[BUG] msi installer shows an error trying to close processes from previous crc version

Tested on version  1.29.0 trying to upgrade a previous version with msi installer.
The environment has a cluster 1.28.0 running, trying to upgrade directly running the msi installer, we got an error saying the installer is not able to close the crc related processes from previous version.
After click ok on the error clicking again to remove the processes finish successfully

Not sure , it it is expected to run crc cleanup in the middle of this process, but from the installer run I expect everything could be handle from it. But now I saw after the installer finish it request to restart and finish the crc setup.
Everything went well but then when I go to the tray to start the cluster. The initial state is showing running. I guess something related with missing data on CRC home folder?

Now looking at status and logs I get
Checking if vsock is correctly configured
Bundle 'crc_hyperv_4.7.18' was requested, but the existing VM is using 'crc_hyperv_4.7.13'

So it seems tray 1.29.0 is managing cluster 1.28.0

It is expected to show an warning message if the tray is already running when user tries to install using msi, it attempts to kill the tray process and if its able to kill it the installation continues and if it cannot you have to kill it manually and you're either able to continue or will have to restart the installation.
For the issue in https://github.com/code-ready/crc/issues/2534#issuecomment-874588286 created #2537


Create decimal or fraction button

Or at least have them all match

It has been decided that decimals are a waste of effort, mixed numbers will be the default


Make license formatting match GitHub's reference text

GitHub uses the licensee ruby gem to detect the license type of the repository. licensee uses the license texts from choosealicense.com so if the text of your license file differs from their license it will not be recognized. GitHub allows filtering searches by license type and also shows the license type on the homepage of your repository and when viewing the license page but these features are only available when the license is recognized.
This does NOT change the actual content of the license in any way.

Nicely done! We should probably cancel the same on the thijse repos, to avoid future conflict. @per1234, What do you think?


Pyg datasequence

What does this PR do?

Fixes # (issue)
Before submitting

[ ] Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
[ ] Did you read the contributor guideline, Pull Request section?
[x] Did you make sure your PR does only one thing, instead of bundling different changes together?
[ ] Did you make sure to update the documentation with your changes?
[ ] Did you write any new necessary tests? [not needed for typos/docs]
[ ] Did you verify new and existing tests pass locally with your changes?
[ ] If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

[ ] Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃

Hello @PabloAMC! Thanks for opening this PR.

In the file flash/graph/backbones.py:

Line 30:47: W291 trailing whitespace
Line 49:86: E261 at least two spaces before inline comment
Line 49:87: E262 inline comment should start with '# '
Line 50:121: E501 line too long (154 > 120 characters)
Line 54:1: E302 expected 2 blank lines, found 1
Line 54:82: E261 at least two spaces before inline comment
Line 54:83: E262 inline comment should start with '# '
Line 55:121: E501 line too long (204 > 120 characters)
Line 55:196: E251 unexpected spaces around keyword / parameter equals
Line 55:198: E251 unexpected spaces around keyword / parameter equals
Line 57:121: E501 line too long (193 > 120 characters)
Line 59:1: E302 expected 2 blank lines, found 1
Line 59:84: E261 at least two spaces before inline comment
Line 59:85: E262 inline comment should start with '# '
Line 60:105: E251 unexpected spaces around keyword / parameter equals
Line 60:107: E251 unexpected spaces around keyword / parameter equals
Line 64:1: E266 too many leading '#' for block comment
Line 65:1: E302 expected 2 blank lines, found 1
Line 65:80: E261 at least two spaces before inline comment
Line 65:81: E262 inline comment should start with '# '
Line 70:1: E302 expected 2 blank lines, found 1
Line 70:81: E261 at least two spaces before inline comment
Line 70:82: E262 inline comment should start with '# '
Line 71:121: E501 line too long (169 > 120 characters)
Line 73:121: E501 line too long (132 > 120 characters)
Line 75:1: E302 expected 2 blank lines, found 1
Line 75:84: E261 at least two spaces before inline comment
Line 75:85: E262 inline comment should start with '# '
Line 80:1: E305 expected 2 blank lines after class or function definition, found 1
Line 80:121: E501 line too long (123 > 120 characters)
Line 87:1: E302 expected 2 blank lines, found 1
Line 87:80: E261 at least two spaces before inline comment
Line 87:81: E262 inline comment should start with '# '
Line 92:1: E302 expected 2 blank lines, found 1
Line 92:79: E261 at least two spaces before inline comment
Line 92:80: E262 inline comment should start with '# '
Line 97:1: E302 expected 2 blank lines, found 1
Line 97:78: E261 at least two spaces before inline comment
Line 97:79: E262 inline comment should start with '# '
Line 102:1: E302 expected 2 blank lines, found 1
Line 102:79: E261 at least two spaces before inline comment
Line 102:80: E262 inline comment should start with '# '
Line 105:41: W292 no newline at end of file

In the file flash/graph/data.py:

Line 20:1: E402 module level import not at top of file
Line 22:1: E402 module level import not at top of file
Line 23:1: E402 module level import not at top of file
Line 24:1: E402 module level import not at top of file
Line 29:121: E501 line too long (147 > 120 characters)
Line 32:1: E302 expected 2 blank lines, found 1
Line 42:1: E302 expected 2 blank lines, found 1
Line 54:1: W293 blank line contains whitespace
Line 78:46: E261 at least two spaces before inline comment
Line 78:47: E262 inline comment should start with '# '
Line 81:48: E261 at least two spaces before inline comment
Line 81:49: E262 inline comment should start with '# '
Line 81:121: E501 line too long (154 > 120 characters)

Do see the Hitchhiker's guide to code style


Use Singleton Type for keepAlive in client endpoint configuration

Description:
$subject.

Fixed with: https://github.com/ballerina-platform/ballerina-lang/pull/7135


Support double-sided slides

We would like to scan both sides of a some microscope slides slides. For the slide-scanner pilot, this applies to between 50 and 100 slides per week. Reverse images lack the barcode and other information required to such as location and taxonomy, presenting a substantial challenge when entering metadata.

Duplicate of #171


WIP: Add weavenet cni option

This Pr allows to replace flannel by weavenet. Weave-net plugin allows NetworkPodPolicy.
Tested on hugernetes.yml with this operator :
 - type: remove
  path: /instance_groups/name=node/jobs/name=net-flannel
- type: remove
  path: /instance_groups/name=control/jobs/name=net-flannel

- type: replace
  path: /instance_groups/name=control/jobs/name=runtime-runc/properties/cni
  value: weavenet
- type: replace
  path: /instance_groups/name=node/jobs/name=runtime-runc/properties/cni
  value: weavenet

- type: replace
  path: /instance_groups/name=control/jobs/-
  value:
    name: net-weavenet
    release: k8s

- type: replace
  path: /instance_groups/name=job/jobs/-
  value:
    name: net-weavenet
    release: k8s

This one looks okay from a cursory review of the code changes; I will try to take this for a spin in my lab this week to suss out any issues.

it works fine


Tab label not translatable

I mix interface & domain translations as described here
https://github.com/marmelab/admin-on-rest/blob/master/docs/Translation.md
For List I get "Stations", for Tab "APP.STATIONS"
    <Tabs>
    <Tab label="app.stations">
        <List title="app.stations" {...props}>

Environment

Admin-on-rest version: 1.4.0

That's because the Tab component from admin-on-rest is different from the one supplied by material-ui and should only be used insided a TabbedShowLayout.
Here you're mixing Tabs from material-ui and Tab from admin-on-rest.
Can you describe your use case ?

Please share a larger part of your code. We need to know:

where are you using a tab (in the Edit view? in the Show view?)
where did you import the Tab from (admin-on-rest? material-ui?)

My bad, used Tabs from material-ui, will try TabbedShowLayout instead


Comprehensive tests for transform UI

This needs comprehensive tests.
Originally posted by @simonw in https://github.com/simonw/datasette-edit-tables/pull/14#issuecomment-700322455

I think convert column to REAL doesn't work. Tests should confirm this one way or the other.

Yes there was a bug there, just fixed it.


[feature] create hero header section

Fixes Issue
Closes #77
Changes proposed
This PR fulfills the following requirements:

[x]  Create a component named HeroHeader in the components folder that implements the screenshots/design given.
[x]  It should make use of the existing Navbar component - feel free to adjust the Navbar component to match the requirements in this ticket.
[x]  The menu items are anchor links which should smoothly scroll to the relevant section when clicked.
[x]  Reuse the Logo and Button components.
[x]  Include the component in index.page.tsx.
[x]  Create a new test file in the e2e folder named hero-header.spec.ts and add a test that verifies that clicking each of the 5 links in the component navigates to the correct URLs.
[x]  When the "About Us" menu is clicked, the URL changes to /#about-us.
[x]  When the "Events" menu is clicked, the URL changes to /#events.
[x]  When the "Contact" menu is clicked, the URL changes to /#contact-us.
[x]  When the "Join Community" button is clicked, the page opens https://bit.ly/joinreactdevske in a new tab.
[x]  When the "Join ReactDevsKE" button is clicked, the page opens https://bit.ly/joinreactdevske in a new tab.
[x]  The implementation should match the design - text content, typography, capitalization and spacing.
[x]  The UI should be responsive and work well on both desktop and mobile viewports.
[x]  The hero-header.spec.ts test should pass on both Chrome, Firefox and Safari.

Check List (Check all the applicable boxes)

[x] My code follows the code style of this project.
[ ] My change requires changes to the documentation.
[ ] I have updated the documentation accordingly.
[x] All new and existing tests passed.
[x] This PR does not contain plagiarized content.
[x] The title of my pull request is a short description of the requested changes.

Screenshots
Hero Header on Large Screen

Hero Header on Mobile Screens

Passing Tests

Note to reviewers

In the design the mobile version has a link to github while the desktop version doesn't. Is this the design or is it an omission?
I made an adjustment on the DropdownMenu. The design places the close icon/button in almost the same line as the About us link. This, in my view, would precipitate a situation whereby a user accidentally clicks on the About us link with the intention of clicking the close button and vice-versa. Similarly, since the design does not explicitly show the interaction between the HeroHeader and the DropdownMenu I opted to move the close button to display where the menu icon shows and toggle them accordingly. I welcome your thoughts on this approach.
I added a box shadow on the DropdownMenu to differentiate it from the rest of the page as they have the same background color.

In the design the mobile version has a link to github while the desktop version doesn't. Is this the design or is it an omission?

I would say it is an inconsistency in the design. We should address it in another round of contributions. Thanks for pointing it out.

I made an adjustment on the DropdownMenu. The design places the close icon/button in almost the same line as the About us link. This, in my view, would precipitate a situation whereby a user accidentally clicks on the About us link with the intention of clicking the close button and vice-versa. Similarly, since the design does not explicitly show the interaction between the HeroHeader and the DropdownMenu I opted to move the close button to display where the menu icon shows and toggle them accordingly. I welcome your thoughts on this approach.

Looking good. Thanks 👍

I added a box shadow on the DropdownMenu to differentiate it from the rest of the page as they have the same background color.

👍


add nats

NATS is an open-source, high-performance, lightweight cloud messaging system.

Thanks, I've just merged the other PR adding NATS (https://github.com/strzalek/queues.io/pull/77)


resolve stack trace from being raised if a 404 is triggered (and caus…

…ing a 500 return)
For example in the case of the browser requesting a favicon:
(env) aaron@earl:~/code/apod-api$ python apod/service.py

Serving Flask app "service" (lazy loading)
Environment: production
WARNING: This is a development server. Do not use it in a production deployment.
Use a production WSGI server instead.
Debug mode: off
INFO:werkzeug: * Running on http://<IP_ADDRESS>:5000/ (Press CTRL+C to quit)
INFO:werkzeug:<IP_ADDRESS> - - [29/Aug/2019 23:43:17] "GET / HTTP/1.1" 200 -
ERROR:service:Exception on /favicon.ico [GET]
Traceback (most recent call last):
File "/home/aaron/code/apod-api/env/local/lib/python2.7/site-packages/flask/app.py", line 2446, in wsgi_app
response = self.full_dispatch_request()
File "/home/aaron/code/apod-api/env/local/lib/python2.7/site-packages/flask/app.py", line 1951, in full_dispatch_request
rv = self.handle_user_exception(e)
File "/home/aaron/code/apod-api/env/local/lib/python2.7/site-packages/flask_cors/extension.py", line 161, in wrapped_function
return cors_after_request(app.make_response(f(*args, **kwargs)))
File "/home/aaron/code/apod-api/env/local/lib/python2.7/site-packages/flask/app.py", line 1815, in handle_user_exception
return self.handle_http_exception(e)
File "/home/aaron/code/apod-api/env/local/lib/python2.7/site-packages/flask/app.py", line 1743, in handle_http_exception
return handler(e)
File "apod/service.py", line 268, in page_not_found
LOG.info('Invalid page request: ' + e)
TypeError: cannot concatenate 'str' and 'NotFound' objects
INFO:werkzeug:<IP_ADDRESS> - - [29/Aug/2019 23:43:17] "GET /favicon.ico HTTP/1.1" 500 -

Please note that there are a number of unrelated whitespace cleanups due to my text editor's default settings.

I hadn't realised that @Calibrator had already got a fix for this, once that is merged I will rebase this on top to pick up my unit test to guard against regression.

FYI - code was reorganized a little to make it run nicely on new server setup on AWS...  Appreciate any help re-adding these changes to the code.

@JustinGOSSES, I've redone the change based on the new structure.
I have manually verified that my browser doesn't cause an exception to be raised when it attempts to retrieve a non-existent /favicon.ico.
However I've had some difficulties verifying the unit test functions correctly. I've been unable to run it or the existing tests (due to import errors).
Might I have some assistance checking that they work?

tests need redone

Approving as the fix to favicon works.
A wider fix to tests is needed but I won't let ie hold up this improvement.


[.NET] Arabic Duration support

All test cases pass extraction.
26 cases pass resolution.
Some of the duplicate test cases that were previously removed have been reintroduced with variations.

@LionbridgeCSII, could we get a doc report explaining the edits in the spec cases? At least for the majority of cases?
This may help in the future with the language expansion process.


Fix 2nd place where installer checks compiler ver.

Avg response time
coverage on master

Summary of changes
Update prerequisites/install-functions/find_or_install.sh so that the 2nd place where the compiler version is checked now passes the new argument expected by acceptable_compiler.f90.
Rationale for changes
Invoking ./install.sh with no arguments traverses a previously untested branch through the above script.  That branch's invocation of the executable program acceptable_compiler lacked the new argument that was added to that program in the most recently merged pull request.
Additional info and certifications
This pull request (PR) is a:

[X] Bug fix
[ ] Feature addition
[ ] Other, Please describe:

I certify that

[X] I reviewed and followed the contributing guidelines, including
- Increasing test coverage for all feature-addition PRs
- Increasing test coverage for all bug-fix PRs for which there
does not already exist a related test that failed before the PR
- At least maintaining test coverage for all other PRs
- Ensuring that all tests pass when run locally
- Naming PR  to indicate work in progress (WIP) and to attach the PR
to the appropriate bug report or feature request issue
- White space (no trailing white space or white space errors may
be introduced)
- Commenting code where it is non-obvious and non-trivial
- Logically atomic, self consistent and coherent commits
- Commit message content
- Waiting 24 hours before self-approving the PR to give another
OpenCoarrays developer a chance to review my proposed code

Merging this one as obvious.


Data generation

Use Synthea to create a cohort of 1000+ patients

be sure to document build and run commands and put in the repo
inspect synthetic dataset to ensure it has enough asthma-related phenotypes/codes
include good asthma example dataset in the repo once we've found one
output as both FHIR and CSV

Hello @susheel @PhilipvD I have added the build and run instructions in the README for generating the population in both FHIR and CSV. Unfortunately I was getting errors trying to upload the actual generated population since the files are too big but I did have some questions regarding some of the results. I believe we discussed this morning that the coding should be in ICD-10 however I am seeing that the output uses snomed codes instead. I tried to do some research but as far as I could see ICD-10 was not supported by Synthea. Would the mapping from snomed to ICD-10 come at a later step or am I missing something? I have attached a generated patient with asthma below.
{"resourceType":"Condition","id":"17556412-0356-de55-eb68-2cc2bebcaf8c","meta":{"profile":["http://hl7.org/fhir/us/core/StructureDefinition/us-core-condition"]},"clinicalStatus":{"coding":[{"system":"http://terminology.hl7.org/CodeSystem/condition-clinical","code":"active"}]},"verificationStatus":{"coding":[{"system":"http://terminology.hl7.org/CodeSystem/condition-ver-status","code":"confirmed"}]},"category":[{"coding":[{"system":"http://terminology.hl7.org/CodeSystem/condition-category","code":"encounter-diagnosis","display":"Encounter Diagnosis"}]}],"code":{"coding":[{"system":"http://snomed.info/sct","code":"195967001","display":"Asthma"}],"text":"Asthma"},"subject":{"reference":"Patient/9e6e8477-46ce-c5e2-8e2f-43298c3fe684"},"encounter":{"reference":"Encounter/d588f220-d088-9e19-9e3f-4020d27136c6"},"onsetDateTime":"2016-06-21T20:17:55-04:00","recordedDate":"2016-06-21T20:17:55-04:00"}
Also if either of you have a solution for uploading large files to git please let me know and I will upload the "output" folder I was able to generate from synthea.

@susheel @PhilipvD another couple questions about the demo:

The Synthea run outputs a total of 22 .ndjson files, each containing a batch of records of a certain model. Here are the models: AllergyIntolerance, CarePlan, CareTeam, Claim, Condition, Device, DiagnosticReport, DocumentReference, Encounter, ExplanationOfBenefit, ImagingStudy, Immunization, Medication, MedicationAdministration, MedicationRequest, Observation, Patient, Procedure, Provenance, SupplyDelivery, hospitalInformation, practitionerInformation

Can we pull out a core set of models that are most relevant to the CQL demo (i.e. Patient, Condition, and others) rather than uploading the whole lot to HAPI? A dataset of 1000 Patients yields, for example, 100,000 DiagnosticReport records. It will simplify the demo and make it easier to rerun if the overall dataset to upload is small.

An additional way to pare down the uploaded dataset. The 1000 Patient dataset contains ~20 asthma patients. Since these 20 are the focus of the CQL query, can we remove a lot of the "patients" we're not interested in querying? E.g. Could we upload all 20 asthma patients and only 80 non-asthma patients, rather than 20 vs 980?

Picking up a couple of things...
First on Jeremy's #1 above. Yes it would be to good decide which Resources (what J is calling models) we want (or are necessary) to work with  for our use case. How did Synthea decide what to generate? Was that driven by our choice? e.g. some config file that controlled the generation?
Second, @Chen2x - did you solve the generation to both FHIR and csv? Does the same set of Patients get saved to both? If we can do that I don't need to bother working out how to read the FHIR files for the purposes of loading into Data Connect - I can just use the csv's. That's the point I think Susheel made at the kick-off.


Change "import your pgp key" to the pgp fingerprint once user has imported pgp key

pending expo eject

Given a PGP user,
When I setup my PGP key
Then I see my PGP Finger print on my profile page

Property on the PGP type added here https://github.com/dltxio/idem-mobile/blob/IDEM-10/app/src/types/wallet.ts#L9

See getFingerPrint method at https://docs.openpgpjs.org/Key.html

pending expo eject

expo ejected!

Will be fixed with #9

OpenPGP.convertPrivateKeyToPublicKey(privateKey) not working well, only can got half of the public key, disabled the import button for now and reported on library github.

y

Seems like this got merged already

Getting an undefined

Generate new PGP disabled still even after required information is added

Does not show fingerprint it I "import my private key"
does not show fingerprint if I "Generate new PGP key"

It only works after a claim is made/ saved again. Doesn't work initially after setting up pgp key

Doesn't generate correct fingerprint

All caps and remove spaces. Should look like 1F8D106A

Still experiencing the same problem as Mitch's comments


How to Generate merged_frozen_graph_FILE.pb

After training the Image Captioning by using main.py.
Generated the
model.ckpt-42903.data-00000-of-00001
model.ckpt-42903.index
model.ckpt-42903.meta
how generate the merged_frozen_graph_FILE.pb from it
Any help would be appreciated.

The instructions are under the "Miscellaneous Notes" section of the readme. Freeze the encoder and decoder graphs as instructed and then use utils/merge_graphs.py, with --read_file flag to generate the said file.
Does that answer your question?

Most likely resolved, closing due to inactivity.


Timesheet - 21/04/2021 - Jesus Avina

Task 1
Discussing core team feedback of 20/04/2021 with team members.
Proof of Work

Private messages

Time Spent
1 hour

Task 2
Meeting with Kristy over tokenomics and projects.
Proof of Work

Private message

Time Spent
1 hour

Task 3
Created a document on google docs for a practice team review for the team to start on.
Proof of Work

Private message, document private

Time Spent
.5 hours

Task 4
Google Meet with Manish over projects and the audit process
Proof of Work

Google Meet, Private Message

Time Spent
.5 hours

Total Time Spent
3 hours
Account Number
f37aaaa15fe0cec8e7cf1809cc884610122c5d8886486b6c2492555229442a46

Approved


Update API to match changes made in February

Changelog shows some new hotness added at the end of February, this is a note to self to add the new endpoints and other goodies. As this includes adding 2 new endpoints, I will move the version to 2.1.0 when I push this up.

Closing in favor of #132 that indicates the requirements more specifically


Releases: add 0.20.1

Todos:

[x]  Update dates (rename the _posts file and edit the YAML date field in the _releases file)
[x]  Optional: add magnet link to the _releases file

Note: tests expect to fail until the binaries have been uploaded to /bin/. After that's done, restart Travis and it should pass.
CC: Sjors to whitelist the magnet hash on his torrent tracker (e.g. https://github.com/bitcoin-core/bitcoincore.org/pull/698#issuecomment-596678739 )

I don't think this deployed yet? I'm not seeing 0.20.1 on the download page or in the release list.

@Sjors fixed now.  (Thanks to whoever fixed it, probably @TheBlueMatt)


Reduce the package size by remove the he dependency

Description
Are we possible to remove the he and use this method (link to Stackoverflow) to decode HTML entities? This could reduce the package size about 75%. This package is only for browser so this will be possible in my opinion.
Steps to reproduce

Expected Behavior

Actual Behavior

Metadata
Typsense Version:
OS:

@DanSnow Thank you for pointing this out. I just removed he as a dependency and the size went down to 13KB from 43KB!
I published this change as v1.1.0-0. Could you give it a shot and let me know how it goes?

Published this in v1.1.0


how to drag and drop in resium

Hi,
I need help, I have created many entities that can be moved using ScreenSpaceEventHandler and it works, but now I have ScreenSpaceEventHandler associated with each entitу, which means when I create a new entitу I have a new ScreenSpaceEventHandler created... As I understand it is a globаl event, and when i created 1000 entitу i have 1000 ScreenSpaceEventHandler , and my application start to freeze. I think that this is related to a lot of created global ScreenSpaceEventHandler, that is what affecting the performance.
Can you explain to me what is the right way to manage this ScreenSpaceEventHandler, because each of them has its own function...
After that I tried to use events on the entity itself (as onMouseMove etc.) but when I move the mouse quickly the mouse moves away from the entity area and the event stops running, can you please help what I am doing wrong.
Thanks in advance...

Check https://github.com/reearth/cesium-dnd


Create a common "update" group supporting self-update options (via pdtm?)

Example syntax from https://github.com/projectdiscovery/httpx/issues/946:
   -up, -update                 update project to the latest released version
   -duc, -disable-update-check  disable automatic update check

The option should just notify the user of a new version availability and no update should happen automatically.
Note: the library aims to be generic, so the self-update mechanism should be abstracted enough to accept a custom endpoint, support semantic versioning and it should be optional
Ref:

Discussed with @tarunKoyalwar
https://github.com/projectdiscovery/team-backlogs/issues/243
https://github.com/projectdiscovery/httpx/issues/946
https://github.com/projectdiscovery/nuclei/issues/3285

@Mzack9999 ,since directly importing pdtm won't be possible (cyclic import) . How about we add a callback options instead and let developer manage it and Create a helper function that returns a callback options in pdtm.
flagSet.AddUpdateGroup(toolName string, UpdateCheckCallback func, UpdateCallback func)

In pdtm
we add public function that returns above callbacks
func GetUpdateCheckCallback(toolName ,toolVersion string)  func() { xxx }

func GetUpdateCallback(toolName string) func()  {}

and we can also add other options to this UpdateGroup with their respective callback functions . Ex: nuclei-templates and fuzzing templates

@tarunKoyalwar that's a valid point. I believe that a good part of the pdtm logic (eg. paths, CRUD in files) are generic and reusable enough to be moved into utils, probably at the point that pdtm doesn't even need a runner folder, but just use the same callbacks mechanism of goflags (let's remember that also pdtm is another tool of the potential update list, likely without delete/install overridden callbacks).
I second the the proposal of a generic update group, which will allow handling uniformely templates of various type.


Add ImportStatePassthrough to resources

This should work fine, allowing users to run an import towards all resources based on their existing UUID, for example:
terraform import cloudstack_vpc.my_vpc <id>

Tested with Apache CloudStack 4.11 and Cosmic 6.1.14, with both local tfstate files and S3 as backend.

@romerojunior I'm going to close this PR in favour of PR #47
PR #47 adds import support for resource that do not require custom logic and it adds tests to make sure importing works as expected. The resources that I omitted are resources that need custom logic and that not passed the tests.
If you want to take another stab at adding support of importing resources that are not part of PR #47, then please make sure you add an import test as the ones I also added in PR #47 to make sure the import logic works as expected.
Thanks!


Update workbox-sw.js

Fixes #839
R: @jeffposnick

Reminder per team sync: let's file an issue to track adding in automated tests for this in V3

(Just doing some manual testing to make sure that those changes are sufficient.)

See https://github.com/GoogleChrome/workbox/issues/839#issuecomment-334274338


Check requested resources are valid

Disallow paths leading outside of the rask directory.
This is not urgent, since the paths are compile time constant and not send by the client

the checking can be implemented in the rask-server/src/games.rs

somewhat obsolete due to #79


chore(flagsmith): bump provider version

This PR

bump flagsmith client version
PS: release notes for the flagsmith client are available here

Related Issues

N/A
Notes
N/A
Follow-up Tasks
N/A

How to test
Covered by unit tests

This is broken due to https://github.com/open-feature/go-sdk-contrib/issues/285


feat(extension): open im-modal on click

This commit has the ExtensionApp accept an apiKey string prop. It then
passes that prop onto the AssetBrowserContainer inside a Modal
component. The modal only opens once the user has clicked on one of the
buttons inside the ProductImageContainer.

Current dependencies on/for this PR:

next

PR #256

PR #258   (this PR)

PR #259

PR #257

This comment was auto-generated by Graphite.

Graphite Merge Job
Current status: ⏳ Queued to merge
This pull request is currently queued to be merged as part of a stack.
This comment was auto-generated by Graphite.

Job Reference: 6cwJaETgMG17vfBY88e2


Column Headers on FluentGrid Control Do Not Render Properly with Horizontal Scroll

🐛 Bug Report

💻 Repro or Code Sample

🤔 Expected Behavior

😯 Current Behavior

This is not a bug report we can or want to work with. No reproduction code or steps, no environment information, no cause or proposed solution.
Closing this. Feel free to try again with a complete one.


Requested a reward [pixs.]

Guild id<PHONE_NUMBER>375438888 | 𝓅𝓇ℯ𝓉𝓉𝓎 𝒾𝓃 𝓅𝒾𝓃𝓁🫧
Member id<PHONE_NUMBER>53735561
Locale English (United States)
Nickname simies
Горячий кофе - 6 шт. | Hot coffee - 6 pcs.

Unfortunately, gifts are only available in Russia and the CIS


NETC-62 Prevents proxyCallbackUrl from being rewritten by default configuration

When specifying an explicit proxyCallbackUrl in Web.config:
https://app.example.com/Account/ProxyCallbackUrl?proxyResponse=true
The base path should have been /Account/ProxyCallbackUrl but instead was being rewritten as /Account/CurrentMethod where CurrentMethod could be any route the client is currently browsing. The corresponding error in cas.log then becomes:
InvalidProxyChainTicketValidationException: Invalid proxy chain: [https://app.example.com/Account/Restricted?proxyResponse=true]
The proposed file change effectively "scopes" the setting of the base path when and only when no CasAuthentication.CasProxyCallbackUrl has been specified and resolves the issue:
[org.jasig.cas.client.validation.Cas20ProxyReceivingTicketValidationFilter] - Successfully authenticated user: jdoe

:+1:

Thanks!

:thumbsup:


Add m2 cache to fast premerge build

Sometimes premerge build took much longer time than normal because of unstable network connection. This PR enables leveraging pre-created m2 cache to minimize such impact to fast premerge build. The pre-created m2 cache were removed snapshot or plugin related jars/xml in order to eliminate potential side effects. Please refer to job 'update_premerge_m2_cache' on Blossom about building m2 tarball details. (if necessary this pre-created m2 cache could be updated regularly)

build

m2 cache were removed snapshot or plugin related jars/xml in order to eliminate potential side effects.

Does it also remove cudf jars?

m2 cache were removed snapshot or plugin related jars/xml in order to eliminate potential side effects.

Does it also remove cudf jars?

yes, it's removed including every file from ~/.m2/repository/ai/


⚠ Quirk Club Argentina (API endpoint) has degraded performance

In 146ad0b, Quirk Club Argentina (API endpoint) (https://us-central1-quirkclub-dev.cloudfunctions.net/api/check/api) experienced degraded performance:

HTTP code: 200
Response time: 7464 ms

Resolved: Quirk Club Argentina (API endpoint) performance has improved in 65a90de.


Add Windows Support: Replace fcntl with Windows-Compatible Alternative

Hello,
I am trying to run the project on a Windows machine, but I encountered the following error:
ModuleNotFoundError: No module named 'fcntl'
The fcntl module is not available on Windows, as it is specific to UNIX-based systems (Linux/macOS). Could you please add support for Windows by either replacing fcntl with a compatible alternative or using conditional imports that only load fcntl on UNIX systems?
Thank you!

@krondelsina hello, can you provide the minimal not working code that you have?

Try latest version - I switched to use uvicorn (instead gunicorn) on win32

Still unable to run on Windows, creating a docker container also doesn't work as it has issues finding the files in their respective directories (mainly .sh files). Any chance you could publish the container to docker so we could download it directly? Building it doesn't seem to work for me. I'm going to try it in WSL, which I'm sure will work, but it would be nice to not have to.

Please try latest version
This commit should help (I tested after it version on windows)


[Unity] Fix IndexDataTypeNormalizer so that it correctly handles corner case

There is a corner case: A[i] = i for IndexDataTypeNormalizer. In current implementation, the var in buffer index will be rewritten, but the var in BufferStore value will not, which cases a conflict and produces free var. I change it to two iterations: the first collects var_remap_, and the second rewrites vars, so that in A[i] = i, both var will be rewritten.

cc: @tqchen


Add elements to Notice XML with agency info from Federal Register metadata.

Something to consider: this parses the data into the XML, but never reads it back. It might be worthwhile to write that "read" function and remove the explicit tests around the XML -- just verify that you can read what you wrote.

:shipit:


add language server debugging configuration

I want to debugging language server process.
This settings will be able to it.
I would like to know if we have other better way.

@vvakame,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by Microsoft. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot

wow, I found #32 now..

This example is deprecated. Use the language server samples in this repository instead: https://github.com/Microsoft/vscode-extension-samples


Cleanup duplicate "section" classes

Remove the section class selector from NFTHeader, TokenHeader and AccountHeader. Put this class into a shared file. However there is a behavior, that, when we remove all of the section, the tab inside Account will be left aligned(will need do more investigation and make sure its not occurring when doing the cleaup)

Rename the section under detailTab.scss , and all of its occurances

Fixed in #219

Reponed, didnt fix it


Investigate best method to communicate with UI(s) from augur-state

More of a spike - look into

How to get augur-state to talk to clients via websockets
How to get augur-state to talk to in-browser UI(s)
Best interface for http, ws, and in browser communication overall

The answer is "connectors" which will be implemented in issue #2086.


Skip test AssemblyPartTest.GetReferencePaths_ReturnsReferencesFromDependencyContext_IfPreserveCompilationContextIsSet

Workaround for "Can not find compilation library location for package" (https://github.com/dotnet/cli/issues/6318)

@mikeharder,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by .NET Foundation. We will now review your pull request.
Thanks,
.NET Foundation Pull Request Bot


Add abiliy to delete files

Unfortunately boto3 doesn't actually tell you if the deletion was successful or not:
https://github.com/boto/boto3/issues/759

Working by https://github.com/prominence-eosc/prominence/commit/2c17fd2bc3ebb11a65d2e9b73e77c0cafa99a69d

However note that it always returns "Success" as boto3 doesn't actually provide any meaningful information when deleting objects.


Type safe ECS queries

This PR partially covers the second part of #5

[x] Some way of getting access to components in a type safe way from Rust.
[x] Optionally get handle to Entity with query

Moved to #32


Update ci-cd for PR merged

Type of PR

[ ] Documentation changes
[ ] Code changes
[ ] Test changes
[x] CI-CD changes
[ ] GitHub Template changes

Purpose of PR

updated ci-cd to not build on PR merge

Issues Closed or Referenced

References retaildevcrews/helium#518

after I merge to master I'm going to create the main branch and change the default branch to main.


NameError: name 'self' is not defined

Hey I am a beginner in python and I tried your chanim library and it does not work for me. Also it compiles some of your tests as seen in the first 2 lines.
The output I get is:
[4]H-C(-[2]H)(-[6]H)-C(-[2]H)(-[6]H)-OH
[4]H-C(-[2]H)(-[6]H)-COOH
Traceback (most recent call last):
File "C:\Users<username>\Anaconda3\envs\math_venv\lib\runpy.py", line 193, in _run_module_as_main
"main", mod_spec)
File "C:\Users<username>\Anaconda3\envs\math_venv\lib\runpy.py", line 85, in run_code
exec(code, run_globals)
File "D:\AutomatisierungSubgroupstuff\Python\Real_Prog\manim_projects\manim.py", line 5, in
manimlib.main()
File "D:\AutomatisierungSubgroupstuff\Python\Real_Prog\manim_projects\manimlib_init.py", line 11, in main
config = manimlib.config.get_configuration(args)
File "D:\AutomatisierungSubgroupstuff\Python\Real_Prog\manim_projects\manimlib\config.py", line 185, in get_configuration
module = get_module(args.file)
File "D:\AutomatisierungSubgroupstuff\Python\Real_Prog\manim_projects\manimlib\config.py", line 180, in get_module
spec.loader.exec_module(module)
File "", line 728, in exec_module
File "", line 219, in _call_with_frames_removed
File "FLN_color.py", line 43, in
class Chem(Scene):
File "FLN_color.py", line 45, in Chem
self.play(Write(Ass))
NameError: name 'self' is not defined

My Code:
from manimlib.imports import *
from chanimlib.imports import *
class Chem(Scene):
test = ChemObject("A-B")
self.play(Write(test))

Also your ChemObject() class has no init() function.

Hello!
The reason you're getting the first error is because you're writing a Manim Scene wrong. You have to write it like this, with the animation code in a construct function:
class Chem(Scene):
    def construct(self):
        test=ChemObject("A-B")
        self.play(Write(test))

As for an __init__ function, the reason for that is because ChemObject inherits everything from TexMobject while changing a few properties (the CONFIG stuff) so you don't have to worry about that.
Also, that chemfig code that comes at the top shouldn't be there, sorry. That was because of me trying to provide some out of the box shorthands for common compounds. I've begun work on cleaning up this repo so you won't have to worry about that in the future.
(P.S. sorry for a late reply)


test: small serialization test of u256 into json

Added a small test of the serialization of a u256 into json

Codecov Report

Merging #991 (5209e6f) into main (c7289bd) will increase coverage by 0.15%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #991      +/-   ##
==========================================
+ Coverage   74.01%   74.16%   +0.15%
==========================================
  Files         294      294
  Lines       32564    32557       -7
==========================================
+ Hits        24102    24146      +44
+ Misses       8462     8411      -51

Flag
Coverage Δ

unit-tests
74.16% <100.00%> (+0.15%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

crates/primitives/src/jsonu256.rs
83.33% <100.00%> (+12.14%)
:arrow_up:

crates/transaction-pool/src/test_utils/mock.rs
53.11% <0.00%> (-6.60%)
:arrow_down:

crates/transaction-pool/src/pool/txpool.rs
58.87% <0.00%> (-0.50%)
:arrow_down:

crates/net/rpc/src/net.rs
0.00% <0.00%> (ø)

crates/primitives/src/net.rs
94.68% <0.00%> (+0.53%)
:arrow_up:

crates/primitives/src/chain.rs
93.87% <0.00%> (+3.06%)
:arrow_up:

crates/primitives/src/chain_spec.rs
81.51% <0.00%> (+7.72%)
:arrow_up:

crates/net/rpc/src/result.rs
29.16% <0.00%> (+10.07%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Should probably be a fuzz test, but not sure how it works cc @joshieDo

@xqft (or anyone else): if you want to add proptests (fuzz), you need to add one attribute  to the type: #[derive_arbitrary]. This will allow you to then add a roundtrip test similar to:
https://github.com/paradigmxyz/reth/blob/6f047a5de0c3b8ebfad5033b0139856a98cd0955/crates/primitives/src/hex_bytes.rs#L362-L372
If, we have many types which require json roundtrip tests, then it might be better just adding that logic to the derive_arbitrary macro itself (just like rlp, and compact have) and eventually remove the roundtrip test above and just modify the macro to derive_arbitrary(json):
https://github.com/paradigmxyz/reth/blob/6f047a5de0c3b8ebfad5033b0139856a98cd0955/crates/storage/codecs/derive/src/arbitrary.rs#L20-L48


/kits rank requirement typo

/kits states that in order to unlock the Origin weekly kit you require the rank of Master when it should state the requirement as Origin

Fixed


SCB-1099 Add nexus SNAPSHOT information to the README repo

Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Make sure there is a JIRA issue filed for the change (usually before you start working on it).  Trivial changes like typos do not require a JIRA issue.  Your pull request should address just this issue, without pulling in other changes.
[ ] Each commit in the pull request should have a meaningful subject line and body.
[ ] Format the pull request title like [SCB-XXX] Fixes bug in ApproximateQuantiles, where you replace SCB-XXX with the appropriate JIRA issue.
[ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[ ] Run mvn clean install to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

Coverage remained the same at 90.989% when pulling 29fb450f62703a590bd8a5a3e1786518887888fb on zhanglongchun:SCB-1099 into 026cc09720ef5084d72ec8378bbb779def57777a on apache:master.


accumulated_times, g_accumulated_times, n_critic argument values

It seems that n_critic is redundant, since it can be replaced by accumulated_times = accumulated_times * n_critic.
And the parameters accumulated_times and g_accumulated_times neither are specified in the running script not have default values, so I was wondering which values did you use for training?

Did you solve this problem? I would also like to know the results.


chore: bdd-nh-1587812963 to 0.0.1

chore: Promote bdd-nh-1587812963 to version 0.0.1

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers:
If they are not already assigned, you can assign the PR to them by writing /assign  in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


programmatically drawing sprites

Rather than creating a sprite and adding it the the running scene, is there a way to programmatically draw sprites on the fly? For example, if I wanted to create a trail effect on a GameObject it would be much easier to do this with a direct draw rather than updating 10 different GameObjects. What would be the best way of doing this for both WebGL and canvas targets?
Thanks,
Nick

Perhaps you could use particles?

I guess that's one option but then I'd need to maintain a map of different particle objects for each kind of sprite I would want to draw. Ideally I want a call like canvas's ctx.drawImage perhaps on the graphics library like graphics.drawImage or graphics.drawSprite

maybe do some stuff pixi?

There's no ability to dump gl draw calls direct onto any kind of object. We have got RenderTexturess on the roadmap but even those would abstract the calls away.

That's fine, I really just want some kind of call from the graphics library or something. Looks like RenderTextures can do what I want -- thanks!


Re-add convenience Flutter gen command

Re-add the convenience Flutter gen command to generate code/FFI bindings and softlink C headers

Where is this being used?

@erdemyerebasmaz we need a single command people can run to generate everything needed for Flutter when developing the SDK. What do you suggest to add?

Where is this being used?

@erdemyerebasmaz we need a single command people can run to generate everything needed for Flutter when developing the SDK. What do you suggest to add?

That command is just bootstrap true true

Where is this being used?

@erdemyerebasmaz we need a single command people can run to generate everything needed for Flutter when developing the SDK. What do you suggest to add?

I'd decouple uniFFI C header file generation from just build-uniffi-swift / make bindings-swift scripts if possible and make it part of gen / bootstrap recipes.

I'd decouple uniFFI C header file generation from just build-uniffi-swift / make bindings-swift scripts if possible and make it part of gen / bootstrap recipes.

Decoupled uniFFI C header file generation from just build-uniffi-swift / make bindings-swift scripts.

we need a single command people can run to generate everything needed for Flutter when developing the SDK.

Created a single command, just build recipe to build the uniFFI library & generate Dart/Flutter & FFI bindings.
just gen can be used without rebuilding the libraries if there are no structural changes to save development time. It also has an option to skip building iOS framework, just gen false.


Option to modify tiles after loading

Hi,
currently there is no option to modify tiles after they have been loaded from the source, but this is required by my application.
So within the method Drawer.onTileLoad, I added the following code:
// AFTER these 2 existing lines:
tile.loaded = true;
tile.image = image;
// NEW:
if (drawer.fixTile) {
drawer.fixTile(drawer, tile);
}
This initially is only a fast way to do nothing, because fixTile is not defined.
By adding the following code, the client-site tile modification becomes possible.
window.OpenSeadragon.Drawer.prototype.fixTile = Xxxx.prototype.fixTile;

But my fixTile method produced a canvas context instead of the original image. So another change was needed.
This is within Drawer.drawCanvas.
The original code was producing a canvas context from the image anyway. Now this is done earlier, so a slight modification is required:
if (!TILE_CACHE[this.url]) {
	// Is this already a canvas context ?
if (this.image && this.image.lineTo) {
rendered = this.image;
} else {
		canvas = document.createElement('canvas');
	canvas.width = this.image.width;

	canvas.height =  this.image.height;

	rendered = canvas.getContext('2d');

	rendered.drawImage(this.image, 0, 0);
}

TILE_CACHE[this.url] = rendered;
            //since we are caching the prerendered image on a canvas

            //allow the image to not be held in memory

this.image = null;

}
Kind regards
Karl

This now exists (see #348).


Tree: Add getNode method

Add getNode method to Tree component.
There are so many methods on Tree component, such as getCheckedNodes, getCheckedKeys, etc. But all get methods are based on checked or current nodes, so I think it is very useful for adding a getNode method to help users get specified tree node easier.
const parentNodeData = {
  key: 'foo'
}

const parentNode = this.$refs.tree.getNode(parentNodeData)

[x] Make sure you follow Element's contributing guide (中文 | English | Español).
[x] Make sure you are merging your commits to dev branch.
[x] Add some descriptions and refer relative issues for you PR.

Supported in #9718


fix: Inter-catalyst connections blocked due to CORS (#224)

For fixing https://github.com/decentraland/catalyst-owner/issues/224.
Only this one line needs to be added, according to https://nginx.org/en/docs/http/ngx_http_headers_module.html#add_header.
$http_origin works on Heroku; on catalysts, it may be that $CATALYST_URL should be used instead.

Not sure how best to test this.
Currently trying to start the docker environment in Windows (nothing in the docs about that).

Error traces are in the linked issue #224.
This change is for making catalyst servers actually send out the header, so that web browsers can tell the cross-site request was expected.

I just now succeeded in getting the docker container started in Windows, will proceed with testing of this change.

@menduz, $server_name is the variable to use.
Tested with curl.
Before the change:
💲 curl -I localhost/stats/parcels
HTTP/1.1 404 Not Found
Server: nginx/1.22.1
Date: Sun, 14 Apr 2024 15:49:52 GMT
Content-Type: application/octet-stream
Content-Length: 46
Connection: keep-alive
ETag: "660578bb-2e"

{ "ok": false, "error": "404 path not found" }

💲 curl -I localhost
HTTP/1.1 200 OK
Server: nginx/1.22.1
Date: Sun, 14 Apr 2024 15:49:55 GMT
Content-Type: text/html
Content-Length: 4997
Last-Modified: Thu, 28 Mar 2024 14:03:39 GMT
Connection: keep-alive
ETag: "660578bb-1385"
Accept-Ranges: bytes

After the change, the Access-Control-Allow-Origin shows up:
💲 curl -i localhost/stats/parcels
HTTP/1.1 404 Not Found
Server: nginx/1.22.1
Date: Sun, 14 Apr 2024 15:49:25 GMT
Content-Type: application/octet-stream
Content-Length: 46
Connection: keep-alive
ETag: "660578bb-2e"
Access-Control-Allow-Origin: localhost

{ "ok": false, "error": "404 path not found" }

💲 curl -I localhost
HTTP/1.1 200 OK
Server: nginx/1.22.1
Date: Sun, 14 Apr 2024 15:49:06 GMT
Content-Type: text/html
Content-Length: 4997
Last-Modified: Thu, 28 Mar 2024 14:03:39 GMT
Connection: keep-alive
ETag: "660578bb-1385"
Access-Control-Allow-Origin: localhost
Accept-Ranges: bytes

Can you share a real world case of the explorer that is failing? Like a deployment not being able to stream the video

Yes, currently in my scene at 69,-55, it's been like that for weeks.

The flame video won't load and replace the green place-holder texture unless CORS is bypassed.

The video also finally loads when I hop onto the realm served by melonwave.com.

Please provide a link in which the maintainers can click into, to debug the issue. It is weird that this error has never happened before. And even though your PR may fix it, the root cause must be analyzed. Because there are dozens of scenes reproducing video

@menduz, if I understand correctly, the issue I posted on catalyst-owner/issues/224 is the link which you are requesting. But I am still trying to figure out how things work on this github.

I am also realizing I made a wrong assumption (which was hard to see before I cleared my mind by posting the other PRs on my plate). I assumed the code looks for the content on a different catalyst because catalysts also share file storage load.
But of course all the content is on all of the catalysts.

Thus a better long-term solution would be to have the code double-check that content won't be blocked due to CORS, and if it will, to not request it from a different catalyst.
But in the short-term, my PR should work to patch-up the issue.

I have also been getting my mind more and more around the dangers inherent to the XSS technologies that are required in this and in many other projects.
How CORS is meant to work is still rather misunderstood, as can be seen by the number of incorrectly up-voted posts on https://old.reddit.com/r/reactjs/comments/1bjft89/what_is_the_actual_point_of_cors/ and other similar places.
In the end, the issue is that any DCL cookie remaining, in the browser, after a trip to Decentraland, could be used by a bad website visited afterwards, in a bid to fool a catalyst.

@ProteanCoding thank you very much for this PR! I think the change is not by itself wrong, but I think perhaps the CORS issue is a red herring, notice:

The browser may return a cors error for things that are not really cors errors, for example, if a 404 error message has no CORS headers (which you can argue is a CORS error, but that's not the most important problem).
Only the /stats/parcels URL in the issues is from a catalyst, so you will still see the other errors. And for the error in catalyst https://peer.dclnodes.io/stats/parcels such URL does not exist, because that catalyst has no comms. So it's expected to fail.
We usually handle cors inside the apps themselves. It is not the case for that phttps://peer.dclnodes.io/stats/parcelsarticular 404 since that's nginx doing the handling, but for most cases the apps do the trick.

Again, I think we will see less CORS errors with this change, but I don't think it will solve the underline issue you are facing.
In any case it's great to see your contribution and how you are debugging the problem and fixing stuff. Thanks!

Hi @hugoArregui, you're welcome !
My apologies, I've been trying to find the conviction reformulate #224, with more convincing arguments and extra log traces.
I will simply list the extra log traces here.

https://play.decentraland.org/?position=-119,119
15:46:59.850 Cross-Origin Request Blocked: The Same Origin Policy disallows reading the remote resource at https://peer.kyllian.me/content//contents/bafybeielnptdv5uorbbpiiw64yeyq6nkfrpd76rt4hhvjbcranwaln7rdm. (Reason: CORS request did not succeed). Status code: (null).

Regarding the 404 error, it's very misleading, because there actually is a JSON object that is sent as response !
💲 curl https://peer.dclnodes.io/stats/parcels
{ "ok": false, "error": "404 path not found" }


[Bug] SelectedItem Two-Way binding source not changing

Description
SelectedItem Two-Way binding doesn't seem to work, source is not updated upon selecting different segment in SegmentedControl.
Steps to Reproduce
Bound ItemsSource, SelectedItem and 'OnChanged' method are defined in VM like that:
using CommunityToolkit.Mvvm.ComponentModel;
...
        [ObservableProperty]
        ObservableCollection<SoundTypeOption> soundTypeOptions = [
            new SoundTypeOption { Latin = "", Native= "" },
            new SoundTypeOption { Latin = "", Native= "" },
            new SoundTypeOption { Latin = "", Native= "" }
        ];
...
       [ObservableProperty]
       SoundTypeOption selectedSoundTypeOption;
...
        partial void OnSelectedSoundTypeOptionChanged(SoundTypeOption value)
        {
            if (value == null)
            {
                do_something;
            }
            else do_something_else;
        }

ContentView containing SegmentedControl is defined like that:
<ControlTemplate x:Key="Vowels">
    <Grid RowDefinitions="Auto,680">
        <s:SegmentedControl Margin="10" ItemsSource="{Binding SoundTypeOptions}" SelectedItem="{Binding SelectedSoundTypeOption, Mode=TwoWay}" TextPropertyName="Native"/>
        <CollectionView ... />
    </Grid>
</ControlTemplate>

If SegmentControl is replaced with Picker, selected item source changes as expected upon selecting different items in Picker.
<Picker
    Grid.Row="0"
    Title="Sound duration"
    ItemsSource="{Binding SoundTypeOptions}"
    SelectedItem="{Binding SelectedSoundTypeOption, Mode=TwoWay}"
    ItemDisplayBinding="{Binding Native}"/>

OnSelectedSoundTypeOptionChanged is not triggered upon selecting another segment.
Expected Behavior
Selected item source changing, , OnChanged method is triggered.
Actual Behavior
Selected item source is not changing, OnChanged method is not triggered.
Basic Information

Version with issue: 1.3.7 ( .NET 8.0 )
Last known good version: -

Screenshots

Reproduction Link

Did you have a look at the SegmentedControlDemoApp in this repository? Test3Page + Test3ViewModel demonstrate SelectedItem bindings.
I adjusted Test3Page.xaml with code that is similar to what you posted in this issue. Have a look:
<s:SegmentedControl
    Margin="10"
    ItemsSource="{Binding Countries}"
    SelectedItem="{Binding SelectedCountry, Mode=TwoWay}"
    TextPropertyName="EnglishName"/>

And in the viewmodel I have following property. The setter is hit whenever a SelectedItem is updated.
public CountryItemViewModel SelectedCountry
{
    get => this.selectedItem;
    set => this.SetProperty(ref this.selectedItem, value);
}

Make sure the property's setter is public. I'm not very familiar with this code-generated properties. Check if it also doesn't work with manual code (non-generated).
Also, maybe SoundTypeOption could be the source of the problem. You're using 3 exactly identical objects. Maybe SelectedItem does recognize them as same and does not update SelectedItem property?

Can you share the implementation of SoundTypeOption? Is there anything like override Equals or IEquitable<> implemented?

Hi, thanks for your quick response.
This is a very simple class defined like that, serving to back selection items.
public class SoundTypeOption
{
    public string Latin { get; set; }
    public string Thai { get; set; }
}

I have replaced the automatically generated properties with explicit one:
private SoundTypeOption selectedSoundTypeOption;
public SoundTypeOption SelectedSoundTypeOption
{
    get => this.selectedSoundTypeOption;
    set {
        this.SetProperty(ref this.selectedSoundTypeOption, value);
        ...
    }
}

Yet the setter is only hit when property is assigned from code behind (e.g. SelectedSoundTypeOption = SoundTypeOptions[0]; ), but not on UI taps.
I also tried to bind to selectedItem from another control and changed mode to OneWay, but it's not showing that selection changes either.

I guess I'll try to build up from your working example and see where it breaks.
I think it might be due to the control being defined within a content template that is injected in the view (however, it works with the Picker somehow). Thanks!

Very strange. Yes, I saw you're using the SegmentedControl inside a ControlTemplate. Shouldn't you use {TemplatedBinding ...} instead if {Binding ...} in this situation? I agree, it's strange that it works with the Picker but not with the SegmentedControl.
If you create a very minimal sample app on a public github repo, I can clone it and try to debug it.

I've made a simple example and... of course it was working. :)
Changed everything back in the main project to exactly mirror the reproduction and it still wasn't working.
Eventually turned out that something in the other package was causing an issue.
Had to uninstall both this one and Plugin.Maui.SegmentedControl that I tried using before.
Re-installed your package after this. Everything is working fine after that.
I suppose there could be some namespace conflicts? Although the compiler didn't complain about a thing.
In any case, apologies for taking your time, and thank you for the package.


Add the latest Video in the HomePage

It will be nice to have the latest 2017 Video https://www.youtube.com/watch?v=PEXnbTyygi4 in the Homepage !

I am sending a fixup with correct frame size for this video.

Fixed in #165


1.0.1

Hotfixed FileFormatException incorrectly inheriting from Client and not ClientException
Added two new exceptions: TooManyRequestsException and LimitExceededException
Added retrying with exponential backoff when getting throttled by the API
Added more tests

Should maybe the TooManyRequestException be dealt with in the code by adding some wait time before trying again? I also received a lot of BadRequest errors from the Api without understanding much of what went wrong. Would it be possible to add some additional information to the user here?
Also, Client has a line that exceeds the PEP standard: line 122

on_exception decorator already handles exponential backoff for failed requests. Can you verify that it is implemented?
Fixed the too long line in client.py


Table flickering when between emptyChildren state and loading state

Solvable using a Table client state manager and transitions between states


Specflow name mapping for danish charecters is missing

When I add TestResults for scenarioes with special danish characters ('æ', 'ø' and 'å') it can not match the scenario with the Specflow generated testname.
I can see the SpecFlowNameMapping.cs is missing the danish characters.
This pull request adds these characters.
It's only commit id: 4a8ed08 which has the change.
/Philip

I found out the VsTestScenarioOutlineExampleMatcher.cs have the same replacement, it also need the update for danish characters.


Official Website Coming Soon

Our official website is coming soon!

This issue will be closed once the website is officially online! Stay subscribed!

The website is already online. URL: https://pacer.org.cn


Document behavior of JobConnection.{run_and_measure|expectation} for …

…non-deterministic programs
This follows our recent internal Slack discussion.
The rendered docs look like this:

I hope the italicized parts are not too dramatic :)

These comments are good.
Can we go one step further and add to the documentation a section on "Optimized Calls"? The run method is the only true bonafide way to evaluate things. Every single other way to evaluate a program has a defect when the program has side-effects, non-determinism, including the .wavefunction call.
We can discuss that these are for optimization only, and have one of those little neat warning boxes.

@ntezak Text looks good. Like the italics. I agree with @tarballs-are-good that emphasizing that the non run calls are more for optimization and debugging on the qvm will be useful.  With this added we can merge.

Ok, I added a short subsection to the JobConnection section in Getting Started:

Ok, @willzeng

moved Optimized Calls up one toc-level,
converted method and class names to proper internal sphinx references to enable users to jump to their documentation
Added note to the expectation api call
Fixed another random RST formatting problem in getting_started.rst

Looks like this now:

Ok, @willzeng

moved Optimized Calls up one toc-level,
converted method and class names to proper internal sphinx references to enable users to jump to their documentation
Added note to the expectation api call
Fixed another random RST formatting problem in getting_started.rst

Looks like this now:

Ok, @willzeng

moved Optimized Calls up one toc-level,
converted method and class names to proper internal sphinx references to enable users to jump to their documentation
Added note to the expectation api call
Fixed another random RST formatting problem in getting_started.rst

Looks like this now:


Update mob_suite to 2.0.2

Update mob_recon and mob_typer tools to use mob-suite v2.0.2

I've had some trouble getting a working tool wrapper for mob_hostrange, so I've removed that tool from this pull request. Can I request that this PR be merged without the mob_hostrange tool? I'd be happy to add my work-in-progress mob_hostrange tool back in another PR.

It is perfectly fine to skip mob_hostrange tool as it is mostly used to query the reference database by replicon, relaxase, plasmid cluster  The mob_typer invokes full host range report internally. I see no need to have mob_hostrange module in Galaxy.

@Takadonet Could I request a review? (I'm not able to use the integrated GitHub review request feature on this repo)

@kbessonov1984 could you review this PR please? Besides updating the version number, the main change that I made was to provide the chromosomal assembly and the collection of plasmid assemblies as separate outputs from mob_recon.

@dfornika Great work! I am testing this Galaxy recipe in my docker container and will get back shortly. I would like to enhance this wrapper with the additional host range output (ascii tree, and reports).
I see that all plasmid sequences are moved to a separate folder plasmids and separate data collection for all plasmid sequences is prepared in the history to make it easier to download all of them as a collection. In the same vein, would it be better to rename chromosome to chromosomal sequences (chromosome.fasta) on line 71 of mob_recon.xml so that user will understand that these sequences are predicted to be chromosomal.
Also for the mob_typer I would add additional outputs including the host range tree (both ascii and newick formats) and host range NCBI and literature reports, not only plasmid report.

Can I suggest that we keep the RefSeq and Literature trees as separate outputs, instead of merging them together into collections? I've found that it's difficult to pick specific outputs out of a collection when designing a pipeline (that's why I moved the chromosome.fasta out into a separate output).
I've added the ASCII and newick tree outputs. I should be able to add the remaining outputs fairly soon.

Hi Dan, I was also working on your commit trying to solve issue of empty Newick files. I finally managed to do it with <discover_datasets> tag, but one needs to set assign_primary_output to true i.e. <discover_datasets pattern=".+_refseqhostrange_phylogeny_tree\.nwk" visible="true" format="newick" assign_primary_output="true"/>. Otherwise it was giving me an empty file and I was thinking that there is an issue with the regex.
I like the idea of replacing the <discover_datasets> tag for simpler  tags with the wild card *. It is very elegant and simple
I am also OK with keeping output data from the host range in the separate files rather than in a collection. In the future it will be nice to put all host range reports in a collection dataset to prevent cluttering of the history.
I also suggest to change from ${tool.name} on ${on_string} to ${tool.name} on ${input.element_identifier} in all instances as this would allow to refer to input file name rather than generic data 1.
Otherwise I am OK with this implementation. It works great on my end.

@Takadonet can we merge?

For sure. Does not have to go thru me to be merged. Anyone that reviews PR
should merge it.
On Wed., Dec. 11, 2019, 16:16 Dan Fornika<EMAIL_ADDRESS>wrote:

@Takadonet https://github.com/Takadonet can we merge?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/phac-nml/galaxy_tools/pull/160?email_source=notifications&email_token=AAAPZXGPB73RSVVO6D6PC2DQYFRDHA5CNFSM4JNC2GG2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEGUYM4A#issuecomment-564758128,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAAPZXHDJOPQE3HT3J2UUSDQYFRDHANCNFSM4JNC2GGQ
.


Website`s release tab issue

https://docs.openservicemesh.io/ release tab not redirecting to correct pages of OSM releases.

Thanks for reporting this issue, @mudit-01. We're currently not using the release tab, so I'll close this at this time.

To update this, we did start using the release tab and it now brings you to the past releases. Thanks!


Hiding child projects in multiproject template

I have created a multiproject template but in new project window I just want to see the parent template and not the child project templates as it gets confusing for users.
Is there a way to hide child project templates and disable them from showing in new project list?
Thanks.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 5b76e208-2a2a-9fc3-98ff-147540157f32
Version Independent ID: 5f5c9adf-da1d-ec0b-8af3-ccd2e27eaadc
Content: Create multi-project templates - Visual Studio
Content Source: docs/ide/how-to-create-multi-project-templates.md
Product: visual-studio-windows
Technology: vs-ide-general
GitHub Login: @gewarren
Microsoft Alias: gewarren

@batizar Hmm, I'm surprised that's happening. @prnadago If you have a multi-project template, are the subprojects supposed to appear in the new project dialog box?

Inner templates within a project group are full-fledged templates and if they are in a location being looked up, they will show up.
If the intent is not use them directly, the inner templates need to be marked as hidden.
https://docs.microsoft.com/en-us/visualstudio/extensibility/hidden-element-visual-studio-templates?view=vs-2019
Hope this helps!

Thanks Pratik. I'll update the doc with this info too.

Thanks @prnadago


Updates | lambda.rb

@joshlarsen added the following:
Lines 17 - 27, 176 - 181
Lines 29 - 40, 183 - 204
The just need to be reviewed and see if I did it correctly. Once I updated the lambda.rb file with these changes I was able to load the custom data without getting any of the following errors:
worker_1  | Loader job failed - NoMethodError undefined method vpc_id' for #String:0x00007fee9146fca8 (/app/app/jobs/lib/loader/asset/loaders/aws_loader/lambda.rb:21:in function') worker_1  | Runner job failed - NoMethodError undefined method vpc_id' for #String:0x00007fee9146fca8 (/app/app/jobs/lib/loader/asset/loaders/aws_loader/lambda.rb:21:in function')
Hope I did it correctly.
Also, while on the Lambda topic am I supposed to be seeing the service within the OpenCSPM web page?
Hope you have a great weekend!
William

@Nebula-Ninjas I pulled this over into it's own branch to take a look.
There are a few issues:
We don't need
def vpc
...
end

and
def subnet
...
end

here because those entities don't appear in the Lambda function resource JSON, only the EC2 resources. They'll get loaded/upserted by the EC2 loader.
The other issue is that in my testing, I see the VPC info under the vpc_config key, not just vpc_id. For example:
{
  "account": "1234567890123",
  "service": "Lambda",
  "region": "us-east-1",
  "resource": {
    "function_name": "lambda-vpc-test",
    "function_arn": "arn:aws:lambda:us-east-1:1234567890123:function:lambda-vpc-test",
    "runtime": "nodejs12.x",
    "role": "arn:aws:iam::1234567890123:role/service-role/lambda-vpc-test",
    "handler": "index.handler",
    "code_size": 856,
    "description": "A simple backend (read/write to DynamoDB) with a RESTful API endpoint using Amazon API Gateway.",
    "timeout": 10,
    "memory_size": 512,
    "last_modified": "2021-04-25 20:48:53 +0000",
    "code_sha_256": "E4HWnUFtLDweNO950YRTEYkjq3MzA7B3BnGrSPUX5R4=",
    "version": "$LATEST",
    "vpc_config": {
      "subnet_ids": ["subnet-96171dca", "subnet-f9c811b4", "subnet-e6673ad8"],
      "security_group_ids": ["sg-29254f7d"],
      "vpc_id": "vpc-b1c993cb"
    },
    "dead_letter_config": null,
    "environment": null,
    "kms_key_arn": null,
    "tracing_config": {
      "mode": "PassThrough"
    },
    "master_arn": null,
    "revision_id": "c71c70f9-eed7-4fad-bf4b-621102abe45a",
    "layers": [],
    "state": null,
    "state_reason": null,
    "state_reason_code": null,
    "last_update_status": null,
    "last_update_status_reason": null,
    "last_update_status_reason_code": null,
    "file_system_configs": null,
    "package_type": "Zip",
    "image_config_response": null,
    "signing_profile_version_arn": null,
    "signing_job_arn": null,
    "type": "function",
    "arn": "arn:aws:lambda:us-east-1:1234567890123:function:lambda-vpc-test",
    "policy": {
      "Version": "2012-10-17",
      "Id": "default",
      "Statement": [
        {
          "Sid": "lambda-94fcc308-cead-4b12-91da-452d853c819c",
          "Effect": "Allow",
          "Principal": {
            "Service": "apigateway.amazonaws.com"
          },
          "Action": "lambda:InvokeFunction",
          "Resource": "arn:aws:lambda:us-east-1:1234567890123:function:lambda-vpc-test",
          "Condition": {
            "ArnLike": {
              "AWS:SourceArn": "arn:aws:execute-api:us-east-1:1234567890123:vhv5dd1tj2/*/*/lambda-vpc-test"
            }
          }
        }
      ]
    }
  },
  "timestamp": "2021-05-28 21:29:46 UTC"
}

so the key is going to be @data.vpc_config.vpc_id if the Lambda is in a VPC. Can you confirm your Lambda JSON is in the same shape as above? (e.g. via cat output.json | grep '"service":"Lambda"' | jq)

@joshlarsen thank you for taking a look at this. I'll admit that I do not know a great deal on coding, just good at comparing other code and seeing what was done and seeing if it would remedy the issue I was having.
To answer your question, I believe the differences I am seeing is how the JSON file outputted the the vpc_config portion.
My Example:
"vpc_config": "{:subnet_ids=>[\"subnet-0f82efdd701104eb8\", \"subnet-011e9efc9b2413686\", \"subnet-061f5099abf30db87\", \"subnet-0997b20811fe72aa2\"], :security_group_ids=>[\"sg-07654186633011770\"], :vpc_id=>\"vpc-0708c1f757a3cef40\"}",
For some reason mine has \ and > on the functions with an association with a VPC. Additionally, I have a "dead_letter_config", "environment", and `"tracing_config"' that all seem to have the same thing.
Lastly, my "vpc_config", "dead_letter_config", and "environment" didn't format the JSON as yours with line breaks after the commas.
Based on your example and mine, I suspect it is the \ and > that could be the culprit. What do you think?
Nonetheless, I'll see if I have some time today to edit the JSON for those oddities and test.
Thanks in advanced!
Sincerely,
William

@Nebula-Ninjas ah, it looks like you're using an older version of aws_recon. Better parsing of the vpc_config was added in a recent update. Can you please ensure you have the latest AWS Recon and re-run your collection?

@joshlarsen I pulled/used the Docker image and it is running 0.5.3. Do you know when/if this image will be updated soon?
AWS Recon - AWS Inventory Collector (0.5.3)
Sincerely,
William

@Nebula-Ninjas the latest is 0.5.11. To re-pull:
docker pull darkbitio/aws_recon:latest

@joshlarsen re-pulled the latest, re-ran aws-recon and that fixed the lambda section.
Additionally, I deleted and re-pulled the OpenCSPM project and tested with the JSON file and it loaded with no errors.
What I am finding is that I can not see anything pass/fail related to Lambda within the console, is this the expected behavior?
William

@Nebula-Ninjas so far, all of the controls related to Lambda are in the Enterprise control pack.


Long Prompt Using Short Text Issue

I am using the pretrained model.
When generating a prompt from a 9 second audio with the following transcript.
Voice 1: 9 secs Audio
Transcript 1: Its members include representatives of the teaching staff, students, and the parents of the students.
After generating this prompt and using a transcript 2 from a file that is 4 seconds.
Voice 2: 4 secs
Transcript 2: This led to both the Red Terror and the White Terror.
This led to the resulting Synthetic audio with the following transcript.
Transcript 3: This led to both the Red Terror and the White Terror and the White Terror.
Is there a reason or way to prevent this from happening? I can also attach files showing the results.

repetitive or missing words is a common defect in autoregressive TTS models, like Tacotron 2. VALL-E suffers from the same problem


Icon only buttons should be a consistent width

I would expect buttons that contain only one of our FontAwesome icons to be a consistent width. This would avoid subtle but noticeable alignment issues, e.g. with stacked toolbars.

The download/export icon seems to be the most common example - in Toolbox most icons are 33px wide, but this one is 34.63px

See #666


Generate Android vectors

This is not merge-able as it is, I just want to open a discussion.
As an attempt to fix #27 I copied the sources from the Android Studio SVG to Android Vectors converter and made a gradle task based on it: https://github.com/RomainPiel/gradle-svg2android
I modified Victor so that it converts SVGs to Android Vectors instead of PNGs and it's working pretty well with the sample.
SVG2Android hasn't been uploaded to maven central or bintray, I've only played with it with mavenLocal.
So to test this PR:

clone https://github.com/RomainPiel/gradle-svg2android
cd gradle-svg2android && ./gradlew install

I think a reasonable plan could be to add an option to victor to switch the export format between png and xml. Then while this appears to be stable, we can remove completely RasterizeTask and only use SVG2AndroidTask.
Limitation:

I haven't played with a lot of SVGs but it seems that the build tools converter doesn't like pt so I converted all of them to px

If you think it's useful, either:

I deploy https://github.com/RomainPiel/gradle-svg2android to bintray
we integrate the code from https://github.com/RomainPiel/gradle-svg2android into victor

This is awesome. I think we'd want to add an option to convert to PNG vs. Android drawable, just so people can have a safe upgrade path.
One other question - why is gradle-svg2android tied to Gradle vs. being a standalone Java process?

Awesome, I have a 7 hours flight tomorrow, I'lltake this time to tidy up the PR.
I made my repo tied to gradle because I wanted to expose a task but you're right, it would be cleaner as a standalone java library.

I think it's much more clean now if you want to have a look:

[x] moved task from romainpiel/svg2android to victor
[x] deployed romainpiel/svg2android to sonatype
[x] added a control to enable the export to Android vector drawable. note that densities and default dpi don't really make sense in that case.
[x] cleaned up as much as possible the logging (i might have missed some lines)

Travis is not passing because the job doesn't do a clean.

I've merged the tasks and removed the usage of generateVectorDrawables  in the sample. I'm still not sure what to do with https://github.com/trello/victor/pull/43#discussion_r60452265

regarding https://github.com/trello/victor/pull/43#discussion_r60452328, this is a bug in the Android Studio source code. I've just reported it, so I'll merge it in svg2android as soon as it gets fixed: http://b.android.com/208216

This looks good to me. Let's see what happens with it!


SPARQL PATCH causes hanging request

The following will cause the server request to hang without any observable errors client-side or server-side:
$ curl -X PUT -H "Content-Type: text/turtle" \
  -d '<ex:s> <ex:p> <ex:o>.' \
  http://localhost:3000/myfile.ttl
$ curl -X PATCH -H 'Content-Type: application/sparql-update' \
  -d 'INSERT DATA { <ex:s2> <ex:p2> <ex:o2> }' \
  http://localhost:3000/myfile.ttl

I can't reproduce this.
I do get an error afterwards when retrieving the data because it is stored as Quads instead of turtle, but that's another issue (related to #47 ).

Hmm, I can't produce this anymore either...

I do get an error afterwards when retrieving the data because it is stored as Quads instead of turtle

Explicitly requesting turtle does work for me though.
I'm ok with closing this.


MAINT: Move code to shared modules

Lots of code in the earnings_calendar loader and tests can be shared with related loaders and datasets.

ping @richafrank. I updated the names in those two functions. Are we good to merge on pass?

Had one other name change; otherwise, LGTM.


Parameters Added with \Cmp\Http\Message\Request::withQueryParameter are not always encoded

The issue seems to be that previously encoded parameters are decoded at Symfony/vendor/pluggit/http-client/src/Message/Request.php:81, so only the last parameter gets encoded.
Fixing this can cause backwards compatibility issues, so I would increment the major version.

Good catch! Agree with the major version change 👍

A related issue was fixed by https://github.com/CMProductions/http-client/pull/14/files
Note that parse_stris already url decoding the params:
http://php.net/manual/es/function.parse-str.php#72745

We where using version 1.1.0 without this last fix: http://php.net/manual/es/function.parse-str.php#72745
We'll update to the latest.


Fix PR Suggestions

See https://github.com/actions/github-script/issues/242
This fixes #23584

cc @BillyONeal

@autoantwort Thanks for the fix & apologies for the extra noise/breakage......(an oversight on my part)

Sorry for blindly merging the previous change, and thank you for the fixes!


[CARBONDATA-3210] Merge common method into CarbonSparkUtil

Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:

[x] Any interfaces changed?

[x] Any backward compatibility impacted?

[x] Document update required?

[x] Testing done
Please provide details on
- Whether new unit test cases have been added or why no new tests are required?
- How it is tested? Please attach test report.
- Is it a performance related change? Please attach the performance test report.
- Any additional information to help reviewers in testing this change.

[x] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

Can one of the admins verify this patch?

Please describe the change of this PR

@xiaohui0318 Please optimize the title, such as change merge to Merge

Have you validate with S3?

add to whitelist

Build Failed  with Spark 2.3.2, Please check CI http://<IP_ADDRESS>:8080/job/carbondataprbuilder2.3/10336/

Build Failed  with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder2.1/2082/

Build Failed with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/2287/

Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:

[x]  Any interfaces changed?
NO
[x]  Any backward compatibility impacted?
NO
[x]  Document update required?
NO
[x]  Testing done
NO,only fix style error
[x]  For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
NO

Build Failed  with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder2.1/2088/

Build Failed  with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder2.1/2090/

Build Failed with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/2295/

Build Failed  with Spark 2.3.2, Please check CI http://<IP_ADDRESS>:8080/job/carbondataprbuilder2.3/10344/

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder2.1/2091/

Build Success with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/2296/

Build Success with Spark 2.3.2, Please check CI http://<IP_ADDRESS>:8080/job/carbondataprbuilder2.3/10345/

please remove blank before '('

fix already.tks

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder2.1/2098/

Build Success with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/2303/

Just some nit comments, and others LGTM


Use singleton instance of slug generator

The slug generator that is use to generate anchors from headings keeps track of the slugs it generates and appends incrementing numbers when it finds duplicates. It's really meant to be run against a single page, in order, and then reset.
But in react on the client-side we:

Can't guarantee the slugs are generated in the same order;
Can re-render, which causes the slugs to get ever-increasing suffixes appended.

And since the table-of-contents used for the right sidebar gets generated separately and ahead of time, the anchors will no longer match.
A singleton instance that doesn't track duplicates is also exported, so I'm using that here instead. As long as there are no duplicates it should work. I experimented with other ways of doing this, but ultimately the correct way is to make sure the slugs are exactly the same. But that will require a larger refactor effort.

Nice catch.


Status of Blocking Socket Transport in Haigha

Hi @awestendorf: What is the status of Haigha with the Blocking Socket Transport? Is it stable and suitable for production deployment when used with Blocking Socket Transport?
Sorry for repeating the question that I emailed to you recently. I need to make an urgent decision with respect to AMQP client selection to solve a licensing incompatibility issue.
Best,
Vitaly

I don't use the blocking transport in production, but as far as I know it's in a good state.


FileTarget - Faster archive check by caching the static file-create-time (60-70% improvement)

FileTarget - FileAppenderCache now caches the conversion of File-Time-Utc to File-Time-TimeSource thus avoiding the expensive DateTime.ToLocalTime(). Also the ArchiveEvery-check now performs truncate of DateTime.Ticks instead of performing DateTime.ToString() allocation.
This PR also contains the following changes:

MutexMultiProcessFileAppender now uses the cached File-Creation-Time, instead of doing lookup using file-handle
WindowsMultiProcessFileAppender now uses the cached File-Creation-Time, instead of doing lookup using file-handle
UnixMultiProcessFileAppender now updates the cached File-Creation-Time as expected by the FileTarget / FileAppenderCache.
Changed some FileTargetTests to use ShiftedTimeSource instead of using File.SetCreationTime. This allows FileAppenders that caches the static File-Creation-Time to be tested (Now also testing SingleProcessFileAppender).

Have done performance tests with the following config:
<target name="SyncFilePerfArchive" type="File" fileName="C:\Temp\Log\NLogPerformanceArchivePerf.txt" autoFlush="false" keepFileOpen="true" concurrentWrites="false" layout="${message}" ArchiveAboveSize="10000000000" MaxArchiveFiles="1000" ArchiveEvery="Year" ArchiveNumbering="Date" />

Logger Name
Messages
Size
Threads
Loggers

PerfArchiveLogger
10.000.000
128
1
1

This PR
Time (ms)
Msgs/sec
GC2
GC1
GC0
CPU (ms)
Mem (MB)

concurrentWrites = false
18.694
534.917
0
0
1243
19.000
36,551

concurrentWrites = true
90.754
110.187
0
0
1275
90.843
36,320

Master
Time (ms)
Msgs/sec
GC2
GC1
GC0
CPU (ms)
Mem (MB)

concurrentWrites = false
32.902
303.924
0
1
1459
33.046
36,746

concurrentWrites = true
144.539
69.185
0
1
1520
143.015
36,648

Merry Kerstmis :)

This change is

Current coverage is 81% (diff: 73%)

Merging #1876 into master will decrease coverage by <1%

@@             master      #1876   diff @@
==========================================
  Files           276        276
  Lines         18634      18646    +12
  Methods        2861       2863     +2
  Messages          0          0
  Branches       2139       2141     +2
==========================================
+ Hits          15138      15143     +5
- Misses         2977       3001    +24
+ Partials        519        502    -17

Powered by Codecov. Last update 2216fff...29ee2b4

Reviewed 10 of 10 files at r1.
Review status: all files reviewed at latest revision, 9 unresolved discussions.

src/NLog/Internal/FileAppenders/BaseFileAppender.cs, line 79 at r1 (raw file):

        /// </summary>
        /// <returns>The creation time of the file.</returns>
        public DateTime CreationTimeUtc { get { return _creationTimeUtc; } internal set { _creationTimeUtc = value; CreationTimeSouce = Time.TimeSource.Current.FromSystemTime(value); } }

smart one. Please add a comment that we are doining this for performance reasons.

src/NLog/Internal/FileAppenders/BaseFileAppender.cs, line 82 at r1 (raw file):

        DateTime _creationTimeUtc;

        public DateTime CreationTimeSouce { get; private set; }

Please add some XML docs and refer to CreationTimeUtc (<see tag)
It's also SouRce? (or is it my limited English vocabulary..)

src/NLog/Internal/FileAppenders/FileAppenderCache.cs, line 177 at r1 (raw file):

                }

                if (string.CompareOrdinal(appenders[i].FileName, fileName) == 0)

What about .Compare (...Ordinal)?

src/NLog/Internal/FileAppenders/FileAppenderCache.cs, line 182 at r1 (raw file):

                    // (MRU)
                    BaseFileAppender app = appenders[i];
                    if (i != 0)

if (i > 0)?

src/NLog/Internal/FileAppenders/FileAppenderCache.cs, line 332 at r1 (raw file):

                    if (result.HasValue)
                    {
                        if (result.Value != appender.CreationTimeUtc)

we're checking the cached version here right? Please add it as comment, thanks!

src/NLog/Internal/FileAppenders/MutexMultiProcessFileAppender.cs, line 196 at r1 (raw file):

        public override DateTime? GetFileCreationTimeUtc()
        {
            return CreationTimeUtc; // File is kept open, so creation time is static

smart one :)
Thanks for the comment. Needed it

src/NLog/Internal/FileAppenders/UnixMultiProcessFileAppender.cs, line 101 at r1 (raw file):

                long filePosition = this.file.Position;
                if (fileExists || filePosition > 0)

isn't fileExists always true when filePosition > 0 ?

src/NLog/Internal/FileAppenders/WindowsMultiProcessFileAppender.cs, line 203 at r1 (raw file):

        public override DateTime? GetFileCreationTimeUtc()
        {
            return CreationTimeUtc; // File is kept open, so creation time is static

are you sure this is the case here?

src/NLog/Targets/FileTarget.cs, line 2065 at r1 (raw file):

        }

        private static DateTime TruncateArchiveTime(DateTime input, FileArchivePeriod resolution)

what are we trying to do here? (xmldoc please)

Comments from Reviewable

src/NLog/Internal/FileAppenders/FileAppenderCache.cs, line 182 at r1 (raw file):
Previously, 304NotModified (Julian Verdurmen) wrote…
if (i > 0)?

Also works

Comments from Reviewable

src/NLog/Internal/FileAppenders/WindowsMultiProcessFileAppender.cs, line 203 at r1 (raw file):
Previously, 304NotModified (Julian Verdurmen) wrote…
are you sure this is the case here?

FileCreation-time should not be updated by having multiple writers to the same file. They will just update FileModified-time. Ofcourse it will not longer react to random application that for fun modifies the file-creation-time of log-files.

Comments from Reviewable

src/NLog/Internal/FileAppenders/UnixMultiProcessFileAppender.cs, line 101 at r1 (raw file):
Previously, 304NotModified (Julian Verdurmen) wrote…
isn't fileExists always true when filePosition > 0 ?

Well there can be a race-condition between the fileExists-check and the filePosition > 0. If someone was able to create the file and append to it between doing the fileExists-check and the filePosition-check.

Comments from Reviewable

src/NLog/Targets/FileTarget.cs, line 2065 at r1 (raw file):
Previously, 304NotModified (Julian Verdurmen) wrote…
what are we trying to do here? (xmldoc please)

Done

Comments from Reviewable

src/NLog/Internal/FileAppenders/BaseFileAppender.cs, line 79 at r1 (raw file):
Previously, 304NotModified (Julian Verdurmen) wrote…
smart one. Please add a comment that we are doining this for performance reasons.

Done

Comments from Reviewable

src/NLog/Internal/FileAppenders/BaseFileAppender.cs, line 82 at r1 (raw file):
Previously, 304NotModified (Julian Verdurmen) wrote…
Please add some XML docs and refer to CreationTimeUtc (<see tag)
It's also SouRce? (or is it my limited English vocabulary..)

Done

Comments from Reviewable

src/NLog/Internal/FileAppenders/FileAppenderCache.cs, line 177 at r1 (raw file):
Previously, 304NotModified (Julian Verdurmen) wrote…
What about .Compare (...Ordinal)?

Fixed

Comments from Reviewable

src/NLog/Internal/FileAppenders/FileAppenderCache.cs, line 332 at r1 (raw file):
Previously, 304NotModified (Julian Verdurmen) wrote…
we're checking the cached version here right? Please add it as comment, thanks!

Done

Comments from Reviewable

src/NLog/Internal/FileAppenders/MutexMultiProcessFileAppender.cs, line 196 at r1 (raw file):
Previously, 304NotModified (Julian Verdurmen) wrote…
smart one :)
Thanks for the comment. Needed it

:)

Comments from Reviewable

Reviewed 4 of 4 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

Close/reopen for triggering appveyor

Ow conflict :/

@304NotModified Fixed merge conflicts

Merci!

Reviewed 7 of 7 files at r3, 9 of 9 files at r4.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

Reviewed all.


Fix Enemy AI

The #10 issue was covering too many different things so I'm splitting it into two.
This issue is just for fixing the AI to make enemies behave like they used to. As in, they shoot in the direction they are accelerating in, not the direction they are currently moving in. The game was significantly more fun when the enemies were like that, and the projectiles often created very pretty patterns.
The other issue (#10) is about other (non-ML) improvements to the AI, e.g. swarming.
And #43 is a more long-term experimental issue about where we try giving the enemies much more complicated ML based AIs.

enemies now shooting towards player, 2df72f86258fc4f33401a2266ebe96ec029adab2


How to return the default CIPHER ssh2 is using?

Hi all, I am looking at this list here: https://github.com/mscdex/ssh2-streams/blob/a979592f13ee06ad9d5245eef17b0535f7354cce/lib/constants.js#L259 and am curious to know which actual algorithm will be used for my client? My SFTP server is updating their list of allowed ciphers so I want to make sure I am ok or if I potentially need to update my default config on connect().
Thanks for any help!

There is no public API to obtain that information programmatically at the moment. You can see it in the debug output however if for example you set debug: console.log in your connection config object. In the debug output you will see all of the algorithms ssh2 offers, what the server offers, and what the negotiated algorithm was, for both directions (client to server and vice versa).

Thanks for the answer, this may be a silly question/thought, but it's my understanding that as long is there is a common overlap between the DEFAULT list of ciphers and the ciphers on the SFTP server side, then the connection will negotiate one of the ones that it has in common?  If there is no overlap at all then I should specify in my client.connect() configuration, right?

Basically, yes. However, you're still limited to the algorithms that are supported, so you can't just add just any arbitrary algorithm name and have it just work.

Thanks! Really appreciate you taking the time to answer this question.


Deploy VPA for kube-scheduler

Story
As an administrator, I would like to deploy VPA for kube-scheduler and make use of its recommendations to be able to manage larger clusters
Tasks

[ ] Deploy VPA for kube-scheduler with the updater set to 'off' mode
[ ] Create the necessary grafana dashboard showing actual vs recommended metrics
[ ] Based on the observation, decide on the operation mode of the VPA

Acceptance Criteria

[ ] Observe and compare the recommendations of VPA for kube-scheduler through Grafana dashboard
[ ] Adapt VPA recommendations by switching the VPA Updater to 'initial' or as appropriate

See comment at #893. There are even more components like kube and cloud controller manager, maybe other control plane components as well, then everything that needs to be scaled based on load in the cluster itself like kube-proxy and calico. A gathering epic would be helpful, I guess. Either #16 or a new one (I don't mind if you close the old one).

Closing as it's done.


Add feature to export/import multiplayer identities

Contains
Implements the feature suggested in #1433; in other words, adds two buttons in the player settings screen that allow to export the identities used to authenticate to multiplayer server to a file, and to import a file of previously exported identities.
A NUI-based file picker is also included to allow the user to choose the file to save to or load from (screenshot attached).

How to test

Make sure to have some identities in your configuration (if not sure, just join a server to automatically generate one). For testing purposes, also make sure that at least one identity is associated with something meaningful; for example, join a server and move your character to a certain place and/or pick up or drop some items.
From the main menu, go to Settings > Player, and click the Export... button next to the Multiplayer identities label. the file picker popup will open; navigate to the directory where you want the file containing the identities to be saved, then enter a name for the file in the text box at the bottom of the popup and click OK.
Exit Terasology and delete or rename the configuration file (config.cfg); obviously before deleting it, back it up if it contains something you want to preserve beside identities.
(optional) Start the game again and join the same server; you will be placed at the spawn point and have the default item set because the identity has been deleted when you deleted the configuration file.
Go back to the main menu, then go to Settings > Player and click Import...; in the file picker, select the file you previously exported to and click OK. If you did the previous step, you will be prompted to choose if you want to replace the locally saved identity; choose to import it anyway, overwriting the one which has been generated while performing the previous step with the one present in the file.
Join the same server; you will be in the same position, have the same items, etc. as before deleting the configuration file.

Outstanding before merging
Nothing I can think of, but obviously any feedback/suggestion is welcome.

Hooray Jenkins reported success with all tests good!

Very nice work - tested it out and all was well first try even detecting that I was importing with a different homedir that had a different identity. I picked overwrite and was able to connect to a test server and resume where I left off from the original client :-)
The file picker was slightly confusing at first just from its appearance, but worked fine otherwise. Seems a useful widget if we don't just spin up native look & feel popup file chooser windows for everything (which I guess would be a possibility)