Add link to the typesript integration instructions

Summary
I installed jest and typescript, but they refused to integrate. jest was throwing SyntaxErrors at me when parsing typescript files. Searching for typescript on you website got me here https://jestjs.io/blog/2019/01/25/jest-24-refreshing-polished-typescript-friendly#typescript-support which a very unhelpful because it does not contain instructions on how to configure the integration. It turned out that I need babel.config.js

Test plan
none

Codecov Report

Merging #11806 (16ab528) into master (98f10e6) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #11806   +/-   ##
=======================================
  Coverage   69.04%   69.05%
=======================================
  Files         312      312
  Lines       16366    16366
  Branches     4746     4746
=======================================
+ Hits        11300    11301    +1
+ Misses       5039     5038    -1
  Partials       27       27

Impacted Files
Coverage Δ

packages/expect/src/utils.ts
96.13% <0.00%> (+0.55%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 98f10e6...16ab528. Read the comment docs.


fix using torch.half with transformers

fix for this error "AttributeError: 'DeepSpeedGPTInference' object has no attribute 'dtype'" while using torch.half

#4814 is already merged. Closing


Variable and function should split with a new line and parameters should split with blank

here : https://github.com/badboy-huaqiao/edgex-ui-go/blob/master/mqtt.go#L30-L31

closing this, fixed this issue in PR #22


ouroboros-network-protocols: added bounds for ouroboros-network-api

The bound was updated in a6c72ab9e38.


Bump MongoDB Node driver version to 2.2.23

Several bug fixes, will prevent Parse Server from trying to authenticate against replica set arbiter nodes: https://github.com/mongodb/node-mongodb-native/blob/2.2/HISTORY.md#2223-2017-02-13

Hey, thanks for reporting this issue.
Can you please add all the info specified in the template? This is necessary for people to be able to understand and reproduce the issue being reported.


Travis CI needs a classic / non-unity Windows build (Version: 1.6.0-b4)

Summary
Travis CI does several Windows builds, but all are unity builds (stave five)
Motivation
A recent beta had a missing include, but only in Windows classic builds. Existing Travis classic builds did not catch the problem.
Solution
Should be able to copy one of the existing builds and define -Dunity=OFF
Paths Not Taken
n/a

I'm assuming this isn't relevant as we don't use Travis CI anymore, but if this is still needed, feel free to re-open or create a new issue.


Change faux private property to a getter

This will mean that application code cannot set the date directly since there is no setter defined.
Ref: #107

Release note: I just merged some backwards incompatible changes into master. So master will be targeting a 3.x release. This still makes sense to merge there, but maybe we'll want to consider backporting this change to a 2.x as well.

maybe we'll want to consider backporting this change to a 2.x as well.

Since this is a breaking change for apps that are utilizing the _date property, would it make sense to backport to 2.x?


fix: unable to set request bodies with colon characters in their names

Description
Allows using quotes in bru file to enclose special symbols for bruno keys in the following dictionaries:
fixes #571
fixes #2878 (alternative)
headers {
  "multi word header": value
  "this:header": is illegal HTTP header, but bruno can save it
}

body:form-urlencoded {
  "special:param name": value
}

body:multipart-form {
  "special:file-part name": @file(bruno.json)
  "special:text-part name": value
}

What happens if I want to have the value @file(bruno.json) in my multipart form?

@SoulKa that part is not touched, so the value will be converted to a file, as it is currently
https://github.com/user-attachments/assets/4862bb1b-7f43-4487-8480-22ae7da0b225


Bump libgit2 to v0.27.1

Appveyor isn't pulling down the submodule correctly, for what I am assuming is cache related?


AUTHORS references non-existent file

Describe the documentation issue
The AUTHORS file references a CONTRIBUTORS files, but no CONTRIBUTORS or CONTRIBUTORS.md file exists:
# This file is distinct from the CONTRIBUTORS files.
# See the latter for an explanation.

If CONTRIBUTORS is some where else, this should be made explicit in AUTHORS.
We welcome contributions by users. Can you submit a PR?
This is a question for maintainers and a PR is not yet appropriate.

Hi, may I know what exactly do we need to add in CONTRIBUTORS.md and can I work on this?

@pocc The AUTHORS file is only consists of authors only.  Contributors list is provided in the release notes. For TF2.4 version, here is the list of contributors. Thanks!
I am closing this issue as this was already resolved. Thanks!

The documentation on the AUTHORS file is still wrong. It mentions a CONTRIBUTORS file, however, it means to reference a CONTRIBUTORS list that is provided on new releases.
AUTHORS file should be updated to reflect this information.


Minimap - highlight all instances of selected word

When you doubleclick and select a word, all instances of this word should be highlighted, not just the selected word itself.
Right now you'd have to press CTRL+F and use the search functionality, but the highlighting of other instances should show up in the minimap the moment you selected the word.
Already discussed in #20853

fyi @RMacfarlane

It would increase productivity for sure!

This feature is good and useful but I hope it can be done on all minimaps of splitted views so we can check if a word is in other splitted view or not as we select it in any of views, i.e. I am checking the used/not-used classes, so I open the html file side by side with the scss file to check if a class in css is used in html by selecting and highlighting it in scss file side and them scroll the html for any highlight then the class is used else not used, I am using an extension for this, while if the minimap already show highlights on the other side then there won't be a need to scroll from top to bottom of the all other views if needed, this feature would be very appreciated.
Thanks for the great MS.Code I am using it since the beginning

I would love to see this feature as well.

I just shifted from sublime to vscode, so far all the features I want is still there thanks to plugins. But this one is missing hope to see it soon.

This is the missing feature from the minimap for me, I'm so used to it from Subime Text that I use it often (e.g. for quickly finding references: double-click on word, all occurrences get clearly highlighted in minimap, just scroll). Alternatives for VSCode currently are selecting word then Alt-F3 to select all occurrences of Ctrl-F to seach occurrences, since selections and search results are shown in minimap, but that's extra work. (also, VSCode highlights complete lines instead of matches only, but that's some other issue I think?)

Is this possible in Visual Studio?

This is a missing feature which I really need.

... any updates on this? is it going to be implemented any time soon?

are there any plans to implement this?

Yeah, cmon dudes, it's been like 4 years

if you need it today, see https://marketplace.visualstudio.com/items?itemName=mde.select-highlight-minimap

The screenshot shows highlighting in the sidebar though, not the minimap?

The screenshot shows highlighting in the sidebar though, not the minimap?

Right, this plugin don't show highlighting in minimap, and this is sad ((

Looks like the job was 99% done.
Let's hope it gets merged. 🤞

Looks like the job was 99% done.
Let's hope it gets merged.

It is incredible that only 6 lines of code were missing! Really hope they will merge this soon!

I saw the pull request was merged to main but still wonder when we can use that. Can't wait to have this feature.

I saw the pull request was merged to main but still wonder when we can use that. Can't wait to have this feature.

You can already use it in the insiders version. I guess it will be part of their next release, in the beginnig of October. In the Insiders version the color of the markings is a light grey, I still could not figure out how to customize the new minimalSelectionHighlight key though

FYI, it works great in the insiders version, except for html files. In html files, if you mark for example an opening tag, only the closing tag is marked too. If you mark an html attribute, nothing else is highligted in the minimap even if other html tags also do have that attribute.
I tested js, ts, tsx, css and vue files - workes great and as expected there. HTML files however - not so good.

That is because html has semantic highlighting support, which wins over the (weak) built-in textual based highlights. In the case of html, the language has found useful to highlight the matching open-close tags, and not all tags of the same type.

I understand, thank you for clearifying!


Section "Create Intelligent Order Management Data Transformer connection" is no longer required

The section titled "Create Intelligent Order Management Data Transformer connection" is no longer applicable. It should be removed. All references to IOM Data Transformer connector should be removed from the documentation.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 37308970-09b7-a0ee-7dcc-5abbc12ce690
Version Independent ID: 1a2c257a-56bf-fedb-d72c-e0cb3f25462d
Content: Create and configure connections
Content Source: topics/lab-create-configure-connections.md
Service: dynamics-365-intelligent-order-management
GitHub Login: @josaw1
Microsoft Alias: josaw

This section has been removed.


Update on READMD.md and CONDUCT.md

Add a Usage section in README.md
Add everyone's email addresses in CONDUCT.md

All good now


AnimationPlayer sometimes not showing animations in editor

Godot version
3.5 rc8, 4.0 alpha 13
System information
Windows 11
Issue description
Sometimes when clicking on an AnimationPlayer node the animation list in the bottom panel of the editor is empty (still visible in the inspector dropdown though). Usually the panel opens automatically when clicking on an animation player node, but with this bug it's not even opening. Animations play when starting the game, they just don't show up in the editor. You also can't click on any buttons, as all of them are disabled (see screenshot below).

The animations have been created in Godot, not Blender or something else.
Steps to reproduce

Close all scenes and the AnimationPlayer panel at the bottom
Open a scene with an AnimationPlayer and a script attached to the root
Open the script
Click on the AnimationPlayer -> nothing happens
Go into 2D/3D view -> nothing shows up. Clicking on the player again also does nothing
Switch to annother node and then back to the player -> now the animations show up in the panel

Minimal reproduction project
No response

Can you confirm this in also 4.0?

Alright, i know why it happens. It's not as bad as i thought it is but it's still a bit annoying.
It only happens when you are in script mode, then select the AnimationPlayer -> empty panel. Switching to the 3D/2D viewport also does not show it. You have to select annother node and then select the Player again. This happens in 3.5 rc8 and master.
Maybe related to #63344.

I updated my original post with reproduction steps

Duplicate of https://github.com/godotengine/godot/issues/63621.


tsc reports error that LS does not

TypeScript Version:  3.9.7 & nightly
Search Terms: diagnostics
Steps

Clone https://github.com/amcasey/node-zwave-js
Check out Repro
npm install --ignore-scripts
lerna run build
Navigate to packages/zwave-js/src/lib/driver/SendThreadMachine.ts line 359
tsc -b -f packages/zwave-js/tsconfig.build.json

Expected behavior: Editor and tsc show the same errors around lines 359 and 368.
Actual behavior: Editor does not show errors.
Notes:

I believe the LocalFix branch is a sensible way to resolve the errors.  Locally, it only build with nightly - not with 3.9.7.
I made a reduced version of the project to investigate perf, but it doesn't exhibit this issue.
Technically, the LS uses tsconfig.json, rather than tsconfig.build.json but they're essentially the same and rejiggering the names to make them use the same tsconfig doesn't affect the behavior.

Hat tip to @AlCalzone for the report.

One word: Variance
This has taken a long time to chase down, as the chain of events occurring to cause the difference between the two clients is quite long; but what it comes down to is file check order affecting the order of variance calculations, which in turn end up affecting relationship comparison results. On the command line, when we try to find the variance for the first type parameter of SendAction, we need to lookup the variance for ActionFunction (which gets marked as Unreliable for using an optional mapped type over its parameter), which in turn looks at ActionMeta, which in turn looks at State, which in turn looks at StateNodeConfig, which in turn looks at InvokeConfig, which in turn looks at TransitionConfig, which in turn looks at AssignAction, which in turn looks at Required, which taints it as Unmeasurable all the way back up that chain and forces structural comparisons. When we then go to lookup the variance of the second type argument of SendAction, we encounter a cached result for the ActionFunction comparison's variance (which failed, and recorded an Unreliable marker), which we then propagate into the second type parameter's variance. This saved result causes it to be marked as neither co- nor contravariant in the second parameter, and is instead an Unreliable Invariant. This later causes us to try to assert invariance, fail, then perform a structural fallback (in just the covariant direction) which also fails, yielding a command line error.
Now in the language service, things go down differently. Ultimately the LS sees SendAction as being bivariant in its first two type parameters, rather than Unreliable/Unmeasurable and fails to report an error. I'm still looking into where, exactly the LS's variance calculation goes off the rails and what I can do to keep it synced up, but figured I should post an update.

@weswigham if, along the way, you happen to notice a way to short-circuit some of these variance checks (probably by updating xstate), it seems like it would be a big perf win.


Add banner to official realeses

Should state release version and also link to this repo.
Since ReDoc switched to webpack this plugin can be used:
https://webpack.github.io/docs/list-of-plugins.html#bannerplugin

Or this external tool can be used.
This one (https://github.com/jonschlinkert/add-banner) automatically get the version from package.json


Fake version 2.0.0 in Ledger Live

Hi I just updated to a version 2.0.0 from the store:

This version does not seem to exist. Thus I cannot verify what I am running at the moment.
Please advise.

Hello @RoanBrand. The new app is compiled from https://github.com/LedgerHQ/app-bitcoin-new.
Most likely, later we will move everything back to this repository, but as an interim solution we have two repos.
I will add a link to the new repo, thanks for your comment!


When a job fails without junit failures, capture the tail of build-log.txt

Will capture some failure modes that ci-operator can't capture.
For instance, https://openshift-gce-devel.appspot.com/build/origin-ci-test/pr-logs/pull/openshift_console/1336/pull-ci-openshift-console-master-images/3053

/refresh

/test images


Branch add command history

Adds new command history feature.
Users are now able to access their past commands by using the ↑ and ↓ arrow keys.
Closes #137

Codecov Report
Attention: Patch coverage is 67.24138% with 19 lines in your changes missing coverage. Please review.
Files with missing lines	Patch %	Lines
src/main/java/seedu/address/ui/CommandBox.java	0.00%	14 Missing ⚠
...ain/java/seedu/address/storage/CommandHistory.java	88.63%	1 Missing and 4 partials ⚠
Files with missing lines	Coverage Δ	Complexity Δ
...ain/java/seedu/address/storage/CommandHistory.java 88.63% <88.63%> (ø) 15.00 <15.00> (?)
src/main/java/seedu/address/ui/CommandBox.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)

The methods that are not tested are mostly UI relevant methods and have been manually tested.


Property name in documentation is incorrect

The setup guides specify that test-prop is the property name, but then
all later examples use test as the property name. This is obviously
wrong, and this patch fixes that.

retest this please


Resetting scrap settings in LethalQuantities mod

Funnily enough, I found another problem
This mod somehow resets the scrap settings in the LethalQuantities mod, meaning that whatever you adjust, everything goes back to vanilla values. Maybe it's a LethalQuantities mod problem I don't know exactly, but it's probably not likely^_^

Yeah sadly that must be something on LQ's side; for the moons I'm doing my own custom information and settings but all the other tools/scrap settings I'm grabbing and printing directly from the main game :/


implement androidx.fragment:fragment:1.3.0-alpha06

Merged into ltman/production
https://github.com/ltman/Matisse/pull/5


Support URLs for Postgrex configuration

To make things a little easier when deploying (esp. Heroku) here's a small change to allow you to use URLs for the database configuration.
   config :eventstore, EventStore.Storage,
      url: "postgres://username:password@host/database"

Let me know if there is anything I'm missing, I wasn't quite sure on the README - since what you have there is super clean and gets you up and running quickly, felt this may distract from that.

@stuartc Thanks for the PR, merged.


Landing page - mentor, mentee or both?

There should be a landing page, where users can select whether to be a mentor, mentee, or both.

Simple, clean, but interesting design
I thought this was interesting: http://manuals.gravitydept.com/


[minor] Typo/Grammatical Corrections

[ ] An issue should be filed for the change unless this is a trivial change (fixing a typo or similar). One issue should ideally be fixed by not more than one commit and the other way round, each commit should fix just one issue, without pulling in other changes.
[ ] Each commit in the pull request should have a meaningful and properly spelled subject line and body. Copying the title of the associated issue is typically enough. Please include the issue number in the commit message prefixed by #.
[ ] The pull request description should explain what the pull request does, how, and why. If the info is available in the associated issue or some other external document, a link is enough.
[ ] Phrases like Fix # or Fixes # will auto-close the named issue upon merging the pull request. Using them is typically a good idea.
[ ] Please run mvn process-resources -Pformat (and amend the changes if necessary) before sending the pull request.
[ ] Contributor guide is your good friend: https://camel.apache.org/camel-quarkus/latest/contributor-guide.html

Let me know if any changes are expected on my end

Let me know if any changes are expected on my end

Please drop commits a52f441 & 607dfda from this PR.

Review comments added

let me cherry-pick 95180f6 and 954a1f4 manually to avoid four unnecessary commits

Cherry-picked as 8554bd6777d1b3b6c4555347359dbd6cf9f2e7d5 and a5ee3fa131ce84813c443cf9ada376c53c4fb196 in the master. Thanks @PoojaChandak !


fix: upstream nodes filed IP occupation.

Type of change:

[x] Bugfix
[ ] New feature provided
[ ] Improve performance
[ ] Backport patches

What this PR does / why we need it:

Pre-submission checklist:

[ ] Did you explain what problem does this PR solve? Or what new features have been added?
[ ] Have you added corresponding test cases?
[ ] Have you modified the corresponding document?
[ ] Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

Codecov Report

Merging #1064 (9094531) into master (f6f0a3b) will decrease coverage by 0.13%.
The diff coverage is 32.12%.

@@            Coverage Diff             @@
##           master    #1064      +/-   ##
==========================================
- Coverage   30.82%   30.69%   -0.14%
==========================================
  Files          74       78       +4
  Lines        8606     9273     +667
==========================================
+ Hits         2653     2846     +193
- Misses       5670     6122     +452
- Partials      283      305      +22

Impacted Files
Coverage Δ

pkg/apisix/apisix.go
61.36% <ø> (ø)

pkg/ingress/endpoint.go
0.00% <0.00%> (ø)

pkg/apisix/upstreamservicerelation.go
3.52% <3.52%> (ø)

pkg/apisix/cluster.go
31.89% <33.33%> (+<0.01%)
:arrow_up:

pkg/apisix/nonexistentclient.go
43.27% <61.22%> (-1.54%)
:arrow_down:

pkg/apisix/cache/memdb.go
75.55% <76.47%> (+0.07%)
:arrow_up:

pkg/apisix/upstream.go
39.73% <100.00%> (+2.49%)
:arrow_up:

pkg/kube/translation/apisix_pluginconfig.go
36.66% <0.00%> (-36.67%)
:arrow_down:

pkg/kube/translation/plugin.go
57.54% <0.00%> (-12.76%)
:arrow_down:

pkg/kube/translation/apisix_consumer.go
67.74% <0.00%> (-1.49%)
:arrow_down:

... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 49dd015...9094531. Read the comment docs.


Add a flag to print filenames as they're being compiled (even if they are not updated in output)

Here's my situation: I'm using nanoc with asciidoctor to build a static site from adoc files.
The trouble I have is specific to this combination, but might appear with other filters as well.
asciidoctor prints warnings to stderr, but without the context of which file was being processed, they aren't very useful.
If I could get nanoc to print the filenames being compiled (e.g. with --verbose), I would see a filename followed by a set of warnings.
The degree to which I can customize the asciidoctor behavior is limited. I can get it to show file basenames in its warnings, but not full paths. And its -Werror-like option only seems to work with command-line invocations.
There are some related open asciidoctor issues, and there's more that they could do on this too, to be sure. But my scenario lives at the intersection of these two tools, so it's equally reasonable for me to look to nanoc to solve it.
For now, I've added a custom filter which uses the asciidoctor gem (almost identical to the built-in asciidoctor filter) and checks for an env var, NANOC_ADOC_DEBUG=1. If it's set, it prints the item identifier every time it runs. It's a viable workaround, and I am very happy that nanoc makes it possible, but I'd be even happier if nanoc had some flag I could set to ensure that all item names are printed.

I don't think you should reason in filenames.
What's given to Asciidoctor might not even be a file.
I'm not sure how but the stock :asciidoctor filter should imho capture errors and eventually print them along with item's identifier.

I don't think you should reason in filenames.
What's given to Asciidoctor might not even be a file.

By this, I assume you're referring to the possibility of other data sources for items.
That's fair. My case is using the filesystem, but the thing that matters to me is to be able to see a warning which a filter emitted on stderr and map that back to the item which produced the error.
If I could get item identifiers, my use-case would be satisfied -- because the identifiers will be filenames for me.

I'm not sure how but the stock :asciidoctor filter should imho capture errors and eventually print them along with item's identifier.

Given that a filter can be calling out to an arbitrary library, it's possible that the lib in question is writing warnings directly to stdout or stderr. The only generic way I can think for nanoc to handle this, without enforcing that filters happen in a separate process, is to capture the standard streams, recording anything which the filter might write there, and then check if it's empty.
If the parallel build support ever merges, a sophisticated approach like that might be necessary in order to mux together the output from various filters.
But for today, just getting nanoc to emit the item identifiers would be sufficient and solve this problem.

I think it’d be reasonable for Nanoc to print the item rep identifiers + names when --verbose is specified twice — what do you think?

If the parallel build support ever merges

It won’t be soon, I’m afraid… I believe Nanoc needs some architectural rework for parallel compilation to be implemented in a solid, reliable way.

Hmm — even without parallel compilation, the output is confusing. Take this as an example:
Loading site… done
Compiling site…
       start  /sitemap.xml.erb (rep name :default)
       start  /sitemap.xml.erb (rep name :latex)
       start  /favicon.ico (rep name :default)
       start  /favicon.ico (rep name :latex)
       start  /404.dmark (rep name :default)
       start  /release-notes.md (rep name :default)
      create  [0.00s]  output/favicon.ico
      create  [0.04s]  output/sitemap.xml
lib/helpers/release_notes.rb:19: warning: deprecated Object#=~ is called on Nokogiri::XML::Element; it always returns nil
       start  /404.dmark (rep name :default)
       start  /404.dmark (rep name :latex)
       start  /style-guide.dmark (rep name :latex)
       start  /style-guide.dmark (rep name :default)
      create  [0.39s]  output/release-notes/index.html
      create  [0.00s]  output/404.html
       start  /whats-new.dmark (rep name :latex)

Note this message:
lib/helpers/release_notes.rb:19: warning: deprecated Object#=~ is called on Nokogiri::XML::Element; it always returns nil

(which is probably something I should fix, but let’s ignore that for now)
This message appears after
      create  [0.00s]  output/favicon.ico
      create  [0.04s]  output/sitemap.xml

… which happens because Nanoc writes files async. So, it is not quite clear where messages are originating from.

I think it’d be reasonable for Nanoc to print the item rep identifiers + names when --verbose is specified twice — what do you think?

Yeah, --verbose --verbose is totally fine and reasonable in my book.
It was one of the options I tried when I was looking at whether not anything existed today -- before I even looked at documentation -- which suggests, anecdotally at least, that others might try it too.
I don't much care how it's enabled. Mainly, I want to be able to turn this on in our CI builds.

If the parallel build support ever merges

It won’t be soon, I’m afraid… I believe Nanoc needs some architectural rework for parallel compilation to be implemented in a solid, reliable way.

Yeah, I figured it was difficult based on the fact that you've done a proof of concept a while back but it hasn't merged.
No pressure from me on this, certainly! We'd love to have parallel builds, of course, but cutting our build from 19 seconds to 10 seconds just isn't that important. 😄

This message appears after
[...]
which happens because Nanoc writes files async.

When I started emitting identifiers in my filter code, it always seemed to sync up correctly. Was I just getting lucky in my tests, or is there a step like "filter and write" which is being executed atomically?
I'm just curious if (1) my workaround is prone to failure (2) maybe there's something in how that's executed which helps show a way to do this?


willRespondWith headers are filtered

Software versions

MAC OS
8.1.2/74293
v10.12.0

Expected behaviour
willRespondWith: {
  status: 503,
  headers: {
    'Retry-After': '1000',
    'Content-Type': 'application/json'
  }
}

should have an error.response.headers with ..
{
    'Retry-After': '1000',
    'Content-Type': 'application/json'
}

Actual behaviour
Returns with:
{
    'Content-Type': 'application/json'
}

Can anyone tell me why the headers would be filtering ?  I have tried this across several teams at my company and they all run into this same issue.  Checking to see if this is an issue with pact-node.  Thank you.

Closing, see pact js issue.


Tests fail if vint is not installed

Hello.
test/acceptance/test_cli.py calls vint with args. When vint isn't installed there is no vint command in PATH, so tests fail. Also relying on the installed vint executable defies testing purposes as already installed version is tested, not the current one.
Solution: explicitly call bin/vint. Fix: sed -i -e "s|'vint'|'bin/vint'|g" test/acceptance/test_cli{,_vital}.py

@Kuniwak, need PR? Really? The sed line with fix is in the OP...

Fixed in 8c34196.


Update the docs' cadvisor unit file

Hi,
Newbie here. As you've seen in the previous issue ;).
I'm testing the platform, randomly resetting machines and seeing if I can manage to nurse the clusters back to health again. It seems to be doing alright, but of course, there's no load on the platform.
Anyway, as a part of trying to get some diagnostics into each of the services running in docker, I installed cadvisor according to the docs with a unit file that I did fleetctl start cadvisor.service, which started it across all three nodes that I have in my vagrant cluster.
I then reset a single node, node 3 and watched whether things would still show up and route properly. They did.
Now I started it again.
Here's where the first question comes: if a node reboots, why doesn't deisctl status tell me about it? It's just blank, exiting 0.
Also, when the node goes back up, not all unit are automatically started, even though they should optimally be started as soon as possible to ensure availability: specifically:
deis-store-daemon.service		169914f2.../<IP_ADDRESS>	activating	start-pre
and
deis-logspout.service			169914f2.../<IP_ADDRESS>	activating	auto-restart
I had to run deisctl start platform for them to start. I didn't manage any fleetctl command that made a difference. At this point it was a bit opaque.
When they had started, I noticed that cadvisor looked like this:
UNIT					MACHINE				ACTIVE		SUB
cadvisor.service			169914f2.../<IP_ADDRESS>	failed		failed
cadvisor.service			21d1548b.../<IP_ADDRESS>	active		running
cadvisor.service			28ed8692.../<IP_ADDRESS>	active		running
deis-builder.service			21d1548b.../<IP_ADDRESS>	active		running
# snip

As it turns out, it didn't want to start again, because, according to journalctl (deisctl journal didn't want to give me anything:
$ deisctl journal cadvisor
Unable to get journal for global unit cadvisor.service. Check the logs on the host using journalctl.

) despite it being a global unit.
$ journalctl -fu cadvisor
Mar 06 23:00:33 deis-03 systemd[1]: Starting Google Container Advisor...
Mar 06 23:00:33 deis-03 systemd[1]: Started Google Container Advisor.
Mar 06 23:00:33 deis-03 docker[3135]: time="2015-03-06T23:00:33Z" level="fatal" msg="Error response from daemon: Conflict, The name cadvisor is already assigned to 0dc97d3eb6b8. You have to delete (or rename) that container to be able to assign cadvisor to a container again."
Mar 06 23:00:33 deis-03 systemd[1]: cadvisor.service: main process exited, code=exited, status=1/FAILURE
Mar 06 23:00:33 deis-03 systemd[1]: Unit cadvisor.service entered failed state.
Mar 06 23:00:33 deis-03 systemd[1]: cadvisor.service failed.

How to start cadvisor again? Do I have to manually go through and SSH to all machines to docker rm -f cadvisor the containers and their images?
And why don't needed containers, such as the ceph monitor container, start when the node goes back up?   ;)

It also seems that docker ps -a | grep cadvis | awk '{ print $1 }' | xargs docker rm followed by fleetctl start cadvisor.service still lists cadvisor as 'failed'...

Answering my own question: the reason is that the unit file is not as robustly written as the other unit files.
The other unit files seem to do a docker rm -f, so the help should be updated to make cadvisor's unit file match those.
Here's the improved unit-file which now matches other other deis unit files:
[Unit]
Description=Google Container Advisor
Requires=docker.socket
After=docker.socket

[Service]
ExecStartPre=/bin/sh -c "docker history google/cadvisor:latest >/dev/null || docker pull google/cadvisor:latest"
ExecStartPre=/bin/sh -c "docker inspect cadvisor >/dev/null && docker rm -f cadvisor || true"
ExecStart=/usr/bin/docker run --volume=/:/rootfs:ro --volume=/var/run:/var/run:rw --volume=/sys:/sys:ro --volume=/var/lib/docker/:/var/lib/docker:ro --publish=8080:8080 --name=cadvisor google/cadvisor:latest
ExecStopPost=-/usr/bin/docker rm -f cadvisor
Restart=on-failure
RestartSec=5

[Install]
WantedBy=multi-user.target

[X-Fleet]
Global=true

Thanks! This documentation was provided by the community, so any improvements to the existing documentation would be helpful.

Where are they updated? Will you take the changes specified in this thread and merge?

docs is our documentation hosted at http://docs.deis.io. Any changes made there via Pull Request will show on the site.

Closing in favor of the PR. Merge/reject at your pleasure.


Fix snap builds

Use core18
Update the building section to be conformant with latest recommendations

Fixes #366
Signed-off-by: Adam Stokes<EMAIL_ADDRESS>

if you hook up github with snapcraft.io, it'll use launchpad to automatically build snaps.

You said something like the above on IRC - Unfortunately, I don't understand what you're saying. Can you point me to a howto or something to set this up?

You said something like the above on IRC - Unfortunately, I don't understand what you're saying. Can you point me to a howto or something to set this up?

There are a couple of ways to do this, one is through travis-ci:
https://tutorials.ubuntu.com/tutorial/continuous-snap-delivery-from-travis-ci#0
The other way is to hook it up through snapcraft.io directly:
https://snapcraft.io/build
This will auth against your github account and do the build automatically

I will add the snippet below to the README after we've merged this:
[![Get it from the Snap Store](https://snapcraft.io/static/images/badges/en/snap-store-black.svg)](https://snapcraft.io/convos)

Thank you so much for the two links! I've set it up through https://snapcraft.io/build now, but it's failing since we haven't merged this PR :)

Awesome! Thank you 👍


Minor formatting change

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@28f36eb). Click here to learn what that means.
The diff coverage is 100%.

@@            Coverage Diff            @@
##             master     #498   +/-   ##
=========================================
  Coverage          ?   63.78%
=========================================
  Files             ?       38
  Lines             ?     4840
  Branches          ?        0
=========================================
  Hits              ?     3087
  Misses            ?     1753
  Partials          ?        0

Looks good to me. Thanks.


@sap/hdi-deploy 3.11.12 fails to deploy into HDI container, previous 3.11.11 works

Dear support,
We are not able to deploy artifacts into HDI container with @sap/hdi-deploy 3.11.12.
We can deploy with previous @sap/hdi-deploy 3.11.11.
We use following packages for MTA deployment:
  "dependencies": {
    "@sap/cds": "^4.1.5",
    "@sap/hana-client": "^2.5.104",
    "mbt": "^1.0.16",
    "passport": "^0.4.1"
  },
  "devDependencies": {
    "@sap/cds-dk": "^3.1.4"
  },

We use following files for HDI deployment:
cds/db/package.json
{
  "name": "deploy",
  "dependencies": {
    "@sap/hdi-deploy": "3.11.12"
  },
  "scripts": {
    "start": "node<EMAIL_ADDRESS>--auto-undeploy --verbose"
  }
}

cds/db/src/defaults/default_access_role.hdbrole
{
	"role": {
		"name": "default_access_role",
		"schema_privileges": [{
			"privileges": ["SELECT", "INSERT", "UPDATE", "DELETE", "EXECUTE", "CREATE TEMPORARY TABLE", "SELECT CDS METADATA"]
		}],
		"schema_analytic_privileges": [{
			"privileges": [
				"W_EMPLOYEE_03_AP"
			]
		}]
	}
}

cds/db/src/W_EMPLOYEE_03_AP.hdbanalyticprivilege
<?xml version="1.0" encoding="UTF-8"?>
<Privilege:analyticPrivilege xmlns:Privilege="http://www.sap.com/ndb/BiModelPrivilege.ecore" id="W_EMPLOYEE_03_AP" privilegeType="SQL_ANALYTIC_PRIVILEGE" schemaVersion="1.1">
<descriptions defaultDescription="W_EMPLOYEE_03_AP"/>
<securedModels>
  <modelUri>W_EMPLOYEE_03</modelUri>
</securedModels>
<whereSql>"EMPLOYEE_ACCOUNTID" = (select accountId from INF_USERPARAM where userEmail = SESSION_CONTEXT('APPLICATIONUSER'))</whereSql>
</Privilege:analyticPrivilege>

cds/db/src/W_EMPLOYEE_03.hdbcalculationview
...

Deployment of HDI container:
2020-10-28T19:08:27.469+0000 [CELL/0] OUT Cell 6cda2496-70c8-4c74-8e9d-cd5101e233e9 creating container for instance 8f20a042-fd5f-4f93-9ac3-03789a280541
2020-10-28T19:08:28.909+0000 [CELL/0] OUT Cell 6cda2496-70c8-4c74-8e9d-cd5101e233e9 successfully created container for instance 8f20a042-fd5f-4f93-9ac3-03789a280541
2020-10-28T19:08:36.047+0000 [APP/TASK/deploy/0] OUT > deploy@ start /home/vcap/app
2020-10-28T19:08:36.047+0000 [APP/TASK/deploy/0] OUT > node<EMAIL_ADDRESS>--auto-undeploy --verbose
2020-10-28T19:08:37.354+0000 [APP/TASK/deploy/0] OUT @sap/hdi-deploy, version 3.11.12 (mode default), server version <IP_ADDRESS>.1602165697 (<IP_ADDRESS>), node version 10.22.0, HDI version 1004, container API version 1003
2020-10-28T19:08:37.449+0000 [APP/TASK/deploy/0] OUT No ignore file at /home/vcap/app/.hdiignore.
2020-10-28T19:08:37.449+0000 [APP/TASK/deploy/0] OUT Collecting files...
2020-10-28T19:08:37.538+0000 [APP/TASK/deploy/0] OUT Collecting files... ok (0s 88ms)
2020-10-28T19:08:37.538+0000 [APP/TASK/deploy/0] OUT 3 directories collected
2020-10-28T19:08:37.538+0000 [APP/TASK/deploy/0] OUT 64 files collected
2020-10-28T19:08:37.538+0000 [APP/TASK/deploy/0] OUT 0 reusable modules collected
2020-10-28T19:08:37.538+0000 [APP/TASK/deploy/0] OUT Target service: hana-cloud-analytics-db-hdi-container
2020-10-28T19:08:37.845+0000 [APP/TASK/deploy/0] OUT Session variable APPLICATION is set to "SAP_HDI/dev/sbn_global_isg-dev".
2020-10-28T19:08:38.082+0000 [APP/TASK/deploy/0] OUT Previous build with request ID 24549 finished at 2020-10-28 19:07:49.357267000 with status Committed and message: Starting make in the container "9193774E6AA342B79C53E9AA886C0DEB" with 0 files to deploy, 0 files to undeploy... ok.
2020-10-28T19:08:38.082+0000 [APP/TASK/deploy/0] OUT Processing revoke files...
2020-10-28T19:08:38.082+0000 [APP/TASK/deploy/0] OUT Processing revoke files... ok (0s 0ms)
2020-10-28T19:08:38.082+0000 [APP/TASK/deploy/0] OUT Processing grants files...
2020-10-28T19:08:38.082+0000 [APP/TASK/deploy/0] OUT Processing grants files... ok (0s 0ms)
2020-10-28T19:08:38.084+0000 [APP/TASK/deploy/0] OUT Preprocessing files...
2020-10-28T19:08:38.085+0000 [APP/TASK/deploy/0] OUT Preprocessing files... ok (0s 0ms)
2020-10-28T19:08:38.085+0000 [APP/TASK/deploy/0] OUT Connecting to the container "9193774E6AA342B79C53E9AA886C0DEB"...
2020-10-28T19:08:38.268+0000 [APP/TASK/deploy/0] OUT Connecting to the container "9193774E6AA342B79C53E9AA886C0DEB"... ok (0s 183ms)
2020-10-28T19:08:38.269+0000 [APP/TASK/deploy/0] OUT Locking the container "9193774E6AA342B79C53E9AA886C0DEB"...
2020-10-28T19:08:38.610+0000 [APP/TASK/deploy/0] OUT Locking the container "9193774E6AA342B79C53E9AA886C0DEB"... ok (0s 342ms)
2020-10-28T19:08:38.611+0000 [APP/TASK/deploy/0] OUT Synchronizing files with the container "9193774E6AA342B79C53E9AA886C0DEB"...
2020-10-28T19:08:39.305+0000 [APP/TASK/deploy/0] OUT Synchronizing files with the container "9193774E6AA342B79C53E9AA886C0DEB"... ok (0s 694ms)
2020-10-28T19:08:39.478+0000 [APP/TASK/deploy/0] OUT 0 modified or added files are scheduled for deploy based on delta detection
2020-10-28T19:08:39.478+0000 [APP/TASK/deploy/0] OUT 0 deleted files are scheduled for undeploy based on delta detection (filtered by undeploy whitelist)
2020-10-28T19:08:39.479+0000 [APP/TASK/deploy/0] OUT 0 files are scheduled for deploy based on explicit specification
2020-10-28T19:08:39.479+0000 [APP/TASK/deploy/0] OUT 0 files are scheduled for undeploy based on explicit specification
2020-10-28T19:08:39.479+0000 [APP/TASK/deploy/0] OUT Deploying to the container "9193774E6AA342B79C53E9AA886C0DEB"...
2020-10-28T19:08:39.676+0000 [APP/TASK/deploy/0] OUT Polling messages for request id: 24556
2020-10-28T19:08:39.693+0000 [APP/TASK/deploy/0] OUT  Starting make in the container "9193774E6AA342B79C53E9AA886C0DEB" with 0 files to deploy, 0 files to undeploy...
2020-10-28T19:08:39.693+0000 [APP/TASK/deploy/0] OUT   Enabling table replication for the container schema "9193774E6AA342B79C53E9AA886C0DEB"...
2020-10-28T19:08:39.694+0000 [APP/TASK/deploy/0] OUT   Enabling table replication for the container schema "9193774E6AA342B79C53E9AA886C0DEB"... ok  (0s 2ms)
2020-10-28T19:08:39.694+0000 [APP/TASK/deploy/0] OUT  Starting make in the container "9193774E6AA342B79C53E9AA886C0DEB" with 0 files to deploy, 0 files to undeploy... ok  (0s 6ms)
2020-10-28T19:08:39.694+0000 [APP/TASK/deploy/0] OUT Deploying to the container "9193774E6AA342B79C53E9AA886C0DEB"... ok (0s 215ms)
2020-10-28T19:08:39.695+0000 [APP/TASK/deploy/0] OUT Default-access-role file "src/defaults/default_access_role.hdbrole" scheduled for deploy; global role "9193774E6AA342B79C53E9AA886C0DEB::access_role" will be adapted
2020-10-28T19:08:39.695+0000 [APP/TASK/deploy/0] OUT Granting container-local default access role "9193774E6AA342B79C53E9AA886C0DEB"."default_access_role" to global role "9193774E6AA342B79C53E9AA886C0DEB::access_role"...
2020-10-28T19:08:39.861+0000 [APP/TASK/deploy/0] OUT Granting container-local default access role "9193774E6AA342B79C53E9AA886C0DEB"."default_access_role" to global role "9193774E6AA342B79C53E9AA886C0DEB::access_role"... ok (0s 167ms)
2020-10-28T19:08:39.861+0000 [APP/TASK/deploy/0] OUT Revoking default permission set from global role "9193774E6AA342B79C53E9AA886C0DEB::access_role"...
2020-10-28T19:08:40.062+0000 [APP/TASK/deploy/0] ERR Deployment to container 9193774E6AA342B79C53E9AA886C0DEB failed - error: HDI call failed! [Deployment ID: none].
2020-10-28T19:08:40.063+0000 [APP/TASK/deploy/0] ERR Error: HDI call failed!
2020-10-28T19:08:40.064+0000 [APP/TASK/deploy/0] OUT (3s 624ms)
2020-10-28T19:08:40.071+0000 [APP/TASK/deploy/0] ERR npm ERR! code ELIFECYCLE
2020-10-28T19:08:40.072+0000 [APP/TASK/deploy/0] ERR npm ERR! errno 1
2020-10-28T19:08:40.074+0000 [APP/TASK/deploy/0] ERR npm ERR! deploy@ start: `node<EMAIL_ADDRESS>--auto-undeploy --verbose`
2020-10-28T19:08:40.074+0000 [APP/TASK/deploy/0] ERR npm ERR! Exit status 1
2020-10-28T19:08:40.074+0000 [APP/TASK/deploy/0] ERR npm ERR!
2020-10-28T19:08:40.074+0000 [APP/TASK/deploy/0] ERR npm ERR! Failed at the deploy@ start script.
2020-10-28T19:08:40.074+0000 [APP/TASK/deploy/0] ERR npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
2020-10-28T19:08:40.303+0000 [APP/TASK/deploy/0] ERR npm ERR!


Transcoder failure after 10-20 sec

After 10-20sec in a live-tv stream the stream always closes and throws an error.
I've been looking at the plex media server log and the only thing that stands out is this:
un 19, 2018 22:58:59.718 [9872] DEBUG - Completed: [<IP_ADDRESS>:61899] 200 GET /livetv/sessions/c8fc4d80-d237-4063-b553-82a387de6403/5wj6nxxa128f5ohcn5mdamif/00017.ts (20 live) 4ms 109792 bytes (pipelined: 1)
Jun 19, 2018 22:58:59.787 [8316] DEBUG - Transcoder segment range: 0 - 35
Jun 19, 2018 22:58:59.799 [2612] ERROR - Caught exception trying to stream file: C:\Users\MJP\AppData\Local\Plex Media Server\Cache\Transcode\Sessions\plex-transcode-c8fc4d80-d237-4063-b553-82a387de6403\media-00017.ts: write: En begäran att skicka eller ta emot data tilläts inte eftersom socketen redan avslutats i den riktningen vid ett tidigare anrop
Jun 19, 2018 22:58:59.801 [10540] DEBUG - Completed after connection close: [<IP_ADDRESS>:61752] 500 GET /livetv/sessions/c8fc4d80-d237-4063-b553-82a387de6403/5wj6nxxa128f5ohcn5mdamif/00017.ts (22 live) 88ms 0 bytes (pipelined: 3)
Jun 19, 2018 22:58:59.915 [8796] DEBUG - Transcoder segment range: 0 - 36

basiclly that swedish text says:
A request to send or receive data was disallowed because the socket had already been shut down in that direction with a previous shutdown call.
And that is a Windows Sockets error:
WSAESHUTDOWN 10058

Same problem here, using Unraid as a server and with all the clients it does that. Strange behaviour.

Same problem... I was not even trasncoding...
I was recording a .ts stream that otherwise works ok when opened with VLC...

@bhaap does this issue still persist on newer versions of Telly?

Hi folks,
As @guyspr suggested, please try the dev branch (especially the ffmpeg one)
Let us know if you're still having issues.


[$250] Distance - Invalid waypoint stays on suggestion list

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 9.0.29-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4919784
Email or phone of affected tester (no customers<EMAIL_ADDRESS>Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team
Action Performed:

Navigate to staging.new.expensify.com
Create a workspace
Go to workspace chat
Go offline
Go to submit distance expense
Enter an invalid waypoint
Go back to workspace chat
Go online
Start a distance expense flow
Click on start waypoint and see the suggestion list

Expected Result:
Invalid waypoints should be removed from suggestion list
Actual Result:
Invalid waypoints stay on the suggestion list
Workaround:
unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android: Native
[x] Android: mWeb Chrome
[ ] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos
https://github.com/user-attachments/assets/d2be0938-fc4d-4a7d-aea8-d08308628f26

View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~021833644939720857104
Upwork Job ID:<PHONE_NUMBER>720857104
Last Price Increase: 2024-09-10

Issue OwnerCurrent Issue Owner: @suneox

We think this issue might be related to the #collect project.

@nyomanjyotisa  Thank you for your proposal, but we also need to prevent selecting invalid waypoints when the network is slow or offline.

Proposal
Please re-state the problem that we are trying to solve in this issue.
Invalid waypoints stay on the suggestion list
What is the root cause of that problem?
Here we only check the waypoint is empty or not to decide to save this waypoint to recent list
https://github.com/Expensify/App/blob/1e8d80e850af52e60ec0fefbe11553cc196e8fee/src/libs/actions/Transaction.ts#L127-L130
What changes do you think we should make in order to solve the problem?
We can use the waypointHasValidAddress function as we do here to check the waypoint is valid or not before saving it to recent list
if (!recentWaypointAlreadyExists && waypoint && TransactionUtils.waypointHasValidAddress(waypoint)) {
    const clonedWaypoints = lodashClone(recentWaypoints);
    clonedWaypoints.unshift(waypoint);
    Onyx.merge(ONYXKEYS.NVP_RECENT_WAYPOINTS, clonedWaypoints.slice(0, CONST.RECENT_WAYPOINTS_NUMBER));
}

https://github.com/Expensify/App/blob/1e8d80e850af52e60ec0fefbe11553cc196e8fee/src/libs/actions/Transaction.ts#L127-L130
What alternative solutions did you explore? (Optional)

@johncschuster I’d like to confirm should we prevent selecting invalid waypoints in offline mode? (currently, we don’t validate waypoints in offline mode) to maintain consistency with the online flow.
https://github.com/user-attachments/assets/23dd6229-13a4-475d-9403-948f6f2e0e11

but we also need to prevent selecting invalid waypoints when the network is slow or offline.

Why so? Don't we do that validation when you come back online? 🤔 CC: @neil-marcellini for vis on this issue.

I think we should only prevent saving invalid waypoints to the recent list because if we prevent selecting invalid waypoint in offline, the user that doesn't have recent waypoints list can't create distance request in offline.

I think we should only prevent saving invalid waypoints to the recent list because if we prevent selecting invalid waypoint in offline, the user that doesn't have recent waypoints list can't create distance request in offline.

I agree. We shouldn't save invalid waypoints to recents, they're useless. But we shouldn't prevent selecting invalid waypoints, because we don't know if they are valid or not when you're offline, so then you couldn't create a distance request when offline.

But we shouldn't prevent selecting invalid waypoints, because we don't know if they are valid or not when you're offline, so then you couldn't create a distance request when offline.

Based on the expected result @nkdengineer proposal LGTM
🎀 👀 🎀 C+ reviewed

I’d like to clarify that the selected solution is to prevent saving an invalid waypoint, rather than filtering out the invalid waypoints in the list. The implementation details can be addressed during the code review process. The alternative solution proposed by @nyomanjyotisa is the same as @nkdengineer solution, which is to prevent saving an invalid waypoint. However, I selected @nkdengineer proposal because it was posted before @nyomanjyotisa notify an update.
But I just double-checked, and it turns out that the updated proposal (at 2024-09-11T03:14:11Z) was actually submitted before the new proposal (at 2024-09-11T03:14:32Z).
Sorry everyone, this was my mistake for not checking the detailed update times, so I’ve updated the selected proposal accordingly.

Hi, sorry for the delay. I reviewed all proposals and I would like to suggest something different.
The root cause of the issue, in my opinion, is that the optimistically saved recent waypoints are not updated when we receive an error from the backend that the distance request failed to create, because the waypoints are invalid.
Idk if the error is that specific, but if a distance request fails to create then we should remove the waypoints it contains from the recent waypoints. A potential problem is if the recent waypoints already contain 'validAddressA' and the failed distance expense contains waypoints 'validAddressA', 'invalidAddressB'. We wouldn't want to remove 'validAddressA' from the recent waypoints, in that case. Therefore we'll also need mark new waypoints in the recent waypoints list as pending to be added, and on failure only remove those that are pending addition to the recent waypoints list.
Does that sounds good to you all? The first person to update or post a good proposal following this plan will be assigned.

@neil-marcellini But we will save the waypoint to the recent list when we select the waypoint and we can have a case that user can enter an invalid waypoint then edit to another before creating the distance request.

Ok, interesting point. I think that flow would work like this.
The user enters an invalid waypoint, it's saved to the recent waypoint list optimistically and marked as pending add. Then, the user edits it to a valid waypoint which is also saved to recent waypoints as pending add. The request succeeds and an Onyx update with method 'set' returns the proper recent waypoints, clearing the invalid one.
In the same case where an invalid waypoint is edited to a valid one, but where there is still at least one invalid waypoint, the failure data set up in the response should reset the recent waypoints list to one where all waypoints are not pending addition.
I think that should all work. Any more questions?

Bumping Slack for proposals

Proposal
Please re-state the problem that we are trying to solve in this issue.
Invalid waypoints remain on the suggestion list when creating a distance request.
What is the root cause of that problem?
We are not revert the recent waypoints if something error when creating distance request.
What changes do you think we should make in order to solve the problem?
We can revert recentWaypoints to the latest validated value if error occurs.
getRecentWaypoints() can be from Transaction action or as createDistanceRequest param
src/libs/actions/IOU.ts

createDistanceRequest(
.....
    const recentServerValidatedWaypoints = getRecentWaypoints().filter(item => !item.pendingAction)
    onyxData?.failureData?.push({
        onyxMethod: Onyx.METHOD.SET,
        key: `${ONYXKEYS.NVP_RECENT_WAYPOINTS}`,
        value: recentServerValidatedWaypoints,
    } )

    API.write(WRITE_COMMANDS.CREATE_DISTANCE_REQUEST, parameters, onyxData);
 .....

Flag new waypoint
src/libs/actions/Transaction.ts
function saveWaypoint(transactionID: string, index: string, waypoint: RecentWaypoint | null, isDraft = false) {
..........
    const recentWaypointAlreadyExists = recentWaypoints.find((recentWaypoint) => recentWaypoint?.address === waypoint?.address);
    if (!recentWaypointAlreadyExists && waypoint !== null) {
        const clonedWaypoints = lodashClone(recentWaypoints);
        waypoint.pendingAction = CONST.RED_BRICK_ROAD_PENDING_ACTION.ADD;
        clonedWaypoints.unshift(waypoint);
        Onyx.merge(ONYXKEYS.NVP_RECENT_WAYPOINTS, clonedWaypoints.slice(0, CONST.RECENT_WAYPOINTS_NUMBER));

I think we don't need to clear pendingField, since the server response will be SET if success, but let me know if that's required
Branch for this solution
What alternative solutions did you explore? (Optional)
N/A

@wildan-m  Thank you for your proposal. We also need to handle the case for TrackExpense.

I think we don't need to clear pendingField, since the server response will be SET if success, but let me know if that's required

@neil-marcellini  Additionally, we need to clear pendingField because the response data still includes the pendingAction field, to prevent cases where a valid waypoint gets cleared

@wildan-m Thank you for your proposal. We also need to handle the case for TrackExpense.

@suneox it seems track expense also call request money. do you think we need different treatment for track expense?

Additionally, we need to clear pendingField because the response data still includes the pendingAction field, to prevent cases where a valid waypoint gets cleared

I didn't notice that, seems it's more appropriate to clear that in the server side (?)

@suneox it seems track expense also call request money. do you think we need different treatment for track expense?

@wildan-m createDistanceRequest and trackExpense are different cases.

seems it's more appropriate to clear that in the server side

Yep, we’re still waiting for the internal team’s feedback on that point.

@neil-marcellini Additionally, we need to clear pendingField on the BE side because the response data still includes the pendingAction field, to prevent cases where a valid waypoint gets cleared

Sorry, I'm not quite following. Would you please list the steps taken to encounter this problem and show the response that is returned? You can also link to a draft PR if that's needed to test this. Regardless, I think that the frontend should generally handle the pendingAction / pendingFields data. If there's some reason why that's not possible please let me know why.

@neil-marcellini successData is initialized before receiving the server response. The nvp_expensify_recentWaypoints latitude and longitude data are set to 0 before the response is received. If we generate the success data from the front end, it will overwrite the server response with lat: 0, lon: 0.
also the nvp_expensify_recentWaypoints doesn't have stable index key like reportActions, the local and returned data length can be different, we can't rely on array sequence index.

createDistanceRequest and trackExpense are different cases.

@suneox sure, but only the saveWaypoint function modifies NVP_RECENT_WAYPOINTS and it is called in IOURequestStepWaypoint. The track expense feature also utilizes IOURequestStepWaypoint but with different parameters.

Sorry, I'm not quite following. Would you please list the steps taken to encounter this problem and show the response that is returned? You can also link to a draft PR if that's needed to test this. Regardless, I think that the frontend should generally handle the pendingAction / pendingFields data. If there's some reason why that's not possible please let me know why.

I'll prepare a test branch to explain the details ASAP

@neil-marcellini  Currently, the data type for NVP_RECENT_WAYPOINTS is an array, but the Onyx library only supports replacing the entire array. Therefore, after receiving new waypoints from the server, we cannot remove pendingAction in the successful request case by onxyData.successData
Example:
  request data = [
      {
        "keyForList": "waypoint_1727255981380",
        "address": "130 nguyen chi thanh",
        "name": "",
        "lat": 0,
        "lng": 0,
        "pendingAction": "add"
      },
      ...
  ];

  response data = [
    {
      "keyForList": "130 Đ. Nguyễn Chí Thanh_1727072486310",
      "address": "130 Đường Nguyễn Chí Thanh, Phường 3, District 10, Ho Chi Minh City, Vietnam",
      "name": "130 Đ. Nguyễn Chí Thanh",
      "lat": 10.7608132,
      "lng":<PHONE_NUMBER>,
      "pendingAction": "add"
    },
    ...
  ]

In that case, we need BE support to remove pendingAction from the response. If we don’t remove pendingAction, any subsequent failed request may result in the removal of valid waypoints.
  response data = [
    {
      "keyForList": "130 Đ. Nguyễn Chí Thanh_1727072486310",
      "address": "130 Đường Nguyễn Chí Thanh, Phường 3, District 10, Ho Chi Minh City, Vietnam",
      "name": "130 Đ. Nguyễn Chí Thanh",
      "lat": 10.7608132,
      "lng":<PHONE_NUMBER>,
-     "pendingAction": "add"
    },
    ...
  ]

If this pattern isn’t commonly supported by the backend, we can proceed with the previous solution, which is to only prevent saving an invalid waypoint. WDYT?

We’re still waiting on the internal team to decide the solution prevent adding an invalid waypoint to the list, or the solution manage the pendingAction on the client side based on the request status (in this case we need backend support base on this comment)

Ah ok, I'm looking at the original bug report again and I'm realizing that I misinterpreted it originally. Sorry! I now see that no request is sent to the backend at all in the original bug report.
I don't think the provided steps result in a real bug. We have "invalid" waypoints in the recent waypoints list after coming back online, but I don't think that's really an issue. It doesn't cause a problem directly. The problem only occurs later if a user tries to create an expense with those invalid waypoints. When that request fails they are not cleared from the recent waypoints list. I will update the description and testing video accordingly.
Maybe in a perfect world we would queue some kind of action that validates waypoints saved while offline, that aren't used in any request, when going back online; but I don't think that's worth it the effort of building such a mechanism. Instead we can make sure optimistic recent waypoints are cleaned up when the next request is made.
Oh wait, I see that when you go back online and try to use these waypoints they won't be allowed, so the request will have to be made while offline. We don't really have a problem with invalid waypoints from offline being used while online. They can still be used while offline, but they aren't necessarily "invalid" at that point, we don't know whether they are valid or not because we are offline. As soon as any distance expense in successfully created, the invalid waypoints will be removed from Onyx.
Here's video proof:
https://github.com/user-attachments/assets/c709e195-6d4c-4999-a4ce-448b6add7242
So I think the only problem that remains is cleaning up these waypoints when the request fails. The case you mentioned of saving invalid waypoints, then switching to use valid ones is not a problem. We only have a problem when creating requests with invalid waypoints. Furthermore, I don't think we'll need to set any pendingAction data afterall.
Bug:

Navigate to staging.new.expensify.com
Create a workspace
Go to workspace chat
Go offline
Go to submit distance expense
Enter an invalid waypoint and click save
Exit out of the expense creation flow
Start a distance expense flow
Click on start waypoint and see the suggestion list
Select the invalid waypoint
Add another waypoint and continue to submit the expense
Go online
Verify the request fails
Green plus, submit an expense, distance
Go to enter a waypoints
Verify the invalid waypoints is no longer in the recent waypoints list ❌

Pseudocode:
When creating the request onyxData {
    In the optimistic data {
        No changes needed, recent waypoints are already saved before this
    }
    In the success data {
        No changes are needed. The backend will return an Onyx.set update with the proper recent waypoints
    }
    Failure data {
        // The goal is to properly reset the recent waypoints
        Create an Onyx.set update with the recent waypoints currently stored in Onyx
    }
}

Please let me know what you all think of this approach 🙇

@neil-marcellini Based on the latest expected behavior, we can proceed with the updated alternative proposal from @wildan-m.

Ok sweet, I'm glad we've landed on a solution! I like @wildan-m's proposal too. I keep changing my mind, but I like the main solution with the pendingAction approach. Either way could work but that's slightly more clear, and I forgot in my last comment that we need a way to identify the current waypoints that have been saved by the server vs offline. Hiring 🚀

@neil-marcellini Thanks for the assignment, please confirm that we'll go with adding pendingAction? If so, we'll need backend modification as mentioned here https://github.com/Expensify/App/issues/48631#issuecomment-2367639225 and explained more here https://github.com/Expensify/App/issues/48631#issuecomment-2373623014

@neil-marcellini bump https://github.com/Expensify/App/issues/48631#issuecomment-2390374379

@suneox The PR is ready https://github.com/Expensify/App/pull/50323. Thanks!

Checklist

[x] [@suneox] The PR that introduced the bug has been identified. Link to the PR: N/A
[x] [@suneox] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. There isn’t an offending PR in this case, as this is a new requirement intended to cover an edge case.
[x] [@suneox] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
[x] [@suneox] Determine if we should create a regression test for this bug: N/A
[x] [@suneox] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again. N/A

Payment Summary:
Contributor: @wildan-m paid $250 via Upwork
Contributor+: @suneox paid $250 via Upwork


Thread safety for core singletons.

Summary of changes:

ConverterRegistry and DefaultStateRegistry made thread-safe.
CommandValidator.LogSingleton renamed to ... Singleton to reflect its nature.

@alexander-yevsyukov PTAL.

Current coverage is 80.65% (diff: 100%)

Merging #222 into master will not change coverage

@@             master       #222   diff @@
==========================================
  Files           147        147
  Lines          5494       5494
  Methods           0          0
  Messages          0          0
  Branches        610        610
==========================================
  Hits           4431       4431
  Misses          952        952
  Partials        111        111

Powered by Codecov. Last update 90ebfa7...aa71b5a


Review position of larval neuroblasts: add relationships [sf#19]

Reported by mmc46 on 2013-10-23 18:40 UTC
From Sian's email:
I'm currently buried in larval neuroblasts, and think there might be need of a parent term.  The paper I'm looking at refers to just "central brain neuroblasts", and I was looking in TermLink to see if I could find something a bit more specific than "neuroblast &&of embryonic/larval brain".  It appears there's a lot of them (reference is FBrf0194268, which states in its title that it concerns late larval neuroblasts), with names like "neuroblast BLP", and defined quite precisely.  However, the only parent term is "neuroblast", with which these terms have an is_a relationship  (neuroblast BLP doesn't have a part_of relationship to anything).  This looks like a useful collection of terms, if they had meaningful relationships to the larger anatomy.

Updated by mmc46 on 2013-11-08 17:08 UTC

status: open --> closed

Commented by mmc46 on 2013-11-08 17:08 UTC
These neuroblasts have been put under: protocerebral, deuterocerebral, tritocerebral or procephalic neuroblast (if it wasn't clear which class it belonged to).


License?

I prefer if you match https://github.com/anderslanglands/babble/blob/main/LICENSE.md but mit-license is fine too.

Thanks for the reminder. Will add it in the next commit.

Completed.


Don't show Cree words labels in spoken recordings, unless normatized

When implementing #128, the old itwêwina shows the search string that is used in order to access spoken recordings. This search string appears to be without vowel-length, which if shown to a user is a non-standard spelling of the word in question.
E.g. wapamew for wâpamêw
Thus, until/unless the search strings can be presented in an orthographically standardized form, do not show them in the new itwêwina. Rather, show just a microphone symbol and the name and community of the speaker. Something like (≪ Harley Simon, Maskwacîs.
Thus, itwêwina would not be generating or showing any non-standard Cree (in SRO), and someone in Regina will be happy.
Desired behavior: wâpamêw, or Ø
Undesired behavior: wapamew
Of course, for recordings of inflected forms that we present alongside the lemma (like ê-wâpamât) we would need to show the normatized spelling, so as not to confuse users.

tl;dr: either we show it RIGHT or we don't show it at all!
(suggested by Arok)

I think this is already achieved. Verify please @aarppe ?

I don't know if this is implemented in the new dictionary, as I don't see any recordings yet, e.g.
https://sapir.artsrn.ualberta.ca/cree-dictionary/search/wapamew/
In the old itwêwina, we certainly yet show the non-standard transcriptions of the recordings (based on how the search from the speech database is done), cf.
https://altlab.ualberta.ca/itwewina/detail/crk/eng/wâpamêw.html?no_compounds=true&lemma_match=true&e_node=7116418259216475478
But we don't want to replicate this behavior in the new itwêwina (until we figure out a more elaborate design), so in the new itwêwina we should only show speaker data and not at all the transcription of the speech snippet.

@aarppe sorry I didn't recognize this issue is talking about recordings


Update: HiPiler: Visual Exploration Of Large Genome Interaction Matrices With Interactive Small Multiples

Our paper is on bioRxiv since the submission deadline, including the revision:
DOI: 10.1101/123588
URL: http://www.biorxiv.org/content/early/2017/07/09/123588
Not sure what criteria is applied but I think bioRxiv is a reliable open access repository.
Also, all the data we used is publicly available too:
https://www.ncbi.nlm.nih.gov/geo/query/acc.cgi?acc=GSE63525
(GEO is one of the two major data repositories for genomic data)
The config for loading this demo (and more) is open-source too:
https://gist.github.com/flekschas/8b0163f25fd4ffb067aaba2a595da447
PS: Thanks for pulling this list together!

Hi Fritz. HiPiler was one of the first I found and has been on OAVIS and marked as on a reliable open access repository from the beginning :)
Any of the following URLs are counted as reliable repositories:  osf.io, arxiv.org, biorxiv.org, psyarxiv.org, hal.inria.fr, hal.archives-ouvertes.fr, eprints.whiterose.ac.uk  (I need to make this more clear in the docs)
For data, I use the center for open science definition, which is the results of an experiment in the paper. I have, however, linked to the source code as materials.

Cool thanks!


obs: Remove fedora 28 obs packages

Fedora 28 has come to end of life status which makes not possible to
retrieve the repositories while performing an update. This PR removes
this distro with this version so we not longer create and test obs packages
for fedora 28.
Fixes #879
Signed-off-by: Gabriela Cervantes<EMAIL_ADDRESS>

/test

/AzurePipelines run


How to train only a camera input with cam_front?

It's only change to the follow setting?
`'cams': [
'CAM_FRONT',
],
'Ncams':
1,`

This should work, but in my experimence, this may result in performance drop, since gt are not filtered based on the cameras you use.

This should work, but in my experimence, this may result in performance drop, since gt are not filtered based on the cameras you use.

Is the metric of  above picture normal only cam_front as network input?  What's the meaning  about  since gt are not filtered based on the cameras you use?


NoReverseMatch at /admin/useraudit/loginattempt/

When user is desactivate and there are a login attempt with this user:
NoReverseMatch at /admin/useraudit/loginattempt/
'useraudit' is not a registered namespace
I am using Django 2.2

When user is desactivate and there are a login attempt with this user:
NoReverseMatch at /admin/useraudit/loginattempt/
'useraudit' is not a registered namespace
I am using Django 2.2

hello ahusteam34 were you able to execute this on you app.
i am facing some problem on intergrating this with my app can you help

anyone fixed this??

Yes, It was necessary to add this in urls.py:
path(r'^ltw/',include('useraudit.urls',namespace="useraudit")),


inject multiple jmstemplate connections in Spring boot

Using, java 8
spring boot 2.5.0
spring jms 5.3.7
ibm mq <IP_ADDRESS>
using spring boot and application.yml file i have set ibm.mq.queueManager , ibm.mq.channel, ibm.mq.connName and using
@Autowired
JmsTemplate jmstemplate;
I am able to successfully connect to the MQ
but i have second Queuemanager, want to know how to instantiate jmstemplate2  with new set of values in application.yml which are named as ibm.mq2.queueManager , ibm.mq2.channel, ibm.mq2.connName
Is there a easier way to configure it,  like below
@Autowired
@Qualifier("ibm.mq")
JmsTemplate jmstemplate;
@Autowired
@Qualifier("ibm.mq2")
JmsTemplate jmstemplate2;
or do i have to follow this approach  https://stackoverflow.com/questions/49520412/spring-boot-multiple-jms-connections
can you pls guide me

See, for example, https://github.com/ibm-messaging/mq-jms-spring/issues/7 and an article linked from there at https://dev.to/adzubla/using-multiple-jms-servers-with-spring-boot-3cbm

MqconnectionFactoryFactory is not working.


BeginSignatureTransactionAsync didn't work

I tried multisig-transaction by BeginSignatureTransactionAsync but failed.
Expected result: sign to transaction and xem transaction success.
Actual result: WebException: The remote server returned an error: (404) Not Found.
My sample code is below (This is written for Unity).
        IEnumerator signCor()
        {
            PrivateKeyAccountClientFactory accountFactory = new PrivateKeyAccountClientFactory();
            PrivateKeyAccountClient accClient = accountFactory.FromPrivateKey(SignerWallet2PrivateKey);

            var sigData = new MultisigSignatureTransactionData
            {
                MultisigAddress = MultisigWalletAddress,
                TransactionHash = transactionHash
            };

            var result = accClient.BeginSignatureTransactionAsync(sigData);

            Debug.Log("waiting..");
            yield return new WaitWhile(() => !result.IsCompleted);

            var response = accClient.EndTransaction(result);
            Debug.Log(response.ToLog());
        }

Signature is succeeded on NanoWallet.

Please let me know if this is solved. thanks

I'm sorry for being late.
The code you sent to me showed same error.
And the data picked up with fiddler showed response below.
POST http://<IP_ADDRESS>:7890/transaction/announce HTTP/1.1
Accept: application/json
Content-Type: application/json
Content-Length: 442
Expect: 100-continue
Host: <IP_ADDRESS>:7890

{"data":"021000000100006824A9700520000000564CAD75EDD7D85CE54FDF7B097FDCA7521D7C24EA3E39937145C0B7E9D14D04F0490200000000003CB7700524000000200000003D242590BBAA0E78992EFBFDEBF915264C4084A1DAB58F44F155C0F7E40420072800000031636264626264656639303338653732303062363837636539376464626664646131323239356466","signature":"B3E5054B48025C1D4C04D330419896AB27801B10743D9EDA79C56FB9F31901E4D8C25FB314A067F717BE840FF5F75C938EF83D57B6282AEA486C6D05DFCD480D"}

HTTP/1.1 404 Not Found
Access-Control-Allow-Origin: *
Access-Control-Allow-Headers: Content-Type
Content-Type: application/json
Transfer-Encoding: chunked
Server: Jetty(9.2.11.v20150529)

9D
{"timeStamp":91269412,"error":"Not Found","message":"invalid address '1CBDBBDEF9038E7200B687CE97DDBFDDA12295DF' (org.nem.core.model.Address)","status":404}

0

excerpt: invalid address '1CBDBBDEF9038E7200B687CE97DDBFDDA12295DF'
this is what you need to investigate. how are you entering the address? how are you creating it? it should start with T for testnet or N for mainnet.

sorry, it is public key of multisig account.
but even change it to multisig address, the error appeared.
HTTP/1.1 404 Not Found
Access-Control-Allow-Origin: *
Access-Control-Allow-Headers: Content-Type
Content-Type: application/json
Server: Jetty(9.2.11.v20150529)
Content-Length: 157

{"timeStamp":91273471,"error":"Not Found","message":"invalid address 'TDMLK5YCLNVMWCKYAWKTPJARTPDBEMQ2RSQVG23F' (org.nem.core.model.Address)","status":404}

your sending a testnet transaction to main net.
http://<IP_ADDRESS>:7890/node/info
networkId: 104 - which is main net.
are you 1) setting connection to test net 2) passing the connection instance into PrivateKeyAccountClientFactory constructor?

passing the connection instance into PrivateKeyAccountClientFactory constructor?

this is the cause! I'm sorry to have inconvenienced you.

No problem at all. :) glad its resolved.


Upgrade deps

So, GitHub upgraded to Jekyll 3: https://github.com/blog/2100-github-pages-now-faster-and-simpler-with-jekyll-3-0
But we don't build properly with it. I've been getting emails but only now had the chance to look into it.
This doesn't yet work but it at least gets us back with what GitHub should be actually using. I couldn't figure out why it doesn't work, so I filed https://github.com/jekyll/jekyll/issues/4564. That should block this PR from landing.

Thanks for handling this Steve! I'll look into the redcarpet->kramdown switch soon

Cool! I think that it should Just Work, but haven't had the chance to deal with it yet.


Added support for an automatic cache buster suffix on the bg image

Folks who use a CDN can append their own cache buster to the .css file, but the background-image entry in the CSS file would still end up being loaded from the browser cache.
This change adds support for a --cachebuster=random parameter, which will append ?<hash> to the background-image: url(...), where <hash> is a randomly generated 40-character hexadecimal string. This would force the new, possibly updated sprite file to be downloaded freshly.

Coverage increased (+0.07%) to 96.99% when pulling 95842dfa09b662b4372ef15dbd353330670616e7 on michaelmoussa:cache-busting into 00f2db80e19fa881c35e2d8075f7a62be1f7570f on aslansky:master.

Thanks! :)


Change broker proxy prefix in walkthrough

Change broker proxy prefix in walkthrough
Prerequisites
This is merged: https://github.com/Peripli/service-broker-proxy/pull/67
Motivation
https://github.com/Peripli/service-broker-proxy/pull/67

Coverage remained the same at 89.828% when pulling 0ba07e59097940b906cacea61b7cad9adb7308a1 on proxy-prefix into 61322655efd2b7650028922eb32f11c8432d4a53 on master.


Added focusNode from SHACLValidator to Schemarama SHACL validator results

This adds a node entry to the results returned by the Schemarama SHACL validator (as is described in the readme)
This fixes #48

Hi Rinke! Thanks for this :)
We need to be careful around the opensource licensing in this repo, hence all the CLA messages above. Are you (or employer) in a position to sign a CLA? Happy to help...

Hi @danbri, I signed the CLA a while ago... perhaps good to get the paper work out of the way? ;-)


Dealing with "reverse" drift for DNS-IAC

Background

Proposed user journey

Approach

Questions / Assumptions

Acceptance Criteria

[ ] Enter text
[ ] Enter text
[ ] Enter text
[ ] Enter text

Reference
How to write good user stories

This is now in. Need to raise a story to finish a runbook.


React step 5

Closes #
{{short description}}
Changelog
New

{{new thing}}

Changed

{{change thing}}

Removed

{{removed thing}}

mybluemix url :http://carbon-tutorial-aakanshaagrawal.mybluemix.net/

No updates in 90 days. Closing.


Update TOC.md

fix project

Docs Build status updates of commit afadbc7:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

dynamics-gp/TOC.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


[Bug]: Address not visible on orders page

What happened?
When I try to order something and then check it from the "admin" panel the customers name, phone and email is shown but not their address, its fully empty.
What did you expect to happen?
To see the address where I need to deliver the order.
Version
3.x
What browser are you seeing the problem on?
Firefox, Chrome, Safari
Relevant log output
No response

okay so I figured out what I did wrong. The country list doesn't have Serbia in it so I had to add it and I forgot to fill the Format area, now it works.


WIP Adding timeout to ClientProtocol

Add a timeout to ClientProtocol using TimeoutMixIn:  http://twistedmatrix.com/documents/9.0.0/api/twisted.protocols.policies.TimeoutMixin.html  .
If a peer does not send anything within 30 seconds, close the connection and mark peer as down.  Also add a unit test for the timeout.

          1 Error

:no_entry_sign:
Please include a CHANGELOG entry.

          1 Message

:book:
See http://keepachangelog.com/en/0.3.0/ for details on good changelog guidelines

  Generated by :no_entry_sign: Danger

I didn't run or test any of this, but reading through it LGTM

changed names of test functions as suggested
rebased to a single commit on master

tests/unit/core/client was missing  init.py folder making test_ConnectionManager not run , added it


Select all (cmd-a) shortcut doesn't work on Save As dialog (the file name field)

VSCode Version: 1.15.0
OS Version: macOS Sierra

Steps to Reproduce:

Open VS Code
Create a new file somewhere
Hit cmd-s to save
Pick a different folder than the default one, just so that the "Save as" field gets deselected
Click the "Save as" field, and try to hit ctrl-a to select all the text

Reproduces without extensions: Yes

This issue has already been reported. Please use the search function next time before reporting an issue and/or this time if you are curious about the progress of the issue.


[EBPF] Generate complexity data in CI

What does this PR do?
Enables the generation of complexity data files in KMT CI. It also fixes some errors in the verifier log parser detected during testing of this PR.
Motivation
A future PR will leverage these files to report complexity changes in PRs.
Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

/trigger-ci --variable RUN_ALL_BUILDS=true --variable RUN_KITCHEN_TESTS=true --variable RUN_E2E_TESTS=on --variable RUN_UNIT_TESTS=on --variable RUN_KMT_TESTS=on

/merge


Add SessionId label to metrics and optimize metric instantiation

This change is

A top-level comment:

This needs to include the remote IA, as session has no meaning outside of that scope.

Review status: 0 of 7 files reviewed at latest revision, 1 unresolved discussion, some commit checks failed.

go/sig/ingress/dispatcher.go, line 101 at r1 (raw file):

				frame.sessId = mgmt.SessionType((frame.raw[0]))
				d.dispatch(frame, src)
				counters, ok := framesRecvCounters[frame.sessId]

This is illegal - you can't access frame after calling dispatch on it. Naughty.

Comments from Reviewable

Review status: 0 of 7 files reviewed at latest revision, 1 unresolved discussion.

go/sig/ingress/dispatcher.go, line 101 at r1 (raw file):
Previously, kormat (Stephen Shirley) wrote…
This is illegal - you can't access frame after calling dispatch on it. Naughty.

Good catch! Done.

Comments from Reviewable

Reviewed 7 of 7 files at r2.
Review status: all files reviewed at latest revision, 3 unresolved discussions.

go/sig/egress/dispatcher.go, line 21 at r2 (raw file):

	"os"

	"github.com/scionproto/scion/go/sig/mgmt"

This should be in the scion import block.

go/sig/egress/dispatcher.go, line 111 at r2 (raw file):

			if !ok {
				counters = metrics.CtrPair{
					Pkts:  metrics.PktsSent.WithLabelValues(ed.devName, sess.SessId.String()),

As the params for both metrics are the same, you could just make a NewCtrPair(intf, sessId string) *CtrPair constructor.

go/sig/ingress/dispatcher.go, line 48 at r2 (raw file):

	freeFrames         *ringbuf.Ring
	pktsSentCounters   map[mgmt.SessionType]metrics.CtrPair
	framesRecvCounters map[mgmt.SessionType]metrics.CtrPair

This doesn't look right. A session Id is only valid when scoped to a specific AS, but these counters look to be global.

Comments from Reviewable

Review status: 0 of 7 files reviewed at latest revision, 3 unresolved discussions, some commit checks failed.

go/sig/egress/dispatcher.go, line 21 at r2 (raw file):
Previously, kormat (Stephen Shirley) wrote…
This should be in the scion import block.

Done.

go/sig/egress/dispatcher.go, line 111 at r2 (raw file):
Previously, kormat (Stephen Shirley) wrote…
As the params for both metrics are the same, you could just make a NewCtrPair(intf, sessId string) *CtrPair constructor.

The metric names themselves are also different each time so NewCtrPair either would need to take two additional params or it would need to be redefined in each package. Both I think is worse than the current thing.

go/sig/ingress/dispatcher.go, line 48 at r2 (raw file):
Previously, kormat (Stephen Shirley) wrote…
This doesn't look right. A session Id is only valid when scoped to a specific AS, but these counters look to be global.

All metrics (frames(sent/recv) and packets(sent/recv)) now take the remote IA and the session Id as labels. The packet metrics currently contained the tun device on which they were sent/received which implicitly contains the same information as remote IA for the pktsRecv metrics. For the pktsSent metrics this label was always scion-local, however, I think what we really want to have is the remoteIA that sent the frame(s) from which a packet got reassembled.

Comments from Reviewable

Reviewed 7 of 7 files at r3.
Review status: all files reviewed at latest revision, 3 unresolved discussions, some commit checks failed.

go/sig/egress/dispatcher.go, line 111 at r2 (raw file):
Previously, shitz wrote…
The metric names themselves are also different each time so NewCtrPair either would need to take two additional params or it would need to be redefined in each package. Both I think is worse than the current thing.

Ok. How about just moving this block into a seperate method getCounters? Or, even better, updateMetrics, and pass in sessId and length. Same for the ingress dispatcher.

go/sig/egress/dispatcher.go, line 42 at r3 (raw file):

)

type metricKey struct {

Defining this type twice seems.. odd :) How about just moving it into sig/metrics?

go/sig/egress/dispatcher.go, line 113 at r3 (raw file):

			}
			sess.ring.Write(ringbuf.EntryList{buf}, true)
			key := metricKey{sess.IA.IAInt(), sess.SessId}

As sess.IA.IAInt() will be a constant for a given egressDispatcher, this could be calculated at the top, and re-used.

Comments from Reviewable

Review status: 4 of 7 files reviewed at latest revision, 2 unresolved discussions.

go/sig/egress/dispatcher.go, line 42 at r3 (raw file):
Previously, kormat (Stephen Shirley) wrote…
Defining this type twice seems.. odd :) How about just moving it into sig/metrics?

Done.

go/sig/egress/dispatcher.go, line 113 at r3 (raw file):
Previously, kormat (Stephen Shirley) wrote…
As sess.IA.IAInt() will be a constant for a given egressDispatcher, this could be calculated at the top, and re-used.

Done.

Comments from Reviewable

Reviewed 3 of 3 files at r4.
Review status: all files reviewed at latest revision, 1 unresolved discussion.

go/sig/ingress/dispatcher.go, line 98 at r4 (raw file):

				frame.frameLen = read
				frame.sessId = mgmt.SessionType((frame.raw[0]))
				key := metrics.CtrPairKey{RemoteIA: src.IA.IAInt(), SessId: frame.sessId}

This is a large block of code just to handle metrics, it ~doubles the size of this method. I suggest moving it out to a dedicated method, and call it with IAInt, SessId, and read.
The same applies to egressDispatcher.Run

Comments from Reviewable

Review status: all files reviewed at latest revision, 1 unresolved discussion.

go/sig/ingress/dispatcher.go, line 98 at r4 (raw file):
Previously, kormat (Stephen Shirley) wrote…
This is a large block of code just to handle metrics, it ~doubles the size of this method. I suggest moving it out to a dedicated method, and call it with IAInt, SessId, and read.
The same applies to egressDispatcher.Run

Done.

Comments from Reviewable

Reviewed 2 of 2 files at r5.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable


doc deplumber

deplumber sounds useful, but I haven't read all the source. let's add some notes to USAGE.md

Have you re-read the PLUMBING.md file since the deplumber command was added? If so, what's missing/confusing from it?
It's basically a hack to enable the p9p plumber to be used with de.

:man_facepalming:


Publish 0.9.X release with DroppingRavenLoggingFilter fix

Any chance we could release a 0.9.X (0.9.3 would be next) release that includes this fix? https://github.com/tradier/dropwizard-raven/commit/eb2285ddcdb5d78e5fce3be5e539a875ea3d809c
It is a pretty nasty bug to APPROVE everything because it makes it impossible to wrap the appender with additional functionality (filters) without hacks.
Upgrading to Dropwizard 1.0+ is not an option for me at the moment, unfortunately.

Hi @loganlinn I can look at getting a release out. You may not be using maven, but if you are, have you tried excluding the Dropwizard dependency?
<dependency>
    <groupId>com.tradier</groupId>
    <artifactId>dropwizard-raven</artifactId>
    <version>1.0.0-1</version>
    <exclusions>
        <exclusion>
            <groupId>io.dropwizard</groupId>
            <artifactId>dropwizard-core</artifactId>
        </exclusion>
    </exclusions>
</dependency>

Looking into a release would be much appreciated!
I have indeed tried and it unfortunately isn't an option. Dropwizard made
API changes to AppenderFactory in their 1.X that this library implements.
When this library upgraded to DW 1.X, it is in turn no longer compatible
with projects running DW 0.9.X or older.
On Wed, May 3, 2017 at 6:57 AM Steve Agalloco<EMAIL_ADDRESS>wrote:

Hi @loganlinn https://github.com/loganlinn I can look at getting a
release out. You may not be using maven, but if you are, have you tried
excluding the Dropwizard dependency?

com.tradier
dropwizard-raven
1.0.0-1

io.dropwizard
dropwizard-core

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/tradier/dropwizard-raven/issues/16#issuecomment-298918654,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAMsdAUtqo5kWL-ie7MrugFtlFtIRlrRks5r2IfZgaJpZM4NPDW1
.

@loganlinn gotcha, I couldn't remember what changes took place when.

I just backported the change to the 0.9.x release branch and shipped version 0.9.3. It should land in the central repository shortly. 😄

@loganlinn did 0.9.3 fix things for you?

presumably this is fixed, @loganlinn feel free to re-open if not.


fatal: [localhost]: FAILED! => {"failed": true, "msg": "'drupalvm_user' is undefined"}

fatal: [localhost]: FAILED! => {"failed": true, "msg": "'drupalvm_user' is undefined"}
I am guessing I need to define drupalvm_user, but where do I do this?
I am running Windows 7

@wah22 - This should be set automatically during provisioning if you're using a recent version/master of Drupal VM: https://github.com/geerlingguy/drupal-vm/blob/ef50cba994e43f40ad4bfe76ee69ab1b73d02f57/provisioning/vars/main.yml#L8

That seemed to do it.

I was on 2.3.1. Switching to master appears to have fixed it. Thank you!

I think I need to make a new tag :)

Hi all,
I am still having this issue after downloading the latest from Git and provisioning it again (and again and again and etc...). I think it might be because I am using CentOS box, as I did not have a user issue with the Ubuntu box.
Here is the error message:

fatal: [drupalvm]: FAILED! => {"failed": true, "msg": "the field 'become_user' has an invalid value, which appears to include a variable that is undefined. The error was: {{ drupalvm_user }}: {{ ansible_ssh_user | default(ansible_env.SUDO_USER, true) | default(ansible_env.USER, true) | default(ansible_user_id) }}: 'ansible_ssh_user' is undefined"}

I am running vagrant on a Mac.

@mdyoung3 which version of ansible are you running?

Centos6? https://github.com/geerlingguy/drupal-vm/issues/838#issuecomment-236475772

Correct. CentOS 6. Also, it appears to be running Ansible <IP_ADDRESS>.
But I have even less luck getting CentOS 7 to work.

Wonder why that happens. Does it work if you set
drupalvm_user: vagrant

in your config.yml?

Unfortunately, that seems to create other problems. It seems like, though, CentOS is not very well supported within Drupal VM--and will not be maintained in the future. Not sure if it's worth pursuing.

@geerlingguy has mentioned intentions of dropping centos6 support a few times already yes.
What errors are you getting? As it still is supported (but not out of the box) we would definitely help debug and improve http://docs.drupalvm.com/en/latest/configurations/base-os/#redhat-enterprise-linux-centos-6

CentOS is not very well supported within Drupal VM

CentOS 6 is not as well-supported—mostly because one-by-one, almost every single package that's used in the core install has become way outdated, and even 3rd party yum repos are dropping support left and right. EOL for full support is already nearing, and the OS is quite old at this point...
CentOS 7, on the other-hand, is well-supported, and I have most of my own servers running on that OS, so support for CentOS 7 is much better :)

Thanks for the update, @geerlingguy. I will focus on getting CentOS 7 operational for our organization.

I'm encountering this error as well. I can get everything up and running when using the default yml. But when I change the following lines per instructions here: http://docs.drupalvm.com/en/latest/deployment/local-codebase/#disable-the-composer-project-build-and-site-install

drupal_build_makefile: false
drupal_build_composer: false
drupal_build_composer_project: false
drupal_install_site: false

I would get the following error:
TASK [geerlingguy.composer : Install configured globally-required fatal: [drupalvm]: FAILED! => {"failed": true, "msg": "the field s undefined. The error was: {{ drupalvm_user }}: {{ ansible_ssh_u  default(ansible_user_id) }}: 'ansible_ssh_user' is undefined"}

@bbdata - What version of Drupal VM are you using, and what OS are you running (host and in VM).

@geerlingguy I was using 4.4.1 that I downloaded straight from drupalvm.com. I'm running Windows 10, using VritualBox 5.1.18 and ubuntu1604

@bbdata - Can you open a new issue for this? I wonder if it could be related to something else.