clangd 18 regression: An include path missing (excluded) from query driver

clangd 17 extracts the following include paths:
$ clangd --log=verbose --query-driver="/nix/store/*/bin/arm-none-eabi-*" --check=main.c 2>&1 | head -n27
I[22:37:53.007] clangd version 17.0.6
I[22:37:53.007] Features: linux
I[22:37:53.007] PID: 2376768
I[22:37:53.007] Working directory: /home/lu/dev/refloat/src
I[22:37:53.007] argv[0]: /nix/store/s834q3rdkn7zrfp9rh3b6cm8nb4mhs21-clang-tools-17.0.6/bin/clangd
I[22:37:53.007] argv[1]: --log=verbose
I[22:37:53.007] argv[2]: --query-driver=/nix/store/*/bin/arm-none-eabi-*
I[22:37:53.007] argv[3]: --check=main.c
V[22:37:53.007] User config file is /home/lu/.config/clangd/config.yaml
I[22:37:53.007] Entering check mode (no LSP server)
I[22:37:53.007] Testing on source file /home/lu/dev/refloat/src/main.c
V[22:37:53.007] config note at /home/lu/dev/.clangd:1:0: Parsing config fragment
V[22:37:53.007] config note at /home/lu/dev/.clangd:1:0: Parsed 1 fragments from file
V[22:37:53.007] Config fragment: compiling /home/lu/dev/.clangd:1 -> 0x00000000347DB980 (trusted=false)
V[22:37:53.007] config note at /home/lu/dev/refloat/.clangd:1:0: Parsing config fragment
V[22:37:53.007] config note at /home/lu/dev/refloat/.clangd:1:0: Parsed 1 fragments from file
V[22:37:53.007] Config fragment: compiling /home/lu/dev/refloat/.clangd:1 -> 0x00000000347DABB0 (trusted=false)
I[22:37:53.007] Loading compilation database...
I[22:37:53.008] Loaded compilation database from /home/lu/dev/refloat/compile_commands.json
V[22:37:53.008] Broadcasting compilation database from /home/lu/dev/refloat
V[22:37:53.016] System include extraction: target extracted: "arm-none-eabi"
V[22:37:53.016] System include extraction: adding  /nix/store/9z0l7wpqx3fqybmyp9gjvihw756dg5fi-gcc-arm-embedded-13.2.rel1/bin/../lib/gcc/arm-none-eabi/13.2.1/include
V[22:37:53.016] System include extraction: adding  /nix/store/9z0l7wpqx3fqybmyp9gjvihw756dg5fi-gcc-arm-embedded-13.2.rel1/bin/../lib/gcc/arm-none-eabi/13.2.1/include-fixed
V[22:37:53.016] System include extraction: adding  /nix/store/9z0l7wpqx3fqybmyp9gjvihw756dg5fi-gcc-arm-embedded-13.2.rel1/bin/../lib/gcc/arm-none-eabi/13.2.1/../../../../arm-none-eabi/include
I[22:37:53.016] System includes extractor: successfully executed /nix/store/9z0l7wpqx3fqybmyp9gjvihw756dg5fi-gcc-arm-embedded-13.2.rel1/bin/arm-none-eabi-gcc
        got includes: "/nix/store/9z0l7wpqx3fqybmyp9gjvihw756dg5fi-gcc-arm-embedded-13.2.rel1/bin/../lib/gcc/arm-none-eabi/13.2.1/include, /nix/store/9z0l7wpqx3fqybmyp9gjvihw756dg5fi-gcc-arm-embedded-13.2.rel1/bin/../lib/gcc/arm-none-eabi/13.2.1/include-fixed, /nix/store/9z0l7wpqx3fqybmyp9gjvihw756dg5fi-gcc-arm-embedded-13.2.rel1/bin/../lib/gcc/arm-none-eabi/13.2.1/../../../../arm-none-eabi/include"
        got target: "arm-none-eabi"

clangd 18 output:
$ clangd --log=verbose --query-driver="/nix/store/*/bin/arm-none-eabi-*" --check=main.c 2>&1 | head -n29
I[22:37:00.933] clangd version 18.1.8
I[22:37:00.933] Features: linux
I[22:37:00.933] PID: 2370322
I[22:37:00.934] Working directory: /home/lu/dev/refloat/src
I[22:37:00.934] argv[0]: /nix/store/58rcyvc7j0b6cgbkdzd1p67qfhlbzrfc-clang-tools-18.1.8/bin/clangd
I[22:37:00.934] argv[1]: --log=verbose
I[22:37:00.934] argv[2]: --query-driver=/nix/store/*/bin/arm-none-eabi-*
I[22:37:00.934] argv[3]: --check=main.c
V[22:37:00.934] User config file is /home/lu/.config/clangd/config.yaml
I[22:37:00.934] Entering check mode (no LSP server)
I[22:37:00.934] Testing on source file /home/lu/dev/refloat/src/main.c
V[22:37:00.934] config note at /home/lu/dev/.clangd:1:0: Parsing config fragment
V[22:37:00.934] config note at /home/lu/dev/.clangd:1:0: Parsed 1 fragments from file
V[22:37:00.934] Config fragment: compiling /home/lu/dev/.clangd:1 -> 0x000000000DE68B80 (trusted=false)
V[22:37:00.934] config note at /home/lu/dev/refloat/.clangd:1:0: Parsing config fragment
V[22:37:00.934] config note at /home/lu/dev/refloat/.clangd:1:0: Parsed 1 fragments from file
V[22:37:00.934] Config fragment: compiling /home/lu/dev/refloat/.clangd:1 -> 0x000000000DE67DB0 (trusted=false)
V[22:37:00.934] Config fragment: compiling <unknown>:0 -> 0x000000000DE67E50 (trusted=false)
I[22:37:00.934] Loading compilation database...
I[22:37:00.935] Loaded compilation database from /home/lu/dev/refloat/compile_commands.json
V[22:37:00.935] Broadcasting compilation database from /home/lu/dev/refloat
V[22:37:00.943] System include extraction: target extracted: "arm-none-eabi"
V[22:37:00.943] System include extraction: adding  /nix/store/9z0l7wpqx3fqybmyp9gjvihw756dg5fi-gcc-arm-embedded-13.2.rel1/bin/../lib/gcc/arm-none-eabi/13.2.1/include
V[22:37:00.943] System include extraction: adding  /nix/store/9z0l7wpqx3fqybmyp9gjvihw756dg5fi-gcc-arm-embedded-13.2.rel1/bin/../lib/gcc/arm-none-eabi/13.2.1/include-fixed
V[22:37:00.943] System include extraction: adding  /nix/store/9z0l7wpqx3fqybmyp9gjvihw756dg5fi-gcc-arm-embedded-13.2.rel1/bin/../lib/gcc/arm-none-eabi/13.2.1/../../../../arm-none-eabi/include
V[22:37:00.945] System includes extractor: builtin headers /nix/store/9z0l7wpqx3fqybmyp9gjvihw756dg5fi-gcc-arm-embedded-13.2.rel1/bin/../lib/gcc/arm-none-eabi/13.2.1/include excluded
I[22:37:00.945] System includes extractor: successfully executed /nix/store/9z0l7wpqx3fqybmyp9gjvihw756dg5fi-gcc-arm-embedded-13.2.rel1/bin/arm-none-eabi-gcc
        got includes: "/nix/store/9z0l7wpqx3fqybmyp9gjvihw756dg5fi-gcc-arm-embedded-13.2.rel1/bin/../lib/gcc/arm-none-eabi/13.2.1/include-fixed, /nix/store/9z0l7wpqx3fqybmyp9gjvihw756dg5fi-gcc-arm-embedded-13.2.rel1/bin/../lib/gcc/arm-none-eabi/13.2.1/../../../../arm-none-eabi/include"
        got target: "arm-none-eabi"

Note the include path /nix/store/9z0l7wpqx3fqybmyp9gjvihw756dg5fi-gcc-arm-embedded-13.2.rel1/bin/../lib/gcc/arm-none-eabi/13.2.1/include is stated as excluded by clangd 18. But I am missing the include path, I get errors when it's excluded (stdbool.h in particular is missing).
Operating system: NixOS

The change in clangd 18 to exclude the queried compiler's builtin headers is deliberate; see https://github.com/clangd/clangd/issues/1695 for for details.
Clangd should be finding as using its own builtin headers instead.

But I am missing the include path, I get errors when it's excluded (stdbool.h in particular is missing).

If you show more of the log we might be able to see what's going wrong.

Thank you, I went through the linked issue but didn't read too deep into it, as it goes into details I don't understand.
As I said, the stdbool.h header is missing. Full log attached:
clangd-verbose.log

From the log, the place where clangd expects to find its own builtin headers such as stdbool.h is /nix/store/maa8li4ybxv6hb2k23n4akqdk609fh1r-clang-18.1.8/lib/clang/18/include. Does this directory exist, and does it contain stdbool.h and other headers?

The directory doesn't exist :smiling_face_with_tear:
$ ls /nix/store/maa8li4ybxv6hb2k23n4akqdk609fh1r-clang-18.1.8/
bin  share

I guess that's another NixOS bug? I'm thinking how to formulate it, any details about the (I assume it may be new) directory you can think of that I should include?

Basically, when clangd is installed to a particular directory <prefix>, it expects certain subdirectories and files to be present in <prefix>. In addition to the executable itself in <prefix>/bin/clangd, this includes the built-in headers in <prefix>/lib/clang/<version>/include.
This is usually a detail that consumers of clangd don't need to worry about it, because the build system should ensure it (e.g. ninja install should copy the files there). Maybe NixOS is doing some custom packaging steps after or instead of the project's own build system?

Maybe NixOS is doing some custom packaging steps after or instead of the project's own build system?

It's not immediately obvious (but I'm pretty sure the installed files are filtered and have other things done to them), here's the main build file, but I guess it's inherited from somewhere...
https://github.com/NixOS/nixpkgs/blob/master/pkgs/development/compilers/llvm/common/clang-tools/default.nix
Anyway, closing, thanks for your help, very much appreciated!


Mark cancel_ares_query_test as flaky

CC @apolcyn

Should there be a bug open to fix this flakiness internally? (there might be and I'm just not aware of it though).

Should there be a bug open to fix this flakiness internally? (there might be and I'm just not aware of it though).

it's in a comment:
b/157516105


are partial / relative AXPaths still an option?

Current documentation points out the Absolute AXPath performance enhancement, but as I am new to this project, I'm wondering if there is still a partial path option available in some form.
The application I am working with (and perhaps many do) changes it's group ordinals based on behavior in the application so that an object found under AXGroup[7] could sometimes be under AXGroup[8], AXGroup[11], etc. Test execution failures ensue as I'm sure you are familiar.
Could someone please advise or point out any appropriate documentation?
I am currently using a java selenium framework with the RemoteWebDriver pointed to http://localhost:4622/wd/hub.
Regards,

@btdaniel2 See this line : https://github.com/appium/appium-for-mac/blob/master/AppiumForMac/Server/Controller/AfMElementLocator.m#L103
BOOL const requireAbsoluteAXPath = NO;

should have done the trick. But even I could not get it working after that.


Update data-factory-azure-ml-batch-execution-activity.md

Typo

Hi @moxpower, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no contribution license agreement is required at this point. Real humans will now evaluate your PR.

TTYL, AZPRBOT;

@moxpower - Thanks for fixing the error. Appreciate it.
@cjgronlund, @tysonn - please merge when you get a chance. Thanks.


The configuration metadata default value for management.endpoint.env.post.enabled should be false instead of true

Fixes #738

This should be made on the 2.2.x branch

Ok no problem I'll create a new pull request.


iTwin Viewer Measurement Units

I've been looking at changing the units that the iTwins Viewer displays in, as currently measurements are showing up in Imperial. Looking through the documentation, this seems to be the default, and if you want to display in Metric, then you have to change the setting.
It's this that I have been trying to do, but I'm clearly approaching it incorrectly, as it's having no effect...
I am trying to use the setUnitFormattingSettingsProvider() method with a LocalUnitFormatProvider instance, which from what I understand in the documentation allows switching to Metric if you pass the constructor a true Boolean, so basically like this:
IModelApp.quantityFormatter.setUnitFormattingSettingsProvider(new LocalUnitFormatProvider(new QuantityFormatter(true)));
Am I on the right track here, can anyone point me at an example, any advice would be really useful!

It's this that I have been trying to do, but I'm clearly approaching it incorrectly, as it's having no effect..

Show the code that's having no effect.
I would have started with:
IModelApp.quantityFormatter.setActiveUnitSystem("metric", true);
but it appears that by default when you switch to a different iModel it will reset the settings (not sure if that matters in your case).


Add support for xsd element ref

This PR adds the ability to handle XSD element ref.

Amazing!

@vpulim Can you review/merge the PR?

cc @piscisaureus @dbrijesh

@herom Can you review/merge the PR? We really want to have the problem fixed without a fork.

@raymondfeng  review our code, the checks needs to be correct.. if you have fails they will not merge the branch.

@raymondfeng I believe this can be merged once the checks pass.

The tests are passing on all platforms except iojs.

@raymondfeng try updating the PR with the latest from master (git pull --rebase upstream master).  I just moved the .travis.yml file over to using docker.  That update should trigger a Travis build, although it's been slow today.

Thanks for adding tetss @raymondfeng!  And this is amazing!

v0.9.2 has been published with this change.


Merging pr 1354 Into Main

@wind57 thanks, that got me past that error
But now I am running into this error
Caused by: java.io.FileNotFoundException: class path resource [org/springframework/boot/BootstrapRegistryInitializer=/.class] cannot be opened because it does not exist.
It is coming from a new test in the PR, but I do not see this locally and I have no idea how it is possible this class file does not exist.  IDK if its something to do with splitting the tests but it appears to be something specific in github actions.

I am starting to think this has to do with us branching main...investigation continues tomorrow


[Color Casket] Unable to install

Extension – Color Casket
Author: @slavarazum
My first recently published extension unable to install from Store.

Error Message:
Failed to install extension.
Reason: Failed to decode response data
Domain: network
Time: 05:07:28.692
Service: Internal networking engine
Underlying:
	Domain: RaycastData.StoreAPIResponse.Error 1

Extension details failed to load either...

Command logo is not displayed on extension page:

Steps To Reproduce

Try to install extension from Strore
Open details

Raycast version
Version: 1.33.2

Fixed!


MT4 doesn't install.

MT4 seems to doesn't install anymore (see build 104776373).
The same for the build which was previously working, see: 103991713.

Probably some key sequences have changed in the latest installer, will check it today.

Fixed in a569b2d9a5425c91d3f8c9f937e335d123d303d9


Investigate Diagnostic collection.

Currently we have a number of issues regarding Diagnostic collection. In general most issues are generated by the fact we have two sources of diagnostics (sourcekit-lsp and the compiler). This issue is to discuss methods of collating these into one list.
Paths to investigate.

Creating our own DiagnosticGroup vscode.languages.createDiagnosticCollection("test")
Using LanguageClient middleware to capture diagnostic coming from sourcekit-lsp
reading the diagnostic file emitted by -serialize-diagnostics-path #670

happy to tackle this one too

So https://github.com/swift-server/vscode-swift/issues/694 and https://github.com/swift-server/vscode-swift/issues/750 need to be considered at the same time, as they both have a common need. For right now I would say we don't want to do anything about https://github.com/swift-server/vscode-swift/issues/670 as it would involve adding in logic similar to TSCBasic for reading the bitstream format. So for showing progress and improving diagnostics, we need access to the output from the swift process. We cannot get this using a ProcessExecution or a ShellExecution for the resolved tasks. So we need to create our own CustomExecution. Since the "swift" tasks just take an arbitrary array of "args", we'll need the resulting terminal to be interactive, for example  if they "run" some executable with a CLI. VSCode already has a native bundled node-pty module we can load. It is even in the remote extension host asar bundle so would work for remote workflows. I've got a POC working for Windows, macOS, and linux. The biggest risk is making sure the Pty environment behaves the same as the current ProcessExecution, but can take a look through terminalProcess.ts for some help.
With access to the swift output, we can control the diagnostic output -fdiagnostics-format=clang/msvc/vi and parse with a similar regex as the $swiftc problem matcher. There is no way to control the format of the build output, ex. [44/57] Building SomeFile.swift but this hasn't changed. Before I get into how I envision merging parsed diagnostics with sourcekit-lsp diagnostics, what are your initial thoughts @adam-fowler?

Not sure what interaction we will need. This should only be for running the swift executable and its children.

For example if running executable tries to read from stdin, ex. readLine()

You should verify that environment variables aren't changing between running tasks

The environment would be set for each PTY process spawned, not the shared pseudo terminal, but absolutely will double check this.
Thanks so much for the feedback @adam-fowler 😃

And @adam-fowler I was going to just focus on parsing diagnostics from output for now and potentially looking at reading the serialized diagnostics down the road (https://github.com/swift-server/vscode-swift/issues/670). To synchronize the parsed diagnostics and the sourcekit-lsp diagnostics to prevent duplicates, and remove stale diagnostics, my proposal is:

Listen for new tasks starting (vscode.tasks.onDidStartTask) and for tasks with our custom SwiftExecution, listen to the output written from the pty process

Use a regex (from package.json) to parse diagnostics and add them to our swift diagnostics collection

Add middleware hooks for provideDiagnostics and handleDiagnostics so the language client doesn't publish these to its own diagnostic collection. The middleware will pass the diagnostics on for us to handle.

The whole idea is to make sure we only have one diagnostic, not duplicates. Although they'd be in the same collection, the diagnostic's source could differ and would be either swiftc or sourcekitd. As user types, we can remove old swiftc diagnostics if sourcekitd is no longer reporting them

When we have a new list of diagnostics from parsing or LSP, we will match on message, and range. i.e. only one copy of diagnostics for a given range, with the same string message

Precedence will always be give to the sourcekitd because they give the full range (parsing only gets us start line/column) and they have quick fixes

@award999 Can we add a PR with just the custom SwiftExecution with some hooks such that we can add parsing of diagnostics later on. And have the swift tasks use this custom execution. This should be a fairly contained change.

@adam-fowler is it cool to close these off as the investigation has been done, with other PRs or issues created

Just copied and pasted my message from other issue. In this case it is we have the other issues raised. I'll throw up a PR later this morning


[Refactor] remove variable pipeline_query_statistic

Fixes #issue
This variable is used to keep version compatibility when upgrading from 2.3 to 2.4, and it's stale since version 3.0
What type of PR is this:

[ ] BugFix
[ ] Feature
[ ] Enhancement
[x] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Checklist:

[ ] I have added test cases for my bug fix or my new feature
[ ] This pr will affect users' behaviors
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

[ ] I have checked the version labels which the pr will be auto-backported to the target branch

[ ] 3.1
[ ] 3.0
[ ] 2.5
[ ] 2.4

[FE PR Coverage Check]
:disappointed: fail : 0 / 1 (00.00%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/qe/SessionVariable.java
0
1
00.00%
[2268]


Quick accent doesn't work in Visual Studio 2022

Microsoft PowerToys version
0.69.0
Installation method
GitHub
Running as admin
None
Area(s) with issue?
Quick Accent
Steps to reproduce
Open Visual Studio 20220
Open any code edit window.
Type any letter and, while holding the key, press (i.e.) the right arrow key to show Quick accent window.
✔ Expected Behavior
I'm expecting Quick accent window appear
❌ Actual Behavior
Quick accent window does not appear and it is impossible to choose a special char
Other Software
Visual Studio 2022

I can't reproduce this. Works fine on my end. This happens only with VS? What about VS Code? Can you also attach /bugreport? Thanks

Yes! It happens only in VS. I can't check with VSCode because it's not
installed on my PC.
VS has no additional extensions installed.
What do you mean with " Can you also attach /bugreport"? How can I do it?
You can find my Quick accent settings attached to this email. (Sorry...
It's the italian translation)
Hope this helps.
Sebastiano
Il giorno ven 7 apr 2023 alle ore 11:19 Stefan Markovic <
@.***> ha scritto:

I can't reproduce this. Works fine on my end. This happens only with VS?
What about VS Code? Can you also attach /bugreport? Thanks
—
Reply to this email directly, view it on GitHub
https://github.com/microsoft/PowerToys/issues/25271#issuecomment-1500108496,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AFU2T5OSGB3EIJOG3XDDCKTW77L2NANCNFSM6AAAAAAWWKXEIE
.
You are receiving this because you authored the thread.Message ID:
@.***>

I've tested it in my home Visual Studio installation and everything seem to work fine!
Maybe there's something in my work PC that "break" PowerToys?
Anyway, I'll send you a bug report ASAP.
Sebastiano

I don't know if you're still interested... But I found the solution: it seems that Microsoft Power Automate prevents QuickAccent to work in Visual Studio. I've just unistalled it and now everything works fine!
PS I had the same issue in Visual Studio 2019.


SymbolTable: Gracefully handle current CHECK-fail

This situation seems to arise if we have possibly multiple parent references when fed a bunch of possibly unrelated files with naming overlap. Don't crash in this case.

Codecov Report
Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (470e0b9) 92.85% compared to head (3681b01) 92.84%.
Report is 6 commits behind head on master.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2029      +/-   ##
==========================================
- Coverage   92.85%   92.84%   -0.01%
==========================================
  Files         357      357
  Lines       26399    26396       -3
==========================================
- Hits        24512    24507       -5
- Misses       1887     1889       +2

Files
Coverage Δ

common/text/concrete_syntax_tree.cc
100.00% <100.00%> (ø)

common/text/concrete_syntax_tree.h
96.82% <100.00%> (+0.46%)
:arrow_up:

common/text/tree_builder_test_util.cc
100.00% <100.00%> (ø)

common/text/tree_utils.cc
97.27% <100.00%> (-0.02%)
:arrow_down:

common/text/tree_utils.h
100.00% <100.00%> (ø)

verilog/CST/expression.cc
96.10% <100.00%> (-0.10%)
:arrow_down:

verilog/CST/macro.cc
100.00% <100.00%> (ø)

verilog/CST/module.cc
100.00% <100.00%> (ø)

verilog/CST/port.cc
94.36% <100.00%> (ø)

verilog/CST/seq_block.cc
100.00% <100.00%> (ø)

... and 15 more

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Do some proper work in the STATIC planner variant

The selection of STATIC planner is enabled but there is almost no logic connected to it. Implement and test it...

Fix the basics (just get a proper end-time from exact time instead of offset from now) [DONE in #55 ]
How to keep track of "used" hours for every cycle (need some persistent memory so that it don't reset if HA is restarted). Could it be stored in config-entry?
Enable option to split the hours over the entire day (the cheapest hours don't have to be consecutive). In reality the duration becomes "find the X cheapest hours" and the duration in logic is set to 1
Set a start-hour (specially for a car charger the vehicle is likely not connected during the day when used and then the integration should not be enabled)

How is the progress of the work with "STATIC planner"? Do you want to implement control by power levels (kWh average over an hour), and add prioritized loads/units in the future?
Can you look into the possibility of a sensor that sets the water temperature in the hot water tank, depending on the electricity price?

Hi, progress is slow on this particular part of the planner (most likely because I don't have an immediate use of it myself), but should maybe start a poll or something to see how large the interest of it is.
About your proposals above, improvements and suggestions are always welcomed. Could you explain a bit more what you're after. Maybe as one or two separate tickets. (this particular ticket only aims to finalize the core functionality of the static planner)

Hi, and thanks for your reply.
See my new "issue" I have started. Answering your questions there.

How is the progress of the work with "STATIC planner"? Do you want to implement control by power levels (kWh average over an hour), and add prioritized loads/units in the future?
Can you look into the possibility of a sensor that sets the water temperature in the hot water tank, depending on the electricity price?

Hi, progress is slow on this particular part of the planner (most likely because I don't have an immediate use of it myself), but should maybe start a poll or something to see how large the interest of it is.
About your proposals above, improvements and suggestions are always welcomed. Could you explain a bit more what you're after. Maybe as one or two separate tickets. (this particular ticket only aims to finalize the core functionality of the static planner)

Hi, and thanks for your reply.
See my new "issue" I have started. Answering your questions there.


Bug: MutableRefObject in EditorRefPlugin can be null or undefined

When initialising ref with const editorRef = useRef<LexicalEditor>(null); or const editorRef = useRef<LexicalEditor>();  to be used in EditorRefPlugin typescript throws error

Lexical version: 0.11.3
Steps To Reproduce

initialise the ref with const editorRef = useRef<LexicalEditor>(null); or const editorRef = useRef<LexicalEditor>();
use it in EditorRefPlugin <EditorRefPlugin editorRef={editorRef} />

The current behavior
editorRef prop has type React.RefCallback<LexicalEditor> | MutableRefObject<LexicalEditor>
The expected behavior
editorRef prop should be React.RefCallback<LexicalEditor> | MutableRefObject<LexicalEditor | null | undefined>

I'd love to contribute but I don't have write access to the repo.

I'd love to contribute but I don't have write access to the repo.

Awesome!! You can just for the repo and make a pull request - this is the conventional way to contribute to an open source project. Let me know if you need additional guidance.


Series metadata inference fails on comparison with dask Scalar

import dask.dataframe as dd
import pandas as pd

df = pd.DataFrame({"x": range(10)})
a = dd.from_pandas(df, npartitions=2)

a.x > a.x.quantile(.5)

raises
$ python cmp.py
Traceback (most recent call last):
  File "/Users/tom.augspurger/Envs/dask/lib/python3.5/site-packages/dask/dask/dataframe/utils.py", line 146, in raise_on_meta_error
    yield
  File "/Users/tom.augspurger/Envs/dask/lib/python3.5/site-packages/dask/dask/dataframe/core.py", line 2616, in _emulate
    return func(*_extract_meta(args, True), **_extract_meta(kwargs, True))
  File "/Users/tom.augspurger/Envs/dask/lib/python3.5/site-packages/pandas/core/ops.py", line 812, in wrapper
    raise ValueError(msg)
ValueError: Can only compare identically-labeled Series objects

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "cmp.py", line 7, in <module>
    a.x > a.x.quantile(.5)
  File "/Users/tom.augspurger/Envs/dask/lib/python3.5/site-packages/dask/dask/dataframe/core.py", line 1030, in <lambda>
    return lambda self, other: elemwise(op, self, other)
  File "/Users/tom.augspurger/Envs/dask/lib/python3.5/site-packages/dask/dask/dataframe/core.py", line 2459, in elemwise
    meta = _emulate(op, *args, **kwargs)
  File "/Users/tom.augspurger/Envs/dask/lib/python3.5/site-packages/dask/dask/dataframe/core.py", line 2616, in _emulate
    return func(*_extract_meta(args, True), **_extract_meta(kwargs, True))
  File "/usr/local/Cellar/python3/3.5.2_2/Frameworks/Python.framework/Versions/3.5/lib/python3.5/contextlib.py", line 77, in __exit__
    self.gen.throw(type, value, traceback)
  File "/Users/tom.augspurger/Envs/dask/lib/python3.5/site-packages/dask/dask/dataframe/utils.py", line 159, in raise_on_meta_error
    raise ValueError(msg)
ValueError: Metadata inference failed in `gt`.

Original error is below:
------------------------
ValueError('Can only compare identically-labeled Series objects',)

Traceback:
---------
  File "/Users/tom.augspurger/Envs/dask/lib/python3.5/site-packages/dask/dask/dataframe/utils.py", line 146, in raise_on_meta_error
    yield
  File "/Users/tom.augspurger/Envs/dask/lib/python3.5/site-packages/dask/dask/dataframe/core.py", line 2616, in _emulate
    return func(*_extract_meta(args, True), **_extract_meta(kwargs, True))
  File "/Users/tom.augspurger/Envs/dask/lib/python3.5/site-packages/pandas/core/ops.py", line 812, in wrapper
    raise ValueError(msg)

That's with latest dask and pandas==0.19.0; With pandas=0.18.1, I get a similar message, the difference being
Original error is below:
------------------------
ValueError('Series lengths must match to compare',)

Haven't had a chance to dig into where the inference is failing :/
Just enough to see that scalar need to be a dask Scalar; calling .quantile(.5).compute() would cause that line to work.

Thanks for the bug report. This is an issue in the metadata inference for quantile - the _meta attribute is a series instead of a scalar as it should be. Fixing. Note that comparison with scalars does work:
In [7]: a.x < a.x.sum()
Out[7]: dd.Series<lt-b3d9..., npartitions=2, divisions=(0, 5, 9)>

Fixed in #1642.


[Enhancement] device detected message

When I first plugged my USBValve in, I thought my USB-A didn't work (bad solder, switched pins - as I was soldering it upside-down) or busted board because of my soldering ...
Well, if I put in for example a keyboard, it correctly starts detecting HID, but if I plug in a simple USB drive, there is nothing that would indicate that the device is actually plugged in, detected, or the board just knows about it in any other form (even if it would be just a detection that it consumes power on PIN 40.
It would be nice that if whenever a device is plugged in, there would be some info message first, before any error (if any) states would pop up.

I'll look into that. Thanks!

I added an initial support for this with release 0.16.0.

Works like charm. Thanks a lot!!

Thanks to you for the suggestion!


Add logs using tracing

This PR adds basic log support using the tracing crate. It gives more context to users about what is going on inside keyring-rs.

More logs can be added if #222 is accepted and merged, so I leave this PR in draft for now.

The PR is ready for review. In fact it can be mergde before or after #222, it does not matter.
I try to apply what you asked for, let me know if it's what you have in mind. I added env_logger for integration tests, so you can easily get logs with RUST_LOG=debug. I enabled it for the CI so we have logs always available, in case of. Just a proposition.


Using FeedForward and NDArray in Java

Hi,
Is there a way to use FeedForward function and NDArray to create the model in Java?
Thanks,
Gaurav

you can refer to https://github.com/dmlc/mxnet/tree/master/scala-package

@gaush123 You can also try swig.

@thirdwing Could you please just give little more information about swig. Thanks!

@tqchen @thirdwing @pluskid @sneakerkg Hi, I am trying to create the model using FeedForward using mxnet_predict-all.cc, instead of using it as predictor, as I want to run this process on mobile device instead of a desktop/server.
What I need to know is how do I pass the values of const void* param_bytes, in the function mentioned below. On my local I can do this by passing a dictionary (python) with key as names of the layers and values as NDArray 4D arrays.
How do I achieve the same result by using the fucntion below

\brief create a predictor
\param symbol_json_str The JSON string of the symbol.
\param param_bytes The in-memory raw bytes of parameter ndarray file.
\param param_size The size of parameter ndarray file.
\param dev_type The device type, 1: cpu, 2:gpu
\param dev_id The device id of the predictor.
\param num_input_nodes Number of input nodes to the net,
For feedforward net, this is 1.
\param input_keys The name of input argument.
For feedforward net, this is {"data"}
\param input_shape_indptr Index pointer of shapes of each input node.
The length of this array = num_input_nodes + 1.
For feedforward net that takes 4 dimensional input, this is {0, 4}.
\param input_shape_data A flatted data of shapes of each input node.
For feedforward net that takes 4 dimensional input, this is the shape data.
\param out The created predictor handle.
\return 0 when success, -1 when failure.
*/

MXNET_DLL int MXPredCreate(const char* symbol_json_str,
                           const void* param_bytes,
                           int param_size,
                           int dev_type, int dev_id,
                           mx_uint num_input_nodes,
                           const char** input_keys,
                           const mx_uint* input_shape_indptr,
                           const mx_uint* input_shape_data,
                           PredictorHandle* out);

@gaush123 Have you ever find a solution in using MXNet in Java?

Hi @Ldpe2G I trained the model in Python and now is going to deploy it in Java environment, but encountered some difficulties, could you give me a hint?
The model file is said to be language agnostic, so I write a predict function in Java as below:
public void predict(NDArrayIter dataiter, int batchSize) {

    SGD opt = new SGD(0.0001f, 0.9f, 0.000f, 0.0f, null);
    Uniform uniform = new Uniform(0.1f);
    Context[] ctx = new Context[1];
    ctx[0] = Context.cpu(0);
    FeedForward model = FeedForward.load("prefix", 10, ctx, 200, 32, opt, uniform, 32, false);

    model.predict(dataiter, batchSize);
}

The question is, how to create an NDArrayIter? I was going to start from creating an NDArray but failed at last. I found a quite similar issue here https://github.com/dmlc/mxnet/issues/2583
Thank you~


Update payload results (#73)

Coverage decreased (-0.5%) to 92.394% when pulling d4f5deff07cd2b200254efc529b51e690244bfae on update_payload_results into afb2920558a91f23a4cc7c49ac971eca1a2414e8 on v2.


Updated Docker rules to 0.22.0

Updated to newer Bazel docker rules.
https://github.com/bazelbuild/rules_docker/releases/tag/v0.22.0

Can't be updated due to Python 3.6 dependency. Docker build rules needs updated Python build rules, but this doesn't work yet. #3646 will resolve this and include the changes found in this PR.


Prepare 2.1.2 release

Signed-off-by: James Taylor<EMAIL_ADDRESS>

I wondered about calling out grpc-js but it seemed more like an implementation detail than the fix


Return tuple instead of dict

I think this is a little cleaner / more "pythonic"
Reviewers
Functional:
@metakuni
Readability:

Changes

add
remove
modify

Definition of Done (from ticket)
QA steps (optional)
Known Issues

PYTHONIC


refactor(workflows): use 4vcpu runner for weaver data sharing workflow

Additionally rename weaver workflows jobs, so as to uniquely identify them by their name.

Closing this as didn't realised this is a duplicate PR of #2368


Setup automated builds

I can configure AppVeyor and make a PR with the config file, works for you?

Hi @italopessoa - thanks for your interest in this issue.  Unfortunately this task has been assigned internally to a company member as we have a set of scripts and tools we already use (including appveyor) for managing builds and deployments.
Thanks again

Please remove "hacktoberfest" label than


ConfigMgr cannot enable ASR rules on server OSes

Per a support case I've had recently, there is a known issue where ConfigMgr cannot set ASR rules on server OSes:
"We have analyzed the logs you provided and have determined that they match a known issue the Product Group is currently aware of and working on. This refers specifically to the applicability of Attack Surface Reduction on Server OS versions which is marked as compliant without any actual enforcement. There is currently no ETA for when this will be fixed"
This document currently makes no mention of this known issue, I think it would be worth adding this to make it clear as currently there's nothing to state that this isn't a supported and functional scenario.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 1a360dd4-bb59-9f48-b182-8eaaf9e20a82
Version Independent ID: 54c5dde8-f8f1-4dd3-5408-12d2dc480970
Content: Enable attack surface reduction rules
Content Source: microsoft-365/security/defender-endpoint/enable-attack-surface-reduction.md
Service: microsoft-365-security
Sub-service: mde
GitHub Login: @jweston-1
Microsoft Alias: v-jweston

@CaptainUnlikely Thank you for your feedback. This issue has been escalated to the Engineering team and they are working on a fix. The document talks about the design and how the product should work. So we usually do not document bugs/design issues in the document unless it is unresolvable.
Hope this helps!
Thanks
Sri

Hi Sri,
Right now there is no way for a customer such as myself to know that this functionality doesn't work other than trying it out and opening a support case when it doesn't work only to be told that this is a known issue.
I understand the docs should cover how the product is supposed to work and can't cover every possible scenario but as I'm told there is no ETA for this to be fixed, to my mind this should be documented somewhere.
It doesn't impact me any more now that I'm aware of it, just trying to help avoid other customers and Microsoft wasting time with support tickets that are unnecessary when the cause is known.

@CaptainUnlikely Thank you for your response. I have made suggested changes in the document via PR#https://github.com/MicrosoftDocs/microsoft-365-docs/pull/9760
Once the author verifies and approves, the changes will be live.
Thanks
Sri

Approved.
From: Sriraman M S @.>
Sent: Monday, September 19, 2022 3:02 AM
To: MicrosoftDocs/microsoft-365-docs @.>
Cc: Brit Weston (Aquent LLC) @.>; Mention @.>
Subject: Re: [MicrosoftDocs/microsoft-365-docs] ConfigMgr cannot enable ASR rules on server OSes (Issue #9729)
@CaptainUnlikelyhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FCaptainUnlikely&data=05|01|v-jweston%40microsoft.com|b3aa66622de64780123808da9a2610a4|72f988bf86f141af91ab2d7cd011db47|1|0|637991785520392189|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=IHbmfpyttq0VAUi%2B3bGdLFko90RwTiO0FHCzJOJysYY%3D&reserved=0 Thank you for your response. I have made suggested changes in the document via PR##9760https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoftDocs%2Fmicrosoft-365-docs%2Fpull%2F9760&data=05|01|v-jweston%40microsoft.com|b3aa66622de64780123808da9a2610a4|72f988bf86f141af91ab2d7cd011db47|1|0|637991785520392189|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=UJx28kSglUCcCxWLuFDV4wrwfDUvMalcp8B%2FJHPz5q4%3D&reserved=0
Once the author verifies and approves, the changes will be live.
Thanks
Sri

Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoftDocs%2Fmicrosoft-365-docs%2Fissues%2F9729%23issuecomment-1250815978&data=05|01|v-jweston%40microsoft.com|b3aa66622de64780123808da9a2610a4|72f988bf86f141af91ab2d7cd011db47|1|0|637991785520392189|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=GoRaLDCHbmNmEvO4tlllRR02U5cBMK1Ulmf16l5b6%2Fk%3D&reserved=0, or unsubscribehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FATPOEXJ4KICGOOCFDELWHFDV7A23LANCNFSM6AAAAAAQNNRHUE&data=05|01|v-jweston%40microsoft.com|b3aa66622de64780123808da9a2610a4|72f988bf86f141af91ab2d7cd011db47|1|0|637991785520392189|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=kR7d6nX9LiA5BKRpNRDGoi7tCFqfwK%2FCQouoWO%2FX814%3D&reserved=0.
You are receiving this because you were mentioned.Message ID<EMAIL_ADDRESS>

@msbemba Thank you very much for the contribution and updating the documentation with PR. @CaptainUnlikely Hope this update is helpful for you. Thanks for taking out some time to open the issue. Appreciate and encourage you to do the same in future also.


Use Textmate's HAML grammar

The language-haml syntax for HAML has a recursive include (https://github.com/ezekg/language-haml/blob/master/grammars/ruby haml.cson#L360-L408) which is causing unbounded nesting of tags when parsing some HAML documents.
As an example, see the HTML source for this rendered document: https://github.com/ManageIQ/manageiq-ui-classic/blob/9b4bfe77184a177f24159fce36cd9377a2f020da/app/views/layouts/angular/_multi_auth_credentials.html.haml
It's not clear to me how to fix the HAML grammar, but I really believe the recursive inclusion is not correct. Hence, I propose we rollback to TextMate's grammar, which does not have this issue.
cc @github/linguist
Fixes https://github.com/github/github/issues/72875

Warnings:
vendor/licenses/grammar/ruby-haml.tmbundle.txt:
  - license needs reviewed: other.

How do I review a license? :)

When you say "unbounded nesting", which lines are you referring to?
I've only taken a cursory glance through the current HAML grammar, but I see a few oddities:

Matching newlines in patterns is handled inconsistently between implementors of the TextMate grammar system. Having a newline included as part of a match is actually a hack used by grammar authors: \n should actually be \n? instead.

This line isn't doing anything. It should be this instead:
-'patterns': [
+'captures': [
+  '0': 'patterns': [

This should end in haml, not html, I assume.

This should also include an .embedded scope, so it becomes source.embedded.ruby.

I doubt any of these errors are what're causing the nesting errors. May I see exactly which lines in the file you linked to are being directly affected?

Regarding the license review: I believe our approach is to whitelist the license file's checksum in test/test_grammars.rb. @pchaigno knows more about that than I do, however.

Further to @Alhadis's comments, it appears the original author (@meganemura) of the switch (https://github.com/github/linguist/pull/3355) soon encountered issues with the grammar they implemented (see https://github.com/github/linguist/issues/3371) and asked for this to be reverted but it was missed.
With that in mind, I think it may be worth reverting (this PR) to address https://github.com/github/linguist/issues/3371 and https://github.com/github/github/issues/68429 and https://github.com/github/github/issues/72875
As for the failing test: the license that has been detected (other) is none of those on the whitelist. This was "permissive" when we last used this grammar as we can see in https://github.com/github/linguist/pull/3355. I'm not sure how it got that though.

Oh! I forgot all about that...
Alright, in that case, revert the hell out of this. =)

@Alhadis: Just for completeness, you can see how https://github.com/ezekg/language-haml/blob/master/grammars/ruby haml.cson#L408 includes the original pattern again (i.e. recursively) when hitting a chunk of inline Ruby code.
The result is that if you have several lines in a row, each line contains all the tags from the previous lines.
It's very obvious in the HAML file I posted because of the huge chunks of redundant HTML in the page:
              = _("Used to gather Capacity & Utilization metrics.")

That is one line; the following line has the same contents + 2 extra tags, and the following one +4, and so on.
@lildude: Fixed the licensing. Can you please approve?

Thank you @Alhadis!

@bighairydude beat @lildude. =) You're most welcome.

@lildude Thanks for the mention about this issue. I'll close the #3371.

@pchaigno Should the hash list be moved to a config file in lib/linguist/? It took me ages to recall where it was located...

It was supposed to be only temporary, but I'm having a hard time getting rid of these unrecognized licenses. I suppose we could move the whitelists to their own file.
@vmg Has the issue been reported to the language-haml grammar? Would be great if we could go back to that grammar in the long term, since it receives updates more frequently.

I'll take a break from developing a graphical troff emulator for Atom to have a look at what's wrong...

Already fixed. How's this look?

Already fixed. How's this look?

I wouldn't trust it 😉. Lightshow is currently running Linguist 4.3.1 😱
I'll be updating it later.

@Alhadis Dayum, that works like a charm. Highlighting looks great and it doesn't create any redundant nodes. I've verified it using our production highlighting engine. :pray:
Could you please upstream that? We can then revert this PR right away.

Already on it. =)

:sorted => ezekg/language-haml#60
#hashrocket #hashtag #hashtagrocket

Upstream fix has been merged (🙇 @Alhadis) so I'm going to revert this and then update the grammar SHA.

@alhadis: Since I have you here (he hehehe), I've just noticed another bug on that grammar. It's basically https://github.com/github/linguist/issues/3371 -- where some string interpolations with # are showing up as comments instead.
I'm afraid your changes didn't catch that one. If you have some spare time to look into that, that'd be n e a t o. ✨

Sorry! I was AFK (which happens every now and then).
I'll tackle it now.

Is it possible to update the version of Linguist used by Lightshow? Or is that a bit more complicated than punching in a few commands?
Both Atom and Lightshow generate the same output, which is different to what's showing on GitHub. Which kinda makes it impossible to tell if changes will actually fix anything...

Is it possible to update the version of Linguist used by Lightshow? Or is that a bit more complicated than punching in a few commands?

As simple as updating a Gemfile and redeploying 😄 I was going to wait for the next linguist, but I can do it now if it helps you.

Yes please! =) That'd be ace.

@lildude Please ping me once it's done. I'm afraid there's very little I can do in the meantime.

@Alhadis will do. Things are so far behind that it's taking a little more than updating a Gemfile to solve. Will let you know when it's good to go.

@Alhadis Done. Lightshow is now running the same version of the parser and linguist (5.0.9) as we're running on github.com.
I've also added a little tweak to the interface to show the version of Linguist so peeps can determine this easily and give us a prod when we forget to update Lightshow 😄
If you have the time, and are able to sort out the HAML issue and get it merged by the end of the day on Thursday, that would be amazing.

Hey all! Maintainer of the Haml language package jumping in here—so I'm curious as to why GitHub renders the grammar differently than Atom? Running this test code through Lightshow (and of course on GitHub) renders very different results than Atom.
This is what it looks like in Atom (the whole file renders is correctly),

Is the GitHub parser vastly different than the one you're using in Atom?
Let me know if I need to dig in and fix things with the Haml grammar—when I took over that language package I didn't know a whole lot about grammars. After taking it over, I went in and closed out a lot of the issues that had been lingering in the Textmate grammar (mostly multiline stuff), but most of that was honestly by trial and error playing with different regexes.
tldr; I knew regex, but not how to put together a grammar so it may be incorrect/messy.

Pushed what I believe will be a fix.
It's a silly kludge but it fixes the interpolation highlighting:

Is the GitHub parser vastly different than the one you're using in Atom?

@ezekg it is quite different so there can be some slight differences.  @Alhadis is probably the most knowledgable when it comes to getting grammar working correctly with the GitHub parser.
I think to keep this alive and getting the attention it needs, @ezekg can you move this to a new issue? 🙇


v4l2_camera: 0.2.1-3 in 'foxy/distribution.yaml' [bloom]

Increasing version of package(s) in repository v4l2_camera to 0.2.1-3:

upstream repository: https://gitlab.com/boldhearts/ros2_v4l2_camera.git
release repository: https://gitlab.com/boldhearts/releases/ros2_v4l2_camera-release.git
distro file: foxy/distribution.yaml
bloom version: 0.9.7
previous version for package: 0.2.0-1

v4l2_camera
* Hold reference to parameters callback handle
* Contributors: Jacob Perron

Holding for the upcoming Foxy sync.

This release should resolve a regression: http://repo.ros2.org/status_page/ros_foxy_default.html?q=REGRESSION
Merging :crossed_fingers:


Option to disable [metrics] printed at the end of the run

Can we please get an option to opt out of getting metrics at the end of each run?
I actually think it should be opt-in for metrics but for now, just a way to turn it off would be great.
It is noisy and just clutters the output.

@aomarks - do you have an opinion on if metrics should be opt-in or opt-out? I'm happy to take on the work of reducing the noise since I am largely responsible for introducing the noise 😁

This is implemented as of 0.12.0 by setting the WIREIT_LOGGER environment variable. Docs: https://github.com/google/wireit#environment-variable-reference
simple is the classic wireit output without the metrics summary, and quiet is a new logger that will soon be the default.


[BotFramework-Connector] Fix webpack bundling broken

Fixes #818
Description
After removing the request dependency from the botframework-connector library the bundling of the app using WebPack would throw a missing dependencies error and fail (see issue #818 ).

Specific Changes
We removed the conditional imports in botframework-connector and replaced a variable (env) that was being initialized to global or window depending on the bot running locally or on a browser, and directly replaced its instances by a call to this which holds that value. This is because the function, being called through its constructor, will execute in the global scope (more information)
Code before this modification was:
(new Function('require', 'const env = (global || window); if (!env.hasOwnProperty("FormData")) { env.FormData = require("form-data"); }; if (!env.hasOwnProperty("fetch")) { env.fetch = require("node-fetch"); }'))(require);

Was changed to:
(new Function('require', 'if (!this.hasOwnProperty("FormData")) { this.FormData = require("form-data"); }; if (!this.hasOwnProperty("fetch")) { this.fetch = require("node-fetch"); }'))(require);

Line changed
Testing
We ran the unit tests after this change and they all passed successfully

Pull Request Test Coverage Report for Build #2218

1 of 1 (100.0%)  changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.05%) to 88.331%

Totals

Change from base Build #2213:
0.05%

Covered Lines:
3243

Relevant Lines:
3528

💛  - Coveralls


Question: If this possible, to use functions from win32 API (UWP)

I want to make UWP launcher and I need to create anticheat for this game. How can I include my anticheat win32 .dll and get info (if game started, if user cheater, etc.)
Thanks.

@Alkanores It depends on what API you call. Here's the list of Win32 API functions that can be accessed inside AppContainer UWP sandbox. If you are loading dynamically, you may need to use LoadPackagedLibrary instead of plain LoadLibrary and you should put in inside your package.

Thanks!


remove first byte check in callByAddress

https://github.com/Zondax/filecoin-solidity/blob/master/contracts/v0.8/utils/Actor.sol#L53
remove
        require(
            actor_address[0] == 0x00 || actor_address[0] == 0x01 || actor_address[0] == 0x02 || actor_address[0] == 0x03 || actor_address[0] == 0x04,
            "actor_address address should be bytes format"
        );

As this puts an unwanted limitation on future filecoin actor addresses that are acceptable
Change this to a check that actor_address is at least one character/byte long
cc @Stebalien to confirm this is the intended change

:link: zboto Link

@snissn this check was added as part of the auditor recommendations. I understand the future filecoin actor addresses issue, but we need to fail early someway if the user is not sending an address in bytes format (like using string format). We could do something like actor_address[0] < 10?

thank you! This change to require(actor_address.length > 1, "invalid actor_address"); looks good!


Extension idea: nmap scanner

My co-workers and I were talking today about how a nmap or nmap-like extension that could be used to perform ping sweeps and port scans could be very useful for device discovery on a network.
We're torn between using nmap directly and having the table work something like select * from nmap where args = '<insert standard nmap args>'or if it would be better to create an nmap-like extension that scans using native code instead of needing nmap to be installed on the system.

This would be extremely useful!!


Persistent provisioner (BLE mesh) (IDFGH-2060) (IDFGH-2061)

Hello
Some weeks ago I asked a question about making the provisioner of a BLE mesh network persistent. I got an answer that Espressif is working on this functionality, but I'm wondering when this functionality is to be expected because this is crucial to my application. Is this in terms of weeks or months?
Old Issue: https://github.com/espressif/esp-idf/issues/4141

Hi @jkockx
Currently we have implemented this feature and just test it, we will release this feature firstly in the branch ble_mesh_release/esp-ble-mesh-v0.6.1 next week.
Thanks for your patience

Thank you!

Hi @jkockx
The Provisioner nvs functionality has been added in the branch ble_mesh_release/esp-ble-mesh-v0.6.1, please pull and have a try.
Thanks.

@jkockx Thanks for reporting. Would you please help try and share the feedback? Thanks.

I'm sorry, I was away from this project for a while. I've pulled the ble_mesh_release/esp-ble-mesh-v0.6.1  branch but I'm not able to build my project anymore. Apparently, the export.sh script is missing in the main folder and because of this my system is unable set the correct path variables.
Should I apply another approach, different from the approach explained on the Getting Started page when working with this development branch?

Hi @jkockx
ble_mesh_release/esp-ble-mesh-v0.6.1 is based on a specific commit c064e008424d6f87cc78ca93ed572d4b2ba346d9. If you are switching from release/v4.0 or master branch to ble_mesh_release/esp-ble-mesh-v0.6.1, then the export.sh will be missing.
So if it's urgent that the Provisioner Persistant functionality needs to be used, please ref here for some help.
If it's not urgent, the Provisioner Persistent functionlaity will be merged into the master and release/v4.0 later. You can use the release/v4.0 or master branch currently.
Thanks & Regards

So if I understand right, this branch is still using the legacy build system? How do I switch between the Toolchain setup that I've already setup and the setup you mentioned?

Or when do you think this functionality will be merged into the master branch? My question is again if we are talking about weeks or about months?

Hi @jkockx
Currenly this functionality is in review, and it will be merged into the master branch in a few weeks.
Thanks.

@Campou
Waiting this feature too...

Hi @jkockx
Sorry for the late reply. We have supported the persistent functionality of Provisioner, please have a try.
And this issue will be closed for now. If you have some other questions, please feel free to open another one.
Thanks.


Archlinux doesn't have a limits.d directory by default

/etc/security/limits.d doesn't exist by default. It works and is included when it does exist, but needs to be made before https://github.com/hardening-io/chef-os-hardening/blob/master/recipes/limits.rb#L21 is ran. A simple wrapper recipe works:
directory '/etc/security/limits.d' do
  owner 'root'
  group 'root'
  mode '0755'
end
include_recipe 'os-hardening::default'

Looks like a fix for this was merged in, you can point Berkshelf to master if you would like to use these changes until we tag a new release.


[YUNIKORN-2954] Remove so-called modular sidebar

What is this PR for?
Remove the modular remote sidebar functionality, as it goes against the open philosophy of Apache YuniKorn development.
This reverts commit 21ebe5d9b1bbfc2e1eea8bbb8440d2a8bd38af4e.
What type of PR is it?

[ ] - Bug Fix
[ ] - Improvement
[ ] - Feature
[ ] - Documentation
[ ] - Hot Fix
[ ] - Refactoring

Todos

[x] - Task

What is the Jira issue?
https://issues.apache.org/jira/browse/YUNIKORN-2954
How should this be tested?
Screenshots (if appropriate)
Questions:

[ ] - The licenses files need update.
[ ] - There is breaking changes for older versions.
[ ] - It needs documentation.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 35.71%. Comparing base (95b0e58) to head (28580a5).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #219   +/-   ##
=======================================
  Coverage   35.71%   35.71%
=======================================
  Files           2        2
  Lines          56       56
=======================================
  Hits           20       20
  Misses         33       33
  Partials        3        3

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Modifying toleration on Kube-Proxy Daemonset reverts back to default

Is this a request for help? : Yes

Is this an ISSUE or FEATURE REQUEST? (choose one): Issue

What version of acs-engine?:
➜  acs git:(master) ✗ acs-engine version
Version: v0.11.0
GitCommit: cda96312
GitTreeState: clean

Orchestrator and version (e.g. Kubernetes, DC/OS, Swarm)
Kubernetes
Client Version: version.Info{Major:"1", Minor:"9", GitVersion:"v1.9.3", GitCommit:"d2835416544f298c919e2ead3be3d0864b52323b", GitTreeState:"clean", BuildDate:"2018-02-09T21:51:54Z", GoVersion:"go1.9.4", Compiler:"gc", Platform:"darwin/amd64"}
Server Version: version.Info{Major:"1", Minor:"8", GitVersion:"v1.8.4", GitCommit:"9befc2b8928a9426501d3bf62f72849d5cbcd5a3", GitTreeState:"clean", BuildDate:"2017-11-20T05:17:43Z", GoVersion:"go1.8.3", Compiler:"gc", Platform:"linux/amd64"}
What happened:
When editing kube-proxy daemonset with a new Toleration or modifying existing toleration via kubectl edit ds kube-proxy -n kube-system, changes was applied momentary but within 1-2 minutes, the changes were reverted back to the default.
Background is I have a node that's tainted with a dedicated=something:NoSchedule and it is causing both kube-proxy and calico-node DaemonSets to not schedule on it.
Modifying calico-node's toleration was successful, changes was applied and persisted. Calico runs on the tainted node.
Doing the same for kube-proxy caused kube-proxy to momentary spawn on the node, but after 1-2 minutes, kube-proxy shutsdown. Doing another kubectl edit ds kube-proxy -n kube-system. Shows that the previously made changes was reverted, although metadata.generation at this point increased by 2.
I've tested another scenario by adding a new annotations for kube-proxy and the changes persisted unlike tolerations.
What you expected to happen:
The tolerations to be persistently applied.
How to reproduce it (as minimally and precisely as possible):

kubectl taint node <node> somekey:value:NoSchedule
kubectl edit ds kube-proxy -n kube-system and add a new Toleration like:

- effect: NoSchedule
   operator: Exists

kubectl get po -n kube-system | grep kube-proxy should now show an additional kube-proxy spawn up
After 1-2 minutes, you should notice that newly created kube-proxy spinning down/terminated.
kubectl edit ds kube-proxy -n kube-system will now show the Toleration revert back to the original:

   72       - effect: NoSchedule
   73         key: node-role.kubernetes.io/master
   74         operator: Equal
   75         value: "true"

Anything else we need to know:
Describing ds/kube-proxy
Shows the events:
  Normal  SuccessfulCreate  22m   daemon-set  Created pod: kube-proxy-np7wl
  Normal  SuccessfulDelete  22m   daemon-set  Deleted pod: kube-proxy-mk85h

kube-proxy is run as an "addon" in the cluster, this means (to the best of my understanding) that the kube-addon-manager will reconcile the running definition with it's on-disk definition in /etc/kubernetes/addons/kube-proxy-daemonset.yaml every few minutes.
So, if you need to modify it, you have to change it on disk on all your master nodes.


Inner ref not passed down when using tag.input

When using tag.input from clean-tag, inner refs are not being passed down to the input element.
Using tag and setting is="input" on my component works fine.

I am also experiencing this issue. It doesn't seem to be possible to use inner refs with components created using system components as these use clean-tag under the hood. This affects most of the components included with rebass as they use system components.

I'm getting the following warning message when trying to use inner refs with components created with system components (e.g. with the Select component`):
"Stateless function components cannot be given refs. Attempts to access this ref will fail."
The reason I want to use innerRefs is to get access to the underlying dom as outlined here: https://github.com/styled-components/styled-components/blob/master/docs/tips-and-tricks.md in the styled component docs.
In rebass the only components that work this way are the box and flex components because they are directly using styled components and not through the system components. Below is some sample code:
class Header extends React.Component {
  constructor(props){
    super(props);
    this.myRef = React.createRef();
  }

  componentDidMount() {
    console.log(this.myRef);
  }

  render() {
    return (
      <Banner
        color="white"
        ratio={2 / 3}
        bg="blue"
      >
        <Box >
          <Select innerRef={this.myRef}><option>Hi</option></Select>
      </Banner>
    );
  }
}

The latest versions of clean-tag and system-components use React.fowardRef which should resolve this issue. Please open a new issue if not


[AVM Module Issue]: Private DNS Zone virtualNetworkLink description typo

Check for previous/existing GitHub issues

[X] I have checked for previous/existing GitHub issues

Issue Type?
Bug
Module Name
avm/res/network/private-dns-zone
(Optional) Module Name if not listed above
No response
(Optional) Module Version
0.2.4
Description
The module's description & documentation of the virtualNetworkLinks parameter indicates it should be an array objects containing properties 'vnetResourceId' and 'registrationEnabled'. The corresponding parameter is actually named virtualNetworkResourceId, not vnetResourceId
vnetResourceId
https://github.com/Azure/bicep-registry-modules/tree/main/avm/res/network/private-dns-zone#parameter-virtualnetworklinks
I can submit a PR, but wanted to make sure this isn't an issue with automation/doc-generation, rather than a typo.
(Optional) Correlation Id
No response

Good catch @colincmac and you are right. Feel free to raise a PR if you have availability, or to go the extra-mile and define a user-defined type for the virtualNetworkLink 😉, if @ChrisSidebotham agrees.

Looking into this now


Surelog does not populate vpiColumnNo, vpiEndLineNo, vpiEndColumnNo for instances

According the IEEE 1800 spec, this isn't strictly necessary, but it would be nice to have these filled out for module and generate/generate_array instances. Would there be any bad side effects to doing this?

Fixed by #1608


NuGet restore for .NET 6 Android project seems to ignore fallback frameworks

Prerequisites

[X] I have written a descriptive issue title
[X] I have searched issues to ensure it has not already been reported

Cake runner
Cake .NET Tool
Cake version
1.3.0
Operating system
Windows
Operating system architecture
64-Bit
CI Server
No response
What are you seeing?
I have .NET 6 project targeting net6.0-android I want to build using cake. This works fine using a simple command line build like dotnet build MyProject.csproj, however when I build the same project in cake using DotNetCoreBuild I get the following error during the restore phase:
NU1202: Package Xamarin.Google.Guava.ListenableFuture <IP_ADDRESS> is not compatible with net6.0-android31.0 (.NETCoreApp,Version=v6.0) / android-arm64. Package Xamarin.Google.Guava.ListenableFuture <IP_ADDRESS> supports: monoandroid50 (MonoAndroid,Version=v5.0)
What is expected?
The net6.0-android target supports monodroid packages and NuGet is supposed restore them appropriately.
Steps to Reproduce

Create a .NET 6 project with target framework net6.0-android
Add a monodroid based NuGet package to it (for example Xamarin.Google.Guava.ListenableFuture <IP_ADDRESS>).
No other code should be required to reproduce the issue
Try to build it using the DotNetCoreBuild method in cake
The error mentioned above should occur

Output log
No response

(moving to GitHub discussions)


Update sbt-native-packager to 1.9.9

Updates com.github.sbt:sbt-native-packager from 1.9.4 to 1.9.9.
GitHub Release Notes - Changelog - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Files still referring to the old version number
The following files still refer to the old version number (1.9.4).
You might want to review and update them manually.
project/Dependencies.scala

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "com.github.sbt", artifactId = "sbt-native-packager" } ]

labels: sbt-plugin-update, early-semver-patch, semver-spec-patch, old-version-remains, commit-count:1

Codecov Report

Merging #1514 (480ffeb) into unstable (b8b8664) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           unstable    #1514   +/-   ##
=========================================
  Coverage     74.89%   74.89%
=========================================
  Files           358      358
  Lines         11471    11471
  Branches        545      545
=========================================
  Hits           8591     8591
  Misses         2880     2880

Impacted Files
Coverage Δ

...he/io/annotations/parser/CommentPreprocessor.scala
95.60% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b8b8664...480ffeb. Read the comment docs.


Correct grayscale to consider luminance value

According to this article http://www.tannerhelland.com/3643/grayscale-image-algorithm-vb6/ , the human eye does not perceive RGB equally.
The actual formula is given by : Gray = (Red * 0.3 + Green * 0.59 + Blue * 0.11)
But for the sake of computation, I only use its integer approximation.
It was originally a TODO for 3 years.

I am not sure this is a good idea in the Image API. Textures transformed into greyscale might be used for special effects, and applying a special pre-transform might lead to confusing results for some people.
Maybe it could be a dedicated function, but a shader could do the job too if we don't want that in the core.

Also I was wondering if it could be done faster at higher precision. Instead of
uint16_t(rofs[0]) / 3 +
uint16_t(rofs[1]) / 2 +
uint16_t(rofs[2]) / 10));

How about
(int (rofs[0]) * 30 +
int (rofs[1]) * 59 +
int (rofs[2]) * 11)
/ 100

Following the same method you could also do it faster and still reasonably accurate by using a power of 2 divisor, which could be done by bitshifting, and use the full range of the container (probably 32 bit uint) to maintain accuracy.
You could also potentially use SIMD for this but I don't know on the policy of using SIMD with the different platforms, it might not be a bottleneck operation (and if it were as groud says a shader would be even better).
Also I don't think the current version adds up to 255 result even with 255,255,255 input.

@groud didn't think of that, perhaps it should be added as a new features with customizable weights and all that.

Also I would double check any assumptions about the colour space / gamma of the input, I'm presuming this is all assuming sRGB input.

Hey, Krita developer here, I saw this while browsing around.
Yes, these values, the luma coefficients have nothing to do with human perception, but rather they're the luminance value (specifically the Y values  of xyY, (which in turn is from XYZ)) of the colorants(red, green and blue) used for sRGB. They also need to be applied to a linearized version of the RGB values for proper results.
It might be worth to check the color space recommendations for YUV(Y here is again, the Luma, or grayscale you want) conversions. Rec 709 is what is used for sRGB to YUV conversions, while Rec 2100 is what is used for YUV conversions for HDR screens.
I hope this isn't inappropriate :)

@hbina This needs to be rebased on the latest master branch, and the above feedback needs to be addressed.


访问 Web端 http://<IP_ADDRESS>:8080/web 404 page not found

curl --location 'http://<IP_ADDRESS>:8080/v1/chat/completions' \

--header 'Content-Type: application/json'
--data '{
"model": "gpt-3.5-turbo",
"messages": [{"role": "user", "content": "Say this is a test!"}],
"stream": true
}'
data: {"id":"chatcmpl-QXlha2FBbmROaXhpZUFyZUF3ZXNvbWUK","object":"chat.completion.chunk","created":0,"model":"gpt-3.5-turbo-0301","choices":[{"delta":{"role":"assistant"},"index":0,"finish_reason":null}]}

data: {"id":"chatcmpl-QXlha2FBbmROaXhpZUFyZUF3ZXNvbWUK","object":"chat.completion.chunk","created":0,"model":"gpt-3.5-turbo-0301","choices":[{"delta":{"content":"This"},"index":0,"finish_reason":null}]}
data: {"id":"chatcmpl-QXlha2FBbmROaXhpZUFyZUF3ZXNvbWUK","object":"chat.completion.chunk","created":0,"model":"gpt-3.5-turbo-0301","choices":[{"delta":{"content":" is"},"index":0,"finish_reason":null}]}
data: {"id":"chatcmpl-QXlha2FBbmROaXhpZUFyZUF3ZXNvbWUK","object":"chat.completion.chunk","created":0,"model":"gpt-3.5-turbo-0301","choices":[{"delta":{"content":" a"},"index":0,"finish_reason":null}]}
data: {"id":"chatcmpl-QXlha2FBbmROaXhpZUFyZUF3ZXNvbWUK","object":"chat.completion.chunk","created":0,"model":"gpt-3.5-turbo-0301","choices":[{"delta":{"content":" test"},"index":0,"finish_reason":null}]}
data: {"id":"chatcmpl-QXlha2FBbmROaXhpZUFyZUF3ZXNvbWUK","object":"chat.completion.chunk","created":0,"model":"gpt-3.5-turbo-0301","choices":[{"delta":{"content":"!"},"index":0,"finish_reason":null}]}
data: {"id":"chatcmpl-QXlha2FBbmROaXhpZUFyZUF3ZXNvbWUK","object":"chat.completion.chunk","created":0,"model":"gpt-3.5-turbo-0125","choices":[{"delta":{},"index":0,"finish_reason":"stop"}]}
data: [DONE]
[root@instance-20221012-2111 ~]# curl --location 'http://<IP_ADDRESS>:8080/v1/chat/completions' \

--header 'Content-Type: application/json'
--data '{
"model": "gpt-3.5-turbo",
"messages": [{"role": "user", "content": "Say this is a test!"}],
"stream": true
}'
data: {"id":"chatcmpl-QXlha2FBbmROaXhpZUFyZUF3ZXNvbWUK","object":"chat.completion.chunk","created":0,"model":"gpt-3.5-turbo-0301","choices":[{"delta":{"role":"assistant"},"index":0,"finish_reason":null}]}

data: {"id":"chatcmpl-QXlha2FBbmROaXhpZUFyZUF3ZXNvbWUK","object":"chat.completion.chunk","created":0,"model":"gpt-3.5-turbo-0301","choices":[{"delta":{"content":"This"},"index":0,"finish_reason":null}]}
data: {"id":"chatcmpl-QXlha2FBbmROaXhpZUFyZUF3ZXNvbWUK","object":"chat.completion.chunk","created":0,"model":"gpt-3.5-turbo-0301","choices":[{"delta":{"content":" is"},"index":0,"finish_reason":null}]}
data: {"id":"chatcmpl-QXlha2FBbmROaXhpZUFyZUF3ZXNvbWUK","object":"chat.completion.chunk","created":0,"model":"gpt-3.5-turbo-0301","choices":[{"delta":{"content":" a"},"index":0,"finish_reason":null}]}
data: {"id":"chatcmpl-QXlha2FBbmROaXhpZUFyZUF3ZXNvbWUK","object":"chat.completion.chunk","created":0,"model":"gpt-3.5-turbo-0301","choices":[{"delta":{"content":" test"},"index":0,"finish_reason":null}]}
data: {"id":"chatcmpl-QXlha2FBbmROaXhpZUFyZUF3ZXNvbWUK","object":"chat.completion.chunk","created":0,"model":"gpt-3.5-turbo-0301","choices":[{"delta":{"content":"!"},"index":0,"finish_reason":null}]}
data: {"id":"chatcmpl-QXlha2FBbmROaXhpZUFyZUF3ZXNvbWUK","object":"chat.completion.chunk","created":0,"model":"gpt-3.5-turbo-0125","choices":[{"delta":{},"index":0,"finish_reason":"stop"}]}
data: [DONE]
使用nextchat也报错{
"error": true,
"message": "Failed to fetch"
}
接口地址写入的http://<IP_ADDRESS>:8080/v1/chat/completions
postman 请求http://<IP_ADDRESS>:8080/v1/chat/completions 也是404 page not found

本地Web端要用服务器的IP地址啊🤣

你用get 请求肯定是404，curl不是能用吗

本地Web端要用服务器的IP地址啊🤣

http://ip:8080/v1/chat/completions post
{
"model": "gpt-3.5-turbo",
"messages": [
{
"role": "user",
"content": "你好"
}
],
"temperature": 0.7
}
{
"code": 403,
"message": "response status code is not 200",
"param": {},
"type": "InitTurnStile_request_error"
}
postman请求IP的8080端口，这种报错如何解决

本地Web端要用服务器的IP地址啊🤣

http://ip:8080/v1/chat/completions post
{
"model": "gpt-3.5-turbo",
"messages": [
{
"role": "user",
"content": "你好"
}
],
"temperature": 0.7
}
{
"code": 403,
"message": "response status code is not 200",
"param": {},
"type": "InitTurnStile_request_error"
}
postman请求IP的8080端口，这种报错如何解决


Doesnt seem to work with android gradle plugin 2.4.0-alpha6

After upgrade to gradle plugin 2.4.0-alpha6 lombok does not generate getters and setters methods anymore.

Without more details we're not going to change anything.


Require distance input for upstream with tributaries and downstream with diversions.

Since the UT and DD queries can be really expensive, I think we should require a distance input to be entered explicitly.
We should add swagger documentation that indicates that this is a very expensive query and should not be executed in parallel.
This change in behavior would apply to the new "navigation" endpoint only.

https://labs-dev.wma.chs.usgs.gov/api/nldi/linked-data/nwissite/USGS-01105585/navigation/UT/flowlines?f=json is a 400
https://labs-dev.wma.chs.usgs.gov/api/nldi/linked-data/nwissite/USGS-01105585/navigation/UT/flowlines?distance=10&f=json does work though!
@jkreft-usgs I'm happy -- do you want an error message in addition to the 400?


net/aodvv2: small cleanups

Reduces code duplication when debugging a packet.

What's the status for this PR?

@luisan00 It's fine to merge as is.

@xkevin190 could you review this PR :wink:?


Repm 19 payment generate and manage payment

More info about this SN Object can be found here: https://docs.servicenow.com/bundle/orlando-application-development/page/build/applications/concept/impl-scripted-ext-pts-base-code.html

Need to add an export to the server side types or you won't be able to import it


JS Emitter crashes on helloworld with big ints

How to reproduce:
$ sbt
sbt:Scala.js> set scalaJSLinkerConfig in helloworld.v2_12 ~= (_.withESFeatures(_.withAllowBigIntsForLongs(true)))
// snip
sbt:Scala.js> helloworld2_12/fastLinkJS
[info] compiling 3 Scala sources to /home/tos/gh/scala-js/linker/jvm/.2.12/target/scala-2.12/classes ...
[info] Fast optimizing /home/tos/gh/scala-js/examples/helloworld/.2.12/target/scala-2.12/helloworld-fastopt
[error] stack trace is suppressed; run last helloworld2_12 / Compile / fastLinkJS for the full output
[error] (helloworld2_12 / Compile / fastLinkJS) java.util.NoSuchElementException: key not found: ClassName<java.lang.ArithmeticException>
[error] Total time: 11 s, completed Jul 6, 2024, 4:08:52 PM

Ouch. That happens because the Infos builders only register a dependency on ArithmeticException if there is a division/modulo somewhere in the program:
https://github.com/scala-js/scala-js/blob/9f5cc98f7f8f1d93a07ca6592aea2e953488b062/linker/shared/src/main/scala/org/scalajs/linker/analyzer/Infos.scala#L653-L674
while the CoreJSLib unconditionally emits the intDiv and intMod helpers (and under bigints-for-longs, also longDiv and longMod, which need ArithmeticException:
https://github.com/scala-js/scala-js/blob/9f5cc98f7f8f1d93a07ca6592aea2e953488b062/linker/shared/src/main/scala/org/scalajs/linker/backend/emitter/CoreJSLib.scala#L912-L929
The issue does not appear with RuntimeLong-for-longs because the emitter then unconditionally declares a dependency on RuntimeLong./, which itself depends on ArithmeticException, and so the latter is unconditionally required.
The ideal fix would be to only emit the four {int,long}{Div,Mod} helpers if ArithmeticException is instantiated. We have precedent for that kind of stuff with GlobalKnowledge.isClassClassInstantiated.


Honor $RUSTUP_HOME

build_system/src/test.rs generates a config.toml that contains a path directly to (what should be) the appropriate rustc binary. However, it incorrectly assumed rustup stores the rustc binaries in ~/.rustup. In actuality, rustup first checks the environment variable RUSTUP_HOME, and defaults to ~/.rustup if the variable is not set. Now build_system/src/test.rs uses the correct path.
If there is a more idiomatic way to encode this please let me know and I'll fix it.

Disclaimer: Some of the ui tests failed, but I wasn't able to run those tests before I made this change. Still diagnosing those.

Maybe running rustup which rustc and using the output would be better? That returns the ground truth as used by rustup.


CPU pinning not ideal on SMT

https://github.com/b4rtaz/distributed-llama/blob/8b1cf898f03c9176489f065906192f0d396f16e8/src/utils.cpp#L191
Will cause dllama to pin threads on consecutive cpus, which isn't ideal on some systems with hyper threading (SMT), which can be laid out this way:
grep -e processor -e "core id" /proc/cpuinfo
processor	: 0
core id		: 0
processor	: 1
core id		: 0
processor	: 2
core id		: 1
processor	: 3
core id		: 1
processor	: 4
core id		: 2
processor	: 5
core id		: 2
...

When running with --nthreads $(($(nproc)/2)) this will only hit half of the real cores, but both threads on each core, essentially halving performance, since the other half of real cores sits idle.
Overriding this with taskset is also not possible.
In this example, distributing threads over context->threadIndex*2 or context->threadIndex + 1 would be ideal.

Hello @lemmi, pinning cpus were added by different reasons, but it seems not needed now. I deleted this part from the code for now.

Thanks :)
This is probably the easiest solution and there is still taskset if some special distribution over cpus is necessary.


RtAudio tlRender audio enhancements

Currently, RtAudio (on Windows and Linux) supports different back-ends.  It would be great if it was possible to set the backend to use, to troubleshoot issues, like:
https://github.com/ggarra13/mrv2/issues/194
On Windows, I would like to switch between Asio, WasApi and Direct Sound.
On Linux, we should be able to switch between JACK, ALSA and OSS.
I can probably add this myself, but you are better at designing the API than I am.
Also, on macOS, I had some requests for the following:
https://github.com/ggarra13/mrv2/discussions/221
I was not aware that RtAudio sets the audio to 48KHZ (on macOS at least) automatically.  From what I can tell from looking at the source of RtAudio, there's currently no way to set the Audio Soundcard to.
mrViewer supported selection of audio soundcards, like:

Never mind.  I went ahead and implemented it in mrv2.


Run it?

What exactly is the code? Do I have to compile it? Or just ran .py using the same method used in the original version?.
I'm rather new when it comes to GitHub, but the description is not very friendly when it comes to non-Github users, even very puzzle.

pip install -r requirement.txt
python setup.py develop

Thanks, but now it gives me this error after use the setup.py command:
error: numpy 1.21.6 is installed but numpy<1.21 is required by {'gfpgan'}

follow the installation https://github.com/xinntao/Real-ESRGAN#wrench-dependencies-and-installation

I did that from the start. and yet still got that error

do a pip install requirements.txt while inside the folder'


Unable to validate receipt in ios Production. Sandbox and Testflight is fine

Hi,
I have a iap subscription which is autorenewable. I validate the receipt using sibelius/iap-receipt-validator based on availability of the latest_receipt_info field in validate data and expires_date in that. I tried to validate like
validationData['latest_receipt_info'][0].expires_date > today
This works absolutely fine in sandbox and in testflight app version.
But the same code fails in production. I really cannot understand why. In production i purchase auto renewable subscription, and when i try to validate using below, it throws unable to evaluate validationData['latest_receipt_info'][0].expires_date.
 if( !validationData['latest_receipt_info'] ||
                (!validationData['latest_receipt_info'].expires_date &&
                !validationData['latest_receipt_info'][0].expires_date) ){
               // DO PAYMENT
            }else{
                if(validationData['latest_receipt_info'][0] && validationData['latest_receipt_info'][0].expires_date &&
                validationData['latest_receipt_info'][0].expires_date < today ){
                    // DO PAYMENT
                }else if(validationData['latest_receipt_info'] && validationData['latest_receipt_info'].expires_date &&
                validationData['latest_receipt_info'].expires_date < today){
                    // DO PAYMENT
                }else{
                    // NAVIGATE TO PREMIUM SUBSCRIPTION PAGE
                }
            }

Could you please help.

Any news?

@MeiyappanKannappa were you able to fix the issue? What was the fix?


Learn about and replace bot wiring

(pending parts and/or pcbs)
It never hurts to pre-emptively study and ask about the wiring on the robot.
It's a great way to learn about how to do (or not to do!) things in hardware.

This has been long done (sorry for the spam everyone)


Add smart Rate Limiter

Now that we have a built-in retry handler for rate limited errors in v3.9, retrying a request after getting rate-limited is much easier than before.

https://github.com/slackapi/python-slack-sdk/releases/tag/v3.9.0
https://github.com/slackapi/python-slack-sdk/blob/v3.9.1/slack_sdk/http_retry/builtin_handlers.py#L52-L91
https://github.com/slackapi/python-slack-sdk/blob/v3.9.1/slack_sdk/http_retry/builtin_async_handlers.py#L49-L88

However, getting rate-limited results in a much longer execution time as the whole operation. As a solution for this pain point, we will add a built-in traffic control layer like we do in the Java SDK: https://slack.dev/java-slack-sdk/guides/web-api-basics#rate-limits
A few points to consider for implementing this feature:

The module manages the amount of requests in the last minute and calculate the interval before the next API call
Metrics data can be in memory in most use cases but the part should be extensible to switch to other data storage (e.g., Redis)
As we do in the Java SDK, running the same script/app in multiple hosts should be supported.
For backward-compatibility, we don't turn the feature on by default. Users can enable it only when they want it.
Both sync and async API clients should be supported in a proper way (= don't use time.sleep in asyncio apps)
All API clients (Web API, Audit Logs, SCIM, Webhook) should have the functionality.

Category (place an x in each of the [ ])

[x] slack_sdk.web.WebClient (sync/async) (Web API client)
[x] slack_sdk.webhook.WebhookClient (sync/async) (Incoming Webhook, response_url sender)
[ ] slack_sdk.models (UI component builders)
[ ] slack_sdk.oauth (OAuth Flow Utilities)
[ ] slack_sdk.socket_mode (Socket Mode client)
[x] slack_sdk.audit_logs (Audit Logs API client)
[x] slack_sdk.scim (SCIM API client)
[ ] slack_sdk.rtm (RTM client)
[ ] slack_sdk.signature (Request Signature Verifier)

Requirements
Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to those rules.

I've implemented a similar thing in the Discovery API SDK: https://github.com/slackapi/python-slack-discovery-sdk/blob/main/slack_discovery_sdk/rate_limit_support.py The ones for the APIs supported by this SDK (especially the Web APIs) would require a bit more complex logic, though.


Polish linter, add format command

This PR polishes functionality around the linter. It makes a distinction between linting and formatting. Formatting is purely syntax, analogous to prettier. In an editor on save you would autoformat. Lint autofixing is a deliberate action you would perform, either through the CLI or with an editor integration. This allows us to be much more aggressive with the sorts of lint autofixes that we add such as removing unused variables.

This PR is large and probably difficult to review so I'm going to merge and in the future try to do smaller diffs (even if I do merge them quickly). Planning on having more structure since I don't want to approve my own PRs.


Routes via container

Okay this may be an absolutely stupid question; but looking at the documentation and the source code I see the router is injected via a container, and can be replaced by any class implementing \Slim\Interfaces\RouterInterface. Is it possible to get the router from a separate service container, which can add it's own route's; and should this be documented in the official documentation?
I'm happy to document if this is valid, I just wanted to get some feedback to see if I'm loosing my marbles thinking it's a lot cleaner, and more modular than using $app->{$verb} globally, or requiring files which $app->verb?
My thinking is that a lot of frameworks will be supporting PSR-7, they will also likely have some low-level routing interoperability and it could increase code sharing potential for services to work on multiple frameworks.

Is it possible to get the router from a separate service container, which can add it's own route's;

I'm sorry, but I'm not sure that I understand the question. Slim already has a container and retrieves the router from it. It looks for the key called router and you can provide whatever class you like for that.

Hi @akrabat not looking to override the router itself, but asking about handling routes themselves via di instead of require as in your slim3 example

@Lewiscowles1986 you can store routes in an array if you want and iterate over that key elsewhere...
//In Container...
'routetable' => [
    'verb' => [
        'pattern' => 'callback'
    ],
]

//someplace else...
$routetable = $app->getContainer()['routetable'];

foreach ($routetable as $verb = > $routes) {
    foreach ($routes as $pattern => $callback) {
        $app->map([$verb], $pattern, $callback);
    }
}

Or something like that ;)

Thanks @geggleto!


fields size will include padding between struct elements, just not at…

fixes #444

and also https://github.com/uwsampa/grappa/blob/bmyerz/support-raco-udas/applications/join/Relation_io_tests.cpp#L179


route logs to logback

Hi,
i tried to route the log messages to logback as described

https://logging.apache.org/log4j/2.x/maven-artifacts.html
https://blog.espenberntsen.net/tag/logback/

can you take a short look at the georocket-server and check if that is what you expected?
Note: I removed the log level to check if there is any logger which i forgot

Yes, this is what I was looking for.
Just a question. When I start GeoRocket now (without your pull request) I get the following warning:
log4j:WARN No appenders could be found for logger (io.netty.util.internal.logging.InternalLoggerFactory).
log4j:WARN Please initialize the log4j system properly.
log4j:WARN See http://logging.apache.org/log4j/1.2/faq.html#noconfig for more info.

Will the PR fix this warning? If yes, perfect!

I can not reproduce the log4j warnings (log4j:WARN).

Cool. Let me know when the PR is ready to be merged (when you've removed the [WIP] tag). Thanks!

ready

Very good! Thanks!


Fix server MongoPubsub to restart subscriptions after crashing

Fixes #3206

Store subscriptions in a persistent class variable that survives across actor crashes, instead of an instance variable that gets reset on actor crashes
Resume subscription processing after crash
More debug logging of pubsub actions

Testing
RPCs now continue working after the pubsub actor crashes.
diff --git a/server/app/services/mongo_pubsub.rb b/server/app/services/mongo_pubsub.rb
index df734ac..a0d61d3 100644
--- a/server/app/services/mongo_pubsub.rb
+++ b/server/app/services/mongo_pubsub.rb
@@ -130,6 +130,8 @@ class MongoPubsub
   def publish(channel, data)
     debug "publish #{channel}"

+    fail "crash!" if channel == 'rpc_client' && data.to_s =~ /crash/
+
     self.collection.insert_one(
       channel: channel,
       data: BSON::Binary.new(MessagePack.pack(data)),

$ bundle exec bin/kontena node health core-01
⊛ Node is online for 8s
⊛ Node core-01 etcd is healthy
$ bundle exec bin/kontena etcd ls /crash
 [fail] Retrieving keys from etcd     \
 [error] 500 : Internal Server Error (/v1/etcd/development//crash)
$ bundle exec bin/kontena node health core-01
⊛ Node is online for 17s
⊛ Node core-01 etcd is healthy

D, [2018-01-15T12:22:32.153687 #9] DEBUG -- TokenAuthentication: Access token found
D, [2018-01-15T12:22:32.182212 #9] DEBUG -- MongoPubsub: subscribe rpc_client:41634832
D, [2018-01-15T12:22:32.183001 #9] DEBUG -- MongoPubsub: publish rpc_client
D, [2018-01-15T12:22:32.186282 #13] DEBUG -- MongoPubsub::Subscription: queued rpc_client...
D, [2018-01-15T12:22:32.187050 #9] DEBUG -- MongoPubsub::Subscription: queued rpc_client...
D, [2018-01-15T12:22:32.441491 #13] DEBUG -- MongoPubsub: publish rpc_client:41634832
D, [2018-01-15T12:22:32.443250 #9] DEBUG -- MongoPubsub::Subscription: queued rpc_client:41634832...
<IP_ADDRESS> - - [15/Jan/2018:12:22:32 +0000] "GET /v1/nodes/development/core-01/health HTTP/1.1" 200 248 0.3937

D, [2018-01-15T12:22:34.047500 #9] DEBUG -- TokenAuthentication: Access token found
D, [2018-01-15T12:22:34.054504 #9] DEBUG -- MongoPubsub: subscribe rpc_client:1247718998
D, [2018-01-15T12:22:34.055083 #9] DEBUG -- MongoPubsub: publish rpc_client
E, [2018-01-15T12:22:34.055259 #9] ERROR -- : Actor crashed!
RuntimeError: crash!
	/app/app/services/mongo_pubsub.rb:132:in `publish'
	/usr/lib/ruby/gems/2.4.0/gems/celluloid-0.17.3/lib/celluloid/calls.rb:28:in `public_send'
	/usr/lib/ruby/gems/2.4.0/gems/celluloid-0.17.3/lib/celluloid/calls.rb:28:in `dispatch'
	/usr/lib/ruby/gems/2.4.0/gems/celluloid-0.17.3/lib/celluloid/call/async.rb:7:in `dispatch'
	/usr/lib/ruby/gems/2.4.0/gems/celluloid-0.17.3/lib/celluloid/cell.rb:50:in `block in dispatch'
	/usr/lib/ruby/gems/2.4.0/gems/celluloid-0.17.3/lib/celluloid/cell.rb:76:in `block in task'
	/usr/lib/ruby/gems/2.4.0/gems/celluloid-0.17.3/lib/celluloid/actor.rb:339:in `block in task'
	/usr/lib/ruby/gems/2.4.0/gems/celluloid-0.17.3/lib/celluloid/task.rb:44:in `block in initialize'
	/usr/lib/ruby/gems/2.4.0/gems/celluloid-0.17.3/lib/celluloid/task/fibered.rb:14:in `block in create'
I, [2018-01-15T12:22:34.055344 #9]  INFO -- MongoPubsub: terminated
D, [2018-01-15T12:22:34.055491 #9] DEBUG -- MongoPubsub: freezing master:leader_elect
D, [2018-01-15T12:22:34.055857 #9] DEBUG -- MongoPubsub: freezing rpc_client
D, [2018-01-15T12:22:34.056050 #9] DEBUG -- MongoPubsub: freezing FirehoseApiEvent
I, [2018-01-15T12:22:34.056394 #9]  INFO -- MongoPubsub: initialized
D, [2018-01-15T12:22:34.056474 #9] DEBUG -- MongoPubsub: freezing rpc_client:1247718998
D, [2018-01-15T12:22:34.056540 #9] DEBUG -- MongoPubsub: restoring master:leader_elect...
D, [2018-01-15T12:22:34.056670 #9] DEBUG -- MongoPubsub: restoring rpc_client...
D, [2018-01-15T12:22:34.056707 #9] DEBUG -- MongoPubsub: restoring FirehoseApiEvent...
D, [2018-01-15T12:22:34.056737 #9] DEBUG -- MongoPubsub: restoring rpc_client:1247718998...
I, [2018-01-15T12:22:34.059862 #9]  INFO -- MongoPubsub: starting to tail collection

RpcClient::TimeoutError (Connection timeout (5s)):
  /app/app/services/rpc_client.rb:90:in `wait_for_response'
  /app/app/services/rpc_client.rb:53:in `request'
  /app/app/routes/v1/etcd_api.rb:25:in `block (4 levels) in <class:EtcdApi>'
  /usr/lib/ruby/gems/2.4.0/gems/roda-2.26.0/lib/roda.rb:767:in `always'
  /usr/lib/ruby/gems/2.4.0/gems/roda-2.26.0/lib/roda.rb:460:in `is'
  /app/app/routes/v1/etcd_api.rb:22:in `block (3 levels) in <class:EtcdApi>'
  ...
  /usr/lib/ruby/gems/2.4.0/gems/puma-3.9.1/lib/puma/thread_pool.rb:120:in `block in spawn_thread'

<IP_ADDRESS> - - [15/Jan/2018:12:22:39 +0000] "GET /v1/etcd/development//crash HTTP/1.1" 500 4315 5.0804

D, [2018-01-15T12:22:40.693216 #13] DEBUG -- TokenAuthentication: Access token found
D, [2018-01-15T12:22:40.700187 #13] DEBUG -- MongoPubsub: subscribe rpc_client:1805502268
D, [2018-01-15T12:22:40.700795 #13] DEBUG -- MongoPubsub: publish rpc_client
D, [2018-01-15T12:22:40.701959 #9] DEBUG -- MongoPubsub::Subscription: queued rpc_client...
D, [2018-01-15T12:22:40.702210 #13] DEBUG -- MongoPubsub::Subscription: queued rpc_client...
D, [2018-01-15T12:22:40.962856 #13] DEBUG -- MongoPubsub: publish rpc_client:1805502268
D, [2018-01-15T12:22:40.965305 #13] DEBUG -- MongoPubsub::Subscription: queued rpc_client:1805502268...
<IP_ADDRESS> - - [15/Jan/2018:12:22:40 +0000] "GET /v1/nodes/development/core-01/health HTTP/1.1" 200 248 0.3502

Pending approval

Looks like the MongoPubsub with existing subscriptions after crashing is able to restart and process publishes is racy on the same initialize => async.tail! race as in https://github.com/kontena/kontena/pull/3038/#issuecomment-344624933
    after crashing
D, [2018-02-14T16:35:58.917945 #6820] DEBUG -- MongoPubsub: subscribe test1
I, [2018-02-14T16:35:58.918531 #6820]  INFO -- MongoPubsub: terminated
D, [2018-02-14T16:35:58.918660 #6820] DEBUG -- MongoPubsub: preserving test1 on crash
I, [2018-02-14T16:35:58.919366 #6820]  INFO -- MongoPubsub: initialized
D, [2018-02-14T16:35:58.919419 #6820] DEBUG -- MongoPubsub: restoring test1...
I, [2018-02-14T16:35:58.922628 #6820]  INFO -- MongoPubsub: starting to tail collection
D, [2018-02-14T16:35:58.924762 #6820] DEBUG -- MongoPubsub: publish test1
D, [2018-02-14T16:35:58.960383 #6820] DEBUG -- MongoPubsub: stopped test1
      is able to restart and process publishes (FAILED - 1)

Failures:

  1) MongoPubsub with existing subscriptions after crashing is able to restart and process publishes
     Failure/Error: expect(test1_msgs).to eq [{'test' => 1}]

       expected: [{"test"=>1}]
            got: []

       (compared using ==)

       Diff:
       @@ -1,2 +1,2 @@
       -[{"test"=>1}]
       +[]

     # ./spec/services/mongo_pubsub_spec.rb:169:in `block (4 levels) in <top (required)>'
     # ./spec/spec_helper.rb:94:in `block (2 levels) in <top (required)>'
     # ./spec/spec_helper.rb:88:in `block (3 levels) in <top (required)>'
     # ./spec/spec_helper.rb:87:in `block (2 levels) in <top (required)>'

The publish gets lost because the tail! => defer { self.collection.find(...) do ... }  loop isn't running yet...


Custom tile source repeatedly loads source files

When I used the custom tile source that official demo provided in GitHub, I found that each time a tile is acquired, a source file is requested and the source file is stored in the browser memory. If the source file is too large, it may easily cause insufficient memory to run. Is there any solution?

Which custom tile source demo are you talking about? This one?
http://openseadragon.github.io/examples/tilesource-custom/
I don't get any of those things when I try it...

I see this example
https://github.com/openseadragon/openseadragon/blob/master/test/demo/customheaders.html
But I already solved it

Great! Out of curiosity, what was the issue?