[Bug]: Serial port becomes unusable until node-red restart w/ newer versions

What happened?
A few days ago I updated nodejs and node-red on a raspi4.  Prior to the upgrade all was well.  Subsequent to the upgrade I'm seeing an issue that I believe I've narrowed down to serial port logic in node-red-contrib-zwave-js:
If I leave the zwave js  controller node enabled when I do a "deploy" or "restart nodes", that port will subsequently become unavailable due to some problem with port locking.  The controller node emits messages about being unable to lock the usb port.
ZWaveError: Failed to open the serial port: Error Resource temporarily unavailable Cannot lock port (ZW0100)
The only way I have found to recover from this is to restart node-red itself.  Once I do that, the controller node works properly again.
I have managed to work around this by being sure to disable + deploy the disable before doing other work.  If I do that I can reliably bring the controller back up by enabling the controller node + deploy.
I looked at a LOT of stuff tracking this down, so I'm pretty sure it's somewhere in your stuff.  Briefly:

I ensured that nothing else is competing for access to the port (using lsof etc)
I upgraded raspian to the latest - everything at the os level is up to date
I upgraded all node modules in node-red and did an npm rebuild. same for node red itself.
At one point I was seeing an identical looking problem with the the serial port thing that comes with node-red (I think it does anyway).  I installed several versions of node-red-node-serialport and found that the problem was gone after I installed 2.0.2.  When I say "identical" I mean "I got a message about failing to lock a port that was only correctable by restarting node-red" which went away after the nod-red-node-serialport upgrade
Looking at your stuff - it looks like you're bundling your own serial logic
I get a sense (I'm not a nodejs coder - I just plink around a bit) that there was some kind of breaking change that might be related directly or indirectly to what's going on with your serial logic.    I got rather deep into that such that at one point I was looking at some stuff about what looked like a google contribution to nodejs, but I can't seem to find it in my browser history - my apologies.  It was C++ stuff and they were talking about deprecating something for a couple of versions - and it looks like by nodejs 20 they had removed it.

I'm just guessing, but it seems like the issue might be sort of in one of these ballparks:

A lock that used to get released on deploy no longer gets released
A lock that is presumed to have been let go no longer needs to be treated as such

Versions:
PRETTY_NAME="Raspbian GNU/Linux 11 (bullseye)"
NAME="Raspbian GNU/Linux"
VERSION_ID="11"
VERSION="11 (bullseye)"

Linux nodered 6.1.21-v8+ #1642 SMP PREEMPT Mon Apr  3 17:24:16 BST 2023 aarch64 GNU/Linux

root@nodered:/usr/lib/node_modules# node --version
v20.5.1
root@nodered:/usr/lib/node_modules# npm ls
/usr/lib
├──<EMAIL_ADDRESS>extraneous
├──<EMAIL_ADDRESS>extraneous
└──<EMAIL_ADDRESS>extraneous

nodered@nodered:~/.node-red $ npm ls
<EMAIL_ADDRESS>/home/nodered/.node-red
├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>└──<EMAIL_ADDRESS>
How to reproduce?

Upgrade to latest raspian
Upgrade node-red to latest
Upgrade all node modules to latest
Modify a flow and deploy it

Version
9.0.3
Node-RED Version
3.1.3
What hardware are you seeing the problem on?
Raspberry Pi
Relevant Z-Wave-JS log as a text file
ZWaveError: Failed to open the serial port: Error Resource temporarily unavailable Cannot lock port (ZW0100)

@svdasein

Looking at your stuff - it looks like you're bundling your own serial logic

This package doesn't do anything with the serial port - other then list what's available on the system- it's all managed by the zwave-js library, that this module uses, and zwave-js is using the popular serialnode package for all serial interaction.

ZWaveError: Failed to open the serial port: Error Resource temporarily unavailable Cannot lock port (ZW0100)

Log file please to capture all events leading up to and including this event - you can enable logging in the Controller Node.
please don't edit the log file - just upload the file as is.
whilst I wait for the log file, I'll ping @AlCalzone, to see if he has any immediate input with any known issues with Node 20 and the serilaport package - But he is on parental leave currently  - so please allow some time
This module will bring down the driver (and in doing so, will release the serial port - see below) - so my guess is, this is an issue with serilaport and node 20 - its already been reported by another user -> https://github.com/serialport/node-serialport/issues/2735
https://github.com/zwave-js/node-red-contrib-zwave-js/blob/716eeb7347521dd2e4ba28077228a7843680bc26/zwave-js/zwave-js.js#L604

zwave-js.log

No known issues from my side, but the linked issue seems to be a reasonable explanation for the behavior. Does the node-red serialport plug in also use this library?

it does

Everything is being closed down according to log.
2023-12-10T20:32:19.536Z DRIVER   all queues idle
2023-12-10T20:32:26.757Z NDERED   [SHUTDOWN] [RESTART] Cleaning up...
2023-12-10T20:32:26.759Z DRIVER   destroying driver instance...
2023-12-10T20:32:26.901Z DRIVER   driver instance destroyed
2023-12-10T20:32:27.671Z NDERED   [options] [interview.queryAllUserCodes] Disabled
2023-12-10T20:32:27.672Z NDERED   [options] [disableOptimisticValueUpdate] Disabled
2023-12-10T20:32:27.672Z NDERED   [options] [enableSoftReset] Disabled
2023-12-10T20:32:27.672Z NDERED   [options] [storage.cacheDir] /home/nodered/.node-red/zwave-js-cache
2023-12-10T20:32:27.672Z NDERED   [options] [storage.throttle] normal
2023-12-10T20:32:27.672Z NDERED   [options] [preferences.scales.temperature] 0x00
2023-12-10T20:32:27.673Z NDERED   [options] [preferences.scales.humidity] 0x00
2023-12-10T20:32:27.673Z NDERED   [FWUS] Open source license applied
2023-12-10T20:32:27.673Z NDERED   Initializing driver...
2023-12-10T20:32:27.678Z NDERED   [TELEMETRY] Disabling...
2023-12-10T20:32:27.678Z NDERED   Starting driver...
2023-12-10T20:32:27.679Z DRIVER   ███████╗        ██╗    ██╗  █████╗  ██╗   ██╗ ███████╗          ██╗ ███████╗
                                  ╚══███╔╝        ██║    ██║ ██╔══██╗ ██║   ██║ ██╔════╝          ██║ ██╔════╝
                                    ███╔╝  █████╗ ██║ █╗ ██║ ███████║ ██║   ██║ █████╗            ██║ ███████╗
                                   ███╔╝   ╚════╝ ██║███╗██║ ██╔══██║ ╚██╗ ██╔╝ ██╔══╝       ██   ██║ ╚════██║
                                  ███████╗        ╚███╔███╔╝ ██║  ██║  ╚████╔╝  ███████╗     ╚█████╔╝ ███████║
                                  ╚══════╝         ╚══╝╚══╝  ╚═╝  ╚═╝   ╚═══╝   ╚══════╝      ╚════╝  ╚══════╝
2023-12-10T20:32:27.679Z DRIVER   version 12.4.0
2023-12-10T20:32:27.679Z DRIVER
2023-12-10T20:32:27.679Z DRIVER   starting driver...
2023-12-10T20:32:27.679Z DRIVER   opening serial port /dev/serial/by-id/usb-Silicon_Labs_CP2102N_USB_to_UART_Bri
                                  dge_Controller_a42420fe1da4eb118cc928259da30875-if00-port0
2023-12-10T20:32:37.031Z DRIVER   Failed to open the serial port: Error Resource temporarily unavailable Cannot
                                  lock port
2023-12-10T20:32:37.033Z DRIVER   destroying driver instance...
2023-12-10T20:32:37.034Z NDERED   [ERROR] [DRIVER] Failed to open the serial port: Error Resource temporarily un
                                  available Cannot lock port (ZW0100)
2023-12-10T20:32:37.037Z DRIVER   driver instance destroyed

It may be the case that whatever is wrong is something that was fixed by whoever maintains node-red-node-serialport - as I mentioned, when I upgraded that the problem with port locks that use that node went away.
├──<EMAIL_ADDRESS>fyi I actually walked the version of node-red-node-serialport upwards 'til the problem went away.  I believe 2.0.2 is the very latest version.

@svdasein
My suggestion is to downgrade to Node 18 for the time being (its still preferred for Node RED at this stage)
Or if you don't want to do that - Just only publish modified nodes - instead of a full deploy, to stop everything re-starting
Nothing in this module will be responsible for the error, as I believe it to be upstream somewhere.

@marcus-j-davies  - thanks - I will try that.

After a downgrade to node v18.17.1 the problem no longer occurs. Thanks for your help!


Auto scroll issue on FreeCodeCamp forum post

Describe the bug
When trying to read this forum post,
https://www.freecodecamp.org/forum/t/freecodecamp-algorithm-challenge-guide-sum-all-primes/16085
, it gets auto scrolled to
https://www.freecodecamp.org/forum/t/freecodecamp-algorithm-challenge-guide-sum-all-primes/16085/3 . I am unable to read that forum post because because web page auto scrolled upto a fixed position.
To Reproduce
Steps to reproduce the behavior:

Go to ' https://www.freecodecamp.org/forum/t/freecodecamp-algorithm-challenge-guide-sum-all-primes/16085 '
Scroll down to ' Hint 3 '
See error (it will auto scroll upto the position (see the screenshot))

Screenshots

Desktop (please complete the following information):

OS: Windows7
Browser: chrome
Version : newest

It looks like this an issue with the repl.it iframe added in oshliaer's comment.
The search field is getting focus on page load which is causing the page to scroll it into view. The behaviour can be replicated in this toy model: https://jsfiddle.net/up240m93/
Removing that comment or at least the iFrame should fix this if it is something that needs to be fixed.

This has been resolved.


Update introduction.md typo

One stop to one-stop

Appreciate this PR but closing it as we're going to stick with the "one stop" terminology for now!


texlab: 5.5.1 -> 5.6.0

Description of changes
Update to the latest version: https://github.com/latex-lsp/texlab/releases/tag/v5.6.0
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 233853 run on x86_64-linux 1

2 packages built:

texlab
texlab.man


feat: enforce strict rlp format for all packets

Purpose

How does the solution address the problem

Changes made

prnet cleaned-up successfully


tsserver CPU consumption goes too high on just typing

VSCode Version: 1.36 / insiders latest
OS Version: windows 10

There are a lot of issues that tsserver (probably issue refers more to tsserver than vscode) consumes a lot of CPU.
Just when I type on the almost empty file, is start to consume 40%-60% cpu (In process explorer I see that it is tsserver, not some other inner processes, besides if ts server disabled/restarting not problems with performance while typing).
I understand probably my PC is not the fastest one, and tsserver analyzes file on very change, but still, maybe tsserver/vscode teams still could think how to make such scenario work quicker?
Maybe introduce some debounce for type checking when typing or something like that.
Here is just demo on what i'm talking about. I tried on the latest insiders, and with all disabled extensions, the result is the same. Sometimes when I close all the editors and tabs it works quite ok (on small simple files).
I don't think that trace logs will help here, there is probably some quite basic and general issue with the approach of realtime type checking which shows itself on not very fast machines.

Is this causing any problems besides the cpu usage?

@mjbvz yes, external irritation and deep internal frustration

same happen at my old Macbook.
Especially when the file is hundreds of lines, it can be delayed by a few seconds.

@whitecolor What specific user problems are you seeing? For example: do suggestions take too long to show up?

@mjbvz yes everything regarding code is working slower, autocomplete and type checking (error reporting).

Can you please file issues upstream against typescript for specific cases where the cpu usage seems too high on typing
Closing this as an upstream issue


Added support for v1 DeleteTopicsRequest

Interestingly, support for DeleteTopicsResponse v1 was there but not for the request !

Thanks!


E2E: go schedule main SLSA3 config-ldflags-main-dir

Repo: https://github.com/ianlewis/example-package/tree/main
Run: https://github.com/ianlewis/example-package/actions/runs/2479581993
Workflow name: go schedule main SLSA3 config-ldflags-main-dir
Workflow file: https://github.com/ianlewis/example-package/tree/main/.github/workflows/e2e.go.schedule.main.config-ldflags-main-dir.slsa3.yml
Trigger: schedule
Branch: main
Date: Sat Jun 11 10:08:24 UTC 2022

Repo: https://github.com/slsa-framework/example-package/tree/main
Run: https://github.com/slsa-framework/example-package/actions/runs/2479610702
Workflow name: go schedule main SLSA3 config-ldflags-main-dir
Workflow file: https://github.com/slsa-framework/example-package/tree/main/.github/workflows/e2e.go.schedule.main.config-ldflags-main-dir.slsa3.yml
Trigger: schedule
Branch: main
Date: Sat Jun 11 10:21:48 UTC 2022
Tests are passing now. Closing this issue.


Disable the cancel button while deleting

Checklist

[x] I tested all changes and all related features with different users (student, tutor, instructor, admin) on the test server https://artemistest.ase.in.tum.de.
[x] Client: I followed the coding and design guidelines.
[x] Client: I added screenshots/screencasts of my UI changes

Motivation and Context
You could still click the Cancel button which would leave the modal but not actually cancel the delete action once it runs. The user had no feedback for the background tasks the system is performing.
Description
We disable the Cancel button while deleting. A spinner is displayed to indicate that the system is working in the background.
Steps for Testing
The component is re-used, so try to delete one entity, like an exercise, a test run, or an exam. Also test that the modal works when an error is thrown instead of deleting.
Screenshots
Notice the spinner and disabled buttons in the bottom right:

This appears to be the same on develop, so not a regression, and also limited to the quiz exercise. For text exercises it works as one would expect:

I'd defer fixing that for quizzes to a follow-up PR since it is not directly related to the changes here. (And also deleting an exercise twice is an edge use-case imo.)


Home/Meetings: Meeting listed twice

@reginafcompton On the Home page and Meetings page, Ad-Hoc Customer Experience Committee meeting is showing up twice.
I noticed this because I went to check whether the meeting was showing up as cancelled yet ... It was cancelled in Legistar earlier (I don't think it's been quite an hour, but just wanted to keep an eye on it to see when the update showed). So just FYI, whichever of the two meetings is supposed to be there is also supposed to be cancelled.

@shrayshray it's been about an hour: I'll manually remove this extra meeting.
This duplicate comes as a result of this issue, which we are still strategizing about: https://github.com/opencivicdata/pupa/issues/295

It's fixed: https://boardagendas.metro.net/events/


fix(tofs): use literal pillar (config) paths instead of tpldir

With nested .sls files, tpldir respectively resolves to:

systemd/networkd
systemd/resolved
systemd/timesyncd

Without this fix, only the default value provided is ever used, respectively:

['network']
['resolved.conf']
['timesyncd.conf']

@aboe76 In my defense, I did voice my concerns about #17 being merged too quickly without full testing.  In any case, this isn't a substantial bug since all it prevents is the extra configurability which no-one is using right now.
I've gone for this simplest fix but I really am considering whether we should use topdir in place of tpldir instead.  What's your take on that?

@aboe76 topdir as implemented in https://github.com/saltstack-formulas/template-formula/pull/49/files.

@myii you are right about this, but let's see if template-formula works, we have some more formula's with tofs pattern awaiting...


Histogram dataview is not submitting the bbox parameter

It looks like this line is not working properly and submitBBox is not being set to true after the first fetch.
I'll open a PR soon.

Closed by #1065.


Accessors needed for mbedtls_x509_crt in 3.0+

Suggested enhancement
I could not find any accessors for x509 certificates, in my project I use fields:

issuer
subject
valid_to - I need to check it against specific date in the future, not just current time, to be able to renew certificate well ahead its expiry time (all the fields in mbedtls_x509_time are also private)
pk - I need to use it with mbedtls_pk_encrypt to encrypt CSR
serial, issuer_raw - to serialize information about certificate used for encryption
raw - to embed the certificate
next - to traverse the certificate chain

Justification
I use those fields for certificate renewal using SCEP

https://github.com/ARMmbed/mbedtls/pull/4842 currently makes all the requested fields publicly readable except next.
I think it makes sense for next to be readable too. I don't remember why I didn't do that. I'll change my PR accordingly.


Implement Gradient slicing and exact size iteration

This adds some missing features to the Gradient type:

Implement ExactSizeIterator for Take.
Make it possible to slice Gradient, and thereby close #4.

I think I'll call this one done. There is more that can be done, but that will have to wait.

@homu r+

:pushpin: Commit a1c6b09 has been approved by Ogeon

:zap: Test exempted - status


Issue with poetry and editable dependencies

Hello,
I'm getting the following error when deploying an app with poetry that has an editable dependency on another local package
    ERROR: Complete output from command /var/lang/bin/python3.6 -c 'import setuptools, tokenize;__file__='"'"'/app/tintlib/setup.py'"'"';f=getattr(tokenize, '"'"'open'"'"', open)(__file__);code=f.read().replace('"'"'\r\n'"'"', '"'"'\n'"'"');f.close();exec(compile(code, __file__, '"'"'exec'"'"'))' develop --no-deps --home=/tmp/pip-target-dvzgxbfh:
    ERROR: usage: -c [global_opts] cmd1 [cmd1_opts] [cmd2 [cmd2_opts] ...]
       or: -c --help [cmd1 cmd2 ...]
       or: -c --help-commands
       or: -c cmd --help

    error: option --home not recognized

My current workaround is to set usePoetry: false in serverless.yml and do the following:
poetry export --without-hashes -f requirements.txt
sed 's/-e //g' requirements.txt > requirements2.txt
mv requirements2.txt requirements.txt
sls deploy

Thanks!

Likely will be fixed by #362

#390 is merged; happy to reopen if the bug is persisting.


Step-by-step adding a new model to CFU-Playground

Hi all,
I follow the steps in https://github.com/google/CFU-Playground/issues/221 to add a new model to CFU-Playground. I create my_model folder and I copy "model_name.tflite" to "CFU-Playground/common/src/models/my_model/"     directory. But it seems that I need to create the 2 files: "model_name.h" and "model_name.cc" and place them in this folder, because I could see 2 files: "mnv2.h" and "mnv2.cc" in  "CFU-Playground/common/src/models/mnv2/". Could you please tell me how to generate the 2 files. Should I write by hands? Or is there any tools to generate them automatically based on my model  "model_name.tflite"? Thank you.

Thank you @JosephBushagour.
So I am modifying the mnv2.cc of the mnv2 model. For the model inference, they used  "tflite_set_input_unsigned(input_00001_18027);" to set input data for the model. I could see the file input_00001_18027.dat in common/src/models/mnv2/. But I don't know how to generate the .dat file from an original image like "1.jpg". Could you show me how to set input for the model?

.dat files are converted directly into arrays of raw bytes at build time, see https://github.com/google/CFU-Playground/blob/main/common/Makefile#L175-L177. Whatever your model takes in as input can just be binary dumped to a corresponding .dat file.

@hoanggiamta  see my comments here: #495 . Also https://github.com/google/CFU-Playground/blob/demo/proj/demo/images.readme has an example of creating the raw data file from an arbitrary image file --- this was for pdti8 not mnv2 so the data format may be different as well as dimensions -- the data file must match the expected dimensions exactly.

Thank you, @JosephBushagour and @tcal-x. The issue was solved. The input image should be formatted as the same as for the the model running on host cpu.


Adding label endpoints

This PR adds all the label endpoints.
TODO

[x] https://developer.github.com/v3/issues/labels/#add-labels-to-an-issue
[x] https://developer.github.com/v3/issues/labels/#create-a-label
[x] https://developer.github.com/v3/issues/labels/#delete-a-label
[x] https://developer.github.com/v3/issues/labels/#get-a-single-label
[x] https://developer.github.com/v3/issues/labels/#list-all-labels-for-this-repository
[x] https://developer.github.com/v3/issues/labels/#list-labels-on-an-issue
[x] https://developer.github.com/v3/issues/labels/#remove-a-label-from-an-issue
[x] https://developer.github.com/v3/issues/labels/#remove-all-labels-from-an-issue
[x] https://developer.github.com/v3/issues/labels/#replace-all-labels-for-an-issue
[x] https://developer.github.com/v3/issues/labels/#update-a-label

Testing

[x] Unit tests for all endpoints
[x] End-to-end testing for all endpoints

@pengwynn: Do y'all have any interest in me adding end-to-end tests for the endpoints I'm adding that actually hit the API, and that are only run conditionally based on an environment variable?

@half-ogre Thanks for working through these. :sparkling_heart: Would have gotten back sooner, but I was off the grid. :tent:

Do y'all have any interest in me adding end-to-end tests for the endpoints I'm adding that actually hit the API, and that are only run conditionally based on an environment variable?

Not quite sure I follow. It looks like you've wired up tests with the same pattern the other methods use, right?

@pengwynn This PR is ready for review.

Not quite sure I follow. It looks like you've wired up tests with the same pattern the other methods use, right?

I was talking about adding acceptance tests in addition to the unit tests, that actually hit the live API, but the friction and amount of change this would add makes this not something to talk about in the context of this PR, even if you were interested. So, never mind. :)

:+1: looking forward to these changes

@half-ogre thanks for the patch! I saw some whitespace/alignment issues (maybe mix of tabs/spaces?). Once we fix those up this looks good. :+1:

I saw some whitespace/alignment issues (maybe mix of tabs/spaces?

My bad. I ran go fmt and all should be well now.

:cake:


Disable (temporarily) Visual C++ option /WX

Required to enable builds using MSVC until Catch is updated with the latest fixed version of Clara.
See https://github.com/philsquared/Catch/issues/637

Currently, Visual Studio/C++ users will observe build failures due to Clara warning treated as error:
c:\projects\nanodbc\catch\src\catch\include\external\clara.h(542): error C2220: warning treated as error - no 'object' file generated [C:\projects\nanodbc\test\mysql_tests.vcxproj]
c:\projects\nanodbc\catch\src\catch\include\external\clara.h(542): warning C4702: unreachable code [C:\projects\nanodbc\test\mysql_tests.vcxproj]
c:\projects\nanodbc\catch\src\catch\include\external\clara.h(542): warning C4702: unreachable code [C:\projects\nanodbc\test\mysql_tests.vcxproj

A few days ago Catch received the update: https://github.com/philsquared/Catch/commit/1c47fe023a1547e9a7a7e4efd163c098d69e38a4
So, the issue has been solved.


Fix bug in process_common_encryption client layer

Fixed here: https://github.com/rdkcentral/tasecureapi/pull/96


Es6 style promises

Angular 1.3.x introduced ES6 style promises. These often provide much cleaner / more concise code.
This commit provides a polyfill for that functionality that will use angulars implementation if available.
The second commit refactors some code to use the new promise style.

Coverage increased (+0.01%) when pulling a7c767ce1e540f522d928130f4115adbdaee4a5d on jamestalmage:es6-style-promises into a8c158529a0f34f10b996ee4c155800d1c3ac083 on firebase:master.

Coverage increased (+1.0%) when pulling abe2c95b1f5c8bafb8472a935a7e0dd0bbd2a3f5 on jamestalmage:es6-style-promises into a8c158529a0f34f10b996ee4c155800d1c3ac083 on firebase:master.

Few more comments then this is good to go :+1:

Okay, one more return needs to be added and I would prefer stylistically to put the returns on the same line as the resolve() / reject() calls (I don't think the undocumented return value is going to cause any issues). I wasn't going to block the PR on the latter, but I am on the former!

OK, One more argument and then I'll cave.
If poking around the source I see return methodIDontKnowReturnsNothing();, I'm almost certainly going to hunt down methodIDontKnowReturnsNothing(); to try and figure out what it returns, especially if I think the calling method should not be returning anything. In the case of unknownMethod(); return;, I have to expend zero effort to figure out what the actual return value is.
Tell me to inline them and I'll do it. Just picking nits.

Haha, no I'll let it slide this time just for you! I completely see where you are coming from and don't entirely disagree. I can't promise that I won't change it myself in the future though :)
You are definitely missing one return statement though. Once that is added, this thing will be in master.

done

Coverage increased (+1.01%) when pulling 293cbd494b60ef6a86599b0990b4a558d5102cac on jamestalmage:es6-style-promises into a8c158529a0f34f10b996ee4c155800d1c3ac083 on firebase:master.


Delete handwritten PubSub layer

You have no idea how happy this PR makes me

Changes Unknown when pulling 58928d15f1344eacb5b1860746fafb701a906daf on pongad:pubsub-rm into ** on GoogleCloudPlatform:pubsub-rm**.

Changes Unknown when pulling 3a559ccf39fc4e2a82d9f2f18e8acc0340f0f260 on pongad:pubsub-rm into ** on GoogleCloudPlatform:pubsub-rm**.

LGTM


Problems about the simulation model when robot is climbing stairs

Hi, I'm trying to let the robot climb stairs. But there is a problem of that the robot's lower legs always penetrate the inside of stairs. And when this problem occurs, the lower leg cannot get out of the stairs anymore, thus the robot can't continue to move normally. I want to know the reason of this matter and how to solve this problem? Thanks!

I also met this problem and I think it is because the 'stairs model' are composed of several 'box models' and there are small gaps between these boxes. When the robot steps into these gaps, the trouble occurs. My solution is using bounding gait and keeping a stable vel_cmd, then, try more times!

我也遇到了这个问题，我认为这是因为“楼梯模型”由多个“盒子模型”组成，并且这些盒子之间的间隙很小。当机器人跨入这些间隙时，就会出现故障。我的解决方案是使用包围步态并保持稳定的vel_cmd，然后尝试更多次！

Thank you for your recommend! Recently I tried to add a contact point which defined in the file quadruped.cpp at the foot. The new points are approximately on the surface of the foot. The effect is also good. You can try this method. I think the reason is that maybe there is a deviation between the length of the simulation model and the length of the parameters defined in the code.

I also met this problem and I think it is because the 'stairs model' are composed of several 'box models' and there are small gaps between these boxes. When the robot steps into these gaps, the trouble occurs. My solution is using bounding gait and keeping a stable vel_cmd, then, try more times!

Thank you for your recommend! Recently I tried to add a contact point which defined in the file quadruped.cpp at the foot. The new points are approximately on the surface of the foot. The effect is also good. You can try this method. I think the reason is that maybe there is a deviation between the length of the simulation model and the length of the parameters defined in the code.

The problem is due to the gap between the 'boxes' (because there is only one contact point on the foot). So, the simplest way to solve this problem is eliminate the 'gap'—let the boxes overlap. For example:
#myStairs box-1:     type: "box"     mu: 0.7     restitution: 0     depth: 0.5     width: 1.5     height: 0.15     position:  [0.95, 0, 0.025]     orientation: [0, 0, 0]     transparent: 0 box-2:     type: "box"     mu: 0.7     restitution: 0     depth: 0.6     width: 1.5     height: 0.2     position:  [1.5, 0, 0.1]     orientation: [0, 0, 0]     transparent: 0 box-3:     type: "box"     mu: 0.7     restitution: 0     depth: 0.6     width: 1.5     height: 0.3     position:  [2, 0, 0.15]     orientation: [0, 0, 0]     transparent: 0 box-4:     type: "box"     mu: 0.7     restitution: 0     depth: 0.6     width: 1.5     height: 0.4     position:  [2.5, 0, 0.2]     orientation: [0, 0, 0]     transparent: 0 box-5:     type: "box"     mu: 0.7     restitution: 0     depth: 1     width: 1.5     height: 0.5     position:  [3.2, 0, 0.25]     orientation: [0, 0, 0]     transparent: 0

@Yage0912 nice, thanks, i put this in default terrian, sim mini cheetah could "climb" first 2 boxes, then crash into 3rd one


Performance Issue with inflight_batcher_llm Model in v0.13.0

Description
I'm reporting a significant performance degradation when using the ensemble model in the inflight_batcher_llm provided in TensorRT-LLM Backend v0.13.0. During benchmarks in my environment, I observed that the performance dropped substantially.
After investigating, I found that the root cause of the issue lies within the postprocessing model in the ensemble, which is implemented in Python. Specifically, there is a performance bottleneck when calculating the tokenizer's vocabulary size on every execute() call.
https://github.com/triton-inference-server/tensorrtllm_backend/blob/f80395e67a464e229b6595acd8f9305b344a5d54/all_models/inflight_batcher_llm/postprocessing/1/model.py#L243
Before v0.13.0, this model used self.tokenizer.vocab_size to access the vocabulary size, which had no performance issues. However, starting from v0.13.0, this was changed to len(self.tokenizer.vocab). In the execute() method, the len(self.tokenizer.vocab) is called repeatedly, and this operation has been measured to take approximately 40ms per execution in my environment. This code returns a dictionary and calculates the length of this dictionary.
This issue becomes even more critical in streaming mode, where output tokens are generated one by one. In streaming scenarios, len(self.tokenizer.vocab) is called each time a token is generated, and the resulting overhead accumulates during the entire generation process. As more tokens are generated, the repeated invocation of it significantly slows down the model's performance.
Here is the simple Python code to measure the execution time of len(self.tokenizer.vocab):
from transformers import AutoTokenizer
import time

tokenizer = AutoTokenizer.from_pretrained(MODEL_PATH)
start = time.time()
vocab_size = len(tokenizer.vocab)
end = time.time()
print(f'elapsed time: {(end - start) * 1000:.5f} ms')
# print "elapsed time: 40.49420 ms" in my case

start = time.time()
vocab = tokenizer.vocab
end = time.time()
print(f'elapsed time: {(end - start) * 1000:.5f} ms / id: {id(vocab)}')
# print "elapsed time: 37.93049 ms / id:<PHONE_NUMBER>41888"
start = time.time()
vocab = tokenizer.vocab
end = time.time()
print(f'elapsed time: {(end - start) * 1000:.5f} ms / id: {id(vocab)}')
# print "elapsed time: 40.11583 ms / id:<PHONE_NUMBER>41824"

start = time.time()
vocab_size = len(vocab)
end = time.time()
print(f'elapsed time: {(end - start) * 1000:.5f} ms')
# print "elapsed time: 0.00095 ms"

Every call tokenizer.vocab creates a new dictionary object, which causing noticeable performance overhead.
Proposed Solution:
This issue can be addressed simply by pre-computing the total_vocal_size during initialize call, and reusing this pre-computed value in subsequent execute calls. After making this modification, the benchmark results returned to normal performance levels.
class TritonPythonModel:
    ...
    def initialize(self, args):
        ...
        self.total_vocab_size = len(self.tokenizer.vocab)

    ...
    def _postprocessing(self, tokens_batch, sequence_lengths):
        ...
                    if tokens[i] < self.total_vocab_size:
                        ...
        ...

Who can help?
@kaiyux @byshiue @schetlur-nv

Unfortunately, even version 0.14 has the same problem

Looks like it is fixed by a new commit in main

Could this be the reason why I am seeing very slow performance serving a tensorrt-llm model with the backend using the ensemble model compared to benchmarks for a similar model deployed with NIM?

I am using the 24.11-trtllm-python-py3 image

@frosk1 can you share some more details of what you are running - like your build and run commands? There could be multiple factors at play here.
This bug should be fixed in that container you point to.

I will add a new issue for it

here:
https://github.com/triton-inference-server/tensorrtllm_backend/issues/667


Update list of tokens supported on fiat-onramp feature

Describe the task
Update list of tokens supported on fiat-onramp feature

result.zip
List tokens update

Version test: https://file.cdmteck.com/s/4oimk9zDJ8R5Aai/download?path=%2F&files=./upgrade-ui-pr-1887-build-1.1.10-2023-09-08T08-08-56UTC.zip
Please check:

[ ] Incorrect token when buying a token with Transak

NEAR

XRP

Re-check BUSD (Binance smart chain)

Version test: https://file.cdmteck.com/s/4oimk9zDJ8R5Aai/download?path=%2F&files=./upgrade-ui-pr-1887-build-1.1.10-2023-09-09T05-14-00UTC.zip
Validation passed

compact.csv
Final token list


Develop/features/td 2899 add automated accessibility unit testing project

https://hee-tis.atlassian.net/browse/TD-2899
Description
Add an automated accessibility unit testing project to the LH web UI repository.
Screenshots
Attach screenshots on mobile, tablet and desktop.

Developer checks
(Leave tasks unticked if they haven't been appropriate for your ticket.)
I have:

[ ] Run the formatter and made sure there are no IDE errors
[ ] Written appropriate unit tests for the changes, including:

accessibility tests for new views
tests for new controller methods
tests for new or modified API endpoints

[ ] Manually tested my work with and without JavaScript
[ ] Tested any Views or partials created or changed with Wave Chrome plugin and addressed any valid accessibility issues
[ ] Updated/added documentation in Confluence and/or GitHub Readme. List of documentation links added/changed:

doc_1_here

[ ] Updated my Jira ticket with information about other parts of the system that were touched as part of the MR and have to be sanity tested to ensure nothing is broken
[ ] Scanned over my pull request in GitHub and addressed any warnings from the GitHub Build and Test checks.

There are some conflicts, so better create a new branch and create PR


Update Composer dependencies (2021-08-31-00-11)

Visual regression test passed!
View the visual regression test report


fix: ensuring useQuery immediately returns results from cache, to prevent hydration errors

closes https://github.com/vuejs/apollo/issues/1432

Thanks! I've reverted the PR that introduced the issue
https://github.com/vuejs/apollo/commit/9302d4d4a55541bb49292463d8176d0527c06ce9


Disclosure triangles to view contents of folders in Details View

What's the Problem?
Unable to view contents of multiple folders in same window.
Solution/Idea
Windows file browser apps limit user to view only contents of inside one folder. More often than not I need to view the contents of more than one folder in details view and i need to see the folder size of each...maybe im working on a design with a superseded revisions folder inside it, i need to see all the files in the root folder as well as any sub folders. macOS been doing this for 30 years..
Alternatives
M$'s bright idea is treeview in a sidebar which is causing the user to constantly resize the horizontal width of the sidebar to make the sub folders visible...this is a legacy M$ early 1990's concept, it never worked well then and its not helping users now.
Still you can't view the same column details for sub folder...basically its useless...macOS Finder shits all over M$'s File browser API's, and its the reason all 3rd party attempts have the same basic configuration limitations, maybe new Windows App Platform has a modernised toolset for 3rd parties?
see macOS Finder screenshots, its List View (what windows calls Details view-but their list view is redundant because its uselessly void of any valuable data-ie Details View in Windows should be renamed List view and then remove details view)
notice this list view is one window with selectable columns which are displayed for any sub folders...even folder size is displayed:

Priorities

Capability
Priority

This proposal will allow developers to accomplish W
Must

This proposal will allow end users to accomplish X
Should

This proposal will allow developers to accomplish Y
Could

This proposal will allow end users to accomplish Z
Won't

Files Version
v1.5
Windows Version
Windows 11 Pro 21H2 22000.194
Additional comment
No response

Merging with #1928


Integer overflow?

Large INTEGER columns seem to overflow, showing negative number instead of the real value
sqlite> .schema user
CREATE TABLE USER (
id INTEGER PRIMARY KEY AUTOINCREMENT,
createdAt INTEGER NOT NULL,
  ...

Pulling the .db manually and querying
sqlite> select createdAt from user where id=112;
createdAt
1480519860000

DebugDB shows that same cell with value -1243857120

Thanks for pointing the issue, I will go through it and fix it.
Thanks
Amit Shekhar

Fixed


Builders should act like they are panicking when shutting down

The builders use logrus.Fatal every time they shutdown. This produces a false-positive for issues.
It would be better if a stack-trace wasn't produced on a graceful shutdown to avoid this confusion.

The easiest way I found to test this is the following:

Run runtime locally with acorn install.
Run a build so that the buildkitd deployment is created.
In two separate terminals watch the logs of both containers in the pod: kubectl -n acorn-image-system logs buildkitd-7cd9fd44c6-wwgxc -f and kubectl -n acorn-image-system logs buildkitd-7cd9fd44c6-wwgxc -c service -f
In another terminal, restart the deployment: kubectl -n acorn-image-system rollout restart deployment buildkitd

Once the fix is in, there should be no stack traces printed when the containers exit.

Able to reproduce the issue on seeing stack traces printed in the logs when testing with acorn version v0.8.0-rc4-27-g20d5e79e+20d5e79e by following the steps mentioned in the issues.
Tested with acorn version v0.8.0-rc4-29-g6a019fe7+6a019fe7
When following the same steps mentioned in the issue , there is no stack traces printed in the logs.
Following are the logs that were printed when attempting kubectl -n acorn-image-system rollout restart deployment buildkitd
kubectl -n acorn-image-system logs buildkitd-686c95c556-p27f6 -f
time="2023-08-17T17:50:34Z" level=info msg="stopping server"
buildkitd: context canceled
rpc error: code = NotFound desc = an error occurred when try to find container "402a5b067b4b4bbce4f76e0aeb7103136b9a1e7170955d8a80d0d547f39a618a": not found%

kubectl -n acorn-image-system logs buildkitd-686c95c556-p27f6 -c service -f
time="2023-08-17T17:50:34Z" level=fatal msg="accept tcp [::]:5000: use of closed network connection"
rpc error: code = NotFound desc = an error occurred when try to find container "4da741bf1818c18ca92d779583dd39b76f07bd12c5ec4f11de85f6766702a5a7": not found%


Something went wrong

I keep getting 'something went wrong' when using the website https://payload-wizard.vercel.app/ aftyer entering my API key. No matter how simple of a payloadf  I ask it to generate something, even the example it just says 'something went wrong' I've created an API key with full permissions as well.

She takes long to respond, we all dont know why?

Same error here

You must have a paid subscription and generate your API key for this to work. There is nothing wrong with the code. It works as intended.
https://openai.com/api/pricing/
https://platform.openai.com/docs/api-reference/authentication
depending on what you want to achieve you can modify the code to point to the model you want to use.
/PH


Netbox webhook does not work on zone update event

netbox-dns itseft in netbox gui is working fine. I have set up on DNS zone update webhook to trigger custom script, and script fails with following error:
Traceback (most recent call last):
  File "/opt/netbox/venv/lib/python3.9/site-packages/django/apps/registry.py", line 158, in get_app_config
    return self.app_configs[app_label]
KeyError: 'netbox_dns'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/opt/netbox/venv/lib/python3.9/site-packages/rq/job.py", line 417, in _deserialize_data
    self._func_name, self._instance, self._args, self._kwargs = self.serializer.loads(self.data)
  File "/opt/netbox/venv/lib/python3.9/site-packages/django/db/models/base.py", line 2477, in model_unpickle
    model = apps.get_model(*model_id)
  File "/opt/netbox/venv/lib/python3.9/site-packages/django/apps/registry.py", line 208, in get_model
    app_config = self.get_app_config(app_label)
  File "/opt/netbox/venv/lib/python3.9/site-packages/django/apps/registry.py", line 165, in get_app_config
    raise LookupError(message)
LookupError: No installed app with label 'netbox_dns'.

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "/opt/netbox/venv/lib/python3.9/site-packages/rq/worker.py", line 1353, in perform_job
    self.prepare_job_execution(job)
  File "/opt/netbox/venv/lib/python3.9/site-packages/rq/worker.py", line 1203, in prepare_job_execution
    self.procline(msg.format(job.func_name, job.origin, time.time()))
  File "/opt/netbox/venv/lib/python3.9/site-packages/rq/job.py", line 451, in func_name
    self._deserialize_data()
  File "/opt/netbox/venv/lib/python3.9/site-packages/rq/job.py", line 419, in _deserialize_data
    raise DeserializationError() from e
rq.exceptions.DeserializationError

I am not sure if this is netbox-dns or netbox itseft problem?

I am not sure if this is netbox-dns or netbox itseft problem?

Neither am I ... can you provide some minimal sample code that triggers the problem?
It would also be very helpful to know the versions of the software involved, particularly NetBox and NetBox DNS, and the configuration.

Thank you for your reply peteeckel.
Netbox version: 3.4.7
netbox-dns: 0.17.0
I use netbox custom script to execute ansible netbooks. This script works when triggered on dcim devices update event or  virtualization virtual-machines update event. However on netbox_dns zone update event script fail. In all cases webhook is almost identical with exception of could variables values in webhook body template.
Netbox custom script:
from utilities.exceptions import AbortScript
import os
import json
import tempfile
import subprocess
import re
import sys
import ansible_runner
import socket

class universal(Script):
    class Meta:
       name = "ansible-runner"
       description = "Executes ansible playbooks"
       job_timeout = 900

    hosts_limit = StringVar(max_length=20, label="Hosts limit", required=True)
    playbook = StringVar(max_length=200, label="Playbook", required=True)
    pg_timeout = IntegerVar(default=300, label="Postgres timeout in sec", required=True)
    verbosity = IntegerVar(default=1, label="Ansible-playbook verbosity", required=True)
    quiet = BooleanVar(default='true', label="Playbook quiet mode", required=True)
    netbox_event = StringVar(max_length=200, label="Netbox event", required=False)
    ansible_extra_vars = StringVar(max_length=200, label="Ansible extra vars", required=False)

    def run(self, data, commit):

        os.environ['PGOPTIONS'] = '-c statement_timeout='+ str(data['pg_timeout'])
        playbook_path = "/var/lib/ansible/linux_state"
        envvars = {
            'ANSIBLE_CONFIG': playbook_path + '/ansible.cfg',
            'ANSIBLE_HOST_KEY_CHECKING': 'False',
            'ANSIBLE_DISPLAY_SKIPPED_HOSTS': 'False'
        }
        playbook = data['playbook']
        hosts_limit = data['hosts_limit']
        verbosity = data['verbosity']
        quiet = data['quiet']
        if 'netbox_event' in data:
            netbox_event = data['netbox_event']
        else:
            netbox_event = ''
        if 'ansible_extra_vars' in data:
            ansible_extra_vars = data['ansible_extra_vars']
        else:
            ansible_extra_vars = ''
        kwargs = {
            'playbook': playbook_path +'/'+ playbook,
            'limit': hosts_limit,
            'envvars': envvars,
            'private_data_dir': '/tmp',
            'verbosity': verbosity,
            'cmdline': '--user awx --extra-vars '+ansible_extra_vars,
            'quiet': 'true'
        }

        hostname = socket.gethostname()
        self.log_info(f"Node {hostname}: Executing playbook {playbook} for target {hosts_limit}")
        result = ansible_runner.run(**kwargs)
        stdout = result.stdout.read()
        stats = result.stats
        stats = json.dumps(stats, indent=4)
        events = list(result.events)
        if result.rc != 0:
          self.log_failure(f"Node {hostname}: Playbook {playbook} failed for target {hosts_limit}")
          self.log_failure(f"{stdout}")
          sys.tracebacklimit = 0
          raise AbortScript("Script failed because of failed playbook")
        else:
          self.log_success(f"Node {hostname}: Playbook {playbook} finished successfully for target {hosts_limit}")
        return (stdout)

Well, this is not exactly what I meant when I wrote 'minimal' (neither is it correct or complete, by the way) ... never mind. I actually wanted to reproduce your problem, but since I'm a bit short on time lately I'll resort to guessing.
Did you restart netbox-rq after installing NetBox DNS and modifying configuration.py, or just netbox? The webhook is executed by netbox-rq, and the error message seems to indicate that that process does not know about NetBox DNS.
If the answer is 'no' it's probably a NetBox issue.

OK, I've checked it with your versions. Maybe I'm too curious. This is minimal:
Create a test script
Since your script doesn't actually use any data or models related to NetBox DNS or NetBox, it's safe to replace it with a stripped-down version:
from extras.scripts import Script

class test(Script):
    class Meta:
       name = "Test"
       description = "Simple test script"

    def run(self, data, commit):
        self.log_success('Script ran successfully')

Create a webhook
The definition of the webhook is slightly more involved:
    {
      "id": 1,
      "url": "http://<IP_ADDRESS>/api/extras/webhooks/1/",
      "display": "Update Zone",
      "content_types": [
        "netbox_dns.zone"
      ],
      "name": "Update Zone",
      "type_update": true,
      "payload_url": "https://<IP_ADDRESS>/api/extras/scripts/webhook.test/",
      "enabled": true,
      "http_method": "POST",
      "http_content_type": "application/json",
      "additional_headers": "Authorization: Token d4e691e868a3ac253b27efe33f05c807c5761ce3",
      "body_template": "{\r\n    \"data\": {},\r\n    \"commit\": true\r\n}",
      "secret": "",
      "conditions": null,
      "ssl_verification": false,
      "ca_file_path": null,
    }

Update the zone (creating a record does the trick)
In the log tab for the custom script I can see that the script was executed successfully. So neither NetBox nor NetBox DNS is the problem, but probably the missing restart of the rqworker (or you left out some other piece of information).

By the way, running an Ansible Playbook on every zone update might get you into surprisingly big trouble with performance issues ... zone updates are rather frequent, especially for bulk operations on records, so I'd resort to a two-staged approach: e.g. each zone update sets a flag and resets a timer to a certain interval, say 10 seconds, and only when the timer expires the playbook is actually triggered.
While rndc is quite fast, Ansible certainly is not.

Your assumption was correct, I forgot to restart rqworker. And you are correct about my netbox custom script, it should not contain substring --extra-vars '+ansible_extra_vars. Ansible is slow, but it cover my lack of python knowledge. You idea with time delay is good, I will try it.
I really appreciate your time peteeckel and sorry for my mistake.

Hi @kemeris2000, glad I could help!


Allow per-job path override for clusterloader2 results dir

Some jobs may have layout that is placing results below root artifacts dir.

Please rebase
/ok-to-test
Could you provide a sample prow config of cl2 job that outputs results below root artifacts dir?
What is the reason for that? Cannot you change the config to have CL2 results in /artifacts dir?

Could you provide a sample prow config of cl2 job that outputs results below root artifacts dir?
What is the reason for that? Cannot you change the config to have CL2 results in /artifacts dir?

Don't have OSS example for that, but essentially that's a non-kubetest job that runs clusterloader2, providing --report-dir that's under ARTIFACTS to logically isolate cl2 output from anything else. It is possible to modify it to put it to root dir, though it would be neat to keep that grouping and make perfdash to be able to see past results.
One hypotetical extension of this use case I could see is multiple clusterloader2 runs per job (let say with different parameters), with multiple perfDashArtifactsDir per job specified.

Rebased, thanks!

/lgtm


READY Update simnet tests to v5

This PR updates simnet tests to v5 version.
After discussion with @TriplEight  I edited this PR to update to simnet v5.
trigger_pipeline.sh was copied  from  https://github.com/paritytech/polkadot/blob/master/scripts/gitlab/trigger_pipeline.sh
and adapted.
We reviewed together https://github.com/paritytech/polkadot/blob/master/scripts/gitlab/trigger_pipeline.sh
last week
Pipeline is green.
https://gitlab.parity.io/parity/substrate/-/pipelines/141040

No major CI changes, LGTM.

bot merge


Fix for boost 1.70 (get_io_service() was deprecated and was removed)

get_io_service() was removed in Boost 1.70.
I made a pull request using the alternative get_executor().context()

I forgot to keep compatibility with older ASIO versions. Now the pull request should be ok.


iCloud articles will not sync/pull in new articles.

On my iPhone since transferring from previous iPhone, articles that are in iCloud will not sync on my iPhone only. Those same articles will sync on all of my other iOS and macOS devices. I’ve attempted to remove the feeds and Re-add them manually. I’ve attempted to nuke everything on all my devices and force a sync but the sync on the iPhone hangs while other devices will pull in articles.

This is a known issue — here’s a page about it: https://netnewswire.com/help/iCloud

I ended up having to nuke the data in iCloud as I have already done the “Leave it open all night” thing. I had also previously deleted all feeds in iCloud and re-added them and the iPhone still would not sync. So nuking the data in iCloud seems to be the resolution. Thank you!

On Mar 30, 2023, at 1:44 PM, Brent Simmons @.***> wrote:
This is a known issue — here’s a page about it: https://netnewswire.com/help/iCloud
—
Reply to this email directly, view it on GitHub https://github.com/Ranchero-Software/NetNewsWire/issues/3930#issuecomment-1490688081, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGBZHAKTZJUIAJOEC52JZ2DW6XA7XANCNFSM6AAAAAAWNQKHKA.
You are receiving this because you authored the thread.


'Azure AI Search' name change

Renaming 'Azure Cognitive Search' to 'Azure AI Search'

@chuwik These edits look great, but I think we decided to not touch this repo until Farzad is done with his ignite demos (late Thursday or Friday).

Thanks for the heads up! I'll just leave it open, @farzad528 you can approve and merge when ready :)


Write method to prepare data for the burndown chart

Write a method to prepare data for plotting with graphing library (most likely to be Seaborn). Could be get_context_data method if #48 is implemented as a class-based view.

Issue closed due to change from matplot lib to ChartJS


Need authenticator app to set up authenticator app

The reason for me landing on this page is because I am trying to set up the authenticator app. However, the app wants me to perform a two-step verification before I can add my account. And the two-step verification wants me to use the authenticator app which I am trying to set up.  And I have no idea how to get out.
Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 5699f56d-758d-e3c2-cd44-571f9364dfef
Version Independent ID: 91ec729c-9ffd-a705-c03f-3608e01ce83a
Content: Add a work or school account to the Microsoft Authenticator app - Azure AD
Content Source: articles/active-directory/user-help/user-help-auth-app-add-work-school-account.md
Service: active-directory
Sub-service: user-help
GitHub Login: @curtand
Microsoft Alias: curtand

@mavusi Thank you for your query. We will investigate and update the thread further.

@mavusi I assume you are using School or work account. It asks for two-step verification generally for Microsoft accounts. also if you are using a work or school account rather than a MSA it will ask you for the first time to verify the code for the first time setup . but after that it works without any issue. I am not sure why you are in a cycle with the same. I would request you to email us on azcommunity[at]microsoft[dot]com referencing this Issue and providing your azure subscription ID and we will help you with alternate support options on this.
Thank you.


readme update

📚 Documentation
update all files readme
https://github.com/TesseractCoding/NeoAlgo/tree/master/Python
Have you read the Contributing Guidelines on Pull Requests?
yes

i want to update all these readme
in total there are 10 files


Add adw.StatusPage widget

https://gnome.pages.gitlab.gnome.org/libadwaita/doc/main/class.StatusPage.html

Usually the docs say since: 1.2 (see e.g. here: https://gnome.pages.gitlab.gnome.org/libadwaita/doc/main/class.Breakpoint.html - although that is since 1.4). The CI should fail anyways if the widget is only available since 1.2, but you did not put it inside a adwaita12 block.

So do we distinguish only between 1.0 and 1.2 or should the instruction be "If you see it a since 1.X block, put your code behind a when defined (adwaita1X) block?"

If a new feature is only available after 1.X, it should be in a when defined (adwaita1X) block, this case just did not come up yet.

This likely will end up in a separate issue:
Could it make sense to refactor the adwaita bits of the library to use a flag -d:adwaita=12 instead of -d:adwaita12 ?
This way you could easily implement logic that allows you to compile with -d:adwaita=14 and because 14 > 12 all when-statements requiring adwaita 1.2 will be there.
Something like:
const adwTargetVersion {.intdefine: "adwaita".}: int = 10 ## The version of adwaita 1.0

template minAdwaitaVersion(minVersion: int, body: untyped)=
  when adwTargetVersion >= minVersion:
    body

Useage example (compile with -d:adwaita=14 or any value larger than 12 really):
const adwTargetVersion {.intdefine: "adwaita".}: int = 10

template minAdwaitaVersion(minVersion: int, body: untyped)=
  when adwTargetVersion >= minVersion:
    body

minAdwaitaVersion(12):
  echo "The adwaita version was larger than 12: ", adwTargetVersion

Although I think we shouldn't use a template for the comparisons, but rather just use a regular when statement. It might also be nice to split the version into a tuple: (majorVersion, minorVersion).

Kinda like nim does it with NimMajor and NimMinor: AdwMajor and AdwMinor defined by default as 1 and 0.

I suggest moving further discussions about this to #96

Okay I've got this one down so far I think, will post PR the once #94 is merged.


Work around a strange space leak in PBFT.ChainState

Includes a workaround for #1356.
Additionally, squash all thunks introduced in the last month(s), so that the tests pass again when the checktvarinvariant flag is enabled for the io-sim-classes package. This boils down to replacing tuples with records with strict fields and forcing the elements of non-empty list to WHNF.

bors r+

We need a nightly run with the whnf checks enabled.

See #1047.

Haha. That flag should sound an alarm if not used with a reasonable
combination of -dsuppress-*.
On Mon, Dec 16, 2019 at 7:27 AM mrBliss<EMAIL_ADDRESS>wrote:

@mrBliss commented on this pull request.
In ouroboros-consensus/src/Ouroboros/Consensus/Protocol/PBFT/ChainState.hs
https://github.com/input-output-hk/ouroboros-network/pull/1357#discussion_r358295949
:

 PBftChainState {

     preAnchor  = preAnchor'

   , postAnchor = postAnchor'

   , preWindow  = preWindow'

   , inWindow   = inWindow'

   , counts     = updateCounts counts

 , ebbs       = ebbs   -- NB this needs to be pruned

   -- NOTE: 'pruneEBBsLT' is inlined here to avoid a strange space leak

   -- that also goes away with @-O0@, see #1356.

 , ebbs       = EbbMap $ Map.filter (>= anchorSlot') (unEbbMap ebbs)

Noted! I had a look this morning, but the GHC Core (-ddump-simpl) version
of append was ~1400 lines, so I quickly gave up 😅
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
https://github.com/input-output-hk/ouroboros-network/pull/1357?email_source=notifications&email_token=AAIOBUYHUWNXSFOFUN4T6ATQY6M65A5CNFSM4J3KHRJKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCPJ5I3Q#discussion_r358295949,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAIOBU6MYOFFSD4SQIHHHWLQY6M65ANCNFSM4J3KHRJA
.

Great work!
With this fix merged I think it is a good idea to update cardano-node's deps.

With this fix merged I think it is a good idea to update cardano-node's deps.

After #1360 :grin:


Allowing pyOpenSSL import to fail for GAE.

Fixes #1445.

@dhermes ping me when you're ready for review.

I am "ready" for review. The AppVeyor fail is noted in #1434
IMO, the coverage drop just needs a pragma no cover. WDYT?

I think it'd be nice to see a test case for this, if possible.

@jonparrott I have previously implemented tests that mock import failures and the pay-off does not justify the amount that goes in.
Maybe there is a better way and I just don't know how to do it?

I guess I more want to ensure that _get_pem_key and _get_signature_bytes raises a more useful error than an AttributeError if crypto is not available.

OK cool I can add that feature and test for it.

@jonparrott PTAL. (Also remind me to squash to commits before merging.)

LGTM with minor nits. You can squash commits if you want, but I don't see an issue with these being separate commits.

@jonparrott PTAL

Good to go with the tiniest little nit. Feel free to merge once that's fixed and travis is happy.


Add unit tests and bug fixes in existing files

 Routes should be specified inside route classes, not controller.

It has been resolved. Moved routes to route configuration files


[Bug] RenderDoc crashes at rdcstr when glGetString(eGL_EXTENSIONS) returns null

Description

I've encoutered a nullptr error when loading RenderDoc for a version of Unity with opengles3.2 api on windows.
It happens when RenderDoc tries to get enabled extensions, I think RenderDoc should handle fail cases explicity instead of crashing the application:
As winapi glgetstring stated:

The crashe happens at here:

where the copy constructor does not check if 'in' pointer is null. Thus crashing at strlen as it does not accept a nullptr.

Steps to reproduce

N/A
Environment

RenderDoc version: 1.21 (c4b4c528a3d19af735009bb286b9455b38d3a6dd)
Operating System: win x64
Graphics API: opengl es 3.2

Hi there, your issue has been closed due to not correctly following the issue template. Please read the documentation about filing issues and open a new issue which does follow the issue template. Do not reply to this issue with more information or with a correctly formatted issue, as that will only lead to confusion.
I try to address all github issues and fix bugs quickly, but badly formatted issues or poorly described bug reports especially are a significant drain on project resources. Taking a few minutes to file a good issue makes a huge difference and will get it addressed faster - everybody wins!
In github when you first create a new issue the form is pre-populated with a template which you should read over and follow. As linked above there is documentation going into more detail about what makes a good issue.

@baldurk Please do not close thie bug report.
I found it is a bug long found in GLEW, best described here. I've just print the error code and can confirm that glGetString(eGL_EXTENSIONS) returns error code GL_INVALID_ENUM.
This bug will persists if glGetStringi is null (where RenderDoc fallback to glGetString) which could be bad.

Please open a new bug report and correctly fill out the issue template as requested above, specifically including steps I can follow to reproduce the problem - such as your program or any demo project that shows the problem.


Bugfix(fmt): Fix comment spacing in block and comments in lists

Fixes #2410. This also fixes some behavior within empty lists and comment spacing after parentheses. Lastly this requires that postfix comments must either follow a postfix comment or a piece of code. This simplifies somewhat the logic for postfix/prefix comment distinction

good to merge @jpopesculian ?

good to merge @jpopesculian ?

sorry just saw the comment! ill fix it up tonight


bump version to 3.0.dev0

Bump the master version to 3.0.dev0 :tada:
Note that, the version isn't 3.0dev0 nor 3.0.0dev0 not even 3.0.0.dev0.
Patch versions don't appear on master, those are for X.X.x branches. The master branch is reserved for major and minor versions (and cycling dev appropriately, not that we ever have)
Also it's 3.0.dev0 instead of 3.0dev0 otherwise setuptools complains with:
setuptools/dist.py:472: UserWarning: Normalizing '3.0dev0' to '3.0.dev0'

Thanks for the clear explanation @bjlittle !


Enable import of customised hierarchy without deleting the "damage" markers.

Enable import of a customised hierarchy without deleting/invalidating the "damage" markers. The "damage" markers will only be used to mark up areas with tissue damage or artifacts such as air bubbles and so are not invalidated by changes to the hierarchy. This feature would be very useful for quality control of the tissue.

Importing hierarchy in v0.7 does not modify existing markup from now.


Improvements for Module aggregation / define module dependencies. #183

Module aggregation / define module dependencies. #183

I add BQModule id() method to BQModuleProvider in order to fix issue with identifying different instances of same module class:
// TODO: looking up modules by java type limits the use of lambdas as modules. E.g. we loaded test
// properties are dynamically created modules in a repeatedly called Lambda. This didn't work..
// So perhaps use provider name as a unique key?

So it helps to merge BQModuleProviders that come from dependency graph, auto-loading and bootique builder (Bootique.app().module(...)).
https://github.com/bootique/bootique/pull/204/files#diff-fc75fb4411338de93aeb75a2d4934914R77

Also this PR breaks backward compatibility of BQModuleProvider since:

Requires new method BQModuleId id() to implement;
Changes signature of dependencies method.

There are still issues with this PR:

Should update docs according this changes;
Should update CHANGELOG.md.

But let's discuss this solution first, and if you ok with this solution - I'll fix this gap.

I did some research in the last few days, and posted my thoughts on the Bootique forum. I think our current solution in general (not just this pull request) should be superseded by Java module-info.java.


[Idea] Binary compatibility check

Binary compatibility is important for Scala libs and currently everyone is doing their own setup. I think this plugin can provide a good default to help catch unexpected breakages. By making version number representative of binary compatibility, day-to-day life will be much nicer for a Scala dev (e.g. by using https://www.scala-lang.org/2019/10/17/dependency-management.html)
There are two approaches:

Restrictive: Enforce that binary compatibility is never broken - This is the approach taken by cats since they don't want to break compatibility in most cases
Permissive: Inform the library author in CI that binary compatibility has been broken. This is the approach taken by https://github.com/mdsol/sbt-smartrelease and works well for libraries that aren't heavily dependent on. (But a good versioning scheme will still help your users catch binary incompatible versions)

We can implement both and the user can choose what makes senes for their library. WDYT?

Thank you for reporting! I believe that MiMa is the is best way to enforce binary compatibility. I’m not sure how much this plugin can help improve the situation besides automatically adding a dependency on sbt-mima 🤔

I created sbt-mima-version-check for this reason.

@ChristopherDavenport thank you for sharing! I believe binary compatibility checking is outside the scope of this project. I'm happy to merge a PR adding a note/link under the FAQ section recommending an sbt plugin like sbt-mima-version-check to verify binary compatibility between releases.


Swift 4 Cocoapods release

Using Cocoapods we get some Swift 4 compiler errors should seems to be fix on master.
Could we have a new release to have these issues fixed? Thanks.

Version 1.2.0 just released to supports Swift 4!


React Flounder issues

Right now the dist file of React-Flounder contains React and React-Dom itself and is kinda huge.
My suggestion is to split Flounder to flounder-core and flounder-react, (maybe the same should happen for jquery etc)
and in case of react and react-dom move it from devDependencies to peerDepedencies. React-Flounder will have Core-Flounder as dependency.
Having separate repos for React (and the other frameworks) will make things much simpler, we will be able to:
-Use Flounder as dependency in our projects easier without having to include the huge dist file or using the src.
-Install it npm i without installing unrelated dependencies e.g. jQuery in our react Projects.
-Write tests for Flounder  (e.g.with Enzyme that we are using in the internal projects) since right now the tests are only for the core.
-And without being 100% sure but I think also build tools that support tree-shaking like Webpack and Rollup can take advantage of this structure to not include in the build, parts of Flounder core that are not used.
-Moving flounder-core to different repo/project will make it easier to write framework-specific wrappers by us or by the community, e.g. Angular, Cycle etc

@avraam-mavridis-sociomantic you definitely are making a good case here. I am 100% in favor though I will admit you are much more involved in the details than I so I can't pretend to play Devil's Advocate anyway.
As for Tsunami repos... is it fine that these two repos just live side by side in Tsunami Org? They don't require their own "parent", correct?
Question may seem silly but if you're saying "correct" then I am fine to assist in the creation / split of the current Flounder repo into two more specific ones.
@mousemke are you having a stance on this?

Founder/repo is the classic way to do it, but tsunami/founder, tsunami/founder-react, etc is good too. The other (less good) idea would be to remove the react dist because it gets packed with react. In its current state, anyone using the react version should use the /src file

Yeah, if we did "flounder/repo" we'd need to also do this for all our OS projects to maintain consistency, and the maintenance of that (as Tsunami grows) would get a bit out of hand. So if you deem that "tsunami/repo" and "tsunami/other-repo" is sufficient I guess I would push for that.
@leandro-lucarella-sociomantic do you have any thoughts / tips here? Your insight might be valuable.

@dilkROM
I like tsunami/flounder, tsunami/flounder-react ...
Facebook follows the same pattern for react and react-devtools  https://github.com/facebook?utf8=✓&query=react
(2-3 internal projects that want to use flounder-react will benefit from this splitting approach)

Maybe @zsolt-nagy-sociomantic has some thoughts on the issue?

@avraam-mavridis-sociomantic I am more interested in the idea you described in this issue, which is great and is 100% supported.
The repository names flounder and flounder-react seem to be correct, this way we can use just the core flounder when needed, and the updates of flounder-react do not affect users of flounder.

Also :+1: to having all in tsunami. I would consider letting projects leave the tsunami namespace if they eventually graduate, meaning the company stops being the main maintainer of a project, and just an eventual contributor (if at all).

bump.  any movement on this?

@dilkROM @leandro-lucarella-sociomantic  can we have the repo(s) for react ?

Could you follow the internal guideline to request a new repo? If you don't know what I am talking about please contact me privately.

I am closing the issue. The repo is here https://github.com/sociomantic-tsunami/flounder-react


Opt in user data collection.

[x] The commits are squashed in a cohesive manner and have meaningful messages.
[ ] For commits that came from upstream, [UPSTREAM] has been prepended to the commit message - N/A
[x] JIRA link(s):   https://issues.redhat.com/browse/RHODS-2856
[ ] The Jira story is acked
[ ] An entry has been added to the latest build document in Build Announcements Folder.
[x] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious)

This PR adds the ability for a RHODS admin to enable and disable user interaction data collection.
Testing instructions:
RHODS admin testing:

Login to the RHODS dashboard as a RHODS admin.
Verify that Settings in the left hand navigation is present.
Verify that Cluster Settings is a menu item under Settings.
Navigate to Cluster Settings.
Verify that the "Allow collection of usage data" is checked or unchecked, based on redhat-ods-applications --> rhods-segment-key-config --> segmentKeyEnabled Config map in OpenShift.
Check or uncheck "Allow collection of usage data"
Verify that the config map in step 5 is updated.

RHODS non admin testing:

Login to the RHODS dashboard as a non RHODS admin (RHODS developer).
Verify that Settings in the left hand navigation is NOT present.
Verify that Cluster Settings is NOT present.

LGTM

LGTM (again)

Added https://github.com/red-hat-data-services/odh-manifests/pull/204 for the rbac permission


fix APK not running

fixed #10

@Chromicle When we upgrade the flutter version, it is easy to cause compilation errors caused by project differences, In addition, multiple contributors will easily submit their project settings and unrelated files to the repo, resulting in unnecessary workload.
Therefore, I suggest adding the release compilation guide in README.md instead of adding 53 files. The project uses the flutter project created by the script, so it can always be created correctly.


ARC: MWDT: minimal libc includes

Describe the bug
Hi,
I'm working on fixing system includes of C++ headers (via -isystem flag) in #52424 PR.
I use MWDT toolchain with ARC nsim_hs platform.
After I carefully removed MWDT includes, I tried to build Zephyr using built-in Minimal libc. This corresponds to case "NOT CONFIG_ARCMWDT_LIBC" and flag '''-Hno_default_include''' has been passed into toolchain (ref. cmake/compiler/arcmwdt/compiler_flags.cmake). This means that only external (regarding toolchain) includes should be used.
Building has broken with error  fatal error: 'stddef.h' file not found''.
Also 'stdarg.h' was not found in header dependencies.
According the issue I'd like to get clarification. Why this two headers (stddef.h and stdarg.h) were not added into Mimimal libc set of includes?
Is this some kind of omission, or headers were not added intentionally?
To Reproduce
in cmake/compiler/arcmwdt/target.cmake
replace
list(APPEND NOSTDINC ${TOOLCHAIN_HOME}/arc/inc)

with
if(CONFIG_ARCMWDT_LIBC)
 list(APPEND NOSTDINC ${TOOLCHAIN_HOME}/arc/inc)
endif()

Expected behavior
The build process should not be failed because of missing header errors.
Impact
Logs and console output
In file included from zephyrproject/zephyr/arch/arc/core/offsets/offsets.c:25:
In file included from zephyrproject/zephyr/include/zephyr/kernel.h:17:
zephyrproject/zephyr/include/zephyr/kernel_includes.h:16:10: fatal error: 'stddef.h' file not found
#include <stddef.h>
         ^~~~~~~~~~
1 error generated.

Environment (please complete the following information):
ZEPHYR_TOOLCHAIN_VARIANT=arcmwdt
west -v build -b  nsim_hs samples/hello_world

Additional context

It seems that it was done intentionally (given how it's implemented for GNU toolchain) that in case of minimal libc implementation we steel uses a few headers from toolchain.
The implementation for ARC MWDT was proper reworked as part of #52606

It seems that it was done intentionally (given how it's implemented for GNU toolchain) that in case of minimal libc implementation we steel uses a few headers from toolchain.
The implementation for ARC MWDT was proper reworked as part of #52606


Weakly link a framework

Is there a way currently to weakly or optionally link a framework?
Was looking around and didn't see it.

At the moment no, it's not possible to mark a dependency linkage as optional.
It's something that would be possible to add to a dependency definition though, which would then set the required WEAK attribute on the framework build file

You can do this by adding -weak_framework Foo to OTHER_LDFLAGS for the target you want to weakly link Foo

True, that’s a good workaround 👆

@keith Thanks man that's a good workaround.

Added in #411, and will be in the next release


Cannot set cors in file service storage

This is autogenerated. Please review and update as needed.
Describe the bug
Command Name
az storage cors clear --services f or az storage cors list
Errors:
'NoneType' object has no attribute 'body'
Traceback (most recent call last):
storage/v2018_03_28/common/storageclient.py, ln 252, in _perform_request
    self.authentication.sign_request(request)
storage/v2018_03_28/common/_auth.py, ln 78, in sign_request
    self._add_authorization_header(request, string_to_sign)
storage/v2018_03_28/common/_auth.py, ln 57, in _add_authorization_header
    signature = _sign_string(self.account_key, string_to_sign)
storage/v2018_03_28/common/_common_conversion.py, ln 91, in _sign_string
    key = _decode_base64_to_bytes(key)
...
binascii.Error: Invalid base64-encoded string: number of data characters (77) cannot be 1 more than a multiple of 4

storage/v2018_03_28/common/retry.py, ln 154, in _retry
    if hasattr(context.request.body, 'read'):
AttributeError: 'NoneType' object has no attribute 'body'

To Reproduce:
Steps to reproduce the behavior. Note that argument values have been redacted, as they may contain sensitive information.

Put any pre-requisite steps here...
az storage cors clear --services f

Expected Behavior
Environment Summary
Darwin-19.4.0-x86_64-i386-64bit
Python 3.7.4
Shell: bash

azure-cli 2.0.64 *

Additional Context

add to S170

Hi @droplet-tech, I am trying to reproduce your issue. But I cannot reproduce it with azure cli 2.6.0 installed. Could you try to upgrade your azure cli version according to https://docs.microsoft.com/en-us/cli/azure/install-azure-cli?view=azure-cli-latest or provide debug information with--debug in your command to help figure out root cause in your scenario?


Tags Not Showing in Search Results

Tags not showing, only categories. Can the tags be shown as well?

@fjumawan I forgot all about this! Working on it, thanks for bringing it up.

Hey @parkjc did you get a chance to look at this? Thought you mentioned it was bringing code back from the old search function. Thanks!

@billymeinke yeah i was in the process of working on this last week and almost finished. I'll get @parkjc on board and add tags by today.


feat: add lark applink

Description
use lark/feishu app link open api to open lark/feishu client.
Screencast

Checklist

[x] I read the extension guidelines
[x] I read the documentation about publishing
[x] I ran npm run build and tested this distribution build in Raycast
[x] I checked that files in the assets folder are used by the extension itself
[x] I checked that assets used by the README are placed outside of the metadata folder

@mattisssa can you review this, thanks very much.

@mattisssa can you review this, thanks very much.

Hey @chyroc! It's not necessary to mention us in the PRs; we have a queue for the reviews, every PR will be reviewed by the review team 😉

I'm sorry, it's been a long time since I brought this up, not immediately after I initiated the PR. I feel that the review time of the pr I submitted recently is relatively long. Thanks for your work.


Mono/macOS: Change .app packaging and codesign editor binary

Supersedes #13, thanks @sjml for the initial work and @neikeq for the buildsystem changes.
Requires https://github.com/godotengine/godot/pull/43768 to be cherry-picking in 3.2 to work.

Marking as draft but it's ready for review, it's just until https://github.com/godotengine/godot/pull/43768 is merged and cherry-picked and the resulting binaries are tested.

So I'm getting a signing failure for the Mono build, but I'm not sure why (as it happens over SSH I only get "Signing failed?" from our build script.
I could use some help to test the current state and see what might still be off to properly sign the .app.
Here's a current build from the 3.2 branch + https://github.com/godotengine/godot/pull/43768 with the changes from this PR:
https://downloads.tuxfamily.org/godotengine/testing/3.2.4.rc.mono-codesign_ready.zip
It includes both the editor build and the templates unsigned, and it would be nice to see:

Whether the editor build still works even though it's unsigned
Whether the export templates can now be signed (that was the aim of https://github.com/godotengine/godot/pull/43768)
Whether the editor .app can also be signed, and if so, what's wrong with my current packaging or codesign options or entitlements

Here's a new test build for the editor which is successfully signed and notarized: https://downloads.tuxfamily.org/godotengine/testing/3.2.4.rc.mono-codesigned-editor.zip

Updated to match what was finally merged with https://github.com/godotengine/godot/pull/43768. Editor build signed and notarized successfully with this script, still need confirmation that all is well with the export templates too.


gperftools 2.9 tcmalloc_minimal_unittest fails on OS X 11.2.1

After compiling gperftools with the following arguments on OS X 11, I get the following error when launching tcmalloc_minimal_unittest.
./configure --disable-dependency-tracking
make tcmalloc_minimal_unittest
./tcmalloc_minimal_unittest

src/central_freelist.cc:330] tcmalloc: allocation failed 8192

This also matches the failures of Homebrew CI when trying to build gperftools 2.9.

I am not able to reproduce. osex 10.15.7. So at least no something immediately dumb. Need help debugging this. Can you try same under debugger and showing what is backtrace ? Then I would probably need you to show me what sbrk and mmap returns when this fails (which looks like maybe first call to both).
Also this is x86-64 right? (have no idea if osex supports i386).
Also I assume 2.8.1 works ?
Also can you attach config.log and config.h ?

Also this is x86-64 right?.

Yes this is x86-64.

Also I assume 2.8.1 works ?

Yes, 2.8.1 does work.
Here are the configure.log and configure.ac. The homebrew package uses the -D_XOPEN_SOURCE cflags. I tried with and without it, it fails the same way in both cases.

Thanks. Can you attach strace (or struss or whatever there is on osex that logs syscalls)? Same test just wrap it with strace.

Is there some kind of patching involved? Asking because I got my hands on latest osx and M1-based machine and it requires some configure tweaks to work, but then it works fine.
I found that:
$ ./configure --enable-stacktrace-via-backtrace
is necessary.
And then forcing this backtracing method is necessary.
$ make tcmalloc_unittest
$ TCMALLOC_STACKTRACE_METHOD=generic TCMALLOC_HEAP_LIMIT_MB=1024 ./tcmalloc_unittest
So definitely something worth a fix, but this seems to be different issue than what you're reporting.

I pushed couple commits that make OSX pass tcmalloc_unittest out of the box.

Sorry the delay, I confirm that this works for me locally:
$ ./configure --enable-stacktrace-via-backtrace
$ make tcmalloc_unittest
$ TCMALLOC_STACKTRACE_METHOD=generic TCMALLOC_HEAP_LIMIT_MB=1024 ./tcmalloc_unittest

Also, building from HEAD fixes the issue I had without any of these configure tweaks. If you were to make a release with those changes, we could integrate that directly to the Homebrew package.

Done. 2.9.1 was just released.


Edits of Connectors docs for Build

Please review and merge/publish these changes as soon as possible. We need these updates to be complete for Build at the end of May. They can be published before Build, but after Build is too late. Thanks, and let me know if you have any questions.
(FYI - I am the editor/writer on the Microsoft Graph team working under Kristen Womack and Laura Graham.)

Closing as changes will come in different PR from @mecampos


500 error on content save

Our editor saw this error when saving a text page:

I traced it to an unloaded concern method, #verify_edit_lock!:

Do you know why this might be happening?  Thank you.

Never seen that before. The EditLocking concern is included in Pageflow::ApplicationController which PagesController inherits from. So that looks all fine. Might be some funky code reloading issue? Are you running in production environment?

Yes, I am. I haven't seen that until now, either. The only thing that I can think might be the cause is that I needed to add Google Tag Manager, so I'm running my own layout template in
views > layouts > pageflow > themes > nova >
I'm wondering if there's some react code that then doesn't know where to find the concern.

Not clear to me how this could be related to React. Maybe there is something getting in the way of eager loading Pageflow::ApplicationController? Or something causing Pageflow::ApplicationController to be redefined without including the concern? Hard to say actually. If the problem only happened once, I'd lean towards closing this issue. Feel free to report back once the issue surfaces again.

Sorry, I was not clear - I just mentioned React because the save happens via AJAX.
I made the following changes to my code:
Added layout template containing GTM snippets:
/app/views/layouts/pageflow/themes/nova/application.html.erb_
Modified the application controller to use this layout template:
module Pageflow
  class Applicationcontroller < ActionController::Base
    layout 'pageflow/themes/nova/application'
  end
end

This results in the verify_edit_lock! method being unknown, which indicates that that concern is not being loaded., and somehow the layout spec is preventing that.
Thank you.

In development mode this can definitely cause Pageflow's ApplicationController not to be auto loaded since you already defined the constant. In production mode, I would expect eager loading to work anyway, but maybe I am missing something. Generally speaking, I think it is safer practice to include concerns in an initializer to patch some library's classes rather than trying to reopen classes and risking to break auto loading. In this case the even simpler approach might be to override layouts/pageflow/application.html.erb by creating a template with this name in your app/views directory. You are changing the layout for all entries anyway - independent of the theme.
Still, please note that overriding templates like that basically means you will need to manually port changes on future updates. Pageflow provides some partials as extension points which are empty by default and should be safer to override.

And for everything even slightly more complicated, creating a custom widget type is probably the best option.


⚠ Bofrost.at has degraded performance

In d1ee7a4, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 5290 ms

Resolved: Bofrost.at performance has improved in 3f0778b.


[Bug]: Cache is not invalidate when a amasdk file pack has been updated

Package name
core, showcase-sdk swagger-builder
Package version
10.0.0
Reproduction steps
Build application as is.
Once everything is build, modify the @ama-sdk/core file-pack cli script and rebuild the project.
Current result
Showcase sdk is not rebuild even though it has a dependency on the @ama-sdk/core package
Expected result
All the projects with a dependency on @ama-sdk/core should be rebuild.
Additional comments
No response

Should be fixed by https://github.com/AmadeusITGroup/otter/pull/1457


About license

I want to ask about the license because a friend of notgoodusername changed the license from MIT to Creative Commons Attribution-NonCommercial-ShareAlike 4.0 International License and can he change if Osiris is under MIT license? and notgoodusername base is osiris paste

im pretty sure daniel is ok with it (the dev of osiris)

im pretty sure daniel is ok with it (the dev of osiris)

maybe but MIT doesnt allow you to change the license

im pretty sure daniel is ok with it (the dev of osiris)

maybe but MIT doesnt allow you to change the license

well i dont make pastes so ur gonna gave to figure that one out


A constructor for CSV files

This will do: CSV.read(filename::String, sink=DataFrame) |> TS internally. Think about supporting XLS.

This will get fixed as part of #80.


Implement endSession endpoint functionality

Implementation for the endSession endpoint (without advanceQueue yet). See Postman screenshots below.

Insufficient information:

Delete player Empty2:

Try to delete player Empty2 again:

Update the Postman screenshots to show "Empty{x}" unable to be deleted. Besides the nit, LGTM!


Commit 0cab360 introduced a .gitignore that included three icon paths, app won't start

Hi,
First of all, great project and thank you for providing this software open source!
Problem
With the latest commit (0cab360), the app won't start because of a FileNotFoundError (line 256 of mini.py). This happens because the icons "tray_icon.png", "error_icon.png" and "info_icon.png" are not found. In that commit, the .gitignore listed them as ignored, but the assets folder includes a .ico version of "tray_icon", I imagine that you were migrating from .png to .ico
Proposed solution
Add "error_icon.ico" and "info_icon.ico" to the assets folder and change lines 244:246 of mini.py accordingly to have the .ico extension
Thank you and let me know if I can help further :)
Riccardo

Fixed


Could not build the precompiled application for the device.

After installing flutter_login_facebook 3.0.0 on real iphone, im getting error:
Could not build the precompiled application for the device.
It appears that your application still contains the default signing identifier.
Try replacing 'com.example' with your signing id in Xcode:
open ios/Runner.xcworkspace
Error launching application on iPhone.
But its works fine on emulator.
The identifier was changed.

flutter clean in VSCode - solved the problem


Accessing JSON used for constructing data models

Hey @mattbdean, I'm just updating to JRAW v1.0 and I have to say that this is fantastic work. I have one question -- I used to rely a lot on Thing#getDataNode() method for accessing custom fields that JRAW hasn't added in yet.
Now that JRAW v1 does not lazily evaluate fields in data models anymore, is there still any other way to access the JSON that was used to create them?

Unfortunately right now there is not. I realize consumers might need to access properties not officially handled by JRAW and I plan on supporting it in v1.2.0 by forking rharter/auto-value-moshi. Right now the idea is to store unknown properties in a Map<String, Object> while deserializing and allow access to these properties via a get(String key) method.

With Moshi, any properties not registered by the model are thrown away during deserialization. The fork would add the ability to store those would-be-discarded properties and then allow access to them at a later time.

I see. Moshi has built in codegen with v1.6. Did you get a chance to look at it?

Makes sense. Familiarity > shiny new things.


Debian package

In order to support kel-agent Debian packaging, this library also needs its own Debian package.

ITP ticket: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=975583
$ dh-make-golang github.com/k0swe/wsjtx-go

# fix up ITP and send
# fix up TODOs

$ git add debian && git commit -a -m 'Initial packaging'

# gbp buildpackage isn't working on Ubuntu

$ bzr builddeb -- -us -uc

I also needed to import https://github.com/leemcloughlin/jdn: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=975586

Requesting access to Salsa repos:

https://salsa.debian.org/go-team/packages/golang-github-leemcloughlin-jdn
https://salsa.debian.org/go-team/packages/golang-github-k0swe-wsjtx-go

Thanks to @tmancillnr for sponsoring me through the Debian upload process.

This has been accepted into Debian unstable: https://packages.debian.org/sid/golang-github-k0swe-wsjtx-go-dev


Add support to create empty local translog if remote translog is empty

Description

In this change, we add a support to create empty translog on local if there is no data in remote translog.
Remote store restore fails if remote translog is empty. As most of the data is part of segments, the new query parameter added in this PR, force_empty_translog, ignores remote translog and creates empty translog on local.
But this is not ideal solution. We made sure each time primary shard is created, remote translog is populated here: https://github.com/opensearch-project/OpenSearch/pull/10839 but it is not guaranteed to succeed always (e.g. if remote store calls are failing at the time of shard creation)

Check List

[x] New functionality includes testing.

[ ] All tests pass

[ ] New functionality has been documented.

[ ] New functionality has javadoc added

[ ] Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
[x] Commits are signed per the DCO using --signoff
[ ] Commit changes are listed out in CHANGELOG.md file (See: Changelog)
[ ] Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

What is our marker here to denote completeness, to ensure we aren't marking incomplete data available. In the case you call out like shard creation failure, can we not retry the same and fail fast if we aren't able to write to remote store.

We can retry on failure but we decided to log the error and continue the shard creation in https://github.com/opensearch-project/OpenSearch/pull/10839. There are a couple of reasons:

The issue occurs immediately after shard creation where ingestion has not happened yet. If we index at least a single doc successfully, remote translog will be populated and the issue will not occur. So, IMO this is a rare scenario. Failing shard creation and the recovery which triggered the shard creation (failover, primary relocation) may impact existing flows.
We got to know about the issue during testing and we made the change in https://github.com/opensearch-project/OpenSearch/pull/10839. But there can be other scenarios where a shard in remote translog will not have any data.

If that is something that you think is hard, having a force_allocate in the remotestore/restore API sounds like a better option

Ideally, we should be using new parameter introduced with this change only when we are sure that remote translog does not exist and there is no data loss. But, as you pointed out, we won't be able to guarantee that. For example, if the data in remote translog is incomplete (due to any reason, can't think of a reason as of now :) ), with this change, user would be able to restore data at least in segments.
I like the name force_allocate over current force_empty_translog. Was your suggestion only on the parameter name or you were suggesting something more with this parameter?

Ideally, we should be using new parameter introduced with this change only when we are sure that remote translog does not exist and there is no data loss. But, as you pointed out, we won't be able to guarantee that. For example, if the data in remote translog is incomplete (due to any reason, can't think of a reason as of now :) ), with this change, user would be able to restore data at least in segments.

This looks giving a risky parameter in hands of the user .

The issue occurs immediately after shard creation where ingestion has not happened yet. If we index at least a single doc successfully, remote translog will be populated and the issue will not occur. So, IMO this is a rare scenario. Failing shard creation and the recovery which triggered the shard creation (failover, primary relocation) may impact existing flows.

This issue is rare that during failover the primary is able to download all the segment files, but is not able to upload empty tlog/ckp files.  We should rather let the failovers fail. In that case restore API can be retried again , right ?

Hi @sachinpkale, Is this being worked upon? Feel free to reach out to maintainers for further reviews.

Not going ahead with this change as creating shard without translog can result in data loss.


Errant } appearing in top left of page

I opened a pull request to fix it, just deleting an extra }
https://github.com/bep/galleriesdeluxe/pull/2

merged in https://github.com/bep/galleriesdeluxe/pull/2


Fallback to parent dir name if sample file name is index

Fixes ampproject/docs#2371.

Can you please add a test for this.

Done!

Thanks!

=> +<EMAIL_ADDRESS>