Clean up unused Envoy Proxy resource that was referenced by Gateway Class

Description:

Describe the desired behavior, what scenario it enables and how it
would be used.

Having initially deployed the GatewayClass with parametersRef, the user can later edit it and remove the envoy proxy resource from parametersRef.
It would be good to check for such updates and clean up the unused resource from the cluster.
[optional Relevant Links:]

Any extra documentation required to understand the issue.

It could be another follow-up to these PRs

https://github.com/envoyproxy/gateway/issues/648
https://github.com/envoyproxy/gateway/issues/865

closing as not planned, EG should not clean up EnvoyProxy resource created by the user


My kubernetes pods keep crashing with “CrashLoopBackOff”

This is a...

[ ] Feature Request
[ ] Bug Report

Problem:
Proposed Solution:
Page to Update:
http://kubernetes.io/...

This issue sounds more like a request for support and less
like an issue specifically for docs. I encourage you to bring
your question to the #kubernetes-users channel in
Kubernetes slack. You can also search
resources like
Stack Overflow
for answers  to similar questions.
You can also open issues for Kubernetes functionality in
https://github.com/kubernetes/kubernetes.
If this is a documentation issue, please re-open this issue.


Fixes class cast exception in MaxLineLength config

I have now reworked the config file a bit. Now no ClassCastException is thrown and the test case does not fail :) - see #84


fix crash when removing glowcase text

iterator time. the obvious pr
threw in a nullcheck since intellij was warning about it

Implemented in 08be518b5abe8a1052873363506d50845612d7ba


ImprovementDistilledObjects.java:392-395: Code...

The puzzle 157-c3c3a3ce from #157 has to be resolved:
https://github.com/objectionary/jeo-maven-plugin/blob/59486edab1fd88228051f0dd5edb2964d632119a/src/main/java/org/eolang/jeo/improvement/ImprovementDistilledObjects.java#L392-L395
The puzzle was created by @rultor on 17-Oct-23.
Estimate: 90 minutes,  role: DEV.
If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.

@0pdd the only puzzle #185 is solved here.


Bump Alluxio version to 2.4.0

Alluxio 2.4 supports Java11, see https://github.com/Alluxio/alluxio/issues/9856

LGTM

Thanks! Can you squash the commits?

superseded with https://github.com/prestosql/presto/pull/5732


Compare .NET 6 vs .NET 5 Directory browsing

For the .NET 6 version, I removed
// using System.IO;
    app.UseStaticFiles(new StaticFileOptions
    {
        FileProvider = new PhysicalFileProvider(
            Path.Combine(env.WebRootPath, "images")),
        RequestPath = "/MyImages"
    });

See V6 Directory browsing vs V5 Directory browsing vs

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: d47f38e2-bc36-cfb8-b0cc-17a534689f8b
Version Independent ID: 3fec6e08-fc99-7a5c-796f-3f2347cad891
Content: Static files in ASP.NET Core
Content Source: aspnetcore/fundamentals/static-files.md
Product: aspnet-core
Technology: aspnetcore-fundamentals
GitHub Login: @Rick-Anderson
Microsoft Alias: riande

@serpent5  is that OK or should I have @Tratcher review the code I removed?

In the screenshot for this section, we show links to the files, e.g. banner1.svg. The code you've removed adds the ability to serve the files behind the links, so without it, clicking on those links 404s. I think I'd include it for a more complete example, but it's up to you. I think we should be able to share the FileProvider instance between the two calls too, to make it slightly cleaner.


chore: updates poetry to 1.8.2

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 74.79%. Comparing base (0d66408) to head (6ed6586).
Report is 39 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #499   +/-   ##
=======================================
  Coverage   74.79%   74.79%
=======================================
  Files          25       25
  Lines         849      849
=======================================
  Hits          635      635
  Misses        214      214

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

/retest

/retest


Issue 1236

Uses anonymous profile in test deserializing from S3 to avoid permissions issue
Parametrizes profile used in other tests to avoid duplication of code
Closes #1236

Need to add a unit test to fix the code coverage miss


[Autocomplete] Fixed options are removable with backspace and the clear all button

When creating an Autocomplete component with fixed options, the only effect this has is disabling the chip. The associated remove button for the chip is disabled with the intention of preventing you from removing it from the selection.
However, the user can still remove the fixed option using the backspace on the keyboard or if the Autocomplete component does not have the disableClearable prop and the user clicks the "clear all" button on the right of the Autocomplete.

[x] The issue is present in the latest release.
[x] I have searched the issues of this repository and believe that this is not a duplicate.

Current Behavior 😯
For fixed options in an Autocomplete component, the user can remove the fixed option using the backspace on the keyboard or if the Autocomplete component does not have the disableClearable prop and the user clicks the "clear all" button on the right of the Autocomplete.
Expected Behavior 🤔
Any fixed options in an Autocomplete component should not be able to be removed by any means. No removal for backspace key, clear all button, or clicking the remove button on the chip.
Steps to Reproduce 🕹
Steps:

Create an Autocomplete component
Add fixed options to the component by using disabled chips in the renderTags prop.
Confirm chip is disabled and can't be removed by clicking the remove button
Use backspace or clear all to remove the fixed options

You can find an example in the material-ui docs for using Autocomplete with Fixed options: https://material-ui.com/components/autocomplete/#fixed-options
Context 🔦
If I have fixed options I would like them to not be able to be removed in any way whatsoever. I can get around the clear all button if I use the disableClearable prop but ideally I would still want this button and have it just remove the not fixed options. I was unable to find a workaround for the backspace functionality.
Your Environment 🌎

Tech
Version

Material-UI
v4.9.10

Material-UI Lab
v4.0.0-alpha.47

React
v16.3.1

Browser
Firefox 74.0.1 64-bit

TypeScript
3.8.3

@kthyer Yes, your description is accurate. What do you think of updating the demo to account for these different ways to clear the value? It would require to control the value state and to ignore all attempts to remove this tag.

@oliviertassinari I think that would definitely help my use case and would be a good way to show how to fully make it a fixed option. That would be much appreciated!

@kthyer What do you think of this diff?
diff --git a/docs/src/pages/components/autocomplete/FixedTags.tsx b/docs/src/pages/components/autocomplete/FixedTags.tsx
index 186fdcd9e..0fe210245 100644
--- a/docs/src/pages/components/autocomplete/FixedTags.tsx
+++ b/docs/src/pages/components/autocomplete/FixedTags.tsx
@@ -5,16 +5,29 @@ import TextField from '@material-ui/core/TextField';
 import Autocomplete from '@material-ui/lab/Autocomplete';

 export default function FixedTags() {
+  const fixedOptions = [top100Films[6]];
+  const [value, setValue] = React.useState([...fixedOptions, top100Films[13]]);
+
   return (
     <Autocomplete
       multiple
       id="fixed-tags-demo"
+      value={value}
+      onChange={(event, newValue) => {
+        setValue([
+          ...fixedOptions,
+          ...newValue.filter((option) => fixedOptions.indexOf(option) === -1),
+        ]);
+      }}
       options={top100Films}
       getOptionLabel={(option) => option.title}
-      defaultValue={[top100Films[6], top100Films[13]]}
       renderTags={(value, getTagProps) =>
         value.map((option, index) => (
-          <Chip label={option.title} {...getTagProps({ index })} disabled={index === 0} />
+          <Chip
+            label={option.title}
+            {...getTagProps({ index })}
+            disabled={fixedOptions.indexOf(option) !== -1}
+          />
         ))
       }
       style={{ width: 500 }}

Do you want to work on a pull request? :)

@oliviertassinari The diff looks good! I can work on a pull request, thanks again!

This still seems to be an issue. Fixed options should not be deleted when pressing backspace.


Integrated Terminal closes immediately upon opening

Issue Type: Bug
When integrated terminal is open, it immediately closes.

Open VSCode
Select "View" > "Terminal"

No errors logged in Developer Tools console.
See screen recording for behavior:
https://drive.google.com/open?id=1uBa3EJlcLTFpySKyhDysMLjcih8KOO8G
VS Code version: Code - Insiders 1.29.0-insider (4626bc0e1b679d555dd6f034ece35ffc394b3bb7, 2018-10-29T06:11:45.152Z)
OS version: Darwin x64 17.7.0

System Info

Item
Value

CPUs
Intel(R) Core(TM) i5-8259U CPU @ 2.30GHz (8 x 2300)

GPU Status
2d_canvas: enabledchecker_imaging: disabled_offflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onnative_gpu_memory_buffers: enabledrasterization: enabledvideo_decode: enabledvideo_encode: enabledwebgl: enabledwebgl2: enabled

Load (avg)
2, 2, 2

Memory (System)
8.00GB (0.42GB free)

Process Argv

Screen Reader
no

VM
0%

Extensions: none

Is this a personal machine or managed by your org? Also what's $SHELL set to and what's in your settings.json file?

https://drive.google.com/open?id=1uBa3EJlcLTFpySKyhDysMLjcih8KOO8G

@tsengsational  did you solve it ? i am having the same issue

@caiceA please answer the questions above, your $SHELL is probably bad.

@caiceA please answer the questions above, your $SHELL is probably bad.

@Tyriar i changed my Shell to this and its working fine now

@Tyriar what i should do now ? to change the setting?

@caiceA just changing the setting will work, having SHELL as a bad value is unrelated to VS Code, likely due to your enterprise setup or shell startup scripts.

this is the ouput of echo $SHELL
/bin/bash

Can you run /bin/bash in the default mac terminal?


Project creation fails in Lab 23 Implement Security and Compliance in an Azure DevOps pipeline Project creation

Error while creating build definition: The pipeline is not valid. A task is missing. The pipeline references a task called '521d1e00-f5fb-4b73-a93b-b2fe88a9af91'. This usually indicates the task isn't installed, and you may be able to install it from the Marketplace: https://marketplace.visualstudio.com. (Task version , job 'Phase_1', step 'WhiteSourceBolt3'.)
I installed WhiteSource Bolt from the marketplace ,but I still get the same error message

Kindly try again in incognito mode or with different organization and let us know.


(Bug) #922 The numbers on the "How much" screen aren't highlighted with black color when user enter the amount

Description
The amount field is disabled on mobile devices. There is an opacity: 0.4 style prop applied for disabled inputs. The solution is to set opacity 1 for the amount field used in send flow.
Also, want to admit that the text shouldn't be black. It should be #42454a according to design.
About #922
How Has This Been Tested?
Open the app on ios simulator.
Go to the dashboard.
Click on the send button.
Go to amount (how much?) step.
Type some amount to see text color in the input.
Checklist:

[x] PR title matches follow: (Feature|Bug|Chore) Task Name
[x] My code follows the style guidelines of this project
[x] I have followed all the instructions described in the initial task (check Definitions of Done)
[x] I have performed a self-review of my own code
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] I have added reference to a related issue in the repository
[x] I have added a detailed description of the changes proposed in the pull request. I am as descriptive as possible, assisting reviewers as much as possible.
[x] I have added screenshots related to my pull request ( for frontend tasks)
[ ] I have pasted a gif showing the feature.
[x] @mentions of the person or team responsible for reviewing proposed changes

Applied color is: #42454a
Screenshot:

It's not the correct color.
Maybe it's still with opacity...
The color should be the same as the title and the other numbers on that screen.

I found what was wrong. Now it is looking correct.

I have created new PR taken from the last commit of master branch.
https://github.com/GoodDollar/GoodDAPP/pull/984
So closing this PR.


Missing properties in DatasetState

When a new DatasetState is created from a JobState object in JobState#newDatasetState, the start time, end time and duration properties are not copied.
This will result 0 values in the job level properties in the state store files.

LGTM.

@liyinan926 Thanks for committing it!


Distributed computation requires CUDA for non-CUDA MxNet version

Environment info
Operating System: Debian Jessie x64
Hi,
I have not examined the issue deeply yet but maybe some contributors may notice the problem easily. When I submit a command similar to below:
launch.py -n X --launcher ssh -H hosts python myexperiment.py --kv-store dist_sync
the error below is raised. However, I've compiled MxNet with USE_CUDA=0 and don't use any GPU in my code. Why does it try to find GPU?
I've tried dist_async, still the same problem. I've tried removing nodes with GPU, still the same problem. I've tried removing nodes with GPU and decreasing the number of the nodes(X). This time, it worked without any problem. However, when I increase X, again the same problem. What should I do?
As a note, when I do not use launch.py, my code works without any problem.
Error:
NVIDIA: no NVIDIA devices found
Stack trace:
/home/mkarakoc/private/frameworks/mxnet/dmlc-core/include/dmlc/./logging.h:235: [21:34:52] src/storage/storage.cc:38: Check failed: e == cudaSuccess || e == cudaErrorCudartUnloading CUDA: unknown error
Traceback (most recent call last):
File "RunDeepAutoencoder.py", line 179, in
main();
File "RunDeepAutoencoder.py", line 153, in main
ae_model.layerwise_pretrain()
File "autoencoder.py", line 315, in layerwise_pretrain
File ".local/lib/python2.7/site-packages/mxnet-0.7.0-py2.7.egg/mxnet/module/base_module.py", line 362, in fit
File ".local/lib/python2.7/site-packages/mxnet-0.7.0-py2.7.egg/mxnet/module/module.py", line 356, in init_optimizer
File ".local/lib/python2.7/site-packages/mxnet-0.7.0-py2.7.egg/mxnet/model.py", line 82, in _initialize_kvstore
kvstore.init(idx, arg_params[param_names[idx]])
File ".local/lib/python2.7/site-packages/mxnet-0.7.0-py2.7.egg/mxnet/kvstore.py", line 100, in init
self.handle, mx_uint(len(ckeys)), ckeys, cvals))
File ".local/lib/python2.7/site-packages/mxnet-0.7.0-py2.7.egg/mxnet/base.py", line 77, in check_call
raise MXNetError(py_str(_LIB.MXGetLastError()))
mxnet.base.MXNetError:

should be fixed by #4550

Confirmed


Exits without waiting for user input during first-time setup

C:\WINDOWS\system32>electron-windows-store
You need at least Node 4.x to run this script
? Did you download and install the Desktop App Converter? It is *not* required to run this tool.  No
? You need to install a development certificate in order to run your app. Would you like us to create one?  Yes
Welcome to the Electron-Windows-Store tool!

This tool will assist you with turning your Electron app into
a swanky Windows Store app.

We need to know some settings. We will ask you only once and store
your answers in your profile folder in a .electron-windows-store
file.

? Please enter your publisher identity:  (CN=developmentca)
C:\WINDOWS\system32>

At the last line it didn't wait for me, and just exited back to the console

I tried providing these values on the command line arguments instead for publisher and windows kit location, but then I got this:
Configuration:
Desktop Converter Location:    undefined
Expanded Base Image:           undefined
Publisher:                     undefined
Dev Certificate:               undefined
Windows Kit Location:          undefined

(node:696) UnhandledPromiseRejectionWarning: TypeError: Cannot read property 'match' of undefined
    at inquirer.prompt.then.then (C:\Users\mhawker\AppData\Roaming\nvm\v10.6.0\node_modules\electron-windows-store\lib\params.js:92:29)
(node:696) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch
block, or by rejecting a promise which was not handled with .catch(). (rejection id: 1)
(node:696) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.


[CHECKLIST] Hubble bridge improvements

Overview
We have received a lot of good feedback on the Hubble bridge that we want to action with improvements.
Task Checklist

[x] https://github.com/webb-tools/webb-dapp/issues/1124
[x] https://github.com/webb-tools/webb-dapp/issues/732
[ ] https://github.com/webb-tools/webb-dapp/issues/1180
[x] https://github.com/webb-tools/webb-dapp/issues/1181
[x] https://github.com/webb-tools/webb-dapp/issues/1182

Moved remaining tasks to https://github.com/webb-tools/webb-dapp/issues/1620.


Elasticsearch image in extras/example/k8s/ can't be pulled

After kubectl apply -f extras/example/k8s, I see the following:
NAMESPACE     NAME                                    READY   STATUS             RESTARTS   AGE
default       app-db854bd98-cz89x                     1/1     Running            0          4m
default       app-db854bd98-vm85d                     1/1     Running            0          4m
default       client-bbf949b4-2xxq5                   1/1     Running            0          4m
default       echo-65fbbf879f-hzmcf                   1/1     Running            0          4m
default       elasticsearch-78476fcfb8-72fhm          0/1     ImagePullBackOff   0          4m
default       frontend-6db5b8ff95-s8g4b               1/1     Running            0          4m
default       frontend-6db5b8ff95-wldng               1/1     Running            0          4m
default       qotd-69fc75dc68-7shxp                   1/1     Running            0          4m
default       redis-6bd486bbfb-lfhg8                  1/1     Running            0          4m
default       search-8448864866-wckx8                 1/1     Running            0          4m
kube-system   coredns-c4cffd6dc-jh9bp                 1/1     Running            0          10m
kube-system   etcd-minikube                           1/1     Running            0          9m
kube-system   kube-addon-manager-minikube             1/1     Running            0          9m
kube-system   kube-apiserver-minikube                 1/1     Running            0          10m
kube-system   kube-controller-manager-minikube        1/1     Running            0          10m
kube-system   kube-dns-86f4d74b45-8hk57               3/3     Running            0          10m
kube-system   kube-proxy-7cd9h                        1/1     Running            0          10m
kube-system   kube-scheduler-minikube                 1/1     Running            0          10m
kube-system   kubernetes-dashboard-6f4cfc5d87-fz8v9   1/1     Running            0          10m
kube-system   storage-provisioner                     1/1     Running            0          10m

Just tried it out and the issue is still there.

Can I take this up?

Please go ahead @bensooraj ! :)

Here's what I have found:
The ErrImagePull => ImagePullBackOff error was caused because, in the absence of an explicit tag under the spec.template.spec.containers[].image section, k8s will assume the the tag to be latest. Evident from the following events logs:
Events:
  Type     Reason     Age                    From                                                   Message
  ----     ------     ----                   ----                                                   -------
  Normal   Scheduled  4m35s                  default-scheduler                                      Successfully assigned default/elasticsearch-8477696f97-5ndss to ip-192-168-76-48.ap-south-1.compute.internal
  Normal   Pulling    2m24s (x4 over 4m34s)  kubelet, ip-192-168-76-48.ap-south-1.compute.internal  pulling image "elasticsearch"
  Warning  Failed     2m22s (x4 over 4m11s)  kubelet, ip-192-168-76-48.ap-south-1.compute.internal  Failed to pull image "elasticsearch": rpc error: code = Unknown desc = Error response from daemon: manifest for elasticsearch:latest not found
  Warning  Failed     2m22s (x4 over 4m11s)  kubelet, ip-192-168-76-48.ap-south-1.compute.internal  Error: ErrImagePull
  Normal   BackOff    2m7s (x6 over 4m11s)   kubelet, ip-192-168-76-48.ap-south-1.compute.internal  Back-off pulling image "elasticsearch"
  Warning  Failed     116s (x7 over 4m11s)   kubelet, ip-192-168-76-48.ap-south-1.compute.internal  Error: ImagePullBackOff

An excerpt from Elasticsearch's official image description:

Note: Pulling an images requires using a specific version number tag. The latest tag is not supported.

I tried out one of the supported tags: 7.4.0, and it worked fine. Event logs:
Events:
  Type     Reason     Age               From                                                    Message
  ----     ------     ----              ----                                                    -------
  Normal   Scheduled  73s               default-scheduler                                       Successfully assigned default/elasticsearch-65794c8db4-jfnjv to ip-192-168-25-150.ap-south-1.compute.internal
  Normal   Pulling    73s               kubelet, ip-192-168-25-150.ap-south-1.compute.internal  pulling image "elasticsearch:7.4.0"
  Normal   Pulled     57s               kubelet, ip-192-168-25-150.ap-south-1.compute.internal  Successfully pulled image "elasticsearch:7.4.0"
  Warning  BackOff    18s               kubelet, ip-192-168-25-150.ap-south-1.compute.internal  Back-off restarting failed container
  Normal   Created    3s (x3 over 53s)  kubelet, ip-192-168-25-150.ap-south-1.compute.internal  Created container
  Normal   Started    3s (x3 over 53s)  kubelet, ip-192-168-25-150.ap-south-1.compute.internal  Started container
  Normal   Pulled     3s (x2 over 36s)  kubelet, ip-192-168-25-150.ap-south-1.compute.internal  Container image "elasticsearch:7.4.0" already present on machine

The elasticsearch deployment appears to be showing up correctly as well:

This is my first time using Weave Scope. Nice product!
Question: Can I go ahead with a PR with the latest image version: 7.4.0?

Nice work, @bensooraj


feat: Add serviceGroup resource and controller

Signed-off-by: disaster37<EMAIL_ADDRESS>

Codecov Report

Merging #15 (8132622) into main (50f27d1) will decrease coverage by 0.00%.
The diff coverage is 51.12%.

@@            Coverage Diff             @@
##             main      #15      +/-   ##
==========================================
- Coverage   59.41%   59.41%   -0.01%
==========================================
  Files          19       23       +4
  Lines        1747     2141     +394
==========================================
+ Hits         1038     1272     +234
- Misses        613      749     +136
- Partials       96      120      +24

Flag
Coverage Δ

unittests
59.41% <51.12%> (-0.01%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

api/v1alpha1/centreonservice_types.go
20.58% <0.00%> (ø)

api/v1alpha1/zz_generated.deepcopy.go
0.00% <0.00%> (ø)

pkg/centreonhandler/centreon.go
28.57% <ø> (ø)

pkg/centreonhandler/centreon_service.go
64.85% <ø> (ø)

pkg/centreonhandler/centreon_servicegroup_model.go
0.00% <0.00%> (ø)

pkg/centreonhandler/centreon_servicegroup.go
60.18% <60.18%> (ø)

controllers/centreonservicegroup_controller.go
62.62% <62.62%> (ø)

controllers/centreonservice_controller.go
70.79% <75.00%> (+7.42%)
:arrow_up:

api/v1alpha1/centreonservicegroup_types.go
100.00% <100.00%> (ø)

controllers/controller_centreon.go
75.14% <0.00%> (+1.69%)
:arrow_up:

... and 3 more

Help us with your feedback. Take ten seconds to tell us how you rate us.


Seems that cygames again patched dmm client to block the plugin

as title describe
no clue on how they did it though


C++: Prevent AliasedVirtualVariable from overlapping string literals

We were hitting a combinatorial explosion in hasDefinitionAtRank for functions that contain a large number of string literals. The problem was that every Chi instruction for AliasedVirtualVariable was treated as a definition of every string literal. We already mark string literals as isReadOnly(), but we were allowing AliasedVirtualVariable to define read-only locations so that the AliasedDefinition instruction would provide the initial definition for all string literals.
To fix this, I've introduced the new InitializeNonLocal instruction, which is inserted in the prologue of every function right after AliasedDefinition. It provides the initial definition for every non-stack memory location, including read-only locations, but is never written to anywhere else. It is the conterpart of the AliasedUse instruction in the function epilogue, which represents the use of all non-stack memory after the function returns. I considered renaming AliasedUse to ReturnNonLocal, to match the InitializeXXX/ReturnXXX pattern we already use for parameters and indirections, but held off to avoid unnecessary churn. Any thoughts on whether I should make this name change?
This change has a significant speedup in evaluation time for a few of our troublesome databases:
attnam/ivan: 13%
awslabs/s2n: 26%
SinaMostafanejad/OpenRDM: 7%
zcoinofficial/zcoin: 8%

I considered renaming AliasedUse to ReturnNonLocal, to match the InitializeXXX/ReturnXXX pattern we already use for parameters and indirections, but held off to avoid unnecessary churn. Any thoughts on whether I should make this name change?

Let's keep that churn out of this PR. I'd be happy with more consistent names down the line, but I'm not a fan of the Return prefix. It has already confused me before because I thought it was related to the return value of the function.

@jbj I've added a test case to ssa.cpp that best illustrates the change. Without this PR, the definition of the Load would have been connected to the Phi at the beginning of block 3, rather than to the InitializeNonLocal instruction,


All project files are in non-UTF encoding

All project files after yeoman generator are created in non-UTF encoding (in my case - Windows 1251), which lead to national characters (in my case - Cyrillic) are corrupted.
After resaving from Visual Studio with UTF8 encoding, the issue has gone.

Can you give repro instructions?
I'm not 100% sure what you mean when you say the files are saved in a non-UTF encoding, given that without a BOM (which the files don't have) or any special chars (which the generator doesn't itself put in the files), the UTF-8 encoding of the file is bitwise-identical with ASCII. As such, I'm not clear how it's meaningful to say the files are in one encoding or another.
No doubt you are correct that there's something for us to fix here - I'm just not sure what, so would appreciate specific steps that show something going wrong! Thanks.

In the absence of more info, I'll close this, but if anyone is able to provide repro information, please let us know!

Looks like it's rather up to VS2015.
However, to reproduce it, you need the following (Win 10 anniversary update x64, VS2015 community edition, Windows 1251 is set as system default for non-UTF):

generate the Angular2 project using yo aspnetcore-spa
try to edit e.g. the Startup.cs file with Notepad++. It shows that the file is in UTF8 encoding.
open the generated .xproj file with VS2015
open Startup.cs from within VS2015, add some Cyrillic chars, save the file
open Startup.cs with Notepad++ - it shows that file is in Windows 1251 encoding
save Startup.cs from VS2015 setting the encoding to UTF8 - now everything works right.


Allow filter value in ".call" invocation for VectorDBQAChain

extract "filter" key from ChainValues passed to ".call"
pass filter value to "similaritySearch" call
if user does not supply "filter" value it remains "undefined" as before
if the shape of filter does not conform to value expected by VectorStore, error returns as expected

Thank you! Added a small integration test and ran formatting.


Collapsible broken in Tab

This Collapsible is contained in a Modal, under normal circumstances, it should be displayed like this:

but, if i put him in a tab: (it's in the EnvList component)

Hey, this is due to how tabs are coded in papercss, the input used to toggle tabs display is targeted through tag name rather than class name or another more specific selector, I'll try to make a patch for it in papercss.

Could you share your code? I couldn't reproduce.


load base split: dynamic thresholds

The load base split is currently controlled using the qps threshold and byte threshold, but these two parameters are manually specified and may not behave well in some scenarios and need to be manually adjusted down.
So the plan is to make these two thresholds dynamic, with two options.

estimate based on the percentage of store, e.g. set the threshold to one percent of store qps or byte
a case-specific estimation, where the region is split only if the sum of the qps gains from the split is greater than the pre-split one

set the threshold to one percent of store qps or byte

Who set this threshold? From the user's pespective it is better not add new options for user.

set the threshold to one percent of store qps or byte

Who set this threshold? From the user's pespective it is better not add new options for user.

Like the current configuration, it will be a default value


More PR labels

This PR adds a couple labels to PRs:

mergeable
conflicts

Could this be optimised so that we only add the label if it doesn't already have it (considering GH API rate limits might come into play at some point..?)

@pchauncey do you prefer any specific colors for these labels?

@amoffat You pick!   Something "good" and something "bad"?

Nice, those are great.  Thanks!

@hongaar  I like the idea of optimizing, but I'm going to have to save that for another PR.  I need to figure out how to extract the labels from the pr object before or during relabel, etc.

@pchauncey would this work?
if "mergeable" not in list(map((lambda x: x["name"]), pr["labels"])):
    label_pr(api, urn, pr, "mergeable")

This PR brought a lot of chaos =)

As is only appropriate.


[FLINK-26570][statefun] Remote module configuration interpolation

[Major] I couldn't find a test that confirms the correct order of merging the config sources. A test that checks if comand line parameters override env variables, for instance. Did I missed this test?

[Major] I'm wondering what's the behior of the feature when the config value for the placeholder is missing. Are we ignore it? Do we throw an exception?

[Major] I'm wondering what's the behior of the feature when the config value for the placeholder is missing. Do we ignore it? Do we throw an exception? Would be good to have a test for this case.

Now we throw. Thanks.


Don't wrap singleton ir.Values with tuples during HLO lowering.

In general a JAX value might correspond to multiple HLO values, which is why the HLO lowering represents each value ad a tuple of zero or more ir.Values. However, the common case is that there is exactly one value, and almost all such lists are singletons.
To reduce the number of singleton list and tuple objects allocated during MLIR lowering, instead represent singleton values as unwrapped ir.Values, and only use a tuple if there is not exactly one ir.Value backing a JAX value.

This has been a constant source of mistakes for me: where to add/remove the tuples. Thanks!


[Notebooks] small markdown fix in decode strategies

Description
Small fix in the markdown of the decoding strategies tutorial notebook
Motivation and Context
Greedy and beam search subsections were inverted

Thanks for spotting the typo!


Unable to create instance with Iam profile

I am getting below error-
ERROR: Fog::Compute::AWS::Error: UnauthorizedOperation => You are not authorized to perform this operation. Encoded authorization failure message: ixPqZPsDYfQYC1KcpwE_QRNlBXtOO3affAg1twm5dfdVQ57J7aT6Pia98GLguc6z5Cnh-fcnnC1D2TdRc0eHYWAgihNgj362WL7S2WN-7aDvG84kMWHQzsPQ7-4esy1dJOX5B5I91mJv_KNFEeWZR9G32oZ7acsI3dgx69zHejHNCSnvcMaAhBAD8lck1rcJ9Ct6Bsjhltfhrvs5QUs2Wv5z1mMTVj7uFkfALsuhYQsjy6GqjpOUIe46S9cMIvKmYpMs3zsjHDCV86NmZPrCocMumDOtTTaUQJPpJAdMFrd27Nnksc6Hww9_HyJbpFihs1C2ODVjQl9gVCDlWiwTR81s96HXnX97OxZE5X4afBo-_h7bn0Inn9Qv7nEAsLkLY_dHJzdERjA
I am passing profile as --iam-profile bbc
Please help

@dilippanwar1, Please check if your --iam-profile is authorized for creating VM. You can check it from AWS console under IAM service for your profile. AmazonEC2RoleforSSM is policy which should be accessed from your profile.

Closing this issue now, hope above comment help you. Please feel free to re-open if error still persists.


gherkin: Cucumber-Ruby integration

Summary
Changes for the Cucumber-Ruby integration.
Details

[X] Provide an interface for passing the feature file content as a string. The testing of Cucumber-Ruby should not require that the test feature files are written to the file system. In version 5.x.x there is an interface for passing the feature file content as a string.
[X] Provide the possibility to set the default dialect for the gherkin parser (needed for the parsing of nested steps in Cucumber-Ruby).
[ ] Implement the --dialects options correctly in the go binary, so that gherkin/ruby/lib/gherkin/gherkin-languages.json can be removed.

Motivation and Context
See Details.
How Has This Been Tested?
The automated test are updated to cover this functionality
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue).
[X] New feature (non-breaking change which adds functionality).
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected).

Checklist:

[X] I've added tests for my code.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.

Now only the proper implementation of the --dialects option in the go binary is needed.

I updated the API a little to conform with the API in Java/JavaScript. Use this instead:
messages = Gherkin.from_paths(paths)


feat: Improve route()

What is this PR?
This PR implements the following.

Reduce side-effects of route() calls on the parent app

https://github.com/honojs/hono/compare/main...usualoma:hono:feat/basepath-2?expand=1#diff-8ac13809c9886e994d1db33943de82df4d6c5d88b73fd0270c0189804ff565c2R182

Support nested route() calls

https://github.com/honojs/hono/compare/main...usualoma:hono:feat/basepath-2?expand=1#diff-8ac13809c9886e994d1db33943de82df4d6c5d88b73fd0270c0189804ff565c2R179-R180

What will this PR allow us to do
route() can be used to specify the base path.
const hono = new Hono().route('/api')
const api = hono.get('/search', (c) => c.jsonT({ ok: true }))
type AppType = typeof api

Why can't we specify our basePath in the constructor in this PR?
I also wrote the following code to try to be able to specify it in the constructor, but I just could not get it to infer correctly.
https://github.com/honojs/hono/compare/main...usualoma:hono:feat/basepath

I know that the following utility method can be prepared and used in place of new Hono in the same way as specifying it in the constructor.
export const hono = <E extends Env = Env, S = {}, BasePath extends string = ''>(
  init: {
    router?: Router<H>
    strict?: boolean
    basePath?: BasePath
  } = {}
) => {
  return new Hono<E, S, BasePath>(init as any)
}

However, I see no need for such a utility method, as it is short enough to be written as follows
const hono = new Hono().route('/api')

Hi @usualoma !
This is great! I also don't want to create a utility method like hono(). Looks good to me because using the existing route() method, two improvements have been made, and the types have been kept.
@yudai-nkt @ThatOneBro and others
What do you think about it?

Hi @yusukebe,
Thanks for the review.
I added two small refactoring commits and then denoify.

Ah, these have been cleaned up by refactoring. Good.

Looks good! Great work @usualoma , this is some pretty crazy Typescript magic you added

I'd say, this is exciting and I'd like to see it in, but I'm very curious to see if it can be cleaned up, basePath seems much more intuitive

Hi @boehs,
I get that "basePath is more intuitive."
But when we allow it to be specified in our constructor, the type is inevitably not well inferred.
In this PR, we only improve the behavior of route() without changing hono's API. And with the improved behavior of route(), route() can be used in the same way as specifying basePath.
In the future, if we find a better way to specify it in the constructor, we can rewrite it that way.
Even leaving the constructor discussion aside, I think this PR is a useful change, so I think it is a good idea to merge it first.
Other Ideas
If route() is not intuitive, it might be possible to create an alias to route().
const hono = new Hono().basePath('/api')

or
const hono = new Hono().under('/api')

But, well, I guess I don't need it.

Hi @boehs @usualoma !
I also hope to use basePath in the constructor, but it's impossible now, as @usualoma said (perhaps we can do it if we master TypeScript more and more). And we don't need an alias method for route().
This PR is a very good PR that improves route(). I'll merge this.


Logo

Hi. I am a graphic designer. I volunteer to design a logo for open source projects. I can design it for you to use it in the readme file. What dou you say?

Ok sure, show me what you got.
Can you incorporate the Moa bird?


Invalid JSON is unmarshaled correctly

Hello,
When attempting to Unmarshal something like so:
type Dog struct {
	Name  *string
	Color *string
	Age   *int
}

jsonStr := `
	{
 		 "name" : "Buddy",
		"color" : "brindle",
		"age": 5,
	}`

var dog Dog
payload := &dog
unmarshalErr := ffjson.Unmarshal([]byte(jsonStr), payload)

And generating a type to match this struct, ffjson will happily unmarshal the json even though it has an extra comma after "age":5,
It would seem to be in violation of the following test in: tests/ff_obj_test.go
func TestInvalidTrailingComma(t *testing.T) {
	testExpectedError(t,
		&fflib.LexerError{},
		`{"X":"foo",}`,
		&Xobj{})
}

Just curious if this should be regarded as a bug or expected?
Thanks in advance,
@deckarep

It is a bug -- as encoding/json would error, so should ffjson, we want to be a drop-in replacement in as many cases as possible.

Ok thanks for confirming @pquerna.  Additionally, the same thing occurs for arrays, i updated the example.

Confirmed the lexer is correct:
 [tok:left_bracket tok:string tok:colon tok:integer tok:comma tok:right_bracket tok:eof]


E2E tests: Allow running actor invocation and reentrancy tests outside of K8s

Changes the E2E tests only, no code changes.
Makes debugging easier since the tests can now be run with dapr run and no need to build new Docker images every time. Instructions are in the comment in the actor_invocation_test.go and actor_reentrancy_test.go files.
The same was already done a few weeks ago for the workflow test

/ok-to-test

/test-version-skew


Updated dependencies and example to support flutter_web

Title
Add support for flutter_web
Description
This PR adds support for flutter_web by pointing flutter dependencies at the flutter_web GitHub Repo and the appropriate packages.

Thank you!

Just an FYI that the Flutter community has unofficially adopted flutter_web as the branch name that indicates your package supports Flutter Web while in tech preview.


Capslock to escape has visible delay

Here's the relevant section in my private.xml. I have Seil map Capslock to F19, and I've made sure that Capslock is set to NoAction for all keyboards under Keyboard settings.
	<modifierdef>F19</modifierdef>
	<item>
		<name>F19 to F19</name>
		<appendix>(F19 to Hyper (ctrl+shift+cmd+opt) + F19 Only, send escape)</appendix>
		<identifier>private.f192f19_escape</identifier>
		<autogen>
			--KeyOverlaidModifier--
			KeyCode::F19,
			KeyCode::COMMAND_L,
			ModifierFlag::OPTION_L | ModifierFlag::SHIFT_L | ModifierFlag::CONTROL_L,
			KeyCode::ESCAPE
		</autogen>
		<block>
		 <modifier_only>ModifierFlag::F19</modifier_only>
		 <autogen>__BlockUntilKeyUp__ KeyCode::F19</autogen>
	 </block>
	</item>

When I just press Capslock, there's small delay before escape is registered. Do you know what might cause that? I've played around with all sort of different settings under Parameters, but nothing seems to help.

Try this see if it help.
<item>
  <name>F19 to F19</name>
  <appendix>(F19 to Hyper (ctrl+shift+cmd+opt) + F19 Only, send escape)</appendix>
  <identifier>private.f192f19_escape</identifier>

    <autogen>
        --KeyToKey--
        KeyCode::F19,

        KeyCode::COMMAND_L,
        ModifierFlag::OPTION_L | ModifierFlag::SHIFT_L | ModifierFlag::CONTROL_L
    </autogen>

    <autogen>
      __HoldingKeyToKey__
      KeyCode::KeyCode::F19,

      <!-- short press -->
      @begin
      KeyCode::KeyCode::ESCAPE,
      @end

      <!-- hold -->
      @begin
      KeyCode::F19,
      @end

      Option::NOREPEAT,
    </autogen>
</item>

The __BlockUntilKeyUp__ introduces delay.
Remove it if you don't need it.


[2.0.0] Tests fail with RepresenterError during build

Hi,
When running the tests during the build of the package, many of them fail with a RepresenterError:
   dh_auto_test -O--buildsystem=pybuild
I: pybuild base:217: cd /build/python-asdf-2.0.0/.pybuild/cpython3_3.6_asdf/build; python3.6 -m pytest
============================= test session starts ==============================
platform linux -- Python 3.6.5, pytest-3.3.2, py-1.5.3, pluggy-0.6.0
rootdir: /build/python-asdf-2.0.0, inifile: setup.cfg
plugins: remotedata-0.2.1, openfiles-0.3.0, doctestplus-0.1.3, arraydiff-0.2
collected 272 items / 2 skipped

asdf/asdf.py .                                                           [  0%]
asdf/stream.py F                                                         [  0%]
asdf/util.py ...                                                         [  1%]
asdf/commands/tests/test_defragment.py FFs                               [  2%]
[...]
=================================== FAILURES ===================================
_________________________ [doctest] asdf.stream.Stream _________________________
012     Examples
013     --------
014     Save a double-precision array with 1024 columns, one row at a
015     time::
016
017          >>> from asdf import AsdfFile, Stream
018          >>> import numpy as np
019          >>> ff = AsdfFile()
020          >>> ff.tree['streamed'] = Stream([1024], np.float64)
021          >>> with open('test.asdf', 'wb') as fd:
UNEXPECTED EXCEPTION: RepresenterError("cannot represent an object: {'streamed': Stream([1024], float64, strides=None), 'history': {'extensions': []}, 'asdf_library': {'
Traceback (most recent call last):

  File "/usr/lib/python3.6/doctest.py", line 1330, in __run
    compileflags, 1), test.globs)

  File "<doctest asdf.stream.Stream[4]>", line 2, in <module>

  File "/build/python-asdf-2.0.0/.pybuild/cpython3_3.6_asdf/build/asdf/asdf.py", line 1059, in write_to
    self._serial_write(fd, pad_blocks, include_block_index)

  File "/build/python-asdf-2.0.0/.pybuild/cpython3_3.6_asdf/build/asdf/asdf.py", line 820, in _serial_write
    self._write_tree(self._tree, fd, pad_blocks)

  File "/build/python-asdf-2.0.0/.pybuild/cpython3_3.6_asdf/build/asdf/asdf.py", line 781, in _write_tree
    yamlutil.dump_tree(tree, fd, self)

  File "/build/python-asdf-2.0.0/.pybuild/cpython3_3.6_asdf/build/asdf/yamlutil.py", line 336, in dump_tree
    tags=tags)

  File "/usr/lib/python3/dist-packages/yaml/__init__.py", line 188, in dump_all
    dumper.represent(data)

  File "/usr/lib/python3/dist-packages/yaml/representer.py", line 26, in represent
    node = self.represent_data(data)
  File "/build/python-asdf-2.0.0/.pybuild/cpython3_3.6_asdf/build/asdf/yamlutil.py", line 78, in represent_data
    node = super(AsdfDumper, self).represent_data(data)

  File "/usr/lib/python3/dist-packages/yaml/representer.py", line 57, in represent_data
    node = self.yaml_representers[None](self, data)

  File "/usr/lib/python3/dist-packages/yaml/representer.py", line 229, in represent_undefined
    raise RepresenterError("cannot represent an object: %s" % data)

yaml.representer.RepresenterError: cannot represent an object: {'streamed': Stream([1024], float64, strides=None), 'history': {'extensions': []}, 'asdf_library': {'name'

/build/python-asdf-2.0.0/.pybuild/cpython3_3.6_asdf/build/asdf/stream.py:21: UnexpectedException
[...]

Build is done with Python 3.6, astropy 3.0, yaml 3.12 (Debian Buster/unstable).

Closing this since I'm pretty sure the underlying issue will be the same as #499.


Clarify whether /Zc:referenceBinding is affected by /permissive- or not

On /Zc:referenceBinding page, it's said that (https://docs.microsoft.com/en-us/cpp/build/reference/zc-referencebinding-enforce-reference-binding-rules)

The /permissive- compiler option implicitly sets this option

but on /permissive- page it's said nothing about it (https://docs.microsoft.com/en-us/cpp/build/reference/permissive-standards-conformance).

@k15tfu The product regularly outpaces the documentation. It's safe to assume that /permissive- sets every relevant option to standard conforming, unless explicitly specified otherwise, or if it requires an additional switch, such as /experimental. Any conformance option you'd like to turn off should be specified explicitly after the /permissive- option on the command line, even if it's not mentioned in the /permissive- documentation as being set.

@corob-msft,
I'm following an opposite goal, I want to do everything in accordance with the standard. Therefore I specify /permissive- and add every /Zc option that should be turned on explicitly.
So right now /permissive- page doesn't mention /Zc:referenceBinding option so it stays unclear whether should I pass it manually or not.

@k15tfu While as far as I know, there's no harm in adding all the /Zc conformance switches to the command line in addition to /permissive-, I wouldn't expect behavior changes as a result. The /Zc switches enable a subset of the behaviors enabled by the /permissive- switch, and are not a complete substitute. They exist primarily to enable backward-compatibility for source code that relied on some common Microsoft-specific compiler behaviors. The /permissive- switch also enables other conformance behaviors that do not have /Zc switches. These other conformance behavior changes often express themselves as new warning or error messages, including warnings that are off-by-default when /permissive- is not set, in code that relies on the non-conforming behavior.

Updates are live.

@corob-msft Thanks!


"TypeError: Cannot read property '!requirejs' of undefined" when using requirejs plugin

I'm starting to use tern in Emacs. However, once I added "requirejs" to the "plugins" part of my .tern-project file, I get the following error whenever Emacs tries to communicate with tern:
Request failed: Could not start Tern server

/usr/local/lib/node_modules/tern/plugin/requirejs.js:219
    var cx = infer.cx(), interfaces = cx.definitions[data["!name"]]["!requirej
                                                                   ^
TypeError: Cannot read property '!requirejs' of undefined
    at Array.postLoadDef [as 0] (/usr/local/lib/node_modules/tern/plugin/requirejs.js:219:68)
    at runPasses (/usr/local/lib/node_modules/tern/lib/def.js:424:60)
    at doLoadEnvironment (/usr/local/lib/node_modules/tern/lib/def.js:451:5)
    at Object.exports.load (/usr/local/lib/node_modules/tern/lib/def.js:461:7)
    at /usr/local/lib/node_modules/tern/lib/infer.js:722:13
    at Object.exports.withContext (/usr/local/lib/node_modules/tern/lib/infer.js:732:18)
    at new exports.Context (/usr/local/lib/node_modules/tern/lib/infer.js:706:13)
    at Object.signal.mixin.reset (/usr/local/lib/node_modules/tern/lib/tern.js:129:17)
    at Object.exports.Server (/usr/local/lib/node_modules/tern/lib/tern.js:111:10)
    at startServer (/usr/local/lib/node_modules/tern/bin/tern:137:16)

Not sure what's happening here.
The following is my .tern-project file:
"titanium" is a customized file under project root.
{
  "libs": [
    "titanium",
    "underscore",
    "ecma5",
    "jquery"
  ],
    "plugins": {
        "requirejs": {
            "baseURL": "./Resources",
            "paths": {}
        }
    }
}

It seems that you wish to use titanium https://github.com/x-cray/titanium-ternjs/blob/master/generate.py and the script seems not to generate !name.
Try to remove titanium in your libs defintion of your tern-project.

Interesting. Actually, if I remove "requirejs" from "plugins", then Tern runs successfully, also providing auto-completion for all things under Titanium namespace. However, if I remove "titanium" from "libs", Tern also could be started succesfully...
If I have to choose one of them then I'd stick with "titanium" which provides auto-completion. But why would they conflict though.

The bug is in the titanium defs though. You can just fix the titanium json file to include a "!name": "titanium" property (in the top-level object) and preferably submit a bug report to wherever it came from to make it spit out a valid json def file.

I see. That fixed bug. Thank you.


2 packages had stderr output: ur_kinematics ur_robot_driver

When Build the Workspace through colcon build --symlink-install
2 packages had stderr output: ur_kinematics ur_robot_driver
is showing as result.
How to solve it.

Package 'llm_bringup' not found: "package 'llm_bringup' not found

Package 'llm_bringup' not found: "package 'llm_bringup' not found

Please Check your workspace env settings

When Build the Workspace through colcon build --symlink-install

2 packages had stderr output: ur_kinematics ur_robot_driver

is showing as result.

How to solve it.

"ur_kinematics" and "ur_robot_driver" are likely related to your UR robotic arm and are unrelated to "ros-llm". You may need to reorganize the contents of your workspace.

Thanks for your support. However, I have checked and tried. This still not work.
What should I do to add the env settings.

It seems that your ros workspace has not been built and the llm_bringup function package cannot be found. This should be caused by your bash environment settings. Please refer to this blog https://blog.csdn.net/m0_56661101/article/details/134098153?spm=1001.2014.3001.5502


Off by one

Per @vittorioorlandi

Fixed the definition of early stopping with respect to PE frac. Previously it was comparing to the previous iteration PE when it should be comparing to the PE at baseline.
Accordingly, the PE at the 0'th iteration is always the PE using all covariates — even if we make no exact matches.

Have everything starting at 0, with a completed iteration corresponding to successfully attempting matching.
Updated defaults for pre_dame and early_stop_iterations; they are now float(‘inf’). This makes sense if they are supposed to be the number of iterations before something happens; if they are infinite they never happen (ie never early stop because of iteration and never switch to dame).

Updated some notebooks to reflect the above.

Eliminated the database folder and corresponding test folder for it -- this is temporary to get it up on PyPi with all the recent updates but will be put back shortly.

This takes care of https://github.com/almost-matching-exactly/DAME-FLAME-Python-Package/issues/47 and https://github.com/almost-matching-exactly/DAME-FLAME-Python-Package/issues/48 without breaking https://github.com/almost-matching-exactly/DAME-FLAME-Python-Package/issues/32 or https://github.com/almost-matching-exactly/DAME-FLAME-Python-Package/pull/33

Also @vittorioorlandi updates documentation webpage to reflect these changes.


[Story] Add unit test for getting a single organization

What projects is this story for?
OpenChallenges
As a user, I want
NA
Description
The goal is to enable unit testing in the organization service. A single unit test is required to demonstrate that the unit testing framework works.
Acceptance criteria

The endpoint to get a single organization is covered by a unit test

Tasks

[ ] Configure the organization service to support unit testing
[ ] Add a unit test for the endpoint that returns a single organization

Anything else?
An example is available in the PR that added unit testing to the image service.
Have you linked this story to a GitHub Project?

[X] I have linked this story to a GitHub Project and set its metadata.

Added to Sprint 23.06

Return to Backlog

The Organization Service module had no tests for OrganizationService.java.

Additional Unit Tests added to improve coverage. Sonar will provide updated coverage once PR created.
Current coverage shows:

PR #2507 covers the changes implemented.


Interrupt based on work done/concept of "ticks"

I have a rather strange use-case. I run a few goja instances in parallel, along with some other goroutines.
This can cause CPU contention. For me, the timeouts are to ensure injected code isn't running an infinite-loop, rather than having a fixed wall-clock bound.
Under high load though, a goja VM might not get around to doing much, thus running out the Wall Clock allotted time.
I'm happy to do the work, but I wanted to field the idea of "ticks". Each time Goja does some work, a tick is updated. The tick doesn't have to be precise, or meaningful, so long as it is monotonic and increments itself periodically as things get executed.
It would do two things:

I would be able to measure the inner-JS for ticks and compare two implementations which can report into performance metrics. This would help identify which scripts can be improved and when they are improved, that they really did improve.

I would be able to set an interrupt after "ticks", so under contention or maybe because the code is blocked on some input, it wouldn't expire due to the wall clock. Yet, I can guard against infinite loops.

I think it could be useful in some cases, so I will consider merging this as long as it does not break existing API, implemented as an option (disabled by default), and when disabled does not have any performance impact.

@archisgore - curious, did you implement this?

Sorry no, never did. We moved away from this and in the future, likely to use a WASM runtime to host 3rd party code. Closing the issue.

@archisgore yes makes sense. Thanks!


Inline includes cleanup

Codecov Report

Merging #187 into master will decrease coverage by 0.03%.
The diff coverage is 42.1%.

@@            Coverage Diff             @@
##           master     #187      +/-   ##
==========================================
- Coverage   51.66%   51.63%   -0.04%
==========================================
  Files          72       72
  Lines       15723    15731       +8
==========================================
- Hits         8124     8123       -1
- Misses       6555     6562       +7
- Partials     1044     1046       +2

Impacted Files
Coverage Δ

vm/datemath.go
58.82% <14.28%> (-3.68%)
:arrow_down:

vm/vm.go
50.48% <46.15%> (-0.13%)
:arrow_down:

expr/include.go
72.09% <50%> (-3.52%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e8b8a53...a64a815. Read the comment docs.


Update ESLint rules

The ESLint rules need to be updated:

[ ] Add no-multi-spaces (default mode)
[ ] Add eqeqeq (default or "smart" mode)

These changes may require not auto-fixable changes to the codebase.

Closed by #45


Using regroup with main_menu

I'm struggling to regroup the main_menu with regrouping into two separate menus. Those with children and those without. Is there a way to do this that I'm not seeing?

@davemerwin I'd love to help, but I'm not currently understanding what it is you're trying to achieve here. Could you provide a bit more info?

In case anyone is interested here's how you can do this:
{% load menu_tags wagtailcore_tags %}
{% regroup menu_items by has_children_in_menu as items %}


transport: Windows + HTTPS issues

What happened?
When using the git-remote-gittuf transport on Windows with the default credential manager (where there is a credential for github via HTTPS set up by github CLI), the transport doesn't work correctly. On fetches, the transport hangs on stateless-connect. On pushes, the transport successfully creates and transmits the objects, but then the transport does not terminate. This difference in behavior may be down to the differences in git protocol and underlying assumptions, though it is strange that in the case of a push, the credential manager works correctly and the push actually happens.
Relevant log output
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct

https://github.com/Microsoft/Git-Credential-Manager-for-Windows/wiki/How-the-Git-Credential-Managers-works

This wasn't a credential manager issue but (more boringly) issues with buffers and newlines. Fixed in #570 and #569


⚠ Bofrost.nl has degraded performance

In 8b1b071, Bofrost.nl (https://www.bofrost.nl) experienced degraded performance:

HTTP code: 200
Response time: 1233 ms

Resolved: Bofrost.nl performance has improved in e0663e8.


t_mapping: 0.1.2-1 in 'kinetic/distribution.yaml' [bloom]

Increasing version of package(s) in repository t_mapping to 0.1.2-1:

upstream repository: https://github.com/mitre/t_mapping.git
release repository: https://github.com/tbostic32/t_mapping-release.git
distro file: kinetic/distribution.yaml
bloom version: 0.10.1
previous version for package: null

Change made, do I need to create a new release that includes the license in the package.xml?


generic app_ids chip component

It's been copy pasted 3 times now, let's refactor it

Issue migrated to our-city-app/plugin-mobicage-control-center#5


The parser get wrong key to table from parsing..

Hi, when parsing html with inserted php code, the parser get this result:
example:
Parsed file:
(script tag with contents: )
<EMAIL_ADDRESS>data-semver="1.3.10" src="
Get json:
{
"">": "",
}
Its because of translate word?
Maybe some regexp can be mofified?
Thank you.

Hey @mikethejet.
I clean all issues, so for yours, the problem is not reproducible since the commit e3ce688419e2b057f501f5ca0605e5e7ac9c0dce.
Enjoy ;)


Selections should be read by screenreader both in client and mashup.

Selections should be read by screenreader both in client and mashup.  At his time the number of selections made are read in the mashup, but not in the client. Maybe it would be good to read upp what is selected as well.

Closing this since we added a new issue from A360


Discovery Issus

SUMMARY
After activate the node and set port to 8050 the device can't be found by alexa (from android mobile app)
Currently i run node-red under windows for testing purpose
When i call the 8050 port on localhost it says
"Cannot GET /"
UPNP Scanner even cannot get the device informations
ECHO DEVICES
Echo Dot (currently offline)
Bose Soundbar 700 (active)
MODULE VERSION
node-red v.1.2.7
node.js 14.151
CONFIGURATION

CONSOLE OUTPUT
C:\Windows\system32>node-red
6 Jan 22:17:30 - [info]
Welcome to Node-RED
6 Jan 22:17:30 - [info] Node-RED version: v1.2.7
6 Jan 22:17:30 - [info] Node.js  version: v14.15.4
6 Jan 22:17:30 - [info] Windows_NT 10.0.18363 x64 LE
6 Jan 22:17:30 - [info] Loading palette nodes
6 Jan 22:17:31 - [info] Dashboard version 2.26.1 started at /ui
6 Jan 22:17:31 - [info] Settings file  : \Users\IvoGutleben.node-red\settings.js
6 Jan 22:17:31 - [info] Context store  : 'default' [module=memory]
6 Jan 22:17:31 - [info] User directory : \Users\IvoGutleben.node-red
6 Jan 22:17:31 - [warn] Projects disabled : editorTheme.projects.enabled=false
6 Jan 22:17:31 - [info] Flows file     : \Users\IvoGutleben.node-red\flows_GS-RYZEN-IG.json
6 Jan 22:17:31 - [info] Server now running at http://<IP_ADDRESS>:1880/
6 Jan 22:17:31 - [warn]

Your flow credentials file is encrypted using a system-generated key.
If the system-generated key is lost for any reason, your credentials
file will not be recoverable, you will have to delete it and re-enter
your credentials.
You should set your own key using the 'credentialSecret' option in
your settings file. Node-RED will then re-encrypt your credentials
file using your chosen key the next time you deploy a change.
6 Jan 22:17:31 - [info] Starting flows
6 Jan 22:17:31 - [info] Started flows
6 Jan 22:17:31 - [info] [loxone-miniserver:e297048b.e7ccc8] Miniserver connected (<IP_ADDRESS>:80) using Token-Enc
6 Jan 22:17:31 - [info] [loxone-miniserver:e297048b.e7ccc8] got structure file 2021-01-05 19:35:23
STEPS TO REPRODUCE
Install node-red under windows
start node-red
activate alexa-echo modul
add echo hub to flow
publish
EXPECTED RESULTS
alexa should find the device behind the hub
ACTUAL RESULTS
alexa don't find the device behind the hub

New Echo devices could discover Amazon Echo Hub only on port 80


VMs as part of a run show up with "Unknown" as run identifier

In the dashboard VM section, only the orchestrator VMs are tied to a particular run.  Other machines part of the run show up as unknown.  The run IDs need to be provided for any VM tied to a deployment.

This doesn't apply anymore.


Is it possible to filter calls coming from a specific domain?

So there some web routes that I don't require the user to be authenticated but I still don't want to be loaded from any other place but my domain.
Is it possible to do so with this firewall?

Not by default but you can send such a PR.


[Q42.HueApi] [Version=<IP_ADDRESS>] Could not create SSL/TLS secure channel while calling HueBridgeDiscovery::CompleteDiscoveryAsync

Hi all,
I am using HueBridgeDiscovery::CompleteDiscoveryAsync to discover my HUE bridge. Minimum code is as follow:
public IEnumerable<LocatedBridge> ScanAvailableBridge()
        {
            Trace.WriteLine("Start scanning Hue bridges...");

            m_bridgeAvail.Clear();
            Task<IEnumerable<LocatedBridge>> bridges = null;
            m_status = HueStatus.SCANNING;
            int count = 0;

            try
            {
                //Run http, MDNS, SSDP, and Net Scans in parallel (API V<IP_ADDRESS>)
                bridges = ScanCompleteBridgeAsync();
                count = bridges.Result.Count();
            }
            catch (AggregateException e)
            {
                Trace.WriteLine("Scan abort. Due to " + e.Message + ".");

                foreach (var errInner in e.InnerExceptions)
                {
                    Trace.WriteLine("Scan abort. Due to " + errInner);
                }
            }
            GetAvalibleBridge(bridges.Result);
            return bridges.Result;
        }

private async Task<IEnumerable<LocatedBridge>> ScanCompleteBridgeAsync()
        {
            return await HueBridgeDiscovery.CompleteDiscoveryAsync(TimeSpan.FromSeconds(5), TimeSpan.FromSeconds(30));
        }

However, I recevied the following error message from my AggregateException e:
System.Net.Http.HttpRequestException: An error occurred while sending the request. ---> System.Net.WebException: The request was aborted: Could not create SSL/TLS secure channel. at AuraHueService.HueController.d__31.MoveNext()
My question is about "Could not create SSL/TLS secure channel." Can someone please elaborate on this SSL/TLS secure channel issue? Thanks very much.

I'm unable to reproduce this. It's probably caused by a device on your network.
HueBridgeDiscovery scans your network and does a http request to devices to check if it is a Hue Bridge.
Maybe, during this http request, it throws the SSL error becauses the device does not have a valid SSL certificate.
The best option is to use the full source code of this project and debug your issue. If you can locate the problem, I'm happy to include a fix.


core-js dependency breaks when using nuxt in monorepo with another package that's using newer core-js

Version
v2.9.2
Reproduction link
https://github.com/kabalage/nuxt-core-js-problem
Steps to reproduce
> yarn install
> cd ui/landing
> yarn run dev

What is expected ?
I expect that @nuxt/babel-preset-app would use the core-js version it needed. (node_modules/@nuxt/babel-preset-app/node_modules/core-js)
What is actually happening?
It resolves to the core-js version installed by other packages. (node_modules/core-js)
This results in errors like:
These dependencies were not found:

* core-js/modules/es6.array.find in ./.nuxt/client.js
* core-js/modules/es6.array.iterator in ./.nuxt/client.js
* core-js/modules/es6.date.to-string in ./.nuxt/utils.js
* core-js/modules/es6.function.name in ./.nuxt/client.js
...

Additional comments?
We have multiple ui projects for one app and others are using the newer 3.x.x version of core-js. We implemented our landing page using nuxt because it supports static site generation but have run into this problem when trying replace the old landing page implementation in our monorepo managed by yarn workspaces.
I'm not sure what is happening in nuxt, I would like some insight if it is something fixable with configuration.

This bug report is available on Nuxt community (#c9710)

If you search on https://nuxtjs.org for core-js you will find these tips about core-js from the release log of v2.6.0: https://nuxtjs.org/guide/release-notes#core-js

Unfortunately, we can't do anything for this issue for supporting multiple core-js versions. The reason is that it is not @nuxt/vue-app picking core-js but webpack which prefers main node_modules... We tried using aliases but it was not fully functional as core-js 2/3 structures are different...
BTW OH! I just thought about a newer idea to make webpack searching for @nuxt/vue-app/node_modules first! Will try to see how it works.
For now as @pimlie mentioned it would be better to follow core-js instructions and upgrading to 3.

Thank you for your responses. I could solve the core-js issue using @pimlie 's suggestion but unfortunately I encountered webpack loader problems afterwards which similarly may have been caused by the different package versions used by the new nuxt app and the rest. It could not load ./.nuxt/components/nuxt-error.vue in ./.nuxt/index.vue or something similar. (I'm writing this from memory, sorry...) If you're interested in the details, I could check again.
I ended up nohoist-ing the nuxt app package so yarn install will install all its dependencies locally under its own directory which completely solved the dependency issues. Maybe using hoisting for every package is not worth the hassle and I understand why these kinds of problems can't always be fixed.

Same problem. I did what he said @kabalage.
rm -rf node_modules && yarn
This worked for me.

I have the same problem but rm -rf node_modules && npm i didn't work for me. Is there any other workaround for this?

I have the same problem but rm -rf node_modules && npm i didn't work for me. Is there any other workaround for this?

Do this:
rm -rf node_modules && yarn
rm -rf yarn.lock
npm run dev

It is caused due to nohoist being done by npm

I have the same problem but rm -rf node_modules && npm i didn't work for me. Is there any other workaround for this?

Do this:
rm -rf node_modules && yarn
rm -rf yarn.lock
npm run dev

It is caused due to nohoist being done by npm

I'm sorry, this didn't work for me.


The game opens and then immediately closes

Describe your problem here.
I tried to do lime test Windows to compile the source code and it made me wait for about ten minutes. Then the game opened but it immediately closed and I don't know how to proceed.
Are you modding a build from source or with Lua?
Source
What is your build target?
Windows x64
Did you edit anything in this build? If so, mention or summarize your changes.
No response

uh idk, try use only english letters in folder names, cuz it crashes with it

@TheLeerName nope it's all in english. I already checked

try clearing save data in AppData/Roaming

i'm having the same problem.


Add support for login via web

We have a few login mechanisms that we're unlikely to want to build into the app natively (both corporate SSO type things like Apache REMOTE_USER and things like GitHub auth).
To support these more unusual login flows, I think maybe we should support "login via web", where basically the app logs into the Zulip website using a web authentication flow, but then rather than loading the website, it instead could just grab a credential and pass it back to the app.
It will likely require some server changes to support this (mainly either just supporting the redirect-at-the-end piece to get an API key), so probably best for whoever works on this to have a working Zulip development server and familiarity with our backend.

Do we need to do this?
As we are moving towards React Native app so What do you suggest ??

Yeah I think this is a sufficiently marginal feature that we should just skip it.  We just implemented this feature in the RN app.


Adds tests for Distribution::Hash

And sister module, CompUnit::Repository::Distribution, which was not
tested either and seems to be part of the spec. I have chosen the
directory which fitted the best, but it might need to be moved
somewhere else.
This closes #442.
Also: Adds emacs backup files to .gitignore :see_no_evil:

Distribution implementations are not ready to have their own roast tests in roast. For the most part they are already tested their primary consumer -- https://github.com/perl6/roast/blob/master/S11-repository/curli-install.t ( which this test is mostly copied from ). As such most things required by a Distribution are part of the curli-install.t test already.

Seeing it now, wouldn't it make more sense if I just added a few lines to curli-install.t instead of creating a new file?

Yes. That is what I suggested here as well: https://github.com/perl6/roast/issues/442#issuecomment-401810363


Add Pods Yield

Revision checks

[x] Your Safe App include a manifest.json file at the root with the required data
[x] The app can be loaded as a custom Safe App in the Apps section of https://gnosis-safe.io/app
[x] The app auto-connects to the Safe
[x] You are able to trigger and execute one transaction with a Safe
[x] RPC requests are optimized (not triggering many requests in a very short time period)

Name/Description
Add Pods Yield app
Type

New addition

Compatible Networks

- Mainnet

Code for review

The frontend is closed source., we can add you to the repo if you want it. The contracts are open-sourced and you can find them here:
https://github.com/pods-finance/yield-contracts
IPFS hash/App URL
https://app.yield.pods.finance
https://yield.ipfs.pods.finance/
Desired date
any time

@Robsonsjre hey! we are checking your Dapp!
Could you add me to the frontend repo so I can take a look at it?
Thank you!

Hi @dasanra. The reason to check the frontend is to see if we are making a lot of clients' RPC requests in parallel, right?
If that is the reason, our frontend doesn't handle RPC logic (only for signing transactions). This is the architecture that we are currently using:

If there is another reason why you want to check the frontend code, tell me and I can check with my team.

@Robsonsjre hey!
We are having trobules with the app. Is not automatically connecting to the Safe, so wanted to also do a check on how you implemented the integration to give more feedback.

Hey, since we haven't received an update in almost 2 months, we're closing this issue. Please feel free to create a new one if you want us to take a look again


[2.x] Laravel 9 support

idea: php 8.1 as well?

idea: php 8 as well?

PHP 8 is already supported, do you mean dropping support under 8?

Yes (wouldnt mind making a pr adding as much type casting as possible :))

This time will come, but it is still too early to drop PHP 7, so that won't happen in Twill 3.

We can think about pushing this forward mid 2022, so that we support PHP 7 until 28 Nov 2022 which is the EOL for PHP 7.4.

https://twitter.com/driesvints/status/1479004201774723073?t=h4272DRUPHa4e7Vw70o8Mw&s=19

A beta has been tagged!
https://github.com/laravel/framework/releases/tag/v9.0.0-beta.1

Made progress on this and submitted 2 support PRs to our dependencies:

https://github.com/Astrotomic/laravel-translatable/pull/261

https://github.com/cartalyst/tags/pull/42

Hey @ifox I made this target the newly created 3.x branch.
I cleaned up the PHP versions to >= 7.4 and added 8.1, then removed old laravel versions, but of course now it conflicts.
could you check which is correct?
Also, I think we can then go ahead and merge this into 3.x and add tasks for further actions to perform?
This will also allow us to merge other 3.x features.

Hey @ifox if you could have a look today that would be nice :).

Hey @ifox if you could have a look today that would be nice :).

Will do.

Astrotomic/laravel-translatabel is now ok

Hey @ifox what do you think of moving this forward but add a disclaimer to the changelog that we, for now, depend on a fork for tag and update it as soon as there is a stable version?

I had
Call to undefined method League\Flysystem\AwsS3V3\AwsS3V3Adapter::getClient() (View: /Users/rob/Sites/9-twill/twill/views/layouts/dashboard.blade.php)

On a fresh install, so I think this needs https://github.com/area17/twill/pull/1414

I have one concern here.
On a Laravel 8, Twill 2.x setup, all I have to add to my .env is:
MEDIA_LIBRARY_ENDPOINT_TYPE=local
MEDIA_LIBRARY_IMAGE_SERVICE=A17\Twill\Services\MediaLibrary\Glide

However, with this branch I get the following error with this config:
Error retrieving credentials from the instance profile metadata service. (cURL error 7: (see https://curl.haxx.se/libcurl/c/libcurl-errors.html) for http://<IP_ADDRESS>/latest/meta-data/iam/security-credentials/) (View: /Users/rob/Sites/9-twill/twill/views/layouts/listing.blade.php)

What I then have to do is also add to my .env:
FILE_LIBRARY_ENDPOINT_TYPE=local

I feel that this is somehow a regression, but nothing in the changes explains this.

This pr is fine as it is, the error above is due to misconfiguration so if all is configured well there should be no issue.

Found one bug with crops, still trying to figure that one out.

Hey @ifox I have a proposed fix for the cors issues that are occurring since 9.x
https://github.com/area17/twill/pull/1463


add listener message validation based on semantic

We have tcp listener, udp listener, api listener in the same Listener message ,
and I am adding another internal listener.
These listeners have their own feature set. e.g. connection_balance_config should not be used by udp listener, filter_chains should only be used by tcp listener (and quic ?), not all sock options are for udp, vice versa.
We don't have adequate validation for the above implicit rules for now.
It's probably good to warn the user upon receiving listener config, starting from "some fields are contradicting or ignored" and eventually reject inconsistent config.
WDYT?

Really the entire listener API is broken and in a perfect world needs to get redone, into essentially:

Common fields for all listener types
oneof of each actual listener type

If you want to start working towards this that would be great. cc @envoyproxy/api-shepherds

+1, this is one of those places that being able to make a more substantial refactor at proto level would be great, but I think we have to live with what we can in the constraints of v3.

@lambdai do you need any volunteers on this? I'm looking for task :)

@lambdai do you need any volunteers on this? I'm looking for task :)

Thank you! Go for it!

@soulxu do you still work for this?

@daixiang0 yea, I'm working on it.


cmd/build: Reduce duplicate code

Use function to generate build arguments
Copy makefiles also when building in a container
Move all helpers files (Makefiles) to folder and use embed.FS

/cc @blanquicet

Hi!
I am not sure to understand what is the final goal. Particularly, adding the buildCmd() is not really linked to remove the Makefiles from the image. Can you please share more insights on the goal?
Best regards.

The idea is to have the ig image build command self-contained without depending on Makefiles already present on the builder image.
Using the makefiles on the eBPF builder image has the following issues:

It introduces another dependency on the version of the image, if we change something on those makefiles, then the user will have to bump the version of the image they're using
introducing more helper files, like done in #3372, implies adding a lot of lines around


No default Key for root command

When running t2 root the default key is not set.

INFO Starting SSH Session on Tessel. Type 'exit' at the prompt to end.
Warning: Identity file undefined not accessible: No such file or directory.
Permission denied (publickey).

@Student007 are you passing in a key option? The default key is set when provision.js loads.

@Student007 are you passing in a key option? The default key is set when provision.js loads.

it seams it is not used if the opts.key is undefined. Means there is no path also if a key is present at ~/.tessel/id_rsa but this is necessary if you have multiple Tessels accessible by wifi and you do not use the --key option (because you like to use the default key).
I am suggesting three different solutions:
https://github.com/tessel/t2-cli/pull/502 => (handle a possible opts.key===undefined within controller.root)
https://github.com/tessel/t2-cli/pull/498 => (Override the default --key option with a default key path)
https://github.com/tessel/t2-cli/pull/501 => (Add a default path to the default --key option)
My preference would be #498 because it is a valid pattern to override default behaviors if necessary.
My second favorite would be #501 because other commands would ignore opts.key if they do not use it. And former this was discussed here
If no alternative solution is provided I would suggest to fix the issue by #502 because it simple catches a not defined opts.keyuntil a better solution will be given by deeper researches.
...please add your own ideas (by discussion).

@Student007 are you passing in a key option? The default key is set when provision.js loads.

it seams it is not used if the opts.key is undefined. Means there is no path also if a key is present at ~/.tessel/id_rsa but this is necessary if you have multiple Tessels accessible by wifi and you do not use the --key option (because you like to use the default key).
I am suggesting three different solutions:
https://github.com/tessel/t2-cli/pull/502 => (handle a possible opts.key===undefined within controller.root)
https://github.com/tessel/t2-cli/pull/498 => (Override the default --key option with a default key path)
https://github.com/tessel/t2-cli/pull/501 => (Add a default path to the default --key option)
My preference would be #498 because it is a valid pattern to override default behaviors if necessary.
My second favorite would be #501 because other commands would ignore opts.key if they do not use it. And former this was discussed here
If no alternative solution is provided I would suggest to fix the issue by #502 because it simple catches a not defined opts.keyuntil a better solution will be given by deeper researches.
...please add your own ideas (by discussion).

@rwaldron what is your preference - ask you because you did the lightweight implementation of t2 root ?

@Student007 I was able to recreate the issue today. I wasn't able to recreate it before because I used the ssh-add utility to add my .tessel folder to the path SSH looks when attempting to connect to a device - that's why it wasn't a problem that the key was undefined. I apologize for not taking a closer look at the code earlier.
I believe #512 is the simplest way of solving this problem. What do you think?

@johnnyman727

I apologize for not taking a closer look at the code earlier

OK - this explains why I couldn't follow your arguments and why I got angry about things you did I interpreted as bad game. :love_letter:

I believe #512 is the simplest way of solving this problem. What do you think?

I commented the code and created a new PR #514 including your tests due to the idea @rwaldron idea to take Tessel instead of Controller as base for the default parameter.


Can you please clarify what is the exported sitescript content ?

Is it list / doc lib / views / pages / webpart in the page / navigation ?
Thank you in advance

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 22ff33a5-2d76-efa5-5b18-1584e20195d8
Version Independent ID: 329529cc-8b5a-b71d-0a3a-f686947cab4b
Content: Get-SPOSiteScript (sharepoint-online)
Content Source: sharepoint/sharepoint-ps/sharepoint-online/Get-SPOSiteScript.md
Service: sharepoint-powershell
GitHub Login: @trent-green
Microsoft Alias: trgreen

@officedocsbot assign @yogkumgit

Hello @seaSide974
Thanks for your feedback.
In this other article from Docs, you can find the description of the contents of a Site Script
Hope this info helps you


Update font-inconsolata-for-powerline to latest

After making all changes to the cask:

[x] brew cask audit --download {{cask_file}} is error-free.
[x] brew cask style --fix {{cask_file}} left no offenses.
[x] The commit message includes the cask’s name and version.

Merged as d06c17537689e97ce404b2d83e04c7bf08efa054.


Extend size of :targeted elements

When the browser follows a link with a #fragment, it scrolls up or
down to put the element with the matching id attribute at the top
of the window. In rustdoc output, that's usually section headers.
docs.rs's floating top navbar hides that element. This PR extends
the height of the element the browser is scrolling to, in a way that
doesn't affect its visual appearance, so that it lands below the
navbar and is visible to the user.

It actually has already been fixed in #465. But for some reasons, the style.css file we get when browsing docs.rs is an older one...
cc @pietroalbini

@TooManyBees This should have been fixed in https://github.com/rust-lang/docs.rs/pull/496, can you take a look at the deployed site (e.g. https://docs.rs/parze/0.5.1/parze/also/trait.Also.html#tymethod.also) and make sure it looks good? If so I'll close this.

i guess it's already fixed then


Add in disabled and title, documented

Added a <circle-button> demo to /settings

Added disabled flag to circle-button directive
Added title parameter which gives you the option of showing a title below
Documented the directive

:+1:

:+1:


Hey! Drew, I have added a Java REST endpoint for you to build and check on your machine if it builds and runs succesfully

parsa has reorganized the quarkus folder located in /about-me-open/practice-code/about-me-service-in-java/code-with-quarkus
parsa has added the Java program into the directory for testing on Drew's machine
Drew will be merging  parsa's pr then pull the updates to build and run the project on his local machine

Did it work?

I remember now..that was an empty project but I cannot really recall if I added the extension for the REST API on Quarkus


[docs] mongoldb

I think there's some metadata missing—mongodb.metrics.commands.*—but let's add that in a followup PR.

Created https://github.com/DataDog/integrations-core/issues/552 to track the missing metrics in the catalog.


"Imprint" can't be configured with Platform API

we can configure "Imprint" with oscm-portal from "Customize texts" menu.
but we can't configure "Imprint" with Platform API.
could you make it possible to do it?

@toshihiro-shiino,
what is the business motivation behind this request, what is the expected benefit?

@mdehn,
We are offering marketplace called Management Portal in our service.
We have tried to automate the setup of this Management Portal by calling Platform API based on strong requests from customers to shorten the delivery time after receiving the request for setup.
However, there are some items that can be configured only via Portal and not via Platform API, so we are still not be able to implement the automated setup to the fullest extent.
This request is issued for the purpose of realizing complete automation of the setup and with business motivation of reduced delivery time and manpower.
In addition, other than the intention to resolve this issue, we believe the abilities offered by Web interface and by API should be identical.

This is a valid request, but currently there are no plans to extend the API with setup functionality.
If this functionality is urgent for you, you may consider a contribution to OSCM.

@mdehn,
This functionality is not urgent for us.
I appreciate it if you remember this issue when planning to extend the API.


Range rules

Range rules should be added to the website.

added with commit https://github.com/s-amundson/wpa_2p1/commit/0748f17f06dd6b2f96dd98f3e21fa6de8fd26aa4


Adds "demoURL" to package.json

Sites likes emberaddons.com and emberobserver.com will display a link to "demoURL".

Cool!

LGTM


Pogs interfaces

Addresses #62.
//cc @zombiezen, when you have the time.

Sorry, lost track of this with other stuff. I'll take a look tomorrow.

I think I can make the tests work with the table; I'll have to add a bit of logic to actually call testEcho when the interface is (expectedly) not nil. So it won't be checking for equality really, but that's OK I think.
I addressed your other two comments.

@zombiezen, I added interface stuff to the main table based tests. It's actually failing currentlly in a case where I'm trying to insert a slice of structs, where some of them have a nil client and some don't; the resulting message ends up with them all filled in.
I bet I know what's going on: the composite list wire format can't actually represent lists of structs that have different numbers of pointers filled in, so there's an extra pointer at the end of some of the structs that's being interpreted as a capability pointer. CapNProto doesn't have a notion of a nil/null pointer, just an "absent" one, so I don't think there's a "correct" way to encode a list like this.
I'm not sure how to handle this case besides just mentioning in the docs that you can't do that. Thoughts?

I bet I know what's going on: the composite list wire format can't actually represent lists of structs that have different numbers of pointers filled in, so there's an extra pointer at the end of some of the structs that's being interpreted as a capability pointer.

But there is a null pointer for capabilities, this happens all over the place.  It's the zero word.  That seems like a legitimate failure to me.  Any pointer type in Cap'n Proto can be null.

Ah, you're right -- I missed that reading the spec. I will dig a bit deeper then.

@zombiezen, fixed.

Thanks! Sorry this took a while, but I'm happy with how it turned out.

Cool. No worries about the delays; things come up.


Warning about :unneeded deprecation

Warning: Calling bottle :unneeded is deprecated! There is no replacement.
Please report this issue to the nektos/tap tap (not Homebrew/brew or Homebrew/core):
  /usr/local/Homebrew/Library/Taps/nektos/homebrew-tap/Formula/act.rb:9

@gsong
Please install act via homebrew-core brew install act


Solver outputs "Twin-width does not match"

Reproducible with the following instance.
p twwe 9 9
v 1
v 2
v 3
v 4
v 5
v 6
v 7
v 8
v 9
e 1 2 1
e 3 2 1
e 3 4 0
e 4 5 0
e 5 6 0
e 6 7 0
e 7 8 0
e 8 9 0
e 9 2 1

What causes this bug?

The input trigraph $G$ has a vertex (2) with red degree 3. The twin-width of $G$ is 3.
From reduction rules, vertex 1 is contracted into vertex 2, creating a trigraph $G'$.
Since $G'$ has twin-width 2, the solver returns twin-width 2.


WIP: Add solved/reconstructed fluxmap support.

This proof of concept adds an optional encoder and fluxsink that
runs after the image is written.
This currently exposes the config of the solvedEncoder, though I
think I ultimately don't want it to be exposed as part of the
config proto.
Another way to do this would be by extending the decoders and/or
directly reading their records. That is actually closer to what I
want in many ways, however those records would need to be
deduplicated from multiple reads, etc.
The ultimate goal is to exactly replicate the timing of the
original sectors, but with a stable clock, sectors reread if a
bad read happens, and garbage between sectors removed. This
requires extending the sector struct to have more information
than it currently holds.

Moved solved encoder creation into arch/.


virt-api: Fix race condition on streamer unit-test

Empty and close channels after each test run to avoid race condition.
Skip check test checking for closed write-only channels, as it is mutually exclusive with the -race-flag.

What this PR does
Before this PR:
Running make go-test fails with race condition found.
After this PR:
Running make go-test passes.

Fixes #8765
Why we need it and why it was done in this way
The following tradeoffs were made:
The following alternatives were considered:
Detecting if the -race flag is set via runtime.debug, however the BuildInfo.Settings was empty.
Links to places where the discussion took place:
Special notes for your reviewer

Checklist
This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.

[x] Design: A design document was considered and is present (link) or not required
[x] PR: The PR description is expressive enough and will help future contributors
[x] Code: Write code that humans can understand and Keep it simple
[x] Refactor: You have left the code cleaner than you found it (Boy Scout Rule)
[x] Upgrade: Impact of this change on upgrade flows was considered and addressed if required
[x] Testing: New code requires new unit tests. New features and bug fixes require at least on e2e test
[x] Documentation: A user-guide update was considered and is present (link) or not required. You want a user-guide update if it's a user facing feature / API change.
[x] Community: Announcement to kubevirt-dev was considered

Release note

NONE

/cc @xpivarc

Thanks for looking at this. One of the issues you are addressing is the race of BeforeEach, this is weird since all other goroutines should already exit. I think the problem is that we don't wait for the Handle to exit, WDYT?

Looking at the latest output with accurate line numbers, it looks to me like the Handle goroutine is exited and only the gingko stack is running. Additionally, from the line numbers given, as well as the read/write assignments, it looks like it finds the data race in the access to the channel variable, instead of the usage of the channel. It claims write when creating it and read when writing to the channel.
Snippet from Test Output
==================
WARNING: DATA RACE
Write at 0x00c000b79ec8 by goroutine 1253:
  kubevirt.io/kubevirt/pkg/virt-api/rest.glob..func5.1()
      /root/go/src/kubevirt.io/kubevirt/pkg/virt-api/rest/streamer_test.go:53 +0x231
  github.com/onsi/ginkgo/v2/internal.extractBodyFunction.func3()
      /root/go/src/kubevirt.io/kubevirt/vendor/github.com/onsi/ginkgo/v2/internal/node.go:463 +0x4d
  github.com/onsi/ginkgo/v2/internal.(*Suite).runNode.func3()
      /root/go/src/kubevirt.io/kubevirt/vendor/github.com/onsi/ginkgo/v2/internal/suite.go:889 +0x16b

Previous read at 0x00c000b79ec8 by goroutine 1251:
  kubevirt.io/kubevirt/pkg/virt-api/rest.glob..func5.1.4()
      /root/go/src/kubevirt.io/kubevirt/pkg/virt-api/rest/streamer_test.go:76 +0x6f
  kubevirt.io/kubevirt/pkg/virt-api/rest.(*Streamer).Handle.func4()
      /root/go/src/kubevirt.io/kubevirt/pkg/virt-api/rest/streamer.go:100 +0xc9

Goroutine 1253 (running) created at:
  github.com/onsi/ginkgo/v2/internal.(*Suite).runNode()
      /root/go/src/kubevirt.io/kubevirt/vendor/github.com/onsi/ginkgo/v2/internal/suite.go:876 +0x13d3
  github.com/onsi/ginkgo/v2/internal.(*group).attemptSpec()
      /root/go/src/kubevirt.io/kubevirt/vendor/github.com/onsi/ginkgo/v2/internal/group.go:199 +0x1127
  github.com/onsi/ginkgo/v2/internal.(*group).run()
      /root/go/src/kubevirt.io/kubevirt/vendor/github.com/onsi/ginkgo/v2/internal/group.go:349 +0x13e1
  github.com/onsi/ginkgo/v2/internal.(*Suite).runSpecs()
      /root/go/src/kubevirt.io/kubevirt/vendor/github.com/onsi/ginkgo/v2/internal/suite.go:489 +0x1151
  github.com/onsi/ginkgo/v2/internal.(*Suite).Run()
      /root/go/src/kubevirt.io/kubevirt/vendor/github.com/onsi/ginkgo/v2/internal/suite.go:130 +0x677
  github.com/onsi/ginkgo/v2.RunSpecs()
      /root/go/src/kubevirt.io/kubevirt/vendor/github.com/onsi/ginkgo/v2/core_dsl.go:300 +0xf0b
  kubevirt.io/client-go/testutils.KubeVirtTestSuiteSetup()
      /root/go/src/kubevirt.io/kubevirt/vendor/kubevirt.io/client-go/testutils/setup.go:60 +0x697
  kubevirt.io/kubevirt/pkg/virt-api/rest.TestRest()
      /root/go/src/kubevirt.io/kubevirt/pkg/virt-api/rest/rest_suite_test.go:29 +0x41
  testing.tRunner()
      /gimme/.gimme/versions/go1.21.5.linux.s390x/src/testing/testing.go:1595 +0x295
  testing.(*T).Run.func1()
      /gimme/.gimme/versions/go1.21.5.linux.s390x/src/testing/testing.go:1648 +0x8d

Goroutine 1251 (finished) created at:
  kubevirt.io/kubevirt/pkg/virt-api/rest.(*Streamer).Handle()
      /root/go/src/kubevirt.io/kubevirt/pkg/virt-api/rest/streamer.go:100 +0x8e9
  kubevirt.io/kubevirt/pkg/virt-api/rest.glob..func5.10.1()
      /root/go/src/kubevirt.io/kubevirt/pkg/virt-api/rest/streamer_test.go:148 +0x347
  net/http.HandlerFunc.ServeHTTP()
      /gimme/.gimme/versions/go1.21.5.linux.s390x/src/net/http/server.go:2136 +0x59
  net/http.serverHandler.ServeHTTP()
      /gimme/.gimme/versions/go1.21.5.linux.s390x/src/net/http/server.go:2938 +0x3c7
  net/http.(*conn).serve()
      /gimme/.gimme/versions/go1.21.5.linux.s390x/src/net/http/server.go:2009 +0xec7
  net/http.(*Server).Serve.func3()
      /gimme/.gimme/versions/go1.21.5.linux.s390x/src/net/http/server.go:3086 +0x9f
==================

So i think the problem here is that the Data Race Detector needs a channel to be empty, before it accepts that it's lifecycle is over and we did not make a mistake by assigning the variable a new channel.
I tested it and the closing part in my cleanup is not necessary, only the reading from the channel to ensure it is empty.

@xpivarc I can follow up on the issues. The first one opens for me the question if that would make it easier when closing the channel inside the streamToX functions, since they are the writers, they should close the channel. I don't think i tested closing the channel in those functions.
I can look through all the tests and try to spot potential problems like unfinished go routines etc...

/approve

@xpivarc I can follow up on the issues. The first one opens for me the question if that would make it easier when closing the channel inside the streamToX functions, since they are the writers, they should close the channel. I don't think i tested closing the channel in those functions.

Closing the channel is one of the things I tried but I am pretty sure it is not enough and I have seen races after. Still it will be more straight forward imo

I can look through all the tests and try to spot potential problems like unfinished go routines etc...

/cc @fossedihelm

/lgtm
Thank you! The fix looks like a good stability improvement!

/hold
please run ``make && make generate` and amend the changes to the commit. Thank you!

@fossedihelm done

/test all

@xpivarc I have looked at the test code and found a few things:

You are right that it is not guaranteed in each test that the handler function from testWebsocketDial exits before the test finishes. Should be easily solved by adding sync.WaitGroup.
Since it nearly always calls some Ginko functions, all handler functions should also include defer GinkgoRecover(). Currently this is a bit inconsistent.
The 2 tests cleans up the streamToX goroutine on termination are either badly misnamed or outdated, as they only check if the goroutine is called. Additionally they both duplicate code from the BeforeEach section. As i see it they might be cleaned up and renamed to ensure streamToX goroutine is run. What we can't actually test for is that the goroutine is cleaned up, since that depends on the code of the goroutine, which we override in the tests...
There are 2 instances where we leak the streamer.Handle function as it will never terminate:

closes clientSocket when keepAliveClient cancels context
returns the first stream result/error if streamToX terminates
I will work on producing a fix for this.

/test all

/retest-required

/retest

@xpivarc Could you review again with my new changes?

LGTM

/lgtm

/retest

/unhold

/retest


[MINOR] Fix couple typo in codebase

What changes were proposed in this pull request?

Fix couple typo in code comments
Fix wrong test value in TextSocketStreamSuite

Why are the changes needed?
Improve the readability

Does this PR introduce any user-facing change?
No

How was this patch tested?
manual test has been performed to test the updated

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Looks fine - if you're spell-checking, feel free to look for more across the code too.


Never-ending, non-stationary problems

What is the recommended way of handling long-running (perhaps never-ending) non-stationary problems?
E.g. Say we have a true objective function that varies over time in an unknown manner, with no end in sight.
What is the recommended way of using GPyOpt in these types of problems? If the functionality to properly handle these types of problems isn't there yet (I don't know if that's the case), what heuristics/ tricks could work well for them?

Hi,
In the current implemented methods you assume that the objective doesn't change after each evaluation. If it does, you need a way to updating your model accordingly. Here you have a reference of a bandits method that can handle that:
https://arxiv.org/pdf/1601.06650v1.pdf
If you are willing to implement it in GPyOpt I can give you some advice on how to do that!
Javier

Thank you @javiergonzalezh Very helpful. I have been going through the code slowly trying to understand all classes and methods and which function does what and why. I should be in good shape to dig deeper here soon.

Great! Thanks for the interests!