Create a new website

Pull Request (PR) description

This Pull Request (PR) fixes the following issues

Task list

[ ] Added an entry under the Unreleased section of the change log in the README.md.
Entry should say what was changed, and how that affects users (if applicable).
[ ] Resource documentation added/updated in README.md.
[ ] Resource parameter descriptions added/updated in README.md, schema.mof
and comment-based help.
[ ] Comment-based help added/updated.
[ ] Localization strings added/updated in all localization files as appropriate.
[x] Examples appropriately added/updated.
[ ] Unit tests added/updated. See DSC Resource Testing Guidelines.
[ ] Integration tests added/updated (where possible). See DSC Resource Testing Guidelines.
[ ] New/changed code adheres to DSC Resource Style Guidelines and Best Practices.

This change is

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: hacky1997 sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

Codecov Report

Merging #490 into dev will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev     #490   +/-   ##
=======================================
  Coverage   91.39%   91.39%
=======================================
  Files          17       17
  Lines        2661     2661
=======================================
  Hits         2432     2432
  Misses        229      229

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4dab473...67ec219. Read the comment docs.

@hacky1997 Please sign the CLA for me to be able to review this PR.
Also, please update the PR description with the issue this PR is closing.

@hacky1997 Thank you for signing the CLA. I will review this PR. 🙂

Sorry but I didn't understand what was my mistake !! could help me to sort out that? @johlju

I think all the changes you made got into this PR. I reviewing it now. This PR looks good so far, just a few review comments. 🙂

Yes I actually asking about the https://github.com/PowerShell/xWebAdministration/pull/494 this one @johlju

@hacky1997 to send in more than one PR you must branch out from the dev branch, read more here https://github.com/PowerShell/xWebAdministration/pull/493#issuecomment-536649491

@hacky1997 let me know if you need any help with this.

@hacky1997 let me know if you need any help with this.

Sure, Actually in India, we people celebrate our Durga Puja festival. So that's why it takes much time to fixed those issues.

I think we need to take a step back a look how we should solve issue #487. It has evolved since other PRs have merged.
The example that issue #487 is pointing at I want split up each configuration block in two files.

First example configuration block I want to be moved in to a file named Sample_xWebsite_NewWebsite_UsingCertificateThumbprint.ps1, the file should be created in the folder Examples/Resources/xWebSite.
Second example configuration block I want to be moved in to a file named Sample_xWebsite_NewWebsite_UsingCertificateSubject.ps1, the file should be created in the folder Examples/Resources/xWebSite.

The other example files in this PR should be removed so that only the two above that resolves issue #487 is left.

I think we need to take a step back and look how we should solve issue #487. It has evolved since other PRs have merged.
The example that the issue #487 is pointing at, I want each configuration block split up into its own file (resulting in only two new example files).

First example configuration block I want to be moved in to a file named Sample_xWebsite_NewWebsite_UsingCertificateThumbprint.ps1, the file should be created in the folder Examples/Resources/xWebSite.
Second example configuration block I want to be moved in to a file named Sample_xWebsite_NewWebsite_UsingCertificateSubject.ps1, the file should be created in the folder Examples/Resources/xWebSite.

The other example files in this PR should be removed so that only the two above that resolves issue #487 is left.

Done.

Codecov Report

Merging #490 into dev will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##              dev     #490   +/-   ##
=======================================
  Coverage   91.39%   91.39%
=======================================
  Files          17       17
  Lines        2661     2661
=======================================
  Hits         2432     2432
  Misses        229      229

Impacted Files
Coverage Δ

...s/MSFT_xWebSiteDefaults/MSFT_xWebSiteDefaults.psm1
12.5% <100%> (ø)
:arrow_up:

DSCResources/MSFT_xWebsite/MSFT_xWebsite.psm1
97.21% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6ded0de...343eac4. Read the comment docs.

@hacky1997 We are close now! Thank you for the work you put into this PR! 😃

Could you please remove the invalid label if you don't mind!

When you merged lates changes from you did not resolve the README.md correctly. You got a lot of text in it again that should not be part of this PR. :) Could you please look a that again?

When you merged lates changes from you did not resolve the README.md correctly. You got a lot of text in it again that should not be part of this PR. :) Could you please look at that again?

Resolve means conflicts? or I have to delete Sample_xWebsite_NewWebsite this from readme.md file?

@hacky1997 Thank you for this! I will merge this as soon as the test passed. 😃

@johlju Thank you so much. Without you it is tough for me and honestly I learn a lot from this. Again, Thank you so much. I hope I will contribute more in future :)

@hacky1997 happy to help :)


How to use claude ?

i tried setting
OPENAI_API_BASE = https://api.anthropic.com/v1/messages
or
OPENAI_API_BASE = https://api.anthropic.com/v1
and
OPENAI_MODEL_NAME = claude-3-opus-20240229
along with proper OPENAI_API_KEY.
but it gives error :
File "C:\Users\Ameer\AppData\Local\Programs\Python\Python312\Lib\site-packages\openai_base_client.py", line 988, in _request
raise self._make_status_error_from_response(err.response) from None
openai.NotFoundError: Error code: 404 - {'type': 'error', 'error': {'type': 'not_found_error', 'message': 'Not Found'}}
what am i doing wrong ? i can use grok and openAi without error

You could follow this doc to use Claude https://docs.praison.ai/models/anthropic/


undefined is not an object

Hello,
I'm started a project with react-native. But I have a probleme with RTCWebView BridgeManager.NavigationType. He write that "undefined is not an object (evaluating'RCTWebViewBridgeManager.Navigation.Type
I uprgrape the webview-bridge. But I have already same message.
I'm in version react native 0.26.3

me too！How about you now?

@shackachaska

Same here. I'm on RN 0.29.1, and I npm install https://github.com/alinz/react-native-webview-bridge already as there are fixes still not pushed to npm.
@alinz?

I am facing the same issue. I am on RN 0.35.0

you need to link the library.
react-native link

I too faced the same issue.But after adding the library file 'libReact-Native-WebView-Bridge.a' to 'Linked Frameworks and Libraries', resolved the issue

Hey guys! what should my rnpm look like and after that what should the "react-native link ...  " look like? ive already followed installation documentation and updated with npm link that you suggested but im still getting "undefined is not an object (evaluating 'propTypes.func') at index.ios.js:105:31"


Add Apps K8s sub-section.

Initial PR to add some of the internal CNR content to TDC.
Signed-off-by: John Harris<EMAIL_ADDRESS>

Rather than put new shortcodes/styles/etc in the theme, shouldn't we override them in the top level, as per hugo overrides?
This would mean, for example, that the aside.yml should go in ./layouts/shortcodes/ instead of ./themes/docsy/layouts/shortcodes.

Rather than put new shortcodes/styles/etc in the theme, shouldn't we override them in the top level, as per hugo overrides?
This would mean, for example, that the aside.yml should go in ./layouts/shortcodes/ instead of ./themes/docsy/layouts/shortcodes.
(I recognize that it's already been done this way here as well as in previous versions of the library, but it does make updating to newer versions of a theme more challenging than it should be.)

This would be right except for the fact that I think we've gone so far outside the realm of the original theme that it's not even really that theme anymore...

OK addressed all comments. For the styling ones I used best judgement (which is probably awful) so might need some touching up later from UX team.

This good to go now @bryanfriedman / @BrianMMcClain ?


GenerateInstructions performance issue

While route.Calculate(...) executes fast is route.GenerateInstructions() quite slow. I did not go into the code details, but it looks like that the cause is in Lua Interop. For example: 50 km route is calculated in 35 ms while GenerateInstructions takes 1150 ms.
Is it possible to speed up GenerateInstructions?

Probably this is due to the instructions being generated in the Lua scripts, I'll check to see if I can improve performance.
What would definetly help is generating the instructions using plain C# but that should be a last resort option because it would defeat the purpose of dynamic vehicle profiles.

Hi, @xivk .Performance issues are definitely due to Lua scripts. I needed some speed-up for TryCalculate so I profiled this method. Excluding TryReolve time (as there is no easy speed up) Lua script call takes more than 50 percent of time

Yes, I know, not really a quick-fix solution, except the suggestion that what's now written in lua can also be done using C#. That should speed up things a lot.

Thx. I'll write car profile in C#.

@anothar I saw you have car profile in C#. What is the performance gain for GenerateInstructions?

Hi @amarinsek. Up to 100 times. Actually with car profile in C# it is counted in milliseconds. Here is link to my C# car profile.

The routing profile gains will be extremely minimal because everything is pre-calculated, speed/factors/access per link type is calculated before routing starts so during routing the profiles are not touched anymore.
This is different in the instruction generation.

Closing this, I added to the roadmap for Itinero 2.0 to reevalute using lua for instruction generation or to fix the performance issues.

https://github.com/itinero/routing/wiki/Roadmap


Support other Promise implementations

It would be nice if there were a way to use Bluebird promises instead of native.

The problem here is that we use async/await extensively, and async functions only produce native Promises.


[Translate zh-CN] chrome-devtools/console/console-write.md

Check out a review request at GitLocalize

cla updated


create 2002 maximum-product-of-the-length-....cpp

File(s) Modified: 2002-maximum-product-of-the-length-of-two-palindromic-subsequences.cpp
Language(s) Used: cpp
Submission URL: https://leetcode.com/problems/maximum-product-of-the-length-of-two-palindromic-subsequences/submissions/875870442/

Thanks.


[BUG] - No list of connections when connected and auto-tunneling active

Describe the bug
No list of connections at the connections tab when auto-tunneling is active and connected
Smartphone (please complete the following information):

Device: Pixel 7 Pro
Android Version: Android 14
App Version 3.3.6

To Reproduce
Enable auto-tunneling
Wait until your preferred tunnel is Connected
Go tunnels tab
See no tunnels are listed
Expected behavior
Tunnels are listed in any case, like in previous versions
Screenshots (Only if necessary)

Thank you so much for reporting this. I'm working on a fix now.


Allow a module to implement an interface

It would be useful when a module can implement an interface using the implements keyword. Syntax: module MyModule implements MyInterface { ... }.
Example:
interface Showable {
    show(): void;
}
function addShowable(showable: Showable) {

}

// This works:
module Login {
    export function show() {
        document.getElementById('login').style.display = 'block';
    }
}
addShowable(Login);

// This doesn't work (yet?)
module Menu implements Showable {
    export function show() {
        document.getElementById('menu').style.display = 'block';
    }
}
addShowable(Menu);

How would this be related to #2159? A namespace implements an interface?

@jbondc If we had this, it would also apply to namespaces.

Are you sure you want to go down an implementational path where "namespaces" can implement interfaces?

Oh wow, this has been approved for quite a while. @RyanCavanaugh unless you have any second thoughts, I might implement this soonish.

I withdraw my previous skepticism, I actually exited for the new structural possibilities it would bring.
In line with that, please consider enforcing the interface of the aggregate of the interface instead of only the block that declares the implementation - The nature of namespaces/modules is to be spread out and to contain a lot of non-trivial components. I'd like to be able to use this, but I certainly don't want to define my whole namespace/module in the same file. Why not just use a class in that case?

@Elephant-Vessel I'm not sure if we are talking about Modules, or Namespaces, or Packages, or Features, or...

@aluanhaddad What do you mean?

I mean that at the time that this discussion started module didn't mean what it means today. We now use the term namespace to refer to what is described in the OP as a module, while module has taken on a more precise and incompatible meaning. So when you talk about multiple files taking part in this implementation are you referring to namespaces or modules?

I'm referring to namespaces. I guess I just wanted to conform to the history of this thread, sorry for not breaking loose :)

So I want to be able to describe and put constraints and expectations on generic modules that can contain other generic modules or classes, taking advantage of the structural concept namespaces in typescript.
My hope is that we'll be able to better express higher-level structural expectations in a system. Classes do not scale well, they are fine as atomic components in a system, but I don't think that higher-level organizational structure in a system would good to express with classes as they are designed to be instantiated and inherited and stuff like that. It's just too bloaty.
I'd appreciate a simple and clean way to describe higher order structure of the system, no fuss. Preferably with the feature of optional directional visibility constraints. Like making it impossible to reference MySystem.ClientApplication from MySystem.Infrastructure but fine the other way around. Then we are starting to go somewhere exciting.

@Elephant-Vessel thanks for clarifying. I agree this would be extremely valuable and that class types are not the right approach here. I think you hit the nail on the head when talking about instantiation because namespaces represent things that are conceptually singletons at the library level. Although this can't be enforced, it would be useful conceptually to have something that does not imply multiple instantiations.

I agree with @Elephant-Vessel. While it is easy to mistaken TypeScript for another Java, where all constraints are expressed with a single class structure, TS has a much broader "Shape" concept which is very powerful and eliminates semantic contortonism. Unfortunately, the inability to put constraints on module tend to force developers to relegate back to a class pattern for things that would be much better expressed as module.
For example, for unit testing, it would be very helpful to be able to express some "shape" (i.e. constraints) on modules so that we can provide alternative implementation for a particular running context. Now, it seems the only way to do that in a structure/checked way is to go back to class based DI (as la Spring) and make everything a class (and therefore instantiable).
Anyway, I am paraphrasing @Elephant-Vessel, but if I have a single wish for TS, it would be this one.

Any word on this bird? I have this issue as well, thanks all

Has this matriculated / landed yet? this is going to be a cool feature

How can we progress this? Its incredibly powerful. Happy to help out!

any worb on this birb?

Seen this question rise up so many times, and I think we are all just looking for one thing:
Support static members in an interface.
If that would happen, you could just use a class with static members and an interface, which is almost the same thing as you are trying to do here, right?
Either way, add static support to interfaces OR add interface support for modules is highly needed.

@shiapetel nah not like that.
we can do this:
export default <T>{
  foo: Foo,
  bar: Bar
}

but that's not what we are looking for. we are specifically looking for:
export const foo : Foo = {};
export const bar : Bar = {};

but there's currently no mechanism to enforce the module to export foo and bar.

If interfaces supported static members, you could use a class with static foo/bar that inherited from:
Interface ILoveFooBar{
static foo:FooType;
static bar:BarType;
}
Right?
That’s what I meant, I think it would help in your situation- I know it would definitely help in mine.

@shaipetel static members of interfaces definitely might be useful, but perhaps not for this use case.

Is this issue just waiting for someone to have a got at implementing?

One use case would be for frameworks and tools that scan a directory for modules on application startup, expecting those modules each to export a certain shape.
For example, in Next.js, you create JS/TS modules within a ./pages directory. The framework scans this directory when you start your server, generating routes based on filenames. It's up to you to ensure your module has a NextPage default export, and optionally a PageConfig export named config. Today, you have to type these exports individually like this:
import { NextPage, PageConfig } from 'next'

interface Props {
  userAgent?: string
}

const Page: NextPage<Props> = ({ userAgent }) => (
  <main>Your user agent: {userAgent}</main>
)

Page.getInitialProps = async ({ req }) => {
  const userAgent = req ? req.headers['user-agent'] : navigator.userAgent
  return { userAgent }
}

export default Page

export const config: PageConfig = {
  api: { bodyParser: false }
}

It would be nice if you could declare the export shape of the whole module in one line, something like implements NextPageModule<Props>.
Even nicer would be if there was a way to declare in a central TypeScript config that all files matching ./pages/**/*.ts must implement a certain export shape. Not sure if there's any precedent for that approach though.

I find I'm often tempted to create a Singleton Class when a simple module that implements an interface is all I need. Any tips how best to address this?

@RyanCavanaugh @DanielRosenwasser
I want to work on this issue. Can you please give me a few tips for the solution or where to look around?

Thinking about this from a 2020 perspective, I wonder if instead of export implements Showable we re-use type and allow export as an identifier? Today that's invalid syntax so it's unlikely to step on anyone's existing codebase.
Then we get the import syntax:
// Can re-use the import syntax
type export = import("webpack").Config

Declarations are then easy to write:
// Can use normal literals
type export = { test: () => string, description: string }

// Generics are easy
type export = (props: any) => React.SFC<MyCustomModule>

There's some notes in ^ - one interesting thing that came out of the meeting was the idea that could we build a more generic tool of which this is a use-case, rather than the only thing it does.
For example, if we had a type assertion operator for type compatibility then that could be used for both the module exports, and generically to verify that types match how you want. For example:
type assert is import("webpack").Config

const path = require('path');

export default {
  entry: './src/index.js',
  output: {
    path: path.resolve(__dirname, 'dist'),
    filename: 'bundle.js'
  }
};

Where the lack of a target means applying it at the top level scope. This can be used to provide contextual typing (e.g. you'd get auto-complete in the export default { en|
But can also be useful in validating your own types:
import {function} from "./example"

type assert ReturnType<typeof function> is string

It's also worth thinking what the JSDoc equivalent should be too, maybe:
/** @typedef {import ("webpack").Config} export */

I would think @module would be the JSDoc equivalent. The top of the file should have:
/** @module {import("webpack").Config} moduleName */

See: https://jsdoc.app/tags-module.html

Storybook v6 has changed to an approach based on structured modules they called Component Story Format. All .stories.js/ts modules in a codebase are expected to include a default export with type Meta.
Having no way to express this expectation in a global way, combined with the existing deficiency in typing default exports, makes using Storybook v6 with TypeScript a much less smooth experience than it could be.

To add on to @jonrimmer 's points, exporting a default that is of a certain type that replicates a module will lead to issues with tree-shaking.
Webpack has no problem tree shaking import * as Foo. But when you try to do the same with a export default const = {} or export default class ModuleName { with all static members, unused imports aren't removed.

I'm +1ing this whole thread. I'd love to have a way to enforce certain modules export a particular shape similar to the examples cited above such as Next.js and Storybook.

Another use case for this:
Universal modules for React Native & React Native Web, where the bundler for each platform picks the right file for a certain ambiguous import like this:
import {analytics} from './analytics'

File list:
analytics.web.ts
analytics.android.ts
analytics.ios.ts`

Currently, there's no convenient way to enforce that all these files must have the same exports. The absence of module-level type assertion could realistically lead to runtime crashes.

Here's a workaround by using a third file with a useless import/export pair (eg: ModuleValidator.js)
import * as module1Import from '../modules/module1.js';
import * as module2Import from '../modules/module2.js';

/** @type {MyModuleType} */
export const module1Export = module1Import;
/** @type {MyModuleType} */
export const module2Export = module2Import;

The export lines should throw throw an error if the module fails to implement the interface. Is it pretty? No. But you can easily build tests around.

Here's a workaround by using a third file with a useless import/export pair (eg: ModuleValidator.js)
import * as module1Import from '../modules/module1.js';
import * as module2Import from '../modules/module2.js';

/** @type {MyModuleType} */
export const module1Export = module1Import;
/** @type {MyModuleType} */
export const module2Export = module2Import;

The export lines should throw throw an error if the module fails to implement the interface. Is it pretty? No. But you can easily build tests around.

@orta have TS team had any new discussions on this? More and more popular tools and libraries start to use a file with some specific named exports approach. Storybook and NextJS to name a few. This can provide next-level type safety for such frameworks.

Unlike regular objects, modules can hold types as well as values. Would it be possible annotate a module to specify that it must export a specific type?
For example, we are defining modules for each of our API endpoints. Each module must export types Params and Response. These will be different for each module, but we would like to enforce that each module exports something under those names. Furthermore, if we renamed the types, ideally TS would update the name in every module.

Is this doable at all now? I really want to type my Next.js pages. This one has been opened a long time, 8 years... Anyone know the thoughts on TS team opinion on this?

I have found a sorta-workaround.
You will have to assign your module into a variable, or declare a global of the interface's type.
interface IUtilities {
    Version: string;
    Build: number;
    PrintVersion(): string;
}
module Utilities {
    export var Version = "1.1";
    export var Build = 23;
    export function PrintVersion() {
        return `v${Version}b${Build}`;
    }
}
//by assigning it into a var of the interface type, we provoke TypeScript to check the module comply with the interface
var p: IUtilities = Utilities;

@shaipetel thanks for sharing but this doesn’t support default exports?

@EloB the problem with default exports, that you do not include inside a namespace or module - is that the point of import doesn't guarantee to import all members. So can't verify it against an interface, I guess (it is not all or nothing, in a sense of all members/functions or none).
Because of tree shaking I guess - think about it, if you were to verify it as an interface:

You export 3-4 functions
Your caller imports it and TypeScript says "Your imports are of type X
Your caller only uses 2 functions inside
Tree shaking will drop the rest unused code << at this point you'll have a problem since TypeScript "lied" about the type you have...

I'm assuming in a nutshell, that's one of the problems. You can't guarantee the entire module will be consumed/exported and won't be broken up by the build.

@shaipetel Typescript is orthogonal to tree-shaking, meaning that it will still Typecheck unused code paths.

@reaktivo exactly, but that is what can cause the problem.
You see, when you import only some members of a module A1 that adheres to interface iA,
then import other members from a different module A2 that also adheres to interface iA.
Now in your code - TypeScript will tell you A1 and A2 both implement iA, right?
So, assume you have a function (not inside your code, maybe a global one. example would be if you try to JSON.stringify your import) that expects iA as a parameter.
TypeScript would basically tell you its ok to send either your imported A1 or A2, without knowing which members you chose to import, and which members are needed by your function, in during dev - TypeScript gives the green light assuming everything would be there.
During build, your A1 is missing some members from iA, and A2 is missing other members...
The build wouldn't know what that function expects, and how it is going to use the parameter - so tree shaking won't be able to identify the members that are needed (dependencies).
I hope I'm making sense...

So by changing tree shaken to follow module requirement (optional) would fix everything?

@JarnoRFB Thanks for your time. This doesn't work tree shaking right? I already know that you can write like this but from my understanding it won't work with tree shaking?

@EloB disregarding tree shaking, the same could be done for normal modules using
interface IUtilities {
  Version: string;
  Build: number;
  PrintVersion(): string;
}

const Version = "1.1";
const Build = 23;
const PrintVersion = () => `v${Version}b${Build}`;

// by assigning it into a var of the interface type,
// we provoke TypeScript to check the module comply with the interface.
const module: IUtilities = {
  Version, Build, PrintVersion,
};

export default module;

Yes, but also, we can't simply disregard tree shaking.

@EloB my understanding is unfortunately to limited to comment on that. I just adapted you solution for normal modules.

@nthypes, thanks for posting this. I'm okay with ugly if it works. However, I must be missing something because this doesn't seem to work for me:
/* commands.ts */
/* -------------------------------------------------------------------------- */
/*                            Module Type Checking                            */
/* -------------------------------------------------------------------------- */

interface YourModuleInterface {
    foo: string;
}

type _ = typeof import('./commands');
export const foo: YourModuleInterface = "hello" as _;

/* ----------------------------------- --- ---------------------------------- */

I also tried this but this also doesn't work.
/* commands.ts */
* -------------------------------------------------------------------------- */
/*                            Module Type Checking                            */
/* -------------------------------------------------------------------------- */

interface YourModuleInterface {
    foo: string;
}

type _ = typeof import('./commands');
export const __TYPE_CHECKING__: YourModuleInterface = { foo: "hello" } as _;

/* ----------------------------------- --- ---------------------------------- */

Got it. Thanks, @nthypes. Adding on to this, the variable named __TYPE_CHECKING__ is arbitrary. You can call it anything you want. At first, I thought there might be some magical/special meaning associated with it, but that's not the case. Here's my updated example with some comments that elaborate on what I believe is happening based on the code you provided.
/*
Inside the file commands.ts
@note we need to import the same file we're in (`commands.ts`) in the module type checking section below
*/

// this defines the interface for our module (commands.ts), i.e., what it must export
export interface CommandsModuleInterface {
    // put whatever you want here for your use case.
   // This use case says we must export a value named `foo` of the type `string`
    foo: string;
}

// here, we implement our interface
export const foo = "hello";

/* -------------------------------------------------------------------------- */
/* Below this line is the "hack" to validate our command.ts module.
/* It works by importing the `type` of the module (file) we're in, i.e., `commands.ts`
/* -------------------------------------------------------------------------- */

// this infers the type of what we're *actually* exporting from `commands.ts`
// we store this as a type called `_` (again this is arbitrary)
type _ = typeof import('./commands');

// The line below here is where the actual type checking occurs.
// We assign an arbitrarily named `const` as `__MODULE_TYPE_CHECK__`
// and specify the type as our desired module interface, `CommandsModuleInterface`.
// We assign the `const` `CommandsModuleInterface` a value of `{}` but immediately
// try to type assert that`__MODULE_TYPE_CHECK__`, which we said should be of type
//  `CommandsModuleInterface`, matches the type actually exported by our module
// and assigned the type `_`.
// @note The eslint-disable-next-line is optional. I needed it for my lint rules
// eslint-disable-next-line @typescript-eslint/no-unused-vars
const __MODULE_TYPE_CHECK__: CommandsModuleInterface = {} as _;

/* ----------------------------------- --- ---------------------------------- */

This is great. I've amended the example slightly to not emit an empty runtime object:
type THIS_MODULE = typeof import('./commands');
type TYPE_CHECK<T extends CommandsModuleInterface> = T;
declare const _: TYPE_CHECK<THIS_MODULE>;

Too bad you have to hard-code the file name in the file itself. There is a high chance of it getting misaligned after renaming/copying.

This is a pretty old issue, but so relevant! Would be nice to have this feature in TypeScript :D
I created the issue #58029, but since it's the same subject, I'll give my 2 cents here:
My proposal is adding a way to define a module interface, and a way to use it, adding the module interface and module implements keywords.
📃 Motivating Example
// file user-module-interface.ts
export module interface UserModuleInterface {
  async function getUser(id: string): Promise<User>
  async function createUser(): Promise<void>
}

// ---------------

// file prisma-user.ts
import type { UserModuleInterface } from "./user-module-interface"

module implements UserModuleInterface

export async function getUser(id) {}

export async function createUser() {}

// ---------------

// another-file.ts
import { getUser, createUser } from "./prisma-user"

Explaining the example
First thing we have to do is creating a module interface. It can be exported from a specific file as type or used in the same file that functions will be implemented.
Everything inside a module interface must be implemented when module implements is used.
Then you can import (as a type) this module interface into another file and use module implements to implement the interface. This can be a line module implements MyInterface or something with a body, like:
// file prisma-user.ts
import type { UserModuleInterface } from "./user-module-interface"

module implements UserModuleInterface {
  export async function getUser(id) {}
  export async function createUser() {}
}

We can also implement more than one interface, like in classes:
// file article-module-interface.ts
export module interface ArticleModuleInterface {
  function getArticles(): Promise<Article[]>
}

// ---------------

// file prisma-user.ts
import type { UserModuleInterface } from "./user-module-interface"
import type { ArticleModuleInterface } from "./artictle-module-interface"
module implements UserModuleInterface, ArticleModuleInterface

export async function getUser(id) {}

export async function createUser() {}

export async function getArticles() {}

Rules
The module that is using module implements must implement all functions defined in module interface. Otherwhise, TypeScript should throw an error.
Shouldn't be a problem to implement other functions that are not defined in a module interface, as long as we implement at least every function defined in module interface.
We can possibly make some functions optional (not required to this suggestion):
// file user-module-interface.ts
export module interface UserModuleInterface {
  async function getUser(id: string): Promise<User>
  // createUser is optional
  async createUser?(): Promise<void>
}

// ---------------

// file prisma-user.ts
import type { UserModuleInterface } from "./user-module-interface"

module implements UserModuleInterface

export async function getUser(id) {}

// no errors, even if `createUser` is not implemented

💻 Use Cases
In this proposal, we do not rely on runtime features. All types (module interface and module implements) can be safely removed in build time.
The functions defined inside a module that extends a module interface can be auto-inferred.
And with this implementation, we have tree-shaking, because we can import only the functions we'll use.
To do something similar today, we have to create a class or an object and export the whole object, even if we want to use only one function.

@fdaciuk Definitely think that modules implementing interfaces / types would warrant a special syntax to do away with the clunky workarounds presented in the thread. However, why would we need a special module interface construct for that and could not just use the normal interface / type keywords we already have?

I don't think we need @JarnoRFB. Maybe just a simple interface will solve the problem. module interface was just a suggestion to give more semantic, but like you said, probably module implements is enough =)

@DanielRosenwasser this issue is 10yo. Do you think there is any chance of this being implemented in TypeScript soon?

Maybe @RyanCavanaugh can help answer this =)

I'd like to bump this for another use case: if you have a package.json with in it, exports:
{
  "exports": {
    "node": "./file.node.ts",
    "require": "./file.require.ts",
    "module": "./file.module.ts",
    "default": "./file.default.ts"
  }
}

And you want to ensure that all those 4 files are exposing the same interface for the whole module (and not that 1 forgot to expose a function, or implemented a different type)


Nested routes should be rendered inside parent's RouteHandler if inside parent RouteHandler isn't used.

Imagine such kind of routes:
<Route name='viewport' path='/' handler={require(`${pagePath}/Viewport.react`)}>
    <Route name='screen' path='/screen/:itemId' handler={require(`${pagePath}/ScreenDesigner.react`)} >
        <Route name='grid_popup' path='grid_popup/:gridId' handler=  {require(`${pagePath}/GridPopupDesigner.react`)} />
     </Route>
 </Route>

Let's say I have viewport inside which there is RouteHanlder:

                    <RouteHandler />

And I want child page 'screen/<screen_id>/grid_popup/<group_id>' to be rendered instead of parent page 'screen/<screen_id>' inside RouteHandler of Viewport.
How can I do that?
Thanks in advance :)

It seems that I found solution:
path='/parent1/child1/:itemId/child2/:itemId/child3/:itemId/child4/:itemId' but it looks ugly.

if you'd like some more help, make a demo we can look at, but the nesting is working as designed, sorry you're having trouble.


Capture bit-depth in source images config file.

When we crawl the image sequences to determine test image sequences, it would be good to also capture the bit-depth of the sources.

That should be possible to achieve. If ffprobe lacks this info we can use iinfo or oiio python bindings directly.


Execution on windows

Is there any way to execute Magneto on Windows(win 8)?
Currently i get some errors beginning with "exec" not recognized.
Please help.

Unfortunately we do not support Windows at the moment, but it's something we have in mind for the future.


⚠ ClamAV has degraded performance

In 7521090, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 470 ms

Resolved: ClamAV performance has improved in e52d66d.


feature request: constant q transform

Constant Q Transform is a transformation for audio that uses a log scale for the frequency instead of a linear scale like FFT does. A fast implementation of Constant Q Transform uses FFT and a kernel.
https://en.wikipedia.org/wiki/Constant-Q_transform
http://academics.wellesley.edu/Physics/brown/pubs/effalgV92P2698-P2701.pdf
CQT is implemented in ffmpeg en mpv and gives intuitive visualization of which notes are being played at a given time.
https://trac.ffmpeg.org/wiki/FancyFilteringExamples#showcqt

There's already a crate for cqt, but it does not use the fast implementation with fft.
https://github.com/alexjago/cqt


simultaneous racon runs cause later one(s) to fail

If I have one racon run going, and start another one, even in a cluster environment, the second one will fail with "##### Illegal instruction" (where ##### varies). I've tried looking for files in /tmp, or in the temp directory of the racon build folder, but nothing stands out. They are running on the same file system, so that's why I suspect some sort of temp file overlap.
Otherwise, runs of the example data complete fine, and if I run one racon job at a time it appears to run fine.

Hi,
Racon does not generate any temporary files, just the output .fasta.
Are all your nodes in the cluster configured with the same operating system? And are the CPUs the same?
Best regards,
Ivan.

Huh ... may not all be same CPUs ... should be same OS. But it always seems
to be the 2nd and later jobs that fail, not the first (as far as I can
tell). Seems unlikely that they're landing on the right / wrong nodes by
chance.
On Wed, Oct 18, 2017 at 3:07 PM, Ivan Sovic<EMAIL_ADDRESS>wrote:

Hi,
Racon does not generate any temporary files, just the output .fasta.
Are all your nodes in the cluster configured with the same operating
system? And are the CPUs the same?
Best regards,
Ivan.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/isovic/racon/issues/38#issuecomment-337742234, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAiFqP5KPfS05dlE4NmMIfE_O7IqpeSpks5stnaTgaJpZM4P-WNS
.

--
Joseph Fass
Bioinformatics Data Analyst
UC Davis Genome Center - Bioinformatics Core
http://bioinformatics.ucdavis.edu/
<EMAIL_ADDRESS>phone ~<PHONE_NUMBER>

Can you try to qrsh to a node where the run failed and run a single instance manually?

Will do ... I'll also try running two on the same (non-cluster) server, to
see if they also collide in that case.
On Wed, Oct 18, 2017 at 3:15 PM, Ivan Sovic<EMAIL_ADDRESS>wrote:

Can you try to qrsh to a node where the run failed and run a single
instance manually?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/isovic/racon/issues/38#issuecomment-337743811, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAiFqCn20Fl9fS4PhJmWmP4oYwViNU8yks5stniGgaJpZM4P-WNS
.

--
Joseph Fass
Bioinformatics Data Analyst
UC Davis Genome Center - Bioinformatics Core
http://bioinformatics.ucdavis.edu/
<EMAIL_ADDRESS>phone ~<PHONE_NUMBER>

The illegal instruction error hints that not all CPUs support the same (or if any) simd instruction set. Try recompiling Racon on each node individually.
Best regards,
Robert


Version 2.7.0

PKG-3331
Upstream
Changelog
Actions

Bump version to 2.7.0

Notes

Commit 5023316 has the build checks minus an added abs.yaml

sorry to do this to you, but I think we need to try building for python 3.12 too

Heyya all.
I'm the maintainer of cramjam, and passively try to keep the conda-forge impl going. Can I ask what the point is of this is on AnacondaRecipes?
I'm rather hoping I can stop having to concern myself with conda-forge if the same can be offered here.

Hello @milesgranger. We (Anaconda) maintain what's called the default channel. The AnacondaRecipes GitHub organization hosts all the feedstocks that make the default channel.
Some of the differences between the default channel and conda-forge channel are explained in https://www.anaconda.com/blog/is-conda-free.
I hope this answer your questions. If not, please feel free to let us know!

Ah, I see now. Thank you! 👌


Rename validate-namespace-deletion VWC to gardener-admission-controller

How to categorize this PR?

/area control-plane
/kind cleanup
What this PR does / why we need it:
This PR renames the validate-namespace-deletion ValidatingWebhookConfiguration to gardener-admission-controller to prevent confusion when people search for the gardener-admission-controller's ValidatingWebhookConfiguration.
Which issue(s) this PR fixes:
Fixes #6858
Special notes for your reviewer:
Release note:

The `validate-namespace-deletion` `ValidatingWebhookConfiguration` is renamed to `gardener-admission-controller`. You might need to cleanup the existing `validate-namespace-deletion` `ValidatingWebhookConfiguration`.

/retest

I tried to dig into the test failure. I created the following issue (ref https://github.com/gardener/gardener/issues/6897) with my observatios.
/retest

/retest
The test failure does not seem to be related to the changes from this PR.

/test pull-gardener-e2e-kind-migration


Feature/ciba

:x: Build TheIdServer 4.3.1-ciba1-0012 failed (commit https://github.com/Aguafrommars/TheIdServer/commit/5d8a952c98 by @)

:white_check_mark: Build TheIdServer 4.3.1-ciba.1+12.build.1852 completed (commit https://github.com/Aguafrommars/TheIdServer/commit/5d8a952c98 by @)


Review of FIN Machine Learning PoC & update permissions

Describe the issue
Review of FIN's current use of the ML PoC for eventual transition to the managed infra and update the permissions as per their new needs
Which Sprint Goal is this issue related to?

Note: 'Milestone' is a ZenHub term that we use synonymously with 'Sprint'.

The 'Milestone' description (created in ZenHub) should clearly list Sprint Goals. This section should indicate which 'goal' this issue is related to.
Additional context

Old Machine Learning PoC that needs to be transitioned at some point

Definition of done

Identify their current use of it
Have Client Services engage with them on subject of transitioning down the road
Update the permissions as per their current requirements

Review conducted and info sent to client through their Client Services rep that this PoC instance will have to be moved onto Gov Azure managed infra.  Client will discuss internally and let us know what their plans for this ML-based audit tool will be as a future project.  Permissions issue was resolved for them in the meantime.


use for each

Pull Request Test Coverage Report for Build 2691
Details

1 of 1 (100.0%)  changed or added relevant line in 1 file are covered.
2 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.05%) to 86.894%

Files with Coverage Reduction
New Missed Lines
%

builtin/array.mbt
2
96.32%

Totals

Change from base Build 2687:
-0.05%

Covered Lines:
3726

Relevant Lines:
4288

💛  - Coveralls


[tool_crash] ProcessException: The directory name is invalid. Command: C:\flutter\bin\cache\dart-sdk\bin\pub.BAT, OS error code: 267

Command
flutter doctor

Steps to Reproduce

...
...
...

Logs
ProcessException: The directory name is invalid.
Command: C:\flutter\bin\cache\dart-sdk\bin\pub.BAT, OS error code: 267
#0      _ProcessImpl._start (dart:io-patch/process_patch.dart:390:33)
#1      Process.start (dart:io-patch/process_patch.dart:36:20)
#2      LocalProcessManager.start (package:process/src/interface/local_process_manager.dart:44:22)
#3      ErrorHandlingProcessManager.start.<anonymous closure> (package:flutter_tools/src/base/error_handling_io.dart:664:24)
#4      _run (package:flutter_tools/src/base/error_handling_io.dart:544:20)
#5      ErrorHandlingProcessManager.start (package:flutter_tools/src/base/error_handling_io.dart:663:12)
#6      _DefaultProcessUtils.start (package:flutter_tools/src/base/process.dart:425:28)
#7      _DefaultProcessUtils.stream (package:flutter_tools/src/base/process.dart:444:35)
#8      _DefaultPub.batch (package:flutter_tools/src/dart/pub.dart:285:34)
<asynchronous suspension>
#9      _DefaultPub.get (package:flutter_tools/src/dart/pub.dart:225:7)
<asynchronous suspension>
#10     PubDependencies.update (package:flutter_tools/src/flutter_cache.dart:121:5)
<asynchronous suspension>
#11     Cache.updateAll (package:flutter_tools/src/cache.dart:546:9)
<asynchronous suspension>
#12     FlutterCommand.verifyThenRunCommand (package:flutter_tools/src/runner/flutter_command.dart:1143:7)
<asynchronous suspension>
#13     FlutterCommand.run.<anonymous closure> (package:flutter_tools/src/runner/flutter_command.dart:1043:27)
<asynchronous suspension>
#14     AppContext.run.<anonymous closure> (package:flutter_tools/src/base/context.dart:150:19)
<asynchronous suspension>
#15     CommandRunner.runCommand (package:args/command_runner.dart:196:13)
<asynchronous suspension>
#16     FlutterCommandRunner.runCommand.<anonymous closure> (package:flutter_tools/src/runner/flutter_command_runner.dart:284:9)

[✓] Flutter (Channel stable, 2.2.3, on Microsoft Windows [Version 10.0.15063], locale en-KE)
    • Flutter version 2.2.3 at C:\flutter
    • Framework revision f4abaa0735 (9 weeks ago), 2021-07-01 12:46:11 -0700
    • Engine revision 241c87ad80
    • Dart version 2.13.4

[✗] Android toolchain - develop for Android devices
    ✗ ANDROID_HOME = D:\Android\android-sdk
      but Android SDK not found at this location.

[✓] Chrome - develop for the web
    • Chrome at C:\Program Files (x86)\Google\Chrome\Application\chrome.exe

[✓] Android Studio (version 3.4)
    • Android Studio at C:\Program Files\Android\Android Studio
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1343-b01)

[✓] Connected device (1 available)
    • Chrome (web) • chrome • web-javascript • Google Chrome 92.0.4515.131

! Doctor found issues in 1 category.

Flutter Application Metadata
Type: app
Version: 1.7.0+8
Material: true
Android X: false
Module: false
Plugin: false
Android package: null
iOS bundle identifier: null
Creation channel: stable
Creation framework version: 1aafb3a8b9b0c36241c5f5b34ee914770f015818
Plugins
connectivity-0.4.9+5
connectivity_for_web-0.3.1+4
connectivity_macos-0.1.0+7
firebase_core-0.5.3
firebase_core_web-0.2.1+1
firebase_messaging-7.0.3
flutter_chat_bubble-1.0.2
flutter_facebook_login-3.0.0
flutter_plugin_android_lifecycle-1.0.11
geolocator-6.2.1
geolocator_web-1.0.1
google_maps_flutter-1.2.0
google_sign_in-4.5.9
google_sign_in_web-0.9.2
image_picker-0.6.7+22
libphonenumber-1.0.2
libphonenumber_plugin-0.1.0
libphonenumber_web-0.1.1
package_info-0.4.3+4
path_provider-1.6.28
path_provider_linux-0.0.1+2
path_provider_macos-0.0.4+8
path_provider_windows-0.0.4+3
permission_handler-5.1.0+2
screen-0.0.5
shared_preferences-0.5.12+4
shared_preferences_linux-0.0.2+4
shared_preferences_macos-0.0.1+11
shared_preferences_web-0.1.2+7
shared_preferences_windows-0.0.2+3
social_share-2.0.6
sqflite-1.3.2+4
url_launcher-5.7.10
url_launcher_linux-0.0.1+4
url_launcher_macos-0.0.1+9
url_launcher_web-0.1.5+3
url_launcher_windows-0.0.1+3
video_player-0.10.12+5
video_player_web-0.1.4+1
wakelock-0.1.4+2
webview_flutter-0.3.24

Hi @pmuiga, There is already a similar open issue describing this case https://github.com/flutter/flutter/issues/80418, You may follow up there for further updates closing this issue as a duplicate.
if you disagree feel free to write in the comments and I will reopen it.
Thank you


Allow exists method to handle out of bounds and wrong type errors

Allow the exists method to handle out of bounds and wrong type errors by checking for errorValue.code == ErrorIndexOutOfBounds and errorValue.code == ErrorWrongType.
For example, when we have let jsonForArray = JSON([["number":1111]]) we would expect jsonForArray[1].exists() and jsonForArray["someValue"].exists() to return false.
I think the change here might fix the issue related to https://github.com/SwiftyJSON/SwiftyJSON/issues/498

Sweet, can you help solve the conflict here and let's ship this.
Sorry for not getting to this earlier.

@zhigang1992 Okay, rebased


Depth Accuracy

Hello there,
I have some recorded RGB-D videos using D435 and real sense viewer, is there a way to get a kind of a metric that tells us how good the depth data was for each video?
Best Regards,

Hi @linahourieh  Whilst there is not a tool for providing feedback about the depth quality of recorded files, Intel's Camera Depth Testing Methodology PDF guide at the link below does outline a formal procedure for evaluating depth quality and discusses metrics.
https://dev.intelrealsense.com/docs/camera-depth-testing-methodology

Hi @linahourieh  Do you require further assistance with this case, please?  Thanks!

No that was helpful, Thank you for your assistance.

You are very welcome.  As you do not require further assistance, I will close this case.  Thanks very much for the update!


addObjectToUpdateQueue function the interrupt

dlhy.pdf
I think there should be a logical judgment
- (void) addObjectToUpdateQueue:(YPObject *)pdfObject
{
    //add to update array

    [updateObjectQueue addObject:pdfObject];     //Here the interrupt

    //[pdfObject getUncompressedStreamContents];
}

Pull-requests are welcome

If the PDF file format simple enough, in this place will cause the interruption of the program, because the judge is not doing enough. The annex to the test file problems.

use Xcode 7.3


Fix KNN if all Attributes are FloatAttribute

This fixes the problem with KNN discussed in issue #84.

If all the attributes are float attributes, will there be any difference between allNumericAttrs before and after this call?

Yes, allNumericAttrs shouldn't contain any class attributes afterwards. Does it fix the problem?

No because I am trying to fix a problem when the data doesn't have any class attributes.

@thedadams: would it be possible to rebase this?

@Sentimentron: Done.


Struggle in my TV

Struggling to connect my TV to hoobs/ HomeBridge 32LM6300PLA, are you experiencing problems with plug-in

Would be nice if you could post your config and setup and also what you tried so far so at least that would give us a small idea what is happening...

Of course I will but I’m gonna have to reinstall the plug-in because it kept crashing
Sent from my iPhone

On 20 Jan 2021, at 23:14, Marcin<EMAIL_ADDRESS>wrote:

Would be nice if you could post your config and setup and also what you tried so far so at least that would give us a small idea what is happening...
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

I've managed to get it installed using the home Manager app Took a bit of fiddling but I did manage to do it

I've managed to get it installed using the home Manager app Took a bit of fiddling but I did manage to do it

Nice. So it works now?

Nice. So it works now?

 Thanks for letting me know! The issue can ble closed i guess.

Ok, good that works now! Thanks for letting me know! The issue can ble closed i guess.


Add increment / decrement actions

Could prob steal implementation from https://github.com/AndreasArvidsson/andreas-talon-vscode

The Emmett action isn't perfect though. When used with a unit like "1rem" it doesn't do what I expect. I need to say "increment first char 1" to get increment to work.

yeah @AndreasArvidsson's version has a lot of little niceties


GPT-4 Api key not working

i add the key .env file

Looks like you're trying to grab a screenshot using a URL, for that you need to sign up for https://screenshotone.com/
Or you can take the screenshot yourself, and just drag/drop it.


Remove dependency on more_itertools

Codecov Report

Merging #226 into master will decrease coverage by 0.03%.
The diff coverage is 50%.

@@            Coverage Diff             @@
##           master     #226      +/-   ##
==========================================
- Coverage   78.91%   78.87%   -0.04%
==========================================
  Files          22       22
  Lines        3040     3044       +4
==========================================
+ Hits         2399     2401       +2
- Misses        641      643       +2

Impacted Files
Coverage Δ

corrscope/gui/util.py
52% <50%> (-0.18%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 00d20e9...de0947e. Read the comment docs.


add option to generate qrcode as base64 encoded PNG string to solve #39

I do not know if png_as_base64_str is a good method name

good. thanks.

I took the submitted pull request almost as is. I did a little bit of documentation alterations, but otherwise that was it.
I will integrating the pull request into the next version, that should be coming out in at most a couple of days.
Your contribution was greatly appreciated. I did not know about that base64 URL trick, before this.
Thanks.

unrelated information: Nose is officially unmaintained
http://nose.readthedocs.io/en/latest/#note-to-users


GAX Error - Could not construct ApplicationDefaultCredentials

Environment details

OS: Windows 10
PHP version: 7.3.28
Package name and version: google-ads-php v11.0.0

Steps to reproduce
Upgrading google-ads-php from version 6 to version 11, shouts Error.
Error
Google\ApiCore\ValidationException
Could not construct ApplicationDefaultCredentials From gax

Previously I'm using google-ads-php v6.0.0. I got error as Version v6 is deprecated. Therefore, I updraged to the current version v11.0.0 where I'm getting Error from gax.
Help me to sort this issue. Thanks in advance

@noahdietz , can you please triage this? Thanks!

@pierrickvoulet could you help us triage what has changed between v6 and v11 of the google-ads-php library?

@noahdietz The only related change that I can find is that we bumped the minimal version of gax-php from ^1.5.0 to ^1.7.0. We did not change anything in the authentication logic as far as I know.
@hkdevandla Do you know by any chance what version of gax-php you were using before upgrading google-ads-php to 11.0.0?

Thanks @PierrickVoulet that helps.

Do you know by any chance what versions of gax-php you were using before upgrading google-ads-php to 11.0.0 and after upgrading?

@SubaKrishnan can you answer this?

Sorry for the delay, Earlier I used gax-php V1.6 After Updating to v1.7 I received this error.
I fixed this issue. In Laravel Application, $clientOptions variable which passes the credentials doesn't return any value. Because Oauth hadn't been recognized properly in AppServiceProvider. Now, It works fine.
Thanks guys

Sure..Thanks for your time


Add keymaps for linux and windows

Addresses #16

Thank you for your Pull Request!
I've checked that it works with Windows.
@penginryo Could you merge it if it doesn't have any problem with Linux?

I can confirm that it works on linux (ubuntu)

Thanks @andreas-bok-sociomantic @changami


WIP: Fix empty line when "lines" have a trailing ";" separator

Description
This PR trims trailing ";" separators from the lines query param before separating them into a list.
This prevents an empty line to be animated.
Fixes #25
Type of change

[x] Bug fix (added a non-breaking change which fixes an issue)
[ ] New feature (added a non-breaking change which adds functionality)
[ ] Updated documentation (updated the readme, templates, or other repo files)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?
I have yet to test the bug fix locally
A new test case is not needed in my opinion.

[ ] Ran tests with composer test
[ ] Added or updated test cases to test new features

Checklist:

[x] I have checked to make sure no other pull requests are open for this issue
[x] The code is properly formatted and is consistent with the existing code style
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings

This looks good. :+1: Maybe you could also add a unit test for this feature?
You could probably just copy the testCardRender() one and put  . ";" at the end of the lines parameter to concatenate an extra semicolon.


Enable gpp api on fides js bundles via developer option

Closes #PROD-1946
Description Of Changes
depends on PR #4780 to be merged first!
Updates fides.js to accept a new query string option that ensures the GPP API is always included.
When the GPP API is included, it sets applicableSections: [-1] whenever a user visits a page from a location that is not one of the supported sections.
Code Changes

adds support for new gpp=true query string option
includes gpp in fides.js response regardless of location when query string is present
Cypress tests to ensure inclusion as well as expected applicableSections: [-1] result

Steps to Confirm

visit demo page with query string included and from a location that is not supported (eg. http://localhost:3000/fides-js-demo.html?gpp=true&geolocation=us-id)
inspect the GPP API and by calling the following from the browser console:

__gpp('ping', (data) => {console.log(data)})

note that applicableSections property in that response is set to [-1]

__gpp('ping', (data) => {console.log(data.applicableSections)})

Pre-Merge Checklist

[ ] All CI Pipelines Succeeded(https://github.com/ethyca/fidesdocs/issues/new/choose)
[x] Issue Requirements are Met
[x] Update CHANGELOG.md

got messed up with rebase. Starting over.


[Feature request] Add thumbnail option for tiles

Hi,
First of all, thanks for putting up this extension - I'm coming back to Chrome from Vivaldi and Vivaldi's Speed Dial experience is what I'm missing the most at the moment.
I'd like to ask if there's a future plan to include thumbnails as the tile's images.
Also, I'm a Front-end Developer (React) and I could try to find some spare time to help with small improvements/features since I'm very interested in using the extension myself. :)

Hi @fmaiabatista! Thank you for the comment!
I have looked into this in the past year, and there isn't a way to generate site thumbnails that would align with a core philosophy for Toolbar Dial of being privacy friendly. Below is a link to what I found after looking into this last year.
https://github.com/lucaseverett/toolbar-dial/issues/14#issuecomment-637915730

Oh, that's super fair. Thanks for clarifying this and also my bad that I didn't investigate previous closed issues in the repo. I'm closing this one then :)


no-unused-variable false positive when variable is declared outside of a module

simple repro code:
const fs = require("fs");

module Foo {
    const path = require("path");

    console.log(fs);
    console.log(path);
}

tslint reports 'fs' on line 1 is unused.

Possibly related to if there is a surrounding scope or not.  Problem seems to happen somewhere in the getReferencedSymbolsForNode function in services.ts (see below for excerpt). With a surrounding scope, the code enters the if statement below and the proper number of references are added to result. If there's not a surrounding scope, it enters the else branch and only the initial declaration is added to result. Unfortunately, unsure why at this point.
            // Try to get the smallest valid scope that we can limit our search to;
            // otherwise we'll need to search globally (i.e. include each file).
            let scope = getSymbolScope(symbol);

            // Maps from a symbol ID to the ReferencedSymbol entry in 'result'.
            let symbolToIndex: number[] = [];
            if (scope) {
                result = [];
                getReferencesInNode(scope, symbol, declaredName, node, searchMeaning, findInStrings, findInComments, result, symbolToIndex);
            }
            else {
                let internedName = getInternedName(symbol, node, declarations)
                for (let sourceFile of sourceFiles) {
                    cancellationToken.throwIfCancellationRequested();

                    let nameTable = getNameTable(sourceFile);

                    if (lookUp(nameTable, internedName)) {
                        result = result || [];
                        getReferencesInNode(sourceFile, symbol, declaredName, node, searchMeaning, findInStrings, findInComments, result, symbolToIndex);
                    }
                }
            }

Additional failure example:
class HelloWorld {
    constructor(public name: string) { }
    sayHello() {
        return `Hello, ${this.name}!`;
    }
};

let hello = new HelloWorld("TSLint");
hello.sayHello();

This is a bad bug, going to try to get it fixed ASAP.

@JKillian @adidahiya - can I ask, is this the following an instance of the same issue? Or a problem specific to .tsx files?
/// <reference path="tsd.d.ts" />

import * as React from "react";
interface IMProps {
	Name: string;
}

export class HelloMsg extends React.Component<{}, {}> {
	constructor() {
		super();
	}
	render(): JSX.Element {
		let props: IMProps = { Name: "test" };

		return

				<Msg {...props} />

;
	}
}

export class Msg extends React.Component<IMProps, {}> {
	constructor() {
		super();
	}
	render(): JSX.Element {
		return

;
	}
}

$ tslint -c app/tslint.json app/**/*.{ts,tsx}
app/example.tsx[13, 7]: unused variable: 'props'

Configuration as follows:

TypeScript v1.6.0-dev.20150907
tslint v2.5.0-dev.5
tsconfig.json:

{
  "compilerOptions": {
    "target": "es5",
    "module": "system",
    "declaration": false,
    "noImplicitAny": true,
    "removeComments": false,
    "noLib": false,
    "sourceMap": true,
    "jsx": "react",
    "rootDir": ".",
    "outDir": "../dist/"
  }
}

tslint.json

@myitcv I think what you're seeing is a similar, but different problem. I'm looking into it more though

I'm getting false positive when using import variables in another import statement. (due to rule 'no-unused-variable'). Below is sample code.
import ExternalDefinition = require("ExternalDefinition");
import Def = ExternalDefinition.MyNamespace.MyClass1;

export class MyImplementation
    extends MyBaseClasses.BaseClass1
    implements Def.Contract {

}

I get below error even though 'ExternalDefinition' is used in another import statement:

TsLint: unused variable: 'ExternalDefinition'

@JKillian - just in case you haven't seen the link, I think I tracked it down to this:
https://github.com/Microsoft/TypeScript/issues/4688

Thanks both. @myitcv nice find, looks like it is a TypeScript bug. Hopefully they'll get that fixed pretty soon and then we'll be sure to get that into TSLint.
@praveennet Yours is because of a TSLint bug which I discuss here. I'm working on getting that fixed, (hopefully) should be released by next Friday.

@JKillian - no problem. I've found that using these tests as a template for finding issues like this really useful.

@JKillian @adidahiya - just so that I'm clear, are we thinking this issue is a separate bug and needs fixed from TypeScript core?
If so I'll open a new issue to track that.

If the fourslash test is failing, definitely a TypeScript issue.

@JKillian hi,
I am using tslint version 3.14.0 and I just got a false positive similar to the one @praveennet got.
Is there a way to prevent it?
thanks!
Avichai

@hashark I recommend using TS 2.0, these bugs should be fixed in it.

just tried and it still shows the false positive results


2022-02-14 - KDB Project Call Meeting Agenda

Date
Monday, February 14, 2022 - 9:30am ET / 2:30pm UK
// Second Monday of every month
Attendees

Fullname
Affiliation
GitHub Username

Meeting notices

FINOS Project leads are responsible for observing the FINOS guidelines for running project meetings. Project maintainers can find additional resources in the FINOS Maintainers Cheatsheet.

All participants in FINOS project meetings are subject to the LF Antitrust Policy, the FINOS Community Code of Conduct and all other FINOS policies.

FINOS meetings involve participation by industry competitors, and it is the intention of FINOS and the Linux Foundation to conduct all of its activities in accordance with applicable antitrust and competition laws. It is therefore extremely important that attendees adhere to meeting agendas, and be aware of, and not participate in, any activities that are prohibited under applicable US state, federal or foreign antitrust and competition laws. Please contact<EMAIL_ADDRESS>with any questions.

FINOS project meetings may be recorded for use solely by the FINOS team for administration purposes. In very limited instances, and with explicit approval, recordings may be made more widely available.

Agenda

(5 min) Convene, roll call, welcome new people.
[ ] Display FINOS Antitrust Policy summary slide
[ ] Review Meeting Notices (see above)
(5 min) Approve previous meeting minutes.
(10 min) Possibility of integrating FINOS Perspective with Boothroyd / Studio?

https://perspective.finos.org/
Other FINOS projects that have made strides?
What's out there already:

https://code.kx.com/dashboards/
https://www.aquaq.co.uk/aquaq-grafana-8-0-plugin-for-kdb/

(5 min) How are things going with going with Technical Steering Committee?

https://github.com/finos/community/issues/153
Is there a sense of the domain expertise being sought?

(10 min) Updates on kdb Studio (FINOS / dzmipt)?

Quite a few PRs as of late.

(5 min) Inclusive Language.

Default branch has been renamed for: kdb, qPython, and kdb-studio .

https://github.com/finos/kdb/issues/65

Transition reasonably smooth?

(5 min) kdb on Blob storage?

Use cases?
SLA?
What's been tried so far?

(5 min) Did call for Business Analysis / Technical Writers from all-community call get any traction?
(5 min) Anomaly detection package for data quality checks?

https://code.kx.com/q/ml/
New HDB partition has a reasonable distribution of data?
Last 30 seconds of RDB data has reasonable distribution?
Where to store model parameters?

(5 min) AOB, Q&A, Adjourn.

LF Security Integration and badge - @mcleo-d

WebEx info
Webex

https://finos.webex.com/finos/j.php?MTID=me61719ca3c3295a7cc76762d78392bc3

Dial-in and Project Materials

US: +1-415-655-0003 US Toll
UK: +44-20319-88141 UK Toll
Access code: 2704 417 0390
GitHub Repos:

https://github.com/finos/kdb
https://github.com/finos/kdb-studio

Wiki Page:

https://finosfoundation.atlassian.net/wiki/spaces/DT/pages/329383945/kdb+Project

KDB Metrics on FINOS

https://metrics.finos.org/goto/033b15c80f0d08cab70f40f4358932f6

hi

Hello 🧇

Howdy!

hi

https://github.com/jpmorganchase/opencell


Noise flooding

It would be nice to have an example of performing noise flooding to get function privacy in a user-friendly manner. I tried looking at the manual but the references linked therein (such as this) weren't super informative.

In principle this would be nice, however, there are some reasons why it's "tricky" and hasn't been included:

Since SEAL doesn't currently have a noise-growth estimator (for BFV), it's hard to know how much flooding is needed to achieve any desired level of function privacy. You would always flood the noise up to a certain level, but you don't know what the starting level was; it's the difference that matters though.
Even if SEAL did have a noise growth estimator, note that noise flooding is only secure in a semi-honest security model. For example, someone can give you a ciphertext with bigger noise than expected, and claim that it is a normal freshly encrypted ciphertext. Now after a computation you think it has a certain amount of noise, and you noise-flood, but actually you flooded by less than you thought.
Noise flooding isn't very friendly with CKKS, so its utility is kind of limited.

Perhaps we could add functionality to do this in some form, but it's hard for me to see how a generally usable implementation should or could work.

In principle this would be nice, however, there are some reasons why it's "tricky" and hasn't been included:
1. Since SEAL doesn't currently have a noise-growth estimator (for BFV), it's hard to know how much flooding is needed to achieve any desired level of function privacy. You would always flood the noise up to a certain level, but you don't know what the starting level was; it's the difference that matters though.

When you say there is no noise-growth estimator, you mean an estimator without using the secret key, right? Cause you do have one using the secret key.
Is there any theoretical obstacle to having a noise estimator in the semi-honest setting?

On a separate note, assume we want to use a noise flooding technique such as the "smudging lemma" suggested by this or this.
Is there any built-in functionality to generate an encryption of zero with a specific noise level?

When you say there is no noise-growth estimator, you mean an estimator without using the secret key, right?

Yes.

Is there any theoretical obstacle to having a noise estimator in the semi-honest setting?

There are heuristic methods for noise-growth estimation. However, there is a gap between estimation and real noise -- estimation tends to be larger, with any of those methods. To me personally, I think such an estimator should be implemented by an compiler for HE programs rather than by an HE library itself.

Is there any built-in functionality to generate an encryption of zero with a specific noise level?

There is no function that does noise flooding or re-randomization in SEAL. To achieve either, you have to implement it. SEAL does provide encryption of zero with default noise level and random number generation methods for a various distributions. Further, public keys can be treated as encryptions of zeros -- it's possible to generate a large set of public keys just for re-randomization in a semi-honest setting.


explain script

@couralex6 do you mind if I branch off this and pull the explain/execute stuff into it's own class?


Overriding UserCreateSerializer doesn't work

I'm trying to override from djoser.serializers import UserCreateSerializer to add a none User related field to the registration form and to validate that my self. The UserCreateSerializer's methods are being called and the user is being created successfully but my methods bellow are not being called at all, is that an intended behavior?
serializers.py
from djoser.serializers import UserCreateSerializer
from django.contrib.auth import get_user_model

User = get_user_model()

class UserCreateSerializer(UserCreateSerializer):
    class Meta(UserCreateSerializer.Meta):
        model = User
        fields = ('id', 'email', 'username', 'password')

    def validate(self, attrs):
        return super().validate(attrs)

    def create(self, validated_data):
        return super().create(validated_data)

settings.py
My settings
'SERIALIZERS': {
        'user_create': 'accounts.serializers.UserCreateSerializer',
    }

Uff...
The problem was that I have USER_CREATE_PASSWORD_RETYPE set to True that's why user_create_password_retype is actually the one being used instead of user_create.
I wish the docs mentioned this (maybe it does?), although it should've been obvious to me anyway.


what is the best way to save Request while offline ?

if I wanna send data to sever from page, but wanna also support offline using background sync.
// sending body 'a=b' to server
self.addEventListener('fetch', (e) => {
  let req = e.request;
  // delegate to background sync
  self.addEventListener('sync', (e) => {
    fetch(req).then(/*....*/)
  });
  e.respondTo(new Response('dummy'));
});

but in this case, req are at local memory, so this will remove when service worker process are down before sync event fired (in my understanding).
so I need to save req to somewhere.
but I don't have response, for saving this to caches.
(saving request with dummy response to caches seems bad hack.)
should I keep body in this request to indexed db ?
it seems heavy for me to initialise / saving / getting IDB for saving only "a=b".
localStorage seems fit with this,
it's handy to save body 'a=b' with some key and grab this when 'sync' event.
but I know that I can't touch it in sw because of sync api.
is there any other way to save body or request ?
or localStorage will have Async API (returning promise) are welcome !!

Personally I think having a Cache object with "pending requests" and empty responses would be fine.  It won't let you store requests with methods other than GET or HEAD, though.  So if you need store a POST you must convert to IDB.

you must convert to IDB

thanks, but this must means, we don't have other way.
if I have Async localStorage, it better to use in this case I think.
or say same thing in other words,
if cache api is more general as kvs, it'll fits for this case.
for example
class AsyncStorage // async localStorage
class Cache extends AsyncStorage // which specialized for Request/Response
class LocalStorage // sync wrapper for AsyncStorage

how do you think about it ?

move to #906

@Jxck take a look at Request Deferrer.


Slider like the stories on Instagram

It's possible to render the expirence of the slider like in the stories of instagram. i would to swipe through the images without the restricion of the pages, when i release the cursor/finger I want the slider to remain in that perfect position.

There is another react library that mimics the functionality of Instagram stories; react-insta-stories


Add links to movies

Same as album, add imdb, metacritic, etc

Fixed by https://github.com/nf-s/nfs-media-manager/commit/a7d267fd99b8e23758da316623b4ee243c0338bd


CVAT.js (part 1)

The list of changes:

Two extra configurations for VS Code (for debugging of source code and jest)
Dashboard uses CVAT.js in order to show, create, update and delete tasks
Updated plugins. Notably Git application uses plugin system of CVAT.js in order to pull a repository
Changed pagination library (previous doesn't support needed scenario)
CVAT.js part of functionality implemented + 29 tests with jest have been written + documentation
The "flipped" field was removed anywhere

@bsekachev , let's fix the patch ASAP and merge into develop. Artyom depends on the patch. Let's discuss on our meeting tomorrow.

@nmanovic
I wrote the first version of migration script. It works on my local server, but I have to check it on the production database.
Also I checked how many tasks have been flipped. And there are only 4 tasks.

@nmanovic
Migration worked okay with our database and images.
It took about 10 minutes.

@bsekachev , I will merge the PR just to move forward. Please look at the migration file and fix it.


Broken WorkerExtensionStartupCodeExecutor generation when FunctionsApp referenced by XUnit test project.

When referencing a function app by an XUnit test project (may happen in other ways as well) the namespace does not get generated correctly. The error shows up against the test project. This happens on the latest version of https://www.nuget.org/packages/Microsoft.Azure.Functions.Worker.Sdk/1.16.3
I would share my solution but its proprietary so I can't, rolling back to the immediate previous version (1.16.2) fixed the issue for me, should be easy enough to work out what caused this..
Below is what was generated.
[assembly: WorkerExtensionStartupCodeExecutorInfo(typeof(.WorkerExtensionStartupCodeExecutor))]
namespace
{
[global::System.ComponentModel.EditorBrowsableAttribute(global::System.ComponentModel.EditorBrowsableState.Never)]
[global::System.Runtime.CompilerServices.CompilerGeneratedAttribute()]
internal class WorkerExtensionStartupCodeExecutor : WorkerExtensionStartup
{
///

Looks like namespaceValue is null here:
https://github.com/Azure/azure-functions-dotnet-worker/blob/5ff83ce0fdf244536cea093686540b424dbfc1ea/sdk/Sdk.Generators/ExtensionStartupRunnerGenerator.cs#L94-L98
https://github.com/Azure/azure-functions-dotnet-worker/blob/5ff83ce0fdf244536cea093686540b424dbfc1ea/sdk/Sdk.Generators/FunctionsUtil.cs#L81-L89
"Constants.BuildProperties.GeneratedCodeNamespace" is not found in GeneratorExecutionContext

Having the same issue with an NUnit Test Project as well.

Hi all - can we get a few additional details on the repro setup? It would be good to know what namespaces are used in which project, how they differ, etc. Can we also get confirmation of the project relationships (how referenced) and project settings, such as .NET version, etc.?

Hi all - can we get a few additional details on the repro setup? It would be good to know what namespaces are used in which project, how they differ, etc. Can we also get confirmation of the project relationships (how referenced) and project settings, such as .NET version, root namespace, etc.?

Not the OP, but having the same issue. My projects are structured as:
Function App with my functions with the following namespace:
namespace Project.Functions;
then a Xunit project that references it, with a namespace:
Project.Tests.Functions;

Thanks for the feedback. We were able to reproduce the issue and will investigate this. I will share an update here as we make progress. Until then please use 1.16.2 to mitigate the issue. Thank you for your understanding and cooperation.

We Identified the root cause of the issue. This was an old issue which is uncovered in 1.16.3. Our source generator is being executed in the context of the test project and it fails to produce the correct code due to lack of certain msbuild properties.
While we are working on getting a fix out, you can mitigate the issue by adding the below code snippet  inside the Project element of your .csproj file.
<PropertyGroup>
  <FunctionsGeneratedCodeNamespace>GiveAnyValueYouWantToGiveHere</FunctionsGeneratedCodeNamespace>
</PropertyGroup>
<ItemGroup>
  <CompilerVisibleProperty Include="FunctionsGeneratedCodeNamespace" />
</ItemGroup>

Ideally it should not run in the context of the test functions. That is the fix we are making and hoping to have this fix out early next week.

@lukehanlon you can work around this by add PrivateAssets="all" to the SDK package reference
<PackageReference Include="Microsoft.Azure.Functions.Worker.Sdk" Version="..." PrivateAssets="all" />

@lukehanlon We have released a new version of the Microsoft.Azure.Functions.Worker.Sdk which fixes this issue. Could you please upgrade to that version?
https://www.nuget.org/packages/Microsoft.Azure.Functions.Worker.Sdk/1.16.4-preview1

@lukehanlon We have released a new version of the Microsoft.Azure.Functions.Worker.Sdk which fixes this issue. Could you please upgrade to that version?
nuget.org/packages/Microsoft.Azure.Functions.Worker.Sdk/1.16.4-preview1

this solved the issue for me


Add local player death event

Due to the removal of ActorDeath event and the despawn event not getting called for the local player, it was suggested by Adam to have a LocalPlayerDeath event.

@Adam- fixed


Fix showing translations for languages with no key set

This PR fixes showing translations where there is no key for a lanauge.
For example, currently, if you set locales to fa and en and a translatable field value is {"en": null}, An error will be shown:
foreach() argument must be of type array|object, string given

Merged with #133


schema-ast does not comment descriptions at the same time as including directives

Describe the bug
As soon as includeDirectives is set to true, the value of commentDescriptions no longer matters: comments will always be generated as docstrings.
To Reproduce
schema: schema.graphql
documents: document.graphql
generates:
  types.ts:
    plugins:
      - typescript
      - typescript-operations
  schema.generated.graphql:
    plugins:
      - 'schema-ast'
    config:
      includeDirectives: true
      commentDescriptions: true

Link to Codebox for reproduction: https://codesandbox.io/s/bold-bird-wuf3p?file=/codegen.yml
Expected behavior
It is possible to include directives and comment descriptions at the same time.
Schema
type Query {
    user(id: ID!): User!
}

"""
TESTING
"""
type User {
    id: ID!
    username: String!
    email: String!
}

Environment:

OS: Ubuntu 20.04
"@graphql-codegen/add": "2.0.2",
"@graphql-codegen/cli": "1.20.1",
"@graphql-codegen/schema-ast": "2.1.0",
"@graphql-codegen/typescript": "1.21.0",
"@graphql-codegen/typescript-operations": "1.17.14",
"graphql": "15.5.0""graphql": "^15.5.1",
NodeJS: 14.x

I don't see any directives in the reproduction.

@ardatan yes, but there is a comment in the reproduction and that comment is kept as docstring although the plugin docs say that it should be converted: https://www.graphql-code-generator.com/docs/plugins/schema-ast
when you set includeDirections: false you'll see that the docstring gets correctly converted.


fix 'static_url_path' defaulting for empty paths

the documentation of the application object specifies static parameters:
static_url_path – can be used to specify a different path for the static
files on the web. Defaults to the name of the static_folder folder.
static_folder – the folder with static files that should be served at
static_url_path. Defaults to the 'static' folder in the root path of the
application.
so by my understanding,
app=Flask(__name__, static_folder='')
should allow for arbitrary (absolute) path structure for all static
files. it doesn't. but the following does:
app=Flask(__name__, static_folder='', static_url_path='')
given the above doc strings, that appears inconsistent
for this specific case (static_folder=''), stepping through the
codebase yielded:
<Rule '//' (GET, OPTIONS, HEAD) -> static>
re.compile('^\\|//(?P<filename>[^/].*?)$')
which is an expression that can never be satisfied by a valid url
please consider this trivial patch. i hope the tests are appropriate
too, it was difficult to know how much of the mechanism to incorporate
for such a small change
commit message:
-prefix a path delimiter iff there's a path to delimit
-ensures a valid default static route rule is created on application
intialisation for the case 'static_folder=""' and implicit
'static_url_path'
todo

add a changelog entry if this patch changes code

It looks like this was addressed in a different way by #3182, but this solution seems more correct.


Added ability to run MailMerge as a context manager

This fixes the resource leak problem as caller can open mailmerge with the with statement which then makes sure that zip file is closed.
This is actually a fairly critical change when using MailMerge on a server (as we do) when lots of zip/docx files are being opened but it is not guaranteed that they are closed.

https://github.com/Bouke/docx-mailmerge/pull/30 needs to be merged first before CI will run on this PR.

Thank you for your contribution. What strikes me as odd about this issue (memory leak), is that I feel like this should be handled by garbage collection. Once there are no references to the object MailMerge, it can be destructed and thus there will be no more references tot he ZipFile, which can be destructed and no memory should leak. Or am I missing something here?

This is not guaranteed in case of resources. See discussion here as a summary: https://stackoverflow.com/questions/7395542/is-explicitly-closing-files-important?answertab=votes#tab-top
What this PR does giving the ability to run MailMerge in a context manager when needed. If someone doesn't see a need in his use case MailMerge still works as before without closing so this change is 100% backwards compatible.

Thank you for the clarification, looks like a great stability improvement to add. 👍


Align the structure of model property

API change check
API changes are not detected in this pull request.


LinkedIn Converstion Tracking

Description

Related Issue(s)

Checklist

[ ] I have read the contribution guidelines
[ ] I have considered the performance impact of these changes
[ ] Suitable unit/system level tests have been added and they pass
[ ] Documentation has been updated

@Hasmin-AC Did you test this on the deployment preview?

@Hasmin-AC I was under the impression this would be implemented through Google Tag Manager, so there wouldn’t be a need to add more code.
Would you mind sharing the documentation with the instructions? Just to confirm it’s in the right place.

I was able to connect HS to LinkedIn so we can track conversion from HS now. Looks like we don't need this code.


Whse.-Activity-Register - UpdateTempBinContentBuffer invalide Key

The key of table Bin Content Buffer has changed from
"Location Code", "Bin Code", "Item No.", "Variant Code", "Unit of Measure Code", "Lot No.", "Serial No."
to
"Location Code", "Bin Code", "Item No.", "Variant Code", "Unit of Measure Code", "Lot No.", "Serial No.", "Package No."
But in Codeunit Whse.-Activity-Register in function UpdateTempBinContentBuffer is a get to the old key.
So it is not possible to create a Put-away to two Lots on one Bin
 local procedure UpdateTempBinContentBuffer(WhseActivLine: Record "Warehouse Activity Line")
    var
        WMSMgt: Codeunit "WMS Management";
        UOMCode: Code[10];
        Sign: Integer;
    begin
        with WhseActivLine do begin
            if Location."Directed Put-away and Pick" then
                UOMCode := "Unit of Measure Code"
            else
                UOMCode := WMSMgt.GetBaseUOM("Item No.");
-            if not TempBinContentBuffer.Get("Location Code", "Bin Code", "Item No.", "Variant Code", UOMCode, "Lot No.", "Serial No.")
+            if not TempBinContentBuffer.Get("Location Code", "Bin Code", "Item No.", "Variant Code", UOMCode, "Lot No.", "Serial No.", "Package No.")
            then begin
                TempBinContentBuffer.Init();
                TempBinContentBuffer."Location Code" := "Location Code";
                TempBinContentBuffer."Zone Code" := "Zone Code";
                TempBinContentBuffer."Bin Code" := "Bin Code";
                TempBinContentBuffer."Item No." := "Item No.";
                TempBinContentBuffer."Variant Code" := "Variant Code";
                TempBinContentBuffer."Unit of Measure Code" := UOMCode;
                TempBinContentBuffer.CopyTrackingFromWhseActivityLine(WhseActivLine);
                OnUpdateTempBinContentBufferOnBeforeInsert(TempBinContentBuffer, WhseActivLine);
                TempBinContentBuffer.Insert();
            end;
            Sign := 1;
            if "Action Type" = "Action Type"::Take then
                Sign := -1;

            TempBinContentBuffer."Base Unit of Measure" := WMSMgt.GetBaseUOM("Item No.");
            TempBinContentBuffer."Qty. to Handle (Base)" := TempBinContentBuffer."Qty. to Handle (Base)" + Sign * "Qty. to Handle (Base)";
            TempBinContentBuffer."Qty. Outstanding (Base)" :=
              TempBinContentBuffer."Qty. Outstanding (Base)" + Sign * "Qty. Outstanding (Base)";
            TempBinContentBuffer.Cubage := TempBinContentBuffer.Cubage + Sign * Cubage;
            TempBinContentBuffer.Weight := TempBinContentBuffer.Weight + Sign * Weight;
            TempBinContentBuffer.Modify();
        end;
    end;

Version: DE Business Central 18.3 (Plattform 18.0.27224.27469 + Anwendung 18.3.27240.27480)

Platform automatically detect right key, even if you only type few first fields for the key, so key
"Location Code", "Bin Code", "Item No.", "Variant Code", "Unit of Measure Code", "Lot No.", "Serial No.", "Package No."
used here.

My problem with this solution ist, that I have a Put-away with a splitted Place line, so I have two lines who the values of "Location Code", "Bin Code", "Item No.", "Variant Code", "Unit of Measure Code", "Lot No.", "Serial No." and "Package No." are the same. Now the get find no record, because the Get looks for a record witch Package No. '' and insert a new line with the already existing Key

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.


pubsublite.ReadWriteIT flaky in beam_PostCommit_Java_DataflowV2

https://ci-beam.apache.org/job/beam_PostCommit_Java_DataflowV2/758/testReport/org.apache.beam.sdk.io.gcp.pubsublite/ReadWriteIT/testReadWrite/
java.lang.AssertionError: Did not receive signal on projects/apache-beam-testing/subscriptions/result-subscription--5335365384640437489 in 300s
Imported from Jira BEAM-13025. Original Jira may contain additional context.
Reported by: ibzib.

.close-issue

Closing because test has been passing consistently for the past couple of months


OkHttpClient.setRetryOnConnectionFailure(true)

Hi, I am trying to understand the use of retrying a connection and I checked inside OkHttpClient class. The value is set to an internal boolean variable 'retryOnConnectionFailure' inside the OkHttpClient class, but I don't see it being referenced anywhere else. Could anybody please help me understand how a connection retry happens inisde OkHttp?

Probably a better question for stackoverflow.

(This issues tracker is strictly for bug reports and feature requests.)


build: Use commitizin as a dev-dependency instead of extra

Fix #95

thanks @vkurilin
indeed, it should not be there. The better alternative is to use dependency groups,
but well have to wait for poetry 1.2 for that.


min and max Dates for a range selection.

I am making a customized range selector which includes 2 datetime pickers.
I want them to be dependent on each other.
So the left one can not select a date after the date selected in the right one.
And the right one can not select a date before the date selected in the left one.
I am doing this with the beforeRender function.
I have 2 questions.

how can I in the beforeRender detect which of my picker triggered it so I can use the right date for comparison ?
how can I trigger a re-render of the other picker when a date is selected so the selectable dates are visualy updated ?

Kind regards

on-before-render uses expression binding so you can pass in an additional parameter (perhaps the model name?) that will indicate the source of the event.  There are examples of this in demo/index.html - look for an ng-repeat (it's not using on-before-render but you will see how to pass a parameter on expression binding)
Sorry, there is currently no way to trigger a re-render. There might be some work around that I am not aware of.

Thanks, I have got the left/right working.
Now to find a way to update it when I want.


How to put the people in the picture into the volume space?（As shown in the picture blow in the paper）

I think that's just a simple diagram. try draw.io

I think that's just a simple diagram. try draw.io

Thanks for reply! But I still want to know if this is merely a schematic diagram, then where do the three-dimensional point coordinates input for the neural network come from? If they are obtained from estimated human poses, then the key points of the human body seem too sparse. Therefore, I would like to know how the observation space is obtained. Or perhaps my understanding of the paper is mistaken?

I have the same question. When we render a specific frame, we get 100 views of that specific frame. So, does this mean the output consists of just frames and not a 3D representation with free-viewing possibilities? Did I misunderstand something?


[KYUUBI #3131] use \n to replace , in operation state change logging

Why are the changes needed?

closes https://github.com/apache/incubator-kyuubi/issues/3131
How was this patch tested?
before:
2022-07-25 14:03:31.391 INFO org.apache.kyuubi.operation.ExecuteStatement: Processing anonymous's query[183ee841-16b5-4444-a53f-3e8966e6af69]: INITIALIZED_STATE -> PENDING_STATE, statement: select 1
2022-07-25 14:03:31.410 INFO org.apache.kyuubi.operation.ExecuteStatement: Processing anonymous's query[183ee841-16b5-4444-a53f-3e8966e6af69]: PENDING_STATE -> RUNNING_STATE, statement: select 1
2022-07-25 14:03:31.433 INFO org.apache.kyuubi.operation.ExecuteStatement: Processing anonymous's query[183ee841-16b5-4444-a53f-3e8966e6af69]: RUNNING_STATE -> FINISHED_STATE, statement: select 1, time taken: 0.42 seconds
2022-07-25 14:03:31.446 INFO org.apache.kyuubi.operation.ExecuteStatement: Processing anonymous's query[183ee841-16b5-4444-a53f-3e8966e6af69]: FINISHED_STATE -> CLOSED_STATE, statement: select 1

after:
2022-07-25 14:29:14.750 INFO org.apache.kyuubi.operation.ExecuteStatement: Processing anonymous's query[22ae85cb-2ce7-4826-ba49-dde87a378c22]: INITIALIZED_STATE -> PENDING_STATE, statement:
select 1
2022-07-25 14:29:14.829 INFO org.apache.kyuubi.operation.ExecuteStatement: Processing anonymous's query[22ae85cb-2ce7-4826-ba49-dde87a378c22]: PENDING_STATE -> RUNNING_STATE, statement:
select 1
2022-07-25 14:29:15.369 INFO org.apache.kyuubi.operation.ExecuteStatement: Processing anonymous's query[22ae85cb-2ce7-4826-ba49-dde87a378c22]: RUNNING_STATE -> FINISHED_STATE, statement:
select 1
time taken: 0.54 seconds
2022-07-25 14:29:15.486 INFO org.apache.kyuubi.operation.ExecuteStatement: Processing anonymous's query[22ae85cb-2ce7-4826-ba49-dde87a378c22]: FINISHED_STATE -> CLOSED_STATE, statement:
select 1

Why are the changes needed?

Codecov Report

Merging #3132 (6797f94) into master (0b3f6b7) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##             master    #3132   +/-   ##
=========================================
  Coverage     51.31%   51.32%
  Complexity        6        6
=========================================
  Files           458      458
  Lines         25388    25388
  Branches       3536     3536
=========================================
+ Hits          13029    13030    +1
- Misses        11115    11116    +1
+ Partials       1244     1242    -2

Impacted Files
Coverage Δ

...rg/apache/kyuubi/operation/AbstractOperation.scala
81.70% <100.00%> (ø)

...org/apache/kyuubi/operation/ExecuteStatement.scala
80.51% <0.00%> (ø)

...rg/apache/kyuubi/ctl/cmd/log/LogBatchCommand.scala
82.00% <0.00%> (+2.00%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us.

Why are the changes needed?

@yaooqinn it's for help lookup the log, the statement will print several lines as the screen size is limited. The pr description can not show the issue that the markdown style will always use one line even if the string is long.

can we print the statement once only in case RUNNING branch?

I think we can, it's real noisy

thank you for review, merging to master


Adding metric for checking node management

Related ticket: https://github.com/CartoDB/cartodb-management/issues/4986
cc @CartoDB/frontend @CartoDB/builder-backend

I think this will need backend changes, because Guido was a troll and we validate that events exist, right?

I remembered something like that and that's what I wanted your opinion 💃  💋  ❤

Added to our TODO column, stay tuned.

Great thanks mates!

Just taken into account with FullStory ^^^ 💃 .


fatalError("add image icon in UITabBarItem") but image aleary added

guard let itemImage = item.image else {
        fatalError("add image icon in UITabBarItem")
      }

Exception from this line
<tabBarItem
    key="tabBarItem"
    title=""
    image="footer_icon_02_00"
    selectedImage="footer_icon_02_00"
    id="LJR-hK-R4Q"
    customClass="RAMAnimatedTabBarItem"
    customModule="RAMAnimatedTabBarController">

However, every item on the storyboard has an image added
What is the problem?
super.viewDidLoad()
        let items = tabBar.items
        for item in items!{
            let image = item.image!
        }

In addition, I've tested this code and I've definitely added an image
version information : 'RAMAnimatedTabBarController', '~> 2.0.13' / swift3

I have this problem too

Have you got solution for this???

Deleting the exception line will work normally.
However, when the animation is not playing, the icon is not visible.
In this case, the animation will be resolved by stopping the frame at the 0th index.

make sure that you set custom image for Bar Item (not Tab Bar Item)