JavaScript viewer update

Updates:

Add USD and glTF as loadable materials.
Add in geometry switcher to select glTF files to load.
Fix texture flipping.
Fix when default url options not set.
Update camera to more closely match desktop viewer.
For boombox example add in images and image path mapping. Search pathing has not been added to viewer so adding to manual mapping.
Fixed up geometric stream loading so there is fallback geometry if the load fails, and if there are no uvs or normals they are generated. This prevents tangent generation from failing if either of those does not exist and hence failing on a series of GL errors.
Add some very basic parameter control.

Results:
Example glTF boombox in JS and desktop viewer (left, and right respectively)

Testing on Mac Safari

Tested local git-hub page on Safari now that WebGL is supported :).

Latest UI

Overlayed loader UI + parameter UI

Same with parameter UI collapsed.

@kwokcb This sounds like a good improvement!  Could you send out a link to your locally-built web viewer, so that we can see the changes in context?

@kwokcb This sounds like a good improvement! Could you send out a link to your locally-built web viewer, so that we can see the changes in context?

Hi @jstone-lucasfilm, I created a dummy branch  of this to force deployment on my main github page here:
https://kwokcb.github.io/MaterialX/
It's a bit non-standard but it should work.

@bernardkwok I like the new functionality in this change, but it seems as if we've lost some of the design finesse in the original web viewer, especially in the handling of options at the top of the screen.  Here are two screenshots to give a sense of what I mean:
Original Web Viewer:

New Web Viewer:

Would it be possible to maintain the look of the original "material" option more closely in the addition of this new "geometry" option?

@bernardkwok I like the new functionality in this change, but it seems as if we've lost some of the design finesse in the original web viewer, especially in the handling of options at the top of the screen. Here are two screenshots to give a sense of what I mean:
Would it be possible to maintain the look of the original "material" option more closely in the addition of this new "geometry" option?

Yes, I have this fixed locally already. It's just a formatting of where the menus are so they overaly vs are above the viewing canvas.

The new material properties panel is a great addition, though it's slightly confusing that it only works for manually-loaded materials, not for the initial standard_surface_default material that launches in the viewer.  Also, perhaps Properties would be a better name than Material for this panel?

The new material properties panel is a great addition, though it's slightly confusing that it only works for manually-loaded materials, not for the initial standard_surface_default material that launches in the viewer. Also, perhaps Properties would be a better name than Material for this panel?

Hi @jstone-lucasfilm,
I should remove old images. It works the same for all materials including the initial one. I can rename the panel and also make it not collapsed by default.

@kwokcb These are some great improvements, and this looks nearly ready to merge.  Maybe we should start with the properties window closed rather than open, so that the initial configuration works on mobile devices as well as desktop PCs?

Probably last cleanup as this is about the limits of dat-gui usage (im-gui is a better toolkit). Also there is missing Javascript API which should be addressed afterwards (too large a change).

Fixed up float parameters not showing up if 0,
Added in some ui-folder grouping and naming.
Property editor is closed on load. Can also use 'h' key to hide.


[BUG] Rancher Monitoring Chart: MetricRelabeling for ingress-nginx exporter has wrong indentation in template

Rancher Server Setup

Rancher version: 2.7.4
Installation option (Docker install/Helm Chart):

Chart version 102.0.1+up40.1.2 and chart rancher-monitoring

Proxy/Cert Details: N/A

Information about the Cluster

Kubernetes version: 25.9
Cluster Type (Local/Downstream):
-Downstream

User Information

What is the role of the user logged in? (Admin/Cluster Owner/Cluster Member/Project Owner/Project Member/Custom)

Cluster Owner

Describe the bug
When we had the values
ingressNginx:
  enabled: true
  serviceMonitor:
    metricRelabelings:
    - action: drop
      regex: (.*bucket)
      sourceLabels:
      - __name__

and feed them to the rancher-monitoring chart with version 102.0.1+up40.1.2 we get an error:
Error: YAML parse error on rancher-monitoring/templates/rancher-monitoring/exporters/ingress-nginx/servicemonitor.yaml: error converting YAML to JSON: yaml: line 30: did not find expected key

We suspect this is related to the line
    {{ tpl (toYaml .Values.ingressNginx.serviceMonitor.metricRelabelings | indent 4) . }}

in the servicemonitor template which has an erroneous indentation.
To Reproduce
Create a values file:
---
ingressNginx:
  enabled: true
  serviceMonitor:
    metricRelabelings:
    - action: drop
      regex: (.*bucket)
      sourceLabels:
      - __name__
---

```bash
helm template rancher-monitoring rancher/rancher-monitoring  -f <values-file> --version 102.0.1+up40.1.2

### Actual Result
An error is returned:

```bash
Error: YAML parse error on rancher-monitoring/templates/rancher-monitoring/exporters/ingress-nginx/servicemonitor.yaml: error converting YAML to JSON: yaml: line 30: did not find expected key

Use --debug flag to render out invalid YAML

Expected Result
The ingress-nginx service monitor is updated with the desired metricRelabelings:
spec:
  endpoints:
  - bearerTokenFile: /var/run/secrets/kubernetes.io/serviceaccount/token
    interval: 30s
    metricRelabelings:
    - action: drop
      regex: (.*bucket)
      sourceLabels:
      - __name__

Screenshots
N/A
Additional context
Link to the erroneous line:
https://github.com/rancher/charts/blob/8ab2bb4a519bfcc7d788ba00e1bda57a060ca243/charts/rancher-monitoring/102.0.1%2Bup40.1.2/templates/rancher-monitoring/exporters/ingress-nginx/servicemonitor.yaml#L33

Is this still broken?


Error: Type 'Result' not found.

: Error: Type 'Result' not found. iterator.dart:18   Result<XmlEvent>? _context;   ^^^^^^ : Error: Method not found: 'Failure'. iterator.dart:13         _context = Failure(input, 0, '');                    ^^^^^^^ : Error: 'Result' isn't a type. iterator.dart:18   Result<XmlEvent>? _context;   ^^^^^^ : Error: 'Success' isn't a type. iterator.dart:29       if (result is Success) {
[flutter] flutter doctor -v
[✓] Flutter (Channel stable, 3.16.0, on macOS 14.1.1 23B81 darwin-arm64, locale zh-Hans-NO)
• Flutter version 3.16.0 on channel stable at /Users/rustyu/Documents/flutter/3.10.5
• Upstream repository https://github.com/flutter/flutter.git
• Framework revision db7ef5bf9f (5 days ago), 2023-11-15 11:25:44 -0800
• Engine revision 74d16627b9
• Dart version 3.2.0
• DevTools version 2.28.2
[✓] Android toolchain - develop for Android devices (Android SDK version 34.0.0)
• Android SDK at /Users/rustyu/Library/Android/sdk
• Platform android-34, build-tools 34.0.0
• Java binary at: /Applications/Android Studio.app/Contents/jbr/Contents/Home/bin/java
• Java version OpenJDK Runtime Environment (build 17.0.6+0-17.0.6b829.9-10027231)
• All Android licenses accepted.
[✓] Xcode - develop for iOS and macOS (Xcode 15.0)
• Xcode at /Applications/Xcode.app/Contents/Developer
• Build 15A240d
• CocoaPods version 1.12.1
[✓] Chrome - develop for the web
• Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome
[✓] Android Studio (version 2022.3)
• Android Studio at /Applications/Android Studio.app/Contents
• Flutter plugin can be installed from:
🔨 https://plugins.jetbrains.com/plugin/9212-flutter
• Dart plugin can be installed from:
🔨 https://plugins.jetbrains.com/plugin/6351-dart
• Java version OpenJDK Runtime Environment (build 17.0.6+0-17.0.6b829.9-10027231)
[✓] IntelliJ IDEA Community Edition (version 2023.2.1)
• IntelliJ at /Applications/IntelliJ IDEA CE.app
• Flutter plugin can be installed from:
🔨 https://plugins.jetbrains.com/plugin/9212-flutter
• Dart plugin can be installed from:
🔨 https://plugins.jetbrains.com/plugin/6351-dart
[✓] VS Code (version 1.84.2)
• VS Code at /Applications/Visual Studio Code.app/Contents
• Flutter extension version 3.76.0
[✓] Connected device (3 available)
• XRust (mobile)  • 00008101-000A39993A10001E • ios            • iOS 17.0.3 21A360
• macOS (desktop) • macos                     • darwin-arm64   • macOS 14.1.1 23B81 darwin-arm64
• Chrome (web)    • chrome                    • web-javascript • Google Chrome 117.0.5938.132
[✓] Network resources
• All expected network resources are available.
• No issues found!
exit code 0

Thanks for the error report. Could you provide a snippet of code that reproduces the error, and include the package versions of the xml and petitparser you are using (by running dart pub deps).

Update petitparser to the latest version and the problem no longer occurs.


Inner Route not working

Hi,
I am unable to route when switching from inner route to another.
this is my route:
<Router>
  <Route path="/" component={Encounter} />
  <Route name="search" path="search/" component={search} />
  <Route name="notification" path="notification/" component={Notification} />
  <Route name="inbox" path="inbox/">
    <IndexRoute component={Inbox} />
    <Route name="conversation" path=":userID" component={Conversation} />
  </Route>
  <Route path="*" component={NotFound} />
</Router>

http://localhost:8080/#/encounter -> http://localhost:8080/#/inbox/123 //work fine
http://localhost:8080/#/inbox/123 -> http://localhost:8080/#/inbox/456 //not working
http://localhost:8080/#/inbox/123 -> http://localhost:8080/#/search //work fine

Try not adding a slash at the end of your paths. So path="inbox" instead of path="inbox/".

thanks for the answer @confiks.
As @confiks mentioned, if you include the forward slash in the end of the path then the URL will have to have / in the end to match, so it's better to not to include it.
The other thing is that React Router does not have named routes anymore. Please have a look at the Upgrade Guide.

Hello
In fact, I am facing exactly the same issue,
so It is not working when routing from
http://localhost:8888/#/archive/1 to http://localhost:8888/#/archive/2

Thank you.
    <Router>
        <Route path="/" component={Home} />
        <Route path="news" component={News} />
        <Route path="archive" >
        <IndexRoute component={archiveList} />
        <Route path=":archiveID" component={archiveDetails} />
        </Route>
        </Router>

@Moussawi7 try making your routes look like:
<Router>
  <Route path="/" component={Home} />
    <Route path="news" component={News} />
    <Route path="archive" >
      <IndexRoute component={archiveList} />
      <Route path=":archiveID" component={archiveDetails} />
    </Route>
  </Route>
</Router>

Hi @knowbody ,
I made the route like you provided, but unfortunately, Home component is always called.
Thanks.

oh I though that's what you wanted. Please have a look into the documentation. Everything is well explained in there.

Thanks @knowbody , and sorry for bothering you.
My fault is that i thought that a new instance of archiveDetails will be created each time it match the route, but in fact it will update the props only.
So i inserted:
   componentWillReceiveProps (nextProps){
          var archiveID=nextProps.params.archiveID;
         //Other instructions
}

which work great.

@Moussawi7 well done! and you're not bothering :smile:


Vault issuer MUST USE the vault 'sign' endpoint

What this PR does / why we need it:
Update the documentation to avoid errors using vault issuer
Release note:

Looks good to me 😄 thanks for the clarification
/lgtm
/approve
/ok-to-test
cc @vdesjardins


[WTD] gender inclusive writing

Updated the document to reflect more gender inclusive writing.
Summarize the change in the pull request title
Describe your change, specifically why you think it's needed.
At write the docs conference Microsoft project is to create document more gender inclusive
Fixes #Issue_Number (if necessary)

@Khairunj : Thanks for your contribution! The author, @aczechowski, has been notified to review your proposed change.


Build rpi64 recipe under GitHub actions

Build the recipe on a push or pull request; save the
resulting artifacts to GitHub artifact storage.
Signed-off-by: Christopher Obbard<EMAIL_ADDRESS>

FWIW this will need reworking to use the large runner.


Dynamically adding and removing bots at runtime

Hello! I'm wondering if there's an idiomatic way to add and remove children to and from TMI at runtime?
My goal is to create and destroy bots on demand from my LiveView web interface. I've been browsing the relevant documentation and right now I'm looking at making a DynamicSupervisor, adding that to my application.ex, and giving TMI.Supervisors to it as children from my actions. Am I on the right track here or missing something critical?
Pretty new to Elixir but having a great time with your library so far. Thanks :)

That sounds like it should work, although I haven't tried it myself. 👍


[WOR-44] Show most expensive workspaces in Spend Report

This total spend by workspace (for 10 most expensive workspaces) for a billing project under the following conditions:

User is billing project owner
User is part of the alpha spending group. "hermione.owner" is a member in dev.
The billing project has spend data stored. galaxy-anvil-dev is a good one to look at. http://localhost:3000/#billing?selectedName=galaxy-anvil-dev&type=project&tab=spend report

Also adds Highcharts attribution per WOR-141.

I think it looks great. Only thing I found while testing was that the chart doesn't shrink well when the window is resized. Making the window bigger works great -- the chart expands to fit the new window size. However, it doesn't shrink as you shrink your window. Instead, it juts off the side of the page and you have to scroll horizontally to see it. Screenshot attached. It's kind of hard to tell what's going on, but the grey vertical line is where the background of the spend report stops.

Thanks for nothing that @marctalbott. I set a min size on the chart (smaller than it will actually be) so that it will shrink as you resize the window. Note though that the parent div will only shrink to a certain point though, and after that you get the horizontal scrollbar. This behavior is the same on the other tabs as well. I believe that we set a minimum size across Terra.

FYI to reviewers, I made a couple small changes in consultation with Adam (PO), and he verified them from the PR site.


Hide Top and Bottom Navigator on Login and Register screen inside Scaffold

With the current solution, the top and bottom bars flash white whenever you change screen, because they're being regenerated by a different compose function

Listo


AVM-Review

Dear module owner,
As per the agreed module ownership requirements & responsibilities at the time of assignment, the AVM Team is opening this issue to request you to kindly review your module against the below AVM specs and confirm that they are met by the module.
We appreciate if you don't close this issue till the review is complete. This review is required as a pre-req to be able to publish v0.1.0 the module to the Terraform Registry. AVM team would be happy to assist with any questions that you might have.
Requested Actions

Complete below task list by ticking off the tasks.
Complete the below table by updating the Compliant column with Yes, No or N/A as possible values.

Please use the comments columns to provide additional details especially if you selected N or NA.
### Tasks
- [x] Update _header.md file
- [x] Address comments on your PR if any
- [x] Ensure that all checks on your PR are passing
- [x] Ensure the latest "chore: repository governance" PR is merged
- [x] Acknowledge specs with comment "Module Owner to action this spec post-publish as appropriate" by ticking this
- [x] Linting / Terraform tests are [failing](https://github.com/Azure/terraform-azurerm-avm-res-web-hostingenvironment/actions/runs/8987801437/job/24798533340?pr=27) due to which the status of any spec requiring this test to pass is updated as "No" meaning not compliant. Once the tests are passing the status of these specs can be updated to "Yes" meaning compliant.

ID
Spec
Compliant
Comments

1
ID: SFR1 - Category: Composition - Preview Services
NA
NA if no preview services are used

2
ID: SFR2 - Category: Composition - WAF Aligned
Yes
Ensure only high priority reliability & security recommendations are implemented if any

3
ID: SFR3 - Category: Telemetry - Deployment/Usage Telemetry
Yes

4
ID: SFR4 - Category: Telemetry - Telemetry Enablement Flexibility
Yes
Yes if AVM Template Repo has been used

5
ID: SFR5 - Category: Composition - Availability Zones
Yes

6
ID: SFR6 - Category: Composition - Data Redundancy
Yes

7
ID: SNFR25 - Category: Composition - Resource Naming
Yes

8
ID: SNFR1 - Category: Testing - Prescribed Tests
Yes
Yes if all e2e test, version-check & linting checks passed

9
ID: SNFR2 - Category: Testing - E2E Testing
Yes
Yes if e2e tests passed

10
ID: SNFR3 - Category: Testing - AVM Compliance Tests
Yes
Yes if all e2e test, version-check & linting checks passed

11
ID: SNFR4 - Category: Testing - Unit Tests
NA
NA if no tests created in tests folder

12
ID: SNFR5 - Category: Testing - Upgrade Tests
NA
Module Owner to action this spec post-publish as appropriate

13
ID: SNFR6 - Category: Testing - Static Analysis/Linting Tests
Yes
Yes if all linting checks passed

14
ID: SNFR7 - Category: Testing - Idempotency Tests
Yes
Yes if e2e tests passed

15
ID: SNFR24 - Category: Testing - Testing Child, Extension & Interface Resources
Yes
Yes if e2e tests passed

16
ID: SNFR8 - Category: Contribution/Support - Module Owner(s) GitHub
Yes

17
ID: SNFR20 - Category: Contribution/Support - GitHub Teams Only
NA

18
ID: SNFR9 - Category: Contribution/Support - AVM & PG Teams GitHub Repo Permissions
Yes

19
ID: SNFR10 - Category: Contribution/Support - MIT Licensing
Yes
Yes if AVM Template Repo has been used

20
ID: SNFR11 - Category: Contribution/Support - Issues Response Times
NA
Module Owner to action this spec post-publish as appropriate

21
ID: SNFR12 - Category: Contribution/Support - Versions Supported
NA
Module Owner to action this spec post-publish as appropriate

22
ID: SNFR23 - Category: Contribution/Support - GitHub Repo Labels
Yes

23
ID: SNFR14 - Category: Inputs - Data Types
Yes

24
ID: SNFR22 - Category: Inputs - Parameters/Variables for Resource IDs
Yes

25
ID: SNFR15 - Category: Documentation - Automatic Documentation Generation
Yes
Yes if linting / docs check passed

26
ID: SNFR16 - Category: Documentation - Examples/E2E
Yes
Yes if e2e tests passed

27
ID: SNFR17 - Category: Release - Semantic Versioning
Yes
Yes if version-check check passed

28
ID: SNFR18 - Category: Release - Breaking Changes
NA
Module Owner to action this spec post-publish as appropriate

29
ID: SNFR19 - Category: Publishing - Registries Targeted
NA
Module Owner to action this spec post-publish as appropriate

30
ID: SNFR21 - Category: Publishing - Cross Language Collaboration
NA
Module Owner to action this spec post-publish as appropriate

31
ID: RMFR1 - Category: Composition - Single Resource Only
Yes

32
ID: RMFR2 - Category: Composition - No Resource Wrapper Modules
Yes

33
ID: RMFR3 - Category: Composition - Resource Groups
Yes

34
ID: RMFR4 - Category: Composition - AVM Consistent Feature & Extension Resources Value Add
Yes
Yes if linting / terraform check passed

35
ID: RMFR5 - Category: Composition - AVM Consistent Feature & Extension Resources Value Add Interfaces/Schemas
Yes
Yes if linting / terraform check passed

36
ID: RMFR8 - Category: Composition - Dependency on child and other resources
Yes

37
ID: RMFR6 - Category: Inputs - Parameter/Variable Naming
Yes

38
ID: RMFR7 - Category: Outputs - Minimum Required Outputs
Yes
Yes if linting / terraform check passed

39
ID: RMNFR1 - Category: Naming - Module Naming
Yes

40
ID: RMNFR2 - Category: Inputs - Parameter/Variable Naming
Yes

41
ID: RMNFR3 - Category: Composition - RP Collaboration
NA
Module Owner to action this spec post-publish as appropriate

42
ID: PMFR1 - Category: Composition - Resource Group Creation
NA
NA if this is not a pattern module

43
ID: PMNFR1 - Category: Naming - Module Naming
NA
NA if this is not a pattern module

44
ID: PMNFR2 - Category: Composition - Use Resource Modules to Build a Pattern Module
NA
NA if this is not a pattern module

45
ID: PMNFR3 - Category: Composition - Use other Pattern Modules to Build a Pattern Module
NA
NA if this is not a pattern module

46
ID: PMNFR4 - Category: Hygiene - Missing Resource Module(s)
NA
NA if this is not a pattern module

47
ID: PMNFR5 - Category: Inputs - Parameter/Variable Naming
NA
NA if this is not a pattern module

48
ID: TFFR1 - Category: Composition - Cross-Referencing Modules
Yes

49
ID: TFFR2 - Category: Outputs - Additional Terraform Outputs
Yes
Yes if linting / terraform check passed

50
ID: TFNFR1 - Category: Documentation - Descriptions
Yes

51
ID: TFNFR2 - Category: Documentation - Module Documentation Generation
Yes
Yes if linting / docs check passed

52
ID: TFNFR3 - Category: Contribution/Support - GitHub Repo Branch Protection
Yes
Yes if AVM Template Repo has been used

53
ID: TFNFR4 - Category: Composition - Code Styling - lower snake_casing
Yes
Yes if linting / terraform check passed

54
ID: TFNFR5 - Category: Testing - Test Tooling
Yes
Yes if linting / terraform check passed

55
ID: TFNFR6 - Category: Code Style - Resource & Data Order
Yes

56
ID: TFNFR7 - Category: Code Style - count & for_each Use
Yes

57
ID: TFNFR8 - Category: Code Style - Resource & Data Block Orders
Yes
Yes if linting / avmfix check passed

58
ID: TFNFR9 - Category: Code Style - Module Block Order
Yes

59
ID: TFNFR10 - Category: Code Style - No Double Quotes in ignore_changes
Yes

60
ID: TFNFR11 - Category: Code Style - Null Comparison Toggle
Yes

61
ID: TFNFR12 - Category: Code Style - Dynamic for Optional Nested Objects
Yes

62
ID: TFNFR13 - Category: Code Style - Default Values with coalesce/try
Yes

63
ID: TFNFR14 - Category: Inputs - Not allowed variables
Yes

64
ID: TFNFR15 - Category: Code Style - Variable Definition Order
Yes
Yes if linting / avmfix check passed

65
ID: TFNFR16 - Category: Code Style - Variable Naming Rules
Yes
Yes if linting / terraform check passed

66
ID: TFNFR17 - Category: Code Style - Variables with Descriptions
Yes
Yes if linting / terraform check passed

67
ID: TFNFR18 - Category: Code Style - Variables with Types
Yes
Yes if linting / terraform check passed

68
ID: TFNFR19 - Category: Code Style - Sensitive Data Variables
Yes

69
ID: TFNFR20 - Category: Code Style - Non-Nullable Defaults for collection values
Yes

70
ID: TFNFR21 - Category: Code Style - Discourage Nullability by Default
Yes
Yes if linting / avmfix check passed

71
ID: TFNFR22 - Category: Code Style - Avoid sensitive = false
Yes
Yes if linting / avmfix check passed

72
ID: TFNFR23 - Category: Code Style - Sensitive Default Value Conditions
Yes
Yes if linting / terraform check passed

73
ID: TFNFR24 - Category: Code Style - Handling Deprecated Variables
NA
Module Owner to action this spec post-publish as appropriate

74
ID: TFNFR25 - Category: Code Style - Verified Modules Requirements
Yes
Yes if linting / terraform check passed

75
ID: TFNFR26 - Category: Code Style - Providers in required_providers
Yes
Yes if linting / terraform check passed

76
ID: TFNFR27 - Category: Code Style - Provider Declarations in Modules
Yes
Yes if linting / terraform check passed

77
ID: TFNFR28 - Category: Code Style - Provider Declarations in Modules
Yes
Yes if linting / terraform check passed

78
ID: TFNFR29 - Category: Code Style - Sensitive Data Outputs
Yes
Yes if linting / avmfix check passed

79
ID: TFNFR30 - Category: Code Style - Handling Deprecated Outputs
NA
Module Owner to action this spec post-publish as appropriate

80
ID: TFNFR31 - Category: Code Style - locals.tf for Locals Only
Yes

81
ID: TFNFR32 - Category: Code Style - Alphabetical Local Arrangement
Yes
Yes if linting / avmfix check passed

82
ID: TFNFR33 - Category: Code Style - Precise Local Types
Yes

83
ID: TFNFR34 - Category: Code Style - Using Feature Toggles
NA
Module Owner to action this spec post-publish as appropriate

84
ID: TFNFR35 - Category: Code Style - Reviewing Potential Breaking Changes
NA
Module Owner to action this spec post-publish as appropriate

85
ID: TFNFR36 - Category: Code Style - Setting prevent_deletion_if_contains_resources
Yes

86
ID: TFNFR37 - Category: Code Style - Tool Usage by Module Owner
Yes

@mbilalamjad This module should be good to go!

Thank you for contributing this module and completing the review process per AVM specs to ensure quality.
You may proceed with publishing this module to the HashiCorp Terraform Registry with the initial pre-release version of v0.1.0.
Please keep future versions also pre-release (e.g., 0.1.0, 0.1.1, 0.2.0, etc.) until AVM becomes generally available (GA) of which the AVM team will notify you.
Requested Action: Once the module is published to the HashiCorp Terraform Registry, please update the module proposal issue with the below comment.
The initial review of this module is complete and the module has been published to the registry. Requesting AVM team to close this module proposal and mark the module available in the module index.


Better error handling for bogus trainer rides

This is actually a bogus trainer ride, but we probably want to also handle the exception from wunderground a little smarter?
Is there a way to detect the bogus trainer rides and exclude them?
ERROR:sync-weather:Error getting weather data for ride: <Ride id=238200342 name=u'01/07/2015 United States Minor Outlying Islands'>
Traceback (most recent call last):
  File "/home/hozn/sites/freezingsaddles.com/bafs/bafs/scripts.py", line 313, in sync_ride_weather
    rw.ride_temp_start = start_obs.temp
AttributeError: 'NoneType' object has no attribute 'temp'

Now that we exclude trainer or virtual rides, this is probably less of an issue?


ValueError when executing train_one_shot_learning_matching_network.py without any modification

Hi,
I simply ran train_one_shot_learning_matching_network.py following guideline in the Readme file, then I met following error. Does anyone meet the same problem?
Traceback (most recent call last):                                                                                | 0/1000 [00:00<?, ?it/s]
File "train_one_shot_learning_matching_network.py", line 69, in
sess=sess)
File "/one_shot_learning/MatchingNetworks-master/experiment_builder.py", line 82, in run_training_epoch
self.learning_rate: self.current_learning_rate})
File "/usr/local/lib/python3.5/dist-packages/tensorflow/python/client/session.py", line 929, in run
run_metadata_ptr)
File "/usr/local/lib/python3.5/dist-packages/tensorflow/python/client/session.py", line 1128, in _run
str(subfeed_t.get_shape())))
ValueError: Cannot feed value of shape (1, 32, 20, 1) for Tensor 'target_image:0', which has shape '(1, 32, 28, 28, 1)'

I got a similar error, were you able to solve it?

I think there might be something wrong with your dataset or codes related to 'img_height' and 'img_width'. It's clearly that the shape of target_image and your input doesn't match.

I haven't updated this code for a while. I would not be surprised if one of the latest updates of tensorflow broke my code.

I haven't updated this code for a while. I would not be surprised if one of the latest updates of tensorflow broke my code.

Sir, i use the same version of  tensorflow with you.
but got the same error, could you please teach me how to fix it？
this is the report
$ python train_one_shot_learning_matching_network.py --batch_size 32 --experiment_title omniglot_20_1_matching_network --total_epochs 200 --full_context_unroll_k 5 --classes_per_set 20 --samples_per_class 1 --use_full_context_embeddings False --use_mean_per_class_embeddings False --dropout_rate_value 0.0
Mapped data paths can't be found, remapping paths..
Get images from /home/luoc/Python-Lab/luoc/code/MatchingNetworks/MatchingNetworks/datasets/omniglot_dataset
100%|█████████████████████████████████████████████████████████████████████████████████| 32460/32460 [00:09<00:00, 3356.67it/s]
1623
1200 1411 1623
data {'train': 24000, 'val': 4220, 'test': 4240}
WARNING:tensorflow:From /home/luoc/Python-Lab/luoc/code/MatchingNetworks/MatchingNetworks/one_shot_learning_network.py:112: calling reduce_sum (from tensorflow.python.ops.math_ops) with keep_dims is deprecated and will be removed in a future version.
Instructions for updating:
keep_dims is deprecated, use keepdims instead
2020-10-15 10:50:03.480899: I tensorflow/core/platform/cpu_feature_guard.cc:140] Your CPU supports instructions that this TensorFlow binary was not compiled to use: AVX2 FMA
2020-10-15 10:50:03.606723: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1212] Found device 0 with properties:
name: GeForce GTX 1080 major: 6 minor: 1 memoryClockRate(GHz): 1.8225
pciBusID: 0000:02:00.0
totalMemory: 7.92GiB freeMemory: 7.14GiB
2020-10-15 10:50:03.606752: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1312] Adding visible gpu devices: 0
2020-10-15 10:50:03.812563: I tensorflow/core/common_runtime/gpu/gpu_device.cc:993] Creating TensorFlow device (/job:localhost/replica:0/task:0/device:GPU:0 with 6895 MB memory) -> physical GPU (device: 0, name: GeForce GTX 1080, pci bus id: 0000:02:00.0, compute capability: 6.1)
  0%|                                                                                | 0/200 [00:00<?, ?it/s]
Traceback (most recent call last):                                                                   | 0/1000 [00:00<?, ?it/s]
  File "train_one_shot_learning_matching_network.py", line 69, in <module>
    sess=sess)
  File "/home/luoc/Python-Lab/luoc/code/MatchingNetworks/MatchingNetworks/experiment_builder.py", line 82, in run_training_epoch
    self.learning_rate: self.current_learning_rate})
  File "/home/luoc/Python-envs/py3/lib/python3.5/site-packages/tensorflow/python/client/session.py", line 905, in run
    run_metadata_ptr)
  File "/home/luoc/Python-envs/py3/lib/python3.5/site-packages/tensorflow/python/client/session.py", line 1113, in _run
    str(subfeed_t.get_shape())))
ValueError: Cannot feed value of shape (1, 32) for Tensor 'target_image:0', which has shape '(1, 32, 28, 28, 1)'

and this is my packages installed
numpy              1.15.0
opencv-python      <IP_ADDRESS>
tensorflow-gpu     1.6.0
torch              0.4.0
``

Hi,
I simply ran train_one_shot_learning_matching_network.py following guideline in the Readme file, then I met following error. Does anyone meet the same problem?
Traceback (most recent call last): | 0/1000 [00:00<?, ?it/s]
File "train_one_shot_learning_matching_network.py", line 69, in
sess=sess)
File "/one_shot_learning/MatchingNetworks-master/experiment_builder.py", line 82, in run_training_epoch
self.learning_rate: self.current_learning_rate})
File "/usr/local/lib/python3.5/dist-packages/tensorflow/python/client/session.py", line 929, in run
run_metadata_ptr)
File "/usr/local/lib/python3.5/dist-packages/tensorflow/python/client/session.py", line 1128, in _run
str(subfeed_t.get_shape())))
ValueError: Cannot feed value of shape (1, 32, 20, 1) for Tensor 'target_image:0', which has shape '(1, 32, 28, 28, 1)'

@YuanEric88 Hi, have you solved this issue? How did you solve it?


LoginRequired error thrown when attempting to ban

Error:
File "/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/site-packages/praw/decorators.py", line 346, in wrapped
raise errors.LoginRequired(function.name)
praw.errors.LoginRequired: do_relationship requires a logged in session
Received when attempting Subreddit.add_ban() with the following _authorization scope:
set([u'wikiedit', u'save', u'wikiread', u'subscribe', u'edit', u'modcontributors', u'mysubreddits', u'privatemessages', u'modconfig', u'read', u'modlog', u'modposts', u'modflair', u'vote', u'modwiki', u'submit', u'identity', u'flair'])
All other moderation functions seem to be working otherwise.

Can you please download the .zip from github, and overwriting your current praw installation? You told me the other day that you did pip install praw --upgrade, which means you'd be on 3.1.0. Your _modify_relationship method therefore looks like this:
https://github.com/praw-dev/praw/blob/3d0be7a1697c90f715d4dd4bb73c63318810b14a/praw/internal.py#L88
But the current version looks like this:
https://github.com/praw-dev/praw/blob/c05bab70ff4b26967ca0b114436e0edad24aa6aa/praw/internal.py#L88

Great thanks man, that did the trick. I did the "install --upgrade" with
the master.zip rather than a manual installing.
On Sun, Aug 2, 2015 at 4:20 PM, voussoir<EMAIL_ADDRESS>wrote:

Can you please download the .zip from github, and overwriting your current
praw installation? You told me the other day that you did pip install
praw --upgrade, which means you'd be on 3.1.0. Your _modify_relationship
method therefore looks like this:
https://github.com/praw-dev/praw/blob/3d0be7a1697c90f715d4dd4bb73c63318810b14a/praw/internal.py#L88
But the current version looks like this:
https://github.com/praw-dev/praw/blob/c05bab70ff4b26967ca0b114436e0edad24aa6aa/praw/internal.py#L88
—
Reply to this email directly or view it on GitHub
https://github.com/praw-dev/praw/issues/489#issuecomment-127066334.

Awesome! I should have checked what the actual code difference was, I would have had you try that much sooner.


Improve support for pipeline/workflow jobs.

Add finer-grained controls over GitHub commit statuses with the ability to:

control the ID/name of the commit status context
set the commit status to a particular value regardless of the job progress/state

This allows pipeline builds the ability to:

Update multiple comit status fields from a single job
Set the commit status based on logic from within the script rather than
inheriting the whole job status

This change is

Hi, that should be done in bit other way, please ping me on weekends to not forget about it.

Thank you for this pull request! Please check this document for how the Jenkins project handles pull requests.

@KostyaSha Thanks! I'm not surprised there is a better way... I'm no expert in the world of jenkins plugins. I'll ping you on the weekend. In the meantime I'll fix up the findbugs issues anyway.

I just can't remember without sources on what we stopped with github-api enhancements that was picked from this code.
GitHubProjectProperty from github plugin starting from some version supports displayName that is designed to be reused for context. So i think fix will be just to replace run.getParent().getFullName() with it's content. That should be really only few lines of changes ;) Plus don't forget update job-dsl code after i will merge job-dsl updates.

https://github.com/jenkinsci/github-plugin/blob/master/src/main/java/com/coravy/hudson/plugins/github/GithubProjectProperty.java#L66-L73
https://github.com/jenkinsci/github-plugin/blob/master/src/main/java/com/coravy/hudson/plugins/github/GithubProjectProperty.java#L35-L42

I did see that ability but the problem I was trying to solve was the ability to manage multiple commit statuses from a single jenkins job. Using the GitHub plugin field restricts you to a single commit status for the whole job.
For example, I have a workflow/pipeline DSL job that runs through three "stages" and I wanted a commit status for each stage: compile, unit-test, and system-test. In order to do that I needed the ability to have different status checks for each phase of the job. I could also break my job up into three separate jenkins jobs but that adds additional complications I was trying to avoid.
If you are saying that having the ability to manage multiple status types is not desired, I can live with that. It was just something I found useful for the way we define our builds here and hoped it would be useful for others. When you have more time on the weekend, you can let me know what you think.

What if property.displayName() + ability to set "kind"/"tail" from pr statuses?
You set in gh project property "my-super-job" and in pr statuses "kinds". That will end in
"my-super-job: run success" < the whole run
"my-super-job-tests: build success" < tests body
"my-super-job-slow-tests"

I agree with the @onecloud-sean use case. We too set multiple different commit statuses, and just implemented our own wrapper around a sh step that executes curl to solve this for now.
Setting as a suffix/tail would not be ideal. The space in github statuses is limited so we try to make them as concise as possible so we can fit a longer description.

It's a little more complicated but we could do a combination of the two. Since either field can be blank we could stick them together to build up any combination of them:
| `isBlank(step)` | `isNotBlank(step)`

---|---|---
isBlank(top-job) | job-id | step
isNotBlank(top-job) | top-job | top-job-step

Sounds interesting. @lanwen sounds like idea of having displayName in PP wasn't good because of this parallel flows?

On other hand having prefix makes sense when you will have 2 different jobs targeted on one repo.

@onecloud-sean your idea looks good, could you try it and rebase?

Yeah, I'll give that a try.

OK, I was able to get that working. I don't really know what GitHubPRJobDslExtension.java is for so you might want to look that change over in particular.

that extension provides job-dsl configuration of plugin. I added link to wiki: last line https://github.com/jenkinsci/github-integration-plugin/wiki/Features (todo move description to configuration page instead features list).

Trying get idea of changes... As i understand context name is just Describable that should be added to Builder/Publisher/Listener. Prestatus is specific and indicates that job was scheduled into queue, so it should also match to futher contexts. It seems that preStatus() should allow multiple statuses. Either better not to use it or use only for outer job with allowing only single parameter...

The only time you are likely to have multiple statuses would be when you are using the pipeline/workflow plugin which allows you to script the steps in-use and call/use them multiple times for a single job. In more traditional job definitions, like freestyle projects, you can only call the status update step once. So in those it doesn't make a lot of sense to have more than one status message/context. In the pipeline/workflow jobs you really don't need the preStatus() functionality since that can be implemented in the DSL with the regular builder step. I can share the pipeline DSL script I have with you if that would help illustrate a use case.

@onecloud-sean: we actually still use what I assume is the preStatus() functionality even with pipelines. Since pipelines can't set a status until a node has been allocated (and in a crowded queue this might be awhile) it is useful to immediately have a pending status on the PR.

@lsglick, interesting. I guess I haven't tried calling it that way. Are you saying that the step statement is not available outside of a node block?

@onecloud-sean, it appears the implementation of step allows you to override getRequiredContext(). But in this case, the step requires context class hudson.launcher. Below is an example exception I've gotten:
[Pipeline] step
Required context class hudson.Launcher is missing
Perhaps you forgot to surround the code with a step that provides this, such as: node
[Pipeline] End of Pipeline
org.jenkinsci.plugins.workflow.steps.MissingContextVariableException: Required context class hudson.Launcher is missing
	at org.jenkinsci.plugins.workflow.steps.StepDescriptor.checkContextAvailability(StepDescriptor.java:126)
	at org.jenkinsci.plugins.workflow.cps.DSL.invokeMethod(DSL.java:132)
	at org.jenkinsci.plugins.workflow.cps.CpsScript.invokeMethod(CpsScript.java:113)
	at groovy.lang.GroovyObject$invokeMethod.call(Unknown Source)
	at org.codehaus.groovy.runtime.callsite.CallSiteArray.defaultCall(CallSiteArray.java:42)
	at org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:108)
	at org.kohsuke.groovy.sandbox.impl.Checker$1.call(Checker.java:151)
	at org.kohsuke.groovy.sandbox.GroovyInterceptor.onMethodCall(GroovyInterceptor.java:21)
	at org.jenkinsci.plugins.scriptsecurity.sandbox.groovy.SandboxInterceptor.onMethodCall(SandboxInterceptor.java:76)
	at org.jenkinsci.plugins.scriptsecurity.sandbox.groovy.SandboxInterceptor.onMethodCall(SandboxInterceptor.java:69)
	at org.kohsuke.groovy.sandbox.impl.Checker$1.call(Checker.java:149)
	at org.kohsuke.groovy.sandbox.impl.Checker.checkedCall(Checker.java:146)
	at com.cloudbees.groovy.cps.sandbox.SandboxInvoker.methodCall(SandboxInvoker.java:15)
	at WorkflowScript.run(WorkflowScript:11)
	at ___cps.transform___(Native Method)
	at com.cloudbees.groovy.cps.impl.ContinuationGroup.methodCall(ContinuationGroup.java:55)
	at com.cloudbees.groovy.cps.impl.FunctionCallBlock$ContinuationImpl.dispatchOrArg(FunctionCallBlock.java:106)
	at com.cloudbees.groovy.cps.impl.FunctionCallBlock$ContinuationImpl.fixArg(FunctionCallBlock.java:79)
	at sun.reflect.GeneratedMethodAccessor320.invoke(Unknown Source)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:606)
	at com.cloudbees.groovy.cps.impl.ContinuationPtr$ContinuationImpl.receive(ContinuationPtr.java:72)
	at com.cloudbees.groovy.cps.impl.CollectionLiteralBlock$ContinuationImpl.dispatch(CollectionLiteralBlock.java:55)
	at com.cloudbees.groovy.cps.impl.CollectionLiteralBlock$ContinuationImpl.item(CollectionLiteralBlock.java:45)
	at sun.reflect.GeneratedMethodAccessor319.invoke(Unknown Source)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:606)
	at com.cloudbees.groovy.cps.impl.ContinuationPtr$ContinuationImpl.receive(ContinuationPtr.java:72)
	at com.cloudbees.groovy.cps.impl.ConstantBlock.eval(ConstantBlock.java:21)
	at com.cloudbees.groovy.cps.Next.step(Next.java:58)
	at com.cloudbees.groovy.cps.Continuable.run0(Continuable.java:154)
	at org.jenkinsci.plugins.workflow.cps.SandboxContinuable.access$001(SandboxContinuable.java:19)
	at org.jenkinsci.plugins.workflow.cps.SandboxContinuable$1.call(SandboxContinuable.java:33)
	at org.jenkinsci.plugins.workflow.cps.SandboxContinuable$1.call(SandboxContinuable.java:30)
	at org.jenkinsci.plugins.scriptsecurity.sandbox.groovy.GroovySandbox.runInSandbox(GroovySandbox.java:106)
	at org.jenkinsci.plugins.workflow.cps.SandboxContinuable.run0(SandboxContinuable.java:30)
	at org.jenkinsci.plugins.workflow.cps.CpsThread.runNextChunk(CpsThread.java:164)
	at org.jenkinsci.plugins.workflow.cps.CpsThreadGroup.run(CpsThreadGroup.java:277)
	at org.jenkinsci.plugins.workflow.cps.CpsThreadGroup.access$000(CpsThreadGroup.java:77)
	at org.jenkinsci.plugins.workflow.cps.CpsThreadGroup$2.call(CpsThreadGroup.java:186)
	at org.jenkinsci.plugins.workflow.cps.CpsThreadGroup$2.call(CpsThreadGroup.java:184)
	at org.jenkinsci.plugins.workflow.cps.CpsVmExecutorService$2.call(CpsVmExecutorService.java:47)
	at java.util.concurrent.FutureTask.run(FutureTask.java:262)
	at hudson.remoting.SingleLaneExecutorService$1.run(SingleLaneExecutorService.java:112)
	at jenkins.util.ContextResettingExecutorService$1.run(ContextResettingExecutorService.java:28)
	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471)
	at java.util.concurrent.FutureTask.run(FutureTask.java:262)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
	at java.lang.Thread.run(Thread.java:745)

Ok, thanks for the explanation. So then to what @KostyaSha mentioned, should it allow selection of multiple status contexts during the preStatus() action? I could probably pretty easily allow that to be a comma-separated list of names -- allowing for a blank entry to also use the default name.

We use it like he mentioned as an outer overall status, largely because it isn't configurable right now. I agree with him that it should either not be configurable and only use the default, or configurable to multiple statuses that are defined in the actual job.

Sounds good to me. @KostyaSha, how would you like for it to work? I can change it as you please and push it up along with fixes for your other review comments.

I want avoid mess of UI/code/usage, so thinking about possible ways.
The other way could be implement native WorkflowDSL script, and use them instead step wrappers. In this case only setPreStatus would be questionable...

Btw, about prestatus and status before putting to queue. If you cancel job it wouldn't be marked/removed from github statuses (sounds like clean-up is TODO).

If there is a way to move this all out into some place where it is available to the pipeline DSL, I think that would be an good plan. Then, the UI-driven choices could go back to the simple checkboxes.
Do you know... are the functions declared in GitHubPRJobDslExtension.java available to pipeline workflow scripts? or does it need to do something more like this?
And for the clean-up TODO I guess that's an issue with or without this change. I suppose it needs a QueueListener or something like that to make sure the status isn't left hanging. Sounds like perhaps a different PR?

TODO is separate issue, just mentioned possible case.
Job-dsl has no relation to workflow it has own definition and usually used as DSL to generate standard jobs.

Well it looks like the pipeline documentation shows how to add a "pipeline-only" step. I can experiment with using that API for better control over the GitHub commit status updates without making a mess of the freestyle job UI.

As i see your link is only for scripts. I think plugin should provide own command
public class GitHubDSL extends org.jenkinsci.plugins.workflow.cps.GlobalVariable and etc
Then provide DSL commands from it and make them as we want - they would be able to work with trigger. But trigger contains this preStatus that i have no idea how do clean.
Only if checkbox with new line separated strings that would follow mentioned logic...

Then standard jobs will have existed Publisher/Builder classes that has single configuration value (but your logic should be applied also because it useful). Workflow DSL will have own implementation with extended features. Optionally standard step would be available for workflow DSL.
Job DSL is only provides ability to configure standard jobs.

@onecloud-sean feel free to experiment and open additional PRs to not kill existed work.

Is there any plan to add a URL to the status? It is quite annoying to not be able to click there.

@mikz handled your change separately. Good catch.
@onecloud-sean did you have any change to try implement status commands in native way?

@KostyaSha -- Yes, I have a working change that I'm testing out now. In the end it is pretty simple since any of the fancy stuff can be (and usually is) handled in the groovy DSL. The one reservation I have now though is whether this feature belongs here or directly in the GitHub plugin. Setting a commit status isn't necessarily a feature of pull requests -- it could just be a basic GitHub ability.

github-plugin uses other commit extractor. and github-plugin doing only poll kick, so it's trigger fully rely on gitscm. pr plugin (and my WIP github-push trigger) rely only on action triggered job, so this statuses set commit status exactly to triggered information. Nothing would be changed in github-plugin as it root of API features now. If you interested i can push my WIP code for #45

Sorry for the misunderstanding. I totally see how this plugin adds valuable functionality that is not available (and doesn't need to be) in the base github-plugin.
My comment was for the githubSetCommitStatus function I am adding to make available for groovy Pipeline DSL scripts. The method will look something like:
    githubSetCommitStatus commit: $env.GIT_SHA, status: "Pending"

So if the pull-request-plugin simply provides the $env.GIT_SHA (or whatever it is called) environment variable indicating which git commit caused/triggered the build, then the act of setting a commit status is really not fundamental to the pull request itself.
I'm probably still not explaining it very well. Perhaps once you see it in code it will make more sense. I hope to have a new pull request up in the next day or two.

You will end with the idea that plugin absolutely not need and you can wrote all logic in groovy or java even without DSL :D i see no need in providing configurable hash fields, job started for commit, statuses set for it. If you want do custom things, then i would better expose additional things but only for DSL that doesn't require having Describables (or require?).

That is indeed true :smile:  I'm no expert here so the advice is much appreciated! The struggle I have is that with a pipeline DSL you can have multiple different Git repos involved. Sure one of them may have triggered the original build in the first place but perhaps there is another one farther on in the script where you want the status applied. On the other hand, maybe I'm getting carried away with it and sticking to just the triggering commit+repo is sufficient.

Good job on this PR! In my opinion it would have been better to be split in two, one part for the custom context name and the other for exposing the result to the DSL. It would allow for a faster and easier review. Anyway, I like the idea, but I'm not sure why the context requires its own java class. Why not simply let it be a String field in GitHubPRBuildStatusPublisher

The struggle I have is that with a pipeline DSL you can have multiple different Git repos involved.

Could you describe your case?
I not sure whether something is designed for multiple repos at all. Triggering is single event that puts variables + TriggerAction into started job. So exposing additional configuration into UI would lead into difficulties for users. Somebody would request to not set URL for example and then single feature would end with too much configuration. StatusPublisher AFAIR uses Action to be strict and know that job was really started from trigger.
Keeping in mind that custom statuses required for freestyle jobs i would like to process firstly with context statuses according to proposed matrix. Then we can experiment with extended DSL things. It could be also possible to place experimental staff into separate plugin.

@emanuelez the only reason I didn't make the context field a simple string parameter was that I didn't know how to. This is my first attempt at any code inside Jenkins and I have had trouble finding information on how things work. So when I got the "String class does not have a descriptor" error, that was how I got past it. I think I have since figured out how to make it a simple parameter so I can change that too if we go ahead with the PR.
The other feature of exposing this via a groovy DSL is going to be a separate PR once I have it ready -- we just seem to have used this PR's conversation thread for discussions related to it (in hindsight, probably should have created an issue).

@KostyaSha I don't know that I have a great case/example. I was imagining a pipeline script that had multiple sections like:
  node {
    git 'http://github.com/a/b'
    // build a/b project
  }
  node {
    git 'http://github.com/x/y'
    // build x/y project
  }

But I can easily see your point now that from the perspective of this plugin, all you really want is the ability to set the status related to the PR which triggered this build. You have convinced me. I will simplify my implementation even further to make it work like that.

Is there any way I can help getting this implemented, merged and released? :)

@emanuelez, thanks for the offer! I was so close to finishing that I just decided to wrap it up and make it available. You can have a look at PR #71 and see if that looks promising at all.
IMHO, #71 replaces this PR. I'd vote for closing this one.

merged via #78

Would be glad if somebody update wiki. I created repository for accepting PRs https://github.com/KostyaSha/github-integration-plugin-wiki


Fixed vocabulary on set style

Coverage remained the same at 98.905% when pulling 7962cabee39f5b0a9af1c32eda8e440b0196117d on redaced:master into 15c00a1b28ecf5bf9ad6d9694bd66b0fed28af73 on charliekassel:master.

Hi, why the change?
Looks like the abbreviated is now longer than the original.


[OTHER] IndexError

Getting an IndexError when running picamera2 on rpi 5.  I was able to run this program awhile ago but now im getting this error every time I run it.
    picam2 = Picamera2()
             ^^^^^^^^^^^
  File "/usr/lib/python3/dist-packages/picamera2/picamera2.py", line 246, in __init__
    camera_num = self.global_camera_info()[camera_num]['Num']
                 ~~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^
IndexError: list index out of range

Any ideas what could be wrong?

What did self.global_camera_info() return, and what was camera_num? One possibility is that your camera (or cameras) are not being detected for some reason.

I reseated the camera cable and it seems to work fine now.


allow seperator in autogenerated routes to be configureable

In our charts it is currently assumed that a service name will be prepended to the router pattern with a .. This should be configurable to allow administrators the option to choose a different DNS-safe seperator, such as -.

I think this is a duplicate of https://github.com/amazeeio/lagoon/issues/2573

discussed in lagoon tech meeting:

remove logic from kbd
add replacement logic (service, environment, project) to helmcharts
add lagoon core upgrade script that adds ${service}. to all routerPatterns
add validator to routerPattern in lagoon core api that checks that the routerPattern has ${service} ${environment} ${project} defined in it
update documentation


Update to support both 2.12 and 2.11

I made a couple non-functional changes, but then decided to not do the rest.  I would be happy to help, just wanted to make sure I was going down the right path.  With this command release will handle both 2.11 and 2.12.  It's pinned to a SNAPSHOT of lum-ai/common, which I submitted a pr for https://github.com/lum-ai/common/pull/2

Thanks! This is great.
I suggest we wait with releasing a new version, until the lum.ai common project is released, so we don't depend on a snapshot. @marcovzla, @myedibleenso: when you have a moment, can you please review @dispalt's PR?
@hickst: does Reach work with Scala 2.12?

Sorry I wasn't explicit, I fully expect to not merge this until there is a 2.12 release of lum.ai-common.  But just wanted to show you what I have so far.  The same team that runs this runs lum.ai correct?

A subset of this team runs lum.ai, yes.

On Sep 25, 2017, at 2:43 PM, Dan Di Spaltro<EMAIL_ADDRESS>wrote:
Sorry I wasn't explicit, I fully expect to not merge this until there is a 2.12 release of lum.ai-common. But just wanted to show you what I have so far. The same team that runs this runs lum.ai correct?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.

I just published common 0.0.8 for scala 2.11 and 2.12

Thanks @dispalt! LGTM

Also before merging, are you fine with me increasing the default scala version to 2.11.11?  Also I can squash the commits.

I'm ok with the upgrade. @MihaiSurdeanu? @hickst?

me too.

On Oct 2, 2017, at 10:55 AM, marcovzla<EMAIL_ADDRESS>wrote:
I'm ok with the upgrade. @MihaiSurdeanu? @hickst?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

This seems to merge into master. @marcovzla: Ok with you?

I meant: seems Ok to merge

@marcovzla Did you test this version of Processors with Reach?

no

I erased my Ivy cache, recompiled master and I get 55 compiler warnings. This one sounds the most potentially serious:
[warn] Found version conflict(s) in library dependencies; some are suspected to be binary incompatible:

I am not affiliated with the project but there is a dependency on some 2.10 library that I saw that would need to be upgraded (this was an issue in 2.11 too).  There's also a bunch of mutable usages that could be simplified to immutable (mostly inner looping in functions).  I tried to basically not do much outside of add the cross compilation infrastructure.  But would be happy to try and help clean up some of the code.

Hi Dan,
Yes, it's compiling for me, just getting a bunch of warnings; probably indicating things that we need to clean up for 2.12, (e.g., the new Eta-expansion warnings). Not sure which is the 2.10 library dependency but we are using some really old stuff (e.g. the XOM library which hasn't been updated since 2013).

nlptools-stem-morpha_2.10, but yes lots of warnings.  You're really not even supposed to be able to depend on libraries like that, but I guess the bytecode its using hasn't changed much.  It would manifest as an abstract method error during runtime if the underlying code changed.


Code to generate active learning sample

For Scope functionality to fully cover a cycle of active learning, we should have code that selects ~N class examples from a set of inference results, yielding a file whose contents can be uploaded to Fritz. This code currently exists in a Jupyter notebook and will be adapted to merge with Scope.

Code added in #188.


Way to remove zoom effect

Any way to remove the zoom effect when the full image loads?

Yes - you can apply or remove any effect you like. See the CSS for .progressive img.reveal.


Avoid global ffigen

Fixes #602.
Checklist

[x] An issue to be fixed by this PR is listed above.
[ ] New tests are added to ensure new features are working. End-to-end tests are usually in the ./frb_example/pure_dart example, more specifically, rust/src/api.rs and dart/lib/main.dart.
[x] The code generator has been run, and code changes are commited. (Otherwise, CI will fail.)
[ ] If this PR adds/changes features, documentations (in the ./book folder) are updated.
[ ] CI is passing.

Right now my code in frb_codegen is very messy, will have to clean it up following your recommandations.
 Feel free to mark it as "ready for review" when ready for review :)

Honestly there's a bunch of changes in frb_codegen/src/commands.rs that can greatly be improved, but I would prefer to have your feedback first @fzyzcjy.

Honestly there's a bunch of changes in frb_codegen/src/commands.rs that can greatly be improved

Yes, I totally agree - code refactor is very welcomed!
Indeed, when I firstly publish this open source lib, I did not expect it to grow this popular :) So the code style was not that good at that time. And later when it grow bigger and bigger more problems arise.

While updating the docs I noticed the same recommendations are literally redundant in 4 different markdown files.
Maybe we could specify it once in one file and link all the other files to it ?
I also noticed the CI won't pass because flutter --version is not recognized, for example this failed job.
Since I started to remove the code to check dart package version requirements comparison (see discussion above), I guess I can even remove more code.
Not sure if it should be marked as ready for review yet ?

the same recommendations are literally redundant in 4 different markdown files.
Maybe we could specify it once in one file and link all the other files to it ?

Sure :)
Is it possible to use this feature: https://rust-lang.github.io/mdBook/format/mdbook.html#including-files

I also noticed the CI won't pass because flutter --version is not recognized, for example this failed job.

Weird... So how do we run other flutter commands? Maybe missing PATH env var or something?

Not sure if it should be marked as ready for review yet ?

Surely depends on you :) I will review 8hr later when getting up tomorrow

Sure :)
Is it possible to use this feature: https://rust-lang.github.io/mdBook/format/mdbook.html#including-files

Oh ok, exactly what I was thinking then 👌
p.s: I'll address it last.

Weird... So how do we run other flutter commands? Maybe missing PATH env var or something?

As far as I understand flutter_rust_bridge github workflow, so far all the examples were treated as depending onto dart toolchain, as can be seen in the common job step.
And looking at all the steps from ci.yaml, no matter these are pure dart or with flutter, they all setup repo the same.
How do you want to address it ? Add flutter toolchain for all, or split the steps in 2 different jobs ? @fzyzcjy

Surely depends on you :) I will review 8hr later when getting up tomorrow

Well then I'm gonna wait to make some more progress to avoid consuming your Github Action credit and your time altogether. I still have to improve on these points 😅

Add flutter toolchain for all, or split the steps in 2 different jobs ?

adding flutter toolchain LGTM, since that is really a flutter project :)

Surely depends on you :) I will review 8hr later when getting up tomorrow

Well then I'm gonna wait to make some more progress to avoid consuming your Github Action credit and your time altogether. I still have to improve on these points 😅

Btw that 8hr has already passed - I reviewed it this morning (about 6hr ago from now).
No worries about CI - the definition, "continuous" integration, means it will run for every commit. Big repos like Rust, Flutter, etc, all do that. Btw GitHub supports open source projects by providing free CI for public repos.

Alright ! A big thanks anyway, that's a pleasure contributing to your repo @fzyzcjy :)

Also a pleasure for me :)

going to merge once ci pass :)

CI is failing:

should I add architecture: x64 to subosito/flutter-action@v2 ?

Given the another ios test passes, the code should be ok.  Feel free to solve it (in another PR)!

@all-contributors please add @Roms1383 for doc


TCP Won't Connect

Specs

Leon version: 1.0.0-beta.7
OS (or browser) version: Windows 11 x64
Node.js version: 16.17.1
Complete "leon check" (or "npm run check") output:
(if using Docker) Complete "npm run docker:check" output:
(optional) Leon skill version:

Expected Behavior
Works on server
Actual Behavior
I get a flashing dot in browser and command line says trying to connect to tcp server
How Do We Reproduce?
Extra (like a sample repo to reproduce the issue, etc.)

Hi @JerryBerry12, please try the following and let us know how it goes:
npm install --global @leon-ai/cli@beta
leon create birth --develop
leon check
leon start

If it says that a Leon instance already exists after you've ran the create birth command, then do a leon delete and confirm the deletion.

hi @louistiti, sorry for the late response. i am getting this error
C:\Users\ *username*  \.leon\node_modules\@ffmpeg-installer\ffmpeg\index.js:42
    throw 'Could not find ffmpeg executable, tried "' + npm3Binary + '", "' + npm2Binary + '" and "' + topLevelBinary + '"';
    ^
Could not find ffmpeg executable, tried<EMAIL_ADDRESS>"C:\Users\BlueBinkSter\.leon\node_modules\<EMAIL_ADDRESS>and<EMAIL_ADDRESS>(Use `node --trace-uncaught ...` to show where the exception was thrown)
Error: Command failed with exit code 1: npm start

when i run the code leon start

Interesting, can you delete the node_modules folder and the package-lock.json file and retry?

ok its deleting. Do you mean the whole process like
npm install --global @leon-ai/cli@beta
leon create birth --develop
leon check
leon start

or just leon start ?

ok the folders are deleted. i ran leon create birth --develop and it is throwing out this
Error: C:\Users\  *username*  \.leon already exists, please provide another path.

when i run leon info it says that no leon instances are found.
Any suggestions?

OK it's Fixed! Let me tell you what I did.

I deleted .leon
I reran leon create birth --develop
When I run leon start, it takes 20-30 seconds to find the tcp server but it eventually does.
Thanks for your help!
p.s. I'm trying to set up stt and tts now...
-JerryBerry12

Interesting, can you delete the node_modules folder and the package-lock.json file and retry?

Delete of the node_modules folder broke my entire nodejs and npm. Cant even uninstall and reinstall it with apt. Do never ever delete this folder!


Add UIScreenEdgePanGestureRecognizer support

I notice you use the pan gesture recognizer.  Any future plans to support an edge gesture recognizer?

Sounds useful, specially for screens that have horizontal scrolling content. I wasn't considering adding support for it but I might do it. I'll leave this as a low priority task unless it gets a few thumbs up.

Horizontal scrolling is exactly my reason for asking.

@Amnell the current implementation only applies the gesture recognizer to the first UIViewController of a UINavigationController hierarchy. This might be modified but I feel that swiping from a pushed view controller to another view controller inside the UITabBarController doesn't follow the native UX.
On selectedViewController change:
swipeInteractor.wireTo(viewController: selectedController.firstController())

Do you think it can be an optional feature?

@Ashald the edge pan? Yeah, shouldn't be too complicated to support edge pans but I currently don't have the time to work on it.

This might get added on the refactor branch since it shouldn't be too troublesome to add it. Any help would be appreciated.


The website remains stable if the window is resized repeatedly.

Description : when window is resized repeatedly the website and all of the elements of the website are stable and displayed properly.
Precondition : the website is up and running

**Step 1 :**Launch the website and ensure it starts properly.
Expected result : The website is opened properly

Step 2 : Click and drag the bottom-right corner of the application window to make it smaller  to the minimum possible size.
Expected result : The website should resize smoothly without crashing or freezing and the elements of the website are not affected.

Step 3 : Enlarge the window - click and drag the bottom-right corner of the application window to make it larger  to the maximum possible size.
Expected result : The website should resize smoothly without crashing or freezing and the elements of the website are not affected.

Step 5: After completing all resizing actions, verify that the website is still stable and functioning as expected.
Expected result : Everything is displayed properly and nothing has crashed


How to enable 2FA in WsFed

when I'm using regular auth from Microsoft, I can use SignInManager to perform 2FA and the code from Microsoft App Authenticator can be usable. But how do I achieve that if I'm using client type like WS-FED/SAML?

Not sure those legacies protocols support 2FA. Did you try to setup 2FA at https;//yourtheidserver/Identity/Account/Manage/TwoFactorAuthentication and login ?


Invalid props crashes the app when importing Tippy from other library

Describe the bug
This one is kinda hard to create a reproducible example. I tried using invalid props with tippy installed directly in the project and it gives me a nice warning message, but when I import a component from a library that uses Tippy, it crashes the entire page. The error message:

Error message
Uncaught Error: [tippy]: `foo` is not a valid option
    at my-lib.esm.js:13620
    at Array.forEach (<anonymous>)
    at validateOptions (my-lib.esm.js:13618)
    at tippy (my-lib.esm.js:15007)
    at my-lib.esm.js:15217
    at commitHookEffectList (react-dom.development.js:22030)
    at commitLifeCycles (react-dom.development.js:22080)
    at commitLayoutEffects (react-dom.development.js:25344)
    at HTMLUnknownElement.callCallback (react-dom.development.js:336)
    at Object.invokeGuardedCallbackDev (react-dom.development.js:385)
    at invokeGuardedCallback (react-dom.development.js:440)
    at commitRootImpl (react-dom.development.js:25082)
    at unstable_runWithPriority (scheduler.development.js:697)
    at runWithPriority$2 (react-dom.development.js:12149)
    at commitRoot (react-dom.development.js:24922)
    at finishSyncRender (react-dom.development.js:24329)
    at performSyncWorkOnRoot (react-dom.development.js:24307)
    at scheduleUpdateOnFiber (react-dom.development.js:23698)
    at updateContainer (react-dom.development.js:27103)
    at react-dom.development.js:27528
    at unbatchedUpdates (react-dom.development.js:24433)
    at legacyRenderSubtreeIntoContainer (react-dom.development.js:27527)
    at Object.hydrate (react-dom.development.js:27591)
    at renderReactElement (index.js:31)
    at _callee4$ (index.js:37)
    at tryCatch (runtime.js:45)
    at Generator.invoke [as _invoke] (runtime.js:271)
    at Generator.prototype.<computed> [as next] (runtime.js:97)
    at asyncGeneratorStep (asyncToGenerator.js:5)
    at _next (asyncToGenerator.js:27)
    at asyncToGenerator.js:34
    at new Promise (<anonymous>)
    at new F (_export.js:36)
    at asyncToGenerator.js:23
    at _doRender (index.js:37)
    at doRender (index.js:33)
    at _callee2$ (index.js:21)
    at tryCatch (runtime.js:45)
    at Generator.invoke [as _invoke] (runtime.js:271)
    at Generator.prototype.<computed> [as next] (runtime.js:97)
    at asyncGeneratorStep (asyncToGenerator.js:5)
    at _next (asyncToGenerator.js:27)
    at asyncToGenerator.js:34
    at new Promise (<anonymous>)
    at new F (_export.js:36)
    at asyncToGenerator.js:23
    at _render (index.js:21)
    at render (index.js:18)
    at _callee$ (index.js:18)
    at tryCatch (runtime.js:45)
index.js:1 The above error occurred in the <Tippy> component:
    in Tippy (created by ForwardRef(TippyWrapper))
    in ForwardRef(TippyWrapper) (created by Tooltip)
    in Tooltip (at pages/index.js:17)
    in div (at pages/index.js:16)
    in div (at pages/index.js:8)
    in Home (created by App)
    in App
    in Container (created by AppContainer)
    in AppContainer

React will try to recreate this component tree from scratch using the error boundary you provided, App.

To Reproduce
The component on my-lib:
import React from 'react';
import Tippy from<EMAIL_ADDRESS>
const Tooltip = props => <Tippy {...props} />;

Tooltip.defaultProps = {
  arrow: true,
};

export default Tooltip;

Then in the project:
import { Tooltip } from "my-lib";
...
<Tooltip content="Tooltip" foo="bar">
  Hello World
</Tooltip>

And then page crashes.
Expected behavior
The page should not crash
Additional context
This bug would not be so bad with just the crash since I can fix the prop and reload the page. The problem is that for some reason on my project, the crash was "recursive" and every time I open the page it completely freezes the tab, so I had to go to the Task Manager to kill the process, and it took a loong time to find where the incorrect prop was (since I couldn't read the console).

I figured out that the recursive error that was freezing the tabs was caused by a misconfigured error boundary. I searched more about the warn -> error problem and don't think the problem is here, so I will close this issue.


Split - App allows splitting when the sum of splits is not equal to total amount

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 1.4.80-6
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4601034
Issue reported by: Applause - Internal Team
Action Performed:

Go to staging.new.expensify.com
Go to group chat
Go to + > Split expense
Enter amount > Next
Enter 0 as split amount for each participants
Click Split button

Expected Result:
The split will not be created because "The sum of splits must equal the total amount."
Actual Result:
The split is created despite the error "The sum of splits must equal the total amount."
Error shows up after the split is created
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

Screenshots/Videos
Add any screenshot/video evidence

https://github.com/Expensify/App/assets/78819774/ab9d9566-3ba9-4cac-8008-2e64bd3f9a70
View all open jobs on GitHub

@thienlnam  FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

We think that this bug might be related to #vip-split

This issue is about frontend error handling, so it's not a backend blocker.

To unblock deploy as fast as possible, I will go with the revert

CPing the revert

Thanks for handling Vit - we should be good here now

Oh yeah, we can offer $75 for helping find this and confirming that the PR is the root cause. Does that work for you? There was not much work involved in this and we still need to get the original PR deployed

$75 to @ishpaul777

Payment summary:

@ishpaul777 $75 - offer spent

upwork link

Paid ✔


Cost estimate?

First, Matt, congratulations on the success thus far of your projects. I am sure you will soon have Sam Altman unable to sleep :-). In the readme, you said:
It'll take some time (from 10 minutes to a couple of hours, depending on how many examples you generate), but soon, you'll have your fine-tuned model!
Can you give some ballpark cost estimates / ranges for this? Thx.

YMMV but I just generated 100 sample at a cost of $5.05 on the GPT-4 API

That seems reasonable. Thanks! I just don't want to go broke ....
“None of you has faith until he loves for his brother or his neighbor what
he loves for himself.”
On Thu, Aug 24, 2023 at 3:59 PM Dillon Erb @.***> wrote:

YMMV but I just generated 100 sample at a cost of $5.05 on the GPT-4 API
—
Reply to this email directly, view it on GitHub
https://github.com/mshumer/gpt-llm-trainer/issues/14#issuecomment-1692398644,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABJYQ6Q535YQULCI4T7C5WDXW66CFANCNFSM6AAAAAA35PC7XM
.
You are receiving this because you authored the thread.Message ID:
@.***>

Not all examples are the same, this is mine:


 not showing inside modal

react-native: 0.55.1
react: 16.3.1
native-base: ^2.4.1

Expected behaviour
 should work as it does normally in normal views.
Actual behaviour
 is not rendering inside the react native modal.
Is the bug present in both ios and android or in any one of them?
The issue exists in iOS. Didn't check fin Android.
Screenshot of emulator/device

Steps to reproduce (code snippet or screenshot)
<View>
          <Modal
            animationType="slide"
            transparent={false}
            visible={this.state.modalVisible}
            onRequestClose={() => {
              alert("Modal has been closed.");
            }}
          >
            <View>
              <Container>
                <Header>
                  <Left>
                    <TouchableHighlight
                      onPress={() => {
                        this.setModalVisible(!this.state.modalVisible);
                      }}
                    >
                      <Text>Cancel</Text>
                    </TouchableHighlight>
                  </Left>
                  <Body>
                    <Title>Notifications</Title>
                  </Body>
                  <Right>
                    <TouchableHighlight
                      onPress={() => {
                        this.setModalVisible(!this.state.modalVisible);
                      }}
                    >
                      <Text>Send</Text>
                    </TouchableHighlight>
                  </Right>
                </Header>
                <Content>
                  <Text style={styles.termsText}>
                    asdasDThe icons are available under the Apache License
                    Version 2.0. We'd love attribution in your app's "about"
                    screen, but it's not required. The only thing we ask is
                    that you not re-sell these icons.
                  </Text>
                </Content>
              </Container>
            </View>
          </Modal>
        </View>

Thanks, it worked,closing the issue now


CI-install

Looking to merge updates made in explore branch to master. Changes include:

added pytest, pytest-cov and flake8 to environment
updated requirements.txt file to include all necessary libraries
added .travis.yml, .coveragerc files
updated setup.py file

Additionally, I starting cleaned up the experiments folder and put more experimental-focused work in playground_nbs subfolder.

Made changes to the files mentioned above and removed files/folders that were unnecessary in the most recent commit.


Make IV display example append IV% to names

Merge with my previous version of this script, which also preserves existing nicknames. Makes sorting alphabetically  somewhat useful also (would be better with leading 0s but that seems ugly). Given the range is 0-45, this rounds to the nearest whole percentage instead of including a decimal digit.

❤


remove dataclasses as they are built-in from python 3.7

this dependency wouldn't build the image, we should probably build the production image as part of tests.
The solution is to remove it as it's a backport of a feature from python 3.7, and ubi image upgrade upgraded base python version

/retest


How to set a context path?

When I set baseURL, It can change some pathes. But .css .js files can not work.

Please use https://discourse.gohugo.io/ for questions/troubleshooting. Also see  Hugo Documentation.

set canonifyurls = true in config.tml file,It can solve this problem.

I have the same issue with static assets. Setting canonifyurls in config.yml doesn't fix anything. The documentation is throwing me off... How something as simple as including static assets is so complicated.


Sometimes items on an order are not stored as JSON array but as JSON objects

Bug Description
I'm using the Simple Commerce plugin in combination with Runway.
Sometimes the product items are store in the incorrect format in the database table which results in not being able to view them in the CP. It's not clear when and why this happens, but maybe you have an idea.
Below is a screenshot of the Orders CP view in Simple Commerce for the last two orders:

Following is data from the first order in the overview:
{"0": {"id": "fedcb2b6-941c-406f-8cb5-5cbfc3e97177", "tax": {"rate": 0, "amount": 0, "price_includes_tax": false}, "total": 100, "product": "24173ec0-5104-4d65-8ee5-7dbf9b4ce7f1", "variant": null, "metadata": [], "quantity": 1}, "4": {"id": "a84121ad-2ddb-4fc9-8725-d584fbc60fdc", "tax": {"rate": 0, "amount": 0, "price_includes_tax": false}, "total": 200, "product": "a9f67df3-4569-41f8-b477-dfa189b15a09", "variant": null, "metadata": [], "quantity": 1}, "5": {"id": "af34916c-e422-488f-a80c-bb0121f0bc86", "tax": {"rate": 0, "amount": 0, "price_includes_tax": false}, "total": 300, "product": "f3b3a75b-ea1e-4ad4-b66b-98c20a4f78bd", "variant": null, "metadata": [], "quantity": 1}, "6": {"id": "9995f893-f53f-4ba2-b79e-18aeea65aa81", "tax": {"rate": 0, "amount": 0, "price_includes_tax": false}, "total": 400, "product": "a3e2db11-f34f-445b-a322-8e54231987e4", "variant": null, "metadata": [], "quantity": 1}, "7": {"id": "4d3cb65d-1263-47ab-9f8b-74c5918156d0", "tax": {"rate": 0, "amount": 0, "price_includes_tax": false}, "total": 500, "product": "1e0f98ab-ba8d-402f-ba71-5e4b8d30deba", "variant": null, "metadata": [], "quantity": 1}}
Following is data from the second order in the overview:
 [{"id": "47ad85a2-bdd4-4371-97d0-8a1435a9edab", "tax": {"rate": 0, "amount": 0, "price_includes_tax": false}, "total": 100, "product": "6d301e16-fb13-4d9d-bd9a-f8ba60b99095", "variant": null, "metadata": [], "quantity": 1}, {"id": "a8d2907b-7a4e-480c-aa4f-8a28c2c73f73", "tax": {"rate": 0, "amount": 0, "price_includes_tax": false}, "total": 200, "product": "a5717e17-87a0-46e6-99d7-a20d57e5c0e8", "variant": null, "metadata": [], "quantity": 1}]
If I change the first one to match the correct JSON array style it works as expected.
Steps to reproduce
Not sure yet how this can be reproduced.
Environment
Statamic 3.3.13 Pro
Laravel 8.83.15
PHP 8.0.8
doublethreedigital/runway 2.3.8
doublethreedigital/simple-commerce 3.2.6
joetannenbaum/antlers-stack-tags 0.1.0
optimoapps/statamic-bard-text-align 1.0.2
roorda-ict/statamic-entries-export 1.0.0

This was a FE user action only.
It does seem that the user removed some products from the order. Since it
starts at 0 and skips to 4
Op ma 20 jun. 2022 19:08 schreef Duncan McClean @.***>:

Okay, the second JSON blob you copied is how they all should be.
Do you know how the orders were 'transformed' into the first blob you
copied in - just by saving the order?
—
Reply to this email directly, view it on GitHub
https://github.com/doublethreedigital/runway/issues/151#issuecomment-1160675749,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ATOWGXWGABVLSTGGVGR7WG3VQCQQDANCNFSM5ZIEI6AQ
.
You are receiving this because you authored the thread.Message ID:
@.***>

Ah - managed to reproduce it. Looks like it's a Simple Commerce problem after removing an item from the cart.
Should be a case of adding ->values() to wherever is setting the line items (whenever I get to it - probably not tonight).


made docs look pretty

just made docs more legit

on your part, well done, though!

oh yes, i just merged it straight away


fix: update transcript conversions to handle point at infinity

This PR adds to native and stdlib field conversion tests for the converting the point at infinity on both Grumpkin and BN254. It fixes how the transcript handles the point at infinity by encoding it as a vector of 0s in the transcript.
The original error happens because when we set a point to the point at infinity, we modify the x-coordinate a group element while its in Montgomery form. As a result, when we transform it back to normal form (when calling from_montgomery_form()), and then convert it back to Montgomery form (calling to_montgomery_form()), we don't get the same value as what we started with. Normally, we don't run into this problem because we don't fiddle around with values while they are in Montgomery form, except in this case.
Addresses https://github.com/AztecProtocol/barretenberg/issues/866.

Benchmark results
No metrics with a significant change found.

Detailed results
All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call  to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.
This benchmark source data is available in JSON format on S3 here.
Values are compared against data from master at commit 74025170 and shown if the difference exceeds 1%.
L2 block published to L1
Each column represents the number of txs on an L2 block published to L1.

Metric
8 txs
32 txs
128 txs

l1_rollup_calldata_size_in_bytes
54,212
214,436
855,332

l1_rollup_calldata_gas
259,856
1,019,768
4,060,052

l1_rollup_execution_gas
354,042
1,139,216
4,281,453

l2_block_processing_time_in_ms
1,270 (-1%)
4,805
18,968 (-1%)

note_successful_decrypting_time_in_ms
216 (-3%)
627 (+3%)
2,184 (-1%)

note_trial_decrypting_time_in_ms
30.8 (-22%)
71.8 (+29%)
188 (-2%)

l2_block_building_time_in_ms
21,342
84,619
343,436

l2_block_rollup_simulation_time_in_ms
16,008
63,413
258,864

l2_block_public_tx_process_time_in_ms
5,305
21,128
84,320

L2 chain processing
Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric
5 blocks
10 blocks

node_history_sync_time_in_ms
16,477 (+2%)
31,852 (+4%)

note_history_successful_decrypting_time_in_ms
1,417 (+1%)
2,718 (-1%)

note_history_trial_decrypting_time_in_ms
191 (-13%)
224 (+1%)

node_database_size_in_bytes
18,722,896
35,930,192 (-1%)

pxe_database_size_in_bytes
29,923
59,478

Circuits stats
Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit
circuit_simulation_time_in_ms
circuit_input_size_in_bytes
circuit_output_size_in_bytes

private-kernel-init
334
44,664
27,457

private-kernel-ordering
214
45,777
14,627

base-rollup
1,740
175,344
933

root-rollup
84.0
4,192
825

private-kernel-inner
443
73,099
27,457

public-kernel-app-logic
274
32,254
25,379

merge-rollup
7.81
2,712
933

Tree insertion stats
The duration to insert a fixed batch of leaves into each tree type.

Metric
0 deployed contracts
1 deployed contracts

tx_size_in_bytes
15,388
36,001

Transaction processing duration by data writes.

Metric
0 new note hashes
1 new note hashes

tx_pxe_processing_time_ms
584 (+1%)
1,503

Metric
0 public data writes
1 public data writes

tx_sequencer_processing_time_ms
0.0284 (-9%)
654

Can return to this after we handle https://github.com/AztecProtocol/barretenberg/issues/871

Can return when we handle https://github.com/AztecProtocol/barretenberg/issues/871


Installation of 2.54 fails on linux

BUG REPORT INFORMATION
- Do you want to request a feature or report a bug?
Bug.
- What is the current behavior?
I'm unable to install the latest netlify-cli via npm.
- If the current behavior is a bug, please provide the steps to reproduce.
$ npm install netlify-cli -g
npm ERR! code ETARGET
npm ERR! notarget No matching version found for<EMAIL_ADDRESS>npm ERR! notarget In most cases you or one of your dependencies are requesting
npm ERR! notarget a package version that doesn't exist.
npm ERR! notarget
npm ERR! notarget It was specified as a dependency of '@netlify/build'
npm ERR! notarget

npm ERR!
The latest version of netlify-cli should be installed
- Local Environment Information
────────────────────┐
 Environment Info   │
────────────────────┘

  System:
    OS: Linux 4.19 Raspbian GNU/Linux 10 (buster) 10 (buster)
    CPU: (4) arm ARMv7 Processor rev 4 (v7l)
  Binaries:
    Node: 14.4.0 - /usr/bin/node
    npm: 6.14.5 - /usr/bin/npm
  Browsers:
    Firefox: 68.9.0esr
  npmGlobalPackages:
    netlify-cli: 2.50.0

netlify-cli/2.50.0 linux-arm node-v14.4.0

Hi @lukehsiao,
Can you try again?
According to npm<EMAIL_ADDRESS>does exist: https://www.npmjs.com/package/@netlify/cache-utils

I see, looks like it was just released ~30mins ago, even those v2.54 was release 9 days ago? Is there a way for netlify to make sure things are release in sync, so that the cli isn't pointing to non-existant dependencies for several days?
I can confirm that it installs correctly now that v1.0.0 of cache-utils exists.

I see, looks like it was just released ~30mins ago, even those v2.54 was release 9 days ago? Is there a way for netlify to make sure things are release in sync, so that the cli isn't pointing to non-existant dependencies for several days?

This problem was not due to the release being 9 days ago, but a few-seconds-long lag from npmjs.com when running npm publish. We are looking into how to prevent this in the future.


Encoder feed

I've been using the previous version of this project, and after I update to this one I've been using some ESC/POS commands in order to open the cashier box, and so on.
For this purpose I send just a pulse and should work as long as the printer is connected to the cashier box, the problem is that after the update, every time I send encoder.pulse().encode() the printer keeps outputting some feed like there was something in the config that makes it do that.
What should I do in this case?

This is fixed in the next release (See #34)


[v0.6.0 Release Docs] SMI Conformance

As part of Release Blog for v0.6.0, we have created this issue belonging to epic [#4127] in order to organize and ensure the smooth release of the blog. Feel free to leave a comment if you would like to take up this respective blog or any section of it.
Some of the Areas to be covered for SMI Conformance:

[ ] What is the conformance program? How do I verify my service mesh’s conformance to SMI?
[ ] What sample application is used?
[ ] How many tests are there? What do they test?
[ ] Meshery UI and SMI Conformance Dashboard on the landscape: How to interpret the results?
[ ] mesheryctl mesh validate

Guides and Resources

v0.6.0 Docs
v0.6.0 Milestone
v0.6.0 RoadMap
v0.5.0 blog
🛠 Meshery Build & Release Strategy

I would like to contribute to this blog topic. Can you help me pointing out which docs should I refer to gain information about SMI Conformance?

I have made a draft of the 3 tasks but not sure about what to add in the 4th task. Can you review it and give some suggestions or feedback?
https://docs.google.com/document/d/19rSlPdKe08-RiB8jnj51XH5RU1NAFb_LyOX6FYgVrHQ/edit?usp=sharing

@SirZeck These two docs should cover everything related to SMI. You can also check the links referenced in those posts for more info.
https://docs.meshery.io/functionality/service-mesh-interface
https://docs.meshery.io/guides/smi-conformance

@navendu-pottekkat as it is mentioned in the task 4 that I have to explain what the red crosses and yellow crossed means mentioned on this dashboard, right?
https://meshery.io/service-mesh-interface

Yes. That is correct. You can check here: https://layer5.io/service-mesh-landscape#smi

You can also check this: https://smi-spec.io/blog/validating-smi-conformance-with-meshery/

I have made a draft of the 3 tasks but not sure about what to add in the 4th task. Can you review it and give some suggestions or feedback?
https://docs.google.com/document/d/19rSlPdKe08-RiB8jnj51XH5RU1NAFb_LyOX6FYgVrHQ/edit?usp=sharing

Now the draft is completed, can you review it for any changes or additions?

Awesome! Thank you so much @SirZeck!
@navendu-pottekkat could you review this?

Yes sure.

Will this be a separate blog post or will it be added to the release blog?

I'm not sure. @leecalcote?


Logs, docs and CLI

PLEASE.. do not merge it yet

sorry.. good to go now

Let me give it a shot..

@johnament  nice one


Your card wasn't correctly detected. Let's try again

I'm trying to install Coder in SD card using SDFormatter like I do in my SD cards to install Raspberry Pi distros in raspberrypi.org
All the time I get "Your card wasn't correctly detected. Let's try again".
Environment:
MacOSX 10.8.5
SD Card Element 14 4GB formatted in FAT-32

I'm keen on running Coder but the same issue occurs.

raspberry pi2B
SanDisk Extreme micro SDHC UHS-I 32GB Card (recommended by a test)

I followed your hints above but "Your card wasn't correctly detected. Let's try again" is returned always...
Thanks for your help a lot!


localsend: 1.13.1 -> 1.14.0

Description of changes

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 292012 run on x86_64-darwin 1

1 package built:

localsend

Result of nixpkgs-review pr 292012 run on x86_64-linux 1

3 packages built:

localsend
localsend.debug
localsend.pubcache

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-already-reviewed/2617/1510


Integrate progress calculator into my assessments

The ProgressCalculator can generate a % completion for an assessment, as well as give indicators of whether individual activity assessments have yet to be started, are in progress, or are completed.
It should be wired into the assessment page so give an accurate summary of progress.

Added to the scoring branch


Add release note signup to CC release pages

Fixes #7006.

This change is

Online preview: http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/ec3b53e77ed6489fe57c14aa35308fb8f30bae74/
Edited pages:

releases/cockroachcloud-03022020.md
releases/cockroachcloud-04062020.md


Activating SIMD in RapidJSON

I found that rapidjson can use SIMD instructions for some operations. This can be activated by setting #define RAPIDJSON_SSE42. I activated SSE4.2 and NEon for x86 and ARM processors. The speedup is significant, especially on the Apple M1 (in my testing, 5x on log replay). My Commit is not perfect because if the chosen SIMD instructions are not supported it fails to build. Ideally, one should implement a check if the SIMD instructions are supported on the platform. If someone has an idea on how this can be done, let me know.
Link in RapidJSON Docs

I can't merge because I'm preparing to commit some massive changes. I've basically rewritten SpinoDB and one of the many changes is to use a binary file format.


puts "undefined" in empty inputs

the trim  directive does not work well when the model is undefined.
then it converts undefined to a string "undefined"
so the text input is filled with "undefined" instead of being empty

@anein I'm using version 2.1.7 and I still have this problem.
More specifically, if the value is null then it's ok, if it's undefined then the "undefined" string appears.

It's odd that, for some reason, this val = val || '' condition passes "undefined" values. The demo has a field with undefined value and it works fine.
So,  we have no choice but to rewrite this condition. =)

@anein any news on this? it looks quite a serious issue and it's currently breaking our production env

@ShinDarth Yes, but to be sure that all works fine, could you post an example how you got the issue?

@anein sure, here it is:
https://stackblitz.com/edit/angular-vobpkx

@ShinDarth Thank you. I thought you use a template-driven form. The issue comes in a reactive form for the reason that you forcefully set undefined on the onInit step. Originally, the reactive form automatically converts all undefined values to null during initialization to avoid this issue.
The repo will be updated soon. 😉

@anein please check my PR https://github.com/anein/angular2-trim-directive/pull/29


Add a "Konto löschen" button to the user settings page

Because delete account is probably not used frequently, it should be integrated into the account settings and not remain in the navigation. This would be in line with the standard compared to other websites.

I agree. In AccountSettingsView there should be a button that opens a model where the user has to confirm the deletion. We should also remove with this issue the LeoModal.vue and use the Sakai Confirmation Delete overlay...
https://sakai.primevue.org/uikit/overlay


Please put the current release

There is a lot of changes which is "a must have" but they are still not presenting as official release.
Please update a version which contains the recent changes.
Thanks in advance.

https://www.nuget.org/packages/Plugin.AudioRecorder/1.0.0


new features

multiple destination targets
option for number of timer samples
options for range of sample values for numeric metric types
option for finite run time duration
refactoring signal handling

LGTM


Pickleable tf.function, attempt #2

Updated attempt at #37837
@mihaimaruseac as requested. Thank you!

Thank you


Add .nvmrc config file

Hi guys!
After upgrading to react-scripts: 1.0.2, I'm getting this warning when running npm i:
npm WARN engine<EMAIL_ADDRESS>wanted: {"node":">=6"} (current: {"node":"4.4.5","npm":"2.15.5"})

Why don't we add a .nvmrc file with the node version necessary to use react-scripts?
So then we only need to run nvm i && npm i.
My 2 cents.
Thanks!

Thanks for the suggestion! We don’t really want to add tool-specific dotfiles by default, but it’s a reasonable thing to do in your project if you use nvm.

@BrodaNoel I'd suggest you look at using n instead of nvm, as it's very heavyweight and causes your shell to boot slower.

Thanks both!

@gaearon @Timer just to be clear, which should be the min-node version to use?
I guess it would be great to add it in the documentation.

We mention it in README, is there a better place?

The latest version of create-react-app will also warn you for newly created projects if you’re on a lower version, and will give you 0.9.x in this case.


Implement support for JUnit 5

Resolves #443.
This PR implements CentralDogmaExtension to support JUnit 5.
https://github.com/line/armeria/pull/1736 was used as a base example.
Changes:

Move logic from CentralDogmaRule to CentralDogmaRuleDelegate in testing:common
Implement CentralDogmaRule (testing:junit4) and CentralDogmaExtension (testing:junit)
Migrate some existing tests to JUnit 5

Notes:

JUnit 5 doesn't support extensions inside extensions yet, so I couldn't use @TempDir for the data directory
@TempDir has issues deleting read-only files on Windows at the moment, so some tests cannot be migrated until JUnit 5.6 is released

I wanted to migrate more tests to use the new extension, but I'll do it in another PR to simplify the review process.

Updated! Thanks for the review.

Thanks! @KarboniteKream

Thanks a lot @KarboniteKream!


Create showcase app

Fixes #621.
Screenshot:

@richard-to - still finalizing the functionality, but the main interface is there, any feedback? I think we can keep this hardcoded for a while.
TODOs:

[ ] Support #403
[ ] Proper links
[ ] Add shim page (similar as demo gallery)
[ ] Add a "+ your app" and an issue template
[ ] Deploy app

Overall, it looks good. I like the design better than the demo site. Only one noticeable issue I saw was that mobile view does not work too well.