Maintenance section not accessible on mobile layout

⚠ Please verify that this bug has NOT been raised before.

[X] I checked and didn't find similar issue

🛡 Security Policy

[X] I agree to have read this project Security Policy

Description
There is no link to the maintenance pane when the mobile layout is used.
The actual maintenance section does work, when accessing it before switching to the mobile layout.
On another note, maybe moving the maintenance menu to the settings page altogether would reduce the confusion for both, mobile and desktop users and resolve the issue of inconsistent menus. When I first searched for this new feature, I went straight to the settings page, assuming it is like “Notifications” or “Proxies”, and totally overlooked the new entry in this dropdown.
Desktop:

Mobile:

Thank you for your work on this awesome project!
👟 Reproduction steps

Access web page using the mobile layout (below 768 px wide)

👀 Expected behavior
See maintenance button under settings page above the logout button.
The logout button has moved there too on mobile, so that would be the logical place to search for it.
😓 Actual Behavior
Cannot find the maintenance button anywhere.
🐻 Uptime-Kuma Version
1.19.0-beta.0
💻 Operating System and Arch
Ubuntu 20.04.5 LTS - 5.4.0-92-generic x86_64 GNU/Linux
🌐 Browser
Firefox 105.0.3
🐋 Docker Version
Docker 20.10.12-0ubuntu2~20.04.1
🟩 NodeJS Version
No response
📝 Relevant log output
No response

I can confirm this bug -- first I was searching for the new maintenance functionality using my smartphone on a mobile browser (Firefox), didn't find it anywhere. Switching the Firefox mobile to retrieving the desktop version of the site showed me the maintenance entry (and user menu as a whole).

Works for me now in 1.19 Beta 2 -- thanks!


emit numberTasks metrics from minion

emit numberTasks metrics from minion, at task type level and table task type level.
Following shows the emitted metrics (Prometheus metrics)
curl -s http://localhost:8080 | grep numberTasks_Count
# HELP pinot_minion_numberTasks_Count Attribute exposed for management "org.apache.pinot.common.metrics":name="pinot.minion.RealtimeToOfflineSegmentsTask.numberTasks",type="MinionMetrics",attribute=Count
# TYPE pinot_minion_numberTasks_Count untyped
pinot_minion_numberTasks_Count{id="RealtimeToOfflineSegmentsTask",} 0.0
pinot_minion_numberTasks_Count{table="mytable",tableType="REALTIME",taskType="RealtimeToOfflineSegmentsTask",} 0.0

Codecov Report

Merging #10195 (d4620da) into master (0797e05) will decrease coverage by 44.36%.
The diff coverage is 100.00%.

@@              Coverage Diff              @@
##             master   #10195       +/-   ##
=============================================
- Coverage     69.02%   24.66%   -44.36%
+ Complexity     5800       48     -5752
=============================================
  Files          2020     2008       -12
  Lines        109138   108790      -348
  Branches      16570    16532       -38
=============================================
- Hits          75328    26830    -48498
- Misses        28508    79166    +50658
+ Partials       5302     2794     -2508

Flag
Coverage Δ

integration1
24.66% <100.00%> (?)

integration2
?

unittests1
?

unittests2
?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...a/org/apache/pinot/common/metrics/MinionMeter.java
100.00% <100.00%> (ø)

.../pinot/minion/taskfactory/TaskFactoryRegistry.java
75.26% <100.00%> (+10.10%)
:arrow_up:

...in/java/org/apache/pinot/spi/utils/BytesUtils.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...java/org/apache/pinot/spi/trace/BaseRecording.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...java/org/apache/pinot/spi/trace/NoOpRecording.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...ava/org/apache/pinot/spi/config/table/FSTType.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...ava/org/apache/pinot/spi/config/user/RoleType.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...ava/org/apache/pinot/spi/data/MetricFieldSpec.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...ava/org/apache/pinot/spi/stream/StreamMessage.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...java/org/apache/pinot/common/tier/TierFactory.java
0.00% <0.00%> (-100.00%)
:arrow_down:

... and 1540 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


How to handle ambiguous paths in the API spec

Overview
How to handle ambiguous paths in the API spec?
As seen in the docs linting warnings when running npm run docs, we have some ambiguous/conflicting paths.
Example:
Paths should resolve unambiguously. Found two ambiguous paths: `/sites/by-delivery-type/{deliveryType}` and `/sites/{siteId}/experiments`.

In some cases, it's clear that the static path segments like by-delivery-type,experiements etc. don't match with the format requirements of the path parameters like siteId (uuid), deliveryType (enum).
But it's still confusing and error prone, as routes have to be order from the most specific to the more dynamic in the API implementation, in order to have the proper behavior of the API implemented.
Proposed Actions
Come up with a recommendation so that we can avoid ambiguous paths in the future from the API design phase.

cc: @solaris007, @chicharr


Generated docs contain url like this %2520 and results in 404 error

Can you provide an example?

change doclet.alias = '(Vue) ' + componentName to doclet.alias = '(Vue)-' + componentName
at /lib/vueTag.js

Well, that will change the module name too:

Aaand... I don't find this very pretty..
I will search if it's possible to change the filename without changing the module name. I hope it exists, that would be awesome!

umm..  i want to know why add blank space before componentName

Well... idk, I wanted to add a badge-like to easily distinguish a Vue component and a plain-JS module.
But we can probably  use doclet.alias = componentName + '.vue' I think :)

Check this PR #14


Only call stream_->Finish() after BOTH reads AND writes are done.

As documented in #12, we were calling Finish() too early - we shouldn't call it before BOTH reads AND writes are done.
This PR corrects that problem.
It increases the number of times we lock a Mutex, but the increase is O(1): we lock once more at start-time, and once more for both writes-finish and reads-finish time. Small price to pay for avoiding persnickety bugs that come with not using your APIs as you're supposed to. 😄
Fixes #12

Primarily would like review from @while-false but CCing @benh for future reference and because he may decide he wants to optimize the mutexes away?


⚠ Bofrost.lu has degraded performance

In 2a132d1, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 1184 ms

Resolved: Bofrost.lu performance has improved in 880764c after 8 minutes.


Is the documentation up to date?

I've been looking at this documentation here.
var schema = (
  <Schema>
    <Property
      name="description"
      required
      label="Message"
      input={<textarea placeholder="Give us details here..." />}
    />
    <Property
      name="email"
      label="Email"
      required
      input={<input type="email" />}
      validate={function(v) { return /.+\@.+\..+/.test(v) }}
    />
  </Schema>
)

It looks very different from the example in the master branch.
var schema = Mapping({
    description: Scalar({
      required: true,
      label: 'Message',
      input: <textarea placeholder="Give us details here..." />
    }),
    email: Scalar({
      label: 'Email',
      required: true,
      input: <input type="email" />,
      validate(node, value) {
        if (!/.+\@.+\..+/.test(value)) {
          return new Error('should be in<EMAIL_ADDRESS>format');
        }
      }
    })
  })

Has the API changed recently and the documentation not been updated yet?

+1
Even just a few examples of the new API would be awesome.

The docs folder in master have some examples of the new api

Inspecting ReactForms.schema showed the Schema object is gone. No more XML-style declarations?

https://github.com/prometheusresearch/react-forms/blob/master/docs/api.rst
We should work together to start building examples for the new API.

+1


Cold and Flu: Deploy form to PROD and HIDE from all users except team and ADMIN

User Story
“As a form owner I want test the 2024 form in PROD so I can be sure everything, including data is working as expected from login to report creation in BI.”
Tasks

[ ] create or revive cold and flu ADMIN security group
[ ]  Deploy 2024 from to Prod on March 20 or 21
[ ]  Form in prod should be visible, and fully functional ONLY to the Admin group, or team
[ ]  Form in PROD should be made available to testing subjects when we are given their information
[ ]  On June 10 form is visible and accessible to all employees

Acceptance Criteria
After deployment March 20/21:

[ ]  Admin and dev team can see use a2024 form
[ ]  Invited test subjects can access and submit form

Bhumin and I created a new group cold-flu-test on production. And assigned this new group to our Team(Stella, Ayushi, Mike and devs).
@Stella-Archer could you let me know who else should I assign to? and who should be admin? Thanks

Waiting for list from Heather

We've got a list @jerry-ey https://bcgov.sharepoint.com/:w:/r/teams/03991/Shared Documents/Cold and Flu/2024 Cold and Flu/Testers for 2024 cold and flu form security group.docx?d=w60a5579e49554a05bfccdeea9213e6e2&csf=1&web=1&e=SN1KPH

Tested on PRD, working fine.
Without the group cold-flu-test (except for cold-flu-admin, use can not see the cold/flu form.

Added two people to admin group.

team member who is not in the admin group could not see it (YAY) so I'm PO approving & closing


[GatesNotesBridge] Unable to parse xml

@corenting Unable to parse xml from https://www.gatesnotes.com/rss Opening and ending tag mismatch: br line 1 and p
As I understand, it's reproduce with the articles which do not have title and description («No Blurb is set for this article», like The-Year-Ahead-2023-Ch-09): then description contains non-xhtml
 tag.
I tried to send a message to the site devs, but contact page on gatesnotes.com returns Service unavailable for me.
To Reproduce

Generate feed when it contains items with «No Blurb is set for this article»
See error

xmllint /tmp/a
/tmp/a:1: parser error : Opening and ending tag mismatch: br line 1 and p
otes.com/The-Year-Ahead-2023-Ch-09</link><title></title><description>

https://validator.w3.org/feed/check.cgi?url=https%3A%2F%2Fwww.gatesnotes.com%2Frss

@corenting


Add aria-label to search button

As the title implies. :)

No problem, thanks for sorting this out :)


add rssfeed to latest

please add adapter to latest repository

2 commits in one pull request.
new pull request is comming


Delete manifests/j/JanDeDobbeleer/OhMyPosh/7.45.0 directory

[ ] Have you signed the Contributor License Agreement?
[ ] Have you checked that there aren't other open pull requests for the same manifest update/change?
[ ] Have you validated your manifest locally with winget validate --manifest <path>?
[ ] Have you tested your manifest locally with winget install --manifest <path>?
[ ] Does your manifest conform to the 1.2 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

@wingetbot run

@wingetbot run


Make Provider optional for Wallet

The idea is to make it possible to use the Wallet methods that don't need a Provider. We should validate the Provider when needed and throw an error if it's not there.

[!NOTE]

Incoming from https://github.com/FuelLabs/fuels-ts/discussions/1537

I believe this is a duplicate of #1444?

@petertonysmith94 Good catch.
Closing in favor of #1444.


V5 Offcanvas/Modal : Open the Offcanvas/Modal using switches

I hope the BS core team try to support the possibility opening of Offcanvas & Modal using Switches.
something similar to this example :
codepen.io

:-1: you can implement this by yourself if you really need this.

Agree with @alpadev here, this feature is not needed really IMO.
/CC @XhmikosR


[#825][part-2] feat:Report failed blocks and a list of ShuffleServer

What changes were proposed in this pull request?
The ShuffleServer corresponding to the block that failed to be sent needs to be reported.
Ⅰ. Overall objective:

During the shuffle write phase, the ShuffleServer reports faulty nodes and reallocates the ShuffleServer list;
Triggers a Stage level retry of SPARK. The shuffleServer node is excluded and reallocated before the retry.

Ⅱ. Implementation logic diagram:

Ⅲ. As shown in the picture above:

During Shuffle registration, obtain the ShuffleServer list to be written through the RPC interface of a Coordinator Client by following the solid blue line step. The list is bound using ShuffleID.
2, the Task of Stage starts, solid steps, in accordance with the green by ShuffleManager Client RPC interface gets to be written for shuffleIdToShuffleHandleInfo ShuffleServer list;
In the Stage, if Task fails to write blocks to the ShuffleServer, press the steps in red to report ShuffleServer to FailedShuffleServerList in RSSShuffleManager through the RPC interface.
FailedShuffleServerList records the number of ShuffleServer failures. After the number of failures reaches the maximum number of retries of the Task level, follow the steps in dotted orange lines. Through the RPC interface of a Coordinator Client, obtain the list of ShuffleServer files to be written (the ShuffleServer files that fail to be written are excluded). After obtaining the list, go to Step 5 of the dotted orange line. Throwing a FetchFailed Exception triggers a stage-level retry for SPARK;
Attempt 1 is generated by the SPARK Stage level again. Pull the corresponding ShuffleServer list according to the green dotted line.

Why are the changes needed?
Reports the ShuffleServer corresponding to the block that failed to be sent
Fix: #825
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Existing UT

Codecov Report

Merging #1138 (89fc8ff) into master (1406e1f) will decrease coverage by 0.12%.
The diff coverage is 11.73%.

@@             Coverage Diff              @@
##             master    #1138      +/-   ##
============================================
- Coverage     53.70%   53.58%   -0.12%
+ Complexity     2573     2105     -468
============================================
  Files           391      320      -71
  Lines         22314    14589    -7725
  Branches       1867     1325     -542
============================================
- Hits          11984     7818    -4166
+ Misses         9622     6347    -3275
+ Partials        708      424     -284

Files Changed
Coverage Δ

...he/uniffle/coordinator/CoordinatorGrpcService.java
1.62% <0.00%> (-0.28%)
:arrow_down:

...assignment/PartitionBalanceAssignmentStrategy.java
56.52% <0.00%> (-39.07%)
:arrow_down:

...niffle/client/impl/grpc/CoordinatorGrpcClient.java
0.00% <0.00%> (ø)

...ent/request/RssGetReShuffleAssignmentsRequest.java
0.00% <0.00%> (ø)

...r/strategy/assignment/BasicAssignmentStrategy.java
62.50% <15.38%> (-32.74%)
:arrow_down:

...ache/uniffle/coordinator/SimpleClusterManager.java
74.22% <37.50%> (-3.31%)
:arrow_down:

...he/uniffle/client/impl/ShuffleWriteClientImpl.java
33.96% <39.47%> (-2.02%)
:arrow_down:

...uniffle/client/response/SendShuffleDataResult.java
75.00% <66.66%> (-8.34%)
:arrow_down:

... and 75 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

@leixm Could you help me review this pr?

+1 LGTM.


incorrect URI in example when hive is used

there is a problem, when the hive metastore is used, the network name is used to create a host name.
Because network name includes '_', generated URI is incorrect.
to solve it you can change a name of network in dockerfile:
networks:   iceberg_net:     name: "icebergnet"

Thank you @pandabrowski, do you like to send PR for fix?

sorry, i'm short on time.


Input labels validity is checked twice

When a classifier is being trained from scratch then labels validity is checked twice. First, there is a call to check_labels in fit_classifier_impl, and then a call to check_labels overload in fit_classifier_online_impl.

This also implies duplicated call to unique_labels.


Mobile Menu for Modular Page

Mobile menu not displaying on a single page site (example is OnePage skeleton).
Submitted PR to fix this: #5

As I said in the PR, like Antimatter, the mobile menu is not intended to show on-page menu items.

Problem is that on a mobile when showing a modular page, the hamburger shows up. Click on the hamburger and you get the menu (or fallback) of the modular page, which means  it has to be set to something reasonable. Also, if you have a site that is only one page, then there is only a single entry in the mobile hamburger.
This is not something I feel is intuitive. The hamburger should show the menu that is shown when there is no hamburger. IMHO

...the mobile menu is not intended to show on-page menu items.

@rhukster, is there a way to disable the hamburger menu then? It is not intuitive to have a hamburger menu with one item.

Another bump because I also think this is still a problem.
But I just tried the workaround above. It's very simple, but you'll likely need some additional CSS, and the menu doesn't close automatically when selecting a menu item.

Another year, another bump. Either the hamburger menu should show the sections or the hamburger should be hidden, I prefer the former.


Error while running with graphql standalone client in subscriptions

Getting this error even if I am not using any Subscription component
Compiler message:
file://flutter/.pub-cache/hosted/pub.dartlang.org/graphql_flutter-1.0.0+1/lib/src/widgets/subscription.dart:15:3: Error: Function-typed parameters can't specify 'const', 'final' or 'var' in place of a return type.
Try replacing the keyword with a return type.
  final bool loading,
  ^^^^^
file:///flutter/.pub-cache/hosted/pub.dartlang.org/graphql_flutter-1.0.0+1/lib/src/widgets/subscription.dart:16:3: Error: Function-typed parameters can't specify 'const', 'final' or 'var' in place of a return type.
Try replacing the keyword with a return type.
  final T payload,
  ^^^^^
file:///flutter/.pub-cache/hosted/pub.dartlang.org/graphql_flutter-1.0.0+1/lib/src/widgets/subscription.dart:17:3: Error: Function-typed parameters can't specify 'const', 'final' or 'var' in place of a return type.
Try replacing the keyword with a return type.
  final dynamic error,
  ^^^^^

graphql_flutter: ^1.0.0
• Flutter version 1.5.4-pre.17 at /dir/flutter
• Framework revision 0545c63b9b (3 days ago), 2019-04-19 20:41:32 -0400
• Engine revision ca31a7c57b
• Dart version 2.3.0 (build 2.3.0-dev.0.1 cf4444b803)
My code
HttpLink _httpLink = HttpLink( uri: '$gqlendpoint/graphql' );

  AuthLink _authLink = AuthLink(
    getToken: () async => 'Bearer ${accessToken}',
  );

  Link _link = _authLink.concat(_httpLink as Link);

  GraphQLClient _client = GraphQLClient(
    cache: NormalizedInMemoryCache(
    dataIdFromObject: typenameDataIdFromObject,
    ),
    link: _link,
  );

  String query =
  '''
    query getHomeData {
    getDetails{
        userId
        userName
      }
   }
  ''';

  QueryResult res
  = await _client.query(new QueryOptions(document: query, variables: {}));

  print("###############");
  print(res);
  print("###############");

This is the same issue as this  and was fixed by this PR.


Modebus-Flex-Getter Node stops working every few hours - "initialize" Reopened

I'm submitting a ...  (check one with "x")
Simple question to get some hint

(x ) help wanted => you read all information and watched relevant YouTube tutorials, but you need more help

Current behavior
As I cannot reopen #245 I create this new issue.
My Flex-Getter node stops working every few hours, sometimes after one or two days. It then only says "initialize". The problem has to be within node-red-contrib-modbus as a php script which logs data into a database from the same modbus device works without problems.
The workaround/solution is:

log into Node Red
open the flow
open the flex-getter node
open the modbus server
change some small detail (usually "Queue delay (ms)" one ms up or down)
update modbus server with this new setting
close flex-getter node
deploy
Flex-Getter node immediately changes it's state to "active" and data is coming in.

So if there is no approach to avoid flex-getter to stop working: Is there a way to automatically "restart" the connection like I always do manually?
Expected behavior
I would expect that the output of data does not stop.
Minimal reproduction of the problem with instructions
My flow looks like this:
Flow 1:

Read node with one address, interval 10 seconds Screenshot sows the faulty state ("initialized"). Please ignore the blue circles, I just renamed the labels for the screenshot.
Flow 2;

It waits until the function node behind the read node from flow 1 has finished, waits another 2 seconds. Then the function node feeds in data to the flex getter node (one address, quantity 96). Complete node and delay node where used to prevent to many or too quick reads. Screenshot also shows the faulty state.
Your Environment
Please tell us about your environment:

( x) I am using just the Node-RED package and got modbus-serial package installed with it
I do not have modbus-serial installed, nevertheless it works?

Yes, modbus-serial is the name but it does all, TCP and Serial.
The node-modbus package is just for the Modbus Server node.

Device :

(x) Linux: Kernel 5.10.11

Description of the connecting Modbus system:

Name: Solar inverter SMA SB3600SE
Vendor: SMA
Link: https://files.sma.de/downloads/SMA_Modbus-de-en_V25.zip, https://files.sma.de/downloads/SB5000SE-DEN1618-V11web.pdf

node-red-contrib-modbus version: 5.13.3

Node: (min. 10.x)
node --version = 14.15.1

Maybe someone from the community can test more with SMA here and give more hints and/ a PR.

Hi, same problem with SMA SB5.0, nothing in node-red debug or in docker logs.
Sometimes it takes some days to occur, something some hours...
Just need to restart flows, can't understand what is wrong

With verbose on logs, I get:
nodered             | 6 Jan 19:42:59 - [info] Started flows
nodered             | 6 Jan 19:42:59 - [info] [mqtt-broker:mosquittodocker  cerebro] Connected to broker: mqtt://mosquitto:1883
nodered             | 10 Jan 00:30:43 - [warn] [modbus-flex-getter:SMA] Modbus Failure On State sending Get More About It By Logging
nodered             | 10 Jan 00:30:43 - [warn] [modbus-flex-getter:SMA] Modbus Failure On State sending Get More About It By Logging
nodered             | 10 Jan 00:30:43 - [warn] [modbus-flex-getter:SMA] Modbus Failure On State sending Get More About It By Logging
nodered             | 10 Jan 00:30:43 - [warn] [modbus-flex-getter:SMA] Modbus Failure On State sending Get More About It By Logging
nodered             | 10 Jan 00:30:43 - [warn] [modbus-flex-getter:SMA] Modbus Failure On State sending Get More About It By Logging
nodered             | 10 Jan 00:30:43 - [warn] [modbus-flex-getter:SMA] Modbus Failure On State sending Get More About It By Logging
nodered             | 10 Jan 00:30:43 - [warn] [modbus-flex-getter:SMA] Modbus Failure On State sending Get More About It By Logging
nodered             | 10 Jan 00:30:43 - [warn] [modbus-flex-getter:SMA] Modbus Failure On State sending Get More About It By Logging
nodered             | 10 Jan 00:30:43 - [warn] [modbus-flex-getter:SMA] Modbus Failure On State sending Get More About It By Logging
nodered             | 10 Jan 00:30:43 - [warn] [modbus-flex-getter:SMA] Modbus Failure On State sending Get More About It By Logging
nodered             | 10 Jan 00:30:43 - [warn] [modbus-flex-getter:SMA] Modbus Failure On State sending Get More About It By Logging
nodered             | 10 Jan 00:30:43 - [warn] [modbus-flex-getter:SMA] Modbus Failure On State sending Get More About It By Logging
nodered             | 10 Jan 00:30:43 - [error] [modbus-flex-getter:SMA] Timed out
nodered             | 10 Jan 00:31:12 - [warn] [modbus-flex-getter:SMA] Modbus Failure On State sending Get More About It By Logging
nodered             | 10 Jan 00:31:12 - [warn] [modbus-flex-getter:SMA] Modbus Failure On State sending Get More About It By Logging
nodered             | 10 Jan 00:31:12 - [warn] [modbus-flex-getter:SMA] Modbus Failure On State sending Get More About It By Logging
nodered             | 10 Jan 00:31:12 - [warn] [modbus-flex-getter:SMA] Modbus Failure On State sending Get More About It By Logging
nodered             | 10 Jan 00:31:12 - [warn] [modbus-flex-getter:SMA] Modbus Failure On State sending Get More About It By Logging
nodered             | 10 Jan 00:31:12 - [warn] [modbus-flex-getter:SMA] Modbus Failure On State sending Get More About It By Logging
nodered             | 10 Jan 00:31:12 - [warn] [modbus-flex-getter:SMA] Modbus Failure On State sending Get More About It By Logging
nodered             | 10 Jan 00:31:12 - [warn] [modbus-flex-getter:SMA] Modbus Failure On State sending Get More About It By Logging
nodered             | 10 Jan 00:31:12 - [warn] [modbus-flex-getter:SMA] Modbus Failure On State sending Get More About It By Logging
nodered             | 10 Jan 00:31:12 - [warn] [modbus-flex-getter:SMA] Modbus Failure On State sending Get More About It By Logging
nodered             | 10 Jan 00:31:12 - [warn] [modbus-flex-getter:SMA] Modbus Failure On State sending Get More About It By Logging
nodered             | 10 Jan 00:31:12 - [warn] [modbus-flex-getter:SMA] Modbus Failure On State sending Get More About It By Logging
nodered             | 10 Jan 00:31:12 - [error] [modbus-flex-getter:SMA] Port Not Open
nodered             | 10 Jan 00:31:42 - [error] [modbus-flex-getter:SMA] Error: Client Not Ready To Read At State init

nodered             | 10 Jan 11:58:00 - [error] [modbus-flex-getter:SMA] Error: Client Not Ready To Read At State init
nodered             | 10 Jan 11:58:14 - [error] [modbus-flex-getter:SMA] Error: Client Not Ready To Read At State init
nodered             | 10 Jan 11:58:44 - [error] [modbus-flex-getter:SMA] Error: Client Not Ready To Read At State init
nodered             | 10 Jan 11:59:11 - [info] Stopping flows
nodered             | 10 Jan 11:59:11 - [info] Stopped flows
nodered             | 10 Jan 11:59:11 - [info] Starting flows
nodered             | 10 Jan 11:59:11 - [info] Started flows

SMA Inverters goes in sleep mode the night and shutdown network interface, could it generate this problem?
Why modbus-flex-getter doesn't re connect or reset connection?
Yoann

Have you checked, if the 'Reconnect on timeout' Checkbox is active in the Server Configuration?

My configuration below, sometimes it stop after 2 or 3 days, sometimes one week.
I may try to make a .pcap and look at the failure in tcp flow. But I think that the root cause is the SMA sleep mode every nights, maybe the reconnect can expire after few tries? But why this is a nonsense when it keep working few days.


Fix a typo

How embarrassing! Thanks for the fix!

  Thanks for making this great software!


Custom parsing logic inside decoding method

I'm trying to add custom parsing logic to init(from:) method, and my nested model depends on a property "above" it. You can see this in the response:
{
    "id": "12345",
    "time_zone": "Europe/Berlin", // need to use this when parsing `regular_hours` so that I can figure out proper dates/times...
    "opening_times": {
        "twentyfourseven": false,
        "regular_hours": [
            {
                "weekday": 6,
                "period_begin": "08:00",
                "period_end": "02:00"
            },
            {
                "weekday": 5,
                "period_begin": "08:00",
                "period_end": "02:00"
            }
        ]
    }
}

And I want to achieve something like this:
public struct LocationDetails: Decodable {
    public let id: String
    public let timeZone: TimeZone
    private let regularHours: [RegularHours]

    private enum CodingKeys: String, CodingKey {
        case id
        case timeZone = "time_zone"
        case regularHours = "regular_hours"
        case openingTimes = "opening_times"
    }

    public init(from decoder: any Decoder) throws {
        let container = try decoder.container(keyedBy: CodingKeys.self)

        self.id = try container.decode(String.self, forKey: CodingKeys.id)
        self.timeZone = try ValueCoder<TimeZone>().decode(from: container, forKey: CodingKeys.timeZone)

        if let openingTimes_container = try? container.nestedContainer(keyedBy: CodingKeys.self, forKey: CodingKeys.openingTimes) {
            do {
                let hours = try openingTimes_container.decode([RegularHoursDto].self, forKey: CodingKeys.regularHours)

                // Parsing logic
                let calendar = Calendar.iso8601
                let today = Date()
                let todayIndex = today.weekday(from: calendar)
                let todayComponents = calendar.dateComponents([.year, .month, .day], from: today)

                let tz = timeZone

                self.regularHours = hours.map {
                    // Parsing logic...
                    let beginDateComponents = DateComponents(timeZone: tz, ...)
                    let endDateComponents = DateComponents(timeZone: tz, ...)

                    return RegularHours(beginDate: calendar.date(from: beginDateComponents)!,
                                            endDate: calendar.date(from: endDateComponents)!,
                                            timezone: tz)
                }
            } catch {
                self.regularHours = []
            }
        } else {
            self.regularHours = []
        }

    }
}

public struct RegularHours {
    public let beginDate: Date
    public let endDate: Date
    public let timezone: TimeZone // Not in this object, but one level above it
}

public struct RegularHoursDto: Decodable {
    public let weekday: Int
    public let periodBegin: String
    public let periodEnd: String

    private enum CodingKeys: String, CodingKey {
        case weekday
        case periodBegin = "period_begin"
        case periodEnd = "period_end"
    }

    public init(from decoder: any Decoder) throws {
        let container = try decoder.container(keyedBy: CodingKeys.self)
        self.weekday = try container.decode(Int.self, forKey: CodingKeys.weekday)
        self.periodBegin = try container.decode(String.self, forKey: CodingKeys.periodBegin)
        self.periodEnd = try container.decode(String.self, forKey: CodingKeys.periodEnd)
    }
}

Is there a way to do something like this with pre-defined macros?
Thanks!

From what you are describing I think it can be achievable with HelperCoder functionality, have you looked into this?
I think places like StackOverflow or Swift Forums etc. will. be better for such questions as you will get wider audience, and somebody might have already achieved what you are expecting.


[Pager] Napier dependency in production classpath

This is not really a bug, more a possible improvement.
With the removal of Android specific APIs in #402 Nappier was introduced solely for (hardcoded?) debug-logging in the pager library.
This in the ends effects the consumers release artifacts and Napier gets shipped for basically no reason. The raw size increase is only 24KB (without minification) but still this feels some kind of unnecessary.
Maybe it is possible to come up with an other logging approach or add a separate build type.

Duplicate of #732. Unfortunately there is no progress.


Add the steepness constant to the parameters of the skyMaterial

It will be useful to add the steepness parameter to get a more realistic skyMaterial because if we look at the sun, the sky behind the camera is too dark.
Here's the forum discussion :
https://forum.babylonjs.com/t/skybox-environment/54107/8

We do not create issue until we actually work on them. Please use the feature request on the forum so users can vote:)


Propose: improving if statement with multiline conditions

Report a bug
Input and also Expected Behavior
The end of multi-line conditions ) then should be outdented in the next line to be at the same indentation level as if (.
if (
    long_condition_1
    or long_condition_2
) then
    x <= '1';
else
    x <= '0';
end if;

Actual Behavior
The end of multi-line conditions ) then is indented at the same level of conditions and also statements in the if body.
if (
    long_condition_1
    or long_condition_2
    ) then  -- should not be indented
    x <= '1';
else
    x <= '0';
end if;

In general, if some parenthesis or bracket is opened at some line, but closed at other line, The closing line should be at the same indentation level of the opening line. The content between these lines should indented one level.


Update threeGenerator.js

adding and editing comments
Note 'three.js' is usually written all lower case. See threejs.org
colorsDefault is tricky. It's a gbXML thing not a three.js thing. but is needed to make these scripts run. must think about this.

Any updates on this @theo-armour ?


Frontend Documentation

We need to have documentation for the Frontend, to have an easier time developing in the future

Initiated by #112


Doc: typo

Looks like a copy-paste bug - these lines probably should be different:
https://github.com/jdx/mise/blob/0192a4191afb939b2beb87ff2fc179584154cabf/settings.toml#L681-L682

Another one (missing mise.{MISE_ENV}.local.toml):
https://github.com/jdx/mise/blob/0192a4191afb939b2beb87ff2fc179584154cabf/docs/profiles.md?plain=1#L41-L44

One more (probably should be "because virtually no one is using it"):
https://github.com/jdx/mise/blob/0192a4191afb939b2beb87ff2fc179584154cabf/docs/direnv.md?plain=1#L34

BTW, I'd like to say "thank you"! The tool is really amazing and the docs is great!

Duplicate "for for":
https://github.com/jdx/mise/blob/0192a4191afb939b2beb87ff2fc179584154cabf/settings.toml#L220-L221

Should be [config_root] | ...:
https://github.com/jdx/mise/blob/aeb5dfeab4d3e6ca5545ba53ad2f8e71ecced0be/docs/templates.md?plain=1#L244

This example does not compile:
https://github.com/jdx/mise/blob/aeb5dfeab4d3e6ca5545ba53ad2f8e71ecced0be/docs/templates.md?plain=1#L282

dir does not allow templates:
https://github.com/jdx/mise/blob/36a19f87b80aafb15f33dd818f3a4b4a0277c295/docs/tasks/toml-tasks.md?plain=1#L25

Shebang in run= has no effect, but using it in example creates impression it will work:
https://github.com/jdx/mise/blob/36a19f87b80aafb15f33dd818f3a4b4a0277c295/docs/tasks/toml-tasks.md?plain=1#L33-L36


Multiple data columns

Hi Nicolas,
Do you think it would be possible to change the library to include the possibility of append more than one column of results?
For example, if you have a report with serveral units, show the sum of one value and the average of another at the same time.
Maybe, instead with a select input to set the column data and another to the aggregator, make like a draggable area where you can drop the columns and for each one select the function...

I know it's a big request, but I think it will take the library to the next level.
Thanks for your time,
Regards

Thanks for the feedback! This is an oft-requested feature but it really is a big change and I'm not planning on implementing it any time soon :)


Network errors when fetching dependencies via gradle turn into a massive spew of unclear text.

Consider for example: https://cirrus-ci.com/task/6022315478614016?logs=main#L205
Ideally, this should have resulted in one of the following:
Either something like the following (for non-fatal network errors, solved by retrying with jittered truncated exponential backoff until it works):
Running Gradle task 'assembleRelease'...
There are network issues attempting to contact jcenter.bintray.com, please stand by...
Issues resolved by retrying!
Running Gradle task 'assembleRelease'...                         1925.2s

...or something like the following (for fatal errors, where retrying forever is deemed a bad idea):
Running Gradle task 'assembleRelease'...
There are network issues attempting to contact jcenter.bintray.com, please stand by...
Could not obtain the following resource:
https://jcenter.bintray.com/io/flutter/armeabi_v7a_debug/1.0.0-f0826da7ef2d301eb8f4ead91aaf026aa2b52881/armeabi_v7a_debug-1.0.0-f0826da7ef2d301eb8f4ead91aaf026aa2b52881.pom
The server responded with "502 Bad Gateway".

Instead here is what we get:
FAILURE: Build failed with an exception.
* What went wrong:
Could not determine the dependencies of task ':app:lintVitalRelease'.
> Could not resolve all artifacts for configuration ':app:releaseRuntimeClasspath'.
   > Could not resolve io.flutter:armeabi_v7a_release:1.0.0-f0826da7ef2d301eb8f4ead91aaf026aa2b52881.
     Required by:
         project :app
      > Could not resolve io.flutter:armeabi_v7a_release:1.0.0-f0826da7ef2d301eb8f4ead91aaf026aa2b52881.
         > Could not get resource 'https://jcenter.bintray.com/io/flutter/armeabi_v7a_release/1.0.0-f0826da7ef2d301eb8f4ead91aaf026aa2b52881/armeabi_v7a_release-1.0.0-f0826da7ef2d301eb8f4ead91aaf026aa2b52881.pom'.
            > Could not HEAD 'https://jcenter.bintray.com/io/flutter/armeabi_v7a_release/1.0.0-f0826da7ef2d301eb8f4ead91aaf026aa2b52881/armeabi_v7a_release-1.0.0-f0826da7ef2d301eb8f4ead91aaf026aa2b52881.pom'.
               > Read timed out
   > Could not resolve io.flutter:arm64_v8a_release:1.0.0-f0826da7ef2d301eb8f4ead91aaf026aa2b52881.
     Required by:
         project :app
      > Could not resolve io.flutter:arm64_v8a_release:1.0.0-f0826da7ef2d301eb8f4ead91aaf026aa2b52881.
         > Could not get resource 'https://jcenter.bintray.com/io/flutter/arm64_v8a_release/1.0.0-f0826da7ef2d301eb8f4ead91aaf026aa2b52881/arm64_v8a_release-1.0.0-f0826da7ef2d301eb8f4ead91aaf026aa2b52881.pom'.
            > Could not HEAD 'https://jcenter.bintray.com/io/flutter/arm64_v8a_release/1.0.0-f0826da7ef2d301eb8f4ead91aaf026aa2b52881/arm64_v8a_release-1.0.0-f0826da7ef2d301eb8f4ead91aaf026aa2b52881.pom'.
               > Read timed out
* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.
* Get more help at https://help.gradle.org
BUILD FAILED in 3m 34s
[!] Gradle threw an error while downloading artifacts from the network. Retrying to download...
FAILURE: Build failed with an exception.
* What went wrong:
Could not determine the dependencies of task ':app:lintVitalRelease'.
> Could not resolve all artifacts for configuration ':app:debugRuntimeClasspath'.
   > Could not resolve io.flutter:armeabi_v7a_debug:1.0.0-f0826da7ef2d301eb8f4ead91aaf026aa2b52881.
     Required by:
         project :app
      > Could not resolve io.flutter:armeabi_v7a_debug:1.0.0-f0826da7ef2d301eb8f4ead91aaf026aa2b52881.
         > Could not get resource 'https://jcenter.bintray.com/io/flutter/armeabi_v7a_debug/1.0.0-f0826da7ef2d301eb8f4ead91aaf026aa2b52881/armeabi_v7a_debug-1.0.0-f0826da7ef2d301eb8f4ead91aaf026aa2b52881.pom'.
            > Could not GET 'https://jcenter.bintray.com/io/flutter/armeabi_v7a_debug/1.0.0-f0826da7ef2d301eb8f4ead91aaf026aa2b52881/armeabi_v7a_debug-1.0.0-f0826da7ef2d301eb8f4ead91aaf026aa2b52881.pom'. Received status code 502 from server: Bad Gateway
* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.
* Get more help at https://help.gradle.org
BUILD FAILED in 1m 59s
[!] Gradle threw an error while downloading artifacts from the network. Retrying to download...
Gradle task assembleRelease failed with exit code 1

@Hixie This is potentially doable with a custom Logger. https://docs.gradle.org/current/userguide/logging.html#sec:changing_what_gradle_logs
Note that the Dart side relies on stderr patterns to retry the build.  If these are filtered at the Gradle level, some new pattern must be introduced.

Oh nice, if we can override the logger output maybe we can make it so when it detects flutter is running it always output something machine-parseable and then the actual output can be done by the flutter tool itself.


Fix incorrect 2.0 reference to AuthenticationOptions

Fixes https://github.com/aspnet/Docs/issues/4630
Internal Review Page

@Tratcher or @HaoK Please review.


add extended resources support to kubermark machine

In kubernetes 1.22.0+, kubemark has support for specifying the resources
for the hollow node using the --extended-resources command line flag.
This pull request adds new fields to the KubemarkMachineTemplate CRD
which allows users to customize the resources that their hollow nodes
advertise.
Additionally, this change will create a new default standard for all
hollow nodes of 1 cpu and 4G memory. These can be overridden by adding
custom values to the KubemarkMachineTemplate.
This example demonstrates how to specify the cpu and memory for a hollow
node which will have 32 cpu and 128G memory:
apiVersion: infrastructure.cluster.x-k8s.io/v1alpha4
kind: KubemarkMachineTemplate
metadata:
  labels:
    cluster.x-k8s.io/cluster-name: mycluster
  name: kubemark-big-machine
  namespace: default
spec:
  template:
    spec:
      kubemarkOptions:
        extendedResources:
          cpu: "32"
          memory: "128G"

The kubemarkOptions field is a new struct which is intended to wrap
command line flags for Kubemark. It only contains the
extendedResources field currently, but can be expanded with other
options in the future.
The extendedResources field is a map which can accept other values to
ensure that users have the maximum flexibility in adding resources.
Although cpu and memory are demonstrated here, a user could add gpu,
networking, or other resources.
Finally, this change updates the README with instructions about the
changes and adds unit tests for the new functions that have been added.

overall looks great! and kudos on the unit tests!
I just wonder if we can flatten the structure a bit, i.e.
apiVersion: infrastructure.cluster.x-k8s.io/v1alpha4
kind: KubemarkMachineTemplate
metadata:
  labels:
    cluster.x-k8s.io/cluster-name: mycluster
  name: kubemark-big-machine
  namespace: default
spec:
  extraMounts:
    ...
  extendedResources:
    cpu: "32"
    memory: "128G"

i think we could definitely flatten the structure. my original thought was to put all the options that are flags to kubemark into a single struct for convenience. then we could have top-level items in the spec for fields which control how the actuator itself behaves. but, if we don't think having that extra structure helps, i can certainly remove it. wdyt?

@elmiko I see that makes sense, planning for future additional options 👍

/lgtm

thanks @agradouski !


[Extension Feature Request] Todoist Create Task Menu Improvements

Extension – Todoist
Author: @thomaslombart

Describe the feature and the current behavior/state.
The Create Task menu stays as-is when a task is created. The form does clear, nor does it send you to a different page when it's submitted.
Will this change the current api? How?
I suggest that once the task is created the project view for the task's selected project should open. There can also be a CMD-k menu option that doesn't open the project view and instead creates the task and clears the form.
Who will benefit from this feature?
Anyone using the Todoist Raycast integration to add tasks.

Hey @thomaslombart!
Here is the new feature request to your extension, take a look at that and subscribe to don't miss anything related 😉

Thanks for letting me know. I'll take a look at it during the week! 🙂

@SmashMineGame Just wanted to let you know that I'm updating the Todoist extension with your requested features. I expect to create a new pull request by the end of the week 🙂


Example code in challenge causes tests to fail - Manipulate Arrays With shift()

Challenge Basic JavaScript - Manipulate Arrays With shift()
This challenge contains example code in code window. That example code causes the tests to fail.
Error message in console window pertaining to example code
removedFromOurArray is not defined
Line 3 is
removedFromOurArray = ourArray.shift();
problem resolved by changing line 3 to
var removedFromOurArray = ourArray.shift();
Add a Link to the page with the problem
https://learn.freecodecamp.org/javascript-algorithms-and-data-structures/basic-javascript/manipulate-arrays-with-shift/
Also, from the forum
https://forum.freecodecamp.org/t/bug-on-manipulate-arrays-with-shift/195248
Tell us about your browser and operating system

Browser Name: Chrome
Browser Version: Version 66.0.3359.181 (Official Build) (64-bit)
Operating System: Ubuntu 16.04

If possible, add a screenshot here

Duplicate of #17287

Oops - did not see duplicate. Closing this one.


DS-590 Switch button component

Jira
https://pegadigitalit.atlassian.net/browse/DS-590
Summary
Adds a new component, Switch Button, which handles boolean UI functions that happens instantly.
Details

Added new component, Jest test and docs.
Only bare minimum props are created to handle basic needs for the notifications project. We can expand on this component down the road.

How to test
Run the branch locally and proof read the Switch Button docs. Make sure the docs are intuitive. Inspect the demo and change on/off to some other language that might be longer, make sure it looks ok. Then check the component code for any mistakes in the code.

Refer to the previous PR for conversations and approvals, https://github.com/boltdesignsystem/bolt/pull/2356


Enable restore of repeat (or circular) references

/cc @zalmoxisus, not sure if this sort of thing is actually useful to you? Do you have a quick screenshot of how you are rendering the results or is it purely visual (E.g. like JSON)?
Edit: If it's not particularly useful, I'll hide it behind a flag and make it a minor release.

Coverage decreased (-0.5%) to 96.078% when pulling 138bd288f80bd27d6e8df10684e1524859c32144 on circular-references into 28ea3edd082d88fb023bd97e54a72816eb153526 on master.

In case of autogenerating tests it would be quite useful, but for redux-devtools-inspector it is used for showing diffs, and it's ok to strip circular references (but transforming the next object into a function would be confusing). I guess hiding under a flag would be better, as it will not be a breaking change.


eth-abi

Tell me you wrote that the problem was fixed, but dependencies still have the version "eth-abi> = 2.0.0b6, <3.0.0" and it turns python-api out does not work with web3
ModuleNotFoundError: No module named 'eth_abi.codec'

We will retest and report the results.

Yes there is a problem
But tronapi is already transferred to the new version.
eth-abi>=2.0.0b6,<3.0.0


WebRTC is not supported by this browser

This is the error i got while try to use it in react native

You need to enable some poly fills in your app for it to work properly, if I remember correctly. I'll create some docs soon with better instructions.

@dukizwe Take a look at the polyfills logic. You'll need this to get Artico working on an Expo app.
https://github.com/matallui/artico/blob/main/apps/demo-expo/components/polyfills.ts


Check windowSoftInputMode and throw on registration

hi @yshrsmz
Can you tell me why this is required? Do you have any specific scenario where it will be required?

As KeyboardVisibilityEvent can only work with specifiy windowSoftInputModes, I thought it would be nice if the library notifies user about this limitation.

Got it. If the WindowSoftInputMode is something like adjustNothing or adjustPan which will not resize the root layout, then throw an exception like IllegalStateException or something right?

Yes, that is the plan ;)

I hope this can be closed now

yes, thanks for your contribution!


Myaccount redirection is failing after a successful password set by suborg user

Describe the issue:

Configure [output_adapter.email] in deployment toml
Login to the Console and create a suborg
Switch to the suborg
Create a user inviting user to set the password
Accept the invite by the user, set the password.
The user will see myaccount link to redirect. Click on that. My account access will be failed with following error

The working API is this pattern
https://localhost:9443/t/carbon.super/o/286f1979-cb42-4f13-8e00-6092fb57f0c5/myaccount

https://github.com/wso2/product-is/assets/25483865/5c97a610-e072-49c2-ae06-210844caed32
Need to fix org qualified my account redirection in user invite flows, password reset flows etc in suborgs

can be fixed by allowing o/<org id> path for myaccount via OrgContextsToRewrite config


New package: PLACE.IA.SING version 2.0.0

Checklist for Pull Requests

[ ] Have you signed the Contributor License Agreement?
[ ] Is there a linked Issue?

Manifests

[ ] Have you checked that there aren't other open pull requests for the same manifest update/change?
[ ] This PR only modifies one (1) manifest
[ ] Have you validated your manifest locally with winget validate --manifest <path>?
[ ] Have you tested your manifest locally with winget install --manifest <path>?
[ ] Does your manifest conform to the 1.6 schema?

Note: <path> is the directory's name containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow
Microsoft Reviewers: Open in CodeFlow

Verify:


Fix for issue 2729: Implemented a wrapper class to ensure the footer is near the bottom of the page.

Put div wrapper in:

content.html.erb
assignment_content.html.erb
Added styling in:
_core.scss to ids: loggedIn and wrapper
footer: placed top border for footer here

@b2simms this appears to be the wrong commit.


Angular 4?

Is there an angular4 version available ?

Just noticed from the closed issues that the answer is no  :-(

Correct. I'm not an Angular user anymore. Contributions are welcome and I'd be happy to support someone who wants to work on a rewrite for what is now essentially a different framework. The real value is in the DOM-independent validation which I actively maintain for anyone who wishes to continue building framework-specific tooling.


How to specify the covalent bond between ligand and residue

Hello,
It is not unclear for me how to specify the option covalent bond between 2 atoms. I am not sure what to specify in RotAtom
'RotAtomA:ligand_resnum1:LigAtomA,theozyme_resnum:RotAtomB:ligand_resnum2:LigAtomB'
Let's say I have a covalent bond between  atom NZ of LYS185 and atom C3 of ligand A300,
Should I put  'A300:C3,A185:NZ' ?

Hi,
did you pull the newest version of the identify_fragments.py script? The description in the old one was incorrect, sorry. I hope the new explanation is a bit better now.
The residue information has to be first, then the ligand. In your case, it would be 'A185-NZ:A300-C3' (assuming LYS185 is on chain A). Additional covalent bonds should be separated with ,
Hope that helps!
Cheers
Adrian

Thank you for your help. I just pulled the newest version. It worked.


ENH: Support for non-compliant DICOM in itk-js

Adds support for non-compliant DICOM headers (but otherwise readable files) in Javascript (itk-js).
This PR aligns the GDCM IO behavior in Javascript with the one in C++ or Python.
A custom build with this works just fine for me.
Are there any other pending reasons for this stricter behavior only in js?

PR Checklist

[x] No API changes were made (or the changes have been approved)
[x] No major design changes were made (or the changes have been approved)
[ ] Added test (or behavior not changed)
[ ] Updated API documentation (or API not changed)
[ ] Added license to new files (if any)
[ ] Added Python wrapping to new files (if any) as described in ITK Software Guide Section 9.5
[ ] Added ITK examples for all new major features (if any)

Refer to the ITK Software Guide for
further development details if necessary.

Using git's blame feature, it is easy to figure out 6322422d82e215e39057ac93ae662c730675743e added that. It was done in PR #423.

Thanks for the pointer, @dzenanz.
I agree that this was clearly useful when DCMTK is used as the IO for DICOMs:
https://github.com/InsightSoftwareConsortium/ITK/pull/423#issuecomment-455284890
GDCM has already been made the default IO for DICOMs in itk-js here:
https://github.com/InsightSoftwareConsortium/itk-js/pull/316
So maybe the original constraint does not apply anymore?

maybe the original constraint does not apply anymore

Maybe, but Matt should decide.

@jmargeta thanks for the patch!
To confirm, you re-built the itk.js Docker images with this branch, ran the test suite, and everything passed?

@thewtex, yup, almost like that.
To be sure my custom Docker images are used I also changed all the "FROM"s in the itk-base, itk-js, and itk-js-vtk docker images and all the references in the build files to point to our Docker registry.
The difference from this PR is that instead of deleting the && !defined(__EMSCRIPTEN__) I replaced it with !defined(__IGNORETHISDEF__) just after the git checkout step in the itk-base's Dockerfile:
RUN git clone https://github.com/InsightSoftwareConsortium/ITK.git && \
  cd ITK && \
  git checkout ${ITK_GIT_TAG} && \
  cd ../ && \
  sed -i -e 's/__EMSCRIPTEN__/__IGNORETHISDEF__/' /ITK/Modules/IO/GDCM/src/itkGDCMImageIO.cxx && \
  sed -i -e '/^option(OPJ_USE_THREAD/c\option(OPJ_USE_THREAD "use threads" OFF)' \
...

Based on the DICOMSeriesTest.js I also added a new test with the non-compliant DICOM series (composed of two files).
Running npm build and then npm run test:browser passes fine.
When I now re-run the test suite with the npm run test,  I am getting:
  9 tests failed

  runPipelineNodeSyncTest › runPipelineNodeSync uses input and output files in the Emscripten filesystem

  dist/runPipelineEmscripten.js:32

   31:   };
   32:   var stream = emscriptenModule.open(path, opts.flags);
   33:   var stat = emscriptenModule.stat(path);

  Error thrown in test:

  TypeError {
    message: 'emscriptenModule.open is not a function',
  }

  readFileSharedArray (dist/runPipelineEmscripten.js:32:33)
  dist/runPipelineEmscripten.js:145:36
  runPipelineEmscripten (dist/runPipelineEmscripten.js:130:13)
  runPipelineNodeSync (dist/runPipelineNodeSync.js:7:16)
  test/runPipelineNodeSyncTest.js:43:39
...

This is happening also for the clean build without the proposed changes and looks unrelated to this PR.
I would love to contribute the test and the sample data, but I cannot share the files as is.
Anonymizing the file fixes the headers, unfortunately.
Also a side note, I originally had the test DICOM files inside a .raw_dicom subfolder and was getting 404s from the test runner. This can be resolved by removing the dot.

Based on the DICOMSeriesTest.js I also added a new test with the non-compliant DICOM series (composed of two files).
Running npm build and then npm run test:browser passes fine.

Great!

message: 'emscriptenModule.open is not a function',

This is happening also for the clean build without the proposed changes and looks unrelated to this PR.

This is suggesting that your build may not be using your custom Docker images. open was added recently to the code that gets injected into the Emscripten module when built:
https://github.com/InsightSoftwareConsortium/itk-js/blob/61d3fe9099056eb21665a048b320ce81cd62471e/src/EmscriptenModule/itkJSPost.js#L89-L91
Are the kitware/itk-js-vtk:latest images rebuilt locally or was the build script changed to point to your images?
https://github.com/InsightSoftwareConsortium/itk-js/blob/61d3fe9099056eb21665a048b320ce81cd62471e/build.js#L55
https://github.com/InsightSoftwareConsortium/itk-js/blob/61d3fe9099056eb21665a048b320ce81cd62471e/build.js#L263
Also, I have noticed that Node 12 and Node 14 have build errors -- Node 10 may be required.

Thanks a lot for your response, @thewtex !
Everything should be pointing to our custom image names.
In the build files and in the Dockerfiles, I modified all the Docker image references from kitware/* and insighttoolkit/* to our container registry names  in the form of xyx.azurecr.io/*.
I rebuilt everything locally (including the images), from scratch, for several times already with the same errors.
It is possible that Docker has been re-using the cached versions without me noticing that or that I've just been doing something silly. Also I was on Node 14 originally, but a quick switch to 10 did not help..
I've just switched to Node v10.23.0 (npm v6.14.8) with nvm + removed all related Docker images (tagged and dangling) local  and from our custom container registry.
Now, I am rebuilding it all from scratch once again, my build sequence now boils down to this:
git clone  https://github.com/InsightSoftwareConsortium/itk-js.git
cd itk-js
nvm use v10.23.0
npm install
src/Docker/itk-js-base/build.sh
src/Docker/itk-js/build.sh
src/Docker/itk-js-vtk/build.sh
npm run build
npm run test

Is this a correct way to locally build and test itk-js from source?
I'll report the results here once it gets done.

Is this a correct way to locally build and test itk-js from source?

@jmargeta yes, perfect, thanks for testing!

I'll report the results here once it gets done.

How did it go?

@thewtex all tests seem to pass just fine now here including the change.
I just had to rebuilt it all from scratch on another PC which never had a chance to see those Docker images before.
The most likely cause for the failure on the original machine was that an incorrect image was indeed used for my subsequent builds. My partition reserved for Docker images got full (those builds are huge) and the latest images were either not being stored correctly or were evicted too early.

@jmargeta great, thanks for update and contribution!

CC @floryst @aylward

Fantastic, thank you @thewtex !


register global blaze loader in run_algorithm

The blaze loader exists to make it easy to register new pipeline datasets in zipline by reflecting information from various sources. We can automatically convert a tabular blaze expression (in a given format) to a Pipeline expression and register this with a pipeline loader (see zipline.pipeline.loaders.blaze.from_blaze; however, this loader is not registered by default so you cannot use these datasets in the cli or run_algorithm. I propose we register the zipline.pipeline.loaders.blaze.global_loader by default so that these can be used without major modification to zipline. If you want to register custom sub-loaders, you are an expert so this is not intended to help your workflow.
Does anyone have any objections?

Only concern I can think of is that this would make blaze and its dependencies required for zipline install, as opposed to optional installs. Am I understanding that correctly, and what are your thoughts?

Only concern I can think of is that this would make blaze and its dependencies required for zipline install, as opposed to optional installs.

I'd be okay with this if we could use stably-released versions from pypi instead of github commits.

Also, another option here would be to register the blaze loader if you have the appropriate dependencies installed.

I'd be okay with this if we could use stably-released versions from pypi instead of github commits.

Want to release blaze?

There is on-going discussion about the long-term plan for blaze in zipline.

At present, loading fundamentals data into zipline is quite complex as apparent here: #2163 . Having a registered-by-default blaze loader will definitely simplify things for an average trader who just wants to use the zipline api for backtesting, without having to modify the internals of zipline. Is there an update on this issue?


Change description on homepage

Currently, the short description on the MNE homepage says:
"Open-source Python software for exploring, visualizing, and analyzing human neurophysiological data: MEG, EEG, sEEG, ECoG, and more."
Maybe I'm too ignorant, but I don't even know what sEEG is (I always thought sEEG and ECoG are synonyms). Furthermore, NIRS support is probably more interesting for more users, so I'd change this sentence to:
"Open-source Python toolbox for exploring, visualizing, and analyzing human neurophysiological data: MEG, EEG, ECoG, NIRS, and more."
I'd also change "software" to "toolbox". WDYT?

Maybe I'm too ignorant, but I don't even know what sEEG is (I always
thought sEEG and ECoG are synonyms).

sEEG is stereotactic EEG (implanted electrodes). Sometime it's just called
iEEG
ECoG means a grid

Furthermore, NIRS support is probably more interesting for more users, so
I'd change this sentence to:

+1 to add NIRS

"Open-source Python toolbox for exploring, visualizing, and analyzing
human neurophysiological data: MEG, EEG, ECoG, NIRS, and more."
I'd also change "software" to "toolbox". WDYT?

I don't like much the word "toolbox" that reminds me of my matlab time :)
maybe package? But I prefer software
"Open-source Python software for exploring, visualizing, and analyzing
human neurophysiological data: MEG, EEG, sEEG, ECoG, NIRS, and more."
in our ch_type we have sEEG different from ECoG (due to my background on
forward model that is different)

Thanks for the clarification. Software is a very general term and it sounds awkward if you use it with an article, e.g. "MNE is a Python software" doesn't sound right and "MNE is Python software" sounds too generic, at least for me. Therefore, I'd prefer Python package, which is also the correct technical term for what MNE really is.
"Open-source Python package for exploring, visualizing, and analyzing
human neurophysiological data: MEG, EEG, sEEG, ECoG, NIRS, and more."
?

deal for me

LGTM


Camel case

Transformation to lower camel case does not work if your first character is upper case.
e. g. Camel("NotAwesome",false) returns "NotAwesome" instead of "notAwesome".

Thanks for reporting this.  I'm taking a look now.

The behavior you're suggesting does seem more reasonable to me.

Fixed by https://github.com/codemodus/kace/commit/0a773928521401fcc9783008d4f0f481dcc8601c


disable snow plow in China

I think snow plow is not used in China.
Disable it to avoid suddenly access slow issue.

@wjllance is this still good to merge in?

Maybe no need to merge, we plan to just remove tracker's code directly in china production branch, there seems many code relate to tracker, it's hard to use that under the feature flag.
We might close this PR

Closing, have https://github.com/codecombat/codecombat/pull/6049 now.


"resource" folder name

Hi!
I've just installed the package and after I run the publish command, it created a "resource" folder in app root. At the same level, Laravel uses another folder named "resources". Isn't it better to generate the packages "resource" contents in Laravel's default "resources" folder?
for example:
        $this->publishes([
            __DIR__ . '/views' => base_path('resource/views/vendor/composer-security-check'),
        ]);

becomes:
        $this->publishes([
            __DIR__ . '/views' => base_path('resources/views/vendor/composer-security-check'),
        ]);

Btw, great package!
Thank you

Hi peter,
you're right, the choice of the name of the folder was an oversight.
I correct the package as soon as possible.
thanks for the tip!


⚠ Bofrost.be has degraded performance

In 5014cfe, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 1262 ms

Resolved: Bofrost.be performance has improved in 522e515.


DefaultPreferences.plist update & suggested Settings.xib tweaks

Updated DefaultPreferences.plist to change to more common default settings and added entries for Exclude List sub-options*
Added sub-options to Exclude List to add granularity and better inform the user what type of files and subfolders are excluded; tweaked wording
Tweaked wording and standardized font styles in Advanced panel

* I expect CZExcludeHidden would be remapped to "Exclude hidden file and subfolders" for clarity. Wasn't sure whether to add another key for the parent exclude setting or whether you handle it similar to the parent checkbox on user notification.

I'll connect the added settings in my next build. Thanks.


ETL pipeline for kedro PyPI downloads: unreliable data source and alternatives

We have set up an ETL pipeline to process Kedro PyPI downloads data and store it in our internal Snowflake space, as described in #145 . This pipeline operates as a GitHub Action, running the Kedro project daily in our internal repository: kedro-pypi-to-snowflake.
Challenges Faced
Approximately 1.5 months ago, an issue #154  arose when the data source changed. It became possible to query only one specific date per request, instead of reading the entire dataset. To address this, we modified the Kedro project to implement an incremental approach, allowing us to process data day-by-day effectively.
As of 2024-11-25, the data source has started returning completely empty responses. This new problem renders our current data source unreliable.
Proposed Solutions

Investigate Current Data Source - explore the reasons behind the empty responses to determine if the issue can be resolved.

Switch to Raw PyPI Dataset in BigQuery  as an alternative data source. Details can be found here.

For some reason, our data source clickpy.clickhouse.com stopped updating its views as of 2024-11-24. This issue is also visible on their dashboards.

Currently, the only option seems to be switching to Raw BigQuery. What do you think, @astrojuanlu?

Thanks for the investigation @DimedS. Please open an issue in https://github.com/ClickHouse/clickpy/issues/, and in parallel I agree, let's finally switch to BigQuery.

Issue created: https://github.com/ClickHouse/clickpy/issues/106
Will start work on moving to BigQuery

Moved PyPI Downloads ETL data source to a raw BigQuery table

Data is now transferred to two tables in our Snowflake storage:

KEDRO_BI_DB.PYPI.AGGREGATED_DOWNLOADS: Maintains the same format as before.
KEDRO_BI_DB.PYPI.AGGREGATED_DOWNLOADS_EXT: Includes additional aggregates such as country, operating system, CI flag, and cloud platform name (if provided).

To query BigQuery, I created a sandbox account on platform.mckinsey. I used my credentials to configure GHA secrets in our internal repository.

Updated the code in our internal repository: https://github.com/McK-Internal/kedro-pypi-to-snowflake. Additionally, I set up GitHub Actions to fully reload both tables daily at 6 a.m.

@astrojuanlu , could you please review the dashboards and confirm that everything looks good?

From the looks of it, this is working now! Thanks @DimedS, closing


Does tensor's label must be an identifier or integer?

When I was using vespa-http-client to feed data, I got following errors:
Failure: Result for 'id:duokan:item::359587
1530176248947 Trace starting
1530176249828 Asked about retrying for cluster ID 0, number of retries is 1 Detail:
Detail resultType=FATAL_ERRORexception='Error in document 'id:duokan:item::359587' - could not parse field 'read_location' of type 'tensor(x{})': label must be an identifier or integer, not '中爪哇省': label must be an identifier or integer, not '中爪哇省'' endpoint=localhost:8080 ssl=false resultTimeLocally=1530176249828
1530176249828 Got detail: Detail resultType=FATAL_ERRORexception='Error in document 'id:duokan:item::359587' - could not parse field 'read_location' of type 'tensor(x{})': label must be an identifier or integer, not '中爪哇省': label must be an identifier or integer, not '中爪哇省'' endpoint=localhost:8080 ssl=false resultTimeLocally=1530176249828

Hello guys,
In the previous version of vespa, it allows us to using string to be tensor's label. However, after I update vespa to version 6.252.3-1, string doesn't work.

Yes, but it's just a validation check. I don't think there's any major drawback to allowing all unicode word characters and not just [a-zA-Z0-9_]. I'll make that change if you think it is useful.

If it's just a validation check. I could change it by myself.
Thanks!


only support Ruby 2.4 and 2.5

It is really a pain not being able to use new Ruby methods because of supporting old Ruby versions. Our code is getting outdated because of that. I would suggest that we get rid or Ruby 2.0-2.3, keep supporting Ruby 2.4 and start supporting Ruby 2.5.

@abargnesi what do you think?

Now with Ruby 2.2 not longer supported, I think this makes even more sense... @abargnesi something against this?

I guess no answer is also an answer :stuck_out_tongue_closed_eyes:


Add support for ARM i.MX 8MQuad Evaluation Kit board

Adding initial i.MX 8M family support.
For i.MX 8M family platforms, there are several options for booting os. It all depends on what the particular board supports. For example: my board (imx8mq_evk) can only boot from emmc or sdcard, other boards may have support for booting from QSPI flash internal memory or usb.
Official boards of the i.MX 8M family are loaded according to this principle: the board has a physical switch that can control which device will be loaded from (emmc, sdcard, qspi, usb). After that, bootloaders are loaded from the boot device, in this order:
uboot-spl -> TF-A -> u-boot
This boot chain is compiled into a single blob using the binman utility in u-boot. This blob we need to write to sdcard, or emmc with 33KB offset. All instructions as proof for my board here, the same rule applies to emmc boot, but we need to use uuu (utility) for writing this blob via SDP(Serial Download Protocol) and fastboot implementation in uboot.
For NXP i.MX 8MQuad Evaluation Kit (EVK) my chosed boot flow looks like:
u-boot-spl(sdcard) -> TF-A(sdcard) -> u-boot(sdcard) -> grub(sdcard) -> EVE-OS kernel(sdcard)
Tasks and problems:

i.MX8 family boards has a different boot blobs, but load this boot blob from boot device with 33k offset.
We need to upstream kernel drivers from BSP or 6.0 kernel.

Added:

Kernel patches with upstream changes for PCIE and FEC Ethernet drivers (from kernel 6.0).
Kernel dts patches with upstream changes for PCIE and FEC Ethernet drivers (adapt from bsp kernel).
How to use on i.MX8MQuad EVK board.
New pkg/bsp-imx for building boot blob for nxp i.MX8 family
New live-raw-imx8mq target in Makefile
New -p flag in pkg/eve entry point script for platform targeting.

Summary:
Now we can boot live raw EVE image from sdcard and work with eve on i.MX 8MQuad EVK board.
OK: emmc1(sdcard), pci0, eth0, usb, video(hdmi, efifb/simple-fb)
Not work(I think to do it in other PR.): usb type-c, wifi, xen, optee

I tested that my changes did not affect the x86 and standard arm64 build in any way, and that EVE-OS runs on an i.MX 8MQuad EVK board and passes all workflow tests, but with edits to the amount of RAM for instances in the eclient/profile test, because on my board 3GB are available to the system, and this is not enough.

Rebased after changes in pkg/alpine https://github.com/lf-edge/eve/pull/2962.

Seems we have new changes that break the build with
# syntax=docker/dockerfile-upstream:master-labs
in bsp-imx pkg
https://github.com/lf-edge/eve/actions/runs/3699742814
lets use
# syntax=docker/dockerfile-upstream:1.5.0-rc1-labs
this tag without problems.
I think we might have problems building packages where we use # syntax=docker/dockerfile-upstream:master-labs

Which devices are supported by this PR: PCIe, Ethernet and USB only? What about CAN? And the Cortex M? In phytec's bsp I saw some code to initialize the Cortex M in drivers/soc/imx/soc-imx8.c, but here it's not clear to me if the Cortex M is being initialized... Actually I'm interested to know which devices are still missing support, so if you could give more details about which devices are supported in the commit message with the kernel patches would be great...

My board not have CAN and Cortex M core.

What are the advantages to use the binman approach? I'm building the u-boot + atf + optee-os standalone and just flashing it to the final EVE image (with the proper offset). By enabling UEFI boot in u-boot, we can boot EVE in the same way as done in RPi...

Because binman does the same thing that imx8-mkimage does, but not as flexible. And we don’t need flexibility, we choose what we will have in the image, the user cannot influence it.

Which devices are supported by this PR: PCIe, Ethernet and USB only? What about CAN? And the Cortex M? In phytec's bsp I saw some code to initialize the Cortex M in drivers/soc/imx/soc-imx8.c, but here it's not clear to me if the Cortex M is being initialized... Actually I'm interested to know which devices are still missing support, so if you could give more details about which devices are supported in the commit message with the kernel patches would be great...

My board not have CAN and Cortex M core.
Cortex M is part of the SoC. I thought you were working with i.MX8MP, but now I see your board has a i.MX8MQ, that's not a big deal, SoCs are still of the same family. Apart from the cortex A53, the i.MX8MP has a Cortex M7 and the i.MX8MQ has a Cortex M4. I was just wondering because it might be required in the future, so no problems for now if it's not being enabled (not urgent). The same for CAN bus (this one might be required earlier), that's why I would like to be sure about the support...

What are the advantages to use the binman approach? I'm building the u-boot + atf + optee-os standalone and just flashing it to the final EVE image (with the proper offset). By enabling UEFI boot in u-boot, we can boot EVE in the same way as done in RPi...

1. Because binman does the same thing that imx8-mkimage does, but not as flexible. And we don’t need flexibility, we choose what we will have in the image, the user cannot influence it.

2. Because it's convenient. We immediately get 1 blob that can be written to the image, without additional commands.

Ok, understood. I'm not opposed to use binman, but by sooner or later we will need imx8-mkimage anyways (to produce signed images), am I right?

Ok, understood. I'm not opposed to use binman, but sooner or later we will need imx8-mkimage anyways (to produce signed images), am I right?

I think yes, but it will be necessary to check and study this part better, i haven't tried it yet, and we don't know yet how we will use signing image feature with eve-os.

Cortex M is part of the SoC. I thought you were working with i.MX8MP, but now I see your board has a i.MX8MQ, that's not a big deal, SoCs are still of the same family.

Oh, yep, I mistakenly thought of a machine learning chip in this moment...

The same for CAN bus (this one might be required earlier), that's why I would like to be sure about the support...

My board doesn't have a CAN bus. If I understood correctly only imx8mp, imx8qm and imx8qx has CAN bus.

@Insei , I think this PR it's getting a good shape, I will try to add support for imx8mp (phytec's board) and come back to you in case I face any problem...

@Insei, I've added the support for Pollux board (i.MX8MP SoC) on top of your PR. Here is my experimental branch:
https://github.com/rene/eve/tree/imx8mp-pollux
I needed to change some of your approaches in order to add another i.MX8M platform, so I will comment here (in this PR) and pointed to the corresponding changes in my branch. My plan is to make a PR once yours get merged. But please, feel free to cherry pick any of my commits if you need.
PS: My branch is rebased over your PR and also over Petr's (cross compilers), so I could build the kernel faster using cross-compilation.

Rebased with latest master version here: https://github.com/rene/eve/tree/imx8mp-pollux-rebased (pushed to another branch to not mess up with posted links in my comments with commit hashes)

@rene Great job, I generally plan to fix Yetus, correct the tabulation, and the rest everything as it is.

Rebased with latest master version here: https://github.com/rene/eve/tree/imx8mp-pollux-rebased (pushed to another branch to not mess up with posted links in my comments with commit hashes)

@rene Great job, I generally plan to fix Yetus, correct the tabulation, and the rest everything as it is.

That's fine @Insei, so let's get this PR merged and then I will open a new one with my changes...


Fix delete to use refresh option

@mtvs Can you explain this PR?

Here, I've added the missing check for document_refresh option within delete() in the indexer classes to set the refresh option for the elastic client accordingly.

Makes sense to me. I'm merging it.

Released in v4.0.5


chore(linter): angular linter setup

Codecov Report

Merging #47 (cf102c5) into dev (a3728ea) will increase coverage by 6.86%.
The diff coverage is 60.00%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@            Coverage Diff             @@
##              dev      #47      +/-   ##
==========================================
+ Coverage   72.36%   79.23%   +6.86%
==========================================
  Files         162       60     -102
  Lines        2566     1103    -1463
  Branches      220      120     -100
==========================================
- Hits         1857      874     -983
+ Misses        682      217     -465
+ Partials       27       12      -15

Impacted Files
Coverage Δ

...risma/reservation/prisma.reservation.repository.ts
0.00% <0.00%> (ø)

...ecurity/authorization/policy/reservation.policy.ts
93.10% <33.33%> (-6.90%)
:arrow_down:

...i/src/domain/reservation/scheduled-parking-time.ts
90.47% <50.00%> (+0.47%)
:arrow_up:

api/src/domain/reservation/reservation.ts
96.07% <100.00%> (+0.16%)
:arrow_up:

...ure/security/authorization/policy/driver.policy.ts
100.00% <100.00%> (+52.63%)
:arrow_up:

.../persistence/prisma/driver/prisma.driver.finder.ts
80.95% <100.00%> (+80.95%)
:arrow_up:

...ce/prisma/reservation/prisma.reservation.finder.ts
22.85% <100.00%> (+22.85%)
:arrow_up:

frontend/src/app/auth/sign-in/sign-in.component.ts

frontend/src/app/core/abstract.dialog.ts

frontend/src/app/core/api/auth.api.ts

... and 105 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Import failures

Some previously created configuration profiles fail to import if the legacy save files exist in the Library.
Workaround is to remove the old profiles from the library and attempt to reimport

I have fixed this for the next release, will be out within 1-2 days.

This was fixed in Beta 6.


Fixes #16266

Fixed yii\helpers\BaseStringHelper where explode would not allow 0 as trim string

Q
A

Is bugfix?
yes

New feature?
no

Breaks BC?
no

Tests pass?
yes

Fixed issues
#16266

Merged. Thank you!


Fix some links to mini-protocol code in documentation

A few of the links from the documentation to the code of mini protocols broke
during refactoring.

@kantp it's fixed in #3088. I also replaced links to the code with links to haddock.
Maybe the problem is that the link itself.  CI builds on every branch, and I suspect that the link in our README, points to the latest build, which might not be the latest version merged to master.


docu: clearify behavior of TOKEN_LIMIT_PER_USER

TOKEN_LIMIT_PER_USER does not expire older tokens, it just denies to creating a new token.

No clue why a documentation change breaks the python test...

No clue why a documentation change breaks the python test...

This is bound to a Django rest framework update see --> https://travis-ci.community/t/importerror-cannot-import-name-nullcharactersvalidator-running-django/10043

Rebased, checks now passed


Spamming town selection if piracy run is still ongoing

Bug explanation
If there's still a piracy run ongoing, Ikabot will start going through the towns indefinitely at a very fast pace until it can successfully start a new run. This can cause IP bans by the Gameforge's anti-DDoS system due to the high amount of requests. It can also cause problems in other functions which require a specific town to be in.
Possible solutions could be fetching the remaining time of the ongoing run and adding a timer. A regular timer with fixed interval could also work as an alternative.
Operating System
All
Ikabot installation
I downloaded the pre-built Windows binary
Ikabot version
Latest
Python version
3.11.3

I've also encoutered this problem.

Ikabot already fetches the remaining time of the ongoing run and waits for it to finish, or at least it should.

This is fixed now in eeb5b9a9e59098b45b35a59cf75a2e29b6f41822, please reopen if it happens again.


New version: RandomEngy.VidCoder version 8.21

Result: Installation Successful

Manifest
Add/Remove Programs

Name
VidCoder
VidCoder

Version
8.21
8.21.0

Publisher
RandomEngy
RandomEngy

ProductCode

VidCoder.Stable

Auto-updated by vedantmgoyal2009/winget-pkgs-automation in workflow run 5344
Microsoft Reviewers: Open in CodeFlow

Same situation as #93905 - these VidCoder packages will make great additions when dependency support is more robust.


Editing stream name / description puts double quotes around it.

The code at fault is in /src/streams/streamsActions.js/updateExistingStream.js.
where api.updateStream is called with the response of JSON.stringify(newValue.name) as the value parameter.
This code was added in  https://github.com/zulip/zulip-mobile/commit/3e1becac570dc8e2d3a163673c5403a47285c820 and  https://github.com/zulip/zulip-mobile/commit/f86e9147cf6101cfd07858440ab7b31667ccf8d0.
Removing the call to JSON.stringify will remove this issue.
It is unclear to me what the "unsafe characters" are described in that commit, I don't think removing the call to JSON.stringify can have any problem, but still posting it as an issue to ask what other people think of this.

Thanks for the detailed explanation @AkashDhiman! Working on this 🙂

We need to be sure what does it mean by "unsafe characters" before removing the JSON.stringify method.


dlib Taking up all RAM

I am trying to train object detector on 14k images all labled but it ends up taking all the RAM and stuck.What to do?I have 16gigs of RAM but stuck.. :(

Buy more RAM or use fewer and/or smaller images.

Have GPU? You need to explain better your system specs etc. 14K is huge, whats the training model, how many steps, how many epochs? Questions, questions...


bug fixed for nacos naming :  trim prefix "naming" when it has prefix…

bug fixed for nacos naming

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


feat: e2e-tests repo CI rule chain

Description

introduced CI Rule Chain for e2e-tests repo (CI Rule Chains for other repositories - infra-deployments, integration-service etc. - will follow in other PRs) that replaces the messy code in magefile.go
updated the Eval method signature to return also an error type when evaluating conditions
eventually we will create rules for every repository where we run e2e tests, and once it's done, duplicated code from magefile.go will be removed

Issue ticket number and link
KONFLUX-3902
Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[X] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

How Has This Been Tested?
locally by mocking the CI-provided values:
export KONFLUX_CI=true
export JOB_SPEC='{
                "container_image": "quay.io/redhat-user-workloads/konflux-qe-team-tenant/konflux-e2e/konflux-e2e-tests@sha256:70adb47a4e050232cbc53cbcd3b1e8db07e806e5cf083f355afbcebbf9cfba01",
                "konflux_component": "konflux-e2e-tests",
                "git": {
                    "pull_request_number": 1344,
                    "pull_request_author": "psturc",
                    "git_org": "konflux-ci",
                    "git_repo": "e2e-tests",
                    "commit_sha": "632593323899578bf5979cbddcf736447043422c",
                    "event_type": "pull_request",
                    "source_repo_url": "https://github.com/psturc/e2e-tests",
                    "source_repo_branch": "KONFLUX-3902-e2e-tests"
                }
            }'
# + export all required env vars for running the bootstrap and e2e tests
make ci/test/e2e

also the initial CI run worked as expected
Checklist:

[X] I have performed a self-review of my code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] I have added meaningful description with JIRA/GitHub issue key(if applicable), for example HASSuiteDescribe("STONE-123456789 devfile source")
[ ] I have updated labels (if needed)

/retest

/retest

@psturc @Dannyb48 seems like no event is send to Pipelines when a PR is converted from draft to normal PR... I think we should open a thread in Konflux. I will add manually.

/retest

/lgtm


🐛 [firebase_auth] MultiFactorInfo property enrollmentTimestamp always returns 0.0

Bug report
Describe the bug
MultiFactorInfo property enrollmentTimestamp always returns 0.0 on Android. Other properties are fine.
https://github.com/firebase/flutterfire/blob/d8bf818528c3705350cdb1b4675d600ba1d29d14/packages/firebase_auth/firebase_auth_platform_interface/lib/src/platform_interface/platform_interface_multi_factor.dart#L124
Steps to reproduce
Steps to reproduce the behavior:

Sign in with Google provider

Enroll a second factor by calling below method
https://github.com/firebase/flutterfire/blob/7132d771ed5ada7a0433232b9f0d996ef0d61481/packages/firebase_auth/firebase_auth/lib/src/multi_factor.dart#L19-L24

After you sign in again,  enrollmentTimestamp returns 0.0

Expected behavior
enrollmentTimestamp returns accurate time

Flutter doctor
Run flutter doctor and paste the output below:
Click To Expand
Doctor summary (to see all details, run flutter doctor -v):
[✓] Flutter (Channel stable, 3.0.5, on macOS 12.5 21G72 darwin-arm, locale ja-JP)
[✓] Android toolchain - develop for Android devices (Android SDK version 31.0.0)
[✓] Xcode - develop for iOS and macOS (Xcode 13.4.1)
[✓] Chrome - develop for the web
[✓] Android Studio (version 2021.2)
[✓] VS Code (version 1.70.0)
[✓] Connected device (4 available)
    ! Error: iPhone has recently restarted. Xcode will continue when iPhone is unlocked. (code -14)
[✓] HTTP Host Availability

• No issues found!

Flutter dependencies
Run flutter pub deps -- --style=compact and paste the output below:
Click To Expand
Dart SDK 2.17.6
Flutter SDK 3.0.5
flutter_firebase_mfa 1.0.0+1

dependencies:
- adaptive_dialog 1.8.0 [animations collection dynamic_color flutter intersperse macos_ui meta]
- collection 1.16.0
- cupertino_icons 1.0.5
- firebase_auth 3.6.3 [firebase_auth_platform_interface firebase_auth_web firebase_core firebase_core_platform_interface flutter meta]
- firebase_core 1.20.1 [firebase_core_platform_interface firebase_core_web flutter meta]
- flutter 0.0.0 [characters collection material_color_utilities meta vector_math sky_engine]
- flutter_dotenv 5.0.2 [flutter]
- flutter_riverpod 2.0.0-dev.9 [collection flutter meta riverpod state_notifier]
- flutter_signin_button 2.0.0 [flutter font_awesome_flutter]
- gap 2.0.0 [flutter]
- go_router 4.2.7 [collection flutter flutter_web_plugins logging meta]
- google_sign_in 5.4.1 [flutter google_sign_in_android google_sign_in_ios google_sign_in_platform_interface google_sign_in_web]
- simple_logger 1.9.0 [logging stack_trace]
- touch_indicator 2.0.0 [flutter]
- tsuruo_kit 0.0.10 [cloud_firestore collection flutter flutter_riverpod flutter_web_plugins rxdart]

dev dependencies:
- flutter_test 0.0.0 [flutter test_api path fake_async clock stack_trace vector_math async boolean_selector characters charcode collection matcher material_color_utilities meta source_span stream_channel string_scanner term_glyph]
- pedantic_mono 1.19.2 [flutter_lints]

transitive dependencies:
- animations 2.0.3 [flutter]
- async 2.8.2 [collection meta]
- boolean_selector 2.1.0 [source_span string_scanner]
- characters 1.2.0
- charcode 1.3.1
- clock 1.1.0
- cloud_firestore 3.4.4 [cloud_firestore_platform_interface cloud_firestore_web collection firebase_core firebase_core_platform_interface flutter meta]
- cloud_firestore_platform_interface 5.7.1 [collection firebase_core flutter meta plugin_platform_interface]
- cloud_firestore_web 2.8.4 [cloud_firestore_platform_interface collection firebase_core firebase_core_web flutter flutter_web_plugins js]
- dynamic_color 1.4.0 [flutter flutter_test material_color_utilities]
- fake_async 1.3.0 [clock collection]
- firebase_auth_platform_interface 6.5.3 [collection firebase_core flutter meta plugin_platform_interface]
- firebase_auth_web 4.2.3 [firebase_auth_platform_interface firebase_core firebase_core_web flutter flutter_web_plugins http_parser intl js meta]
- firebase_core_platform_interface 4.5.0 [collection flutter flutter_test meta plugin_platform_interface]
- firebase_core_web 1.7.1 [firebase_core_platform_interface flutter flutter_web_plugins js meta]
- flutter_lints 2.0.1 [lints]
- flutter_web_plugins 0.0.0 [flutter js characters collection material_color_utilities meta vector_math]
- font_awesome_flutter 9.2.0 [flutter]
- google_sign_in_android 6.0.1 [flutter google_sign_in_platform_interface]
- google_sign_in_ios 5.4.0 [flutter google_sign_in_platform_interface]
- google_sign_in_platform_interface 2.2.0 [flutter quiver]
- google_sign_in_web 0.10.2 [flutter flutter_web_plugins google_sign_in_platform_interface js]
- http_parser 4.0.1 [collection source_span string_scanner typed_data]
- intersperse 2.0.0
- intl 0.17.0 [clock path]
- js 0.6.4
- lints 2.0.0
- logging 1.0.2
- macos_ui 1.7.1 [flutter]
- matcher 0.12.11 [stack_trace]
- material_color_utilities 0.1.4
- meta 1.7.0
- path 1.8.1
- plugin_platform_interface 2.1.2 [meta]
- quiver 3.1.0 [matcher]
- riverpod 2.0.0-dev.9 [collection meta stack_trace state_notifier]
- rxdart 0.27.5
- sky_engine 0.0.99
- source_span 1.8.2 [collection path term_glyph]
- stack_trace 1.10.0 [path]
- state_notifier 0.7.2+1 [meta]
- stream_channel 2.1.0 [async]
- string_scanner 1.1.0 [charcode source_span]
- term_glyph 1.2.0
- test_api 0.4.9 [async boolean_selector collection meta source_span stack_trace stream_channel string_scanner term_glyph matcher]
- typed_data 1.3.1 [collection]
- vector_math 2.1.2

Thanks for the report. I do see same behavior on Android.

Hello, looking at the data from Android, it seems that the underlying SDK is returning 0.
I'll raise an issue in the Android Firebase repo

I added in anddroid to PR title, because it seems that the bug occurs only in android refer to https://github.com/firebase/flutterfire/issues/9363
Thanks.

Has been fixed in https://firebase.google.com/support/release-notes/android#auth_v21-1-0


Mapboxgl currently using default token

https://docs.mapbox.com/help/how-mapbox-works/access-tokens/#how-access-tokens-work


support for javascript workers

Does this package support workers?

It's just a scripting engine conforming to ECMAScript 5.1 spec. You could use it to create an execution  environment compatible with browsers which could include workers but that would be an external project and require a bit of work.


Revise line and col information in all rules

Most of our rules report only in first cell (col = 0) even if the problem occurs in the middle of line. Some of the rules also report im the wrong line.
We need to go through all rules and check how they report col and line information and fix if necessary.

@mnojek What should be start pos of line and col? Currently first line = 1, first col = 0. This cause some problems, for example PyCharm counts first line as 1 (and issues from external tools are 'shifted' by 1).
But most issues are looking ok in LSP (with some exceptions - to be fixed). If we change first col to 1 we would need to update most issues +1 and then decrease col by 1 when converting issues to lsp diagnostic since Range is 0 based: https://microsoft.github.io/language-server-protocol/specifications/specification-3-17/#range

Honestly, I have no idea what is the best option. I would just look at the other linters and see what approach do they have, e.g. pylint and others.

Unfortunately it's differs.. pylint starts from 0, pycodestyle from 1, flake8 from 1. IDEs typically support from 1. LSP plugin hovewer expect it from 0. 1's is bit more favoured though we would need to release our own Jenkins parser for Warnings plugin since we could not longer use Pylint one.


Finetuning example loss does not decrease over time

System Info / 系統信息
CUDA 12.1, Torch 2.3
Who can help? / 谁可以帮助到您？
No response
Information / 问题信息

[ ] The official example scripts / 官方的示例脚本
[ ] My own modified scripts / 我自己修改的脚本和任务

Reproduction / 复现过程
I've been trying to run the finetuning example for Cog2 (on a dual A100 setup with deepspeed). The loss fluctuates like crazy around 2.0, and it doesn't seem to converge or decrease over time. At first I tried with my own dataset, but as that didn't work also tested the code with the provided labels_en both from the multi-conversation and single conversation, and it does mostly the same (the en version fluctuates maybe around 1.8, up and down).
Tried to decrease/increase lr, no luck. Any suggestions?
BTW, thanks for releasing this great model!
Expected behavior / 期待表现
Loss decreases.

Just in case, I tried the same finetuning using 8 x A100 to mimic the docs, loss doesn't seem to decrease either.
This is my tensorboard for the 8 x GPU finetuning right now, all params default:

me too, loss does not decrease too,
my target : ["gate_proj","up_proj","down_proj","vision_expert_query_key_value","vision_expert_dense","language_expert_query_key_value","language_expert_dense"]

loss确实没有降低，这个问题已经被记录，我们测试了微调的模型能按照微调的结果输出（但是loss没有下降，还在进一步debug）

初步猜测是lr太低的问题，调成1e-4就好些了，有下降的趋势，但也不明显，LLM一般很明显

初步猜测是lr太低的问题，调成1e-4就好些了，有下降的趋势，但也不明显，LLM一般很明显

1e-4 下降0.04每个epoch， 2e-7下降0.01每epoch（太小了，所以肉眼看起来是没下降）

可以尝试用sat微调：https://github.com/THUDM/CogVLM/tree/cogvlm2_dev，把微调代码的CogVLMModel换成CogVLM2Model就可以了。后续会merge到这个仓库里。

可以尝试用sat微调：https://github.com/THUDM/CogVLM/tree/cogvlm2_dev ，把微调代码的CogVLMModel换成CogVLM2Model就可以了。后续会merge到这个仓库里。

merge了吗？现在还是波动较大

loss确实没有降低，这个问题已经被记录，我们测试了微调的模型能按照微调的结果输出（但是loss没有下降，还在进一步debug）

您好，请问这个大概是什么原因呢？现在训loss还是不太下降


[Docs] Update custom documentation for loss layer

[Docs] Update custom documentation for loss layer

This patch updates documentation of custom for loss layer.
Also deletes redundant `pow.cpp` that sneaked in.

**Self evaluation:**
1. Build test: [X]Passed [ ]Failed [ ]Skipped
2. Run test: [X]Passed [ ]Failed [ ]Skipped

Signed-off-by: Jihoon Lee<EMAIL_ADDRESS>

:memo: TAOS-CI Version: 1.5.20200925. Thank you for submitting PR #1267. Please a submit 1commit/1PR (one commit per one PR) policy to get comments quickly from reviewers. Your PR must pass all verificiation processes of cibot before starting a review process from reviewers. If you are new member to join this project, please read manuals in documentation folder and wiki page. In order to monitor a progress status of your PR in more detail, visit http://nnstreamer.mooo.com/.

INFO: You can read if there are misspelled characters at our misspelling check report. Please read http://nnstreamer.mooo.com/nntrainer/ci/repo-workers/pr-checker/1267-202106101749480.5402090549469-67a9bb44ff6daed433def0ef0d4f4019d640e8c7/report/misspelling_result.txt.

INFO: You can read if there are misspelled characters at our misspelling check report. Please read http://nnstreamer.mooo.com/nntrainer/ci/repo-workers/pr-checker/1267-202106101843520.98127388954163-1c76e76d21c4c6cf0a47fb3f0560ba45eed29e96/report/misspelling_result.txt.


Add ctx in SpanDecorator option

I needed to add specific tag from contextKey set in the context on an other middleware before this one.
I wasn't able to access it without adding the context in the decorator.

@rnburn could this be merged?


Clicking "collections created" on user profile page gives "ActionView::MissingTemplate in Catalog#index" error

Description of issue
When I click "Collections created" on my user profile page, nurax-pg gives me a "ActionView::MissingTemplate in Catalog#index" error message.
Steps to replicate

Navigate to Dashboard -> Your Activity -> Profile
Click on "Collections created" link.
Observe error message.

@jlhardes Can be closed; I cannot replicate.

Closing as fixed!