Invalid compose file because networks structure is wrong

Describe the bug
With the change introduced in commit Update the network structure, I get the following error:

ERROR: The Compose file '/srv/server/proxy/compose/bin/..//docker-compose.yml' is invalid because:
networks.default value Additional properties are not allowed ('name' was unexpected)

To Reproduce
Steps to reproduce the behavior:

Clone the repository
cd to ./bin inside the cloned repository folder
Execute fresh-start.sh

Expected behavior
It should read it and continue without failing.
Server info:

Linux release: Debian 9 (stretch)
Server type: ODROID-C2
Docker version: 19.03.15
docker-compose version: 1.25.4

Update the docker version to 20

My version of docker is 20 but I got the same issue
docker -v
Docker version 20.10.7, build 20.10.7-0ubuntu5~20.04.2

It was resolved by checking out version 0.6

I finally reverted Update the network structure and everything went fine for me @allanext, but it's quite interesting to know that it's not working for you in docker version 20.

@xaabi6 my bad... I was in a hurry, just wanted you to fix the issue.
But the message you received was from docker-compose not docker, so the version you are using of docker-compose 1.
This new structure is for version 2.
I will add to the home a version compatibility soon.
Sorry for the hurry again!

Thanks for the clarification @evertramos, I never thought the culprit would be the docker-compose version but it makes sense because otherwise it would have worked for @allanext.

For anyone still having trouble, you need to install compose switch: https://docs.docker.com/compose/cli-command/#compose-switch
You can install it in one command. Then docker-compose will use v2.

@xaabi6 @evertramos I've set docker-compose 2 and I still have the network error:
~/docker/proxy/bin$ docker-compose -v
Docker Compose version v2.0.1
~/docker/proxy/bin$ docker -v
Docker version 20.10.7, build 20.10.7-0ubuntu5~20.04.2

with the trunk i get:
git clone --recurse-submodules https://github.com/evertramos/nginx-proxy-automation.git proxy
./fresh-start.sh --yes -e email@domain --skip-docker-image-check

 ✔ success Function 'file_comment_line_with_string'
 ✔ success Function 'file_comment_line_with_string'
 ✔ success Function 'local_update_docker_compose_file'
network proxy declared as external, but could not be found
 ✔ success Function 'docker_compose_start'
 ✘ ERROR   There was an error starting the service at '/home/user/docker/proxy/bin/../'

with the tag git checkout  tags/v0.6 i get two warnings:
./fresh-start.sh --yes -e email@domain --skip-docker-image-check
⚡ Start execution './bin/fresh-start.sh  ✔ success Function 'check_local_env_file'
 ✔ success Function 'check_docker'
 ✔ success Function 'check_running_script'
 ✔ success Function 'starts_initial_check'
WARN[0000] network default: network.external.name is deprecated in favor of network.name
 ✔ success Function 'docker_compose_check_service_exists'

...

 ✔ success Function 'file_comment_line_with_string'
 ✔ success Function 'local_update_docker_compose_file'
WARN[0000] network default: network.external.name is deprecated in favor of network.name
network proxy declared as external, but could not be found
 ✔ success Function 'docker_compose_start'
 ✘ ERROR   There was an error starting the service at '/home/user/docker/proxy/bin/../'

I've also installed docker-switch as suggested by @mlysle:
curl -fL https://raw.githubusercontent.com/docker/compose-cli/main/scripts/install/install_linux.sh | sh

@xaabi6 @evertramos removing network: external worked for me

@xaabi6 @evertramos I've just installed a fresh version and the issue is still there.
Shouldn't network: external be commented out on the master branch?

@allanext what version of docker-compose do you have installed?

Hi @evertramos here are the versions:
Docker Compose version v2.0.1
user@ubuntu:~$ docker -v
Docker version 20.10.7, build 20.10.7-0ubuntu5~20.04.2
user@ubuntu:~$ uname -a
Linux 5.4.0-92-generic #103-Ubuntu SMP Fri Nov 26 16:13:00 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux```

@allanext not sure what would cause that... I will check this when I get the time, but this network structure is external, so it must be informed in our compose, once the network may already exist, when I get a chance I will come back to this thread.


Keylogger

I have only installed League of Legends and Steam on my system, and yet, after downloading this particular program, unauthorised individuals gained access to my accounts on Steam and Google. Despite using complex passwords and experiencing no database breaches, it is evident that this program is, without a doubt, a keylogging software.

The code is available, you can compile it yourself. Do you see any keylogging code?

xD

I have only installed League of Legends and Steam on my system, and yet, after downloading this particular program, unauthorised individuals gained access to my accounts on Steam and Google. Despite using complex passwords and experiencing no database breaches, it is evident that this program is, without a doubt, a keylogging software.

Same exact thing happened to me. This is malware.

Honest question: Could you please highlight the place where the keys are collected? I've checked the code and haven't found this part, so could you please point it to me?

I had the same problem dont use this program it works but its a key logger

I’ve checked the code multiple times for maintenance when I wanted to update the patches for myself, and there’s really nothing in them, zero malwares.

"I've experienced no database breaches" "I use complex passwords"

I open issues on open source software claiming open source code is malware

Are you retarded

best quote for this issue here.

best quote for this issue here.

Right, I guess the keylogging software that spammed my discord and steam friends was because on microsoft word... be so fr now instead of using slurs, y'all dont trust this version.

best quote for this issue here.

Right, I guess the keylogging software that spammed my discord and steam friends was on microsoft word... be so fr now instead of using slurs, y'all dont trust this version.

"Don't trust this version"
We have read the code.
We compile it ourselves.
You don't know what you're talking about.


Fix - Checkbox icon accept CheckboxIconMarginTop variable

@patrick-welab Can you explain why is this needed?

@SupriyaKalghatgi I saw the theme variables CheckboxIconMarginTop is defined on https://github.com/GeekyAnts/NativeBase/blob/37558cb46ad11dcb97322d69aae1511cbc46e40b/src/theme/variables/platform.js#L90 but it is never used in the code
Also CheckboxIconMarginTop could be found on http://docs.nativebase.io/docs/ThemeVariables.html

Thank you @patrick-welab for bringing this to our notice.
We should be looking into this with other perspective.
You will be updated on this here


Cannot reset glsuterfs topology

I want to reset the glusterfs topology because one of my server changed IP.
So I tried to delete everything related to glusterfs:
kubectl delete -n gluster svc,deployments,daemonset,pods,pv,pvc --all
I also deleted and recreated the volumes on all the nodes
I delete the /etc/glusterfs directory on all the nodes
I've edited the topology to match the new one (one IP changed)
I then ran:
./gk-deploy -n gluster -w 900 -g -y topology.json
But the still get the error:
Using Kubernetes CLI.
Using namespace "gluster".
Checking for pre-existing resources...
  GlusterFS pods ... found.
  deploy-heketi pod ... found.
  heketi pod ... not found.
  gluster-s3 pod ... not found.
Creating initial resources ... Error from server (AlreadyExists): error when creating "/home/user/k8s/gluster-kubernetes/deploy/kube-templates/heketi-service
-account.yaml": serviceaccounts "heketi-service-account" already exists
Error from server (AlreadyExists): clusterrolebindings.rbac.authorization.k8s.io "heketi-sa-view" already exists
clusterrolebinding.rbac.authorization.k8s.io/heketi-sa-view not labeled
OK
Found node vps01 on cluster d1590f4ee8fcfb6202446c8b63b95908
Found device /dev/loop0
Found node vps02 on cluster d1590f4ee8fcfb6202446c8b63b95908
Found device /dev/loop0
Found node vps04 on cluster d1590f4ee8fcfb6202446c8b63b95908
Found device /dev/loop0
heketi topology loaded.
Error: Unable to execute command on glusterfs-wb4cl: volume create: heketidbstorage: failed: Host 5.196.XX.XXX is not in 'Peer in Cluster' state
command terminated with exit code 255
Failed on setup openshift heketi storage
This may indicate that the storage must be wiped and the GlusterFS nodes must be reset.

The IP displayed in the error message does not match the one in my topology.json file.
Is there something I forgot to delete in order to completely reset the glusterfs cluster ?
I don't care about the data as I'm still trying to setup a cluster.

As per log, gluster pods still found.
You need to delete all pods first.
You can try kubectl get all and delete all resources.
Also, by passing --abort you can delete  existing resources.

Yes it works now, however I have now this error:
mount: /var/lib/kubelet/pods/ae815ad6-ac5a-11e8-bbc2-fa163eec9a70/volumes/kubernetes.io~glusterfs/heketi-storage: unknown filesystem type 'glusterfs'.
Do I need to install glusterfs-fuse on the host machine ? Is there any package required to be installed on the nodes host machines ?

Do I need to install glusterfs-fuse on the host machine ?

GlusterFS client version installed on nodes should be as close as possible to the version of the server.
Please check https://github.com/gluster/gluster-kubernetes/blob/master/docs/setup-guide.md

Ok It worked. Thank you

@bend  Glad it helped - If you think there is any need to improve anything specific in documentation, let us know.  Also, feel free to send Pull requests :)


Handle verse spans in the scripture viewer

Issue
—-
USFM that contains verse spans - \v 2-4 should display the text for that verse in gatewayEdit. The spanned text should be displayed for all verses in the span. ie. A verse span of \v 2-4 should show the text whether verse 2 or 3 or 4  is chosen in the reference navigator. The highlighting should work as if the text is a single verse.
DoD:
—-
Scripture that contains combined verses in a span should be displayed and highlighted in the scripture cards.
Details:
—-
Often translators have to combine the text of two or more verses in order to properly communicate the text correctly. The is represented in USFM by a verse marker followed by two numbers separated by a hyphen.  (\v 2-4). The user expects a verse span to function just like all the other verses for all the checks for all the verses included in the span. An example of how this works is the scripture pane in translationCore.

@birchamp @elsylambert Currently in GWE we display the verse spans, but highlighting is not working.  Phil 1:15-17 in en_ust is a good test example because it is both a span and is aligned:

@PhotoNomad0 Please see the attached screenshot: in the latestGWE v1.1.0 build 2747aff QA server.

The highlighting is not showing up even after adding Original Quote to the Quote section. Was the highlighting fixed in this build?

@elsylambert  It works if you change occurrence to 1

Thanks @PhotoNomad0 it works.

@elsylambert FYI - the alignment on the UST for that verse span 15-17 is very strange. It is not very linear.   Maybe they got the occurrences mixed up?

Yeah @PhotoNomad0 I noticed that. Could it be data issue? I tried with occurrence 2 but it does not highlight with it.

Yeah @PhotoNomad0 I noticed that. Could it be data issue? I tried with occurrence 2 but it does not highlight with it.

Hmm...both 1 & 2 are working for me when I use the same word you chose.

@elsylambert do we need to meet after standup?  I can bring up tCore to see how the ust is aligned, but It looks like it is highlighting properly.  Maybe I need to google chiasm from the note and see if that means a mixed up order?

@elsylambert maybe we should create an issue for GWE to highlight/flag invalid fields? - such as invalid occurence number, missing supportReference, Notes, etc. ?  @birchamp

Tested with v1.1.0 build 2747aff QA. Working properly


Function not deploying with Azure SWA

First, thanks for your work on this and for making it available to the public!
We're trying to deploy a Remix Vite app as an Azure Static Web App using your createRequestHandler function and can't quite seem to get it to work (via the Azure SWA CLI). After deploying, static assets are served up properly but it doesn't appear the Azure Function gets created so every other non-static-asset request fails (404). We don't get any related errors during deployment, as far as we can tell.
As a sanity check, we attempted to deploy your non-Vite example SWA project and that is behaving in the exact same way - static assets work, other routes (the Azure Function) do not.
Some questions for you:

Should there be some indication in the Azure portal web UI that a function was created and exists within the SWA? The only indication I have right now is when I go to Application Insights, it says App Insights is only applicable to Static Web Apps with at least one function. Add a function to your app to enable App Insights. - which makes me think the function did not get created.
What is the appropriate situation for node_modules? We've been trying all these deployments with node_modules in the root of the project and no server/node_modules - but it dawned on us that the deployment may not run npm install once the function code is deployed, meaning the necessary node_modules for the function would not be there at runtime. But if we include server/node_modules, the deployment fails because the API Zip is too big (errors with Reason: The size of the function content was too large. The limit for this Static Web App is 104857600 bytes.).
Should this work on the Free hosting plan? Someone said you need to be on the Standard hosting plan for functions to work in an SWA. We tried both, no difference in behavior. Just curious if you know for sure.

Any guidance you could provide would be most appreciated. 🙏
Thank you!

Thanks for reaching out!
Just to mention, we are currently using this in our production environment for different remix application with vite and without vite. There is also a working example in the SWA example readme, maybe you can find that useful!
Answering your questions:

Once a deploy is made, you should be able to "see" your function under the APIs section. You can access through the sidebar, under Settings.

If the Function is not there, my suggestion would be to:
a. Try to start the function locally, either with the Azure Functions emulator using the azure-functions-core-tools.
b. Check the logs to see if there is any start-up issue with your function.

I think this depends on how you bundle your application and each case is unique. First, is possible to tell Azure to run npm install --production, you can check more here.
Secondly, we used managed functions which means that we are deploying the function by itself by packing everything into a zip file with the node_modules. Again, I do think that this depends quite a lot on your stack and how you are managing your deployments.

Yes, doesn't really matter in which Plan you are. The working example is on the Free tier.

If you like, you can create an small reproduction case where we can take a look and see what's going on.

There is also a working example in the SWA example readme, maybe you can find that useful!

We couldn't get that to work, either. It does the same thing as ours (no function created). ☹
As for ours, everything runs great locally when we run npm run simulate-azure given the following package.json scripts:
"simulate-azure": "run-p simulate-azure:*",
"simulate-azure:swa": "swa start ./build/client --api-location ./server --port 3000 --api-devserver-url http://<IP_ADDRESS>:3030",
"simulate-azure:function": "func start --prefix server/ --cors-credentials --port 3030"

We can then browse http://localhost:3000 and it renders the index route as expected.
We're deploying like so:
npx cross-env SWA_CLI_DEPLOYMENT_TOKEN=<AZURE_SWA_DEPLOYMENT_TOKEN> swa deploy --no-use-keychain --verbose=silly

All the log output from that command looks like it should have worked (no errors, gives us a smiley face and a URL at the end).
We're doing managed functions as well (got past the 100MB limit by only installing production deps in the server directory, like you mentioned above). But even though the deploy appears to succeed, the function does not get created.

Maybe this has something to do with our deployment approach? So far, this has just been an experiment to see if we could get it to work, so we've just been trying to deploy from the CLI on our local dev machines. Under normal circumstances, we would use GitHub Actions to deploy. But we wanted to get it to work manually first. Maybe the GitHub Action does something extra that we're not aware of and/or can't reproduce manually?
I can create a small reproduction repo but like I said, the example doesn't work for us either, so it might not be too valuable.
Thanks so much for your help on this!

Here's the project we're using (minimal repro): https://github.com/halljus/remix-swa

Right, It could be related on how the output is being generated using vite. We can add a new example using vite instead

A working example would be great! 🙏

Here is a working example with vite:
https://github.com/scandinavianairlines/remix-azure-functions/pull/76
There are a few things to take into consideration, I try to wrote all of the in the readme file. If you still can't deploy it, let us know!

The deploy succeeding but no logs about what's going on is quite common on Azure 😅
My though on what's going on is that the package deployed as a function is not right, so the function cannot start.
Make sure of:

The SWA CLI is picking the right staticwebapps.config.json file. Looking at the logs, is using one from /public while it should be build/client.
Double check what SWA is deploying as a function. Not sure if there is another way, but what I usually do is to grab the zip file generated by SWA CLI on deploy and see what's inside.
Make sure that the build/server is part of the function package

I can't get your example to work, either - it behaves in an identical way (says it succeeds, but no function deployed).

Do you know why it would matter which staticwebapp.config.json it uses? The one in build/client is just copied from public by the Vite build process, so they are identical. The logs from deploying your example also reference the copy in public, for what it's worth.
I looked at the zip already and it contains what I would expect: the contents of the server directory, including node_modules and build/server/index.js. 🤷♂
Yep, confirmed.

I just tried deploying your example on my personal device/network/Azure account and it does the exact same thing (no function gets deployed). So that eliminates my enterprise work environment, at least.
You've successfully deployed your Vite example? I must just be missing a step or something... 😅

You can try looking into the logs.
The easiest way is to query
traces
Check if you see some logs saying
X functions found
X functions loaded
If you get more "found" that loaded there is usually also some logs with the node style exception.
Hope it helps

You can try looking into the logs.
The easiest way is to query
traces
Check if you see some logs saying
X functions found X functions loaded
If you get more "found" that loaded there is usually also some logs with the node style exception.
Hope it helps

Thanks for the suggestion. What logs? Where? I have the SWA CLI log output set at the most verbose level and there's nothing in there (see above). I see no logs available on the SWA in the Azure Portal (Application Insights is only available if there is a function present, which there isn't).

There is no logs as application insights is not initialised yet 😂 , chicken and the egg story here...
The example is deployed and working, you have the URL in the readme.

Silly question, but do you have a host.json file in the root of the function right?
Are you still trying to deployed what you share in the reproduction repository?

Again, to me this points that you are missing a dependency on your function. If the vite build doesn't have declare the noExternal optional, you need to also include all the dependencies from the UI.

It works! 🎉
So... the only difference was we were using npm (not allowed to use yarn). I guess now we need to determine what on earth is happening with npm. 😕
For reference, we were doing this:
npm install
cd server
npm install --omit=dev
cd ..

OK, so I jumped to an invalid conclusion there. It had nothing to do with yarn-vs-npm, it was just the import * as build from './build/server/index.js'; change. 😅

I think this concludes the experiment. Thanks so much for all your help @lfantone!

I'm removing the vite dev server from the example to make it easier and clear for everyone.


Relative links on rich text edit are malformed

Azure Data Studio Version:
OS Version:

Steps to Reproduce:

Create a notebook under a folder with name containing spaces ex: ADS LiveSite Books
Create another notebook under the same folder and create a relative link to the prior notebook.
Now edit the cell with the relative link, the relative link gets updated to a weird absolute path.

https://github.com/microsoft/azuredatastudio/pull/21438 fixes this as well, closing this.


move example app documentation into a separate README

This PR splits off the MORKExample documentation into a separate README and adds some clarifying information about how the results are persisted to Rave.

:+1:


check if placeholder can be removed from config file, and only use place holder in template theme file

No need to remove it. Keep it for a flexible way to do customization.


Trouble with Bits

Okay maybe I'm stupid and missed it when reading but where does it say how to collect bits? Like what's the process of collecting them? Do I write the coords of a corner or something? Im in a dungeon but it still says 0 bits collected pls help.

the mod does all the work lol.  use the mod then run around and find as many structures as possible.
For example burried ships, igloos,  pillager outpost,  ocean monuments, pyramids and swamp huts
when u find enough the tool will try to crack


Update existing comicinfo.xml

Maybe a dumb question, but I wasn't sure. With the parameter -p I can print out existing tags. With -f I can parse the file name to lookup comic informations and with -m I'm able to direct comictagger to look for something specific.
I have a lot of comics where the data is incomplete. I would like to update this on comicvine and get an updated comicinfo.xml into my comics. How can I accomplish this without parsing again the file name or extracting with -p the content and use the --id flag to request it specifically for that file?
Maybe a parameter -u --update would be a great enhancement.

So unless ComicTagger can't parse the filename or you need a specific functionality you can just run this command
comictagger --save --type CR --parse-filename --no-overwrite --online --recurse .

This uses the "save" command with ComicRack tags, parse the filename, skip comics that already have a comicinfo.xml, retrieve metadata online and to recursively search all files in the current directory
The -p or --print flag is just to view the information in the file, if it is a part of your process for tagging comics it should be the last part to verify that they got tagged how you want them to.
The -f or --parse-filename flag should pretty much always be used, unless you know that it causes issues with a particular set of comics, any data stored as tags takes priority over data parsed from the filename.
The -m or --metadata overrides any other information obtained before doing an online search.
The --id flag is the last resort if ComicTagger can't find the issue, you can use it to tag a specific comic, but 80% of the time comictagger should just be able to search using the filename and find it.
comictagger -s -t cr --id 1234 comic.cbz
See the wiki for more info https://github.com/comictagger/comictagger/wiki


Material syntax breaks parentheses matching indicator

When the syntax theme is on, proper parentheses matching in one line is not shown, for example:

However, closing parenth in another line shows up properly
(only closing though, I don't know if thats intended):

This is clearly a syntax theme issue, same situation after switching to One Dark looks like this:

Happens on atom 1.21.1 with no other package than atom-material-syntax and atom-material-ui installed. Seen on both linux and windows.

same here

#83 should fix this issue

Here's a temporary fix by the way: https://github.com/atom-material/atom-material-syntax/pull/83#issuecomment-351348082


[app] Add support for collections

The authenticator should handle collection scopes

@hstove got a general idea of the work involved to make this happen?

It requires that the authenticator

creates a requested keys for the collections.
writes an encrypted file to gaia storage containing the keys

It's definitely a non-trivial amount of work. The technical details have already been implemented by Ken in the Browser, and we'd also want to consider the UI changes.

There is no UX for "publish_data", why bother for collection scopes ;-)

A request should be for a specific collection type.  "collections_documents", for instance.

There is no UX for "publish_data"

Actually there is, if you are selecting an ID that has already done publish_data with a different app. We warn the user that they'll be able to be cross-identified.

This is still important to me!


Feat: add List.perm_replicate_append_replicate

This is a forward-port of leanprover-community/mathlib#18126
Also golf a proof.

[ ] depends on: #1475

This PR/issue depends on:

leanprover-community/mathlib4#1475
By Dependent Issues (🤖). Happy coding!

This PR/issue depends on:

leanprover-community/mathlib4#1475
By Dependent Issues (🤖). Happy coding!

The proofs are not exactly aligned, but that's okay.
bors merge


add agent client to retrieve agent status, metadata, load, and job counts

🛠 Changes being made

Added agent client to check if enabled/check availability for agent registration to livekit-server.
Added metadata for workers registered to livekit-server to manage the context of the agent in the dispatch service.
Added worker_info to retrieve agent status, metadata, load, and job counts.

🧠 Rationale behind the change

In the dispatch service, it is necessary to manage agents registered to livekit-server to determine which agent can be dispatched to a room.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.an-vo3_cake seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

Hi Team,
Could you please let me know if this PR is necessary for implementation? In my context, I want to manage the agents registered to the LiveKit server. Before starting a new room, I would like to check:

Which script/scenario an agent can serve based on the metadata registered with the LiveKit server.
Agent availability for handling conversations in this room. Through load testing, we can determine how many rooms a single agent worker instance can handle (including STT, TTS, VAD, and LLM).

Before dispatching, I may need to check:

job_count per worker
load / threshold for agent availability.

Please provide more information and context for scaling to production.
Thank you!


Update sheet.html with Battle Dancer class

Added missing Battle Dancer class, including calculations based on that class.

Submission Checklist
Required

[x] The pull request title clearly contains the name of the sheet I am editing.
[x] The pull request title clearly states the type of change I am submitting (New Sheet/New Feature/Bugfix/etc.).
[x] The pull request makes changes to files in only one sub-folder.
[x] The pull request does not contain changes to any json files in the translations folder (translation.json is permitted)

New Sheet Details

The name of this game is: <   >  (i.e. Dungeons & Dragons 5th Edition, The Dresden Files RPG)

The publisher of this game is: <   > (i.e. Wizards of the Coast, Evil Hat)

The name of this game system/family is: <   > (i.e. Dungeons & Dragons, FATE)

[x] I have followed the Character Sheets Standards when building this sheet.

[ ] I have authorization from the game's publisher to make this an official sheet on Roll20 with their name attached.
[ ] This game is not a traditionally published game, but a copy of the game rules can be purchased/downloaded/found at: <   >
[x] This sheet is for an unofficial fan game, modification to an existing game, or a homebrew system.

Changes / Description

Minor change to add one missing class to the character sheet.

Small change to add the Battle Dancer class. If this works, we'll be adding a few more minor changes in the near future to keep things up to date with the latest rules additions.


Fix simulation directories

Codecov Report

Merging #279 into dev0-2 will decrease coverage by 0.02%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           dev0-2     #279      +/-   ##
==========================================
- Coverage    70.4%   70.37%   -0.03%
==========================================
  Files          69       69
  Lines        3034     3031       -3
==========================================
- Hits         2136     2133       -3
  Misses        898      898

Impacted Files
Coverage Δ

src/utils/simulation_results_reference.jl
84.61% <100%> (ø)
:arrow_up:

src/core/core_structs/simulation.jl
96% <100%> (+4.33%)
:arrow_up:

src/core/build_simulations.jl
89.39% <100%> (-1.97%)
:arrow_down:

src/routines/solve_routines.jl
88% <100%> (-0.24%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a975596...aab44a2. Read the comment docs.


CLI on macOS ignores -t/--threads

Always uses 1 thread; compiled using basic instructions

Hi,
This is because the Clang compiler provided by Apple has OpenMP (multi-threading) disabled. In order to compile primesieve with multi-threading on macOS I suggest you use the GCC compiler instead:
brew install gcc

CXX=g++-6 cmake .
make -j

primesieve now uses C++11 threads instead of OpenMP. Multi-threading now also works on macOS using Apple Clang.

That's great; I couldn't get brew to link g++.
The new version works as expected, thanks.


AP-4726-Add partner income to "Review and print" page

What
Add partner income to 'Review and print' page
Describe what you did and why.
Checklist
Before you ask people to review this PR:

Tests and rubocop should be passing: bundle exec rake
Github should not be reporting conflicts; you should have recently run git rebase main.
The standards in the Git Workflow document on Confluence should be followed
There should be no unnecessary whitespace changes. These make diffs harder to read and conflicts more likely.
The PR description should say what you changed and why, with a link to the JIRA story.
You should have looked at the diff against main and ensured that nothing unexpected is included in your changes.
You should have checked that the commit messages say why the change was made.

Well spotted on the missing section and actioning it, just a few minor questions from me.


Decomposition of Non-H1 spaces doesn't work on geometries with repeated knots.

I found a bug when discretizing VectorFemSpace on the geometry pipe.h5 when kind is not h1. It seems to be caused by the repeated knots.
Here's the code :
import os
from mpi4py import MPI
from sympde.topology import VectorFunctionSpace, Domain, ScalarFunctionSpace
from psydac.api.discretization import discretize

geometry = 'pipe.h5'
kind = 'hcurl'
space = VectorFunctionSpace

comm = MPI.COMM_WORLD
rank = comm.Get_rank()

filename = os.path.join('../mesh', geometry)

domain = Domain.from_file(filename=filename)
domain_h = discretize(domain, filename=filename, comm=comm)

dim = domain.dim

symbolic_space = space('V', domain, kind=kind)

mapping = list(domain_h.mappings.values())[0]
degree = mapping.space.degree

space_h = discretize(symbolic_space, domain_h, degree=degree)

print(rank, f"mapping local domain {mapping.space.local_domain}\n",
            f"space.spaces[0] local domain {space_h.spaces[0].local_domain}\n",
            f"space.spaces[1] local domain {space_h.spaces[1].local_domain}\n")

When called with mpirun -n 2, the domain decomposition is not what it should be :
1 mapping local domain ((15, 0), (31, 31))
 space.spaces[0] local domain ((8, 0), (31, 31))
 space.spaces[1] local domain ((7, 0), (31, 31))

0 mapping local domain ((0, 0), (14, 31))
 space.spaces[0] local domain ((0, 0), (7, 31))
 space.spaces[1] local domain ((0, 0), (7, 31))

This is done using sympde==0.14.1 as it fails on newer versions.

@saidctb Should this issue be fixed by PR #232?

@saidctb Should this issue be fixed by PR #232?

yes, it's fixed by the PR #232


update jsonschema to v0.9 .

What this PR does / why we need it:

335a7fa - (5 minutes ago) perf: used hash object confirm if there was a duplicated value in array.

Pre-submission checklist:

[x] Did you explain what problem does this PR solve? Or what new features have been added?
[ ] Have you added corresponding test cases?
[ ] Have you modified the corresponding document?
[x] Is this PR backward compatible?

duplicated with PR https://github.com/apache/incubator-apisix/pull/1863


No API to retrieve a world's sea level

Unless I'm blind, there isn't an API for it. @Deamon5550 wasn't able to find one either, so blame him if I'm wrong.

Is this changeable?

@ST-DDT In theory, mojang made an effort to replace all hard codings of it with a field in the 1.9 update (although they missed a few places). No reason why it can't be settable though.

@Deamon5550
What are some of the things that this is used for in the Vanilla code?

Looks like it's used in some mob AI / spawning checks (bats, ocelots, and squids from what I saw). It's used in BiomeMesa as well for terrain gen, and in chunk for lighting checks, and in a few ChunkProviders. Just the few usages I found after a quick search in IntelliJ.


Error when you open vim from a different folder than elm.json is located

I always have to cd for the root folder where elm.json is located so the elm-format plugin triggers correctly. Otherwise I keep receiving this error message.
I couldn't figure out what version of Elm you are using!

You should either run elm-format from the directory containing
your elm.json (for Elm 0.19) or elm-package.json (for Elm 0.18),
or tell me which version of Elm with --elm-version=0.19 or --elm-version=0.18

I have the same issue, but not all the time and not in all projects.
running :ElmFormat works fine.

The difference between the 2 projects is:
working:

nodejs : 8.8.1
elm-format: elm-format-0.19 0.8.0

problem:

nodejs :  10.9.0
elm-format: 0.8.1

The problem is that the plugin is not using the latest version of elm (0.19) while the elm-webpack loader is using elm 0.19. Run run --version in case your elm version is updated to the latest use this code as the ElmComponent wrapper instead of this plugin.

I may be mistaken, but I believe this pull request should have fixed this issue no that it will fall back to FindRootDirectory. Are you able to check and report back?

@Hermanverschooten I'll look into that. I have another PR that is dealing with elmMake so hopefully if that gets merged in I can start working on some of the other issues with various commands, including what you just mentioned.

Ok, thanks

This would be awesome to have a fix for.

The problem was with elm-format itself, and it's already fixed there (version 0.8.2).


[Bug] Fix build error

Checklist

[x] I've looked at the contribution guidelines.
[x] This pull request is complete and ready for review.

Description
The build error is caused by QuickSort(https://github.com/raywenderlich/swift-algorithm-club/pull/580/commits/449b14b904c6cee06460c3933b7b73f60104593a). The update changed something in workspace, it specified the fileRef as user's local path. So Travis cannot figure out that path, it cause build error.
#604

Thanks for fixing this @remlostime.


More Refactoring & KivyMD & Scalability

Many things was changed, removed, added, etc... The main idea was to make project scalable for future improvements and additions. Hope this will give some idea of where to grow this project.

Has runtime error in player.py file, closing this PR


Evaluate whether any additional garbage collection stats would be useful

With Ruby 3.3, the GC.stat hash has 31 keys. As of agent version 9.6.0, we report on 5 of these. Is there any value in reporting on any of the other 26?
NOTE: here are lists of keys for each currently supported Ruby version
2.4, 2.5, 2.6

count
heap_allocated_pages
heap_sorted_length
heap_allocatable_pages
heap_available_slots
heap_live_slots
heap_free_slots
heap_final_slots
heap_marked_slots
heap_eden_pages
heap_tomb_pages
total_allocated_pages
total_freed_pages
total_allocated_objects
total_freed_objects
malloc_increase_bytes
malloc_increase_bytes_limit
minor_gc_count
major_gc_count
remembered_wb_unprotected_objects
remembered_wb_unprotected_objects_limit
old_objects
old_objects_limit
oldmalloc_increase_bytes
oldmalloc_increase_bytes_limit

2.7

(all from the previous list)
compact_count

3.0

(all from the previous list)
read_barrier_faults
total_moved_objects

3.1, 3.2

(all from the previous list)
time

3.3

(all from the previous list)
marking_time
sweeping_time

In addition to exploring the other GC.stats key/value pairs, we can also explore the other GC methods beyond stats to see if there's anything there we want to consider.


any chance for a linux version ?

It look very good, but I want to try to use it in my linux webserver (Debian 8.2).
I have try to compile it with xbuild coming with mono (a .NET adaptation for linux) but I get many errors.
mono-building-loe-ghost-server-sln.txt
I'll search more after 1 week, but if you can answer me, it can be great too ^^
If I understand well, this allow to run a private server with sql support for the players in the February build of legends of equestria ?

Yes it works with february client build and allow almost the same features as official server.
I managed to build mono version (I use mono <IP_ADDRESS> and XBuild Engine 14.0) whith latest commit.

Yeah, I'm so happy for this, my dedicated server'll be able to resume service for this game, and for what I see, you really did a great job here
Can it be launched without any windows display manager ? I'll see how to make that if not.

Okay, so now, I have these 2 warning, I'll check that later (because it is 3AM), but if you can do it now
mono-building-loe-ghost-server-sln(1).txt

This server is console application and does not required gui to work.

Thanks and sorry for annoying you with that. Now, I have 0 Error and 0 Warning, but it continue to fail the compilation :
mono-building-loe-ghost-server-sln(2).txt

Hm... I just don't know what went wrong:)
Can you try to build with these parameters: "/verbosity:diagnostic /clp:verbosity"?

Thanks for your help, and sorry for my bad level in programming.
mono-building-loe-ghost-server-sln(3).txt

if last commit not help you can try compiled files:
https://drive.google.com/open?id=0B_U2XbzYevYbeXlZZzIyRE9tT2s

Try use mono insted of wine

Ah, it seem to work, I only have "couldn't connect to database", so I'll try to add the sql to my server and your file and I'll see if all work well

Ok, it seem to work now, thank you very very much !
What I have in my server :
serverlog(1).txt
I'll need to ask you for new version you compiled if it doesn't annoy you, and I'll see to make a launcher allowing to chose on what server you want to connect with the game.

I'll make release build, after upcoming official "Open Servers Weekend" with new client version support.

Thanks then

I didn't mind. You can do everything you want!

I have still an issue, the game keep loading ponies characters for ever, what port should I open in my firewall if it is the problem ? Else, I don't know where the game is stuck :/

You no need to patch dll, modify connections.json and put it to the game folder.
In loe_server.cfg replace all "<IP_ADDRESS>" with you IP, except mysql_host.

It working, thanks !
Just need to make a sign up page, but I need to know how the password is encripted, I see this in the login.php : base64_encode(hash("tiger192,3", "Celestia".time()."Luna".$this->game_login."~zbKG5tGWqv")) Is it correct ?

No it's session id. Password hashed with sha1:
user name(in lower case) + password.

Ok, it's working, thanks, I think I can close this issue now.


Dropped items do not seem to get affected by all collision

https://user-images.githubusercontent.com/20887403/180648925-f1864b1d-baf7-4648-8cc9-c249c0aba67b.mp4

Duplicate of #543?

Whoops


Aggregate function always returns the source list.

The cql aggregate function appears to always return the source list, unaltered, regardless of the parameters given to it.
For example, take:
({ 1, 2, 3, 4, 5 }) Num
aggregate Result starting 1: Result * Num
This will return the array {1, 2, 3, 4, 5] rather than the expected value of 120.
Similarly, other more complicated expressions after the ":"  still just return the input source as an array of original values.
Ref:   CqlAggregateTest.xml

Resolved by #1271


Drop device capabilities

FTR, first patch is from #630
This patchset drops the device capabilities. They are mostly superfluous because we should simply assume that if we have multiple profiles, we can switch between them and write to them. Same for buttons, etc.
Some of the button caps are now handled by the action types list. And the profile disable/default caps are better handled in the profile (because that's where the set_foo() calls are).
This is of course an API break, the Capabilities property on the device disappears.
Another subtle change: if our name isn't writable, simply don't export it (DBus empty string).

Oke, that took less effort than expected. One change I had to make in the ratbagd bindings was the following, due to https://github.com/libratbag/libratbag/pull/631/commits/f285b12f212cd00cb461969696fe2c3bd166375f#diff-4edf8a4ccbbc4924299aa67ad39e8283R388:
@@ -485,7 +455,11 @@ class RatbagdProfile(_RatbagdDBus):
     @GObject.Property
     def name(self):
         """The name of the profile"""
-        return self._get_dbus_property("Name")
+        name = self._get_dbus_property("Name")
+        if not name:
+            name = "Profile {}".format(RatbagdProfile.counter)
+            RatbagdProfile.counter += 1
+        return name

Perhaps we can include this in the linked diff instead, because ratbagd_profile already has the index as a member of its struct.


Move RingBuffer to a separate module

This uses the freshly created module pa_ringbuffer: https://github.com/mgeier/python-pa-ringbuffer.
Thanks to @arigo for helping me on the CFFI mailing list: https://groups.google.com/forum/#!topic/python-cffi/JtAKU-g9Exg!
@tgarc Would you mind testing if that works for you?
Any comments?
Suggestions for improvements?

Yes, this module seems to work fine for me. Thanks!

@tgarc Thanks for testing!
Which OS did you try?
I initially tried it on Debian Linux and there it works.
Sadly, it doesn't seem to work on macOS:
$ python3 setup.py develop
...
creating build/temp.macosx-10.11-x86_64-3.6/build/temp.macosx-10.11-x86_64-3.6
clang -Wno-unused-result -Wsign-compare -Wunreachable-code -fno-common -dynamic -DNDEBUG -g -fwrapv -O3 -Wall -Wstrict-prototypes -UNDEBUG -Isrc -I/usr/local/Cellar/python3/3.6.0/Frameworks/Python.framework/Versions/3.6/include/python3.6m -c build/temp.macosx-10.11-x86_64-3.6/_rtmixer.c -o build/temp.macosx-10.11-x86_64-3.6/build/temp.macosx-10.11-x86_64-3.6/_rtmixer.o
creating build/lib.macosx-10.11-x86_64-3.6
clang -bundle -undefined dynamic_lookup build/temp.macosx-10.11-x86_64-3.6/build/temp.macosx-10.11-x86_64-3.6/_rtmixer.o /Users/me/python-pa-ringbuffer/src/_pa_ringbuffer.abi3.so -o build/lib.macosx-10.11-x86_64-3.6/_rtmixer.abi3.so
ld: can't link with bundle (MH_BUNDLE) only dylibs (MH_DYLIB) file '/Users/me/python-pa-ringbuffer/src/_pa_ringbuffer.abi3.so' for architecture x86_64
clang: error: linker command failed with exit code 1 (use -v to see invocation)
error: command 'clang' failed with exit status 1

According to http://stackoverflow.com/a/24519922/ this seems to have to do with the -bundle and -dynamiclib options.
Any ideas how to make this work?

Yeah I also tested on debian linux. Unfortunately I don't have any
experience developing for osx :/
On Mon, Feb 27, 2017 at 11:17 AM, Matthias Geier<EMAIL_ADDRESS>wrote:

@tgarc https://github.com/tgarc Thanks for testing!
Which OS did you try?
I initially tried it on Debian Linux and there it works.
Sadly, it doesn't seem to work on macOS:
$ python3 setup.py develop
...
creating build/temp.macosx-10.11-x86_64-3.6/build/temp.macosx-10.11-x86_64-3.6
clang -Wno-unused-result -Wsign-compare -Wunreachable-code -fno-common -dynamic -DNDEBUG -g -fwrapv -O3 -Wall -Wstrict-prototypes -UNDEBUG -Isrc -I/usr/local/Cellar/python3/3.6.0/Frameworks/Python.framework/Versions/3.6/include/python3.6m -c build/temp.macosx-10.11-x86_64-3.6/_rtmixer.c -o build/temp.macosx-10.11-x86_64-3.6/build/temp.macosx-10.11-x86_64-3.6/_rtmixer.o
creating build/lib.macosx-10.11-x86_64-3.6
clang -bundle -undefined dynamic_lookup build/temp.macosx-10.11-x86_64-3.6/build/temp.macosx-10.11-x86_64-3.6/_rtmixer.o /Users/me/python-pa-ringbuffer/src/_pa_ringbuffer.abi3.so -o build/lib.macosx-10.11-x86_64-3.6/_rtmixer.abi3.so
ld: can't link with bundle (MH_BUNDLE) only dylibs (MH_DYLIB) file '/Users/me/python-pa-ringbuffer/src/_pa_ringbuffer.abi3.so' for architecture x86_64
clang: error: linker command failed with exit code 1 (use -v to see invocation)
error: command 'clang' failed with exit status 1
According to http://stackoverflow.com/a/24519922/ this seems to have to
do with the -bundle and -dynamiclib options.
Any ideas how to make this work?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/mgeier/python-rtmixer/pull/3#issuecomment-282786375,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAaVHJquuXvDJM0V1REnp6A7IfZEGi5kks5rgwUbgaJpZM4MMEMM
.

I tried this on python2.7 + Visual C++ for Python also no issues.

@tgarc Thanks, that's great news!
I've written another message to the CFFI mailing list, I hope somebody will come up with a solution for macOS!

That's annoying. Wish I could help, but I don't even have a mac. FWIW I also compiled with Python3.4 & Visual Studio 2010 and on my older redhat 6.7 setup at work without a hitch.

@tgarc Thanks for the update, I hope somebody will come up with a solution for macOS!
BTW, you are talking about compiling ... I think you should also try to run it, because there might still be a dynamic link error at runtime?

Yes I've run the code on all those systems, I'm using it in my own module.
On Mar 1, 2017 2:14 AM, "Matthias Geier"<EMAIL_ADDRESS>wrote:

@tgarc https://github.com/tgarc Thanks for the update, I hope somebody
will come up with a solution for macOS!
BTW, you are talking about compiling ... I think you should also try to
run it, because there might still be a dynamic link error at runtime?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/mgeier/python-rtmixer/pull/3#issuecomment-283273795,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAaVHIjFPqCpEDu2N6GXpnNy1zvOHgfXks5rhSkBgaJpZM4MMEMM
.

@mgeier Sorry, still no feedback in the mailing list.  I don't have a Mac either; I only know that .so and .dylib files are somehow working differently from each other.  I think that by now, .dylib's are strictly more general than .so's, so that using .dylib everywhere should work.  But I don't know how that plays with the idea that CPython C extension modules should be .so's.

@arigo Thanks for your answer!
TL;DR: I found a setting which seems to work on CPython/macOS, see the last few paragraphs of this comment.
I did some digging:
On macOS, there seem to be two types of "dynamic" libraries: ones for "loading" (MH_BUNDLE, with any extension, sometimes .so, sometimes .dylib, sometimes .bundle, sometimes something else) and ones for "linking" (MH_DYLIB, always with the extension .dylib, but sometimes also hidden in "frameworks", which are hopefully not relevant here).
"loading" seems to be not so picky and also work with MH_DYLIB nowadays, but "linking" still only works with MH_DYLIB and doesn't work with MH_BUNDLE. If I understood correctly, "loading" is what's done by ffi.dlopen(...), while "linking" is what's done when I just specify the file name of the .dylib as command line option to the compiler.
The type of a given library can be found out with
otool -hv somelib.so

Here are some more details about the topic: http://docstore.mik.ua/orelly/unix3/mac/ch05_03.htm.
Some more random links:
http://stackoverflow.com/questions/2339679/what-are-the-differences-between-so-and-dylib-on-osx
http://stackoverflow.com/questions/32419594/how-to-create-a-dylib-c-extension-on-mac-os-x-with-distutils-and-or-setuptools
CPython seems to be expecting their extension modules to be MH_BUNDLE, see second comment here: https://github.com/python/cpython/blob/master/Python/dynload_next.c.
This was discussed in 2004: https://mail.python.org/pipermail/pythonmac-sig/2004-January/009925.html.
When I create a CFFI module with CPython, I indeed get a MH_BUNDLE (with the extension .abi3.so).
When I create a CFFI module with PyPy, I get a MH_DYLIB (with the extension .pypy-41.so).
When I try to compile this PR with CPython, I get the error message mentioned above: https://github.com/mgeier/python-rtmixer/pull/3#issuecomment-282786375.
I can compile it on PyPy without error message. However, I get an error on import:
>>>> import rtmixer
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/Users/me/python-rtmixer/src/rtmixer.py", line 7, in <module>
    from _rtmixer import ffi as _ffi, lib as _lib
ImportError: unable to load extension module '/Users/me/python-rtmixer/src/_rtmixer.pypy-41.so': dlopen(/Users/me/python-rtmixer/src/_rtmixer.pypy-41.so, 6): Library not loaded: build/lib.macosx-10.11-x86_64-2.7/_pa_ringbuffer.pypy-41.so
  Referenced from: /Users/me/python-rtmixer/src/_rtmixer.pypy-41.so
  Reason: image not found

The file _pa_ringbuffer.pypy-41.so (which is found successfully given its absolute path) seems to in turn link to the relative path build/lib.macosx-10.11-x86_64-2.7/_pa_ringbuffer.pypy-41.so. These two .so files are in fact identical (a copy was made during the CFFI build process), there just seems to be some mixup with the internally stored paths.
BTW, a little side note: pypy uses cc while CPython uses clang for compiling. On the Mac where I'm trying this, those are the same. I don't know if this means anything, I just wanted to mention it.
Now back to CPython:
When I manually replace the -bundle option with -dynamiclib, the compilation of pa_ringbuffer still works and I indeed get a MH_DYLIB. I can successfully import and use the pa_ringbuffer module, even though CPython expects a MH_BUNDLE.
I can also successfully compile the rtmixer module, but on import I get an error quite similar to the above:
>>> import rtmixer
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/Users/me/python-rtmixer/src/rtmixer.py", line 7, in <module>
    from _rtmixer import ffi as _ffi, lib as _lib
ImportError: dlopen(/Users/me/python-rtmixer/src/_rtmixer.abi3.so, 2): Library not loaded: build/lib.macosx-10.11-x86_64-3.6/_pa_ringbuffer.abi3.so
  Referenced from: /Users/me/python-rtmixer/src/_rtmixer.abi3.so
  Reason: image not found

I assume that problem could be somehow solved, but I don't know if it is the right approach, especially since CPython doesn't seem to "officially" support MH_DYLIB extension modules.
After all this playing around, I did one more random thing: I just removed the line
extra_objects=[_pa_ringbuffer.__file__],

... which previously added the .dylib file name to the compiler options. To my big suprise, now it works!
To be more exact: With CPython on macOS it seems to work if I remove the abovementioned line!
I don't know how and why, but it works ...
Does it have something to do with this line?
ffibuilder.include(_pa_ringbuffer_build.ffibuilder)

Does this do some magic on CPython/macOS that it doesn't do on PyPy/macOS and CPython/Linux?

  You would have the same troubles trying to do the same thing with regular CPython extension modules written in C, and you would have found the solution that fails to work on OS/X in the same way.
This problem is actually documented for CPython: https://docs.python.org/2/extending/extending.html#using-capsules ("capsules" are a custom but portable solution to that problem).
Maybe you should use a similar approach.  For example, cffi module A defines a (static) global structure a_api containing pointers to (static) functions, and expose it via cffi.def("""struct A_api a_api;""").  Then cffi module B has a (static) global function pointer to this structure, also exposed via cffi.def("""struct A_api *a_api_ptr;""").  Then you need one extra line of Python code after importing A and B, to link them together: b_ffi.a_api_ptr = ffi.addressof(a_ffi.a_api).
In this way, there is no need to compile B in such a way that it depends on A: the linking is done purely by that Python line.
See example at https://paste.pound-python.org/show/bNtITFyGgohi7TtgKcCV/

Thanks a lot @arigo, that's extremely helpful, especially the working mini-example!
I've tried your suggestion, but with a little twist, since I didn't really like to force users to use the redirection via the API struct.
I thought if I can use a pointer to a struct, I might as well use multiple function pointers, and this way the user can call the functions just as in the original C API (without even knowing that now they are function pointers).
It works like a charm (for now I've tried it on CPython/Linux and PyPy/Linux)!
My first attempt is here: fbdd4257f7289477f1d8584706d9e308a5baacbb.
This only works with the corresponding changes in pa_ringbuffer: https://github.com/mgeier/python-pa-ringbuffer/pull/2/commits/19731b341cc095cddde4d9e1bd485a2e3f7a547d.
To simplify the usage, I've defined two strings CDEF and SOURCE that can be used in the "derived" module to avoid copying the C code.
I've also created a function link_c_functions() that encapsulates assigning stuff from one module to the other.
This already works, but I had also to add some casts, because in my Python code now I'm mixing the two CFFI instances. Other re-users will also have to do that.
To avoid all the casting and therefore simplifying the user code, I've tried to sneakily switch the CFFI instance from below the RingBuffer implementation.
This is done in 6dbcdda8af411fdd66e2f4bba9d899461e78bbca, which needs https://github.com/mgeier/python-pa-ringbuffer/pull/2/commits/d6b49b39b1b2ead807866196a645a68b5cf9373b.
I've renamed the function link_c_functions() to link(), because now it's doing more than that.
As far as I can tell, this works on Linux, I hope it will also work on other OSs.
But I'm not sure if I'm on the right track, probably there is a better solution ...
Is it a good idea to define and later assign all those function pointers?
Is it a good idea to pull a switcheroo on the CFFI instance of pa_ringbuffer?
I have the feeling that it is a bad idea, because if multiple modules "derive" from pa_ringbuffer and are used at the same time, each one will switch the CFFI instance ...
Probably I can make something that generates the RingBuffer class on demand, injecting the right CFFI instance?
Are there examples of other libraries that do a similar thing with CFFI?

I've added another commit (df9b230c9c8a3e3951a44c438f2e1b6dcd75ed43) that uses a modified ring buffer class instead of monkey-patching the pa_ringbuffer module. This needs also an updated version of the pa_ringbuffer module: https://github.com/mgeier/python-pa-ringbuffer/commit/55595d8b71e36e8f9da23289ac739adb34b54f5e.
I think it should work now without problems, but I'm not sure if that's really the way it should be done ...
Any comments?
@tgarc I've seen that you are patching pa_ringbuffer.py in order to inject your own ffi and lib objects. What do you think about using something like the link() function (as in https://github.com/mgeier/python-pa-ringbuffer/commit/55595d8b71e36e8f9da23289ac739adb34b54f5e) instead?
Or is there probably something completely different that I could try to make re-using pa_ringbuffer easier?
BTW, the only project using ffibuilder.include() that I could find is https://github.com/gdanezis/bplib/blob/master/bplib/compile.py. I'm not sure, but I think they don't link to their "parent" CFFI module ...

I've made another attempt for this in #5 (in combination with https://github.com/mgeier/python-pa-ringbuffer/pull/4).
This time, I completely removed the compilation part from pa_ringbuffer and only provide the Python code there. Plus, for convenience, the string that can be used in ffibuilder.cdef().
The compilation now has to be done only once (in the rtmixer module) and there is only one CFFI instance involved, which hopefully makes things easier.
This might be a little more complicated to set up, but I hope it's still easy to use.
I've added some (hopefully accurate) documentation: https://github.com/mgeier/python-pa-ringbuffer/tree/foreign-init#usage.
It has the advantage that it also works by just copying pa_ringbuffer.py to some importable directory. Getting it from PyPI is optional (and currently it's not yet available there!).
@arigo Can you please have a quick look if that makes sense from a CFFI standpoint?
@tgarc Since you are the only user I know of, can you please check if that works for you?
Is #5 better than #3?
Any further suggestions?

I'm closing this in favor of #5.


FilterDialog: don't slow down horribly on huge waveforms when typing

Live updates are cool but we don't want to slow everything down with huge filters re-evaluating the filter graph every keystroke.
Can we do this in a background thread, queueing an update flag so things don't update unless we're idle?

Fixed in ngscopeclient. No plans to backport to glscopeclient.


Bugs when mapping reads with number of CIGAR operations > 64k

Hi philres:
I am using NGMLR for maping ultro long nanopore reads.
here is my NGMLR and SAMTOOLS version
ngmlr --version
ngmlr 0.2.7 (build: Jul  2 2018 10:32:15, start: 2018-09-10.12:02:26)
Contact<EMAIL_ADDRESS>
samtools --version
samtools 1.9
Using htslib 1.9
Copyright (C) 2018 Genome Research Ltd.

And here is my commands to run ngmlr:
ngmlr -q input.fastq -r ref.hg38.fa -t 28 -x ont --bam-fix | samtools sort -@ 28 -o sorted.bam -

log
Skipping alignment 0 for 914f8a2b-6215-49f9-9be3-941e86ad35d1: number of CIGAR operations 72571 > 64k.

samtools sort error
[E::sam_parse1] incomplete aux field
[W::sam_read1] Parse error at line 3369
samtools sort: truncated file. Aborting

I have tried to output BAM when I run NGMLR and then sort the BAM file by samtools, get the same ERROR as above

Yeah its included in his call.
Could you check if your output sam file from NGMLR has \t at the end of the line?
Thanks
Fritz

You can just attach it here if you press "selecting them" below the text box.
Alternatively, please send it to<EMAIL_ADDRESS>My old university address doesn't work anymore (I'll have to update the address here).
Thanks,
Philipp

Hi Philipp:
I attach the read cause the problem here.
914f8a2b-6215-49f9-9be3-941e86ad35d1.txt
Thanks,
Archie

Hi Fritz:
No \t was found at end of the output sam file
Thanks,
Archie

Hi, I get the exact same samtools error.
I found that it is caused by SAM records with all the bases soft-clipped so that the CIGAR is just 405324S or similar. I don't know whether that is the intended behaviour of --bamfix but I could get around the samtools error by removing all these records with:
sed -E '/\t[0-9]+S\t/d' failing.sam > better.sam


Added Nuance ASR

However, Nuance API returns time out because audio data has to be sent in chunks. Maybe somebody could fix this or is experienced in this.

Nuance Developer Guide (PDF) can be found here: https://www.google.at/url?sa=t&rct=j&q=&esrc=s&source=web&cd=2&cad=rja&uact=8&ved=0ahUKEwim59Cmt9TMAhUJtBoKHcF5AVYQFggkMAE&url=https%3A%2F%2Fdeveloper.nuance.com%2Fpublic%2FHelp%2FHttpInterface%2FHTTP_web_services_for_NCS_clients_1.0_programmer_s_guide.pdf&usg=AFQjCNGX_02PAiXL7Yi2J-_a9FhXwN-_LQ&sig2=1DSipLl3awUnpD1rwXxULg

Thanks! I'll try to review this in the next few days. We could implement chunked transfer pretty simply with what we have now.

Hi @jhoelzl,
I looked into the Nuance API some more, and unfortunately it has several limitations that mean we can't support it in this library:

The free usage tier expires after 180 days, so we won't be able to test/maintain it afterward.
Only the Gold tier has access to the HTTP APIs in production, and the production environment seems to differ from the sandbox in several important ways.

I recommend the excellent Bing STT, api.ai, or Wit.ai APIs instead.


Unknown values on some parameters

I used the add on since a long time with hassio, updating to 104.1 I started to get some "unknown" for parameters that were correctly used in the past.
These are the parameters I am getting back from add-on:

sensor.ups_battery | unknown
sensor.ups_battery_shutdown | 5
sensor.ups_battery_timeout | 0
sensor.ups_cable_type | USB Cable
sensor.ups_daemon_info | 3.14.14 (31 May 2016) unknown
sensor.ups_driver | USB UPS Driver
sensor.ups_hostname | a722577e-apcupsd.local.hass.io
sensor.ups_input_voltage | unknown
sensor.ups_input_voltage_high | unknown
sensor.ups_input_voltage_low | unknown
sensor.ups_load | unknown
sensor.ups_mode | Stand Alone
sensor.ups_model | unknown
sensor.ups_name | APC UPS
sensor.ups_output_voltage | unknown
sensor.ups_shutdown_time | 3
sensor.ups_startup_time | 2020-09-17 16:31:45 +0200
sensor.ups_status | COMMLOST
sensor.ups_status_data | 001,018,0465
sensor.ups_status_date | 2020-09-17 16:31:55 +0200
sensor.ups_time_left | unknown

Currently i am running Hassio 104.4 with addon version 1.9

I'm similarly getting unknown for input_voltage_high, input_voltage_low, and output_voltage but I do get correct values for everything else, including battery and time_left.

I have made the decision to archive this repository. Please see the README for more information.


Investigate Spring Cloud Gateway support for only allowing the proxying of certain URLs

User Story
Our current auth POC uses a simple global wildcard to forward all requests to their correct destination whether it exists or not. This is causing issues with serving swagger ui and also may be forwarding requests to invalid endpoints that could be handled at the gateway level.
Description/Use Case
See if requests could be set up via configuration as seen in Spring Cloud Gateway documentation
Dev Notes
Ensure Swagger can be used if added
Acceptance Criteria
if possible...
-POC updated to route specific configuration (remove wildcard request mapping)
-Requests that are forwarded are still being checked for authentication and 401 if missing/invalid
-Swagger loads
-unit tests continue to pass
if not possible...
-Document reasoning in project and write ticket for alternative way to limit scope of possible forwarded requests

Hey team! Please add your planning poker estimate with Zenhub @adegolier @arnejduranovic @brick-green @david-navapbc @jack-h-wang @jalbinson @JFisk42 @mkalish @thetaurean


Tooltip units for figures with relative measurements

Describe the bug
If a barplot is normalized, the measurement's tooltip inherit the absolute value's unit.
To Reproduce
See for example here. Hovering over displays the bars shows the unit in cubic meters (and with arguably way too many digits)
Expected behavior
Units should either change to %, or the original values should be displayed. Maybe even both?
Screenshots or video

Environment (please complete the following information):

Visualize environment and version: v3.20.3 (99cea84)
Browser and version: Edge Version 115.0.1901.188 (Official build) (64-bit), but the same behavior is seen in Chrome Version 115.0.5790.171 (Offizieller Build) (64-Bit)

Hi @kronmar, thanks for reporting this!
As we treated the two features separately (normalisation of charts and dual-value tooltip), the percentages inside the tooltip are not yet implemented (but should be ready soon) – see #1092 #1093.
I'll mention a pull request in this issue and close once it's merged to main.


实例列表的顺序可以是按时间倒序的吗

[ ] I have searched the issues of this repository and believe that this is not a duplicate.
[ ] I have checked the FAQ of this repository and believe that this is not a duplicate.

Describe the bug
A clear and concise description of what the bug is.
To Reproduce
Steps to reproduce the behavior:

Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
Additional Details & Logs

Version
Error logs
Configuration
Platform and Operating System

自己来提个 pr 吧


[KYUUBI #1620] Implement api: /${version}/operations/${operation_identifier}/log

Why are the changes needed?
closes #1620
Implement api: /${version}/operations/${operation_identifier}/log
How was this patch tested?

[ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible

[ ] Add screenshots for manual tests if appropriate

[ ] Run test locally before make a pull request

Codecov Report

Merging #1621 (346df79) into master (9dfbd2b) will decrease coverage by 20.58%.
The diff coverage is 61.41%.

@@              Coverage Diff              @@
##             master    #1621       +/-   ##
=============================================
- Coverage     78.80%   58.22%   -20.59%
- Complexity       80      164       +84
=============================================
  Files           175      258       +83
  Lines          6451    12815     +6364
  Branches        764     1610      +846
=============================================
+ Hits           5084     7461     +2377
- Misses          923     4723     +3800
- Partials        444      631      +187

Impacted Files
Coverage Δ

...g/apache/kyuubi/sql/KyuubiEnsureRequirements.scala
30.18% <0.00%> (ø)

...pache/kyuubi/sql/KyuubiSQLExtensionException.scala
100.00% <ø> (ø)

...ache/kyuubi/sql/RepartitionBeforeWritingBase.scala
0.00% <0.00%> (ø)

.../kyuubi/sql/watchdog/ForcedMaxOutputRowsBase.scala
0.00% <0.00%> (ø)

.../kyuubi/sql/watchdog/KyuubiWatchDogException.scala
0.00% <0.00%> (ø)

...che/kyuubi/sql/watchdog/MaxPartitionStrategy.scala
0.00% <0.00%> (ø)

...che/spark/sql/PruneFileSourcePartitionHelper.scala
0.00% <0.00%> (ø)

...he/kyuubi/sql/zorder/ZorderSqlAstBuilderBase.scala
26.23% <17.58%> (ø)

...pache/kyuubi/sql/KyuubiQueryStagePreparation.scala
32.35% <25.00%> (ø)

.../kyuubi/sql/zorder/OptimizeZorderCommandBase.scala
77.27% <50.00%> (ø)

... and 231 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9dfbd2b...346df79. Read the comment docs.

thanks, merged to master


Find for recurring calendar items

Is there any way to search for Recurring calendar items by begin/end pediod?
https://msdn.microsoft.com/en-us/library/office/dn727655(v=exchg.150).aspx#sectionSection0
Now they are missing if searching by items_between...
Thank!

As a workaround you can use find_items with calendar_view as described in this issue: https://github.com/WinRb/Viewpoint/issues/184#issuecomment-63967542

This seems to be a bug/regression? In Viewpoint 0.1.27 it used a CalendarView when calling find_items on a calendar folder which would expand this.  See also:
https://github.com/WinRb/Viewpoint/blob/1139abcb9d02661988badd69f4ac235b67fbd01c/lib/model/generic_folder.rb#L291 and
https://github.com/WinRb/Viewpoint/blob/1139abcb9d02661988badd69f4ac235b67fbd01c/lib/model/calendar_folder.rb#L60
Now this method just seems to have a copy-pasted version of what is in GenericFolder.  See also:
https://github.com/WinRb/Viewpoint/blob/e8fec4ab1af25fc128062cd96770afdb9fc38c68/lib/ews/types/generic_folder.rb#L106 and
https://github.com/WinRb/Viewpoint/blob/e8fec4ab1af25fc128062cd96770afdb9fc38c68/lib/ews/types/calendar_folder.rb#L10

according to @paulvt this is resolved in #276


Node t1_2_mni failed to run

Hi,
I'm trying to run qsiprep version 0.15.3 and I receive the following error:
Node: qsiprep_wf.single_subject_211_wf.anat_preproc_wf.t1_2_mni
Working directory: /work/qsiprep_wf/single_subject_211_wf/anat_preproc_wf/t1_2_mni
Node inputs:
compress_report = auto
explicit_masking = True
flavor = precise
float = True
initial_moving_transform =
lesion_mask =
moving = T1w
moving_image =
moving_mask =
num_threads = 8
orientation = LPS
out_report = report.svg
reference = T1w
reference_image = /usr/local/miniconda/lib/python3.8/site-packages/qsiprep/data/mni_1mm_t1w_lps_brain.nii.gz
reference_mask =
settings =
template = MNI152NLin2009cAsym
template_resolution = 1
Traceback (most recent call last):
File "/home/groot/.local/lib/python3.8/site-packages/nipype/pipeline/plugins/multiproc.py", line 67, in run_node
result["result"] = node.run(updatehash=updatehash)
File "/home/groot/.local/lib/python3.8/site-packages/nipype/pipeline/engine/nodes.py", line 516, in run
result = self._run_interface(execute=True)
File "/home/groot/.local/lib/python3.8/site-packages/nipype/pipeline/engine/nodes.py", line 635, in _run_interface
return self._run_command(execute)
File "/home/groot/.local/lib/python3.8/site-packages/nipype/pipeline/engine/nodes.py", line 741, in _run_command
result = self._interface.run(cwd=outdir)
File "/home/groot/.local/lib/python3.8/site-packages/nipype/interfaces/base/core.py", line 429, in run
runtime = self._post_run_hook(runtime)
File "/usr/local/miniconda/lib/python3.8/site-packages/qsiprep/niworkflows/interfaces/registration.py", line 60, in _post_run_hook
return super(RobustMNINormalizationRPT, self)._post_run_hook(runtime)
File "/home/groot/.local/lib/python3.8/site-packages/nipype/interfaces/mixins/reporting.py", line 50, in _post_run_hook
self._generate_report()
File "/usr/local/miniconda/lib/python3.8/site-packages/qsiprep/niworkflows/interfaces/report_base.py", line 55, in _generate_report
mask_nii = threshold_img(fixed_image_nii, 1e-3)
File "/home/groot/.local/lib/python3.8/site-packages/nilearn/image/image.py", line 824, in threshold_img
img_data = _safe_get_data(img, ensure_finite=True, copy_data=copy)
File "/home/groot/.local/lib/python3.8/site-packages/nilearn/_utils/niimg.py", line 51, in _safe_get_data
img = copy.deepcopy(img)
File "/usr/local/miniconda/lib/python3.8/copy.py", line 172, in deepcopy
y = _reconstruct(x, memo, *rv)
File "/usr/local/miniconda/lib/python3.8/copy.py", line 270, in _reconstruct
state = deepcopy(state, memo)
File "/usr/local/miniconda/lib/python3.8/copy.py", line 146, in deepcopy
y = copier(x, memo)
File "/usr/local/miniconda/lib/python3.8/copy.py", line 230, in _deepcopy_dict
y[deepcopy(key, memo)] = deepcopy(value, memo)
File "/usr/local/miniconda/lib/python3.8/copy.py", line 172, in deepcopy
y = _reconstruct(x, memo, *rv)
File "/usr/local/miniconda/lib/python3.8/copy.py", line 270, in _reconstruct
state = deepcopy(state, memo)
File "/usr/local/miniconda/lib/python3.8/copy.py", line 146, in deepcopy
y = copier(x, memo)
File "/usr/local/miniconda/lib/python3.8/copy.py", line 230, in _deepcopy_dict
y[deepcopy(key, memo)] = deepcopy(value, memo)
File "/usr/local/miniconda/lib/python3.8/copy.py", line 172, in deepcopy
y = _reconstruct(x, memo, *rv)
File "/usr/local/miniconda/lib/python3.8/copy.py", line 270, in _reconstruct
state = deepcopy(state, memo)
File "/usr/local/miniconda/lib/python3.8/copy.py", line 146, in deepcopy
y = copier(x, memo)
File "/usr/local/miniconda/lib/python3.8/copy.py", line 230, in _deepcopy_dict
y[deepcopy(key, memo)] = deepcopy(value, memo)
File "/usr/local/miniconda/lib/python3.8/copy.py", line 161, in deepcopy
rv = reductor(4)
File "indexed_gzip/indexed_gzip.pyx", line 956, in indexed_gzip.indexed_gzip.IndexedGzipFile.reduce
File "indexed_gzip/indexed_gzip.pyx", line 737, in indexed_gzip.indexed_gzip._IndexedGzipFile.export_index
AttributeError: '_io.BytesIO' object has no attribute 'mode'
Did anyone encounter something similar and know how to handle it?
Thanks in advance!

are you running this on a system with memory limits? Is it in a docker or singularity container?

It's a singularity container, and the execution doesn't reach the memory limit as far as I can tell.

The many threads may be causing memory to run out too. An update to a newer version likely would fix this too


Clean up error handling

Fixes #295
todo:

[x] stop using class names in errors
[x] auto-add help to errors
[x] simplify error creation

@chriddyp and @etpinard ready for review. There was only one thing I wanted to keep backwards comptatible, which is the plain_message field. We actually use this in streambed...

I'll wait until this gets the :dancer: to work on https://github.com/plotly/python-api/issues/289, which i'd like to do soonish.

Looks good. :dancer:

Cool gonna merge this in then and put in some time on enhancing docstrings.


⚠ Bofrost.lu has degraded performance

In 5e39528, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 972 ms

Resolved: Bofrost.lu performance has improved in ec6f2db.


--status does not detect incomplete download on armv7

I have tried using my little odroid-c1 for big downloads from gog. One of the downloads got interrupted and running 'lgogdownloader --status' does not detect the incomplete download.
The actual size as reported by ls:
$ ls -al
3532570624 Jun 21 21:48 gog_the_book_of_unwritten_tales_2_<IP_ADDRESS>.tar.gz

The content of the xml file provided by gog:
$ more gog_the_book_of_unwritten_tales_2_<IP_ADDRESS>.tar.gz.xml
<file name="gog_the_book_of_unwritten_tales_2_<IP_ADDRESS>.tar.gz" available="1" notavailablemsg="" md5="b899f85f6cf15fde0e80a08b0a1429
17" chunks="475" timestamp="2015-02-23 18:04:45" total_size="4973333114">

The output of --status:
$ lgogdownloader --status --game the_book_of_unwritten_tales_2_almanac_edition
OK the_book_of_unwritten_tales_2_almanac_edition gog_the_book_of_unwritten_tales_2_<IP_ADDRESS>.tar.gz<PHONE_NUMBER> b899f85f6cf15fde0e80a08b0a142917

So lgogdownloader does not detect the difference between the size of downloaded file and the total size as stated by the gog api.
This problem seems to be specific to either 32bit platforms or even the armv7 platform: If I move these files to a x64 box, the size difference is detected and the download resumed accordingly.
Tested against current master.
Platform:
odroid-c1 running ArchLinuxARM

Hopefully 59faa40 fixes this issue
Downloader::checkStatus is a huge mess and has lots of duplicate code. I'll probably need to rewrite it later.

I have tested your patch on my odroid-c1. Now I get this error message:
$ lgogdownloader --status --game the_book_of_unwritten_tales_2_almanac_edition
Getting game info 1 / 1
terminate called after throwing an instance of 'std::out_of_range'
  what():  stoi

c4c2f8c should fix the std::out_of_range error

Ok. The out_of_range error is gone. But --status still does not get it quite right:
$ lgogdownloader --status --game the_book_of_unwritten_tales_2_almanac_edition  ❯❯❯
Getting game info 1 / 1
MD5 the_book_of_unwritten_tales_2_almanac_edition gog_the_book_of_unwritten_tales_2_<IP_ADDRESS>.tar.gz 678365818 5c4dba9b5696e5deffcd0b3fe47e886b

It reports 678365818 as the file size. But the file in question is reported as<PHONE_NUMBER> size on disk by ls -al.
So continuing the download does not work either.

The reason it reports different file size is because I made it so that it reports the file size from xml data.
I changed it in 699c9f2 so that --status now reports the file size from disk rather than xml.

Thanks for that fix. But I am not finished yet ;-)  - I have two more remarks on this topic
First: --status reported (before the last patch) 678365818 as file size - which does not make any sense because the total size as reported in the xml file is<PHONE_NUMBER> -- which looks to me like there is some kind of integer overflow going on.
Second: Although there is a size mismatch --status reports a MD5 mismatch - which does not make any sense for an incomplete file. I think it would be better to report an incomplete download.
To prove my point that there is some kind of overflow going on, this is what happens when actually try to download the game:
$ lgogdownloader --download --game the_book_of_unwritten_tales_2_almanac_edition                                              ❯❯❯
Getting game info 1 / 1
Downloading: Linux Installer, English
/home/erik/gog.com/the_book_of_unwritten_tales_2_almanac_edition/gog_the_book_of_unwritten_tales_2_<IP_ADDRESS>.tar.gz
  0% ▕                          ▏ 4096.00/4096.00MB @ 0.00kB/s ETA: 0s
Downloading: manual (extended, German, English)
/home/erik/gog.com/the_book_of_unwritten_tales_2_almanac_edition/extras/bout_2_almanac_manual.zip
  0% ▕                          ▏ 18.01/18.01MB @ 0.00kB/s ETA: 0s

So lgogdownloader just skips the first file an proceeds with the next one although the first file is not complete yet -- this might be a different issue - so let me know if I should open another issue.

I added status code for file size mismatch in 64690d0
I guess the overflow happens with std::stoull at https://github.com/Sude-/lgogdownloader/blob/3f7fbc5/src/downloader.cpp#L2628 but I don't know why because unsigned long long should be large enough to hold the value.
The standard says it should be at least 64 bits (http://en.cppreference.com/w/cpp/language/types)
_FILE_OFFSET_BITS=64 is defined in Makefile so size_t should also be 64 bits.
What file system are you using?
Because it stops at 4096MB it seems like the 4GB file size limit of FAT32.

I am using ext4. So the maximum file size should not be a problem.
I have looked at downloader.cpp and added the following lines to the function void Downloader::checkStatus():
std::cout << "size_t:\t\t" << sizeof(size_t) << " bytes" << std::endl;
std::cout << "filesize:\t\t" << filesize << std::endl;
std::cout << "filesize_xml:\t\t" << filesize_xml << std::endl;

And here is the resulting output:
$ ./bin/Release/lgogdownloader --status --game the_book_of_unwritten_tales_2_almanac_edition                    ❯❯❯
size_t:         4 bytes
Getting game info 1 / 1
filesize:<PHONE_NUMBER>
filesize_xml:           678365818
FS the_book_of_unwritten_tales_2_almanac_edition gog_the_book_of_unwritten_tales_2_<IP_ADDRESS>.tar.gz<PHONE_NUMBER> 5c4dba9b5696e5deffcd0b3fe47e886b

size_t is only 32 bits which causes the overflow<PHONE_NUMBER>-2^32 = 678365818)
Does using off64_t instead of size_t help?
sed -e 's/std::size_t/off64_t/g' -e 's/size_t/off64_t/g' -i main.cpp src/*.cpp include/*.h

I tried your sed patching -- it causes a lot of compile errors.
So I took a look at boost:file_size. It specifies uintmax_t as a return type for the file_size() function. So what do you think of this little patch - replacing size_t for the filesize variables with uintmax_t?

Quick info: I have extended my patch. I hope I find some more time tomorrow to continue and test the changes.


Add v13 pointing to teleport@master

Add v13 to git submodules & config.json
This is for after v12 has been released

Closing as completed in another PR


Issue in executing End2End

What operating system are you using?
Linux
What version of Node.js is on your system?
v8.11.2

I have successfully build this sample but when it comes to interaction with the fabric console UI i get
<--------------------------------LOGS---------------------------->
Gtk-Message: GtkDialog mapped without a transient parent. This is discouraged.
(electron:3130): dconf-WARNING **: failed to commit changes to dconf: Unknown or unsupported transport 'disabled' for address 'disabled:'
(electron:3130): dconf-WARNING **: failed to commit changes to dconf: Unknown or unsupported transport 'disabled' for address 'disabled:'
(electron:3130): dconf-WARNING **: failed to commit changes to dconf: Unknown or unsupported transport 'disabled' for address 'disabled:'
(electron:3130): dconf-WARNING **: failed to commit changes to dconf: Unknown or unsupported transport 'disabled' for address 'disabled:'
Error creating proxy: Unknown or unsupported transport 'disabled' for address 'disabled:' (g-io-error-quark, 13)
Error creating proxy: Unknown or unsupported transport 'disabled' for address 'disabled:' (g-io-error-quark, 13)
Error creating proxy: Unknown or unsupported transport 'disabled' for address 'disabled:' (g-io-error-quark, 13)
Error creating proxy: Unknown or unsupported transport 'disabled' for address 'disabled:' (g-io-error-quark, 13)
Gtk-Message: GtkDialog mapped without a transient parent. This is discouraged.
Gtk-Message: GtkDialog mapped without a transient parent. This is discouraged.
Gtk-Message: GtkDialog mapped without a transient parent. This is discouraged.
<--------------------------------LOGS---------------------------->
Can you specify which all inputs must be given to
*Connection Profile
*User Management
*Channel management
*Chaincode Management

this project is no longer maintained, thanks for your attention


fix: add getMetaPropertiesMap() to code scanner

Description
Define getMetaPropertiedsMap for code scanner. Now the widget can reset using resetWidget()
Fixes #16900
Type of change

Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Manually

Drop a code scanner widget on the canvas
Use a text widget to bind its internal property CodeScanner1.value
Scan a QR code and observe text widget display the stored value of the code scanner
Use a button widget to reset the code scanner and observe that the action is executed but the internal properties are not reset

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes

Tested this PR and LGTM

Tested resetWidget functionality
Tested functionality on adding widgets on container widgets and modals as well

/ok-to-test sha=b3bb5ed

/ok-to-test sha=cdf081a

/ok-to-test sha=028e2be

/ok-to-test sha=cb24acf

/ok-to-test sha=3d56401

/ok-to-test sha=a5b4a8d

/ok-to-test sha=2f3ebc9


fix(native_image): fix C++ toolchain env setup

Instead of relying on the default shell env, get the environment
variables declared by the C++ toolchain. On macOS, additionally use
apple_support to pass in DEVELOPER_DIR.
Since GraalVM sanitizes the environment, all variables are translated
into -E flags.
Fixes #67

Stacked on #70 and #71

@keith This is what I came up with based on your diff. It works in Bazel CI :-)

I can see how lambda and nested functions in general are problematic on Bazel 4. Unfortunately loading them conditionally isn't possible without either splitting out the non-legacy rules or using a Bazel version check in a repository rule and generating code.
We could also mimic what apple_support.run does and then directly control the way environment variables are passed to ctx.actions.run. Maybe @keith also knows a better solution.

@fmeum see #80, i've performed the rule split and refactor in anticipation of that same problem. bazel4 is fixed, mac tests are working, and that PR now includes this one as well as #73
i hope we can move discussion to #80 where we can prep a release at 0.10.x 😄
as such closing this (but only as long as that PR works for your needs @fmeum -- if you hit issues we can always reopen this one.)


Add blog post about avoiding the default address when using kubeadm

Add blog post describing all the steps to take when using kubeadm to
create a cluster in which each node's default address must not be
used in any kubernetes configuration.

/hold
For tech review. After a quick look I think some of the exaples are not a
best practice.

instead of asking users to pin IPs in every single component for multiple nodes (based on blog posts like this one) should we instead write a guide around a k8s compliant networking interface setup for nodes to make cluster management based on the default IP detection just simpler?

you can't standardise network, that is the main problem, cloud environments kind of did that, one interface one subnet, easy  peasy, once you want to use multiples interfaces or subnets, you have to do proper network planning based on your setup ... and each setup is different :shrug:
There are good practices in networking for multihomed setups though, but that depends a lot on how you setup your network:

is each interface for network segmentation, i.e. services, storage, management networking, ... from which interface/s do you want to access the services?
is each interface for providing HA? Layer2 or Layer3 ?
Actually, for Layer3 HA, when the host uses link-local for the interfaces, and a loopback global address, it picks the loopback address, that is the best practices for these kind of setups https://github.com/kubernetes/kubernetes/pull/95790 when you use a routing protocol.
is one interface just for management or simlpe connectivity and the other for kubernetes, like in this setup, my recommendation here is to use one VRF per each interface, so you can have 2 default gateways, that is also best practices in all networking setups, since one interface is totally unrelated to the other one. https://lwn.net/Articles/632522/

you can't standardise network, that is the main problem, cloud environments kind of did that, one interface one subnet, easy peasy, once you want to use multiples interfaces or subnets, you have to do proper network planning based on your setup ... and each setup is different

the current "default gateway" IP-detection approach in components makes sense to me.
if i were to create my self-hosted cluster today, i can think of a number of ways to make my cluster suite the k8s IP detection, but still secure it at a router or with firewalls on individual nodes.
i was wondering if we need a page about best practices of sorts.
maybe it exists already.

i was wondering if we need a page about best practices of sorts.

There's the section https://kubernetes.io/docs/setup/best-practices/

There's the section https://kubernetes.io/docs/setup/best-practices/

thanks, looks like it does not have notes about network setup yet.

another instance of a custom network setup from today:
https://github.com/kubernetes/kubeadm/issues/2506

Hi folks
Is the hold from https://github.com/kubernetes/website/pull/28331#issuecomment-857235128 still appliable?

i think as per the discussion above we need a blog post or a page that:

talks about best practices of setuping the networking of k8s nodes to accommodate the default k8s IP detection.
covers the users can fallback to customizing addresses for components; this is a compromise but not ideal as it results in a more fragile setup (e.g. the current content talks about that):

gives examples with kubeadm, kubelet, etc (there were some content update recommendations in the reviews above)

Given the concerns so far from SIG Cluster Lifecycle I'm going to close this PR
The Kubernetes project would still welcome a blog article that gives endorsable information about how to manage issues around this aspect of networking. @MikeSpreitzer thanks for your work on this so far, too.
/close


[Mod compatibility]: Wrong clientside block reach with Pehkui

See https://github.com/Virtuoel/Pehkui/issues/229

This can be closed here, it's definitely on Pehkui's end.


Update cachegrind.yml add env

Valgrind Results:
==3815== Cachegrind, a cache and branch-prediction profiler
==3815== Copyright (C) 2002-2017, and GNU GPL'd, by Nicholas Nethercote et al.
==3815== Using Valgrind-3.18.1 and LibVEX; rerun with -h for copyright info
==3815== Command: target/release/snailtracer
==3815==
--3815-- warning: L3 cache found, using its data for the LL simulation.
==3815==
==3815== I   refs:      456,271,439
==3815== I1  misses:          2,954
==3815== LLi misses:          2,636
==3815== I1  miss rate:        0.00%
==3815== LLi miss rate:        0.00%
==3815==
==3815== D   refs:      229,452,234  (152,511,516 rd   + 76,940,718 wr)
==3815== D1  misses:        350,019  (    210,222 rd   +    139,797 wr)
==3815== LLd misses:        137,004  (      3,754 rd   +    133,250 wr)
==3815== D1  miss rate:         0.2% (        0.1%     +        0.2%  )
==3815== LLd miss rate:         0.1% (        0.0%     +        0.2%  )
==3815==
==3815== LL refs:           352,973  (    213,176 rd   +    139,797 wr)
==3815== LL misses:         139,640  (      6,390 rd   +    133,250 wr)
==3815== LL miss rate:          0.0% (        0.0%     +        0.2%  )


Store employee_id after employee_request approval

As a admin
I want the employee_id to be stored in the il.employee_request table after employee_request approval
So that I can easier investigate issues

suggest to store it in jsonb, not new column.
Currently there is no fulfilled column on dev env.

there is employee_id in data column and as i understood, its used to update existing employee on employee_request approval, so that is different field


style: Fix HTML repr styling

Puts the icon and name of an element in the HTML repr title on one line
Also makes title larger

Before:

After:

Puts the icon and name of an element in the HTML repr title on one line

But ... they were already in one line before.

Also makes title larger

It's smaller now.
What exactly were you attempting to fix?


Problem if different accounts use the same name

It should be possible to add 2FA for accounts which use the same name. Google and Amazon for example both use your email adress but have different keys.
As I am already using Google Authenticator for my gmail adress it is not possible to use this app for my amazon account aswell. When I try to do so I get the error message: "Sorry, this name is already in use." and "(1)" is added to the account name for amazon. Therefore the generated key is not working.

I hope this will helpe out

Could you clarify the problem? langfingaz seems to be saying you can't add accounts with the same name, but also saying that it's actually added, but with "(1)" appended to the name. Is that right?
The name is not part of the TOTP algorithm, so if the codes also don't work, then that's a completely separate issue.

The name is not part of the TOTP/HOTP algorithm,

Thanks for pointing that out Thomas. As this issue was opened quite a while ago, I don't remember the exact details anymore, but to me it seemed as if somehow because of the appended " (1)" to the name of the account the generated code was different and therefore not working. But probably the error was somewhere else.
As you can create multiple accounts with the same name and rename them later to your liking by long-pressing on them, this issue can be closed then.

you closed it without solving it?
On Mon, 15 Oct 2018 at 19:55, langfingaz<EMAIL_ADDRESS>wrote:

Closed #641 https://github.com/google/google-authenticator/issues/641.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/google/google-authenticator/issues/641#event-1904659530,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AqFUDOKAoUTig72-ikttvV_BmY-HTw6Sks5ulL31gaJpZM4T_sUl
.

--

Hub Authentic
A Division of Authentic Sparrows Limited
Phone: +254 795 333932
email<EMAIL_ADDRESS><EMAIL_ADDRESS>

Original bug filer closed it. Who am I to argue.
Feel free to file another bug explaining what the problem is, since langfingaz doesn't seem to have (much of) one.

I closed it because you can indeed use this app to generate codes for an Google-account and an Amazon-account at the same time (as opposed to what I wrote when I opened this issue). Yesterday I manually added two accounts with the same secret key but different names - and for both the generated codes are the same. So the solution is to manually give your accounts meaningful names if they were automatically added as "email" and "email (1)".
Maybe you have a different problem, but in that case feel free to open another issue for that specific problem.
Greetings and good luck,
Daniel

that's okay. thanks.I will open a new one
On Wed, 17 Oct 2018 at 16:17, langfingaz<EMAIL_ADDRESS>wrote:

I closed it because you can indeed use this app to generate codes for an
Google-account and an Amazon-account at the same time (as opposed to what I
wrote when I opened this issue). Yesterday I manually added two accounts
with the same secret key but different names - and for both the generated
codes are the same. So the solution is to manually give your accounts
meaningful names if they were automatically added as "email" and "email
(1)".
Maybe you have a different problem, but in that case feel free to open
another issue for that specific problem.
Greetings and good luck,
Daniel
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/google/google-authenticator/issues/641#issuecomment-430623989,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AqFUDLNqP-nyQvHjpag0LyfklDPeV3SGks5uly3ZgaJpZM4T_sUl
.

--

Hub Authentic
A Division of Authentic Sparrows Limited
Phone: +254 795 333932
email<EMAIL_ADDRESS><EMAIL_ADDRESS>