[BUG] Rancher 2.7.5 Active Directory authentication fails completely in Rancher 2.7.5 due to wrong objectGUID escaping

Rancher Server Setup

Rancher version: 2.7.5
Installation option (Helm Chart): K8S 1.24.x RKE1
Proxy/Cert Details:

Information about the Cluster

Kubernetes version: 1.24.x
Cluster Type (Local/Downstream): Local

User Information

What is the role of the user logged in? (Admin/Cluster Owner/Cluster Member/Project Owner/Project Member/Custom)

All users are affected!

Describe the bug
After upgrading to Rancher 2.7.5 (from 2.7.4) LDAP based login using Active Directory integration fails for all users.
To Reproduce
Upgrade to 2.7.5 and then login with a fresh browser.
Result
Login failure. In Rachner log (GUID data removed):
LDAP Result Code 201 Filter Compile Error: ldap: invalid characters for escape in filter: encoding/hex: invalid byte: U+004E N
Expected Result
Login success
Additional context
The following change has introduced to problem:
https://github.com/rancher/rancher/commit/cdd90ea6c687d8c83cfd0289e51be32da5c21d14
I think the problem source is that guidString := html.EscapeString(fmt.Sprintf("%x", entry.GetRawAttributeValue(common.AttributeObjectGUID))) is used to build an URL from the objectGUID value. This might result in a string that is not fully hex encoded. All our objectGUIDs contain the "N" byte with hex value '4E'. The HTML escaping might not escape this byte and then when it is used later in LDAP the filter string will contain "...\N..." which is not a proper escaping and leads to the above noted error message. This is still an assumption, because I have not understood the relevant code fully yet, but I am pretty sure, that it points at least in the right direction.

@FFock Do you have an example GUID from a test system or any log messages?  Just an example of the format is necessary, I don't need a real one.

Hi,
I just updated to Rancher v2.7.5 from v2.7.2 and this change completely break auth against AD. I don't expect breaking change in patch update. I am using: https://registry.terraform.io/providers/rancher/rancher2/latest/docs/resources/auth_config_activedirectory
which uses activedirectory_group:// or activedirectory_user:// and any other resources use the same approach. Any idea?
It is not manageable to use GUIDs here.
Thank you.

@FFock Do you have an example GUID from a test system? Just an example of the problematic GUID is necessary, I don't need a real one. My test system may be creating GUIDs in a different way, so I want to be sure that the fix will cover all possible GUIDs that we will encounter.

@crobby The format seems to be very simple:
16-n bytes (the length varies between users), where the sequence "ef bf bd" (hex) occurs very often. Inbetween there is binary data where some of the bytes represent ASCII characters.

This is bug is more fatal than I thought initially, because most users cannot login even after having rolled back to Rancher 2.7.4. It seems that a migration of the user identifier from DN to objectGUID had already been running in the background and now all migrated users cannot login anymore.
We really need very urgently a fix for this.

Even after having restored the Rancher local cluster to the state before the 2.7.5 upgrade does not fix the login issue. We now have a lot of users with GUID user identifier, which cannot be deleted:
[ERROR] Unknown error: DN ended with incomplete type, value pair
On the other hand, readding the users with their DN user identifier, does not work either:
[INFO] Creating user for principal activedirectory_user://CN=Name\, Forename (123456),OU=99,OU=orgunit,DC=somedc,DC=com
2023/07/04 10:04:08 [ERROR] error syncing 'c-s484l/crtb-4n3cp': handler mgmt-auth-crtb-controller: users.management.cattle.io "u-4g51sghhql" already exists, handler auth-prov-v2-crtb: roletemplatebinding doesn't have any subject fields set: crtb-4n3cp, requeuing

We also encounter this bug after upgrading from 2.7.4 to 2.7.5 We have a lot of users that have broken permissions or can't log into Rancher at all.
I agree that this is a major bug! We also opened a critical issue in the SUSE customer center.

It is also no longer possible to add users to projects, here is the error message in the frontend:

We have the same here after going from 2.7.3 to 2.7.5.
But we are still able to add AD Groups and users in AD Groups are still able to login.
Opened a issue with SUSE too.

https://github.com/rancher/rancher/issues/37994#issuecomment-1610906320

Even after having restored the Rancher local cluster to the state before the 2.7.5 upgrade does not fix the login issue. We now have a lot of users with GUID user identifier, which cannot be deleted:
[ERROR] Unknown error: DN ended with incomplete type, value pair

There is a workaround for the above problem, users with GUID identifier have to be deleted on "Users & Authentication" and then the corresponding entries on down-stream cluster are deleted automatically too. After that, you can re-add those users on downstream cluster level again. Then those are again working with DN identifier on Rancher 2.7.4.

Even after having restored the Rancher local cluster to the state before the 2.7.5 upgrade does not fix the login issue. We now have a lot of users with GUID user identifier, which cannot be deleted:
[ERROR] Unknown error: DN ended with incomplete type, value pair

There is a workaround for the above problem: Users with GUID identifier have to be deleted on "Users & Authentication" and then the corresponding entries on down-stream cluster are deleted automatically too. After that, you can re-add those users on downstream cluster level again. Then those are again working with DN identifier on Rancher 2.7.4.

I can confirm that this is a workaround for users who can't log in - but not a satisfying one. You will have to re-configure single permissions to projects on all downstream clusters.

We now are facing another related problem: Users which had been affected by this issue during the 2.7.4->2.7.5 upgrade attempt cannot use scoped API keys (tokens) anymore after the rollback of the local Rancher HA 2.7.5 cluster to 2.7.4 through server restore.

QA notes:
QA scenarios-

user upgrades from 2.7.4 to 2.7.5 with nested OUs and users in it- confirm nested OU compatibility
user upgrades to 2.7.5 and then creates a nested OU and create users into the nested OU. log in as user
user upgrades to 2.7.5 and then edits a nested OU and moves users around OU. log in as user
user upgrades to 2.7.5 and then deleted a nested OU and move the users to the base OU. log in as user

Please take also API changes into consideration. Currently it breaks all scripts and/or terraform modules because it requires GUID instead of DN. GUIDS in API or terraform are very hard to maintain.
Thank you

Very frustrating to have hit this bug having been forced to upgrade to 2.7.5 from 2.7.3 due to the OOM bug, in additional to having to hold off upgrading to K8S 1.24 due to the high CPU bug! Seems to be a very buggy trend here!

We are also suffering this issue

We are also suffering this issue and can see for each user logging in a new account is created.

Deleting the older account seems to restore the ability to login to UI for the user, but then all stored KUBECONFIG will need to be updated as the tokens will then be invalid.

@geoff-carr-bzy yes exactly and I don't really want to ask all users to update their KUBECONFIG due to a bug.
On the other hand, if you delete the newer one and the users try again to login in the UI, this also works.

Same problem here. Since the update to 2.7.5, I couldn't add existing and new users to projects. I also got the error message 'No identities can be retrieved'. I were able to add groups to the 'who is authorized to login' part under 'Auth-Provider', but not a single user, just groups.
In the logs of the rancher pods, I saw that it searched for something like this: (&(objectClass=person)(guid=\..\..\..\)) where the \ parts seem to be escaped characters. A little confusing is, that the actual guid is something like aabbccdd-aabbcc-aabbccdd, but the escaped and searched one was like ddccbbaa-ccbbaa-ddccbbaa ... is this the right thing to do?
I switched to the OpenLDAP auth provider. Regarding the source code, it does things differently for getPrincipal and RefetchGroupPrincipals by do not setting the ldap search level to SingleLevel. Is this maybe a thing?
After the switch, everything worked as before, but I had to set the permission per user per project again... manually.
I hope it helps somehow.

Same here, we are stuck in 'No identities can be retrieved'. Any good workaround, besides moving authentication to AD groups (currently they are working)?

As I wrote, I changed the auth provider to OpenLDAP and can (again) authorize through users and groups, as well as assign single users to groups etc. But I can think of scenarios where this provider change isn't suitable, since all existing permissions are gone afterwards.

As far as I understand, changing the auth provider will need to recreate all the current projects users and groups management; which is not possible in a production environment.

Exactly. As far as I understand from the last commit of the source code, they changed the ldap search scope. I don't know why, but maybe changing this back, could solve the problem without changing the auth provider.

We're also facing the same issue with our ActiveDirectory auth backend setup. To summarize, as I haven't seen all of the issues reported in one comment:

Rancher tried to do the conversion of users with the old DN-based principalIds to the new GUID one. For some users it worked, so that these now only have the new one. For some it apparently failed, ending up with two users for the same person - the old DN-based one and the new GUID-based on.
Project and Cluster role template bindings were not properly updated for the users where the migration failed, some are still pointing to old DN-based users.
My guess: when a user tries to log in, the auth backend is using the new GUID-based users regardless whether conversion failed or not. As not all role template bindings were updated, these users lose their permissions as the bindings are still referencing the old DN-based users.
Why exactly it's failing I'm not sure. We're seeing the following logs repeating all the time for different IDs - some of those log entries are probably also caused by users being removed from AD at some point but the role binding still being there.

rancher-55d968698d-lm487 rancher 2023/07/12 11:56:52 [ERROR] Error refreshing token principals, skipping: Cannot locate user information for (&(objectClass=person)(objectGUID=\c0\a5\6a\7d\a2\00\2e\4d\a2\07\e6\15\59\37\99\c5))
rancher-55d968698d-lm487 rancher 2023/07/12 11:56:52 [ERROR] error syncing 'user-2jtvq': handler mgmt-auth-userattributes-controller: No identities can be retrieved, requeuing
rancher-55d968698d-lm487 rancher 2023/07/12 11:56:53 [ERROR] Error refreshing token principals, skipping: Cannot locate user information for (&(objectClass=person)(objectGUID=\4f\60\0f\16\59\59\73\46\a7\1e\0a\8c\a5\95\b8\8a))
rancher-55d968698d-lm487 rancher 2023/07/12 11:56:54 [ERROR] error syncing 'u-ii5rhjptp4': handler mgmt-auth-userattributes-controller: No identities can be retrieved, requeuing
rancher-55d968698d-lm487 rancher 2023/07/12 11:56:59 [ERROR] Error refreshing token principals, skipping: Cannot locate user information for (&(objectClass=person)(objectGUID=\70\fa\14\2e\3b\03\82\4f\b0\5f\14\43\ea\d0\2e\c5))
rancher-55d968698d-lm487 rancher 2023/07/12 11:56:59 [ERROR] error syncing 'u-3pf7cvyg6r': handler mgmt-auth-userattributes-controller: No identities can be retrieved, requeuing
rancher-55d968698d-lm487 rancher 2023/07/12 11:57:08 [ERROR] Error refreshing token principals, skipping: Cannot locate user information for (&(objectClass=person)(objectGUID=\9e\d8\ac\74\d3\84\0f\41\9d\d7\fe\be\2b\0c\a5\db))
rancher-55d968698d-lm487 rancher 2023/07/12 11:57:09 [ERROR] error syncing 'u-6fcsvou6am': handler mgmt-auth-userattributes-controller: No identities can be retrieved, requeuing
rancher-55d968698d-hflzl rancher 2023/07/12 11:57:11 [ERROR] Unknown error: No identities can be retrieved
rancher-55d968698d-lm487 rancher 2023/07/12 11:57:11 [ERROR] Error refreshing token principals, skipping: Cannot locate user information for (&(objectClass=person)(objectGUID=\01\1c\d2\16\77\b2\e4\48\94\37\fd\8f\25\54\20\79))
rancher-55d968698d-lm487 rancher 2023/07/12 11:57:12 [ERROR] error syncing 'u-kbcfbecaef': handler mgmt-auth-userattributes-controller: No identities can be retrieved, requeuing
rancher-55d968698d-lm487 rancher 2023/07/12 11:57:12 [ERROR] Error refreshing token principals, skipping: Cannot locate user information for (&(objectClass=person)(objectGUID=\b1\f0\0c\ef\2b\2f\62\4c\8a\2c\0c\cb\4c\55\ef\e4))
rancher-55d968698d-lm487 rancher 2023/07/12 11:57:12 [ERROR] error syncing 'u-kioxa7doxo': handler mgmt-auth-userattributes-controller: No identities can be retrieved, requeuing
rancher-55d968698d-lm487 rancher 2023/07/12 11:57:22 [ERROR] Error refreshing token principals, skipping: Cannot locate user information for (&(objectClass=person)(objectGUID=\56\11\86\ac\9b\9c\8b\45\ae\09\3e\c7\a2\02\0e\15))
rancher-55d968698d-lm487 rancher 2023/07/12 11:57:23 [ERROR] error syncing 'u-kutrdremqy': handler mgmt-auth-userattributes-controller: No identities can be retrieved, requeuing
rancher-55d968698d-lm487 rancher 2023/07/12 11:57:25 [ERROR] Unknown error: No identities can be retrieved
...
rancher-55d968698d-lm487 rancher 2023/07/12 11:57:46 [ERROR] error syncing 'u-7ff5ktddfv': handler mgmt-auth-userattributes-controller: No identities can be retrieved, requeuing
rancher-55d968698d-lm487 rancher 2023/07/12 11:58:30 [ERROR] Error refreshing token principals, skipping: Cannot locate user information for (&(objectClass=person)(objectGUID=\c9\93\8b\70\00\1f\41\4e\88\b9\40\7f\ae\c4\a0\54))
rancher-55d968698d-lm487 rancher 2023/07/12 11:58:30 [ERROR] error syncing 'u-ln4b4zpomm': handler mgmt-auth-userattributes-controller: No identities can be retrieved, requeuing
rancher-55d968698d-lm487 rancher 2023/07/12 11:58:32 [ERROR] Error refreshing token principals, skipping: LDAP Result Code 201 "Filter Compile Error": ldap: invalid characters for escape in filter: encoding/hex: invalid byte: U+004E 'N'
rancher-55d968698d-lm487 rancher 2023/07/12 11:58:32 [ERROR] error syncing 'u-d7v2tqctgm': handler mgmt-auth-userattributes-controller: NotFound 404: <redacted> not found, requeuing
rancher-55d968698d-lm487 rancher 2023/07/12 11:58:34 [ERROR] Error refreshing token principals, skipping: LDAP Result Code 201 "Filter Compile Error": ldap: invalid characters for escape in filter: encoding/hex: invalid byte: U+004E 'N'
rancher-55d968698d-lm487 rancher 2023/07/12 11:58:34 [ERROR] error syncing 'u-3uatfpifxg': handler mgmt-auth-userattributes-controller: NotFound 404: <redacted> not found, requeuing
rancher-55d968698d-lm487 rancher 2023/07/12 11:58:39 [ERROR] Error refreshing token principals, skipping: LDAP Result Code 201 "Filter Compile Error": ldap: invalid characters for escape in filter: encoding/hex: invalid byte: U+004E 'N'
rancher-55d968698d-lm487 rancher 2023/07/12 11:58:40 [ERROR] error syncing 'u-ncdwezl7ux': handler mgmt-auth-userattributes-controller: NotFound 404: <redacted> not found, requeuing
rancher-55d968698d-lm487 rancher 2023/07/12 11:58:41 [ERROR] Error refreshing token principals, skipping: LDAP Result Code 201 "Filter Compile Error": ldap: invalid characters for escape in filter: encoding/hex: invalid byte: U+004E 'N'

Does downgrading try to convert back to the old principal IDs? My installs seem to be completely messed up at this point even after downgrading etc :(

We are also affected.  Fortunately, we upgraded out test environment first.  We did postpone our production upgrade due to Kubernetes 1.24 high CPU bug with RKE and then the cattle cluster agent memory leak in 2.7.2+.  Was hoping on 2.7.5, but this is a real show stopper.

For my part none of them appear to have non-ASCII chars in the DN.

how can it be that this issue exists for 2 weeks and no hotfix has been released? my client is also affected by this.

Is this affecting all users or only ones with non-ASCII characters in their DN?

No, as I wrote above in this ticket, it seems that the GUID migration/usage is failing if the GUID of a user contains at least one byte that represents a character that does not need to be escaped in an URL (i.e., some letter like 'N' or 'e').

@crobby  please revert the change that caused this issue and release a fix asap

@crobby please revert the change that caused this issue and release a fix asap

I think at least for all users, that have already tried to install 2.7.5 somewhere with several downstream clusters active, reverting back to 2.7.4 will not solve the issue created by the upgrade. I did that already using a full HA Rancher 2.7.4 pre-upgrade backup, but the issue now is in the API key handling/tokens of the downstream cluster users (scoped keys are no longer working for users affected by failed GUID migration - even after deletion and recreation of those users!).
So far, we have not found and are not aware of any workaround. So we need a forward fix that restores full AD functionality with 2.7.6+.

@crobby please revert the change that caused this issue and release a fix asap

I think at least for all users, that have already tried to install 2.7.5 somewhere with several downstream clusters active, reverting back to 2.7.4 will not solve the issue created by the upgrade. I did that already using a full HA Rancher 2.7.4 pre-upgrade backup, but the issue now is in the API key handling/tokens of the downstream cluster users (scoped keys are no longer working for users affected by failed GUID migration - even after deletion and recreation of those users!).
So far, we have not found and are not aware of any workaround. So we need a forward fix that restores full AD functionality with 2.7.6+.

I agree, just reverting these settings won't help any customer that has already upgraded Rancher to 2.7.5. The fix must contain a logic that reverts the already migrated user accounts to their original state. Or at least there should be a release without this change to benefit from the fixes with the cluster agent and cilium bugs there were included in the 2.7.5.

Is this being actively investigated ? We were eagerly awaiting this release to fix the high memory consumption bug on Rancher pod and cattle-cluster-agents, as well as introducting k8s 1.25 support to our teams.  We won't deploy 2.7.5 on our production instance because of this issue.  Still running 2.6.6 as it is the most stable release we experienced so far.

@crobby  could you please make a statement

moving it to Review after an offline chat with @crobby. Waiting for the PR to be merged ^

/backport v2.7.6

QA Test plan WIP:
the bug-
in 2.7.5 we made a change to the principle field on AD users, switching them from distinguished name to GUID. for a couple reasons this process can fail. if the user tries to login before their principal has been migrated, they will lose their permissions.
reproduction steps-

stand up a 2.7.4 rancher
configure AD
log in with multiple nested OU users
give the users permissions to projects
delete one of the users out of the AD
upgrade the server to 2.7.5
log in as one of the immigrated users
a. to check which users have been migrated, open kubectl
kubectl get users -o yaml | grep activedirectory
b. located a user with a principle ID that hasn't been migrated
log in with the user that failed to migrate

bug- user does not have proper permissions and user is duplicated
bug fixes that should be verified-

test reproduction steps above, validate that the migration works as expected and users being deleted out of ADs do not result in a migration failure. confirm user is not duplicated
test reproduction steps above with a high volume of users (500). -- confirm if we will add release note saying how long much time to give the migration before attempting login. confirm all users migrate their IDs as expected.
how to test the cleanup script tool. work with Chad once he has created it.

targeted regression areas-

Bug-
in 2.7.5 we made a change to the principle field on AD users, switching them from distinguished name to GUID. for a couple reasons this process can fail. if the user tries to login before their principal has been migrated, they will lose their permissions.
reproduction steps-

stand up a 2.7.4 rancher

configure AD

log in with multiple nested OU users

give the users permissions to projects "p1"

delete one of the users out of the AD

upgrade the server to 2.7.5

log in as one of the immigrated users

a. to check which users have been migrated, open kubectl

kubectl get users -o yaml | grep activedirectory

confirm logged in as migrated user works as expected

locate a user with project permissions and with a principle ID that hasn't been migrated

log in with the user that failed to migrate

confirm the user doesn't have project permissions and is duplicated.

Bug

user does not have proper permissions and user is duplicated
logs throw this error Login failure. In Rancher log (GUID data removed): LDAP Result Code 201 Filter Compile Error: ldap: invalid characters for escape in filter: encoding/hex: invalid byte: U+004E

bug repro documentation

per screenshot, you can see we stopped the migration causing only some principle IDs to be converted. further down the screenshot shows user10's display issues due to failed migration, as well as its lack of project permissions when logged in as duser10. additionally there is a pic of the error code in the client reported bug, as well as picture proof of duser10 duplicating upon attempting to log in.

Here are the revert PRs:
PRs:
https://github.com/rancher/rancher/pull/42169
https://github.com/rancher/rancher/pull/42167
https://github.com/rancher/rancher/pull/42168
And the issue for reverting the changes: https://github.com/rancher/rancher/issues/42161

Does anyone have an interim solution for this? It seems like I can't go backward and while we're waiting for 2.7.6 there's nothing to go forward to.

Does anyone have an interim solution for this? It seems like I can't go backward and while we're waiting for 2.7.6 there's nothing to go forward to.

That won't help you at all, but just for completeness sake: we've switched auth to AzureAD as our enterprise also makes use of Azure and has synchronisation set up. AAD doesn't have this issue, but we obviously still had to rebuild all permissions. Also has the positive side effect of giving us the option to enforce MFA (from AAD side).

What won't help me?

What won't help me?

My comment how we solved this for us.

@AndrewHoffmanQA I installed 2.7.6-rc5 (form 2.7.5) and then run scenario 1. You say

his display all user's principle IDs, confirm they are GUID not DS. GUID ID example- 4d80209a63f84309be662a208d5613f0

In my case, the users have a GUID. Still I can successfully login with my user and have the required permissions.
I also delete my 2nd user account, login again and this also only creates one user (but with a DS, not a GUID)

We updated to Rancher 2.7.6 and the issue seems fixed. Users are there only once using a DS (instead the new GUID)

Here as well so far on our test environment.  Updated to 2.7.6 and all AD users can now log in. They are also seen in Rancher by DN instead of GUID.  They can also be added to RBAC without any problem.


implementing cwd attribute for task

fixes #309
Note: the 'cwd' cannot be changed with schtasks but can be changed editing task xml as done here.

LGTM other than my minor comments :+1:

I vote for this to be merged, It is biting us currently when no cwd is set.

:+1: Merge it


RTA-177. Only send the LCDuplication message if the config is actually different.

Codecov Report

Merging #10 into master will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #10      +/-   ##
==========================================
+ Coverage   93.69%   93.71%   +0.01%
==========================================
  Files          28       28
  Lines         714      716       +2
==========================================
+ Hits          669      671       +2
  Misses         45       45

Impacted Files
Coverage Δ

src/live-connect.js
89.61% <100.00%> (+0.27%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dfb2efe...90bef4e. Read the comment docs.


126384815: As a user, I can update a schedule w/ recurring rules

Thought you were talking about the test class method. Yes in the controller should have renamed it after implementing the update functionality. Will make the change in next commit.Thanks.


FilterWarnings allows long errors

doesn't look the nicest, and whilst it does clearly show the user we can't do what they've asked, it might be nicer if it said

There are no Chemical Physics, Circuits, Fields or Waves questions in level 6

or, more generally things like:

There are no x, y or z questions in levels i or j
There are no x questions in level k

Yes, it would be nice, but the text generation is already ludicrously complicated. It does what you ask for multiple levels, just not multiple topics.


Intent is deleting after adding advanced mode

https://github.com/warden-protocol/wardenprotocol/assets/59832414/7c14c973-3f6d-4d32-b169-5726e262f091

Not reproduced


Feat: Theme for right side items

Requested feature
Allow configuring theme for right-side items.
Motivation
I'm trying to port my lightline setup to lualine, but it doesn't seem to be possible to theme the right hand side -- so elements at the far right will always look off.
For example, the left-most element usually displays the mode, so it makes sense for that one to stand out a lot, however, the right-most element seldom needs to stand out so much.

@WhyNotHugo with #238 merged you can now theme the right side separately . Just define x,y,z along with a,b,c in your themes.


Bug: Editor depends on white-space: pre-wrap for spacebar to work

Repro

Remove whiteSpace: 'pre-wrap' from the example app
yarn dev
Type ‘Hello world’

Observe that there is no space between ‘Hello’ and ‘world’ and that the text in the view model becomes "Helloworld "

We have a use case to remove end-of-spaces and would like to use white-space: normal. Can we reopen this issue or should I create a new one?


to_json() creates str

Given a JSON example (Python 3.7.4 for all):
json_string = """
{  "entity": "ENTITY" }
"""
entity = Box.from_json(json_string)
print(entity)
print(type(entity))

I get,
{'entity': 'ENTITY'}
<class 'box.box.Box'>

Doing the same thing with YAML, given,
yaml_string = """
entity: "ENTITY"
"""

entity_temp = Box.from_yaml(yaml_string)
entity = entity_temp.to_json()
print(entity)
print(type(entity))

I get,
{"entity": "ENTITY"}
<class 'str'>

In the first example I can use the entity variable directly with requests.put(...,json=entity,...). The second one I have to json.loads()... which is pretty much why I was starting to use Box in the first place.
Your documentation is clear that to_json outputs as a string (or a filename).
Similar to json.load and json.loads, at some point maybe to_json() and to_jsons() might be useful?
Thanks for the useful work on this library. It's handy.

I'm not sure I completely follow. In the second example you seem to be transforming the box to a JSON string unnecessarily? You could do the same thing as you did with the first example and use the box directly, if you are looking for a dict like object.
yaml_string = """
entity: "ENTITY"
"""

entity = Box.from_yaml(yaml_string)
print(entity)   # {'entity': 'ENTITY'}
print(type(entity)) # <class 'box.box.Box'>

@staylorx were you able to figure it out?

More or less. This can be closed. Thank you for looking into it.

From: Chris Griffith<EMAIL_ADDRESS>Sent: Wednesday, March 11, 2020 8:12 AM
To: cdgriffith/Box
Cc: Steve Taylor; Mention
Subject: Re: [cdgriffith/Box] to_json() creates str (#138)
@staylorx were you able to figure it out?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.

Thanks for the reply. A little off topic, but one thing that you did make me think about is that to_json and the other converters can't take an open file handler like json.load can, and might be a nice addition.


Added Atom types to test JSON data.

This adds an [AtomType] property to all types derived of Atom. Don't know any F#, though, so code is probably abysmal.
Fixes #188.

Yeah, I was pretty sure my solution wasn't the best one. It's been years that I even looked at F# and I was astonished I even got something to compile (let alone work).


Add rgee

Insert URLs to the project here:
https://github.com/r-spatial/rgee

[x] The projects is active, documented, open source licensed, shows usage from external parties and is directly targeting environmental sustainability. Find more details in the Contribution Guide.

All issues labeled as 'Good First Issue' of the project listed on OpenSustain.tech will be visible on ClimateTriage.com. This is a great way to welcome new community members to your project.

@csaybar


One item not centerented

Hi ! @lmmenge  &
I am currently trying your lib and it's very awesome !

However, when i have less than 4 items, they are not properly centered :/
![ios simulator screen shot 2015-07-08 16 44 23]
(https://cloud.githubusercontent.com/assets/3285421/8573192/98f7f5d2-2590-11e5-9472-583fecf725b9.png)
Could you please help me to fix them ?

Thanks for the nice comments!
Unfortunately I'm no longer able to spend time on this project, but feel free to fork it and make your changes!


fix: Bb 265 fix soilleaf test data validation

Description
Fix validationSchema for Fields and Soil and general cleanups/enhancements to interfaces.
Type of changes
Please delete options that are not relevant.

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Checklist

[x] I have read the CONTRIBUTING doc
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] Any dependent changes have already been accepted and merged

Further comments

Thanks for the PR!
Deployments, as required, will be available below:

Frontend
Backend

Please create PRs in draft mode.  Mark as ready to enable:

Analysis Workflow

After merge, new images are deployed in:

Merge Workflow

@kcaparas1630 Fixed :smile:


chore: bdd-sbrp-import-1585113547 to 0.0.1

chore: Promote bdd-sbrp-import-1585113547 to version 0.0.1

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers:
If they are not already assigned, you can assign the PR to them by writing /assign  in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


small caps and old style numbers not rendering properly

The small caps and old style numbers in http://mcc.id.au/temp/authoring-tool-chapter-20120229.pdf don't render correctly. Possibly ligatures, too.

http://gee.cs.oswego.edu/dl/papers/aqs.pdf seems to suffer from this as well.


Fine-tuning on a 24GB GPU?

Hello,
I've been fine tuning SDXL on a 24GB 4090 card for a while now, and I get good results from this. But I'd like to upgrade to a newer model like Lumina.
I think that you do support single-GPU fine tuning of your Lumina_T2X_Next model, but currently it doesn't fit on a 24GB GPU, is that correct?
This image in your readme suggests that you support smaller parts than your standard Lumina_T2X_Next model currently uses, such as CLIP-L/G, an 0.6B DiT model, and the Stable Diffusion 1.5 VAE:

Would I need you to release a specific cut-down model that use these smaller parts if I wanted to train Lumina-2TX on my 24GB GPU, or is this something I could get working myself with what you've already released?
Thanks for any information.

Thanks for you advice. Currently we are working on releasing a PEFT version of 2B Lumian-Next. Besides, we are experimenting with 800M Lumina-Next.
Stay tuned.


MINOR: fix typo in config for eos-v2 docs of the upgrade guide

One of the configs has a typo and should have been exactly_once _v2 rather than just exactly_once

Alright I'm just going to merge this since it's a trivial typo fix. Ran the streams tests locally as a sanity check and we're all good

Merged to trunk and cherrypicked to 3.0


As a user (any role) I want to view Material Full view page so that I can get acquainted with the content

Changed by change request #311 (27/05/21)
User (any role) should view material in Post Page.
Article Page should contain:

Expert section.
Article section.

Expert section includes:

Author's picture.
First name, last name.
City and place of work.

Click on “First name, last name” should redirect to "Expert Page".
Article section includes:

Article title.
Tags.
Topic.
Material.
Date of adding.

Click on "Topic" should redirect to "Topic Page".
For Article page:
Material must contain text and should contain pictures that are provided by the author.
Picture should be named.

For Note page:
Material must contain text and should be limited by number of characters.

AC:

Expert section is displayed.
Article section is displayed.
Click on “First name, last name” should redirect to "Expert Page".
Click on Topic’s value should redirect to "Topic page".

SI:

about Tags // Edited 25.02.2021 by #184
about time of addinf materials // Edited 25.02.2021 by #182

BA checked


Add build metadata to VHD

What this PR does / why we need it: Add info for debugging custom images, including commit ID, build ID and build number.
Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #
Special notes for your reviewer:
If applicable:

[ ] documentation
[ ] unit tests
[ ] tested backward compatibility (ie. deploy with previous version, upgrade with this branch)

Release note:

/lgtm


Set up Kanban Board

https://github.com/jlvFlores/catalog-of-my-things/projects/1
There are three members of this team
@Cisco-the-wayword is working on the tasks assigned to #Team member 1
@jlvFlores is working on the tasks assigned to #Team member 2
@haftamuDesta is working on the tasks assigned to #Team member 3

STATUS: CHANGES REQUIRED ♻
Hi @jlvFlores, @Cisco-the-wayword, and @haftamudesta👋,
Good job so far!
There are some issues that you still need to work on to go to the next project but you are almost there!

Required Changes ♻

[ ] Most of the task cards are missing descriptions. Please make sure all task cards have descriptive descriptions as requested in the project requirements.

[ ] Please make sure all task cards have the number of points in the [Xpt] prefix. That number should indicate the number of points that show how complex the task is. 1 point = 1 hour of estimated work. Currently, no task card has a points prefix.

[ ] Please make sure all task cards have assigned team members as requested in the project requirements. Currently, some task cards are missing assigned members. You should divide the tasks among team members equally based on the point prefix.

Optional suggestions
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.
You can also consider:
N/A
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

Hi Team 👋,
STATUS: APPROVED 😃
In my opinion, your project is complete!  There is nothing else to say other than... it's time to merge it :shipit:
Good luck! 🎉
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.


Feature Request: Support Vault KV Version 2

Are there plans to support Vault's versioned KV store (Version 2) happy to do a proof of concept PR if this is something that konfig would like support in the future.

We don't have an immediate need ourselves, but it would definitely be a feature we would like to include and eventually use, so if you want to do a proof of concept PR, that'd be greatly appreciated!

Sounds great! I'll get started on the POC in a few days.

Fixed by #48


4 new features

message, animate/stopAnimate and progress are 4 features have been added in this branch.
Plz, review then merge if it is approved.

Hey, abdennour!
Thanks! I will get back to your commits when I'll have some spare time.


HTTP_CLIENT_SSL_OPTS removed from documentation

I created a thread on Discourse a while ago (https://discourse.firez.one/t/using-adfs-with-internal-ca-certificate-for-oidc/202) regarding SSL cert trust issues when using an non-publicly-trusted CA which resulted in #996 being opened and PR #1221 being merged to add the HTTP_CLIENT_SSL_OPTS variable.
When I went to switch over to Docker, I decided to perform a clean-reinstall and set up Firezone from scratch.
The current Docs page (https://www.firezone.dev/docs/reference/env-vars/) does not currently reference the HTTP_CLIENT_SSL_OPTS variable, though the variable does work as expected.
Based on what I can tell from the commit history, it looks like #1352 is what removed that variable (and potentially others, the commit is huge) from the documentation.
While it does work today, is the HTTP_CLIENT_SSL_OPTS variable still supported or was it removed from the docs as its functionality is expected to be removed at some point?
If it is supported, should the variable (and potentially whatever other ones were removed) be re-added to the docs page?
Thanks so much!

Thanks for the report! Hmm, I believe that variable should be in the docs. Our env var docs are automagically generated from this file so there must be some bug causing this issue.

This will be largely irrelevant with 1.0 and the cloud-managed web portal. Documentation is being overhauled as well for 1.0, so I'll close this for now and reopen if it's still needed for 1.0.

Ah, nevermind, it looks like the docs were already fixed: https://www.firezone.dev/docs/reference/env-vars#webserver


[Suggestion] Auto optimize the settings for different devices

Suggestion
On mobile it would like set the render distance, vsync etc. to optimize the settings for those devices.
Additional Information
You can change the settings on 1.8.8 from the localstorage entry "_eaglercraftX.g" and on 1.5.2 from "_eaglercraft.g"

I’ll need to look into this more. My suspicion is that local storage is only read from / written to occasionally (with the client storing the state internally) and that would make this fairly annoying to implement in any consistent manner. It’s definitely a good idea though. I’ll play around with it after I finish v3.1, unless someone else wants to take a stab at it


feat: added option to hide semicolons at return of each statement

#31

Codecov Report

Merging #32 (e5613ff) into main (5a81ef1) will not change coverage.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##                main       #32   +/-   ##
===========================================
  Coverage     100.00%   100.00%
- Complexity        96        99    +3
===========================================
  Files              3         3
  Lines            229       234    +5
===========================================
+ Hits             229       234    +5

Impacted Files
Coverage Δ

src/MysqlParser/Parser.php
100.00% <100.00%> (ø)

src/MysqlParser/Processor/CloudSpanner.php
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a81ef1...e5613ff. Read the comment docs.


UNSAFE_componentWillUnmount

Looks like some of the components in this lib declare a lifecycle, UNSAFE_componentWillUnmount, that does not exist. Despite having "will" in its name, componentWillUnmount is a commit phase lifecycle meant for cleaning up (e.g. removing event listeners). It's not "unsafe".
Read about side effects here if you're curious:
https://reactjs.org/docs/strict-mode.html#detecting-unexpected-side-effects
This means that these components will not clean up after themselves and may cause leaks:

https://github.com/akiran/react-slick/blob/97988e897750e1d8f7b10a86b655f50d75d38298/src/slider.js#L70
https://github.com/akiran/react-slick/blob/97988e897750e1d8f7b10a86b655f50d75d38298/src/slider.js#L70

Fixed in https://github.com/akiran/react-slick/pull/1615

Thanks @bvaughn @afc163
Resolved this issue


Customized plugin for perfetto UI

I am wondering whether perfetto UI support customzied plugin, what we want is showing query result in diagram by our customized plugin, e.g. drawing lines to show trend of numbers, even we can save results into csv and work on excel later, but it's not that convience. Will perfetto support such feature (show trend of numbers) or support customized plugins?

A plugin-based architecture is what we are striving towards but the UI needs some refactoring (currently under progress) to get there.

Plugin support has landed and is documented at https://perfetto.dev/docs/contributing/ui-plugins


encoding error at the start of installation

Inside a docker container with insystem option.
Sometimes it raises an encoding error like (will try to reproduce and get a full backtrack).
Tue 09 16:08:38 InstallTools.py  -2243 - install                            : EXCEPTION: 'ascii' codec can't encode character '\u2192' in position 72: ordinal not in range(128)

➤ AhmedHanafy725 commented:
I faced this before and it can be solved by:
apt-get install -y locales language-pack-en
export LANG=en_US.UTF-8
export LC_ALL=en_US.UTF-8


Making a fat jar for android library

Hi,
I'm working on android library project and everything works great, but now my client requested that I create a jar with all the required dependencies (scala-library etc.) included instead of instructing him to add those to his gradle.build. I'm unfortunately not very familiar with gradle or android development in general so even after much googling I was unable to find a solution. Any suggestions?
Thanks a lot!

I'm using jarjar to make all-in-one jar.
Please see following example for Gradle.
https://github.com/shevek/jarjar/blob/master/jarjar-gradle/example/build.gradle

Looks great. I will give it a try.


track eval error?

Hi, thank you for sharing the great work.
I met the error below.

    exec(code, run_globals)
  File "/SHFP12/xiaoquan.wang/01_bev/DetZero/tracking/tools/eval_track_my.py", line 50, in <module>
    main()
  File "/SHFP12/xiaoquan.wang/01_bev/DetZero/tracking/tools/eval_track_my.py", line 47, in main
    evaluation.get_tracklet_recall()
  File "/defaultShare/SHFP12/xiaoquan.wang/01_bev/DetZero/tracking/detzero_track/utils/track_recall.py", line 68, in get_tracklet_recall
    eval_results = multi_processing(
  File "/defaultShare/SHFP12/xiaoquan.wang/01_bev/DetZero/utils/detzero_utils/common_utils.py", line 302, in multi_processing
    results = [function(x) for x in progress_bar]
  File "/defaultShare/SHFP12/xiaoquan.wang/01_bev/DetZero/utils/detzero_utils/common_utils.py", line 302, in <listcomp>
    results = [function(x) for x in progress_bar]
  File "/defaultShare/SHFP12/xiaoquan.wang/01_bev/DetZero/tracking/detzero_track/utils/track_recall.py", line 171, in eval_single_seq
    frame_pred_data = tracklets_to_frames({'reference':gt_data, 'source':pred_data})
  File "/defaultShare/SHFP12/xiaoquan.wang/01_bev/DetZero/tracking/detzero_track/utils/data_utils.py", line 40, in tracklets_to_frames
    sample_idx = obj_data['sample_idx']
KeyError: 'sample_idx'
  0%|                                                                                | 0/2 [04:37<?, ?it/s]

The running script is below.
python eval_track_my.py

I met the same error,have you solved it?

only the final result pkl file is supported.


Added: dolphin 5.0

A couple of notes:
The minimum Windows version is actually 7 SP1 but I don't think AppGet supports that granularity.
https://dolphin-emu.org/download/ is the download page and might need to be scraped to find updates. Another option is to look at GitHub releases https://github.com/dolphin-emu/dolphin/releases


Requiring multiple stylesheets with the same relative path doesn't work

As of b9fdff56e81ead7dfe73a23d82276cef4eb7325d, I'm running into an issue when requiring multiple stylesheets with the same relative path.
The easiest way to reproduce is to use https://github.com/lern/react-starter, which is a fork of https://github.com/webpack/react-starter that I slightly modified to use version 0.10.1 of style-loader and added an additional require of a stylesheet called style.css. If you do a npm run build, npm start, and navigate to localhost:8080, you will see this error:
Uncaught TypeError: Cannot read property 'call' of undefined

I'm not entirely sure how to debug further, but I've narrowed it down to b9fdff56e81ead7dfe73a23d82276cef4eb7325d and also observed that the issue only happens if I have multiple require statements of the same relative path (eg. require("./style.css");), but in different directories (ie. the paths resolve to different files). I don't hit the issue if I run in HMR mode.

I encountered this issue as well and can confirm that 0.10.0 works but 0.10.1. My config is derived from react-starter but has diverged slightly from it.

I think this was fixed by https://github.com/webpack/webpack/commit/026170a8a36c82552f894cf9a6b9f1695552fc42

@sokra I just tried confirming that using v1.8.5 of webpack and I'm still getting the error. See lern/react-starter@2d63d99b051bf51b81d3542d80e5975e225d8ada if you'd like to reproduce it.

I'll check.

Don't have a solution yet, but it's the combination of DedupePlugin and ExtractTextPlugin, when a module is deduped and removed by extraction.

@sokra thanks, I confirmed it's fixed in webpack master :+1:


Custom logger can no longer be used in 0.7.9.

Version of Ruby: 2.4.6
Version of ruby-kafka: 0.7.9

Steps to reproduce
kafka = Kafka.new(['localhost:9092'], logger: MyLogger.new)

TypeError: no implicit conversion of MyLogger into String
/usr/local/rvm/rubies/ruby-2.4.6/lib/ruby/2.4.0/open-uri.rb:37:in `open'
/usr/local/rvm/rubies/ruby-2.4.6/lib/ruby/2.4.0/open-uri.rb:37:in `open'
/usr/local/rvm/rubies/ruby-2.4.6/lib/ruby/2.4.0/logger.rb:744:in `open_logfile'
/usr/local/rvm/rubies/ruby-2.4.6/lib/ruby/2.4.0/logger.rb:736:in `set_dev'
/usr/local/rvm/rubies/ruby-2.4.6/lib/ruby/2.4.0/logger.rb:671:in `initialize'
/usr/local/rvm/rubies/ruby-2.4.6/lib/ruby/2.4.0/logger.rb:387:in `new'
/usr/local/rvm/rubies/ruby-2.4.6/lib/ruby/2.4.0/logger.rb:387:in `initialize'
~/.bundle_local/ruby/2.4.0/gems/ruby-kafka-0.7.9/lib/kafka/tagged_logger.rb:63:in `new'
~/.bundle_local/ruby/2.4.0/gems/ruby-kafka-0.7.9/lib/kafka/tagged_logger.rb:63:in `initialize'
~/.bundle_local/ruby/2.4.0/gems/ruby-kafka-0.7.9/lib/kafka/tagged_logger.rb:56:in `new'
~/.bundle_local/ruby/2.4.0/gems/ruby-kafka-0.7.9/lib/kafka/tagged_logger.rb:56:in `new'
~/.bundle_local/ruby/2.4.0/gems/ruby-kafka-0.7.9/lib/kafka/client.rb:75:in `initialize'
~/.bundle_local/ruby/2.4.0/gems/ruby-kafka-0.7.9/lib/kafka.rb:366:in `new'
~/.bundle_local/ruby/2.4.0/gems/ruby-kafka-0.7.9/lib/kafka.rb:366:in `new'

Expected outcome
A custom logger class can be used.
Actual outcome
It appears that as a result of #716, when using a custom logger (that does not extend from ::Logger), it attempts to create a ::Logger instance, which can only accept a log device: https://github.com/zendesk/ruby-kafka/blob/master/lib/kafka/tagged_logger.rb#L63

... -_-
Ruby has an actual built-in Logger class, why are there so many other frameworks that don't use it? 🤦♂
I'll try to take a look at this in the next week or so.

Opened #762 to fix this, hopefully finally. My apologies for the last fix. I thought I was testing with Phobos but I forgot that I'd separately monkey-patched a fix in Phobos itself. :(

Thanks @dorner!


externalIP implementation for cluster ip service

ExternalIP programming in IPVS , ipset , iptable is being taken care with this implementation

/lgtm
/approve

filed #194 as a follow on


⚠ SolarOscp has degraded performance

In acb9ba5, SolarOscp ($SOLAROSCP_URL) experienced degraded performance:

HTTP code: 200
Response time: 410 ms

Resolved: SolarOscp performance has improved in d565752 after 7 minutes.


Arduino serial monitor not working

Issue Type: Bug
After upgrade of VSCode to 1.49.0 unable to open serial monitor in Arduino extension (vscode-arduino	vsc	0.3.2)
VS Code version: Code 1.49.0 (e790b931385d72cf5669fcefc51cdf65990efa5d, 2020-09-10T13:22:08.892Z)
OS version: Windows_NT x64 10.0.19041

Me too. Just updated, and bang, nothing works.
I just filled in a survey about what VSCode could do better - my answer was "stability, stability stability", and then this happen...

Could we please have an easy downgrade to previous version button somewhere. These serial port problems is happening so often it has become an issue of timewaste to downgrade every time. We have a "install a previous release" menu item on each extension, but where is it on the VS code itself.

I can confirm that downgrading to 1.48.2 restores expected functionallity.

please see https://github.com/microsoft/vscode-arduino/issues/1097 for progress


Fix chunk indexing

Previously there was a bug when the remembering function didn't close elegantly. This caused there to be frames in the frames table with a chunkId one higher than the top number in the chunks table (since the chunk wasn't added to the chunks table yet). This caused an issue running the timeline since there was no associated file. As well, the next frames would be initiated with the same chunkId causing there to be (chunkId, offset) duplicates in the frames table.
Another possibility was the ffmpeg video compressing process would fail, this would cause the chunk to exist in the chunks table but the associated path would not exist of be corrupted.
Fixes:

Moved let _ = DatabaseManager.shared.startNewVideoChunk(filePath: outputPath) to the end of the processChunk() and check that the ffmpegProcess exited successfully
Changed getCurrentChunkId() in DB.swift to return the chunkId of the last inserted frame (in case the chunk doesn't get saved to the database). Also, now insert chunk with specified chunkId instead of auto increment.
Added a chunksFramesView and associated interfaces for only grabbing frames with a chunk in the chunks table

Testing:
Using the timeline functionality after purposefully stopping rem while in remember mode.
Did not notice any performance decrease on Apple M3 Max (hopefully can get tested on a different model)
https://github.com/jasonjmcghee/rem/assets/54302513/2aa2fb0b-e075-405e-8bb1-b6ca71c2a2d3

Thank you and excited to dive in further / test- and I have an m1 air so that'll be an extra test case!
Seems like the right changes to me- here are some other cases / details that seem like they should be unaffected but worth checking:

open timeline while recording (should pause it, and resume on closing timeline)
Same as above for search
sleep computer while remembering and wake it back up (should be seamless)

I was seeing some weird behaviors (mostly noticing through watching the live log) when exiting the timeline and going from the search to the timeline. The biggest issue was a second recording thread starting which eventually caused a seg fault and rem to crash. I don't believe the chunk indexing changes impacted this but thought I would include the changes since small anyways.
P.S. The double recording was due to the onClose call within the TimelineView. I wasn't entirely sure what the intended functionality of this is (mentions thumbnail clicking which I thought was only relevant for search), so I left it alone and solved the issue within the enableRecording func.

@cparish312  nice change! Could you do the same fix for on opening search? Assuming it suffers from the same issue- double recording

So before these changes clicking on a frame in search to enter timeline did start recording and then closing timeline caused a second thread to start recording.
Are you thinking a single variable for checking if we were recording before either timleine or search? In that case, could probably have closeTimelineView() and closeSearchView() take an argument that ensure recording isn't started which could be passed when closing the search view within the timeline view.

Does recording resume after recording -> search -> timeline -> closed with your changeset?

Yup!
The newest change (adding userDisableRecording) ensures that this doesn't end in recording resuming
recording -> timeline -> toggle recording off -> search -> closed

Hmm I'm a bit confused. By "toggle recording off" I mean that the user clicks "Stop Remembering" in the menu. I would assume that if that is selected remembering should not begin again after opening timeline or search and would require the user to click "Start Remembering" to resume recording.

Totally true! But if you are recording when you open the timeline or search it "pauses" the recording and should automatically resume on close

Yup that is the functionality with the changes proposed!

(so one more confirmation, sorry lol) if you are actively recording, open search, click a tile, which opens timeline, then close, which should resume recording.

No worries! Yup that is how it works! Implementation of that is this line at the top of showTimelineView()
wasRecordingBeforeTimelineView = (isCapturing == .recording) || wasRecordingBeforeSearchView // handle going from search to TL

I'll make sure to do more testing before building a new release, but merging!


v5 bug/behavior: cant open file in a hx buffer from yazi if the helix pane is not the topmost

cant open file in a hx buffer from yazi, if the helix pane is not the topmost
to do: add this to the documentation

fix 1: add this to documentation
fix 2: make it so that when you open a new helix process from yazi, it always goes to the topmost location (so there are less instances of this bug, leaving only the case when helix is opened manually)
fix 3: somehow make the script find the pane where helix is. this is harder if not impossible or too time consuming to implement

its in the docs


Refactor wrapper classes + optional use of installed LibAPR

Quite a few changes here. A brief summary:

Change the wrappers to either directly expose the underlying LibAPR class or, where additional methods are required, derived classes. This reduces code duplication and should be easier to maintain, compared to the previous solution of defining C++ classes that contain an instance of the corresponding LibAPR class.
Move submodules to the external/ directory.
Add a cmake option to find and use an installed LibAPR rather than building it from submodules.
Expand tests with checks of error bound for APR conversion.
Add some new functions, including max projections along x, y or z, subvolume projections and reconstructions via ReconPatch, and a connected component algorithm.
Add a new class APRSlicer which returns reconstructions (constant, smooth or level) at a given resolution via 3D slicing, e.g. slicer[z0:zf, x0:xf, y0:yf], thus mimicking a read-only uniform array. This can, for example, be used to view APRs in napari.

Is this the current up to date development branch? shall we put this through to develop? the branches are all a bit confusing right now.. would like to update and push the CI through to github actions.


⠦ [Webpack] Watch service... Console (animation) cuts out console.log/s

Bug report

What is the current behavior?
I'm using webpack (watch mode enabled) along with serverless framework and serverless.offline, serverless-webpack plugins
Runtime Nodejs w/ Typescript.
If the current behavior is a bug, please provide the steps to reproduce.
When I test locally my serverless app executing on console:
sls offline start
I see the following webpack watcher message(animation) on the console:
⠦ [Webpack] Watch service... ( dots are animated )
While the app is running and I starts logging, webpack watch service message might refresh
When webpack watch is polling this message will overwrite last lines on my console logs.
Preventing me to see latest information.
Following is my webpack.config.js file:
const path = require('path');
const slsw = require('serverless-webpack');
const nodeExternals = require('webpack-node-externals');

module.exports = {
  context: __dirname,
  mode: slsw.lib.webpack.isLocal ? 'development' : 'production',
  entry: slsw.lib.entries,
  devtool: slsw.lib.webpack.isLocal ? 'cheap-module-source-map' : 'source-map',
  resolve: {
    extensions: ['.mjs', '.json', '.ts'],
    symlinks: false,
    cacheWithContext: false,
  },
  output: {
    libraryTarget: 'commonjs',
    path: path.join(__dirname, '.webpack'),
    filename: '[name].js',
  },
  target: 'node',
  externals: [nodeExternals()],
  module: {
    rules: [
      {
        test: /\.(tsx?)$/,
        loader: 'ts-loader',
        exclude: [
          [
            path.resolve(__dirname, 'node_modules'),
            path.resolve(__dirname, '.serverless'),
            path.resolve(__dirname, '.webpack'),
          ],
        ],
        options: {
          transpileOnly: true,
          experimentalWatchApi: false,
        },
      },
    ],
  },
  watchOptions: {
    poll: 1000,
    ignored: ["node_modules"]
  }
};

What is the expected behavior?

Other relevant information:
webpack version:  "^5.70.0"
Node.js version: v14.18.0
Operating System: macOS 12.x
Additional tools:
"serverless": "~3.12.0",
"serverless-offline": "^8.5.0",
"serverless-webpack": "^5.6.1",

not sure what you expect.. webpack logs in stdout/stderr during build, this is not related to your application logs, maybe you need to change your setup..

Yes, not related to webpack, please open an issue in serverless-webpack/serverless/serverless-offline repo


RxJava 2 Support

I was hoping to see support for RxJava2, I love having Redis on the stack when I make apps, but it's a real pain when almost every other library has standardized. Thanks for considering :)

It would be nice to see migration to rxjava 2.x since rxjava 1.x has officially out of support. Observing the following error when using Reactive operation.
For Ex :
RBucketReactive bucket = redissonReactiveClient.getBucket(key);
RxReactiveStreams.toObsersable(bucket.get());
is complaining that "Cannot access rx.Completable" since I have rxjava 2.x in classpath.

Done


nosense entity model on Create Issued Document

Hello,
on POST /c/{company_id}/issued_documents
there is an "entity" model that is related to clients in FIC but there is no way to bind this entity where we create an issued document with the client, this not make any sense and is a big problem.
Hope there is a solution
Thanks
MM

Hi @Mattia-Marchiorato, actually the entity model is related to both the client and supplier models so creating an issued document there needs to be a manual binding from the Client or Supplier model (depending on the document type) to the Entity that is needed by the IssuedDocument model.
Thanks,
Emanuele.

Hello @emajo,
can't see any reference about entity type on the API Reference,
There is only a "Type"
type: enum
EntityType: Entity type
Default: null Allowed: company┃person┃pa┃condo
But no difference between Client And Supplier, can you please be more explicit?
Thanks
MM

Hi @Mattia-Marchiorato
In our APIs, we always deal with "Entities", that are used to represent both Clients and Suppliers. You can check this fact on the Clients and Suppliers methods, which include "entities" in the path.
Since Clients and Suppliers differ for a subset of fields, while modeling the APIs in our OpenAPI Spec we preferred to manage them as two different models when possible to avoid ambiguities.
Unfortunately for issues related to the SDK generator it was not possible to indicate both Client or Supplier as acceptable types for the entity field in the Create Issued Document method, so we opted to manage them with the original "Entity" model that contains all the parameters accepted for Clients and Suppliers.
What we suggest, if you already have a client and you want to use it to populate the creation request, is to write a simple client2entity method that accepts the Client and returns the Entity, simply by mapping the fields of the client into the fields of the entity(the fields name should be the same for all fields). It should be also possible to marshal a Client into its JSON representation and unmarshal it to an Entity if preferred.
Thanks
Mauro

Yes @Mattia-Marchiorato unfortunately we know some parts of our APIs can be confusing, let us know if we can further help you with this topic.

No thanks.


iOS build fails on Flutter stable 1.22.3

     ^
    /Users/runner/hostedtoolcache/flutter/1.22.3-stable/x64/.pub-cache/git/callkeep-283403503ee348a9fde02aa5471174f399459686/ios/Classes/CallKeep.m:330:1: error: missing context for method declaration
    -(void) updateDisplay:(NSString *)uuidString displayName:(NSString *)displayName uri:(NSString *)uri
    ^
    fatal error: too many errors emitted, stopping now [-ferror-limit=]
    26 warnings and 20 errors generated.
    note: Using new build system
    note: Building targets in parallel
    note: Planning build
    note: Constructing build description

Excellent. Will test today.


Pie times out in Enzyme, but only first time it's used

Hey all,
Love the utility. Having an unfortunate bit of trouble with Pie.
The below test suite runs the same test twice. The first time it times out. The second time it works.
Any ideas?
import React from 'react';
import {mount} from 'enzyme';
import {Pie} from 'react-chartjs-2';

const theTest = () => {
        const chartData = {
          "labels": [
            "Developing"
          ],
          "datasets": [
            {
              "data": [
                3
              ],
              "backgroundColor": [
                null
              ]
            }
          ]
        };

        mount(
            <Pie
              data={chartData}
              tooltips={false}
              width={150}
              height={150}
              options={{
                animation: {
                  animateScale: false,
                  animateRotate: false},
                legend: {
                  display: false},
                tooltips: {
                  enabled: false},
                onClick: (e, elms) => onClickGroup(elms[0]._index),
              }}
            />
        );
    };

describe('<Pie />', () => {
    it('first', theTest);
    it('second', theTest);
});

Using:
    "enzyme": "^2.4.1",
    "chart.js": "^2.4.0",
    "react-chartjs-2": "^2.0.0",

Is there any error that comes along with it? I've never heard of this before.

The only error is the "timeout" message accompanying the failed test. Nothing to indicate why...

Closing for now. Please supply a sandbox or code example with the latest versions of both libraries. If the problem persists, feel free to open a new issue.


Only change the assembler state on success

The current hole was always shrinked even if the
packet assembler rejected adding a packet due to
not being able to insert a new hole.
Shrink only after a new hole was added.
Shrinking before or after does not make a difference
because offset + size < hole_size and thus
contigs[index] is not empty, passing the
debug_assert in add_contig_at.
https://github.com/m-labs/smoltcp/issues/261

@m-labs-homu r+
Thanks!

:pushpin: Commit 9ccf18e has been approved by whitequark

:hourglass: Testing commit 9ccf18e0b61efc49480aa538495a7e746bed1d16 with merge 68869defc79e7bce8d4a7e09aa7981ccb7cc4a44...

:sunny: Test successful - status-travis
Approved by: whitequark
Pushing 68869defc79e7bce8d4a7e09aa7981ccb7cc4a44 to master...


Changed dependencies list for YUM installation

The nodejs and python-pip packages are available through epel-release. Also, libmysqlclient-dev package is not available on the repos and the nodejs installation script was installing a deprecated version.
This was tested on a CentOS 7 machine.

Merged @WolfangAukang thank you for your contribution!


ethereum parity is too old to sync

Issue description
current stable version of parity is 2.2.10-stable
https://github.com/paritytech/parity-ethereum/releases
current version in nix pkgs as altcoins.parity is 1.11.8
this version is so old that running parity --no-warp dies around block 7079993 and cannot validate (at least i hope that is why it cannot validate)
i see a lot of debug output, but this seems relevant as some Rust debug output:
2019-02-18 14:48:50  Stage 3 block verification failed for #7080000 (0x30f1…ebc9)
Error: Error(Block(InvalidDifficulty(Mismatch { expected:<PHONE_NUMBER>642656, found:<PHONE_NUMBER>287456 })), State { next_error: None, backtrace: InternalBacktrace { backtrace: None } })
2019-02-18 14:48:50
Bad block detected: Error(Block(InvalidDifficulty(Mismatch { expected:<PHONE_NUMBER>642656, found:<PHONE_NUMBER>287456 })), State { next_error: None, backtrace: InternalBacktrace { backtrace: None } })

Steps to reproduce

nix-shell -p parity --run 'parity --no-warp'
wait...
see the error validating blocks ~7079993

Technical details
Please run nix-shell -p nix-info --run "nix-info -m" and paste the
results.
[thedavidmeister@nixos:~]$ nix-shell -p nix-info --run "nix-info -m"
 - system: `"x86_64-linux"`
 - host os: `Linux 4.19.7, NixOS, 19.03pre161883.e85c1f58680 (Koi)`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.1.3`
 - channels(root): `"nixos-19.03pre165037.eebd1a92637, nixpkgs-19.03pre160749.3a393eecafb"`
 - channels(thedavidmeister): `"nixos-19.03pre169108.36f31600749"`
 - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos

@thedavidmeister the version has been updated in the upcoming 19.03 release.
I think this can be closed?

yes, i am syncing again by updating to latest unstable


[Feature] Add tidb datatype convertor

Purpose of this pull request

Check list

[ ] Code changed are covered with tests, or it does not need tests for reason:
[ ] If any new Jar binary package adding in your PR, please add License Notice according
New License Guide
[ ] If necessary, please update the documentation to describe the new feature. https://github.com/apache/seatunnel/tree/dev/docs
[ ] If you are contributing the connector code, please check that the following files are updated:

Update change log that in connector document. For more details you can refer to connector-v2
Update plugin-mapping.properties and add new connector information in it
Update the pom file of seatunnel-dist

[ ] Update the release-note.

Shall we add some test case for it?

If need to add test cases, I can also add, but I don't know how to test this，
and only Seatunnel Web uses this datatypeconvorter,


Adds MIDDLEWARE_UNSUBSCRIBE handler

I'm using the MIDDLEWARE_SUBSCRIBE event to send messages such as "player x has joined the conversation". However, there is currently no way to send "player x has left the conversation" using middleware in the same manner.
MIDDLEWARE_UNSUBSCRIBE does not allow for blocking, but instead prints a warning when blocking is attempted by the consuming implementation i.e. next(true); will not block the unsubscribe.

Use socket.on('unsubscribe', function (channel) {}); instead.


🌏 Improve environment variables used for ModelCI

What has been done to verify that this works as intended?
First, generate .env when you install / or change the environment settings:
python scripts/generate_env.py

And, that's all! You do not need source scripts/setup_env.sh every time.
Why is this the best possible solution? Were any other approaches considered?
Remove setup environment step for users at each time.
How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
See Readme.
And at the same time, pip install needs to be inspected. Some subdirectories may affect and not be installed.
Does this change require updates to documentation?
Yes.
Before submitting this PR, please make sure you have:

[x] run python -m pytest tests/ and confirmed all checks still pass.
[x] verified that any code or assets from external sources are properly credited.

can be merged?

please merge


Added support for headers in the settings.

This pull request adds support for using custom HTTP headers with CURL. For each header, it appends an argument like --header "name:value" to the CURL command. Unit tests are included. Related issue https://github.com/ecampidoglio/Cake.Curl/issues/4.
I had to upgrade the project to use the .cproj project system to be able to run unit tests. If you want I could create another pull request for that.

@johanbenschop Thank you for your contribution! 🎉


Bring in pkg/model/multiversion package to help interacting with multiple API versions

Part of https://github.com/aws-controllers-k8s/community/issues/835
Description of changes:
This patch brings a new package to pkg/model, essentially to
simplify accessing and interacting with multiple api versions.
The pkg/model/multiversion contains five main components:

An APIVersionManager struct containing information about the hub
and spokes apis, their corresponding ackmodel.Model and
APIInfo, plus a list of the deprecated and removed versions.
A FieldDelta, CRDDelta and FiledChangeTypes which helps in
representing the difference between two different APIs.
A ComputeFieldsDiff function which helps in computing the difference
between two given string to ackmodel.Fields maps.
An APIStatus and APIInfo that holds information about a specific
api version (used sdk version, generator file path etc...)
Add ComputeRenamesDelta to compte the correct field renames
between two api versions.

this PRs also changes model.SDKHelper methods and signatures to
support interacting with multiple "Service API Versions" and multiple sdk
versions
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.


run provider tests with ocis in drone

sub task of #644
depends on #646
blocked by pact-foundation/pact-js/issues/561
the provider side tests need to be run on ocis to make sure the API is what the consumer expect

fixed by  #740


Add search by Unicode to the the "Filter by name or id" input box.

Summary
This feature request proposes the addition of a Unicode code point glyph search functionality in Samsa. This feature would improve the efficiency of testing for glyphs from complex scripts and rare characters not easily accessible through standard keyboards.
Background
In current usage, Samsa allows users to search for glyphs by typing the character itself into the string box, or searching by glyph name or id.
Suggested Implementation
UI Enhancement:
• Add this functionality to the "Filter by name or id" input box.
Other options:
• Add an input field specifically for Unicode points in the Samsa UI.
• Add to the current string box for character entry.
Syntax Proposal: The input could be in the standard Unicode notation (e.g., U+1F60A  for the smiling face emoji “😊”).
Alternatively: u1F60A.

Thanks for this. Good idea, fixed in 6198ed4e9bcf9103e6e5e947c552e6588fa4978f. You can now use any of the following formats in the "filter by string" field in order to filter by Unicode value: U+nnnn, unnnn, &#xnnnn;, &#nnnn;.
For example, to enter the Euro sign €, type any of these:

U+20ac
u20ac
€
€

Unfortunately, Unicode IDs higher than 65535 such as U+1F60A ("😊") are not yet supported, awaiting integration of samsa-core v2.

See issue #88


Add support for TS project not located at the root of the repo.

This is the PR followup for the discussion in #44
Overview of the changes:

Add support for the tsc --project flag to use non-root located tsconfig.json files to scope the plugin
Some tests added, with respect to changes in the project

closes #44

If accepted for merge, would you also be willing to add a label hacktoberfest-accepted so that this would count toward my contributions?

Can do, bump it up a minor version?


Where does hass-opnsense store its settings?

Hello.
I am using the integration and it worked just fine until recently.  I have reconfigured my network, and the firewall does now have a different hostname.  This renderd the integration useless, and I do not find anything in the GUI where I can update the hostname.
I was also reading through the files in the /config/custom_components/opnsense/ folder, but this seems wrong either.
Thanks for a hint.
Best regards,
Marcus

The file /config/.storage/core.config_entries contains the relevant data, do a backup first, then open it and search for "opnsense", a couple of lines below you'll find the URL key.
Be careful, it's a critical HA data file.

Thanks a lot, this is exactly what I was looking for.


Warning: Unknown prop

I have got the following warnings with react 15.3.0

@irskep any updates on this one ?

Looks like a recent version of React changed the API or something. I don't have time to fix it.

no plan on supporting latest react version?

I will be happy to do a release if someone submits a pull request with the necessary changes.


PaneTitle on NavigationView is getting narrator focus even when its empty

Describe the bug
When the NavigationView is expanded, there's no PanelTitle assigned to it, and I navigate through it using narrator, the focus disappears after the Menu button and then reappears on the first Menu Item. The focus is getting lost because narrator tries to focus on the PaneTitle, and because it's empty, there's nothing to focus on.
Steps to reproduce the behavior

Make sure XAML Controls Gallery is installed
Launch XAML Controls Gallery
Navigate to NavigationView Page
Scroll to the bottom of the page to "API in action"
Remove PaneTitle using the edit controls on the right
Turn on Narrator (Ctrl+Windows+Enter)
Navigate to the Menu button
Go one element forward (CAPS+Right Arrow) and notice the focus disappears
Go one more element forward and notice the focus shows up again on the first Menu Item.

Expected behavior
Narrator should go from the Menu button directly to the first Menu Item when there's no PaneTitle.
Version Info
XAML Controls Gallery: <IP_ADDRESS>

Windows 10 version
Saw the problem?

Insider Build (xxxxx)

May 2019 Update (18362)
Yes

October 2018 Update (17763)

April 2018 Update (17134)

Fall Creators Update (16299)

Creators Update (15063)

Device form factor
Saw the problem?

Desktop
Yes

Mobile

Xbox

Surface Hub

IoT

I'm not able to repro this with the steps provided.
And when you do see this, are you seeing the title be a narrator stop even after switching to another window and then back to the gallery?


Error executing grunt platform:add:ios on Windows

Below is the error when I try to execute grunt platform:add:ios on Windows
PS C:\Git\SmartMeteoMobileApp\src> grunt platform:add:ios
Running "platform:add:ios" (platform) task
Creating ios project...

Error: C:\Users\alex.cordova\lib\ios\cordova\3.4.1\bin\create: Command failed with exit code ENOENT
at ChildProcess.whenDone (C:\Git\SmartMeteoMobileApp\src\node_modules\cordova\src\superspawn.js:126:23)
at ChildProcess.emit (events.js:95:17)
at Process.ChildProcess._handle.onexit (child_process.js:808:12)
Warning: Task "platform:add:ios" failed. Use --force to continue.

Aborted due to warnings.
Execution Time (2015-03-28 06:40:00 UTC)
loading tasks     13ms  ■■ 1%
platform:add:ios    1s  ■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■ 99%
Total 1s

Yup, that's about what's expected, unfortunately! The only platform you can develop iOS apps on, even when using a Cordova based framework, is OS X. Cordova requires Xcode command line tools to do the business, so you won't even be able to add the platform on a Windows machine.
See the relevant Cordova platform documentation: http://cordova.apache.org/docs/en/4.0.0/guide_platforms_ios_index.md.html#iOS Platform Guide
Sorry!

It does not work on MacOS as well
Alexs-MacBook-Pro:src alex$ grunt platform:add:ios
Running "platform:add:ios" (platform) task

/Volumes/BOOTCAMP/Git/SmartMeteoMobileApp/src/node_modules/cordova/bin/cordova.cmd: line 1: @node: command not found
Warning: Task "platform:add:ios" failed. Use --force to continue.

Aborted due to warnings.
Execution Time (2015-03-28 08:04:00 UTC)
loading tasks     59ms  ▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇ 69%
platform:add:ios  26ms  ▇▇▇▇▇▇▇▇▇▇▇▇▇▇ 30%
Total 86ms

I'm wondering why it uses cmd on MacOS

Okay, but this time you got a different error! And you're right, it really shouldn't use the .cmd binary...
As far as can see, the grunt script determines which binary to use based on the process.platform nodejs global variable. If that says your platform is win32, then you get the .cmd commands, otherwise it goes with the linux variant. I'm guessing it might be wrong for you, because you have the project under a bootcamp folder. You could try running node -e 'console.log(process.platform)' in there to see if that's the case. You could also try cloning your repo under OS X, and seeing if you get the same problem there.

running node -e 'console.log(process.platform)' seems to show correct result - see below
Alexs-MacBook-Pro:src alex$ node -e 'console.log(process.platform)'
darwin

Well, bummer... Sorry, I'm out of ideas then.

I could not make grunt platform:add:ios to work. However cordova platform add ios worked fine
Alexs-MacBook-Pro:src alex$ cordova platform add ios
Adding ios project...
iOS project created with<EMAIL_ADDRESS>Installing "com.megster.cordova.bluetoothserial" for ios
Installing "org.apache.cordova.device" for ios

grunt build:ios or grunt build:android those will not work on my Mac.
What the reason to wrap the build command with the grunt? Or just remove them if they won't work correctly.


Do I need to use this SDK if I just want to use Sentry on the renderer process? Or can I use the normal minified browser bundle in that case?

Is there an existing issue for this?

[X] I have checked for existing issues https://github.com/getsentry/sentry-javascript/issues
[X] I have reviewed the documentation https://docs.sentry.io/
[X] I am using the latest SDK release https://github.com/getsentry/sentry-javascript/releases

How do you use Sentry?
Sentry Saas (sentry.io)
Electron SDK Version
.
Electron Version
.
What platform are you using?
None
Link to Sentry event
No response
Steps to Reproduce
.
Expected Result
.
Actual Result
.

The browser SDK will work perfectly well in the renderer process but the Electron SDK does add a lot of potentially useful context like os and device info.
The electron SDK will also give more accurate session data since it tracks the full lifetime of the app and captures errors in the main process and native crashes.


Pods’ Swift 2.3 version

Hi,
First of all — cool library, thanks for sharing it!
I’d like to use the Swift 2.3 version, what version should I refer to on my cocoa pods?
Thanks!

Unfortunately pods support was added after FaceAware had been updated to Swift 3.0.
There was a short time early on where the project supported both but that was only during that rough time period of transition.
You can try this commit, it's an early version so I can't tell you how stable it will be. Many improvements since then, and of course no cocoapods support.

@BeauNouvelle — Thanks! I’ll check it out.

@BeauNouvelle — I’ve created a fork, and downgraded the code to use Swift 2.3. My question: I sometimes get the following error: CreateWrappedSurface() failed for a dataprovider-backed CGImageRef..
Looking on Stack OverFlow, the suggestions I tried did not solve it. Any idea?

Try compare it to that commit I linked. I can't really help you out much further as I don't have an older version of Xcode that supports swift 2.3

👍


Missing pause menu string extract from Majiro

セーブする
ロードする
メッセージログ
コンフィグレーション
ゲームに戻る
タイトルに戻る
script: pausemenu.mjo.zip
Thanks to the effort, almost all text was extracted.
There is a string that has not been extracted from the pausemenu.mjo

Fixed. Let's hope that was the last one then :D

Fixed. Let's hope that was the last one then :D

So far, it looks like Sanarara R's script has been extracted completely.
Thank you for your efforts. :)


[BLOCKED gui-application-build]Multiple vertex settings

This merge is blocked by the PR for the branch gui-application-build
This branch adds the ability for a vertex to have multiple settings written to JSON if it exhibits a type that expresses multiple settings in the JSON.

Fixed with recent merge into master


Change binding powers for rescue modifier

Fixes #633
Although I am not 100% sure about this change, I haven't seen any regression in the targets.

Yeah, after some testing this seems right.


about crontab issues

i want to know how to solve the problem when i use the time mission of crontab on centos to creat the html issues , the size of html is 0 .
but i can creat the html with running the goaccess command directly .
this's the shell on crontab
#!/bin/bash
time=$(date +%Y%m%d)
commandStr=`goaccess -f /log/access_log.$time -p ~/.goaccessrc -a > /report/report--$time.html`
$commandStr

Which version are you running?
You can also try this:
commandStr=`cat /log/access_log.$time | goaccess -p ~/.goaccessrc -a > /report/report--$time.html`

GoAccess - 0.9.8

the version is GoAccess - 0.9.8
i try your suggest ,  the time mission of crontab creat the html size still be 0 .

Your script does work on a debian machine. Tomorrow I can probably test this on a centos machine.
BTW, you can use --no-progress to avoid getting progress metrics. Also, does it work if you run the bash script directly (no through the cron)?

yes . i run the bash script on the terminal is work ! except the crontab mission . do you try on crontab with the bash script ? or just the command of the goaccess ?

Both. I tried this through the cron and directly from the script. Either way worked fine.

Sorry for the delay on this. I tested this on CentOS 6.5 and I noticed you need to specify the full path, so this worked:
commandStr=`/usr/local/bin/goaccess -f /log/access_log.$time -p ~/.goaccessrc -a > /report/report--$time.html`

Closing this. Feel free to reopen it if needed.


on-prem very low performance with dataset.as_mount() method

Using the sample notebook 002-SciKitLearn
Experienced very slow performance with .as_mount() method.
A possible workaround:
Using .as_download() methos instead the pipeline on prem bare metal cluster, the required time was drastically reduced from 34mins to 3 mins!
Below the original snippet:
from azureml.core import ScriptRunConfig
args = ['--data-folder', mnist_file_dataset.as_mount(), '--regularization', 0.5]
src = ScriptRunConfig(source_directory=script_folder,
                      script='train.py',
                      arguments=args,
                      compute_target=compute_target,
                      environment=env)

Below the code with as_download() method that solved the performance issue.
from azureml.core import ScriptRunConfig
args = ['--data-folder', mnist_file_dataset.as_download(), '--regularization', 0.5]
src = ScriptRunConfig(source_directory=script_folder,
                      script='train.py',
                      arguments=args,
                      compute_target=compute_target,
                      environment=env)

Hi tinuxnet, did you use outbound proxy for the on-prem cluster? Do you still meet the issue on latest release?


API call hardening for public posts

Makes /posts work properly for authed/non-authed users. Also fixes it for foreign nodes who are calling it.
Need to run ./nodes.py after deploy. Will probably need to blow away the DB beforehand for one last time.

:+1:

I'll try to deploy tonight. Might do a little cleaning myself.


Prevent removing title if it changed

There is an issue with Angular 1.5 with UI Router causing title to disappear even if new one is set. It is caused by how $destroy event is processed: after new directives has been created.
Simple check if the title has been updated is enough to work reliably.

+1

This is way too old PR and it's not going to be merged (I suppose). Closing.

#amadeuszcleaningbeforespring :medal_sports:


Support for working with already running containers

Is your feature request related to a problem? Please describe.
When running integration tests with containers, I would like to reuse a running container on my local machine. So as not to recreate it between every test run. So along with StartAsync():
I propose a EnsureStartedAsync(Filter? filter)
Describe the solution you'd like
As of v2.0.1 it seems to me that a TestcontainersContainer's internally need two things.

An ITestcontainersConfiguration which is hidden from public inside the builders
An ContainerInspectResponse representing the running container

So in order to accomplish my "ensure started" method I actually have everything.
The test will use TestcontainersBuilder to construct an ITestcontainersContainer with a configuration inside.
If the container is running, I can easily do a ListContainersAsync and InspectContainerAsync to get the ContainerInspectResponse. (in this case, some kind of filter could be supplied)
If the container is not running, I can just call startAsync.
Describe alternatives you've considered
So if this solution is to "specialized" or niche, an alternative could be to open up the API a bit. At the moment it is very closed for extensions.
From an package user perspective I have the following problems:

I cannot get a hold of the ITestcontainersConfiguration, it is private inside the builder and inside the testcontainer
Without the configuration I cannot extend TestcontainersContainer or any of its subtypes (it takes a configuration in the constructor)
The ContainerInspectResponse container of TestcontainersContainer is private and I can't find a way to "extend my way" to set it. Therefore I cannot represent the "running state"

Additional context
I have not used this lib for a long time, so please bare with me, if I missed something obvious.
But working with this lib, I have banged my head against internal classes, and private fields in hierarchies a lot. Of cause you should not expose internal state, but is all this exactly internal?
Couldn't some of it be made public, and thereby improve how extensible this library is?

I have started to work on this, but I am not sure when I am able to finish. (Sorry, I have no public WIP branch.)
I agree with @HofmeisterAn that the public API should be as restricted as possible so that further development can continue without unnoticed or too many breaking changes.


Claims and HTTP 431

Has the support for ClaimsTransformation been dropped from ASP.NET Core 2.0 ? If yes , what is the best way to maintain cookie based authentication and avoid HTTP 431?

Claims transformation is still there, you just directly add it to the container:
See https://github.com/aspnet/Security/blob/dev/test/Microsoft.AspNetCore.Authentication.Test/GoogleTests.cs#L1049

Thank You. Was looking at wrong place.


Feature/county list investigation

A simple script to check the union, intersect, and complement of two county lists. The county list has been updated. The equivalent in the API repo needs to be updated based on this list.

We need to make sure that the CSV file that I have is the same as we have in the API repo used for the county extraction.


ThisAssembly.Strings: If resource name is not a valid code identifier, compilation fails

If a resx file contains an entry with an invalid code identifier (like a number), the generated code will not compile, and the error is quite cryptic too.
We should validate that the name are valid C# identifiers and skip (probably warn too if they aren't?)

Some quick notes:

The same check may be useful in other situations where identifiers are involved, e.g. user-defined constants.
Roslyn has a handy IsValidIdentifier utility method that can be used for this purpose.
There's an IsValidIdentifier method for Visual Basic too, so you may call one or the other according to the project's language.
F# is no concern, as it doesn't support code generators.

I guess more than just checking whether the identifier is valid, you'd actually want it to generate code but turn the identifier into a valid one by replacing invalid chars with underscores, say...

@viceroypenguin perhaps this could also use the sanitization you applied to resource class names?

Yeah, I encountered this while working on Resources; I just got lazy and avoided it for now... 🙂. I would expect the code to work the same here. Could copy/paste or extract to common .cs file. The regex is doing the bulk of the work, so copy/paste would probably be fine.

This method could be used to generate a valid identifier : it replaces any invalid identifier by '', removes redundant '', and prefixes the identifier by '_' if not valid :
        private string EscapeIdentifier(string filename)
        {
            var bytes = filename.ToCharArray();

            var replaced = bytes.Select(_ => SyntaxFacts.IsIdentifierPartCharacter(_) ? _ : '_').ToArray();

            var result = Regex.Replace(new string(replaced), "(_)+", "_");

            if (!SyntaxFacts.IsValidIdentifier(result))
            {
                result = "_" + result;
            }

            return result;
        }

As for now, all we can do is change all the files' name, but that's not always easy.

Thanks for the suggestion @PhenX. Would you like to send a PR? 🙏


The right way of pre-processing for input?

We use the first img as input, and resize it from (427, 640, 3) to (512, 512, 3), and normalize it from [0,255] to [0,1].

As below, the output of OS=16 is normal,

but the output of OS=8 is worse.
I can not figure out that, so I think my pre-processiong(such as normalizing) is wrong.

After trying more times with normalizing to [0,1], the OS=16 is better

How to reproduce your results? I try to do this way:
deeplab_model = Deeplabv3((512,512,3),num_classes=21, last_activation=None, OS = 16)
#load weights
img = plt.imread("image1.jpg")
resized = cv2.resize(img,(512,512)) / 255.
res = deeplab_model.predict(np.expand_dims(resized,0))
plt.imshow(np.argmax(res.squeeze(),-1))
but i get this

What version of TensorFlow and Keras do you use?

Keras == 2.1.5
Tensorflow == 1.4.0
Cuda == 8.0, Cudnn == 6.0

And I use the scipy.misc.imresize, which is different with yours

Hmmm. I am using TF == 1.6.0 and Cuda==9.0.
Maybe there are some big implementation differences between this two version

if rescale it to[-1,1] is correct then (at least for exception backbone) this should do it:
from keras.applications.xception import preprocess_input
img = preprocess_input(img)


Automated Package Upgrade

:tada: This PR is included in version 7.7.195 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


feat: deploy main playbook manually

Closes: #13

:tada: This PR is included in version 1.2.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Vision torch targets sometimes don’t activate the first time

What Happened?
This bug applies only to vision torch targets (the kind that you aim a held vision torch at to activate).
Description: sometimes, the torch will lock on to the target but not start the vision. You have to stop activating the torch and try again to get the vision to start. It always starts on the second attempt
What was supposed to happen?
No response
Platform
Steam
Mods
No response
Logs
No response

appears to have not been an issue since this one time


Why you can't do it older models (2010-2016)

If done soo.

Support for vehicles not on our supported car list ( https://github.com/commaai/openpilot#supported-cars ) will come through community contributions. A good candidate for support would be a car with LKAS and ACC, newer than 2016. Without LKAS or ACC, there's no system in place to control the car.


issue with esbuild / typeschema optional dependencies

context
I'm trying to use typeschema (lib that makes runtime validation library-agnostic, so the user can use zod, arktype, valibot, typebox ..) inside the partykit server
not sure why but esbuild can't skip those optional dependencies. the solution would usually be to mark them as external (as I'm not using those, only valibot in this example).
I'm not aware of a way to do that (customizing partykit esbuild config) and from a quick glance I couldn't find a way either
https://github.com/partykit/partykit/blob/f60434bdc1623c38d072da9616fb8d33bb802127/packages/partykit/src/dev.tsx#L389
https://github.com/partykit/partykit/blob/f60434bdc1623c38d072da9616fb8d33bb802127/packages/partykit/src/dev.tsx#L24-L29
minimal repro
here's the minimal repro commit:
https://github.com/astahmer/partykit-typeschema/commit/52dc3a819be75fe4cfa0b8d77ae232f4182d0047
to run this example:
pnpm i && pnpm dev

error
this is the error output, it stops here (= not just a warning)
 pnpm dev

><EMAIL_ADDRESS>dev /Users/astahmer/dev/reproductions/partykit-typeschema
> partykit dev src/server.ts

🎈 PartyKit v0.0.0-f60434b
---------------------------
▲ [WARNING] Serving static assets in dev mode is experimental and may change any time

✘ [ERROR] Could not resolve "fp-ts/Either"

    node_modules/.pnpm/@decs+typeschema@0.9.1_valibot@0.12.0/node_modules/@decs/typeschema/dist/io-ts-BRWJAQV3.mjs:2:24:
      2 │ import { isRight } from "fp-ts/Either";
        ╵                         ~~~~~~~~~~~~~~

  You can mark the path "fp-ts/Either" as external to exclude it from the bundle, which will remove
  this error.

✘ [ERROR] Could not resolve "yup"

    node_modules/.pnpm/@decs+typeschema@0.9.1_valibot@0.12.0/node_modules/@decs/typeschema/dist/yup-J36PHLX6.mjs:2:32:
      2 │ import { ValidationError } from "yup";
        ╵                                 ~~~~~

  You can mark the path "yup" as external to exclude it from the bundle, which will remove this
  error.

✘ [ERROR] Could not resolve "@sinclair/typebox/compiler"

    node_modules/.pnpm/@decs+typeschema@0.9.1_valibot@0.12.0/node_modules/@decs/typeschema/dist/typebox-WF7VWWUM.mjs:2:29:
      2 │ import { TypeCompiler } from "@sinclair/typebox/compiler";
        ╵                              ~~~~~~~~~~~~~~~~~~~~~~~~~~~~

  You can mark the path "@sinclair/typebox/compiler" as external to exclude it from the bundle,
  which will remove this error.

✘ [ERROR] Could not resolve "ow"

    node_modules/.pnpm/@decs+typeschema@0.9.1_valibot@0.12.0/node_modules/@decs/typeschema/dist/ow-RU2EFUAC.mjs:2:21:
      2 │ import owImport from "ow";
        ╵                      ~~~~

  You can mark the path "ow" as external to exclude it from the bundle, which will remove this
  error.

✘ [ERROR] Could not resolve "@deepkit/type"

    node_modules/.pnpm/@decs+typeschema@0.9.1_valibot@0.12.0/node_modules/@decs/typeschema/dist/deepkit-KEFZXADV.mjs:2:25:
      2 │ import { validate } from "@deepkit/type";
        ╵                          ~~~~~~~~~~~~~~~

  You can mark the path "@deepkit/type" as external to exclude it from the bundle, which will remove
  this error.

Hah, I thought this was an issue with pnpm, but even after I used npm, I notice that the peerDependencies listed for @decs/typeschema don't get installed under node_modules. This package is funny, no one can use it in a bundler without external for all the libs they don't use haha.
Anyway, I think exposing external is a good idea. https://github.com/partykit/partykit/pull/255 Thanks for reporting with a repro! Could you test with the latest partykit@beta and lemme know whether it solves your problem?

can confirm this works now ! thanks, that was fast.
on a side note, and completely unrelated to partykit, I'm not sure I can use typeschema anyway as it seems to lead to dts issues 😅

src/server/create-party-rpc.ts(48,14): error TS2742: The inferred type of 'createPartyRpc' cannot be named without a reference to<EMAIL_ADDRESS>This is likely not portable. A type annotation is necessary.

Hah, I thought this was an issue with pnpm

oh yes btw, regarding could partykit init command take a --pm flag to specify the package manager ? or I'm not sure how other tools do that install step but it felt a bit weird that it directly installed with npm (maybe asking with a prompt ?)

Good idea. I think the way to do it is to detect which package manager called the command itself, and to use that to install dependencies. This was just an initial stab at the problem, we're going to polish this over the next couple of weeks for our announcement. We'll probably also make a create-partykit package (so you can do npm init partykit etc)