Supporting training/inference of vision LLM using multiple images

I want to finetune llama3.2 11B vison using conversations that contain multiple images.
I've used the example in the documentation:
model, tokenizer = FastVisionModel.from_pretrained(
    "unsloth/Llama-3.2-11B-Vision-Instruct",
    load_in_4bit = True, # Use 4bit quantization to reduce memory usage. Can be False.
    use_gradient_checkpointing = "unsloth", # True or "unsloth" for long context
)

model = FastVisionModel.get_peft_model(
    model,
    finetune_vision_layers     = True, # False if not finetuning vision part
    finetune_language_layers   = True, # False if not finetuning language part
    finetune_attention_modules = True, # False if not finetuning attention layers
    finetune_mlp_modules       = True, # False if not finetuning MLP layers

    r = 16,           # The larger, the higher the accuracy, but might overfit
    lora_alpha = 16,  # Recommended alpha == r at least
    lora_dropout = 0,
    bias = "none",
    random_state = 3407,
    use_rslora = False,  # We support rank stabilized LoRA
    loftq_config = None, # And LoftQ
    # target_modules = "all-linear", # Optional now! Can specify a list if needed
)

dataset = Dataset.load_from_disk("Dastaset")

FastVisionModel.for_training(model) # Enable for training!

trainer = SFTTrainer(
    model = model,
    tokenizer = tokenizer,
    data_collator = UnslothVisionDataCollator(model, tokenizer), # Must use!
    train_dataset = dataset,
    args = SFTConfig(
        per_device_train_batch_size = 1, # Reduce to 1 to make Pixtral fit!
        gradient_accumulation_steps = 4,
        warmup_steps = 5,
        max_steps = 30,
        # num_train_epochs = 1, # Set this instead of max_steps for full training runs
        learning_rate = 2e-4,
        fp16 = not is_bf16_supported(),
        bf16 = is_bf16_supported(),
        logging_steps = 1,
        optim = "adamw_8bit",
        weight_decay = 0.01,
        lr_scheduler_type = "linear",
        seed = 3407,
        output_dir = "outputs",
        report_to = "none",     # For Weights and Biases
        # You MUST put the below items for vision finetuning:
        remove_unused_columns = False,
        dataset_text_field = "",
        dataset_kwargs = {"skip_prepare_dataset": True},
        dataset_num_proc = 4,
        max_seq_length = 1024*8,
    ),
)
trainer_stats = trainer.train()

Each example looks something like:
{'messages': [{'content': [{'index': None, 'text': "", 'type': 'text'}, {'index': 0, 'text': None, 'type': 'image'}], 'role': 'user'}, {'content': [{'index': None, 'text': "", 'type': 'text'}, {'index': 1, 'text': None, 'type': 'image'}], 'role': 'user'},
{'content': [{'index': None, 'text': '', 'type': 'text'}], 'role': 'assistant'}], 'images': [<PIL.Image>, <PIL.Image>]}

But I get the following error:
ValueError: The number of image token (2) should be the same as in the number of provided images (1)

Are multiple images currently not supported?

It seems that the cause is the implementation of UnslothVisionDataCollator in unsloth_zoo's vision_utils.py
Specifically, changing:
def __call__(self, examples):
        # [TODO] Support non image inputs as well
        # The issue is batch = self.processor( forces tensors to be returned and not None.
        texts  = []
        images = []
        for example in examples:
            messages = example["messages"]
            message = self.processor.apply_chat_template(
                messages,
                tokenize = False,
                add_generation_prompt = False,
            )
            # Dataset with 2 columns messages / images
            if "images" in example:
                image = example["images"][0]
            else:
                image, video = process_vision_info(messages)
            texts .append(message)
            images.append(image)
        pass

To
def __call__(self, examples):
        # [TODO] Support non image inputs as well
        # The issue is batch = self.processor( forces tensors to be returned and not None.
        texts  = []
        images = []
        for example in examples:
            messages = example["messages"]
            message = self.processor.apply_chat_template(
                messages,
                tokenize = False,
                add_generation_prompt = False,
            )
            # Dataset with 2 columns messages / images
            example_images = []
            if "images" in example:
                example_images += example["images"]
            else:
                images, video = process_vision_info(messages)
                example_images += images
            texts.append(message)
            images += example_images
        pass

Resolves the issue.
I would open a PR but unsoth_zoo I've not found the unsloth_zoo's repo.

@GianlucaDeStefano   https://github.com/unslothai/unsloth-zoo

@dame-cell, I don't know how I did not see that.
I will open a pull request there.


Dagger2 @Provides(type=Set) and other collections fail

Return type of a provider method needs to be converted to the appropriate collection type when @Provides has an annotation parameter type=SET or SET_VALUES, or MAP.
This is mainly a note to myself. I'll fix this on another free day.

@Provides(type=SET) should now be resolved by pull request #26.
Still need to figure out how to resolve @Provides(type=MAP) correctly.


test_client.py: deserialization for Reference objects not working

Reference objects are not being deserialized, they are just returned in serialized JSON representation.
For example this is what we get when we print an aas_reference object that we get with the client:
{'keys': [{'type': 'AssetAdministrationShell',
           'value': 'https://acplt.org/Test_AssetAdministrationShell'}],
 'referred_semantic_id': None,
 'type': 'ModelReference'}

Fixed in 0b25e8774be8ae8d1c9b671584d45d97e1d5d883


Torrentio is broken -- Need host/port after enabling in Riven

New bug after closing #54 . I opened a ticket on the Riven repo directly for this one, and they referred me back to you/DMB again.
https://github.com/rivenmedia/riven/issues/722
Essentially the issue is that when I enable Torrentio in Riven settings, it crashes the Riven backend. Then when I restart the stack, it cannot load at all, and shuts down. When I asked for help, they said something about needing a host/port for it? I'm a bit confused.
I can modify and save other settings successfully, but when I enable Torrentio and save, this crashes.

You know what Profucius says?
You got me there haha! Although normally I am adept at handling bugs, but with the combination of being newish with docker, and Riven making deep changes, I'm a bit turned around here.

I've attached the config files (tokens obfuscated) via a zip file in the link below, figured that is easier. Thanks for taking a look.
profucius DMB configs.zip

Same issue for me. In fact, even after disabling torrentio manually from riven’s json settings, I get the same issue on startup and everything will eventually shut down - I’m not quite sure how to restore functionality.
I also tried a hard reset of Riven’s DB, but no luck.

This is what happens in the logs immediately after clicking Save after enabling Torrentio in Riven WebUI:
Sep 25, 2024 08:46:06 - ERROR - PostgreSQL subprocess: type "states" does not exist
Sep 25, 2024 08:46:06 - INFO - PostgreSQL subprocess: 2024-09-25 13:46:06.908 UTC [223] STATEMENT:  ALTER TABLE "MediaItem" ALTER COLUMN last_state TYPE states
Sep 25, 2024 08:46:06 - WARNING - riven_backend subprocess: | db.run_migrations - Error running migrations: (psycopg2.errors.UndefinedObject) type "states" does not exist
Sep 25, 2024 08:46:06 - INFO - riven_backend subprocess: [SQL: ALTER TABLE "MediaItem" ALTER COLUMN last_state TYPE states ]
Sep 25, 2024 08:46:06 - INFO - riven_backend subprocess: (Background on this error at: https://sqlalche.me/e/20/f405)
Sep 25, 2024 08:46:07 - INFO - riven_backend subprocess: Generating /riven/backend/data/alembic/2024_09_25_338ab47698b5_auto_upg_20240925084606.py ...  done
Sep 25, 2024 08:46:07 - ERROR - PostgreSQL subprocess: type "states" does not exist
Sep 25, 2024 08:46:07 - INFO - PostgreSQL subprocess: 2024-09-25 13:46:07.194 UTC [223] STATEMENT:  ALTER TABLE "MediaItem" ALTER COLUMN last_state TYPE states
Sep 25, 2024 08:46:07 - WARNING - riven_backend subprocess: | db.run_migrations - Error running migrations: (psycopg2.errors.UndefinedObject) type "states" does not exist
Sep 25, 2024 08:46:07 - INFO - riven_backend subprocess: [SQL: ALTER TABLE "MediaItem" ALTER COLUMN last_state TYPE states ]
Sep 25, 2024 08:46:07 - INFO - riven_backend subprocess: (Background on this error at: https://sqlalche.me/e/20/f405)
Sep 25, 2024 08:46:07 - INFO - riven_backend subprocess: Generating /riven/backend/data/alembic/2024_09_25_5df5b5413669_auto_upg_20240925084607.py ...  done
Sep 25, 2024 08:46:07 - CRITICAL - riven_backend subprocess: | main.<module> - Server has been stopped
Sep 25, 2024 08:46:08 - INFO - riven_backend subprocess: | 👾 API       | main.dispatch - GET /settings/load - 200 - 2.51s
Sep 25, 2024 08:46:08 - INFO - riven_frontend subprocess: TypeError: fetch failed
Sep 25, 2024 08:46:08 - INFO - riven_frontend subprocess: at node:internal/deps/undici/undici:12500:13
Sep 25, 2024 08:46:08 - INFO - riven_frontend subprocess: at process.processTicksAndRejections (node:internal/process/task_queues:95:5) {
Sep 25, 2024 08:46:08 - INFO - riven_frontend subprocess: [cause]: Error: connect ECONNREFUSED <IP_ADDRESS>:8080
Sep 25, 2024 08:46:08 - INFO - riven_frontend subprocess: at TCPConnectWrap.afterConnect [as oncomplete] (node:net:1605:16) {
Sep 25, 2024 08:46:08 - INFO - riven_frontend subprocess: errno: -111,
Sep 25, 2024 08:46:08 - INFO - riven_frontend subprocess: code: 'ECONNREFUSED',
Sep 25, 2024 08:46:08 - INFO - riven_frontend subprocess: syscall: 'connect',
Sep 25, 2024 08:46:08 - INFO - riven_frontend subprocess: address: '<IP_ADDRESS>',
Sep 25, 2024 08:46:08 - INFO - riven_frontend subprocess: port: 8080
Sep 25, 2024 08:46:08 - INFO - riven_frontend subprocess: }
Sep 25, 2024 08:46:08 - INFO - riven_frontend subprocess: }

And then in the Riven WebUI this shows:

And then I refresh the page and this shows:

With only this in the log:
Sep 25, 2024 08:47:37 - INFO - riven_frontend subprocess: }
Sep 25, 2024 08:48:08 - ERROR - The Riven backend process is not running.

Same issue for me. In fact, even after disabling torrentio manually from riven’s json settings, I get the same issue on startup and everything will eventually shut down - I’m not quite sure how to restore functionality.
I also tried a hard reset of Riven’s DB, but no luck.

This shouldn't be happening to you. I'm able to reverse it and get back into Riven again by simply changing this line to false in the Riven settings.json file, then restarting the stack (it takes about 3-5 minutes to fully boot)
        "torrentio": {
            "enabled": false,

Try deleting the Riven/data/alembic directory and restarting.

I tried this and it did not work.

As a last option, try deleting the PostgreSQL data directory and restarting.

Then I tried this, and it worked! Torrentio enabled successfully and Riven continued running. The downside is that I lost everything in the Library tab that Riven was tracking, but honestly that is a sacrifice I'm willing to make to get it running again.
Any idea how this might've happened? I'm currently assuming something went wrong with the recent Riven major changes.

Something's even more odd on my side.

I made sure that torrentio is disabled in settings.json, and it is. Restarted, didn't help.
I zapped the alembic directory. Restarted, the directory is not recreated, didn't help.
I zapped the pgsql data directory. Restarted, the data directory is recreated, didn't help.

Relevant part of the logs, for reference:
Sep 25, 2024 16:12:34 - INFO - Attempt 10/10 to fetch settings from http://<IP_ADDRESS>:8080/settings/get/all
Sep 25, 2024 16:12:34 - ERROR - Error fetching settings: HTTPConnectionPool(host='<IP_ADDRESS>', port=8080): Max retries exceeded with url: /settings/get/all (Caused by NewConnectionError('<urllib3.connection.HTTPConnection object at 0x7f29379c3f10>: Failed to establish a new connection: [Errno 111] Connection refused'))
Sep 25, 2024 16:12:34 - ERROR - Max retries reached. Failed to fetch settings from http://<IP_ADDRESS>:8080/settings/get/all
Sep 25, 2024 16:12:34 - ERROR - Error loading Riven settings: No active exception to reraise
Sep 25, 2024 16:12:34 - ERROR - An error occurred in the Riven backend setup: No active exception to reraise
Sep 25, 2024 16:12:34 - INFO - Shutdown signal received. Cleaning up...
Sep 25, 2024 16:12:34 - INFO - Stopping riven_frontend
Sep 25, 2024 16:12:34 - WARNING - riven_frontend process not found or already stopped.
Sep 25, 2024 16:12:34 - INFO - Stopping riven_backend
Sep 25, 2024 16:12:34 - INFO - riven_backend process terminated gracefully.

And this is the relevant part of my docker compose:
services:
  dmb:
    image: iampuid0/dmb:latest
    container_name: dmb
    restart: unless-stopped
    stop_grace_period: 60s
    stdin_open: true
    tty: true
    volumes:
      - /home/nosync/media/dmb/config:/config:rw
      - /home/nosync/media/dmb/log:/log:rw
      - /home/nosync/media/dmb/zurg/RD:/zurg/RD:rw
      - /home/nosync/media/dmb/zurg/mnt:/data:rshared
      - /home/nosync/media/dmb/riven/data:/riven/backend/data:rw
      - /home/nosync/media/dmb/riven/mnt:/mnt:rw
      - /home/nosync/media/dmb/pgsql/data:/postgres_data:rw
      ## Location for rclone cache if enabled
      - /data/cache/rclone:/cache:rw
      - /home/nosync/media/dmb/zilean/data:/zilean/app/data:rw
    environment:
      - TZ=Europe/Zurich
      - PUID=1000
      - PGID=1000
      - ZURG_ENABLED=true
      - ZURG_UPDATE=true
      - ZURG_LOG_LEVEL=info
      - RD_API_KEY=redacted
      - RCLONE_MOUNT_NAME=dmb
      - RCLONE_DIR_CACHE_TIME=10s
      - RCLONE_CACHE_DIR=/cache
      - RCLONE_VFS_READ_CHUNK_SIZE=1M
      - RCLONE_VFS_READ_CHUNK_SIZE_LIMIT=32M
      - RIVEN_ENABLED=true
      - RIVEN_BACKEND_UPDATE=true
      - RIVEN_FRONTEND_UPDATE=true
      - RIVEN_LOG_LEVEL=info
      - FRONTEND_LOGS=off
      - ORIGIN=https://redacted.proxy.com
      - PLEX_TOKEN=redacted
      - PLEX_ADDRESS=https://redacted2.proxy.com
      - DUPLICATE_CLEANUP=true
      - CLEANUP_INTERVAL=24
      - SEERR_API_KEY=redacted
      - SEERR_ADDRESS=https://redacted3.proxy.com
      - ZILEAN_ENABLED=true
      - ZILEAN_UPDATE=true
      - DMB_LOG_LEVEL=info
      - COLOR_LOG_ENABLED=true
    devices:
      - /dev/fuse:/dev/fuse:rwm
    cap_add:
      - SYS_ADMIN
    security_opt:
      - apparmor:unconfined
      - no-new-privileges
    healthcheck:
      start_period: 1m
      interval: 10s
      retries: 3
    networks:
      macvlan-docker:
        ipv4_address: <IP_ADDRESS>

It was likely due to the Riven update that required the database to be reset; new states were added. From the logs riven_backend subprocess: | db.run_migrations - Error running migrations: (psycopg2.errors.UndefinedObject) type "states" does not exist it was trying to migrate the database, but failing.

Interesting, I have painfully come to realize how huge of a change this Riven update was after all this. They said they'd announced it on their Discord, but I wasn't a member of it yet, but even if I had been I didn't see where they had used @everyone so I don't know if I'd have even been notified. I requested that they make it more clear on the github releases page when a breaking change occurs.
Would it be possible for you to reflect such major changes onto your github releases page too? The extra visibility would help prevent some potential catastrophes in the future, especially to those who have installed DMB but aren't following the original devs/discords.
One last question, is it possible to disable DMB from auto-updating all the contained softwares on every release? I'm currently assuming I just need to hardcode the version in the docker compose file for any software I don't want to update. I might do that in Riven for the time being so that I can have a break from this.

Sep 25, 2024 16:12:34 - INFO - Attempt 10/10 to fetch settings from http://<IP_ADDRESS>:8080/settings/get/all
Sep 25, 2024 16:12:34 - ERROR - Error fetching settings: HTTPConnectionPool(host='<IP_ADDRESS>', port=8080): Max retries exceeded with url: /settings/get/all (Caused by NewConnectionError('<urllib3.connection.HTTPConnection object at 0x7f29379c3f10>: Failed to establish a new connection: [Errno 111] Connection refused'))
Sep 25, 2024 16:12:34 - ERROR - Max retries reached. Failed to fetch settings from http://<IP_ADDRESS>:8080/settings/get/all
Sep 25, 2024 16:12:34 - ERROR - Error loading Riven settings: No active exception to reraise

I seem to remember seeing this during my testing. Try renaming your Riven settings.json file and restart the stack. It'll recreate a new one. If that works, then it's something in your Riven settings, it might be the "debug" flag set to enabled, that kept failing for me on the newest version. If that doesn't work, then you might try grabbing a clean docker compose yaml from the DMB repo and boot the stack with that. If that works, then deductively re-add your compose settings back in until you find the culprit. If none of that works, PUID might know what to do next.

Riven's breaking changes have been the bane of existence! I've requested the same. They use Semantic Versioning, as do I; however, Riven has not incremented the MAJOR field on a breaking change.
As for tracking it on the DMB repo, that's a bit difficult to do when no changes are required for the DMB code to support a Riven breaking change - where typically the indicator would be the MAJOR field for the DMB version.

I see, yes that is quite maddening isn't it. I've talked to other devs in the past about versioning, sometimes they can be staunch about it and it makes little sense to me why not just increment a major version, that's what it's for. Well I just want to say I appreciate you keeping things straight for us here on this repo!
Side note, I'm looking at hardcoding the versions in my docker compose for Riven (for a few weeks, then I'll read the changelogs and allow the update). I see there is a RIVEN_BACKEND_VERSION and RIVEN_FRONTEND_VERSION separately, but on the Riven repo I only see the one main release version (currently v1.14.1). Do I just use that version for both?
After this I'll duck out so the conversation doesn't get hectic with three people talking at once.

@NoSync I believe you should open a separate ticket for this, it appears to be a different issue at this point.

It was indeed a case of two separate issues caused by the latest riven update, one of them being the one mentioned in this ticket.
On one hand, the settings.json I had was no longer playing nice with the latest riven version. After I removed it, as you recommended, I got the same crashes as per OP when restoring my pgsql data directory, which were solved by zapping the data directory again. In short, should anybody else stumble upon this, to get everything to work nicely with the latest release both settings.json and the DB data had to be initialized from scratch.
I also cleaned up the logging vars in my docker-compose a little, as suggested by @I-am-PUID-0, although they weren't the culprits.
Thanks to both.

Glad you got it working! A cautionary tale to all: Riven is under heavy development. If they anounce major breaking changes, we should be prepared to delete (or use a file diff app to compare) the settings.json file, as well as potentially the whole PostgreSQL database folder if all else goes fubar.
Thanks to PUID as always for being patient with us AND with the Riven devs haha. Much love to all.


Click the "Contact the Help Desk" button should open the page in a new tab

From Center click the Help Icon in the common Toolbar
Click the "Contact the Help Desk" button
results - Help desk open in same window.
expected results - Help Desk system should open in a new tab

Passed on Latest.

Passed on Staging.


Building ord for Windows from source using syntax in readme results in bad build

tl;dr: Should we add a checkout command to the instructions on how to build ord from source on https://github.com/ordinals/ord?tab=readme-ov-file#building?
Hello all - please pardon any etiquette mistakes in this Issue report, it is my first and I'm not yet experienced with Github.
I built ord 0.15.0 for Windows from source using the Github clone commands found in the readme, here: https://github.com/ordinals/ord?tab=readme-ov-file#building
I then built the index with sats using 0.15.0 and everything seemed to be working fine.  The server would start and was accessible on the localmachine, the wallet I had started Bitcoin Core with would return a balance, ord --version returns 'ord 0.15.0', etc.  My issue is when I try to restore a non-ord wallet into ord, I receive the following error:

error: JSON-RPC error: transport error: Couldn't connect to host: A connection attempt failed because the connected party did not properly respond after a period of time, or established connection failed because connected host has failed to respond. (os error 10060)
0: std::backtrace_rs::backtrace::dbghelp::trace
at /rustc/5680fa18feaa87f3ff04063800aec256c3d4b4be/library\std\src....\backtrace\src\backtrace\dbghelp.rs:98
1: std::backtrace_rs::backtrace::trace_unsynchronized
at /rustc/5680fa18feaa87f3ff04063800aec256c3d4b4be/library\std\src....\backtrace\src\backtrace\mod.rs:66
2: std::backtrace::Backtrace::create
at /rustc/5680fa18feaa87f3ff04063800aec256c3d4b4be/library\std\src\backtrace.rs:332
3: std::backtrace::Backtrace::capture
at /rustc/5680fa18feaa87f3ff04063800aec256c3d4b4be/library\std\src\backtrace.rs:298
4: anyhow::error::<impl core::convert::From for anyhow::Error>::from
5: ord::wallet::Wallet::exists
6: ord::subcommand::wallet::restore::Restore::run
7: ord::subcommand::wallet::WalletCommand::run
8: ord::subcommand::Subcommand::run
9: ord::main
10: __ImageBase
11: __ImageBase
12: std::rt::lang_start_internal::closure$2
at /rustc/5680fa18feaa87f3ff04063800aec256c3d4b4be/library\std\src\rt.rs:148
13: std::panicking::try::do_call
at /rustc/5680fa18feaa87f3ff04063800aec256c3d4b4be/library\std\src\panicking.rs:500
14: std::panicking::try
at /rustc/5680fa18feaa87f3ff04063800aec256c3d4b4be/library\std\src\panicking.rs:464
15: std::panic::catch_unwind
at /rustc/5680fa18feaa87f3ff04063800aec256c3d4b4be/library\std\src\panic.rs:142
16: std::rt::lang_start_internal
at /rustc/5680fa18feaa87f3ff04063800aec256c3d4b4be/library\std\src\rt.rs:148
17: main
18: invoke_main
at D:\a_work\1\s\src\vctools\crt\vcstartup\src\startup\exe_common.inl:78
19: __scrt_common_main_seh
at D:\a_work\1\s\src\vctools\crt\vcstartup\src\startup\exe_common.inl:288
20: BaseThreadInitThunk
21: RtlUserThreadStart

I sought help on the Ordicord and Discord mod ETS recommended I try downloading a prebuilt version of ord instead of using my own.  I did so and attempted to use the index that I had built with my initial build of ord 0.15.0, but received this error:

error: index at F:\Bitcoin\ord_index\0.15.0\index.redb appears to have been built with a newer, incompatible version of ord, consider updating ord: index schema 17, ord schema 16
0:
1:
2:
3:
4:
5:
6:
7:
8:
9:
10:
11: BaseThreadInitThunk
12: RtlUserThreadStart

Discord mod ETS mentioned that this seemed to prove what he thought the issue may be - building from source using the syntax from the readme doesn't actually build the release as it was released, but instead builds the release with every single change in the source up until that point.  This isn't always a functioning build and can result in some errors for some functionality depending on the changes in the build at the time - at least, that is the issue as I understand it.
This was discussed in the Ordicord at the following links: https://discord.com/channels/987504378242007100/1069465367988142110/1209130700738138142 and https://discord.com/channels/987504378242007100/987504378749538366/1207049658002837514
According to Discord mod Greg, there should be a "git checkout 0.15.0 before the cargo command".
I think the fix here is just to update the readme directions.  I would love to be involved in submitting the fix or testing it or following this through to the end because I need experience in Github and I really want to contribute in any way possible to the project.
Please let me know if there is any further information that I can provide.
-cryptoni9n

Update: attempting to test the proposed fix with 0.16.0-rc1 by submitting the checkout request prior to building the release.  The following advice is presented:

PS C:\Users\xxx\ord16\ord> git checkout 0.16.0-rc1
Note: switching to '0.16.0-rc1'.

You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by switching back to a branch.

If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -c with the switch command. Example:

  git switch -c <new-branch-name>

Or undo this operation with:

  git switch -

Turn off this advice by setting config variable advice.detachedHead to false

HEAD is now at e5f48e6b Release 0.16.0-rc1 (#3185)

I'll provide more updates as this build and index complete in order to determine if this has resolved my original issue.

I was able to successfully build ord from source using the checkout command, so it works - but I'm not 100% sure if it is necessary.  Deferring to higher minds.

If you want to build from master you just clone the repo and do cargo build --release
If you want to build from a release you just do git checkout 0.14.1 and cargo build --release
This seems to work now, so I'll close the issue. Please reopen if not

If you want to build from master you just clone the repo and do cargo build --release
If you want to build from a release you just do git checkout 0.14.1 and cargo build --release

I think the point is that the build instructions @ https://github.com/ordinals/ord?tab=readme-ov-file#building lead users to build incorrectly as they don't include a call to a version checkout.

Build instructions on repos always assume building from master. We could add a small line that says how to checkout a specific version with git but the default should be master

https://github.com/ordinals/ord/pull/3304


Modularize generated code

Modularize generated code

Introducing a new restriction - model's filename should match the
generated model's class name.
Serializer implementation is not split into three files -
Serializer.cpp, Serializer_save.cpp and Serializer_restore.cpp
capnp.py indexes each model's field in top-down hierarchy rather than
bottom-up order. This ensures that a field from base class always
gets the same id regardless of the depth of inheritance.
classes.py now generates an implementation file for each model. This
is to reduce the bloat in Serializer related implementation files.
classes.py also incorporates the logic for cloning. Introduced a new
function BaseClass::DeepCopy(...) which walks the inheritance
hierarchy upwards to avoid duplicating the code in each subclass.
clone_tree_cpp.py is a stub as a result.
Serialization save/restore now takes advantage of the class hierarchy.

Known Issues

There is still code in clone_tree.cpp that belongs in model specific
implementation file.
Does capnp support 'extends' for structs? Documentation doesn't say
anything about it. If it does, serializer save/restore logic could
be lot simpler.
Ideally, model specific serialization logic should be in respective
implementation file but the declaration of such a function in the
header requires including UHDM.capnp.h - which is non-ideal. The
Reader/Builder classes for each capnp model are nested classes and
so they can't be forward declared.

@hzeller @alaindargelas This change is part one. A follow up PR would tackle the code duplication in vpi_user, vpi_listener and vpi_visitor.


stacked on v2-ack: add upd req+resp with workqueue

Add upd mgmt and request operation state machine
Publish upd_req message to agent topic
Wait for and verifies PUBACK from mqtt broker
Wait for upd_resp message in OnMessage callbacks
Create update and reporting work queues
Push the response json message body onto update work queue
Clang format and cmake format
Add enum to str functions

merged up to top pr stack that was merged to topic


Error due to accessing an entry in argv entry beyond the end of the list

Some toolkits, like Glut, might process the argument list before the program calls ultragetopt(), rewriting argc and the entries of argv.  This can leave a valid option identifier in argv[argc], which ultragetopt accesses and which leads to an error.
The following demonstration program
ultra_test2.zip
reproduces the situation by reducing argc by two before calling ultragetopt, and then reports on the argument list. It accepts options -a and -b, which take parameters.
Test 1: completes correctly
./ultra_test2 -a 1 bbb ccc
Before processing agument list (argc has been reduced by two):
argc = 3
argv[0] = './ultra_test2'
argv[1] = '-a'
argv[2] = '1'
Processing agument list:
option -a read, argument is '1'
After processing agument list:
ultraoptind = 3
Test 2: shows the issue occurring when the argument beyond the truncation point is a valid option identifier.
./ultra_test2 -a 1 -b ccc
Before processing agument list (argc has been reduced by two):
argc = 3
argv[0] = './ultra_test2'
argv[1] = '-a'
argv[2] = '1'
Processing agument list:
option -a read, argument is '1'
option -b missing required argument
After processing agument list:
ultraoptind = 4
ultraoptind is greater than argc
The fix might be to change ultragetopt.c:568
/* Sanity check (These are specified verbatim in SUS) */
if (ultraoptind > argc
to
/* Sanity check (These are specified verbatim in SUS) */
if (ultraoptind >= argc
Adrian.

Definitely a bug.  I think your fix is correct, but it has been a while since I last worked on this code.
I'm working on adding proper unit and behavior tests as part of the fix, to prevent any accidental regressions.  It may take me a little while to complete.  If I don't have it done in a few days, feel free to ping this issue.
Thanks again for taking the time to report this issue!

Thanks for reviewing this so quickly. I'll look out for the update.


[https://themes.lekoarts.de/]: webGL error on official page!

Description
If you enter in an environment where webGL is not active, an error occurs in the console window as follows.
Therefore, it would be nice to have a notification or a page that allows you to access the blog even if webGL is not enabled, or to activate webGL.

Unlike Chrome, Firefox works well! I've currently tried to enable webGL 2.0 on Chrome, but it doesn't seem to go well!

Steps to reproduce
Occurs in the default state of Chrome browser where webGL 2.0 is not enabled.
Expected result
Just letting you know that webGL is not active and you can't use it, like jstris, will help you a lot in terms of accessibility.

Actual result
What happened.
Environment

Thanks for the issue but I can't reproduce :)


Bug/2445 helper text 508

Pull Request

made helper text focusable so screen reader announces it

Need to combine my approach to satisfy both #2445 and #2281


Update to Kotlin 1.9.20 + add Wasm

This way we can add a new shiny WebAssembly target to Arrow
Furthermore, I've realized that we have several cases of duplicated code between JS and Native. Instead of adding yet another duplication with Wasm, I've added a nonJvmMain source set to gather all those.

I don't think Arrow suits a lot into something to be consumed by JS or TS, since you have native libraries doing similar things in those ecosystems. My point of view is that we should support those platforms so that people using KMP in them can also use Arrow in the Kotlin portion.
This is just a drop in the ocean, but one of my personal projects, https://deck.run/, compiles to JS from Kotlin, and uses Arrow. This wouldn't have been possible had we not published the JS versions of the libraries.

If you think this is correct, could you also generate a release, so we can then release the new 1.2.x version of Arrow with WebAssembly support? @raulraja @nomisRev

Merged! Could anybody make a new release, so we can update the dependency?

Merged! Could anybody make a new release, so we can update the dependency?

Do you not have the right permissions? 🤔 I'm on it!


Taze kod işalap dur

https://tr.pinterest.com/dns-query

Ozi işleya yone YouTube isledenok

Mende ba isleyani
сб, 14 нояб. 2020 г., 11:30 mayajyk<EMAIL_ADDRESS>
Ozi işleya yone YouTube isledenok
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/Jigsaw-Code/Intra/issues/365#issuecomment-727154304,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AQZPKIBTA7DD57TKNBAQRPDSPYPYDANCNFSM4TU7FGOA
.

berayde isleyan kody intran


strict equality '===' transformed to '== ='

Hi @Alxandr ,
First off, I really like this library. Thank you for making it available for people like me to use.
I came across an issue but I'm not too sure whether this is an issue with your lib or rshtml or something else 🤔  So I thought I'd ask you first.
When parsing inline scripts using html! it seems that it transforms all the strict comparison operators, that use three symbols, and splits them. For example:
if(active === true) { ... } would be transformed to if(active == = true) { ... }
Is this something that your lib would have control over or is it something that one of the dependencies manages?
Thanks

I need a bit more info about how you're embedding your script - but my best guess with what information I have is that it's a limitation of the rust macro system. Regardless, it's almost certainly not rstml-component.
To illustrate, the following works "as you would expect": html!(
some text
) - however, it's basically a big hack. The thing you have to remember is that anything you pass in to a rust macro has to be valid rust tokens (not syntax, just tokens). So first this gets parsed into a list of tokens (something like [LessThan, Ident(div), GreaterThan, Ident(some), Ident(text)....]). This removes all whitespace and comments. The "proper" way to deal with this (and what you probably want to do with embedded javascript) is this: html!(
"some text"
). Basically, make node content into strings.

The way that I have been adding the inline script is
html! (

	…
)

But given your explanation, it's something that I need to work around. No problem.
Thank you for explaining.

My recomendation - put it in a js file next to the rs file, and include it using one of the import macros.  It's a bit less "everything in one file" - but the alternative is a giant rust string which means no syntax highlighting.


subpackage version conflict with python2.7

Following the instructions at "Installation" section of README,
various sub-packages of pyannote would be installed using latest version.
Some would conflict with python2.7
downgrade some packages can make pyannote-change-detection -h works
Note: I'm doing it at 2018/2/5, Beijing
pip install --force-reinstall pyannote.database==0.11.2
pip install --force-reinstall pyannote.generators==0.13

In fact, this project has been merged into pyannote.audio. You can find more information here.
PS:
We move into python3 in the latest version.


Null border in CircularClipRoute

In CircularClipTransition, border is a BoxBorder? and docs say you can set it to null to disable it:

To disable the border, set [border] to null.

But in CircularClipRoute, border is a Boxborder, so you can't set it to null, so you can't disable border.
Please make CircularClipRoute.border nullable.

Thanks for reporting this. I published a fix.


Chapter 06: Unable to Publish COntainer Image

Dear @ThomasVitale,
On package job, the step to Publish Container Image is failing due to "denied: permission_denied: The requested installation does not exist." My Personal Access Token has the following permissions: delete:packages, gist, read:user, repo, user:email, workflow, write:org, write:packages. Here is the snippet of the failing step:
      - name: Log into container registry         uses: docker/login-action@v2         with:           registry: ${{ env.REGISTRY }}           username: ${{ github.actor }}           password: ${{ secrets.GITHUB_TOKEN }}       - name: Publish container image         run: docker push ${{ env.REGISTRY }}/${{ env.IMAGE_NAME }}:${{ env.VERSION }}
What could be the reason to fail the publishing of the image?
Thanks in advance.

@nmuianga when using the ${{ secrets.GITHUB_TOKEN }} placeholder, GitHub automatically injects a short-lived token configured with permissions that depend on what is configured in the workflow. The job in a workflow that is responsible for publishing images must declare the packages: write permission as follows.
package:
    name: Package and Publish
    runs-on: ubuntu-22.04
    permissions:
      contents: read
      packages: write
      security-events: write

The examples in the book follow this setup for publishing images having the following format: ${{ env.REGISTRY }}/${{ env.IMAGE_NAME }}:${{ env.VERSION }}. In particular, REGISTRY must be equal to ghcr.io and IMAGE_NAME must be exactly the same as the repository name. The GitHub Actions workflows in the book don't need you to create custom Personal Access Tokens since the token automatically provided by GitHub is enough.
There might be reason for which you can't use the automatically provided token. For example, if you need IMAGE_NAME to be something else than the repository name, but you still want to publish to the GitHub Container Registry (ghcr.io), then you can create a Personal Access Token as described in the book. That token needs the write:packages scope. Is this your use case?

You can then save the value of the newly generated token into a Secret in your GitHub repository. Since GITHUB_TOKEN is the name of the token automatically injected by GitHub, your custom token should have a different name to avoid conflicts. Could this be the reason for the error you experienced? In the snippet you shared, I can see that ${{ secrets.GITHUB_TOKEN }} is used. If you want to use your Personal Access Token (let's say you saved it as a Secret with name MY_CUSTOM_TOKEN) , then the value passed to the Docker Login action should be ${{ secrets.MY_CUSTOM_TOKEN }}.

Closing this for now. If you still have issues with publishing images, feel free to open a new issue. Thank you!


Realtime Data for Notifications, etc.

Hey @RealOlympusDev 😊
Do you mind expanding a bit on what you mean by "Realtime Data for Notifications, etc."? To understand whether it's something that can actually be implemented, maybe even for 2.0, which is currently in development, or not.
Thanks 💪

Look at mgp25's version:
https://github.com/mgp25/Instagram-API/tree/master/src/Realtime
https://github.com/mgp25/Instagram-API/blob/master/examples/pushReceiver.php
I believe they use Mqtt. To get messages, notifications, etc. (I doesn't use the actual apns).

Ok so it's actually closer to "streams", as I suspected.
Unfortunately, both Push and Realmtime in mpg25 are inconsistent, and (the public versions at least) have not been maintained in several years.
(e.g. one of the many issues stating they're unreliable)
Browsing through PR and issues in the past, it seems like the best scenario would be replicating the Realtime loop manually, forcing the request as time goes by (which is inconvenient, I agree).
Right now it appears to be the only 100% future-proof solution, and super easy to add to any endpoint, but I feel like it should be left to people using the library to implement it of their own accord.

But please, feel free to submit a pull request in case you come up with either a "fix" for Push and Realtime or an alternative solution to evaluate 💪 @RealOlympusDev


Add NOTTOOLONG macro for more clear code.

Also fix one missing use of it. Thanks to GitHub user Vort for finding
it and pointing out the fix.
Fied #4085

updated commit pushed with extra !good ness :)

can you tell i didn't compile on windows? :)  fixed three places.

Looks fine now.

merged, thanks!


Modernise Local Transaction results view

Trello: https://trello.com/c/CdUKR3M4/204-accessibility-local-look-up-fix-the-non-descriptive-button
This sets the font size in text to be a normal one rather than the
rather giant one that previously exited. It also includes more
supplementary information.
This changes the start button to be the less bold "start" button style
to be the more conventional success operation style. The text has been
changed to include the name of the local authority. This resolves in
accessibility issue that has been flagged in the Digital Accessibility
Centre's WCAG 2.1 audit of GOV.UK:

Screen reader comments:
“The button to move to the service of the relevant council announced to me as ‘Go to their
website’. It may be unclear to some screen reader users browsing out of context which
council the button relates to as the user may not have located the text situated within the
main content when browsing in context. I further would have expected to locate the feature
as a link, as a link would usually take the user to a different page or service. It would benefit
users if the item could be marked up as a link and could possess the name of the Council
within the link text to ensure screen reader users both in and out of context are aware of
what is being selected.”
Solution:
Consider implementing an more succinct label, that accurately conveys the function or
purpose of the ‘Go to their website’ button to prevent any unnecessary confusion.
Example:
<a class="gem-c-button govuk-button govuk-button--start gem-c-button--bottom-
margin" role="button" rel="external" href="https://www.npt.gov.uk/" >
Go to Neath Port Talbot County Borough Council website
</a>

Screenshots
Success before:

Success after:

No service link before:

No service link after:

No local authority link before:

No local authority link after:

⚠ This repo is Continuously Deployed: make sure you follow the guidance ⚠

Looks good!


Detect filesystem changes

$ git status
On branch master
Your branch is ahead of 'origin/master' by 1 commit.
  (use "git push" to publish your local commits)
Changes to be committed:
  (use "git reset HEAD <file>..." to unstage)

	new file:   test3c.txt
	new file:   test5.txt
	new file:   test6.txt

$ gl status
On branch master, repo-directory //

Tracked files with modifications:
  ➜ these will be automatically considered for commit
  ➜ use gl untrack f if you don't want to track changes to file f
  ➜ if file f was committed before, use gl checkout f to discard local changes

    test3c.txt (new file)
    test5.txt (new file)
    test6.txt (new file)

Untracked files:
  ➜ these won't be considered for commit
  ➜ use gl track f if you want to track changes to file f

    There are no untracked files to list

Go to my file manager, delete test5.txt and rename test6.txt to test7.txt.
$ git status
On branch master
Your branch is ahead of 'origin/master' by 1 commit.
  (use "git push" to publish your local commits)
Changes to be committed:
  (use "git reset HEAD <file>..." to unstage)

	new file:   test3c.txt
	new file:   test5.txt
	new file:   test6.txt

Changes not staged for commit:
  (use "git add/rm <file>..." to update what will be committed)
  (use "git checkout -- <file>..." to discard changes in working directory)

	deleted:    test5.txt
	deleted:    test6.txt

Untracked files:
  (use "git add <file>..." to include in what will be committed)

	test7.txt

$ gl status
On branch master, repo-directory //
✘ Some internal error occurred
  ➜ If you want to help, see http://gitless.com for info on how to report bugs and include the following information:

  0.8.4

  Traceback (most recent call last):
    File "/usr/local/Cellar/gitless/0.8.4/libexec/lib/python2.7/site-packages/gitless/cli/gl.py", line 73, in main
      return SUCCESS if args.func(args, repo) else ERRORS_FOUND
    File "/usr/local/Cellar/gitless/0.8.4/libexec/lib/python2.7/site-packages/gitless/cli/gl_status.py", line 45, in main
      for f in curr_b.status():
    File "/usr/local/Cellar/gitless/0.8.4/libexec/lib/python2.7/site-packages/gitless/core.py", line 753, in status
      yield self.FileStatus(fp, *self._st_map[git_s])
  KeyError: 513

I also had this problem.
I fused a branch to master, deleted the branch, tried to publish to origin/master but it said "✘ There are changes you need to fuse/merge", so I fused from origin/master, then removed some files (which I had just marked as resolved), then:
$ gl status
On branch master, repo-directory //

You are in the middle of a fuse; all conflicts must be resolved before commiting
  ➜ use gl fuse --abort to go back to the state before the fuse
  ➜ use gl resolve f to mark file f as resolved
  ➜ once you solved all conflicts do gl commit to continue

✘ Some internal error occurred
  ➜ If you want to help, see http://gitless.com for info on how to report bugs and include the following information:

  0.8.4

  Traceback (most recent call last):
    File "gitless/cli/gl.py", line 73, in main
    File "gitless/cli/gl_status.py", line 45, in main
    File "gitless/core.py", line 753, in status
  KeyError: 513

@spderosso I've also faced the KeyError: 513 error and it seems to be legitimated / assured by the following test case:
https://github.com/sdg-mit/gitless/blob/bd6761c8c7af85237e2c00f9a3ceda8b373744ec/gitless/tests/test_core.py#L483-L490
Does it mean that users aren't supposed to rm / rename tracked files? Or is this test some temporary condition (meant to be modified in the future)? I didn't understand it.
Thanks!

Thanks @megadr01d @langdon-holly @embs. This is a bug, the test case is wrong. The expected behavior if you remove a tracked file is for the file to be removed.


set "main" instead of "master" to indicate development branch

What type of PR is this?
/kind bug
What this PR does / why we need it:
The image creation currently fails since the script only considers "master" tag can be overwritten.
This commit replaces "master" with "main" to
indicate the development branch.
Which issue(s) this PR fixes:
Updates #74
Special notes for your reviewer:
Does this PR introduce a user-facing change?:

NONE

/cc @PrasadG193 @carlbraganza

/ok-to-test

/approve

/test pull-kubernetes-csi-external-snapshot-metadata-unit

I guess this needs to changed in https://github.com/kubernetes-csi/csi-release-tools/blob/master/build.make
And then merged into this repo.
I'll send a pr there tmr.

handled by https://github.com/kubernetes-csi/external-snapshot-metadata/pull/83


Run yarn build fails with<EMAIL_ADDRESS>on Windows when yarn.lock file has \n as EOL char.

What version of Turborepo are you using?
1.0.24
What package manager are you using / does the bug impact?
Yarn v1
What operating system are you using?
Windows
Describe the Bug
On Windows 10, the command yarn build fails with the following error when we have the EOL char as \n in yarn.lock file:
$ yarn build
yarn run v1.22.15
$ turbo run build
 ERROR  yarn.lock: could not unmarshal lockfile: yaml: line 17: could not find expected ':'
child_process.js:830
    throw err;
    ^

Error: Command failed: D:\Dropbox\projetos\js\turborepo-test\node_modules\turbo-windows-64\turbo.exe run build
    at checkExecSyncError (child_process.js:790:11)
    at Object.execFileSync (child_process.js:827:15)
    at Object.<anonymous> (D:\Dropbox\projetos\js\turborepo-test\node_modules\turbo\bin\turbo:5:26)
    at Module._compile (internal/modules/cjs/loader.js:1085:14)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1114:10)
    at Module.load (internal/modules/cjs/loader.js:950:32)
    at Function.Module._load (internal/modules/cjs/loader.js:790:12)
    at Function.executeUserEntryPoint [as runMain] (internal/modules/run_main.js:76:12)
    at internal/main/run_main_module.js:17:47 {
  status: 1,
  signal: null,
  output: [ null, null, null ],
  pid: 4316,
  stdout: null,
  stderr: null
}
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

This issue only happen using<EMAIL_ADDRESS>If I install the version 1.0.23 it builds fine.
With the EOL \r\n the build works fine in 1.0.24.
Info: I saw this error before in previous versions of Turborepo on Linux when we had \r\n in yarn.lock file as EOL char.
Expected Behavior
I think the command yarn build should work in Windows / Linux with both EOL char \r\n or only \n.
To Reproduce
Clone the following project in a Windows machine:
https://gitlab.com/viniciuspjardim/turborepo-test
I'm in the branch add-gitlab-ci, commit e1079eaff16afca3d1f72cf1e11b55d20dd986a5 now.
Make sure that Git did not change the EOL to \r\n in yarn.lock file.
Then run yarn install then yarn build. The last command is failing.

same issue.

Seems like a duplicate of https://github.com/vercel/turborepo/issues/471


how can I get the input size

now,I want to covert the mode to caffe; so I want to the input size; like this input = torch.ones([1, 3, 224, 224])

The model works with variable time lengths, and works with packed padded sequences. So something  like torch.randn(1, 2, num_seconds * sample_rate) is an acceptable input.


[EC-89] Accurately name sha3 functions in crypto

changed name of sha3 to kec256 and sha512 to kec512

I think this build failure is example that we have to run all tests locally (it:test)

LGTM! In relation with this, there is an opcode called SHA3 should we also rename it?

LGTM! In relation with this, there is an EVM opcode called SHA3, should we also rename it?

Good point but let's keep names of the opcodes the same as in YP.


K_SHORTEST_PATHS queries only support one variable in FOR

catch if the user gives more than one variable in grammar.y
also give a correct error message

https://jenkins01.arangodb.biz/view/PR/job/arangodb-matrix-pr/4112/


Screen for lobby transition

Story #7 Lobby
Sub-Tasks:

[x] CSS
[x] Join Lobby Button
[x] Create Lobby Button
[x] Back to Menu Button
[x] Click Functionality & Routing

Estimate: 0.5h

47c0e5889376208c5059dfc48eb5cefc97a24038


Boto3 has different keys for auto scaling tags - handle that gracefully

LGTM once the tests are passing. Thanks for doing this @william-richard!

Coverage decreased (-0.2%) to 93.223% when pulling c5ce2848befef6b8475da22d6ab3804493e19f6a on william-richard:asg-tags-propagate-at-launch into 385df46a0bc13a229c0fdf77e9c36041394cbfc7 on spulec:master.

Coverage increased (+0.002%) to 93.429% when pulling c5ce2848befef6b8475da22d6ab3804493e19f6a on william-richard:asg-tags-propagate-at-launch into 385df46a0bc13a229c0fdf77e9c36041394cbfc7 on spulec:master.


Bump rugged to latest release

Need this for this fix: https://github.com/libgit2/libgit2/pull/3000
/cc @vmg @simonsj

/cc @github/linguist Anything else need done before I push the button?

Looks good.

(you'll need to bump linguist now ;))

(you'll need to bump linguist now ;))

@adelcambre - I'm happy to do this if you like?

@arfon I need to do it in GitRPC first, so I can handle it.

:+1:

@arfon I was confused, but it would be awesome if you can release a new linguist. I'll handle getting it bumped in github.com/gitrpc after that.


precompute bug fix

This PR fixes 2 things:

Removes the assertion regarding the precompute factor needing to be a power of 2. There is no such requirement and it works just fine for other values too.
Fixes the average bucket size for the large buckets threshold - it depends on the precompute factor.

Merging with the failed spell check since it will be fixed in https://github.com/ingonyama-zk/icicle/pull/528


Test/fix aggregator

The resolve is being done with res instead of result?
Also, bulk_index under heavy load is printing different sizes in process_bulk and post process_bulk/split

Resolved.


added classical_sieve_of_eratosthenes.cpp

Description of Change

Added classical_sieve_of_eratosthenes.cpp in math
Checklist

[x] Added description of change
[x] Added file name matches File name guidelines
[x] Added tests and example, test must pass
[x] Relevant documentation/comments is changed or added
[x] PR title follows semantic commit guidelines
[x] Search previous suggestions before making a new one, as yours may be a duplicate.
[x] Sort by alphabetical order
[x] I acknowledge that all my contributions will be made under the project's license.

Notes:

👍 Great effort by the author and reviewer.
Could you please update documentation with standard similar to #807
Thank you.

@ayaankhan98 please review my last commit

@kvedala @ayaankhan98 please review my last commit

@kvedala what about the space complexity since last code was using an int static array  but this code uses bool dynamic array

@kvedala what about the space complexity since last code was using an int static array but this code uses bool dynamic array

i think you can fix that too in that file

@kvedala what about the space complexity since last code was using an int static array but this code uses bool dynamic array

try to do a print of sizeof(bool) and sizeof(char) -> they both return 1 i.e., both a boolean type and a character type occupy 1 byte of memory when compiled using GCC, MSVC. Some compilers like the Intel Compiler might be able to optimize it further to a 1 bit as one would not tally expect but this is not a necessity.
That being said, to your point, to reduce the memory space, all it needs is a change from int to bool and the overall algorithm remains the same.


Ferdi Portable - Extract to specific directory and do not delete

Hello there,
I'm running Ferdi portable on Windows in order to be able to transfer Ferdi easily between machines.
I noticed that Ferdi extracts itself in the temp folder and then deletes itself when the program closes. This creates problems with my firewall as in every new boot session I have to validate access to the internet for ferdi.exe.
Would there be a switch or something to make the portable version extract itself to a regular folder and not delete itself when exiting?
Thanks!

I'm having the same issue. Seems counter-intuitive to me call it portable when it really isn't.

Which artefact are you using for the portable version?

Latest release, Windows (Intel, 64bit, Portable). I believe it used to work but after upgrading I can't seem to get it to run in the execution directory. I think FerdiAppData used to reside there as well. Can't see it there after running Ferdi. Looks like it writes to appdata now all of the time.


[SPARK-34557][BUILD] Exclude Avro's transitive zstd-jni dependency

What changes were proposed in this pull request?
This PR aims to exclude Apache Avro's transitive zstd-jni dependency.
Why are the changes needed?
While SPARK-27733 upgrades Apache Avro from 1.8 to 1.10,
zstd-jni transitive dependency is created.
This PR explicitly prevents dependency conflicts.
BEFORE
$ build/sbt "core/evicted" | grep zstd
[info] 	* com.github.luben:zstd-jni:1.4.8-5 is selected over 1.4.5-12

AFTER
$ build/sbt "core/evicted" | grep zstd

Does this PR introduce any user-facing change?
No.
How was this patch tested?
Pass the CIs.

cc @wangyum

Test build #135534 has started for PR 31670 at commit beddb2b.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/40115/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/40115/

Could you review this when you have some time, @maropu ?

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/40115/

Thank you, @maropu . Merged to master.

Test build #135534 has finished for PR 31670 at commit beddb2b.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/135534/


feature: 提升云区域 Agent 安装效率 (closed #1699)

Codecov Report

:exclamation: No coverage uploaded for pull request base (v2.3.3-dev.1@adc8da1). Click here to learn what that means.
The diff coverage is 73.33%.

@@               Coverage Diff               @@
##             v2.3.3-dev.1    #1701   +/-   ##
===============================================
  Coverage                ?   73.14%
===============================================
  Files                   ?      390
  Lines                   ?    26484
  Branches                ?        0
===============================================
  Hits                    ?    19371
  Misses                  ?     7113
  Partials                ?        0

Impacted Files
Coverage Δ

apps/backend/agent/solution_maker.py
90.10% <ø> (ø)

...ackend/components/collections/agent_new/install.py
88.88% <ø> (ø)

apps/backend/components/collections/base.py
91.07% <71.42%> (ø)

apps/node_man/models.py
76.31% <100.00%> (ø)


For Microsoft 365 use ,

In case of Microsoft 365 smartrelay :
$XOAUTH2_CLIENT_ID" can't be mandatory.
$XOAUTH2_TOKEN_ENDPOINT parameter added.
If the application will be restricted to one tenant the token edpoint is neened

Thank you for the commit -- looks good!
The only thing I would fix is to:

update the documentation to state that Gmail endpoint is the default and
provide (at least an example) endpoint for Microsoft 365.

Happy to do (1), but I really don't know which endpoint is used by Microsoft.

Would you mind squashing your commits before we push them to main?

Hello,
Sorry for my delayed response.
sasl-oauth2 could be registered in Microsoft 365 in 2 way :

Public App : Everybody can use it and the endpoint is : https://login.microsoftonline.com/consumers/oauth2/v2.0/token
Tenant App : Only M365 account in the tenant can use and the endpoint is  https://login.microsoftonline.com/[TENANT_ID]/oauth2/v2.0/token

The maintainer of sasl-oauth2 update is documentation about it https://github.com/tarickb/sasl-xoauth2#outlookoffice-365-configuration-device-flow
Anyway , I'm not very comfortable yet with git , i ll squash / rebase my commits and pull it again.

I'll most likely take your changes then and apply them as a diff, without merging this commit.
Please give me a day or two to get other things sorted first.


Lact causes the screen to flicker when it's running when I choose anything above 120Hz !

Checklist

[X] The problem is not listed in the hardware support matrix as a known limitation
[X] I've included a debug snapshot if the issue is related to hardware configuration

Bug description
When I choose a refresh above 120Hz the screen start to show glitches and flickers.
https://github.com/user-attachments/assets/ab260e25-da05-4859-90b6-2a58e678e9fb
Reproduction
Simplified, easy to follow steps to reproduce the bug:
1.Run LACT
2.Choose a refresh above 120Hz
Actual result:
Screen shows glitches.
Expected result:
Run 165Hz without glitches.
Additional information
In order to avoid the glitch you shouldn't open LACT whatsoever, once you run it, even after closing the issue still persists.
LACT-sysfs-snapshot-20240730-200320.tar.gz
System info
CoreCtrl version: 1.4.1-2

Distribution: CachyOS

Kernel version: Linux 6.10.2-2-cachyos

GPU model: AMD RX 580 8GB

GPU driver:

❯ glxinfo | grep Mesa
client glx vendor string: Mesa Project and SGI
OpenGL core profile version string: 4.6 (Core Profile) Mesa 24.1.4-arch1.3
OpenGL version string: 4.6 (Compatibility Profile) Mesa 24.1.4-arch1.3
OpenGL ES profile version string: OpenGL ES 3.2 Mesa 24.1.4-arch1.3
❯ glxinfo | grep -e OpenGL.vendor -e OpenGL.renderer
OpenGL vendor string: AMD
OpenGL renderer string: AMD Radeon RX 580 Series (radeonsi, polaris10, LLVM 18.1.8, DRM 3.57, 6.10.2-2-cachyos)

GPU driver parameters: amdgpu.ppfeaturemask=0xffffffff

It’s possible setting your featuremask value to 0xfffd7fff fixes the flicker, in which case this is a driver problem and not a LACT problem.

It’s possible setting your featuremask value to 0xfffd7fff fixes the flicker, in which case this is a driver problem and not a LACT problem.

This might be true - you should try removing the ppfeaturemask option and enabling OC support via LACT instead. It will set the parameter to enable only the features needed for overdrive, and not everything like with 0xffffffff.

you should try removing the ppfeaturemask option and enabling OC support via LACT instead. It will set the parameter to enable only the features needed for overdrive, and not everything like with 0xffffffff

just learned about this. unfortunately this fails on atomic desktop as initramfs generation is a bit more complicated there. would it be possible to include the target value of ppfeaturemask in the error mask, or show it in the "Overclocking information" bubble (for example if /boot/efi is not writeable) to grab and set it manually?
on Fedora Silverblue 40 it will create /etc/modprobe.d/99-amdgpu-overdrive.conf but fail when trying to regenerate initramfs (small bug: the dialog still reports Success at the top):

This isn't an LACT issue it is a Linux DRM issue for AMD https://gitlab.freedesktop.org/drm/amd/-/issues/3449

It’s possible setting your featuremask value to 0xfffd7fff fixes the flicker, in which case this is a driver problem and not a LACT problem.

This might be true - you should try removing the ppfeaturemask option and enabling OC support via LACT instead. It will set the parameter to enable only the features needed for overdrive, and not everything like with 0xffffffff.

This worked for me. I removed the featuremask reference in grub, regenerated grub, rebooted, enabled overclocking via the toggle in LACT, rebooted, and viola - no more flickering when I change my memory clock.


Add click on cluster for expansion

@frodrigo : PR's not ready yet, sorry. I have to add fitBounds.options available for client customization if we want to take in account Vido's UI components.


Fix Rails/RootPathnameMethods autocorrection for Pathname calls without parens

# I run into case where...
file = File.open Rails.root.join 'spec', 'fixtures', 'pdfs', 'read_only.pdf'

# Got autocrrected to... 👇
file = Rails.root.join 'spec', 'fixtures', 'pdfs', 'read_only.pdf'.open

This autocorrection is invalid Ruby code. We can avoid it if we parenthesize Pathname methods before chaining like so:
file = Rails.root.join('spec', 'fixtures', 'pdfs', 'read_only.pdf').open

Before submitting the PR make sure the following are checked:

[x] The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
[x] Wrote good commit messages.
[x] Commit message starts with [Fix #issue-number] (if the related issue exists).
[x] Feature branch is up-to-date with master (if not - rebase it).
[x] Squashed related commits together.
[x] Added tests.
[x] Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
[x] Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.
[ ] If this is a new cop, consider making a corresponding update to the Rails Style Guide.

Thank you,Genadi!


Fix bugs in new groups UI.

First commit is to make "Cancel" button work in group creation form.
Second commit is to open groups UI with "#groups/your" hash when opening the groups UI from gear menu.
Third commit is to fix browser back button behavior when opening the groups UI by manually entering "#groups" hash.
Fourth commit is to empty the right panel based on url hash.

Fixes:  https://chat.zulip.org/#narrow/stream/9-issues/topic/new.20user.20group.20cancel.20button.20bugs.20out.20in.20group.20settings

Screenshots and screen captures:

Self-review checklist

[ ] Self-reviewed the changes for clarity and maintainability
(variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

[ ] Explains differences from previous plans (e.g., issue description).
[ ] Highlights technical choices and bugs encountered.
[ ] Calls out remaining decisions and concerns.
[ ] Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

[ ] Each commit is a coherent idea.
[ ] Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

[ ] Visual appearance of the changes.
[ ] Responsiveness and internationalization.
[ ] Strings and tooltips.
[ ] End-to-end functionality of buttons, interactions and flows.
[ ] Corner cases, error conditions, and easily imagined bugs.

Code changes look reasonable to me; @alya can do you a testing pass? We might want to backport this one to 8.x.

The first three points look good to me in manual testing (I didn't test super extensively). I'm not sure what the behavior to test is for the 4th point.
Remaining issues I came across when playing with the UI:

#28481 (I need to review a contributor PR)
If you leave a group, your access to settings doesn't immediately get updated in the UI. Instead, it still looks like you can control the settings, and you get an error if you try to change them. Not a big deal, but it would be nice if it live-updated, if it's not too tricky. (The members panel does immediately get updated.)

For fourth point -

Open the groups UI using gear menu.
Click on any of the groups (either in "Your groups" or "All groups" list).
Then click browser back button.
The right panel should become empty with hash being updated to "#groups/your" or "#groups/all" depending on from where the group settings was opened

Regarding live-update, I guess would be better to fix it as part of or after #26355 as that setting will determine who can edit the group settings.


Update NavigationView to meet MAS 4.1.2

Describe the bug
When testing our app accessibility, we had a bug assigned to us where the control type reported by the accessibility tool is not the expected one for NavigationViewItem and was breaking WCAG rule 4.1.2.
The NavigationViewItem are reporting a ListItem control type whereas they should report TabItem.
According to the AutomationControlType documentation we have:

ListItem:  A list item control, which is a child item of a list control.
TabItem: A tab item control, which represents a page of a tab control.

TabItem is a better fit for the navigation items.
Steps to reproduce the bug

Create an application with a navigation view with one or more navigation item.
Run the application
Run accessibility insights tool or the Windows narrator

Expected behavior
The NavigationViewItem should report AutomationControlType.TabItem as their control type
Screenshots

Version Info
NuGet package version:
Microsoft.UI.Xaml 2.2.190917002

@vgromfeld thank you for the bug report. The role of NavigationViewItems actually depends on NavigationView's PaneDisplayMode. The items are more similar to TabItem in top mode, and more similar (and are implemented using) ListItem in left mode. Sounds like we need to change the role dynamically.

If they perform a navigation, they behave like tabs.
If they display a flyout, they behave more like menu items.

@YuliKl, I think the NavigationViewItems can always keep the AutomationControlType.TabItem. They always behave as "navigation tabs" whether they are displayed in top or left mode

@YuliKl, I think the NavigationViewItems can always keep the AutomationControlType.TabItem. They always behave as "navigation tabs" whether they are displayed in top or left mode

I may be wrong, but I believe users have an expectation that tab items are laid out horizontally. Users will attempt to use left/right arrow keys to move between tab items, which won't work when NavigationView is in left mode.

So the change would be: change the role dynamically; ListItem in left nav and TabItem in top nav?


Reframe : Stitching scenes

Ubuntu version: Ubuntu 24.04.1 LTS
Python: Python 3.12.4
PyGMTSAR version: 2023.5.3
I am wondering how to set a code for stitching 2 scenes acquired on a particular date and along the same track with three subswaths in each scene. I already have orbit files. There are no pins (GDPs). If information on pins is not available,  how to set a code that sbas_reframe.py automatically stitch scenes.
I checked available notebooks but none have the code for the stitching. I run some codes but I get error that there are no pins defined.
I will appreciate any feedback on that :)

Of course, there are examples of how to stitch scenes. You can refer to the notebook ‘CENTRAL Türkiye Mw 7.8 & 7.5 Earthquakes Co-Seismic Interferogram, 2023’ available at https://insar.dev

Thanks a lot dear Alexey Pechnikov. Yes in the mentioned example, I found the code
sbas.compute_reframe() which will likely do it automatically.  Thanks a bunch :). I will give it a try in my office. Wish you a wonderful day...


Added TweetBot to the repo

Pull Request Template
script name -
What have you Changed
what you changed in the codebase.write here
Issue no.(must) -
Self Check(Tick After Making pull Request)

[x] This issue was assigned to me.
[x] One Change in one Pull Request
[x] My file is in proper folder (Name of folder should be in lowercase with no space in between)
[x] I am following clean code and Documentation and my code is well linted with flake8.
[x] I have added README.md and requirements.txt with my script

If issue was not assigned to you Please don't make a PR. It will marked as invalid.

@pawangeek
May you please give me a hint to find the correct linter for vscode ?!
I used to use PEP-8. So this time I don't want to lint it manually 🤯

That's awesome @ashkankamyab

@pawangeek
May you please give me a hint to find the correct linter for vscode ?!
I used to use PEP-8. So this time I don't want to lint it manually 🤯

You should user flake8 for this

Can you please add docstrings with class and functions including parameter and working. It's good for testing and end to end users

Well I am comfort using class 🙈 But if you explain more. I can give it a try.

Can you please add docstrings with class and functions including parameter and working. It's good for testing and end to end users

Well I am not comfort using class 🙈 But if you explain more I can give it a try.

Then just do that with functions. Just add what's the purpose and params at the top of functions using docstring (""" """)

That's awesome @ashkankamyab

@pawangeek
May you please give me a hint to find the correct linter for vscode ?!
I used to use PEP-8. So this time I don't want to lint it manually 🤯

You should user flake8 for this

is this approved?

Can you please add docstrings with class and functions including parameter and working. It's good for testing and end to end users

Well I am not comfort using class 🙈 But if you explain more I can give it a try.

Then just do that with functions. Just add what's the purpose and params at the top of functions using docstring (""" """)

Ahh, That's you mean. Ok! I will why not !

Perfect. Thanks for your contribution @ashkankamyab

Don't mention it 🍻 . See you in next PR 👍

@all-contributors please add @ashkankamyab for code


[xxx] Display custom maintenance page

Context
Signin is down and we're serving a default 504 page.
Changes proposed in this pull request
Add a proper service down page temporarily. Content copied from the Apply version
Guidance to review

Important business

Does this PR introduce any PII fields that need to be overwritten or deleted in db/scripts/sanitise.sql?
Does this PR change the database schema? If so, have you updated the config/analytics.yml file and considered whether you need to send 'import_entity' events?

Closing in favour of -> https://github.com/DFE-Digital/register-trainee-teachers/pull/2035#pullrequestreview-884423645


Does not show up in "shlex" search results: github.com/google/shlex

https://godoc.org/github.com/google/shlex page exists but does not show up in godoc.org search results: https://godoc.org/?q=shlex
Screenshot:

Some of the packages may be not reindexed due to some reason. Refreshed and it shows now.


SQL SERVER

Type: Bug
Whenever I tried to run SQL code, it keeps asking me for connection profile. I tried following the instructions, but it keeps giving back an error
VS Code version: Code 1.86.2 (903b1e9d8990623e3d7da1df3d33db3e42d80eda, 2024-02-13T19:40:56.878Z)
OS version: Windows_NT x64 10.0.22631
Modes:

System Info

Item
Value

CPUs
11th Gen Intel(R) Core(TM) i5-1135G7 @ 2.40GHz (8 x 2419)

GPU Status
2d_canvas: enabledcanvas_oop_rasterization: enabled_ondirect_rendering_display_compositor: disabled_off_okgpu_compositing: enabledmultiple_raster_threads: enabled_onopengl: enabled_onrasterization: enabledraw_draw: disabled_off_okskia_graphite: disabled_offvideo_decode: enabledvideo_encode: enabledvulkan: disabled_offwebgl: enabledwebgl2: enabledwebgpu: enabled

Load (avg)
undefined

Memory (System)
15.73GB (5.72GB free)

Process Argv
--crash-reporter-id 5bb650e9-2249-4060-b121-ba497683b1a1

Screen Reader
no

VM
0%

Extensions (8)

Extension
Author (truncated)
Version

codespaces
Git
1.16.10

data-workspace-vscode
ms-
0.5.0

mssql
ms-
1.22.1

sql-bindings-vscode
ms-
0.4.0

sql-database-projects-vscode
ms-
1.4.1

debugpy
ms-
2024.0.0

python
ms-
2024.0.1

vscode-pylance
ms-
2024.2.2

A/B Experiments
vsliv368:30146709
vspor879:30202332
vspor708:30202333
vspor363:30204092
vscorecescf:30445987
vscod805:30301674
binariesv615:30325510
vsaa593cf:30376535
py29gd2263:30899288
c4g48928:30535728
azure-dev_surveyone:30548225
2i9eh265:30646982
962ge761:30959799
pythongtdpath:30769146
welcomedialogc:30910334
pythonidxpt:30866567
pythonnoceb:30805159
asynctok:30898717
pythontestfixt:30902429
pythonregdiag2:30936856
pyreplss1:30897532
pythonmypyd1:30879173
pythoncet0:30885854
2e7ec940:30968132
pythontbext0:30879054
dsvsc016:30899300
dsvsc017:30899301
dsvsc018:30899302
bf62j303:30959262
pydisww1:30959800
edj9j583:30969295
7j2b6412:30969109
e3gdj431:30958358
ccp1r6:30958156

/causedByExtension
This functionality is provided by an extension and should be reported in extension's repo (don't forget to check for the duplicate)

This issue is caused by an extension, please file it with the repository (or contact) the extension has linked in its overview in VS Code or the marketplace for VS Code. See also our issue reporting guidelines. If you don't know which extension is causing the problem, you can run Help: Start extension bisect from the command palette (F1) to help identify the problem extension.
Happy Coding!


webpack.optimize delete comments in css first

Comments are useful in css while using postcss plugins, eg: postcss-px2rem
which transforms
.selector {
    width: 150px;
    height: 64px; /*px*/
    font-size: 28px; /*px*/
    border: 1px solid #ddd; /*no*/
}

to
.selector {
    width: 2rem;
    border: 1px solid #ddd;
}
[data-dpr="1"] .selector {
    height: 32px;
    font-size: 14px;
}
[data-dpr="2"] .selector {
    height: 64px;
    font-size: 28px;
}
[data-dpr="3"] .selector {
    height: 96px;
    font-size: 42px;
}

But webpack.optimize delete comments first, so postcss-px2rem could not generate the right result

+1

+1

how to solve this problem

+1

#537

+1

+1

+1

+1

+1

Don't related to webpack. Maybe problem in css-loader or other plugin for minify css. Feel free to open issue in css-loader or you plugin used for css minification. Thanks everyone!


Created new definitions for ko.plus library

New submission for ko.plus - this is a set of extensions for knockout.js
See https://github.com/stevegreatrex/ko.plus
Ran tests using tsc method, using TypeScript v1.4 compiler, no errors or warnings
npm test didn't work for some reason:
C:\Users\Howard\Documents\GitHub\DefinitelyTyped>npm test

><EMAIL_ADDRESS>test C:\Users\Howard\Documents\GitHub\DefinitelyTyped
> ./node_modules/.bin/dt --changes

'.' is not recognized as an internal or external command,
operable program or batch file.
npm ERR! weird error 1
npm ERR! not ok code 0

Hi Howard, thanks for this - the definitions all look good to me (though I must confess to having only a passing knowledge of TypeScript).
It looks like the problem running npm test is that it can't find the dt file - probably something wrong with the path concatenation.  Is there a grunt task or similar for running the typescript compilation and tests?

@Igorbek @moonpyk @conficient could you review this PR?

Looks like a huge rewrite for that part, the usage of union types requires latest version of the typescript compiler. Could be a problem for some users but shouldn't stop us from going forward.
HTML5 components is not an area I personally use at all, someone with better knowledge in that area should make a close review.
Besides that, the code looks cleaner and tests are passing (bu maybe we miss tests for that precise area ?)

Sorry @moonpyk - the original pull request was for just the two new ko.plus files - no idea why GitHub decided to add the changes to knockout as well - I'll try to remove them and redo in a different branch.

OK have have reversed the last commit to revert to the original knockout definitions. The pull request now only relates to new definitions for the ko.plus library.
Please could either @moonpyk  or @Igorbek please review?
ta

Could you make an interactive rebase of your commits to remove 920b8d64621f249331f2a17123148c446c212d32 and 86ca758d1cd9514cea55ff77072f0c406b6c007f completely from the picture, then push -f to your repo ? It will make history look better.
Regards.

Thanks @moonpyk I've done as requested - the pull request now only has the ko.plus entries. What a dangerous command that rebase is !

@conficient Very nice work :+1:
@vvakame Good to merge for me

@moonpyk thanks!
@conficient thanks mate!


doc: fixed windows installation typo

For windows binary installation we need binaries in $Env:ProgramFiles\containerd, the current command adds the binaries in $Env:ProgramFiles\containerd\bin.

cc @kevpar

haha, another contributor made the same change a little before you 😆. Lets try and land https://github.com/containerd/containerd/pull/8013

Apologies; dup of #8013 which was just merged. Closing; but thanks for the contribution


Automatic error report

<!---   *** BEFORE SUBMITTING: PASTE CLIPBOARD HERE TO COMPLETE YOUR REPORT ***   ---!>
I can't close the scripts window of jupyter notebooks

If you're using spyder-notebook, please uninstall it. We're not maintaining it at the moment because we don't have the resources to do it, sorry.


Feature Request (Blockbench loop types backport)

Blockbench loop types (play once, loop, hold onto last frame) don't work in-game for forge 1.19.2
Please, I really need this and probably many users will be also happy if this backport happens.

That feature was introduced by the devs of the geckolib mod so I have no control over it.


[Update] update firebase version 8.6.1 -> 8.10.1

Due to firebase version, we cannot use firebase in Dartpad.
Bless you!

Closing now that https://github.com/dart-lang/dart-pad/pull/2132 has landed cc: @srawlins


What's the best practice for expanding volume?

We start to test expanding volume. now we simply change weedfs volume -max=${VOLNUM}' to expand volume space. It might work. But we found an error volume %d not found in some random files throungth filer api.
Seaweedfs Version: 1.76
Here's our environment:

A server which runs master,filer,volume,etcd(for filer)
use linux_amd64_large_disk.tar.gz
volume binds it's data in /data which contains 8T free space.

Way to reproduce this problem:

start master with this command: -mdir=/master -volumePreallocate -volumeSizeLimitMB=60000
start volume with this command: -dir=/data -max=1. now we have 60G free space
upload many small files (5k~5M) to fullfill volume
after 5 hours it will be full. check some files throungh filer and no error happens.
restart volume with this command: -dir=/data -max=60. now we have ~3.6T free space
check some files throungh filer api and no error happens.
keep uploading small files for about 5 hours
check some files throungh filer api and get this error volume %d not found. but not all files are inaccessible.
if I restart volume with the same command (-dir=/data -max=60) again, these files can be accessed. but since we have a large mount of small files, it's hard to tell whether all files are accessible.

We want to know if change -max=? parameter is a correct way to expand volume space. If not, do we have to keep -max=? in a certain number and never change it again?
Thanks.

keep -max=? in a certain number and never change it again

max is just a limit. The actual volume will be created when it is needed. You do not need to change the max.


Add Remote Deployment through Docker

After creating your pull request, tick these boxes if they are applicable to you.

[x] I have tested my changes against the review branch (the latest developmental version), and this pull request is targeting that branch as a base
[x] I have tested my changes on Python 3.5.3 or higher

Description
What is this?
This PR adds the functionality to pass envvars into python using pydantic which fulfills the request in #2080. Furthermore it adds deployment scripts to push it to a docker-ready remote machine which the localhost has ssh access to.
What changed?

some preferences and options are now configurable via environmental variables prefixed with MUSICBOT_
streamlined the Dockerfile so that rebuilds do not take as long (e.g. moving the COPY step to after the installation of dependencies means that that layer doesn't need to be rebuild every time there is a change in the COPY layer)
Added a deploy script to push data into remote machine

How was this tested?
Setting up a musicbot on a remote machine.
Related issues (if applicable)

The Discord and Spotify tokens really should be mounted as secrets, but I couldn't find a clean way of mounting them without using K8s or Docker swarm which adds too much complexity on the remote machine side.

No response from PR'er. After discussion about potentially hosting the scrip(s) on a wiki page, or github pages as mentioned above, it was decided it would be more of a hassle to do for the time being.


Add resource conn

cat is_instance_volume_attachment.tf
resource "ibm_is_instance_volume_attachment" "tfer--ferocious_neon_various_twine_ngzi" {
  capacity                         = "100"
  delete_volume_on_instance_delete = "true"
  instance                         = "${ibm_is_instance.tfer--test_ansible_fpll.id}"
  name                             = "ferocious-neon-various-twine"
  profile                          = "general-purpose"
  volume_name                      = "test-ansible-boot-1663666597000"
}

@sergeylanzman can you please review and merge the changes. thanks


note on the y coordinate in numpy.meshgrid

Adding small explanation why images in continuous coordinates tutorial are upside down.

Thanks!  Yes, that's definitely a confusing topic.  I'm not completely sure it's clearer after these changes, though.  I'll have to think about whether there's a simpler way to explain all this...

Sorry for letting this sit for so long. Any other suggestions on this @jbednar? I'm going through old PRs trying to get them merged or closed. At minimum the grammar I just commented on should be fixed and the PR should be rebased so I can rebuild the test data.

I can't edit the PR, so I'll give @RafalSkolasinski one day to respond, but otherwise we should probably merge it and I can make the changes separately.

I can't edit the PR, so I'll give @RafalSkolasinski one day to respond, but otherwise we should probably merge it and I can make the changes separately.

Probably can't do that because I have to rebuild test data, but I can't do that without rebasing the PR first.

Not sure what you mean; we can merge it without rebasing, can't we?  True, the tests won't pass, bu then we could quickly fix that?

True, the tests won't pass, but then we could quickly fix that?

Right, generally try to avoid that, but I guess it's fine.

Should either merge this or close it since we'll be reorganizing the Tutorials soon.

It might be worth mentioning #1534 where we are discussing the possibility of making Image and Raster more consistent in future.

Going to close this PR, the material has moved at this point and we'll have to update the material once we make the planned changes to Raster and Image anyway.


.NET Standard 2.0 Assembly Used as R Package?

Is it possible to package a .NET Standard assembly as an R package such that R scripts can call into the .NET Standard assembly? Would any additional work need to be added to the .NET Standard assembly such that this level of integration is possible?
I see documentation that references .NET code calling into an R script, but nothing that references an R script calling into an assembly. Is this possible?

The simplest probably is to run C# as a process and call it via JSON RPC. You can use StreamJsonRpc library. We do exactly this calling C# from TypeScript in VS Code Python.
This would save you from trouble converting data types from R to C++ to C#.

Look at
https://github.com/Microsoft/PTVS/blob/master/Python/Product/VSCode/AnalysisVsc/Program.cs how to setup JSON RPC and https://github.com/Microsoft/PTVS/blob/master/Python/Product/VSCode/AnalysisVsc/LanguageServer.cs that has bunch of methods mapped to JSON requests. The project is .NET App 2.0


Add state related error code

(cherry picked from commit 70c9f9285286380234d8d99df150f6e3bf046430)
Description
Add an error code.
Changes include

[ ] Bugfix (non-breaking change that solves an issue)
[ ] New feature (non-breaking change that adds functionality)
[ ] Breaking change (change that is not backwards-compatible and/or changes current functionality)
[ ] Tests
[ ] Documentation
[x] Other (for changes that might not fit in any category)

Codecov Report

:exclamation: No coverage uploaded for pull request base (API_LEVEL_12@2bd83dd). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@               Coverage Diff               @@
##             API_LEVEL_12     #395   +/-   ##
===============================================
  Coverage                ?   69.09%
===============================================
  Files                   ?       11
  Lines                   ?      864
  Branches                ?        0
===============================================
  Hits                    ?      597
  Misses                  ?      267
  Partials                ?        0

Flag
Coverage Δ

unittests
69.09% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


[HV-1569] workaround gmavenplus issue to allow usage of properties ov…

…erridden on command line
https://github.com/groovy/GMavenPlus/issues/72
https://hibernate.atlassian.net/browse/HV-1569

Can one of the admins add this person to the trusted builders? (reply with: "add to whitelist" or "ok to test")

ok to test

@simkam waiting for CI to run but looks good to me.
Do you need a release with this included? I suppose you found that when testing the HV 6.0 upgrade for WildFly 12.

@gsmet no I don't need release right now. Yes, I started setting up TCK job.

@simkam cool, thanks for the fix, I just merged it!


'allel' module missing

Hi,
I've been trying to test your script out on my WGS data to identify inversions in Littorina saxatilis. I've downloaded your repository from GitHub, and checked the dependencies, but I get the following error whenever I try to run windowed_pca.py:
Script
python windowed_pcangsd.py /dir/input.vcf.gz /dir/Metadata.tsv /dir/Local_PCA LG17_SUPER_6:1-$chrom_length 10000 10000 0.05 1 Population Crab,Wave,Other Sex M,F
Error

Any ideas what's going on?

Hi and sorry for the slow response!
There are two scripts, windowed_pcangsd.py (which uses pcangsd) and windowed_pca.py (which uses scikit-allel). Your prompt uses windowed_pcangsd.py but the Error refers to the windowed_pca.py. Any chance there was a mixup of the two scripts?


MAISTRA-1821 Add support for ServiceMeshExtensions

/retest

rebased and renamed "mec" to wasm extensions and wasm cacher for clarity, here: https://github.com/maistra/istio-operator/pull/544


add option to skip vacuum analyzing on switchover

Merging. Will follow up with the fixes. Thanks again!


Audio cut off

Hi everybody,
I found a strange behaviour, at least in my Phoniebox installation. Everytime the last track of a playlist has about 2 seconds cut off. It only affects the last track of a list, everything track before the last track is played completely. I have already searched the various forums - without result. Not even this error has someone described.
The error occurs both when using the soundcard of the RasPi4 and with a HifiBerry.
The behavior is also reproducible on the command line when I call mpc manually. Does anyone know this and does anyone have a solution?
//Frank
Phoniebox version: 2.3 - 24258901 - master
Raspberry 4 with Raspian Buster (Linux 5.10.103-v7l+ armv7l)

I would assume, if this also happens when using mpc directly that this is an issue of mpc.

Closing as it seems to be an external issue of mpc and no interaction for a couple of months.
Feel free to reopen the issue, if the problem still occurs.


The rule reported an error

Caddyfile
        coraza_waf {
                include /waf/coraza.conf
                include /waf/coreruleset4/crs-setup.conf.example
                include /waf/coreruleset4/rules/*.conf
        }

Start error
# ./caddy start
2022/10/10 04:36:31.694 INFO    using adjacent Caddyfile
2022/10/10 04:36:31.696 WARN    Caddyfile input is not formatted; run the 'caddy fmt' command to fix inconsistencies    {"adapter": "caddyfile", "file": "Caddyfile", "line": 2}
2022/10/10 04:36:31.697 INFO    redirected default logger       {"from": "stderr", "to": "/data/test/access.log"}
Error: loading initial config: loading new config: loading http app module: provision http: server srv0: setting up route handlers: route 0: loading handler modules: position 0: loading module 'waf': provision http.handlers.waf: failed to compile rule (error parsing regexp: invalid or unsupported Perl syntax: `(?<`): FILES_NAMES|FILES "@rx (?<!&(?:[aAoOuUyY]uml)|&(?:[aAeEiIoOuU]circ)|&(?:[eEiIoOuUyY]acute)|&(?:[aAeEiIoOuU]grave)|&(?:[cC]cedil)|&(?:[aAnNoO]tilde)|&(?:amp)|&(?:apos));|['\"=]" "id:920120,phase:2,block,t:none,t:urlDecodeUni,msg:'Attempted multipart/form-data bypass',logdata:'%{MATCHED_VAR}',tag:'application-multi',tag:'language-multi',tag:'platform-multi',tag:'attack-protocol',tag:'paranoia-level/1',tag:'OWASP_CRS',tag:'capec/1000/210/272',ver:'OWASP_CRS/3.3.4',severity:'CRITICAL',setvar:'tx.anomaly_score_pl1=+%{tx.critical_anomaly_score}'"
Error: caddy process exited with error: exit status 1

Same issue using Caddy v2.6.1 and and Coreruleset v3.3.4. Coreruleset Nightly from today produces:
failed to compile rule (error parsing regexp: invalid nested repetition operator: `*+`): REQUEST_HEADERS:Accept "!@rx ^(?:(?:\*|[^\"(),\/:;<=>?![\x5c\]{}]+)\/(?:\*|[^\"(),\/:;<=>?![\x5c\]{}]+))(?:\s*+;\s*+(?:(?:charset\s*+=\s*+(?:\"?(?:iso-8859-15?|windows-1252|utf-8)\b\"?))|(?:(?:c(?:h(?:a(?:r(?:s(?:e[^t\"(),\/:;<=>?![\x5c\]{}]|[^e\"(),/:;<=>?![\x5c\]{}])|[^s\"(),/:;<=>?![\x5c\]{}])|[^r\"(),/:;<=>?![\x5c\]{}])|[^a\"(),/:;<=>?![\x5c\]{}])|[^h\"(),/:;<=>?![\x5c\]{}])|[^c\"(),/:;<=>?![\x5c\]{}])[^\"(),/:;<=>?![\x5c\]{}]*(?:)\s*+=\s*+[^(),/:;<=>?![\x5c\]{}]+)|;?))*(?:\s*+,\s*+(?:(?:\*|[^\"(),\/:;<=>?![\x5c\]{}]+)\/(?:\*|[^\"(),\/:;<=>?![\x5c\]{}]+))(?:\s*+;\s*+(?:(?:charset\s*+=\s*+(?:\"?(?:iso-8859-15?|windows-1252|utf-8)\b\"?))|(?:(?:c(?:h(?:a(?:r(?:s(?:e[^t\"(),\/:;<=>?![\x5c\]{}]|[^e\"(),/:;<=>?![\x5c\]{}])|[^s\"(),/:;<=>?![\x5c\]{}])|[^r\"(),/:;<=>?![\x5c\]{}])|[^a\"(),/:;<=>?![\x5c\]{}])|[^h\"(),/:;<=>?![\x5c\]{}])|[^c\"(),/:;<=>?![\x5c\]{}])[^\"(),/:;<=>?![\x5c\]{}]*(?:)\s*+=\s*+[^(),/:;<=>?![\x5c\]{}]+)|;?))*)*$" "id:920600,phase:1,block,t:none,t:lowercase,msg:'Illegal Accept header: charset parameter',logdata:'%{MATCHED_VAR}',tag:'application-multi',tag:'language-multi',tag:'platform-multi',tag:'attack-protocol',tag:'paranoia-level/1',tag:'OWASP_CRS',ver:'OWASP_CRS/4.0.0-rc1',severity:'CRITICAL',setvar:'tx.inbound_anomaly_score_pl1=+%{tx.critical_anomaly_score}'"

I've tried different versions of Coreruleset and have different problems. Feeling that it cannot be used in production yet

Hey, since CRS v4,, we have been struggling with regression issues; we are working together to make this work: https://github.com/coreruleset/coreruleset/issues/2848.
We are adding Github actions to CRS to avoid this to ensure RE2 (golang regex) compatibility.
We also have to upgrade coraza-caddy to the latest coraza v3 commit, as we added support for new ModSecurity features required by CRS 4.
We will be posting soon some proper measures to avoid this from happening in the future.

It is recommended to maintain a set of available rule versions by yourself to avoid production accidents caused by updating the official coreruleset rules.

Open discussion @corazawaf/core-developers. Until CRS ensures RE2 regression, we could maintain a Coraza-compatible CRS fork.

This issue is now fixed, please update CRS: https://github.com/coreruleset/coreruleset/pull/2862

Is anyone still having this issue? I am still getting it with branches v4.0/dev, v3.3/dev and v3.3/master. I do not have the issue for v4.0/main or v3.4/dev but I would assume these rulesets are out of date.

Hello, @rholden3 it actually works for me with OWASP_CRS/4.0.0-RC1. I tried OWASP_CRS/3.2.3 and OWASP_CRS/3.3.4 and i still have the same error "failed to compile rule"

Upgrading to v4 and https://github.com/corazawaf/coraza-caddy/releases/tag/v1.2.2 is the solution to this


Doesn't work for me

Hello, I used this old click crystal before and it was the best mod I've ever had. After the update it even improved more, but it doesn't work. Like I can set everything up, but it doesn't change anything. How can I fix that?

btw I play on 1.20.2. Maybe it's because of the version?

You're going to have to explain more in detail. I don't know what's wrong on your side. "It doesn't work" doesn't explain anything.

Issue closed due to no response within 3 days.


try to add this to my styles.css, but it went missing background-image: url("http://localhost:3000/images/logo.png");

background-image: url("http://localhost:3000/images/logo.png");

the lines gets removed in dev & build output

Latest version fixed that bug, can you upgrade and check if it works?

@hannoeru Im on the latest

latest version is v0.10.4

@hannoeru I think it works! thanks;


Fix type definition of UTCDateMini

Now new UTCDateMini(2020, 0, 1) in TypeScript raises type error 'Type 'UTCDate' has no construct signatures.', and this PR will fix it.

Shipped as<EMAIL_ADDRESS>


[Question] issue with the jump_cursor_with_keybrd_layout function

Hello, I just learned about and use this project recently. It is awesome, and my favorite function is the jump_cursor_with_keybrd_layout, by which I can say goodbye to my mouse.
However, I find that when more than one monitor are connected, this jump function seems to work weirdly. When I type , the cursor jump to the mid-bottom, the red position in the pic, in my no.1 monitor.

And the cursor never jumps to my no.2 monitor by the . I think the best effect is to detect the screen where the cursor is located, and then perform this jump only with the detected monitor.

(this is my monitor layout)
In addition, I am using a 61-key layout keyboard, is it possible to use this function within the alphabet area? How should I set it？

I created patch for keyboard projection on the monitor where the cursor is located.
I will add it officially in v4.4.0, but if you want to use it as a beta version, you can build it by installing MSVC and NSIS and running the following.
$ . /tools/setup_libs.bat issue99 -msvc 64
$ . /tools/create_assets.bat issue99 -msvc 64

If you want to use it for your preferred keyboard layout, write custom.kmp file in the config directory and link the screen coordinates to the key codes. The coordinates are normalized by the maximum value of x and y, respectively.
set keybrd_layout=custom.kmp

ref. https://github.com/pit-ray/win-vind/blob/2d7c1cda120eef31083ba689e94e855eb31f9bf3/res/default_config/US.kmp
If it is a general keyboard layout for your language, you can share the created .kmp file for other people. If then, add the .kmp file into res/default_config and register it like this, and please send pull request.
Thanks for using it.

Thanks a lot, I will try it when I am avalible.