feat: control/configure default ClusterFilters (helm chart)

What this PR does / why we need it:
Allows users to control and slightly configure the deployment of default ClusterFilters, this is useful for when users have their own ClusterFilter being deployed which overlaps with the defaults.
Which issue(s) this PR fixes:

Fixes #
Does this PR introduced a user-facing change?

New values defined to allow users to control the deployment of the default ClusterFilters.
The default values match the existing behaviour today.

fluentbit:
  filter:
    kubernetes:
      enable: true
      labels: false
      annotations: false
    containerd:
      enable: true
    systemd:
      enable: true

Additional documentation, usage docs, etc.:

https://github.com/fluent/fluent-operator/blob/master/charts/fluent-operator/templates/fluentbit-containerd-config.yaml Does this one need to be dealt with as well?

Hey @wenchajun, yes that does look like it should be covered by .Values.fluentbit.filter.containerd.enable, I've updated the pull request.


CPU Monitoring update

Delegates the CPU to a separate thread. Some interesting behavior observed:
The sample app deadlocks with the Debugger on. I believe, this is because the debugger expects Thread to be released before calling the GC on the destructor , and the GC won't release TrakerrClient until the thread it's holding onto clears up. The fix is simple, raise the graceful shutdown manually, and it will proceed with disposing the thread and releasing the TC the debugger holds. The line is included with the sample app, to be un-commented. THIS ONLY HAPPENS IN A DEBUGGING ENVIRONMENT. The sample app runs fine without the debugger.
I also extended the java design just slightly to include an reference manager. I decided that if people wanted to close their logger but keep the application running for whatever reason, we shouldn't keep it going, so I keep track of the number of instances the cpuperf is 'created' from. Each shutdown check to see if someone is still using the thread, and shuts down only when it reaches 0 under graceful shutdown calls. You can interrupt the thread forcefully, of course and that will pass an abort, although this isn't exactly graceful.

Add code comments before merge.


Multiple DefaultHttpClientFactory container registrations

It seems the class DefaultHttpClientFactory is being registered multiple times into the container because the base AddHttpClient uses the instruction AddSingleton<DefaultHttpClientFactory>(); instead of TryAddSingleton<DefaultHttpClientFactory>();.
https://github.com/aspnet/Extensions/blob/52b4a202090891dd254ae83ab97b01a99b5f0eb9/src/HttpClientFactory/Http/src/DependencyInjection/HttpClientFactoryServiceCollectionExtensions.cs#L35-L38
I believe this isn't an intended behavior and will cause multiple registrations when using the example code provided by the documentation:
// Startup.cs
//Add http client services at ConfigureServices(IServiceCollection services)
services.AddHttpClient<ICatalogService, CatalogService>();
services.AddHttpClient<IBasketService, BasketService>();
services.AddHttpClient<IOrderingService, OrderingService>();

Sure. In practice this isn't a problem unless you retrieve DefaultHttpClientFactory an an IEnumerable<> but I see no reason why not to do the most correct thing :+1:

Fixed by #1682


prepare GA for the first focus group

collect required events to measure business objectives.

https://developers.google.com/analytics/devguides/collection/analyticsjs/events?hl=ru


move freq params to dataloader

move freq params to dataloader
Description
The frequency should be tranparent to data handler.
Screenshots of Test Results (if appropriate):

Pipeline test:
Your own tests:

Types of changes

[ ] Fix bugs
[X] Add new feature
[ ] Update documentation

@bxdd  I've removed kwargs now.
Please let me know if there are any other problems  :) w


Sidebar alignment

Currently the sidebar of the dew-drop theme will shrink both margin. Is it possible to only shrink the right margin.
On the other hand, sometimes if there are too many level, the sidebar may overflow.

config-page(margin: (right: 10em)) and sidebar: (width: 10em,)


feat: let textarea grow based on value

Description
Let textareas grow upto 90vh based on their content. This approach may seem more complex than the minHeight=outerHeight method, but it avoids jankiness by being declarative and letting CSS do the heavy lifting.

[x] I have read and understand the CONTRIBUTING.md document in this repository

Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Checklist:

[ ] I have added tests that prove my fix is effective or that my feature works
[x] Existing test suite passes locally with my changes
[ ] I have made corresponding changes to the documentation

Thank you @thgh and @JessChowdhury - good feature!!!


REST API doesn't start; generating stager fails with REST API call

The REST API won’t start due to a bug:
./empire --rest --username "emp" --password "emp"
[*] Loading modules from: /mnt/hgfs/cjones/Empire/lib/modules/

Starting Empire RESTful API on port: 1337
RESTful API token: 2bjmeuwa6pr6yy4x0n88rauyyl1nve7cekdgkefh
Traceback (most recent call last):
File "/usr/lib/python2.7/logging/init.py", line 853, in emit
msg = self.format(record)
File "/usr/lib/python2.7/logging/init.py", line 726, in format
return fmt.format(record)
File "/usr/lib/python2.7/logging/init.py", line 465, in format
record.message = record.getMessage()
File "/usr/lib/python2.7/logging/init.py", line 329, in getMessage
msg = msg % self.args
TypeError: %d format: a number is required, not str
Logged from file _internal.py, line 87

After casting the port from a string to an int, the REST service works.
Also, when calling the API to create a stager, the .dll is not actually
written to disk.

I can't recreate this bug on master or dev. Additionally, for stager generation, we don't want the output to be written to disk for the server, but rather returned in a transport-safe (base64) format caller to keep the responsibility for file ingestion/processing with the REST client. Also, for future pull requests, please submit to the development branch instead of master.
I'm going to close this PR, but if you would like to resubmit to dev with just the "port=int(port)" fix we'll land it.

Thank you for the feedback and the work on this.  I'll use dev from now on.


Misspelling of words：registery -> registry

What is the purpose of the change
Misspelling of words：registery -> registry

Sorry, changes have been made.


chore: import repository https://github.com/testingcicdorg/jx3-python-app2.git

this commit will trigger a pipeline to generate the CI/CD configuration which will create a second commit on this Pull Request before it auto merges

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please assign
You can assign the PR to them by writing /assign  in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Restarting Jenkins Runbook

Restarting Jenkins is an occasional but necessary service interruption. To minimize developer impact when updating TVM's Jenkins, follow these steps:

Notify users:

message the TVM Discord with a couple hours notice

PSA that we'll be restarting Jenkins soon to <insert reason> -- we will need to retrigger in-flight builds as part of this process, so expect CI slowdowns for the next few hours.

In Jenkins under Manage Jenkins > Configure System > System Message set it to something like

Jenkins will restart on 3/22/22 at 10 AM PDT (details)

Save a list of in-flight jobs (i.e. by saving the webpage at ci.tlcpack.ai to disk)

Re-deploy Jenkins through these steps:

Apply the terraform from https://github.com/tlc-pack/ci-terraformgit clone https://github.com/tlc-pack/ci-terraform
cd ci-terraform
# set aws credentials to access state
terraform workspace select tvm-ci-prod
terraform apply -var-file=vars/tvm-ci-prod.auto.tfvars

Pull the Terraform output to the head node by running this GitHub Actions workflow
Trigger a workflow_dispatch event on this GitHub Actions workflow

Wait for Jenkins to come up (5-ish minutes)

Cancel any jobs that Jenkins re-queued (due to this issue Jenkins may re-schedule old jobs). These JavaScript snippets can help:
// cancel all jobs from the main Jenkins page at ci.tlcpack.ai
const cancel = (x) => {
    let href = x.parentNode.href;
    console.log(href)
    new Ajax.Request(href);
}
document.querySelectorAll("img[alt=\"cancel this build\"]").forEach(cancel)
document.querySelectorAll("img[alt=\"terminate this build\"]").forEach(cancel)

// list unique in-flight and queued job URLs from the saved webpage HTML
let builds = Array.from(document.getElementById("executors").querySelectorAll("table[tooltip]")).map(x => x.previousSibling.href)
let builds = [];
document.getElementById("buildQueue").querySelectorAll("a[tooltip]").forEach(a => {
    builds.push(a.href)
})
builds = [...new Set(builds)];
for (const b of builds) {
    console.log(b);
}

Monitor CI for the next day to ensure that autoscaled nodes are being allocated / deallocated as necessary

this has been merged into the docs, so we don't need the issue anymore (any updates can come as a PR to the README)


Mail::Utilities.to_crlf Improvement

Mail::Utilities.to_crlf seems like it can be changed to not use a Regexp instead by using String#encode.
Running this test:
require 'benchmark'

CRLF = "\r\n"
CRLF_REGEX = Regexp.new("(?<!\r)\n|\r(?!\n)")

string = "\n\r\n\n" * 10_000

Benchmark.bm do |x|
  x.report('to_crlf:') do
    10_000.times do
      string.gsub(CRLF_REGEX, CRLF)
    end
  end

  x.report('encode:') do
    10_000.times do
      string.encode(:universal_newline => true).encode!(:crlf_newline => true)
    end
  end
end

... I get these results on 2.3.0:
       user     system      total        real
to_crlf: 57.450000   0.120000  57.570000 ( 57.580348)
encode:  7.790000   0.090000   7.880000 (  7.889390)

Am I missing something here?  I will put in a PR if not.

I'm not a maintainer or anything, but I say make a PR, include this perf info there. If all the tests still pass in the CI run for the PR, I can't see why they'd turn it down.

Please do pursue a PR! Note we support older rubies, so we'd need
version-specific shims.
On Thu, Jan 14, 2016 at 12:30 Kevin Glowacz<EMAIL_ADDRESS>wrote:

I'm not a maintainer or anything, but I say make a PR, include this perf
info there. If all the tests still pass in the CI run for the PR, I can't
see why they'd turn it down.
—
Reply to this email directly or view it on GitHub
https://github.com/mikel/mail/issues/955#issuecomment-171752795.

:metal:


Question about Faster R-CNN ResNet_FPN backbone

I was wondering the function resnet_fpn_backbone defined in https://github.com/pytorch/vision/blob/master/torchvision/models/detection/backbone_utils.py, why freeze layers except layer2,layer3 and layer4? Why the first conv7x7 and layer1 also need to freeze?
Thanks!

Not a complete answer, but I would say it is because the conv7x7 takes a lot of time to compute (and so even more to backpropagate) and is very unlikely to change since it is pre-trained on ImageNet. This is probably the same for the first layer.

This is what the original Fast R-CNN paper did, see section 4.5 in the paper for more details, which I copy in part here.

Does this mean that all conv layers should be fine-tuned? In short, no. In the smaller networks (S and M) we find that conv1 is generic and task independent (a well-known fact [14]). Allowing conv1 to learn, or not, has no meaningful effect on mAP. For VGG16, we found it only necessary to update layers from conv3 1 and up (9 of the 13 conv layers). This observation is pragmatic: (1) updating from conv2 1 slows training by 1.3× (12.5 vs. 9.5 hours) compared to learning from conv3 1; and (2) updating from conv1 1 over-runs GPU memory. The difference in mAP when learning from conv2 1 up was only +0.3 points (Table 5, last column). All Fast R-CNN results in this paper using VGG16 fine-tune layers conv3 1 and up; all experiments with models S and M fine-tune layers conv2 and up.


[0.3.0] Manifest does not contain contract address

no contract addresses (world or systems) are present in the manifest, but these are needed for clients

i think this is covered by https://github.com/dojoengine/dojo/issues/748


Sort configuration key alphabetically

Ref: https://github.com/bbatsov/rubocop/pull/5174
Additions to config/enabled.yml are inserted alphabetically.
However, since config/enabled.yml is not currently in alphabetical order, it sorts it.

Before submitting the PR make sure the following are checked:

[x] Wrote good commit messages.
[ ] Commit message starts with [Fix #issue-number] (if the related issue exists).
[x] Used the same coding conventions as the rest of the project.
[x] Feature branch is up-to-date with master (if not - rebase it).
[x] Squashed related commits together.
[ ] Added tests.
[ ] Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
[x] All tests(rake spec) are passing.
[x] The new code doesn't generate RuboCop offenses that are checked by rake internal_investigation.
[x] The PR relates to only one subject with a clear title
and description in grammatically correct, complete sentences.
[x] Updated cop documentation with rake generate_cops_documentation (required only when you've added a new cop or changed the configuration/documentation of an existing cop).

Good catch! But unfortunately the config file is not sorted completely.
# Preparing
$ git checkout origin/master
$ cp config/enabled.yml before.yml
$ git checkout wata727/sort_enabled_yml
$ cp config/enabled.yml after.yml

# A script to check equivalent. It's ok
$ ruby -ryaml -e 'p YAML.load_file("before.yml") == YAML.load_file("after.yml")'
true

# Scripts to check it is sortred
$ ruby -rpp -ryaml -e 'File.read("after.yml").each_line.grep(/^\w/).tap{|l| pp l.sort}' > sorted
$ ruby -rpp -ryaml -e 'File.read("after.yml").each_line.grep(/^\w/).tap{|l| pp l}' > not-sorted
$ git diff --no-index not-sorted sorted
diff --git a/not-sorted b/sorted
index 24b1204..b839962 100644
--- a/not-sorted
+++ b/sorted
@@ -14,6 +14,7 @@
  "Layout/CommentIndentation:\n",
  "Layout/DotPosition:\n",
  "Layout/ElseAlignment:\n",
+ "Layout/EmptyLineAfterMagicComment:\n",
  "Layout/EmptyLineBetweenDefs:\n",
  "Layout/EmptyLines:\n",
  "Layout/EmptyLinesAroundAccessModifier:\n",
@@ -21,19 +22,18 @@
  "Layout/EmptyLinesAroundBlockBody:\n",
  "Layout/EmptyLinesAroundClassBody:\n",
  "Layout/EmptyLinesAroundExceptionHandlingKeywords:\n",
- "Layout/EmptyLinesAroundModuleBody:\n",
  "Layout/EmptyLinesAroundMethodBody:\n",
+ "Layout/EmptyLinesAroundModuleBody:\n",
  "Layout/EndOfLine:\n",
  "Layout/ExtraSpacing:\n",
- "Layout/InitialIndentation:\n",
  "Layout/FirstParameterIndentation:\n",
- "Layout/IndentationConsistency:\n",
- "Layout/IndentationWidth:\n",
  "Layout/IndentArray:\n",
  "Layout/IndentAssignment:\n",
  "Layout/IndentHash:\n",
  "Layout/IndentHeredoc:\n",
- "Layout/SpaceInLambdaLiteral:\n",
+ "Layout/IndentationConsistency:\n",
+ "Layout/IndentationWidth:\n",
+ "Layout/InitialIndentation:\n",
  "Layout/LeadingCommentSpace:\n",
  "Layout/MultilineArrayBraceLayout:\n",
  "Layout/MultilineBlockLayout:\n",
@@ -42,28 +42,28 @@
  "Layout/MultilineMethodCallIndentation:\n",
  "Layout/MultilineMethodDefinitionBraceLayout:\n",
  "Layout/MultilineOperationIndentation:\n",
- "Layout/EmptyLineAfterMagicComment:\n",
  "Layout/RescueEnsureAlignment:\n",
- "Layout/SpaceBeforeFirstArg:\n",
  "Layout/SpaceAfterColon:\n",
  "Layout/SpaceAfterComma:\n",
  "Layout/SpaceAfterMethodName:\n",
  "Layout/SpaceAfterNot:\n",
  "Layout/SpaceAfterSemicolon:\n",
- "Layout/SpaceBeforeBlockBraces:\n",
- "Layout/SpaceBeforeComma:\n",
- "Layout/SpaceBeforeComment:\n",
- "Layout/SpaceBeforeSemicolon:\n",
- "Layout/SpaceInsideBlockBraces:\n",
  "Layout/SpaceAroundBlockParameters:\n",
  "Layout/SpaceAroundEqualsInParameterDefault:\n",
  "Layout/SpaceAroundKeyword:\n",
  "Layout/SpaceAroundOperators:\n",
+ "Layout/SpaceBeforeBlockBraces:\n",
+ "Layout/SpaceBeforeComma:\n",
+ "Layout/SpaceBeforeComment:\n",
+ "Layout/SpaceBeforeFirstArg:\n",
+ "Layout/SpaceBeforeSemicolon:\n",
+ "Layout/SpaceInLambdaLiteral:\n",
  "Layout/SpaceInsideArrayPercentLiteral:\n",
- "Layout/SpaceInsidePercentLiteralDelimiters:\n",
+ "Layout/SpaceInsideBlockBraces:\n",
  "Layout/SpaceInsideBrackets:\n",
  "Layout/SpaceInsideHashLiteralBraces:\n",
  "Layout/SpaceInsideParens:\n",
+ "Layout/SpaceInsidePercentLiteralDelimiters:\n",
  "Layout/SpaceInsideRangeLiteral:\n",
  "Layout/SpaceInsideStringInterpolation:\n",
  "Layout/Tab:\n",
@@ -118,6 +118,7 @@
  "Lint/RequireParentheses:\n",
  "Lint/RescueException:\n",
  "Lint/RescueType:\n",
+ "Lint/ReturnInVoidContext:\n",
  "Lint/SafeNavigationChain:\n",
  "Lint/ScriptPermission:\n",
  "Lint/ShadowedArgument:\n",
@@ -130,30 +131,30 @@
  "Lint/UnneededDisable:\n",
  "Lint/UnneededRequireStatement:\n",
  "Lint/UnneededSplatExpansion:\n",
+ "Lint/UnreachableCode:\n",
  "Lint/UnusedBlockArgument:\n",
  "Lint/UnusedMethodArgument:\n",
- "Lint/UnreachableCode:\n",
  "Lint/UriEscapeUnescape:\n",
  "Lint/UriRegexp:\n",
  "Lint/UselessAccessModifier:\n",
  "Lint/UselessAssignment:\n",
  "Lint/UselessComparison:\n",
  "Lint/UselessElseWithoutRescue:\n",
- "Lint/ReturnInVoidContext:\n",
  "Lint/UselessSetterCall:\n",
  "Lint/Void:\n",
  "Metrics/AbcSize:\n",
+ "Metrics/BlockLength:\n",
  "Metrics/BlockNesting:\n",
  "Metrics/ClassLength:\n",
- "Metrics/ModuleLength:\n",
  "Metrics/CyclomaticComplexity:\n",
  "Metrics/LineLength:\n",
  "Metrics/MethodLength:\n",
- "Metrics/BlockLength:\n",
+ "Metrics/ModuleLength:\n",
  "Metrics/ParameterLists:\n",
  "Metrics/PerceivedComplexity:\n",
  "Naming/AccessorMethodName:\n",
  "Naming/AsciiIdentifiers:\n",
+ "Naming/BinaryOperatorParameterName:\n",
  "Naming/ClassAndModuleCamelCase:\n",
  "Naming/ConstantName:\n",
  "Naming/FileName:\n",
@@ -161,12 +162,12 @@
  "Naming/HeredocDelimiterNaming:\n",
  "Naming/MethodName:\n",
  "Naming/PredicateName:\n",
- "Naming/BinaryOperatorParameterName:\n",
  "Naming/VariableName:\n",
  "Naming/VariableNumber:\n",
  "Performance/Caller:\n",
- "Performance/Casecmp:\n",
  "Performance/CaseWhenSplat:\n",
+ "Performance/Casecmp:\n",
+ "Performance/CompareWithBlock:\n",
  "Performance/Count:\n",
  "Performance/Detect:\n",
  "Performance/DoubleStartEndWith:\n",
@@ -184,16 +185,15 @@
  "Performance/ReverseEach:\n",
  "Performance/Sample:\n",
  "Performance/Size:\n",
- "Performance/CompareWithBlock:\n",
  "Performance/StartWith:\n",
  "Performance/StringReplacement:\n",
  "Performance/TimesMap:\n",
  "Performance/UnfreezeString:\n",
  "Performance/UriDefaultParser:\n",
  "Rails/ActionFilter:\n",
+ "Rails/ActiveSupportAliases:\n",
  "Rails/ApplicationJob:\n",
  "Rails/ApplicationRecord:\n",
- "Rails/ActiveSupportAliases:\n",
  "Rails/Blank:\n",
  "Rails/CreateTableWithTimestamps:\n",
  "Rails/Date:\n",
@@ -221,10 +221,10 @@
  "Rails/ReversibleMigration:\n",
  "Rails/SafeNavigation:\n",
  "Rails/ScopeArgs:\n",
+ "Rails/SkipsModelValidations:\n",
  "Rails/TimeZone:\n",
  "Rails/UniqBeforePluck:\n",
  "Rails/UnknownEnv:\n",
- "Rails/SkipsModelValidations:\n",
  "Rails/Validation:\n",
  "Security/Eval:\n",
  "Security/JSONLoad:\n",
@@ -235,8 +235,8 @@
  "Style/ArrayJoin:\n",
  "Style/AsciiComments:\n",
  "Style/Attr:\n",
- "Style/BeginBlock:\n",
  "Style/BarePercentLiterals:\n",
+ "Style/BeginBlock:\n",
  "Style/BlockComments:\n",
  "Style/BlockDelimiters:\n",
  "Style/BracesAroundHashParameters:\n",
@@ -259,27 +259,29 @@
  "Style/DoubleNegation:\n",
  "Style/EachForSimpleLoop:\n",
  "Style/EachWithObject:\n",
- "Style/EmptyElse:\n",
+ "Style/EmptyBlockParameter:\n",
  "Style/EmptyCaseCondition:\n",
+ "Style/EmptyElse:\n",
+ "Style/EmptyLambdaParameter:\n",
  "Style/EmptyLiteral:\n",
  "Style/EmptyMethod:\n",
- "Style/EndBlock:\n",
  "Style/Encoding:\n",
+ "Style/EndBlock:\n",
  "Style/EvenOdd:\n",
  "Style/ExtendSelf:\n",
- "Style/FrozenStringLiteralComment:\n",
  "Style/FlipFlop:\n",
  "Style/For:\n",
  "Style/FormatString:\n",
  "Style/FormatStringToken:\n",
+ "Style/FrozenStringLiteralComment:\n",
  "Style/GlobalVars:\n",
  "Style/GuardClause:\n",
  "Style/HashSyntax:\n",
+ "Style/IdenticalConditionalBranches:\n",
  "Style/IfInsideElse:\n",
  "Style/IfUnlessModifier:\n",
  "Style/IfUnlessModifierOfIfUnless:\n",
  "Style/IfWithSemicolon:\n",
- "Style/IdenticalConditionalBranches:\n",
  "Style/InfiniteLoop:\n",
  "Style/InverseMethods:\n",
  "Style/Lambda:\n",
@@ -290,10 +292,11 @@
  "Style/MethodMissing:\n",
  "Style/MinMax:\n",
  "Style/MixinGrouping:\n",
+ "Style/MixinUsage:\n",
  "Style/ModuleFunction:\n",
  "Style/MultilineBlockChain:\n",
- "Style/MultilineIfThen:\n",
  "Style/MultilineIfModifier:\n",
+ "Style/MultilineIfThen:\n",
  "Style/MultilineMemoization:\n",
  "Style/MultilineTernaryOperator:\n",
  "Style/MultipleComparison:\n",
@@ -307,8 +310,8 @@
  "Style/NilComparison:\n",
  "Style/NonNilCheck:\n",
  "Style/Not:\n",
- "Style/NumericLiterals:\n",
  "Style/NumericLiteralPrefix:\n",
+ "Style/NumericLiterals:\n",
  "Style/NumericPredicate:\n",
  "Style/OneLineConditional:\n",
  "Style/OptionalArguments:\n",
@@ -318,8 +321,6 @@
  "Style/PercentLiteralDelimiters:\n",
  "Style/PercentQLiterals:\n",
  "Style/PerlBackrefs:\n",
- "Style/EmptyBlockParameter:\n",
- "Style/EmptyLambdaParameter:\n",
  "Style/PreferredHashMethods:\n",
  "Style/Proc:\n",
  "Style/RaiseArgs:\n",
@@ -349,17 +350,16 @@
  "Style/SymbolLiteral:\n",
  "Style/SymbolProc:\n",
  "Style/TernaryParentheses:\n",
- "Style/MixinUsage:\n",
  "Style/TrailingBodyOnMethodDefinition:\n",
  "Style/TrailingCommaInArguments:\n",
  "Style/TrailingCommaInLiteral:\n",
  "Style/TrailingMethodEndStatement:\n",
+ "Style/TrailingUnderscoreVariable:\n",
  "Style/TrivialAccessors:\n",
  "Style/UnlessElse:\n",
  "Style/UnneededCapitalW:\n",
  "Style/UnneededInterpolation:\n",
  "Style/UnneededPercentQ:\n",
- "Style/TrailingUnderscoreVariable:\n",
  "Style/VariableInterpolation:\n",
  "Style/WhenThen:\n",
  "Style/WhileUntilDo:\n",

And probably we can add a test or something that checks the config files are sorted in another pull-request.

And probably we can add a test or something that checks the config files are sorted in another pull-request.

👍

👍


⚠ ClamAV has degraded performance

In 73aea87, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 79 ms

Resolved: ClamAV performance has improved in 7288c56.


Assertion fail

When I run the test, I got this response
java.lang.RuntimeException: Assertion failed for :-
[Get property by closed date and city]
|
|
+---Step --> [get_property_by_closed_date_and_city]
Failures:
Assertion path '$.body[0].id' with actual value '1' did not match the expected value '1'
Scenario .json file
{
  "scenarioName": "Get property by closed date and city",
  "steps": [
    {
      "name": "get_property_by_closed_date_and_city",
      "url": "/api/v1/property",
      "operation": "GET",
      "request": {
        "headers": {
          "Content-Type": "application/json",
          "Authorization": "Basic xxxxx"
        },
        "queryParams": {
          "closeDate": "12/19/2020",
          "city": "Sacramento"
        }
      },
      "assertions": {
        "status": 200,
        "body": [
          {
            "id": "${$.get_property_by_closed_date_and_city.response.body[0].id}",
            "import": null,
            "location": {
              "id": 2,
              "city": "",
              "county": "",
              "state": "",
              "country": ""
            },
            "originalValue": "",
            "jsonContent": "",
            "realEstateTransactionId": -1,
            "dateCreated": "2020-07-06T20:56:22.206",
            "listingId": "0",
            "propertyType": "0",
            "streetName": "0",
            "streetNumberNumeric": 0,
            "streetNumber": "",
            "unitNumber": "",
            "city": "0",
            "countyOrParish": "SA",
            "postalCode": "0",
            "stateOrProvince": "CA",
            "yearBuilt": 0,
            "closeDate": "2020-12-19",
            "closePrice": 0,
            "listPrice": 0,
            "originalListPrice": 0,
            "listingKey": "",
            "mlsAreaMajor": "",
            "mlsStatus": "S",
            "onMarketDate": "",
            "parcelNumber": "",
            "buyerAgentFullName": "",
            "buyerAgentMlsId": "",
            "listAgentFullName": "",
            "listAgentKey": "",
            "listAgentMlsId": "",
            "listOfficeKey": "",
            "listOfficeMlsId": "",
            "listOfficeName": "",
            "buyerOfficeKey": "",
            "buyerOfficeMlsId": "",
            "buyerOfficeName": "",
            "standardStatus": "S",
            "originalEntryTimestamp": "2019-10-29T10:22:59",
            "parties": "",
            "buyer1": "",
            "buyer2": "",
            "fullAddress": "",
            "modificationTimestamp": null,
            "propertySubType": null
          }
        ]
      }
    }
  ]
}

@crauadams , can you paste here your actual response?
You can get this from the console or from the log file.
Only the payload body with id field should do.

{
  "status" : 200,
  "headers" : {
    "Date" : [ "Wed, 29 Jul 2020 14:52:31 GMT" ],
    "Expires" : [ "0" ],
    "Transfer-Encoding" : [ "chunked" ],
    "Vary" : [ "Origin", "Access-Control-Request-Method", "Access-Control-Request-Headers" ],
    "X-Frame-Options" : [ "SAMEORIGIN" ],
    "Pragma" : [ "no-cache" ],
    "Set-Cookie" : [ "JSESSIONID=BC91B9F271A48E8923A5BDD0079AC205; Path=/api; HttpOnly" ],
    "Keep-Alive" : [ "timeout=60" ],
    "X-Content-Type-Options" : [ "nosniff" ],
    "X-XSS-Protection" : [ "1; mode=block" ],
    "Content-Type" : [ "application/json" ],
    "Connection" : [ "keep-alive" ],
    "Cache-Control" : [ "no-cache, no-store, max-age=0, must-revalidate" ]
  },
  "body" : [ {
    "id" : 13,
    "import" : null,
    "location" : {
      "id" : 2,
      "city" : "Sacramento",
      "county" : "SA",
      "state" : "CA",
      "country" : "United States"
    },
    "originalValue" : "",
    "jsonContent" : "",
    "realEstateTransactionId" : -1,
    "dateCreated" : "xxxx-xx-xxT20:17:12.931",
    "listingId" : "xxxxxx",
    "propertyType" : "xxxx" .... ```

Thanks for the response details.
Solution:

"id": "${$.get_property_by_closed_date_and_city.response.body[0].id}",

Update to

"id": "(int)${$.get_property_by_closed_date_and_city.response.body[0].id}",

Why ?
As your actual response is "id" : 4690, but you are asserting as "id" : "4690", , that's causing the problem. And Zerocode is saying that string "4690" in not equal to integer 4690. The error message could be enhanced, I agree.
Give it a try and let us know!

Thanks for your response, I'm still getting the same error.
'$.body[0].id' with actual value '4690' did not match the expected value '(int)4690'

Which version of Zerocode you are using?
Can you update to version 1.3.23 and try?

I was using 1.2.11, now it works! Thank you so much!

Hi @authorjapps where can I found a document with all data type that I can cast ? Because I'm with a BigDecimal value now with the same error and when the value can be null too, eg:
with actual value 'null' did not match the expected value:
$ONE.OF:[${$.get_property_by_closed_date_and_city.response.body[0].propertySubType}, $IS.NULL]
with actual value '45000.0' did not match the expected value '45000.0'

Hello @crauadams ,
If you are unsure about the data types, then better to use the below, which should cover your usecase:

"id": "$EQ.${$.get_property_by_closed_date_and_city.response.body[0].id}",

$EQ. does a number value comparison irrespective of integer, float,long, BigDecimal etc...
Which passes for:
1=1
1.5=1.5
-1=-1
left(actual)=right(expected)

where can I found a document with all data type that I can cast ?

Have you searched the Wiki index ? If this is missing we will spin up a page soon(sorry if this is the case, we will get this sorted soon).
Also here are list currently supported which might be handy for you in your future usecases until we find the doc page for you.
(int)
(long)
(float)
(boolean)

A ticket has been raised now to solve this.  ✌
https://github.com/authorjapps/zerocode/issues/420

Yes, I search on Wiki's page but I didn't found anything about check the field types, only the values.
About the $EQ. I would like to test the structure of response not they values, to make sure that a data type change doesn't broken the UI.


Repo is slow to download

It hangs at 13% - consider rebase to remove data files.
http://c2.com/wiki/closed.html?SeparationOfDataAndCode

Why has this been closed? I feel this is important.


fix: remove wrong protocol check

protocol_version is based on message, not on device.
This is the only occurrence of a check in the entire code base.
Remove and verify in the wild.

:warning: Please install the  to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 39.89%. Comparing base (45f7bd2) to head (5cf1ca3).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #320   +/-   ##
=======================================
  Coverage   39.89%   39.89%
=======================================
  Files          84       84
  Lines        7607     7607
=======================================
  Hits         3035     3035
  Misses       4572     4572

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Why change it without an issue related?

Why change it without an issue related?

This is the only device with a check and IMHO was based on a "device" logic not a message one

Why change it without an issue related?

This is the only device with a check and IMHO was based on a "device" logic not a message one

We shouldn't change it without any related issues. We might create issues and we need stability.

Anyway we need to find a proper way to handle.
I'm 99% sure that it was a mistake ; is the only device with a if on the protocol.
If we don't change the logic, we need to introduce a constant for message protocol value(s)

Or just skip that line.

Nope, we will have doubts in future


Upload operations are failing

Describe the bug
Runner running in CoA, is failing to upload with following exception:
Tes.Runner.Transfer.BlobBlockApiHttpUtils[0] Error executing request System.Net.Http.HttpRequestException: Response status code does not indicate success: 403 (This request is not authorized to perform this operation using this permission.).    at Tes.Runner.Transfer.BlobBlockApiHttpUtils.HandleHttpRequestException(Nullable1 status, HttpRequestException ex)    at Tes.Runner.Transfer.BlobBlockApiHttpUtils.ExecuteHttpRequestImplAsync(Func1 request, CancellationToken cancellationToken) <3>2023-10-05 06:47:23.761 Tes.Runner.Transfer.PartsProcessor[0] Failed to execute processorAsync System.Net.Http.HttpRequestException: Response status code does not indicate success: 403 (This request is not authorized to perform this operation using this permission.).    at Tes.Runner.Transfer.BlobBlockApiHttpUtils.HandleHttpRequestException(Nullable`1 status, HttpRequestException ex)
Expected behavior
No error.

Let's implement the ProcessExitCode for this


onLeft and leftTitle do not work using Example on tab2_2

Version
0.26 is required for v3):

react-native-router-flux v3.26.16
react-native v0.26

Expected behaviour

Expected left button to display "Left"
Expected left button press to display alert "Left button!"

File: Example.js
<Scene key="tab2" initial={true} title="Tab #2" icon={TabIcon}>
  <Scene key="tab2_1" component={TabView} title="Tab #2_1" renderRightButton={()=><Right/>} />
  <Scene key="tab2_2" component={TabView} title="Tab #2_2" onLeft={()=>alert("Left button!")} leftTitle="Left" duration={1} panHandlers={null}/>
</Scene>

Actual behaviour

The Tab #2_2 left button displayed no text, only the left arrow
Tab #2_2  scene transitioned to tab2_1 without displaying "Left button!" alert

Steps to reproduce

cd Examples, run "npm install"
Run react-native-router-flux/Example in iOS simulator, react-native run-ios
Select "Go to TabBar page"
Select "next screen for tab2_1"
Title displays "Tab #2_2" with no left button text displayed

Should be fixed with 3.26.20

3.26.21 reverts Back button over Left button priority, because it is more correct (don't show drawer but back button). In rare case you could use onBack, backTitle and new hideBackImage properties to show something custom instead of own back button


Deploy Proxy Submitter feature to TEST

new images:
fcrepo: image: oapass/fcrepo:4.7.5-3.2-2
ember: image: oapass/ember:20181108-8c1a4a3
static-html: image: oapass/static-html:20181101-c7be0f8
indexer: image: oapass/indexer:0.0.17-3.2-SNAPSHOT
deposit: image: oapass/deposit-services:0.1.0-3.2
authz: image: oapass/authz:0.4.0-3.2
notification: oapass/notification-services:0.0.2-3.2@sha256:7a693ce4005c88bdf93104d1cea1caec569dbb994ad8eaa07150dcd815a0e002 - configurations for notification service are described here: https://github.com/OA-PASS/pass-docker/tree/model-3.0#notification-services-environment
(i'm not sure if elastic search needs updated?)
Here's the migration plan as we planned in theory before https://docs.google.com/document/d/1XYkA6spS_QRUAU6ToLhlQb2u6UoWsw9Qx16aILrSDfA/edit#heading=h.g573llsxb65i

This is done.


sys.exit(1) after printing error messages?

Can I has sys.exit(1) after print 'argz plz' and print 'to many argz'?

If you submit a pull request, you probably can. I currently don't really develop/need this, so I won't do it myself, sorry.


config.json

Hey,
if in will use as example your great homebridge-hue and have homebridge-lib installed. Do I have to add something to config.json?
Do not really understand it from readme if it is needed.
When yes, is there an example?
Thank you.

No, you don't need to add anything to config.json for homebridge-lib.


Articles require <!-- more --> otherwise page will crash

Description
Following up on https://github.com/getzola/zola/issues/1298, the theme appears to use a redundant call to | markdown(inline = true), which causes a crash when page.summary is null, i.e., when <!-- more -->  is not defined. This makes summaries required, and imo, they shouldn't be! :)
Relevant area of code:
https://github.com/schoenenberg/zola-paper/blob/643041d20be22e2f32a31ac8759e0431d93f28db/templates/index.html#L17
Reproduction steps

Remove <!-- more --> from any article in content/
Attempt to compile
Observe this error:

Reason: Failed to render 'page.html' (error happened in 'index.html').
Reason: Filter call 'markdown' failed
Reason: Filter `markdown` was called on an incorrect value: got `null` but expected a String

Thanks for reporting it!

Thanks for reporting this issue! I like the fi


Change approach for loading study metadata from WADO to QIDO+WADO

This ticket addresses a metadata-loading performance issue that has come up a few times lately. @salimkanoun reported it over email with a set of PET/CT studies and @fredericcervenansky have also run into it (https://github.com/OHIF/Viewers/issues/824) when deploying against their hospital PACS.
The problem is that when we load a study right now we first make a WADO-RS call to retrieve all of the metadata for every instance related to that StudyInstanceUID. When a study has a large number of instances, this initial call can become very slow. Large studies e.g. PET/CT and DICOM Whole-slide Image studies suffer from performance issues because of this issue.
The proposed change is to switch from a single initial WADO-RS RetrieveMetadata call at the Study level to a set of calls: First, a QIDO-RS SearchForSeries call at the Study Level, and then a set of WADO-RS RetrieveMetadata calls at the Series level.
Steps:

User loads a study into the Viewer
Viewer makes QIDO-RS SearchForSeries request given the StudyInstanceUID to retrieve the list of series. If this fails, the viewer displays an error that the study was not found.
Viewer starts making WADO-RS RetrieveMetaData requests at the Series level for each of the series listed in the study.
As each series is retrieved, createDisplaySets should be run on the series (https://github.com/OHIF/Viewers/blob/8f758186c1a096a80b92596c4c796f927d1d9a8b/platform/core/src/classes/metadata/StudyMetadata.js#L115-L190). The display sets should be concatenated to the current set of display sets in the study.
Whenever a new display set is added to the list of display sets for the study, the list should be sorted by series number to ensure the proper ordering in the study.

These calls can be tested on our public DICOMWeb server: https://server.dcmjs.org/dcm4chee-arc/aets/DCM4CHEE/rs/
QIDO-RS SearchForSeries:
Docs: https://dicomcloud.azurewebsites.net/swagger/#!/QidoRS/QidoRS_SearchForSeries
GET ${qidoRoot}/studies/{StudyInstanceUID}/series
WADO-RS RetrieveMetadata at the Series Level:
Docs: https://dicomcloud.azurewebsites.net/swagger/#!/WadoRS/WadoRS_GetSeries
GET ${wadoRsRoot}/studies/{StudyInstanceUID}/series/{SeriesInstanceUID}
Notes:

This means that createDisplaySets will have to be refactored slightly to call something like createDisplaySetsForSeries() internally. The current WADO-RS-based study data ingestion currently happens here: https://github.com/OHIF/Viewers/blob/b59c8c277af38ab601c2f3baa5a0cef8841c4438/platform/viewer/src/connectedComponents/ViewerRetrieveStudyData.js#L30
The WADO-RS Metadata manager will need to be updated as series-level metadata arrives. Currently this happens here: https://github.com/OHIF/Viewers/blob/b59c8c277af38ab601c2f3baa5a0cef8841c4438/platform/viewer/src/connectedComponents/ViewerRetrieveStudyData.js#L55
All calls should use dicomweb-client

Big support for this feature.
Our CT files (512width, 512height, 16bits per pixel) consist of approximately 2.7% metadata. Most of which are repeated tags. If in fact OHIF is currently blocking the download of the first image untill all metadata can be downloaded, this fix would reduce the time to first image of a 1000 slice CT scan on a 3mb/s connection from 64 seconds down to a floor of one sixth of a second, effectively shifting the bottleneck to latency rather than broadband.
I have one question swederik. Since most of the metadata in a CT scan is duplicated anyways, have you considered a fix that would remove the need to download duplicate data? It wouldn't be very impactful, but it would feel like justice.

Thanks for the statistics @TZubiri.  Yes, I think this change will directly impact your use case.
In terms of reducing redundant metadata, one way forward is to look at storing legacy converted multiframe datasets, which have the potential for much more efficient access.

This has now been added by @emfol in #922!
@fredericcervenansky, @MathisGuilhin, @salimkanoun could you test out the latest version with some of your larger studies (i.e. with a lot of instances spread across series)?
If you are still having issues, leave a comment and I'll reopen the issue.


[BUG]

Hello I am using
agora_uikit: ^1.3.2
and all of a sudden I have this error
   : Error: The argument type 'VideoSourceType' can't be assigned to the parameter type 'RtcConnection'.
rtc_event_handlers.dart:65
- 'VideoSourceType' is from 'package:agora_rtc_engine/src/agora_base.dart' ('../../.pub-cache/hosted/pub.dev/agora_rtc_engine-6.1.1/lib/src/agora_base.dart').
agora_base.dart:1
- 'RtcConnection' is from 'package:agora_rtc_engine/src/agora_rtc_engine_ex.dart' ('../../.pub-cache/hosted/pub.dev/agora_rtc_engine-6.1.1/lib/src/agora_rtc_engine_ex.dart').
agora_rtc_engine_ex.dart:1
        ?.call(connection, width, height, elapsed);
               ^
Target kernel_snapshot failed: Exception

i have an update on this.
when I add
agora_rtc_engine: 6.1.0 to my project this error is fixed.
it does not work with version 6.1.1.

i have an update on this. when I add agora_rtc_engine: 6.1.0 to my project this error is fixed. it does not work with version 6.1.1.

but i add this still same error
Error: The argument type 'VideoSourceType' can't be assigned to the parameter type 'RtcConnection'.

'VideoSourceType' is from 'package:agora_rtc_engine/src/agora_base.dart' ('../../../../.pub-cache/hosted/pub.dev/agora_rtc_engine-6.1.1/lib/src/agora_base.dart').
'RtcConnection' is from 'package:agora_rtc_engine/src/agora_rtc_engine_ex.dart' ('../../../../.pub-cache/hosted/pub.dev/agora_rtc_engine-6.1.1/lib/src/agora_rtc_engine_ex.dart').
?.call(connection, width, height, elapsed);

i have an update on this. when I add agora_rtc_engine: 6.1.0 to my project this error is fixed. it does not work with version 6.1.1.

but i add this still same error
Error: The argument type 'VideoSourceType' can't be assigned to the parameter type 'RtcConnection'.

'VideoSourceType' is from 'package:agora_rtc_engine/src/agora_base.dart' ('../../../../.pub-cache/hosted/pub.dev/agora_rtc_engine-6.1.1/lib/src/agora_base.dart').
'RtcConnection' is from 'package:agora_rtc_engine/src/agora_rtc_engine_ex.dart' ('../../../../.pub-cache/hosted/pub.dev/agora_rtc_engine-6.1.1/lib/src/agora_rtc_engine_ex.dart').
?.call(connection, width, height, elapsed);

Ghulam Are you sure agora_rtc_engine version is set back to 6.1.0?
Because it seems not.
to make sure go over pubspec.lock and search for agora_rtc_engine
you can see its version there.


FileNotFoundError: [Errno 2] No such file or directory: '../DataSets/coco_precomp/train_ims.npy'

FileNotFoundError: [Errno 2] No such file or directory: '../DataSets/coco_precomp/train_ims.npy'   can you give me this file?thanks

Hello，has the problem been solved？


[FLINK-2591] Add configuration parameter for default number of yarn containers

Sorry for the late response, I didn't see this new pull request.
The failed test is okay. The test is known for being unstable.

For others who follow this PR, there was already some discussion on this change here: https://github.com/apache/flink/pull/1107

@willmiao: What is the status of this pull request?

@rmetzger : I'm sorry for the late reply, I have been on vacation last three weeks.
I failed to find a nice way to "generate a flink-conf.yaml just for the test", could you please give some tips on this?

That's indeed a good question. I don't have much time currently, but I'm trying to answer you within the next few days.

Hi rmetzger,
I have updated this PR.
I generated a flink-conf.yaml in a directory, which I then used as the configuration directory for the test.

Sorry for the failed tests, I'll fix them.

hi @rmetzger ,
I believe I find the reason why my test failed.
A test will fail if we don’t specify “-t” argument(which is an optional argument) in the command when call runWithArgs function, and we will get exception here:
Exception in thread "main" java.lang.NoClassDefFoundError: org/apache/log4j/Level
    at org.apache.hadoop.mapred.JobConf.<clinit>(JobConf.java:357)

It seems some jar files relevant to log callback are needed.
One more thing, I noticed a segment of code as follows in the file “FlinkYarnSessionCli.java”:
File logback = new File(confDirPath + File.pathSeparator + CONFIG_FILE_LOGBACK_NAME);
if (logback.exists()) {
shipFiles.add(logback);
    flinkYarnClient.setFlinkLoggingConfigurationPath(new Path(logback.toURI()));
}

And I wonder if “File.pathSeparator” should be “File.separator” here.


Add find all with pagination to the Notes API

Add an GET endpoint that will implement pagination using the continuation token pattern.

The business logic has been implemented with the previous PR.
Now we need tomodify

the CDK app (we must create the GSI for supporting the access pattern)
add the lambda integration for this API
In addition, we probably need to re-arrange the code in the CDK app before adding this new integration (it is a bit messy and needs to be cleaned up)


Add method to update endpoint permissions for all pipelines

So that all pipelines can be granted or denied access to
service endpoints.
Issue: #82
Example of use:
        // Create a client to interact with the Pipelines area
	pipelineClient := pipelines.NewClient(ctx, connection)
	if err != nil {
		log.Fatal(err)
	}
	resource_id := "9948edhu-b56d-4890-b0a6-0a980b1d8904"
	project := "testProject"
	authorized := true
	args := pipelines.UpdateEndpointPermissionsArgs{
		PermissionsParameters: &pipelines.PipelineResourcePermissions{
			Resource:     &pipelines.Resource{Id: &resource_id, Type: nil},
			AllPipelines: &pipelines.ResourcePermissions{Authorized: &authorized},
			Pipelines:    nil,
		},
		Project: &project,
	}
	permissionResponse, err := pipelineClient.UpdateEndpointPermissions(ctx, args)
	if err != nil {
		log.Fatal(err)
	}
	log.Printf("%v", *permissionResponse.AllPipelines.Authorized)

These are autogenerated files.  They should not be hand edited.  In order to add methods new clients will need to be generated.

Thanks for looking into it @tedchamb. I'm not sure how to autogenerate the pipelines client; I was thinking of using Autorest and https://github.com/MicrosoftDocs/vsts-rest-api-specs/tree/master/specification, but I cannot find the corresponding configuration file in the repo.

@goflores,  the clients are generated with the internal tool genclient.  Ping me and I can help you as this means we will need to create a new major version.

Added in #87


Add Delete By Name Command to AddressBook

Includes:

DeleteByNameCommand
DeleteByNameCommandParser
DeleteByNameCommandParserTest
DeleteByNameCommandTest
DeleteByNameCommandSystemTest
Necessary updates in user guide

Just adding a note for record purposes. My PR actually does pass Travis, just that there is a weird bug going on. Travis returns build success after merging this commit into the main branch.
Issue created: https://github.com/CS2103AUG2017-T10-B3/main/issues/24


Update widget docs

- Summary
Adds a complete reference for each type of built-in widget. Covers most of the outline in https://github.com/netlify/netlify-cms/issues/619#issuecomment-335689598, but still needs screenshots, and could probably use some improvements in the Custom Widgets (formerly Extending) page. Provides a temporary improvement until @hcavalieri finished the bigger improvements he's working on in #866.
Closes #157.
- Test plan
I've based the configuration samples on the widget code and existing configs where available, but I haven't had a chance to actually apply and test all of them. Adding them all to a single collection in the cms-demo config could be an option for testing them directly.
You can check rendering by visiting the updated pages:

Updated Widgets doc with new widget reference and basic validation info included
Renamed Custom Widgets doc (formerly Extending), with advanced validation section included

- Description for the changelog
Updated widget configuration docs

Deploy preview ready!
Built with commit abe9001d746b0f03a49f1bb84aaba1062360bd30
https://deploy-preview-876--netlify-cms-www.netlify.com

@verythorough Maybe add something about how you can use either object format for any of the widgets, i.e.:
  - {label: "Draft", name: "draft", widget: "boolean", default: true}

or
  - label: "Draft"
    name: "draft"
    widget: "boolean"
    default: true

Right now it kind-of looks like you can only use one type for some, and the other type for others.

Yeah, I know what you mean. I debated including it, though, because it's really a matter of yaml syntax, and applies to any place where implementers are using yaml.
What do you think about if I add a sentence to the intro about how all fields are in yaml, and can be written in block or inline form, with a link to a yaml syntax reference?
For references, Ansible has a nicely formatted doc, but could cause confusion. The description on wikipedia is nearly as clear, and probably a better reference. (The actual YAML page is not that helpful.) I can also link (here, and in other config docs) the YAML linter.

Added this new note:

Widgets are specified as collection fields in the config.yml file. Note that YAML syntax allows lists and objects to be written in block or inline style, and the code samples below include a mix of both.

What do you think about if I add a sentence to the intro about how all fields are in yaml, and can be written in block or inline form, with a link to a yaml syntax reference?

That sounds good, and I don't know if we even need a reference link, just something to the effect of "Some of the examples are in a block format, and some are in a YAML inline format, but either works the same."


[web] a11y focus ring rect frequently broken for plain text

Due to https://g-issues.chromium.org/issues/40875151 (I filed it against Chromium, but all browsers have it; it's a missing piece in the ARIA spec), I've been having difficulty finding a combination of DOM structure and ARIA attributes for plain text that would satisfy all screen readers. Currently, text is rendered into semantics like this:
<flt-semantics style="position: absolute;
                      width: 814px;
                      height: 809px;
                      top: 0px;
                      left: 0px;
                      pointer-events: all;">
  Hello, World!
</flt-semantics>

All screen readers are able to find this text and read it to the user correctly. However, some screen reader + browser combos, e.g. VoiceOver on macOS, ignore the size information specified on the element, and instead tightly hug the text that's inside the element:

The framework means the box containing the text to cover the whole screen with the "Hello, World!" text centered horizontally inside it. However, the DOM used to report semantics to screen readers is unaware of all this. All it gets is the rect of the box (0, 0, 814, 809) and the label ("Hello, World!"), and there does not seem to be a way to publish such box via anything DOM and ARIA provide.
Repro:
import 'package:flutter/material.dart';
import 'package:flutter/semantics.dart';

void main() {
  runApp(const MyApp());
  SemanticsBinding.instance.ensureSemantics();
}

class MyApp extends StatelessWidget {
  const MyApp({super.key});

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'Plain text accessibility',
      theme: ThemeData(
        primarySwatch: Colors.blue,
      ),
      home: Text('Hello, World!', textAlign: TextAlign.center),
    );
  }
}

Methods tried before

Set aria-label and no DOM text inside:

Breaks JAWS (and JAWS refuses to fix it).

role="text"

Supported by Safari <16 (and used to work perfectly), but alas, Safari 17 removed it.

Other roles: "group", "static"

Sizes the ring correctly but breaks the traversal with "end of $LABEL, grou" wording after every text element.

Adding hidden content inside the node (to avoid "empty group")

Hidden content gets collapsed as if the node never had it, so it has no effect.

Links

Various discussions of role="text" removal:

https://github.com/w3c/aria/issues/2011
https://bugs.webkit.org/show_bug.cgi?id=260641
https://github.com/w3c/aria/issues/870

JAWS:

https://github.com/flutter/flutter/issues/122607
https://github.com/FreedomScientific/standards-support/issues/759

Internal Google issues:

http://b/334798120
http://yaqs/8749427549701931008

I think I found a trick: measure the DOM text then rescale it to match the rect of the semantics node. Here's a sketch:

    Hello, World!

I tried it on macOS with all the browsers and it worked. I'll try to implement it in the engine.


Improve documentation usage part

This PR:

Fix typing error
Adds a large part of the package usage to the documentation

Codecov Report

Merging #29 (2aa0a01) into main (c915bdc) will increase coverage by 0.21%.
Report is 2 commits behind head on main.
The diff coverage is 100.00%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
@@            Coverage Diff             @@
##             main      #29      +/-   ##
==========================================
+ Coverage   98.54%   98.76%   +0.21%
==========================================
  Files          12       13       +1
  Lines         206      242      +36
==========================================
+ Hits          203      239      +36
  Misses          3        3

Files Changed
Coverage Δ

src/tensorshare/__init__.py
100.00% <ø> (ø)

src/tensorshare/utils.py
100.00% <ø> (ø)

src/tensorshare/client.py
100.00% <100.00%> (ø)

src/tensorshare/schema.py
100.00% <100.00%> (ø)

src/tensorshare/server.py
100.00% <100.00%> (ø)


The hocr output is not displayed as xhtml in Chrome

Current Behavior
Tesseract's hocr output is not displayed as xhtml in Chrome.
Firefox displays  the hocr file as expected.
Expected Behavior
No response
Suggested Fix
If I change the file extension from hocr to xhtml the file is displayed as expected in Chrome.
tesseract -v
tesseract 5.3.1
leptonica-1.83.1
libgif 5.1.9 : libjpeg 8d (libjpeg-turbo 2.1.2) : libpng 1.6.37 : libtiff 4.3.0 : zlib 1.2.11 : libwebp 1.2.2 : libopenjp2 2.4.0
Found AVX
Found SSE4.1
Found OpenMP 201511
Operating System
Ubuntu 22.04 Jammy
Other Operating System
No response
uname -a
Linux amit-desktop 5.19.0-38-generic #39~22.04.1-Ubuntu SMP PREEMPT_DYNAMIC Fri Mar 17 21:16:15 UTC 2 x86_64 x86_64 x86_64 GNU/Linux
Compiler
gcc version 11.3.0 (Ubuntu 11.3.0-1ubuntu1~22.04)
CPU
No response
Virtualization / Containers
No response
Other Information
Chrome Version: 111.0.5563.146 (Official Build) snap (64-bit)

hocr.zip

I agree to the suggestion to change the file extension from .hocr to _hocr.html.
@stweil, @zdenop, your opinion?
CC: @kba, @bertsky

So that would probably rule out *.xhtml if one wanted to conform to the spec.

The .hocr extension is a problem when working with local files. When serving hOCR from web server, setting the Content-Type to something browsers interpret as (X)HTML works but if it has to be a local file, I tend to use .hocr.html myself.
In other words, should we change the spec to recommend for file extension, in order of preference *.hocr.html, *.hocr.xhtml *.html *.xhtml *.hocr?

Personally I'd prefer .html because a duplicate extension like .hocr.html is not very common and I am not sure how libraries which can split filenames would handle this special case if they are asked to get the extension.
We have an (unrelated) problem with the extension for ALTO XML as soon as we add support for PAGE XML (see https://github.com/JKamlah/tesseract/tree/PageExport) because both formats use .xml by default.
Maybe we should keep the current defaults, but add new parameters file_extension_hocr, file_extension_alto and so on which can override the default extension including the leading dot. Then everybody is free to choose any desired extension.

I shared @stweil 's concerns about multiple dots confusing things, which is why I suggested _hocr.html, but I'd be fine with just .html (IA has both _chocr.html and _hocr.html which is not an issue if we're just generating a single file). As for adding additional naming parameters, it's pretty simple for a script / workflow to rename output files, so this is more about getting the default to be user friendly, whether those parameters exist or not.
Having said all that, I think it's a low priority issue because there is an easy workaround (renaming the file yourself).

So I suggest to keep the .hocr for now because that requires the least efforts and does not break compatiblity with existing Tesseract releases.

I am not sure how libraries which can split filenames would handle this special case if they are asked to get the extension.

>>> from pathlib import Path
>>> Path('foo.hocr.html').suffix
'.html'
>>> Path('foo.hocr.html').suffixes
['.hocr', '.html']

So, it is easy to get this wrong. Users are still free to use the .hocr.html convention if they so choose, if we recommend *.html as the preferred extension.

Maybe we should keep the current defaults, but add new parameters file_extension_hocr, file_extension_alto and so on which can override the default extension including the leading dot. Then everybody is free to choose any desired extension. With additional support for system wide and personal Tesseract configuration files this would also be easy to use.

That is a good idea to make configurable in any case.


allow adding custom attributes with sections

Allows adding Custom Attributes through the api with sections that are
not 'metadata'. 'metadata' will be the default if no section is set.
cc @alongoldboim @dkorn

@miq-bot euwe/yes

LGTM 👍

@imtayadeway @abellotti @gtanzillo PTAL

LGTM :+1:

LGTM!!

ping @abellotti @simon3z  @chessbyte can this be backported ?

@enoodle do you have a BZ?

@simon3z BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1405776

ping @abellotti @simon3z @chessbyte can this be backported, now there is a  BZ:
https://bugzilla.redhat.com/show_bug.cgi?id=1405776

@dkorn @enoodle didn't we say that the user shouldn't be allowed to touch any custom attribute at his will? There are sections that contain information that the user cannot fiddle with.
Also is the RBAC honored? (Any user can change these settings?)
This seems way too much relaxed.

@simon3z we could backport this with https://github.com/ManageIQ/manageiq/pull/13360, once merged?

@enoodle yes we'll evaluate that one

Euwe backport details:
$ git log -1
commit 6dca0a2e5fd70367d6d73db7e9099b57bc360887
Author: Alberto Bellotti<EMAIL_ADDRESS>Date:   Wed Nov 30 18:13:48 2016 -0500

    Merge pull request #12913 from enoodle/api_allow_setting_custom_attribute_section

    allow adding custom attributes with sections
    (cherry picked from commit 4eb32cd5dd776776709fbe4b23bd0b2a1c5adb57)

    https://bugzilla.redhat.com/show_bug.cgi?id=1411466


--drop without continuing migration use case

EDIT: Tried rewrite whole post with better english

grate v1.7.4
Entity Framework Core v8.0.4

I have a use case where I need to drop a database without continuing the migration. Specifically, I have a database rebuild script that first drops the database. I want to handle creating the database with Grate (setting collation, etc.) on SQL Server.
So my flow on database rebuild

Only drop and create database (I want --drop flag without further migrations applied)
Run EF Core Migrations
Run rest Grate migrations

So my ultimate goal have
RebuildDatabase.sh
containining (WITH SINGLE GRATE FOLDER) something like
grate --folders=./grate \
--connectionstring="example-database" \
--drop

dotnet ef database update

grate --folders=./grate \
--connectionstring="example-database"

Now my workaround is to create set Drop & Create database script different folder and run them from master db (I can't use --drop flag, because that would trigger migrations before Entity Framework Core migrations. And when I dont use --drop, grate  will not trigger scripts in dropDatabase folder)
So my current setup is something like this (example)
# Step 1: Drop and create the database using Grate
grate --folders=./grate/initDb \
--connectionstring="SQL-server-master-database"

# Step 2: Entity Framework migrations
dotnet ef database update

# Step 3: Rest migrations
grate --folders=./grate/migrations \
--connectionstring="example-database" \

Then my another ultimate goal is have UpdateDatabase.sh what would contain
dotnet ef database update

grate --folders=./grate \
--connectionstring="example-database"

I know it's kind of strange to have two db managment tool. But Im only using Entity Framework Core with OpenIddict related tables because EF can handle migration automatically. Otherwise I want use only grate and handle db calls manually with Dappet etc.

Hi, @Jantero93 - to try to generalise a bit, how do you run your EF migrations? It looks like the recommended way from Microsoft to run EF migrations in production is to generate SQL scripts:
https://learn.microsoft.com/en-us/ef/core/managing-schemas/migrations/applying?tabs=dotnet-core-cli
It even looks like they have some functionality similar to grate, with the Idempotent SQL scripts  (same page, further down).
Microsoft says in this same page:

The EF command-line tools can be used to apply migrations to a database. While productive for local development and
testing of migrations, this approach isn't ideal for managing production databases:
The SQL commands are applied directly by the tool, without giving the developer a chance to inspect or modify them. This can be dangerous in a production environment.
The .NET SDK and the EF tool must be installed on production servers and requires the project's source code.

I would recommend:

As part of your development or CI workflow, generate SQL scripts from EF migrations, using dotnet ef migrations script (optionally with from and to parameters
Store the scripts in the grate up folder, numbered in ascending order (maybe in a sub-folder per generated migration if there are many scripts generated), so that each migration will be applied in the correct order when you run grate

Depending on the rest of your grate scripts, where they fit in with the EF migrations, you might want to use another folder than up for the EF migrations scripts, if you always want to run these before the other migrations. But I would definitely recommend using a one-time-scripts type of folder for EF migrations, as this fits well with how EF migrations work.
You can customise the grate Folder configuration completely, if you want either a simpler or more complex folder structure than the default: https://erikbra.github.io/grate/folder-configuration/


double backslash when posting to X

Describe the bug
Eliza is posting an '\n\n' to X instead of two carriage returns.  This is using CLAUDE_VERTEX.

It appears every post has this symptom.
To Reproduce
I run on a mac, so compiled eliza with settings for mac.  Example: https://x.com/waggyhappytail/status/1869352624656716210

I run with pnpm tsx agent/src/index.ts
Expected behavior
It should post carriage returns.

Screenshots
https://imgur.com/a/BFJ2RlH

Additional context
If I exit eliza and restart, it doesn't always reproduce the issue.  The only filed edited is the character file.

@tekspirit I fix this by adding following line in
pacakages -> client-twitter -> src -> post.js
in "generateNewTweet()" function
after
cleanedContent = removeQuotes(content);
cleanedContent = cleanedContent.replace(/\n/g, '\n');`

Fixed here https://github.com/ai16z/eliza/pull/1141
You should use .replaceAll


[Bug]: Configuration error on macOS when using non-Apple compiler

What Operating System(s) are you seeing this problem on?
macOS (Intel)
dlib version
19.24
Python version
3.11.5
Compiler
LLVM  clang++ 15.0.7
Expected Behavior
Configuration of the build using CMake, on macOS, with a compiler other than Apple’s version of clang, should work.
Current Behavior
The configured build fails with the error:
<full path of the rankin used>: error: Invalid option: '-no_warning_for_no_symbols’

Steps to Reproduce
Following the CMake build instructions with the addition of specifying the clang++ to use is other than Apple’s clang:
cmake -DCMAKE_CXX_COMPILER=$(which clang++) -DCMAKE_C_COMPILER=$(which clang) ..

In my case, $(which clang++) yields:
/Users/paterno/mambaforge/envs/for-fc-cpu/bin/clang

which is the compiler used to build all the other C++ libraries in my Conda environment.
Anything else?
The problem seems to be fixed by modifying dlib/dlib/CMakeLists.txt. The diff is:
❯  git diff
diff --git a/dlib/CMakeLists.txt b/dlib/CMakeLists.txt
index 8fc43ec5..83230606 100644
--- a/dlib/CMakeLists.txt
+++ b/dlib/CMakeLists.txt
@@ -136,10 +136,12 @@ endmacro()

 # Suppress superfluous randlib warnings about libdlib.a having no symbols on MacOSX.
-if (APPLE)
+if (CMAKE_C_COMPILER_ID STREQUAL "AppleClang")
    set(CMAKE_C_ARCHIVE_CREATE   "<CMAKE_AR> Scr <TARGET> <LINK_FLAGS> <OBJECTS>")
-   set(CMAKE_CXX_ARCHIVE_CREATE "<CMAKE_AR> Scr <TARGET> <LINK_FLAGS> <OBJECTS>")
    set(CMAKE_C_ARCHIVE_FINISH   "<CMAKE_RANLIB> -no_warning_for_no_symbols -c <TARGET>")
+endif()
+if (CMAKE_CXX_COMPILER_ID STREQUAL "AppleClang")
+   set(CMAKE_CXX_ARCHIVE_CREATE "<CMAKE_AR> Scr <TARGET> <LINK_FLAGS> <OBJECTS>")
    set(CMAKE_CXX_ARCHIVE_FINISH "<CMAKE_RANLIB> -no_warning_for_no_symbols -c <TARGET>")
 endif()

If it is helpful, I would be happy to supply a pull request.

Yeah, totally send me a pull request with this :)


an unknown error using .NET SDK Azure Datalake Gen1 Client

[Enter feedback here]
According to the document,  I create a application to wire data to the file. In the most time, the application is ok. But sometime it will get an unknown error :
CONCURRENTAPPEND failed with Unknown Error: The underlying connection was closed: A connection that was expected to be kept alive was closed by the server.
My code
 ServiceClientCredentials cred = ApplicationTokenProvider.LoginSilentAsync(tenantId, clientId, clientSecret).GetAwaiter().GetResult();
             AdlsClient client = AdlsClient.CreateClient(domain, cred);

            string path = "/input/test.txt";
            string[] lines = System.IO.File.ReadAllLines(@"E:\mytext.txt");
            foreach (var line in lines) {

                var textBytes = Encoding.UTF8.GetBytes(line);
                client.ConcurrentAppend(path, true, textBytes, 0, textBytes.Length);
            }

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 70e7e183-024f-9c05-c8b4-540b243dc1ea
Version Independent ID: d3c45856-5fc7-ee0a-9d17-6d42d378f8d8
Content: .NET SDK: Filesystem operations on Azure Data Lake Storage Gen1
Content Source: articles/data-lake-store/data-lake-store-data-operations-net-sdk.md
Service: data-lake-store
GitHub Login: @twooley
Microsoft Alias: twooley

@test123114 Thanks for bringing this to our notice. We are investigating into the issue and will update you shortly.

One of the problems could be due to the use of "Create" and "ConcurrentAppend" on the same file stream. ADLS documentation mentions that they can't be used on the same file. If you are using them concurrently, maybe, try changing the "Create" command to "ConcurrentAppend" as the latter can be used to create a file if it doesn't exist.

@ChiragMishra-MSFT  What do you mean? How can I update your code?

@test123114 I meant, incase you are executing a Create and a ConcurrentAppend at the same time on the same file, please remove the create operation and work with a ConcurrentAppend operation only.
ConcurrentAppend operation can be used to create a file if it doesn't exist, hence you can safely use it instead of using a Create operation separately.

Hi. I do not use Create  method.

I suspect that you see the error when you try to execute ConcurrentAppend multiple times on the same file.
In that case, can you please try out executing just one instance of ConcurrentAppend and seeing if you still see the error?

@test123114 Since you are using ConcurrentAppend in a for loop, it's trying to run it multiple times. Since it's a synchronous function, you are seeing the error.
Replacing the function with ConcurrentAppendAsync  should get rid of this problem.

Ok. I will try it.

@test123114 Did you get a chance to try it out ?

@test123114 I will now proceed to close this issue. However, please feel free to comment and tag me if you have any questions.


Add deck.net support for Assert.

This would be useful for reporting bugs to be able to provide unit tests on deck.net.

Hi @michaelcheers – Thanks for the feature request. Could you re-post this issue in the Deck.NET Issues repo. It will be better to track within the Deck repo.
https://github.com/deckdotnet/Deck.NET/issues

@geoffreymcgill, created as deckdotnet/Deck.NET#21


The training of the copy_augmented Transformer model is very slow!

I have tried to train the model with copy option on 4GPU (12GB each) but the training was very slow. I have tried tuning some hyperparameters ending up with almost the same issue. Am I missing something:  here are my settings:
python train.py --track 1 --train-mode pretrain --model copy --ngpu 4
        model_config = f"--ddp-backend=no_c10d --arch copy_augmented_transformer " \
            f"--update-freq 4 --alpha-warmup 10000 --optimizer adam --lr {lr} " \
            f"--dropout {dropout} --max-tokens 3000 --min-lr '1e-09' --save-interval-updates 5000 " \
            f"--lr-scheduler inverse_sqrt --weight-decay 0.0001 --max-epoch {max_epoch} " \
            f"--warmup-updates 4000 --warmup-init-lr '1e-07' --adam-betas '(0.9, 0.98)' "

Hi @Al-Sabahi,
Thanks for trying out our model! We'll need more information to determine what the issue might be. The pretraining step iterates over a lot of synthetically generated data and is supposed to take a while. On our system, pre-training for 5 epochs took a day or so using 8 P40 GPUs.
How slow (e.g., how much time does it take per epoch/steps) is the training? What kind of GPUs are you using? Is the speed significantly different from the speed when training with the --model base option instead? It'd be also helpful if you provide the log and/or the training curve from running the command on your system.

Hi @yjchoe Thank you so much for the remarkable work and for the nice reply. I am suspecting that the problem is in my side. Because I am in the middle of something else, I will double check later. I am closing this issue and if I find something, I will reopen it. Thanks again.


Blank project codes get mapped to unfound projects

When there are entries without a project code, and you have a project code configured in ~/.md.yml that doesn't exist, md matches them up and creates matching entries in the secondary minutedock account.
It shouldn't do this.

---
ApiKey: "x"

AccountID: 1869
MappedAccountID: 16411

ProjectMaps:
  ae_merchant_self_service_portal: "ae_eftplus_and_merchant_portal"
  other_team_meetings: "team_meetings"
---

In my case I got double entries for each entry not matching the given project name.


⚠ AZ-Launcher has degraded performance

In b004071, AZ-Launcher (https://az-launcher.nz/) experienced degraded performance:

HTTP code: 200
Response time: 1481 ms

Resolved: AZ-Launcher performance has improved in 72d5445 after 17 minutes.


chore: make storage wrappers internal

Description
This is a follow-up of https://github.com/openfga/openfga/pull/1155

I noticed that if someone uses OpenFGA as a library, they are not getting the benefits neither of the in-memory model cache, nor the benefits of using the context wrapper to avoid dropping database connections if there is a context error. So, in this PR i instantiate those wrappers inside Server.new.
I also make all the storage wrappers internal because they should not be used by outside consumers.
I fixed a goroutine leak in case the call to server.New fails because of validation failures.

It also feels like w'ere doing a bit too many unrelated changes within this PR. Would you perhaps consider breaking these down in multiple PRs that are focused on a single problem? 🙏🏻

I see your point, but the changes are all related. The changes in server.New can bring a (small) goroutine leak if not done in the right order, which is why I added the validation test.
And if I don't make the storage wrappers private, this could happen
datastore = storagewrappers.NewCachedOpenFGADatastore(storagewrappers.NewContextWrapper(datastore), config.AuthorizationModelCacheSize)

openfgaSvr := openfga.MustNew(...)
// inside this, we are ALSO doing
// s.datastore = storagewrappers.NewCachedOpenFGADatastore(
//		storagewrappers.NewContextWrapper(s.datastore),
//		s.maxAuthorizationModelCacheSize)

Alright, I'll split this PR into two parts, one making everything that we want internal, and then the other one 👍


Karpenter should hold an unneeded node for almost the billing period

Description
What problem are you trying to solve?
I want to optimize the nodes I have already spent money on by keeping them around for as long as possible.  As an example, if Karpenter creates a new node at 12:00 and the node is deemed to be empty at 12:23, then I want Karpenter to keep the node around until a configurable amount (default 5m maybe) before the the 60m billing period ends before deleting it.  This is because if the node is needed again, then it can immediately be used.  However, if the node was deleted at 12:24 and then another pod @ 12:30 requires Karpenter to create another node, then I will have actually spent double the amount over just holding onto a node that's already been paid for.
How important is this feature to you?
It was save a lot in environments where there are short lived jobs and disruption enabled.

Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
If you are interested in working on this issue or have submitted a pull request, please leave a comment

Karpenter is explicitly designed around a price-per-instance-type optimization algorithm https://github.com/aws/karpenter-core/blob/main/pkg/cloudprovider/types.go#L128, and I don't see a technical path to extending this to arbitrary complexity.
EC2 charges per second, so I assume you're talking about the costs incurred from a 3p software vendor. We've occasionally heard from customers about 3p vendors billing in slower increments (hourly as you suggest), or even more complex models (e.g. per node, per vcpu). These business models are challenging to optimize around, and realistically, Karpenter cannot hope to capture optimization decisions for all business models for all 3p integrations.
Ideally, the charges would be either:

Small enough that the orthogonal pricing isn't significant enough to change capacity optimization decisions.
Directly proportional to VM price, such price optimizations are directly aligned with what Karpenter optimizes for

Related: https://github.com/kubernetes-sigs/karpenter/issues/693


Upgrade Android embedding to v2

this PR solves #23

upgrade gradle to 7.0.2
Upgradle Android Flutter plugin to v2.
Fixed some warnings in AndroidStudio
Reformat Code by using AndroidStudio

This PR works on Android 8.
I'm new to Flutter Plugin development and Android development, so there may be some oddities.
so, If the PR is not good enough, I don't mind if you close it.
References.
https://flutter.dev/docs/development/packages-and-plugins/plugin-api-migration
https://flutter.dev/docs/development/packages-and-plugins/developing-packages#plugin

I tested that this PR works on Android 8.

Hi @ttyniwa I tried ur code but got an error "lambda expressions are not supported in -source 7 vscode"
I think using lambda not working for me when building the app.

@andrey-ushakov can we merge this to master?

can this PR be merged?


[grid] refocus moves focus to viewport when a cell in the last column or row is focused

Resolved by #8010.


Aospless mesa build failed

See https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/25410
build.tar.gz
Btw I'm using latest Arch Linux

Thanks. I use clang-15 and have no such issue.
From meson-log.txt:
Command line: `/home/tarsin/Downloads/aospless/toolchain_wrapper/wrap_c /home/tarsin/Downloads/aospless/build/meson-private/tmptipbcfzv/testfile.c -o /home/tarsin/Downloads/aospless/build/meson-private/tmptipbcfzv/output.obj -c '[C_ARGS]' -D_FILE_OFFSET_BITS=64 -O0 -Werror=implicit-function-declaration -Werror=unknown-warning-option -Werror=unused-command-line-argument -Werror=ignored-optimization-argument -std=c11` -> 1
stderr:
clang: error: the flag '-enable-trivial-auto-var-init-zero-knowing-it-will-be-removed-from-clang' has been deprecated and will be ignored [-Werror,-Wunused-command-line-argument]
-----------
Checking whether type "struct stat" has member "st_birthtimespec.tv_nsec" : NO
Running compile:
Working directory:  /home/tarsin/Downloads/aospless/build/meson-private/tmp6uvaz390
Code:
 #include <sys/stat.h>
        void bar(void) {
            struct stat foo;
            foo.st_mtimespec.tv_nsec;

        }
-----------

Looks like -enable-trivial-auto-var-init-zero-knowing-it-will-be-removed-from-clang is causing this issues.
Please remove this flag from all files in ./toolchain_wrapper/ directory.

Thanks, IMapper4 API works,
No more disjoint planes

I noticed a [[DNM] Fix aospless build](https://github.com/asuka-mio/mesa/commit/45928618457f3e80f7f832e91e82d2f9b3798e52) commit in your chain. Is it still required?

I noticed a [DNM] Fix aospless build commit in your chain. Is it still required?

Yup, libxml missing readline header

Okay. It probably can be fixed by installing system libxml-dev or something like that.

Okay. It probably can be fixed by installing system libxml-dev or something like that.

Hi, i am getting file not found error even through i have /usr/include/readline/readline.h on my archlinux setup.
I use same build.tar.gz linked above as workdir.
How should i fix it ?

Hi,
Try this: https://stackoverflow.com/questions/23085076/readline-readline-h-file-not-found

Hi,
Try this: https://stackoverflow.com/questions/23085076/readline-readline-h-file-not-found

I have installed libxml several times to be sure, but never thought i can install readline.
Sadly running make cleanup && make install still reproduces same issue.

I have tried appending -I/usr/include/readline to the files of toolchain_wrapper directory.
I think it is a weird idea, yet it does not change anything.


Mention about how to add an new advance throttling policy at the throttling use cases.

Description:
For a new user who is not familiar with APIM, at [1] it is bit confusing to figure out from where they can add mentioned throttle policy as the explanation is not straight forward. better to add a link [2] at these places.
[1] - https://apim.docs.wso2.com/en/latest/learn/rate-limiting/introducing-throttling-use-cases/#advanced-throttling-policies-api-publisher
[2] - https://apim.docs.wso2.com/en/latest/learn/rate-limiting/adding-new-throttling-policies/#adding-a-new-advanced-throttling-policy
Affected Product Version:
4.0.0-alpha, 3.2.0, 3.1.0 and previous versions as well.

Also this image incorrect in [1]. It has put 30 requests per minute and as per the description, 30K (30000) is used.
[1] -  https://apim.docs.wso2.com/en/next/design/rate-limiting/adding-new-throttling-policies/


Misc cleanup

Can't run it yet, so these are just various small fixes I poked at that should be safe.

Nice catches!  I know there is more cleanup that can be done based on the warning output from Monodevelop/Xamarin.  Good to see changes for this kind of stuff.

Awesome! Thanks for the fixes and cleanup


add eslint and fixes

cc @ivarconr

Coverage decreased (-0.1%) to 95.181% when pulling c018f0ce5d41187b2b0cd40664c47b5944ae026c on lint-and-fix into 14d0c0e534d2d7aa0dfb9adf492731ac84d66889 on master.

Coverage decreased (-0.1%) to 95.181% when pulling 1ab0fc9cef9707d9b98e63e12b390539e87ffe47 on lint-and-fix into 14d0c0e534d2d7aa0dfb9adf492731ac84d66889 on master.

Coverage decreased (-19.4%) to 75.862% when pulling 842699059ad56e5ce7d6ed3c91b0ac6dc5f211cc on lint-and-fix into 14d0c0e534d2d7aa0dfb9adf492731ac84d66889 on master.


#Fix UNIX install prefixes according to CMake recommendation

This is a small convenience change to CMake installation on Linux. It does not change the current/default behavior, but allows some freedom for changing installation destinations from CACHE variables ("the outside").
From https://cmake.org/cmake/help/latest/command/install.html#targets:

To make packages compliant with distribution filesystem layout policies, if projects must specify a DESTINATION, it is recommended that they use a path that begins with the appropriate GNUInstallDirs variable. This allows package maintainers to control the install destination by setting the appropriate cache variables.

This allows altering of the 'bin' subdirectory by overwriting CMAKE_INSTALL_BINDIR from the outside.
Tested on CentOS with cmake version 3.20.5
Feel free to squash the second commit.

This looks good to me, thank you very much!
I'm currently on vacation without access to most of my machines, so I'm gonna hold off with merging until I can test it on at least one other distro (not foreseeing any problems, just want to make sure).
Cheers!


[FEATURE] emote support for YouTube

Will chat-downloader support youtube emote download?
It'll be nice to see it stored in ChatDownloader instance and available when exported.
Thank you!
e.g.
x = ChatDownloader(...)

# Do some download stuff

x.emotes # {":hii:": "https://.../hii.png", ":hey:": "https.."}

if it's good enough to have the emotes saved into a local folder, then it's possible to do this with softchat... but unfortunately it requires some setup (sorry!)
the readme has steps to enable more additional features, but the things you definitely need are:

install fontforge and, if you are on linux, the python bindings for it
install imagemagick
create a folder named noto-hinted and download NotoSansCJKjp-Regular.otf into it

then, either use ytdl-tui to download the vid+chat+emotes automatically, or:
python3 -m pip install --user softchat chat-downloader
python3 -m chat_downloader -o the.json -c cookies.txt youtu.be/3UV8OZj2olg
python3 -m softchat --emote_font --emote_cache emotes the.json

...and see #85 regarding cookies.txt if you're opting for the manual approach :>

Will chat-downloader support youtube emote download?
It'll be nice to see it stored in ChatDownloader instance and available when exported.
Thank you!
e.g.
x = ChatDownloader(...)

# Do some download stuff

x.emotes # {":hii:": "https://.../hii.png", ":hey:": "https.."}

Emote information is included in the messages, so what you could do is add to your "list of emotes" after a message comes in that contains the emotes key. Something like this, for example:
import json
from chat_downloader import ChatDownloader

emote_dictionary = {}

url = 'https://www.youtube.com/watch?v=0GRsPTEG7Sk'
chat = ChatDownloader().get_chat(url, start_time=400, end_time=500)

for message in chat:
    for emote in message.get('emotes') or []:
        if emote['id'] not in emote_dictionary:
            emote_dictionary[emote['id']] = emote
            print('Added emote:', emote['name'])

print('All emote information:')
print(json.dumps(emote_dictionary, indent=4))

Let me know if you have any other questions 😃


Is it safe to use SECRET_KEY as the salt?

Looks like it's possible to discover the salt by looking at hashids: http://carnage.github.io/2015/08/cryptanalysis-of-hashids
This blog post is linked at hashids.org website: http://hashids.org/#decoding
Therefore, maybe this lib shouldn't use SECRET_KEY by default as the salt.
IMO there should be a custom Django setting for the global hashid salt.

Thanks, I should have looked into that before I published. I have added a global setting and pushed a new version out. This of course will change all existing Hashids if just dropped in place, and no salt was specified on each field, so I upped it to version 1.0.0 since it's a breaking API change when used in its default state. Very regrettable, but hopefully it won't affect a lot of people. I have no idea how many are using this module since PyPI doesn't have counters anymore (not that they worked before with mirrors inflating them.) But at least you caught it somewhat early, as the module has only existed for a couple months. Thanks!

Thank you! This project is great. Thanks for the fix.


Update JDBC Framework to run under a single connection

Description
[Describe what this change achieves - Guidelines below (please delete the guidelines after writing the PR description)]

What is the change? This is best described in terms of “Currently, Babelfish does X. With this change it now does Y.” Think of “What did it used to do?” and “What does it do now?”

Why was the change made? What drove our desire to put effort into the change?
How was the code changed should only appear for large commits. This can serve as a rough roadmap to what’s contained in the commit. It should be very high level; if it’s directly referencing code it’s probably too detailed. It’s also critical that this section of a commit message does not try to replace proper code documentation (ie, block comments or README files). Generally, this section should only appear if the commit itself is large enough that it’s helpful to provide a roadmap to someone looking at the commit.
The last descriptive piece is the “title” for the commit: the very first line of the commit message, which should typically be less than 80 characters. A good title is critical, because it’s the only thing that shows up in places like the Github commit listing. No one’s got time to read through full commit messages when trying to find a single commit out of dozens.

Issues Resolved
[List any issues this PR will resolve]
Test Scenarios Covered

Use case based -

Boundary conditions -

Arbitrary inputs -

Negative test cases -

Minor version upgrade tests -

Major version upgrade tests -

Performance tests -

Tooling impact -

Client tests -

Check List

[ ] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is under the terms of the Apache 2.0 and PostgreSQL licenses, and grant any person obtaining a copy of the contribution permission to relicense all or a portion of my contribution to the PostgreSQL License solely to contribute all or a portion of my contribution to the PostgreSQL open source project.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>9
Details

0 of 0   changed or added relevant lines in 0 files are covered.
20466 unchanged lines in 92 files lost coverage.
Overall coverage decreased (-33.4%) to 41.291%

Files with Coverage Reduction
New Missed Lines
%

contrib/babelfishpg_tds/src/backend/utils/adt/numeric.c
1
78.06%

contrib/babelfishpg_tsql/src/collationproperty.c
1
92.86%

contrib/babelfishpg_tsql/src/plan_inval.c
2
91.3%

contrib/babelfishpg_tds/src/backend/tds/err_handler.c
2
75.86%

contrib/babelfishpg_common/src/encoding/mb/conversion_procs/utf8_and_uhc/utf8_and_uhc.c
2
0.0%

contrib/babelfishpg_tsql/src/tsqlIface.hpp
3
84.21%

contrib/babelfishpg_tds/src/backend/tds/tdsprotocol.c
3
83.39%

contrib/babelfishpg_tds/src/backend/tds/tdstimestamp.c
3
93.49%

contrib/babelfishpg_common/src/encoding/mb/conversion_procs/utf8_and_sjis/utf8_and_sjis.c
4
0.0%

contrib/babelfishpg_common/src/encoding/mb/conversion_procs/utf8_and_gbk/utf8_and_gbk.c
4
0.0%

Totals

Change from base Build<PHONE_NUMBER>2:
-33.4%

Covered Lines:
25286

Relevant Lines:
61239

💛  - Coveralls


Resume / Pause event is not fired on Android

Hi,
Recently I moved from CordovaWebView to cordova-plugin-ionic-webview.
It turns out that the resume pause event is not fired on android. There is no problem with iOS.

code

    this.platform.resume.subscribe(async _ => {
      console.log('resume');
    });
    this.platform.pause.subscribe(() => {
     console.log('pause');
    });

env

Ionic:

   ionic (Ionic CLI)  : 4.2.1 (/usr/local/lib/node_modules/ionic)
   Ionic Framework    : ionic-angular 3.9.6
   @ionic/app-scripts : 3.2.2

Cordova:

   cordova (Cordova CLI) : 8.1.2<EMAIL_ADDRESS>   Cordova Platforms     : android 7.1.4
   Cordova Plugins       : cordova-plugin-ionic-webview 4.1.1, (and 13 other plugins)

System:

   Android SDK Tools : 26.1.1 (/Users/macbook/Library/Android/sdk)
   ios-deploy        : 1.9.4
   NodeJS            : v10.15.1 (/usr/local/bin/node)
   npm               : 6.4.1
   OS                : macOS High Sierra
   Xcode             : Xcode 10.1 Build version 10B61

Sorry.
This bug in our app was the cause.
cordova-plugin-ionic-webview is not a problem at all.

thanks for letting us know.


RDS: Generate random password and store in referenced secret

Description of your changes
Addresses these use cases:

DBCluster API has master password as optional
a. masterUserPasswordSecretRef is now optional, controller ignores not found errors and returns empty string for password
DBCluster does not autogenerate a password
a. Added autogeneratePassword which, if masterUserPasswordSecretRef is set, will create a random password and store it in the specified location.

Fixes #667
I have:

[x] Read and followed Crossplane's contribution process.
[x] Run make reviewable test to ensure this PR is ready for review.

How has this code been tested
Generated new CRDs and applied to a cluster that was not running provider-aws. Ran provider-aws locally and verified that:

masterUserPasswordSecretRef being optional is respected and will create a DBCluster if not provided.
If masterUserPasswordSecretRef is set, it will create a DBCluster with the specified password
If autogeneratePassword and masterUserPasswordSecretRef is set, and no input password is located, it will generate a random password and store at the location specified in masterUserPasswordSecretRef
If autogeneratePassword and masterUserPasswordSecretRef is set, and an input password is located, it will be used instead of a random password

@muvaf I'm willing to do similar work on the RDSInstance controller if this is an acceptable pattern, granted RDSInstance doesn't use hooks so it'll be ever so slightly different

Dropped the RDSInstance changes. As per the discussion in Slack the path forward is to not make any changes to the RDSInstance resource contract regarding password management, and to have that work be done on a future resource DBInstance instead.

@PocketMobsters Thanks for your contribution. looking forward to see it is merged.

@PocketMobsters Happy new year any chance to get the Open Points resolved ?

@PocketMobsters any chance to see this finalized ?

Implemented with #1413  @PocketMobsters thanks for working on this - some Folks implemented your Branch with up2date master


Unique operation names requirement and near-operation-file preset

The generator throws if it encounters duplicated operation names (requested in #720, implemented in #913).
This is perfectly correct if all generated code goes to a single file. However, with  near-operation-file preset, duplicated names aren't a problem any longer (unless the duplication would be in the same file). It seems like the validation should be on output level rather than on global level.
I'm still relatively new to GraphQL world so I'm not sure what are the best practices, maybe it's the best to have unique names anyway, but with my current understanding the requirement of unique names across relatively large application seems to be limiting.

You are right, I'll take a look today :)

Fixed in: https://github.com/dotansimha/graphql-code-generator/pull/2269 , you can try it with the latest alpha 1.4.1-alpha-45ce6b30.65.

Fixed in 1.5.0 🎉


don't receive anymore notifications after updating to the 0.6.10 version

Reported by @zottel:matrix.zottel.net
https://github.com/matrix-org/riot-android-rageshakes/issues/259

P2 because i don't reproduce it

The GCM/FCM events were received but the caught up events did trigger notifications.

Happened on three devices on the same wifi network, did not happen on at least two other devices that use the same HS.

There is one case i could think :
At application launch, the client performs a request to retrieve the notification rules.
If they are retrieved, the client does not trigger notifications.
An application cache forces the bing rules retrieval.

i have added more logs to track why the events could have been unnotified.
-> log the number of notification rules
-> tells if a message is a message is not notified because of a rule or if it is too old.

fixed in https://github.com/matrix-org/matrix-android-sdk/commit/d9d0e83e08a00d2f93e2e4b6ff94344bf72580b3


[FEATURE REQUEST] Move "admins" from usecase to parameters file

Which area is mainly impacted
Configuration
Requested Feature
Currently the admins section is defined in the usecase configuration. This should be modified.
The usecase configuration should be rather independent from the actual user calling the use case. Therefore, it makes more sense to have the admins section inside the parameters.json file.

Would you like to support us?

[X] Yes, I would like to support you

Anything else?
I've already started do develop the change and will send a pull request soon.

But please add your comments on this idea.

What is the main reason to move admins into parameter file?
At this moment I'm satisfied how admin user management is done.
As we discussed internally, this was proposed vision for the use case but we had not time to implement this:
"requiredrolecollections": [
{
"name": "BPM Administrator",
"roles": [
{"name": "BPMADmin", "roletemplate": "RuleRepositorySuperUser"},
{"name": "BPMADmin2", "roletemplate": "RuleRepositorySuperUser"}
],
"assignedUserGroups": ["adminsForApp","superheros"]
}
],
"userGroups": [
{"name": "adminsSubaccount","type": "subaccount", "members"<EMAIL_ADDRESS><EMAIL_ADDRESS>{"name": "adminsForApp","type": "custom", "members"<EMAIL_ADDRESS><EMAIL_ADDRESS>{"name": "superheros","type": "custom", "members": ["tony<EMAIL_ADDRESS>]

I've given this some additional thoughts. I think we should move ahead with the initial plan you've sketched above. Do you want to give it a first try in the code? I'm not sure whether I'll have time to code this myself in the next couple of weeks.

Yes, i like this approach but i dont have capacity at the moment, maybe, let's come to this one in couple of weeks.

Hi,
It makes sense to keep subaccount resources (services, environments) separate from subaccount parameters (subaccount name, admins).
I have a use case where the subaccount has a number suffix, and the admin email also has the same number suffix. Currently I have to modify the two files (through a script). With this change, I would only have to deal with the parameters, while the usecase can remain constant.
Kr,
Pedro

This issue has now been fixed with this pull request: https://github.com/SAP-samples/btp-setup-automator/pull/109


bug: for the cached pages provide a way to reinvoke controller

Type: bug
Platform: all
Hello.
Some of the nice features don't work without using cached pages. However when you transition b\w cached pages - controller of the page is not initiated.
Is it possible for you guys provide a solution so that when you transition to the cached page - there is an event or something that can be triggered to update the data? Otherwise swipe buck functionality is useless for 99% of the use cases.

Greetings @reviyou!
My sensors indicate that you need to update your issue through our custom issue form. We are now requiring all issues to be submitted this way, to ensure that we have all of the information necessary to fix them as quickly as possible.
Click Here To Update Your Issue
I will have no choice but to close this issue if it is not resubmitted through the form. Please fill out the rest of the form, so that I may use my friendly robot powers to assist you.
Thank you!

I'm not sure if it's exactly what you are looking for but why aren't you using the ionic-view lifecycle-events: http://ionicframework.com/docs/api/directive/ionView/
For example if you want to update the data-scope whenever you load a fresh or cached view you could simply add the following to you controller:
// update scope whenever the view is shown
$scope.$on('$ionicView.afterEnter', function() {
    DataService.loadData().then(function(data) {
      $scope.data = data;
    });
});

Thanks... Elvis? :)
it actually sounds like a very good idea that can help to enable caching across the application and still reload data. Enabling caching would benefit UX and helps us to add swipe back functionality back again
Let me try that but that's for the hint, i thought afterEnter would not work with swiping b\w cached pages for some reason!

Just gave it a try. Looks like it's still not stable and not working for most of the people. I had exactly the same issue as those guys http://forum.ionicframework.com/t/ionicview-in-scope-on-not-launching/15847/2
doesn't launch any of those events for the scope. Does for rootScope but in an unpredictable way....

Caching views, being what they are, would not reinit. You can turn off caching, or listen for the $ionicView events. It sounds like the events aren't firing consistently for you though. Could you provide a codepen or something we can look at and inspect to help figure out why they're not firing?

is there anywhere a codepen with a working events on the cached pages? Would be easier to look at working implementation, I don't have anything unusual, caching enabled  for all application and listeners on page A. When I swipe back from page B listeners are not invoked even though transition works fine. 2 pages 2 controllers, that's all. I think having a code pen for this feature provided by ionic would benefit the users, otherwise we don't know if it's even works

I'll provide an example later today

if you want to reload controller when you come back into him , you need to clear cache immediately afterwards leaving it:
$scope.$on("$ionicView.afterLeave", function () {
$ionicHistory.clearCache();
});

To summarize:
1.If you want to enable swipe to go back you need ALL you pages, where you can go back, not just some pages.
2.basically on those those pages you might want to update the data. You have 2 options:
2.a  do it from the child scope when you are still on the child page
2b expect to be able to go back and enter beforeEnter or afterLeave event where you can update you data for the current page
Looks like for now only the 2a option works properly but it is not very clean and convenient  in terms of coding coding.
2a option has some issues and doesn't work consistently for some of the users (see link above and my original comment)
@PedroJusto
Idea of cleaning the whole cache when you return to the parent page just smells. It's kind of against the purpose of having cache in the first place. Besides if you do it and remove the cache you swipe to go back functionality will suffer. That's part of the reason swipe to go back doesn't work with not cached pages currently - UX is ugly

Hello! Are you all still experiencing this issue?

Hello! Thanks for opening an issue with us! Since it has been a little while since there was any activity on this issue i will be closing it, but feel free to respond back if your still having the issue! Thanks again!