#NEXT-265-Add events when Billing Address/ Shipping Address is set as default

1. Why is this change necessary?
These events were missing by default in shopware 6. When there have to be restrictions on address for a particular sales channel, the Account service doesn't provide these necessary events and hence leads to Custom Address Controller inheritance.
2. What does this change do, exactly?
Add events when an address is set as default shipping or as default billing address

I want this :O

I want this :O

Will this be triggered via admin as well?

Will this be triggered via admin as well?

@JoshuaBehrens nope

@JoshuaBehrens nope

@JoshuaBehrens
I guess for the admin, you can just use the entity written events? :thinking:

@JoshuaBehrens
I guess for the admin, you can just use the entity written events? :thinking:

@mitelg I could do that in any situation. You are right. Why do we need this event - looking at it like this - anyway? Why should we add more complexity by not using this event in the admin? The admin regarding orders are told me to act the same as the storefront (as they use the storefront). Why not here?

@mitelg I could do that in any situation. You are right. Why do we need this event - looking at it like this - anyway? Why should we add more complexity by not using this event in the admin? The admin regarding orders are told me to act the same as the storefront (as they use the storefront). Why not here?

@JoshuaBehrens CUSTOMER_ADDRESS_WRITTEN_EVENT -> i guess this event is meant to be used whenever a new address is added and not when an address is marked as default. Also i don't think these both events are same.

@JoshuaBehrens CUSTOMER_ADDRESS_WRITTEN_EVENT -> i guess this event is meant to be used whenever a new address is added and not when an address is marked as default. Also i don't think these both events are same.

With written event you can cover both sides. With this event only frontend. Do we want it then 🤔

With written event you can cover both sides. With this event only frontend. Do we want it then 🤔

Like i said, These 2 events are totally different from each other i guess. The written event is set also when an address  entry is added to the database. I just want this event fired when customer is setting an address as default address.
My use case is , when a customer is setting an address as default billing address, for some sales channel, it should be also set as default shipping address.  I  am not sure when is this Written event exactly fired. and if it could be used to check if the address   set as default could be identified from this even data. I couldn't find it in the code.
Am i missing something here?

Like i said, These 2 events are totally different from each other i guess. The written event is set also when an address  entry is added to the database. I just want this event fired when customer is setting an address as default address.
My use case is , when a customer is setting an address as default billing address, for some sales channel, it should be also set as default shipping address.  I  am not sure when is this Written event exactly fired. and if it could be used to check if the address   set as default could be identified from this even data. I couldn't find it in the code.
Am i missing something here?

I took the hint from @mitelg to listen to the customer.written event and check whether the defaultId value changed.

I took the hint from @mitelg to listen to the customer.written event and check whether the defaultId value changed.

yes, its possible that way. But isn't it too much of a overhead when we have to listen to the customer written event which is dispatched for every possible changes done to the customer object itself? On the other hand, this event when implemented just does what the name says, dispatched only when an address is set as default. To me, it lowers the complication of the other event.

yes, its possible that way. But isn't it too much of a overhead when we have to listen to the customer written event which is dispatched for every possible changes done to the customer object itself? On the other hand, this event when implemented just does what the name says, dispatched only when an address is set as default. To me, it lowers the complication of the other event.

I see qualities in that event but it feels misguiding when it is not happening when updated via administration as well.

I see qualities in that event but it feels misguiding when it is not happening when updated via administration as well.

also, if we now start with adding an event, for changing one certain field of one certain entity: where should we end? :wink:

also, if we now start with adding an event, for changing one certain field of one certain entity: where should we end? :wink:

Just do those automatically and spam the event dispatcher :shipit:

Just do those automatically and spam the event dispatcher :shipit:

Firstly, the intention was not to spam the event dispatcher. This is a common feature which is required by various shops to restrict customers from having different shipping and billing address. This event is basically meant to be triggered especially for this case.

What about the customer import? Is the customer.written event triggered on each customer import? If yes, do you think its a good idea to check for this particular key (default billing address id) in the entire payload for every entity?

It would have been nice if you could have told me this before when I actually discussed with you @mitelg  about these events before creating this ticket. That could have saved a lot of effort and time from my side.

Firstly, the intention was not to spam the event dispatcher. This is a common feature which is required by various shops to restrict customers from having different shipping and billing address. This event is basically meant to be triggered especially for this case.

What about the customer import? Is the customer.written event triggered on each customer import? If yes, do you think its a good idea to check for this particular key (default billing address id) in the entire payload for every entity?

It would have been nice if you could have told me this before when I actually discussed with you @mitelg  about these events before creating this ticket. That could have saved a lot of effort and time from my side.

hey @sr-SW6-workshop
the "spamming the dispatcher" was a joke comment by @JoshuaBehrens if we would implement an event for each field change of each entity. please do not take that to serious :slightly_smiling_face:
Adding new events is normally no problem, and we highly appreciate PRs like that, because we could not think of all scenarios developer need, when we are developing features for Shopware. So I was okay with this issue and of course with your PR. :+1:
But sometimes a discussion arises during the review process and upcoming objections should not be left unconsidered.
As already mentioned before, your newly introduced events will only cover the store-api, which means, when the customer itself changes its default addresses. If this is sufficient for your use case, this is okay.
But we as maintainer need to take a holistic look at this, and your events will not cover changes made by the admin API or other changes with the customer repository. So you will miss changes made to the customer, which could also affect the default addresses.
Again, if this is really sufficient enough for you, we could certainly consider your PR. In my opinion, the naming of the event classes makes it clear, that these events are only dispatched, if the customers themselves change their addresses. So, I'm good to go with it. What do you think @shyim ?
I'm very sorry, if you felt upset about our discussion. But we just wanted to make sure, that you understand the consequences and that this will not cover all use cases :slightly_smiling_face: But if I got that right, this it totally your intention, so you will got my approve on this :heavy_check_mark:

hey @sr-SW6-workshop
the "spamming the dispatcher" was a joke comment by @JoshuaBehrens if we would implement an event for each field change of each entity. please do not take that to serious :slightly_smiling_face:
Adding new events is normally no problem, and we highly appreciate PRs like that, because we could not think of all scenarios developer need, when we are developing features for Shopware. So I was okay with this issue and of course with your PR. :+1:
But sometimes a discussion arises during the review process and upcoming objections should not be left unconsidered.
As already mentioned before, your newly introduced events will only cover the store-api, which means, when the customer itself changes its default addresses. If this is sufficient for your use case, this is okay.
But we as maintainer need to take a holistic look at this, and your events will not cover changes made by the admin API or other changes with the customer repository. So you will miss changes made to the customer, which could also affect the default addresses.
Again, if this is really sufficient enough for you, we could certainly consider your PR. In my opinion, the naming of the event classes makes it clear, that these events are only dispatched, if the customers themselves change their addresses. So, I'm good to go with it. What do you think @shyim ?
I'm very sorry, if you felt upset about our discussion. But we just wanted to make sure, that you understand the consequences and that this will not cover all use cases :slightly_smiling_face: But if I got that right, this it totally your intention, so you will got my approve on this :heavy_check_mark:

@mitelg  Thanks for the reply. No offense taken for sure!
I am of course open to discussions. It really helps all of us to improve in general. I am happy that you really can see the purpose of these events and can consider our use case scenario.
How long do I have to do the review changes?

@mitelg  Thanks for the reply. No offense taken for sure!
I am of course open to discussions. It really helps all of us to improve in general. I am happy that you really can see the purpose of these events and can consider our use case scenario.
How long do I have to do the review changes?

@shyim @pantrtxp when do you plan to import the boost day changes?

@shyim @pantrtxp when do you plan to import the boost day changes?

Hey @sr-SW6-workshop
Since we need to start with our internal work to bring the BoostDay contributions into the product we ask you to complete this PR till next Monday (25.01) if you are still interested in solving this.
Otherwise we have to close this PR coming Monday.
I hope you understand this.
Sunny regards
Shopware

Hey @sr-SW6-workshop
Since we need to start with our internal work to bring the BoostDay contributions into the product we ask you to complete this PR till next Monday (25.01) if you are still interested in solving this.
Otherwise we have to close this PR coming Monday.
I hope you understand this.
Sunny regards
Shopware

Thanks @sr-SW6-workshop
would you mind doing the following things?

[ ] Squash commits into only one commit
[ ] execute code style fixer

Thanks @sr-SW6-workshop
would you mind doing the following things?

[ ] Squash commits into only one commit
[ ] execute code style fixer

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.3 out of 6 committers have signed the CLA.:white_check_mark: sr-SW6-workshop:white_check_mark: shyim:white_check_mark: pantrtxp:x: schuering:x: philipgatzka:x: taltholtmannYou have signed the CLA already but the status is still pending? Let us recheck it.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.3 out of 6 committers have signed the CLA.:white_check_mark: sr-SW6-workshop:white_check_mark: shyim:white_check_mark: pantrtxp:x: schuering:x: philipgatzka:x: taltholtmannYou have signed the CLA already but the status is still pending? Let us recheck it.

hey @sr-SW6-workshop,
Please use "NEXT-13424" (without the #) as your issue key instead of "#NEXT-265" and changes "fixes #270" to "fixes shopwareBoostday/platform#265" in your commit.
If you did this your PR matches our requirements :)

hey @sr-SW6-workshop,
Please use "NEXT-13424" (without the #) as your issue key instead of "#NEXT-265" and changes "fixes #270" to "fixes shopwareBoostday/platform#265" in your commit.
If you did this your PR matches our requirements :)

thanks for your contribution @sr-SW6-workshop   👍🎉💙

thanks for your contribution @sr-SW6-workshop   👍🎉💙


Move vuln scan action from agent repo.

In order to be more proactive on vulnerabilities in the serverless extension, run a vulnerability scan nightly on the agent main branch.
We will be able to subscribe in slack to this workflow which I will do once we're done testing it.

Also note, this doesn't scan serverless-init or bottlecap. We can always add those later.


Plots modify wizard

Now that we have the plots wizard to create new plots, it would be great to also be able to choose an existing plot and modify it using the wizard. In other words:

When viewing a plot, have an option to modify it.
When you choose to modify it, we open the plots wizard but preselect the existing options for it.

I don't think this is easily doable since it's hard to alter yaml file lines without possibly breaking things. The solution would most likely be flaky 🤔

In DVC CLI, we already have lots of tooling to try to modify yaml in-place, so this could depend on CLI support first (see https://github.com/iterative/dvc/issues/7753).


Fixes issues with accessing disposed intercepted request message

What kind of change does this PR introduce?
This fixes the bug with accessing intercepted HTTPRequestMessage objects when the application has disposed of them.
What is the current behavior?
Some HTTPClient libraries, such as Refit (https://github.com/reactiveui/refit) dispose of the HTTPRequestMessage object after use. If one of the libraries is used, or the application itself disposes of the HTTPRequestMessage, then the HTTPRequestMessage stored in the OutgoingRequests collection, has some properties that are inaccesible (such as Content).
What is the new behavior?
The HTTPRequestMessage is cloned during interception, before it is stored in the OutgoingRequests collection. The application will then dispose of the original object, and the tests can read from the cloned object.
What might this PR break?
Nothing. Maybe more memory usage.
Other Information
And example and test has been added for the Refit REST Library to confirm compatibility.

awesome ! I will have a cloer look over the weekend, but highly appreciate the effort !


[BUG][FLINK-23944] PulsarSourceITCase.testTaskManagerFailure is unstable.

I think this issue is caused by #16. Since #16 has been resolved, I'll temporarily close this issue.


Debug Layer: Bogus warning for unmapping CPU accessible textures

I don't know if there's an actual issue tracker for the D3D12 debug layer, so I'm posting this here for now.
Unmapping a CPU accessible texture with a pWrittenRange of NULL warns:
D3D12 WARNING: ID3D12Resource::ID3D12Resource::Unmap: pWrittenRange is NULL and the heap page property is WRITE_BACK. This can be an indicator of inefficiencies that will result on mobile systems, as the range should be as tight as possible. But, it is also possible the range must encompass the whole subresource.A NULL pWrittenRange parameter indicates all resource memory was written to.  [ EXECUTION WARNING #931: UNMAP_INVALID_NULLRANGE]
Setting the pWrittenRange to (0, width * height * bpp) gives:
D3D12 ERROR: ID3D12Resource::ID3D12Resource::Unmap: pWrittenRange must be NULL or specify an empty range when Unmap is invoked for a resource with an opaque layout. The resource layout is D3D12_TEXTURE_LAYOUT_UNKNOWN, which is opaque. pWrittenRange is not NULL. [ EXECUTION ERROR #829: UNMAP_INVALIDRANGE]
Setting the pWrittenRange to (0,0) doesn't give any errors and appears to work anyways, but I'm not sure if that's undefined behaviour or not. As implied by the first message, this only happens on iGPUs (with WRITE_BACK CPU heaps)
I think this is a bug in the debug layer. The first warning shouldn't happen for CPU accessible textures, since they must always be unmapped with a NULL pWrittenRange.

The best place to report issues with D3D12 and the debug layer is http://forums.directxtech.com.

Done. Here's the thread: http://forums.directxtech.com/index.php?topic=5784.0
Thanks!


[google_maps_flutter_web] Missing longPress support on Mobile Web

We trying to use the longPress event provided by the google maps flutter plugin.
The maps the setup roughly looks like this:
@override
  Widget build(BuildContext context) {
    return Scaffold(
      body:GoogleMap(
          mapType: MapType.hybrid,
          onLongPress: (latLn) {
                  widget.onPinDropped(latLng);
          }
          onMapCreated: (GoogleMapController controller) {
            _controller.complete(controller);
          },
        ),
      floatingActionButton: FloatingActionButton.extended(
        onPressed: _goToTheLake,
        label: const Text('To the lake!'),
        icon: const Icon(Icons.directions_boat),
      ),
    );
  }

While the longPress works fine on Mobile app, with the standard long press, the same event on Desktop Web fires with a mouse right click as well.
But on Mobile Web, we dont get any events fired on for this.
Is there a way we get this event working on Mobile web.

flutter doctor -v

[✓] Flutter (Channel stable, 2.5.3, on macOS 11.6 20G165 darwin-x64, locale en-US)
    • Flutter version 2.5.3 at /Users/ahetawal/sdk/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 18116933e7 (9 weeks ago), 2021-10-15 10:46:35 -0700
    • Engine revision d3ea636dc5
    • Dart version 2.14.4

[✓] Android toolchain - develop for Android devices (Android SDK version 31.0.0)
    • Android SDK at /Users/ahetawal/Library/Android/sdk
    • Platform android-31, build-tools 31.0.0
    • Java binary at: /Applications/Android Studio.app/Contents/jre/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.10+0-b96-7281165)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 12.5.1, Build version 12E507
    • CocoaPods version 1.11.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2020.3)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.10+0-b96-7281165)

[✓] IntelliJ IDEA Ultimate Edition (version 2021.2.1)
    • IntelliJ at /Users/ahetawal/Applications/JetBrains Toolbox/IntelliJ IDEA Ultimate.app
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart

[✓] IntelliJ IDEA Ultimate Edition (version 2021.2.1)
    • IntelliJ at /Users/ahetawal/Library/Application Support/JetBrains/Toolbox/apps/IDEA-U/ch-0/212.5080.55/IntelliJ IDEA.app
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart

[✓] VS Code (version 1.59.0)
    • VS Code at /Users/ahetawal/Downloads/Visual Studio Code.app/Contents
    • Flutter extension version 3.27.0

[✓] Connected device (2 available)
    • iPhone 11 (mobile) • 15249398-F752-49BD-9F8C-E7DD89D48344 • ios            • com.apple.CoreSimulator.SimRuntime.iOS-14-5 (simulator)
    • Chrome (web)       • chrome                               • web-javascript • Google Chrome 96.0.4664.93

@ahetawal-p
There's similar open issue describing your case, https://github.com/flutter/flutter/issues/80322
Please follow-up in it for further updates.
Closing this as a duplicate.

Hi @darshankawar,
How is this a duplicate, this issue is specifically for longPress event not working. How does this relate to pan and zoom gestures. ?

@ahetawal-p
Since longPress event falls under gesture handling, I referred to that issue, but yes, it only talks about zoom and pan. I'll come back to this issue.

@ahetawal-p
Can you provide a complete code sample to address this ?
Thanks.

Here is a basic sample
import 'dart:async';

import 'package:flutter/material.dart';
import 'package:google_maps_flutter/google_maps_flutter.dart';

class MapSample extends StatefulWidget {
  @override
  State<MapSample> createState() => MapSampleState();
}

class MapSampleState extends State<MapSample> {
  Completer<GoogleMapController> _controller = Completer();

  static const CameraPosition _kGooglePlex =  CameraPosition(
    target: LatLng(37.42796133580664, -122.085749655962),
    zoom: 14.4746,
  );

  static const CameraPosition _kLake =  CameraPosition(
      bearing:<PHONE_NUMBER>395799,
      target: LatLng(37.43296265331129, -122.08832357078792),
      tilt: 59.440717697143555,
      zoom: 19.151926040649414);

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      body:GoogleMap(
          mapType: MapType.hybrid,
          initialCameraPosition: _kGooglePlex,
          onLongPress: (latLn) {
                  print("I am pressed $latLn");
          },
          onMapCreated: (GoogleMapController controller) {
            _controller.complete(controller);
          },
        ),
      floatingActionButton: FloatingActionButton.extended(
        onPressed: _goToTheLake,
        label: const Text('To the lake!'),
        icon: const Icon(Icons.directions_boat),
      ),
    );
  }

  Future<void> _goToTheLake() async {
    final GoogleMapController controller = await _controller.future;
    controller.animateCamera(CameraUpdate.newCameraPosition(_kLake));
  }
}

void main() {
  runApp(MaterialApp(home: MapSample()));
}

If you longPress on Mobile web browser nothing happens, but on Desktop web(with mouse right click) and mobile app you can see the print statement in the console for longPress.

Thanks. Verified this behavior on latest master and stable and running the sample on mobile web and trying to long press on the map doesn't perform any action, unlike on mobile and desktop web (using mouse).
mobile and desktop web:

flutter: I am pressed LatLng(37.42870523138699, -122.08492621779442)
flutter: I am pressed LatLng(37.431337561290356, -122.08861157298088)

mobile web:
No action:

 stable, master flutter doctor -v
[[✓] Flutter (Channel stable, 2.8.1, on Mac OS X 10.15.4 19E2269 darwin-x64,
    locale en-GB)
    • Flutter version 2.8.1 at /Users/dhs/documents/fluttersdk/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 77d935af4d (13 hours ago), 2021-12-16 08:37:33 -0800
    • Engine revision 890a5fca2e
    • Dart version 2.15.1

[✓] Android toolchain - develop for Android devices (Android SDK version 30)
    • Android SDK at /Users/dhs/Library/Android/sdk
    • Platform android-30, build-tools 30.0.3
    • ANDROID_HOME = /Users/dhs/Library/Android/sdk
    • Java binary at: /Users/dhs/Library/Application Support/JetBrains/Toolbox/apps/AndroidStudio/ch-0/202.7486908/Android
      Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6915495)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 12.3, Build version 12C33
    • CocoaPods version 1.10.1

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 4.1)
    • Android Studio at /Users/dhs/Library/Application Support/JetBrains/Toolbox/apps/AndroidStudio/ch-0/202.7486908/Android
      Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build
      1.8.0_242-release-1644-b3-6915495)

[✓] VS Code (version 1.57.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.21.0

[✓] Connected device (4 available)
    • Darshan's iphone (mobile)  • 21150b119064aecc249dfcfe05e259197461ce23 •
      ios            • iOS 14.4.1 18D61
    • iPhone 12 Pro Max (mobile) • A5473606-0213-4FD8-BA16-553433949729     •
      ios            • com.apple.CoreSimulator.SimRuntime.iOS-14-3 (simulator)
    • macOS (desktop)            • macos                                    •
      darwin-x64     • Mac OS X 10.15.4 19E2269 darwin-x64
    • Chrome (web)               • chrome                                   •
      web-javascript • Google Chrome 93.0.4577.82

• No issues found!

[✓] Flutter (Channel master, 2.9.0-1.0.pre.156, on Mac OS X 10.15.4 19E2269
    darwin-x64, locale en-GB)
    • Flutter version 2.9.0-1.0.pre.156 at
      /Users/dhs/documents/fluttersdk/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 27ad488747 (87 minutes ago), 2021-12-21 22:39:19 -0500
    • Engine revision 4eabb883af
    • Dart version 2.16.0 (build 2.16.0-126.0.dev)
    • DevTools version 2.9.2

[✓] Android toolchain - develop for Android devices (Android SDK version 30)
    • Android SDK at /Users/dhs/Library/Android/sdk
    • Platform android-30, build-tools 30.0.3
    • ANDROID_HOME = /Users/dhs/Library/Android/sdk
    • Java binary at: /Users/dhs/Library/Application Support/JetBrains/Toolbox/apps/AndroidStudio/ch-0/202.7486908/Android
      Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6915495)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 12.5.1, Build version 12E507
    • CocoaPods version 1.10.1

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 4.1)
    • Android Studio at /Users/dhs/Library/Application Support/JetBrains/Toolbox/apps/AndroidStudio/ch-0/202.7486908/Android
      Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build
      1.8.0_242-release-1644-b3-6915495)

[✓] VS Code (version 1.57.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.21.0

[[✓] Connected device (4 available)
    • Darshan's iphone (mobile)  • 21150b119064aecc249dfcfe05e259197461ce23 •
      ios            • iOS 14.4.1 18D61
    • iPhone 12 Pro Max (mobile) • A5473606-0213-4FD8-BA16-553433949729     •
      ios            • com.apple.CoreSimulator.SimRuntime.iOS-14-3 (simulator)
    • macOS (desktop)            • macos                                    •
      darwin-x64     • Mac OS X 10.15.4 19E2269 darwin-x64
    • Chrome (web)               • chrome                                   •
      web-javascript • Google Chrome 93.0.4577.82

• No issues found!

For me it seems that there is a mix up between long-press and "right-click" in desktop web. If I short click on right mouse button, it behaves like short-click on left button, when listening to longClick events... (AFAICS)

I have the same problem.
From a web browser the right click works but once installed as a Webapp on the mobile the longPress doesn't react.


Fix requests counts on error events.

When errors happen requests are not being counted which throws off
success failure ratios, along with rps.

Thanks!


Added Python-2.0 to the most popular licenses

Pull Request Check List
This is just a reminder about the most common mistakes. Please make sure that you tick all appropriate boxes.  But please read our contribution guide at least once, it will save you unnecessary review cycles!

[x] Added tests for changed code.
[x] Updated documentation for changed code.

Note: If your Pull Request introduces a new feature or changes the current behavior, it should be based
on the develop branch. If it's a bug fix or only a documentation update, it should be based on the master branch.
If you have any questions to any of the points above, just submit and ask!  This checklist is here to help you, not to deter you from contributing!

running black against the code should address formatting concerns

running black against the code should address formatting concerns

I just checked with black, and it does not help with line 78th... ;(


Allocation of Resource Without limiting in register page.

https://github.com/BenCinn/Node-Server/blob/5c5c9d1c8fd2fb9663700268aef9ab5442aa3f2c/server.js#L67-L69
This can be exploited to perform Denial of Service attack.
From: https://github.com/BenCinn/Node-Server/security/code-scanning/11

Fixed in 72ca0f24ca0ffcdf3e9909fc9fd7815aaf53516a!!


artisan route:list no longer works without a database connection

Since 7233adaf20dde806db8cc4691a46a6312d2010c5 artisan route:list requires a database connection if any controller's constructor requires a database connection for any reason (e.g. dependency injection of PasswordBroker in the default PasswordController).
In many applications, especially those which introduce multi-tenancy, having a default database set either does not make sense or is not desirable.
Is it possible for there to be either an option to disable controller instantiation on route:list, or a graceful failure with a list of controllers that were unable to be instantiated?

This is an issue for a project I am working on with multi-tenancy. We have the default DB connection config value to null and set it in a service provider.
As @jmakenney suggested a soft fail/warning would be nice.

This is not a bug, but the expected result. On a default laravel application, this is caused by loading dependencies for middleware I assume.


Work on contamination model

A few different changes:

Using the built in ADAM support to count kmers in the reference
Sliding over the read to generate k-mers to search for
This should now also support multiple contigs in a fasta file
Started adding tests, but got stuck with the things above so I never real got around to writing them.

At the moment it's all untested, but I'm to tired to go on. Bugs will be abundant... :p

If you want to have a look @chris-zen you're welcome. Would be interesting to hear your opinion on this.

You're right I missed the sliding.
See my comment above about the multi-contig stuff.
Awesome that you opened an issue. Following it now, and hopefully they'll pick up on it.

Thanks. Looking forward to more of your contributions. :smile: Thank you so much for the feedback on the code!
I'll go ahead and merge this even if it's not complete and the tests are failing... Will make the next PR cleaner, and we're all quite aware that this is not fully operational yet.


Feature(Service): add created, mounted and destroyed hooks + fix unde…

Add hooks : created, mounted and destroyed => Now we known when the component is mounted or ...
+
Fix undefined methods during a this$1.$options.methods ect...

Hey, all of this is not necessary, check https://vuedose.tips/tips/listen-to-lifecycle-hooks-on-third-party-vue-js-components


Matter-Window-Covering: Resolve shade status issue

This PR addresses CHAD-13384, to resolve an issue where the window covering operational status is not updated from "Opening" or "Closing" to "Partially Open" after the shade level is adjusted in the ST app.
Additionally, an additional check is added in current_status_handler to resolve an issue seen with the Eve Motion Blinds where rb.info_block.data was nil but the code attempted to read rb.info_block.data.value. Note that the Eve device in question is faulty so this is likely not a common situation but this is still a good check to include.

Can you add a unit test that would catch this issue?

Can you add a unit test that would catch this issue?

I added 2 test cases in the latest commit: the first adjusts the shade level by > 2%, which passes on both the main branch and with these changes. The second adjusts the shade level by 2%, which on the main branch does not update the capability to Partially Open.

A similar fix to this issue was made by this PR. I think that that solution is more complete, as it includes an update to current_status_handler that I believe is needed. I think that I will revert my driver changes, but I think it would still a good idea to keep the test cases updates made in this PR, or possibly include them in PR 1447.


[v1.7]: operator: rate limit GC of security identities

To prevent bursts of security identities from being deleted in the
KVStore, possibly causing Cilium agent to have a high CPU usage due
policy calculation, this commit adds a rate limiter for such KVStore
deletes. For example, in case there are 1000 identities to GCed, the
operator will delete 250 every minute until all 1000 identities are
GCed.
$ for pr in 12451; do contrib/backporting/set-labels.py $pr done 1.7; done

test-backport-1.7


editor

Is there an editor?

I hope you can use the editor to create models, import models, upload pictures/videos/files and other content.
One click publishing, like hubs, can be released quickly.

Right now there's the Third Room Unity Exporter which we're using internally for the Terra and UK City scenes:
https://github.com/matrix-org/thirdroom-unity-exporter
It's really great especially if you're familiar with Unity or you have existing Unity content that you want to port to Third Room. However, we'll be working on the integrated editor again next year.
Closing as a duplicate of #62


[Bug]: The terraform-provider-snowflake_v0.86.0 plugin crashed!

Terraform CLI Version
1.4.6
Terraform Provider Version
0.86.0
Terraform Configuration
terraform {
  required_providers {
    snowflake = {
      source  = "Snowflake-Labs/snowflake"
      version = "<=0.86.0"
    }
  }
  required_version = ">= 1.1.3, <=1.4.6"
}

resource "snowflake_tag" "tag" {
  name     = var.name
  database = var.database
  schema   = var.schema
}

resource "snowflake_tag_masking_policy_association" "masking_policy_tag_association" {
  for_each          = toset(var.masking_policies)
  tag_id            = snowflake_tag.tag.id
  masking_policy_id = each.key
}

Category
category:resource
Object type(s)
resource:tag_masking_policy_association
Expected Behavior
Associating masking policies with a tag
Actual Behavior
I am getting the below error
Error: Plugin did not respond
│
│ The plugin encountered an error, and failed to respond to the
│ plugin6.(*GRPCProvider).ApplyResourceChange call. The plugin logs may
│ contain more details.
╵
Stack trace from the terraform-provider-snowflake_v0.86.0 plugin:
panic: interface conversion: sdk.ObjectIdentifier is sdk.AccountObjectIdentifier, not sdk.SchemaObjectIdentifier
Error: The terraform-provider-snowflake_v0.86.0 plugin crashed!
Steps to Reproduce
resource "snowflake_tag" "tag" {
name     = var.name
database = var.database
schema   = var.schema
}
resource "snowflake_tag_masking_policy_association" "masking_policy_tag_association" {
for_each          = toset(var.masking_policies)
tag_id            = snowflake_tag.tag.id
masking_policy_id = each.key
}
How much impact is this issue causing?
Low
Logs
No response
Additional Information
No response
Would you like to implement a fix?

[ ] Yeah, I'll take it 😎

Hi @rajasinghr 👋
Could you provide the definition of var.masking_policies and the whole stack trace output? I think the issue is that snowflake_tag_masking_policy_association expects a fully qualified name in tag_id and masking_policy_id, but only scoped names are provided.
In v0.95.0, we have introduced fully_qualified_name to each resource which should help in referencing these objects. We recommend updating the provider to this version.
Note that tags and masking policies are on our roadmap, and will be reworked soon.

Hi @sfc-gh-jmichalak ,
Thanks for helping on this.
What do you mean by fully qualified name?
We are passing masking_policies as list from an yaml file and create resources using the below module.
module "tag" {
  for_each = var.tags
  source   = "../../modules/tag"

  name             = each.key
  database         = lookup(each.value, "database", "<default_db>")
  schema           = lookup(each.value, "schema", "<default_schema>")
  masking_policies = lookup(each.value, "masking_policies", [])
}

tag.yaml
tags:
  - name: MASKED
    properties:
      masking_policies: ["<policy 1>", "<policy 2>"]
  - name: PENDING_REVIEW
    properties:
      masking_policies: ["<policy 1>", "<policy 2>"]

Here is the full stack trace
Stack trace from the terraform-provider-snowflake_v0.86.0 plugin:

panic: interface conversion: sdk.ObjectIdentifier is sdk.AccountObjectIdentifier, not sdk.SchemaObjectIdentifier

goroutine 74 [running]:
github.com/Snowflake-Labs/terraform-provider-snowflake/pkg/resources.CreateTagMaskingPolicyAssociation(0x0?, {0x205bd40?, 0xc000d0be10?})
	github.com/Snowflake-Labs/terraform-provider-snowflake/pkg/resources/tag_masking_policy_association.go:118 +0x598
github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema.(*Resource).create(0x242a2c8?, {0x242a2c8?, 0xc000e00f60?}, 0xd?, {0x205bd40?, 0xc000d0be10?})
	github.com/hashicorp/terraform-plugin-sdk/v2@v2.31.0/helper/schema/resource.go:766 +0x163
github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema.(*Resource).Apply(0xc000899180, {0x242a2c8, 0xc000e00f60}, 0xc000b7c680, 0xc000990180, {0x205bd40, 0xc000d0be10})
	github.com/hashicorp/terraform-plugin-sdk/v2@v2.31.0/helper/schema/resource.go:909 +0xa89
github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema.(*GRPCProviderServer).ApplyResourceChange(0xc000b0aa50, {0x242a2c8?, 0xc000e00db0?}, 0xc000bc8aa0)
	github.com/hashicorp/terraform-plugin-sdk/v2@v2.31.0/helper/schema/grpc_provider.go:1074 +0xdbc
github.com/hashicorp/terraform-plugin-mux/tf5to6server.v5tov6Server.ApplyResourceChange({{0x2440020?, 0xc000b0aa50?}}, {0x242a2c8, 0xc000e00db0}, 0x0?)
	github.com/hashicorp/terraform-plugin-mux@v0.13.0/tf5to6server/tf5to6server.go:37 +0x54
github.com/hashicorp/terraform-plugin-mux/tf6muxserver.(*muxServer).ApplyResourceChange(0x242a300?, {0x242a2c8?, 0xc000e00ab0?}, 0xc000bc8a50)
	github.com/hashicorp/terraform-plugin-mux@v0.13.0/tf6muxserver/mux_server_ApplyResourceChange.go:36 +0x193
github.com/hashicorp/terraform-plugin-go/tfprotov6/tf6server.(*server).ApplyResourceChange(0xc000b16960, {0x242a2c8?, 0xc000e000c0?}, 0xc0006776c0)
	github.com/hashicorp/terraform-plugin-go@v0.20.0/tfprotov6/tf6server/server.go:857 +0x56b
github.com/hashicorp/terraform-plugin-go/tfprotov6/internal/tfplugin6._Provider_ApplyResourceChange_Handler({0x20091c0?, 0xc000b16960}, {0x242a2c8, 0xc000e000c0}, 0xc00088f900, 0x0)
	github.com/hashicorp/terraform-plugin-go@v0.20.0/tfprotov6/internal/tfplugin6/tfplugin6_grpc.pb.go:503 +0x169
google.golang.org/grpc.(*Server).processUnaryRPC(0xc0000d8d20, {0x242a2c8, 0xc000e00030}, {0x243b300, 0xc000a0e000}, 0xc000c16c60, 0xc000930ba0, 0x3424d78, 0x0)
	google.golang.org/grpc@v1.60.0/server.go:1372 +0xe03
google.golang.org/grpc.(*Server).handleStream(0xc0000d8d20, {0x243b300, 0xc000a0e000}, 0xc000c16c60)
	google.golang.org/grpc@v1.60.0/server.go:1783 +0xfec
google.golang.org/grpc.(*Server).serveStreams.func2.1()
	google.golang.org/grpc@v1.60.0/server.go:1016 +0x59
created by google.golang.org/grpc.(*Server).serveStreams.func2 in goroutine 10
	google.golang.org/grpc@v1.60.0/server.go:1027 +0x115

Error: The terraform-provider-snowflake_v0.86.0 plugin crashed!

This is always indicative of a bug within the plugin. It would be immensely
helpful if you could report the crash with the plugin's maintainers so that it
can be fixed. The output above should help diagnose the issue.

time=2024-09-17T23:06:06Z level=error msg=terraform invocation failed in /home/atlantis/.atlantis/repos/Rippling/terraform-snowflake/406/default/multi-region/dev/us1/resources/tag/.terragrunt-cache/Ulx83QFGCg23kzsO7mQKLofSLDM/kHYvUfT4SdbyrRHGWEVNpDPp-qE/application-modules/tag error=[/home/atlantis/.atlantis/repos/Rippling/terraform-snowflake/406/default/multi-region/dev/us1/resources/tag/.terragrunt-cache/Ulx83QFGCg23kzsO7mQKLofSLDM/kHYvUfT4SdbyrRHGWEVNpDPp-qE/application-modules/tag] exit status 1 prefix=[/home/atlantis/.atlantis/repos/Rippling/terraform-snowflake/406/default/multi-region/dev/us1/resources/tag]
time=2024-09-17T23:06:06Z level=error msg=1 error occurred:
	* [/home/atlantis/.atlantis/repos/Rippling/terraform-snowflake/406/default/multi-region/dev/us1/resources/tag/.terragrunt-cache/Ulx83QFGCg23kzsO7mQKLofSLDM/kHYvUfT4SdbyrRHGWEVNpDPp-qE/application-modules/tag] exit status 1

I mean that masking policies are schema-level objects, and a part of their id is also schema and database name. A fully qualified name of a masking policy looks like "<database_name>"."<schema_name>"."<policy_name>" and this is an expected format in snowflake_tag_masking_policy_association resource. I think that here you just pass <policy_name>, so this needs to be adjusted. Read more on Snowflake identificators here.
In v0.95.0, each resource has a fully_qualified_name field that returns a computed fully qualified name, so there's no need to construct these manually. We highly recommend migrating to this version and using this field.

Got it. Thank you. Will try this with the latest version

This worked after upgrading the version and mentioning the fully_qualified_name for the resources


WIFI AP

Describe you new feature you'd like
Hi
I look arround and did not found a way to disable the wifi AP.
Is that possible ?
Thanks for this great job bth.

As soon as you successfully connect with WiFi or wired connection and reboot it will disable the AP and only enable it if it cannot connect.  It needs to do this so that it does not brick if you simply change your connection credentials.

Ok I Will  double check that.
On an other project, they disable the AP after a configured time period (e.g. 5min)
And if we need AP, we just need to reboot the esp.
Thanks for your quick answer


workflows: disable docs during make

Requires https://github.com/OISF/suricata/pull/9258

Replaced by #1319 ?


Content Shell as Dart Editor Panel/Internal Browser

What steps will clearly show the issue / need for enhancement?
I don't know how hard this would be to implement but if Content Shell could be embedded in Dart Editor as a Panel/Internal Browser it would allow people to write plugins in Dart that could then be used in both Dart Editor and Chrome/Chrome Dev Editor.
Looking here: http://www.eclipse.org/swt/faq.php#browserlinux it seems that WebKit is already supported somehow in Eclipse as an internal browser. Would it be possible to do the same for Content Shell/Dartium?
There are already two use cases for this today: Observatory and the Polymer UI Editor. With Content Shell available in Dart Editor those applications could be Panels.
The usefulness would be huge even if none of the Dart Editor APIs are exposed to Content Shell (Observatory and Polymer UI don't need it).
Not everyone has two monitors where they can have Dart Editor on one and browser with Observatory/Polymer UI Editor/Something else on the other.
Other plugins could be built in Dart/Content Shell, such as:
* a test result tree renderer, code coverage, etc
* integration with task tracking/project management apps

This issue has been moved to dart-lang/eclipse3#28.


puppeteer not working on Ubuntu 16.04 but works on 14.04

I have the same nodejs project running on 16.04 and 14.04
on 16.04 fails with:
Error: Failed to connect to chrome!
    at Function.launch (/home/ageorgios/c9/projects/scrapi/node_modules/puppeteer/lib/Launcher.js:96:13)
    at process._tickDomainCallback (internal/process/next_tick.js:135:7)

Please help.

Please include your node version and code that repros the issue.

@ebidel brand new ubuntu 16.04 VM on GCE, fully updated
ubuntu@rend:~/test⟫ node -v
v8.4.0
ubuntu@rend:~/test⟫ npm -v
5.3.0
ubuntu@rend:~/test⟫ npm install --save puppeteer

><EMAIL_ADDRESS>install /home/ubuntu/test/node_modules/puppeteer
> node install.js

Downloading Chromium r494755 - 92.1 Mb [====================] 100% 0.0s
npm WARN saveError ENOENT: no such file or directory, open '/home/ubuntu/test/package.json'
npm notice created a lockfile as package-lock.json. You should commit this file.
npm WARN enoent ENOENT: no such file or directory, open '/home/ubuntu/test/package.json'
npm WARN test No description
npm WARN test No repository field.
npm WARN test No README data
npm WARN test No license field.

+<EMAIL_ADDRESS>added 36 packages in 13.051s
ubuntu@rend:~/test⟫ node -e "(async () => { try { browser = await require('puppeteer').launch(); } catch (e) { console.error(e); } })();"
Error: Failed to connect to chrome!
    at Function.launch (/home/ubuntu/test/node_modules/puppeteer/lib/Launcher.js:96:13)
    at <anonymous>
    at process._tickCallback (internal/process/next_tick.js:188:7)

@alex88
That was it thank you!!

Started working after I updated mu node version (used nvm to do that).


Spine Component

Description
Hi @inlet
I'd like to add the Spine's support (http://esotericsoftware.com/) as it is a very popular tool for designers and animators in the game development world (we for example use it quite a lot) and it is already working nicely with PIXI through the pixi-spine (https://pixijs.io/examples/#/plugin-spine/dragon.js). The way is going to work it will be very easy to also add dynamic content generated in PIXI to existing Spine animations through the React compound component pattern.
I am going to submit a PR soon if you feel it'd be a good addition to the library

Hi @paolotozzo, wow you're on 🔥!
Love to see the PR, thanks!

Madness @paolotozzo !! 🔥

Any progress on this, @paolotozzo? If not, I might give it a go.

@ascorbic Hi Matt, I got slightly sidetracked last week, but planning to finish over the course of next week

I got a rough demo working yesterday. Gist is here: https://gist.github.com/ascorbic/f01009247f859f0d76b8b92d34ae87bd
Demo here: https://master.d1bkaw8b0oav5y.amplifyapp.com/

Great, my PR is almost ready, things are a bit busier than expected but as I am now left with only to write the documentation by the end of the week I'll be able to submit it

#174


PowerShell .Net Standard 2.0 support

I understand traditional PowerShell not making it out of experimental for v1 of Azure Functions. Can you share any loose thoughts about supporting PowerShell .Net Standard 2.0 in the future, as this probably would fit the Azure Functions v2 platform a lot better, and possibly scale a lot better.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 40e84dea-0cdb-2aa7-6aa0-a4c697ef19ac
Version Independent ID: 2fe0dbd3-7e5b-04b1-46e5-fecd89c4a780
Content: Supported languages in Azure Functions
Content Source: articles/azure-functions/supported-languages.md
Service: functions
GitHub Login: @tdykstra
Microsoft Alias: tdykstra

Thanks for the feedback! We are currently investigating and will update you shortly.

@tdykstra , @ggailey777 an insights into this one? Or would this roadmap question be better suited directly on the functions github page?
https://github.com/Azure/Azure-Functions/issues

Yes, we can't address roadmap issues in docs.

Great thanks Tom.
@wobba can you please ask this directly on the functions GitHub I linked above? The product team is active there and should be able to provide you some guidance. Feel free to come back and link the issue here so we can track and follow up as well.


Operator Hub: next stability level

We are listed with an "alpha" channel and without the "Full Lifecycle" capability. Depending on the definition of the later, we should support it.
We also should replace "alpha". What's the next level? "beta"?

Let's replace "alpha" with "stable".

As per guiding questions listed at https://sdk.operatorframework.io/docs/advanced-topics/operator-capabilities/operator-capabilities/#level-3---full-lifecycle, I feel we not yet support the below to move to "Full Lifecycle":
Does your Operator allow adding/removing read-only slave instances of your Operator?
Does your operand have a Liveness probe?
Does your operand have a Readiness probe which will fail if any aspect of the operand is not ready? e.g. if the connection to the database fails.
Does your operator create a PodDisruptionBudget resource for your operand pods?

Any idea what that means?

Does your operand have a Liveness probe?

Can be added.
We could add the livenessprobe sidecar, but adding a HTTP endpoint is easier.

Does your operand have a Readiness probe which will fail if any aspect of the operand is not ready? e.g. if the connection to the database fails.

Same here.

Does your operator create a PodDisruptionBudget resource for your operand pods?

Not yet, to be added.

This starts to make more sense when replacing "of your Operator" with "of your operand". In the context of databases, this could be a read-only, internally consistent snapshot of the database for backup purposes.

Does your operator create a PodDisruptionBudget resource for your operand pods?

This only makes sense for the controller, and only if we enable replication. For that we need to know how the scheduler will reach the controller - through the service or through an external load balancer?

Does your operator create a PodDisruptionBudget resource for your operand pods?

This only makes sense for the controller, and only if we enable replication. For that we need to know how the scheduler will reach the controller - through the service or through an external load balancer?

For OpenShift, access to the scheduler extender and the webhook is done through the service, so replication would make sense to avoid outages during a rolling update. I started the implementation (see last commit in https://github.com/intel/pmem-csi/pull/1025), I am just not sure whether we should tackle that for 1.0.

PR #1025 was merged. What we haven't done yet is bump the capability in the bundle meta data.
@avalluri once v1.0.0 is released, can you take care of submitting the operator update to Operator Hub and while doing that, increase the capability to "Full Lifecycle"?

We might also have to consider how testing will work once v1.0.0 is the base version and testing happens on OpenShift: then the base bundle is not the one we published on Operator Hub and the base image not intel/pmem-csi-driver:v1.0.0.

once v1.0.0 is released, can you take care of submitting the operator update to Operator Hub and while doing that, increase the capability to "Full Lifecycle"?

Done: https://operatorhub.io/operator/pmem-csi-operator

We might also have to consider how testing will work once v1.0.0 is the base version and testing happens on OpenShift: then the base bundle is not the one we published on Operator Hub and the base image not intel/pmem-csi-driver:v1.0.0.

Fixed by https://github.com/intel/pmem-csi/pull/1035


Cmd

removed line number 46

hey @crescentpartha, actually this is my first time contributing so that's why I'm a bit nervous. Do let me know if you want me to add rename command (as I have removed the command and updated the .md file)

Can you tell if my updated content is merged or not, I cannot able to see it


About the cosine distance calculation

Hi,
I was going through your code on GitHub, specifically this file: adapt_algorithms.py. I was wondering what does  XX+YY+XY do for the distance calculation. Can we simply use  `1-cosine_similarity' as the distance?
Could you shed some light on the reasoning behind this calculation? I'm interested in understanding the logic behind it.
Best regards,
JO

Thank you for your interest in our work. In many metric learning works, including prototypical network (Snell et al., 2017), the Euclidean metric and cosine similarity which normalize feature representations are commonly used to calculate the distance between features in the embedding space. Our work is inspired from these studies.


K8SPXC-237 Upgrade cert-manager dependancy

Test name
Status

self-healing
failed

scaling
failed

recreate
failed

init-deploy
failed

big-data
failed

self-healing-advanced
failed

scaling-proxysql
failed

demand-backup
failed

storage
failed

upgrade
failed

limits
passed

operator-self-healing
failed

scheduled-backup
failed

one-pod
passed

auto-tuning
failed

monitoring
failed

monitoring-2-0
failed

affinity
passed

proxysql-sidecar-res-limits
failed

upgrade-consistency
failed

Test name
Status

recreate
passed

scaling
passed

big-data
failed

init-deploy
passed

self-healing
failed

scaling-proxysql
passed

self-healing-advanced
passed

storage
passed

demand-backup
failed

upgrade
passed

operator-self-healing
passed

limits
passed

monitoring
passed

upgrade-consistency
passed

monitoring-2-0
passed

one-pod
passed

auto-tuning
passed

affinity
passed

proxysql-sidecar-res-limits
passed

scheduled-backup
failed

Test name
Status

big-data
failed

scaling
failed

self-healing
failed

init-deploy
passed

recreate
passed

scaling-proxysql
passed

self-healing-advanced
passed

upgrade
passed

storage
failed

demand-backup
failed

upgrade-consistency
passed

operator-self-healing
passed

limits
passed

one-pod
failed

monitoring
passed

monitoring-2-0
passed

scheduled-backup
failed

affinity
passed

auto-tuning
passed

proxysql-sidecar-res-limits
passed

Test name
Status

scaling
passed

recreate
passed

self-healing
failed

init-deploy
failed

big-data
failed

storage
failed

self-healing-advanced
passed

scaling-proxysql
passed

demand-backup
failed

operator-self-healing
passed

limits
failed

upgrade
passed

monitoring
passed

one-pod
failed

upgrade-consistency
passed

monitoring-2-0
passed

affinity
passed

scheduled-backup
failed

proxysql-sidecar-res-limits
passed

auto-tuning
passed

Test name
Status

self-healing
failed

scaling
passed

recreate
failed

big-data
failed

init-deploy
failed

demand-backup
failed

scheduled-backup
failed

self-healing-advanced
passed

scaling-proxysql
passed

storage
passed

operator-self-healing
passed

limits
passed

upgrade
passed

monitoring
passed

one-pod
failed

upgrade-consistency
passed

monitoring-2-0
passed

affinity
passed

proxysql-sidecar-res-limits
passed

auto-tuning
passed

Test name
Status

init-deploy
passed

self-healing
failed

scaling
passed

big-data
failed

recreate
passed

self-healing-advanced
passed

scaling-proxysql
passed

storage
passed

demand-backup
failed

upgrade
passed

operator-self-healing
passed

limits
passed

monitoring
passed

upgrade-consistency
passed

monitoring-2-0
passed

one-pod
failed

affinity
passed

scheduled-backup
failed

proxysql-sidecar-res-limits
passed

auto-tuning
passed

Test name
Status

big-data
failed

init-deploy
passed

scaling
passed

recreate
passed

self-healing
passed

scaling-proxysql
passed

storage
passed

self-healing-advanced
passed

demand-backup
failed

upgrade
passed

limits
passed

operator-self-healing
passed

upgrade-consistency
passed

monitoring
passed

one-pod
failed

monitoring-2-0
passed

affinity
passed

scheduled-backup
failed

proxysql-sidecar-res-limits
passed

auto-tuning
passed

Test name
Status

Test name
Status

Test name
Status

Test name
Status

Test name
Status

Test name
Status

Test name
Status

Test name
Status

big-data
passed

init-deploy
passed

self-healing
passed

recreate
passed

scaling
passed

scaling-proxysql
passed

storage
passed

demand-backup
passed

limits
passed

self-healing-advanced
passed

upgrade
passed

monitoring
passed

operator-self-healing
passed

upgrade-consistency
passed

monitoring-2-0
passed

affinity
passed

one-pod
passed

scheduled-backup
failed

auto-tuning
passed

proxysql-sidecar-res-limits
passed

Test name
Status

big-data
passed

init-deploy
passed

self-healing
passed

recreate
passed

storage
passed

self-healing-advanced
passed

demand-backup
passed

limits
passed

operator-self-healing
passed

scheduled-backup
failed

monitoring
passed

one-pod
passed

monitoring-2-0
passed

auto-tuning
passed

affinity
passed

proxysql-sidecar-res-limits
passed

scaling
passed

scaling-proxysql
passed

upgrade
passed

upgrade-consistency
passed

Test name
Status

init-deploy
passed

storage
passed

limits
passed

monitoring
passed

scaling
passed

monitoring-2-0
passed

scaling-proxysql
passed

affinity
passed

upgrade
passed

proxysql-sidecar-res-limits
passed

upgrade-consistency
passed

recreate
passed

big-data
passed

demand-backup
passed

scheduled-backup
failed

self-healing
passed

self-healing-advanced
passed

operator-self-healing
passed

one-pod
passed

auto-tuning
passed

Test name
Status

init-deploy
passed

big-data
passed

scaling
passed

storage
passed

scaling-proxysql
passed

limits
passed

upgrade
passed

monitoring
passed

recreate
passed

upgrade-consistency
passed

monitoring-2-0
passed

demand-backup
passed

affinity
passed

scheduled-backup
failed

proxysql-sidecar-res-limits
passed

self-healing
passed

self-healing-advanced
passed

operator-self-healing
passed

one-pod
passed

auto-tuning
passed

Test name
Status

scaling
passed

big-data
passed

scaling-proxysql
passed

recreate
passed

upgrade
passed

demand-backup
passed

upgrade-consistency
passed

scheduled-backup
passed

init-deploy
passed

storage
passed

limits
passed

monitoring
passed

monitoring-2-0
passed

affinity
passed

proxysql-sidecar-res-limits
passed

self-healing
passed

self-healing-advanced
passed

operator-self-healing
passed

one-pod
passed

auto-tuning
passed

PXC operator docker - perconalab/percona-xtradb-cluster-operator:PR-359-cfd84aa3

Test name
Status

Test name
Status

init-deploy
passed

storage
passed

limits
passed

monitoring
passed

scaling
passed

scaling-proxysql
passed

monitoring-2-0
passed

affinity
passed

upgrade
passed

big-data
passed

proxysql-sidecar-res-limits
passed

upgrade-consistency
passed

recreate
passed

demand-backup
passed

scheduled-backup
failed

self-healing
passed

self-healing-advanced
passed

operator-self-healing
passed

one-pod
passed

auto-tuning
passed

PXC operator docker - perconalab/percona-xtradb-cluster-operator:PR-359-cfd84aa3

Test name
Status

scaling
passed

scaling-proxysql
passed

upgrade
passed

upgrade-consistency
passed

self-healing
passed

self-healing-advanced
passed

operator-self-healing
passed

one-pod
passed

recreate
passed

auto-tuning
passed

big-data
passed

demand-backup
passed

scheduled-backup
passed

init-deploy
passed

storage
passed

limits
passed

monitoring
passed

monitoring-2-0
passed

affinity
passed

proxysql-sidecar-res-limits
passed

PXC operator docker - perconalab/percona-xtradb-cluster-operator:PR-359-cfd84aa3

Test name
Status

big-data
passed

scaling
passed

scaling-proxysql
passed

upgrade
passed

init-deploy
passed

recreate
passed

upgrade-consistency
passed

storage
passed

demand-backup
passed

limits
passed

scheduled-backup
passed

monitoring
passed

monitoring-2-0
passed

affinity
passed

proxysql-sidecar-res-limits
passed

self-healing
passed

self-healing-advanced
passed

operator-self-healing
passed

one-pod
passed

auto-tuning
passed

Test name
Status

init-deploy
passed

storage
passed

limits
passed

monitoring
passed

monitoring-2-0
passed

affinity
passed

proxysql-sidecar-res-limits
passed

self-healing
passed

big-data
passed

self-healing-advanced
passed

operator-self-healing
passed

one-pod
passed

auto-tuning
passed

recreate
passed

demand-backup
passed

scheduled-backup
failed

scaling
passed

scaling-proxysql
passed

upgrade
passed

upgrade-consistency
passed

PXC operator docker - perconalab/percona-xtradb-cluster-operator:PR-359-cfd84aa3

Test name
Status

scaling
passed

big-data
passed

scaling-proxysql
passed

upgrade
passed

upgrade-consistency
passed

init-deploy
passed

storage
passed

limits
passed

monitoring
passed

monitoring-2-0
passed

affinity
passed

proxysql-sidecar-res-limits
passed

self-healing
passed

recreate
passed

self-healing-advanced
passed

demand-backup
passed

scheduled-backup
passed

operator-self-healing
passed

one-pod
passed

auto-tuning
passed


The use of models on large images

hello~~
hi~i want to ask how much memory is required to run the model if the size of the input picture is 1024×1024？ i run the demo 0_local_p4_selfattention.ipynb，i put in a picture of myself，and the shape of the input_tensor is torch.Size([1, 96, 256, 256])，i can get the result of LiftLocalSelfAttention， but when i run “out_2 = sa_2(out_1)”，an error will be reported：
RuntimeError: [enforce fail at CPUAllocator.cpp:68] . DefaultCPUAllocator: can't allocate memory
Is this model unable to load large images and Is it possible to reduce patch_size
thanl you！！！！！！

HI liminyu-web,
I apologize for the long delay. I am afraid missed your issue.
Unfortunately, the memory requirements of self-attention are quadratic. That means there are huge! To give you an idea, we use 2 TitanRTX with 24GBs of memory each to train on the CIFAR-10 dataset with batches of size 24 (That is, to process a total of 243232=24,576 pixels). If we were to use 1024x1024 images, we would require processing 1,048,576 pixels, which is ~50 times more than what we can process with two GPUs.
Although it is possible to reduce the patch_size (see config file), I am afraid that you won't be able to make it small enough to be able to process images of that size.
I am sorry for your inconvenience & I thank you for your interest. Please let me know if there's anything I can help with.
Cheers,
David


VMAgent config is not generated properly then attach_metadata is set.

HI.
I'm using this VMServiceScrape resource to scrape data from node-exporter service:
apiVersion: operator.victoriametrics.com/v1beta1
kind: VMServiceScrape
metadata:
  labels:
    app.kubernetes.io/instance: victoria-metrics-k8s-stack
    app.kubernetes.io/managed-by: Helm
    app.kubernetes.io/name: victoria-metrics-k8s-stack
    app.kubernetes.io/version: v1.91.3
    argocd.argoproj.io/instance: victoria-metrics-k8s-stack
    helm.sh/chart: victoria-metrics-k8s-stack-0.17.0
  name: victoria-metrics-k8s-stack-node-exporter
  namespace: victoria-metrics
spec:
  endpoints:
  - attach_metadata:
      node: true
    metricRelabelConfigs:
    - action: drop
      regex: /var/lib/kubelet/pods.+
      source_labels:
      - mountpoint
    port: metrics
  jobLabel: jobLabel
  selector:
    matchLabels:
      app.kubernetes.io/name: prometheus-node-exporter

VM operator generates following job configuration for VMagent:
- job_name: serviceScrape/victoria-metrics/victoria-metrics-k8s-stack-node-exporter/0
  honor_labels: false
  kubernetes_sd_configs:
  - role: endpoints
    attach_metadata:
      node: "true"
    namespaces:
      names:
      - victoria-metrics
  relabel_configs:
  ....

Looks like operator converting boolean true to string.
VMAgent fails to read this config:
2023-07-21T23:08:20.718Z	info	VictoriaMetrics/lib/promscrape/scraper.go:114	reading Prometheus configs from "/etc/vmagent/config_out/vmagent.env.yaml"
2023-07-21T23:08:20.723Z	fatal	VictoriaMetrics/lib/promscrape/scraper.go:117	cannot read "/etc/vmagent/config_out/vmagent.env.yaml": cannot parse Prometheus config from "/etc/vmagent/config_out/vmagent.env.yaml": cannot unmarshal data: yaml: unmarshal errors:
  line 368: cannot unmarshal !!str `true` into bool; pass -promscrape.config.strictParse=false command-line flag for ignoring unknown fields in yaml config

Thanks for report!

Fixed at v0.36.0 release


Blas-like Prompt Parallelization?

Is it possible to make prompt processing faster with help of a gpu device, just like CuBLAS or ClBlast can with CPU hosted Llama models or other?

It is possible, but would require implementing sequence processing mode. Currently, only RNN mode is implemented, that is, processing token-by-token.


ccl: allow partitioned inverted indexes

PR: https://github.com/cockroachdb/cockroach/pull/59858
From release notes:

Partitioned inverted indexes are now supported. [#59858][#59858] {% comment %}doc{% endcomment %}

Hi @mgartner !
I looked at the tests you added for inverted indexes on REGIONAL BY ROW tables in cockroachdb/cockroach#60018
my assumption is that if I add an inverted index to a JSON column in a RBR table as shown in e.g.
CREATE TABLE regional_by_row_table (
   pk int,
   a int,
   j JSON,
   INVERTED INDEX (a, j)
 )
 LOCALITY REGIONAL BY ROW

then CockroachDB automatically partitions the index for me by region like it does with other indexes on RBR tables (as described in this docs PR: #10280 )
is that correct?
(cc @rytaft since you reviewed #10280 and I may not be formulating the question very well w.r.t. how inverted indexes work)

Yep that's correct! crdb_region is automatically added as an implicit partitioning column to all indexes, including inverted indexes (unless crdb_region is listed explicitly, in which case the explicit column is used as the partitioning column).


mobile: getting rid of compression code

Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

/retest

/retest

/retest

/retest


Add --all-targets to cargo test in github rust action

Codecov Report

Merging #467 (d9e2578) into main (091765d) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #467   +/-   ##
=======================================
  Coverage   91.06%   91.06%
=======================================
  Files         159      159
  Lines        9247     9247
=======================================
  Hits         8421     8421
  Misses        826      826

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 091765d...d9e2578. Read the comment docs.


Update DeleteBehavior to allow client-only cascades

Issue #12661

Yep. Forgot to reference it in the commit message.


Build from source code

Hi!
When I build from source code and run installer.exe my mouse stops working after reboot (debug build X64; uninstaller.exe fixes).
Also file wrapper/input.h probably misses "#include <string>"
I want to contribute. What is the right way to build and debug driver?

Or maybe it would be easier if you implement feature by yourself)
Rawaccel now uses mouse input speed as input.
I want rawaccel to use mouse distance offset from some point as input (similar to joystick).
In GUI it will probably be:

Checkbox (feature enabled/disabled)
TextBox for one number ("time to travel" or how much mouse offset is divided by to get input speed)
TextBox for one number (minimal offset for mouse to move; otherwise it would be hard to use Windows)

I guess there will be some difficulties in implementing as your callbacks should be called not only on mouse movement but every x milliseconds too.

Hello,
Multiple things here:
"wrapper/input.h probably misses "#include "
Yes, I have addressed this in my branch "userinterface" which includes UI overhaul for RA 2.0
"I want to contribute. What is the right way to build and debug driver?"
You are coming in at an interesting time. Right now the big thing that needs doing is taking userinterface branch from my repo and start cleaning up the UI.
As far as building and debugging driver, you will need:

Windows SDK and WDK for your version of Windows 10 or 11
MSVC, spectre-mitigated, C++/CLI support for v143 x64/x86 build toolds
Avalonia (for building latest UI): https://avaloniaui.net/gettingstarted#installation
You will then need to build the entire solution. Before running installer.exe and restarting, you need to make sure that testsigning is enabled, which may be as simple as running a bcdedit command or may require BIOS edits. (This is the step that I would guess you have missed.)

"I want rawaccel to use mouse distance offset from some point as input (similar to joystick)."
Your algorithm as stated does not make much sense to me. How does the user set the "center point"? What happens when the user picks the mouse up (which happens through natural motion all the time)? Why would it be hard to use windows without minimal offset - that would be a function of the curve, right?

Thank you! It works with testsigning.
I used those links:

.NET Framework 4.7.2
SDK + WDK + MSVC libs
after opening solution "Tools > NuGet Package Manager > Package Manager Console" and restore missing NuGet packages
enable testsigning
use pipe to see stdout "rawaccel.exe > output.txt"

How does the user set the "center point"? What happens when the user picks the mouse up?

Center point is where mouse was when driver started (or when feature was enabled). Only way for user to change center point is to pick mouse up


Question about data results

It seems that as soon as a number is entered into the system you can use the portal and search it. It will only return the company name. But it seems about after 24 hours when searching https://safer.fmcsa.dot.gov/CompanySnapshot.aspx it will then contain all the info about the USDOT number. Is there a way to get this data immediately without having to wait 24 hours?

@ph3l1x python-safer will only search what is available in the Safer system.
This package reads the website just like you would if you were browsing it.
Does that make sense?

Yes very much so. Do you know if there is a way to access the data quicker?
I know if someone that has a script that can access the data immediately.
Or of some type of an API. Only asking because there isn't much you about
that site on the internet anywhere and you seen to be the only one I could
find that's worked with their system. Just thought I would ask, and thank
you for your time and responding to me.
Ryan
On Thu, Nov 14, 2019, 8:54 PM Arthur Tyukayev<EMAIL_ADDRESS>wrote:

@ph3l1x https://github.com/ph3l1x python-safer will only search what is
available in the Safer system.
This package reads the website just like you would if you were browsing it.
Does that make sense?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/arthurtyukayev/python-safer/issues/2?email_source=notifications&email_token=ABZA325QHR3CWIU7ODYMD63QTYMPXA5CNFSM4JNFKIW2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEEEG7FA#issuecomment-554200980,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABZA32ZHQI5ME7XFH6IKK73QTYMPXANCNFSM4JNFKIWQ
.

Depending on the exact data that you're looking for there is another government website that has DOT data, it's the FMCSA's SMS (Simple Measurement System).
They might be listing data faster than the Safer system, but I've never actually checked. You can view company at this link, I randomly searched a company:
https://ai.fmcsa.dot.gov/SMS/Carrier/604262/Overview.aspx
This package doesn't support the SMS system, but it can easily be written.


Add Table trace.

https://github.com/igiagkiozis/plotly/issues/148
This issue mentioned the trace.

Really great to see a Table Trace in the pipeline. Would also love to see a Pie Chart Trace if possible. Would love to contribute this, but don't have the requisite skill to do it yet.

Really great to see a Table Trace in the pipeline. Would also love to see a Pie Chart Trace if possible. Would love to contribute this, but don't have the requisite skill to do it yet.

This is also first time I make a pr in plotly, after this pr is merged, I would like to make a similar Pie Chart pr.

Really great to see a Table Trace in the pipeline. Would also love to see a Pie Chart Trace if possible. Would love to contribute this, but don't have the requisite skill to do it yet.

This is also first time I make a pr in plotly, after this pr is merged, I would like to make a similar Pie Chart pr.

Hi @igiagkiozis, would be great to have this pull request approved in your next release. I tried it out and it works quite well. I also find it to be a very useful feature.

@baiguoname I'm glad someone started work on this!
I do think it would make more sense if Table::new() takes a header and a cells struct, unless I'm missing something (I am a rust noob). I think in your code currently there is no way to change the header or cells style without creating a new instance of a header or cell with the same values you used in Table::new() and altering the header field in the struct with Table.header(). It makes more sense to me to create the cell or header beforehand with the values and styles you want and pass it into the table when you're happy with it. I hope that makes sense.
I've made a fork of your repo and am happy to submit a pr to it :) Lmk what you think. Heres the link to my fork: https://github.com/kylemello/plotly

@baiguoname I'm glad someone started work on this! I do think it would make more sense if Table::new() takes a header and a cells struct, unless I'm missing something (I am a rust noob). I think in your code currently there is no way to change the header or cells style without creating a new instance of a header or cell with the same values you used in Table::new() and altering the header field in the struct with Table.header(). It makes more sense to me to create the cell or header beforehand with the values and styles you want and pass it into the table when you're happy with it. I hope that makes sense. I've made a fork of your repo and am happy to submit a pr to it :) Lmk what you think. Heres the link to my fork: https://github.com/kylemello/plotly

Thanks very much, I think it's great. Excuse me, I'm still new to github, what should I do next? Should I close this commit, and you pull a new pr to this crate?

Thanks very much, I think it's great. Excuse me, I'm still new to github, what should I do next? Should I close this commit, and you pull a new pr to this crate?

Sorry for the late reply, I swear github never notifies me of anything.
No, I don't think so... I think submitting a pr onto your branch will do just fine. I think once you merge it you'll be set. I haven't done a pull request on a pull request on GitHub yet so I'm just guessing here lol. Just opened it, here's the link: https://github.com/baiguoname/plotly/pull/1

@baiguoname hi, is this feature still able to be merged? Really looking forward to see it.

Is it ok for me to take over this PR and make it mergable?  @baiguoname @andrei-ng

Is it ok for me to take over this PR and make it mergable? @baiguoname @andrei-ng

Sorry for late reply. Yes, it's ok for me.

Is it ok for me to take over this PR and make it mergable? @baiguoname @andrei-ng

Sorry for late reply. Yes, it's ok for me.

Thx. How do I take over it? I am not familiar with Github's PR. It looks like I just need to resolve merge conflict.

Is it ok for me to take over this PR and make it mergable? @baiguoname @andrei-ng

Sorry for late reply. Yes, it's ok for me.

Thx. How do I take over it? I am not familiar with Github's PR. It looks like I just need to resolve merge conflict.

Please do take it over :) .
My typical worflow is to add the other fork as another remote to my local clone, fetch the branch, check it out, do changes and push it back to the fork e.g.,
git remote add baiguoname git@github.com:baiguoname/plotly.git
git fetch baiguoname
git checkout -b table-pr baiguoname/master

... do changes
git push -u  table-pr HEAD:master

There might be other workflows outhere...

I am not so sure how to link the conflict-resolve PR to this one....

@baiguoname can you merge my branch into your PR branch?

@baiguoname can you merge my branch into your PR branch?

Of course, but how can I do it? I didn't find any pull request or something.

@baiguoname can you merge my branch into your PR branch?

Yes, of course. I have approved your pr . Is there anything else I need to do?

@baiguoname I just update my branch to fix some CI issues. Can you approve it?

@baiguoname and @naijim , should we close this PR in favour of https://github.com/plotly/plotly.rs/pull/207 ?

@baiguoname and @naijim , should we close this PR in favour of #207 ?

Yes, I think so.


Subscription API - GET

User story
User wants to click each subscription and see proper to detailed information. For this, an API is needed to fetch the data.
Description
API is needed to get the data for subscription details
Acceptance Criteria
The API returns the proper data for a testing subscription.
Testing
The API returns the proper data on request of getting a subscription detailed information from the database.

Tested and completed.


Can't sign-in with long password

Describe the bug
I can't sign-in, while the sign-in on the web site works. My password has 24 characters. Is this a problem for the app?

@teolemon can  I work on this?

@mustaqmustu have you managed to establish a preliminary diagnosis/analysis ?

@teolemon as u labeled it...I thought it was a valid issues ...but I have made a new account and checked it...there is no issue with long password :)

I tried it again, today and got it running. I've must done something wrong on the first try. Sorry to have bothered you.

no worries @jo-so :-)
Feel free to join the chat room :-) https://slack.openfoodfacts.org


update to p-g-validate v0.6.13

The only differences to generated code were some whitespace changes to the C++ code.


allow RegExp as managed and immutable paths

add all node_modules as managedPaths in futureDefaults

What kind of change does this PR introduce?
feature

Did you add tests for your changes?
no

Does this PR introduce a breaking change?
no

What needs to be documented once your changes are merged?
nothing

I noticed there isn't much in the documents for this, but it could be very helpful if it was in there. I wouldn't mind making the change, but could use a bit of insight into the design approach.

I noticed that the same patterns that work for rules[n].exclude patterns don't work here. ie: /.*node_modules((?!non-managed-lib).)*$/
I also noticed that the code keeps track of both files and directories to watch, is there a way to specify just a directory easily?

If I had a package / shared library that I wanted webpack to keep an eye on, called non-managed-lib, how would I write the RegEx for it? What was the intent? RegEx is not my strongest. I came up with something like this:
/^(.+?[\\/]node_modules)[\\/]((?!non-managed-lib)).*[\\/]*/) but that seems to add the files individually as well, and not just the directories.

PR welcome for docs (we have an issue)

Is there a specific reason why regex is chosen over the original requested feature here: https://github.com/webpack/webpack/issues/12112?
I've tried using regex to define a negative pattern for excluding specific folders  (non managed paths), but my experience so far is somewhat similiar with @joshhogg above. I've got a lot of warning saying:
<w> Managed item _<some/managed/folder/>_ isn't a directory or doesn't contain a package.json

TBH, I myself prefer if the managed and immutable paths configuration is similiar the to rule exclude/ include pattern

Did anyone ever manage to use this feature? Just seems totally broken. We got the same error as IronGeek.
Ping @sokra

@cattermo Can you provide an exanple of the problem?

@cattermo Can you provide an exanple of the problem?

Here is a small repository to reproduce the problem.
https://github.com/cattermo/webpack-managed-path-regex
I'm using a pretty standard Regex to include all but one package in managedPaths:
/node_modules\/(?!(@azure\/msal-browser)\/).*/
When running webpack I get error
/**/webpack-managed-path-regex/node_modules/webpack/lib/FileSystemInfo.js:791
	let i = managedPath.length;
	                    ^

TypeError: Cannot read properties of undefined (reading 'length')
    at getManagedItem (/**/webpack-managed-path-regex/node_modules/webpack/lib/FileSystemInfo.js:791:22)
    at checkManaged (/**/webpack-managed-path-regex/node_modules/webpack/lib/FileSystemInfo.js:2021:26)
    at captureNonManaged (/**/webpack-managed-path-regex/node_modules/webpack/lib/FileSystemInfo.js:2044:10)
    at FileSystemInfo.createSnapshot (/**/webpack-managed-path-regex/node_modules/webpack/lib/FileSystemInfo.js:2127:25)
    at handleBuildDone (/**/webpack-managed-path-regex/node_modules/webpack/lib/NormalModule.js:1046:32)
    at handleParseResult (/**/webpack-managed-path-regex/node_modules/webpack/lib/NormalModule.js:991:12)
    at /**/webpack-managed-path-regex/node_modules/webpack/lib/NormalModule.js:1098:4
    at processResult (/**/webpack-managed-path-regex/node_modules/webpack/lib/NormalModule.js:800:11)
    at /**/webpack-managed-path-regex/node_modules/webpack/lib/NormalModule.js:860:5
    at /**/webpack-managed-path-regex/node_modules/loader-runner/lib/LoaderRunner.js:407:3

@cattermo Sorry for delay, please use /(node_modules\/(?!(@azure\/msal-browser)\/)).*/,
You can look at the default value - /^(.+?[\\/]node_modules)[\\/]/ (for npm), here you should have a directory (not true/false), i.e. using group (()).
I think we should document this. Feel free to questions

@cattermo Sorry for delay, please use /(node_modules\/(?!(@azure\/msal-browser)\/)).*/ or just /(node_modules\/(?!(@azure\/msal-browser)\/))/
You can look at the default value - /^(.+?[\\/]node_modules)[\\/]/ (for npm), here you should have a directory (not true/false), i.e. using group (()) on the part of path. Also I recommend to use [//\], because I think you need windows here.
But it will add node_modules to a manager path, but I think you expected to add all except @azure/msal-browser...
Try this:
/^(.+?[\\/]node_modules[\\/](?!(@azure[\\/]msal-browser))(@.+?[\\/])?.+?)[\\/]/

Looks tricky, but should work.
I think we should document this. Feel free to ask questions.

So we just needed the capture group 🤦♀
Thanks for the help! Would be great if this was documented since Regex in rules works differently.

I am trying to do something similar:
/^(.+?[\\/]node_modules[\\/](?!(@foo|@bar))(@.+?[\\/])?.+?)[\\/]/, which works, but I get some warnings like the following:
Managed item <absolute path>/node_modules/@reduxjs isn't a directory or doesn't contain a package.json (see snapshot.managedPaths option)
What is the correct regex? I can't even turn off the warning logs. It seems like these logs get logged even if I set up logging to only log errors. Any advice would be great. Thank you so much!

I am trying to do something similar:
/^(.+?[\\/]node_modules[\\/](?!(@foo|@bar))(@.+?[\\/])?.+?)[\\/]/, which works, but I get some warnings like the following:
Managed item <absolute path>/node_modules/@reduxjs isn't a directory or doesn't contain a package.json (see snapshot.managedPaths option)
What is the correct regex? I can't even turn off the warning logs. It seems like these logs get logged even if I set up logging to only log errors. Any advice would be great. Thank you so much!

I am having the same issue. Also, it seems that due to this issue, I am also having the following error from chokidar. If I comment out the snapshot configuration, the chokidar error also disappears.
LOG from webpack.FileSystemInfo
<w> Managed item ABSOLUTE_PATH\node_modules\@types isn't a directory or doesn't contain a package.json (see snapshot.managedPaths option)
<w> Managed item ABSOLUTE_PATH\node_modules\@redux-devtools isn't a directory or doesn't contain a package.json (see snapshot.managedPaths option)
+ 13 hidden lines

webpack 5.75.0 compiled successfully in 16355 ms
node:events:491
      throw er; // Unhandled 'error' event
      ^

Error: EBUSY: resource busy or locked, lstat 'C:\pagefile.sys'
Emitted 'error' event on FSWatcher instance at:
    at FSWatcher._handleError (ABSOLUTE_PATH\node_modules\chokidar\index.js:647:10)
    at ReaddirpStream.NodeFsHandler._boundHandleError (ABSOLUTE_PATH\node_modules\chokidar\lib\nodefs-handler.js:303:43)
    at ReaddirpStream.emit (node:events:513:28)
    at emitErrorNT (node:internal/streams/destroy:157:8)
    at emitErrorCloseNT (node:internal/streams/destroy:122:3)
    at processTicksAndRejections (node:internal/process/task_queues:83:21) {
  errno: -4082,
  code: 'EBUSY',
  syscall: 'lstat',
  path: 'C:\\pagefile.sys'
}

Without configuration I can't help, will be better if somebody create a minimum reproducible test repo, thank you

@alexander-akait Here is my configuration
snapshot: {
  managedPaths: [
    /^(.+?[\\/]node_modules[\\/](?!(@scope1[\\/])|(@scope2[\\/])|(prefix-.+?[\\/])).+?)[\\/]/
  ]
}

The intent is to instruct the webpack to ignore changes in the node module other than [<EMAIL_ADDRESS>

/^(.+?[\/]node_modules\/(@.+?[\/])?.+?)[\/]/

As you can see you need to provide nested directories (like msal-browser, yes, you can change it on [\\/].+?[\\/]), otherwise node_modules\@types will be consideren as a package

Following what was documented, I tried using a regex like:
^(.+?[\\/]node_modules[\\/](?!(@ignoreme))(@.+?[\\/])?.+?)[\\/]
Yet I was still seeing warnings from improper matching:
Managed item <absolute path>/node_modules/@next isn't a directory or doesn't contain a package.json (see snapshot.managedPaths option).
From what I can tell, this regex is actually the correct one:
^(.+?[\\/]node_modules)[\\/](?!(@ignoreme))(@.+?[\\/])?.+?[\\/]
The only difference here is what is returned in the first capture group. It seems that when matched against a given path, the regex should output what managed folder it belongs to in capture group 1. From what I can tell, every path is checked against the regex, rather than skipping ones "known" to be within a managed folder.
Hope this helps someone else!

@Sayan751 I am fine with array, do you want to send a PR? Should be not hard

@alexander-akait I have created a PR for this. You may review, and let me know any further changes are required.


Added option to disable auto bracketing in sub and superscript mode.

Resolves #605
Additions
Option to disable auto bracketing in sub/superscript in Texify settings.
Changes
Restricted the character set after which auto bracketing is triggered to alphanumeric only.
Backwards incompatible changes
None

There are conflicts that are aching to be resolved :) @stenwessel

Nvm. Resolved them myself. Merging when CI passes.


Enhance awssecurityhub parser.py

First attempt at enhancing a parser and reading - ( https://defectdojo.github.io/django-DefectDojo/contributing/how-to-write-a-parser/ )
The goal is to add the resource_type and resource_id to join to create a host / endpoint.
A Finding should always have a host, but a host does not always contain an IP in the context of AWS Security Hub Findings.  This enhancement should (hopefully) add an Endpoint field to a Finding, reducing the number of Findings from AWS Security Hub that do not contain any Host/Endpoint data.
A Finding without an actual Host/Endpoint is to me - incomplete by design and for the structure of DefectDojo Findings.
:warning: Note on feature completeness :warning:
We are narrowing the scope of acceptable enhancements to DefectDojo in preparation for v3. Learn more here:
https://github.com/DefectDojo/django-DefectDojo/blob/master/readme-docs/CONTRIBUTING.md
Description
Enhance AWS Security Hub parser to include an Endpoint field for Findings that currently do not have one.
Test results
This is my first PR attempting to edit a parser, so I'm not fully sure what I should be testing.
Documentation
Please update any documentation when needed in the documentation folder)
Checklist
This checklist is for your information.

[X] Make sure to rebase your PR against the very latest dev.
[X] Features/Changes should be submitted against the dev.
[ ] Bugfixes should be submitted against the bugfix branch.
[X] Give a meaningful name to your PR, as it may end up being used in the release notes.
[ ] Your code is flake8 compliant.
[ ] Your code is python 3.11 compliant.
[ ] If this is a new feature and not a bug fix, you've included the proper documentation in the docs at https://github.com/DefectDojo/django-DefectDojo/tree/dev/docs as part of this PR.
[ ] Model changes must include the necessary migrations in the dojo/db_migrations folder.
[ ] Add applicable tests to the unit tests.
[ ] Add the proper label to categorize your PR.

Extra information

enhancement
bugfix? (if you consider a Finding with no Endpoint a bug?)

Looking for suggestions on the host = join that I implemented from the 2 respective fields to populate the Endpoint.  Maybe resource_id is fine by itself and resource_type can be removed, since in the resource_id the type is mentioned in the ARN?

@manuel-sommer thank you for the guidance, this is my first PR and I have very little experience with python development and doing unit tests.  I will edit this https://github.com/DefectDojo/django-DefectDojo/blob/master/unittests/tools/test_awssecurityhub_parser.py  to include something like -
self.assertEqual("AwsEc2Instance arn:aws:ec2:us-east-1:098765432109:instance/i-0a1a0c4b881ed0ae2", finding.endpoint)
I assume I would need to do that for both the one_finding#L14 and the one_finding_active#L25 ?
Does the sample data file matter, or is the construct example above fine?

Hi @testaccount90009,
if you want, I can help you with a PR, this would be easier and then you can take a look at the PR to learn from it.

@manuel-sommer sure thing.  I will look for your new PR and close this one.  I appreciate the opportunity to learn!

You can close this @testaccount90009 , see PR 9814

#9814 - making the PR link active


Add bound point reference annotation

Adding a bound point reference annotation. This can allow, for example, alternative segmentation lookup points for nuclei that fell badly in the original segmentation.

Looks good, can we add tests?


Added  remaining datasets to test_load_dataset

Added additional datasets to test

m4_quarterly
m4_yearly
bike_sales_sample
bike_sharing_daily
taylor_30_min
walmart_sales_weekly
wikipedia_traffic_daily

Nice work Jeff!


[RESOLVED] High ICMP ping response time

Problem started at 12:02:14 on 2023.07.14
Problem name: High ICMP ping response time
Host: MF-FG
Severity: Warning
Operational data: Value: 455ms
Original problem ID: 32642
Event details in Zabbix: http://<IP_ADDRESS>/tr_events.php?triggerid=23132&eventid=32642

Problem has been resolved in 5m 0s at 12:07:14 on 2023.07.14
Problem name: High ICMP ping response time
Host: MF-FG
Severity: Warning
Original problem ID: 32642


Issue due to fitering players by slotStatus > 1

I have a replay with an issue where the player is not in the W3GReplay.players object. The replay fails in processCommandDataBlock since the playerId has not been added. I have seen that players are only added to that object depending on their slotStatus in handleBasicReplayInformation. What does that slotStatus actually mean? If I remove that condition, the replay can be parsed. But it returns a high amount of players. How should we go about this - should we just make the parser more capable to deal with the fact when a player cannot be found? Attached the replay
ced_vs_lyn.zip
Edit: Apparently this (and other replays with the same issue) are customs from the new W3C Flobot.exe

I just asked fluxxu (creator of the hostbots) and it seems like Blizzard added special records for LAN games. Those are not part of the parser here yet.
For reference: https://github.com/nielsAD/gowarcraft3/blob/77326e95295636a1d4a60ab253323e65c4e4a8ca/file/w3g/records.go#L786

Should be fixed in v2.2.2

Fantastic, I have actually noticed that we have the same issue with some old Netease replays so this will most likely also fix that. Currently reparsing 40k+ replays. Very few issues


Add max-txn-size flag to gazctl (not ready for review)

This change is

Connects #154
Connects #159

v2/cmd/gazctl/journals_apply.go, line 37 at r2 (raw file):

	var ctx = context.Background()
	resp, err := client.ApplyJournalsLimit(ctx, journalsCfg.Broker.JournalClient(ctx), req, cmd.MaxTxnSize)

@rupertchen Looking for some feedback here. I have made it so that within the ApplyFn we panic. It seemed like the idea was if you return an error from this function that idea is that the user should then be able to "clean up" the changes in the temp file, and in this case that is not going to be possible. Rather we want to panic with some error information and the user can try again from starting from scratch.
If that seems wrong to you let me know.

v2/pkg/client/list.go, line 109 at r2 (raw file):

// ShardClient.Apply call. Response validation or !OK status from Apply RPC are
// mapped to error. In the event of an error any unapplied changes will be
// available on |parentReq|.

I made a decision here that might be a little divisive and I would like to hear what people think. This function (and ApplyShardsLimit) have side effects wherein the parentReq is mutated as a result of this function. The idea being if there is an error of some kind of you can see what changes were not applied. I could see this helpful however I also acknowledge that functions with side effects can be confusing.

v2/pkg/client/list.go, line 110 at r2 (raw file):
Previously, jgraettinger (Johnny Graettinger) wrote…
nits:

the repo doesn't break lines in this way. Quoting "CodeReviewComments":

If you find that this produces lines that are too long, then change the names or the semantics and you'll probably get a good result.

eg parentReq => req, and maxTxnSize => limit.
(You can use scoped curReq / curResp or something similar within your loop.)
Recall that argument names are part of the documentation contract. As a reader, I have no idea what "parentReq" is (it's just my request?).

I know I threw in ApplyJournalsLimit, but wondering if ApplyJournalsInBatches is a better name.

I think ApplyJournalsLimit works well. In InBatches feels a little cumbersome.

v2/pkg/client/list.go, line 136 at r2 (raw file):
Previously, rupertchen (Rupert Chen) wrote…
FailFast is deprecated, can we use WaitForReady (the opposite) instead?

I believe we are on an older version of grpc which does not support WaitForReady. I will take a look at this.

v2/pkg/client/list.go, line 109 at r2 (raw file):
Previously, jgraettinger (Johnny Graettinger) wrote…
my gut is YAGNI. we shouldn't mutate the request, but can come back later and add this context to the returned error without breaking the API contract if it proves important to have.

Ok, I think given that YAGNI is a good philosophy I think we can punt on the surfacing unapplied changes until we need it. But there are a few nice things that I will borrow from your suggestion Rupert.

v2/pkg/client/list.go, line 110 at r2 (raw file):
Previously, jgraettinger (Johnny Graettinger) wrote…
the trouble is, as a reader I don't know at a glance what Limit is or means. Does it only apply the first N changes? Does it return an error if there are more than N? I think the obvious parallel is io.LimitedReader, which returns EOF on reaching N -- and this seems to imply that not all specs are actually applied.

got it. The LimitedReader is a good parallel.

v2/cmd/gazctl/journals_apply.go, line 68 at r2 (raw file):
Previously, jgraettinger (Johnny Graettinger) wrote…
the number of etcd cmps / ops is 1:1 with the number of specs in the yaml.
etcd doesn't provide a way to introspect the limit, that I'm aware of. the default is currently 128.

I could see it potentially being difficult to figure out exactly how many specs are described in a yaml, so I can include the total number of changes as well as the default etcd config.

v2/pkg/client/list.go, line 136 at r2 (raw file):
Previously, jskelcy (Jake Skelcy) wrote…
I believe we are on an older version of grpc which does not support WaitForReady. I will take a look at this.

It was a local env issue. Ill fix this up.

a discussion (no related file):
@rupertchen @jgraettinger addressed all of your comments PTAL.

v2/cmd/gazctl/journals_edit.go, line 62 at r4 (raw file):
Previously, jgraettinger (Johnny Graettinger) wrote…
nit: var resp, err =  rather than extra declaration lines above
dave cheney recently recommend := if you're initializing a value, and var iff it's zero-valued. I'm down with that, if we want to switch, but we should be consistent.

I like the suggestion from dave cheney but I think given the current pattern we should stick to this.

v2/cmd/gazctl/shards_apply.go, line 37 at r4 (raw file):
Quoted 4 lines of code…

batches of at most the max transaction size, however this means a loss
of transactionality and should be used with caution. Instead it is recomended
that additional label selectors are used to limit the number of changes within
this operation.

Is there a hard and fast rule about why we should not be panic-ing? I saw we were using mbp.must and assumed that there was not an issue with a panic.


Performance Support all match one logic

Proposed changes
tpcds q54:
before: 3.8s
after:3.2s

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall

run buildall

run buildall


Prepare Core Libraries for August 2022 Release

API change check
API changes are not detected in this pull request.


What capture API does this use?

Specifying capture APIs is important on linux as this tool for instance does not work on cosmic-compositor

Seems like this uses xcap which supports gnome's screenshot or portals. Portals should be working, Im hitting a different issue, will try and find out what it is, will leave this open since it's necessary anyways.

Updated the readme in this commit with linux details


ZkCert chainID registry field

We saw with Andromeda and Reticulum that the user might get confused if zkCerts for both chains are listed in the frontend or the snap.
To prevent this, we want to include a chain field in the zkCert registration data to be able to filter them and only show the user available ones.

chainID field added in zkCertRegistration
listZkCerts method of the snap now accepts  filter parameters

Looks good to me.


last cell in '3-seq2seq-native-new.ipynb'

should be:
tracks_time.plot(figsize=(8, 5), title='GRU vs LSTM loss, compute-time')

fixed it, thanks for noticing!