Error: invalid byte sequence in UTF-8

brew doctor output
Please note that these warnings are just used to help the Homebrew maintainers
with debugging if you file an issue. If everything you use Homebrew for is
working fine: please don't worry or file an issue; just ignore this. Thanks!

Warning: Some installed kegs have no formulae!
This means they were either deleted or installed manually.
You should find replacements for the following formulae:
<EMAIL_ADDRESS>
Warning: Some installed formulae are deprecated or disabled.
You should find replacements for the following formulae:
  gcc@5
<EMAIL_ADDRESS>  jsonschema
  libelf

Warning: Unbrewed header files were found in /usr/local/include.
If you didn't put them there on purpose they could cause problems when
building Homebrew formulae, and may need to be deleted.

Unexpected header files:
  /usr/local/include/python2.7/greenlet/greenlet.h
  /usr/local/include/python3.6m/Python-ast.h
  /usr/local/include/python3.6m/Python.h
  […]
  /usr/local/include/python3.6m/warnings.h
  /usr/local/include/python3.6m/weakrefobject.h

Warning: Unbrewed '.pc' files were found in /usr/local/lib/pkgconfig.
If you didn't put them there on purpose they could cause problems when
building Homebrew formulae, and may need to be deleted.

Unexpected '.pc' files:
  /usr/local/lib/pkgconfig/python-3.6.pc

Warning: Unbrewed static libraries were found in /usr/local/lib.
If you didn't put them there on purpose they could cause problems when
building Homebrew formulae, and may need to be deleted.

Unexpected static libraries:
  /usr/local/lib/libpcrs.a
  /usr/local/lib/libpython3.6m.a
  /usr/local/lib/libtcp-portmon.a

Warning: You have unlinked kegs in your Cellar.
Leaving kegs unlinked can lead to build-trouble and cause formulae that depend on
those kegs to fail to run properly once built. Run `brew link` on these:
  pygments
  six
  elfutils
  opencl-icd-loader

The following tools exist at both paths:
  g++-5
  update-mime-database
  ldapexop
  timeout
  ps2pdf13
  […]
  toe
  xmllint
Error: invalid byte sequence in UTF-8
Please report this issue:
  https://docs.brew.sh/Troubleshooting
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/vendor/bundle/ruby/2.6.0/gems/activesupport-<IP_ADDRESS>/lib/active_support/core_ext/object/blank.rb:127:in `match?'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/vendor/bundle/ruby/2.6.0/gems/activesupport-<IP_ADDRESS>/lib/active_support/core_ext/object/blank.rb:127:in `blank?'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/cmd/doctor.rb:63:in `block in doctor'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/cmd/doctor.rb:55:in `each'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/cmd/doctor.rb:55:in `doctor'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/brew.rb:94:in `<main>'

Verification

[X] My "brew doctor output" above says Your system is ready to brew. and am still able to reproduce my issue.
[X] I ran brew update twice and am still able to reproduce my issue.
[X] This issue's title and/or description do not reference a single formula e.g. brew install wget. If they do, open an issue at https://github.com/Homebrew/homebrew-core/issues/new/choose instead.

brew config output
HOMEBREW_VERSION: 4.0.11-33-g7dbe1b4-dirty
ORIGIN: https://github.com/Homebrew/brew
HEAD: 7dbe1b4877ca510b3832d84fb798e2f05e89494a
Last commit: 63 minutes ago
Core tap origin: https://github.com/Homebrew/homebrew-core
Core tap HEAD: 3409af069e4c05f0493d17dc824e0fed4f2d512c
Core tap last commit: 8 weeks ago
Core tap branch: master
Core tap JSON: 04 Apr 09:15 UTC
HOMEBREW_PREFIX: /home/linuxbrew/.linuxbrew
HOMEBREW_AUTO_UPDATE_SECS: 7200
HOMEBREW_BAT: set
HOMEBREW_BAT_CONFIG_PATH: /home/yz/.config/bat/config
HOMEBREW_CASK_OPTS: []
HOMEBREW_DISPLAY: localhost:10.0
HOMEBREW_EDITOR: /usr/bin/vim
HOMEBREW_GITHUB_API_TOKEN: set
HOMEBREW_INSTALL_BADGE: ✔
HOMEBREW_MAKE_JOBS: 2
HOMEBREW_NO_INSTALLED_DEPENDENTS_CHECK: set
Homebrew Ruby: 2.6.8 => /home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/vendor/portable-ruby/2.6.8_1/bin/ruby
CPU: quad-core 64-bit haswell
Clang: 16.0.0
Git: 2.40.0 => /usr/bin/git
Curl: 7.47.0 => /usr/bin/curl
Kernel: Linux 4.4.0-210-generic x86_64 GNU/Linux
OS: Linux Mint 18.3 Sylvia (sylvia)
Host glibc: 2.23
/usr/bin/gcc: 4.9.4
/usr/bin/ruby: 2.3.1
glibc: 2.35_1
gcc@11: 11.3.0
gcc: 12.2.0
xorg: N/A

What were you trying to do (and why)?
what: brew cleanup
why: previous run of brew upgrade ended up with the below:
[…]
Removing: /home/yz/.cache/Homebrew/Logs/packer... (4KB)
Error: invalid byte sequence in UTF-8
Please report this issue:
  https://docs.brew.sh/Troubleshooting
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/cleanup.rb:535:in `match?'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/cleanup.rb:535:in `block (2 levels) in prune_prefix_symlinks_and_directories'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/vendor/portable-ruby/2.6.8_1/lib/ruby/2.6.0/pathname.rb:565:in `block in find'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/vendor/portable-ruby/2.6.8_1/lib/ruby/2.6.0/find.rb:49:in `block (2 levels) in find'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/vendor/portable-ruby/2.6.8_1/lib/ruby/2.6.0/find.rb:48:in `catch'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/vendor/portable-ruby/2.6.8_1/lib/ruby/2.6.0/find.rb:48:in `block in find'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/vendor/portable-ruby/2.6.8_1/lib/ruby/2.6.0/find.rb:43:in `each'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/vendor/portable-ruby/2.6.8_1/lib/ruby/2.6.0/find.rb:43:in `find'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/vendor/portable-ruby/2.6.8_1/lib/ruby/2.6.0/pathname.rb:565:in `find'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/cleanup.rb:531:in `block in prune_prefix_symlinks_and_directories'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/cleanup.rb:528:in `each'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/cleanup.rb:528:in `prune_prefix_symlinks_and_directories'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/cleanup.rb:243:in `clean!'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/cleanup.rb:225:in `periodic_clean!'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/cmd/upgrade.rb:131:in `upgrade'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/brew.rb:94:in `<main>'

What happened (include all command output)?
> brew cleanup
Warning: Skipping (old) /home/linuxbrew/.linuxbrew/Cellar/autogen/5.18.16_2 due to it being linked
Warning: Skipping (old) /home/linuxbrew/.linuxbrew/Cellar/dive/0.10.0 due to it being linked                       W
arning: Skipping git-chglog/git-chglog/git-chglog: most recent version 0.15.4 not installed
Warning: Skipping dty1er/tap/kubecolor: most recent version 0.0.25 not installed
Warning: Skipping (old) /home/linuxbrew/.linuxbrew/Cellar/mesa-glu/9.0.2 due to it being linked
Warning: Skipping (old) /home/linuxbrew/.linuxbrew/Cellar/openjpeg/2.5.0 due to it being linked
Warning: Skipping snyk/tap/snyk: most recent version 1.1137.0 not installed
Warning: Skipping terragrunt: most recent version 0.45.1 not installed
Warning: Skipping terramate: most recent version 0.2.17 not installed
Warning: Skipping bridgecrewio/tap/yor: most recent version 0.1.171 not installed
Error: invalid byte sequence in UTF-8
Please report this issue:
  https://docs.brew.sh/Troubleshooting
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/cleanup.rb:535:in `match?'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/cleanup.rb:535:in `block (2 levels) in prune_prefix_symlinks_and_directories'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/vendor/portable-ruby/2.6.8_1/lib/ruby/2.6.0/pathname.rb:565:in `block in find'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/vendor/portable-ruby/2.6.8_1/lib/ruby/2.6.0/find.rb:49:in `block (2 levels) in find'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/vendor/portable-ruby/2.6.8_1/lib/ruby/2.6.0/find.rb:48:in `catch'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/vendor/portable-ruby/2.6.8_1/lib/ruby/2.6.0/find.rb:48:in `block in find'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/vendor/portable-ruby/2.6.8_1/lib/ruby/2.6.0/find.rb:43:in `each'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/vendor/portable-ruby/2.6.8_1/lib/ruby/2.6.0/find.rb:43:in `find'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/vendor/portable-ruby/2.6.8_1/lib/ruby/2.6.0/pathname.rb:565:in `find'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/cleanup.rb:531:in `block in prune_prefix_symlinks_and_directories'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/cleanup.rb:528:in `each'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/cleanup.rb:528:in `prune_prefix_symlinks_and_directories'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/cleanup.rb:243:in `clean!'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/cmd/cleanup.rb:58:in `cleanup'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/brew.rb:94:in `<main>'

What did you expect to happen?
brew cleanup to not through error
Step-by-step reproduction instructions (by running brew commands)
`brew cleanup`

Try to run brew cleanup --dry-run and it'll likely output Would remove (broken link): and then one of the paths for you to manually remove that's causing this error.

Thanks, I tried it and it didn't help =(
> brew cleanup --dry-run
Warning: Skipping (old) /home/linuxbrew/.linuxbrew/Cellar/autogen/5.18.16_2 due to it being linked
Warning: Skipping (old) /home/linuxbrew/.linuxbrew/Cellar/dive/0.10.0 due to it being linked
Warning: Skipping (old) /home/linuxbrew/.linuxbrew/Cellar/mesa-glu/9.0.2 due to it being linked
Warning: Skipping (old) /home/linuxbrew/.linuxbrew/Cellar/openjpeg/2.5.0 due to it being linked
Warning: Skipping bridgecrewio/tap/yor: most recent version 0.1.171 not installed
Error: invalid byte sequence in UTF-8
Please report this issue:
  https://docs.brew.sh/Troubleshooting
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/cleanup.rb:535:in `match?'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/cleanup.rb:535:in `block (2 levels) in prune_prefix_symlinks_and_directories'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/vendor/portable-ruby/2.6.8_1/lib/ruby/2.6.0/pathname.rb:565:in `block in find'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/vendor/portable-ruby/2.6.8_1/lib/ruby/2.6.0/find.rb:49:in `block (2 levels) in find'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/vendor/portable-ruby/2.6.8_1/lib/ruby/2.6.0/find.rb:48:in `catch'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/vendor/portable-ruby/2.6.8_1/lib/ruby/2.6.0/find.rb:48:in `block in find'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/vendor/portable-ruby/2.6.8_1/lib/ruby/2.6.0/find.rb:43:in `each'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/vendor/portable-ruby/2.6.8_1/lib/ruby/2.6.0/find.rb:43:in `find'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/vendor/portable-ruby/2.6.8_1/lib/ruby/2.6.0/pathname.rb:565:in `find'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/cleanup.rb:531:in `block in prune_prefix_symlinks_and_directories'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/cleanup.rb:528:in `each'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/cleanup.rb:528:in `prune_prefix_symlinks_and_directories'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/cleanup.rb:243:in `clean!'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/cmd/cleanup.rb:58:in `cleanup'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/brew.rb:94:in `<main>'

Adding a debug statement into cleanup.rb on line 535 helped though:
Would remove (broken link): /home/linuxbrew/.linuxbrew/lib/�

Not sure where this came from, though this also helped to reveal other garbage in this dir 😲
> LANG=C ll /home/linuxbrew/.linuxbrew/lib/ | less
total 311296
lrwxrwxrwx  1 root root    10 Oct 30 19:52 ^B -> libLLVM.so*
lrwxrwxrwx  1 root root    21 Oct 30 19:52 ^D -> libtextstyle.so.0.1.2*
lrwxrwxrwx  1 root root     9 Oct 30 19:52       -> libgts.so*
lrwxrwxrwx  1 root root    15 Oct 30 19:52
 -> libgvc.so.6.0.0*
lrwxrwxrwx  1 root root    19 Oct 30 19:52 ^K -> libsqlite3.so.0.8.6*
lrwxrwxrwx  1 root root    18 Oct 30 19:52 ^O -> libcgraph.so.6.0.0*
drwxrwx--- 18 yz   yz   69632 Apr  4 15:20 ./
drwx------ 14 yz   yz    4096 Nov 15  2020 ../
-rw-------  1 yz   yz       0 Nov 15  2020 .keepme
lrwxrwxrwx  1 root root    23 Oct 30 19:52 2.2.5 -> libgnutls-dane.so.0.4.1*
lrwxrwxrwx  1 root root    18 Oct 30 19:52 END__ -> libnetpbm.so.11.86*
lrwxrwxrwx  1 yz   yz      38 Mar 23 22:11 LLVMPolly.so -> ../Cellar/llvm/16.0.0/lib/LLVMPolly.so*
lrwxrwxrwx  1 yz   yz      37 Mar 23 22:11 LLVMgold.so -> ../Cellar/llvm/16.0.0/lib/LLVMgold.so*
lrwxrwxrwx  1 yz   yz      34 Sep 19  2022 Mcrt1.o -> ../Cellar/glibc/2.35_1/lib/Mcrt1.o*
lrwxrwxrwx  1 root root    17 Oct 30 19:52 Pk    -> libxml2.so.2.10.3*
lrwxrwxrwx  1 yz   yz      34 Sep 19  2022 Scrt1.o -> ../Cellar/glibc/2.35_1/lib/Scrt1.o*
lrwxrwxrwx  1 yz   yz      30 Feb  6 22:40 X11 -> ../Cellar/libx11/1.8.4/lib/X11/
lrwxrwxrwx  1 root root    16 Oct 30 19:52 _2.4 -> libbsd.so.0.11.7*
lrwxrwxrwx  1 root root    21 Oct 30 19:52 _ZN6gnutls7session7prf_rawEmPKcmS2_mPc -> libgnutlsxx.so.30.0.0*
lrwxrwxrwx  1 root root    10 Oct 30 19:52 _contPKcm -> libompd.so*
lrwxrwxrwx  1 root root    15 Oct 30 19:52 _msc_reply -> libEGL.so.1.0.0*
[snip line thhat look sane]
lrwxrwxrwx  1 root root    16 Oct 30 19:52 <B2>  -> libgxps.so.10.00

Am going to clean this garbage manually 🤔

Glad you're able to find it manually. Closing this because this will blow up all over Homebrew as it looks a lot like some sort of disk corruption.

Manual cleanup helped. Thanks @MikeMcQuaid
Yep, looks a power outage could lead to some files got corrupted back then.

The match?() at this line in cleanup.rb might probably need to be secured against "improper" chars though:
path.uninstall_info if path.to_s.match?(Keg::INFOFILE_RX) && !dry_run?

The match?() at this line in cleanup.rb might probably need to be secured against "improper" chars though:

I don't think so. This will blow up all over Homebrew. I'd like to see it affecting multiple users before I think it's worth handling.


Killed container still appeared to be running

Description of problem:
I run my irc client inside docker, and use it with docker attach. This morning when I ran the script, which should have attached the container, it hanged and didn't respond to Ctrl-L to refresh the display, and had to kill the docker client from another console. When doing a docker ps, it showed that the container was "Up 5 weeks" and had been created "5 weeks ago". Killing resulted in an error that clearly didn't have anything to do with it (it mentioned TLS). A quick ps auwx did not show any irssi process.
It was the only container running on the system, so I rebooted the machine. After the reboot I did a quick docker ps - and to my surprise the container still appeared to be "Up 5 weeks", but ps still didn't show any irssi process.
To fix this, I stopped the docker daemon, edited the /var/lib/docker/containers/<id>/config.json and set the running to false and restarted the daemon.
I have no idea how to reproduce it, but it seems some extra validation checks might be needed before assuming a container is running and not just relying on the config.json.
docker version:
Client:
Version:      1.8.1
API version:  1.20
Go version:   go1.4.2
Git commit:   d12ea79
Built:        Thu Aug 13 02:35:49 UTC 2015
OS/Arch:      linux/amd64
Server:
Version:      1.8.1
API version:  1.20
Go version:   go1.4.2
Git commit:   d12ea79
Built:        Thu Aug 13 02:35:49 UTC 2015
OS/Arch:      linux/amd64
docker info:
Containers: 12
Images: 170
Storage Driver: aufs
Root Dir: /var/lib/docker/aufs
Backing Filesystem: extfs
Dirs: 194
Dirperm1 Supported: false
Execution Driver: native-0.2
Logging Driver: json-file
Kernel Version: 3.13.0-62-generic
Operating System: Ubuntu 14.04.3 LTS
CPUs: 1
Total Memory: 3.861 GiB
Name: koffie
ID: 6QXR:2KPJ:R4LD:RO26:LR4S:MX4V:QHAI:BFLR:RXNZ:JFZJ:HBTV:PDZD
Username: bartmeuris
Registry: https://index.docker.io/v1/
uname -a:
Linux koffie 3.13.0-62-generic #102-Ubuntu SMP Tue Aug 11 14:29:36 UTC 2015 x86_64 x86_64 x86_64 GNU/Linux
Environment details (AWS, VirtualBox, physical, etc.):
VM running on VMWare ESX
Steps to reproduce:

Haven't been able to reproduce

Actual Results:
Container not attaching, container process not running, docker still showing the container as "Up"
Expected Results:
Docker not showing the container as running
Additional info:
Dockerfile and script to start/attach container here: https://gist.github.com/bartmeuris/ed6a45f9c4d0216649b8

Hi!
Please read this important information about creating issues.
If you are reporting a new issue, make sure that we do not have any duplicates already open. You can ensure this by searching the issue list for this repository. If there is a duplicate, please close your issue and add a comment to the existing issue instead.
If you suspect your issue is a bug, please edit your issue description to include the BUG REPORT INFORMATION shown below. If you fail to provide this information within 7 days, we cannot debug your issue and will close it. We will, however, reopen it if you later provide the information.
This is an automated, informational response.
Thank you.
For more information about reporting issues, see https://github.com/docker/docker/blob/master/CONTRIBUTING.md#reporting-other-issues

BUG REPORT INFORMATION
Use the commands below to provide key information from your environment:
docker version:
docker info:
uname -a:
Provide additional environment details (AWS, VirtualBox, physical, etc.):
List the steps to reproduce the issue:
1.
2.
3.
Describe the results you received:
Describe the results you expected:
Provide additional info you think is important:
----------END REPORT ---------
#ENEEDMOREINFO

ping @coolljt0725 I think some improvements were made in this, or am I mistaken?

The PR fixed this is not in 1.8.1

To fix this, I stopped the docker daemon, edited the /var/lib/docker/containers//config.json and set the running to false and restarted the daemon.

is the right approach

@coolljt0725 is the fix in master / 1.9? I couldn't find the PR :relaxed:

@thaJeztah  #15748 #16275 is going to fix this.
In normal, daemon will set the running to false if detect the container has a state running=true on container registering when daemon starting, but sometimes registering failed before set the running to false and returned left with the container has a state running=true.

Thanks @coolljt0725, those changes will be in docker 1.9.
@bartmeuris as commented above, docker 1.9 will have fixes to prevent this situation. I'm going to go ahead and close this issue, but feel free to comment here after I've closed this issue! thanks!


OJ-38960: refactor agent to use feature flags and grab redownloaded i…

Description
Previously, the Agent wasn't taking in feature flags related to JF Ingest. Now, we read the feature flags via the API. Additionally, we now also get the list of issues IDs that need redownloading (which is needed for the "new sync path" in JF Ingest)
Testing
To test, I ran an Agent run with the new code. I verified we use the new sync path and that we properly redownload issues marked for redownload (I manually marked one issue for redownload)
➜  jf_agent git:(OJ-38960-check-feature-flags-and-get-redownloaded-issue-ids) ✗ pdm run jf_agent/main.py -e ./creds.env --jellyfish-api-base http://localhost:8000
2024-10-01 18:24:04 [info    ] Logging setup complete with handlers for log file, stdout, and streaming.
2024-10-01 18:24:24 [info    ] Will write output files into ./output/20241001_182404
2024-10-01 18:24:24 [info    ] Running ingestion healthcheck validation!
2024-10-01 18:24:24 [info    ] Validating configuration...

Jira details:
  URL:      https://jelly-ai.atlassian.net
  Username<EMAIL_ADDRESS>  Password: **********
2024-10-01 18:24:24 [info    ] ==> Testing Jira connection...
2024-10-01 18:24:24 [info    ] Authenticating to Jira API at https://jelly-ai.atlassian.net using the username and password secrets for<EMAIL_ADDRESS>of company orthogonal-networks
2024-10-01 18:24:25 [info    ] ==> Getting Jira version...
2024-10-01 18:24:25 [info    ] Found Jira version as 1001.0.0-SNAPSHOT
2024-10-01 18:24:25 [info    ] ==> Getting Jira deployment type...
2024-10-01 18:24:25 [info    ] Response headers does not contain X-ANODEID! Customer is NOT running Jira Data Center.
2024-10-01 18:24:25 [info    ] ==> Getting Jira permissions...
2024-10-01 18:24:25 [info    ] Found granted permissions as ['DELETE_OWN_WORKLOGS', 'CREATE_ISSUES', 'WORK_ON_ISSUES', 'DELETE_OWN_COMMENTS', 'MODIFY_REPORTER', 'EDIT_ISSUES', 'ADD_COMMENTS', 'EDIT_OWN_COMMENTS', 'ASSIGN_ISSUES', 'BROWSE_PROJECTS', 'EDIT_OWN_WORKLOGS', 'EDIT_ALL_WORKLOGS', 'EDIT_ALL_COMMENTS', 'CLOSE_ISSUES', 'SET_ISSUE_SECURITY', 'SCHEDULE_ISSUES', 'USER_PICKER', 'DELETE_ALL_COMMENTS', 'ADMINISTER_PROJECTS', 'RESOLVE_ISSUES', 'DELETE_ISSUES', 'VIEW_READONLY_WORKFLOW', 'MOVE_ISSUES', 'TRANSITION_ISSUES', 'ASSIGNABLE_USER', 'LINK_ISSUES', 'DELETE_ALL_WORKLOGS']
2024-10-01 18:24:25 [info    ] ==> Testing Jira user browsing permissions...
2024-10-01 18:24:25 [info    ] Downloading Users...
2024-10-01 18:24:26 [info    ] Done downloading Users! Found 533 users
2024-10-01 18:24:26 [info    ] We can access 533 Jira users.
2024-10-01 18:24:26 [info    ] ==> Testing Jira project permissions...
2024-10-01 18:24:26 [info    ] With provided credentials, the following projects are discoverable: {'JFR', 'OJ'}.
Checking project access.
2024-10-01 18:24:26 [info    ] Testing access for project: "JFR"
2024-10-01 18:24:27 [info    ] With provided credentials, we can access issues, versions, and components within project JFR
2024-10-01 18:24:27 [info    ] Testing access for project: "OJ"
2024-10-01 18:24:28 [info    ] With provided credentials, we can access issues, versions, and components within project OJ
2024-10-01 18:24:28 [info    ] Checking access to fields
2024-10-01 18:24:28 [info    ] Checking access to resolutions
2024-10-01 18:24:28 [info    ] Checking access to issue types
2024-10-01 18:24:29 [info    ] Checking access to issue link types
2024-10-01 18:24:29 [info    ] Checking access to priorities
2024-10-01 18:24:29 [info    ] Checking access to boards
2024-10-01 18:24:29 [info    ] Checking access to sprints
2024-10-01 18:24:41 [info    ] . Skipping Git Validation.

Memory & Disk Usage:
  Available memory: 829.41 MB
  Disk usage for jf_agent/output: 295 GB / 460 GB
  Size of jf_agent/output dir:  20K
2024-10-01 18:24:41 [info    ] Attempting to upload healthcheck result to s3...
2024-10-01 18:24:42 [info    ] Successfully uploaded healthcheck.json
2024-10-01 18:24:42 [info    ] Successfully uploaded jf_agent.log
2024-10-01 18:24:42 [info    ] Successfully uploaded healthcheck result to s3!
2024-10-01 18:24:42 [info    ]
Done
2024-10-01 18:24:43 [info    ] Obtained Jira configuration, attempting download...
2024-10-01 18:24:43 [info    ] Attempting to use JF Ingest for Jira Ingestion
Set global value INGESTION_TYPE to AGENT
2024-10-01 18:24:43 [info    ] Beginning load_and_push_jira_to_s3
2024-10-01 18:24:43 [info    ] Using local version of ingest
2024-10-01 18:24:43 [info    ] Authenticating to Jira API at https://jelly-ai.atlassian.net using the username and password secrets for<EMAIL_ADDRESS>of company orthogonal-networks
2024-10-01 18:24:43 [info    ] Data will not be saved locally
2024-10-01 18:24:43 [info    ] Data will be submitted to jellyfish
2024-10-01 18:24:43 [info    ] Downloading Jira Projects...
2024-10-01 18:24:43 [info    ] Done downloading Projects!
2024-10-01 18:24:43 [info    ] Downloading Jira Project Components...
2024-10-01 18:24:44 [info    ] Done downloading Project Components!
2024-10-01 18:24:44 [info    ] Downloading Jira Versions...
2024-10-01 18:24:44 [info    ] Done downloading Jira Versions!
2024-10-01 18:24:44 [info    ] Done downloading Jira Project, Components, and Version. Found 2 projects
2024-10-01 18:24:45 [info    ] Downloading Jira Fields...
2024-10-01 18:24:45 [info    ] Done downloading Jira Fields! Found 230 fields
2024-10-01 18:24:46 [info    ] Downloading Users...
2024-10-01 18:24:46 [info    ] Done downloading Users! Found 533 users
2024-10-01 18:24:47 [info    ] Downloading Jira Resolutions...
2024-10-01 18:24:47 [info    ] Done downloading Jira Resolutions! Found 9 resolutions
2024-10-01 18:24:48 [info    ] Downloading IssueTypes...
2024-10-01 18:24:48 [info    ] Done downloading IssueTypes! found 34 Issue Types
2024-10-01 18:24:48 [info    ] Downloading IssueLinkTypes...
2024-10-01 18:24:48 [info    ] Done downloading IssueLinkTypes! Found 10 Issue Link Types
2024-10-01 18:24:49 [info    ] Downloading Jira Priorities...
2024-10-01 18:24:49 [info    ] Done downloading Jira Priorities! Found 5 priorities
2024-10-01 18:24:49 [info    ] Downloading Jira Statuses...
2024-10-01 18:24:50 [info    ] Done downloading Jira Statuses! Found 129
2024-10-01 18:24:50 [info    ] Downloading Boards...
2024-10-01 18:24:51 [info    ] Done downloading Boards! Found 62 boards
2024-10-01 18:24:56 [info    ] Using 100 as batch size for issue downloads. Full Redownload is False
2024-10-01 18:24:56 [info    ] Processing projects and issues from remote
2024-10-01 18:24:56 [info    ] Fetching list of all jira issue ID/key from remote to match local
Getting total issue counts for 2 projects (Thread Count: 10): 100%|████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████| 2/2 [00:00<00:00,  2.73it/s]
2024-10-01 18:25:08 [info    ] 61734 issues local, 39451 issues remote, 22385 issues deleted
2024-10-01 18:25:08 [info    ] 0 issues have been detected as being rekeyed. These will be redownloaded
2024-10-01 18:25:08 [info    ] 102 issues found on remote not found on local. These will be downloaded.
2024-10-01 18:25:08 [info    ] Attempting to pull all the full Jira Issues that have been updated since our last Jira Download across 2 projects.
Getting total issue counts for 2 projects (Thread Count: 10): 100%|████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████| 2/2 [00:00<00:00,  6.13it/s]
Pulling issue data across 2 projects by Date (Thread Count: 10): 100%|█████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████| 350/350 [00:07<00:00, 45.67it/s]
2024-10-01 18:25:17 [info    ] Successfully saved 350 Jira Issues in 1 separate batches, with each batch limited to 50MB per batch
2024-10-01 18:25:17 [info    ] We have downloaded 350 issues that have been updated or created since our last pull across 2 projects.
Pulling issue data for 1 Jira Issue IDs (Thread Count: 10): 100%|██████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████| 1/1 [00:00<00:00,  1.31it/s]
2024-10-01 18:25:19 [info    ] Successfully saved 1 Jira Issues in 1 separate batches, with each batch limited to 50MB per batch
2024-10-01 18:25:19 [info    ] 22385 issues have been detected as being deleted
2024-10-01 18:25:20 [info    ] Downloading Jira Worklogs...
2024-10-01 18:25:20 [info    ] Fetching updated worklogs
2024-10-01 18:25:21 [info    ] Done fetching updated worklogs
2024-10-01 18:25:21 [info    ] Fetching deleted worklogs
2024-10-01 18:25:21 [info    ] Done fetching deleted worklogs
2024-10-01 18:25:21 [info    ] Done downloading Worklogs! Found 0 worklogs and 0 deleted worklogs
2024-10-01 18:25:21 [info    ] Data has not been saved locally, because save_locally was set to false in the ingest config!
2024-10-01 18:25:21 [info    ] Data has been submitted to jellyfish
2024-10-01 18:25:21 [info    ] Shutting down Systems Diagnostics Thread
2024-10-01 18:25:21 [info    ] Closing Diagnostics file
2024-10-01 18:25:21 [info    ] Compressing ./output/20241001_182404/diagnostics.json
2024-10-01 18:25:21 [info    ] Compressing ./output/20241001_182404/healthcheck.json
2024-10-01 18:25:21 [info    ] Sending data to Jellyfish...
2024-10-01 18:25:22 [info    ] Starting 3 threads
2024-10-01 18:25:22 [info    ] Successfully uploaded healthcheck.json.gz
2024-10-01 18:25:22 [info    ] Successfully uploaded diagnostics.json.gz
2024-10-01 18:25:22 [info    ] Successfully uploaded status.json.gz
2024-10-01 18:25:23 [info    ] Successfully uploaded config.yml
2024-10-01 18:25:23 [info    ] Agent run succeeded: True
2024-10-01 18:25:23 [info    ] Successfully uploaded jf_agent.log
2024-10-01 18:25:24 [info    ] Successfully uploaded .done
2024-10-01 18:25:24 [info    ] Done!
2024-10-01 18:25:24 [info    ] Closing the agent log stream.
2024-10-01 18:25:24 [info    ] Log stream stopped.

Any risk here to turn it on immediately for all agent customers?
(we've done a gradual rollout for DC customers)

I don't think so, we're running this for all customers in Direct Connect (and we have for several months now) without issue. Direct Connect reflects what we generally see in the Agent (we have Jira Server, Jira Cloud, and Jira Data Center customers in D.C., just like we do for Agent). After merge we should pay attention to any Agent monitoring we have just to be extra sure though


Django Q and Django secret key documentation fixes.

Excellent work on the docker file.
I would add the following in the documentation of the workers.
All workers and servers need the same DJANGO_SECRET_KEY, otherwise the workers will not work correctly.  Hit that in development a ways back.  It's a subtle bug that will trip people up.  (especially if they decide to run 2 servers for high availability)
Also I would add documentation on docker hub so that people understand exactly what their docker compose needs to look like.
See the following as an example:
https://hub.docker.com/r/linuxserver/plex
You don't probably have to be that detailed, but a good docker compose file there would be nice.

This has now been fixed in the docs - thanks for pointing this out.


Make it easy to disable Immutable***Rules

Describe the bug
We currently do not have a way to disable these rules as we do not use guava on our codebase. Is there a way to disable these globaly without using annotations SuppressWarnings(...). An example that triggers the warning.
var array  = List.of(....)

Thanks for reaching out!
Yes we definitely provide a way to disable specific Refaster rules. Using a regex one can restrict which Refaster rules will be loaded. For some extra context, see the explanation in Refaster.java.
Let me provide a solution for which I verified with that your provided example is not flagged anymore.
Please add this to your Error Prone configuration in the pom.xml:
-XepOpt:Refaster:NamePattern=^(?!(Immutable.*Rules)).*

This enables all rules except for the rule collections that match Immutable.*Rules.
Does this help you @atkawa7 ?

Thanks @rickie. That solved the issue. Closing this

First off: congrats @atkawa7 on opening the very first issue in this repository :smile:.
For others landing here: we are aware that we can do better in this respect:

For BugCheckers other than Refaster we have #308, which should prevent Error Prone Support (by default) from introducing a dependency on libraries not already on the classpath. The plan is to do something similar for the Refaster check (but that'll require a significantly different approach; details TBD).
We should also better document -XepOpt:Refaster:NamePattern and other custom flags :)

I'll link the relevant PRs here if/when they land.


Configuration property description should not contain Javadoc tags

Thank you for your work on the starter.
As documented in the reference guide, field javadoc for @ConfigurationProperties-annotated type should not contain javadoc tags as those aren't processed by the annotation processor.
Please change that to be a succinct description rather and move the more detailed description to the README or some reference guide.

Thank you for your reminder, I will move the description to the java documentation of the class in the next release.


Thanks so much for packaging. Everything deploys for the private preview from GH except the workbook which seems to be erroring in Commerical and GOV. Would it be possible to double check the ./maintemplate.json? Also wondering if its possible to remove the timestamp from the workbook name, please let me know your thoughts.
@.***
Very Respectfully,
TJ Banasik
CISSP-ISSEP,ISSAP,ISSMP
Senior Program Manager
C&AI, Sovereign Cloud Security Group
<EMAIL_ADDRESS>(202) 658-8148
@.***
LinkedIn: In/tjbanasikhttps://nam06.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww.linkedin.com%2Fin%2Ftjbanasik&data=04|01|Thomas.Banasik%40microsoft.com|cea4ba8bab0143dc382c08d9fb3f7105|72f988bf86f141af91ab2d7cd011db47|1|0|637817072214651810|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000&sdata=v%2FT19nBVWI0yZhFwx5p7RaxjaBIzgSM%2FK0EiQjOPw04%3D&reserved=0
From: Nikhil Tripathi (TATA CONSULTANCY SERVICES LTD<EMAIL_ADDRESS>Sent: Thursday, February 24, 2022 1:41 PM
To: TJ Banasik<EMAIL_ADDRESS>Azure/Azure-Sentinel<EMAIL_ADDRESS>Ajeet Prakash (MSTIC<EMAIL_ADDRESS>Lior Tamir<EMAIL_ADDRESS>Ashwin Patil<EMAIL_ADDRESS>Sapan Goel<EMAIL_ADDRESS>Subject: RE: [Azure/Azure-Sentinel] NISTSP80053 Solution (PR #3992)
Hi,
The solution package has been updated in both GitHub and the partner center. We don't need to push it live because it's a private preview through GitHub, according to @TJ @.***>.
Thanks.
All the best,
-Nikhil Tripathi (TATA CONSULTANCY SERVICES LTD)
From: TJ Banasik<EMAIL_ADDRESS>Sent: Thursday, February 24, 2022 1:13 AM
To: Azure/Azure-Sentinel<EMAIL_ADDRESS>Ajeet Prakash (MSTIC<EMAIL_ADDRESS>Lior Tamir<EMAIL_ADDRESS>Ashwin Patil<EMAIL_ADDRESS>Nikhil Tripathi (TATA CONSULTANCY SERVICES LTD<EMAIL_ADDRESS>Sapan Goel<EMAIL_ADDRESS>Subject: RE: [Azure/Azure-Sentinel] NISTSP80053 Solution (PR #3992)
@Nikhil Tripathi (TATA CONSULTANCY SERVICES @.***>,
We have the approvals, would it be possible to merge and post to GH for Private Previews?
@Ajeet Prakash @.> & @Lior @.>,
Thanks so much for the review/approvals
Very Respectfully,
TJ Banasik
CISSP-ISSEP,ISSAP,ISSMP
Senior Program Manager
C&AI, Sovereign Cloud Security Group
<EMAIL_ADDRESS>(202) 658-8148
@.***
LinkedIn: In/tjbanasikhttps://nam06.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww.linkedin.com%2Fin%2Ftjbanasik&data=04|01|Thomas.Banasik%40microsoft.com|cea4ba8bab0143dc382c08d9fb3f7105|72f988bf86f141af91ab2d7cd011db47|1|0|637817072214701803|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000&sdata=i1htpxcq5lEo4zebWJzvze3D4hp91tysZrXiG1CLXko%3D&reserved=0
From: TJ Banasik
Sent: Tuesday, February 22, 2022 8:26 AM
To: Azure/Azure-Sentinel<EMAIL_ADDRESS>Ajeet Prakash (MSTIC<EMAIL_ADDRESS>Lior Tamir<EMAIL_ADDRESS>Ashwin Patil<EMAIL_ADDRESS>Subject: RE: [Azure/Azure-Sentinel] NISTSP80053 Solution (PR #3992)
@Lior @.***>,
Would it be possible to approve this PR. The playbooks are slightly modified versions of the 3 playbooks we've included in previous compliance solutions (Notify, ADO Ticket, JIRA Ticket)?
@Ajeet Prakash @.> & @Ashwin @.>
Would it be possible to approve the analytics rule? Same structure as our rules for Zero Trust, CMMC which leverages SecurityRegulatoryCompliance assessments. Please let me know your thoughts.
Very Respectfully,
TJ Banasik
CISSP-ISSEP,ISSAP,ISSMP
Senior Program Manager
C&AI, Sovereign Cloud Security Group
<EMAIL_ADDRESS>(202) 658-8148
@.***
LinkedIn: In/tjbanasikhttps://nam06.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww.linkedin.com%2Fin%2Ftjbanasik&data=04|01|Thomas.Banasik%40microsoft.com|cea4ba8bab0143dc382c08d9fb3f7105|72f988bf86f141af91ab2d7cd011db47|1|0|637817072214701803|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000&sdata=i1htpxcq5lEo4zebWJzvze3D4hp91tysZrXiG1CLXko%3D&reserved=0
From: NikTripathi<EMAIL_ADDRESS>Sent: Monday, February 21, 2022 12:56 PM
To: Azure/Azure-Sentinel<EMAIL_ADDRESS>Cc: TJ Banasik<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Subject: Re: [Azure/Azure-Sentinel] NISTSP80053 Solution (PR #3992)
@NikTripathi approved this pull request.
Workbook looks good. Can merge once analytic and playbooks approved.

Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FAzure%2FAzure-Sentinel%2Fpull%2F3992%23pullrequestreview-888983550&data=04|01|Thomas.Banasik%40microsoft.com|cea4ba8bab0143dc382c08d9fb3f7105|72f988bf86f141af91ab2d7cd011db47|1|0|637817072214701803|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000&sdata=ZDekiHxDRv1x4MJl728lwMgWL1HlXTFh4lTlwTR%2B5jw%3D&reserved=0, or unsubscribehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAM6PRES4XXQCWFNSZBNT7E3U4J4E3ANCNFSM5MWADRCA&data=04|01|Thomas.Banasik%40microsoft.com|cea4ba8bab0143dc382c08d9fb3f7105|72f988bf86f141af91ab2d7cd011db47|1|0|637817072214701803|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000&sdata=%2FxcUIgJ9EW8CTgwVVRbI5N3gIxy1czLznBAaLLhU4m4%3D&reserved=0.
Triage notifications on the go with GitHub Mobile for iOShttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fapps.apple.com%2Fapp%2Fapple-store%2Fid1477376905%3Fct%3Dnotification-email%26mt%3D8%26pt%3D524675&data=04|01|Thomas.Banasik%40microsoft.com|cea4ba8bab0143dc382c08d9fb3f7105|72f988bf86f141af91ab2d7cd011db47|1|0|637817072214701803|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000&sdata=8F5M4dMTKyvGFjPf1CUGYcN%2B3oanQ1zeJpwzCcVkQcg%3D&reserved=0 or Androidhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fplay.google.com%2Fstore%2Fapps%2Fdetails%3Fid%3Dcom.github.android%26referrer%3Dutm_campaign%253Dnotification-email%2526utm_medium%253Demail%2526utm_source%253Dgithub&data=04|01|Thomas.Banasik%40microsoft.com|cea4ba8bab0143dc382c08d9fb3f7105|72f988bf86f141af91ab2d7cd011db47|1|0|637817072214701803|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000&sdata=7dh2EYgRDdKAOlJ%2BvqkgCQhaDJHh%2F5TK5%2FfAI%2BEsAJs%3D&reserved=0.
You are receiving this because you authored the thread.Message ID<EMAIL_ADDRESS>


Add propertypairs from the 20190311 dump

I don’t want to push this directly to master because the file looks a bit unusual. It seems like previous dumps all start with P31 and P279:
$ gunzip < 20181008/wbs_propertypairs.csv.gz | head
pid1,qid1,pid2,count,probability,context
31,945532,18,1,1.0,item
31,945532,373,1,1.0,item
279,24775422,527,1,0.5,item
279,24775422,2926,2,1.0,item
279,24775422,31,2,1.0,item
279,11429,3417,1,1.0,item
31,451752,227,1,0.3333333333333333,item
31,451752,131,1,0.3333333333333333,item
31,451752,646,3,1.0,item

This one, on the other hand, starts with P4804:
$ gunzip < 20190311/wbs_propertypairs.csv.gz | head
pid1,qid1,pid2,count,probability,context
4804,,1038,8,0.012965964343598054,item
4804,,3599,13,0.02106969205834684,item
4804,,18,168,0.27228525121555913,item
4804,,19,572,0.9270664505672609,item
4804,,20,502,0.813614262560778,item
4804,,21,614,0.9951377633711507,item
4804,,22,24,0.03889789303079417,item
4804,,25,7,0.011345218800648298,item
4804,,26,26,0.04213938411669368,item

@mariushoch is that an issue? (For now, I’ll prepare the update on mwmaint1002 but stop before updating the actual table.)

(It could be due to an underlying Python change – for example, IIRC this might be the first dump that was processed on a Python where ordinary dicts preserve ordering.)

I don't think this is very worrying… as long as the total number of lines/rows in the file hasn't decreased, I wouldn't suspect any problems.

 Let’s deploy this.


Enable CI testing for OpenGL

Motivation

In order to allow quicker and safer development of OpenGL features, some tests should be implemented. Currently, there is exactly one test (a circle test) but the goal is to figure out all the changes that are necessary to run tests.
Overview / Explanation for Changes

Implement get_frame to return a Numpy array of pixel data so that OpenGL renders can consistent in the testing rig.
Produce a very simple scene to test that OpenGL testing can work.
Enable tests to specify an RGB-space tolerance value.
Add xvfb to the Linux CI checker
Use MSYS2 in the Windows CI checker, and tell Python to add the DLL when using NT in the CI.
GraphicalUnitTest now checks the use_opengl_renderer flag
Refactor the GraphicalUnitTest argument named "scene_object" to "scene_class" because it's actually a class, not instantiated yet.

Testing Status

Works on my laptop (Ubuntu 18.04.5).
Further Comments

Acknowledgements

[x] I have read the Contributing Guidelines
[x] I have chosen a descriptive PR title (see top of PR template for examples)

Reviewer Checklist

[ ] Newly added functions/classes are either private or have a docstring
[ ] Newly added functions/classes have tests added and (optional) examples in the docs
[ ] Newly added documentation builds, looks correctly formatted, and adds no additional build warnings
[ ] The PR title is descriptive enough

So here's the status:
Ubuntu needs something like an xvfb to run
Windows also has a OpenGL error
Mac runs, but it renders slightly differently from Ubuntu, on which I made the test.
Looks like this is another issue with cross-platform differences...

ps. ignore the force pushes testing things whether it works on windows

OH LOL tests passed

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@e4d539f). Click here to learn what that means.
The diff coverage is n/a.

:exclamation: Current head a4b18b4 differs from pull request most recent head 5ee549d. Consider uploading reports for the commit 5ee549d to get more accurate results

@@            Coverage Diff            @@
##             master    #1160   +/-   ##
=========================================
  Coverage          ?   59.40%
=========================================
  Files             ?      109
  Lines             ?    14952
  Branches          ?        0
=========================================
  Hits              ?     8882
  Misses            ?     6070
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e4d539f...5ee549d. Read the comment docs.

Windows build is broken now... I'll submit a review with changes requested.

Fixed it :)

Once @behackl gives an approve this can be merged, and then think about adding more tests.

Is it documented anywhere how to generate test data for OpenGL scenes? I'm not sure how to pass the use_opengl_renderer flag to template_generate_graphical_units_data.py.

I've been kludging using something like:
from wherever import set_test_scene

with tempconfig({"use_opengl_renderer": True}):
    set_test_scene(CircleTest, "opengl")

just right in the test file, and remembering to delete it right afterwards.
I think there's a better way to do it, but I only discovered the wiki about testing after I had dug around in the code for set_test_scene for the SVG PR, and I haven't learned the right way.
All in all to say that you may need to implement the flag yourself.


question about the validate

After processing the data as you say at https://github.com/Jieqianyu/SSC-RS/issues/2#issuecomment-1645249137,
I got the following result.

But when I run the validate.py,
I got the issue

According to the dataset file structure, I delete the 'replace('voxels', 'velodyne')' and run again.
This time  I got the new issue,

Same as the previous operation, I delete the 'replace ('voxel', 'labels') and run again.
This time I got the new issue too,

These issues seem all connected with semantic_kitti.py.
I wish you could help me to solve these issues.
Thank you so much.

I found the reason that I don't have the velodyne and labels.
So the changes above are wrong.
I will check the data and find out how to get velodyne and labels.


Add more error handling to restapi

This PR adds a little more error handling to the restapi.

TGTM, and probably long overdue


Modify --link arg and README (Cdr Cloud)

Correct me if I'm wrong, but I assume it is not in alpha anymore. Is it in beta or is it released?

Correct me if I'm wrong, but I assume it is not in alpha anymore. Is it in beta or is it released?

I'm not personally sure. cc @sreya

Thanks for contributing @JammSpread

❤


⚠ Bofrost.de has degraded performance

In e04c791, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 791 ms

Resolved: Bofrost.de performance has improved in afaa40c after 6 minutes.


Add custom styling to Questions page

https://github.com/sopra-fs23-group-39/sopra-client/commit/0767e84bb4e0e19d2b69983ebc320888b38656ad


Unsubscribe

Is there a way to unsubscribe or reset a ddp subscription?
Need to be able to change subscription to fetch a specific collection depending on the selected country.

The build in unsubscribe method is broken. Use this implementation instead:
    public void fixedUnsubscribe(final String subId, final String name)
    {
        Timber.d("Unsubscribing from %s with subId: %s", name, subId);

        if ((subId == null) || (name == null))
        {
            Timber.d("Cannot unsubscribe if subId or name is not specified.");
            return;
        }

        final Map<String, Object> unsubMsg = new HashMap<>();
        unsubMsg.put(DDPClient.DdpMessageField.MSG, DDPClient.DdpMessageType.UNSUB);
        unsubMsg.put(DDPClient.DdpMessageField.NAME, name);
        unsubMsg.put(DDPClient.DdpMessageField.ID, subId);
        getDDP().send(unsubMsg);
    }

This is actually a bug in the java-ddp-client library.  Added a method that takes an integer ID to the unsubscribe method for version <IP_ADDRESS>


MTV: Adding PLAN_FAILED condition message

Short description:
More details:
What this PR does / why we need it:
Which issue(s) this PR fixes:
Special notes for reviewer:
Bug:

/verified

/approve


Use colors of original LineUp

Coming from https://github.com/Caleydo/lineupjs/issues/65 and https://github.com/Caleydo/lineup/issues/7
I don't where to find the original color scale other than this paper figure:

why should we use these colors?

Nostalgia. :)


Post and Put Request Exception

In Base.php line 194:  Undefined offset: -72 error occurred,
While FormRequest for parameter validation on some of API's.
Want to generate docs but the not generate all api docs, FormRequest work fine but not for all, some of POST and PUT request make error "Undefined offset: -72 error occurred"
if anyone familiar with this error please help me to resolve it.
Thanks in advance

This project is dead

@tarreislam
thanks for reply, can you please specify any other solution to resolve this issue.


Ambassador Edge Stack UI shows "Configuration Error" when using TLSContext and Host together

Describe the bug
By the time of writing, it is not possible to configure http2 within a Host CRD in ambassador on kubernetes. The required option would be something like the alpn_protocols (then set to h2 for http2) option of the TLSContext CRD. But the Host CRD is needed for acme certificates.
The problem is, when someone wants to connect to a service through ambassador with a grpc service, and the option above is not configured, the call will be downgraded to http1.1. This can either made working by setting and enabling the grpc_11_bridge or by just using unary non streaming calls.
After some conversation with @nbkrause he suggested to use the workaround and create a Host for the acme process to get the certificate and a TLSContext for the protocol definition.
When doing this, it produces the correct envoy configuration but the Edge Stack UI yells an error at me:

It does seem to work as intended, but the ui still produces this error.
To Reproduce
Steps to reproduce the behavior:

Create a Host CRD with some hostname (for acme - lets encrypt - certificates)
Create a TLSContext CRD with the same hostname (for alpn_protocols: h2)
See the error in the edge stack ui under "debugging" (and the logs of course)

Expected behavior
Either allow the host to define the protocols, or don't throw errors when a tlscontext uses the same hostnames to define additional properties :-)
Versions (please complete the following information):

Ambassador: 1.0.0
Kubernetes environment: bare metal
Version 1.17.0

I'm experiencing a similar issue when trying to use a Host CRD to take advantage of the LetsEncrypt automation, but also trying to lock down the min_tls_version to v1.2 which is required to get an "A" score on SSLabs (https://www.ssllabs.com/). The min_tls_version directive is set in a TLSContext, but doesn't appear to be getting read (verifiable with curl --tlsv1.1 still passing).
Once I move the entire TLS configuration over to the TLSContext, including secrets, and then set ACME to 'none', it starts honouring the min_tls_version setting, but then I've lost certificate renewals via LetsEncrypt.
It doesn't seem possible to use both a Host CRD to automate LetsEncrypt, and also use a TLSContext for additional configuration such as min_tls_version, which is implied in the doc. Unless I'm missing something (which is possible - and someone please let me know if they have this working).

Same here

some could say we see the same 😁

+1 this is frusterating

@HunterLarco meanwhile...
I guess the did some implementation on this topic, but did not mention it.
Sadly enough it's a "naming convention" thingy:
https://www.getambassador.io/docs/latest/topics/running/tls/#hostand-tlscontext
So, I tested it.
If you use a host with the name foobar-host and then use the context with the name foobar-host-context, the error is gone and everything is correctly configured.
Thanks to @conblem for the nudge into the right direction.
But I wonder if the ambassador devs are changing something on this matter?
/cc @fforootd


Load declarations for dynamic imports

Suggestion
⭐ Suggestion
Now the typescript import declaration files only from node_modules.
I also suggest importing declaration files for dynamic imports.
📃 Motivating Example
In the current version of the typescript, the widget will have the type any.
After the implementation of this feature, the widget must have a type from declarations, check types, and help the developer write code.
const widget = await import("https://some-site/widget-microfront.esnext.min.js");
widget.render(this.microfontElement, {app: {serverUrl: location.origin}});

💻 Use Cases
Development of distributed microfrontends.
This feature will allow you to make much larger distributed applications.
✅ Viability Checklist
My suggestion meets these guidelines:

[ ] This wouldn't be a breaking change in existing TypeScript/JavaScript code
[ ] This wouldn't change the runtime behavior of existing JavaScript code
[ ] This could be implemented without emitting different JS based on the types of the expressions
[ ] This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, new syntax sugar for JS, etc.)
[ ] This feature would agree with the rest of TypeScript's Design Goals.

This sounds like #24550.

#24550 specifically mentions dynamic import from a domain in the OP, just like this issue.

Then it sounds like #35749.


Tests broken

Emmm, not sure in this PR, made it bacause it failes https://app.travis-ci.com/github/AlphaWallet/alpha-wallet-ios/jobs/558375338 for https://github.com/AlphaWallet/alpha-wallet-ios/pull/3777


Add Sound

Background music

Title screen
Character Select
Combat (separate BGM for victory/loss?)

Sound effects

Menu navigation
Monster attacks
Hit and dodge

Background music is done and there is #38 for UI sounds. Will create a new issue for combat SFX.


Added script to check for username not starting with alphabets.

Closes: #1
Fixes #<issue_number_goes_here>

It's a good idea to open an issue first for discussion.

[ ] Tests pass
[ ] Appropriate changes to README are included in PR

@googlebot I signed it!


hugo serve won't render fonts

When I use hugo serve -w, it show different result from hugo which accessed locally. When I build my website, fonts are correctly rendered. But hugo serve -w won't render my fonts, it only show default fonts.
I'm using google fonts by
<link href="https://fonts.googleapis.com/css?family=Noto+Sans|Noto+Serif|Source+Code+Pro" rel="stylesheet">

Please use http://discuss.gohugo.io/ for questions/troubleshooting. Also see  Hugo Documentation.

Have you checked your browser console for errors? This isn't much to go off of and might

@rdwatters please keep the questions on the forum.

We must have crossed paths. And that comment cut off at "might be better served on the forums"...


Dan/2023/01/additional import cleanup

Motivation
Hygiene
Solution
Clean up.
Note: I didn't dig into it, but it seemed inconsistent that Invalid1155BatchTransferEncoding_error_selector was unused.  Maybe we never ported _performERC1155BatchTransfers over to the new pattern that Dillon started using ~4 months ago?
(see removed lines and TokenTransferrer)

Codecov Report
Base: 99.54% // Head: 100.00% // Increases project coverage by +0.45% :tada:

Coverage data is based on head (4baf1d6) compared to base (9b630a2).
Patch has no changes to coverable lines.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@             Coverage Diff             @@
##              1.2      #932      +/-   ##
===========================================
+ Coverage   99.54%   100.00%   +0.45%
===========================================
  Files          47        21      -26
  Lines        2642      1229    -1413
  Branches      390       219     -171
===========================================
- Hits         2630      1229    -1401
+ Misses         12         0      -12

Flag
Coverage Δ

foundry
?

production
?

reference
100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

reference/ReferenceConsideration.sol
100.00% <0.00%> (ø)

reference/lib/ReferenceOrderCombiner.sol
100.00% <0.00%> (ø)

reference/lib/ReferenceOrderFulfiller.sol
100.00% <0.00%> (ø)

reference/lib/ReferenceOrderValidator.sol
100.00% <0.00%> (ø)

reference/lib/ReferenceZoneInteraction.sol
100.00% <0.00%> (ø)

reference/lib/ReferenceCriteriaResolution.sol
100.00% <0.00%> (ø)

reference/lib/ReferenceFulfillmentApplier.sol
100.00% <0.00%> (ø)

reference/lib/ReferenceGettersAndDerivers.sol
100.00% <0.00%> (ø)

reference/lib/ReferenceBasicOrderFulfiller.sol
100.00% <0.00%> (ø)

reference/lib/ReferenceSignatureVerification.sol
100.00% <0.00%> (ø)

... and 26 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


added youtube button to footer

Added link to AlphaByte's youtube channel in the footer.

@Fangston0  You working on it ?

@Fangston0  You working on it ?


Remove the duplicate get_context_modules

While looking at the code, and figuring out how to inject custom modules, I've stumbled upon some duplicate code. Besides that, I also took the liberty of adding annotations.

Wow, that's crazy @Fokko, I was just preparing a PR to do the exact same thing as you (add the ability to inject custom modules), also came across this duplicated code and then I spotted your PR. Do you have a follow PR of injecting modules? If no, I'll can merge your code first to do my PR :)

Good to see that I'm not the only one :-) I'd like to do some counts, and send them to an external system.
I'm currently exploring two directions:

Inject the function in some messy way:

def hello():
    return 'world'

dbt.context.base.CONTEXT_MODULES['custom'] = {
    'my_custom_function': hello
}

dbt.main()

Do it using a Spark UDF. But I don't like this, because then we also have to distribute credentials to Spark.

I've stopped pursuing implementing a custom Python function, and went with https://github.com/fishtown-analytics/dbt-event-logging/ instead. This does everything I need for now.

@Fokko sorry about this, but mypy is failing, I think before this function wasn't annotated so it wasn't inspected. Can you add a   # type: ignore to the line that accesses pytz.__all__? That attribute does exist...

@beckjake Sure, I've added the exception.


Trying to init an existing amplify repo of other creator

Before opening, please confirm:

[X] I have installed the latest version of the Amplify CLI (see above), and confirmed that the issue still persists.
[X] I have searched for duplicate or closed issues.
[X] I have read the guide for submitting bug reports.
[X] I have done my best to include a minimal, self-contained set of instructions for consistently reproducing the issue.

How did you install the Amplify CLI?
npm
If applicable, what version of Node.js are you using?
No response
Amplify CLI Version
4.50.0
What operating system are you using?
Mac
Amplify Categories
Not applicable
Amplify Commands
init
Describe the bug
I am getting the following errors when I want to init an amplify project created by an other author:
⠦ Initializing your environment: devCould not initialize 'dev': Access Denied
Failed to get profile: Profile configuration is missing for: undefined
The steps I took:
npm install -g @aws-amplify/cli
$ amplify configure
amplify init --app https://github.com/Savinvadim1312/NetflixClone.git
? Do you want to use an existing environment? No
? Enter a name for the environment netflix
Using default provider  awscloudformation
? Select the authentication method you want to use: AWS profile
For more information on AWS Profiles, see:
https://docs.aws.amazon.com/cli/latest/userguide/cli-configure-profiles.html
? Please choose the profile you want to use default
? Select the authentication method you want to use: AWS profile
Failed to get profile: Profile configuration is missing for: undefined
On a forum it said that you should add 2 files: , ~/.aws/config and ~/.aws/credentials to the root folder....
Currently these files are located here is that wrong? (if I delete them and try a new init then a new config and credentials are created there).
/Users/kevinbergmeijer/.aws
Expected behavior
Being able to launch this project by creating a new enviorment
Reproduction steps
See above
GraphQL schema(s)

# Put schemas below this line

Log output

# Put your logs below this line

Additional information
.

Hi @Kevinberg :wave:, thanks for raising. Is this the same/duplicate of this issue https://github.com/aws-amplify/amplify-cli/issues/7428? If so, can you please consolidate and close the duplicate

hi @siegerts , This one is the latest one, the other could be removed...

@yuth, lets continue the thread here, thanks!!


miliseconds

Di you plan on implementing miliseconds? I started using this for an ffmpeg video editing project, and a lot can happen in a second on film. Ffmpeg has a function that tells you where a video fades to black at say at second 3535.3432. I wanted to store and manipulate these as Duration objects, but it's just not fine grained enough. Seem like a useful thing to have.
Any thoughts?

I've come come back again to check on this, haha. But I guess neither I nor anyone else has had the time to implement micro / milliseconds. :(


Fix page 404 on documentation website

Summary

This PR contains fix page 404.
The page was corrected by a redirect in the 404 template, the redirect leads to the created page page_404 at the root of the site
Preview:
https://tosmanov.github.io/datumaro/2134
https://tosmanov.github.io/datumaro/docs/usr_manual
How to test

Checklist

[x] I submit my changes into the develop branch
[ ] I have added description of my changes into CHANGELOG
[x] I have updated the documentation accordingly
[ ] I have added tests to cover my changes
[ ] I have linked related issues

License

[x] I submit my code changes under the same MIT License that covers the project.
Feel free to contact the maintainers if that's a concern.
[ ] I have updated the license header for each file (see an example below)

# Copyright (C) 2021 Intel Corporation
#
# SPDX-License-Identifier: MIT

@azhavoro , could you take a look?


Can't find variable: self?

Hi,
I recently added redux-api-middleware to my project and everything is working fine as long as I'm in debugger mode. But once I exit the debug mode it throws "Can't find cariable: self" error when app is starting.
I got all my packages updated. RN is in latest version (0.34.1 when I'm writing this).
Anyone noticed anything similar before? It's quite tricky to even know what can be wrong as I can't debug anything (it's working when debugger is on).
I'm also sure that it's none of my existing packages.
Thanks in advance for any help.

 Looks like it's because redux-api-middleware simply doesn't work with react native as I initially thought. Sorry, my bad. Closing.

@karolbarkowski I'm running into the same problem trying to get R-A-M working with RN. Did you end up getting this working? What did you do differently?


Logs errors inside "log"

When I use console-stamp (v2) with console.error in Node.js 12.16.2, I get the error logged inside a "log" entry:
[... timestamp ...]  LOG     [... timestamp ...]  ERROR   etc
I assume this is because console.error is using console.log internally, but there must be a way round this because the documentation doesn't look like this. So what am I doing wrong?

Hmm. Can you show me the code? I'm not able to reproduce this issue.


POJOs can be directly mutated by developers without fiber knowing

Because java optimises accesses to final fields, modifying them at runtime will result in unexpected behaviour. (and fiber shouldn't be modifying those in the first place)
This means we are forced to disallow use of final in POJOs.
However, this also means developers can directly set the values in a POJO, making it desynchronised with the IR it was merged into.
Implement a system to prevent this.

Have developers merge the POJO back into the IR after mutating.
Have the IR track POJOs and a ir.markDirty() method that checks for modifications

one option would be to create a copy of the POJO, with setters and getters (via gradle task generating code)
such wrapper objects might be possible to be generated
class PojoWrapper extends Pojo {
    private Pojo wrappedObject;

    public setX(int x) {
        // do ir notify before or after
        wrappedObject.setX(x);
    }
}

but i am not sure how to properly parse the existing POJO and turn it into AST or whatever to generate the wrapper
thats why i think a simpler representation/format that covers all you need for generating a POJO would be easier to use
class PojoName
  int x
  String variableName "defaultvalue"

this would generate just a POJO, no extra functions on there, maybe thats something one would want to add
i think there is no real builtin way to monitor fields
maybe InvocationHandler could be used to hook into the setter mothods of a POJO,
but from what i read you have to have a interface and can only monitor calls defined there, apparently not register them dynamically at runtime, which would probably be a bad idea anyways
and it does not work on public variables anyways

You could instead of POJOs declare configurations as interfaces with getter and setter methods. Neither option is particularly desirable tho.

Maybe we can modify the backing Property's getValue of nodes created by the annotation system to perform a reflection call on the POJO. Basically, any time the getValue method on a node is called, it'll fetch the (potentially new) value from the POJO.
Some thoughts to consider:

Does this impact performance severely enough not to be feasible? Reflection is pretty slow at times, but is it a problem in a configuration system?

Change listeners will only be invoked upon a getValue call, where the backing Property suddenly 'realises' the value changed.
This means that e.g.:
myPojo.a = 0;
myPojo.a = 2;
doSomethingInvolvingA(mirrorOfA);
mirrorOfA.getValue();

Will only call listeners of a either somewhere in doSomethingInvolvingA (if getValue is called), or during mirrorOfA.getValue();. Is this a problem?

0 will never pass through the listeners, because the Property has never 'seen' it pass by.
Listeners are delayed, but will always be called just in time before a value is fetched.

What to do if a node with this kind of property is detached from the IR? How do we handle merges, etc?


Cannot gitignore R.generated.swift

I cannot ignore R.generated.swift, location R.generated.swift in Name Project/Resources/R.generated.swift
and I finished add *.generated.swift in .gitignore
when I git status :
modified:   Name Project/Resources/R.generated.swift
please help me 🙏🏼

If you see the file as modified in git, it means it is already being tracked by git.
First remove the file from git, then commit. Afterwards the ignored file shouldn't show up anymore.


schematicareplace command not working on 1.8

i'm using the latest version of schematica and the command isn't recognised. did it get changed/removed?

You need to write /schematicaReplace =) It's important to write it exactly like that ^^


Logo

I think it would be nice to have a simple logo for plot2.
I'm not a designer, and I'm unlikely to have other ideas, but here's a simple one (with help of GPT and some manual edits). It's probably not objectively great, but I like that it's simple and that the 2 could be used as favicon.

Thanks, yeah it's a good idea. A logo would be cool and it's nice to have ChatGPT's help here.. (Alternatively, Maybe something produced by the package itself, like I did for parttree?
Let's finalise the package name then take it up from there.

I was thinking of a stylised easel containing a plot. Here's the first thing DALL-E gives me, which is actually pretty cool. Could probably edit out a few of those extra points, but I like the vibe.

I like it!
I've tried asking it to make plots simpler but it always seems to struggle. Once I asked it for 20 versions of the same logo and picked one, converted it to svg in inkscape, and got something reasonable.

Some comments and impressions, just my two cents. Feel free to disagree or ignore!

Both icons are "ok" in my opinion but I think they are not the most memorable.
I like the minimalistic style of the latter but would prefer something with more color...given that it is a graphics package.
The main aspect I don't like is that an easel is not "tiny". But I couldn't think of an easily recognizable device that is tiny. A clipboard is probably still too large.

When thinking about the name, I had the following association which I quickly drew in very poor quality in GIMP. Again feel free to dislike or ignore.

+1 to whimsy and a pop of colour.
One thing I do like about the original DALL-E drawing that I got was that it looks "cute", which is kind of synonymous with "tiny" in my mind. I'm going to share these with my wife (who actually works in the architecture/design industry and is thus much more qualified than me) for some opinions :-)

Asking the wife is always a good idea!
On Monday my very talented colleague Reto will be back in the office. I'll also ask him for his opinion and possibly an alternative idea. He has helped me with quite a few logos and icons in the past:

Hi both, I plan to submit to CRAN this even (finally!).
But I wanted to circle back to this issue first. I've re-jigged my easel idea a bit. See attached. I think it makes for a decent enough logo, so I'm going to run with it. We can always revisit and potentially redo down the line.

(Achim, I'm not sure if anything came of your conversations with Reto, but please feel fee to share any ideas/logos that he proposed.)

Looks great!

I like it. It has a bit of a "great wave" vibe.
(Re: Reto. He had so many other things on his plate that I didn't want to add to that so I haven't asked, yet.)


Proposal: handle vendor symlink redirect gracefully

Many Go repositories, instead of having a directory at vendor, have a symlink to a directory such as .vendor or _vendor so that the go toolchain will skip vendored code. At present dep fails on such repos entirely with a source is not a directory error; it uses lstat instead of stat on vendor, lest it get caught in an infinite loop.
Possible solutions:

Do nothing for now. When Go 1.9 is released and the toolchain skips vendor by default, ask repo maintainers to move the linked directory to vendor before running dep.

Pros: No changes, and repos will naturally standardize.
Cons: Nobody with this setup can use dep until 1.9 is released.

If dep finds a symlink at vendor, explicitly follow it once, verify it points to a directory, then:

silently use the linked directory as the vendor directory.

Pros: It works with minimal changes to the repository.
Cons: The maintainer may have no idea that their usage is nonstandard.

use the linked directory, but warn the user.

Pros: It works with minimal changes to the repository.
Cons: Anyone using dep gets hit with a warning every single time. (Is this really a con?)

(in dep init only) remove the symlink and move the linked directory to vendor, possibly with a prompt.

Pros: The repo is automatically standardized.
Cons: Possibly massive changes to the repo; the go toolchain will no longer skip vendored code.

My preferred solution is 2 before the release of 1.9, 3 afterward, but I'm happy to implement any of these or any modification.
What version of Go (go version) and dep (git describe --tags) are you using?
go version go1.7.5 darwin/amd64
v0.1.0-313-g44a454b

hi! thanks for the issue, and giving us a menu of options to choose from 😄 🎉
i'd say that 2.ii and 2.iii aren't actually mutually exclusive, and we probably want both. the implementation for them lives in very different places, especially because we have to be able to deal with legacy code from before this fix was made.
2.ii is the harder one, with further-reaching implications. so, notes...

At present dep fails on such repos entirely with a source is not a directory error

this is actually just the tip of the iceberg. that may need fixing as well (i'm guessing that error is only occurring during dep init?) but the hairier thing is updating the way we build a virtual representation of the filesystem to accommodate this reality.

if dep finds a symlink at vendor, explicitly follow it once, verify it points to a directory

we have to be a little more restrictive than this, as we've been all up and down this kind of path before. symlinks are 🤕 🔫 . so, more rules:

symlink MUST be relative
symlink MUST point to a sibling node (no subdirs, and definitely no ../)
symlink MUST not point to another symlink (encompassed by your "must be dir" req, but just to be 💯 clear)

OTTOMH, these'll need to be applied in that ListPackages() func, the probably mirrored elsewhere. further, we'll need to expand ListPackages() to understand that the referent of the vendor symlink is also a directory that should be skipped. with the way that filepath.Walk() works, this is likely to require keeping some state outside of the giant walkFn.

Another reason I'd like to be able to make vendor be a symlink: if we don't check vendor into git and want to store vendor in a cache in CI.  It would be nice to be able to just run ln -s /cache/go-vendor ./vendor at the top of my CI setup and assume that dep ensure will only write to vendor via my symlink.

We have a complicated hybrid perforce/git environment where it would help me if /go/src/arista.com/vendor could be a symlink.  I would prefer option one, where the go toolchain just assumes I know what I'm doing.
Generally, it would be nice if go treated symlinks as first-class within /go/src.  ("go install arista.com/..." does not do what I want because it disregards my symlink forest in /go/src/arista.com).  I may have to resort to bind mounts to get my go workspace to behave the way I want while preserving interoperability with my existing source control hierarchy.  I suppose if I have to bind mount other things anyway, why not bind-mount /go/src/arista.com/vendor too.  :-/
Thanks,
-Ken
Kenneth Duda
Arista Networks


merge Phonegapify and Buildify modules

the phonegapify and buildify modules are identical, just different shell targets

Closing. This is not being pursued.


Enabling rotation gesture

when will the rotation and move image will be implemented

i am using files of
https://github.com/renancaraujo/photo_view/tree/4bf597fdee1e46fd3b4aab22159f73557948c4f9
where i modified some files to move image position as well.
the custom library RotateGestureDetector was very helpful. Thanks. 👍

I've opened a PR in flutter/flutter  adding framework support for rotation gesture. I've opened as I wait for final disclosure of this question since I think that a GestureDetector is a huge responsibility to carry with Photo View as a lib.
In other words, this PR is a snapshot of how Photo View must behave when rotation becomes available in Flutter.
If you think your changes are a good addition, you can share here, that would be great.

Unfortunately, I'm not having time to update this branch anymore. Photo View will support rotation as soon as flutter does.


Buggy pipe rendering in water

When you place pipes underwater and are above the water, the pipes often don't render at all. There seem to be chunk borders involved somehow.
In the below image, there are pipes basically in a straight line there going into the hole in the side of the wall

I am unable to reproduce this effect. Please provide testing steps and what mods you have loaded.

Oh, it might be a sodium bug then. I'll see if I can reproduce it tomorrow, with and without sodium

Were you able to reproduce it without sodium?


Can not handle two accounts with the same name

Storage Explorer Version:
1.0.0
OS Version:
Win 10
Steps to Reproduce:

Create private account<EMAIL_ADDRESS>Create another account bound to some Company AD<EMAIL_ADDRESS>
Expected Experience:
Can drill down in browser to see storage accounts etc.
Actual Experience:
Can not drill down. ASE is not able to expand any node.
Also when you delete one of those two accounts in Account Management in ASE it will delete both…

@Confuset , are you getting the "Subscriptions for one or more tenants could not be retrieved" message in the account panel?

Not that iam aware of.
in account managment my Microsoft account listed 3 subscriptions (which is correct). For the other account i was asked to reenter credentials, what i did not do, because the blob storage, i was interested in was one of the 3 listed already of my Microsoft account.
in the tree browser i could see all 3 subcriptions, but when i tried to expand one of those, it failed with no message. the + (for expand) just disappeared.
i then tried to delete the one account i was not using and for which it asked for the credentials, but when i did that both account where deleted.
i have the feeling that Storage Explorer does not cope well with to accounts having the same mail address…

side not. after readding my Microsoft Account everything worked :-)

I'm glad you got it working, but it does seem like you were in a less than ideal state for quite a while though. So I'm going to leave this issue open until we can repro it and figure out what went wrong. :)

@chillryan , so let me understand this correctly,
You have your<EMAIL_ADDRESS>email address, and that has both an MSA and an O365 account associated with it. Then you also have your "ryanchill..." email address which is just an MSA.
For "ryanchill...", you have no issues. But for<EMAIL_ADDRESS>you have to duplicate the MSA? How are you doing that? I guess what I'm interested to know is how many times did you have to sign in to see the 3<EMAIL_ADDRESS>accounts.

I depends on which<EMAIL_ADDRESS>I remove. When I remove one, I can't access our azure resources (see the second shot; you'll notice that there is no chevron), it will popup but not display anything. If I remove the other, Azure Storage Explorer is happy but VS says invalid token to access VSTS and prompts me to sign in again. Doing so duplicates the MSA account. My O365 account doesn't have any VSTS or Azure subscriptions tied to.

Ok, it sounds like VS and Storage Explorer are causing issues for each other. While I try to figure out how I can get my VS into the same state, can you do the following?

Close Storage Explorer and VS
Go to %temp%\servicehub\logs
Clear the folder, leave file explorer open
Launch Storage Explorer and VS, remove the account that causes VS to need reauthentication. Once you see VS asking for reauth, sign back in, and then close the programs
Go back to the logs, give them a quick look and remove any personal information you don't want other people to see
Zip up the files and add them to this issue

Also, I'm pretty sure you're not blocked (just an annoying state), but if you are, you can download the previous version here: https://go.microsoft.com/fwlink/?LinkId=809306&clcid=0x409 (though I would appreciate the logs before you downgrade :) ).

Will do, and yeah it's annoying at most. I tried all kinds of scenarios. Removing accounts from Storage Explorer, adding through storage explorer and vice versa. I'll post the logs as soon as I can.

@MRayermannMSFT not much going on in the logs
StorageServiceClient-hubControllerLookup-15464-j3mcmudn-1.log

For anyone watching this issue, please be aware that if you are:

Using Windows
Your machine is domain joined/your are signing into Windows with your ADFS work account or you have logged in with this work account before
It is possible that you will not receive 2 factor authentication or even your password. This capability comes from our new auth library.

Basically, with our new auth library, once you enter your username, a request goes to your company's ADFS server. If your Windows account/machine is linked with this account, then the server knows who are, and thus doesn't ask you for a password or to authenticate.

Closing this as no one has replied to it in a while. If you continue to have issues, please open a new one describing your situation. Thanks!


Issue importing a URL using default import script

In helix-importer-ui when the given import script URL does not exist, the import will still work using a default transform function (from helix-importer). This is the default use case and is supposed to always work OOTB.
As discussed with @bpauli and @jckautzmann: @karlpauls and myself are working on a demo tool to help users automate the kickstart of a Franklin project. Quickly came up the case for support crosswalk projects.
We are working on automating the import to jcr flow and while doing so we are testing different URLs and when the import to jcr is failing in our flow, we fallback testing the same URL in the "vanilla" jcr importer (building locally this project and using in context of aem import) to check if issue already occurs in default use case.
Last example we have is with
https://www.commbank.com.au/credit-cards.html

importer settings:

(notice the dummy "Transformation File URL" value to ensure we use the importer default import script)

Hitting the Import button, we get following error in web console
log.js:35 [importer-ui] Error importing http://localhost:3001/credit-cards.html?host=https%3A%2F%2Fwww.commbank.com.au: Cannot read properties of undefined (reading 'value')
TypeError: Cannot read properties of undefined (reading 'value')
    at getLink (helix-importer.js:102389:39)
    at getAttributes (helix-importer.js:102408:35)
    at helix-importer.js:103194:26
    at node (element<p>) (http://…porter.js:197228:27)
    at node (element<div>) (http:…porter.js:197245:61)
    at node (element<main>) (http…porter.js:197245:61)
    at node (element<body>) (http…porter.js:197245:61)
    at node (element<html>) (http…porter.js:197245:61)
    at visitParents (helix-importer.js:197186:31)
    at hast2jcr (helix-importer.js:103185:73)

(Note: for line number references, I built helix-importer-ui in dev mode npm run build:dev)

Further investigation shows that problematic element is this cards block (at the middle of the page):

Here is an import script which works as it removes all the identified problematic blocks.
export default {
  transformDOM: async ({ document }) => {

    const main = document.body;

    WebImporter.DOMUtils.remove(main, [
      '.commbank-header #logonDialog',
      '.commbank-header #hamDialog',
      '.commbank-header #dialog1',
      '#skipmaincontent > div.container.content-container > div > div > div > div > div:nth-child(5) > div:nth-child(2) > div > div > div:nth-child(4)',
    ]);

    return main;
  },
};


feat: add first group of practice projects

Checklist:

[ ] I have read freeCodeCamp's contribution guidelines.
[ ] My pull request has a descriptive title (not a vague title like Update index.md)

Closes #XXXXX

Be aware: I am building a JS testing helper: https://github.com/ShaunSHamilton/babeliser

This looks interesting @ShaunSHamilton, I will give it a try. I presume you saw I added acorn to and help with things like that. It helps, but it isn't awesome.

I suggest splitting up your descriptions with new lines - separate the information from the instruction. It adds 2 chars to your total length. So, I do not think it a problem.

Quincy always encouraged us to just use a single line for the instructions. I think it was to try and force us to make shorter descriptions. I don't mind splitting it up in spots, but I would try to not do that if you can.

I suggest going through and adding periods

Yea, I think we mostly use periods there - although, It's pretty mixed. I just prefer not to on the test tests, I think it looks better. I suppose I can maybe add those in.


Fix exception message logging

The .message attribute was present when these were ROS 1 exception types, but they were changed to the standard Exception type.

Buildfarm failure due to patch 2 rebuild, tests succeed locally.


fix: add notice for required content-type header on update tokens

Description

Clearly document the required Content-Type header for PATCH /tokens/

Testing required outside of automated testing?

[X] Not Applicable

Screenshots (if appropriate):

Rollback / Rollforward Procedure

[X] Roll Forward
[ ] Roll Back

Reviewer Checklist

[ ] Description of Change
[ ] Description of outside testing if applicable.
[ ] Description of Roll Forward / Backward Procedure
[ ] Documentation updated for Change

:tada: This PR is included in version 1.76.2 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Add Efosa Ogiesoba to Contributors list

I resolved an immediate merge conflict that took place when I made a new Pull Request. My contribution line of code conflicted with another user below. Included me and the user who was trying to get added to the contribution list.
Other user: Robert Ghereben

@eogiesoba, I'm quite elated about your pull request. I wanna evolve this project to addresses various problems faced by first-time contributors. I'd love to learn about your journey in open source community, the problems, pain points you had etc.
Could you explain how you felt when you went through the tutorial, made a pull request and learned that I merged it?
We’ve recently added social share  to our web app. Could you please go to https://roshanjossey.github.io/first-contributions/#social-share and share your first contribution to open source?
Also, check out projects with easy issues while you’re there.

@Roshanjossey, The tutorial was very easy to follow. I was very happy to see that it merged, and also that I had made my very first contribution to an open source project. I feel more in contributing to future open source projects. I actually completed this task as part of an HW assignment for a coding certification program that I'm currently attending.

@eogiesoba, I’d urge you to continue contributing to other open source projects.
We also have a slack team to help/mentor people trying to contribute to open source projects.
You can join the team by going to https://firstcontributions.herokuapp.com


on npm version 2.0 is available instead of 2.2

@oligibson  new version is not published on npm. Please update it.

@sagarkaurav
Try npm install --save devicon-2.2. It works for me!

@jessamarie  I am using yarn and yarn add<EMAIL_ADDRESS>doesn't seems to work!.

@sagarkaurav For some reason you have to add a different package name, but it should work with yarn as well. Use this command instead: yarn add devicon-2.2

@jessamarie thanks its worked but i am still curious  why different name is used and why is devicon 2.2 is not available?

I had the same issue when I tried upgrading from version 2.0 to 2.2 on Yarn (I solved it by removing the original package and installing that separate 2.2 package). Will all future releases be released in separate packages in Yarn?

since 2.2, it's a package named devicon-2.2 with a version of 2.2.0.  whoever owns the original devicon packages needs to npm publish please.
putting the version number in the package name is bad joojoo:  npm install<EMAIL_ADDRESS>will work.  npm install<EMAIL_ADDRESS>will not.

To add to @adamski52's comment:

devicon-2.2 is a different package published by boomhq
That package is NOT owned by @konpa

@konpa would it be possible to publish the latest to NPM?

Hey, we are working on getting back on track. We will be following SEMVER releases from now on! I'll go ahead and close this issue. (Docs will be updated accordingly in the future. Trying to get the website back up at the moment.)


Android Multiple BLE Connections | Latency on Observe Functionality

Hi,
I'm working on an Android app which connects 5 to 8 devices and these devices have a service which emits a simple ByteArray in each ~(4 to 10ms).
When I start observing this service for each devices, I start seeing huge package losses (80% or even heigher) for some devices (for some of them package loss is pretty acceptable like 0.48%). But when I connect only 1 or 2 devices, I see almost no package loss.
Is there any restriction with device count or do you if I miss a point?

There isn't any known restrictions.
Kable feeds all characteristic changes (from the BluetoothGattCallback) into a MutableSharedFlow with an "unlimited" buffer:
https://github.com/JuulLabs/kable/blob/40973d5f50dd4346510f25dcd6296c62053c4cc6/core/src/commonMain/kotlin/Observers.kt#L46
If you're slow on the consuming side, you should just see memory usage grow rather than packets being dropped.
I can't really speak as to limitations there might be in the underlying Android BLE system though. Not sure how Android might handle a peripheral updating a characteristic faster than Android and retrieve the updated data.

What version of Android is this? Before Android 26 the threading model for BLE was wonky. 🤷 If you see different behavior pre vs. post Android 26 it might hint at a possible cause.


Attachment cycling with onyx

Implemented functionality to achieve the following statement:
"The attachments present in the chat should cycle when the user is viewing the modal and presses the left/right arrows on their keyboard"
Details
Refactored code and moved Attachment modal so only one is created for ReportActionsView and one for the ReportActionCompose view. AttachmentModal now consumed visibleModal object from Onyx to know what to show and wether to be visible.
Also wrote getNextAttachment function which retrieves the next attachment using the current action and a boolean value indicating whether to move to the right or left of the current action.
Fixed Issues
Implements #1038
Tests

Upload multiple attachments (Images and PDFs)

Once they have been uploaded, use the left and right arrow keys to move between all of them.

Go to the last attachment and confirm that moving to the right of the last attachment takes you to the first attachment in a cyclical manner.

Test that uploading attachments still work (Images, PDFs .etc)

Tested On

[x] Web
[ ] Mobile Web
[ ] Desktop
[ ] iOS
[ ] Android

Screenshots
Web

Mobile Web
no changes
Desktop
no changes
iOS
no changes
Android
no changes

also adding @tgolen

also adding @tgolen

Closing PR. Marc and i discussed about this issue for a while and we feel like we should close this PR for now. We'll be splitting the original GH issue into multiple smaller issues to discuss and improve renderHTML and cycling attachments and once we've settled with a technical plan we'll be posting those in upwork.
Thank you for your time and work. Closing PR now.

Closing PR. Marc and i discussed about this issue for a while and we feel like we should close this PR for now. We'll be splitting the original GH issue into multiple smaller issues to discuss and improve renderHTML and cycling attachments and once we've settled with a technical plan we'll be posting those in upwork.
Thank you for your time and work. Closing PR now.


Fix remaining tests

With this PR, #574 and https://github.com/arborx/ArborX/pull/353 All the tests pass. I had to relax the tolerance for two tests. One is interpolation using H_DIV which nobody is using. The other is a MLS test which was already a little bit strange. All the other tests were using a tolerance of 1e-14 but this one was using 1e-11.

Superseded by #574.


Include glibc version by default

v4.0

Still having issues probably as results of this, e.g., https://travis-ci.org/nextcloud/client_theming/jobs/231715981 has the glibc version twice now.

Can you give me a link to the recipe?

https://github.com/nextcloud/client_theming/blob/master/linux/appimage-build.sh

Well, they copy-pasted that code some time ago, and it's still in their recipe: https://github.com/nextcloud/client_theming/blob/master/linux/appimage-build.sh#L99
They just have to remove that, and voila, it'll work. So, it's not the commit that is causing that.

As do 188 others... https://github.com/search?utf8=✓&q="GLIBC_NEEDED"+appimage&type=Code

The old legacy code problem. The benefit of this pull request is a lot higher than its cost. I mean, double glibc version is better than none in the filename.
I think people will adapt that in the future automatically. Also, we can send PRs whenever it gets relevant.