Id field

Shouldn't it be possible for the Id field to not be AUTO_INCREMENT (so that we can specify the actual id)?
Thanks

Yes, that seems like a reasonable thing to do. I'm trying to kill off these last remaining tickets for a 1.0 release soon, so this will be included in that.
For now you could add another field for your own ids and ignore the AUTO_INCREMENT ids.


Improve date time visualization

Improve date time visualization displaying two units at the same time:

current view (e.g. hours)
scale view (e.g. days)

This requires the definition of a schema mapping between different units (hour/day, day/week, week/month, month/year)
Move the hour tick above the cell border or in a better place to improve UX.

:tada: This issue has been resolved in version 1.0.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Convert YAML to JSON before using JSON tags

First translate YAML to JSON before unmarshaling to a structure with JSON tags. This is less prone to error.

What was the reason behind this PR? IIRC the decoded string is in YAML. We are able to decode yaml into structures quite easily. We can even add yaml:"fieldname" similar to how we do the json stuff.

I was passing around a large set of yaml as a config file and found this issue.  I think the YAML to JSON has trouble with complex YAML structures so this was to guarantee we never have that issue.

@jmrodri does that address your question?

@rthallisey what large yaml were you passing around? How large of a yaml file was it to cause the problem? Right now things are working as is, unless you can show me what problem this fixes.

NACK

Maybe we should log an issue with the problematic yaml and investigate that directly?

Let me dig up what I was using.  It wasn't bad yaml, but the information was nested 3 or 4 layers down and was never being gathered.   All I'm doing is converting all incoming data, yaml and json, and decoding with the json decoder. Kubernetes does the same thing.  That's where I got the idea from.
https://github.com/kubernetes/apimachinery/blob/4500b7d1a0fc94ffb6d03f4019b2968b47e165bf/pkg/runtime/serializer/json/json.go#L87

Have we seen an issue during the last iteration with this?
This makes it seem like the real problem is attempting to serialize json and yaml into the same struct. Specs are taken in as YAML and output as JSON. Because of this, I think it might make sense to convert it to all one format to interact with the struct.

I see the comments in the blog, but I struggle because we've been running for months without a problem in any of the areas where we do yaml conversion. If there was a problem we saw consistently I would be much less of a pain with this simple PR.
Now if we really want to do this then, there are quite a few uses of yaml.Unmarshal that need to be replaced then.
$ git grep "yaml.Unmarshal"
cmd/mock-registry/mock_registry.go:     yaml.Unmarshal(dat, &parsedDat)
pkg/apb/mock_registry.go:       err = yaml.Unmarshal(specYaml, &parsedData)
pkg/apb/types.go:       if err = yaml.Unmarshal([]byte(payload), obj); err != nil {
pkg/app/config.go:      if err = yaml.Unmarshal(dat, &config); err != nil {

@eriknelson thoughts?

this also needs rebasing since there are conflicts.

@jmontleon this PR would add a new dependency.

@rthallisey Do we want to close this and reopen if we come across the problem again, or were you working on that so we should leave this open?

I wanted to see if I could generate the yaml that gave me the issue. Since what we have works, let's stick with it and we can always come back to this if there's a problem.


How to generate a token to authenticate for hook

Hi Akraxx,
Thank you for your great tool. I am following your instruction to setup it but currently get stuck on this one: "You need to generate a token to authenticate your hook, format of the token is : [service:pwd] encoded in Base64, where service is any value you want to identify your gitlab hook, and password is the one defined in the YAML configuration file."
Could you please provide a step by step guide how to achieve the task above?
Regards

Hi,
To do this you have to follow these steps :

Choose a password, for example test-password
Choose a name for the gitlab project (it's only useful for the log of the plugin to identify the requestor), for example my-gitlab-project
Go to a base 64 encoder like this
Type my-gitlab-project:test-password into the first textbox
Click on > ENCODE <
You will generate this : bXktZ2l0bGFiLXByb2plY3Q6dGVzdC1wYXNzd29yZA==
Now go back to the settings of your gitlab project, and add the following Web Hook url : http://[IP/HOSTNAME]:9090/hook?token=bXktZ2l0bGFiLXByb2plY3Q6dGVzdC1wYXNzd29yZA==

Hope it will help you! Tell me if you still have some troubles with this part.

Perfect, thank you very much Akraxx. Thanks again for share this plugin with us.

You're welcome !


[BUG] Can't open game pages, when clicking games (not play button) it gets rid of the UI and goes to or just shows the classic avatar area. (works for regular roblox)

Acknowledgement of preliminary instructions

[X] I have read the preliminary instructions, and I am certain that my problem has not already been addressed.
[ ] My answer given in the checkbox above is a lie.

What problem did you encounter?

prob shouldve kept the title short

this also happens to me too

apparently someone got it fixed by disabling the old avatar editor background (it worked for me)

Turn off "Use old avatar editor background."

nevermind they fixed it, but thanks for the suggestions


Symbols Navigation

It will be great to have symbols navigation :)
I made a quick search about it and I found that it was easy with Sublime Text
https://github.com/SublimeText/ColdFusion/blob/master/Symbol List.tmPreferences
But probably will not work with vscode. Not deeply tested yet.
Otherwise PHP community solve it
https://github.com/ly95/vsc.php-symbols
Thanks for this extension btw.
Mx

I would be willing to sponsor this feature!  @ilich Would you be interested?

Sounds good, @lmajano. Could you send me a private message on Twitter, and we will discuss the project. I would like to keep working on the project.

It seems we will have to create a language server for CFML to support those features.
Is there any official CFML language specification similar to ECMASscript or C# specification?
Do you think we should use https://cfdocs.org/ as the starting point? I think this project might be useful to generate TextMate Language definitions and snippets.
Does anybody know any good CFML parser? I found https://github.com/cfparser/cfparser that supports ANTLR4 and I hope to generate JavaScript code and may be even TypeScript code from it.
I also found https://github.com/denuno/cfml.parsing/tree/master/antlr, but it seems to be outdated.

I believe peter freitag has one
Luis Majano
CEO
Ortus Solutions, Corp
www.ortussolutions.com
P/F: 1-888-557-8057

From: Ilya Verbitskiy<EMAIL_ADDRESS>Sent: Thursday, September 7, 2017 8:44:25 AM
To: ilich/vscode-coldfusion
Cc: Luis Majano; Mention
Subject: Re: [ilich/vscode-coldfusion] Symbols Navigation (#11)
It seems we will have to create a language server for CFML to support those features.
Is there any official CFML language specification similar to ECMASscript or C# specification?
Do you think we should use https://cfdocs.org/ as the starting point? I think this project might be useful to generate TextMate Language definitions and snippets.
Does anybody know any good CFML parser? I found https://github.com/cfparser/cfparser that supports ANTLR4 and I hope to generate JavaScript code and may be even TypeScript code from it.
I also found https://github.com/denuno/cfml.parsing/tree/master/antlr, but it seems to be outdated.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/ilich/vscode-coldfusion/issues/11#issuecomment-327803580, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AAIXl48K7QlCbDUSsRFEhriGc1oLsJIcks5sf_M5gaJpZM4NATdK.

I think VS Code has some real potential to become the best editor for CF.
This could also be an opportunity to add some "intellisense" beyond what can only be derived from within the contents or path of a open file in the editor. Perhaps some metadata or config file present to help provide the editor with some context to take advantage of other IDE features that seem to lack in all other CF IDE/Editors. Analysis of the entire project directory and config files with Javascript/TypeScript.
"Language servers let you create a dedicated process for your extension."
https://code.visualstudio.com/docs/extensions/example-language-server
https://code.visualstudio.com/docs/editor/intellisense#_troubleshooting

@ilich You can use this for a parser: https://github.com/foundeo/cfmlparser
Remember like @tdhatcher mentioned, we can use a language server in the background.  We can use an instance of CommandBox to achieve this. So we can even have a running CFML engine at the OS level

@lmajano You are right. We have to build a language server to support any intellisense, refactoring, etc.  Users will have to have ColdFusion/Lucee installed locally to be able to run it, won't they? Is there any lightweight option to run CFML script?
I know several developers who have ColdFusion running on the server, and they just code locally and upload files over FTP. That's why I was thinking about ANTLR4. It is capable to generate a JavaScript parser. In this case language server might be built in TypeScript that is available out of the box with VSCode. What do you think?
PS Of course, if we cannot find ANTLR4 syntax, let's build the server in pure CFML. I assume that most of developers have Lucee or ColdFusion locally anyway.

You can use CommandBox for this.  www.ortussolutions.com/products/commandbox. It allows you to execute cfml at the operating system with no server.  The sublime extension also uses this.  This allows you to leverage CFML like php or nodejs but at the OS level.

cfparser uses ANTLR if you want to check that out.

Regarding parsing, cfparser is the best one I know of, but I'm not sure it is performant enough. The primary maintainers on it are @ryaneberly and @denuno. It is the parser that is used for CFEclipse.
Creating a language server goes beyond even VS Code and is currently the best possible solution for the widest support. GitHub recently announced Atom-IDE, which utilizes language servers. There is also a Sublime Text 3 LSP package.

What about this one: https://github.com/foundeo/cfmlparser

That one doesn't do cfscript AFAIK.
CFParser is the best and fastest that I know of.  CFEclipse runs it after every change and it's zippy enough in general.  I think it's the only complete 3rd party parsing solution.
I think we're going to be adding a more generic model, right now it handles both tags and script but they're basically separate models.
That'd be your only real issue using a JavaScript ANTLR target for the lexer/parser based off of the existing grammar -- it'd only handle script, as the tags are handled by Jericho (an HTML parser)... A couple of us have tried to write ANTLR grammers for the tag stuff too, but so far they've been too brittle to handle all the real-world crazyness valid CFML can be.  Jericho is geared for exactly that kind of thing.
You could use CommandBox as a language server, and run CFParser or CFLint to generate the document model, or say to heck with tags and use the javascript targets from the ANTLR grammar and basically plug it in the same way the PHP folks did their tokens, or revisit the tag ANTLR grammar and try to support tags that way.
A lot depends on what you want to do, and where you want to go. If all you need is function tokens, you can do that with a couple regular expressions, basically.  But soon you want arguments, and then better yet references, so you can do a "replace all occurrences" on a variable and have it not change things that are strings or a different variable with the same name, etc..
If there's stuff we can do for CFParser that will make it easier for other tools, we're all ears.  I'm doing stuff for CFEclipse and sorta kinda keeping Sublime in mind.  We could all try to define a good document model and then use that, so implementations could vary.  (Language committee type stuff I reckon, really, but at this point I think the tools folks are as good as any to create a standard.)
Anyhow, I've played with VS Code and I like it, and I'm always happy to get better CFML support wherever it's needed-- Plus I'm probably one of the world's foremost experts on CFML IDE integration don't cha know! -- so feel free to pick my brain.  :-)

Dennyyyyyyy to the rescue.
We need you man. Let’s make this happen
Luis Majano
CEO
Ortus Solutions, Corp
www.ortussolutions.com
P/F: 1-888-557-8057

From: Denny Valliant<EMAIL_ADDRESS>Sent: Thursday, September 14, 2017 11:23:15 PM
To: ilich/vscode-coldfusion
Cc: Luis Majano; Mention
Subject: Re: [ilich/vscode-coldfusion] Symbols Navigation (#11)
That one doesn't do cfscript AFAIK.
CFParser is the best and fastest that I know of. CFEclipse runs it after every change and it's zippy enough in general. I think it's the only complete 3rd party parsing solution.
I think we're going to be adding a more generic model, right now it handles both tags and script but they're basically separate models.
That'd be your only real issue using a JavaScript ANTLR target for the lexer/parser based off of the existing grammar -- it'd only handle script, as the tags are handled by Jericho (an HTML parser)... A couple of us have tried to write ANTLR grammers for the tag stuff too, but so far they've been too brittle to handle all the real-world crazyness valid CFML can be. Jericho is geared for exactly that kind of thing.
You could use CommandBox as a language server, and run CFParser or CFLint to generate the document model, or say to heck with tags and use the javascript targets from the ANTLR grammar and basically plug it in the same way the PHP folks did their tokens, or revisit the tag ANTLR grammar and try to support tags that way.
A lot depends on what you want to do, and where you want to go. If all you need is function tokens, you can do that with a couple regular expressions, basically. But soon you want arguments, and then better yet references, so you can do a "replace all occurrences" on a variable and have it not change things that are strings or a different variable with the same name, etc..
If there's stuff we can do for CFParser that will make it easier for other tools, we're all ears. I'm doing stuff for CFEclipse and sorta kinda keeping Sublime in mind. We could all try to define a good document model and then use that, so implementations could vary. (Language committee type stuff I reckon, really, but at this point I think the tools folks are as good as any to create a standard.)
Anyhow, I've played with VS Code and I like it, and I'm always happy to get better CFML support wherever it's needed-- Plus I'm probably one of the world's foremost experts on CFML IDE integration don't cha know! -- so feel free to pick my brain. :-)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/ilich/vscode-coldfusion/issues/11#issuecomment-329677678, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AAIXl3R3qOoMzBxxbbiS7_sVyreZEYK8ks5sifuzgaJpZM4NATdK.

@ilich ,
As with @lmajano I would be willing to co/sponsor the upgrade of CFML support in VSC. It's the only thing keeping me from using VSC... so I am in Sublime Text 3 for now, which has better CFML support but is lacking in many other areas.

@WebVeteran Thank you very much!

You're welcome. I am super duper eager. Whatever I can do to get this going, let me know! Email is in my profile.

@denuno Thank you for the link. I will take a look. You cannot use a parser or language server for syntax highlighting because it will cause performance problems. More information is available on https://code.visualstudio.com/blogs/2017/02/08/syntax-highlighting-optimizations post.  Unfortunately we will have to use TextMate regular expressions, and it seems to be complex in case of CFML language because people mix HTML, CFML, cfscript and SQL inn one file. I am still looking a way to say VSCode that particular chunk should be parsed by SQL parser, etc (if it is even possible).

Would it be possible to port over https://packagecontrol.io/packages/CFML ? It does a great job, at least in what I use it for. Does that package do what you're looking to solve above?

That Sublime package is awesome!  I think parts of it are already ported here, and soon in CFEclipse too actually.  (The TextMate/Sublime syntax file @ilich mentioned (with the mix of stuff) above.)
We could use the TextMate bit to tokenize things I think... that's not quite the same as a real model, but it would probably get a Language Server ("LS") going, ish.  An interesting idea for sure!  Maybe plug tm4e into lsp4j?  Something tells me if it were that easy it'd exist out there already.  Plus, it'd be cool to have a decent model, versus just knowing where generic tokens are.
After taking a hard look at how both Eclipse and IntelliJ IDEA do their Java stuff (arguably their best language editors, neh?)-- man, doing it really well is not super easy!  Those are some deep models, with lots of caching, etc..
So, I dunno, maybe we don't do it really really well.  :smiley:  Or maybe we grab one of those and tweak 'em to suit our needs.  Or maybe tweak the Groovy LS (less complicated model at first glance at least).  FWIW, I'm currently leaning towards maybe putting what I saw into a middle-of-the-road interface+implementation, and then using that in an LS.
@ilich Being able to edit mixed languages is something that VSCode/the LS Protocol will have to support eventually (I winced looking at the tickets relating to it -- not going to link because man it's long enough already -- but vscode issue 670 is a place to start to find a couple potential routes).
As for the coloring, it seems like TextMate/Sublime is sort of the standard, and so I tossed the same tmLanguage into CFEclipse, and used the tm4e plugin, which I think actually uses the (at least optimized) stuff you linked too.  I like the idea of everyone being able to use a standard for colorizing, but it is a monster syntax file.
I can see why you'd want to do the rendering on the client, but I don't see why we couldn't somehow use the same model for both doing stuff to/finding stuff in the code, and colorizing it.... probably just not thinking clearly because they all seem to use (basically) regex for the coloring, while keeping the model separate-- maybe it's fastest or something? (though with the cache... (hmm.  meh.  le shrug :-) ) )

If VSC's cfml matched what is in sublime, I'd move over to VSC. It's the only thing stopping me.
I don't want to sound like an a-hole talking about money - but I'd pay to get it ported over sooner rather than later. Definitely not as much as it's worth... I don't pretend to know the effort involved. Still it's important to my workflow and business, so the value is there, and I would happily contribute something. If anyone is interested, please get in touch with me.

I don't know about other people, but I find money motivating,and you the opposite of an a-hole.  :-) I think we could get the CFML to match what's in Sublime, but if you're looking for the multi-language editing that Sublime has, this will have to be addressed: https://github.com/Microsoft/vscode/issues/1751

Aren't so many of these editors based on Electron? Why/how do they all work differently?  I don't understand why ST3 handles this so well but VSC can't.
Also I'm bewildered by Atom being 500MB!

While proper language injection would be nice, it's not absolutely necessary. For right now at least, you can enable Emmet to work with the language and get some help that way at least, though I found it annoying especially in CFC files where you wouldn't have.
With a language server, though, if you can determine in what ranges each language is applicable, you should be able to delegate those requests to the appropriate other language server yourself -- HTML and CSS -- and have your language server act as a proxy in those instances.
As for client-side support, there seems to be support to some extent but I haven't been able to find details on how beyond Microsoft/vscode#11081 existing. Microsoft's own html grammar or php grammar could probably analyzed as well, but I'm just not familiar enough with the format. If you use the Developer: Inspect TM Scopes command on the respective files, you can see it transitions appropriately.

I'm starting to feel like VSC won't be my future website IDE. The ability to handle multiple languages in a single file is crucial. CFML being the most important to me.
Coda does it but has many bugs in other areas.
Sublime does it but the gui and overall community is lacking.
Its frustrating to think I'll have to spend $ on ST3 and the SFTP plugin and still be unsatisfied - whereas VSC is where I'd rather invest but seems to be a dead end.
Dreamweaver won't install.
Eclipse/aptana/cfbuilder are complete messes.
...
TGIF

Silly question maybe... VSC does html+css+js mixed just fine. Why cant we (excluding me) copy the html syntax and add all the cfml elements? Then we'd only be left with the challenges of SQL mixed, and cfscript mixed. I'm like that client you have that has no idea what he's talking about but makes it sound easy =)

I have checked different possibilities and decided to go the longer path and implement CFML language server based on CFParser. The source code will be available at https://github.com/ilich/vscode-languageserver-coldfusion repository. I also found out that Atom supports LSP as well. This is good since we will be able to port the extension for Atom as well. I know that that editor is also quite popular.

Editing a lot of old CF code ...
Does this issue imply that command+R would display the cffunction names in the CFC ? At present it says "No symbol information for the file"

Any update on this ?

Has anyone found the solution for outline view in .cfc|.cfm files.

Well actually, I kinda got it to work using....
https://marketplace.visualstudio.com/items?itemName=KamasamaK.vscode-cfml
And using this one for cfml syntax code highlighting
https://marketplace.visualstudio.com/items?itemName=SketchPunk.ColdFusion
When using this extension, the outline view goes away. Must be conflicting with something. https://marketplace.visualstudio.com/items?itemName=ilich8086.ColdFusion


Gossip: an online presentation tool inspired by impress.js

Thanks a lot for your guys to create impress.js, I like it very much 😘!
But during authoring presentation by impress.js, I found it difficult to make layout and choose the proper switch animation for each slides, so I use the word cloud algorithm to place each slides automatically and apply switch animation depend on the relationship between two slides before and after.
Furthermore, I also found a series of problem related to author and delivery presentation, so I create an online user interface called Gossip to solve them. [link][github]
I hope your guys like Gossip and give me some suggestions to improve it!

Thanks for sharing! Looks like an interesting approach.
If you want, you're welcome to add a link to your tool in the wiki: https://github.com/impress/impress.js/wiki/Examples-and-demos#authoring-tools
I have also authored a GUI authoring tool: https://github.com/henrikingo/impressionist But since I took over maintainership of impress.js itself, I haven't really had time to continue on Impressionist. So the space is still open for a great impress.js visual authoring tool!

Ok, I will add a link and take a look at impressionist :)


"Discontinuance" case type should not require trial dates

"Discontinuance" case type should not require trial dates. Hides trial date fields on claim form and turns off trial date validations.

:+1: merging for you because its awesome and you're busy


added support for using nodes as source

With this pull request I'd like to suggest adding the support for using --source node to external-dns. The use-case is as follows: I'm running an on-premise kubernetes cluster and bootstrap and decommission nodes on a regular basis. Bootstrapping new nodes is done almost completely automatic: new VM is created, an image is loaded that runs a predefined script to finish installation and join my cluster. However, as soon as my cluster wants to connect to the machine's API, it resolves its hostname and that's where it goes wrong: the hostname is not in DNS (yet).
The solution I came up with: delegate a subdomain to a PowerDNS deployment on my cluster and have external-dns handle nodes that join or leave. Currently, external-dns doesn't support using nodes as source, which this PR adds support for. This is still a PoC but I like to finish this PR with your guys input. I'm not sure how to implement some things:
What does it support:

using FQDN templates
have node's ExternalIP take preference over a node's InternalIP
using annotation filters
controllerAnnotationKey

Wat doesn't it support yet:

detecting if a node has already expanded its name to FQDN so the FQDN template shouldn't be applied again
FQDN template with multiple hostnames, not sure how to deal with this
support for hostnameAnnotation, does this even makes sense for a node?
combining FQDN template and annotations, related to the multiple hostname in FQDN template I had dilemma I had
support for the compatibility, is this still relevant?

My goal is to follow the expected behaviour of service and ingress sources the best as possible. I'd love to hear your thoughts about this!

If https://github.com/kubernetes-incubator/external-dns/pull/1212 is merged before this PR, I should respect that as well.

Also, in some of the ClusterRoles in docs/tutorials I think I should add the watch verb to nodes resources, right?

@njuettner perhaps you can share your opinion?

👍

👍🏽

@skoef Thank you. Works well for me.
One thing I've found during testing is that it doesn't leverage the support for multiple targets. My use case is that I would like to have a single DNS name which points to all node IPs.
For instance, you could annotate each of your nodes with a desired DNS name of my-cluster-nodes.example.com and ExternalDNS would create an A record for each of your nodes. This would allow you to discover your cluster nodes via DNS:
$ dig my-cluster-nodes.example.com
my-cluster-nodes.example.com. 4 IN	A	<IP_ADDRESS>
my-cluster-nodes.example.com. 4 IN	A	<IP_ADDRESS>
my-cluster-nodes.example.com. 4 IN	A	<IP_ADDRESS>

The same happens if you omit the annotation and rather use a static --fqdn-template=my-cluster-nodes.example.com.
The only thing you need to change is to aggregate Endpoints that have the same DNSName. Instead of returning one Endpoint per node you would instead add to an existing Endpoint's Targets slice if the DNSName was already introduced by another node.
I'm happy to test it out if you want to make that change.
Related: https://github.com/kubernetes-incubator/external-dns/issues/20

My thoughts on your open questions:

detecting if a node has already expanded its name to FQDN so the FQDN template shouldn't be applied again
I think the cluster operator should know and configure ExternalDNS correctly, e.g. if --fqdn-template is provided it gets applied. I guess there's also some if/else templating magic you could do inside of it.

FQDN template with multiple hostnames, not sure how to deal with this
I'm not sure how this can be configured in the first place.

support for hostnameAnnotation, does this even makes sense for a node?
yes, if you want to override the value provided by the template or to opt-in a node if no template is provided (similar to ServiceSource)

combining FQDN template and annotations, related to the multiple hostname in FQDN template I had dilemma I had
I think we can say that an annotation takes precedence over the template. You decide which annotations you honor on Node.

support for the compatibility, is this still relevant?
no, you can ignore that.

@skoef I created a PR for the multiple IPs feature I mentioned: https://github.com/skoef/external-dns/pull/1/files

I'm not sure how this can be configured in the first place.

I meant a template like {{.Name}}.fqdn.org,{{.Name}}.fqdn.com, but the same argument goes for that I guess: the cluster operator should be aware of what is configured.

support for hostnameAnnotation, does this even makes sense for a node?

yes, if you want to override the value provided by the template or to opt-in a node if no template is provided (similar to ServiceSource)

combining FQDN template and annotations, related to the multiple hostname in FQDN template I had dilemma I had

I think we can say that an annotation takes precedence over the template. You decide which annotations you honor on Node.

I think you're right, I'll implement these issues concerning annotations.

/lgtm
/cc @njuettner

I'm still implementing the support for hostnameAnnotations and combineFQDNAnnotation, should we wait for that or do we want to proceed with this initially?

/lgtm

However you prefer @skoef, we can also wait until you implemented it.

Let’s merge right away, I’ll take my time to properly implement the mentioned settings. At least that MR won’t be as big!
Thanks in advance!

/approve

@skoef Thank you!


LUCENE-10500: StringValueFacetCounts to not rely on sequential collection

StringValueFacetCounts should use the segment ordinal instead of the current index when looping through the matching hits, as when search is multi-threaded the order of the matching hits (one per segment) is not deterministic.

[x] I have reviewed the guidelines for How to Contribute and my code conforms to the standards described there to the best of my ability.
[x] I have created a Jira issue and added the issue ID to my pull request title.
[ ] I have given Lucene maintainers access to contribute to my PR branch. (optional but recommended)
[x] I have developed this patch against the main branch.
[x] I have run ./gradlew check.
[ ] I have added tests for my changes.

Oh no. Good find and thanks for fixing! (and apologies for slipping that bug in)

oh well if I had to apologize for every bug I committed... happy to help! Also good to see that using collector managers in tests helped uncover this.


Are those scripts and strong passphrase generation compatible with yubikey-luks ?

Hello.
This is a very simple question :
Do the way you compute the passphrase with the yubikey is the same as the "yubikey-luks" modules that we usually use to cypher the filesystem of an install under ubuntu ?
Meaning, can it be used to unlock standalone partition on removable medias for example, of backups of such luks partition of backup hard drive with the yubikey itself ?

Yes but only if you enable both CONCATENATE=1 and HASH=1 in yubikey-luks config.

Thank you for this precise answer. And when using the following default command line to enroll a yubikey on a LUKS partition, after installing the "yubikey-lusk" package with
sudo apt-get install yubikey-luks
without editing anything (Using its default configuration), and enrolling the yubikey with :
sudo yubikey-luks-enroll -d /dev/sda3 -s 7 command, is it the case ? Do those options Contatenate and Hash are set properly ?

No, both options I mentioned default to 0 so your passphrase isn't compatible with this project.

For unknown reasons, when installing the "yubikey luks" package as I did, the command yubikey-luks-open is not included.

What distro are you using? yubikey-luks-open  is available only in ubuntu 19.04 or debian 10. If you use older distro you may install it from there.

Hm, it seems that ubuntu/debian packages mistakenly install yubikey-luks-open to /usr/lib instead of /usr/bin which means you have to invoke it with full path like /usr/lib/yubikey-luks-open rather than yubikey-luks-open.

Thank a lot for all your precise explanations.
I've read the yubikey-luks package config file, and the default config sets those two variables to zero.
Meaning that the effective passphrase generated is just the output of the challenge function of the raw password. I could finaly mount the volume entering this string and it worked.
yubikey-luks folks could have included a small documentation explaining all this rapidely, that there are four different modes to generate the long passphrase from the challenge from the password.
And yes, the mode you propose by default for your driver is therefore the most secure because it generates the longest string.
Kind regards,
Frederic.


Is it possible to add multi line inline creation scripts for the compute instance

Hello. I was just wondering is there any guidance on providing a multiline inline creation script and if this is not possible is there any guidance on deploying a script to a jupyter notebooks file share for a machine learning workspace via ARM templates?
Thanks

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 130e7224-46aa-22c1-3cc3-96b2ed760bce
Version Independent ID: 24edf863-4af3-b10d-9f42-1e36238e1fb3
Content: Customize compute instance with a script (preview) - Azure Machine Learning
Content Source: articles/machine-learning/how-to-customize-compute-instance.md
Service: machine-learning
Sub-service: core
GitHub Login: @jesscioffi
Microsoft Alias: jcioffi

@VIPHercules
Thanks for your feedback! We will investigate and update as appropriate.

@VIPHercules
Could you please go through below link & following steps. It might be helpful.
https://learn.microsoft.com/en-us/azure/machine-learning/how-to-run-jupyter-notebooks
As for deploying a script to a Jupyter notebooks file share for a machine learning workspace via ARM templates, you can use the following steps:
1.Create a file share in the Azure portal.
2.Mount the file share to the compute instance.
3.Copy the script to the file share.
4.Run the script on the compute instance.
Otherwise, I'd recommend working closer with our support team via an [Azure support request] (https://docs.microsoft.com/en-us/azure/azure-portal/supportability/how-to-create-azure-support-request). Or you can leverage our Q&A forum by posting your issue there so our community, and MVPs can further assist you in troubleshooting this issue or finding potential workarounds.
[Teams Q&A forum] (https://docs.microsoft.com/en-us/answers/topics/46488/office-teams-windows-itpro.html) for technical questions about the configuration and administration of Microsoft Teams on Windows.
[Microsoft Teams Community forum] (https://answers.microsoft.com/en-us/msteams/forum?sort=LastReplyDate&dir=Desc&tab=All&status=all&mod=&modAge=&advFil=&postedAfter=&postedBefore=&threadType=All&isFilterExpanded=false&page=1

@VIPHercules
We are going to close this thread as resolved but if there are any further questions regarding the documentation, please tag me in your reply and we will be happy to continue the conversation.


Handling null values

fixes #63
Previously nulls were converted to empty spaces. This PR undoes that so the results will be equivalent to bigquery's handling of nulls

For the sake of completeness, can you please include the result of running the query in the aforementioned issue after this update?

For the sake of completeness, can you please include the result of running the query in the aforementioned issue after this update?

Sure..


Tray icon bug

So I found an annoying bug. If I left click to the Tray icon, SpotifyXP will stop update album art and song info, and always retain the the album art and info of the last song before left-clicking the Tray icon.. Need relaunch an app to fix this.

Ok good to know

Worked for me, thanks!


Fix bugs in decompose, found by cargo fuzz

Fix decompose to compute the decomposition with a method that following the CR paper more exactly, and also following the documentation and comments in the code better (since those come from the papers).
Decompose was stripping prefixes much too eagerly. An example is in one of the basics tests. Given a pattern aaabaaabaaabaabbbb, it is now factorized into a, aabaaabaaabaabbbb and it satisfies the rules for a decomposition.
There aren't too many changes in this PR, if we look at the algorithm and disregard the testing code. The PR changes decompose and hrp.
One good thing is that none of these examples passed the debug assertions in the implementation; they could only ever produce wrong answers in release mode, if that is any consolation.

How to reproduce finding the bug with cargo fuzz

Check out a revision that is buggy

Run the fibwords dict generator cargo test -- --ignored generate

Run ./fuzz/run_known_substring_debug.sh  -dict=dict-fibwords

thread '<unnamed>' panicked at 'Factorization u, v = 10 , 68 is not k-simple because
                    v's 3-HRP1 is Hrp { period: 3, len: 9 } and 3-HRP2 is Hrp { period: 13, len: 40 }', src/lib.rs:394:12


Move to pyproject_toml + package cleanup

This is a very large PR that began with a simple goal of moving the project over to pyproject TOML standard. Due to continued issues with failing CI jobs because of things like upper pins on old packages, dependencies on deprecated packages (theano), failing mpi tests, among other things; the PR became much more complicated. A rough list of improvements are the following:

Moved to pyproject.toml standard
Refactor package to generally recommended src layout
Moved build to CMake + scikit-build-core
Support for more recent pythons (3.12), 3.13 is limited by TF support now
Building wheels now on all major platforms (linux, macos ARM/x64, and windows)
MPI tests are marked now and run in separate process using a slightly modified fork of https://github.com/minrk/pytest-mpiexec
Removed almost all upper pins on packages, only TF probability remains.
Conda packages building on linux and mac using mamba build, no windows here because conda-forge TF support on windows seems gone now
Removed Theano as a dependency by porting ssrm to use tensforflow instead for differentiation. Tests pass but probably someone should look at this code more carefully to make sure nothing is broken.
Fixed a large number of warnings all throughout the code
Probably some other small things I am forgetting.

I still think there is considerable work to be done in cleaning up the pr-check.sh, run-tests.sh, and run-checks.sh scripts. Probably better to move these to github actions workflows or something so we can run them on windows. Currently, windows checks are just running pytest.

Hey @mihaic , I think this one is ready, let me know what you think. della_notebooks run needs to be fixed. I will do another PR for it though.


Job killed “extract_forceconstants”

Hello, dear developer, I've been using your software for silicon testing and encountered an issue where my work frequently ends in an unexpected manner. This usually happens when executing the command "extract_forceconstants -rc2 5". Could you please advise on what might be causing this issue?
extract_forceconstants -rc2 5
... reading unitcell
... min cutoff: 2.37032
... max cutoff: 8.20277
DETERMINING SYMMETRY OF INTERACTION TENSORS
... constructed distance tables (0.02471s)
... built singlets
... built pairs
... built prototype tuplets (0.00037s)
... expanded symmetry operations (0.16686s)
... reducing pairs                     100.0% |========================================|  0.00020s
... mapping pairs                      100.0% |========================================|  0.02164s
N singlet shells:           1
shell:  1   8
N pair shells:           4
shell:           1           8   0.0000000000000000
shell:           2          32   2.3679512299170984
shell:           3          96   3.8668481660618292
shell:           4          96   4.5342813947351832
... determined singlet nullspace
... determined pair nullspace
... determined dielectric tensor nullspace
... determined Born charge nullspace
Interactions:
firstorder forceconstant:           0           0
secondorder forceconstant:           4          10
thirdorder forceconstant:           0           0
fourthorder forceconstant:           0           0
dielectric constant:           0           0
dielectric singlet:           1           1
dielectric pair:           0           0
born effective charge singlet:           0           0
born effective charge pair:           0           0
born effective charge triplet:           0           0
GENERATING CONSTRAINTS
... 0 secondorder constraints (0.00142s)
... created 0 constraints (0.00146s)
... got constraints in 0.00147s
READING SIMULATION FROM FILE
... made space and decided on heuristics
... reading simulation                  100.0% |========================================|  11.58603s
... got displacements
... short summary of simulation:
number of atoms: 216
number of configurations: 19500
average temperature (K): 299.71302
thermostat set to (K): 300.00000
average pressure (GPa): 0.13303
average stresstensor xx xy xz (GPa):       0.1377      -0.0035       0.0027
average stresstensor yx yy yz (GPa):      -0.0035       0.1217       0.0122
average stresstensor zx zy zz (GPa):       0.0027       0.0122       0.1397
... finished reading simulation (11.97897s)
REPORT GRADE OF OVERDETERMINATION
total number of equations:     12636000
number of FC up 2. order:           10   --> overdetermination ratio:    1263600.0
SOLVING FOR INTERACTION TENSORS
... distributed data
... no polar interactions to worry about
Killed

Please reduce the number of samples included in the fit, e.g., via the --stride option


Crashes when sorting fragment tree from different directory without -q option.

When creating an analysis tree from a fragment tree in a different directory and keeping grsisort open after sorting, grsisort crashes (segmentation violation) on line 96 of TGRSIint.cxx (printf("\tfile %s opened as _file%i\n",file->GetName(),x); ) (file is NULL).
Example command:
grsisort -al test/fragment02131_000.root
I suspect that the directory needs to be removed from the call in line 95:
TFile file = (TFile)gROOT->FindObject(TGRSIOptions::GetInputRoot().at(x).c_str());

I can't reproduce that issue on nessa (CentOS 6, root 5.34/24) using the multiset branch. I do get the same error using root 6.04/00 though. I'll see if I can find what causes this.

I fixed the issue with #598. I don't know why gROOT->FindObject("") fails, but using gROOT->GetListOfFiles()->FindObject("") works.

Please check that this works for you as well, @gdemand, I've only tested this on nessa, not on Mac OS.

Fixed it for me - thanks!


Implemented small Metal abstractions and make the FFT POC usable

Implemented small Metal abstractions and make the FFT POC usable
Description
This is a follow-up for #190 aiming to structure the gpu crate and to implement a small set of Metal abstractions and a API that wraps around these for making the FFT POC usable. A second goal is to pave the way for future features, like parallel bit-reverse permutation, different FFT algorithms (orderings and radixes) and implementations in other platforms like CUDA.
Type of change

[x] New feature

Checklist

[ ] Unit tests added
[ ] This change requires new documentation.

[ ] Documentation has been added/updated.

I have added the same comments to the opened PR. These can be disregarded if fixed there PR #190

Codecov Report

Merging #193 (078ab00) into main (337225b) will increase coverage by 2.71%.
The diff coverage is 8.33%.

@@            Coverage Diff             @@
##             main     #193      +/-   ##
==========================================
+ Coverage   92.28%   94.99%   +2.71%
==========================================
  Files          66       64       -2
  Lines        7244     7037     -207
==========================================
  Hits         6685     6685
+ Misses        559      352     -207

Impacted Files
Coverage Δ

math/src/field/traits.rs
91.78% <0.00%> (-1.28%)
:arrow_down:

math/src/polynomial.rs
97.58% <0.00%> (-1.72%)
:arrow_down:

gpu/src/lib.rs
100.00% <100.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


adding files does not write CMakeLists.txt

I am trying to learn programming and i have a project dir and a build dir. This is how my setup looks like.
(require 'rtags)
(cmake-ide-setup)

(setq cmake-ide-build-dir "/Users/dev/my-sandbox/C/cmake-ide/build/")
(setq cmake-ide-rdm-executable "/usr/local/bin/rdm")
(setq cmake-ide-build-pool-dir "/Users/dev/my-sandbox/C/cmake-ide/build/")
(setq cmake-ide-build-pool-use-persistent-naming t)
(setq cmake-ide-project-dir "/Users/dev/my-sandbox/c/cmake-ide/")

Whenever i save a file on the project directory, it looks like it runs rtags but it never appends the buffer-name to the CMakelists.txt.
Am i missing something or is this not how its suppose to work?
Thanks,

That's only supposed to work if the CMakeLists.txt file adds source files by globbing, instead of individually. That's way too much work to implement and I actually don't know why anyone would want to manually list source files.

Globing files is problematic if you use git-bisect or work with others, see: https://stackoverflow.com/a/18538444/432509
Think this should be closed, if you manually list source files, manually adding to CMakeLists.txt is expected.

I disagree with globbing being problematic - I think it's crazy to add files manually.  But yes, this should be closed.

Globbing is fine as long as everyone remembers to manually re-run cmake when files are added/removed. (when bisecting, switching branches - etc)


How to fix non unique GroupKeys?

Background
GroupKey is a string that is derived from the matchers in the route (including any parent routes) and the labels in the group_by of the matching route.
There are a number of cases where GroupKey is not unique and its possible for two (or more) different groups to have the same GroupKey. The following YAML shows a configuration containing two routes that create groups with the same GroupKey:
receivers:
  - name: test1
  - name: test2
route:
  receiver: test1
  routes:
    - receiver: test1
      matchers:
        - foo=bar
    - receiver: test2
      matchers:
        - foo=bar
      mute_time_intervals:
        - name: weekends

The reason a user might have such a configuration is to mute notifications on the weekends, but still send webhooks to an issue tracker.
Problems
This creates a number of problems:

In the case the receiver is also the same, then groups from these routes also share notification logs.
If we want to use the GroupKey to mark groups (e.g. mute status) (#3513) then active groups can be incorrectly marked as muted.

Solutions
I've been thinking on the issue of the GroupKey being non-unique for a little while, and if its possible to make the GroupKey both stable and unique without adding new fields to the configuration file.
What do I mean by stable? I mean that the GroupKey should not depend on the position of the route relative to its siblings. This is the reason why we cannot use the RouteID when calculating the GroupKey, because as soon as the route is moved higher or lower in the configuration file the group's notification log is invalidated causing repeat notifications.
One option we have is to use a non cryptographic hash function (for example fnv) to calculate a hash using extra metadata from the route that is not included in the GroupKey at present. For example:

Receiver name
Mute time intervals
Active time intervals
Child routes

This would change how GroupKey is calculated from being a top-down path of routes from parent to child (i.e. route0/route1/route...N/groupLabels) to a bottom-up Merkle tree where the parents are derived from the hash of their children.
This means that when either the receiver, matchers, group by labels or active or mute time intervals are changed in a child route, the notification logs for the parent upwards are invalidated. This might be undesirable. The other issue I see with this solution is observability. Without adequate tools, it will be very hard to see which group is flushed in the logs just from its hash.
So perhaps it's better to just add an (optional) name to routes? If the name is absent, then Alertmanager uses the current mechanism (which can be non unique in some cases). If a unique GroupKey is required, then a name can be set on the route to discriminate between them.

Another option is to add the receiver name to the RouteKey. This would be the least invasive change and fixes all but one case of non unique GroupKeys where the receiver name, matchers and group by are the same. In this case, the aggregation groups also share nflogs, even if some of the routes have active or mute time intervals.
Here is an example of how this could look for the following configuration file:
receivers:
  - name: test1
  - name: test2
route:
  receiver: test1
  routes:
    - receiver: test1
      matchers:
        - foo=bar
    - receiver: test2
      matchers:
        - foo=bar
      mute_time_intervals:
        - name: weekends

Without the change:
{}/{foo="bar"}:{}
{}/{foo="bar"}:{}

With the change:
(recv="test1",matchers={})/(recv=test1,matchers={foo="bar"}):{}
(recv="test1",matchers={})/(recv=test2,matchers={foo="bar"}):{}

This could also be shortened to something like:
(test1,{})/(test1,{foo="bar"}):{}
(test1,{})/(test2,{foo="bar"}):{}

Any chance the example needs to have a "continue" to match the second route?

Yes it does :) I missed that in the example!

Yes it does :) I missed that in the example!

What if we don't attempt to fix this without requiring extra configuration? What if a future version of AM refuses to accept a config where both GroupKey and Receiver are identical for two siblings? What is the users intention in creating such config?
We could offer a user a way to differentiate these two routes (extraGroupKey: newRoute)

What if we don't attempt to fix this without requiring extra configuration? What if a future version of AM refuses to accept a config where both GroupKey and Receiver are identical for two siblings?

This is something that I've considered too. In some respect I like it a lot because it means we don't need to add extra configuration, but I'm also concerned about breaking configurations.

We could offer a user a way to differentiate these two routes

If we choose this option I propose adding a "name" field to the route, similar to what we have for receivers.

What if we don't attempt to fix this without requiring extra configuration? What if a future version of AM refuses to accept a config where both GroupKey and Receiver are identical for two siblings?

This is something that I've considered too. I like it a lot because it means we don't need to add extra configuration, but I'm also concerned about breaking configurations.

We could offer a user a way to differentiate these two routes

If we choose this option I propose adding a "name" field to the route, similar to what we have for receivers.

Can we add a deduplication key instead? The default Pagerduty receiver has it. Something similar seems easier to create than keeping track of the intricacies of how hashed values from other fields track over time/user changes on configuration.

Can we add a deduplication key instead? The default Pagerduty receiver has it. Something similar seems easier to create than keeping track of the intricacies of how hashed values from other fields track over time/user changes on configuration.

Yeah that's one of the options (named routes).


Ensure JSON schema files in Aspire component packages provide a description for all declared nodes

When component packages provide JSON schema, they should ensure they're providing a meaningful description for every node in the configuration schema, so that a good UX is provided to users in the JSON editor. For example, if all Aspire contribute schema under a root "Aspire" node, e.g. "Aspire": { "Caching": { "Redis": ..., they should all be defining the "Aspire" node with the same description. The tooling will simply take the last description it found for a node based on all the schema parts contributed by packages, so ensuring they're all aligned will provide a consistent UX.

@DamianEdwards - do you think this is necessary for 8.0?
With the generator, the starting path is provided in the assembly level attribute:
https://github.com/dotnet/aspire/blob/fc1dd495456cea3c1b0cf583c05fd18e3052a3f2/src/Components/Aspire.StackExchange.Redis/AssemblyInfo.cs#L8-L9
We can have a set of common descriptions and pass them in here. I'm just not sure how much value this will provide. The only thing missing today is the top few namespaces Aspire and StackExchange in the case above. The Redis section has description:
https://github.com/dotnet/aspire/blob/fc1dd495456cea3c1b0cf583c05fd18e3052a3f2/src/Components/Aspire.StackExchange.Redis/ConfigurationSchema.json#L181

Could we do it by having multiple schema files in the packages, split by "level"? So we can have a central schema file defined for the "Aspire" node, which is configured into all our packages by our tool/build process, and if desired we can do so for intermediate levels.

This doesn't seem like a ship-stopping issue. Moving to 8.1.


Test dice up vacio

cambiamos status por hasended
si no termino el juego, preguntar por winner lanza error + test
-Test  si la nave se pasa del board, su posicion sea la ultima del mismo

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

12 of 15 (80.0%)  changed or added relevant lines in 2 files are covered.
12 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-7.7%) to 92.308%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

repository/IngSoft2-Model/LaScalonetaGame.class.st
11
14
78.57%

Files with Coverage Reduction
New Missed Lines
%

repository/IngSoft2-Model/LaScalonetaGame.class.st
12
84.85%

Totals

Change from base Build<PHONE_NUMBER>:
-7.7%

Covered Lines:
180

Relevant Lines:
195

💛  - Coveralls


"skipDuplicates" and "retries" configs are incompatible

Hello,
When the skipDuplicates config is enabled, the library won't retry in case of failure. So the retries config won't be fulfilled. In case of a retry, the skipDuplicates should not be considered, do you agree?
There is a second issue with these settings, the options.callback won't even be called as the call to self.queue will be skipped in the code of  Crawler.prototype._onContent.
        if (options.retries) {
            setTimeout(function() {
                options.retries--;
                self.queue(options);
                options.release();
            },options.retryTimeout);
        } else{
            options.callback(error,{options:options},options.release);
        }

        return;

What's the proper way to handle this case, allow to retry or call the options.callback when skipDuplicates is enabled?
Thanks!

Hey, It seems a bug in crawler, I suggest you to handle by yourself in callback before queue ,  use seenreq. I'll also fix it as soon as possible. Many thanks!

I'm now trying to fix this bug, we know that some bad things will happen, thus we suggest as in README that better to handle by developers. It seems quite deep and the complexity beyond my expectation in the source code, so I'm wondering that refactor the code first and maybe we should discuss again to determine if we should keep it. Pls keep you attention on this issue.

My workaround for testing was the following diff, I don't know if it could become a fix
--- a/lib/crawler.js
+++ b/lib/crawler.js
@@ -357,6 +357,7 @@ Crawler.prototype._onContent = function _onContent (error, options, response) {
            (options.uri||options.url)+(options.retries?' ('+options.retries+' retries left)':''));

         if (options.retries) {
+            self.options.skipDuplicates = false;
             setTimeout(function() {
                 options.retries--;
                 self.queue(options);

Good job thomas, I think it could be a solution, though the options may be ambiguous. I suggest you create a pull request and fix first before the refactor project. Last but not least, thank you for your idea.

This breaks the skipDuplicates option.
Now there is the problem after the first request fails, the option skipDuplicates is permanently set to false for all following requests.

I think this is the right solution
--- a/lib/crawler.js
+++ b/lib/crawler.js
@@ -215,7 +215,7 @@
        self._buildHttpRequest(options);
 };

-Crawler.prototype.queue = function queue (options) {
+Crawler.prototype.queue = function queue (options, force) {
        var self = this;

        // Did you get a single object or string? Make it compatible.
@@ -229,12 +229,13 @@
                        continue;
                }
                self._pushToQueue(
-                       _.isString(options[i]) ? {uri: options[i]} : options[i]
+                       _.isString(options[i]) ? {uri: options[i]} : options[i],
+                       force
                );
        }
 };

-Crawler.prototype._pushToQueue = function _pushToQueue (options) {
+Crawler.prototype._pushToQueue = function _pushToQueue (options, force) {
        var self = this;

        // you can use jquery or jQuery
@@ -248,7 +249,7 @@
        self.globalOnlyOptions.forEach(globalOnlyOption=>delete options[globalOnlyOption]);

        // If duplicate skipping is enabled, avoid queueing entirely for URLs we already crawled
-       if (self.options.skipDuplicates && self.seen.exists(options, options.seenreq)) {
+       if (self.options.skipDuplicates && self.seen.exists(options, options.seenreq) && force !== true) {
                return;
        }

@@ -356,10 +357,9 @@
                log('error','Error '+error+' when fetching '+ (options.uri||options.url)+(options.retries?' ('+options.retries+' retries left)':''));

                if (options.retries) {
-                       self.options.skipDuplicates = false;
                        setTimeout(function() {
                                options.retries--;
-                               self.queue(options);
+                               self.queue(options, true);
                                options.release();
                        },options.retryTimeout);
                } else{

@Hackebein Thank you so much and you're right. but it's much more complicate of your solution. Let's keep the API simple and clean to ensure it is maintainable.

@mike442144 Error handling is complex, thats right. Code that changes the users selected options for error handling is in many ways wrong! Set skipDuplicates = false is not clean and not maintainable. If you leave the line in its place you can't support any error with skipDuplicates = true. My pull request breaks nothing. I tested this solution for 2 weeks in differend projects.

 Let's reopen the issue and have more discussions.

Fix it use _schedule rather than .queue .

@mike442144 This somehow seems to leak millions of duplicate urls in the queue causing them crawled more than once on site which only has few thousand of pages when skipDuplicates is enabled.


fix[build shared bug]: shared build fails on Mac OS X as ssl needs li…

…bcrypto symbols hence needs to depend from libcrypto.
Please do not send pull requests to the BoringSSL repository.
We do, however, take contributions gladly.
See https://boringssl.googlesource.com/boringssl/+/master/CONTRIBUTING.md
Thanks!

Stop spamming me! Check your mail list. I shouldn't be there!
On Fri., Feb. 5, 2021, 9:23 a.m. Loïc Touraine<EMAIL_ADDRESS>wrote:

Closed #18 https://github.com/google/boringssl/pull/18.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/google/boringssl/pull/18#event-4296328175, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AJDKUMVN4ELNOSIASQ43VM3S5P5MTANCNFSM4XEWUMEQ
.

@leonidgurevich please see your GitHub settings or unsubscribe link in the notification email. You're probably watching this repo which is why you're getting notified.
@Firefly35 I not quite sure what you're trying to do, but you're repeatedly opening and closing this issue (and another). I've set a temporary limit on this repo to avoid the notification flood.


Simplify PMO deploy

Ideally, it could look something like:
previously in the CI section
donejs add travis
Then in the Deploy section:
static hosting on firebase

Sign up for firebase
Run donejs add firebase <app-name> ... this installs the firebase deploy, updates package.json.

remaining steps are the same.
Deploy your node code

Download heroku toolbelt, login/create.
donejs add heroku <heroku-app-name> - configs heroku, creates proc file.
update procfile to add proxy.
remaining steps are the same

Continuous Deploy

donejs add travis-to-heroku
donejs add travis-to-firebase

Ideally those could run travis-encrypt in the right way to fill out .travis.yml.

@justinbmeyer @phillipskevin Seeing if you all think this is worth doing. It would surely make doing the PMO guide easier but would likely take a while to do as it is adding 4 new generators that we haven't made yet.

I think this is worth doing. I do not think this is worth doing prior to releasing 1.0.

We are deferring this to 1.1-ish.

@m-mujica Link to this issue when you do the guide updates for this.


Please provide urlencode (URL encode) functions

Is your feature request related to a problem? Please describe.
I want to make a JDBC URL from Vault secrets with the Banzai Cloud template engine.
Describe the solution you'd like
I'm trying to do something like:
apiVersion: v1
kind: ConfigMap
metadata:
  name: test-db-configmap
  annotations:
    # vault.security.banzaicloud.io settings
data:
  jdbc: postgresql://foo.bar.svc:5432/mydb?user=${vault:secret/database/test#username}&password=${vault:secret/database/test#password}

However, my password contains some special characters, so the whole JDBC URL is not a safe URL.
I searched the available functions, but didn't see one that can do urlencode.
Describe alternatives you've considered
I may have to do some extra post-processing for the unsafe JDBC URL.

Hi! A per this and this issue, unfortunately there is no urlencode function in Sprig yet, but did you check out the urlquery Go template function? Maybe something like this would work for you: example

Well, this is not that straightforward than I initially thought it would be, but I am on the problem!

Thank you @akijakya!

Hi @johnlinp, @bonifaido created a fix for this issue (see the linked PR), after merge & release it should work like this:
data:
  jdbc: postgresql://foo.bar.svc:5432/mydb?user=postgres&password=${vault:secret/database/test#${.password | urlquery}}


MapView annotation press event

I couldn't find anything about MapView press event.
Should I create custom component?

It looks like this isn't possible yet, do you want to try to implement it? See: http://stackoverflow.com/a/15297919/659988
Something like this on RCTMapManager.m (the delegate):
- (void)mapView:(MKMapView *)mapView didSelectAnnotationView:(MKAnnotationView *)view
{
    // Dispatch event through React stack
}

@brentvatne I tried my luck and implemented didSelectAnnotationView. Before opening a pull request I'ld like to know if this has been implemented the correct way since it is my first time hacking on react-native - https://github.com/facebook/react-native/compare/master...dvcrn:on-annotation-press
Though the question comes into my head how useful this is. My implementation only gives the marker long, lat, title and subtitle. With this alone, you can't really identify which marker in particular has been pressed.
Nevertheless, let me know how to proceed with this :)

@dvcrn - Nice one! Closing so we can track this in the PR


tile initialize and re-initialize needs to dynamically respond to the amount of drivable area in the underlying FOV

when running tile initialize naively, initialize will fail or potentially take a very long time initializing in areas with little drivable area.  the density should be scaled proportionally to driveable area

This is something Berend and I discussed before and came to the same conclusion as the fix. The constraints will be that this will be on the client side with all of the design implications therein. That being said, @ruinixu were discussing it a moment ago and came to 2 solutions:

Quick and dirty: From the birdview image in location_info endpoint, per map tile, we can average the colour of every pixel to get a rough idea of how much road surface is present to determine the number of agents requested from the API (or to just not call INITIALIZE at all if 0).
More accurate but longer development: From the osm map acquired from locaction_info endpoint, calculate the percentage "spawnable area" per agent type per tile for similar number of vehicles request scaling. The reason this will take a bit longer to pull off is due to the need to familiarize with the OSM data format.


#174: fix ng9 compatibility

PR Checklist
Please check if your PR fulfills the following requirements:

[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

PR Type
What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

i am trying to fork compatilplity in my own repo.


Android build error when using Mapbox V10

Environment

Dev OS: MacOS 12.6

Steps to reproduce

I am building a RN app and am having issues running the Android build with Mapbox V10, the build fails when I try to run  it with yarn android or when I try to build it in Android Studio.
The error I am getting is the following:
 > 2 files found with path 'lib/arm64-v8a/libc++_shared.so' from inputs:
      - /Users/MJ/.gradle/caches/transforms-3/52dc46a592dc383805ce46fda8bdc1a4/transformed/jetified-react-native-0.70.1-debug/jni/arm64-v8a/libc++_shared.so
      - /Users/MJ/.gradle/caches/transforms-3/fdbc7f140d88eddac6969e3c2b95c806/transformed/jetified-common-23.0.0/jni/arm64-v8a/libc++_shared.so
     If you are using jniLibs and CMake IMPORTED targets, see
     https://developer.android.com/r/tools/jniLibs-vs-imported-targets

Here is my build.gradle setup:
// Top-level build file where you can add configuration options common to all sub-projects/modules.

buildscript {
    ext {
        buildToolsVersion = "31.0.0"
        minSdkVersion = 21
        compileSdkVersion = 31
        targetSdkVersion = 31

        if (System.properties['os.arch'] == "aarch64") {
            // For M1 Users we need to use the NDK 24 which added support for aarch64
            ndkVersion = "24.0.8215888"
        } else {
            // Otherwise we default to the side-by-side NDK version from AGP.
            ndkVersion = "21.4.7075529"
        }

        RNMapboxMapsImpl = "mapbox" // required for v10

    }
    repositories {
        google()
        mavenCentral()
    }
    dependencies {
        classpath("com.android.tools.build:gradle:7.2.1")
        classpath("com.facebook.react:react-native-gradle-plugin")
        classpath("de.undercouch:gradle-download-task:5.0.1")
        // NOTE: Do not place your application dependencies here; they belong
        // in the individual module build.gradle files
    }
}

allprojects {
    repositories {
        maven {
            // All of React Native (JS, Obj-C sources, Android binaries) is installed from npm
            url("$rootDir/../node_modules/react-native/android")
        }
        maven {
            // Android JSC is installed from npm
            url("$rootDir/../node_modules/jsc-android/dist")
        }
        mavenCentral {
            // We don't want to fetch react-native from Maven Central as there are
            // older versions over there.
            content {
                excludeGroup "com.facebook.react"
            }
        }
        google()
        maven { url 'https://www.jitpack.io' }
        maven {
            url 'https://api.mapbox.com/downloads/v2/releases/maven'
            authentication {
                basic(BasicAuthentication)
            }
            credentials {
                // Do not change the username below.
                // This should always be `mapbox` (not your username).
                username = 'mapbox'
                // Use the secret token you stored in gradle.properties as the password
                password = project.properties["MAPBOX_DOWNLOADS_TOKEN"] ?: ""
            }
        }
    }
}

When I comment out the the mapbox lines the build is successful, although the map does not work on the app (which is expected), hence why I am posting for any assistance here. Thank you.

Pls check the guide https://github.com/rnmapbox/maps/blob/main/android/install.md#android-installation,
there is a section with:

If you see 2 files found with path 'lib/arm64-v8a/libc++_shared.so' from inputs issue see possible workaround.


[Snyk] Upgrade io.reactivex.rxjava3:rxjava from 3.1.8 to 3.1.9

Snyk has created this PR to upgrade io.reactivex.rxjava3:rxjava from 3.1.8 to 3.1.9.
:information_source: Keep your dependencies up-to-date. This makes it easier to fix existing vulnerabilities and to more quickly identify and fix newly disclosed vulnerabilities when they affect your project.

The recommended version is 1 version ahead of your current version.

The recommended version was released on 24 days ago.

[!IMPORTANT]

Check the changes in this PR to ensure they won't cause issues with your project.
This PR was automatically created by Snyk using the credentials of a real user.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open upgrade PRs.
For more information:

🧐 View latest project report
📜 Customise PR templates
🛠 Adjust upgrade PR settings
🔕 Ignore this dependency or unsubscribe from future upgrade PRs

Upgrade the package version in this PR : https://github.com/contentstack/contentstack-java/pull/149.


Support dirty-chai

Not sure how feasible this one is, considering it has to run before any other plugins, but it would be nice to support dirty-chai.

@Vassi while I'm not a huge fan of dirty-chai I would most likely accept pull requests that implement optional support for dirty-chai. I don't see any immediate blockers right now for implementing such a PR, but I won't put any work in this myself.


release wheel package too

Thanks!

Development moved to https://github.com/pytest-dev/pytest-env


cloudflare dns is not getting added

go version : go version go1.15.2 linux/amd64
xcaddy build works for cloudflare
$ xcaddy build --with github.com/caddy-dns/cloudflare

2020/10/04 00:59:23 [INFO] Temporary folder: /tmp/buildenv_2020-10-04-0059.352150349
2020/10/04 00:59:23 [INFO] Writing main module: /tmp/buildenv_2020-10-04-0059.352150349/main.go
2020/10/04 00:59:23 [INFO] Initializing Go module
2020/10/04 00:59:23 [INFO] exec (timeout=10s): /usr/local/go/bin/go mod init caddy
go: creating new go.mod: module caddy
2020/10/04 00:59:23 [INFO] Pinning versions
2020/10/04 00:59:23 [INFO] exec (timeout=0s): /usr/local/go/bin/go get -d -v github.com/caddyserver/caddy/v2
go: github.com/caddyserver/caddy/v2 upgrade => v2.2.0
2020/10/04 00:59:24 [INFO] exec (timeout=0s): /usr/local/go/bin/go get -d -v github.com/caddy-dns/cloudflare
go: github.com/caddy-dns/cloudflare upgrade => v0.0.0-20200811180534-4494da72fa56
2020/10/04 00:59:24 [INFO] Build environment ready
2020/10/04 00:59:24 [INFO] Building Caddy
2020/10/04 00:59:24 [INFO] exec (timeout=0s): /usr/local/go/bin/go build -o /home/<user>/caddy -ldflags -w -s -trimpath
2020/10/04 00:59:25 [INFO] Build complete: caddy
2020/10/04 00:59:25 [INFO] Cleaning up temporary folder: /tmp/buildenv_2020-10-04-0059.352150349

the list modules command is not working and throws an error
$ xcaddy list-modules

go list -m: not using modules
2020/10/04 01:01:26 [ERROR] exec [go list -m]: exit status 1:

so the module doesn't get added when I add dns cloudflare {API} in Caddyfile
run: adapting config using caddyfile: parsing caddyfile tokens for 'tls': /etc/caddy/Caddyfile:35 - Error during parsing: getting DNS provider module named 'cloudflare': module not registered: dns.providers.cloudflare

xcaddy build and xcaddy * do different things (please check the readme). Once you have built the binary please be sure you run it, instead of xcaddy.


Ignore flag is ignored in feature branch.

Limited to the in-development feature branch. Needs to be fixed, before merging into main for release.

Also, this was not picked up by any existing unit test.


CWPool: handle code id

          Do we need to store the code_id? It can be retrieved from the ContractInfo (using the addr) once the contract is instantiated.

Originally posted by @nicolaslara in https://github.com/osmosis-labs/osmosis/pull/4764#discussion_r1150560500

resolved


Java Template: json schema union is generated as object

Describe the bug
In our schema, we have multiple types, that are nullable types, like a string.
Eg.
          username:
            type: [ "string", "null" ]
            description: The username of the user that sent this message

What we expected would happen:
private String username;
What we got
private Object username;
How to Reproduce
We generate our file like this:
const generator = new JavaFileGenerator({
  collectionType: 'List',
  presets: [
    {
      preset: JAVA_COMMON_PRESET,
      options: {
        equals: true,
        hashCode: true,
        classToString: true,
      },
    },
    JAVA_CONSTRAINTS_PRESET,
    JAVA_JACKSON_PRESET,
    JAVA_DESCRIPTION_PRESET,
  ],
});

(async () => {
  const asyncDoc = readFileSync(schemaFile, 'utf8');
    const parsedDoc = await parser.parse(asyncDoc);
  await generator.generateToFiles(parsedDoc, outDirectory, {
    packageName: rootPackage,
  });

  //Temp fix:
  /*
   * We replace the union of nulls, with just the object, because currently the code generation turns it into objects, instead of string or boolean etc.
   */
  //const parsedDoc = await parser.parse(
  //  asyncDoc.replace(/\[(?: ?null" ?,)? ?("\w+")(?: ?, ?"null")? ?]/g, '$1')
  //);
  //await generator.generateToFiles(parsedDoc, outDirectory, {
  //  packageName: rootPackage,
  //});
})();

Expected behavior
Making a string nullable, should leave it as a java String, instead of turning it into an object.

@RobinGoussey Hello! Do you wanna create fix for that? It should be fixed here in this place https://github.com/asyncapi/modelina/blob/master/src/generators/java/JavaRenderer.ts#L56

@jonaslagoni
The behaviour of
            type: [ "string", "integer", "null" ]

should not have changed, and will thus be an object[]. Which is the behavior it had before. As in test test('Should render mismatching tuple types as Object', () => { in JavaRenderer.spec.ts

should not have changed, and is still object[]. Which is the behavior it had before. As in test test('Should render mismatching tuple types as Object', () => { in JavaRenderer.spec.ts

I know, I just want to make sure that the upcoming change will work as "expected". So just want to dig a bit deeper 🙂

I have no clue on what will happen if the upcoming changes, and my PR come together. I hadn't really considered the uniion of 2 types + nullable. As I think currently in Java, all types are nullable.
So maybe I need to rework, but how do I best do this then? Do I create merge your branch into mine, and create a PR to your branch?

So maybe I need to rework, but how do I best do this then? Do I create merge your branch into mine, and create a PR to your branch?

You don't have to worry about the next branch, ill make sure to adapt it appropriately 🙂 I will take a look at the PR later today or tomorrow 👍

Still relevant.


End of game: Debrief not appearing after score phase.

[ ] Change copy to say "Play again" or "End game"
[ ] Change button to redirect players to lobby screen

Currently this button just sends players to an empty round screen

verified this is happening after selecting "go to next round button".

fixed!


query parameters in src url

Describe the bug
Could not stat file. This shows up when i try to use D:\IdeaProjects\LaudyNetwork\NetworkUtils\src\main\resources\export?languages=en&format=JSON&zip=false. The Error says that it cannot access the output directory
Sample build script
https://pastes.dev/10ZjnAV60O

I'm sorry but I cannot reproduce this issue with your sample build script. If I execute it as is, I get an error regarding an empty eachFile block because there's only one source specified (An 'eachFile' action can only be added if multiple sources are provided.). If I comment this block out, I get an HTTP 403 error, just like I get when I open the URL in my web browser.
It seems to me your build script is either broken or everything works as it should. If you can provide more information, I'd be more than happy to help.

i use now kotlin's native file download


Web Payments API update.

Changed the existence check that specifically excluded non-Android
platforms. Will now be based entirely on validity of window.PaymentRequest

cc @beaufortfrancois @rsolomakhin

👍


sync-changes failing at HEAD

https://github.com/sigstore/community/actions/runs/8905874264/job/24457154923
cc @jku might be related to the pulumi update

It's a bit of a mystery and pulumi isn't making the debugging easy...  It seems to imply that we have already created a branch protection rule for this repo:branch combination but we don't seem to be doing that.
The only real search hit with the term is this  https://github.com/integrations/terraform-provider-github/issues/1699 but I don't quite understand the concept there...

fixed, seems all good now


Add CashuWallet.checkProofsStates()

Add checkProofsStates method to CashuWallet to get the spent enums from the mint, should retire checkProofsSpent which throws most information away.
I would prefer getting rid of checkProofsSpent entirely. If you agree, please delete it or let me know.
Edit: we're getting rid of checkProofsSpent.

Can we be sure that a mint will ALWAYS return the state in the same order as it received the proofs? This is not explicitly defined in NUT07 and if the mint does actually not do that, we need to take care of this in order to avoid lost nuts.

Can we be sure that a mint will ALWAYS return the state in the same order as it received the proofs? This is not explicitly defined in NUT07 and if the mint does actually not do that, we need to take care of this in order to avoid lost nuts.

Agreed, good point. Fixed in code and fixed in the spec: https://github.com/cashubtc/nuts/pull/181

Can we be sure that a mint will ALWAYS return the state in the same order as it received the proofs? This is not explicitly defined in NUT07 and if the mint does actually not do that, we need to take care of this in order to avoid lost nuts.

Good point. Fixed in the code and also fixed in the spec: https://github.com/cashubtc/nuts/pull/181

Thanks for updating! What do you think about this instead?
async checkProofsStates(proofs: Array<Proof>): Promise<Array<ProofState>> {
	const enc = new TextEncoder();
	const Ys = proofs.map((p: Proof) => hashToCurve(enc.encode(p.secret)).toHex(true));
	// TODO: Replace this with a value from the info endpoint of the mint eventually
	const BATCH_SIZE = 100;
	const states: Array<ProofState> = [];
	for (let i = 0; i < Ys.length; i += BATCH_SIZE) {
		const YsSlice = Ys.slice(i, i + BATCH_SIZE);
		const { states: batchStates } = await this.mint.check({
			Ys: YsSlice
		});
		const stateMap: { [y: string]: ProofState } = {};
		batchStates.forEach((s) => {
			stateMap[s.Y] = s;
		});
		for (let j = 0; j < YsSlice.length; j++) {
			const state = stateMap[YsSlice[j]];
			if (!state) {
				throw new Error('Could not find state for proof with Y: ' + YsSlice[j]);
			}
		states.push(state);
		}
	}
	return states;
}

By introducing a map for the returned states, we can check whether a state is present in constant time. Before the worst case scenario was a quadratic + running time

By introducing a map for the returned states, we can check whether a state is present in constant time. Before the worst case scenario was a quadratic + running time

sure go ahead and push and merge it


Not ripping imagefap galleries

Ripme version:1.7.70
Operating system: Windows 10 Pro 64 bit
Exact URL you were trying to rip when the problem occurred: www.imagefap.com/gallery/1399324
Please include any additional information about how to reproduce the problem:

Expected Behavior
rip imagefap gallery
Actual Behavior
refusing to download any imagefap galleries leaves an empty folder with a log file in it thats it.
log.txt
theres a log file from failed rip i think i did it right

This is happening because the user has a space in their name and ripme isn't url encoding it before making requests, it should be an easy fix


BT: tests/bsim/bluetooth/audio/test_scripts/bap_broadcast_audio_assistant broken in main

Describe the bug
The BT Audio test
tests/bsim/bluetooth/audio/test_scripts/bap_broadcast_audio_assistant
is broken in main, on an nrf52_bsim. It blocks CI.
To Reproduce
Steps to reproduce the behavior:

WORK_DIR=${ZEPHYR_BASE}/bsim_out  nice tests/bsim/bluetooth/audio/compile.sh
tests/bsim/bluetooth/audio/test_scripts/bap_broadcast_audio_assistant
See error

Expected behavior
Passing testcase
Impact
Main development blocked when this test is triggered
Logs and console output
https://github.com/zephyrproject-rtos/zephyr/actions/runs/6588609341/job/17901270642?pr=63803#step:12:137
Environment (please complete the following information):

OS: Linux, Ubuntu 22.04 / CI
Toolchain (e.g Zephyr SDK, ...): Host gcc (11 or 12)
Commit SHA or Version used: Main as of now 02deea0e806a40a33eb70edf4b810221c14a0cad

Additional context
The test was just introduced in https://github.com/zephyrproject-rtos/zephyr/commit/0e67c990cdb7ae4e4c90a474e7dc478c44a7d494

Lowering priority as the test has been disabled by now

Will look at this today


Use --alias key

#91
This should work. Previously, duplicate dependencies wouldn't be an issue because the commands targeted a single possible key.
My remaining concern is this version of add-deps doesn't address possible duplicates because the location it adds to is conditional. I don't know whether the project's intent would be to ignore a dupe with the same version between :deps and an alias, warn, or remove one. So please stress test this!

Maybe check if an alias already has a :deps or :extra-deps keys and adjust the key based on that, and default to :extra-deps? Other than that, I think the code looks good. Is it possible to add a test? (Not sure if we've tested add dep otherwise).

Sure, I'll continue as I have time, likely later today

Take your time :)

Hello, long-winded response to a small issue. After adding the check you mentioned I wanted to know how all these dependency maps are dealt with.
What's informing me resolve-deps reference, reference, tools.deps code, code
The implementation leads to this general precedence when a single project file declares multiple versions of a library.

alias :override-deps
alias :extra-deps
alias :replace-deps
alias :deps (deprecated)
project :deps
alias :default-deps ignored unless all other coords nil

So I have learned version conflicts (outside the codebase) aren't an issue except for mental overhead, maybe more if this tool is helping you touch project files less. Plus, a lot more is possible than the 2 or 3 cases I was aware of.
--
If I start throwing in more checks, cli flags etc it feels like increased spaghetti for diminished returns.
My question for you guys as the designers and maintainers, how fine-grained should neil as a tool aim to be.

If you're in the situation substituting all these extra options to resolve dependencies I'm guessing you'd be editing them manually.
Most of the flags within an alias seem semantic for an average-scoped project, because they eventually overrule the project's deps one way or another.
This hierarchy is a corner case anyway

The cleanest all-or-nothing approaches are keeping it naive and letting the user handle it manually, or letting them target any flag they want. Specifying anything between those makes neil more opinionated, so I'd like to consult on where the balance is before pushing anything. My first thought before all this was to check for alias :deps, default to :extra-deps, flag to allow :override-deps for its semantic use and call it a day.
This continues to be an interesting task after getting excited for an analogue to pip install or npm install, lol.... Thanks!

Specifying anything between those makes neil more opinionated

I agree with this. In my opinion we should keep it simple for now:

neil add dep with no --alias always adds to [:deps]
neil add dep --alias foo always adds to [:aliases :foo :extra-deps]

Special case: If deprecated :deps key is already present in [:aliases :foo], use that instead of :extra-deps for compatibility

For project-level deps.edn aliases, :extra-deps is almost always what the user wants. I think for other cases like :override-deps or :replace-deps it's reasonable to edit the deps.edn file by hand.
This is just my feedback; hopefully it helps. I'll leave it to @borkdude for next steps here.

I agree, let's keep it simple, user can always adjust manually but let's also take into account the existing key and use that if present.
I don't think :deps is deprecated, it's just a synonym for :replace-deps. You can see it still being used in the tools build guide for example here:
{:paths ["src"] ;; project paths
 :deps {}       ;; project deps

 :aliases
 {;; Run with clj -T:build function-in-build
  :build {:deps {io.github.clojure/tools.build {:git/tag "TAG" :git/sha "SHA"}}
          :ns-default build}}}

Ok sounds good both replies.
I'm working on tests and was getting hung up on failures related to searching for licenses, oops.. Then checked github:
{"message":"API rate limit exceeded for ............ (But here's the good news: Authenticated requests get a higher rate limit.
Check out the documentation for more details.)","documentation_url":"https://docs.github.com/rest/overview/resources-in-the-rest-api#rate-limiting"}

Now writing test(s) for alias use cases and finding that --alias needs to be specified after --deps-file or it will target deps.edn, that might be my doing. It looks like this PR just merged so I can submit another once finalized or however is easiest

@kees- Ah right, tests welcome, merged this a bit prematurely :). Yes, this github rate limiting is annoying, but perhaps you can test with a predefined version.

Got it, thanks for the clarification.


Want to add sent mail functionality to the owner in contact us from using email.js

Assign me under GSSOC 24

can i work on this issue?

@SUGAM-ARORA Can I work on resolving this issue?

@IAlgorithmia Yes you can work on this issue. But the gssoc has ended so you won't get any points

@IAlgorithmia If you are okay with that then tell me .

Absolutely @SUGAM-ARORA , I'm here because I loved the project idea
I'm excited to begin working on all the issues, beginning with this one

@IAlgorithmia Issue assigned to you

Hey there @SUGAM-ARORA
I have completed the addition of EmailJS in contact us form, also, sending attachments like images, pdfs, etc via email.js requires us to purchase its premium.
I have attached the example template of sent email via EmailJS. I have used one of my personal emails as the owner email.
Please verify the status and suggest any changes if needed, I will request a PR after your confirmation.

@SUGAM-ARORA I have made the necessary changes and opened a pull request.
Can you please review it and merge if no issues arise?


Use ::cartographer::mapping::PoseGraphInterface::TrajectoryState

https://github.com/googlecartographer/rfcs/pull/35

makes use of the trajectory state in map_builder and node
adds a service to query the trajectory states
follow-up to https://github.com/googlecartographer/cartographer/pull/1214
that takes the deleted state into account in the /finish_trajectory service
(could crash otherwise)

As this is an (unplanned) early pull request for features of the yet unmerged RFC https://github.com/googlecartographer/rfcs/pull/35, let me know if you prefer to split it in separate PRs.

@cschuet I added some graceful handling for the case with no subscribers (as in visualize_pbstream) in https://github.com/googlecartographer/cartographer_ros/pull/910/commits/a79fc684c1e3d8f8d996d51ea87462c47bfaa49e
Replacing the manually maintained is_active_trajectory_ by TrajectoryState checks is worth it in my opinion.

@MichaelGrupp Thanks for the contribution.


Possible Feature/Change:  GIT_EDITOR is parsed as shell syntax

This might just be a design decision, but at the very least it is a heads up.   The hub command will use the GIT_EDITOR (or other common suspects) to invoke an editor of choice.   There can be problems if you qualify the path in your command and depending on the windows shell, MsysGit or Cygwin, you can have unexpected behavior and failures.
% GIT_EDITOR="/bin/vim" hub commit --amend
D:/Dev/Program Files/Git/bin/vim: D:/Dev/Program: No such file or directory
error: There was a problem with the editor 'D:/Dev/Program Files/Git/bin/vim'.
Please supply the message using either -m or -F option.
The problem above is due to the space in the path, even though /bin/vim has no spaces, it is converted to a DOS path and that path may have spaces  if installed in a standard location.  Both the git and hub commands expose the editor variable to shell quoting.  Strange as it may seem, if the editor path is a canonical DOS path, i.e., d:\dev\Program Files (x86)\git\vi.exe, it will interpret the backslashes instead of seeing them as path separators.  The fix is to twice quote the string and to use forward slashes:
% GIT_EDITOR="'d:/dev/Program Files (x86)/git/vi.exe'" git commit --amend
Or if you are using vi/vim as your default editor, GIT_EDITOR is not required.   Also be aware that EDITOR or VISUAL are other environment variables that may be used in the absence of GIT_EDITOR.
This also can happen with a hub pull-request, however, it shows up differently:
% hub pull-request -b xxxx:yyyyy
error using text editor for pull request message
The workarounds are to quote the string and use forward slashes so that the shellquote.Split() that is done in cmd.go doesn't interpret backslashes and spaces.    Ideally, the openTextEditor() function in editor.go would normalize the string before calling cmd.New(program) where program is the raw string returned from the environment variable.

@fcassirer I don't think there's an easy workaround other than quoting the program as you mentioned:
GIT_EDITOR="'d:/dev/Program Files (x86)/git/vi.exe'" git commit --amend

We want to shell quote split the GIT_EDITOR value from git config because people may define params when invoking the editor, e.g. vim --noplugin, corresponding issue from gh. Without quoting the editor executable, there's no easy way to distinguish spaces between path segments from spaces between params.

Some more findings, Ruby Shellwords behaves similarly to the shllequote library we use in Go:
irb(main):004:0> Shellwords.split("d:/dev/Program Files (x86)/git/vi.exe")
=> ["d:/dev/Program", "Files", "(x86)/git/vi.exe"]
irb(main):005:0> Shellwords.split("'d:/dev/Program Files (x86)/git/vi.exe'")
=> ["d:/dev/Program Files (x86)/git/vi.exe"]

The one point I want to make that I don't think I've communicated well is that the various shell environments that people are likely to use such as cygwin or msysgit need to be factored in.  People will be working in these shells and naturally will setup a GIT_EDITOR or EDITOR env var expecting it to be parsed by that shell, not necessarily DOS.   For example, simply setting GIT_EDITOR="/usr/bin/vi" is natural in these environments, however, it will require shell specific interpretation by an external command such as hub.  If you then follow the spec for what GIT_EDITOR allows in general, you absolutely have to run the command through the shell of choice in order to do the delayed interpretation.    Again, to do this correctly, I think this is larger in scope than just figuring out the quoting issue.

https://github.com/github/hub/issues/1354

https://github.com/github/hub/issues/835


ARTEMIS-2826 SSL configuration for 'data imp' tool

Jira https://issues.apache.org/jira/browse/ARTEMIS-2826

Instead of adding a handful of new input parameters to deal with SSL/TLS specifics I recommend deprecating the host and port parameters and adding a url parameter. That way any parameter can be set if desired (include SSL/TLS stuff).

@jbertram Thank you for recommendation. I was thinking same approach.. let me try with  URL parameter.

Closing this for now. Re-open when you've got a solution using the URL.


Not working on Raspberry Pi B Rev 2.0 - raises "NotImplementedError'

I tried to repurpose my trusty old RPI1 B rev 2.0 as a environment sensor platform. I purchased a ms430 and tried to use the example python scripts.
Unfortunately the lib rpi-lgpio crashed with the error message:
"NotImplementedError - 'This module does not understand old-style revision codes'"
After poking aroung in: /usr/lib/python3/dist-packages/RPi/GPIO/__init__.py
I found def _get_rpi_info() and applied my own 'sledgehammer method' there.
I hardcoded the following right at the beginning of def _get_rpi_info():
 revision = int('000e',base=16)
 return {'P1_REVISION':0,'REVISION':hex(revision)[2:],'TYPE':'Model B','MANUFACTURER':'Sony UK','PROCESSOR':'BCM2835','RAM':'512M'}

This obviously circumvents the whole revsion-parsing stuff in def _get_rpi_info()` and I am not sure at all if this hack has some nasty side effects but in my case it worked like a charm: I can now use the Metriful sensor example python scripts without any problem.
I also opened an issue at the githup repo of rpi-lgpio but I think the Readme in here should be updated with a workaround for RPI B rev. 2.0 users like me ;-)

Thanks and well done for getting it working! We will try to include this in the next release.


How to interpret labels and estimates returned from run_glm?

If I run a glm a get labels and estimates. What do their numbers mean and how do I interpret the regression results?
 In [168] labels
Out [168] array([0.83, 0.82, 0.77, 0.86, 0.89, 0.91, 0.9 , 0.92, 0.92, 0.92, 0.92,
                 0.92, 0.92, 0.92, 0.92, 0.92, 0.91, 0.9 , 0.89, 0.87, 0.85, 0.8 ,
                 0.83, 0.86, 0.86, 0.89, 0.9 , 0.92, 0.92, 0.92, 0.91, 0.92, 0.92,
                 0.92, 0.92, 0.92, 0.91, 0.89, 0.9 , 0.86])

 In [169] estimates
Out [169] {0.77: <nistats.regression.RegressionResults at 0x145e38320>,
           0.8: <nistats.regression.RegressionResults at 0x159164d68>,
           0.82: <nistats.regression.RegressionResults at 0x1591641d0>,
           0.83: <nistats.regression.RegressionResults at 0x159164668>,
           0.85: <nistats.regression.RegressionResults at 0x159164fd0>,
           0.86: <nistats.regression.RegressionResults at 0x1591640b8>,
           0.87: <nistats.regression.RegressionResults at 0x1591647f0>,
           0.89: <nistats.regression.RegressionResults at 0x159164940>,
           0.9: <nistats.regression.RegressionResults at 0x159164048>,
           0.91: <nistats.regression.RegressionResults at 0x159164160>,
           0.92: <nistats.regression.RegressionResults at 0x1591645c0>}

Dear dangom,
Maybe this discussin would be better on Neurostars.
run_glm is a low-level function: obviously its ouptut is not meant to be dealt with directly. We only used it in nistats atm because there's no high-level function to deal with surface-based GLM (we this we need a Surfacemasker object in nilearn that is not there yet).
glms are indexed by the noise model. More precisely, we use the AR(1) coefficients of models residuls to group the voxels into classes. For each class, the whitening procedure, hence the AR(1) GLM computations are fixed.
hence, for each for this labels, you obtain a   RegressionResults that exactly yields the summary statistics you need for contrast computations.
These things have to be given to a function that will perform contrast handling --as in the surface-based GLM example.
Does that make sense ?

Thanks bthirion. That makes sense.
As in the example given in the documentation,  I noticed I can get the betas I'm after by running:
con = compute_contrast(labels, estimates, contrast_val, contrast_type="t")
con.effect

But I guess end-users shouldn't be using either run_glm nor compute_contrast directly, as you say.  I'll close this issue and reopen a discussion in neurostats if I have other questions. As always, thanks for sharing the project and for the quick response.

run_glm is a low-level function: obviously its ouptut is not meant to be dealt with directly. We only used it in nistats atm because there's no high-level function to deal with surface-based GLM (we this we need a Surfacemasker object in nilearn that is not there yet).

Is this something that we should consider? Indeed very little
would be required to allow this example to use FirstLevelModel instead
of the low-level functions.

We should consider this, but this has to rely on a proper SurfaceMasker I guess.

Let's spec it out, what all do we need to implement a SurfaceMasker in a new issue in Nilearn. Whenever we decide to work on it, it'll be a good document to start at.

We should consider this, but this has to rely on a proper SurfaceMasker I guess.

would that masker map from volume to surface? (but what would be the inverse_transform?)
or should we add proper support for surface data in nilearn (but the
nibabel documentation for Gifti images is somewhat cryptic)?

I mean the second one: add proper support for surface data in nilearn.

would that masker map from volume to surface? (but what would be the
inverse_transform?)
or should we add proper support for surface data in nilearn (but the
nibabel documentation for Gifti images is somewhat cryptic)?

—
You are receiving this because you commented.
Reply to this email directly, [
https://github.com/nistats/nistats/issues/401?email_source=notifications&email_token=AABZHVRRJZF7JK7SPQKJMSLQOBB3ZA5CNFSM4I7PH3Z2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEA7OEUY#issuecomment-540992083
| view it on GitHub ] , or [
https://github.com/notifications/unsubscribe-auth/AABZHVS3OINF7PASGWXCKYLQOBB3ZANCNFSM4I7PH3ZQ
| unsubscribe ] .


add upload permission for hyper-slaves-plugin

https://github.com/jenkinsci/hyper-slaves-plugin

@daniel-beck Could you please merge this PR?
This is related to hyper-build-step-plugin and hyper-commons-plugin

Done @Jimmy-Xu
Beware that for your permissions to work, the person deploying must already have logged in at least once on https://accounts.jenkins.io/
Have fun!

@batmat Thank you!