TypeError: Cannot read property 'range' of null from template-curly-spacing

With this .eslintrc config:
{
  "root": true,
  "parser": "babel-eslint",
  "extends": [
    "eslint:recommended",
    "semistandard"
  ],
  "env": {
    "browser": true,
    "commonjs": true,
    "es6": true,
    "mocha": true,
    "node": true
  },
  "plugins": [
    "babel"
  ],
  "rules": {
    "arrow-parens": 0,
    "no-class-assign": 0,
    "space-before-function-paren": [2, "never"]
  }
}

And these dependencies:
  "dependencies": {
    "babel-runtime": "6.26.0",
  },
  "devDependencies": {
    "babel-cli": "6.26.0",
    "babel-core": "6.26.0",
    "babel-eslint": "8.0.1",
    "babel-plugin-transform-runtime": "6.23.0",
    "babel-preset-latest": "6.24.1",
    "babel-preset-stage-0": "6.24.1",
    "chai": "4.1.2",
    "dotenv": "4.0.0",
    "eslint": "4.9.0",
    "eslint-config-semistandard": "11.0.0",
    "eslint-config-standard": "10.2.1",
    "eslint-plugin-babel": "4.1.2",
    "eslint-plugin-import": "2.7.0",
    "eslint-plugin-node": "5.2.0",
    "eslint-plugin-promise": "3.6.0",
    "eslint-plugin-standard": "3.0.1",
    "mocha": "4.0.1"
  }

this code snippet:
export default class SomeClass {
  someMethod(params) {
    const test = 'test';
    return `${test}`; // Seems to have to do with this template. Returning `test` directly is fine.
  }
}

results in this error when running eslint:
Cannot read property 'range' of null
TypeError: Cannot read property 'range' of null
    at SourceCode.getTokenBefore (/Users/jason/my-project/node_modules/eslint/lib/token-store/index.js:303:17)
    at checkSpacingBefore (/Users/jason/my-project/node_modules/eslint/lib/rules/template-curly-spacing.js:51:42)
    at TemplateElement (/Users/jason/my-project/node_modules/eslint/lib/rules/template-curly-spacing.js:116:17)
    at listeners.(anonymous function).forEach.listener (/Users/jason/my-project/node_modules/eslint/lib/util/safe-emitter.js:47:58)
    at Array.forEach (native)
    at Object.emit (/Users/jason/my-project/node_modules/eslint/lib/util/safe-emitter.js:47:38)
    at NodeEventGenerator.applySelector (/Users/jason/my-project/node_modules/eslint/lib/util/node-event-generator.js:251:26)
    at NodeEventGenerator.applySelectors (/Users/jason/my-project/node_modules/eslint/lib/util/node-event-generator.js:280:22)
    at NodeEventGenerator.enterNode (/Users/jason/my-project/node_modules/eslint/lib/util/node-event-generator.js:294:14)
    at CodePathAnalyzer.enterNode (/Users/jason/my-project/node_modules/eslint/lib/code-path-analysis/code-path-analyzer.js:606:23)

If I remove "parser": "babel-eslint" the problem goes away, so I think it has to do with babel-eslint. The error also goes away if I pin babel-eslint to 7.2.3.
Happy to provide any other information if necessary!

Weird.. it works fine with just
  "dependencies": {
    "babel-eslint": "^8.0.1",
    "eslint": "^4.10.0"
  },

https://github.com/ant-design/ant-design/commit/d1568c959ceb4082a8795a167456c4412c38a5ed
Locking to 8.0.1 seems to be ok.

8.0.2 works fine too.

https://travis-ci.org/ant-design/ant-design/jobs/321665643

After few hours digging, I found the root problem. There are two copies of @babel/types in our node_modules.
[0] % yarn list @babel/types
yarn list v1.3.2
├─<EMAIL_ADDRESS>│  └─<EMAIL_ADDRESS>└─<EMAIL_ADDRESS>✨  Done in 1.31s.

<EMAIL_ADDRESS>is lifted to the root, so babel-eslint monkey patched this version. And @babel-traverse depend on<EMAIL_ADDRESS>so that MethodDefinition is not visited at all.

babel-eslint should upgrade @babel-traverse to 7.0.0-beta.36 https://github.com/babel/babel-eslint/pull/550.
@hzoo Why not move babel-eslint to mono-repo?

how to fix this ? Anybody know ?

@delch Install<EMAIL_ADDRESS>as your project's dependent.

I have same issue. The most annoying thing is that it doesn't bubbles for old peaces of code with template literals, but only for fresh once. Can't figure out why. It does creeps me out a lot.
ERROR in ./src/components/common/input-combobox.js
Module build failed: TypeError: Cannot read property 'range' of null
    at SourceCode.getTokenBefore (/media/projects/sites/taximow-static/node_modules/eslint/lib/token-store/index.js:303:18)
    at checkSpacingBefore (/media/projects/sites/taximow-static/node_modules/eslint/lib/rules/template-curly-spacing.js:52:42)
    at TemplateElement (/media/projects/sites/taximow-static/node_modules/eslint/lib/rules/template-curly-spacing.js:117:17)
    at listeners.(anonymous function).forEach.listener (/media/projects/sites/taximow-static/node_modules/eslint/lib/util/safe-emitter.js:47:58)
    at Array.forEach (<anonymous>)
    at Object.emit (/media/projects/sites/taximow-static/node_modules/eslint/lib/util/safe-emitter.js:47:38)
    at NodeEventGenerator.applySelector (/media/projects/sites/taximow-static/node_modules/eslint/lib/util/node-event-generator.js:251:26)
    at NodeEventGenerator.applySelectors (/media/projects/sites/taximow-static/node_modules/eslint/lib/util/node-event-generator.js:280:22)
    at NodeEventGenerator.enterNode (/media/projects/sites/taximow-static/node_modules/eslint/lib/util/node-event-generator.js:294:14)
    at CodePathAnalyzer.enterNode (/media/projects/sites/taximow-static/node_modules/eslint/lib/code-path-analysis/code-path-analyzer.js:608:23)
    at Traverser.enter [as _enter] (/media/projects/sites/taximow-static/node_modules/eslint/lib/linter.js:1006:32)
    at Traverser._traverse (/media/projects/sites/taximow-static/node_modules/eslint/lib/util/traverser.js:132:14)
    at Traverser._traverse (/media/projects/sites/taximow-static/node_modules/eslint/lib/util/traverser.js:144:34)
    at Traverser._traverse (/media/projects/sites/taximow-static/node_modules/eslint/lib/util/traverser.js:147:30)
    at Traverser._traverse (/media/projects/sites/taximow-static/node_modules/eslint/lib/util/traverser.js:147:30)
    at Traverser._traverse (/media/projects/sites/taximow-static/node_modules/es

ps I have "@babel/types": "7.0.0-beta.39" in my devDependencies

In case anyone is in a similar situation - this problem occurred for me when I bumped my Node version from 6.11.1 to 8.9.4. I took two steps to resolve this -

As recommended by @jasonblanchard, I set my version of babel-eslint to 7.2.3
I also manually included @babel/types": "7.0.0-beta.40 in my deps as recommended by @yesmeck, though I'm not certain that this had any effect as it was not enough to resolve the problem on its own.

In my case upgrading to<EMAIL_ADDRESS>has solved the problem.

@jasonblanchard confirmed pin pin babel-eslint to 7.2.3. solved the issue!
its good to resolve the issue since that means newer version of this plugin really is nobody using it.. lol

I've missed this error for a while, but today I had edited like 20 files using template literals, and I had this error again. Weirdest thing that error appeared in 10 of edited files, and there was no errors for other part of the files. All 20 files are React components, and all 20 fixes had similar pattern. I looked at babel-eslint version, and I had 8.2.2
I've downgraded it to 7.2.3 and errors disappeared.

Why is babel-eslint 8.x picking a beta build of @babel/types in the first place? And a very specific, non-bug-fixable version?? https://github.com/babel/babel-eslint/blob/master/package.json#L16 Seems like downgrading to 7.2.3 is definitely a safer option.

I managed to fix this problem for myself; our company's internal ESLint config defined "parser": "babel-eslint", but that line also existed in each project's .eslintrc.
Removing the line "parser": "babel-eslint" from each project caused ESLint to rely on the version installed from our config, and fixed the issue. I know npm flattens the dependency tree, so I can't explain why this works; I'm just happy it does work.

@ryaninvents Worked for me too. Thank you!

@ryaninvents What do you mean with company's internal ESLint config?
I've tried adding and removing "parser": "babel-eslint" from .eslintrc to no avail.
Are we still supposed to downgrade to a specific version to get this working?

have the same issue. Can't downgrade to<EMAIL_ADDRESS>as I encounter another issue https://github.com/eslint/eslint/issues/9767. To solve it, I have to update to ^8.2.0 .
eslint version v4.19.1

same here.
this is broken on "babel-eslint": "8.2.3", and works on "babel-eslint": "8.2.2"

still happens on newest versions

catch 22 :/

Work fine for me with this..
"babel-eslint": "8.0.1",
"eslint": "4.13.1",

For me works with
"babel-eslint": "7.2.3",
"eslint": "^4.19.1",

module.exports = {
    "parser": "babel-eslint",
    ...

Tried many of the above solutions and they don't seem to work for me.
Cannot downgrade eslint below 4.14.0 or babel-eslint below 7.2.3 due to https://github.com/eslint/eslint/issues/9767
Trying with any of the current babel-eslint versions (8.0.1, 8.1.0, 8.2.3) with eslint (4.18.0 or 4.19.1) will result with this error.
Removing "parser": "babel-eslint" got rid of this error, so I believe its this module thats the issue.

"babel-eslint": "7.2.3", did work for me aswell.

Argh... On another project, I'm encountering the same situation as @vitalii & @jnrepo :
Downgrading to<EMAIL_ADDRESS>fixes the bug discussed in the current issue, but it's causing the https://github.com/eslint/eslint/issues/9767 issue.
😞  🔫

it' weird. In out company's project, one JS file causes this error in these versions:
"babel-eslint": "^8.2.3",
"eslint": "^4.19.1"

but other files also use the same grammar ( template string ), they don't cause the problem.
we must turn off both two rules then it can work:
rules:
  indent: 0
  template-curly-spacing: 0

But when moving this file into a new folder and install the same versions and the folder is like this:
├─ node_modules
├─ .eslintrc.yml
├─ action.js
├─ package-lock.json
└─ package.json

without any operations, and don't need turn off the two rules, it also works!
finally, make "babel-eslint": "8.0.1" to solve this problem.

@fnknzzz turning off both rules worked for me, thanks!

dupe of https://github.com/babel/babel-eslint/issues/585

@yesmeck already identified the root cause https://github.com/babel/babel-eslint/issues/530#issuecomment-354242702

I think the reason why upgrading to the latest 8.x works for some people and not other is because we have a beta dependency in the tree. It works when it was released, but not when the beta changes.

When it should be fixed? I'm really missing out of updating babel-eslint to
latest version in my project.
2018-06-19 2:07 GMT+08:00 Pyrolistical<EMAIL_ADDRESS>
I think the reason why upgrading to the latest 8.x works for some people
and not other is because we have a beta dependency in the tree. It works
when it was released, but not when the beta changes.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/babel/babel-eslint/issues/530#issuecomment-398144393,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACJseYK2EbVKsfRhhJ06HLzNDPppEJFHks5t9-xZgaJpZM4P6xj3
.

downgrading to 7.2.3 not working for me :/

babel-eslint 7.2.3 and aslant 4.13.1 is working for me.

Hum I'm quite stuck.. if I downgrade babel-eslint I have this error with my decorators

Cannot read property 'type' of undefined

😭

FWIW this appears to be architecture-specific. On my Linux (Arch) box, I do not encounter this problem using<EMAIL_ADDRESS>and<EMAIL_ADDRESS>however my co-worker did when using the same combination on Mac. For him downgrading to<EMAIL_ADDRESS>worked.

These versions seem to work for me: https://github.com/babel/babel-eslint/issues/566#issuecomment-375563065
babel-eslint 8.2.2
aslant 4.19.0

Downgrading to these versions fixed the issue for me:
"babel-eslint": "8.0.1", "eslint": "4.19.0",

@vitalii Did you manage to make it work? I tried different combinations and none of them seem to be good. Versions older than 8.1.1 cannot work because of Flow-related bug 9767 and versions newer than 8.1.1 don't work because of this range thing.

@denisftw try https://github.com/babel/babel-eslint/issues/530#issuecomment-397495131

Using<EMAIL_ADDRESS>doesn't fixes this
If I disable template-curly-spacing rule, I get the same error on ident rule.
My workaround id to temporarily disable both rules
  // TODO: Remove when is https://github.com/babel/babel-eslint/issues/530 fixed
  rules : {
    "template-curly-spacing" : "off",
    indent : "off"
  }

Why is this issue still labelled with needs investigation ?

Any idea when this will be fixed?

"eslint": "5.3.0",
"babel-eslint": "8.2.5",
these versions work for me on windows

I'm also having problems with the indent rule, I can't commit anything...
These are all the eslint related packages' versions I'm using.
    "eslint": "4.19.1",
    "eslint-config-airbnb": "16.1.0",
    "eslint-config-airbnb-base": "12.1.0",
    "eslint-config-prettier": "2.9.0",
    "eslint-import-resolver-webpack": "0.10.0",
    "eslint-plugin-import": "2.12.0",
    "eslint-plugin-jsx-a11y": "6.0.3",
    "eslint-plugin-prettier": "2.6.0",
    "eslint-plugin-react": "7.9.1",
    "eslint-plugin-redux-saga": "0.9.0",
    "babel-eslint": "8.2.1",

Is this going to be fixed anytime soon?

I've never had problems after I found a setting that worked for me time ago. It'd be better if I could use newer versions now, so please it'd be greatly appreciated if somebody'd take care of this issue.

hi, i as well have this problem when i merge my project(with webpack@4, named A) to another(with webpack@3, named B), but the eslint and babel settings are the same.
It is weird that my eslint ran well in project A, however in project B throws Cannot read property 'range' of null when having a template string as a object's value:
(eslint broke when there is a template string in object's value)
(works well in the other conditions)
and when i remove both template-curly-spacing & indent rules it works fine
(works fine when i remove both template-curly-spacing & indent)
it's more likly a babel-eslint problem because when i remove parser: babel-eslint  it works fine without some es6 parsers cannot be recognized such as decorators
here are my devDependencies
"devDependencies": {
    "@babel/types": "^7.0.0-beta.44",
    "autoprefixer": "^8.5.0",
    "babel-core": "^6.26.3",
    "babel-eslint": "^8.2.6",
    "babel-jest": "^22.4.3",
    "babel-loader": "^7.1.4",
    "babel-plugin-import": "^1.7.0",
    "babel-plugin-module-resolver": "^3.1.1",
    "babel-plugin-react-html-attrs": "^2.1.0",
    "babel-plugin-transform-decorators-legacy": "^1.3.4",
    "babel-plugin-transform-es2015-template-literals": "^6.22.0",
    "babel-plugin-transform-react-remove-prop-types": "^0.4.13",
    "babel-plugin-transform-runtime": "^6.23.0",
    "babel-preset-env": "^1.7.0",
    "babel-preset-react": "^6.24.1",
    "babel-preset-stage-1": "^6.24.1",
    "babel-register": "^6.26.0",
    "eslint": "^4.19.0",
    "eslint-config-standard": "^11.0.0",
    "eslint-config-standard-react": "^6.0.0",
    "eslint-friendly-formatter": "^4.0.1",
    "eslint-loader": "^2.0.0",
    "eslint-plugin-babel": "^5.1.0",
    "eslint-plugin-import": "^2.11.0",
    "eslint-plugin-jest": "^21.15.1",
    "eslint-plugin-node": "^6.0.1",
    "eslint-plugin-promise": "^3.7.0",
    "eslint-plugin-react": "^7.8.2",
    "eslint-plugin-standard": "^3.1.0",
    "file-loader": "^1.1.11",
    "koa": "^2.4.1",
    "koa-router": "^7.2.1",
    "node-sass": "^4.9.2",
    "nodemon": "^1.12.1",
    "postcss-calc": "^6.0.1",
    "postcss-flexbugs-fixes": "^4.1.0",
    "postcss-loader": "^2.1.5",
    "postcss-mixins": "^6.2.0",
    "postcss-pxtorem": "^4.0.1",
    "react-hot-loader": "^4.3.4",
    "sass-loader": "^7.1.0",
    "style-loader": "^0.22.1",
    "url-loader": "^1.0.1",
    "webpack": "^3.12.0",
    "webpack-dev-server": "^2.11.2"
  }

and my babel settings
{
  "presets": [
    ["env", { "modules": false }],
    "stage-1",
    "react"
  ],
  "plugins": [
    "transform-runtime",
    "react-html-attrs",
    "transform-decorators-legacy",
    ["import", { "libraryName": "antd-mobile", "style": true }]
  ],
  "env": {
    "production": {
      "plugins": [
        ["transform-react-remove-prop-types", {"removeImport": true, "ignoreFilenames": ["node_modules"]}]
      ]
    },
    "development": {
      "plugins": ["react-hot-loader/babel"]
    },
}

and here are my eslint settings. it's a bit long so i update it as a file
eslintrc.txt

I found that adding
"devDependencies": {
    "@babel/traverse": "7.0.0-beta.52",
}

e.g. to version match the dependency stated here
appears to have fixed my issue using latest babel-eslint

Holy crap, @seankoji ! This worked for me =D Thanks!

@seankoji this worked for me as well   thanks!

@seankoji worked for me also! 🎉
"dependencies": {
  "@babel/core": "7.0.0-rc.1",
  "@babel/node": "7.0.0-rc.1",
  "@babel/traverse": "^7.0.0-rc.1",
  "eslint": "^5.4.0",
},
"devDependencies": {
  "babel-eslint": "^8.2.6"
}

Yes ... this has been called out as working, so long as you are always on the correct version that eslint is using under the hood. Once those subdepenencies change, this resurfaces. This was referenced way up in the discussion.
Ideally there would be persistent solution, although there may not be until babel 7 goes stable.

"dependencies": {
    "@babel/traverse": "^7.1.0"
  }
"devDependencies": {
  "babel-eslint": "^8.2.6",
  "eslint": "4.19.1"
}

it worked for me @seankoji  thanks

@piuccio that error is unrelated to this issue report as that was in 2017 and we just released 10.0 yesterday. You're issue is most likely https://github.com/babel/babel-eslint/issues/695. I would also advise you not need to add commentary like "this is depressing" to your comments. babel-eslint is a separate project that also happens to have the same maintainers as Babel and we make mistakes, might not understand what's going on, and are volunteers.

@hzoo I didn't mean to offend you or any Babel maintainers, I know you're doing a great job.
The stack trace is very cryptic and when I googled it, this is the only issue I could find and it looked remarkably similar despite being a year old. I'm spending days trying to upgrade dependencies (react-native, babel, ...) and I just needed to vent my frustration.
Thanks for your quick reply

I am also getting the same error which is silenced once I remove the line "indent": ["warn", 4]. Which someone else reported above. I updated to 10.0.1 today.

Same error, if I remove the intent rule it's fine.
"rules": {
  "indent": [2, 2]
}

@piuccio try to this way

npm install<EMAIL_ADDRESS>-g
delete node_modules
yarn install (don't use "npm install")

this is my config:
"devDependencies": {
"babel-eslint": "^10.0.0",
"eslint": "^5.4.0",
"eslint-config-airbnb": "^17.1.0",
"eslint-plugin-import": "^2.14.0",
"eslint-plugin-jsx-a11y": "^6.1.1",
"eslint-plugin-react": "^7.11.1",
}

Even with these versions, it still gives error when the code has  a ` eg
uri: `${configuration.user}/users/signon`

@albertpb indent:off seems to work for me. I'm using "babel-eslint": "^10.0.1",

Did anyone come up with a fix for this? Using "babel-eslint": "^10.0.1" and "eslint": "^5.7.0"

FWIW, I had this issue and was able to fix it by running yarn upgrade.
I may have had 2 different versions of the dependencies installed (@babel/traverse and @babel/types for example).
After running yarn upgrade, the linter just worked, without needing to disable rules.
"babel-eslint": "10.0.1",
"eslint": "5.8.0",
"xo": "0.23.0"

ok, i update "babel-eslint": "^10.0.0" will be ok

Babel-eslint 10.0.1 still doesn't work for me. Is this issue known to be fixed or is it still open?

Not working, with latest versions at present in my project.
see:
"@babel/traverse": "^7.1.5",
"@babel/types": "^7.1.5",
"babel-eslint": "^10.0.1",
"eslint": "^5.9.0",

I've got exactly the same error several times. After removing package-lock.json it starts working.

Upgraded to latest babel-eslint + eslint
Remove node_modules
Remove yarn.lock
Run yarn install.

🎊 All works again.

So, everything is supposed to work now with up to date dependencies? 🤔

This fix the problem for me too.

1. Upgraded to latest babel-eslint + eslint

2. Remove `node_modules`

3. Remove `yarn.lock`

4. Run `yarn install`.

confetti_ball All works again.

With this config
"babel-eslint": "^10.0.1",
"eslint": "^5.5.0",
"eslint-plugin-vue": "^4.5.0",

I was able to fix this
using "babel-eslint": "10.0.1",
and then running
yarn install
yarn upgrade
that fixed me the issue

This is finally resolved. Installing latest babel, babel-eslint with its latest dependencies work fine

even with the latest version of eslint/babel-eslint i could only fix this issue by:

removing node_modules + package-lock.json
running npm install

The same error:
    "babel-eslint": "10.0.1",
    "eslint": "^5.9.0",
    "eslint-config-airbnb": "^17.1.0",
    "eslint-import-resolver-webpack": "^0.10.1",
    "eslint-plugin-import": "^2.14.0",
    "eslint-plugin-jsx-a11y": "^6.1.2",
    "eslint-plugin-react": "^7.11.1"

With "babel-eslint": "8.2.6" working.

This is becoming chronic with a lot of tries and errors. I still can get it fixed with all been said here.

even with the latest version of eslint/babel-eslint i could only fix this issue by:
* removing node_modules + package-lock.json

* running npm install

This work for me with that upgrade:

The same error:
    "babel-eslint": "10.0.1",
    "eslint": "^5.9.0",
    "eslint-config-airbnb": "^17.1.0",
    "eslint-import-resolver-webpack": "^0.10.1",
    "eslint-plugin-import": "^2.14.0",
    "eslint-plugin-jsx-a11y": "^6.1.2",
    "eslint-plugin-react": "^7.11.1"

With "babel-eslint": "8.2.6" working.

I had the exact same situation, and dropping from "babel-eslint": "^10.0.0",  to "babel-eslint": "^8.2.6", made the problem go away for me.

Still an error for me:
    "babel-eslint": "10.0.1",
    "eslint": "5.10.0",
    "eslint-config-airbnb": "17.1.0",
    "eslint-plugin-import": "2.14.0",
    "eslint-plugin-jsx-a11y": "6.1.2",
    "eslint-plugin-react": "7.11.1"

Works for me, but it didn't work during many hours of trying things.  This is where I ended up, but I suspect that there is some other interaction that was causing the problem.
    "@babel/core": "^7.2.0",
    ... (lots of Babel 7 lines  for plugin etc.) ...
    "babel-eslint": "^10.0.0",
    "babel-plugin-object-assign": "^1.2.1",
    "babelify": "^10.0.0",
    "browser-sync": "^2.26.3",
    "browserify": "^13.3.0",
    "eslint": "^5.10.0",
    "eslint-config-airbnb": "^17.1.0",
    "eslint-plugin-import": "^2.14.0",
    "eslint-plugin-jsx-a11y": "^6.1.2",
    "eslint-plugin-react": "^7.11.1",

It sounds weird, but what helped to me was: removing node_modules AND package-lock.json and do the clean installation. My versions are:
    "babel-core": "6.26.3"
    "babel-eslint": "10.0.1",
    "eslint": "5.10.0",
    "eslint-config-airbnb": "17.1.0",
    "eslint-plugin-import": "2.14.0",
    "eslint-plugin-jsx-a11y": "6.1.2",
    "eslint-plugin-react": "7.11.1",

Apparently there was an issue with some locked version of package, but I'm not sure which one - fully clean installation helped.

I fixed this by installing the latest @babel/types and @babel/traverse that met my requirements (^7.x.x), deduplicating the tree, and then removing them from my dependencies.
npm install --save-dev<EMAIL_ADDRESS><EMAIL_ADDRESS>npm dedupe
npm uninstall --save-dev @babel/types @babel/traverse

This allowed npm to install a newer version of both at the top of my node_modules tree, deduplicate the tree to remove older versions, and then remove them from my dependencies while leaving them in node_modules for nested dependencies.

yarn upgrade fixed it for me without wiping yarn.lock or node_modules

In my case, I was able to run eslint with ./node_modules/.bin/eslint --ext js,jsx src  successfully but I was getting the Cannot read property 'range' of null from template-curly-spacing error from the vscode eslint plugin when I was trying to format the code with the vscode prettier plugin. Disabling/enabling the vscode eslint plugin solved it for me. 🤔

In my case, I was able to run eslint with ./node_modules/.bin/eslint --ext js,jsx src successfully but I was getting the Cannot read property 'range' of null from template-curly-spacing error from the vscode eslint plugin when I was trying to format the code with the vscode prettier plugin. Disabling/enabling the vscode eslint plugin solved it for me. 🤔

I had a similar issue with atom, I was able to run eslint from the terminal just fine.  I updated the "linter" package for atom to the latest and now I'm no longer getting this error.

It works after I did
rm -rf node_modules
rm package-lock.json
npm install```
Essentially update the modules & do a clean installation of node modules

I'm don't get why but @danielnmai's solution worked for me, too

Because you updated the dependencies of your dependencies.

I get this error whenever I used 'as' typecasting from typescript

removing node_modules + package-lock.json
running npm install

this fixed the issue for me as well

@ntucker Thanks for your comment -- I'm experiencing the same thing and you pointing out that issue helped me hunt down the solution: add eslint-config-prettier. In case it helps, I managed to isolate the issue to the rule "@typescript-eslint/indent": "error", which is included in the plugin:@typescript-eslint/recommended eslint config.
Examples of this troubleshooting can be found on the various branches here.
Hope this helps!

Dug into my version of the error
    "@babel/plugin-proposal-class-properties": "^7.4.0",
    "@babel/plugin-proposal-decorators": "^7.4.0",
    "babel-eslint": "^10.0.1",

seems these rules, it is related to decorator usage like this @computed('first', 'last')

turning off these rules solved the problem

My fix was to remove node_modules and package-lock.json and to run npm install again. Not ideal.

Upgraded to latest babel-eslint + eslint
Remove node_modules
Remove yarn.lock
Run yarn install.

This was a bit heavy handed for my tastes -- after all, I'm using a lock file for a reason. After some experimentation, I was able to land on the follow more targeted solution, based on npm 6.4.1:

npm ls @babel/types
npm uninstall all of those top level packages
Confirm you typed/copied everything correctly: npm ls @babel/types should now return no matching packages
npm install that same list of top level packages

And now everything works 🙌 For a reason I don't understand, different packages were grabbing different versions of @babel/types, ranging from 7.0.0 to latest (7.4.4 as of this writing). The above procedure gets all packages on the same version of @babel/types which then allows eslint to run.

@ZebraFlesh's more refined approach didn't work for me, but the "blow away everything and reinstall without a lock" :boom:  approach did the job.

Fixed by upgrading babel-eslint from 8.2.6 to 10.0.3

It still a problem for me but only for VSCode plugin, if I run it from the terminal directly - all fine.

I have the same problem babel-eslint 10.0.3 and eslint 6.5.0
TypeError: Cannot read property 'range' of null
Occurred while linting File.jsx:1
    at OffsetStorage.setDesiredOffset (project_dir_here\node_modules\eslint\lib\rules\indent.js:339:45)
    at TemplateLiteral.node.expressions.forEach (project_dir_here\node_modules\eslint\lib\rules\indent.js:1358:29)
    at Array.forEach (<anonymous>)
    at Object.TemplateLiteral [as listener] (project_dir_here\node_modules\eslint\lib\rules\indent.js:1350:34)
    at Program:exit.listenerCallQueue.filter.forEach.nodeInfo (project_dir_here\node_modules\eslint\lib\rules\indent.js:1585:55)
    at Array.forEach (<anonymous>)
    at Program:exit (project_dir_here\node_modules\eslint\lib\rules\indent.js:1585:26)
    at listeners.(anonymous function).forEach.listener (project_dir_here\node_modules\eslint\lib\linter\safe-emitter.js:45:58)
    at Array.forEach (<anonymous>)
    at Object.emit (project_dir_here\node_modules\eslint\lib\linter\safe-emitter.js:45:38)

Haven't run into this problem for several weeks now. I'd say just update your dev dep, and do a yarn --force
Sent from my iPhone

On 2 Oct 2019, at 14:16, Sergey Zolotarev<EMAIL_ADDRESS>wrote:
I have the same problem babel-eslint 10.0.3 and eslint 6.5.0
TypeError: Cannot read property 'range' of null
Occurred while linting File.jsx:1
at OffsetStorage.setDesiredOffset (project_dir_here\node_modules\eslint\lib\rules\indent.js:339:45)
at TemplateLiteral.node.expressions.forEach (project_dir_here\node_modules\eslint\lib\rules\indent.js:1358:29)
at Array.forEach ()
at Object.TemplateLiteral [as listener] (project_dir_here\node_modules\eslint\lib\rules\indent.js:1350:34)
at Program:exit.listenerCallQueue.filter.forEach.nodeInfo (project_dir_here\node_modules\eslint\lib\rules\indent.js:1585:55)
at Array.forEach ()
at Program:exit (project_dir_here\node_modules\eslint\lib\rules\indent.js:1585:26)
at listeners.(anonymous function).forEach.listener (project_dir_here\node_modules\eslint\lib\linter\safe-emitter.js:45:58)
at Array.forEach ()
at Object.emit (project_dir_here\node_modules\eslint\lib\linter\safe-emitter.js:45:38)
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.

Blown away and reinstalled - on latest versions - still throws this error unless I a) turn off template-curly-spacing and b) exclude TemplateLiteral from indent :/

Removing node_modules & package-lock.json before reinstalling all dependencies did the job.
Thanks!

i tried everything about this is still an issue, can we re open this ?

In my case this fixed it:
rm -f yarn.lock
rm -rf node_modules
yarn add $(npm outdated |awk '/eslint/ {print $1"@"$4}')
yarn

I guess it's bringing a big sledgehammer and could invite more consequences to your code-base than are welcome though (upgraded linting, subtle or not so subtle dependency changes).

Some suggestions described in #681 worked for me in the end.
I initially tried the suggested method with removing yarn.lock and completely re-installing the modules, but the error persisted.
Defining a resolution for @babel/types, so that every package uses the same version, should work to resolve the issue.
  "resolutions": {     "@babel/types": "7.7.4"   }
If that still doesn't work, disable the rule that causes the crash in your eslintrc.json or whichever config file you use:

... In my case at least the error is generated during handling of template literals within the indent rule. I can live with not checking indentation for template literals, so I've fixed it for now using the ignoredNodes option for the indent rule, roughly as follows:
"indent": ["error", 2, {
  "ignoredNodes": ["TemplateLiteral"]
}]

Not sure how else I can be of help, except maybe reiterate @ljqx's suggestion of trying to normalize the @babel/types dep across babel and babel-eslint. I can't tell if npm is doing something wrong here or if yarn's more deterministic algorithm is hiding a flaw in the code.

Interestingly, I removed the specific indent rule since, to see if the issue was fixed (resolution still in place). babel-eslint kept working without the rule, even though template literals were present.

Justo to report, i had the same problem with "babel-eslint": "^10.0.3" and "eslint": "^5.16.0" on node 10.17.0 and npm 6.11.3. For me rm -rf node_modules && npm install solved the problem

Still having this problem myself. On<EMAIL_ADDRESS>and<EMAIL_ADDRESS>removing babel-eslint from the parser setting worked to quell the error, but then created a new error around assigning functions to class properties (a la foo = () => {...} in classes)

I think the cause is as what I said here: https://github.com/babel/babel-eslint/issues/799#issuecomment-567598343

This just started failing for me yesterday.

Same for me, was resolved by:
"@babel/generator": "7.7.4"

None of the above workarounds helped. The bug persists with the latest ESLINT, etc.
Should be reopened IMO.

@ivan-kleshnin do yarn cache clean

+1

This works: https://github.com/babel/babel-eslint/issues/799#issuecomment-570790316

@afc163 解决了, 谢谢

Still seeing this issue working with i18n in Vue.
Original code that was causing the error:
return import(/* webpackChunkName: "lang-[request]" */./locales/${lang}.json)     .then((messages) => {       i18n.setLocaleMessage(lang, messages.default);       loadedLanguages.push(lang);       return setI18nLanguage(lang);     });
New code that doesn't throw the error:
  const languageFile =./locales/${lang}.json`;
return import(/* webpackChunkName: "lang-[request]" */ languageFile)
.then((messages) => {
i18n.setLocaleMessage(lang, messages.default);
loadedLanguages.push(lang);
return setI18nLanguage(lang);
});
`

Most likely the issue is causing of wrong parsing.
import(some_path/${variable}) // issue exists
Fix
import("some_path" + variable) // issue fixed

I confirm, it's broken for such code:
import(`../layouts/${this.name}.vue`)

Please, reopen the issue. yarn cache clean, rm yarn.lock, rm -rf node_modules, yarn audit don't help.
> yarn audit
yarn audit v1.21.1
0 vulnerabilities found - Packages audited: 24351
Done in 1.29s.

> yarn outdated
yarn outdated v1.21.1
Done in 1.09s.

/cc @ljharb

This is an ancient issue; please file a new one.

This is an ancient issue; please file a new one.

OK, but I see open #608, #741, #799 and #815, which are pretty similar, so I'll just watch for them.

fixed https://github.com/babel/babel-eslint/issues/815#issuecomment-594534738

I have been able to resolve this issue by upgrading babel-eslint to 10.1.0.

Still having it.
module.exports = {
  root: true,
  env: {
    node: true
  },
  extends: [
    'plugin:vue/essential',
    'plugin:vue/recommended',
    'eslint:recommended',
    'standard'
  ],
  "parser": "vue-eslint-parser",
  parserOptions: {
    "parser": "babel-eslint",
      "sourceType": "module"
  },
  rules: {},
}

"devDependencies": {
    "@vue/cli-plugin-babel": "~4.2.0",
    "@vue/cli-plugin-eslint": "~4.2.0",
    "@vue/cli-plugin-router": "~4.2.0",
    "@vue/cli-plugin-unit-jest": "~4.2.0",
    "@vue/cli-plugin-vuex": "~4.2.0",
    "@vue/cli-service": "~4.2.0",
    "@vue/eslint-config-standard": "^5.1.0",
    "@vue/test-utils": "1.0.0-beta.31",
    "babel-core": "7.0.0-bridge.0",
    "babel-eslint": "^10.0.1",
    "eslint": "6.8.0",
    "eslint-config-standard": "14.1.1",
    "eslint-plugin-import": "2.20.2",
    "eslint-plugin-node": "11.1.0",
    "eslint-plugin-promise": "4.2.1",
    "eslint-plugin-standard": "4.0.1",
    "eslint-plugin-vue": "6.2.2",
    "vue-eslint-parser": "7.0.0",
    "vue-template-compiler": "^2.5.17"
  }

@KarmaBlackshaw, have you tried https://github.com/babel/babel-eslint/issues/530#issuecomment-598122608?

@TomasBarry  yes, but to no avail.

I've run into these issues before with just the version of babel-eslint but now, I don't really know what to do. Changing babel-eslint version no longer works.

This only occurs on vue-router. Line 1 which is import Vue from 'vue'.

You’re still using babel 6?

@ljharb, These are the only babels I'm only using.
+--<EMAIL_ADDRESS>+--<EMAIL_ADDRESS>+--<EMAIL_ADDRESS>
Perhaps, they need to be matched?

babel-core bridge is only used to be able to use Babel 6, i thought.

I have updated it now to use the latest stable version which is 6.26.3. Still the same. I don't like turning off rules though, but for now, it seems that it is just appropriate. I believe this is just a hack.
indent: [
  'error', 2,
  { ignoredNodes: ['TemplateLiteral'] }
],
'template-curly-spacing': 'off'

Right, Babel 7+ is at @babel/core.

Downgrading to babel-eslint 8.x was the only way I was able to solve this after trying the other suggestions here.


Ingest metadata query implementation

Ingest metadata query -
expose maxIngestedEventTime

closing in favour of another one having write access..


Figure out and implement optimizations for the pyfontaine checks

@davelab6 suggested at #1345 that we could run pyfontaine subprocesses in parallel, starting them very early in the testsuite. This is not simple to achieve with the current architecture, but perhaps can be addressed by @graphicore 's proposal of a new architecture for FontBakery, described at:
https://gist.github.com/graphicore/9456bdbdaf1276b52e56fc817a175058

@graphicore can this be addressed now?

This consists of two parts:

run in paralell.
find a good separation of tests for the parallel processes.

Run in parallel, here means on a multicore processor, right? In Kubernetes we'll do this a bit differently,  via worker instances.
Also, can we rethink the Pyfontaine tests? Most of them fail by default, that's bad.
And, why is it so slow? I did something like this with the specimen tools and it was not even blocking the browser UI, unless I'm missing something. I don't really trust the whole thing.

Uh, yeah, so run in parallel is not so hard to do, but still some work, but I think we have a good standing for this,

This consists of two parts:

run in paralell.

find a good separation of tests for the parallel processes.

Run in parallel, here means on a multicore processor, right? In Kubernetes we'll do this a bit differently, via worker instances.

Well, if you run a k8s cluster locally, then I believe k8s will load-balance a pod of containers across your cores, I think.
...
So yeah:

One cpu, in Kubernetes, is equivalent to: ... 1 Hyperthread on a bare-metal Intel processor with Hyperthreading

https://kubernetes.io/docs/concepts/configuration/manage-compute-resources-container/#meaning-of-cpu

and

For each processor core that is physically present, the operating system addresses two virtual (logical) cores and shares the workload between them when possible.

https://en.wikipedia.org/wiki/Hyper-threading

Also, can we rethink the Pyfontaine tests? Most of them fail by default, that's bad.

Yeah, I was just discussing language support testing with the GF team, and currently its a mess. As you know, CLDR is the current state of the art, and this is packaged in pyfontaine, but, actually language support requires testing a font against 3 things:

encoded glyphs (like in CLDR)
OT feature codes
unencoded glyphs corresponding to the above

AFAIK pyfontaine can only check for 1 and 3 at the moment.

And, why is it so slow? I did something like this with the specimen tools and it was not even blocking the browser UI, unless I'm missing something. I don't really trust the whole thing.

Yep, I have no idea why it is slow. I'm happy to abandon it if we need to.

Uh, yeah, so run in parallel is not so hard to do, but still some work, still I think we have a good standing for this

Ideally I want to have a dashboard showing how the current font collection in production passes/fails every FB check, including language support checks; and how every upstream associated with each of those families passes/fails.
This requires massive parallelism.

Pyfontaine checks were deprecated a while ago, so this issue is now invalid, so I'm closing it.


No handling of duplicated files (identical content, different path) in the uploading of the code to the server.

If the code of a handler contains multiple times a file with the same content, for example, multiple __init__.py files at the root of different packages, only containing the copyright headers, the upload will fail with this kind of error:
Exception: Unable to upload handler plugin code to the server (msg: {'message': 'An unexpected error occurred in the server while processing the request: A file with this id already exists.'})

And somewhere in the logs we can see that indeed we try to upload twice a file with the same id.
INFO     tornado.access:web.py:2243 200 POST /api/v1/file (<IP_ADDRESS>) 1.11ms
INFO     tornado.access:web.py:2243 200 PUT /api/v1/file/2e8c1551b7a261141ff4144fd3908e5051f5ab64 (<IP_ADDRESS>) 1.16ms
INFO     tornado.access:web.py:2243 200 PUT /api/v1/file/e2c256c7be1324c9b5335972a147d68e2ede897b (<IP_ADDRESS>) 1.04ms
INFO     tornado.access:web.py:2243 200 PUT /api/v1/file/208920ec7ffacd098532bd6abc8316c89c9a7231 (<IP_ADDRESS>) 0.74ms
ERROR    tornado.access:web.py:2243 500 PUT /api/v1/file/e2c256c7be1324c9b5335972a147d68e2ede897b (<IP_ADDRESS>) 1.28ms

This comes from the fact that files are identified only by a hash of their content during this upload process.
https://github.com/inmanta/inmanta-core/blob/5bfe60683f7e21657794eaf222f43e4c53540bb5/src/inmanta/loader.py#L61-L69
The upload is happening here:
https://github.com/inmanta/inmanta-core/blob/5bfe60683f7e21657794eaf222f43e4c53540bb5/src/inmanta/export.py#L81-L99

This is a duplicate of #2313 I think.

Indeed, I will close this one.


Wiki don't match with struc

Hi,
In the JPEGDRAW structur is defined as :
typedef struct jpeg_draw_tag
{
  int x, y; // corner offset of this block of pixels
  int iWidth, iHeight; // size of this pixel block
  **uint8_t *pPixels; // RGB565 pixels**
} JPEGDRAW;

but is :
typedef struct jpeg_draw_tag
{
    int x, y; // upper left corner of current MCU
    int iWidth, iHeight; // size of this MCU
    **int iBpp; // bit depth of the pixels (8 or 16)**
    **uint16_t *pPixels; // 16-bit pixels**
    void *pUser;
} JPEGDRAW;

That change may make some trouble for old prog.
Thanks in advance,
(great job, it save me 30ms for better result than the ESP32-cam library)

Thanks for pointing out the discrepancy. I've been lagging on documentation for everything. I fixed it.


feat(delivery): add option to skip seeding prompt

Extracted from #482; part of #347

Merge after #493

@grayside this now skips the seeding account name prompt instead of skipping seeding entirely.

@updatedigital.com


Not an issue, but a thank you

Hey @profzei
I just wanted to extend a thank you for all of your efforts and hard work in getting this project as far as it has gotten over the past year. Can't thank you enough for your consistent support and guidance regarding this project.

I see you have been hard at work over the past few weeks rebuilding the patches for Big Sur and to ensure better support across the patches.
Really looking forward to your latest update, if you require any assistance with anything just let me know!
PS: Maybe it's time to set up a donate link 👍
All the best!
R

Thank you very much for your feedback!
With latest release I'm pretty sure Catalina is very stable!
I only hope Big Sur is the same... even if I read about some issues in power management (in Big Sur with high cpu occupancy due to kernelmanagerd...) probably due to apps or extensions not yet fully compatible with BS!
PS: btw I don't even know how to setup a donate link! XD

@profzei You should sign up on PayPal.  The coffee is flying to you. Thanks for your work.

@Vatri91 ...Thank you very much! I'm doing this for fun (but sometimes it's also very stressing... XD), but honestly I didn't expect so much appreciation! ;)

I would also gladly donate. For keeping your github updated and actively responding here.

@profzei I want to add my Thank you to this thread. Thanks to you I could really enjoy my MBXP with a great operative system, and as a geek enjoyed the process of setting the Hackintosh in my own laptop. This has been kinda frustrating getting to understand how the system works, but you have made an excellent job in your tutorial and explaining everything.
You are great, keep rockin'!

I just saw the donate button on your repo. Just shot you 5 Euro! Coffee's on me

@mmenendezg @wiregen Thank you so much for your appreciation!

Yes, thank you a lot @profzei as it's the only working solution for my MBXP 2018 to use Big Sur and it has been so fluent to use your EFI (I've been stuck for long to upgrade to Big Sur until I find that you've got an awesome macOS 11 solution!)

Yes, thank you a lot @profzei as it's the only working solution for my MBXP 2018 to use Big Sur and it has been so fluent to use your EFI (I've been stuck for long to upgrade to Big Sur until I find that you've got an awesome macOS 11 solution!)

Thank you very much for your work.

Thank you very much for your work.

I've already expressed my gratitude in another post, but want also to say thank you here. I've never been happy with my Huawei. The device is really nice, but the experience on Windows/Linux was not very good (specially on windows). So my laptop was sitting in one corner getting dust... until I found this guide, and thanks to it, the laptop as become again my main computer and I'm enjoying it like never using Catalina. It's the closest experience to Mac that I've experimented!
Again, thanks !
Roberto

I'm testing new versions and tweaks of your work right now, and everything works perfectly. WOW. The project evolved from curiosity to a fully functioning system that I use on a daily basis. I don't even have Windows anymore.
Thank you so much

@Vatri91 Thank you very much for your appreciation!


Create examples and tests for principal.go

in examples update bin, cmd and Inspec

fixed by #188


[Bug] Node would only consider fork if another chain is longer than own chain, regardless of cumu_weight

🐛 Bug Report

When a node is trying to determine is_fork, it seems the node would only think it's fork if the other chain's height to be greater than or equal to the own chain. This could make a node unable to switch to a heavier chain for quite a while.
Steps to Reproduce

Consider the following logs:
2021-12-03T07:25:45.558311Z DEBUG Status Report (type = Miner, status = Ready, block_height = 10659, cumulative_weight = 30377, block_requests = 0, connected_peers = 3)
2021-12-03T07:25:45.289141Z DEBUG Peer <IP_ADDRESS>:4132 is at block 10657 (type = Miner, status = Mining, is_fork = undecided, cumulative_weight = 31777, common_ancestor = 10466)

Here the heavier chain is shorter than our own chain, so is_fork remains in undecided although the other chain is considerably heavier.
I've shut down the node and waited for a while:
2021-12-03T07:27:23.812487Z  INFO Ledger successfully loaded at block 10661
2021-12-03T07:27:25.893890Z DEBUG Peer <IP_ADDRESS>:4132 is at block 10661 (type = Miner, status = Mining, is_fork = true, cumulative_weight = 31781, common_ancestor = 10470)

Then the node started to switch over to the heavier chain. If I continue to mine in my own fork and I'm producing blocks fast enough, the node would keep on the lighter chain for quite a while as the block interval is supposed to be constant.
Expected Behavior

The node should be able to switch to a heavier chain regardless of the length of the chains.
Your Environment

snarkOS @a4f6936

Another example:
2021-12-03T07:43:34.355907Z DEBUG Peer <IP_ADDRESS>:4132 is at block 10686 (type = Miner, status = Mining, is_fork = undecided, cumulative_weight = 32309, common_ancestor = 10638)
2021-12-03T07:43:38.794076Z DEBUG Status Report (type = Miner, status = Mining, block_height = 10687, cumulative_weight = 31809, block_requests = 0, connected_peers = 2)

After a while:
2021-12-03T07:44:33.163644Z DEBUG Status Report (type = Miner, status = Ready, block_height = 10689, cumulative_weight = 31811, block_requests = 0, connected_peers = 2)
2021-12-03T07:44:35.219691Z DEBUG Peer <IP_ADDRESS>:4132 is at block 10689 (type = Miner, status = Mining, is_fork = true, cumulative_weight = 32315, common_ancestor = 10638)
2021-12-03T07:44:42.664688Z  INFO Discovered a canonical chain from <IP_ADDRESS>:4132 with common ancestor 10638 and cumulative weight 32315

Candidate fix: #1373

Similar example (miner continues to mine a fork obviously):
Dec 06 12:22:54 nba74b9 snarkos[9018]: 2021-12-06T12:22:54.599079Z DEBUG Peer <IP_ADDRESS>:4132 is at block 19985 (type = Miner, status = Mining, is_fork = undecided, cumulative_weight = 3408859, common_ancestor = 18898) Dec 06 12:23:11 nba74b9 snarkos[9018]: 2021-12-06T12:23:11.524271Z DEBUG Peer <IP_ADDRESS>:4132 is at block 20077 (type = Miner, status = Mining, is_fork = undecided, cumulative_weight = 3075171, common_ancestor = 18990) ... Dec 06 12:24:00 nba74b9 snarkos[9018]: 2021-12-06T12:24:00.519739Z DEBUG Status Report (type = Miner, status = Ready, block_height = 21085, cumulative_weight = 1876786, block_requests = 0, connected_peers = 20) 2021-12-06T12:25:05.731265Z  INFO Mining Report (confirmed_blocks = 0, pending_blocks = 1797, miner_address = aleo1nscuwq4n55autt2uldnxjwgs7jq6wyktlldkrqyazkgpv7v3k5gqwn9229)
Still didn't catch the longer chain.

Is this issue still applicable?

For me it's ok, I did not observe such behavior recently.

The network is pretty stable now so this is not an apparent issue. However I believe in an unstable environment it will still be an issue.

Marking as likely fixed, then, but leaving it open so it doesn't get forgotten.

Not applicable to testnet3.


cornerRadius property override error

I'm getting an error on the cornerRadius property declaration: "Overriding declaration requires an 'override' keyword"
@IBInspectable public var cornerRadius: CGFloat = 0 {
    didSet {
        layer.cornerRadius = cornerRadius
    }
}

Anyone is getting the same eerror with iOS 8.3 SDK ?
It is possible to fix by replacing the declaration with:
@IBInspectable public override var cornerRadius: CGFloat  {
didSet {
layer.cornerRadius = cornerRadius
}
}
Note that the compiler complains also about the initialization value.

You have two choice:

optional var
cornerRadius: CGFloat?
// or
cornerRadius: CGFloat!

non optional var must have initial value
cornerRadius: CGFloat = 0
// or
init(){
cornerRadius = 0
super.init()
}

I'm not able to reproduce the compiler error in Xcode 6.4 and iOS 8.4.
@giacomopiva If this problem has now been solved, we can close the issue.

I did download a fresh copy from master and I test it on a new project with SDK 8.4 and Xcode 6.4 and I didn’t get the error again.

Great! Thank's for your feedback! :+1:


Add Python 3 support.

Without dropping Python 2 support.

Thanks for patches! Looks fine, merging (trusting you have tested...)


Fix bookmark redirecting to worng content

PR Fixes:

1 Bookmarks Redirecting to worng content

Resolves #684
Checklist before requesting a review

[x] I have performed a self-review of my code
[x] I assure there is no similar/duplicate pull request regarding same issue

/bounty $5

/bounty $5

Hi @hkirat,
Thank you, sir, for awarding the $5 bounty. As I'm not part of the cohort, am I still eligible to redeem it? If so, could you please let me know how to proceed?


FR: Setting for ‘XP Award’ listed on Tracker to not take Party Size into account to better match RAW

Since it’s just cosmetic and you can usually do simple math while hovering the current number to do this I get why you might not want to add a setting like this, but I figured since it has rules support it’d be worth asking. Thanks either way; I really appreciate all your guys have done.
https://2e.aonprd.com/Rules.aspx?ID=574
Page 507 of CRB “ When the group overcomes an encounter with creatures or hazards, each character gains XP equal to the total XP of the creatures and hazards in the encounter (this excludes XP adjustments for different party sizes; see Party Size on page 508 for details)”
Under Party Size on Page 508 of CRB: “The rules for advancement assume a group of four PCs. The rules for encounters (page 489) describe how to accommodate groups of a different size, but the XP awards don’t change—always award the amount of XP listed for a group of four characters.”

The math being done changes the XP budget per these guidelines. Effectively we normalize the adjustment from page 498 to number of players. Are you asking that we simply sum all the XP and divide by 4 instead of normalizing to the tier per the rules?
Right now, the system will, say for an encounter budget of moderate (80 XP) for four players will convert the excess XP for 6 players (80 XP plus 20 plus 20 for a total of 120 XP) back to 80, which is the intent of the rules you’re quoting - awarding all players 80 XP per the direction of “award the XP as if there are 4 players” directive. What is your specific ask for the recomputation? What value should the XP be, because the rules you reference lead to this scenario.

Ah, I see what you mean. And I now realize that you can pretty much always get the number I’m asking for by looking at the first anyways. Sorry for the confusion.


Need to be added as collaborator

I originally set this up with my home user git account. I would prefer to do this class from my work account

Huntsville is in Alabama


BUG: reload_symbol_maps should clear the equity_supplementary_maps

Coverage decreased (-0.05%) to 87.168% when pulling 70d78afa720820e978660d5d662c24c66a3762ea on clear-supplementary-map into 8ef2279ee4b775f1c66a2baa31400cce4cae6055 on master.

Hey @llllllllll could you give me an example of when this occurs/why we want to clear equity_supplementary_maps?

This is useful when you are are writing to the underlying assets db. After each write you need to clear the internal caches.

Ok. I understand that. Do you think this warrants any tests to be added?

I don't think the tests will add much value because it will not automatically ensure that this actually reloads the cache without tightly depending on the implementation of the asset finder. It's probably fine to omit them for now.


Update README.md

This PR updates the README.md document.  I tried to give a description of PolicyBrain that had a technical tilt.  I included the new local deployment steps.  I still need to add the production and test server deployment steps.  However, I think this would be a little too much for the README.md document.  So, I think we should move the deployment information to a separate document.  I also need to add a contributing guide.
I appreciate all feedback on this document.  It could be formatted completely differently if we think that would be helpful.  I recommend checking out the README.md documents for other projects such as Pandas and NumPy.  I liked NumPy's concise style and use of bullet points.  I thought that made it easier to read.  It seems like there is a fairly large variation in README styles.  For example, compare Scipy's README with NumPy's.

@hdoupe,  Big improvement in the README.md text.  Thanks.

Looks great. +1

@brittainhard In the following line, I wanted to briefly describe PolicyBrain's technology stack.  Do you have any input on how this was worded?
"PolicyBrain is a Django app which is deployed on Heroku and uses Flask, Celery, and Redis to schedule jobs."
Specifically, I'm not sure if I got the "...uses Flask, Celery, and Redis to schedule jobs." part right.

@hdoupe i'll take a look at that wording.

Thanks @brittainhard

@hdoupe I think you are on point with the stack description. LGTM.
However, this got me thinking. I'm not sure someone can get the local application running without taxpuf. This is an issue that is long-standing. We need a way for people to develop on the application without needing taxpuf, since it is private.
I don't know if there is an issue open for this or not. @MattHJensen @PeterDSteinberg do you recall if we came up with a solution for this?

@brittainhard Thanks!

However, this got me thinking. I'm not sure someone can get the local application running without taxpuf. This is an issue that is long-standing. We need a way for people to develop on the application without needing taxpuf, since it is private.

I ran into this problem this afternoon.  I re-cloned my local PolicyBrain directory after the release and forgot to include the PUF file until this afternoon.  I was able to look at the parameter input pages, but I got an error when I tried to submit a reform.  By the end of the year, we will have an option for users to use the CPS.  At that point, you could run the full model without the PUF file.

@brittainhard said in the discussion of PR #702:

However, this got me thinking. I'm not sure someone can get the local application running without taxpuf. This is an issue that is long-standing. We need a way for people to develop on the application without needing taxpuf, since it is private.

This problem will be solved once PolicyBrain starts using the taxcalc>=0.12.0 package.  One of the enhancements in 0.12.0 is to make the taxbrain interface or tbi functions work with either the puf.csv or cps.csv input files.  See Tax-Calculator pull request 1577 for details.
@MattHJensen @hdoupe @GoFroggyRun

Unless someone objects, I plan to merge this on Wednesday (10/25).


Team Email addition to Team Contact

Request:
Currently we can add a PO and 2 Tech Lead Contact's to the OpenShift registry. We would like to be able to add our team email as a contact.
Context:
Team members graduate from our team on a 6 month to 1 year timeline. We take on applications that have not had an active team maintaining them. The registry Team Contacts section can be out of date when we pick up an application.
During our team onboarding/offboarding we update the Team Contacts section.
Due to flex days and needing coverage we would like the entire team to have insight into OpenShift related issues that arise. We can currently create an email rule that forwards emails to the team email. But this is another thing we need to manually update when a dev leaves/graduates to another team.

This ticket can be related to the ticket about the Other Contacts #

This work will be compete with the ticket #3097 that is almost completed and is in testing now.


Prometheus Histogram edge case which we don't support

Form the documentation sum is not always present and MUST NOT be present in some scenarios, see:

Negative threshold buckets MAY be used, but then the Histogram MetricPoint MUST NOT contain a sum value as it would no longer be a counter semantically.

This is a very strange edge case to make things work with Prometheus, and I don't know how we can support this and enforce it.
One option is to have https://github.com/open-telemetry/opentelemetry-proto/issues/187 in the data model. This will not work that good, because receiving an OM without a SUM may imply negative buckets are "possibly" present, but it is not guaranteed to be, and next point may contain a SUM? <- @RichiH is this possible?

Notes from March 3 Prometheus-WG meeting:
Brian, RichiH note that "if there are no negative bucket boundaries, there are no negative observations."
Bogdan will file an issue on OM to clarify assumptions and alignment with specification.

If the implementor anticipates negative thresholds, then the Histogram MetricPoint MUST NOT contain a sum value. Depending on if it's a gap in spec or unclear, fix will go into spec proper or Considerations section.


Cannot use CLI or env vars to set registry.search array

Background
registry.search is meant to be an array of URLs to use for searching for bower components. I'd like the equivalent of this .bowerrc:
{
  "registry": {
    "search": [
      "https://my-private-bower-registry",
      "https://bower.herokuapp.com"
    ]
  }
}

In my particular case, env vars or CLI args are the most convenient way to configure this (the build server I'm running on exposes no concept of the current user or global, so I can't configure my .bowerrc "globally", and it would not be maintainable to put this configuration in each of the N Bower components I'll be calling bower install from on the build server).
Attempts
I've tried different variations on the following types of things:
bower install --config.registry.search=["https://my-private-bower-registry", "https://bower.herokuapp.com"]

set bower_registry__search__0="https://my-private-bower-registry"
set bower_registry__search__1="https://bower.herokuapp.com"
bower install

Actual results
The first one results in config like
{
  "registry": {
    "search": "[\"https://my-private-bower-registry\",\"https://bower.herokuapp.com\"]"
  }
}

That is, a string in the shape of an array
The second results in config like:
{
  "registry": {
    "search": [
        { "0" : "https://my-private-bower-registry", "1" : "https://bower.herokuapp.com" }
    ]
  }
}

And Config.js line 65 barfs on this shape.
Is it impossible to do what I'm trying to do?

Bower now accepts arrays in cli & env args


Fix test issue to unblock further commits

Contributing to the Azure SDK
Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.
For specific information about pull request etiquette and best practices, see this section.

API change check
API changes are not detected in this pull request.


Extend PrintActionSimpleType enumeration

To cater for more printer actions it is suggested the PrintActionSimpleType enumeration to be extended to also hold
PauseJob, ResumeJob, FailedPrint and to cover for all other eventualities Other

merged in #9

Fixed in v3.1.0


Integrate library into own library

Hello,
i wanted to add the cpr library to my library. After some trial and error I came across the error:
CMake Error: install(EXPORT "MyLib" ...) includes target "mylib" which requires target "cpr" that is not in any export set.

What is the best way to include a library?

Have you try this: https://github.com/whoshuu/cpr#usage? Also you could try with vcpkg.
You should probably open an issue in their project, to get a better answer from them. I don't see how cpr is related to this cmake-example-library?


Particle corruption in Assassin's Creed Odyssey under Windows

This is running on the latest 22.1.2 Optional (WHQL) driver with a 5700XT, but this issue has persisted throughout multiple driver iterations until now; previously on Windows 10, now under Windows 11 with the latest updates. I've made sure this isn't happening because of a dxvk.conf flag or environment variable.
I haven't tested dxvk versions below 1.9.1, but it could be some sort of regression, as I remember it being an issue and having been fixed after an update a while(years - likely 2020) back.
It appears to affect only some specific type of particle, only in specific parts of the world map, and especially at night - although step dust particles in caves are always a surefire way to reproduce this. Here's the location pictured in the screenshot above:

PS: I've filed a bug report to AMD describing this bug approximately half a year ago(as they have had some driver woes in the past), and have gotten no response in return; it does only affect the game running through dxvk, I suppose. Game runs perfectly otherwise.

Driver bug.
Duplicate of:
#2390 #2326 #2355 #2390


Feature deleted records

Looks good -- I like making the sqlite verb into a variable and pulling the Sickle exceptions into the main namespace. Is this ready to test + merge?

I believe so, yes.  Note the change to how item identifiers are located.

Hitting this when trying to harvest Islandora:
[axfelix@nixon globus_oai]$ python3 globus_harvester.py
Traceback (most recent call last):
File "globus_harvester.py", line 657, in
oai_harvest_with_thumbnails(repository)
File "globus_harvester.py", line 530, in oai_harvest_with_thumbnails
sqlite_write_record(oai_record, repository["url"])
File "globus_harvester.py", line 338, in sqlite_write_record
for subject in record["subject"]:
TypeError: 'NoneType' object is not iterable
I previously just used if "subject" in record: for inserts into all of the non-records tables (creators, subjects, rights, descriptions); any reason we wouldn't want to do that here?

Yes I saw that, working on it already

Oh, I see, I think the way you're fetching the objects now may be passing the if "x" in record test; you probably want to change them to if "x" in record and record["x"] is not None:

Try that now.  I was flattening metadata, forgetting that some of them need to be lists.

I'm dumping a lot of logging into the logs right now, but you'll notice that a number of records are "none".  I'm going to look into why that is... maybe they're missing a key piece of metadata?  I saw some from SP that didn't have a creator...

One of my hardcoded rules in earlier versions of this script was no creator == dump the record; I'm not sure if that's still there, but it shouldn't be being triggered for very many SP records.

Yeah I had messed that up, it's back to working

I also rewrote the secondary table inserts so they can handle both lists and strings, since I wasn't sure if future repos might break that

Seems good now. One other thing I noticed: The try on line https://github.com/usask-rc/globus_oai/blob/feature_deleted_records/globus_harvester.py#L717 will always fail if there isn't a gmeta_filepath in the config; unlike temp_filepath in https://github.com/usask-rc/globus_oai/blob/feature_deleted_records/globus_harvester.py#L648, you never assign a default.

Hm, I think you might've broken the dc.source URL links for Islandora...

Also, general note -- this is probably getting complicated enough that we should pull it out into multiple files rather than just the one. But that doesn't have to be part of this PR :)

Agreed, I was thinking yesterday that it was close to refactoring time

Not to be too much of a pain, but isn't it easier to use the hardcoded Islandora URL workaround from master rather than having to add a bunch of stuff to config?
	# islandora
	if "/oai2" in record["repository_url"]:
		local_url = re.sub("\/oai2", "/islandora/object/", record["repository_url"]) + record["local_identifier"]
		return local_url

I'm trying to make it easier/faster for us to add new repos in the future without having to do any coding changes, just add a new config block.

I get it -- it's technically cleaner overall, but I'm afraid it's actually more complicated in practice. If I encountered "action:prepend" and "action:replace" in the JSON config as an end-user I'd actually have a harder time trying to figure out what I wanted to do than just adding a few hardcoded workarounds.
If you'd rather pull this out of the main script, we can use this as an excuse to start the refactor, and import oai_repository_workarounds for this block...

Can't do that easily, as your code no longer works (it doesn't yield resolvable URLs).  Since grabbing the id from the header, it's no longer in the form "islandora:134" rather they look like "oai:researchdata.sfu.ca:islandora_134" so if you append that to the base URL, you get this:
http://researchdata.sfu.ca/islandora/object/oai:researchdata.sfu.ca:islandora_134

So I'd rather commit code and configs that work now, and then refactor later

Also, I'm still working on getting the thumbnails back into the gmeta json, looks like they're missing right now.  Not ready for pull request to be accepted yet.

K -- all sounds good. Just got this from most recent checkout, btw:
$ python globus_harvester.py
Traceback (most recent call last):
  File "globus_harvester.py", line 709, in <module>
    update_stale_records()
  File "globus_harvester.py", line 284, in update_stale_records
    logger.info("Updated %s items in %s (%.1f items/sec)", record_count, humanize_time(time.time() - tstart),record_count/(time.time() - tstart))
ZeroDivisionError: float division by zero

I was encountering an error if the gmeta file wasn't there, the os.remove() would fail, so I put it into its own try block.  However this does mean if the file is there but can't be removed, then that's bad. More work probably needed here... :|

I looked at the generated gmeta file and I think it's OK now Alex

Really, truly, probably, maybe done now.

Looks good! Merging.
Incidentally, how long have we been using dc.contributor.author in the output gmeta rather than dc.creator? Was that requested by globus for some reason? It seems wrong in hindsight...


FP16 doesn't work

using the --fp16 command results in this error:
RuntimeError: Input type (float) and bias type (struct c10::Half) should be the same

I'm very sorry about this, I just inherited inference_video.py, and didn't maintain all its functions on GMFSS, it is known that --montage and --fp16 should not work properly, --UHD is also de facto obsolete state.
And I have doubts about the effect of using FP16 to infer GMF. If I just want to try GMFSS_union under 8G video memory, I can add a mixed precision modification to do this.


Implement Constantinople fork

(closes #434 )
(closes #435 )
(closes #436 )
Adding the Constantinople fork. The PR is still in the draft stage since it waits for the Byzantium Precomplies and will need to be patched on top of those.
EIP-145, EIP-1052 and EIP-1234 are complete and can be reviewed. Some tests from EIP-1052 fail because they also need EIP-1014.
Cute Animal Picture

@SamWilsn This is now ready for review.
I have marked the tests that depend on create2 as slow for now.
Also marked stSStoreTest/InitCollision_d0g0v0.json as slow. This is similar to the case that @voith pointed out some time back where a current_target has no nonce and balance but has some storage.

@gurukamath can you please give me permissions to your copy of the execution specs so as to add commits corresponding to CREATE2. Thanks!

I'm getting one failed test after I rebased and ported some stuff:
FAILED tests/constantinople/test_state_transition.py::test_create2[stCreate2/RevertInCreateInInitCreate2_d0g0v0.json

Did I break something?

I'm getting one failed test after I rebased and ported some stuff:
FAILED tests/constantinople/test_state_transition.py::test_create2[stCreate2/RevertInCreateInInitCreate2_d0g0v0.json

Did I break something?

@SamWilsn @voith This appears to me to be another one of those zero nonce, zero balance but having some storage accounts. Voith's PR will fix this.

You're right. RevertInCreateInInitCreate2_d0g0v0 is similar to InitCollision_d0g0v0 and it should added to the incorrect upstream tests list.

@SamWilsn
Cleaned up the following parts of tests/constantinople/test_state_transition.py

Unmarked all but 6 tests that were previously marked as slow, since create2 is now implemented. These 6 tests will be handled by #489
Removed the test_create2 function to prevent create2 tests from running twice

@voith
Found 4 more tests (in addition to the earlier 2) with zero nonce and balance but non-zero storage
stSStoreTest/InitCollision_d0g0v0.json
stSStoreTest/InitCollision_d1g0v0.json
stSStoreTest/InitCollision_d2g0v0.json
stSStoreTest/InitCollision_d3g0v0.json
Curiously however, stSStoreTest/InitCollision_d2g0v0.json passes for constantinople. Might be worth investigating.

I think this is good to merge now? :tada:


[ClangImporter] Use appropriate link name for export_as

Skip linking with module name when using export_as and that module is imported.
See https://github.com/apple/swift-clang/pull/176 for additional details.
rdar://problem/38269782

Please test with following pull request:
https://github.com/apple/swift-clang/pull/176
@swift-ci Please test

Looks fine, though I guess it may change based on the other review. Can you include a test where SomeKit is not imported as well?

Also, when you do land this it should go to master too.

Added one more testcase as suggested by Jordan.

Doug's feedback addressed.

Please test with following pull request:
apple/swift-clang#176
@swift-ci Please test

Build failed
Swift Test OS X Platform
Git Sha - c2232b9075cfaa922ae4b304601c82a2d9eca81e

Build failed
Swift Test Linux Platform
Git Sha - c2232b9075cfaa922ae4b304601c82a2d9eca81e

This looks good, but (again) should be committed to the master branch, not swift-4.2-branch.

(I suppose it could get cherry-picked since it's causing problems in one of our internal builds.)


[REQUEST] Add Support For Multiplexed Instruments in Pinmap

Describe the Problem
I am having an issue with SetupNIDCPowerInstrumentation function when using multiplexed channels in pinmap.
I am investigating if I can use this library in my new project, where I am planning to use semiconductor module.
I am using a pinmap where I have different pins that are sharing same SMU channel by using simulated multiplexer.

In this case I get an error in Setup NI DCPower Instrumentation step saying: An item with the same key has already been added at System.ThrowHelper.ThrowArgumentException(ExceptionResource resource)  at System.Collections.Generic.Dictionary`2.Insert(TKey key, TValue value, Boolean add)

When I try it with pinmap that doesn't have multiplexed smu channels there is no error.
It seems to me that this scenario is not supported by the library
To Reproduce
Create a simple empty project.
Modify Pinmap to have a multiplexed SMU channels.
Try to run it.
It will throw an error in process setup on Setup NI DCPower Instrumentation step.
Expected behavior
I would expect this kind of pinmap to work with the library.

@noffz-nvidakovic, thank you for reporting this. While I am able to reproduce this, note that multiplexers are not yet supported by the library. This applies to both simulated and physical multiplexers. Therefore, this would be better addressed as a Feature Request, rather than a Bug, to be addressed in a future release.
To allow for better tracking, I suggest updating the title and the content/tags such that it reflects a Feature Request instead of a bug. If I have your permission, I will take care of this for you, please just confirm.

For the record, here is a simplified example pin map, which does not currently work with the library, but would once multiplexer support is added in a future release:
<?xml version="1.0" encoding="utf-8"?>
<PinMap schemaVersion="1.6" xmlns="http://www.ni.com/TestStand/SemiconductorModule/PinMap.xsd" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance">
	<Instruments>
		<NIDCPowerInstrument name="SMU_4147_C1_S04" numberOfChannels="4">
			<ChannelGroup name="CommonDCPowerChannelGroup" />
		</NIDCPowerInstrument>
		<Multiplexer name="Multiplexer1" multiplexerTypeId="" />
	</Instruments>
	<Pins>
		<DUTPin name="DUTPin1" />
		<DUTPin name="DUTPin2" />
	</Pins>
	<PinGroups></PinGroups>
	<Sites>
		<Site siteNumber="0" />
		<Site siteNumber="1" />
		<Site siteNumber="2" />
		<Site siteNumber="3" />
	</Sites>
	<Connections>
		<MultiplexedConnection instrument="SMU_4147_C1_S04" channel="0">
			<MultiplexedDUTPinRoute pin="DUTPin1" siteNumber="0" multiplexer="Multiplexer1" routeName="Site0_DUTPin1" />
			<MultiplexedDUTPinRoute pin="DUTPin2" siteNumber="0" multiplexer="Multiplexer1" routeName="Site0_DUTPin2" />
		</MultiplexedConnection>
		<MultiplexedConnection instrument="SMU_4147_C1_S04" channel="1">
			<MultiplexedDUTPinRoute pin="DUTPin1" siteNumber="1" multiplexer="Multiplexer1" routeName="Site1_DUTPin1" />
			<MultiplexedDUTPinRoute pin="DUTPin2" siteNumber="1" multiplexer="Multiplexer1" routeName="Site1_DUTPin2" />
		</MultiplexedConnection>
		<MultiplexedConnection instrument="SMU_4147_C1_S04" channel="2">
			<MultiplexedDUTPinRoute pin="DUTPin1" siteNumber="2" multiplexer="Multiplexer1" routeName="Site2_DUTPin1" />
			<MultiplexedDUTPinRoute pin="DUTPin2" siteNumber="2" multiplexer="Multiplexer1" routeName="Site2_DUTPin2" />
		</MultiplexedConnection>
		<MultiplexedConnection instrument="SMU_4147_C1_S04" channel="3">
			<MultiplexedDUTPinRoute pin="DUTPin1" siteNumber="3" multiplexer="Multiplexer1" routeName="Site3_DUTPin1" />
			<MultiplexedDUTPinRoute pin="DUTPin2" siteNumber="3" multiplexer="Multiplexer1" routeName="Site3_DUTPin2" />
		</MultiplexedConnection>
	</Connections>
</PinMap>


Site should put some "nyaa" in header or footer for better search engine ranking.

Googling  "nyaa", the Pantsu is in the second page (people do not click second page) and the page is FAQ, because it is the only page where the string nyaa can be found by Google crawler. Maybe the site icon should be change to plain text that explicit mentioned nyaa.

We do have some SEO https://github.com/NyaaPantsu/nyaa/blob/dev/templates/index.html#L7.
Not sure how much it affects this issue but google is removing a lot of links from us https://www.google.com/transparencyreport/removals/copyright/searchdata/domains/?id=pantsu.cat

A minimal change that might help is

Add a space in the footer, from "Powered by NyaaPantsu" to "Powered by Nyaa Pantsu"
Add a space in the alt text of the logo.


Porting from 1.11 to 1.12

I added Minetweaker/crafttweaker support  to my mod in 1.11. But now in 1.12 alot of methods are gone and all classes have been renamed at first why?, Is there any big reason or just because of old name -> new name? And also back in 1.11 I used minetweaker.MineTweakerAPI#registerClassRegistry(String) to regsiter everything... what has happend with this method and how do I fix this ?

The api changed, the old api was semi based on reloading, which is no longer a thing, so big changes had to be made.

you can use @ZenRegister to automatically register the class.
Take a look at existing examples :)
https://github.com/jaredlll08/ModTweaker/blob/1.12/src/main/java/com/blamejared/compat/actuallyaddition/AtomicReconstructor.java

SO @ZenRegister works alot like @Mod or @JEIPlugin ?

yes


Update MediaInfo

Could we update mediaInfo?
We are using Version 0.7.67, 2013-01-10 and current one is Version 0.7.87, 2016-06-30
3 years of boost performance etc 👍

3.6 has the latest version.


Force preview scene to match project resolution

This PR aims to fix low res previews by forcing the control nodes to be resized when the plugin is initialized.

After testing this don't break anything from the original behavior so its good for me
But since I could not reproduce the behavior from the issue I could'nt say if the fix work
Since I could not reproduce the behavior from the issue I couldn't say if the fix work,
But this I tested and this don't break anything from the original behaviors + It's globally a good addition to ensure this respect resolution
So its okay for me ! 👍

Since I could not reproduce the behavior from the issue I couldn't say if the fix work,
But this I tested and this don't break anything from the original behaviors + It's globally a good addition to ensure this respect resolution
So its okay for me ! 👍

I closed this PR since this target an old version of the plugin


Hiding host’s telephone number on HousingResources list

During selecting host for submission host's telephone number should be only visible after clicking “Dzwonię” (eng. I’m calling) button.
(but HousingResources should be still searchable by host number).

Motivation: sometimes users forget to mark outcome after call and the same hosts are called multiple times.

Sorry, seems I'm late and this has already been implemented... :-)


sqlite-net-pcl super slow in loading database on android... it takes 20 seconds to display data.

https://www.nuget.org/packages/sqlite-net-pcl
I tried it on android phones, Android TV, Android tablet.
my database file is already store on filesystem from embedded resource stream...
20+ seconds to display data. sometimes it fast but always take long to read.. here the all database file samples.
https://github.com/fangniude/bible-data/blob/master/bibledata-en-asv.zip?raw=true
.NetStantard 2.0  to Net Maui project.
public IEnumerable<books> GetBooks()
        {
            using (var session = new SQLiteConnection(SqlFilePath))
            {
                List<books> books = null;
                try
                {
                    books = session.Table<books>().ToList();
                }
                catch
                {
                    if (File.Exists(SqlFilePath))
                    {
                        File.Delete(SqlFilePath);
                    }

                }
                return books;
            }
        }
public IEnumerable<chapters> GetChapters(books books)
        {
            using (var session = new SQLiteConnection(SqlFilePath))
            {
                var items = session.Table<chapters>().Where(p=>p.reference_human == books.human).ToList();
                return items;
            }
        }

I will upload loading time...
https://user-images.githubusercontent.com/73583588/170488415-abbf443b-a460-4f53-acc7-855e3a49e6bf.mp4
//new update
<PackageReference Include="sqlite-net-pcl" Version="1.8.116" />
		<PackageReference Include="SQLitePCLRaw.core" Version="2.1.0" />
		<PackageReference Include="SQLitePCLRaw.bundle_green" Version="2.1.0" />
		<PackageReference Include="SQLitePCLRaw.provider.dynamic_cdecl" Version="2.1.0" />
		<PackageReference Include="SQLitePCLRaw.provider.sqlite3" Version="2.1.0" />

I have found slowness as well.  I have not looked at too hard yet.  I manually coded the SQL and it performed.

Not sure what is causing OP's slowness problem, but their package config is weird.
Having Microsoft.Data.Sqlite and sqlite-net-pcl might be causing problems, because both are built on SQLitePCLRaw, and might be bringing in different configurations.
Ignoring that...
If you have sqlite-net-pcl, it is bringing in SQLitePCLRaw.bundle_green.  You can explicitly reference that package to bring in a newer version, which you are doing.
However, if you do that, you don't need to explicitly reference SQLitePCLRaw.core or the two providers.  The bundle_green package references these for you.


pull request for e2e test at 01/26/2017 21:26:10

:white_check_mark: Validation status: passed
For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Create Unit test for sign up for an account

Scenarios for unit test:
Create a new account
a) Valid email address
b) Empty email field -error message
c) Empty password field - error message
Password must be at least 8 characters with letters (TBC)
d) Password is less than 8 characters - error message
e) Password is 8 characters or more
f) Create account button
g) Log in button

Thank you for creating this issue.
We are reviewing our approach to testing + will update the guidance around testing once that is completed.


RenderBuffer of vector layer

In relase OL3-Cesium v1.20 the renderBuffer of vector layer does not display label and point symbol properly.

Do you mean in the OL3 map?

Have you checked the OL3 changelog? There are some lines about the renderbuffer.

Yes. I use ol3-cesium for vector layer view in 2D and 3D Mode. The latest version  ol3-cesium 1.20 incorrectly displays the vector layer point objects.They are cut off by the extents of the layer -- С уважением,Вячеслав Серебряков   02.09.2016, 19:35, "gberaudo" notifications@github.com:Do you mean in the OL3 map?—You are receiving this because you authored the thread.Reply to this email directly, view it on GitHub, or mute the thread. OL3-Cesium v1.20


update to polkadot v0.9.9

https://github.com/paritytech/polkadot/releases/tag/v0.9.9
https://github.com/paritytech/cumulus/tree/polkadot-v0.9.9
https://github.com/paritytech/substrate/tree/polkadot-v0.9.9

closed in #98


CMAKE_SOURCE_DIR vs. CMAKE_CURRENT_SOURCE_DIR

the top level CMakeLists.txt line 43 is setting the scripts directory based on CMAKE_SOURCE_DIR.  This will cause failure to find the scripts if this project is included as a subproject of another.
Using CMAKE_CURRENT_SOURCE_DIR instead fixes this issue.
Unfortunately I can't make pull requests from here or I'd throw one.

Fix pushed to Master -- Thanks @Delwin9999.
commit 3e0a252daa55dc92df88aadf1507df9b382633a8
Author: Mark Lobodzinski<EMAIL_ADDRESS>Date:   Tue Jan 31 07:35:19 2017 -0700
cmake: GH1428, Reenable subproject builds

SCRIPTS dir was defined using CMAKE_SOURCE_DIR which prevented LVL
from building correctly if used as a subproject. Changed to use
CMAKE_CURRENT_SOURCE_DIR.

Change-Id: I201fcfde78b65df80c3c74373a26e4d518770806


Deploy the frontend with GitOps Style

[x] deploy the app with k8s
[x] #30
[x] logging with prometheus

close with issue #30


[incubator][VC] complete secret syncer

dws service account token type secret remove event
check service account token secret of tenant

Signed-off-by: zhuangqh<EMAIL_ADDRESS>

/lgtm
/approve


Unify vocabulary.  In Pub/Sub, there is no such thing as a queue.  An…

…d I used the word 'task' without ever clearly defining it.

I'll take a look later today.

Basically looks good, modulo the comment re: whether you want to ensure that app versions each have their distinct topics and subs.  However, I think it would be helpful to be more explicit that you're publishing/getting pubsub messages, instead of using the term 'request'.  I made a few notes on that.

I changed "shout request" to "shout request message" wherever appropriate.
I considered adding a version suffix to the topic and subscription names.  But that would require updating the backends to read from the version-specific subscription too.  Right now, there's no way to use gcloud to deploy the backends running on Windows.  So it's definitely a problem, but right now all the solutions would be worse than the problem.

LGTM.


Remove named parameter from create_capability example.

Checklist

[x] I've run bundle exec rspec from the root directory to see all new and existing tests pass
[x] I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
[x] I've read the Contribution Guidelines
[x] I've updated the documentation if necessary.

Motivation and Context

Description

Testing Steps

@t2 Hey! Would you mind signing the Google CLA? 😇 Thank you!


adding cmake projects into master branch to enable andriod studio to …

…import
this one is going to break CI for:

build.gradles are different and there is no app directory either
ndk version mis-match - this one need ndk r12 beta

I did a diligent test, it works.

Actually the only failure of the CI, is that the README.md file for cmake directory doesn't have the same content of the hello-jni one under Support  (it won't try to build something that doesn't have an app directory)
--- /tmp/hello-jni.readme	2016-06-03 22:30:37.266479848 +0000
+++ /tmp/cmake.readme	2016-06-03 22:30:37.250481583 +0000
@@ -1,12 +1,12 @@
 Support
 -------
-If you've found an error in these samples, please [file an issue](https://github.com/googlesamples/android-ndk/issues/new).
-
-Patches are encouraged, and may be submitted by [forking this project](https://github.com/googlesamples/android-ndk/fork) and
-submitting a pull request through GitHub. Please see [CONTRIBUTING.md](../CONTRIBUTING.md) for more details.

-- [Stack Overflow](http://stackoverflow.com/questions/tagged/android-ndk)
 - [Google+ Community](https://plus.google.com/communities/105153134372062985968)
-- [Android Tools Feedbacks](http://tools.android.com/feedback)
+- [Stack Overflow](http://stackoverflow.com/questions/tagged/android)
+
+If you've found an error in these samples, please [file an issue](https://github.com/googlesamples/android-ndk/issues/new).
+
+Patches and new samples are encouraged, and may be submitted by [forking this project](https://github.com/googlesamples/android-ndk/fork) and
+submitting a pull request through GitHub. Please see [CONTRIBUTING.md](CONTRIBUTING.md) for more details.

 License
The command "for f in */README.md; do sed -n '/Support/,/License/p' $f > /tmp/$(dirname $f).readme; done && diff -u --from-file=/tmp/hello-jni.readme /tmp/*.readme" exited with 1.

So that the only thing you'd need to change.

thanks! modified that READMe.md, it needs to be updated for this project purpose. Just uploaded, hope it will get through.

LGTM


Require the machine-readable responses

Some API responses, such as Tofu CLI output, are not machine-readable.
To integrate other systems/software, all APIs must provide machine-readable responses.

#64 #63


1.2.10 transient fields in nested classes are being saved in the db

Any transient field which is present in the main schema does not get saved, as expected. But the transient fields that I have in nested classes does get ported to the db. Please fix this in 2.0.

It already is working properly in 2.0. Astronomy 1.x in some parts was to complex and it was hard to keep track of all the features. And in 2.0 the code base is much cleaner and simpler. There should be less bugs. I will probably don't fix it in 1.2+, at least for now until I'm finished working with 2.0

Awesome! I am eagerly waiting for 2.0 final release.

We all are.


PR: Remove unused imports

Description of Changes

Removed all unused imports I could find. (Except for utils.external.github which I didn't dare to touch.)
Any removed spaces are caused automatically.
Affirmation
By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct: Oscar Gustafsson/oscargus

I'm sorry but I'm sure this will interfere with other PRs for no important gain. So I'll leave this to merge it in two or three weeks.

No problems! Not really urgent, more that I find it a bit annoying with unused imports...

Ok, thanks for understanding @oscargus!

@oscargus, please update this PR so I can merge it. Thanks!

@oscargus, I plan to release beta4 on July 31. Do you have time to finish this PR by then?

New attempt in #9904 as I wasn't able to resolve all merge conflicts here and do not know how to start all over in the same branch...


Syndicate metrics to Kafka

This change publishes metrics to kafka or artemis if a queue-type other than miq_queue is enabled.
$ bin/kafka-console-consumer.sh --bootstrap-server 'localhost:9092' --topic metrics --from-beginning
{"capture_interval_name"=>"realtime",
 "capture_interval"=>"20",
 "resource_name"=>"Joe_20190719_101454",
 "timestamp"=>"2020-04-01T15:33:40Z",
 "mem_swapout_absolute_average"=>0.0,
 "cpu_used_delta_summation"=>1535.0,
 "cpu_usagemhz_rate_average"=>191.0,
 "cpu_system_delta_summation"=>9.0,
 "cpu_ready_delta_summation"=>19.0,
 "cpu_usage_rate_average"=>2.08,
 "mem_swapped_absolute_average"=>0.0,
 "net_usage_rate_average"=>0.0,
 "cpu_wait_delta_summation"=>78631.0,
 "sys_uptime_absolute_latest"=>22209148.0,
 "mem_usage_absolute_average"=>7.99,
 "mem_vmmemctl_absolute_average"=>0.0,
 "mem_swaptarget_absolute_average"=>0.0,
 "mem_vmmemctltarget_absolute_average"=>0.0,
 "mem_swapin_absolute_average"=>0.0,
 "resource_id"=>1,
 "resource_type"=>"VmOrTemplate",
 "derived_cpu_reserved"=>0,
 "derived_host_count_off"=>0,
 "derived_host_count_on"=>0,
 "derived_host_count_total"=>0,
 "derived_memory_available"=>12288,
 "derived_memory_reserved"=>0,
 "derived_memory_used"=>981.8112,
 "derived_host_sockets"=>nil,
 "derived_vm_allocated_disk_storage"=>"70866960384.0",
 "derived_vm_count_off"=>0,
 "derived_vm_count_on"=>0,
 "derived_vm_count_total"=>0,
 "derived_vm_numvcpus"=>4,
 "derived_vm_used_disk_storage"=>"70866960384.0",
 "assoc_ids"=>{"storages"=>{"on"=>[], "off"=>[]}},
 "tag_names"=>"",
 "parent_host_id"=>1,
 "parent_storage_id"=>1,
 "parent_ems_id"=>2,
 "parent_ems_cluster_id"=>1,
 "resource_ref"=>"vm-382",
 "resource_uid"=>"423d26fa-67df-dd86-27a2-ec7a795048dd"}

Depends on: https://github.com/ManageIQ/manageiq/pull/19984
https://github.com/ManageIQ/manageiq/issues/19584

cc @carbonin

@agrare Did we want to publish to kafka and ems_events in the interim?  This way it sort of tees into 2 systems until we move all of event handling to pull off of kafka, allowing integration with third party event systems.

I'm not sure how solid we need to make this on this pass. Maybe it is good enough and in the future we can make it more rock solid?

@agrare This looks good to me and is guarded by the messaging_type so I think this is good to merge.

Jansa backport details:
$ git log -1
commit 066795006f1156df3069999874b2566b4de9d1d3
Author: Jason Frey<EMAIL_ADDRESS>Date:   Mon Apr 6 20:05:23 2020 -0400

    Merge pull request #19987 from agrare/publish_metrics_to_kafka

    Syndicate metrics to Kafka

    (cherry picked from commit dff9e8e638d7267ad7ceed75e8b538bce5ffc8ad)


[Network] skip second connect in bidirectional peering

Description
This PR disable a second connection establishment in case of a bidirectional peering.

/rebase test=true


Add go module

Hello,
Thanks for this awesome project!
As go mod is the new way of managing dependencies with go, it would be great to also have go module support with terratest.
Currently we are unable to use terratest with go modules, as the dependencies are not pinned correctly. This leads to errors like:
../../../../go/pkg/mod/k8s.io/client-go@v10.0.0+incompatible/kubernetes/scheme/register.go:22:2: unknown import path "k8s.io/api/admissionregistration/v1alpha1": cannot find module providing package k8s.io/api/admissionregistration/v1alpha1

This PR enables go modules support by generating a go.mod based on the existing Gopkg.lock.
Let me know whether this can get merged, or you need anything else.
Cheers!

Nice, thanks for the PR!

Should we remove the go dep files? Or will that cause issues for users who haven't yet migrated to go mod? I'm worried it would be tricky to keep both go dep and go mod files in sync...
According to the docs, go mod won't be finalized until Go 1.13. Should we wait until then to make the full switch over?

As always the questions are on point.

Should we remove the go dep files? Or will that cause issues for users who haven't yet migrated to go mod? I'm worried it would be tricky to keep both go dep and go mod files in sync...

I did not yet remove the go dep files on purpose, to keep the backwards compatibility. It will take some effort to keep them in sync, however currently the amount of dependencies looks manageable. At the end this should be decided by the maintainers of course.

According to the docs, go mod won't be finalized until Go 1.13. Should we wait until then to make the full switch over?

Fully agreed. The question is if "switch over" means adding the go mod and removing the go dep with Go 1.13, or if we want to add the go mod now and remove the go dep with Go 1.13

I would tend to go with adding the go mod now and removing the go dep with Go 1.13, however all other approaches are also fine. What is your suggestion?

So from another scan of the docs, Go 1.13 isn't due until August. That's roughly 5 months to have to keep the Go dep and Go mod dependency files in sync. Odds of success if we do it manually are ~0. In fact, anyone who is using Go mod probably doesn't have GOPATH set up in the first place, and won't be able to use Go dep without lots of additional effort.
So it seems we need to pick one or the other. I guess the main question for me is, if we remove the Go dep stuff now, will current Terratest users who rely on dep get all sorts of errors? Or does dep version the code, so they'd still be using the previous releases that were still configured with dep? Is there any easy way to test this?

I thought about adding a simple test to check if go mod and dep are in sync, but this is not easily possible, as the modconv package is internal.
As to my understanding removing the Gopkg.lock and Gopkg.toml files should not break the setup for existing users. I did some research and it looks like go will use the vendor directory automatically if present: https://golang.org/cmd/go/#hdr-Vendor_Directories
So my current assumption is, that things would only break, once dependencies are updated / added and the user did not yet switch to go mod.
However, it looks like there are some unknowns here, so postponing this until Go 1.13 is released, might be the safer choice.

So my current assumption is, that things would only break, once dependencies are updated / added and the user did not yet switch to go mod.

That seems like something very likely to happen over the next ~5 months...

However, it looks like there are some unknowns here, so postponing this until Go 1.13 is released, might be the safer choice.

Agreed. I think moving to go mod is a great idea, and appreciate the PR, but it's probably best to wait until it's the official tool, and then go all in on it. Thanks!

As we're nearing August could this be revisited? Initial attempts to use terratest in a bazel project appears to be complicated by the lack of module use.

As stated before, the plan is to wait for Go 1.13 to drop, with the official, built-in, enabled-by-default support for go mod.

Go 1.13 has been released. It would be great to see a updated version of Terratest to simplify my test setup.

@brikis98 Go 1.13 has dropped

Hello,
indeed thanks for this awesome project 🙏
I am also having this error when importing in test_structure in my go module.
Indeed this is about the dependency on tunnel.go from k8s library see this issue
transitive = -> terratest/modules/test_structure -> terratest/modules/k8s -> k8s.io/kubernetes/pkg/kubectl/generate -> k8s.io/kubernetes/pkg/kubectl/generate not found
here is my 2 cents :

Complete the support of module and relase this existing PR as the only blocking point identified is go 1.13 released (and the current version of go is 1.13.1)
having a new look on the PR 240 as it brings a dependency on k8s in the test_structure terratest module for only 3 methods related to k8s (SaveKubectlOptions, LoadKubectlOptions, formatKubectlOptionsPath),
would it make sense to have those methods in the k8s module folder instead of the test_structure module folder? Does those methods are used a lot in there actual form (not working when imported in a go module) ?

I would be available for the PR to move elsewhere those k8s helper methods, let me know
Regards

@msvechla Could you update this PR to the latest? i.e., rebase, make sure new dependency versions are pulled in, and remove the Gopkg.* files?

Ok @brikis98 I can do that but in a different pr for the sake of simplicity. here it is

Agreed, starting on a clean PR might be quicker. Feel free to close my pr in favor of #384. Alternatively I can rebase and make it work as well.

This has been merged with #384


Add Skeleton screen to Navigator

Bug/issue #90172650, if applicable:
Summary
Add Skeleton screen to Navigator
https://user-images.githubusercontent.com/8567677/193631610-c4a0bffa-3110-4759-a7d2-7e8154548e5e.mov
Dependencies
NA
Testing
Steps:

Open the project and go to src/components/Navigator.vue
Set line 17 to :isLoading="true"
Run the project
Assert that you can see the skeleton screen

Checklist
Make sure you check off the following items. If they cannot be completed, provide a reason.

[x] Added tests
[x] Ran npm test, and it succeeded
[x] Updated documentation if necessary

@swift-ci test

@swift-ci test

@swift-ci test