Keyboard navigation on the interface

Godot version: 3.0.4

Issue description: UX failures force the user to switch between mouse and keyboard.
There are several shortcuts present in the API. But I could not locate those who allow me to navigate in it.

Not having access to certain options in the software, makes your use less productive for those who tend to use the keyboard more.
Case1: Many times when I'm working in the Script editor, and I need to check something in the other panels, I end up having to switch to the scene editor, only to be able to navigate freely on the interface; This is not a very intuitive task, in my view.
Case2: The TAB key allows me to move on the GUI, but it is somewhat confusing, as it is difficult to understand which panel is in focus at the moment. Only buttons, or input objects as the text field are highlighted. As a consequence I have to pushing the arrows to see if I can locate myself, and this may end up, move an object from the scene for example. Sometimes I can not access some panels, like the Inspector (one of the always have to be manipulating). And I end up having to opt for the mouse (the villain tendinitis.)
Case3: For some reason the full screen is activated with Shift + F11. Which could lead us to believe that the option does not even exist, if the option Editor > Toggle Fullscreen was not available. The Scape key does not deactivate this mode. //This is not a big problem, but it is different from the patterns which generates a certain strangeness.
Case4: In the inspector, I found no way to expand/select these options...

Given this, I show below some cases of how problems like this are solved in other softwares:

The ALT key would allow me to navigate the options bar: the desired option would be represented with a highlighted character, as shown in the examples below

This following solution is present on Godot but it is very strange, sometimes works, others do not. Navigating between tabs as well as in browsers is performed by pressing CTRL + TAB or SHIFT + TAB, or even CTRL + (1-9 tab numbering).

In some software, such as Photoshop, some panes (or Windows) have specific shortcuts. Which would make access to the Inspector much quicker and more practical.

F1 in many programs, opens a guide or manual, which is actually not that relevant.

In canvas, it would make sense if the zoom control was performed with the CTRL + (+,-, 0) keys.

Some problems may seem a bit silly, but they really make a difference when you choose to leave your mouse aside.

If you have more cases or solutions for this type of problem in UX, please feel free to join us in the discussion. I hope someone understands and implements these issues.

Feature and improvement proposals for the Godot Engine are now being discussed and reviewed in a dedicated Godot Improvement Proposals (GIP) (godotengine/godot-proposals) issue tracker. The GIP tracker has a detailed issue template designed so that proposals include all the relevant information to start a productive discussion and help the community assess the validity of the proposal for the engine.
The main (godotengine/godot) tracker is now solely dedicated to bug reports and Pull Requests, enabling contributors to have a better focus on bug fixing work. Therefore, we are now closing all older feature proposals on the main issue tracker.
If you are interested in this feature proposal, please open a new proposal on the GIP tracker following the given issue template (after checking that it doesn't exist already). Be sure to reference this closed issue if it includes any relevant discussion (which you are also encouraged to summarize in the new proposal). Thanks in advance!


Remove Night

Hi, Im Amplify, Co-owner of Night. Im just finna say this straight. if you dont remove Night from your leaks i will A: ban you B: you will get DMCA'ed.

sorry for having leaked Night links, I didn't leak I found them from that proxies 100+ google document, anyways I removed ALL of them. I still have your discord server linked if thats okay, and I am wondering if there is any official link of Night that I can put or no?

sorry for having leaked Night links, I didn't leak I found them from that proxies 100+ google document, anyways I removed ALL of them. I still have your discord server linked if thats okay, and I am wondering if there is any official link of Night that I can put or no?

Our links are down due to the loads of our VPS and so none of our links currently work but we are working on acquiring new servers.


Fix raw bluetooth mode

For my system,
CalledProcessError: Command '['bluetoothctl', '', 'list']' returned non-zero exit status 1.

Workaround:
use
subprocess.check_output(["bluetoothctl", "list"], stderr=subprocess.STDOUT)

l see no issue on my end. Merged. Though I suspect Hengi's pull request which might be merged next would make it unneeded.


cannot sort cursor before limit

Let us say, we have 1000 records, and I want to fetch latest 100 records by timestamp.
when i use
local r = col:find(criteria,nil,100)
r:sort({["timestamp"]=-1})
the cursor return sorted result of first 100 results.
what I want is sort 1000 records first, and then limit 100 records.

it is a bug.
you can modify this file src/cursor.lua in line 42:

function cursor_methods:limit(n)
assert(n)
self.limit_n = n
return limit
end

modify

return limit

to

return self

then use like this

r:sort({["timestamp"]=-1}):limit(100)


[BUG] GSE macros not changing when Skyriding

🔵 Describe the bug:
A clear and concise description of what the bug is.
🔵 To reproduce: (Steps to reproduce the behavior)

Go to '...'
Click on '....'
Scroll down to '....'
See error

🔵 The error:
Paste the error message in this blockquote.

🔵 Screenshots:
If applicable, add screenshots to help explain your problem.
🔵 Expected behavior:
A clear and concise description of what you expected to happen.
🔵 GSE.lua file:
Please provide your GSE.lua file or the export string for the specific macro that is causing an issue.

To find the GSE.lua file:

First, make sure you have enabled the "File Name Extensions" checkbox in Explorer (View tab)
Browse to C:\path\to\wow\_retail_\WTF\Account\YourAccountName\SavedVariables\ or /path/to/WoW/_retail_/WTF/Account/YourAccountName/SavedVariables
Copy the GSE.lua file to your Desktop
Rename this copy to GSA.lua.txt
Then just drag it here in your message

Note: If you do not include your GSE.lua file you are wasting your time and mine. 90% of the time, the first thing I will ask for is "Can you please upload your GSE.lua file?".  This file is needed with the error to work out Why that error occured for you.

🔵 Desktop (please complete the following information):

OS: [e.g. Windows 10 64bit]
Game Version [e.g. classic/bcc/retail (9.1.0)]

🔵 GSE Version:

Version: [e.g. 3.x.y]
Downloaded From: [e.g. https://www.curseforge.com]

🔵 Additional context:
Add any other context about the problem here.

Not sure if this is a GSE or Blizzard bug, but the GSE macros are preventing the Skyriding keys from working when the GSE macros are Key bound to Action Bar 1, i.e. the bar changes to skyriding but the keys 1 through 4 are still bound to the macro keybinds.

Yes you can only bind 1 thing in WoW so you can either bind the actionbar button or the GSE button but not both


fix(gui): Re-enable application menu

This re-enables the application menu to allow for OS native shortcuts
to work again (i.e. hide/minimize window), which also allows us to
get rid of the global-shortcuts hack to prevent window reloads.
Also adds links to the website, Etcher Pro and GitHub issues in the help menu.
TODO:

[ ] Add ⌘+, to open preferences / settings on Mac OS
[ ] Check if there's a similar convention on Windows or Linux

Mac OS

Windows
Default state:

When hitting Alt:

Connects To: #1883 #1909
Change-Type: patch
Changelog-Entry: Fix disabled native OS window shortcuts

Before this gets approved, IMHO you should include before and after screenshots from all 3 OSes, and we should get feedback from @konmouz and @alexandrosm
I thought Etcher not having a menu was a "feature", which adds to its elegant interface and simple usability...?

Does #1840 relate to this at all? Does re-enabling the menubar still prevent Etcher from being maxmised? (and to clarify, I believe we want to keep the behaviour of Etcher being non-maximisable?)

@lurch no, the menubar doesn't magically override menu settings

@Shou is there an easy way to programatically toggle the settings view?

Why does the first menu item say Electron and not Etcher ? :confused:

Because that's the appName when running npm start, as that runs Electron – the appName will only be set to "Etcher" once packaged

Ahhh, might be worth re-taking the screenshots with packaged versions of Etcher then, to avoid confusion ;-)
What does the "about" option display?  (on Linux and Windows this is usually an option on the Help menu)
What "edit-menu" functionality does Etcher expose? (I can't think where copy'n'paste would come in handy)

Added ⌘+, to open / toggle preferences on Mac OS now. On Windows there doesn't seem to be a convention around that, other than having a "Settings" thing in the menu. Still need to dig into Linux.

In other Mac apps, is the Preferences thing always a 'toggle'? I don't have any Mac experience myself.
In Linux apps, if there was a shortcut to display the preferences (I also haven't done any digging to see if there's a convention here or not) I'd expect that to display the preferences window, and for pressing it again to leave the preferences window open, rather than toggling it closed again.
Did you see my suggestion in #1909 about adding a Ctrl+o shortcut?  Could you update your GIF to quickly show what each of the top-level menus displays?

Maybe I'm missing something, but I don't understand why Etcher needs Edit, View or Window menus??

I mentioned this in last Fridays meeting, but should've added it to the description, so here goes (also added this to the PR description):

App (Mac OS): Quit, hide / show window, preferences
App (Windows, Linux): Quit, preferences
View: Enable showing DevTools without that global shortcut hack, disable content zoom and reloads
Edit: Don't disable native copy/paste & shortcuts (needed in DevTools and when we'll add an "Open URL" etc)
Window: Native window management shortcuts, like minimize / maximise and friends (dep. on OS)

@jhermsmeier, in my opinion, we should avoid the menu if that is possible. If we can't completely remove the menu, hiding is fine. But in any case, the menu shouldn't provide any additional functionality that can't be found in the Etcher UI.


made changes in the blog section

Would you please look into this and change the size of that background color to make it look more attractive.
https://blogweet.vercel.app/hhh-rrr/ycn6Am43GHRf5IiGVtsn

I have removed that background color on hover. I tried to apply other background colors but they didn't suit with the styling of the blogs so I have applied another property in which if we will hover on share button, it's size will will increase.

Also, could u please add relevant tags in the issue so that it can be considered for the evaluation of scores in GSSOC'23.

issue #106

@srivastavaritik review it please


[DSS-313] Tooltip - Allow handlers to pass to Tooltip Element

Description

Adds functionality to allow handlers to be passed to the Tooltip element per support request and engineer input.
Testing in sage-lib

Navigate to the Tooltip Story
Add a click handler on line 27
Navigate to Tooltip
Check that click handler works properly

Testing in kajabi-products

(LOW) Adds functionality to allow handlers to be passed to the Tooltip element per support request.
Related

DSS-313

I believe we should add specs to highlight / covert the new properties.

@ju-Skinner I've added more tests here. size and theme have been deprecated as of Sage 3 and were not added.


Is there a way to reload schema just for one instance?

Hi django-hstore developers!
I'm wondering if there is a way to apply schema not to the whole model class, but rather for one model instance.
My situation is following:
I have a model that has a set of fields that are common for all instances.
This model has a 'category'.
Depending on category (e.g. Hotel, Parking, Theatre) I'd like to add a fixed set of additional attributes (different for every category). For example, Hotel should have a star_rating, while Parking should have a lots_number but it shouldn't have a star_rating.
I can't create separate models for each category, I'd like it to be as much dynamic as possible.
So, the solution I see is to attach schema name to a Category model and then apply this schema to 'attributes' field on instance creation.
However, if I do it in the way described in docs:
field = SchemaDataBag._meta.get_field('data')
# load a different schema
field.reload_schema([
    {
        'name': 'url',
        'class': 'URLField'
    }
])
# turn off schema mode
field.reload_schema(None)

Schema is getting updated for the whole model class (all instances).

Thank you for the insights, I'm closing this to cleanup the issue list.


Dashboard not refreshing when removing widgets

Dev Home version
0.1501.547.0
Windows build number
10.0.22621.3737
Other software
OS Build Version: 10.0.22621.3737.amd64fre.ni_release.220506-1250
.NET Version: .NET 8.0.6
Steps to reproduce the bug
Add a widget to dashboard and remove it. It will stay in the dashboard but in a frozen state. Navigate out of dashboard page and navigate back to it to see it actually removed.
Expected result
Widgets removed should not be shown in dashboard.
Actual result
Widgets stay in the dashboard in a frozen state after being removed. It is needed to navigate away from dashboard page to see the changes in UI.
Included System Information
No response
Included Extensions Information
Extensions:
Microsoft.DevHomeMicrosoftGameDevExtension_0.400.536.0_x64__8wekyb3d8bbwe (Dev Home Microsoft Game Dev Extension (Preview))
Microsoft.Windows.DevHome.Canary_0.1501.547.0_x64__8wekyb3d8bbwe (Core Widget Extension)
Microsoft.Windows.DevHome.Canary_0.1501.547.0_x64__8wekyb3d8bbwe (Hyper-V Extension)
Microsoft.Windows.DevHomeAzureExtension.Canary_0.1000.549.0_x64__8wekyb3d8bbwe (Dev Home Azure Extension (Canary))
Widget Service:
MicrosoftWindows.Client.WebExperience_524.13200.30.0_x64__cw5n1h2txyewy

I was able to reproduce this as well, it is a refresh issue, the widgets are being removed and are not active after removal.


Message command with two newlines crashes

[00:34]clickmazes: @davidus of polyomino there's definitely a problem in the editor at the moment - both the release version and the latest build. I think it's triggered by Messages that include new-line chars. E.g. "Message aaa\n\nbbb"

Bug fixed.


Create 163.txt

Our school does not set up an education email, so I hope to use my private email to authenticate the education information.It is also expected to be adopted

@iUnicOrnate This domain does not belong to a university, nor to a college. I have to close the request without merging. Please ensure that you are familiar with this repository rules located at the bottom of this page before submitting a new request.
If you do not have an email which your school provided you with, please apply for free educational license with an official document which proves that you are a student. You can do it using "OFFICIAL DOCUMENT" tab at https://www.jetbrains.com/shop/eform/students.
Thank you for the understanding!


Windows 10 ARM DLL ?

Can you update ARM64 DLL (include icu.dll, winhttp.dll and WSAPatch.dll). Thanks

I can provide the original arm64 DLLs

I can provide the original arm64 DLLs if needed and also test WSA on Windows 10 arm

Yes, but I don't have any Surface or another ARM Device for testing

I can provide the original arm64 DLLs if needed and also test WSA on Windows 10 arm

Yes, but I don't have any Surface or another ARM Device for testing

I have an arm device to test on

I can provide the original arm64 DLLs if needed and also test WSA on Windows 10 arm

Yes, but I don't have any Surface or another ARM Device for testing

I have an arm device to test on

So can you build ARM64 DLLs and test it now ?


Docker support broken

Problem or feature statement
Trying to use docker from README
docker-compose build
...
#0 92.41 done.
#0 92.41 done.
#0 92.53 update-alternatives: error: alternative /usr/lib/jvm/java-11-openjdk-amd64/bin/java for java not registered; not setting
------
failed to solve: executor failed running [/bin/sh -c apt-get update -qq     && apt-get install -y curl openjdk-11-jdk maven     && update-alternatives --set java /usr/lib/jvm/java-11-openjdk-amd64/bin/java     && update-alternatives --set javac /usr/lib/jvm/java-11-openjdk-amd64/bin/javac     && apt-get install golang git -y     && go get -u github.com/tcnksm/ghr     && curl https://github.com/graalvm/graalvm-ce-builds/releases/download/vm-21.1.0/graalvm-ce-java11-linux-amd64-21.1.0.tar.gz -O -J -L     && tar xfz graalvm-ce-java11-linux-amd64-21.1.0.tar.gz     && mv graalvm-ce-java11-21.1.0 .graalvm     && rm graalvm-ce-java11-linux-amd64-21.1.0.tar.gz     && /build/.graalvm/bin/gu install native-image     && git clone https://github.com/pyenv/pyenv.git ~/.pyenv     && apt-get install -y gcc libbz2-dev libsqlite3-dev libssl-dev make zlib1g-dev libffi-dev     && ~/.pyenv/bin/pyenv install 3.8.6     && ~/.pyenv/bin/pyenv local 3.8.6     && curl -sSL https://raw.githubusercontent.com/python-poetry/poetry/master/get-poetry.py | python -]: exit code: 2

Advised solution
Fix it or remove it. It appears there's a docker job in the circleci.yaml file but it's not invoked which is misleading.
Testing scenarios
docker-compose build

@mjallday I thought the whole point of docker is "works on my machine" isn't a problem any more but, I just tried it on my machine:

Can you share more about your setup?

windows 95, unpatched on a pentium 60 with 8mb of ram.
docker 0.1

docker-compose --version
Docker Compose version 2.4.1

i'll give this a couple more tries locally since it's working for you. i see it's mounting ~/.m2 so it's probably that i don't have github authentication setup


Support for Play Framework 2.5.x

@ShahBinoy thanks for the PR! I just realized that the README needs adjustments - can you submit a PR for this as well? This would be awesome! :-)


Jest configuration support for "setupFiles"

Is your proposal related to a problem?
I'm trying to test localStorage with https://www.npmjs.com/package/jest-localstorage-mock which requires some minor configuration setup in the package.json however when I try to add the following to my package.json
  "jest": {
    "setupFiles": ["jest-localstorage-mock"]
  }

I get the following error message:
Out of the box, Create React App only supports overriding these Jest options:

  • clearMocks
  • collectCoverageFrom
  • coveragePathIgnorePatterns
  • coverageReporters
  • coverageThreshold
  • displayName
  • extraGlobals
  • globalSetup
  • globalTeardown
  • moduleNameMapper
  • resetMocks
  • resetModules
  • restoreMocks
  • snapshotSerializers
  • transform
  • transformIgnorePatterns
  • watchPathIgnorePatterns.

These options in your package.json Jest configuration are not currently supported by Create React App:

  • setupFiles

If you wish to override other Jest options, you need to eject from the default setup. You can do so by running npm run eject but remember that this is a one-way operation. You may also file an issue with Create React App to discuss supporting more options out of the box.

error Command failed with exit code 1.

Describe the solution you'd like
I'f possible, I'd like out of the box support for this as I don't want to run npm run eject
Describe alternatives you've considered
(Write your answer here.)
Additional context
https://www.npmjs.com/package/jest-localstorage-mock
https://jestjs.io/docs/en/configuration.html#content
(Write your answer here.)

If this is an easy fix, i'd like to contribute it myself to the create-react-app project if someone can just point me to previous config or relevant document =)

jest-localstorage-mock provides a solution for this:

For a create-react-app project you can replace the suggested mock
with this at the beginning of the existing src/setupTests.js file:

require('jest-localstorage-mock');

Why does this work?
create-react-app automatically executes the content in src/setupFiles.js if it’s created.


Description off /webif/Readme.md Wrong

Hello,
i tried to make a Language change for the Html files and convert it to a same lookin file as your e.g. channels_htm_gz.h
But when i will compile it Arduino gives me failure on compiling. I think because i didnt gzipped it. But how to gzip it that it will work?
Or in what order i have to zip the file?

Hi @crazybanane
Thanks for your interest in aquacontrol and pointing this out.
The explanation was outdated.
I updated the description on preparing the web interface files. Hopefully this made it more clear.
Updated explanation
Feel free to reopen this issue if things dont work out or are unclear.

Thank you so much. It works just fine also on WIN11 with WSL and Kali Linux.
Is there a way that i can Upload German Language Website file inclusive Gzipped files here that anybody can use it?
Thank you so much for this great and Easy made Program

Yes, a PR with German language translation would be a nice addition.
I do have to think a bit about how to make it work in an easy and maintainable way.
I will report back if I have worked something out.

I took the files from webif and translated it to german i can send you these if you want.

Yes, you can send them to aquacontrol @ wasietsmet.nl.

Yes, you can send them to aquacontrol @ wasietsmet.nl.

On the way

Is it easy enough if you made in webif new folder with the language e.g.
webif>
-de
-en
-esp........
and correct the code that the Compiler can search for it when language is set?
Or is it possible to upload the wbesite files via filemanager?

@crazybanane
I might go for something like the first approach.
The second approach exposes the files through the filemanager and is imho not the best (rather ugly) solution.
For now I got multiple other fish to fry.
Thanks for your time and effort!


Adds ViewModel groupings

This adds ViewModel groupings to both the .component and the modlet
components.
For .component this also adds a name to the ViewModel for better
debuggability. Closes #287

Coverage increased (+0.03%) to 97.541% when pulling 1fca579e61e2746cfac984e19068d1fd15fbc022 on vm-groupings into 13510f4f41ede849ac823d600f97f02b010d6efa on major.


Example for S3 provider instead of github

Hi,
I am looking for the example of s3 provider for auto-update.
I've already done s3 publishing. But can't check the update from s3.
Is there any example that I can follow for the window? Thanks.

@dede-plato I have no experience with S3 (and very little with Windows).  But to whoever knows how to do it, feel free to post here.

I did it for macOS, but I would assume, it is the same for Windows.
With the electron-builder one has the use the S3Options. (Here is the JSON scheme for S3 if you prefer that.)
{
...
"build": {
    ...
    "publish": [
      {
        "provider": "s3",
        "bucket": "your-bucket-name",
        "path": "optional/download/path"
      }
    ],
    ...
  },
...
}

Assuming your S3 is public, you can omit the acl prop, it falls back to "public-read". If your bucket is private, see this thread.
You also have to tune the ACL config on S3, I ended up with this policy file based on this and this comments.
{
  "Statement": [
    {
      "Sid": "yourId1",
      "Effect": "Allow",
      "Action": [
        "s3:ListBucket",
        "s3:GetBucketLocation",
        "s3:ListBucketMultipartUploads"
      ],
      "Resource": "arn:aws:s3:::your-bucket-name"
    },
    {
      "Sid": "yourId2",
      "Effect": "Allow",
      "Action": [
        "s3:AbortMultipartUpload",
        "s3:GetObject",
        "s3:GetObjectAcl",
        "s3:GetObjectVersion",
        "s3:ListMultipartUploadParts",
        "s3:PutObject",
        "s3:PutObjectAcl"
      ],
      "Resource": "arn:aws:s3:::your-bucket-name/optional/download/path/*"
    }
  ],
  "Version": "2012-10-17"
}

Notes:

You  can  explicitly set the acl prop to null,
People say it is better to use a secret env variable for the bucket name, instead of writing it into the electron builder config (YAML, or package.json). I could not achieve it.

I hope this helps others configuring the electron updated with S3.
PS: If you have spotted any mistakes/anti-patterns in my config, let me know. Thanks!


No way currently to clear blocked list

Expected Behavior
If a node has recovered or is addressable it should be able to be removed from the blocked list.
Actual Behavior
When using a stateful service in Kubernetes and proto actor if I scale the system to 0 then add any arbitrary set of nodes it operates fine, but if a node is moved or if the service is updated during the period of the node becoming healthy the gossip channel will mark the node in the blocked list on all other nodes and then it can never recover. Having programmatic access to clean the block list would be nice.
Specifications

Version: 0.26.0
Platform: Ubuntu 20.04 Container on EKS  -

Blocking is on a member ID level, the idea is that if a member for some reason leaves the cluster, this specific member instance may not re-join.
This is much due to how virtual actors work. if some actors existed on this node before, and now exists elsewhere in the cluster as this member left. if it were to be allowed to rejoin, there would have to be coordination on which instance of this actor is the correct one.
Instead, we opted for the simpler approach, once a member leaves, it may never rejoin, and should be downed.
A new node may very well rejoin again on the same host and port, but this member will have a different member id as this is a new instance (ID is an autogenerated GUID, so this part is handled automatically)
This applies to rolling upgrades of pods also.
Are you seeing any case where a newly started pod may not join the cluster?

Yes. When the existing pod is restarted the new instance with a new ID is not reaching gossip consensus and then gets banned. But if I scale to 0 and then up to any arbitrary amount (I have tested 1,2,5, and 10 nodes) then joining of new nodes works fine.

I'm doing some testing with a fairly pessimistic readiness probe to see how that alters the behavior.

So I was able to resolve why the gossip was happening out of band. I think that since the containers I'm using have 1 core the cluster task was blocking starting the web server so I moved the start logic to a hosted service which resolved this like so. I still wonder in practice though how should I receive a signal and restart nodes that have failed gossip so that I don't get a split brained cluster?
`
public class HostedCluster : IHostedService
{
private ActorSystem _actorSystem;
Task _startTask;
    public HostedCluster(ActorSystem actorSystem)
    {
        _actorSystem = actorSystem;
    }

    public async Task StartAsync(CancellationToken cancellationToken)
    {
        _startTask = _actorSystem.Cluster().StartMemberAsync();
    }

    public Task StopAsync(CancellationToken cancellationToken)
    {
        return Task.CompletedTask;
    }
}

`


add Spotify OAuth backend

Problematic fields:
https://github.com/spotify/web-api/issues/371
https://github.com/spotify/web-api/issues/332

Thanks


Use API key for login if specified

For users with a federated id (mostly IBMers IMO), there is a recommendation in the clusters documentation to generate and use an API key from https://iam.ng.bluemix.net/demo and use this for bx login. Adding as a dark feature, could be supported with more detail in README. API key is equivalent to user, password, and account.

Thanks for the pull request, I will add more details on README.


Update jsoniter-scala-core, ... to 2.12.0

Updates

com.github.plokhotnyuk.jsoniter-scala:jsoniter-scala-core
com.github.plokhotnyuk.jsoniter-scala:jsoniter-scala-macros

from 2.10.4 to 2.12.0.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "com.github.plokhotnyuk.jsoniter-scala" } ]

labels: library-update, early-semver-minor, semver-spec-minor, commit-count:1

Superseded by #246.


[snappy] build failure

Host Environment

OS: Centos7
Compiler: revision

To Reproduce
Steps to reproduce the behavior:
./vcpkg install srpc
Failure logs
usr/downloads/vcpkg/buildtrees/snappy/src/1.1.9-3644d789ea.clean/snappy.cc:1017:8: error: inlining failed in call to always_inline ‘size_t snappy::AdvanceToNextTag(const uint8_t**, size_t*)’: function body can be overwritten at link time
/usr/downloads/vcpkg/buildtrees/snappy/src/1.1.9-3644d789ea.clean/snappy.cc:1097:53: error: called from here
         size_t tag_type = AdvanceToNextTag(&ip, &tag);
                                                     ^
/usr/downloads/vcpkg/buildtrees/snappy/src/1.1.9-3644d789ea.clean/snappy.cc: In function ‘std::pair<const unsigned char*, long int> snappy::DecompressBranchless(const uint8_t*, const uint8_t*, ptrdiff_t, T, ptrdiff_t) [with T = char*; uint8_t = unsigned char; ptrdiff_t = long int]’:
/usr/downloads/vcpkg/buildtrees/snappy/src/1.1.9-3644d789ea.clean/snappy.cc:1017:8: error: inlining failed in call to always_inline ‘size_t snappy::AdvanceToNextTag(const uint8_t**, size_t*)’: function body can be overwritten at link time
 size_t AdvanceToNextTag(const uint8_t** ip_p, size_t* tag) {
        ^
/usr/downloads/vcpkg/buildtrees/snappy/src/1.1.9-3644d789ea.clean/snappy.cc:1097:53: error: called from here
         size_t tag_type = AdvanceToNextTag(&ip, &tag);
                                                     ^
ninja: build stopped: subcommand failed.

logs above in /vcpkg/buildtress/snappy/install-x64-linux-rel-out.log when I tried to  install srpc.
Additional context
-- Building x64-linux-dbg
-- Building x64-linux-rel
CMake Error at scripts/cmake/vcpkg_execute_build_process.cmake:157 (message):
    Command failed: /usr/local/cmake/bin/cmake --build . --config Release --target install -- -v -j5
    Working Directory: /usr/downloads/vcpkg/buildtrees/snappy/x64-linux-rel
    See logs for more information:
      /usr/downloads/vcpkg/buildtrees/snappy/install-x64-linux-rel-out.log

Call Stack (most recent call first):
  installed/x64-linux/share/vcpkg-cmake/vcpkg_cmake_build.cmake:102 (vcpkg_execute_build_process)
  installed/x64-linux/share/vcpkg-cmake/vcpkg_cmake_install.cmake:41 (vcpkg_cmake_build)
  ports/snappy/portfile.cmake:17 (vcpkg_cmake_install)
  scripts/ports.cmake:142 (include)

Error: Building package snappy:x64-linux failed with: BUILD_FAILED

logs above are logs on terminal

What's the version of your cmake and compiler?

Could you please try the fix method here: https://github.com/google/snappy/pull/128 ?

What's the version of your cmake and compiler?

cmake :3.22.0
gdb:10.1
gcc:11.1.0

yes,thanks

yes,it works. thanks!


Can't get cuda-toolkit to install on Mac Ventura 13.3

Perhaps this it's way over my head to be attempting to run this repo without being a dev, but this seemed like the best way to contact you, so here goes.
The terminal command below doesn't work for me:
conda create -n textgen python=3.10.9 torchvision torchaudio pytorch-cuda=11.7 cuda-toolkit conda-forge::ninja conda-forge::git -c pytorch -c nvidia/label/cuda-11.7.0 -c nvidia

When I run this, I get:
Solving environment: failed

PackagesNotFoundError: The following packages are not available from current channels:

  - cuda-toolkit

Any ideas on how to fix?

Yeah I'm sure it's complicated for someone who's not a dev lol. I'm not sure why it's not working for you, but luckily a new one-click installer was just released over here. It should make things easier.
It'll ask you what brand of GPU you have (or no GPU) then you select the letter corresponding to it. When you get to the model downloading step, you'll select the letter for downloading another model (the letter L) and enter decapoda-research/llama-7b-hf, or the model of your choice.
Make sure you're able to run and chat with the model using text-generation-webui before trying to use the bot, but once you're able to, just follow steps 2-5 here and you should be good to go!
Let me know if you run into anymore issues!

Thank you so much! I'm running the installer tonight, downloading the model right now. I joined the Discord too. I really appreciate your reply. I'm excited to try out the one-click installer!

Also, you probably already know this, but for anyone who stumbles across this issue–CUDA only runs on NVIDIA graphics cards, which do not work with Apple computers.


fix(ngLocale): Fixed Chilean locales

Chilean translation to September is "Septiembre", "Setiembre" is a slang translation.
Short days and months should not have an ending dot, it's dependent on the usage.
Weekends are Sunday and Saturday.
First day of week is Monday.

This should be split into several parts.
1/ "Setiembre" vs "Septiembre" should be a simple fix with just regenerating
2/ The extra dot at the end of the short month, for that check Localization Issue
3/ Day positions follow ISO-8601 where Monday is day 0
Closing this, in a few will post a PR that regenerates the locales, this should solve only 1/, for 2/ please follow the guidelines and 3/ is not an issue.


Mix of landuse kind wood and park in Prospect Park Brooklyn

Not sure what to do here:

Add wood to the park layer’s filter.
On Wed, Sep 23, 2015 at 3:58 PM, Geraldine Sarmiento <
<EMAIL_ADDRESS>wrote:

Not sure what to do here:
[image: screen shot 2015-09-23 at 3 56 36 pm]
https://cloud.githubusercontent.com/assets/466585/10061239/ef4f3faa-620b-11e5-85c5-e3a541a7491b.png
[image: screen shot 2015-09-23 at 3 58 15 pm]
https://cloud.githubusercontent.com/assets/466585/10061240/ef67bc38-620b-11e5-98e3-092bc6295331.png
—
Reply to this email directly or view it on GitHub
https://github.com/tangrams/eraser-map/issues/33.

ok, added
https://github.com/tangrams/eraser-map/blob/gh-pages/eraser-map.yaml#L1705


Fix development preview links

Signed-off-by: Jorge Padilla<EMAIL_ADDRESS>

@gurnben Please review and merge.


Move common functions to clustertest

What this PR does
Move some common functions to clustertest to make them reusable in other repos.
Checklist

[x] Update changelog in CHANGELOG.md.

Trigger e2e tests

/run cluster-test-suites

Failures are from flakey providers and enough test suites have passed that I'm confident this change is safe. Adding skip label.


test skipping some failing tests in frs only

TEST FRS PIPELINE BY SKIPPING SOME TESTS

Not needed, handled by other PR


Update CSharp syntax highlighting

This is valid CSharp,
enum Element { /* ... */ }
// ...
(Element?, Element) GetArchitectureElement(Element element) => (null, element);

However, this is literally what I see:

It is not important what Element fields are, but that it is an enum.
Also, the scope of this issue is not exhaustive, but covers one scenario that I happened to observe. Feel free to elaborate, specify the title accordingly, etc.

I'm not able to reproduce this behavior. What I see:

Do you have any extension installed that may be causing this?

Possibly? Who knows... Code 1.54.3:

I ended up going a simpler way after all, but I thought it was interesting.

Given that you're not on the latest version and that you may have an extension causing this (there's a command "Extensions: Disable All Installed Extensions for testing things like this), I'm closing as not reproducible.


pub serve delay between "Serving..." and "Build completed"

 Issue by dgrove
Originally opened as dart-lang/sdk#19150

Running with tip of bleeding_edge, I'm seeing a delay of 6-7 seconds between the time that pub serve prints "Serving todomvc web on http://<IP_ADDRESS>:8080" and the time that it prints "Build completed successfully".
This is when running the TodoMVC sample in Dartium

 Comment by dgrove

This is significantly improved by polymer 0.10.1 . There's still more to do, but we're in good shape for 1.5 .

Removed this from the 1.5 milestone.
Removed Priority-High label.
Added Priority-Medium label.

 Comment by nex3

This sounds like time being spent running the polymer transformers. Siggi, could they take 6-7s worth of time?

cc @sigmundch.

 Comment by sigmundch

FYI - here is a change that let us mock out the SDK. It's an improvement, but it's not perfect:
https://codereview.chromium.org/315813003/
It takes TodoMVC from 4.8s in my machine, to 2.7s. The analyzer still resolves the entire application. I could make mocks for parts of the libraries that are known to us (like polymer), but I'm not sure about that. It already feels brittle with the current change.
The ultimate solution is to be lazy and not run any of the transformers in TodoMVC.
See: issue dart-lang/sdk#19168

 Comment by sigmundch

It could - when do you pub-build pub reports about 5-6 seconds running polymer on TodoMVC. Most of the time is running the resolver (which might be loading and analyzing the entire SDK).
I haven't tried, but we could provide a mock SDK to the analyzer that only contains what we need. But the analyzer might already have this planned.

 Comment by nex3

A bit of barback instrumenting seems to confirm this: running ScriptCompactor on web/index.html takes about 5.6s on my machine. I'll bump this over to polymer.

cc @munificent.
Set owner to @sigmundch.
Removed Area-Pub label.
Added Area-Pkg, Pkg-Polymer labels.

 Comment by sigmundch

For now, I'm going to investigate making the build faster with a mock SDK for the analyzer as a temporary workaround, but long term, I believe we should invest in a solution that allow us to not run transformations when launching an app for development in Dartium.
Bob and I had a long brainstorming discussion this morning about what we could do to address this, but it requires non-trivial changes. For example, one attractive idea we had was to use the user-agent to decide how transformers are run, similar to namespaces ideas you had discussed in the past.

 Comment by sigmundch

Added this to the Later milestone.

 Comment by sigmundch

Removed this from the Later milestone.
Added this to the 1.6 milestone.

 Comment by sigmundch

Added Polymer-P-2 label.

 Comment by sigmundch

Removed Polymer-P-2 label.
Added Polymer-Milestone-Later label.

 Comment by sigmundch

Removed this from the 1.6 milestone.
Added this to the Later milestone.

 Comment by sigmundch

Removed this from the Later milestone.

 Comment by sigmundch

Removed Polymer-Milestone-Later label.
Added PolymerMilestone-Later label.

Nothing further planned on the polymer end of things for this.


add add_basemap function to new plotting.py

This does & documents #20.
A few things:

I started writing a plot_with_basemap(geodataframe, ...) function, but we'd have to decide how much to assume about the crs of geodataframe. I thought it'd be more convenient to just reproject anything that's not in webmerc, but there's support elsewhere for raw lat-long.
plot_map from place.py might be more properly put into plotting.py, or plotting.py should be named something else.

OK, this is the simplest modification to address #20 through a distinct plotting function with automatic zoom.
This gives us 2 plotting functions,

plot_map, which works on places
add_basemap, which adds a basemap to the axis

I went a step further in my placeplot branch. There, I've stuffed plot_map into the Place class as a plot method, so `Place('Austin, TX').plot() would plot Austin.
If we took this further step, it would make it so that there is one plotting function which adds basemaps to axes, add_basemap, but all places can be plotted using their .plot method.


Empty path name is not legal

I was attempting to run my Core 2.1 website and received the above error, stack trace is below.
When I traced it through, the MetadataReferenceFeatureProvider was adding an empty string in this statement:
if (libraryPaths.Add(path))
This then got populated down to System.Io.File constructor where the exception was raised.
I am not sure if this is my configuration or not at this stage, but either way, checking for a null/empty string should prevent this in future.
regards
Si
Stack Trace:
System.ArgumentException: Empty path name is not legal.
Parameter name: path
at System.IO.FileStream..ctor(String path, FileMode mode, FileAccess access, FileShare share, Int32 bufferSize, FileOptions options)
at System.IO.FileStream..ctor(String path, FileMode mode, FileAccess access, FileShare share)
at System.IO.File.OpenRead(String path)
at Microsoft.AspNetCore.Mvc.Razor.Compilation.MetadataReferenceFeatureProvider.CreateMetadataReference(String path)
at Microsoft.AspNetCore.Mvc.Razor.Compilation.MetadataReferenceFeatureProvider.PopulateFeature(IEnumerable1 parts, MetadataReferenceFeature feature)    at Microsoft.AspNetCore.Mvc.ApplicationParts.ApplicationPartManager.PopulateFeature[TFeature](TFeature feature)    at Microsoft.AspNetCore.Mvc.Razor.Internal.DefaultRazorReferenceManager.GetCompilationReferences()    at System.Threading.LazyInitializer.EnsureInitializedCore[T](T& target, Boolean& initialized, Object& syncLock, Func1 valueFactory)
at Microsoft.AspNetCore.Mvc.Razor.Internal.DefaultRazorReferenceManager.get_CompilationReferences()
at Microsoft.AspNetCore.Mvc.Razor.Internal.LazyMetadataReferenceFeature.get_References()
at Microsoft.CodeAnalysis.Razor.CompilationTagHelperFeature.GetDescriptors()
at Microsoft.AspNetCore.Razor.Language.DefaultRazorTagHelperBinderPhase.ExecuteCore(RazorCodeDocument codeDocument)
at Microsoft.AspNetCore.Razor.Language.RazorEnginePhaseBase.Execute(RazorCodeDocument codeDocument)
at Microsoft.AspNetCore.Razor.Language.DefaultRazorEngine.Process(RazorCodeDocument document)
at Microsoft.AspNetCore.Razor.Language.DefaultRazorProjectEngine.ProcessCore(RazorCodeDocument codeDocument)
at Microsoft.AspNetCore.Razor.Language.RazorProjectEngine.Process(RazorProjectItem projectItem)
at Microsoft.AspNetCore.Mvc.Razor.Internal.RazorViewCompiler.CompileAndEmit(String relativePath)
at Microsoft.AspNetCore.Mvc.Razor.Internal.RazorViewCompiler.OnCacheMiss(String normalizedPath)
--- End of stack trace from previous location where exception was thrown ---
at Microsoft.AspNetCore.Mvc.Razor.Internal.DefaultRazorPageFactoryProvider.CreateFactory(String relativePath)
at Microsoft.AspNetCore.Mvc.Razor.RazorViewEngine.CreateCacheResult(HashSet`1 expirationTokens, String relativePath, Boolean isMainPage)
at Microsoft.AspNetCore.Mvc.Razor.RazorViewEngine.OnCacheMiss(ViewLocationExpanderContext expanderContext, ViewLocationCacheKey cacheKey)
at Microsoft.AspNetCore.Mvc.Razor.RazorViewEngine.LocatePageFromViewLocations(ActionContext actionContext, String pageName, Boolean isMainPage)
at Microsoft.AspNetCore.Mvc.Razor.RazorViewEngine.FindView(ActionContext context, String viewName, Boolean isMainPage)
at Microsoft.AspNetCore.Mvc.ViewEngines.CompositeViewEngine.FindView(ActionContext context, String viewName, Boolean isMainPage)
at Microsoft.AspNetCore.Mvc.ViewFeatures.ViewResultExecutor.FindView(ActionContext actionContext, ViewResult viewResult)
at Microsoft.AspNetCore.Mvc.ViewFeatures.ViewResultExecutor.ExecuteAsync(ActionContext context, ViewResult result)
at Microsoft.AspNetCore.Mvc.ViewResult.ExecuteResultAsync(ActionContext context)
at Microsoft.AspNetCore.Mvc.Internal.ResourceInvoker.InvokeResultAsync(IActionResult result)
at Microsoft.AspNetCore.Mvc.Internal.ResourceInvoker.InvokeNextResultFilterAsyncTFilter,TFilterAsync
at Microsoft.AspNetCore.Mvc.Internal.ResourceInvoker.Rethrow(ResultExecutedContext context)
at Microsoft.AspNetCore.Mvc.Internal.ResourceInvoker.ResultNext[TFilter,TFilterAsync](State& next, Scope& scope, Object& state, Boolean& isCompleted)
at Microsoft.AspNetCore.Mvc.Internal.ResourceInvoker.InvokeResultFilters()
at Microsoft.AspNetCore.Mvc.Internal.ResourceInvoker.InvokeNextResourceFilter()
at Microsoft.AspNetCore.Mvc.Internal.ResourceInvoker.Rethrow(ResourceExecutedContext context)
at Microsoft.AspNetCore.Mvc.Internal.ResourceInvoker.Next(State& next, Scope& scope, Object& state, Boolean& isCompleted)
at Microsoft.AspNetCore.Mvc.Internal.ResourceInvoker.InvokeFilterPipelineAsync()
at Microsoft.AspNetCore.Mvc.Internal.ResourceInvoker.InvokeAsync()
at Microsoft.AspNetCore.Builder.RouterMiddleware.Invoke(HttpContext httpContext)
at Microsoft.AspNetCore.Authentication.AuthenticationMiddleware.Invoke(HttpContext context)
at Microsoft.AspNetCore.Diagnostics.EntityFrameworkCore.MigrationsEndPointMiddleware.Invoke(HttpContext context)
at Microsoft.AspNetCore.Diagnostics.EntityFrameworkCore.DatabaseErrorPageMiddleware.Invoke(HttpContext httpContext)
at Microsoft.AspNetCore.Diagnostics.EntityFrameworkCore.DatabaseErrorPageMiddleware.Invoke(HttpContext httpContext)
at Microsoft.AspNetCore.Diagnostics.DeveloperExceptionPageMiddleware.Invoke(HttpContext context)

@mkArtakMSFT ?

  And can reliably reproduce this as I now have modules loaded using Assembly.Load(File.ReadAllBytes yada yada.  If I change this to Assembly.LoadFrom yada yada then it works.
I would hypothesise that Core is using Assembly.Location, which is an empty string for assemblies loaded using the Assembly.Load() method, which in turn is being passed down and causing the error, maybe ??

@muratg please move this to MVC.


Completing comparer tests

This PR just adds two tests to finish out the coverage on the NumericKeyComparer Class.
A couple screenshots to demonstrate the small change in coverage.
Before:

After:

👍


[Documentation] armresources.DeploymentProperties.Template comment allows JSON string

DeploymentProperties.Template comment says that it allows a JSON string to be passed, but only a JSON object is supported in calls to PUT /deployments.
https://pkg.go.dev/github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/resources/armresources#DeploymentProperties
https://pkg.go.dev/github.com/Azure/azure-sdk-for-go/services/resources/mgmt/2020-10-01/resources?utm_source=gopls#DeploymentProperties.Template

Offending descriptions ("It can be a JObject or a well formed JSON string."):

https://github.com/Azure/azure-rest-api-specs/blob/23b8c3e5ecc0a90bc89f93517d7f45ca0b6881d5/specification/resources/resource-manager/Microsoft.Resources/stable/2021-04-01/resources.json#L4564
https://github.com/Azure/azure-rest-api-specs/blob/23b8c3e5ecc0a90bc89f93517d7f45ca0b6881d5/specification/resources/resource-manager/Microsoft.Resources/stable/2021-04-01/resources.json#L4572

Note - same problem probably exists in multiple API versions


delay the slick slide before starting the slick transition to next slide via clicking dots

> short description of the bug / issue, provide more detail below.
I am trying to delay the slide transition starting by 1 second after clicking the dots pager.
====================================================================
###### [  paste your jsfiddle link here  ]
https://jsfiddle.net/joshmoto/Lcaung0w/
====================================================================
#### Steps to reproduce the problem
I am adding a .closed class to my current slick slide beforeChange, but also trying to delay the slide start transitioning by 1 second.
When the .closed class is added, it sets the height of the current slide to 0px !important. I am using transition: height 1s ease-in-out css to animate the height down to 0px. The slides have a fixed height so the animation works fine.
But I am struggling to delay the slide by 1 second beforeChange. The slick slide transitions instantly and the .closed css transition (1 second) is missed.
Can you help me delay the slide by 1 second before the slick transition starts changing to the next slide.
====================================================================
#### What is the expected behaviour?
The expected behaviour is that the when I click the dots pager buttons, the slick slider transition is delayed by 1 second. But I want to add my .closed class immediately (which works) but then the css height animation is missed, because the slide begins transitioning instantly. My speed is set to 0 because I don't want any transition effect on the slide itself. I am trying to make my own custom transition effect by adding/removing class.
====================================================================
#### What is observed behaviour?
The 1 second delay is ignored in the beforeChange function.
====================================================================
#### More Details
Using latest slick and jQuery.
For years I've been using slick because it is the last carousel you'll ever need, but today I have found an issue I cant work arround!
https://stackoverflow.com/questions/52459659/delay-the-slick-slide-before-starting-the-slick-transition-to-next-slide

Any solution to this?
When I click on my thumbnails in the slick sync mode very quickly, it doesn't change the slide.

You got any code? I was using the pager not the sync mode in my question. In the end managed to use beforeChange and afterChange to handle animations on the slide. I'm not sure this will apply for you? Post your code if you are struggling.

Solved this problem by disabling the default "Prev", "Next" and dots buttons and creating my own.
Here's the code:
`
document.addEventListener("DOMContentLoaded", function() {
// Set the transition delay here
const sliderTransitionDelay = 500;
// get the number of slides
let slidesNumber = $('.slider__inner').children().length;

// Init your slick-slider. Disable the default arrows and dots - w'll create these elements later.
$('.slider__inner').slick({
    arrows: false,
    dots: false
});

// Creating the "Prev" and "Next" buttons.
$('.slider').append('
<button class="slider__prev">Prev</button><button class="slider__next">Next</button>
');

// Creating the dots buttons
$('.slider').append('

');
for (let i = 0; i < slidesNumber; i++) {
    let dot = '
<button class="slider__dot" data-slide-index="' + i + '">' + i + '</button>
';
    $('.slider__dots').append(dot);
}

// Dot click actions
$('.slider__dots button').click(function(e) {
    // Getting an index of a target slide
    slideIndex = $(e.target).attr('data-slide-index');

    // Doing some actions here, i.e. animations
    $('.slider__content')
    .removeClass('animate__animated animate__backInUp')
    .hide()
    .addClass('animate__animated animate__backOutUp')
    .show();

    // Delay until the slide is changed
    setTimeout( () => {
        $('.slider__inner').slick('slickGoTo', slideIndex);
    }, sliderTransitionDelay)
});

// Next button actions
$('.slider__next').click(function(e) {

    // Doing some actions here, i.e. animations
    $('.slider__content')
    .removeClass('animate__animated animate__backInUp')
    .hide()
    .addClass('animate__animated animate__backOutUp')
    .show();

    // Delay until the slide is changed
    setTimeout( () => {
        $('.slider__inner').slick('slickNext');
    }, sliderTransitionDelay)
});

// Prev button actions
$('.slider__prev').click(function(e) {

    // Doing some actions here, i.e. animations
    $('.slider__content')
    .removeClass('animate__animated animate__backInUp')
    .hide()
    .addClass('animate__animated animate__backOutUp')
    .show();

    // Delay until the slide is changed
    setTimeout( () => {
        $('.slider__inner').slick('slickPrev');
    }, sliderTransitionDelay)
});

// Some actions after slide is changed
$('.slider__inner').on('afterChange', (event, slick, direction) => {

    $('.slider__content')
    .removeClass('animate__animated animate__backOutUp')
    .hide()
    .addClass('animate__animated animate__backInUp')
    .show();

})

});
`


Next / FastForward : disable buttons if there is no response on the page

As with the "Continue" button, to prevent emptying the response (inputs, checkboxGroup) and moving forward

Also check that continue/validate/previous still have the right behavior


Components

Documentation template and guidance on how to document:

General
Design
Developer
Content
Research
Accessibility

https://docs.google.com/document/d/1qbrWXa-UFaG29iHff4enqqB4xYd2okqoAxe9xDWFESw/edit#

Draft component template with a live example for 'Targeted Content'.
Worked on with Daniel N and Alex E.


docs: add consolidation policies rfc

Fixes #N/A
Description
RFC for https://github.com/kubernetes-sigs/karpenter/pull/1429 and https://github.com/kubernetes-sigs/karpenter/pull/1430
Let me know what topics or areas of interest need to be included or weren't fully covered. First time writing one of these.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 0   changed or added relevant lines in 0 files are covered.
4 unchanged lines in 2 files lost coverage.
Overall coverage decreased (-0.04%) to 78.096%

Files with Coverage Reduction
New Missed Lines
%

pkg/test/expectations/expectations.go
2
94.64%

pkg/controllers/disruption/drift.go
2
89.66%

Totals

Change from base Build<PHONE_NUMBER>:
-0.04%

Covered Lines:
8796

Relevant Lines:
11263

💛  - Coveralls

Sorry to have let this stale out, now that v1.0.0 is out the door we should all have more bandwidth for review. I'm planning on taking a look at this soon.
/reopen

Previously on 9/26 we had discussed splitting the problem statement into a separate PR so we could gather consensus and confirm we agree on the problem space. I apologize for taking so long, but I finally opened https://github.com/kubernetes-sigs/karpenter/pull/1746


feat(helm): add command to generate documentation

This adds a hidden 'helm doc' command that generates documentation out
of the Helm help text.
Currently it can create:

man pages for HELM(1)
Markdown documentation
bash autocompletions

Those are the three built-ins for Cobra.
The command is hidden so that it doesn't show up to the regular user,
since this is really a specialized task. It has the advantage of making
it trivially easy to install man pages and bash completion at installation time.

This change is

DON'T MERGE THIS UNTIL AFTER 2.0.0!

Does this support the completion command to generate the completion script on the fly? Something like
helm completion --shell bash. Maybe it helm docs --type bash will also work?
It would be nice to have this since we could deploy only the binary without having to provide the completion script.

@rodcloutier Yeah, it's helm docs --type bash. Right now, it just uses the built-in completion that Cobra provides.


Editing the path of a node in a TypedArray of type Object fails

Tested versions

Reproducible in 4.2.1.stable and later, haven't tested before but it's probably there since the introduction of the feature.

System information
Godot v4.2.1.stable - Windows 10.0.19045 - Vulkan (Forward+) - dedicated NVIDIA GeForce RTX 3060 (NVIDIA; <IP_ADDRESS>12) - Intel(R) Core(TM) i7-6700K CPU @ 4.00GHz (8 Threads)
Issue description
When trying to edit the path of a node in a typed array of Object, it fails and give the following message :
  Attempted to set a variable of type 'NodePath' into a TypedArray of type 'Object'.
  core/variant/array.cpp:413 - Condition "!_p->typed.validate(value, "set")" is true.

https://github.com/godotengine/godot/assets/75151379/f79acf21-d147-4c68-b40e-13a456709ef8
I discovered this while working on the batch drag and drop PR.
PS : On a side note, I think it is probably the cause of another bug when using the AnimationPlayer, when it RESET the track, the array keep its size, but with empty slots. I think it's a plausible theory because this issue is not happening with typed array of NodePaths.
Steps to reproduce

Add a node in the typed array of Object
Click the 3 dots and press Edit
Change the path to another valid node
Observe it fails and print the error message

Minimal reproduction project (MRP)
EditPathBug.zip

duplicate of #89065


Add ForceUpdateTag description for PipelineRun

Add description and example for using forceUpdateTag property when redeploying a pipelineRun resource.

@jaysterp : Thanks for your contribution! The author(s) have been notified to review your proposed change.

#sign-off


Fixed previous pull request errors

What does this PR do?
Add resource(s)
For resources
Added resources
Description
added resources as well as fixed all errors from previous pull request
Why is this valuable (or not)?
new and extensive guides to viewers
How do we know it's really free?
i have personally used it...doesnt require account or registrations of any kind
For book lists, is it a book? For course lists, is it a course? etc.
Checklist:

[x] Read our contributing guidelines.
[x] Search for duplicates.
[x] Include author(s) and platform where appropriate.
[x] Put lists in alphabetical order, correct spacing.
[x] Add needed indications (PDF, access notes, under construction).
[x] Used an informative name for this pull request.

Follow-up

Check the status of GitHub Actions and resolve any reported warnings!

no editorial comments


retyping channel when renaming it -  ecg not in channel list

Hi,
I suggest adding a mne.channel.retype (or an automatic retyping to channel.rename_channels), especially for 'ecg' and 'eog'. I get those from biochannels, and can do raw.pick_channels; but without the correct type I can't use mne.pick_typesor ica_find_bads_ecg.
I retyped them manually by digging into the code belly and adding:
raw.info['chs'][raw.info['ch_names'].index('ecg')]['kind']=402
raw.info['chs'][raw.info['ch_names'].index('eog')]['kind']=202

but I guess it would solve people a lot of time not having to find and go through the numeric channel identities. Also they may warrant a listing in the manual / API (section mne.channel), or maybe I overlooked that?

do you know the set_channel_types methods?
eg for raw:
http://martinos.org/mne/dev/generated/mne.io.Raw.html#mne.io.Raw.set_channel_types

Ah, indeed I overlooked it, though I did scan that page; my apologies.
Should I turn to the mailing list first in general?
Thanks,
tnt

yes mailing list for such questions is better.
close the issue if we're good


Add rxd parameter - Issue #495

Major change is adding the RxD Parameter class.  Tested by replacing some constants in examples/rxd_net.py with parameters.
Includes fix of typo in netrxd.py definition of _addStates(): param['initial'] == None -> param['initial'] = None
Also now allows for specifying the number of rxdthreads used in init scripts (e.g. sim.net.addRxD(nthreads=6) )

Hey @kelley92 , I'm going to be doing a new release soon, before which I'd like to accept all Pull Requests that are completely ready.  Is this one good to go?  If so would you mind resolving the conflicts?  Thanks!


Returning a per request metric for number of cached_tokens read

Motivation
Right now sglang uses an advanced radix cache system, but it is not possible to know for each request how many of the
tokens were computed, or read from the cache. This pull request offer a way to easily return this information

Modifications
Most important edit is to the UsageInfo structure, adding cached_tokens in prompt_tokens_details the same way openai does it. To limit the impact to current users, this is disabled by default and needs to be activated using --activate-cache-report server parameters.
For sglang /generate requests, the number of cached tokens is always returned in the meta_info dictionary
I'm not really sure about the extra parameter to the server, which is not implemented very elegantly. I'm open to suggestion to improve it. It could also be entirely removed and this report be activated by default (to avoid adding yet another server argument).

Checklist

[x] Format your code according to the Contributor Guide.
[x] Add unit tests as outlined in the Contributor Guide.
[x] Update documentation as needed, including docstrings or example tutorials.

I changed the computation as suggested. However, it was not that simple, as it now requires to explicitely handle the case where a prefill is split among several chunks (to avoid counting the first chunks as being already in cache).
It seems to work at the moment, but I'll test it more to be really sure (probably on Monday).
I'll also try to handle the case where the same prompt was already sent, it seems in that case that the cache is prompt_tokens - 1, which isn't really true it should be prompt_tokens.

The case of sending the same prompt twice is tricky. It depends on how you define "cache tokens".

If you treat it as cached tokens in memory, then the second time, #cache-tokens should be #prompt-token
If you define #cached-tokens as the number of skipped tokens in the prefill, then the current return value #prompt-token - 1 is correct. Because even if you cache the full prompt, you only cache the KV cache, not the final logits. You have to run the computation again for that last token to get the logits.

I think returning #prompt-token - 1 for the second time makes sense from a computation-saving perspective.

@merrymercy I did some further tests, and it seems that now it counts properly, I didn't saw any request with the cache counted several time. I let the return be #prompt-token -1 as it makes more sense, and it doesn't make a big difference anyway.
I rebased the branch, it should be "almost" up to date (a commit on the main branch occured at the same time it seems)

@merrymercy chunked prefill is already tested and even present in the unit test (that's why the engine is configured with --chunked-prefill-size=40 in this test, to test a prefill splitted between several chunks without it being to big / long to process).
I just tested jump-forward decoding, but it seems I'm affected by this bug #1312 and I'm not sure that it only impacts the logs.
With and without jump forward activated, for a simple schema with an enum (where in theory jump forward should be able to jump the length of the enum, that I made extra long for the test), I got the exact same Usage in output (prompt, completion and cached), and even printing the internal completion_tokens_wo_jump_forward they are the same . I'm not sure that's normal.

@havetc Thanks for the contribution. It is merged. We can iterate on this and fix bugs if there is any mismatch on the token counting.


testing: test.timeout uses panic(), returning an exitcode of 0

Please answer these questions before submitting your issue. Thanks!
What version of Go are you using (go version)?
go version go1.8.1 linux/amd64
What operating system and processor architecture are you using (go env)?
GOARCH="amd64"
GOBIN=""
GOEXE=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOOS="linux"
GOPATH="/home/movits/gocode"
GORACE=""
GOROOT="/home/movits/go"
GOTOOLDIR="/home/movits/go/pkg/tool/linux_amd64"
GCCGO="gccgo"
CC="gcc"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build095751258=/tmp/go-build"
CXX="g++"
CGO_ENABLED="1"
PKG_CONFIG="pkg-config"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
What did you do?
if you set a test.timeout on the cmdline when using go test, and you hit the timeout, the testing code calls panic to stop and print a stack trace:
https://github.com/golang/go/blob/bd74fd3abb27b9b857ca77c9ee648299045ce963/src/testing/testing.go#L1148
However, this causes the execution to exit with an exitcode of 0, unlike all other failure scenarios.
What did you expect to see?
An exitcode of 1.  As with this comment:
https://github.com/golang/go/blob/bd74fd3abb27b9b857ca77c9ee648299045ce963/src/testing/testing.go#L907
// Run runs the tests. It returns an exit code to pass to os.Exit.
IOW, failure usually means a non-zero exitcode--except in the case of timeout.  (Or perhaps other panic()s too?)
What did you see instead?
And exitcode of 0.

Could you provide a small, self-contained reproducer for this? I just tried to reproduce this with:
package bug

import (
        "testing"
        "time"
)

func TestBug(t *testing.T) {
        time.Sleep(time.Minute)
}

 $ go test -timeout=1s
panic: test timed out after 1s

goroutine 17 [running]:
testing.startAlarm.func1()
        /home/mvdan/tip/src/testing/testing.go:1146 +0xf9
created by time.goFunc
        /home/mvdan/tip/src/time/sleep.go:170 +0x44

goroutine 1 [chan receive]:
testing.(*T).Run(0xc42007c000, 0x5342b6, 0x7, 0x53c6b0, 0x468b26)
[...]
exit status 2
FAIL    _/home/mvdan/bug        1.004s
[mvdan@carbon:3] [1] [/home/mvdan/bug]
 $ echo $?
1

You're right, my test harness had a logic bug.


Iran (Islamic Republic of) (IR/IRN)

Please can you add "Iran (Islamic Republic of)" (IR/IRN)

Hi,
IR is already in the data at https://github.com/fannarsh/country-list/blob/master/data.json#L418
I don't support the three letter country codes (ISO 3166-1 alpha-3).
cheers


add property to properly reference ant-xyna dir (#1)

ant-xyna.xml is now properly referenced.
However, when ant -f installation/install.xml is called now, the line https://github.com/GIP-SmartMercial/xyna-factory/blob/8743d6e8f89d6a6f73320b35331dc4558f802642/installation/install/install.xml#L23 can't execute because delivery.name is never read.

I selected the wrong branch here. Those are not the correct changes


Feature Request: IDS Alerts

I would like to see the IDS alerts page also show source and destination ports and which interface it was generated on in the main IDS alert listing. A choice of which categories to display would also be helpful.

IDS is in core. Are you sure that this should be posted here?

I am requesting an addition to the list of displayed alerts in IDS in the WebGUI. This dropdown list should show the ports and the interface. I know the ports are shown in the detail, but they should also be shown in the list. The Interface that triggered the alert is not shown anywhere which is useful when IDS is attached to multiple interfaces

The issue tracker for core is here: https://github.com/opnsense/core/issues
Plugins is everything you can install via the plugins menu (system -> firmware).

Thanks, I will post in core. Admin, please delete this thread.

@tpcr We cannot delete it - but I can close it.


Remove root ApplyPatches and clean-up dotnetcommmand properties

cc @eerhardt

Looks like source-build doesn't import Build.Common.props, which means this property isn't getting set.


gui: bitcoin=0.30 and async-hwi=0.0.8

Opened https://github.com/wizardsardine/liana/issues/573 for the flaky test and re-ran the checks.


CentOS release enforcement in kickstart/yum configuration

Hello
Working on PR #1, I noticed this code in etc/ks-update.cfg :
# 20151221: mirrorlist.centos.org doesn't return a list for release=7.2.1511
# but does for release=7.1.1503
mirror_works=`curl "http://mirrorlist.centos.org/?repo=os&arch=x86_64&release=${myrel}" | grep '^http://'`

if [ -n "${mirror_works}" ]; then
	mkdir -p /etc/yum/vars
	echo "${myrel}" > /etc/yum/vars/releasever
fi

I understand it should fix the CentOS release in yum's configuration, only when mirrorlist.centos.org answers the request.
When it doesn't, yum relies on its defaults, which will be the current CentOS release. Thus it will allow minor CentOS upgrades.
Is that right?
However, it doesn't work for 7.3.1611. And as of today, it doesn't work for 7.1.1503 either. Guess it worked earlier ?
From my understanding, it only works with releasever=7, and it returns a mirror list for the latest CentOS 7 release.
Any thoughts about this since commit 6b5ccf0b ?

Yes, I think they changed CentOS so the notion of pinned minor versions doesn't really exist anymore. For most people, I think pinning at the major version is fine, but we ran into some packages that had breaking changes within minor CentOS versions. We mostly solve that now by using our own yum mirrors and staging updates to those mirrors.

OK. I think I'll go with frozen mirrors too. Thanks. :)


[RELEASE-1.8] Fix cm configuration and checks

What this PR does / why we need it:

fixes the cm features checking as jsonPath is tricky and properties with dots need escaping.
fixes the timeout command as actually we need to wait for a command to succeed
cleans up the code for setting cm properties
run shellCheck locally.

Which issue(s) this PR fixes:
JIRA: NO jira it is meant for cleanup
Does this PR needs for other branches:
Yes but will do it manually for verifying spellcheck.
Does this PR (patch) needs to update/drop in the future?:
NONE

/unhold


Change the minified directory path so it is within the /dist folder.

Not sure why this was needed... Didn't need it before...


feat: add filter of substations based on network of lines

Pull Request doc
Purpose

Implement a filtering of substations, based on whether they're present in the largest connected component in the graph constructed from the filtered table of transmission lines. This mirrors the logic within the data_transform function of the data_trans.py file in @Mingze-Li128's branch.
Clean up the variable naming inside build_transmission for readibility and compactness.

What the code is doing

We add the networkx package as a requirement, to make use of graph analysis functions.
We add a new function filter_substations_by_connected_components, which creates a networkx graph from the filtered data frame of lines, identifies the substations which are part of the largest connected component, and filters out substations which are not part of this part of the network (or not connected to the network at all).
We use this function within build_transmission
We rename all intermediate data frames of transmission lines as simply lines, and all intermediate data frames of substations as just substations.

Testing
Tested manually.
Usage Example/Visuals
>>> from prereise.gather.griddata.hifld.data_process.transmission import build_transmission
>>> lines, substations = build_transmission()
dropping 6892 substations of 70857 total due to LINES parameter equal to 0
dropping 759 lines with one or more substations listed as 'NOT AVAILABLE' out of a starting total of 71554
dropping 3143 lines with one or more substations not found in substations table out of a starting total of 70795
Evaluating endpoint location mismatches... (this may take several minutes)
dropping 120 lines with one or more substations with non-matching coordinates out of a starting total of 67652
dropping 143 lines with matching SUB_1 and SUB_2 out of a starting total of 67532
dropping 13358 substations not connected to largest island out of a starting total of 63965

Time estimate
15 minutes to understand, longer if we want to make changes to the logic.

One note here: as mentioned briefly in #202, most of the filtering of substations that are not present in the largest connected component ends up filtering substations that are not part of any connected component. 13,358 substations get dropped, but the connected components besides the largest one only contain 2,738 substations.
There are about 800 connected components, and we can approximately halve the number of connected substations dropped if we can connect the 200 next largest components (we get 1,359 of those 2,738).

One note here: as mentioned briefly in #202, most of the filtering of substations that are not present in the largest connected component ends up filtering substations that are not part of any connected component. 13,358 substations get dropped, but the connected components besides the largest one only contain 2,738 substations.
There are about 800 connected components, and we can approximately halve the number of connected substations dropped if we can connect the 200 next largest components (we get 1,359 of those 2,738).

So there are 13358 - 2738 = 10620 isolated substations which don't have any lines connected to?

One note here: as mentioned briefly in #202, most of the filtering of substations that are not present in the largest connected component ends up filtering substations that are not part of any connected component. 13,358 substations get dropped, but the connected components besides the largest one only contain 2,738 substations.
There are about 800 connected components, and we can approximately halve the number of connected substations dropped if we can connect the 200 next largest components (we get 1,359 of those 2,738).

So there are 13358 - 2738 = 10620 isolated substations which don't have any lines connected to?

Seems so.

If we comment out the new line substations = filter_substations_by_connected_components(lines, substations), we can analyze the connected components, and we can find the closest pair of substations between the largest island and any smaller one.
Using Maine as an example, with the assumption that the closest substation in the big island will be in either Maine or New Hampshire, we can identify two substations in Oakfield, Maine which are six miles apart and would connect the biggest and second-biggest islands.
>>> import networkx as nx
>>> from powersimdata.utility.distance import haversine
>>> from prereise.gather.griddata.hifld.data_process.transmission import build_transmission
>>>
>>> lines, substations = build_transmission()
dropping 6892 substations of 70857 total due to LINES parameter equal to 0
dropping 759 lines with one or more substations listed as 'NOT AVAILABLE' out of a starting total of 71554
dropping 3143 lines with one or more substations not found in substations table out of a starting total of 70795
Evaluating endpoint location mismatches... (this may take several minutes)
dropping 120 lines with one or more substations with non-matching coordinates out of a starting total of 67652
dropping 143 lines with matching SUB_1 and SUB_2 out of a starting total of 67532
>>> lines = lines.astype({"SUB_1_ID": int, "SUB_2_ID": int})
>>> graph = nx.convert_matrix.from_pandas_edgelist(lines, "SUB_1_ID", "SUB_2_ID")
>>> components = sorted(nx.connected_components(graph), key=len)[::-1]
>>> [len(c) for c in components]
[50607, 41, 36, 34, 31, 29, 24, 22, 21, 17, 17, 15, 15, 15, 15, 13, 13, 12, 12, 12, 12, 11, 10, 10, 10, 9, 9, 9, 9, 9, 9, 8, 8, 8, 8, 8, 8, 8, 8, 8, 8, 8, 8, 7, 7, 7, 7, 7, 7, 7, 7, 7, 7, 7, 7, 7, 7, 6, 6, 6, 6, 6, 6, 6, 6, 6, 6, 6, 6, 6, 6, 6, 6, 6, 6, 6, 6, 6, 6, 6, 6, 6, 5, 5, 5, 5, 5, 5, 5, 5, 5, 5, 5, 5, 5, 5, 5, 5, 5, 5, 5, 5, 5, 5, 5, 5, 5, 5, 5, 5, 5, 5, 5, 5, 5, 5, 5, 5, 5, 5, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 3, 3, 3, 3, 3, 3, 3, 3, 3, 3, 3, 3, 3, 3, 3, 3, 3, 3, 3, 3, 3, 3, 3, 3, 3, 3, 3, 3, 3, 3, 3, 3, 3, 3, 3, 3, 3, 3, 3, 3, 3, 3, 3, 3, 3, 3, 3, 3, 3, 3, 3, 3, 3, 3, 3, 3, 3, 3, 3, 3, 3, 3, 3, 3, 3, 3, 3, 3, 3, 3, 3, 3, 3, 3, 3, 3, 3, 3, 3, 3, 3, 3, 3, 3, 3, 3, 3, 3, 3, 3, 3, 3, 3, 3, 3, 3, 3, 3, 3, 3, 3, 3, 3, 3, 3, 3, 3, 3, 3, 3, 3, 3, 3, 3, 3, 3, 3, 3, 3, 3, 3, 3, 3, 3, 3, 3, 3, 3, 3, 3, 3, 3, 3, 3, 3, 3, 3, 3, 3, 3, 3, 3, 3, 3, 3, 3, 3, 3, 3, 3, 3, 3, 3, 3, 3, 3, 3, 3, 3, 3, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2]
>>> largest_island = substations.loc[components[0]]
>>> largest_island
                   X             Y  ... MAX_INFER MIN_INFER
ID                                  ...
131072 -1.069084e+07  5.898522e+06  ...         N         N
131089 -9.311883e+06  5.323699e+06  ...         Y         Y
131090 -1.049062e+07  5.162095e+06  ...         Y         Y
131091 -1.049057e+07  5.161922e+06  ...         Y         N
131092 -1.047791e+07  5.136316e+06  ...                  Y         Y
131068 -1.034633e+07  5.144523e+06  ...         Y         N
131069 -1.035529e+07  5.125052e+06  ...         Y         Y
131070 -1.071809e+07  5.914971e+06  ...         Y         Y
131071 -1.048157e+07  5.915785e+06  ...         Y         N

[50607 rows x 24 columns]
>>> second_island = substations.loc[components[1]]
>>> second_island
                   X             Y           NAME  ...
We build a 800*800 matrix that represents a fully connected graph among all islands. The value in each cell is the minimum distance between the corresponding two islands which could be calculated by the function above. The matrix is symmetric with all zeros in the leading diagonal.
Finally, we find a minimum spanning tree within the fully connected graph we construct in the second step. I presume networkx can do this directly. Otherwise, lots of well known algorithms are applicable, such as Prim, Kruskal, etc.

@danielolsen I was thinking of the following algorithm to connect all the components at minimum "cost" (assuming the cost is the angular distance here, we could change it to any other metric that makes more sense from power system perspective):
* Implement a function to solve following sub problem: similarly as your demonstration above, given two islands as inputs, it returns two substations from each island respectively, the distance between which is minimum to connect the two islands together.

* We build a 800*800 matrix that represents a fully connected graph among all islands. The value in each cell is the minimum distance between the corresponding two islands which could be calculated by the function above. The matrix is symmetric with all zeros in the leading diagonal.

* Finally, we find a minimum spanning tree within the fully connected graph we construct in the second step. I presume `networkx` can do this directly. Otherwise, lots of well known algorithms are applicable, such as Prim, Kruskal, etc.

I like your line of thinking. We can potentially speed this operation by avoiding calculations for islands that are obviously not going to be connected directly (e.g. an island in Arizona and an island in New York) and substituting infinity in their place in the 800x800 matrix that's fed to the minimum spanning tree algorithm. Similar to my example, we can use a predefined mapping of states to neighbor states to identify nonsensical hypothetical connections.

@danielolsen I was thinking of the following algorithm to connect all the components at minimum "cost" (assuming the cost is the angular distance here, we could change it to any other metric that makes more sense from power system perspective):
* Implement a function to solve following sub problem: similarly as your demonstration above, given two islands as inputs, it returns two substations from each island respectively, the distance between which is minimum to connect the two islands together.

* We build a 800*800 matrix that represents a fully connected graph among all islands. The value in each cell is the minimum distance between the corresponding two islands which could be calculated by the function above. The matrix is symmetric with all zeros in the leading diagonal.

* Finally, we find a minimum spanning tree within the fully connected graph we construct in the second step. I presume `networkx` can do this directly. Otherwise, lots of well known algorithms are applicable, such as Prim, Kruskal, etc.

I like your line of thinking. We can potentially speed this operation by avoiding calculations for islands that are obviously not going to be connected directly (e.g. an island in Arizona and an island in New York) and substituting infinity in their place in the 800x800 matrix that's fed to the minimum spanning tree algorithm. Similar to my example, we can use a predefined mapping of states to neighbor states to identify nonsensical hypothetical connections.

Agree. Only looking at geographical neighbors will potentially prune the problem significantly.

As a workflow question, do we want to:

Merge this current function, and make an Issue to improve this step
Keep this PR open until an improved algorithm is developed/implemented
Close this PR, and submit a new one once an improved algorithm is developed/implemented
?

As a workflow question, do we want to:

Merge this current function, and make an Issue to improve this step
Keep this PR open until an improved algorithm is developed/implemented
Close this PR, and submit a new one once an improved algorithm is developed/implemented

?

I think we can remove the substation filer in the end and close this PR given the algorithm we are discussing will use the results here. What do you think?

I think we can remove the substation filer in the end and close this PR given the algorithm we are discussing will use the results here. What do you think?

I think there could be value in proceeding with the current implementation, even if it's just so that we have something that can unblock the other downstream efforts (e.g. identifying transformers, constructing the bus dataframe, assigning generators to buses, etc.). Once we can construct a valid Grid and profiles, then we can test the impact of different improvements to the different parts of the chain. I could be convinced otherwise though. @rouille, what do you think?

I think we can remove the substation filer in the end and close this PR given the algorithm we are discussing will use the results here. What do you think?

I think there could be value in proceeding with the current implementation, even if it's just so that we have something that can unblock the other downstream efforts (e.g. identifying transformers, constructing the bus dataframe, assigning generators to buses, etc.). Once we can construct a valid Grid and profiles, then we can test the impact of different improvements to the different parts of the chain. I could be convinced otherwise though. @rouille, what do you think?

If we proceed with the largest island only, we can't implement the algorithm that we are discussing in parallel, right? At least we should keep all islands, i.e. all subs and lines within those islands, at this stage, so that it opens the window to improve. The main stream implementation in the next step could just take one cc to start with, which could be the biggest island or the cc consists of all islands using the algorithm, no?

You're right, we can get started with developing the next step as long as there is an initial 'largest connected component-only' filtering in the beginning of that step. Later, if we connect all islands, then that filter will be moot and can be removed, but the underlying algorithm won't need to change.

I think we can remove the substation filer in the end and close this PR given the algorithm we are discussing will use the results here. What do you think?

I think there could be value in proceeding with the current implementation, even if it's just so that we have something that can unblock the other downstream efforts (e.g. identifying transformers, constructing the bus dataframe, assigning generators to buses, etc.). Once we can construct a valid Grid and profiles, then we can test the impact of different improvements to the different parts of the chain. I could be convinced otherwise though. @rouille, what do you think?

I am not too worried about the filtering for the moment. I am more interested in the methodology as we discussed today.


Not compatible with babel-core/register 5.8 when update to 0.5.7

i use "-r babel-core/register" (Babel 5.8.35) on develop, when update to 0.5.7 (continuation-local-storage use it), will get the error in event "unhandledRejection": promise.__asl_wrapper is not a function.
Unhandled Rejection at: Promise  Promise {
_d:
{ p: [Circular],
c: [],
a: [],
s: 2,
d: true,
v: [TypeError: promise.__asl_wrapper is not a function],
h: false,
n: false },
__asl_wrapper: [Function: proxyWrapper] }  reason:  [TypeError: promise.__asl_wrapper is not a function]
TypeError: promise.__asl_wrapper is not a function
at Promise.proxyWrapper [as __asl_wrapper] (E:\My_Projects\Java\Work_Space_For_IDEA\ant\ant-manage-web\node_modules\async-listener\index.js:438:17)
at E:\My_Projects\Java\Work_Space_For_IDEA\ant\ant-manage-web\node_modules\async-listener\index.js:450:32
at run (E:\My_Projects\Java\Work_Space_For_IDEA\ant\ant-manage-web\node_modules\core-js\modules\es6.promise.js:104:47)
at E:\My_Projects\Java\Work_Space_For_IDEA\ant\ant-manage-web\node_modules\core-js\modules\es6.promise.js:115:28
at flush (E:\My_Projects\Java\Work_Space_For_IDEA\ant\ant-manage-web\node_modules\core-js\modules$.microtask.js:19:5)
at E:\My_Projects\Java\Work_Space_For_IDEA\ant\ant-manage-web\node_modules\async-listener\glue.js:188:31
at nextTickCallbackWith0Args (node.js:415:9)
at process._tickCallback (node.js:344:13)

Could you provide more details on how to reproduce the issue? Using babel 5 and default transforms, I was not able to reproduce any issues.

without any way to reproduce the issue, I spent a lot of time today trying to guess at what could be causing the issue. I have an  untested theory, but if you have a chance, could you try testing this change: https://github.com/hayes/async-listener/commit/7f1d80cde6b8cbcbcd3145f74746cb447685f788 to see if it fixes the issue for you?

Hopefully, we can upgrade to the newest version as soon as possible.

I'll try to get a PR up as soon as I can get a test for the issue
On Sun, Mar 6, 2016, 5:42 PM Xu Jin<EMAIL_ADDRESS>wrote:

Yes, this patch is available for me, Thank you ! ! ! !
Hopefully, we can upgrade to the newest version as soon as possible.
—
Reply to this email directly or view it on GitHub
https://github.com/othiym23/async-listener/issues/51#issuecomment-193039670
.

This is affecting parsing of swagger specs on startup of blueoak-server projects that also have a dependency on this library.

Okay, this should be fixed now, and released with<EMAIL_ADDRESS> @Qard @hayes

Thanks @Qard @hayes - it looks like things are back in order.

Thanks @hayes, that patch fixed my issue too :)


Website content crafting and publishing: Components/ Mega Menu AI & HC enhancement - Web components

Objective
Provide Carbon for IBM.com adopter the best practices and guidance they need to adopt Carbon for IBM.com.
General publishing process
Please make sure you always start the content crafting process by viewing the 2020 website content publishing process box document first.
Publishing for Components section website page

Content crafting starts as soon as the design is finalized.
Components section includes UI components and Layout components.
The content can be at the MVP level. MVP means the content meets the basic needs of an adopter for learning. It does not mean the content crafting will or should stop at this stage. Future enhancement should be working on with a separate task issue.
MVP content publishing template and requirement can be found in the Publishing template and best practices/_UI and Layout Components folder.
Please use the visual and design spec files inside of the Carbon for IBM.com Box folder as a reference.
Content publishing to the live website can be code or markdowns. If you need guidance on how to start with markdowns, please see the step by step instruction in the Editing and publishing in Github Box document.
When the page is published, please also make sure the components table list on the Overview page is updated as part of the publishing task.

File naming and storage

Name the Sketch file with the following convention: Name of the category + components/pattern/guideline + version. ex: Components-Feature card block v1.0, Guidelines-Expressive theme v1.0, Help-Overview v1.0 and etc.
Please save all content publishing work files (box, markdowns link, or Sketch file) in the proper sub-folder under the ✍ Content + Design folder.

Publishing acceptance criteria

[ ] Content crafting is done.
[ ] Asset image creation is done.
[ ] Page design is done (as needed).
[ ] Publishing with markdown is done.
[ ] Update the Overview page component table list with the new component name, link to the newly published component page, description and status when the markdown is done.
[ ] Create a thumbnail of the new component.   Thumbnail examples can be viewed here.  The Sketch file that will help you get started can be found here.  If you are not familiar with component thumbnail creation, please ask another designer or Jenny for assistance.  Once the thumbnail is created, please review with Wonil for approval, then export the file as an SVG for implementation.
[ ] Add the new component thumbnail to the Overview page/Gallery view by adding the image file to the components.json markdown file. Please follow the file naming format so it can be linked to the website page automatically (ex: thumbnail svg file for "Card section – Carousel" should be "cardsection-carousel.svg").
[ ] QA'd by Jenny.
[ ] Web page preview is approved by Linda, Jeff, and Wonil.
[ ] PR merged by Jenny.
[ ] Web page is published and live on the website.

FYI @RobertaJHahn I think this issue does not need work. The component update is only to the "products & solutions" dropdown, and the Masthead page doesn't show "products & solutions" dropdown opened as an example. In the future we might wanna include more content regarding the Mega menu as a separate exercise. So this issue can be closed.


Fixed #27648 -- Deprecated (iLmsu) regex groups in url() patterns.

https://code.djangoproject.com/ticket/27648

LGTM


README instructions don't work for me who doesn't know Python

I don't know Python and when I follow the README instructions it doesn't seem to work:
First I run the pip install command:
pip3 install -U openapi-to-asciidoc

Output:
Requirement already satisfied: openapi-to-asciidoc in /Library/Frameworks/Python.framework/Versions/3.12/lib/python3.12/site-packages (0.1.5.dev2)
Requirement already satisfied: jinja2-cli>=0.8.2 in /Library/Frameworks/Python.framework/Versions/3.12/lib/python3.12/site-packages (from openapi-to-asciidoc) (0.8.2)
Requirement already satisfied: jinja2>=3.1.2 in /Library/Frameworks/Python.framework/Versions/3.12/lib/python3.12/site-packages (from openapi-to-asciidoc) (3.1.4)
Requirement already satisfied: marshmallow>=3.19.0 in /Library/Frameworks/Python.framework/Versions/3.12/lib/python3.12/site-packages (from openapi-to-asciidoc) (3.21.3)
Requirement already satisfied: MarkupSafe>=2.0 in /Library/Frameworks/Python.framework/Versions/3.12/lib/python3.12/site-packages (from jinja2>=3.1.2->openapi-to-asciidoc) (2.1.5)
Requirement already satisfied: packaging>=17.0 in /Library/Frameworks/Python.framework/Versions/3.12/lib/python3.12/site-packages (from marshmallow>=3.19.0->openapi-to-asciidoc) (24.1)

Then when I run the python command:
python3 openapi_to_asciidoc -j openapi.json -o openapi.adoc

I am getting this error:
/Library/Frameworks/Python.framework/Versions/3.12/Resources/Python.app/Contents/MacOS/Python: can't open file '/<redacted>/openapi_to_asciidoc': [Errno 2] No such file or directory

As a complete Python n00b, what do I need to do in order to use/run this generator? 😅

Hi and welcome! I think that your problem is that the path to the openapi.json file is not correct.
Your would have to provide the complete path to the openapi.json file if you are not running the openapi-to-asciidoc command from the same folder as your openapi.json file is placed in.


The 8 Requirements of Real-Time Stream Processing

https://cs.brown.edu/~ugur/8rulesSigRec.pdf

https://zhuanlan.zhihu.com/p/499286673


SAML2SSOAuthenticator isHandle method needs to be implement properly

Currently the isHandle method does not check any conditions [1]. Therefore if the Authenticators propriety is high, even the admins service calls with the basic auth will be picked up by SAMLSSOAuthenticator.
As a workaround we can set the priority of the SAML2SSOAuthenticator to 0 as below,
<CARBON_HOME>/repository/conf/security/authenticators.xml
<Authenticator name="SAML2SSOAuthenticator" disabled="false">
        <Priority>0</Priority>
        <Config>
            <Parameter name="LoginPage">/carbon/admin/login.jsp</Parameter>
            <Parameter name="ServiceProviderID">carbonServer</Parameter>
            <Parameter name="IdentityProviderSSOServiceURL">https://localhost:9443/samlsso</Parameter>
            <Parameter name="NameIDPolicyFormat">urn:oasis:names:tc:SAML:1.1:nameid-format:unspecified</Parameter>
            <Parameter name="AssertionConsumerServiceURL">https://localhost:9443/acs</Parameter>
	</Config>
</Authenticator>

But we need to fix the isHandle method properly as the permeant solution.
[1] https://github.com/wso2-extensions/identity-carbon-auth-saml2/blob/master/components/org.wso2.carbon.identity.authenticator.saml2.sso/src/main/java/org/wso2/carbon/identity/authenticator/saml2/sso/SAML2SSOAuthenticator.java#L266

This issue is being closed due to extended inactivity. Please feel free to reopen it if further attention is needed. Thank you for helping us keep the issue list relevant and focused!


Broken Image Links for Avatars

From this twitter comment/conversation asked by @Primigenus (Rahul):
https://twitter.com/Rahul/status/553835276389584896
The problem appears to be that if a user signs up via twitter or another linked service and then changes his/her avatar image on twitter/other service, the user.profile object does not get updated, so the image load fails and initials are shown instead. I'll try to track it down and implement a bugfix soon.

I finally looked into this, and my initial assessment seems to be incorrect. I just tried logging in with twitter then changing my twitter avatar. Upon logging out and then logging back into Telescope, the image URL gets updated. If I remember correctly, that functionality is handled by the built-in Meteor user accounts system.
The only situation I can imagine where the image link could get broken is if the user changed their avatar elsewhere and then didn't login to Telescope for a long time and the linked service removed the image?
Can anyone else verify this?

It seems to work well now :)


Compilation

Hi at least in my case I had to install libnewlib-arm-none-eabi on my Ubuntu (16.04) distro. Otherwise I was getting
src/usbd_8dev_if.c:22:20: fatal error: string.h: No such file or directory
#include <string.h>
Also could you please update Makefile as current stm32cube lib is V1.9.0

Doesn't compile here either. I adjusted the stm32cube lib directory and then I got:
arm-none-eabi-gcc -g -Os -std=c99 -pedantic -Wall -Wextra -Werror -ffunction-sections -fdata-sections -mthumb -mcpu=cortex-m0 -DCORE_M0 -DSTM32F042x6 -DHSE_VALUE=16000000 -I inc -I lib/STM32CubeF0-1.11.3/Drivers/CMSIS/Include -I lib/STM32CubeF0-1.11.3/Drivers/CMSIS/Device/ST/STM32F0xx/Include -I lib/STM32CubeF0-1.11.3/Drivers/STM32F0xx_HAL_Driver/Inc -I lib/STM32CubeF0-1.11.3/Middlewares/ST/STM32_USB_Device_Library/Core/Inc -MMD -o obj/usbd_8dev_if.o -c src/usbd_8dev_if.c
src/usbd_8dev_if.c: In function 'usbd_8dev_transmit_can_frame':
src/usbd_8dev_if.c:163:5: error: unknown type name 'CanRxMsgTypeDef'
  163 |     CanRxMsgTypeDef *buf_canrx = can_handle.pRxMsg;
      |     ^~~~~~~~~~~~~~~
src/usbd_8dev_if.c:163:44: error: 'CAN_HandleTypeDef' {aka 'struct __CAN_HandleTypeDef'} has no member named 'pRxMsg'


understanding file renaming within flask_uploads. (any filename changes other than " " replaced by "_" ? )

I'm using
from flask_uploads import configure_uploads, ALL, UploadSet
all = UploadSet('all', ALL)
configure_uploads(app, all)

then in a flask route
form = MyForm()
    if form.validate_on_submit():
        filename = form.all.data.filename
        fname = all.save(form.all.data)

filename and fname will not be the same.
fname appears to replace any spaces in filename  with "_".
if duplicate filenames are uploaded, fname appears to append "_01", "_02" etc to the filename uploaded.
just wanted to check I'm interpreting the observed behaviour correctly as I couldn't find the relevant source code.
caveat : while I've checked the installed packages within the virtual env I'm using, I was a bit thrown by pip freeze not showing 'flask_uploads' as an installed package. It's remotely possible my 'import flask_uploads' is pulling flask_uploads from somewhere else (?)
pip freeze
.....
Flask==2.1.2
Flask-Reuploaded==1.2.0
Flask-WTF==1.0.1

otherwise. thanks for publishing the package. idk why more ppl aren't using it.

a) renaming
The relevant source code you were looking for is found here:
https://github.com/jugmac00/flask-reuploaded/blob/31055e625e1be0a1b7bcaadc1d0c81381a26afe1/src/flask_uploads/flask_uploads.py#L346-L365
b) Flask-Reuploaded vs flask_uploads

while I've checked the installed packages within the virtual env I'm using, I was a bit thrown by pip freeze not showing 'flask_uploads' as an installed package.

This is explained in the README at the front page of this repository.
https://github.com/jugmac00/flask-reuploaded
In short - this package here is a drop-in replacement for the unmaintained flask-uploads - drop-in in a sense, that you even do not have to change the import statement.
The "trick" here is... the package name is Flask-Reuploaded, but the folders are named src/flask_uploads.
c) usage

idk why more ppl aren't using it.

monthly downloads
| Flask-Reuploaded | 5,568 |
| flask-uploads | 15,050 |
source https://pepy.tech/
I am ok with the numbers. I am still a bit surprised that so many people download a completely outdated library - which even contains some security issues, but there is nothing I can do about it.
A general thought on the "low" download numbers... this flask-uploads was really needed many years ago, as Flask did not provide an easy way to handle file upload. Meanwhile it does - so many developers just use plain Flask. This is absolutely ok. I created Flask-Reuploaded especially to help those developers, who struggle to work with plain Flask, and who maybe followed one of the many, many flask-reuploaded tutorials out there, but then were frustrated as the package was broken.
P.S.: There is no need to cross-post here and on StackOverflow.