Request for Clarification on ACR Image Pulling in Docker Build Context Documentation

This is a report from the Azure Machine Learning support team.
In the Docker build context described in the following document, it is possible to specify a generic DockerHub repository or an MCR (Microsoft Continer Registry) image in the FROM command of the specified Dockerfile. However, if you specify an ACR (Azure Container Registry) image with the FROM command, the build will always fail due to an error in the internal authentication information.
-ref: Create an environment from a Docker build context
However, the documentation does not mention that ACR cannot be pulled using the Docker Build Context, so there is a concern that many customers may mistakenly believe that they can pull ACR using the Docker Build Therefore, there is a concern that many customers may mistakenly believe that they can pull ACRs using the Docker Build Context.
Therefore, we believe that the number of inquiries will be reduced if you add a clear statement to the effect that "ACRs cannot be pulled using Docker Build Context" in the documentation.
Thank you in advance for your consideration.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: a10c58c2-1767-778c-5591-8b6eb1e50969
Version Independent ID: ecc11aa4-56c9-d8b0-69c0-d9978de4adc5
Content: Manage Azure Machine Learning environments with the CLI & SDK (v2) - Azure Machine Learning
Content Source: articles/machine-learning/how-to-manage-environments-v2.md
Service: machine-learning
Sub-service: core
GitHub Login: @ositanachi
Microsoft Alias: osiotugo

@KazuOnuki
Thanks for your feedback! We will investigate and update as appropriate.

@ositanachi
could you please review this, add your comments and update as appropriate.

@KazuOnuki
I've delegated this to @ositanachi, a content author, to review and share their valuable insights.

@ositanachi We would appreciate it if you could confirm the contents.


Restore configurable tolerance

Now it has a bit different meaning then before: it allows to set
max CIEDE2000 value not treated as difference. It is now also
configurable on a 3 levels: global(config), suite and state.
Due to possibility of different suite to have different tolerance
API method buildDiff is now deprecated: it has access only to global
tolerance, so diff it produces might not show exactly what caused test
to fail. Method is kept for backward compatibility, but users of a
programmatic API now encouraged to use saveDiffTo method of
test result  (passed to reporter) instead.

@j0tunn @scf2k

:ok:


data exporting string

Note to self.
There is a string ambiguity which feel a bit off.
This concerns .data().add('key', 'i am a string') vs. .data().add('key', '"i am a string"') + other benefits.
Maybe passing in a string singleton (i.e. the entire key is simply a string) is a non-use case.
In which case:

the third parameter to add should be dropped as strings are assumed to contain evaluable javascript.
if someone actually wants to export a string directly onto a key, they will have to wrap it in quotes inside a string..
require#extensions tests need to be modified to fit this new behaviour

Else, maintain current behaviour:

third parameter has to be set to true to export an evaluable javascript string
strings can be passed in directly to export a 'singleton' string to a data key.

I think we should change to the former. Because Plugins looked better with it, and because plugins already use first anyway. It will lessen confusion.

1 and 2 makes it sensible.


more: reduce memory usage a bit

Work towards (but definitely does not close): https://github.com/uutils/coreutils/issues/6397
This just reduces the number of strings that are allocated. We're still at 5x the file though. Even though technically, we don't need to keep the file in memory at all.

Changes since last push:

Changed some u16 to usize to reduce conversions
Made the pattern search take &str instead of Option
Nothing to improve performance, but cleans up a bit.

Clippy is unhappy:

error: useless conversion to the same type: `usize`
   --> src/uu/more/src/more.rs:472:29
    |
472 |             .saturating_add(self.content_rows.into())
    |                             ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `self.content_rows`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
    = note: `-D clippy::useless-conversion` implied by `-D warnings`
    = help: to override `-D warnings` add `#[allow(clippy::useless_conversion)]`

error: useless conversion to the same type: `usize`
   --> src/uu/more/src/more.rs:488:58
    |
488 |         self.upper_mark = self.upper_mark.saturating_add(self.content_rows.into());
    |                                                          ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `self.content_rows`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion

error: useless conversion to the same type: `usize`
   --> src/uu/more/src/more.rs:527:49
    |
527 |             .min(self.upper_mark.saturating_add(self.content_rows.into()));
    |                                                 ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `self.content_rows`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion

@tertsdiepraam ping ? :)


universal_poker not registered in colabs

I simply concatenated "install_open_spiel.ipynb" and "test_universal_poker.ipynb" from open_spiel/open_spiel/colabs/ in Google Colab.
However I get the error:
"RuntimeError: Unknown game 'universal_poker'. Available games are:"

Hi @VogtAI, this is because that game requires an optional dependency (the ACPC code base) as a dependency which we have disabled by default.
To enable it, you will need to clone the ACPC code into the proper directory (see install.sh) and then prepend the build command with BUILD_WITH_ACPC="ON"

Thinking more: having the appropriate commands in the colab commented out would be good. That way people can enable poker just by deleting a few characters. I will suggest it to the team, will probably go into next Monday's update.

There seems to be a regression here as the same problem is happening again with the latest versions of "install_open_spiel.ipynb" and "test_universal_poker.ipynb". Also, it's not immediatly clear to new users how to build with BUILD_WITH_ACPC="ON".

Arghh... a test case I forgot to check, sorry!
The release did not include the optional dependencies for the pip package for some reason. My bad, sorry, will fix tonight.. should be done in 4-5 hours.

Hi @krfgbhoiaeuzr , ok it's fixed again... apologies!


Packages created from a monorepo are not properly analyzed

Describe the bug
I wanted to analyze https://pypi.org/project/rouge-score/ with OSSF Scorecard, which fails apparently with a Timeout, as the linked repo is a folder inside a monorepo. Trying to analyze the referenced GitHub URL fails.
Reproduction steps
Steps to reproduce the behavior:

Run scorecard --pypi rouge-score --show-details --checks Vulnerabilities
Scorecard tries to analyze the package, but never seems to return
Run scorecard --repo https://github.com/google-research/google-research/tree/master/rouge --show-details --checks Vulnerabilities
Scorecard fails with error during command execution: RunScorecard: repo unreachable: GET https://api.github.com/repos/google-research/google-research/tree/master/rouge: 404 Not Found []

Expected behavior
I would expect the analysis to analyze the provided path in the linked repo

Possibly related to #3464

Scorecard is intended to be run at the top level of the repository: e.g.
scorecard --repo https://github.com/google-research/google-research --show-details --checks Vulnerabilities

So monorepos have always been problematic for us as some of our checks must be at the repo level, while some can be handled at the subfolder level. For a huge repo like google-research/google-research, Scorecard will scan all of the dependencies, and it's either found an infinite loop in our vuln scanning library (google/osv-scanner), or there's just a lot of them to process.
If you're just wondering about vulns in rouge, it's one of the checks that can be done locally:
/tmp/google-research$ scorecard --local=rouge --checks Vulnerabilities --format json | jq
{
  "date": "2023-11-20T10:28:08-08:00",
  "repo": {
    "name": "file://rouge",
    "commit": "unknown"
  },
  "scorecard": {
    "version": "v4.13.0",
    "commit": "e1d3abc7fd2bdfe8819ac19b5c82815ea20890e6"
  },
  "score": 10,
  "checks": [
    {
      "details": null,
      "score": 10,
      "reason": "no vulnerabilities detected",
      "name": "Vulnerabilities",
      "documentation": {
        "url": "https://github.com/ossf/scorecard/blob/e1d3abc7fd2bdfe8819ac19b5c82815ea20890e6/docs/checks.md#vulnerabilities",
        "short": "Determines if the project has open, known unfixed vulnerabilities."
      }
    }
  ],
  "metadata": null
}

Hey, is  there any update regarding this bug ?

Hey, is there any update regarding this bug ?

I've tried the repo again, and it does finish (although it takes almost 7 minutes). I would say Scorecard is working as intended, it's just that the repo being analyzed is large.
If the desire is to support analyzing a subset of the project, I'd recommend the --local approach.

Yeah, can confirm this, needs some time, but comes up with results

Will open a new issue to clarify --repo flag and usage


Update example astrocyte analysis notebook

Make the notebook work with the latest NeuroM
Add astrocyte selection and download from NGV static server
Make figures larger

Codecov Report

Merging #959 (925371c) into master (830cd7d) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master      #959   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files           36        36
  Lines         2136      2136
=========================================
  Hits          2136      2136

you can use plotly if you want plots to be nicer, scalable, manipulable by user.

That would be really nice, do you have by any chance an example how this can be done?

a neighbor tutorial getting_started.ipynb contains examples of plotly graphics in the beginning.

Also would be good to rename Neuron id to Astrocyte id in "Morphology Analysis" paragraph.

Thank you, Aleksei,
Indeed, plotly works better for this case, I've also renamed neuron to astrocyte in the morphology analysis paragraph.
Anything else of concern?

Thanks!


deviceNotReady error : "Registration failed"

I have done server setup in php. But getting "Registration failed" error in 'deviceNotReady" listener.
This is a function I am calling on click of number:
initTwilio = async () => {
	const token = await this.getAuthToken();
	if (Platform.OS === 'android') {
		await this.getMicrophonePermission();
	}
	const success = await TwilioVoice.initWithToken(token);
	if (success.initialized) {
		TwilioVoice.addEventListener('deviceReady', () => {
			this.setState({ twilioInited: true });
		});
		TwilioVoice.addEventListener('deviceNotReady', function (data) {
			console.log('data', data) // getting error here
		});
		if (Platform.OS === 'ios') { //required for ios
			TwilioVoice.configureCallKit({
				appName: 'ReactNativeTwilioExampleApp',
			});
		}
	}
};

getAuthToken = () => {
	return fetch('https://myurl/accessToken.php', {
		method: 'get',
	})
	.then(response => response.text())
	.catch((error) => console.error(error));
}

Please help I am new to this.

You probably made a typo when setting up the twillo key on the backend. This particular happened to me when I couldn't generate the API secret and API secret key well. I hope it helps

Hi, since a long time has passed I will be closing this issue. Read our repository update in #158. I invite you to reopen this issue when you still have problems so we can debug the problems together.


Web Only Mode on Mac

I'm trying to run fast-data-dev on  MAC:
docker run --rm -it --net=host -e WEB_ONLY=1 -e DEBUG=1 landoop/fast-data-dev.
In docs told: "This is a special mode only for Linux hosts." - Is it possible to run fast-data-dev application on Mac? I'm running locally (default) installation (Confluent) platform (zookeeper/kafka/schema-registry/kafka-rest. Main reason - application couldn't connect to running locally components.
My configuration: Mac, docker (version 17.03.1-ce, build c6d412e, not docker-machine), Java 8.

Unfortunately fast-data-dev can't provide this functionality.
For this purpose you will find more useful our dedicated, lightweight *-UI docker images:

kafka-topics-ui
schema-registry-ui
kafka-connect-ui

Keep in mind that you either need to explicit enable CORS on your confluent platform components, or use the proxy mode of the images.

Thanks.


Remove figlet

This is a dummy project which doesn't code code that is doing something useful.

Hi @fabaff any reason why this package needs to be removed? Removing this package will impact the interface.

figlet is not used and doesn't contain any functionality.
pyfiglet is used.

@vasantchinnipilli please merge it.


Update wharfie usage in windows code path

Proposed Changes
Fix https://github.com/k3s-io/k3s/pull/4575 for windows. We don't test or build any of the Windows code that's present in k3s until it's pulled through into RKE2, so this was missed.
Types of Changes
bugfix
Verification
update k3s in rke2; notice build failure.
Linked Issues

#4646

User-Facing Change
Further Comments

CI failed due to disk space issues; merging.

[PARALLEL-postgres]   Normal   NodeHasDiskPressure      89s                  kubelet     Node d0e6e41cc174 status is now: NodeHasDiskPressure


B 18633 actual move date not found frontend integration

B-18633
Summary
As a customer uploading documents, future dates should be greyed out when setting the departure date.
Verification Steps for Reviewers
These are to be checked by a reviewer.

[ ] Has the branch been pulled in and checked out?
[ ] Have the BL acceptance criteria been met for this change?
[ ] Was the CircleCI build successful?
[ ] Has the code been reviewed from a standards and best practices point of view?

How to test

Create a PPM move
As SC edit and submit move
As customer click Upload documents and select calendar under "Departure date", and verify all future dates are greyed out

Screenshots

Warnings

:warning:
This PR does not include changes to unit tests, even though it affects app code.

  Generated by :no_entry_sign: dangerJS against 3c54d85a8c30bb079344d8e0a6e94f24649fc4ef


Why is cmd/exec being used to run Docker?

Instead of the Docker client? Just curious.

see https://github.com/ory-am/dockertest/issues/11

hey, this was fixed now, check out #66

@arekkas Awesome! Thanks for keeping me in mind!

you're welcome. Sorry that it took so long

No problem at all. That PR looks squeaky clean. Good work!

Also, most authors/maintainers don't think to come back and comment on old issues letting them know their original problem/question has been solved. Kudos to you on that.

Thanks!


Allows specification of epsilon

… while retaining original defaults and API for compatibility (unless a dependency relies on the function.length)
Helps fix https://github.com/plotly/plotly.js/issues/552 (see images for visible effects)

Thanks!


Ingest the latest pulumi-terraform.

These changes bring in support for first-class provider definitions in
Node.JS.

Can we add a test? Ideally of multi-region deployment?

Already working on it.


Add ArangoDB snapshot store

@codeliner Can you enable TravisCI and the other tools for this package, please?
Here is an example for docker-compose.yml
version: '2'
services:
  php:
    image: prooph/php:7.1-cli-xdebug
    volumes:
      - "./:/app"

  arangodb:
    image: arangodb:3.1.4
    ports:
      - 8529:8529
    environment:
      - ARANGO_NO_AUTH=1

Then change arangodb_host in phpunit.xml.dist to tcp://arangodb:8529 and run:
$ docker-compose up -d --no-recreate
$ docker-compose run --rm -e PHP_IDE_CONFIG="serverName=application" php php -d xdebug.remote_autostart=1 -d xdebug.remote_host=<IP_ADDRESS> vendor/bin/phpunit

I added coveralls.
Having problems with packagist login right now (@codeliner?)
Travis-CI has some problems currenty, prooph is missing from my organizations (but it's in github).

Packagist is created:
https://packagist.org/packages/prooph/arangodb-snapshot-store
Travis-CI, too.

I added composer.json manually, the PR needs to be rebased.

This error makes no sense to me, because I don't see the failure. :thinking:
1) ProophTest\ArangoDB\SnapshotStore\ArangoDBSnapshotStoreTest::it_saves_and_reads
Class __PHP_Incomplete_Class has no unserializer

@sandrokeil You're right. We would need to add all classes involved in the aggregate root, which is completely unknown to the snapshot-store. So we have to remove it. For security we could only encrypt / decrypt the serialized string, so nobody is able to manipulate the data, but I think this is too much and costs also performance. So let's remove allowed_classes.

Second: I think we should also remove JsonSerializable, this would either require all uses value objects to also implement this or having a complex serialization method in the aggregate root PLUS it's dangerous to have a public static fromArray-method, as it can be used to create aggregate roots in invalid state.

@prolic I've updated the code. Here is a slide about PHP Object Injection (Chapter 5).
This is strange, all tests are green. :D Locally I get an error in it_saves_and_reads that the objects are not equal. Must be a PHP in Docker Bug or mabye a PHPUnit Bug.

Changes Unknown when pulling 97e4c9b4b0972143dfb39a3033e78d9927b4273b on sandrokeil:master into ** on prooph:master**.

Any ideas why the build times out?

Changes Unknown when pulling 92bef3c0c110d95310ec4d7acb706076bcc19cf8 on sandrokeil:master into ** on prooph:master**.

Changes Unknown when pulling 92bef3c0c110d95310ec4d7acb706076bcc19cf8 on sandrokeil:master into ** on prooph:master**.

Changes Unknown when pulling 820316000fb40c54b1d823b9c0cd67dde8122b16 on sandrokeil:master into ** on prooph:master**.

Changes Unknown when pulling 820316000fb40c54b1d823b9c0cd67dde8122b16 on sandrokeil:master into ** on prooph:master**.

Changes Unknown when pulling 4ed5b22472eb6d5769ca803b5aaa33f280e63876 on sandrokeil:master into ** on prooph:master**.

Changes Unknown when pulling 02e221b4b132d4014b03763681e4c939db230f2f on sandrokeil:master into ** on prooph:master**.

Changes Unknown when pulling 02e221b4b132d4014b03763681e4c939db230f2f on sandrokeil:master into ** on prooph:master**.

@prolic I've removed the aggregate_type from query, but it was stolen from PDO Snapshotter. So we should it change too.

Changes Unknown when pulling b3f97d9c653949530f5b601f02422d07ce096f84 on sandrokeil:master into ** on prooph:master**.

build still failing... I'll install arangodb on my machine and check...

Yes, Travis can not shutdown. Still trying some stuff to solve this.

Changes Unknown when pulling 2a565a1e5e14c64f3a88f80294113dea6328be30 on sandrokeil:master into ** on prooph:master**.

@sandrokeil a suggestion: check other github repositories, where arangodb is tested (maybe event arangodb build itself) - perhaps there you'll find something.
Testing locally - all runs, but I got a lot of debug output. Seems like you did this within TestUtil.php - for travis testing I guess?

@prolic Yes, the debug logs are for the travis issue. I will remove it wen I solved the problem.

Changes Unknown when pulling bd73997bcbc030877f48b94600de0cc31111026e on sandrokeil:master into ** on prooph:master**.

Changes Unknown when pulling e8f9badaab2bf8bc44129f61ffeb3101cadb9766 on sandrokeil:master into ** on prooph:master**.

Changes Unknown when pulling 611ce25a55cb3c29159eed7e2cb949797b00d6c5 on sandrokeil:master into ** on prooph:master**.

Changes Unknown when pulling f77d3ed2fcbe130eb1338283752a48a3f4072650 on sandrokeil:master into ** on prooph:master**.

@prolic Ready to merge :tada:

@prolic Good catch, but there exists no ArangoDB 3.2 version.

Changes Unknown when pulling 9fda8c78c9b6e1701ec6de9f6e4e468038c80b69 on sandrokeil:master into ** on prooph:master**.


@hidden implementation of non-hidden overloads result in documentation that marks the function as hidden

Search terms
hidden, overload
Actual Behavior
When the implementation of overloads is marked with @hidden while the overloads aren't, the generated documentation of the function is also marked marked with Hidden.
Reproduction
Save the following file to a.ts.
/**
 * @param a - Number param.
 */
export function f(a: number): void;

/**
 * @param a - String param.
 */
export function f(a: string): void;

/** @hidden */
export function f(a: string | number): void {
  console.log(a);
}

Run typedoc a.ts. Check out the output.

Expected Behavior
Function f above shouldn't be marked as Hidden in the generated doc.
Environment

Typedoc version: 0.26.3
TypeScript version:  5.5.3
Node.js version: 22.4.1

That should have entirely removed the function from the documentation... weird.

How should we exclude the implementation prototype from the doc then? They are often only used for implementation and not for users to read.

nvm, the implementation is undocumented by default.


Can't add LiveCharts to my toolbox

Few months ago, I tried to add livecharts winforms to my toolbox with no success for a project. I just retried it today and still same issue "Can't add winform controls to the Toolbox"... I have visual studio 2017 community edition.
Could you solve this issue? Thank you in advance.

I found a solution. It may help other person having this issue. Instead of following the tutorial of Livecharts to add the winforms components, just drag and drop the dll file onto the toolbox :-)


[Enhancement] improve the observability of tablets and fix some metric bugs

What type of PR is this:

[ ] BugFix
[x] Feature
[x] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Which issues of this PR fixes:

remove useless configs
add a HTTP API be_ip:port//api/compaction/running to query the tablets that are being or will be merged
provide more tablet details for HTTP API `be_ip:port//api/compaction/show?tablet_id=xxx
reformat the output of HTTP API to stardard json
provide more tablet details and reformat the output for ls and get_meta_stats operation of meta_tool

curl http://<IP_ADDRESS>:8048/api/compaction/running
{
    "max_task_num": 2,
    "base_task_num": 2,
    "cumulative_task_num": 0,
    "running_task_num": 2,
    "base_task_num_detail": [
        {
            "path": "/root/work/Starrocks-20230509/be/storage",
            "base_task_num": 2
        }
    ],
    "cumulative_task_num_detail": [],
    "tablet_num": 2,
    "running_tablet_list": [
        18029,
        18027
    ],
    "candidate_tablet_list": [
        18031,
        18033
    ]
}

curl http://<IP_ADDRESS>:8048/api/compaction/show?tablet_id=18029
{
    "compaction_detail": {
        "enable_compaction": true,
        "compaction_status": "RUNNING",
        "task_id": 6,
        "elapsed_time": 128,
        "score": 20.733333333333336,
        "type": "base",
        "rowsets_count": 5,
        "input_rowset_details": [
            {
                "rowset_id": "0200000000000012704a4a7cb811c67db7cd75a498247a8b",
                "version": "0-5"
            },
            {
                "rowset_id": "0200000000000014704a4a7cb811c67db7cd75a498247a8b",
                "version": "6-6"
            },
            {
                "rowset_id": "0200000000000018704a4a7cb811c67db7cd75a498247a8b",
                "version": "7-7"
            },
            {
                "rowset_id": "020000000000001c704a4a7cb811c67db7cd75a498247a8b",
                "version": "8-8"
            },
            {
                "rowset_id": "0200000000000020704a4a7cb811c67db7cd75a498247a8b",
                "version": "9-9"
            }
        ]
    },
    "cumulative_point": -1,
    "last_cumulative_failure_time": "1970-01-01 08:00:00.000",
    "last_base_failure_time": "1970-01-01 08:00:00.000",
    "last_cumulative_success_time": "1970-01-01 08:00:00.000",
    "last_base_success_time": "2023-05-09 11:20:47.471",
    "rowsets_count": 5,
    "rowset_details": [
        {
            "rowset_id": "0200000000000012704a4a7cb811c67db7cd75a498247a8b",
            "version": "0-5",
            "num_segments": 1,
            "type": "DATA",
            "overlap": "NONOVERLAPPING",
            "rowset_size": 480
        },
        {
            "rowset_id": "0200000000000014704a4a7cb811c67db7cd75a498247a8b",
            "version": "6-6",
            "num_segments": 1,
            "type": "DATA",
            "overlap": "NONOVERLAPPING",
            "rowset_size": 464
        },
        {
            "rowset_id": "0200000000000018704a4a7cb811c67db7cd75a498247a8b",
            "version": "7-7",
            "num_segments": 1,
            "type": "DATA",
            "overlap": "NONOVERLAPPING",
            "rowset_size": 464
        },
        {
            "rowset_id": "020000000000001c704a4a7cb811c67db7cd75a498247a8b",
            "version": "8-8",
            "num_segments": 1,
            "type": "DATA",
            "overlap": "NONOVERLAPPING",
            "rowset_size": 464
        },
        {
            "rowset_id": "0200000000000020704a4a7cb811c67db7cd75a498247a8b",
            "version": "9-9",
            "num_segments": 1,
            "type": "DATA",
            "overlap": "NONOVERLAPPING",
            "rowset_size": 464
        }
    ],
    "stale_version_path": [
        {
            "path_id": "1",
            "last_create_time": "2023-05-09 11:20:16 +0800",
            "path_list": "[0-4]->[5-5]"
        }
    ]
}

Checklist:

[ ] I have added test cases for my bug fix or my new feature
[ ] This pr will affect users' behaviors
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

[ ] I have checked the version labels which the pr will be auto backported to target branch

[ ] 3.0
[ ] 2.5
[ ] 2.4
[ ] 2.3

[FE PR Coverage Check]
:heart_eyes: pass : 0 / 0 (0%)


Quicksilver retains focus after triggering different app

For questions or tech support, please start with the users’ group. If you know the problem is in Quicksilver itself, report it here.
Describe the bug
I'm on an M1 Mac, macOS Monterey 12.1
Quicksilver is configured to not appear in Dock, but in the menu bar:

If I trigger even something simple like launching Safari, Quicksilver seems to retain focus, so e.g. moving between tabs in Safari using shit-cmd-arrow doesn't work. You need to alt-tab Safari into the foreground before the app really has focus.
To Reproduce
Steps to reproduce the behavior:

Have Safari open with a number of tabs
Use Quicksilver to open Safari
Use keyboard to navigate between Safari tabs - nothing happens (aside from the "boink" noise)
Alt-tab away from and then back to Safari - tab navigation now works

Expected behavior
When Quicksilver launches or opens an application, that application has keyboard focus
What version of macOS?
Monterey 12.1 on M1 Mac
What version of Quicksilver?
1.6.1

Trying to reproduce, also on an M1 MBP, 12.2, 1.6.1 -- are you sure this is a Quicksilver problem and not just Safari? Full-screen or not (or both)?
For example, if I open two tabs in Safari, neither of which has a search box:

https://qsapp.com
https://n8henrie.com

I can switch back to Firefox, type into this form, use QS to go back to Safari, and e.g. kbdshift<- switches tabs as expected.
However, if I open tabs that include a focus-stealing search box:

https://www.google.com
https://www.yahoo.com

Either of these steals my focus (sometimes?) and kbdshift<- no longer works.

Ah, thanks for the those tests. It's helped me narrow the problem down:

Give Safari focus (with your two non-focus stealing tab; https://qsapp.com/ and https://n8henrie.com/)
Trigger Quicksilver
Press escape to cancel the bezel

Safari looks like it has focus, but it does't - you still have to alt-tab away to another app and back again, before it does.

Safari looks like it has focus, but it does't

Interesting. In that case, I can't reproduce.

I have QS in the menu bar enabled
I'm typing this into Firefox
QS -> Safari -> Open
I can cmd-shift-arrow between tabs as expected, immediately, without having to click anything to give focus to Safari.
This is true in both full-screen and non-fullscreen

Try this:

Have Firefox focused
Trigger QS
Press escape
Try and use your keyboard to navigate tabs in Firefox

The problem seems to be dropping back to the app that had focus before QS is cancelled

I also tried reproducing this, but cannot find the issue. @jaygooby - can you please try and debug further. Also, sending screenshots of each of your preference panes may help
https://user-images.githubusercontent.com/150431/152452886-2d0cf088-6b38-4d59-8b28-7512b88cb417.mov

Weird. Thanks. I wondered if it might be due to another program (had iTerm and LastPass both in the menu bar), but I've quit everything and still no joy. This screencast uses the mic, so you can hear the boink when I try and switch between the tabs
https://user-images.githubusercontent.com/64270/152575205-337e54a1-cb62-4def-ac0b-744b1a258229.mov

Here are the grabs from the pref panes:

Try this:
Have Firefox focused
Trigger QS
Press escape
Try and use your keyboard to navigate tabs in Firefox

@jaygooby this works flawlessly for me, with and without fullscreen, in the menu bar. Even tried restarting quicksilver to see if that made a difference.

Are you running an ARM64 build of QS? Or still on x86_64? I wonder if that could make a difference (I'm on the former).

Can you try deselecting "Use superfluous visual effects" and "focus action
when showing results" one by one to see if that has any effect?
On Saturday, 5 February 2022, Nathan Henrie @.***>
wrote:

Are you running an ARM64 build of QS? Or still on x86_64? I wonder if that
could make a difference (I'm on the former).
—
Reply to this email directly, view it on GitHub
https://github.com/quicksilver/Quicksilver/issues/2596#issuecomment-1030233882,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AABEXH6Q5UQ2DXUVWHTEJD3UZQJUBANCNFSM5NOWVQFQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you commented.Message ID:
@.***>

Sounds similar to #1351, but I can’t reproduce it as described either. Only setting that’s likely to matter here is “Reopening the current application”, but I have the same value as shown in the screenshot.

@n8henrie it's a brew --cask installed version. Interesting, I checked in Activity Monitor and it's showing as intel. This is the current cask recipe: https://github.com/Homebrew/homebrew-cask/blob/HEAD/Casks/quicksilver.rb

@pjrobertson - tried both of those, one at a time, and restarted after each, but no joy

I'm going to close this now as I can no longer reproduce either. There have been a couple of Quicksilver and plugin updates since I opened the issue. I'm now on QS 2.1.0 (4032).
Sorry to not be more help :(

@jaygooby thinking back, I may have run into this a time or two in the interim -- if I remember correctly, it was when trying to use the Type Text action (and/or Paste as Plain Text), which sadly hadn't worked for me for months, and I use heavily (mostly to get around password forms that have pasting blocked, since I use a password manager). Whenever I tried to use this action it would fail, and around that time I would often end up in a similar situation to what you describe -- no app would seem to have focus.
Anyway, last week I finally figured out that there was an issue in System Preferences -> Security and Privacy -> Accessibility (something along those lines); removing the entry for Quicksilver and then invoking Type Text caused the accessibility permissions prompt to reappear, and after re-enabling it for QS these actions now work perfectly, and I can't reproduce the losing focus bug.
If it comes back, may be something to think about.


Query diff error when operation has variables

It seems query diff is not working in some cases when original query use variables.
I have an article container component which retrieve its data and its source from two distinct root queries.
The first time the component is mounted, everything works (the full query is sent to the server). But the second time with a different article and the same source the diff is not working.
Component connection :
export default connect({
  mapQueriesToProps: ({ ownProps }) => ({
    data: {
      query: gql`
        query articleWithSource($articleMid: MID!, $sourceMid: MID!) {
          article: article(mid: $articleMid) {
            rubric
            pubDate
            title
            subtitle
            byline
            abstract
            image {
              url
              width
              height
            }
          }
          source(mid: $sourceMid) {
            name
            image {
              url
              width
              height
            }
          }
        }
      `,
      variables: {
        articleMid: ownProps.params.articleMid,
        sourceMid: ownProps.sourceMid,
      },
    },
  }),
})(withTheme(ArticleContainer));

Generated diff query for the second article :

query articleWithSource($articleMid: MID!, $sourceMid: MID!) {
  article: article(mid: $articleMid) {
    rubric
    pubDate
    title
    subtitle
    byline
    abstract
    image {
      url
      width
      height
    }
  }
}

I get from the server :
{
  "errors": [
    {
      "message": "Variable \"$sourceMid\" is never used in operation \"articleWithSource\".",
      "locations": [
        {
          "line": 1,
          "column": 44
        }
      ]
    }
  ]
}

Sounds like we might need to avoid sending variables that are not actually included in the query!

Hmm, this requires additional logic to manipulate the AST to remove variable definitions, scan for what variables are being used, etc.
Would it maybe be better to just get rid of this query diffing feature? Then the only difference is you just put it in as two separate queries if you want them to be cached independently. What do you think? Do you feel like you get a lot of value out of this feature?

I split it in two queries, this is a safe workaround, you're right.
But as it return an unexpected result, i think this is a good idea to disable query diffing for theses queries.


Fix compile errors in examples and docs in valuable crate

How to reproduce the errors:
$ git clone https://github.com/tokio-rs/valuable.git
Cloning into 'valuable'...
remote: Enumerating objects: 1365, done.
remote: Counting objects: 100% (406/406), done.
remote: Compressing objects: 100% (145/145), done.
remote: Total 1365 (delta 339), reused 262 (delta 259), pack-reused 959
Receiving objects: 100% (1365/1365), 295.04 KiB | 715.00 KiB/s, done.
Resolving deltas: 100% (834/834), done.
$ cd valuable/valuable
$ cargo test

Example error:
error: cannot find derive macro `Valuable` in this scope
 --> valuable/examples/derive.rs:7:10
  |
7 | #[derive(Valuable)]
  |          ^^^^^^^^
  |
note: `Valuable` is imported here, but it is only a trait, without a derive macro
 --> valuable/examples/derive.rs:1:5
  |
1 | use valuable::Valuable;
  |     ^^^^^^^^^^^^^^^^^^

Those are due to that the feature valuable-derive might not have been enabled, and are fixed by adding a #[cfg(not(feature = "valuable-derive",))] around them.

Realized that this was neither a complete fix nor a good enough one, closing it for now.


ARROW-10124: [C++] Don't restrict permissions when creating files

The permissions of a file created by Arrow should simply follow the current umask.

May want to add a simple test for this.


[WIP] Add ordering parameter to GET /v0/orders

Currently the results from /v0/orders are returned unordered. Given a sufficient number of orders in a relayers orderbook, it will become expensive for clients to request all orders for a given query. In addition, most clients will not be equally interested in all orders.
Some client examples:

A dApp wants to fetch the cheapest order for it's user to acquire WETH for MLN. In this case, the dApp would like to request all orders where makerToken is WETH, takerToken is MLN. It would further want the orders returned in ascending order of the price of WETH in terms on MLN by setting tokenAscByPrice to WETH. The dApp can then simply take the first few orders that have sufficient liquidity for the desired trade, and it is guaranteed the best price.

A trading bot wants to query the depth of a particular orderbook in order to inform it's trading decisions. The bot therefore fetches all trades with parameters tokenA equal MLN and tokenB equal WETH, thus fetching all orders involving this trading pair. In order to define which orders are bids and which asks, as well as return the orders ordered by price, it can set tokenAscByPrice to the desired baseToken (as opposed to quoteToken). Given that this is an efficient market, this query will return the orders from the lowest bid to the highest ask. In order to find the "market price" the bot would simply need to scan the orders to find where the bids meet the asks.

Some way of ordering the orders returned to clients will be necessary for them to build performant applications. Since a main purpose of the Standard Relayer API is sharing liquidity, we should design it such that it is easy for clients to fetch the most competitive orders for a given token pair.
My proposed solution involves letting them elect a baseToken and have the orders returned sorted by the price of this baseToken in terms of a quoteToken. The orders are always returned in ascending order because if one wanted the reverse, one can simply flip the baseToken for the quoteToken.
I'm open to suggestions and alternative solutions but thought it would make sense to start the discussion about the ordering of orders with a proposal.

I like this proposal as a starting point, but I dislike the parameter name tokenAscByPrice. An order's value is made up of 3 components: price, fee, and expiration. The most frequently desired sorting pattern will probably be orders sorted by ascending price, ascending fees, and ascending expiration. Considering all of these factors, I think a more appropriate name would be something like ascByBaseToken or ascByQuoteToken.
The problem with this is that it assumes that price is more important than fees and that fees are more important than expiration. Different models might assign higher values to any of these 3 factors. At the very least, we could probably use something like:
ascBy: {
    quoteToken: makerTokenAddress | takerTokenAddress
    order: [..., ..., ...] // default = price, fee, expiration
}

For anything more complex, it is probably acceptable to leave the additional sorting to the client.

As per our discussion offline, we decided on:
ascByBaseToken: {$ref: '/Address'},

Where baseToken refers to the token set as the denominator when calculating the effective "price" of the baseToken in terms of a quoteToken (naturally the other token of the order).
price = quoteToken / baseToken

Example:
const order = {
  makerTokenAddress: '0x323b5d4c32345ced77393b3530b1eed0f346429d', // MLN
  makerTokenAmount: '20000000000000000',
  takerTokenAddress: '0xef7fff64389b814a946f3e92105513705ca6b990', // WETH
  takerTokenAmount: '10000000000000000',
  ...
}

If the client wishes to retrieve prices in ascending order of MLN denominated in WETH, he wishes to elect WETH as the quoteToken and MLN as the baseToken.
WETH/MLN 0.5

Meaning you'd receive 1 MLN in return for 0.5 WETH. The price of 1 MLN is therefore 0.5 WETH. The user would therefore set:
ascByBaseToken: '0x323b5d4c32345ced77393b3530b1eed0f346429d', // MLN

And would receive prices of MLN denominated in WETH in ascending order.
Although fee and expiration ordering will matter for certain use-cases, the initial version of this API will stipulate that orders be returned in ascending price of the specified baseToken, followed by ascending order of fees, and lastly ascending order of expirations. Clients requiring a different ordering of fees/expiration will need to perform further sorting after retrieving orders from the relayer.


[Website] [$data property missing from the Adaptive Card Schema Explorer docs]

When creating an adaptive card Adaptive Card Designer, it is possible to set the data context for any element on the card.  This gets added to the json template as the property $data.  The $data property is not mentioned in the linked schema document.

URL: https://adaptivecards.io/explorer/AdaptiveCard.html

This is causing confusion in the schema as well since the $data  will be decalred as unavailable even tho it is.

Adding to the $data property. $when property is causing the same warning, for the same reason, as it is not included in the AdaptiveCard once is rendered and it is causing confusion. Does the AdaptiveCard template mentioned by @jwoo-msft sound viable to solve this issue?


the linear.x and angular.z too big in HuRoN dataset

Dear author,
Thanks for your great work , there is a problem with the linear.x and angular.z too big  in HuRoN dataset when we play the bage  eg [4.267790794372559, -8.381914138793945]
[0.9343571066856384, 7.951975345611572] The value is bigger than I know
cmd_vel = odom.twist.twist
linear_x = cmd_vel.linear.x
angular_z = cmd_vel.angular.z This is my code to read the data in the bag

HuRoN dataset contains the wheeled odometry. Not the velocity command, since we do not use the velocity commands in SACSoN training.
If you need the velocity commands, you need to (approximately) calculate it from the odometry.


[WebSub] Introduce two clients instead of one.

Description:
Currently, we have a single client to interact with the hub - for topic registration, publishing, subscribing, etc.
However this does not make sense, since a publisher is almost never a subscriber at the same hub and vice versa. Would be better to split this into two.

Done with https://github.com/ballerina-platform/ballerina-lang/pull/19599.


POC on how the enterprise profile would look like

What it does (currently only for vehicle routing)

Adds a maven profile "enterprise" to add the repo + deps
Adds a quarkus profile "enterprise" to activate multithreaded solving
Cleans up the application.properties.
-- Remove the whole CORS stuff that was needed for the showcase which has been removed
-- Remove other stuff that shouldn't be in there.
-- Use DEBUG logging by default like in the other quickstarts.

Requirements to make this a real PR:

Apply the maven profile and quarkus profile on all quickstarts
clean up the application.properties
add it to the readme
CI work? => finally quickstarts will test enteprise too :)

The SDK work will affect the readme further, but let's get this one merged first.

Replaced by https://github.com/TimefoldAI/timefold-quickstarts/pull/476


Result fields are misaligned when using subqueries on presto 330

--- this is a fact table
CREATE TABLE kudu.test.test_fact (
id varchar WITH ( primary_key = true ),
grade varchar WITH ( primary_key = true ),
score varchar WITH ( nullable = true ),
name varchar WITH ( nullable = true ),
age varchar WITH ( nullable = true ),
school varchar WITH ( nullable = true ),
teacher varchar WITH ( nullable = true ),
update_time varchar WITH ( nullable = true )
)
WITH (
number_of_replicas = 3,
partition_by_hash_buckets = 20,
partition_by_hash_columns = ARRAY['grade','id']
);
-- insert data
insert into kudu.test.test_fact values('AA1','a1','99.0','stu1','12','my school','hari','2018-01-18 14:00:53');
insert into kudu.test.test_fact values('AA2','a1','98.5','stu1','13','my school','hari','2018-01-18 14:00:53');
insert into kudu.test.test_fact values('AA3','a2','96.5','stu1','14','my school','hari','2018-01-18 14:00:53');
insert into kudu.test.test_fact values('AA4','a2','99.1','stu1','11','my school','hari','2018-01-18 14:00:53');
insert into kudu.test.test_fact values('AA5','a4','88.5','stu1','12','my school','hari','2018-01-18 14:00:53');
insert into kudu.test.test_fact values('AA6','a1','70.5','stu1','13','my school','hari','2018-01-18 14:00:53');
insert into kudu.test.test_fact values('AA7','a4','90.5','stu1','10','my school','hari','2018-01-18 14:00:53');
-- The result is a field mismatch.Notice the teacher field in the query result,the value of the school field is displayed.
select t1.id as id ,t1.name as name,t1.score as score,t1.age as age,t1.teacher as teacher,t1.update_time as update_time
from kudu.test.test_fact t1
where (t1.grade = 'a1') and t1.age in (select age from kudu.test.test_fact) and t1.name is not null;
-- When the school was checked out, the result showed normal, no dislocation.
select t1.id as id ,t1.name as name,t1.score as score,t1.age as age,t1.school as school,t1.teacher as teacher,t1.update_time as update_time
from kudu.test.test_fact t1
where (t1.grade = 'a1') and t1.age in (select age from kudu.test.test_fact) and t1.name is not null;

This is a problem at kudu

Also in the kudu release, presto 324 does not have this problem.


RequestBodyParserMiddleware should repect MAX_FILE_SIZE post value

The MAX_FILE_SIZE post value (cast insensitive) can be used to limit the maximum size for each following file upload. This is PHP's default behavior and it probably makes sense to mimic this here.
See also https://stackoverflow.com/questions/1381364/max-file-size-in-php-whats-the-point and https://github.com/php/php-src/blob/1c295d4a9ac78fcc2f77d6695987598bb7abcb83/main/rfc1867.c#L1053
This should not be confused with #257. In particular, this value can easily be spoofed and we have to ensure that this does not allow clients to bypass the server limits.

Up at #261


Method swizzling is not atomic

Method swizzling is not atomic

Method swizzling is not atomic

Maybe dispatch_once is better？


Start the v3 documentation

Thanks a lot!!! messages/conversations endpoints should require no payload but it'd be super useful if you could look into sending pics or setting your own and especially creating the GCM token with google if possible so I can start implementing without setting up a phone and MITM setup.

I did look at how the GCM token is created.  It involves trading a device ID that was presumably created earlier when the OS was installed... I don't feel too comfortable about faking that.  I'm curious what happens on iOS.  Google does have a GCM SDK for iOS, but it obviously isn't native, so maybe it's less integrated?
On a related note, I noticed that v2 and v3 session IDs are interchangeable.  So you can log in with a v2 flow, and start making v3 API calls.  That makes migration easier.
Also, do you have anything set up to MITM the XMPP side of things?  I have less experience there.

Thanks a lot for the session ID tip. There must be a request to some Google/ex-Firebase server; this connection might use proper certificate pinning though :/. Nope, we could Wireshark/TShark but XMPP hasn't changed much and you can see the other side in the terminal if you speak between Fuckr and Grindr. Can you just add chat/profile pics or should I merge and complete?

Google doesn't use any pinning, as far as I can tell.  I added a section on photo upload.

Thanks 👍, I'll assume chat pics are the same endpoint. Well all we'll need is Grindr's app key which is probably in all GCM requests.

Chat pics are already documented in there :)

Any idea what is kind of token is being generated for iPhone users or do they use GCM for both?

@ZeroFeetAway did you figure it out?

@JKalash, nope. I still don't know what request is being made in order to obtain the token for iPhone users. It looks much different than the GCM token last I looked.

@ZeroFeetAway Yeah. The token being used is extremely short. Digits only. Makes me wonder what it is.


split checksums and checksum publishing

It seems there is a difference in uploading a file to artifactory with providing checksums and doing a checksum deploy.
A checksum deploy is quering artifactory to see if there already is a file with the same checksum. From the Artifactory Rest API:

If Artifactory already contains a user readable artifact with the same checksum the artifact content is >copied over to the new location and return a response without requiring content transfer. Otherwise, a> 404 error is returned to indicate that content upload is expected in order to deploy the artifact.

Deploying with checksum is providing the checksums so Artifactory can see if they are the same as provided by the client after upload.
If you don't provide these Artifactory will say something like this:

Client did not publish a checksum value.
I>f you trust the uploaded artifact you can accept the actual checksum by clicking the 'Fix Checksum' >button.

I split the headers so $checksum only does X-Checksum-Deploy.
I catch the webrequest to see if it returns a 404 and set X-Checksum-Deploy to false and continue with the content upload.
This is the way Artifactory intents it and what the cli actually does.
https://www.jfrog.com/blog/artifactory-command-line-interface-cli-pure-and-simple/
@devblackops @TerrapinStation (since I know you use Artifactory deployments)

Awesome work! And thank you for keeping the existing Checksum parameter so we don't have to refactor :smile:

Awesome, thanks @Plork, merging!


Adding missing static information/data

@tbergq Thank you for the thorough review! Should be better now


Updating RabbitMQ.Client to 6.0.0-rc1

In the new RabbitMQ.Client version, there is no public constructor for the BasicProperties class.

Update to a stable 6.0.0 client


infinite configuring

I'm using "react-native": "0.71.1", and "react-native-mmkv": "^2.6.1"
When I try to run npm run android there will be an infinite configuring

It's installing the NDK, this might take a while..


Add support for Alternate links <link rel="alternate"  ... />

Hi,
This PR adds support for alternate links:
new SEOData(
  alternates: [
    new AlternateTag(
      hreflang: 'en',
      href: "https://example.com/en",
    ),
    new AlternateTag(
      hreflang: 'fr',
      href: "https://example.com/fr",
    ),
  ],
)

<link rel="alternate" hreflang="en" href="https://example.com/en" />
<link rel="alternate" hreflang="fr" href="https://example.com/fr" />

It is super useful for multilingual apps or blog.
The PR includes tests and a small documentation update.

Thank you! Looks good, will review and merge both PRs later this week! 👍

Very nice implementation, thanks!


Add Test Coverage on Frontend Admin Pages

Description
There is no test coverage for the frontend admin pages in frontend/src/app/admin.  Add some tests to ensure the pages load and function.  These are contributing to failure to meet our test coverage percentage on sonar.
https://sonarcloud.io/dashboard?id=CDCgov_prime-data-input-client

Closing this ticket; will break into smaller tickets for the specific pages/forms that need to be updated.

Tests have been added for this folder over time; our test coverage in this area looks good now.


Notloggedinreport

Description
If the Login capability was used, give a better exception message
GitHub Issues

#86

Coverage decreased (-0.6%) to 90.722% when pulling 86bb63829e2d9ef73bbb884e92d554becc9e6e2a on mcrowson:notloggedinreport into cc91113f79f22bf0333400f40a251aad07f6d52b on refindlyllc:development.


YARN-10502. Add backlogs metric for CapacityScheduler

2496

 Quality gate: Failed
2 Issues

 2 Code issues

Details


[10.x] Add make:enum command with enum creation standard

Hi, everyone! This request add a new command to laravel console.
I'm refactoring a feature in one of my projects and adding Enum. Since laravel 10 uses php 8.1 as a prerequisite, can we consider standardizing the creation of enums?
I added this functionality in this PR and hope we can open a discussion about it.
I added 2 methods inside the enum as I didn't find native support

This is a amazing feature that would improve coding time, I have something that you should consider: Laravel [9.x] is supported by php > =8.0, and ENUM feature is only available at php >= 8.1. You should make this PR to Laravel [10.x]

@SilvioDoMine
True, I will create a new PR for this. Thanks!

Looks good! i've been waiting for a make:enum command for quite a while now, it'd be nice to have boilerplates for enums since not every developer does them the same way. I'm hoping this gets merged!

Thanks for your pull request to Laravel!
Unfortunately, I'm going to delay merging this code for now. To preserve our ability to adequately maintain the framework, we need to be very careful regarding the amount of code we include.
If possible, please consider releasing your code as a package so that the community can still take advantage of your contributions!
If you feel absolutely certain that this code corrects a bug in the framework, please "@" mention me in a follow-up comment with further explanation so that GitHub will send me a notification of your response.

Too bad. This command would be awesome. I was about to implement same command but there was already a pr for it. It's very sad that it's not merged.

@megasteve19 Possibly "useful", but "awesome" might be a bit overrated.
But I understand the choice here. Enums are nothing Laravel-specific, and generating a new enum is something already native in popular IDE, such as PHPStorm (Ctrl+N > PHP Class > Template: Enum).

Yeah I agree, this may be useful for some developers but as pyrou said it's not a laravel specific construct. Otherwise we would have to create make:trait, make:interface, make:class etc.
And I think the stubs are too opinionated. Some developers (me included) don't use PascalCase for enum cases and don't need additional static names and values functions.

Looks like I've hurt you. I apologize, wasn't the point.
You are free to create a package (public or private) to include all these command (make trait, interface, enum, etc..) and add this package to all your laravel projects as a composer require --dev dependency.
There is a lot of advantage of doing this:

package won't hit production (because included as a dev dependency)
you are free to add enum cases in stub the way YOU prefer (pascal, upper, kebab, whatever case, no enum body at all)
you can also customize (override) existing stubs for controller, model, tests, etc..

IMHO, make:exception doesn't deserve it place in the laravel/framework package

At the end, the decision has already been made. I believe that if any make command has a direct relationship with the framework, it is valuable to me. If you look at them individually, they actually mean nothing; they are just here for productivity.
@pyrou, I apologize for overreacting earlier.


build: PyInstaller cannot locate/add icon file

Unable to open icon file .github/pyinstaller/logo.ico see e.g. https://github.com/mandiant/capa/runs/6099866176?check_suite_focus=true#step:7:303
Tried all kinds of paths in #980. Maybe the new PyInstaller doesn't like the file anymore or it really can't find it...

maybe?: https://github.com/pyinstaller/pyinstaller/issues/6759

There's a SPECPATH global which points to the parent directory of the spec file for anchoring files relative to it (although I personally wish we just used file).

maybe we can do this to overcome?

im glad PyInstaller is cleaning up the way they handle paths since it was pretty inconsistent and difficult to figure out when things where relative to what. but... its also painful here.


[DNM] Migrate StackPromotion to OSSA

NonUse is a hack to handle uses that are not in the instruction's normal operand position. But OSSA logic still generally assumes that reference lifetimes are well-behaved, with post-dominating destroys. Can we preserve this ownership property and expand the dealloc_ref in OME? To split the alloc_ref lifetime from its allocation, we should split it into two SSA values.


Clarification for VPN detection needed

[A connection will be treated as a VPN if the adapter description contains certain keywords, such as "VPN" or "secure."]
Can we please clarify what exactly these keywords are? I read VPN or secure - but is there more to it?

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 971ae051-5d39-19d3-072e-fb098c82943b
Version Independent ID: 971ae051-5d39-19d3-072e-fb098c82943b
Content: Delivery Optimization Frequently Asked Questions - Windows Deployment
Content Source: windows/deployment/do/waas-delivery-optimization-faq.yml
Product: m365-security
GitHub Login: @carmenF
Microsoft Alias: carmenf

Chiming in, can you please clarify on all keywords? Our Citrix VPN is using network adapter name "Citrix Virtual Adapter", so would it be correctly recognized as a VPN, or not?

@maxbaldt Thank you for your feedback. You are right, the Keywords are only VPN or Secure.
@Skorfulose  Delivery optimization tries to find out whether a computer is connected via VPN by checking the type of network adapter and whether its description contains certain keywords, such as "VPN" or "secure" and not the name.
Hope this helps!
Thanks
Sri

@msbemba Thank you very much for the contribution and sharing this explanation. @maxbaldt Hope this comment is helpful for you. If you see a documentation update is required, please feel free to open an issue for the same. We proceed here to close it. Thanks for taking out some time to open the issue. Appreciate and encourage you to do the same in future also.


Add proposal votePower view function to CoreVoting

Currently we are not able to poll what the current votes are for a proposal.  Adding a view function to help out with this.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 2 (0.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.3%) to 93.901%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

contracts/CoreVoting.sol
0
2
0.0%

Totals

Change from base Build<PHONE_NUMBER>:
-0.3%

Covered Lines:
495

Relevant Lines:
513

💛  - Coveralls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Warning: This coverage report may be inaccurate.
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

0 of 0   changed or added relevant lines in 0 files are covered.
2 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.3%) to 93.901%

Files with Coverage Reduction
New Missed Lines
%

contracts/CoreVoting.sol
2
93.0%

Totals

Change from base Build<PHONE_NUMBER>:
-0.3%

Covered Lines:
495

Relevant Lines:
513

💛  - Coveralls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Warning: This coverage report may be inaccurate.
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

0 of 0   changed or added relevant lines in 0 files are covered.
2 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.3%) to 93.901%

Files with Coverage Reduction
New Missed Lines
%

contracts/CoreVoting.sol
2
93.0%

Totals

Change from base Build<PHONE_NUMBER>:
-0.3%

Covered Lines:
495

Relevant Lines:
513

💛  - Coveralls


cmd/compile: "1 variable but %d values" to "1 variable but %d return values"

This is a followup to #26616 which changed error message for this case:
bar := bufio.NewReader(...)
line := bar.ReadString()

from multiple-value bar.ReadString() in single-value context to 1 variable but 2 values.
In Python, if function returns multiple arguments (a tuple), it is completely okay to assign it to one variable:
>>> def xxx():
...   return 1,2
...
>>> a = xxx()
>>> b, c = xxx()
>>> a
(1, 2)
>>> b
1
>>> c
2

Therefore is Python coder like me is reading the Go code, it is not completely obvious what is going on, which was the reason to fill #26616. The error message is that fixes #26616 is good, but could be improved to include return values for explicit context that the error cause is in return type of the function and not in the assignment statement.

/cc @griesemer @mdempsky

I'm ok with making the error message more specific in case of a return statement. Not urgent.


can not find "Ninja" when working with cmake

When I type command
cmake -GNinja /path/to/project
I get the error:
CMake Error: CMake was unable to find a build program corresponding to "Ninja". CMAKE_MAKE_PROGRAM is not set. You probably need to select a different build tool.
when I copy the executable program "ninja" to /usr/local/bin/ninja(not /usr/local/bin/Ninja),cmake works well.So I suggest that add command
cp ninja /usr/local/bin/ninja
after executing command:
./configure.py --bootstrap
in file README

cmake -GNinja assumes that ninja is in PATH. I think most folks get ninja from https://github.com/ninja-build/ninja/releases , so I'm not sure if making configure print this would help much (and it'd be fairly unusual). Seems more like something to be documented on the cmake side.


Adds K8s manifests

This PR adds K8s manifests to get Descheduler running as a CronJob.

/assign @aveshagarwal

/close
🤦♂ just realized there is a directory kubernetes with some manifests.


Make useful exceptions for inaccessible external content

JIRA Ticket: https://jira.duraspace.org/browse/FCREPO-2828
What does this Pull Request do?
Wraps the IOException returned by a failed access of a remote site in a new ExternalContentAccessException and returns it as a 502 Bad Gateway response.
How should this be tested?
Create a proxied external content to a controllable webserver.
curl -ufedoraAdmin:fedoraAdmin -i http://localhost:8080/rest/simple_external -XPUT -H"Link: <http://static-ldp.localhost:8111/2012-12-01/IMG_20121201_113805.jpg>; rel=\"http://fedora.info/definitions/fcrepo#ExternalContent\"; handling=\"proxy\"" -H"Link: <http://www.w3.org/ns/ldp#NonRDFSource>;rel=\"type\""

GET the resource
> curl -i -u fedoraAdmin:fedoraAdmin http://localhost:8080/rest/simple_external
HTTP/1.1 200 OK
Date: Fri, 13 Jul 2018 15:37:16 GMT
Set-Cookie: JSESSIONID=o3n17jmzy9a28f7g3uooxdym;Path=/
Expires: Thu, 01 Jan 1970 00:00:00 GMT
Set-Cookie: rememberMe=deleteMe; Path=/; Max-Age=0; Expires=Thu, 12-Jul-2018 15:37:16 GMT
ETag: "734344dd5c3764b9235e2ee36c50e86de966e48c"
Last-Modified: Fri, 13 Jul 2018 15:36:21 GMT
Content-Type: image/jpeg
Accept-Ranges: bytes
Content-Disposition: attachment; filename=""; creation-date="Fri, 13 Jul 2018 15:36:21 GMT"; modification-date="Fri, 13 Jul 2018 15:36:21 GMT"; size=1377502
Link: <http://www.w3.org/ns/ldp#Resource>;rel="type"
Link: <http://www.w3.org/ns/ldp#NonRDFSource>;rel="type"
Link: <http://localhost:8080/rest/simple_external/fcr:metadata>; rel="describedby"
Link: <http://localhost:8080/static/constraints/NonRDFSourceConstraints.rdf>; rel="http://www.w3.org/ns/ldp#constrainedBy"
Accept-External-Content-Handling: copy,redirect,proxy
Allow: DELETE,HEAD,GET,PUT,OPTIONS
Link: <http://localhost:8080/rest/simple_external/fcr:acl>; rel="acl"
Content-Location: http://static-ldp.localhost:8111/2012-12-01/IMG_20121201_113805.jpg
Cache-Control: no-transform, must-revalidate, max-age=0
Content-Length: 1377502
Server: Jetty(9.3.1.v20150714)

????\ExifII*

.....

Shut down the remote webserver and perform the same GET request
> curl -i -u fedoraAdmin:fedoraAdmin http://localhost:8080/rest/simple_external
HTTP/1.1 502 Bad Gateway
Date: Fri, 13 Jul 2018 15:59:36 GMT
Set-Cookie: JSESSIONID=q48uyx5bizoi1x0pdx6m8vy3p;Path=/
Expires: Thu, 01 Jan 1970 00:00:00 GMT
Set-Cookie: rememberMe=deleteMe; Path=/; Max-Age=0; Expires=Thu, 12-Jul-2018 15:59:36 GMT
ETag: "734344dd5c3764b9235e2ee36c50e86de966e48c"
Last-Modified: Fri, 13 Jul 2018 15:36:21 GMT
Content-Type: text/plain;charset=utf-8
Accept-Ranges: bytes
Content-Disposition: attachment; filename=""; creation-date="Fri, 13 Jul 2018 15:36:21 GMT"; modification-date="Fri, 13 Jul 2018 15:36:21 GMT"; size=1377502
Link: <http://www.w3.org/ns/ldp#Resource>;rel="type"
Link: <http://www.w3.org/ns/ldp#NonRDFSource>;rel="type"
Link: <http://localhost:8080/rest/simple_external/fcr:metadata>; rel="describedby"
Link: <http://localhost:8080/static/constraints/NonRDFSourceConstraints.rdf>; rel="http://www.w3.org/ns/ldp#constrainedBy"
Accept-External-Content-Handling: copy,redirect,proxy
Allow: DELETE,HEAD,GET,PUT,OPTIONS
Link: <http://localhost:8080/rest/simple_external/fcr:acl>; rel="acl"
Content-Location: http://static-ldp.localhost:8111/2012-12-01/IMG_20121201_113805.jpg
Content-Length: 54
Server: Jetty(9.3.1.v20150714)

Problems getting external content : Connection refused

Additional Notes:
Any additional information that you think would be helpful when reviewing this PR.
Example:

Does this change require documentation to be updated? no
Does this change add any new dependencies? no
Does this change require any other modifications to be made to the repository (ie. Regeneration activity, etc.)? no
Could this change impact execution of existing code? no

Interested parties
@bbpennel @bseeger @dbernstein @awoods

Resolves: https://jira.duraspace.org/browse/FCREPO-2828


Preserve rails generator functionalities for the old versions

Why did you break the compatibility?
Better preserve it, no?

MongoDB already merges their own fixes.


jx-go-http3 to 0.0.1

Promote jx-go-http3 to version 0.0.1

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers:
If they are not already assigned, you can assign the PR to them by writing /assign  in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


using with Docker

Can this be used for a Shlink Docker installation as the target?  Source is a Shlink dist file version.

Yes, you can import from any Shlink instance to any Shlink instance.

I've read the steps, but can you elaborate on how to use this tool in Docker?

Here https://shlink.io/documentation/install-docker-image/#usage
See the Interact with Shlink's CLI on a running container. part.


Benchmark test for ES2015

Hello, I have a request about es6 benchmark suite.
The current process of implementing new es6 features looks not optimal because developer should manually add test files.
How about using es6-version test262 (https://github.com/tc39/test262)?
test262 tests each language feature in a single file, so it would help finding bugs and eventually speed up development.
(I found that JerryScript already has test262 suite but it is for es5.1)
Thanks.

@clover2123 Yes, ES6 tests of test262 can improve the testing process and it could add information how much ES6 features follow the standard. We planned to implement a ES6-test262 test driver in the near future, however if you are interested you can do it. Would you like to work on it?

@rtakacs actually, I have worked test262 of es6 version in my personal repo (https://github.com/clover2123/test262). But this version contains some wrong tests, so I'll futher update it and create a pr based on it if you are ok. Thanks.

The idea is good to have a working test262 runner for ES2015 too. Unfortunately there isn't test262 release, branch or tag for ES2015. Of course we can pick a revision which we think it is close enough to ES2015 (as you picked one in your fork), but it can contain bugs, it can miss tests added later, etc.
I investigated master test262 and experimented how to run tests with jerry ~3 months before, but it changed a lot since ES5/ES6 and need more development to make it work properly. I'm going to continue this work in the near future. But I think it shouldn't conflict with the proposed ES2015 runner at all, they are completely different, test262 master is near 5 years older now. :)
Now tools/run-tests.py --test262 builds ES5 jerry, calls tools/runners/run-test-suite-test262.py
which clones ES5 test262, and run tests with the original runner in the test262 repository. It would be great to have a similar solution for ES2015, for example a --test262-es2015 option in run-tests.py script which calls a script to clone a given test262 revision and then run tests. Can we do it without modifying test262, just adding an exclude file and call its runner directly?

@ossy-szeged
Yes, we can run ES6 test262 tests by cloning particular test262 version with some additional script files.
But there are some issues that I want to discuss with you.

test262 revision
By searching the log, fd44cd commit seems the last commit of ES6. How about picking this resivion for ES6 test?
test262 runner
it seems that original runner (test262.py) does not maintained properly now, so we should add ES6 runner manually. Other script files might be necessary too. I already have these additional scripts in my repo(https://github.com/clover2123/test262). Would it be fine to run test262 by cloning the particular test262 revesion first and copying the additional scripts into the cloned test262 directory before executing the runner?

#3667 is merged.
Close this issue.


Can each channel contributions on any input data be extracted?

So far, in DelayedSaturatedMMM, there is no way to extract channel contributions on other than data used for fitting.
I'd like to extract channel contributions on any input data, for example, future input or counterfactual input.
It cloud answer questions like "If we had reduced TV commercial cost at 30%, how much our company had earned?"

Hi @rym903
My first thought at the moment would be to:

fit model to get posterior
build model again with these new spends
sample for "channel_contributions" with pm.sample_posterior_predictive with the posterior (using mmm.fit_results)

Would you be interesting in making a PR to expose this functionality a bit more?
I would note that #632 is in progress and might make this a lot easier soon! However, to my eyes, it is not currently exposed very well

Hi @rym903
Any follow up questions here? If not, I can close out


Update aeron-client, aeron-driver to 1.26.0

Updates

io.aeron:aeron-client
io.aeron:aeron-driver

from 1.24.0 to 1.26.0.
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "io.aeron" } ]

labels: library-update, semver-minor

Closing due to #317.


python3Packages.nanobind: init at 1.9.0

Description of changes
nanobind is a small binding library that exposes C++ types in Python and vice versa. It is reminiscent of Boost.Python and pybind11 and uses near-identical syntax. In contrast to these existing tools, nanobind is more efficient: bindings compile in a shorter amount of time, produce smaller binaries, and have better runtime performance.
https://github.com/wjakob/nanobind
Pinging the pybind11 maintainers @yuriaisaka @dotlambda
Pinging the nanobind/pybind11 author @wjakob
Things done

Built on platform(s)

[x] x86_64-linux
[x] aarch64-linux (except tests depending on torch since cache.nixos.org does not provide a binary for torch and I did not have the patience to build it)
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Is there anything, I can do on my side such that we can merge this, @dotlambda ? Many thanks for your review!

Please ping tensorflow maintainers to fix the remaining error.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/cmake-3-27-8-nix-support-setup-hook-line-126-cmake-command-not-found/39053/2

@abbradar pinging you in your capacity as the maintainer of the tensorflow package. When I try to create an environment in which both torch and tensorflow are present, I get:
Running phase: pythonCatchConflictsPhase
Found duplicated packages in closure for dependency 'tensorboard':
        tensorboard 2.15.1 (/nix/store/14gikl62hxwdqdwhfndahr8x71arbj92-python3.11-tensorboard-2.15.1/lib/python3.11/site-packages/tensorboard-2.15.1.dist-info)
        tensorboard 2.15.1 (/nix/store/v9yv7sgvkgmm0dgdgl038bdsk43cggjy-python3.11-tensorboard-2.15.1/lib/python3.11/site-packages/tensorboard-2.15.1.dist-info)
Found duplicated packages in closure for dependency 'protobuf':
        protobuf 4.24.4 (/nix/store/m61dvbg0ncrf08mghn4n3r9x4cyq7dgq-python3.11-protobuf-4.24.4/lib/python3.11/site-packages/protobuf-4.24.4.dist-info)
        protobuf 4.21.12 (/nix/store/vkdvmsjz81x2xlws8qnkw4dqg51d2l8r-python3.11-protobuf-4.21.12/lib/python3.11/site-packages/protobuf-4.21.12.dist-info)
Found duplicated packages in closure for dependency 'grpcio':
        grpcio 1.60.1 (/nix/store/ccx0r2jzx5wxsp2dqa9a35l8amlspdvl-python3.11-grpcio-1.60.1/lib/python3.11/site-packages/grpcio-1.60.1.dist-info)
        grpcio 1.60.1 (/nix/store/asq5z2xncj4wp8k10igqlc99a2smmyax-python3.11-grpcio-1.60.1/lib/python3.11/site-packages/grpcio-1.60.1.dist-info)
Found duplicated packages in closure for dependency 'tensorboard_plugin_profile':
        tensorboard_plugin_profile 2.11.1 (/nix/store/b84ndcxxald19yj2yy1sqbzd68cdvfg5-python3.11-tensorboard_plugin_profile-2.11.1/lib/python3.11/site-packages/tensorboard_plugin_profile-2.11.1.dist-info)
        tensorboard_plugin_profile 2.11.1 (/nix/store/m5m47mw6gk7n55k8yz709n7r4ybdy1rd-python3.11-tensorboard_plugin_profile-2.11.1/lib/python3.11/site-packages/tensorboard_plugin_profile-2.11.1.dist-info)

Package duplicates found in closure, see above. Usually this happens if two packages depend on different version of the same dependency.

One possibility would be, I believe, to disable tensorboard support in tensorflow. However, this causes a massive rebuild that needs more RAM than my machine provides.
What is your take on this? Is this a common problem? Would it be possible to solve it? Or would be disabling tensorboard support the way to go?
Many thanks in advance - your help is highly appreciated.

@abbradar just a quick reminder. Do you have any idea how to solve this duplicate dependency issue? Otherwise, I would propose to disable the tests (only a tiny fraction of the overall test suite) and merge nanobind without them. Many thanks for your time!

@dotlambda I believe we can merge now. The tensorflow dependency issues have been resolved on master. Awesome!

I think we can merge now. Pinging you, @NickCao, as you have previously merged similar contributions by me.

@ofborg build python311Packages.nanobind python312Packages.nanobind

Is there anything I can do such that we can merge this? Any pointers highly appreciated :)

greetings @phiadaarr  !
I am interested in getting this merged, unfortunately currently one of dependecis fails to build on master
pythonPackages.protobuf
I certainly don't expect/require you to fix this for this PR, but any help would be appreciated

Result of nixpkgs-review pr 286125 run on x86_64-linux 1

2 packages failed to build:

python312Packages.nanobind
python312Packages.nanobind.dist

2 packages built:

python311Packages.nanobind
python311Packages.nanobind.dist

protobuf build log
error: builder for '/nix/store/xp69yxchzp0hdy9jgfl0agmz9nq2hsqz-python3.12-protobuf-4.21.12.drv' failed with exit code 1;
       last 10 log lines:
       > google/protobuf/internal/well_known_types_test.py::TimeUtilTest::testTimestampSerializeAndParse
       >   /build/source/python/google/protobuf/internal/well_known_types.py:195: DeprecationWarning: datetime.datetime.utcnow() is deprecated and scheduled for removal in a future version. Use timezone-aware objects to represent datetimes in UTC: datetime.datetime.now(datetime.UTC).
       >     self.FromDatetime(datetime.datetime.utcnow())
       >
       > -- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html
       > =========================== short test summary info ============================
       > FAILED google/protobuf/internal/json_format_test.py::JsonFormatTest::testInvalidOneof - AttributeError: 'JsonFormatTest' object has no attribute 'assertRaisesRegex...
       > FAILED google/protobuf/internal/json_format_test.py::JsonFormatTest::testInvalidTimestamp - AttributeError: 'JsonFormatTest' object has no attribute 'assertRaisesRegex...
       > ============= 2 failed, 900 passed, 9 skipped, 9 warnings in 7.09s =============
       > /nix/store/v5lsd029lz5lfhamivbgqyp3zdv94ah2-stdenv-linux/setup: line 1578: pop_var_context: head of shell_variables not a function context
       For full logs, run 'nix log /nix/store/xp69yxchzp0hdy9jgfl0agmz9nq2hsqz-python3.12-protobuf-4.21.12.drv'.

Regarding the protobuf build failing:

I tried nix-build -A python3Packages.protobuf --check on the latest master (c077b043ee73cb0c479c7c8d1d01e42c71a8372f) and there protobuf builds and the tests run through.
I ran nix-build -A python3Packages.nanobind on my nanobind branch -> works

Not sure what the problem overall is and whether it is a problem after all for us or not.
Is there anything that needs to be fixed from our side before we can merge this package, @NickCao @dotlambda ?

Result of nixpkgs-review pr 286125 run on x86_64-linux 1

2 packages failed to build:

python312Packages.nanobind
python312Packages.nanobind.dist

2 packages built:

python311Packages.nanobind
python311Packages.nanobind.dist

but now python312Packages.nanobind fails because python312Packages.tensorflow fails to build
I think, this should be good to merge

Is there anything, I can do to get this merged? Any pointers highly appreciated :)

@GrahamcOfBorg build python3Packages.nanobind

@phiadaarr thank you for this !


Disable auto-steering temporarily

Driving through long construction zones, shiny-road conditions or other situations which confuse lane line recognition is a hassle. There are several times when I want auto-steering off while cruise control is still desired and usable. This PR adds the option to disable auto-steer while leaving longitudinal cruise-control intact. No extra hardware or UI needed.
Simply turn cruise On, Off and On in under 2.5 seconds and auto-steer is now disabled.
Note: Not to be confused with setting cruise to 'enabled' / setting a cruise speed.
Auto-steer remains disabled until cruise is turned off. When road conditions are again favorable to auto-steer, just turn cruise Off and On again.
Toyota-only atm. I can probably figure out the other makes and add an appropriate alert, if there is interest in this request.

@ncflagg , we really want to keep openpilot UI very simple: either it's on, or it's off. No intermediate states where long control is active but lateral isn't, for example.
Ok feature for a fork though, as long as the panda safety code remains the same.


Having beta channel / contextual deployments for KodaDot

Think about how we can achieve have a beta channel where we can test some new features and have them battle-tested till they hit mainstream exposure.
Thinking aloud about the switch button which by default is off and once enabled, we can start enabling features.

having json, where you can enable/disable accessibility for new features for mainstream users
probably will be always on for beta?
having a survey, where can collect feedback probably, feedback channel on discord, is good but it could be messy, probably direct people straight to the github, but non-tech savvy having some tally form?
have a beta-testers audience
have proper way to have great and rich reports about bugs, critical

First feature we can start testing out with #753

Can we set some specific ENV variables per branch?

Apparently there is context env https://stackoverflow.com/questions/49720743/branch-specific-environment-variables-on-netlify
ref

https://docs.netlify.com/configure-builds/environment-variables/
https://www.netlify.com/blog/2020/05/21/localize-your-environment-variables-by-context-with-build-plugins/
https://docs.netlify.com/site-deploys/overview/#deploy-contexts

recall plugin which can set env based on branch prefix i.e.
in theory it might works 😄

Installed https://github.com/cball/netlify-plugin-contextual-env#readme

Regarding feature toggling, you might want to check launchdarkly

Memo, we have https://beta.kodadot.xyz meanwhile


NFS provisioning fails when PVC was created by an operator

When a PVC is created by an operator (and thus has a metadata.ownerReferences field) with a storageClass that has nfsResources set to "true" the provision of the nfs volume fails. This results in the original PVC staying in the 'Pending' state.
This only happens when nfsResources is set to "true".
StorageClass:
---
allowVolumeExpansion: true
apiVersion: storage.k8s.io/v1
kind: StorageClass
metadata:
  labels:
    environment: int
  name: hpe-standard
parameters:
  csi.storage.k8s.io/controller-expand-secret-name: nimble-storage
  csi.storage.k8s.io/controller-expand-secret-namespace: nimble-storage
  csi.storage.k8s.io/controller-publish-secret-name: nimble-storage
  csi.storage.k8s.io/controller-publish-secret-namespace: nimble-storage
  csi.storage.k8s.io/fstype: xfs
  csi.storage.k8s.io/node-publish-secret-name: nimble-storage
  csi.storage.k8s.io/node-publish-secret-namespace: nimble-storage
  csi.storage.k8s.io/node-stage-secret-name: nimble-storage
  csi.storage.k8s.io/node-stage-secret-namespace: nimble-storage
  csi.storage.k8s.io/provisioner-secret-name: nimble-storage
  csi.storage.k8s.io/provisioner-secret-namespace: nimble-storage
  description: Volume created by the HPE CSI Driver for Kubernetes
  destroyOnDelete: "true"
  nfsResources: "true"
provisioner: csi.hpe.com
reclaimPolicy: Delete
volumeBindingMode: Immediate

PersistentVolumeClaim:
apiVersion: v1
kind: PersistentVolumeClaim
metadata:
  annotations:
    volume.beta.kubernetes.io/storage-class: hpe-standard
    volume.beta.kubernetes.io/storage-provisioner: csi.hpe.com
  creationTimestamp: "2021-12-20T13:07:16Z"
  finalizers:
  - kubernetes.io/pvc-protection
  name: my-claim-2
  namespace: default
  ownerReferences:
  - apiVersion: zalando.org/v1
    blockOwnerDeletion: true
    controller: true
    kind: EphemeralVolumeClaim
    name: my-claim-2
    uid: 1272133c-546b-4620-8baf-f1113002ff18
  resourceVersion: "11046667"
  uid: 9d20d560-50ef-45c6-bc21-0f915a22c4df
spec:
  accessModes:
  - ReadWriteOnce
  resources:
    requests:
      storage: 1G
  volumeMode: Filesystem
status:
  phase: Pending

csi-provisioner.log
csi-driver.log

What version of Kubernetes is this? I ran into this on Kubernetes 1.23, which the HPE CSI Driver doesn't support yet.

Kubernetes v1.21.4-gke.201

Ok thanks for the info. We've reproduced this in our environment and currently investigating what is going on.

We've tracked this down to "Cross-namespace owner references is disallowed by design.", you should see this event being emitted in the "hpe-nfs" Namespace on your cluster:
5m17s       Warning   OwnerRefInvalidNamespace   persistentvolumeclaim/hpe-nfs-af414f04-ae58-4dcc-a06a-c7476bf0a6ee   ownerRef [zalando.org/v1/EphemeralVolumeClaim, namespace: hpe-nfs, name: my-claim-2, uid: fbc152e2-a93e-45eb-9d26-7382586bec28] does not exist in namespace "hpe-nfs"

NFS servers, backing PersistentVolumeClaims and all the associated configuration are being setup in the "hpe-nfs" Namespace by default.
That said, we have a workaround for this. In the StorageClass, you can set nfsNamespace to the Namespace name of where EphemeralVolumeClaims are being created. In your example above:
---
allowVolumeExpansion: true
apiVersion: storage.k8s.io/v1
kind: StorageClass
metadata:
  labels:
    environment: int
  name: hpe-standard
parameters:
  csi.storage.k8s.io/controller-expand-secret-name: nimble-storage
  csi.storage.k8s.io/controller-expand-secret-namespace: nimble-storage
  csi.storage.k8s.io/controller-publish-secret-name: nimble-storage
  csi.storage.k8s.io/controller-publish-secret-namespace: nimble-storage
  csi.storage.k8s.io/fstype: xfs
  csi.storage.k8s.io/node-publish-secret-name: nimble-storage
  csi.storage.k8s.io/node-publish-secret-namespace: nimble-storage
  csi.storage.k8s.io/node-stage-secret-name: nimble-storage
  csi.storage.k8s.io/node-stage-secret-namespace: nimble-storage
  csi.storage.k8s.io/provisioner-secret-name: nimble-storage
  csi.storage.k8s.io/provisioner-secret-namespace: nimble-storage
  description: Volume created by the HPE CSI Driver for Kubernetes
  destroyOnDelete: "true"
  nfsResources: "true"
  nfsNamespace: default
provisioner: csi.hpe.com
reclaimPolicy: Delete
volumeBindingMode: Immediate

However, this might not be practical for several reasons and for that we have the ability to allow users confined to namespaced objects to override certain parameters.
So, this StorageClass:
---
allowVolumeExpansion: true
apiVersion: storage.k8s.io/v1
kind: StorageClass
metadata:
  labels:
    environment: int
  name: hpe-standard
parameters:
  csi.storage.k8s.io/controller-expand-secret-name: nimble-storage
  csi.storage.k8s.io/controller-expand-secret-namespace: nimble-storage
  csi.storage.k8s.io/controller-publish-secret-name: nimble-storage
  csi.storage.k8s.io/controller-publish-secret-namespace: nimble-storage
  csi.storage.k8s.io/fstype: xfs
  csi.storage.k8s.io/node-publish-secret-name: nimble-storage
  csi.storage.k8s.io/node-publish-secret-namespace: nimble-storage
  csi.storage.k8s.io/node-stage-secret-name: nimble-storage
  csi.storage.k8s.io/node-stage-secret-namespace: nimble-storage
  csi.storage.k8s.io/provisioner-secret-name: nimble-storage
  csi.storage.k8s.io/provisioner-secret-namespace: nimble-storage
  description: Volume created by the HPE CSI Driver for Kubernetes
  destroyOnDelete: "true"
  nfsResources: "true"
  allowOverrides: nfsNamespace
provisioner: csi.hpe.com
reclaimPolicy: Delete
volumeBindingMode: Immediate

Would allow users to create PersistentVolumeClaims with the following annotation:
apiVersion: v1
kind: PersistentVolumeClaim
metadata:
  name: my-pvc
  annotations:
    csi.hpe.com/nfsNamespace: this-is-my-namespace
spec:
  accessModes:
    - ReadWriteOnce
  resources:
    requests:
      storage: 100Gi

So, the most practical way to go about this would be to change the "EVC" Operator to add the annotation from the calling namespace to underlying "PVC".
You can learn more about allowOverrides and allowMutations supported by the HPE CSI Driver on SCOD.

Thanks for that quick workaround @datamattsson !
Since this only happens when there is an owner reference set on the original PVC I can only conclude that the NFS PVC gets the owner reference copied from the original PVC. IMHO it would be better if the owner reference of the NFS PVC should point to the original PVC and always be present, or never be present at all. And if an owner reference is used, the NFS resources should be created in the original namespace by default.
The operator in the case above is obviously a stub I used to reproduce the issue, since I can't share the operator with which I originally encountered the issue. In this case we might be able to get the developer of the operator to customize the templates used by the operator, but this will add extra maintenance. This may not be possible with every operator we use.

Thanks for verifying. There are multiple ways this can play out. The origin PVC ownerReference should not be copied to the NFS PVC in the first place, the fact that we're using a different PVC to serve the origin PVC is an implementation detail that shouldn't be anyone's concern in the first place. I'm not too familiar with the implementation details but I'm assuming we're simply copying the origin PVC as-is and inject a few parameters, it seems we need to truncate ownerReference in that transformation.
There's also the behavior of having the NFS resources deployed automatically in the origin Namespace when ownerReference is encountered. This might be implemented as a behavior that a Kubernetes admin might want to control per StorageClass so we have to wait and see what Eng/PM deem the best foot forward.


Import fails with similarly named partial in 3.4.2

A project I'm working on imports a pattern library in which the base file imports a partial with the same file name (e.g. base.scss imports _base.scss). This setup was working through v3.4.1 but fails on v3.4.2 with the following error:
Error: It's not clear which file to import for '@import "base"'.

Looking through the v3.4.2 release notes it looks like @import was refactored in libsass#1626.
Is this a regression? It broke our CI server builds this morning when the new patch was installed.

To clarify, this should fail according to the SASS specification:

"Note that you may not include a partial and a non-partial with the same name in the same directory. For example, _colors.scss may not exist alongside colors.scss."

My concern here is with this potentially being a breaking change that was introduced in a patch update between v3.4.1 and v3.4.2.

This is tricky. Node Sass technically follows semver but LibSass does not. There isn't really much we can do here. The expectation is that we do what Ruby Sass does. If you're relying on an undocumented bug semver offers no guarantees that behaviour won't break.


Handoff from Vanilla JS App to Angular App Authentication

Core Library
MSAL.js v2 (@azure/msal-browser)
Core Library Version
2.24.0
Wrapper Library
MSAL Angular (@azure/msal-angular)
Wrapper Library Version
2.4.5
Public or Confidential Client?
Public
Description
Let's assume, We've an Angular app with MSAL Authentication. When we load this app in the browser, it has to download all the required JS files before application starts showing up and then the authentication kicks in, where it redirects to the Azure AD and come back and reload the app.
So Authentication is delayed till the source application JS is downloaded and parsed.
I'm thinking is there any way, we could have the plain MSAL.js library injected in to the index.html of the Angular app, which allows to kick in the authentication even before the Angular app Javascript files download.
This way, we can achieve early authentication and avoid redudant download of Angular app Javascript files.
Question:
How this handoff will happen from the authentication happened from the MSAL.js to authentication from Angular (@azure/msal-angular) library.
I've tried this and I see issues like Browser Auth Error & Interaction Error errors. Looks like there's no formal handshake between the two modes of authentication even though we use the same cache location for storage of tokens.
Any thoughts are appreciated.
MSAL Configuration
No response
Relevant Code Snippets
No response
Identity Provider
Azure AD / MSA
Source
External (Customer)

I've tried this and I see issues like Browser Auth Error & Interaction Error errors. Looks like there's no formal handshake between the two modes of authentication even though we use the same cache location for storage of tokens.

Can you please go into more detail about this? What exactly did you try and what happened?
I'm also not sure I understand this statement: "Looks like there's no formal handshake between the two modes of authentication". msal-angular is merely a thin wrapper around msal-browser to provide Angular features like Interceptors and Guards but all operations still go through msal-browser under the hood.

I've downloaded one of your sample application of Angular implementing the MSAL auth. So, in the index.html file, I've added the code from the sample app for Vanilla JS implementation. To be precise, I've this below code -
`

<script>

  const msalConfig = {
auth: {
  authority: 'https://login.microsoftonline.com/',
  clientId: 'xxxxxxxxxxxxxxxx',
  redirectUri: 'http://localhost:4200',
  postLogoutRedirectUri: 'xxxxxxxxxxxxxxxx',
  navigateToLoginRequestUrl: true
},
cache: {
  cacheLocation: 'sessionStorage'
},
logs: false

};
const loginRequest = {
scopes: ["User.Read"]
};
let signInType;
let accountId = "";
// Create the main myMSALObj instance
// configuration parameters are located at authConfig.js
const myMSALObj = new msal.PublicClientApplication(msalConfig);
// Redirect: once login is successful and redirects with tokens, call Graph API
myMSALObj.handleRedirectPromise().then(handleResponse).catch(err => {
console.error(err);
});
function handleResponse(resp) {
if (resp !== null) {
accountId = resp.account.homeAccountId;
myMSALObj.setActiveAccount(resp.account);
} else {
// need to call getAccount here?
const currentAccounts = myMSALObj.getAllAccounts();
if (!currentAccounts || currentAccounts.length < 1) {
return;
} else if (currentAccounts.length > 1) {
// Add choose account code here
} else if (currentAccounts.length === 1) {
const activeAccount = currentAccounts[0];
myMSALObj.setActiveAccount(activeAccount);
accountId = activeAccount.homeAccountId;
}
}
}
if (!myMSALObj.getAllAccounts().length) {
// Sign In
myMSALObj.loginRedirect(loginRequest);
}
</script>

`
When I do this i'm thrown with this errors in the console -
VM451641:106 ClientAuthError: state_not_found: State not found:  Cached State
Basically what I mean by handshake is - "If we setup a plain vanilla auth in the Angular index.html and after initializing it again in Angular app once its bootstrapped, will it work seamlessly? To my knowledge, since idtoken is already dropped inside the browser it should work".
Also, for Angular App, we add -  tag beside the . Will that cause any harm?

There's no technical reason this shouldn't work, however, you should be careful that handleRedirectPromise is not called both in the VanillaJS and Angular app at the same time, that's likely what's causing the error here. If you refresh the page after getting this error does it work?
I'm not sure how you would delay Angular bootstrap until after the VanillaJS script has completed but that would be the way to resolve this.

Yes. That's what I was checking on the handoff mechanism which allows the Angular app to wait till the VanillaJS code is done.


Editor Toggle hide children broken

Since version 3.9 the editor options on a SimGroup "Toggle Hide Children" and "Toggle Lock Children" no longer work, nothing happens. Previously in 3.8 it worked and it proberly hid all children objects in the SimGroup.

Figured this one out, will have a PR to fix it up tonight. Thanks for the spot on this!

Please give #1769 a shot, it should fix both the hide and lock toggles for you.

Worked for me.

Merged #1769


Add dialog to perform compendium migrations

Also fixes compendium migration but since its not a released feature and the bug only occurred this cycle (?), we don't really need to add the bugfix tag.

I attempted to do the compendium.apps[this.appId] = this thing to have the dialog auto-refresh but it seems that unlike documents, compendium apps are an array. So my attempt merely caused it crash.


Use domain names for banks instead of IPs

#629

This will require backend updates and quite a few additional tests as well https://github.com/thenewboston-developers/thenewboston-python/blob/development/src/thenewboston/models/network_node.py#L12 We are adding in domain name support for beta but the alpha nodes only support static IP addresses now.

This field should still work for ip addresses. Could you update the regex to account for both situations?

Sure, I will do that change

You can close that @avinashupadhya99