[ios] Lock screen controls remain after last track ends. (NowPlayingInfoCenter)

On iOS, the lock screen controls should disappear after the last track ends.
Instead, they remain visible.

I tried adding the following to RNTrackPlayer.swift inside player.event.playbackEnd.addListener
self.player.nowPlayingInfoController.clear()

As suggested here: https://github.com/jorgenhenrichsen/SwiftAudio/issues/83
However, this clears out the info but the controls remain in place.

Have been looking at a similar issue and setting nowPlayingInfo to an empty dictionary seems to do the trick: MPNowPlayingInfoCenter.default().nowPlayingInfo = [:].

Are you finding that your suggestion works differently than self.player.nowPlayingInfoController.clear()? Where did you put that line?

Yes. It actually clears the audio player including the controls.
Currently calling it in the reset function in RNTrackPlayer.swift within the DispatchQueue.main.async block.

@Thomas0c do the lock screen control disappear if you are watching them when the queue ends?
For me everything works as expected, UNLESS I have the lock screen controls visible when the queue ends. In this case, using either MPNowPlayingInfoCenter.default().nowPlayingInfo = [:] or self.player.nowPlayingInfoController.clear() causes the controls to reset to a "default" state. (see attached)

At this point, if I turn the screen off and back on, the controls go away as they should.

Did someone solve this issue? Is this issue still in tracking?

Any update on this?

Here is the destroy method which only prints a message in the log
@objc(destroy)
    public func destroy() {
        print("Destroying player")
    }

This is not a perfect solution but i found a workaround that updating the options after restting the player works for me.
    await RNTrackPlayer.reset()
    await RNTrackPlayer.updateOptions({ stopWithApp: true,
      capabilities: [
        Capability.Play,
        Capability.Stop,
        Capability.SkipToNext,
        Capability.SkipToPrevious,
        Capability.Pause
      ]})await RNTrackPlayer.reset()
      ```


[BUG] Prophet object error when predicting

Describe the bug

Trying a flow similar (but not exactly the same) to the one in the Prophet getting started guide, I run into an issue when making the call to predict.
To Reproduce

import numpy as np
import pandas as pd
from sktime.forecasting.fbprophet import Prophet

y = pd.DataFrame(np.arange(1, 100), columns=['0'])
y.index = y.index.astype('datetime64[ns]')
f = Prophet()
f.fit(y)
predictions = f.predict(fh=[1])

Expected behavior

Predictions should be made and stored in the predictions variable.
Additional context

Versions

System:
    python: 3.8.6 (default, Nov 20 2020, 18:29:40)  [Clang 12.0.0 (clang-1<IP_ADDRESS>)]
executable: /Users/Pato/env/bin/python3.8
   machine: macOS-10.16-x86_64-i386-64bit
Python dependencies:
          pip: 20.2.4
   setuptools: 50.3.2
      sklearn: 1.0.2
       sktime: 0.11.2
  statsmodels: 0.12.1
        numpy: 1.21.5
        scipy: 1.4.1
       pandas: 1.1.5
   matplotlib: 3.3.3
       joblib: 0.17.0
        numba: None
     pmdarima: 1.8.0
      tsfresh: None

So sth like this:
import numpy as np
import pandas as pd
from sktime.forecasting.fbprophet import Prophet

y = pd.DataFrame(np.arange(1, 100), columns=['0'], index = pd.date_range(start='1/1/2018', end='4/9/2018'))

f = Prophet()
f.fit(y)
predictions = f.predict(fh=[1])

(not a bug, I think)

Thanks for the quick reply @fkiraly!

you probably do not want that...

You're right I don't (Prophet may not play nice with such tiny scales), but am trying to call this under some constraints that mean I don't necessarily have access to the actual absolute timestamps, which is why I tried this approach with a relative index first.
I'll consider this solved for now, up to the maintainers to decide whether it's an actual bug or not.

Hm, I think it might be a bug, because this does not work:
import numpy as np
import pandas as pd
from sktime.forecasting.fbprophet import Prophet

y = pd.DataFrame(np.arange(1, 100), columns=['0'])

f = Prophet()
f.fit(y)
predictions = f.predict(fh=[1])

I think it should.

Prophet works only with pd.DatetimeIndex

yes, but due to the prophet limitation, it violates the sktime interface contract that strongly implies it should work with any index. A simple workaround would be: if you see an integer index, put in some dummy dates, make the forecast, remove the dummy dates. In such a case, of course, holiday dummies and the like will not make sense and the user should be forewarned by the docstring.


Why VirusTotal detect Trojan?

Here is result https://www.virustotal.com/gui/file/39770082ed6f43a9642d243f92a1dd10fbf27778e3571d29ec0c9bde1607ee5a?nocache=1
Detected<EMAIL_ADDRESS>(RDM.MSIL:/alA16pI2egLctGcr0nubw)"

Well, any reactions?

@mirgorodalexander in almost all cases where only a couple of the scans trip is a case of a false positive and can be safely ignored


v1 - local search issue

For some parameters like uule that we need to pass to Google for search, they should not be urlencoded because then the value is lost. Since you're using http_build_query for your parameters, this particular parameter's value is being converted wrongly.
Example:
$googleUrl->setLang('en')->setNumberResults(10)->setTld("co.in")->setParam("uule","w+CAIQICIJTmV3IERlbGhp");
Ideally it should call
https://www.google.co.in/search?lr=lang_en&hl=en&q=chinese+restaurants&complete=0&pws=0&uule=w+CAIQICIJTmV3IERlbGhp but it converts the "+" sign and that results in a wrong search in Google. So perhaps you need a function called, setRawParam which is then appended in it's raw form at the end of the built query.

I see the problem.
setRawParam looks to be good solution, though I have to use the proper solution to implement it.
I the interim you can replace you setParam call with:
->setParam("uule",urldecode("w+CAIQICIJTmV3IERlbGhp"));

I didnt give it a try but that should work.

setRawParam was implemented


Fix memory leak in static renderer when using PipelineFrustumCulling_Simple

fixes #149
Hope it's cool that I made an issue and PR for this!
Ran into it while working on a little game.

fixes #149
Hope it's cool that I made an issue and PR for this! Ran into it while working on a little game.

Hey, nice pull request you got there i will see if the code is not broken then i will aprove, the merge will be doing by h4570.

Thank you for contributing! :)


JAVA_OPTS was ignored when app started

Hi,
In last version of buildpack I can not add my custom JAVA_OPTS.
Steps:

I have created simple app via https://start.spring.io/ with Spring-boot 2.3.3
Create docker image  with ./mvnw spring-boot:build-image.
Run docker docker run -e "JAVA_OPTS=-Xmx400m" library/awesome_app:0.0.1-SNAPSHOT

Then I see at logs my params.

Setting Active Processor Count to 4
Adding $JAVA_OPTS to $JAVA_TOOL_OPTIONS
WARNING: Container memory limit unset. Configuring JVM for 1G container.
Calculated JVM Memory Configuration: -XX:MaxDirectMemorySize=10M -XX:MaxMetaspaceSize=95268K -XX:ReservedCodeCacheSize=240M -Xss1M (Total Memory: 1G, Thread Count: 250, Loaded Class Count: 14406, Headroom: 0%)
Adding 127 container CA certificates to JVM truststore
Spring Cloud Bindings Enabled
Picked up JAVA_TOOL_OPTIONS: -Djava.security.properties=/layers/paketo-buildpacks_bellsoft-liberica/java-security-properties/java-security.properties -agentpath:/layers/paketo-buildpacks_bellsoft-liberica/jvmkill/jvmkill-1.16.0-RELEASE.so=printHeapHistogram=1 -XX:ActiveProcessorCount=4 -Xmx400m -XX:MaxDirectMemorySize=10M -XX:MaxMetaspaceSize=95268K -XX:ReservedCodeCacheSize=240M -Xss1M -Dorg.springframework.cloud.bindings.boot.enable=true

But any params was passed to  jar

cnb@ae43ae18befc:/$ ps ax | grep jav
1 ?        Ssl    0:11 java org.springframework.boot.loader.JarLauncher
126 pts/0    S+     0:00 grep --color=auto jav

The line
Picked up JAVA_TOOL_OPTIONS: -Djava.security.properties=/layers/paketo-buildpacks_bellsoft-liberica/java-security-properties/java-security.properties -agentpath:/layers/paketo-buildpacks_bellsoft-liberica/jvmkill/jvmkill-1.16.0-RELEASE.so=printHeapHistogram=1 -XX:ActiveProcessorCount=4 -Xmx400m -XX:MaxDirectMemorySize=10M -XX:MaxMetaspaceSize=95268K -XX:ReservedCodeCacheSize=240M -Xss1M -Dorg.springframework.cloud.bindings.boot.enable=true

is printed by the JVM itself, not by any part of the buildpack.  So the JVM is telling you that it's seen your -Xmx400m when it starts.  $JAVA_TOOL_OPTIONS is a JVM-native way of passing in JVM flags in headless environments since $JAVA_OPTS is a convention, but is not understood by the JVM directly.  If you were to fire up JVisualVM, and looked at the memory configuration from inside the JVM, you'd see that you configuration took.

Thank you.
May you also explain, why I do not see JAVA_TOOL_OPTIONS at environment variables in docker?


the shield can't prevent the debuff caused by mobs

Describe the Bug
when i went into the fortress to kill the blaze, i found i can use the shield to prevent the danmage caused by their fireball but i was in fire. so did the wither skeleton. i didn't harm by its sword but i get wither. also,when skeleton hit me. i won't get any danmage but i was knocked back. i test in vanilla and the shield worked well.
Reproduction Steps
1.just place a blaze and arm a shield
2.right click
3.you are in fire
Expected Result
just make the shield work properly.
Screenshots and Videos
https://github.com/Fabricators-of-Create/Create/assets/145242844/e67dd652-6600-49b3-9b1e-3018b472147d
Crash Report or Log
No response
Operating System
Windows 11
Mod Version
0.5.1d
Minecraft Version
1.20.1
Other Mods

Additional Context
No response

Confirmed in my testing.
i compared how the shield work between fully vanilla client and with only Create fabric installed
in fact, not just blaze
it seems that shield only block damage, but does not block any effect that comes with that damage, like knockback from skeleton arrow, knockback from zombie hit, blaze fire, shulker levitation, etc.
And the weirdest of them all being, if you block a creeper explosion while jumping backwards, you got knocked FORWARD as if the explosion comes from the back.
making shield completely useless imo, and making raiding fortress harder than it should be

it would be interesting to test with a fabric instance with no mods, just to see if it might be caused by fabric itself.

Retested with just fabric loader 0.14.22 without any mods installed
And shield behave as expected just like in vanilla

Retested with just fabric loader 0.14.22 without any mods installed
And shield behave as expected just like in vanilla

so it means this is a bug caused by Create and needs to be solved? :)

it would be interesting to test with a fabric instance with no mods, just to see if it might be caused by fabric itself.

i use these mods except Create to test and the shield works well.

this should be fixed on patch f


add dynamic setter for empty fields

Fixes https://github.com/contentful/contentful_model/issues/140

Thanks for tackling this!
Merging

Thank you for merging. We do have one other minor pull request to allow custom Asset mapping. Otherwise there is no way to inherit the current default Asset model and map it. https://github.com/contentful/contentful_model/pull/141


Autoconvert not true by default

Documentation says
"You can disable the auto-conversion of smileys by setting the auto_convert_smileys configuration option to false", and by that one would assume that the default value is true, when it's undefined.
For auto conversion to work, you have to explicitly define a parameter
auto_convert_smileys: true

Thanks pinta83 for your comment
You're right, By default the smileys auto conversion is disabled so you have to set the  auto_convert_smileys configuration option  to true in order to enable it.
I just fixed this in the readme file. Thanks again and please don't hesitate to submit any bug, issue you find in this plugin

No problem m8, if i find anything else, I'll report ASAP :)


GitHub actions workflow for sending a package to pypi on release

Setup File Structure
~Setup pypi project on https://pypi.org/project/big-o-pbeekes/0.0.1/~
Setup workflow

Hi @jpphilips , thank you for the PR.
There are several issues with the PR that would need to be fixed before merging

A PyPi package for BigO already exists https://pypi.org/project/big-O/
The current version is 0.10.2, as defined in the setup.py file
My name is misspelled, and the email addresses are fake
We can discuss about authorship, but it's either everyone who ever participated, or just me as the original author and main contributor
The project URLs are fake
The PR changes the permissions of all files, why is that?
I would like to have a solution based on the existing setup.py, rather than adding a toml file and having to maintain both

The PR also moved all the tests somewhere else

Thanks for the feedback

Noted. sorry about that
fixed
fixed
Set you as only author
fixed
I don't know about this. Pls check the recent commit to see if it has been resolved
I will delete the toml file yes?
fixed

Thank you for the changes. The version of the github action you are using is also very old.
I'll make some changes and re-submit with you as author

@jpphilips I committed a branch called pypi-workflow containing the changes you made that are relevant for this task, with you as author. Could you please open a new PR with that branch? Normally I would do it, but I fear you wouldn't get the Hacktoberfest credits

Thank you. I'm unable to see the branch you created.

Alright. Thank you but I'm unable to see the branch you created

how about now?

you would need to pull the branch in your fork, then do a PR from there

Closing in favor of #51


Setter method receiving no arguments

Follow-up to #5856. It is currently still possible to do the following
class Foo
  def bar=; end
  def []=; end
end

These should be disallowed; a regular setter method should receive exactly 1 positional argument, and []= should receive at least 1 positional argument.
Furthermore, setter methods should never have default arguments. For regular ones this is obvious, because you cannot call them without arguments anyway. For #[]= the reasoning is as below: suppose we have
class Foo
  def []=(a, b = 0)
    "#{a}, #{b}"
  end
end

x = Foo.new
x[1] = 2 # => "1, 2"
x[] = 3  # => "3, 0"

One may expect that 3 is assigned to b instead of a, because conceptually the last positional argument to #[]= is always provided by the operator syntax, but due to the way default arguments work, this isn't the case. def []=(a = 0, b) wouldn't do either, since b becomes a required named argument and a would then be the new setter value. It follows that any default positional arguments on #[]= would lead to similar confusion; to prevent this, users shall define two overloads instead:
class Foo
  def []=(b)
    self[0] = b
  end

  def []=(a, b)
    "#{a}, #{b}"
  end
end

x = Foo.new
x[1] = 2 # => "1, 2"
x[] = 3  # => "0, 3"

Note that #[]= can in fact be called without arguments if we use the functional syntax:
Foo.new.[]=

But by requiring at least 1 non-default positional argument for #[]= we also automatically reject code like that.

Sounds reasonable.


Priyanshu official/GOSW24

Issue Number
ISSUE #55

Describe the changes you've made
Added  Email notification feature after submitting the contact us form
Describe if there is any unusual behaviour of your code(Write NA if there isn't)
NA
Additional context (OPTIONAL)
I have Use Emailjs Which gives us More Feature and Easy to Implement
for Testing Create Id in Dashboard > https://dashboard.emailjs.com/
Adding Img of testing

Test plan (OPTIONAL)
A good test plan should give instructions that someone else can easily follow.
How someone can test your code?
Checklist

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.
[x] The title of my pull request is a short description of the requested changes.

@AVS18  Pls Review This

Ok will check buddy

@07souravkunda Ok I will do that with nodejs

@07souravkunda I am closing this I will Make new PR OF EMAIL
By implementation of NODEJS


PhpdocVarWithoutNameFixer - fix for properties only

This fixes #3112

@keradus @ntzm can you check it and update you review status?

Can this be merged?

@kubawerlos or members/maintainer please review/approve as well

Another month passed... Can someone please take a look? @keradus?

I rebased onto latest 2.12
Travis fails on something completely unrelated to this PR 😕

ping @dmvdbrugge

Thank you @dmvdbrugge.

I've update the PR and added some tests and made other minor adjustments.
Thanks @dmvdbrugge for all the work, thanks to the reviewers as well!

Thank you @SpacePossum for the merge and additional work. I apologise for being a bit unresponsive on this 😅


Gogoloot announces autoneed on BoEs even when it's disabled

I was in a ZG run where the loot is changed from master loot to group loot back and forth, and every time group loot is enabled, GogoLoot announces that I am autoneeding on BoEs even though I specifically have that setting disabled.

You aren't on latest. Make sure you update your addons daily.
https://www.getajour.com/

I'm using CurseBreaker and specifically made sure that i'm up to date - but that's from CurseForge though. It supports Github as well, but they are the same version as far as the numbering tells me?

You aren't on the latest. 1.6 is the latest.
https://www.curseforge.com/wow/addons/gogoloot
https://github.com/Gogo1951/GogoLoot/releases/tag/v1.6 - 28 days old.

Up-to-date     │ GogoLoot by aerorocks99, gogo913    │ GogoLoot-v1.6.zip

Mate, you aren't on the latest. Don't know what else to tell you. Use Ajour or WoWUp and tell me what it comes back with.

In my opinion, anyone not using Ajour is doing it wrong.
Ajour has backups and a bunch of great features to keep your addons safe.
They do it right. No clue about the tool you used, but I wouldn't trust it given it tells you that you're on 1.6 but aren't actually.

C:\Program Files (x86)\World of Warcraft_classic_\Interface\AddOns\GogoLoot\GogoLoot.toc

Does it say "## Title: |cFFFFFFFFGogoLoot|r|cFF00FF00 v1.6|r"?

Yes. I just ran force update command to update the addon and I verified what you asked in the previous post, it's still announcing I'm autoneeding on BoEs (option still disabled).

I haven't got a clue how that tool works, but I suspect poorly. Can you use Ajour?

Send me a screenshot of your addons folder? Do you have duplicate versions installed?


[Tutorial] Using Hangfire Background Jobs with Serenity

Hi Serenity contributors and members!
I've just added a Wiki entry on you to set up background tasks with Serenity: Using Hangfire Background Jobs with Serenity
Sorry to use an issue to announce this, I'll close this issue in a few days.
I hope somebody finds this useful, please give feedback if something doesn't work or is confusing.
Edward

Hi @edwardch edwardch,
following package got restored using ASP.NET  4.6.1 than .NET Core 2.2
Please advice.
1>------ Rebuild All started: Project: RioLMS.Web, Configuration: Debug Any CPU ------
1>E:\RioLMS\RioLMS\RioLMS\RioLMS.Web\RioLMS.Web.csproj : warning NU1701: Package 'Hangfire.Dashboard.Authorization 2.1.0' was restored using '.NETFramework,Version=v4.6.1' instead of the project target framework '.NETCoreApp,Version=v2.2'. This package may not be fully compatible with your project.
1>E:\RioLMS\RioLMS\RioLMS\RioLMS.Web\RioLMS.Web.csproj : warning NU1701: Package 'Owin 1.0.0' was restored using '.NETFramework,Version=v4.6.1' instead of the project target framework '.NETCoreApp,Version=v2.2'. This package may not be fully compatible with your project.
1>Transforming MVC at: E:\RioLMS\RioLMS\RioLMS\RioLMS.Web\Imports\MVC
1>Transforming ClientTypes at: E:\RioLMS\RioLMS\RioLMS\RioLMS.Web\Imports\ClientTypes
1>RioLMS.Web -> E:\RioLMS\RioLMS\RioLMS\RioLMS.Web\bin\Debug\netcoreapp2.2\RioLMS.Web.dll
1>RioLMS.Web -> E:\RioLMS\RioLMS\RioLMS\RioLMS.Web\bin\Debug\netcoreapp2.2\RioLMS.Web.Views.dll
1>Transforming ServerTypings at: E:\RioLMS\RioLMS\RioLMS\RioLMS.Web\Imports\ServerTypings
1>Done building project "RioLMS.Web.csproj".
========== Rebuild All: 1 succeeded, 0 failed, 0 skipped ==========

Hey @samdubey I have updated the guide
You need to remove the Hangfire.Dashboard.Authorization package.
I left that there by mistake, and I didn't check my warnings when testing with .NET Core.
I had only been testing in Windows, but confirmed this works when deploying to a linux docker container.
Good luck

It worked thanks


[fix] correct skips in design rule checks (test_common.py) caused by fragile whitelist_to_blacklist

Description
fix errors in private CI and Azure Pipelines caused by differences in sys.path.  This PR will enable those tests properly in those CI systems.  It deals with possible issues with user paths and symlinks, as well as erroneous inclusions of subdirectories (if they occur).
No benching necessary as it is purely testing code.

Checklist to comply with before moving PR from draft:
PR completeness and readability

[x] I have reviewed my changes thoroughly before submitting this pull request.
[x] I have commented my code, particularly in hard-to-understand areas.
[x] I have updated the documentation to reflect the changes or created a separate PR with update and provided its number in the description, if necessary.
[x] Git commit message contains an appropriate signed-off-by string (see CONTRIBUTING.md for details).
[x] I have added a respective label(s) to PR if I have a permission for that.
[x] I have resolved any merge conflicts that might occur with the base branch.

Testing

[x] I have run it locally and tested the changes extensively.
[x] All CI jobs are green or I have provided justification why they aren't.
[x] I have extended testing suite if new functionality was introduced in this PR.

Performance

[x] I have measured performance for affected algorithms using scikit-learn_bench and provided at least summary table with measured data, if performance change is expected.
[x] I have provided justification why performance has changed or why changes are not expected.
[x] I have provided justification why quality metrics have changed or why changes are not expected.
[x] I have extended benchmarking suite and provided corresponding scikit-learn_bench PR if new measurable functionality was introduced in this PR.

I'm going to merge this and will be responsible for private CI failures.


Add Proxy support

It would be nice to add socks or http proxy support to use it in countries that are not supported.
VPN already works though

export all_proxy=socks5h://<IP_ADDRESS>:1080/

Check new release and docs


Option to NOT strip comments?

Hi there,
We use comments in our AsyncAPI YAML files to track implementation of requirements.  The current application's behavior is to strip comments -- and I can't seem to find an option to NOT strip comments.
Help?

hi @philCryoport
We are using https://github.com/stoplightio/yaml for loading/saving YAML files.
We investigated to support comments, but have not found a library to parse/save YAML with support comments.
https://github.com/thim81/openapi-format/issues/60
If you find a YAML library that would support it, please let me know so we can offer support of preserving comments.


Upgrade carbon mediation to 4.6.76, synapse to 2.1.7-wso2v59 and carbon commons 4.6.26

Description:

Suggested Labels:

Suggested Assignees:

Affected Product Version:
OS, DB, other environment details and versions:
Steps to reproduce:
Related Issues:

Fixed with https://github.com/wso2/product-apim/commit/807acb16ca7d4df3ea4ae0b8ecc20b149bf72314


⚠ ClamAV has degraded performance

In e596c6f, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 199 ms

Resolved: ClamAV performance has improved in c7d7a5a.


glXSwapInterval link error

does the function needs to be retrieved with glXGetProcAddressARB?

linux is currently not yet supported


CAMEL-20754: Support for MQTT 5 Publish Properties

Description
This PR adds support for the MQTT message headers introduced with MQTT 5 (like, e.g., content-type, response-topic, message-expiry-interval, or user properties; cf. section <IP_ADDRESS> of the MQTT 5 spec) to the Paho-MQTT5 component.
To this end, support for a single new Camel message header, CamelPahoMqtt5MsgProperties, is added; the header is filled with an object containing the MQTT message headers when consuming a MQTT message, and the contents of the header are used to set the MQTT message headers when publishing a MQTT message.
Notes
The PR adds a single Camel message header for all MQTT message headers (using the MqttProperties class from the underlying Eclipse Paho library). An alternative would be to add multiple Camel message headers for the various MQTT message headers (e.g., one for the content-type, one for the response-topic, one for the message-expiry-interval, etc.). I prefer the simpler variant with a single Camel message header, but am open for the solution with multiple Camel message headers if that is the more "Camel-esque" way to go.
Target

[X] I checked that the commit is targeting the correct branch (note that Camel 3 uses camel-3.x, whereas Camel 4 uses the main branch)

Tracking

[X] If this is a large change, bug fix, or code improvement, I checked there is a JIRA issue filed for the change (usually before you start working on it).

Apache Camel coding standards and style

[X] I checked that each commit in the pull request has a meaningful subject line and body.

[X] I have run mvn clean install -DskipTests locally and I have committed all auto-generated changes

/component-test paho-mqtt5

Thanks for the fast review!


Does not work anymore

Hi,
I just tried the project and it didn't work, the web browser is appearing.
And today Facebook is not accepting the embedded browser anymore.
So, I switched to LoginBehavior.NativeOnly, and I got an error message "login attempt failed".
I have also upgrade to the last nugets/sdk/etc... same problem. (I can provide a repro).
So, if you have an idea of the problem... you're very welcome :-)

Hi @vd3d , did you make it work?
I'm facing almost the same problem.


Code review

Branch Changes

Implemented a function to add new tasks. 🥇
Implemented a function to delete tasks. 🗡
Implemented a function to edit task descriptions. 🎓
Added event listener to the checkbox (change). 👍
Updated items object's value for completed key upon user actions. 💯
Implemented a function for the "Clear all completed" button (use filter() method). 🥇
Enable to store the updated array of items in local storage. 👍

Hi @Pi1998
Approved 🍏 🟢
Your project is complete!  There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉

Highlights

Webpack setup correctly ✔✔
Todo tasks display correctly :heavy_check_mark:
UI looks good :heavy_check_mark:

Optional suggestions
Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.
Cheers, and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.

As described in the Code reviews limits policy  you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

[OPTIONAL] You have done great meeting the project requirement :+1: :+1: How about we remove this direct call to renderTasks at the end? We've already got a well-structured mechanism in place through the saveAndRender function, which handles rendering when the page loads and when changes occur. This could help streamline our code and maintain a consistent flow. :+1: :100:

// Event listener to render the tasks list when the page is loaded
document.addEventListener('DOMContentLoaded', saveAndRender);

// Initial render of tasks
- renderTasks();


Migration: Apply to MsSQL ignores identity

Add-Migration creates correct .cs
id = table.Column(nullable: false).Annotation("SqlServer:ValueGenerationStrategy", SqlServerValueGenerationStrategy.IdentityColumn)
But when update-database is executed on mssql server the generated sql statement is missing identity flag and the resulting table has no identity set on id column.
Further technical details
Microsoft.EntityFrameworkCore.Design 3.0.0-preview7.19362.6
Microsoft.EntityFrameworkCore.SqlServer 3.0.0-preview7.19362.6
Microsoft.EntityFrameworkCore.Tools 3.0.0-preview7.19362.6
Operating system: Windows 10 Build 18941.1001
IDE: Visual Studio 2019 16.2.0 Preview 4.0

@BravoSlo Please post a small, runnable project/solution or complete code listing that demonstrates the behavior you are seeing so we can fully investigate.

Found the problem, one of our assemblies, which holds base object for our models, was built using preview6 versions. After upgrading to preview7 the migrations are working as expected. Sorry for false report.


Hide mentions to order in the reference

For the time being...

Closed by https://github.com/CartoDB/carto-vl/pull/456


Reland PR #41 once Gecko's minimum rustc is 1.36

I reverted PR #41 to unblock landing PR #42 since the base toolchain Gecko builds are still on 1.35.

We can re-merge and re-land this.

https://bugzilla.mozilla.org/show_bug.cgi?id=1565193


Implement a struct for links

Right now, links are not represented by a single object/struct. We should change that.

Fixed by #3.


Job stuck in running if the meta commit is finished externally

In 2.0.0-alpha23, if a user were to finish the meta commit while a job is running, the worker does not handle it correctly and the job is stuck in the RUNNING state.  Here are the master logs for the job:
updating job info, state: JOB_STARTING
started waiting for job inputs
updating job info, state: JOB_RUNNING
finished waiting for job inputs
started processing job running
started computing skipped and deleted datums
finished computing skipped and deleted datums
updating job info, state: JOB_RUNNING
started running and collecting datum set subtasks
errored running and collecting datum set subtasks: commit 09f06683ed28422db30d4c5debe5e64f in repo regression.meta has already finished
errored processing job running: commit 09f06683ed28422db30d4c5debe5e64f in repo regression.meta has already finished
processJob error: commit 09f06683ed28422db30d4c5debe5e64f in repo regression.meta has already finished, retrying in 552.330144ms
error stack:
github.com/pachyderm/pachyderm/v2/src/internal/grpcutil.ScrubGRPC
        /Users/brendon/src/github.com/pachyderm/pachyderm/src/internal/grpcutil/error.go:16
github.com/pachyderm/pachyderm/v2/src/server/worker/pipeline/transform.(*registry).processJobRunning.func<IP_ADDRESS>
        /Users/brendon/src/github.com/pachyderm/pachyderm/src/server/worker/pipeline/transform/registry.go:576
github.com/pachyderm/pachyderm/v2/src/internal/work.(*Master).RunSubtasksChan.func1.1.1
        /Users/brendon/src/github.com/pachyderm/pachyderm/src/internal/work/work.go:179
github.com/pachyderm/pachyderm/v2/src/internal/work.(*taskEntry).runSubtaskBlock.func1
        /Users/brendon/src/github.com/pachyderm/pachyderm/src/internal/work/task_queue.go:43
github.com/pachyderm/pachyderm/v2/src/internal/work.newTaskQueue.func1
        /Users/brendon/src/github.com/pachyderm/pachyderm/src/internal/work/task_queue.go:84
runtime.goexit
        /usr/local/Cellar/go/1.16.4/libexec/src/runtime/asm_amd64.s:1371
updating job info, state: JOB_RUNNING
master done running processJobs
fatal job error: context canceled

We should probably prevent users from doing this. Users shouldn't be accessing system repos right? This is probably still worth looking into though.

I agree that I think we can get away with refusing to let users finish a commit that has provenance, but I'm not sure how we would detect that inside an RPC.  We could add a Force flag, I suppose.


Remove the references to the use of containers in the How to Create a project set document

Describe the bug
The current document makes references to use a docker container to create a project set. This is not necessary anymore and it is a possible source of confusion, so better to remove it.
Additional context
Before using a CI/CD pipeline, the code created a Docker container in the users computer. The goal was to ensure that projects were created using the same environment, with the root cause being the files created by Terraform to store the state are different between OSs. This way, creating the project set in a container ensured these files were the same.
However, the container still relied on the host machine having already set up config files for AWS, GitHub, ssh. and relied on a bash shell. If the host computer didn't have these files there will be error messages. These message actually can be disregarded, and the new project set can be created in the host machine bypassing the container.
The new CI/CD pipeline creates a container but not in the local machine but in AWS, so, there is no need to keep any reference to the docker container when creating a new project set
Definition of done

A new  How to create a project set that does not reference to start a docker container in the host machine

Document modified. New version can be found at


No dimension check on operations

I encountered a small issue when using this otherwise phenomenal package. My issue was that the package does not directly check dimensions, meaning that if padding in the form of zeros is added then the computations still run.
A small MWE: Say that H is a sparse matrix and x is a right-hand side, then
H\x						# Default SparseArrays.jl solve
H\[x;spzeros(100)]		# SparseSparse.jl solve as RHS is now sparse. This returns same as H\x due to not not checking dimensions
H\[x;sprand(100,0.1)]   # SparseSparse.jl fails the padding is not zeros

I do not know if it is intended or not, but it took me a while to realize that something was wrong with the dimensions in my code as the SparseSparse solve was not failing.

Sorry I just saw this issue you posted. I've pushed what I believe to be a fix.

Hey! No worries, the issues was just meant as a heads up 😃


feat: added drawer component

📝 Description
Added Drawer component.
Learned about some user feature requests from #2134 [Feature Request] Some Components Feature Suggestions, so I started to implement them from the simplest components (Because it can almost reuse Modal’s design and code).

Closes: #2620
Closes: #2376

⛳ Current behavior (updates)
There is currently no support for the Drawer component.
🚀 New behavior
We can have the Drawer component.
💣 Is this a breaking change (Yes/No):
No. Supports the new Drawer component, which will not have any impact on other components.
📝 Additional Information

There is currently some work yet to be completed, such as Drawer documentation and usage examples. Because I don’t know whether such code complies with the specifications of the warehouse, I initiated a PR in advance to confirm this. If all goes well I will continue with the rest of the work.
Feel free to point out my questions at any time. Of course, if you already have Drawer-related implementation plans or other questions, please let me know and I will close this PR. Thank you.
This is a continuation of the previous PR #2202.

I have read the contributing guidelines and code of conduct document.

any updates on this?

Component looks great 🤩

any updates on this?

Any updates?

@1111mp can you ping me at discord?

Hey @1111mp thanks for your contribution, we will handle this internally here https://github.com/nextui-org/nextui/pull/3986


types: trace sessions and records

Summary of this proposal
Adding types for the new trace sessions and records.
Issue(s) number(s)
https://github.com/calyptia/cloud/issues/501
Checklist for reviewer

[ ] The proposal fixes a bug/issue or implements a new feature that is well described.
[ ] The proposal has sufficient test cases that covers the changes.

[ ] If changes an API, it does not break backwards compatibility (-1 major version).

[ ] If integration is required, the proposal has integration tests.
[ ] The proposal does not break coverage stats
[ ] The proposal has the required documentation changes.

Backport

[ ] Backport to the latest stable release.

@pwhelan @nicolasparada are you guys in sync in regards to https://github.com/calyptia/api/pull/111#discussion_r937004839 ? If so, feel free to merge this patch.


Blocks topping crashes on 1.17 due to candles

in 1.17, candles were added, which can be stacked up to 4 in a single block
Light level emitted by candles depends on the amount of candles in block and their lit status, which is handled by the lambda in the candle block class looking like follows:
h = (var0) -> {
    return (Boolean)var0.c(f) ? 3 * (Integer)var0.c(e) : 0;
};

Since passed lambda is initialized inside of the BlockCandle as a static field and then referenced in Blocks class, currently burger will not resolve it properly through intercepting GETSTATIC, so default object will be returned, which will cause JSON serialization issues down the line
Simplest solution would be to hard-code light level of 12 to candles, by looking at the signature of the field get and falling back to hard-coded value. Obviously proper solution would involve looking into static fields and their initializers, but it's rather hard and requires investigating code outside of the primary blocks class

Thanks for looking into this; I was aware of the problem but hadn't had time to look into it.
I believe sea pickles behave similarly, but Burger currently just skips them and doesn't assign any light information.  That would probably be appropriate for candles as well.  Hardcoding a specific value seems less useful to me.

bandaid solution I implemented locally was simply not assigning light information if provided object is not an int, but obviously it's a hacky one and there should probably be a proper way to intercept that, but unfortunately i'm not that familiar with jawa python package (and python in general) to find it quickly


[Feature Request]:

Is your feature request related to a problem?
i would like to add some items that are not automaticaly included for example  yellorium from extreme reactors or some self made stuff
and maybe add some blocks that can be crushed like example compressed cobblestone
just examples
i want this for personal use dont know if this mod is free to use for modpacks
Solution(s)
knowledge of how to change/add item drops and blocks to crush
Describe alternatives you've considered
maybe an config .json option? may be helpful for modpacks or personal use
Mod Version
1.20.1
Mod Loader Version
1.20.1 47.1.3
Mod Loader
Forge
Additional context
i have looked in to the jar file but could not find anything about item drops  maybe im just too lost

i agree with this. theres a lot of really good not well known mods that arent included. maybe finding a way to add all existing raw ores when the mod initializes?


Update developer guide

closes #130

closes #130

Also i think the issue tag here is referencing the wrong issue tag, should be #135


Cache only option

Could be some cases where you need to rely only in the cache and not make http requests.
I added a CacheOnly option that allows it
I hope you like it
Any comments would be appreciated :)
Regards

Hi,
@victorg1991 Thanks for the p-r. It looks good, expect these two concerns for me. If you would like to fix them, I am glad to merge it.

The option name CacheOnly is a bit confusing. It could mean download it and do not cache it, which is not correct. Could you modify it to something more clear? Maybe OnlyFromCache would be better?
Please use space instead of tab as indent.

Totally agree, I will change it and submit it again :)
Thanks

@onevcat  I hope you like it now 😉

Current coverage is 73.93% (diff: 100%)

Merging #385 into master will increase coverage by 0.26%

@@             master       #385   diff @@
==========================================
  Files            14         14
  Lines          1656       1665     +9
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
+ Hits           1220       1231    +11
+ Misses          436        434     -2
  Partials          0          0

Powered by Codecov. Last update ac99e1b...8f0a261


⚠ Samsung has degraded performance

In 79ce5e1, Samsung (https://samsung.com) experienced degraded performance:

HTTP code: 200
Response time: 2251 ms

Resolved: Samsung performance has improved in 08ff08e.


Add twia12 and change structure

Changes are good so far.

Laminar is everywhere already. What about keeping it for next week?

@fhaynes @TimonPost what do you think? Should we add something about laminar?

This would be especially in case we don't have anything to say next week. Going a bit more in depth with laminar.

Yes, shaders are useful regardless of the renderer.
On Thu, Oct 25, 2018, 21:28 Joël Lupien<EMAIL_ADDRESS>wrote:

@jojolepro commented on this pull request.
In src/content/blog/twia-12.md
https://github.com/amethyst/website/pull/114#discussion_r228305092:

+## Call for participation

+We love contributions from the community, so if you see something you'd like
+to work on, don't hesitate! We are going to help you and point you into the
+right direction if something doesn't work out at first.
+
+We have tasks with different difficulty. Make sure to choose easier ones at
+first, because hard issues can become quite frustrating, especially if you
+haven't worked on Amethyst before.
+
+Here are seven issues for you to pick from:
+
+* [very easy] [Use the Transform component for all examples][is0]
+* [easy] [Doc improvements][is1] (you can add new suggestions or fix existing)
+* [easy] [Textures are dynamic unconditionally][is2]
+* [moderate] [Lighting / Pass compatibility][is3]

I can't type. I meant, "is it worth working on since there's a new
renderer being worked on".

If the renderer isn't in the score of 0.10 anymore, then it makes sense.
👍
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/amethyst/website/pull/114#discussion_r228305092, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AWFFuW7bEhqlh5yGESKVscbck0nifHoSks5uohDYgaJpZM4X4ssM
.

Rendering rewrites take time, and we wanted to have more regular releases.
On Thu, Oct 25, 2018, 21:36 Théo Degioanni<EMAIL_ADDRESS>wrote:

@Moxinilian commented on this pull request.
In src/content/blog/twia-12.md
https://github.com/amethyst/website/pull/114#discussion_r228307545:

+## Call for participation

+We love contributions from the community, so if you see something you'd like
+to work on, don't hesitate! We are going to help you and point you into the
+right direction if something doesn't work out at first.
+
+We have tasks with different difficulty. Make sure to choose easier ones at
+first, because hard issues can become quite frustrating, especially if you
+haven't worked on Amethyst before.
+
+Here are seven issues for you to pick from:
+
+* [very easy] [Use the Transform component for all examples][is0]
+* [easy] [Doc improvements][is1] (you can add new suggestions or fix existing)
+* [easy] [Textures are dynamic unconditionally][is2]
+* [moderate] [Lighting / Pass compatibility][is3]
I wasn't aware of it not being in the 0.10 version?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/amethyst/website/pull/114#discussion_r228307545, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AWFFuR8JRqjNrhJWuhRh8kHwZFiuJiL1ks5uohLQgaJpZM4X4ssM
.

Thank you for all the reviews!
bors r+


[DISCUSSION] possibly use conda-recipe-manager, bring souschef into incubation, or vendor souschef?

Is your feature request related to a problem? Please describe.
There is no problem, but we may want to try and unify dev of these tools into a single spot to get increased efficiencies in maintenance. souschef is fantastic and is fundamental to this package.
Describe the solution you'd like / Describe alternatives you've considered
Some possible options:

leave things as they are which is 100% fine
move to using conda-recipe-manager
bring souschef into incubation
vendor souschef into grayskull

Additional context
It appears that conda-recipe-manager is moving towards being more than just a parser (https://github.com/conda-incubator/conda-recipe-manager/issues/129). I do wonder how we'll square more features there with the already official garyskull project.

Hi, thanks for opening this discussion! I appreciate the opportunity to share my perspective:

Souschef was mainly created to manage the complex logic required to handle the various selectors we use as YAML comments in v1 recipes. Dealing with them was becoming quite cumbersome. However, my intention has always been to eventually phase it out as the ecosystem adopts v2 recipes more widely. With v2, the need for a dedicated parser significantly diminishes since everything will essentially be YAML + Jinja2.

Currently, I don't have the interest or time to replace Souschef for conda-recipe-manager without a clear, tangible benefit. I’m trying to be pragmatic here and avoid changes that don't provide meaningful improvements.

That said, I’m fine with bringing Souschef into incubation if the community feels it’s the right path. Alternatively, I could vendor it as an independent module, though I’m not sure there’s much advantage in doing so since a few projects appear to rely on it.

I’m open to further discussion and happy to align with whatever direction the conda-forge community feels would be best. Flexibility is key, and I trust the community's judgment! :)

These are all great points @marcelotrevisani!
The main possible benefits of moving to conda-recipe-mansger from my perspective are

less maintenance for devs (e.g., possibly you!) by centralizing around one parsing package
built-in conversion utilities from the old format (v0) to the new format (v1)
conda-recipe-manager is getting a lot of attention from various folks at anaconda
FWIW, I suspect even though the new format is formally YAML and so requires no special parser, using a dedicated library will help with certain manipulations of the recipe and so might be attractive from a maintenance point-of-view. This remains to be seen.

I am happy to contribute work moving grayskull over to CRM if people are in agreement that this is not a horrible idea.

I was just forwarded this thread by a colleague.
I want to be 100% clear that conda-recipe-manager is not intended to replace anything. We have business needs at Anaconda that warrant advanced parsing and editing capabilities of conda recipe files. We are doing this work in the open so it may benefit the community. We might be developing some tools that do things that are similar to Grayskull. I get paid by Anaconda, so I must build what the company needs.
Again, I'm not trying to dictate what conda-forge does or bifurcate the ecosystem, but there are trade-offs at play. conda-recipe-manager (CRM) is backed by a corporate entity, so there will be full time engineering support going forward.
Now that being said, I have V1 support on my roadmap. The CRM parser is already semi capable of editing V1 files, but there are limitations.
Is it silly to use CRM's parsing tools on pure YAML files that are parseable in other ways? Maybe. But there are a few main reasons I think we should continue using CRM:

Maintenance. We're going to be in a V0 --> V1 transition period for some amount of time. If we invest in tools that use CRM, we should have less maintenance cost in the long run when a full switch occurs.
CRM has a lot of tooling specific to recipe files that could make it more valuable than just using a pure YAML parser.
To Matt's point, centralizing around one library will pay future dividends. Using a YAML parser of your choosing per tool would likely incur multiple solutions to the same problems.

Am I fan that this project is all in Python? No. I kind of wish we went with Rust, but at the time I started this, I needed to prove a parser was worth the engineering time with a quick turnaround. Even if it is flawed in some aspects, I think the tooling available in CRM is a net positive for the community. A rising tide lifts all boats, after all.
@wolfv @jezdez for visibility.


Remove highContrast from FakeAccessibilityFeatures

Description
#48486 added noSuchMethod to the FakeAccessibilityFeatures class to enable adding features to this class in a non-breaking way. Changes like these require engine and framework changes, so this eases that workflow. The PR at the same time added a feature, which is now blocking the related engine change, as it previously did not require an override, but with the engine change will require an override.
This also adds documentation to the FakeAccessibilityFeatures class to make it clearer to future contributors how to successfully make this change from engine to framework. :)
Related Issues/PRs
Unblocks https://github.com/flutter/engine/pull/15343
#48418
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] I signed the CLA.
[x] I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
[x] I read the Tree Hygiene wiki page, which explains my responsibilities.
[x] I updated/added relevant documentation (doc comments with ///).
[x] All existing and new tests are passing.
[x] The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
[x] I am willing to follow-up on review comments in a timely manner.

Breaking Change
Did any tests fail when you ran them? Please read Handling breaking changes.

[x] No, no existing tests failed, so this is not a breaking change.

Now I understand where was the issue :) thanks!


Custom headers in supported loaders for Auth

What feature or change would you like to see made?
ability to add custom headers to the dicom-image-loader and volume loader to support things like JWT tokens for authentication
Why should we prioritize this feature?
I am trying to build a simple web service using cornerstone and orthanc. The orthanc server requires authentication to protect the data and in the frontend I’m loading images using the volume loader with the @cornerstonejs/streaming-image-volume-loader. The webImageLoader allows for custom headers but the volume loader and the dicom-image-loader look like they don’t. Are there ways to add custom headers to support something like JWT auth or does anyone have a recommendation on how to add auth to the system in another way?
It's easier to add authentication when building web apps that need access to protected dicom servers.
thanks!

You can take benefit from beforeSend hook in the image loader


Incorrect color conversion in utils.js

Hi Koen,
The red, green and blue values in the function rgbToXY() in utils.js need to be scaled to values between 0.0 and 1.0 before applying the gamma correction.
This can be simpele done by devide all color values by 255.
For more info see:
https://github.com/mikz/PhilipsHueSDKiOS/blob/master/ApplicationDesignNotes/RGB to xy Color conversion.md
Regards Cor

Could you make a PR to fix the conversion?


Component | Donut: Automatic label placement

Will do the following, as suggested in https://github.com/ExaForce/unovis/pull/5#issuecomment-2528948027

[ ] Leverage getCSSVariableValueInPixels to get font size based on --vis-donut-central-label-font-size and vis-donut-central-sub-label-font-size
[ ] Leverage estimateStringPixelLength to approximate text length for alignment

Maybe this other PR would be a better first step:

https://github.com/ExaForce/unovis/pull/9

Then later, on top of those changes, we could add an option to automatically calculate the offsets based on measuring/estimating text size. What do you think?

Converted this to draft PR because:

This other PR is cleaner: https://github.com/ExaForce/unovis/pull/9
We can layer on top of chose changes some additional changes that focus on measuring/approximating text size, making the changes in this PR obsolete (there would be no longer any need for, say halfDonutLabelOffsetY, since it would be automatically computed)

Researching this more to get the right terminology...

The text size estimation appears to only account for the height as the distance between the baseline and the cap height. It does not account for the descender or ascender, resulting in those things getting cut off.
I wonder what the best solution here would be...
Perhaps we could bring back the idea of halfDonutLabelOffsetY as an additional offset to be applied in addition to the measured text size?
Or maybe we can modify the text height estimation to account for the descenders and ascenders? I'm not sure what that would look like. I don't think it's as straightforward as multiplying the size by some constant, because I would guess that various fonts have different values for the ratio of the cap height (which we know) to ascender height and descender height (both of which we don't know).

Noting down the code that measured the x-height here for future reference, since we are squashing the commits and can't see the commit history:
      const fastEstimatesMode = true // Fast but inaccurate
      const fontWidthToHeightRatio = 0.52
      const centralLabelFontSize = getCSSVariableValueInPixels('var(--vis-donut-central-label-font-size)', this.element)
      const centralLabelSize = estimateTextSize(this.centralLabel, centralLabelFontSize, 0, fastEstimatesMode, fontWidthToHeightRatio)
      const centralSubLabelFontSize = getCSSVariableValueInPixels('var(--vis-donut-central-sub-label-font-size)', this.element)
      const centralSubLabelSize = estimateTextSize(this.centralSubLabel, centralSubLabelFontSize, 0, fastEstimatesMode, fontWidthToHeightRatio)

Using getBoundingClientRect achieves the desired result.

@curran Nice!
You can keep working in your donut-label-offsets branch https://github.com/ExaForce/unovis/pull/9 overriding the history.
Feel free the modify the estimateTextSize function (it's current logic is pretty simple), or maybe just add some extra padding to take into account the imprecise nature of that function. It you think that won't solve the problem, you can use  getBoundingClientRect. The downside of getBoundingClientRect is that it triggers a force reflow which is not good for performance.
Also please don't forget about the alignment

Closing in favor of https://github.com/ExaForce/unovis/pull/9


Design and implement accumulation operation

This will accept an accumulation function of type {function(<U>, <V>) : Promise.<U>}, and turn ChainedPromise.<U> into ChainedPromise.<{data: V, next: ChainedPromise}>
This is an intermediate step in implementing reduce. A missing puzzle is how to support termination from ChainedPromise

5eb2ce5834f0a0850fdae34d1e1ba51645803836


User hover card v2

Follow up for making for user hover card

add a Twitter link to the design
copy address feature

@exezbcz will drop updated design 👀
Originally posted by @yangwao in https://github.com/kodadot/nft-gallery/issues/4117#issuecomment-1316983217

I can do this once designs are in


[opencascade] Fix link the debug of freetype.dll

Describe the pull request

What does your PR fix?
Fixes #16648
Change opencascade use freetype provided by VCPKG, because the internal freetype will search debug dll which name is freetype.dll, it can't found. The correct debug dll name is freetyped.dll.

Thanks for the fix!


Some checks are lost on the unified route of the mediator coordination crate

Looks like the following checks were lost on the unified route:
https://github.com/adorsys/didcomm-mediator-rs/blob/b8fd01ebe64ea0d4da853ceb4046b5dff0bde4dc/mediator-coordination/src/web/coord/handler/mod.rs#L34-L40
Add them to stateless::process_plain_mediation_request_over_dics, so it is not lost in the future. When done, I believe function process_didcomm_mediation_request_message could be safely removed.
https://github.com/adorsys/didcomm-mediator-rs/blob/b8fd01ebe64ea0d4da853ceb4046b5dff0bde4dc/mediator-coordination/src/web/coord/handler/mod.rs#L45-L56

@IngridPuppet Apparently i did some findings with @Christiantyemele and discovered that this tacks has already been done earlier

Seems like we should begin to do and overall ticket check every end of the month, cause some tacks are been done in other related  tickets while their original ticket lie in the Todo Bar
What do you think @IngridPuppet ?

@IngridPuppet Apparently i did some findings with @Christiantyemele and discovered that this tacks has already been done earlier in another related ticket. I think i will just close the ticket if you are okay with it?

I created this ticket precisely because I noticed it was not completely done and required a dedicated ticket. Did you find the highlighted checks under stateless::process_plain_mediation_request_over_dics?

Seems like we should begin to do and overall ticket check every end of the month, cause some tacks are been done in other related tickets while their original ticket lie in the Todo Bar What do you think @IngridPuppet ?

Most of the tickets in the Todo column are not actually coding tasks, neither are they to be prioritized. Anyway, we'll discuss this point with the Scrum master.

@IngridPuppet Apparently i did some findings with @Christiantyemele and discovered that this tacks has already been done earlier in another related ticket. I think i will just close the ticket if you are okay with it?

I created this ticket precisely because I noticed it was not completely done and required a dedicated ticket. Did you find the highlighted checks under stateless::process_plain_mediation_request_over_dics?

Seems like we should begin to do and overall ticket check every end of the month, cause some tacks are been done in other related tickets while their original ticket lie in the Todo Bar What do you think @IngridPuppet ?

Most of the tickets in the Todo column are not actually coding tasks, neither are they to be prioritized. Anyway, we'll discuss this point with the Scrum master.

Yes it's good


Support batteries listed as CKB

As reported at cmd-johnson/atom-battery-status#14, not all batteries are found at /sys/class/power_supply/BAT[\d]+, but some are located at sys/class/power_supply/CKB[\d]+.

Fixed with version 0.1.5


Reorder components

This is a version of the fix people have been using to address #913. It changes the priority of the union component be be behind group, having, limit and offset.
I had to keep order after union still, so now order is after limit and offset instead of before. I don't fully understand the repercussions of this, but it works fine in my limited testing.

Well that test failing answers that question - this won't work


Have granular event details for deployment and continuous development

(this depends on Skaffold exposing an event api)
Currently as part of the Kubernetes deployment and continuous development features we do not provide any insight to the user about the state of the action beyond just printing the skaffold log output.
For example, if the build fails, the user will see the run process window complete, with no visual indication or action suggestions for the user (beyond just showing the logs):

At a minimum, with proper events exposed, we could show the completion status of the operation similar to how we do for app engine deployment in the cloud tools plugin. Here is an example of a failed app engine deployment, followed by a successful one:

Furthermore, we use the event knowledge here to print out additional information for the user to the output console in case of a failure.
todo: investigate the what can be done with the standard intellij run configuration output window - i.e. how much control do we have for displaying different completion states (@ivanporty if you have any ideas here).

wrong repo ...


scripts: check_init_priorities: use the zephyr executable file  [WAS: scripts: add dump_init_order.py]

Hi, this is a rework of  device discovery code of check_init_priorities. Instead of finding all the individual object files and find the level+piority from the section name, parse back the initlevel section from the output elf file. This means that the script is not impacted by stale files in the build directory, but more importantly it makes it work with LTO builds, where somehow the intermediate object fiels sections are completely mangled up.
While doing this, add a feature to print a human readable format of the initialization sections. This is pretty much just a friendlier version of arm-zephyr-eabi-objdump -j initlevel -j device_area -d build/zephyr/zephyr.elf. I'm using it to troubleshoot SYS_INIT order breakages, though I'm thinking one may use it in CI to compare the known sequence order of a build and catch unintended changes.
Looks something like this:
$ west build -t initlevels -p -b nrf52840dk_nrf52840 samples/drivers/led_pwm
...
EARLY
PRE_KERNEL_1
  __init_nordicsemi_nrf52_init: nordicsemi_nrf52_init(NULL)
  __init___device_dts_ord_74: clk_init(__device_dts_ord_74)
  __init_rtt_init: rtt_init(NULL)
  __init___device_dts_ord_11: gpio_nrfx_init(__device_dts_ord_11)
  __init___device_dts_ord_104: gpio_nrfx_init(__device_dts_ord_104)
  __init___device_dts_ord_112: uarte_0_init(__device_dts_ord_112)
  __init_uart_console_init: uart_console_init(NULL)
PRE_KERNEL_2
  __init_sys_clock_driver_init: sys_clock_driver_init(NULL)
POST_KERNEL
  __init_enable_logger: enable_logger(NULL)
  __init_malloc_prepare: malloc_prepare(NULL)
  __init___device_dts_ord_69: pwm_nrfx_init(__device_dts_ord_69)
  __init___device_dts_ord_19: led_gpio_init(__device_dts_ord_19)
  __init___device_dts_ord_68: led_pwm_init(__device_dts_ord_68)
APPLICATION
SMP

Very much inspired by a comment from @bjarki-trackunit on the original proposal, should be fairly easy to adapt to https://github.com/zephyrproject-rtos/zephyr/pull/61986.
Also pushed on https://github.com/zephyrproject-rtos/zephyr-testing/tree/vfabio-testing-branch
Since this now needs to work on a linked library I had to tweak the CMakeFiles a bit, and also it turns out this does not quite work with the elf file when using NATIVE_LIBRARY, although it does on the final exe. I could hack around it but I'd rather turn it off in that case right now and look for a proper solution down the road.

Very cool! Should this be added as a west target for convenience/ better discoverability?

Thanks for the feedback folks, I thought more about this and  realized that the information here works for check_init_priorities.py, and does not require the hack for detecting sub builds plus it works with LTO files (which turns out the corrent code does not).
So I'm taking a 180 on this one, going to rip the file scanning code off check_init_priorities.py, replace it with this one and I'll integrate the functionality of this check_init_priorities.py itself.
@kartben yes will look into adding a target

Update: this is now a check_init_priorities update with the "dump initlevels" as a feature and cmake target. Ran it on CI as well, ended excluding it when using CONFIG_NATIVE_LIBRARY (i.e. natsim) to avoid making a giant mess with CMake to make it run on the right binary at the right time but I'll look into fixing that down the road.

just one comment: since this is now using the Zephyr elf file, shouldn't we re-use/extend elf_parser.py?

Yeah I initially started building on top of it and eventually realized that there was going to be pretty much no overlap. Despite the generic sounding name that's very much specialzied on processing the dependency graph, I found I was making a mess of it with no deduplication savings so I went with a separate container class.

Minor nit: "zephyr" is misspelled in the commit message.

Yeah found a couple more typos as well in there :-) sorry... fixed

Thanks folks, sorry about the typos, need to remember doing a spell checker pass on my commit and error messages.

Ok small update now that I managed to get my hands on an armclang file, there's two problems:
1 - the init data is spread into multiple sections, looks something like:
        0x000021d8 - 0x00002200 is init_103
        0x00002200 - 0x00002208 is init_104
        0x00002208 - 0x00002208 is init_end

2 - the symbols for the init section boundaries are not there, looks like the linker resolved and ate them up
So [1] is easy to fix and I've actually decided to integrate the change regardless: I've just changed _initlevel_pointer to resolve the section for every pointer individually, which is actually nice regardless cause it means the script does not need to look for a specific section name to find the data.
[2] is a more of a problem though, if the armclang linker cannot be configured to omit those symbols (some debug option?) I think I'll have to either guess the symbols from those init_103 strings (is that dependable?!) or just disable this for armclang entirely.
Waiting for further feedback from @tejlmand.

        0x000021d8 - 0x00002200 is init_103
        0x00002200 - 0x00002208 is init_104
        0x00002208 - 0x00002208 is init_end

Wonder how the linker ended up with those now that I looked into it, from the content these seems to be 103: PRE_KERNEL_1 and 104: PRE_KERNEL_2.
Was trying to correlate those in the code but maybe it's better to just shut this off for armclang for the moment. Waiting to hear if it works for ARCMWDT at least.

Added a conditional to skip this for armclang binaries, no point blocking on that, it can be fixed down the road by someone that have access to that compiler.

@evgeniy-paltsev thanks for testing this
@tejlmand can we go ahead with this one excluded on armclang for now? Then you folks with access to that compiler can look into this whenever you have time

Reworked the "no armclang support" patch, it now works by:

not defining the initlevels target
adding a Kconfig dep instead


500 Internal error when migrating from another self-signed HTTPS Gitea server

Gitea Version
1.15.4
Git Version
2.33.1
Operating System
Linux amd64
How are you running Gitea?
Prebuild amd64 binary from https://dl.gitea.io/gitea/1.15.4/gitea-1.15.4-linux-amd64
Database
SQLite
Can you reproduce the bug on the Gitea demo site?
No
Log Gist
No response
Description
I have setup Gitea ServerA with HTTP (localhost only, on port 3000) and use Nginx reverse proxy to provide both HTTP and HTTPS  (on port 80 and 443) to other clients. The HTTPS certificate in Nginx is a self-signed one and I have set "http.sslVerify = false" in client git config to skip the certificate error and access the repo on ServerA. In ServerA app.ini, the ROOT_URL is https://serverA/.
And now I am trying to setup another Gitea ServerB to mirror/backup some repos from ServerA. ServerB is HTTP only (on port 3000) and I am add new migration repo mirrored from ServerA.
Scenario 1: ServerA HTTP/HTTPS both accessible; ServerB git user doesn't have http.sslVerify = false
a) Migrating from HTTPS fail, with error: Migrating from https://serverA/user/repo.git failed.
However, the migration repo in ServerB is created. It is empty and accessing it results in 500 Internal Server Error.
b) Migrating from HTTP fail, with error: Migrating from http://serverA/user/repo.git failed. No migration repo created in ServerB.
Scenario 2: ServerA HTTP/HTTPS both accessible; ServerB git user has http.sslVerify = false
a) Same as S1.a.
Migrating from HTTPS fail, with error: Migrating from https://serverA/user/repo.git failed.
However, the migration repo in ServerB is created. It is empty and accessing it results in 500 Internal Server Error.
b) Migrating from HTTP succeed, clone URL is actually https://serverA/user/repo.git
Scenario 3: ServerA HTTP forcefully redirected to HTTPS; regardless of ServerB git user's http.sslVerify setting
a) Same as S1.a.
Migrating from HTTPS fail, with error: Migrating from https://serverA/user/repo.git failed.
However, the migration repo in ServerB is created. It is empty and accessing it results in 500 Internal Server Error.
b) Similar to S1.a.
Migrating from HTTP fail, with error: Migrating from http://serverA/user/repo.git failed.
However, the migration repo in ServerB is created. It is empty and accessing it results in 500 Internal Server Error.
My guess is that Gitea and git has separated function to access HTTPS repo. Setting git config http.sslVerify only bypass the SSL check in git HTTPS function but there is no way to bypass Gitea's.

When migrating/mirror repo in HTTP, Gitea will access the serverA using HTTP (thus no SSL involved), and the find the serverA advertises ROOT_URL=https://. So it calls git clone using https:// and therefore git config http.sslVerify would make it work.
In other cases, Gitea must migrating/mirror from HTTPS, but encounters self-signed certificate, so it fails. The problem is that it still make an empty repo on ServerB and report 500 Internal Server Error when someone tries to access it.

My suggestion is to add a service configuration in app.ini to allow Gitea to ignore HTTPS certificate error, something like git config sslVerify=false does.
I searched for potential solution and got this Go example :
package main

import (
    "fmt"
    "net/http"
    "crypto/tls"
)

func main() {
    http.DefaultTransport.(*http.Transport).TLSClientConfig = &tls.Config{InsecureSkipVerify: true}
    _, err := http.Get("https://golang.org/")
    if err != nil {
        fmt.Println(err)
    }
}

I understand that this option is insecure and dangerous but it would be nice to have it configurable in app.ini. Thanks!
Screenshots
No response

You can add your self-signed CA to you system root CA, then the CA can be trusted.

Just found, SkipTLSVerify will be introduced in v1.16, so it's a feature which has been implemented in v1.16. I think we can close this now.


Correction for raw affiliation Faculté de Pharmacie Université de Montréal C.P. 2940 Chemin de Polytechnique  Montreal Quebec H3C 3J7 Canada

Correction needed for raw affiliation Faculté de Pharmacie Université de Montréal C.P. 2940 Chemin de Polytechnique  Montreal Quebec H3C 3J7 Canada
raw_affiliation_name: Faculté de Pharmacie Université de Montréal C.P. 2940 Chemin de Polytechnique  Montreal Quebec H3C 3J7 Canada
new_rors: 0161xgx34
previous_rors: 05f8d4e86;0161xgx34
works_examples: W4372348743
contact: 671e4b62b00f3ccd2f577011b7bc55aa:5af5eb61c2bd9ef2b7b429 @ polymtl.ca

This issue was accepted and ingested by the OpenAlex team on 2024-11-01. The new affiliations should be visible within the next 7 days.


Long, sometimes endless loading in message list

When I login, from time to time (I would say one in five times I open the app) I get this "loading" screen.  Sometimes it lasts for 5 seconds, sometimes for 30 seconds.
Restarting the app (force quit and reload) fixes it immediately 100% of the time, so I am sure there is nothing wrong on server side.
Video is attached, I could not upload the mp4 file directly, so it is zipped here.
Screenrecorder-2020-03-26-22-04-19-301.mp4.zip

Hi @maltokyo, thanks for the report!
I don't have a clear diagnosis for this yet, but we know of one issue that could cause long wait times in hard-to-reproduce ways.
@gnprice or @ray-kraesig, I think https://github.com/zulip/zulip-mobile/pull/3841 is getting close to mergeable. I'm not saying this is definitely the solution to this problem, but it might be, and it would be a nice thing to eliminate as a possible cause.

Great. Thank you. The other thing I can say is that recently when it happens on mobile app I've always had web version nearby. And it was always super responsive without issue while the mobile app was was behaving like this. Both on the same WiFi network. So again, I did everything I could to isolate it to be sure it's an issue with the app.
Any log I can attach?

#3841 was merged today, so it should be out in the next beta, probably next week; you can watch for that to be released here in the Zulip developer community, but I'll post again here when that happens, if I remember. And, in any case, we'll keep this issue open until we're sure it's been fixed.
Or, if you'd like to test it sooner, you can build and run the app from the latest code on the master branch, following these instuctions.

Thanks a lot @chrisbobbe ! So nice to hear  responses like this and motivates people to submit issues more when they find. I'll try the beta next week or when available.

So, there was a beta release yesterday, the 13th, but it only had one cherry-picked fix, deemed critical because it caused a total crash of the app on startup, so it didn't include the attempted fix for this issue. @gnprice, we'll plan to do a regular beta release with everything on master this week, I think, right?

Hi @chrisbobbe & all
Here are some more videos.  Strange things still happenning, it seems even more frequently now with the latest update.  I updated two days ago.

Here is more of the issue above:

https://www.youtube.com/watch?v=1RqD1X-9j1Y&feature=youtu.be

I have additional issues also with latest couple of versions, including latest version.  Sometimes I get spinning ball next to the post.  When I go out of it and back in, it is posted, and spinning ball stays, and posts again!  Here it is in action:

https://www.youtube.com/watch?v=rZMjHYoRFhE&feature=youtu.be

And another issue, this I noticed first time only with the latest version, some jittering posts:

https://www.youtube.com/watch?v=Qvpjr9kSCmY&feature=youtu.be
These videos are "unlisted", and I will delete soon, please acknowledge that you have seen the problem(s) enough for me to bring them down.

Thanks for the additional reports, @maltokyo!

One thing that would be very helpful to know for this issue, and I'm seeing that I didn't ask for this specifically, above, is if you're pretty confident that the loading screen just never goes away, or if it eventually goes away after 30 seconds or so. I know the effect on users is about the same, if it causes enough frustration that you have to quit and relaunch the app to fix it, but I ask because it would a helpful clue for debugging, if it isn't fixed in the (hopefully!) next beta release. Could you leave it on that screen for 5 or 10 minutes and see if it's still there?
This looks like it's under the umbrella of https://github.com/zulip/zulip-mobile/issues/3881, specifically, https://github.com/zulip/zulip-mobile/issues/3731. An "outbox message" is a message that you've just pressed "send" for, but the server hasn't acknowledged it yet. We show the message anyway, so the experience of sending messages feels quicker, but apparently we don't correctly handle failures to send.
This looks like https://github.com/zulip/zulip-mobile/issues/3869.

Hi @chrisbobbe
Regarding #1 I've frequently left it for some minutes like that (not 5 mins for sure, but at least 1:30 - 2:00). For me it doesn't resolve itself and I just restart the app which fixes it 100% of the time. Next time it happens I'll leave it for 10min, see how it goes, and report back.
Does the app make any logs at all, that would be useful for you guys? I'm happy to send if you let me know how to access.

There's been another report of something that looks quite similar, also on Android, here.
@gnprice, @ray-kraesig, do you know a way to filter our Sentry logs to see errors whose first occurrence is recent, and that only happen on Android?

Hmm, @gnprice, @ray-kraesig, take a look at this filtering/sorting in Sentry.
That's a summary of events that have occurred at least once in the last 14 days, where the first-seen date for that class of events (I know we have some open issues about disaggregation, like #3864) is within the last three weeks, sorted by frequency.
The first four, which we addressed as a P0 fix this week, were Unable to parse color from string: #NaN. It's plausible that this load-screen issue is also a symptom; if so, it would be fixed by upgrading to 26.27.150 (GitHub, CZO); I believe that's in production on iOS and Android.
However, there's an interesting result that's popping up, and is showing a clearly upward trend in occurrences:

The error message (which, again, we haven't seen in Sentry before) is "RuntimeException: Probable deadlock detected due to WebView API being called on incorrect thread while the UI thread is blocked."

@maltokyo , are you continuing to see this symptom?
I have a hypothesis that it might be tied to the Chrome version used for the WebView, in part because the timing (especially in the graph Chris posted just above) lines up with when a new Chrome release came out. If you are still seeing the issue, you might be able to help us pin that down.
Two quick questions first:

What Android version are you using?
What version of Chrome is installed on your device? (You can determine this by finding Chrome in the Play Store app.)

Then, if you're up for an experiment: I would be very interested in the results if you try opting into the "dev" channel of Chrome (currently Chrome 84) for your WebViews. Instructions here:
https://chromium.googlesource.com/chromium/src/+/HEAD/android_webview/docs/channels.md
and a description of what the channels mean is here:
https://support.google.com/chrome/a/answer/9027636?hl=en
It might be a bit fiddly to set up, depending how much you've poked at the guts of Android before; I'd be quite happy to help you through it over on chat.zulip.org, either in #mobile or in PMs. It's straightforward to change back whenever you want to stop the experiment.

Hi @gnprice
Amazingly (I'm not sure if there was a recent update?) I don't seem to experience this at the moment. Let me test a few things and see if I can see why. But for the past one or two weeks I do not remember it happening. I'm on the version updates 13th April.

This issue also affects (all of?) our staff in the company. Both on Android as well as iOS. We do have some streams that load, but most are just (at least seemingly) loading forever. The ones that do load only have very few messages in them. The desktop and web clients are working perfectly.
Previous messages in this ticket are now weeks old already. Has there been any movement or the possibility to get/test a beta release?

@pohutukawa Thanks for the report! Please file it as its own issue so we can debug it properly -- it sounds like it's a different issue from this one, and I have some followup questions I'll be interested in asking to learn more about what you're seeing.

This issue is now back for me too. I didn't experience it for some time
until the last few days. Same as before.
On Sat, 13 Jun 2020, 01:08 Greg Price<EMAIL_ADDRESS>wrote:

@pohutukawa https://github.com/pohutukawa Thanks for the report! Please
file it as its own issue so we can debug it properly -- it sounds like it's
a different issue from this one, and I have some followup questions I'll be
interested in asking to learn more about what you're seeing.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/zulip/zulip-mobile/issues/4033#issuecomment-643516383,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAKS7W6R2TVMTMXB7WMHCQDRWKYNRANCNFSM4MFOJ6JA
.

@gnprice Done in #4156.

@maltokyo Very interesting. Thanks for the update, and sorry the issue seems to be back.
I asked some questions at https://github.com/zulip/zulip-mobile/issues/4033#issuecomment-622173988 that may help us debug the issue. Now that you're seeing the issue again, I'd be very curious for the answers.

Hi @gnprice Please find below, sorry for the delay.

Two quick questions first:

What Android version are you using?

MIUI 11, based on Android 10 (Xiaomi, latest updates)

What version of Chrome is installed on your device? (You can determine this by finding Chrome in the Play Store app.)

Version 83.0.4103.106 (updated on 15th June)

Then, if you're up for an experiment: I would be very interested in the results if you try opting into the "dev" channel of Chrome (currently Chrome 84) for your WebViews. Instructions here:
https://chromium.googlesource.com/chromium/src/+/HEAD/android_webview/docs/channels.md
and a description of what the channels mean is here:
https://support.google.com/chrome/a/answer/9027636?hl=en
It might be a bit fiddly to set up, depending how much you've poked at the guts of Android before;

I tried this, however, due to the fact that I have a "work profile" installed, it will not let me select the second line in this screenshot, any way around it?

MIUI 11, based on Android 10 (Xiaomi, latest updates)

Cool -- so that's consistent with our guess that this symptom may correspond to the error #4051 we're seeing reported as an exception, because that error is only possible on Android 10+. (Though something like half our Android users are on Android 10 -- 38% when I last looked a couple of months ago -- so one data point isn't super strong confirmation by itself.)

Version 83.0.4103.106 (updated on 15th June)

That's helpful, thanks.

I tried this, however, due to the fact that I have a "work profile" installed, it will not let me select the second line in this screenshot, any way around it?

Hmm. I don't know very much about how a "work profile" works, but I would guess that this means that this is a device managed by your employer's IT department, and it's saying that changing the Chrome version to be used for webviews is something off-limits for you to do yourself -- that it can only be done by someone with those IT privileges. (Which is pretty reasonable; keeping everyone's configurations uniform helps keep down the complexity of debugging the IT staff may have to do.)
If you have a good relationship with someone in that department who might be up for helping you debug this issue you're seeing in Zulip, you might ask them to make this change for you. I would certainly be grateful to see the results.
If it helps, the version I'm most interested in -- Chrome 84 -- is now in the Beta channel, so you can use that instead of Dev. Slim chance that'll give any different result on this screen; but if you do ask someone in your IT department for help, they might feel more OK about a beta version than a dev version.

@maltokyo One other question for you (or pair of questions), which I should have asked sooner but I see I neglected to!

Are you seeing this on Zulip Cloud (zulip.com / zulipchat.com), or on a server hosted elsewhere (like within your company/organization)?
If the latter, what version of the Zulip server is it running? You can find out the exact version with a command like this one (just replace chat.zulip.org with the domain from your server's URL):

$ curl -s https://chat.zulip.org/api/v1/server_settings | jq -r .zulip_version
3.0-rc1-131-g5d91cfbbb7

Hi @gnprice
I only have tried with my own (debian 10, 32GB RAM, VPS) server using docker version of Zulip, but I can give it a go with the main zulip chat site as well.
Below is the outcome of running that command on my server (domain replaced).
# curl -s https://z.MYDOMAIN.com/api/v1/server_settings | jq -r .zulip_version
2.1.4

That's helpful information, thanks.

2.1.4

(Unrelated to this issue, I'd recommend you upgrade the server -- there was a security release last month.)

@maltokyo Have you been continuing to see this symptom?
We've been seeing in Sentry a much lower rate of the exception #4051 which looked like it might have been related, ever since around the time of the last few comments on this thread. So I'm hoping that you've also stopped seeing this, or at least that it's become rare.

We'd marked this as P1 last year because it's a bad symptom, and it looked like it might be related to #4051 which was an exception report we were getting from a lot of users so it seemed likely that a lot of users were seeing this.
Since then #4051 has become infrequent, and we haven't had any reports of this from additional users, so that no longer seems likely.

Hi Greg
It's become rare indeed but still happens. I'd say once in 10-20 times I
open the app. Very strange.
On Wed, 14 Apr 2021, 02:44 Greg Price, @.***> wrote:

We'd marked this as P1 last year because it's a bad symptom, and it looked
like it might be related to #4051
https://github.com/zulip/zulip-mobile/issues/4051 which was an
exception report we were getting from a lot of users so it seemed likely
that a lot of users were seeing this.
Since then #4051 https://github.com/zulip/zulip-mobile/issues/4051 has
become infrequent, and we haven't had any reports of this from additional
users, so that no longer seems likely.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/zulip/zulip-mobile/issues/4033#issuecomment-819141789,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAKS7W6Z7LUJFHGNPHVQZQ3TITQO7ANCNFSM4MFOJ6JA
.


Not able to build container docker build -t azure-sphere .

Hello,
While trying to build container, I am getting below error.
Azure Sphere Installation getting cancelled. Note that I already have Azure Sphere SDK installed on my laptop.
Environment:
Machine: Laptop
OS: Windows10
Docker: v20.10.5
Ran the command from cmd prompt (admin privilege) and powershell (admin privilege).

[5/7] RUN /bin/bash ./install_azure_sphere_sdk.sh:
#9 1.517 logname: no login name
#9 1.566 Downloading Azure Sphere SDK tarball from 'https://aka.ms/AzureSphereSDKDownload/Linux'...
#9 1.570 Installing Azure Sphere SDK version <IP_ADDRESS>749.
#9 80.95 Validating signature.
#9 81.69 Installing SDK files.
#9 84.60 chmod: cannot access '/opt/azurespheresdk/Tools/azsphere_connect.sh': No such file or directory
#9 96.96 ERROR: Could not mark file /opt/azurespheresdk/Tools/azsphere_connect.sh as executable. Please try again or visit https://aka.ms/AzureSphereSDK/Linux for more information.
#9 96.97 Cancelled during installation, rolling back to clean state.
#9 96.98 Removing installed files.
#9 96.98 Removing Azure Sphere CLI from PATH, if present.
#9 96.99 Removing default udev configuration, if present.
#9 97.00 Azure Sphere SDK installation cancelled.
#9 97.00

executor failed running [/bin/sh -c /bin/bash ./install_azure_sphere_sdk.sh]: exit code: 1
D:\AzureSphere\EdgeImpulse\example-azure-sphere-mt3620>

Hi @jeevannagvekar sorry I never saw this ticket. Even though I'm using an install script for a specific version it just downloads the latest SDK instead, which is a moving target, so no way to write a build script that just works. I've reached out to Microsoft to see if there's a way to properly pin this!

Hi, updated the install script now!


Update PI profile when grant information is incorrect

From Florence:
I approved the last unapproved PI profile this morning which was from Leigh Charvet. They had "Pending" in the award info. But, I was hoping the system would find Leigh and add their ORCID ID which is not currently in their PI profile. They have 3 awards in the CIC. Two have the same name but are different numbers.
The result is an additional record that just has "Pending", as was submitted, in the record.

For now, approval is all-or-nothing, so please do not approve surveys with incorrect information. We will make the processing more bulletproof in the future.


[URGENT] Update the count of integrations.

Master is currently broken.
Followup of 1303248b0b65096cfdc972afaafe2108e2a10364
@timabbott @gnprice
@Rishabh570 FYI

Thanks for spotting this!
I've pushed a fix that cuts the number out of the test entirely.

Fixed in https://github.com/zulip/zulip/commit/ccb8c79edb4bd2710b9e10ef33b7c354ce4d7d01. Thanks @gnprice


Initial implementation for influxDB connector

Purpose
InfluxDB connector will make it possible for users to insert, update or insert data into a InfluxDB
measurement and reading and deleting data from a influxDB measurement.
Goals
This connector allows user to store data in a influxDB database.
Approach
Influxdb-java version 2.14 is used for this connector.
User stories
Userstory for InfluxDB :
https://docs.google.com/document/d/1FWatYFcSv16n2qW2Cx1aZeho5zhyAxCwdZG1zcq-_m8/edit
Release note

Brief description of the new feature or bug fix as it will appear in the release notes

Documentation

Link(s) to product documentation that addresses the changes of this PR. If no doc impact, enter “N/A” plus brief explanation of why there’s no doc impact

Training

Link to the PR for changes to the training content in https://github.com/wso2/WSO2-Training, if applicable

Certification

Type “Sent” when you have provided new/updated certification questions, plus four answers for each question (correct answer highlighted in bold), based on this change. Certification questions/answers should be sent to<EMAIL_ADDRESS>and NOT pasted in this PR. If there is no impact on certification exams, type “N/A” and explain why.

Marketing

Link to drafts of marketing content that will describe and promote this feature, including product page changes, technical articles, blog posts, videos, etc., if applicable

Automation tests

Unit tests

Code coverage information : 84%

Integration tests

Details about the test cases and coverage

Security checks

Followed secure coding standards in http://wso2.com/technical-reports/wso2-secure-engineering-guidelines? yes
Ran FindSecurityBugs plugin and verified report? yes
Confirmed that this PR doesn't commit any keys, passwords, tokens, usernames, or other secrets? yes

Samples

Provide high-level details about the samples related to this feature

Related PRs

List any other related PRs

Migrations (if applicable)

Describe migration steps and platforms on which migration has been tested

Test environment
JDK versions : JDK 8
operating systems : ubuntu 16.04 LTS
databases : InfluxDB 1.7.1
Learning
https://docs.influxdata.com/influxdb/v1.7/introduction/getting-started/
https://github.com/influxdata/influxdb-java

@malkisandamini  Please fill in the PR template with a few details on what this PR about,
Purpose, Approach, User stories, Automation test, etc...

@malkisandamini, seems some of build files are added and not deleted in the last commit. Please do the needful.
Also please follow git commit practices from here on out, https://chris.beams.io/posts/git-commit/

Add the docs/licnese.md file, Please build the mkdocs site locally and test is everything is available.


Restore legacy support

Revert latest version. This breaks the support for the node versions 4 and 5.

Coverage remained the same at 100.0% when pulling 95b3732f22332ad5ee2499bd090145d754d07e53 on restore-legacy-support into ea7e1a887aaed0c2c12d8e5aa8242c555a22c1e8 on master.


cmd/go: unuseful error message when solving dependencies

The build is failing with "error loading module requirements" without any insights on why module requirements didn't load. It also doesn't give any helpful details whether it was due to a third party library or not.
$ go run .
go: finding github.com/GoogleCloudPlatform/cloudsql-proxy/proxy/dialers/postgres latest
go: finding github.com/GoogleCloudPlatform/cloudsql-proxy/proxy/dialers latest
go: finding github.com/GoogleCloudPlatform/cloudsql-proxy/proxy latest
go: finding github.com/GoogleCloudPlatform/cloudsql-proxy latest
go: finding golang.org/x/oauth2/google latest
go: finding golang.org/x/oauth2 latest
go: finding golang.org/x/net/context latest
go: finding golang.org/x/net latest
go: finding cloud.google.com/go v0.34.0
go: finding golang.org/x/net v0.0.0-20180724234803-3673e40ba225
go<EMAIL_ADDRESS>unknown revision v0.34.0
go: finding github.com/golang/protobuf v1.2.0
go: finding golang.org/x/sys v0.0.0-20190215142949-d0b11bdaac8a
go: error loading module requirements

It looks like the error was buried in the rest of the chatter:
go<EMAIL_ADDRESS>unknown revision v0.34.0

This is related to #30661, but not quite a dup. But CL 166984 should fix this when it finally gets submitted.

This seems like a dup of #26152: one of the lines was useful, but it was buried in less-useful chatter.


Rename build conversions, so they have different names to core conven…

…tions
Reviewer checklist

[ ] Read the contributing guide
[ ] PR should be motivated, i.e. what does it fix, why, and if relevant, how
[ ] Ensure relevant issues are linked (description should include text like "Fixes #")
[ ] Ensure any appropriate documentation has been added or amended

Coverage: 92.8%. Remained the same when pulling 047a307e5f33d9cb823d0ce3671adc590377809d on rename-conventions into 5847650fd805e2853b9d2c622dfb5a43d18d4f21 on main.


Subsequent calls to DNS Client query fails

Subsequent calls to DnsClient fails . Both tests pass independently, but when I run the whole suite the second one timeouts. The following code was used to reproduce the issue using the latest alpha ==2.0.0a2. Python version is 3.9.5
import unittest
from unittest import IsolatedAsyncioTestCase

from async_dns.resolver.client import DNSClient
from async_dns.core import types, Address

class TestDnsResolver(IsolatedAsyncioTestCase):
    async def test_resolve_mx(self):
        dns = DNSClient()
        resolved = await dns.query('gmail.com', types.MX, Address.parse("<IP_ADDRESS>"))
        self.assertEqual(5, len(resolved.an))

    async def test_resolve_mx2(self):
        dns = DNSClient()
        resolved = await dns.query('gmail.com', types.MX, Address.parse("<IP_ADDRESS>"))
        self.assertEqual(5, len(resolved.an))

Unclear to me why this happens, but I noticed the CallbackProtocol does not implement the methods error_received and connection_lost exposed at the example on python docs. Can this behaviour be related to UDP socket handling, maybe some disposal routines or anything like that?

It seems that IsolatedAsyncioTestCase creates a new event loop for each test case.
async_dns shares the same protocol for all clients, so it runs into trouble when the dispatcher which holds the protocol is created with an event loop and the new client is created with another.
https://github.com/gera2ld/async_dns/blob/fe2ff8c74861dcbfb16eb0757f0a5ee6f141486b/async_dns/request/udp.py#L64-L65
In your case, simply adding a tearDown method would help:
from async_dns.request.udp import Dispatcher

# ...
    def tearDown(self):
        Dispatcher.data.clear()

I guess the dispatcher / protocol should not be destroyed after each request internally. So maybe I should add this to async_dns.request.clean so that you can call request.clean explicitly when you need a clean initial state.

Looks like the tearDown works, I agree it would be nice to have this clean up routine in cases like that.

Following on this, when I ran several tests, I face some ResourceWarnings, looks like the socket was not closed, probably the clean up routine should take care of closing it.

Normally this should not happen because we don't force clear cache this way. Anyway I will close the socket in request.clean.

In the latest alpha ==2.0.0a3, you should use request.clean instead:
from async_dns.request import clean

# ...
    def tearDown(self):
        clean()


Failed to create URL with base address contained port 80

Input
new URL('/part', 'http://servername:80/app');

Result in error: 'URL unable to set base http://servername/app due to http://servername:80/app'
Another problem is that the address must be lowercase due to case-sensitive string comparison, i.e. I can not write
new URL('/part', 'http://SERVERNAME/app');

Well, origin (second argument) should not contain any path. This is an error on your side even if some browsers allows it.
Second, domain name are lower-cased, this is normal behavior...

Looking at the https://developer.mozilla.org/en-US/docs/Web/API/URL article and Usage example we will see that the base part may not be the origin but any base address:
const url = new URL('../cats', 'http://www.example.com/cats');

Casting a domain name to lowercase before creating a URL object is not a problem, but again it will be more convenient to ignore case sensitivity when building URLs
var polyfillURL = function() {
  var _URL = global.URL;

  var URL = function(url, base) {
      if (base && (global.location === void 0 || base !== global.location.href)) {
        ....
        try {
           if (baseElement.href.indexOf(base.toLowerCase()) !== 0) throw new Error(baseElement.href);
        } catch (err) {
          throw new Error('URL unable to set base ' + base + ' due to ' + err);
        }
      }