108 check change units in p foresce lc per catchment reclass cat$total prms area

Added new functions in 2_process/src/area_diff_fix.R to [1] check the area difference between gpkg catchments (p1_PRMS_catchments_edits_sf) and comid area aggregation in nlcd lc dataset using a specified km2 diff threshold; [2] Build a new shpfile with nhd-based catchments for the PRMS_segid that require new catchments polygons.
Much of the updates are also created in 2_process.R, where important new targets are added:
p2_PRMS_segid_special_handling_list : list of PRMS_segid requiring new catchment polygon assignment w/ nhd.
p2_nhd_catchments_dissolved_sf : new sf object of nhd catchments dissolved to PRMS scale.
p2_FORESCE_LC_per_catchment_fixed : extraction of LC rasters from FORESCE lulc model using new nhd-based catchment shp and proportion calculation
p2_FORESCE_LC_per_catchment_fixed_reclass_cat : reclassification of proportions for fixed PRMS_segid. (this is not done earlier because original reclassed LC proportion datasets are still scaled at hru level).
Utimately the fixed and original lc proportions datasets for FORESCE are rebinded into target p2_FORESCE_LC_per_catchment_reclass_cat.
Please note. These numerous targets were added to 2_process.R for sake of time. If time allows, process this catchment fix in a separately sourced R script/function.
New scatterplot after fixing (code below):

@jds485 , I have not updated target p2_FORESCE_LC_per_catchment_reclass_tot - which uses the recursive fun - based on these changes. I'll let you take that over.
The Rdsalt target also uses the raster extraction and proportion calc function using the gpkg catchment target (p1_catchments_edited_sf). This polygon fix was not made for the rdsalt target because this target does not get appended to another nhd-based dataset such as nlcd. We should decide whether we want to stick with the gpkg shp as the catchment boundary for rd salt, or if we want to dissolve all nhd catchments to PRMS scale for all PRMS_segid if we want more granular rdsalt measurements.

library(dplyr)
library(tidyverse)
library(nhdplusTools)
library(mapview)

# Comparing PRMS NLCD proportions dataset wih FORESCE
targets::tar_make(p2_PRMS_NLCD_lc_proportions_reclass_cat)
targets::tar_make(p2_FORESCE_LC_per_catchment_reclass_cat)
targets::tar_load(p2_PRMS_NLCD_lc_proportions_reclass_cat)
targets::tar_load(p2_FORESCE_LC_per_catchment_reclass_cat)

# subset/filter and mutate. We choose year 2000 for FORESCE and 2001 for NLCD
##2000
l1 <- p2_FORESCE_LC_per_catchment_reclass_cat[[7]] %>%
  #  select(PRMS_segid, Year, everything(), -hru_segment) %>%
 # mutate(total_PRMS_area_km2 = total_PRMS_area/10^6) %>%
  select(PRMS_segid, total_PRMS_area_km2)
## 2001
l2 <- p2_PRMS_NLCD_lc_proportions_reclass_cat[[1]] %>%
#  rename(total_PRMS_area_km2 = AREASQKM_PRMS) %>%
  # select(PRMS_segid, Year, everything(), -AREASQKM_PRMS) %>%
  select(PRMS_segid, AREASQKM_PRMS)

# Merge l1 and l2 and calculate difference for each PRMS SEGMENT
df <- l1 %>% left_join(l2, by = 'PRMS_segid') %>%
  rename(PRMS_area_km2_FOR = total_PRMS_area_km2, PRMS_area_km2_NLCD = AREASQKM_PRMS) %>%
  mutate(ab_diff = abs(PRMS_area_km2_FOR - PRMS_area_km2_NLCD)) %>%
  mutate(ab_diff_categorized = factor(case_when(ab_diff > 50 ~ '>50 km2',
                              ab_diff > 10 ~ '>10 km2',
                              ab_diff > 5 ~ '>5 km2',
                              ab_diff >1 ~ '>1 km2',
                              TRUE ~ '< 1 km2'),
                              levels = c('< 1 km2', '>1 km2', '>5 km2', '>10 km2', '>50 km2')))

# Plotting
scatterplot1 <- ggplot(df, aes(x = PRMS_area_km2_FOR, y = PRMS_area_km2_NLCD))+
  geom_point(aes(color = ab_diff_categorized))+theme_bw()+
  labs(caption = 'Scatter plot of PRMS area in the NLCD dataset versus FORESCE.\n Point colored by their difference categories')+
  theme(plot.caption = element_text(hjust = 0.5))
scatterplot1

Read to be merged. Awaiting preceeding PRs before pushing.

This is ready to merge following latest updates to main.
Area check still the same graphic as above:


Adding bower support so that we can use this in client side.

Adding bower support so that we can use this in client side.

@aceakash please review.
Thanks.


chore: Use same type in contexts example

Why:

This PR changes the input type of the last example to number
What's being changed (if available, include any code snippets, screenshots, or gifs):

Check off the following:

[x] I have reviewed my changes in staging (look for the "Automatically generated comment" and click the links in the "Preview" column to view your latest changes).
[x] For content changes, I have completed the self-review checklist.

@Lulalaby Thanks so much for opening a PR! And for providing the screenshots! 🤩
I'll get this triaged for review :zap:

@Lulalaby Thanks so much for opening a PR! And for providing the screenshots! 🤩
I'll get this triaged for review ⚡

Sure <3 and thanks


allow adding custom partial echo containers

Usage: Set GRPC_ECHO_IMAGE env to some image that implements echo + a special flag --forwarding_address (https://github.com/grpc/grpc/pull/30005).
Effect: Any proxyless gRPC echo app will split the Echo across two containers, one for gRPC, one for everthing else.

This is to support testing Proxyless gRPC implementations in other languages (C++, Java). We have to implement echo to use Istio's integration tests, but it would be a burden to implement all of the echo protocols in these languages and keep implementations in sync across languages.
What we do here is described in this doc. TL;DR: running a second container with the the normal Go app to handle non-gRPC.
cc @yashykt

@stevenctl: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-cni_istio
d4c4782b2952f918c99a3fa2c9fb8313215b5ed0
link
true
/test integ-cni_istio

integ-pilot_istio
d4c4782b2952f918c99a3fa2c9fb8313215b5ed0
link
true
/test integ-pilot_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stevenctl: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-cni_istio
d4c4782b2952f918c99a3fa2c9fb8313215b5ed0
link
true
/test integ-cni_istio

integ-pilot_istio
d4c4782b2952f918c99a3fa2c9fb8313215b5ed0
link
true
/test integ-pilot_istio

integ-distroless_istio
d4c4782b2952f918c99a3fa2c9fb8313215b5ed0
link
true
/test integ-distroless_istio

integ-pilot-multicluster_istio
d4c4782b2952f918c99a3fa2c9fb8313215b5ed0
link
true
/test integ-pilot-multicluster_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stevenctl: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-cni_istio
d4c4782b2952f918c99a3fa2c9fb8313215b5ed0
link
true
/test integ-cni_istio

integ-pilot_istio
d4c4782b2952f918c99a3fa2c9fb8313215b5ed0
link
true
/test integ-pilot_istio

integ-distroless_istio
d4c4782b2952f918c99a3fa2c9fb8313215b5ed0
link
true
/test integ-distroless_istio

integ-pilot-multicluster_istio
d4c4782b2952f918c99a3fa2c9fb8313215b5ed0
link
true
/test integ-pilot-multicluster_istio

integ-telemetry_istio
d4c4782b2952f918c99a3fa2c9fb8313215b5ed0
link
true
/test integ-telemetry_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stevenctl: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-cni_istio
d4c4782b2952f918c99a3fa2c9fb8313215b5ed0
link
true
/test integ-cni_istio

integ-pilot_istio
d4c4782b2952f918c99a3fa2c9fb8313215b5ed0
link
true
/test integ-pilot_istio

integ-distroless_istio
d4c4782b2952f918c99a3fa2c9fb8313215b5ed0
link
true
/test integ-distroless_istio

integ-pilot-multicluster_istio
d4c4782b2952f918c99a3fa2c9fb8313215b5ed0
link
true
/test integ-pilot-multicluster_istio

integ-telemetry_istio
d4c4782b2952f918c99a3fa2c9fb8313215b5ed0
link
true
/test integ-telemetry_istio

integ-telemetry-mc_istio
d4c4782b2952f918c99a3fa2c9fb8313215b5ed0
link
true
/test integ-telemetry-mc_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


++NEW+((UPDATE))~ToDaY'S<(Free) Free Roblox Gift Card Codes 2024✔unused New Roblox Free Gift Cards

Welcome to the Roblox Gift Card Redeem Codes Guide! Learn how to open a wide variety of fun rewards and virtual items. Improve your gaming experience, whether you’re looking for exclusive products, in-game currency, or distinctive avatar upgrades. Prepare to explore an infinitely creative universe with Roblox as you let your imagination run wild!
🔴►🔴👉 👉CLICK HERE TO FREE GENERATOR
🔴►🔴👉 👉CLICK HERE TO FREE GENERATOR
Roblox has been hailed as the top playground for children and one of the best gaming platforms available. Its popularity lies in the fact that users can upload their games, play games created by others, and even create their own games using the platform.
To access the various paid items on the platform, one needs a virtual currency known as Robux. While there are multiple methods of obtaining Robux on the Roblox platform, the most efficient method is by spending real money.
Robux can be easily procured for amounts ranging from $10 to $50. Additionally, one can acquire unused Roblox gift card codes, which can grant them 10,000 Robux.
So, keep reading this guide to learn more about acquiring Robux.


The paperThe paper mentions that Mobile MQA was used, but I couldn't find the implementation in your code.

Yes, I didn't add MQA block in this code, because I didn't find related code in official code

This is a non-official implementation code that I came across.MobilenetV4

Thank you so much! I will update my code and illustrate this statement


Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.
Originally posted by @welcome[bot] in https://github.com/github/docs/issues/5339#issuecomment-819038819

I didn't really understand the reason for this PR.

@lucalves it's just spam.


Support Sketch 45 plugin update system

Hi there!
This is a quick note to remind you that Sketch 45 will include a plugin update system.
It would be awesome if you could add support to it (it's really easy!) before Sketch 45 comes out. Ideally, you should release an update for your plugin while we're still in Sketch 44, so your users will have a nice & easy experience when 45 is released.
For more details, please check http://sketchplugins.com/d/229-updating-plugins and http://developer.sketchapp.com/introduction/updating-plugins/
Thanks in advance!

Thanks @bomberstudios its a very nice and appreciated feature. I have made updates, and it works like a charm.

🎉


Adding social sign-on to preexisting cognito pool fails

Before opening, please confirm:

[x] I have installed the latest version of the Amplify CLI (see above), and confirmed that the issue still persists.
[X] I have searched for duplicate or closed issues.
[X] I have read the guide for submitting bug reports.
[X] I have done my best to include a minimal, self-contained set of instructions for consistently reproducing the issue.

How did you install the Amplify CLI?
yarn
If applicable, what version of Node.js are you using?
v12.9.0
Amplify CLI Version
4.51.2
What operating system are you using?
Mac
Amplify Categories
auth
Amplify Commands
push
Describe the bug
Hi there,
Our team is currently blocked on adding social sign on to our backend which has a preexisting cognito pool.
Amplify CLI version: 4.51.2
Stack Trace from CloudWatch log:
2021-05-24T04:20:59.370Z 411e5301-4f6e-4cef-afc9-f1711cfc969a INFO NotAuthorizedException: Error calling iam:PutRolePolicy API. Make sure credentials calling the API allow 'cognito-idp.amazonaws.com' to call this API. at Request.extractError (/var/runtime/node_modules/aws-sdk/lib/protocol/json.js:52:27) at Request.callListeners (/var/runtime/node_modules/aws-sdk/lib/sequential_executor.js:106:20)

IAM Policy for the account configured with amplify:
is the same as described here: https://docs.amplify.aws/cli/usage/iam
Which includes the iam:PutRolePolicy.
Seeing error:
CREATE_IN_PROGRESS OAuthCustomResourceInputs Custom::LambdaCallout Sun May 23 2021 21:21:00 GMT-0700 (Pacific Daylight Time) Resource creation Initiated
CREATE_FAILED      OAuthCustomResourceInputs Custom::LambdaCallout Sun May 23 2021 21:21:00 GMT-0700 (Pacific Daylight Time) Received response status [FAILED] from custom resource. Message returned: See the details in CloudWatch Log Stream: 2021/05/24/[$LATEST]88f8d7204e8942cda2df860c793a2a47 (RequestId: 40a21d3a-eeb5-4ded-bf68-64c3c7efcd43)
⠼ Updating resources in the cloud. This may take a few minutes...

UPDATE_ROLLBACK_IN_PROGRESS xxx AWS::CloudFormation::Stack Sun May 23 2021 21:21:01 GMT-0700 (Pacific Daylight Time) The following resource(s) failed to create: [OAuthCustomResourceInputs].
⠋ Updating resources in the cloud. This may take a few minutes...

UPDATE_FAILED               xxx AWS::CloudFormation::Stack Sun May 23 2021 21:21:15 GMT-0700 (Pacific Daylight Time) Embedded stack xxx was not successfully updated. Currently in UPDATE_ROLLBACK_IN_PROGRESS with reason: The following resource(s) failed to create: [OAuthCustomResourceInputs].

Expected behavior
The push is successful and social sign-on is added as a feature to our cognito pool.
Reproduction steps

Step through CLI to add social sign on by running amplify update auth
run amplify push

GraphQL schema(s)
N/A
Log output
N/A
Additional information
N/A

@bmvdeveloper
Do your project already have an existing social provider? or did you add a social provider for the first time?
I was not able to repro on v4.51.2 with an existing project that did not have social provider added.

The project did not have an existing social provider when initially created
from what I remember.  It was awhile ago when I first created it.
Regardless tho based off the error it’s saying permissions is the problem.
What would cause that?
On Tue, May 25, 2021 at 4:13 PM Josue Ruiz @.***> wrote:

@bmvdeveloper https://github.com/bmvdeveloper
Do your project already have an existing social provider? or did you add a
social provider for the first time?
I was not able to repro on v4.51.2 with an existing project that did not
have social provider added.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/aws-amplify/amplify-cli/issues/7388#issuecomment-848330903,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AMURR6X6QBVNGJJU5CKYPGTTPQVKDANCNFSM45MO33ZA
.

--
Thanks,
Michael Valdez
Co-Founder & VP | BMV Inc.
P:<PHONE_NUMBER>
E: @.***
597 Nucla Way Ste G
Aurora, CO 80011

Can you send over your auth cfn template (amplify/backend/auth/<AUTH_RESOURCE_NAME>/<AUTH_TEMPLATE>.yml) to<EMAIL_ADDRESS>

Hey @bmvdeveloper :wave: are you still experiencing this issue? And if so may you send us your auth cloudformation template to<EMAIL_ADDRESS>

Hi 👋 yes our team is still experiencing the issue.  Will send over the information requested, thanks for the follow up!

Hey @bmvdeveloper sorry to ask again but may you try re-sending your information in a zip file? I haven't seen the mail come through, assuming you've had a chance to send it. If not, no worries! I'll be sure to keep an eye out.

yep resending right now! thank you

I sent the information again please let me know if your team did not receive it, thank you again :)

Hey @bmvdeveloper thank you for resending, I received it and will be taking a look at it today!

Hey @bmvdeveloper :wave: apologies for the delay I'm still taking a look at reproducing this issue. Out of curiosity was the project/auth created with Admin UI? OR are you able to see what account is attempting to make the call?

So it was created via CLI -- when admin UI was launched I then went in and enabled it (if I remember right) just to see what it was all about.
From there I will say it seemed to have been acting different.  I don't know if that helps at all.  Am I able to see what account is attempting to make the call? It's from the CLI so the main account I am assuming?  The IAM User/Profile has full admin access.

Hey @bmvdeveloper I've taken a further look at this and noticed this error is coming from a Lambda callout, and I've been aiming to identify the Lambda that's causing the error, though the fix would ultimately be providing that policy to the Lambda in question. What is the social provider in use and is this a custom auth flow? I was able to add Login with Amazon to an existing auth resource

Not a custom auth flow -- basically whenever I try to update auth from CLI to add facebook, google & Amazon it fails when I push via amplify push

is there any way I can schedule a time to chat with one of you via discord or something?  Our team really wants to get this out and we have been blocked on it for almost 2 months.

@bmvdeveloper Yes, absolutely! Please ping me directly or on the Amplify server (@josef) and we can schedule a time to chat. My schedule is open today

Note: after hopping on a quick call with @bmvdeveloper we ran into an issue similarly described in #7685

Hi @josefaidt! I'm currently stuck at the exact same problem. Walking through Apply default configuration with Social Provider (Federation) --> Sign in with Apple and  amplify push afterwards always fails with this output:
CREATE_FAILED OAuthCustomResourceInputs Custom::LambdaCallout Tue Sep 14 2021 13:32:44 GMT+0200 (Central European Summer Time) Received response status [FAILED] from custom resource. Message returned: See the details in CloudWatch Log Stream: 2021/09/14/[$LATEST]0a11b1d3d83043f8a558c91fc90a7d26 (RequestId: 59203570-27b1-40f7-bdb8-2b4b02f5b4d9)

The CloudWatch logs show this error message:
"message": "Error calling iam:PutRolePolicy API. Make sure credentials calling the API allow 'cognito-idp.amazonaws.com' to call this API.".
As I am not sure which resource should receive the PutRolePolicy I don't really know how to proceed here...
Any update / help is really appreciated.

Hey @yannikw23 :wave: can you elaborate on the reproduction steps and how you are authenticated with the CLI? Below are the steps taken using Amplify CLI v5.5.0:

Create an app with amplify init -y using a profile to authenticate (also tried with AdminUI to no avail)
add auth with amplify add auth > amplify add auth
 ⚠ Amplify command hooks are disabled in the current execution environment.
 ⚠ See https://docs.amplify.aws/cli/usage/runtime-hooks for more information.
 Using service: Cognito, provided by: awscloudformation

 The current configured provider is Amazon Cognito.

 Do you want to use the default authentication and security configuration? Default configuration with Social Provider (Federation
 )
 Warning: you will not be able to edit these selections.
 How do you want users to be able to sign in? Email
 Do you want to configure advanced settings? Yes, I want to make some additional changes.
 Warning: you will not be able to edit these selections.
 What attributes are required for signing up? Email
 Do you want to enable any of the following capabilities?
 What domain name prefix do you want to use? authresourced5e74f61-d5e74f61
 Enter your redirect signin URI: http://localhost/signin/
 ? Do you want to add another redirect signin URI No
 Enter your redirect signout URI: http://localhost/signout/
 ? Do you want to add another redirect signout URI No
 Select the social providers you want to configure for your user pool: Sign in with Apple

 You've opted to allow users to authenticate via Sign in with Apple. If you haven't already, you'll need to go to https://develop
 er.apple.com/account/#/welcome and configure Sign in with Apple.

 Enter your Services ID for your OAuth flow:  fakeserviceid
 Enter your Team ID for your OAuth flow:  faketeamid
 Enter your Key ID for your OAuth flow:  fakekeyid
 Enter your Private Key for your OAuth flow:  ----BEGIN PRIVATE KEY-----MIGTAgEAMBMGByqGSM49AgEGCCqGSM49AwEHBHkwdwIBAQQgna3uFpCCc
 ZKRx6TZu0+jVZl+JktWmqNGBYHkYYrNp52gCgYIKoZIzj0DAQehRANCAASVgGc7zI+pUDdJP/1bVd/ig89c9SdPqY+QXnkMMQnlrJMcmajXi7TKla3WiKxy9Hbor3GMgE
 D48R3P9vlb0s+c-----END PRIVATE KEY---—
 Successfully added auth resource authresource locally

push resources with amplify push -y

@josefaidt, thanks a lot for your prompt response! I have an existing application with an existing UserPool for which currently only email/password sign up is enabled. Now, I wanted to add Sign in with Apple.
$ amplify auth update
Please note that certain attributes may not be overwritten if you choose to use defaults settings.

You have configured resources that might depend on this Cognito resource.  Updating this Cognito resource could have unintended side effects.

Using service: Cognito, provided by: awscloudformation
 What do you want to do? Apply default configuration with Social Provider (Federation)
 What domain name prefix do you want to use? mXXX
 Enter your redirect signin URI: http://localhost:3000/signin/
? Do you want to add another redirect signin URI No
 Enter your redirect signout URI: http://localhost:3000/signout/
? Do you want to add another redirect signout URI No
 Select the identity providers you want to configure for your user pool: Sign in with Apple

 You've opted to allow users to authenticate via Sign in with Apple. If you haven't already, you'll need to go to https://developer.apple.com/account/#/welcome and configure Sign in with Apple.

 Enter your Services ID for your OAuth flow:  com.XXX.sid
 Enter your Team ID for your OAuth flow:   XXX
 Enter your Key ID for your OAuth flow:  XXX
 Enter your Private Key for your OAuth flow:  -----BEGIN PRIVATE KEY----- XXX -----END PRIVATE KEY-----
Successfully updated auth resource XXX6e84eedb locally

So up until this point, it runs smoothly. However, when I want to amplify push it, I receive the errors described above:

CREATE_FAILED OAuthCustomResourceInputs Custom::LambdaCallout Tue Sep 14 2021 13:32:44 GMT+0200 (Central European Summer Time) Received response status [FAILED] from custom resource. Message returned: See the details in CloudWatch Log Stream: 2021/09/14/[$LATEST]XXX (RequestId: XXX)

The CloudWatch logs show this error message:
"message": "Error calling iam:PutRolePolicy API. Make sure credentials calling the API allow 'cognito-idp.amazonaws.com' to call this API.".
As I am not sure which resource should receive the PutRolePolicy I don't really know how to proceed here...

Hey @yannikw23 do you remember what version of the CLI was used to create the auth resource initially? Or approximately how long ago it was created?

@josefaidt  I initially set up amplify back in May 2020. Not sure which version number that was, tbh...

@yannikw23 no worries! I appreciate the information! I went back and set something up with 4.42, but now trying to use 4.2. I'll report back shortly

Hey @yannikw23 I downgraded to 4.13.1 to create the auth resource with email, upgraded to the latest version of the CLI, and ran amplify update auth to apply social configuration with sign-in-with-apple. Unfortunately I was not able to reproduce the error. May you send your auth resource's CloudFormation template file over to<EMAIL_ADDRESS>

Hey @josefaidt! Thanks for taking a look - that's super weird. I've sent you a mail with the CloudFormation template file attached. Hope that helps. Please let me know if you need more info :)

@yannikw23 thanks for sending that over! May you send your project's amplify/ folder over as a zip file to that same address? We'd like to take a further look at the details associated with the auth resource.
@bmvdeveloper may you send your project's amplify/ directory as well?

Or just the auth-related files, including the CloudFormation template and parameters.json files 🙂

Hi @josefaidt, I've just sent the zipped auth folder over. :)

@josefaidt Hi there! Any updates on this? Have you received all required files? 😊

Hey @yannikw23 I'm still investigating the cause of the issue. Yes, I have received the necessary files, thank you for sending those over!

Hey @yannikw23 :wave: what region is your Amplify backend deployed to? And may you send me your amplify/ folder as a zip file? I want to see if I can init off of it as I've mimicked the setup based on the auth files you sent over, though I am unable to reproduce. Can you also confirm whether this is the only error present when pushing and if it persists across envs?

Hey @bmvdeveloper and @yannikw23 :wave: I was able to reproduce this issue with the help of @chrisbonifacio using the latest version of the CLI (7.6.3) and the following steps:

create a new project with amplify init -y
add auth with amplify add auth

add a social provider like Facebook, enter some ID/secret

push with amplify push -y
update the auth resource with new social providers with amplify update auth
choose Update OAuth Social Providers, add Google and Amazon> amplify update auth
Please note that certain attributes may not be overwritten if you choose to use defaults settings.
Using service: Cognito, provided by: awscloudformation
What do you want to do? Update OAuth social providers
Select the identity providers you want to configure for your user pool: Facebook, Google, Login With Amazon

You've opted to allow users to authenticate via Facebook.  If you haven't already, you'll need to go to https://de
velopers.facebook.com and create an App ID.

Enter your Facebook App ID for your OAuth flow:  fakeappid
Enter your Facebook App Secret for your OAuth flow:  fakeappsecret

You've opted to allow users to authenticate via Google.  If you haven't already, you'll need to go to https://deve
lopers.google.com/identity and create an App ID.

Enter your Google Web Client ID for your OAuth flow:  fakeclientid
Enter your Google Web Client Secret for your OAuth flow:  fakeclientsecret

You've opted to allow users to authenticate via Amazon.  If you haven't already, you'll need to create an Amazon A
pp ID. Head to https://docs.amplify.aws/lib/auth/social/q/platform/js#setup-your-auth-provider to learn more.

Enter your Amazon App ID for your OAuth flow:  fakeappid
Enter your Amazon App Secret for your OAuth flow:  fakeappsecret

push with amplify push -y
Observe error

Looking at the CloudWatch logs for this Lambda callout we see:

As a workaround we can run amplify update auth and step through the same prompt to update OAuth social providers, which should pre-populate all inputs with the corresponding values entered from the previous attempt.
Marking as a bug :)

@josefaidt I'm a little confused on the workaround. Once I do update OAuth social providers am I supposed to just amplify push and it should work?
I did that and it's still giving me the same error as the other people. Any ETA on a fix (or workaround?)

Getting the same error after an amplify auth update followed by amplify push. I also didn't actually change anything in the auth config, it was merely an attempt to fix a build issue in the Amplify console.

@edwardfoyle @josefaidt @sachscode  I updated amplify CLI (7.6.24) but I still get this error. Is there any files that would be useful for me to share so we can figure out what is going on?

Yea so... I found my "upClientLambdaRoleb5f16d0d211809-dev" role and granted it full admin access just to test. Now it pushes just fine? A little confused on why this specific role needs more rights and why that is not setup through Amplify.


VideoPlayer or AudioPlayer not work Play()

When I pause, video or audio is paused, ready and then press to continue or "Play" but does not respond. It works using new mediafile but I do not want to, I want to continue.
Here is a very simple example:
if (PlayerStatus != Playing)
{
     await MediaManager.VideoPlayer.Play(); // does not reply!
}
else
{
     await MediaManager.VideoPlayer.Pause();
}

I found a solution.
private MediaFile mediaFile;

public void Init()
{
	mediaFile = new MediaFile
	{
		Type = Video,
		Availability = ResourceAvailability.Remote,
		Url = VideoSource,
	};

	await MediaManager.AudioPlayer.Play(mediaFile);
}

...
if (PlayerStatus != Playing)
{
     // MediaFile is already saved, it will not start again, it is continuing...
     await MediaManager.VideoPlayer.Play(mediaFile);
}
else
{
     await MediaManager.VideoPlayer.Pause();
}

I already tested the same AudioPlayer.Play(); but it does not work.
05-21 16:02:07.194 I/MediaPlayer(12079): [HSM] stayAwake false uid: 10361, pid: 12079
05-21 16:02:07.204 I/MediaPlayer(12079): [HSM] stayAwake false uid: 10361, pid: 12079
05-21 16:02:07.205 I/MediaPlayer(12079): Pid:12079 MediaPlayer destructor


Upload/Download Progress on Vercel Blob

I am currently using vercel blob to store large files and not showing the progress results in a very bad user experience. Can we have this feature soon?

hey @fahidsarker,
this is on our roadmap and we are planning to implement this.
Are you using the multipart upload or the plain put method?

We're having the same issue. We're using the multipart upload, typically with large files.

We're also using Vercel Blob and taking the client-side upload approach (in our Next.js app) and would love to show an upload progress bar, especially for larger file uploads.

If you are using @vercel/blob/client package in a NetxtJs app router, I think I have a temp solution.
util.ts
"use server"
import { upload, generateClientTokenFromReadWriteToken } from "@vercel/blob/client";

import { ORIGIN } from "@/lib/constants";

export const secureGenerateClientTokenFromReadWriteToken = async ({
  userId,
  pathname,
}: {
  userId: string;
  pathname: string;
}) => {

  return generateClientTokenFromReadWriteToken({
    token: process.env.BLOB_READ_WRITE_TOKEN,
    pathname: pathname,
    onUploadCompleted: {
      callbackUrl: `${ORIGIN}/api/user/upload`,
      tokenPayload: JSON.stringify({
        userId,
      }),
    }
  })
}

Then from inside your client component.
        const pathname = `${user.id}/${file.name}`;
        const token = await secureGenerateClientTokenFromReadWriteToken({
          userId: user.id,
          pathname,
        });
        await axios.put(
          `https://blob.vercel-storage.com/${pathname}`,
          file,
          {
            headers: {
              "Authorization": `Bearer ${token}`,
            },
            onUploadProgress: (progressEvent) => {
              console.log(progressEvent);
            }
          }
        )
       ```

This progress functionality is important for our project as well. Displaying the download progress is essential for users, as varying file sizes or slow internet connections can make the process appear frozen.

Would also be very useful for us.

Any idea on whether it'll be implemented anytime soon?
I need to understand should I move to S3 uploads instead of Vercel Blob or not.

Hey there, we just published a preview version of @vercel/blob which includes a way to track the progress of uploads.
If you want to try it, please upgrade to<EMAIL_ADDRESS>in your package.json. Then use it this way:
// also works with upload()
const blob = await put('file.pdf', file, {
  onUploadProgress(event) {
    console.log(event.loaded, event.total, event.percentage);
  }
});

If you're using Next.js and getting errors about undici, please upgrade to at least<EMAIL_ADDRESS>or force undici to be at version 5 in your package.json using pnpm overrides for example: https://pnpm.io/package_json#pnpmoverrides.
cc @fahidsarker @xavimb @patrickdevivo @jonathantcrawford @alan-funded @neoromantic @Vitalii-Hurieiev

Thanks, this will allow our customers to know their upload is actually
happening :)
On Fri, Oct 25, 2024 at 3:50 PM Vincent Voyer @.***>
wrote:

Hey there, we just published a preview version of @vercel/blob which
includes a way to track the progress of uploads.
If you want to try it, please upgrade to
@@.*** in your package.json. Then
use it this way:
// also works with upload()const blob = await put('file.pdf', file, {
onUploadProgress(event) {
console.log(event.loaded, event.total, event.percentage);
}});
If you're using Next.js and getting errors about undici, please upgrade to
at least @.*** or force undici to be at version 5 in your
package.json using pnpm overrides for example:
https://pnpm.io/package_json#pnpmoverrides.
cc @fahidsarker https://github.com/fahidsarker @xavimb
https://github.com/xavimb @patrickdevivo
https://github.com/patrickdevivo @jonathantcrawford
https://github.com/jonathantcrawford @alan-funded
https://github.com/alan-funded @neoromantic
https://github.com/neoromantic @Vitalii-Hurieiev
https://github.com/Vitalii-Hurieiev
—
Reply to this email directly, view it on GitHub
https://github.com/vercel/storage/issues/642#issuecomment-2438990641,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BDME3BVUJIGXSXGKYOP7JOLZ5LDLFAVCNFSM6AAAAABFQN2WQGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMZYHE4TANRUGE
.
You are receiving this because you were mentioned.Message ID:
@.***>

@alan-funded I am curious: are the uploads from your customers big enough that upload progress is needed? I think it's always a valuable info, just curious here

Tens of megabytes, but often from cell phone, and on the go. AlanOn Oct 25, 2024, at 4:26 PM, Vincent Voyer @.***> wrote:
@alan-funded I am curious: are the uploads from your customers big enough that upload progress is needed? I think it's always a valuable info, just curious here
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: @.***>

Huge thanks to the team for the update. Will close the issue as it has been resolved.

@alan-funded Hey, im just using Vercel Blob for the first time and this works with no problem! Thanks for this feature. In argentinian i'll say: ¡qué grande!

Nice @arazardev! Will publish a stable version this week then

This feature is now released in<EMAIL_ADDRESS>it's compatible with Node.js, browsers, client or server uploads, and most recent Next.js versions too.

For everyone here, since this was a well followed ticket, I wanted to raise your awareness on an upcoming change we'd like to do on Vercel Blob SDK: no more random suffixes by default. Please join the conversation here:
https://x.com/vvoyer/status/1854816275173634175


kubectl: Pod with deletionTimestamp shown as Terminating after Failed/Succeeded

What happened?
A pod with a finalizer and a deletion timestamp is listed as "Terminating" in kubectl get and describe, even after the phase is Failed/Succeeded
What did you expect to happen?
The phase Failed or Succeeded to be shown
How can we reproduce it (as minimally and precisely as possible)?

Create a long running pod with a finalizer
Issue a pod delete
Use kubectl get -o wide or kubectl describe to see the pod.

Anything else we need to know?
This causes confusion, as the Pod doesn't account for any resource usage when its Failed or Succeeded.
This should be backported to all supported versions.
Kubernetes version

master

Cloud provider

N/A

OS version

# On Linux:
$ cat /etc/os-release
# paste output here
$ uname -a
# paste output here

# On Windows:
C:\> wmic os get Caption, Version, BuildNumber, OSArchitecture
# paste output here

Install tools

Container runtime (CRI) and version (if applicable)

Related plugins (CNI, CSI, ...) and versions (if applicable)

In addition to the linked PR, in pkg/describe it looks like this is being set statically/manually (search for "Terminating") and this will probably be confusing and need to be cleaned up as well so that describe is not setting things that contradict get.
/triage accepted

My only concern is whether users need to know that a finalizer is pending, but "Terminating" status doesn't distinguish between waiting for containers to exit and waiting for finalizers to complete, so this change makes it more clear what is happening.
If people need to know that finalizers are pending, versus just seeing Completed or Failed, we could potentially show a status of "Finalizing", but that hasn't been asked for yet as far as I know.


Fix the description for 'observable.map(f)'

The current documentation for observable.map states that this function returns a new EventStream, which is not accurate. That lead me to believe that if used in a property the result would be an 'EventStream' rather than a property, which I thought was odd. However, after I tested it I realized that it returns a property when it's used with a property and  stream when it's used with  stream, which is what I would expect.

pls update readme-src.coffee, from which readme is generated (see contribution section in readme)
On 11 Mar 2015, at 16:49 , Josep M<EMAIL_ADDRESS>wrote:

The current documentation for observable.map states that this function returns a new EventStream, which is not accurate. That lead me to believe that if used in a property the result would be an 'EventStream' rather than a property, which I thought was odd. However, after I tested it I realized that it returns a property when it's used with a property and stream when it's used with stream, which is what I would expect.
You can view, comment on, or merge this pull request online at:
https://github.com/baconjs/bacon.js/pull/565
Commit Summary
Fix the description for 'observable.map(f)'
File Changes
M README.md (2)
Patch Links:
https://github.com/baconjs/bacon.js/pull/565.patch
https://github.com/baconjs/bacon.js/pull/565.diff
—
Reply to this email directly or view it on GitHub.

:+1:
@raimohanska in my very first commit of this PR I didn't have the readme-src.coffee file updated, but I immediately realized that the readme file was being generated from there, so I ammended the commit and pushed it again. If you have a look at the "files changed" you will see the file is there. Thanks!

Thanks!


Migrate to Iron

### Tasks
- [ ] #86
- [ ] #88
- [ ] https://github.com/aica-technology/dynamic-components/issues/267
- [ ] aica-technology/modulo#32
- [ ] https://github.com/aica-technology/dynamic-state-engine/issues/117

@domire8 I think this one can also be closed 🔥


Use EF7, Linq Left Join Where Select is error.

Hi, Linq left join for different grammar, I use EF6, EF7 were tested, but the test results are completely different, I hope you can help me, because my project is using it, thank you!
For more details see this blog: EntityFramework 7 Left Join Where Select 奇怪问题

When will this be available?

@maumar just a reminder that we looked at this item and we thought it would be a good idea to tackle it next.

Initial work completed.

Yay!


[google_maps_flutter] How do I show the google_maps like a picture(no interaction)?

I tried to use the Stack, the dialog, and the IgnorePointer to block the interaction of the google_maps but it does not work. The google_maps is always on top.
How do I block the interaction of the google_maps?

Example:
https://user-images.githubusercontent.com/59549741/152469925-e3ae9fa5-7def-4037-95f9-f2b9fb6c34a3.mp4

@SittiphanSittisak
Your question is better suited for support channels like StackOverflow, so please ask the same there.
Closing from here, as this is more of a code assistance question.


Migrate to new csproj format & add netstandard2.0

fixes #1 (at least on windows)

Great work @zivillian! Thank you.
Can you please resolve conflicts and merge develop branch to yours since your branch is 1 commit behind main repo?

I'm going to create another one commit and then I'll be ready to merge your PR.

@zivillian Thanks for your contribution!


[FR] Allow the Chart to create extra manifest

Is your feature request related to a problem? Please describe.

Sometimes, accessory to the installation there may be manifest to be installed (for example a SecretProviderClass or in this specific case a ClusterIssuer).
Describe the solution you'd like

It would be nice to be able to do this directly via the Chart using the approach that ArgoCD also uses:
Ref: https://github.com/argoproj/argo-helm/blob/cf57a71a154a1a8a19f5f9d3980d60eb3efd80c8/charts/argo-cd/values.yaml#L62-L87
/kind feature

/remove-lifecycle stale

Agree this would be helpful, it's very common to deploy issuers along with the chart using CD and this would simplify the process and isn't a big change at all.

Hey, thanks for raising this issue! Great to see so many thumbs up on an issue too :grin:
I just added a comment on #4803 which is similar. I'll copy it here:

I'm not sure that this is something we're ever likely to support. There isn't really any "default" issuer we can add, and crucially we can't guarantee that the cert-manager CRDs have been installed before the Helm chart is installed - which would be required for us to be able to create a ClusterIssuer.

I like the idea of this - like an "extended" install, or some kind of operator which can do more than just install cert-manager - but I don't think we're likely to ever add that to our helm charts, sorry!

Put simply: we can't guarantee that the CRDs are going to be installed when the helm chart is installed, and so we're unlikely to add this. I'm sure a PR adding functionality like this would be considered but it seems super hard to do this in any kind of safe way :disappointed:

Would a post-install hook work for additional resources?
https://helm.sh/docs/topics/charts_hooks/#the-available-hooks
Or use the pre-install hook for CRDs?

Put simply: we can't guarantee that the CRDs are going to be installed when the helm chart is installed

Sorry for commenting under a closed issue, but could you elaborate on this point, please?
The risks described here are not really clear, i.e. if this is something intended to pre-install issuers along with the chart, this could depend on the installCRDs value the way it's handled right now: it's only rendered from values into manifests if both (installCRDs and installIssuers) evaluate to true.
According to helm code (also InstallOrder), custom resources like Issuer/ClusterIssuer will be installed last, after the CRDs have already been installed, so there is no race condition risk.

I'm not totally familiar with the whole process, but I think it gets complicated with upgrading CRDs... mostly I'm going off what's documented here.
I think I can see how this feature could be implemented somewhat safely and as I said I'm sure we'd at least consider a PR to add this.


fix: fixes indentation of extraInitContainers

Description
Fixes an issue when indenting template for extraInitContainers.
Related issues
Closes #30

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: salaboy
If they are not already assigned, you can assign the PR to them by writing /assign @salaboy in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


updated test repository for test_gitlab_ref

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@3fe8143). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master       #2   +/-   ##
=========================================
  Coverage          ?   80.26%
=========================================
  Files             ?       14
  Lines             ?     1373
  Branches          ?        0
=========================================
  Hits              ?     1102
  Misses            ?      271
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3fe8143...2ea22e8. Read the comment docs.


General question on custom controller guidance

Apologies if this is the wrong repository to pose this question - is there any documentation related to implementing custom controllers that Flux can utilize?
For example, if I wanted to create a custom controller that could be used to manage deployments onto AWS ECS, is there any guidance on the interface for controllers and how they integrate with Flux? Thank you in advance!

Thank you for the info and guidance - I'll take a look and give it a try, cheers!


fix(scap): remove unnecessary and harmful strchr(=)

get_cgroup_subsystems_v2 already returns subsystem names only, not subsys=path, so the strchr won't ever return anything else than NULL.
In fact, the whole subsys variable is unnecessary, we can use cgset_subsys directly.
What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area API-version

/area build

/area CI

/area driver-kmod

/area driver-bpf

/area driver-modern-bpf

/area libscap-engine-bpf

/area libscap-engine-gvisor

/area libscap-engine-kmod

/area libscap-engine-modern-bpf

/area libscap-engine-nodriver

/area libscap-engine-noop

/area libscap-engine-source-plugin

/area libscap-engine-savefile

/area libscap-engine-udig

/area libscap

/area libpman

/area libsinsp

/area tests

/area proposals

Does this PR require a change in the driver versions?

/version driver-API-version-major

/version driver-API-version-minor

/version driver-API-version-patch

/version driver-SCHEMA-version-major

/version driver-SCHEMA-version-minor

/version driver-SCHEMA-version-patch

What this PR does / why we need it:
In debug builds, scap_cgroup_resolve_v2 never works (always hits an ASSERT). In release builds, it works because we're lucky (all entries from get_cgroup_subsystems_v2 have a trailing NUL).
Special notes for your reviewer:
We need this in 0.12 too :<
Does this PR introduce a user-facing change?:

NONE

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: gnosek
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [gnosek]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: FedeDP, gnosek
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [FedeDP,gnosek]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

LGTM label has been added.  Git tree hash: f21b7f684d16b91ef25adcf124cf693e1b286e23


Logitech G910: No Key Lighting in Overwatch

I have pressed the "Patch Overwatch" and pointed it to where I have installed it. But When i run the game all keys go black and nothing happens.
i'm guessing it has something to do with the "Game Listener".
Thanks in advance. :)

Do you get an error message telling you Game Listener couldn't get started when starting Aurora?
Try to run Aurora with Admin rights. (This is what I need to do.)

I don't get an error. Nothing happens, it just goes black.
I am running it as admin otherwise it won't start at all.

Take a look over solutions for #42

I have just tried that. It's not working.
I installed both x86 and x64 of vc_redist, and i am runnning everything as admin.

Can you attach the Aurora log during which you tried playing Overwatch?

2017_02_01.txt
here.

I see what is going on here.
Run Command Prompt as administrator and execute the following command: lodctr /R

I have done that now.
Not fixed yet.
2017_03_01.txt

Well, if you're running Overwatch. Then the wrapper isn't making a connection with Aurora. Are you sure you installed the wrapper in the correct location? (There should be two files next to Overwatch.exe: "RzChromaSDK64.dll" and "RzChromaSDK.dll")

I already have those.

I just tested with current Overwatch update (to make sure that Blizzard didn't block Aurora's wrapper), and it worked fine.
So, I believe that your PC isn't allowing wrapper to communicate with Aurora. Do you have any antiviruses or firewalls that could be blocking the wrapper?

Having this same issue. I tried turning off my antivirus and firewall, but still having the same issue.

Any updates on this? And, could @Tearhead and @Gulugumi try the latest development release if you're still having issues.

@simon-wh Yep. working for me now.

@simon-wh I have all the things i need but it still doesn't work. I don't understand why


fix(package): update axios to version 0.18.0

Closes #19

Coverage remained the same at 90.21% when pulling 89f11969f97b1bbee6b4a6681c51e53ab7552b9b on greenkeeper/axios-0.18.0 into 926f60c64107cdb25899f88cdf8a55cfd2599810 on master.


gulp plugin?

Hi,
Although the front page says that gaze is used by gulp, it doesn't appear that way anymore. Am I right in assuming that gaze is native on linux where chokidar is not (ok you may not be able to answer to the 2nd part)...If so, then is there work already done to integrate gaze into gulpjs? asking because I couldn't find any plugin and gulp-watch list chokidar as the current watcher.

gulp itself currently uses gaze through glob-watcher. gulp-watch is something else and at one time did use gaze but now uses chokidar. gulp will also likely switch to chokidar.
gaze >= 0.6 uses native addons for OSX, Linux and Windows. Where gaze 0.5.1 (the version gulp uses) only uses the native file watching events (provided through Node.js) for some operations.


[pdfx] Android : Close document throw a PlateformException with an Unknown error

Describe the bug
PlatformException when I try to close a PdfDocument
To Reproduce
I opened a pdf with openData function then getPage() and page.render(). Once I get my PdfPageImage, I close the pdf with the close function.
This code works well on web and iOS, but on Android I get a PlatformException (more info in screenshot)
Screenshots

Additional context
pdfx : 2.6.0
flutter : 3.19.5

Sorry I realize I had to close the PdfPage before the PdfDocument.


delete one title from projects page issue #633

Before

LGTM

@tobySolutions @tobySolutions @tobySolutions

Hey @devvsakib, can you do one more change?
can you remove the "Want to contribute to these projects" line and the line below it?
Thanks ❤

@devvsakib this part too...
<p className="mb-5 text-lg">
              Get started by selecting the language you want to work
</p>`

ready to merge @tobySolutions

Awesome work @devvsakib, @AryanBabber!! Great job guys!


Enhancement Idea: After moving a file to a new folder, leave the focus in the source folder

When deleting, this behaviour is an option:
"After the file is deleted, focus is switched to the next open file. This way you can carry on editing without needing to switch view to return to an active state. Other extensions don't do this!"
But after moving a file to another folder, focus moves to the target folder.  When cleaning up a folder and moving lots of files around, it would be more efficient to leave the focus on the next file in the source folder.
I guess it's tricky to do, with a few edge cases - have to figure out the name of the file to return to, before the move happens, and what if that's the last file in a folder, or it's removed while the move is happening?
      // return focus to editor
      await vscode.window.showTextDocument(newUri);

But the delete active file does this instead:
      // give focus to next editor
      await vscode.commands.executeCommand("workbench.action.nextEditorInGroup");

Hi @ianmcgowan
Thanks for you interest in the extension.
Is it the Move active file or Move file command you are referring to?
It is different with commands that work on active files. The issue I found, and that you quoted above, is that when you carry out a file operation in the background on a file that is open in an editor, then VS Code loses it place and you left in an essentially unfocused state. You need to click somewhere in the application to recover an active state somewhere.
I get the gist of what you are looking for. I am just wondering what it is you are doing that this will help you be more efficient at? Are you moving multiple files from one folder to another folder? Like a batch move of files?
I don't find myself moving many files in projects. I tend to reach for the command-line if I do as it more precise and efficient.
When I have time, I will play around with the scenario in VS Code to see what makes sense. Other people may prefer to have it the way it is, they may like focus swithicng to the target folder!

Yes, it's kind of a niche requirement for "Move active file" - I sometimes have a folder of uncategorized files that I need to put into separate folders.  But I have to look at each program individually to decide where it goes.  The extension already makes it way more efficient to do with keyboard shortcuts, but it's a small annoyance having to navigate back to the source folder and find my place each time.  Agree, some folks may prefer switching to the target folder, that's probably the right thing to do when moving one file (and how is the extension to know you're doing one vs many?).
I have a folder INCOMING, with 400 programs in it, and they need to be moved into folders A, B, C, D based on reviewing the content, not the file name - that's the use case.  I'm already done with this exercise now, but it comes up pretty regularly in the work I do.  I'm not usually allowed to install Midnight Commander or other file managers, so FileBunny was a great find for me - thanks so much for releasing!


[question] SUPERSET_WEBSERVER_TIMEOUT deprecated but what is the alternative?

Make sure these boxes are checked before submitting your issue - thank you!

[X ] I have checked the superset logs for python stacktraces and included it here as text if there are any.
[X ] I have reproduced the issue with at least the latest released version of superset.
[X ] I have checked the issue tracker for the same issue and I haven't found one similar.

Superset version
Superset 0.28.1
Expected results
Answer of the question
Actual results
Missing answer
Steps to reproduce

Click on https://github.com/apache/incubator-superset/blob/master/superset/config.py#L62
See that it says deprecated
See that it does not say what is the alternative to be placed in superset_config.py

Looks like this is confusing indeed, the comment comes from https://github.com/apache/incubator-superset/pull/4451 where the auto generated gunicorn command (started through superset runserver) started getting deprecation messages but appears to still work.
The config element SUPERSET_WEBSERVER_TIMEOUT is still used widely across the codebase.
Timeouts are much more complicated than a sane person would expect. Let me document some things here:

first your proxy / load balancer / envoy / kong thing may time out before your web server does. When that happen I think nothing is returned and the request is just forever lost. The webserver may still do work, and has no way to return a response.
flask offers no way to set a timeout, but your wsgi server does (gunicorn / nginx / ...) when that happens, it does return a proper response with an error code. Without us generating the gunicorn command (per #4451), people have to keep the timeouts in sync manually
we have code on the client side that gives up if it looks like it'll never get a timeout response, I'm not sure if it's implement consistently across all "requests that may time out"

Regardless, I think we should remove the " # deprecated" comment and add some notes in there. PR coming up.


Cyanogen3DS seems broken with the new GPU changes

First of all my program heavily relies on sf2d and sflib for loading it's textures. I haven't changed anything with the source but after updating with the most recent versions of libctru, citro3d and libsf2d, libsfil, libsftd it appears to run very slowly on both Citra and hardware. What's even weird is that none of the controls actually work, except for the analog stick. A/B/Y doesn't seem to work. The only that may possibly be causing the lags is this https://github.com/joel16/Cyanogen3DS/blob/master/source/utils.c#L126
I can't think of anything else that may affect performance. Do you have any idea what's the problem?

Hmm can you try commenting functions such as drawing a texture to see if the speed improves and find the function that is slow?

So... I appear to be having similar issues with my project (this isn't limited to Cyanogen3DS). Iirc, I was getting roughly 120 FPS before I updated, and now I'm getting ~58-59. This is now causing issues with my sound, though it's probably fixable. And I don't even have real collision detection yet... >_<
I will attempt commenting stuff tomorrow, I need to take a break from this.

https://github.com/joel16/Cyanogen3DS/blob/master/source/boot.c#L66
Why is there a sleep? sf2dlib is supposed to already take care of synching with the screen refresh rate (which is 60FPS, rendering at anything higher than that is pointless)

@fincs the sleep function is there to prevent the boot animation from going way too fast. That was the reason why I had to place the sleep function there. Besides that function isn't activated if bootanimation is off (in my case it is), so it wouldn't even go to the sleep function in the first place. But as you suggested, I tried commenting it out but it didn't make any change.
@xerpi I tried commenting out some drawing functions, and also my setBilienarFilter function to see if it improves performance in any way but sadly it didn't. It's weird because I haven't messed with the source since the most recent changes to the GPU. I only made a few changes in the makefile to adapt to the changes in the way shaders are handled. I'm out of ideas here.

The issue still persists and basically leaves my program unusable, has anyone found anything regarding this?

Any update on this?  This is also happening in my homebrew application which also heavily relies on sf2dlib.
I don't know if this would help debug, but...
After loading this up in citra-qt with a gdb instance attached I'm seeing it hang or something else strange is happening.  I placed a breakpoint at the start of the main game loop stepping through it, it works file but allowing it to run for several seconds it eventually starts doing the following
(gdb) bt
#0  svcWaitSynchronization ()
at /devkitPro/ctrulib/libctru/source/svc.s:210
#1  0x0017a368 in gspEventThreadMain (arg=)
at /devkitPro/ctrulib/libctru/source/services/gspgpu.c:151
#2  0x0017cc30 in _thread_begin (arg=)
at /devkitPro/ctrulib/libctru/source/thread.c:36
#3  0x00000000 in ?? ()
I will also note that commenting out the drawing functions the input appears to be working fine except nothing is drawn of course!
So I suspect its a case of deadlock...

Blast, I completely forgot about this! >_>
sf2dlib, when using citro3d, essentially has VSync. After calling sf2d_swapbuffers(), it waits until the current frame actually gets displayed, if I understand correctly. (someone please feel free to correct me on this)
What I did was move my sound loading stuff into another thread, leaving graphics and collision (which could probably also be in another thread... shrugs) in the main thread. Now I get a steady framerate and steady sound.

Cyanogen3DS doesn't even use sound (yet), and the framerate issues still occur. There are also many graphical glitches. I have certain 'overlays' on my project. For example if the cursor (which is controlled by the d-pad/c-pad/analog) goes over a certain x and y axis, another asset will be displayed over the current to make it sort of 'highlight'. These things are causing glitches on both screens, which never used to happen with the old GPU code. It's funny how everything was working fine and progress was going smooth, then this just completely transformed my project into an unusable state. I literally changed nothing, except adopting to the new citro3d changes (include -citro3d in the libs, and minor makefile stuff). Didn't mess with the source in any other way, so I really don't know what's going on. I might as well just give on my project.

@kitling  that sounds plausible and I'm inclined to believe you since commenting out the swap_buffers call does make my app respond to input but doesn't show anything (as expected).
If this is definitely the case then I'm miffed that the documentation wasn't updated with this new unexpected behavior or mentioned in the commit that switched this to using citro3d some warning would have been appreciated.
So you are suggesting shoving off the rendering to a different thread since sf2d_swap_buffers will now block until the screen is actually showing the contents of what was drawn correct?  If this is the case then the question is why doesn't the library just spawn threads to do itself so that the behavior is left unchanged?
and joel16 don't give up!  There's probably one/two pieces missing out of the puzzle here.
Anyway I am thankful, for the support in keeping this maintained I like the simplicity of this library.

@joel16 I'd recommend you to use citro3d directly. Wrap some of the code here in a thin layer and you'll be fine: https://github.com/devkitPro/3ds-examples/blob/master/graphics/gpu/gpusprites/source/main.c

Didn't even think about using citro3d directly, but I'll give it a shot.
Thanks for your suggestion.


Baseline: duplicate removal and cross cleaning

Applies duplicate removal and cross cleaning for all objects.
Validation plots are here: https://www.classe.cornell.edu/~mgr85/SegmentLinking_keep/PR77/

Timing

TC % breakdown:


optionally add a floating indicator onto observation photos

https://groups.google.com/forum/#!topic/inaturalist/MYVF4Qhypyg
Discussion of this enhancement in the group is pretty supportive, but there's no input from any devs.  Maybe we can get something going here about how this would actually look & work in practice?

Sifting through old issues here. Please actually describe what change you're proposing here and don't just link to a description elsewhere. I don't know what you mean by a "floating indicator" or what part of the website you're proposing adding it to.


Multiple concurrent migrations don't work due to "template1" database being used

Environment

Elixir version (elixir -v): 1.4.0
Database and version (PostgreSQL 9.4, MongoDB 3.2, etc.): PostgreSQL 9.6.1
Ecto version (mix deps): 2.1.3
Database adapter and version (mix deps): postgrex 0.13.0
Operating system: OS X 10.12.2

Current behavior
When doing mix ecto.create, a connection is opened to the template1 database. However, if there is already another connection to template1, the database creation will fail:
** (Mix) The database for Envoy.Repo couldn't be created: ERROR 55006 (object_in_use): source database "template1" is being accessed by other users

There is 1 other session using the database.

To reproduce this, just do psql -d template1 and leave that prompt open while doing mix ecto.create in another terminal window.
Expected behavior
Creating the database should succeed no matter how many connections there are to template1. This is especially true for running multiple mix ecto.create tasks concurrently.
Additional info
This is documented PostgreSQL behavior, as you can read here: https://www.postgresql.org/docs/current/static/manage-ag-templatedbs.html
The problem with this is, if you have multiple applications that have their database on the same database server, creating the databases will fail if you happen to do that concurrently. I have never seen this happen in production, but in theory it could.
We also have a Docker environment for running our microservices landscape on our local development machines. There, we execute migrations and database creation on startup. In that environment, we can see this behavior rather often, which is not ideal.

Do you have any suggestions on how to solve this problem?

Well, I'm not an expert when it comes to PostgreSQL. Probably connecting to a different database for mix ecto.create would be sufficient. But I'm not sure what the best practice is.
I found this very old PR where people discussed whether to connect to template1 or postgres: https://github.com/elixir-ecto/ecto/pull/260
So maybe using postgres is the better alternative after all? I could try reproducing the issue with the postgres database and report my findings. Other than that, I can only search Google for best practices on this.

@mmainz if you can do the research, that would help us a ton. We can also see what other frameworks are doing. The fix itself is likely straight-forward. Finding the right fix is the tricky part. :)

@josevalim sure, I already tried to find out what ActiveRecord does, but that source code is a little tricky to read :)
I'll give it another shot. Then I'll see if I can find something in the PostgreSQL documentation. When I made up my mind, I'll check if the problem is eliminated if I make the appropriate change. I'll come back to you then :)

Postgres documentation states that you should use the postgres database for stuff like creating new databases. That is also the database used by CLI tools like createdb. After some digging, it seems Rails does also use the postgres database for that. You can find the relevant documentation page here: https://www.postgresql.org/docs/current/static/manage-ag-createdb.html

Initdb CLI is used to create a postgresql database cluster, which, by
default, should contain template0, template1 and postgres databases.
Standard and third party applications assume the existance of postgres
database in a postgresql database cluster (abbreviated as cluster)
template1 is used only during creation of new database within the cluster.
Database administrator can create additional database within the cluster.
I am new to Elixir and Ecto. If ecto.create is used to create new database
within the cluster, the described behaviour (not able to connect to
template1 if it is connected by more than 1 connection) is correct.
On 25 Jan 2017 05:26, "Mario Mainz"<EMAIL_ADDRESS>wrote:

Postgres documentation states that you should use the postgres database
for stuff like creating new databases. That is also the database used by
CLI tools like createdb. After some digging, it seems Rails does also use
the postgres database for that. You can find the relevant documentation
page here: https://www.postgresql.org/docs/current/static/manage-ag-
createdb.html
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/elixir-ecto/ecto/issues/1925#issuecomment-274943826,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AEBUt1ppwI3CwHzscVKH1Es9fa7XWgNzks5rVmyAgaJpZM4Lsgnq
.


Util.Generic.mapType is too long

The mapType function has grown longer than it should have and hinders both comprehension for readers and composition for writers

I attempted to handle this, but I'd like input on how well I've done so. I'm leaving it on dev for now, but closing this issue till I receive any feedback.


Support for OpenAPI 3.1

Hi,
I tried to generate an api client based on a json openapi v3.1.0 (https://docs.publiq.be/docs/uitdatabank/taxonomy-api%2Fopenapi-file), but validation fails as OAS3.1 seems to be not (yet) supported.
I've listed some of the validation exceptions:

"Unsupported openapi version: 3.1.0"
"Reference: additional properties are given. Only $ref should be set in a Reference Object."
"Invalid key 'Event-@id' used in Components Object for attribute 'schemas', does not match ^[a-zA-Z0-9\\.\\-_]+$."
"Invalid key 'Organizer-@id' used in Components Object for attribute 'schemas', does not match ^[a-zA-Z0-9\\.\\-_]+$."

What could/should be done to provide support for OAS 3.1?
I'm not familiar with the inner workings and detailed OAS specs, but open to collaborate.
PS: tried to downgrade the json from 3.1 to 3.0 which, when trying to generate the api client afterwards, only throwed the "Invalid key" exceptions twice.
Thanks,
Glenn

Hi @glenncoppens, can you please share the command you used so I can try to reproduce it?
OAS3.1 should be supported out of the box so it could be something with the spec, I pasted it in https://editor.swagger.io/ and it shows some similar warnings...
Additionally, maybe you have a YAML version to test?

thx for the command, I ran it here and did some debugging, ik what the issue is 😄 please bear with me:

this generator uses cebe/php-openapi to parse the file and the lib doesn't support OAS 3.1 so yes, you're right, this generator currently doesn't support OAS 3.1

this cebe/php-openapi has an open issue for this topic https://github.com/cebe/php-openapi/issues/101, but not much interest in pushing this forward apparently

for your case specifically, you can edit the json to be able to generate a php 8 client with our generator if you do this:

use "openapi": "3.0.0" instead of "openapi": "3.1.0" (guess you tried that already but there's 1 more thing you need to do)
change the get-terms operationId to getTerms, apparently we have an issue with dashes in operationId
you can keep the 2 "examples" keys (which are not compatible with 3.0.0) because they will simply be ignored by the generator

I'll open an issue here in github for this operationId handling to be fixed, and we can keep your issue opened to add proper support for OAS 3.1, but I hope with these 2 changes you can generate your client in the meantime

@vsouz4
Oh thanks!
But see I pasted the wrong OpenAPI file, it should have been this one: https://stoplight.io/api/v1/projects/publiq/uitdatabank/nodes/reference/entry.json?deref=optimizedBundle
But as per your suggestion I've managed to remove those errors you mentioned.
There's only one error left:
"Reference: additional properties are given
  . Only $ref should be set in a Reference Object.","Invalid key 'Event-@id' used in Co
  mponents Object for attribute 'schemas', does not match ^[a-zA-Z0-9\\.\\-_]+$.","Inva
  lid key 'Organizer-@id' used in Components Object for attribute 'schemas', does not m
  atch ^[a-zA-Z0-9\\.\\-_]+$.","Invalid key 'Place-@id' used in Components Object for a
  ttribute 'schemas', does not match ^[a-zA-Z0-9\\.\\-_]+$.",

... omitted

But I'm guessing it's related by having a dash in the key?
I've attached a version of the OpenApi file with already renamed "operationId" keys.
entry-api-3.json
Is it possible to rename those key references in an OAS3.0?

I'm able to generate a client if:

you replace openapi: 3.1.0 with openapi: 3.0.0
you rename all operationId to camelCase (btw created a PR to fix that, will merge as soon as it gets approved https://github.com/DoclerLabs/api-client-generator/pull/107)
you remove the 1 endpoint (operationId: image-post) that requires multipart/form-data from the spec because that's also not currently supported
you remove the peer properties to $ref (allowed in json schema / oas 3.1 but not in oas 3.0) - they're irrelevant for the client generation anyways

how I did that with vim:
:%s/\([^"]*\)".*,\n\s*"\($ref.*\)/\1"\2/
:%s/\($ref": .*\),\n\s*"description.*/\1/

you replace the -@ with just -

:%s/-@/-

but FYI the generated code will completely ignore the "if" / "then" and "dependentRequired" from json schema / oas 3.1 (and any other props I might've missed)
last but not least, we currently don't support type: oauth2 in security still, so this is also being ignored atm, any help is very much appreciated to add support for that


Redux Toolkit: responseHandler should always be serializable

Addresses points brought up in https://github.com/rtk-incubator/rtk-query/issues/154
We have a use case where we need to consume the headers of the response. It looks like that we could handle this case through responseHandler by returning the raw Response : (response) => response. However, it seems that Redux Toolkit complains when responseHandler is a function (because it is not serializable). Thus, it appears that a suitable approach would be to simply add 'raw' as a potential responseHandler type, then to handle the raw Response with transformResponse (see corresponding tests).

I'll take a look tomorrow. It seems reasonable, but I want to check if we don't have other options that lead the the same pitfall.
You have seen that you can use the codesandbox build above meanwhile?

I'll take a look tomorrow. It seems reasonable, but I want to check if we don't have other options that lead the the same pitfall.
You have seen that you can use the codesandbox build above meanwhile?

OK, looking forward to your review tomorrow 👌By the way, many thanks for the codesandbox tip, I hadn’t seen it 👍

OK, looking forward to your review tomorrow 👌By the way, many thanks for the codesandbox tip, I hadn’t seen it 👍

Unfortunately, there's a bunch of other options with the same problem. I've opened #156 to try and find a more broad solution. Can you take a look please?

 I've opened #156 to try and find a more broad solution. Can you take a look please?

Solved by #156

Solved by #156


Rename "scaling" right shifts

I argue that the Vector Single-Width Scaling Shift Instructions, vssr*, don't perform any "scaling" --- in the usual (multiplicative) sense --- beyond their non-scaling counterparts, vsr*. What distinguishes these instructions is rounding behavior. The "s" in their mnemonics may also confuse with "saturation", a la vsadd*, vssub*, and vsmul*. (What mnemonics would we use for saturating left shifts, a possible RVV 2.0 feature?)
A comprehensive solution to my nitpick involves changing the mnemonics to vrsr*, but frankly I can't stomach more churn.
In this PR I propose to replace "scaling" by "rounding" in Section 13.4, and interpret the "s" in the mnemonics to abbreviate "single-width". This is a purely superficial change.

Spec has been ratified so I'm closing this.


Bug: 7zip size information isn't shown correctly

Description
Title
Steps To Reproduce

Create a .zip or .7z archive
Go to properties of archive
See uncompressed size as 0b

Steps to fix

Correctly disable the archives uncompressed size

Files Version
<IP_ADDRESS>
Windows Version
10.0.22621.875
Relevant Assets/Logs
debug.log

Fixed by #10563


Refactor: try this way，to prevent overflows

I don't understand this change.
>>> won't fail until 2 ^ 32, which is 4_294_967_296. The shift is being applied to start + end, so the queue itself would need to be half that size to overflow. It doesn't seem realistic for the scheduler queue array to contain 2 billion items. I suspect the browser would crash long before we got to that point.
I'm also unclear why we would want to switch from >>> to >>. Wouldn't that overflow sooner?
The proposed change only avoids the overflow in some specific edge cases. Specifically, when start and end are both large. If end is large and start is small then it doesn't really make any difference, it'll still overflow.
If there is a way for this to overflow in real usage then we can use other techniques to do the division, but I think we'd have to identify what those use cases are before making a change.

Closing this because it does not have an issue assigned and based on skirtles is unclear the intention.


[FEA] docker images w/ spark-rapids released artifacts for public usage

Maintain docker images on public registry like docker hub.
The images should be well-documented and easy-to-use,
we can firstly deploy those images to URM and then public registries

we are releasing docker images with both Apache Spark in it and the spark rapids plugin?     For what env?  k8s, yarn, etc?

we are releasing docker images with both Apache Spark in it and the spark rapids plugin? For what env? k8s, yarn, etc?

We are not going to release any images for now. The issue here is to track if we decide to provide out-of-box docker image in some public registry for quick starter, it could just contain specific spark bin and plugin & cudfJNI artifacts


Create sym link to SNAP_COMMON

To stop hard coded host mounts from using the wrong directory.

Tested with the previously failing Ceph CSI helm chart.

https://github.com/ubuntu/microk8s/pull/2095 Is already merged into this to avoid conflict after it's merged to master.


improve docs: useStateList demo link

Added a demo link for useStateList

Thanks!

:tada: This PR is included in version 12.3.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Match request

Codecov Report

Merging #13 into master will decrease coverage by 0.47%.
The diff coverage is 96.92%.

@@            Coverage Diff             @@
##           master      #13      +/-   ##
==========================================
- Coverage   93.16%   92.68%   -0.48%
==========================================
  Files           5        5
  Lines         117      123       +6
==========================================
+ Hits          109      114       +5
  Misses          5        5
- Partials        3        4       +1

Impacted Files
Coverage Δ

internal/error.go
50% <ø> (ø)

internal/server.go
100% <100%> (ø)

internal/route_matchers.go
88.57% <100%> (ø)

internal/handler.go
92.3% <100%> (ø)

internal/imposter.go
80% <80%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 36f066a...d1fd157. Read the comment docs.


Prepend emojis indicative of success for !eval

Comments on org-issue-141 suggests something quite useful.
Add emojis indicative of success when you use !eval.

✅ - if no error.
❌ - if exception.
❗ - for other cases, as it runs but there's no output

I think ⚠ is better for the third one since it's yellow rather than red. More distinct from the :x: that way.

I'd like to work on this, since I personally use this more often than not. Unless you are working on it with other plans like bringing 3.8 to snekbox @MarkKoz

You can go for it. My plans are only concerned with CI.

I had this assigned and was working on this, you can have it though.

Ah no no, it has been quite a while and so I thought no one has taken it, @kosayoda
If you are already on it please dont mind me

Sorry I was on mobile at the time of commenting and wasn't aware it was already assigned.


Relay Maintainer: Added LightRelay contract to Tbtc chain

Depends on https://github.com/keep-network/keep-core/pull/3378.
This PR adds LightRelay contract to the Tbtc chain, so that the contract can be accessed from the Tbtc chain.

@tomaszslabon Can you please rebase this PR now when #3378 is merged?

@tomaszslabon Can you please rebase this PR now when #3378 is merged?

Yes. I already did.

no more comments

Note that based on this discussion some components added in this PR should be located in pkg/maintainer and not pkg/tbtc/maintainer. I am merging it as-is it do not create merge conflicts later, but please take it into account when working on #3394.


Document Carthage setup with EarlGrey gem & Add Carthage badge

Update: Waiting on next EarlGrey release to write the docs because 1.0.0 isn't Carthage compatible.


fix: add info for problem 54 - project Euler

Checklist:

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)
[x] My pull request targets the master branch of freeCodeCamp.
[x] All the files I changed are in the same world language, for example: only English changes, or only Chinese changes, etc.

Problem 54 has a vague input description. It doesn't mention the test case.
Mentioning the test case is useful when someone wants to try out on their local machine, or in another programming language.

Thank you for opening this pull request.
This is a standard message notifying you that we’ve reviewed your pull request and have decided not to merge it. We would welcome future pull requests from you.
Thank you and happy coding.

Well, the problem is incomplete, you can't argue with that

@AdrianMuntean You are correct.  It was my mistake in closing it.  However, instead of linking to the external file, maybe we can just state:

The global array (arr) that will be passed to the function contains one-thousand string elements representing random hands dealt to two players. Each element of the array contains ten cards (separated by a single space): the first five are Player 1's cards and the last five are Player 2's cards. You can assume that all hands are valid (no invalid characters or repeated cards), each player's hand is in no specific order, and in each hand there is a clear winner.

@AdrianMuntean Feel free to reopen and consider using the text I have suggested above.  Sorry for closing so quickly.

@RandellDawson I couldn't re-open it caused I have removed the branch. I have created a new one https://github.com/freeCodeCamp/freeCodeCamp/pull/40057. I have updated with your suggestion. Thanks


Should be able to specify vapp_storage_profile per disk pool (not unique global storage profile)

When deploying big deployments, like cloudfoundry, it would be much more efficient to to able to specify vapp_storage profile for each disk pool.
This parameter is on bosh config, which requires all deployments to use the same storage profile. Cant optimize for io intensive jobs ...

@poblin-orange that makes sense.


Private credential issuance

@lovesh can you resolve the conflict on index.md?

Merge conflict is fixed.


fix: improve error message for plugin

Resolves #867
Signed-off-by: Junjie Gao<EMAIL_ADDRESS>

Codecov Report
Attention: 11 lines in your changes are missing coverage. Please review.

Comparison is base (ee72394) 65.14% compared to head (b8b91bd) 64.95%.

Files
Patch %
Lines

cmd/notation/plugin/install.go
40.00%
4 Missing and 2 partials :warning:

cmd/notation/plugin/list.go
0.00%
5 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #870      +/-   ##
==========================================
- Coverage   65.14%   64.95%   -0.19%
==========================================
  Files          45       45
  Lines        2717     2731      +14
==========================================
+ Hits         1770     1774       +4
- Misses        787      795       +8
- Partials      160      162       +2

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

When running command on a malformed plugin executable file on Windows:
./notation.exe plugin install --file ./malformed-plugin/azure-kv/notation-azure-kv.exe, the command returns following error message:
Error: plugin installation failed: failed to get metadata of new plugin: failed to execute the get-plugin-metadata command for plugin azure-kv: fork/exec ./malformed-plugin/azure-kv/notation-azure-kv.exe: This version of %1 is not compatible with the version of Windows you're running. Check your computer's system information and then contact the software publisher..
Please ensure the plugin is executable and meet the installation requirements on the windows/amd64.

On linux:
Error: plugin installation failed: failed to get metadata of new plugin: failed to execute the get-plugin-metadata command for plugin azure-kv: fork/exec test-plugin/malformed-plugin/azure-kv/notation-azure-kv: exec format error.
Please ensure the plugin is executable and meet the installation requirements on the linux/amd64.

These error messages are quite verbose though, can we improve them?

When running command on a malformed plugin executable file on Windows: ./notation.exe plugin install --file ./malformed-plugin/azure-kv/notation-azure-kv.exe, the command returns following error message:
Error: plugin installation failed: failed to get metadata of new plugin: failed to execute the get-plugin-metadata command for plugin azure-kv: fork/exec ./malformed-plugin/azure-kv/notation-azure-kv.exe: This version of %1 is not compatible with the version of Windows you're running. Check your computer's system information and then contact the software publisher..
Please ensure the plugin is executable and meet the installation requirements on the windows/amd64.

On linux:
Error: plugin installation failed: failed to get metadata of new plugin: failed to execute the get-plugin-metadata command for plugin azure-kv: fork/exec test-plugin/malformed-plugin/azure-kv/notation-azure-kv: exec format error.
Please ensure the plugin is executable and meet the installation requirements on the linux/amd64.

These error messages are quite verbose though, can we improve them? (contents starting with fork/exec are already in the DEBUG log)

Updated to:
./bin/notation plugin install --file ~/download/notation-azure-kv_1.0.1_darwin_amd64.tar.gz -d
DEBU[2024-01-18T12:55:26+08:00] Extracting file notation-azure-kv...
DEBU[2024-01-18T12:55:26+08:00] Extracting file LICENSE...
DEBU[2024-01-18T12:55:26+08:00] Installing plugin from plugin path /tmp/notation-plugin2182206927
DEBU[2024-01-18T12:55:26+08:00] Plugin get-plugin-metadata request: {}
ERRO[2024-01-18T12:55:26+08:00] plugin get-plugin-metadata execution status: fork/exec /tmp/notation-plugin2182206927/notation-azure-kv: exec format error
Error: plugin installation failed: failed to get metadata of new plugin: failed to execute the get-plugin-metadata command for plugin azure-kv.
Please ensure the plugin is executable and meet the installation requirements on the linux/amd64.


P2-Make all folders configurable parameters with current names as their default value.

retrieve_results, rerank_results, prompts_and_responses, token_counts are the four folder names that are hardcoded in the code, Ideally, these should be configurable input parameters with default values

Now that the ResultsWriter takes filenames as input, this is a p2. The only place where read and write happens with default hardcoded values are in reranker.write_rerank_results which is called from retrieve_And_rerank which is not the main form of using our API.

@sahel-sh Is this issue still needed, I see that in reranker.write_rerank_results the writes are already replaced with the ResultsWriter class.

@sahel-sh Interested in this (if still open).

@sahel-sh Is this issue still needed, I see that in reranker.write_rerank_results the writes are already replaced with the ResultsWriter class.

You are right,  as I mentioned in comment #2, the only part that folder names are hard coded is inside the write rerank results. In this function they are calculated based on some parameters that the user provides, but it doesn't have to be this way.  This function can optional three file names/path to store the results

@sahel-sh Interested in this (if still open).

It is yours

@sahel-sh Made a PR here https://github.com/castorini/rank_llm/pull/82

Thank you @yilinjz for working on this!


Add option for explicit StructLayout on generated interop structs

ClangSharpPInvokeGenerator-generated interop structs introduce CS0649 (field never assigned) warnings with the default set of C# compiler flags.  The warning can be disabled at the project level easily, but that's not desirable for projects that include user code with the generated types, and disabling the warnings per-type is tedious.
Another option for disabling the warnings is to include explicit [StructLayout(LayoutKind.Sequential)] attributes on the structs.  Since this attribute only sets a flag in IL (and is just making the default explicit anyway), there's no size cost for including it.  At present, I'm inserting those using the --with-attribute option, but again, defining the type list for that option is tedious.
How about a global option that includes StructLayout for all generated structs, or maybe even just making that a default behavior?

Another option for disabling the warnings is to include explicit [StructLayout(LayoutKind.Sequential)] attributes on the structs

Could you share a simple repro in ClangSharp, this doesn't sound right and sounds like a compiler bug. StructLayout should have no effect on definite assignment.

Given this project:
<Project Sdk="Microsoft.NET.Sdk">

  <PropertyGroup>
    <TargetFramework>net6.0</TargetFramework>
    <Nullable>enable</Nullable>
    <AllowUnsafeBlocks>true</AllowUnsafeBlocks>
  </PropertyGroup>

</Project>

using System.Runtime.InteropServices;

[StructLayout(LayoutKind.Sequential)]
internal unsafe partial struct native_error
{
    public int code;

    public int subcode;

    public sbyte* message;
}

internal unsafe partial struct native_error2
{
    public int code;

    public int subcode;

    public sbyte* message;
}

dotnet build gives warnings on native_error2 but not on native_error
sample.cs(15,16): warning CS0649: Field 'native_error2.code' is never assigned to, and will always have its default value 0
sample.cs(19,19): warning CS0649: Field 'native_error2.message' is never assigned to, and will always have its default value
sample.cs(17,16): warning CS0649: Field 'native_error2.subcode' is never assigned to, and will always have its default value 0
    3 Warning(s)

Oh, you don't get the warning if the type is public.  That's probably why you haven't noticed it.
FWIW, dotnet/runtime uses the attribute trick on interop types extensively
https://grep.app/search?q=StructLayout(LayoutKind.Sequential)&filter[repo][0]=dotnet/runtime


[Top Pool] Separate storage of trusted Getters and Calls

The top pool does not differentiate between getters and calls. It simply saves them as Trusted operation into a hashmap. However, we now operate a separate time & shard loop for getter and calls (see overview).
Hence, to get either of them all top pool operations of the specific shard need to be iterated through.
It might be sensible to differentiate between getters & calls within the top pool.

Yes, this should definitely be separated. Now with sidechain consensus even more. I think the following pattern would make sense:

worker is current authority: only execute trusted calls
worker is not current authority: only execute trusted getters.

This should maximize the stf-executions per second throughput of a sidechain.

We have decided to use two separate pools for this matter. So this issue can be closed.