dry run?

here (the 'validate a workflow' section) it says  "It does not perform a “dry run” or check to see if any of your inputs are actually available, only that it can interpret what you told it."
to me, an obvious question here is - is there such a thing as a 'dry run' with Cromwell/WDL?   I have not (yet?) tackled learning snakemake but I think I know enough to have an idea of what 'dry run' means, and it seems like a very appealing concept.
If there is a way to do a dry run, would be great to tell us how. If not, also perhaps helpful to say it's just not a thing for WDLs.
same goes for the "check to see if any of your inputs are actually available" part - is there a capability for that?

Good point!
Cromwell doesn't really have a dry run mode per se, but this validate process IS basically what those other tools consider to be a dry run.   I edited it to be the following text?

This checks the format of your workflow files to make sure you have a valid file in a known format that Cromwell can interpret.  This is called a "dry run" to ensure that your tasks are wired up correctly, but Cromwell does not try to see if any of your inputs are actually available, only that it can interpret what you told it. One of the reasons this is is that since Cromwell can pull files from local filesystems, AWS S3, Google buckets and Azure blobs, the process to test it's ability to actually get your inputs will happen while you run the workflow the first time.  Luckily, Cromwell will only get file inputs it needs at that moment, and if it can't it won't do that specific task (but can continue with the other tasks it can do!).

yes, that makes sense, and that's useful.  Can I suggest a rewrite for clarity?

This checks your workflow files (wdl / jsons) to test:

are they in a known format that Cromwell can interpret?
are they formatted properly?
are the tasks wired up correctly?
This is called a "dry run".
Note that this does NOT test whether your input files are actually available, partly because Cromwell can pull files from local filesystems, AWS S3, Google buckets and Azure blobs. The process of testing input availability will only happen when you run the workflow for the first time. If some input files are missing, Cromwell will run tasks for the input files that ARE available, skipping tasks where inputs can't be found.

I can see myself WANTING to check all the inputs before I start when a workflow is long, so that I can troubleshoot immediately rather than a day later.   Is that something you sometimes do?   e.g. I could imagine writing an additional task at the start of the workflow that checks for existence of ALL inputs from the workflow, and exits if one or more are missing.
Example - let say in diy-cromwell-server/testWorkflows/tg-wdl-VariantCaller you want to check for the annovar inputs like known_indels_sites_VCFs upfront, so that you know you have all your ducks in a row before running the whole thing.

I have put in your text into WDL 101 now with PR #35 .  However the issue of actually testing for workflow inputs should live in WDL 102 I think.  I'm not aware of a function in Cromwell that will do what you're wanting so I need to go explore a bit and see if it exists, and then document it in WDL 102 if it does.  OR like you say, make a hacky "input tester" task (I actually have this for another reason), that you could copy and use at the beginning of your workflow to force localization of all inputs prior to running anything.


Load developers from json file

In this pull request I changed the data source of the developers to be pulled from the json file not the markdown file.

This certainly looks better than parsing the HTML table. Thanks for working on the JSON representation of the data!


use DDSUBLINK instead of LINK2

DDSUBLINK uses ROOT_DIR which is more robust than a relative path.
Together with https://github.com/D-Programming-Language/dlang.org/pull/1159 this fixes the link in the online DDox docs.

Auto-merge toggled on


Allow customization of resolve/rejection handling for status codes

Currently any non-200 level status code will be rejected. In most cases this makes sense, but if you are anticipating a certain status code this can break control flow as it does here
const response = await axios.get(url);
if (200 === response.statusCode) doA();
if (422 === response.statusCode) doB();
doC();

There is currently no way to do this without handling the rejection on your own which can be unintuitive.
request-promise handles this with the simple option. I think it would be even better to allow users to define ranges or maybe a function that determines resolution / rejection based on header information.

I actually agree with this idea. See my comment here https://github.com/mzabriskie/axios/issues/41#issuecomment-72732209.


Variable suggestions for order description do not work configuration page

Expected behavior
I expect variables not to be translated for the current locale. They should be English.
Actual behavior
Variables to be used in order descriptions are translated into Dutch. These variables do not work.

Steps to reproduce the behavior

Install PrestaShop
Import Dutch locale
Enable Dutch in backoffice
Install mollie
Go to configuration page and open a method

Environment

PrestaShop version: <IP_ADDRESS>
Mollie module version: 4.5.2
PHP version: 7.1.32

Hey there, @muyncky!
Thank you for raising this request!
We will overview everything, and get back to you!
Best Regards,
Invertus Support team.

Hello there @muyncky!
Our team has fixed the issue, you will be able to see everything in the next release, which should be done around the middle of September.
If you have any other questions, let us know!
Best Regards,
Invertus Support team.


All section query

Worked with @anandaroop on this PR
Removes PartnerShows from queries
Adds correct sort to city and museum tabs/lists/bricks
Adds upcomingShows to globalMap query
Shows upcoming saved shows on map

Fails

:no_entry_sign:

[danger-plugin-jest] Could not read test results. Danger cannot pass or fail the build.

  Generated by :no_entry_sign: dangerJS

Fails

:no_entry_sign:

[danger-plugin-jest] Could not read test results. Danger cannot pass or fail the build.

  Generated by :no_entry_sign: dangerJS

Resolve these conflicts locally and pushed.

🎉


Unable to get device authorization token

I use docker to run the program. The log shows this error when logging in：
[2023-10-10 12:09:18.211 +0800] ERROR: Unable to get device authorization token
user<EMAIL_ADDRESS>err: {
"type": "Error",
"message": "Unable to get device authorization token",
"stack":
Error: Unable to get device authorization token
at DeviceLogin.waitForDeviceAuthorization (/usr/app/src/device-login.ts:309:15)
at processTicksAndRejections (node:internal/process/task_queues:95:5)
at DeviceLogin. (/usr/app/src/device-login.ts:190:36)
}

I get the same error.
By clicking the login link a second  time or restarting the node and clicking login link again, I was able to bypass the error and eventually the cookie got successfully stored.

I'm having the same issue. Here's the 400 Bad Request response from EpicGames:
{
    "errorCode": "errors.com.epicgames.common.oauth.invalid_grant",
    "errorMessage": "invalid_grant",
    "messageVars": [],
    "numericErrorCode": 1012,
    "originatingService": "com.epicgames.account.public",
    "intent": "prod",
    "error_description": "invalid_grant",
    "error": "invalid_grant"
}

I think Epic Games disabled device code authorization for the fortnite client ID we were using. Not sure if there's another one available.

Updating the client used in your config.json might work. I scanned all the known clients and only this one (Diesel - Dauntless) got anywhere:
    "deviceAuthClientId": "b070f20729f84693b5d621c904fc5bc2",
    "deviceAuthSecret": "HG@XE&TGCxEJsgT#&_p2]=aRo#~>=>+c6PhR)zXP",

Something strange is happening on my local machine, so I'm not able to test it in full. Feel free to try it out though.

@claabs Thanks for looking into it. Unfortunately, I got the same error with this client.

I get the same error.
By clicking the login link a second time or restarting the node and clicking login link again, I was able to bypass the error and eventually the cookie got successfully stored.

I can repeatedly reproduce this behavior. The first login produces the "Unable to get device authentication token" error in the logs. However, using the same redirect link, in the same browser (auth-ed), a second time succeeds.

I was able to test a bunch of the auth clients, and the default one seems to still work fine for me. I updated the alternate values in the docs with the only other clients that worked as well: https://github.com/claabs/epicgames-freegames-node/commit/1cae032377eb72823f8faa102af41ae6d8efd1cd

Note: If your network is poor (e.g. slow to open the device authorization verification link), you can appropriately increase the parameter deviceAuthPollRateSeconds, so that you can avoid aborting before you successfully log in by sending a request and getting a 400 error code. That works for me.

That's actually the root of the problem. This error was being returned, but not logged:

Request frequency should not exceed one call per 10 seconds

Changed the default poll rate in https://github.com/claabs/epicgames-freegames-node/commit/4b3126ec374f9270626ddce696d53703f6c23b32


Update dependencies

I just started learning ZIO and this g8 template helped me a lot!
It introduces a couple of small fixes - see commit log.

@whysoserious please run scalafmt

@whysoserious please run scalafmt

ok, nvm, scalafmt doesn't work on the template level (yet)


Improve error handling

When request fails with error it read "OpenSearch error..." which could be confusing is someone has configured Elastic? For example when testing datasource it shows below even when Elastic is selected:

Originally posted by @ifrost in https://github.com/grafana/opensearch-datasource/pull/5#discussion_r721940972
In general we should improve error handling to have better messages.

I am getting above error while adding "OpenSearch" data source in grafana.

hi @makvac-aws can we start with some basic info first? can you describe your configuration (grafana version, plugin version, how are you configuring the datasource)? and is there anything in the logs worth noting?

Hi Team,
This is what I have configured. I am using Amazon Managed Grafana.
URL: OpenSearch url
Access: Server(Default)
SigV4: Enabled
Authentication Provider: Workspace IAM Role
Assume Role ARN: AWS Role ARN
Default region: us-east-1
Index name: *
Pattern: Hourly
Time field name: @timestamp
Version: I tried Elasticsearch 7.0+ as well as OpenSearch 1.0x. Both are giving the same error.
Regards,
Chetan Makvana
(E<EMAIL_ADDRESS>(M) +91 77740 37191
AISPL | aws.amazon.com
@.***
Work hard. Have fun. Make history.
From: Giordano Ricci @.>
Sent: Wednesday, November 10, 2021 3:23 PM
To: grafana/opensearch-datasource @.>
Cc: Makvana, Chetan @.>; Mention @.>
Subject: Re: [grafana/opensearch-datasource] Improve error handling (#6)
hi @makvac-awshttps://github.com/makvac-aws can we start with some basic info first? can you describe your configuration (grafana version, plugin version, how are you configuring the datasource)? and is there anything in the logs worth noting?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/grafana/opensearch-datasource/issues/6#issuecomment-964962059, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ARLQ2BAFPECOH5YCQSJFQXDULI6GZANCNFSM5FL2L2ZA.
Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

I'm not sure what version of Grafana and OpenSearch plugin is running on AMG, chan you please check this?
Also, do you have access to any logs? do they contain some useful information?
I don't know much about sigv4, but locally I get the same error if I do not set skip TLS verify or if I don't correctly set basic auth for the DS, in that case the error is not raised by grafana but by OpenSearch itself, so can you double check your auth settings? i do not have access to the same environment myself, so it's quite hard to debug

Grafana version is 8.0 and ElasticSearch is 7.9. I don't have access to any logs.
I also tried setting skip TLS verify and basic auth, still same error

@makvac-aws i've been trying to figure out what could be wrong with your setup but it's quite hard without having access to the logs. is there a way we could get them?

Guys, this is Amazon Managed Services - we do not have Grafana Logs.


Deleted stuff for testing Windows agent

High-level description
This PR is deleting stuff for test Windows agent
Corresponding DC/OS tickets (required)

D2IQ-67984 JIRA title / short description.

Related tickets (optional)

D2IQ-ID JIRA title / short description.

Checklist for component/package updates:
If you are changing components or packages in DC/OS (e.g. you are bumping the sha or ref of anything underneath packages), then in addition to the above please also include:

[ ] Change log from the last version integrated (this should be a link to commits for easy verification and review): example
[ ] Included a test which will fail if code is reverted but test is not. If there is no test please explain.
[ ] Test Results: [link to CI job test results for component]
[ ] Code Coverage (if available): [link to code coverage report]

@mesosphere-mergebot request-review @DominikDary

@mesosphere-mergebot request-review @jeschkies

@mesosphere-mergebot request-review @mediapills

@mesosphere-mergebot label Ready For Review

@mesosphere-mergebot changelog-not-required


Reduce ability to create invalid RDS template

Implement a complex mechanism for reducing the chance of creating JSON
for an RDS DBInstance that is invalid.  My hope is that the complexity
equals and is not greater than the complexity inherent in the
restrictions around RDS creation.  There is still one run-time check
around storage encryption since specifying it is only valid on new
instances created within VPCs.
A couple other minor changes:

Clean up build.sbt
Implement and use EnumFormat for all enumerations JSON serialization

When this change gets merged, the release will have to increment the major version number since this breaks RDS backward compatibility badly.

It's a big set of changes, so it's hard to judge whether it's completely correct, especially not understanding the underlying rules.  I do like the enumeration format.

I stole the enumeration format from @hibikir . I've tried to capture the rules around creation in the Scaladoc, but it is convoluted.

I forgot to include in the commit and above that I also added support for DeletionPolicy.

LGTM. I can't verify that the modeling is perfect, but what I can say is that it's better than the one provided by Amazon. If more changes are needed later, because we didn't quite grasp all the RDS rules, so be it.

I found a few issues with this PR. There is no good way to map from a Token[X] to X, so as it currently stands the fields that are Ints can't take ParameterRef's as values. To allow that, you'd have to accept Token[Int], and then you can't do any math, like checking that the Iops value is valid, since you won't actually have the value at compile/run time.
While I'd like to keep those checks in, I am not seeing a way to do that, so I'm going to convert to using Tokens.

Hmm…  it is possible to code things to know whether you have a raw value or a resource reference, and behave differently depending on the result.  However, I haven't spent enough time looking at the code to try to figure out what's the best way to implement that with the minimum amount of impact on the existing API.

Yes, that is what you would have to do, because there are situations where you literally cannot turn a token into an actual thing at generation time (not knowable, like the parameter case), so you'd have to have two paths and get more checks on only one side
This e-mail message may contain privileged and/or confidential information, and is intended to be received only by persons entitled
to receive such information. If you have received this e-mail in error, please notify the sender immediately. Please delete it and
all attachments from any servers, hard drives or any other media. Other use of this e-mail by you is strictly prohibited.
All e-mails and attachments sent and received are subject to monitoring, reading and archival by Monsanto, including its
subsidiaries. The recipient of this e-mail is solely responsible for checking for the presence of "Viruses" or other "Malware".
Monsanto, along with its subsidiaries, accepts no liability for any damage caused by any such code transmitted by or accompanying
this e-mail or any attachment.
The information contained in this email may be subject to the export control laws and regulations of the United States, potentially
including but not limited to the Export Administration Regulations (EAR) and sanctions regulations issued by the U.S. Department of
Treasury, Office of Foreign Asset Controls (OFAC).  As a recipient of this information you are obligated to comply with all
applicable U.S. export laws and regulations.

I was thinking about using something like Either, but then I figured these values will almost always be parameters, not hard-coded. Well, I may do that if for nothing other than it may be worthwhile to keep the logic in for those reading the code.

I implemented this as Either and fixed a couple other minor things.


Is there a compilation option to compile only float16?

It seems that it only supports the option not to compile float16

I tried changing the compilation options, but it didn't work


Tests executed with Snapshot expect non-localised strings

New Issue Checklist

[x] Updated fastlane to the latest version
[x] I have read the Contribution Guidelines

Issue Description
I have an app localised in English and Spanish. In my UITests, I find elements according to their text, which is localised. For example, I have a simple test that only checks that a cell says "What is Facebook?" in English, and "Qué es Facebook?" in Spanish.
This test succeeds if executed from Xcode. However, when I run the snapshot command, it won't work for Spanish. If I look at the simulator while the Spanish process is executed, I can see that the label is correctly displayed in Spanish (see image below). Still, I also see that the device is not really set in Spanish, as the status bar says Carrier instead of Operador. I am not really sure if this has something to do, but I have seen it was already reported once https://github.com/fastlane/fastlane/issues/1671). It is weird, as the text is well localised and displayed, but snapshot expects the english version.
Complete output when running fastlane, including the stack trace and command used
testDisplayFAQView, Failed to find "What is Facebook?" StaticText after 5.0 seconds.
/Users/user/Documents/Project/UITests/FAQUITests.swift:39

    let firstQuestionCell = tablesQuery.staticTexts["FAQ.Question1.Question".UIlocalized()]
    waitForElementToAppear(firstQuestionCell)

   Executed 1 test, with 1 failures (0 unexpected) in 17.076 (17.080) seconds

[12:41:30]: Exit status: 65
[12:41:30]: Tests failed - check out the log above

Automatic screenshot took by snapshot for English

Manual screenshot took by self when snapshot executed in Spanish

Configuration Files
Snapfile:
devices([
  "iPhone 6"
])

languages([
  "en",
  "es-ES"
])

scheme "Snapshots"

clear_previous_screenshots true

Environment
fastlane version (run fastlane -v): fastlane 1.97.2
snapshot version: snapshot 1.12.3
Do you use bundler to execute fastlane (i.e. bundle exec fastlane)? No
Do you use a Ruby environment manager (e.g. chruby, rbenv, rvm)? No

I've managed to solve this issue from the description of this PR https://github.com/fastlane/fastlane/pull/4313. It would be helpful to include the localize_simulator config in the project's Readme 🙂


Application will not start with NSwag in .net Core 2 - works fine with swashbuckle

After getting all of my client models working with NSwag (amazing tool BTW), I am trying to move my generation across to get the whole chain working with one system.
I have followed the wiki and this, essentially adding the NUGET packages and the Configure code;
`
app.UseStaticFiles();
// Enable the Swagger UI middleware and the Swagger generator
app.UseSwaggerUi(typeof(Startup).GetTypeInfo().Assembly, settings =>
{
    settings.GeneratorSettings.DefaultPropertyNameHandling = PropertyNameHandling.CamelCase;
});`

Unfortunately my application starts, but then hangs trying to get the swagger.json. Any ideas on what I can try to figure out what is going on? It isn't my .net core model because that works perfectly with my swashbuckle implementation - and yes, I did take the sb code out when implementing nswag.
Any help appreciated.

The ui renders correctly? If so, what error do you get if you directly access the swagger.json URL?

That's the weird thing... The json renders perfectly.
A couple of screenshots attached.
swag.zip

Try manually installing Microsoft.AspNetCore.StaticFiles v2.0.2 manually in the host application.
https://www.nuget.org/packages/Microsoft.AspNetCore.StaticFiles/2.1.0-preview1-final

Already have v2.02 installed.
For some reason it works with swagger3.0...
I need jwt support anyway, but would be curious to know what the problem was.
                 app.UseSwaggerUi3(typeof(Startup).GetTypeInfo().Assembly, settings =>             {                 settings.GeneratorSettings.DefaultPropertyNameHandling = PropertyNameHandling.CamelCase;             });

This is really strange, maybe you can F12 (developer tools) in Chrome to see an actual error message?
I think, you should use Swagger UI 3 anyways as this is the way forward...

Even stranger - the whole browser hangs - can't f12 or anything. Really weird. I cant even get the json, unless I shut down the browser and open it again. Not to worry. v3 works

Can we close this or should we investigate?

It works with swagger 3 - so close away.


Controlled configuration changes

Hi there
Love the operator, we use it quite a lot, but I think something that we're lacking is the fact that when making changes, we have this weird issue where if you're running with replica of 2:

change foo setting in mysqlConf
statefulset starts updating, -1 is terminated
-1 was master, -0 is promoted to master because -1 is gone
-1 is back up as slave, -0  is dead again and now no master again

I'm not sure what the best way to go about this to prevent this from happening.. I'd be happy to put in the work to fix it

Hi @mnaser,
We thought about this and concluded that Deployment rolling update is not a good fit. We should use OnDelete policy and let the operator choose the order in which the pods are killed (updated).

If you would like to implement this feel free to open a PR or let's chat about this here or on the k8s Slack channel for #mysql-operator.

I was wondering your opinion about what if read-only/startup settings would need an extra variable set to true in order to push them live, and changes that could be done on-the-fly could be done within reconciliation.

Hi @cu12, can you please elaborate a bit on your idea and how do handle this? I don't think I get it. :smile:


chore(dependencies): Update dependency winston to v3.10.0

This PR contains the following updates:

Package
Type
Update
Change

winston
dependencies
minor
3.9.0 -> 3.10.0

Release Notes

winstonjs/winston
v3.10.0
Compare Source

Avoid potential github issues - relax engines node requirement in package.json  fc9c83d
Export Logger class (#2181)  eda40ef
Added Lazy option to file transport (#2317)  f7e7f2f
Bump eslint from 8.32.0 to 8.44.0 (#2321)  de2e887
docs(#2319): Syntax error on README.md (#2320)  fcc69ec
fix(types): Allow any object to be passed as meta to logger.profile (#2314)  9d6001a
Bump @types/node from 18.11.18 to 20.3.1 (#2313)  06e3165
Update supported Node versions and run npm audit fix (#2315)  61e2f5b
Bump @babel/core from 7.20.12 to 7.22.1 (#2309)  7643ad6

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

:tada: This PR is included in version 1.1.1 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Improved icon typings.

Improved icon typings to have infered keys. This can be used to check icons in compile time.
Updated TypeScript to 3.4.
Added VSCode setting to use local TypeScript.
Removed settings.json from .gitignore.
Added utility to add icons to the global ClarityIcons namespace.
Consistent property naming for icon shapes.

Thank you @lukeshiru for contributing. It looks like there is an issue with the build in this PR. Taking a look at it its looks like it is related to the TypeScript package change you made. Please remove the TS package update from the PR as we manage dependency updates separately and this should allow your PR to build in Travis.

@coryrylan done! The TypeScript update to 3.4.x should happen at some point in the near future, to make functionality like const assertions to work. Its a minor update, so it should go smoothly.

Hi @lukeshiru, Thank you for your contribution. This PR brings nice cleanup and organization in the icons codebase. I have only one questions I posted above. And I am almost ready to approve PR.

Due to the work and research being worked to fix the tree shaking issue https://github.com/vmware/clarity/issues/2599 we are closing the PR until we are ready to address it. I opened an issue https://github.com/vmware/clarity/issues/3337 for us to track. When we implement the tree shaking changes that will be the optimal time to also address the typings issues. This PR is still very valuable and will give us context of what we should be aware of to properly fix typings and the tree shaking issues.


[4.0] Make coding paths non-optional [DO NOT MERGE]

What's in this pull request?
Cherry-picks #10728 to swift-4.0-branch.
Explanation: As laid out in a proposed update to SE-0166 and SE-0167, there are changes to unkeyed containers and coding paths that we want to introduce to the Codable API. This implements the remainder of those updates which had not yet been implemented:

For the benefit of unkeyed containers, coding paths currently contain optional CodingKeys — unkeyed containers are allowed to report a nil key in a path. However, this is unhelpful for debugging purposes, or inspecting the coding path for context, since any unkeyed container simply reports nil, whether it’s at index 1 or 1000
Now all containers are required to report a non-optional CodingKey for their segment of the coding path, and coding paths are now exposed as [CodingKey]

To support this, UnkeyedEncodingContainers now expose their count and UnkeyedDecodingContainers expose their currentIndex

Scope: Affects writers of Encoders/Decoders and consumers of the new Codable API.
Radars:

rdar://problem/32512602
rdar://problem/32512692

Risk: Low
Testing: Updates existing unit tests to confirm expected behavior.
This PR should not be merged on its own. This must be merged simultaneously with #10728 and apple/swift-corelibs-foundation#1091 to avoid breaking the build.

@swift-ci Please test macOS

apple/swift-corelibs-foundation#1091
@swift-ci Please test Linux

Build failed
Jenkins build - Swift Test Linux Platform
Git Commit - c8a8d83d605906445561832a9c1a8d1abfdf267d
Test requested by - @itaiferber

apple/swift-corelibs-foundation#1091
@swift-ci Please test Linux

Build failed
Jenkins build - Swift Test Linux Platform
Git Commit - c8a8d83d605906445561832a9c1a8d1abfdf267d
Test requested by - @itaiferber

apple/swift-corelibs-foundation#1091
@swift-ci Please test Linux

Build failed
Jenkins build - Swift Test Linux Platform
Git Commit - c8a8d83d605906445561832a9c1a8d1abfdf267d
Test requested by - @itaiferber

apple/swift-corelibs-foundation#1091
@swift-ci Please test Linux


(Gitlab) Repo configuration should inherit Global configuration

Is your feature request related to a problem? Please describe.
The config at least should be inherited from a global configuration because those will most likely be shared actors repositories such as the user_mapping used to fix user auto-discovery.
config:
  user_mapping:

The second use case I see for inheritance is to have a global list of people on vacation so they can be rejected from the review selection.
Describe the solution you'd like
In the GitLab setup, we have to define a dedicated repo, cm that contains the Gitlab CI pipeline for the repo. We also have the option to define a global automation configuration. Any repo configuration should be able to inherit the global configuration.
Describe alternatives you've considered
Copy pasting
Additional context
This solution should simply require loading the global and repo configuration and applying a deep merge between both configurations. You can think of more advanced solutions such as includes or patches, but a simple (deep merge) inheritance would already cover a lot of use cases.

fixed

Thanks for proposing this idea @xNok! This feature isn't on our roadmap, but that may change, and we'll let you know if this gets prioritized.
In the meantime, it might be possible to partially workaround this problem by defining your automations at the GitLab Group level. You would still be restricted to a single user_mapping per automation, but you could at least make them apply to all repos. Let me know if you have questions about this.

It is about the same, but an include feature seems more complex to implement. Simply having the deepmerge option would cover most of the cases. As far as I know, you are already merging all .cm files together.
You can configure gitStream via one or more Continuous Merge (CM) files inside your git repository or GitHub/GitLab organization. These files end with a .cm extension, and they outline automation that will run whenever someone opens a new PR or makes changes to an existing PR.

ref: https://docs.gitstream.cm/how-it-works/
So far I can have multiple cm files in the same repo, and they are merged according to the doc. I am simply expecting the global cm file to be merged with the local ones.
cm repo (for gitlab)
+ .cm
  `- user-mapping.cm
   - default-automation.cm

repo (code repos)
`

.cm
- gitstream.cm

The resulting configuration is the combination of all three files as expected in the Github setup when breaking the configuration into multiple files.
nothing more than a deepmerge between a set of yaml file:

python: https://pypi.org/project/deepmerge/
nodejs: https://www.npmjs.com/package/deepmerge


Not all movies added to studio collection

Version Number
2.1.0
What branch are you on?
master
Describe the Bug
I want to make collection with A24 movies but it doesn't collect all of them. Civil War or Love lies bleeding is not added for example.
Relevant Collection/Overlay/Playlist Definition
No response
Logs
No response

Need more info - what are you using to create the collection?

    - default: studio       template_variables:         include:         - A24

- default: studio
  template_variables:
    include:
    - A24

Plex lists the Studios for Civil War as DNA Films and for Love Lies Bleeding as Film4 Productions
Plex generally lists the production studio, not the distribution studio.

Thank you.


Fix context menu

With reference to Strencher's PronounDB

It isn't working for me. I get this error when I try to open a user menu.

Which version are u using? I'm using
Stable 121601 (c130b44)
BetterDiscord 1.5.2
Host 0.0.266 OS X 10.15.7 (19.6.0)
OS X 10.15.7 (19.6.0)
ZeresPluginLibrary 2.0.2

Stable 121719 (faa867d)
BetterDiscord 1.5.2
Host 1.0.9004 Windows 10 64-Bit (10.0.22000)

Oops, clicked the wrong button.

I have created a virtual Windows machine and verify that it should be working now.
Moreover I have removed the "patchStreamContextMenu" as it seems that discord had removed that webpack module
FYI
Stable 122087 (5c6d04c)
BetterDiscord 1.5.2
Host 1.0.9004
Windows 10 64-Bit (10.0.19041)

Some discord modules are lazy loaded now, including the context menus, which is the reason why it doesn't appear for you. Can you revert that change, please? I can get it working.

I have reverted the changes, but as the method pushStreamPreviewMenuItems has one more argument, I'm not sure will the code works or not

Thanks, I'll do some testing now and make it work for the other menu.


getProducts always returns an empty array on android

const productSkus = Platform.select({
ios: ['abc', 'abc2'],
android: ['abc', 'abc2'],
default: [],
});
export const getAllPurchasePlans = async productSkus => {
try {
await RNIap.initConnection();
// Flush failed purchases cached as pending on Android
if (Platform.OS === 'android') {
const isFlushSuccessful =
await RNIap.flushFailedPurchasesCachedAsPendingAndroid();
  if (!isFlushSuccessful) {
    console.log('No failed purchases cached as pending.');
    // Handle the case where there are no failed purchases cached as pending
  } else {
    console.log('Failed purchases cached as pending flushed successfully.');
  }
}
const products = await RNIap.getProducts({skus: productSkus});
console.log('-products----------->->->->', productSkus, products);
return products;

} catch (error) {
//console.error('Error fetching products:', error);
return [];
}
};
this is my code but its always return me empty array have any solution so please share here....

Were you able to resolve this? If so, can you post the solution?

Assuming your developer account is in good standing, with a correctly configured bank account and no pending holds, when you create a product on the Google Play Console, the product ID will serve as your SKU. It should appear in the array after receiving approval for release, even if it's just for a closed test.
Be careful not to confuse products with subscriptions when coding. If you attempt to retrieve a subscription by calling the getProducts() method instead of getSubscriptions(), you might encounter empty arrays as a result. This is a common mistake.
It's essential that your account is fully functional before you start coding, as feedback from the stores is often not very informative in your specific context. Whenever I’ve helped others, the issue usually traced back to an incomplete process on the store’s side related to the developer's account, such as waiting for bank account approval. Without resolving these issues first, it’s challenging to rule out potential causes during debugging. Debugging in-app purchases can be a slow process due to the many variables outside of the library itself, so don’t get frustrated if it takes some time to pinpoint the issue.
Below, I've included some of my own public implementations to help you understand how things work:
https://github.com/Vittor-Javidan/EarthLog/blob/main/src/SubscriptionManager.ts
https://github.com/Vittor-Javidan/EarthLog/blob/main/src/V1/Components/Alert/PopUp/BuySubscription/index.tsx
https://github.com/Vittor-Javidan/EarthLog/blob/main/src/app/V1/index.tsx
I hope this helps!


Gauge uses PluginConnection timeout instead of KillConnectionTimeout

In the plugin.Kill() method, Gauge is using plugin_connection_timeout instead of plugin_kill_timeout.
Ref line number for this change.

Fixed in this commit.


Add transactional adapter support for mongoose

mongoose is a popular mongodb client package that is used by many people including myself, and I am eager to add an official transactional adapter to mongoose.

Hi, I was planning to add support for plain mongodb at some point (or welcome a contribution).
In terms of mongoose - I don't know if you're aware, but they offer a built-in transaction propagation with AsyncLocalStorage (i.e. the very same thing that a @nestjs-cls/transactional plugin would offer)

Hi, I was planning to add support for plain mongodb at some point (or welcome a contribution).
In terms of mongoose - I don't know if you're aware, but they offer a built-in transaction propagation with AsyncLocalStorage (i.e. the very same thing that a @nestjs-cls/transactional plugin would offer, so the only benefit would be the option to use the @Transactional decorator)

Yes, I understand, but I don't think there is a conflict because mongoose's support for AsyncLocalStorage makes us easier to provide a transaction adapter for us to use the @Transactional decorator feature.

@GO-DIE Would you like to have a go at implementing it? I am definitely open to contributions.

I found some free time and put together a mongoose adapter. Feel free to test it for your use-case.
@nestjs-cls/transactional >= [2.4.0] is required.


no file train_textBPN.py

hi, great works! But I can not find train_textBPN.py(I can find eval_textBPN.py). Can you provide this file?

I'm currently implementing a training extension for TextBPN with a config file support - (training is fully working but needs little more work on the validation step - will be fully working soon.).
I hope it can be helpful in the meantime and until the authors publish the full training code here with the next TextBPN version.
TextBPN-Training Extention

I'm currently implementing on a training extension for TextBPN with a config file support - (training is fully working but needs little more work on the validation step - will be fully working soon.).
I hope it can be helpful in the meantime and until the authors publish the full training code here with the next TextBPN version.
TextBPN-Training Extention

You are cool! Thanks for your work, have you tested your training results?


Some questions related to mongodb-erlang

I was experimenting with this lib for some days now and i had some doubt regarding the same would be great if this can be answered

I want to use this as multi-tenant driver for which i need to pass DB on runtime like i can do for java / c/ c++ drivers
with c i can

   const char *uri_string =<EMAIL_ADDRESS>   client = mongoc_client_new_from_uri (uri);
// magic happens here pass db name at runtime
   database = mongoc_client_get_database (client, "db1");
   collection = mongoc_client_get_collection (client, "db1", "coll_name");

   database1 = mongoc_client_get_database (client, "db2");
   collection1 = mongoc_client_get_collection (client, "db2", "coll_name");

I can pass db name on runtime on the same client or connection pool letting me use diff db as and when i need  i was trying with erlang lib but i was not able to do it
is there a way we can do this or add this feature for multi - tenant apps?

Was just curious why we did not use erlang NIF/PORT binding for libmongoc to leverage the connections to mongodb is there any specific reason not go this way ?

For now connection and auth are done in one step. It means you can't just open conneciton and then authenticate against some database. But you can just spawn a new mc_worker as soon as you know your database at runtime. Will it work for you?

Using nif/port adds additional dependencies. It's better to have pure Erlang implementation.

Hope I've answered your question.

For question

but spwaning new mc_worker would not create a new connection on each spwan ? if i have several hundreds tenants it will open up those many connections to the server.
I was thinking of solution where you have connection pool say of x and x connections can handle db change at runtime as possible in java and c drivers.
so you have one or many conenctions pre-authenticated however db's and collections are passed on runtime ryt now only collections can be passed on runtime.

Yes, new mc_worker spawns a new connection.
The issue here is that changing database on the fly is not implemented yet.
I'll check it out and if I'll have time this weekend I'll try to fix it.

@comtihon thank do let me know if i can contribute some how for the same. would be happy to do that.

@nOmi7 would you be so kind to test this https://github.com/comtihon/mongodb-erlang/pull/198 ?
I don't have erlang + mongo now anywhere.

@comtihon  i was able to change the database at the runtime  however i had one suggestion  instead of running mc_worker:database everytime when change is needed would it be a good thought allow function to accept db as paramter as well. as in
// this will insert to default db on which connection was made
mc_worker_api:insert(Connection, Collection, [ #{<<"name">> => <<"Red Sox">>,
                                                     <<"home">>=> #{<<"city">> => <<"Boston">>, <<"state">> => <<"MA">>},
                                                     <<"league">> => <<"American">>}
                                                 ]).

// use db which is passed as parameter to the insert / read etc.. functions?
mc_worker_api:insert(Connection, Collection, **Database**,  [ #{<<"name">> => <<"Red Sox">>,
                                                     <<"home">>=> #{<<"city">> => <<"Boston">>, <<"state">> => <<"MA">>},
                                                     <<"league">> => <<"American">>}
                                                 ]).


Changelog gen

e.g.
$ ./hack/changelog.py \
  --token=$GITHUB_TOKEN \
  --section-title="Section Title" \
  --range=origin/master..v0.5.1-alpha.1 \
  --changelog-file=CHANGELOG.txt

and
$ cat CHANGELOG.txt

Section Title
* Fix CRD mapper blocking all others because caches never sync  and revamp backend-mode flag ([#303](https://github.com/kubernetes-sigs/aws-iam-authenticator/pull/303), @wongma7)
* Update aws-sdk-go to version v1.30.0 ([#306](https://github.com/kubernetes-sigs/aws-iam-authenticator/pull/306), @nckturner)
* Bump k8s.io/ dependencies to 1.16.8 ([#305](https://github.com/kubernetes-sigs/aws-iam-authenticator/pull/305), @wongma7)
* chown aws-iam-authenticator to avoid permission denied ([#302](https://github.com/kubernetes-sigs/aws-iam-authenticator/pull/302), @wongma7)
* Indentation and unit test improvements ([#298](https://github.com/kubernetes-sigs/aws-iam-authenticator/pull/298), @bhagwat070919)
* Adding Rate limiting ec2:DescribeInstances API along with Batching for high TPS ([#292](https://github.com/kubernetes-sigs/aws-iam-authenticator/pull/292), @bhagwat070919)

cool!

/lgtm

Nice, and this could be piped into goreleaser as the release notes. https://goreleaser.com/customization/release/#custom-release-notes

/lgtm


[BUG] - Cart amount changes - Firefox

Describe the bug
The cart drawer, when either add or subtract amount is selected, the window will refresh the page and close the cart drawer
To Reproduce

Open in Firefox
Add item to cart / bag
Click cart / bag icon
Click add or subtract item amount

Hydrogen version: 1.x-2022-07
Node version: 16.14.2
Windows 10
Firefox  106.0.5 (64bit)

I can confirm this issue exists,
adding something like this on the cart details solves the issue:
<form onSubmit={evt => evt.preventDefault()}>

link to the pr: https://github.com/Shopify/hydrogen/pull/1767


Format pyproject.toml file with pyproject-fmt using pre-commit

Description
This PR adds a pre-commit check and formatting step leveraging pyproject-fmt to help standardize the formatting found within the file, similar to how black or ruff-format work with Python code.
Additionally - I moved inline comments for dependencies to be above their related lines (to conserve line space) and updated the version of the project to be in alignment with dynamic versioning (0.0.0).
What kind of change(s) are included?

[ ] Documentation (changes docs or other related content)
[ ] Bug fix (fixes an issue).
[x] Enhancement (adds functionality).
[ ] Breaking change (these changes would cause existing functionality to not work as expected).

Checklist
Please ensure that all boxes are checked before indicating that this pull request is ready for review.

[x] I have read and followed the CONTRIBUTING.md guidelines.
[x] I have searched for existing content to ensure this is not a duplicate.
[x] I have performed a self-review of these additions (including spelling, grammar, and related).
[x] These changes pass all pre-commit checks.
[ ] I have added comments to my code to help provide understanding
[ ] I have added a test which covers the code changes found within this PR
[x] I have deleted all non-relevant text in this pull request template.

Thanks @jenna-tomkinson ! I've created an issue for the versioning item (I don't believe there's any additional configuration we need at this time). Merging this in.


Check if bot is listening after a RTM Close event

Slacks RTM connection is lost when using a debugger.  This causes the rtm_close event to be fired, which in turn starts a new bot.  We should check if the bot is currently running before started a new one.

These should be handled at the same time.
https://github.com/Dynatrace/davis-server/issues/213

can't reproduce as of e4f653e12dabdb39134193887a13a9b450d5547d


Update Overview-and-Workflow.md

Fixed typo

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/create-packages/Overview-and-Workflow.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Thanks for the fix!


Add user Robert Blackwell

Pull requests are fun I guess.

Thanks! Validation that my code is good is nice :)


Reaching EMO level quality

Thanks for the great work on the project! The approaches of AniPortrait and EMO share a lot of similarities, especially in the use of SD1.5, ReferenceNets, and AnimateDiff type motion modules.
Of course, we have limited visibility into EMO outputs, but it seems to be better. This begs the following questions:

What are the top reasons for difference in quality of AniPortrait and EMO?
What are the most impactful possible improvements to improve Aniportrait video quality?

Which of the following do folks think is the biggest reason for quality gap:

Training dataset (size and quality)
Use of intermediate representation (EMO conditions on audio directly)
Weak guiding conditions used in EMO
Architectural differences in the Lmk2Video stage
Other

The authors mention the use of intermediate representations in the paper as a limitation. Certainly, it seems the Audio2Lmk model could be trained more effectively or can be done away with. To my eye, however, the most stark quality issue seems to be with teeth artifacts (e.g. blurs, temporal inconsistency, generally weird looking teeth). This leads me to believe the discrepancy in quality is either from dataset used or some architectural difference in Lmk2Video. Any idea what's most to blame for these types of artifacts?
Curious what the community + authors think - especially around causes of lesser image / video quality compared to EMO!

I am also curious about that. I think the problem is in the script/libraries/programs used to restore and animate face realisticly. I think we lack the face/body movements base on models used to recreate it. We should implement something that is trained on realistic face/body movements and then it should be applied on character in the process.
I found this program also contributed by Alibaba team:
https://github.com/ali-vilab/dreamtalk
and it is based on this program:
https://github.com/RenYurui/PIRender
and it uses this program:
https://github.com/sicxu/Deep3DFaceRecon_pytorch/issues
So it is audio driven and it generates random movements of the body and also make "realistic" face movement. I think that's what we need. Also as far as I noticed it generates anatomical movement of the neck (i think) so this is something that we can observe in EMO. It is a little bit simpler than EMO but I think it is the base(?)
I may be wrong, but those programs/technologies seems to be connected to EMO. Also for some reason DreamTalk took a step back with the access for the public so it may be it.


UDPRoute Controller Scaffolding

Problem Statement
We need to add a controller to handle UDPRoutes. We'll start by adding the
basic scaffolding before we add the dataplane connection. This only includes
the basic scaffolding, not the data-plane configuration push yet that will be
handled in a follow-up.
TODO

[x] 1UDPRoutecontroller added withoperator-sdk`
[x] Logic added to verify UDPRoute is attached to a Gateway supported by
GatewayClass and print this out to logs

Fixes : https://github.com/Kong/blixt/issues/30

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Add selector for last topic used in active narrow

Automated message from Dropbox CLA bot
@borisyankov, it looks like you've already signed the Dropbox CLA. Thanks!


Enumeration of joystick directions

The enumeration of the joystick directions is not the same between the library and the site admin interface.
{UP, LEFT, RIGHT, DOWN} on the website respectively associated with {BOTTOM, LEFT, RIGHT, TOP} in the library
code-reference

Thanks for the report! I was able to reproduce the issue. Hopefully we get this fixed for the next release.

UP and DOWN are now displayed correctly on the website.


fix invalid gcsfs git repo url

change gcsfs repo url from https://github.com/gcsfs/gcsfs.git to https://github.com/dask/gcsfs.git

+1

Thanks @andersy005 !  Merging.


"Bad gateway" deploying demo application

NOTE: GitHub issues are reserved for bug reports only.
For anything else, please join the conversation
in Kong Nation https://discuss.konghq.com/c/kubernetes.

Summary
Bad gateway error when trying to access $PROXY_IP/foo
Kong Ingress controller version
0.6.0
Kong or Kong Enterprise version
1.3.0
Kubernetes version
Client Version: version.Info{Major:"1", Minor:"14", GitVersion:"v1.14.6", GitCommit:"96fac5cd13a5dc064f7d9f4f23030a6aeface6cc", GitTreeState:"clean", BuildDate:"2019-08-19T11:13:49Z", GoVersion:"go1.12.9", Compiler:"gc", Platform:"darwin/amd64"}
Server Version: version.Info{Major:"1", Minor:"13+", GitVersion:"v1.13.10-eks-5ac0f1", GitCommit:"5ac0f1d9ab2c254ea2b0ce3534fd72932094c6e1", GitTreeState:"clean", BuildDate:"2019-08-20T22:39:46Z", GoVersion:"go1.11.13", Compiler:"gc", Platform:"linux/amd64"}
Environment

Cloud provider or hardware configuration: AWS EKS

What happened
I'm trying to deploy the demo application with Kong-ingress in my istio service mesh inside AWS EKS. When I run this command curl -i $PROXY_IP/foo, I got this errors

curl -i $PROXY_IP/foo
HTTP/1.1 502 Bad Gateway
Date: Mon, 30 Sep 2019 05:30:48 GMT
Content-Type: text/plain; charset=UTF-8
Transfer-Encoding: chunked
Connection: keep-alive
Server: kong/1.3.0
X-Kong-Upstream-Latency: 12
X-Kong-Proxy-Latency: 24
Via: kong/1.3.0

An invalid response was received from the upstream server

Expected behavior
st like "HTTP/1.1 200 OK..."
Steps To Reproduce
As in https://github.com/Kong/kubernetes-ingress-controller/blob/master/docs/guides/getting-started.md

Okie, I figured out. It's because I enabled mTLS policy for all services using istio configuration and it blocks Kong from communicating with upstreams.

If envoy is injected into the Kong Ingress Controller, you shouldn't be having this error.
Also, please make sure to add traffic.sidecar.istio.io/includeInboundPorts: "" annotation to your Kong Ingress Controller pod so that envoy doesn't take over Ingress traffic.

Just curious I'm receiving a 504 Gateway Timeout error having followed the kubernetes.io blog post that is similar to the example that was followed above.
I added the annotation that you suggested above @hbagdi and am still receiving similar errors. Any thoughts on how to fix this?


Website favicon

First, I recently found this project and I'm excited to try this out as a self-hosted bookmark alternative to Raindrop! It's super minor, but I thought I would point out that the grimoire website favicon is the default Docusaurus icon, and I'm sure the intention is to have the grimoire icon there.  But I really I just wanted to take advantage of this to let you know that I appreciate the hard work you're putting into the project that you're graciously allowing others to use!

Hello @corykinney!
I thought I had it already updated, but maybe I need to take a second look at this. Thank you for bringing it to me and I hope you will find Grimoire useful!
PS, Sorry for not getting back to you sooner!

Fixed it. Thanks again @corykinney!


Incorrect Password even if it is correct

^^^

misspelled pw in .sxcu mb try it again

misspelled pw in .sxcu mb try it again

@eozri Tried again but still didn't work.

add my discord pix#0070

pix#0x070

@eozri Accept my friend request

Fixed. Forgot to put https:// before the domain in Hoster.sxcu


SOMPY missing ipdb

I recently downloaded SOMPY and attempted the run the example code "California Housing". When I attempt to import SOMFactory from sompy, I receive this error...
~/anaconda3/lib/python3.6/site-packages/SOMPY-1.0-py3.6.egg/sompy/sompy.py in ()
30
31 #lbugnon
---> 32 import sompy,ipdb
33 #
34
ModuleNotFoundError: No module named 'ipdb'
How do I fix this?

Please have a look at #61, that was probably left during debugging, you can remove it from sompy.py and mapview.py.


macro for EKS images to use in rule: Launch Privileged Container

Signed-off-by: ismail yenigul<EMAIL_ADDRESS>
What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

If contributing rules or changes to rules, please make sure to also uncomment one of the following line:

/kind rule-update

/kind rule-create

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area build

/area engine

/area rules

/area tests

/area proposals

What this PR does / why we need it:
Creates macro for AWS EKS images to use in rule: Launch Privileged Container
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:

Create new macro for AWS EKS images hosted on ECR to use in rule: Launch Privileged Container

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please assign mstemm after the PR has been reviewed.
You can assign the PR to them by writing /assign @mstemm in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

rules/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

LGTM label has been added.  Git tree hash: 2b60ede8d2ecaeb1439b7eba69708029174704bf

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: Kaizhe
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

rules/OWNERS [Kaizhe]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


dsq: 0.21.0 -> 0.22.0

Description of changes
Fixed version of #188592. The tag naming has changed: it now has a v prefix.

Things done

Built on platform(s)

[x] x86_64-linux
[x] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[ ] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 188610 run on x86_64-linux 1

1 package built:

dsq


rowSelection can't be disabled

The dropdown that enables the user to choose how many rows of the table should be displayed can't be disabled with a simple option flag.

The only solution is to delete line 20-26 in md-data-table.js.
I think there should be a solution that is more straight forward.
PS: Yes, I've tried:
option = {rowSelection: false}

I've received requests to be able to disable the row select options a few times now. In the mean time you can remove it pretty easily with CSS.

Could you please demonstrate how to do this

It looks like you want to show the page select but hide the limit select.
.md-table-pagination {
  .md-table-select:nth-of-type(2) {
    display: none;
  }
}

You can hide the labels as well. You can use child selectors to choose which labels to hide.
.md-table-pagination {
  /* this will hide all labels */
  .label {
    display: none;
  }
}

I couldn't get it to work with your CSS but I found a workaround that sadly only works with hiding both selects:
  md-select.md-table-select > .md-select-value {
    display: none;
  }

You probably just need to un-nest it if you are not using a CSS preprocessor.
.md-table-pagination .md-table-select:nth-of-type(2) {
  display: none;
}

I just tried it and it worked.

In v0.10.0 You must now opt-in to displaying the limit options dropdown


233 3.3 event states

Make event states more obvious by implementing a function that returns them.
--> needs to be used instead of the implicit request

Coverage remained the same at 100.0% when pulling 39d44e15c78b6c97fe24e62b0dc2d41a937276e2 on 233_3.3_EventStates into 7fecfe1c5012ca487e09cedc5df6979cfaebaa41 on dev.

Coverage remained the same at 100.0% when pulling e05ea082a69d48629f80ff429449f93d68a7528b on 233_3.3_EventStates into fa5ab5007842a61dbddc852cd10f543711e62051 on dev.

Coverage remained the same at 100.0% when pulling 4df6655a4921c298cdc80d5b3cc91bd88177c725 on 233_3.3_EventStates into 5f620fef35c4bcbf394595d7c91f5ce81fe29ac3 on dev.


Standardize the save format

Need to use a standardized save format so that save files from other emulators work with this. Maybe this is helpful.
http://fileformats.archiveteam.org/wiki/GB

So the best bet is to save a raw binary file of $a000-$a1ff with no header and the extension .SAV. Add a command line parameter of -save="saveFile.sav" to load a save file, and have a hotkey available for creating save files.
Be sure to test this .SAV against other common emulators and also loading other common emulator .SAV files in this emulator.

The best way to handle this (I don't want to write to sav every time a save byte is written and I don't want to keep a stream open constantly) is to have a dirty flag for the sav region and update the .SAV file once a second whenever it is dirty.

Implemented with d871c2e6f9203ffb6ef7550f276c6a683add02d2


PropTypes warning

Hello,
This package triggers the following warning:

Warning: Accessing PropTypes via the main React package is deprecated. Use the prop-types package from npm instead.

It should be trivial to fix it.

Should be fine with latest 👍


Crash on macOS Big Sur with an Intel chip

Geode Issue

[X] I confirm that this crash is NOT related to a mod but directly to Geode Loader itself.

Platform
MacOS
Geode Version
v3.1.1 (latest)
Mods Installed
No mods, it was a fresh install
Steps to Reproduce

Get an Intel MacBook Air from 2013
Install Steam and GD
Install Geode

Crash Report
There is no other crashlog than the crash report directly prompted to me by macOS
crashlog.txt
Additional Information
I'm using an old Mac from 2013, and it's stuck on macOS 11 Big Sur
Idk if for some reason Big Sur is no longer supported
Before these recent updates, I have been able to install Geode without any issues, so I assumed it was gonna work fine

geode requres monterey now for some reason
I guess you have to test your luck with opencore legacy patcher

known issue with ci builds, we're still figuring out a good fix (mostly waiting on testers)
but yeah, it's unintentional. if you build geode locally, it'll run on macos 11 just fine. hopefully fixed releases soon


fix delete authentication policies when delete topic.

Fixes #11876
Motivation
When delete the topic, its authentication policies in zookeeper are not deleted.
Modifications
delete the authentication policies of the topic when delete the topic.
Verifying this change
This change added tests and can be verified as follows:

Added unit test.

Does this pull request potentially affect one of the following parts:
If yes was chosen, please highlight the changes

Dependencies (does it add or upgrade a dependency): ( no)
The public API: (no)
The schema: ( no )
The default values of configurations: (no)
The wire protocol: (no)
The rest endpoints: (no)
The admin cli options: (no)
Anything that affects deployment: (no)

Documentation
Check the box below and label this PR (if you have committer privilege).
Need to update docs?

[x] no-need-doc

bug fix

/pulsarbot run-failure-checks

@LeBW Could you please help create a PR to branch-2.8 directly? we are not able to cherry-pick this one directly because it depends on #11693

@LeBW Could you please help create a PR to branch-2.8 directly? we are not able to cherry-pick this one directly because it depends on #11693

I have fixed the cherry-pick issue in https://github.com/apache/pulsar/commit/ffe574d535b1233ecb8fbc047daecc05c76537cd , Please help review this commit, thanks. @LeBW @codelipenghui


The command '/bin/ash -o pipefail -c pip3 install -r requirements.txt' returned a non-zero code: 1

Logger: homeassistant.components.hassio
Source: components/hassio/websocket_api.py:123
Integration: Home Assistant Supervisor (documentation, issues)
First occurred: 9:32:44 AM (1 occurrences)
Last logged: 9:32:44 AM
Failed to to call /addons/087658ba_household_chores/install - The command '/bin/ash -o pipefail -c pip3 install -r requirements.txt' returned a non-zero code: 1

Same issue here.

I also have this issue.


[Enhancement] Bring Back The Old Effects!

Summary
This repository used to contain a nice variety of effects that i've tended to use in various places. The old NuGet package is still available and I do still use it however it would be nice to carry those effects over to this revitalised version of the lib.
Below is a list of some of the available effects

Now I think some of these effects are probably outdated however I would assume not all of them are useless. I specifically want to use EntryRemoveBorder and EntryRemoveLine in many places as it's very necessary for styling.
Was there a reason that these effects were removed from this lib? a cursory search of the issues doesn't reveal much and I haven't looked at the commit history.
Since the old NuGet package is pointing to this repository (link), I think the effects should either be added back or it should be made clear they are no longer available in this lib.
Who Will Do The Work?

[X] I am willing to take this on myself
[ ] Just putting this out there for someone to pick up

Don't you mind to refactor the code a little bit?
At least names :)

I'm not opposed to bring them back, but I would want to check which are actually still needed. Maybe some of them are now supported by Forms out of the box? If you can update or comment here which ones you actually want to bring back, what they actually do and give us some more details, that would be cool. Thanks!

Cool, I couldnt find any docs for these old effects so I've had a look at them and wildy assumed their functionality. here is a table of the old effects, what they do and if they are supported by Forms OTB

Effect
Purpose
Supported Out The Box?

EntryCapitalizeKeyboard
Capitalize all inputs on an Entry
[ ]

EntryClear
Adds clear button to Entry
[X] - ClearButtonVisibility

EntryDisableAutoCorrect
Disables autocorrect for Entry
[ ]

EntryItalicPlaceholder
Makes Entry placeholder italic
[X] - FontAttributes="Italic"

EntryRemoveBorder
Removes Entry border on iOS
[ ]

EntryRemoveLine
Removes Entry underline on Android
[ ]

EntrySelectAllText
Selects all text in entry when focussed
[ ]

LabelCustomFont
Allows a custom font for Label
[X] - FontFamily

LabelMultiLine
Specify the amount of lines a Label can have
[X] - MaxLines

LabelSizeFontToFit
I assume this sizes the label font to fit the available space however it didn't do anything in my sample project
?

PickerChangeColorEffect
No idea what this did + it crashed my app when I tried to use the effect
?

SearchBarSuggestionEffect
I didn't try this one
?

SwitchChangeColorEffect
Again no idea what this one does, attached it to my switch and it didn't look any different to the original
?

ViewBlurEffect
This one crashed my sample app
?

The effects I'm personally interested are the entry remove lines / borders but I think the following effects would be useful for developers:

EntryCapitalizeKeyboard
EntryDisableAutoCorrect
EntryRemoveBorder
EntryRemoveLine
EntrySelectAllText

We could potentially combine the EntryRemoveBorder and EntryRemoveLine effects into one single effect, thats what I'd do.
Anyway what are your thoughts? would people be happy to see these effects added back?

Wooow thanks for this @Axemasta I think autosuggest and capitalization can be done with this? https://docs.microsoft.com/en-us/xamarin/xamarin-forms/user-interface/text/entry#customize-the-keyboard

Oh excellent, 2 more to strike off the list. I'll make a PR tomorrow with

EntryRemoveBorder
EntryRemoveLine
EntrySelectAllText

@Axemasta

EntryNoBorderEffect
EntryNoUnderlineEffect
EntrySelectAllTextEffect

I have a question. Does it make sense to combine EntryNoBorderEffect & EntryNoUnderlineEffect into a single effect?
Seems the first one is only for iOS and the second one is for Android.
class EntryBorderEffect
{
    public bool HasBorder { get; set; }
    public bool HasUnderline { get; set; }
}

Please keep in mind that it is not a strict request. That's more just a question 👍

@AndreiMisiukevich I think this is a good idea, I actually mentioned the same thing in my original post. In my own apps I have 1 effect that does both on each platform, I wonder if they just created them separately and then threw them into the repo.

I need the LabelSizeFontToFit-Effect. 🙈

Merged in #492


Big Sur style app icon

While I'm working on the fancy mouse and menu detection thing, I think it's time to have a new app icon to match the overall design language of macOS Big Sur. Here is several candidates for the new rounded rectangle app icons, I'm not sure which one is better.

woa, nice.

Hello!

Please create pull request, our designer really like it.

#118


Add game activity log page

Codecov Report

Merging #14 (4ca1163) into develop (6b0ce42) will decrease coverage by 0.47%.
The diff coverage is 84.61%.

@@             Coverage Diff             @@
##           develop      #14      +/-   ##
===========================================
- Coverage    94.50%   94.02%   -0.48%
===========================================
  Files           41       42       +1
  Lines          510      536      +26
  Branches        67       73       +6
===========================================
+ Hits           482      504      +22
- Misses          27       30       +3
- Partials         1        2       +1

Impacted Files
Coverage Δ

src/pages/PlayerProps.jsx
100.00% <ø> (ø)

src/pages/Activity.jsx
84.61% <84.61%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b0ce42...4ca1163. Read the comment docs.


ActionPlan chaining

Hi! Is there a way that I can chain ActionPlan requests? Next action plan gets executed when all actions from the previous one get executed. For example:
TodoAction.fetchTodos()
.then(TodoAction.filterTodos())
.then(TodoAction.mapTodos())

Originally, I was planning to add functionality similar to redux thunks as a native API, which could provide this kind of feature. It ended up causing a lot of complexity, and opened the door for abuse of the unidirectional data-flow.
The way I view it is that an action is simply a dispatched event. The dispatcher shouldn't care what happens to the acton or if it ever modifies the state. Observers of the state should be used instead to trigger any new action that might be needed.
For the example you provided, I might handle fetchTodos() in the following ways:

It would populate the state after it filters and maps the data internally.
The reducer might filter and map the todos before adding them to the state. It could create a hashed dictionary for all todos by their ids, and then another collection of ids representing the filtered ones.
It would populate the state with a collection of all todos. This would trigger the relevant view to update, which would filter its own set of todos when it maps them from the state. It could use a selector to cache the results.
An optional closure could be passed to fetchTodos() that provides a derived publisher from the service call. It could be used to further perform any extra operations on the todos before they're added to the state:

let action = fetchTodos { (todos: AnyPublisher<[Todo], Error>) in
  todos.filter { ... }.map { ... } // The returning publisher is then mapped to a `setTodos` action.
}

dispatch(action)

It might be possible to pull this off inside a containing publishable action plan. It's kind of a hack, but you could observe off of the store.didChange property using something like firstWhere(_:) to wait for the fetchTodos() to update the state. The store.state property inside an action plan always provides the latest snapshot of the state similar to getState() in redux thunk.

I'm working on a solution using a new API on the ActionPlan itself:
let chainedActions = firstActionPlan.next(secondActionPlan).next(thirdActionPlan)

// Or

let chainedActions = firstActionPlan.next(secondActionPlan, thirdActionPlan)

Each plan would wait for the previous one to fully complete or be cancelled before running (Useful for plans that return a publisher). The method would return a new version of the first action plan that internally keeps a copy of the next ones to run after it finishes.
There's no data passing between the action plans. Instead, the store's state can be accessed to retrieve anything necessary.

Added the feature in v0.12.0


B 21904 nts oconus int

B-21904
Summary
This PR adds in the pre approved service items for international NTS shipments.
Verification Steps for Reviewers
These are to be checked by a reviewer.

[ ] Has the branch been pulled in and checked out?
[ ] Have the BL acceptance criteria been met for this change?
[ ] Was the CircleCI build successful?
[ ] Has the code been reviewed from a standards and best practices point of view?

How to test

Login as a TOO
Add an international NTS shipment to a move. Test the variations of the move:
OCONUS -> OCONUS
OCONUS -> CONUS... etc
Click on Approve and send.
Confirm on the next pageInternational Shipping and Linehaul and International Packing with NTS Pricing Factor are preapproved service items. Fuel Surcharge - PODFSC should only be pre approved if the shipment is OCONUS -> CONUS

Note: OCONUS -> CONUS etc are determined by the shipments pickupaddress and storage facility address.
Example: NTS Shipment
Pickup Address ->  Storage Facility Address         ==      Ordering Type
Alaska              ->                          Alaska               ==                   OCONUS -> OCONUS
Iowa                 ->           Alaska    ==               CONUS -> OCONUS
Backend

[ ] Code follows the guidelines for Logging.
[ ] The requirements listed in Querying the Database Safely have been satisfied.

Database
Any new migrations/schema changes:

[ ] Follows our guidelines for Zero-Downtime Deploys.
[ ] Have been communicated to #g-database.
[ ] Secure migrations have been tested following the instructions in our docs.

Screenshots
OCONUS -> CONUS

OCONUS -> OCONUS

Test coverage on server failed.
Last run: Fri 13 Dec 2024 07:19:06 PM UTC
Refer to this report to see coverage details for the server app.
Documentation for test coverage can be found at this link.

Warnings

:warning:
This PR does not include changes to unit tests, even though it affects app code.

  Generated by :no_entry_sign: dangerJS against c1b1719dae239d51c46684793f29d920549234cc


PYTHON variable issue when making pip-installable

General information

versions: smoothcorrfunc 0.0.0, Corrfunc: 2.3.2
platform: linux
installation method (pip/source/other?): source

Issue description
I am trying to make my package installable via pip. I have edited the setup.py and common.mk files to make a new distribution name and version number. When I upload the distribution to testpypi, it seems fine, but then when I try to install on another system, it hits an error because of the PYTHON variable in common.mk.
I figured out that the setup.py file checks that the python executable that ran the setup script is the same as the one in common.mk, and if it's not, it updates the common.mk one to the python path used. This means that my miniconda path ends up hardcoded, so when I try to install on another system it fails.
Actual behavior
This is the line that updates the PYTHON variable and causes the issue:
python setup.py sdist
where python points to my miniconda python installation, /home/users/ksf293/miniconda3/bin/python3.
Then I do
python -m twine upload --repository testpypi --skip-existing dist/*
The package is successfully uploaded to testpypi here:
https://test.pypi.org/project/smoothcorrfunc/0.0.0
and can be installed with:
pip install -i https://test.pypi.org/simple/ smoothcorrfunc==0.0.0
When I try this on a different system, I get the error:
RuntimeError: command = /home/users/ksf293/miniconda3/bin/python3 -c 'from __future__ import print_function; import sys; print(sys.executable)' failed with stdout = b'' stderr = b'/bin/sh: /home/users/ksf293/miniconda3/bin/python3: No such file or directory\n' status 127
Expected behavior
For now I edited setup.py to not update common.mk, and just set PYTHON:=python in common.mk.
I did this for an updated pip distribution, so doing
pip install -i https://test.pypi.org/simple/ smoothcorrfunc==0.0.1
installs with no errors.
Is there a better solution?

@manodeep @lgarrison, any wisdom here? thanks!

If you compile the code, then common.mk will get modified; but that modification will remain as an uncommitted change. I create the source distribution after restoring common.mk to the normal (i.e., PYTHON := python) value (you can also do a git checkout -- common.mk to remove that change).
I should probably document the steps to create a release of Corrfunc (including updating the version numbers in multiple places) - such a document probably would have been helpful for you.

Actually @manodeep, it looks like you might have fixed this bug in this commit 6 months ago? https://github.com/manodeep/Corrfunc/commit/e6cd90ba23d5723aa87b0141d42336ac46bd4238
So maybe the fix is as easy as merging upstream into your branch, or at least cherry-picking this commit if merging is complicated at this point.

Heh! Just came here to point that out - what @lgarrison said :)

I love it when I forget I fixed a bug, it's a gift from my past self!

amazing thank you for the quick replies! been meaning to merge in 2.3.3... i'll see how complicated that seems, and otherwise just grab that commit.
and yes @manodeep documentation of the steps to release would have been helpful, though it wasn't too bad to figure out! i'll write up what i did at least for posterity.

fixed via sync with Corrfunc 2.3.4 e59fd57


tmp checkin

Coverage remained the same at 85.256% when pulling c8b626e75c81eb807e6411a4826a09a64982582c on shaikhjamir:feature/travis_check into 55ae0521ae11aca725fd82380c7170cdde04af33 on intuit:develop.


feat [IDP-1510] : Added the tutorial to add links in software components

Harness Developer Pull Request
Added the tutorial to add links in software components
What Type of PR is This?

[ ] Issue
[x] Feature
[ ] Maintenance/Chore

If tied to an Issue, list the Issue(s) here:

Issue(s)

House Keeping
Some items to keep track of. Screen shots of changes are optional but would help the maintainers review quicker.

[x] Tested Locally
[ ] Optional Screen Shoot.

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app


FileMode.group() and FileMode.private() now set the any_exec bit

Before any_read has instead been set twice.

Thanks!


RAC-5032 - Converted the workflows CIT test scripts to FIT format for staging

Converted the workflows CIT test scripts to FIT format.
This is first part of committing these changed scripts to show the diffs.

@larry-dean @keedya @jimturnquist @johren @derrickostertag

BUILD RackHD #331 : FAILURE

test this please

BUILD RackHD #335 : FAILURE

test this please

BUILD RackHD #343 : FAILURE

test this please


Using zos with openzeppelin-eth Ownable, owner assigned to be a fixed number, rather than designated argument.

I was writing a contract something similar as below
pragma solidity ^0.4.24;

import "zos-lib/contracts/Initializable.sol";
import "openzeppelin-eth/contracts/ownership/Ownable.sol";

contract Foo is Initializable, Ownable {

    uint256 public x;
    string public s;

    function initialize(uint256 _x, string _s, address _owner) initializer public {
        x = _x;
        s = _s;
        Ownable.initialize(_owner);
    }

    function increment() public {
        x += 1;
    }
}

In the zos project, I deployed (pushed) the above logic contract to Ropsten network, and then create a proxy contract for it.
zos create Foo --network ropsten --init initialize 1,"begin",<owner address> --from <admin address>

However, when I try to log the info, using ethers.js. The values of state variables are as below.
FooProxy
  x: 1
  s: begin
  owner: 0x0000000000000000000000000000000000000977

The owner address is fixed to be "0x977", rather than the designated address.
I wonder whether my approach of writing this upgradable contract for a zos project is correct? Or have I accidentally overwritten the owner state?

Closing the issue, since the error result from that the input address argument are not all in lower case.


Integrate common element with the defined trustbloc theme

[ ] Change Sign in  link color to blue
[x] Use the button theme in sign up page.

The Sign in link color is blocked by #858


Announcement Page Cards

Describe the bug
Readmore is associated with the header tag it should be a button instead
To Reproduce
Steps to reproduce the behavior:

Go to Announcement Page
Scroll down to Recent Event
See error

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

OS: [e.g. iOS]
Browser [e.g. chrome, safari]
Version [e.g. 22]

Additional context
Add any other context about the problem here.

@smaranjitghose Can I correct this ?

@smaranjitghose Kindly add the difficulty label :)


Fix: Verify executed tests taking include/exclude option into account

We have the policy that all commits have to be signed. I'm going to bypass that policy in this case. Please set up commit signing.


Start Menu Icons for Default Programs are IN!

:white_check_mark: Build TimeHACK AppVeyor-102 completed (commit https://github.com/TimeHACKDevs/TimeHACK/commit/6b5df7645a by @lempamo)


HashMap-like Entry API for Task-Locals

@carllerche made a good point that with the new task::Context API, we no longer need the with API for safety, and could instead provide more ergonomic task-local accessors that resemble the existing APIs on HashMap.

Are task-local variables really needed?
Aren't they a bad idea just like putting the context itself in TLS was?
Also, after removing them "task context" can be renamed to a better name, which is something like "WakerProvider" or "Notification" or "Waker" (renaming the current waker to WakerHandle) or similar, since all it does is provide a way to notify and has nothing to do with anything that would be called a "task".

@bill-myers See the executor RFC which is being designed using the assumption that task locals are a thing.

Why not have the "task context" parameter be a pair of an executor reference and a waker mechanism them?
This seems just like a repeat of the task context TLS mistake.

This seems just like a repeat of the task context TLS mistake.

Not sure why you call it a mistake. There are valid use cases for it. I was just pointing out the executor as a valid use case.

The RFC to change it to not use TLS has been approved, so it seems to have been a mistake by definition.
I think it's the same because task local variables, just TLS, introduce "variables" that may or may not be set and it's not possible to tell at a glance if it's set or not upon entry to a function or that it even exists.
An explicit executor field or accessors in an opaque field instead are far more explicit and discoverable, and make sure that an executor is always set (of course this is not true for any future opaque accessors that will have to have a default, or code that constructs the task context will break).

Why does it matter if variables have been set or not if they do not alter the observable behavior from the POV of the caller?

Because if a variable is required to be set by the function, then a panic has to happen instead of the compiler error that would happen if normal function parameters were used and the parameter was missing?
BTW, the executor RFC does seem to propose something similar to the opaque accessors with the "with_spawn" and "with_notify" accessors (although for some reason they seem to take a closure instead of just return a modified task context), so I'm a bit confused on why there is talk of an HashMap-like API here.
Or maybe I'm misunderstading and this is not about providing arbitrary task-local variables?

@bill-myers

Because if a task-local or TLS variable is required to be set by the function, then a panic has to happen

That would alter the observable behavior from the POV of the caller. I'm asking why task-local variables are mistake if they are used in a way that does not alter the observable behavior from the POV of the caller.

The approval to change task context to argument from TLS does not imply TLS is a mistake. I'd offer that calling it as such is a little combative, and suggests that anyone using TLS is making a mistake, when really, all decisions are usually based after comparing pros and cons.

Closing -- this is done.


Issue 3

Per Issue 3, created A_DatasetLogs.bat, A_ETL_Runtimes.bat, A_RunETL.bat, A_TodayLogs.bat to mimic the functionality of the corresponding shell scripts.  Care has been taken to avoid dependencies, other than a modern windows command interpreter.  However:

A_RunETL.bat uses the Windows Task Scheduler as an analog to cron, and relies on the command line interface schtasks.exe, which appears in Windows XP or newer workstations, and Windows 2003 and newer servers.

In A_TodayLogs.bat, the correct setting of the TODAY variable assumes the default date format for English - United States (en-us).  Different locales may require tweaking.

In A_TodayLogs.bat, the delimiter for DATASETS_TO_EXCLUDE has been changed from the pipe symbol (|) to a space ( ) for compatibility with the FINDSTR command.

Without a set of example log files, testing has been very limited, please construct your test plan accordingly.

Signed the agreement via clahub.

Thank you! We will take a look at these.
As they say, no good deed goes unpunished. Any chance you want to take a swing at updating the corresponding page in the documentation? If not, that is totally fine.

Yes, no problem.  Just glancing at the docs made me realize A_RunETL.bat needs changes anyway.  I only took it as far as capturing and outputting the command, not actually running it.  There's no real equivalent to eval in the CMD.EXE, so I may have to resort to making a temporary file.

Okay - I've updated the docs and the A_RunETL.bat to run the commands.  Out of curiosity, what do you intent for the RunETL script to in case multiple jobs are matched?  I imagine it would be a fairly common failure mode for the user to accidentally press enter prematurely, maybe giving something like:
$ sh RunETL.sh t [oops I hit enter while aiming for the "3" on the keypad]
In this case the script would match any jobs with a "t" - which could be a lot of stray jobs.
The shell script would compound all this onto one line, due to the use of eval, and the command would almost certainly fail to run.
The batch file, however, would run each job one by one, as the tasks are being parsed out in a loop, and the call inside this.
Let me know what the desired behavior is, or raise a new issue, and I can tackle this if you want.

Reasonable point. The desired behavior would be to fail without running any jobs.
I have not really thought through ease of implementation in either a shell script or batch file but I suppose a good validity check would be to make sure the parameter is nine characters (good) or four alphanumeric dash four-alphanumeric (better).  Nine with the middle one being a dash would be almost as good.
All that said, I have done so much worse things by mistake than running some ETLs needlessly so we can also live with the risk if necessary. ☺
Thanks.
From: Jef Waltman<EMAIL_ADDRESS>Sent: Friday, October 16, 2015 10:03 AM
To: Chicago/open-data-etl-utility-kit<EMAIL_ADDRESS>Cc: Levy, Jonathan<EMAIL_ADDRESS>Subject: Re: [open-data-etl-utility-kit] Issue 3 (#30)
Okay - I've updated the docs and the A_RunETL.bat to run the commands. Out of curiosity, what do you intent for the RunETL script to in case multiple jobs are matched? I imagine it would be a fairly common failure mode for the user to accidentally press enter prematurely, maybe giving something like:
$ sh RunETL.sh t [oops I hit enter while aiming for the "3" on the keypad]
In this case the script would match any jobs with a "t" - which could be a lot of stray jobs.
The shell script would compound all this onto one line, due to the use of eval, and the command would almost certainly fail to run.
The batch file, however, would run each job one by one, as the tasks are being parsed out in a loop, and the call inside this.
Let me know what the desired behavior is, or raise a new issue, and I can tackle this if you want.
—
Reply to this email directly or view it on GitHubhttps://github.com/Chicago/open-data-etl-utility-kit/pull/30#issuecomment-148740542.

This e-mail, and any attachments thereto, is intended only for use by the addressee(s) named herein and may contain legally privileged and/or confidential information. If you are not the intended recipient of this e-mail (or the person responsible for delivering this document to the intended recipient), you are hereby notified that any dissemination, distribution, printing or copying of this e-mail, and any attachment thereto, is strictly prohibited. If you have received this e-mail in error, please respond to the individual sending the message, and permanently delete the original and any copy of any e-mail and printout thereof.

Added validation requiring the Dataset4x4 argument to be (exactly) 4 alphanum dash 4 alphanum per your suggestion.  Hooray regex.  I think this is a reasonable safeguard.  It's not so much running an ETL that I would worry about, it's other stuff that may be lurking in the crontab or task scheduler.

A_DatasetLogs.bat - looks great.
A_ETLRuntimes.bat - something is not quite right. Here is a zipped folder of sample logs (sorry, this would have been helpful for you) and the commands didn't quite work. The parsing seems to be stopping after the header.
A_TodayLogs.bat - terrific.
For A_ETLRuntimes.bat
Shell output (correct):
$ A_ETLRuntimes.sh f7f2-ggz5
INFO  01-08 06:00:40,695 - Kitchen - Processing ended after 19 seconds.
INFO  02-08 06:00:39,526 - Kitchen - Processing ended after 18 seconds.

Batch file output:
> A_ETLRuntimes.bat k7hf-8y75
WARN  01-08 00:45:20,949 - Unable to load Hadoop Configuration from "file:///pat
h/to/directory/data-integration/plugins/pentaho-big-data-plugin/hadoop-configura
tions/mapr". For more information enable debug logging.
INFO  01-08 00:45:21,130 - Kitchen - Logging is at level : Detailed logging
INFO  01-08 00:45:21,131 - Kitchen - Start of run.
INFO  01-08 00:45:21,240 - Standard_ETL - Start of job execution
INFO  01-08 00:45:21,242 - Standard_ETL - exec(0, 0, START.0)
INFO  01-08 00:45:21,246 - START - StartinNot enough storage is available to pro
cess this command.

In another example:
$ A_ETLRuntimes.sh k7hf-8y75
INFO  01-08 00:45:31,837 - Kitchen - Processing ended after 10 seconds.
INFO  01-08 01:45:31,532 - Kitchen - Processing ended after 10 seconds.
INFO  01-08 02:45:35,323 - Kitchen - Processing ended after 13 seconds.
INFO  01-08 03:45:31,021 - Kitchen - Processing ended after 10 seconds.
INFO  01-08 04:45:33,491 - Kitchen - Processing ended after 9 seconds.
INFO  01-08 05:45:35,705 - Kitchen - Processing ended after 10 seconds.
INFO  01-08 06:45:30,327 - Kitchen - Processing ended after 9 seconds.
INFO  01-08 07:45:30,401 - Kitchen - Processing ended after 9 seconds.
INFO  01-08 08:45:30,755 - Kitchen - Processing ended after 9 seconds.
INFO  01-08 09:45:30,992 - Kitchen - Processing ended after 11 seconds.
INFO  01-08 10:45:30,064 - Kitchen - Processing ended after 10 seconds.
INFO  01-08 11:45:32,956 - Kitchen - Processing ended after 13 seconds.
INFO  01-08 12:45:29,006 - Kitchen - Processing ended after 10 seconds.
INFO  01-08 13:45:31,072 - Kitchen - Processing ended after 12 seconds.
INFO  01-08 14:45:34,327 - Kitchen - Processing ended after 13 seconds.
INFO  01-08 15:45:32,042 - Kitchen - Processing ended after 13 seconds.
INFO  01-08 16:45:36,774 - Kitchen - Processing ended after 15 seconds.
INFO  01-08 17:45:30,050 - Kitchen - Processing ended after 11 seconds.
INFO  01-08 18:45:30,543 - Kitchen - Processing ended after 10 seconds.
INFO  01-08 19:45:30,866 - Kitchen - Processing ended after 11 seconds.
INFO  01-08 20:45:30,196 - Kitchen - Processing ended after 9 seconds.
INFO  01-08 21:45:27,508 - Kitchen - Processing ended after 9 seconds.
INFO  01-08 22:45:27,525 - Kitchen - Processing ended after 9 seconds.
INFO  01-08 23:45:30,555 - Kitchen - Processing ended after 10 seconds.
INFO  02-08 00:45:31,668 - Kitchen - Processing ended after 9 seconds.
INFO  02-08 01:47:31,540 - Kitchen - Processing ended after 2 minutes and 14 sec
onds (134 seconds total).
INFO  02-08 02:45:29,161 - Kitchen - Processing ended after 10 seconds.
INFO  02-08 03:45:28,886 - Kitchen - Processing ended after 10 seconds.
INFO  02-08 04:45:32,704 - Kitchen - Processing ended after 9 seconds.
INFO  02-08 05:45:35,135 - Kitchen - Processing ended after 10 seconds.
INFO  02-08 06:45:30,211 - Kitchen - Processing ended after 10 seconds.
INFO  02-08 07:45:28,853 - Kitchen - Processing ended after 10 seconds.
INFO  02-08 08:45:28,631 - Kitchen - Processing ended after 9 seconds.
INFO  02-08 09:45:32,719 - Kitchen - Processing ended after 14 seconds.
INFO  02-08 10:45:26,688 - Kitchen - Processing ended after 10 seconds.
INFO  02-08 11:45:28,690 - Kitchen - Processing ended after 10 seconds.
INFO  02-08 12:45:28,745 - Kitchen - Processing ended after 10 seconds.
INFO  02-08 13:45:28,885 - Kitchen - Processing ended after 10 seconds.
INFO  02-08 14:45:27,470 - Kitchen - Processing ended after 10 seconds.

The bash script has the same Hadoop error as above. The grep/find doesn't seem to be working, but unclear to me as why.

Okay - I'll take a look and debug using your sample logs.  I'm pretty booked for the next couple of weeks, but will work on it as catch can.

@tomschenkjr - can you double check that those sample files are still available on FileTea?  I get a blank page when following the URL you posted.

@jefw -- Ok, adjusted the link. That should work.

@tomschenkjr - Retrieved in good order - thanks.

Okay - fixed in my branch.  I was using copy to get file content into the find command, but this was stopping after the first file.  Switched to type instead.  I have a dim recollection that type is limited to files < 2GB but couldn't quickly verify this.  The .bat now outputs the same as the .sh when tested with k7hf-8y75.  Please re-test and advise.
I am not sure what you mean about the Hadoop errors.  These appears in the log files themselves, and should be excluded by grep/find.

Thanks, I'll test to confirm.
For the Hadoop ... when I was running the command, it was displaying a Hadoop error that was contained in the logs -- which just happened to be the first line.
Tom Schenk Jr.
Chief Data Officer
Department of Innovation and Technology
City of Chicago
(312) 744-2770
<EMAIL_ADDRESS>data.cityofchicago.org

From: Jef Waltman<EMAIL_ADDRESS>Sent: Tuesday, December 8, 2015 1:37 PM
To: Chicago/open-data-etl-utility-kit
Cc: Schenk, Tom
Subject: Re: [open-data-etl-utility-kit] Issue 3 (#30)
Okay - fixed in my branch. I was using copy to get file content into the find command, but this was stopping after the first file. Switched to type instead. I have a dim recollection that type is limited to files < 2GB but couldn't quickly verify this. The .bat now outputs the same as the .sh when tested with k7hf-8y75. Please re-test and advise.
I am not sure what you mean about the Hadoop errors. These appears in the log files themselves, and should be excluded by grep/find.

Reply to this email directly or view it on GitHubhttps://github.com/Chicago/open-data-etl-utility-kit/pull/30#issuecomment-162991947.
[https://avatars3.githubusercontent.com/u/7562476?v=3&s=400]https://github.com/Chicago/open-data-etl-utility-kit/pull/30#issuecomment-162991947
Issue 3 by jefw · Pull Request #30 · Chicago/open-data-etl ...
Per Issue 3, created A_DatasetLogs.bat, A_ETL_Runtimes.bat, A_RunETL.bat, A_TodayLogs.bat to mimic the functionality of the corresponding shell scripts. Care has been ...
Read more...https://github.com/Chicago/open-data-etl-utility-kit/pull/30#issuecomment-162991947

This e-mail, and any attachments thereto, is intended only for use by the addressee(s) named herein and may contain legally privileged and/or confidential information. If you are not the intended recipient of this e-mail (or the person responsible for delivering this document to the intended recipient), you are hereby notified that any dissemination, distribution, printing or copying of this e-mail, and any attachment thereto, is strictly prohibited. If you have received this e-mail in error, please respond to the individual sending the message, and permanently delete the original and any copy of any e-mail and printout thereof.

Succes :exclamation:
Thank you.

Awesome!