Structuring reducers page

Initial content review for #1784 .  Please give feedback on content, formatting, structure, and ordering of topics.  Current content is a first draft, and I expect I'll need to make numerous changes before it's ready to merge.

There's a lot of information here. It's all good stuff worth having, but it's an effort to get through. Maybe each page should have an executive summary or TLDR or bullet points that cover the main concepts/problems/solutions.  or "PRO TIP: ..." interstitials. (I don't know how much formatting control you can achieve with markdown.)

Worth investigating.  The individual pages are pretty consistent with the length of the other doc pages, though.

@markerikson This looks great, amazing effort! Hopefully I'll be able to read all of it carefully over the next few days and offer some comments.

@markerikson I'm about 2/3rds of the way through taking notes on these. I agree with @jimbolla that some kind of executive summary might be useful to make sure the key ideas stand out.
One consistent nitpick I've noticed is that there are often 2 spaces after full stops, while the other docs use a single space.

One consistent nitpick I've noticed is that there are often 2 spaces after full stops, while the other docs use a single space.

Bah.  So sue me for being old-school - I learned typing from a DOS program that taught that :)
But yeah, I figured there'd be formatting stuff I'd have to change.  The code snippets probably need to change spacing from four spaces to two spaces as well, or something like that.

some kind of executive summary might be useful to make sure the key ideas stand out.

Hmm.  Per-page, or for the section as a whole?  Any suggestions?

Bah. So sue me for being old-school - I learned typing from a DOS program that taught that :)

😄

But yeah, I figured there'd be formatting stuff I'd have to change. The code snippets probably need to change spacing from four spaces to two spaces as well, or something like that.

I guess the exact format of the code snippets is a bit up in the air until our new lint rules (airbnb?) are decided on.

some kind of executive summary might be useful to make sure the key ideas stand out.

Hmm. Per-page, or for the section as a whole? Any suggestions?

Line 74 of Basic Reducer Structure is an example to consider. IMO the line in bold is a key idea in the "Basic State Shape" section, but it comes 20+ lines into the section. To be fair, it is in bold, but it would be a shame if people missed an important idea because they are skipping sections that start off seeming familiar. I actually hadn't considered an "as a whole" summary, but that might be a good idea.

Okay, seems reasonable.  I'll have to do some thinking about how to summarize things.

I've now read all the sections (and also gone back and read most of the
existing Redux documentation too). Theres so much good stuff here, kudos!
Here are some things I have been thinking about the overall structure. I am far from a technical writing expert, so feel to tell me I am talking nonsense at any point!

Reduce the number of docs to one per topic. It seems to me that there the are five distinct topics covered:

Basic Reducer Usage
Reducer Composition
combineReducers and Beyond
Normalizing State Shape
Initializing State

I think there is a lot of cross over between "Basic Reducer Usage" stuff and the existing Reducer doc. I would be in favour of augmenting the existing Reducer doc where it is lacking and remove the "Basic Reducer Usage" material from the new docs.
There is also some cross-over between "combineReducers and Beyond" and "Reducer Composition"? Some re-organization might make sense there (or it might not make sense to treat them as distinct topics at all).

Add an introductory/overview/summary paragraph (or two) at the start of each
section. It should mention any idea important enough that it was highlighted
in bold in the doc. My thinking is that this makes the important points harder to miss.

Mention pre-requisites in the introduction, and list further reading at the end of
each doc.

Repeat the "combineReducers is just a convenience function" warning whenever
there is an opportunity. I think it is important enought to bear the repetition.

======
01: Basic Reducer Structure
There is a large overlap between this and the Reducer doc. I would be in favour
of adding the new stuff introduced here to the Reducer doc and dropping this file.
02: Splitting Reducer Logic
Remove "business function" and "case function" from the glossary (they aren't
mentioned again in the docs). "Utility function" is a well understood
term (?), if we also remove that then we would just have the list of reducer types.
03: Functional Decomposition
Drop the explanations of updateObject and updateItemInArray refactorings
and start from the listing after updateItemInArray is introduced. I think the updateObject refactoring might be a little controversial and updateItemInArray is covered in the Immutable update section. I would argue that these refactorings are a little off topic, and removing them cuts 100+ lines from the doc.
Merge "Splitting Reducer Logic" and "Functional Decomposition" into a single "Reducer Composition" doc.
04: Using combineReducers
Remove the basic information about combineReducers and refer user to the combineReducers doc instead. The Initialization information is seems like it has some overlap with the initialization document
05: Beyond combineReducers
LGTM.
Merge "Using combineReducers" with "Beyond combineReducers". Maybe "combineReducers and Beyond"?
06: Normalizing State Shape
LGTM
07: Managing Normalized Data
I'm not sure about the Redux-ORM stuff here. It looks neat, but doesn't feel essential to me. Removing it reduces the doc size considerably.
Merge with "Normalizing State Shape"
08 - Reusing Reducer Logic
LGTM
Merge with Splitting Reducer Logic and Functional Decomposition
09 - Immutable Update Patterns
This is very important stuff, Redux won't work as advertised if you get this
wrong. I think it should be its own section in the Reducers doc (it is already
touched upon in the "Splitting Reducers" section).
10 - Initializing State
LGTM
00: Pre-Requisites:
I would be in favour of moving the pre-requisites to the relevant introductions, and drop this as a stand-alone document.
========
I also have a couple of wording suggestions and things, but I think this is
enough for now!

@ellbee : Thanks, this is some great feedback!  I'll have to take some time to digest it and think through things.  Also hoping to get review-ish comments from a couple more people.  Much appreciated!

Wow.  Well, I did ask for feedback :)  Thanks, @randycoulman !
I'll go through and reply to a few of your comments now.  Definitely sounds like I'm going to have to step back and rethink some of the overall approach, although I'm not exactly sure that that will involve.

There is a lot here.

I know you've collected a lot of information about Redux best practices and have a good encyclopedia of information about it.

The challenge with that is that it's tempting to include it all here.

I can imagine similar sections talking about actions/action creators, async actions, selectors, etc., and I wonder how much would be too much for the core documentation. The longer it gets, the less likely people will read it.

Some very worthwhile discussion.  I would say that reducers are more of a core topic than the others.  While use of action creators / thunks / selectors is certainly "idiomatic Redux", it's entirely possible to write an app without those.  On the other hand, every Redux app will have reducers.

The information here is really valuable, though, and having a distilled version of all of the information that's out there is a good idea.

Would it be worth splitting some of this into a separate online book about Redux in the real-world? Or is it OK to have this as part of the core documentation? I'm not sure I know the answer, but I think it's worth talking about.

Well, there certainly are a few of those out there already.  However, I think there is a lot of value in having at least a good chunk of this in the docs.  Having the stamp of "officialness" is kind of a big deal - see the reaction to Create-React-App as an example.  It's also more easily visible than a random blog post somewhere.
It's certainly possible at least some of this could get moved elsewhere.  As much as I like the Redux-ORM bit in "Managing Normalized Data", that might be a good candidate.

Probably won't be able to start addressing this stuff until next weekend.  Thanks for all the comments so far.  Would also appreciate feedback from @reactjs/redux , @Aweary , @naw , @phoenixmatrix , @tommikaikkonen , and anyone else who's looked at this.

@markerikson Sorry if my review was too detailed or too overwhelming.  I'm not suggesting that you need to re-work the whole thing, and I hope you didn't take it that way.  You've got a lot of great stuff here, and I think it will help a lot of people.
And remember, I'm just one guy, so balance what I say against what others think.

No no, this is very much the kind of feedback I was hoping to get. And yeah, I'd definitely like to hear from a few more people as well.  Gotta get to bed, but I'll reply to a couple of the latest comments tomorrow.
Thanks for all the feedback so far!

Relevant suggestions: https://github.com/thejameskyle/documentation-handbook

@markerikson I know you wanted to make some changes, but I think this is pretty good as-is. And I think this is too important to leave hanging in a PR for too long! It can always be better, but we'll be accepting typo fixes until the end of time on all the docs 😄
If you want to make any other final changes, feel free. Regardless, I'll merge this in on Sunday at some point. We can make future changes via subsequent PRs.
Seriously, amazing work on this stuff!

Heh.  Thanks for the encouragement :)
The main thing I need to do atm is actually make sure it builds properly with the rest of the docs.  I deliberately didn't worry about that yet, only focusing on the content.  For example, I'm not sure about the numbered naming of the Markdown files versus the generated HTML filenames.  I may need to rename the Markdown files to produce better HTML output.
Currently working on setting up a new gadget.  I'll tackle this on Sunday, and let you know when I'm done.  Please ping me before merging.
Thanks!

All gitbook cares about is how it's referenced in the ToC. It builds the book off of what's linked there and that's it.

Updated the content per review comments.  Now time to do some checks for Gitbook results.

BTW, this is what you need to add to the docs/README.md to make it show up in the gitbook build:
  * [Structuring Reducers](/docs/recipes/StructuringReducers.md)
    * [Basic Reducer Structure](/docs/recipes/reducers/01-BasicReducerStructure.md)
    * [Splitting Reducer Logic](/docs/recipes/reducers/02-SplittingReducerLogic.md)
    * [Refactoring Reducers Example](/docs/recipes/reducers/03-RefactoringReducersExample.md)
    * [Using `combineReducers`](/docs/recipes/reducers/04-UsingCombineReducers.md)
    * [Beyond `combineReducers`](/docs/recipes/reducers/05-BeyondCombineReducers.md)
    * [Normalizing State Shape](/docs/recipes/reducers/06-NormalizingStateShape.md)
    * [Updating Normalized Data](/docs/recipes/reducers/07-UpdatingNormalizedData.md)
    * [Reusing Reducer Logic](/docs/recipes/reducers/08-ReusingReducerLogic.md)
    * [Immutable Update Patterns](/docs/recipes/reducers/09-ImmutableUpdatePatterns.md)
    * [Initializing State](/docs/recipes/reducers/10-InitializingState.md)

I can put that at the top of the Recipes section. I think that looks best.

Right, that was going to be my next step once I got Gitbook building okay in my repo.  Unfortunately, it looks like the current Gitbook setup symlinks from /SUMMARY.md to /docs/README.md, which doesn't work on Windows, and things don't work from there.  Currently playing around to see if I can figure out an alternative approach to getting Gitbook working.

BTW, I'm going to merge this in now and we can do some other PRs to get them into the docs site. Plus, if anyone wants to suggest further changes, they can do so against the docs themselves 👍
Great job, @markerikson!

@markerikson For that gitbook issue, just temporarily copy the docs/README.md contents into SUMMARY.md to get it building. Whenever you have it how you'd like, just copy the changes (if any) back and make a commit.

Possible typo in "Using combineReducers":
import theDefaultReducer, {firstNamedReducer, secondNamedReducer} "./reducers";

// Use ES6 object literal shorthand syntax to define the object shape
const rootReducer = combineReducers({
    theDefaultReducer,

should be
import renamedDefaultReducer, {firstNamedReducer, secondNamedReducer} "./reducers";

// Use ES6 object literal shorthand syntax to define the object shape
const rootReducer = combineReducers({
    renamedDefaultReducer,

?

@mg : Yeah, looks like I've got a couple typos in there.  Will fix those.

And fixed.

Loving this section of the docs, thanks for taking the time to pass on your expertise, this is the best thing you can do for the community, much appreciated.
Reading the section on splitting reducer logic got me thinking again about how I can marry my selectors to also only take the relevant part of the state tree. My current solution is to not connect my components but the parent component imports the child selector and uses it to pass the correct props to its children. However if i want to connect my reusable child component, it's hard to to do this when you don't know beforehand where in the tree the component's state will live.
Now redux has had some more years for maturation, are there any further insights on the topic of reusable selectors?


Handle passing query criteria by values

Currently any try of passing filter or sort order by value/method would fail.
Following code would fail:
val filterCriteria = _.foo > 1
val sortBy = _.bar

Dao[FooBar]
.filter(filterCritiera)
.sortBy(sortBy)()

In order to resolve such issue it is needed to resolve context of macro usage and obtain value definition.

We shouldn't do this: it's a step too far towards interpreting the Scala code, and the further we push in this direction, the more problems we will encounter. The definition of val filterCriteria may actually be virtual, and therefore depend on the runtime type of the class, so in such cases we can't handle it correctly.
It's easiest to just add the restriction for these cases that we won't support them.


#35 Decouple intercepting from persisting

To meet the memory footprint requirements the LMAX Disruptor library was used.

To meet the memory footprint requirements the LMAX Disruptor library was used.

This was replaced with a ThreadPoolExecutor eventually.


Files arg

This change adds a files argument that can be passed to post()
The value supported is dictionary with string keys and tuple values. The behavior when passed matches the behavior of CPython requests.
A new example was added illustrating the functionality, I've only tested with native wifi on ESP32 S3, so that is the only one added.
I was able to confirm the upload is working correctly by using a local simple flask server that acceps file upload and by examining the result returned by httpbin.org when the new example runs. It returns the image back in base64 format. This cyberchef recipe was used to validate that the original image does pop back out the other side https://cyberchef.org/#recipe=From_Base64('A-Za-z0-9%2B/%3D',true,false)Render_Image('Raw')
Note that the CPYthon implementation of this also supports a files dictionary with string keys and file_handle values (as opposed to tupple containing the file_handle and other things). That form of the argument is not supported on circuitpython. In order for that to be supported I believe we would need access to FileIO.name property or something that provides similar functionality. I've created #9195 in the core inquiring about adding that, but at present time this is not supported in the circuitpython version.

@FoamyGuy is this ready for final review or is it still in progress/

I believe this is ready for review now. I've merged Justin's changes that were submitted against my branch to this so they are included here now.

@dhalbert I created a new PR into his branch to add some tests back in. Would love to see those in (can add later if wanted)

@dhalbert my tests are merged and this is ready for review!

@FoamyGuy shall I make another PR into this branch with the changes?

@FoamyGuy shall I make another PR into this branch with the changes?

I got the change to os.urandom() with the latest commit, if you've got a clear idea how to tackle reducing the string concatenation then definitely feel free to PR to this branch.
I'll try to take a crack at it over the weekend if you don't have the opportunity to get it first.

@FoamyGuy created here: https://github.com/FoamyGuy/Adafruit_CircuitPython_Requests/pull/4

@dhalbert ready to go again!

Maybe the ValueError -> AttributeError should be a separate PR.

@dhalbert I'm happy to work through this repo and fix up the exceptions and tests, and can do so after this is merged if that is the only concern.

@dhalbert I had this idea of a requests-plus. That requires normal requests but has extra methods and overrides. The other option is that requests-plus could just have add-in methods (like in this case _build_boundary_string, _build_boundary_data etc. And if you pass in files and we got an import error for requests-plus it would error...

@FoamyGuy Thanks for merging. This is an upward-compatible improvement, so it deserved a minor version bump. But no need to change the version number now.


FOUC on translations

The about text on the menu takes a second to load, and ng-cloak isn't doing the trick.  This looks like a good solution:
https://github.com/angular-translate/angular-translate/issues/921
Via:
http://angular-translate.github.io/docs/#/guide/12_asynchronous-loading#asynchronous-loading_fouc---flash-of-untranslated-content

The solution here in general is to use the translate attribute.


How to display a month which is not the current month ?

Hello,
Thank you for this Date Picker.
I have a question for you.
How to display a month which is not the current month ?
Thank you very much for your answer.

Hi and thank you.
There is nothing to do it, you can fork it and do it the way you want, I don't think we gonna add that feature, too complex to handle because people will want to show X months with current month in a certain position etc.

Yes, I'm heading to show several month by repeating your datePicker for every month.
OK I understand, I thought it was easy do force.

It's not very complicated, it's just that people will want all kind of displays, maybe by doing something flexible but I don't have time right now :(
If you think about a good way to do it and choose how to display it, we could do it

Yes I'll be very interrested about this type of feature.
@mgohin I'm not an expert of directives also :)
But Yes definitely I would do that, I'll try if you can help :)
I use to be connected on IRC #angularjs on freenode.
Come to talk !

We can talk here, it's dedicated to the directive --> https://gitter.im/arca-computing/MultipleDatePicker
I was thinking about another directive to wrap the multiple date picker, something like
<multiple-date-picker-wrapper display="[-3, -2, -1, 0, 1, 2, 3]" />

to display 7 months with the current in middle (each number reprensenting difference with current month). Of course we would pass an option parameter to give every pickers options like day-click, highlight-days etc
I clearly don't have time right now to do it, if you want to participate I can create a repo and add you as contributor. I though a bit about this wrapper if you want to dev, we can talk about it more.

Amazing way of implementation.

still want to do it ? I still don't have time to do it :(

Hey, yes definitely.
Same on my side .... I'm finishing my product
but we keep on track !!

I'm currently developing the same MultipleDatePicker with React ;)

I'd second that, it would be cool to have an attribute like startMonth that would set the current Month to be shown on the control

I'd second that, it would be cool to have an attribute like startMonth that would set the current Month to be shown on the control

Not sure if you are talking about a super directive to show multiple multipleDatePicker or current directive. If so It's already possible with month attribute ;)
<multiple-date-picker month="any_timestamp_or_moment_date" />

Using another month than the current is already possible, for any improvement please open a new ticket

@mgohin
the month attribute is not working for me. Any idea why? I tried adding the timestamp manually, unix format and with milliseconds, and I also tried a moment date (from a variable in my controller).
It just shows the current month.
Thanks in advance!

can you provide a piece of code (html and js) ?

$scope.departureMonthDefault = moment($scope.lastDayInUS * 1000);

<multiple-date-picker
	days-selected="departureDatepickerSelected"
	sunday-first-day="true"
	disable-days-after="lastDayInUS * 1000"
	disallow-back-past-months="true"
	month="departureMonthDefault"
	show-days-of-surrounding-months="true"
	fire-events-for-days-of-surrounding-months="true"
	day-click="departureDatepickerClick"
	day-hover="departureDatepickerHover"
	highlight-days="departureDatepickerHighlights"
/>

Thanks.

Is $scope.departureMonthDefault a good moment date ?
Have you checked it's value ?

If I try to log it, it returns:
{_isAMomentObject: true, _i:<PHONE_NUMBER>000, _isUTC: false, _pf: Object, _locale: t…}
Which is a valid Moment date.

And what it passed to $scope.lastDayInUS ?
I'm on gitter, maybe simplier and quicker to help you https://gitter.im/arca-computing/MultipleDatePicker?utm_source=badge&utm_medium=badge&utm_campaign=pr-badge


Bootstrap 3 and 4 in the same project

We are currently migrating a big project from bootstrap 3 to bootstrap 4 but we are facing the problem that we can't install version ^1.4 and 2.0.0-beta4 of this plugin at the same time (same namespace).
How could we solve this to allow developers to migrate their projects in pieces? Could there be a repo for bootstrap 4 with a different namespace so composer could install both versions?

Duplicate of #212


Update etcd rbac document to remove v2 references

Description

Fixes https://github.com/projectcalico/calico/issues/2243
Todos

[ ] Tests
[ ] Documentation
[ ] Release note

Release Note

None required

@tmjd I think this is ready for another look!


Update WifiCommands.md

Thanks for the fix, did not have time to test some URLs since my HERO4 Session died and HERO4 Black was shooting a timelapse, now I will test all URLs and make fixes.


Validator registry view

Closing this PR as will be replaced with new PRs based upon architecture changes to PoET consensus module.


Does not handle elements detached from DOM

If an element has already been detached from the DOM, this throws an exception in testUniqueness, which assumes that parentNode always exists.

having the same issue here. @jiaweihli  did you solve this? im using it in react and i am using some ternary expression to render components and it throws that error when certain elements are removed from dom.

@jiaweihli its def been a while but this PR resolves the issue https://github.com/ericclemmons/unique-selector/pull/39

const elements = parentNode?.querySelectorAll( CSS.escape(selector) );
return elements.length === 1 && elements[ 0 ] === element;
}
Use ?.Will Work as if parentNode not available
also instead of selector use CSS.escape(selector)
It will automatiackly escapes spevial chrcaters like . whitespace % t etc etc from id and class


manual doesn't explain how to install BioNetGen

Now that Anaconda is the default install method, BNG is installed via a package, so we don't need to provide separate instructions.


Updates all our icons to use Segoe Fluent

use FontFamily="{ThemeResource SymbolThemeFontFamily}" where possible, in XAML
use FontFamily{ L"Segoe Fluent Icons, Segoe MDL2 Assets" } in codebehind

Basically just a simple string replace.

[x] This was a bullet point in #11353
[x] Confirmed manually on my win10 PC
see also #12438

Actually, this is the last bullet in #11353, so I'm gonna say closes #11353.
Screenshots below.

holy sh*t, that's everyone

@msftbot merge this in 1 minute


File.writeAsBytes doesn't work with UnmodifiableUint8ListView

From signature it seems that File.writeAsBytes accepts a List<int>, and it seems that UnmodifiableUint8ListView implemements Uint8List.
However, the following example:
import 'dart:io';
import 'dart:convert';
import 'dart:typed_data' show UnmodifiableUint8ListView;

void main() async {
  await File('test-file').writeAsBytes(
    UnmodifiableUint8ListView(utf8.encoder.convert('hello world')),
  );
}

Throws
Unhandled exception:
Invalid argument(s): writeFrom failed: test-file
#0      _RandomAccessFile.writeFrom.<anonymous closure> (dart:io/file_impl.dart:858:9)
#1      _RootZone.runUnary (dart:async/zone.dart:1381:54)
#2      _FutureListener.handleValue (dart:async/future_impl.dart:139:18)
#3      Future._propagateToListeners.handleValueCallback (dart:async/future_impl.dart:680:45)
#4      Future._propagateToListeners (dart:async/future_impl.dart:709:32)
#5      Future._completeWithValue (dart:async/future_impl.dart:524:5)
#6      Future._asyncComplete.<anonymous closure> (dart:async/future_impl.dart:554:7)
#7      _microtaskLoop (dart:async/schedule_microtask.dart:43:21)
#8      _startMicrotaskLoop (dart:async/schedule_microtask.dart:52:5)
#9      _runPendingImmediateCallback (dart:isolate-patch/isolate_patch.dart:118:13)
#10     _RawReceivePortImpl._handleMessage (dart:isolate-patch/isolate_patch.dart:175:5)

The problem is that UnmodifiableUint8ListView implements Uint8List but is not actually a Uint8List as the VM expects. The problem occurs in _ensureFastAndSerializableByteData:
_BufferAndStart _ensureFastAndSerializableByteData(
    List<int> buffer, int start, int end) {
  if (buffer is Uint8List || buffer is Int8List) {
    return new _BufferAndStart(buffer, start);
  }
  int length = end - start;
  var newBuffer = new Uint8List(length);
  int j = start;
  for (int i = 0; i < length; i++) {
    newBuffer[i] = buffer[j];
    j++;
  }
  return new _BufferAndStart(newBuffer, 0);
}

The Uint8List path here is taken despite that the VM does not know how to serialize a UnmodifiableUint8ListView.
The bug can be fixed by falling back to the slow path if it's not exactly a Uint8List or Int8List. Is .runtimeType the best way of doing such a strict check?
It does feel a bit surprising in a sense that a UnmodifiableUint8ListView would be slower than a Uint8List. Optionally we can maybe find a way of handling it efficiently. We could perhaps access the _list getter somehow, although it's in dart:typed_data  and this is dart:io. Alternatively the VM can learn how to serialize the UnmodifiableUint8ListView and UnmodifiableInt8ListView classes.
@lrhn Might you have any thoughts here?

Is .runtimeType the best way of  ....

No. Using runtimeType is never the best way of anything.
In the VM, to check the exact class of an object, you should check the class ID of the object instead. That's actually trustworthy. I found an example at:
https://github.com/dart-lang/sdk/blob/a75ffc89566a1353fb1a0f0c30eb805cc2e8d34c/sdk/lib/_internal/vm/lib/string_patch.dart#L128-L131
(but not for Uint8List, that code just does an is test for Uint8List).
Talk to @mkustermann about the unmodifiable typed data, I believe he's working on making them better.

+1 to what @lrhn  says: If you want code to only work with _Uint8Array, _Uint8ArrayView, _ExternalUint8Array then you have to use ClassID.getId().


Not working on Production

I have no problem working with RFValues on debug mode.
But when i do archive the app for AppStore, its like the RFValues cant calculate and breaks my app style.
I'm using  react-native: 0.61.4 and styled-components 5.3.3
Has anyone had a similar problem?

I've have just figured out that it only happens when the RFvalor is placed on a styles.js file (outside the index file).

Is this closed or still having this issue ?

stucking on it too... it work om Android release Build and not on IOS


unable to resolve dependency tree

Need to use this with Cypress 9.7.0
npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR!
npm ERR! While resolving<EMAIL_ADDRESS>npm ERR! Found<EMAIL_ADDRESS>npm ERR! node_modules/cypress
npm ERR!   dev<EMAIL_ADDRESS>from the root project
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer cypress@">=10" from<EMAIL_ADDRESS>npm ERR! node_modules/cypress-plugin-xhr-toggle
npm ERR!   cypress-plugin-xhr-toggle@"*" from the root project
npm ERR!
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.

Yeah I only support versions 10 and higher. The UI in previous version is different, which would require me to basically build this plugin twice. The benefit is very limited as pre-10 versions are used less and less.


Add Flexbox questions / answers

Create a new deck titled 'CSS3 Flexbox' - and add questions and answers that might test core concepts and mimic questions that might be asked in phone screens. Should be concise enough to fit into 1-2 sentences. Fill in here and submit pull request.
Example of question types / length

I'd love to get this going!

@gcasalett awesome - that would be great, thanks!


[BUG]: Sync Template v2 (PVA) Fails 429

Describe the bug
When running Flow Sync Template V2 (PVA) fails with an error 429
Component (please tell us which flow or app you are experiencing issues with):

Solution Core
Version 1.52
Flow Sync Template V2 (PVA)

To Reproduce
Steps to reproduce the behavior:

Run Flow Sync V2 (PVA)

Expected behavior
I expected the Flow to finish successfully
Screenshots
If applicable, add screenshots to help explain your problem.
Additional context
Add any other context about the problem here.

Hi Nigel. Can you please provide screen shots of the failure? From your but I don't know where it occurred or the text of the error.
Thanks

I am also getting this in Admin | Sync Template V2 (Flows)  always the same place "List Flows as Admin".  This is after the Condition "Check If Environment is deleted" and the "Yes" Branch..  This is happening at 0030 hrs at night so the system should be quiet.

The text of the error is Status field = 429

We have a large Tenancy of tens of thousands of users.  I dont know how many flows because the "List Flows As Admin" never completes !

Hi Nigel. We released a bug fix for this last week in Core 1.53.
Can you please see if you are resolved with an upgrade?

We have just released a new version 1.54 of core with other fixes too. aka.ms/CoEStarterKitDownload
closing this out as a result.


Nested Lazy V & HStacks

My layout hierarchy looks like this:
ScrollView -> LazyVStack -> several LazyHStacks, each with several WebImages.
When scrolling up and down the scrollview, everything works fine for awhile. However, at random times the placeholder is shown and the actual image is not loaded. If I scroll up and down repeatedly, it appears to fix itself and load the image. I have tried to find the source of this issue, but it happens very randomly & unpredictably.

iOS 14+ behavior. iOS 13 works well.
Using @StateObject will solve this. Release in 2.0.0

Should be solved by v2.0.0


Tthe bottom cells do not appear in small screen (no scroll)

with small height (laptop with 768px as height ) I cannot see the cells at the bottom and I cannot scroll

Good catch, I'll take a look! Thanks!


Hobbies form does not have any styles

Recommending bootstrap form-controls @Ed0176

Thanks man. That was useful, I've already added bootstrap controls to all pages.


chore(web3): Bump node version to v18

please wait for me to release a new manual_build image for kicker before merging this pr

please wait for me to release a new manual_build image for kicker before merging this pr

here is the new image:

https://hub.docker.com/layers/retricsu/godwoken-manual-build/node18/images/sha256-27390ad30f1ccbd4e23700eb9db3a602f4f16bbb14220b01abd30b9b159e3567?context=repo

here is the new image:

https://hub.docker.com/layers/retricsu/godwoken-manual-build/node18/images/sha256-27390ad30f1ccbd4e23700eb9db3a602f4f16bbb14220b01abd30b9b159e3567?context=repo

cc @classicalliu

https://github.com/godwokenrises/godwoken/pull/998

Remove node engine limit for Kicker init failed. Re-add later


remove unused import statement

Hi, I  just format CustomizerRegistry.java to keep it consistent with other files.

remove unused import statement;
brace-on-the-same-line;
remove whitespaces in empty lines;

Correct me if I am wrong. 😃

LGTM


Code actions are spotty on Windows

System info
Windows 11 Pro 21H2
Sublime Text 4 (4131)
Node 16.13.2 (through Volta, but LSP's local runtime doesn't work either)
LSP 1.16.2
LSP-volar 1.0.18
Issue
Previously I had problems getting Volar to run properly on Windows, and while that was fixed I was still having some issues, but had moved on to other (non-Vue) projects so I didn't have the time or energy to look into it at the time. Now that I've been working on a Vue project again, these issues crept up again, so I'm making a new issue about one of them in particular.
Basically, Volar (or the TypeScript server, not entirely sure) is reporting on every line inside a Vue script tag (even empty lines) that there are at least 13 code actions available (often more depending on what the cursor is sitting on), but most of them are not logical for the context and will either crash Volar when selected or silently do nothing, mostly the former.
However, sometimes accurate code actions don't execute like they should, for example importing things through a code action might sometimes just not go do anything, but other times it adds the import just fine. It's hard to reproduce, so it's not included in the logs.
This doesn't happen in Visual Studio Code, and as far as I know, Code and Sublime LSP are using the same underlying dependencies (i.e. my project's TypeScript v4.7.3).
Logs
Here is the system log:
system.log
And here is the language server log:
languageserver.log

So, I decided to check my WSL2 install of ST and it turns out it happens there too? Which made me go and install LSP-volar on a MacBook Pro that I'm current borrowing and it turns out that it happens there too! 👀

Maybe specific to the project you are using it on then? If you'd provide that then someone might check it out.

The logs I posted are from a project I created with pnpm create vite (vue-ts preset) to confirm whether it's just my project or not, and it's not just my project that's making this happen.
I went and checked what this looks like in coc-volar (Vim, as to see if this is just a thing outside of VS Code) and saw that it lists the same code actions, but most of them are disabled. After adding some extra logging to LSP's code actions handler, I saw that they are indeed sent as disabled, with the reason why they are disabled as well.
So I guess that particular issue is a quirk in how LSP are presenting code actions, i.e. it's not filtering out (or marking them) disabled actions, but it doesn't solve the issue of Volar crashing on legitimate code actions (like highlighting a block of code and picking "Extract function"), but it seems like it's not a LSP-volar specific issue... 😕

One thing at a time. I'm implementing support for "disabled" code actions in https://github.com/sublimelsp/LSP/pull/1975 by filtering them out.

BTW. A proper-behaving server would not use "disabled" property on code actions if the client doesn't explicitly announce support for them. I would expect the server to filter them out itself instead.


[fixup][gws] mail transfer with multiple emails

Coverage decreased (-20.9%) to 61.6% when pulling 224dd42a86c989d5bd711ea3c8683cc5adea77ab on sunny4381:fixes/fixup-3388 into a3c5a7cdfc15cf8621296fdb1fcf4de97c67693a on shirasagi:master.


Start menu or some sort of Application launcher?

Could you implement some sort of Application launcher into Costa? And can Costa have some sort of taskbar or a panel to place apps on?

Hi dgrtygry,
The desktop is the application launcher, I'm not sure what you would like to see? The taskbar/panel idea is nice, but since Costa doesn't have multitasking, I don't really see a use for it.
If you can expand on your thoughts, maybe I can look in to something.


Fix up search process for aws_zsh_completer.sh in the non-brew case.

When "which" returns nothing, lack of quotes around variable was
causing a syntax error.  Quotes are also needed in
the (admittedly unusual) case of a filename with spaces in it.
The test should be for existence, not executability, since the
file is sourced, and therefore need not be marked executable.
Which also means that the "which" command isn't really a great
way to find the file.  It might not be in a place that's on
normal PATHs.  So this commit adds a check for one common place
to look: the location of the completer file on Amazon Linux - seems
reasonable to make sure the aws command has nice completion on
aws machines!

Obsolete and "fixed" in #7364


API support for Mary

There is still some work pending, but I'm leaving it for a follow up PR. In particular, probably we need to wrap utxos and account balances (which currently are used directly in the format  given by the backend) in new types that use the multi token class. And then refactor a few functions accordingly.
I ended up adding more changes to this PR, basically all the needed functionalities required for Mary (except the UI, which is being working on in a separate PR).
In summary, this PR does the following:

Introduces the MultiToken class for representing amounts (ported from the extension)
Updates all the transaction API, trying to stay in synch with the extension
Gets rid of BaseSignRequest
Move to ledgerjs 2.2.0
Bump Cardano libs

TODO:

[x] move to new backend API
[x] test code that uses the new bindings (recall: jest uses the node version)
[x] flow

Note: this shouldn't be merged yet because I'd like to release a hot fix for the ledger issue, and I'd prefer to keep this out.

Note: PR feedback will be addressed in the following PR.


docs: update minikube GSG

Signed-off-by: André Martins<EMAIL_ADDRESS>Summary of changes:
Review GSG for minikube tutorial

test-me-please


PowerToys Run doesn't launch

ℹ Computer information

PowerToys version: 0.29.0
PowerToy Utility: PowerToys Run
Running PowerToys as Admin: Yes
Windows build number: 20H2 19042.685

📝 Provide detailed reproduction steps (if any)

... Ensure PowerToys is running in the background
… Press the PowerToys Run keybind

✔ Expected result
What is the expected result of the above steps? PowerToys Run will launch
❌ Actual result
What is the actual result of the above steps? It simply didn't launch.
📷 Screenshots
Are there any useful screenshots? WinKey+Shift+S and then just paste them directly into the form

@Koooper Can you please open the command prompt and run dotnet --list-runtimes
Can you also add your logs for 0.29? %localappdata%\Microsoft\PowerToys\PowerToys Run\Logs

Here's my .net stuff:

Microsoft.AspNetCore.All 2.1.23 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.All]
Microsoft.AspNetCore.App 2.1.23 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
Microsoft.AspNetCore.App 3.1.9 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
Microsoft.NETCore.App 2.1.23 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
Microsoft.NETCore.App 3.1.6 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
Microsoft.NETCore.App 3.1.9 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
Microsoft.WindowsDesktop.App 3.1.6 [C:\Program Files\dotnet\shared\Microsoft.WindowsDesktop.App]
Microsoft.WindowsDesktop.App 3.1.9 [C:\Program Files\dotnet\shared\Microsoft.WindowsDesktop.App]
As for logs, there's nothing from 0.29 from that address, but I did find two log files in %localappdata%\Microsoft\PowerToys\Powertoys Run\LogsModuleInterface if that helps.
launcher-log_2020-12-30.txt
launcher-log_2020-12-31.txt

Here's my .net stuff:

Microsoft.AspNetCore.All 2.1.23 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.All]
Microsoft.AspNetCore.App 2.1.23 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
Microsoft.AspNetCore.App 3.1.9 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
Microsoft.NETCore.App 2.1.23 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
Microsoft.NETCore.App 3.1.6 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
Microsoft.NETCore.App 3.1.9 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
Microsoft.WindowsDesktop.App 3.1.6 [C:\Program Files\dotnet\shared\Microsoft.WindowsDesktop.App]
Microsoft.WindowsDesktop.App 3.1.9 [C:\Program Files\dotnet\shared\Microsoft.WindowsDesktop.App]
As for logs, there's nothing from 0.29 from that address, but I did find two log files in %localappdata%\Microsoft\PowerToys\Powertoys Run\LogsModuleInterface if that helps.
launcher-log_2020-12-30.txt
launcher-log_2020-12-31.txt

There are two scenarios for this problem:

PowerLauncher.exe is not started when PowerToys.exe starts, this is now tracked in https://github.com/microsoft/PowerToys/issues/9017
PowerLauncher.exe is running but not responding to the shortcut key, this is now tracked in https://github.com/microsoft/PowerToys/issues/9018

Closing this as duplicate, please refer to https://github.com/microsoft/PowerToys/issues/9017 or https://github.com/microsoft/PowerToys/issues/9018 depending on your case.
Thanks.

There are two scenarios for this problem:

PowerLauncher.exe is not started when PowerToys.exe starts, this is now tracked in https://github.com/microsoft/PowerToys/issues/9017
PowerLauncher.exe is running but not responding to the shortcut key, this is now tracked in https://github.com/microsoft/PowerToys/issues/9018

Closing this as duplicate, please refer to https://github.com/microsoft/PowerToys/issues/9017 or https://github.com/microsoft/PowerToys/issues/9018 depending on your case.
Thanks.


Explicit "unsafe" in session type language

Currently, if one needs to escape the session typing regimen temporarily, there is no way to do so while retaining the drop guards which are necessary to continue in over/split/call. Additionally, there is no marker in the type system to point at locations in a protocol where extra scrutiny is required due to departure from the listed session type.
Both of these issues can be allayed by the introduction of:

a new session type constructor, Unsafe<P> (only parameter is continuation, since its innards are opaque),
its corresponding Session! macro keyword unsafe; (no block, since its innards are opaque), and
a new method on Chan<S, Tx, Rx>:

async fn unsafe_with<F, Fut>(
    self, F
) -> (
    Fut::Output,
    Result<Chan<P, Tx, Rx>, IncompleteSession<Tx, Rx>>
)
where
    S: Session<Action = Unsafe<P>>
    F: FnOnce(DropGuard<Tx>, DropGuard<Rx>) -> Fut,
    Fut: Future
{
    // Call function on the drop guards for the transport ends, recover the transport ends or return an error.
}

In the above, DropGuard<T> is similar to the existing pattern in Dialectic of pairing a T with an Arc<Mutex<Result<T, IncompleteHalf<T>>>> and a Drop implementation that places T in the mutex. In the case of DropGuard, we don't need to worry about the case of an unfinished session, since Unsafe doesn't specify what session completion means. Thus, DropGuard should contain merely an Arc<Mutex<Option<T>>>. We can then implement Deref and DerefMut for DropGuard, allowing it to be used however the underlying Tx/Rx can be—including as the transmitter/receiver for a new Chan. This last ability means that Unsafe can crucially be used to nest protocols with different ways of using the underlying transport: for instance, to use different encodings/framings for messages in different parts of a protocol, or to embed a multiplexed subprotocol in a larger protocol, per the multiplexing backend described in #79.

Related to this issue, the function into_inner is almost never correct to call, since it unconditionally discards the drop guards on the Chan and therefore will result in a runtime error if called within over, split, or call. It should be replaced with:
fn try_into_inner(self) -> Option<(Tx, Rx)> {
    // only return `Some` if drop guard is a unique `Arc`
}

Documentation should discourage the use of this function and refer to unsafe_with for situations where only temporary access to the raw transport is needed.

Some may object to calling any of this "unsafe" since it cannot result in memory unsafety. Alternate nomenclature: Extern<P> type (alternatively: ExternCall?), extern; keyword (alternatively: extern call;? or extern _;?), extern_call function. This gets at the "this bit is not internally specified" notion, but without punning on the Rust meaning of "unsafe".
Presently, my favorite set of naming is Extern<P>/extern _;/extern_call.


Bug with lazy flag

can't reset infinite loop when lazy flag is true.
easiest way to show this is going to the example docusaurus template (which uses the lazy flag):
https://textbook.latenights.me/
and enter the following code:
res = 1
while True:
    res *= 2

when you run and then try to reset, the worker is not reseting.
The same can't be seen in the default code editor without the lazy flag (tried here and everything works :https://elilambnz.github.io/react-py/)

The difference here is that on the documentation site, the reset button is disabled while code is still being executed. All that reset does in both of these examples is set the input back to the initial value.
To prevent the behaviour you're seeing with runaway code, interruptExecution() could be called as part of resetting the codeblock - however this level of implementation is up to the developer.
It's easier to test this behaviour when looking at long running code that doesn't crash the browser, such as the example here - https://elilambnz.github.io/react-py/docs/examples/interrupting-execution

@elilambnz I'm sorry I've wrote "reset" instead of "stop". This does have interruptExecution() in both but the lazy flag is problematic here.
I've changed my original comment as well, but I still believe that this is a bug.

Testing with the code snippet in the "Interrupting Execution" docs here, you can absolutely call interruptExecution() by clicking the stop button regardless of the lazy prop being set.
However, with the snippet you provided, this causes a runaway process which completely locks up the browser tab. Trying to terminate the worker at this point is difficult, because the browser is already unresponsive.
This is the main reason why I moved to web workers (#25) so that the worker can be terminated, but there are obviously cases such as the snippet you provided that remain problematic. Some improvement is needed here to deal with being able to control these runaway workers, so I'll consider enhancing the termination logic when I'm next looking into this.


fix: Check contact url if is internal #250343

fix: Added a check if urls in Contact component are internal or not. #250343

@eea-jenkins build storybook

@eea-jenkins build storybook


App install page resize sometimes crashes the app

Dev Home version
No response
Windows build number
No response
Other software
Resizing Dev Home in the App Install page sometimes causes the app to crash
Steps to reproduce the bug
No response
Expected result
No response
Actual result
No response
Included System Information
No response
Included Extensions Information
No response

Duplicate #658


kube-aws: don't add trailing dot to empty dns names

If you add the trailing dot to an empty hostname, the validation
that hostname isn't blank is worthless.
Basically none of the trailing dot stuff was being tested because it was
being added in ClusterFromFile rather than ClusterFromBytes, which is only
used in the live code. Also, the r53 dummy service was returning the
HostedZone and ResourceRecordSet without the final ., which would be
there in the real return values.

Makes sense to me, LGTM.


Goldilocks inverse system call

This can help accelerate Plonky3 verification, as the bottleneck is calculating field element inverse.

Wait, why are changes to the executor not needed?

Good question! I forgot about it, but it worked anyway. I have no idea what is happening.


include flatpickr.min.js in edit-course.gohtml

for some reason the css but not the javascript is included for flatpickr
btw. is there a reason for why the codebase uses spaces instead of tabs? I think it would be friendlier for contributors to not have tab sizes forced upon them.

is there a reason for why the codebase uses spaces instead of tabs?

No, we just started that way and kept it. I think it's more important to be consistent than whether tabs or spaces are used. The indentation for our go code is enforced by the go language. We have a prettier configuration that should automatically reformat typescript and automatic formatting for .gohtml files might(?) be introduced with/after #452


Crash on latest version.

Describe your bug here.
Game crashes on picking any song
Command Prompt/Terminal logs (if existing)
PlayState.hx (Line 7450)
PlayState.hx (Line 5932)
flixel/group/FlxGroup.hx (Line 787)
PlayState.hx (Line 5840)
flixel/FlxState.hx (Line 222)
flixel/FlxGame.hx (Line 752)
flixel/FlxGame.hx (Line 682)
flixel/FlxGame.hx (Line 556)
openfl/events/EventDispatcher.hx (Line 444)
openfl/display/DisplayObject.hx (Line 1400)

Uncaught Error: Null Object Reference

Are you modding a build from source or with Lua?
Source
What is your build target?
Windows
Did you edit anything in this build? If so, mention or summarize your changes.
I literally emptied the mods folder, gives the following error: PlayState.hx (Line 1318) flixel/FlxGame.hx (Line 642) flixel/FlxGame.hx (Line 729) flixel/FlxGame.hx (Line 682) flixel/FlxGame.hx (Line 550) openfl/events/EventDispatcher.hx (Line 444) openfl/display/DisplayObject.hx (Line 1400)
If you use 1.12.0 or earlier, did you have Optimized Chart Loading turned on?
None

just keep the mods folder in, i dont think it impacts the performance

turn off double note ghosts


Tag SES resources with org, space tags

Other brokers tag resources using the https://github.com/cloud-gov/go-broker-tags repository. This broker should tag resources in the same way — e.g. CF org name, org GUID, space name, space GUID...

[x] Rewrite using sesv2 resources so SES identity can be tagged
[x] Tag a single resource, the SES identity, as a POC
[x] Write a module that allows repeatably tagging all resources created by the brokerpak
[x] Investigate tagging all resources created by the broker at the top level

Tagging with org and space information is currently not possible in the CSB. The CSB uses HIL to interpolate variables into service definition files. HIL does not support indexing into maps with heterogeneous value types, and the request.context map, which contains org and space information, contains both string and map types. I've opened a discussion in the CF Slack about possible workarounds.
OSBAPI Cloud Foundry Context object docs: https://github.com/openservicebrokerapi/servicebroker/blob/master/profile.md#cloud-foundry-context-object
Discussion in CF Slack: https://cloudfoundry.slack.com/archives/C0164KKEZGX/p1724703876380109

Started tagging all resources with default_tags on each provider. Now blocked until I hear back from the CSB dev team about the HIL issue.

Submitted PR to fix the issue: https://github.com/cloudfoundry/cloud-service-broker/pull/1087

Workaround works. Last tags added to broker; closing.


/admin/POLICY_URL -Page Not Found

So I just updated the status panel I'm running with the most recent version.
This activated the "Imprint & Privacy Policy" page.
However, when you try to open the file it displays an error 404 page.
You can view the issue live at https://status.otuts.eu/
Is there some config feature I missed?
Since I can't find anything in the settings page.
Kind Regards,

Update of the issue:
I manually edited the "config.php" with the "config.php.template".
This solved my issue.
But this raised another question:
I always override all the files expect the "config.php" as it contains the Database connection details.
Are there other filles which aren't overwritting that should be sometimes?

Only config should be updated manually :) Hopefully I will get some time between school and work to work on settings in database so that upgrading config.php will no longer be necessary :slightly_smiling_face:


Invalid schema created when using zod intersections

I posted an issue with the generated schema at https://github.com/microsoft/vscode-json-languageservice/issues/245 but the maintainer said the schema was invalid (I think?).
The original zod parser simply uses .and() to extend a base type with mixins:
z.object({…})
  .and(z.object({…}))
  .and(z.object({…}))
  // ...

Basically, the suggestion is to use unevaluatedProperties instead of additionalProperties.

Duplicate of #68


How much gpu memory dose this network need?

The config we provided can be trained with GeForce RTX 2080 Ti (11 GB).


Add module to find subnet ranges (powershell/situation_awareness/network/powerview/get_subnet_ranges)

Often during a pentest I find myself having to understand the environment quickly. This module is designed to pull down a list of computers from the Domain, ping test them, and parse them into easily digestible /24 ranges. The idea is that this will help give the tester an understanding of what ranges have already been identified and what ranges haven't been explored yet.
Expected output from the default settings (In context of a domain-joined machine)
<IP_ADDRESS>/24 - 3 Hosts
<IP_ADDRESS>/24 - 16 Hosts

get_subnet_ranges completed!

Expected output with IPs set to True:
The following subnetworks were discovered:
<IP_ADDRESS>/24 - 3 Hosts
<IP_ADDRESS>
<IP_ADDRESS>
<IP_ADDRESS>

get_subnet_ranges completed!

This is based on Powerview, but is distinct from the get_subnet module that already exists. That module looks for AD objects, whereas this is actually testing ranges based on DNS entries.
I marked it as not opsec safe because it does in fact interact with DNS, if only to ping the hosts.

Thanks @benichmt1 !


Policy: Route-Maps

@mtarking - I'll start on the Jinja for this, and look at creating similar structure to VRF-lite for the rest of the implementation.

Uploading the draft merged schema and data yaml file having the route map, acl, prefix list data model.
updated_schema_datafile_draft.zip


ESD Protection

Nice work so far!!
Looking at the design, I was curious about static discharge protection. Is that what R8 & R9 are for? I don't have the latest version of Kicad, so I couldn't open the schematics, but looking at the BOM, it looks like these resistors may be for ESD.

From, Hardware design with RP2040:

these I/Os do require 27Ω series termination resistors (R3 and R4 in Figure 9), placed close to the chip, in order to meet the USB impedance specification.

Regarding ESD, the RP2040 meets all the standard ESD specifications of 1-2kV Human Body Model, additional USB ESD protection may be added later depending on the available board space and cost.

Thanks for the rely! I am working on a ESP32-based thermostat  (https://github.com/smeisner/smart-thermostat) and was concerned about ESD. This is why I was asking. I am doing a final rev of the PCB and was hoping to incorporate protection into it.


Pull request on suspicious code

By testing the errorprone tool i found this two lines with some code that are implementation errors (or i think they are). I have modified them just in case there is already someone interested in this code.

Im closing this as the modification in BeanPropertyTarget is not right. I think it should be type.isArray() instead of !type.isArray() but i am not sure.


for version 2.0.x MongoClient not found, mongo extension is deprecated.

Mongo extension is deprecated. verison 2.0.x still require it.

Is this actually supposed to be helpful?  Please, think before you post.
2.x uses the old, deprecated driver.  3.0 uses the new driver.  Pretty simple.  I can't imagine anyone's going to invest the time to migrate the old Laravel 4.2 version of this package to use the new driver.  You need to upgrade.


Task 1.2: Let the model predict the price after 2 weeks

Established a code example to support the prediction we want.
Please see this branch for details: https://github.com/jingedawang/StockPredictor/tree/setup/algorithm
There are still some TODOs need to be solved in the code.

Do we have any criteria for this requirement (e.g. from a statistical perspective, what is the confidence interval/level, how accurate is the prediction, etc.)?  Thanks.

Thanks for point it out! Yes, we have some criteria to evaluate the model. I explained them in the next task, please see #7 for more details.


Custom staff filter

Allow customisation of the function used to validate the user for access to "staff-only" areas

@brente any chance of picking this up again and trying to resolve the conflicts? We had a bit of downtime recently, and trying to catch up on open PRs.

I'm going to close this PR since it was merged. Ongoing work on this and permissions in general in the develop branch, please file a new ticket if needed! Thanks for your work on this contribution!


ADDON-35152:Updated selected property

ADDON-35152

Updated Selected property of switch component which will be selected if the prop. value is "1", 1 or true.
Updated Default value fetching in form components

:tada: This PR is included in version 5.0.0-develop.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 5.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


MONDO:0033211 OMIMPS xref

See https://www.omim.org/phenotypicSeries/PS251280

@dhimmel thanks for this PR. It looks like we actually have duplicate terms:
MONDO:0033211 'diencephalic-mesencephalic junction dysplasia syndrome' already is equivalent to OMIMPS:251280, and it should be merged with MONDO:0017868 'diencephalic-mesencephalic junction dysplasia'
I will close your PR and create a new ticket to merge these terms.
Thank you!


fix: ChargePriceQueryService integration tests

Description

IntegrationTests fails in CI.
References

#0000

Replaced by https://github.com/Energinet-DataHub/geh-charges/pull/1817


pachctl list-job shows start times 6 hours in the past

What happened?:
Summary: pachctl list-job shows jobs starting 6 hours ago even though they just ran a second ago.
I’ve been running through examples locally with minikube on mac os x and when I commit a file to the repo the list-job command shows that job starting 6 hours ago even though I just started the job.
What you expected to happen?:
pachctl list-job to show correct start time for jobs
How to reproduce it (as minimally and precisely as possible)?:
I don't have a bare bones repro of this issue, hoping for a quick tip to set up clock timezone or some other simple solution.
Anything else we need to know?:
Example run locally was the beginner tutorial first pipeline to generate images with edges using opencv.
Environment?:

Kubernetes version (use kubectl version):
Client Version: version.Info{Major:"1", Minor:"10", GitVersion:"v1.10.11", GitCommit:"637c7e288581ee40ab4ca210618a89a555b6e7e9", GitTreeState:"clean", BuildDate:"2018-11-26T14:38:32Z", GoVersion:"go1.9.3", Compiler:"gc", Platform:"darwin/amd64"}
Server Version: version.Info{Major:"1", Minor:"13", GitVersion:"v1.13.4", GitCommit:"c27b913fddd1a6c480c229191a087698aa92f0b1", GitTreeState:"clean", BuildDate:"2019-02-28T13:30:26Z", GoVersion:"go1.11.5", Compiler:"gc", Platform:"linux/amd64"}
Pachyderm CLI version (use pachctl version):
pachctl             1.8.6
pachd               1.8.6
Cloud provider (e.g. aws, azure, gke) or local deployment (e.g. minikube vs dockerized k8s):
minikube
OS (e.g. from /etc/os-release):
Mac OS X Mojave
10.14.2
Others:

Hi @ccotar. I've tested things locally on Mac with all the same versions as you and am not able to repro the behavior you're seeing.
That said, I think I've seen something similar to this in the past, but was never able to repro successfully -- I didn't spend much time on it. My theory was it had something to do with minikube getting out of sync when I put my laptop to sleep, but again, never tested this extensively. If you're able to figure out more concrete repro steps, we'd be happy to take another look at this.

Thanks for trying to repro, I will try restarting minikube since I let my laptop sleep with it on a lot and see if that fixes the timing issue

Restart of Minikube worked as well as using the docker for mac k8s.


Screen blacked out when trying to add new credit card to Google Express app

Is this a security feature in apps or a scrcpy v1.2 bug (sorry, could not update to 1.3 yet)? The moment it went to the page where you add a new credit card to Google Express, everything on the screen except for Gboard blacked out and remained black.
I could still type from my computer keyboard and see the input on my phone, but the screen stayed black for the entire time until I submitted the data. Then when it returned to the checkout page, it showed again as normal.

The app enables screen protextion. See FAQ.

Oops, thanks!


fix ISSUE_TEMPLATE

fix for #3167

Codecov Report

Merging #3243 (b40bd32) into master (343e7de) will increase coverage by 0.08%.
The diff coverage is n/a.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
@@            Coverage Diff             @@
##           master    #3243      +/-   ##
==========================================
+ Coverage   25.19%   25.28%   +0.08%
==========================================
  Files          54       54
  Lines       11933    11933
==========================================
+ Hits         3007     3017      +10
+ Misses       8926     8916      -10

see 2 files with indirect coverage changes

strange these 2 old tests which are required to get the merge button visible ...
any ideas?
could try to push this commit directly on master

strange these 2 old tests which are required to get the merge button visible ...

very strange, especially that 14.x one...

any ideas?
could try to push this commit directly on master

I would be okay with that, if github / git allows it :-)

oh wait, wouldnt then the update notification be triggered for all users?

oh wait, wouldnt then the update notification be triggered for all users?

no, I wrote this already in the issue.
as expected:
remote: error: GH006: Protected branch update failed for refs/heads/master.
remote: error: 2 of 2 required status checks are expected.
To github.com:MichMich/MagicMirror.git
 ! [remote rejected]   master -> master (protected branch hook declined)
error: failed to push some refs to 'github.com:MichMich/MagicMirror.git'

So I think this can only be merged by @MichMich . If the "Squash and merge" button is disabled for him too he can disabled the check rule, do the merge and then enable this again.

After a good nights sleep I'd be fine with merging it to develop. We can live another two month with this issue after having it  for so long :-)

@rejas moved to develop and now ready to merge
I will play with a master merge later to may find the cause of the node v14/v16 tests, couldn't reproduce this on my fork ...


feat(client): expose the language button to the navbar

Checklist:

[x] I have read and followed the contribution guidelines.
[x] I have read and followed the how to open a pull request guide.
[x] My pull request targets the main branch of freeCodeCamp.
[x] I have tested these changes either locally on my machine, or GitPod.

Ref #41373

@Sboonny We need to make a decision here as to whether this is going to be a true "menu". Right now we have role="menu" on the list and role="menuitem" on each button in the list. If we keep these then we need to implement all of the expected keyboard commands and behaviors that go along with them, such as being able to use the arrow keys to navigate through the languages, using the Esc key to close the menu, Home and End keys to take you to beginning and end of menu. Basically, it needs to function the same way the current language selector does.
Otherwise, we need to remove all roles associated with this menu. We would also need to remove aria-haspopup from the Change Language button and add aria-expanded to the button. This would turn it into a disclosure menu, just like the main menu, in which you can only tab through the items. I'm fine with that. I think this menu could go either way. It would make it much easier to implement if we didn't include the roles. But if we do this option then I do think that we should still implement the Esc key to close the menu when focus is on one of the language buttons.

I just noticed that there is now a change in behavior when you Shift + Tab from the first menu item to the button. On production, if you use the keyboard to open the main menu and then tab into it, and then use Shift + Tab to go back to the menu button, the menu does not close automatically. The menu does not close until you Shift + Tab one more time to take focus off of the Menu button. This PR is changing that behavior so that the menu closes immediately when you Shift + Tab to the button itself, but the screen reader still announces it as expanded.
I think we need to follow the current behavior on production. The lists should remain open if you Shift + Tab to the button from the list. Then they should close automatically if you Shift + Tab one more time to take keyboard focus off of the button.
As for the other end of things, tabbing out of the list is working fine.

I have an issue with the production way, the issue isn't with the idea, but when the menu in nav-links lose focus and focus on language list, it doesn't close the menu.
do you know why?
rec-tab (3).webm

@Sboonny The issues with the Menu button not closing is in https://github.com/freeCodeCamp/freeCodeCamp/blob/main/client/src/components/Header/components/menu-button.tsx#L28.
Now that we have another button in the .universal-nav-right div the logic doesn't quite work any more. Can probably change it to:
!event.relatedTarget.classList.contains('nav-link') &&

That seems to work well for me.

In addition to my code suggestions to deal with screen readers announcing aria-expanded correctly, I've got the following things that might need attention:

When you put the keyboard focus on the change language button (without expanding the menu) the background color changes. But when you put the keyboard focus on the main menu button the background color does not change. We should probably make these behave the same. I might lean toward the background staying the same, that way if you have keyboard focus on the button and then hover with your mouse you still get a change.

If you open the main menu and then tab into it so a menu item has keyboard focus, and then click outside of the menu (somewhere other than the menu button itself) with your mouse, the menu will close up. If you do the same thing with the language menu, the menu does not close on the mouse click.

@Sboonny We've got an issue with the checkmark on the currently selected language when in RTL mode. I can't find any logical properties for background-position. Do you know of any?
My solution is to add the following after the .nav-lang-list-option[aria-current='true'] ruleset on line 173:
[dir='rtl'] .nav-lang-list-option[aria-current='true'] {
  background-position: 10px center;
}

But maybe you know of a better way to do this?

We can add the SVG as background for pseudo-element, and what is left is adding flex to the li and it will always be inline.

Thank you for the thorough review, that was fun 💚😁


Breadcrumb should take you out to global asset catalog (its type)

There's no need to include the library in the breadcrumb because the library is linked from the asset detail page dashboard.

[ ] Only two items in the breadcrumb
[ ] First item is the asset type (e.g. "Components") that takes you out to the global catalog for that asset type
[ ] Second item is read only, the asset name

Spec:

My hypothesis, when finding this component from its library, you likely want to go back to the library to view other assets and we're making that too hard by relying on browser back button and the link to the library in the dashboard.

the breadcrumb in the example about is correct.
We want the breadcrumb to stay the same whether coming from asset catalog or library. We have 2 scenarios.
Scenario 1: breadcrumb is asset based (like above example)
Coming from asset catalog:

When browsing the component catalog, a user would select component and go to details.
to get back a user would use breadcrumb or the back button

Coming from library:

when coming from library, user would select component from data table and see breadcrumb from
to get back to library, a user would need to use back button

Scenario 2: breadcrumb is library based
Coming from asset catalog:

When browsing the component catalog, a user would select component and go to details
we would most likely need to implement the side nav on our asset pages instead of the tabs (i would have to think this through a bit but my instinct is that it should stay since we aren't actually leaving the library section)
to get back a user would have used the back button

Coming from library:

when coming from library, user would select component from data table and to stay consistent, would need a level of side navigation
to get back to library, a user would need to use back button

I think it would be best to go with scenario 1. Scenario 2 breaks the browsing experience for when users are in the catalogs—it puts the emphasis on the Library experience while I suspect much of our traffic will be coming from the catalogs. If we have to add the side nav back into the asset pages for scenario 2, it could get a little jarring for users who are browsing to jump in and out of a libraries and their contextual side nav. Scenario 1 keeps it simple.


[NTR] CDH1-Related Diffuse Gastric and Lobular Breast Cancer, DGLBC

From ClinGen (Sheng-An Yang)
New term: CDH1-Related Diffuse Gastric and Lobular Breast Cancer
Syn: DGLBC
Definition:
Germline pathogenic or likely pathogenic variants in the CDH1 gene (NM_004360.5) predispose to hereditary diffuse gastric cancer (HDGC; MIM# 137215), a cancer susceptibility syndrome inherited in an autosomal dominant pattern, initially characterized by the increased risk for diffuse gastric cancer (DGC) but subsequently well documented to be associated with lobular breast cancer (LBC) in women. To encompass the increased risk for both DGC and LBC in the name of the CDH1 syndrome, the ClinGen Disease Naming Committee and CDH1 Variant Curation Expert Panel (VCEP) have proposed to redefine the disease as CDH1-related Diffuse Gastric and Lobular Breast Cancer Syndrome (DGLBCS).
Reference. We are still submitting our manuscript which contains the information of the new disease term (DGLBC). Since we expect this paper will not be published soon, may we add reference after the paper gets published?
Parent term. The old disease term (Hereditary diffuse gastric cancer, MONDO:0007648) is under these two parent terms: hereditary gastric cancer (MONDO:0018502) and diffuse gastric adenocarcinoma (MONDO:0005017). However, since many woman patients with CDH1 variants also have lobular breast cancer (LBC), we think the old parent terms cannot well cover the new disease term (DGLBC). Therefore, we are thinking that these two ways may solve this issue:

Use all parent terms that related to DGLBC. So, we selected 4 parent terms for DGLBC: Hereditary gastric cancer (MONDO:0018502), Breast lobular carcinoma (MONDO:0000552), Mendelian disease (MONDO:0003847) and Adenocarcinoma (MONDO:0004970). The caveat for this way is Hereditary gastric cancer (MONDO:0018502) and Breast lobular carcinoma (MONDO:0000552) only cover part of phenotypes of DGLBC.
Only use Mendelian disease (MONDO:0003847) and Adenocarcinoma (MONDO:0004970) as parent terms. Thus, the two parent terms can well cover the phenotypes of DGLBC. However, the caveat is that these two parent terms are not specific enough.

Updated 2022-03-02:
Parent terms should be:
Hereditary gastric cancer (MONDO:0018502)
Breast lobular carcinoma (MONDO:0000552)
Nano-attribution: https://www.clinicalgenome.org/affiliation/50014/
--
Note, this is similar to Hereditary diffuse gastric cancer, MONDO:0007648.
They said: We hope to add a new disease term in addition to the old one, since the old term might be also used by other groups or in other conditions. Therefore, we would like to keep Hereditary diffuse gastric cancer (MONDO:0007648) and add CDH1-Related Diffuse Gastric and Lobular Breast Cancer Syndrome (DGLBCS) as a new term.

based on the definition, I suggested that we add the parent 'inherited disease susceptibility' and add predisposes towards Hereditary gastric cancer (MONDO:0018502)
Breast lobular carcinoma (MONDO:0000552)

confirmed the above


Debugging always keep last debugging status and info.

VS: dev14 community
OS: windows 8.1 enterprise
Powershell: v4
Repro steps:
1. Install latest version PoshTools from http://aka.ms/Get-PoshToolsNightly;
2. Open VS and create a PowerShell project.
3.Type a sentence with wrong grammar like '& 'C:$Recycle.Bin' to one method, and then F5, after F5 complete, you can see some error info from the output window;
4.Delete this wrong sentence '& 'C:$Recycle.Bin'  from the method in step 3, and then F5 again, verify whether debug will success.
Expect: Debug will success and haven't any error info in output window;
Actual: Debug failed and still have same error info with the last debugging, please see the top screenshot
More Info:
On the contrary, if the last debugging is success, after add some wrong sentences and then the next debugging will success. And when you debug multiple times(>2), debugging will return normal status.

@RongTang Thanks for reporting issue. Are you sure you are not seeing the original error(which was from last round of run)? I could not repro your issue on my end. Could you double check it by clearing your output window before each debugging run?

Yes, I'm sure. I have verified this issue on another machine, it also repro. And the Output window could only display current debugging info, when you start the next debugging, the last round of debugging info will be automatic cleared. I found the method call locate at ahead of the called method, this issue will repro; In contrast, this issue won't repro.

@RongTang I m still not able to get it. Tried on both dev12 and dev14 on 8.1 + PSv4, no repro.
I guess what I originally wanted to say "clearing the Interactive window(a.k.a REPL)", you are right, output window automatically clears for each debugging/execute, however REPL window is keeping all historical log(error).
Would you be able to show me a quick video on onedrive(or some internal places) about that repro, or let's just set up meet so that you can share me your desktop sometime next week?

As my machine has a problem and couldn't make a video, I copy the details steps as below,
VS: Dev14 Community,Dev12 Ult
OS: Win8.1 Ent
PoshTools: V4

Install latest version PoshTools from http://aka.ms/Get-PoshToolsNightly;
Open VS and create a PowerShell project;
Type some codes to editor as pictures right,

F5 and check the Output window as below,

Add this wrong sentence '& 'C:$Recycle.Bin' to above codes as below,

then F5 again and check the Output window as below,

More Info:
When you debug multiple times(>2), Output window will show correct info.
Repro machine:
Account: Redmond\vslab2; IP:<IP_ADDRESS>
If you're still not repro it, please feel free to tell me, tks.

@RongTang I think I got what you are seeing here, and why. Generally there are a few things needs to be clarified;

PowerShell script need forward declarations of functions, like header files in C/C++ for example. This can be proved by first time to run your script right after you start new VS instance.
The PowerShell runspace is preserved during the entire life of that VS instance.
Within this in mind,
By F5'ing against your script for multiple rounds, you basically call into previous definition of StringContact from last round of run(F5), which explains the weirdness of what you are observing.
You should observe the same on powershell ISE.

Thanks for your reporting! I'll close it for now, please reopen it if you see otherwise.


MWPW-137193 - Quiz results validation improvements

checks for an empty basic fragment object

Resolves: MWPW-137193
Test URLs:

Before: https://main--milo--adobecom.hlx.page/drafts/colloyd/quiz-results-block/quiz-results?quizKey=result-validation&debug=quiz-results&martech=off
After: https://mwpw-137193-quiz-result-validation-improvements--milo--colloyd.hlx.page/drafts/colloyd/quiz-results-block/quiz-results?quizKey=result-validation&debug=quiz-results&martech=off

To test these pages add the following to local storage for each page:

key: result-validation
value: {"primaryProducts":["lr","pr"],"secondaryProducts":["ps","au"],"umbrellaProduct":"cc","basicFragments":[],"nestedFragments":{},"pageloadHash": "some-hash-value-that-matches-the-format-they-want-with-the-quiz-responses-that-were-chosen"}

The "Before" page will render a blank page and you should not see debug console logs about basic fragments missing. The "After" page will have messaging indicating that basic fragments are missing and that the page will redirect (when using the debug param as included in the urls).

https://helpx.ci.corp.adobe.com/view/0. Milo/job/01-E2E UI Test Matrix - CC - App Recommender-Nala/


Streamlit

Added app.py but still need cleaned data put in the data subfolder

app.py looks good but we might have to modify the data loading part so that it reads from a Google Drive link instead. I can handle that if you reply to this with a list of column name specifications for the data.


fix(skip_one): fix floating-point skip_one logic

Currently, skip_one only handles scalar cases. When a floating-point skip_one occurs, the value of the floating-point register is incorrectly synchronized to the scalar register. We have fixed this.
After the modification, we can correctly handle scalar and floating-point skips. However, vector skips will not be allowed, so an assert will be raised when a vector triggers a skip.
Currently, our framework cannot correctly synchronise the data in the vector register. After subsequent discussions, we will add support for this, and this commit will first fix the bug where the floating-point register cannot be correctly synchronised.

For reference, the XiangShan processor should never under normal circumstances generate a skip vector, so it is acceptable to add an assert in this place, but we can still choose to add support for vector skip in the future.
The main reason for not adding support for vector skip for the time being is that the width of the vector register needs to be greater than 64, and in some implementations, the vector register may be split into multiple register stacks. For example, in the XiangShan processor, the V0 register is split into a separate register stack.
In summary, we may add support for vector skip in the future, but for now, the priority is to fix the floating-point synchronization bug.

minstret

Thanks, this path can be merged.


Display accrued bond rewards

@sickmullahh on telegram gave us this idea:
"i want to be able to see how much rewards the node has accrued."
Display on Node details the accrued bond rewards of my (any?) node.

This will soon be available on the latest node account endpoint.
https://gitlab.com/thorchain/thornode/-/merge_requests/1153


KAFKA-16141: Fix StreamsStandbyTask system test

KAFKA-15629 added TimestampedByteStore interface to KeyValueToTimestampedKeyValueByteStoreAdapter which break the restore code path and thus some system tests.
This PR reverts this change for now.

\cc @agavra @stanislavkozlovski

Triggered a system test run: https://jenkins.confluent.io/job/system-test-kafka-branch-builder/6035/

I'm not familiar with the IQv2 path so can't comment on whether or not it makes sense from that perspective but it should fix KAFKA-16141.

If did run the single system test locally and it passed.
About IQv2, even if you don't have a full picture, given that remove TimestampedByteStore isTimestamped now returns false however, by also adding isAdaptor check, we get true again -- so even just from a context free POV, nothing should change, right?

@mjsax - yes the changed code should definitely work, my point was that I can't confirm that there aren't other places we need to change as well.

Ah. Fair enough. I think (hope?) that existing unit/integration test ensure we did not miss a place :)

Jenkins looks good, but previous system tests run did not start to run the test (I assume also because of the compilation error). Retriggered: https://jenkins.confluent.io/job/system-test-kafka-branch-builder/6039/

Merged to trunk and cherry-picked to 3.7 branch.


Popper directive "content" input errors

The popper directive uses the content field in two ways:

The name of a template reference
A text string to display as a tooltip

In some situations, errors are thrown in the directive because of this dual use of field.
Given this template:

and this code:
public myProperty: string = 'Hello';
public onClick(): void {
    this.myProperty = 'World';
}

results in the following error:
TypeError: Cannot create property 'referenceObject' on string 'World'
    at PopperController.show (webpack-internal:///../../../../ngx-popper/ngx-popper.es5.js:2509:39)
    at eval (webpack-internal:///../../../../ngx-popper/ngx-popper.es5.js:2547:19)
    at ZoneDelegate.invokeTask (webpack-internal:///../../../../zone.js/dist/zone.js:421:31)
    at Object.onInvokeTask (webpack-internal:///../../../core/esm5/core.js:4944:33)
    at ZoneDelegate.invokeTask (webpack-internal:///../../../../zone.js/dist/zone.js:420:36)
    at Zone.runTask (webpack-internal:///../../../../zone.js/dist/zone.js:188:47)
    at ZoneTask.invokeTask (webpack-internal:///../../../../zone.js/dist/zone.js:495:34)
    at ZoneTask.invoke (webpack-internal:///../../../../zone.js/dist/zone.js:484:48)
    at timer (webpack-internal:///../../../../zone.js/dist/zone.js:2065:29)

Also, looking at the code, there are no changes handler for the "content" input, only "popperDisabled".

you should use it like so:

This doesn't work as interpolation cannot be used with the form []. Angular error is:
Parser Error: Got interpolation ({{}}) where expression was expected...

Also using the form:

results in the same error (Cannot create property 'referenceObject'...).

this works fine for me, can use provide a more info?

myProperty needs to change after being initialized to another value. In the example above, I was using a click handler to change the value. The issue happens when I mouse over the element that should display the tooltip. Before invoking the click handler, the tooltip was displaying correctly.

indeed this is a limitation, you should then use:

`{{myProperty}}`
Ill think about a way of supporting you use case tomorrow.

@hspier Ive just released a new version 2.2.1 with support for this.

should work fine now, can you please verify?

Just tested, the issue is resolved. Thanks for the quick fix!

Sure, hope it serves you well.
PS stars are appreciated :)

Sure, hope it serves you well.
PS stars are appreciated :)


Feature/resample

Implemented low-variance resampling method from prob robotics book, see, conveniently https://robotics.stackexchange.com/questions/16093/why-does-the-low-variance-resampling-algorithm-for-particle-filters-work
There are a few other small changes to MCEM

Test seems to fail because:
Fatal error: 'try!' expression unexpectedly raised an error: Python exception: No module named 'numpy': file PythonKit/Python.swift, line 673

Oh I see. I think we need a pip3 install --user numpy in .github/workflows before running swift test.
Let's merge this and after that I can put up a PR that fixes this.


Profiles 2.0 multiple dimension layout plan

The second version of the profile layout requires separate layouts for compact and regular widths. When viewed in compact width all of the elements stack vertically. In regular width the avatar is on the left with the remaining elements stacked vertically to the right of the avatar.
Possible approaches
Variable number of StreamCellItems
Create a new type of UICollectionViewCell that takes a  custom UIView that knows how to lay itself out. Compact width uses 5 separate cells (avatar, name, views, description, links). Regular mode uses 1 cell that composes all of those views.
Pros

Uses our existing cell item paradigm.
Easier to separate units of work into separate cells.

Cons

Rotation (in the future) will require a recalculation of data potentially requiring a complete redraw of the UICollectionView.

Same number of StreamCellItems
Both compact and regular use a single UICollectionViewCell and a single StreamCellItem. Their layout is composed of ~5 custom views (avatar, name, views, description, links).
Pros

Maintains an equal number of StreamCellItems for all layouts.
No recalculating of cell items when rotating.

Cons

Harder to separate the work.
A single cell managing 5 regions of UI and user interactions with that UI may become complicated and heavy.

Final choice - Same number of StreamCellItems using a single cell. 👌


Websocket integration tests - SET and GET

This PR is a preparatory step in adding integration tests for websocket --> #557.
We want to use all async server integration tests as it is for websocket with minor changes.
This PR

changes websocket FireCommand function to be compatible with async server integration tests
adds tests for GET command

@pratikpandey21 @lucifercr07 - Please review.

@pratikpandey21 - the only change I made was related to types in assert statement. These types are dependent on the parsing logic which will evolve as we ass more tests to it.


Rewrite in AngularJS 1.X using TypeScript.

This pull request is a complete rewrite of all existing functionality using AngularJS 1.X and TypeScript. This is a work in progress and there are more things to implement before we can make a release:

Automatically refresh the view after uploading a file using an HTML form.
Integrate DropZone as an alternative to using HTML forms directly.
Ensure all errors are caught and displayed to the user.
Write unit and integration tests.
Set up Travis CI to run tests and create builds.
Things I missed?

Here is what I'd like feedback on specifically:

Structure and organization of the project. Are there better (more idomatic perhaps) ways to structure AngularJS projects? Should I use namespaces, modules, or both?
HTML and CSS structure. Is the HTML I used clear and straight-forward? Is it flexible enough to allow appropriate restyling?
Core functionality. This includes browsing the bucket, creating folders, uploading files, deleting folders, deleting files, downloading files, and downloading specific file versions.
User interface. Is it intuitive? Is the layout good?

I will end up expanding the README.md based on the feedback I get. For now, to test this, you will need an S3 bucket with an appropriate CORS configuration (see a very permissive example below).
<?xml version="1.0" encoding="UTF-8"?>
<CORSConfiguration xmlns="http://s3.amazonaws.com/doc/2006-03-01/">
<CORSRule>
    <AllowedOrigin>*</AllowedOrigin>
    <AllowedMethod>GET</AllowedMethod>
    <AllowedMethod>PUT</AllowedMethod>
    <AllowedMethod>POST</AllowedMethod>
    <AllowedMethod>DELETE</AllowedMethod>
    <MaxAgeSeconds>3000</MaxAgeSeconds>
    <AllowedHeader>*</AllowedHeader>
</CORSRule>
</CORSConfiguration>

 Clicking "Delete" on directories in S3Commander deletes the objects in S3, but fails to display the directory as deleted to the user

tslint reports 4 remaining errors:
ERROR: src/common/IUploadConfig.ts[14, 17]: missing whitespace
ERROR: src/s3session/S3SessionController.ts[31, 7]: comment must start with lowercase letter
ERROR: src/s3session/S3SessionController.ts[38, 7]: comment must start with lowercase letter
ERROR: src/s3session/S3SessionController.ts[39, 7]: comment must start with lowercase letter

@amadornimbis Regarding tslint I think a better approach would be to add a gulp task to run it for you. Maybe gulp lint? I'll fix the first error but the remaining 3 are caused by // TODO comments which will be removed in a future PR. Actually, it kind of bothers me those are issues because of uppercase versus lowercase. I would much rather have a warning regarding TODO and XXX than an error because my comment isn't lowercase, so maybe I'll look into changing it's configuration to do that.
Regarding the CONTRIBUTING.md file, I plan to update it once I add tests in a future PR so I can reference the entire testing procedure.

Ready for another look.

Updated README.md to mention HTTPS and HTML file upload quirk.
Resolved the tslint warnings by fixing the code and adjusting the configuration of the linter.
Added a gulp tslint task and updated the README.md file to mention it.


Remove fixture path from Runner.filter() arguments

You can filter them before passing to .src()

We will need it for the studio to support run via multiselect - files may contain fixtures with the same name. So, closing this.


Stop using luaL_check for negative arguments

In the Lua bindings (src/api folder) the luaL_check* and luaL_opt* family of functions are generally used to check argument types.  However, if they are used with a negative argument index (like when reading a table field), you'll get a bad error message that looks like this:
Bad argument #-1 to Object:function (expected number, got string)

We should replace these with custom error messages using lovrAssert or use luaL_typerror with a better stack index.

Hm, Lua 5.2 has lua_absindex that can be used for this.  Could polyfill that and use it to convert negative stack positions to absolute stack positions before passing them to luaL_check/luaL_opt functions.


firebase_auth "Use the plugin" typo in example, doesn't build

The below example is listed in the firebase_auth plugin page on pub.dev:
https://pub.dev/packages/firebase_auth
Future<FirebaseUser> _handleSignIn() async {
  final GoogleSignInAccount googleUser = await _googleSignIn.signIn();
  final GoogleSignInAuthentication googleAuth = await googleUser.authentication;

  final AuthCredential credential = GoogleAuthProvider.getCredential(
    accessToken: googleAuth.accessToken,
    idToken: googleAuth.idToken,
  );

  final FirebaseUser user = await _auth.signInWithCredential(credential);
  print("signed in " + user.displayName);
  return user;
}

The function "signInWithCredential" returns an AuthResult, which is not the same type as user (FirebaseUser).  It should look something like this I think:
 final FirebaseUser user = (await _auth.signInWithCredential(credential)).user;

@mrmax99
This issue has been moved to https://github.com/FirebaseExtended/flutterfire/issues/1090. Any further collaboration will be done there.


Cantonese support

This project will be great if it can support traditional chinese languages like Cantonese!

I also support Cantonese, the language of Cantonese is really good

There are very litte support on Cantonese among tts models, its very sad


Cant add base64 images

Hello guys,
I've tried to add base64 images to documents but the result is that the image is not rendered in the pdf, and also the pdf cannot be oppened in my browser.
Anybody knows what could be happening??
Here's my code:
var buffer
if (isUrl(signatureImage.url)) {
  var result = request.getSync(signatureImage.url, {
    encoding: null
  })
  buffer = result.body
} else {
  buffer = signatureImage.urls
}
pdf.image(buffer, 50, 50, { width: 120, height: 60 })

The same thing happens in my pdf I guess

Solved, Still don't know why wasn't working yesterday but not now


Discord client not showing the rich presence

I have the discord client , i am running bmbf beat saber on quest 2 with teh rich presence mod, the status was successful to reach presence from quest, but the game activity still isnt working, anyone had the same issue ?

This is a discord bug if anything.
Try reinstalling discord, and restarting your PC.


Background audio AccessViolation when playing certain MP3 files inside a MediaPlaybackList

BackgroundMediaPlayer crashes with an AccessViolation (in mfcore.dll) when playing certain MP3 files, but only when inside a MediaPlaybackList. It does not happen if I set BackgroundMediaPlayer.Current.Source directly (no MediaPlaybackList), and only happens with some files. These files play fine in every other media player, including Groove.
Stacktrace:
msvcrt.dll!00007ffbf44e3d60()
mfcore.dll!00007ffbc5d374a3()
mfcore.dll!00007ffbc5d371e6()
mfcore.dll!00007ffbc5d36548()
mfcore.dll!00007ffbc5bed8a2()
mfcore.dll!00007ffbc5bed67a()
mfcore.dll!00007ffbc5bedd5a()
mfcore.dll!00007ffbc5becadd()
RTWorkQ.dll!00007ffbe3f02521()
ntdll.dll!00007ffbf6697ed5()
ntdll.dll!00007ffbf666667d()
kernel32.dll!00007ffbf64064a2()
ntdll.dll!00007ffbf669eca4()

I'm running the latest RS insider build

Can you provide a link to a file that reproduces this so we can test? Alternatively, I can provide instructions next week for how to collect logs that may help us diagnose further.

To start with, while you are debugging a process in Visual Studio, you can save a dump file when the debugger has stopped at an exception or at a breakpoint. Choose Debug, Save Dump As and select Minidump with Heap (the default).

Thanks for the instructions, I've uploaded a crash dump here: Windows.Media.BackgroundPlayback.dmp (100MB)
And here's a sample MP3 that crashes: crash.mp3 (I've truncated the file to 127KB, but the behaviour is identical)

Worth noting I get AccessViolations using MediaPlaybackItem's created from URI in the background task using any media file not included in the application package (i.e, the file path was obtained via a search query on the user's Music Library)

Thanks for the data on this. There appear to be a couple issues at play and the team is investigating.

We believe we have addressed this in a future platform update. Thanks for the reports.


[FLINK-20961][table-planner-blink] Fix NPE when no assigned timestamp defined

Fix an erroneous NPE created when using a table from a DataStream that did not assign timestamps and watermarks
Brief change log

Fix direct access to ctx.timestamp(), validate that it has a timestamp before

Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:
(Maybe, not sure)  - The runtime per-record code paths (performance sensitive): (yes / no / don't know)
Documentation

Does this pull request introduce a new feature? No

@wuchong Please re-check.

@wuchong Please re-check.

@wuchong Thank you for the comments. Made the modifications.

@wuchong Thank you for the comments. Made the modifications.

Oops, MatchRecognizeITCase.testWindowedGroupingAppliedToMatchRecognize is still failed, because org.apache.flink.cep.time.TimeContext#timestamp returns primitive type long, and long can't be compared with null.
I think we either we generate a special code for MATCH_ROWTIME in MatchCodeGenerator#visitCall, either faillback your previous approach by introducing a temporary Long variable.

Oops, MatchRecognizeITCase.testWindowedGroupingAppliedToMatchRecognize is still failed, because org.apache.flink.cep.time.TimeContext#timestamp returns primitive type long, and long can't be compared with null.
I think we either we generate a special code for MATCH_ROWTIME in MatchCodeGenerator#visitCall, either faillback your previous approach by introducing a temporary Long variable.

@wuchong Reintroduced the local variable.

@wuchong Reintroduced the local variable.


Noise: Add getpid/getTime for NO_FILE_SYSTEM

Reported by beutlich on 19 Oct 2015 18:13 UTC
ModelicaInternal_getpid and ModelicaInternal_getTime need to be considered if NO_FILE_SYSTEM is defined.

Migrated-From: https://trac.modelica.org/Modelica/ticket/1805

Comment by beutlich on 21 Oct 2015 09:00 UTC
Temporarily show ticket.

Modified by beutlich on 21 Oct 2015 10:23 UTC

Comment by beutlich on 23 Oct 2015 12:53 UTC
Both functions are independent of the availability of a file system but still have implementation specific issues. See https://github.com/DLR-SR/Noise/issues/74 for a discussion.

Modified by beutlich on 23 Oct 2015 12:54 UTC

Modified by beutlich on 23 Oct 2015 12:59 UTC

Comment by otter on 10 Dec 2015 10:14 UTC
Fixed in bd869f466ac057d5e8062801250e3296c5275a89 by adding defines NO_PID and NO_TIME

Comment by beutlich on 21 Dec 2015 11:56 UTC
This is a reminder for me that ModelicaInternal_getpid and ModelicaInternal_getTime should be moved out of the NO_FILE_SYSTEM macro and tested on dSPACE.

Modified by beutlich on 21 Dec 2015 11:56 UTC

Comment by beutlich on 21 Dec 2015 15:09 UTC
Resolved by 717bed6372333262c28f0f80c6eb3c81c144c00f.


Try Dagger on multinode

Summary
Try the integration of our Tensor methods with Dagger on a multinode execution. See issue #95 for more information.

I'm interested on how the network affects the execution, so I would like a recreation of #95 but with 1 core/worker and 1 worker/node. It would be nice to try it in CTE-AMD and Marenostrum 4.