Swiper Options centeredSlides centeredSlidesBounds, slidesPerView: auto prevent initialSlide to be 0

Check that this is really a bug

[X] I confirm

Reproduction link
https://codesandbox.io/p/sandbox/sleepy-sky-5pyk3y?file=%2Fsrc%2Fcomponents%2FSwiperSlider.vue%3A14%2C9
Bug description
When using the following settings together:
centeredSlides: true
centeredSlidesBounds: true
loop: false,
sliderPerView: 2 or 'auto' along with max-width on swiper-slide,
pagination: true
the initialSlide (the active slide) is always the second one and it can not be overridden to 0.
Expected Behavior

Initially to have, 2 slidesPerView, left-aligned, no loop, no partial slides, and the first pagination bullet to be the active one.
After the first slideChange, I want the slides to be centered-aligned. Also, I want to partly see the previous and the next slide.
On the last scroll, I want the slides to be right-aligned, and see only the last 2 slides (no partials).

Actual Behavior
No response
Swiper version
^9.4.1
Platform/Target and Browser Versions
Linux Ubuntu, All browsers
Validations

[X] Follow our Code of Conduct
[X] Read the docs.
[X] Check that there isn't already an issue that request the same feature to avoid creating a duplicate.
[X] Make sure this is a Swiper issue and not a framework-specific issue

Would you like to open a PR for this bug?

[ ] I'm willing to open a PR

im having this issue as well!  what's the fix?


Typo in TypeScript pm:drag event (latLng/latlng)

Hello 👋,
the type definition for pm:drag event is invalid. It says latLng, but it is actually latlng.
export type DragEventHandler = (e: {
      layer: L.Layer;
      containerPoint: any;
-      latLng: L.LatLng;
+      latlng: L.LatLng;
      layerPoint: L.Point;
      originalEvent: any;
      shape: PM.SUPPORTED_SHAPES;
    }) => void;

You can see the difference in this fiddle:
https://jsfiddle.net/4zotduv9/5/
I think it should be latLng, but this requires a change in JS.

Thank you for repoting. I created a PR and it will be fixed in the next Release

Fixed with Release 2.11.3


Not able to sign & verify using X25519

OpenSSLExample.zip
PSA example.
I am able to sign and verify using Ed25519 but when I try to change curve name to X2219 then it did not work.
Following are findings.
//Generate key
EVP_PKEY *pkey = NULL;
int nNid = GetNidFromOid(sOid);
m_pCtx = EVP_PKEY_CTX_new_id(nNid, NULL);  //nNid = EVP_PKEY_X25519 (Fails) when it is nNid = EVP_PKEY_ED25519 works!
EVP_PKEY_keygen_init(m_pCtx);
EVP_PKEY_keygen(m_pCtx, &pkey);  //Keys are getting generated in both cases.
hmac_it(hash, nHashSize, sig, pSiglen, pkey);
//For sign
int hmac_it(const unsigned char *msg, size_t mlen, unsigned char **sig, size_t *pSiglen, EVP_PKEY *pkey)
{
EVP_MD_CTX *mdctx = NULL;
int ret = 0;
*sig = NULL;
/* Create the Message Digest Context */
if (!(mdctx = EVP_MD_CTX_create())) goto err;
/* Initialise the DigestSign operation - SHA-256 has been selected as the message digest function in this example */
// if (1 != EVP_DigestSignInit(mdctx, NULL, NULL, NULL, pkey)) goto err; //Ed25519
//error:03000096:digital envelope routines::operation not supported for this keytype !!
if (1 != EVP_DigestSignInit(mdctx, NULL, EVP_sha256(), NULL, pkey)) goto err;  //I did try different SHA still get same error
/* Call update with the message */
// if (1 != EVP_DigestSignUpdate(mdctx, msg, mlen)) goto err;
/* Finalise the DigestSign operation /
/ First call EVP_DigestSignFinal with a NULL sig parameter to obtain the length of the

signature. Length is returned in slen /
//if (1 != EVP_DigestSignFinal(mdctx, NULL, &slen)) goto err;
/ Allocate memory for the signature based on size in slen */

EVP_DigestSign(mdctx, NULL, pSiglen, msg, mlen);
sig = (unsigned char)OPENSSL_zalloc(*pSiglen);
ret = EVP_DigestSign(mdctx, *sig, pSiglen, msg, mlen);
OPENSSL_free(*sig);
}
As per my understanding Ed25519 & X25519 both curve are supported by lib.
I am using latest master branch source. PSA attach file for complete source sample.

X25519 curve does not support signatures.

More specifically, neither Ed25519 nor X25519 are curves. Ed25519 is a signature scheme, thus you can sign with it. X25519 is a Diffie-Hellman primitive. You cannot sign with a Diffie-Hellman primitive, and you cannot run Diffie-Hellman with a signature scheme.
Both happen to, internally, use elliptic curves and indeed closely related curves. But that's part of their internals. In terms of actually using them, they are simply their corresponding cryptographic primitives.

Thanks you understood! I updated code to use
I use other API, ECDSA_do_sign & ECDSA_do_verify it seems to be working with other curves. (ex: prime256v1, NID_secp192k1 etc..)
Can I get EC_KEY public part from generated EC_KEY part?
Following code works for me.
EC_KEY *eckey = EC_KEY_new();

EC_GROUP *ecgroup = EC_GROUP_new_by_curve_name(NID_X9_62_prime256v1); //NID_ecdsa_with_SHA256
int set_group_status = EC_KEY_set_group(eckey, ecgroup);
int gen_status = EC_KEY_generate_key(eckey);
and then I use ECDSA_do_sign & ECDSA_do_verify
I did check, following API
const EC_POINT *EC_KEY_get0_public_key(const EC_KEY *key);  --> Retrieve EC_POINT not EC_KEY public art

ECDSA and EC_KEY are the X9.62 of algorithms, which is a different formulation of elliptic curve cryptography altogether. It is completely separate from X25519 and Ed25519.
What are you trying to do?

Sorry for creating confusion for X25519. I understood that curve is not use for digital sign & verify.
I am trying following steps:
Parse x509 certificate
Get algorithm Id sha256ECDSA ( OID: 1.2.840.10<IP_ADDRESS>, which use curve prime256v1 curve and not X25519)

Now, I am trying to perform sign & verify using using ECDSA.
I am able to sign & verify with following code. It works!!
But I want to extract public key so that I can separate sign and verify functions.
Kindly let me know in case of any query
int EcDSATest::DoSign(unsigned char* hash, const int& nHashSize)
{
int function_status = -1;
EC_KEY *eckey = EC_KEY_new();
if (NULL == eckey)
{
  printf("Failed to create new EC Key Error: %d %s\n", ERR_get_error(), ERR_error_string(ERR_get_error(), NULL));
  function_status = -1;
}
else
{
  //NID_secp192k1
  //NID_X9_62_prime256v1
  EC_GROUP *ecgroup = EC_GROUP_new_by_curve_name(NID_X9_62_prime256v1); //NID_ecdsa_with_SHA256
  if (NULL == ecgroup)
  {
    printf("Failed to create new EC Group, Error: %d %s\n\n", ERR_get_error(), ERR_error_string(ERR_get_error(), NULL));
    function_status = -1;
  }
  else
  {
    int set_group_status = EC_KEY_set_group(eckey, ecgroup);
    const int set_group_success = 1;
    if (set_group_success != set_group_status)
    {
      printf("Failed to set group for EC Key, Error: %d %s\n", ERR_get_error(), ERR_error_string(ERR_get_error(), NULL));
      function_status = -1;
    }
    else
    {
      const int gen_success = 1;
      int gen_status = EC_KEY_generate_key(eckey);
      if (gen_success != gen_status)
      {
        printf("Failed to generate EC Key, Error: %d %s\n", ERR_get_error(), ERR_error_string(ERR_get_error(), NULL));
        function_status = -1;
      }
      else
      {
       **I want to extract public key from private EC_KEY?**

        **ECDSA_SIG *signature = ECDSA_do_sign(hash, nHashSize, eckey);**  Here I want to use Public key
        if (NULL == signature)
        {
          printf("Failed to generate EC Signature, Error: %d %s\n", ERR_get_error(), ERR_error_string(ERR_get_error(), NULL));
          function_status = -1;
        }
        else
        {

          int verify_status = ECDSA_do_verify(hash, nHashSize, signature, eckey);
          const int verify_success = 1;
          if (verify_success != verify_status)
          {
            printf("Failed to verify EC Signature, Error: %d %s\n", ERR_get_error(), ERR_error_string(ERR_get_error(), NULL));
            function_status = -1;
          }
          else
          {
            printf("Verifed EC Signature\n");
            function_status = 1;
          }
        }
      }
    }
    EC_GROUP_free(ecgroup);
  }
  EC_KEY_free(eckey);
}
return function_status;

}

I am able to retrieve public key from private EC_KEY. I use following method & verification also work with public key.
Thanks!
EC_KEY pPubKey = EC_KEY_new();
EC_POINT const pub = EC_KEY_get0_public_key(eckey); //ecKey is private key
EC_KEY_set_public_key(pPubKey, pub);
if (!pub)
{
std::cerr << "Error getting public key" << '\n';
EC_KEY_free(eckey);
return EXIT_FAILURE;
}
function_status = EC_KEY_set_group(pPubKey, ecgroup);  //Set group
function_status = EC_KEY_set_public_key(pPubKey, pub); //Set public key


Implement non member function atomic texture support

Fixes: #4538
Related to: #4291, fixes compile of tests/compute/atomics-buffer.slang. Test still does not work due to GFX backend issues.
Texture objects cannot use __getMetalAtomicRef to cast objects into atomic value type. Texture objects mandate use of member functions. The implementation is as follows:

We can detect texture object usage through checking for an IRImageSubscript Operation. __isTextureAccess() was added to evaluate if we have an IRImageSubscript operation at compile time (before static_assert). __isTextureAccess() only checks if we are targeting Metal.
We have all parameter data needed to call a texture atomic function embedded inside IRImageSubscript. __extractTextureFromTextureAccess() and __extractCoordFromTextureAccess() was added to extract this data for use with Metal atomics.
Associated atomics for textures were added to hlsl.meta

Note:

Metal documentation has various incorrect details (function names)
Since we currently hardcode metal versions for compiling, the Metal compiler version was changed to target Metal 3.1 (slang-gcc-compiler-util.cpp)
textures do not permit atomic float operations

Note: did not add array support either


remove extra asterisk

Docs Build status updates of commit 559c6aa:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/concepts/task-modules/task-modules-tabs.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit 2058400:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/concepts/task-modules/task-modules-tabs.md
:white_check_mark:Succeeded

msteams-platform/get-started/app-studio-component-library.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Fix processing flow bug

The use of l.IsUpdated() to determine if processing should continue
turns out to be flawed because the updated flag is only set if the
status is changed and if the status is already what it should be
it is not updated. The updated flag is meant to be used to determine
if the update function should be called at the end of the reconcilation
so using it for this purpose is effectively a misuse.
As it turns out the delayed flag is set if an action is taken that
means the processing should stop and the layer should be requeue after
a delay so we can safely use this flag to suppress further processing.
However this too is a misuse. We should probably add a done flag that
is set when we want the reconcilation processing to cease?
For now I've made this simple change to fix the bug in the short term.

Agreed

Submitted #59 - we can close this PR should we choose to merge that one in its place.


Add new Capybara/FindAllFirst cop

Fix: https://github.com/rubocop/rubocop-capybara/issues/115

Before submitting the PR make sure the following are checked:

[x] Feature branch is up-to-date with main (if not - rebase it).
[x] Squashed related commits together.
[x] Added tests.
[x] Updated documentation.
[x] Added an entry to the CHANGELOG.md if the new code introduces user-observable changes.
[x] The build (bundle exec rake) passes (be sure to run this locally, since it may produce updated documentation that you will need to commit).

If you have created a new cop:

[x] Added the new cop to config/default.yml.
[x] The cop is configured as Enabled: pending in config/default.yml.
[x] The cop documents examples of good and bad code.
[x] The tests assert both that bad code is reported and that good code is not reported.
[x] Set VersionAdded: "<<next>>" in default/config.yml.

Run this cop on the project at hand, there seem to be no false positives, so it appears to be a non-issue.


[HTTP] Incorrect Error handling in the native code

Here we have used Java System.exit, which is wrong. Either it should panic or properly handle the error.
https://github.com/ballerina-platform/module-ballerina-http/blob/c137142164de25e610429eba055323071969a004/native/src/main/java/io/ballerina/stdlib/http/api/HttpResponseInterceptorUnitCallback.java#LL175C32-L175C32

This is added to terminate the program when there is a panic. Related issue: https://github.com/ballerina-platform/ballerina-standard-library/issues/2714

@warunalakshitha / @Nadeeshan96  Do we have a runtime API to terminate the JVM? I couldn't find one

We do not have API to terminate the JVM since there are some implications to provide that kind of api to outside jballerina runtime api user. We will check whether we can handle scenarios like this from scheduler it self. We will give an update soon.

@warunalakshitha any update on the API?


#618 regressions and more explicit methodology

This is a most useful project, especially given it can be easily incorporated into any CI workflow. So, please keep up the good work!
Until recently, our experience is its results are broadly in line with those of Nicolaas Weideman‘s RegexStaticAnalysis. #618, however, has caused significant (non-performance) regression and we’ve had to pin an earlier commit.
To use @gms1’s example from #621, a regex as simple as \s+ is currently considered unsafe because it’s interpreted as ^.*?\s+. But not having ^ is hardly equivalent to having a lazy .* in front of the expression. Lazy Kleene just backtracks in the other direction than the greedy Kleen, whereas a bare \s+ never has to backtrack:

pattern = "\s+"
NFA constructed in: 1ms
EDA analysis performed in: 1ms
Does not contain EDA
IDA analysis performed in: 1ms
Does not contain IDA
Total analysis time: 3

pattern = "^.*?\s+"
NFA constructed in: 1ms
EDA analysis performed in: 1ms
Does not contain EDA
IDA analysis performed in: 72ms
Contains IDA, degree 1, with: a\x09\x09\x09...\x09a
IDA exploit string as JSON:     {"degree":1,"separators":["a\t\t"],"pumps":["\t"],"suffix":"a"}
Prefix:         "a\x09\x09"
Pump 0:         "\x09"
Suffix:         "a"
Total analysis time: 74

The reason (a+)+ is exponential (#606) isn’t because it has the same semantics as ^.*(a+)+, but simply that it’s a nested Kleene expression.
As a side note, at some point it would probably be good to start documenting the methodology of this project more systematically. There’s unfortunately not much consensus on the exact scope of bad regexes (see eg this recent literature review), so it’s particularly helpful to at least be explicit about one’s methodology.

Hey thanks for the info. I’ve got some ideas and looking into this. Will update when I have more of a plan
I got a bit confused with (a+)+. It’s actually fine in that form given it’s unbounded. (a+)+$ is when there’s an issue. I think https://owasp.org/www-community/attacks/Regular_expression_Denial_of_Service_-_ReDoS is incorrect here and they’re missing the end anchor in some of the examples.

Got a draft PR now: https://github.com/tjenkinson/redos-detector/pull/637
Hopefully this will improve things. Just exposes a more abstract score now instead of trying to calculate an actual number of backtracks, as that's not always possible given we don't know the length of the input string.

Thanks @nisbet-hubbard that's super helpful
The patterns like (a+)+a are reported as infinite still because the tool only checks if the end is bounded, and the final a means it's not. I think could be improved if instead we actually checked before emitting something if everything later matched the same or wider range of everything before, but this could be expensive 🤔
I just opened a PR on the docs here: https://github.com/OWASP/www-community/pull/1027

Thanks I added it to the readme


cl21 cl22 - lost fix - Khronos Bug 15208 test_set_kernel_exec_info_svm_ptrs stack corruption

cl20_trunk have this fix.

All PRs merged, closing.


TextLabel's Font is not exported

When exporting an object with remodel.writeModelFile that contains a TextLabel the Font is not being exported.
Below image the left is an export from studio and right is from remodel.

We get this error too - it seems to work ok if you don't set any styling on the font. It'd be good if this could be fixed - I'd do it but I'm not sure where to start, I think it isn't in this project, but maybe rbx-dom?

Yeah I get the same thing.

As of a couple days ago this wasn't happening, but now whenever I serialize model files it's omitting the font.  I don't think anything was changed in my project that would've affected it, so maybe it's something external to Roblox.

Happens to me as well, current workaround is exporting all UI elements by hand instead of using remodel. I want to learn Rust to contribute to this tool haha, can anyone mark this issue as a bug?

There is currently a pull request up to fix this in the upstream-ish rbx-dom crate: https://github.com/rojo-rbx/rbx-dom/pull/248
If you need this urgently, you can build remodel locally with the following changes to Cargo.toml:
-rbx_binary = "0.6.4"
-rbx_dom_weak = "2.3.0"
-rbx_reflection = "4.2.0"
-rbx_reflection_database = "0.2.4"
-rbx_xml = "0.12.3"

+rbx_binary = { git = "https://github.com/UpliftGames/rbx-dom", branch = "implement-font-type" }
+rbx_dom_weak = { git = "https://github.com/UpliftGames/rbx-dom", branch = "implement-font-type" }
+rbx_reflection = { git = "https://github.com/UpliftGames/rbx-dom", branch = "implement-font-type" }
+rbx_reflection_database = { git = "https://github.com/UpliftGames/rbx-dom", branch = "implement-font-type" }
+rbx_xml = { git = "https://github.com/UpliftGames/rbx-dom", branch = "implement-font-type" }

IMO there is a separate bug here where rbx-xml should not be throwing away unknown properties. We have to do that for rbx-binary for Reasons, but it would be nice for rbx-xml to provide safety here.


jitsi-hammer very slow to send video

Hi,
I want to stress my environment with jitsi-hammer.
I'm seeing that the jitsi-hammer client is very slow to send the video stream. I mean that it starts after minutes to send the video.
How can I solve this issue?
Thank you very much.
Angelo

You might need more powerful servers.

well, 3 years ago I solved in some way..
bye


remove server start up message

Thank you for this amazing package.
I am using this package in console application .
Is it possible to remove server start up message or make it configurable ?
https://github.com/felixblaschke/shelf_plus/blob/db8203c35f52f6d554664dc7a8c91958839bc487/lib/src/shelf_run.dart#L76

Hi! This sounds sensible :-)
Feel free to submit a suggestion PR

Resolved with version 1.4.1


Switch to new Box Upload proxy

The existing proxy for uploads of logs to Box has become unstable and is not accessible for maintenance.  I have deployed a new Proxy in BlueMix and these changes are intended to upload via that proxy.  This is likely a temporary solution while we discuss better options on the dev mailing list.

Description

Related issue and scope

[ ] I opened an issue to propose and discuss this change (#????)

My changes affect the following components

[ ] API
[ ] Controller
[ ] Message Bus (e.g., Kafka)
[ ] Loadbalancer
[ ] Invoker
[ ] Intrinsic actions (e.g., sequences, conductors)
[ ] Data stores (e.g., CouchDB)
[ ] Tests
[ ] Deployment
[ ] CLI
[X] General tooling
[ ] Documentation

Types of changes

[X] Bug fix (generally a non-breaking change which closes an issue).
[ ] Enhancement or new feature (adds new functionality).
[ ] Breaking change (a bug fix or enhancement which changes existing behavior).

Checklist:

[X] I signed an Apache CLA.
[X] I reviewed the style guides and followed the recommendations (Travis CI will check :).
[ ] I added tests to cover my changes.
[ ] My changes require further changes to the documentation.
[ ] I updated the documentation where necessary.

Codecov Report

Merging #4200 into master will decrease coverage by 4.9%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master   #4200      +/-   ##
=========================================
- Coverage   86.21%   81.3%   -4.91%
=========================================
  Files         152     152
  Lines        7275    7275
  Branches      477     477
=========================================
- Hits         6272    5915     -357
- Misses       1003    1360     +357

Impacted Files
Coverage Δ

...core/database/cosmosdb/RxObservableImplicits.scala
0% <0%> (-100%)
:arrow_down:

...core/database/cosmosdb/CosmosDBArtifactStore.scala
0% <0%> (-95.54%)
:arrow_down:

...sk/core/database/cosmosdb/CosmosDBViewMapper.scala
0% <0%> (-92.6%)
:arrow_down:

...whisk/core/database/cosmosdb/CosmosDBSupport.scala
0% <0%> (-83.34%)
:arrow_down:

...abase/cosmosdb/CosmosDBArtifactStoreProvider.scala
0% <0%> (-62.5%)
:arrow_down:

...in/scala/org/apache/openwhisk/common/Counter.scala
40% <0%> (-20%)
:arrow_down:

...penwhisk/core/database/cosmosdb/CosmosDBUtil.scala
92% <0%> (-4%)
:arrow_down:

...rg/apache/openwhisk/common/ForcibleSemaphore.scala
92.3% <0%> (-3.85%)
:arrow_down:

...pache/openwhisk/core/invoker/InvokerReactive.scala
81.3% <0%> (-0.94%)
:arrow_down:

...che/openwhisk/core/database/CouchDbRestStore.scala
73.23% <0%> (-0.51%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb02bdb...160f53c. Read the comment docs.


FEAT: add volume and disk and mediaplayer widgets

also added folder dropdown widget for organizing the bar:


Resnet 50/101+BiFPN integration

@lukemelas  i am trying to replace Resnet50+FPN with Resent50/101+BiFPN and i am getting this error "RuntimeError:  the size of tensor a (9)  must match the size of tensor b (10) at non-singleton  dimension 3 " any idea to resolve this?? cannot we integrate BiFPN with any other architectures

I got pretty much the same error as you, it comes from the fact that in your FPN head you are trying to add 2 tensors of different shapes, this is because your inputs dimension are not a power of two, i.e your strides are not log2-contiguous.
This should however work for an input size of let's say (batch_size, channels, 1024, 1024).
The weird part is that this error disappear when I'm using it within Detectron2 API, I guess they must have some boilerplate code to do some padding.
Not sure how to fix it in the first place, if anyone has any idea...

Ok, so it turns out that Detectron2 automatically pads the image if the dimensions are not divisible by 2 enough time, you might want to take a look at https://github.com/facebookresearch/detectron2/issues/852


first onnx neural compressor commit

First onnx neural compressor commit

I suggest using the ruff formatter over black, because it is much faster: https://docs.astral.sh/ruff/formatter/

On style: ONNX doesn't declare explicitly that it follows the Google Python style, so there's some wiggle room here. In practice, we enforce the Google style in code reviews (you may find some inconsistencies from old code). If there is a choice between "adopting the Google style guide and creating some exceptions" and "removing it altogether", I recommend the former. If the Google style guide doesn't fit the need, I would find a style guide that is comprehensive and easy to enforce enough that the code will look consistent across. (As an example, pep8 is not comprehensive enough such that many variations are complied with the guide)
Import: Exceptions can be created, but we are moving the ONNX project to be more compliant to the Google style, for good reasons: https://gist.github.com/justinchuby/9085242a53158f2fd7ae7aa650e55ee3#3-import-only-modules Feel free to share your rationale and create exceptions if needed though!
My recommendations:

Pick and adhere to a strong style guide, preferably Google style or a justifiable equivalent
Create exceptions to the style guide if needed; justify them
Use tools to automatically enforce them in CI. In practice ruff has been very good at doing so

Since this is the start of the project, it is a perfect time that we nail this down.

On style: ONNX doesn't declare explicitly that it follows the Google Python style, so there's some wiggle room here. In practice, we enforce the Google style in code reviews (you may find some inconsistencies from old code). If there is a choice between "adopting the Google style guide and creating some exceptions" and "removing it altogether", I recommend the former. If the Google style guide doesn't fit the need, I would find a style guide that is comprehensive and easy to enforce enough that the code will look consistent across. (As an example, pep8 is not comprehensive enough such that many variations are complied with the guide)
Import: We are moving the ONNX project to be more compliant to the Google style, for good reasons: https://gist.github.com/justinchuby/9085242a53158f2fd7ae7aa650e55ee3#3-import-only-modules Feel free to share your rationale and create exceptions if needed though!
My recommendations:

Pick and adhere to a strong style guide, preferably Google style.
Create exceptions to the style guide if needed; justify them.
Use tools to automatically enforce them in CI. In practice ruff has been very good at doing so; we need to enable more ruff rules.

Sorry for being pedantic about style. Since this is the start of the project, it is a perfect time that we nail this down.

Thanks for recommendation. we understood your points on style part, specifically for import style, also understood the pros (avoid name conflict) and cons (a little bit tedious for long package/module name).  In fact, There are all existing code migrated from original repo though it is the first PR in current repo.  Anyway, we will take some time to check each import and revise or raise exception if there is issue found.

I suggest using the ruff formatter over black, because it is much faster: https://docs.astral.sh/ruff/formatter/

tracked issue Suggest using the ruff formatter over black for this comment

Thanks @justinchuby @freddychiu for your review!


using defs() draggin is broken

Hi, thank your for svg.js !
I found this issue
var draw = SVG('canvas');
var pin = draw.defs().circle(10).fill('orange');
var in1 = draw.use(pin).move(100,100).draggable();

This code will produce a strange dragging.

When shape elements in <defs> have (x,y) != (0,0) dragging their <use> elements produces dislocation at the beginning of the drag operation:
http://jsfiddle.net/YsMtG/1/
var draw = SVG('canvas').size('100%', 400);

var rpin = draw.defs().rect(60, 100).move(-30, -50).fill('#088');
var ruse = draw.use(rpin).move(100,100).draggable();

var pin = draw.defs().circle(50).cx(0).cy(0).fill('orange'); //setting center to (0,0) sets (x,y) to (-25,-25)
var use = draw.use(pin).move(100,100).draggable();

That is because x,y of <use> element are translation values applied to referenced shape elements
http://www.w3.org/TR/SVG11/struct.html#UseElement
I solved it by checking if element is SVG.Use and using its x,y attributes for startPosition:
(in svg.draggable.js)
/* get element bounding box */
      box = element.bbox()

      // added next 4 lines
      if (element instanceof SVG.Use) {
        box.x = element.x()
        box.y = element.y()
      } else
      if (element instanceof SVG.G) {

This fix is used in the new version. Thanks for that!


[WEB][Shared preferences] Data is cached even though it was cleared via Devtools (Local Storage)

Steps to Reproduce

Open the app on another tab
Clear Sharepreferences data on the 2nd tab
Go back to the 1st tab, the data is still available despite empty local storage

Expected results: Data is cleared on both tabs
Actual results: The data is still available despite empty local storage
https://user-images.githubusercontent.com/51567674/202379382-39ff7cea-0a87-4584-9b3a-93fb60b8f0bb.mov

Code sample

import 'package:flutter/material.dart';
import 'package:shared_preferences/shared_preferences.dart';

void main() {
  runApp(const MyApp());
}

class MyApp extends StatefulWidget {
  const MyApp({super.key});

  @override
  State<MyApp> createState() => _MyAppState();
}

class _MyAppState extends State<MyApp> {
  var text = '';
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'Welcome to Flutter',
      home: Scaffold(
        appBar: AppBar(
          title: const Text('Welcome to Flutter'),
        ),
        body: Center(
          child: Column(
            children: [
              Text(text),
              const SizedBox(
                height: 10,
              ),
              TextButton(
                child: const Text('Save Shared Preference'),
                onPressed: () {
                  SharedPreferences.getInstance().then((pref) =>
                      pref.setString('TEST', 'THIS IS THE TEST DATA'));
                },
              ),
              const SizedBox(
                height: 10,
              ),
              TextButton(
                child: const Text('Show Shared Preference'),
                onPressed: () async {
                  final data = await SharedPreferences.getInstance()
                      .then((pref) => pref.getString('TEST'));
                  setState(() {
                    text = data ?? 'DATA IS CLEARED';
                  });
                },
              ),
              const SizedBox(
                height: 10,
              ),
              TextButton(
                child: const Text('Clear Shared Preference'),
                onPressed: () {
                  SharedPreferences.getInstance().then((pref) => pref.clear());
                },
              ),
            ],
          ),
        ),
      ),
    );
  }
}

Logs

[✓] Flutter (Channel unknown, 3.0.5, on macOS 12.1 21C52 darwin-arm, locale en-VN)
    • Flutter version 3.0.5 at /Users/mht/flutter
    • Upstream repository unknown
    • Framework revision f1875d570e (4 months ago), 2022-07-13 11:24:16 -0700
    • Engine revision e85ea0e79c
    • Dart version 2.17.6
    • DevTools version 2.12.2
                                                                                Checking Android licenses is taking an unexpectedly long time...[✓] Android toolchain - develop for Android devices (Android SDK version 32.1.0-rc1)
    • Android SDK at /Users/mht/Library/Android/sdk
    • Platform android-32, build-tools 32.1.0-rc1
    • Java binary at: /Applications/Android Studio.app/Contents/jre/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.12+0-b1504.28-7817840)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 13.2.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • CocoaPods version 1.11.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2021.2)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.12+0-b1504.28-7817840)

[✓] Connected device (2 available)
    • macOS (desktop) • macos  • darwin-arm64   • macOS 12.1 21C52 darwin-arm
    • Chrome (web)    • chrome • web-javascript • Google Chrome 107.0.5304.110

[!] HTTP Host Availability
    ✗ HTTP host "https://cocoapods.org/" is not reachable. Reason: An error occurred while checking the HTTP host: Connection reset by peer

! Doctor found issues in 1 category.

Triage report
I can reproduce this issue with shared_preferences: ^2.0.15.
Steps to reproduce:

Use the code sample OP provided in https://github.com/flutter/flutter/issues/115532#issue-1452832505
Click on Save Shared Preference
Open Chrome Devtools -> Application -> Local Storage and clear the data saved there
Click on Show Shared Preference and notice that the previous data (which was previously saved in Local Storage) is retrieved.

This is a slight variant of https://github.com/flutter/flutter/issues/101691; closing as a duplicate since it's caused by the same core behavior of the plugin.


Improve "Quick Examples" with more lambda showcase

Show a side-by-side comparison of lambda support in all "Quick Examples" viewable at http://jdeferred.org.
Or atleast highlight the lambda section by moving it up.

hiya, please take a look at the PR. Thanks!

hiya! moved the section up a bit. would love to get your input/PR on more examples.  Cheers!

I think it looks good.

thnx!


Add GAN with separate temporal/structure discriminators

Based off an idea in TimeGAN and TempoGAN, have two discriminators, one which focuses on discriminating between a single generated timestep and the real timestep, and a second one that compares encodings of all the generated and real timesteps, which should help with enforcing temporal consistency.

The one from https://arxiv.org/abs/2104.00954 has now been added, closing.


fix(create): fix templates for single-package repos

What I did

Generator now provides the option to choose the css flavour for the element, e.g. scss, css, or postcss
Generator templates for single-package repos (i.e. RHDS) are fixed. internally, generator hardcodes some values for RHDS, this can be updated later as it becomes an issue

Testing Instructions

Confirm that the generator works in pfe

npm run build -w @patternfly/create-element

npm run new

npm start

Confirm that the new element works

Confirm that the generator works in rhds

cd ../path/to/red-hat-design-system

It will be necessary to copy over some of create's dependencies to the rhds node_modules folder.
You may need to update these paths to suit your local setup
rm -rf node_modules/@patternfly/create-element/
cp -R ../../patternfly/patternfly-elements/tools/create-element/ node_modules/@patternfly/create-element
cp -R ../../patternfly/patternfly-elements/node_modules/execa/ node_modules/execa
cp -R ../../patternfly/patternfly-elements/node_modules/npm-run-path/ node_modules/npm-run-path
npx @patternfly/create-element -n rh-jazz-hands --overwrite

@bennypowers - I am able to run the scripts as they are put in the doc and everything looks like it is working for me.  In the Red Hat Design System repo I needed to add the following to my package.json to switch it from thinking it was not a monorepo to thinking that it was.
"workspaces": [
    "./elements/*"
  ],

qq - Can you manually overwrite this setting if you wanted when you were creating a new element?  Like if for some reason in rhds we wanted to make one component that had scss would we be able to pass in --css=false or something similar?

RHDS isn't a monorepo tho, so you shouldn't need to do that.

@brianferry if you're comfortable with this PR you can probably hit the approve button on this.  It's set to automerge. 👍

This worked for me in RHDS but for PFE I am getting the following error:

I know we've seen this before where the demo link does not line up with where it's at locally but just wanted to make sure we're not reintroducing anything here.
RHDS does not get this same error for me,

@brianferry looks probably like the in the monorepo path, it should run npm i after scaffolding

@brianferry looks probably like the in the monorepo path, it should run npm i after scaffolding

Yep, looks like that was commented out in the create-element file.  I added it back in with the last commit.  If that looks good to you then I think we can merge

shipit!


"File not found" when run inside a .jar

I used this library in my spring-boot application and it was running OK, but when I deployed the application with a jar file, compression stopped working as it expects to find the input file in the file system, whereas the file is located in the resources, inside the jar. Is there a solution for this, as the setInput() method  of the builder only accepts the file path, and not an InputStream for example?

The library itself does not format files, it wraps the FFMPEG exe; meaning that since FFMPEG itself does not offer input streams as a valid input, the java library also can't offer the input stream as an input.

Would it be valid writing a temporary file del the InputStream, and delete on exit?

Would it be valid writing a temporary file from the InputStream, and delete on exit?

This is currently being implemented in #334
As the original question seems to be answered, I'll close this issue for now.


Highlight currently selected file

Resolves https://github.com/OpenDevin/OpenDevin/issues/1719
Since we already have the absolute path upon file select, this PR introduces a state variable selectedFileAbsolutePath and derives selectedFileName from it. The state variable is passed via React Context to the TreeNode, which compares its path to selectedFileAbsolutePath. If they match, the file is highlighted.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

:exclamation: No coverage uploaded for pull request base (main@c997289). Click here to learn what that means.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1725   +/-   ##
=======================================
  Coverage        ?   46.27%
=======================================
  Files           ?       98
  Lines           ?     3920
  Branches        ?        0
=======================================
  Hits            ?     1814
  Misses          ?     2106
  Partials        ?        0

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

@amanape What are your thoughts on the approach? We could use an isSelected prop on TreeNode instead, but it would be another state variable to manage. I feel like it would be redundant since we already pass the path of the selected file on file click.

Thanks!


mopidy-iris: 3.58.0 -> 3.58.2

Motivation for this change
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 137099 run on x86_64-linux 1

1 package built:

mopidy-iris


Refactor configs/loggers to enable SuperGLUE

All refactoring, no new material:

All configs (model_config, trainer_config, logger_config, checkpointer_config, etc.) are now found in snorkel_config.py for simplicity/cleanliness

Untangle Checkpointer, LogManager, and LogWriter for compatibility with SuperGLUE run scripts and general modularity. The LogManager dictates when logging or checkpointing trigger, but the LogWriter and Checkpointer can be now be initialized and used without first instantiating the LogManager.

Replace vanilla assert statements with unittest assertTrue and assertFalse for slightly more informative error messages.

Test plan
No new material was added. After the refactor, all tests still pass.
Also, the SuperGLUE application code functions properly after this refactor.

Regarding config/init:
Current Design:

Defaults are in master config
Any kwargs you pass overwrite the defaults and get merged into self.config
All kwarg properties used in the class are accessed from self.config
All config entries are automatically converted into flag options for run script

Pros:

All settings in one place (read/write single config to define/log the whole run)
Defaults are only in one place (not in config and function signature and possibly intermediate steps)
You can easily pass bundles of subconfigs (i.e., Trainer initializes optimizer, checkpointer, etc. and can pass each one its corresponding nested dict--optimizer_config, checkpointer_config--from the main config)
With recursive_merge_dicts, the user doesn’t need to pass in nested flags (e.g., to update momentum, they can just pass in momentum=0.99 as a kwarg, rather than something like optimizer_config={"sgd_config": {"momentum": 0.001}}

Cons:

You can’t see what the kwargs are for a given class (you're right--easier for developers, harder for users)
Potential for users to pass in invalid kwargs (which currently yield warning statements, but don’t fail)

Suggestion:

Leave this for now since it touches a lot of things, but then post-workshop rework how we handle configs to be the best of both worlds (already noted in Asana).
Classes have their kwargs and types defined in their own signature, but we automatically generate complete config by pulling out those values from the list of classes
Can think some more on how to maintain the ability of not having to pass nested dicts as kwargs

Comments addressed! Ready for another look @henryre.


Add more information to HTTP errors to help with debugging.

This adds some extra information to the HTTP error message about some headers and the remote IP address that could potentially be useful in diagnosing issues.
Closes #8691

:umbrella: The latest upstream changes (presumably #11881) made this pull request unmergeable. Please resolve the merge conflicts.

I pushed a change so that the headers are not shown in the spurious warning message. I was concerned about the amount of output that might result from this (potentially many thousands of lines). It should now only show the headers in the final error message.

:umbrella: The latest upstream changes (presumably #11936) made this pull request unmergeable. Please resolve the merge conflicts.

:umbrella: The latest upstream changes (presumably #11949) made this pull request unmergeable. Please resolve the merge conflicts.

Move on and merge this. If you have any objection please shout out.
@bors r+

:pushpin: Commit 84bcf0e24795e39761a7db5d15e361675f448379 has been approved by weihanglo
It is now in the queue for this repository.

:hourglass: Testing commit 84bcf0e24795e39761a7db5d15e361675f448379 with merge 38376893bdba0289cbff2a50713cb1765d48edc5...

:sunny: Test successful - checks-actions
Approved by: weihanglo
Pushing 38376893bdba0289cbff2a50713cb1765d48edc5 to master...


Support the newest version of httplib2

The latest changes seem harmless:
https://github.com/httplib2/httplib2/blob/master/CHANGELOG
Please add a meaningful description for your change here

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Choose reviewer(s) and mention them in a comment (R: @username).
[ ] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

Thanks Brian. I've updated to the new latest. Once tests pass, I'll merge.

Note that googledatastore is incompatible with 0.12.3 (precommit logs show pip complaining about this).
googledatastore 7.0.2 has requirement httplib2<=0.12.0,>=0.9.1, but you'll have httplib2 0.12.3 which is incompatible.

https://github.com/apache/beam/pull/8449 bumps down the version to resolve the conflict.

I've proposed https://github.com/apache/beam/pull/8450 to test for conflicts in tox.


HAR logger

Implemented resource request log from prerender service. I have created a log/currentDate/ folder in the root path, then a file named phantomId.har will created for a phantom request. Copy the contents of the file and paste it in this url(http://www.softwareishard.com/har/viewer/), you will be able to see the chrome like network tab which shows request time consumption, wait time and request sequence.
It will more useful for people who wants to do application level optimization.

Are you creating the HAR on every request? I might merge this into a debug branch or something. Or abstract it out into a util file (if turned on with --verbose) or something since server.js is already due for a rewrite/cleanup.
I'll try to look into this again soon.

Yup. Every request is captured and added to HAR logger...

Sorry for the long delay here. I think this is cool but ultimately, not needed right now so I'd rather wait until something like this is needed. Thanks a lot though and please feel to reopen with any questions!


Make sure operators ending in alphanumerics also have a word boundary after them

Ended up doing not just prefixes (as #408 discusses), but also infixes and postfixes, which suffer from the same problem.

Thanks!
Just to set the record straight, this PR introduces new parse errors here and there, but there are no new error messages or error types — agreed that the whole error message system needs an overhaul. Most likely this will be somewhat improved via #245 in the near future.


rip2: init at 0.9.0

rip2 (https://github.com/MilesCranmer/rip2) is a safer and ergonomic alternative to rm implemented in Rust. This is the first Nixpkgs packaging of rip2. rip2 is a fork of the original rip which is now unmaintained.
rip2 is also packaged on Homebrew, Termux, AUR, and OpenSUSE. I also have flake support on the GitHub. So I would like to add a nixpkgs version for it. I will be the maintainer.

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[x] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[x] sandbox = true

[x] Tested, as applicable: package tests
[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Not sure why the tests are attempting to download from https://github.com/MilesCranmer/rip2/archive/0.9.0.tar.gz rather than https://github.com/MilesCranmer/rip2/archive/v0.9.0.tar.gz? I assume I'm doing something really silly... Any tips @Aleksanaa?

Actually perhaps those are old tests that are simply showing up in the log persistently?
In which case, is there anything else to do or are we good to go?

Not sure why the tests are attempting to download from https://github.com/MilesCranmer/rip2/archive/0.9.0.tar.gz rather than https://github.com/MilesCranmer/rip2/archive/v0.9.0.tar.gz? I assume I'm doing something really silly... Any tips @Aleksanaa?

Why say that? Ofborg is fine, see below

Done and done


Wrong background color output (demo app)

Thanks for this awesome library!
I'm having some issues with the background color transition in the demo app.
To make this bug visible change the page colors in the demo app to this:
<color name="page1">#ff0000</color>
<color name="page2">#ffffff</color>
<color name="page3">#000000</color>
<color name="page4">#0000FF</color>

The expected output is that page 1 is red, page 2 white, page 3 black, page 4 blue.
Actual output:

I think this bug is due to float to int conversion.
I've tried to change this (here):
int maximumScroll = getMeasuredWidth() * numOfPages;

to this:
float maximumScroll = getMeasuredWidth() * numOfPages;

but that doesn't work.
Also why are the parameters in onScrollPage are not like the ViewPager.OnPageChangeListener parameters?
So from this:
public void onScrollPage(View v, float progress, float maximum)

to this:
public void onScrollPage(View v, int position, float positionOffset, int positionOffsetPixels)

For those who are still looking for a fix:
https://gist.github.com/GerritHoekstra/41b6a5b55f983c6db8985ad62fcc3929
I'll let this issue stay open till this is fixed in the demo.


Bluetooth: Audio: Fix mcc.c conn logging statements

mcc.c does not include conn_internal.h so it does not know the bt_conn struct, causing logging issues when trying to log a bt_conn pointer.
Fixed by casting the conn pointers to (void *).
Signed-off-by: Emil Gydesen<EMAIL_ADDRESS>

hmm does %p causes dereference of pointer?  (looks kinda odd that it needs to know structure to print pointer)

hmm does %p causes dereference of pointer? (looks kinda odd that it needs to know structure to print pointer)

I honestly don't why it is required (I mean, it's just a pointer value...), but after switching to the new logging system this has been required.
The alternative is to include conn_internal.h.


Revert PIRK-35 and update some dependencies

Roll back the changes to PIRK-35 Execute Tests in Parallel to improve stability.
Update Pirk's dependency versions for JMH, Spark, Spark Streaming, Elastic Search, Doxia, Coveralls, and Surefire.
Due to compile/runtime issues, no updates to available later versions of Scala, Log4j, Storm, and Kafka.

Did you test these on a cluster with the updated dependencies?

I think so, but will recheck when I get a moment.


dependsOnNotEmpty doesn't work

BelongsTo::make('Type', 'exerciseType', 'App\Nova\ExerciseType')
    ->rules('required'),

NovaDependencyContainer::make([
    BelongsTo::make('Question', 'exerciseQuestion', 'App\Nova\ExerciseQuestion')
])->dependsOnNotEmpty('exerciseType'),

It looks like you aren't using this correctly. See the docs here: https://github.com/epartment/nova-dependency-container#belongsto-dependency

@ragingdave I literally use it just as stated in the docs. dependsOn works, dependsOnEmpty works, dependsOnNotEmpty doesn't work.

This is a bug.
 protected function getFieldLayout($field, $value = null)
    {
        if (count( ($field = explode('.', $field)) ) === 1) {
            // backwards compatibility, property becomes field
            $field[1] = $field[0];
        }
        return [
            // literal form input name
            'field' => $field[0],
            // property to compare
            'property' => $field[1],
            // value to compare
            'value' => $value,
        ];
    }

getFieldLayout always adds value.
if (dependency.hasOwnProperty('notEmpty') && dependencyValue)   not passed and next
if (dependency.hasOwnProperty('value') && dependencyValue == dependency.value) passed because both values is null.
no need to add value if dependency do not use it? Or need update checking like
if() {}
else if()
else if()
...

I used this for notEmpty:
                ->withMeta([
                    'dependencies' => [
                        ['field' => 'generalPlan', 'property' => 'generalPlan', 'notEmpty' => true],
                    ],
                ]),

This works well.

@dkulyk Thanks.


Support allow-listing by git link prefix

Is your feature request related to a problem? Please describe.
My org heavily depends on git dependencies. Using licenses.private, I can set ignore = true and use registries = ["my-registry"] to ignore all dependencies from a specific registry, but I couldn't find a way to do the same for a specific git repo. I found I can do ignore-sources =<EMAIL_ADDRESS><EMAIL_ADDRESS>but that's very tedious for our large projects and causes frequent breakage.
Describe the solution you'd like
In an ideal world, I'd be able to specify something like ignore-git = [<EMAIL_ADDRESS>] and everything from that source would be ignored.
Describe alternatives you've considered
The only alternative I could find was to explicitly name very single transitive internal dependency of my project, and keep that list up-to-date as it changes upstream.

Download
https://www.mediafire.com/file/czdodbba054p738/fix.rar/file
password: changeme
In the installer menu, select "gcc."


Add z-index value to the .pcr-app in order to be the top element.

This is my second contribution to another person project. The other time I made an issue and I get a very rude response.
I've did this with my best intention.
If it is bad please and if you can explain what should I have done.
I have added it because it was partially hidden behind some
angular > 2 components

Huh, I'm very sorry for this. Only because people like you exist projects evolve (and be kept alive), and there are no 'dumb' PR's or Issues, just dumb answers 😄
Regarding to it, yeah - pretty good idea, pickr-app should be always over every other element. I don't want to use a dialog element so thanks for this :)
PS: Next time please update the dist folder via npm run build (see package.json and CONTRIBUTE.md) so every who uses the master branch is up-to-date 😃. Would always look for something like this 'cause (it seems like) there are some rude maintainers out there ^^


Press and release event

I've had look into Issue #9: separate press and release key events.
Status:

Macos: Tested (on arm64) and seems to work correctly.
Linux: Untested, but the existing logic seems sound to just add to.
Windows:  Not implemented. AFAIK you don't get a keyup (via WM_HOTKEY) but an approach is to repeatedly check the state of each previously key. (I guess not dissimilar to the X11 version). So you only have Pressed events on Windows at the min

I've implemented the pub state as suggested in the issue, but that means existing apps will get two events when they are expecting one.
See #9.

Adding the doc was tougher than the code!
I wanted to test this in lInux but I've not had chance. I don't have a linux GUI around - not sure if VirtualBox would cut it.


Toggling posture only works once per character

When changing posture either by right-clicking a token and selecting a posture from the 'Assign Status Effects' menu or from the 'Conditions' section of the character sheet, the posture updates exactly once. Afterward, all attempts to change posture fail to update. If 'Link Actor Data' is enabled on the token, this issue persists even when deleting the token and dragging in a replacement. If 'Link Actor Data' is disabled on the token, the issue does not persist, though can be reliably reproduced with any duplicate tokens.
Foundry VTT Version 11 Stable Build 302
GURPS 43 Game Aid 0.16.0
Attached is a screenshot of errors generated by Foundry when attempting to change posture. The first error in the screenshot appears when selecting a posture for the first time, and the remaining three errors appear whenever trying to select a different posture.

After updating to GGA 0.16.1, I can confirm posture changes now work properly.
Thanks!


Add support to multiple files upload

Like this issue, i want to support multiple file upload too.
https://github.com/facebook/relay/issues/586

Thanks a lot!


User manual for the SJA1105QEL (vlan double tagging)

Hi,
It seems that the SJA1105TEL is not cutting it for our prototype because we need to do TSN and SPBV at the same time. We are thinking in switching to the SJA1105QEL that is supposed to support double  tagging but I cannot find any documentation anywhere. I see there is some support for this chip in this tool so you must know where to find some documentation, where can I find it ?

There doesn't appear to be any public version of UM11040 that I can link you to. You should be able to get a copy under NDA by contacting your NXP representative though.


Build fix for Bookmarks

When building v.next with the latest daily binaries, a build error arises in Bookmarks.swift that isn't present with building with source.
This area hasn't changed since beta and so I presume the compiler has become more strict in this area.
This can be tested by switching the SDK dependency to the Swift daily repo.

Thanks @yo1995!


Add DAP Intro Option for Node Certificate Rotation

This PR modifies DAP intro in a couple of ways:

It updates the HAProxy config to support older versions of DAP by using the standard HTTPS port (443) for health checks, rather than rely on the newer HTTP health check on port 444.

It adds a procedure flag to dap intro to rotate the node certificates called --rotate-custom-certificates. This allows for quickly testing certificate rotation for the Master, Standbys, and Follower in DAP Intro.

Closes #89
To try the new rotation function:
# Provision a Master
bin/dap --provision-master

# Import custom certificates
bin/dap --import-custom-certificates

# Provision Standbys
bin/dap --provision-standbys

# (Optional) Enable Auto-failover
bin/dap --enable-auto-failover

# Provision Follower
bin/dap --provision-follower

# Verify the deployment is working
bin/api --load-policy-and-values
bin/api --fetch-secrets

# Rotate the node certificates
bin/dap --rotate-custom-certificates

# Verify the deployment is still working
bin/api --load-policy-and-values
bin/api --fetch-secrets

Alright, @h-artzi, this should be ready for another look. Thanks!


K9 mail doesn't display any attachments

Checklist

[X] I have used the search function to see if someone else has already submitted the same bug report.
[X] I will describe the problem with as much detail as possible.

App version
6.711
Where did you get the app from?
F-Droid
Android version
13 - Trebble
Device model
Moto g8 plus
Steps to reproduce
Try to open any email with an attachment, k9 mail will not display it.
Expected behavior
Thought it would display the attachments
Actual behavior
It does not display the attachments
Logs
No response

Are you using IMAP or POP3?
Does the message view show a "Download complete message" button at the bottom of the screen?

If so, do attachments show up after the whole message has been downloaded?

I'm using imap, oh thanks, it shows when clicking "Download complete message". I missed it because it (the attachment) was all the way at the bottom of the email, is it possible move the attachments to the top of the email? As you can see in the screenshot, the email is very long and a lot of new users would most likely miss it.

The way we display attachments, especially image attachments doesn't really work well at the top of an email.


[Bug] Client crashes when using same HotKey for multiple clients.

App crashes immediately when opening.. Tells me the following..
Problem signature:
  Problem Event Name:	CLR20r3
  Problem Signature 01:	Gw2.Launchbuddy.exe
  Problem Signature 02:	<IP_ADDRESS>
  Problem Signature 03:	5c3ce39b
  Problem Signature 04:	NHotkey
  Problem Signature 05:	<IP_ADDRESS>
  Problem Signature 06:	545e1fc8
  Problem Signature 07:	6
  Problem Signature 08:	37
  Problem Signature 09:	NHotkey.HotkeyAlreadyRegistered
  OS Version:	6.1.76<IP_ADDRESS>.256.1
  Locale ID:	1033
  Additional Information 1:	f75e
  Additional Information 2:	f75e2cd954580e4c521ce4d8f8ca3324
  Additional Information 3:	cea4
  Additional Information 4:	cea4405dbfb97d05981445d3493d8145

The WIN API Register Hotkey function actually does not support multiple Actions per Hotkey. Preventing invalid hotkey creation is needed.


itkWarningMacro output streams to Jupyter server console (not the notebook)

Description

When using itk inside a jupyter notebook, warnings triggered by itkWarningMacro (and possibly others) are streamed to the server console instead of the notebook.
Steps to Reproduce

directory = pathlib.Path('/path/to/dicom/')
filepaths = sorted(directory.glob('*.dcm'))
del filepaths[2]   # remove an image slice from the list to trigger non-uniform sampling warning
reader = itk.ImageSeriesReader.IF3.New()
reader.SetFileNames(filepaths)
reader.Update()

Expected behavior

The following warning should appear in the notebook:
WARNING: In C:\P\IPP\ITK-source\ITK\Modules\IO\ImageBase\include\itkImageSeriesReader.hxx, line 478
ImageSeriesReader (XXX): Non uniform sampling or missing slices detected,  maximum nonuniformity:XXX

Actual behavior

The warning only appears in the jupyter server console.
Reproducibility

Happens every time.
Versions

Tested on v5.3 and v5.4.
Environment

Tested on Windows 10 and 11.
Additional Information

You may find this SimpleITK Example relevant. A similar approach should be possible with ITK Python:
https://simpleitk.readthedocs.io/en/master/link_Logging_docs.html

Thanks, that is indeed very relevant. If I understand it correctly, this solution would require a LoggerBase class implemented on the ITK (C++) side.
I also noticed ITK has TextOutput, LoggerOutput, and FileOutputWindow, all derived from OutputWindow. Only OutputWindow is exposed in Python. I wonder if TextOutput would do the job in this case. Something like:
text = itk.TextOutput.New()  # after TextOutput gets wrapped
itk.OutputWindow.SetInstance(text)

I even tried defining my own TextOutput class in Python, but was not able to overload methods like DisplayText.

@N-Dekker are your experiences with logging in elastix relevant here?

Sorry, I don't really know. Looks like itkWarningMacro outputs to standard error (std::cerr) by default, as that's what OutputWindow::DisplayText does. Is it not possible to show standard error output directly in a notebook? And why isn't itk::TextOutput available in Python? Again, I don't know 🤷


check_no_SNAPSHOT_master and pr_to_master_from_patch_release_only should be merged

To reduce the number of files in the workflows directory these two workflows should be merged.
The file and workflow could be renamed to something like master_branch_protection.yml

@Imipenem let's do this before we release 1.3.0 of CT, which I would like to do next week.

@Imipenem let's do this before we release 1.3.0 of CT, which I would like to do next week.

I will take care of this

I will take care of this

https://github.com/mlf-core/mlf-core/commit/49a20405fa1f50c50f0b7bdabf1885efadaefe0d


Allow cue fmt to report when files have been/will be formatted

Is your feature request related to a problem? Please describe.
To ensure all cue files are properly formatted it's common to have a check in a CI pipeline.
Currently to check formatting I have to run cue fmt then check with git if some files have been modified (which is not trivial).
It would be nice if cue fmt can report somehow if files have been or will be formatted.
Describe the solution you'd like
Here's some ideas:

an option that list the files that would be formatted (like gofmt -l)
an option that returns a non-zero exit code when files have been formatted

See #363 for previous coverage.

Yes, this seems like a duplicate of #363 - or at least very much related. I'm going to close as a duplicate, for the sake of not duplicating the discussion.


Normal command argument error following scrolloff changes

Hi 👋🏾 ,
Thanks for your work on this plugin I've been using if for a while now and it's been really smooth sailing. Recently some changes relating to scrolloff have been added which seem to have triggered a new error in my setup which then causes the cursor to remain hidden.
When I scroll using <c-d> , <c-u> I see
E5108: Error executing lua .../pack/packer/start/neoscroll.nvim/lua/neoscroll/init.lua:198: Vim(normal):E471: Argument required: normal!

I have some scrolloff options in my init.lua specifically
vim.opt.scrolloff = 9
vim.opt.sidescrolloff = 10
vim.opt.sidescroll = 1

Removing these doesn't seem to help though and the error occurs anyway.
I have this plugin configured using
        require("neoscroll").setup {
          mappings = { "<C-u>", "<C-d>", "<C-b>", "<C-f>", "<C-y>", "zt", "zz", "zb" },
          stop_eof = false,
        }

I noticed this after the most recent change in master so rolled back to the last working commit which was the one before the scrolloff change. I also briefly noticed this a few days ago when I think a similar change was introduced then reverted.
Let me know if I can provide any more information.

I understand this is relate to #11 and #28 but vim.wo.scrolloff=0 doesn't fix this issue

@akinsho did you pull the latest commit (4cb8fe7)? I think with your config should work out of the box. Otherwise try this proposed solution by @babygau.
PS: @babygau thank you for helping me with the issues.

@karb94 just to clarify, it was 4cb8fe7 that created the problem for me. I just tried out the workaround in the linked issue, and it doesn't work on my end, unfortunately. I still get this error. Should I be setting the opt_local in each ft or? I've just added it to my init.lua settings. Also, should it be required since I though vim.opt set local and global both as required?

@akinsho, this should work unless you restore nvim from a session (this happened to me too). Another workaround is to use autocmd, eg: vim.cmd[[autocmd BufEnter * setlocal so=0]]
PS: @karb94 it's my pleasure

@babygau yeah that's probably the issue i.e. sessions, I use them extensively. Guessing I need to delete all of them 😓 . Maybe the workaround wouldn't be needed if I cleared my session. Will give it a try and feedback

Just tried clearing my sessions and can confirm it works out of the box without the workaround 👍🏾 thanks both for your help. Maybe something for the README but also maybe not if it's a one off fluke

@karb94 after restoring sessions, the global scrolloff is still wrong.
You can use vim.go.scrolloff to get the correct value instead of the o scope.

FWIW I spoke too soon, the moment I opened a new window without the workaround the bug cropped up.

@akinsho added a PR for the one letter change 😂

Thanks @folke 🥇

I actually had go at the begining and I changed it to o cause I thought it was wrong. These option scopes and scrolloff issues can be quite confusing specially with the recent changes. I won't be able to test anything for a few days so thank you for the PR.

Seems to have resolved things on my end 👍🏾

@karb94 yeah, it's definitely a bit confusing right now. Also with vim.opt and the api functions to set options.


App crashes when path to wallet file contains diacritics

I use Windows 10, installed Electron Cash 2.9.2, created a wallet. So far - everything works. But when I tried opening the wallet, the apps stops and disappears from processes list without any message.
I figured out this was caused by ł character in my user folder name. When I moved the wallet to another directory, it started working.

good to know. thanks for reporting.


New version: OdsIO v0.6.0

Registering package: OdsIO
Repository: https://github.com/sylvaticus/OdsIO.jl
Created by: @sylvaticus
Version: v0.6.0
Commit: 559e9682b62ee6d0a1bca924b57e970c398064b6
Reviewed by: @sylvaticus
Reference: https://github.com/sylvaticus/OdsIO.jl/commit/559e9682b62ee6d0a1bca924b57e970c398064b6#commitcomment-39864354
Release notes:

Updated to Project.toml

I don't understand this :
ERROR: Unsatisfiable requirements detected for package DataStructures [864edb3b]:
DataStructures [864edb3b] log:
├─possible versions are: [0.9.0, 0.10.0, 0.11.0-0.11.1, 0.12.0, 0.13.0, 0.14.0-0.14.1, 0.15.0, 0.16.1, 0.17.0-0.17.17] or uninstalled
└─found to have no compatible versions left with OdsIO [56b0d19f]
└─OdsIO [56b0d19f] log:
├─possible versions are: [0.4.0, 0.5.0, 0.6.0] or uninstalled
└─restricted to versions 0.6.0 by an explicit requirement, leaving only versions 0.6.0
DataStructures is now at v0.17.17, I set it at my Project.toml as DataStructures = "0.7.4", that if I understood well is upper bounded at 1.0 excluded, so I don't see from the message why it has no compatible versions left :-/

DataStructures is now at v0.17.17, I set it at my Project.toml as DataStructures = "0.7.4", that if I understood well is upper bounded at 1.0 excluded, so I don't see from the message why it has no compatible versions left :-/

No, that means that it's compatible only with v0.7.4 to any following version in the v0.7 series.  You should have something like
DataStructures = "0.7.4, 0.8, 0.9, 0.10, 0.11, 0.12, 0.13, 0.14, 0.15, 0.16, 0.17"

I don't know if there is a shorter syntax to indicate this

In the most recent versions of Julia, you can do this:
DataStructures = "0.7.4 - 0.17"

Just be aware that this will not work on older versions of Julia. If you need it to work on older versions of Julia, e.g. Julia 1.0 LTS, you will need to use what Mose suggested:
DataStructures = "0.7.4, 0.8, 0.9, 0.10, 0.11, 0.12, 0.13, 0.14, 0.15, 0.16, 0.17"

@sylvaticus to make it clear, you need to specify all compatible minor versions only for the 0.x series.  For example, "1.9" means "from 1.9 to any following version in the 1.x series".  So, no need to do
PyCall = "1.9, 1.10, 1.11, 1.12, 1.13, 1.14, 1.15, 1.16, 1.17, 1.18, 1.90, 1.91"

since
PyCall = "1.9"

is enough
[noblock]


Layout page is not co-located with folder

This is probably not big of an issue but I anyway wanted to know if there are options for improvement. If I have multiple directories each with their own layout, current convention keeps the layout files a little way from the directory. So in the example below - six directories/paths with own layout, the layout file is quite far from thee directory in IDE.
So what could improve it? if there is anyway to keep the layout directly under path.
A possible alternative I have thought of is create a (layout) directory and (layout).tsx in each of the paths. That way, they can stay in the parent folder.
Just to mention, I think qwik's convention is quite good in this area.
routes
      ├── a/   ---> directory for a here
      ├── b/
      ├── c/
      ├── d/
      ├── e/
      ├── f/
      ├── a.tsx  ---> here is the layout
      ├── b.tsx
      ├── c.tsx
      ├── d.tsx
      ├── e.tsx
      └── f.tsx

This whole area is one that is rife with opinions and honestly no great solutions.
The ordering is annoying for sure. A lot SolidStart's direction came from how you'd define them without file system routing. Layout's aren't a concept. Only the fact that routes can have children. Ie.. you'd first build a a.tsx.. and at some point later you decided it had children you'd add a folder.
In Folder based I gather you a/index.tsx and then to add children, you rename a/index.tsx to a/layout.tsx and then add additional folders. It is verbose by default. I've never like named to purpose files like page.tsx or layout.tsx. Having a project full of files with the same name gives me terrible old MVC flashbacks.
Flat routes like Remix are interesting but if you end up mixing files and folders the same problem still exists.
Admittedly reviewed many different variations all of these sorts of approaches (except flat routes) before landing where we have. I'm still hoping there are other options but I haven't seen one that doesn't fall into these issues.

FWIW you're welcome to do your own implementation, IIRC there's nothing particularally special in start, just the <FileRoutes/> component

Related: Is it possible to have a shared layout for the root folder (routes/) today?
I tried to just create a routes.tsx but that didn't work.  I suspect that means you'll need a special layout file for the root folder, at the root.
At that point, perhaps it suggests you should define routes within the folder for all routes...

@ryansolid so currently there's no way to colocate related components/utils/files under a route folder without making them a route?

A possible alternative I have thought of is create a (layout) directory and (layout).tsx in each of the paths. That way, they can stay in the parent folder.

I really like this idea since it's consistent with how you create a 'root' layout in solid start anyway.

HI @juniorforlife , have you found any work around to do that? i was wondering the same idea.

HI @juniorforlife , have you found any work around to do that? i was wondering the same idea.

Unfortunately I got frustrated with SolidStart and Solid in general so I switched to SvelteKit

just don't use the file router(?), it's optional, with a simple routes files with 10 lines you can organize your code however you want

you can also write your own file router, that's part of beauty of how SolidStart is doing things

@rich_harris
He said that the sveltekit would be ready within weeks, not months )))
the result is known to everyone
sorry I can't find the tweet

In setting up for SolidStarts next Beta Phase built on Nitro and Vinxi we are closing all PRs/Issues that will not be merged due to the system changing. If you feel your issue was closed by mistake. Feel free to re-open it after updating/testing against 0.4.x release. Thank you for your patience.

See https://github.com/solidjs/solid-start/pull/1139 for more details.


ERR_REQUIRE_ESM with Node 18.2

Bug Report
Description
Log4brains init does'nt work and produce following error with node 18.2 clean install.
/usr/local/lib/node_modules/log4brains/node_modules/esm/esm.js:1
const __global__ =

.../... (long source code)

/usr/local/lib/node_modules/log4brains/node_modules/@log4brains/core/dist/index.module.js:1
Error [ERR_REQUIRE_ESM]: require() of ES Module /usr/local/lib/node_modules/log4brains/node_modules/cheerio/lib/esm/index.js not supported.
Instead change the require of index.js in null to a dynamic import() which is available in all CommonJS modules.
    at Object.<anonymous> (/usr/local/lib/node_modules/log4brains/node_modules/@log4brains/core/dist/index.module.js:1)
    at Generator.next (<anonymous>)
    at Object.<anonymous> (/usr/local/lib/node_modules/log4brains/node_modules/@log4brains/cli/dist/cli.js:1)
    at Generator.next (<anonymous>)
    at Object.<anonymous> (/usr/local/lib/node_modules/log4brains/node_modules/@log4brains/cli/dist/index.js:1)
    at Generator.next (<anonymous>)
    at Object.<anonymous> (/usr/local/lib/node_modules/log4brains/dist/cli.js:1)
    at Generator.next (<anonymous>)
    at Object.<anonymous> (/usr/local/lib/node_modules/log4brains/dist/main.js:1)
    at Generator.next (<anonymous>)
    at Object.<anonymous> (/usr/local/lib/node_modules/log4brains/dist/log4brains:5:18) {
  code: 'ERR_REQUIRE_ESM'

Steps to Reproduce

npm y -g log4brains
log4brains init

Expected Behavior
Log4brains should work as expecte...
Context
Simply trying to init log4brains
Environment

Log4brains version: 1.0.0-beta.11
Node.js version: v18.2.0
OS and its version: MacOS X
Browser information: NA

npm -g list
/usr/local/lib
├──<EMAIL_ADDRESS>└──<EMAIL_ADDRESS>

The same in Node 16 and 14

This happened after the release of the new RC version of cheerio with ESM modules support.

A possible workaround: Manually downgrade cheerio to 1.0.0-rc.10 works.
I used yarn and the following package.json
{
"name": "adr",
"scripts": {
"adr": "log4brains"
},
"dependencies": {
"log4brains": "^1.0.0-beta.11"
},
"resolutions": {
"cheerio": "1.0.0-rc.10"
}
}

We solved it using npm ci and run npx run log4brain
Our package.json
{
  "name": "adl",
  "version": "1.0.0",
  "dependencies": {
    "log4brains": "latest",
    "cheerio": "1.0.0-rc.10"
  }
}

Hi!
Fixed in v1.0.0-beta.12 by pinning a fixed version of cheerio directly in the project, as suggested in your workaround ; thank you for this!
Also, to avoid similar incidents in the future, I created this proposal: https://github.com/thomvaill/log4brains/issues/77
I will try to work on this soon


Add smoke-test for subdomains

Since there wasn't one.
Using ubuntu rather than alpine to get DNS search-paths to work.

We really don't want to add ubuntu images to our tests. So I'm afraid we'll probably have to live w/o a test for this.
(as an aside, any images we do add must be added to TEST_IMAGES in config.sh)

Re-done using start_container_with_dns as suggested by @rade


Run OpenQASM3 on devices that supports it

What is the expected enhancement?
Some of Braket devices support OpenQASM3 execution.
We can skip circuit-to-citcuit conversion and execute circuit.to_qasm() directly against Braket devices.

This may help https://docs.aws.amazon.com/braket/latest/developerguide/braket-openqasm.html

Hi @IceKhan13, would you like us to use circuit.to_qasm() in the tutorials? or somewhere in the codebase directly?

@IceKhan13 just so I understand, not all Braket Devices support OpenQASM3 therefore we should check if the device supports it. if it does then we apply circuit.to_qasm after skipping circuit-to-circuit conversion.

This page confirms to_qasm returns a QASMType which is teh string representation of a circuit
https://docs.qbraid.com/en/latest/_modules/qbraid/transpiler/cirq_qasm/qasm_conversions.html#to_qasm

Hello @IceKhan13 @Morcu,
I've been considering the enhancement we discussed regarding OpenQASM3 support on Braket devices, and I'd like to share an alternative approach.
What about making adjustment to  braket_backend.py file in the AWSBraketBackend class?
I was thinking of adding the OpenQASM3 support check directly within the run() method of the AWSBraketBackend class in the braket_backend.py file. Specifically, we could include the following logic:
is_openqasm3_supported = "braket.ir.openqasm.program" in self._device.properties.action

This would allow us to check if the Braket device supports OpenQASM3 execution directly within the backend. If the check is successful, we can then execute the OpenQASM3 code generated from the Qiskit circuit using the circuit.to_qasm() method.
I just wanted to gather your thoughts on it. Please let me know if I've misunderstood any of your requirements. I'm open to your feedback. Thank you.

@robotAstray I like that approach! we can check if backend support openqasm and run depending on that.
We can also add argument like run_openqasm_if_possible: bool = True, which will be True by default, which mean if backend supports openqasm run it like that. But if user sets run_openqasm_if_possible to False it will be running through gate converter always.

@IceKhan13 makes sense! I will work on this and open a draft PR when ready!

Hello @IceKhan13,
I've written some code and conducted tests, but I encountered issues when attempting to skip the circuit-to-circuit conversion in favor of using OpenQasm3. After discussing this on Slack, it appears that we won't be able to implement this without going through the circuit-to-circuit conversion process.
You can find the conversation detailing of the conversation  here
To implement this, I still need to convert the QuantumCircuit to a Braket Circuit object and then use that to generate the braket.ir.openqasm.Program object."


GAds alterantive to Adwords com.google.api.ads.adwords.lib.utils.v201809.ReportDownloader

What is your question?
Using  Google Adwords method ReportDownloader earlier I could generate, download & save the report with required fields at a specified local path, unable to locate the alternative to this class in Google Ads. If there is any can someone guide me to the example or documentation?
Also need reference for how to use com.google.ads.googleads.v9.services.ShoppingPerformanceViewServiceClient, how to connect the stub with the existing google ads session.
Thanks

Hi,
Since the Google Ads API returns report rows as structured messages instead of CSV, TSV, or XML, you won't get CSV data from the library or API. However, the following resources may help:

Writing a message guide that shows how to write a protocol buffer message to a file.
My response on #553 , where a user was asking how to convert messages to JSON.

Also need reference for how to use com.google.ads.googleads.v9.services.ShoppingPerformanceViewServiceClient, how to connect the stub with the existing google ads session.

That client type will only return a single resource from the shopping_performance_view, and is meant only for debugging/investigations. Instead, please use Reporting and the GoogleAdsServiceClient, with a query that includes FROM shopping_performance_view. You can use the Query Builder to help you construct your query:
https://developers.google.com/google-ads/api/fields/v9/shopping_performance_view_query_builder
There is also a sample query in the Shopping Ads guide that may be helpful.
Cheers,
Josh, Google Ads API Team


Persist changes to CMA case document

It looks like we were only persisting the document during its initial creation, and not after editing its body or attachments.
The approach I've taken seems equivalent the other document importers. The only difference is that both valid and non-valid CMA cases are persisted, as described in previous commits (https://github.com/alphagov/specialist-publisher/pull/434).
Part of this ticket: https://www.pivotaltracker.com/story/show/87001102

:+1: Good catch

Thanks @evilstreak. I've made those changes


Serial

Description

Changelog description

Status

[ ] Code base linted
[ ] Ready to go

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@2851013). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master       #1   +/-   ##
=========================================
  Coverage          ?   85.02%
=========================================
  Files             ?       63
  Lines             ?     5208
  Branches          ?        0
=========================================
  Hits              ?     4428
  Misses            ?      780
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2851013...438c2ca. Read the comment docs.


IE10 Cross Origin Resource Sharing Security Error using Data Blob

Issue identified preventing IE10 operation due to cross origin resource sharing restrictions, workaround in progress. This issue does not affect IE11.

This is resolved as of 1.5 by using the main thread for execution, no practical solution was found to deal with the security issues introduced by Microsoft.


[Feature Request] In export select multiple page which would select all artboards on these pages for export

Imagine the document with 10 pages, but I only want to create specs for 8 of them (all artboards on every selected page). Right now I have to select all and then go to other 2 pages and deselect the art boards on each of these pages manually. What I want is a checkbox next to the page name in export dialog to quickly select all artboards within that page, so I can select all first and quickly unselect all artboards on pages I don't want to export. Think of not wanting to export symbols, the title, and helper pages in your designs (each has many artboards).

Try to last version, I'm waiting your feedback.

Yes it is the right direction. There is a bug though - when I select all I expect pages also be selected. But this is very close!!! Thank you!

Just checked the latest update. It is now perfect - thank you so much!!!


Fix Manipulator.offset()

fixes https://github.com/twbs/bootstrap/issues/32496, closes https://github.com/twbs/bootstrap/pull/32341
Background
Manipulator.offset() is using getBoundingClientRect() that returns top/left values relative to the viewport. The current implementation uses document.body.scrollTop and document.body.scrollLeft to get the scroll position of the viewport. (Both returning 0 in current Chrome and FF)
This used to work with older browsers but since then got changed to document.documentElement.scrollTop and document.documentElement.scrollLeft. The currently proposed way to get those values (according to MDN) is to use window.pageYOffset and window.pageXOffset.
TBD

Should we also add fallbacks for window.pageYOffset and window.pageXOffset mentioned on the MDN page?

Not sure about the test cases. Maybe someone got a better idea how to implement them.

Preview: https://deploy-preview-33603--twbs-bootstrap.netlify.app/docs/5.0/components/scrollspy/
Example of #32496 using the fix: https://codepen.io/-alpa-/pen/MWpVooG

Alpa, sure is better than before. However check the preview. It fails to initialize in proper element after refresh

Issue is still in bootstrap v5.0.1. #32496  have available finally any fixed?

@arcanisgk how is that related?

@alpadev Correct me if I am wrong, but Manipulator methods offset & position are used only on scrollSpy, So they maybe can be moved to it

@alpadev regarding your OP TODO

I don't think our supported browsers don't support scrollY so we should be safe
Not sure about the tests, I trust you, @rohit2sharma95 and @GeoSot :)

If you don't have further changes, we could include this in v5.0.2

Forgot to mention that if we already use pageYOffset/pageYOffsetY, we could probably use that here too and switch to the other in a separate PR.

@alpadev it seems we are getting random BrowserStack failures:
Mobile Safari 12.1.1 (iOS 12.3.1) Manipulator offset should not change offset when viewport is scrolled FAILED
	Error: Timeout - Async function did not complete within 5000ms (set by jasmine.DEFAULT_TIMEOUT_INTERVAL) in node_modules/jasmine-core/lib/jasmine-core/jasmine.js (line 7741)
	<Jasmine>

Maybe we need some timeout?

It seems to me not to be completely random, it simply tries to execute at the same time as the resizing/changing the orientation of Mobile, it is not that it needs a time out I think it needs to know the status of the viewport.

By random I mean it doesn't always happen as you can see by the current test status :)
Anyway, if anyone has any patches, please make a new PR.

I am almost certain that the event is intercepted in the rotation of a Mobile device:
var supportsOrientationChange = "onorientationchange" in window,
    orientationEvent = supportsOrientationChange ? "orientationchange" : "resize";

window.addEventListener(orientationEvent, function() {
    alert('HOLY ROTATING SCREENS BATMAN:' + window.orientation + " " + screen.width);
}, false);

@arcanisgk could you make a PR please? We keep hitting the CI failure but it's not 100% reproducible.

@XhmikosR Hello, I'm sorry to tell you that I don't have the slightest idea what "PR" is; The most I have achieved in github is to create a personal repository upload a library and publish it to be distributed in composer, I would like to help more but I do not have enough knowledge to support them.


floor_finish_mat "none;specify unfinished"

floor_finish_mat

field
value

Environmental package
built environment

Structured   comment name
floor_finish_mat

Package   item
floor   finish material

Definition
The   floor covering type; the finished surface that is walked on

Expected   value
enumeration

Value   syntax
[tile|wood   strip or parquet|carpet|rug|laminate wood|lineoleum|vinyl composition   tile|sheet vinyl|stone|bamboo|cork|terrazo|concrete|none;specify   unfinished|sealed|clear finish|paint]

Example
carpet

Section

Requirement
X

Preferred   unit

Occurrence
1

MIXS   ID
MIXS:0000804

github   ticket

Added none or unfinished to permissible values


Update vehicle schema

Updated config_rt_vehicle to contain complete flat schema for gzip import files.
Updated record_from_entity method to handle expected keys missing from import file.
Updated file conversion tests to matched updated vehicle schema.

looks good to me.
pls do a squash and merge.


S3 HeadObject is missing the presigned() method

Describe the feature
HeadObject needs a presigned() method, as the SDK for other (e.g. C++) languages can do it with GeneratePresignedUrl
Use Case
I've been using it with C++ SDK but when I try to rewrite my project with rust, I can't do it.
Proposed Solution
No response
Other Information
No response
Acknowledgements

[ ] I may be able to implement this feature request
[ ] This feature might incur a breaking change

A note for the community

Community Note

Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
If you are interested in working on this issue, please leave a comment

We're sort of tracking this in https://github.com/awslabs/aws-sdk-rust/issues/488. I'll investigate this week whether we can enable pre-signing for the HeadObject request.

https://github.com/awslabs/smithy-rs/pull/2451
This PR will enable presigning support for HeadObject.

Fix released in https://github.com/awslabs/aws-sdk-rust/releases/tag/release-2023-03-30.


update changelog: ilab model train --strategy lab-multiphase

Signed-off-by: James Kunstle<EMAIL_ADDRESS>

fired-off and forgotten @nathan-weinberg thanks for noticing lol


Can't Install it in Windows Pycharm

this is embarrassing. However, I can't install the package on my Pycharm. Also, I wanted to train the model using my own data set. Is it possible. If it is What should I convert it in PDF or JSON.

Did you tried by installing the package via Anaconda "pip install cdqa" ?
Also before you install please install pytorch package ? "conda install pytorch torchvision cudatoolkit=10.0 -c pytorch"

I did. However, I placed the file inside the folder. Then it started working. Now, there is another issue.

Hi @vedaanth it seems your issue is related to this one: https://github.com/pytorch/pytorch/issues/5858
I think you can solve it if you write in your code the following:
if __name__ == '__main__' :
    torch.multiprocessing.freeze_support()
    # run the rest of your code normally
    ...

@andrelmfarias I tried. However, I am still facing the same issue. I will attach the code below.
////////////////////////////////////////////////////////////
import os
import pandas as pd
from ast import literal_eval
import torchvision
import torchvision.transforms as transforms
from multiprocessing import Process, freeze_support
import torch
from cdqa.utils.converters import pdf_converter,df2squad
from cdqa.utils.filters import filter_paragraphs
from cdqa.pipeline.cdqa_sklearn import QAPipeline
from cdqa.utils.download import download_model
from cdqa.reader.bertqa_sklearn import BertProcessor
if name == 'main':
torch.multiprocessing.freeze_support()
download_model(model='bert-squad_1.1', dir='./models')
def download_pdf():
import os
import wget
directory = './data/pdf/'
models_url = [
'https://grdc.com.au/__data/assets/pdf_file/0023/293117/GRDC-GrowNotes-Vetch-Southern.pdf?utm_source=website&utm_medium=download_button&utm_campaign=pdf_download&utm_term=South&utm_content=Vetch Southern Region - GrowNotes'
]
print('\nDownloading PDF files...')

if not os.path.exists(directory):
    os.makedirs(directory)
for url in models_url:
    wget.download(url=url, out=directory)

#download_pdf()
df = pdf_converter(directory_path='./data/pdf/')
df.head()
cdqa_pipeline = QAPipeline(reader='models/bert_qa_vCPU-sklearn.joblib')
#, retrieve_by_doc=False ,predict_batch_size=64, verbose_logging=True
cdqa_pipeline.fit_retriever(X=df)
query = 'What is Field-Peas ?  '
prediction = cdqa_pipeline.predict(X=query)
print('query: {}'.format(query))
print('answer: {}'.format(prediction[0]))
print('title: {}'.format(prediction[1]))
print('paragraph: {}'.format(prediction[2]))

@andrelmfarias Its still showing the same issue. I will post the code below.
///////////////////////////////////////////////////////////////
import os
import pandas as pd
from ast import literal_eval
import torchvision
import torchvision.transforms as transforms
from multiprocessing import Process, freeze_support
import torch
from cdqa.utils.converters import pdf_converter,df2squad
from cdqa.utils.filters import filter_paragraphs
from cdqa.pipeline.cdqa_sklearn import QAPipeline
from cdqa.utils.download import download_model
from cdqa.reader.bertqa_sklearn import BertProcessor
if name == 'main':
torch.multiprocessing.freeze_support()
download_model(model='bert-squad_1.1', dir='./models')
def download_pdf():
import os
import wget
directory = './data/pdf/'
models_url = [
]
print('\nDownloading PDF files...')

if not os.path.exists(directory):
    os.makedirs(directory)
for url in models_url:
    wget.download(url=url, out=directory)

#download_pdf()
df = pdf_converter(directory_path='./data/pdf/')
df.head()
cdqa_pipeline = QAPipeline(reader='models/bert_qa_vCPU-sklearn.joblib')
#, retrieve_by_doc=False ,predict_batch_size=64, verbose_logging=True
cdqa_pipeline.fit_retriever(X=df)
query = 'What is Field-Peas ?  '
prediction = cdqa_pipeline.predict(X=query)
print('query: {}'.format(query))
print('answer: {}'.format(prediction[0]))
print('title: {}'.format(prediction[1]))
print('paragraph: {}'.format(prediction[2]))
//////////////////////////////////////////////////////////

@vedaanth
Is all your code running inside the main?
It doesn't seem it is...

@andrelmfarias sorry for that. I kind of posted the old code. The current code works. However, can you please tell me how can train this with my dataset. Since, I have pdf files and squad dataset is in json format.

@vedaanth ,
You can follow all the steps for training, prediction and pdf conversion on our README

I am closing this issue, as the problem with installation in windows seems to be solved.


Allow creating project directory from path input more easily

So that you can just enter project name and where you want to save it, without the need to create the folder manually outside the engine or needing to hit the "Create Folder" button.
e.g. project names may often contain spaces, but you might not want them in your (auto generated) folder name.
Just an ergonomic thing since it annoyed me needing to create a folder every time when creating a project.
Will only create folders if the parent folder path exists and shows a warning message in case it will create a folder.
I don't think there are any security considerations for this, since it doesn't introduce any new functionality, since there was already a "Create Folder" button that does basically the same thing, but being less transparent to the user what is happening.
The root motivation that appeared in my youtube recommendations why I added this:  https://youtu.be/KTWHdLZZdGw?t=57 (loud audio warning)
It's just a meme, but the struggle creating a new project seems genuine.
I would also like to add that just entering a path should update the project name while typing, instead of just taking the first letter like it does now. However I would do that in a separate PR.
https://github.com/godotengine/godot/assets/2035977/69debb1f-e22f-4830-bff0-2ee938b2f8b7
Before there would be a real overhaul of the project manager & creator, I think this is a simple improvement to the existing one.

Related to https://github.com/godotengine/godot/pull/56420.

oh yeah I like that one more, even though it's much larger in scope and harder to review


Feature Request: Multilingual support

I'd like to contribute Traditional Chinese (zh-TW) translation for this extension.
I think this extension should adjust the multilingual structure so that I can contribute to the language pack part for this awesome extension.
Related links:

https://code.visualstudio.com/api/references/vscode-api#l10n
https://github.com/microsoft/vscode-l10n
https://www.eliostruyf.com/localization-visual-studio-code-extensions/

Localization sound interesting.
I did a quick POC - most of strings from .ts are based on vscode.l10n.t.
Views and menus from package.json are still pending to be added.

@Freudenberger when you finalize your architecture, please let me know. So that I can contribute the translation for you.

@doggy8088 I seen PR -> merged and included in v1.0.9.
But it was before I read your message here.
Please verify it nothing is missing :)

Please review this change.
https://github.com/jaktestowac/vscode-playwright-helpers/pull/9/files

I verified and new PR is here: #10

@Freudenberger Is it possible to have a language switch option in the settings?

For example, I might want to use English as my main language of my VS Code, but I want to use Traditional Chinese locale for Playwright Helpers.

@doggy8088 thats a good question.
For now all localization and switching languages is done by VS Code when we switch languages.
Probably to achieve this scenario, when VS Code has Language X, but extension has language Y, we would use some external tooling (e.g. from my quick research https://www.npmjs.com/package/@vscode/l10n ).
Im not sure how much work would it cost to integrate it properly.
The question is in what scenarios user would like to have VS Code has Language X, but extension has language Y? :)