Vendor Specific QOS (24/25.43) not decoding properly.

When decoding the hex value of a vendor specific QoS TLV, I get the right information, but when decoding the text, the value I get does not make sense, and does not encode back to the same hex values, as well as truncates the rest of the TLVs (in my case, another vendor specific qos TLV and a service class name TLV) .
For example:
[Type:25] 19:4C:01:02:00:0D:06:01:07:07:01:05:08:04:00:0F:A0:00:0C:02:00:00:0D:02:00:C8:0E:04:00:00:00:00:2B:11:08:03:00:00:CA:30:10:01:08:00:00:00:1E:00:00:00:01:2B:0F:08:03:00:00:0C:04:08:00:00:00:14:00:00:00:01:04:08:65:4D:54:41:2D:44:53:00
Split out:
25: 19:4C
25.1: 01:02:00:0D
25.6: 06:01:07
25.7: 07:01:05:
25.8: 08:04:00:0F:A0:00:
25.12: 0C:02:00:00:
25.13: 0D:02:00:C8:
25.14: 0E:04:00:00:00:00
25.43: 2B:11:08:03:00:00:CA:30:10:01:08:00:00:00:1E:00:00:00:01
25.43: 2B:0F:08:03:00:00:0C:04:08:00:00:00:14:00:00:00:01
25.4: 04:08:65:4D:54:41:2D:44:53:00
What it looks like in text:
DownstreamServiceFlow        {
ServiceFlowReference 13;     /* TLV: [25.1]/
ServiceClassName eMTA-DS;    / TLV: [25.4]/
QualityOfServiceParameterSetType 07;         / TLV: [25.6]/
TrafficPriority 5;   / TLV: [25.7]/
MaxSubstainedTrafficRate 1024000;    / TLV: [25.8]/
TimeoutForActiveQoS 0;       / TLV: [25.12]/
TimeoutForAdmittedQoS 200;   / TLV: [25.13]/
TimeoutForAdmittedQoS 0;     / TLV: [25.14]/
VendorSpecificQoS 134414336;         / TLV: [25.43]*/
}

We will take a look at this.  I think we need to fix the Dictionary.  Also in a few weeks, you we will have an online app to Edit or Add TLVs

Thanks for the Feedback!!!
Download TLV Dictionary - Click View Raw
Replace db/dictionary.sqlite with download file.
Can you reply back if this fixes the problem.  If not can you provide your configuration file.

Better!  The first TLV43 shows up properly, but the second is still gone, as is the TLV after the two tlv 43's.
DownstreamServiceFlow        {
ServiceFlowReference 13;     /* TLV: [25.1]/
ServiceClassName eMTA-DS;    / TLV: [25.4]/
QualityOfServiceParameterSetType 07;         / TLV: [25.6]/
TrafficPriority 5;   / TLV: [25.7]/
MaxSubstainedTrafficRate 1024000;    / TLV: [25.8]/
TimeoutForActiveQoS 0;       / TLV: [25.12]/
TimeoutForAdmittedQoS 200;   / TLV: [25.13]/
TimeoutForAdmittedQoS 0;     / TLV: [25.14]/
VendorSpecificQoS 08:03:00:00:CA:30:10:01:08:00:00:00:1E:00:00:00:01;        / TLV: [25.43]*/
}
I’ve attached my binary file to this email.
From: Maurice Garcia<EMAIL_ADDRESS>Sent: Thursday, June 25, 2015 8:23 AM
To: Comcast/Oscar
Cc: Colin Dearborn
Subject: Re: [Oscar] Vendor Specific QOS (24/25.43) not decoding properly. (#38)
Thanks for the Feedback!!!
Download TLV Dictionary - Click View Rawhttps://github.com/Comcast/Oscar/blob/UpdateDictionary/db/dictionary.sqlite
Replace db/dictionary.sqlite with download file.
Can you reply back if this fixes the problem. If not can you provide your configuration file.
—
Reply to this email directly or view it on GitHubhttps://github.com/Comcast/Oscar/issues/38#issuecomment-115274741.

Apparently, the file gets stripped from email. :) Here's a link:
https://drive.google.com/file/d/0B5tjPaWyLCu1OER3MEZqTmtlelk/view?usp=sharing

OK, I see the problem.
[Type:25] 19:4C:01:02:00:0D:06:01:07:07:01:05:08:04:00:0F:A0:00:0C:02:00:00:0D:02:00:C8:0E:04:00:00:00:00:2B:11:08:03:00:00:CA:30:10:01:08:00:00:00:1E:00:00:00:01:2B:0F:08:03:00:00:0C:04:08:00:00:00:14:00:00:00:01:04:08:65:4D:54:41:2D:44:53:00
[Type:25] 19:4C:
01:02:00:0D:
06:01:07:
07:01:05:
08:04:00:0F:A0:00:
0C:02:00:00:
0D:02:00:C8:
0E:04:00:00:00:00:
2B:11:08:03:00:00:CA:30:10:01:08:00:00:00:1E:00:00:00:01:
You are missing this -> 2B:0F:08:03:00:00:0C:04:08:00:00:00:14:00:00:00:01:
04:08:65:4D:54:41:2D:44:53:00
 DownstreamServiceFlow	{
	 ServiceFlowReference 13;	 /* TLV: [25.1]*/
	 ServiceClassName eMTA-DS;	 /* TLV: [25.4]*/
	 QualityOfServiceParameterSetType 07;	 /* TLV: [25.6]*/
	 TrafficPriority 5;	 /* TLV: [25.7]*/
	 MaxSubstainedTrafficRate 1024000;	 /* TLV: [25.8]*/
	 TimeoutForActiveQoS 0;	 /* TLV: [25.12]*/
	 TimeoutForAdmittedQoS 200;	 /* TLV: [25.13]*/
	 TimeoutForAdmittedQoS 0;	 /* TLV: [25.14]*/
	 VendorSpecificQoS 08:03:00:00:CA:30:10:01:08:00:00:00:1E:00:00:00:01;	 /* TLV: [25.43]*/
}

There is a No Max Instance Rule in the dictionary, so it must be ignoring it.  Give me a few hours to fix

Download <IP_ADDRESS>-beta.1
Please Reply back to thread if it worked

Almost. Still missing the service class name TLV that is immediately after the second vendor specific TLV.
docsis decode of the service flow:
DsServiceFlow
{
DsServiceFlowRef 13;
QosParamSetType 7;
TrafficPriority 5;
MaxRateSustained 1024000;
ActQosParamsTimeout 0;
AdmQosParamsTimeout 200;
MaxDsLatency 0;
GenericTLV TlvCode 43 TlvLength 17 TlvValue 0x08030000ca301001080000001e00000001;
GenericTLV TlvCode 43 TlvLength 15 TlvValue 0x080300000c04080000001400000001;
ServiceClassName "eMTA-DS";
}
Oscar decode:
DownstreamServiceFlow  {
ServiceFlowReference 13;        /* TLV: [25.1]/
ServiceClassName eMTA-DS;       / TLV: [25.4]/
QualityOfServiceParameterSetType 07;    / TLV: [25.6]/
TrafficPriority 5;      / TLV: [25.7]/
MaxSubstainedTrafficRate 1024000;       / TLV: [25.8]/
TimeoutForActiveQoS 0;  / TLV: [25.12]/
TimeoutForAdmittedQoS 200;      / TLV: [25.13]/
TimeoutForAdmittedQoS 0;        / TLV: [25.14]/
VendorSpecificQoS 08:03:00:00:CA:30:10:01:08:00:00:00:1E:00:00:00:01;   / TLV: [25.43]/
VendorSpecificQoS 08:03:00:00:0C:04:08:00:00:00:14:00:00:00:01;         / TLV: [25.43]*/
}

It's there? The order may not be preserved.

So it is. Was expecting order to be preserved. :)
:+1:
Thanks!!

Top Level TLV are preserved, the SubTLV are Ordered.  I will fix that next.  BTW, keep checking back, we are building an OnlineApp, which will be available in a couple of weeks that will allow you to add  your own custom TLV without having to wait for an update from us.  Also create custom Vendor TLV like the ones above.
TLV Dictionary Wiki


[BUG]: App crash when running Optimize intervention settings

Scenario: https://github.com/DARPA-ASKEM/terarium/blob/main/testing/manual/optimize.md
Step: running Optimize intervention
Link to the project: https://app.staging.terarium.ai/projects/d0d0e082-8556-4906-ad84-cfb7d5be9afb/workflow/ec5c7b56-1bad-4c7d-b537-d2aa456733e9?operator=889186fb-b679-422f-89fe-1c338ec7ed72

Describe the issue
App crashes with array out of bounds error

For the record this is because we set end time for the intervention to be 150 and the optimize setting end time to 90
I will look to update the UI two ways

Do not allow the user to hit run when optimize end time < any intervention end time
highlight any infractions to this in red so it is easier for user to find infractions


[SPARK-24462][SS] Initialize the offsets correctly when restarting a query with saved state

What changes were proposed in this pull request?
Initialize the currentOffset and lastOffsetCommitted correctly when the query is restarted with saved state (startOffset has some value)
How was this patch tested?
existing unit tests
Please review http://spark.apache.org/contributing.html before opening a pull request.

@tdas @jose-torres @jerryshao @HeartSaVioR

Can one of the admins verify this patch?

Test build #91453 has started for PR 21490 at commit c5ff731.

What's the motivation for this change? Does something go wrong if they aren't initialized correctly?  (And note that we document that the socket source doesn't support fault recovery at all - not sure whether that should affect this PR.)

If "checkpointLocation" is set and the SS application is restarted, it throws the below exception because the currentOffset and lastOffsetCommitted are initialized to -1.
18/06/01 22:47:04 ERROR MicroBatchExecution: Query [id = 0bdc4428-5d21-4237-9d64-898ae65f28f3, runId = f6822423-2bd2-47c1-8ed6-799d1c481195] terminated with error
java.lang.RuntimeException: Offsets committed out of order: 2 followed by -1
 at scala.sys.package$.error(package.scala:27)
 at org.apache.spark.sql.execution.streaming.sources.TextSocketMicroBatchReader.commit(socket.scala:197)
 at org.apache.spark.sql.execution.streaming.MicroBatchExecution$$anonfun$org$apache$spark$sql$execution$streaming$MicroBatchExecution$$constructNextBatch$1$$anonfun$apply$mcZ$sp$2$$anonfun$apply$mcV$sp$5.apply(MicroBatchExecution.scala:377)

The proposed patch fixes this so that the query can be restarted with saved state. This could be used for running sample programs with saved state and examining the results (though its not fully fault tolerant)

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/91453/
Test PASSed.

The proposed strategy still won't work correctly, though. If a batch fails before commit, the restart won't replay the same records that were in that batch, but the new ones incoming from the socket.
I agree that the current state is non-ideal, but IMO we should either make batches actually replayable or add an exception explicitly stating that it's not allowed to restart a text socket source.

The patch does not attempt to make the micro-batch text-socket source fault tolerant and I suppose that may not be very trivial.
This just makes the source work when query is restarted allowing one to play with the sate in example programs (and could even produce correct results if the restart is done gracefully). Not allowing restarts may be too restrictive IMO.

@arunmahadevan I have already proposed a fix for this issue https://github.com/apache/spark/pull/20958, but seems it is not so necessary to fix based on the comments, and pending to review.

@jerryshao , was not aware of your PR before raising this, so looks like we both encountered similar issues. I think the intention is similar here and attempts to start from last saved offset (offsets are contiguous which may be slightly different from your PR). And maybe we don't need a separate flag, since the socket source is not expected to be fault tolerant.
The intention is with the fix socket source can work across restarts and allows users to play with the state in sample programs. Overall I think this will make the socket source more usable.
@tdas can you comment?

Can one of the admins verify this patch?

Test build #94525 has started for PR 21490 at commit c5ff731.

Test build #94525 has finished for PR 21490 at commit c5ff731.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.


I'm unable to make the extension work

I just installed the extension through Chrome Web Store and tried to use it in my browser without success.
I see the Puppeteer IDE in my developer tools, but it's just white, there's nothing there. This happens on all websites I visit (including Github).

Any ideas on how I can fix this?

Can you try refreshing the page, keeping devtools open

Same issue.
I have also tried restarting the entire browser (not just tabs) and disabling all extensions (except Puppeteer of course). Neither helped.

I tried again in Brave, there it works. But not in regular Google Chrome.

What is Google Chrome version, i will check on that version

96.0.4664.110 (Official Build) (64-bit)

After opening devtools and switching to Puppeteer IDE tab. Again press Ctrl+Shift+I, which will open devtools for devtools, there in console tab can you check if any errors.

Yep, there were errors:

I was using localStorage to persist script but it seems it's not allowed when cookies are blocked so have made changes to use chrome.storage extension api instead of localStorage. You can try extension version <IP_ADDRESS> once and if you still face this issue feel free to reopen this issue.


Fix broken Endpoints (addHostname, setForceSSL, removeHostname, loadFreeCertificate)

Fixed several endpoints where the request was not built correctly.

Sure 👍


RD2: Display Active Schedule on the RD Lightning Page

We added a Recurring Donations Active Schedules component for use on the Enhanced Recurring Donations record page. The Recurring Donations Active Schedules component displays the details of both current and future active schedules.
Critical Changes
Changes
Changed the labels associated with the Recurring Donations Installments component to better distinguish between installments and schedules.
Issues Closed
New Metadata
Custom Labels:

RD2_ActiveSchedulesEndDate

Lightning Component Bundle:

rdActiveSchedule

Deleted Metadata

**lurch: attach W-037848

Tracking W-037848

@force2b @RadSFDeveloper I've created a WIP PR for the Active Schedule work so @ravensisco can begin doing some preliminary testing.  Please do not review this item yet.  There are several known items that need to change, so it would be more efficient to hold any review until those known issues are addressed.

@force2b @RadSFDeveloper There is UI work still in progress, but current work satisfies the ACs and tests are complete, so I believe it is okay to review now, with the understanding that there will be some UI changes.
@sam-knox There are still some label changes coming.  Will alert you when labels are ready for review.

@sam-knox Labels are ready for review.
@force2b @RadSFDeveloper Last remaining UI issue resolved, so this is stable and ready for any additional feedback you might have.

@sam-knox There has been one new label added - AssistiveTextRecordIcon. All new labels mentioned in the PR comment have been renamed, but text has not changed.

@RadSFDeveloper @force2b PR suggestions should be fully implemented.  Ready for another review.

@RadSFDeveloper @force2b PR feedback implemented.  Please review again.  Thanks!

@RadSFDeveloper @force2b PR feedback implement.  Can you take another look please?

QE testing for this PR is now complete.  Tests have passed.
For further testing details, see:
https://foundation.lightning.force.com/lightning/r/agf__ADM_Work__c/a2x1E000001HpLVQA0/view
https://salesforce.quip.com/HjUEAjM6dF5F
PR has been merged.  Once post-merge builds have completed and passed, WI status will be set to Closed.


npm + typescript - import issue (example would be exellent)

Hi can you provide a Typescript + npm example using either a web project (Angular 2+ or Aurelia) or Node.JS, does not really matter which one as the code to "import" it would be similar.
#25 <- this is very close to the issue i'm actually having, i'm currently developing a Aurelia web app.
if it helps im using VS Code as the Editor.
(ps thanks for doing this project, it should save me a ton of time)

Hi @dbones ,
Thanks for your interest in the AutoMapperTS library. The library has been created quite a long while back (at least, speaking web ;)). When I created the library, the file import syntax was not that common.
I answered a question similar to yours at StackOverflow a while ago, I hope it helps you as well: https://stackoverflow.com/questions/40138293/importing-automapper-into-a-angular2-webpack-project/44692661#44692661.
Cheers, Bert


Update the developer guide: user stories, glossary, NFRs, use cases

The current developer guide is made for AddressBook3. It does not contain any ContactMation-specific details. Fixes #6.
This adds the follow ContactMation-specific information:

User stories
Use cases
Non-functional requirements
Glossary

The developer guide will now be more specific to ContactMation.

Codecov Report

Merging #25 (0e7edb2) into master (f18f93a) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master      #25   +/-   ##
=========================================
  Coverage     72.15%   72.15%
  Complexity      399      399
=========================================
  Files            70       70
  Lines          1232     1232
  Branches        125      125
=========================================
  Hits            889      889
  Misses          311      311
  Partials         32       32

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Updated Readme

I made a custom Readme just for hammertime and would love to see it added, I left the Sledge website just to remind everyone that this project is just a fork of Sledge

Push so you see it lol

Thanks a lot.
I will merge it.


The Apex Library has compatibility issues with the currently installed version of PyTorch (torch = = 1.10.1 + CU113) .

Hello, Can you help me to look at this error?
The Apex Library has compatibility issues with the currently installed version of PyTorch (torch = = 1.10.1 + CU113) . An error occurred after running the environment that was installed according to the steps.
python main.py --dir_data nyudepthv2 --data_name NYU  --split_json data_json/nyu.json  --gpus 0 --max_depth 10.0 --num_sample 500 --save_image  --test_only --pretrain pretrained/NYUv2.pt --save hy-tmp/save
Traceback (most recent call last):
File "CompletionFormer-main/CompletionFormer-main/src/main.py", line 42, in
import apex
File "/usr/local/miniconda3/envs/completionformer/lib/python3.8/site-packages/apex/init.py", line 8, in
from . import amp
File "/usr/local/miniconda3/envs/completionformer/lib/python3.8/site-packages/apex/amp/init.py", line 1, in
from .amp import init, half_function, float_function, promote_function,
File "/usr/local/miniconda3/envs/completionformer/lib/python3.8/site-packages/apex/amp/amp.py", line 1, in
from . import compat, rnn_compat, utils, wrap
File "/usr/local/miniconda3/envs/completionformer/lib/python3.8/site-packages/apex/amp/rnn_compat.py", line 1, in
from . import utils, wrap
File "/usr/local/miniconda3/envs/completionformer/lib/python3.8/site-packages/apex/amp/wrap.py", line 3, in
from ._amp_state import _amp_state
File "/usr/local/miniconda3/envs/completionformer/lib/python3.8/site-packages/apex/amp/_amp_state.py", line 14, in
from torch._six import container_abcs
ImportError: cannot import name 'container_abcs' from 'torch._six' (/usr/local/lib/python3.8/dist-packages/torch/_six.py)

Hi,
I'm sorry for not getting back to you sooner.  According to this note:
ImportError: cannot import name 'container_abcs' from 'torch._six' (/usr/local/lib/python3.8/dist-packages/torch/_six.py)
The issue may be due to the torch version.  Please search on Google to find a specific solution.
Best,
Youmin


Further Collect trait improvements

Builds off of #107 to further improve the Collect trait.
There are three main API changes:

Makes the Collect::trace method take a generic parameter that must implement the new trait Trace. This will be useful in the future to generically scan any value type for the properties of their held pointers.
Adds a 'gc lifetime parameter to Collect and Trace, allowing for more safety especially when implementing Trace which is a safe trait.
Changes the #[derive(Collect)] proc macro to handle the required 'gc lifetime on Collect and Trace. Almost always this will work without any further changes, but in the extremely rare and almost completely useless case where a type has multiple lifetime parameters, one must now be selected with #[collect(gc_lifetime = 'gc)].

There are also some additional related internal changes

Internally, don't use RefCell<Vec<GcBox>> for the gray queues. Instead, just unsafety via a new internal Queue type. This avoids the need for locking in all cases.
Because of the previous change, we can get rid of MarkState entirely and implement Trace on Context directly.

This also changes some parts of the design of #107 and there are some open questions.

Collect::trace now accepts &mut (impl Trace<'gc> + ?Sized) instead of impl Trace<'gc> which would more closely match what used to be Collection<'_>. This is for a few reasons:

Requiring the implementer of Trace to always provide a special reborrow trace method that takes T: Collect is slightly obnoxious, and would require that every implementation always include the if T::NEEDS_TRACE { ... } check itself.
We probably want to leave open the possibility of passing a dyn trait here, in case we need to one day need to allow tracing the contents of a Gc via vtable (such as with a cast Gc pointer).
Every method on Trace accepts &mut self, so accepting a &mut impl Trace<'gc> allows for avoiding a double indirection on Trace methods.

However, this does not enforce that implementers of Collect must always use a convenience method that includes if T::NEEDS_TRACE { ... }. To me this is not a very big deal, because:

The previous technique only enforced this in the case where there were multiple fields due to moving the Collection<'_> object, and the fact that it doesn't work doesn't automatically hint to why things were designed that way.
We can do whatever we want in the proc derive
It usually not actually THAT bad if Collect::trace doesn't check NEEDS_TRACE on its field types. This only matters when the inner Collect::trace is not inline or doesn't itself early exit.

Instead of Collection::trace, I added a TraceExt extension trait and a TraceExt::trace extension method which does what Collection::trace used to do. I would have liked to avoid an extension trait, but adding it as an inherent Trace method has problems as well, namely that it wouldn't work with &mut dyn Trace (which would be required for one day tracing pointee of Gc<'gc, ()>). I could have also added this convenience method on Collect in the form of an additional method that always checked Self::NEEDS_TRACE, but that is also somewhat confusing because both methods would have default implementations (and it wouldn't be immediately clear which one to implement). On the balance, this seemed the best option but I'm open to changing how this works.

Should Collect<'gc> also imply : 'gc?

Is #[collect(gc_lifetime = 'gc)] just overkill?

The vtable trace_value function signature is unsafe fn(GcBox, &mut Context), it could be unsafe fn(GcBox, &mut dyn Trace<'gc>) for future use, but I figured it was worth it to micro-optimize this?

The TraceExt extension trait is gone in favor of an inherent method and dropping the + ?Sized bound in Collect::trace everywhere (required because the inherent method must require Self: Sized).
This is not a big deal at all because &mut dyn Trace is ONLY going to be necessary for tracing through Gc, which can use an internal wrapper anyway (exactly how the current function works but not specialized to &mut Context).


Bug: Some Shops are overpriced

Hi, first of all: Great mod!
I find that some shops have way to high prices. F.e: I found a Shop in Stage 2 for over 700$ containing regular items.

Thanks!
The prices are actually supposed to loosely mimic those of chests: A shop containing tier 1 (white) items costs the same as small chest, a tier 2 (green) shop costs the same as a large chest and the rare tier 3 shops (red) have the same base cost as the legendary chests that can be found in stage 4. I'm assuming you found a tier 3 shop, which is why the cost was so high.
Personally, I like how the costs are balanced, as it makes skipping an early tier 3 shop a valid choice if the items on offer aren't worth it.
That said, I'll take a look at adding some settings so that the costs can be customized for each tier of shops.
PS: If my guess was wrong and you're sure that it wasn't a tier 3 shop you ran into I'll have to take a deeper look into what happened.

I’m sure that the shop contained Tier 1 items.
Same thing in stage 1 I found two shops with tier 1 items, that did cost 50$ instead of 25$

Yeah, I've just been trying to reproduce the bug and just found a shop just like that as well. Not sure yet why this is happening with the update, but I'll look into it.

Took me a while to realize what's going on, but the actual issue was that the rarity of the shop items didn't get changed because the way shop items are chosen changed quite a bit with the update.
Anyway, I've found a way to fix it and it should work properly in version 3.0.2, which should be live on Thunderstore in a few minutes.


soc: arm: st_stm32: stm32g4: STM32G4 support

Add support for STM32G4 series
Signed-off-by: Richard Osterloh<EMAIL_ADDRESS>

Requires PR from stm32_hal https://github.com/zephyrproject-rtos/hal_stm32/pull/20

It would worth to split the PR into several commits, e.g. one for the SoC support, one for the new board(s) support...

Split the commit as requested by @loicpoulain and added copyright dues zephyrbot warnings

@erwango I've done the following tests:

@rosterloh

@erwango I've done the following tests:

Ok, then please focus your commits on drivers actually validated: clock, gpio, interrupt_controller.
And remove reference (in doc, dts, driver modifications, ...) for whatever was not validated yet: SPI, I2C, ADC, PWM, UART, ....
These will be added later on, either by you when you have time or by other community members that will take advantage of your initial basic port.

@erwango I've validated everything I've checked in. Just pushed a few fixes in and additional commit. clock, gpio, i2c, interrupt_controller, pwm, led, pinmux, serial, spi and usb all working.

@erwango I can't fix the shippable errors as they require my PR from the hal_stm32 repo to be merged. I've made the other small changes from checkpatch. Do you want me to split the commits further than I already have?

@erwango I can't fix the shippable errors as they require my PR from the hal_stm32 repo to be merged.

Ok, you actually need to push an updated version of west.yml manifest targeting https://github.com/zephyrproject-rtos/hal_stm32/pull/20 (cf: https://docs.zephyrproject.org/latest/contribute/index.html?highlight=modules#contributions-to-external-modules).
This will allow CI to build using the HAL. Then, once we're satisfied with current PR, the PR on hal_stm32 will be merged and we'll get the hal_stm32 SHA1 to update west.yml. And finally current PR with this last west.yml version.

I've made the other small changes from checkpatch. Do you want me to split the commits further than I already have?

Indeed, please refer to https://docs.zephyrproject.org/latest/contribute/index.html#other-commit-expectations.

@rosterloh, thanks for the split into multiple commits.
Usually, for review efficiency and consistency, I prefer these are split by topic rather by pure directory point of view (eg: usart dts, Kconfig, _fixup, ... into a uart commit, and same for I2C, ...) (as you could see in L1 port (#12354) for instance).
Though, considering the effort made to bring all the drivers, I'll start reviewing in current state.
Meanwhile, if you have time to do this, it would be welcome.

@erwango Thank you for being understanding. I am very busy with my current project at work at the moment but I thought it would be good to push back my changes to help the community. I will try my best to find the time.

@rosterloh , pushed most of the re-split work on you repo, this is a quick work that should be reviewed but I hope you can take it and push it back

Thank you very much @erwango. I really appreciate your help.

@rosterloh, seems now we have way too much commits (as shown in github, even if not visible on git tree), and I won't be able to help on that front.
I think the easiest to get back on our feet is for you to take back the branch I pushed to your project and push this one directly (and then skip the merge in your branch).
Sorry for additional steps, but this is the first time I tried to work this way.
Thanks

@rosterloh, please rebase your branch as there was an issue with a Kconfig symbol which screwed your CI and is fixed now.
Also, about identity checks, please add our both sign-off to the guilty commit .

Seems like my flash partition for settings is too small now. Is there a minimum?

@erwango on closer inspection ci failing because the application it's building is too big for the FLASh on the device. Is there a mechanism for blacklisting certain tests on certain boards?

@rosterloh
Theoretically, CI uses board ram/flash size decalred in board yaml to select which applications could be run on which targets. I wonder why this is failing here.
According to test filters, minimum flash required is 64 and you get 128. There are also other filters that might prevent build on other targets.
Need to find other boards on which it is tested and see flash size. If others targets have similar binary size, issue lies in the test requirements.

Building disco_l475_iot1, I get
[145/156] Linking C executable zephyr/zephyr_prebuilt.elf
Memory region         Used Size  Region Size  %age Used
           FLASH:       67356 B         1 MB      6.42%
            SRAM:       13920 B        96 KB     14.16%
        IDT_LIST:         152 B         2 KB      7.42%

While your board gets :
Memory region         Used Size  Region Size  %age Used
           FLASH:      132472 B       128 KB    101.07%
            SRAM:       14080 B        32 KB     42.97%
        IDT_LIST:         120 B         2 KB      5.86

I wonder how we end up with double flash size on this target

Hmmm, that's really odd. I'm making mods for the gpio api which changed yesterday so maybe the next build will be different.

@ioannisg , can you help us here?
Seems tests/arch/arm/arm_thread_swap is run on board introduced in this PR with no_optimization flavor, which results in  a bit more than 128K flash.
Test is filtering this no_optim config on > 64 min flash, this sounds optimistic.
Would that be ok to filter on > 128 ?

I'm making mods for the gpio api which changed yesterday so maybe the next build will be different.

I'd prefer you don't mix both topics in this PR.
PR is in good shape to be merged soon and there is already a work planned for GPIO API. Your contribution would be of course welcome on this, but please keep it for another PR.

@ioannisg , can you help us here?
Seems tests/arch/arm/arm_thread_swap is run on board introduced in this PR with no_optimization flavor, which results in a bit more than 128K flash.
Test is filtering this no_optim config on > 64 min flash, this sounds optimistic.
Would that be ok to filter on > 128 ?

@erwango sure, I think this is OK.

@rosterloh, just pushed #19302, when/if accepted please rebase on it to fix shippable issue

@rosterloh, shippable should work now. You can rebase to get it passed

@erwango Woo Hoo! All passed.

Approved, but last point will be to update west.yml file once https://github.com/zephyrproject-rtos/hal_stm32/pull/20 is merged.
Tagged DNM until this is done.

Approved, but last point will be to update west.yml file once zephyrproject-rtos/hal_stm32#20 is merged.
Tagged DNM until this is done.

Merged the HAL repo change.

@erwango @galak made the west.yaml change


Improve PowerShell code.

Using aliases like Select instead of Select-Object is bad practice.
Also fixed spacing to be consistent.

@bjompen : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@malopMSFT – Can you review the proposed changes? IMPORTANT: When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"

@bjompen : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@bjompen : Thanks for your contribution! The author(s) have been notified to review your proposed change.


[elasticsearch] Adds imagePullSecrets for test Pod

[x] Chart version not bumped (the versions are all bumped and released at the same time)
[ ] README.md updated with any new values or changes
[ ] Updated template tests in ${CHART}/tests/*.py
[ ] Updated integration tests in ${CHART}/examples/*/test/goss.yaml

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

Signed

jenkins test this please

Hi @marcostvz, thank you for this PR. Can you sign the CLA?

I had to re-sign the commit, thanks for your quick review @jmlrt

jenkins test this please


Duplicated code for url regex

https://github.com/plone/volto/blob/8d247b03d22b096cc25d3e1c632aae0eb385d374/src/components/manage/AnchorPlugin/utils/urlRegex.js
https://github.com/plone/volto/blob/8d247b03d22b096cc25d3e1c632aae0eb385d374/src/helpers/Url/urlRegex.js

This will be solved as part of https://github.com/plone/volto/pull/2992


Confirm the shape of full-stack cert

The fullstack cert doesn't yet include the the three new python certificates, however it does include the InfoSec Cert and QA Cert (that have been split from the single InfoSec & QA cert).
We need clarity on the what is happening to the retired projects (there are new required projects in both certs).
We also need clarity on what is required to claim the fullstack cert. As is it does not have the three new python certs. At the same time, it needs one additional cert (from the split as mentioned earlier).
This could be a source of support queries.
Refer: https://github.com/freeCodeCamp/freeCodeCamp/pull/38912#pullrequestreview-419094596

@beaucarnes @QuincyLarson
I would like some inputs on the plans that was formulated how to mitigate this. Validations you would implement for the various scenarios.

Partial Curriculum Progress.
~Past certifications~ (this is implemented and tested already)

@raisedadead I think we should call it the "Legacy Full Stack Development Certification" and it should include the first 6 certifications.
Once we've added the Relational Database Certification projects and merged the Data Visualization Certification into the Front End Libraries certification, we can create a new Full Stack Development Certification that you get for completing all 10 certifications.

I think we should call it the "Legacy Full Stack Development Certification" and it should include the first 6 certifications.

Thanks for the confirmation. This needs some visual changes to the settings and timelines. From my guess this does not need any change to the API.
I am assigning @ahmadabdolsaheb to work on this.
Ahmad, this is a potential show stopper for shipping to production.

Once we've added the Relational Database Certification projects and merged the Data Visualization Certification into the Front End Libraries certification, we can create a new Full Stack Development Certification that you get for completing all 10 certifications.

I have created https://github.com/freeCodeCamp/freeCodeCamp/issues/38943 to track this specifically.

I think we should call it the "Legacy Full Stack Development Certification" and it should include the first 6 certifications.

Are we referring to the following 7 certificates?

responsive web design
javascript data structures and algorithms
front end libraries
data visualisation
api and microservices
quality assurance
info security

Maybe @QuincyLarson and @beaucarnes have thought of how this to be mitigated? The certificates were split and did replace some projects?
So it has to be both ways?

Also,

Once we've added the Relational Database Certification projects and merged the Data Visualization Certification into the Front End Libraries certification, we can create a new Full Stack Development Certification that you get for completing all 10 certifications.

I think it implies Relational Database will be a certification of its own.
In that case, 7 js certs, 3 python certs, and relational db would make 11 certs.

@ahmadabdolsaheb Just to be 100% clear, here are the two terms I've been using:
"Front 3" (called "front" because they can be done right on freeCodeCamp.org without any additional tools or servers)

Responsive Web Design
JavaScript Algorithms and Data Structures
Front End Libraries (will include the Data Visualization Certification, which will be merged in during phase 3)

"Back 7" (called "back" because because they will require a back end, and will be completed either in a VS Code environment in a browser or on a local computer in a Docker container):

Relational Databases
APIs and Microservices
Quality Assurance
Scientific Computing
Data Analysis
Machine Learning
Information Security

We want the Full Stack Developer Certification to only be claimable after completing all 50 certification projects. Once we ship our current beta, 45 of these 50 certification projects will be live in production. We will ship the Relational Database Certifications once @moT01 is done with them.)
In the meantime, we have the Legacy Full Stack Development Certification, which can be earned by completing the projects from:

the front 3
the 5 data visualization projects
the 5 API and Microservice projects
the 5 Quality Assurance projects

I think we can immediately start calling this the "Legacy Full Stack Certification", and just introduce the new Full Stack Certification with Phase 3 when we've added these final 5 Relational Database Projects.

@moT01 in his https://github.com/freeCodeCamp/freeCodeCamp/pull/38995#issuecomment-638586622 says:

What if someone is like one project away, and all of a sudden there's 5 new projects before it can be claimed.

Now, from the discussion in this thread, it seems to imply that we will have the certification renamed and anyone who is midway or almost done with the cert will have to go thru with additional projects for certification?
@QuincyLarson can you confirm this? IMHO, So far this thread has only covered users who are "going to start" the InfoSec or the QA Cert.

@QuincyLarson
Ahmad, Kris, Oliver and me met to discuss and QA the implementation in https://github.com/freeCodeCamp/freeCodeCamp/pull/38995. We hit some hurdles, while trying to address the requirement in the changes you requested for the Legacy Full Stack Development Certification.
After much deliberation we concluded this is what we can do to be able to mitigate all sorts of technical limitations around the legacy schema we have had.

The current Full Stack Certification in the settings is to be moved to the legacy section (below everything in that legacy stack).
It is to be called 'Legacy Full Stack Development Certification' as per the thread above.
It will list all the certifications needed to claim it:

Responsive Web Design
Algorithms and Data Structures
Front End Libraries
Data Visualization
APIs and Microservices
Quality Assurance Legacy Infosec and QA Certs

Metric Imperial Converter
Issue Tracker
Personal Library
Stock Price Checker
Anonymous Message Board

All projects should link back to their own pages (already on learn) for quick navigation.
We will have a 'coming soon' style section for the  'Full Stack Development Certification' as a replacement for the above move.

Doing the above will address:

Anyone who has completed the projects from the 'Legacy InfoSec and QA Cert' will be able to claim the Legacy Full Stack Development certification.
We will not advertise this on the learn map for new users, which means mostly users who were continuing this certification will claim it.
It will make all the implementation quite simple and straight for the @freeCodeCamp/dev-team without delaying the new curriculum, effectively unblocking it.
Finally we agreed that the upcoming Phase 3 changes will make this a good transitional choice without users needing to wait on claiming certifications. They can claim certs as they become available. They can also go back and claim legacy certs should they choose to.


Use OllamaFunctions to build AgentExecutor but return errors with tools

Checked other resources

[X] I added a very descriptive title to this issue.
[X] I searched the LangChain documentation with the integrated search.
[X] I used the GitHub search to find a similar question and didn't find it.
[ ] I am sure that this is a bug in LangChain rather than my code.
[X] The bug is not resolved by updating to the latest stable version of LangChain (or the specific integration package).

Example Code
from langchain_experimental.llms.ollama_functions import OllamaFunctions
from langchain_core.tools import tool
from langchain_community.tools.tavily_search import TavilySearchResults
import os
from langchain.agents import AgentExecutor
from langchain.agents import create_tool_calling_agent
from langchain import hub

os.environ["TAVILY_API_KEY"] = ''

llm = OllamaFunctions(model="llama3:8b", temperature=0.6, format="json")

@tool
def multiply(first_int: int, second_int: int) -> int:
    """Multiply two integers together."""
    return first_int * second_int

@tool
def search_in_web(query: str) -> str:
    """Use Tavily to search information in Internet."""
    search = TavilySearchResults(max_results=2)
    context = search.invoke(query)
    result = ""
    for i in context:
        result += f"In site:{i['url']}, context shows:{i['content']}.\n"
    return result

tools=[
        {
            "name": "multiply",
            "description": "Multiply two integers together.",
            "parameters": {
                "type": "object",
                "properties": {
                    "first_int": {
                        "type": "integer",
                        "description": "The first integer number to be multiplied. " "e.g. 4",
                    },
                    "second_int": {
                        "type": "integer",
                        "description": "The second integer to be multiplied. " "e.g. 7",
                    },
                },
                "required": ["first_int", "second_int"],
            },
        },
        {
            "name": "search_in_web",
            "description": "Use Tavily to search information in Internet.",
            "parameters": {
                "type": "object",
                "properties": {
                    "query": {
                        "type": "str",
                        "description": "The query used to search in Internet. " "e.g. what is the weather in San Francisco?",
                    },
                },
                "required": ["query"],
            },
        }]

prompt = hub.pull("hwchase17/openai-functions-agent")

agent = create_tool_calling_agent(llm, tools, prompt)

agent_executor = AgentExecutor(agent=agent, tools=tools)

### Error Message and Stack Trace (if applicable)

---------------------------------------------------------------------------
Traceback (most recent call last):
  File "/media/user/My Book/LLM/Agent/check.py", line 80, in <module>
    agent_executor = AgentExecutor(agent=agent, tools=tools)
  File "/home/user/anaconda3/envs/XIE/lib/python3.9/site-packages/pydantic/v1/main.py", line 339, in __init__
    values, fields_set, validation_error = validate_model(__pydantic_self__.__class__, data)
  File "/home/user/anaconda3/envs/XIE/lib/python3.9/site-packages/pydantic/v1/main.py", line 1100, in validate_model
    values = validator(cls_, values)
  File "/home/user/anaconda3/envs/XIE/lib/python3.9/site-packages/langchain/agents/agent.py", line 981, in validate_tools
    tools = values["tools"]
KeyError: 'tools'

### Description

I am tring to initialize AgentExecutor with OllamaFunctions.
I have check the `OllamaFunctions.bind_tools` and it works well.
So I want to use AgentExecutor to let llm to response.
But `keyerror: tools ` confused me, since the `create_tool_calling_agent` use the same `tools` value.
Does anyone know how to fix this problem?

### System Info

langchain==0.2.1
langchain-community==0.0.38
langchain-core==0.2.1
langchain-experimental==0.0.58
langchain-openai==0.1.7
langchain-text-splitters==0.2.0
langchainhub==0.1.16
platform: Ubuntu 20.04
python==3.9

Well you cannot use OllamaFunctions with AgentExecutor due to unsupported messages type in ChatOllama (ToolAgentAction) but you can still use OllamaFunction to call functions by doing some custom changes as shown below, let me know if you understand the code below because I have made some major changes in OllamaFunctions to make it work. Please try it on your machine and let me know if it works. I would also suggest using React which is being powered by Ollama:

from langchain_experimental.llms.ollama_functions import OllamaFunctions,convert_to_ollama_tool
from langchain_core.prompts import ChatPromptTemplate

from langchain_core.tools import tool
from langchain_community.tools.tavily_search import TavilySearchResults
from langchain_core.pydantic_v1 import (
    BaseModel,
    Field
)
from langchain_core.messages import AIMessage, ToolCall
from langchain_core.outputs import ChatGeneration, ChatResult
from langchain_core.prompts import SystemMessagePromptTemplate,HumanMessagePromptTemplate
from langchain_core.pydantic_v1 import BaseModel
from langchain_community.chat_models.ollama import ChatOllama
from langchain.agents.output_parsers import ToolsAgentOutputParser

class CustomOllamaFunctions(OllamaFunctions):

    def _generate(
        self,
        messages,
        stop,
        run_manager,
        **kwargs,
    ):
        functions = kwargs.get("functions", [])
        if "functions" in kwargs:
            del kwargs["functions"]
        if "function_call" in kwargs:
            functions = [
                fn for fn in functions if fn["name"] == kwargs["function_call"]["name"]
            ]
            if not functions:
                raise ValueError(
                    "If `function_call` is specified, you must also pass a "
                    "matching function in `functions`."
                )
            del kwargs["function_call"]
        response_message = ChatOllama(model="llama3", temperature=0, format="json")._generate(
            messages, stop=stop, run_manager=run_manager, **kwargs
        )
        chat_generation_content = response_message.generations[0].text
        if not isinstance(chat_generation_content, str):
            raise ValueError("OllamaFunctions does not support non-string output.")
        try:
            parsed_chat_result = json.loads(chat_generation_content)
        except json.JSONDecodeError:
            raise ValueError(
                f"""'{self.model}' did not respond with valid JSON.
                Please try again.
                Response: {chat_generation_content}"""
            )
        called_tool_name = parsed_chat_result["tool"]
        called_tool = next(
            (fn for fn in functions if fn["name"] == called_tool_name), None
        )
        if called_tool is None:
            raise ValueError(
                f"Failed to parse a function call from {self.model} output: "
                f"{chat_generation_content}"
            )
        called_tool_arguments = parsed_chat_result["tool_input"]

        response_message_with_functions = AIMessage(
            content="",
            tool_calls=[
                ToolCall(
                    name=called_tool_name,
                    args=called_tool_arguments if called_tool_arguments else {},
                    id=f"call_{str(uuid.uuid4()).replace('-', '')}",
                )
            ],
        )
        return ChatResult(
            generations=[ChatGeneration(message=response_message_with_functions)]
        )

os.environ["TAVILY_API_KEY"] = ''

class MultiplyInput(BaseModel):
    """Input for the Multiply tool."""

    name = "Multiply"
    description = "Multiply two integers together."
    first_int: int = Field(description="The first integer number to be multiplied e.g 4")
    second_int: int = Field(description="The second integer to be multiplied. e.g 7")

class SearchinWebInput(BaseModel):
    """Input for the Multiply tool."""

    name = "SearchinWebInput"
    description = "Use Tavily to search information in Internet."
    query: str = Field(description="The query used to search in Internet. " "e.g. what is the weather in San Francisco?")

def multiply(first_int: int, second_int: int) -> int:
    """Multiply two integers together."""
    return first_int * second_int

def search_in_web(query: str) -> str:
    """Use Tavily to search information in Internet."""
    search = TavilySearchResults(max_results=2)
    context = search.invoke(query)
    result = ""
    for i in context:
        result += f"In site:{i['url']}, context shows:{i['content']}.\n"
    return result

llm = CustomOllamaFunctions(model="llama3", temperature=0, format="json")
tools = [MultiplyInput,SearchinWebInput]
tools = [convert_to_ollama_tool(fn) for fn in tools]

system_message = """
You have access to the following tools to answer the user question:

{tools}

You must always select one of the above tools and respond with only a JSON object matching the following schema:

{{
  "tool": <name of the selected tool>,
  "tool_input": <parameters for the selected tool, matching the tool's JSON schema>
}}

Double check that in your json, you only have `tool` and `tool_input`.
""".format(tools=json.dumps(tools, indent=2))

prompt = ChatPromptTemplate(messages=[SystemMessagePromptTemplate.from_template(system_message,template_format='jinja2'),
                                      HumanMessagePromptTemplate.from_template('{input}')])

all_tools = {'Multiply':multiply,'SearchinWebInput':search_in_web}
llm_with_tools = llm.bind_tools(tools=tools)
agent = prompt | llm_with_tools | ToolsAgentOutputParser()
action = agent.invoke({'input':'Using the search tool tell me Who is elon musk?'})[0]
tool_used,tool_input = action.tool,action.tool_input
print(all_tools[tool_used](**tool_input))

@keenborder786 Agent successfully returned search information with your codes. Thanks.
I know the complexity is due to Ollama has not support function calling yet.
So OllamaFunctions will continue to imporve? It will be easier to build agent if Ollama support function calling in the future?

@DiaQusNet Agreed therefore keep the issue open

@keenborder786 Thank you. Is it possible to use tools with llama.cpp as well? because i don't think there is anything in llama.cpp like ollamafunctions. also, i prefer llama.cpp because it is faster, almost twice, for same model.
though i'm able to use kobold.cpp for tools, however, it only works for first step "AI message" and does not go to tool message, and did not throw error like ollama or llama.cpp, so I assumed that maybe tools can be used with kobold.cpp however, they don't work like I want, or perhaps tools don't work at all and kobold just don't throw error.

update with llama.cpp, now it is not throwing error after updating llama.cpp. However, now the output is like the kobold.cpp's
(ai) D:\work\project\ai>python agent1.py
{
'agent': {
'messages': [
AIMessage(
content=" To answer your question, I'll first list the tables in the database and then query the schema of the table
that seems most relevant to find out which country's customers spent the most.\n\nsql\nPRAGMA table_info(sqlite_master);\n\n\nLet's assume we have a table named transactions that contains information about customer
transactions. Now, I will query the schema of this table to find out which columns are available:\n\nsql\nPRAGMA table_info(transactions);\n\n\nAssuming the transactions table has columns like customer_id, amount, and country, I'll
write a SQL query to find the country with the highest total spent by its customers.\n\nsql\nSELECT country, SUM(amount) as total_spent\nFROM transactions\nGROUP BY country\nORDER BY total_spent DESC\nLIMIT 1;\n\n\nThis query groups all transactions by
their respective countries and calculates the total amount spent in each country. It then orders the results in descending order
based on the total spent, and limits the output to only the top result (the country with the highest total spent).",
response_metadata={
'token_usage': {'completion_tokens': 263, 'prompt_tokens': 265, 'total_tokens': 528},
'model_name': 'gemini-pro',
'system_fingerprint': None,
'finish_reason': 'stop',
'logprobs': None
},
id='run-45dbe68d-a9a6-42af-b355-a363e5c74406-0',
usage_metadata={'input_tokens': 265, 'output_tokens': 263, 'total_tokens': 528}
)
]
}
}
This is from the code of agent part from the page agents but i think output should be "agent"...
action ...
agent ...
action
...
until you get the correct answer

Take a look at #22339 which should have addressed this issue.
The PR was approved and merged yesterday but a release is yet to be cut from it and should happen in the next few days.
In the meantime, you may try and install langchain-experimental directly from langchain's source like this:
pip install git+https://github.com/langchain-ai/langchain.git\#egg=langchain-experimental\&subdirectory=libs/experimental

I hope this helps.


PlatformException error showing ERROR_GEOCODING_ADDRESS

🐛 Bug Report
I want to get attitude and longitude from address
When I am using the code

List<Placemark> placemark = await Geolocator().placemarkFromAddress(address);

It showing the error for some address. Not showing error for all address.

PlatformException(ERROR_GEOCODING_ADDRESS, The operation couldn’t be completed. (kCLErrorDomain error 8.), null)

Configuration
Version: ^5.1.4+2
Platform:

[ ] :iphone: iOS

It ' s working fine in android. But in IOS it showing error.
How to solve this issue?

I'm having the same issue. It seems like it's happening in many projects. Can you please look into this?

PlatformException(ERROR_GEOCODING_COORDINATES, grpc failed, null)only on android

I'm having the same issue. It works totally fine on android but not on ios. Was anyone able to find a solution?

Since version 6.0.0 the geocoding features are no longer part of the geolocator plugin and moved to their own plugin which can be found here.


NIFI-2708 Added merging of SiteToSite details

Ready for review.

Reviewing...

Good catch.  Updated so that it doesn't skip over aggregating the clientDto ports.

Looks good @jtstorck! This has been merged to master.


overload .type to accept a callable/lambda

Addresses #65
I'm basically no good at Java, so this may have lots of problems with it. Conceptually this does make some sense to me.
As I can tell, Lambda implement something called FunctionalInterfaces. DataFetcher is one such FunctionalInterface that you have defined already.
Java.util.concurrent.Callable is also a functional interface. It maps to a lambda that takes no arguments but returns a value.
Therefore Callable<GraphQLOutputType> should be a lambda that returns a GraphQLOutputType.
Conceptually, this should let us do something like this to create recursive Object types.
GraphQLObjectType commentType = newObject()
                        .name("Comment")
                        .field(newFieldDefinition()
                                .type(() -> new GraphQLList(commentType))
                                .name("replies")
                                .build())
                        .build();

As I said, I'm no good at Java, and there may be issues, but I do hope that this helps add support for recursive Objects. We need it badly.

Apparently there's an error as I didn't account for the fact that Runnables can throw. I'm not sure what the solution here is. But I'll keep looking.

Closes, because solved already by TypeReferences. But thanks for creating a PR!


Use without jquery

Hello, thanks for your work on this. Is it possible to use this library without jquery? If not, would you recommend some alternative libraries to use?

Hi there! You can use this library with jquery or zepto, but one or the other is required. We can't endorse other libraries that we don't control for security/safety reasons, although I'm sure you'll find other libraries that fit the tools you're working with. Good luck!


Request processing: Give content-type an initial value and/or raise an error if no request was added

When using a request class generated bij openapi-suite associated with a POST, the creator of the  request message has to explicitly set the content-type.
I guess it may even required for GETs if your server is picky :)
This is confusing and not right if you view the generated Business Operation as a Black box.
Also, it leads to unexpected ill behavior in case of POST, as an empty body is submitted by the API
So the generated request class should either set the Content-Type as the initial value, like in
Property %ContentType As %String [ InitialExpression = "application/json" ];
And/or the LoadHttpRequestObject() method should quit with an error when no matching content-type is found, like in:
/// Load %Net.HttpRequest with this property object.
Method LoadHttpRequestObject(ByRef httpRequest As %Net.HttpRequest) As %Status
{
	Set sc = $$$OK
	Set httpRequest.ContentType = ..%ContentType
	Do httpRequest.SetHeader("accept", ..%Consume)
	Set ..%URL = $Replace(..%URL,"{did}", ..pathdid)
	If $Piece($$$LOWER(..%ContentType),";",1) = "application/json" {
           Do ..ContactInformation.%JSONExportToStream(httpRequest.EntityBody)
           return sc
        }
	return $SYSTEM.Status.Error($$$GeneralError, "No matching content-type found; found '" _ ..%ContentType _ "'")
}

Hi @isc-tstolker,
I'm ok to set %ContentType to application/json, today this is the most commonly used.
I assign the task to myself.

@isc-tstolker Finally, I set the InitialExpression with the first content type found for this request.
Even If application/json is commonly used, sometimes we use another.
If you are ok, we can close this issue.

Looks awesome, thanks!


Refactor: Move DEFAULT_DATA_PROCESSORS

Move DEFAULT_DATA_PROCESSORS from data_processors.py to __init__.py,
In response to comment by @yomach

Actually, I can't get the tests working. The problem is the following:

results/data_handler/data_handler.py needs DEFAULT_DATA_PROCESSORS for one of its class attributes.
DEFAULT_DATA_PROCESSORS is defined in results/data_handler/__init__.py
results/data_handler/__init__.py loads results/data_handler/data_handler.py
This leads to a circular import.

I can't see a way around it. @yomach if you can't either then I suggest to cancel this PR, and keep DEFAULT_DATA_PROCESSORS in data_processors.py

@nulinspiratie See my changes.
Also note, I've put all of the __all__ under the __init__.py, as it is more customary to do


Portfolio view. 3+ networks counter shows wrong

Description
Need to show 3rd network icon, instead of counter +1
Cases:

2 networks - shows 2 icons
3 networks - shows 3 icons
4 networks - shows 2 icons and icon with counter +2

https://www.figma.com/design/n8IgGoYgK0HT1zWDF5uNYy?node-id=585-25267#1046300126
Expected Behavior
Shows counter only for +2, for +1 shows icon itself
When 4 networks - shows counter +2
When 5 networks - shows counter +3
Actual Behavior
When 4 networks - shows counter +1
When 5 networks - shows counter +2
etc

Environment
https://github.com/novasamatech/nova-spektr/commit/1b7efc5e282ffc28d8a692e709eafa904f1bca07

Status verification: ✅


Add new static content

PR: [when the PR is created, put a link to it here.  DO NOT use the "linked PR" feature]
User Test Scripts: [when there are user test scripts available link them here]

Provide new web routes for any desired additional static content, and support the provision of that content as HTML.  Wire in any new navigation.
This issue may be broken down into several issues for areas of content development if this is convenient.
Acceptance Criteria
List the criteria which must be met for the issue to be considered complete

New static content incorporated into Imperial codebase

enable the CMS feature for the 23rd September meeting

Instance database will contain the static content, may need to add a process to backup and reload that content


Add plugin dir to fpath

I'm trying to install https://github.com/sindresorhus/pure using zplug but it requires adding the repo root directory to fpath. Can this be done using zplug?

Sorry, I was wrong, it does not require adding the repo root to fpath- I just installed it successfully with zplug (I was missing a dependency).

Sorry, I was wrong, it does not require adding the repo root to fpath- I just installed it successfully with zplug (I was missing a dependency).

Okay, are there other questions?

Maybe you can describe in general how to make changes to fpath using zplug if needed? if I want to autoload a function from another repo for example?
Thanks!

Okay I understand what you say probably. Would you give me more details? It may be necessary to implement the new features, if necessary. Because zplug doesn't have a method of changing fpath basically.

This can be closed, yes?

Yes

I'm having an issue with this.  I'm trying to install Gentoo Completions, but it does not work.  The completion files are added to the zcompdump file, but the src directory is not added to the fpath as it should be.
Is this something zplug should handle? or should I just use do:"fpath+=${ZPLUG_HOME}/repos/gentoo/gentoo-zsh-completions/src"?

Thank you for your report.
I'll reproduce your problem, please wait a little.

Sorry, the behavior is by design. But I added the workaround so please update zplug.

That worked.  Thank you!  Incredibly fast solution!
FYI,  I have forked Gentoo Completions and added a plugin.zsh file and created a pull request.

Nice work! If that *.plugin.zsh file exists, no of:src is require!

Thanks for the tip.  Both the old code (taken from the zsh-completions plugin.zsh) and the new code work for me.

@Triquetra You might already know this, but there is app-shells/gentoo-zsh-completions that you can install using Portage.


feat: added detection of Taskfile.yml via dev

Add taskfile.dev to environment

Pull Request Test Coverage Report for Build<PHONE_NUMBER>6
Details

0 of 3 (0.0%)  changed or added relevant lines in 1 file are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage increased (+1.2%) to 92.3%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/utils/devenv.ts
0
3
0.0%

Files with Coverage Reduction
New Missed Lines
%

src/utils/execve.ts
1
96.39%

Totals

Change from base Build<PHONE_NUMBER>5:
1.2%

Covered Lines:
1376

Relevant Lines:
1493

💛  - Coveralls