Make Conan Center Index work with Qt5 and Qt6

Making an issue to make it easier to track

@ericLemanissier I've started looking into running the browser too :rofl: and I will have to debug a bit, but I'm wondering about this bit in qt.conf
LibraryExecutables = bin/archdatadir/bin

should that maybe be
LibraryExecutables = bin/archdatadir/libexec

I will try to fill in the state here because I get confused
Qt5 - Windows 2019 - Release
Qt5 - Ubuntu 20.04 - Release
Qt5 - Mac 10 - Release
Qt5 - Mac 11 - Release
Qt5 - Mac 10 - Debug
Qt5 - Mac 11 - Debug (with recent XCode)
Qt6 - Windows 2019 - Release
Qt6 - Ubuntu 20.04 - Release
Qt6 - Mac 10 - Release
Qt6 - Mac 11 - Release
Qt6 - Mac 10 - Debug
Qt6 - Mac 11 - Debug (with recent XCode)

Qt5 Ubuntu fails to detect nss. Is the system libnss-dev package installed? Is the pkg_config_path variable set in you qt5 github action like it is in your qt6 github action?

Ah, no, the workflow I'm using here is the "Update Conan" workflow, which didn't have that - added it now - I'll add new links to the above

The Qt5 Mac 11 (Debug - I only have a debug build of it so far) build with new SDK needs the same patch Qt6 has

Since Qt6 Mac builds are timing out I'm going to do Mac 11 with new SDK locally - I gave it a go the other day and there was an issue around CMake targets - iirc it was because QtWebEngine is in Qt6 called QtWebEngineQuick. I'm doing new builds now though, so I'll post new logs.

Qt6 Windows failure seems to be this: https://bugreports.qt.io/browse/QTBUG-96533

Qt5 Windows is a mystery to me - it failed after 15 minutes

Qt5 Windows doesn't build in CLion for me because of the CXX thing: https://gist.github.com/patricia-gallardo/cb95187bd039be2e5df8e34dcdad64fe

Building new caches locally for Qt5 (master) on Windows and Ubuntu 20.04 - it will take awhile so they will probably be ready in the morning

Windows qt5 error is at https://github.com/turtlebrowser/turtlebrowser/runs/4076269823?check_suite_focus=true#step:11:2186
D:\a\turtlebrowser\turtlebrowser\release\short\cb4a06\1\qt5\qtbase\src\3rdparty\angle\src\libANGLE\renderer\d3d\d3d11\texture_format_table_autogen.cpp : fatal error C1083: Cannot open compiler generated file: '': Invalid argument
This error message is sometimes associated with some file paths too long. Is there a way to make it shorter?

This error message is sometimes associated with some file paths too long. Is there a way to make it shorter?

Yes, I think so.  One minute

Note to self - fix for 18.04 : remove pkgconf and install pkg-config

Going to try to make a list of changes needed to the Conan Center Index (as I understand things)

[ ] libexec in the qt.conf link
[ ] Patch missing from Qt5 recipe for MacOS11 with new SDK link
[ ] CLion build of Qt5 (CXX is set) link
[ ] QtWebEngineQuick cmake changes needed to link link

The second item should be solved with https://github.com/conan-io/conan-center-index/pull/7951, I think

Can you retry qt5 on Macos, now that the pr is merged ?

Can you retry qt5 on Macos, now that the pr is merged ?

It seems to have gotten past that error iirc - but it seems to get an error (log from local machine):
https://gist.githubusercontent.com/patricia-gallardo/d052400a589a08fdf32d36abcd685ebe/raw/348a32b22239d2b2092589ab990ca33ebfc62f89/gistfile1.txt

regarding the qt.conf issue. I can make a pull request on qt5 and qt6 to fix it. do you manage to start properly with only this change LibraryExecutables = bin/archdatadir/libexec ?

regarding the qt.conf issue. I can make a pull request on qt5 and qt6 to fix it. do you manage to start properly with only this change LibraryExecutables = bin/archdatadir/libexec ?

No, I don't think I managed to run yet, but I can try again. The QtWebEngineQuick cmake thing means I can't link TurtleBrowser in Qt6. I will have to try Qt5 on Linux or Windows, because Qt5 doesn't build locally on MacOS (I would have to try a different SDK).

the qtwebengine rename needs to be done also in the recipe, I'll made a PR for that.
LibraryExecutables seems to depend on the platform https://github.com/qt/qtbase/blob/efc1cd5799f692cfbc76bdfe1099d75141558c9b/src/corelib/global/qlibraryinfo.cpp#L500-L504, I'll make more research to confirm this.

I was wrong - in Linux in Qt5 this diff is all that I need to run TurtleBrowser
LibraryExecutables = bin/archdatadir/libexec

I can't test Windows for a couple of days because I'm going on a trip

https://github.com/ericLemanissier/turtlebrowser/actions/runs/1443988727. it's been a long time since all configuration have been green for so long. Fingers crossed it'll last until it misses disk space, or bails out after 6h....


Add async method

Codecov Report

Merging #33 into dev will increase coverage by 2.06%.
The diff coverage is 64.03%.

@@             Coverage Diff              @@
##                dev      #33      +/-   ##
============================================
+ Coverage     56.84%   58.90%   +2.06%
- Complexity      157      175      +18
============================================
  Files            26       26
  Lines          1564     1645      +81
  Branches        109      108       -1
============================================
+ Hits            889      969      +80
- Misses          603      611       +8
+ Partials         72       65       -7

Impacted Files
Coverage Δ
Complexity Δ

...a/com/webank/wecross/stub/fabric/FabricDriver.java
60.96% <60.78%> (-0.68%)
21.00 <4.00> (+6.00)
:arrow_down:

...m/webank/wecross/stub/fabric/FabricConnection.java
69.38% <91.66%> (+3.10%)
25.00 <6.00> (+6.00)

...va/com/webank/wecross/stub/fabric/FabricBlock.java
77.90% <0.00%> (-1.17%)
9.00% <0.00%> (-1.00%)

...ebank/wecross/stub/fabric/ChaincodeConnection.java
59.23% <0.00%> (+6.15%)
15.00% <0.00%> (+3.00%)

...wecross/stub/fabric/EndorsementPolicyAnalyzer.java
82.92% <0.00%> (+31.70%)
11.00% <0.00%> (+4.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1076cfb...3ea53ed. Read the comment docs.


idea: details from request in locals

Thank you for this module :tada:
Could the locals in the bugsnag notification give details about the request object ?

nevermind, scope has details about the request anyway


ENH: Add reporting workflow for BOLD fit

Changes proposed in this pull request

Sets up scaffolding for including reports for fitting, following smriprep example.
Adds basic SDC and coregistration reportlets.

TODO:

[x] Use nireports
[x] Add white matter contour and/or ribbon volume to show quality of SDC/coregistration

Results:

ds005 (2 runs, no SDC)
ds005 (1 run, SyN-SDC)
ds054 (2 run, phasediff)
ds210 (1 run, SyN-SDC)

Example reports:

ds005 (pending)
ds054
ds210

Generally we've used blue contours to indicate white matter boundaries, so I'll update that. I would also like to create a 3-way image that shows the boldref, the fieldmap reference mapped onto the boldref, and the fieldmap (in Hz) overlaid on the boldref. @oesteban Any thoughts on how to make that last happen?

I would also like to create a 3-way image that shows the boldref, the fieldmap reference mapped onto the boldref, and the fieldmap (in Hz) overlaid on the boldref. @oesteban Any thoughts on how to make that last happen?

Flickering through three frames is not possible ATM. We would need to refactor the JS code we embed in the SVGs.
However, if you don't mind the fieldmap overlay to be fixed in both (boldref and fmapref), then that should not be very difficult. And that plot makes a lot of sense to me.
WDYT?

Yeah, that sounds reasonable.

Updated the reports in the first post. This is done.

Where did the subject-specific section (# of anats, funcs, spaces, etc) of the reports go?

Made a copy of init_single_subject_wf() and probably didn't pull that over. Let me do that now.


CKS: retry if unable to drain node or unable to upgrade k8s node

Description
This PR tries to fix the upgrade of HA cluster, by retrying in case of

fail to drain kubernetes node
fail to upgrade kubernetes node

Types of changes

[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] New feature (non-breaking change which adds functionality)
[x] Bug fix (non-breaking change which fixes an issue)
[ ] Enhancement (improves an existing feature and functionality)
[ ] Cleanup (Code refactoring and cleanup, that may add test cases)
[ ] build/CI

Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale

[ ] Major
[ ] Minor

Bug Severity

[ ] BLOCKER
[ ] Critical
[x] Major
[ ] Minor
[ ] Trivial

Screenshots (if appropriate):
How Has This Been Tested?

How did you try to break this feature and the system with this change?

@blueorangutan package

Packaging result [SF]: ✔ el7 ✔ el8 ✔ el9 ✔ debian ✔ suse15. SL-JID 8132

@weizhouapache very few new tests 😜
Looks good. Need to wait for test results

@blueorangutan test matrix

@weizhouapache a [SL] Trillian-Jenkins matrix job (centos7 mgmt + xenserver71, rocky8 mgmt + vmware67u3, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests

[SF] Trillian test result (tid-8667)
Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
Total time taken: 58210 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8402-t8667-xenserver-71.zip
Smoke tests completed. 107 look OK, 2 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test
Result
Time (s)
Test File

test_01_deploy_vm_on_specific_host
Error
1.32
test_vm_deployment_planner.py

test_02_deploy_vm_on_specific_cluster
Error
2.36
test_vm_deployment_planner.py

test_03_deploy_vm_on_specific_pod
Error
2.43
test_vm_deployment_planner.py

test_04_deploy_vm_on_host_override_pod_and_cluster
Error
1.34
test_vm_deployment_planner.py

test_05_deploy_vm_on_cluster_override_pod
Error
2.33
test_vm_deployment_planner.py

test_02_cancel_host_maintenace_with_migration_jobs
Error
1786.37
test_host_maintenance.py

test_02_cancel_host_maintenace_with_migration_jobs
Error
1786.41
test_host_maintenance.py

[SF] Trillian test result (tid-8667) Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7 Total time taken: 58210 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8402-t8667-xenserver-71.zip Smoke tests completed. 107 look OK, 2 have errors, 0 did not run Only failed and skipped tests results shown below:
Test	Result	Time (s)	Test File
test_01_deploy_vm_on_specific_host	Error	1.32	test_vm_deployment_planner.py
test_02_deploy_vm_on_specific_cluster	Error	2.36	test_vm_deployment_planner.py
test_03_deploy_vm_on_specific_pod	Error	2.43	test_vm_deployment_planner.py
test_04_deploy_vm_on_host_override_pod_and_cluster	Error	1.34	test_vm_deployment_planner.py
test_05_deploy_vm_on_cluster_override_pod	Error	2.33	test_vm_deployment_planner.py
test_02_cancel_host_maintenace_with_migration_jobs	Error	1786.37	test_host_maintenance.py
test_02_cancel_host_maintenace_with_migration_jobs	Error	1786.41	test_host_maintenance.py

@shwstppr
looks good :smiley_cat:
Test to check for failure while tying to upgrade a Kubernetes cluster to a lower version ... === TestName: test_01_invalid_upgrade_kubernetes_cluster | Status : SUCCESS ===
ok
Test to deploy a new Kubernetes cluster and upgrade it to newer version ... === TestName: test_02_upgrade_kubernetes_cluster | Status : SUCCESS ===
ok
Test to deploy a new Kubernetes cluster and check for failure while tying to scale it ... === TestName: test_03_deploy_and_scale_kubernetes_cluster | Status : SUCCESS ===
ok
Test to enable autoscaling a Kubernetes cluster ... === TestName: test_04_autoscale_kubernetes_cluster | Status : SUCCESS ===
ok
Test to deploy a new Kubernetes cluster ... === TestName: test_05_basic_lifecycle_kubernetes_cluster | Status : SUCCESS ===
ok
Test to delete an existing Kubernetes cluster ... === TestName: test_06_delete_kubernetes_cluster | Status : SUCCESS ===
ok
Test to upgrade a HA Kubernetes cluster to newer version ... === TestName: test_08_10_upgrade_kubernetes_ha_cluster | Status : SUCCESS ===
ok
Test to upgrade a HA Kubernetes cluster to newer version ... === TestName: test_08_11_upgrade_kubernetes_ha_cluster | Status : SUCCESS ===
ok
Test to upgrade a HA Kubernetes cluster to newer version ... === TestName: test_08_12_upgrade_kubernetes_ha_cluster | Status : SUCCESS ===
ok
Test to upgrade a HA Kubernetes cluster to newer version ... === TestName: test_08_13_upgrade_kubernetes_ha_cluster | Status : SUCCESS ===
ok
Test to upgrade a HA Kubernetes cluster to newer version ... === TestName: test_08_14_upgrade_kubernetes_ha_cluster | Status : SUCCESS ===
ok
Test to upgrade a HA Kubernetes cluster to newer version ... === TestName: test_08_15_upgrade_kubernetes_ha_cluster | Status : SUCCESS ===
ok
Test to upgrade a HA Kubernetes cluster to newer version ... === TestName: test_08_16_upgrade_kubernetes_ha_cluster | Status : SUCCESS ===
ok
Test to upgrade a HA Kubernetes cluster to newer version ... === TestName: test_08_17_upgrade_kubernetes_ha_cluster | Status : SUCCESS ===
ok
Test to upgrade a HA Kubernetes cluster to newer version ... === TestName: test_08_18_upgrade_kubernetes_ha_cluster | Status : SUCCESS ===
ok
Test to upgrade a HA Kubernetes cluster to newer version ... === TestName: test_08_19_upgrade_kubernetes_ha_cluster | Status : SUCCESS ===
ok
Test to upgrade a HA Kubernetes cluster to newer version ... === TestName: test_08_2_upgrade_kubernetes_ha_cluster | Status : SUCCESS ===
ok
Test to upgrade a HA Kubernetes cluster to newer version ... === TestName: test_08_3_upgrade_kubernetes_ha_cluster | Status : SUCCESS ===
ok
Test to upgrade a HA Kubernetes cluster to newer version ... === TestName: test_08_4_upgrade_kubernetes_ha_cluster | Status : SUCCESS ===
ok
Test to upgrade a HA Kubernetes cluster to newer version ... === TestName: test_08_5_upgrade_kubernetes_ha_cluster | Status : SUCCESS ===
ok
Test to upgrade a HA Kubernetes cluster to newer version ... === TestName: test_08_6_upgrade_kubernetes_ha_cluster | Status : SUCCESS ===
ok
Test to upgrade a HA Kubernetes cluster to newer version ... === TestName: test_08_7_upgrade_kubernetes_ha_cluster | Status : SUCCESS ===
ok
Test to upgrade a HA Kubernetes cluster to newer version ... === TestName: test_08_8_upgrade_kubernetes_ha_cluster | Status : SUCCESS ===
ok
Test to upgrade a HA Kubernetes cluster to newer version ... === TestName: test_08_9_upgrade_kubernetes_ha_cluster | Status : SUCCESS ===
ok
Test to upgrade a HA Kubernetes cluster to newer version ... === TestName: test_08_upgrade_kubernetes_ha_cluster | Status : SUCCESS ===
ok
Test to deploy a Kubernetes cluster on VPC ... === TestName: test_10_vpc_tier_kubernetes_cluster | Status : SUCCESS ===
ok

----------------------------------------------------------------------
Ran 26 tests in 19677.224s

OK

[SF] Trillian test result (tid-8669)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 71121 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8402-t8669-kvm-centos7.zip
Smoke tests completed. 106 look OK, 3 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test
Result
Time (s)
Test File

test_08_9_upgrade_kubernetes_ha_cluster
Failure
881.05
test_kubernetes_clusters.py

test_08_migrate_vm
Error
0.05
test_vm_life_cycle.py

test_hostha_kvm_host_degraded
Error
699.05
test_hostha_kvm.py

test_hostha_kvm_host_fencing
Error
683.27
test_hostha_kvm.py

@blueorangutan test matrix

@weizhouapache a [SL] Trillian-Jenkins matrix job (centos7 mgmt + xenserver71, rocky8 mgmt + vmware67u3, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests

[SF] Trillian test result (tid-8671)
Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
Total time taken: 57476 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8402-t8671-xenserver-71.zip
Smoke tests completed. 108 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test
Result
Time (s)
Test File

test_01_deploy_vm_on_specific_host
Error
2.26
test_vm_deployment_planner.py

test_02_deploy_vm_on_specific_cluster
Error
2.24
test_vm_deployment_planner.py

test_03_deploy_vm_on_specific_pod
Error
1.25
test_vm_deployment_planner.py

test_04_deploy_vm_on_host_override_pod_and_cluster
Error
2.30
test_vm_deployment_planner.py

test_05_deploy_vm_on_cluster_override_pod
Error
2.26
test_vm_deployment_planner.py

@weizhouapache do we need to move some of the test cases to a component test? Taking more than 5.5h now
shwstppr@shwstppr-zbook:~/Downloads|⇒  grep "kubernetes" pr7345-t8662-xenserver-71/MarvinLogs/tests-time.txt
test_kubernetes_clusters.py: 2738 seconds
test_kubernetes_supported_versions.py: 65 seconds
shwstppr@shwstppr-zbook:~/Downloads|⇒  grep "kubernetes" pr8402-t8671-xenserver-71/MarvinLogs/tests-time.txt
test_kubernetes_clusters.py: 20429 seconds
test_kubernetes_supported_versions.py: 65 seconds

[SF] Trillian test result (tid-8673)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 65144 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8402-t8673-kvm-centos7.zip
Smoke tests completed. 107 look OK, 2 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test
Result
Time (s)
Test File

test_08_migrate_vm
Error
0.06
test_vm_life_cycle.py

test_hostha_kvm_host_degraded
Error
702.24
test_hostha_kvm.py

test_hostha_kvm_host_fencing
Error
684.15
test_hostha_kvm.py

@weizhouapache do we need to move some of the test cases to a component test? Taking more than 5.5h now
shwstppr@shwstppr-zbook:~/Downloads|⇒  grep "kubernetes" pr7345-t8662-xenserver-71/MarvinLogs/tests-time.txt
test_kubernetes_clusters.py: 2738 seconds
test_kubernetes_supported_versions.py: 65 seconds
shwstppr@shwstppr-zbook:~/Downloads|⇒  grep "kubernetes" pr8402-t8671-xenserver-71/MarvinLogs/tests-time.txt
test_kubernetes_clusters.py: 20429 seconds
test_kubernetes_supported_versions.py: 65 seconds

@shwstppr
The last commit  is only used for testing..
I will revert it  af93915634b2cdfbbb199737a0b0e75dd50fc7bd

@blueorangutan test matrix

@weizhouapache a [SL] Trillian-Jenkins matrix job (centos7 mgmt + xenserver71, rocky8 mgmt + vmware67u3, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests

[SF] Trillian test result (tid-8672)
Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server r8
Total time taken: 73330 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8402-t8672-vmware-67u3.zip
Smoke tests completed. 108 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test
Result
Time (s)
Test File

test_08_15_upgrade_kubernetes_ha_cluster
Failure
757.08
test_kubernetes_clusters.py

test_08_18_upgrade_kubernetes_ha_cluster
Failure
3665.09
test_kubernetes_clusters.py

test_08_19_upgrade_kubernetes_ha_cluster
Failure
0.12
test_kubernetes_clusters.py

test_08_2_upgrade_kubernetes_ha_cluster
Failure
0.13
test_kubernetes_clusters.py

test_08_3_upgrade_kubernetes_ha_cluster
Failure
0.14
test_kubernetes_clusters.py

test_08_4_upgrade_kubernetes_ha_cluster
Failure
0.12
test_kubernetes_clusters.py

test_08_5_upgrade_kubernetes_ha_cluster
Failure
0.12
test_kubernetes_clusters.py

test_08_6_upgrade_kubernetes_ha_cluster
Failure
0.11
test_kubernetes_clusters.py

test_08_7_upgrade_kubernetes_ha_cluster
Failure
0.12
test_kubernetes_clusters.py

test_08_8_upgrade_kubernetes_ha_cluster
Failure
0.12
test_kubernetes_clusters.py

test_08_9_upgrade_kubernetes_ha_cluster
Failure
0.12
test_kubernetes_clusters.py

test_08_upgrade_kubernetes_ha_cluster
Failure
0.13
test_kubernetes_clusters.py

test_10_vpc_tier_kubernetes_cluster
Failure
72.90
test_kubernetes_clusters.py

ContextSuite context=TestKubernetesCluster>:teardown
Error
132.76
test_kubernetes_clusters.py

[SF] Trillian test result (tid-8676)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 56401 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8402-t8676-kvm-centos7.zip
Smoke tests completed. 107 look OK, 2 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test
Result
Time (s)
Test File

test_08_2_upgrade_kubernetes_ha_cluster
Failure
481.48
test_kubernetes_clusters.py

test_08_3_upgrade_kubernetes_ha_cluster
Failure
3613.79
test_kubernetes_clusters.py

test_08_4_upgrade_kubernetes_ha_cluster
Failure
0.05
test_kubernetes_clusters.py

test_08_5_upgrade_kubernetes_ha_cluster
Failure
0.05
test_kubernetes_clusters.py

test_08_6_upgrade_kubernetes_ha_cluster
Failure
0.05
test_kubernetes_clusters.py

test_08_7_upgrade_kubernetes_ha_cluster
Failure
0.05
test_kubernetes_clusters.py

test_08_8_upgrade_kubernetes_ha_cluster
Failure
0.06
test_kubernetes_clusters.py

test_08_9_upgrade_kubernetes_ha_cluster
Failure
0.06
test_kubernetes_clusters.py

test_08_upgrade_kubernetes_ha_cluster
Failure
0.05
test_kubernetes_clusters.py

test_10_vpc_tier_kubernetes_cluster
Failure
46.15
test_kubernetes_clusters.py

ContextSuite context=TestKubernetesCluster>:teardown
Error
95.56
test_kubernetes_clusters.py

test_08_migrate_vm
Error
45.06
test_vm_life_cycle.py

[SF] Trillian test result (tid-8674)
Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
Total time taken: 60296 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8402-t8674-xenserver-71.zip
Smoke tests completed. 107 look OK, 2 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test
Result
Time (s)
Test File

test_01_deploy_vm_on_specific_host
Error
0.07
test_vm_deployment_planner.py

test_02_deploy_vm_on_specific_cluster
Error
0.05
test_vm_deployment_planner.py

test_03_deploy_vm_on_specific_pod
Error
0.07
test_vm_deployment_planner.py

test_04_deploy_vm_on_host_override_pod_and_cluster
Error
0.08
test_vm_deployment_planner.py

test_05_deploy_vm_on_cluster_override_pod
Error
0.06
test_vm_deployment_planner.py

test_02_cancel_host_maintenace_with_migration_jobs
Error
1942.32
test_host_maintenance.py

test_02_cancel_host_maintenace_with_migration_jobs
Error
1942.37
test_host_maintenance.py

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan test rocky8 kvm-rocky8

@weizhouapache a [SL] Trillian-Jenkins test job (rocky8 mgmt + kvm-rocky8) has been kicked to run smoke tests

[SF] Trillian test result (tid-8943)
Environment: kvm-rocky8 (x2), Advanced Networking with Mgmt server r8
Total time taken: 72166 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8402-t8943-kvm-rocky8.zip
Smoke tests completed. 109 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test
Result
Time (s)
Test File

test_01_migrate_VM_and_root_volume
Error
90.53
test_vm_life_cycle.py

test_02_migrate_VM_with_two_data_disks
Error
55.88
test_vm_life_cycle.py

test_08_migrate_vm
Error
50.25
test_vm_life_cycle.py

@blueorangutan package

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Packaging result [SF]: ✔ el7 ✔ el8 ✔ el9 ✔ debian ✔ suse15. SL-JID 8446

@blueorangutan test rocky8 kvm-rocky8

@weizhouapache a [SL] Trillian-Jenkins test job (rocky8 mgmt + kvm-rocky8) has been kicked to run smoke tests

[SF] Trillian test result (tid-8952)
Environment: kvm-rocky8 (x2), Advanced Networking with Mgmt server r8
Total time taken: 82863 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8402-t8952-kvm-rocky8.zip
Smoke tests completed. 110 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test
Result
Time (s)
Test File

[SF] Trillian test result (tid-8958)
Environment: kvm-rocky8 (x3), Advanced Networking with Mgmt server r8
Total time taken: 62988 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8402-t8958-kvm-rocky8.zip
Smoke tests completed. 109 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test
Result
Time (s)
Test File

test_01_migrate_VM_and_root_volume
Error
83.32
test_vm_life_cycle.py

test_02_migrate_VM_with_two_data_disks
Error
52.78
test_vm_life_cycle.py

test_01_secure_vm_migration
Error
243.32
test_vm_life_cycle.py

test_02_unsecure_vm_migration
Error
243.25
test_vm_life_cycle.py

test_03_secured_to_nonsecured_vm_migration
Error
243.26
test_vm_life_cycle.py

test_04_nonsecured_to_secured_vm_migration
Error
243.29
test_vm_life_cycle.py

test_08_migrate_vm
Error
47.04
test_vm_life_cycle.py

@rohityadavcloud a [SL] Jenkins job has been kicked to build packages. It will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Packaging result [SF]: ✔ el7 ✔ el8 ✔ el9 ✔ debian ✔ suse15. SL-JID 8520

@blueorangutan test rocky8 kvm-rocky8

@weizhouapache a [SL] Trillian-Jenkins test job (rocky8 mgmt + kvm-rocky8) has been kicked to run smoke tests

Merging based on 2 approvals and perfect smoke tests result.
19:54:06 === TestName: test_08_10_upgrade_kubernetes_ha_cluster | Status : SUCCESS ===
19:54:06
19:54:06 === TestName: test_08_11_upgrade_kubernetes_ha_cluster | Status : SUCCESS ===
19:54:06
19:54:06 === TestName: test_08_12_upgrade_kubernetes_ha_cluster | Status : SUCCESS ===
19:54:06
19:54:06 === TestName: test_08_13_upgrade_kubernetes_ha_cluster | Status : SUCCESS ===
19:54:06
19:54:06 === TestName: test_08_14_upgrade_kubernetes_ha_cluster | Status : SUCCESS ===
19:54:06
19:54:06 === TestName: test_08_15_upgrade_kubernetes_ha_cluster | Status : SUCCESS ===
19:54:06
19:54:06 === TestName: test_08_16_upgrade_kubernetes_ha_cluster | Status : SUCCESS ===
19:54:06
19:54:06 === TestName: test_08_17_upgrade_kubernetes_ha_cluster | Status : SUCCESS ===
19:54:06
19:54:06 === TestName: test_08_18_upgrade_kubernetes_ha_cluster | Status : SUCCESS ===
19:54:06
19:54:06 === TestName: test_08_19_upgrade_kubernetes_ha_cluster | Status : SUCCESS ===
19:54:06
19:54:06 === TestName: test_08_2_upgrade_kubernetes_ha_cluster | Status : SUCCESS ===
19:54:06
19:54:06 === TestName: test_08_3_upgrade_kubernetes_ha_cluster | Status : SUCCESS ===
19:54:06
19:54:06 === TestName: test_08_4_upgrade_kubernetes_ha_cluster | Status : SUCCESS ===
19:54:06
19:54:06 === TestName: test_08_5_upgrade_kubernetes_ha_cluster | Status : SUCCESS ===
19:54:06
19:54:06 === TestName: test_08_6_upgrade_kubernetes_ha_cluster | Status : SUCCESS ===
19:54:06
19:54:06 === TestName: test_08_7_upgrade_kubernetes_ha_cluster | Status : SUCCESS ===
19:54:06
19:54:06 === TestName: test_08_8_upgrade_kubernetes_ha_cluster | Status : SUCCESS ===
19:54:06
19:54:06 === TestName: test_08_9_upgrade_kubernetes_ha_cluster | Status : SUCCESS ===
19:54:06
19:54:06 === TestName: test_08_upgrade_kubernetes_ha_cluster | Status : SUCCESS ===


Refactor SearchPage.test.tsx and fix DateModifiedSelector

Checklist

[x] the contributor license agreement is signed
[x] commit message follows commit guidelines
[x] tests are included

Description of change

First and foremost this was about refactoring SearchPage.test.tsx to use React Testing Library (RTL) rather than Enzyme. As part of doing this, there was a need to understand how to interact with MUI <Select> components. To build this understanding SearchPagination.test.tsx provided a good platform and so it was also refactored.
Fixing SearchPage.test.tsx highlighted that it was returning a false positive for selecting a quick date via the DateModifiedSelector component. This was broken recently due to the work done in #2202 . It feels this was a good example of the benefits of the move to RTL.
With the refactor I also brought in the user-events module, and then have attempted to use this in most places - there are more which later can be refactored to do the same.
There was one test I had to drop, and that was the checking for the display of the progress bar on loading results. This relied on the Enzyme way of component.update() to check before and after, but I think in RTL we more so need to do real-time and I couldn't quite unravel it. However we do have a Storybook story for it, and see it's non-critical I think this is fine.

That's odd. The GHA build_import_export_tool job failed due to missing SBT dep - which is obviously nothing to do with this. I'm going to ignore that. (Especially seeing the build_and_check passed which actually does the TS side of things, including running the tests.)

Hmmm, flaky GHA newUI failure: com.tle.webtests.test.myresources.MyResourcesTest -> testAddMyResource.
I'm going to address some feedback, so I'll wont retry yet.

Alright. Fixed up the comments. If you're happy, and if I can manage a green build, I'll get this merged in. :crossed_fingers:


mail client

Using a Limilabs.client and the email auth2 prox is listening for auth requests, but not intercepting authentication requests and there are no pending authorization requests to approve. Any suggestions are greatly appreciated! Thank You!

emailproxy.log
Thanks for the reply back. Attached is the log. It does not appear to have much to it

There is no evidence in this log of your client actually connecting to the proxy. My guess is that you have not correctly set up localhost on port 995 as the email server in your client.
If you definitely have already done this, I would suggest changing the port used by the proxy to, say, 1995 (as in the example configuration) just in case the issue is being caused by the proxy not being allowed to open port 995 and for some reason not being able to detect this (ports below 1024 are normally marked as privileged).

Thanks for the response back. Unfortunately, I am dealing with more of a service, than a client. The service allows me to define mail accounts in a gui format for authenticating O365 mailboxes to pull in mail items.  On the defined mail account, I have also reverted back to using port 1995, but still unable to connect with the proxy. Probably because I am using a s/w vendor defined email receiver service and not necessarily a client.  All though it does utilize a Limilabs client through a mail.dll.

It shouldn't make any difference what the end application is as long as it uses IMAP, POP or SMTP. But you certainly do need to be able to set the server host name as well as its port. I'd recommend getting support from the developer of the service you are using if you're still not able to get it set up.
I'm going to close this issue for now as it is not a problem with the proxy and I don't think there's anything else I can suggest.


Update type definitions for RatingColumn::$width

Description
Removed width Method:

The width method has been completely removed from Yepsua\Filament\Tables\Components\RatingColumn as it was redundant. The method is identical to the one provided in the base class through the HasWidth trait.

Updated Type Definitions:

Adjusted the type definitions for the $width property in Yepsua\Filament\Tables\Components\RatingColumn to ensure compatibility with the base class Filament\Tables\Columns\Column. The types now correctly reflect Closure|string|int|null.

Reason for Changes

Redundancy Removal: Removing the duplicate width method simplifies the code. The base class already provides the necessary functionality.
Type Compatibility: The type definitions were inconsistent with the base class, leading to errors. This update ensures that the types are aligned, preventing such errors. (Especially when using strict types.)

Testing

Manual Testing: Verified that removing the method does not affect functionality, as the base class's method is the same.
Type Checking: Ensured that the updated type definitions eliminate the previously encountered errors.

@renderse7en was facing the same issue in #19

Hi Omar @oyepez003 ! Can you please look at this.

@avinmaster
If you encountered the same issue, you may use my branch as dependency.
"repositories": [
    {
        "type": "vcs",
        "url": "https://github.com/Tschucki/filament-rating-field.git"
    }
],

@Tschucki Thanks for sharing!
A new version has been published: https://github.com/yepsua/filament-rating-field/releases/tag/v0.5.0

@Tschucki , there are something missing, need also to update getWidth() function return type to ?string to be compatible


Update main with dev work

Newsroom is functional and a little pretty atm. It is likely worth it now to pull into main.

I think we're lookin not too bad so gonna merge.
Next I'll set up the suggestion engine interface so @spencer-dale you can have some fun :)


What is the streaming URL?

I can get the RTSP stream to work in HomeAssistant but cannot attach to it via VLC or SecuritySpy.  I had SecuritySpy test every camera profile it knows (which is quite a few) and I can see all the errors in the RTSP log but none of them connect to the stream, so I can see the conversation but nothing streams back.
What is the URL that I should use to access the stream?  I tried rtsp://home_assistant_ip:8554 by itself but it doesn't do the trick so I presume I need a path on it.

There is a sensor called streaming_source, you can use it

Thanks for the suggestion @fuatakgun, I had noticed that once before but it hadn't registered with me where to find it again after when I saw it since it is only active when the EUFY streaming has been turned on.


Remove the deprecated test for deprecated_disable_overprovisioning

I plan to do the related clean-up work for illegal use of hidden_envoy_deprecated_ V2 check(in source/common/protobuf/utility.cc where this error message is thrown) in a separate PR.
Signed-off-by: Tianyu Xia<EMAIL_ADDRESS>
Risk Level: LOW
Testing: local unit test, CI

/assign @htuch
PLAT. Thanks!

@tyxia before merging, can you explain why the split here? Generally prefer to group related changes unless there is some compelling reason.

@tyxia before merging, can you explain why the split here? Generally prefer to group related changes unless there is some compelling reason.

Hi  @htuch , Thanks for the information. The reason I am doing clean-up in #17924 is because 1) I feel this PR is just for disable_overprovisioning and the other one has board scope of change 2) The other one is a bit riskier than this PR and I am working on to fix all the CI (still in draft mode :) )
But if merging them in PR is preferred, please just let me know. I can definitely do it. Thanks!

Sure, let's just merge it.


New ticker/prompt in 0.12 causing CPU load on terminal emulator

Testing 0.12.0-RC2-38-029986, Windows 11 x64 with millw.bat.
When running mill -w someTask, the CPU load on my terminal emulator (alacritty) is increased when compared to mill --disable-prompt -w someTask. This is best seen when the task finishes executing and is in idle/waiting state monitoring for any inputs to change. The system is otherwise idle but it seems the prompt is producing a lot of updates to update the time counter (?), causing unnecessary load on the terminal emulator. It can use up to 50% of one core, so the overhead is significant (and my laptop ramps up because of it)
The increased CPU load is the same if I run my desktop at 60Hz or 240Hz, which I think means the load on the terminal emulator is the same and caused by Mill (the producer of this output).

@farnoy could you hook up jprofiler to the process to see what its doing? or send me the profile so i can take a look

The CPU usage is not in the mill process, but the terminal emulator. I can't reproduce this on the Windows Terminal, so it may be an issue with alacritty. Is there some non-standard output by Mill, or is it just outputting \r$newContent every second?

If I'm not mistaken it does a bit more than that due to the multi line prompt: it does LEFT_9999 UP_PromptHeight and redraws the prompt 10 times a second. This can probably be optimized. I wonder if the 9999 is causing issues

@farnoy I don't have a windows machine handy, but if you do you can try changing this 9999 (https://github.com/com-lihaoyi/mill/blob/e0a2c93bfbc7bf68a71ddbc0c52afbb14e73e6f2/main/util/src/mill/util/PromptLogger.scala#L291) to 999 or something, use ./mill installLocal to create a new binary, and seeing if it exhibits the same issue

I couldn't reproduce this with the latest tip, and in fact RC3 has already fixed it. I bisected RC2 against RC3 (based on tags in git, RC2 shows up as something like RC2-38-xxx in Mill itself).
The first commit that fixed this as far as I can tell is 49a28110a6153b0f77ca71c3538c325b5d7cdd17. So no new issue after all, I'm just upgrading my project to use RC3 (ty for publishing)

Rather, the issue still exists as the new progress prompt is placing extra load on this specific terminal emulator, but after that commit, at least it's not draining cycles when it's idle and waiting for inputs to change.


rodio

isn't this a re-brand of Rodio with a few changes?

Not really.
While they do share the same audio decoding dependencies, they don't serve the same purpose at all. Rodio is an audio playback engine; this crate is just a sample converter (which can't play sounds). Ideally, you would use this crate as part of a playback engine's backend to load sound data. Since I just wanted something to load + convert samples, I wrote this crate.
Closing this issue for now.

Not really.
While they do share the same audio decoding dependencies, they don't serve the same purpose at all. Rodio is an audio playback engine; this crate is just a sample converter (which can't play sounds). Ideally, you would use this crate as part of a playback engine's backend to load sound data. Since I just wanted something to load + convert samples, I wrote this crate.
Closing this issue for now.

Nope.
While they do share the same audio decoding dependencies, they don't serve the same purpose at all. Rodio is an audio playback engine; this crate is just a sample converter (which can't play sounds). Ideally, you would use this crate as part of a playback engine's backend to load sound data. Since I just wanted something to load + convert samples, I wrote this crate.
Closing this issue for now.

Nope.
While they do share the same audio decoding dependencies, they don't serve the same purpose at all. Rodio is an audio playback engine; this crate is just a sample converter (which can't play sounds). Ideally, you would use this crate as part of a playback engine's backend to load sound data. Since I just wanted something to load + convert samples, I wrote this crate.
Closing this issue for now.


How to using a sitemap to indicate alternate language pages

I have using this composer for my project but I don't know how to add xhtml:link into sitemap, please help me when you have time, thanks a lot!
https://support.google.com/webmasters/answer/2620865?hl=en

It seems to be non-standard sitemap and isn't currently supported.

Thank for answer, please see more information from here https://webmasters.googleblog.com/2012/05/multilingual-and-multinational-site.html

Duplicate of #14


Change "expanded" icon in treeview from downwards-looking-arrow to left-top-corner

Having the tight treeview layout is awesome for saving place. Here a supereasy but powerful change to make the tiny layout even more readable.
Currently the layout uses the downwards-looking-arrow if a section is expanded.

My suggestion with a left-top-corner icon looks like so

At least for me, this so much better readable ;-)
VSCode version: 1.41.1

product icons will be user customizable with https://github.com/microsoft/vscode/issues/92791

thanks @aeschli
nice to have this customaizable, but don't you think that would also be a good default?
One of the big advantages of vscode is that it comes with very good defaults, hence I be glad if we can reopen this ticket.

Assigning to @misolori

Thanks for the suggestion. We used to use the angled tree icon:

But I don't think I've ever seen an example like your screenshot shows. I would say that this still falls under product icon customization (see https://github.com/microsoft/vscode/issues/79130) as it comes down to personal preference since everyone has their own interpretation of what "good" means for icons. Will close this as duplicate.


Requirements_Backend is not respecting async/defer explicitly set to false

Affected Version
4.4.4
Description
Due to two wrong checks (async, defer) any value set for the options will be treated like a true. The following change should solve this issue:
Old:
isset($options['async']) && isset($options['async']) == true

New:
isset($options['async']) && $options['async'] == true

I thought async and defer were both boolean attributes? What other value are you trying to set?

Yes, it doesn't matter which value you are setting, as any value is treated like true (as there is checked if isset == true and not the value itself). So in my case I'm setting them to false but this is treated as true.

Oh I see, we’re checking isset twice for some reason...
isset($options['async']) && $options['async']

should be fine, we can just lose the == true. Fancy submitting a PR?

PR #9309 created

Fixed in https://github.com/silverstripe/silverstripe-framework/pull/9309


Fix broken external links in scg pico pages

In the Linkchecker folder there are scripts to identify and triage broken external links, and a python script to replace broken links by the text titles only.
Need to continue the clean up.
Take care to check which links can be repaired as opposed to being simple removed.

This is a duplicate of issue #6


delete unnecessary .c/.cpp files to avoid compile failure.

delete unnecessary .c/.cpp files to avoid compile failure when running build.py  on other machines for nms and pycocotools compile.

thanks!


Circular structure in context crash the machine

Hello,
I have a machine where I store a rest client inside the context but it's seems to have circular structure and this crash the xstate-ninja and then the machine;
Uncaught (in promise) TypeError: Converting circular structure to JSON
    --> starting at object with constructor 'Client'
    |     property 'admins' -> object with constructor 'AdminService'
    --- property 'client' closes the circle
    at JSON.stringify (<anonymous>)
    at new H (xstate-ninja.js:181:36)
    at xstate-ninja.js:398:17
    at Interpreter2.update (interpreter.js:452:9)
    at interpreter.js:106:15
    at Scheduler2.process (scheduler.js:65:7)
    at Scheduler2.schedule (scheduler.js:44:10)
    at Interpreter2.send (interpreter.js:100:23)
    at _a2.id.id (interpreter.js:1135:15)
H @ xstate-ninja.js:181
(anonyme) @ xstate-ninja.js:398
Interpreter2.update @ interpreter.js:452
(anonyme) @ interpreter.js:106
Scheduler2.process @ scheduler.js:65
Scheduler2.schedule @ scheduler.js:44
Interpreter2.send @ interpreter.js:100
_a2.id.id @ interpreter.js:1135

Machine used ;
import { assign, createMachine } from 'xstate'
import PocketBase from 'pocketbase'
import { produce } from 'immer'

export interface StoreContext {
  pocketBaseUrl: string
  pocketBase?: PocketBase
}

export const storeMachine = createMachine({
  id: 'store',

  predictableActionArguments: true,
  tsTypes: {} as import('./store.typegen').Typegen0,

  schema: {
    context: {} as StoreContext,
    events: {} as {
      type: 'Add gateway'
    },
    services: {} as {
      connectToPocketBase: {
        data: PocketBase
      }
    },
  },

  context: {
    pocketBaseUrl: import.meta.env.VITE_POCKETBASE_URL,
  },

  states: {
    init: {
      after: {
        500: 'connecting',
      },
    },

    connecting: {
      invoke: {
        src: 'connectToPocketBase',
        onDone: {
          target: 'online',
          actions: 'usePocketBase',
        },
        onError: 'offline',
      },
    },

    online: {},
    offline: {},
  },

  initial: 'init',
},
{
  actions: {
    usePocketBase: assign({
      pocketBase: (context, event) => produce(context.pocketBase, (draft) => {
        draft = event.data
      }),
    }),
  },
  services: {
    connectToPocketBase: async (context) => {
      const client = new PocketBase(context.pocketBaseUrl)
      const health = await client.health.check()
      if (health.code === 200)
        return client
      else
        throw new Error('Could not connect to PocketBase')
    },
  },
})

With XStateNinja registred I am stuck in the connecting state and without I get to the online state

Yes, I have just encountered a related problem. This has to do with the serialization of events done by xstate-ninja prior to sending them to the browser extension. There is a sanitizeObject function which tries to strip the event objects off the unsafe properties, but apparently it fails.
https://github.com/rlaffers/xstate-ninja/blob/master/packages/xstate-ninja-core/src/utils.ts#L145
We need to think about a better strategy.

A hotfix would be always stripping away some properties, e.g. those starting with _. E.g.:
export function sanitizeObject<T extends Record<string, any>>(obj: T): T {
  const result: Record<string, any> = {}
  for (const key in obj) {
    if (key[0] === '_') {
      // skip properties starting with _
      result[key] = '<stripped>'
      continue
    }

I'm not a big fan of doing this, because it requires a change in the machine configuration (prefixing unsafe event props with "_"). What do you think?

Of course, it would be also possible to traverse everything and detect circular references, but this may be costly.

A hotfix would be always stripping away some properties, e.g. those starting with _. E.g.:
export function sanitizeObject<T extends Record<string, any>>(obj: T): T {
  const result: Record<string, any> = {}
  for (const key in obj) {
    if (key[0] === '_') {
      // skip properties starting with _
      result[key] = '<stripped>'
      continue
    }

I'm not a big fan of doing this, because it requires a change in the machine configuration (prefixing unsafe event props with "_"). What do you think?

I can't control the library so it's hard to do, maybe limit the depth of the context or query one level when expending in the extension

Indeed. I will implement a proper function for filtering out circular refs.

@Zehir Try upgrading to<EMAIL_ADDRESS>

Hello @rlaffers I still have the error;
xstate-ninja.js:114 Uncaught (in promise) TypeError: Converting circular structure to JSON
    --> starting at object with constructor 'Client'
    |     property 'recordServices' -> object with constructor 'Object'
    |     property 'user' -> object with constructor 'RecordService'
    --- property 'client' closes the circle
    at JSON.stringify (<anonymous>)
    at C (xstate-ninja.js:114:17)
    at new ee (xstate-ninja.js:266:19)
    at xstate-ninja.js:482:17
    at Interpreter2.update (interpreter.js:452:9)
    at interpreter.js:106:15
    at Scheduler2.process (scheduler.js:65:7)
    at Scheduler2.schedule (scheduler.js:44:10)
    at Interpreter2.send (interpreter.js:100:23)
    at Interpreter2.inspectSend [as send] (browser.js:126:24)

@Zehir Can you perhaps set up a Codesandbox for this? Or else provide what is logged in the JS console?
Just set up logging with:
import xstateNinja, { LogLevels } from 'xstate-ninja'
xstateNinja({ logLevel: LogLevels.debug })

The last "actor updated" log should log a state snapshot which should contain an event. Let's look at it.

In the meantime I will release a hotfix which wraps serialization in a try-catch block, so there are no exceptions.

@Zehir Can you perhaps set up a Codesandbox for this? Or else provide what is logged in the JS console? Just set up logging with:
import xstateNinja, { LogLevels } from 'xstate-ninja'
xstateNinja({ logLevel: LogLevels.debug })

The last "actor updated" log should log a state snapshot which should contain an event. Let's look at it.

You can use my repo;
https://github.com/deconz-community/ddf-tools
You will need to start both ;
pnpm dev:store
pnpm dev:toolbox

Then open the page http://localhost:4000/ddf-tools/sandbox

Hmm, I cannot reproduce this. The connectToPocketBase service fails (the promise is rejected). I guess that's because I have no pocketBaseUrl in my env.

New version with serialization wrapped: https://github.com/rlaffers/xstate-ninja/releases/tag/v1.3.6

Hmm, I cannot reproduce this. The connectToPocketBase service fails (the promise is rejected). I guess that's because I have no pocketBaseUrl in my env.

Sorry my bad, you can edit the .env file ;
VITE_POCKETBASE_URL="http://<IP_ADDRESS>:8090"

I will try to do a reproduction url when I have some time soon thanks

Gotcha, I reproduced the problem.

Hey @Zehir
<EMAIL_ADDRESS>is out. I strongly believe this will fix your issue.

Sorry but no, I don't understand why but as soon I register with ninja.register(service) I get errors that don't seems related to xstate ninja;
If I disable the chrome extension I don't have any errors
nav-sidebar-level-one.vue:23
Uncaught (in promise) TypeError: app.state.context.machine.gateways.keys is not a function
    at ReactiveEffect.fn (nav-sidebar-level-one.vue:23:5)
    at ReactiveEffect.run (reactivity.esm-bundler.js:178:19)
    at get value [as value] (reactivity.esm-bundler.js:1147:33)
    at unref (reactivity.esm-bundler.js:1026:29)
    at Object.get (reactivity.esm-bundler.js:1032:35)
    at nav-sidebar-level-one.vue:57:20
    at Proxy.renderFnWithContext (runtime-core.esm-bundler.js:766:13)
    at Proxy.render (vue3-perfect-scrollbar.esm.js:102:42)
    at renderComponentRoot (runtime-core.esm-bundler.js:816:16)
    at ReactiveEffect.componentUpdateFn [as fn] (runtime-core.esm-bundler.js:5701:46)

device.ts:52
Uncaught (in promise) TypeError: context.gateway.getDevice is not a function
    at fetchData (device.ts:52:43)
    at Interpreter2._exec (interpreter.js:265:57)
    at Interpreter2.exec (interpreter.js:1022:10)
    at Interpreter2.execute (interpreter.js:383:14)
    at Interpreter2.update (interpreter.js:411:12)
    at interpreter.js:671:13
    at Scheduler2.process (scheduler.js:65:7)
    at Scheduler2.initialize (scheduler.js:28:12)
    at Interpreter2.start (interpreter.js:670:20)
    at Interpreter2.spawnMachine (interpreter.js:1109:8)

I added some debug, my function stored in the context was replaced by a string;
  services: {
    fetchData: (context) => {
      console.log('fetchData', typeof context.gateway.getDevice)
      console.log('fetchData', context.gateway.getDevice)
      return context.gateway.getDevice({
        params: {
          deviceUniqueID: context.id,
        },
      })
    },
  },

device.ts:53 fetchData string
device.ts:54 fetchData <function>: (t) => this.request(…
device.ts:55 Uncaught (in promise) TypeError: context.gateway.getDevice is not a function
    at fetchData (device.ts:55:30)
    at Interpreter2._exec (interpreter.js:265:57)
    at Interpreter2.exec (interpreter.js:1022:10)
    at Interpreter2.execute (interpreter.js:383:14)
    at Interpreter2.update (interpreter.js:411:12)
    at interpreter.js:671:13
    at Scheduler2.process (scheduler.js:65:7)
    at Scheduler2.initialize (scheduler.js:28:12)
    at Interpreter2.start (interpreter.js:670:20)
    at Interpreter2.spawnMachine (interpreter.js:1109:8)

@Zehir Please try upgrading to 1.3.8

@Zehir This issue was caused by incorrect serialization of context data in xstate-ninja (it did some mutation on the original object).
Can you please test your code with version 1.3.9?

@rlaffers Sorry but it's look like the same;
Uncaught (in promise) TypeError: app.state.context.machine.gateways.keys is not a function
Uncaught (in promise) TypeError: context.gateway.getDevice is not a function

thanks @rlaffers it's worked :)


Bad LLF version 13, wanted version 14.

When I run "make cold-image-vmdk" , it doesn't fully compile, and I get a "Bad LLF version 13, wanted version 14."

I got the same kind of error, most probable reason is leftovers from previous compilation. I got successful build after running make clean


[RFC] arch: nrf: Block forever when building for the wrong board

There are no safety mechanisms to give the user feedback that he might
have choosen a BOARD that doesn't match the connected board. Running
FW for one board on another can lead to obscure debugging.
This patch uses 16 bytes of code to block the application from running
when it is detected that the user has selected the wrong board. After
this patch the user can use his debugger to see why his application is
hanging and it will be obvious what the user error is.
If this method is OK'd I'll port this to nrf51.
Well thought out suggestions for better ways to solve the same usability
problem are welcome.
PS: I'll make an effort to get this upstreamed as well.

@ioannisg: Ping.

This is ugly, will fix this on the runner side later.


Upgrade workspace - Workspace upgrade whisper can be deleted

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 9.0.45-2
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers<EMAIL_ADDRESS>Issue reported by: Applause Internal Team
Action Performed:

Go to staging.new.expensify.com
Create a new workspace.
Go to workspace settings > More features.
Enable Report fields.
Click Upgrade.
Go to #admins.
Right click on the workspace upgrade whisper > Delete comment.

Expected Result:
Whisper should not be deletable.
Actual Result:
Workspace upgrade whisper can be deleted.
Workaround:
Unknown
Platforms:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

Screenshots/Videos
https://github.com/user-attachments/assets/da6eb3a0-062c-42e2-bff7-603e0c90f668

View all open jobs on GitHub

We think that this bug might be related to #wave-control

@joekaufmanexpensify  FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

Proposal
Please re-state the problem that we are trying to solve in this issue.
Workspace upgrade whisper can be deleted.
What is the root cause of that problem?

The current user is not the action owner of the workspace upgrade whisper, but they still can delete that message because they are policy's admin:

https://github.com/Expensify/App/blob/99f280b0edae75ff59614a1c5e98c47b39800aa5/src/libs/ReportUtils.ts#L1813
What changes do you think we should make in order to solve the problem?

In this add addtitional condition:

       || ReportActionsUtils.isWhisperAction(reportAction)

If we don't want to show "Flag as offensive", do the same.

What alternative solutions did you explore? (Optional)

I don't think it really matters that this message can be deleted. Maybe I could see an argument because it's recording
history you can't delete it. But my understanding is this is purely for informational purposes. If someone deletes it, we know they engaged with it, so that seems fine to me.
Going to close for now as I don't really think this is a bug, but please let me know if you disagree, or think that being able to delete this causes a problem.

🤷 I'd rather see if it causes a problem before doing anything. Not convinced this will be an issue.


[5.5 Cherry-pick] Fix new package XCTest file formatting and include throws keyword

Motivation: Fix formatting of the XCTest source file in newly init'ed packages, and include the
throws keyword on the example XCTest method as a convenience to users and to promote use of throwing
test methods in XCTests.
Changes:

Fix a bug in the formatting of XCTest source files in InitPackage, where the closing """ string
terminator was outdented one level too far, which resulted in the file contents being indented unnecessarily.
Include the throws keyword on func testExample() in the new Library type package template.
Modify an existing test to validate these improvements.

rdar://77209458
rdar://77209464

@swift-ci please test

reviewed in #3448


PH315-51 Fan Control works properly out of the box

Hello, there.
Thank you very much for this. I tried a few alternatives and only this worked on my laptop (Helios 300 2018 model). This model has no RGB lighting, so only thing I could test was the fan controls (CoolBoost, Turbo mode). It works exactly as you'd expect. I am proposing you add this model as supported to your README. But in case you don't want to bother, I can try to fork it and simplify the project, relating to my machine.
Again, thanks a lot!
Möhsün.

Okay, I decided to fork it anyway. The application has a lot of issues from a novice user's perspective. I am going to try my best to make it like a normal application and put it in AUR.

Thank you for the feedback. Appreciate the initiative.
Also note that in newer kernel versions, ec_sys is no longer included in vanilla kernels, which is crucial for this program.
It has to be installed maunally, using https://github.com/FaridZelli/acpi_ec, and the program has to be pointed to the new location.
Additional insturctions and automated setup are a WIP to ease the setup.

Which versions are you referring to? I tried this in Arch Linux with kernel 5.19.13 and 6.0 is not out yet.

File to R/W: /sys/kernel/debug/ec/ec0/io
That existed when I was on Kubuntu Focal, kernel 5.13 and 5.15
Tested the program on Fedora 35 and 36, OpenSUSE TW and Manjaro, all with latest kernels at the time (probably 5.18 and 5.19). None had the above file.
Had to use the acpi_ec to install to fix it.
Issue regarding the same, with my comment: https://github.com/FaridZelli/ISW-Modern/issues/3


DetailPanel not working anymore

When adding a detailPanel to a Table, it tries to use a function that doesn't exist.
It happens in core/src/components/MTableHeader/index.js And the following function should be added (I think, I quickly tested it :) )
function renderDetailPanelColumnCell() {
    return (
      <TableCell
        padding="none"
        key="key-detail-panel-column"
        className={props.classes.header}
        style={{ ...props.headerStyle }}
      />
    );
  }

Hi I tried to push the changes but get a 403 error. Am I doing something wrong?

Hi I tried to push the changes but get a 403 error. Am I doing something wrong?

Can you provide a link to your fork?

Can you provide a link to your fork?

Created pull request :)

Created pull request :)

Sorry, one final question, but do you need to make a new release for this?

Sorry, one final question, but do you need to make a new release for this?


Attribute "href" of links is incorrectly validated

According to RFC 7483 section 4.2:

The "href" JSON value MUST be specified.  All other JSON values are OPTIONAL.

Currently the file WEB-INF/notices/help.xml can have a link like this:
<link href="">foo.bar</link>

This link is correct when validated against META-INF/xsd/help.xsd: this is the issue. The schema should validate that the attribute must also have a value.
The issue isn't only at the "help" validation, it's in these schemas:

help.xsd
notices.xsd
tos.xsd

The schemas were updated to validate that "href" value must have at least 1 character.
The issue was:
<xs:attribute type="xs:string" name="href" use="required" />

The fix is:
<xs:attribute name="href" use="required">
	<xs:simpleType>
		<xs:restriction base="xs:string">
			<xs:minLength value="1" />
			<xs:whiteSpace value="collapse" />
		</xs:restriction>
	</xs:simpleType>
</xs:attribute>

Verified. If a href in help.xml is defined with a empty value (""), the validation from help.xsd doesn't allow to start rdap server.
All the validations listed above (help.xsd, tos.xsd, notices.xsd) were modified in order to validate that href is not empty.


⚠ AGE-Vicmap_Parcel-MS has degraded performance

In e6117d6, AGE-Vicmap_Parcel-MS (https://vicmap.land.vic.gov.au/hosting/rest/services/vicmap/Vicmap_Parcel/MapServer/0/query?where=1%3D1&resultRecordCount=1) experienced degraded performance:

HTTP code: 200
Response time: 23168 ms

Resolved: AGE-Vicmap_Parcel-MS performance has improved in 852b27d after 8 minutes.


Not an issue but...

Keep up the good work.

Have fun setting this up,
--- spicata (from the town (maybe not depending on whether or not I get charged for the 99 million counts of arson) )

hi spicata
ty :)
idk how to set this up ;-;


CSS

CSS
User Story
As a boot camp student
I want the pre-work notes to be structured on a webpage
So that I can easily find and read the information
Acceptance Criteria
GIVEN a Pre-work Study Guide website
WHEN I view the study guide
THEN I see a dark blue header and footer, and four boxes with a shadow

CSS layout added and HTML file has been styled


Documentation fixes from last pull

Pull Request Checklist
Is this in reference to an existing issue?
No.
General

[ ] Update Changelog following the conventions laid out on [Keep A Changelog]
N/A

[N/A] Update README with any necessary configuration snippets

[N/A] Binstubs are created if needed

[N/A] RuboCop passes

[N/A] Existing tests pass

New Plugins

[N/A] Tests

[N/A] Add the plugin to the README

[N/A] Does it have a complete header as outlined here

Purpose
Fixing some documentation and formatting issues with the last pull.
Known Compatablity Issues
None.

@sstarcher Can you merge this also please?


Fix  .zprezto/modules/python/init.zsh:85: command not found: add-zsh-…

Fixes ".zprezto/modules/python/init.zsh:85: command not found: add-zsh-hook"  error that started happening recently upon zsh start
Last login: Thu Feb xx xx:xx:xx on ttys000
/Users/xxxxx/.zprezto/modules/python/init.zsh:85: command not found: add-zsh-hook

happens on
zsh 5.3 (x86_64-apple-darwin17.0)
zsh 5.4.2 (x86_64-apple-darwin17.3.0)
with the latest prezto

Thanks for the fix! Looks good to me.


how to build tfprof on rocm platform

Hi,
I am failed to build tfprof on ROCm platform by command:
"bazel build --config opt tensorflow/core/profiler:profiler"
or
"TF_NEED_ROCM=1 PYTHON_BIN_PATH=/usr/bin/python3 ./configure
bazel build -s --config=opt --config=rocm --action_env=HIP_PLATFORM=hcc tensorflow/core/profiler:profiler"
is there any official guide can build pass?
Thanks

@xiongshan could you help share your system configuration, and the errors you are seeing?
I just verified that //tensorflow/core/profiler:profiler can be properly built with the following configuration:

ROCm: 2.2
Docker image tag: rocm/tensorflow:rocm2.2-tf1.13-python3-dev
Config command:

TF_NEED_ROCM=1 PYTHON_BIN_PATH=/usr/bin/python3 ./configure

Build command:

bazel build -s --config=opt --config=rocm --action_env=HIP_PLATFORM=hcc tensorflow/core/profiler:profiler

Also I've verified tfprof builds fine in the upcoming release candidates for ROCm 2.3.

@whchung , previously, I user rocm/tensorflow:latest docker image (it is rocm2.1 sevral days ago.) and sync “latest” tensorflow-upstream codebase to build, not from a tag, this maybe cause the build error.
Now it works well base on the tensorflow codebase in rocm/tensorflow:rocm2.2-tf1.13-python3-dev
Thanks for your kindly help !


simply the logic for wait for glance pods

simply the logic for wait for glance pods

simply the logic for wait for glance pods

s/simply/simplify

@katarimanojk can you check the linter issue and rebase this patch?


add downloadble pkpass file to apple wallet

Description
Add downloadable pkpass file to simulate prescription barcode apple wallet feature
Checklist

[ ] Tested against our testing policy (Resolution, Browser & Accessibility)
[ ] CHANGELOG entry

The package-lock.json file shouldn't of been changed here. Could you revert it and push again?

I didn't touch the package file. Are you able to show me what you mean?

The package-lock.json file shouldn't of been changed here. Could you revert it and push again?

I didn't touch the package file. Are you able to show me what you mean?
@edwardscull I have just seen that you updated the json package file. How do I revert? Do I pull this branch and push again or?

I assume you ran npm install at some point? This has changed the package-lock file for some reason. It shouldn't get changed but this won't be due to anything you did I am assuming.
 The package-lock file should not get changed and then you can push again to this PR.

The package-lock.json file shouldn't of been changed here. Could you revert it and push again?

I didn't touch the package file. Are you able to show me what you mean?
@edwardscull I have just seen that you updated the json package file. How do I revert? Do I pull this branch and push again or?

I assume you ran npm install at some point? This has changed the package-lock file for some reason. It shouldn't get changed but this won't be due to anything you did I am assuming.
 The package-lock file should not get changed and then you can push again to this PR.

Thanks @edwardscull :)
I have tried to undo the commit, run the npm ci and re-did the commit. Does that work?

@Tosin-Balogun your latest commit shows no difference to the previous commit? If you're unsure have a look here https://stackoverflow.com/questions/15772134/can-i-delete-a-git-commit-but-keep-the-changes. Or you could

close this pull request
make a brand new branch from develop
make your changes
run npm ci and revert the package-lock.json file only IF it shows there are changes made to it
then push your new branch and make a new PR

Closing the branch as advised. Will create new branch and run the commands

@Tosin-Balogun your latest commit shows no difference to the previous commit? If you're unsure have a look here https://stackoverflow.com/questions/15772134/can-i-delete-a-git-commit-but-keep-the-changes. Or you could

close this pull request
make a brand new branch from develop
make your changes
run npm ci and revert the package-lock.json file only IF it shows there are changes made to it
then push your new branch and make a new PR

@edwardscull thanks. I have closed the commit.
Running through the steps. I got to the bit where i'm running the npm ci again, but it throws up an error
tosin@Tosins-MBP nhs-app-design-styles-components-patterns % npm ci
npm WARN prepare removing existing node_modules/ before installation
npm ERR! Cannot read property '@babel/core' of undefined

npm ERR!      /Users/tosin/.npm/_logs/2024-08-12T12_34_54_217Z-debug.log
tosin@Tosins-MBP nhs-app-design-styles-components-patterns % npm ci
npm WARN prepare removing existing node_modules/ before installation
npm ERR! Cannot read property '@babel/core' of undefined

npm ERR!      /Users/tosin/.npm/_logs/2024-08-12T12_37_55_859Z-debug.log

Do you know what might be the reason?

@Tosin-Balogun did you ensure you had pulled the latest main before you started working? If you

stash your local changes on your current working branch (https://git-scm.com/docs/git-stash)
checkout main and run git pull. What happens? Does it say "already up to date"? Or does it pull new code?
checkout a new branch from main and apply your stashed changes to this new branch. Everything should now be running off of the latest
run npm install should now no longer change the package-lock.json file
delete old branches that are not needed anymore

@Tosin-Balogun did you ensure you had pulled the latest main before you started working? If you

stash your local changes on your current working branch (https://git-scm.com/docs/git-stash)
checkout main and run git pull. What happens? Does it say "already up to date"? Or does it pull new code?
checkout a new branch from main and apply your stashed changes to this new branch. Everything should now be running off of the latest
run npm install should now no longer change the package-lock.json file
delete old branches that are not needed anymore

@edwardscull so when I went to the main branch to run a pull, it was already up to date. The I did an npm install and it showed the json package file has changes.
Do I discard the changes?

@Tosin-Balogun yes discard those changes before pushing 👍

@Tosin-Balogun yes discard those changes before pushing 👍

I have opened a new PR here https://github.com/nhsuk/nhs-app-design-styles-components-patterns/pull/83


packages Set up download directory

Our project runs ci in gitlab, and then each package get takes a long time. How can I download gackages into my designated cache so that each run doesn't take a long time

export PUB_CACHE=XXX
Found in flutter. Bat


progress bar display?

any thoughts on having a visual progress bar for the playing track?
alternatively,  a display of remaining time for the track?

@CoderRing28 Patiobar does not have access (?yet?) to the CLI output of Pianobar.  I am prettifying some code I have just written and will publish it.  I have extracted the times (played/length) which could be easily adapted to a progress bar.  I have it going to a HomeAssistant sensor and it shows numerically in my music player card, updating each second.  Also I have the upcoming playlist.


refactor: don't check dir and symlink against include

Summary
In #1687, I fixed a bug where directories were traversed even if they were ignored.
Unfortunately this introduced a new bug: any folder that doesn't match at least one pattern in include are rejected.
For example, given the following config
{ files: { include: ["./**/*.js"] } }

And running biome format . results in no processed files because . doesn't match ./**/*.js.
To fix this issue, we should handle directories differently:
If a directory match a prefix of a pattern, then it matches the pattern.
This change is not trivial because our current glob library don't support such mode.
Reverting #1687 seems undesirable.
As temporary workaround, I propose to consider that directories always match any pattern of include. In other words, we skip include checking when the path is a directory.
We retain most of the intention of #1687 because we can still ignore entire directories using ignore.
An important limitation is that symlinks are not recognized as
I also decided to skip include checks for symlink, assuming that most of symlinks target a directory.
EDIT: the second commit fixes a bug I found: the virtual path of a symbolic link that points to a directory was erroneously computed. For example if foo is a symbolic link to bar, the computed path was foo/bar, while it should be foo.
Test Plan
I added a test.

I'm concerned by the fact that we are adding a lot of assumptions without documenting anything. Or without suggesting a clear path forward.
I'm not fond of this patch, and I would prefer to revert the previous change, and limit that change to only symbolic links. After all, nobody filed any issues so far, so I don't see any particular harm.
Practically, take a step back, and move more carefully.

I'm not fond of this patch, and I would prefer to revert the previous change, and limit that change to only symbolic links. After all, nobody filed any issues so far, so I don't see any particular harm.

In that case I would have to file an issue :sweat_smile: Traversing ignored directories runs into issues when those directories contain inaccessible files for whatever reason.

I’m not too excited about assuming that symlinks point to directories. I have a project where that’s not the case 😅 Can’t we check whether the destination is a directory and base the decision on that?

Fixed :) I found another bug around path computation. See the PR description (EDIT).

I'm concerned by the fact that we are adding a lot of assumptions without documenting anything. Or without suggesting a clear path forward.

I updated the changelog entry.
I think it is a fair patch. This is a partial revert of #1687.
While this is not perfect, it avoids many file system errors by actually skipping directories that are ignored in ignore.


Installing "system" node using nvm?

From the README, it's not clear how I could install a system version of node (that will be used even when nvm isn't sourced). Is that a supported use case?

No, definitely not. nvm use system only uses whatever you may have previously had installed.


xfreerdp SPNEGO fails  after installation of Windows 10 update kb5028166

Describe the bug
xfreerdp fails to connect with errors:
SPNEGO failed with NTSTATUS: STATUS_TRUSTED_RELATIONSHIP_FAILURE [0xC000018D]
nla_recv_pdu:freerdp_set_last_error_ex ERRCONNECT_AUTHENTICATION_FAILED [0x00020009]
rdp_recv_callback: CONNECTION_STATE_NLA - nla_recv_pdu() fail
transport_check_fds: transport->ReceiveCallback() - -1
Connecting as local admin user with  xfreerdp  works.
Connecting from a Win10 machine works also for domain users.
To Reproduce
Steps to reproduce the behavior:

Connect to a Win10 box as domain user after installing Windows 10 update kb5028166.

Application details

FreeRDP version 2.10.0
command line: xfreerdp +clipboard /d:dom1 /u:user1 /v:machine1 /geometry /p:password1  /size:95% /multimon /dynamic-resolution

Environment (please complete the following information):

Linux OpenSuSE 15.4

@rkbwde can you try to connect with a current master/nightly build?

@rkbwde https://learn.microsoft.com/en-us/troubleshoot/azure/virtual-machines/troubleshoot-broken-secure-channel suggests this is an issue with your windows 10 machine? (note: FreeRDP 2.0 does not use kerberos, so it is most likely that this is why you only get the failure with xfreerdp and not mstsc)

@akallabeth   Thnx for the link.
I left and re-joined the domain already - no change :-(
But I can login via VNC so the trust between virtual machine and domain controller should be OK.  xfreerdp fails nevertheless :-(
And there has to be a connection to KB5028166. I connected succesfully with xfreerdp this morning. Then the VM suggested to install KB5028166. After reboot, I got the error messages mentioned above.
BTW: Domain controller is a Samba PDC.

@mfleisz  I did a "git clone" and built a local version here.
That version works if I add "/sec:tls".
Thnx  :-)  :+1:
P.S. Without that switch I get errors about an unknown Kerberos Realm.

@rkbwde if /sec:tls works with master that should also work with stable-2.0?
which error do you get with master exactly? (kerberos stuff are just warnings, no failures)

git-version without /sec:tls:
Kerberos messages are prefixed with "ERROR", not with "WARN":
[14:13:19:64] [23250:00005ad3] [ERROR][com.winpr.sspi.Kerberos] - [kerberos_log_msg]: KDC for Realm »DOM1« can't be found
[14:13:19:272] [23250:00005ad3] [ERROR][com.freerdp.core.nla] - [nla_recv_pdu]: SPNEGO failed with NTSTATUS: 0xC000008D
[14:13:19:272] [23250:00005ad3] [ERROR][com.freerdp.core] - [nla_recv_pdu]: ERRCONNECT_AUTHENTICATION_FAILED [0x00020009]
[14:13:19:272] [23250:00005ad3] [ERROR][com.freerdp.core.rdp] - [rdp_recv_callback_int][0x1c1ef60]: CONNECTION_STATE_NLA - nla_recv_pdu() fail
[14:13:19:272] [23250:00005ad3] [ERROR][com.freerdp.core.rdp] - [rdp_recv_callback_int][0x1c1ef60]: CONNECTION_STATE_NLA status STATE_RUN_FAILED [-1]
[14:13:19:272] [23250:00005ad3] [ERROR][com.freerdp.core.transport] - [transport_check_fds]: transport_check_fds: transport->ReceiveCallback() - STATE_RUN_FAILED [-1]

@rkbwde please attach the complete log - there might be some information before the actual [ERROR] lines that are relevant

@rkbwde could you:

run this with /log-level:debug and attach the full log?
If I don´t overlook something, this error code is sent from the server and it maps NTSTATUS 0xC000008D to STATUS_FLOAT_DENORMAL_OPERAND ?!?

@rkbwde and could you please:

tell if /sec:tls works with your xfreerdp 2.10.0
tell if mstsc connects using tls (e.g. you see a login screen if you do not provide the password) or NLA (credentails entered before connection)

just tried with win11. same STATUS_TRUSTED_RELATIONSHIP_FAILURE
according to https://support.microsoft.com/en-us/topic/july-11-2023-kb5028166-os-builds-19044-3208-and-19045-3208-eab49ea6-3133-41c8-845f-a14a329c6c20
This update addresses security issues for your Windows operating system.
Whatever that means
do you have a samba based dc?

they already found the issue upstream
https://bugzilla.samba.org/show_bug.cgi?id=15418

just confirmed that the same happens with mstsc. They also describe the issue being the computer not being able to communicate with the domain controller.
a workaround is, a @rkbwde found out, disable require "network layer authentication" on the rdp server and use /sec:tls instead.
mstsc falls back automatically
If you have freerdp master with kerberos support and you use the /u:domainuser /v: then it should use kerberos and work (both freerdp and mstsc if you use the hostname)

ok, closing as not our bug.

Workaround does not work for me:

NLA is disabled on rdp server
I use /sec:tls

xfreerdp /u:admin /v:<IP_ADDRESS> /p:XXXX /d:schule /cert:ignore /sec:tls /gfx:rfx
Server: Windows 10 Version 22H2 fore x64
Client: freerdp 2.10.0-3.1-x86_64 on openSUSE Tumbleweed 20230719

@stolzpet this probably means that the login does not work enierly (it should fallback to kerberos)
Is the domain a samba nt4 domain? With that only a upgrade of samba to a version that has a fix for this issue.

Samba version 3.6.25


Remove deprecated mogo Model.new constructor

See https://github.com/joshmarshall/mogo/blob/master/mogo/model.py#L127

Thanks! Remember to update it for _create too.


DRY up the dialects. Fixes #661

An initial solution, before Olaf's concrete suggestions in #661.

Will rebase the PR https://github.com/scalameta/scalameta/pull/659 onto this once it is merged :)

"But, but, sbt is, like, not Scala"
Yes and no, it's Scala210 but with allowToplevelTerms = true:
@leaf implicit object Sbt0137 extends DelegatingDialect {
  def name = "Sbt0137"
  def delegate = Scala210
  override def allowToplevelTerms = true
}

I personally would love to have .copy, since for example in scalafmt I want to use a dialect that allows pretty much everything. It could be as simple as
@ case class Dialect2(allowTopLevelTerms: Boolean)(implicit private val sourceName: sourcecode.Name) {
    def name: String = sourceName.value
  }
defined class Dialect2
@ object Dialect2 {
    implicit val Scala210 = new Dialect2(
      allowTopLevelTerms = false
    )
    implicit val Sbt0137 = Scala210.copy(allowTopLevelTerms = true)
  }
defined object Dialect2
@ Dialect2.Sb
Sbt0137
@ Dialect2.Sbt0137.name
res7: String = "Sbt0137"

PS. sourcecode is already a dependency

I second @olafurpg's suggestion.

After trying to get the case class approach to work I've changed my mind and now I'm leaning more towards the approach taken by @dwijnand in this PR. See https://github.com/scalameta/scalameta/commit/1a451a339e9305a613e751de296f47915a5fc923#commitcomment-20830673 for where I got stuck with the other approach.

Started working on this. But changing the dialects to be values instead of types requires a few things to change. Particularly I've got to find a way to rework Dialect.all.

Right, it's nothing to do with using @data or with making sure Dialect.all returns the standard dialects: I'm hitting the compile errors you were hitting now.

@xeno-by Have you taken this task or would you like for me to keep looking at it?

@dwijnand I will fix the related macro errors and follow this through.

Superseded by #678.


Added context.Context Support

This extends PR #245 by adding context.Context support, as discussed in Issue #240. This contribution comes after discussion and example implementations from both myself and @vintik100.

I support a less example code to use context.Context with colly,
which not change anything in colly.
// contextTransport wrapper a context.Context for cancel requests
type contextTransport struct {
	ctx   context.Context
	trans *http.Transport
}

func (t *contextTransport) RoundTrip(req *http.Request) (*http.Response, error) {
	req = req.WithContext(t.ctx)
	return t.trans.RoundTrip(req)
}

func collectorWithContext(c *colly.Collector, ctx context.Context) {
	// We can stop all requests at `OnRequest` callback
    // before send request to HTTP client.
    c.OnRequest(func(req *colly.Request) {
		select {
		case <-ctx.Done():
			req.Abort()
		default:
		}
	})

    // Use custome Transport to cancel all pending requests at HTTP client,
    // which not have chance to stop at OnRequest callback.
    trans := &contextTransport{
		ctx:   ctx,
		trans: &http.Transport{},
	}
	c.WithTransport(trans)
}

This will work when cancel the context.Context,
ctx.Done() will return, and all pending request will immediately be canceled.

Hey! Any reason why this became stuck?
Is it because this PR changes lots of function signatures to have context argument, which is a pretty radical change?
If so, what about making it much less drastic by only adding Collector.WithContext method, which will be used for the http.Request? This way API compatibility would be kept, and it still would be possible to cancel HTTP requests in a clean way.
And since the common way to use colly is to have OnHTML etc. handlers be closures, you can simply use your own context from the closure. E.g.
func crawl(ctx context.Context, url string) {
	c := colly.NewCollector(colly.WithContext(ctx))
	c.OnResponse(func(res *colly.Response) {
		storeIntoSomeDatabase(ctx, res)
	})
	// skip
}

If so, what about making it much less drastic by only adding Collector.WithContext

I like this approach a lot! @WGH- could you work on this?

@asciimoo yes
FWIW, I said it in other issue, but the solution outlined by @fooofei is not perfect since it loses the original request's context which might already have deadline set. See net/http/client.go, where setRequestCancel(req, rt, deadline) is called just before RoundTrip.

FWIW, I said it in other issue, but the solution outlined by @fooofei is not perfect since it loses the original request's context which might already have deadline set

I think it isn't a deal breaker. We can document this behavior or perhaps we can throw a warning if the user sets a custom timeout and also uses custom ctx. What do you think?

FWIW, I said it in other issue, but the solution outlined by @fooofei is not perfect since it loses the original request's context which might already have deadline set

I think it isn't a deal breaker. We can document this behavior or perhaps we can throw a warning if the user sets a custom timeout and also uses custom ctx. What do you think?

What I said earlier applies only to the hack with setting context inside RoundTrip. Setting context before passing the http.Request to Client.Do does not have this problem.


Receiving PushNotification when app is not running

Hello,
I am following this doc to be able to receive push notification in my Xamarin.Forms app.
There is a note on this page about how to receive push notification when the app isn't running on Android :

The Android application will only receive push notifications if it is running in either the background or foreground. To receive push notifications when the main Activity is not running, you must implement a service, which is beyond the scope of this sample. For more information, see Creating Android Services

I don't understand this note as I still receive push notification even if the app is killed (on release build only).
Could you provide more information about this note? Why should it be considered if everything seems to work as expected?
Thank you for your feedback :)
Bruno

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 92f390d9-cbd0-ab8c-6c8c-49df76d1b8e0
Version Independent ID: 15739c2f-afbb-c21d-b96f-fabe7060e410
Content: Send and receive push notifications with Azure Notification Hubs and Xamarin.Forms - Xamarin
Content Source: docs/xamarin-forms/data-cloud/azure-services/azure-notification-hub.md
Product: xamarin
Technology: xamarin-forms
GitHub Login: @profexorgeek
Microsoft Alias: jusjohns

Hi @BrunoMoureau
Apologies for the delayed response. You are correct, and that note needs removing.

Hi @davidbritch
No worries for the delay. Thank you for your answer ! 👍

I've updated the doc in a PR that will go live later this week.


Redundant aria-label on the svg for expand/collapse in clr-accordion

This is an issue with accessibility. We got a report from AccessLevel where they note that the expand/collapse icon inside a clr-accordion has a redundant aria-label.
Here is the issue described by them:

Although technically nothing wrong with the code in the screenshot, the issue with these accordions is that the parent div with the role=”button” has attribute aria-expanded which already conveys the state. Adding the textual equivalent (“Collapse” or “Expand”) to the svg images may be redundant and can be verbose to screen reader users. The functionality of collapsing and expanding is set on the div with the role=”button” and not on the image itself which is why I deemed it decorative. You can simply use aria-hidden=”true” on the image but still keep the title attribute which may be useful to sighted users.

How to reproduce
Use clr-accordion element and check its expand/collapse icon accessibility properties. Screenshot attached.
Expected behavior
To have enough information for screen readers without repetition.
Versions

Angular: 9
Node: 10
Clarity: 3

Device:

Type: Desktop
OS: Win10
Browser Chrome
Version 81

Additional notes
Screenshot of the accessibility properties mentioned in this issue:

This is following our guidelines provided by the a11y team. Will defer to @chlane

I agree, In this case, the aria-label value is duplicative. The icon itself is visually duplicative since sighted users can see that the expansion has occurred without it.  Icons (images) only need accessible names when they provide meaning on their own, independent of any nearby textual content. If not they should be hidden from assistive technologies.

We should remove the title attribute because it will create a tooltip that is not keyboard accessible

I can't seem to reproduce the issue. I've inspected the accordion component in an application here and the aforementioned title attribute is not present - https://stackblitz.com/edit/clarity-v4-accordion-accessibility?file=src/app/app.component.html. Could you please provide a reproduction?

@sis0k0 - clr-stack-view is the right component. The description is incorrect (good thing I added a screenshot).
Sorry for the confusion.

Thank you for the prompt responses!


Error when setting timeout on /start command

I keep getting an error when running user.py and calling the /start command with a timeout argument (as in the tutorial)
Currently using a Cyton (no Daisy) with firmware v3.1.2
user.py plus the print plugin starts fine. Then when I try to run the start command I get an error that forces user.py to exit:
-------------BEGIN---------------

--> /start T:3
Traceback (most recent call last):
  File "user.py", line 232, in <module>
    lapse = int(s[string.find(s, "T:") + 2:])
AttributeError: module 'string' has no attribute 'find'
Closing Serial...
Deactivating Plugins...
Plugin PluginPrint deactivated.
User.py exiting...

As long as I run without the timeout argument, it seems to be fine.
Any ideas what might be going on? Happy to provide more info if needed.

I'll look into this if I can reproduce the issue. What version or python do you have?

I'm using Python version 3.7.2

That's probably the issue right there. At some point we will have a python module that works with 3.x, but that's at least a few months away. The current python module is written for 2.7.
Try again with python 2.7 and see if that works.
If you must python 3, and you're feeling adventurous, you could try porting the Cyton code to python 3.

Thanks, that worked!
Apologies, this led me to another question - in the README under "Useful Commands" there is a bit of code showing how to write a test signal (square wave) onto the SD card for 3 seconds. When I run those same lines I get "no function loaded" after the start command, I assume because there were no plugins added as arguments when running user.py. However, the example also loads no plugins. My SD card has the file that was created by sending an 'a' over serial, but it is empty (despite running '/start T:3'). Should I expect data there, or is the example perhaps from an older version of the code and the doc needs to be updated?
Thanks again for your help.


Can not build for iPhone X simulator

Operating system or device, Godot version, GPU Model and driver (if graphics related):
Godot 2.1
maxOS High Sierra 10.13.1
Issue description:

Steps to reproduce:
$ scons p=iphone arch=x86 target=debug
get the godot.iphone.debug.x86 into the Xcode project
Modify the executable file  to godot.iphone.debug.x86
When tried to run in the simulator in Xcode 9, it failed with
godot.iphone.debug.x86 does not have an architecture that Simulator iPhone X can execute.
If I modified the detect.py file, change the i386 to x86_64, change 32 to 64, it can run without error, but, nothing was displayed.
Link to minimal example project:

I think not just iPhone X simulator.

Well that's what your message mentions, and I know that it works/worked fine on earlier versions with a 32-bit binary.

Yes, 64-bits is missed.

For simulator iPhone 7 and lower, this error message is
dyld: dyld_sim is not compatible with the loaded process, likely due to architecture mismatch

I don't think is an issue any longer.

怎么解决

更新到3.1


Apple rejection

Hi everyone,
Probably not the correct place for this, but I'm been getting a back and forward with Apple about this, has anyone been able to sort this out with them? They refuse to read the licenses in this repo apparently

Design 4.4.3
While we understand the information you have provided, your app must comply with the App Store Review Guidelines to be appropriate for the App Store.
Your app includes images of third party emoji used as stickers without authorization from the necessary third party.
To resolve this issue, please revise the images used in your sticker pack. Otherwise, please provide documentation from Twitter demonstrating your rights to use the emoji imagery as stickers in your app.

Thanks!

Just to clarify: you are trying to get a sticker pack into Apple's (iMessage) app store that uses Twemoji graphics verbatim.
Maybe it would help if Twemoji assets lived in their own repository and had a LICENSE file instead of LICENSE-GRAPHICS, because Github shows a simple synopsis for the former but not the latter. Perhaps an additional pointer to https://creativecommons.org/licenses/by/4.0/ would do the trick, though.

FYI This repository is mirrored by MaxCDN. This is how it's been set up since the beginning and assets cannot possibly be moved anywhere else or people using twemoji via MaxCDN will break.
Assets are also used to generate the JS file so any other solution different from moving assets from here would be probably better.

Just to clarify: you are trying to get a sticker pack into Apple's (iMessage) app store that uses Twemoji graphics verbatim.

Yes, it allows you to compose new emojis by overlapping them, resize, rotate, etc. But yes, it includes all the twitter emojis

@WebReflection Submodules would not work for Maxcdn?

@Crissov I don't know. If they just pull from here without recursion for submodules too it'd be a problem but I am not responsible for that setup.

@raulriera I'm anticipating having a similar issue. Did you get this resolved with Apple?

I made a completely new icon

so ... the issue is that you were using a twitter emoji as App icon?
Can you please elaborate a bit more what was the issue, how you actually solved it, and if it had nothing to do with this ticket, maybe close it too?
Thanks!

so ... the issue is that you were using a twitter emoji as App icon?

Yes, this image shows the old vs new... the old one was rejected because it was just the emoji without changes

The disclaimer where I actually show the emojis was me, they didn't ask about that... but I felt it needed more acknowledgement that just the website (space is sooo crammed in iMessage apps)

thanks for elaborating.


Use the namespace name

The global classname Serializable is an actual interface which is not the same as MongoDB\BSON\Serializable

Merged


Conductor shows wrong AO Function ID

When running an experiment in the Experiment Conductor with a trial that has AO2=1 and AO4=2, the conductor shows this:

Tried this out today and I saw the correct id numbers for the AO functions - this may have been fixed with the big update we did a few weeks ago. I ran an experiment on the updated version with AO2 = 1 and AO4 = 2 during the block trials and another with AO2 = 3, AO3 = 2, and AO4 = 1 during the intertrial. This led me to discover an issue with running AO functions in the intertrial, but I fixed that. The Conductor showed the correct IDs though. If this issue happens again could you include the exact experiment used so I can investigate why it might happen with that particular experiment?


🐛 [Joplin Server] time drift to large

Which addon?

Addon name : Joplin Server
Addon version : 2.9.7

Describe the bug
When starting the container it reports the error and exits
To Reproduce

Install addon
Configure (see below)
Start
Change admin credentials
Create user
Connect Windows 10 client with user and import ~200 text only notes in ~2.5 MB (from Tomboy export)
Connect Android client and synchronize notes
Restart the Add-on
Add-on does not start anymore with Error: The device time drift is 15486ms (Max allowed: 2000ms) - cannot continue as it could cause data loss and conflicts on the sync clients. You may increase env var MAX_TIME_DRIFT to pass the check, or set to 0 to disabled the check.

Full addon log
Starting...
/etc/cont-init.d/00-banner.sh: executing
-----------------------------------------------------------
 Add-on: Joplin Server
 Self-hosted open source note-taking application
-----------------------------------------------------------
 Add-on version: 2.9.7
 You are running the latest version of this add-on.
 System: Home Assistant OS 9.3  (amd64 / qemux86-64)
 Home Assistant Core: 2022.11.3
 Home Assistant Supervisor: 2022.10.2
-----------------------------------------------------------
 Please, share the above information when looking for help
 or support in, e.g., GitHub, forums
 https://github.com/alexbelgium/hassio-addons
-----------------------------------------------------------
/etc/cont-init.d/00-global_var.sh: executing
APP_BASE_URL='http://hass.nodeejay.net:22300'
MAILER_ENABLED='1'
MAILER_HOST='mail.nodeejay.net'
<EMAIL_ADDRESS>MAILER_NOREPLY_NAME='Joplin'
MAILER_PORT='25'
MAILER_SECURE='1'
data_location='/config/addons_config/joplin'
Timezone set from Etc/UTC to Europe/Prague
/etc/cont-init.d/01-custom_script.sh: executing
[22:39:37] INFO: Execute /config/joplin.sh if existing
[22:39:37] INFO: ... no script found
/etc/cont-init.d/99-run.sh: executing
[22:39:37] WARNING: Warning - minimum configuration recommended : 2 cpu cores and 4 GB of memory. Otherwise the system will become unresponsive and crash.
[22:39:37] WARNING: Warning : a custom data location was selected, but the previous folder will NOT be copied. You need to do it manually
[22:39:38] INFO: Using sqlite
[22:39:38] INFO: Mailer Host set
[22:39:39] INFO: Mailer Port set
[22:39:39] INFO: Mailer Secure set
[22:39:40] INFO: Mailer Noreply Name set
[22:39:40] INFO: Mailer Noreply Email set
[22:39:41] INFO: Mailer Enabled set
[22:39:41] INFO: Starting Joplin. Initial user is "admin@localhost" with password "admin"
><EMAIL_ADDRESS>start
> node dist/app.js
2022-11-18 22:39:56: App: Starting server v2.9.7 (prod) on port 22300 and PID 313...
Error: The device time drift is 15424ms (Max allowed: 2000ms) - cannot continue as it could cause data loss and conflicts on the sync clients. You may increase env var MAX_TIME_DRIFT to pass the check, or set to 0 to disabled the check.
    at /home/joplin/packages/server/src/app.ts:260:11
    at Generator.next (<anonymous>)
    at fulfilled (/home/joplin/packages/server/dist/app.js:5:58)
    at processTicksAndRejections (node:internal/process/task_queues:96:5)
npm notice
npm notice New major version of npm available! 8.19.2 -> 9.1.2
npm notice Changelog: <https://github.com/npm/cli/releases/tag/v9.1.2>
npm notice Run `npm install -g<EMAIL_ADDRESS>to update!
npm notice
/etc/cont-init.d/99-run.sh: exiting 1

Full addon config
APP_BASE_URL: http://hass.<beep>.net:22300
data_location: /config/addons_config/joplin
MAILER_ENABLED: 1
MAILER_HOST: mail.<beep>.net
MAILER_NOREPLY_EMAIL<EMAIL_ADDRESS>MAILER_NOREPLY_NAME: Joplin
MAILER_PORT: 25
MAILER_SECURE: 1

I tried adding as requested by joplin server but it did not make a difference
MAX_TIME_DRIFT: 0
System

System: Home Assistant OS 9.3  (amd64 / qemux86-64)
Home Assistant Core: 2022.11.3
Home Assistant Supervisor: 2022.10.2

Please try this version

Puh, that was quick, it fixed it. Thanks!
But I am not sure if it should be permanently set to 0, there is a reason to warn for the time drift?

You could set an ntp server

I've added access to HA server time


Fix: dynamic router creation

What does this PR do?

Stop routers from being created automatically if the defaultRule is empty (""), which should fix traefik/traefik#5576
Motivation

It was bothering me, that the issue hasn't been fixed after this long.
More

[ ] Added/updated tests
[ ] Added/updated documentation

Additional Notes

hi dude, FYI in ma config with latest version this is working well -> defaultRule: ""

Hi @N0tExisting,
Thanks for this contribution!
We are wondering whether it should be put out of draft and be reviewed. Are you still iterating on it?


Add detail to Event Page

https://recodehive.github.io/awesome-github-profiles/events.html
Video 1: https://www.youtube.com/watch?v=AtoVNe1mVUA&t=792s
Video 2: https://www.youtube.com/watch?v=Rm2lT9j6VxQ&t=522s
Video 3: Mention its upcoming event

@sanjay-kv I would like to work on this

@sanjay-kv sir can i work


Kurdish model needed

We desperately need Kurdish TTS to support people without speech. There are no TTS systems supporting this (apart from eSpeak)
I'm really parking this here as a note to anyone else wanting to do this too. Here are some datasets

https://github.com/AsoSoft/AsoSoft-TTS-Speech-Corpus-for-Central-Kurdish
https://data.mendeley.com/datasets/gft65z43hs/1

(sort of related:

https://huggingface.co/Akashpb13/Central_kurdish_xlsr
https://huggingface.co/datasets/navinaananthan/Kurdish-Sorani-Parallel-Corpus
)

The next version of Piper will be moving away from espeak (for licensing reasons), so I will need a pronunciation dictionary for Kurdish similar to these: https://mfa-models.readthedocs.io/en/latest/dictionary/index.html#dictionary
The dictionary can be generated with espeak-ng too, though the quality depends on aspects of the language itself. Arabic is especially difficult because the written form can be spoken many different ways depending on context.

Interesting. Any info on the licensing issues with espeak??

espeak and its successor espeak-ng are LGPL. Depending on who you ask, this means that any project using it should also be some form of GPL. Since Piper is MIT licensed, I want to make sure there's no question that it can be used everywhere.


Notification Action Button

When a popup like this happens we should include a button to take you to that specific realm

it could also include an actual claim button in the notif