nRF5x System Off demo fails to put the nRF52840DK into system off

Using zephyr-v3.0.0 release
Please also mention any information which could help others to understand
the problem you're facing:

Board nrf52840dk_nrf52840

To Reproduce
Steps to reproduce the behavior:

west build -p auto -b nrf52840dk_nrf52840 samples\boards\nrf\system_off
west flash

Expected behavior
System off entered
Impact
Not possible to enter system off
Logs and console output
*** Booting Zephyr OS build zephyr-v3.0.0 ***
nrf52840dk_nrf52840 system off demo
Retained data not supported
Busy-wait 2 s
Busy-wait 2 s with UART off
Sleep 2 s
Sleep 2 s with UART off
Entering system off; press BUTTON1 to restart
ERROR: System off failed
Environment (please complete the following information):

OS: Windows 10
Toolchain: GNU ARM Embedded 9-2019-q4-major
zephyr-v3.0.0

Additional context
Also reported to Nordic for nRFConnect SDK 1.9 in https://devzone.nordicsemi.com/f/nordic-q-a/85097/nrfconnect-sdk-1-9-system-off-sample-fails-to-put-the-nrf52840dk-into-system-off

Can you check if https://github.com/zephyrproject-rtos/zephyr/pull/43187 fixes the issue?


[CINFRA-543] Resilience Failover Tests

Scope & Purpose
I investigated this file during our effort to support replication2 databases. I ended up fixing some unrelated problems. These are just small fixes, nothing major.

[x] :hankey: Bugfix
[ ] :pizza: New feature
[ ] :fire: Performance improvement
[ ] :hammer: Refactoring/simplification

Failing Jenkins urns are unrelated to the changes.


Peer-to-Peer code review

Can we limit the height and width from javascript?

Nice work on implementing your javascript for the menu bar I will like us to work with the linters before actually coding that will prevent you from and help you to limit problems with linters.

Thanks, @BilalLiaquat7 for the intuitive issue,  We can use the style property in Javascript to set an element's width, height, and color.


Build issues / guidance how to use this for JVM

Really cool project, after ready the blog I would really like to try this out for the regular JVM. I've spent quite some time to get it running but even after the latest release I'm still getting seemingly random errors. After battling a lot of other errors (mostly related to Android development setup that was missing) I'm now finally to this error which fails compilation:
The following declaration is incompatible because parameter types are different:
    internal actual fun [Error type: Unresolved type for Zipline].multiplatformLoadJsModule(bytecode: ByteArray, id: String): [Error type: Return type for function cannot be resolved]

Could you provide some guidance on how to resolve this?
In general it would be really helpful to understand better how this could be used in a regular JVM project, even with the Trivia example it's not entirely clear to me how this works. It might be lack of understanding KMM, I haven't used that much before. Maybe a standalone sample repo with examples might be helpful for this?

Agreed that we could add some more samples!
The redwood repo has an integration, though it’s extremely powerful and not necessarily suitable as a sample.
https://github.com/cashapp/redwood
Another place to look is this test:
https://github.com/cashapp/zipline/tree/trunk/zipline-gradle-plugin/src/test/projects/basic


Pytype checker

We use python type annotations, but don't appear to validate them anywhere except on import into Google's source control. This means there are random warnings for the integrator. We should run pytype in OSS if we're going to use type annotations.

Implemented in https://github.com/google/iree/pull/3571.

I'm seeing pytype failures in a PR that doesn't touch the files it's pointing at. I think the issue is that we're doing a diff vs main the base branch as opposed to doing a diff of what is changed in the PR, where I guess we'd be diffing versus the common ancestor of main and the PR
https://github.com/google/iree/pull/3611/checks?check_run_id=1311964122


Generate list of series logos based on file patterns

Add another web-accessible handler to give a list of all of the series logos that are found dynamically in the resources repository. This way new convention logos can be added dynamically as needed. This links with Latent-Logic/TSSSF-Frontend#7

Also probably need to update the card generation python to find and load the new png for the symbol


Permission denied on Windows

Steps to  reproduce:
Run docker-compose up on examples/zookeeper/five-server-docker folder.
There will be the following error messages:
ERROR: for zookeeper4  Cannot start service zookeeper4: oci runtime error: exec: "/opt/zookeeper/bin/zookeeper-entrypoint.sh": permission denied

ERROR: for zookeeper5  Cannot start service zookeeper5: oci runtime error: exec: "/opt/zookeeper/bin/zookeeper-entrypoint.sh": permission denied

ERROR: for zookeeper1  Cannot start service zookeeper1: oci runtime error: exec: "/opt/zookeeper/bin/zookeeper-entrypoint.sh": permission denied

ERROR: for zookeeper2  Cannot start service zookeeper2: oci runtime error: exec: "/opt/zookeeper/bin/zookeeper-entrypoint.sh": permission denied

ERROR: for zookeeper3  Cannot start service zookeeper3: oci runtime error: exec: "/opt/zookeeper/bin/zookeeper-entrypoint.sh": permission denied

I'll try it out on a windows machine and get back to you.

I was able to reproduce on Windows and this fixed it for me.


anonymize breaks trace

$ go tool trace -d staticcheck.trace | wc -l
2023/04/15 04:10:12 Parsing trace...
277357

$ ./traceutils anonymize staticcheck.trace staticcheck.trace.anon

$ go tool trace -d staticcheck.trace.anon | wc -l
2023/04/15 04:10:28 Parsing trace...
failed to parse trace: unknown event type 55 at offset 0x1adcd2
0

I've attached the original trace and the resultant anonymized trace.
staticcheck.trace.anon.gz
staticcheck.trace.gz

Thanks for reporting this 🙇♂. I started working on improving this code the other day and will take this issue into account!

This should be fixed now. Additionally anonymize is now more aggressive in order to prevent any potential reversing of the obfuscation. I also added a strings command to verify the output.


question(nx-remotecache-s3): aws credentials

Hello,
Is there a specific reason behind why access key id & secret access key needs to be defined via either options or environment variable?
https://github.com/robinpellegrims/pellegrims/blob/7a6fd7c4035b16a81a9be0126cec29c1f45c6ec1/libs/nx-remotecache-s3/src/lib/nx-remotecache-s3.ts#L25-L33
I was thinking of using this plugin on EC2 with IAM role (AWS CodeBuild) and noticed currently the above lines were blocking this type of usage.
I think it might be better to remove the checks and let it fallback to aws-sdk-v3 credential provider if user defined AWS credentials are unavailable. I made an example patch here

I'm personally using it with Backblaze B2 so there both parameters are mandatory but I'm sure there will be an error from the B2 backend anyway if they are not set. So feel free to open a PR to make it compatible with your use case.

I'm personally using it with Backblaze B2 so there both parameters are mandatory but I'm sure there will be an error from the B2 backend anyway if they are not set. So feel free to open a PR to make it compatible with your use case.

Ah I see. I will open a PR with the changes :smile:


question about  seq2seq pre-training

For pre-training seq2seq LM ,  how to construct the training example?  Especially, given the unannotated  corpus, what are the source segment and target segment?

The target segment is the next "sentence" of the source segment.


Added Chaostreff Salzburg

Greetings from Salzburg :) Have a nice sunday

@oliver-j  Great. Thanks for adding Chaostreff. Have a great weekend. PS: You're more than welcome to "join" Vienna.html; see -> https://github.com/viennahtml/members   Free ;-) No database required ;-) Just another pull request.  Than you can edit the awesome pages (really) like a wiki (no more pull request required - just click edit etc.).

Thank you very much :)  I am pretty active in the Salzburg Web dev and Startup scene.  So I can contribute a lot of Salzburg dev related events and meetups (even when there aren`t many).
I am sure this list is a good Idea because we need a better programming community in Austria.
: D


[Bug] fix case sensitivity for wildcard queries

Description
Fixes the wildcard query to not normalize the pattern when case_insensitive is set by the user. This is achieved by creating a new normalizedWildcardQuery method so that query_string queries (which do not support case sensitivity) can still normalize the pattern when the default analyzer is used; maintaining existing behavior.
Issues Resolved
closes #5461
Check List

[x] New functionality includes testing.

[x] All tests pass

[x] New functionality has been documented.

[x] New functionality has javadoc added

[x] Commits are signed per the DCO using --signoff
[x] Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Codecov Report

Merging #5462 (378310b) into main (d266a73) will decrease coverage by 0.16%.
The diff coverage is 58.33%.

@@             Coverage Diff              @@
##               main    #5462      +/-   ##
============================================
- Coverage     71.10%   70.93%   -0.17%
+ Complexity    58238    58154      -84
============================================
  Files          4711     4711
  Lines        277573   277579       +6
  Branches      40180    40182       +2
============================================
- Hits         197358   196912     -446
- Misses        64078    64530     +452
  Partials      16137    16137

Impacted Files
Coverage Δ

...rg/opensearch/index/mapper/KeywordFieldMapper.java
86.04% <0.00%> (-0.51%)
:arrow_down:

...a/org/opensearch/index/mapper/MappedFieldType.java
74.74% <25.00%> (-1.55%)
:arrow_down:

...a/org/opensearch/index/mapper/StringFieldType.java
85.07% <66.66%> (-5.70%)
:arrow_down:

...h/cluster/service/ClusterManagerTaskThrottler.java
87.83% <100.00%> (+0.16%)
:arrow_up:

...pensearch/index/search/QueryStringQueryParser.java
70.47% <100.00%> (ø)

...adonly/AddIndexBlockClusterStateUpdateRequest.java
0.00% <0.00%> (-75.00%)
:arrow_down:

...readonly/TransportVerifyShardIndexBlockAction.java
9.75% <0.00%> (-73.18%)
:arrow_down:

...a/org/opensearch/client/cluster/ProxyModeInfo.java
0.00% <0.00%> (-55.00%)
:arrow_down:

.../opensearch/client/indices/CloseIndexResponse.java
42.50% <0.00%> (-48.75%)
:arrow_down:

...adcast/BroadcastShardOperationFailedException.java
55.55% <0.00%> (-44.45%)
:arrow_down:

... and 467 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Expand patterns for lint-staged

Currently, the lint-staged config (in .lintstagedrc) looks like this:
{
  "./**/*.ts": [
    "npm run lint-fix"
  ]
}

This triggers a build and code lint for any modified files before each commit. However, this is limited to just *.ts files currently. The patterns and commands here should be expanded to cover all inputs that could affect the build or lint. At least these changes should be made:

Match on .eslintignore and .eslintrc.json to pick up changes to the lint config.
Match on tsconfig.json and tsconfig.base.json to pick up changes to the build config. There are multiple tsconfig.json files in different folders, so make sure to use a filename match and not a path match.
Match on ava.config.js to pick up changes to unit test config.
Match on package.json to pick up package version changes. Build, tests, and linting should all re-run if package versions change.

The simplest way to handle this is to modify the config like this:
{
  "./**/*.{ts,js,json}": [
      "npm run lint"
  ]
}

This will trigger a lint on any change to a TS, JS, or JSON file. Testing is needed to make sure that ESLint does not throw errors when asked to link a JSON file, since this change will cause lint-staged to pass any modified JSON files as arguments to ESLint.
Documentation for lint-staged is available here.

@warriordog I think
{
  "./**/*.{ts,js,json}": [
      "npm run lint",
      "npm build"
  ]
}

will be enough since these types of files can make breaking changes.

@Vhndaree
Thanks, that should work and its a lot simpler than specifying everything individually.

@warriordog, recently I noticed that we even don't need to add json as a pattern. Because, we are not linting any of .json files. And if you think build should be auto run before every changes to be commited, husky will handle this as build command is mentioned in pre-commit.
So, I think below is suffice
{
"./**/*.{ts,js}": [
"npm run lint"
]
}


Properties for setting image position, locking orientation...

Added few additional properties for setting image position and locking orientation. Also added a function for updating image position manually and a single tap recognizer with a closure.

Sorry but zooming with a single tap gesture is not neccessary.
Thank you for your contribution!

@sidlauskaslukas thanks for the orientation lock that was driving me nuts not knowing why the zoom kept resetting. Turns out the orientation handler was the cause!


Update default body limit to 50 MiB

Currently, the limit of requests is 15 MiB - however, the practice has show that this is not enough. Therefore, we should update it to 50 MiB, which seems to be reasonable given the known file sizes.

Resolved with #69


CLOCK_REALTIME undeclared

Building on a mac:
Apple LLVM version 8.0.0 (clang-8<IP_ADDRESS>)
Target: x86_64-apple-darwin15.6.0
Thread model: posix
InstalledDir: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin

I get:
cc -O3 -Wall -std=c99 -c src/file_operations.c -o src/file_operations.o
cc -O3 -Wall -std=c99 -c src/walkers.c -o src/walkers.o
cc -O3 -Wall -std=c99 -c src/convert_stream.c -o src/convert_stream.o
cc -O3 -Wall -std=c99 -c src/main.c -o src/main.o
src/main.c:251:5: warning: implicit declaration of function 'clock_gettime' is invalid in C99 [-Wimplicit-function-declaration]
    clock_gettime(CLOCK_REALTIME, &res);
    ^
src/main.c:251:19: error: use of undeclared identifier 'CLOCK_REALTIME'
    clock_gettime(CLOCK_REALTIME, &res);
                  ^
1 warning and 1 error generated.
make: *** [src/main.o] Error 1

Potential fix on http://stackoverflow.com/a/6725161

Great. I'll try the fix tomorrow. However, as I said, as I don't have a Mac anymore, would you be OK to test the fix and give away the binary ?

Hello. I've reopened the dev branch. Please feel free check whether this compiles better on OSX.
git pull origin dev
git checkout dev
make

If so, I'll appreciate if you also agree to provide the resulting binary (a pull request should do), that I'll then merge into the master branch with the relevant bookkeeping.
Instead of fixing the real time clock to compile on OSX's peculiarities, I've changed the method of producing a unique temporary file name, and use the process's PID instead. It's a better way anyway. :)

Not getting any response, and being unable to verify by myself on OSX, but given that I checked Apple's docs thoroughly, I assume that the fix will work, I merge dev into master and I close this issue.


Issue with /docs/tasks/tools/install-minikube/

This is a Bug Report
Problem: while installing Minikube to run kubernetes cluster on Oracle virtual box locally  , getting error : This computer doesn't have VT-X/AMD-v enabled. Enabling it in the BIOS is mandatory. It seems neither VMware work-station , nor the Oracle Virtual box is supporting nested Virtualisation. So, minikube --vm-driver=virtualbox start command fails to execute.
**Proposed Solution:**NA
**Page to Update:
https://kubernetes.io/docs/tasks/tools/install-minikube/
https://github.com/kubernetes/minikube/blob/v0.28.0/README.md

 v1.10.0

Things i have done so far:
Install Oracle virtual box on my Windows machine.
Enable Hyper-v in my windows machine.
spawn a linux (ubuntu -16.04) on virtual box.
Installed virtualbox driver on the linux vm.
Installed kubectl on the linux vm.

Hyper-V prevents running other hypervisors on Windows Hosts unfortunately.
You may want to either try disabling Hyper-V and using Virtualbox or see the Minikube Hyper-V specific docs to get that going.


mxnet support windows10 or windows 11 on RTX30 serial

windows 10 RTX3090
I want to install mxnet,but I do not find mxnet version to match with RTX3090.so whl file can supply or how can compile it with windows 10 or win11.

This might help you.
https://github.com/apache/mxnet/discussions/21131

It depends on the CUDA version you're using. Check this link for building from source.


Intended extensibility mechanism?

I'm curious whether any thought has been given to extensibility yet. Given the emacs references, of course using a lisp seems appropriate, but with Neovim using Lua and VSCode using (Java|Type)script, that might close off future avenues of interoperability.

Emacs is my main inspiration and I want Emacs users to feel at home, including by having identical default bindings / macros etc.
When it comes to extensibility, my plan is to want to add a language agnostic plug-in system based on wasm -- so as long as there's a Lisp to wasm compiler, yes, although  my immediate focus will likely be on Rust compiled to wasm plugins.
N.B. given the boost in exposure this project recently received, I'm working on expanding README with goals as well as a roadmap and website (as well as release a new version on crates.io)

Are there drawbacks to using wasm directly as an extension mechanism? I was under the impression that it's a very limited runtime (e.g. no built-in gc). That seems like it could be a bit gnarly. :thinking:

Regarding lisp-to-wasm, there are a couple of projects that do this. There is wasCm (https://github.com/FemtoEmacs/wasCm), which operates on a form of lisp, as well as schism (https://github.com/google/schism, from scheme and discontinued, but possibly still useful).


Add linux aarch64 wheel build support.

Added linux aarch64 wheel build support.
Related to #9 . @fgregg, Could you please review this PR?

superseded

superseded


Slower Build Performance after Upgrade from 9.0.7 to 9.1.0

Since the update from Angular 9.0.7 to 9.1.0 our build times increased a lot. Here are some times:
v9.0.7 - prod build: 8:41
v9.1.0 - prod build: 13:09
These times are on a windows machine with node v12
On linux and mac the difference is much smaller - only a few seconds

Are you sure it is an ngcc problem? The first line in my output is the normal ngc step and even this increased a lot

The sync NGCC is run because of possible modules added in the compilation at a later stage after the first build. Example, when doing code changes, in a local library or adding a new NPM module.
That being said, if a module was already processed by the async NGCC should bail out pretty fast, it will just check for the build marker and exit.

@blackholegalaxy

Fun fact: adding a new dependency in the project (dotenv) caused the entire ngcc compile to occur again even if it was the only changed dependency.

This is expected if you use Yarn as your package manager. This is because Yarn will remove the entire node_modules and re-install all dependencies when you add a new dependency. Which means that NGCC will need to re-run on all modules, which in this case NGCC will only run in sync mode.

With #1 you mean the ngc step? This is the biggest problem for us because this also happens when we develop with --watch.
#4 could be. The windows system I used has an old ssd and my linux system has a new m2 ssd.

With #1 you mean the ngc step? This is the biggest problem for us because this also happens when we develop with --watch.

Yes, me and @petebacondarwin discussed this in the past and @petebacondarwin had some ideas on how to speed this up when there is no work to be done.
#4 could be. The windows system I used has an old ssd and my linux system has a new m2 ssd.
From my experience in general IO operations are always slower on Windows.

So the actual ngcc processing should still only run once per package, so unless you modify your node_modules, the processing of these packages should not happen a second time.
Regarding 1. - this might well be the problem, since on Windows it is quite slow to  traverse the file-system checking for entry-points that "might" need processing. This is happening even if it turns out that they are all already processed.  That being said, I recently implemented an __ngcc_entry_point_manifest__.json file that should be written to the top of your node_modules directory that should avoid having to do this traversal... Can you check to see if one of these is appearing?

Oh, the other part of 1. is that once we have the list of entry-points, which can come from the manifest, we are still parsing the entry-points looking for dependencies in order to sort them before we determine whether they need to be processed or not. This is what @alan-agius4  is talking about here:

Yes, me and @petebacondarwin discussed this in the past and @petebacondarwin had some ideas on how to speed this up when there is no work to be done. But in involved quite a decent amount of work at the time.

Perhaps now is the time to fix this?


Allow painting and exporting textures in 8K resolution (8192x8192)

This requires a powerful GPU with at least 4 GB of VRAM (6+ GB highly recommended).
On a GeForce GTX 1080, it works successfully with most examples I tested. Of course, you'll have to be patient while 8K textures are generated and exported :slightly_smiling_face:
This closes #186.

Hmm sounds cool. How's painting framerate at 8K?

How's painting framerate at 8K?

I didn't test painting yet, but I'll try that. I get a feeling it might be too slow to be usable, so I can probably remove the ability to paint in 8K.

I didn't test painting yet, but I'll try that. I get a feeling it might be too slow to be usable, so I may have to remove the ability to paint in 8K.

Even if painting is near unusable, could be a good idea to keep it for procedural layers and lucky owners of ultra high end GPUs.

Seems painting is completely unusable at 8K. I removed this option for now...


Mobile User Behavior Classification

Description
Please provide a summary of the changes made in this pull request. Include any relevant motivation and context for the changes.
Fixes # (issue)
Type of Change
Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[x] Documentation update

How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Include instructions for reproducing the tests and any relevant details about your test configuration.
Checklist

[x] My code follows the style guidelines of this project.
[x] I have performed a self-review of my code.
[x] I have commented my code, particularly in hard-to-understand areas.
[x] I have made corresponding changes to the documentation.
[x] My changes generate no new warnings.
[x] I have added tests that prove my fix is effective or that my feature works.
[x] New and existing unit tests pass locally with my changes.

Additional Notes
Add any other context or information that may be helpful for the reviewers.

Summary by CodeRabbit

New Features

Introduced a Streamlit web application for predicting mobile user behavior.
Added a dark theme configuration for enhanced UI experience.
Implemented a comprehensive README and documentation for user guidance.
Included a progress bar to visualize prediction results.

Chores

Added a .gitignore file to manage version control effectively.
Created a requirements.txt file listing essential dependencies for the project.

This PR includes the complete Mobile User Behavior Classification project

This PR includes the complete Mobile User Behavior Classification project


Improvement: 自定义tab优化

Codecov Report

Merging #492 (2c904a0) into v2.6.x_develop (21f070d) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@                Coverage Diff                 @@
##           v2.6.x_develop     #492      +/-   ##
==================================================
- Coverage           62.68%   62.68%   -0.01%
==================================================
  Files                 441      441
  Lines               27243    27262      +19
==================================================
+ Hits                17077    17088      +11
- Misses              10166    10174       +8

Impacted Files
Coverage Δ

itsm/project/serializers.py
88.23% <0.00%> (-7.60%)
:arrow_down:

itsm/ticket/managers.py
41.37% <0.00%> (+0.04%)
:arrow_up:

itsm/ticket/views/ticket.py
47.20% <0.00%> (+0.06%)
:arrow_up:

itsm/ticket/serializers/ticket.py
70.45% <0.00%> (+0.13%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 21f070d...2c904a0. Read the comment docs.


Docs: explain in CONTRIBUTING.md how to run a Jest build from another project?

Do you want to request a feature or report a bug?
Suggest an addition to Jest docs
What is the current behavior?
To explore how the excellent improvements in #2787 and #2798 apply to the discussion about snapshots, I wanted to do something like what React describes:
https://facebook.github.io/react/contributing/how-to-contribute.html#development-workflow

…it can be handy to try your build of React in a real project.

If you want to try your changes in your existing React project…

Is something similar possible in Jest?
If yes, do y’all consider it worth the effort to explain it in Jest docs?
If yes, can you give me some feedback and guidance to explain it?

What is the expected behavior?
What I did is run on the command line with same options as test script in my package.json:
node ~/path_to_my_jest_clone/packages/jest-cli/bin/jest.js [options]

It did work for no options or --watch option. For example, an asymmetric matcher in expected value of toMatchObject assertion did work that doesn’t yet work in the release version!
But not for --env=jsdom option: TypeError: Cannot read property 'bind' of undefined

Is what I did incorrect or incomplete?
If y’all think the benefits are greater than the costs, then as a prerequisite to writing a first draft:
I can try more options, and see whether I can understand what fails with environments.

We could mention npm link method for sure. This is what I like to use
$ cd packages/jest-cli
$ npm link
$ cd /path/to/your/project
$ jest // runs `jest` from `packages/jest-cli/bin/jest.js`

to unlink:
$ npm unlink jest-cli

I think it may require sudo if you're having global node modules in a protected dir.
@pedrottimark I don't know why it fails for --env 🤷♂

Aha, nice, thank you very much. And it solved the problem with the --env option.
A few follow-up questions so I can begin to write a first draft:

In contrast to jest on the command line, for npm test and other scripts in my sample project to refer to the link instead of its release version of Jest, I had to temporarily uninstall jest from the sample project. Does that make sense?
To unlink, I had to include global option: npm unlink --global jest-cli as recommended in http://stackoverflow.com/questions/19094630/how-do-i-uninstall-a-package-installed-using-npm-link Does that make sense? The npm doc page for link does not even address unlink :(
To make sure that I understand correctly, in my jest clone project, npm test has the side effect of building Jest for this purpose, true? Whether it is a change I am writing, or a commit already merged from another contributor.

Yea, seems like --global is the way to go as npm unlink jest-cli unlinks local module, didn't know about this, thanks!
Building Jest on npm test is on purpose, just to be sure you're running latest build.


[$125] iOS - Chat - Emoji picker has no space to dismiss when searching for an emoji

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 9.0.67-1
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/cases/view/2654739
Email or phone of affected tester (no customers<EMAIL_ADDRESS>Issue reported by: Applause Internal Team
Action Performed:

Launch Expensify and Go to any chat
Tap on the emoji icon
Tap on the search bar on the emoji picker

Expected Result:
There's a bit of space so a user can dismiss the picker without needing to make search results fewer or add an emoji
Actual Result:
Describe what actually happenedOn the iPhone 12 mini there's not enough space on the top of the emoji picker when making a search to dismiss it. User needs to either add an emoji or first tap on an empty area of the picker to dismiss the keyboard and then tap to exit the picker.
Also the picker is slightly overlap by the time and status bar
Workaround:
Unknown
Platforms:

[ ] Android: Standalone
[ ] Android: HybridApp
[ ] Android: mWeb Chrome
[x] iOS: Standalone
[x] iOS: HybridApp
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos
https://github.com/user-attachments/assets/93f3d80b-dad9-446c-a2ce-2d8c92472f1d

View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~021861826366793735200
Upwork Job ID:<PHONE_NUMBER>793735200
Last Price Increase: 2024-11-27

Issue OwnerCurrent Issue Owner: @hungvu193

Proposal
Please re-state the problem that we are trying to solve in this issue.
iOS - Chat - Emoji picker has no space to dismiss when searching for an emoji
What is the root cause of that problem?
We are already making the maxHeight to be 95% for the popoverInnerContainer
https://github.com/Expensify/App/blob/084a711842d6be379b18491ebe2cc6b48280006e/src/styles/index.ts#L1848
and calculating the max height for the emoji list accordingly here
https://github.com/Expensify/App/blob/084a711842d6be379b18491ebe2cc6b48280006e/src/components/EmojiPicker/EmojiPickerMenu/useEmojiPickerMenu.ts#L31
but we haven't considered the case when the keyboard is open
What changes do you think we should make in order to solve the problem?

The maxHeight should be set to 95% of the windowHeight - keyboardHeight. we can use useKeyboardState to get the current keyboardHeight and update maxHeight values for both cases mentioned above.
What alternative solutions did you explore? (Optional)

Proposal
Please re-state the problem that we are trying to solve in this issue.
Emoji picker has no space to dismiss when searching for an emoji
What is the root cause of that problem?
We have set the maxHeight for BaseEmojiPickerMenu to windowHeight * 0.95.
https://github.com/Expensify/App/blob/9cae202fec631e82fb8fdfe8c661047cb3fccdce/src/components/EmojiPicker/EmojiPickerMenu/useEmojiPickerMenu.ts#L31
But when maxHeight is less than height, the content respects maxHeight, but the view's height still takes the value of height. Native views do not inherently enforce maxHeight constraints. While maxHeight is a CSS property respected by web-based rendering engines, native app layout systems prioritize explicit dimensions like height. Without explicitly calculating and setting the height, the view may expand beyond the intended bounds, leading to layout inconsistencies.
For example:
The calculated listStyle is {"height": 300, "maxHeight": 87}
The red line in the image is 87, and the green line is 300, as described above

What changes do you think we should make in order to solve the problem?
To resolve this issue, we need to compute the height. If maxHeight is less than height, then we set maxHeight equal to height, something like this:
// src/components/EmojiPicker/EmojiPickerMenu/index.native.tsx#L119
+    const computedHeight = listStyle.maxHeight ? Math.min(listStyle.height, listStyle.maxHeight) : listStyle.height;
// src/components/EmojiPicker/EmojiPickerMenu/index.native.tsx#L128
         <BaseEmojiPickerMenu
              isFiltered={isListFiltered}
              headerEmojis={headerEmojis}
              scrollToHeader={scrollToHeader}
              listWrapperStyle={[
                  listStyle,
                  {
                      width: Math.floor(windowWidth),
+                      height: computedHeight,
                  },
              ]}
              ref={emojiListRef}
              data={filteredEmojis}
              renderItem={renderItem}
              extraData={[filteredEmojis, preferredSkinTone]}
              stickyHeaderIndices={headerIndices}
              alwaysBounceVertical={filteredEmojis.length !== 0}
          />

This is an example change. We will discuss the calculation inside the hook and where to place it in the pull request
https://github.com/Expensify/App/blob/9cae202fec631e82fb8fdfe8c661047cb3fccdce/src/components/EmojiPicker/EmojiPickerMenu/useEmojiPickerMenu.ts#L31

POC

What alternative solutions did you explore? (Optional)

This is pretty minor and specific to a 4+ year old device. Dropping the price.

Thanks @huult, I don't think your RCA is correct. I can reproduce this issue on iPhone SE, even when the maxHeight is bigger than actual height. Apply your diff also didn't the bug btw.

Proposal updated

Add new RCA
Add new solution
Add poc on iPhone SE

@hungvu193 Sorry, I've updated the RCA and solution. Can you help me check it again?

@hungvu193 thoughts on the proposal?

I'll rereview this weekend

Thanks @huult 's proposal here looks good and tests well!
🎀 👀 🎀

I tried to revert my pull request, but the crash issue still occurred. I think it’s not related to this ticket.
https://github.com/user-attachments/assets/f0d9a0d7-a411-493b-92c9-7ad57d5ba522

👋 @hungvu193 let's get the checklist for tomorrow!

BugZero Checklist:

[ ] [Contributor] Classify the bug:

Bug classification

Source of bug:

[ ] 1a. Result of the original design (eg. a case wasn't considered)
[ ] 1b. Mistake during implementation
[ ] 1c. Backend bug
[ ] 1z. Other:

Where bug was reported:

[ ] 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
[ ] 2b. Reported on staging (eg. found during regression or PR testing)
[ ] 2d. Reported on a PR
[ ] 2z. Other:

Who reported the bug:

[ ] 3a. Expensify user
[ ] 3b. Expensify employee
[ ] 3c. Contributor
[ ] 3d. QA
[ ] 3z. Other:

[ ] [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment:

[ ] [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion:

[ ] [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

Regression Test Proposal Template

[ ] [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:

Regression Test Proposal
Precondition:

Test:

Do we agree 👍 or 👎

Thanks! This was caught with this existing regression test for the emoji picker, so I think we're good on a standalone test.
Payment summary as follows:

$125 to @hungvu193 for the c+ review (go ahead and request!)
$125 to @huult for the PR

Paid, closing!


Update metoffice data

Create snapshot, meadow, garden, and grapher steps for near-surface temperature anomaly dataset by Met Office Hadley Centre.

Thank you @spoonerf !


Fix the problem of failing transcribing when using OpenAiWhisper

Pull Request Type

[ ] ✨ feat
[ x] 🐛 fix
[ ] ♻ refactor
[ ] 💄 style
[ ] 🔨 chore
[ ] 📝 docs

Relevant Issues

resolves #2617
What is in this change?

Once a Transcription API is set to OpenAiWhisper, transcription result is failure whenever I upload a .mp3 file. I find that the code in line 36 of OpenAiWhisper.js in collector directory is return a result like: content: response. I have referred to the docs in openai.com, the example shows that the text content should extract by using response.text. So I change the code to content: response.text, and my question is solved.
Additional Information

Developer Validations

[x ] I ran yarn lint from the root of the repo & committed changes
[x ] Relevant documentation has been updated
[x ] I have tested my code functionality
[ ] Docker build succeeds locally

This causes any transcriptions to fail when using OpenAI Whisper.


Minor CI tool fixes

What is the purpose of the change
Fixes make test-mutation, and ensures blocks.db from simulator is ignored regardless of directory

I believe doing this leaves out some files for some reason (which is why I had to add the ! in the first place), however I am now seeing errors like you do that I wasn't seeing before. Give me a moment to look into this

@ValarDragon  Basically the method you posted leaves out the twap folder. I have no idea why, but now am realizing that the method I committed includes things like the READMEs, so something in the substitution isnt working. I recommend that we just go back to how it was without the common variable, unless you know what the problem is off the top of your head

Okay I think I finally figured it out, the single quotes on the file exclusions had to go -_-


Fix network injector webhook

This commit fix the network injector webhook to stuck the all cluster.
https://github.com/k8snetworkplumbingwg/sriov-network-operator/pull/116 move the admission version to v1
In v1 the default FailurePolicy is Fail and not Ignore as v1Beta1
Signed-off-by: Sebastian Sch<EMAIL_ADDRESS>

/lgtm
:-)


Cadence/Temporal exceptions and RetryOptions

We need to better align the .NET Temporal client exceptions with what the Java client does.  Ours are somewhat random now.

We also need to have a better RetryOptions implementation that can sensibly map .NET exceptions as well as GOLANG client errors.

TemporalClient should also provide for default RetryOptions.

It's been a while since I've looked at Cadence errors and retrying.  The GOLANG and Java clients model errors and retry policies a bit differently:
GOLANG Client:
The GOLANG client uses standard GO errors and then they wrap them with structs like CanceledError, CustomError, TimeoutError, CanceledError, PanicError, and GenericError.  Each of these errors can return a reason string which can be used by a retry policy to decide whether to retry a failed operation.  The format of the reason string varies based on the type of error:

CanceledError: not sure that the format is
CustomError: a custom reason is specified when the error is constructed
GenericError: cadenceInternal:Generic
PanicError: cadenceInternal:Panic
TimeoutError: the reason cadenceInternal:Timeout TIMEOUT_TYPE where TIMEOUT_TYPE is one of START_TO_CLOSE or HEARTBEAT

Note that GenericError ends up being the catch-all for all errors returned by workflows or activities that don't match any of the other errors.
GOLANG allows the specification of a retry policy for workflows and activities when they are started.  You can specify the retry intervals and such and you can also specify the errors you don't want to be retried.  These are specified using the reason strings for the errors not to be retried.

RetryOptions support is partially completed.  This need some deeper investigation:

[ ] I believe that cadence-proxy will need to use cadence.NewCustomError() when the .NET side sends replies with a custom error.  Currently, I'm seeing custom errors being reported as generic.

[ ] I'm just guessing at the reason strings for many of the exceptions that exist in Java but aren't documented in GOLANG.  I'm currently assuming that these will be reported as generic errors with the reason being the error string.  This is probably incorrect.  We need to see if we can cause one or more of these errors and see what's actually reported.

[ ] We need to complete and test RetryOptions

@johncburns1: I think we're going to need to collaborate on this one.  We're currently seeing Cadence two unit test failures:

Test_EndToEnd.ActivityExternalErrorByID
Test_EndToEnd.ActivityExternalErrorByToken

The basic problem is that these tests have the activity return a custom error including a reason and details, but it looks like the cadence-proxy code isn't actually returning a custom error to Cadence which means that the unit test is seeing a generic error instead.  I believe you can see this happening at request_handlers.go:648.
The unit tests are expecting to see a generic error, which is why they're failing.
I believe cadence-proxy may need to be a bit smarter to actually create the specified error type for requests that return an error in the reply.  We're going to need this for the retry policy to work correctly.
PS: I've been mostly updating both the Cadence and Temporal projects as I've been working on features and fixes so I can at least test the changes on Cadence (while we're getting Temporal working).

CLOSING: Temporal is deprecated.  We're waiting for an official client.


WIP: ClamAV plugin

First draft for a ClamAV plugin.
It only handles clamd and freshclam to keep a modular design so other services can use it too.
My last problem is, that when clamav is newly installed you first have to download a fresh copy of AV sigs via command "freshclam" (takes couple of minutes). I talked to @fichtner and he suggested you implement a button which checks for DB existance and will be displayed out if it was already downloaded.
Is there some code where I can cherry pick stuff?
Would be thankful if you find some time for reviewing @fabianfrz @fichtner 👍

You will need an API status command for whether the database is installed or not. From there, you can implement an JS API call, e.g.:
https://github.com/opnsense/core/blob/master/src/opnsense/mvc/app/views/OPNsense/Core/firmware.volt#L180-L195
Invoke this on page load. We should maybe manipulate a div instead of a dialog:
https://github.com/opnsense/core/blob/master/src/opnsense/mvc/app/views/OPNsense/Core/firmware.volt#L671-L676
And the API-call answer requires three states (best case): missing, (currently) running, ok -- maybe two is enough in the beginning, too.

Ok, and what about this one:
https://github.com/opnsense/core/blob/master/src/opnsense/mvc/app/views/OPNsense/Core/firmware.volt#L662
I could negate it, if file /var/db/clamav/main.cvd DOES NOT exist display button blablubb?  I am unsure what to do. We should make a note in the plugin... (reboot = no database)

on second thought, it's enough if stated in the div, the dialog will reappear after boot anyway since the database is gone :)

I don't know what your systems are doing, but when I reboot my machines the files/folders survive ...

There is a setting under system: settings: misc: /var MFS, it puts /var into RAM, that's why we have the annoying setup.sh thingy :)

Hopefully noone uses this in production  oO
I'll add a note to the button.

@mimugmail ready for merge?

@fichtner Yes, please ping me when you've done the change with the DB check


Makefile add additional_targets for testing

-closes #5298
@davids5 is this what you had in mind? Personally I'd find it just as easy to do it within the Makefile, but I haven't experienced your merge pain.
check: the build everything we care about target, although doesn't contain snappy, and anything else with a complex environment. Can now be extended with additional_targets.mk. Builds on semaphore-ci
qgc_firmware: the set of firmware uploaded for QGC. Builds on travis-ci
quick_check: Easy way to check the main stuff for developers. Builds 1 nuttx, posix, test, and check formatting. I use this locally all the time.

What are the targets of additional_targets.mk?

Sorry @davids5 I'm not quite sure how to do it like this. I think you'd need the target to have optional dependencies? Do you want to do something with naming conventions instead?

@dagar
I was thinking something like defining
ADDITIONAL_CHECK ?=
ADDITIONAL_YADA?=
after the -include  additional_targets.mk
then in the constant targets
check:  ${ADDITIONAL_CHECK}
But that is as far as I thought through it.

Replaced with @davids5's solution in https://github.com/PX4/Firmware/pull/5548


If you haven't changed this prop yourself, this usually means that your versions of the native code and JavaScript code are out of sync. Updating both should make this error go away.

version:
RN: 0.40,
react-native-webview-bridge: 0.33,
try restart React Packager，but the question remains.

我也遇到了这个问题，请问你解决了么


BUG: RegularGridInterpolator does not work on non-native byteorder anymore

Describe your issue.
With the most recent update, applying the scipy.interpolate.REgularGridInterpolator using non-native byteorder raises an exception.
This worked in 1.9.
Reproducing Code Example
import scipy
import numpy as np
from scipy.interpolate import RegularGridInterpolator

print(scipy.__version__)

x = np.linspace(0, 1, 10)
y = np.linspace(0, 1, 15)

xg, yg = np.meshgrid(x, y, indexing='ij', sparse=True)

# make values non-native byteorder
values = (2 * xg + yg).astype('>f8')
points = np.array([[0.5, 0.5]])

print(f'{points.dtype = }')
print(f'{values.dtype = }')
print(f'{x.dtype      = }')

interpolator = RegularGridInterpolator((x, y), values)
print(interpolator(points))

Error message
1.10.0
points.dtype = dtype('float64')
values.dtype = dtype('>f8')
x.dtype      = dtype('float64')
Traceback (most recent call last):
  File "/home/maxnoe/Uni/CTA/ctapipe/test_interp.py", line 22, in <module>
    print(interpolator(points))
  File "/usr/lib/python3.10/site-packages/scipy/interpolate/_rgi.py", line 336, in __call__
    result = evaluate_linear_2d(self.values,
  File "_rgi_cython.pyx", line 19, in scipy.interpolate._rgi_cython.evaluate_linear_2d
ValueError: Big-endian buffer not supported on little-endian compiler

SciPy/NumPy/Python version information
1.10.0 1.23.5 sys.version_info(major=3, minor=10, micro=9, releaselevel='final', serial=0)

Does https://github.com/scipy/scipy/pull/17717 fix it?

I didn't test it, but the PR explicitly mentions this error message

If you could actually test it, that would be most helpful.

The PR actually has a unit test that is basically my example above

OK, I've edited the closes gh-17727 incantation to gh-17717. Thanks for double-checking it!


Make modulus public

…so we don't have to duplicate the value across our eip4844 repos. Currently we duplicate this value in the eip4844 branches of both prysm and geth.

oops this was meant to go to Inphi's fork not the original repo.


WIP: more k8s updates

Closes: #161
Fixes: #427

All of the failures are with the newly added Install kube binaries but interestingly it works on some targets :thinking:

All of the failures are with the newly added Install kube binaries but interestingly it works on some targets 🤔

Perhaps it's related to rate limits @GabyCT addressed for kustomize in https://github.com/confidential-containers/operator/pull/404

It looks extra_opts setting was failing on some targets. ebb1a25dd moves away from using it and tests seem going further at least

./cluster/up.sh: line 21: /usr/local/bin/kubeadm: Permission denied

This is the remaining error AFAICS.

@fidencio @stevenhorsman @ldoktor this looks to be in a good shape now


Release 3.0.1

Release 3.0.1
Summary

cc-check sub-command now run all the tests to do a extensive check of possible limitations to run Clear Containers.
The runtime code coverage was was increased.
The developers documentation now describe how to build a kernel for Clear Containers.

Changes

cc-check: Always run all tests
build: Fix config file warning message
list: Ensure "--cc-all" details are correct
refactor: simplify code to return the fastpath first
Unbreak gofmt
process: Add github issue template
paths: Resolve paths earlier
Improve collect data script
build: Show version of go
tests: Increase unit test timeout
Revert "Merge pull request #587 from mcastelino/topic/govet"
Fix go vet issues flagged by go 1.9
docs: developers: how to build custom kernel
scripts: Create script to gather environment details
readme: Update CI badges
.ci: Remove Travis and add unit testing to all CI

Shortlog
413e2ed cc-check: Only warn if nesting not available
c761552 cc-check: Always run all tests
6ec4ecd build: Fix config file warning message
b629d80 list: Ensure "--cc-all" details are correct
1378b68 refactor: simplify code to return the fastpath first
fc87e7b tests: Fix gofmt and ineffassign issues
2212ef7 CI: Unbreak gofmt logic
651cfb3 process: Add github issue template
2c1ce71 paths: Resolve paths earlier
16b1dae scripts: Improve formatting in cc-collect-data.sh
53bd495 scripts: Simpify main function in cc-collect-data.sh
08ed990 scripts: Rename Meta heading in cc-collect-data.sh
57f2500 scripts: Use more punctuation in cc-collect-data.sh
6a7fc90 scripts: Add more patterns to cc-collect-data.sh
541fe44 scripts: Add more patterns to cc-collect-data.sh
1c7d20c build: Generate cc-collect script
ffe6ccf build: Generalise ".in" file rule
9280a6b build: Show version of go
1bde169 tests: Increase unit test timeout
d4954bc Revert: Undo "Merge pull request #587 from mcastelino/topic/govet"
5213667 go vet: Fix issues detected by go vet in go 1.9
acecd7b Revendor: Revendor testify to fix go vet
3d07c40 docs: developers: how to build custom kernel
c8fc271 scripts: Create script to gather environment details
062522d readme: Update CI badges
fb10a0e .ci: Remove travis and add unit testing to Jenkins
Compatibility with Docker
Clear Containers 3.0.1 is compatible with Docker v17.06-ce
OCI Runtime Specification
Clear Containers 3.0.1 support the OCI Runtime Specification v1.0.0-rc5
Clear Linux Containers image
Clear Containers 3.0.1 requires at least Clear Linux containers image 17270
Clear Linux Containers Kernel
Clear Containers 3.0.1 requires at least Clear Linux Containers  kernel v4.9.47-77.container
Installation

Ubuntu
Fedora
Developers

Issues & limitations
Networking
Adding networks dynamically
Resource management
docker run --cpus=
See issue #341 for more information.
docker run --kernel-memory=
See issue #388 for more information.
shm
cgroup constraints
Capabilities
See issue #51 for more information.
sysctl
tmpfs
Other
checkpoint and restore
docker stats
See issue #200 for more information.
runtime commands
ps command
See issue #95 for more information.
events command
See issue #379 for more information.
update command
See issue #380 for more information.
Networking
Support for joining an existing VM network
docker --net=host
docker run --link
Host resource sharing
docker --device
docker -v /dev/...
docker run --privileged
Other
Annotations
runtime commands
init command
spec command
More information Limitations

lgtm

Hit #622
00:15:21.034 not ok 12 ctr execsync
00:15:21.036 # (in test file crio.bats, line 508)
00:15:21.041 #   `[ "$status" -eq 0 ]' failed
00:15:21.043 # 0
00:15:21.043 # time="2017-09-27 16:18:16.810292537Z" level=debug msg="[graphdriver] trying provided driver "aufs""
00:15:21.043 # time="2017-09-27 16:18:16.816364228Z" level=info msg="CNI network crionet (type=bridge) is used from /tmp/tmp.hlo4cY6DHL/cni/net.d/10-crio.conf"
00:15:21.043 # time="2017-09-27 16:18:16.816465530Z" level=info msg="CNI network crionet (type=bridge) is used from /tmp/tmp.hlo4cY6DHL/cni/net.d/10-crio.conf"
00:15:21.043 # time="2017-09-27 16:18:16.826517781Z" level=debug msg="Golang's threads limit set to 115110"
00:15:21.043 # time="2017-09-27 16:18:16.828358109Z" level=debug msg="sandboxes: []"
00:15:21.043 # time="2017-09-27 16:18:16.828565912Z" level=error msg="Failed to start streaming server: listen tcp <IP_ADDRESS>:10010: bind: address already in use"
00:15:21.043 # time="2017-09-27 16:18:17.948660140Z" level=debug msg="ImageStatusRequest: &ImageStatusRequest{Image:&ImageSpec{Image:redis:alpine,},}"
00:15:21.043 # time="2017-09-27 16:18:17.948922944Z" level=debug msg="parsed reference into "[aufs@/tmp/tmp.hlo4cY6DHL/crio+/tmp/tmp.hlo4cY6DHL/crio-run]docker.io/library/redis:alpine""
00:15:21.043 # time="2017-09-27 16:18:17.949965660Z" level=debug msg="ImageStatusResponse: &ImageStatusResponse{Image:&Image{Id:2308a4be12f7f80b12c3bc6d10610a76c5ffe21b2dd132afabd289b8187e5ff1,RepoTags:[docker.io/library/redis:alpine redis:alpine],RepoDigests:[],Size_:27500208,Uid:nil,Username:,},}"
00:15:21.043 # time="2017-09-27 16:18:18.029207149Z" level=debug msg="ImageStatusRequest: &ImageStatusRequest{Image:&ImageSpec{Image:redis:alpine,},}"
00:15:21.043 # time="2017-09-27 16:18:18.029304651Z" level=debug msg="parsed reference into "[aufs@/tmp/tmp.hlo4cY6DHL/crio+/tmp/tmp.hlo4cY6DHL/crio-run]docker.io/library/redis:alpine""
00:15:21.043 # time="2017-09-27 16:18:18.029740957Z" level=debug msg="ImageStatusResponse: &ImageStatusResponse{Image:&Image{Id:2308a4be12f7f80b12c3bc6d10610a76c5ffe21b2dd132afabd289b8187e5ff1,RepoTags:[docker.io/library/redis:alpine redis:alpine],RepoDigests:[],Size_:27500208,Uid:nil,Username:,},}"
00:15:21.043 # time="2017-09-27 16:18:18.092730001Z" level=debug msg="ImageStatusRequest: &ImageStatusRequest{Image:&ImageSpec{Image:mrunalp/oom,},}"
00:15:21.043 # time="2017-09-27 16:18:18.092850303Z" level=debug msg="parsed reference into "[aufs@/tmp/tmp.hlo4cY6DHL/crio+/tmp/tmp.hlo4cY6DHL/crio-run]docker.io/mrunalp/oom:latest""


Create an intro

Add an intro about yourself: who are you, what is your strength, why are you here.

Issue Created


Debugger failure in Windows

Describe the bug
Cannot load module 'actionsWeatherAppindex.js': Error: Cannot find module '/code/actionsWeatherAppindex.js'
the path for the code in the linux container is badly constructed in windows it should be '/code/actions/WeatherApp/index.js'
To Reproduce
run debugger in windows
Expected behavior
should work
Screenshots

Desktop (please complete the following information):

OS: Windows 10

Fixed.


chore: update rector to 0.15.1

Hi,
Supersedes and closes #5
In this PR, I tried to update the Rector.
Thank you for your wonderful package.

Thanks!


V24.10.23 - won't work on Pi 32bit Bookworm ?

I've been scratching my head on this for a few hours now.
I have a number of Pi's running various editions of Raspbian, most of them use a pibackup.sh and that launches pishrink.sh
In order to try and unravel the problem, I have broken down the two scripts and run them independently.
Using 2 Pis as examples, one running Bookworm, the other Buster. Both mount a network drive and can create .imgs there.
The Pi that is running Buster quite happily shrinks the image (in this example compressing with Gzip too.):
_pi@Coop:~ $ sudo pishrink.sh -advz /media/backup/pi3btest/2024-11-03.img /media/backup/pi3btest/test4.img
pishrink.sh: Creating log file /home/pi/pishrink.log
PiShrink v24.10.23 - https://github.com/Drewsif/PiShrink
_pishrink.sh: Copying /media/backup/pi3btest/2024-11-03.img to /media/backup/pi3btest/test4.img...
pishrink.sh: Gathering data
Creating new /etc/rc.local
pishrink.sh: Checking filesystem
rootfs: 117373/904960 files (0.2% non-contiguous), 932718/3652608 blocks
resize2fs 1.44.5 (15-Dec-2018)
pishrink.sh: Shrinking filesystem
resize2fs 1.44.5 (15-Dec-2018)
Resizing the filesystem on /dev/loop0 to 934619 (4k) blocks.
Begin pass 2 (max = 115452)
Relocating blocks             XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX
Begin pass 3 (max = 112)
Scanning inode table          XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX
Begin pass 4 (max = 13854)
Updating inode references     XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX
The filesystem on /dev/loop0 is now 934619 (4k) blocks long.
pishrink.sh: Zeroing any free space left
pishrink.sh: Zeroed 157M
pishrink.sh: Shrinking partition
pishrink.sh: Truncating image
pishrink.sh: Using pigz on the shrunk image
/media/backup/pi3btest/test4.img to /media/backup/pi3btest/test4.img.gz
pishrink.sh: Shrunk /media/backup/pi3btest/test4.img.gz from 15G to 1.2G
However, the 32 bit Bookworm version hangs at the gathering data point and doesn't move on:
pi@pi3btest:~ $ sudo pishrink.sh -v /media/backup/pi3btest/2024-11-03.img /media/backup/pi3btest/test3.img
PiShrink v24.10.23 - https://github.com/Drewsif/PiShrink
pishrink.sh: Copying /media/backup/pi3btest/2024-11-03.img to /media/backup/pi3btest/test3.img...
pishrink.sh: Gathering data
There's nothing more added to the log file either if i use the -d switch.
The install was completed using the text from your Linux Installation instructions.
All the prerequsites (parted gzip pigz xz-utils udev e2fsprogs) are all listed in their own folders when running a sudo which:
eg:
pi@pi3btest:~ $ sudo which parted
/usr/sbin/parted
It feels like an issue creating the new /etc/rc.local?
There's certainly no .bak verison of it on the bookworm unit
Bookworm:

Buster:

Note that this is not a recent file creation?
I'm at a loss now - do you have any suggestions?

PS - I've since manually created rc.local.bak - that didn't make any differenct.

Can you attach your logs? Im guessing one of the external utilities we call is hanging with the network drive. Does it work when the image is local?

Thanks for the swift response.
If you can tell me which logs you want (and their locations), I'll attach them.
I'll dig out a usb drive with enough storage and try it local tomorrow

there should be a pishrink.log the gets written with the -d option

So i have run a few tests today.
If i mount a local USB drive and manually copy the image files across. pishrink will work - and pretty quickly.
If i use the same mounted USB drive and specify the USB drive as the final destination of the shrunk file (wit the source on the NAS), it will start to copy, but the file transfer stalls at about 4.1GB (of 15GB).
Pishrink fails to write anything useful to the log when it fails either in the file copy from the NAS to the USB, or shrinking on the NAS.
Noting that the exact same version on Buster writes and works on the same NAS.
Both write as root to the NAS.
pishrink_nas to nas file copy.log
pishrink copy to USB.log
pishrink_localusb.log

Is it possible to spin up a version that will do enhanced logging with a -D switch?


support property-based hierarchies from CodeSystemSupport

Is your feature request related to a problem? Please describe.
In the hl7 codesystem artifacts that ship with FHIR R4, hiearchy is expressed by nesting the concepts and the "hiearchyMeaning" field is set to indicate the semantics of that nesting.
For at least some of the CodeSystems moved to https://terminology.hl7.org/ these have been updated to express hierarchy through properties.  For the v3 CodeSystems, that seems to be indicated by a custom "subsumedBy" property and these are the affected CodeSystems as of 3.1:

I assume this was done so that they can properly reflect a "polyhierarchy" (where a single concept belongs "under" two different parent concepts).
Unfortunately, the current support in CodeSystemSupport for IS-A filters will only work for nested hierarchies at the moment:
        public IsAFilter(CodeSystem codeSystem, Concept concept) {
            this.codeSystem = codeSystem;
            descendantsAndSelf = getConcepts(concept, getCodeValueFunction(codeSystem));
        }

    /**
     * Get a set containing {@link R} instances mapped from concepts where all structural
     * hierarchies have been flattened.
     *
     * @param <R>
     *     the element type of the result set
     * @param concept
     *     the root of the tree containing the Concept instances to be flattened
     * @param function
     *     the function to apply to each element of the result set
     * @return
     *     flattened set of {@link R} instances mapped from concepts for the given tree
     */
    public static <R> Set<R> getConcepts(Concept concept, Function<Concept, ? extends R> function) {
        if (concept == null) {
            return Collections.emptySet();
        }
        Set<R> result = new LinkedHashSet<>();
        result.add(function.apply(concept));
        for (Concept c : concept.getConcept()) {
            result.addAll(getConcepts(c, function));
        }
        return result;
    }

How are we supposed to know that the subsumedBy property is the one we're supposed to follow in this case!?
Describe the solution you'd like
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Acceptance Criteria

GIVEN [a precondition]
AND [another precondition]
WHEN [test step]
AND [test step]
THEN [verification step]
AND [verification step]

Additional context
See the below for some general guidance on the nested hierarchy vs property-based hierarchy:
https://chat.fhir.org/#narrow/stream/179166-implementers/topic/hierarchical.20CodeSystems.20and.20ValueSets/near/234918418
I know we have support for these property-based hierarchies in the fhir-term-graph stuff, but I was hoping for something a little simpler that can be simply implemented on top of the RegistryTermServiceProvider.

these are the non-example bindings to terminology.hl7.org valuesets in R4B as of 2022-03-09:
http://terminology.hl7.org/ValueSet/v2-0116
http://terminology.hl7.org/ValueSet/v2-0276
http://terminology.hl7.org/ValueSet/v2-0493
http://terminology.hl7.org/ValueSet/v2-0916
http://terminology.hl7.org/ValueSet/v3-ActConsentDirective
http://terminology.hl7.org/ValueSet/v3-ActEncounterCode
http://terminology.hl7.org/ValueSet/v3-ActIncidentCode
http://terminology.hl7.org/ValueSet/v3-Confidentiality|2.0.0|2.0.0 [sic]
http://terminology.hl7.org/ValueSet/v3-PurposeOfUse
http://terminology.hl7.org/ValueSet/v3-ServiceDeliveryLocationRoleType

currently we look up the CodeSystem to see if its case-sensitive or not.
additionally, we need to be able to walk the hiearchy of concepts in these codesystems in order to support the :above and :below modifiers for searches.
see related discussion at
https://chat.fhir.org/#narrow/stream/179166-implementers/topic/R4B.20questions.20.2F.20issues/near/274827413

proposal:  look for a property named "subsumedBy"
optional:  instead confirm its URI is "http://hl7.org/fhir/concept-properties#parent" and the hierarchyMeaning is "IS-A"?   what if we see other hierarchyMeanding instead?
decision: only handle this in the RegistryTermServiceProvider for now

QA:

identify a valueset that has concepts from a codesystem that uses a property-based hierarchy (probably the v3 ones mentioned above like http://terminology.hl7.org/ValueSet/v3-ActConsentDirective etc)
test valueset expansion on this using [base]/ValueSet/$expand and passing the canonical url of that valueset in the url parameter

GET [base]/ValueSet/$expand?url=http://terminology.hl7.org/ValueSet/v3-ActConsentDirective'
produces the following response:
{
  "resourceType": "ValueSet",
  "id": "v3-ActConsentDirective",
  "language": "en",
  "url": "http://terminology.hl7.org/ValueSet/v3-ActConsentDirective",
  "identifier": [
    {
      "system": "urn:ietf:rfc:3986",
      "value": "urn:oid:2.16.840.1.1138<IP_ADDRESS>25"
    }
  ],
  "version": "2.0.0",
  "name": "ActConsentDirective",
  "title": "ActConsentDirective",
  "status": "active",
  "date": "2014-03-26",
  "description": "ActConsentDirective codes are used to specify the type of Consent Directive to which a Consent Directive Act conforms.",
  "compose": {
    "include": [
      {
        "system": "http://terminology.hl7.org/CodeSystem/v3-ActCode",
        "filter": [
          {
            "property": "concept",
            "op": "is-a",
            "value": "_ActConsentDirective"
          }
        ]
      }
    ]
  },
  "expansion": {
    "identifier": "urn:uuid:81c7242f-7317-4803-8a65-f76ebfff3d04",
    "timestamp": "2022-05-28T12:49:24+10:00",
    "total": 11,
    "parameter": [
      {
        "name": "excludeNested",
        "valueBoolean": true
      },
      {
        "name": "includeDesignations",
        "valueBoolean": true
      },
      {
        "name": "version",
        "valueUri": "http://terminology.hl7.org/CodeSystem/v3-ActCode|6.1.0"
      }
    ],
    "contains": [
      {
        "system": "http://terminology.hl7.org/CodeSystem/v3-ActCode",
        "abstract": true,
        "code": "_ActConsentDirective",
        "display": "ActConsentDirective"
      },
      {
        "system": "http://terminology.hl7.org/CodeSystem/v3-ActCode",
        "code": "EMRGONLY",
        "display": "emergency only"
      },
      {
        "system": "http://terminology.hl7.org/CodeSystem/v3-ActCode",
        "code": "GRANTORCHOICE",
        "display": "grantor choice"
      },
      {
        "system": "http://terminology.hl7.org/CodeSystem/v3-ActCode",
        "code": "IMPLIED",
        "display": "implied consent"
      },
      {
        "system": "http://terminology.hl7.org/CodeSystem/v3-ActCode",
        "code": "IMPLIEDD",
        "display": "implied consent with opportunity to dissent"
      },
      {
        "system": "http://terminology.hl7.org/CodeSystem/v3-ActCode",
        "code": "NOCONSENT",
        "display": "no consent"
      },
      {
        "system": "http://terminology.hl7.org/CodeSystem/v3-ActCode",
        "code": "NOPP",
        "display": "notice of privacy practices"
      },
      {
        "system": "http://terminology.hl7.org/CodeSystem/v3-ActCode",
        "code": "OPTIN",
        "display": "opt-in"
      },
      {
        "system": "http://terminology.hl7.org/CodeSystem/v3-ActCode",
        "code": "OPTINR",
        "display": "opt-in with restrictions"
      },
      {
        "system": "http://terminology.hl7.org/CodeSystem/v3-ActCode",
        "code": "OPTOUT",
        "display": "op-out"
      },
      {
        "system": "http://terminology.hl7.org/CodeSystem/v3-ActCode",
        "code": "OPTOUTE",
        "display": "opt-out with exceptions"
      }
    ]
  }
}

We see that ValueSet-v3-ActConsentDirective is composed of http://terminology.hl7.org/CodeSystem/v3-ActCode
...


Add batching to requests to Context Graph API.

Fixes #9803

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: jeffmendoza
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: mandarjog
If they are not already assigned, you can assign the PR to them by writing /assign @mandarjog in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

mixer/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jeffmendoza: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-local-tests.sh
8432c8d8e96333be4c6c2f12025cfa3b8ad872b1
link
/test istio-integ-local-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jeffmendoza: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-local-tests.sh
8432c8d8e96333be4c6c2f12025cfa3b8ad872b1
link
/test istio-integ-local-tests

prow/istio-integ-k8s-tests.sh
8432c8d8e96333be4c6c2f12025cfa3b8ad872b1
link
/test istio-integ-k8s-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jeffmendoza: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-local-tests.sh
8432c8d8e96333be4c6c2f12025cfa3b8ad872b1
link
/test istio-integ-local-tests

prow/istio-integ-k8s-tests.sh
8432c8d8e96333be4c6c2f12025cfa3b8ad872b1
link
/test istio-integ-k8s-tests

prow/e2e-mixer-no_auth-mcp.sh
8432c8d8e96333be4c6c2f12025cfa3b8ad872b1
link
/test e2e-mixer-no_auth-mcp

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@douglas-reid Comments addressed, PTAL. Thanks!

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: douglas-reid, jeffmendoza
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

mixer/OWNERS [douglas-reid]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jeffmendoza: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-k8s-tests.sh
8432c8d8e96333be4c6c2f12025cfa3b8ad872b1
link
/test istio-integ-k8s-tests

prow/e2e-mixer-no_auth-mcp.sh
8432c8d8e96333be4c6c2f12025cfa3b8ad872b1
link
/test e2e-mixer-no_auth-mcp

prow/istio-pilot-e2e-envoyv2-v1alpha3-mcp.sh
6a311a52dd18c661d4702d42dc1982b5ff1d4ac5
link
/test istio-pilot-e2e-envoyv2-v1alpha3-mcp

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jeffmendoza: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-k8s-tests.sh
8432c8d8e96333be4c6c2f12025cfa3b8ad872b1
link
/test istio-integ-k8s-tests

prow/istio-pilot-e2e-envoyv2-v1alpha3-mcp.sh
6a311a52dd18c661d4702d42dc1982b5ff1d4ac5
link
/test istio-pilot-e2e-envoyv2-v1alpha3-mcp

prow/e2e-mixer-no_auth-mcp.sh
6a311a52dd18c661d4702d42dc1982b5ff1d4ac5
link
/test e2e-mixer-no_auth-mcp

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jeffmendoza: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-k8s-tests.sh
8432c8d8e96333be4c6c2f12025cfa3b8ad872b1
link
/test istio-integ-k8s-tests

prow/istio-pilot-e2e-envoyv2-v1alpha3-mcp.sh
6a311a52dd18c661d4702d42dc1982b5ff1d4ac5
link
/test istio-pilot-e2e-envoyv2-v1alpha3-mcp

prow/e2e-mixer-no_auth-mcp.sh
6a311a52dd18c661d4702d42dc1982b5ff1d4ac5
link
/test e2e-mixer-no_auth-mcp

prow/istio-pilot-multicluster-e2e.sh
6a311a52dd18c661d4702d42dc1982b5ff1d4ac5
link
/test istio-pilot-multicluster-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@douglas-reid can you restart ci/circleci: e2e-simple ? thanks

@jeffmendoza: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-k8s-tests.sh
8432c8d8e96333be4c6c2f12025cfa3b8ad872b1
link
/test istio-integ-k8s-tests

prow/istio-pilot-e2e-envoyv2-v1alpha3-mcp.sh
6a311a52dd18c661d4702d42dc1982b5ff1d4ac5
link
/test istio-pilot-e2e-envoyv2-v1alpha3-mcp

prow/e2e-mixer-no_auth-mcp.sh
6a311a52dd18c661d4702d42dc1982b5ff1d4ac5
link
/test e2e-mixer-no_auth-mcp

prow/istio-pilot-multicluster-e2e.sh
6a311a52dd18c661d4702d42dc1982b5ff1d4ac5
link
/test istio-pilot-multicluster-e2e

prow/istio-unit-tests.sh
6a311a52dd18c661d4702d42dc1982b5ff1d4ac5
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jeffmendoza: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-k8s-tests.sh
8432c8d8e96333be4c6c2f12025cfa3b8ad872b1
link
/test istio-integ-k8s-tests

prow/istio-pilot-e2e-envoyv2-v1alpha3-mcp.sh
6a311a52dd18c661d4702d42dc1982b5ff1d4ac5
link
/test istio-pilot-e2e-envoyv2-v1alpha3-mcp

prow/e2e-mixer-no_auth-mcp.sh
6a311a52dd18c661d4702d42dc1982b5ff1d4ac5
link
/test e2e-mixer-no_auth-mcp

prow/istio-pilot-multicluster-e2e.sh
6a311a52dd18c661d4702d42dc1982b5ff1d4ac5
link
/test istio-pilot-multicluster-e2e

prow/istio-unit-tests.sh
6a311a52dd18c661d4702d42dc1982b5ff1d4ac5
link
/test istio-unit-tests

prow/e2e-mixer-no_auth.sh
6a311a52dd18c661d4702d42dc1982b5ff1d4ac5
link
/test e2e-mixer-no_auth

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jeffmendoza: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-k8s-tests.sh
8432c8d8e96333be4c6c2f12025cfa3b8ad872b1
link
/test istio-integ-k8s-tests

prow/e2e-mixer-no_auth-mcp.sh
6a311a52dd18c661d4702d42dc1982b5ff1d4ac5
link
/test e2e-mixer-no_auth-mcp

prow/istio-unit-tests.sh
6a311a52dd18c661d4702d42dc1982b5ff1d4ac5
link
/test istio-unit-tests

prow/e2e-mixer-no_auth.sh
6a311a52dd18c661d4702d42dc1982b5ff1d4ac5
link
/test e2e-mixer-no_auth

prow/istio-pilot-multicluster-e2e.sh
6a311a52dd18c661d4702d42dc1982b5ff1d4ac5
link
/test istio-pilot-multicluster-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test istio-unit-tests
/test e2e-mixer-no_auth


Memory leak on fullrender

Here's what ive tried
Garbage collecter:
Aikars flags, custom flags, default flags
Ram allocation:
10gb, 16gb, 24gb
config:
setting compression to 0.5, setting max render threads to 8
it seems unavoidable, during a fullrender pl3xmap causes a memory leak which ultimately crashes the server on large worlds
server version: purpur 1.17.1 1393
pl3xmap version: 1.0.0 beta 126

send the crash log

I noticed that Pl3xMap uses a bigger chunk of memory even without rendering. Flare memory profiler screenshot - about 9 minutes of runtime

Screenshots don't help, we need real info

What is "real info"?

The flare link itself

The flare link itself

Here you go.

You have given 9 gigabytes to the server.  Pl3xmap has ALLOCATED 3 GB here.  All this memory has likely been reclaimed by garbage collection.  Even if none of this memory was reclaimed by garbage collection, your server still wouldn't run out. I personally have rendered a 40k by 40k world without any memory issues.
I would assume that you are running pterodactyl and set your XMS and XMX to the total memory that you have allocated to the server container, which is causing this issue.  A freeze is what pterodactyl does when the container is out of memory and the out of memory killer isn't on.

I have 11GB RAM on pterodactyl (left ~2GB for headroom). I don't know if this is normal behaviour for a map plugin just looked a bit much compared to other plugins. Right now with few players maybe it's not a problem but if Pl3xMap is that hungry for RAM it can cause frequent GC and lag spikes with higher load. I can be totally wrong tho.

It's so bad it crashes my server, when will this be fixed?

Please stop posting on every issue you can find. Its spamming the tracker.

There is no memory leak. Read point 3 on this comment for an explanation.


aes-wrap: improve error handling

There was a problem with the error handling in AES wrap which fell back to a default final error.  This adds a fix for the error and more specific errors for the different failure possibilities.
Fixes #16387

[ ] documentation is added or updated
[ ] tests are added or updated

Actually, I'm quite alarmed by this. If we have returns of -1 here, where else do we have those as well?

I just went through all of providers/implementations/cipher/, and only found that type of fault in providers/implementations/ciphers/cipher_aes_wrp.c.  This diff fixes it:
diff --git a/providers/implementations/ciphers/cipher_aes_wrp.c b/providers/implementations/ciphers/cipher_aes_wrp.c
index f797db4596..efd40f8dc8 100644
--- a/providers/implementations/ciphers/cipher_aes_wrp.c
+++ b/providers/implementations/ciphers/cipher_aes_wrp.c
@@ -212,12 +212,12 @@ static int aes_wrap_cipher(void *vctx,

     if (outsize < inl) {
         ERR_raise(ERR_LIB_PROV, PROV_R_OUTPUT_BUFFER_TOO_SMALL);
-        return -1;
+        return 0;
     }

     len = aes_wrap_cipher_internal(ctx, out, in, inl);
-    if (len == 0)
-        return -1;
+    if (len <= 0)
+        return 0;

     *outl = len;
     return 1;

This pull request is ready to merge


[Consensus]  Decoupling the Pacemaker and Consensus modules (Synchronous method)

Description
This PR aims to decouple the consensus module and pacemaker module by making the pacemaker module a submodule of the consensus module.
In a nutshell, this PR includes and introduces:

The Pacemaker submodule
A shared ConsensusPacemaker interface used by the Pacemaker submodule
Renames some fields to improving code quality

Issue
Fixes (partially as intermediate step) #395
Type of change
Please mark the relevant option(s):

[ ] New feature, functionality or library
[ ] Bug fix
[x] Code health or cleanup
[ ] Major breaking change
[ ] Documentation

List of changes

Defined a new shared interface called PaceMakerAccessModule which is implemented by Consensus module
Removed the consensus module field from Pacemaker struct
Made pacemaker a separate submodule
Modified the pacemaker to access the consensus module in a synchronous matter via the PaceMakerAccessModule interface

Testing

[x] make develop_test
[ ] LocalNet w/ all of the steps outlined in the README

Required Checklist

[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have tested my changes using the available tooling
[x] I have updated the corresponding CHANGELOG

If Applicable Checklist

[ ] I have updated the corresponding README(s); local and/or global
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have added, or updated, mermaid.js diagrams in the corresponding README(s)
[ ] I have added, or updated, documentation and mermaid.js diagrams in shared/docs/* if I updated shared/*README(s)

@gokutheengineer Also, please make sure this works with LocalNet

@gokutheengineer Would also appreciate if you could look into TestHotstuff4Nodes1BlockHappyPath to add a small/simple unit test.
Will be easier after I merge my PR in though.

@gokutheengineer Also, please make sure this works with LocalNet

I am facing with problems running LocalNet, even on main. I opened this ticket: https://github.com/pokt-network/pocket/issues/433
So as is, this branch doesn't execute correctly with LocalNet, but first we need to understand if what I am facing with the LocalNet as explained in the ticket is a general issue or not. Only after that diagnosis, and possible fix, I will be able to test with LocalNet.

@gokutheengineer Would also appreciate if you could look into TestHotstuff4Nodes1BlockHappyPath to add a small/simple unit test.
Will be easier after I merge my PR in though.

Okay, since I presume the merge will happen very soon, I will implement after the merge.

@gokutheengineer Let me know if this is ready for review (i.e. cleaned up and existing tests passing + localnet stable).
We can add tests in a followup PR.

@gokutheengineer Let me know if this is ready for review (i.e. cleaned up and existing tests passing + localnet stable).
We can add tests in a followup PR.

Yes it is ready for the review.

@gokutheengineer Make sure to re-request a review when you need a new review. It signals the reviewer that the PR is ready again.

Yes, I re-requested yesterday.

@gokutheengineer Last set of comments.

Could you also merge with master and set the CHANGELOG dates to tomorrow so we can merge it in (the recommit hook errors on it now).
Just confirming you ran LocalNet and everything works, right?

2- As we discussed and tried in our meeting together, even on main branch my localnet is not working as expected (if you remember height is starting from 2, can't move to next view etc.), which we decided this will be handled after this branch.
I presume you remember this issue, and that is why I updated the Readme Testing section on Localnet.
But as I said, I can't be 100% sure if Localnet works as expected, because even main branch doesn't work as expected. So I kindly request you try and run the Localnet as well, like the last time.

The code seems fine and the unit tests pass, but I'm not comfortable merging this in. See the following screencap of running LocalNet on main versus this branch: https://drive.google.com/file/d/15nCq3dy358ZxgM0WbCkY-jpNXZwZwvXE/view?usp=sharing
Note: you may have to wait 5-15 minutes for the video to process since it just finished uploading.
This branch is much less stable & less functional. If you can look into it to understand why (and compare its performance again main on your machine), please do so. If not, I can potentially help look into it closer to the end of the week.

Posting an update. @gokutheengineer and I pair-programmed on this and got a dirty version of the branch working here:
https://github.com/pokt-network/pocket/pull/new/issue/395-decouple-consensus-and-pacemaker-pairprogramm
The diff is available here: debug.diff.txt
Next step is to understand why the changes above fixed things, clean up the diff and aim to get it over the finish line.

Posting an update. @gokutheengineer and I pair-programmed on this and got a dirty version of the branch working here: https://github.com/pokt-network/pocket/pull/new/issue/395-decouple-consensus-and-pacemaker-pairprogramm
The diff is available here: debug.diff.txt
Next step is to understand why the changes above fixed things, clean up the diff and aim to get it over the finish line.

This was due to the GetPrepareQC() method returning an empty QuorumCertificate when consensus modules prepareQC was nil, where it should be returning nil. This was happening when proceeding to the new round since GetPrepareQC() method was called by the InterruptRound() method.

@gokutheengineer Per our discussion offline, here's a video with a bit of an explanation of my approach to merging with main and reviewing PRs: https://drive.google.com/file/d/1wmJHYFt8y-G7uWNur_k7K-D3XzJ4Q6XQ/view?usp=sharing
It's a little long (raw and unedited) but hopefully it helps.


No greenbox data found

I am calling the script, and mafia says everything goes fine:
> greenbox

Deciding your fate...
All done! To see your greenboxes, visit: https://greenbox.loathers.net/?u=2455701

Then I go to the page, and after some loading time I see the error No greenbox data found.
This may or may not be related to another issue. A few days ago I wanted to do a fresh start and called greenbox --wipe. After that I started getting infinite KMail from Jalen Arbuckle confirming successful data wipe, I had to add him to ignore list. I wonder if that request started an infinite loop that is still running, constantly deleting my data, and this is why new requests show an empty page?

The request won't still be running but ignoring Jalen Arbuckle will break
greenbox I think. I need to sort the wipe issue!
On Fri, 19 Jul 2024 at 17:19, pjdo @.***> wrote:

I am calling the script, and mafia says everything goes fine:

greenbox

Deciding your fate...
All done! To see your greenboxes, visit: https://greenbox.loathers.net/?u=2455701
Then I go to the page, and after some loading time I see the error No
greenbox data found.
This may or may not be related to another issue. A few days ago I wanted
to do a fresh start and called greenbox --wipe. After that I started
getting infinite KMail from Jalen Arbuckle confirming successful data
wipe, I had to add him to ignore list. I wonder if that request started an
infinite loop that is still running, constantly deleting my data, and this
is why new requests show an empty page?
—
Reply to this email directly, view it on GitHub
https://github.com/loathers/greenbox/issues/89, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AABL4LVUHXWDAMC3EMMOAGLZNE4BZAVCNFSM6AAAAABLE35UECVHI2DSMVQWIX3LMV43ASLTON2WKOZSGQYTSMRZGI3TONY
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

I removed Jalen Arbuckle from the ignore list, ran greenbox command again and I can now see my stats. It works!

Great. It'll now only send one message, and I have some error reporting in place to see what is going on.


Cut / Copy / Paste is not working in NuEdit.

This needs to be rewritten due to the changes in the API.

Fixed.


Question: Channel-specific drops

Hello, Rust for example has generic drops (drops from every streamer that has them enabled) and streamer drops that you can get only from the specific streamer channel.
Can the program handle this?
Thanks.

Hello o/
Yes, ACL (access control lists, as Twitch calls them) are supported. Each campaign has an ACL of channels the campaign can be progressed with, and when such a campaign is considered for mining, only those channels are used for that purpose.
The ACLs are displayed on the inventory tab, under "Allowed Channels". You can see that section on the picture from the README:


Edit project and client fails if name exists

Edit commands of project and client is invalid if the name of each entity already exist in the model.

Codecov Report

Merging #217 (44dbc5b) into master (e47da71) will decrease coverage by 0.09%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##             master     #217      +/-   ##
============================================
- Coverage     38.85%   38.75%   -0.10%
  Complexity      526      526
============================================
  Files           125      125
  Lines          3150     3158       +8
  Branches        396      400       +4
============================================
  Hits           1224     1224
- Misses         1746     1754       +8
  Partials        180      180

Impacted Files
Coverage Δ

...dress/logic/commands/client/EditClientCommand.java
0.00% <0.00%> (ø)

...ess/logic/commands/project/EditProjectCommand.java
0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


issue with image download

I downloaded the cornerstoneDemo source code from GitHub. I am trying to download an image (jpegas well as dcm) from the application. I understand that the image is loaded from "dicomweb://cornerstonetech.org/images/ClearCanvas/"
I am trying to download an image when it is loaded on to the viewer dynamically (as in, the current image ID has to be appended to the URL "dicomweb://cornerstonetech.org/images/ClearCanvas/" ).
Is it possible to download the image from cornerstone? If so, how?

Cornerstone does not currently provide any method for downloading the displayed image.
Since you have the imageId, though, you should be able to replace the 'dicomweb' prefix with something like 'http' and then use that link to download the file.
Hope that helps!


prepare test coverage CI/CD

adding tarpaulin in github action would be enough?

Let's do this in next milestone.

grcov is the one of options.
https://github.com/gluesql/gluesql/blob/main/.github/workflows/coverage.yml


When building a portal, liquid collection can often get stuck.
When mining diamonds, many diamonds are left out.

When mining diamonds, many diamonds are left out.

Can confirm; I think almost half of the diamonds are left out.

Example: Took 5 minutes to find water
https://youtu.be/_kb0x-szNso
Time: 42:30

Thankfully the "bot missing diamonds" bug is an easy fix. The timers that check for failure use real world time instead of in game ticks, so if you pause the game/lag for a bit they get set off, detecting that the player hasn't made any progress. Will be fixed under codebase-fixes.
Unfortunately the lava collection/water collection is another big issue, will need to deconstruct what I'm currently doing.

Picture of bot not grabbing closest water source from #16:

Here's what I think is happening with the closest block/item task (and why I'm using it instead of baritone's MineProcess)
The task caches the heuristic "travel distance score" of each item it tries to navigate to. If it finds a closer object it will attempt that object instead, comparing its heuristic to other objects. When re-considering closer objects, it will check the cached heuristic chain to determine whether to proceed.
The issue with this is that the heuristic can become outdated real fast: If you cache a heuristic when you're really far away from something, when you get closer the bot will completely ignore the item even if it's super duper close.
The reason why I don't just use baritone's MineProcess is because I need to keep track of which item I'm accessing, so I can blacklist if I fail to reach it. Baritone's mineprocess just goes after every single ore it finds via A* (and this is way better in every other aspect, but it doesn't give me "the current target" just yet).
Will see if I can maybe re-write the task to use baritone goals and figure out which item is currently being pursued.

Sort of fixed in commit codebase-fixes/ada654da605708903a7addd5cd79f10d026f7a3e.
The solution wasn't elegant but it improved the general case: The bot also re-considers going to another object if it's moved much closer to it than before. This fixes the mentioned issue of the heuristics being completely out of date by position, but also makes the edge case (where you have two objects and can get stuck bouncing back between them) a little slower, as some bouncing back+forth will be done (but not too much, and it is an edge case so making that a little slower is worth it)

https://clips.twitch.tv/AmazonianFaintPenguinTooSpicy-s_308XIy_5YhPkb-
Can we re-open this? Or shall I make a new issue?


I am not able to run your code with my latest Matlab 2017. What I can do?

Run it with Simulink project it will work.

Thank you it helped...:)


console open on localhost instead of kubefirst.dev with k3d

Which version of kubefirst are you using?
v2.2.17
Which cloud provider?
k3d (local)
Which installation type?
CLI
Which distributed Git provider?
None specific
What is the issue?
I think it's an issue for a while now, but most of the time, if not always (I think), when I create a new k3d cluster, the browser open the console to http://localhost:9094/services instead of http://lkubefirst.dev as it should.
Code of Conduct

[X] I agree to follow this project's Code of Conduct

It won't be an issue anymore with v2.3 as the revamp of the CLI (using the API instead of its own code, easier to maintain) won't open the browser automatically anymore.


Crash

Problem Description
Hey!
Everytime i load into this save file
last attempt.zip
it crashes with following Error Message:
The mod Factory Planner (1.1.72) caused a non-recoverable error.
Please report this error to the mod author.
Error while running event factoryplanner::on_nth_tick(349856)
factoryplanner/backend/classes/Collection.lua:69: Dataset count incorrect
stack traceback:
[C]: in function 'error'
factoryplanner/backend/classes/Collection.lua:69: in function 'remove'
factoryplanner/backend/classes/Factory.lua:32: in function 'remove'
factoryplanner/ui/main/subfactory_list.lua:35: in function 'handler'
factoryplanner/util/nth_tick.lua:10: in function <factoryplanner/util/nth_tick.lua:7>
Reproduction

Load into save
Wait 2-3 minutes
Crash happens

I wanted to confirm that I've experienced the exact same error message! I double-checked and this happened even only with Factorio Library and Factory Planner installed. I've been trying some new QoL mods, no game-changing ones on the level of Space Exploration or anything, but even so, they're all disabled.
Error message copied below:
Just wanted to
The mod Factory Planner (1.1.72) caused a non-recoverable error.
Please report this error to the mod author.
Error while running event factoryplanner::on_nth_tick(75656)
factoryplanner/backend/classes/Collection.lua:69: Dataset count incorrect
stack traceback:
[C]: in function 'error'
factoryplanner/backend/classes/Collection.lua:69: in function 'remove'
factoryplanner/backend/classes/Factory.lua:32: in function 'remove'
factoryplanner/ui/main/subfactory_list.lua:35: in function 'handler'
factoryplanner/util/nth_tick.lua:10: in function <factoryplanner/util/nth_tick.lua:7>
My save file is attached to this comment - hope it helps!
Mod Test.zip

Hey! Just wanted to add that i am having the same error crashing the save.
Sorry not sure how to link the save or add a screenshot as i am on steam deck and relatively new to it.
Also on 1.1.72 of factory planner and am also running K2 with a few other minor mods.

Similar issue, running latest version of factory planner on 1.1.87 alongside Freight Forwarding and a few other mods.

Hello everyone, thanks for all your reports, and sorry for not addressing this earlier. This bug is an old one that I haven't been able to nail down yet, and it seems to have gotten more frequent. Either way, the next update will include a big rewrite that drops all the code that could be causing this, so it should all be fine when that is out. I'll try to release it very soon.


LedgerConsensus:ERR Unable to reach consensus

hello, I have two problems on my rippled v1.4.0 with Testnet.
anyone knows why those happen?

ERROR:LedgerConsensus:ERR Unable to reach consensus

LedgerConsensus:ERR {
    "acquired": [
        "082943BBE3E0881DA9E05C27706149671C6380E701AE7F8FBE3F7B3E7E5C68F3"
    ],
    "close_granularity": 10,
    "close_resolution": 10,
    "close_times": {
        "628681466": 3,
        "628681467": 3
    },
    "converge_percent": 360,
    "current_ms": 18004,
    "have_time_consensus": true,
    "ledger_seq": 2576601,
    "our_position": {
        "close_time": "628681470",
        "previous_ledger": "94AF40F65CE409BBEA823482F57AC87FA9B0FBB507740C0B7C96ABC63B3AD39B",
        "propose_seq": 1,
        "transaction_hash": "082943BBE3E0881DA9E05C27706149671C6380E701AE7F8FBE3F7B3E7E5C68F3"
    },
    "peer_positions": {
        "67D66319220E4163CCEDA901868674FC5C07C088": {
            "close_time": "628681470",
            "peer_id": "n944nVL4GHUBpZWUn2XaQXYT92b42BYHpwAisiCqvL159tEmWY46",
            "previous_ledger": "94AF40F65CE409BBEA823482F57AC87FA9B0FBB507740C0B7C96ABC63B3AD39B",
            "propose_seq": 1,
            "transaction_hash": "EA282637417916C17BCF767F9EA03E0548068D013BDE8406CFF06F4D5BF9407F"
        },
        "C812271DE132A4313AB634DE935F962A6BB33195": {
            "close_time": "628681470",
            "peer_id": "n9KWVA64rMeqkAvcQ4DNCa2eDXTzprCtK1HLC8H5PEyUVwSSyL5X",
            "previous_ledger": "94AF40F65CE409BBEA823482F57AC87FA9B0FBB507740C0B7C96ABC63B3AD39B",
            "propose_seq": 1,
            "transaction_hash": "EA282637417916C17BCF767F9EA03E0548068D013BDE8406CFF06F4D5BF9407F"
        }
    },
    "phase": "establish",
    "previous_mseconds": 2000,
    "previous_proposers": 6,
    "proposers": 2,
    "proposing": false,
    "synched": true
}

2.ERROR: MISMATCH
019-Dec-03 09:39:17.243721682 LedgerHistory:ERR MISMATCH: seq=2576495 validated:807B1ABDDB754A63DAE7EB8D430789180E8BCA32536087EFC9D5EAAFC01D3B71 then:B25227689245AF13C8FED88A31BFD1CDF62039B006AE4334DADFD9A2A69A6FB2

I suspect you do not have an appropriate UNL configured for the test net. But that's a guess.

Closing due to inactivity. If the issue persists, please open a new issue.


Fix deprecated commands (set-env, add-path)

Finally got around to it 😅

The tests appear to be stuck

Normally the tests fail on nightly because Cassette doesn't work there, but I've never seen it hang before. I can reproduce the hang locally too. But since it's only a test problem and not a package problem, I'm gonna go ahead and merge.


Define minimum viable YAML

Also, something like the following snipped could allow flexibility.
name: atmospheric-carbon-dioxide-trends
version: 1.0.0
kind: FrictionlessDatapackage
kindVersion: 1.0.0

This is something that would need to be worked at the Frictionless spec level! Will reach out to them since they're working on the v2.