Word/phrase level timestamp support possible?

https://github.com/Azure-Samples/cognitive-services-speech-sdk/issues/665
Hi, I'd like to use Word/phrase level timestamp as shown in issues above, is there any possibility to support it?

Yes, I can use the offset and duration of the entire utterance. However, I would like to use each word and its offset and duration as shown below.
{
    "Id": "791d3f8a724846f69e9d9256947d2479",
    "RecognitionStatus": "Success",
    "Offset": 500000,
    "Duration": 13000000,
    "DisplayText": "What's the weather like?",
    "NBest": [
        {
            "Confidence": 0.97660327,
            "Lexical": "what's the weather like",
            "ITN": "what's the weather like",
            "MaskedITN": "what's the weather like",
            "Display": "What's the weather like?",
            "Words": [
                {
                    "Word": "what's",
                    "Offset": 500000,
                    "Duration": 3900000
                },
                {
                    "Word": "the",
                    "Offset": 4500000,
                    "Duration": 1300000
                },
                {
                    "Word": "weather",
                    "Offset": 5900000,
                    "Duration": 2900000
                },
                {
                    "Word": "like",
                    "Offset": 8900000,
                    "Duration": 4600000
                }
            ]
        },

According to https://github.com/Azure-Samples/cognitive-services-speech-sdk/issues/665, if I call RequestWordLevelTimestamps and set OutputFormat to Detailed, I can get the word level timestamp.
https://github.com/jabber-tools/cognitive-services-speech-sdk-rs/blob/main/src/speech/speech_config.rs#L245-L250
https://github.com/jabber-tools/cognitive-services-speech-sdk-rs/blob/main/src/speech/speech_config.rs#L324-L335
I called RequestWordLevelTimestamps and set OutputFormat to Detailed, but I could not get the NBest.
So to get the NBest, we need to add the NBest field here.
https://github.com/jabber-tools/cognitive-services-speech-sdk-rs/blob/main/src/speech/speech_recognition_result.rs#L19-L20

hi
no need to enhance the struct SpeechRecognitionResult in any way. Just do exactly same as they advice in above mentioned issue 665, i.e.:

set request_word_level_timestamps on your speech config object
set set_get_output_format to OutputFormat::Detailed on your speech config object
in recognized callback (available only in recognized callback, not in recognizing callback!) read event result property like this event.result.properties.get_property(PropertyId::SpeechServiceResponseJsonResult, "N/A")
4 That's it! You will get the very same JSON as they describe above, I just tested it and it works fine

Let me know should you have any problems with it, I just used one of provided examples to make this work with above mentioned tweaks.

I tried the above method and got the desired result.
Thank you so much!


Missing information

[Enter feedback here]
This page should mention an important information about the key to the log analytics workspace will change after the migration happened. People who are saving the primary key to the Key Vault should be reminded to rotate the secret accordingly.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 00ee37bb-dd7e-29c3-76ff-7e00e9c9d73f
Version Independent ID: 546fccf7-426c-ea9e-0515-b5bfbca6b655
Content: Move a Log Analytics workspace in Azure Monitor - Azure Monitor
Content Source: articles/azure-monitor/platform/move-workspace.md
Service: azure-monitor
Sub-service: logs
GitHub Login: @bwren
Microsoft Alias: bwren

@zzgzy Thanks a lot for bringing this to our notice, we will review this information with required team and update the document accordingly.

Hello,
You are correct - the workspaces keys are re-generated with workspace move operation.
Thanks for reporting this gap in documentation. We will update appropriately.
Thanks,
Yossi

I want to update that documentation was updated and mentions the keys change in: https://docs.microsoft.com/azure/azure-monitor/platform/move-workspace#workspace-move-considerations.
#close


Memory Leak

Attaching event handlers will prevent GC from cleaning up.

Do it yourself, coder boy

https://github.com/Tocseoj/StardewValleyMods/blob/4472a5e27002e64c27180c5beb027d2e2ccacfb0/LadderLight/ModEntry.cs#L82

Should be fixed using WeakReferences in commit 8a6b751edf418a1fe3e2ea3a329eb9a0977985c1


Updated link

The old link was not working. Updated to the correct one.
Problem: https://github.com/MicrosoftDocs/microsoft-365-docs/issues/563

@MSFTTracyP - PR is ready for final review based on issue #563
Thank you.
cc: @kenwith


Follow "How to apply the Apache License to your work"

http://choosealicense.com/licenses/apache-2.0/
How to apply the Apache License to your work.
To apply the Apache License to your work, attach the following
boilerplate notice, with the fields enclosed by brackets "{}"
replaced with your own identifying information. (Don't include
the brackets!)  The text should be enclosed in the appropriate
comment syntax for the file format. We also recommend that a
file or class name and description of purpose be included on the
same "printed page" as the copyright notice for easier
identification within third-party archives.
Copyright {yyyy} {name of copyright owner}
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.

I'm cool with this change: http://www.apache.org/licenses/LICENSE-2.0#apply
:+1:

IANAL but this makes sense. For due diligence, work with Josh and get agreement from our counsel and ask Ben if there's any historical context why we didn't do this originally. If all good, please update our template too.

-1
The intent with the short form here is to include it with your copyright notice. Which this project does at the end of the README section. Some projects also choose to include this in all their source files which you usually see at the header of a source file. Additionally this text needs to be present in the "NOTICE.txt" file that is contained alongside the copy of the license (and is for the project currently).
The actual LICENSE.txt is intended to by a full copy of the license text itself. See the [apache guide|http://apache.org/dev/apply-license.html#new] for a bit more info. The guide there is intended for Apache software itself, but we follow their same recommendation in this case from a naming perspective. The LICENSE.txt file and its contents fulfill section 4a of the license.

I think in either case we do need to update the current license.txt to actually have our information in it at the bottom. Right now it still has the brackets: https://github.com/cerner/canadarm/blob/master/LICENSE.txt#L190

I think in either case we do need to update the current license.txt to actually have our information in it at the bottom. Right now it still has the brackets

The license text must be an exact unmodified copy of the license. Modifying it is a common mistake, but check out some of the apache projects for good examples. Modifying it, for example, would be like telling other people that reference your copy of the license to apply the license and use our own copyright holding name.

As a small example check out this issue for when Curator moved from Netflix (where they mostly get the LICENSE inclusion wrong) into the Apache incubator and their current checked in copy
https://issues.apache.org/jira/browse/CURATOR-119
https://github.com/apache/curator/blob/master/LICENSE

I stand corrected. Is there any outstanding comments or changes? Can this be closed?

Based on conversation I've closed this pull request.


[Bug]: Workflow engine type "Hop remote workflow engine" can reference itself

Apache Hop version?
2.8.0
Java version?
openjdk version "11.0.23" 2024-04-16 LTS
Operating system
Windows
What happened?
Issue Description:
The workflow run configuration for workflow engine type "Hop remote workflow engine" can reference itself.
Incident Details:
This issue occurred with the following workflow:
Hop server is running on a VM (VirtualBox, Ubuntu 24.04, openjdk version "11.0.23" 2024-04-16), default installation with no modifications.
In the Hop GUI (Windows), the server was added via the Metadata button -> Add Hop Server.
The workflow run configuration "test" was created with "Hop remote workflow engine".
Clicking on the "Start execution button" then click on the play button.
This opens the run configuration for "test". Here it is possible to select again "test" as run configuration.
Clicking OK -> Launch results in the following error, see file: log.log

Resetting to local run configuration and starting the Workflow again -> pop-up indicates that the workflow is already running.
However the stop button is greyed-out.

Later, the stop button becomes visible, but clicking it does not abort the process.
Restarting Hop is required to resume work.
Expected Behavior:
When opening the run options -> edit this metadata

it should not be possible to select "test" run configuration again!
Issue Priority
Priority: 2
Issue Component
Component: Hop Gui, Component: Hop Server, Component: Metadata, Component: Workflows

Same problem for pipeline remote run configuration


[tools revamp] render simple charts based off selections

render a map, scatter, or timeline tile depending on selections

thanks!


Remove unnecessary panel in EditorHelpBit

This fixes some visual problems with it, but there are others that I don't know the cause:

It completely ignores the editor font size.
In tooltips, font variants (bold, code, etc) aren't set.

Thanks!


At home page, display the only the current year's Executive Members

Need to remove previous year executive member's option from the home page but will be able to view them through About us Page.
Task

Remove the option to view 2023/24 from the home page
Remove the 2024/2025 as well but make sure to display the members of 2024/2025

I expect non-members to contribute on this

@gaurovgiri i can fix this issue !

So technically you don't need the old options there just put that in the About Us page ?

I have added a fix for this, Pull Request #136


Adjusted configs to format expected by launcher

Just delete client/configs/taunts.cfg because it's not used anymore and this LGTM.


An issue about training data

Hi,
I've managed to download the training data, but it seems that a file is missing. There should have been a file "pairs-dilation-0.00-fixed2.h5" in "prague_old_town_square". Is it necessary for the generation of matching data?

That scene had some issues, just don't use it. We wanted to have another look at it but can't find the time, we might eventually remove it.


Add "Accessibility" to definitions.md

Hi. My name is Nick Geller, and I’m a colleague of Eric Gardner at the Getty. I really like what you all have been doing at the incluseum. I thought it might be a good idea to a definition for accessibility, since the term accessible comes up a few times in the repository and could use a bit of deconstructing like you do with the other terms defined. Feel free to change the definition I wrote in whatever way you want. If you don’t include it, that’s okay with me, too. It’s just a suggestion for what I consider to be a really worthwhile project. Thanks!

Hey Nick! Sorry I'm just getting to this, I didn't see this pull request until now. Thanks for the contribution. Merging!

No worries, @nikhiltri. Happy to contribute!


homepage is showing 404 error page in both theme

Bug report
Title
homepage is showing 404 error page in both theme
Issue Description
homepage is showing 404 error page in both theme
Preconditions
1. framework Version- master

Steps to reproduce
1. step1- visit shop

Actual result

@vaishaliwebkul  I can not reproduce this issue, see screenshot below

Not getting this issue on fresh installation.


Add Conditional Execution beforeAgent Note

In the Conditional Execution section in the pipeline we're using:
beforeAgent true
May be beneficial to include a note as to why you would want to do this an the significance of what is means.  This potentially saves us time in needing to spin up a new agent pod if the branch isn't the master branch.

Also #3 below this section it says:
"Next, in GitHub, navigate to your forked helloworld-nodejs repository - click on the Branch drop down menu, type *development"
Remove the * in front of development, that might be confusing.

Done https://github.com/cloudbees-cd-acceleration-workshop/cloudbees-cd-acceleration-workshop-exercises/commit/a1f05dca469790f480bb1e989627d37398371e43
Thanks


add script to restrict changes on default branch to PRs

This sample pre-receive hook script will block any changes to the default branch that are not made via Pull Request.

@cjs :shipit: Looks good.


Upgrade jsc-android to 250230.2.1

Summary
Upgrade jsc-android to latest stable version. Hopefully this should finally fix https://github.com/facebook/react-native/issues/25494.
Before Hermes totally replaced JSC, it should be worth to have this and make JSC stable
Changelog
[Android] [Changed] - Upgrade jsc-android to 250230.2.1
Test Plan
Launch app with new jsc-android and see everything works fine.

@hramos The CI is passed now for this PR. Could you please take a look? Hopefully this could be landed and have a more stabler JSC in the future.

@hramos, please review this PR, @Kudo thanks for the contribution to fix this

Here I'm pasting the outcome from our quick investigation over this PR:
@Kudo Please review ..
React-Native JSC Upgrade
A quick evaluation of this PR which is upgrading the JavaScriptCore binaries used by react-native on Android platform,
The PR is upgrading JSC binaries from revision 245459 to 250230. These numbers are the SVN revision numbers in Webkit repo (svn info "${URL}" | sed -n 's/^Last Changed Rev: //p') akin to the commit ids in Git repos.
These binaries are generated based on the WebKitGtk sources and the build scripts are stored in this repo :react-native-community/jsc-android-buildscripts: Script for building JavaScriptCore for Android (for React Native but not only) (github.com)
The current JSC package consumed in react-native
The last JSC upgrade in react-native was through this commit: https://github.com/facebook/react-native/commit/58d87940a1a995f0faf1270c0da435b44015575f on Jul 1, 2019.
It was also built by Kudo
This was the commit description,
Upgrade jsc-android to r245459 and fix crash on Samsung S7 Edge (#25426)

Summary:

Upgrade bundled jsc-android that should fix the native JSC crash addressed for #24261.

Major changes after r241213 are:

1. Disable DFG JIT.

2. Upgrade WebKitGTK to 2.24.2, this version includes the [new bytecode format enhancement](https://webkit.org/blog/9329/a-new-bytecode-format-for-javascriptcore/).

3. Workaround LLVM \_\_clear\_cache issue which may have some problems on ARM Cortex A-53.

For details, please refer to the PRs in https://github.com/react-native-community/jsc-android-buildscripts.

In #24261, there were many experimented JSC deliveries and thank to people in RN community helping me verify the final version which solve the crash issues.

Even though the above commit description suggested that the JIT was being turned off, by looking at the changes that went into the JSC build scripts, the JIT was turned back on based on the feedbacks on adverse impact on performance,
https://github.com/react-native-community/jsc-android-buildscripts/commit/abdce96b7ce833d0d33078b4b8a772b6593d7a3f
commited on Jun 25, 2019
Here is a summary on the state of JSC package at present,

Based in WebKitGtk release v2.24.2 (SVN revision 245459) released on 05/17/2019
ICU 58.1
Based on Android ndk version r17c

Latest PR
By looking at the changes went into the build scripts, the following are the enhancements in the JSC binaries with the latest PR,

Based on WebKitGTK 2.26.1 (SVN revision 250230) dated on 09/23/2019
Upgraded ICU from v58.1 to v64.2
Built with Android NDK r19c
One key crash fix is included,

https://github.com/react-native-community/jsc-android-buildscripts/commit/57a2aa0d05f0963c7079117d1bee156d2f7399fa
Summary
I'd summarize my thoughts below,

he new package is also based on a 1½ year old version of Webkit source and is only 4 months ahead of the current one. Hence I don’t expect the new binaries to be much different, and any important security fixes to be included.
The crash fix mentioned above seems to be one that community is looking forward to. The fix is not yet tested and verified to fix the crash though as far as I understood. But the crash seems to be happening because of synchronization issues between GC and interpreter access to bytecode pages and the fix is addressing it, hence it will likely fix the crash.
ICU bump from 58.* to 64.* can mean a lot for products which consumes JSC with Intl enabled.

Thanks @mganandraj for the briefly description which is correct.
and thanks @yungsters for getting this landed.

Sure thing. Thanks right back at you, @Kudo! And yes, much appreciation to @mganandraj for the analysis that helped me do a lot of the legwork to gain the context for merging this.


Renaming the master branch to main

I've just noticed that tests do not run after merging a PR. This is because main slipped in when updating to JupyterLab 4.0. As new repositories and most extensions now use main branch, would it make sense to migrate over here too to limit confusion?
https://github.com/jupyterlab-contrib/jupyterlab-vim/blob/2078dc0ad8be24225da67cac8bf954a8e31e66fc/.github/workflows/build.yml#L3-L7
CC @ianhi

makes sense to me

done

For reference, instructions to update locally:
git branch -m master main
git fetch origin
git branch -u origin/main main
git remote set-head origin -a

Thank you!


[Suggestion] Wildwood weapons/tools/armor glow a greenish tint when enchanted

Wildwood & Sylvan weapons/tools/armor glow a greenish tint when enchanted instead of the default vanilla purple.  I think this would make them much more "roots" specific and more aesthetic assuming it was noticeable but not toxic avenger bright either.

Nautilus is unfortunately still in Alpha, but I'll talk to Darkhax about potentially including it as a dependency. Otherwise the only way to achieve this functionality is through providing coremodding ourselves.
That ideally would be nice though!

This wouldn't be possible without using ASM or depending directly on Nautilus. It could be done as an option thing with Nautilus, which is a distinct possibility, but I'm not sure how many people would actually download it.

Ok. Nvm then. Thanks!


Move to travis-ci.com (instead of travis.org)

The old travis.org service is no longer available.
You need to activate something in order to move the CI to travis-ci.com. PRs won't be able to get merged otherwise

@NathanFallet Thanks for the reminder. We are currently in the process of doing it, but there is quite a few repos to go through
@dannys42 Do you have any progress on this side?

I'll try to prioritize this in the next couple days.  FYI, part of the process I've been going through is also to update the CI builds to include newer versions of swift and deprecate Swift 4.x.  Let me know if there are any issues with that.

FYI, I'm working on this... Some of the dependencies (e.g. Swift-Kuery and KituraContracts) also need updating, so it's going a little slower than I'd hoped.

Resolved in PR and release 1.0.0


Set conda channels for each dependency

In poetry2conda this is done using a tool.poetry2conda.dependencies section of pyproject.toml. Not sure how it would be done here without an additional metadata file.
This feature would also permit dependencies to be installed via pip.

Wouldn't need to introduce a new input metadata file - if I introduced more settings they would take the form of additional arguments to the dist_conda command, which are configurable either in pyproject.toml or setup.py (or on the command line at build time if you don't want to edit the project files).
The bigger issue is that the output would need to be an additional metadata file, and new tools would need to be made to act on that information. Conda packages have no knowledge of where their dependencies need to come from, so this it out of scope for a project that builds conda packages. I don't believe conda itself can be told to install specific dependencies from specific channels when satisfying dependencies - one would need to script multiple calls to conda install, and the script would need to walk the dependency tree itself.
It sounds like entire environments can specify these things - like what poetry2conda produces with its environment yaml files. But this is quite far out of scope for setuptools-conda, and almost orthogonal to its current functionality of building conda packages.
As for installing dependencies via pip, labscript-suite repackaged PyPI packages in order to avoid this.
Perhaps one approach could be to use setuptools-conda to build conda packages, and then also make a metapackage that depends on your top-level components, and specifies enough info for environment creation with poetry2conda?


Implement Matcher for std::sync::LazyLock<T>

Resolves: #129
⚠ This bumps MSRV to 1.80.
Matcher impl for std::sync::LazyLock<T> isn't gated behind regex feature because it doesn't need once_cell dependency.
Would be nice to phase out once_cell completely but i'm not sure how to do that without breaking existing feature flags

CI failures seem unrelated. 1.81 clippy passes locally. CI runs nightly check/fmt

WASM test might be related but I don't understand what's happening

Thanks!


Consider adding toolbar (back/forward/reload, maybe more?)

after convert to app there's No back or forward button..how do i add those?
is there any command for these?

is there any command for these?

@Phe0nix thanks for the feedback :)
There's no back/forward/reload/url bar and buttons in Nativefier apps, no. The goal is to package web applications and let the webapps themselves be the way users navigate inside them, with minimal interface around.
I'll close that for now, but feel free to add more comments, with enough understanding (please provide use cases, perceived benefits, examples where the lack is particularily painful, etc.) we can reconsider this into a feature request

FWIW, I too would love back/forward/reload/home and on page text search.  I do not want a URL bar, just 4 icons plus a way to search for text on a page.
Use case: I use Natifiver for several web apps like our project managment tool and it's really helpful to be able to search a long page for key words in a long threaded conversation.
Additionally, when I click into an issue/task it's really nice to back out (I used cmd-[) but my normal method would be a button or right-click and back.  Yes, the web app provides a link backward to the "issue list" but it's not the best UI and hard to find/click.
Somewhat related #297

This basically renders Nativefier useless in web apps like GitHub, which are heavily dependent on linking between issues/PR's and subsequently using the back/forward buttons (or swiping on MacOS) extensively.

This basically renders Nativefier useless in web apps like GitHub, which are heavily dependent on linking between issues/PR's and subsequently using the back/forward buttons (or swiping on MacOS) extensively.


Drag & Drop capability

https://stackoverflow.com/questions/4861214/wpf-drag-and-drop-virtual-files-into-windows-explorer

Selection rectangle behavior will need to be modified

I'd like to see copy & pasting implemented before this.

Any chance of this happening? Love the new updates. The app is so polished and stable now.

I've split up the tasks to make it simpler, and I'll start with the easier ones.

my use-case is cutting files from my device, and pasting them onto a backup HDD. The "Pull" GUI button seems to only perform a copy, but no "after successful copy, remove from source location". The cut action in the GUI seems to not respond to pasting in Explorer.exe (not completely unexpected). Is there another cut-and-paste-to-PC method I am missing?

my use-case is cutting files from my device, and pasting them onto a backup HDD. The "Pull" GUI button seems to only perform a copy, but no "after successful copy, remove from source location". The cut action in the GUI seems to not respond to pasting in Explorer.exe (not completely unexpected). Is there another cut-and-paste-to-PC method I am missing?

You are correct - there is no pull and delete option, but this will be possible when the whole drag & drop mechanism is finished, as it is the default in File Explorer to move-drag.


Miscellaneous Changes - Quick Start Guide

Removed introduction and 1st numbered bullet under Account setup as unnecessary
Added introduction to Making a test API call section
Clarified 1st numbered bullet in Making a test API call section
Added additional sub-headings: "Follow end user payment journey" and "View transaction at GOV.UK Pay Admin site"
Added in content around expiry date format

Conflict resolved so hopefully this is good to go now. @roryjhs please review


Fixed a unicode error that happens with Python 2.7

Codecov Report

Merging #127 into master will increase coverage by 6.86%.
The diff coverage is 88.88%.

@@            Coverage Diff             @@
##           master     #127      +/-   ##
==========================================
+ Coverage   55.97%   62.83%   +6.86%
==========================================
  Files          37       37
  Lines        1472     1472
==========================================
+ Hits          824      925     +101
+ Misses        648      547     -101

Impacted Files
Coverage Δ

categories/tests/test_admin.py
100% <100%> (ø)
:arrow_up:

...gories/editor/templatetags/admin_tree_list_tags.py
60.18% <75%> (+41.43%)
:arrow_up:

categories/base.py
77.17% <0%> (+4.34%)
:arrow_up:

categories/editor/tree_editor.py
62.96% <0%> (+33.33%)
:arrow_up:

categories/editor/utils.py
100% <0%> (+66.66%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d71d057...fb0174c. Read the comment docs.


HttpRequestMessage does not have data in ASP.NET Core

Currently I am converting LINE with bot framework application to ASP.NET Core, implement the same controller
  [HttpPost]         public async Task<ActionResult> Post([FromBody]  HttpRequestMessage request)
But when I test webhook, HttpRequestMessage does not have any data. Can anyone help?

Using seanmars' code to create a method like the one below, I was able to create an HttpRequestMessage that the "GetWebhookEventsAsync" extension method can use successfully.
Note that the "X-Line Signature" key must be included in the header.
private async Task<HttpRequestMessage> GetLineRequest()
{
    using (var reader = new StreamReader(HttpContext.Request.Body))
    {
        var content = await reader.ReadToEndAsync();
        var reqMessage = new HttpRequestMessage
        {
            RequestUri = new Uri("https://localhost:5001/callback"),
            Content = new StringContent(content, Encoding.UTF8, "application/json")
        };
        var signature = HttpContext.Request.Headers.Where(x => x.Key == "X-Line-Signature").First();
        reqMessage.Headers.Add(signature.Key, signature.Value.ToString());
        return reqMessage;
    }
}


handleLiveChat is not defined

Uncaught ReferenceError: handleLiveChat is not defined
    at HTMLButtonElement.handleClick (script.js:30:5)
script.js:30 Uncaught ReferenceError: handleLiveChat is not defined
    at HTMLButtonElement.handleClick (script.js:30:5)
handleClick @ script.js:30

thanks for opening the issue! I've implemented the needed changes and have submitted it to the Chrome web store - it'll be live shortly once they approve👍


add link rel preconnect to improve page load times

Add preconnect to the most used/important domains to speed up page loading.

Bug in htmltest breaks the build. I've reported the bug and will close that for now:
https://github.com/wjdp/htmltest/issues/202


Additional damage visualisers

About the PR

I saw that there are respective damage visualisers at 20, 40 and 100 damage values. This is like, way too little and very inconsistent. I added 3 more so that the visualisers are at 10, 20, 30, 50, 70 and 100 damage values.
Because of the way the system works, I had to redo burn as well so i felt that i might add a new sprite for 100 damage.
For burn, it goes 10, 30, 50, 100 instead of the standard 20, 40 and 100.
Media

[X] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Finally fixed it, and it's ready for review ^^


Errors lose a lot of data when being serialized and hydrated

Currently this is how we serialize errors on the server:
function serializeError(error) {
  return error.message ? `new Error(${devalue(error.message)})` : devalue(error);
}

I think this looses some important data, i.e.other properties on the error object, eg. stack, code and custom properties. I think we can do better and more thorough serialization of the error to get almost the same error object on the client (with the stack preserved).
https://github.com/sindresorhus/serialize-error Might be a good starting point for this.

Perhaps dev mode only though so as not to over-expose details to the client.

yeah that's reasonable

I see.. Hmm... it would require custom deserialization in the browser which isn't great. stack and name seem at least reasonable for dev.

How can I work on this issue? Are there any hints in the code so I can follow up?


adding the docker image tag into message

We have docker hub repos with multiple tags, so it would be nice to also show the tag in the message :)

@chamerling thank you! do you also plan a new release version?

oh nevermind, already happened, thanks a lot

@Schnitzel here it is https://www.npmjs.com/package/dockerhub2slack


Hide audit- commands from help and auto-complete because they a…

…re deprecated.

[ ] All tests passed. If this feature is not already covered by the tests, I added new tests.
[ ] All static analysis checks passed.
[ ] This pull request is on the dev branch.
[ ] I used gofmt for formatting the code before submitting the pull request.

Hide deprecated audit- commands from help and auto-complete.

Closing due to a duplication with this PR:
https://github.com/jfrog/jfrog-cli/pull/1557


fix(plugins/plugin-kubectl): What's Next guidebook

Description of what you did:
Created the first draft of the Knative What's Next guidebook.

My PR is a:

[ ] 💥 Breaking change
[ ] 🐛 Bug fix
[x] 💅 Enhancement
[ ] 🚀 New feature

Please confirm that your PR fulfills these requirements

[x] Multiple commits are squashed into one commit.
[x] The commit message follows Conventional Commits, which allows us to autogenerate release notes; e.g. fix(plugins/plugin-k8s): fixed annoying bugs
[x] All npm dependencies are pinned.

/lgtm
/approve


Add source, creator and tag links to the single result page media info

Fixes

Fixes #2730 by @obulat
Description

This PR updates the single result page's creator, source and tag links to the new designs, linking them to the collection pages.
Audio

Image

If the creator and source names are longer than the page width, they become scrollable. Setting up the scrolling to work in both LTR and RTL was a bit complex.
Note that the link URLs will be updated after #3140 is merged because it's impossible to add a link to a localized page that does not exist (and we don't currently have pages for source/creator/tag collections).
Testing Instructions

Run the app
Go to localhost:8443/preferences and switch the additional_search_views flag on
Go to single result pages for audio and image.
The source, creator and tag should have an updated style with correct links (/image/tag/cat, /image/source/flickr, /image/source/flickr/creator/name). Note that i18n (linking to the correct locale if you are not on the English one) does not work yet because the pages for tag/source/creator do not exist yet. The links also do not open the pages because the pages are created in #3140
When the creator and the source name are longer than the available width, they become scrollable. To check, see http://localhost:8443/image/8c8f2318-acc8-477c-a059-34f44901933e?q=cat
Checklist

[ ] My pull request has a descriptive title (not a vague title likeUpdate index.md).
[ ] My pull request targets the default branch of the repository (main) or a parent feature branch.
[ ] My commit messages follow best practices.
[ ] My code follows the established code style of the repository.
[ ] I added or updated tests for the changes I made (if applicable).
[ ] I added or updated documentation (if applicable).
[ ] I tried running the project locally and verified that there are no visible errors.
[ ] I ran the DAG documentation generator (if applicable).

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

Youtube tags also have the same behavior

Comparing our implementation with the youtube one, I think the youtube tags don't have as much of a jarring experience to me for two reasons:

There isn't the jitter of the arrows causing the tags to jump around
The arrow disappears immediately after clicking when it would scroll to the end. In other words, it doesn't scroll to the end and then hide the arrow. It hides the arrow before it hits the end, after you've clicked the last possible "scroll".
It scrolls much faster and further, and feels more responsive, so I'm less inclined to rapidly click the scroll button to get to the end.

A lot of that is definitely improved a lot now though. The only weird thing I'm noticing is that on image/8c8f2318-acc8-477c-a059-34f44901933e I have to click twice on the right scroll to get to the end, but once I'm at the end, only once on the left scroll to get back to the start :thinking: I don't know what could be causing that.
Maybe we could use real-time calculation of scroll distance? Like, scroll at least 2/3 the width of the container every time, but fudge that a bit so that we're never scrolling less than 1/3? I don't know exactly how to make that math work out, but the idea would be that you'd never have a scroll button press that only scrolled a tiny amount, which is what's happening with the second click of the right scroll for me on that result. Here's a video showing that.
Screencast_20231123_121008.webm
Probably not blocking, but I haven't fully re-reviewed now. The improvements are awesome though, for sure. I'll re-review tomorrow morning (logging off for the day now).

Great comments here. Three topics have been touched, so grouping them to share my thoughts.
Filters interaction
Thanks @sarayourfriend for sharing your use case. The reason behind using arrows (visible or hidden when reaching the end) comes from an a11y assumption of providing controls, and because some filters' text lengths are quite long and need to be contained within the area.
I revisited YouTube again and you're right about the behavior. But I also noticed that buttons are hidden on mobile. It might be because touch interaction predominates in small devices and the scroll relies on swiping, so removing the arrows on small breakpoints could be a good idea.
If we can test your suggestion in a different ticket, it would be great to decide which interaction feels smoother. So far, I would merge this PR as it is.
Testing the implementation

I also experienced this (and got really annoyed with it) when developing this locally.

I'd like to reinforce the idea that design work is not written in stone. If you experience something that feels weird, unexpected, or literally breaks up your experience as a user, please share it. I've been contributing to other WordPress projects and noticed that we don't tend to discuss design ideas and instead develop what's on mockups.
We all are Openverse users and our experiences with the tool provide tremendous value.
Visible focus

There is a tiny sliver of the purple outline, but otherwise there's no indication that it is focused and, worse, the button is focused but not in view

I've mentioned this problem in other tickets and raising the question again of whether is possible to address it for the whole site. If we continue revisiting the focus style per case, we risk missing future use cases like this one, where I completely forgot about it.
We can move the discussion into a different ticket, indeed. But to me, this component style belongs to a core state that should not be in revision because of possible layout breaks.

I'd like to reinforce the idea that design work is not written in stone. If you experience something that feels weird, unexpected, or literally breaks up your experience as a user, please share it. I've been contributing to other WordPress projects and noticed that we don't tend to discuss design ideas and instead develop what's on mockups.

We all are Openverse users and our experiences with the tool provide tremendous value.

Thank you for reminding about this, @fcoveram! You are right that we should all be more mindful about the UX when working on the frontend issues.

We can move the discussion into a different ticket, indeed. But to me, this component style belongs to a core state that should not be in revision because of possible layout breaks.

The core state does have the focus state implemented. However, when an element or its container has a CSS position set, the focus ring gets cut off. It still exists, but it's hidden behind other elements, so it becomes useless. I think it would be nice to open an issue for a better fix for this problem than what I implemented here (adding a padding to the container and removing some of the margins to balance the height with the mockup.

The core state does have the focus state implemented.

You are right, I didn't explain myself correctly. It is part of the component.

I think it would be nice to open an issue for a better fix for this problem…

Mainly to suggest ideas and land on a solution like adding extra space as we do it but from the design stage or another one I'm unaware of.

The only weird thing I'm noticing is that on image/8c8f2318-acc8-477c-a059-34f44901933e I have to click twice on the right scroll to get to the end, but once I'm at the end, only once on the left scroll to get back to the start 🤔 I don't know what could be causing that.

I think this was caused by 2 things. The issue has suggested using scroll-snap for scrolling. When I added it, it was causing a problem when the buttons were about as long as the scroll width: you could not scroll past them.
Scroll snap problem.webm
I removed the scroll snap and also adjusted scrolling for the last two steps: when the distance left is less than 2 scroll steps, the scroll step becomes half of this distance. So, if the distance left is 200, we don't scroll 150px and 50px (scroll step and what's left), but scroll 100px and 100px instead.
Here's the updated scrolling:
Scrolling.webm

It scrolls much faster and further, and feels more responsive, so I'm less inclined to rapidly click the scroll button to get to the end.

@sarayourfriend, do you think it would make sense to increase the scroll step? I took 150px as "about half of the screen on mobile width", but it might be better to have larger steps?

I revisited YouTube again and you're right about the behavior. But I also noticed that buttons are hidden on mobile. It might be because touch interaction predominates in small devices and the scroll relies on swiping, so removing the arrows on small breakpoints could be a good idea.

I looked at Facebook and Google maps on mobile, and neither of them has arrows for their horizontally scrollable list of tags. I guess this is the behavior users expect, so I would vote for removing the arrows on mobile.

If we can test your suggestion in a different ticket, it would be great to decide which interaction feels smoother. So far, I would merge this PR as it is.

Merging this PR would make it easier to test the PR that adds collection pages, so I would be happy to do as you suggest. @sarayourfriend , do you think this is okay as is, considering that it's under a feature flag and we can open new issues to keep iterating?


[iOS] Apply app icons

What to do
No app icon is set for iOS app for now.
Please download the icons from the following Figma link and apply them.
Design
https://www.figma.com/file/MbElhCEnjqnuodmvwabh9K/DroidKaigi-2023-App-UI?type=design&node-id=55674-97357&mode=design&t=kf8tT9D4davWhDvh-0

🙋♂

Thanks! Assigned you!


ROT47 decoder

Finished ROT47 decoder.

I made the mistake to commit and push without making a new branch, so I reverted those changes and pushed them to a new branch, I apologize for any inconvenience

Hey, unfortunately ROT47 is a cracker, not a decoder so we can only accept submissions in the form of C++ code. We already have a ROT26 cracker, so to make it ROT47 I am under the assumption that we only need to change the alphabet out.

No it's not, this is a decoder

honestly

Hey, please fix this:
       for character in encrypted_words:
>           decoded_words += decoder_dict.get(character)
E           TypeError: can only concatenate str (not "NoneType") to str

You can test it is fixed by running pytest on your machine :)

I'm closing this because ROT47 will actually need to be a C++ cracker. ROT47 uses an alphabet of ASCII characters 33 to 126, making an alphabet length of 94. Only adding ROT47 would be like only adding ROT13 without adding ROT 1-25.
We'll need a cracker that can decode ROT 1-94 using the ROT47 alphabet. It should be easy to just use the existing caesar cracker with the ROT47 alphabet.


TrafficManagerProfile.WithoutEndpoint removes the incorrect endpoints

With package version 1.13.0, the TrafficManagerProfile.WithoutEndpoint only "keeps" the endpoint from input parameter other than "removes" it, for example:
In the profile there are three endpoints - endpoint1, endpoint2 and endpoint3.
profile.Update().WithoutEndpoint("endpoint2").Apply() removes endpoint1 and endpoint3 but the expected behavior should remove endpoint2 only.
When debugging into the IUpdate object of profile, I saw the endpoint2 is marked as "ToBeRemoved" in the "PendingOperation" field and Fiddler API confirms the deletion is for endpoint2.
But when calling to Apply() method, the "Put" request does NOT pass the correct traffic manager profile model (which contains the endpoint to be deleted in the profile), I think that's the cause of this issue.

@allenjzhang  Assigning Fluent bug related to you

Given the age of this issue and the pending deprecation of the Fluent management packages, I'm going to close this out as stale.   Please feel free to reopen if further discussion is needed.


Question regarding fine tunning

If I train the hifi-gan vocoder using fine tunning approach, which uses Tacotron 2 to generate Mel in the first place. Can I use the regular glow-tts generated Mel with the above trained hifi-gan vocoder and achieve same quality during the inference or do I have to shift to Tacotron 2 altogether during the inference too?

@jaywalnut310 Any input regarding this query?

Did this on my own. If any one needs help can share my colab and instructions.

Hi would you be able to share your Colab on how you did this? We are trying to do the same thing using glowtts mel to train hifigan and are running into trouble

Did this on my own. If any one needs help can share my colab and instructions.

Would you be able to share your colab and instructions we’ve been stuck on this for weeks

@michaellin99999 It has been long time and I don't recall the process exactly and I currently don't have access to infra to test out the script.
But hopefully the below steps should work.

Clone the Tacotron 2 Nvidia official repo and in the main directory of the copy the two attached files finetunning.zip
Run the extract_teacher_force.py script. A sample command with various arguments is present at the last line of the file.

Let me know if this works out for you.

is it the same method even with GlowTTS?

@michaellin99999 It has been long time and I don't recall the process exactly and I currently don't have access to infra to test out the script.
But hopefully the below steps should work.

Clone the Tacotron 2 Nvidia official repo and in the main directory of the copy the two attached files finetunning.zip
Run the extract_teacher_force.py script. A sample command with various arguments is present at the last line of the file.

Let me know if this works out for you.

is it the same method even with GlowTTS?
and Nvidia official repo is it this one? https://github.com/NVIDIA/tacotron2
we are trying to use glow-tts generated Mel to train /fine tune Hifigan, I am a bit confused why do we use the Tacotron repo. Is the logic that the extract_teacher_force.py script is ran to automatically generate mel spectrograms that can be fed into Hifigan?

Yes. that if the correct repo.
To explain the fine tunning in simple terms, there are two ways to generate the Mels that are can be used during the training phase. You use the actual audio files and use deterministic algorithm to get the true Mels. But this is ideal scenario and during the inference phase usually the mels predicted won't be that perfect. So what do we do, we predict the mels from a pretrained Tacotron 2 model because given it's auto-regressive nature, we can create the Mels which match the exact length of the input audio file and as these are predicted Mels, thus using these predicted Mels during training phase would help the hifi-gan to learn better and be little more resilient to noisy (less than perfect) Mels, thus perform little better during inference phase.
Once you generate the Mels from the fine-tunning step, you can store the same and use these stored mels during the Hifi-gan training phase. You probably don't want to use these mels during the glow-tts training phase, there you would be better in using the actual mels generated from the underlying audio file, as the goal of the glow-tts training is to be able to generate Mels as close as possible to original.
Hope I was able to explain it to you. Let me know if you have any doubts.

Yes. that is the correct repo.
To explain the fine tunning in simple terms, there are two ways to generate the Mels that are can be used during the training phase. You use the actual audio files and use deterministic algorithm to get the true Mels. But this is ideal scenario and during the inference phase usually the mels predicted won't be that perfect. So what do we do, we predict the mels from a pretrained Tacotron 2 model because given it's auto-regressive nature, we can create the Mels which match the exact length of the input audio file and as these are predicted Mels, thus using these predicted Mels during training phase would help the hifi-gan to learn better and be little more resilient to noisy (less than perfect) Mels, thus perform little better during inference phase.
Once you generate the Mels from the fine-tunning step, you can store the same and use these stored mels instead during the Hifi-gan training phase. You probably don't want to use these mels during the glow-tts training phase, there you would be better in using the actual mels generated from the underlying audio file, as the goal of the glow-tts training is to be able to generate Mels as close as possible to original.
Hope I was able to explain it to you. Let me know if you have any doubts.

Thank you for the explanation, Just to confirm I udnerstand correct, basically its best to obtain mels from tacotron and use the mels to train hifigan. Later when I connect glowtts with hifigan, other than the config and audio parameters, they should work in sequence to synthesize audio?

Yes. that is the correct repo.
To explain the fine tunning in simple terms, there are two ways to generate the Mels that are can be used during the training phase. You use the actual audio files and use deterministic algorithm to get the true Mels. But this is ideal scenario and during the inference phase usually the mels predicted won't be that perfect. So what do we do, we predict the mels from a pretrained Tacotron 2 model because given it's auto-regressive nature, we can create the Mels which match the exact length of the input audio file and as these are predicted Mels, thus using these predicted Mels during training phase would help the hifi-gan to learn better and be little more resilient to noisy (less than perfect) Mels, thus perform little better during inference phase.
Once you generate the Mels from the fine-tunning step, you can store the same and use these stored mels instead during the Hifi-gan training phase. You probably don't want to use these mels during the glow-tts training phase, there you would be better in using the actual mels generated from the underlying audio file, as the goal of the glow-tts training is to be able to generate Mels as close as possible to original.
Hope I was able to explain it to you. Let me know if you have any doubts.

Thank you for the explanation, Just to confirm I udnerstand correct, basically its best to obtain mels from tacotron and use the mels to train hifigan. Later when I connect glowtts with hifigan, other than the config and audio parameters, they should work in sequence to synthesize audio?

Yes.These stored Mels generated is to be used only for Hifigan training phase. During the inference phase there is no need for the Tacotron.

Yes. that is the correct repo.
To explain the fine tunning in simple terms, there are two ways to generate the Mels that are can be used during the training phase. You use the actual audio files and use deterministic algorithm to get the true Mels. But this is ideal scenario and during the inference phase usually the mels predicted won't be that perfect. So what do we do, we predict the mels from a pretrained Tacotron 2 model because given it's auto-regressive nature, we can create the Mels which match the exact length of the input audio file and as these are predicted Mels, thus using these predicted Mels during training phase would help the hifi-gan to learn better and be little more resilient to noisy (less than perfect) Mels, thus perform little better during inference phase.
Once you generate the Mels from the fine-tunning step, you can store the same and use these stored mels instead during the Hifi-gan training phase. You probably don't want to use these mels during the glow-tts training phase, there you would be better in using the actual mels generated from the underlying audio file, as the goal of the glow-tts training is to be able to generate Mels as close as possible to original.
Hope I was able to explain it to you. Let me know if you have any doubts.

Thank you for the explanation, Just to confirm I udnerstand correct, basically its best to obtain mels from tacotron and use the mels to train hifigan. Later when I connect glowtts with hifigan, other than the config and audio parameters, they should work in sequence to synthesize audio?

Yes.These stored Mels generated is to be used only for Hifigan training phase. During the inference phase there is no need for the Tacotron.

Thanks so much, will try this out and see.

one more question, regarding the audio parameters. other than fmin and fmax, what other paramters are critical that I must keep the same across glow and hifigan? or everything should be the same?

one more question, regarding the audio parameters. other than fmin and fmax, what other paramters are critical that I must keep the same across glow and hifigan? or everything should be the same?

Given that my training audio data was 22050Hz I kept the fmin and fmax unchanged. I don't remember any other critical parameter. Although if I recall correctly, I did use the parameter to turn the add noise flag off, as without adding noise during the training phase the output seemed to me marginally better. But this difference was very low, and can be matter of personal judgement. Basically the default parameter seemed to be working OK.

@michaellin99999 It has been long time and I don't recall the process exactly and I currently don't have access to infra to test out the script.
But hopefully the below steps should work.

Clone the Tacotron 2 Nvidia official repo and in the main directory of the copy the two attached files finetunning.zip
Run the extract_teacher_force.py script. A sample command with various arguments is present at the last line of the file.

Let me know if this works out for you.

Hello, I have tried these steps, generate mel-spectrogram by run your extract_teacher_force.py script. But when I put it in hifigan's folder, and follow it's fine tunning step

And I got this error

What possible reason could this happended? Thanks!

There is a slight difference between the padding logic of Tacotron 2 and glow tts. You can copy few lines from the glow tts and replace them in the tacotron 2 library to make that padding logic same.

Thanks for replying.
Another question, do you have any idea of how to verifiy the mel-spectrogram that generated by your extract_teacher_force.py script?
I try to use librosa to inverse back to wav, but it sounds like nothing.


Retry automatically on Play Store API authorization errors

See here for more details: https://github.com/fastlane/fastlane/issues/21091

Handled #557


feat: don't call OCM in development environment testing for clusters with standalone ProviderTypes

Description
The nightly tests failed due to tests I added. In which the kas-fleetshard-sync mocks were unable to get ocm addons.
Cluster '<clusterId>' not found
This pr, removes calls the OCM for clusters with ProviderType standalone. Which will prevent the previous test and similar tests failing.
Verification Steps
You can run the tests against development environment with the following:

Run ngrok http 8180
Set the kafka mas-sso-base-url to the ngrok url Here
Set the connectors mas-sso-base-url to the ngrok url also Here
Run the tests with OCM_ENV=development TEST_TIMEOUT=3h make test/integration

Checklist (Definition of Done)

[ ] All acceptance criteria specified in JIRA have been completed
[ ] Unit and integration tests added that prove the fix is effective or the feature works (tested against emulated and non-emulated OCM environment)
[ ] Documentation added for the feature
[ ] CI and all relevant tests are passing
[ ] Code Review completed
[ ] Verified independently by reviewer
[ ] All PR comments are resolved either by addressing them or creating follow up tasks
[ ] Required metrics/dashboards/alerts have been added (or PR created).
[ ] Required Standard Operating Procedure (SOP) is added.
[ ] JIRA has been created for changes required on the client side

The change lgtm.
I'll let @miguelsorianod review and approve.

lgtm


Rename "Add to Home Screen" docs "Install (something)"

This was brought up in another doc, but our PWA Install docs are called Add to Home Screen, which can be somewhat confusing and isn't accurate for desktop. It also calls out WebAPKs early in the doc, which again, for desktop isn't relevant.
I'm open to suggestions about what/how to rename them.

Make a Progressive Web App Installable
App Install Prompts
Other suggestions?

cc @b1tr0t @dominickng @snugug

There are two places where "Add to Home Screen" are used, in the title and throughout to describe the prompt. I like renaming the page "Make a Progressive Web App Installable", changing the first line to The Web App Install Prompt, sometimes referred to on mobile Add to Home Screen,, and then elsewhere in the article describing it simply as "App Install Prompt" or "Install Prompt" (it's used in headings and throughout content). I especially like this because the event is beforeinstallprompt, which then ties back in to what we're calling it.

Would +1 focusing on install.  There  is currently an experiment to rename A2HS => Install on mobile as well.  Too early to call results but it is trending neutral which means I am in favour of normalizing on Install to make it more coherent with desktop for users and doc writers.


confgi.skipUrlNormalization option

This must have been done a long time ago, all assets like images and fonts can be copied over preserving structure of folders.
Contra: if 2 libs have same image001.jpg then we have a collision

I think you meant to submit a PR against the official repo https://github.com/guybedford/require-css?

Hi, nope, the official repo guy thinks his masterpiece is perfect, I'd
rather work with contributing people. Cheers.
Am Dienstag, 19. Mai 2015 schrieb asavoy :

I think you meant to submit a PR against the official repo
https://github.com/guybedford/require-css?
—
Reply to this email directly or view it on GitHub
https://github.com/asavoy/require-css/pull/1#issuecomment-103280969.


Add centosah

I asked @abutcher to take a gander.

I hit this while attempting to test https://gist.github.com/cooktheryan/2facf392c7ad871df2b12997eb22d02a with virtualbox

Any comments on the fixup?  I know the notice may have been lost due to the github outage.

@cgwalters if you can hook me up with a quick how to guide on performing the steps I would be glad to help validate. I attempted the other day but ran into an issue when it was attempting to run a network manager restart

@cooktheryan do you happen to have the output of the issue you ran into?

@ashcrow @cgwalters https://gist.github.com/cooktheryan/6bb6b23364e00ea6851abe08511172f9

-- Unit network.service has begun starting up.
Dec 09 19:30:12 master1.example.com network[12528]: Bringing up loopback interface:  Could not load file '/etc/sysconfig/network-scripts/ifcfg-lo'
Dec 09 19:30:12 master1.example.com network[12528]: Could not load file '/etc/sysconfig/network-scripts/ifcfg-lo'
Dec 09 19:30:12 master1.example.com network[12528]: Could not load file '/etc/sysconfig/network-scripts/ifcfg-lo'
Dec 09 19:30:13 master1.example.com network[12528]: Could not load file '/etc/sysconfig/network-scripts/ifcfg-lo'
Dec 09 19:30:13 master1.example.com network[12528]: [  OK  ]
Dec 09 19:30:13 master1.example.com network[12528]: Bringing up interface eth0:  Error: Connection activation failed: No suitable device found for this connection.
Dec 09 19:30:13 master1.example.com network[12528]: [FAILED]
Dec 09 19:30:13 master1.example.com network[12528]: RTNETLINK answers: File exists
Dec 09 19:30:13 master1.example.com network[12528]: RTNETLINK answers: File exists
Dec 09 19:30:13 master1.example.com network[12528]: RTNETLINK answers: File exists
Dec 09 19:30:13 master1.example.com network[12528]: RTNETLINK answers: File exists
Dec 09 19:30:13 master1.example.com network[12528]: RTNETLINK answers: File exists
Dec 09 19:30:13 master1.example.com network[12528]: RTNETLINK answers: File exists
Dec 09 19:30:13 master1.example.com network[12528]: RTNETLINK answers: File exists
Dec 09 19:30:13 master1.example.com network[12528]: RTNETLINK answers: File exists
Dec 09 19:30:13 master1.example.com network[12528]: RTNETLINK answers: File exists
Dec 09 19:30:13 master1.example.com systemd[1]: network.service: control process exited, code=exited status=1
Dec 09 19:30:13 master1.example.com systemd[1]: Failed to start LSB: Bring up/down networking.

Can you post the output of atomic host status and ls -alZ /etc/sysconfig/network-scripts/ifcfg-lo and look at journalctl -b -p err etc?

For me:
# atomic host status
State: idle
Deployments:
● centos-atomic-continuous:centos-atomic-host/7/x86_64/devel/alpha
       Version: 7.2016.1024 (2016-12-09 21:17:00)
        Commit: f0894de40ef404555cf794d9d279eab03839738bf84ea6f9703c80ca79c2903b
        OSName: centos-atomic-host
# systemctl status network
● network.service - LSB: Bring up/down networking
   Loaded: loaded (/etc/rc.d/init.d/network; bad; vendor preset: disabled)
   Active: active (exited) since Mon 2016-12-12 20:56:58 UTC; 8min ago
     Docs: man:systemd-sysv-generator(8)
  Process: 881 ExecStart=/etc/rc.d/init.d/network start (code=exited, status=0/SUCCESS)

Dec 12 20:56:58 localhost.localdomain systemd[1]: Starting LSB: Bring up/down networking...
Dec 12 20:56:58 localhost.localdomain network[881]: Bringing up loopback interface:  [  OK  ]
Dec 12 20:56:58 localhost.localdomain network[881]: Bringing up interface eth0:  [  OK  ]
Dec 12 20:56:58 localhost.localdomain systemd[1]: Started LSB: Bring up/down networking.

Got busy today will shoot you a log tomorrow
On Mon, Dec 12, 2016 at 4:05 PM, Colin Walters<EMAIL_ADDRESS>wrote:

For me:
atomic host status
State: idle
Deployments:
● centos-atomic-continuous:centos-atomic-host/7/x86_64/devel/alpha
Version: 7.2016.1024 (2016-12-09 21:17:00)
Commit: f0894de40ef404555cf794d9d279eab03839738bf84ea6f9703c80ca79c2903b
OSName: centos-atomic-host
systemctl status network
● network.service - LSB: Bring up/down networking
Loaded: loaded (/etc/rc.d/init.d/network; bad; vendor preset: disabled)
Active: active (exited) since Mon 2016-12-12 20:56:58 UTC; 8min ago
Docs: man:systemd-sysv-generator(8)
Process: 881 ExecStart=/etc/rc.d/init.d/network start (code=exited, status=0/SUCCESS)
Dec 12 20:56:58 localhost.localdomain systemd[1]: Starting LSB: Bring up/down networking...
Dec 12 20:56:58 localhost.localdomain network[881]: Bringing up loopback interface:  [  OK  ]
Dec 12 20:56:58 localhost.localdomain network[881]: Bringing up interface eth0:  [  OK  ]
Dec 12 20:56:58 localhost.localdomain systemd[1]: Started LSB: Bring up/down networking.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/openshift/openshift-ansible-contrib/pull/132#issuecomment-266552506,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ADoslCFCxss0BGu-_8ef24rhFzsWTxCMks5rHbclgaJpZM4K_LEy
.

We actually shouldn't have network.service enabled; https://github.com/CentOS/sig-atomic-buildscripts/pull/197

@cgwalters got a lot further during the installation process. I hit this wall on the admin box
==> admin1: Setting hostname...
==> admin1: Configuring and enabling network interfaces...
==> admin1: Installing SSHFS client...
The following SSH command responded with a non-zero exit status.
Vagrant assumes that this means the command failed!
dnf -y install fuse-sshfs
Stdout from the command:
bash: dnf: command not found
Stderr from the command:
[rcook@goku vagrant]$ rpm -qa | grep fuse-sshfs
fuse-sshfs-2.8-1.fc25.x86_64

You need fuse-sshfs on the VM too.  I've been doing rpm-ostree install fuse-sshfs ansible pyOpenSSL manually so far, at some point we'll do https://pagure.io/fedora-atomic/issue/38

I'd also like to look at migrating the ansible invocations into a container.

[vagrant@admin1 ~]$ sudo rpm-ostree install ansible
Checking out tree f0894de... done

Downloading metadata: [======================================================================================================================================================================================] 100%
error: No package matches 'ansible'
/

You need to install EPEL too:
(cd / && curl https://dl.fedoraproject.org/pub/epel/epel-release-latest-7.noarch.rpm  | rpm2cpio | cpio -div)

@cgwalters after installing those items and re-running the <DEPLOYMENT_TYPE=origin ORIGIN_OS=centos-ah vagrant up --provider=virtualbox> command but the one question I have is there a way to cloud-init those items or have an if script so that the items tasks that need to be done are completed?

Unfortunately there's no good way to do that right now because vagrant-sshfs injects its run before any provisioners are called.   It currently installs EPEL automatically which I think is a bit presumptuous; I filed https://github.com/dustymabe/vagrant-sshfs/issues/63
This does suck but I'm trying not to get bogged down by every problem in the the chain.  Maybe I can create a one-liner for this.

@cgwalters did you still want to look at a 1 liner for this or should we move forward?

@cooktheryan I recommend moving forward. The one liner could be done as a later follow on if needed.

OK, so I baked in fuse-sshfs into the CAHC boxes by default.  This works a bit better now, can you retry?

I got tied up today so I should be able to test this on monday

To be really seamless I need to finish porting to run Ansible from a container; see ⬆

@cgwalters if you want to resolve those conflicts ill test and merge

Is this still being pursued?

@cgwalters Is this still being pursued?


Spaceship::Tunes::AppVersion#url uses hard-coded app id

New Issue Checklist

[✓] Updated fastlane to the latest version
[✓] I have read the Contribution Guidelines

Issue Description
Spaceship::Tunes::AppVersion#url uses a hard-coded app ID. I looked at the diff, and it used to use application.apple_id until last September. See https://github.com/fastlane/fastlane/blob/b7b8b5f960a330e1f0d514da958d6ecf918d5789/lib/spaceship/tunes/app_version.rb#L205.
Environment
I'm using Spaceship programmatically to build a private gem for internal use. I have spec.add_runtime_dependency 'spaceship' in my *.gemspec, which Bundler resolves to version 0.26.2.
Do you use a Ruby environment manager (e.g. chruby, rbenv, rvm)?
rbenv

@ravinggenius Thanks for pointing this out and working with us on the PR! Hope you have a great week 👍


@conda-forge-admin,please add bot automerge

Additional comment:
No response

Hi! This is the friendly automated conda-forge-webservice.
I just wanted to let you know that I added bot automerge in conda-forge/mdacli-feedstock#7.


Fix read again fail on timeout err

When calling callback function returned by etcd:watchdir, if timeout err occured, the callback function can't be called the 2nd time, since the http lib does not restart read chunk size.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Allow us to extend the Order Criteria in Order State Transition Emails

Description
The order data passed to order state transition emails resolves only the bare minimum of data that is required for the standard emails (that ship with shopware) to be rendered.
More advanced shops might want to provide their customers with order information, that are not being provided by the current implementation. For example, currently, it is impossible to render the order details, since the currency information of that order are not being resolved, when the order is loaded.
The easiest way to fix this would be to allow developers to extend the $criteria object that loads the order entity from the repository.
Shopware\Core\Checkout\Order\Api\OrderActionController
private function getOrderCriteria(?string $orderId = null): Criteria
{
    if ($orderId) {
        $orderCriteria = new Criteria([$orderId]);
    } else {
        $orderCriteria = new Criteria([]);
    }

    $orderCriteria->addAssociation('orderCustomer.salutation');
    $orderCriteria->addAssociation('stateMachineState');
    $orderCriteria->addAssociation('transactions');
    $orderCriteria->addAssociation('deliveries');
    $orderCriteria->addAssociation('salesChannel');

    return $orderCriteria;
}

A simple custom event passed to the event dispatcher would help us, adding further associations if we need them.

Hello,
thank you for creating this issue.
I have opened a ticket on our Issue Tracker for you. See the ticket link: https://issues.shopware.com/issues/NEXT-7782
Please use this ticket to track the state of your issue.

Hi @AlexBachmann
I have imported this issue to our internal ticket system.
If you don't want to wait for us to fix this, an pull request is very welcome :)
If this is okay for you I'd like to close this issue here. You can keep track of your Issue with the link provided above
Sunny regards
Pantrtxp

Hello,
Within our company roadmap and work capacity, we try to address each bug or improvement request but admit that not each one will be resolved. To continue our culture of honesty and openness, we are closing this issue to focus on our roadmap on behalf of all Shopware users.
If you feel like this issue is still impacting you, please create a new issue and let us know.
Thank you again for your valuable feedback.


Issue authoring a custom tag helper in F#

I had been trying to write a custom tag helper in F#, however I've ran into an issue where the tag helper seems to ignore the given HtmlTargetElementAttribute—it instead ends up applying to every tag on the page.
The following is a reduced case with which I could reproduce this issue myself; as far as I understand, this should only match on <test>:
[<HtmlTargetElement ("test", TagStructure = TagStructure.NormalOrSelfClosing)>]
type CustomTagHelper () =
    inherit TagHelper ()

    override __.Process (_, output) =
        output.Content.SetContent("Test")
        |> ignore

If I look at that in something like ILSpy, the attribute line displays in C# as
[HtmlTargetElement("test", TagStructure = )]

though I'm not sure if that actually affects the resulting IL or if that's just a display bug with ILSpy itself. However, if I remove the TagStructure property from the attribute, the tag helper works as expected only on the targeted elements. After that, I tried saving the enum value in a separate constant
[<Literal>]
let tagStructure = TagStructure.NormalOrSelfClosing

and using that in the attribute instead of the enum value, which works correctly as well. But then I changed that constant to a different enum value, and reverted the attribute definition to what I started with, then that worked. And then removing the constant broke it again. So I'm wondering if this is some issue with the F# compiler instead, in which case this is in the wrong repo (sorry).
I should also note that this occurs regardless of which TagStructure value I use, not just NormalOrSelfClosing.

Hi @Cartermp, can you please look into this? Thanks!

@kevinransom and @dsyme could this be related to the recent issue with literals?

Just as an update, I'm thinking that the part about the literal value was a bit of a red herring. The issue occurs without the literal, and actually it turns out that the issue is avoided when the enum is referenced anywhere, whether as a literal or not. I mentioned it being a literal in the original post since I was trying to use that value in the attribute, but afterwards I didn't think to try it as just a normal value.
However I did notice something else in ILSpy, though I'm not sure how relevant this is either. In the base case, when the tag helper wasn't working correctly, ILSpy sees the references as:
// Referenced assemblies (in metadata order):
// mscorlib, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=b77a5c561934e089 (unresolved)
// Microsoft.AspNetCore.Razor.Runtime, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=adb9793829ddae60 (unresolved)
// FSharp.Core, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a (unresolved)

But when the TagStructure is referenced anywhere in the project, then that section reads:
// Referenced assemblies (in metadata order):
// mscorlib, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=b77a5c561934e089 (unresolved)
// Microsoft.AspNetCore.Razor.Runtime, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=adb9793829ddae60 (unresolved)
// FSharp.Core, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a (unresolved)
// Microsoft.AspNetCore.Razor, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=adb9793829ddae60 (unresolved)

Microsoft.AspNetCore.Razor being where TagStructure is declared. In fact, referencing anything in that assembly seems to have the same effect. However, that assembly was in the project the entire time, and it compiles without an issue.
I'm afraid I don't know enough about this to be of much help, and for all I know this whole thing is just a user error on my part. Let me know if you need more information.


[WIP] Improve error handling

WIP for #291

Currently adding error messages based on context. However, I'm not familiar with the code base so thorough review is highly recommended to improve error messages
... especially for the fzf and core modules.

TODO:

[x] Every call to bash now has an error message similar to "Failed to execute bash". This should probably be related to the actual command ran, i.e. params given to bash.
[x] A lot of anyhow::[with_]context() is used to add, well, context. It might be better to create custom error variants for repetitive errors.
[x] navi fn welcome is broken.
[x] Add "file a bug report" message to top-level error.
[x] Test for potential breakages. Logic changes have been avoided as much as possible but stuff happens.
[x] navi repo browse and navi repo add https://github.com/denisidoro/navi crash. Root cause is fzf not returning data due to window layout error.

[ ] bump version

My approach currently is to:

eliminate all unwrap(), except in tests
expect() when calling an internal function with highly controlled input, since these "ugly" panic messages ~will~ should only ever be seen by devs.
return as much Result as possible, as the added context to each layer of errors will be nicely formatted and hopefully useful for the end-user.

The navi repo bug is fixed in master 👍

Kindly re-review changes. Please check whether the actual messages are clear.
Also added a wrapping error telling the end-user to file an issue. Ex:

This required the error type FileAnIssue to be made public in the library. It had to be used in the bin. handle_config is called multiple times so it would look weird to potentially have multiple of these messages nested. Is this change ok?
A few things remain to be done as can be seen in the TODO of the first post.

Would this be a bump in version to 2.4.0?


Bump up golangci-bin version

Bump up golangci-bin version to v1.50.0
Remove invalid configurations in golangci.yml
Formated several files

Signed-off-by: wenyingd<EMAIL_ADDRESS>

@antoninbas We found that golangci-bin v1.41.1 may introduce unexpected golint validation failures ( https://github.com/antrea-io/libOpenflow/pull/31 ), so I make this patch to bump up its version to v1.50.0 which is used in antrea. Could you help review it?

Hi @antoninbas , I updated the patch to remove unused code ( all for padding messages), would you help review it again?


guidance with software

So I just received a batch of 3 Picoclick-C3 devices.
The device is really well made, great job @makermoekoe !!
The thing I'm now stuck with is that I don't see an easy path for integrating the devices into my Home Assistant setup?

I have many ESPHome-based devices around the house, but that doesn't look like a great option, ESPHome will likely kill the battery life - even with deepsleep.
MQTT might be an option, but I have zero experience with the Arduino-IDE...
... ?

So, is anyone using the Picoclick-C3 with Home Assistant? How?
Failing anyone with Home Assistant experience, what would be the best way to achieve this ?

Great to hear so, thank you!
Unfortunately I've either not worked with Home Assistant nor with ESPHome yet, but we will somehow get it working. MQTT is probably one of the easiest ways to get it to work, but the Picoclick would get a delay from the button press to sending its message because it has to connect to the router first.
How do you program your ESPHome devices? Is it possible to equip one of these devices with a modified/custom code? Then the best solution would be to act one of those as an ESPNOW master device, which will act as a broker between your Picoclicks and your smart home. In this case you will get an immediate response in your smart home like shown in the Youtube video of the Picoclick.
If this isn't possible you can set up an extra ESP device to be the broker/bridge between the Picoclicks and the smart home.

I've been using a few of these : Hugo-ESP8266 , they are using MQTT, and I'm very happy with the latency. But they are using a batt with much higher capacity.
No longer available, so I went looking for alternatives & came across Picoclick.
ESPHome compiles a yaml file and offers to upload via OTA, or USB, or download the binary fw and use a flasher software on your computer.
People have been trying to include an ESPNOW component into ESPHome, but it isn't there (yet)... https://github.com/iphong/esphome-espnow
"...set up an extra ESP device to be the broker/bridge..." this would certainly be an option, have you got a specific tutorial in mind ?

Would you mind sending the bin files for flashing please ?

I've finally set up my first Home Assistant instance and I'm very pleased by it. So happy about it that I shifted all my smart home devices to work with HA.
In addition to this I started to work with ESPHome as well, which seems to be a very useful tool for non-battery powered devices (haven't played with deep sleep in ESPHome at all). Thus I think integrating the Picoclicks to ESPHome is not the best solution.
Nevertheless I wanted to integrate them to HA so I tried this by using the MQTT plugin. But as I want to use ESPNow for the Picoclicks because it is way faster and extends battery life I set up a ESPNow to MQTT bridge using an ESP32-S2 Thing board from Sparkfun (should be possible with any ESP based board). I published both the Picoclick code and the bridge code a couple days ago.
After installing the MQTT plugin in HA I added this code to the configuration.yaml  which will create three entities for the Picoclick device (battery voltage, battery percentage and binary_sensor):
`sensor:

platform: mqtt
name: Battery_Picoclick1
state_topic: "home/node1234/battery"
device_class: voltage
unit_of_measurement: "V"
value_template: "{{ value | round(0)}}"
platform: mqtt
name: BatteryLevel_Picoclick1
state_topic: "home/node1234/batterylevel"
device_class: battery
unit_of_measurement: "%"
value_template: "{{ value | round(0)}}"

binary_sensor:

platform: mqtt
name: Picoclick1
state_topic: "home/node1234/value"
payload_on: true
payload_off: false
value_template: "{{ value | int > 0 }}"`

All in all this is working brilliant. It is running a couple days now without any problems or interruptions. You won't even notice a delay between pressing the Picoclick and the actuation in HA.
Btw. you don't even have to create entities for the Picoclick, you can use it within the automations of HA directly (via MQTT) which will looks like this for toggling an outlet:
`alias: Picoclick1_automation
description: ''
trigger:

platform: mqtt
topic: home/node1234/value
payload: '1.00'
condition: []
action:
type: toggle
device_id: YOUR_DEVICE_ID
entity_id: YOUR_ENTITY_ID
domain: switch
mode: single`

Hope this helps. If you have questions then please let me know! I'm now on the road to become a HA pro 😄

I'd like to know exactly what firmware you are flashing ?


[Always-On-Top] Adding border radius to always-on-top window outlline

Description of the new feature / enhancement
Add border-radius to the always-on-top window outline(Sky blue).
Scenario when this would be used?
When the user envokes always-on-top for a particular window
Supporting information

.

/dup #15284


Foundation model training details

Congrats on this foundation model.
Your publication doesn't mention anything about training time, hardware requirements, and costs. Could you elaborate on this?
Best regards

Always insightful and good to know! Thanks

@mamscience  have a look at the colab notebook here for fine-tuning: https://colab.research.google.com/drive/1uvTmh-pe1zO5TeaaRVDdoEWJ5dFDI-pA?usp=sharing


adding eShop demo

Purpose

...

Does this introduce a breaking change?

[ ] Yes
[ ] No

Pull Request Type
What kind of change does this Pull Request introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

How to Test

Get the code

git clone [repo-address]
cd [repo-name]
git checkout [branch-name]
npm install

Test the code

What to Check
Verify that the following are valid

...

Other Information

Could you also update the README.md in the root of the repo?

@philon-msft what content do you want me to put in the README.md in the root of the repo?

Could you also update the README.md in the root of the repo?

@philon-msft what content do you want me to put in the README.md in the root of the repo?

Whatever is necessary to make it look like this is an official/professional repo owned by our service. We should describe its purpose and link to our public documentation. We should also list the project you're adding and include a link to its location in the repo. I'd format the README so it's easy to add more demo projects in the future. The README in our samples repo may be a helpful example: https://github.com/Azure-Samples/azure-cache-redis-samples/blob/main/README.md

Could you also update the README.md in the root of the repo?

@philon-msft what content do you want me to put in the README.md in the root of the repo?

Whatever is necessary to make it look like this is an official/professional repo owned by our service. We should describe its purpose and link to our public documentation. We should also list the project you're adding and include a link to its location in the repo. I'd format the README so it's easy to add more demo projects in the future. The README in our samples repo may be a helpful example: https://github.com/Azure-Samples/azure-cache-redis-samples/blob/main/README.md

Edited README.md in the root of the repo.


color property on a line or curve should be an alias for stroke

Doesn't make sense to be an alias for fill in this context


Feature/universal navigation

Should be synced with corresponding CMS changes and have menu_universal object with defined links at the endpoint.
Note AppHeaderDropdown.vue component where most of the new logic resides.

Hi @arnasziedavicius — I think this issue can now be closed?

Hi @chrismplus, you are right, this has been merged and can now be closed ✔


Error while using ABAPGIT

Hi,
We are following this blog : https://developers.sap.com/tutorials/abap-environment-abapgit.html to establish the connection with ABAPGIT and clone a GIT repository. A couple of months back we were able to establish the connection successfully by performing all the necessary configurations like SSL Setup, running the program ZABAPGIT_TEST_SSL to test the connection. We were successfully able to git clone from the repository "https://github.com/sangita-p/abapgitrepo2"
But now when we try to access the same repository by running the ABAPGIT program, we get the error as "Error: HTTP error 411 occured: Direct connect to github.com:443 failed: NIECONN_REFUSED(-10)". Sceenshot below:

Also please find the SSL certification which has been configured in the STRUST.

Also when we run the program ZABAPGIT_TEST_SSL, we get the error given in the screenshots below:

Can you please help us know what would have changed that the same setup is not working any more?
Regards,
Sangita

NIECONN_REFUSED is typically a connection refused error, suggest trying to login to the application server and verify that it is possible to connect to github.com
Is the server behind a firewall? Is it behind a proxy?

Looks like the github certificates are missing (they recently expired in May)?
See docs here: https://docs.abapgit.org/guide-ssl-setup.html
Also: https://docs.abapgit.org/guide-ssl-setup.html#note-on-actions-that-require-authentication
Certificate List should include these two:

Could be also due to missing profile settings (see the same doc - https://docs.abapgit.org/guide-ssl-setup.html#note-about-github)
ssl/client_ciphersuites = 150:PFS:HIGH::EC_P256:EC_HIGH
ssl/ciphersuites = 135:PFS:HIGH::EC_P256:EC_HIGH
icm/HTTPS/client_sni_enabled = TRUE

@sangita-p  did above help?

Still trying to resolve the issue. Will keep you informed on the findings

I have imported the new certificates from github.com into STRUST.

But when I run the ABAP Program ZABAPGIT_TEST_SSL, I am still getting the same error:

When I goto smicm > Goto > Trace File > Display End, I see the below error:

The system where we have imported the certificates in an on-premise system.
Regards,
Sangita

Your first screenshot still only shows the root and intermediate certificate and not the server certificate of GitHub?
In some configurations you need the full certificate chain and in others you only need the root certificate (no idea when which scenario is relevant).

I just noticed the docs seem to have been updated and say that you only need the root certificate now instead of all three of the chain? I don't think that works on all releases.

It still show DigiCert for me o0

Yes (Digicert and with 2 levels of certification). This is what I downloaded and uploaded yesterday into the on-premise system. And I uploaded both the certificates. This is the correct one right?

A couple of months back, the same Digicert certificates with 2 levels were imported into the same and the connection with abapGIT was working perfectly fine. I re-imported these certificates which was downloaded again yesterday, into our system as someone in the above chain mentioned that the certificates expired in May.

note the peer ip address which is Vodaphone india

NIECONN_REFUSED is typically a connection refused error, suggest trying to login to the application server and verify that it is possible to connect to github.com
Is the server behind a firewall? Is it behind a proxy?

you need all 3 levels. you are missing the github.com cert.

If you want to update private repos, you will also need the *.github.com which you can get from https://api.github.com/.

note the peer ip address which is Vodaphone india

NIECONN_REFUSED is typically a connection refused error, suggest trying to login to the application server and verify that it is possible to connect to github.com
Is the server behind a firewall? Is it behind a proxy?

We imported all the 3 certificates now, but still getting the same error when we goto smicm> Goto > Trace File > Display End

Yes the ABAP sever(N1D) that we are using is behind a firewall. Can you please elaborate what do you mean by "uggest trying to login to the application server and verify that it is possible to connect to github.com"? How do we check this?

if its linux, ssh into it and verify with curl or wget, if its windows then open via rdp and check the browser can access https://github.com

Thanks for the help. It was a networking issue. We are successfully able to connect to abapGIT with github

👍 closing

Hello all,
I am getting the same issue as above, I tried everything as explained above still not able to connect to Online Repository.
Only breakthrough  i got is in prog ZABAPGIT_TEST_SSL, I entered the P_PROXY and Port and it succeeded.

But when I tried to execute and connect to https://github.com/abapGit/abapGit/ . It has given me the same error as aobe one.

Can anybody suggest where I am lagging? Where do i need to update the Proxy parameter?
Is it in here?

@jayesh-mudaliar please open new issues for new/additional issues
anyhow, setup the proxy settings under https://docs.abapgit.org/guide-settings-global.html

@jayesh-mudaliar please open new issues for new/additional issues
anyhow, setup the proxy settings, see https://docs.abapgit.org/guide-settings-global.html

Thanks@larshp You are genius!! It worked!! I can blame myself for not reading the whole document and jumping into the action!!


Week 2 / Day 2  code review

Revisit the grid concept and try to understand why certain grid attributes are used or preferred in certain situations

clean up the css as well

Thanks for the remarks. I'll look into that...


Cheatcodes tracking issue

The people want cheatcodes for testing!
Testing can be a bit of a pain in the neck if insufficient access to data or manipulation is available. Therefore we want to support some of the cheatcodes that Hardhat and Foundry supplies on the L2 as well. Some of the differs a bit from what is seen at https://book.getfoundry.sh/cheatcodes/ as it needs a extra functions for the distinction between private and public data.
I suggest that we create a CheatCode class that implements those functions to make it easily accessible to devs without having to stroll through 10 different classes. Similar to how you can use vm in foundry tests.
Consider:

adding a cheatcode to skip the constraints in the rollup on global variables.
having an l1 and an l2 sub class as many of these can be useful for either, for the l1 cheatcodes we should call the anvil cheatcodes directly.

### Cheatcodes: Non-intrusive
- [ ] https://github.com/AztecProtocol/aztec-packages/issues/1275
- [ ] https://github.com/AztecProtocol/aztec-packages/issues/1276
- [ ] https://github.com/AztecProtocol/aztec-packages/issues/1281
- [ ] https://github.com/AztecProtocol/aztec-packages/issues/1285
- [ ] https://github.com/AztecProtocol/aztec-packages/issues/1288

### Cheatcodes: Intrusive
- [ ] https://github.com/AztecProtocol/aztec-packages/issues/1279
- [ ] https://github.com/AztecProtocol/aztec-packages/issues/1280
- [ ] https://github.com/AztecProtocol/aztec-packages/issues/1282
- [ ] https://github.com/AztecProtocol/aztec-packages/issues/1286
- [ ] https://github.com/AztecProtocol/aztec-packages/issues/1277
- [ ] https://github.com/AztecProtocol/aztec-packages/issues/1278
- [ ] https://github.com/AztecProtocol/aztec-packages/issues/1283
- [ ] https://github.com/AztecProtocol/aztec-packages/issues/1284

### Misc
- [ ] https://github.com/AztecProtocol/aztec-packages/issues/1458

I get that this follows foundry's naming choices, but the words aren't very descriptive. etch, warp, roll, prank.
Thoughts on using more descriptive function names?

I get that this follows foundry's naming choices, but the words aren't very descriptive. etch, warp, roll, prank. Thoughts on using more descriptive function names?

I prefer to use foundry as we will probably need to support both l1 and l2 cheatcodes, and I don't want to have people relearn terms just for us.

I'm closing this issue since we primarily are missing the intrusive cheatcodes which seems much more fit for a testing framework that the mix that is the sandbox.


teacher-tool: initial support for universal app theming

This PR introduces a unified CSS theming mechanism, shared between the main editor, react-common, and CRAs.
The immediate goal for this change is to enable teacher tool to receive its theming from the target it was launched from, but its benefits stretch beyond this. This system gives us a clear and simple way to implement new themes or fine-tune existing ones, and it provides a generalized solution to the problem of duplicated styling in CRAs, an area where we've been accumulating technical debt.
The approach involves:

Defining a well-known set of CSS style variables in the core web app.
Overriding these variables in targets.
Using these variables for theming in the editor, react-common, and CRAs.
Providing a utility function to set the current theme of the application.

This is just the initial commit to put the system in place for teacher tool to leverage. TODO:

[ ] Define the actual set of CSS theme variables we want to support as our theme schema. What is there currently is placeholder.
[ ] For the controller scenario: create an iframe message to set the editor theme.
[ ] Propagate the use of the new variables across existing style definitions in core editor, targets, and react-common.
[ ] Extract high contrast theme colors to .theme-highcontrast.
[ ] Later: propagate the variables to multiplayer and skillmap when necessity arises.

Also switched to using sass/scss for teacher tool styling. We get it for free from create-react-app.

Also switched to using sass/scss for teacher tool styling. We get it for free from create-react-app.

Are we using this anywhere else in pxt? And will it only affect teacher tool or will this become necessary for any app hooking into this theming system?


Error:Module 'com.github.lsjwzh.RecyclerViewPager:tablayoutsupport:v1.1.2' depends on one or more Android Libraries but is a jar

To reproduce this problem:

Create a new Android Studio 2.2.3 project, accepting all defaults, except use the "Empty Activity" template.

Add both RecyclerViewPager dependencies to app/build.gradle:

repositories {
  maven { url "https://jitpack.io" }
}

dependencies {
  compile fileTree(dir: 'libs', include: ['*.jar'])
  androidTestCompile('com.android.support.test.espresso:espresso-core:2.2.2', {
    exclude group: 'com.android.support', module: 'support-annotations'
  })
  compile 'com.android.support:appcompat-v7:25.1.0'
  compile 'com.github.lsjwzh.RecyclerViewPager:lib:v1.1.2'
  compile 'com.github.lsjwzh.RecyclerViewPager:tablayoutsupport:v1.1.2'
  testCompile 'junit:junit:4.12'
}

You then get the error when syncing the project with the Gradle build files, or via gradle clean assembleDebug.

Is someone already fixed this issue?

According to this issue : https://github.com/hotchemi/PermissionsDispatcher/issues/35
Use
compile 'com.github.lsjwzh.RecyclerViewPager:tablayoutsupport:v1.1.2@aar'
instead of :
compile 'com.github.lsjwzh.RecyclerViewPager:tablayoutsupport:v1.1.2'
It seems to work for me.
Hope it helps !

@sokarcreative Yeah! It works) Thx


V2: TextField numeric input not working on non-Windows platforms

Hello
For V2, when I'm trying to enter numeric input values for a TextField on non-Windows platforms, the values are not accepted by the control.  Is there some specific setting in V2 that I'm missing?  Looking at the changes to the TextField between V1 and V2, the V2 OnProcessKeyDown contains an additional check around key codes A-Z which is not in the V1 ProcessKey method - not sure if this is the cause of the issue and why it works on Windows
        // Ignore other control characters.
        if (!a.IsKeyCodeAtoZ && (a.KeyCode < KeyCode.Space || a.KeyCode > KeyCode.CharMask))
        {
            return false;
        }

This sounds like a bug.  But having more information to diagnose would help.
Can you check whether NumLock or Scroll Lock is down when trying to type.  Sometimes that makes a difference (although it really shouldn't).
One thing that would help is to know exactly what the keycode is that is being ignored.
You can trap all key events at application level with a global listener (see below) and then look at e in the debugger.  If you could provide a screenshot of what that is showing on the affected OS that would be great.
        Application.KeyDown += (s, e) =>
        {
            // Break point here
        };

@tznind Thanks for the reply.
Following your suggestion, I added a status bar item that logs the key code.  On Windows 11 when I execute this, I see D1, D2... for the digits.  On Linux (Ubuntu 22.04 running in WSL on Windows 11), the same key codes are logged as 17, 18, 19...
I wasn't sure if running in WSL might be causing the issue, so I compiled this on my Mac as well.  When executing on the Mac I see the same behaviour, i.e. the digits are logged as 17,18,19.  On the Mac I have some additional issues with some other key codes as well.  For example, Backspace is logged as 95 on Mac, but interpreted correctly on Linux and Windows.
Thoughts?

I've also now verified this with the Keys example on the Mac.  Running the Keys example for the develop branch works fine, but running the Keys example from the v2_develop branch does not work for digits and some other keys.

@cjlotz can you please test the PR #3542, on Linux and macOS to see if it working better. On macOS, for the Alt key to work at all, you need to change the following configuration in Terminal. Thanks.
Terminal > Preferences > Profiles > Keyboard and just check Use Option as Meta key

@BDisp I can confirm that the fixes work on my Mac and also in Ubuntu 22.04 running in WSL on Windows 11.

This was already fixed on #3542.