Shadow glitches

@LevYas wrote in #3:
There are some glitches with shadows though

But this could be because of OpenGL ver 3.3. Even the freshest Nvidia drivers did not bring me 4.
Originally posted by @LevYas in https://github.com/AximoGames/AxEngine/issues/3#issuecomment-655954786

This is a known issue and is regardless of the OpenGL version. There's a bug in the shadow calculation. Some brainstorming:
There could be a problem in the source of

https://github.com/AximoGames/AxEngine/blob/master/Assets/Shaders/common/lib.frag.glsl#L29
https://github.com/AximoGames/AxEngine/blob/master/Assets/Shaders/common/lib.frag.glsl#L98
Maybe wrong Near/Far-Plane calculation?

I've spent lots of time in shadow debugging in the past. Any help would be great.
Nut sure, but as I remind this occurs only in DirectionLightning (shadow Map). Try PointLight (shadow Cube) here:
https://github.com/AximoGames/AxEngine/blob/master/Demo/DemoApplication.cs#L189

Just a notice: in Marbles ( https://github.com/AximoGames/AxMarbles ) only PointLight is used and there are no shadow glitches. So, it seems it happens only with DirectionalLight. Any help in fixing the shadow gub would be great.

I'm afraid I will not be able to help. I've just started to learn OpenGL and OpenTK as a hobby and came across your engine as a real-word usage example :)
BTW, I'm very disappointed there is no TDD practice for shaders. I think they're ideal for unit testing - a specific set of arguments (coordinates, uniforms, ...), a specific set of output (color for pixel, ...), but I failed to find any testing framework for this, only 1.5 proof of concepts several years old and that's all.
I have no idea how people making shaders like this without a decent debugger and tests https://www.shadertoy.com/view/Ms2SD1

I do not have isolated shader tests, but there are some render tests: https://github.com/AximoGames/AxEngine/tree/master/Tests/RenderTests
The work in the following way:

Generate a Image of a scene. The images are stored in the repository ( https://github.com/AximoGames/AxEngine/tree/master/Tests/Assets/TestOutputs/LightTests )
On every "unit" test (it's more a integration test) all scenes are rendered and compared with the stored image. If there's a notable difference, the test is failing.

So I tested a bit and found the following:

The Reason, that the OpenGL Version is 3.3,  is because OpenTK default initializes the Context with Version 3.3
You can change the Version by Adding  APIVersion = new Version(4, 1) in the NativeWindowSettings in the RenderWindow.cs
The Bug presists in Version 4.1 with Intel

and Nvidia.

Both were tested with the Context set to Version 4.1

I disabled the moving Light and looked with Renderdoc to check how the shadowmaps are and noticed, that the directional light Shadowmap ist just white.

And the Problem seems to be in DeferredRendering Part of the Engine, since the only shadows I see in Renderdoc are in the DeferredRenderPipeline

If the Renderdoc Capture is interessting, I can upload it to dropbox or something similar, since Github doesn't allow for files bigger than 10MB.

Interesting. But if the shadow map (used for direction light shadows) is "empty", there should not be any shadow? Did you checked the shadow map "Index" (=Slice)?

Yes, with index 1 there is a shadow map.
Is it normal, that there is an white image as output in the first render pass?

And the Issue with the shadow is caused by the shadow map

So the problem now is, why the shadow map has this problem.

Greate work! Just some ideas:

Near-Plane is crossing the sphere?
Shadows are renderend with normal cull mode = back, like normal rendering.

I know for shadows, cull mode = front shuld be used. But with that cull mode, the shadows seems to be less accurate. You can test it here: https://github.com/AximoGames/AxEngine/blob/master/Render/Objects/SimpleVertexObject.cs#L266

It was the near plane intersecting with the sphere, that caused the issue.

But the shadow of rotating directional still disappears and reappears.
I thing there might be a problem, that the shadow map doesnt catch the complete map.

amazing! thx very much for tracking down the problem. Regarding the missing shadows that are far away: I have no idea how to solve this in a perfect manner. One idea is to move the directional shadow light with the player. But even in this case, the map needs to be bigger: More memory, more computing time or shadow have more artifacts. So, what do you think is a good/acceptable way to render shadows that are far away?

Sadly no :/

Did you found out why the shadows are not correctly rendered if cull mode is changed?

I did not check that, but I can look later

Hm it's really weird. This is the shadows when I enable Cullmode Front:

I used the following code to enable it in SimpleVertexObject.cs :
GraphicsDevice.Default.CullFaceMode = CullFaceMode.Front;
//GL.CullFace(CullFaceMode.Front);
//GL.Disable(EnableCap.CullFace);
mat.Vao.Draw();
//GL.Enable(EnableCap.CullFace);
//GL.CullFace(CullFaceMode.Back);}
GraphicsDevice.Default.CullFaceMode = CullFaceMode.Back;

The weird part, is that the shadowmaps seem to be fine
Slice 0

Slice 1

I have currently no clue, where the problem can be.


fix(rpc): less clones in logs filter

It can be more improved by changing alloy into accepting just the address and the topics as argument to filter functions

ref https://github.com/alloy-rs/alloy/issues/256


The wrong output of the test case in challange 290

Challenge Inventory Update has an issue.
User Agent is: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/58.0.3029.110 Safari/537.36.
Please describe how to reproduce this issue, and include links to screenshots if possible.
My code:

function updateInventory(arr1, arr2) {
    // All inventory must be accounted for or you're fired!
  if(arr1.length!==0&&arr2.length!==0){

    var a1 = [];
    for(var k=0;k<arr1.length;k++){
      a1.push(arr1[k][1]);
    }

    for(l=0;l<arr2.length;l++){
      if(a1.indexOf(arr2[l][1])<0){
        arr1.push(arr2[l]);
      }
    }

    for(var i=0;i<arr1.length;i++){

     for(var j=0;j<arr2.length;j++){
       if(arr1[i][1]==arr2[j][1]&&arr1[i][0]!=arr2[j][0]){
        arr1.splice(i,1,arr2[j]);
       }

     }

   }
  }else if(arr1.length===0){
    arr1=arr2;
  }

  arr1.sort(function(x,y){
    return x[1].localeCompare(y[1]);
  });
  return arr1;
}

// Example inventory lists
var curInv = [
    [21, "Bowling Ball"],
    [2, "Dirty Sock"],
    [1, "Hair Pin"],
    [5, "Microphone"]
];

var newInv = [
    [2, "Hair Pin"],
    [3, "Half-Eaten Apple"],
    [67, "Bowling Ball"],
    [7, "Toothpaste"]
];

updateInventory(curInv, newInv);

I use the updateInventory([[21, "Bowling Ball"], [2, "Dirty Sock"], [1, "Hair Pin"], [5, "Microphone"]], [[2, "Hair Pin"], [3, "Half-Eaten Apple"], [67, "Bowling Ball"], [7, "Toothpaste"]]) should return [[88, "Bowling Ball"], [2, "Dirty Sock"], [3, "Hair Pin"], [3, "Half-Eaten Apple"], [5, "Microphone"], [7, "Toothpaste"]].
The true result should be the
(6) [Array(2), Array(2), Array(2), Array(2), Array(2), Array(2)]
0
:
Array(2)
0
:
67
1
:
"Bowling Ball"
length
:
2
proto
:
Array(0)
1
:
Array(2)
0
:
2
1
:
"Dirty Sock"
length
:
2
proto
:
Array(0)
2
:
Array(2)
0
:
2
1
:
"Hair Pin"
length
:
2
proto
:
Array(0)
3
:
Array(2)
0
:
3
1
:
"Half-Eaten Apple"
length
:
2
proto
:
Array(0)
4
:
Array(2)
0
:
5
1
:
"Microphone"
length
:
2
proto
:
Array(0)
5
:
Array(2)
0
:
7
1
:
"Toothpaste"
length
:
2
proto
:
Array(0)
length
:
6
proto
:
Array(0)

challange 290

What is 290?
Hi @chcifung
Thanks for reporting this issue.
Here are some next steps that you should follow before we can help you with your query:

Check these troubleshooting steps first.
Please use the Chat Rooms or try looking through our forum for help with a specific challenge and any coding assistance.

IMPORTANT:
Please NOTE that this tracker is for reporting bugs and enhancements to freeCodeCamp's code base only.
Happy Coding!

@chcifung by the way, there has no number of the challenge. more like it is your brownie point. you could look at this link. you will understand. https://forum.freecodecamp.com/t/free-code-camp-brownie-points/18380
Happy coding!


after reloadMenu the first menu item is always selected

I have a paging view controller that contains two child view controllers, each view controller will update its menu item text so i have the new text stored in an array of strings of length 2, when i update the strings, i call reloadMenu to refresh menu items labels, the issue that it always selects the first menu item without even switching to the first view controller, just the bottom selection line of the menu items gets moved to the first one and that's it, I tried calling select on the last index but it didn't work

I figured something that might help us.
I want to edit the title of the PagingIndexItem but its a constant, I just need a version of this pod where the title property is a var, Thank you

To furthur explain, I am trying to change menu items label text in runtime by specifying new strings and then calling reloadMenu which then selects the first menu item losing sync ex: i am standing in the second view controller and after calling reloadMenu, selected menu item is the first

Hi @minaMagedNaeem! When calling reloadMenu it keeps the current selection as long as the selected PagingItem does not become a new item. For instance, if you are using PagingIndexItem it uses the title property to determine the uniqueness of the item. This means that if you change the title of that item, it counts as a new completely new item and the selection is reset to the first item. If you want to keep the same selection while change the title property you need to implement your own PagingItem where the title is not part of the Hashable

@rechsteiner could you please give more info on washable. e.g. in IconItem (from example), I'm using hasher like:
   func hash(into hasher: inout Hasher) {         hasher.combine(index)     }
but it still reloads the entire menu (on reloadMenu()). I'm trying to add a badge to each item that (atm using tier to update badge info and reloadMenu()), but as above - sets menu 1st item as selected but doesn't change the active VC.
Also weird thing: I'm having 3 menu items, only 2nd's badge gets updated; if 1st is selected - all is fine; if last (3rd) is selected - its also all ok; problem persists only if the 2nd item (with badge updating) is selected. Thx!

any progress here? I met this problem too!

struct CSRecordItem:PagingItem{
public let index: Int

public var title: String

public init(index: Int, title: String) {
    self.index = index
    self.title = title
}

func isEqual(to item: PagingItem) -> Bool {
    guard let recordItem = item as? CSRecordItem else {
        return false
    }
    return self.index == recordItem.index
}

func isBefore(item: PagingItem) -> Bool {
    guard let recordItem = item as? CSRecordItem else {
        return false
    }
    return self.index < recordItem.index
}

var identifier: Int {
    return index
}

}
just implement  PagingItem protocol with index ,ignore title

struct CSRecordItem:PagingItem{
public let index: Int

public var title: String

public init(index: Int, title: String) {
    self.index = index
    self.title = title
}

func isEqual(to item: PagingItem) -> Bool {
    guard let recordItem = item as? CSRecordItem else {
        return false
    }
    return self.index == recordItem.index
}

func isBefore(item: PagingItem) -> Bool {
    guard let recordItem = item as? CSRecordItem else {
        return false
    }
    return self.index < recordItem.index
}

var identifier: Int {
    return index
}

}
just implement PagingItem protocol with index ,ignore title

Hi, I am trying to use your reply to solve this problem, but app keep crashing due to  "'could not dequeue a view of kind: UICollectionElementKindCell with identifier CSRecordItem - must register a nib or a class for the identifier or connect a prototype cell in a storyboard'"
Any idea how can i fix it. Thx!

@davidhsu1115 you need to register the custom class for the given item type. See the docs here: https://github.com/rechsteiner/Parchment#custom-cells


solved #782  added solutions to challenges

📥 Pull Request
Description
changes:
1.changed questions of challenge 2 as both challeneg 1,2 displaying same questions
2.added solutions to challenge 1
3.add solutions to challenge 2
added solutions to challenges
Fixes #758
https://github.com/user-attachments/assets/bd1cda03-9c30-4a06-8080-3774257c92ba

Type of change

[x] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[x] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[x] Documentation update

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] Any dependent changes have been merged and published in downstream modules

sir please change level to level 3 and merge it sir
https://github.com/user-attachments/assets/234e0ac3-2aea-4502-9588-2bd57782fd9c

@ajay-dhangar sir please merge this pr

Ok
On Tue, Oct 22, 2024, 8:55 AM Ajay Dhangar @.***> wrote:

@.**** requested changes on this pull request.
Can you create a directory for this in the docs? We need to write in the
src using good format and follow best practices. Therefore, we can't put
your code in the src.
—
Reply to this email directly, view it on GitHub
https://github.com/ajay-dhangar/algo/pull/1073#pullrequestreview-2383675473,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BHOWNHDVAZ4UVCP6R3SOWJTZ4XARNAVCNFSM6AAAAABQIRZWOOVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDGOBTGY3TKNBXGM
.
You are receiving this because you were assigned.Message ID:
@.***>


Unsupported field "type" of property TEL

As reported by @hansbkk

In the Google interface, there is a pre-defined pair of strings "Home fax" and "Work fax", which get exported as follows in the vCard:

TEL;TYPE=WORK;TYPE=FAX:212 555 2345
TEL;TYPE=HOME;TYPE=FAX:212 555 3456

These both show up in Cozy as "FAX" alone, so it is impossible to tell which is the home fax number and which is the work number.

My work-around solution for now is to enter these as a custom string rather than using Google's predefined labels, which will export as:

item1.TEL:212 555 2345
item1.X-ABLabel:Work Fax

and this works fine, but obviously it isn't ideal to require the user to have to remember which google labels work with Cozy and which don't.

I've found other clients rather than use:
TEL;TYPE=WORK;TYPE=FAX:212 555 2345
TEL;TYPE=HOME;TYPE=FAX:212 555 3456
they do "compound types" like this:
TEL;TYPE=WORK,FAX:212 555 2345
TEL;TYPE=HOME,FAX:212 555 3456
and then display as "Work fax" and "Home fax"
Not sure which is more "correct". If we transform into the latter, test to see if Google's import interprets it correctly?

It should work fine now.


GUI installation error with ZSH

Hi, I had a small issue installing the gui with a zsh shell. I needed to escape the brackets, i.e. pip install tesliper\[gui\] instead of pip install tesliper[gui].

I'm not familiar with zsh, but this stackexchange answer explains that this is due to how zsh resolves some[thing] syntax, so the issue is not related to tesliper. Anyway, I will add a note about this for zsh users in the "Installation" section of docs.


Build source containers with remote_sources

CLOUDBLD-4454

Signed-off-by: Robert Cerven<EMAIL_ADDRESS>Maintainers will complete the following section

[x] Commit messages are descriptive enough
[x] Code coverage from testing does not decrease and new code is covered
n/a JSON/YAML configuration changes are updated in the relevant schema
n/a Changes to metadata also update the documentation for the metadata
n/a Pull request has a link to an osbs-docs PR for user documentation updates
n/a New feature can be disabled from a configuration file

rn updated: Build source containers with remote_sources


createChatParticipant API choices: The Handler function

Testing #205609
It feels very odd to me that we pass in a Handler function into the createChatParticipant rather than:

using a Provider model something like:

{
    provideChatParticipant() { ...}
}

following what we do for UriHandlers where you pass in:

{
   handleUri() {...}
}

I feel like chat participants are often going to be represented as classes since there will likely be some state/instance variables that will need to be kept tied to that instance and doing it this way promotes that idea. Aside from commands, which are really quite a lower level basic unit, I don't see any (or at least many) usages of passing in a raw handler.

This is inspired by the NotebookController model. It is a bit weird. But we want it to be a push model, and also to be based on an object which is owned by VS Code, since it is dynamic and can be changed arbitrarily, so vscode wants to monitor it, and also it provides some information from vscode back to the extension, like the onDidReceiveFeedback callback. Not saying there's no other way to accomplish this, but the NotebookController shape seems like a good match, and then it's consistent with that pattern.


Memory Leak in parse_address

I just wanted to leave a note that we confirmed a fairly large memory leak associated with parse_address in our Heroku/Django application.  Using heapy in a heroku bash shell, we deduced that the cities.csv file was continually being loaded and saved in memory.  We didn't have the resources to find a workaround, so we moved to another package, but I wanted to file this ticket in case it flags the issue for anyone in the future who can save some time.

What package, if you don't mind sharing? 😉

malloc traceback also confirmed the leak was on the cities.csv being loaded into memory in a loop
I wasn't parsing the city so I didn't bother debugging the code so i just commented out lines 57 to 60 which called the function to load the csv


WIP Layout remake

Though it turned out not to be the mess I expected, I decided to make a separate PR for this. This here would also be a good opportunity to design the layout so that it looks good. Now the layout uses pixels instead of inches so in theory it should work on all screen sizes and platforms.
Should there be a 'help' button somewhere that would open a pop up window to view all the key combinations etc. (discussed in https://github.com/mne-tools/mne-python/pull/2206)? Are there other buttons we might need?

start with help button. and please share screenshots.

The point of the remake was to make it so that it looks the same on all platforms. The actual look of the layout shouldn't have changed much (apart from the title being larger). So the idea to make this a separate PR was to test this on all platforms and see if it turns out ok. I can test this on virtual box on my laptop (which has really weird screen settings) once I get home.

ok cool
no time to test though

by the way, one small issue I noticed with the raw plotter. If I select the bad channel, then the channel name doesn't get grayed out so it's a bit hard to say which channel got selected. @jaeilepp can you squeeze this into one of your PRs or make a new PR to address this. Should be an easy fix ...

One problem is that having a non-standard DPI will break the rendering:

You can set the figure.dpi param in matplotlibrc if you want to try it yourself, or do the equivalent in Python space with rcParams or whatever it is called. Not sure if there is an easy fix. Not the end of the world if there isn't.
For me the "+", "-", and "b" keys don't work, even though pageup/pagedown/home/end do. This makes sense given that they aren't listed in _plot_onkey in mne/viz/epochs.py, are you still working on adding those?

Also, 'escape' should close the epochs browsing window like it does for raw, and it should be added to the help.

you'll need to rebase too.

I guess it's best to finish the butterfly and continue with this when it's merged.

sounds good

Update:
Added a dialog for adjusting the number of epochs/channels per view as suggested in https://github.com/mne-tools/mne-python/issues/2213.

this was missed in the last pr: could you a command line message to remind/notify the user of the drop channel similar to the drop epochs message. would be very useful.

Well the channels aren't actually dropped. They're just added to the bads list like in raw.plot.

@mainakjas, @yousrabk, and I were discussing having an interactive way of selecting channels. In my system acquisition software we have plot of the channel montage and you can select a set of sensors this way. we could also include some buttons for pre-defined ROIs, like the ones given in mne_browse_raw (temporal, occipital quadrants, etc.)
here's a screen capture of the window:

sorry, yeah, a message to notify which channels are marked in info['bads']

There is already an 'order' param in plot_raw that allows the user to define the order of the shown channels.  Don't know if it's used much.

In the help, can you align all the colons ? And color the keyboard shortcut red / yellow or make it bold. See whatever looks good. Just some aesthetics to make it look professional :)

More help dialog related comments:

put + and = on the same line separated by the word 'or`
can you use the unicode to show the arrow keys: https://en.wikipedia.org/wiki/Arrow_(symbol) ?
close mne_browse_epochs -> Quit
f11 -> F11 (make the f capital)

Some comments about the viewport dialog box

the title of the dialog box is not inclusive of the check boxes
the checkboxes update immediately in the plot but the viewport dimensions don't update until you press the update button. Can you make it consistent? Actually, it would be better to have no update button if possible.
T0 visible => zeroline
Y labels visible => channel names

Should we also have a checkbox for event-id and epoch-id for consistency?

In the help dialog, can you right justify the bold stuff (like here for example: https://inkscape.org/en/doc/keys046.html). Also can we change the sentences at the bottom to look like the table of keyboard shortcuts? Something like:
click epoch -> mark bad epoch
click channel -> mark bad channel
right click -> vertical line at a time instant
middle click -> show channel name (butterfly plot)
Maybe put a small heading which says mouse controls or something like that?

Screen shot ?

the checkboxes update immediately in the plot but the viewport dimensions don't update until you press the update button. Can you make it consistent? Actually, it would be better to have no update button if possible.

This is a usability thing. If you change the viewport dimensions, it takes a while to update, which is not the case with the labels and vertical lines. Imagine trying to adjust the viewport to show every epoch and channel and not hitting the end of the slider immediately.

The layout remake evolved a bit from the original idea. I think now the layout should be somewhat same for all platforms. At least it seems to work well for all platforms I've tried. Ready for review.

I have crashes on mac os x when toggling the buttons in settings.

Any error messages?

  File "/Users/alex/anaconda/lib/python2.7/site-packages/matplotlib/backend_bases.py", line 1887, in button_press_event
    self.callbacks.process(s, mouseevent)
  File "/Users/alex/anaconda/lib/python2.7/site-packages/matplotlib/cbook.py", line 540, in process
    proxy(*args, **kwargs)
  File "/Users/alex/anaconda/lib/python2.7/site-packages/matplotlib/cbook.py", line 415, in __call__
    return mtd(*args, **kwargs)
  File "/Users/alex/anaconda/lib/python2.7/site-packages/matplotlib/widgets.py", line 558, in _clicked
    if (t.get_window_extent().contains(event.x, event.y) or
  File "/Users/alex/anaconda/lib/python2.7/site-packages/matplotlib/text.py", line 798, in get_window_extent
    bbox, info, descent = self._get_layout(self._renderer)
  File "/Users/alex/anaconda/lib/python2.7/site-packages/matplotlib/text.py", line 311, in _get_layout
    ismath=False)
  File "/Users/alex/anaconda/lib/python2.7/site-packages/matplotlib/backends/backend_macosx.py", line 166, in get_text_width_height_descent
    six.text_type(s), family, size, weight, style)
RuntimeError: CGContextRef is NULL

If you suspect this is an IPython bug, please report it at:
    https://github.com/ipython/ipython/issues
or send an email to the mailing list at<EMAIL_ADDRESS>
You can print a more detailed traceback right now with "%tb", or use "%debug"
to interactively debug it.

Extra-detailed tracebacks for bug-reporting purposes can be enabled via:
    %config Application.verbose_crash=True

@jaeilepp look here:
https://github.com/mne-tools/mne-python/blob/master/mne/viz/raw.py#L322
I had to do something stupid to the raw code to prevent those errors, namely making sure the proj fig is always the last one drawn. Maybe it would fix this, too.

I added the lines of code @Eric89GXL suggested in a couple of places. If that doesn't fix it, there might be a problem because now we have two dialogs with check boxes. If they're the ones causing the trouble we might have to find another way of toggling the labels and such. Unless someone has a better idea...

esc -> Esc

actually, the key names should probably follow the IBM naming convention: https://en.wikipedia.org/wiki/IBM_PC_keyboard

any reasoning that help isn't h instead of ?

gmail convention. I am fine if h works too but ? is fine with me.

oh yeah, @mainakjas just showed me that. i had no clue you had so many shortcuts in gmail. the only ones I know are from accidentally pressing a mapped key

I still see crashes :( but it does not block the GUI
I would be fine with merging as it is and fixing during the sprint. If so just open an issue when merged.
ready to merge ?

I would be fine with merging as it is and fixing during the sprint. If so just open an issue when merged.

Yeah, I'm okay with that.
Ready for my part.

So shall we merge this or should we wait for the sprint? I'm asking because the diff to other PRs is becoming quite big.

@jaeilepp can you rebase? I can try it then.

Done.

clean up and I'll merge.

Oops. Done.

Tell me travis is happy. I'll merge.

Oops again. There was an empty line at the end it just doesn't show it here and I didn't notice it either.

Okay, travis is happy.

Thanks !


import.meta.glob as: 'raw' fails for template strings

Describe the bug
import.meta.glob(`./*`, { as: `raw` })

raises

[plugin:vite:import-glob] Invalid glob import syntax: Could only use literals

When removing the { as: `raw` } part, the error disappears.
When replacing backticks with single quotes, the error also disappears: import.meta.glob('./*', { as: 'raw' }).
Related: #9349
Reproduction
https://stackblitz.com/edit/vitejs-vite-2rd1zk?file=counter.js&terminal=dev
Steps to reproduce
No response
System Info
StackBlitz

Used Package Manager
npm
Logs
No response
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Make sure this is a Vite issue and not a framework-specific issue. For example, if it's a Vue SFC related bug, it should likely be reported to vuejs/core instead.
[X] Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
[X] The provided reproduction is a minimal reproducible example of the bug.

This now works. I guess https://github.com/vitejs/vite/pull/10999 fixed this.


docs: Fix a few typos

There are small typos in:

README.md

Fixes:

Should read output rather than ouput.
Should read double rather than doble.

Semi-automated pull request generated by
https://github.com/timgates42/meticulous/blob/master/docs/NOTE.md

Thanks! @timgates42


Object inspector rich text mode fails for non-ascii docstrings

From pierre.raybaut on 2011-10-16T15:22:46Z
Here is a traceback if we call "raise" here: https://code.google.com/p/spyderlib/source/browse/spyderlib/plugins/inspector.py#674 Traceback (most recent call last):
File "D:\Python\spyder\spyderlib\widgets\editor.py", line 1719, in send_to_inspector
force_refresh=force)
File "D:\Python\spyder\spyderlib\plugins\inspector.py", line 554, in set_rope_doc
self.set_sphinx_text(doctxt)
File "D:\Python\spyder\spyderlib\plugins\inspector.py", line 672, in set_sphinx_text
html_text = sphinxify(unicode(text))
File "D:\Python\spyder\spyderlib\utils\sphinxify.py", line 105, in sphinxify
filed.write(docstring)
UnicodeEncodeError: 'ascii' codec can't encode character u'\xe9' in position 15: ordinal not in range(128)
Original issue: http://code.google.com/p/spyderlib/issues/detail?id=801

From ccordoba12 on 2011-10-16T20:27:32Z
I'm working on this one.
Status: Started
Owner: ccordoba12

From ccordoba12 on 2011-10-16T20:52:55Z
This issue was closed by revision cfc507c44927 .
Status: Fixed

From pierre.raybaut on 2011-10-16T13:22:55Z
Labels: Cat-ObjectInspector


Page Fault after upgrade to x86_64

Hello,
Before all, congratulations for the project. All posts are very simple and explanatory, thanks.
Ok, I got some issues with my project so I download your's using the git clone command, and I got the same result. The make works just fine, but when I ran it on qemu a triple fault happened, that because a page fault rises before the IDT configuration. Down below I left the relevant Qemu output, as well the objdump of the nearby assembly.
Can you check what is happen and explain why, pls 😊
Qemu
check_exception old: 0xffffffff new 0xe
     0: v=0e e=0002 i=0 cpl=0 IP=0008:00000000001038bb pc=00000000001038bb SP=0000:000000000011ccc0 CR2=000000000011cd38
RAX=0000000000119af0 RBX=0000000000000800 RCX=00000000001008b9 RDX=00000000001197e8
RSI=0000000000000000 RDI=0000000000119af0 RBP=0000000000120da0 RSP=000000000011ccc0
R8 =0000000000000010 R9 =0000000000000004 R10=0000000000000004 R11=0000000000120c48
R12=0000000000000000 R13=0000000000000000 R14=0000000000000000 R15=0000000000000000
RIP=00000000001038bb RFL=00000006 [-----P-] CPL=0 II=0 A20=1 SMM=0 HLT=0
ES =0000<PHONE_NUMBER>000000 00000000 00000000
CS =0008<PHONE_NUMBER>000000 00000000 00209800 DPL=0 CS64 [---]
SS =0000<PHONE_NUMBER>000000 00000000 00000000
DS =0000<PHONE_NUMBER>000000 00000000 00000000
FS =0000<PHONE_NUMBER>000000 00000000 00000000
GS =0000<PHONE_NUMBER>000000 00000000 00000000
LDT=0000<PHONE_NUMBER>000000 0000ffff 00008200 DPL=0 LDT
TR =0010<PHONE_NUMBER>119769 00000067 00008900 DPL=0 TSS64-avl
GDT=<PHONE_NUMBER>1197e8 0000003f
IDT=<PHONE_NUMBER>000000 00000000
CR0=80010013 CR2=000000000011cd38 CR3=0000000000003000 CR4=00000620
DR0=0000000000000000 DR1=0000000000000000 DR2=0000000000000000 DR3=0000000000000000
DR6=00000000ffff0ff0 DR7=0000000000000400
CCS=00000000000040e0 CCD=000000000011ccc0 CCO=SUBQ
EFER=0000000000000d00
check_exception old: 0xe new 0xd
     1: v=08 e=0000 i=0 cpl=0 IP=0008:00000000001038bb pc=00000000001038bb SP=0000:000000000011ccc0 env->regs[R_EAX]=0000000000119af0
RAX=0000000000119af0 RBX=0000000000000800 RCX=00000000001008b9 RDX=00000000001197e8
RSI=0000000000000000 RDI=0000000000119af0 RBP=0000000000120da0 RSP=000000000011ccc0
R8 =0000000000000010 R9 =0000000000000004 R10=0000000000000004 R11=0000000000120c48
R12=0000000000000000 R13=0000000000000000 R14=0000000000000000 R15=0000000000000000
RIP=00000000001038bb RFL=00000006 [-----P-] CPL=0 II=0 A20=1 SMM=0 HLT=0
ES =0000<PHONE_NUMBER>000000 00000000 00000000
CS =0008<PHONE_NUMBER>000000 00000000 00209800 DPL=0 CS64 [---]
SS =0000<PHONE_NUMBER>000000 00000000 00000000
DS =0000<PHONE_NUMBER>000000 00000000 00000000
FS =0000<PHONE_NUMBER>000000 00000000 00000000
GS =0000<PHONE_NUMBER>000000 00000000 00000000
LDT=0000<PHONE_NUMBER>000000 0000ffff 00008200 DPL=0 LDT
TR =0010<PHONE_NUMBER>119769 00000067 00008900 DPL=0 TSS64-avl
GDT=<PHONE_NUMBER>1197e8 0000003f
IDT=<PHONE_NUMBER>000000 00000000
CR0=80010013 CR2=000000000011cd38 CR3=0000000000003000 CR4=00000620
DR0=0000000000000000 DR1=0000000000000000 DR2=0000000000000000 DR3=0000000000000000
DR6=00000000ffff0ff0 DR7=0000000000000400
CCS=00000000000040e0 CCD=000000000011ccc0 CCO=SUBQ
EFER=0000000000000d00
check_exception old: 0x8 new 0xd

Objdump
_ZN34_$LT$spin..once..Once$LT$T$GT$$GT$9call_once17hd3007fcb89bced39E:
  1038b0:	55 	pushq	%rbp
  1038b1:	48 89 e5 	movq	%rsp, %rbp
  1038b4:	48 81 ec e0 40 00 00 	subq	$16608, %rsp
  1038bb:	48 89 bd 98 bf ff ff 	movq	%rdi, -16488(%rbp)

Thanks a lot for the report! The QEMU and objdump output is really helpful.
The CR2=000000000011cd38 line tells us that the page fault occured while addressing address 0x11cd38, which is close to the stack pointer value (0x11ccc0). So it seems like we overflow the stack. The corresponding assembly instruction (movq %rdi, -16488(%rbp)) confirms this.
I think this is caused by using the Idt type of the x86_64 because it defines the full 256 entries (256*64=16488). Our old IDT type only defined the first 16 (or 32?) entries, so a smaller stack sufficed.
To resolve this, we need to increase the stack size (defined in boot.asm).

Thanks a lot for the explanation... After report the issue I start digging around, with the Radare2, and I found the stack a little strange... Kkk
After return from my English class, I will make a PR, expanding the stack size.


List possible cipher options in example config

As far as I can tell this isn't listed besides in the source code.
Adding this to assist others.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


SimpleMDE: Problem posting code

There is a problem posting code with SimpleMDE (I don't know if the problem is related to SimpleMDE or Bludit).
When posting the following I get the error 403:
https://www.dropbox.com/s/tg46gm0ziol4nsv/code-example.txt?dl=0
Parts of the content can be posted without any problem, but not the whole.
It works creating the file index.txt in the directory of the content.

Hi Edi,
I create the page via SimpleMDE and creating the index.txt with the code-example.txt but I don't find the bug.
Also, I tried on the demo, and works fine, can you test ?
https://demo.bludit.com/blog/admin

I will have a look at it. Perhaps the problem was caused using an updated installation.


Upgrade hdf5-sys dependency

Codecov Report

Merging #84 (771a4ed) into master (3ee2238) will decrease coverage by 0.63%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #84      +/-   ##
==========================================
- Coverage   86.14%   85.50%   -0.64%
==========================================
  Files           8        8
  Lines        1855     1849       -6
==========================================
- Hits         1598     1581      -17
- Misses        257      268      +11

Impacted Files
Coverage Δ

src/variable.rs
84.25% <100.00%> (-2.00%)
:arrow_down:

src/dimension.rs
90.51% <0.00%> (-7.91%)
:arrow_down:

src/lib.rs
88.88% <0.00%> (-7.12%)
:arrow_down:

src/group.rs
75.00% <0.00%> (-2.42%)
:arrow_down:

src/attribute.rs
92.32% <0.00%> (-2.26%)
:arrow_down:

src/types.rs
84.72% <0.00%> (+2.80%)
:arrow_up:

src/error.rs
51.11% <0.00%> (+3.19%)
:arrow_up:

src/file.rs
83.63% <0.00%> (+6.32%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ee2238...771a4ed. Read the comment docs.


start converting test to use fuerte connection instead of single requsts

Scope & Purpose
This test doesn't use persistent connections yet, resulting in many collections in TIME_WAIT state.

[x] :fire: Performance improvement
[x] :hammer: Refactoring/simplification

https://jenkins.arangodb.biz/view/PR/job/arangodb-matrix-pr/22236/


make welcome page more responsive

This updated script makes the separator line as wide as the terminal, enhancing the responsiveness of the display. The shutil.get_terminal_size().columns line dynamically adjusts the width of the separator to fit the terminal size. Happy coding with Cipherion! as doing these will make the page more responsive and imrpove the user experience.
please assign me this task.

import pyfiglet
import shutil
def welcome():
# Get the terminal width to make the separator dynamic
terminal_width = shutil.get_terminal_size().columns
sep = "-" * terminal_width
welcmsg = pyfiglet.figlet_format("Cipherion")

print(sep)
print(welcmsg)
print(sep)
print("Welcome to Cipherion!")
print("A robust tool for encrypting and securely storing sensitive information.")
print(sep)

Call the welcome function
welcome()
these is the change i have to put in these .

Sir please accept my pr and merge it.

Which changes sir can you tell please

Check the PR, I've mentioned there already.

sir can you please merge my PR

Closing this issue since #4 was closed by contributor and marked as incomplete.


Sign Messages with MicroSD

Would it be possible to add an option to sign messages with a given address via MicroSD from this screen? I'm working on the signing end of this with Passport, since some messages can be a bit too much to scan in a single QR code.

Do you mean saving a file in the Coldcard format? https://coldcard.com/docs/sign-text-file/#text-file-format

I'd like the standard (electrum) format if possible

I'd like the standard (electrum) format if possible

Is this documented anywhere?

Not anywhere great, but it's already exported via QR here in the sparrow ui, and it follows this format:
signmessage <derivation path> ascii: <message>

for example:
signmessage m/84h/0h/0h/0/0 ascii: chancellor on the brink of second bailout

I'll have to double check in the morning if my code strips leading spaces on the message. It wasn't too clear to me if a space would be inserted between the colon and the message as part of the standard.

I think it would be better to use the same format as Coldcard, rather than introduce an effectively new format for this media? The format used for QRs is not really material, and is poorly documented as you say.

Ok, I can adapt to that. Thanks!

Implemented in 17093dbf. As per the Coldcard spec the message is saved as a single line (newlines are removed) but no further checks or amendments are made.


Merge patterns into main Nextflow docs

The Nextflow patterns provide a lot of value to users at every level. I think they would have more visibility if they were part of the main Nextflow docs, since that seems to be the starting point for most people.
What do you think @pditommaso

It makes sense. It is something we need to coordinate with @ewels. For me the update of patterns and process docs to DSL2 syntax is top priority

I definitely agree 👍🏻 I think this should be done as part of the Nextflow website v2 effort though, which is a fairly long term target.
@pditommaso - looks like @bentsherman has already updated all the patterns 2 months ago, just waiting to be merged 👀 👉🏻 https://github.com/nextflow-io/patterns/pull/26

After discussing with Phil and the Nextflow website team, we have a tentative plan for consolidating Nextflow web resources, which is much broader than simply merging the patterns into the reference docs. Therefore I am closing this issue in favor of that plan.


Hass update JSON string has the version and release notes values the wrong way round!

Home Assistant release with the issue:

0.94.4
Last working Home Assistant release (if known):
Same
Operating environment (Hass.io/Docker/Windows/etc.):

HassOS latest version on Pi 3B+
Component/platform:

Updater
Description of problem:
Error message appears in the log with the following:
got unexpected response: {'release-notes': '0.94.4', 'version': 'https://www.home-assistant.io/blog/2019/06/05/release-94/'}
I think one of your devs owes a round of drinks!
Problem-relevant configuration.yaml entries and (fill out even if it seems unimportant):
updater:

Traceback (if applicable):
N/A

Additional information:
N/A

The problem has been fixed. Thanks for reporting.


bigtree 0.12.0 made 'pandas' requirement optional

This leads to error on tree view since we don't pin bigtree but with last version pandas is not installed anymore but we rely on it in tree view code.
We need to change requirement to:
bigtree[pandas]

Done in v0.6.2-pre.2


Refactor router import related logic to make it test independent

Following on from https://github.com/chausme/middle-messenger/issues/117 and https://github.com/chausme/middle-messenger/issues/126 there is a known issue of a router logic with actual pages baked in which makes sense in general, however independent unit tests become impossible since they fetch the entire app

It has been addressed in a most simple way by excluding router import from AuthController which makes independent router tests possible


Captions return None if no data is present for the field

See here: https://iatistandard.org/en/iati-standard/

Should there be a fallback if no data is entered, or not appear at all?

This issue has been fixed. Closing.

In 4a0e1beb, I think.


Add anchors and spacing

A couple little changes in these commits.
One just improves (I think) spacing around code listings.
The other prepends anchor slugs to every heading. I've found other tools doing this, and some output processors don't add anchors later, including jekyll-asciidoc. I hope it's useful!

I think this features should be configurable.
Maybe it's the right time to create a configuration panel:
AFAIK we can create a custom dialog and use Property service to store and serve data.
Wdyt ?

Yeah, I thought of that as well. In some cases I would find it superfluous, though the s&r regex stripping them is simpler than adding them ;-)
We could also consider allowing such alterations inside the modal after the main conversion takes place.  It might be nice to do this for certain types of cleanup that I've had to do post-migration, that maybe were due more to the way my docs were formatted than the script itself. But I think re-running the "server-side" conversion is easy enough, so you could just toggle those options as needed.
I don't know how trivial it is to add these features. This is my first contrib to a Google Apps project. I'm definitely in, though. I need this tool ;-)

I don't know how trivial it is to add these features. This is my first contrib to a Google Apps project. I'm definitely in, though. I need this tool ;-)

This is my first Google Apps project too :smile:

We could also consider allowing such alterations inside the modal after the main conversion takes place. It might be nice to do this for certain types of cleanup that I've had to do post-migration, that maybe were due more to the way my docs were formatted than the script itself. But I think re-running the "server-side" conversion is easy enough, so you could just toggle those options as needed.

Why not but a configuration panel will avoid to re-running the conversion.
I will try to find some time next week to experiment.

+1 for sure. I think you're right about the approach. Count me in for several hours of tinkering and testing.
One other configurable preference I would use is converting headings to # instead of =. Our product docs use that notation, and our engineers are used to Markdown (from GitHub, mainly, of course). There are quite a few such preference possibilities in Asciidoc, so a framework for adding them would be smart.

We can hold this branch off until we slip those conditionals in, no worries. The add-on testing in GDocs is relatively easy to use for production.

@briandominick Do we really need to explicitly define anchors ? You could add :sectanchors: attribute and let Asciidoctor do the job for you no ? http://asciidoctor.org/docs/user-manual/#anchors

One other configurable preference I would use is converting headings to # instead of =

I think @mojavelinux will disagree on this one :wink:
Asciidoctor supports (some) Markdown syntax but we do encourage users to use the Asciidoctor syntax. What do you think Dan ?
If we decide to not include this feature, then creating a configuration panel, to choose to add an extra space or not, is not worth it I guess.
However I've started experimenting on a configuration panel and it's quite easy so feel free to add more features :smile:

@Mogztter So this is funny: it was only this weekend that I realized # is not actually officially supported for title/heading marks! The first AsciiDoc project I ever took over used them, for whatever reason, and I never noticed they're undocumented. I've changed my mind on this for the current project, actually. If we're going to be using markdown at all, I actually like this being one of the distinctive characteristics so you know what language you're supposed to be using. So yeah, I'm dropping the # setting request.
I do think explicit anchors can be useful. I got the idea of forcing them from another converter; I don't recall which. I think what I like about them is they can stay the same even if the heading they mark gets changed, so you don't get broken links and xrefs. I'm not really sure if that's best practice for team usage. I've had the luxury(?) of being the only one directly using my AsciiDoc files until now. I don't think it's the end of the world at all to not offer this, but it seems simple. This script is incomplete, though -- it needs more replacements, such as / and other symbols.
Good to know config is easy. I'll draft off your achievement when you commit the first one ;-)

@Mogztter anticipated correctly, I also prefer generating the document using = headings. Asciidoctor supports some Markdown syntax to ease migration and to provide a stop-gap solution when the document has to be parsed by a Markdown processor (like on npm), but we should always be gravitating towards the official AsciiDoc syntax.
As for the section anchors, I think we're getting section IDs and anchors confused. The [[anchor-name]] line sets the ID for a section. If this line is not present, and the sectids attribute is set (as it is by default), then an ID is auto-generated. These IDs are not visible to the user, but allow deep linking to that section of the page.
If you want to see a physical anchor or link, then you must set either the sectanchors or sectlinks attribute.
For mature documents, it's a good idea to set the ID explicitly for reasons @briandominick explained. So I do think it is a good option to have. The auto-generated ID is to save typing in the early drafts and for simpler documents.
If we set auto-generated IDs, however, we should use the modern syntax.
[#anchor-name]
= Section Title

+1 to generating IDs, not anchors, formatted as: [#anchor-name]!


[Style] Support backface-visibility style property on views.

For 3d animations with perspective, it is important to have backface-visibility.
Reference:
https://developer.mozilla.org/en-US/docs/Web/CSS/backface-visibility
cc @vjeux  @sahrens

Can you PR it?

I can def try this one. :D
Adding rotateX, rotateY, rotateZ first.

done.

The backface-visibility: hidden does't work in Android.

Same here, backface-visibility: hidden has no effect on Android. It's definitely defined in ViewStylePropTypes.js, it just isn't doing anything.

any update?

Not working on Android for me either. Any working workaround at the moment?

backface visibility is not supported on android. There was a PR for this: https://github.com/facebook/react-native/pull/6695. Feel free to send a new one based off of that PR.

Unfortunately I don't know Java, but thanks for the information and the link to the PR!

Any working workaround for this ?

I'm using Animated.Views and I've been playing with the idea of animating the opacity as well. It seems to work ok for my use case, and the only thing Im doing is this:
this.backOpacity = this.animatedValue.interpolate({       inputRange: [89, 90],       outputRange: [0, 1] })
and then use this for the animation
const backAnimatedStyle = {       opacity: this.backOpacity,...}
The Animated.Value in my case goes from 0-180 (symbolising degrees).
When I flip them back I go from 180 to 0, so thats why this solution is enough for my case.
So if your situation is similar to mine, maybe this will help for now.

Thanks, @vnil! Your workaround works amazingly well! It should become canonical, until backfaceVisibility is implemented in Android.

I got the same issue and the workarround is excelent... Thanks!!

A PR for backface-visibility is here #15970!

Great! @charpeni  . but PR is failed by CI  . Try to fix conflicts!

Thanks @vnil  . I will expand your solution : You explained the backOpacity, still now frontOpacity .. And it will be :
    this.frontOpacity = this.animatedValue.interpolate({
      inputRange: [89, 90],
      outputRange: [1, 0]
    });

    this.backOpacity = this.animatedValue.interpolate({
      inputRange: [89, 90],
      outputRange: [0, 1]
    });

Then: style={opacity:  this.frontOpacity} goes with Card Face,  and style={opacity:  this.backOpacity} goes with Card Back.

Thanks @vnil works perfectly

@vnil @Gringox - does anyone have a complete example? I am trying to integrate this with multiple sequenced animations and i cannot get it all to work, thanks  in advance


Make the month/day a bit clearer when navigating on mobile

The problem
It's quite annoying when on mobile when you're either "Mois" is selected and you can't see the current month name, or "Jour" is selected and you can't see the current date:

Proposed solution
The current month or date could be added (depending on whether "Mois" or "Jour" is selected), instead of just the week count (S*) and the day of the week, e.g.:

(This could definitely be made to look 100 times better, but you get the idea.)
I don't mind implementing this myself as a PR!
As a sidenote, and this should perhaps be another issue, but it would also be nice to add the beginning & ending times of an event inside the little popup which appears when it's being clicked on, so as to tell a bit easier (OTOH, this may make that little popup a little too cluttered).

Hello @obiwac , thanks you for opening an issue ! We love to see people getting interested in the programming part of ADE Scheduler :D
For the first part of your issue, I’m not sure how customizable FullCalendar is. The best thing to do might be to test your idea in a separate project that uses FullCalendar (not to bother with the installation process required to run your own ADE Scheduler server).
We use FullCalendar to display events and you can find the exact version in the repo files. Then, open a PR and we will review your work.
For the second part, it is better to open a second issue. But I expect a problem of too many information cluttered in a tight space.
If you have any question, please feel free to ask us here !

Hey ! Thanks for the issue, you are right it would be better to have the date on mobile as well.
Actually, this is something I intentionally removed back then as having the date plus the different buttons was making things very clustered and not very nice looking on mobile, cfr hose line of codes:
headerToolbar: {
  left: 'prev,next today addEvent',
  center: document.body.clientWidth > 550 ? 'title':'',
  right: document.body.clientWidth > 550 ? 'dayGridMonth,timeGridWeek':'dayGridMonth,timeGridDay'
},

Ideally, one would modify the layout to put the title "under" the buttons (as is done on your screenshot) instead of simply removing it. However, to be honest, I don't really know how to achieve this although I know the FullCalendar folks have introduced means to have custom CSS injected into the calendar.
Some links that might help: toolbar doc and css customization. I suspect some hacking around is required to achieve a clean mobile layout that includes the date...


Specify C compiler in build cross-compilation

Closes https://github.com/onflow/flow-emulator/issues/534
Description

remove unused Dockerfile.relic
update Dockerfile go build step:

enable cgo.
specify the C compiler for each arch target. This insures cross-compilation of the crypto non-portable code succeeds.
disable ADX instructions when compiling the crypto lib: crypto operations become slower but it makes sure binary can run on all CPUs.

For contributor use:

[x] Targeted PR against master branch
[x] Linked to GitHub issue with discussion and accepted design OR link to spec that describes this work
[x] Code follows the standards mentioned here
[x] Updated relevant documentation
[x] Re-reviewed Files changed in the GitHub PR explorer
[x] Added appropriate labels

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (70dcc68) 53.26% compared to head (cb4bb0f) 53.26%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #548   +/-   ##
=======================================
  Coverage   53.26%   53.26%
=======================================
  Files          29       29
  Lines        3869     3869
=======================================
  Hits         2061     2061
  Misses       1653     1653
  Partials      155      155

Flag
Coverage Δ

unittests
53.26% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Builds were enabled temporarily while working on the PR. You can see the results here.


Don't offer to add labels when I don't have permission to do so

Testing #4433
I'm offered to add labels to a PR on a repository I don't have permissions for. Admittedly didn't hit "Create PR", but I don't have permissions here: https://github.com/microsoft/python-sample-vscode-django-tutorial from what I see.

The "Add labels" icon still shows but disappears when I try to click it when I try to create a pull request in a repo I dont have permissions on.
https://user-images.githubusercontent.com/25044782/214958932-a1e02d81-5e5f-4c2e-a0b2-0c32b5426230.mp4


Allow to add url without TLD to install_app

I want to merge this change because...I want to allow install app with url without TLD

Impact

[ ] New migrations
[ ] New/Updated API fields or mutations
[ ] Deprecated API fields or mutations
[ ] Removed API types, fields, or mutations
[ ] Documentation needs to be updated

Pull Request Checklist

[ ] Privileged queries and mutations are guarded by proper permission checks
[ ] Database queries are optimized and the number of queries is constant
[ ] Database migration files are up to date
[ ] The changes are tested
[ ] GraphQL schema and type definitions are up to date
[ ] Changes are mentioned in the changelog

Task linked: SALEOR-2236 install_app rejects valid URLs

Should we validate if this url it's in ALLOWED_HOSTS?

@d-wysocki  also one important thing. The App model uses URLField which uses a standard URLValidator for checking the value. We need to take this into account during applying this changes, afaik.


Getting "supabaseKey is required" error when the key is literally there

Bug report
Describe the bug
This was already discussed here https://github.com/supabase/supabase/discussions/3919 but since there is no solution after more than a month I decided to report it here and hope that this will get a better solution than commiting my key to github 😅
TL;DR createClient only works when the key is passed as a string, not from the .env.local file
This works:
const url = "https://supabaseurlhere.supabase.co";
const supabase = createClient(url, "supabasekeyhere");

This doesn't work:
SUPABASE_KEY=supabasekeyhere

const url = "https://supabaseurlhere.supabase.co";
const supabase = createClient(url, process.env.SUPABASE_KEY!);

To Reproduce

Create .env.local file and add the Supabase key

SUPABASE_KEY=supabasekeyhere

Console.log the env variable just to check that it's working

console.log(process.env.SUPABASE_KEY);

Try to create the client using the env variable

const url = "https://supabaseurlhere.supabase.co";
const supabase = createClient(url, process.env.SUPABASE_KEY!);

See the error

Expected behavior
The client should be created using the key which IS in the env file. I tried logging it to the console and it is available from the "process.env.SUPABASE_KEY"
Screenshots

System information

OS: Windows 11
Browser: Brave
Version of supabase-js: 1.29.1
Version of Node.js: 17.2.0
Version of React: 17.0.2
Version of Next.js: 12.0.7
Version of TypeScript: 4.5.4

@kangmingtay just responded to the initial discussion with a solution so this can be closed, thank you! https://github.com/supabase/supabase/discussions/3919

If i'm not mistaken, since this is a nextjs app, your env var has to be prefixed with NEXT_PUBLIC so it shd look like NEXT_PUBLIC_SERVICE_KEY. Hope this helps!


mssql to make use of config/*.json connection string

according to sequelize docs, mssql accepts a connection string just like mysql/pg
http://docs.sequelizejs.com/en/latest/docs/getting-started/#setting-up-a-connection
for instance, the generator does generate the connection string under config/default.json
"mssql": "mssql://root:@localhost:1433/test",

but it's not being used anywhere since it was being hard coded under /src/services/index.js

:+1: thanks! I hadn't gotten around to testing with a windows environment.

Release v0.6.9 has this change.


Add GitHub Actions

Issue #, if available:
Description of changes:
The first commit simplifies Makefile. The second commit adds a YAML for GitHub Actions.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

You can see the result of GitHub Actions on https://github.com/kzys/amazon-ecs-shim-loggers-for-containerd/actions/runs/1183770258.


I cannot migrate

Type of issue
Typo
Description
[Введите отзыв здесь]
amirhon@Noutbuk-Amirhon Infrastructure % dotnet ef migrations add InitialCreate
Build started...
Build succeeded.
Unable to create a 'DbContext' of type ''. The exception 'Unable to resolve service for type 'Microsoft.EntityFrameworkCore.DbContextOptions' while attempting to activate 'Infrastructure.DataAccess.BookCatalogDbContext'.' was thrown while attempting to create an instance. For the different patterns supported at design time, see https://go.microsoft.com/fwlink/?linkid=851728
amirhon@Noutbuk-Amirhon Infrastructure %
Page URL
https://learn.microsoft.com/ru-ru/ef/core/dbcontext-configuration/#constructor-argument
Content source URL
https://github.com/dotnet/EntityFramework.Docs/blob/main/entity-framework/core/dbcontext-configuration/index.md
Document Version Independent Id
b0a3d5ad-b62c-1ff4-386a-f11e350eea0c
Article author
@ajcvickers

this exemption only on maOS

This issue is lacking enough information for us to be able to fully understand what is happening. Please attach a small, runnable project or post a small, runnable code listing that reproduces what you are seeing so that we can investigate.

can you send me your telegram link


Updated plugin to work with new Event APIs

LTGM, I dont see anything that could make this plugin stop working.


Roll Flutter Engine from b8ca6a5e0ecf to c007b3c242fc (2 revisions)

https://github.com/flutter/engine/compare/b8ca6a5e0ecf...c007b3c242fc
2022-05-12<EMAIL_ADDRESS>Roll Fuchsia Linux SDK from Vl7w2nU1L... to oU0932u8-... (flutter/engine#33283)
2022-05-12<EMAIL_ADDRESS>Roll Skia from d4aa36a9b644 to 866f74a1ef26 (1 revision) (flutter/engine#33282)
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from Vl7w2nU1LkXB to oU0932u8-sUy
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC<EMAIL_ADDRESS>on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Commit queue failed; closing this roll.


Compliance Trestle Logo is breaking on the PyPi page

Describe the bug
Quite recently there has been a new release and while reviewing PyPi page, the logo is not appearing properly in the webpage
To Reproduce
Steps to reproduce the behavior:

Go to '...'
Click on '....'
Scroll down to '....'
See error

Expected behavior
A clear and concise description of what you expected to happen.
Screenshots / Logs.

Environment

OS: [e.g. iOS]
Python version:
Installed packages:

This issue https://github.com/pypi/warehouse/issues/5246 seems to be the same thing happening to us.
To reproduce the solution described in the issue above behavior do the following:
1- Click on logo

2- It will redirect to blob instead not the raw image:

3- Change blob for raw instead:

This will redirect to the image itself not the "markdown".
I will do the change in the PR linked to this.


Values migration may leave incorrect data

Describe the bug: (a clear and concise description of what the bug is)
To Reproduce
Having files:
teams.yaml
teamConfig:
    teams: {}

and
secrets.teams.yaml
teamConfig:
    teams: {}

and relocation
    relocations:
      - teamConfig.teams: teamConfig

After running otomi migrate
The secrets.teams.yaml will preserve old structure.
The teams.yaml is emptied
Expected behavior: (a clear and concise description of what you expected to happen)
Both files are emptied.
Screenshots: (if applicable, add screenshots to help explain your problem)
Cluster(s):

Cloud: [e.g. aws]
Cluster: [e.g. demo]

Versions: (seen in console's /settings)

Core Version [e.g. 0.12.34]
Console Version: [e.g. aws]
API version: [e.g. 0.4.56]

Desktop: (if relevant)

OS: [e.g. iOS]
Browser [e.g. chrome, safari]
Version [e.g. 22]

Smartphone: (if relevant)

Device: [e.g. iPhone6]
OS: [e.g. iOS8.1]
Browser [e.g. stock browser, safari]
Version [e.g. 22]

Additional context: (add any other context about the problem here)

@Morriz perhaps you know how to fix it

@Morriz perhaps you know how to fix it

If there is no teams data nothing is done with that secrets file when writeValues is called.

ok, no worries if it is not an easy fix.
This is highly unlikely to happen because who is going to upgrade otomi without any team deployed ?
I am closing it because there are more important things to tackle.

Fixed in this PR: #761


fix(tabs): missing mat class on tab group

This change causes some IE issues. Need to investigate what's going on here that would mess them up


how to put the parent node on the left

In the treeview, can I make the parent node start from the left, like the following image：

please give me some pointers. thank you!

There isnt any option like this yet


Tidy up distribution.

Right now LICENSE and version files from Electron are included in the Windows and Mac distributions. That should be fixed.

Presumably also in the Linux distribution. License file may need to be incorporated into the open source licenses to list.


Remove some of the legacy code

Coverage increased (+7.6%) to 73.791% when pulling 3e56b6f3d9effcf28a593ef881dacffdef519b4d on randomir:master into e237a882b6de1d0a34b35d3df6e8ab72ec866745 on dwavesystems:master.


Azure CDN multiple CDN

I'm trying to use Azure CDN for azure static website through storage accounts and azure app service for our frontend. In the configuration part we are unable to configure origin for storage and web app in one endpoint.
Wanted to know if  there is a possibility of configuring both the origins in the same endpoint or we have to create different endpoints for each of the above origins.

I'm afraid this is the issues for the TypeScript programming language - I think you're looking for the docs for Azure Static Webapps: https://docs.microsoft.com/en-us/azure/static-web-apps/overview


Framework for unit and integration tests

Added mocha, chai, chai-as-promised, spectron, and electron-mocha to the devDependencies to facilitate tests. Also added a few basic tests for utils.ts and whether a window appears on startup.
Related to issue #125.

@mgbennet,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

This is shaping up nicely! Let's fill out the test cases a bit more to prove out the framework before merging it.

A few additional items to cover:

[ ] Make a pass over the code for use of implicit types (any, or non-typed structs)
[ ] Update the How to Contribute Wiki page to include a section on how to run the tests, how to write a test, etc.

Thank's @mgbennet! Nicely done!


invoke starting the app isnt working. im not getting url (local tunnel)

this is what shows up instead
/content/invokeai
/tools/node/bin/lt -> /tools/node/lib/node_modules/localtunnel/bin/lt.js

<EMAIL_ADDRESS>updated 1 package in 1.9s

<IP_ADDRESS>
2023-10-21 04:23:49.929744: W tensorflow/compiler/tf2tensorrt/utils/py_utils.cc:38] TF-TRT Warning: Could not find TensorRT
/usr/local/lib/python3.10/dist-packages/torchvision/transforms/functional_tensor.py:5: UserWarning: The torchvision.transforms.functional_tensor module is deprecated in 0.15 and will be removed in 0.17. Please don't rely on it. You probably just need to use APIs in torchvision.transforms.functional or in torchvision.transforms.v2.functional.
warnings.warn(
[2023-10-21 04:23:55,170]::[InvokeAI]::INFO --> Patchmatch initialized
[2023-10-21 04:23:56,218]::[uvicorn.error]::INFO --> Started server process [16404]
[2023-10-21 04:23:56,219]::[uvicorn.error]::INFO --> Waiting for application startup.
[2023-10-21 04:23:56,219]::[InvokeAI]::INFO --> InvokeAI version 3.3.0post3
[2023-10-21 04:23:56,219]::[InvokeAI]::INFO --> Root directory = /content/invokeai
[2023-10-21 04:23:56,220]::[InvokeAI]::INFO --> Using database at /content/invokeai/databases/invokeai.db
[2023-10-21 04:23:56,226]::[InvokeAI]::INFO --> GPU device = cuda Tesla T4
[2023-10-21 04:23:56,230]::[InvokeAI]::INFO --> Scanning /content/invokeai/models for new models
[2023-10-21 04:23:56,566]::[InvokeAI]::INFO --> Scanned 9 files and directories, imported 0 models
[2023-10-21 04:23:56,569]::[InvokeAI]::INFO --> Model manager service initialized
[2023-10-21 04:23:56,589]::[InvokeAI]::INFO --> Pruned 0 finished queue items
[2023-10-21 04:23:56,601]::[InvokeAI]::INFO --> Cleaned database
[2023-10-21 04:23:56,602]::[uvicorn.error]::INFO --> Application startup complete.
[2023-10-21 04:23:56,602]::[uvicorn.error]::INFO --> Uvicorn running on http://<IP_ADDRESS>:9090/ (Press CTRL+C to quit)

Thanks for notifying me about issue! The Localtunnel service has been unavailable recently. I added a comment about Localtunnel services being down and made Ngrok the first option. If the servers stay unavailable, I'll remove Localtunnel option entirely, and replace with another tunneling solution. For now, you can go with Ngrok.


Big size difference for Linux vs macOS/Windows

Solution to issue cannot be found in the documentation.

[x] I checked the documentation.

Issue
The size of the Polar package seems to be around 25 MB for macOS and Windows and 100 MB for Linux.
https://anaconda.org/conda-forge/polars

Installed packages
not relevant

Environment info
not relevant

👀  uncompressed it's 1GB

the issue started from 1.14.0 onwards, maybe because of https://github.com/conda-forge/polars-feedstock/pull/288


Rename and improve sortnan

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (965fc0d) 100.00% compared to head (cafb7c2) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #202   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files           68        68
  Lines         1624      1624
  Branches       165       165
=========================================
  Hits          1624      1624

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Optional Y key?

I would like to be able to specify the value of y data members in scatterplots.
// dataset = [
//     {'x_var': 1, 'y_var': 1}
//     {'x_var': 2, 'y_var': 3}
//     {'x_var': 3, 'y_var': 4}
// ]

c3.generate({
    bindto: '#c3chart',
    data: {
      json: dataset,
      x: 'x_var'
      y: 'y_var'
      type: 'scatter',
    }
    }
});

Is this something the maintainers want?  Whereabouts should I be working to add this?

You can do that now using the keys.value configuration except keep in mind that you can multiple y-values so you have to specify it as an array with only one value in single y-values cases like your example. Here is an example. I've never tried it with a scatter chart but here is how I think it's supposed to work.
c3.generate({
    bindto: '#c3chart',
    data: {
        json: dataset,
        keys:{
            x: 'x_var',
            value: ['y_var']
        },
        type: 'scatter'
    }
});

Works perfectly.  Thanks for the heads up!
On Wed, May 20, 2015 at 1:15 PM, Larry Maccherone<EMAIL_ADDRESS>wrote:

You can do that now using the keys.value configuration except keep in
mind that you can multiple y-values so you have to specify it as an array
with only one value in single y-values cases like your example. Here is an
example http://c3js.org/samples/data_json.html. I've never tried it
with a scatter chart but here is how I think it's supposed to work.
c3.generate({
bindto: '#c3chart',
data: {
json: dataset,
keys:{
x: 'x_var',
value: ['y_var']
},
type: 'scatter'
}
});
—
Reply to this email directly or view it on GitHub
https://github.com/masayuki0812/c3/issues/1175#issuecomment-103965679.


[QST] Is there a two_pass_precision mode for brute force knn?

My project uses RAFT brute force knn and I noticed a drop in precision when I upgraded to the latest RAFT. I moved to cuvs but still see cosine similarity that's off by more than 1e-04 when compared to the dot product cpu calculation. Is this a bad use case for cuvs?
I had this issue before when I was using cuML and two_pass_precission fixed it, unfortunately it also suffered from a different correctness bug https://github.com/rapidsai/cuml/issues/5569. Would appreciate any suggestions.

Thanks for creating an issue about this @phact. can you share a little more info about how you are using this? Are you using the Python API? What precision is your data? (float or double?). If it's not too hard to provide a trivial reproducible example then that would be helpful.
Sometimes this can be caused my multiple sources of small precision errors throughout the computational stack- inner product can mount small errors, then follow-on arithmetic can make things slightly worse. We will work to get this fixed if you can help us understand more.

Thanks for the reply @cjnolet yeah it's the python API using float32.
I'll take a stab at a minimum reproducible example.


Implement #2230 - Consume BindingAddress instead of ServerAddress

Hello. I've tried to implement changes for #2230. I've done this:

Marked ServerAddress obsolete and suppress CS0618 errors in ServerAddressTests
Added reference to Microsoft.AspNetCore.Http in Kestrel.Core.csproj
Replaced usage of ServerAddress.FromUrl with BindingAddress.Parse
Update tests

I hope nothing is wrong =)

@halter73 @shirhatti let's decide if we can take this in release/2.2. If so then in 3.0 it'd be easy to remove the obsolete type.

@muratg @shirhatti thoughts on obsoleting ServerAddress in 2.2? It's officially a public type, but not one used in any public APIs.

@shirhatti thoughts on this?

If we take this in 2.2, we should probably update all servers. I'd like to see this https://github.com/aspnet/HttpSysServer/issues/422 go in as well

@shirhatti this is an implementation detail for the servers, not a public API we expect people to use directly with the servers.

Offline notes: This is fine to take in 2.2, and the HttpSys change would be orthogonal.
@SonicGD can you move this to the release/2.2 branch? If not then I can get to it next week.

@Tratcher Sure, will do today

Thanks


Has anyone tried adding self-supervised constrative loss to SCL?

That is to say, supervised contrastive loss and self-supervised constrative loss, the former can be regarded as global and the latter is local.

Hi @Chen-Song , did you try this out?


Cummerbund

Modified training on "Visualization of RNA-Seq results with CummeRbund"

Explained each field of the CuffDiff output that is used as input data
Previous filter/sort procedure filtered on segnificance attribute, then sorted descending on log2fold_change. Since the goal is instead to sort on the statistically assessed log2fold_change, the new filter/sort procedure filters on significance attribute, and then sorts on Q-value (ascending) and log2fold_change (descending)
Added link to the ggplot objects generated by CummeRbund
Added heatmap for the top-5 significant differentially expressed gene isoforms

thanks a lot @bagnacan!
ping @mblue9 perhaps you would like to review this?

@shiltemann, @mblue9, thank you for your edits and suggestions! I addressed the last comments in my latest contribution. What do you think?

@bagnacan thanks for the edits and don't worry about dismissing the stale review, that happens automatically when changes are made after an approval :)

Thanks @bagnacan, I just added some tiny edits.


Update deprecated-react-native-listview

This is required to work with react-native 0.62+

@deanmcpherson if you have some time do you think you could review this PR? It is required for this library to work on the latest version of react-native.


Flyway 5 regression when line in multi line string starts with single line comment

What version of Flyway are you using?
5.0.7
Which client are you using? (Command-line, Java API, Maven plugin, Gradle plugin, SBT plugin, ANT tasks)
Command-line & Java API
What database are you using (type & version)?
MySQL 5.7, SQL Server, Oracle, DB2
What operating system are you using?
Linux
What did you do?
(Please include the content causing the issue, any relevant configuration settings, and the command you ran)
V1_test_code.sql
CREATE TABLE `certstore` (
  `cert` text,
  `last_modified_date` datetime DEFAULT NULL
) ENGINE=InnoDB DEFAULT CHARSET=utf8;

insert into certstore (cert) values ('old cert data');

update certstore set cert = '-----BEGIN CERTIFICATE-----
MIIEIjCCAwqgAwIBAgIIAd68xDltoBAwDQYJKoZIhvcNAQEFBQAwYjELMAkGA1UE
BhMCVVMxEzARBgNVBAoTCkFwcGxlIEluYy4xJjAkBgNVBAsTHUFwcGxlIENlcnRp
ZmljYXRpb24gQXV0aG9yaXR5MRYwFAYDVQQDEw1BcHBsZSBSb290IENBMB4XDTEz
MDIwNzIxNDg0N1oXDTIzMDIwNzIxNDg0N1owgZYxCzAJBgNVBAYTAlVTMRMwEQYD
VQQKDApBcHBsZSBJbmMuMSwwKgYDVQQLDCNBcHBsZSBXb3JsZHdpZGUgRGV2ZWxv
cGVyIFJlbGF0aW9uczFEMEIGA1UEAww7QXBwbGUgV29ybGR3aWRlIERldmVsb3Bl
ciBSZWxhdGlvbnMgQ2VydGlmaWNhdGlvbiBBdXRob3JpdHkwggEiMA0GCSqGSIb3
DQEBAQUAA4IBDwAwggEKAoIBAQDKOFSmy1aqyCQ5SOmM7uxfuH8mkbw0U3rOfGOA
YXdkXqUHI7Y5/lAtFVZYcC1+xG7BSoU+L/DehBqhV8mvexj/avoVEkkVCBmsqtsq
Mu2WY2hSFT2Miuy/axiV4AOsAX2XBWfODoWVN2rtCbauZ81RZJ/GXNG8V25nNYB2
NqSHgW44j9grFU57Jdhav06DwY3Sk9UacbVgnJ0zTlX5ElgMhrgWDcHld0WNUEi6
Ky3klIXh6MSdxmilsKP8Z35wugJZS3dCkTm59c3hTO/AO0iMpuUhXf1qarunFjVg
0uat80YpyejDi+l5wGphZxWy8P3laLxiX27Pmd3vG2P+kmWrAgMBAAGjgaYwgaMw
HQYDVR0OBBYEFIgnFwmpthhgi+zruvZHWcVSVKO3MA8GA1UdEwEB/wQFMAMBAf8w
HwYDVR0jBBgwFoAUK9BpR5R2Cf70a40uQKb3R01/CF4wLgYDVR0fBCcwJTAjoCGg
H4YdaHR0cDovL2NybC5hcHBsZS5jb20vcm9vdC5jcmwwDgYDVR0PAQH/BAQDAgGG
MBAGCiqGSIb3Y2QGAgEEAgUAMA0GCSqGSIb3DQEBBQUAA4IBAQBPz+9Zviz1smwv
j+4ThzLoBTWobot9yWkMudkXvHcs1Gfi/ZptOllc34MBvbKuKmFysa/Nw0Uwj6OD
Dc4dR7Txk4qjdJukw5hyhzs+r0ULklS5MruQGFNrCk4QttkdUGwhgAqJTleMa1s8
Pab93vcNIx0LSiaHP7qRkkykGRIZbVf1eliHe2iK5IaMSuviSRSqpd1VAKmuu0sw
ruGgsbwpgOYJd+W+NKIByn/c4grmO7i77LpilfMFY0GCzQ87HUyVpNur+cmV6U/k
TecmmYHpvPm0KdIBembhLoz2IYrF+Hjhga6/05Cdqa3zr/04GpZnMBxRpVzscYqC
tGwPDBUf
-----END CERTIFICATE-----', last_modified_date=NOW();

commit;

What did you expect to see?
The above V1_test_code.sql file should run without any issues as it is working as expected in 4.2.0, but is failing in 5.0.x because of a regression.
What did you see instead?
My analysis and fix:
This is a regression caused in Flyway 5.0.x codebase.
Regression was introduced in this line: https://github.com/flyway/flyway/blob/flyway-5.0.7/flyway-core/src/main/java/org/flywaydb/core/internal/database/SqlStatementBuilder.java#L199
if (endWithOpenMultilineStringLiteral() || insideMultiLineComment || isSingleLineComment(lineSimplified)) {
    statement.append(line);
    return;
}

But the same logic in 4.2.0 is: https://github.com/flyway/flyway/blob/flyway-4.2.0/flyway-core/src/main/java/org/flywaydb/core/internal/dbsupport/SqlStatementBuilder.java#L193
if (endWithOpenMultilineStringLiteral() || insideMultiLineComment) {
    statement.append(line);
    return;
}

In 5.0.x code, code is checking if the line starts with line comment (--) and if it does, then Flyway is thinking the that line is not terminating line and amusing there would be following lines in the same statement. But it is not checking if that comment chars are inside a multi line string literal value, which is exactly our case.
I've fixed it by adding extra check endWithOpenMultilineStringLiteral() for isSingleLineComment(lineSimplified) condition check, like below:
if (endWithOpenMultilineStringLiteral() || insideMultiLineComment ||
        ( endWithOpenMultilineStringLiteral() && isSingleLineComment(lineSimplified) )) {
    statement.append(line);
    return;
}

But isSingleLineComment() is used in other place also. Not sure if the same gaurd is required in that place also.

Thanks Mani for identifying the code which is causing this issue.

Thanks for the report and the detailed analysis. The example you provided is for MySQL. Are you seeing this for the other 3 databases you mentioned as well?

I've not tested with other DBs for this specific scenario. But as the fix is in common class, I assume it will affect others too.

I also thought of adding the safe guard check in 'isSingleLineComment()' method itself, but I'm not sure if that could cause another regression, which I doubt though.

Thanks for reporting. Fixed.

Thanks for quick fix.
Just for my info - is 'isSingleLineComment()' not at required?

@manikantag I would appear not. I couldn't find a single scenario where it actually made sense.


Visualizer tool

Closes #5.
This PR builds on #20 so it appears slightly weightier than it is.  Make no mistake -- this is a very large PR, but I don't know if it could be made smaller.
There are again two commits:

Introduces the discovery logic used by the visualization tool.  This is largely cribbed from t.p.modules, and indeed the hardest part -- module exploration -- is handled by PythonModule.  Unfortunately there is no version of namedAny that returns PythonModule or PythonAttributes instead of actual objects.  This meant either using less of t.p.modules (which appears to be what trial does) or reimplementing namedAny in terms of t.p.modules objects.  I chose the latter.  An open question here: should findMachinesViaWrapper (and thus findMachines) accept an argument to ignore import-related errors?  This would allow for best-effort machine collection.

Introduces the command line tool itself.  This PR should probably also include proper documentation for publishing on readthedocs or the like, but given that I don't expect this to pass review, I'll hold off on that.

Most of the lines are in test files.  Some of that is related to awkwardness caused by unittest (such as no tmpdir affordance.)  If there's a portable way to tell unittest to skip a module and not a test, that could help cut down on the lines quite a bit; as it stands now, tests can't use py.test extensions or trial's SynchronousTestCase.

Coverage increased (+0.03%) to 98.686% when pulling 19a6806c02c1697bc24216a71f8fde96563470ed on markrwilliams:visualizer-tool into f6885f96307383fbb1974532df81fefc06e1c187 on glyph:master.

Closing until #20 is merged and I can rebase this onto master.

Coverage increased (+0.03%) to 98.686% when pulling 19a6806c02c1697bc24216a71f8fde96563470ed on markrwilliams:visualizer-tool into f6885f96307383fbb1974532df81fefc06e1c187 on glyph:master.

(Merge worked better than rebase!)

Coverage increased (+0.3%) to 99.141% when pulling c40a55f7df49c45f751168db96ec0280c13e4d2e on markrwilliams:visualizer-tool into 07ec3f5f544f00265f2b726dc766641c69577799 on glyph:master.

Coverage increased (+0.3%) to 99.141% when pulling c40a55f7df49c45f751168db96ec0280c13e4d2e on markrwilliams:visualizer-tool into 07ec3f5f544f00265f2b726dc766641c69577799 on glyph:master.

Coverage increased (+0.3%) to 99.141% when pulling 48a01ec74573ba5720b79fef49736ef6dfb498d6 on markrwilliams:visualizer-tool into 07ec3f5f544f00265f2b726dc766641c69577799 on glyph:master.

@glyph this behemoth is ready for review!  The commits that are actually relevant begin with https://github.com/glyph/automat/pull/21/commits/8acecaab184f98a8f05e45680753189340967166; looks like GitHub didn't Do The Right Thing with the merge commit.

This looks pretty good and while I might nitpick little pieces of the implementation, I don't think there's much significant to be learned.  Landing.


afsctool: init at 1.7.0

Description of changes
Add a tool for enabling filesystem-level compression of HFS/APFS files and folders.
This is a macos specific tool.
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[x] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 176485 run on x86_64-linux 1


In v0.54, intersection of objects with properties of the same name seems to behave strangely

function  _onClearButtonFocus(
  e: SyntheticFocusEvent<HTMLElement> & { relatedTarget: HTMLElement }
) {
  // prevent the focus on the clear button
  if (e.relatedTarget) {
    e.relatedTarget.focus();
  } else {
    e.currentTarget.blur();
  }
}

Error:
    6:     e.relatedTarget.focus();
                           ^ property `focus`. Property not found in
    6:     e.relatedTarget.focus();
           ^ EventTarget

Here is a Try.
The problem I see is that SyntheticFocusEvent is defined with a relatedTarget: EventTarget property. But this shouldn't be a problem !
It looks like that a "direct" intersection works fine (see last example on the try).
A possible fix would be to define SyntheticFocusEvent to have 2 type parameters: one for currentTarget and one for relatedTarget. But I feel like there is a deeper bug here.

Smaller testcase that works in newer Flow versions
type A = {
  prop: {
    focus: () => {}
  }
};

type B = {
  prop: {
    blur: () => {}
  }
};

function test(a: A & B) {
  a.prop.focus();
  a.prop.blur();
}

For anybody coming here, the workaround is to put { relatedTarget: XXX } before SyntheticFocusEvent.

Aren't intersections supposed to be commutative?

That's what I intuitively thought, but I don't think this is always true in Flow.

I'd think so too, but this comment on the React HOC documentation suggests it's not:
https://flow.org/en/docs/react/hoc/

This uses an intersection to say that the type for props is everything in Props (which is the props type for our output component) except for foo which has a type of number.
Note: The intersection order is important here!


A new domain of Polish high school in the city of Leszno

@tpxHorus Please provide us with:

the school official website URL
the school street address, including city and country
an URL of a page on the official website where the school offers an IT-related long-term (>1 year) course
a proof, which shows that the school recognizes the domain you are submitting as an official email domain for the students.

Please provide us with a proof, which shows that the school recognizes the domain you are submitting as an official email domain for the students.
You can provide us with any of the following:

A copy of instruction (a hard-copy or electronic one) given to you by the school that tells you to use an email address in this email domain
An URL of a page at the official school website that says that students use this email domain
A reference to a recognized journal where an article was published by someone from the school, with explicit affiliation to the school, and e-mail address from the email domain
A WHOIS data that link the email domain to the school somehow
A copy of official letter from the school representative saying that the school provides e-mail addresses in this domain to the students
Anything else that can prove this fact in similar way, i.e. can be verified independently.

@tpxHorus You might miss my previous comment. Please react.

@tpxHorus You might miss my previous comment. Please react.

@tpxHorus I am sorry, this request remains unanswered for a while. I have to close it without merging. Please reopen and comment if you have an update regarding the aforementioned issue. Thank you for your understanding!


Add flag to allow global installs e.g. for CI

We require install into a virtual environment, but in ephemeral builds like CI or containers this may not be desired.

I was facing the same issue. Maybe provide a --no-envor --global variable so the user can't do it by accident

Ya, this has been a blocker to using this to speed up some slow container builds unfortunately.

Workaround credit to @matthewfeickert:
    - name: Set the VIRTUAL_ENV variable for uv to work
      run: |
        echo "VIRTUAL_ENV=${Python_ROOT_DIR}" >> $GITHUB_ENV

I actually took that from https://github.com/astral-sh/uv/issues/1386#issuecomment-1947801083 and https://github.com/astral-sh/uv/issues/1386#issuecomment-1947835870. The important bit here is that it needs to be done in a seperate step before you want to use it, so you can't modify the $GITHUB_ENV in the same run command as you want to use it.

(Naming the flag --system would mirror venv's --system-site-packages)

I got this error pointing the env to the python location as @henryiii posted. Did anyone face the same issue? In the docker container it worked fine

https://github.com/rotki/rotki/pull/7499

I am a fan of a system flag though @zanieb has done a lot more work on the Python discovery stuff.

I can probably take this on next week.

@zanieb not sure if you want this as a separate ticket, but in containers where we install system python through apt-get, uv pip install fails because there's no /usr/lib/python3.10/site-packages directory (all libs are just in /usr/lib/python3.10 by the looks of it). Example Dockerfile to reproduce:
FROM nvidia/cuda:12.1.1-devel-ubuntu22.04

RUN apt-get update && \
    apt-get install -y build-essential python3.10 python3.10-dev curl && \
    apt-get clean

RUN ln -s /usr/bin/python3.10 /usr/bin/python

RUN curl -LsSf https://astral.sh/uv/install.sh | sh

ENV VIRTUAL_ENV="/usr"
RUN /root/.cargo/bin/uv pip install ruff -v

> [5/5] RUN /root/.cargo/bin/uv pip install ruff -v:
0.286  uv::requirements::from_source source=ruff
0.287     0.001892s DEBUG uv_interpreter::virtual_env Found a virtualenv through VIRTUAL_ENV at: /usr
0.288     0.001951s DEBUG uv_interpreter::interpreter Detecting markers for: /usr/bin/python
0.308     0.022522s DEBUG uv::commands::pip_install Using Python 3.10.12 environment at /usr/bin/python
0.310 error: Failed to list installed packages
0.310   Caused by: failed to read directory `/usr/lib/python3.10/site-packages`
0.310   Caused by: No such file or directory (os error 2)
------

https://ryxcommar.com/2024/02/15/how-to-cut-your-python-docker-builds-in-half-with-uv/

Similar to #1396 a --python flag would solve this constraint. Additionally, it makes sense to simply use whatever comes first on PATH as a default; users have come to expect this.

I got this error pointing the env to the python location as @henryiii posted. Did anyone face the same issue? In the docker container it worked fine

rotki/rotki#7499

I see this same error, but only in Python 3.9 and 3.10. Python 3.11 works fine.

@zanieb not sure if you want this as a separate ticket, but in containers where we install system python through apt-get, uv pip install fails because there's no /usr/lib/python3.10/site-packages directory (all libs are just in /usr/lib/python3.10 by the looks of it). Example Dockerfile to reproduce:
FROM nvidia/cuda:12.1.1-devel-ubuntu22.04

RUN apt-get update && \
    apt-get install -y build-essential python3.10 python3.10-dev curl && \
    apt-get clean

RUN ln -s /usr/bin/python3.10 /usr/bin/python

RUN curl -LsSf https://astral.sh/uv/install.sh | sh

ENV VIRTUAL_ENV="/usr"
RUN /root/.cargo/bin/uv pip install ruff -v

> [5/5] RUN /root/.cargo/bin/uv pip install ruff -v:
0.286  uv::requirements::from_source source=ruff
0.287     0.001892s DEBUG uv_interpreter::virtual_env Found a virtualenv through VIRTUAL_ENV at: /usr
0.288     0.001951s DEBUG uv_interpreter::interpreter Detecting markers for: /usr/bin/python
0.308     0.022522s DEBUG uv::commands::pip_install Using Python 3.10.12 environment at /usr/bin/python
0.310 error: Failed to list installed packages
0.310   Caused by: failed to read directory `/usr/lib/python3.10/site-packages`
0.310   Caused by: No such file or directory (os error 2)
------

We're facing the same with Ubuntu 22.04 and Python 3.10 in docker.

In the next release, you can provide a --python flag to uv pip install and uv pip sync in lieu of setting the VIRTUAL_ENV variable in CI environments.
--python can point to any Python interpreter -- it doesn't need to be a virtualenv (e.g., --python $(which python3.12) and so on).

(I'm undecided on adding a flag like --system or --global, since it'd just be a syntactic nicety over --python.)

--cicd ?

I'm not sure why this would be better specified as just for CI.
Would --system be exactly equivalent to --python python3? --python python3 would be confusing to see when reviewing code.

Would --system be exactly equivalent to --python python3? --python python3 would be confusing to see when reviewing code.

Roughly, yeah. (My assumption is that internally, we'd just use find_default_python instead of passing a selector to find_requested_python.)

--python-executable?
Explicit is better than implicit ;-)

Thank you for this great tool and the exceptional community support! ♥
--python python3 could be confused with specifying "not Python 2". --python python looks weird to me.
--global, --system, --no-venv, or --python-executable XYZ would solve this.

I think in CI environments like GitHub Actions (or Docker containers, etc.) I'd expect that you'd typically either encode the full path (--python /usr/...) or use --python $(which python3) or similar.
(But I'm not really opposed to adding --system or --global.)

I don't think using which is platform portable so that sounds annoying. I'm loosely in favor of adding a dedicated flag. I don't know if --global is any clearer than --system to me.

--python python3 could be confused with specifying "not Python 2"

Is there a problem with that? It would indeed be problematic if we picked up Python 2 because we don't support it. I would be worried that people would do --python python and be confused when it picked up Python 2 which still seems weirdly common.

I think --python ... is fine, and there is no need for another flag that is syntactic sugar over this.
My rationale is that I think if "regular pip" as "always part of a specific Python distribution" (installed via ensurepip or a system package), so --system/--global makes sense, as it refers to the implicit Python it was installed with.
But I think of "uv pip" as a global command untied to any Python interpreter (installed from cargo/pipx/..), so --system/--global seems confusing. Hence the need to specify the Python interpreter.
AFAICT a parallel is that pip-compile from pip-tools uses the Python it is installed with to generate the requirements, whereas uv pip compile has a --python-version (even though it is optional).
Perhaps my mental model of this is inaccurate though 😉

When it comes to working with scripts / workflows in the CI, I think having a dedicated flag (precise name doesn't matter so much) would help simplify things at the user end. You're frequently working on different operating systems and environments and so not needing to supply this every time would be helpful.

I empathize with that perspective but we still want to guide users towards using virtual environments and make installing into the system Python an opt-in behavior. It's an intentional difference to have a virtual environment-focused workflow by default, and something we plan to continue to do. Manipulating the system Python is generally discouraged and even dangerous (see: Externally Managed Environments), and I think it's good for us to take advantage of the opportunity to have some different defaults from pip, this being one of them.

Also, I should point out that pip does have the ability to be used in this way - pip --python <python> allows you to target some other Python install, and using this actually speeds up tools like build - we reduced our venv based backend building an sdist and wheel from 10 seconds to 4 seconds by removing the pip install and instead using the outer pip instance (if possible). Historically, people have always installed pip and used pip wherever Python was (that's why people even push for python -m pip over pip, to ensure you are getting the "local" one, though pip --python python is actually just as valid), but that's not necessarily the best model.
The big difference with uv is it's built for virtualenvs, and picks up on them automatically. I need to be sure that uv pip install <thing> will install into .venv, not my system! I was really worried about that when I first started using uv, and love that it does ensure that I can't mess up my system by mistake.
FYI, in GitHub Actions, especially if you were setting up a composite action, you could do it this way:
    - uses: actions/setup-python@v5
      id: python
      with:
        python-version: "3.12"
        update-environment: false
    - run: |
        uv pip install --python "${{ steps.python.outputs.python-path }}" <...>

This is explicit and will not affect the environment of future steps.

Thanks for the quick release!
I just tested uv 0.1.12 and looks like uv pip install --system ... did its thing, but then neither pytest nor python -m pytest worked ("command not found" and "No module named pytest" respectively).
https://github.com/kedro-org/kedro-plugins/actions/runs/8088151338/job/22101608421

Thanks @astrojuanlu -- I'm tracking that here: https://github.com/astral-sh/uv/issues/2056. It's something specific to Windows with Python versions prior to Python 3.12 (i.e., Python 3.12 seems to work).

Calling this complete! --system exists.

Not sure if this merits a new issue (it probably does) but can this be implemented for uv pip compile as well?

I think uv pip compile will already discover a system Python if needed, since it doesn't modify the virtual environment. Are you seeing otherwise?

Well, yes and no.
I actually had a broken .venv dir which it auto discovered:
$ uv pip compile be3_lib.txt
error: Broken virtualenv `/repos/analytics_content/.venv`, it contains a pyvenv.cfg but no Python binary at `/repos/analytics_content/.venv/bin/python`

This is because I use this directory in a docker container which is mounted so it broke the venv symlink. After I removed the .venv dir it worked as expected.
Maybe adding the same --system / --python flags here as well in order to explicitly set it?
Thanks for the swift response, it's very much on brand with uv & ruff 😆

Yeah, it could make sense to include it for consistency.

Cool, do you want me to open a separate issue for this?

Yes please, you can just link to your comment above, no need to write an extensive description.

Great thread. I came here because I want to install dependencies in CI using uv sync.
Do we want to support --system for uv sync? I am proposing this here: https://github.com/astral-sh/uv/issues/8085


Clean up labels and domain usage

fix #1383
chore: replace epinio.suse.org, use epinio.io.
note: this changes various resource labels.
done: chart changes
note: doc changes are a separate PR

Codecov Report

Merging #1503 (c9b720d) into main (6a27915) will decrease coverage by 53.85%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main   #1503       +/-   ##
==========================================
- Coverage   62.70%   8.85%   -53.86%
==========================================
  Files         165      81       -84
  Lines       12083    7893     -4190
==========================================
- Hits         7577     699     -6878
- Misses       3535    7148     +3613
+ Partials      971      46      -925

Flag
Coverage Δ

acceptance-api
?

acceptance-apps
?

acceptance-cli
?

unittests
8.85% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

internal/api/v1/application/stage.go
0.00% <0.00%> (-76.14%)
:arrow_down:

internal/application/application.go
0.00% <ø> (-64.33%)
:arrow_down:

internal/application/workload.go
0.00% <0.00%> (-56.16%)
:arrow_down:

internal/configurations/configurations.go
0.00% <0.00%> (-81.78%)
:arrow_down:

internal/registry/registry.go
39.56% <ø> (-17.59%)
:arrow_down:

main.go
0.00% <0.00%> (-100.00%)
:arrow_down:

helpers/string.go
0.00% <0.00%> (-100.00%)
:arrow_down:

internal/api/v1/authtoken.go
0.00% <0.00%> (-100.00%)
:arrow_down:

internal/auth/certs.go
0.00% <0.00%> (-85.00%)
:arrow_down:

internal/api/v1/application/match.go
0.00% <0.00%> (-82.36%)
:arrow_down:

... and 148 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a27915...c9b720d. Read the comment docs.


Add GENERATE_PKGCONFIG option

This PR fix this issue.

Thank you very much for this PR, it's a great addition! 😄