i3 workaround for color picker window not marked as "tool window popup"

When you're using a tiling window manager like i3 on linux the color picker comes up as a regular window which means it takes up half the screen space. The color picker in atom doesn't do that.
This issue can be worked around in the i3 config file, by adding this:
for_window [class="vscode-color-ui"] floating enable

Hi @mo, thank you for the report.
So, this issue is solved by your config in the i3?

I had to set:
"colorHelper.disableShadow": true
in settings.json as well but now it works really well for me. It would have been better if it "just worked" out of the box but I'm happy now at least. I opened this issue mostly so that people that run into the same problem could find something useful on google to help them out. Feel free to close this issue if you feel that it's to niche to be worth fixing.

This is caused by a behavior of Electron in i3-wm. Therefore it seems that we can do nothing to solve it perfectly, unfortunately. And I close this issue.
Your solution should help them who have same problem. Thank you again 😄


Dockerfile: test SSH on port 22

as we provide SSH working by default on the base image, we should be sure it's working correctly

tests are presetnt


feat: swap red & blu teams on game details

Swap BLU & RED teams on game details page to avoid confusion. Most HUDs have RED on the right-hand side and BLU on the left one.

Codecov Report

Merging #7 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master       #7   +/-   ##
=======================================
  Coverage   73.46%   73.46%
=======================================
  Files          48       48
  Lines         441      441
  Branches       35       35
=======================================
  Hits          324      324
  Misses        104      104
  Partials       13       13

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b8ddff3...640374b. Read the comment docs.


added the ability to immediately select the desired Dispatch class name

Added the ability to immediately select the desired class name

Thanks @SergeyMi37

Thanks @SergeyMi37


Critical flaw

I have found a critical flaw in this repository. It will scan all the file in the folder. This is a problem when it will start counting lines from in example node_modules folder. I can propose a change for this. I.e you could remove the folders found from the gitignore file
Nöfnöf

nöfnöf

how dare you miss this important flaw in your code, klinoff will not be happy to hear this!!

nöfnöf


Page cache multisite flush

Fix for #135 and #136. Also a tweak for #134.

Thank you! Great works!


a question about Y032: "var vm = this"

A friend of mine asked me a question about the JSHint warning "Possible strict violation". In asking for more detail, he pointed me to the style guide here:
https://github.com/johnpapa/angular-styleguide/blob/master/a1/README.md#style-y032
I'm not sure I understand the intent behind this recommendation - at least, not with the initial examples shown.

Why?: The this keyword is contextual and when used within a function inside a controller may change its context. Capturing the context of this avoids encountering this problem.

/* recommended */
function CustomerController() {
    var vm = this;
    vm.name = {};
    vm.sendMessage = function() { };
}

This example doesn't solve any of the gotcha's around this, it just creates a JSHint warning as noted in the style guide.
I can see the value of var vm = this in the later example, though:
function SomeController($scope, $log) {
    var vm = this;
    vm.title = 'Some Title';

    $scope.$watch('vm.title', function(current, original) {
        $log.info('vm.title was %s', original);
        $log.info('vm.title is now %s', current);
    });
}

Here, there's good reason for the vm variable - to provide access to the SomeController instance, from within the $scope.$watch callback.
But i'm wondering:
Why this is a recommendation for style, including the override of the JSHint rule?
Why not provide another of the many options for managing this in the callback for $watch, as a recommendation?
I'm not suggesting this be changed, at this point. I'm just curious about the recommendation. I would like to understand why this recommendation is made.
Thanks!

also, fwiw, i'm not an angular user so this may be an obvious question / answer for those that are...
is this because $watch is evaluating vm.title to know what object and attribute it should watch?

The possible strict violation has nothing to do this style afaict. It is the same whether you capture this in another variable or use it directly. So, it seems totally out of place there. It should be placed to another rule that recommends starting controller constructors with an uppercase letter. (Is there even such a rule?)
The examples are also pretty poor in this rule. The first one doesn't show accessing this/VM from inside a method and the one with $watch doesn't access this/vm either and would work equally well with both versions. (It even gives the false impression that the vm appearing in the strings is related to the name of the variable :disappointed:)

@johnpapa that doesn't really answer my question, though... sure, they are options. but, back to the question: what was the reason for this recommendation?

@derickbailey

Why?: The this keyword is contextual and when used within a function inside a controller may change its context. Capturing the context of this avoids encountering this problem.

Following snippet shows when capturing controller instance to a variable becomes useful. Inside a click handler, this is set to something else than the controller instance itself. So, having the variable vm available within such handler comes in handy.
var vm = this;

vm.onButtonClicked = onButtonClicked;
vm.doSomething = doSomething;

function onButtonClicked() {
    // this.doSomething is undefined.
    vm.doSomething();
}

function doSomething() {
    // ...
}

Also,
$scope.$watch('vm.title', function(current, original) {
        $log.info('vm.title was %s', original);
        $log.info('vm.title is now %s', current);
});

This vm is something else than the variable vm declared in the controller. This vm is the controller alias defined in SomeController as vm syntax in your view or route definition.
When you use controllerAs syntax, Angular adds a property to the scope with the given alias as key and the controller instance as its value.
<div ng-controller="MyController as vm">
</div>

angular
    .module('myModule', [])
    .controller('MyController', function ($scope) {
        $scope.foo = 'bar';
    });

After your controller is instantiated, your $scope looks like this
{
    foo: 'bar',
    vm: <MyController instance>,
    // other stuff
}

thanks, @prashantpalikhe! that makes sense now :)

@johnpapa
I have recently faced an issue with vm of one controller clashing with the other.
I had a directive called ecbSelectViews 👍
angular
.module('app.layout')
.directive('ecbSelectViews', Directive);
function Directive() {
var directive = {
bindToController: true,
restrict: 'EA',
templateUrl: 'app/layout/selected-view/selectViews.html',
controller: 'selectViewsController',
controllerAs: 'vm'
};
return directive;
}
And I have to use this directive in system-bar. When I place this  in system-bar.html
The the system bar code is getting disturbed. Not able to fetch any expressions and call ng-click functions in system-bar controller.
Then I understood that both the controller vm s are getting clashed and I renamed the selectViewsController to 'sm'
templateUrl: 'app/layout/selected-view/selectViews.html',
controller: 'selectViewsController',
controllerAs: 'sm'
Now everything is working fine.
Why does two vm s clash although they are pointed to their own controllers while defining the directive?

For me ,it was a conflict of two controllers .When  doing " var vm=this " ,the scope was already using another controller,so it was not able to assign itself to a new controller .

For me ,it was a conflict of two controllers .When doing " var vm=this " ,the scope was already using another controller,so it was not able to assign itself to a new controller .


Update episode 3 to the terra package

The episode 3 is still using raster and rgdal package and not the newest terra package.
We need to update the episode to the newest functions from terra. The parameters and default behavior being different we need to be careful to make sure we keep the episode story intact while mentioning there is another way to do certain steps (e.e project will crop to extend automatically if you give a raster as second parameter).

the episode update to terra is done see #c050e87
@jonjab is going to look at the main lesson to see if we could create a PR to send the update back to the main lesson


add-comfyui-tooling-nodes

Hello!
I would love to add  the ComfyUi tooling Nodes to the repo.
Thanks in advance!

@influgenai there's a specific save image node in that ComfyUI Tooling Nodes of type SendImageWebSocket.  It would be nice to support the SendImageWebSocket node so that you don't need to write image files to disk and then read from them before returning a response.  Have you tried that node as well and does it work already, or do you think we'd need to modify this PR to be able to handle image data directly in the outputs (instead of handling file names) when using that node?

Thank you for adding this 🙏

@ctscoville As you suspected, the Send Image (WebSocket) node does not work when using this directly – the model currently returns any files that are in the outputs directory, as this doesn't write any files, nothing gets returned.
A follow-up PR is needed to support Send Image (WebSocket).


order accidents by their location on the road-fixed #1536

@galrou we discussed this pr. Whenever you're ready updated this one or open a new one.

@galrou closing this one for now, let me know if to reopen.


Make Candles possible to beat

I'm currently testing out the music and I saw that I couldn't beat candles on Medium and Hard. My suggestion is to either increase the length of the last platform (in circled red), or to make the goal higher (also in circled red) as seen below
.
Another solution is to just increase gravity (which I don't think you want).
The good news is that I've found a bug in the gravity where it wasn't consistent because I cancelled out the difficulty factor by dividing it, and then multiplying it (💀 oops).

Even though I said there wouldn't be anymore changes to the physics, would it be ok if I changed this? (it would mean more consistency across the difficulties 👍)

@shoc71

working on it and finished it. It will be in the new patch, ltr today


ASIHTTPRequest synchronous request with stub never ends

I don't know is it still in your list of priorities, but I found out that your library does not want to work with ASIHTTPRequest correctly. My AFNetworking requests finished successfully, but ASIHTTPRequest request that starts synchronously never leaves this loop (ASIHTTPRequest:765, method -startSynchronous):
if (![self isCancelled] && ![self complete]) {
	[self main];
	while (!complete) {
		[[NSRunLoop currentRunLoop] runMode:[self runLoopMode] beforeDate:[NSDate distantFuture]];
	}
}

After Nocilla calls -requestFinished this local variable (complete) stays the same.

[NSDate distantFuture] is going to cause this code to wait indefinitely and never check your complete variable. Change this to something like [NSDate dateWithTimeIntervalSinceNow:1.0] and see if that helps.
If you still see issues, provide sample code so that we can test/reproduce ourselves and look into it.


costcla.model is not working with latest version of sklearn

sir,
I want to use costcla library on my datasets as I am importing  from costcla import models I am facing error that no module of sklearn.cross_validation. As it present in sklearn.model_selection. please help me to uses this package on my datasets

The code repository has been updated to work with sklearn.model_selection but it has not been pushed to pypi . To use the code :

Clone the repository to your local environment .
cd CostSensitiveClassification
pip install .

You should be able to use the latest version of the code . A few minor changes may be required to make to tutorial notebook work .

You need to change the sentense in Anaconda3\Lib\site-packages\costcla-0.5-py3.7.egg\costcla\models, open cost_ensemble.py. Then change [from sklearn.cross_validation import train_test_split] to [sklearn.model_selection import train_test_split]

Done. Sorry for the delay


docs: fix invalid operation references in example snippets

title: Fix invalid operation references in example snippets

Related issue(s):
#619
Replaces invalid example snippets with valid ones. I decided to no longer include the message in the channel and parameter object section because I felt like it didn't add much to the understanding. But if you prefer, let me know and I add them as in the intro section.

Hi @fmvilas, @smoya, is there currently anything needed from my side to advance this PR? This is my first contribution to the repo so I'm not 100% sure about the processes in place.

@all-contributors please add @balogal for doc and bug


[6.0][Concurrency] Move innermost record assertion to handle more gracefully

Description: Removes an assertion that was triggering in lsp usage on linux yet is actually too aggressive - we do not need to assert on this and can just return early as the code does now.
Scope/Impact: Low, relaxes assertion
Risk: Low, relaxing too aggressive assertion.
Testing: This has been validated over the last week in sourcekit lsp where it used to be hit. No other concurrency issues were caused by this removal.
Reviewed by: @rjmccall @ahoppen
Original PR: https://github.com/apple/swift/pull/73935
Radar: rdar://128547676

@swift-ci please test


Change of the blending Skeleton3D bone rotations from 3.x makes confuse

Godot version
4.0 alpha 5
System information
Win10, GLES3, RTX 2070 mobile
Issue description
When adding animations in animation blend tree (via Add2/Add3 node) some bones rotate incorrectly and end up in weird positions after the animation is fully added.
Watch this vid. I am adding a back crawl animation to a forward crawl. In both, the legs should be trailing behind the torso, yet the right leg is twisting oddly as if it was either unaffected by the Add operation, or incorrectly affected.
I was able to replicate this issue with different animation Adds and a different bone is affected by this issue each time
https://user-images.githubusercontent.com/82995330/160230168-773f96df-f77d-4676-b8ca-7a0721c94a57.mp4
.
Steps to reproduce
Start a 3d scene
Import a Mixamo (or other) skleleton with at least 2 animations
add a AnimationTree
create new AnimationNodeBlendTree
add a Add2 and connect the 2 animations
slide the add amount to see smooth adding
Minimal reproduction project
No response

NodeAdd had been working strangely since 3.x to begin with and made confusion #37661. Now that the blending algorithm has changed in 4.0, I think it needs to be corrected correctly.

@macryc By the way, do you have a comparison video with 3.x? To begin with, 4.0 includes rest in the pose, so additive animation must be extracted by some means. (Ref: https://github.com/godotengine/godot-proposals/issues/2700)
In other words, the 4.0 add will apply rest twice if the same animation as in 3.x is used without modification.

@macryc By the way, do you have a comparison video with 3.x? To begin with, 4.0 includes rest in the pose, so additive animation must be extracted by some means. (Ref: godotengine/godot-proposals#2700) In other words, the 4.0 NodeAdd will apply rest twice if the same animation as in 3.x is used without modification. So the above video looks like a bug but may be the correct behavior...

This issue was introduced in Godot 4 alpha 5. It didn't exist in alpha 4. So it's not a Godot 3.x vs Godot 4 thing. Rather, it looks like it could have been introduced unintentionally while fixing the root bone bug?

For comparison, this is the exact same scene in Godot 4 alpha 4. Works fine here.
https://user-images.githubusercontent.com/82995330/160231497-f72fb17d-bc3f-4ab0-bdb9-aefb73ef71a4.mp4

@macryc The blend method changed in alpha 5 should probably add animations with NodeAdd correctly. As we have added in the past with https://github.com/godotengine/godot/issues/37661#issuecomment-615510819 and https://github.com/godotengine/godot/pull/34134#issuecomment-763752698, they will add correctly if the inconsistencies in the blend order are removed.
In other words, in the previous inconsistent blends, NodeAdd and NodeBlend behaved almost identically.

You can see from the vids that the issue is affecting one bone. It affects different bones with each Add - it's difficult to see a pattern here. It's inconsistent and results in unpredictable behavior which makes Add operations quite unusable, at least for skeletons.

It is obvious. I say again, in order to perform correct addition in Godot 4, one must at least extract the additive animation https://github.com/godotengine/godot-proposals/issues/2700. However, the ability to extract additive animation has not yet been implemented, so after it is added, the behavior of NodeAdd must be normalized. (In Godot 3, all animations were implicitly imported as Additive Animations.)

Alright, thanks.
I think the issue is obvious by now but just in case, here's another occurrence. This one shows the issue more clearly, I think. Adding (blending, in this case, but the root cause is the same) an aiming animation to a walking_with_rifle animation. The left forearm bone rotates at the root as opposed to simply blend into the aiming animation:
https://user-images.githubusercontent.com/82995330/160235996-054096c4-73b3-4445-9a6a-c3efa5a2982d.mp4

~It is obvious. I say again, in order to perform correct addition in Godot 4, at first, one must at least extract the additive animation godotengine/godot-proposals#2700. However, the ability to extract additive animation has not yet been implemented, so after it is added, the behavior of NodeAdd should be fixed. (In Godot 3, all animations were implicitly imported as Additive Animations.)~
Sorry, I correct my misunderstand above, for Additive Animation it was extracted by init_lot/rot/scl in BlendTree. However, I just tested it and it was adding correctly in my environment.
2022-03-<IP_ADDRESS>.mov
@macryc Can you send a sample project of a broken case?

I will post it in a bit. But clearly, in your vid at 0:08 the hands are gone completely awry when adding the running anim...

@macryc Please make sure it is not due to the optimizer, just to be sure. If one of the animation tracks is missing, the animation will be blended with the rest.

4_alfa4_FPS - add issue.zip
here's the project. Go to 'crawler' scene, open the animation tree and slide the Add2 node called 'problem'.

@macryc I tested the sample project and the animations definitely seemed to add animations correctly.
The behavior of NodeAdd is like rotating an elbow 90deg and then rotating the elbow another 90deg. The correct behavior is that when large animations are added to each other, the bones may break.

I understand it's behaving as intended, but my point is that the intention is incorrect for many reasons:

you can't expect users to only be blending/adding simple animations
sequential adding/blending as you described will always result in unwanted/unpredicted bone positions, like in my aiming example where the end state seems to be correct but on they way to that end state there is unwanted elbow rotation occurring (and this is a very simple blend)

So what are the plans? Is this going to be addressed?

@macryc The problem with your uploaded arms appears to be simply a quaternion interpolation problem. Is that not complemented by the shortest distance? Can you send a sample project?

@macryc The problem with your uploaded arms video seems to be simply a quaternion interpolation problem. Is that not complemented by the shortest distance? Can you send a sample project?

OK but how do I solve this 'quaternion interpolation problem'? As you can see in the vid I'm simply blending 2 animations.
I will try and extract this but the project (and my animation tree) is massive...

@macryc AnimationBlend is not allowed to rotate more than 180 degrees with reference to rest. Please make sure that there is no unreasonable rotation of the elbow.

you can't expect users to only be blending/adding simple animations

Need to explain actual use cases for approving. Animation blending and addition are based on pure mathematics and nothing more. There are plans for retargeting and IK improvements in the meantime, but AnimationTree will have little to no further role in that.

Here's the player scene. It's obviously not built for sharing so you will see the anim tree is a bit messy.
Find the Blendnode called 'gun righclick aiminig' and scroll the slider to see how the left elbow rotates all over the place before it reaches the correct position. This should be a smooth blend.
ThePlayer_extract.zip
.

@macryc I can't open it and determine the cause since it only contains tscn. But I think probably there is a problem with the T-pose and the actual bones that are being rotated.

ISSUE DEMO.zip
Sorry forgot to add the animations. Try this.
Btw, why would the Tpose suddenly be a problem? It's a Mixamo import.

Need to explain actual use cases for approving. Animation blending and addition are based on pure mathematics and nothing more. There are plans for retargeting and IK improvements in the meantime, but AnimationTree will have little to no further role in that.

On this. One huge use case is mocap animations like Mixamo. Most 3d games made in Godot use them. If we can't add/blend those imported anims in Godot then that will be a deal breaker for the community. So the math behind add/blend will definitely need to be improved.

@macryc Your model's rest is not T-pose.

Disable AnimationTree, play the t-pose and click "apply all poses to rest," then clear the AnimationTree cache (restarting Godot is a sure way to do this) and try blending again.
https://user-images.githubusercontent.com/61938263/160242886-88f493a0-1888-4ee3-a48d-d0de1cf47d93.mov
ISSUE DEMO_fixed.zip
As I have said many times before, the rotation of the blend is based on rest, so the model needs to be imported in a pose that is as close as possible to the middle of the range of motion for all joints https://github.com/godotengine/godot/pull/57675#issuecomment-1037668326. This is similar to the reason Unity's Humanoid does bike poses. This is not a reason why motion capture data cannot be used, as it only sets the correct model rest. And that is the role of the importer, not BlendTree's role.

@Zireael07 The animation team plans to implement a T-poser as a post-process importer. However, I agree with you that we need to detect the pose closest to the T-pose/Apose before we can force the T-pose to be generated.
cc @fire @lyuma @SaracenOne

In other words, the 4.0 NodeAdd will apply rest twice if the same animation as in 3.x is used without modification. So the above video looks like a bug but may be the correct behavior...

@TokageItLab can you explain this a little more? Does this mean that 4.0 additive animation adds its rotations on top of the base animation's current rotation? Trying to understand what's initial vs. rest pose (i believe this is the bone's pose in Tpose) and pose (actual current pose vs. rest pose). And what's actually being added and to what...?

@macryc I was misunderstood about that and have already corrected it here. https://github.com/godotengine/godot/issues/59536#issuecomment-1079658125
However, if your model does not have a rest (a model where all bones meet at the origin with InitPose), the base pose will be added twice. In short, the difference from InitPose will be added.

@TokageItLab What I'm trying to understand is the difference between a bone's initial pose and rest pose.
I thought that initpose was simply a pose without rotations (quat(0,0,0,1)) and rest pose was te pose as per the model's T-pose (which is almost always rotated ve. initpose).
Is this correct?

@macryc I mean InitPose is one of the functions that can be selected from the viewport options when the Skeleton is selected.

Using it, all bones of the model will be rest pose, and NodeAdd will add the differences from the rest pose to each other.›


Update CSS to version 7

Here is a small set of changes to update the CSS version to 7, and to adjust the use of it in code and fix the unit tests. The new configuration has been tested to work when serving the generated dataset and only doing reading (since locking is still disabled, as it was previously).
If there is anything that could or should be changed, I can do that.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
116

Relevant Lines:
116

💛  - Coveralls

Thanks! Remind me to merge this one once the fragmenter stuff is ready :-)

This is ready to be merged on its own, I think it would make for a cleaner commit history than adding everything else also in this same PR. Would that be okay?

Thanks!


🐛 [performance] iOS crash app when HttpMetric stops

Bug report
Describe the bug
I have updated performance to the latest version (from 0.7.1+4 to 0.8.0+2) and now when measuring an HTTPRequest the app crash on iOS (emulator and real device) and not on Android.
Steps to reproduce
Steps to reproduce the behavior:
n/a
Expected behavior
n/a
Sample project
n/a
Additional context
Real device crash trace:
-[NSNull length]: unrecognized selector sent to instance 0x1dbf8c558
*** Terminating app due to uncaught exception 'NSInvalidArgumentException', reason: '-[NSNull length]: unrecognized selector sent to instance 0x1dbf8c558'
*** First throw call stack:
(0x18182504c 0x199e99f54 0x181902014 0x1817ba474 0x1817b95b0 0x181facbfc 0x181faa784 0x181fe7a94 0x18203699c 0x1046560a0 0x10314b450 0x10314b0bc 0x10314ac00 0x10763195c 0x107182130 0x1074feafc 0x10742c214 0x10742ff6c 0x18183a268 0x1817bec40 0x1817b943c 0x181797c58 0x1817ab3b8 0x19d13b38c 0x18414b6a8 0x183eca7f4 0x102a4cbdc 0x103fd5a24)
libc++abi: terminating with uncaught exception of type NSException
* thread #1, queue = 'com.apple.main-thread', stop reason = signal SIGABRT
    frame #0: 0x00000001b866c964 libsystem_kernel.dylib`__pthread_kill + 8
libsystem_kernel.dylib`__pthread_kill:
->  0x1b866c964 <+8>:  b.lo   0x1b866c984               ; <+40>
    0x1b866c968 <+12>: pacibsp
    0x1b866c96c <+16>: stp    x29, x30, [sp, #-0x10]!
    0x1b866c970 <+20>: mov    x29, sp

Emulator crash trace:
Application Specific Information:
dyld4 config: DYLD_ROOT_PATH=/Applications/Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform/Library/Developer/CoreSimulator/Profiles/Runtimes/iOS.simruntime/Contents/Resources/RuntimeRoot
CoreSimulator 776.4 - Device: iPhone 13 Pro Max (********-****-****-****-************) - Runtime: iOS 15.0 (19A339) - DeviceType: iPhone 13 Pro Max
terminating with uncaught exception of type NSException
*** Terminating app due to uncaught exception 'NSInvalidArgumentException', reason: '-[NSNull length]: unrecognized selector sent to instance 0x7fff8a349fb0'
dyld4 config: DYLD_ROOT_PATH=/Applications/Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform/Library/Developer/CoreSimulator/Profiles/Runtimes/iOS.simruntime/Contents/Resources/RuntimeRoot
abort() called

Last Exception Backtrace:
0   CoreFoundation                	    0x7fff203fbba4 __exceptionPreprocess + 226
1   libobjc.A.dylib               	    0x7fff2019ebe7 objc_exception_throw + 48
2   CoreFoundation                	    0x7fff2040a821 +[NSObject(NSObject) instanceMethodSignatureForSelector:] + 0
3   CoreFoundation                	    0x7fff204000bc ___forwarding___ + 1433
4   CoreFoundation                	    0x7fff204021e8 _CF_forwarding_prep_0 + 120
5   CFNetwork                     	    0x7fff23f9a87e 0x7fff23dad000 + 2021502
6   CFNetwork                     	    0x7fff23e834e7 0x7fff23dad000 + 877799
7   CFNetwork                     	    0x7fff23e83840 0x7fff23dad000 + 878656
8   CFNetwork                     	    0x7fff23dc56de 0x7fff23dad000 + 100062
9   FirebasePerformance           	       0x105c8f38e -[FIRHTTPMetric stop] + 750 (FIRHTTPMetric.m:129)
10  Runner                        	       0x10476ec42 -[FLTHttpMetric stop:result:] + 802
11  Runner                        	       0x10476e86a -[FLTHttpMetric handleMethodCall:result:] + 282
12  Runner                        	       0x10476e364 -[FLTFirebasePerformancePlugin handleMethodCall:result:] + 436
13  Flutter                       	       0x108fbd8a1 __45-[FlutterMethodChannel setMethodCallHandler:]_block_invoke + 104
14  Flutter                       	       0x108a66c4d flutter::PlatformMessageRouter::HandlePlatformMessage(std::__1::unique_ptr<flutter::PlatformMessage, std::__1::default_delete<flutter::PlatformMessage> >) const + 193
15  Flutter                       	       0x108a6c307 flutter::PlatformViewIOS::HandlePlatformMessage(std::__1::unique_ptr<flutter::PlatformMessage, std::__1::default_delete<flutter::PlatformMessage> >) + 35
16  Flutter                       	       0x108e976c9 std::__1::__function::__func<fml::internal::CopyableLambda<flutter::Shell::OnEngineHandlePlatformMessage(std::__1::unique_ptr<flutter::PlatformMessage, std::__1::default_delete<flutter::PlatformMessage> >)::$_16>, std::__1::allocator<fml::internal::CopyableLambda<flutter::Shell::OnEngineHandlePlatformMessage(std::__1::unique_ptr<flutter::PlatformMessage, std::__1::default_delete<flutter::PlatformMessage> >)::$_16> >, void ()>::operator()() + 81
17  Flutter                       	       0x108d9c866 fml::MessageLoopImpl::FlushTasks(fml::FlushType) + 164
18  Flutter                       	       0x108da2d18 fml::MessageLoopDarwin::OnTimerFire(__CFRunLoopTimer*, fml::MessageLoopDarwin*) + 26
19  CoreFoundation                	    0x7fff2036a6c6 __CFRUNLOOP_IS_CALLING_OUT_TO_A_TIMER_CALLBACK_FUNCTION__ + 20
20  CoreFoundation                	    0x7fff2036a1c2 __CFRunLoopDoTimer + 923
21  CoreFoundation                	    0x7fff20369781 __CFRunLoopDoTimers + 265
22  CoreFoundation                	    0x7fff20363dc0 __CFRunLoopRun + 2010
23  CoreFoundation                	    0x7fff20363103 CFRunLoopRunSpecific + 567
24  GraphicsServices              	    0x7fff2c851cd3 GSEventRunModal + 139
25  UIKitCore                     	    0x7fff24ffbe63 -[UIApplication _run] + 928
26  UIKitCore                     	    0x7fff25000a53 UIApplicationMain + 101
27  Runner                        	       0x10405053f main + 63 (AppDelegate.swift:6)
28  dyld_sim                      	       0x105463e1e start_sim + 10
29  dyld                          	       0x105e234fe start + 462
30  ???                           	               0x0 ???
31  Runner                        	       0x10404a000 ???

Flutter doctor
Run flutter doctor and paste the output below:
Click To Expand
[✓] Flutter (Channel stable, 2.8.0, on macOS 12.0.1 21A559 darwin-x64, locale es-ES)
[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.3)
[✓] Xcode - develop for iOS and macOS (Xcode 13.1)
[✓] Chrome - develop for the web
[✓] Android Studio (version 2020.3)
[☠] IntelliJ IDEA Ultimate Edition (the doctor check crashed)
    ✗ Due to an error, the doctor check did not complete. If the error message below is not helpful, please let us know about this issue at https://github.com/flutter/flutter/issues.
    ✗ FormatException: Unexpected extension byte (at offset 5)
[✓] VS Code (version 1.62.3)
[✓] Connected device (3 available)
    ! Error: iPhone is busy: Making the device ready for development. Xcode will continue when iPhone is finished. (code -10)

! Doctor found issues in 1 category.

Flutter dependencies
Run flutter pub deps -- --style=compact and paste the output below:
Click To Expand
Dart SDK 2.15.0
Flutter SDK 2.8.0
agrarware 1.2.0+16

dependencies:
- badges 2.0.2 [flutter]
- cached_network_image 3.2.0 [flutter flutter_cache_manager octo_image cached_network_image_platform_interface cached_network_image_web]
- camera 0.9.4+5 [camera_platform_interface camera_web flutter pedantic quiver flutter_plugin_android_lifecycle]
- chopper 4.0.3 [http meta logging]
- cupertino_icons 1.0.4
- device_info_plus 3.1.1 [flutter device_info_plus_platform_interface device_info_plus_linux device_info_plus_macos device_info_plus_web device_info_plus_windows]
- file_picker 4.2.7 [flutter flutter_web_plugins flutter_plugin_android_lifecycle plugin_platform_interface ffi path]
- firebase_analytics 9.0.2 [firebase_analytics_platform_interface firebase_analytics_web firebase_core firebase_core_platform_interface flutter]
- firebase_core 1.10.5 [firebase_core_platform_interface firebase_core_web flutter meta]
- firebase_crashlytics 2.4.3 [firebase_core firebase_core_platform_interface firebase_crashlytics_platform_interface flutter stack_trace]
- firebase_messaging 11.2.3 [firebase_core firebase_core_platform_interface firebase_messaging_platform_interface firebase_messaging_web flutter meta]
- firebase_performance 0.8.0+2 [firebase_core firebase_core_platform_interface firebase_performance_platform_interface firebase_performance_web flutter]
- flutter 0.0.0 [characters collection meta typed_data vector_math sky_engine]
- flutter_app_badger 1.3.0 [flutter]
- flutter_cache_manager 3.3.0 [clock collection file flutter http path path_provider pedantic rxdart sqflite uuid]
- flutter_image_compress 1.1.0 [flutter]
- flutter_local_notifications 9.1.5 [clock flutter flutter_local_notifications_linux flutter_local_notifications_platform_interface timezone]
- flutter_localizations 0.0.0 [flutter intl characters clock collection meta path typed_data vector_math]
- flutter_platform_widgets 1.11.1 [flutter]
- flutter_secure_storage 5.0.2 [meta flutter flutter_secure_storage_linux flutter_secure_storage_macos flutter_secure_storage_platform_interface flutter_secure_storage_web flutter_secure_storage_windows]
- flutter_speed_dial 4.6.6 [flutter]
- flutter_webview_plugin 0.4.0 [flutter]
- font_awesome_flutter 9.2.0 [flutter]
- fuzzy 0.4.0-nullsafety.0 [latinize]
- get_it 7.2.0 [async collection]
- google_maps_flutter 2.1.1 [flutter flutter_plugin_android_lifecycle google_maps_flutter_platform_interface]
- image_cropper 1.4.1 [flutter]
- image_picker 0.8.4+4 [flutter flutter_plugin_android_lifecycle image_picker_for_web image_picker_platform_interface]
- infinite_scroll_pagination 3.1.0 [flutter sliver_tools]
- intl 0.17.0 [clock path]
- json_annotation 4.4.0 [meta]
- location 4.3.0 [flutter location_platform_interface location_web]
- logging 1.0.2
- native_pdf_view 5.0.0 [flutter photo_view synchronized native_pdf_renderer]
- nfc_manager 3.1.0 [flutter]
- open_file 3.2.1 [flutter ffi]
- package_info_plus 1.3.0 [flutter package_info_plus_platform_interface package_info_plus_linux package_info_plus_macos package_info_plus_windows package_info_plus_web]
- path_provider 2.0.7 [flutter path_provider_android path_provider_ios path_provider_linux path_provider_macos path_provider_platform_interface path_provider_windows]
- permission_handler 8.3.0 [flutter meta permission_handler_platform_interface]
- photo_view 0.13.0 [flutter]
- rxdart 0.27.3
- share_plus 3.0.4 [meta mime flutter share_plus_platform_interface share_plus_linux share_plus_macos share_plus_windows share_plus_web]
- shared_preferences 2.0.9 [flutter meta shared_preferences_android shared_preferences_ios shared_preferences_linux shared_preferences_macos shared_preferences_platform_interface shared_preferences_web shared_preferences_windows]
- timelines 0.1.0 [flutter]
- url_launcher 6.0.17 [flutter meta url_launcher_android url_launcher_ios url_launcher_linux url_launcher_macos url_launcher_platform_interface url_launcher_web url_launcher_windows]
- webview_flutter 3.0.0 [flutter webview_flutter_android webview_flutter_platform_interface webview_flutter_wkwebview]

dev dependencies:
- build_runner 2.1.5 [args async analyzer build build_config build_daemon build_resolvers build_runner_core code_builder collection crypto dart_style frontend_server_client glob graphs http_multi_server io js logging meta mime package_config path pool pub_semver pubspec_parse shelf shelf_web_socket stack_trace stream_transform timing watcher web_socket_channel yaml]
- chopper_generator 4.0.3 [analyzer build built_collection chopper code_builder dart_style logging meta source_gen]
- flutter_launcher_icons 0.9.2 [args image path yaml]
- flutter_lints 1.0.4 [lints]
- flutter_native_splash 1.3.2 [args image meta path xml yaml universal_io]
- flutter_test 0.0.0 [flutter test_api path fake_async clock stack_trace vector_math async boolean_selector characters charcode collection matcher meta source_span stream_channel string_scanner term_glyph typed_data]
- json_serializable 6.1.1 [analyzer async build build_config collection json_annotation meta path pub_semver pubspec_parse source_gen source_helper]
- pigeon 1.0.12 [analyzer args collection meta path]

@CarlosVallsCiscar
Is this coming from production or from debug mode ?
Is it possible for you to provide a minimal complete reproducible code sample that we can use to verify this behavior ?

@CarlosVallsCiscar
Is this coming from production or from debug mode ?
Is it possible for you to provide a minimal complete reproducible code sample that we can use to verify this behavior ?

It is from debug mode.
I create a minimal project with the same bug.
Project

Hi @CarlosVallsCiscar, I would double check these [values] (https://github.com/CarlosVallsCiscar/firebase_perf_crash/blob/master/lib/custom_client.dart#L20-L22) aren't null or invalid before setting.

Hi @CarlosVallsCiscar, I would double check these [values] (https://github.com/CarlosVallsCiscar/firebase_perf_crash/blob/master/lib/custom_client.dart#L20-L22) aren't null or invalid before setting.

I have checked those values before setting and now it no longer crash.
responseContentType field was the one that produced the error, but is it defined as a string? and I think it shouldn't crash if I pass it a null value. I close the issue.

Sorry to reopen but I'm still having issues with HttpMetric.
I have been reviewing the code in Objective-C and in this class FLTHttpMetric.m the null is checked with != nil, but if i put a breakpoint, if I don't put for example responsePayloadSize what it receives from the arguments is an NSNull. I have not worked with Objective-C but I have searched a bit I have understood that NSNull != nil because NSNull is an instantiated object so this check is always true if I don't pass those optional values.

I'm experiencing the same issue when using HTTpMetric. ios crash after calling metric.stop()
I use 0.8.0+2

/cc @russellwheatley

This was fixed in #7593 - pending release

Released in firebase_performance v0.8.0+3 - thanks


Fix Xcode Analyser warnings and deprecations

Hey guys,
this PR basically resolves all common deprecation- and Xcode Analyser-warnings. Some notes:

Some of them have been surrounded by the -Wdeprecated-declarations flag, since there is no replacement for the methods available. So I followed the the existing way like done in the RCTModuleData for those cases
I added the __unused flag to mute the unused-warnings in certain parameter lists. This was also done in some other classes as well, so this one unifies the way for all current API's
I migrated some methods that have been deprecated (e.g. UIActivityViewController's completionHandler method)

One note: I left the NSStringArray deprecation for now, since the migration should be done in an own PR, since it effects common type conversions across the project.
Thanks! 🚀

2/4 travis builds fail due to unrelated errors. May need to re-trigger those.

I just fixed a comment typo which will also trigger the CI to re-run. This looks good to me so if/when CI gives the thumbs-up I will land it.

It keeps failing. Unfortunately, I don't have travis access to this project so you might need to retrigger it yourself.

Ah, dang it. So I went on vacation a couple days after your last comment, lost track of this PR, and now there are conflicts. Would you mind resolving those @hansemannn ?

@hansemannn Could you resolve conflicts?

@hansemannn Sorry for late reply. 😭 Could you please rebase the diff on lastest master and resolve conflicts?


Add emailSANs field to Certificate resource

Is your feature request related to a problem? Please describe.
First off: Thanks for this awesome controller!
We are using Vault to issue client certificates for mTLS and these client certificates normally just contain an RFC822 (email) SAN and no real dns name. When using the Vault Issuer and putting any email Address in the commonName or DNSNames Field, Vault automatically recognizes the email SAN and creates a correct certificate (containing an RFC822 SAN).
The issue is that cert-manger wrongly asserts that this certificate does not match the spec. The issue is that in sync.go certificateMatchesSpec compares the DNSNames from the Spec with golangs x509 cert.DNSNames.
In general it is at the discretion of the CA to pick SANs and extensions so any external validation is bound to fail in corner cases like these. Hashicorp Vault got rid of a lot of checking code while issuing certificates and relies on either golangs x509 package or on client certificate validation (We had problems with x509v3 NameConstraints before)
Describe the solution you'd like
Either change the check certificateMatchesSpec to also compare with cert.EMailAddresses
OR
Add a EMailAddresses (and URIAddresses) to the certificate spec. The latter are pretty uncommon although they are becoming more and more popular (look at SPIFFE / SPIRE)
Describe alternatives you've considered
I don't see any big alternatives apart from writing stuff on our own to issue these certificates on our own...
Maybe selectively disabling the checks would in general be a good idea to cover corner cases...
Additional context
Example certificate
apiVersion: certmanager.k8s.io/v1alpha1
kind: Certificate
metadata:
  name: example-com
  namespace: default
spec:
  secretName: example-com-tls
  issuerRef:
    name: vault-issuer
    kind: ClusterIssuer
  duration: 72h
  renewBefore: 48h
  commonName<EMAIL_ADDRESS>  dnsNames: []

Environment details (if applicable):

Kubernetes version:. v1.11.3
Cloud-provider/provisioner : GKE
cert-manager version 0.6.0
Install method: helm

/kind feature

@munnerz is there anything I can do to move this forward? I'd happily write more unit tests or try to get the e2e tests running if the changes are ok in a general sense. Great talk at KubeCon btw...

Hey 👋 sorry for the delayed response here - I definitely think we want to support this on the Certificate resource. It can be added in a similar manner to the new certificate.spec.uriSANs field.
That said, I don't think we should automatically promote email addresses specified in the commonName field to be an emailSAN, as we ran into issues in the past when doing this with dnsNames.
Would you be interested in picking up the implementation of this still? Our next feature release (v0.12) is scheduled for around the 14th November 😄

/remove-lifecycle stale


Support SegWit

Support SegWit.
merged from https://github.com/theuni/btcpool/commit/f014154eaecb6821cf8e27f499c15cd09a10dfdb

Advertise support for the segwit rule
Grab default_witness_commitment from gbt
Insert default_witness_commitment as 2nd txout

TODO:

Skip insertion if default_witness_commitment doesn't exist done by https://github.com/btccom/btcpool/pull/9/commits/fa8891f7c85171c4933a888b39f5469b86b65b1d
Verify that merkles are being built without witness data

Nice!
Is it possible to test this on testnet? I was not able to reliably test my patches, as I'm not familiar enough with btcpool to know how to troubleshoot. So they were written completely blindly.
It would be great to test 3 things here:

Mine a block on testnet that contains witness transactions
Mine a block on mainnet to make sure that nothing broke
Add a test in TestStratum.cc for a block that contains witness data. This will mean that hash != txid.

For 1 and 2, I recommend using a bitcoind patched with https://github.com/bitcoin/bitcoin/pull/9000. You can then start bitcoind using (for example) ./bitcoind -forceminerdifficulty=493944831
That will allow testing on any net (testnet or mainnet), except that forces bitcoind to "lie" about the difficulty, so that it can be set very low. In this mode, when blocks are submitted, they're simply tested (ignoring the fact that the difficulty is too low), then thrown away. No changes to mining software are necessary.

we have mined several segwit blocks on testnet3 which contains witness txs, one of blocks:
{
  "hash": "000000000000000a99bc67d90e283e0730e0db0a6d353bfa9aac1c4c479a26e3",
  "confirmations": 1,
  "strippedsize": 5379,
  "size": 5525,
  "weight": 21662,
  "height": 1064002,
  "version": 536870912,
  "versionHex": "20000000",
  "merkleroot": "af38f5f89e0e7fd8511cf6d34409454ba626d30b7e84801524e36f7e911618aa",
  "tx": [
    "33e1aa548a13f7f7df3422189c4021dcdfa5c81eb6189f03bc066b1e4221a840",
    "2cda3f2e07973e3f1464cc2c2ce9a71ec2cb95e436b702d615cacf4116facd7a",
    "f47d989085cee4e6bfe2f33672958cb8db7412f338bfeb86510b291c0ff2de8d",
    "6b358554265fb49ba23ad1bff5b9b12cb24450e852e16503902260fdc514a7da",
    "913dcb0aad24ce3dffb2ddc20bafe80b57a6afb4853483c491c8deeb1e818a40",
    "1547fbe0cd90a8e2e6c3307a0065dd9909fdae8665f4a0e806f1c798972a08ab",
    "905950ff1956eed8dd73e58c48513f4667155174c1cc09a2df1968251ee218bd",
    "2cf35b39190dce539c08aa050802b53dadfa3b936ad0ea988ac028f6bb447b92",
    "1575711428614e85251f3778ccc5d499d86a275765cab654375d5235fd7880a1",
    "2dd16cb412cb593b46c005a4819a9e8c8c0976a969ad5f8dd0a0efa5087644fd",
    "960e04ed1d785d26ef54aded3197f1b123d162aae39f4fe67ef547a84ea8aa76",
    "9d6ce01035b5c41988dd5bee812359f9c1b6683b6fe48fdf73762c537625fb7f",
    "1241e0d89ef7ddb4f2dd5eca59d766b4d934a54ec4a985828f35fe0e1699019e",
    "13089dc41621e7b78983d54d48d809565498570eeff6849782bc2800371393ab",
    "dc5e802ba9248833e43c175ac2511298545fddffdb87a6d160571386fd05e989"
  ],
  "time":<PHONE_NUMBER>,
  "mediantime":<PHONE_NUMBER>,
  "nonce": 691739001,
  "bits": "1a037666",
  "difficulty": 4845339.949056488,
  "chainwork": "00000000000000000000000000000000000000000000001d9de6013746d22014",
  "previousblockhash": "000000000000000e2afb810d01bb60d9c3bd3c1395d311b39c66f42a16f47acb"
}

Add a gist: how to create witness transaction, maybe could help someone when trying to make witness txs on testnet3.
tested on v0.13.1 and v0.13.2.

we have mined two blocks on mainnet which coinbase tx contains the witness commitment:
https://btc.com/0000000000000000022ffa9ed3046230b31a13f57faa5e7bb5bba653b5b6626b
https://btc.com/0000000000000000028a507cb15ef64f8b1a054dfd63ba316076a3e1392f32bb


Define configuration format

Right now the configuration file's format is a weird JSON variation with // comments, at least as I understand it.
It'd be nice if we, instead, used a more config-friendly format (such as TOML or even YAML) that allowed for things like comments. Moreover, it'd be useful if the file was called config.json or config.toml so that editors can pick-up the filetype automatically.
I'll leave a link to an article I enjoy on why JSON is a poor choice for a configuration language: https://www.lucidchart.com/techblog/2018/07/16/why-json-isnt-a-good-configuration-language/

That would mean breaking the compatibility with all installs of waybar. The user-base might be small, but this still would cause a lot of troubles.

@cafehaine Not necessarily, the old config could remain, but be removed from wiki/readme and leave alongside the TOML one for some time. If you load the old config format it works with a deprecation warning.
A breaking change nonetheless, but with a nice adaption period.

The great thing about yaml is that you can actually use a yaml parser to parse json. So that would kind of ensure backwards compatibility with older configs, the only problem being the // comments.
A dirty way to convert old config to yaml:
cat ~/.config/waybar/config | sed 's|//.*$||' | yq -y .

(this won't work if you have // in a string somewhere, but you get the idea)

+10 i'm really confused about that choice...

Toml is a bad choice too : https://hitchdev.com/strictyaml/why-not/toml/
Yaml is still the easier and cleaner human readable configuration language and would be a great choice for that kind of project.

@eoli3n Agree to disagree and I'll avoid bikeshedding this :laughing:

FWIW, current format is just "a JSON variation", it's called jsonc, and actually used by plenty of tools. So I wouldn't discredit is as non-standard.

Any news ?

Off the top of my head, nvim-coc uses jsonc, as do flatpak manifests (example). I guess waybar also counts on this list really. There's plenty of libraries for working with jsonc in various languages too.
I'm sure I've seen other applications, but my memory is bad.
Most of these tools use the .json extension, which is a bit annoying since editors are bad at figuring out it's actually jsonc.
I don't think popularity is that important though; it's very easy to explain that jsonc is just "json with comments", and it's not like end users have to learn an entirely new format.
That said, I don't disagree with the initial criticism of JSON. But there's also a lot of valid criticism for YAML (e.g.: type handling). TOML is bad for highly nested structures, or when you have a large set of files that share a schema. For a configuration format like waybars, it's actually not a bad candidate.
Ultimately though, I think this falls into bikeshedding a bit. A PR showing pros and cons of a change is probably best at this point.

I think it's not a matter of criticizing json or jsonc now, but adding support for yaml files is necessary, and the format of yaml is obviously more beautiful

It boggles my mind that I can get syntax highlighting...

It boggles my mind that I can't get syntax highlighting...

May I ask which editor you use? For vim you can use the jsonc syntax highliting by installing vim-polyglot.

+1 for yaml configuration

It boggles my mind that I can't get syntax highlighting...

May I ask which editor you use? For vim you can use the jsonc syntax highliting by installing vim-polyglot.

Did you read this issue thread at all?

I just wanted to ask if we can have a defined schema too, especially in the current JSON config. The schema can be included in with the $schema key (See https://json-schema.org/).


Linking and building on with IOS

I'm receiving this error when linking and building on IOS -
node_modules/react-native-interactable/lib/ios/Interactable/RCTConvert+Interactable.h:10:9: fatal error: 'React/RCTConvert.h' file not found
#import <React/RCTConvert.h>
        ^~~~~~~~~~~~~~~~~~~~
1 error generated.

Same here

Refer #283


[IOTDB-144]meta data cache for query

To increase query speed, metadata needs to be cached, including TsFileMetaData and TsDeviceMetaData.
The files in IOTDB are organized according to time, so the query frequency of different files varies greatly. Cache metadatas of frequently queried files can reduce the time of reading metaData from disk. Besides, all sensors' metadata of a device is in TsDeviceMetaData. In order to read the metadata of a sensor, we need to read the entire TsDeviceMetaData. In the current version, querying multiple sensors in a device simultaneously need to read TsDeviceMetaData multiple times, so consider caching TsDeviceMetaData.

I am going to review it today.

For code polish suggestions:

the creation of TsFileSequenceReader in the four classes of the resourceRelated package can be moved backward to just above the creation of ChunkLoaderImpl since DeviceMetaDataCache.getInstance().get instead of MetadataQuerierByFileImpl is used to prepare metaDataList.
In MetadataQuerierByFileImpl

this.fileMetaData = tsFileReader.readFileMetadata();

maybe can be replace by
this.fileMetaData = TsFileMetaDataCache.getInstance().get(tsFileReader.getFileName);

The method TsFileMetadataUtils.getTsRowGroupBlockMetaData. Since the concept of rowgroup is out of date, why not name it getTsDeviceMetaData?


SideNav problems in version 2022.12.1

Hi,

Sidenav does not move the form to left when click on hamburger v2022.12.1 when running with NG Client. Works fine with TiNG.

Sidenav does not show Menu Icons done with glyphicon when running with TiNG. Works fine with NG Client.

Regards,

2> cannot be fixed those icons are not there anymore you need fontawesome

Fine about the icons, not a problem.
Please take a look to item 1.


Add Cypress test for FAQ link conventions

Current Implementation
The Cypress test suite does not test for FAQ links abiding by the conventions specified in docs/CHANGE_WEBSITE_CONTENT: "Links on FAQ pages".
Related issues / pull requests

https://github.com/corona-warn-app/cwa-website/pull/3030
https://github.com/corona-warn-app/cwa-website/issues/3031
https://github.com/corona-warn-app/cwa-website/pull/3032
https://github.com/corona-warn-app/cwa-website/issues/3034
https://github.com/corona-warn-app/cwa-website/pull/3035

Suggested Enhancement
Implement a Cypress test which checks for conformance with the conventions specified in docs/CHANGE_WEBSITE_CONTENT: "Links on FAQ pages":

The following conventions should be followed for links in the FAQ sources /src/data/faq.json and /src/data/faq_de.json:

All internal and external links on the FAQ pages should use the HTML hyperlink attribute target='_blank' to open in a new frame. This provides a consistent user experience and works around an issue with the browser back arrow button in the FAQ Glossary.
External links should use the HTML hyperlink attribute rel='noopener noreferrer' to avoid a cross-domain security issue in older browsers when the link also contains target='_blank'.
Internal links should not contain the attribute rel='noopener noreferrer'. There is no security issue for internal links.

Examples:

External link: Check EU COVID certificates directly via app
Internal link: Test Certificate

Expected Benefits
An automatically executed Cypress test helps to ensure consistency in the way that FAQ links are formed. This enhances both the user experience and security.

I already prepared this Cypress test in July 2022 before the Open Source Team / Community Management was stopped on August 4, 2022, and I then forgot about it until I noticed some link issues and Community Management was reinstated.
If you would like me to submit this test as a PR, please let me know.

The test will fail until PR https://github.com/corona-warn-app/cwa-website/pull/3157 is merged. The PR fixes incorrect link attributes.

@MikeMcC399 Thanks for the suggestion, very much appreciated. Indeed, we would like to review your PR.

@dsarkar

Thanks for the suggestion, very much appreciated. Indeed, we would like to review your PR.

Thanks in return for your interest! I have submitted PR #3159 to implement this enhancement.

I noticed whilst I was testing this PR that the build and deploy scripts are successful, however they now include deprecation warnings for node 12, so I will submit this as issues.

PR https://github.com/corona-warn-app/cwa-website/pull/3159 is now merged, so this enhancement request has been fulfilled.


TextInput multiline={true} not functioning as expected

Description
TextInput multiline set to true no longer does newline on enter press. just blurs the TextInput instead.
Reproduction
Just change from 0.41.2 to 0.42.0 using the default AutoExpandingTextInput Example from the TextInput Docs to see it happening
Additional Information

React Native version: 0.42.0
Platform: Android ( Possibly iOS havent tested )
Operating System: MacOS

I can reproduce it on Android. But not on iOS.

It blurs on Sony's Swift Keyboard,
but it's working fine when I changed it to Google's GBoard

+1

It blurs on Samsung Galaxy S6 keyboard.
Like @HermantoTang said, it works fine with Google's GBoard or the default keyboard in the Android emulator.

 Google Japanese keyboard does not work. A chinese input method I have also does not work.
Android.

Had the same problem with SwiftKey Keyboard. Following fixed it for me:
#12923

+1

#12923 didn't fix our case. We tried to replace the entire ReactAndroid folder, but in vain.
We had to roll back to 0.41.2
Hope this is fixed in 0.43

@goodhyun have you built ReactNative from source?
https://facebook.github.io/react-native/docs/android-building-from-source.html

+1 on this, we need a fix for this for our app because it affects Samsung.

I have the same issue while using Expo. The Expo SDK 15 brought RN 0.42 and broke my input field.
See #13159.

Sorry @studio3w  I didn't know that I had to rebuild RN again from source.
Even 0.43.1 didn't solve this issue, and I rebuilt 0.43.1 with #12923 fix and it just worked like a charm.
This is a really annoying issue though.

Doesn't work onContentSizeChange event in release 0.43.2

+1

Having same issue. :'(    same version , using expo , swiftkey

+1

Can confirm onContentSizeChange also not working in 43.*

Below working for me, use expo SDK 15, RN 0.42, wrote by Typescript.
https://gist.github.com/BCGen/9ba9f7d96459fd063e42bd53f9839217

+1 Same here for Sony Z5 Compact. Why isn't this fixed yet? I'm a SwiftKey user as well, it seems to affect only those. Native Sony Keyboard works like a charm.

I don't think it's just swift key, I'm using a bog standard emulator and have the issue.

Same here, totally failed on my three android devices, any updating?

Having same issue: pressed enter and got submit triggered not entering a newline.
It works with google english input method, but all Chinese input method failed.
Platform: android 7.1.1
Input Method: Google Chinese Input Method.
RN Version: 0.44.0

any update on this issue?

Same problem

I've solved setting the blurOnSubmit props to false: https://facebook.github.io/react-native/docs/textinput.html#bluronsubmit
<TextInput
	multiline={true}
	numberOfLines={4}
	blurOnSubmit={false}
/>

By default, blurOnSubmit is set to true. So every time you press enter on the keyboard, the TextInput loses focus. If instead you set this property to false, this does not happen and, with enter, go to a new line :+1:

@akajack It doesn't work for me. I tried it.

I submitted a PR https://github.com/facebook/react-native/issues/13890 please try

@kevinluvian How to apply it ? I tried modify it in node_modules then run-android, but doesn't work.

no, you need to recompile from source https://facebook.github.io/react-native/docs/android-building-from-source.html
or you can wait until my PR got merged and install react native as usual

@kevinluvian Thanks

+1 on SwitfKey

my solution:
                 <TextInput
                    multiline={true}
                    blurOnSubmit={false}
                    editable={true}
                    maxLength={40}
                    onChangeText={(txt) => {
                        this.setState({ myText: txt })
                    }}
                    value={this.state.myText}
                    onSubmitEditing={() => {
                        if (!this.state.myText.endsWith("\n")) {
                            let myText = this.state.myText;
                            myText = myText + "\n";
                            this.setState({ myText: myText })
                        }
                    }}
                    />

hope that helps

@renehauck It works, bug very slow...

@renehauck What if I want to add a newline in the middle of the text and not at the end?

@iRoachie you can get the cursor position in the TextInput from onSelectionChange={(event) => this.setState({ cursorPosition: event.nativeEvent.selection.start })} and in onSubmitediting to use something like splice for strings. See example

<TextInput
  multiline
  blurOnSubmit={false}
  onChangeText={(text) => {
    this.setState({ text });
  }}
  value={this.state.text}
  onSelectionChange={(event) => this.setState({ cursorPosition: event.nativeEvent.selection.start })}
  onSubmitEditing={(event) => {
    const { text, cursorPosition } = this.state;
    let newText = text;
    const ar = newText.split('');
    ar.splice(cursorPosition, 0, '\n');
    newText = ar.join('');
    this.setState({ text: newText });
  }}
/>

Yea I tried I already. However the cursor doesn't move to the newline like you'd expect. The cursor stays where it is and the new line is below

@iRoachie
you can set  TextInput selection to cursorPosition.
<TextInput selection={this.state.cursorPosition} />
and after add new line set cursorPosition to next position
const newPosition = this.state.cursorPosition + 1;
setState.({cursorPosition: newPosition});

is this issue solved yet?

any updates? does anyone know where is this issue coming from?

Seems to be fixed in 0.45

Nope. Still no effect on multiline. updated to RN 0.45. Using Samsung Galaxy S6. Works fine in Google Keyboard though.

Same here. Updated and no effect on multiline.

This is a serious issue..not able to publish the app due to this.
@nikolay-radkov tried your code too. works fine but its inserting 2 newlines successively plus cursor remains in the same position when inserting new line from the middle of the text.

@shubhomoy to prevent the 1 newlines, you should debounce the function because some Android's version dispatch it twice. I did:
On constructor:
this.onSubmitEditing = debounce(this._onSubmitEditing, 100, true);

The _onSubmitEditing function:
_onSubmitEditingDescription(event) {
            const { shortProductDescription, cursorPosition } = this.state;

            let newText = shortProductDescription;
            const ar = newText.split('');
            ar.splice(cursorPosition, 0, '\n');
            newText = ar.join('');

            this.setState({ shortProductDescription: newText });
    }

On TextInput: onSubmitEditing={this.onSubmitEditing.bind(this)}
For the position issue, try what @BCGen said above. I didnt yet.

thanks @vendramini for the debounce tip. Did the trick.
As far as the position issue from middle of the text is concerned, I found a dirty trick...
here's my code
In constructor
this.onSubmitEditing = this.onSubmitEditing.bind(this);
Inside class
onSubmitEditing = _.debounce(this._onSubmitEditingNote, 100, true);

_onSubmitEditingNote() {
        const { noteText, cursorPosition } = this.state;
        let newText = noteText;
        const ar = newText.split('');
        ar.splice(cursorPosition.start, 0, '\n');
        newText = ar.join('');
        if(cursorPosition.start === noteText.length) {
        	this.setState({ noteText: newText });
        }else{
        	this.setState({
        		noteText: newText,
        		selection: {
        			start: cursorPosition.start + 1,
        			end: cursorPosition.end + 1
        		}
        	});
        }
    }

In render function
<TextInput multiline = {true}
	blurOnSubmit = {false}
	selection = {this.state.selection}
	onSelectionChange={(event) => this.setState({ cursorPosition: event.nativeEvent.selection, selection: event.nativeEvent.selection })}
	onChangeText = {(text) => {this.setState({noteText: text})}}
	value = {this.state.noteText}
	onSubmitEditing={this.onSubmitEditing} />```

Thanks @shubhomoy for your code. I created a wrapper component out of it for general use in this gist.
Works for me on Samsung without major issues so far. The only thing I noticed: When selecting text somewhere inside and pressing enter, the cursor jumps ahead too much.

Can confirm this issue is still active with swiftkey and latest react-native (0.45.1)

@catchin Thanks for sharing. Your solution works fine on its own, but when combined with the "autogrow" feature illustrated by the official example (https://github.com/facebook/react-native/commit/481f560f64806ba3324cf722d6bf8c3f36ac74a5), things become very buggy.
Have you guys tried to implement both "multiline" and "autogrow" on android?

Why hasn't @studio3w 's fix been merged yet? This is a serious deal-breaker for many scenarios, we better ask proper attention on this.

I really hope this will be fixed in 0.46... confirmed in 0.44.2 and 0.45.1

@irrigator Yes, however, I implemented "autogrow" differently: I set the following prop:
numberOfLines={this.props.value.split('\n').length}

@catchin that doesn't seem like it would handle line wrapping...

https://github.com/facebook/react-native/commit/35393524a94e2ea2668494eac7c89521f75266cf
Does this fix the issue? It's in the latest RN release.

@Ehesp No, it does not. But https://github.com/facebook/react-native/pull/13890 should.

I tested with 0.46.1 and it seems that it wasn't fixed, input with multiline and blurOnSubmit={false} still does not add a new line on Android with a keyboard other than default (e.g. Swiftkey) :(

One work around, for those of you who are super desperate, is to put a text area in a webview, and communicate the data back and forth.
The work arounds above (mostly work). But it's still not perfect.

All those who are posting work around just one question. Is React Native all about work around ??. I see that even normal functionalities are not working and all organizations have started using this platform :(

@rajsuvariya No, it is not. This bug was fixed recently. Do you still experience this problem on master?

@vspedr Have you tested it on master branch?

@shergin No. I am using stable version 0.46.3. When will these changes be published in the stable version? If it is already please let me know the version.

@rajsuvariya Sorry, I am unaware of release schedule. It should be in stable in the end of the next month.

0.48.0-rc.0 and 0.47.1 are not yet good.

People, I did a search and I found other related issues opened here in github. Did someone solve this or got a better workaround than inserting newline on demand?

Tried to Build ReactAndroid from source from: https://facebook.github.io/react-native/docs/android-building-from-source.html, with this patch: https://github.com/facebook/react-native/commit/e6941990ef1ee4fd757d8dacebdd4be00438e3a7.
Bug still persist on Samsung keyboard and Google Chinese keyboard. Don't think this will be resolved anytime soon since this has been dragging for months. Meanwhile using wrapper class from https://gist.github.com/catchin/47afe706256604959c13dc25e7bb9383, while waiting for patch.

@holyxiaoxin That's sad. Probably different keyboard has different problems. 😢
Could you please share exact keyboard app name (or app id) which does not work for you?

@vendramini That issue discuss iOS specific problem, this one discuss Android specific one.

@shergin Not working on ASUS ZenUI keyboard, Android 7.0, Expo SDK 20 / RN 0.47

@ceefour Thank you! I will try!

It still has errors on Samsung Galaxy S6 keyboard also S7 keyboard.
It works fine with Google's GBoard or the default keyboard in the Android emulator.

Agree with @poongnewga , this seems to be a behavior of certain third-party keyboards (which are in common usage). I think it's independent of Android version or manufacturer, since with my Asus Zenfone 3, I see similar behavior as him, i.e. the bug only occurs when I use ZenUI keyboard, and disappears when I switch to GBoard.

@shergin can you point to commit where this was fixed?

@zhangzhhz While I appreciate if it's really "fixed", the docs say

blurOnSubmit?: bool #
If true, the text field will blur when submitted. The default value is true for single-line fields and false for multiline fields.

Why the need to set to it false when it should default to false in the first place!

Probably to maintain backward comparability

@ceefour Do you mean that in your opinion it should be always false by default or you mean that the current behavior does not respect the docs?

@shergin it doesn't respect the docs, so either one should be changed to match the other. I prefer behavior stated in the docs. much less "unexpected surprise" that way. AFAIK React Native is the only framework where setting "blurOnSubmit=false" explicitly is required on multline text input. Same component in Ionic and Xamarin just works out of the box.

I've tried it with Expo v20 and manually  moving to react-native 0.48.1.
Still no luck with Swiftkey

@codewithpassion, have you tried explicitly setting blurOnSubmit={false}?

@ceefour The adb6646016944fb17fd4cb3824f38a42d4785176 finally fixes issue with wrong default value on Android! 🎉
Thanks @rsnara!

Nope. Still seeing this on 0.49.0. Had to manually set blurOnSubmit={false} to get it to work.

@suvodeep-pyne Yep. Starting at 0.50.

I added this line and it worked correctly:
style={{minHeight: 150, height: 'auto'}}
<TextInput
	onChangeText={val => this.setState({ text: val})}
	value={this.state.text}
	multiline
	style={{minHeight: 150, height: 'auto'}}
/>

@sturmenta  your solution worked for me!


boussingaultia, ferrying

This pull request was generated by the 'mq' tool
[test]
flake rate: 0.4
logical conflict every: 5
sleep for: 300s
[pullrequest]
requests per hour: 30
deps=[b,f]

/trunk merge


adding translocator cooldown reset

Literally just that

I was trying to generate a none dev mode settings but  ADJ_ROADHOG_BREATHER_DURATION was missing, and when i added that it fails to import the code because no maps are selected.

sombra healing WAS bugged. the stuff for it was commented out.


chore(main): release docker 0.1.0

:robot: I have created a release beep boop
0.1.0 (2024-04-20)
Features

docker: add a collection that installs docker (#2) (b0a07a9)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/mateusz-uminski/ansible-collections/releases/tag/docker-v0.1.0 :sunflower:


feat: Run integration tests on full Apple CI matrix

Issue #
#1477
Description of changes
Runs our integration test suite on all of the xcodebuild destinations that CI does: Mac plus iOS, tvOS sims.

To get AWS credentials into the simulators, an Xcode scheme is created for CI integration testing, and the scheme is fitted with a .xctestplan file.  Since xctestplan is a JSON file, the jq command line utility is used to write the credentials into the file before testing.  They are then set as environment variables for the test suite before running.

New/existing dependencies impact assessment, if applicable
No new dependencies were added to this change.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Merging this despite the failing integration tests; those are legitimate integration test failures exposed by the config changes in this PR.
Will address the root cause of those failures separately.


Problem with Time records

Hi, I do have a problem with importing Time records from toggl to Clockify. I got imported all clients and projects but when it comes to Time records import, nothing really happen - see picture attached. Can you please help me with that? Thank you sooooo much :-)

Hi,
I need a bit more information. It is difficult to help with this screenshot. Can you attach the log.txt file, but please remove any sensitive data before.

Hi, thanks a lot for your reply. Sending log attached :)
log.txt

Okay, this is really strange...
I commited a more verbose output version. Can you update your local working copy and run the script again and most what it shows now for
Phase 4 of 5: ...
Are you running the .exe version or the python version of the script?

I am running the .exe version. I download it again and run the script and there is no Phase 4 of 5: even shown anymore ... check log. file. Thank you for your time!!
(or do I have to try it with python?)
log.txt

strange... Do you get any error output on the command line?

Well nothing at all ... no errors :-/

Okay, how do you exactly start the exe file? You should open a command prompt and run it inside the command prompt, than you should get at least the same output as in the log.txt file on the console.

I do have toggl2clockify.exe file and config.json file in the same folder and then I just open the .exe file and it runs automatically...once it is done, .exe file close itself and I have some outputs which is log.txt, toggl_projects_json and clockify_projects.json
Am I doing it wrong?

I guess it is better if you open a command prompt (select start button in windows and type "cmd") go to the exe folder and start it inside the command prompt this way if any error occurs, the output can still be seen on the command prompt and doesn't close automatically

OK...so I got this at the end:

uuups, sorry that was my mistake, can you update and run again...

So I did it and this is result...so it looks like it doesn´t run properly now (check PrtScr). Thank you a looot for your patience!!

okay sorry, that was my mistake again :( can you try again, please...

No worries ... I am happy you are even willing to help me :) So I tried again ... and it awesomely perfectly work!! Thank you sooo much!! :)

It really made my day so thank you!! You are awesome :)

Cool, nice to hear!


What happened to the server? I can't chat uh it got locked

it was locked because of raid
please dont create issue because of these things, i dont think it will be approved by devs

Alr sorry


Documentation comment before module definition leads to misleading error message

In elm 0.15.1 try and compile Test.elm
{-| xyz -}
module Test where
f = 5

It will produce the error
I ran into something unexpected when parsing your code!

2| module Test where
         ^
I am looking for one of the following things:

    a value definition

This is not an error in Elm 0.15

Superseded by https://github.com/elm-lang/error-message-catalog/issues/100?


Contour Wireframe Plot Error: Database Unknown

When making a contour plot using the wireframe option, I get this error in the plot window: *
-----------------------REDMINE MIGRATION-----------------------
This ticket was migrated from Redmine. As such, not all
information was able to be captured in the transition. Below is
a complete record of the original redmine ticket.
Ticket number: 2477
Status: Pending
Project: VisIt
Tracker: Bug
Priority: High
Subject: Contour Wireframe Plot Error: Database Unknown
Assigned to: -
Category: -
Target version: -
Author: Elizabeth Hicks
Start: 12/08/2015
Due date:
% Done: 0%
Estimated time:
Created: 12/08/2015 06:51 pm
Updated: 12/15/2015 06:48 pm
Likelihood: 2 - Rare
Severity: 3 - Major Irritation
Found in version: 2.10.0
Impact:
Expected Use:
OS: Linux
Support Group: Any
Description:
When making a contour plot using the wireframe option, I get this error in the plot window: *
Comments:

unable to reproduce. Should it be closed?

Yes


Not working with react-router v4.0 and browserHistory

I'm just able to see an empty screen. My apoligize that I came to know by read me that current version is only compatible with react-router 3.x so I downgraded it and changed my code but till  I'm getting the same problem.
import React from 'react'
import ReactDOM from 'react-dom'
import { createStore, combineReducers, applyMiddleware } from 'redux'
import { Provider } from 'react-redux'
import { Router, Route, browserHistory } from 'react-router'
import { syncHistoryWithStore, routerReducer, routerMiddleware } from 'react-router-redux'
import EngagementsContainer from './Engagements/EngagementsContainer.js'
import EngagementViewContainer from './Engagements/EngagementViewContainer.js'
import EngagementReducer from './Engagements/reducers/reducers.js'
import thunk from 'redux-thunk'

const router = routerMiddleware(browserHistory);

const middlewares = [ thunk, router ];

// Add the reducer to your store on the `routing` key
const store = createStore(
  combineReducers({
    routing: routerReducer,
    deals: EngagementReducer
  }),
  applyMiddleware(...middlewares),
);

store.subscribe( state => console.log(state) );

// Create an enhanced history that syncs navigation events with the store
const history = syncHistoryWithStore(browserHistory, store)

const AppRoutes = () => { return (
    <Provider store={store} >
      <Router history={history} >
        <Route path="/" component={ EngagementsContainer } /
         <Route path="/hello" component={ EngagementViewContainer } />
        </Route>
      </Router>
    </Provider>
  ) };

export default AppRoutes;

It says right at the top of the readme that this version doesn't work with 4.0...


Changing a bone's rest pose does not redraw the bone

Operating system or device, Godot version, GPU Model and driver (if graphics related):
Linux, godot 33a59993945fb313309c8a68fe5d6e48b2bd1874
Issue description:

Changing the bones rest pose does not update the current scene.
Changing the rest pose and then changing the pose will cause the old rest to be used in pose

Steps to reproduce:

Create new scene with bone
Change rest, bone will not be re-drawn with new rest
Change pose, old rest will be used to pose bone

Link to minimal example project:
bone_draw.zip

Can anyone still reproduce this bug in Godot 3.2.1 or 3.2.2beta4?

Closing due to lack of response. Please comment if you can still reproduce this bug.
PS: If no minimal reproduction project was included in the original bug report, please upload one as well to ease troubleshooting.


Compiler: Consistent command expansion on all platforms?

Discussion
Like I mentioned in my PR for the Interpreter (#12094), I noticed that Windows is expanding ldflags in the compiler, but before it runs Codegen (linking).
However, I'm not sure why we wouldn't want to do the same thing for other platforms (i.e. Linux/Mac/Wasm)?
The only reason I could come up with, is that backticks are valid syntax when running a shell, but obviously Windows can't do it, so it was pulled out to run beforehand.
But I think that should've been the turning point to make it the same for all platforms.
My proposal would be to run the same command expansion that Windows is doing above, but for other platforms as well. This would make it more consistent between platforms and make the compiler and interpreter work more similarly.
Thoughts?

The custom expansion proposed in https://github.com/crystal-lang/crystal/pull/12109 is quite limited. It only covers commands wrapped in backticks. And it's very simple. For example, there is no escaping. It also misses other features that a typical shell provides, most importantly variable expansion. So this might actually be a breaking change when an ldflags configuration depends on more advanced shell features.
So I'm skeptical about this approach, at least in a naive implementation.
Overall, we're missing a concept for managing linker flag configurations (see this forum thread for example: https://forum.crystal-lang.org/t/rfc-link-configuration/546/13).
And in this context I have some doubts whether expanding linker flags in a shell is actually a good idea.

Yeah, that makes sense. I'm not an expert in this kind of thing, just trying to provide some help for simple things, but it's clear I'm a little in-over-my-head here.
I think I'll close the linked PR for now.


Cannot find module 'webpack/lib/Chunk'.  does not work on linux but does works locally

After upgrading to next6 from next3 everything locally was working.
on my server I pulled the new code deleted node_modules and npm i and restarted the server
the server should run on port 3000
however It does not run and I am getting a strange error if I run it manually
module.js:549
    throw err;
    ^

Error: Cannot find module 'webpack/lib/Chunk'
    at Function.Module._resolveFilename (module.js:547:15)
    at Function.Module._load (module.js:474:25)
    at Module.require (module.js:596:17)
    at require (internal/module.js:11:18)
    at Object.<anonymous> (/home/mojoteam/knowledgebase/SSR/node_modules/extract-text-webpack-plugin/dist/index.js:17:14)
    at Module._compile (module.js:652:30)
    at Object.Module._extensions..js (module.js:663:10)
    at Module.load (module.js:565:32)
    at tryModuleLoad (module.js:505:12)
    at Function.Module._load (module.js:497:3)

nodejs.service holdoff time over, scheduling restart.
Started Service Wrapper for Executing Node Application:  .
Starting Service Wrapper for Executing Node Application:  ...
nodejs.service: main process exited, code=exited, status=1/FAILURE
Unit nodejs.service entered failed state.
nodejs.service failed.
nodejs.service holdoff time over, scheduling restart.
start request repeated too quickly for nodejs.service
Failed to start Service Wrapper for Executing Node Application:  .
Unit nodejs.service entered failed state.
nodejs.service failed

Your Environment

Tech
Version

next
6

node
8.11.1

OS
Fedora

browser
Chrome

etc

@theskillwithin Did you figure this out? I'm having the same issue.

Are you using webpack in your project?

@aaldrich I had to run npm run build I think

one solution that works:

rm -rf node_modules
install node v6.14.3
npm i

@mtrabelsi tried it & didn't work 4 me. but thanks 4 suggestion

@aaldrich @akmil anyone solve this problem?
I'm using
"node": "8.9.3",
"npm": "5.6.0"

& it's only showing me this error on Heroku but is working fine locally

@quinnliu  sorry for the late reply, you should also remove your package-lock.json


pkg/dds/test/dap/integration/debug_attach_test  fails on pkg-win-release-arm64

from logs

/============================================================================================\
| pkg/dds/test/dap/integration/debug_attach_test broke (Pass -> RuntimeError, expected Pass) |
\============================================================================================/

--- Command "vm" (took 19.000584s):
set DART_CONFIGURATION=ReleaseARM64 & set DART_SUPPRESS_WER=1 & out\ReleaseARM64\dart-sdk\bin\dart.exe --enable_asserts --sound-null-safety -Dtest_runner.configuration=unittest-asserts-release-win-arm64 --ignore-unrecognized-flags --packages=C:\opt\s\wh5ccbuqe\ir\cache\builder\sdk\.dart_tool\package_config.json C:\opt\s\wh5ccbuqe\ir\cache\builder\sdk\pkg\dds\test\dap\integration\debug_attach_test.dart

exit code:
255

stdout:
00:00 +0: debug mode can attach to a simple script using vmServiceUri

00:04 +1: debug mode can attach to a simple script using vmServiceInfoFile

00:08 +1 -1: debug mode can attach to a simple script using vmServiceInfoFile [E]

  Instance of 'Response'

00:08 +1 -1: debug mode removes breakpoints/pause and resumes on detach

00:13 +2 -1: Some tests failed.

Consider enabling the flag chain-stack-traces to receive more detailed exceptions.
For example, 'dart test --chain-stack-traces'.

stderr:
Unhandled exception:
Dummy exception to set exit code.

--- Re-run this test:
python3 tools/test.py -n unittest-asserts-release-win-arm64 pkg/dds/test/dap/integration/debug_attach_test

I'm seeing a slightly different error when I run locally:
PS C:\Dev\Google\dart-sdk\sdk\pkg\dds> & 'C:\Dev\Tools\Dart\Latest (Bleeding Edge)\bin\dart.exe' .\test\dap\integration\debug_attach_test.dart
00:00 +0: debug mode can attach to a simple script using vmServiceUri

00:09 +0 -1: debug mode can attach to a simple script using vmServiceUri [E]

  SocketException: Write failed (OS Error: The pipe is being closed.
  , errno = 232), port = 0

  dart:io-patch/socket_patch.dart 1246:34       _NativeSocket.write
  dart:io-patch/socket_patch.dart 2004:15       _RawSocket.write
  dart:io-patch/socket_patch.dart 2481:18       _Socket._write
  dart:io-patch/socket_patch.dart 2216:28       _SocketStreamConsumer.write
  dart:io-patch/socket_patch.dart 2168:11       _SocketStreamConsumer.addStream.<fn>
  dart:async/zone.dart 1407:47                  _rootRunUnary
  dart:async/zone.dart 1308:19                  _CustomZone.runUnary

It's possible they're the same issue and there's just a timing difference causing it to show up differently. I'll debug/fix this and we can check the bot results after.

@bkonyi I can only reproduce the error above when running from the terminal - any time I run with a debugger it does not occur. My feeling is that when debugging, the timing is slightly different.
Unfortunately from the terminal, the stack trace is not very useful - there is no user code in it:
00:09 +0 -1: debug mode can attach to a simple script using vmServiceUri [E]

  SocketException: Write failed (OS Error: The pipe is being closed.
  , errno = 232), port = 0

  dart:io-patch/socket_patch.dart 1246:34       _NativeSocket.write
  dart:io-patch/socket_patch.dart 2004:15       _RawSocket.write
  dart:io-patch/socket_patch.dart 2481:18       _Socket._write
  dart:io-patch/socket_patch.dart 2216:28       _SocketStreamConsumer.write
  dart:io-patch/socket_patch.dart 2168:11       _SocketStreamConsumer.addStream.<fn>
  dart:async/zone.dart 1407:47                  _rootRunUnary
  dart:async/zone.dart 1308:19                  _CustomZone.runUnary
  dart:async/zone.dart 1217:7                   _CustomZone.runUnaryGuarded
  dart:async/stream_impl.dart 365:11            _BufferingStreamSubscription._sendData
  dart:async/stream_impl.dart 541:14            _DelayedData.perform
  dart:async/stream_impl.dart 646:11            _PendingEvents.handleNext
  dart:async/stream_impl.dart 617:7             _PendingEvents.schedule.<fn>
  dart:async/zone.dart 1391:47                  _rootRun
  dart:async/zone.dart 1301:19                  _CustomZone.run
  dart:async/zone.dart 1209:7                   _CustomZone.runGuarded
  dart:async/zone.dart 1249:23                  _CustomZone.bindCallbackGuarded.<fn>
  dart:async/zone.dart 1399:13                  _rootRun
  dart:async/zone.dart 1301:19                  _CustomZone.run
  dart:async/zone.dart 1209:7                   _CustomZone.runGuarded
  dart:async/zone.dart 1249:23                  _CustomZone.bindCallbackGuarded.<fn>
  dart:async/schedule_microtask.dart 40:21      _microtaskLoop
  dart:async/schedule_microtask.dart 49:5       _startMicrotaskLoop
  dart:isolate-patch/isolate_patch.dart 118:13  _runPendingImmediateCallback
  dart:isolate-patch/isolate_patch.dart 185:5   _RawReceivePort._handleMessage

Can you think of any ways I might be able to track down where this is happening? From the stack trace, I thought maybe I was using addStream somewhere, and the target stream is closed when the added stream gets an event, but I can't see any relevant addStream calls in the DAP code.
I don't know if something like the "asyncCausalFrames" we use via the VM Service would help here, but without reproducing with a debugger attached I'm not sure if I could get them to see.

SocketException: Write failed (OS Error: The pipe is being closed.

This might be different race. This one is due to how during test session tearDown, client queues command "terminate" to the server's stdin, which races with server process itself shutting down first closing stdin socket, before that "terminate" command has a chance of being written into that server's stdin.

This one is due to how during test session tearDown, client queues command "terminate" to the server's stdin, which races with server process itself shutting down first closing stdin socket, before that "terminate" command has a chance of being written into that server's stdin.

That's the conclusion I arrived at yesterday, though I was unable to handle this error. I can "fix" it by changing the test to not auto-resume-on-exit, but I feel like the teardown should be more robust. I tried adding try/catch for the synchronous + async parts, and the write to the stream is even in a zone, but the error always seems to cause the test failure. Do you know why I don't seem to be able to handle this (the terminate call seems to synchronously write to the stream, so I would've expected a try/catch, or the zone to handle it).
The Instance of 'Response' failure is when the debug adapter returns an error response. I will fix up this code so the reported error is clearer (includes the details of the response) so we can see what the adapter actually returned - my guess is that it's also related to the app shutting down so the request couldn't be fulfilled - which may or may not be similar to the error I'm seeing (hard to say without the specifics).

@sstrickl that's actually a different issue that was caused by my change :-( Unfortunately I dont' think the right trybots ran on https://dart-review.googlesource.com/c/sdk/+/366640 so it wasn't stopped. I've opened a fix for that at https://dart-review.googlesource.com/c/sdk/+/366665
That issue shouldn't affect this test though - if debug_attach_fails we should get a more detailed error like that, although I'm struggling to find if it is currently failing (I tried https://dart-ci.firebaseapp.com/#showLatestFailures=false&configurations=pkg-win-release-arm64 and don't see it, but I don't know if approved failures appear there?).

Is anyone able to confirm if this issue is still occurring, and if so, provide a recent failure log?

Looking at the current results for that test, looks like it's passing in all configurations currently. Looking at the internal flaky dashboard, it hasn't been flaky since December 2023. Thus, I'm marking this closed unless it reoccurs.


Using adapter modules that extend Adapter class

@mosheBelostotsky In order to understand your adapter implementation to-date, I took a look at the core adapter module and saw that in the constructor, you are dynamically loading the adapter file based on the adapter name that is chosen (upon load / config) https://github.com/eedevops/hubot-enterprise/blob/slack_api/lib/adapter_core.coffee#L35
However, I was thinking that perhaps another approach could be to make all adapter modules available within Hubot, have each one of them extend the Adapter class, and then you could dynamically choose which adapter class to instantiate upon load. Please take a look at the pattern that they suggest in the Hubot docs https://hubot.github.com/docs/adapters/development/#adapter-basics.
So, perhaps the adapters could look something like:
class SlackAdapter extends Adapter
...

class FlowDockAdapter extends Adapter
...

Perhaps there are some limitations that you encountered in your research / experimentation. If so, it would be great if you share them.
Great work!
Thanks.

@rqc & @mosheBelostotsky The whole point here is that we bring Hubot up with an adapter so there can be only one adapter with such bot so I think the approach will not bring us any value right?

@eitzhaki @rqc robot is loading the adapter based on parameter and searching in hubot-#{adapter} dir.
To use our internal adapter we need this adapter to extend the specific adapter + change hubot core functionality to load our adapter....

So can we close this issue?
From: Ricardo Quintana<EMAIL_ADDRESS>Sent: Tuesday, August 2, 2016 11:21 PM
To: eedevops/hubot-enterprise<EMAIL_ADDRESS>Subject: [eedevops/hubot-enterprise] Using adapter modules that extend Adapter class (#14)
@mosheBelostotskyhttps://github.com/mosheBelostotsky In order to understand your adapter implementation to-date, I took a look at the core adapter module and saw that in the constructor, you are dynamically loading the adapter file based on the adapter name that is chosen (upon load / config) https://github.com/eedevops/hubot-enterprise/blob/slack_api/lib/adapter_core.coffee#L35
However, I was thinking that perhaps another approach could be to make all adapter modules available within Hubot, have each one of them extend the Adapter class, and then you could dynamically choose which adapter class to instantiate upon load. Please take a look at the pattern that they suggest in the Hubot docs https://hubot.github.com/docs/adapters/development/#adapter-basics.
So, perhaps the adapters could look something like:
class SlackAdapter extends Adapter
...
class FlowDockAdapter extends Adapter
...
Perhaps there are some limitations that you encountered in your research / experimentation. If so, it would be great if you share them.
Great work!
Thanks.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHubhttps://github.com/eedevops/hubot-enterprise/issues/14, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ARsQKrxMbf7qxvBndWn81gDEouF6nJhzks5qb6bFgaJpZM4JbAlh.

The resolution is to re-consider this when a major refactoring or hardening takes place. I would leave it open for now so that we can track it and perhaps add a special label of wish list low priority. What do you think?

@rqc I would suggest to close this issue and open a new one with specific action items for refactoring...

@mosheBelostotsky that would be ok, but we might end up losing the context of how those action items came about. Let's keep the conversation going here for now. Also, no worries about leaving an issue open, this happens all the time and it is encouraged. I created a few labels that should help us filter and distinguish between items that require our immediate attention and those that don't (e.g. wish list, priority/low). What do you think?


Add expected type API to Semantic API

Purpose
Fixes #36539
This PR will add the new API, expectedType to semantic API which provides expected type based on the given position.
Approach

Describe how you are implementing the solutions along with the design details.

Samples

Provide high-level details about the samples related to this feature.

Remarks

List any other known issues, related PRs, TODO items, or any other notes related to the PR.

Check List

[x] Read the Contributing Guide
[ ] Updated Change Log
[ ] Checked Tooling Support (#)
[x] Added necessary tests

[x] Unit Tests
[ ] Spec Conformance Tests
[ ] Integration Tests
[ ] Ballerina By Example Tests

[ ] Increased Test Coverage
[ ] Added necessary documentation

[ ] API documentation
[ ] Module documentation in Module.md files
[ ] Ballerina By Examples

Issues Related to PR:
https://github.com/ballerina-platform/ballerina-lang/issues/38564
https://github.com/ballerina-platform/ballerina-lang/issues/38522
https://github.com/ballerina-platform/ballerina-lang/issues/38491

All review suggestions are addressed except changes suggested in LS testcases, changes suggested in PositionUtil and a few refactoring suggestion that causes test failures.


[MadNLPGPU] AMD support

It would be good to add support for AMDGPU. We only need to add rocBLAS interface to MadNLPLapackGPU.

I think this is definitely doable. All kernels implemented in MadNLPGPU  are using KernelAbstractions, so are directly portable to AMD. One thing, though: I don't know it's a good idea to have both AMDGPU and CUDA as dependencies in the same package. I think we may want to split MadNLPLapackGPU in two: MadNLPCUDA and MadNLPAMDGPU?

That's the risk. KernelAbstractions depends on Cassette.jl, and that might add some overhead in the load time. Maybe we need another package MadNLPKernel? But that's maybe too much ...

That makes total sense. MadNLP should be as lightweight as possible (and I like the current setting, with few dependencies)


no ability to pass kwargs to create_engine

Hello! Love your library and use it often in my daily work.
One feature I would love to see is very simply adding kwargs to the Database class that can be passed to the sqlalchemy create_engine method. Here is a possible  implementation:
...
    def __init__(
        self,
        uri: str,
        name: str = None,
        cache_store: Union[str, Path, store.BaseStore] = None,
        store_backend: str = "parquet",
        normalize: bool = True,
        compression: Any = None,
        **kwargs
    ):
        self.__dict__.update(**kwargs)
        self.kwargs = kwargs
        self.engine = create_engine(uri, **self.kwargs)
...

I think there are a number of uses for this, but I can provide my primary use case: In order to connect to my company's database I need to be attached to the VPN. If I am not attached to the VPN, it takes many minutes for sqlalchemy to raise an error which is a frustrating waste of time. However, if I pass a more reasonable timeout to the create_engine method like this:
engine = sqlalchemy.create_engine(
           uri='MY_URI',
            connect_args={"connect_timeout": 5},
        )

then an error is quickly raised, indicating I need to check my VPN connection then retry the query.
Let me know what you think. Thanks again  @felipeam86 for publishing such a neat, and useful little library! If you are open to collaborating, I am happy to make the code changes and submit a PR myself :)

Hi @jacob-r-g !
Thanks for the kind words. Nice to see other people benefiting from this package! What you are proposing makes sense.
I will be very glad to collaborate with you. Please submit a PR and I'll process!

I would be happy to, but it looks like i do not have write access to the repository to publish a branch or submit a PR. Can you provide access @felipeam86 ?

@jacob-r-g I don't think you need to be a collaborator. You can fork the repository and do a PR from it.
In any case, I did add you as a collaborator to the project to make things simpler

Sounds good, I have opened a PR

@jacob-r-g I've done a new release with your pull request. I'll close this issue. Feel free to open a new one if it doesn't work


OSD-13005 Improve debug logging and specificity of returned errors

Independently check for enableDnsHostnames and enableDnsSupport and provide errors
Recommend specifying an image-id when no default image is found
We're only really aware of docker issues when parsing user data logs at the moment, but setting the code up to expand for future issues

Codecov Report

Merging #131 (ce03f63) into main (8283e30) will decrease coverage by 0.25%.
The diff coverage is 40.42%.

@@            Coverage Diff             @@
##             main     #131      +/-   ##
==========================================
- Coverage   19.01%   18.76%   -0.26%
==========================================
  Files          19       19
  Lines        1020     1034      +14
==========================================
  Hits          194      194
- Misses        799      811      +12
- Partials       27       29       +2

Impacted Files
Coverage Δ

pkg/cloudclient/aws/private.go
44.48% <40.42%> (-2.70%)
:arrow_down:

/label tide/merge-method-squash