MP4 fixes, recap table improvements

Check if map is null for every game instead of just TM2020. This fixes the script exceptions when loading/exiting a map on MP4 (and probably Turbo too)
Use a second for loop to find a matching UID when looping TM2 Exchange's API response. This won't load the maps that are not on MX of course, but it loads the maps that were after the missing UID. See #53
Adds alternate background color for the rows in the recap table. Here's how it looks

Freeze table header (see screenshot above) and align rows text

Partially fixes #53
Closes #41 (hopefully)

Marking as draft because the for loop still doesn't work quite right (and I'm having a hard time understanding the code :sweat_smile:). Will mark it as ready once I fix it

looks good! ty


[Android] Different shadow length in landscape and portrait view (elevation)

Environment
Environment:
OS: Linux 4.14
Node: 6.10.3
Yarn: Not Found
npm: 3.10.10
Watchman: Not Found
Xcode: N/A
Android Studio: Not Found
Packages: (wanted => installed)
react: 16.3.0-alpha.1 => 16.3.0-alpha.1
react-native: 0.54.0 => 0.54.0
Expo SDK 26
Steps to Reproduce

CRNA
Add bottom bar with elevation
Run on Android (5+)
Rotate phone

import React from 'react';
import { StyleSheet, Text, View } from 'react-native';

export default class App extends React.Component {
  render() {
    return (
      <View style={styles.container}>
        <Text>Open up App.js to start working on your app!</Text>
        <Text>Changes you make will automatically reload.</Text>
        <Text>Shake your phone to open the developer menu.</Text>
        <View style={styles.tabBar}>
          <Text>Test</Text>
        </View>
      </View>
    );
  }
}

const styles = StyleSheet.create({
  container: {
    flex: 1,
    backgroundColor: '#fff',
    alignItems: 'center',
    justifyContent: 'center',
  },
  tabBar: {
    flex: 1,
    backgroundColor: '#fff',
    position: "absolute",
    bottom: 0,
    height: 56,
    elevation: 8,
    width: "100%",
    alignItems: 'center',
    justifyContent: 'center',
    opacity: 1
  },
});

Expected Behavior
Pretty shadows
Actual Behavior
Different shadows

Can you reproduce the issue on the latest release, v0.54?

When Expo updates to 0.54 :thinking:

0.54 same issue

0.55.4 still reproducible
https://snack.expo.io/SJywnG67m


WIP MGMT-9754 Static IPs

Heavily WIP, do not merge.
Adding Static IPs. Progress recently blocked on persistence.

Closing in favor of https://github.com/rh-ecosystem-edge/ztp-pipeline-relocatable/pull/547


Add search

Feature Request
Is your feature request related to a problem? Please describe.
Some documentation is long and complicated to find things in, which leads to lots of clicking around and reading
Describe the solution you'd like
Having a search dropdown, like on the react documentation, for example. This can be done using DocSearch for free, simply by having the autocomplete etc. as an option, and then explaining how to apply. A similar process as for docusaurus can be followed
Note that I work for Algolia.

I really like this idea and it's in the roadmap, as soon as possible I'll create this on docz-theme-default 🙏

If there's anything we can do to help, ping :)

Thanks @Haroenv, pr are welcome too ✌

To facilitate user feedbacks and make a really good roadmap, now we're using Canny as a tool to create our roadmap 😍
We think that is better keep Github issues only for bugs and other issues! 🐞
This issue is already on our roadmap, so I'll close this issue in favor of it!
👉🏻 Check this issue on roadmap

All right, makes sense!

Released in the new v0.5.0 🚀

Any reason you chose not to go for Algolia?

@Haroenv, I've chosen for something faster to develop and less complex for now, but I'll improve this later...


Python: dict and set audio file

Description 📜
I have added an audio file and its document file in the python folder. Issue No. #551

Type of change 📝

[x] Au#dio (Should be in mp3 format Includes speech clarity, Concise ,Low distortion)
[ ] Vi#deo (Animations, screen-recordings, presentations and regular explanatory films are all possibilties etc)
[ ] Doc#umentation (Content Creation in the form of codes or tutorials)
[ ] Other (If you choose other, Please mention changes below)

Domain of Contribution 📊

[ ] Android Dev #(Flutter)
[ ] Android Dev #(Java)
[ ] Android Dev #(Kotlin)
[ ] Backend Dev #(Java)
[ ] Backend Dev #(.NET)
[ ] Backend Dev #(PHP)
[ ] Backend Dev #(Python)
[ ] C/#CPP
[ ] Competitive #Programming
[ ] Cyber #Security
[ ] DS#A
[ ] Data#base
[ ] Datascience with #Python
[ ] Datascience with #R
[ ] Frontend Dev #HTML/CSS/JS
[ ] Frontend Dev #React/Angular/Vue
[ ] Go#lang
[ ] Interview #Prep
[ ] Java_#Domain
[ ] Java#Script
[ ] ME#RN
[ ] Machine #Learning
[ ] Open #Source
[x] Python_#Domain
[ ] Ru#st
[ ] Statis#tics
[ ] UI/#UX

Checklist ✅

[x] I follow Contributing Guidelines & Code of conduct of this project.
[x] I have performed a self-review of my own code or work.
[x] I have commented my code, particularly in hard-to-understand areas.
[x] My changes generates no new warnings.
[x] I'm GWOC'21 contributor

Screenshots / Gif (Optional) 📸

@ankurg132 sir, it's uploaded.

Delete the previous .txt file, use the correct markdown format for links which should look like [Reference link](your drive link here) instead of [Reference link] your drive link which you are using currently.

@ankurg132 sir, is it perfect now ?


[BEAM-775] Full removal of Aggregators in Java SDK and Runners

Coverage increased (+0.1%) to 69.998% when pulling da85133988d4e5636aaf93be67911db8b9dfec9a on pabloem:full-remove-agg into 3bd8a0f9f2c0fa4676c090f70a8053de5275de8a on apache:master.

Changes Unknown when pulling 6bf4ab7b030723cddc759155bc74946a1e1046dc on pabloem:full-remove-agg into ** on apache:master**.

Coverage increased (+0.1%) to 69.973% when pulling 6bf4ab7b030723cddc759155bc74946a1e1046dc on pabloem:full-remove-agg into a552fb8f69d1bcab64377d1743f5e7d4d653509a on apache:master.

r: @dhalperi all tests pass. The only thing that is left about aggregators is the class itself. It's not being used anywhere, and it should be removable after the dataflow worker is rebuilt.

LGTM


Support collection queries

This allows collection indices to be resolved, which means (among other things) the required_if option will work on collection members.

also, could you please squash your commits into one and sign it?
(While I haven't really documented it here yet) we're trying to follow the same contributing philosophy as Praxis: https://github.com/rightscale/praxis/blob/master/CONTRIBUTING.md#sign-your-work

Squashed, other CR change made, and signed :+1:

LGTM


Bower Package?

Hey there,
looking at using this but would love to include it in my bower build. If you're interested in including it on bower I'd be happy to submit a PR to add the necessary files.
Cheers

Hello Chad!
Im happy that you will find a use for this plugin! Yes, please feel free to submit PR and i will process it right away :)

Hello, just to let you know, your request is in development with v2


showLimitedView() "Can't fetch all photos" only shows first time picker is displayed when selectLimit = 1

What did you do?
When picker options selection limit is set to 1, and user selects limited photo access (selected photos only), then the alert at the bottom of the picker screen "Can't fetch all photos, Click to select more photos", only appears on first time shown and doesn't display for a any other time the picker is shown. If I change selectLimit to > 1, then the text alert at the bottom of the picker shows every time (as expected).
var options = PickerOptionsInfo()
options.selectLimit = 1
options.selectOptions = .photoGIF
options.selectionTapAction = .quickPick
What did you expect to happen?
Expected the alert "Can't fetch all photos" to show at the bottom of the picker every time the picker is shown. But it doesn't.
What happened instead?
The "Can't fetch all photos" alert is shown the first time the picker is displayed, but not for any other times the picker is shown, until the next app restart.
Environment
AnyImageKit version: 0.14.3
Xcode version: 13.3
Swift version: 5.5
iOS/iPadOS/macOS version: iOS 15.1

fix in #144 and released version 0.14.4, enjoy it 😊

👍👍
On Fri, Apr 8, 2022 at 2:29 AM 刘栋 @.***> wrote:

fix in #144 https://github.com/AnyImageKit/AnyImageKit/pull/144 and
released version 0.14.4, enjoy it 😊
—
Reply to this email directly, view it on GitHub
https://github.com/AnyImageKit/AnyImageKit/issues/143#issuecomment-1092486307,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABVTEPTK4NZ2DST5GLJMBQTVD7G2XANCNFSM5SRJCUVA
.
You are receiving this because you authored the thread.Message ID:
@.***>


main.jsbundle does not exist. This must be a bug with + echo 'React Native - getting this error while archiving the builds.

Description
echo 'error: File /Users/lassie/Library/Developer/Xcode/DerivedData/EduFund-bucqbjbvceebshdrsgccwdmntmhd/Build/Intermediates.noindex/ArchiveIntermediates/APP-NAME/BuildProductsPath/Release-iphoneos/APPNAME.app/main.jsbundle does not exist. This must be a bug with'
error: File /Users/lassie/Library/Developer/Xcode/DerivedData/APPNAME-bucqbjbvceebshdrsgccwdmntmhd/Build/Intermediates.noindex/ArchiveIntermediates/APP-NAME/BuildProductsPath/Release-iphoneos/APPNAME.app/main.jsbundle does not exist. This must be a bug with

echo 'React Native, please report it here: https://github.com/facebook/react-native/issues'
React Native, please report it here: https://github.com/facebook/react-native/issues
exit 2
Welcome to React Native!
Learn once, write anywhere

events.js:291
throw er; // Unhandled 'error' event
^
Error: EMFILE: too many open files, watch
at FSEvent.FSWatcher._handle.onchange (internal/fs/watchers.js:178:28)
Emitted 'error' event on NodeWatcher instance at:
at NodeWatcher.checkedEmitError (/Users/lassie/Documents/APP-FOLDER-PATH/PROJECT-NAME/node_modules/sane/src/node_watcher.js:143:12)
at FSWatcher.emit (events.js:314:20)
at FSEvent.FSWatcher._handle.onchange (internal/fs/watchers.js:184:12) {
errno: -24,
syscall: 'watch',
code: 'EMFILE',
filename: null
}
Command /bin/sh emitted errors but did not return a nonzero exit code to indicate failure
Version
react-native-cli: 2.0.1 react-native: 0.63.4
Output of react-native info
react-native-cli: 2.0.1
react-native: 0.63.4
Steps to reproduce
.
Snack, code example, screenshot, or link to a repository
No response

I have this bug too

In xcode just rename the main target to something else Eg. Myapp -> Myapp-new.


Entity/Component implementation

Adds a (experimental-flagged) Entity/Component system to Torque 3D.
Can be activated via the advanced property TORQUE_EXPERIMENTAL_EC in cmake.
Note: Currently requires one of the Physics APIs(Bullet or PhysX) to be active as well to use any of the physics/collisions components.

Nah, you're correct. Timmy recently pointed that out to me and it had totally snuck past. My apologies and I'm working on the fix for it. Thanks for the additional spotter on that though!


Logs in admin panel

Would be a great idea to put logs from chat in the admin panel on the website. Moderators can then check logs if there was an event or something that needs clarification. Logs of what that person has been saying, just not that day but a couple of weeks earlier too. So mods dont ban someone that's actually nice and talkative.

Logs is something I want to implement, not quite sure how to store last messages of a user.
One possibility is this:
Store a log element for each time a user is timed out (the CLEARCHAT event is thrown).
When that is thrown, we store the users latest message along with the timeout row in the database.
I also want logs for admin commands like, whenever someone uses !add command it should be visible in the logs properly.
I'm thinking logs should be stored in MySQL under tb_log or something like that.
Not sure about the structure yet.

ye, also recent changes and which mod who changed anything

[ ] Command removed
[ ] Command added
[ ] Command edited
[ ] Banphrase removed
[ ] Banphrase added
[ ] Banphrase edited
[ ] Blacklisted link added
[ ] Blacklisted link removed
[ ] Whitelisted link added
[ ] Whitelisted link removed
[ ] Timer removed
[ ] Timer added
[ ] Timer edited
[ ] Userlevel edited
[ ] Module removed
[ ] Module added
[ ] Module edited
[ ] Permaban removed
[ ] Permaban added
[ ] Game set
[ ] Title set

Log entry layout:
{
    "message": "XD",
    "tag": "Command edited",
    "created_at": "2015-09-13 12:03:04",
    "added_by": 123,
    "data": {
        "previous_command": "xd",
        "new_command": "XD",
    }
}

logs for

[ ] !add alias
[ ] !remove alias


Saving interactive html containing Bokeh camera display?

https://github.com/cta-observatory/ctapipe/blob/e65311dd6dc49c1314ad82be0c5c907a1fb6cc96/ctapipe/visualization/bokeh.py#L18
I would like to produce, using the bokeh camera display, an interactive html file in which a given camera display shows different values according to the position of a slider (the values would be run-wise averages of various pixel quantities, and the slider would be used to select the run). It seems this requires to use JavaScript callbacks, i.e. https://docs.bokeh.org/en/latest/docs/user_guide/interaction/callbacks.html.  What I need is something like the first example there, in which the slider changes the power of a polynomial, but in my case the plot would be a camera display. I gave it a try, with no success, and I am completely lost. Is it possible to do this with the current ctapipe bokeh camera display?

Can you show the code you currently have?

I just tried to follow the example in the linked bokeh page above, and make a camera display in which I could scale the pixel contents by a factor via a scaler. Actually I know that what is wrong there (at least one thing): the 'image' I am modifying does not contain at that point the pixel values, but the rgb color codes, so it cannot work. But I do not know how to do it, since the camera.cdsource does not have the pixel values inside, just the colors.

from bokeh.layouts import column
from bokeh.models import ColumnDataSource, CustomJS, Slider
from bokeh.plotting import Figure, output_file, show
import numpy as np
from ctapipe.instrument import CameraGeometry
from ctapipe.coordinates import EngineeringCameraFrame
from ctapipe.visualization.bokeh import CameraDisplay as BokehCameraDisplay
geom = CameraGeometry.from_name('LSTCam')
engineering_geom = geom.transform_to(EngineeringCameraFrame)
pad_width = 350
pad_height = 370
z0 = np.linspace(0, 1854, 1855)
cam = BokehCameraDisplay(engineering_geom)
cam.image = z0
cam.add_colorbar()
output_file("js_on_change.html")
source = cam.cdsource
plot = cam.fig
callback = CustomJS(args=dict(source=source), code="""
var data = source.data;
var slider_value = cb_obj.value
var image = data['image']
for (var i = 0; i < image.length; i++) {
image[i] = image[i] * slider_value
}
source.change.emit();
""")
slider = Slider(start=0, end=1, value=1, step=1, title="factor")
slider.js_on_change('value', callback)
layout = column(slider, plot)
show(layout)

Ok, this could be solved by the changes O had planned for the camera display.
I will open a PR next week.

I guess you're trying to make a stand-along gui? You can also do it in a Jupyter notebook with the interact tools, which work well with Bokeh displays (using push_notebook(handle) to update). Then you have access to all info, and no need for JavaScript.  Of course then you have to use the ipywidgets slider, not the Bokeh ones, I think.

Alternately, use a Bokeh Datasource, and make sure add the pixel values to it (as in my example), so then you have access to those values not just the colors.

The problem is that the CameraDisplay is converting values to colors directly and not through bokeh means for mapping data to colors.

Ah, yes, that is solved in the example above - just use a DataSource and ColorMapper.  I think we can just replace some of the existing code with what I showed in #1247 (with hex pixels as well).

Thanks a lot, @kosack, indeed with the display version in #1247  I managed to make an interactive camera plot and save it as html - I think that is very convenient for easy display of e.g. data quality checks to be accessed at a web site. Would be great to have this new CameraDisplay in one of the coming releases.
Eventually, one might have a camera display with the "multiple values" option built-in, i.e. rather than providing a single image to it, we could provide an array of images, mapped to certain values to be selected interactively with a slider (e.g. run numbers).

Implemented in the new bokeh camera display


[ Security ] Increased entropy from OpenSSL and OS to a full SHA512 …

…block (64 bytes) and added additional entropy from RDSEED on CPUs that support it.
To compile it a flag is needed to enable the RDSEED instruction. I compiled with
./configure CFLAGS='-mrdseed ' CXXFLAGS='-mrdseed ' CPPFLAGS='-mrdseed' --with-incompatible-bdb

As for the actual changes:

It is unclear to me why we only used half a SHA512 block to gather entropy from OpenSSL, and the same for OS entropy.
I increased that entropy gathering to a full block for each one.
I added entropy from the RDSEED instruction implemented on x86 by Intel and AMD.
The entropy from RDSEED is NIST compliant. ( See https://csrc.nist.gov/projects/cryptographic-algorithm-validation-program/details?product=11882)
All AMD Zen processors support this instruction and most Intel Processors launched since 2015.
The existence of this instruction is checked at runtime, if it is not available we default to the previous mechanism where we gather entropy from OpenSSL and the OS. Only we gather twice as much as before to get one full SHA512 block when hashing.

EDIT 1: @michilumin @rnicoll @patricklodder @edtubbs
EDIT2: Fixed typo, from RNSEED to RDSEED.

I am looking at all the errors...its a different error for each system. hahahhahahahahaha
Okay,  here we go:

The ARM errors: I think the thing to do here is to do compile time headers and default to the previous version with double the entropy gathering (See notes on the PR).
For the 32-bit systems, I will default back to 32-bit registers to gather the data.
For 64-bit systems, the issue is the compiler flag I mentioned in the PR.
Apparently MacOS does not have the same cpuid.h as found in linux, which makes sense. In particular, with the new processors like the M1, I think the best course of action is the same one as for ARM. Default back to previous method with double the entropy gathering.
The 64-bit windows error is the same as the one I got. Solving the compiler flag will solve this one too.

@patricklodder @michilumin @edtubbs

We are now getting the same error on all but the MacOS platform. Those errors will be fixed when the flags are added to the compiler.
As for MacOS, the fix is defining the bit_RDSEED macro as it seems #include <cpuid.h> on MacOS is not defined. I will just define it myself if it is not defined.

@patricklodder @rnicoll Okay, ARM and MacOS are ready to go. We need to add the compiler flags to fix the others. Alternatively, we could just use the byte code implementation of RDSEED, but I'd rather fix the intrinsic flag issue now as it will come up again.

like with sse2, I'd like a ./configure flag for this
unlike with sse2, we should probably give some thoughts about what the default can/should be

@patricklodder Given this particular implementation checks for availability of this instruction at runtime, the default on the compiling side should be to always enable it. How that is done is up to discussion.

I think I can be okay with a default enable, as long as it also can be switched off, to enhance portability to architectures we currently do not test for / do not foresee. So for that to be nice, we'd just add --disable-rnseed to configure.ac, which can override a use_rnseed=yes as a configure flag. Kinda like how zmq integration is done - default on, can be disabled.
Thoughts?

@patricklodder  That's perfect.

@patricklodder @rnicoll  How do I detect ARM at the configure.ac level? That is the only way I can think of to solve this. I can think of another way, but it would probably break the Windows build.

Unsubscribe
On Mon, 30 Aug, 2021, 11:23 am RichDevX, @.***> wrote:

@.**** commented on this pull request.
In src/random.cpp
https://github.com/dogecoin/dogecoin/pull/2482#discussion_r698204896:

           int32_t status1 = _rdseed32_step( &rng_low );

           int32_t status2 = _rdseed32_step( &rng_high );

Should place in a retry loop
https://software.intel.com/content/www/us/en/develop/articles/intel-digital-random-number-generator-drng-software-implementation-guide.html#inpage-nav-5-9
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/dogecoin/dogecoin/pull/2482#pullrequestreview-741287881,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AVMSUCHTZMMZYCY5N3TIVFLT7MMEJANCNFSM5CSGKWIQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

@patricklodder Could you confirm: what does uname -p return on the machine that is running the arm linux test?

https://software.intel.com/content/www/us/en/develop/blogs/changes-to-rdrand-integration-in-openssl.html
According to Intel, OpenSSL is using RDSEED as an entropy source to seed the software PRNG in v1.0.2..
https://github.com/openssl/openssl/blob/1c0eede9827b0962f1d752fa4ab5d436fa039da4/providers/implementations/rands/seeding/rand_cpu_x86.c#L29

@edtubbs Thanks for that reference. That Intel document supports the option to implement RDSEED ourselves, given OpenSSL does not gather entropy from that instruction by default.

Actually, it says OpenSSL uses the RDSEED instruction by default if available with RDRAND starting in v1.0.2, and the comments in that version are consistent.

@edtubbs My final comment on this matter: I vote for the inclusion of this code. We maintain this code and can guarantee that sources from the hardware, if available in hardware and sufficient in bytes at running time, will always be used. We will not depend on other projects implementation/usage not even the OS kernel.  Virtually no performance cost. Per NIST standard, compliant. Small enough to review carefully.
Per OpenSSL project, note this was written 3 years after the intel doc, (https://www.openssl.org/blog/blog/2017/08/12/random/):
They’re relatively well-commented, but the implementation could to change in the future.
(referencing entropy sources.)

@michilumin @rnicoll will have the final word on this.

@ReverseControl could you please do the rebase/squash on this branch?
If you haven't the remote to this repo already:
git remote add upstream https://github.com/dogecoin/dogecoin.git

then:
git fetch upstream
git rebase -i upstream/1.14.5-dev #and squash all the commits into one
git push -f origin 1.21.5-dev-improve_entropy_for_key_generation

then this PR should show a clean commit tree and becomes mergeable.

Pushing to 1.14.6 as this is stalled on rebase.

@patricklodder Done. Do check the rebase.


[Feature Request] Set 'allowEmptyScopes' based on commitlint config

💭 Describe the feature
Respect commitlint option about empty scopes by default, when there's no option set for cz-git explicitly:
  rules: {
    "scope-empty": [2, "never"]
  }

https://commitlint.js.org/#/reference-rules?id=scope-empty
💡 Proposed Solution
Fallback to commitlint config when the cz-git one is not specified directly.
If the commitlint setting is in the warning mode (1) instead of the error one (2), we could either ignore it or maybe provide some additional message.

I feel like this is a bug, I need to locate it further.

The latest version 🌟(v1.2.4)🌟 should be resolve this issue request , please have a try. 💪
👀 Let me know if there are still any issues. Thanks for reporting it! 🎉

@Zhengqbbb I just tried it and I think it still doesn't work :/
Sample configuration:
  rules: {
    extends: ["@commitlint/config-conventional"],
    "scope-empty": [2, "never"],
    "body-leading-blank": [2, "always"],
    "footer-leading-blank": [2, "always"],
    "trailer-exists": [2, "always", "Issues:"],
    "references-empty": [2, "never"],
    "references-in-trailer": [2, "always", "Issues:"],
    allowBreakingChanges: [],
  },

when I run cz, I still see:
❯ gcz
<EMAIL_ADDRESS><EMAIL_ADDRESS>
? Select the type of change that you're committing: feat:     A new feature
? Denote the SCOPE of this change:
  ──────────────
  custom
❯ empty

@Zhengqbbb or actually I think the problem is with allowEmptyScopes per se - now I tried with no extends:, with all commitlint rules removed and with allowEmptyScopes: false added - and I still see exactly the same prompt as above.

@Zhengqbbb one more issue I discovered (it's not related to the above bug):
 allowEmptyScopes: pkgConfig.allowEmptyScopes ?? clPromptConfig.allowEmptyScopes ?? !ruleIsActive(clConfig?.rules?.["scope-empty"] as any),

When you pass "scope-empty": [2, "never"] to !ruleIsActive(clConfig?.rules?.["scope-empty"] as any), then the result of ruleIsActive would be true, so the negated one would be false, so empty scopes would be disallowed - and that's fine.
But - when I pass "scope-empty": [2, "always"] - the result would be exactly the same, because we don't check the value of second element in array in ruleIsActive function - that's actually done in ruleIsNotApplicable, which is not used here.

@Zhengqbbb I think I found the issue:
https://github.com/Zhengqbbb/cz-git/blob/aa0e8fb930ba1383300e6ebd0ad2069535c648c7/packages/cz-git/src/until/until.ts#L59-L72

when you don't define scopes - you get:

? Denote the SCOPE of this change:
  ──────────────
  custom
❯ empty

when you define single scope like:

scopes: [{ name: "scope1", value: "scope1" }],

you get:
? Denote the SCOPE of this change: (Use arrow keys or type to search)
❯ scope1
  ──────────────
  custom
  empty

but when you define 2 or more scopes:
scopes: [{ name: "scope1", value: "scope1" }, { name: "scope2", value: "scope2" }],

you get:
? Denote the SCOPE of this change: (Use arrow keys or type to search)
❯ scope1
  scope2
  ──────────────
  custom

So the problem is the target.length check in the below if statement:
   if (!Array.isArray(target) || target.length === 3 || target.length === 4) {
     return allowCustom ? target : target.filter((i) => i.value !== "___CUSTOM___");

leads to wrong results, because it doesn't check allowEmpty at all. I'm not sure what was the exact goal of target.length === 3 || target.length === 4 check, but it seems to be just too naive.
I just wonder if that if statements is actually needed at all? Implementing the function without it wouldn't be enough?
 const filterCustomEmptyByOption = (
   target: {
     name: string;
     value: any;
   }[],
   allowCustom = true,
   allowEmpty = true
 ) => {
   target = allowCustom ? target : target.filter((i) => i.value !== "___CUSTOM___");
   return allowEmpty ? target : target.filter((i) => i.value !== false);
 };

@jaklan Sorry to trouble you. At the same time I did not find out. You are right. This implementation does need to change.
The main reason for this is due to the easing strategy. I haven't been very strict with empty before because I thought I might need to provide an exit for the next step.

@jaklan
I want to push code that resolve of these issues. But at the moment I can't push the code, don't know if it's a github question or our country's question. I'll try it later.

@jaklan
The latest version 🌟(v1.2.5)🌟 should be resolve this issue request , please have a try. 💪
👀 Let me know if there are still any issues. Thanks for reporting it! 🎉

@Zhengqbbb seems to work 😉


How do I add custom header using C# generated proxy client?

I have WebApi project, tested the custom header using Postman, works fine.  But can't figure out how to add the header using WebApiProxy generated C# client.
 var client = new TestClient();
 client.HttpClient.DefaultRequestHeaders.Add("Clientid", "tester");
 var test = new TestClient().Get("123");

Not sure if I understand it correctly.  Appreciate your help.  Thanks.

Nevermind, this seems working fine.  Not sure what I missed earlier.


Not able to connect to testnet

Issue Template
Context
I'm attempting to download the testnet blockchain but can't seem to find any nodes.  I'm trying the one listed in the readme.md using ./VERGEd -testnet -addnode=ddvnucmtvyiemiuk.onion
Prerequisites

[x] Are you running the latest version? Yes

User Story:

"I'm submitting a ... "

[ ] bug report
[ ] support request

Expected Behavior
I'd expect to connect to the testnet and download the blockchain
Current Behavior
I get stuck at connections: 0
Steps to Reproduce (for bugs)
./VERGEd -testnet -addnode=ddvnucmtvyiemiuk.onion
Your Environment

Verge Release:
CPU: 4770k
GPU: GTX 1080
RAM: 32gb
OS:

[ ] I'm using Mac

Any extra information that might be useful in the debugging process.
This is my VERGE.conf
rpcuser=[redacted]
rpcpassword=[redacted]
daemon=1
algo=lyra
server=1
rpcallowip=192.168.8.*

I have the following in my debug.log:
VERGE version v<IP_ADDRESS>-2be388c-funky-beta (2018-01-26 22:22:13 +0100)
Using OpenSSL version OpenSSL 1.0.2n  7 Dec 2017
Startup time: 02/16/18 03:57:12
Default data directory /Users/kyler/Library/Application Support/VERGE
Default mining hash algorithm: lyra2re
Used data directory /Users/kyler/Library/Application Support/VERGE/testnet2
scrypt: using scrypt-sse2 as built.
dbenv.open LogDir=/Users/kyler/Library/Application Support/VERGE/testnet2/database ErrorFile=/Users/kyler/Library/Application Support/VERGE/testnet2/db.log
Bound to <IP_ADDRESS>:29102
TOR thread started.
AddLocal(5vj3xi4ecublsq76.onion:29102,4)
Loading block index...
Opening LevelDB in /Users/kyler/Library/Application Support/VERGE/testnet2/txleveldb
Transaction index version is 70509
Opened LevelDB successfully
LoadBlockIndex(): hashBestChain=65b4e101cacf3e1e4f3a9237e3a74ffd1186e595d8b78fa8ea22c21ef5bf9347  height=0  trust=1  date=04/30/16 23:14:26
LoadBlockIndex(): synchronized checkpoint 65b4e101cacf3e1e4f3a9237e3a74ffd1186e595d8b78fa8ea22c21ef5bf9347
Verifying last 0 blocks at level 1
 block index              12ms
Loading wallet...
No OBFS4 found, not using it.
nFileVersion = 4000100
 wallet                  225ms
Loading addresses...
Loaded 0 addresses from peers.dat  1ms
mapBlockIndex.size() = 1
nBestHeight = 0
setKeyPool.size() = 101
mapWallet.size() = 0
mapAddressBook.size() = 2
Done loading
ThreadRPCServer started
Loading addresses from .onion seeds
ThreadSocketHandler started
0 addresses found from .onion seeds
ThreadOnionSeed exited
trying connection ddvnucmtvyiemiuk.onion lastseen=0.0hrs
ThreadMessageHandler started
SOCKS5 connecting ddvnucmtvyiemiuk.onion
Flushed 0 addresses to peers.dat  0ms
ERROR: Proxy error: connection refused
trying connection ddvnucmtvyiemiuk.onion lastseen=0.0hrs
SOCKS5 connecting ddvnucmtvyiemiuk.onion
ThreadRPCServer method=getinfo
ERROR: Proxy error: general failure
trying connection ddvnucmtvyiemiuk.onion lastseen=0.0hrs
SOCKS5 connecting ddvnucmtvyiemiuk.onion
ERROR: Proxy error: connection refused```

@kylerc I'm running into this same issue, (how) did you manage to fix it?
https://imgs.xkcd.com/comics/wisdom_of_the_ancients.png

I didn't lol.  I just gave up, seems more development is needed for the testnet to be working again.

yeah we're working on it, it's not a huge deal. basically the testnet p2p port isn't wrapped by tor

I am getting the same issue. How should I fix it?


Auto-detect headers

System Information (please complete the following information):

Model Builder Version: CLI 16.1.0

Training on a file without header because has-header flag default is true takes the first row as the column names. It would be good to have it default to false and autodetect/generate headers unless users explicitly say it had header.
Dataset:
Wow... Loved this place.	1
Crust is not good.	0
Not tasty and the texture was just nasty.	0

Command:
mlnet classification --name classification --dataset yelp_labelled.txt --label-col 1

ModelInput:
// This file was auto-generated by ML.NET Model Builder.

using Microsoft.ML.Data;

namespace Classification.Model
{
    public class ModelInput
    {
        [ColumnName("Wow... Loved this place."), LoadColumn(0)]
        public string Wow____Loved_this_place_ { get; set; }

        [ColumnName("1"), LoadColumn(1)]
        public string _1 { get; set; }

    }
}

@justinormont @beccamc do we have anything that is good at guessing if there is a header?

Add a third option for has-header flag should be able to solve this


Extend generated model from source functionality

Describe the feature
Proposed features

A settings field that allows the user to set the naming template for the generated model to align with their specific naming convention.
For example: base__{schema}_{table_name} or stg_{table_name}

Generate the model file in the same folder as where the source.yml is located.

Goal of features
This eliminates having to rename and move the generated file each time.
Describe alternatives you've considered
No response
Who will benefit?
All users that generate base models from source.
Are you willing to submit PR?

[X] Yes I am willing to submit a PR!

These changes are welcome, maybe they can be configured through vscode configurations (can be set globally or per workspace).


the meaning of Δx, Δy and Δz

hi😊, I want to confirm the meaning of Δx, Δy and Δz. Do they represent the change from the initial position at each timestamp? And if you subtract two adjacent terms, you get the change in position of adjacent frames, right?

the delta x,y,z means the deformation between  canonical 3D Gaussians and world 3D Gaussians
if you want to get deformation between two adjacent frames, you should:

compute the 3D Gaussian's position x1 at timestamp t1
compute the 3D Gaussian's position x2 at timestamp t2
return x2-x1


Fix enabling/disabling of proxy objects in catalog

Fixes #1660
Pretty simple fix. QSProxyObject (a subclass of QSBasicObject) override the enabled method, and did not call through to super.

Again, another small fix which I'll merge straight into master.
I'm keen to get 2.1.0 out


BJM to write a Why for week 1

From @bjmorgan
Should we include a "what is this course for / overview" at the beginning of the handout and in the lecture content? At the moment the handout reads like the students are doing a programming course, rather than a programming + comp chem methods course. I am happy to add some stuff at the beginning (or to another document) talking about the overall course outline and how we see it fitting together (including, e.g. why we are teaching comp chem through programming exercises rather than a traditional series of lectures).

why coding is important to chemistry?
not just lab coats and test tube
importance of computational chemistry/data analysis
teaching to program to use for comp Chem/data analysis
practical hands on
mix labs and lectures

https://github.com/pythoninchemistry/ch40208/blob/master/week_1/overview.pdf
(realised now it could possibly do with a bit on generic data analysis / reproducibility)

depending on how tired/caffinated I am on the train I will try and add something to that


Srinivas Peer Review

Assignment
Weightage
Grade
Comments

College Board Coverage
20
17/20
Strong alignment with College Board standards. To improve, consider incorporating more explicit references to specific AP topics for a deeper connection.

Java Examples
30
26/30
Solid examples of Java implementation. Adding more diverse and complex examples could further enhance the variety and challenge of the lesson.

Popcorn Hack Usage
10
7/10
Creative use of the Popcorn Hack. With some adjustments, it could be more seamlessly integrated into the flow of the lesson.

Homework
10
9/10
Reinforces key concepts effectively. Adding a few more challenging questions would push students to think more critically.

Grading Plan
10
9/10
Clear grading criteria are outlined. Adding more detail, such as including partial credit for creativity, would strengthen the assessment framework.

Original and Creative
10
8/10
The lesson incorporates some unique and creative ideas. For a fresh approach, try experimenting with elements that haven't been used in previous lessons.

Total
90
81/90
Overall, this is a strong lesson. With some added complexity and innovative elements, it could reach an even higher level of engagement and depth.

Assignment
Points
Grade
Evidence

Pull Request (Integration)
2
1.7

Relevancy Checklist (Peer)
2
1.8
created this issue and peer reviewed Srinivas

Lesson (Group)
1
0.91

Homework, Popcorn Hacks
1 x 8
7.3
Refer to google Sheet Grading

Individual Contribution
1
0.92
Contribution 1, Contribution2, Contribution3

Personal Notebooks / Blogs
1
0.91
Personal Notebooks

Total
15
13.54

Skill
Points
Grade
Evidence

Work Habits (Analytics)
1
0.92

Team Planning (Issue)
1
0.9
Planning Issue

Presentation Memories
1
1
- Was a fun experience for all of us collaborating on a repo since CSP, MERGE ERRORS!!!!! we developed a true hate for them, practicing our presentation together in office hours

Grading and Feedback
1
0.9
- Have not received a grade for this aspect of the team Teach yet but we belive we graded fairly across all people but there is always room for improvement

Beyond Perfunctory
1
0.91
We developed a solid lesson but brought a fun interactive aspect to it as well with the jeopardy game that will remain a memorable way to recollect and implement Arraylists in code in the future

Total
5
4.63
0.926

Your summary of blogs and thinking about API aspects is amazing.   Memories and CSP is interesting?

The BLOG you shared on utterace would be amazing if it linked to your lesson detail.  This is the best thing I have seen in any review!!!   Memories and CSP is interesting?  Did that impact you?

i like how you talked about fun moments from working with your team and your page is super organized

I liked the notes, very nice with the animation. Could've definitley added more visual representations but aside from that great presentation.

Well done it was nice  to see how things like API applications were added.  Very organized.

I like how you talk about which units you think is the most important and will be implemented the most frequently. I also like how you talked about problems you faced and adversities.

his blog was great, he went in depth on his favorite memory and also what he contributed to his team. He was a helpful person to his team and was clear on what he learned during his team teaching. it was also very organized and neat.

I like how you mentioned a problem during the team teach and how you worked as a team to combat this issue. I also like you design for displaying the unit summary.

I think the study guide you made is very helpful and has very good information in it.

Personal experiences helped me see how he grew from the experience. He also had some good notes on what he learned and a cool way to keep it compact.

Your blog is super organized and I like how you discussed future projects that you might create.

I like the pop up for showing information and being honest about other groups.

Blog page with key highlights and API implications looks very organized and reflective. Good plan for making project to help future students with college app.

I liked how you discussed moments leading up to the lesson, such as the methods of practice your team incorporated, which shows how invested all four members of the team were in creating a good team teach.

Your page is organized and has good summaries on each unit

Very nice notes and reflection. I also liked the organization on your blog post. Very thoughtful summaries

Your blog was really well made! Having modals pop up on the page was very cool to see and it was good that you discussed further implications of your lesson.

Your blog is very nice looking and you discussed your personal growth as well. Very nice overall!

I liked your project idea for a college app tracker and how you developed leadership skills.

Overall, it is solid work and then the blog and the issue are very organized as well. The issue included images and good summaries which will be really helpful when reviewing the units.


Removed several warnings when compiling with GCC 10.2

stxxl::priority_queue uses std::memmove internally, which is only defined behavior for trivially copyable types.
std::pair and std::tuple are not trivially copyable, even if all the stored types are trivially copyable, so storing
them in a stxxl::priority_queue is technically undefined behavior. While this should still work as expected in all "sane"
compilers, it is still against the standard and GCC 10.2 throws a warning. This commit fixes the only occurence of this warning
in the "core" libraries stxxl and stxxl_tools. Note that there are many more occurences of this issues in the examples
(e.g. in the skew3 algorithm) which remain unchanged by this commit.

stxxl::vector::const_vector_iterator had a user-defined copy-constructor but the automatically generated copy-assignment-operator.
This throws a warning in GCC 10.2 (Typically, either both can be defaulted, or both have to be manually defined). The const_vector_iterator
is a trivial type, so defaulting both operations works here and leads to a cleaner interface.

@bingmann We are currently using this fork of stxxl for the QLever project (@niklas88 suggested this switch quite some time ago). It seems to be newer than the "official" stxxl/stxxl repository, although both of them have slightly diverged. Could you please comment on the current status of stxxl? Is it still being officially maintained, and if yes, by whom?

@bingmann We are currently using this fork of stxxl for the QLever project (@niklas88 suggested this switch quite some time ago). It seems to be newer than the "official" stxxl/stxxl repository, although both of them have slightly diverged. Could you please comment on the current status of stxxl? Is it still being officially maintained, and if yes, by whom?

I also ask myself the question, is the project still alive ? I would be interested in maintaining it, but if not many people are interested I don't know if it's worth it.
I thought I would do as I did on this project:
https://github.com/stbrumme/crc32/pull/11

Add github action for Linux, MacOS, Windows
Add github action for cross platform (ARM, RISCV, PowerPC ect...) with dockcross
Add Google test and Google benchmark, to avoid regressions with units test
Compatible C++11 to C++20


Issue592 reword filter content

Added one map for filter button actual option values -> display option values.
Filtering functions properly (see recording below).
TODO: My Prettier seems to do something differently then the existing formatter from main, many file changes are simply due to auto formatting, should I adjust my Prettier setting to make formatting more consistent ? (If so, could you pls share your Prettier setting with me @CodeWritingCow  thx!)

Closes #592
https://github.com/CodeForPhilly/clean-and-green-philly/assets/88219993/cfcbf873-6870-456b-a0dd-ae2c2cb7eb99

@zheyichn I added this line your PR description: Closes #592. For future PRs, let's tag the ticket number that you're working on in the PR description. It'll help everyone keep track of ticket statuses. Thanks!


Fix/787

Replaced 'accuracy' with 'quality' in sandbox/ files. Fixes #787.

Can one of the admins verify this patch?

Can one of the admins verify this patch?

[ ] Is it mergeable?
[ ] Did it pass the tests?
[ ] If it introduces new functionality in scripts/ is it tested?
Check for code coverage with make clean diff-cover
[ ] Is it well formatted? Look at make pep8, make diff_pylint_report,
make cppcheck, and make doc output. Use make format and manual
fixing as needed.
[ ] Did it change the command-line interface? Only additions are allowed
without a major version increment. Changing file formats also requires a
major version number increment.
[ ] Is it documented in the ChangeLog?
http://en.wikipedia.org/wiki/Changelog#Format
[ ] Was a spellchecker run on the source code and documentation after
changes were made?

add to test list

add to testlist

Ready to review.

Otherwise it looks good!

Ready to review.

LGTM. As soon as this is mergeable I shall do so.

Thanks!

Just in case you're wondering, khmer-recipes works with this.


dts: bindings: modem: ppp: add optional power and reset pins

The user can configure optional reset and on pins for the generic gsm-ppp device.
There's already a condition check in modem_cellular.c that checks if those pins have been defined to use them.

What is your usecase for this change @ldenefle? Are you using a modem that is not supported by the modem_cellular.c driver yet? In which case you could just add an entry for it there like the other modems :)

What is your usecase for this change @ldenefle? Are you using a modem that is not supported by the modem_cellular.c driver yet? In which case you could just add an entry for it there like the other modems :)

It is a much better approach than further development of that driver. I would go even further and remove it entirely since there is no reason to maintain 2 drivers simultaneously.

Hello all,
Maybe I can shed some light on my current use case and the problem this PR solves for me.
Right now I'm using a EC-25G module and the new modem subsystem by @bjarki-trackunit the module driver is not yet implemented in Zephyr but the gsm_ppp device does the job as it's super generic. My only problem with it is that out of the box it can't control reset and power pins.
So in this situation, I could:

reimplement a gsm driver to maintain out of tree and reimplement a bunch of code internal to modem_cellular driver
add an entry in the cellular_modem file and raise a PR, it would mean having to maintain another list of chat commands in modem_cellular which would be identical to the gsm_ppp one for now with an extra dts/bindings for quectel,ec-25g to me it seems like it's the most Zephyr compliant solution but I don't like the idea of repeating so much code
extend the generic gsm_ppp to add ability to control power and reset pins, this feels elegant to me as modem_cellular already filters out their use on initialisation with macros of type .power_gpio = GPIO_DT_SPEC_INST_GET_OR(inst, mdm_power_gpios, {}), so IMO it's a very painless way to add  optional power pin control on a device that is already made generic

The current PR stems from some challenges:

there is no way to easily add an out-of-tree modem_cellular without reimplementing a bunch of custom structs like device data and config and fsm as most of the of the modem_cellular functions and data structure are private
modems that share initialisation chat scripts create boilerplate code

Let me know what you think

What is your usecase for this change @ldenefle? Are you using a modem that is not supported by the modem_cellular.c driver yet? In which case you could just add an entry for it there like the other modems :)

It is a much better approach than further development of that driver. I would go even further and remove it entirely since there is no reason to maintain 2 drivers simultaneously.

GSM PPP is already marked deprecated. It will be removed in two releases.

add an entry in the cellular_modem file and raise a PR, it would mean having to maintain another list of chat commands in modem_cellular which would be identical to the gsm_ppp one for now with an extra dts/bindings for quectel,ec-25g to me it seems like it's the most Zephyr compliant solution but I don't like the idea of repeating so much code

@ldenefle This may be the best option due to the gsm_ppp driver going away in the near future. Maybe there's some room for optimization in cellular_modem to reduce copied code.

I fully agree with you @bjarki-trackunit and not criticizing a bit !
The repetition IMO is not the issue, I can't think of way to avoid it and another wrapper would add undesired opacity.
The specific improvement I would have loved as an user is to be able to access the MODEM_CELLULAR_DEVICE macro from out of tree, to be able to leverage the generic modem_cellular state machine.

Anyway I'm convinced that the best way to go forward is to implement my own driver with its own init_chat script in-tree, so this is what I'll do, once it's functional I'll open another PR.
Thanks all


Animation callback missing

Song : 122 ルンに花咲く恋もある
Num diva : 1
0 : Diva : 8 - Costume : 17 - 0 Position : 1
Valkyrie : 13
Difficulty : VeryHard, Line6 : True
Valkyrie : Ev_AwakeEffectEmitStop / Ev_AwakeEffectEmitStart

This was coded since the bug was opened


Sharing textures doesn't work on macOS/CGL

Here is what gfx-backend-gl tries to do:

create one GL context ("root") without a surface, most operations are done on that context by rendering into textures.
create an additional GL context for the window/surface. When it's time to present, we want to blit from a renderbuffer of the root context to this context. Then we present the surface.

This is needed in order to detach the "Instance" we have from the "Surface". In order to work properly, it requires that a certain renderbuffer is shared between the GL contexts (rendered into by "root", read by "surface".
We were struggling to get this to work with @zicklag, and we found out that CGL context is created without any sharing. I experimented with a surfman API that would allow sharing contexts in this branch and confirmed that this would work.
@pcwalton is this a bug in the code, feature not yet implemented (sharing), or a limitation by design?
Note: it is very much desired to avoid the blit altogether, and just be able to render to a surface from the "root" context. But apparently this isn't supported by surfman, at least now. We are looking forward to see if this becomes an option.

@kvark Did the changes in your surfman branch fix the issue with the surfman backend in GFX?

Yes, see https://github.com/gfx-rs/gfx/pull/3216#issuecomment-625322960
Here are the corresponding backend changes. It creates another context for the Instance, which is shared with both adapter contexts and surfaces.

My goal was to avoid any GL context sharing to avoid locking and driver bugs. (Servo used to use sharing and it had a lot of problems.) It's an easy trap for people who aren't as experienced with graphics APIs to use GL context sharing and make a mess.
But for advanced use I could see how sharing could be useful, as long as the documentation warns against it…

I don't know how this works much, but would texture sharing be a safe alternative that would work for our GFX use-case? Could we share the rendered texture instead of the GL Context?

If there is a way for us to get that use case I described without sharing contexts, I'd love to try it out. Otherwise, we'll proceed with a PR adding the sharing capability to surfman.

I can't tell what's going on, but maybe that is similar to what's going on in the threads example somewhere around here:
https://github.com/pcwalton/surfman/blob/ae14cc9afd140bc73e89f3fe8c080f729f09ccd2/surfman/examples/threads.rs#L218-L225
It looks like that is sending the surface around over a channel, maybe not the texture. I don't know if that would help.

You should be able to detach surfaces from contexts and send them over channels; that's how the threads example works. I'm not sure whether this works for your use case?

@zicklag
That function allows a different context to read the texture of a surface. This is indeed a limited form of surface/texture sharing that doesn't involve the whole context sharing. However, the key limitation here is read, so we can't share the final surface texture with it (since we want to write to it). So, if I understand correctly, it's not useful to our case.

Can we create a context and a surface associated to that context, render to it, then send that surface to the thread that owns the window handle's surface, and then create a texture ( read only ) from the rendered surface that we can copy to the window's surface?

@zicklag Yes, that should work.
BTW, you may find @asajeffrey's surfman-chains useful, if not to use, than at least to look at as a reference: https://github.com/asajeffrey/surfman-chains It builds swap chains on top of surfman. Servo uses it for compositing WebGL/WebXR content.

@zicklag I don't see how this would solve our case. Would that surface be associated with the swapchain? There is no way to get that without sharing the resources with whatever else there is on the device.

@pcwalton surfman-chains looks promising for sure.
@kvark I don't really know. I never fully grasped how the Vulkan-ish GFX API was going to use the surfaces and such.
It feels like we're just going to have to put the context that we write to in an RwLock to enforce single-thread-at-a-time access to whatever is doing the rendering and avoid any sharing. Then, using the surfman-chains project we can create a swap chain. According to the surfman-chains doc:

Each swap chain has a producer context, responsible for creating and destroying surfaces, and a number of consumer contexts, (usually just one) which take surfaces from the swap chain, and return them for recycling.

So the producer context would be the context that we render to. That context would have to be behind an RwLock. The Window would be the consumer context. I can't remember how the Swapchain relates to the window surface in GFX...but...if I remember right the swapchain has the window surface associated to it and it would be responsible for grabbing the next frame in the swap chain and displaying it on the window surface.
I might be missing something. Does that make any sense?

Nope, sorry, I don't think it's going to work like that.
When the GL backend is given a stream of commands (i.e. a list of command buffers at submission), it doesn't have any association of them to any surface. They might be rendering to some swapchain, or multiple, or not any at all. This is where we are producing the contents of the swapchain images, and we can't use their personal contexts for that. We can only render to some buffer that can be blit onto the surface, but that requires that the surface sees that buffer, and this is exactly the context sharing we are missing.

Reading your initial comment, I think I understand the problem: you want to share a plain old GL renderbuffer over to another GL context. The workflow surfman was designed for is this: you don't render to a plain GL renderbuffer object, but rather to a surface created specially through surfman, which you can then share over to another thread. Is there a reason why you need to render to a GL renderbuffer as opposed to a surfman surface?
(I'm not saying no to sharing, I just want to understand why it's necessary.)

Note that this is similar to the way that DXGI requires that you pass a special SHARED flag when creating a surface to be shared between threads/processes, and in fact this is the implementation on Windows.)

Is there a reason why you need to render to a GL renderbuffer as opposed to a surfman surface in the first place?

Imagine that there is a Device, and all the resources the user creates belong to this device. It includes shaders, buffers, textures, and other things. Let's say that command buffers are also created from the device and submitted for execution on it, for simplicity. Some of the work that the user does may need to render to some surface. How do you suggest us to render to this surface? The work of rendering to it depends on many resources the user has created on the device. The device is created without any knowledge of surfaces (and thus, any resources on it). So how does rendering to a surface get access to the resources used in that rendering? I only see sharing as an option.
Now, maybe there isn't need for a blit there under certain conditions. Maybe we can just identify that render pass that targets the surface, and switch to the surface context for it. This isn't really relevant to the subject here (since the sharing is still needed), and it would require the following conditions:

that render pass doesn't render to multiple surfaces at once
the context of a surface can modify resources of the device context (e.g. with load/store operations, or by have a depth-stencil attachment from it), OR
some guarantee that this particular pass only reads the resources

What if we put all the resources in one thread, and "remote controlled" that thread with messages sent over a channel for every operation we needed to make to the graphics resources.
Do we still need shared contexts if everything happens in one thread?

This isn't about threading at all. In fact, we are pretty much doing what you described today: the command buffers are recorded without touching any GL contexts, and we actually issue command on queue submit(), which typically happens on one thread. The problem is that no single context has access to all resources as well as the target surface(s), if we don't have sharing.

So it is sounding like we need sharing, and surfman may or may not grant us a lot of extra advantage over gluten except for its lack of a dependency on winit?

Yep. if glutin were able to work with RWH instead of being locked to winit, we'd just use it. Anyhow, the glutin discussion is largely off-topic in this issue.

OK, so that makes this still relevant to the work we are doing for GFX and it means that we will also need PRs for the MacOS, X11 (, XCB? ), and Wayland to enable sharing in surfman.
I'm not sure that I can do that one, or that I'll find the time very soon. I haven't looked at @kvark 's experiment branch yet, but if it is simple enough then I might be able create PRs for X11 when I find the time. If sharing support lands in surfman then I think our surfman backend for gfx doesn't really need changes other than to enable the sharing.

It seems to me that @pcwalton isn't opposed to sharing, so the next step for us could be turning this work into a PR that can be discussed here.

OK, that doesn't look super hard. Whenever I next have time I'll probably check it out, if nobody beats me to it.

Looking over https://github.com/servo/surfman/pull/185 it looks like a good implementation of context sharing, the question is whether we need it? In the other cases where we need to step outside the surfman/surfman-chains model, I've done it by using (e.g.) NativeContext and create_context_from_native_context (https://github.com/servo/surfman/blob/master/surfman/src/device.rs#L58-L60) Could we do that in this case too?

I guess I am equally confused :/ The Native* APIs are the "escape hatch" for "surfman's model mostly fits my application, but I need to interoperate with something else", e.g. for gstreamer we need to use its GL APIs, which we do via Native*. I'm wondering whether we could use NativeContext to create a GL context with sharing, then construct a surfman Context from it?
Even better would be to work out if there's a way to use surfman in gfx without texture sharing, but this might be tricky as surfman/surfman-chains is based on each Surface having a producer context and a number of consumer contexts which only get read access. It sounds like this is a different model than gfx uses?

Chat at https://chat.mozilla.org/#/room/#gfx:mozilla.org/$wg5m0QokgZulwv-lx8eAKSWSC-yjbcXJzrR0o17ytR4
tl;dr: we might be able to lift the restriction that surfman Surfaces have an associated producer Context that has draw access. This restriction was needed for GLX, but that's not a supported platform any more.


NameError: name 'cuda_setup' is not defined

/root/miniconda3/lib/python3.9/site-packages/torchvision/io/image.py:13: UserWarning: Failed to load image Python extension: libtorch_cuda_cu.so: cannot open shared object file: No such file or directory
warn(f"Failed to load image Python extension: {e}")
Initializing Chat
Loading VIT
Loading VIT Done
Loading Q-Former
Loading Q-Former Done
Loading LLAMA
===================================BUG REPORT===================================
Welcome to bitsandbytes. For bug reports, please submit your error trace to: https://github.com/TimDettmers/bitsandbytes/issues
Traceback (most recent call last):
File "/root/MiniGPT-4/demo.py", line 60, in
model = model_cls.from_config(model_config).to('cuda:{}'.format(args.gpu_id))
File "/root/MiniGPT-4/minigpt4/models/mini_gpt4.py", line 243, in from_config
model = cls(
File "/root/MiniGPT-4/minigpt4/models/mini_gpt4.py", line 90, in init
self.llama_model = LlamaForCausalLM.from_pretrained(
File "/root/miniconda3/lib/python3.9/site-packages/transformers/modeling_utils.py", line 2639, in from_pretrained
from .utils.bitsandbytes import get_keys_to_not_convert, replace_8bit_linear
File "/root/miniconda3/lib/python3.9/site-packages/transformers/utils/bitsandbytes.py", line 9, in
import bitsandbytes as bnb
File "/root/miniconda3/lib/python3.9/site-packages/bitsandbytes/init.py", line 7, in
from .autograd._functions import (
File "/root/miniconda3/lib/python3.9/site-packages/bitsandbytes/autograd/init.py", line 1, in
from ._functions import undo_layout, get_inverse_transform_indices
File "/root/miniconda3/lib/python3.9/site-packages/bitsandbytes/autograd/_functions.py", line 9, in
import bitsandbytes.functional as F
File "/root/miniconda3/lib/python3.9/site-packages/bitsandbytes/functional.py", line 17, in
from .cextension import COMPILED_WITH_CUDA, lib
File "/root/miniconda3/lib/python3.9/site-packages/bitsandbytes/cextension.py", line 13, in
setup.run_cuda_setup()
File "/root/miniconda3/lib/python3.9/site-packages/bitsandbytes/cuda_setup/main.py", line 92, in run_cuda_setup
binary_name, cudart_path, cuda, cc, cuda_version_string = evaluate_cuda_setup()
File "/root/miniconda3/lib/python3.9/site-packages/bitsandbytes/cuda_setup/main.py", line 395, in evaluate_cuda_setup
has_cublaslt = is_cublasLt_compatible(cc)
File "/root/miniconda3/lib/python3.9/site-packages/bitsandbytes/cuda_setup/main.py", line 153, in is_cublasLt_compatible
cuda_setup.add_log_entry("WARNING: Compute capability < 7.5 detected! Only slow 8-bit matmul is supported for your GPU!", is_warning=True)
NameError: name 'cuda_setup' is not defined

What bitsandbytes version are you using?

Version: 0.37.0


1.27.0: Community Updates won't go away even after reading them

The number above the notification bell, and the actual notification, used to go away after you've clicked and read the notification. Now with version 1.27.0 they are stuck (at least one such notification is stuck for me).

Thanks for the feedback, and sorry for the holiday delay. This was an intentional change but it hasn't worked out as we'd hoped (currently you see events since your last login). The notification drawer is being revamped and this should be resolved in the new version.

Thanks for the feedback, and sorry for the holiday delay. This was an intentional change but it hasn't worked out as we'd hoped (currently you see events since your last login). The notification drawer is being revamped and this should be resolved in the new version.


Kernel is not launched with right arguments or some of the launcher API is not used

export interface IKernelLauncher {
    launch(interpreterUri: InterpreterUri, kernelName?: string | IJupyterKernelSpec): Promise<IKernelProcess>;
}

Kernel launcher accepts a pthon interpreter or resource uri as first argument
However rawJupyterSession always passes a resource Uri as first argument.

I.e. looking at the code, there is no place where we launch a specific interpreter.

Either we haven't added that code
Or we don't need that. I.e. we don't need the ability to launch a specific interpreter in IKernelLauncher.

Removing that code makes it simpler as well.
Though I'm not sure whether we need it or not.
Either way we have some dead code

@DonJayamanne . @DavidKutu  and I can look into this.  Right now I'm not seeing a reason why we would want to kernel find with a specific interpreter. So I think this is the case:

Or we don't need that. I.e. we don't need the ability to launch a specific interpreter in IKernelLauncher.

But I'm just trying to think it through to make sure we're not missing a case here. I would think the only time we might need an interpreter is if we don't have a resource / kernel name, and in that case we just use the active interpreter, we don't pass one in.

Closed as work item.


Random UI tweaks mostly

Most controversial thing is making savegame writable. But guess what: it was always mostly writable and and nothing bad happened. We have so many other ways to protect the save anyway in the tools.


Remove outdated IE6 condition in  tag

SilverStripe\View\SSViewer => get_base_tag()
IE6 is almost 20 years out of date. It's time to remove <!--[if lte IE 6]></base><![endif]--> or at least make it optional so you can remove it if desired.
public static function get_base_tag($contentGeneratedSoFar)
    {
        $base = Director::absoluteBaseURL();

        // Is the document XHTML?
        if (preg_match('/<!DOCTYPE[^>]+xhtml/i', $contentGeneratedSoFar ?? '')) {
            return "<base href=\"$base\" />";
        } else {
            return "<base href=\"$base\"><!--[if lte IE 6]></base><![endif]-->";
        }
    }

If you'd like to create a PR, I'll be happy to review it - but this is not a high priority by any means.


What about Remote Desktop for Administration?

This page adds to confusion about Remote Desktop licensing.  According to this page, Remote Desktop for Administration doesn't even exist.  We have several admins who need to quickly remote into our Windows Server 2016 boxes in separate domains and start/restart a service, then log right back out again.  Why would a separate license be needed to administrate a server that's not included in the server's operating system license?
Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: fd015c0b-3360-88fd-86b1-08e8c0e8ec5e
Version Independent ID: 0c3ddb09-23f3-68a3-e7a4-877951feb55b
Content: License your RDS deployment with client access licenses (CALs)
Content Source: WindowsServerDocs/remote/remote-desktop-services/rds-client-access-license.md
Product: windows-server
Technology: remote-desktop-services
GitHub Login: @lizap
Microsoft Alias: elizapo

Hello @KitLemmonds. Please post your question on Microsoft Q&A.

Microsoft has no documentation anywhere on "Remote Desktop for Administration", so to the original poster's point, you draw great confusion with this article completely ignoring it.


Fix documentation

Description

Apparently the code blocks need an opening PHP tag.
Add missing log level in config
Add middleware config

Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to
implementation.
Please reference the issue this PR will close: #[issue number]
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list:

[ ] Code compiles correctly
[ ] Created/updated tests
[x] Extended the documentation

Codecov Report

Merging #56 (d3525e9) into main (40b40a0) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main      #56   +/-   ##
=========================================
  Coverage     73.23%   73.23%
  Complexity      360      360
=========================================
  Files            45       45
  Lines          1349     1349
=========================================
  Hits            988      988
  Misses          361      361

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 40b40a0...d3525e9. Read the comment docs.


UK Biobank Exome data from GSK collaboration

GSK are finalising their analysis of rare variant tests for over 700 traits using the whole exome sequence data from 50K individuals from UK Biobank. They would like to share their data with us, to be made available through Open Targets immediately after accessibility restrictions are lifted (early March 2019).
This would be a great opportunity for Open Targets, as most people working in the field will be using this data in the coming months.
Steps:

[ ]  Plan what the UKB GSK Exomes page will look like
[ ] Plan table schema
[ ] Plan GraphQL schema
[ ] Map traits to EFO
[ ] Write description of methods

The 450k+ individuals are currently available through GWAS catalog. We will soon be scoping the required work. Particularly, to handle rare variants.


Patched sprintf usage (IDFGH-5175)

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Why not using strcpy instead?

Why not using strcpy instead?

Good point, I guess strcpy is better in this case. I updated to strncpy and used the defined WPS macros for the bounds lengths. For example:
 strncpy(dev->manufacturer, s_factory_info->manufacturer, WPS_MAX_MANUFACTURER_LEN);

@PBearson Thanks for your contribution.

Hi @PBearson , we use snprintf now which checks for bound limitation, therefore this change is not needed anymore.

Thanks for contribution again.


Implement Statements

Statements are given here:

https://sulzmann.github.io/ModelBasedSW/imp.html#(2)

Definition of Done:

[x] Command Sequence

[x] Pretty
[x] Eval
[x] Check
[x] Tests

[x] Variable Declaration

[x] Pretty
[x] Eval
[x] Check
[x] Tests

[x] Variable Assignment

[x] Pretty
[x] Eval
[x] Check
[x] Tests

[x] While

[x] Pretty
[x] Eval
[x] Check
[x] Tests

[x] If-then-else

[x] Pretty
[x] Eval
[x] Check
[x] Tests

[x] Print

[x] Pretty
[x] Eval
[x] Check
[x] Tests

[x] Block

[x] Pretty
[x] Eval
[x] Check
[x] Tests

[x] Program

[x] Pretty
[x] Eval
[x] Check
[x] Tests

Unittests are almost done. We still have to implement scoping and write some tests accordingly.


[Spike] Improve keymaster scope handling on tags management screen

refs #6191, #6192

supplement focusIn and focusOut event handlers in gh-tag-settings-form with mouseEnter/Leave and touchStart events so that the navigation shortcuts aren't lost after the first interaction with the settings form
add a resetShortcutsScope action that is triggered on tags list touchStart so that touch screen devices can get the tags navigation shortcuts back
as a final backup, reset the keymaster scope to default when leaving the tags route

How we're handling the various events:

focusIn/focusOut handle keyboard navigation. Tabbing through screen elements will always trigger focusIn last which disables the default keymaster scope, once you tab out of the gh-tag-settings-form children only the focusOut event is triggered re-enabling the default scope.
mouseEnter/mouseLeave handle mouse movement. Any time the mouse is over the gh-tag-settings-form element the default keymaster scope will be disabled.
touchStart handles touch devices. Any touch on the tag settings form will disable the default scope, a touch on the tags list will re-enable the default scope.

Marked as a spike as it may be overkill. I'll pull the scope reset on deactivate into a separate PR as that will be useful immediately and I'll continue to ponder on any other edge cases here.

Not to completely upend this PR, but have we thought about using ember-keyboard at all? Seems to have more intuitive shortcut handling.
Otherwise, LGTM :+1:

Yep, I've been looking at that quite a bit, interesting to see how it's changed recently. TBH I'm still bit concerned that this PR is over-complicating things, however even with ember-keyboard we'll run into similar issues because of the way the screen is designed.
Not sure what the best approach is for situations like this where we have multiple screen areas that each need their own shortcut handling.

Going to close this to keep the PR list clean. I think this approach is likely overkill for something we're not seeing many issues/support requests for but it was a useful experiment to see how far certain ideas could be pushed.


Autogenerate Invoice number

Notion :
https://www.notion.so/saeloun/While-generating-a-new-invoice-the-invoice-number-should-be-autopulated-as-per-the-previous-invoice--05e98f0d18064bb5b47f9f4e92f8292d?pvs=4
What :

if the previous invoice number for a client is 003, then when the user selects the client name on a new invoice, then the invoice number field is getting be auto-populated with 004.
If last character of previous invoice number is alphabet then the invoice number will be blank.
If no previous invoices are present for the selected client then the invoice number will be blank.

Why :

To ensure that the invoice number is incremented from the previous number and maintain consistency.

Preview :
https://www.loom.com/share/89f4ce5938f0498381582f247b797c41?sid=7a0ff982-fdb0-4258-a418-40a37311eb9a
Todos (for testing):

Tested according to requirement.

@Shruti-Apte Please fix the bug mentioned in the loom video.
https://www.loom.com/share/6baeef45bec04c92b73ef0cb2167b3f9


Not filtering the users

Hi,
So I cloned the project and ran mvn clean install and i had this error:
Compilation failure
keycloak-custom-api-searchby-attr-master/src/main/java/keycloak/apiextension/KeyCloakUserApiProviderFactory.java:[3,29] cannot find symbol
[ERROR]   symbol:   class TokenKeyCloakUserApiProvider
[ERROR]   location: package keycloak.apiextension
So I went and changed the import to .* and ran it again. This time it worked but it keeps returning the list of all the users of the realm.
Keycloak is telling me that the jar file has been deployed.
I'm using keycloak 12.0.4 and maven 3.6.3 and using this query url with postman:
localhost:9990/auth/admin/realms/myrealm/users?attr=merchant_id&value=1
The query url mentioned in the workshop is not working.
If i'm doing something wrong please let me know. If not I hope you fix this as soon as possible as I need it for my graduation project.

Hey I've fixed the import issue. It should work now.
Sample URL: /auth/realms//userapi-rest/users/search-by-attr?attr=merchant_id&value=1

Thank you very much! it is working now


add labels to cronjob pod template

Signed-off-by: yeya24<EMAIL_ADDRESS>fixes #697

Looks good! The only thing missing is a test, to make sure the expected labels can be found on both expected places.

Sure, I will add it ASAP

Looks good! The only thing missing is a test, to make sure the expected labels can be found on both expected places.

@jpkrohling Could you please check if this is OK? Thank you very much.

Seems the install-docker script has some problems...

I started the failed checks again. Once it passes, I'll merge it.

@yeya24 thanks for your PR!


Minimize utillib and people lib code

Remove all utillib and people lib code that is not needed.

Closing this for now. Removed most of it, still some could be removed but the important parts I wanted removed are.


saporro 2 still has DOWNLOAD_CODES

I think we cleaned DOWNLOAD_CODES from the codes, library saporro 2 still has it..

Right!
There are still a number of other codes (Bonsai2, Krome, Mocassin, Mpiamrvac, Rebound, Sakura and Tupan) that also still have it.


Misleading error message when using outdated OpenStack token

the REST API responds with Resource not found although an authentication error prevents access to the service catalog. The log message reads INFO: Request with wrong credentials from curl/7.54.0: Resource not found

fixed


Replay Stats not loading for custom maps

When trying to access Stats class in replay files on custom maps I get null pointer exception error:
Unhandled exception. System.NullReferenceException: Object reference not set to an instance of an object.

Example file:
custom.replay.zip

Stats is an event (AthenaMatchStats) from Fornite replays. so not something custom we've build.
If it is null, it means it wasnt an event in the replay. So I guess Fortnite will not send this event for custom game mode.


Soundcloud appears to be broken  - error 401

youtube-dl "https://soundcloud.com/feintdnb/we-wont-be-alone-feat-laura-brehm-mc-master" --verbose
[debug] System config: []
[debug] User config: []
[debug] Command-line args: [u'https://soundcloud.com/feintdnb/we-wont-be-alone-feat-laura-brehm-mc-master', u'--verbose']
[debug] Encodings: locale UTF-8, fs UTF-8, out UTF-8, pref UTF-8
[debug] youtube-dl version 2015.09.09
[debug] Python version 2.7.10 - Linux-4.2.0-gentoo-x86_64-AMD_A10-6700_APU_with_Radeon-tm-_HD_Graphics-with-gentoo-2.2
[debug] exe versions: ffmpeg 2.8, ffprobe 2.8, rtmpdump 2.4
[debug] Proxy map: {}
[soundcloud] feintdnb/we-wont-be-alone-feat-laura-brehm-mc-master: Resolving id
[soundcloud] feintdnb/we-wont-be-alone-feat-laura-brehm-mc-master: Downloading info JSON
ERROR: Unable to download JSON metadata: HTTP Error 401: Unauthorized (caused by HTTPError()); please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; see  https://yt-dl.org/update  on how to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
File "/usr/lib64/python2.7/site-packages/youtube_dl/extractor/common.py", line 326, in _request_webpage
return self._downloader.urlopen(url_or_request)
File "/usr/lib64/python2.7/site-packages/youtube_dl/YoutubeDL.py", line 1865, in urlopen
return self._opener.open(req, timeout=self._socket_timeout)
File "/usr/lib64/python2.7/urllib2.py", line 437, in open
response = meth(req, response)
File "/usr/lib64/python2.7/urllib2.py", line 550, in http_response
'http', request, response, code, msg, hdrs)
File "/usr/lib64/python2.7/urllib2.py", line 475, in error
return self._call_chain(*args)
File "/usr/lib64/python2.7/urllib2.py", line 409, in _call_chain
result = func(*args)
File "/usr/lib64/python2.7/urllib2.py", line 558, in http_error_default
raise HTTPError(req.get_full_url(), code, msg, hdrs, fp)

#6930

Thanks @clancye. @yoshi314 This is fixed but not included in the latest release yet. Please wait for the next version or try the latest git tarball.

@yan12125 thanks! All good now.

@clancye @yan12125  How does one actually use that tarball? I can't get ./bin/youtube-dl to do anything other than spit out
Traceback (most recent call last):
File "youtube-dl", line 3, in
import youtube_dl
ImportError: No module named youtube_dl

@zampl1cg just go to the youtube-dl-master directory and run the exec from there. If you're in the terminal it will just be ./youtube-dl URL_HERE

@clancye Maybe I'm going crazy but that file doesn't exist in https://github.com/rg3/youtube-dl/archive/master.zip
$ tree youtube-dl-master/ |grep youtube-dl
youtube-dl-master/
│   └── youtube-dl
└── youtube-dl.plugin.zsh

@zampl1cg That's weird.  I'm running OSX but that shouldn't change the file structure. I don't know what to tell you =[

@clancye can you re-download that master.zip, and "ls youtube-dl-master/" I'm telling you its not there.
$ ls youtube-dl-master/
AUTHORS          devscripts  Makefile     setup.cfg  tox.ini
bin              docs        MANIFEST.in setup.py   youtube_dl
CONTRIBUTING.md  LICENSE     README.md    test       youtube-dl.plugin.zsh

Running ./youtube_dl/__main__.py or python -m youtube_dl should work.

Its confusing as a noob. Thanks yan12125. Here is the easy steps:

Download https://github.com/rg3/youtube-dl/archive/master.zip
In cmd prompt "\youtube_dl_main_.py"
Wait for the new .exe to come out


Fix integration tests in Xcode 16

API deprecation?

Actually the opposite, I was using new API and with proper deployment targets in #570 it all has broken.


[cordova][XWALK-2941] update cases to support shared mode scene

Update auto cases to support shared mode scene
Update description for some manual cases
Failure analysis:XWALK-3956

Impacted tests(approved): new 0, update 11, delete 0
Unit test platform: [Android]
Unit test result summary: pass 8, fail 3, block 0

Why there are blocked tests? What are the block reason?

LGTM


arrow expression methods

closes #58

I left some tests failing based on thinking we should use SpaceBrace for Methods etc. If true, we'll need to finish up https://github.com/belav/csharpier/issues/34 before we can finish this up.


Fix issues with worker receive

Purpose
$title.
Fixes https://github.com/ballerina-platform/ballerina-lang/issues/18162 - Type checking issues in worker receive for sync send
Fixes https://github.com/ballerina-platform/ballerina-lang/issues/19389 - Bad, sad error when incorrectly using checkpanic with a worker receive that does not evaluate to error
Check List

[x] Read the Contributing Guide
[ ] Required Balo version update
[ ] Updated Change Log
[ ] Checked Tooling Support (#)
[x] Added necessary tests

[x] Unit Tests
[ ] Spec Conformance Tests
[ ] Integration Tests
[ ] Ballerina By Example Tests

[ ] Increased Test Coverage
[ ] Added necessary documentation

[ ] API documentation
[ ] Module documentation in Module.md files
[ ] Ballerina By Examples

Codecov Report

Merging #19491 into ballerina-1.0.x will not change coverage.
The diff coverage is n/a.

@@               Coverage Diff                @@
##           ballerina-1.0.x   #19491   +/-   ##
================================================
  Coverage            15.73%   15.73%
================================================
  Files                   47       47
  Lines                 1265     1265
  Branches               197      197
================================================
  Hits                   199      199
  Misses                1053     1053
  Partials                13       13

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 625faea...fd463d3. Read the comment docs.


Update identifier rules

Fixes #1737
Hint that you can use double-quotes to preserve case-sensitivity
in database, table, view, and column names.
@knz, is this sufficient, or should we also add notes to CREATE DATABASE, CREATE TABLE, etc.?

This change is

http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/defeb955cab4f6c844208f920ba9191baa0a48a1/

this seems sufficient to me.
LGTM


global tags on same path from different locations doesn't work

If you create namespaces with global tags on same path, all metrics created under those namespaces use only one set of tags.

I think that was actually the expected behavior, and the idea was that you shouldn't be creating multiple namespaces with the same path.


Hide graph tab

Coverage remained the same at 57.206% when pulling 2abe168c3807338ac1b07cf515fca504ea2f431b on cwhitten/hide-graph-tab into 83b261330d8cae88e2a16b1446d07e1434b4e558 on master.

I think the license reporter bugged out, so I'm going to merge it.


Ref table versioning : Datasync on certain tables

I am currently versioning the entire fixture.
The ref table updates are not currently going under any versioning.

Addressed in 1.2.3.


add_entity_robot does not show entity, outdated?

I got the resource & behavior packs from https://github.com/microsoft/minecraft-samples/tree/main/add_entity_robot installed in minecraft
I am able to add the packs to a new world without issue, but when I try to summon the sample robot or find the spawn egg in creative, nothing shows up
Is there something missing from the json files which is now a requirement in the latest version of bedrock, causing the entity to not appear?

Found the issue; have to add it both as a resource pack & behavior pack, because the 2 are not linked together via dependencies


Trouble connecting to Playbulb Rainbow

I'm having trouble connecting to a Playbulb Rainbow and am hoping someone might be able to help - not really sure who else to ask.
I can see the device with hcitool lescan, but when I try to connect with gatttool I get "connect error: Host is down (112)". I get this either connecting interactively or just sending a command.
I also tried updating Bluez to the latest version, but then I get a connection refused error. This error comes back so quickly that I'm not sure it's actually trying to connect.
I tried reseting the bulb to factory, which seemed to work because the name changed. But other than that I'm not sure what to try.
Any suggestions would be greatly appreciated. Thanks very much!

What OS is this, and what version of it and BlueZ are you using?

Thanks for the reply. I tried a fresh install of Raspbian Jessie and Buez 5.23 (just did an apt-get install bluez). Now it's working! Thanks for figuring this out.


MSC2261: Allow m.room.aliases events to be redacted by room admins

Rendered

See https://github.com/matrix-org/matrix-doc/issues/625#issuecomment-540215275 for an example of why this would be nice to have

I think this is superceded by #2432.