keycloak: 17.0.1 -> 18.0.0

Description of changes
Update to version 18.0.0. Release notes available at https://www.keycloak.org/docs/latest/release_notes/index.html#keycloak-18-0-0.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

The nixos test fails for me, but I think it might just be the tidyup timing out. Unsure. Exception: action timed out after 900 seconds

The way the database port is configured changed in a backwards incompatible way in Keycloak 18: https://github.com/keycloak/keycloak/commit/7811f3721a2992739ffa24b855f5772d5a009df5. I have a fix you can pull in here: https://github.com/talyz/nixpkgs/commit/63e5826ac894f6e3b33d68c1c0615bace6bb2b80. With it, all tests pass for me.

@felixsinger could you cherry-pick this addition please :point_up:

@talyz Awesome. Thanks for looking into it! Would it be ok for you if I squash your patch into mine so that we don't merge a non-working patch? I will add a sign-off line for you.

Sure! Squash it and make me co-author of the commit if you want.


WIP: add dependency checks to linter

try to avoid things like: #873

Sure I can. But maybe we should even split the other PR into smaller pieces to get it reviewed/merded faster?


delete args2 of untar modules

Hi,
In the conf/modules.config file, the attribute ext.args2 for the UNTAR module is defined first, even though, according to the development standards, the ext.args attribute should be used firstly. Moreover, in modules/nf-core/untar, since task.ext.args has never been defined in the modules.config file, the line def args = task.ext.args ?: '' does not make sense. Therefore, I've removed the ext.args2 portion and standardized the use of ext.args, aligning it with the development standards.
Does this make sense? I'd like to submit a PR for this on the GitHub repo.
PR checklist

[ ✅] This comment contains a description of changes (with reason).

[✅ ] Make sure your code lints (nf-core lint).

HI @dxu104 ! Thanks for the PR and apologies for the delay in responding. As far as I remember, this was an intentional change because tar required a positional argument for --no-same-owner in that position which is why I implemented it this way. I will close this PR for now but in the future, given that this is an nf-core module you will need to make the changes to the module code on nf-core/modules and then we can re-install it here in the pipeline. Thanks again!


Class 'AbstractPicoPlugin' not found

I just recieved this error message and apparently my picco installation is now not working with any plug in.
I'm running pico inside '/vendor/picocms/pico/' on localhost just to test if it could be possible to implement it as a basic catalogue site cms.
I installed two plug ins, Pico Tags and Pico Editor by copying their files inside the pico/plugin folders. Nothing went wrong when installing Pico Tags since I only needed to copy a single file, yet in order to install PicoEditor I copied the hole folder into pico/plugins (Meaning I created a pico/plugins/PicoEditor folder) and added a few lines in config.php.
$config['PicoEditor'] = array(
    'enabled' => true,
    'password' => '[..my very own SHA-512 generated password..]'
);

Afterwards the following message appeared:
Fatal error: Class 'AbstractPicoPlugin' not found in C:\xampp\htdocs\jjc\vendor\picocms\pico\plugins\PicoEditor\PicoEditor.php on line 28
Now when I delete the PicoEditor folder I get a similar error
Fatal error: Class 'AbstractPicoPlugin' not found in C:\xampp\htdocs\jjc\vendor\picocms\pico\plugins\PicoTags.php on line 24
Ps:
I've also tryed copying all the content of the PicoEditor folder directly inside pico/plugins without any successful result either.
I can only delete both to preview the default pico front page, but I'm afraid I really need those plugins :(
Ps2: Sorry for such a long post.

Can you please provide us the contents of the files composer.lock, vendor/composer/autoload_namespaces.php and vendor/composer/installed.json?

Yes of course. This is composer.lock
{
    "_readme": [
        "This file locks the dependencies of your project to a known state",
        "Read more about it at https://getcomposer.org/doc/01-basic-usage.md#composer-lock-the-lock-file",
        "This file is @generated automatically"
    ],
    "hash": "84806675447f7a95d4f79cc45d928128",
    "content-hash": "445c22d963668182069bdfef2ec49989",
    "packages": [
        {
            "name": "michelf/php-markdown",
            "version": "1.3",
            "source": {
                "type": "git",
                "url": "https://github.com/michelf/php-markdown.git",
                "reference": "fcdd3e0781ae40c2b9847874e0755ff4f5559688"
            },
            "dist": {
                "type": "zip",
                "url": "https://api.github.com/repos/michelf/php-markdown/zipball/fcdd3e0781ae40c2b9847874e0755ff4f5559688",
                "reference": "fcdd3e0781ae40c2b9847874e0755ff4f5559688",
                "shasum": ""
            },
            "require": {
                "php": ">=5.3.0"
            },
            "type": "library",
            "extra": {
                "branch-alias": {
                    "dev-lib": "1.3.x-dev"
                }
            },
            "autoload": {
                "psr-0": {
                    "Michelf": ""
                }
            },
            "notification-url": "https://packagist.org/downloads/",
            "license": [
                "BSD-3-Clause"
            ],
            "authors": [
                {
                    "name": "Michel Fortin",
                    "email"<EMAIL_ADDRESS>                    "homepage": "http://michelf.ca/",
                    "role": "Developer"
                },
                {
                    "name": "John Gruber",
                    "homepage": "http://daringfireball.net/"
                }
            ],
            "description": "PHP Markdown",
            "homepage": "http://michelf.ca/projects/php-markdown/",
            "keywords": [
                "markdown"
            ],
            "time": "2013-04-11 18:53:11"
        },
        {
            "name": "nikic/fast-route",
            "version": "v0.6.0",
            "source": {
                "type": "git",
                "url": "https://github.com/nikic/FastRoute.git",
                "reference": "31fa86924556b80735f98b294a7ffdfb26789f22"
            },
            "dist": {
                "type": "zip",
                "url": "https://api.github.com/repos/nikic/FastRoute/zipball/31fa86924556b80735f98b294a7ffdfb26789f22",
                "reference": "31fa86924556b80735f98b294a7ffdfb26789f22",
                "shasum": ""
            },
            "require": {
                "php": ">=5.4.0"
            },
            "type": "library",
            "autoload": {
                "psr-4": {
                    "FastRoute\\": "src/"
                },
                "files": [
                    "src/functions.php"
                ]
            },
            "notification-url": "https://packagist.org/downloads/",
            "license": [
                "BSD-3-Clause"
            ],
            "authors": [
                {
                    "name": "Nikita Popov",
                    "email"<EMAIL_ADDRESS>                }
            ],
            "description": "Fast request router for PHP",
            "keywords": [
                "router",
                "routing"
            ],
            "time": "2015-06-18 19:15:47"
        },
        {
            "name": "picocms/pico",
            "version": "v0.9",
            "source": {
                "type": "git",
                "url": "https://github.com/picocms/Pico.git",
                "reference": "4ef01ecc22d90f763535a15adce36f85cf621c28"
            },
            "dist": {
                "type": "zip",
                "url": "https://api.github.com/repos/picocms/Pico/zipball/4ef01ecc22d90f763535a15adce36f85cf621c28",
                "reference": "4ef01ecc22d90f763535a15adce36f85cf621c28",
                "shasum": ""
            },
            "require": {
                "michelf/php-markdown": "1.3",
                "php": ">=5.2.4",
                "twig/twig": "1.18.*"
            },
            "type": "library",
            "autoload": {
                "files": [
                    "lib/pico.php"
                ]
            },
            "notification-url": "https://packagist.org/downloads/",
            "license": [
                "MIT"
            ],
            "authors": [
                {
                    "name": "Gilbert Pellegrom",
                    "email"<EMAIL_ADDRESS>                }
            ],
            "description": "Pico is a flat file CMS, this means there is no administration backend and database to deal with. You simply create .md files in the \"content\" folder and that becomes a page.",
            "homepage": "http://picocms.org/",
            "keywords": [
                "cms"
            ],
            "time": "2015-04-29 02:50:41"
        },
        {
            "name": "twig/twig",
            "version": "v1.18.2",
            "source": {
                "type": "git",
                "url": "https://github.com/twigphp/Twig.git",
                "reference": "e8e6575abf6102af53ec283f7f14b89e304fa602"
            },
            "dist": {
                "type": "zip",
                "url": "https://api.github.com/repos/twigphp/Twig/zipball/e8e6575abf6102af53ec283f7f14b89e304fa602",
                "reference": "e8e6575abf6102af53ec283f7f14b89e304fa602",
                "shasum": ""
            },
            "require": {
                "php": ">=5.2.7"
            },
            "type": "library",
            "extra": {
                "branch-alias": {
                    "dev-master": "1.18-dev"
                }
            },
            "autoload": {
                "psr-0": {
                    "Twig_": "lib/"
                }
            },
            "notification-url": "https://packagist.org/downloads/",
            "license": [
                "BSD-3-Clause"
            ],
            "authors": [
                {
                    "name": "Fabien Potencier",
                    "email"<EMAIL_ADDRESS>                    "homepage": "http://fabien.potencier.org",
                    "role": "Lead Developer"
                },
                {
                    "name": "Armin Ronacher",
                    "email"<EMAIL_ADDRESS>                    "role": "Project Founder"
                },
                {
                    "name": "Twig Team",
                    "homepage": "http://twig.sensiolabs.org/contributors",
                    "role": "Contributors"
                }
            ],
            "description": "Twig, the flexible, fast, and secure template language for PHP",
            "homepage": "http://twig.sensiolabs.org",
            "keywords": [
                "templating"
            ],
            "time": "2015-06-06 23:31:24"
        }
    ],
    "packages-dev": [],
    "aliases": [],
    "minimum-stability": "stable",
    "stability-flags": [],
    "prefer-stable": false,
    "prefer-lowest": false,
    "platform": [],
    "platform-dev": []
}

autoload_namespaces.php
<?php

// autoload_namespaces.php @generated by Composer

$vendorDir = dirname(dirname(__FILE__));
$baseDir = dirname($vendorDir);

return array(
    'Twig_' => array($vendorDir . '/twig/twig/lib'),
    'Michelf' => array($vendorDir . '/michelf/php-markdown'),
);

ínstalled.json
[
    {
        "name": "michelf/php-markdown",
        "version": "1.3",
        "version_normalized": "<IP_ADDRESS>",
        "source": {
            "type": "git",
            "url": "https://github.com/michelf/php-markdown.git",
            "reference": "fcdd3e0781ae40c2b9847874e0755ff4f5559688"
        },
        "dist": {
            "type": "zip",
            "url": "https://api.github.com/repos/michelf/php-markdown/zipball/fcdd3e0781ae40c2b9847874e0755ff4f5559688",
            "reference": "fcdd3e0781ae40c2b9847874e0755ff4f5559688",
            "shasum": ""
        },
        "require": {
            "php": ">=5.3.0"
        },
        "time": "2013-04-11 18:53:11",
        "type": "library",
        "extra": {
            "branch-alias": {
                "dev-lib": "1.3.x-dev"
            }
        },
        "installation-source": "dist",
        "autoload": {
            "psr-0": {
                "Michelf": ""
            }
        },
        "notification-url": "https://packagist.org/downloads/",
        "license": [
            "BSD-3-Clause"
        ],
        "authors": [
            {
                "name": "Michel Fortin",
                "email"<EMAIL_ADDRESS>                "homepage": "http://michelf.ca/",
                "role": "Developer"
            },
            {
                "name": "John Gruber",
                "homepage": "http://daringfireball.net/"
            }
        ],
        "description": "PHP Markdown",
        "homepage": "http://michelf.ca/projects/php-markdown/",
        "keywords": [
            "markdown"
        ]
    },
    {
        "name": "twig/twig",
        "version": "v1.18.2",
        "version_normalized": "<IP_ADDRESS>",
        "source": {
            "type": "git",
            "url": "https://github.com/twigphp/Twig.git",
            "reference": "e8e6575abf6102af53ec283f7f14b89e304fa602"
        },
        "dist": {
            "type": "zip",
            "url": "https://api.github.com/repos/twigphp/Twig/zipball/e8e6575abf6102af53ec283f7f14b89e304fa602",
            "reference": "e8e6575abf6102af53ec283f7f14b89e304fa602",
            "shasum": ""
        },
        "require": {
            "php": ">=5.2.7"
        },
        "time": "2015-06-06 23:31:24",
        "type": "library",
        "extra": {
            "branch-alias": {
                "dev-master": "1.18-dev"
            }
        },
        "installation-source": "dist",
        "autoload": {
            "psr-0": {
                "Twig_": "lib/"
            }
        },
        "notification-url": "https://packagist.org/downloads/",
        "license": [
            "BSD-3-Clause"
        ],
        "authors": [
            {
                "name": "Fabien Potencier",
                "email"<EMAIL_ADDRESS>                "homepage": "http://fabien.potencier.org",
                "role": "Lead Developer"
            },
            {
                "name": "Armin Ronacher",
                "email"<EMAIL_ADDRESS>                "role": "Project Founder"
            },
            {
                "name": "Twig Team",
                "homepage": "http://twig.sensiolabs.org/contributors",
                "role": "Contributors"
            }
        ],
        "description": "Twig, the flexible, fast, and secure template language for PHP",
        "homepage": "http://twig.sensiolabs.org",
        "keywords": [
            "templating"
        ]
    },
    {
        "name": "picocms/pico",
        "version": "v0.9",
        "version_normalized": "<IP_ADDRESS>",
        "source": {
            "type": "git",
            "url": "https://github.com/picocms/Pico.git",
            "reference": "4ef01ecc22d90f763535a15adce36f85cf621c28"
        },
        "dist": {
            "type": "zip",
            "url": "https://api.github.com/repos/picocms/Pico/zipball/4ef01ecc22d90f763535a15adce36f85cf621c28",
            "reference": "4ef01ecc22d90f763535a15adce36f85cf621c28",
            "shasum": ""
        },
        "require": {
            "michelf/php-markdown": "1.3",
            "php": ">=5.2.4",
            "twig/twig": "1.18.*"
        },
        "time": "2015-04-29 02:50:41",
        "type": "library",
        "installation-source": "dist",
        "autoload": {
            "files": [
                "lib/pico.php"
            ]
        },
        "notification-url": "https://packagist.org/downloads/",
        "license": [
            "MIT"
        ],
        "authors": [
            {
                "name": "Gilbert Pellegrom",
                "email"<EMAIL_ADDRESS>            }
        ],
        "description": "Pico is a flat file CMS, this means there is no administration backend and database to deal with. You simply create .md files in the \"content\" folder and that becomes a page.",
        "homepage": "http://picocms.org/",
        "keywords": [
            "cms"
        ]
    },
    {
        "name": "nikic/fast-route",
        "version": "v0.6.0",
        "version_normalized": "<IP_ADDRESS>",
        "source": {
            "type": "git",
            "url": "https://github.com/nikic/FastRoute.git",
            "reference": "31fa86924556b80735f98b294a7ffdfb26789f22"
        },
        "dist": {
            "type": "zip",
            "url": "https://api.github.com/repos/nikic/FastRoute/zipball/31fa86924556b80735f98b294a7ffdfb26789f22",
            "reference": "31fa86924556b80735f98b294a7ffdfb26789f22",
            "shasum": ""
        },
        "require": {
            "php": ">=5.4.0"
        },
        "time": "2015-06-18 19:15:47",
        "type": "library",
        "installation-source": "dist",
        "autoload": {
            "psr-4": {
                "FastRoute\\": "src/"
            },
            "files": [
                "src/functions.php"
            ]
        },
        "notification-url": "https://packagist.org/downloads/",
        "license": [
            "BSD-3-Clause"
        ],
        "authors": [
            {
                "name": "Nikita Popov",
                "email"<EMAIL_ADDRESS>            }
        ],
        "description": "Fast request router for PHP",
        "keywords": [
            "router",
            "routing"
        ]
    }
]

Hmm... composer installed Pico v0.9 instead of the current v1.0.0-beta.1. Can you please also provide your composer.json? When did you run this installation?

{
    "name": "picocms/pico",
    "type": "library",
    "description": "Pico is a flat file CMS, this means there is no administration backend and database to deal with. You simply create .md files in the \"content\" folder and that becomes a page.",
    "keywords": ["cms"],
    "homepage": "http://picocms.org/",
    "license": "MIT",
    "authors": [
        {
            "name": "Gilbert Pellegrom",
            "email"<EMAIL_ADDRESS>        }
    ],
    "require": {
        "php": ">=5.2.4",
        "twig/twig": "1.18.*",
        "michelf/php-markdown": "1.3"
    },
    "autoload": {
        "files": ["lib/pico.php"]
    }
}

ps: I just installed it today in my computer with php composer.phar require picocms/pico

I don't mean Pico's composer.json at vendor/pico/picocms/composer.json, I mean your custom (root) composer.json.

Oh, sorry :dizzy_face:
{
    "require": {
        "picocms/pico": "^0.9.0",
        "nikic/fast-route": "^0.6.0"
    }
}

There it is :wink:
You can't use plugins for Pico 1.0 with Pico 0.9 and older. We highly recommend you to upgrade to the current v1.0.0-beta.1.

Thanks for the help !


Change diceroll array declaration

In Game class
Change diceroll array declaration from C-style to C++ style or use a std::pair

change diceroll declaration to std::pair<int, int>


feat(headless): expose logCustomEvent via loader function

While refactoring to expose analytics actions via loader functions, I left out certain lower level actions like logClickEvent and logSearchEvent since there are higher level actions that can be used instead (if there is a need to expose the low-level action, please let me know).
On the other hand, logCustomEvent would be useful to a dev wanting to send additional information, This PR exposes the action using the new loader function approach.

We certainly need to expose logClickEvent and logSearchEvent.
It's certainly possible that someone would want to have a random button in their app for which they want to track a click event.
Or that they would want to create a completely new type of UI component (let's say: A map, or a calendar), for which they would like to track search events that are not part of "the standard".
As such, it is mandatory that we let them dispatch the low level click and search actions.


reproduction problem

I just run the code without any change and find the initial recall scores is as follow:
Recall Scores:
top-1           1.2%
top-5           4.6%
top-10          8.7%
then I continue the training process util the generation1 epoch2 with the recall score:
Recall Scores:
top-1           1.4%
top-5           6.3%
top-10         11.9%

Finished generation   1 epoch   2 recall@1:  1.4%  recall@5:  6.3%  recall@10: 11.9%  best@5:  7.7%
it seems no obvious promotion, is that right?

It seems totally failed. I did not meet this problem before. Did you load all pre-trained weights as instructed?

It seems totally failed. I did not meet this problem before. Did you load all pre-trained weights as instructed?

yes, i load the pre-trained weights and besides i test the best model on pitts 30k that you provide (https://drive.google.com/drive/folders/1FLjxFhKRO-YJQ6FI-DcCMMHDL2K_Hsof) , the score is :
Recall Scores:
top-1           1.3%
top-5           5.0%
top-10          9.7%
is there something wrong?

I cannot locate your issue. Maybe provide your full testing log could help.

I cannot locate your issue. Maybe provide your full testing log could help.

this is the log of first evaluation of my initial model:
Args:Namespace(arch='vgg16', cache_size=1000, data_dir='/data/yangling/datasets', dataset='pitts', deterministic=False, epochs=5, eval_step=1, features=4096, generations=4, gpu=0, height=480, init_dir='/data/yangling/openIBL/examples/../logs', iters=0, launcher='pytorch', layers='conv5', logs_dir='logs/netVLAD/pitts30k-vgg16/conv5-sare_ind-lr0.001-tuple1-SFRS', loss_type='sare_ind', lr=0.001, margin=0.1, momentum=0.9, neg_num=10, neg_pool=1000, ngpus_per_node=1, nowhiten=False, num_clusters=64, pos_num=10, pos_pool=20, print_freq=10, rank=0, resume='', scale='30k', seed=43, soft_weight=0.5, step_size=5, sync_gather=False, syncbn=True, tcp_port='19294', temperature=[0.07, 0.07, 0.06, 0.05], test_batch_size=8, tuple_size=1, weight_decay=0.001, width=640, workers=2, world_size=1)
Pittsburgh dataset loaded
subset        | # pids | # images
train_query   |   311  |     7320
train_gallery |   417  |    10000
val_query     |   319  |     7608
val_gallery   |   417  |    10000
test_query    |   286  |     6816
test_gallery  |   417  |    10000
Loading centroids from /data/yangling/openIBL/examples/../logs/vgg16_pitts_64_desc_cen.hdf5
Loading centroids from /data/yangling/openIBL/examples/../logs/vgg16_pitts_64_desc_cen.hdf5
Test the initial model:
Extract Features: [10/2201]	Time 0.124 (0.506)	Data 0.000 (0.282)
Extract Features: [20/2201]	Time 0.123 (0.315)	Data 0.000 (0.141)
Extract Features: [30/2201]	Time 0.124 (0.251)	Data 0.000 (0.094)
Extract Features: [40/2201]	Time 0.123 (0.219)	Data 0.000 (0.071)
Extract Features: [50/2201]	Time 0.125 (0.200)	Data 0.000 (0.057)
Extract Features: [60/2201]	Time 0.124 (0.188)	Data 0.000 (0.047)
Extract Features: [70/2201]	Time 0.124 (0.179)	Data 0.000 (0.040)
Extract Features: [80/2201]	Time 0.125 (0.172)	Data 0.000 (0.035)
Extract Features: [90/2201]	Time 0.124 (0.167)	Data 0.000 (0.031)
Extract Features: [100/2201]	Time 0.125 (0.163)	Data 0.000 (0.028)
Extract Features: [110/2201]	Time 0.125 (0.159)	Data 0.000 (0.026)
Extract Features: [120/2201]	Time 0.125 (0.156)	Data 0.000 (0.024)
Extract Features: [130/2201]	Time 0.126 (0.154)	Data 0.000 (0.022)
Extract Features: [140/2201]	Time 0.125 (0.152)	Data 0.000 (0.020)
Extract Features: [150/2201]	Time 0.125 (0.150)	Data 0.000 (0.019)
Extract Features: [160/2201]	Time 0.125 (0.149)	Data 0.000 (0.018)
Extract Features: [170/2201]	Time 0.126 (0.147)	Data 0.000 (0.017)
Extract Features: [180/2201]	Time 0.126 (0.146)	Data 0.000 (0.016)
Extract Features: [190/2201]	Time 0.125 (0.145)	Data 0.000 (0.015)
Extract Features: [200/2201]	Time 0.125 (0.144)	Data 0.000 (0.014)
Extract Features: [210/2201]	Time 0.125 (0.144)	Data 0.000 (0.014)
Extract Features: [220/2201]	Time 0.126 (0.143)	Data 0.000 (0.013)
Extract Features: [230/2201]	Time 0.126 (0.142)	Data 0.000 (0.012)
Extract Features: [240/2201]	Time 0.129 (0.141)	Data 0.000 (0.012)
Extract Features: [250/2201]	Time 0.126 (0.141)	Data 0.000 (0.011)
Extract Features: [260/2201]	Time 0.129 (0.140)	Data 0.000 (0.011)
Extract Features: [270/2201]	Time 0.126 (0.140)	Data 0.000 (0.011)
Extract Features: [280/2201]	Time 0.127 (0.139)	Data 0.000 (0.010)
Extract Features: [290/2201]	Time 0.128 (0.139)	Data 0.000 (0.010)
Extract Features: [300/2201]	Time 0.132 (0.139)	Data 0.000 (0.010)
Extract Features: [310/2201]	Time 0.127 (0.138)	Data 0.000 (0.009)
Extract Features: [320/2201]	Time 0.128 (0.138)	Data 0.000 (0.009)
Extract Features: [330/2201]	Time 0.129 (0.138)	Data 0.000 (0.009)
Extract Features: [340/2201]	Time 0.127 (0.137)	Data 0.000 (0.008)
Extract Features: [350/2201]	Time 0.127 (0.137)	Data 0.000 (0.008)
Extract Features: [360/2201]	Time 0.127 (0.137)	Data 0.000 (0.008)
Extract Features: [370/2201]	Time 0.134 (0.137)	Data 0.000 (0.008)
Extract Features: [380/2201]	Time 0.127 (0.136)	Data 0.000 (0.008)
Extract Features: [390/2201]	Time 0.127 (0.136)	Data 0.000 (0.007)
Extract Features: [400/2201]	Time 0.130 (0.136)	Data 0.000 (0.007)
Extract Features: [410/2201]	Time 0.130 (0.136)	Data 0.000 (0.007)
Extract Features: [420/2201]	Time 0.131 (0.136)	Data 0.000 (0.007)
Extract Features: [430/2201]	Time 0.128 (0.135)	Data 0.000 (0.007)
Extract Features: [440/2201]	Time 0.128 (0.135)	Data 0.000 (0.007)
Extract Features: [450/2201]	Time 0.128 (0.135)	Data 0.000 (0.006)
Extract Features: [460/2201]	Time 0.128 (0.135)	Data 0.000 (0.006)
Extract Features: [470/2201]	Time 0.127 (0.135)	Data 0.000 (0.006)
Extract Features: [480/2201]	Time 0.128 (0.135)	Data 0.000 (0.006)
Extract Features: [490/2201]	Time 0.128 (0.135)	Data 0.000 (0.006)
Extract Features: [500/2201]	Time 0.128 (0.135)	Data 0.000 (0.006)
Extract Features: [510/2201]	Time 0.129 (0.134)	Data 0.000 (0.006)
Extract Features: [520/2201]	Time 0.129 (0.134)	Data 0.000 (0.006)
Extract Features: [530/2201]	Time 0.129 (0.134)	Data 0.000 (0.005)
Extract Features: [540/2201]	Time 0.129 (0.134)	Data 0.000 (0.005)
Extract Features: [550/2201]	Time 0.129 (0.134)	Data 0.000 (0.005)
Extract Features: [560/2201]	Time 0.131 (0.134)	Data 0.000 (0.005)
Extract Features: [570/2201]	Time 0.132 (0.134)	Data 0.000 (0.005)
Extract Features: [580/2201]	Time 0.137 (0.134)	Data 0.000 (0.005)
Extract Features: [590/2201]	Time 0.129 (0.134)	Data 0.000 (0.005)
Extract Features: [600/2201]	Time 0.131 (0.134)	Data 0.000 (0.005)
Extract Features: [610/2201]	Time 0.129 (0.134)	Data 0.000 (0.005)
Extract Features: [620/2201]	Time 0.130 (0.134)	Data 0.000 (0.005)
Extract Features: [630/2201]	Time 0.131 (0.133)	Data 0.000 (0.005)
Extract Features: [640/2201]	Time 0.129 (0.133)	Data 0.000 (0.005)
Extract Features: [650/2201]	Time 0.130 (0.133)	Data 0.000 (0.004)
Extract Features: [660/2201]	Time 0.130 (0.133)	Data 0.000 (0.004)
Extract Features: [670/2201]	Time 0.129 (0.133)	Data 0.000 (0.004)
Extract Features: [680/2201]	Time 0.133 (0.133)	Data 0.000 (0.004)
Extract Features: [690/2201]	Time 0.142 (0.133)	Data 0.000 (0.004)
Extract Features: [700/2201]	Time 0.128 (0.133)	Data 0.000 (0.004)
Extract Features: [710/2201]	Time 0.128 (0.133)	Data 0.000 (0.004)
Extract Features: [720/2201]	Time 0.129 (0.133)	Data 0.000 (0.004)
Extract Features: [730/2201]	Time 0.129 (0.133)	Data 0.000 (0.004)
Extract Features: [740/2201]	Time 0.129 (0.133)	Data 0.000 (0.004)
Extract Features: [750/2201]	Time 0.129 (0.133)	Data 0.000 (0.004)
Extract Features: [760/2201]	Time 0.129 (0.133)	Data 0.000 (0.004)
Extract Features: [770/2201]	Time 0.132 (0.133)	Data 0.000 (0.004)
Extract Features: [780/2201]	Time 0.130 (0.133)	Data 0.000 (0.004)
Extract Features: [790/2201]	Time 0.139 (0.133)	Data 0.000 (0.004)
Extract Features: [800/2201]	Time 0.130 (0.133)	Data 0.000 (0.004)
Extract Features: [810/2201]	Time 0.130 (0.133)	Data 0.000 (0.004)
Extract Features: [820/2201]	Time 0.128 (0.133)	Data 0.000 (0.004)
Extract Features: [830/2201]	Time 0.142 (0.133)	Data 0.000 (0.004)
Extract Features: [840/2201]	Time 0.131 (0.133)	Data 0.000 (0.003)
Extract Features: [850/2201]	Time 0.129 (0.133)	Data 0.000 (0.003)
Extract Features: [860/2201]	Time 0.134 (0.133)	Data 0.000 (0.003)
Extract Features: [870/2201]	Time 0.130 (0.133)	Data 0.000 (0.003)
Extract Features: [880/2201]	Time 0.131 (0.133)	Data 0.000 (0.003)
Extract Features: [890/2201]	Time 0.130 (0.133)	Data 0.000 (0.003)
Extract Features: [900/2201]	Time 0.130 (0.133)	Data 0.000 (0.003)
Extract Features: [910/2201]	Time 0.131 (0.133)	Data 0.000 (0.003)
Extract Features: [920/2201]	Time 0.129 (0.133)	Data 0.000 (0.003)
Extract Features: [930/2201]	Time 0.130 (0.133)	Data 0.000 (0.003)
Extract Features: [940/2201]	Time 0.129 (0.133)	Data 0.000 (0.003)
Extract Features: [950/2201]	Time 0.131 (0.132)	Data 0.000 (0.003)
Extract Features: [960/2201]	Time 0.130 (0.132)	Data 0.000 (0.003)
Extract Features: [970/2201]	Time 0.133 (0.132)	Data 0.000 (0.003)
Extract Features: [980/2201]	Time 0.131 (0.132)	Data 0.000 (0.003)
Extract Features: [990/2201]	Time 0.131 (0.132)	Data 0.000 (0.003)
Extract Features: [1000/2201]	Time 0.131 (0.132)	Data 0.000 (0.003)
Extract Features: [1010/2201]	Time 0.129 (0.132)	Data 0.000 (0.003)
Extract Features: [1020/2201]	Time 0.131 (0.132)	Data 0.000 (0.003)
Extract Features: [1030/2201]	Time 0.130 (0.132)	Data 0.000 (0.003)
Extract Features: [1040/2201]	Time 0.134 (0.132)	Data 0.000 (0.003)
Extract Features: [1050/2201]	Time 0.130 (0.132)	Data 0.000 (0.003)
Extract Features: [1060/2201]	Time 0.131 (0.132)	Data 0.000 (0.003)
Extract Features: [1070/2201]	Time 0.131 (0.132)	Data 0.000 (0.003)
Extract Features: [1080/2201]	Time 0.130 (0.132)	Data 0.000 (0.003)
Extract Features: [1090/2201]	Time 0.138 (0.132)	Data 0.000 (0.003)
Extract Features: [1100/2201]	Time 0.137 (0.132)	Data 0.000 (0.003)
Extract Features: [1110/2201]	Time 0.130 (0.132)	Data 0.000 (0.003)
Extract Features: [1120/2201]	Time 0.130 (0.132)	Data 0.000 (0.003)
Extract Features: [1130/2201]	Time 0.130 (0.132)	Data 0.000 (0.003)
Extract Features: [1140/2201]	Time 0.131 (0.132)	Data 0.000 (0.003)
Extract Features: [1150/2201]	Time 0.132 (0.132)	Data 0.000 (0.003)
Extract Features: [1160/2201]	Time 0.131 (0.132)	Data 0.000 (0.003)
Extract Features: [1170/2201]	Time 0.132 (0.132)	Data 0.000 (0.003)
Extract Features: [1180/2201]	Time 0.132 (0.132)	Data 0.000 (0.003)
Extract Features: [1190/2201]	Time 0.148 (0.132)	Data 0.000 (0.003)
Extract Features: [1200/2201]	Time 0.131 (0.132)	Data 0.000 (0.002)
Extract Features: [1210/2201]	Time 0.129 (0.132)	Data 0.000 (0.002)
Extract Features: [1220/2201]	Time 0.130 (0.132)	Data 0.000 (0.002)
Extract Features: [1230/2201]	Time 0.132 (0.132)	Data 0.000 (0.002)
Extract Features: [1240/2201]	Time 0.139 (0.132)	Data 0.000 (0.002)
Extract Features: [1250/2201]	Time 0.131 (0.132)	Data 0.000 (0.002)
Extract Features: [1260/2201]	Time 0.132 (0.132)	Data 0.000 (0.002)
Extract Features: [1270/2201]	Time 0.130 (0.132)	Data 0.000 (0.002)
Extract Features: [1280/2201]	Time 0.131 (0.132)	Data 0.000 (0.002)
Extract Features: [1290/2201]	Time 0.131 (0.132)	Data 0.000 (0.002)
Extract Features: [1300/2201]	Time 0.132 (0.132)	Data 0.000 (0.002)
Extract Features: [1310/2201]	Time 0.131 (0.132)	Data 0.000 (0.002)
Extract Features: [1320/2201]	Time 0.131 (0.132)	Data 0.000 (0.002)
Extract Features: [1330/2201]	Time 0.131 (0.132)	Data 0.000 (0.002)
Extract Features: [1340/2201]	Time 0.134 (0.132)	Data 0.000 (0.002)
Extract Features: [1350/2201]	Time 0.132 (0.132)	Data 0.000 (0.002)
Extract Features: [1360/2201]	Time 0.131 (0.132)	Data 0.000 (0.002)
Extract Features: [1370/2201]	Time 0.132 (0.132)	Data 0.000 (0.002)
Extract Features: [1380/2201]	Time 0.132 (0.132)	Data 0.000 (0.002)
Extract Features: [1390/2201]	Time 0.137 (0.132)	Data 0.000 (0.002)
Extract Features: [1400/2201]	Time 0.131 (0.132)	Data 0.000 (0.002)
Extract Features: [1410/2201]	Time 0.132 (0.132)	Data 0.000 (0.002)
Extract Features: [1420/2201]	Time 0.131 (0.132)	Data 0.000 (0.002)
Extract Features: [1430/2201]	Time 0.131 (0.132)	Data 0.000 (0.002)
Extract Features: [1440/2201]	Time 0.136 (0.132)	Data 0.000 (0.002)
Extract Features: [1450/2201]	Time 0.130 (0.132)	Data 0.000 (0.002)
Extract Features: [1460/2201]	Time 0.131 (0.132)	Data 0.000 (0.002)
Extract Features: [1470/2201]	Time 0.131 (0.132)	Data 0.000 (0.002)
Extract Features: [1480/2201]	Time 0.132 (0.132)	Data 0.000 (0.002)
Extract Features: [1490/2201]	Time 0.130 (0.132)	Data 0.000 (0.002)
Extract Features: [1500/2201]	Time 0.132 (0.132)	Data 0.000 (0.002)
Extract Features: [1510/2201]	Time 0.134 (0.132)	Data 0.000 (0.002)
Extract Features: [1520/2201]	Time 0.130 (0.132)	Data 0.000 (0.002)
Extract Features: [1530/2201]	Time 0.132 (0.132)	Data 0.000 (0.002)
Extract Features: [1540/2201]	Time 0.137 (0.132)	Data 0.000 (0.002)
Extract Features: [1550/2201]	Time 0.132 (0.132)	Data 0.000 (0.002)
Extract Features: [1560/2201]	Time 0.132 (0.132)	Data 0.000 (0.002)
Extract Features: [1570/2201]	Time 0.131 (0.132)	Data 0.000 (0.002)
Extract Features: [1580/2201]	Time 0.132 (0.132)	Data 0.000 (0.002)
Extract Features: [1590/2201]	Time 0.131 (0.132)	Data 0.000 (0.002)
Extract Features: [1600/2201]	Time 0.132 (0.132)	Data 0.000 (0.002)
Extract Features: [1610/2201]	Time 0.132 (0.132)	Data 0.000 (0.002)
Extract Features: [1620/2201]	Time 0.136 (0.132)	Data 0.000 (0.002)
Extract Features: [1630/2201]	Time 0.143 (0.132)	Data 0.000 (0.002)
Extract Features: [1640/2201]	Time 0.134 (0.132)	Data 0.000 (0.002)
Extract Features: [1650/2201]	Time 0.132 (0.132)	Data 0.000 (0.002)
Extract Features: [1660/2201]	Time 0.131 (0.132)	Data 0.000 (0.002)
Extract Features: [1670/2201]	Time 0.131 (0.132)	Data 0.000 (0.002)
Extract Features: [1680/2201]	Time 0.133 (0.132)	Data 0.000 (0.002)
Extract Features: [1690/2201]	Time 0.132 (0.132)	Data 0.000 (0.002)
Extract Features: [1700/2201]	Time 0.136 (0.132)	Data 0.000 (0.002)
Extract Features: [1710/2201]	Time 0.132 (0.132)	Data 0.000 (0.002)
Extract Features: [1720/2201]	Time 0.133 (0.132)	Data 0.000 (0.002)
Extract Features: [1730/2201]	Time 0.134 (0.132)	Data 0.000 (0.002)
Extract Features: [1740/2201]	Time 0.135 (0.132)	Data 0.000 (0.002)
Extract Features: [1750/2201]	Time 0.133 (0.132)	Data 0.000 (0.002)
Extract Features: [1760/2201]	Time 0.132 (0.132)	Data 0.000 (0.002)
Extract Features: [1770/2201]	Time 0.132 (0.132)	Data 0.000 (0.002)
Extract Features: [1780/2201]	Time 0.131 (0.132)	Data 0.000 (0.002)
Extract Features: [1790/2201]	Time 0.132 (0.132)	Data 0.000 (0.002)
Extract Features: [1800/2201]	Time 0.132 (0.132)	Data 0.000 (0.002)
Extract Features: [1810/2201]	Time 0.132 (0.132)	Data 0.000 (0.002)
Extract Features: [1820/2201]	Time 0.132 (0.132)	Data 0.000 (0.002)
Extract Features: [1830/2201]	Time 0.132 (0.132)	Data 0.000 (0.002)
Extract Features: [1840/2201]	Time 0.132 (0.132)	Data 0.000 (0.002)
Extract Features: [1850/2201]	Time 0.132 (0.132)	Data 0.000 (0.002)
Extract Features: [1860/2201]	Time 0.135 (0.132)	Data 0.000 (0.002)
Extract Features: [1870/2201]	Time 0.132 (0.132)	Data 0.000 (0.002)
Extract Features: [1880/2201]	Time 0.133 (0.132)	Data 0.000 (0.002)
Extract Features: [1890/2201]	Time 0.131 (0.132)	Data 0.000 (0.002)
Extract Features: [1900/2201]	Time 0.133 (0.132)	Data 0.000 (0.002)
Extract Features: [1910/2201]	Time 0.132 (0.132)	Data 0.000 (0.002)
Extract Features: [1920/2201]	Time 0.132 (0.132)	Data 0.000 (0.002)
Extract Features: [1930/2201]	Time 0.138 (0.132)	Data 0.000 (0.002)
Extract Features: [1940/2201]	Time 0.132 (0.133)	Data 0.000 (0.002)
Extract Features: [1950/2201]	Time 0.133 (0.133)	Data 0.000 (0.002)
Extract Features: [1960/2201]	Time 0.132 (0.133)	Data 0.000 (0.002)
Extract Features: [1970/2201]	Time 0.132 (0.133)	Data 0.000 (0.002)
Extract Features: [1980/2201]	Time 0.133 (0.133)	Data 0.000 (0.002)
Extract Features: [1990/2201]	Time 0.131 (0.133)	Data 0.000 (0.002)
Extract Features: [2000/2201]	Time 0.133 (0.133)	Data 0.000 (0.002)
Extract Features: [2010/2201]	Time 0.132 (0.133)	Data 0.000 (0.002)
Extract Features: [2020/2201]	Time 0.136 (0.133)	Data 0.000 (0.002)
Extract Features: [2030/2201]	Time 0.132 (0.133)	Data 0.000 (0.002)
Extract Features: [2040/2201]	Time 0.133 (0.133)	Data 0.000 (0.002)
Extract Features: [2050/2201]	Time 0.138 (0.133)	Data 0.000 (0.002)
Extract Features: [2060/2201]	Time 0.131 (0.133)	Data 0.000 (0.002)
Extract Features: [2070/2201]	Time 0.132 (0.133)	Data 0.000 (0.002)
Extract Features: [2080/2201]	Time 0.132 (0.133)	Data 0.000 (0.002)
Extract Features: [2090/2201]	Time 0.133 (0.133)	Data 0.000 (0.001)
Extract Features: [2100/2201]	Time 0.132 (0.133)	Data 0.000 (0.001)
Extract Features: [2110/2201]	Time 0.134 (0.133)	Data 0.000 (0.001)
Extract Features: [2120/2201]	Time 0.133 (0.133)	Data 0.000 (0.001)
Extract Features: [2130/2201]	Time 0.134 (0.133)	Data 0.000 (0.001)
Extract Features: [2140/2201]	Time 0.133 (0.133)	Data 0.000 (0.001)
Extract Features: [2150/2201]	Time 0.132 (0.133)	Data 0.000 (0.001)
Extract Features: [2160/2201]	Time 0.132 (0.133)	Data 0.000 (0.001)
Extract Features: [2170/2201]	Time 0.133 (0.133)	Data 0.000 (0.001)
Extract Features: [2180/2201]	Time 0.136 (0.133)	Data 0.000 (0.001)
Extract Features: [2190/2201]	Time 0.133 (0.133)	Data 0.000 (0.001)
Extract Features: [2200/2201]	Time 0.132 (0.133)	Data 0.000 (0.001)
gathering features from rank no.0
===> Start calculating pairwise distances
===> Start calculating recalls
Recall Scores:
top-1           1.2%
top-5           4.6%
top-10          8.7%
===> Start extracting features for sorting gallery

I cannot locate your issue. Maybe provide your full testing log could help.

if you have retested the model rightly, could you please zip your local folder and send it to my email (yangling0818@163.com)? I would appreciate it.

It shows that resume='', indicating that you did not load any model weights.

It shows that resume='', indicating that you did not load any model weights.

this is my training log, so resume=''

It shows that resume='', indicating that you did not load any model weights.

And this is my testing log, the model is downloaded from your provided url:
Use GPU: 0 for testing, rank no.0 of world_size 1
Args:Namespace(arch='vgg16', data_dir='/data/yangling/test/OpenIBL-0.1.0-beta/examples/data', dataset='pitts', features=4096, gpu=0, height=480, lambda_value=0, launcher='pytorch', logs_dir='/data/yangling/test/OpenIBL-0.1.0-beta/examples/logs', ngpus_per_node=1, nowhiten=False, num_clusters=64, print_freq=10, rank=0, reduction=True, rerank=False, resume='logs/ori/model_best.pth.tar', rr_topk=25, scale='30k', sync_gather=False, tcp_port='5017', test_batch_size=6, vlad=True, width=640, workers=2, world_size=1)
Pittsburgh dataset loaded
subset        | # pids | # images
train_query   |   311  |     7320
train_gallery |   417  |    10000
val_query     |   319  |     7608
val_gallery   |   417  |    10000
test_query    |   286  |     6816
test_gallery  |   417  |    10000
=> Loaded checkpoint 'logs/ori/model_best.pth.tar'
=> Start epoch 3  best recall5 94.5%
Evaluate on the test set:
load PCA parameters...

I think whether some default settings about dataset preprocessing are wrong with your current code, because the evaluation results of the models you provide and i train are similarly much lower than you report.


[Storage] Add fs.createWriteStream() shim for browser rollup

This removes one rollup warning.

Not required for preview1. can wait to merge after release.

Looks good. Out of curious, without this does released track2 packages have unfound bugs?

Rollup has some more warnings, I'm not sure if we can categorize them as "bugs".
We have an issue to track and resolve the rollup warnings, we'll soon be fixing them.


Make it easier to run SkyShell from the command line on Mac

Now you can use --snapshot to load snapshots from the command line and have
them appear visually on Mac. Also, remove code duplication with Linux by
factoring common testing code into //sky/shell/testing.

@chinmaygarde @eseidelGoogle

Lgtm assuming the cl has all the new files.
On Saturday, August 15, 2015, Adam Barth<EMAIL_ADDRESS>wrote:

@chinmaygarde https://github.com/chinmaygarde @eseidelGoogle
https://github.com/eseidelGoogle
—
Reply to this email directly or view it on GitHub
https://github.com/domokit/sky_engine/pull/635#issuecomment-131437808.


fix(testing-karma): ensure karma-webpack creates a single bundle

This fixes the issue of karma-webpack creating a separate bundle per test file.
I think that configs should have smart defaults, but still be overrideable and understandable. I iterated over different solutions, but couldn't find a good solution that covers these. At it's core, this is a bug in karma-webpack, so we should look into whether we can fix it on their side.
With this approach, by default all files in the /test folder ending with .test are run. It can be overwritten through by parameters to the config function (can't do it through the files property). Consumers can also opt out entirely by setting their own files property.

closed in favor of https://github.com/open-wc/open-wc/pull/89


Save Windows terminal window split status

Function widely used on terminals such as iTerm and others of the kind to report the preferred working status.

There's not a lot of details to go off of in this issue, but it sounds a lot like either #961 or #756

Perfect signaling #961 with saving the internal division status of each card.
THX for your work ,)

Awesome, thanks for following up!
/dup #961


react-native run-android fails.

While running react-native run-android not working. It's throwing me following error.
Unhandled promise rejection (rejection id: 2): TypeError: Cannot read property 'message' of undefined
I tried giving permission to android/gradlew but it's not woking. I was able run app on ios successfully.
react-native version 0.40.0

duplicate of #14225


[RFC] Common Benchmark Suite

This is the subsequent RFC of the high-level benchmarking strategy for OpenXLA #75 (in review).
It proposes to create a benchmark suite to fulfill the benchmarking requirements in the strategy.
The temporary links to the high-level strategy RFC will be updated once #75 is merged.

Will someone be able to help add suitable reviewers? (probably include @jpienaar @GMNGeoffrey @julianwa @mariewhite). It looks like I don't have permission.

Nice work, looking forward to this! :)
I just left a few nit comments mostly, thanks.

Thanks for all the reviews and I think we don't have a major objection to this idea 🙂  I added a section in the bottom to list the remaining open questions and will track them in the new benchmark repository.

@theadactyl Will you be able to help merge this RFC and create the repository openxla-benchmark as the next step?

I can merge. Will look into the new repo


Option to not create files when input results in zero records

I am using the embulk-input-postgres plugin to extract records out of a postgres database. With this type of input, using a WHERE clause may result in 0 records to be pulled from there. When I use the file output type (or a file output plugin like embulk-output-s3), empty files (or CSV files with just a header row) will be created.
Since there are store costs with storing these files as well as time taken to process these empty files, it would be nice if embulk had an option to not create any output files if the input results in zero records.

I am not sure if this is a plugin-specific issue or related specifically to the embulk-native file output plugin.

a necessary change is that file output plugins (local, s3, etc.) should create a file lazily when the first row comes after flush.


[CIT-377] rename tedge_dm_agent to collectd_mapper

Proposed changes
This PR captures code changes to rename the "tedge-dm-agent" to "collectd-mapper".
This includes renaming the folders, updating the pysys system tests and service.
Types of changes
What types of changes does your code introduce to thin-edge.io?
Put an x in the boxes that apply

[ ] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[x ] Improvement (general improvements like code refactorings that doesn't explicitly fix a bug or add any new functionality)
[ ] Documentation Update (if none of the other choices apply)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Paste Link to the issue

Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

[ ] I have read the CONTRIBUTING doc
[ ] I have signed the CLA (in all commits with git commit -s)
[ ] I ran cargo fmt as mentioned in CODING_GUIDELINES
[ ] I used cargo clippy as mentioned in CODING_GUIDELINES
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have added necessary documentation (if appropriate)

Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

Codecov Report

Merging #266 (79442e6) into main (650255e) will increase coverage by 0.11%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #266      +/-   ##
==========================================
+ Coverage   65.87%   65.98%   +0.11%
==========================================
  Files          64       64
  Lines        3634     3634
==========================================
+ Hits         2394     2398       +4
+ Misses       1240     1236       -4

Impacted Files
Coverage Δ

mapper/collectd_mapper/src/batcher.rs
82.45% <ø> (ø)

mapper/collectd_mapper/src/collectd.rs
89.62% <ø> (ø)

mapper/collectd_mapper/src/main.rs
0.00% <ø> (ø)

mapper/collectd_mapper/src/monitor.rs
0.00% <ø> (ø)

tedge_config/tests/test_tedge_config.rs
98.24% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 650255e...79442e6. Read the comment docs.

Looks good, is there no documentation update required?

There is no document for the collectd_mapper yet.


detect: Adding more serial id fallbacks

As per issue 206 in edeploy, we have systems where serial numbers are .... weird.
We have system that are even much more evil like DMI not providing any
unique ID at all...
This patch is trying to solve all that different cases.
If the serial is known to be buggy then we search for a possible
fallback in the following order :

system uuid
motherboard serial
MAC address of the first nic

Note that the system uuid will be used unless it is known to be buggy or empty.
If a system doesn't provide any valid 'product SN' or 'product uuid' or
'motherboard serial' (yes this does exist), then we fallback on the last
unique ID we have on a system which is the mac address of one nic : this
is not optimal but at least that makes the installation process staying
alive. That's really a workaround.

Related to https://github.com/enovance/edeploy/issues/206

Travis failed, I'm trying to trigger a new build.


Path pattern syntax

What kind of patterns can I use for the PathRules? Can I use regular expressions or the wildcard pattern is only supported? It's not clear from the article.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 6f499fef-00fc-0326-a4e5-0d796d6ca331
Version Independent ID: 09179d08-d93c-df5f-f838-c854d9dca26f
Content: URL-based content routing overview
Content Source: articles/application-gateway/application-gateway-url-route-overview.md
Service: application-gateway
GitHub Login: @vhorne
Microsoft Alias: victorh

Hello @ebashmakov We are investigating this issue now. Thank you for reporting it

@ebashmakov It looks like only wildcard is currently supported for Pathrules. More examples can be found here: https://docs.microsoft.com/en-us/azure/application-gateway/application-gateway-create-url-route-arm-ps
Let me know if this helps.

@Adam-Smith-MSFT thanks for the replaying. I maybe looking in a wrong place but I only see the same example everywhere: /images/* and /video/*. Does it mean that I can do only something like this: /something/* and /something1/something2/*? Or I can also do: /*.jpg, /images/**/img*.jpg, /**/*-video.mp4?

@ebashmakov It looks like only the folder path/schema is supported. I'll assign it to the author to clarify this matter.

@ebashmakov
Added a qualifying statement to the note about PathPattern:
Otherwise, any characters allowed in a URL are allowed in PathPattern.

@vhorne your addition is important but this is actually not what has my interest.

PathPattern: This setting is a list of path patterns to match. Each must start with / and the only place a "*" is allowed is at the end following a "/." The string fed to the path matcher does not include any text after the first ? or #, and those chars are not allowed here.

I have read the note multiple times and after some time it became clear for me how it works. I think it shouldn't be just a note since it's quite important information. I spend quite a lot of time researching Application Gateway and it turns out that it's not what I need. I expected it to support some like IIS URL Rewrite (it least support matching without rewriting). A more clear documentation would save my time.
I believe some examples of usage will really improve the documentation. So the future readers will not be confused like me.

Path pattern
Is supported?

/images/*
yes

/images*
no

/images/*.jpg
no

/*.jpg
no

/Repos/*/Comments/*
no

/CurrentUser/Comments/*
yes

Please also check the documentation of AWS ELB. It also has path patterns which work exactly the same. But the documentation is much clearer than here.
I would also suggest to add the following:
The path pattern is used to route requests but does not alter them. The path pattern is not a regular expression and not a file-path pattern.


Specify swift-syntax version in manifest

Specified a swift-syntax version in the Package.swift manifest to resolve an error when trying to add csv2img to a project.

Thank you!
it seems that error happens in CsvBuilder because of this version updtae.
Could you also fix the error? If it's difficult, I can undertake it.🙆♂

Hi, I'm not sure why that is. I haven't come across this when using the package.
The problem was, without a version defined, the package cannot be added to an Xcode project and will display this error:

I see. I think you don't use CsvBuilder library, but just use Csv2Img library. so let me add a new commit to address above issue :pray:


Include <thrust/detail/memory_wrapper.h>, not

Yesterday "#include " was added to
thrust/detail/allocator/allocator_traits.inl.  That caused a regression
when compiling with NVC++, breaking #1218.  This fix changes that include
to be "#include <thrust/detail/memory_wrapper.h>".  (And it makes the
same change to a different include of  that I seem to have missed
in my earlier commit.)

Ack, I should have caught that since we just merged the other fixes. I'll see if I can get a copy of nvc++ and add it to my pre-merge testing.
I'll get this landed and backported to 1.9.10-1.


new developers get confused about this warning

Type: Bug
There's a warning I don't know what to do with. Other people also get it:
https://stackoverflow.com/questions/76654815/vs-code-python-shell-integration-failed-to-activate
Let me know if I should bother with this warning.
VS Code version: Code 1.81.1 (6c3e3dba23e8fadc360aed75ce363ba185c49794, 2023-08-09T22:22:42.175Z)
OS version: Windows_NT x64 10.0.19043
Modes:

System Info

Item
Value

CPUs
Intel(R) Core(TM) i5-7200U CPU @ 2.50GHz (4 x 2712)

GPU Status
2d_canvas: enabledcanvas_oop_rasterization: disabled_offdirect_rendering_display_compositor: disabled_off_okgpu_compositing: enabledmultiple_raster_threads: enabled_onopengl: enabled_onrasterization: enabledraw_draw: disabled_off_okvideo_decode: enabledvideo_encode: unavailable_offvulkan: disabled_offwebgl: enabledwebgl2: enabledwebgpu: enabled

Load (avg)
undefined

Memory (System)
31.87GB (23.04GB free)

Process Argv
--crash-reporter-id 15ade0d1-325b-4210-935d-91603f471e38

Screen Reader
no

VM
0%

Extensions (16)

Extension
Author (truncated)
Version

vscode-pull-request-github
Git
0.70.0

vscode-docker
ms-
1.26.0

data-workspace-vscode
ms-
0.5.0

mssql
ms-
1.20.1

sql-bindings-vscode
ms-
0.4.0

sql-database-projects-vscode
ms-
1.2.0

isort
ms-
2023.10.1

python
ms-
2023.14.0

vscode-pylance
ms-
2023.8.40

jupyter
ms-
2023.7.1002162226

jupyter-keymap
ms-
1.1.2

jupyter-renderers
ms-
1.0.17

vscode-jupyter-cell-tags
ms-
0.1.8

vscode-jupyter-slideshow
ms-
0.1.5

remote-containers
ms-
0.304.0

remote-wsl
ms-
0.81.0

This means something went wrong when trying to automatically activate it: https://code.visualstudio.com/docs/terminal/shell-integration. Can you try installing manually and see if there's an error?

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.
Happy Coding!


Use BlobsCheckpointStore in scale monitor

The goal to reuse the existing logic in BlobsCheckpointStore for scale monitor calculations.
Added some logging to BlobsCheckpointStore to compensate for the one being removed from the scale monitor.

/azp run net - eventhub - tests

Will defer to @jsquire for the checkpoint store usage.


Minor Issue :2 - Reading input files.

The data processor function identifies the labels and text by column position.
def _create_examples(self, lines, set_type):
"""Creates examples for the training and dev sets."""
examples = []
for (i, line) in enumerate(lines):
guid = "%s-%s" % (set_type, i)
text_a = line[3]
label = line[1]
examples.append(
InputExample(guid=guid, text_a=text_a, text_b=None, label=label))
return examples
This is a problem as pandas is used to generate the tsv files, and across 0.24, 0.25 there is a difference in the order in which the columns are saved. It might be better to save the column names ad directly name the label column. I ran into this issue as I had to operate on two different machines and on the second machine it would crash - saying label_id used before being assigned.

I'll check this. But any version of pandas should be saving the df in the same order it is in. Maybe there's something going on with my saving code.

You were right. 0.24 seems to have been doing weird stuff when writing out dfs to files. I changed the Colab notebook and the data_prep notebook to specify the column names when writing the tsv files.

Thanks!!


[Adding Tool]: Algorithm for Competitve Programming

Closes #1154
I have added a website where all the algorithms related to competitive programming will be accessible to everyone. It is one of the best site for a competitive programmer and used by large number of coders.
Screenshots

Checklist

[x] My code adheres to the established style guidelines of the project.
[ ] I have included comments in areas that may be difficult to understand.
[x] My changes have not introduced any new warnings.
[x] I have conducted a self-review of my code.

The PR title format you are using is causing an error in the workflow. Please follow the instructions in the README.md and change it accordingly.


Update scalacheck to 1.15.2

Updates org.scalacheck:scalacheck from 1.15.1 to 1.15.2.
GitHub Release Notes - Changelog - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.scalacheck", artifactId = "scalacheck" } ]

labels: library-update, semver-patch

Codecov Report

Merging #906 (2f589a6) into develop (99432ee) will increase coverage by 0.27%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop     #906      +/-   ##
===========================================
+ Coverage    89.52%   89.79%   +0.27%
===========================================
  Files          119      119
  Lines         9869     9869
  Branches       494      494
===========================================
+ Hits          8835     8862      +27
+ Misses        1034     1007      -27

Impacted Files
Coverage Δ

.../scala/com/twitter/algebird/immutable/BitSet.scala
96.78% <0.00%> (+0.21%)
:arrow_up:

.../src/main/scala/com/twitter/algebird/ExpHist.scala
96.55% <0.00%> (+1.14%)
:arrow_up:

.../main/scala/com/twitter/algebird/BloomFilter.scala
95.13% <0.00%> (+1.32%)
:arrow_up:

...c/main/scala/com/twitter/algebird/SpaceSaver.scala
94.44% <0.00%> (+4.62%)
:arrow_up:

...ain/scala/com/twitter/algebird/AdaptiveCache.scala
78.37% <0.00%> (+5.40%)
:arrow_up:

...main/scala/com/twitter/algebird/monad/Reader.scala
58.82% <0.00%> (+5.88%)
:arrow_up:

...in/scala/com/twitter/algebird/scalacheck/Gen.scala
100.00% <0.00%> (+9.09%)
:arrow_up:

...src/main/scala/com/twitter/algebird/Interval.scala
86.95% <0.00%> (+10.43%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 99432ee...2f589a6. Read the comment docs.


feat: Implement the metrics user menu

Fixes #422
Checklist

[x] Documented
[x] Unit tested

@mergifyio refresh


Document the changes in windows-toolkit/WindowsCommunityToolkit#2820

This PR documents in the changes made in windows-toolkit/WindowsCommunityToolkit#2820

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: encrypt0r sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

cc @michael-hawker

OPS Build status updates of commit 4980b20:
:clock10: Incremental building: average incremental building time is 1 min(s) 13 sec(s)

OPS Build status updates of commit 4980b20:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/extensions/TextBoxMask.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


db-analyser: use reapply not apply for --store-ledger

This should have always been reapply instead of apply.

bors r+


Crashlytics Error - UiAutomatorInteractionController.java line 39

We are on v1.3.1 for android-browser-helper and seeing this error in Crashlytics. Let me know if you need any more information from my side to investigate this.

This crash is happens in UiAutomatorInteractionController. This is neither part of or used by androidx.browser and android-browser-helper.  The stack trace does point to androidx.test.runner.AndroidJUnitRunner, which seems to indicate indicate the test suite for the application crashing - a lab crash, not the device crashing with end users, and issue with test configuration, not the libraries. Closing as this is outside the scope of this repository.


doc directory is cluterred by source files

In GitLab by @jbigot on Jul 26, 2021, 16:57

mentioned in commit 4dc9fa803c09c0706339044b67d1d6fbe4286851

mentioned in commit b8259aeb759eb91bfb69924fe9a97bf5ddd66308

created merge request !374 to address this issue


fix(mdx-components): fix pre scrollbar

What is it?

[ ] Feature / enhancement
[ ] Bug
[ ] Docs / tests
[x] Other

Why is it needed?

Checklist:

[ ] My code follows the developer guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have ran pnpm changeset and documented my changes
[ ] I have add necessary docs (if needed)
[ ] Added new tests to cover the fix / functionality

Looks good to me!


Feature/bitcon core support

Submission for the assignment 6 - Plan B Network Tech School.
General changes

added unsubscribe methods on Electrum provider
added Electrum provider tests
added Bitcoin Core provider
added Bitcoin Core provider tests
added a package dependency (ZeroMQ)
some updates on test-helpers

Choices

A new files has been added to .gitignore: package-lock.json, as of what we said on Telegram
The module now exports two distinct providers: ElectrumProvider and BitcoinCoreProvider.
Bitcoin Core provider subscriptions are managed with ZeroMQ
Only one ZeroMQ socket is used. All messages go through it with a different topic to distinct them.
The socket port is 28334. The standard one should be 28332, but the suggested bitcoin.conf file uses three different ports starting from 28334. I chose the first one.
The ZeroMQ socket emits different events depending on the topic. The Bitcoin Core provider listens to the events and their handler contains the logic. This way I can assure only one socket is opened and it is listened only by one process.
I changed the name of _getBalance() to getBalance() in both Electrum and Bitcoin Core providers, with the intention to signal it as a public method.
New test-config schema: the schema has been updated to reflect the presence of the new Bitcoin Core provider. It is now a dictionary with an entry for each provider and the needed properties.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


ISPN-15860 Exception with async store when not segmented

https://issues.redhat.com/browse/ISPN-15860

Are the SharedStoreTest failures related?

Checking.

Updated, the size stat for DummyInMemoryStore was added twice on accident

Thanks, @wburns!


Remove dependency of apis/ on pkg/

What type of PR is this?

/kind cleanup
What this PR does / why we need it:
it is desirable to have hermetic API packages (not depending on packages in pkg/). This PR removes such dependency.
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?

NONE

/ok-to-test

Maybe it's good idea to move this test to pkg. WDYT?

I removed the dependency of apis/visibility/v1alpha1/defaults.go on kueue/pkg/constants by copying a constant. Please take a look if it is fine.

/retest

/retest


Dumped image from mi424wr rev D can't identify images

This https://github.com/Lightsword1942/jungo-image/blob/master/MI424-WR-0018017A3ED9.bin is a dumped image that was created using this imaging script https://github.com/Lightsword1942/jungo-image/blob/master/jungo-image-2.py binwalk does not appear to identify anything.

This thread should explain some of the uncramfs-lzma modified Jungo images. And the Gianpietro explanation here:

lzma-uncramfs is a modification of the uncramfs program to be able to
unpack cramfs images included in some openrg based home routers.
It includes lzma decompression and a different PAGE_CACHE_SIZE.
To successfully compile lzma-uncramfs an old version of lzma modified
by Jungo/OpenRG team is included.

And lzma-uncramfs sources here. But I don't know if this is the same as that provided by James above...

Did you test it on my router image? This is the firmware update file that I couldn't extract https://github.com/Lightsword1942/jungo-image/blob/master/<IP_ADDRESS>.<IP_ADDRESS>.6-MI424WR.rmt .

No I didn't. I just randomly came across this page and recalled that I had encountered something very similar in the past while dealing with and looking at various Jungo based crap FW on Pirelli routers. (Those guys should have a huge lawsuit up theirs, since their insecure FW is jam packed with security holes, not conforming to GPL and endangering entire nations.) You'll have to compile those sources to do the extraction, then mount it, AFAICR.

Yeah, I think these Verizon routers are similar(they also don't conform to the GPL by releasing only the source for certain parts of the router rather than the compile environment that actually matches their firmware binaries). I compared the config file that is on the router with the one that is in their GPL package and the GPL one is missing lots of features/drivers.


Update 2021-10-18-how-all-frameworks-can-bump-to-php-81-and-you-can-u…

…se-older-php.md
changed php version in the rector-downgrade.php to keep it with description provided above

Thank you :+1:


Converge to a single Jenkins configuration for all jobs.

The "all test runs manual" bit is required for the nightlies to work.


reference[method] is not a function (it is undefined)

I'm passing a virtual element to position a context menu in react native
this is my code
 const virtualRef = React.useRef({
    getBoundingClientRect: () =>
      isWeb
        ? DOMRect.fromRect({ width: 0, height: 0, ...pointRef.current })
        : {
            width: 0,
            height: 0,
            top: 0,
            left: 0,
            ...pointRef.current,
          },
  })

and then calling
floating.refs.setReference(virtualRef)

but it gives me this error
reference[method] is not a function ( it is undefined )
floating version
"@floating-ui/react": "^0.24.7",
"@floating-ui/react-dom": "^2.0.1",
 "@floating-ui/react-native": "^0.10.1",

as it seems it's trying to call measure and measureInWindow on that virtual element
const method = sameScrollView ? 'measure' : 'measureInWindow';
            reference[method]((x, y, width, height) => {

maybe adding some fake measure and measureInWindow can fix it

I think it's worth having something like DOMRect that uses DOMRect on web and a simple object on react native


Misleading Parameters for CF "health-check"?

Hi guys,
I just checked the new feature of CAP, using the new capabilities of Cloud Foundry to perform a http-check after the deployment as kind of readiness check, as announced within the release-notes for march
I checked the referenced documentations on CAPire for more details, but was not able to get more details how to get it embedded on the mta.yaml file.
So, I followed instead the example from the picture of the release-note of march.
This did not lead me to success. I did supply a "wrong" name to check, the pipeline / cf deployment is failing like expected:
modules:
  - name: my-demo-app
    type: nodejs
    path: .
    parameters:
      disk-quota: 1024M
      memory: 512M
      instances: 1
      buildpack_name: nodejs_buildpack
      readiness-health-check-type: http
      readiness-health-check-http-endpoint: /broken

After some further debugging, checking cf-cli version and mta-build version, I found this example.
So, I modified it accordingly and used instead:
modules:
  - name: my-demo-app
    type: nodejs
    path: .
    parameters:
      disk-quota: 1024M
      memory: 512M
      instances: 1
      buildpack_name: nodejs_buildpack
      health-check-type: http
      health-check-http-endpoint: "/broken"

This is working! Can you please check, if it's a typo and correct the page accordingly, so the next one isn't running into the same situation?
Best Regards,
Cedric

Thanky @drvup ! I can confirm, that cds init book --add sample,mta create an mta.yaml that is according to our docs.
@sjvans and @swaldmann could you check if we need to adapt according to @drvup 's findings?

readiness-health-check-type and readiness-health-check-http-endpoint are correct. see readiness-health-check-http-endpoint in cf docs

Hi @drvup ,
I created a simple CAP app and deployed it. It worked.
my mta.yaml looks like this:
_schema-version: '3.1'
ID: book
version: 1.0.0
description: "A simple CAP project."
parameters:
  enable-parallel-deployments: true
build-parameters:
  before-all:
    - builder: custom
      commands:
        - npm ci
        - npx cds build --production
modules:
  - name: book-srv
    type: nodejs
    path: gen/srv
    parameters:
      buildpack: nodejs_buildpack
      readiness-health-check-type: http
      readiness-health-check-http-endpoint: /health
    build-parameters:
      builder: npm
    provides:
      - name: srv-api # required by consumers of CAP services (e.g. approuter)
        properties:
          srv-url: ${default-url}
    requires:
      - name: book-auth
      - name: book-db

  - name: book-db-deployer
    type: hdb
    path: gen/db
    parameters:
      buildpack: nodejs_buildpack
    requires:
      - name: book-db

resources:
  - name: book-auth
    type: org.cloudfoundry.managed-service
    parameters:
      service: xsuaa
      service-plan: application
      path: ./xs-security.json
      config:
        xsappname: book-${org}-${space}
        tenant-mode: dedicated
  - name: book-db
    type: com.sap.xs.hdi-container
    parameters:
      service: hana
      service-plan: hdi-shared

So thanks again for being alert and opening this issue. But I don't think there's an error in capire or our implementation.
All the best,
René


Added dry run support.

By providing the parameter dryrun, noop or whatif, a dry run will be performed. This is useful to see what tasks will be executed given the current context (environment variables, arguments etc).
No tasks will actually be executed.
PS> .\Cake.exe build.cake -dryrun

Performing dry run...
Target is: Build

1. Clean
2. Build
3. Copy-Files
4. Package-Files

This was a dry run.
No tasks were actually executed.

Related to issue #155.

@patriksvensson will test some more, but seems to works well, should add to Cake.exe usage too before merge.

OK, will add to usage. Hold on :+1:


Formulate a policy for external dependencies

CCL is growing rapidly to include new external codes. We have varying levels of control over these codes, especially in terms of:

The programming language used and their own external dependencies
The level of testing and accuracy validation of the code
Fixing bugs, adding features, and other issues surrounding keeping the external code up to date
The level of documentation and performance optimisation

Some examples of questions that we should be able to answer are:

What do we do if an external dependency depends on (e.g.) a different FFT library to the one we are using? What if the dependency doesn't run on some systems (e.g. Macs)?
What should we do if the dependency has license restrictions that means it can't be distributed with CCL? How do we deal with citation clauses in licenses of the external codes?
What should we do if the dependency is written in a different programming language? Should we re-write Python codes so that they are more easily available to the C library?
Should some of the codes be hard dependencies, while others are optional? How do we decide which to choose?
If we heavily depend on a code (e.g. CLASS), should we fix bugs in our own local version of the code? Or should we work around them in the CCL code only? Or should we try to get them fixed upstream?
What standards should we apply to these codes in terms of the levels of validation and documentation?

Also, should we keep a 'roadmap' document spelling out which codes we are planning to integrate with CCL in the future? And should we have a formal process (with a set of 'minimum standards') for people who want to propose their code for integration within CCL?

For (1) and sort of (5), If it's a C library, @jchiang87 or or @rmjarvis should help out a bit with figuring out a build dependency system (CMake, Spack, or similar) and/or a packaged build system. Including too many dependencies is going bring up this issue over time.  Alternatively, we only use versions of libraries packaged with brew (os x), apt/yum, (and/or package them) or switch to Conda. If you want to keep using PyPI, I think it's best to go the brew/apt/yum route. This also helps with (2) - you aren't distributing those libraries.
For (3), everything is either going to be C, C++, Fortran, or Python. Those are all reasonably interoperable (nobody uses Fortran directly). It's not very practical to use anything other than that (technically Rust and Julia might still work fine, R is more of an issue).
(4) is still wrapped up in the decision for (1) and (2)
For (5), bugs should definitely be fixed locally (ideally via a fork of CLASS in LSSTDESC) which is maintained and PRs it's easiest to handle that if you actually. Again, this leads back to (1) to an extent
Alternatively, make sure every external library is either available in brew (or package it in brew) and/or apt/yum, depending.
For (6), this is again a question for @rmjarvis and @jchiang87, but for C we probably should be using Clang-format and for Python we should probably adopt a style checker based on PEP-8 (with reasonable exceptions when necessary). It's relatively easy to configure both of those. For external libraries which are imported/patched (e.g. CLASS), you should always try to code consistently with the explicit or inferred style of that library.

I left something out: if there's not too many dependencies, the current behavior is fine and a packaging system is probably overkill for (1), but we should have a complexity line-in-the-sand that, if it's crossed, another solution should be considered.

For (1) and sort of (5), If it's a C library, @jchiang87 or or @rmjarvis should help out a bit with figuring out a build dependency system (CMake, Spack, or similar) and/or a packaged build system.

I think the main bit of advice I have about this is to do your best to keep your core dependencies to a minimum.  Especially dependencies that are not pip installable.
It's usually ok to have sub-modules that have additional dependencies, so only people who want to use the features in these sub-moduels have to worry about these extra dependencies.  E.g. in GalSim, we have an lsst module that depends on the LSSTDM stack, but the main GalSim code does not depend on it.
But I would try to keep the core dependencies to be both few in number and as light-weight as possible in terms of pain of installation.


Portus 2.1 Docker image unavailable on Docker Hub

Portus 2.1 has been released on September 2016 but is still unavailable as a Docker image on Docker Hub. Is there any release plan ?

I just pulled the opensuse/portus:head image and using it the UI tells me to be "Version: 2.1.0-dev". Unfortunately the new image / tags removal feature is not part of that build. Would really nice to get that running by just pulling another Docker image.

+1

+1

+1
What's the status on this? I love Portus, and I'd love to be on the latest version (now 2.2)! I'm in an environment where I am only able to run RHEL, so it's Docker or nothing for me.

opensuse/portus:head on Docker Hub is pretty recent. Was built about 4 hours ago of this comment.

I'm a bit unfamiliar with development practices for Portus – is head considered relatively stable?

I'm using it, but I'm hardly a large data set. :) YMMV, etc.

@Djelibeybi @blaketmiller opensuse/portus:head contains the master version of Portus, so bear in mind that it's not really meant for production (maybe staging).
The current state is that we are fixing some issues on the RPM, so it can be better used in the final Docker image (see #1191, #1192, #1194). The goal is to provide an official docker image which has the best of both worlds (minimalistic but still has all the security/reliability feedback from OBS). We are re-doing what we did after some internal discussions and other discussions with members of the community (see #1027 and #912).
I hope we have something ready rather soonish.

+1
I'm expecting version 2.2 production image release

@mssola When can be production v2.2 on docker hub?

This has already been fixed. The sum things up:

For 2.1 and 2.2 you have their respective docker images in here. This image is the same as always (with apache in it).
The head (and the future 2.3) has effectively changed to the new layout as you can see in this commit. So, check out the README file again for the changes. The summary is that we greatly simplified the image, stripping away apache in favor of Puma. You can find examples of deployment in the PR #1254 (I still need to polish it and there might be some rough edges though).

Sorry for the wait. Feel free to write more comments here if you have any other doubt!


https://github.com/AFakhriddinov/Capstone-project

Link to our project: https://github.com/AFakhriddinov/Capstone-project
We are 2 people in the group

Hi @Team
While you made a great effort in this project, unfortunately, I cannot proceed to review your code.
Invalid Code Review Request
You have submitted an issue that does not have a description, please add a link to your GitHub project and
information about the number of people in your group in the issue above👍🏿
Your Code Review Request will be marked as invalid in your Dashboard, so please submit a new one once you are ready 🙏
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification @prolajumokeoni.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

Invalid Code Review Request does not count into the code reviews limit.

STATUS: INVALID CODE REVIEW REQUEST 🛑 🛑
Hi @AFakhriddinov and @PrinceBadru,
While you made a great effort in this project, unfortunately, I cannot proceed to review your code.
Invalid Code Review Request
You provided the link to your repo, but you should provide the link to your Kanban board itself. Kindly do that.
Your Code Review Request will be marked as invalid in your Dashboard, so please submit a new one once you are ready 🙏
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear. And please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

Invalid Code Review Request does not count into the code reviews limit.

Status: Required Changes :recycle:
Hi @team,
Good job so far!
There are some issues that you still need to work on to go to the next project but you are almost there!
Highlights

Kanban board set up properly. :heavy_check_mark:

Required Changes ♻
Check the comments under the review.

[ ] Some of the tasks on the board are not assigned to any student. You know if a task is assigned when you could see the assignee's avatar by the right part of the ticket. Kindly assign students to the unassigned tasks as you did to the group tasks.

Optional suggestions
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

Hi team,

Great work, your project is complete!  There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉
Remember: Every finish line 🏁  is the beginning of a new race 🐎
Highlights

[ ] All task exists on the kanban 👍🏾
[ ] All tasks have assignees 👍🏾
[ ] Link to Kanban provided 👍🏾

Optional suggestions
Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.

As described in the Code reviews limits policy  you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.


FIX Grafana dashboards files are stored in a bad format

Issue

This PR fixes #135
Solution

This PR fixes:

The dashboard's malformed files names
Dashboards content: There is no need to transform the content of the dashboard, since the lib returns a string
Files overwrite: As we generated the same name, the files were overwritten.

Hi @rbarry82
Thanks for the review!
I don't think I quite understand you.
About these:

Considering it's a subordinate and we already included the rel id, do we really think we need it?

I do wonder whether including the enumeration ID as part of the filename will do bad things.

The answer is Yes.
We do need the ID as part of the filename. In fact what we need is a way to create unique file names. Otherwise if the charm provides more than one dashboard, we'll end up overwriting the dashboards because the generated filenames are the same. That's why I include the key.
Note that in the original code, we generate the same file name for every dashboard.
Regarding this:

If the loading of dashboards/enumerating doesn't return the same order in the list every time, we may end up with the "same" dashboard with different iterator IDs, and GrafanaDashboardProvider won't "know" they're the same.

As far as I understand, every time there is a _cos.on.data_changed event, Grafana Agent will remove and re-generate the dashboards files stored in /var/lib/juju/agents/unit-grafana-agent-{NUM}/charm/grafana_dashboards, after that the method _update_all_dashboards_from_dir will be executed. This method delete the previous stored dashboard files from self._stored and re-store them.

The answer is Yes. We do need the ID as part of the filename. In fact what we need is a way to create unique file names. Otherwise if the charm provides more than one dashboard, we'll end up overwriting the dashboards because the generated filenames are the same. That's why I include the key. Note that in the original code, we generate the same file name for every dashboard.

Can we use the hash for this, as we do for _generate_alt_uid or otherwise sum it? Even that may not be reliable if the content changes, but using dashboard["title"].replace(" ", "_").lower() would be "same title -> same filename", and put the name of the dashboard in the filename, too.

If the loading of dashboards/enumerating doesn't return the same order in the list every time, we may end up with the "same" dashboard with different iterator IDs, and GrafanaDashboardProvider won't "know" they're the same.

As far as I understand, every time there is a _cos.on.data_changed event, Grafana Agent will remove and re-generate the dashboards files stored in /var/lib/juju/agents/unit-grafana-agent-{NUM}/charm/grafana_dashboards, after that the method _update_all_dashboards_from_dir will be executed. This method delete the previous stored dashboard files from self._stored and re-store them.

Yes, but the line I'm worried about that is two above what was linked and just below it. Unlike other charms (due, again, mostly to the limitations in subprocess from sending huge amounts of data during set-state for relation data) Grafana does not wipe the entire list. It only deletes matched keys, and that key includes filename.stem, which will include the enumerated index.
That's why I'm worried that a charm refresh/update which, say, adds a dashboard, or a lack of a guarantee in ordering after serializing/de-serializing the list to put it into relation data will result in juju_0_....json being renamed/changed to juju_1_....json if something changes, and then we wouldn't end up with the behavior we want.

Can we use the hash for this, as we do for _generate_alt_uid or otherwise sum it? Even that may not be reliable if the content changes, but using dashboard["title"].replace(" ", "_").lower() would be "same title -> same filename", and put the name of the dashboard in the filename, too.

This could be a solution... I did not implement the hash, since I thought with the key was enough. Thanks!

Assuming that the ordering is the same, but.. I don't think that's a great guarantee either.
Honestly, using a hash potentially has the same risk if the "same dashboard" ends up changing enough that the hash is meaningfully different. Using dashboard["title"].... is probably the closest we'll get to "if this dashboard is updated on upgrade, replace the old one" until we have time to test whether OF not sending relation stuff over subprocess anymore makes it safe for Grafana to drop all of the storedstate stuff that's happening right now.


Is there anyway we could implement interface based typed factory?

Is there any way we could achieve the below factory pattern in function app?
https://github.com/castleproject/Windsor/blob/master/docs/typed-factory-facility-interface-based.md?
I really appreciate any guidance on this regards.

While I think it will be quite hard to implement this with the Microsoft Dependency Injection, you could also have this with my Nuget package. This extension uses what ever IoC container is returned from the ServiceProviderBuilder. There is a package (https://github.com/volosoft/castle-windsor-ms-adapter) that wraps a Castle WIndsor container into an IServiceProvider. You can use that with my Autofac example in the readme.

Thanks @BorisWilhelms . I'll have a look at it.


LDAP load testing capability for Gatling

Like JMeter, it's probably good to add LDAP load testing feature in Gatling?

Sorry, alrady discussed here: https://github.com/gatling/gatling/issues/305.


[EPIC] Ansible and CLI re-design PoC

https://github.com/epiphany-poc

Closing as it was moved internally.


GTP-u in linux kernel

Is your feature request related to a problem? Please describe.
I'm  working on GTP and I need to recompile the kernel for every release to activate the GTP in kernel
I need to do
add the GTP-u support in kernel
diff --git a/Microsoft/config-wsl b/Microsoft/config-wsl
index ab578e1c8891..b5de4c6a7fda 100644
--- a/Microsoft/config-wsl
+++ b/Microsoft/config-wsl
@@ -1840,7 +1840,7 @@ CONFIG_IPVTAP=y
 CONFIG_VXLAN=y
 CONFIG_GENEVE=y
 # CONFIG_BAREUDP is not set
-# CONFIG_GTP is not set
+CONFIG_GTP=y
 # CONFIG_MACSEC is not set
 # CONFIG_NETCONSOLE is not set
 CONFIG_TUN=y
    add the GTP-u support in kernel

diff --git a/Microsoft/config-wsl b/Microsoft/config-wsl
index ab578e1c8891..b5de4c6a7fda 100644
--- a/Microsoft/config-wsl
+++ b/Microsoft/config-wsl
@@ -1840,7 +1840,7 @@ CONFIG_IPVTAP=y
 CONFIG_VXLAN=y
 CONFIG_GENEVE=y
 # CONFIG_BAREUDP is not set
-# CONFIG_GTP is not set
+CONFIG_GTP=y
 # CONFIG_MACSEC is not set
 # CONFIG_NETCONSOLE is not set
 CONFIG_TUN=y

Is it possible to enable it by default ?
I used it since 6 months without issue.

@benhillis I'm not real familiar with this module. At first glance, some potential negatives are:

I'm guessing that it is not something that would be widely used. It would be nice if some other users spoke up and disproved my assumption here.
A fraction of the WSL2 users will ever use GTP-u but, with the current limitation requiring that everything be built-in to the kernel, every user would have it enabled.

An additional attack surface is present with no way to denylist the module
An additional maintenance cost when flaws/bugs are found in GTP-u

The obvious positives are that @jbdamiano wouldn't have to do this manual (re)enablement work on every WSL2 kernel release and there would be no roadblocks for future users that come along wanting to use GTP-u.

@tyhicks The GTP-u protocol is used to encapsulate the traffic from layer 3 in Telecom data plane layer. It's needed when you are working on Telecom node.
In the kernel SCTP is activated and used also in Telecom node and I 'm guessing that it is not something that would be widely used except in Telecom business.

With the <IP_ADDRESS> WSL2 from linux supports module, GTP could be activated as a module

In addition, with this new kernel version, add the GTP in the kernel removed the module support.

@benhillis @tyhicks I update this issue opened 2 years ago


Nividia Drivers with Linux 5.1 are broken

Issue description
Nividia Prop drivers appears to have a missing dependancy and is unable to build correctly with the Linux 5.1 Kernel
Steps to reproduce
sudo nix-rebuild boot --upgrade
Technical details

system: "x86_64-linux"
host os: Linux 5.0.13, NixOS, 19.09pre178675.24debf74ef5 (Loris)
multi-user?: yes
sandbox: yes
version: nix-env (Nix) 2.2.2
channels(root): "nixos-19.09pre178846.7defc47944f"
channels(falcon): "nixos-19.09pre177249.dfd8f84aef1"
nixpkgs: /nix/var/nix/profiles/per-user/root/channels/nixos

If anyone knows how to keep nix on 5.0.13 that would be appreciated

Well, you had to explicitly override kernel version (default is 4.19 on master).  So you do i the same way in configuration.nix
boot.kernelPackages = pkgs.linuxPackages_5_0;

(there are many equivalent ways)

Here's the tail end of the build where it errors:
  CC [M]  /build/kernel/nvidia-uvm/uvm8_gpu_isr.o
  CC [M]  /build/kernel/nvidia-uvm/uvm8_procfs.o
  CC [M]  /build/kernel/nvidia-uvm/uvm8_va_space.o
  CC [M]  /build/kernel/nvidia-uvm/uvm8_va_space_mm.o
/build/kernel/nvidia-uvm/uvm8.c:187:14: error: initialization from incompatible pointer type [-Werror=incompatible-pointer-types]
     .fault = uvm_vm_fault_sigbus_wrapper
              ^~~~~~~~~~~~~~~~~~~~~~~~~~~
/build/kernel/nvidia-uvm/uvm8.c:187:14: note: (near initialization for 'uvm_vm_ops_disabled.fault')
/build/kernel/nvidia-uvm/uvm8.c:525:21: error: initialization from incompatible pointer type [-Werror=incompatible-pointer-types]
     .fault        = uvm_vm_fault_wrapper,
                     ^~~~~~~~~~~~~~~~~~~~
/build/kernel/nvidia-uvm/uvm8.c:525:21: note: (near initialization for 'uvm_vm_ops_managed.fault')
/build/kernel/nvidia-uvm/uvm8.c:526:21: error: initialization from incompatible pointer type [-Werror=incompatible-pointer-types]
     .page_mkwrite = uvm_vm_fault_wrapper,
                     ^~~~~~~~~~~~~~~~~~~~
/build/kernel/nvidia-uvm/uvm8.c:526:21: note: (near initialization for 'uvm_vm_ops_managed.page_mkwrite')
/build/kernel/nvidia-uvm/uvm8.c:609:21: error: initialization from incompatible pointer type [-Werror=incompatible-pointer-types]
     .fault        = uvm_vm_fault_sigbus_wrapper,
                     ^~~~~~~~~~~~~~~~~~~~~~~~~~~
/build/kernel/nvidia-uvm/uvm8.c:609:21: note: (near initialization for 'uvm_vm_ops_semaphore_pool.fault')
cc1: some warnings being treated as errors
make[3]: *** [/nix/store/pkkqci7dx8iribbxy113l0q0sgwirp3x-linux-5.1-dev/lib/modules/5.1.0/source/scripts/Makefile.build:276: /build/kernel/nvidia-uvm/uvm8.o] Error 1
make[3]: *** Waiting for unfinished jobs....
make[2]: *** [/nix/store/pkkqci7dx8iribbxy113l0q0sgwirp3x-linux-5.1-dev/lib/modules/5.1.0/source/Makefile:1571: _module_/build/kernel] Error 2
make[2]: Leaving directory '/nix/store/pkkqci7dx8iribbxy113l0q0sgwirp3x-linux-5.1-dev/lib/modules/5.1.0/build'
make[1]: *** [Makefile:169: sub-make] Error 2
make[1]: Leaving directory '/nix/store/pkkqci7dx8iribbxy113l0q0sgwirp3x-linux-5.1-dev/lib/modules/5.1.0/source'
make: *** [Makefile:79: modules] Error 2
builder for '/nix/store/aqhsq692zhyxjd53v1ddgiqd3qhnqbi2-nvidia-x11-418.56-5.1.drv' failed with exit code 2
cannot build derivation '/nix/store/95dyl3w9dbn1wk51dbyq6kchnvbvg7zi-etc.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/3a54ihp9jxl498p8frdrgz0g83n8x2np-kernel-modules.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/hjzp48gvd33whb6q971gfj663n18zvr7-linux-5.1-modules.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/a1p6nbizgvh3cg8az9cvh01ws3q5xmym-system-path.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/miw0i8rj5jcyzwrk28saqp3jjqgcam9i-nixos-system-nixos-workstation-19.09pre178846.7defc47944f.drv': 1 dependencies couldn't be built
error: build of '/nix/store/miw0i8rj5jcyzwrk28saqp3jjqgcam9i-nixos-system-nixos-workstation-19.09pre178846.7defc47944f.drv' failed

The vm_fault errors are due to: https://github.com/torvalds/linux/commit/3d3539018d2cbd12e5af4a132636ee7fd8d43ef0
After this fix there are errors due to: https://github.com/torvalds/linux/commit/fcd70cd36b9bf697122538c9e38e8cf954b2342b
I'm currently testing a fix that I made on my own.

I tried to patch this, but given the amount of patching that would be needed, I think it would be better to add driver 418.73 which works fine with kernel 5.1. It is trivial to update, I updated it locally and don't see problems.

Sorry I got confused, didn't know we were already at 418.56. We just need to update to 418.74, I'll make a PR.

418.74 was added in https://github.com/NixOS/nixpkgs/pull/61164 and we are now on 430.26
Does that resolve the issue?

I believe so.  linuxPackages_5_1.nvidia_x11 builds for me now, and even the 5.2 RC as well.


KinematicBody colliding with meshes of a GridMap throws recover_from_penetration errors

Godot version: 3.2.2.stable

OS/device including version: Windows 10

Issue description:
When a KinematicBody moves through a Gridmap on the same layer, this error is thrown constantly:
recover_from_penetration: Condition "shape_idx < 0 || shape_idx >= cs->getNumChildShapes()" is true.
Steps to reproduce:
Have a kinematic body use move_and_collide/slide to move through a Gridmap tile.
Example video attached:
ExampleVIdeo.zip
Minimal reproduction project:

Physics Error repro.zip

This is not actually a physics problem, because it's correctly identifying that the StaticBody associated with the Mesh item has no CollisionShape. It's a problem with MeshLibraries (and related to #11888 which is about not being able to add shapes to a Mesh in a MeshLibrary). Basically, if the MeshLibrary Item has no shapes, it shouldn't be creating an associated StaticBody.

It happened to me without StaticBodies, only "visual tiles". I "solved" the issue by deactivating the collision layers of the purely graphical gridmap

The case of a compound collision shape with zero child shapes was being treated as an error in recover_from_penetration, causing an early return from the function, which could cause the recovery from other shapes to be skipped. In fact recovering from a compound collision shape with zero child shapes is very easy: just ignore it. I implemented this in https://github.com/godotengine/godot/pull/59864 because the previous early return caused a pretty bad bug (see the issue linked there). Hence, this issue here can be closed as well.
I agree with @madmiraal that it would be better if GridMap somehow would not create static bodies without shapes. This should be discussed in a separate issue.


fix(io): do not throw on close.

Signed-off-by: azjezz<EMAIL_ADDRESS>

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 99.97%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
3315

Relevant Lines:
3316

💛  - Coveralls


Please invite me to the GitHub Community Organization

Name
Akshit Savaliya
Discord Username (if applicable)
No response
Additional Context
It will be really great opportunity to join such a organization and learn new coding skills

@AGSAVALIYA Your not a member of this organization, please accept invite.


Reducing demo size with small devices

👷 Deploy Preview for gladia processing.

Name
Link

🔨 Latest commit
df5beabca21012cd48b042146b82d23d4397fae3

🔍 Latest deploy log
https://app.netlify.com/sites/gladia/deploys/643a8e5a95953600080583e1


Feat/safezadd: add safeZAdd

Unfortunately, lots of things changed in immudb 0.9.x, therefore, this became obsolete.


Fix required tinkerbell ip flag

During hardware generation we require a tinkerbell IP unless the
--skip-registration flag is specified. This patches the behavior that
made the --tinkerbell-ip flag mandatory in all cases.

/cc @gwesterfieldjr @panktishah26 @abhinavmpandey08 @ptrivedi @pokearu