Gitea ignores path to git binary

Gitea version (or commit ref): 1.9.4
Git version: <IP_ADDRESS>
Operating system: RHEL 7
Database (use [x]):

[ ] PostgreSQL
[ ] MySQL
[ ] MSSQL
[x] SQLite

Can you reproduce the bug at https://try.gitea.io:

[ ] Yes (provide example URL)
[ ] No
[x] Not relevant

Log gist:
N/A

Description
The current version of Git in the RHEL 7 repositories is <IP_ADDRESS>. This version is quite old so I would like to use one of the more recent versions available in the SCL repository. However, SCL packages install everything outside of the regular directories, in /opt/rh. I've set the PATH in the [git] section of my gitea.ini file to point to the git binary (/opt/rh/rh-git218/root/usr/bin/git) but gitea seems to completely ignore this option and keeps using the git version that it finds in it's PATH environment variable, which is /usr/bin/git

As a work-around I currently set Environment=PATH= in the systemd unit file for gitea to include /opt/rh/rh-git218/root/usr/bin/

OK, so looking at this - master and 1.9 don't use "git" directly except in one place as a fallback in git.Init and in the install page.
Do you have any more information about when the wrong git is used?
Is it when you're pushing/pulling over SSH because that's the only place I can think that won't use the correct git necessarily?

@zeripath that's a good question, how can I check? I just went with the information I found on the Configuration page in the site settings, it said "git version <IP_ADDRESS>" there even though I had configured the path to point to the newer version.

oh that's interesting... Let me have a look again...

Ah. Found this out - although we use GitExecutable throughout our code, the code to use [git] PATH= is in 1.10 not 1.9.4.
If you cannot use 1.10-rc or master but can recompile gitea you would be able to change the default value from the linker using LDFLAGS="-X "code.gitea.io/gitea/modules/git.GitExecutable=YOUR_PATH""

FYI #6772 is the PR that provided this function. It would likely be possible to cherry-pick it on to 1.9.4 too.

As this feature is implemented but not planned to be backported I will close this issue.

I have it fixed with the work-around right now and can wait for the proper release of 1.10, so no problem.

Sorry about that! There's definitely an issue with ssh though - I think that needs some more thought. We might have to be putting git on the executable path etc.


Fix ES module version

Description
To prevent issues like:
[pod/fs-drift-benchmark-client-3f5a0b88-1-5xlqb/fs-drift] RUN STATUS DONE
[pod/fs-drift-benchmark-client-3f5a0b88-1-5xlqb/backpack] Input dictionary is empty for module ocp_default_ingress_controller
[pod/fs-drift-benchmark-client-3f5a0b88-1-5xlqb/backpack] Input dictionary is empty for module ocp_dns
[pod/fs-drift-benchmark-client-3f5a0b88-1-5xlqb/backpack] Input dictionary is empty for module ocp_kube_apiserver
[pod/fs-drift-benchmark-client-3f5a0b88-1-5xlqb/backpack] Input dictionary is empty for module ocp_kube_controllermanager
[pod/fs-drift-benchmark-client-3f5a0b88-1-5xlqb/backpack] Input dictionary is empty for module ocp_network_operator
[pod/fs-drift-benchmark-client-3f5a0b88-1-5xlqb/backpack] Unknown indexing error: The client noticed that the server is not a supported distribution of Elasticsearch
[pod/fs-drift-benchmark-client-3f5a0b88-1-5xlqb/backpack] Indexing exception found The client noticed that the server is not a supported distribution of Elasticsearch
[pod/fs-drift-benchmark-client-3f5a0b88-1-5xlqb/backpack] Closing Redis connection
[pod/fs-drift-benchmark-client-3f5a0b88-1-5xlqb/backpack] Attempting to close ES connection

cc: @dry923 @bengland2


Remove unnecessary cloning of govuk-content-schemas

As of ebd6d0c370145eb1acd42ad1477f931c1368b994 the tests no longer depend on
govuk-content-schemas itself.

:+1:


Elaborate and fix metricq version string

TL;DR: git-builds now have a version string like "metricq-cpp/r500.g5a7781d". Makes answering the question "Which git commit of metricq was this build from?` a lot easier.
Use ${CMAKE_CURRENT_SOURCE_DIR instead of ${CMAKE_SOURCE_DIR} when deducing version strings from git.  This fixes version strings of parent project including metricq as a submodule having their version show up in metricq::version(); which is all kinds of wrong.
Additionally, we tweak the version string format to make it easier to figure out from which source commit/release a client was built.
If the current CMake source directory is cointained in a .git repository, we try and generate a version string from git history, which includes the latest metricq commit hash.
If not, we'll simply use $metricq_VERSION as defined in CMakeLists.txt.
The general format of this is either (in a non-git directory, e.g. a release tarball):
  v$MAJOR.$MINOR[.$PATCH]

or (when building in a git directory or git submodule)
  r$REV_COUNT.g$HEAD_REV

where $REV_COUNT is the number of revisions since the root commit (git rev-list --count HEAD), and $HEAD_REV is the (abbreviated) commit hash of latest commit.
Any competent™ version comparison tool should be able to deduce that "r42.g1234abc < v1.0".
In the future, when there is a git tag v1.0, version strings of in-git builds should be formatted as
  v$MAJOR.$MINOR[.$PATCH].r$REV_SINCE_LAST_VER.g$HEAD_REV[-dirty]

similar to what git describe --long --tags --dirty outputs.

As we discussed, this isn't needed anymore.


Logo redesign

We are changing the name and logo of the project.  We need big ones and small ones please. The ones we created before were only small for the app, but we also need some larger ones to put on github pages, and docs, and other places.
@dimakrsna please change all appearances of "koto" to "peacenik"
EXCEPT - the name of my company remains Koto LLC. So the footer copyright should be Koto LLC.

Logos attached

EPS Document (with font)
https://drive.google.com/file/d/1Feq1WZqqcmtzuxyH_4cmpcXUbN6GUZnT/view?usp=sharing
Illustrator file:
https://drive.google.com/file/d/1MZ6iWyQdrYqGagTdRdszd63esFYjqwfJ/view?usp=sharing

Logos attached

EPS Document (with font)
https://drive.google.com/file/d/1Feq1WZqqcmtzuxyH_4cmpcXUbN6GUZnT/view?usp=sharing
Illustrator file:
https://drive.google.com/file/d/1MZ6iWyQdrYqGagTdRdszd63esFYjqwfJ/view?usp=sharing

@mreider The name "koto" remains in the references koto.at
In the rest places changed

@mreider The name "koto" remains in the references koto.at
In the rest places changed


feat: Template ingress annotations

Description of the change
Template the ingress annotations
My use case is to have variations of a chart with a unique title for gethomepage

Removed

Fixed

Added

Changed
Template the ingress annotations

Benefits
Allows for template functions to be used in ingress annotations

Possible drawbacks
Can't use any of {{ or }} out of the box. Not likely to be the case for annotations

Applicable issues

fixes #

Additional information

Checklist

[X] Title of the PR conforms to the Conventional Commits standard.
[X] Scope of the of the PR title contains the chart name.
[X] Chart version in Chart.yaml has been bumped according to Semantic Versioning.
[X] Chart artifacthub.io/changes changelog annotation has been updated in Chart.yaml. See Artifact Hub documentation for more info.
[X] Variables have been documented in the values.yaml file.

There, I think i followed all the items in contributing :)
no biggie if you don't want it, but its useful to me, but i also have work arounds :)

Heya, thanks for the PR! I'll go over the work tomorrow 👍🏻 I'll also see if I can implement something similar for the other object classes

oh sweet, if you have something else better to use than 👍
feel free to hand it back to me too


Redo site listing to be a list

gut additional elements. Just a list w/ details that's filterable maybe via grafitto. Also require login to get to it.

like this. much more straight forward as to what to do.

happy to close this bc of what it means now :)


docs: add hypernova-vue link in readme

I added the link for hypernova-vue.
VueOnRails is currently using hypernova and hypernova-vue.
This package can be helpful to enable Vue.js developers to adopt Hypernova in their current stack.

Hi @ljharb, I believe the link is useful for Vue.js developers. Someone reported an issue before about trying to use Vue.js with Hypernova, and the ticket was closed because the issue reporter tested it and validated it. https://github.com/airbnb/hypernova/issues/51
Should we add it?

@duoertai could you please create a new PR for this change, as the branch for the old PR could not pass CI builds.

Please do NOT create a new PR; this one should be repurposed.


Add cleanCSS level 2 optimizations flag

Add cleanCSS level 2 optimizations flag. This applies more aggressive css reshaping such as combining rules and cuts the index.html size from 3,447 bytes to 3,435 bytes.

Level 2 optimisation changes
body {
font:18px -apple-system,BlinkMacSystemFont,sans-serif;
line-height:1.4;
...
}

into
body {
font:18px/1.4 -apple-system,BlinkMacSystemFont,sans-serif;
...
}

Looks perfect to me and I'll merge as soon as I test in few more browsers.
Thank you.

Will merge now.
By the way, the site is deployed after each commit to master. You can always see it live 30 seconds after I merge. I've also added a Netlify badge in the README so you can see the status.
Thank you.


[build] Fix winelib build

[build] Fix x86 crossfile
[util] Fix version.h build order
[util] default is reserved keyword
[util] Headers are case sensitive (Windows.h)
[util] Missing WINE definitions
[dx9asm] Use std::max
[d3d9] Use std::size
[dx9asm, util] Missing headers for std::memcpy, std::invoke,
std::reverse, std::max
[dx9asm] Fix -fpermissive errors (this-> and pushObject)

To solve linker error I have had to modify /usr/include/wine/windows/d3d9.h (https://source.winehq.org/git/wine.git/blob/ea9253d6d3c9bb60d98b0d917292fc0b4babb3dd:/include/d3d9.h#l1620)
like this:
-STDMETHOD(GetAdapterDisplayModeEx)(THIS_ UINT adapter_idx, D3DDISPLAYMODEEX *mode, D3DDISPLAYROTATION *rotation);
+STDMETHOD(GetAdapterDisplayModeEx)(THIS_ UINT adapter_idx, D3DDISPLAYMODEEX *mode, D3DDISPLAYROTATION *rotation) PURE;

Probably WINE typo, but I'm not sure.


Example app to look at implementation?

Hi, first off, thanks for making this. I'm making a new Rails 7 app and want to use JSX in my code. Is there an example app I can look at somewhere that uses this to see how everything is typically set up?

Please use discuss.rubyonrails.org for usage help ✌


Remove UUID from print details

This resolves #635. Makes two special types of objects when calling Details.__str__:

keys where you don't print at all (currently only __uuid__, but can be extended)
types where you use repr instead of str (currently only Ensemble, but can be extended)

I think I would exclude all entries starting with a _ by default. Question is, if you add an option to show otherwise hidden keys. Maybe just state in the docs that a key does not have to be private.

The only one that was being printed before was the UUID. Keep in mind, this is the Details object. We don't add much to it that we don't specifically intend to save there. However, since the UUID gets added to everything....

Exactly, everytime we change the StorableObject we need to change the details object as well. That is, what I had in mind. Not print things that are supposed to be hidden. But we can merge this and change it again, when this becomes necessary.


Update changelog?

0.7 hasn't been updated in a long time, and it sounds like a good number of people are using 0.8 via edge/Github.
I'm considering doing the same, but I can't find a better changelog than looking through a massive commit/pull request list.
Request
Could the changelog be updated to reflect all the changes that would presumably eventually be added before 0.8 is published any?
I would like to at least mentally prepare to make the move, and would rather not have to click on every closed pull request.
Suggestion
In the few projects of my own where I maintain changelogs, I've been adding notes to the changelog under the presumable next version at the time of merging the changes, which makes it much easier to cut new releases.  I can publish when appropriate without having to retroactively build a big changelog entry.
Would that reduce publish friction for Ractive?
Possible side discussion point
If Ractive 0.8 is the current "version in use" by the heaviest Ractive users, should it just be released as is?  Any open bugs could be released later under patch releases, and any features currently tagged for 0.8 could be bumped to 0.9, and all the current 0.9 milestone issues could move to 0.10.
I know there's usually some trepidation around large projects bumping versions, but if all the major contributors have moved on from 0.7, leaving the year-old version on npm seems a bit awkward.
Possible side-side discussion
Versioning would be easier if 1.0.0 was out and breaking/feature/patch version numbers were all on the table.  Ractive seems pretty stable overall - unless there's some pie-in-the-sky plan to magically become even-more-stable eventually, why not take the leap past 0.x?

Sorry to the Ractive issue followers who get updates by email - I accidentally submitted this issue before I'd finished typing it.  Why haven't I learned to just write everything in my editor and paste into the browser at the last second? 😿

If you switch to edge on the docs site, the migration guide has a major- and breaking-changes list.
As to releasing 0.8, I agree that it would be good to get away from 0.7 being what everyone gets by default. Unfortunately cutting a release is a non-trivial thing and there are a few bugs that need to be addressed before that point. We're getting closer though, as I don't think there are any super serious bugs that don't have a potential fix pending.

What all is involved in publishing a release?  I'm guessing there are steps not in the release scripts, but I don't know where to figure out what they are.
Another question while I'm asking "how does it work" questions: what's the release plan for patching bugs in released versions without releasing other code in dev?  Check out the commit of the last patch release on that version number, fix it in a branch, publish from that branch, and then merge that branch into the dev branch and delete the patch branch?

Oh, and thanks for pointing me at the edge migration guide, that looks quite useful.  It does point back to the changelog file though! :-)

Well, the PR for 0.7 should give you an idea of what needs to happen before a release #1784. The IE stuff in particular needs to be addressed. I know @MartinKolarik has already braved a good bit of that particular dungeon. See also #1253 - I think only Rich can publish to npm.
I think tags and branches would be the way to go to handle bug fixes for older releases going forward. Unfortunately the early changes in 0.8 are just too big to keep anywhere close to in sync with master. Changes going forward should be less drastic. An alpha/beta/RC cycle for majors would be nice, but I don't know if that would be feasible time-wise.
I think we're getting pretty close to being able to have a 1.0 release, meaning nothing super huge should happen, like the more-or-less complete rewrite in 0.8 by @martypdx and @Rich-Harris. I'm sure there will still be plenty of semver major bumps left after 1.0. I would guess there's a 0.9 and probably a 0.10 between here and there though. Ultimately it's up to the bdfl.

0.8.0 is out and 0.8.1 will be out shortly with some bug fixes. The changelog is updated, so I'm gonna close this :smile:


Volunteership Card UI Update #649

This issue was created for developing a Volunteership cards section. These are developed using HTML and CSS with all instructions provided in requirement . Those cards  are responsive and mobile friendly. Let me know any changes to be done further. I have attached the screenshot as well.

Do not mess up the directory structure..!


tooltip appears on click and is not dismissed on iOS mobile

Hi,
First, thanks for this library!
I'm using this on iOS mobile, there are two issues I am noticing right now:

An element that is hovered over on the desktop browser and displays the tooltip, will show the tooltip when clicked on in mobile iOS

the tooltip that appears after the element is clicked does not go away without scrolling the page

I'm guessing this might have something to do with the event listeners, maybe it needs support for touch events? I can help troubleshoot, but wanted to submit this just in case anyone else has run into it and what the best solution would be.
This is reproducible with the example page by opening it in iOS simulator for iPhone. http://wwayne.com/react-tooltip/
Update 1: Doing something like:
var isMobile = /iPhone|iPad|iPod|Android/i.test(navigator.userAgent);
if (isMobile) {
    return;
}

in showTooltip fixes the issue. Not sure how you would feel about adding this.
Cheers.

+1

@mjw56 could you please elaborate a little more on that potential fix?

I solved this using globalEventOff={isMobile() ? 'click' : undefined} passed to the React-Tooltip component.

@elodszopos That causes the tooltip to never appear on mobile because clicking it triggers the eventOff and that's the only way to get it to show in the first place.

@Ardhimas that's weird.
Check out http://wwayne.com/react-tooltip/ -> "Custom event" -> left example.
Is it works for you on mobile? As for me, it does.

To everyone stumbling on this issue here is what I did to disable the tooltip on mobile:
const isMobile = /iPhone|iPad|iPod|Android/i.test(navigator.userAgent)

<ReactTooltip disable={isMobile} />

This way, you don't have to update the lib and you can control the behavior on your side.

There is a known issue with iOS safari where click events aren't being fired on non interactive elements, e.g. divs and spans.
See: https://developer.mozilla.org/en-US/docs/Web/Events/click#Safari_Mobile
I used a combination of the solutions above and cursor: 'pointer' to solve this issue for me:
const isMobile = /iPhone|iPad|iPod|Android/i.test(navigator.userAgent);

<ReactTooltip
  style={{ cursor: 'pointer' }}
  globalEventOff={ isMobile ? 'touchstart' : undefined }
/>

Hey guys! I found a solution that works for me:
Handle tooltip close on iOS
globalEventOff={bowser.ios ? 'click' : undefined}

Handle tooltip open on any device because it didn't work on iOS
event='click'

both as prop of ReactTooltip
Remember include bowser as a dependency to check if you are currently on iOS.

click does not work on iOS as expected. have to use touchstart as @codenameyau suggested.
here's my solution:

desktop showing tooltip on hover.
mobile showing tooltip on click without testing UA.

data-event="touchstart focus mouseover"
data-event-off="mouseout"

globalEventOff="touchstart"

Hello and thanks for the solution proposed! I don't understand why this is not implemented inside the library yet ? It was not too simple to test the up-voted solution already, I'm using nextjs and i used this approach in a customized global instance:
import { useEffect, useState } from 'react';
import ReactTooltip from 'react-tooltip';

export const ToolTip = () => {
  const [isMobile, setIsMobile] = useState(true);

  useEffect(() => {
    setIsMobile(/iPhone|iPad|iPod|Android/i.test(navigator?.userAgent));
    // alert(/iPhone|iPad|iPod|Android/i.test(navigator?.userAgent));
  }, []);

  if (isMobile) {
    return null;
  }

  return (
    <>
      <ReactTooltip
        className="tooltip"
        effect="solid"
        delayShow={300}
        border={true}
        // globalEventOff={isMobile ? 'click' : undefined}
      />
    </>
  );
};

Hi guys, can someone do the PR with the fix, please?
Also, I'll add the label of V5 to let this one be tracked while we develop the V5 from scratch, thanks!

Hi, can someone test the alpha release of V5 and let me know if this issue still happens, please?
https://react-tooltip.com/docs/getting-started
I'll close this issue in few days of no one answer :)

Hi, can someone test the alpha release of V5 and let me know if this issue still happens, please?
https://react-tooltip.com/docs/getting-started
I'll close this issue in few days of no one answer :)

It is still present

@fiorins Please open a new issue providing a reproducible sample.


[Peek] Remove WIC project and only keep used ComImport

Summary of the Pull Request

Cleanup WIC code by removing the WIC project and only keeping the used classes in the Peek.Common project.

Validation Steps Performed

Tested against raw image files that were dehydrated to trigger our WIC use scenarios.

I've added a commit to try and fix spellcheck

Hi @SamChaps ,
Do you feel like this one is ready to go in? 😉


Undefined behavior in read

The implementation of read invokes UB by using SoapySDRDevice_readStream to write to buffers which is behind a shared reference. It can probably be solved by changing the signature from &[&mut [E]] to &mut [&mut [E]] unfortunately that's a breaking change.

Good catch, thanks for noticing. Fixed in 4d61a6416d4e9a8fb0852dc562b5904b1f285470.
Let me check if there are other breaking changes that are desirable, and I'll publish 0.4 soon.

Released in 0.4.0


Fix Leppa Berry protocol message

Apparently the move data that stores PP doesn't have a "name" property.

Reliant-ish on #346, but can live without it (it'll just show the move as lower case instead)

what the hell travis

Okay, Travis, why you fail to download Node 0.12, continue in Node 0.10, and then the test freezes for some reason.

must be an April Fools' thing

Can't edit on mobile, but when I said 346, I meant Zarel/Pokemon-Showdown-Client#346 whoops

IDs have never been allowed in the protocol. Please use this.getMove(...).name.


bumping packages to 0.2.30

/cherrypick release-0.14

Waiting for the checksums?

Waiting for the checksums?

/lgtm
/approve


Fix typos

Oh, thanks for your commit!
I have merged this commit into branch: sitesrc
The branch gh-pages is readonly : )


feat(hls): expose manifest skd uri on drmInfo

I'll take a look, probably missed something because I was cherry-picking the changes.


The Guacamole.Keyboard only use Guacamole.Keyboard(document),but use in Guacamole.Keyboard(selfElement).

Guacamole.Keyboard(document) will cover global window ,event of window can't use it.
Event of Guacamole.Keyboard(selfElement) is invalid ,keyup and keydown can't trigger.
Keybord.reset() is also invalid.
var keyboard = new Guacamole.Keyboard(document); // events can use ,but cover global window object.
var keyboard = new Guacamole.Keyboard(document.getElementById('terminal')); // events can't use.

document.keyup=null and document.keydown=null is solve this problem.


Pump control is not working

I'm able to control the fans of my Kraken x62 however the pump stays fixed at 40% even ignoring the Force Apply flag.
There are no errors in the logs but there is the ? icon near the fan speed percentage

CAM is not open

@anphetamina Talk to Cardano  Support on the Cardano Live Support so that your issue can be looked into.
Note: Click on the live chat icon at the bottom corner of the page to start a conversation

I have the same Problem with my Kraken x72.

I have the same Problem.
For me both Pump and Fan don't do what they should.


Add support for custom pragma

Issue: #9
What Changed
New options have been added to use a custom pragma. (Such as h() instead or React.createElement().)

options.pragma (default: React.createElement)
options.pragmaImportSource (default: react)

How to test
I'm not certain. I've tested this in my own set-up and I've run the unit test suite.
That said, I'm not sure whether the unit tests cover loader.js.
Change Type

[ ] maintenance
[ ] documentation
[ ] patch
[x] minor
[ ] major

@shilman: Any thoughts on this one yet?


Reflect the renaming of our process calculus in the code base

We recently changed the name of our process calculus from “χ-calculus” to “♮-calculus”, because there is already another process calculus named “χ-calculus”. Our goal is to change the source code, file names, and documentation in both the Haskell and the Isabelle part of the code base to reflect this change.

Since we aren’t using the ♮-calculus anymore, as it has been replaced by the Þ-calculus, I’m closing this issue.


Add test case for ANSI pmod and ANSI Remainder

Contributes #5119
Signed-off-by: Chong Gao<EMAIL_ADDRESS>

Aready supported ANSI pmod and ANSI Remainder, it is just to add test cases.


example mnist-pytorch fails

example mnist-pytorch failed with following errors:
config file: https://github.com/microsoft/nni/blob/master/test/config_test/examples/mnist-pytorch.test.yml
Traceback (most recent call last):
  File "mnist.py", line 157, in <module>
    main(params)
  File "mnist.py", line 91, in main
    transforms.Normalize((0.1307,), (0.3081,))
  File "/home/chec/anaconda3/envs/nni/lib/python3.7/site-packages/torchvision/datasets/mnist.py", line 46, in __init__
    self.download()
  File "/home/chec/anaconda3/envs/nni/lib/python3.7/site-packages/torchvision/datasets/mnist.py", line 120, in download
    gzip.GzipFile(file_path) as zip_f:
  File "/home/chec/anaconda3/envs/nni/lib/python3.7/gzip.py", line 163, in __init__
    fileobj = self.myfileobj = builtins.open(filename, mode or 'rb')
FileNotFoundError: [Errno 2] No such file or directory: '/tmp/tensorflow/mnist/input_data/raw/train-images-idx3-ubyte.gz'

Then change maxTrialNum from 4 to 2, trialConcurrency from 2 to 1, got following errors:
Traceback (most recent call last):
  File "mnist.py", line 157, in <module>
    main(params)
  File "mnist.py", line 91, in main
    transforms.Normalize((0.1307,), (0.3081,))
  File "/home/chec/anaconda3/envs/nni/lib/python3.7/site-packages/torchvision/datasets/mnist.py", line 46, in __init__
    self.download()
  File "/home/chec/anaconda3/envs/nni/lib/python3.7/site-packages/torchvision/datasets/mnist.py", line 128, in download
    read_image_file(os.path.join(self.root, self.raw_folder, 'train-images-idx3-ubyte')),
  File "/home/chec/anaconda3/envs/nni/lib/python3.7/site-packages/torchvision/datasets/mnist.py", line 299, in read_image_file
    return torch.from_numpy(parsed).view(length, num_rows, num_cols)
RuntimeError: PyTorch was compiled without NumPy support

Manully upgrade pytorch from 0.4.1 to 1.2.0,  second problem solved.

problem fixed.


fix(package): remove semantic-ui-css dependency

I believe this was left over from when we used to bundle jquery plugins. We don't bundle any Semantic packages with ours.

Current coverage is 99.62% (diff: 100%)

Merging #580 into master will not change coverage

@@             master       #580   diff @@
==========================================
  Files           118        118
  Lines          1862       1862
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
  Hits           1855       1855
  Misses            7          7
  Partials          0          0

Powered by Codecov. Last update bceb7ef...f2e0797

Released in<EMAIL_ADDRESS>


Add public ips with service tags for LBs during cluster creation

Reason for Change:

As per the new security requirements, all traffic for our services  must be under a service tag. Cluster creation under ACN repo creates load balancers and the associated ips use default service tags provided by Microsoft. This change creates new public ips and attaches it with LBs during cluster creation phase.
Requirements:

Notes:

location: westcentralus
allowed ip range: <IP_ADDRESS> - <IP_ADDRESS>
ip address: <IP_ADDRESS>
Cilium Nightly Pipeline run

General Notes:
We had a couple of PRs out by Esteban and Shubham to update service tags. However, all of the PRs targeted hack/aks/Makefile, so I went ahead and made all of the updates in this branch.
Testing:
Tested changes in a couple of Cilium pipelines:
CNI Nightly Pipeline - similar as above, but with all of the final changes
location: westcentralus
allowed ip range: <IP_ADDRESS> - <IP_ADDRESS>
ip address: <IP_ADDRESS>
CNI Release Test
The cilium-overlay test fails at the scale test job, but this happens on the master branch for the same exact reason, so I believe that this is safe to merge, considering the other pipelines that have been run
All of the public ips created have service tags attached to them, and the ips fall within the allowed ranges for the locations they were created
Cilium Private Test on v1.14 as suggested by John Payne
Cilium Private Test on v1.16 as suggested by John Payne
ACN PR Pipeline
The failing test also fails in master, so I believe this is safe to merge considering the other pipelines that have been run

@k-routhu This will not be merged since the author of the PR has not agreed to the CLA (and likely won't). You will need to fork off of this branch and open a new PR.


Open FlatPickr when clicked on button

I have a button with a calendar icon next to the input box. How could I open the DateTimePicker when clicked on the button.
I tried this button didn't worked
$("#button").on("click", function () {
    $("#datetimepicker").flatpicker(options).open();
});

Is there any alternative way? Or this feature isn't supported?

https://chmln.github.io/flatpickr/examples/#flatpickr-external-elements

I know I am too late to comment


instanceof File

using instanceof in an if statement worked in 5.7, it does not in 5.8, if I remove the if statement everything works as it should.  Do we have a new way to test the instanceof?  I'm doing this in a block controller -thanks
$f = File::getByID($this->fID);
if($f instanceof File){
bla bla bla
}

if ($file !== null) and (even shorter) if ($file) should both work

Yes, in my case $f, it works. I think in 5.6/5.7 it was preferred to use instanceof File, no backward compatibility problems just using $f?

Yeah the problem is probably that the File object itself has changed. It's now Concrete\Core\Entity\File\File, instead of Concrete\Core\File\File

I would just use
if (is_object($f)) {
...
}

but mlocati's suggestions are good as well

I've been using the if ($file) but came across an issue if used with an image attribute that has had its related file deleted.
//Define an image_file attribute ('thumbnail')
//Pick an image and assign it to a page via the new thumbnail attribute
$file = $c->getAttribute('thumbnail');
//Delete the original image
//The page attribute now contains an orphaned fID which throws up a fatal Error

Is there a way to check that the file is actually present?


Add setup url config

Config setting without use-case? I would re-submit this together with the code that uses it.

This was discussed in the Configuration Editor thread in the mailing list.
Added a link to the coapp in the admin menu.

I'm aware of what has been discussed - but adding a setting without also adding the use-case for it is obviously a bit pointless or at least premature.
Better now - but you should of course use the getter to retrieve the setting, not access the dict directly.

Sorry for that. Done now :)


Adding a base npm middleware and making it public

Summary of the changes (Less than 80 chars)

Added a more generic npm middleware and making it public
Changed the Angular CLI and React dev server middleware to use the new npm middleware
The change makes it possible to create a custom middleware for other SPA frameworks, for example, Vue.js

Addresses #5214 (partially)

I'm fine with doing this sort of thing, but I do think the APIs this creates are very unusual.
        public static void Attach(ISpaBuilder spaBuilder,
            string npmScriptName,
            Func<int, string> npmParameters,
            Func<int, IDictionary<string, string>> envVars,
            Regex outputMatch, Func<Match, int, Uri> listeningUri)

We don't usually have people pass things like Func<int, string>. It's not obvious for the caller what their callback is meant to do here, or what the int param is (I know it's the port, but I don't think it's obvious). It's also a bit sketchy to assume that all SPA server middleware is always going to make its "am I ready or not" decision based on a Regex match of some console process's output - that seems pretty specific to the way that Angular CLI and create-react-app work.
Perhaps rather than bundling all these assumptions together in one method, we should have a collection of separate methods you can pick the relevant ones out of, e.g. on some NpmHelpers class:

Process StartNpmScript(string scriptName, string arguments)
IAsyncEnumerable<string> ReadOutputLinesAsync(Process process)
Task PollForSuccessResponseAsync(Uri uri, TimeSpan timeout)

Then AngularCliMiddleware, ReactDevelopmentServerMiddleware, and external SPA dev server middlewares can be constructed more simply out of these primitives.
@ryanbrandenburg What's your preference on how the SPA middleware APIs should evolve?

We can have named delegates instead and it will be more obvious. At the
same time, I am not a big fan of coupling to npm, there’s an open issue
about yarn and it might be a good think to address that too. But I saw a
comment that the npm script runner will be moved to the Node Services
package and it wasn’t, so knowing the thoughts of moving forward would
definitely help.
On Fri, 1 Feb 2019 at 13:38, Steve Sanderson<EMAIL_ADDRESS>wrote:

I'm fine with doing this sort of thing, but I do think the APIs this
creates are very unusual.
    public static void Attach(ISpaBuilder spaBuilder,
        string npmScriptName,
        Func<int, string> npmParameters,
        Func<int, IDictionary<string, string>> envVars,
        Regex outputMatch, Func<Match, int, Uri> listeningUri)

We don't usually have people pass things like Func<int, string>. It's not
obvious for the caller what their callback is meant to do here, or what the
int param is (I know it's the port, but I don't think it's obvious). It's
also a bit sketchy to assume that all SPA server middleware is always going
to make its "am I ready or not" decision based on a Regex match of some
console process's output - that seems pretty specific to the way that
Angular CLI and create-react-app work.
Perhaps rather than bundling all these assumptions together in one method,
we should have a collection of separate methods you can pick the relevant
ones out of, e.g. on some NpmHelpers class:

Process StartNpmScript(string scriptName, string arguments)
IAsyncEnumerable ReadOutputLinesAsync(Process process)
Task PollForSuccessResponseAsync(Uri uri, TimeSpan timeout)

Then AngularCliMiddleware, ReactDevelopmentServerMiddleware, and external
SPA dev server middlewares can be constructed more simply out of these
primitives.
@ryanbrandenburg https://github.com/ryanbrandenburg What's your
preference on how the SPA middleware APIs should evolve?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/aspnet/AspNetCore/pull/7046#issuecomment-459709692,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACsMVZ2l2MkvoKWUHE5e9d41VUHanQ-Uks5vJDVIgaJpZM4aUtp7
.

--
Med vennligst hilsen / Best regards,
Alexey V. Zimarev

@SteveSandersonMS does this look align with our long-term vision in this area? The issue this is partially resolving is our plan (https://github.com/aspnet/AspNetCore/issues/5182). If this looks fine, let's ask @alexeyzimarev to rebase this so we can get this merged for 5.0.

@mkArtakMSFT As I commented above, I think we certainly could add a base NPM middleware. My concern is that the APIs proposed in this PR aren't what we would want, for the reasons described in my comment. I suggested some alternate API design thoughts in my comment.

Thanks for your effort, @alexeyzimarev.
After some further discussion we've decided that we don't want to take this PR as it's not a complete solution for https://github.com/aspnet/AspNetCore/issues/5182. We will instead come up with a design for the feature and tackle it then.


java.lang.NoSuchMethodError: feign.SynchronousMethodHandler$Factory.

Unexpected exception during bean creation; nested exception is java.lang.NoSuchMethodError: feign.SynchronousMethodHandler$Factory.(Lfeign/Client;Lfeign/Retryer;Ljava/util/List;Lfeign/Logger;Lfeign/Logger$Level;ZZLfeign/ExceptionPropagationPolicy;Z)V
spring-cloud-openfeign-3.1.3

Hello, @tongzige please provide a description of the issue, including steps to reproduce, the expected result and the actual result. Also, please provide a minimal, complete, verifiable example that reproduces the issue.

If you would like us to look at this issue, please provide the requested information. If the information is not provided within the next 7 days this issue will be closed.

Closing due to lack of requested feedback. If you would like us to look at this issue, please provide the requested information and we will re-open the issue.


Compatibility with Nix(OS)?

Hi, very excited to try this tool. Unfortunately Nix doesn't expose common executables on standard paths (/bin/ls, /bin/ld, etc.) so I'm not sure how to proceed. Any advice? I'm going to try to change the logic to perform a $PATH-based lookup, but not sure if absolute paths are desired. Would appreciate advice.

I believe this is a dupe of #1395.

Yeah I definitely want to fix this.

I'm gonna merge into #1395.


Error message when use: start firefox

Hello,
I got below error when use : start firefox. I installed the latest version of firefox: 48.0.2

An unhandled exception of type 'OpenQA.Selenium.WebDriverException' occurred in WebDriver.dll
Additional information: Failed to start up socket within 45000 milliseconds. Attempted to connect to the following addresses: <IP_ADDRESS>:7055

Firefox changed in version 48 and doesn't not work with selenium 2.5x ,
Selenium 3 is not out yet.  You have to use the older version of Firefox
until then.
On Sep 7, 2016 11:22 AM, "Quan Dai"<EMAIL_ADDRESS>wrote:

Hello,
I got below error when use : start firefox. I installed the latest version
of firefox: 48.0.2
An unhandled exception of type 'OpenQA.Selenium.WebDriverException'
occurred in WebDriver.dll
Additional information: Failed to start up socket within 45000
milliseconds. Attempted to connect to the following addresses:
<IP_ADDRESS>:7055
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/lefthandedgoat/canopy/issues/288, or mute the thread
https://github.com/notifications/unsubscribe-auth/AAsQ6X7gkXBjrZJDC-ZwGbTPE2zS-6Fyks5qnuTggaJpZM4J3G9m
.

ah.. I see. Thanks a lot!


Originating Identity may be null if platform does not support this feature

To make Unipipe OSB more publicly available and usable for the private use cases, we should convert our codes. Our model has a restriction around this header however the public docs explain that this is an optional parameter. Our OSB should have this parameter as nullable type and CLI should have it as dynamic model (not as strict models like meshmarketplace). Moreover maybe even we can automatically put the context.platform value ourselves if there is an originatingIdentity header or we can check that they are matching because it is mandatory requirement which is described in the API specs.
More info:
https://github.com/openservicebrokerapi/servicebroker/blob/master/spec.md#originating-identity

I think the CLI already tries to differentiate different profiles. Makes sense to make the broker not assume a specific platform profile when speaking OSB API, though it's fine to have support of all the extra meshmarketplace profile features when explicitly flagged as such. For example we should probably make sure that the metering documentation mentions that this is a meshmarketplace profile feature
11:50 $ unipipe list --help

  Usage:   unipipe list <repo>
  Version: 1.3.0 (vnext)

  Description:

    Lists service instances status stored in a UniPipe OSB git repo.

  Options:

    -h, --help                      - Show this help.
    -p, --profile        [profile]  - include columns of context information according to the specified OSB API    (Values: "meshmarketplace", "cloudfoundry")
                                      profile. Supported values are 'meshmarketplace' and 'cloudfoundry'. Ignored
                                      when '-o json' is set.


fix: dev not close

Codecov Report

Merging #93 (56ca3bb) into master (8cc4b24) will decrease coverage by 0.37%.
The diff coverage is 20.00%.

@@            Coverage Diff             @@
##           master      #93      +/-   ##
==========================================
- Coverage   82.77%   82.40%   -0.38%
==========================================
  Files          34       34
  Lines        2648     2660      +12
  Branches      748      750       +2
==========================================
  Hits         2192     2192
- Misses        414      426      +12
  Partials       42       42

Impacted Files
Coverage Δ

packages/serverless-spec-builder/src/fc/builder.ts
44.28% <0.00%> (-3.78%)
:arrow_down:

packages/cli-plugin-package/src/index.ts
82.06% <100.00%> (+0.03%)
:arrow_up:

packages/cli-plugin-dev/src/index.ts
79.32% <0.00%> (-0.56%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8cc4b24...56ca3bb. Read the comment docs.


Add support of the BlockKit to attachments

Ofgicial documentatiin claims to support blocks in attachment. Although there is a workaround for chat.postMessage, there is no such one for chat.unfurl that consumes only attachments. Please add it.

Thank you for this feature request. You're right. We should have blocks in an Attachment. https://api.slack.com/changelog/2018-12-a-bric-a-brac-of-broadcasts-built-with-blocks#how_do_i_prepare
I will work on it soon and the change will be included in a next release (possibly this weekend or early next week, JST)

Update: I'll work on this soon.

@efulmo I just started working on this. If I could know your needs correctly, it would be helpful.

Although there is a workaround for chat.postMessage

Could you share your workaround with some code examples?

there is no such one for chat.unfurl that consumes only attachments. Please add it

Could you share your ideal way to send blocks in the request?

Never mind regarding chat.unfurl. I still would like to know your workaround for chat.postMessage.

Oh I just meant ChatPostMessageRequest#blocks method. I see that you already implemented BlockKit in chat.unfurl.


Add expiration info to RPC server cookie

cookie being sent has expiration info
correct names of the headers

deprecated; http protocol is not supported anymore


ts-force-gen: Picklist (Multi-select) generates the type as string instead of string[]

version: 2.6.0
Example:
@sField({
   apiName: 'Groups__c',
   createable: true,
   updateable: true,
   required: false,
   reference: undefined,
   childRelationship: false,
   salesforceType: SalesforceFieldType.MULTIPICKLIST,
   salesforceLabel: 'Groups',
   externalId: false
})
public groups: string;

interesting, Looks like it only correctly generates as a [] when the enforcePicklistValues:true in the config.
Will fix

fixed in v2.6.2


fix: Fixed passive mode address when connecting from localhost

I'd rather see this expanded into if blocks instead of ternary operators.
And a function to test if a given IP is "local" would make it clear.
function isLocalIP(ip) {
  return ip === '<IP_ADDRESS>' || ip === 'localhost' || ip == '::1'
}

...

let address = this.server.options.pasv_url;
if (isLocalIP(this.ip)) {
  address = this.ip;
}

I think that IP can never be localhost because it's hostname. So it can be done like that:
function isLocalIP(ip) {
  return ip === '<IP_ADDRESS>' || ip == '::1';
}

...

let address = (isLocalIP(this.ip) ? this.ip : this.server.options.pasv_url);
// or
let address = this.server.options.pasv_url;
if (isLocalIP(this.ip)) {
  address = this.ip;
}

or maybe make pasv_url option as callback called every time when someone sends PASV command to the server? Connected user's IP will be passed to the callback parameters and server developer will handle connecting from localhost by itself.

If there becomes a need to make it a callback it can be. The only reason I see to make it a callback would be for this exact case.
That looks good to me. I'd rather the if block only because it's clearer to me at a glance.

That method can go in https://github.com/trs/ftp-srv/tree/master/src/helpers

Added to: https://github.com/trs/ftp-srv/pull/168


Problem

Hey! When I write this on my site:
// Import at the top
use Activity;
// Find latest users
$activities = Activity::users()->get();
// Loop through and echo user's name
foreach ($activities->users as $user) {
echo $user->name . '';
}
I became this error:
ErrorException in b75221df64d6887b27b0b34867838817 line 26:
The use statement with non-compound name 'Activity' has no effect (View: /var/www/html/resources/views/startsite/startsite.blade.php)
Can anyone help me? Thanks!

Short answer: You don't need to add use Activity; to your view files. :)
Longer answer: View files aren't in a defined namespace so it's in the "global" namespace. As a result, you don't need to add use Activity;. That is only a requirement for classes in a defined namespace like your controllers.

Thanks for your answer!
I have now remove „use Activity;“.
When I add into my view PHP File:
$activities = Activity::users()->get();
// Loop through and echo user's name
foreach ($activities->users as $user) {
echo $user->name . '';
}
Than I became also a error:
ErrorException in b75221df64d6887b27b0b34867838817 line 29:
Undefined variable: activities (View: /var/www/html/habbolando.com/httpdocs/resources/views/startsite/startsite.blade.php)
Line 29:
foreach ($activities->users as $user) {

Can you post the contents of your view file just so I can be sure of what's going on?

This is my content:
http://pastebin.com/729DtpCP

That is weird. Can you tell me what you get if you do this?
    <?php
    $activities = Activity::users()->get();
    ?>
    {{ dd($activities) }}

Also, on another note, thanks for pointing out an error in the docs. It should be:
foreach ($activities as $activity) {
    echo $activity->user->name;
}

I will update the docs when I get home.

$activities = Activity::users()->get();
foreach ($activities as $activity) {
echo $activity->user->name;
}
It works =)! Thank you <3!!!

Awesome! Sorry about that mistake.


wasm: update V8 to v8.8.278.8.

Signed-off-by: Piotr Sikora<EMAIL_ADDRESS>

//test/extensions/filters/http/wasm:wasm_filter_test            FAILED TO BUILD

FAILED TO BUILD?  :confused:

//test/extensions/filters/http/wasm:wasm_filter_test            FAILED TO BUILD

FAILED TO BUILD? 😕

Looks like there is a data race in std::shared_ptr that's caught by TSan during V8 build.
Not sure how that passed upstream. Might be also an older issue that's fixed in LLVM 11, since V8 is bundled with LLVM HEAD.

/lgtm deps


[Feature Request] Expose ref for use along with react hook form library

Is your feature request related to a problem? Please describe.
I'm using the the checkbox like this :
({ label, name }) => (
    <Controller
        key={label}
        control={control}
        {...register(name)}
        render={({ field }) => (
            <Checkbox
                {...field}
                label={label}
                isDisabled={isCheckboxDisabled(
                    name
                )}
            />
        )}
    />
)

But I get this error: https://github.com/react-hook-form/react-hook-form/issues/85
I think the problem comes from the fact the ref of the component is not accessible.
Describe the solution you'd like
Make the components' refs accessible for use with other libraries.
Describe alternatives you've considered
None.
Screenshots or Videos
No response

The Checkbox component does expose a ref, though, you can see it here:
https://github.com/nextui-org/nextui/blob/f85a569b4782e99124c752269867272dc91f6313/packages/react/src/checkbox/checkbox.tsx#L48
Maybe you can share your whole code to get a better picture of what your problem is.

Hey @xegulon as @Hdanzo the checkbox ref is available and work without problem, here's and example:
https://codesandbox.io/s/nextui-react-hook-form-ekesj8?file=/src/index.js

Hi @jrgarciadev, it looks like the TableBody component does not have a ref prop.
Property 'ref' does not exist on type 'IntrinsicAttributes & TableBodyProps<unknown>'

Should I open a new issue for this?
I think this could fall under this issue given the generic title and description (it refers to components in general, not to the checkbox specifically).
Thanks.


merge from konsum-frontend-svelte,template-svelte-app

package.json

chore(deps): add ^6.12.48 remove ^6.12.47 (devDependencies.npm-pkgbuild)

:tada: This PR is included in version 1.29.25 :tada:
The release is available on:

v1.29.25
npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Vehicles - Adjust maximum speed and acceleration parameters according to vehicle

Vehicle maximum speed has been removed until simulation reach enviroment out of urban enviroment.
Vehicles enter the map at urban speed limit meters per second and if they stop, they accelerate by their acceleration parameter in meters per square second.


Design of Auto complete component

Shared from Notify:
https://www.figma.com/design/RLcM0JwlQsd2uVK3GJr5qY/Templates-|-Gabarits?node-id=2866-891&node-type=canvas&t=7TVJQQacvFr9OGFW-0

From DFO: Searchable list
autocomplete-autofill-searchablelist.pdf

Check GC Forms implementation.


Use dict.get in case cost data key does not exist in response

Link to JIRA
DOM-XYZ
What issue does this pull request solve?
Some fields when retrieving cost data may not readily exist.
What is the solution?
Use Python's dict .get() method with a default of 0.
Where should reviewer start?
placeholder
Pull Request Reminders

[ ] Has relevant documentation been updated?
[ ] Has the JIRA ticket(s) been linked above?

References (optional)

Ah, closing. @ddl-martin-currao got it covered in https://github.com/dominodatalab/costs-dashboard/pull/11


Optimize performance by replacing a set of nodes with a bit in each node.

@swift-ci please test

rdar://74466708

@swift-ci please test

@CodaFi I am wondering if the driver still needs this transitive machinery at all. For example: if external dependency E is used by A in a fashion that will change B when E changes, will the frontend record that B depends on E? If so, we could remove all the transitive tracing code.

@swift-ci please test

@swift-ci please test


RELATED: RAIL-2407 improve tiger backend support

Changes domain to hostname, keeps its schema.
Adds default workspace value for tiger backends.
Fixes tiger proxy setup and authentication. For now the Login button is hidden in tiger
and we rely on the basic auth dialog.
Also removes react-components as they are no longer needed.

Build succeeded (check pipeline).

https://checklist.intgdc.com/job/client-libs/job/gooddata-create-gooddata-react-app-unit-tests-zuul-docker-el7/112/ : SUCCESS in 34s
https://checklist.intgdc.com/job/compliance/job/gooddata-create-gooddata-react-app-oss-check/96/ : SUCCESS in 4s

LGTM

Build succeeded (gate pipeline).

https://checklist.intgdc.com/job/compliance/job/gooddata-create-gooddata-react-app-merge-compliance-check/40/ : SUCCESS in 12s
https://checklist.intgdc.com/job/client-libs/job/gooddata-create-gooddata-react-app-unit-tests-zuul-docker-el7/113/ : SUCCESS in 15s
https://checklist.intgdc.com/job/compliance/job/gooddata-create-gooddata-react-app-fossa-scanning-zuul-el7/5/ : FAILURE in 11m 32s (non-voting)


Linaria example is outdated

In linaria folder:

if using with provided deps from lockfile everything is ok
using with latest @remix-run/* (currently 1.4.0 -> 1.7.0) deps breaks application with following error:

Unexpected Server Error

ReferenceError: React is not defined

updating linaria deps to latest (pnpm up "@linaria/*" -L) breaks build

Alternative str:

create-remix with basic setup
Follow steps from linaria example
Try to start

Sorry, linaria is no longer supported by this repository.

I created an issue for the ReferenceError: React is not defined:
https://github.com/callstack/linaria/issues/1338


Decorator warnings after the update to 7.0.1 (from 6.0.0)

I ran into some minor issues after updating from 6.0.0 to 7.0.1.
Peer dependencies are not satisfied for these two packages anymore because of<EMAIL_ADDRESS>npm WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>- 3.x but none is installed. You must install peer dependencies yourself.
npm WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>|| ^3.0.0 but none is installed. You must install peer dependencies yourself.

All decorators get reported as defined but never used, and functions using decorators are reported as is not defined.
/home/user/e/src/components/Transaction.js:2:10: 'translate' is defined but never used.
/home/user/e/src/components/Transaction.js:3:10: 'inject' is defined but never used.
/home/user/e/src/components/Transaction.js:3:18: 'observer' is defined but never used.
/home/user/e/src/components/AddressGet.js:4:18: 'computed' is defined but never used.

The ones above reference these imports.
import React from 'react'
import { translate } from 'react-i18next'
import { computed } from 'mobx'
import { inject, observer } from 'mobx-react'

export default @observer class Test extends React.Component {
  render () {
    return (

hello

    )
  }
}

Thanks, I'll investigate

This should be fixed in 7.0.3, could you check?

I'm getting the same response.
If you want to try yourself, you can git clone https://github.com/openvcash/vcash-electron and update your devDep to 7.0.3 and npm run format.
I've since switched to the method used in the issue referenced above for the time being (using eslint & prettier directly).

@whphhg I don't experience warnings you mention:
vcash-electron  node_modules/.bin/prettier-standard --version
7.0.3
vcash-electron  node_modules/.bin/prettier-standard 'src/**/*.js'
54 files were unchanged

I think you're getting these warnings because of && standard at the end of format script:
"format": "prettier-standard 'src/**/*.js' && standard"

standard is for linting, not formatting so it's reasonable you're getting extra messages (it's because prettier-standard is not able to automatically fix all rules standard uses, only fixable ones. for example it cannot automatically fix "is defined but never used." errors).

I understand the above (difference between the two use-cases). Sorry for a poor issue description. I think we're on the same page regarding what each packages does.
I'll try to better describe the issue. Please let me know if I have to do better on some parts.
Using<EMAIL_ADDRESS>there are no errors / warnings reported by standard. As soon as I upgraded a few weeks ago to<EMAIL_ADDRESS>I started seeing those warnings, but only after the files are saved, unchanged files in src/ directory don't have any warnings.
For example, after you've upgraded to 7.0.3 you saw warnings printed by standard for the files that prettier-standard formatted, the rest of the files should return the same warning because they use decorators as well, but they don't return any warnings. As soon as you just save one of those files, standard will report warnings for that file as well.

Ok so I'm getting the same error when I install prettier-standard, standard itself starts throwing the above errors that class properties are not defined.
yarn list standard:
└─<EMAIL_ADDRESS>
yarn list eslint:
├─<EMAIL_ADDRESS>└─<EMAIL_ADDRESS>   └─<EMAIL_ADDRESS>
yarn list prettier-standard:
└─<EMAIL_ADDRESS>
yarn list babel-eslint:
├─<EMAIL_ADDRESS>└─<EMAIL_ADDRESS>   └─<EMAIL_ADDRESS>
without prettier standard we have just one version of eslint and babel-eslint.
also getting the error without prettier-standard if babel-eslint's version is ^8.0.0.
So there is something fishy happening where installing prettier-standard makes standard's babel-eslint version to be ^8.0.0

@sheerun Any progress on this?

sdfsdfsdfd


Some questions about the layers

Hi, Diego! Thank you for sharing the code.
I have read and run the code in branch similar_impl_tensorflow. There are some questions I confuse about.
The paper of GAT tells that the author replaces concatenation with averaging of heads in the second (predict) layer in multi-head. But I only find
x = self.out_att(x, adj)  return F.log_softmax(x, dim=1)
in models.py. It happens in not only similar_impl_tensorflow branch but also master branch. Could you tell me if pyGAT contains this part? Thanks.
Besides, since the paper's output is h', which represents new features of entities. But the output of pyGAT's second layer is classification result. I believe both outputs of the first layer and the second layer are new features h', and the biggest difference between them is that the dimension of the latter one is equal to the dimension of nClass, am I right?
Thanks again,
Jason

Actually, if you read the Experimental setup (Transductive learning) part in the GAT paper, the second layer (output layer) is used for classification directly with out_features = number of classes.

The second layer is used for classification: a single attention head that computes C features (where C is the number of classes), followed by a softmax activation.


[software-bridges 2/x] report VF representor name in SriovNetworkNodeState.Status field

Add support for reporting VF representor name when the NIC is in switchev mode
Report VF representor field as described in the desing doc
Depends on #689, only second commit for review

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

21 of 180 (11.67%)  changed or added relevant lines in 6 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.3%) to 38.313%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

api/v1/sriovnetworknodepolicy_types.go
0
3
0.0%

pkg/host/internal/lib/sriovnet/sriovnet.go
3
6
50.0%

pkg/host/internal/lib/sriovnet/mock/mock_sriovnet.go
5
19
26.32%

pkg/host/internal/sriov/sriov.go
2
20
10.0%

api/v1/zz_generated.deepcopy.go
9
130
6.92%

Totals

Change from base Build<PHONE_NUMBER>:
-0.3%

Covered Lines:
4888

Relevant Lines:
12758

💛  - Coveralls

I rebased the PR and applied requested changes to the code. @SchSeba  please take another look, thx


Can't export abstract class by default

TypeScript Version:  2.0.3
Code
export default abstract class SomeClass {
}

Expected behavior: The code above should result in export by default of abstract class SomeClass.
Actual behavior: Compiler throws an error error TS1005: ';' expected.. Export in new line works fine:
abstract class SomeClass {
}
export default SomeClass

Duplicate of #3792 and others. Please be courteous to the team and search for existing issues first. Note that comment was for another duplicate of this same issue opened just a day ago.


Refresh api-tokens page

Related Issues

SURE-7885
Summary
We had a Slack request from support engineering. Upon further examination, the api-tokens.md page needs more work. The v2.8 page and latest have gotten out of sync. Looking at Git blame, the file in /docs still contains 2 year old content that was updated when we cut the v2.8 release.
From Slack:

Hello Team, :wave: This section does not work for 0 value. Setting TTL on kubeconfig tokens
“Admins can set a global time-to-live (TTL) on Kubeconfig tokens. Changing the default kubeconfig TTL can be done by navigating to global settings and setting kubeconfig-default-token-ttl-minutes to the desired duration in minutes. The default value of kubeconfig-default-token-ttl-minutes is 0, which means tokens never expire.” 0 value defaults to 89 days

Looks like things got messy in https://github.com/rancher/rancher-docs/pull/906, as the PR was created before a change in the branching strategy for releases, then got merged without updating /docs

If you check the ticket, you'll see that there's a dispute about the original ask, over whether the default value should set the token to an infinite lifetime or 89 days. There might be a bug causing the duration to be shortened to 89 days.

Closing since this particular problem with the page was resolved in #1184


"pwd -P" -> "pwd"

I just want to run the CI suite

[x] Have you followed the guidelines in our Contributing document?
[x] Have you checked to ensure there aren't other open Pull Requests for the same change?
[x] Have you added an explanation of what your changes do and why you'd like us to include them?
[x] Have you written new tests for your changes? Here's an example.

[x] Have you successfully run brew typecheck with your changes locally?
[x] Have you successfully run brew tests with your changes locally?

Hopefully this helps with ublue-os/bluefin#252

oh well

ok again

Interested in seeing this merged, as this might allow using Homebrew on Fedora Silverblue.

Interested in seeing this merged, as this might allow using Homebrew on Fedora Silverblue.

Thx! It’s an attempt, still trying. I remember it introduced some errors that I didn’t understand. You can try editing with vim $(which brew) or your favorite editor and change whatever.
You can always run brew doctor for instructions how to roll back.


Add net.delNode(), net.delLink() and associated methods

This makes the mid-level net.add*() API symmetric.
You can now delete hosts, switches, controllers and links using
a new net.del*() API, as well as del net[ 'nodename' ].

seems reasonable


buildroot: 2021.02.7

buildroot lts
busybox 1.34

Signed-off-by: Jacob Blain Christen<EMAIL_ADDRESS>

Shoot, this doesn't get us out of the woods at all. The busybox config I have is from 1.34.1 but the source from the buildroot tag is still 1.33.x: https://github.com/buildroot/buildroot/blob/2021.02.7/package/busybox/busybox.hash
Additionally, coreutils is stale: https://github.com/buildroot/buildroot/blob/2021.02.7/package/coreutils/coreutils.hash


Can rocketmq thread pool add a "bottom-up" scheme to catch exceptions

In BrokerController#initialize(), it will create many business thread pools. can we add "bottom-up" scheme to catch exceptions for business thread pools?
for example, class 'org.apache.rocketmq.common.ThreadFactoryImpl'
@Override
public Thread newThread(Runnable r) {
    Thread thread = new Thread(r, threadNamePrefix + this.threadIndex.incrementAndGet());
    thread.setDaemon(daemon);
    thread.setUncaughtExceptionHandler(new Thread.UncaughtExceptionHandler() {
        @Override
        public void uncaughtException(Thread t, Throwable e) {
            log.error("Uncaught exception in thread '" + t.getName() + "':", e);
        }
    });
    return thread;
}

@liuzongliang0202 Good catch! Do u willing to submit a pr to make it perfect?


read-manifest Sample is broken and StorageAdapter class obsolete

Cloning & building for the read-manifest solution fails due to missing system dependencies in read-manifest.
Second, i noticed the sample code is incorrect as AdlsStorage adapter doesn't exist - can someone please update this sample to function such that we can read from ADLS?

Third, when investigating where that went, I noticed our usage of StorageAdapter which is deprecated:

Hi seanmcne,
Closing this issue since I think this issue is replied via email. Please reactivate if necessary.

For others that coming into this thread with the same question, currently the adls project reference needs to be added into the sample project manually if the ADLSAdapter is used. We will add the references into the samples soon.


Cudnn makefile changes

Small cleanup changes on the build for cudnn. Added Windows support for cudnn. Tested on Ubuntu 22.04 and Windows 11.

I'm not amazing at Makefiles maybe there is a bit of a reasoning around what the changes here are and why they make sense?

@karpathy - notes on the above changes:
Windows changes - fixing the locations for the CUDNN_FRONTEND_PATH to (HOMEPATH and current directory) for Windows.


Clean out unused tools

To reduce complexity let's delete some dead code.
We never used to compare visual tool I introduced because we always worked with Mapbox Studio directly and also don't find ourselves using it now.
The tessera performance tests were used for the evaluation in the thesis and have no value in the context of osm2vectortiles.

This looks good to me.


installing to SD Card doesn't work

name: precise
encrypted: no
Entering /mnt/stateful_partition/crouton/chroots/precise...
crouton: version 1-20161116131524~master:9db73043
release: precise
architecture: amd64
xmethod: xorg
targets: lxde
host: version 8992.0.0 (Official Build) dev-channel setzer
kernel: Linux localhost 3.18.0-13451-gc264b5c #1 SMP PREEMPT Tue Nov 15 03:06:48 PST 2016 x86_64 x86_64 x86_64 GNU/Linux
freon: yes
Unmounting /mnt/stateful_partition/crouton/chroots/precise...

chronos@localhost / $ sudo edit-chroot -allc /media/removable/SD_Card/chroots
name: trusty
encrypted: no
mount: cannot remount /dev/mmcblk1p1 read-write, is write-protected

Please describe your issue:
in installation to an SD Card get so far thin this happens:
dpkg: unrecoverable fatal error, aborting:
 unable to fsync updated status of `iputils-ping': Input/output error
E: Sub-process /usr/bin/dpkg returned an error code (2)
E: Could not create temporary file for /var/lib/apt/extended_states - mkstemp (30: Read-only file system)
E: Could not open file /var/lib/apt/extended_states - open (2: No such file or directory)
E: Failed to open StateFile /var/lib/apt/extended_states
Failed to complete chroot setup.
Unmounting /media/removable/SD_Card/chroots/trusty...

apparently I'm no longer able to write to the SD Card without restarting chrome os, chrome os seems to think it's write protected now.
If known, describe the steps to reproduce the issue:
sudo mount /dev/mmcblk1p1 /media/removable/SD_Card

sudo sh ~/Downloads/crouton -r trusty -t gnome -p /media/removable/SD_Card

have since followed instructions at https://github.com/dnschneid/crouton/wiki/How-To-Install-To-External-Drive
chroot does not install correctly and has problems with circular mounting paths:
chronos@localhost / $ sudo umount /dev/mmcblk1p2
umount: /media/removable/chroots/chroots/trustycore/var/host/media/removable/chroots/chroots/trustycore/var/host/media/removable/chroots/chroots/trustycore/var/host/media/removable/chroots: target is busy
        (In some cases useful info about processes that
         use the device is found by lsof(8) or fuser(1).)


Add tutorial for Aurora Serverless v2

Co-authored-by: Chirag Dave (@cdaveaws)
Issue #, if available: N/A
Description of changes: This adds a tutorial for how to use ACK to manage Auroral Serverless v2 clusters.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@RedbackThomson Feedback addressed. Please let me know if you would like any additional changes.

/lgtm


fix(atomic): ensure redirection on instant result click

The redirection fails to occur based on the user's click location within the instant result.
This problem arises when the mouse click event target is 'atomic-result,' preventing the 'atomic-search-box-instant-results' from extracting the document URI.

https://github.com/coveo/ui-kit/commit/6a8641a0864618598fc221d1c11423affefeb0a9
getLink is called when we declare the Node/Element of the atomic-result we want to 'bind' ourselves to.
So let's just grab a ref and use it instead of depending on what exact element caught the click initially.


test debian on travis, too

We had issues with debian-8 in the past, so please add this to travis-ci

Interesting. /bin/systemctl --system enable smartmontools always fails on debian-8 however it seems to work in CI/docker…  (it's a systemd issue and upgrading systemd to jessie-backports fixes it)

Thanks


[C#] Unable to load assembly

Godot version
v3.5.rc5.mono.official [ae6059793]
System information
Windows 11, GLES3
Issue description
I want to use LitJson to Serialize Property, but when I run the scene, it throw a exception
System.IO.FileNotFoundException: Could not load file or assembly 'LitJSON, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=null' or one of its dependencies.
File name: 'LitJSON, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=null'

Here is mono log:
Loading reference 17 of C:/Users/redel/Documents/Projects/Move/Movalia/.mono/temp/bin/Debug/Movalia.dll asmctx DEFAULT, looking for LitJSON, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=null (in domain Mono, info)
Assembly Loader probing location: 'C:/Program Files/Godot/GodotSharp/Mono/lib\LitJSON.dll'. (in domain Mono, info)
Assembly Loader probing location: 'C:\Program Files\Godot\GodotSharp\Mono\lib\mono\4.5\/Facades\LitJSON.dll'. (in domain Mono, info)
Assembly Loader probing location: 'C:/Program Files/Godot/GodotSharp/Mono/lib\LitJSON.exe'. (in domain Mono, info)
Assembly Loader probing location: 'C:\Program Files\Godot\GodotSharp\Mono\lib\mono\4.5\/Facades\LitJSON.exe'. (in domain Mono, info)
Assembly Loader probing location: 'C:\Users\redel\Documents\Projects\Move\Movalia\.mono\temp\bin\Debug\LitJSON.dll'. (in domain Mono, info)
Assembly Loader probing location: 'C:/Program Files/Godot/GodotSharp/Mono/lib\LitJSON.dll'. (in domain Mono, info)
Assembly Loader probing location: 'C:\Program Files\Godot\GodotSharp\Mono\lib\mono\4.5\/Facades\LitJSON.dll'. (in domain Mono, info)
Assembly Loader probing location: 'C:\Users\redel\Documents\Projects\Move\Movalia\.mono\temp\bin\Debug\LitJSON.exe'. (in domain Mono, info)
Assembly Loader probing location: 'C:/Program Files/Godot/GodotSharp/Mono/lib\LitJSON.exe'. (in domain Mono, info)
Assembly Loader probing location: 'C:\Program Files\Godot\GodotSharp\Mono\lib\mono\4.5\/Facades\LitJSON.exe'. (in domain Mono, info)
The following assembly referenced from C:/Users/redel/Documents/Projects/Move/Movalia/.mono/temp/bin/Debug/Movalia.dll could not be loaded:
     Assembly:   LitJSON    (assemblyref_index=17)
     Version:    <IP_ADDRESS>
     Public Key: (none)
The assembly was not found in the Global Assembly Cache, a path listed in the MONO_PATH environment variable, or in the location of the executing assembly (C:\Users\redel\Documents\Projects\Move\Movalia\.mono\temp\bin\Debug\).
 (in domain Mono, warning)
Failed to load assembly Movalia[0000027436b55700]. (in domain Mono, info)

Steps to reproduce
Just run the scene
Minimal reproduction project
Playground.zip

You are targeting netcoreapp3.1 which is not officially supported in 3.x. Also, this sounds a lot like https://github.com/godotengine/godot/issues/42271 but you can workaround it with <CopyLocalLockFileAssemblies>true</CopyLocalLockFileAssemblies> (see https://github.com/godotengine/godot/issues/42271#issuecomment-751423827) although that seems to only work for netstandard2.0.
The default target in 3.x is net472, keep in mind you can still use a newer C# language version without changing the targeted framework, there's also NuGet packages that backport some features so you can use them in net472.


FilePicker just doesn't work.

Description
When I click on the filepicker button, nothing happens. I tried the examples from the documentation and they don't work either. Maybe some libraries need to be installed. I am running in a virtual environment.
Code example to reproduce the issue:
import flet as ft

def main(page: ft.Page):
    def pick_files_result(e: ft.FilePickerResultEvent):
        selected_files.value = (
            ", ".join(map(lambda f: f.name, e.files)) if e.files else "Cancelled!"
        )
        selected_files.update()

    pick_files_dialog = ft.FilePicker(on_result=pick_files_result)
    selected_files = ft.Text()
    page.overlay.append(pick_files_dialog)

    page.add(
        ft.Row(
            [
                ft.ElevatedButton(
                    "Pick files",
                    icon=ft.icons.UPLOAD_FILE,
                    on_click=lambda _: pick_files_dialog.pick_files(
                        allow_multiple=True
                    ),
                ),
                selected_files,
            ]
        )
    )

ft.app(target=main)

and also this one
import flet as ft

def main(page: ft.Page):
    page.theme_mode = "light"

    def result(e):
        page.add(ft.Text("result :)"))

    my_dialog = ft.FilePicker(on_result=result)
    page.overlay.append(my_dialog)

    page.add(
        ft.Row(
            [
                ft.ElevatedButton("Pick", icon=ft.icons.UPLOAD_FILE,
                                  on_click=lambda _: my_dialog.pick_files()),
                ft.ElevatedButton("Save", icon=ft.icons.UPLOAD_FILE,
                                  on_click=lambda _: my_dialog.save_file()),
                ft.ElevatedButton("Get Dir", icon=ft.icons.UPLOAD_FILE,
                                  on_click=lambda _: my_dialog.get_directory_path()),
            ]
        )
    )

ft.app(target=main)

Describe the results i received:
Nothing happens when I press it. It's like they're just normal buttons with no functionality. Also no message is displayed even in the terminal
Additional information:
I tried to run it in web, only pick_files works. Pick_dir and save_file don't work as well.
In windows it works correctly
Flet version (pip show flet):
Name: flet
Version: 0.7.4
Summary: Flet for Python - easily build interactive multi-platform apps in Python
Home-page:
Author: Appveyor Systems Inc.
Author-email<EMAIL_ADDRESS>License: Apache-2.0
Location: /home/rwm/Projects/SeeSerial_python/env/lib/python3.11/site-packages
Requires: flet-core, httpx, oauthlib, packaging, watchdog, websocket-client, websockets
Required-by:

Operating system:
Arch Linux.
kernel: 6.3.9
Additional environment details:
DE: Gnome 44.2
Please help me, I have no idea why this is happening.

Seconded. I am using the examples provided, even they don't work. I am also using Linux (ubuntu).

I can confirm. Running the examples as Ubuntu native app, none of the functions pick_files(), save_file() or get_directory_path() open the native file explorer (Nautilus on Ubuntu) unless I run the python executable with sudo privileges.
I cannot imagine this is intentional. Anyone found a solution? This is currently a showstopper for my app.

UPDATE to my previous comment:
Apparently I was a little bit too hasty... What I have discovered is that the above is true when running the script from VS Code, but not if running the script from Ubuntu terminal (x-terminal-emulator). Trying to find what's going on I came across this setting in VS Code: terminal.integrated.inheritEnv. Setting this to false makes file explorer launch as expected with all 3 above mentioned methods. (Still I have the issue if running debug in VS Code, but I assume it is related).
@R0w0m / @BedirT  - any comments on this? Maybe the same is true for you?

Another UPDATE for the possible benefit of future googlers:
Comparing the environments where

FilePicker launches the file explorer
vs
where FilePicker needs root-privileges to open file explorer

reveals that env var GTK_PATH=/snap/code/134/usr/lib/x86_64-linux-gnu/gtk-3.0 was set in case 2. Unseting this variable solves the problem for me.
The following links may be relevant:

https://askubuntu.com/questions/1462295/ubuntu-22-04-both-eye-of-gnome-and-gimp-failing-with-undefined-symbol-error
https://github.com/microsoft/vscode/issues/179274

Great discovery, thanks for sharing it!


readonly property should not be patched in patchMethod in v0.8.16

I'm getting the error while testing my application on Safari. It is fixed if I comment this lines (lines 1226 to 1228):
    proto[name] = function () {
        return patchDelegate_1(this, arguments);
    };

Inside function patchMethod(target, name, patchFn).
Could you please check it out?
Thank you

@manugarciac , could you post a reproduce repo?

@manugarciac @JiaLiPassion It works. i am wait for the next release

@JiaLiPassion That is the same file from this issue, right?
https://github.com/angular/zone.js/issues/859#issuecomment-318909774
I had already tested it with that before opening my issue, and no, it doesn't work.
@BillyQin What do you mean? The zip works for you?

@manugarciac , yes, it is the same file, so could you provide a reproduce repo?

@JiaLiPassion Here you go:
https://github.com/manugarciac/safari-error-app
You can do npm install and then ng serve to test it. The page loads, but the error is there. I start it like this: ng serve --host <IP_ADDRESS> --disable-host-check so that I can test it on another PC with Safari (I don't have Safari on my own PC).

@manugarciac , thank you, I will fix this one.


[kubernetes-backend-plugin] per-user authentication for AWS auth provider when using federated identities

Feature Suggestion
The current aws auth provider for the kubernetes-backend plugin allows Backstage to surface k8s objects from clusters using aws-iam-authenticator, which is neat! However, it does so by using a static/fixed IAM role/account to authenticate every call to k8s. Effectively the same role will be used to fetch data from k8s, regardless of the user accessing the kubernetes plugin!
The google auth provider, on the other hand, has the kubernetes and kubernetes-backend plugins collaborating so that the user is prompted to log in to Google on demand, and with the resulting access token Backstage authenticates as that particular user when making calls to k8s. In contrast, the aws provider almost seems like a confused deputy! Wouldn't it be cool if Backstage could have the same fine-grained respect for access control when accessing aws-iam-authenticated clusters as it does when accessing, say, GKE clusters?
Possible Implementation
Problem - AWS identities are not always federated
GKE clusters uniformly use OIDC authentication, and you can request a special scope from accounts.google.com just for accessing them. AWS APIs, on the other hand, authenticate with the AWS-specific 'security credential' (access key ID/secret access key/security token) mechanism, and IAM identities are not necessarily neatly federated with OIDC -- for example, access to your AWS account could always be brokered by a username/password. There's no secure way for Backstage to act on behalf of such users.
However, in the case when your AWS account uses web identity federation, I think it should always be possible to retrieve a user's identity via the GetCallerIdentity action - which is already being done by Backstage.
Values-file structure
What I can imagine is an app-config a bit like
auth:
  providers:
    aws-oidc:
      # ... same config options as the generic oidc provider ...
kubernetes:
  clusterLocatorMethods:
  - type: config
    clusters:
      - name: <cluster name>
        url: <apiserver URL>
        authProvider: aws-oidc

alternatively -- rather than introducing a provider type for the auth plugins -- the clusters entry could be smart enough to allow any of the existing OIDC-compatible providers (like auth0, gitlab, google, etc) to be specified.
User Experience
When you open the kubernetes tab for a service, you get the login popup; you click the log in button for this as-yet-undefined auth provider, finish up the OAuth2 authorization flow.
The problem is that at this point, all you have is an OIDC ID token, and you need a bit more data to effectively make a GetCallerIdentity request with creds specific to the federated user to whom the token belongs.
specify role ARN in app-config and use sts:AssumeRoleWithWebIdentity
The only potentially-awkward part here is that folks deploying Backstage would need to configure an IAM role out-of-band -- but they were probably doing this already anyway 😁
The cluster config could have an assumeRole field whose value is the ARN for a role that is capable of calling GetCallerIdentity. If I'm not mistaken, this config parameter already exists, but isn't documented. Then instead of calling assumeRole with raw security creds like this, the kubernetes-backend could call assumeRoleWithWebIdentity with the OIDC ID token passed from the frontend following the authorization flow.
Context
I didn't realize this section was down here and kinda threaded the context throughout the sections above; if it's better to keep the above sections more focused and tactical and leave the "narrative" part down here, I can revise!

@mclarke47 for visibility.

Was this completed?

I think this one and https://github.com/backstage/backstage/issues/10035 are related


TextField Acessibility ID not persist after build

Steps to reproduce

create a sample app
add a Button with Key property
add a TextField with Key property
build app
inspect built app using some tool like appium-inspector

Expected results
Both Button and TextField expose accessibility-id.
Actual results
Only Button shows accessility-id.
Code sample
Code sample
TextField(
  decoration: InputDecoration(
    border: OutlineInputBorder(),
    hintText: 'Enter a search term',
  ),
),

TextButton(
  style: ButtonStyle(
    foregroundColor: MaterialStateProperty.all<Color>(Colors.blue),
  ),
  onPressed: () { },
  child: Text('TextButton'),
)

Screenshots or Video

Screenshots / Video demonstration

Logs
Logs
[Paste your logs here]

Flutter Doctor output
Doctor output
Flutter 3.19 may have identifier for SemanticsProperties (introduced by flutter/flutter#138331). It sets resource-id and accessibilityIdentifier for Android and iOS, then UiAutomator2/XCUITest drivers also can handle Key without this driver
"appium:disableIdLocatorAutocompletion": true would be necessary to make resource-id idea work without any package name prefix like Android compose.
e.g. flutter/flutter#17988 (comment)
[✓] Flutter (Channel stable, 3.19.0, on Ubuntu 23.10 6.5.0-21-generic, locale en_US.UTF-8)
    • Flutter version 3.19.0 on channel stable at /home/pedro/Development/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision bae5e49bc2 (2 weeks ago), 2024-02-13 17:46:18 -0800
    • Engine revision 04817c99c9
    • Dart version 3.3.0
    • DevTools version 2.31.1
[✓] Android toolchain - develop for Android devices (Android SDK version 34.0.0)
    • Android SDK at /home/pedro/Development/Android/Sdk
    • Platform android-34, build-tools 34.0.0
    • ANDROID_HOME = /home/pedro/Development/Android/Sdk
    • Java binary at: /snap/android-studio/148/jbr/bin/java
    • Java version OpenJDK Runtime Environment (build 17.0.7+0-17.0.7b1000.6-10550314)
    • All Android licenses accepted.
[✓] Chrome - develop for the web
    • Chrome at google-chrome
[✓] Linux toolchain - develop for Linux desktop
    • Ubuntu clang version 16.0.6 (15)
    • cmake version 3.27.4
    • ninja version 1.11.1
    • pkg-config version 1.8.1
[✓] Android Studio (version 2023.1)
    • Android Studio at /snap/android-studio/148
    • Flutter plugin can be installed from:
      :hammer: https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      :hammer: https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 17.0.7+0-17.0.7b1000.6-10550314)
[✓] VS Code (version 1.86.2)
    • VS Code at /snap/code/current/usr/share/code
    • Flutter extension version 3.83.20240201
[✓] Connected device (3 available)
    • SM G770F (mobile) • RQ8NB02AVTF • android-arm64  • Android 13 (API 33)
    • Linux (desktop)   • linux       • linux-x64      • Ubuntu 23.10 6.5.0-21-generic
    • Chrome (web)      • chrome      • web-javascript • Google Chrome 122.0.6261.69
[✓] Network resources
    • All expected network resources are available.
• No issues found!

Thanks for the report. I also see the same on the latest master channel. This also happens on the previous release 3.16.9.

Complete sample code
import 'package:flutter/material.dart';

void main() async {
  runApp(
    const MaterialApp(
      title: 'Flutter Example',
      home: MyApp(),
    ),
  );
}

class MyApp extends StatelessWidget {
  const MyApp({super.key});

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      body: Column(
				mainAxisAlignment: MainAxisAlignment.center,
        children: [
          const TextField(
            key: Key('search_field'),
            decoration: InputDecoration(
              border: OutlineInputBorder(),
              hintText: 'Enter a search term',
            ),
          ),
          TextButton(
            key: const Key('text_button'),
            style: ButtonStyle(
              foregroundColor: MaterialStateProperty.all<Color>(Colors.blue),
            ),
            onPressed: () {},
            child: const Text('TextButton'),
          ),
        ],
      ),
    );
  }
}

flutter doctor -v (stable and master)
[✓] Flutter (Channel stable, 3.19.2, on macOS 14.1 23B74 darwin-x64, locale en-VN)
    • Flutter version 3.19.2 on channel stable at /Users/huynq/Documents/GitHub/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision<PHONE_NUMBER> (31 hours ago), 2024-02-27 16:51:22 -0500
    • Engine revision 04817c99c9
    • Dart version 3.3.0
    • DevTools version 2.31.1

[✓] Android toolchain - develop for Android devices (Android SDK version 34.0.0)
    • Android SDK at /Users/huynq/Library/Android/sdk
    • Platform android-34, build-tools 34.0.0
    • ANDROID_HOME = /Users/huynq/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jbr/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 17.0.7+0-17.0.7b1000.6-10550314)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 15.0.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 15A507
    • CocoaPods version 1.15.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2023.1)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • android-studio-dir = /Applications/Android Studio.app/
    • Java version OpenJDK Runtime Environment (build 17.0.7+0-17.0.7b1000.6-10550314)

[✓] VS Code (version 1.86.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.82.0

[✓] Connected device (3 available)
    • RMX2001 (mobile) • EUYTFEUSQSRGDA6D • android-arm64  • Android 11 (API 30)
    • macOS (desktop)  • macos            • darwin-x64     • macOS 14.1 23B74 darwin-x64
    • Chrome (web)     • chrome           • web-javascript • Google Chrome 122.0.6261.94

[✓] Network resources
    • All expected network resources are available.

• No issues found!

[!] Flutter (Channel master, 3.20.0-15.0.pre.45, on macOS 14.1 23B74 darwin-x64, locale en-VN)
    • Flutter version 3.20.0-15.0.pre.45 on channel master at /Users/huynq/Documents/GitHub/flutter_master
    ! Warning: `flutter` on your path resolves to /Users/huynq/Documents/GitHub/flutter/bin/flutter, which is not inside your current Flutter SDK checkout at /Users/huynq/Documents/GitHub/flutter_master. Consider adding /Users/huynq/Documents/GitHub/flutter_master/bin to the front of your path.
    ! Warning: `dart` on your path resolves to /Users/huynq/Documents/GitHub/flutter/bin/dart, which is not inside your current Flutter SDK checkout at /Users/huynq/Documents/GitHub/flutter_master. Consider adding /Users/huynq/Documents/GitHub/flutter_master/bin to the front of your path.
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 2ccf375cb1 (40 minutes ago), 2024-02-28 23:17:36 -0500
    • Engine revision 232217f39c
    • Dart version 3.4.0 (build 3.4.0-187.0.dev)
    • DevTools version 2.33.0-dev.11
    • If those were intentional, you can disregard the above warnings; however it is recommended to use "git" directly to perform update checks and upgrades.

[✓] Android toolchain - develop for Android devices (Android SDK version 34.0.0)
    • Android SDK at /Users/huynq/Library/Android/sdk
    • Platform android-34, build-tools 34.0.0
    • ANDROID_HOME = /Users/huynq/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jbr/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 17.0.7+0-17.0.7b1000.6-10550314)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 15.0.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 15A507
    • CocoaPods version 1.15.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2023.1)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • android-studio-dir = /Applications/Android Studio.app/
    • Java version OpenJDK Runtime Environment (build 17.0.7+0-17.0.7b1000.6-10550314)

[✓] VS Code (version 1.86.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.82.0

[✓] Connected device (3 available)
    • RMX2001 (mobile) • EUYTFEUSQSRGDA6D • android-arm64  • Android 11 (API 30)
    • macOS (desktop)  • macos            • darwin-x64     • macOS 14.1 23B74 darwin-x64
    • Chrome (web)     • chrome           • web-javascript • Google Chrome 122.0.6261.94

[✓] Network resources
    • All expected network resources are available.

! Doctor found issues in 1 category.

@hangyujin Are you the right person to confirm what the intended behavior is here for accessibility ids on Android?

I am not familiar with this, the feature was added at https://github.com/flutter/engine/pull/47961.
bartekpacia Do you know what the intended behavior is here?

Thanks for the ping @hangyujin. I believe author of this issue misunderstands the new "accessibility identifier" feature we added in Flutter 3.19. key on the widget doesn't have any effect, no changes were made to its behavior.
To add accessibility identifier to a widget, it has to be wrapped with Semantics and Semantics.identifier must be specified:
class MyApp extends StatelessWidget {
  const MyApp({super.key});

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      body: Column(
        mainAxisAlignment: MainAxisAlignment.center,
        children: [
          Semantics(
            identifier: 'search_field',
            child: TextField(
              decoration: InputDecoration(
                border: OutlineInputBorder(),
                hintText: 'Enter a search term',
              ),
            ),
          ),
          Semantics(
            identifier: Key('text_button')
            child: TextButton(
              style: ButtonStyle(
                foregroundColor: MaterialStateProperty.all<Color>(Colors.blue),
              ),
              onPressed: () {},
              child: const Text('TextButton'),
            ),
          ),
        ],
      ),
    );
  }
}

Thanks @hangyujin @bartekpacia.
Does that fix your problem @paulowsky?


Implement metacall_box for passing function arguments with different types

…types
Description
Implement metacall_box for passing function arguments with different types
Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[x] This change requires a documentation update
[ ] Documentation update

Checklist:

[x] I have performed a self-review of my own code.
[x- I have commented my code, particularly in hard-to-understand areas.
[ ] I have made corresponding changes to the documentation.
[x] My changes generate no new warnings.
[ ] I have added tests/screenshots (if any) that prove my fix is effective or that my feature works.
[ ] I have tested the tests implicated (if any) by my own code and they pass (make test or ctest -VV -R <test-name>).
[ ] If my change is significant or breaking, I have passed all tests with ./docker-compose.sh test &> output and attached the output.
[ ] I have tested my code with OPTION_BUILD_ADDRESS_SANITIZER or ./docker-compose.sh test-address-sanitizer &> output and OPTION_TEST_MEMORYCHECK.
[ ] I have tested my code with OPTION_BUILD_THREAD_SANITIZER or ./docker-compose.sh test-thread-sanitizer &> output.
[ ] I have tested with Helgrind in case my code works with threading.
[ ] I have run make clang-format in order to format my code and my code follows the style guidelines.

If you are unclear about any of the above checks, have a look at our documentation here.

@devraymondsh what's left for merging this?