Ripple order entry, order cancel, account orders, trades and balance queries added

Ripple order entry, order cancel, own order query and balance query added. Also added an additional data map to the core Order class, for passing counterparty information on order entry, own order query and order book query - hope this is OK.
Main missing feature (for me) is a lack of trade history. There does not currently appear to be a way of obtaining this using their REST API.
Related to #181

I'm hesitant on adding that Map to Order. I'd either want to go "all in" and add that to all the DTOs or stick to the current philosophy of "down casting" to the exchange-specific service and pulling out the info needed.

For standard stuff such as order entry, polling for own orders, I think it would be good to be able to use the generic interfaces and objects as much as possible. The other way I thought it could be done was on order entry go down a route similar to TradeHistoryParams, with a 2nd argument for placeLimitOrder (and placeMarketOrder) that extends OrderEntryParams. On the way back from the exchange for queries, the returned objects could be a RippleLimitOrder that extends LimitOrder.
What is your concern about adding the additional data map to Order? There is already a similar map on Trade.

I've now added trade history support. Assume merge decision is pending outcome of discussion #990 about the additional data maps.
The CI build failed due to SocketTimeoutExceptions in the Coinmate project, perhaps these should be integration tests rather than standard unit tests.

Yes, any test that operates over the network should be an integration test. See step #9 here: https://github.com/timmolter/XChange/wiki/New-Implementation-Best-Practices

@ww3456 Can you look at the travis build and see why it's failing?

The build failed due to Coinmate integration tests failing on the network, I've renamed them as part of #1008. This Ripple PR isn't ready for merge yet, I still need to get rid of the additional data maps in Order and Trade. Will try and do that this week.

Removed additional data map from core Order and Trade classes (#990).
Order.Builder classes have been reworked to add inheritance.
On the Ripple side everything is now working for me.

Please let me know if there are any issues. Thanks.


http01 challenge succeeds, but authorization fails

/kind bug
What happened:
Disclaimer: I'm a relative newbie at k8s, so I'm very likely doing something wrong and just didn't RTFM correctly.
Super close to getting http01 ACME challenges working with letsencrypt-staging, but running into a strange authorization failure I can't seem to pin down. First, I installed cert-manager v0.2.3 via helm install --name cert-manager --namespace kube-system contrib/charts/cert-manager. My Issuer and Certificate config looks like this:
apiVersion: certmanager.k8s.io/v1alpha1
kind: ClusterIssuer
metadata:
  name: letsencrypt-staging
spec:
  acme:
    # The ACME server URL
    server: https://acme-staging.api.letsencrypt.org/directory
    # Email address used for ACME registration
    email<EMAIL_ADDRESS>    # Name of a secret used to store the ACME account private key
    privateKeySecretRef:
      name: letsencrypt-staging
    # Enable the HTTP-01 challenge provider
    http01: {}
---
apiVersion: certmanager.k8s.io/v1alpha1
kind: Certificate
metadata:
  name: domain-com-staging
  namespace: default
spec:
  secretName: domain-com-tls-staging
  issuerRef:
    name: letsencrypt-staging
    kind: ClusterIssuer
  commonName: domain.com
  acme:
    config:
    - http01:
        ingressClass: nginx
      domains:
      - domain.com

After applying it, according to the logs cert-manager picks it up and begins the process:
I0227 06:23:20.413039       1 sync.go:107] Error checking existing TLS certificate: secret "domain-com-tls-staging" not found
I0227 06:23:20.413065       1 sync.go:238] Preparing certificate with issuer
I0227 06:23:20.413506       1 prepare.go:239] Compare "" with "https://acme-staging.api.letsencrypt.org/acme/reg/<redacted>"

I see a mini challenge-response pod pop up called cm-domain-com-staging-*. Looks like the logs show the ACME server actually does perform the challenge correctly:
2018/02/27 06:22:15 [domain.com] Validating request. basePath=/.well-known/acme-challenge, token=HOlOtteBrz8A_<redacted>
2018/02/27 06:22:15 [domain.com] Comparing actual host 'domain.com' against expected 'domain.com'
2018/02/27 06:22:15 [domain.com] Got successful challenge request, writing key...

Unfortunately something between then and cert-manager retrieving the certificate fails:
I0227 06:23:35.254098       1 sync.go:242] Error preparing issuer for certificate: error waiting for authorization for domain "domain.com": acme: authorization error for :

Anything else we need to know?:
The first thing that jumps out at me is the blank entry in prepare.go which appears to come from auth.Account. I'm assuming that comes from the letsencrypt-staging secret (???), but all I see there is tls.key:
$ k -n kube-system describe secret letsencrypt-staging
Name:         letsencrypt-staging
Namespace:    kube-system
Labels:       <none>
Annotations:  <none>

Type:  Opaque

Data
====
tls.key:  1675 bytes

The resulting blank error is probably related is related to #12, but unfortunately I can't figure out how to dump the wireAuthz structure (my go-fu is ... bad).
One last thing that might be related is that I've used LetsEncrypt to generate certificates for this domain before. Sadly I don't have the private key for the staging environment, but I do have the private_key.json that certbot spits out. I've looked high and low, but I can't seem to find out exactly what the structure of privateKeySecretRef is, so I don't know how to stuff the private_key.json from the prod instance into a secret. I'd try to generate a new cert de-novo on the prod instance to see if it's something related to staging, but I've been burned by the rate limit before and would like to avoid that week-long penalty box if I can.
Let me know if there's anything else I can provide.
Environment:

Kubernetes version (use kubectl version):
Client Version: version.Info{Major:"1", Minor:"9", GitVersion:"v1.9.2", GitCommit:"5fa2db2bd46ac79e5e00a4e6ed24191080aa463b", GitTreeState:"clean", BuildDate:"2018-01-18T10:09:24Z", GoVersion:"go1.9.2", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"9", GitVersion:"v1.9.3", GitCommit:"d2835416544f298c919e2ead3be3d0864b52323b", GitTreeState:"clean", BuildDate:"2018-02-07T11:55:20Z", GoVersion:"go1.9.2", Compiler:"gc", Platform:"linux/amd64"}
Cloud provider or hardware configuration: bare-metal
Install tools: kubeadm

Hm. Well, tried again today and it appeared to succeed...? Seems like it might have been an intermittent issue with the letsencrypt staging server. I'll dig around a bit more and see if I find anything, but I'll close this in the meantime.

Seems like it might have been an intermittent issue with the letsencrypt staging server.

@timblakely I was able to use that snippet of the challenge token you put in the issue body (token=HOlOtteBrz8A_<redacted>) to work backwards through the server-side validation authority logs (I work for Let's Encrypt/ISRG :wave:) to find the HTTP-01 validation request result.
I don't believe this was a staging server issue, it looks like the HTTP-01 challenge request was refused. The API response given to cert-manager said as much too:

"Error":"connection :: Fetching http:///.well-known/acme-challenge/HOlOtteBrz8A_: Connection refused"

Hope that helps!

OH! You know, I think I was messing with my iptables forwarding and dnsmasq rules around that time. tl;dr: cluster's network switch didn't support hairpin routing, so I had dnsmasq point to the internal IP address. That made the domain accessible from intra-cluster (hence the successful test challenges), but it didn't occur to me that the FORWARDING rules might be borked.
@cpu Thanks a bunch! :+1:

These exact errors also happened to me. It was also caused by a refused connection. The firewall was blocking the connection.
If you have set up a website with a whitelist that only accepts connections from a select list of IPs, then you might be able to access the challenge URLs, but Let's Encrypt will not. Adding the following Let's Encrypt IPs to my firewall fixed the problem:
<IP_ADDRESS>
<IP_ADDRESS>
<IP_ADDRESS>
<IP_ADDRESS>


Publishing a library

First pass, authors will be able to pass the target triplet and the corresponding download URL (maybe using a JSON file). The CLI will generate code to download and cache the library.
After that is implemented, authors should also be able to provide a git repository URL or source (zip/tar/...) or crates.io publish and deno_bindgen will generate relevant glue code to build the crate from source using the available Rust toolchain on the user's machine.

Now has an --release=URL_PREFIX option to support loading remote libraries (gh releases, etc)


Meetings page updates

move date/time/location to top of page
include link to civic-meetings repo

Can we also add the following content to meetings page somewhere? At bottom?
"This year the Semantic Web Applications and Tools for Life Sciences (SWAT4LS) Conference (http://www.swat4ls.org) and Clinical Interpretation of Variants in Cancer (CIViC) Curation Jamboree and Hackathon (https://civic.genome.wustl.edu/#/meetings) are both at the NKI in Amsterdam, only separated by the weekend.  This brings the opportunity for potential synergy, where content from CIViC is curated and presented in a Semantic Web-ready format, which is then integrated with other resources on the Semantic Web at SWAT4LS.
Attendance at both events would certainly benefit from such a cross-pollination. To enable this, we cordially invite attendees of SWAT4LS to join the CIViC Jamboree and Hackaton and vice versa. Joining the CIViC Jamboree/Hackaton is free of charge (please register at http://ngs2016.org). Attendees for the CIViC Jamboree get a 20% discount when registering for SWAT4LS events (discount codes will be distributed at the CIViC Jamboree and Hackathon).
"


MyFirstContribution

I Created my file

I Created my f

I Created my file

atta raedme file edit kar ani punha request tak


Getting snap image/video doesn't work!

(rdb:1) media_response = snapcat.media_for(snap.id)
*** OpenSSL::Cipher::CipherError Exception: wrong final block length

Let me know if you need more data!

I was only getting that if it was a snapchat from 'teamsnapchat'. Worked when I send one from another account :)


GitlabReporter - fix report output

According to the documentation the location in the report should be a nested object.

Hi and thanks for the PR!
Could you add @see https://github.com/codeclimate/spec/blob/master/SPEC.md#data-types to the header so it becomes:
/**
 * Generates a report according to gitlabs subset of codeclimate json files.
 *
 * @see https://github.com/codeclimate/spec/blob/master/SPEC.md#data-types
 *
 * @author Hans-Christian Otto<EMAIL_ADDRESS> *
 * @internal
 */

after that I'm :+1:  for merging in this

Sure, I added the reference to the documentation.

please, can you solve https://github.com/FriendsOfPHP/PHP-CS-Fixer/issues/4430 inside this PR?

What should I do to solve #4430 inside this PR?

Thank you @mjanser.

I really don't like that we are doing some unspecified changes to reporter, that is supposed to be under BC promise, but we don't specify what the promise is - we have reporter without spec :/
cc @SpacePossum @mjanser

We've added a link to the spec:
https://github.com/FriendsOfPHP/PHP-CS-Fixer/pull/4563#issuecomment-539068372
This PR fixes a bug so the tool generates the report following that spec, I think that is inline with BC?

Link to a spec does not ensure that our implementation is following this spec.
validating outcome of our implementation with spec file (eg xsd) would.

Good idea, let me know when you've time to help out with that :)
Till than I will merge bug fixes because I think these are more important than test case completeness.


[feat] add ledger compiler support

Description
目前 double-entry-generator 只支持 beancount 后端，增加对 ledger 后端的支持.  针对不同的 provider, 后端需要有对应的输出模板，已有的输出模板包括:

[x] 普通消费账单的模板
[ ] 火币模板1
[ ] 火币模板2
[ ] 火币卖出模板
[ ] 海通买入模板

本次PR 先增加 普通消费账单的模板 的支持
Motivation and Context
#92
Dependencies
None
Type of change
Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[x] This change requires a documentation update

How has this been tested?
新增三个 end-to-end 测试脚本, 测试 ledger 后端生成功能:

[x] alipay-test-ledger.sh: pass
[x] wechat-test-ledger.sh: pass
[x] icbc-test-ledger.sh: pass

对生成的 ledger 文件进行语法与格式校验:

[x] ledger -f test/output/test-icbc-credit-output.ledger bal: pass
[x] ledger -f test/output/test-icbc-debit-output.ledger bal: pass
[x] ledger -f test/output/test-alipay-output.ledger bal: pass
[x] ledger -f test/output/test-wechat-output.ledger bal: pass

PTAL @gaocegege

Thanks for your contribution 🎉


T265 does not work [URGENT PLEASE HELP]

librealsense
2.48.0 RELEASE

OS
Windows

Name
Intel RealSense T265

Serial Number
119622110175

Firmware Version
<IP_ADDRESS>1

Usb Type Descriptor
3.1

Product Line
T200

The product does not work, it disconnects always with the following errors:
11/08 15:38:52,323 ERROR [12944] (tm-device.cpp:2038) Bulk request error RS2_USB_STATUS_OTHER
11/08 15:38:52,323 ERROR [9960] (messenger-winusb.cpp:102) bulk_transfer failed, error: 433
11/08 15:38:52,323 ERROR [9960] (tm-device.cpp:2038) Bulk request error RS2_USB_STATUS_OTHER
11/08 15:39:13,694 ERROR [14292] (messenger-winusb.cpp:102) bulk_transfer failed, error: 31
11/08 15:39:13,694 ERROR [14292] (tm-device.cpp:2038) Bulk request error RS2_USB_STATUS_OTHER
11/08 15:39:13,703 ERROR [10708] (messenger-winusb.cpp:102) bulk_transfer failed, error: 433
11/08 15:39:13,703 ERROR [10708] (tm-device.cpp:2038) Bulk request error RS2_USB_STATUS_OTHER
11/08 15:39:14,033 ERROR [12684] (messenger-winusb.cpp:117) failed to set timeout policy, error: 22
11/08 15:39:14,033 ERROR [12684] (tm-device.cpp:2038) Bulk request error RS2_USB_STATUS_OTHER
11/08 15:39:26,523 ERROR [5620] (messenger-winusb.cpp:117) failed to set timeout policy, error: 22
Please help I am desperate. :'(

I purchases a new powered USB External 3.1 hub - and still it doesn't want to work. I have 32GB of ram - should I at this point assume that it is broken and I should get a replacement?


Initial test and fixes for GdipMeasureCharacterRanges

Tests and fixes part of behaviour changed by PR #137.

Rebased on top of master.


Use $translate with LxNotificationService.confirm

How to properly use $translate with LxNotificationService.confirm. I tried this way, but its not working
$scope.removeFile = function removeFile(row) {

            $translate('TEXT.SURE_DELETE_FILE')
                .then(function (translatedValue) {
                    $scope._text = translatedValue;
                });

            LxNotificationService.confirm('Lorem Ipsum', $scope._text, { cancel:"cancel", ok:"ok" }, function(answer)
            {
                console.log(answer);
            });

        };

Hi!
You have to use instant: https://angular-translate.github.io/docs/#/api/pascalprecht.translate.$translate
We use it in all of our projects, no problem at all!


Pip: Do not raise PathDependenciesNotReachable for missing setup.py

Previously, Dependabot would assume that for every requirements.txt with
a self-reference (-e .), we should expect a setup.py to be present. The
self-reference is considered a path dependency that needs a setup.py.
However, nowadays it's valid to have a requirements.txt without a
setup.py. This change accounts for that by still attempting to pull in a
setup.py if it exists, but to not raise and error when it doesn't.
Closes https://github.com/dependabot/dependabot-core/pull/5324
Resolves https://github.com/dependabot/dependabot-core/issues/4483

Thanks @jurre this is now working as expected 😄


The message handler must return the Task instead of the void

Need native support for asynchronous message handlers.

We need to upgrade rabbitmq.client up to 5.0.1 to support async.


Research how to integrate Apika with EMQ

Clarify how an MQTT API can be connected to eMQ broker / proxy via APIKA. REST APIs are connected to proxy (e.g. API Umbrella) through an internal Admin API. Determine the options for connecting the MQTT API.
Definition of done

[ ] Look into options for connecting the API
[ ] Select the most reasonable option
[ ] Document the options and the recommendation

At first glance, there seem to be several related EMQ components here:

HTTP Publish API - HTTP API for publishing messages to MQTT channels
username/password auth - required by HTTP Publish API and ACL
ACL - rules to allow MQTT clients to publish/subscribe topics

ACL HTTP API - allows us to configure ACL rules via HTTP

A high-level goal might be described as "create a REST API for emqttd_ctl".

emqttd_ctl commands

I opened an upstream issue to get support and/or feedback for this idea.

Let's create an issue to test adding a user and access control rule a particular topic


sync_down_on_open not working for me as expected.

"type": "sftp",
"save_before_upload": true,
"upload_on_save": true,
"sync_down_on_open": true,
"sync_skip_deletes": false,
"sync_same_age": true,
"confirm_downloads": false,
"confirm_sync": true,
"confirm_overwrite_newer": false,

Above are my sftp-config.json settings.
sync_down_on_open is true but it is not working for me.
I changed the remote file and then opened the previously synced local file. I expected local file to get updated but i received "No Operations to perform" and the file is not downloaded and synced. Please let me know if this is really an issue.
PS: I am using sftp_flags with proxy command. I am accessing actual server via an intermediate server (jump host). Other features are working fine...

Hi,
I'm afraid this repository is for a different plugin (FTPSync) than you are using (probably SFTP)?
FTPSync does not even support "sftp" as stated in the readme https://github.com/NoxArt/SublimeText2-FTPSync
It uses ftpsync.settings config file instead of sftp-config.json etc. and none of these options...


Cannot Differentiate between Tweet and Retweet

Hi @linvi How are you?
I am getting tweet against specific keyword and save into database. but my issue is
var SearchResults = Search.SearchTweets("#Trump");
foreach(var tweet in SearchResults )
{
	if (Tweet.IsRetweet)
	{
		//retweet goes here
		// i am getting retweet like this
		var tweetText=Tweet.retweetedTweet.text;
	}
	else
	{
		//Tweet goes here
		var tweetText=Tweet.text;
	}
}

Both gives me original tweet data how can i consider Original Tweet as Tweet and Retweet as retweet

Sorry, I do not understand your question. Could you please provide more information as to what is causing your problems?
Please not that the code you provided does not work because of capitalization.

I set TweetId as primary key in my tweet table. when someone tweet on my streaming keyword it comes into my database but when someone retweet (of this previous tweet which are in database) error comes out as primary key violation because tweet and retweet id are same.
so how can i save tweet and retweet in db.
i am getting reTweet Id Like This
var Id= Tweet.RetweetedTweet.Id;
and Tweet Id Like this
var Id=Tweet.Id;

Well your code is just wrong and the error seems legitimate as you are intentionally using the id of the retweeted tweet (var Id= Tweet.RetweetedTweet.Id;) which mean that if you already inserted the id of the original tweet there will be an error.
This problem has nothing to do with Tweetinvi but is purely a problem in your code logic I would say.

Well thank you for response i sort it out.
but one thing i want to ask that i have more keyword i want to track. by using one AddTrack method i can track only one keywords track. is it possible that when i start my program i count my keywords and make AddTrack dynamically equal to keywords count like this
int count=6;
create dynamically add Track for every keyword. if it is possible then how?

Yes you can add up to 400 keywords to track. Keywords can only be added when the stream is not running.
var fs = Stream.CreateFilteredStream();

fs.AddTrack("hello");
fs.AddTrack("hello2");

fs.StartStreamMatchingAllConditionsAsync();

// Later on you want to add a new track

fs.StopStream();
fs.AddTrack("hello3");

fs.StartStreamMatchingAllConditionsAsync();
// ...


Where should SourceDescriptions be attached?

In working on #33 I see that we need to be more deliberate about where we attach SourceDescriptions. FamilySearch generates SourceDescriptions on their own and have them attached to the root GEDCOM X element. For all other sites we have been generating one SourceDescription and attaching it to all persons and relationships in the document. We did that before realizing that the root element had a description property.
I believe we should use the root level description property. But should we continue attaching that same SourceDescription to all persons and relationships?

Lets first consider the case of your typical census record. Say you have a couple and three children. genscrape is used to extract the data when viewing the mother's record which includes a household table that points to all other members of the household but only include their name and age. Should all other household members be linked to that same source? That's not likely what you want because they have their own records.
But in the case of a marriage record, depending on how the record repository displays the data, the parents of the couple might not have their own records in which case you would want all persons and relationships to have the root SourceDescription attached to them.
Online trees are similar to the first case of a typical census record.  That's not what we want.
We have a few choices:

Never attach the root SourceDescription to any other entities in the document. Consider it implicit that it also applies to everything in the document in varying degrees and expect apps to interpret as they please.
Always attach the root SourceDescription to all entities in the document which support sources.
Have genscrape site processors attach the root SourceDescription to none, some, or all entities based what is deemed most appropriate for the record type.

I'm leaning towards option 1.

I still believe that option 1 from above is ideal but it's a breaking change. Currently we are generating a root SourceDescription but we're not attaching it to the root document while we are attaching it to all nested entities (persons, relationships, etc). So we can fix this, for now, by attaching that SourceDescription to the root too.


multi downloading video info_dict

DO NOT REMOVE OR SKIP THE ISSUE TEMPLATE

[X] I understand that I will be blocked if I intentionally remove or skip any mandatory* field

Checklist

[X] I'm asking a question and not reporting a bug or requesting a feature
[X] I've looked through the README
[X] I've verified that I'm running yt-dlp version 2023.03.04 (update instructions) or later (specify commit)
[X] I've searched known issues and the bugtracker for similar questions including closed ones. DO NOT post duplicates
[X] I've read the guidelines for opening an issue

Please make sure the question is worded well enough to be understood
is there any way to download multi json of a playlist?
for example i've 200 videos in a playlist
and i want to download only the info.json of all videos with n threads
it's posible it?
ps: how many requests can i do in youtube before my ip is blocked?
sorry my english no is good
Provide verbose output that clearly demonstrates the problem

[ ] Run your yt-dlp command with -vU flag added (yt-dlp -vU <your command line>)
[ ] If using API, add 'verbose': True to YoutubeDL params instead
[ ] Copy the WHOLE output (starting with [debug] Command-line config) and insert it below

Complete Verbose Output
No response

Use -J to get full json, but it will not be multithreaded.

ps: how many requests can i do in youtube before my ip is blocked?

You'd have to ask google to get an actual answer. I have personally never gotten 429'd with --sleep-requests 0.3.

why dont add multiprosesing download?
i think that add with an argument and then you can check if a thread finished the work
with concurrent.futures


Autocomplete of usernames using jquery-ui

Completed issue #7 using jquery-ui built in auto-complete functionality.

That's really awesome, thank you!


The UI response is very slow

The response of the UI is really really slow when I no matter click on dropdown list or button. It seems no response for very long time in my Mac mini m2 16G SSD 512. But the processing time is pretty fast.
I used it in my another iMac, it looks pretty fast. The CPU , memory and SSD is not as good as my Mac mini.

could be a painting issue, i dont know i havent reviewed the code. i saw another program that was pulling its display from memory rather than storing it which caused an insane bottleneck visually and this sounds similar enough.

The response of the UI is really really slow when I no matter click on dropdown list or button. It seems no response for very long time in my Mac mini m2 16G SSD 512. But the processing time is pretty fast.
I used it in my another iMac, it looks pretty fast. The CPU , memory and SSD is not as good as my Mac mini.

try moving the program around and seeing if it updates immediately after or closing and opening the display

The response of the UI is really really slow when I no matter click on dropdown list or button. It seems no response for very long time in my Mac mini m2 16G SSD 512. But the processing time is pretty fast.
I used it in my another iMac, it looks pretty fast. The CPU , memory and SSD is not as good as my Mac mini.

try moving the program around and seeing if it updates immediately after or closing and opening the display

It's refreshed if I move the app around. Is this a known issue? Are they going to fix it?

Are you running Mac Sonoma? There's a know issue related to mouse clicks - https://github.com/Anjok07/ultimatevocalremovergui/issues/840

Are you running Mac Sonoma? There's a know issue related to mouse clicks - #840

Yes. I'm running Sonoma. THe same mouse click issue.

Are you running Mac Sonoma? There's a know issue related to mouse clicks - #840

Yes. I'm running Sonoma. THe same mouse click issue.

This issue has been resolved. Please update to UVR_Patch_10_6_23_4_27.


Add Allsorts as a font-kit loader

impl Loader for Allsorts. Not sure how to handle rasterize_glyph though.

I think there are a couple of options:

have the allsorts rasterize_glyph always return PlatformError
Have the Loader impl delegate to a Loader that is passed into the constructor of the the allsorts impl.  I'm not super sure this is a great idea, especially if the metrics don't match up between the two impls.

That said, based on my (probably lesser than yours!) understanding, I'm not super sure that it makes sense for allsorts to be a font-kit Loader.  I think that there are two main places where allsorts can plug in to the mainstream use cases:

Work with the font-kit folks to define a Shaper trait and have allsorts impl that.  The Shaper trait would provide the main API that can shape a string, and a variant on that to shape and rasterize using the font-kit loaders.
Work with the rusttype folks to use allsorts as the parser/loader for their rasterizer and add shaping support


portainer and traefik problems after update of Docker for Windows

Since the new Docker for Windows update (Version 18.03.0-ce-win59 (16762), on Win10) none of my projects start up, with mount-related errors about portainer and traefik like these:

ERROR: for eorgdockerlocalhost_portainer_1 Cannot create container for service portainer: b'Mount denied:\nThe source path "\var\run\docker.sock:/var/run/docker.sock"\nis not a valid Windows path'
ERROR: for traefik Cannot create container for service traefik: b'Mount denied:\nThe source path "\var\run\docker.sock:/var/run/docker.sock"\nis not a valid Windows path'
ERROR: for portainer Cannot create container for service portainer: b'Mount denied:\nThe source path "\var\run\docker.sock:/var/run/docker.sock"\nis not a valid Windows path'
ERROR: Encountered errors while bringing up the project.

Same problem after Docker for windows update to 16762.

Downgraded to Docker for Windows Version 17.06.1-ce-win24 (13025) - all works perfectly.
@csandanov please let us know here once it is safe again for users to upgrade; thanks.

TBH I couldn't even launch docker for windows :) I try to launch it via parallels on mac and even purchased a newer Parallels version + Pro license but no luck https://github.com/docker/for-win/issues/904#issuecomment-351642219. Although somethings could've changed in the last 3 months

Perhaps an investment in a simple Windows laptop is an option. There are lots of Windows users relying on D4D for local development.

Finally, i swhitched on Arch linux with i3wm... My old setup, for local development and keep windows on dual booting for other business devs... All work fine on Linux hosted D4D

https://github.com/docker/for-win/issues/1889#issuecomment-376874047 fixed it for me.

I downgraded.

@mfrieling linked a solution that worked for me
Restated here:
Just add environment variable COMPOSE_CONVERT_WINDOWS_PATHS=1
git-bash: export COMPOSE_CONVERT_WINDOWS_PATHS=1
powershell: $Env:COMPOSE_CONVERT_WINDOWS_PATHS=1

Anyone played with WSL2 and wodby4drupal ?
I'm stucked, my websites or even portainer or pma are not accessible from my host.
The only thing I can see from my linux, is the admin page of traefik 2 on port 8080.


Vulkan: Error spam when SSIL is enabled in a specific scene

Godot version
4.0.alpha (44516d1a5)
System information
Fedora 36, GeForce GTX 1080 (NVIDIA 510.68.02)
Issue description
While testing https://github.com/godotengine/godot/pull/62478, I went for the MRP of https://github.com/godotengine/godot/issues/56723 and noticed it spams error messages whenever SSIL is enabled in the Environment resource:
ERROR: Uniforms supplied for set (2):
Set: 1 Binding: 0 Type: Image Writable: Y Length: 1
are not the same format as required by the pipeline shader. Pipeline shader requires the following bindings:
Set: 0 Binding: 0 Type: CombinedSampler Writable: Y Length: 1
Set: 1 Binding: 0 Type: Image Writable: Y Length: 1
Set: 2 Binding: 0 Type: Image Writable: N Length: 1
   at: compute_list_dispatch (drivers/vulkan/rendering_device_vulkan.cpp:8250)

No screen-space indirect lighting is visible in the 3D editor viewport. No other features are enabled in Environment.
This doesn't occur in a brand new project with SSIL enabled, only with the MRP linked below.
Steps to reproduce

Download the minimal reproduction project below and import it.

Minimal reproduction project
https://github.com/godotengine/godot/files/7854794/test_ssil_3.zip

I'm seeing this error spam in an upgraded project and can't find a root cause. Just a new scene in an old project, no WorldEnvironment or default environment, with a camera, light and gltf mesh (CSG has no issues) will spam these errors. But with the same asset on a new project, no errors.

Same problem here. Older project spamming those errors, but when I rebuild it in a new project with the same settings and environment, the errors are gone. In my project the gpu particles triggers those errors (as soon as it emmits, even without particle material).

Same problem here. Older project spamming those errors, but when I rebuild it in a new project with the same settings and environment, the errors are gone. In my project the gpu particle triggers those errors (as soon as it emits, even without particle material). SSIL is not active in my project.

This is an unrelated issue, likely related to https://github.com/godotengine/godot/issues/57471.

Same problem here. Older project spamming those errors, but when I rebuild it in a new project with the same settings and environment, the errors are gone. In my project the gpu particle triggers those errors (as soon as it emits, even without particle material). SSIL is not active in my project.

This is an unrelated issue, likely related to #57471.

I don't think it is related to your suggestion, since the error came up with alpha 11. In Alpha 10 it worked without any errors. Now the particles aren't even visible. Also I don't have to add particle material to get the error.

If you haven't looked at this reply in #62803 - check it out. The user shader_cache likely contains the culprit.
https://github.com/godotengine/godot/issues/62803#issuecomment-1178265235
Go to Project -> Open User Data Folder, delete shader_cache and reload the editor. Errors gone, no project changes needed.

Closing per @cridenour's comment. Please continue the discussion about shader cache invalidation in https://github.com/godotengine/godot/issues/63056 :slightly_smiling_face:


Missing fields in all-transactions response on mainnet: tokenId and tokenInfo are missing

Describe the bug
ERC20_TRANSFERS are missing tokenId and tokenInfo fields. Those are required by the mobile client to show correct data in a transaction list.
To Reproduce
https://safe-transaction.gnosis.io/api/v1/safes/0x1D5Fceb726FcbAA3d7D9885b8666305ED44Ad23E/all-transactions/?limit=150
Mainnet

Erc20 transfers don't have a tokenId, that field is for erc721 transfers

Also token info is present on staging, so maybe it is not deployed yet?

It's not deployed yet @elgatovital


Questions about wxlibrary use

@Correct-Syntax Firstly I'd like to say, you have done a good job working on the wxnodegraph stuff. Just trying it out I was surprised it worked decently out of the box. Tho it does still have crash issues here and there when linking things and clicking around.
I'd like to help, but I'm not sure how far you are in your project as to whether I should continue working on the little bit I've done with my copy of wxnodegraph.
I'd like to see the wxnodegraph actually become part of the standard wxPython lib. This would benefit everyone from having to duplicate a lot of the work when it comes to customizing options and the sort and in the end dealing with bugfixes, etc...
but doing that will mean basically ripping out the basic node functionality and turning it into a package that requires just wxpython as a base. A lot of projects in the past I have seen will start out and someone will come along and ask if they can use the widget and get told they can, but it is so ingrained in the program that it would be a nightmare to reverse without ripping the whole program to shreads. Timeline project for example was one that did this but kind of realized they couldnt do it fully because their program was actually a timeline and keeps track of itself... go figure... :/
When I started hacking on mine I had a few other ideas in store, mainly one was similar to how you do custom nodes. This allows users to implement something on the fly which is specific to their needs that for example wouldn't be able to be done with just base wx. In Embroidermodder we achieved this by making every single command in the program basically a plugin(custom node in your case), all the way down to simple cut copy paste stuff lol.
I had need of a blender like node system in SourceCoder, but at the time I needed to write a ton of other code in order to be able to make dynamic nodes possible. For example, I could generate my code on the fly and also generate a nodegraph leading to possible problems where an exception occured ect ect. Also I figured it would be useful in my 3dModeler if I wanted to interface with my models I design in whatever program. Of course your biggest problem will be dealing with images also because that is the main reason for out of memory errors and crashes.

Also I'm not sure why you changed the license to apache2 from MIT...? Maybe its because you use other requirement libs in your program? Maybe you are worried about patent trolls. Personally I try to avoid it anytime I can because of the changelog statements. Most anyone isn't going to save 10 years of minimal changes just to please a lawyer(plus they are not going to spend 10 years reading it lol). Especially if you are the author of a code editor.
Basically what I'd like to do if you are not too far in the project is to help get the node stuff in a releasable state. On the wxPython end that basically means formatting for sphinx docs, trying to follow code conventions, etc, etc. and then make some demos.
I was the one who ported the whole demo to phoenix and boy let me tell you it sure was alot of work for a single person.
wxPython/wxWidgets license is basically LGPL with an exception that you can license your binary any way you want.
Also I'm sure that the wxWidgets folks would want to port such a widget into the C++ end which would make the widget alot faster... tho im not sure how much work that would entail on their end. probably would take awhile and they would want it to be stable and cross platform on the python end before doing so.
Anyhow, I'd like to hear your thoughts...

Hi @Metallicow,
Hope you are doing well.

Firstly I'd like to say, you have done a good job working on the wxnodegraph stuff. Just trying it out I was surprised it worked decently out of the box.

Thank you and HalleluYAH!

it does still have crash issues here and there when linking things and clicking around.

This is a known issue that has more to do with the threading issues with the image renderer, I believe.

I'd like to help, but I'm not sure how far you are in your project as to whether I should continue working on the little bit I've done with my copy of wxnodegraph.

I would definitely appreciate help with Gimel Studio. :)

I'd like to see the wxnodegraph actually become part of the standard wxPython lib. This would benefit everyone from having to duplicate a lot of the work when it comes to customizing options and the sort and in the end dealing with bugfixes, etc...
but doing that will mean basically ripping out the basic node functionality and turning it into a package that requires just wxpython as a base.

Hmmm.... Before I created Gimel Studio and worked with creating the node graph functionality myself, I probably would have agreed with you. However, my personal opinion is that a node graph widget is really something you need to have full control -made to fit the requirements of the application you are creating.
For example, many node-based programs (Pixaflux, etc) have the "output node" the one that is currently selected/active while other programs (such as Blender) have a separate Output node, etc. (I prefer the latter which is why Gimel Studio's node graph is that way!)
My point is that (to me), it would be difficult to try and make a node graph widget that was flexible enough so users could customize things like that. It would be a huge undertaking to do so, that's for sure. Maybe you're willing to do the work involved -and that would be great, but as of now with my own experience, I am glad that I implemented my own node graph.
I really feel like the end resulting node graph widget would be good (no doubt), but not very practical for many people. I am open to your thoughts on this, I just don't see it as something worthwhile ...to be honest.

Also I'm not sure why you changed the license to apache2 from MIT...? Maybe its because you use other requirement libs in your program? Maybe you are worried about patent trolls. Personally I try to avoid it anytime I can because of the changelog statements. Most anyone isn't going to save 10 years of minimal changes just to please a lawyer(plus they are not going to spend 10 years reading it lol). Especially if you are the author of a code editor.

I assume you are referring to wxnodegraph as MIT licensed. I chose Apache because it was a balance between the OS licenses and yes because of the req libs.
If I am not mistaken, wxPython does keep track of code changes in some of the source files.

Basically what I'd like to do if you are not too far in the project is to help get the node stuff in a releasable state.

I wouldn't be apposed to help with getting the node graph more stable. :)
Anyway, I do appreciate your pull requests and willingness to help. So, thank you.

As far as Jeffs changelog in the files. That stuff occured before we moved to github and had a proper file for changelogs/git revision system, etc. It is relatively old and shouldnt have been in a library file in the first place, but thats how things worked back in the old days sometimes.
Really in reality that is considered cruft and could be removed because that was done in Classic which is dead now. Only Phoenix will be worked on in the future. Stuff like that should have gone/been moved into a changelog file.
Occasionally you will see TODO's/Ideas lists in the files, but you have to realize that that simply means if you want to continue work and implement it then at some point those lines would be removed and a changelog entry would be made stating that XX feature has been added.
As far as my copy of wxnodegraph, I have a bit more to do but basically the drawing/looks part is similarly finished like yours. I haven't implemented detaching yet tho... Instead of having a dc drawn image window like you are doing, I had more of an idea of using an actual window class/wxControl to do stuff in. For example a wxTextCtrl or wxSlider, STC, etc... Also I intend in the end to implement the majority into a matrix class so that scaling/zooming will act proper with the window. Sadly there is no PsuedoDC for Graphics Context on the C side yet, but that would make things a bit nicer than dealing with the alpha issues completely from the python side of things(which is way slower if calculating the alpha yourself) Eventually when I get around to adding it to my MCOW package basically the user or programmer would just subclass a base node and customize it from there, kind similar to how you are dealing with imports and then make their program from there depending on what area they may be focusing on(Ex: NonDestructive Image Generation in your case).

As far as my copy of wxnodegraph....

This sounds interesting...

Sadly there is no PsuedoDC for Graphics Context on the C side yet...

It would be nice if there was.

I had more of an idea of using an actual window class/wxControl to do stuff in.

How has this worked out for you?

Eventually when I get around to adding it to my MCOW package basically the user or programmer would just subclass a base node and customize it from there, kind similar to how you are dealing with imports and then make their program from there depending on what area they may be focusing on(Ex: NonDestructive Image Generation in your case).

Yeah. That is probably the right way to do it.

As far as the window drawing part... It is still very much a WIPz. For example everytime I work on something new in SourceCoder or try to start a new concept for a widget or improve one it often involves me writing more code in another module in SourceCoder in order to ease the development so I don't have to duplicate code a lot library-wise. One example is the pure python widget stuff. I recently finally got the CustomCheckBox from the wxPy wiki ported and updated and is now merged into what will become wx.lib.checkbox.GenCheckBox in wxPython4.1.1 . I added some helper functions/mixins to snag graphics for example. The native renderer stuff helps with the drawing of for example the checkbox graphics and whatnot. Other widgets sometimes need to be refactored so I can rip just the drawing methods out of them to make things easier.
As far as the matrix class goes. That is a can of worms in itself if you don't understand how matrix math(it often confuses folks) works, because besides just basic matrix operations you could send/pass a random/arbitrary matrix to be multiplied and it could cause unpredictible results. Also besides scaling the graphics, you have to deal with whether or not to rasterise fonts as they are finiky because wx.Font first arg doesn't accept a float.
As far as using actual native os c widgets, I'm still playing around with streaming and alpha code to try and get some stuff to work(it half works on MSW atm thanks to help from other wxPythoneers)
Ex: TaskBarButton I've played with for like 5 years until recently we figured out the alpha issues. Now I can recreate what most folks would call a desktop shell in python with proper alpha(at least on windows atm)

It would be awesome to support custom widgets also. wink wink tho I don't know if I'll ever get that far with the nodes.
But overall in the end my version will likely import a lot of other stuff already in the pure python lib from wxPy to help glue all the components together. I'll at least need to get my MCOW package into the library with the matrix as it will use some stuff from it also beforehand.
And as far as wxPy4.1 there has been event based changes/fixes on the wxWidgets side that messed up a lot of things on the python side(actually the problem/pyfix has been known for like 10 years, they just finally got around to doing it on the wxWidgets end lol). I also have to go ahead and write me a replacement for the agw aui notebook. That will be a chore in itself making a better one from scratch that wont rely on agw aui and will work with wxPy4.0 and wxPy4.1+ and support vector.
It will definitely take a while to get the notebook done so that SourceCoder doesn't have to hack around focus issues because of the new fixes. Then at that point I'll update my MCOW lib widgets to support vector. ... and in the mean time, I just chug along here and there working on whatever in my spare time. Ex: wxnodegraph is one of my many widgets on the WIPz/TODO list to get to a releasable state.

I am closing this because It doesn't really have much to do with Gimel Studio itself. Though, I have enjoyed the conversation and am curious to see how your wxnodegraph works out. 👍
What exactly is "SourceCoder". It must be an application you're working on?
Probably the most promising custom widget set I've seen made with wxPython is DynaUI. Unfortunately, it isn't maintained (that I can see) and the license is GPL (pretty-restrictive for doing much with it).

Well, I guess you could call it an application. It is a dynamic code editor basically, so if that gives you any idea, then it basically does everything(tho it isn't the fastest since it is written in python). I use it for many things including developing widgets, watching movies, making meshes, painting, etc,etc... But it is a book at heart. I used to work in a printshop and with the internet and everybody always wanting to sell you a home use junk printer that you might as well throw away after it runs out of ink, basically the industry is hurting bad. It is a dying trade, but will never be dead. And there isn't a whole lot of open source tools, so that is an added expense for small businesses. Overall, when it gets released, it will help be the glue or binding with any program that has a api users can use to script/etc. But it is also a self documenting book. Long story... it has been in development for over 10 years, just to be short and sweet.


Create a handbook which will encode a shared way to operate to this repo (e.g. pr, READme etc.)

John's comment on that:

Taking a look at this MNE contributions guidelines: https://mne.tools/dev/development/contributing.html. See what it makes sense to implement


Missing tests

I just pushed tests for the CSS (3fb26cc72e17632767ff7385dd70022edc06117c) and the JS (26ad4f31076a88762c1b974b9c14098e31b43f15) components.
I'll make PRs for the next ones and will leave them pending for a few days so that anyone can review them. It will also help to keep a better track of what have been done.
 Thanks!

All merged! \o/


Append all arguments to --complete

Fixes #7
(if using bash)
When bash-completion is invoked, all arguments are now
forwarded to the command, e.g.
sub command arg1 arg2
now triggers:
sub --complete command arg1 arg2
instead of just:
sub --complete command

And for ZSH?

4 years and no merge or comment from the maintainers?

Looks good, I recommend merging this.


fix: reduce module size with terser

PR Checklist
Please check all that apply to this PR using "x":

[x] I have checked that this PR is not a duplicate of an existing PR (open, closed or merged)
[x] I have checked that this PR does not introduce a breaking change
[ ] This PR introduces breaking changes and I have provided a detailed explanation below

PR Type
What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting)
[ ] Refactoring (no functional changes)
[ ] Documentation changes
[ ] Other - Please describe:

Fixes
Issue Number: #60
What is the current behavior?

Size 1,1MB
What is the new behavior?

289KB
Other information
I don't push the dist folder. I think that this folder shouldn't in the repo, only generate when the package publishing.

@DaniAcu Awesome, yeah I want to exclude some folders from the package itself, see: #22 #6


Fix Router healthchecks.

Healthchecks were looking at :3000 instead of :8000 where Router is listening. For now, just run Router on :3000 to save messing about overriding things in the shared Helm chart.
Once we refactor the charts we can go back to running it on its default port (8000) if we like.

Realised it wasn't just the port so had to do this a bit differently


java.lang.OutOfMemoryError: Direct buffer memory errors

Related to https://github.com/juxt/yada/issues/75
we're seeing
java.lang.OutOfMemoryError: Direct buffer memory

and
#
# There is insufficient memory for the Java Runtime Environment to continue.
# Native memory allocation (mmap) failed to map 3653632 bytes for committing reserved memory.
Java HotSpot(TM) 64-Bit Server VM warning: INFO: os::commit_memory(0x00000000ff815000, 3653632, 0) failed; error='Cannot allocate memory' (errno=12)
# An error report file with more information is saved as:

when streaming request bodies via manifold from aleph.
I'm using manifold.stream/reduce over the incoming stream (with raw-streams?set to true). Each buffer is subject to a byte-streams/to-byte-buffer which I thought decremented the reference count.
Versions are:
[aleph "0.4.1-beta5"]
[byte-streams "0.2.1"]
[manifold "0.1.2"]

I've been printing out the refCnt field of the ByteBufs from the stream and they appear quite high (3-6) but I'm not sure what is 'normal' here. Could this be a bug in Netty?
Also, JVM options are:
:jvm-opts ["-Xms1g" "-Xmx1g" "-server" "-Dio.netty.leakDetectionLevel=advanced"]

But I'm not seeing any leak detection messages from Netty's leak detector.
I'm a bit stumped. My current strategy is to replace netty+aleph with xnio+undertow to prove that the issue is not in manifold, but this might be misguided.

I will try to create a smaller failing test that only uses manifold, aleph and netty.

As I'm fairly sure this isn't an Aleph issue, I'm inclined to close this.  Any objections?

Yes, please close this issue.
For reference, the following did fix the issue.
-Dio.netty.allocator.numDirectArenas=0

However, the performance is then reduced substantially. This needs more investigation but directly with the Netty team.


Add pip requirements.txt file

This makes it easier to install dependencies (i.e. using pip install -r requirements.txt).

Thank you!


Validation layer catch(...) behavior is confusing

I recently encountered behavior in SteamVR where xrAttachSessionActionSets would sometimes throw C++ exceptions. While this may be a bug in SteamVR (throwing exceptions through a C ABI is obviously not well-defined), my investigation was slowed by the validation layers' silent, blanket conversion of all caught exceptions to XR_ERROR_VALIDATION_FAILURE, giving the appearance that specific application misbehavior had been detected, although no diagnostics were produced. This was further confounded by (I presume) C++ ABI details causing the exceptions to only be caught in release builds of the layers.
Ideally, the validation layer should only catch its own exceptions, by e.g. inheriting them from a private base class, and then catching that base class by reference.

The trouble with "catching its own exceptions only" is that STL classes are used in the loader, so we can't entirely change the thrown exceptions. (Indeed I don't think we throw any exceptions explicitly, since you can do a no-exceptions build if you have a no-exceptions c++ standard library build - the browsers do this)  This is definitely a SteamVR bug - no exceptions should leak out a C API - but it's possible we might be able to handle this better in the loader. If nothing else we could maybe wrap the actual invocation of the function in another try/catch so we could pre-emptively catch any erroneously-leaked exceptions from the runtime and do something more useful. (Turn them into runtime failure, at least) That said, I'm not sure, given that exceptions in a C ABI is not well defined, if the compiler would even retain such a try/catch that would appear impossible...
Do you know if anyone ever added a conformance test for the bug you found in SteamVR? We can probably also add exception-catching to the conformance layer, though same caveat around "not appearing possible" to the compiler applies here.

Oh I was confused when replying, I was thinking the problem was the catch in the loader. I'm not sure if the validation layer uses any stl things that might throw, I'll have to look at it again. If not we can remove the catches. Kind of strange that they're all turned into validation failure, runtime failure seems more appropriate.


#656 Add maketime function to MysqlSqlModule

https://github.com/zio/zio-sql/issues/656

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Sarah OToole seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

@sarahotoole accepted prematurely :). One small modification needed.

Thank you and congrats on the first contribution!


make Credit Card Payment Responsive

Issue Type:

[x] Bug Report
[ ] Feature Request
[ ] Documentaion

Describe the bug
Its not responsive

can i work on this?

Go ahead @Skapsime

Go ahead @Skapsime

okay

I am making an issue in AMAZING JS PROJECTS can you please assign me.

@Skapsime this issue was for
https://amazing-css-effects.netlify.app/credit card payment/

@Skapsime

@Skapsime complete it by today


[RFC] Set up a round-robin pool balance the host emitter work.

Hi guys, looking for a thumbs up/down on whether this seems like a reasonable strategy; I'll be deploying this strategy in our setup shortly, but wanted to get your comments first.
Before committing this to this project, I'll make the pool size configurable.

Does the configurable actor wrap the sink or another actor? In the latter case should the RR be pushed down into that level?

Looks like this doesn't solve my problem :(
Closing for now.

Okey, looks like this does indeed solve our problem once the race condition in DynamicConfiguration is solved. So I did both. What do ya think?

You didn't actually fix the race condition.


Feature: load .env

.env is a file that specifies the environment variables that should be loaded. AFIAK Poetry doesn't load these. Will poe do, though?

Currently, my tasks look like this:
[tool.poe.tasks]
    [tool.poe.tasks.run]
    shell = "if [ -r .env ]; then eval $(grep -v '^#' .env | xargs) poetry run python -m slashtilities; else echo 'You need to make a .env'; fi"
    help = "Run the bot"

https://github.com/ThatXliner/slashtilities/blob/4090f359cd72fa8ec55fe7f1a91bd76474100cb6/pyproject.toml#L22-L25

@ThatXliner It never occurred to me, having not used .env files for much myself. Though I see how it could be useful for your use case. Is the .env files a heroku thing in this scenario? What else do you use them for?
Currently you can specify env vars via a sub table at either tool.poe.env for env vars available to all tasks, or tool.poe.tasks.task_name.env for task specific env vars, but I guess having to duplicate the configuration is not desirable
Maybe what you're after could be best achieved by also supporting options like tool.poe.tasks.task_name.envfile = ".env".
The question then is what should happen if the file is missing? My first preference would be that it should be ignored, maybe with a console warning, because it keeps poe dependent on just the pyproject.toml. But it looks like in you're use case you wouldn't want to run the task without it. How important do you think this is?

@ThatXliner It never occurred to me, having not used .env files for much myself. Though I see how it could be useful for your use case. Is the .env files a heroku thing in this scenario? What else do you use them for?

No, you can set "config vars" (the name's misleading because they're just secret environment variables. Useful for setting API tokens)

Currently you can specify env vars via a sub table at either tool.poe.env for env vars available to all tasks, or tool.poe.tasks.task_name.env for task specific env vars, but I guess having to duplicate the configuration is not desirable

But.... secrets, though.

Maybe what you're after could be best achieved by also supporting options like tool.poe.tasks.task_name.envfile = ".env".

Yes, exactly. Default to .env

The question then is what should happen if the file is missing? My first preference would be that it should be ignored, maybe with a console warning, because it keeps poe dependent on just the pyproject.toml. But it looks like in you're use case you wouldn't want to run the task without it. How important do you think this is?

In my case, my program will raise a KeyError if the environment variable I need doesn't exist. Maybe this can be configurable.... (preferably just not require it). Yes, definitely a warning though. (I'm impressed by the CLI of poe. How did you manage this?)

Thanks for the feedback. Yes, secrets are a compelling use case.
I guess it doesn't make sense to be too strict about the presence of the dotenv file, since its validity/completeness is also uncertain anyway.
Enabling the dotenv file could be a boolean flag to enable (I think enabling it by default would be surprising), though I figure there's no great burden in making it a file path (like ".env") to get a little more flexibility, even if it's largely redundant.
Re: the CLI; It's largely inspired by poetry, and uses the same lib for console color, but the implementation is a bit more lightweight, some minimal usage of argparse and custom logic. It might be worth switching to use cleo for easier integration as a poetry plugin.

I came to the issues looking for this exact feature, so I just wanted to chime in and +1 this especially for handling secrets. If you aren't opposed to adding in other dependencies I've used https://saurabh-kumar.com/python-dotenv/ in the past and it's worked well, but a trivial implementation of reading a .env file might not warrant another library.
I could take a crack at an initial PR if you want? Let me know if that would be helpful.
Thanks for creating poe! I built something similar (https://github.com/adamghill/dj), but poe looks like it has more features and a much better implementation. :)

Since the opening of this issue I realised that it would be a useful feature on one of my own projects, so I definitely intend to add it (though I'm currently working on two other more complex features).
@adamghill If you're like to submit a PR, that's cool. I welcome the help, and other perspectives, just don't be offended if I'm super opinionated and picky about the interface and how it fits into the codebase 😉 . I'm happy to take a little time to talk it over.

Hey guys! I'm also interested in the feature. Maybe I can help?

Here's an idea: [tool.poe.envfile] (global) and tool.poe.tasks.task_name.envfile (task-specific) defaults to None. The envfile option specifies the file path relative to the pyproject.toml's parent (e.g. the project directory).
Then we modify config.py somewhere implementing the option.
Finally, we should

Try to find the envfile (I'm wondering if we should raise an error or a warning if not found?)
Parse the envfile (with open(self._poe["envfile"], "r") as envfile: parsed = {name: contents for line in envfile for name, contents in line.split("=", 1)} I think)
Load it like env

(I hope I have that list comprehension correct)

@nat-n can you explain these:
https://github.com/nat-n/poethepoet/blob/c5ac6cf3f9561f3891f620dc576e707cbcf441f0/poethepoet/executor/base.py#L41-L43

@ThatXliner nice. I think you're on the right track. See also here.
PoeTask.run is what does most of the env composition so it makes sense to control it from there. I'd probably extend the RunContext to abstract loading (and caching for the duration of the run) of env files.
The arguments to the executor constructor that you pointed out are:

the RunContext which is created at the beginning of a run, and shared by every task in the run, so it gets passed around a lot. For the purpose of the executor is mostly used in the PoetryExecutor to track whether this task is running inside another executor of the same type, and cache the location of the poetry venv for reuse across tasks.
options are options from the toml file relating to the executor (similar to task or global options, only used by VirtualenvExecutor so far)
and of course env is the default set of env vars that tasks will be set for tasks in this executor instance (unless the subclass decides to do something else...). It comes from the context which creates it by combining the env vars it gets (i.e. os.environ with the env vars from the task).

Is that clear?

Here's an idea: [tool.poe.envfile] (global) and tool.poe.tasks.task_name.envfile (task-specific) defaults to None. The envfile option specifies the file path relative to the pyproject.toml's parent (e.g. the project directory).
We modify config.py somewhere implementing the option:

Try to find the envfile (I'm wondering if we should raise an error or a warning if not found?)
Parse the envfile (with open(self._poe["envfile"], "r") as envfile: parsed = {name: contents for line in envfile for name, contents in line.split("=", 1)} I think)
Load it like env

(I hope I have that list comprehension correct)

@ThatXliner I often include comments and/or empty lines in .env files, so I'd lean towards https://github.com/theskumar/python-dotenv rather than rolling our own inline. Or at least some more robust parsing.
A workaround I'll likely use for now though is python-pyenv's CLI:
[tool.poe.tasks]
run = "pyenv run ..."

This is all starting to feel a bit stuttery though... invoking poetry run poe run as a "shorthand" for poetry run pyenv run dbt run --profiles-dir=. (in my case). 🤪  🙃

@nat-n so we should use another library, if you don't mind adding another dependency.
Also, I don't see a use case where one would want to place their .env under a different name. In other words, we should expect it to be in a file named .env the project root directory.
So, I think the envfile option should be renamed to load_dotenv which accept a Boolean value and defaults to False.

It seems to me that python-dotenv will default to finding a .env by itself if no .env is specified.

This is now available in pre-release 0.11.0b3

Just checked it out and it looks awesome. Thanks for your work on adding this feature into poe!

How do I use this feature? Any docs or examples?

@MattGurney https://poethepoet.natn.io/tasks/options.html#loading-environment-variables-from-an-env-file


fix(Dependencies): Bump itk.js and vtk.js to latest

This addresses some important ImageIO bugs in itk.js.

:tada: This PR is included in version 4.5.1 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


clarify visibility of credentials when used to create snapshot repository

Codecov Report

Merging #6933 into master will increase coverage by <.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #6933      +/-   ##
============================================
+ Coverage     83.17%   83.18%   +<.01%
- Complexity    13372    13382      +10
============================================
  Files          1536     1536
  Lines         49736    49736
  Branches       5981     5981
============================================
+ Hits          41369    41371       +2
+ Misses         5567     5563       -4
- Partials       2800     2802       +2

Impacted Files
Coverage Δ
Complexity Δ

...n/java/io/crate/exceptions/JobKilledException.java
0% <0%> (-66.67%)
0% <0%> (-1%)

...main/java/io/crate/auth/user/AlterUserRequest.java
47.36% <0%> (-42.11%)
5% <0%> (-2%)

...rc/main/java/io/crate/analyze/UnboundAnalyzer.java
76.92% <0%> (-20.52%)
2% <0%> (ø)

core/src/main/java/io/crate/types/ByteType.java
82.6% <0%> (-13.05%)
15% <0%> (-3%)

...a/io/crate/auth/user/TransportAlterUserAction.java
84% <0%> (-4%)
7% <0%> (-1%)

...tion/engine/distribution/DistributingConsumer.java
75.72% <0%> (-3.89%)
21% <0%> (ø)

...c/main/java/io/crate/exceptions/SQLExceptions.java
68.18% <0%> (-2.73%)
36% <0%> (-2%)

...ion/engine/collect/sources/ShardCollectSource.java
81.62% <0%> (-2.71%)
29% <0%> (-2%)

...lob/src/main/java/io/crate/blob/BlobContainer.java
77.5% <0%> (-2.5%)
17% <0%> (-1%)

...a/io/crate/execution/dml/TransportShardAction.java
77.77% <0%> (-1.86%)
13% <0%> (ø)

... and 23 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f2adb5...d0b991a. Read the comment docs.


🌱 add support for beta/rc releases in release notes

Support beta and RC releases in release note generator. Move some logic from Makefile to the release note generator, and then add nice unfolding summary section to hide details in beta/rc notes.
Fix previous release tag pattern detection in Makefile, and make the release note file named after the tag, same as CAPM3.
Example output visible in CAPM3 PR: https://github.com/metal3-io/cluster-api-provider-metal3/pull/1567

/override test-centos-e2e-integration-main  test-ubuntu-integration-main

/cc @adilGhaffarDev @mquhuy
/assign @kashifest

/approve


Create blacklist functionality for disposable email providers

Separate to banning so we can be more flexible in our approach, but with the same effect. Must tell the user that their email address provider is the issue, and to use a non-disposable email address.
Known providers

fakemailgenerator.com
mailinator.com
guerrillamail.com
getnada.com
10minutemail.com
maildrop.cc
temp-mail.org
throwawaymail.com
tempmailaddress.com
sharklasers.com
yopmail.com
mohmal.com
sharklasers.com
m.kuku.lu

Actually OK (mail forwarding service only)

33mail.com / 33m.co

https://dmoztools.net/Computers/Internet/E-mail/Spam/Preventing/Temporary_Addresses/
Also, check MX records

I've used a composer library (wesbos/burner-email-providers) which keeps track of these in the reporting scripts. We should probably use that for this.

Can we make calls to https://www.disposable-email-detector.com/?shell#Email-Hippo-Wesbos-DEA-Identification-API-DisposableEmails which uses that librarys data?

I'd rather we didn't make API calls where it's not necessary to do so.
wesbos/burner-email-providers provides a composer package we can use and reference the raw data file directly without needing to call out to third-party sites which may or may not be doing logging and data capture themselves.

So thinking about this again several years later - I'm wondering if we should be treating this as bans, or just treating this as another datapoint in the interface to be checked while handling a request.
We've already got the yellow diamond flag for indicating uncommon email domains, perhaps we could accept the request and show this highlighted as a red waste bin flag?
I don't know what's best to do here.
In either case, we'll want this to be pretty responsive from a web UI point of view. I'm not convinced that scanning text files every single page load is the right answer - a database lookup might be quicker. We should probably do some analysis to figure that out.

Personally I think it should be struck whist the iron is hot and rejected at submission stage.

a database lookup might be quicker

I agree, maybe have a job that runs every, I dunno, 30 days(?) to update the DB with the latest domains and then just check against that as part of the validation of email address?

Personally I think it should be struck whist the iron is hot and rejected at submission stage.

Yeah, though I'm having a hard time reconciling that with ACC's supposed role of being a last resort with human review for account requests. Is there a chance of false positives from these lists that other people maintain?

a database lookup might be quicker
I agree, maybe have a job that runs every, I dunno, 30 days(?) to update the DB with the latest domains and then just check against that as part of the validation of email address?

Exactly what I was thinking, though we might have to be careful with indexes to make sure it's faster than a text file lookup.

Yeah, though I'm having a hard time reconciling that with ACC's supposed role of being a last resort with human review for account requests. Is there a chance of false positives from these lists that other people maintain?
'If you are sure this is not a disposable address, email us at<EMAIL_ADDRESS>- If we get one, then we look a that domain more closely and potentially whitelist it in the update job


Print Caddy Version to Log on Startup

1. What would you like to have changed?
Print the version of Caddy to log when started
2. Why is this feature a useful, necessary, and/or important addition to this project?
It makes it easy to track the Caddy version running at different points in time while looking at the logs.
3. What alternatives are there, or what are you doing in the meantime to work around the lack of this feature?
The startup command be caddy -version && caddy [...etc], I guess.
4. Please link to any relevant issues, pull requests, or other discussions.
N/A

@Mohammed90 I would love to work on this.


Cannot disable leader election

Bug Report
What did you do?
I generated a new operator, then disabled leader election in cmd/manager/main.go with
    mgr, err := manager.New(cfg, manager.Options{
        Namespace:          namespace,
        MetricsBindAddress: fmt.Sprintf("%s:%d", metricsHost, metricsPort),
        LeaderElection:     false,
    })

then built the binary and started two copies of the operator in a k8s cluster, and it still performs leader election.
What did you expect to see?
No leader election in the logs.
What did you see instead? Under which circumstances?
One copy of the operator becomes the leader, and the other waits as the non-leader.
Environment
operator-sdk version v0.6.0+git

Kubernetes version information:
Client Version: version.Info{Major:"1", Minor:"10", GitVersion:"v1.10.11", GitCommit:"637c7e288581ee40ab4ca210618a89a555b6e7e9", GitTreeState:"clean", BuildDate:"2018-11-26T14:38:32Z", GoVersion:"go1.9.3", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"11+", GitVersion:"v1.11.7-gke.6", GitCommit:"144b681e3870074abfdaaf176e48b1b13360d7e5", GitTreeState:"clean", BuildDate:"2019-02-09T00:08:19Z", GoVersion:"go1.10.7b4", Compiler:"gc", Platform:"linux/amd64"}

Kubernetes cluster kind:
GKE

Are you writing your operator in ansible, helm, or go?
go

Additional context
My operator use-case does not modify any objects in the cluster, only reads information to update it in memory for other use, so I do not want leader election.

@snarlysodboxer Does your main.go file also have the following lines (around line 78)?
// Become the leader before proceeding
err = leader.Become(ctx, "my-operator-lock")
if err != nil {
	log.Error(err, "")
	os.Exit(1)
}

If so, that is what you should remove. You can also remove the LeaderElection: false line in the manager.Options struct if you'd like, because it is disabled by default in the controller-runtime manager.

@joelanford Thank you! That was it. It's working as expected now. Thanks again!


Default sort doesn't work with "deep" properties

I'm submitting a ...
[ ] bug report => search github for a similar issue or PR before submitting
[x] feature request
[ ] support request => Please do not submit support request here

Current behavior
When you specify a "deep" property as the prop for a column:
new TableColumn({
    name: 'Cylinders',
    prop: 'engine.cylinders'
}),

or
            <datatable-column name="Cylinders" prop="engine.cylinders">
              <template let-value="value">
                {{value}}
              </template>
            </datatable-column>

Sort malfunctions, the entire data set is not sorted.
Expected behavior
All rows are sorted based on the value for the column. This is the behavior for rows that use a "shallow" property
Reproduction of the problem
http://plnkr.co/edit/9Eug63qi775HVCMe3BhO?p=preview

On either the "Expressive: Cars" tab or the "Templated: Cars" tab, try to sort by Formation
See that the sort does not work.
On either the "Expressive: Cars" tab or the "Templated: Cars" tab, try to sort by Color
See the the sort does work

What is the motivation / use case for changing the behavior?
I need to sort on deep properties,
Since its trivial (from the usage standpoint) to display these properties using the prop input, it seems like sorting by them should be supported by the default sort
Please tell us about your environment:
Windows
VSCode
Node
Webpack Dev Server

Table version: 0.7.x
0.9.2

Angular version: 2.0.x
<EMAIL_ADDRESS>

Browser:
Only tried in Chrome

Language:

<EMAIL_ADDRESS>

We probably just need to apply similar code as this does - https://github.com/swimlane/angular2-data-table/blob/master/src/components/body/body-cell.component.ts#L34 ... Can you PR that?

@amcdnl,
Submitted


ToLookup overloads for key-value pairs & tuples of 2

Following on from #272, it makes sense to have overloads of ToLookup for key-value pairs and tuples of 2.

Available for testing in 2.4.0 beta 2.
Documentation also available online.


README - Add play store links

Add play store badges for Now In Android and Material Catalog
Test plan
Click on each badge and ensure it takes you to the correct page
Screenshots

Thanks!


Support aliased imports

As previously seen on #9034, I would like to use a separate, TypeScript-based "commons" library in two other TypeScript projects. The problem is that aliased imports are disabled for no documented reason. A workaround is possible with react-app-rewired through react-app-rewire-alias (since version 0.1.6 also fully compatible with my problem), but this should be natively supported in CRA.
The problem this would bring is that overrides in eslint-loader does not support absolute/external paths, so either a version that does support this should be used, or it should be ignored (possibly accompanied by a warning that they are not linted).

I just wanted to use aliased imports too and it was a rather rude realization when CRA removed it from my config. Before I tried this I expected problems with Jest, but it turns out that moduleNameMapper option is no longer blacklisted which solves it.
@JollyGoodHolly Sadly it seems that react-app-rewire-alias solves only a part of the problem. When CRA is actually removing paths configuration from tsconfig it breaks the project in VSCode anyway because TypeScript can't grab it from react-app-rewire-alias configuration.
So as I said, it's pretty rude to remove something from the config. Instead, it should be left there and feel free to annoy me with a warning.


Add OpenBazaar v2.0.11

After making all changes to the cask:

[x] brew cask audit --download {{cask_file}} is error-free.
[ ] brew cask style --fix {{cask_file}} reports no offenses:
A maintainers is required to verify both the url and homepage, as they differ.
[x] The commit message includes the cask’s name and version.

Additionally, if updating a cask:

[ ] sha256 changed but version stayed the same (what is this?).
I’m providing public confirmation below.

Additionally, if adding a new cask:

[x] Named the cask according to the token reference.
[x] brew cask install {{cask_file}} worked successfully.
[x] brew cask uninstall {{cask_file}} worked successfully.
[x] Checked there are no open pull requests for the same cask.
[x] Checked the cask was not already refused in closed issues.
[x] Checked the cask is submitted to the correct repo.

Thanks @miccal! 👍


Missing dll's - git290befde.dll

Development Environment: Windows 7 Ultimate, Visual Studio 2013
Deployment Environment: Microsoft Azure Web App
Error:  Copying file bin\NativeBinaries\amd64\git2-90befde.dll to obj\Release\Package\PackageTmp\bin\NativeBinaries\amd64\git2-90befde.dll failed. Could not find file 'bin\NativeBinaries\amd64\git2-90befde.dll'
Commit: 5e2184f75647057cd12bca6a93c00a6cdd3959ab
Action: Publish - Release - Any CPU
Output:

1>------ Build started: Project: Bonobo.Git.Server, Configuration: Release Any CPU ------
1>  0 File(s) copied
1>  0 File(s) copied
1>C:\Users\Brett\Documents\Visual Studio 2013\WebSites\Bonobo\Bonobo-Git-Server\Bonobo.Git.Server\Helpers\MembershipHelper.cs(50,30,50,32): warning CS0168: The variable 'ex' is declared but never used
1>  Bonobo.Git.Server -> C:\Users\Brett\Documents\Visual Studio 2013\WebSites\Bonobo\Bonobo-Git-Server\Bonobo.Git.Server\bin\Bonobo.Git.Server.dll
2>------ Publish started: Project: Bonobo.Git.Server, Configuration: Release Any CPU ------
2>Transformed Web.config using C:\Users\Brett\Documents\Visual Studio 2013\WebSites\Bonobo\Bonobo-Git-Server\Bonobo.Git.Server\Web.Release.config into obj\Release\TransformWebConfig\transformed\Web.config.
2>Auto ConnectionString Transformed Views\Web.config into obj\Release\CSAutoParameterize\transformed\Views\Web.config.
2>Auto ConnectionString Transformed App_Data\Web.config into obj\Release\CSAutoParameterize\transformed\App_Data\Web.config.
2>Auto ConnectionString Transformed obj\Release\TransformWebConfig\transformed\Web.config into obj\Release\CSAutoParameterize\transformed\Web.config.
2>Copying all files to temporary location below for package/publish:
2>obj\Release\Package\PackageTmp.
2>C:\Program Files (x86)\MSBuild\Microsoft\VisualStudio\v12.0\Web\Microsoft.Web.Publishing.targets(2586,5): Error : Copying file bin\NativeBinaries\amd64\git2-90befde.dll to obj\Release\Package\PackageTmp\bin\NativeBinaries\amd64\git2-90befde.dll failed. Could not find file 'bin\NativeBinaries\amd64\git2-90befde.dll'.
2>
========== Build: 1 succeeded, 0 failed, 0 up-to-date, 0 skipped ==========
========== Publish: 0 succeeded, 1 failed, 0 skipped ==========<

It appears as though git2-90befde.dll does not exist but instead git2-e0902fb.dll is in its place.
If this is a problem on my end, please explain your ideas for fixing it. If it is not, I hope this is a useful reference.
Thanks!

Proposed fix: #318


Correct V5 & V6 Docs + added ts-codesandbox

I Aligned the code on the website with what is in the codesandbox's.
I am planning on adding some more codesandbox's if this PR is met with approval.

awesome! thank you. yes, please.


docs: v_t defined as function of v_t ?

In the documentation of the (non-separable) value function, the signature is given as:
$v_t = w(s_t,x_t,v_t,s_{t+1},x_{t+1},v_{t+1})$
Note that $v_t$ is repeated on both sides of the equation.
Is that intentional?
See:
https://github.com/EconForge/dolo.py/blob/master/docs/model_specification.md#value
https://dolo.readthedocs.io/en/latest/model_specification.html#value

yes, it is a general updating equation. It is there to
accommodate nonseparable value function like epstein-zin formulation.
It is also defined as such in the recipes file
https://github.com/EconForge/dolo.py/blob/master/dolo/compiler/recipes.yaml
For the "reward" there is an additional felicity function which is purely
intratemporal.
In any case, this could use some dust cleaning, or some name
renormalization: the VFI algorithm was never very advanced in dolo
On Wed, Apr 5, 2023 at 4:37 PM Sebastian Benthall @.***>
wrote:

In the documentation of the (non-separable) value function, the signature
is given as:
$v_t = w(s_t,x_t,v_t,s_{t+1},x_{t+1},v_{t+1}$
Note that $v_t$ is repeated on both sides of the equation.
Is that intentional?
See:
https://github.com/EconForge/dolo.py/blob/master/docs/model_specification.md#value
https://dolo.readthedocs.io/en/latest/model_specification.html#value
—
Reply to this email directly, view it on GitHub
https://github.com/EconForge/dolo.py/issues/235, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AACDSKJWJM5HONOBB2F5EYDW7V7UDANCNFSM6AAAAAAWUFMIDY
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

I'm sorry if this is a dense question, but isn't $v_t = v_t$ always, so if $v_t$ is an argument to $w$, the function is trivial?

Actually the way I did Epstein-Zin a while ago was by iterating on two variables:
V_t  <- U(c_t) + \beta (V_{t+1}/EV_t^{1/alpha})^{-\gamma}
EV_t <- (V_{t+1})^\alpha
In equilibrium, EV_t is of course the same on the left and on the right.
I admit it is a little bit of a corner case ....
In other applications, I used arbitrage equations for the same purpose (treating left and right hand side in the same way) but that is also not super satisfying.

Oh, I see. So with some solution algorithms, you might run this to convergence to solve for a single period, before incrementing t.
So there's two update/convergence loops?
Is the solution algorithm for this in the repository?


Add Critical Success Index to Torchmetrics

🚀 Feature
In weather forecasting, critical success index (CSI) is widely used to evaluate model skill. However, Torchmetrics does not have this metric. Instead, one must determine the true positives, etc. and calculate it locally which can get a bit clunky. I think it would be good for weather applications of artificial intelligence to be able to call this metric directly from torchmetrics.
Motivation
I find myself bogged down with trying to figure out CSI for a paper I am writing to present a model to the forecasting community. Since they use this metric frequently, if I don't have this metric my model may not be taken seriously. So, it would be nice to have a function to do this.
Pitch
Create a Torchmetrics metric for Critical Success Index.
Alternatives
An alternative would be to have documentation for how to calculate this metric from existing metrics.
Additional context
Definition of critical success index from a brief google search and from NOAA:

The critical success index is usually calculated at many thresholds (i.e. .1, .2, .4) and used to determine which threshold the model performs best at.

Hi @sortland33 ,
We would definitely welcome such an addition. Once you figured it out, would you submit a PR to add it here for future use both by yourself and others?

Hi @justusschock (and @SkafteNicki ?),
I wrote some code for this new metric, but it is specific to a 2 class case. This is my first time ever submitting a PR- do I need to try to generalize it to multilabel and more than 2 classes before I submit a PR?

Hi @sortland33,
You can send a PR with what you have, then it will be easier to identify what to do next :)

Hello, I stumbled across this issue. I implemented CSI for my own project, so I thought I might polish up and contribute what I have. I don't have any unit tests yet, as I didn't know what implementation could be used as a reference (torchmetrics and scikit-learn have Jaccard index but that requires different inputs than CSI)


accessible_by with :manage "all"

Model.accessible_by(current_ability) causes:
The accessible_by call cannot be used with a block 'can' definition. The SQL cannot be determined
Is there currently not a way to return all records for a model when this permission is in the ability class?

I feel like the anticipated results of accessible_by for an ability class that doesn't explicitly have sql or resource conditions to go off of would be to return all the records?

Please refer to Stackoverflow for questions. Thanks.


Please update to latest angular ivy library.

It seems angular-scrollspy still use ViewEngine library.
In latest angular and modern angular versions, they drop ViewEngine library build and recommend to use ivy compile library pattern.
It is easy to update.
Just put enableIvy in tsconfig.json
I can make PR for this updates. Please consider it.

Thanks for showing interest in our angular-scrollspy library, we're not actively maintaining this package at the moment but we'd be more than happy to accept a PR for the necessary updates.


Case sensitivity issue while comparing

There is case sensitive comparison in terraform script.  However not all part of the resource id is case sensitive.

Reference:
https://learn.microsoft.com/en-us/azure/azure-resource-manager/management/frequently-asked-questions
It is recommended to convert both side of comparison to single case .

@ibersanoMS can you take a look at this please?


[5.4] Disallow access to protected properties via array access

This PR fixes an issue with the offset* methods referring to magic methods allowing to access and manipulate protected properties.
For example:
$model['table']; // returns value of protected $table instead of $attributes['table']

Array access is also leveraged in other cases, for example in Collection methods, which use data_get to retrieve values:
$collection->pluck('attributes'); // basically dumps models contents

Thanks to @arikal for finding this.

What if the value of that attribute is null? Like if you have a nullable field in your DB

@ntzm A null will be returned. The behaviour will be exactly the same as when accessing property.
Assuming I have a table like this:
CREATE TABLE foo (
    id int(10) UNSIGNED NOT NULL,
    name varchar(255) NOT NULL,
    attributes json DEFAULT NULL
);

...and an entry in this table with empty attributes, fetched to the $foo variable:
Previously:
$foo->attributes // null
$foo['attributes'] // array 😱

This PR:
$foo->attributes // null
$foo['attributes'] // null 😌

Ah right, nice one 👍

laravel/internals#45

I couldn't really make this change on the 5.4 branch as it is breaking.

Can you provide an example how one could use this 'feature' on purpose? My understanding is that if someone needs to access/mutate protected property, they can add getter/setter to their models, but array access here was meant for attributes alone.
I understand semver and all, but I consider it a long time bug (laravel/internals#45), so maybe current LTS is a better branch? Otherwise, I'll create PR for 5.5 and extend offset* methods in my models for the time being.

@mrliptontea target the next branch :)


Clean kluge

As you know, trying to send a non-static reference to the test thread is not feasible. I have three alternative approaches (one per commit), but only this one was cross-platform (Win10, Xlib, Wayland). Interestingly, Xlib works with either the handle or the window variant.
This whole test workaround is still easily ripped out, but the state is similar to here. The deltas now are cargo-nextest fails instead of hanging on X11 and I know it fails on Wayland.

Apologies if this was too forward, but your PR made several quick improvements easier to see.


🐛 syncer: Fix wrong logic in dns-related process

Summary
We should:

trigger the creation of the CoreDNS deployment (if not already created) by the Syncer on any resource syncing, at the condition that deployments are part of the synced GVRs for this synced target.
wait for the CoreDNS deployment to be reachable through a service before syncing a resource, but only when syncing a deployment. In this case, the deployment resource should be requeued after a small delay.

Related issue(s)
Fixes flaky e2e tests

/test test

I did some local testing, all work as expected. LGTM

/lgtm

Seems this is not sufficient to fix the errors in the e2e tests. Let's postpone the merge here.

/hold

/lgtm

/unhold

/approve


RocketMQ Feature Request: Transaction-Aware Message

Messaging is a major approach to decouple distributed systems. However, when trying to decouple system modules whose boundaries are associated with transactions, it is subtle to determine when to send messages. For example, when module A completes a database transaction, it needs to send a message to notify module B, C, and D to perform subsequent actions. The problem is what the best time point to send the message is in comparison with database transaction. If we sent the message before database transaction, what if the application or database server crashed out. The same counts if the transaction rolls back due to any potential reason. If we sent the message after the transaction commits, there will be chances that application server may suffer crashes before message delivery is made. Thus, to maintain consistency of the whole system, we need to either implement an extra module to periodically check messages of each transaction is sent given messages are designed to send after the transaction commits and supplementally send those missed ones to achieve eventual consistency or make our messaging system transaction aware.
The first option is viable, but it excessively complicates business application systems and brings about noticeable overhead as the extra module has to repeatedly check committed transactions and messages sent are in accordance after a period of time. The latter choice, however, confines complexities to the messaging system itself and once achieved, all application developers may enjoy simplicity and consistency.
To achieve the goal described above, we define a new type of message: transaction aware message. A transaction-aware message is composed of a pair of deliverable messages: prepare-message and commit/rollback message. Prepare messages are supposed to be sent before local transaction commits/roll-back, which are not visible to consumers. Commit/rollback messages are sent after transaction commits/rolls back. Brokers are responsible to inquire application servers, which share the same role with those prepare-message senders, to handle pending prepare messages after the defined period of time. On receiving of the commit message, the transaction aware message is made visible to consumers; Similarly, on receiving of rollback message, pending status of the corresponding prepare message is canceled quietly and consumers are completely unaware in the whole process.

Thanks for @lizhanhui's feature request，and as mentioned above, with the rise of micro service architecture，developers are eager to use a mechanism to ensure the eventual consistency of transaction, especially in distributed systems, and we also found transaction aware message can achieve this goal gracefully, so we intend to implement this feature in rocketMQ, and this process is as follows：

In our design, we will define a pair of message: named half message and commit/rollback message. As mentioned by @lizhanhui, half message means prepared message, which are not visible to consumers，and it will be sent before local transaction is executed. After the local transaction ends，producer will send a commit or rollback message  to broker based on local transaction execution result. when producers are blocked or crashed after send a half message，the broker will check all of producers with the same role to obtain the transaction status, so producer must implement the check listener interface to response transaction check query request.
In our implementation, we will make full use of the mechanism of rocketMQ itself to avoid external dependencies, so we will build two new system topic to store half message（RMQ_SYS_TRANS_HALF_TOPIC）and commit/rollback result message(RMQ_SYS_TRANS_OP_HALF_TOPIC)，and we will also add a checkback service in broker to periodically check every message in the half message queue, if its corresponding result message can be found in the result message queue, it will be consumed or discarded depends on its result status，and if this message cannot be found in the result queue，that indicates that it was in pending status， so the checkback service will send check request to all corresponding producers to obtain transaction status, at the same time，we will also support immunity time config for producer to avoid being checked prematurely, the pending status but still in immunity time message will be reload to the half message queue to wait for the next round of check.

队列如何对待没有提交，或者回滚的消息。
如何回滚消息，回滚消息的性能。
主从与宕机的一致性处理，宕机之后如何保证之前的消息的一致性
如果要处理一致性，是否做类似与MySQL的 rodu，undo吗？

Good catch for transactional message :-) IMO, the feature will give a awesome complementation for the SAGA pattern, and could we consider abstract the local storage in the broker? In that case, we could create a common solution for the span-multiple-service transactions in the microservice field :-)

when publish 4.3.0?

@zjw2011  Will you help to review the PR as the issue referred ? could be helpful for the community.

Close as this feature is merged


Modernizing

There are a number enhancements I'd like to add to your awesome tool and was hoping I could get feedback on whether you are still maintaining the repository, and if so, what your opinions were on the following:

Publishing to npm. I'd do it under your npm user name and repo if you wanted to do publishing. Otherwise, I might just publish my own fork.
Adding ESLint. I'm partial to my own rather strict standards at https://github.com/brettz9/eslint-config-ash-nazg , but I could apply a different set if you preferred.
Converting to ES6 Modules and ES6 source, using Rollup and Babel for distribution files (both UMD and ES bundles), ideally, imo, in a src and dist directory.
~Possibly avoiding the jQuery dependency by~ using ES6 and modern browser features (which can be polyfilled for those targeting older browsers).
Though I'm not keen to add a bunch of tests now, I thought it might be nice to add the awesome testcafe for UI tests so tests can be added as contributors may be inspired.
Add JSDoc

Besides getting your feedback, I'd really hope you might be willing to apply your genius to complete the unfinished polyline feature as it would be really great to have this fundamental type of map added to the available options.
Thanks very much!

If you are no longer maintaining, please let me know, so I can release my own updated version of your package.

@brettz9
Good job. Please take a moment to review. /cc @ahnbj2000

@brettz9
I will check PR. And publishing to npm is a good idea, i will proceed. thanks.

By the way, to possibly save some of your time, feel free to ask why any changes were made...

@brettz9
I published it in npm. I will complement the readme and demo.

Wonderful... Btw, you may want to update gh-pages, since now this fork includes an updated, improved version of the demo that gh-pages has.
Also, my personal suggestion would be to make tags in the form v1.0.0 (instead of just v1) even for new major releases, so people know more clearly that you are using "semantic versioning" and so they can find the tag predictably, since other projects I think tend to use the fuller form for tags than just v1.
And thank you all again for an excellent code base. I'm eager to try to put it to good use!


[Content group horizontal] Storybooks QA

General entry

Rename to Content block horizontal (no one remembers why this is named Content group horizontal)

Storybooks entry should be:

Content block horizontal
    Default

General issues

Make sure the spacing after the section heading is 32px as according to AEM recommendations

What it should be

What it currently is

There is an extra bottom padding for the links that makes the spacing between them and the horizontal rule 64px + an extra 16px

The grid alignment is off. Content starts at col 4

Horizontal rule should span 12 col and overhang

What it should be

What it currently is

Adjust the content item width on md

What it should be

What it currently is

Design will confirm the remaining and specs of this component, then work will be ready for dev.

@RobertaJHahn  @DragosRistici I'm gonna break this issue down into smaller dev issues to fix. Design clean up is done.


Introduce Torus Export

We've had a lot of feedback from users that it's confusing to use torus view to export credentials from Torus.
To remove this confusion, we are thinking of deprecating the --format flag on torus view and moving the associated behaviour to torus export as a first class citizen.
Additionally, it'd be great to expand the format support of export to support different shells such as sh, bash, fish, powershell etc. It'd be pretty cool if we could also detect the current shell and output appropriately depending on the value of the SHELL environment variable (at least on *nix, not sure if it's possible on windows?).
Ideally, it should also be super clear that you can export or write out to a file while also supporting out putting via stdout.
Current Ideas
# Inside a linked project, export to the current shell env
$ $(torus export -e production)

# Inside a link project, export to a file
$ torus export -e production -f json config.json

# Outside linked project, export to a file
$ torus export -o myorg -p api -e production -f json > config.json

There should also be a hint telling the user about export.


UI not showing properly in production environment!

I have followed your tutorial properly but at the end the ui is not working properly. What might be the reason?
I tried by uploading the vendor files through github but didn't help.

Thanks in advance. I would really appreciate if you could help me out.

Check if "python manage.py vendor_pull "
Worked properly then confirm the local cdn folder has all the files.

Yes, the vendor_pull works properly, and my local CDN has all the files as well. I tried by manually giving all the vendor files without using the vendor_pull command inside dockerfile but didn't work as well.

What was the issue?

What was the issue?

I fixed the issue by using flowbite.min.js 2.3.0 (from cdn) inside the dashboards nav.html. Though I had the same version in the vendors file and I was using that through base.html but somehow that was not working.