Normalized cache does not try to normalize internal objects if query caching fails

I have found the Android Apollo client to behave differently than the iOS client. Making the normalized caching unusable.
On iOS I use the cacheKeyForObject to set a cache key. This method is evaluated once for the entire response and once for each object in the response. For example, if returned { "object": [Object] }. It would be evaluated for the dictionary containing "object" and also for each Object. Furthermore, if there was a cache miss, the apollo client would still return a result.
Code:
client.cacheKeyForObject = {
return $0["urn"]
}

However, on Android. The resolver only evaluates once for the entire response, making it impossible to do any cache normalization. Secondly, the graphql query doesn't seem to emit a response when there is a cache miss.

val query = GetTagsForGroupQuery(group, size, start)

return Rx2Apollo.from(apolloClient.query(query))
.map { getTagsResult -> Result.fromResponseRequiredData(getTagsResult, LOG_TAG) }
// this map function is not evaluated upon cache miss.

Bugs:
1. resolver does not evaluate each object in response, just top level
2. on cache miss, the query does not emit values
3. There is no SqlNormalizedCacheFactory as mentioned in documentation

Code:
CacheKeyResolver resolver = new CacheKeyResolver() {
@NotNull @Override
public CacheKey fromFieldRecordSet(@NotNull ResponseField field, @NotNull Map<String, Object> recordSet) {
return formatCacheKey((String) recordSet.get("urn"));
}

@NotNull @Override
public CacheKey fromFieldArguments(@NotNull ResponseField field, @NotNull Operation.Variables variables) {
return formatCacheKey((String) field.resolveArgument("urn", variables));
}

private CacheKey formatCacheKey(String urn) {
if (urn == null || urn.isEmpty()) {
return CacheKey.NO_KEY;
} else {
return CacheKey.from(urn);
}
}
};

// There is supposed to be a sqlCache we can chain so we can read-write from the in-memory cache and allow trickle down writes
// to the sql cache, but in 1.0.0-alpha it didn't seem to exist
NormalizedCacheFactory cacheFactory = new LruNormalizedCacheFactory(EvictionPolicy.builder().maxSizeBytes(10 * 1024).build());

return ApolloClient
.builder()
.serverUrl(globalConfig.getGraphQlUrl())
// this works
//.httpCache(new ApolloHttpCache(cacheStore))
// this does not work
.normalizedCache(cacheFactory, resolver)
.okHttpClient(okHttpClient)
.build();

Environment:
Android Studio 3.2.1
Nexus 5X API 27 emulator
implementation 'com.apollographql.apollo:apollo-runtime:1.0.0-alpha'
implementation 'com.apollographql.apollo:apollo-rx2-support:1.0.0-alpha'
implementation 'com.apollographql.apollo:apollo-http-cache:1.0.0-alpha'

Howdy ho! https://github.com/apollographql/apollo-android/blob/master/apollo-android-support/src/main/java/com/apollographql/apollo/cache/normalized/sql/SqlNormalizedCacheFactory.java does in fact exist.  It is in the apollo-android artifact since we use the android version of sqlite.  Let me try to gather more info on the cache impl, my understanding was that it is consistent wtih other clients.

Going to close this since the iOS counterpart is also closed.


More reliable mechanism for _this/_super simplification

This changes the somewhat fragile way we handled the simplification of constructor body statements when transforming super() that became even more fragile in TS 5.2. These simplifications were intended to slim down transformed constructor bodies when a temporary variable like _this may not be necessary:
// given
class C extends Base {
  constructor() {
    super();
  }
}

// without simplification
var C = (function (_super) {
    function C() {
        var _this = this;
        _this = _super.call(this) || this;
        return _this;
    }
    return C;
})(Base);

// with simplificaiton
var C = (function (_super) {
    function C() {
        return _super.call(this) || this;
    }
    return C;
})(Base);

However, when using was introduced in TS 5.2, the simplification mechanism became more complicated as the super() statements we would normally look for would be moved inside of a try..catch..finally block if the constructor contained a using declaration.
Rather than try to handle specific super() simplifications when initially visiting the constructor body, this PR instead performs these simplifications in a second pass after the initial transformation completes. This results in a mechanism that is more reliable than the prior approach as it only performs these simplifications with complete knowledge of the transformed result..
Fixes #55646
Fixes #55637

@typescript-bot perf test

I'm going to make a small update to make updatePropertyName public to align with https://github.com/microsoft/TypeScript/pull/56194


YouTube TV uses blur event as well. Resolves #4

Not 100% sure this is side effects free, but other inputs still receive the blur event, so I guess it should be fine.

@buttercookie42 Would you like to review this? This may be a better solution than #11.

@Lusito: As I cannot test this, can you confirm that this is still required and that your fix is still working?

As I cannot test this

I'm curious about why couldn't you test this, though. This is about the TV interface for YouTube, not the region-locked, paid streaming service.

I had googled "Youtube TV" and only found the latter, not the former. (Also didn't look closely enough at your issue). Sorry for the confusion and thanks for clearing this up.


MOBILE-1756 forum: Support for nested order of posts in forum discussions

Hello,
thanks for working on this, I've submitted it for peer-review via the https://tracker.moodle.org/browse/MOBILE-1756 issue.
You should subscribe (watch) this issue in the tracker to get further notifications

Hi @brikendr !
I added some comments on https://tracker.moodle.org/browse/MOBILE-1756 please review them! :-D
Thanks for your work!

Closing this pull request since it was already integrated.


SNOW-1304211: Pylance throws errors when using copy_options with copy_into_location method

Please answer these questions before submitting your pull requests. Thanks!

What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Fixes https://github.com/snowflakedb/snowpark-python/issues/1363

Fill out the following pre-review checklist:

[ ] I am adding a new automated test(s) to verify correctness of my new code
[ ] I am adding new logging messages
[ ] I am adding a new telemetry message
[ ] I am adding new credentials
[ ] I am adding a new dependency

Please describe how your code solves the related issue.

src/snowflake/snowpark/dataframe_writer.py: The copy_into_location method was updated in three instances. The copy_options parameter was changed from Optional[str] to Optional[Dict[str, Any]]. This change allows for a wider range of types to be accepted as copy options, providing more flexibility when calling the method. [1] [2] [3]

I have read the CLA Document and I hereby sign the CLA

@sfc-gh-stan

I suggested 2 additional type hint fixes.

Thank you for your suggestion. I'd like to propose a slightly different fix for the blocks type.
The current suggestion sets block: Literal[True]. However, I believe it should be block: bool to maintain type consistency with the _internal_collect_with_tag_no_telemetry function.
The blocks argument in the _internal_collect_with_tag_no_telemetry function is used as a bool type. Therefore, setting the blocks type to bool in the copy_into_location function as well will ensure type consistency.
src/snowflake/snowpark/dataframe.py
    def _internal_collect_with_tag_no_telemetry(
        self,
        *,
        statement_params: Optional[Dict[str, str]] = None,
        block: bool = True,  # <-- here
        data_type: _AsyncResultType = _AsyncResultType.ROW,
        log_on_exception: bool = False,
        case_sensitive: bool = True,
    ) -> Union[List[Row], AsyncJob]:
        # When executing a DataFrame in any method of snowpark (either public or private),
        # we should always call this method instead of collect(), to make sure the
        # query tag is set properly.
        return self._session._conn.execute(
            self._plan,
            block=block,
            data_type=data_type,
            _statement_params=create_or_update_statement_params_with_query_tag(
                statement_params or self._statement_params,
                self._session.query_tag,
                SKIP_LEVELS_THREE,
            ),
            log_on_exception=log_on_exception,
            case_sensitive=case_sensitive,
        )

    _internal_collect_with_tag = df_collect_api_telemetry(
        _internal_collect_with_tag_no_telemetry
    )

@sfc-gh-stan
Thank you for your suggestion. I have implemented your suggestion with a slight modification.
I have added a default value to the blocks keyword argument. This is because keyword arguments are optional, and not providing a value would result in an error.

Tests kicked off by #1377, will merge after merge gates pass.


Mark each kubernetes object created by Space Cloud with a special annotation

We should mark each object that space cloud creates with a special annotation so users do not accidentally change the config objects created by space cloud runner.

If you want this feature to be implemented, give it a thumbs up reaction, so that we can determine which features are important to you.
👍

Done. coming in v0.16.0


Installation with pip==23.1 gives PyYAML error

The newest version of pip produces unstable results, e.g., sagemaker-ssh-helper may fail to install in some SageMaker Studio kernels with the following error:
ERROR: Cannot uninstall ‘PyYAML’

The current workaround is to downgrade pip to the previous version:
pip install pip=23.0.1

The source of this error is found in SageMaker Python SDK, so it's not specific to SageMaker SSH Helper.
Same PyYAML error is in the SDK build logs:
https://github.com/aws/sagemaker-python-sdk/pull/3793#issuecomment-1512117512

Released in v1.10.2 .


Issues with Electron

Hi, I've been trying to use KUTE.js with Electron Framework, but the following error triggers if trying to use relative paths for the JS files:
`internal/modules/cjs/loader.js:659 Uncaught Error: Cannot find module './kute.js'
Require stack:

C:\Users\jhawkins.admin\Desktop\DevelopmentTest\index.html
at Module._resolveFilename (internal/modules/cjs/loader.js:659)
at Function.Module._resolveFilename (C:\Users\jhawkins.admin\AppData\Roaming\npm\node_modules\electron\dist\resources\electron.asar\common\reset-search-paths.js:43)
at Function.Module._load (internal/modules/cjs/loader.js:577)
at Module.require (internal/modules/cjs/loader.js:715)
at require (internal/modules/cjs/helpers.js:14)
at kute-css.js:10
at kute-css.js:16`

This obviously doesn't happen if the index file and the js files are located on the same directory.

Try
const KUTE = require(kute.js/kute.js.js');

The following error appears if I try to require it from the npm  plugin folder.

Well it seems you're linking the script in the <HEAD> or you're trying to animate elements that aren't present withing the DOM, which isn't what this library was supposed to do

No, the script call is within the body element. However, I just found that a restriction inside my Electron initialize script was the culprit. For those who might have similar issues in the future, check the flags you have set up in your Electron app.
You can set up some flags in Electron through the appendSwitch function (specifically app.commandLine.appendSwitch) which might cause some conflict with KUTE.js and some other libraries. So that might be the first step.
Thank you so much for your support.


ddev remove --remove-data does not delete the database

Describe the bug
ddev remove --remove-data
I get this error:
Creating database snapshot ccp_remove_data_snapshot_20180828171834
Failed to create snapshot: Failed to run docker-compose [-f /Users/jvenne/vm/dev_ccp/.ddev/docker-compose.yaml exec -T db bash -c mariabackup --backup --target-dir=/mnt/ddev_config/db_snapshots/ccp_remove_data_snapshot_20180828171834 --user root --password root --socket=/var/tmp/mysql.sock 2>/var/log/mariadbackup_backup_ccp_remove_data_snapshot_20180828171834.log], err='exit status 1', stdout='', stderr='', stdout=, stderr=
Failed to remove ddev project ccp: Failed to run docker-compose [-f /Users/jvenne/vm/dev_ccp/.ddev/docker-compose.yaml exec -T db bash -c mariabackup --backup --target-dir=/mnt/ddev_config/db_snapshots/ccp_remove_data_snapshot_20180828171834 --user root --password root --socket=/var/tmp/mysql.sock 2>/var/log/mariadbackup_backup_ccp_remove_data_snapshot_20180828171834.log], err='exit status 1', stdout='', stderr=''

To Reproduce
ddev remove --remove-data
Expected behavior
I expect the database to be removed. I don't need a snapshot.
Screenshots
Version and configuration information (please complete the following information):
macOS High Sierra 10.13.6
docker version:
Client:
 Version:           18.06.0-ce
 API version:       1.38
 Go version:        go1.10.3
 Git commit:        0ffa825
 Built:             Wed Jul 18 19:05:26 2018
 OS/Arch:           darwin/amd64
 Experimental:      false

Server:
 Engine:
  Version:          18.06.0-ce
  API version:      1.38 (minimum version 1.12)
  Go version:       go1.10.3
  Git commit:       0ffa825
  Built:            Wed Jul 18 19:13:46 2018
  OS/Arch:          linux/amd64
  Experimental:     true

ddev version:
db    	drud/ddev-dbserver:v1.1.0
dba   	drud/phpmyadmin:v1.1.0
router	drud/ddev-router:v1.1.0
commit	v1.1.1
domain	ddev.local
cli   	v1.1.1
web   	drud/ddev-webserver:v1.1.0

config.yaml content:
APIVersion: v1.1.1
name: ccp
type: typo3
docroot: web
php_version: "7.2"
router_http_port: "80"
router_https_port: "443"
xdebug_enabled: false
additional_hostnames: []
additional_fqdns: []
provider: default

Just in case to clearify: I'm not seeking advice to fix my database. I just want to completely get rid of the containers and database files of that project.

I can understand how snapshotting after providing --remove-data can lead to unexpected results (given that it's not actually removing all project data). It might be that we need to provide some more explicit flag options surrounding snapshots.
In the meantime, you can remove project data without snapshotting by providing the --omit-snapshot flag.

As Andrew said, using --omit-snapshot solves your immediate problem. If you're interested in helping us by chasing the actual problem, you could review the log, which would help loads.
In the example you quoted, the log is in the db container at /var/log/mariadbackup_backup_ccp_remove_data_snapshot_20180828171834.log so could be
reviewed by ddev ssh -s -db and then inspect that log, possibly with just cat /var/log/mariadbackup_backup_ccp_remove_data_snapshot_20180828171834.log

Closing, hoping this is all good for you at this point, sorry you had trouble. Happy to continue the conversation here or elsewhere.


Optional types ignored

I made some changes to my rules file with 3.0.8 and found that all optional types are ignored by the compiler.
For example I added the optional child source to Comment:
type Comment extends Timestamped {
    ...
    status: String | Null
    source: String | Null
}

Old JSON:
        "status": {
          ".validate": "newData.isString() || newData.val() == null"
        },

New JSON:
        "status": {
          ".validate": "newData.isString()"
        },
        "source": {
          ".validate": "newData.isString()"
        },

I tried a union type and it still works:
type Foo {
  bar: String | Number
}

path /test is Foo {
  read() { true }
}

{
  "rules": {
    "test": {
      ".validate": "newData.hasChildren(['bar'])",
      "bar": {
        ".validate": "newData.isString() || newData.isNumber()"
      },
      "$other": {
        ".validate": "false"
      },
      ".read": "true"
    }
  }
}

But not when I change the second type to Null:
type Foo {
  bar: String | Null
}

path /test is Foo {
  read() { true }
}

{
  "rules": {
    "test": {
      ".validate": "newData.hasChildren()",
      "bar": {
        ".validate": "newData.isString()"
      },
      "$other": {
        ".validate": "false"
      },
      ".read": "true"
    }
  }
}

Isn't that the point of:
".validate": "newData.hasChildren(['bar'])",

vs
".validate": "newData.hasChildren()",

The old behavior was a bug.
That said, the lack of a property listed in hasChildren() is sufficient to allow the field to be deleted when the parent value is written.

If this is the case, should the docs be modified to not recommend defining types as:
path / is Person;

type Person {
  name: String,
  age: Number,
  isMember: Boolean,

  // Optional data (allows an Object or null/missing value).
  extra: Object | Null
}

I am understanding from your comment that this would be equivalent to just writing extra: Object. I was definitely confused for a while about why the former and latter were compiling to the same thing.


Add Webpack tutorial

This could stand some editorial attention :P

@facebook-github-bot import

that's fantastic. Thank you!

Thanks for importing. If you are an FB employee go to Phabricator to review.

@facebook-github-bot shipit


Want New Options: do not delete log files when reach MaxAge but not reach MaxeBackups

settings:
FileName:    "t.log",
MaxAge:      7,
MaxBackups:  3,

my log files:
t-2018-09-03T00-00-00.00.log
t-2018-08-20T00-00-00.00.log

current time:
2018-09-04

I don't want to delete the second log file t-2018-08-20T00-00-00.00.log, because there are not too many files.
If there an option to archive it, it will be nice.

Shouldn't increase MaxAge work for you?

@xiegeo  Yes!


[Refactor] Follow-up for PR 1930

Why are these changes needed?
Follow-up for https://github.com/ray-project/kuberay/pull/1930#pullrequestreview-2044141001
Related issue number
N/A
Checks

[x] I've made sure the tests are passing.
Testing Strategy

[x] Unit tests
[ ] Manual tests
[ ] This PR is not tested :(

Related to #1930


Right click to create new folder/file

Hey there,
this is a question or a feature request.
From a UX/UI perspective, it might be useful to let the user right-click in the file explorer to create files/menus. Like in VSCode. Is it useful to create some sort of this feature?
Cheers and happy new year 🎆

You are thinking of adding a context  menu on the sidebar for New file / Folder ?

You are thinking of adding a context  menu on the sidebar for New file / Folder ?

I agree with you @prikeshsavla :) We just block the normal right-click and then it will open a context menu when you right-click.

I agree with you @prikeshsavla :) We just block the normal right-click and then it will open a context menu when you right-click.

We just block the normal right-click and then it will open a context menu when you right-click.

@FlorianWoelki that sounds good :raised_hands:

We just block the normal right-click and then it will open a context menu when you right-click.

@FlorianWoelki that sounds good :raised_hands:

Beautiful :) If no one else want to work on this, I would tackle this task :)

Beautiful :) If no one else want to work on this, I would tackle this task :)


Chrome Framework exceeds maximum allowed filesize for Google AppEngine

I am trying to deploy to Google AppEngine. I have checked out the code and verified that I am able to run rendertron locally.  However when I try to deploy to GAE using the command
gcloud app deploy app.yaml --project rendertron-test-233009

the deployment fails with the error
ERROR: (gcloud.app.deploy) Cannot upload file [/Users/ashwindate/Documents/git/rendertron/node_modules/puppeteer/.local-chromium/mac-588429/chrome-mac/Chromium.app/Contents/Versions/71.0.3542.0/Chromium Framework.framework/Versions/Current/Chromium Framework], which has size [137191564] (greater than maximum allowed size of [33554432]). Please delete the file or add to the skip_files entry in your application .yaml file and try again.

Weird, I can't reproduce that here - could you try again with the current version of Chromium?


pass mouse button state into HandleMouse

Summary of the Pull Request
TerminalInput::HandleMouse now needs an extra parameter to track the state of the mouse buttons.

ConHost: parameter defined in windowio
Terminal: parameter defined in TermControl --> Terminal

References
#4848 - HandleMouse being moved to TermInput
PR Checklist

[X] Closes #4869

Validation Steps Performed
ran mc in Terminal

I still want to understand..

what if you are scrolling with buttons pressed? then what? :P

does this have to be three booleans? can it be a button mask so we don't back ourselves into a corner for the future point where somebody asks for buttons 4/5/6/7/8 to work properly?

So, the main problem here is IMouseWheelListener.idl. I could introduce a struct there for MouseButtonState that is the same as TerminalInput::MouseButtonState. That still seems wrong to me though so idk. :/

i don't love s_getPressedButton, because it no longer gets a pressed button, it more like "determines the most important button out of the provided button set I think"??

This is working the same as before though. All I did was make it take a parameter for MouseButtonState and read from that. :/


Refactor completion widget and update behaviors.

[x] When there is only one completion match, instead of rendering a completion widget just automatically fill in the value.
[x] Refactor the completion widget to use the IOptions and IRenderer pattern.
[x] Change the behavior of the up and down arrow keys when a completion widget is open: have them cycle through options instead of stopping at the first and last items. (This is, again, closer to what IPython does.)
[x] Switch console's completion to use the CompletionHandler class that the notebook uses to minimize repetition.
[x] Use JSONObject where applicable to use deepEqual checks.
[x] Write unit tests for completion widget, model, and handler.
[x] "Tab should not pick-up a completion." https://github.com/jupyter/jupyterlab/issues/68 To expand: change the behavior of the tab key when a completion widget is open. When every available option has a common initial substring, the tab key will "fill in" the text up to that common substring. Any other tab keydown will select the currently active item.
[x] Peg completion widget's top position to the scroll position of its semantic parent.

Awesome work @afshin, everything functions as advertised.


bundling mozilla root CA store for when there are no default certs

not all machines have system certs such as in busybox containers and so by bundling certs from Mozilla we can fallback to them when system certs are missing

@viega updated to curl the certs on each compile and then using openssl command to validate download is not corrupted/etc and that its a valid PEM file

not sure about grabbing it from curls site. thought to get it from the original link in case curl does any massaging but happy to change. cc @MyNameIsMeerkat @viega thoughts?

not sure about grabbing it from curls site. thought to get it from the original link in case curl does any massaging but happy to change. cc @MyNameIsMeerkat @viega thoughts?

I feel like we are splitting hairs at this point, the salesforce/microsoft link looks weird for sure but is one of the official sources cited by CCADB (https://www.ccadb.org/resources) so I have no concerns using it and would tend to have more trust in that as a source than using curl's website tbh.
Let's just get this done and merged


  It would be clearer to have isWritable and isReadable.

+1

Closing this since we decided to keep the current naming for the time being (in #3491)


[BUG] New-PnPSite: Object reference not set to an instance of an object. (GCC High)

Notice
Many bugs reported are actually related to the PnP Framework which is used behind the scenes. Consider carefully where to report an issue:

Are you using Invoke-PnPSiteTemplate or Get-PnPSiteTemplate? The issue is most likely related to the Provisioning Engine. The Provisioning engine is not located in the PowerShell repo. Please report the issue here: https://github.com/pnp/pnpframework/issues.
Is the issue related to the cmdlet itself, its parameters, the syntax, or do you suspect it is the code of the cmdlet that is causing the issue? Then please continue reporting the issue in this repo.
If you think that the functionality might be related to the underlying libraries that the cmdlet is calling (We realize that might be difficult to determine), please first double check the code of the cmdlet, which can be found here: https://github.com/pnp/powershell/tree/master/src/Commands. If related to the cmdlet, continue reporting the issue here, otherwise report the issue at https://github.com/pnp/pnpframework/issues

Reporting an Issue or Missing Feature
new-pnpsite throws object reference not set to an instance of an object
Expected behavior
new modern team site created
Actual behavior
Create new modern Team Site
Steps to reproduce behavior
Please include complete script or code samples in-line or linked from gists
Connect-PnPOnline -AzureEnvironment USGovernmentHigh  -ClientId 'xxx' -Url 'https://x.sharepoint.us' -CertificatePassword $pass  -Tenant x.onmicrosoft.com -CertificatePath C:\mycertificates\x.pfx
New-PnPSite -Type TeamSite -Title 'Team Contoso' -Alias contoso
New-PnPSite: Object reference not set to an instance of an object.
What is the version of the Cmdlet module you are running?
(you can retrieve this by executing Get-Module -Name "PnP.PowerShell" -ListAvailable)
Manifest   2.0.53     PnP.PowerShell
Which operating system/environment are you running PnP PowerShell on?

[ X] Windows
[ ] Linux
[ ] MacOS
[ ] Azure Cloud Shell
[ ] Azure Functions
[ ] Other : please specify

You also need to set owners for the team site, to do that, please specify value for -Owners parameters, can you please do that, execute and let us know ?

You also need to set owners for the team site, to do that, please specify value for -Owners parameters, can you please do that, execute and let us know ?

Hi,
I kept the example simple from the documentation.

New-PnPSite -Type TeamSite -Title 'Team Contoso' -Alias contoso -Owners @($SiteCollectionAdmin1, $SiteCollectionAdmin2)
New-PnPSite: Object reference not set to an instance of an object.
I added owners parameter with the same issue. My original command is below which also has the same issue.
New-PnPSite -Type TeamSite -Title $NewSiteTitle -Alias $NewSiteAlias -Description $NewSiteDescription -Owners @($SiteCollectionAdmin1, $SiteCollectionAdmin2)

I debugged this a bit more using fiddler. I authenticate in and make my call. The users call is going correctly, but the groups call is going to azure commercial instead of azure gov.

I am also facing the same issue. I have added -Owners as well. I am using ManagedIdentity for authentication in Azure Function. PnPPowerShell Version - 2.1.1 PowerShell: 7.2
Is it correct way to pass owners parameter ? -Owners<EMAIL_ADDRESS>I was able to create of type "TeamSiteWithoutOfficegroup" though.
New-PnPSite -Type TeamSite -Description "Test project site" -PreferredDataLocation "CAN" -Title $siteTitle -Alias "ESU-PRJ-$($requestID)" -SiteAlias "ESU-PRJ-$($requestID)" -TimeZone UTCPLUS0200_HELSINKI_KYIV_RIGA_SOFIA_TALLINN_VILNIUS -Owners<EMAIL_ADDRESS>-Lcid 1033 -Connection $conn -Wait -Classification "HBI"

I am also facing the same issue. I have added -Owners as well. I am using ManagedIdentity for authentication in Azure Function. PnPPowerShell Version - 2.1.1 PowerShell: 7.2
Is it correct way to pass owners parameter ? -Owners<EMAIL_ADDRESS>I was able to create of type "TeamSiteWithoutOfficegroup" though.
New-PnPSite -Type TeamSite -Description "Test project site" -PreferredDataLocation "CAN" -Title siteTitle−Alias"ESU−PRJ−(requestID)"−SiteAlias"ESU−PRJ−($requestID)" -TimeZone UTCPLUS0200_HELSINKI_KYIV_RIGA_SOFIA_TALLINN_VILNIUS -Owners<EMAIL_ADDRESS>-Lcid 1033 -Connection $conn -Wait -Classification "HBI"

ERROR: Object reference not set to an instance of an object. Exception : Type : System.Management.Automation.PSInvalidOperationException ErrorRecord : Exception : Type : System.Management.Automation.ParentContainsErrorRecordException Message : Object reference not set to an instance of an object. HResult : -2146233087 CategoryInfo : InvalidOperation: (:) [], ParentContainsErrorRecordException FullyQualifiedErrorId : InvalidOperation TargetSite : Name : ProcessRecord DeclaringType : PnP.PowerShell.Commands.Base.PnPConnectedCmdlet MemberType : Method Module : PnP.PowerShell.dll Message : Object reference not set to an instance of an object. Source : PnP.PowerShell HResult : -2146233079 StackTrace : at PnP.PowerShell.Commands.Base.PnPConnectedCmdlet.ProcessRecord() in c:\build\src\Commands\Base\PnPConnectedCmdlet.cs:line 98 at PnP.PowerShell.Commands.PnPSharePointCmdlet.ProcessRecord() in c:\build\src\Commands\Base\PnPSharePointCmdlet.cs:line 120 at System.Management.Automation.Cmdlet.DoProcessRecord() at System.Management.Automation.CommandProcessor.ProcessRecord() CategoryInfo : InvalidOperation: (:) [New-PnPSite], PSInvalidOperationException FullyQualifiedErrorId : InvalidOperation,PnP.PowerShell.Commands.NewSite InvocationInfo : MyCommand : New-PnPSite ScriptLineNumber : 27 OffsetInLine : 1 HistoryId : 1 ScriptName : C:\home\site\wwwroot\HttpTrigger1\run.ps1 Line : New-PnPSite -Type TeamSite -Description "Test project site" -PreferredDataLocation "CAN" -Title $siteTitle -Alias "ESU-PRJ-$($requestID)" -SiteAlias "ESU-PRJ-$($requestID)" -TimeZone UTCPLUS0200_HELSINKI_KYIV_RIGA_SOFIA_TALLINN_VILNIUS -Owners<EMAIL_ADDRESS>-Lcid 1033 -Wait -Classification "HBI" -Connection $conn

@gautamdsheth Any potential updates?

hi @jrudley , can you give it a try with the latest build, 2.1.65-nightly or later ? We found some places where we missed passing the correctly URLs.
Unfortunately, we dont have access to USGov tenants, so would be great if you could test it out for us.

Sure, I will test it out today and let you know.
On Fri, Jun 2, 2023, 5:12 AM Gautam Sheth @.***> wrote:

hi @jrudley https://github.com/jrudley , can you give it a try with the
latest build, 2.1.65-nightly or later ? We found some places where we
missed passing the correctly URLs.
Unfortunately, we dont have access to USGov tenants, so would be great if
you could test it out for us.
—
Reply to this email directly, view it on GitHub
https://github.com/pnp/powershell/issues/2948#issuecomment-1573490497,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAOYIS5CAGQZ2JGFEO5DQQ3XJG4CLANCNFSM6AAAAAAWK6XKXI
.
You are receiving this because you were mentioned.Message ID:
@.***>

great news, it works! Thanks again for the fix.
On Fri, Jun 2, 2023 at 6:46 AM James Rudley @.***>
wrote:

Sure, I will test it out today and let you know.
On Fri, Jun 2, 2023, 5:12 AM Gautam Sheth @.***> wrote:

hi @jrudley https://github.com/jrudley , can you give it a try with
the
latest build, 2.1.65-nightly or later ? We found some places where we
missed passing the correctly URLs.
Unfortunately, we dont have access to USGov tenants, so would be great if
you could test it out for us.
—
Reply to this email directly, view it on GitHub
https://github.com/pnp/powershell/issues/2948#issuecomment-1573490497,
or unsubscribe
<
https://github.com/notifications/unsubscribe-auth/AAOYIS5CAGQZ2JGFEO5DQQ3XJG4CLANCNFSM6AAAAAAWK6XKXI
.
You are receiving this because you were mentioned.Message ID:
@.***>

—
Reply to this email directly, view it on GitHub
https://github.com/pnp/powershell/issues/2948#issuecomment-1573604576,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAOYIS72P3HCHOHCCCFZJ4LXJHHADANCNFSM6AAAAAAWK6XKXI
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

Thanks for confirming the fix and raising the issue.
Much appreciated, closing this.

Problem still exists running in VS-Code!
VS-Code
Version: 1.78.2 (system setup)
Commit: b3e4e68a0bc097f0ae7907b217c1119af9e03435
Date: 2023-05-10T14:39:26.248Z
Electron: 22.5.2
Chromium: 108.0.5359.215
Node.js: 16.17.1
V8: <IP_ADDRESS>-electron.0
OS: Windows_NT x64 10.0.22621
Sandboxed: Yes

get-Module PnP.PowerShell
ModuleType Version    PreRelease Name                                ExportedCommands
---------- -------    ---------- ----                                ----------------
Manifest   2.1.69     nightly    PnP.PowerShell                      {Add-PnPAlert, Add-PnPApp, Add-PnPApplicationCustomizer, Add-PnPAvailableSiteClassification…}

$PSVersionTable
Name                           Value
----                           -----
PSVersion                      7.3.4
PSEdition                      Core
GitCommitId                    7.3.4
OS                             Microsoft Windows 10.0.22621
Platform                       Win32NT
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0…}
PSRemotingProtocolVersion      2.3
SerializationVersion           <IP_ADDRESS>
WSManStackVersion              3.0

New-PnPSite -Connection $adminCon -Type "TeamSite" -Title $title -Alias "$($siteUrl)" -Description $description -Owners $siteOwners -Wait

New-PnPSite: C:\Alya\Repos\STHODO-ADM-CloudConfiguration\scripts\sharepoint\Create-Site.ps1:145:17
Line |
 145 |  …     $site = New-PnPSite -Connection $adminCon -Type "TeamSite" -Title …
     |                ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
     | Object reference not set to an instance of an object.

Can you run fiddler and see the calls? I don't have an issue. I am working
with Microsoft on a similar issue but it is using a group to create a
aharepoint site and not pnp.
On Tue, Jun 6, 2023, 9:58 AM Konrad Brunner @.***>
wrote:

Problem still exists running in VS-Code!
VS-Code
Version: 1.78.2 (system setup)
Commit: b3e4e68a0bc097f0ae7907b217c1119af9e03435
Date: 2023-05-10T14:39:26.248Z
Electron: 22.5.2
Chromium: 108.0.5359.215
Node.js: 16.17.1
V8: <IP_ADDRESS>-electron.0
OS: Windows_NT x64 10.0.22621
Sandboxed: Yes
get-Module PnP.PowerShell
ModuleType Version    PreRelease Name                                ExportedCommands

Manifest   2.1.69     nightly    PnP.PowerShell                      {Add-PnPAlert, Add-PnPApp, Add-PnPApplicationCustomizer, Add-PnPAvailableSiteClassification…}
$PSVersionTable
Name                           Value

PSVersion                      7.3.4
PSEdition                      Core
GitCommitId                    7.3.4
OS                             Microsoft Windows 10.0.22621
Platform                       Win32NT
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0…}
PSRemotingProtocolVersion      2.3
SerializationVersion           <IP_ADDRESS>
WSManStackVersion              3.0
New-PnPSite -Connection $adminCon -Type "TeamSite" -Title $title -Alias "$($siteUrl)" -Description $description -Owners $siteOwners -Wait
New-PnPSite: C:\Alya\Repos\STHODO-ADM-CloudConfiguration\scripts\sharepoint\Create-Site.ps1:145:17
Line |
145 |  …     $site = New-PnPSite -Connection $adminCon -Type "TeamSite" -Title …
|                ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
| Object reference not set to an instance of an object.
—
Reply to this email directly, view it on GitHub
https://github.com/pnp/powershell/issues/2948#issuecomment-1578821684,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAOYIS2I2F7GSN7OFR7FX3DXJ4ZRLANCNFSM6AAAAAAWK6XKXI
.
You are receiving this because you were mentioned.Message ID:
@.***>

I see the login request:
$AlyaConnection = Connect-PnPOnline -Url $TenantAdminUrl -ReturnConnection -Interactive

CONNECT tenantname.sharepoint.com:443 HTTP/1.1
Host: tenantname.sharepoint.com:443
User-Agent: NONISV|SharePointPnP|PnPPS/<IP_ADDRESS> (Microsoft Windows NT 10.0.19045.0)

I see the test, if the site exists:
$site = Get-PnPTenantSite -Connection $AlyaConnection  -Url $absSiteUrl -ErrorAction SilentlyContinue

POST https://tenantname.sharepoint.com/_vti_bin/client.svc/ProcessQuery HTTP/1.1
Host: tenantname.sharepoint.com
X-ClientService-ClientTag: PnPPS:2.1:Get-PnPTenantSite
Authorization: Bearer **********
User-Agent: NONISV|SharePointPnP|PnPPS/<IP_ADDRESS> (Microsoft Windows NT 10.0.19045.0)
Connection: Keep-Alive
Accept-Encoding: gzip, deflate
Content-Type: text/xml
Content-Length: 729

May then, NOTHING. The following line does not generate any request:
$site = New-PnPSite -Connection $adminCon -Type "TeamSite" -Title $title -Alias "$($siteUrl)" -Description $description -Owners $siteOwners -Wait

Also running into this same issue in GCC (VSCode and PS 7.4.5), but with a different commandlet:
$Batch = New-PnPBatch foreach($item in $items){      Set-PnPListItem -Identity $item.id -List $List -ContentType "ContentType" -UpdateType SystemUpdate -Values @{"Field 1" = $Value1; "Field 2" = $Value2; "Field 3" = $Value3; "Field 4" = $Value4} -Batch $Batch }
Tried also:
$Batch = New-PnPBatch $items | Foreach-Object{ Set-PnPListItem -List $List -ContentType "ContentType" -UpdateType SystemUpdate -Values @{"Field 1" = $Value1; "Field 2" = $Value2; "Field 3" = $Value3; "Field 4" = $Value4} -Batch $Batch}
And:
$Batch = New-PnPBatch $items | Foreach-Object{ Set-PnPListItem $_.Id -List $List -ContentType "ContentType" -UpdateType SystemUpdate -Values @{"Field 1" = $Value1; "Field 2" = $Value2; "Field 3" = $Value3; "Field 4" = $Value4} -Batch $Batch}
The Set-PnP command works in both without the $Batch.
Potentially the same issue that was fixed in 2.1.65-nightly by @gautamdsheth ?


Extend #61 with tests and docs

A follow-on to #61, this starts tests and documentation for the explicit spec approach. It could be merged back into #61, but I didn't want to start pushing to @mathieu1's master...

This one's looking good... 25s vs 35s isn't much, for this solve, but on windows, with a long environment and a heavy dep like scikit-image, not doing the solve provides a really nice speed-up.

:tada:


[BUG] Cant extend longhorn volume 1.15.3  in k3s v1.27.7+k3s2

cant extend my longhorn volume
hi guys,
i have a small local cluster for local pourpose, there are two debian machines.
i have installed longhorn following official docs.
i've already installed icsi and nfs and running the requirement check script it didn't show me any problem.
persistent volumes works but when i try to extend a volume via pvc i can see on the UI the volume tries to expand without success.
if i do kubectl describe pvc pvcname i see following events:

Normal   Provisioning           2m45s                  driver.longhorn.io_csi-provisioner-65cb5cc4ff-8jx6d_ed2159bc-0ecf-4d42-b6a3-d245ab6bcf43  External provisioner is provisioning volume for claim "default/exserver"
Normal   ExternalProvisioning   2m45s (x2 over 2m45s)  persistentvolume-controller                                                               waiting for a volume to be created, either by external provisioner "driver.longhorn.io" or manually created by system administrator
Normal   ProvisioningSucceeded  2m43s                  driver.longhorn.io_csi-provisioner-65cb5cc4ff-8jx6d_ed2159bc-0ecf-4d42-b6a3-d245ab6bcf43  Successfully provisioned volume pvc-ec6d1386-9be3-4b1d-bc62-e3a9ec088ce8
Warning  ExternalExpanding      2m10s                  volume_expand                                                                             waiting for an external controller to expand this PVC
Warning  VolumeResizeFailed     40s                    external-resizer driver.longhorn.io                                                       resize volume "pvc-ec6d1386-9be3-4b1d-bc62-e3a9ec088ce8" by resizer "driver.longhorn.io" failed: rpc error: code = DeadlineExceeded desc = volume pvc-ec6d1386-9be3-4b1d-bc62-e3a9ec088ce8 expansion from existing capacity<PHONE_NUMBER> to requested capacity<PHONE_NUMBER> failed
Normal   Resizing               39s (x2 over 2m10s)    external-resizer driver.longhorn.io                                                       External resizer is resizing volume pvc-ec6d1386-9be3-4b1d-bc62-e3a9ec088ce8

this is my storage class:

allowVolumeExpansion: true
apiVersion: storage.k8s.io/v1
kind: StorageClass
metadata:
annotations:
longhorn.io/last-applied-configmap: |
kind: StorageClass
apiVersion: storage.k8s.io/v1
metadata:
name: longhorn
annotations:
storageclass.kubernetes.io/is-default-class: "true"
provisioner: driver.longhorn.io
allowVolumeExpansion: true
reclaimPolicy: "Delete"
volumeBindingMode: Immediate
parameters:
numberOfReplicas: "1"
staleReplicaTimeout: "30"
fromBackup: ""
fsType: "xfs"
dataLocality: "disabled"
storageclass.kubernetes.io/is-default-class: "true"
creationTimestamp: "2023-12-15T09:32:19Z"
name: longhorn
resourceVersion: "122323"
uid: 176f9161-0b6c-4756-bef0-a8ff25fdb66a
parameters:
dataLocality: disabled
fromBackup: ""
fsType: xfs
numberOfReplicas: "1"
staleReplicaTimeout: "30"
provisioner: driver.longhorn.io
reclaimPolicy: Delete
volumeBindingMode: Immediate

i've already tried to delete the pod who mount my volume , extend it and recreate the pod but it give me the same issue, it cant extend the volume.
i can extend my volume only if is detached and no pod has ever been connected to it.
please i need your help :(
To Reproduce
-1 install k3s
-2 install longhorn requirement
-3 install longhorn via kubectl
-4 modify configmap/longhorn-storageclass field fsType: ext4 to fsType: xfs
-5 modify configmap/longhorn-storageclass field numberOfReplicas: "3" to numberOfReplicas: "1"
-6 apply the following pvc:

apiVersion: v1
kind: PersistentVolumeClaim
metadata:
name: exserver
spec:
volumeMode: "Filesystem"
accessModes:
- ReadWriteOnce
storageClassName: longhorn
resources:
requests:
storage: 1Gi

-7 apply the following deploy:

apiVersion: apps/v1
kind: Deployment
metadata:
name: exserver
spec:
selector:
matchLabels:
app: exserver
template:
metadata:
labels:
app: exserver
spec:
containers:
- name: nfs-server
image: k8s.gcr.io/volume-nfs:0.8
ports:
- name: nfs
containerPort: 2049
- name: mountd
containerPort: 20048
- name: rpcbind
containerPort: 111
securityContext:
privileged: true
volumeMounts:
- name: storage
mountPath: /exports
volumes:
- name: storage
persistentVolumeClaim:
claimName: exserver

-8 apply the following pvc:

apiVersion: v1
kind: PersistentVolumeClaim
metadata:
name: exserver
spec:
volumeMode: "Filesystem"
accessModes:
- ReadWriteOnce
storageClassName: longhorn
resources:
requests:
storage: 2Gi

Expected behavior
I expect that updating the pvc will increase the volume of the block and filesystem.
Environment

Longhorn version: 1.5.3
Installation method (e.g. Rancher Catalog App/Helm/Kubectl): Kubectl
Kubernetes distro (e.g. RKE/K3s/EKS/OpenShift) and version: K3s

Number of management node in the cluster: 1
Number of worker node in the cluster: 1

Node config

OS type and version: debian 11
Kernel version: 5.10.197-1
CPU per node: 2
RAM per node: 4GB
Memory per node: 20 GB
Disk type(e.g. SSD/NVMe/HDD): HDD

Underlying Infrastructure (e.g. on AWS/GCE, EKS/GKE, VMWare/KVM, Baremetal): Virtual Box VM

Hi @rh363,
Could you provide the support bundle?
Could you show the Longhorn volume and Longhorn engine status by commands?:
kubectl -n longhorn-system get volume pvc-ec6d1386-9be3-4b1d-bc62-e3a9ec088ce8 -oyaml

and
kubectl -n longhorn-system get engine pvc-ec6d1386-9be3-4b1d-bc62-e3a9ec088ce8-e-0 -oyaml

And is there any abnormal log in the longhorn-manager, instance-manager, and csi-plugin pods?

hi @mantissahz,
thank you very much for your answer.

The engine shows

isExpanding: true
size: "10850304"

These will be the conditions that block the expansion process.
cc @shuo-wu

i'm sorry but i dont understand...
the pvc size is 1 GB next i expand it to 2 GB where is my problem?
i'm sorry i'm new to k3s and longhorn system...

Hi @rh363 , could you search the log of the pod longhorn-manager and instance-manager pod for the keyword pvc-4219b930-f322-44de-ac12-44a608ce8ea7 and provide the result here?

@PhanLe1010 i'm sorry i dont know why but now it work, i dont open it for a couple days and know it work...
i cant reproduce this error i'm sorry i cant help developer to patch it...
thanks for your help.


Bootloader jump error

In some situation, bootloader can't jump to actual kernel. (e.g. If shell command "ls" and "cat"  are enable at the same time, it can't jump correctly)
Possible fault : Checksum are different in sender and receiver

I think the reason is that actual kernel is place too close to bootloader. And bootloader's stack pointer is set to beginning of bootloader(0x80000). Both of them increase their memory in opposite direction then they finally overlapping cause crash.


[Bug] VRCX crashes when VRChat is Open on Version 2024.10.25

Description
If VRCX is running when I load up VRChat (through SteamVR), it will crash once the game opens and will not be usable again until I close VRC. This does not occur when SteamVR is running without VRChat. Downgrading to 2024.10.11 seems to avoid this issue upon initial A/B testing.
Steps to Reproduce:

Have an instance of VRCX 2024.10.25 running.
Open SteamVR (and presumably have some sort of headset connected. I did this with and without, both with the same results).
Open VRChat.
When VRChat "fully loads" (i.e. the game screen comes up), VRCX immediately crashes and closes.
Attempts to reopen VRCX result in a window that opens and closes immediately.

Expected behavior
VRCX should be able to stay open and usable when VRChat is running.
What version you are running
2024.10.25 (but 2024.10.11 also exhibits this behavior)

try doing this here, it could be an issue with GPU acceleration https://github.com/vrcx-team/VRCX/issues/971#issuecomment-2453705980

Okay, I retested everything with --disable-gpu in the VRCX.exe shortcut. That seems to have fixed it. Worthy to note that without GPU acceleration disabled, even 2024.10.11 is buggy too. I'm not sure why this suddenly became an issue, as I'm sure it previously worked on this version. Perhaps it's on VRC's side.
I notice that the --disable-gpu flag is not persistent through updates. I'll change the config json instead from here on forward. Thanks!

Added option to revert to how the overlay used to work in Settings -> General -> Disable VR Overlay GPU Acceleration.

I am experiencing this issue even on clean restarts. I'm clueless as to why this is suddenly happening.

I just started it with --disable-gpu in the command line. We'll give it a go. I'd like to note I am on an AMD GPU... is this specific to AMD or is this also happening on nVidia cards?
I would also like to note that VRCX loaded WAYYY faster then normal with --disable-gpu set.

its usually an issue with laptops that use GPU Switching technology such as Nvidia Optimus and AMD Enduro, the exact cause of it is unknown and its not very straight forward to debug for so many machines.

I just started it with --disable-gpu in the command line. We'll give it a go. I'd like to note I am on an AMD GPU... is this specific to AMD or is this also happening on nVidia cards?
I would also like to note that VRCX loaded WAYYY faster then normal with --disable-gpu set.

Also keep in mind that both using --disable-gpu and configuring it directly in the .json file are not persistent. The nightly build introduces the ability to permanently disable GPU acceleration in the settings menu.

I just installed the nightly build. Even with  --disable-gpu set, it is still crashing on the current nightly build.

Try this option Settings -> General -> Disable VR Overlay GPU Acceleration

Try this option Settings -> General -> Disable VR Overlay GPU Acceleration

I just finished trying this option. I am still crashing frequently. I confirmed it was enabled in the settings, restarted with it on... no real change. :/

Could you try disable the SteamVR overlay to see if that's the cause?

Could you try disable the SteamVR overlay to see if that's the cause?

It didn't help at all. I would like to note that I have not run VRChat or SteamVR at all, and this is from a cold boot/reboot (I'm setup for a true cold boot in my Windows settings).

Send us a crashlog from%localappdata%\CrashDumps\

I do not appear to have any crash logs generated from VRCX O_o;

NM, weird. Somehow the "Minimize to tray when closing" option got unticked. I just realized this. I'll monitor to see if that was my issue all along. I have NO idea how this got unticked when I've had it ticked for years.


Dubious require on calendar.lua

The following code chunk gives an error on start:
-- from calendar.lua
local vim = require("vim")

oh... taking a look

Okay, it's fixed, but, why you needed require("vim")?

I got a really annoying local error, there is a fix for that but I've implemented wrongly. Do not remember right now

If you can execute everything properly, maybe it's better to use your LSP "ignore options" to handle these.

yeah, I ended up making some big adjustments to my environment, I must have missed something. overall, can I close issue?

Feel free to close the issue, i'm preparing a PR with a ui date format enhancement.


Debugger: Variable inspection

Problem
Make Noir source code level variables observable via the debugger.
Happy Case
REPL
A command vars should print every the values of every variable in context
VS Code extension
The variables pane of the debugger UI should display every variable in context
Additional Context
Implementation notes
Variable observability will be achieved by adding instrumentation oracles to track variable updates.
Caveats

Updates to variables triggered by interactions with references will not be captured by the instrumentation at the first released version of this feature. While it is achievable, it requires some additional effort to generate the necessary mappings through instrumentation, so we're opting to leave them out of scope to get release an MVP version of the debugger earlier.
Invoking oracles with slices is currently not possible, which means the programs run through the debugger will panic.

Would you like to submit a PR for this Issue?
Yes
Support Needs
No response

Implemented by #4122


More React synchronization fix

Background
In streetscape.gl, viewState and React children (DOM labels) are changed at the same time. In the current implementation, child components are updated before the Deck viewports, resulting in flashing of label positions.
Change List

When both children and views are changed, defer React rerender to the next animation frame.

Coverage decreased (-0.02%) to 62.294% when pulling 25efcbf078554a3bcce686c9591c2be3d17a8b8c on x/react-synchronization-fix into b7fa2b0954a7c49a6757f9036952a2548e77ef49 on master.


Updated acknowledgements file to change old username

I recently moved from @Jammy4312 to @JamesMCo, and this commit fixes that in the acknowledgements file

Coverage remained the same at 99.844% when pulling 19c13c213021db5933376945e0a28823e3b3b8f7 on JamesMCo:develop into<PHONE_NUMBER>f899fe2c97790099f2592c12c9978a on timothycrosley:develop.


[wip] add support for CPU sockets and threads

What this PR does / why we need it:
Add support for CPU sockets and threads
The performance team identified an issue with how we define CPUs for VMs. They were getting significantly better performance when configuring virtual CPUs as sockets (vs. the current method of specifying cores) - https://bugzilla.redhat.com/show_bug.cgi?id=1653453. This PR allows user to specify socket and threads in vm.
This patch changes the way how cores are calculated. Previously cpu topology had just 1 socket, 1 thread and n cores. Now cpu topology can have n cores, threads and sockets. If none of cores, threads and sockets are defined in Spec.Domain.CPU, virt-launcher looks into Spec.Domain.Resources.Requests and Spec.Domain.Resources.Limits for k8sv1.ResourceCPU and sets this value into sockets (because sockets have better performance than cores). Calculation of vcpu is changed to sockets*cores*threads.
@MarSik, @fromanirh, @yanirq, @petrkotas, @rmohr please review
Release note:
Add support for CPU sockets and threads

Hello contributor, thanks for submitting a PR for this project!
I am the bot who triggers "standard-CI" builds for this project.
As a security measure, I will not run automated tests on PRs that are not from white-listed contributors.
In order to allow automated tests to run, please ask one of the project maintainers to review the code and then do one of the following:

Type ci test please on this PR to trigger automated tests for it.
Type ci add to whitelist on this PR to trigger automated tests for it and also add you to the contributor white-list so that your future PRs will be tested automatically.
If you are planning to contribute to more than one project, maybe it's better to ask them to add you to the project organization, so you'll be able to run tests for all the organization's projects.

@ksimon1 thanks for the pr.
Please add a little bit more context to the PR description to tell a reviewer on the high-level what you are changing.

@fabiand We need to be able to specify all sockets, cores and threads for windows cases. The licensing there might limit the number of sockets you are allowed to utilize.
The patch here could just map cores to sockets, but it would be confusing (and breaking the API again) once we change that again to support sockets again in a separate PR. We have unique opportunity to break the API together with everything else we did in 1.4 and not break it again in the future.

@fabiand We need to be able to specify all sockets, cores and threads for windows cases. The licensing there might limit the number of sockets you are allowed to utilize.

That's what I proposed. Extend the API to let a user specify cores and sockets (threads for completeness as well I guess (this referes to (1) above).

The patch here could just map cores to sockets, but it would be confusing (and breaking the API again) once we change that again to support full topology in a separate PR. We have unique opportunity to break the API together with everything else we did in 1.4 and not break it again in the future.

I'm not suggesting to map cores to sockets or vice-versa. I'm suggesting to expose a public API where a cuser can specify sockets, cores and threads.
1.4 seems to be a non-KubeVirt version number

Moreover, adding support for topology means you have to touch all the places you mentioned and there is no way around that. So the additional PR wouĺd look the same as this one again.

I'm not sure how topology would help here.
My point in general is: We know that we should be able to specifc sockets (and cores). Thus let's change the API to specify both of them (and threads becuase it's just one more item).
The other part is that we know that when vcpus are specified, that they should increase sockets instead of cores (as it's done right now).
I'm also recommending to keep it simple, as I heared that there are requests to backport this performance sensitive patch to a stable branch. For this, smaller and well understood patches are better.
I'm proposing to do these ismple changes right now, and any adiditonal work as follow up.

ci test please

@petrkotas, @vladikr, @fabiand, @rmohr please can you review this?


Issue 763

tests/unit/components/sl-modal-header-test.js, line 13 [r2] (raw file):
Change tabName to tagName.

Comments from the review on Reviewable.io

sl-modal-header also accepts title as a parameter, but it is not currently set to a default value in the sl-modal-header component. I have opened an issue for it https://github.com/softlayer/sl-ember-components/issues/931

Comments from the review on Reviewable.io

tests/unit/components/sl-modal-header-test.js, line 13 [r2] (raw file):
doh! thanks

Comments from the review on Reviewable.io

Reviewed 1 of 1 files at r3.
Review status: all files reviewed at latest revision, 1 unresolved discussion, all commit checks successful.

Comments from the review on Reviewable.io


Upgrade Node 16 to Node 20

Upgrade the action to use Node 20 instead of Node 16.
Migrate from @zeit/ncc to @vercel/ncc package because the former has been out of maintenance for 3 years and a transition to the latter is recommended. Change done here because @zeit/ncc doesn't provide support for Node 20.

Fixes gh-299

Thanks for the PR, @ThomasVitale!
I see the build is failing. I have a hunch this is unrelated and I'll check this now.
I also note that for Enterprise users with self-hosted runners, Node 20 support was only added in August (https://github.com/actions/runner/releases/tag/v2.308.0) so I suspect this may be a breaking change for some. I think when we merge this the next build should be called v2. No action required in this PR, but just a reminder to myself (and an FYI to others).

@ThomasVitale : Could you do me a favor to fix the build? Either merge, cherry-pick or copy and paste the changes from https://github.com/carvel-dev/setup-action/pull/301 onto your branch?
This PR needs that fix to pass, but my PR also needs the fixes to dependencies to pass. Between them they should do the job.

@jbrunton thanks for the review. Since my branch is in a fork, I couldn't cherry-pick your commit fixing the tests, so I copied the fix. I hope that's ok.
I agree about bumping the major version for the new release since it could be a breaking change.

@ThomasVitale : thank you, that all looks good. I'll merge this and create a new version.


FR: Add summary hardware infos on devices

Is it possible to push summary CPU/RAM/DISK on custom field on "devices" like netbox-sync do on VirtualMachines
Thanks
NB : refers to this discussion : https://github.com/bb-Ricardo/netbox-sync/discussions/189#discussioncomment-2746471

thank you

CPU and RAM have been added. Disk is not exposed via VMWare API.


pull request for the changes for issue #358

thanks.
2 comments on workflow:

please resolve the conflicts above. you need to merge the current devel branch into your improve-BLA branch and fix them there, then commit the result.
i.e. on your machine change to the devel branch, do git pull. then change to this branch, do git pull; git merge devel and fix the conflicts manually. then do git push.
in the future, make sure to create a branch from an up-to-date version of the devel branch and periodically merge devel into your own branch to avoid this kind of problem.

this PR now includes files and modifications for issues/PRs #358, #283, #318  and #196, AFAICT. Do avoid stuff like that in the future, please, and create separate PRs for separate issues and topics. Too late/complicated for you to change this now, I will repair this myself once you've done the other stuff.

1 comment on content:

in the regression tree picture, please put the horizontal lines at the height of the mean of the respective y-values, for example the left most one is way too high, the one in the middle seems too low. Also the labels don't match the graph -- e.g. the label for the right most segment is -0.01, but the plotted value of the horizontal line is more like +0.1 etc.  Sorry, I overlooked this earlier because I had assumed you read my earlier comment requesting this change.


Unable to import CrossQuantilogram as cq

import pandas as mypf
import numpy as mynp
import matplotlib.pyplot as myplot
import CrossQuantilogram as cq
ModuleNotFoundError                       Traceback (most recent call last)
C:\Users\ECONOM~1\AppData\Local\Temp/ipykernel_7860/1289324908.py in
2 import numpy as mynp
3 import matplotlib.pyplot as myplot
----> 4 import CrossQuantilogram as cq
ModuleNotFoundError: No module named 'CrossQuantilogram'

I have been trying to import the package but in vain. Kindly suggest. thanks.


Allow optparse-applicative 0.14

It builds and works fine here.

Cool, for a test I added - optparse-applicative-<IP_ADDRESS> to stack.yaml and that built and ran fine as well. So looks good to me!


Exchange JSON with CBOR serialization does not work as intended

If I replace the Json serialisation with CBOR within my own implementation, the following error message occurs:
error[E0277]: the trait bound `yew::format::Cbor<std::result::Result<shared::WsMessage, failure::Error>>: std::convert::From<std::result::Result<std::string::String, failure::Error>>` is not satisfied
  --> src/frontend/login.rs:39:31
   |
39 |         let task = ws_service.connect(API_URL, callback, notification);
   |                               ^^^^^^^ the trait `std::convert::From<std::result::Result<std::string::String, failure::Error>>` is not implemented for `yew::format::Cbor<std::result::Result<shared::WsMessage, failure::Error>>`
   |
   = help: the following implementations were found:
             <yew::format::Cbor<std::result::Result<T, failure::Error>> as std::convert::From<std::result::Result<std::vec::Vec<u8>, failure::Error>>>

In my intention there is a missing trait implementation here. I think the implementation in websocket.rs could be a bit problematic when using other serialisers than json:
        ws.add_event_listener(move |event: SocketMessageEvent| {
            if let Some(bytes) = event.data().into_array_buffer() {
                let bytes: Vec<u8> = bytes.into();
                let data = Ok(bytes);
                let out = OUT::from(data);
                callback.emit(out);
            } else if let Some(text) = event.data().into_text() {
                let data = Ok(text);
                let out = OUT::from(data);
                callback.emit(out);
            }
        });

Indeed the From<Text> trait dependency is the main problem here. Would it be okay to stick to binary transmit or make a feature out of it?

you can look at my fork untill its not merged, ive implemented a quick workaround for this

Let's track this with https://github.com/yewstack/yew/issues/279

Wrong issue link? Shouldn't it be #389 ?

Yes, thanks!


Automatically detect correct pyflamegpu wheel to download

In the past few months Google Collab has updated the Python version twice, in both cases breaking the pyflamegpu install.
Would be nice if wheel selection could be automated.
https://github.com/FLAMEGPU/FLAMEGPU2/issues/953
https://github.com/FLAMEGPU/FLAMEGPU2/issues/1005

Also see #2 / this is almost a duplicate.

The python side of things is now resovled via the wheel house, but the CUDA side of things is not.


feat(collection): add some useful methods & fixes

Rewritten random() method, now it works 1.4 times faster

sorry, we can't accept this PR. it changes too many different things, you are bound to split it into several different prs. there are too many oddities in this PR, such as hasValue(), which is instead of the standard Map.has uses a loop across the entire collection, which is horribly unproductive. or getKeys(), getValues() - why do this? what is the meaning of these methods? isn't it possible for a developer to call [ ...collection.values() ] independently? and also you broke the equal method. lodashIsEqual method this is optional, and you use this as if it is always exists.


Added support of auto recalculation of assemblies price

In some cases store owner want apply one pricing formula for all assemblies. In such cases it's convenient to set the price of the assemblies automatically, instead of having to manually set the price of each assembly.
This patch is also available for 2-0-stable & 1-2-stable, see corresponding branches in my fork.

@romul Take control ;)

This is stale, still relevant? I'd like to clean this repo up. Thanks!


memoize caching the python object, not the JSON serialization

I am very interested by the memoize capacity yet by going through the code, I see it is not caching the JSONResponse but the object before its serialization.
As the JSON serialiaztion is quite expensive in my case (hourly data on a year with multiple traces => lot of datetime JSON serialisation), it is still very slow.
Would it be feasible to cache the final response (JSON) instead of the intermediate Figure object ?

If the JSON serialization is in fact expensive, i guess it would make sense to cache the JSON string rather than the object. That being said, i haven't encountered any real life examples where the JSON serialization itself was a performance bottleneck. Are you sure that's the case? How have you measured it?

I have measured the time for the callback to return (with a timing
decorator) and the time for the request (with a
before_request/after_request timing).
When cached, the first time is close to zero but the second is around
4seconds, time that I also see in the browser dev tool.
On Tue, Sep 15, 2020, 11:21 Emil Haldrup Eriksen<EMAIL_ADDRESS>wrote:

If the JSON serialization is in fact expensive, i guess it would make
sense to cache the JSON string rather than the object. That being said, i
haven't encountered any real life examples where the JSON serialization
itself was a performance bottleneck. Are you sure that's the case? How have
you measured it?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/thedirtyfew/dash-extensions/issues/16#issuecomment-692588081,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAJ6S5RSWIODQQHWG5ZGYBLSF4WXZANCNFSM4RMXBPKA
.

To check the json serializaton time, i would suggest measuring it directly in the callback, i.e. something like
import json
import datetime

obj = {}
tic = datetime.datetime.now()
json_string = json.dumps(obj)
toc = datetime.datetime.now()
print(f"TIME TO SERIALIZE = {(toc-tic).total_seconds()}")

where obj is the figure in question. As you measure it now, i guess that the data transfer time is included?

The timing probably includes the transfer time but it is on localhost. Do
you think it can be significant?
I will time tomorrow the json serialization as you suggest.
On Tue, Sep 15, 2020, 12:36 Emil Haldrup Eriksen<EMAIL_ADDRESS>wrote:

To check the json serializaton time, i would suggest measuring it directly
in the callback, i.e. something like
import json
import datetime
obj = {}
tic = datetime.datetime.now()
json_string = json.dumps(obj)
toc = datetime.datetime.now()
print(f"TIME TO SERIALIZE = {(toc-tic).total_seconds()}")
where obj is the figure in question. As you measure it now, i guess that
the data transfer time is included?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/thedirtyfew/dash-extensions/issues/16#issuecomment-692629606,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAJ6S5VOZPPWYXRLN7BGVADSF47SPANCNFSM4RMXBPKA
.

Yes, in most cases (as per my experience), it takes much longer than the serialization itself.

I have done some measurements by adding time logs around the figure
generation itself, around the whole callback and around the json.dumps in
Dash callback wrapper:
--------    'figure generation' started
********    'figure generation' ran in 3.912 seconds
func:'update_output_div_grid_graph' took: 4.3776 sec
--------    'dumping response' started
********    'dumping response' ran in 2.704 seconds
duration of request /_dash-update-component = 7.1836 s
So, my callback takes 4.3s (of which 3.9s generating the plotly figure).
Serialiazing to JSON takes 2.7s
Total request is 7.2s
Transfer time = 7.2-2.7-4.3=0.2s       (447kb compressed, 2.6M uncompressed)
without memoization => 7.2s
With the current memoize behavior, I save on the 4.3s of my callback but
still have the json & the transfer => 2.7+0.2 = 2.9s
If the memoization could be done after the JSON serialisation => 0.2s
On Tue, Sep 15, 2020 at 9:55 PM Emil Haldrup Eriksen <
<EMAIL_ADDRESS>wrote:

Yes, in most cases (as per my experience), it takes much longer than the
serialization itself.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/thedirtyfew/dash-extensions/issues/16#issuecomment-692944355,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAJ6S5XEWEMGU44JL523G4DSF7BCBANCNFSM4RMXBPKA
.

Wow, that is slow for the serialization! To do the serialization before caching, I guess you could just return the serialized figure, i.e call json.dumps on the figure object.

I have tried to return the jsonified figure but then Dash will see a string
and jsonify again the string which the react component do not like
On Wed, Sep 16, 2020, 11:50 Emil Haldrup Eriksen<EMAIL_ADDRESS>wrote:

Wow, that is slow for the serialization! To do the serialization before
caching, I guess you could just return the serialized figure, i.e call
json.dumps on the figure object?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/thedirtyfew/dash-extensions/issues/16#issuecomment-693299151,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAJ6S5TNHBOJXLNITCJHTD3SGCC77ANCNFSM4RMXBPKA
.

The slowness of the serialization is maybe due to the fact that there are 9
traces, built from dataframes at an hourly level on a full year (index=8760
datetimes that are serialised to json 9 times)
On Wed, Sep 16, 2020, 11:50 Emil Haldrup Eriksen<EMAIL_ADDRESS>wrote:

Wow, that is slow for the serialization! To do the serialization before
caching, I guess you could just return the serialized figure, i.e call
json.dumps on the figure object?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/thedirtyfew/dash-extensions/issues/16#issuecomment-693299151,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAJ6S5TNHBOJXLNITCJHTD3SGCC77ANCNFSM4RMXBPKA
.

ok, I have noticed two points that takes time:

serializing the dataframe datetimeindex ==> I convert the index to string in the original dataframe before creating the figure
plotly json conversion (vs the standard one) ==> it takes for instance 0.28s instead of 0.08s to dumps via plotly instead of the std json package ==> I do a fig = json.loads(json.dumps(fig, cls=plotly.utils.PlotlyJSONEncoder)) within the callback (a bit like what you suggested) and I save 0.2s
With these two hacks, it is now much more responsive when memoize.
Maybe the last hack could integrate dash-extensions as an option for the memoize argument with True (current behavior for memoization), False (no memoization), "prejson" (prejsonify before returning)

Haha, that’s a nice hack 👍

for the record, I "integrated" it in dash_extensions by adding after https://github.com/thedirtyfew/dash-extensions/blob/master/dash_extensions/enrich.py#L393 the following;
            if memoize == "prejson":
                data = json.loads(json.dumps(data, cls=plotly.utils.PlotlyJSONEncoder))

Now, if I use @app.callback(..., memoize="prejson"), it will memoize after applying the JSON dump/load hack.
Do you think it can be integrated in the package (to avoid me "monkey patching" your package in my project) ?

Jep. Could you provide a small self contained example of the usage?

Here is an example where you can "refresh" a graph with the three memoize modes (True, False, "prejson"). You need to have patched your code as explained hereabove to have the "prejson" working.
What is interesting to notice (and for this you need to add some with Timer("..."): lines in your code) is that, once the figure has been converted to pure JSON (with the plotly dumps followed by the loads), it is also much faster to pickle (the timing of line https://github.com/thedirtyfew/dash-extensions/blob/master/dash_extensions/enrich.py#L387 is oing from 0.62s to 0.01s) even through if the pickled file is larger (probably because there is no more sharing of common objects).
So I am even wondering if the "prejson" mode should not be the default mode.
import functools
import time
from threading import get_ident

import dash_bootstrap_components as dbc
import dash_core_components as dcc
import dash_html_components as html
import numpy
import pandas
from dash_extensions.enrich import Dash, Output, Trigger
from flask import g, request

from dash_utils import px_area

class Timer:
    def __init__(self, desc_or_function="anonymous code block"):
        if isinstance(desc_or_function, str):
            # called as context
            self.description = desc_or_function
        else:
            # called as decorator
            self.description = desc_or_function.__name__
            self.obj = desc_or_function
            functools.update_wrapper(self, desc_or_function)
        self.log = print

    def __enter__(self):
        self.start = time.perf_counter()
        return self

    def __exit__(self, *args):
        self.end = time.perf_counter()
        self.interval = self.end - self.start
        self.log(f"Thread: '{get_ident()}'   '{self.description}' ran in {round(self.interval, 3)} seconds")

    def __call__(self, *args, **kwargs):
        # decorator call
        with Timer(self.description):
            return self.obj(*args, **kwargs)

df = pandas.DataFrame(
    index=pandas.date_range("2020-01", "2021-01", freq="H", closed="left", tz="CET"),
    columns=list("ABCDEFGHIJK"),
    data=pandas.np.nan,
)
df[:] = numpy.random.random(df.values.shape)

app = Dash(__name__)

memoize_modes = [True, "prejson", False, ]

app.layout = dbc.Container(
    [
        dbc.Row(
            [
                dbc.Col(
                    [
                        html.Button(id=f"trigger-{mode}", children=f"Refresh {mode}"),
                        dcc.Graph(id=f"my-graph-{mode}"),
                    ],
                    className="col-4",
                )
                for mode in memoize_modes
            ]
        )
    ]
)
for mode in memoize_modes:
    @app.callback(
        Output(component_id=f"my-graph-{mode}", component_property="figure"),
        Trigger(component_id=f"trigger-{mode}", component_property="n_clicks"),
        memoize=mode,
    )
    @Timer
    def update_graph():
        with Timer("figure generation"):
            fig = px_area(df)
        return fig

@app.server.before_request
def before_request():
    if request.path != "/_reload-hash":
        g.timer = Timer(request.path).__enter__()

@app.server.teardown_request
def teardown_request(exception=None):
    if request.path != "/_reload-hash":
        g.timer.__exit__()

if __name__ == "__main__":
    app.run_server(debug=True)

Could you add the px_area also? I just tried with simple scatter plots, but they render pretty fast

I just did a few test, and the speed up is indeed remarkable! It just made a build with the new feature,
https://pypi.org/project/dash-extensions/0.0.32rc6/
In this build i am using the syntax that you can pass function handles via the memoize keyword. Here is a small example,
import itertools
import dash_core_components as dcc
import dash_html_components as html
import plotly.graph_objs as go
import pandas as pd
import numpy as np

from dash_extensions.enrich import Dash, Output, Trigger, plotly_jsonify

def make_figure():
    fig = go.Figure()
    for col in df.columns:
        fig.add_trace(go.Scatter(x=df.index, y=df[col]))
    return fig

def make_layout(tag):
    return [dcc.Graph(id=f"graph_{tag}"), html.Button(f"Update [{tag}]", id=f"btn_{tag}")]

tags = ["default", "memoize", "prejson"]
memoize = dict(default=None, memoize=True, prejson=plotly_jsonify)
# Create dummy data.
df = pd.DataFrame(index=pd.date_range("2020-01", "2021-01", freq="H"), columns=list("ABCDEFGHIJK"), data=pd.np.nan)
df[:] = np.random.random(df.values.shape)
# Create example app.
app = Dash(prevent_initial_callbacks=True)
app.layout = html.Div(list(itertools.chain.from_iterable([make_layout(tag) for tag in tags])))
# Attach callbacks.
for t in tags:
    app.callback(Output(f"graph_{t}", "figure"), Trigger(f"btn_{t}", "n_clicks"), memoize=memoize[t])(make_figure)

if __name__ == '__main__':
    app.run_server(port=8877, debug=True)

Let me know if this syntax is OK for your use case. I am still open to suggestions :)

I do not see the code on the repo yet, could you push it on a branch ?
For the syntax, I understand that you want to be able to provide:

None => as False before
True => as True before (memoize the output of the callback without any postprocessing)
a function => as True but where the output of the callback is passed to the function to get back the object to memoize
Is that correct ?
If so, the function ability may appear to be bring some ability to be flexible but I wonder if in this case it is not "premature generalisation". The user will never guess by himself that it can pass plotly_jsonify to get an improvement in speed.
I would rather have as possible values for memoize:
True/"jsonify" => optimised behavior with the plotly_jsonify
False/None/"none" => no memoization (=default)
"raw" => memoize without the plotly_jsonify
(ie keep strings or plain bool/None as parameters with a good docstring, like in the pandas lib)

But I may have misunderstood the syntax

I pushed it to a new branch yes,
https://github.com/thedirtyfew/dash-extensions/tree/prejson
The concept is like you note for [None/false, True, and function]. Hence to get the behavior you need, you would should pass memoize=plotly_jsonify. Setting memoize="raw" would also work, since "raw" would evaluate to True in a boolean conversion. I figured this syntax would accommodate if anyone needs a different pre processing (prior to caching), whatever that might be.

I would rather adapt the syntax:

True/"jsonify" => optimised behavior with the plotly_jsonify
False/None/"none" => no memoization (=default)
"raw" => memoize without the plotly_jsonify

And so:

not add possibility for generic functions (not useful today, more complex for beginners, better to get to know new use cases that would need other preprocessing function via a github issue ;-) ... Otherwise you will not be aware of people using other inventive preprocessing functions like me)
when True (the basic use of memoize), use the plotly_jsonify preprocessing, i.e. automatically enable the optimization
consider "raw" as memoize but without any preprocessing (i.e. today behavior when giving True)

But it is also a matter of taste, so feel free to choose the one that makes the more sense

hello @emilhe
any news regarding this MR? tell me if I can be of any help!

No, sorry, i have been caught up in with other projects :)
As i understand, the performance gain you have experienced is specific to (specific) plotly objects (e.g. graphs). And since a dash component can be anything, i am not a big fan of adopting the plotly-serialize-deserialize approach per default. In some some cases it will lower performance, and if the object(s) are not serializeable, it might event break existing apps.
Personally, i don't really see the big different between passing a (pre defined) function handle or a string (assuming both are mentioned in the docstring), but i don't see any issue in the string approach either.
Haha, i like the argument on why not to allow generic preprocessing functions :P. But in general i really like it when other people make their libraries flexible (like the option to add generic pre processing) so that i can adopt to my use case immediately and get going rather than having to file an issue and wait for a patch.
So, at the moment, i am leaning towards,

Keeping the default behavior for "True" (which will also ensure backwards compability)
Adding string options for the predefined functions, which will just be the string "plotly_jsonify" for now
Keeping the option to pass in function handles (if people don't understand it, they can just avoid using it)

@emilhe shouldn't this issue be closed?
You did implement the feature right?

Yes! I finally got it merged into master yesterday. It's thus available in the 0.0.32 release, and a small example can be found here,
https://github.com/thedirtyfew/dash-extensions/blob/master/examples/callback_prejson.py
I am still amazed of the performance difference. On my current laptop, the default memoize takes 1.5s to update, but only 300 ms with the prejson option. That's 5X faster (:

You also may look at https://community.plotly.com/t/speeding-up-plotting-large-timeseries-x5/47638
I have added some extra speedups vs what I have posted that accelerates even more. I will share them later


was something wrong

was something wrong

Multiple new issues containing spam; that's wrong. https://github.com/NixOS/nixpkgs/issues?utf8=✓&q=author:mrsshahinda

@edolstra: I suggest blocking this one from NixOS org. on GitHub.

@vcunat Done.


Added support for OpenJDK 11, in Ubuntu 16.04 Xenial and Ubuntu 18.04 Bionic

Description of the Change
Added support for OpenJDK 11, in Ubuntu 16.04 Xenial and Ubuntu 18.04 Bionic
Benefits
Added support for OpenJDK 11, in Ubuntu 16.04 Xenial and Ubuntu 18.04 Bionic
Possible Drawbacks
None
Applicable Issues
None

I was able to resolve everything :) This PR includes:

added support for OpenJDK 11
allow setting specific java_open_jdk_package, allowing JRE vs. JDK
add support for Ubuntu 18.04, Ubuntu 16.04
added specific OS, and OS version, testing in Molecule


Add Odin as 3rd party language

Changes

Added 3rd party odin language grammar to Supported Languages.

Checklist

[ ] Added markup tests, or they don't apply here because they are in the repo of the language
[x] Updated the changelog at CHANGES.md

Thanks so much!


Ignore .pdm-build when searching for projects

pdm backend creates pyproject.toml files here when building wheels, so
they do occur sometimes in rye projects that use pdm backend.
I don't know if changelog updates in PRs are wanted or not, it might cause merge conflicts but here's a try.

At this point, why do we not just skip recursing into dot prefixed folders to begin with? I think this will otherwise turn into a game of whack-a-mole.

I've updated it to do that.


fix: fix takePhoto not working inside an Modal

What
When the camera view is inside of Modal they dont take photo, throws [system/view-not-found].
Changes
Changed way how Camera view is resolved.
We utilize the global React Native View registry to resolve the view instance.
Tested on
Android 10 emulator
Android 10 device
Related issues

We now probably need to call findCameraView using withContext to ensure it's being called from Main/UI Thread.

We now probably need to call findCameraView using withContext to ensure it's being called from Main/UI Thread.

OK, but... Who to do this? LOL

Wow nice that did fixed the takePhoto, I just tested it  👍

@mrousavy Can you help-me in your change request?

I met same problem and fixed with this PR. thanks!
Here is patch file for patch-package
react-native-vision-camera+2.13.3.patch

@mrousavy Can u see this PR? <3

Oh I'm sorry I missed this! It somewhere got swallowed by thousands of other emails 😅
LGTM, thank you so much for your help here!

@mrousavy publish this fix please

is this published? I'm still facing this issue.


www.rdocumentation.org stuck at Feb 22

https://www.rdocumentation.org/trends
is stuck at Feb 22
Newest packages
RcppBlaze	Wed Feb 22 2017 14:13:09

Did something change?

Thanks for reporting, something seems broken on our end, we'll look into it ASAP

The crawler has been restarted, new packages should be indexed gradually


0.8.0 active tab text font on Android

Hi, I have set tabBarTextStyle so that the text font changes.
tabBarTextStyle={{fontFamily: 'Comfortaa'}}
IOS seems to work fine, but on Android, the active tab text style changes back to its default text style.

+1

I think I have found an answer, try to add a fontWeight to tabBarTextStyle


Chords are not supported in the ABC

This is a side-effect of choosing MongoDB and thus a JSON representation of the tune.  JSON doesn't support unescaped embedded strings making the translation in and out of Mongo awkward.   Chords in ABC are represented simply by the chord name wrapped in double quotes.
This is also partly a design decision because chords sound terrible in all ABC players that I've ever heard. However, a nicer approach would have been to accept chords in the ABC and just ignore them in any player.

If we wanted to sort this out, it seems to me we would need to escape strings in the ABC body within the AbcSubmission class.

This is now becoming more of an issue because we have started to introduce better support for chord symbols in the front end.  Even so, it seems that this will be difficult to resolve with MongoDB and may have to be left to the Haskell re-write which uses a conventional relational database.


Upstream Kafka TLS hostname verification

Type of change

Enhancement / new feature

Description
Enable SSL hostname verification.
Additional Context
Netty 4.2 enables HTTPS style hostname validation by default as its more secure (see https://github.com/netty/netty/pull/14127).  However, the APIs exist in the 4.1, so we can enable them earlier. This PR is to start the discussion if we want to apply this independent of what or when we decide to use netty 4.2
Checklist
Please go through this checklist and make sure all applicable tasks have been done

[ ] Write tests
[ ] Make sure all tests pass
[ ] Review performance test results. Ensure that any degradations to performance numbers are understood and justified.
[ ] Make sure all Sonarcloud warnings are addressed or are justifiably ignored.
[ ] Update documentation
[ ] Reference relevant issue(s) and close them after merging
[ ] For user facing changes, update CHANGELOG.md (remember to include changes affecting the API of the test artefacts too).

@strimzi-ci run system tests

I'd strongly advocate for 11a76eb1d71782e6cd54dcc4901b6a1277b8a4f9.  I'd argue that introducing shades of insecure TLS is a dangerous antipattern.   For TLS to be secure you need both hostname verification and certificate trust.    Take either of those away and you have zilch - a insecure system.

@strimzi-ci run system tests

:arrow_forward: Build started - check Jenkins for more info. :arrow_forward:

:heavy_exclamation_mark: System tests Failed (no tests results are present) :heavy_exclamation_mark:

@strimzi-ci run system tests

:arrow_forward: Build started - check Jenkins for more info. :arrow_forward:

:heavy_check_mark: Test Summary :heavy_check_mark:
BUILD NUMBER: 105
KAFKA VERSION: 3.7.1
TOTAL: 27
PASS: 21
FAIL: 0
SKIP: 6

@strimzi-ci run system tests

:arrow_forward: Build started - check Jenkins for more info. :arrow_forward:


Sum type encoder in the README

I think it would be super useful to show in the readme how to make a schema for a sum type like e.g. data Color = Black | White that doesn't use DeriveGeneric. I imagine there must be an analogue of requiredField that takes a deserializer like HasSchema a => Text -> Either DeserializerErrorString a.
The readme currently shows how to product types, but it doesn't show sum types, which are also super important in Haskell.

If they're enums, there's a function for that.
If they're not, you use something like eitherCodec.
The complexity has something to do with a codec being 3 directional: encoding, decoding, and documenting.
PR welcome.

Sum types have been documented now, https://hackage.haskell.org/package/autodocodec-<IP_ADDRESS>/docs/Autodocodec.html#g:14


Include pinned dependency versions in dependency report

Similar to Python, include a section in the report that shows the dependency versions that we have pinned in the parent POM, and highlight places where libraries override those versions.

Can't link the PR directly, but it's JonathanGiles/DependencyChecker#3


SteamVR_Skybox.SetOverride() makes VRAM leak!

Because I have to change to SteamVR Skybox according to my game logic when scene loaing,
but I found there is VRAM leaking when I call SteamVR_Skybox.SetOverride().
My SteamVR version is<PHONE_NUMBER>
Here is the simple project to reproduce the problem
https://drive.google.com/file/d/1EUbL6LPvxGVxilwQwi0Bf74i_uOXxlRB/view?usp=sharing
Reproduce

Open project
Open Assets/Scenes/SteamVR_SkyboxTest
Press key "A" to call SteamVR_Skybox.SetOverride
See Dedicated GPU memory of vrcompositor.exe in [Task Manager] -> [Details]
Press key "A" again
Dedicated GPU memory of vrcompositor.exe is increasing
PS. Press key "C" to call SteamVR_Skybox.ClearOverride() dose not help to decrease the GPU memory.
If Press "A" again the VRAM will reach a new high!

If I have any wrong, feel free to let me know, Thanks.

Pretty sure this has been fixed. If not please create a new issue with repro steps and ideally an example project. Thanks!


subsystems: add smb2 definition

Is your feature request related to a problem? Please describe.
We can simplify smb2 coverage tracking defining one more subsystem.
#5524 is expected to improve coverage there.

The coverage is available at https://syzkaller.appspot.com/upstream/graph/coverage_heatmap?period=month&subsystem=cifs .
It is currently 1%.


Code completion leads to jumping of the scrollbar

Type: Bug
Sometimes the scrollbar suddenly jumps down or up, when the code completion have a lot of information, which will be shown in big windows. It seems this is caused by the big description window, which appears sometimes for the suggested code. This is quite annoying.
For example the super huge description for the Autowired annotation takes a lot of space, which causing the scrollbar of the Editor to Jump down or up.

 To help fix this issue, it would be helpful if you could provide some more information about the problem, such as the specific steps you're taking that cause the scrollbar to jump. Additionally, it would be helpful if you could share a code sample so that the development team can try to reproduce it and determine the cause.

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.
Happy Coding!


uuu snap upgrade failure

sudo snap refresh on Ubuntu 22.04.2 LTS gives following:
$ sudo snap refresh
error: cannot perform the following tasks:
- Run post-refresh hook of "universal-update-utility" snap if present (run hook "post-refresh": /snap/universal-update-utility/500/meta/hooks/post-refresh: 3: /snap/universal-update-utility/500/meta/hooks/post-refresh: cannot create /etc/udev/rules.d/test: Permission denied)

Try again? I  remove unused hook

Thanks, but you need to publish a snap package, otherwise I'm not able to try it out.

Yes, I update it, just version have not change.

Same result:
$ sudo snap refresh
error: cannot perform the following tasks:
- Run post-refresh hook of "universal-update-utility" snap if present (run hook "post-refresh": /snap/universal-update-utility/500/meta/hooks/post-refresh: 3: /snap/universal-update-utility/500/meta/hooks/post-refresh: cannot create /etc/udev/rules.d/test: Permission denied)

$ snap list
Name                                  Version                           Rev    Tracking         Publisher          Notes
bare                                  1.0                               5      latest/stable    canonical✓         base
...
universal-update-utility              1.4.243                           434    latest/stable    nxpfrank           -

Had a look once again. snap refresh fails, while I got it through by reinstalling your package:
$ snap refresh
error: cannot perform the following tasks:
- Run post-refresh hook of "universal-update-utility" snap if present (run hook "post-refresh": /snap/universal-update-utility/500/meta/hooks/post-refresh: 3: /snap/universal-update-utility/500/meta/hooks/post-refresh: cannot create /etc/udev/rules.d/test: Permission denied)

$ snap remove universal-update-utility
universal-update-utility removed

$ snap install universal-update-utility
universal-update-utility 1.5.21 from frank li (nxpfrank) installed

$ snap refresh
All snaps up to date.

Closing.


Missing test case for defined pid but not property indexes

Test "P_???_0502 Triangle P1, 2, 3 Usage" does not cover the case where pid is defined but no p1 is defined.
The expected result is to apply the default object property.

To clarify, we need to add the following test cases for triangles, beamlattice, beams, and Balls as follows:
pid present, no index  (i.e. p1) - use default
index present, no pid. - index applied to default pid
The existing test cases for triangles, beamlattice, and beams have BOTH pid and the index present in override test cases.

-Test Specification was updated to add tests for this functionality.
-Test case P_???0312_01 was updated to test missing functionality described in this issue on suites 1, 3, 4, and 5
-Test case P???_0506_01 was updated to test missing functionality described in this issue on suites 2 and 5
-Expected thumbnail albums updated for suites 1 to 6


Bug/better type checking

While building the HanziCraft react-native app, I noticed this line in the dictionarySearch was causing issues. It was evaluated as true by the react-native environment, which was bizarre. However, in theory the type checking done here was not very neat, so I changed it and fixed the bugs I was seeing. Still not sure why the non-empty search array == '' returned true in that environment. But that's probably going deep into different compilers/transpilers etc.

Codecov Report

Merging #57 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master      #57   +/-   ##
=======================================
  Coverage   87.77%   87.77%
=======================================
  Files          15       15
  Lines         548      548
  Branches       91       91
=======================================
  Hits          481      481
  Misses         55       55
  Partials       12       12

Impacted Files
Coverage Δ

lib/dictionary.js
87.98% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 99abbb0...a63b2c2. Read the comment docs.


:memo: docs: update nextjs use docs

💻 变更类型 | Change Type

[ ] ✨ feat
[ ] 🐛 fix
[ ] ♻ refactor
[ ] 💄 style
[ ] 🔨 chore
[ ] ⚡ perf
[x] 📝 docs

🔀 变更说明 | Description of Change

📝 补充信息 | Additional Information

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (3d8d767) 81.99% compared to head (89b921a) 81.99%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #143   +/-   ##
=======================================
  Coverage   81.99%   81.99%
=======================================
  Files         436      436
  Lines       27599    27599
  Branches     1247     1247
=======================================
  Hits        22631    22631
  Misses       4968     4968

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


[HUDI-4114] Remove the unnecessary fs view sync for BaseWriteClient#i…

…nitTable
No need to #sync actively because the table instance is instantiated freshly,
its view manager has empty fiew instantces, the fs view would be synced lazily when
is it requested.
Tips

Thank you very much for contributing to Apache Hudi.
Please review https://hudi.apache.org/contribute/how-to-contribute before opening a pull request.

What is the purpose of the pull request
(For example: This pull request adds quick-start document.)
Brief change log
(for example:)

Modify AnnotationLocation checkstyle rule in checkstyle.xml

Verify this pull request
(Please pick either of the following options)
This pull request is a trivial rework / code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)

Added integration tests for end-to-end.
Added HoodieClientWriteTest to verify the change.
Manually verified the change by running a job locally.

Committer checklist

[ ] Has a corresponding JIRA in PR title & commit

[ ] Commit message is descriptive of the change

[ ] CI is green

[ ] Necessary doc changes done or have another open PR

[ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

@danny0405 : unless it is a hot fix, or some test related changes, can we not merge it in w/o getting a stamp from someone.
It is a good practice to follow as to not miss out anything.

@danny0405 : unless it is a hot fix, or some test related changes, can we not merge it in w/o getting a stamp from someone. It is a good practice to follow as to not miss out anything.

Oops, i'm sorry, would follow that in following PRs.
I did ping you on Slack but no response yet.


feat(pie-monorepo): DSW-2172 pie-design-tokens update

Describe your changes (can list changeset entries if preferable)

"wc-vanilla": minor
"pie-storybook": minor
"pie-docs": minor
"pie-monorepo": minor
[Changed] - pie-design-tokens version bump to 6.5.0.

"@justeattakeaway/pie-css": minor
[Changed] - replaces hardcoded breakpoint values with PIE tokens.

"@justeattakeaway/pie-cookie-banner": minor
"@justeattakeaway/pie-modal": minor
[Removed] - pie-design-tokens dependency

"@justeattakeaway/pie-notification": minor
"@justeattakeaway/pie-modal": minor
[Changed] - replaces media with include-media with pie breakpoints tokens.
It also updates the usage of scss var for ::backdrop in modal component with css value since the bug has been fixed:

https://wpt.fyi/results/html/semantics/interactive-elements/the-dialog-element/backdrop-inherits.html?label=experimental&label=master&aligned
https://issues.chromium.org/issues/40569411
https://bugzilla.mozilla.org/show_bug.cgi?id=1855668
https://bugs.webkit.org/show_bug.cgi?id=263834

I checked in Browserstack the following browsers:
Firefox: 130, 129, 128
Chrome: 128, 127, 126
Opera: 113, 112, 111
Edge: 128, 127, 126
Safari: 17.6 worked fine on my machine but didn't show the backdrop in browserstack so I couldn't confirm
Author Checklist (complete before requesting a review)

[x] I have performed a self-review of my code
[ ] I have reviewed the PIE Storybook/PIE Docs PR preview
[ ] I have reviewed visual test updates properly before approving
[x] If changes will affect consumers of the package, I have created a changeset entry.
[x] If a changeset file has been created, I have used the /snapit functionality to test my changes in a consuming application

Reviewer checklists (complete before approving)
Reviewer 1

[ ] I have reviewed the PIE Storybook/PIE Docs PR preview
[ ] If there are visual test updates, I have reviewed them

Reviewer 2

[ ] I have reviewed the PIE Storybook/PIE Docs PR preview
[ ] If there are visual test updates, I have reviewed them

/test-aperture

/snapit

/test-aperture

/snapit