Update log entry table to allow longer messages

1. Why is this change necessary?
Long messages in log entries (such as stack traces) which exceed 255 characters cannot be saved in the database. The creation of the row fails, as the data is too large to fit in the data cell. See the example below.
2. What does this change do, exactly?
This PR changes the datatype of the column message in the table log_entry from VARCHAR(255) to LONGTEXT, effectively removing the character limit. The "limit" now sits at roughly 4GB, which should be enough for even the longest stack traces.
3. Describe each step to reproduce the issue or behaviour.

Try to consume a message (in the message queue) which causes an exception, such that the serialized exception is longer than 255 characters.

4. Please link to the relevant issues (if any).
5. Checklist

[x] I have written tests and verified that they fail without my change
[x] I have created a changelog file with all necessary information about my changes
[x] I have written or adjusted the documentation according to my changes
[x] This change has comments for package types, values, functions, and non-obvious lines of code
[x] I have read the contribution requirements and fulfil them.

Small example for the kind of error message
bin/console messenger:consume -t 120 -m 1G

 [OK] Consuming messages from transports "default".

 [Exception]

In AbstractMySQLDriver.php line 128:

  An exception occurred while executing 'INSERT INTO log_entry (id, message, level, channel, context, extra, updated_at, created_at) VALUES (?, ?, ?, ?, ?, ?, ?, ?)' with param
  s ["\xc0\xc7\x0c\xdc\xa2\x37\x4e\x85\x9f\x88\x8e\xb3\x02\xd4\x99\x05", "Failed rendering string template using Twig: Failed rendering string template using Twig: Neither the
  property \"calculatedListingPrice\" nor one of the methods \"calculatedListingPrice()\", \"getcalculatedListingPrice()\"\/\"iscalculatedListingPrice()\"\/\"hascalculatedListi
  ngPrice()\" or \"__call()\" exist and have public access in class \"Shopware\\Core\\Content\\Product\\SalesChannel\\SalesChannelProductEntity\" in \"a521744fc19cf2df60ab0b052
  9f0c3a7\" at line 27.", 400, "business_events", "[]", "[]", null, "2022-03-04 09:20:40.873"]:

  SQLSTATE[22001]: String data, right truncated: 1406 Data too long for column 'message' at row 1

You also need to change the field type inside the definition \Shopware\Core\Framework\Log\LogEntryDefinition from StringField to LongTextField as StringFields have a default max length of 255 chars, and those will be validated when the table is written by the DAL.

Hello,
thank you for creating this pull request.
I have opened an issue on our Issue Tracker for you. See the issue link: https://issues.shopware.com/issues/NEXT-20766
Please use this issue to track the state of your pull request.

Thanks @maximilianruesch for contributing! 🎉


Document NUGET_UPDATEFILETIME_MAXRETRIES

fixes: https://github.com/NuGet/docs.microsoft.com-nuget/issues/2626

Docs Build status updates of commit 64e813a:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/reference/cli-reference/cli-ref-environment-variables.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit 070fc85:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/reference/cli-reference/cli-ref-environment-variables.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit 6229c23:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/reference/cli-reference/cli-ref-environment-variables.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


Add unit tests for channel model funding getters

These functions were added in #3256.
This work follows #3267.

@geoknee This is the same changeset as https://github.com/statechannels/statechannels/pull/3265

Is there a reason these tests were not included in #3256?

Am I reviewing the right changeset? This PR includes https://github.com/statechannels/statechannels/pull/3273/commits/dd75f9e7f075154fe325c1397b9c9af013dcb15d
This seems like the same content as https://github.com/statechannels/statechannels/pull/3257/commits/79736c2f947715c32246a5f1d0e0222804fe778c, which is a different commit in a different branch.

Is there a reason these tests were not included in #3256?

The unit tests probably should have been included in #3256.

Am I reviewing the right changeset? This PR includes dd75f9e
This seems like the same content as 79736c2, which is a different commit in a different branch.

This is the result of stacking PRs. I don't have a good strategy for doing so right now. Perhaps we should figure out a process for creating PRs that depend on other PRs that are yet to be merged.

@andrewgordstewart This PR is more reasonable to review now.


Template for EE Tasks alpha

Procedurally-generated tabs for multi-version UI and CLI walkthroughs of tasks for EE's use cases.
See: https://deploy-preview-5066--docker-docs.netlify.com/deploy/test/

LGMT 2 me too :)


klipper: unstable-2022-10-06 -> unstable-2022-10-17

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for klipper is: "The Klipper 3D printer firmware"
meta.homepage for klipper is: "https://github.com/KevinOConnor/klipper"
meta.changelog for klipper is: ""
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
found unstable-2022-10-13 in filename of file in /nix/store/0krrcwjjpi0b7av37swckc49bjp5gv99-klipper-unstable-2022-10-13

Rebuild report (if merged into master) (click to expand)

4 total rebuild path(s)

4 package rebuild(s)

First fifty rebuilds by attrpath
klipper
klipper-firmware
klipper-flash
klipper-genconf

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/0krrcwjjpi0b7av37swckc49bjp5gv99-klipper-unstable-2022-10-13 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A klipper https://github.com/r-ryantm/nixpkgs/archive/4b311cb852b29178d32fc872065edfba4aa09d61.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/0krrcwjjpi0b7av37swckc49bjp5gv99-klipper-unstable-2022-10-13
ls -la /nix/store/0krrcwjjpi0b7av37swckc49bjp5gv99-klipper-unstable-2022-10-13/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

4 packages built:

klipper
klipper-firmware
klipper-flash
klipper-genconf

Maintainer pings
cc @lovesegfault @zhaofengli @cab404 for testing.

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for klipper is: "The Klipper 3D printer firmware"
meta.homepage for klipper is: "https://github.com/KevinOConnor/klipper"
meta.changelog for klipper is: ""
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
found unstable-2022-10-17 in filename of file in /nix/store/va1vsqbdk7bjcjz4b7aqrs763z5c6nav-klipper-unstable-2022-10-17

Rebuild report (if merged into master) (click to expand)

4 total rebuild path(s)

4 package rebuild(s)

First fifty rebuilds by attrpath
klipper
klipper-firmware
klipper-flash
klipper-genconf

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/va1vsqbdk7bjcjz4b7aqrs763z5c6nav-klipper-unstable-2022-10-17 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A klipper https://github.com/r-ryantm/nixpkgs/archive/91d76738b4009e6e1925eb600c82eb80aea6157e.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/va1vsqbdk7bjcjz4b7aqrs763z5c6nav-klipper-unstable-2022-10-17
ls -la /nix/store/va1vsqbdk7bjcjz4b7aqrs763z5c6nav-klipper-unstable-2022-10-17/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

4 packages built:

klipper
klipper-firmware
klipper-flash
klipper-genconf

Maintainer pings
cc @lovesegfault @zhaofengli @cab404 for testing.


Make DifferentialPair able to nest.

This change makes the DifferentialPair type nest-able, so we can form DifferentialPair<DifferentialPair<T>> types.
This is a prerequisite to support nested/higher-order differentiation.
The challenge here is to define the DifferentialPair type so that the Differential of Differential should always evaluates to DifferentialBottom, which is a builtin type for representing non-existent/not-well-defined differential. This means that we need to make DifferentialPair<DifferentialPair<T>> to effectively form a tripple (p.p.p, p.p.d p.d.p), leaving out the p.d.d term that has no mathematical meaning.
To allow such definition, this work starts by modifying the existing DifferentialPair<T:IDifferentiable> .
The new definition of DifferentialPair type is as follows:
__generic<T : IDifferentiable>
__magic_type(DifferentialPairType)
__intrinsic_type($(kIROp_DifferentialPairType))
struct DifferentialPair : IDifferentiable
{
    typedef DifferentialPair<T.Differential> Differential;
    typedef T.Differential DifferentialElementType;

    __intrinsic_op($(kIROp_MakeDifferentialPair))
    __init(T _primal, T.Differential _differential);

    __intrinsic_op($(kIROp_DifferentialPairGetDifferential))
    T.Differential d();

    T.Differential getDifferential()
    {
        return d();
    }

    __intrinsic_op($(kIROp_DifferentialPairGetPrimal))
    T p();

    T getPrimal()
    {
        return p();
    }

    [__unsafeForceInlineEarly]
    static Differential dzero()
    {
        return Differential(T.dzero(), Differential.DifferentialElementType.dzero());
    }

    [__unsafeForceInlineEarly]
    static Differential dadd(Differential a, Differential b)
    {
        return Differential(
            T.dadd(
                a.p(),
                b.p()
            ),
            Differential.DifferentialElementType.dzero());
    }

    [__unsafeForceInlineEarly]
    static Differential dmul(This a, Differential b)
    {
        return Differential(
             T.dmul(a.p(), b.p()),
            Differential.DifferentialElementType.dzero());
    }
};

There is one tricky bit when defining DifferentialPair this way. Notice the definition of Differential:
 typedef DifferentialPair<T.Differential> Differential;

This line has a type mismatch issue because T.Differential is unconstrained and using it to fill in type parameter that requires IDifferential conformance is not valid.
To solve this issue, we introduce a new sub-typing rule that if a generic type T is unconstraint, we treat it as a subtype of DifferentialBottom. This rule allowed us to form the Differential type for DifferentialPair, and that the Differential.Differential will resolve to DifferentialPair<T.Differential, DifferentialBottom>, which is exactly what we want.
The rest of this PR is all about dealing with the consequences of changing the stdlib definition of DifferentialPair.
Most of the work done here is to get generic-impl-jvp test to pass. First, we need to modify dvector type to conform to IDifferentiable  since it is used as Differential type for myvector. We will just rely on automatic synthesis to implement the conformances. However, dvector is a generic type, so the first part of the work is to extend our synthesis logic to work with generic parent types. The next obstacle is that values field is an array, and we need our synthesis logic to be smart enough to synthesize a loop to compute each element of the array. This required us to synthesize significantly more complex code, so I've added the ASTSynthesizer class to simplify the synthesis code.
Another major challenge addressed in this PR is to register type conformances only within a differentiable function at each expression site instead of doing it globally at coerce. This allows us to avoid running the differentiation logic for programs that don't need it.

I think the dictionary clean up would be trivial after this PR, because we now only collect witness for expressions inside a differentiable func. We could just stick them to a function-local decoration instead of the global dictionary.


'long' object has no attribute 'encode'

Version: 2.10.3
Platform: Python 2.7.5 on  Ubuntu 16.04
Description: When trying to use pipeline with command that reply with integer value, exception raise.
Example
r_old_master = redis.StrictRedis(host=old_master_host, port=old_master_port)
p_old_master = r_old_master.pipeline(transaction=True)
p_old_master.execute_command('CLIENT KILL', 'TYPE', 'normal')
p_old_master.execute_command('CLIENT KILL', 'TYPE', 'pubsub')
p_old_master.execute_command("SET", "my_key", “my_value”)
p_old_master.execute()

As CLIENT KILL TYPE <type> will return the number of clients killed.,
  File "build/bdist.linux-x86_64/egg/redis/client.py", line 2578, in execute
    return execute(conn, stack, raise_on_error)
  File "build/bdist.linux-x86_64/egg/redis/client.py", line 2501, in _execute_transaction
    r = self.response_callbacks[command_name](r, **options)
  File "build/bdist.linux-x86_64/egg/redis/client.py", line 238, in bool_ok
    return nativestr(response) == 'OK'
  File "build/bdist.linux-x86_64/egg/redis/_compat.py", line 19, in <lambda>
    x if isinstance(x, str) else x.encode('utf-8', 'replace')
AttributeError: 'long' object has no attribute 'encode'

I find the source code is like that, if x is str i think exception will be raise
    def nativestr(x):
        return x if isinstance(x, str) else x.encode('utf-8', 'replace')

my test
>>> def foo(x):
...     return x if isinstance(x, str) else x.encode('utf-8', 'replace')
...
>>> a = 3L
>>> type(a)
<type 'long'>
>>> foo(a)
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "<stdin>", line 2, in foo
AttributeError: 'long' object has no attribute 'encode'

I think the reason is that  old version redis-py can not adapt to the command ('CLIENT KILL', *args)  because not noly the pipeline but the StrictRedis client i saw the same error.


nixos/lxqt: enable libinput

Description of changes
See https://github.com/NixOS/nixpkgs/issues/170489
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

I had a weird bug caused by this option missing in the past where the touchpad could do everything but move the cursor. I'd be in favor of this being a default.

@romildo can you rebase?

@romildo can you rebase?

Done.


how did you generate the demo gif ?

I don't remember 😬
I think I googled for "terminal recorder GIF output" or something like that.


The plugin can block Neovim for a long time

This plugin synchronously calls vim.fn.getcompletion. When that happens, the entire Neovim is blocked until that call completes. Unfortunately, that call can take a long time in some circumstances. For example, completing :e huge_nfs_directory/ takes a minute on my machine. I suspect that https://github.com/hrsh7th/cmp-cmdline/issues/84 is another example of this.
There are a few avenues we could take to remedy this:

Make the call asynchronous or add a timeout. Unfortunately, I couldn't find a way to do this. https://github.com/neovim/neovim/issues/19742 suggests there's no existing way for it.
https://github.com/neovim/neovim/issues/19742 suggests using CTRL-C. Unfortunately, that doesn't work for cmp-cmdline, because CTRL-C clears the entire commandline. That means that I can't finish the command I'm typing. I either have to wait for completion to finish or abandon it entirely.
Avoid using vim.fn.getcompletion. I don't know what alternative there is though.

Hitting this too at the moment, made me think it was an issue with cmp-path: https://github.com/hrsh7th/cmp-path/issues/68

It is possible to get around blocking calls that take a long time. I wrote a autocompletion plugin (https://github.com/girishji/autosuggest.vim) for cmdline-mode completion in vim9script. I solved this problem by adding a timeout to job_start(). There are certain completions that are long running (like ** expansion). I check them first in a separate process. I assume similar mechanism can be used in neovim as well.

hitting this too.
I would be happy (enough) with the ability to exclude some paths from cmp-path completion as a work-around (happy to file a feature request under cmp-path if desired)


Can you provide a Google Drive link for dataset?

Thank you for sharing your perfect job.
Can you provide a Google Drive link for the datasets? It is too slow to download these datasets.

Did you download these datasets? I am in China and cannot download these files by using provided .sh file. @JackHenry1992

The download speed is very low. Did you find any remedy for this?


document localization support

Added a doc page for localization support.

I would like to review, but doubt that I can get to it this week. If you need to publish sooner rather than later, please do. I can follow up with questions and suggestions after the fact.


How does one start a function directly on 2.0.1-beta.18

The docs mention func run as an available command, however, it results in the following output:
$ func run .\myFunc\
Error: unknown argument run
Function Runtime Version: 2.0.11308.0
Usage: func [context] [context] <action> [-/--options]

Contexts:
azure       Commands to log in to Azure and manage resources
extensions  Commands for installing extensions
function    Commands for creating and running functions locally
host        Commands for running the Functions host locally
settings    Commands for managing environment settings for the local Functions host
templates   Commands for listing available function templates

Actions:
new     Create a new function from a template. Aliases: new, create
    --language [-l] Template programming language, such as C#, F#, JavaScript, etc.
    --template [-t] Template name
    --name [-n]     Function name

init    Create a new Function App in the current folder. Initializes git repo.
    --no-source-control [-n] Skip running git init. Default is false.

do func host start instead of func run. func run used to internally call func host start, then send a request to the correct function. However we haven't ported that to 2.0. I don't know if it makes sense there. func run has always been a bit odd the way it was implemented.

Closing as obsolete.


Add optional seed argument to pairwise operator.

Hi,
just learning about reactive programming and this repo is great!
I am using the pairwise operator to pair up elements of an observable. However, this means that I need to wait for two elements to be available for the first output element to be emitted. Elements 1, 2, 3, 4, ... would be paired as (1, 2), (3, 4), ...
Would it be possible to add a seed optional argument to pairwise, to be use as a fictitious element number one? This would pair elements as (seed, 1), (2, 3), (4, 5), ...

Hi @gasagna,
Thank for your feedback. There is an start_with operator for these purposes. Can you try it as:
source |> start_with(seed) |> pairwise()

Hi @bvdmitri,
this does the job, thanks! You can close the issue, unless this is a feature that you want to add at some point and can be tracked with this issue.

For me it seems like a nice feature to have and it should be easy to implement.
I will add optional initial value to |> pairwise() operator in next minor release.

This feature is now available in v1.3.9 version!


Feature aws ecr2 8

Compatible with aws-ecr v8.2.1

Your development orb has been published. It will expire in 30 days.
You can preview what this will look like on the CircleCI Orb Registry at the following link:
https://circleci.com/developer/orbs/orb/martyzz1/aws-ecr-extra?version=dev:38a83c2b9c3e110eeabc6e0f82b8f2a3ed86505d

Your development orb has been published. It will expire in 30 days.
You can preview what this will look like on the CircleCI Orb Registry at the following link:
https://circleci.com/developer/orbs/orb/martyzz1/aws-ecr-extra?version=dev:966db9916e07de38f623f5a91030e5b3ed4209c0

Your development orb has been published. It will expire in 30 days.
You can preview what this will look like on the CircleCI Orb Registry at the following link:
https://circleci.com/developer/orbs/orb/martyzz1/aws-ecr-extra?version=dev:966db9916e07de38f623f5a91030e5b3ed4209c0

Your orb has been published to the CircleCI Orb Registry.
You can view your published orb on the CircleCI Orb Registry at the following link:
https://circleci.com/developer/orbs/orb/martyzz1/aws-ecr-extra?version=8.2.1


Add support for refactor

It would be great if we can do refactors like:

Rename an element.
Rename a property/attribute:
Rename an observer.
...

Closing and old issue.


Show tier of mods?

Would it be possible to add the tier of each mod similar to holding ALT in game?   I find that I am switching back alot, cause I am still learning the mod tiers, would be helpful for choosing which mods to select for pricing.

Not only the tier but the original value would be great. When we set +/- 20% would be great to know the actual roll on the item without having go back and forth.


Add auditory gammatone filter bank

Which issue(s) are closed by this pull request?
Towards #267, note that this should be merged into #326 after which #326 can be merged into develop.
Changes proposed in this pull request:

add Gammatone filter class: I first wanted to use the filters containd in scipy, but they are currently buggy (https://github.com/scipy/scipy/issues/16522#issuecomment-1173067641) and would not allow for a close to perfect reconstruction. I thought about using the SOSFilter class, but the output of the Gammatone filters is complex, which required a workaround to go along with pyfar.Signal (can not take complex time values). In addition having it in a class keeps all functions and parameters in an object.
add function to generate ERB spaves frequency vectors
add testing for the above
tiny bugfix elsewhere, that was discovered during testing

@sikersten  I added read write support - can you re-re-review if you find time: https://github.com/pyfar/pyfar/pull/327/commits/682f2d14493ae0cfda208e80285e2432a5b87275


Add python tests (+ consistency tests)

Stylua pre-commit hook added (pip install pre-commit, pre-commit install).
Added the python tests in scripts/python_tests. Check the README.md in that directory, follow the demos to see what it is doing. I have one basic test for Python and it is there for proof of concept now.
LuaCheck fails because the lua files in the directory is not for executing directly. It is for pynvim to execute code to initialise the clean nvim (load treesitter, add communication logic etc.)

You can either format the test files (I would prefer that) or add a .styluaignore https://github.com/theHamsta/nvim-treesitter/blob/72cbda75a901bf14a2eb98a47584fe5fc32689ab/.styluaignore#L1
Do you plan to add a CI workflow for the tests?

You can either format the test files (I would prefer that) or add a .styluaignore https://github.com/theHamsta/nvim-treesitter/blob/72cbda75a901bf14a2eb98a47584fe5fc32689ab/.styluaignore#L1

I formatted with StyLua so it's passing, but LuaCheck is the problem. This is not a linting issue, it's more of accessing unknown function. This is happening because broke down the lua init file to multiple different ones (so later if I don't want some events I can disable them). And simply executing the lua files like
https://github.com/kiyoon/nvim-treesitter-textobjects/blob/759fbddd4a37c314aafd7076473aa7fa87b628a8/scripts/python_tests/tools/event_demo.py#L75-L84
I modified the .luacheckrc to exclude files.

Do you plan to add a CI workflow for the tests?

I just added the GitHub Actions to perform automated testing. However, currently there's only one test and the tests themselves can be unstable.

It's pretty impressive that you wrote your own Neovim testing framework for this. It seems to run on CI so it seems to test on a clean system. I couldn't make it run on my system (with --clean :TSUpdate isn't found thought the :packadd seems to work, without --clean I get other results than the expected ones). I guess I'm fine as long as it runs on CI.
At the moment, test_select.py runs on https://raw.githubusercontent.com/pytorch/pytorch/fc4acd4425ca0896ca1c4f0a8bd7e22a51e94731/torch/nn/modules/loss.py?

It's pretty impressive that you wrote your own Neovim testing framework for this! It seems to run on CI so it seems to test on a clean system. I couldn't make it run on my system (with --clean :TSUpdate isn't found thought the :packadd seems to work, without --clean I get other results than the expected ones). I guess I'm fine as long as it runs on CI.

Thank you! That's weird, if packadd works the treesitter should have been initialised. This is the demo run of tools/event_playground.py.

This just prints all events captured by the nvim movement, buf modification, selection etc.

At the moment, test_select.py runs on https://raw.githubusercontent.com/pytorch/pytorch/fc4acd4425ca0896ca1c4f0a8bd7e22a51e94731/torch/nn/modules/loss.py?

Yes, but that's just a placeholder. I'm making an automated pseudo ground truth generation (assuming that the current behaviour is correct). Once this is implemented I can generalise to more languages, codes, etc.

It just moves the cursor to every possible location and performs textobject selection, and writes the captured events. It is pretty slow but the good news is it should be easy to parallelise it. Maybe searching from all cursor positions is redundant, so we can maybe just choose random positions.

Finally made a working version of the consistency tests.

It logs the current behaviour.
When new pull requests are out, we can see which actions have changed their behaviour easily.

So with Tests we should add definite ground truth that should never change. It should be required to be met for a new pull request.
With Consistency Tests we just auto-generate tests by logging the current behaviour. It should be a good reference but is not a ground truth as behaviour might change in the future. Currently, I have 10,000 tests with one python file. This is subject to change. (I will add more languages, multiple files from multiple sources, more nvim settings, more movements etc.)

So we, have now a version that we "bless" to be ok. If behavior of future CI tests fail, we either have to update the test results if the new behavior is desired or look deeper when we don't expect a change?
Does "auto_generate_tests.py" generate the tests? Is test_select.py the only non-generated test?

So we, have now a version that we "bless" to be ok. If behavior of future CI tests fail, we either have to update the test results if the new behavior is desired or look deeper when we don't expect a change?

Exactly. We should keep it non-required for now until it gets stable.

Does "auto_generate_tests.py" generate the tests?

Yes. I will make a bash script that contains many files with many languages, calling auto_generate_tests.py.

Is test_select.py the only non-generated test?

Yes. However, I think I may just delete the entire tests folder. Using pytest and multiprocessing seemed a bit difficult to implement 🤔
Instead, we can just auto_generate_tests.py and keep only confident ones and delete the rest, to make another confident test.yaml file. We can run it just like the consistency tests.

This package looks very big and it isn't required for users that use the plugin? Should we maybe put it into a separate repo and pull it in only here during our CI? Then, you could develop this independently and it would also be easier in case we would every upstream nvim-treesitter-textobjects to nvim-treesitter as they use a Lua-based test runner.
I found this difficult to run it myself. Is this ready to be used in our CI? Would be good to test whether it would detect certain kind of regression in CI.

This package looks very big and it isn't required for users that use the plugin? Should we maybe put it into a separate repo and pull it in only here during our CI? Then, you could develop this independently and it would also be easier in case we would every upstream nvim-treesitter-textobjects to nvim-treesitter as they use a Lua-based test runner.
I found this difficult to run it myself. Is this ready to be used in our CI? Would be good to test whether it would detect certain kind of regression in CI.

But maybe we want to do synchronized changes to the repo and the test tool. What do you think?

This package looks very big and it isn't required for users that use the plugin? Should we maybe put it into a separate repo and pull it in only here during our CI? Then, you could develop this independently and it would also be easier in case we would every upstream nvim-treesitter-textobjects to nvim-treesitter as they use a Lua-based test runner.

There are quite a few files in this project, but all of them are small and users are not required to install python packages locally so I see little impact when pulling the plugin. The only big files are test files, and I am hosting them on OneDrive for now.
I don't know much about the upstreaming plan so if you think it will be more consistent by keeping it as a separate repo, I don't mind it.

I found this difficult to run it myself. Is this ready to be used in our CI? Would be good to test whether it would detect certain kind of regression in CI.

The CI and local testing are working. What do you mean by regression? Like performance impact?

But maybe we want to do synchronized changes to the repo and the test tool. What do you think?

I guess versioning is not very important as of now and we can just use the master branch of nvim-treesitter, and nvim-treesitter-textobjects-tests when we run the tests, if our goal is just to make sure a PR isn't breaking.

I found this difficult to run it myself. Is this ready to be used in our CI? Would be good to test whether it would detect certain kind of regression in CI.

The CI and local testing are working. What do you mean by regression? Like performance impact?

I mean the CI is now green. Can you commit one of the commits that broke our plugin or deliberately break our plugin to check whether CI ticks turn red?

I mean the CI is now green. Can you commit one of the commits that broke our plugin or deliberately break our plugin to check whether CI ticks turn red?

Actually, the consistency tests hang with some specific events. I'm investigating on this.

It works when failing as well. It was nvim.feedkeys that hangs when vim is in an operator-pending mode.
Do you want me to create the test repository on my own account?

@theHamsta It works when failing as well. It was nvim.feedkeys that hangs when vim is in an operator-pending mode.
Do you want me to create the test repository on my own account?

If it works, we can also have it here for some time. I suppose you would know what to do if we ever have failing tests. Is this ready to merge?

@theHamsta It works when failing as well. It was nvim.feedkeys that hangs when vim is in an operator-pending mode.
Do you want me to create the test repository on my own account?

If it works, we can also have it here for some time. I suppose you would know what to do if we ever have failing tests. Is this ready to merge? You can also out-source code to an own repository of yours if you think that would be more convenient to you.

Don't merge now as I just broke the textobjects to show the tests failing.
I made the repo nvim-treesitter-textobjects-tests and in this repo we can just add the CI that will clone that repository and run the script.

It's pretty impressive that you wrote your own Neovim testing framework for this! It seems to run on CI so it seems to test on a clean system. I couldn't make it run on my system (with --clean :TSUpdate isn't found thought the :packadd seems to work, without --clean I get other results than the expected ones). I guess I'm fine as long as it runs on CI.
At the moment, test_select.py runs on https://raw.githubusercontent.com/pytorch/pytorch/fc4acd4425ca0896ca1c4f0a8bd7e22a51e94731/torch/nn/modules/loss.py?

I just reproduced this problem. I think it happens when the package is not found in a specified packpath.
After running nvim --clean --listen localhost:28905, can you manually run
set packpath+=~/.local/share/nvim/site
packadd nvim-treesitter
packadd nvim-treesitter-textobjects
TSUpdate

And see if it loads treesitter okay? Another option is to use
nvim -u treesitter_init.lua --noplugin

Once you made it loaded then it will be not problem to use the test program


Access to range defined by a Table Name

Hi,
thank you for the library. It's very useful.
I'm using a lot of Structured References (also called "Table Name") in my Excel Sheets for different reasons.
In VBA, I can access these ranges by its name like any range.
For example, a table défined by the range "A1:B5" named "MyRange" can be accessed both ways : range("A1:B5") or range("MyRange").
It's interesting when you have different tables in the same sheets and when their ranges are not know a priori.
Is it possible to do it the same way through the "range" attribute of your method ?
thanks a lot.
Regards

I came here to see if this issue existed. I am working on a project now that would benefit a lot from this.


Frequency and Density

Is it possible to calculate frequency and Density for a given statement and response?

Could you elaborate a bit more about what frequency and density are?

I am not sure this will benefit to chatterbot, My idea is to identify frequent words in all the statements, so that i can guess my users are writing sentence or statements in such a way i can update my corpus based on those words
I find we could find frequency through NLTK module
words = nltk.tokenize.word_tokenize(p)
fdist = FreqDist(words)

More information https://languagelearning.stackexchange.com/questions/449/what-are-the-advantages-of-studying-words-by-their-frequency/452

I'm not sure if this would benefit ChatterBot either. I'd be open to suggestions on design or implementation details regarding this if you or anyone else has suggestions about how something like this could be used to accomplish any learning or response generation tasks. For now however, I'm going to close this ticket off.


Add srun.template for slurm (+ more robust python interpreter location specification)

I like these changes! If you turn this into a full pull request, I'm happy to merge it.

I've changed to 'ready for review'. I've also tested these changes on Ares supercomputer and looks like it works


Updates to automl tabular beans pipeline

Attempting a fix for https://github.com/GoogleCloudPlatform/vertex-ai-samples/issues/204
I replaced job.run() with job.submit(). Also made a few other version updates:

Replaced column_transformations with column_specs
Updated KFP required version to >= 1.8
Updated base component image to TF 2.6

@ivanmkc could you review?

Thanks @sararob !


Add linting for protobuf files via Super lint

Super lint can handle a number of linters, so I am also
migrating the rustfmt and actionlint jobs to use super lint instead

Does this change how a developer should format code before pushing a change? Like running protolint? Can you include instructions for this?

Not specifically, I'd added protolint to the format-all and test-all
scripts.
I'm thinking that I might need to put together a more thorough dev-setup
guide, to include VS Code and Android Studio plugins and configuration. I'm
working through getting protobuf files set up for the whole serialized
design file now and that might change some of the configuration. Let's talk
about this more in our team meeting today.
On Tue, May 21, 2024 at 10:40 AM Robert Lin @.***>
wrote:

Does this change how a developer should format code before pushing a
change? Like running protolint? Can you include instructions for this?
—
Reply to this email directly, view it on GitHub
https://github.com/google/automotive-design-compose/pull/1137#issuecomment-2122914049,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABMM2SS3PPCOEVPZ2WKAC3LZDNTGNAVCNFSM6AAAAABIAKYKOKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMRSHEYTIMBUHE
.
You are receiving this because you were assigned.Message ID:
@.***>

--
Tim Froehlich
Test Engineer for DesignCompose and AAOS
Located in Austin TX, US Central Time
I support a free Palestine 🇵🇸 - go/open-letter

Can you add instructions on installing protolint?

Can you add instructions on installing protolint?

I've got too many active changes now so it's getting messy. Instructions for installing protolint are in #1146. Here's the GitHub repo with it's instructions: https://github.com/yoheimuta/protolint

Is this expected?
[proto/layout/types.proto:26:23] Found a possible incorrect indentation style. Inserting a new line is recommended.
[proto/layout/types.proto:28:18] Found a possible incorrect indentation style. Inserting a new line is recommended.

Is this expected?
[proto/layout/types.proto:26:23] Found a possible incorrect indentation style. Inserting a new line is recommended.
[proto/layout/types.proto:28:18] Found a possible incorrect indentation style. Inserting a new line is recommended.

It's not, I had disabled that check in .protolint.yml. Where did you see that?

Also, FYI, the lint-rust check is listed as Expected because it's been renamed to the --> Linted: RUST_2021 check by super linter. Once you approve the PR and it's ready to merge I'll change the required checks in GitHub to require the new lints to pass.

Is this expected?
[proto/layout/types.proto:26:23] Found a possible incorrect indentation style. Inserting a new line is recommended.
[proto/layout/types.proto:28:18] Found a possible incorrect indentation style. Inserting a new line is recommended.

It's not, I had disabled that check in .protolint.yml. Where did you see that?

Nvm I didn't have your changes. So protolint just warns you, it doesn't format the proto itself, is that correct?

Is this expected?
[proto/layout/types.proto:26:23] Found a possible incorrect indentation style. Inserting a new line is recommended.
[proto/layout/types.proto:28:18] Found a possible incorrect indentation style. Inserting a new line is recommended.

It's not, I had disabled that check in .protolint.yml. Where did you see that?

Nvm I didn't have your changes. So protolint just warns you, it doesn't format the proto itself, is that correct?

It does both. For some reason it didn't want to fix those ones. Empty messages work well for the rust enums and it makes sense for them to be on one line so that's why I disabled the check


Supporting domain aliases

Hello,
This theme is really a great idea. I just tried it out on a store that uses a domain alias:
normalsetup.myshopify.com —> custom.customdomain.com
And I see that clicking the logo in the checkout causes an infinite redirect loop. Any way around this behavior, with this theme?

Hey @MaSchVam, that should definitely be possible! After installing the headless theme, did you define the "Base URL" in the theme settings? This should look like this:

@leeuwis ,
Instead of getting the shop url on line 28 in theme.liquid, I now just grab window.location.href. This should cover this usecase?

@MaSchVam I've opened a PR with a fix, let me know if this fixes the issue for you!
It's indeed fixed by changing the value on line 28 in theme.liquid, but I ended up using window.location.hostname instead of the window.location.href. If window.location.href would be used, all traffic will always be redirect to the home url of your storefront, but the path should also stay intact so https://example.myshopify.com/products/slug-x also gets redirected to https://example.com/products/slug-x.


The tab parser seems to have collapsed concepts that have not identical accessions

The tab parser seems to have collapsed concepts that have not identical accessions (partial prefix matches only).

Test files attached.
acc-merge.zip

Likely, it's not the parser, but the collapse and the Lucene module.

The problem is accessions with dots. The damn Lucene module doesn't yet do fully exact searches in these cases. I'll try to fix it again.

Closing as fixed.


Validation error messages broken in vulcan-accounts

I have an issue with validation error messages not being shown correctly on the signin/signup form. I'm pretty new to React/Meteor/VulcanJS and I've done my best to dig around in the code and Google a solution, but sadly I've not been able to resolve this.
When the signin/signup form is submitted with empty fields, instead of the localised error messages being shown, the key for the localised string is displayed instead. For example, instead of saying "Username required" it displays "accounts.error_username_required". This is true for all validation error messages for this form.
I've traced it back to the helpers.js file in vulcan-accounts, which calls the showMessage method with the error string key directly:
showMessage("accounts.error_username_required", 'warning', false, fieldName);
All other usage of the showMessage method appears to fetch the correct translated string first using a call to formatMessage. For example, LoginForm.jsx calls it like this:
this.showMessage(this.context.intl.formatMessage({id: 'accounts.info_password_changed'}), 'success', 5000);
Is this a bug, or have I got something misconfigured in my project?
I have tried to resolve this myself, but I'm still learning my way around the Meteor/VulcanJS frameworks and can't seem to figure out the right way to import the formatMessage functionality into the vulcan-accounts helpers.js file.

Sorry about that, it's likely a bug. The accounts code was adapted from another package and a few issues crept in when I refactored that code. Like you said, it should be showMessage(formatMessage(string)) instead of showMessage(string).

I fixed it. please check it out ⚡

Now fixed.


control-service: graphql add execution fail/success query

why: Users requested the ability to produce reports
based on data job execution failure/success numbers.
This is a part of the graphQL epic.
what: added a query in the JobExecutionRepository which
retrieves the status of executions based on a certain filter
criteria. Considered to count the execution statuses separately
in two different queries, however decided counting them toghether
wouldn't impose a performance penalty and is more convenient
this way, since DB caching should produce better results as we only
query the DB per data job name once and return only the status
numbers.
testing: added unit test.

Is there github issue for this ticket? Can you link it?

Do you think this approach is better than the one describe in #424? Why?

Is there github issue for this ticket? Can you link it?

This issue is a part of #424, however we don't want to close it when we merge this.

Do you think this approach is better than the one described in #424? Why?

I've updated the query.


[BUG] longhorn-manager: no kind "CronJob" is registered for version "batch/v1"

Describe the bug
I tried upgrading from 1.2.0 to 1.2.2, however longhorn-manager is stuck with the following error message and does not complete the healthcheck:
E1015 18:49:34.531592       1 reflector.go:178] k8s.io/client-go/informers/factory.go:135: Failed to list *v1beta1.CronJob: no kind "CronJob" is registered for version "batch/v1" in scheme "k8s.io/kubernetes/pkg/api/legacyscheme/scheme.go:30"

I then tried to uninstall everything (all volumes and the longhorn-system namespace). After reinstalling (with Helm) longhorn-manager still is stuck with the same error.
To Reproduce
Steps to reproduce the behavior:

Cluster consists of 4 Nodes (2 AMD, 2 ARM) with k3os v0.20.11-k3s2r1 on all nodes.
Deploy longhorn 1.2.2 to the cluster.
longhorn-manager fails to start with error mentioned above.

Expected behavior
No error. Successful deployment of longhorn.
Log
UI returns status code 502.
Environment:

Longhorn version: 1.2.2
Installation method (e.g. Rancher Catalog App/Helm/Kubectl): Helm
Kubernetes distro (e.g. RKE/K3s/EKS/OpenShift) and version: k3os v0.20.11-k3s2r1

Number of management node in the cluster: 4
Number of worker node in the cluster: 4

Node config

OS type and version:
CPU per node:
Memory per node:
Disk type(e.g. SSD/NVMe):
Network bandwidth between the nodes:

Underlying Infrastructure (e.g. on AWS/GCE, EKS/GKE, VMWare/KVM, Baremetal):
Number of Longhorn volumes in the cluster:

Additional context
Previous update from 1.1.x to 1.2.0 was successful. However, trying to deploy 1.2.0 instead of 1.2.2 also shows the same behaviour.

It seems to be related to the Kubernetes version:
https://stackoverflow.com/questions/67520866/no-matches-for-kind-cronjob-in-version-batch-v1
k3os v0.20.11-k3s2r1 means k3s version v1.20.11+k3s2. I don’t know why this issue is not triggered in the v1.2.2 release test.

Thanks @reitermarkus
Something is wrong with k3os v0.20.11-k3s2r1. Could @longhorn/qa give it try?


Change user id from header to url param

When we want to list licences belonging to a certain user, we're using a header with the User UUID. We need to use the user ID in the URL instead, like in
.../licences?user_id=:user_id
Thanks

The code was as you requested the problem was with the documentation, it's fixed now plus other minor fixes in the documentation. Should we do another pull request?

:-)
Yes please.

On 6 Dec 2016, at 15:09, Bruno Silva<EMAIL_ADDRESS>wrote:
The code was as you requested the problem was with the documentation, it's fixed now plus other minor fixes in the documentation. Should we do another pull request?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/sonata-nfv/son-gkeeper/issues/358#issuecomment-265173691, or mute the thread https://github.com/notifications/unsubscribe-auth/AAAuQ8f_jlb1odPuQGbPOC3dfHu6lz-Bks5rFXqOgaJpZM4LEGlQ.

Closed by #418


ArgumentError

Hello, i try to create a producer as written in the documentation.
class TestProducer
  include Phobos::Producer
end

Then i call it
TestProducer.producer.publish(topic: 'test', payload: {test: 'test'}.to_json)
I catch error
ArgumentError (wrong number of arguments (given 1, expected 2..4))
Phobos running standalone.
Gem version 1.8.2, ruby version 2.6.3, rails version <IP_ADDRESS>

@Pash-tet please try with the latest version, 1.9.0-beta3. It's still technically in beta because we haven't had anyone use it on production yet, although that should change very soon!

@dorner I can't install this version:
gem install phobos -v '~> 1.9.0.pre.beta2'
Successfully installed phobos-1.9.0.pre.beta3
Parsing documentation for phobos-1.9.0.pre.beta3
Installing ri documentation for phobos-1.9.0.pre.beta3
Done installing documentation for phobos after 0 seconds
1 gem installed

Only phobos-1.9.0.pre.beta3, in this version i have another error:
TestProducer.producer.publish(topic: 'test', payload: 'test')
NoMethodError (undefined method `producer_hash' for nil:NilClass)

Can you post the full backtrace?

Maybe you forgot to call Phobos.configure?

Yes, I forgot to add this line to initializer. Everything worked. Thanks for the help. Good luck with the release. I want to use this gem in production.


custom button and props for TriangleColorPicker

Hello there, I implemented some feature described here #28 for TriangleColorPicker
Could somebody apply this #29?

@sodik82, could you help with this, please?

hi there,
you can now (0.5.3) simply hide default buttons and render your buttons outside of the component. I believe it should be enough to cover your case.
if not, pls let me know.

@sodik82, thank you.


add onyo new --set

The relevant portions of #260 have been moved here:
We want onyo new --set key=value asset to have the optional flag --set, but also the possibility to not use it, while at least one (possibly multiple) asset(s) are needed, except when a --tsv tsv.file is specified, which disallows giving assets via command line.
It is unclear to me if this is possible without adding --path to onyo new (see #286), which I'm not thrilled about.

There are three options I see:

don't add --set to onyo new
add the --path flag to onyo new
examine the passed args to determine if they're a key=value pair or an asset.

1 would be a tangible loss in functionality, IMO. 2 would blur the command categories we just created. 3. is most intuitive IMO, but will make Tobias cry.
Thoughts? ;-)

It makes me cry for sure, and it already does, since it is the current approach, and does still break the onyo new --help.
I see the argument against 2, but we do already have a onyo new --tsv [path], so if there is a need to declare actively if it is about a tsv or an asset path, I could live with onyo new --path warehouse/laptop_apple_macbookpro.123

Another option:

don't view this as a set of assets but rather using an ephemeral template.

2 and 4 are my current favorites.


How can I see the payload to an NLogViewer target?

Type: Question
NLog version: 4.3.10
Platform: .Net 4.5
Current NLog config

<?xml version="1.0" encoding="utf-8"?>

<nlog xmlns="http://www.nlog-project.org/schemas/NLog.xsd"
      xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
      autoReload="true"
      throwExceptions="true"
      internalLogFile="c:\temp\nlog-debug-log.txt"
      internalLogLevel="Trace"
      >

  <!-- NLog example: https://github.com/nlog/nlog/wiki/Examples -->
  <targets async="true">
    <target name="Sentinel"
            xsi:type="NLogViewer"
            address="udp://<IP_ADDRESS>:9999"
            layout="ssss-seeing-if-this-overrides"/>
  </targets>

  <rules>
    <logger name="*" minlevel="Trace" appendTo="Sentinel" />
  </rules>

</nlog>

Hi 👋
I'm trying to figure out a way to see the payload that is sent over the wire when using an NLogViewer target. My reasoning is that we use a viewer called Sentinal and I'm starting to use properties to attach more meta data, per log entry. (We use Serilog + Serilog.sinks.nlog right now).
If i can see the exact payload that is sent over the wire to sentinal I can then determine if it's worth my time in trying to fix their application to handle dynamic columns (1 per property, for example) or maybe flatten the properties into the end of the rendered Message.
So - is there an easy way to see this data?
I'm used to using FIDDLER for snooping this type of info but this isn't HTTP traffic.
NOTE: If you noticed, i've added a internalLogLevel="Trace" attribute to see if the internal tracing might output/dump the payload context, but it doesn't. (I don't put that on any of my nlog files .. just this R&D).
cheers!

It looks like this isn't logged to the InternalLogger. We could add it in the next version. The code should added to the NetworkTarget

Oh nice then :)

would an example be provided if it's added, in the next release?
could this issue be updated (with a link to a PR) if it's added in, please?

would an example be provided if it's added, in the next release?

Do you mean, how to enable? That will be  internalLogLevel="Trace"

I said

would an example be provided if it's added, in the next release?

and you said

Do you mean, how to enable? That will be internalLogLevel="Trace"

and I was actually really trying to say ..
would an example be provided that uses this NetworkTarget if that is the way we will need to see this payload data. Otherwise, what does NetworkTarget have to do with it?

Sorry about the confusion.
NLogViewer inherits from NetworkTarget, so if we log at NetworkTarget level, this is fixed for NLogViewer :)

I have added some internal logs in NLog 4.3.11. https://www.nuget.org/packages/NLog/4.3.11

Thank you kindly!


👷 Add codecov step to python-package.yml

Add codecov step

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@95e48f8). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #10   +/-   ##
=======================================
  Coverage        ?   91.30%
=======================================
  Files           ?        7
  Lines           ?      138
  Branches        ?        0
=======================================
  Hits            ?      126
  Misses          ?       12
  Partials        ?        0

Flag
Coverage Δ

unittests
91.30% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 95e48f8...0bd5a9c. Read the comment docs.


gopacket does not build on openbsd

0:mischief@thx1138:~/go/src/github.com/david415/HoneyBadger/cmd/honeyBadger$ go install
# github.com/google/gopacket/pcap
error: 'pcap_free_datalinks' undeclared (first use in this function)
error: 'pcap_offline_filter' undeclared (first use in this function)

this is OpenBSD 5.6, with the system libpcap.

Do you happen to know which libpcap version is installed?
On Sat, Apr 4, 2015 at 8:35 PM, Nick Owens<EMAIL_ADDRESS>wrote:

0:mischief@thx1138:~/go/src/github.com/david415/HoneyBadger/cmd/honeyBadger$ go install
github.com/google/gopacket/pcap
error: 'pcap_free_datalinks' undeclared (first use in this function)
error: 'pcap_offline_filter' undeclared (first use in this function)
i modified honeybadger to use the new github package rather than
code.google.com, but the error is the same for both repos.
this is OpenBSD 5.6, with the system libpcap.
—
Reply to this email directly or view it on GitHub
https://github.com/google/gopacket/issues/64.

sorry, no, i can't tell myself. but i also tried on openbsd 5.7.
here's the header file. http://cvsweb.openbsd.org/cgi-bin/cvsweb/src/lib/libpcap/pcap.h?only_with_tag=OPENBSD_5_7
i also attempted to link gopacket against a locally compiled version of pcap, but rather than compiler errors of undeclared functions, i got linker errors.
1:mischief@thx1138:~/go/src/github.com/david415/HoneyBadger/cmd/honeyBadger$ CGO_CFLAGS="-I$PCAP_PATH/include" CGO_LDFLAGS="-L$PCAP_PATH/lib" go build -x
WORK=/tmp/go-build313270947
mkdir -p $WORK/github.com/google/gopacket/pcap/_obj/
mkdir -p $WORK/github.com/google/gopacket/
cd /home/mischief/go/src/github.com/google/gopacket/pcap
CGO_LDFLAGS="-L/home/mischief/local/lib" /usr/local/go/pkg/tool/openbsd_amd64/cgo -objdir $WORK/github.com/google/gopacket/pcap/_obj/ -- -I $WORK/github.com/google/gopacket/pcap/_obj/ -I/home/mischief/local/include pcap.go
/usr/local/go/pkg/tool/openbsd_amd64/6c -F -V -w -trimpath $WORK -I $WORK/github.com/google/gopacket/pcap/_obj/ -I /usr/local/go/pkg/openbsd_amd64 -o $WORK/github.com/google/gopacket/pcap/_obj/_cgo_defun.6 -D GOOS_openbsd -D GOARCH_amd64 $
WORK/github.com/google/gopacket/pcap/_obj/_cgo_defun.c
gcc -I . -fPIC -m64 -pthread -fmessage-length=0 -print-libgcc-file-name
gcc -I . -fPIC -m64 -pthread -fmessage-length=0 -I $WORK/github.com/google/gopacket/pcap/_obj/ -I/home/mischief/local/include -o $WORK/github.com/google/gopacket/pcap/_obj/_cgo_main.o -c $WORK/github.com/google/gopacket/pcap/_obj/_cgo_main
.c
gcc -I . -fPIC -m64 -pthread -fmessage-length=0 -I $WORK/github.com/google/gopacket/pcap/_obj/ -I/home/mischief/local/include -o $WORK/github.com/google/gopacket/pcap/_obj/_cgo_export.o -c $WORK/github.com/google/gopacket/pcap/_obj/_cgo_ex
port.c
gcc -I . -fPIC -m64 -pthread -fmessage-length=0 -I $WORK/github.com/google/gopacket/pcap/_obj/ -I/home/mischief/local/include -o $WORK/github.com/google/gopacket/pcap/_obj/pcap.cgo2.o -c $WORK/github.com/google/gopacket/pcap/_obj/pcap.cgo2
.c
gcc -I . -fPIC -m64 -pthread -fmessage-length=0 -o $WORK/github.com/google/gopacket/pcap/_obj/_cgo_.o $WORK/github.com/google/gopacket/pcap/_obj/_cgo_main.o $WORK/github.com/google/gopacket/pcap/_obj/_cgo_export.o $WORK/github.com/google/g
opacket/pcap/_obj/pcap.cgo2.o -L/home/mischief/local/lib
# github.com/google/gopacket/pcap
/tmp/go-build313270947/github.com/google/gopacket/pcap/_obj/pcap.cgo2.o(.text+0x73): In function `_cgo_c663009e3544_Cfunc_pcap_activate':
: undefined reference to `pcap_activate'
/tmp/go-build313270947/github.com/google/gopacket/pcap/_obj/pcap.cgo2.o(.text+0x9e): In function `_cgo_c663009e3544_Cfunc_pcap_can_set_rfmon':
: undefined reference to `pcap_can_set_rfmon'
/tmp/go-build313270947/github.com/google/gopacket/pcap/_obj/pcap.cgo2.o(.text+0xc9): In function `_cgo_c663009e3544_Cfunc_pcap_close':
: undefined reference to `pcap_close'
/tmp/go-build313270947/github.com/google/gopacket/pcap/_obj/pcap.cgo2.o(.text+0x112): In function `_cgo_c663009e3544_Cfunc_pcap_compile':
: undefined reference to `pcap_compile'
/tmp/go-build313270947/github.com/google/gopacket/pcap/_obj/pcap.cgo2.o(.text+0x145): In function `_cgo_c663009e3544_Cfunc_pcap_create':
: undefined reference to `pcap_create'
/tmp/go-build313270947/github.com/google/gopacket/pcap/_obj/pcap.cgo2.o(.text+0x172): In function `_cgo_c663009e3544_Cfunc_pcap_datalink':
: undefined reference to `pcap_datalink'
/tmp/go-build313270947/github.com/google/gopacket/pcap/_obj/pcap.cgo2.o(.text+0x19c): In function `_cgo_c663009e3544_Cfunc_pcap_datalink_val_to_description':
: undefined reference to `pcap_datalink_val_to_description'

... rest is elided ...

Ah, I think that second issue is probably easier to fix...
Please try this change: https://github.com/google/gopacket/pull/66/files
Let me know if it works.  If it does, I can commit it to master.
On Mon, Apr 6, 2015 at 10:07 AM, Nick Owens<EMAIL_ADDRESS>wrote:

sorry, no, i can't tell myself. but i also tried on openbsd 5.7.
here's the header file.
http://cvsweb.openbsd.org/cgi-bin/cvsweb/src/lib/libpcap/pcap.h?only_with_tag=OPENBSD_5_7
i also attempted to link gopacket against a locally compiled version of
pcap, but rather than compiler errors of undeclared functions, i got linker
errors.
1:mischief@thx1138:~/go/src/github.com/david415/HoneyBadger/cmd/honeyBadger$ CGO_CFLAGS="-I$PCAP_PATH/include" CGO_LDFLAGS="-L$PCAP_PATH/lib" go build -x
WORK=/tmp/go-build313270947
mkdir -p $WORK/github.com/google/gopacket/pcap/_obj/
mkdir -p $WORK/github.com/google/gopacket/
cd /home/mischief/go/src/github.com/google/gopacket/pcap
CGO_LDFLAGS="-L/home/mischief/local/lib" /usr/local/go/pkg/tool/openbsd_amd64/cgo -objdir $WORK/github.com/google/gopacket/pcap/_obj/ -- -I $WORK/github.com/google/gopacket/pcap/_obj/ -I/home/mischief/local/include pcap.go
/usr/local/go/pkg/tool/openbsd_amd64/6c -F -V -w -trimpath $WORK -I $WORK/github.com/google/gopacket/pcap/_obj/ -I /usr/local/go/pkg/openbsd_amd64 -o $WORK/github.com/google/gopacket/pcap/_obj/_cgo_defun.6 -D GOOS_openbsd -D GOARCH_amd64 $
WORK/github.com/google/gopacket/pcap/_obj/_cgo_defun.c
gcc -I . -fPIC -m64 -pthread -fmessage-length=0 -print-libgcc-file-name
gcc -I . -fPIC -m64 -pthread -fmessage-length=0 -I $WORK/github.com/google/gopacket/pcap/_obj/ -I/home/mischief/local/include -o $WORK/github.com/google/gopacket/pcap/_obj/_cgo_main.o -c $WORK/github.com/google/gopacket/pcap/_obj/_cgo_main
.c
gcc -I . -fPIC -m64 -pthread -fmessage-length=0 -I $WORK/github.com/google/gopacket/pcap/_obj/ -I/home/mischief/local/include -o $WORK/github.com/google/gopacket/pcap/_obj/_cgo_export.o -c $WORK/github.com/google/gopacket/pcap/_obj/_cgo_ex
port.c
gcc -I . -fPIC -m64 -pthread -fmessage-length=0 -I $WORK/github.com/google/gopacket/pcap/_obj/ -I/home/mischief/local/include -o $WORK/github.com/google/gopacket/pcap/_obj/pcap.cgo2.o -c $WORK/github.com/google/gopacket/pcap/_obj/pcap.cgo2
.c
gcc -I . -fPIC -m64 -pthread -fmessage-length=0 -o $WORK/github.com/google/gopacket/pcap/_obj/cgo.o $WORK/github.com/google/gopacket/pcap/_obj/_cgo_main.o $WORK/github.com/google/gopacket/pcap/_obj/_cgo_export.o $WORK/github.com/google/g
opacket/pcap/_obj/pcap.cgo2.o http://github.com/google/gopacket/pcap/_obj/pcap.cgo2.o -L/home/mischief/local/lib
github.com/google/gopacket/pcap
/tmp/go-build313270947/github.com/google/gopacket/pcap/_obj/pcap.cgo2.o(.text+0x73) http://github.com/google/gopacket/pcap/tmp/go-build313270947/github.com/google/gopacket/pcap/_obj/pcap.cgo2.o(.text+0x73): In function _cgo_c663009e3544_Cfunc_pcap_activate': : undefined reference to pcap_activate'
/tmp/go-build313270947/github.com/google/gopacket/pcap/_obj/pcap.cgo2.o(.text+0x9e): In function _cgo_c663009e3544_Cfunc_pcap_can_set_rfmon': : undefined reference to pcap_can_set_rfmon'
/tmp/go-build313270947/github.com/google/gopacket/pcap/_obj/pcap.cgo2.o(.text+0xc9): In function _cgo_c663009e3544_Cfunc_pcap_close': : undefined reference to pcap_close'
/tmp/go-build313270947/github.com/google/gopacket/pcap/_obj/pcap.cgo2.o(.text+0x112): In function _cgo_c663009e3544_Cfunc_pcap_compile': : undefined reference to pcap_compile'
/tmp/go-build313270947/github.com/google/gopacket/pcap/_obj/pcap.cgo2.o(.text+0x145): In function _cgo_c663009e3544_Cfunc_pcap_create': : undefined reference to pcap_create'
/tmp/go-build313270947/github.com/google/gopacket/pcap/_obj/pcap.cgo2.o(.text+0x172): In function _cgo_c663009e3544_Cfunc_pcap_datalink': : undefined reference to pcap_datalink'
/tmp/go-build313270947/github.com/google/gopacket/pcap/_obj/pcap.cgo2.o(.text+0x19c): In function _cgo_c663009e3544_Cfunc_pcap_datalink_val_to_description': : undefined reference to pcap_datalink_val_to_description'
... rest is elided ...
—
Reply to this email directly or view it on GitHub
https://github.com/google/gopacket/issues/64#issuecomment-90126252.

Merged into master.
On Mon, Apr 6, 2015 at 10:24 AM, Graeme Connell<EMAIL_ADDRESS>wrote:

Ah, I think that second issue is probably easier to fix...
Please try this change: https://github.com/google/gopacket/pull/66/files
Let me know if it works.  If it does, I can commit it to master.
On Mon, Apr 6, 2015 at 10:07 AM, Nick Owens<EMAIL_ADDRESS>wrote:

sorry, no, i can't tell myself. but i also tried on openbsd 5.7.
here's the header file.
http://cvsweb.openbsd.org/cgi-bin/cvsweb/src/lib/libpcap/pcap.h?only_with_tag=OPENBSD_5_7
i also attempted to link gopacket against a locally compiled version of
pcap, but rather than compiler errors of undeclared functions, i got linker
errors.
1:mischief@thx1138:~/go/src/github.com/david415/HoneyBadger/cmd/honeyBadger$ CGO_CFLAGS="-I$PCAP_PATH/include" CGO_LDFLAGS="-L$PCAP_PATH/lib" go build -x
WORK=/tmp/go-build313270947
mkdir -p $WORK/github.com/google/gopacket/pcap/_obj/
mkdir -p $WORK/github.com/google/gopacket/
cd /home/mischief/go/src/github.com/google/gopacket/pcap
CGO_LDFLAGS="-L/home/mischief/local/lib" /usr/local/go/pkg/tool/openbsd_amd64/cgo -objdir $WORK/github.com/google/gopacket/pcap/_obj/ -- -I $WORK/github.com/google/gopacket/pcap/_obj/ -I/home/mischief/local/include pcap.go
/usr/local/go/pkg/tool/openbsd_amd64/6c -F -V -w -trimpath $WORK -I $WORK/github.com/google/gopacket/pcap/_obj/ -I /usr/local/go/pkg/openbsd_amd64 -o $WORK/github.com/google/gopacket/pcap/_obj/_cgo_defun.6 -D GOOS_openbsd -D GOARCH_amd64 $
WORK/github.com/google/gopacket/pcap/_obj/_cgo_defun.c
gcc -I . -fPIC -m64 -pthread -fmessage-length=0 -print-libgcc-file-name
gcc -I . -fPIC -m64 -pthread -fmessage-length=0 -I $WORK/github.com/google/gopacket/pcap/_obj/ -I/home/mischief/local/include -o $WORK/github.com/google/gopacket/pcap/_obj/_cgo_main.o -c $WORK/github.com/google/gopacket/pcap/_obj/_cgo_main
.c
gcc -I . -fPIC -m64 -pthread -fmessage-length=0 -I $WORK/github.com/google/gopacket/pcap/_obj/ -I/home/mischief/local/include -o $WORK/github.com/google/gopacket/pcap/_obj/_cgo_export.o -c $WORK/github.com/google/gopacket/pcap/_obj/_cgo_ex
port.c
gcc -I . -fPIC -m64 -pthread -fmessage-length=0 -I $WORK/github.com/google/gopacket/pcap/_obj/ -I/home/mischief/local/include -o $WORK/github.com/google/gopacket/pcap/_obj/pcap.cgo2.o -c $WORK/github.com/google/gopacket/pcap/_obj/pcap.cgo2
.c
gcc -I . -fPIC -m64 -pthread -fmessage-length=0 -o $WORK/github.com/google/gopacket/pcap/_obj/cgo.o $WORK/github.com/google/gopacket/pcap/_obj/_cgo_main.o $WORK/github.com/google/gopacket/pcap/_obj/_cgo_export.o $WORK/github.com/google/g
opacket/pcap/_obj/pcap.cgo2.o http://github.com/google/gopacket/pcap/_obj/pcap.cgo2.o -L/home/mischief/local/lib
github.com/google/gopacket/pcap
/tmp/go-build313270947/github.com/google/gopacket/pcap/_obj/pcap.cgo2.o(.text+0x73) http://github.com/google/gopacket/pcap/tmp/go-build313270947/github.com/google/gopacket/pcap/_obj/pcap.cgo2.o(.text+0x73): In function _cgo_c663009e3544_Cfunc_pcap_activate': : undefined reference to pcap_activate'
/tmp/go-build313270947/github.com/google/gopacket/pcap/_obj/pcap.cgo2.o(.text+0x9e): In function _cgo_c663009e3544_Cfunc_pcap_can_set_rfmon': : undefined reference to pcap_can_set_rfmon'
/tmp/go-build313270947/github.com/google/gopacket/pcap/_obj/pcap.cgo2.o(.text+0xc9): In function _cgo_c663009e3544_Cfunc_pcap_close': : undefined reference to pcap_close'
/tmp/go-build313270947/github.com/google/gopacket/pcap/_obj/pcap.cgo2.o(.text+0x112): In function _cgo_c663009e3544_Cfunc_pcap_compile': : undefined reference to pcap_compile'
/tmp/go-build313270947/github.com/google/gopacket/pcap/_obj/pcap.cgo2.o(.text+0x145): In function _cgo_c663009e3544_Cfunc_pcap_create': : undefined reference to pcap_create'
/tmp/go-build313270947/github.com/google/gopacket/pcap/_obj/pcap.cgo2.o(.text+0x172): In function _cgo_c663009e3544_Cfunc_pcap_datalink': : undefined reference to pcap_datalink'
/tmp/go-build313270947/github.com/google/gopacket/pcap/_obj/pcap.cgo2.o(.text+0x19c): In function _cgo_c663009e3544_Cfunc_pcap_datalink_val_to_description': : undefined reference to pcap_datalink_val_to_description'
... rest is elided ...
—
Reply to this email directly or view it on GitHub
https://github.com/google/gopacket/issues/64#issuecomment-90126252.

ok, after some fuss, i got a git checkout of libpcap 1.6.2 to link, and @david415's honeyBadger is running on OpenBSD 5.6. thanks for the quick response. i'm unsure why the system libpcap doesn't work, i guess it could be old.

Unfortunately, libpcap doesn't have a version defined, so you kind of have
to guess what's available vs. not based on #ifdefs (see
https://github.com/google/gopacket/blob/master/pcap/pcap.go#L26).  In
short, it's a real pain to try to support new features while still being
backwards incompatible.  If you do think of a clever ifdef check I can do
to handle your initial problem, I'd love to hear it :)
On Mon, Apr 6, 2015 at 11:12 AM, Nick Owens<EMAIL_ADDRESS>wrote:

ok, after some fuss, i got a git checkout of libpcap 1.6.2 to link, and
@david415 https://github.com/david415's honeyBadger is running on
OpenBSD 5.6. thanks for the quick response. i'm unsure why the system
libpcap doesn't work, i guess it could be old.
—
Reply to this email directly or view it on GitHub
https://github.com/google/gopacket/issues/64#issuecomment-90159777.

hm, rather unfortunate since the two functions that are missing are 'pcap_free_datalinks' and 'pcap_offline_filter', which are just small wrapper functions. i am tempted to write a pcap_openbsd.go file, that has copied definitions of these functions, with maybe a special build tag to indicate if one is using the openbsd system pcap or not. but, perhaps that's too hacky and a better idea is to just report these missing functions to openbsd team and deal with a custom libpcap for a while.

Oh, actually free_datalinks/offline_filter is a particularly ornery case.
In libpcap 1.1.0, both were added, but no #define variables were.  So there
are no #ifdefs we can use to distinguish whether you're using libpcap
<1.1.0 vs >1.1.0.  In fact, I don't think we can be sure until 1.5.1 :(
On Mon, Apr 6, 2015 at 11:14 AM, Graeme Connell<EMAIL_ADDRESS>wrote:

Unfortunately, libpcap doesn't have a version defined, so you kind of have
to guess what's available vs. not based on #ifdefs (see
https://github.com/google/gopacket/blob/master/pcap/pcap.go#L26).  In
short, it's a real pain to try to support new features while still being
backwards incompatible.  If you do think of a clever ifdef check I can do
to handle your initial problem, I'd love to hear it :)
On Mon, Apr 6, 2015 at 11:12 AM, Nick Owens<EMAIL_ADDRESS>wrote:

ok, after some fuss, i got a git checkout of libpcap 1.6.2 to link, and
@david415 https://github.com/david415's honeyBadger is running on
OpenBSD 5.6. thanks for the quick response. i'm unsure why the system
libpcap doesn't work, i guess it could be old.
—
Reply to this email directly or view it on GitHub
https://github.com/google/gopacket/issues/64#issuecomment-90159777.

alright, i'll poke tech@ and see what they will do about it. linking to a custom libpcap suffices for now. thanks @gconnell :-)


Replaced unique_together with models.UniqueConstraint in TranslatableMixin

Django unique_together may be deprecated in the future. models.UniqueConstraint is recommended in Django documentation as a good replacement as it also offer more functionality. This pull request resolves this issue #11098
Please check the following:

[ ] Do the tests still pass?[^1]
[ ] Does the code comply with the style guide?

[ ] Run make lint from the Wagtail root.

[ ] For Python changes: Have you added tests to cover the new/fixed behaviour?
[ ] For front-end changes: Did you test on all of Wagtail’s supported environments?[^2]

[ ] Please list the exact browser and operating system versions you tested:
[ ] Please list which assistive technologies [^3] you tested:

[ ] For new features: Has the documentation been updated accordingly?

Please describe additional details for testing this change.
[^1]: Development Testing
[^2]: Browser and device support
[^3]: Accessibility Target

I would need to modify some tests so the checks can run successfully.

@lb- I have a test__migrations (wagtail.tests.test_migrations.TestForMigrations) failure. Not sure what to do. I can't find manage.py in wagtail.tests, so I am not sure whether create one to create the migration files for this test to be successful.
this is the specific error I am getting:

Traceback (most recent call last):
File "/home/danajayi/wagtail/wagtail/tests/test_migrations.py", line 63, in test__migrations
self.fail("Model changes with no migrations detected:\n%s" % migrations)

Sorry @Temidayo32  this is not my area of expertise, my guess is that there could be some cross database issues with using UniqueConstraint.
See the call outs linked under this section
https://docs.djangoproject.com/en/4.2/ref/models/constraints/#uniqueconstraint

Functional unique constraints have the same database restrictions as Index.expressions.

https://docs.djangoproject.com/en/4.2/ref/models/indexes/#django.db.models.Index.expressions - then says there are some restrictions.
But that could be wrong, there may be something else going on here.

@lb- Hmmm, this is interesting. Thanks for pointing out that aspect of the docs. But it is a little surprising functional Uniqueconstraint might be up against some cross database restrictions. Because the docs also points out unique_together might be deprecated and be replaced by UniqueConstraint.
As regards the failed checks, they aren't a result of the restrictions, that's if there is any. They are actually a result of the tests written by Wagtail for the database. Currently, there are two test failures. Locally, I have fixed one of them. The second has to do with the tests_migration. The test is setup to throw error if there are model changes and there aren't any migration for them yet. Since I modified TranslatableMixin and changed some of its attributes, new migrations need to be made. Unless the migrations are made, the error would remain.

The main thing here is we want to handle both unique_together and UniqueConstraint as can't guarantee what existing implementations will use

@zerolab Yeah, I thought of doing that too. Better still, let me just do that. Initially, I thought it might be unnecessary duplication.

@zerolab Yeah, I have done that (I mean added back unique_together). But since I added a new attribute to the model which is UniqueConstraint the migration test still won't pass. Any idea on how to proceed with that?

@laymonage I have made the requested changes. I  I have made the suggested change above. But I am aware this would cause a failing test with the migration, partcularly, wagtail.tests.test_migrations.TestForMigrations. test__migration, since I would now have to define constraints in the meta class . Let me know if you want me to create the necessary migration files. I haven't done that yet since my most recent changes haven't been reviewed yet. Thanks so much.

@laymonage I added 3 new tests. The third test is the one you were considering we add. This:

Now I'm wondering whether we should also test when both are used 🤔 We don't want developers to do this, so maybe it's worth adding the check.

Let me know if there is anymore correction to be made. Thanks.

@laymonage Thanks so much for helping with this PR. I really appreciate!


Web and Load Test test support in Azure DevOps

Other MSDN pages are listing that Visual Studio 2019 will be the last version to support Performance and Load test projects. Downloading DevOps web tests created in the browser produces a project of this type. What's the long term roadmap here? Difficult to commit to these if there's a limited lifespan.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 6e19f646-d820-7582-0672-e5d3b3fe8966
Version Independent ID: 37f94f23-23bb-3306-840a-1291ca0e66b5
Content: Load test before release - Azure Test Plans
Content Source: docs/test/load-test/run-performance-tests-app-before-release.md
Product: devops
GitHub Login: @alexhomer1
Microsoft Alias: ahomer

Thank you for your feedback. I will pass this on to the product team and update the topic based on their response.

https://devblogs.microsoft.com/devops/cloud-based-load-testing-service-eol/

@cytron201 - we blogged about the deprecation of the service early this year. You can find the blog post at https://devblogs.microsoft.com/devops/cloud-based-load-testing-service-eol/


Why the need for "utils.Buffer"?

[Please label this as "question" :-)]
I was just curious, why was the Buffer type in package utils written? If I am not mistaken, it looks like the standard bytes.Buffer type, along with the binary.Read and binary.Write functions, would provide the same functionality? Or is it for reasons of performance?

Your guess is correct. The binary.Write method allocates memory whereas our buffer implementation does not.


JQPlay site busted

I'm sorry to say (because I use it), the site is up but not responding with the proper web code.

I can confirm this as well. I'm on Brave Browser Version 1.0.1 Chromium: 78.0.3904.108 (Official Build) (64-bit). Below is a screenshot of what I see, even with Brave's shields down.

@geofffox can we close it this out? The site is working for me.
https://jqplay.org/

Thank you, Owen.
Geoff
On Mon, Dec 18, 2023 at 9:47 PM Owen Ou @.***> wrote:

Closed #95 https://github.com/owenthereal/jqplay/issues/95 as completed.
—
Reply to this email directly, view it on GitHub
https://github.com/owenthereal/jqplay/issues/95#event-11284988969, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AA5MGNOSOSBKUVUHDECCUFLYKETARAVCNFSM4JX73SOKU5DIOJSWCZC7NNSXTWQAEJEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW4OZRGEZDQNBZHA4DSNRZ
.
You are receiving this because you were mentioned.Message ID:
@.***>


Update AppStream Repo for CentOS 8

CentOS 8 is now EOL, so moving to vault for now.
Signed-off-by: Sai Sindhur Malleni<EMAIL_ADDRESS>Description
Fixes

@smalleni did you check the new centos stream to see if they have the required packages? http://mirror.centos.org/centos/8-stream/AppStream/x86_64/os/ . It looks like it should be a 1-to-1 swap but i haven't tested it personally.

@smalleni did you check the new centos stream to see if they have the required packages? http://mirror.centos.org/centos/8-stream/AppStream/x86_64/os/ . It looks like it should be a 1-to-1 swap but i haven't tested it personally.

It would be easy to move the repo over the CentOS stream, but untilwe upgrade the operator image itself, I'd much rather use the exact 1x1 RPMs in the same old repos we were using. This change essentially makes us use what we were using earlier. Moving to stream could potentially introduce newer packages.

@smalleni did you check the new centos stream to see if they have the required packages? http://mirror.centos.org/centos/8-stream/AppStream/x86_64/os/ . It looks like it should be a 1-to-1 swap but i haven't tested it personally.

It would be easy to move the repo over the CentOS stream, but untilwe upgrade the operator image itself, I'd much rather use the exact 1x1 RPMs in the same old repos we were using. This change essentially makes us use what we were using earlier. Moving to stream could potentially introduce newer packages.

Yes it could add newer packages, etc but that is exactly like it was before it was EOLd. Updates come out, etc. If you want to remain on a static set of rpms thats one thing but if we want to treat it like it was before I'd argue it should go to the stream release. Not saying one way is more correct than the other.

@smalleni did you check the new centos stream to see if they have the required packages? http://mirror.centos.org/centos/8-stream/AppStream/x86_64/os/ . It looks like it should be a 1-to-1 swap but i haven't tested it personally.

It would be easy to move the repo over the CentOS stream, but untilwe upgrade the operator image itself, I'd much rather use the exact 1x1 RPMs in the same old repos we were using. This change essentially makes us use what we were using earlier. Moving to stream could potentially introduce newer packages.

Yes it could add newer packages, etc but that is exactly like it was before it was EOLd. Updates come out, etc. If you want to remain on a static set of rpms thats one thing but if we want to treat it like it was before I'd argue it should go to the stream release. Not saying one way is more correct than the other.

But 8-stream is like saying it could be 8.5. or 8.6 . I won't pretend like I know everything about stream but IMHO getting updated RPMs for Fedora 34 for a  package is different from getting the same package for Fedora 35 right? Kind of applying that logic here. Let Raul and others weight in, I'm not married to any particular way of doing this.

@smalleni did you check the new centos stream to see if they have the required packages? http://mirror.centos.org/centos/8-stream/AppStream/x86_64/os/ . It looks like it should be a 1-to-1 swap but i haven't tested it personally.

It would be easy to move the repo over the CentOS stream, but untilwe upgrade the operator image itself, I'd much rather use the exact 1x1 RPMs in the same old repos we were using. This change essentially makes us use what we were using earlier. Moving to stream could potentially introduce newer packages.

Yes it could add newer packages, etc but that is exactly like it was before it was EOLd. Updates come out, etc. If you want to remain on a static set of rpms thats one thing but if we want to treat it like it was before I'd argue it should go to the stream release. Not saying one way is more correct than the other.

But 8-stream is like saying it could be 8.5. or 8.6 . I won't pretend like I know everything about stream but IMHO getting updated RPMs for Fedora 34 for a package is different from getting the same package for Fedora 35 right? Kind of applying that logic here. Let Raul and others weight in, I'm not married to any particular way of doing this.

So there's nothing in the old line "http://mirror.centos.org/centos/8/AppStream/x86_64/os/" that indicates a version so its the same thing unless I'm missing something. That said, it's really not a big deal to me either way.


Pad lines before parsing PDB

Some of our "golden data" is in the incorrect format, missing some spaces in the end;
This line was too short to parse the expected data field (at 76 to 78)
, InvalidatingError: Line too short
    ╷
190 │ ATOM    311  O1P  DT B  32      -7.080   5.978  23.824  1.00  0.00      B
    ·                                                                         ────
    ╵

This can be fixed by padding the lines

Maybe it's possible to use the pdb-handler


[ENG-670] fix: create for osfNestedResource

Purpose
The create action for osfNestedResource is not working properly. Namely, it does not connect the nested child resource it creates to the parent resource. This is because the default handler for post in mirage doesn't know to connect the resource it creates to the parent. This PR fixes this by implementing a custom handler function for post in osfNestedResource that creates the child and then connects it to the parent.
Summary of Changes
Fixed

Mirage

osfNestedResource - added custom post handler to fix create action

Side Effects
None expected.
Feature Flags
n/a
QA Notes
No QA needed.
Ticket
https://openscience.atlassian.net/browse/ENG-670
Reviewer Checklist

[ ] meets requirements
[ ] easy to understand
[ ] DRY
[ ] testable and includes test(s)
[ ] changes described in CHANGELOG.md

Pull Request Test Coverage Report for Build 3238

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 75.884%

Totals

Change from base Build 3236:
0.0%

Covered Lines:
7231

Relevant Lines:
8345

💛  - Coveralls


Commit contribution is zero

I see "0 contributions for the year"
for all users, despite recent commits and commits going back years.
Tested in Chrome and Edge
Screenshots

Work Items appear fine.

I see "0 contributions for the year" for all users, despite recent commits and commits going back years.
Tested in Chrome and Edge Screenshots
Work Items appear fine.

Here the pullrequests and changests ones are also not working. Only work items yields results.


Warning RZ10012 occurs on getting started example

I followed the "Getting started" example "Creating basic tests in .razor files".
The test works, but I'm getting follow warning:
RZ10012	Found markup element with unexpected name 'Counter'. If this is intended to be a component, add a @using directive for its namespace.
The Test class is testing the standard Counter component:
@attribute [TestClass]
@inherits BunitTestContext
@code  {

    [TestMethod]
    public void TestCounterHasHeaderR() {
        // Act
        var cut = Render(@<Counter />);

        // Assert: whitespaces are ignored
        cut.MarkupMatches(
            @<text>

Counter

Current count: 0

                <button class="btn btn-primary">Click me</button>
            </text>
        );
    }
}  // <= the warning RZ10012 accours here (green underline)

The _Imports.razor file has an using reference to the Counter namespace
@using Microsoft.AspNetCore.Components.Forms
@using Microsoft.AspNetCore.Components.Web
@using Microsoft.JSInterop
@using Microsoft.Extensions.DependencyInjection
@using AngleSharp.Dom
@using Bunit
@using Bunit.TestDoubles

@using BlazorApp
@using BlazorApp.Pages
@using Microsoft.VisualStudio.TestTools.UnitTesting

Versions (all newest):

net6.0 preview 6.0.100-rc.1.21463.6
Windows 10  21H1
Visual Studio 2022 Preview 4.1
bUnit 1.2.49

After restarting Visual Studio 2022, the warning is gone.
There is may be a problem with the razor parser in VS 2022.
But thanks a lot for your great and fast help and also for bUnit it self !!!


Validator improvements.

Summary
Validator improvements:

Add retry count to error results.
Add early exit to retry loop when the rounds are equal.

Test Plan

Codecov Report

Merging #569 (5a54138) into develop (8980d9e) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop     #569   +/-   ##
========================================
  Coverage    46.39%   46.39%
========================================
  Files           24       24
  Lines         3899     3899
========================================
  Hits          1809     1809
  Misses        1818     1818
  Partials       272      272

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8980d9e...5a54138. Read the comment docs.


conda not deactivating properly

There is some problem deactivating the fermi conda environment.  After deactivating, I still have that python on my path. See:
% which python
/usr/bin/python

% conda activate fermi-2.2.0

(fermi-2.2.0) % which python
/Software/miniconda3/envs/fermi-2.2.0/bin/python

(fermi-2.2.0) % conda deactivate

% which python
/Software/miniconda3/envs/fermi-2.2.0/bin/python

But for my other conda environments, it works fine.
% conda activate hese

(hese) paulr@hesenode1:~ % which python
/Software/miniconda3/envs/hese/bin/python

(hese) paulr@hesenode1:~ % conda deactivate

paulr@hesenode1:~ % which python
/usr/bin/python

Is there something about the fermi tools that is making this not work?

It looks like PATH environment variable is not getting reset after deactivation. I assume it's an issue with the Fermitools's activate/deactivation scripts.  I've assigned it to @jasercion to look into.  In the meantime, you should probably be able to source your .bashrc file (or whatever is appropriate for you shell) to reset the PATH variable.


docs: Use '.' separator syntax in JSDoc @links (#11)

Additionally, use IEventEmitter in @links rather than EventEmitterMixin.
The documentation for IEventEmitter contained references to
EventEmitterMixin, but it should be referencing itself (IEventEmitter).

Coverage remained the same at 100.0% when pulling 5e1a8551ddc3dba4b67d33e2435975ecd73ce42f on yokuze:yokuze/fix_jsdoc_link_member_syntax_11 into 32e131f9803d9491618ee2bf0639add005ccb883 on silvermine:master.


Fix assertion failure during chat session.

This fixes the following assert that is easy to repro in any chat session:
Traceback (most recent call last):
    File "/home/ubuntu/cali/torchchat/torchchat.py", line 69, in <module>
        generate_main(args)
    File "/home/ubuntu/cali/torchchat/generate.py", line 896, in main
        for _ in gen.chat(generator_args):
    File "/home/ubuntu/cali/torchchat/generate.py", line 748, in chat
        self.chat_formatter.encode_header(
    File "/home/ubuntu/cali/torchchat/generate.py", line 53, in encode_header
        tokens.extend(self.tokenizer.encode(role, bos=False, eos=False))
    File "/home/ubuntu/cali/torchchat/tokenizer/tiktoken.py", line 133, in encode
        assert type(s) is str

I believe this regressed with https://github.com/pytorch/torchchat/pull/1035.

Thanks for flagging and fixing @prideout !


Deprecation Warnings/Errors

Just noticed in a project that we were using some deprecated code and this was only caught by vscode when I visited the file. We should probably have something which lets us know if something is being deprecated so we can move off it early especially when we're bumping up packages or node versions. I know we don't use warnings here but perhaps it might be worth setting up an eslint plugin for this to set as an error?
https://github.com/gund/eslint-plugin-deprecation

Going to close this as I believe it should be handled within typescript. Performance is too poor
https://github.com/microsoft/TypeScript/issues/47382


test: a simple bump

Codecov Report

Merging #32 (5aed161) into main (9e71677) will not change coverage.
The diff coverage is n/a.

:exclamation: Current head 5aed161 differs from pull request most recent head 15a1bed. Consider uploading reports for the commit 15a1bed to get more accurate results

@@           Coverage Diff           @@
##             main      #32   +/-   ##
=======================================
  Coverage   94.74%   94.74%
=======================================
  Files          48       48
  Lines        6931     6931
  Branches      450      450
=======================================
  Hits         6567     6567
  Misses        364      364

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Level always reported as [info] in logs

I noticed that even though I set the logs to different levels, they always are shown at the info levels. For instance:
EVLOG_verbose << "verbose boop!";
EVLOG_debug << "debug boop!";
EVLOG_info << "info boop!";
EVLOG_warning << "warning boop!";

prints out as
[2024-05-17 17:32:31.427336] [0x0000ffff81207cc0] [info]    verbose boop!
[2024-05-17 17:32:31.427351] [0x0000ffff81207cc0] [info]    debug boop!
[2024-05-17 17:32:31.427352] [0x0000ffff81207cc0] [info]    info boop!
[2024-05-17 17:32:31.427354] [0x0000ffff81207cc0] [info]    warning boop!

Can you share some code and your logging.ini?

This might happen if you do not call Everest::Logging::init() before you start to log using the EVLOG macros


fix: unable to get quotes for weth

Description

Pull Request Type

[ ] :bug: Bug fix (Non-breaking Change: Fixes an issue)
[ ] :hammer_and_wrench: Chore (Non-breaking Change: Doc updates, pkg upgrades, typos, etc..)
[ ] :nail_care: New Feature (Breaking/Non-breaking Change)

Issue (if applicable)

closes #
Risk

Testing

Engineering

Operations

Screenshots (if applicable)

Current dependencies on/for this PR:

develop

PR #5931   👈

This stack of pull requests is managed by Graphite.


Deploy a CAP Business Service to SAP Business Technology Platform

Tutorials: https://developers.sap.com/tutorials/cap-service-deploy.html
I followed the tutorial and deployed the application on my trial sub-account. After the deployment I noticed that 2 new applications appear in my space:

my-bookshop-srv
my-bookshop-db-deployer

When I try to delete some of them, the corresponding application remains in status STOPPED.
The deletion is not possible neither from BTP Cockpit nor via cf CLI tool.

c


Revert "Enable and test high bit depth input (#437)"

This reverts commit 8c5453501423ff67f9d973a2a1cc1df7e24e02b2.
Since 8c5453501423ff67f9d973a2a1cc1df7e24e02b2 has broken encoder, causing desync (in 1st frame) btw enc and dec for the test:
./target/release/rav1e nyan.y4m -o test.ivf -r test_rec.y4m --quantizer=10 --speed=0 --limit=5

Travis is supposed to test for this, but it appears the Travis test is busted somehow.  Agreed with revert policy until it is fixed. r=me

Well, the travis test uses different content. Something about that content causes this not to trigger.

Yes, the decode_test uses random images, not from input files?


Write tests for commands

We have two custom Django commands that are untested, both in  jarbas/core/management/commands/:

loaddatasets.py
loadsuppliers.py

Maybe a quick way to do it is to mock a CSV responde with a few records, call the command ([check test_static_files.py) and assert records form the mocked CSV is in the database.
But surely unit tests would be welcomed too ; )

Closed by d500755


Surefire Plugin mentioned twice

[WARNING]
[WARNING] Some problems were encountered while building the effective model for de.zalando.pazuzu:pazuzu-registry:jar:1.1.2-SNAPSHOT
[WARNING] 'build.plugins.plugin.(groupId:artifactId)' must be unique but found duplicate declaration of plugin org.apache.maven.plugins:maven-surefire-plugin @ line 200, column 21
[WARNING]
[WARNING] It is highly recommended to fix these problems because they threaten the stability of your build.
[WARNING]
[WARNING] For this reason, future Maven versions might no longer support building such malformed projects.
[WARNING]

I'm closing this one as it's already merged.


Refactor

[ ] english comments
[ ] more readable code

Thank you for your job. English comments will be really helpful.


Use encoding reported by camera driver

I use a RealSense D455, which encodes the colors in RGB8 instead of BGR8. As the reported encoding string from sensor_msgs::Image is the same used in cv_bridge, this string can just be used.
I did not put a check in to keep the camera call back fast.
The strings from include/sensor_msgs/image_encodings.h that is also accepted by cv_bridge:
"mono8"
"bgr8"
"bgra8"
"rgb8"
"rgba8"
"mono16"

Thanks for your contribution. I'll check with my colleague.

Looks great @kdhansen! Thanks

I also meet this problem!
when i training,the picture's format is rgb8. when i test the weights that i trained using bag,the colors of pictures in windows(yolo_v4) is different from my training pictures.
i also changed BGR8 to RGB8 in YoloObjectDetector.CPP, but the colors in window(yolo_v4) didn't change!
how did you handled this problem?