plots for paper

For each classifier,  a grid of violin plots like this: https://seaborn.pydata.org/examples/grouped_violinplots.html
one row per MIA metric, a item on x-axis per structural attack metric, metric values on y-axis and the violins split according to the  binary values of the structural metric

if that's not possible because o f the way needed to do the grouping, make it a x-axis item per MIA metric and one row per structural measure with violins split according to structural risk metric value, and don't discriminate between datasets.

Some questions for @jim-smith and @albacrespi :

How should we summarise these results over repetitions? Take the mean?
There are NaNs in the structural metrics. Is this expected? How is it best to deal with them?

Ignore question 2 above, worked it out. Structural scores are only there for Structural Scenario

Ok, stopping for today, but seems ok to get something like this (for D-tree)

@jim-smith we also have dataset -- do you want one grid per classifier x dataset combo? I think I can get that done pretty quickly

Current effort, this is for DTREE, which probably has the least interesting results:

Each row is an attack metric (I picked four)
Each column is a structural metric
Within each plot there isd one column per dataset
Each violin plot is split on the structural value

Here's xgboost...but there's maybe an issue here...all structural values are 1 always...(hence the lack of the second violin anywhere)

Easier to see version of DTree:

And here's DTree for LIRA, which looks quite interesting. Note that the green viuolin is where structural risk metric value = 1 and black is zero

So, to summarise:

Each large grid is for a single classifier and a single attack scenario (e.g. WorstCase / lira)
Each row is an attack metric (I picked four, but easy to include whatever)
Each column is a structural metric
Within each plot there is one pair of violins (although you won't always see 2) for each dataset
The green violin is for all examples where the structural metric value is 1, black for zero.
So, e.g. in the plot above, in second row down and second column from the left, we can see a pretty consistent pattern that the attach metric (y-axis) is consistenly higher when the structural value is 1.
Caution -- the bottom two rows are binary metrics (is the AUC and FDIF significant at 5%), hence the uniform shapes.
Caution 2 -- I think the area of the violin will be proportional to the number of observations but I'm not 100% sure. E>g. row 3 column 3, the area within the black violin >> the area within the green, which makes me think it's normalised like this. i.e. it tells us a bit about how common different structural values are.

Going to leave it for now -- send feedback. I can download and analyse any other results if you're interested.

Ah-ha! so their are clearly cases (with spikes) where a given value for a structural metric is associated with all the MIA risk metric scores being the same.
Looking at the LIRA-DT plot, bearing in mind that the 'k-anonymity is directly related to leaves here for this simple model
So k anonymity is not related to anything
DoF risk is related to FDIF and AUC
Class disclosure risk does seem to be quite strongly associated with FDIF and AUC but also someofthe other metrics as well
and
'unnecessary risk' is associated with other MIA risk metrics - as to be expected as it is derived from AUC

I reproduced Simon's plots with the new results for RF and DT (lira).

And for Worst Case scenario:


Document the use of BrainGlobe tools on the SWC HPC system

Linked to https://github.com/brainglobe/brainglobe.github.io/issues/130
The HPC module will also need to be updated to BG v1 too.

For reference, here is the old brainmapper info:

Using brainmapper at the SWC
N.B. Before starting to use brainmapper on the SWC, you should familiarise yourself with the job scheduler system (SLURM).
:::{hint}
This information refers to using brainmapper for cell detection and registration, but any of the BrainGlobe command-line tools (e.g. training brainmapper, or running only registration with brainreg) can be used similarly.
:::
Interactive use
On the SWC cluster, no software needs to be installed, as brainmapper can be loaded with module load brainglobe.
brainmapper can be used interactively, by starting an interactive job:
srun -p gpu --gres=gpu:1 -n 20 -t 0-24:00 --pty --mem=120G bash -i

Loading brainmapper:
module load brainglobe

And then running brainmapper as per the User guide.
Batch processing
It is recommended to use brainmapper by using the batch submission system.
This has many advantages:

Your analysis is reproducible: you have a script showing exactly what you did.
You don't need to wait for computing resources to become available: once submitted, the job will wait until it can be run.
If for any reason the analysis is interrupted, you can easily restart.
You don't need to keep a connection to the cluster open.
You can easily receive email updates when the job starts and finishes.

An example batch script is given below, but it is recommended to familiarise yourself with the batch submission system before trying to optimise brainmapper.
#!/bin/bash

#SBATCH -p gpu # partition (queue)
#SBATCH -N 1   # number of nodes
#SBATCH --mem 120G # memory pool for all cores
#SBATCH --gres=gpu:1
#SBATCH -n 10
#SBATCH -t 1-0:0 # time (D-HH:MM)
#SBATCH -o brainmapper.out
#SBATCH -e brainmapper.err
#SBATCH --mail-type=ALL
#SBATCH<EMAIL_ADDRESS>
cell_file='/path/to/signal/channel'
background_file='path/to/background/channel'
output_dir='/path/to/output/directory'

echo "Loading brainglobe environment"
module load brainglobe

echo "Running brainmapper"
# Just an example. See the user guide for the specific parameters
brainmapper -s $cell_file -b $background_file -o $output_dir -v 5 2 2 --orientation psl


Enable export for class-based resources

Summary of the new feature / enhancement
Enable class-based resources to participate in DSCv3 export capability
Proposed technical implementation details (optional)
No response

The PowerShell adapter for DSCv3 is implemented to support export for PSDSC Resources when the resource has a static Export method that takes no parameters and returns an array of the PSDSC Resource class.
https://github.com/PowerShell/DSC/blob/0157276b2ada32da5859ce930f4cae2e592f586c/powershell-adapter/psDscAdapter/psDscAdapter.psm1#L296-L301
Following is an example signature for the Export method, using MyDscResource as the class name:
static [MyDscResource[]] Export() {
    # Code to return the array of all instances for the resource
}

@michaeltlombardi Will the DSCv3 implementation support parameters in the future? I guess the PR on VSCodeExtension in the winget-dsc repository broke the participation now.

@michaeltlombardi Will the DSCv3 implementation support parameters in the future?

It's possible - I don't think parameterized export is fully settled yet in general, but in that case I would expect the class-based resource to define the following static methods to fully implement the export capability:
[DscResourceClassName[]] Export() {
  return [DscResourceClassName]::Export($null)
}

[DscResourceClassName[]] Export([DscResourceClassName]$filterProperties) {
  # logic to get all instances and save in $instances
  if ($null -eq $filterProperties) {
    return $instances
  }
  # logic to filter instances
  return $instances
}


HTTP 406 Not Acceptable - SendGrid sending email

In our project we've started receiving these errors when trying to send any transactional email.

"\r\n406 Not Acceptable\r\n\r\n406 Not Acceptable\r\nnginx\r\n\r\n\r\n"

The params we send:

%{"content" => [%{"type" => "text/plain", "value" => "some text value email."}, %{"type" => "text/html", "value" => "some html..." <> ...}], "from" => %{"email" =><EMAIL_ADDRESS>"name" => "Team Papa"}, "key" => "[FILTERED]", "personalizations" => [%{"to" => [%{"email" =><EMAIL_ADDRESS>"subject" => "Reset your password"}

Did a Sendgrid API change break this package?

We're still seeing these HTTP 406 errors randomly.

Thanks for opening this @sergiotapia-papa. I wonder if others are seeing similar errors? Is there any more info you can provide about how to reproduce this error? I'm not sure I have much to go on.

I'm going to create a custom strategy to log more information about the error and try to find a common thread.

Thank you! That would be so helpful.

I'm still getting these errors and the custom strategy isn't giving any further information.
There was a problem sending the email through the SendGrid API.

Here is the response:

"\r\n<title>406 Not Acceptable</title>\r\n\r\n
406 Not Acceptable
\r\n
nginx\r\n\r\n\r\n"

Here are the params we sent:

%{"from" => %{"email" =><EMAIL_ADDRESS>"key" => "[FILTERED]", "personalizations" => [%{"dynamic_template_data" => %{"client_name" => "sergiotest", "date_of_birth" => "2020-07-27T21:26:50.019Z", "description" => "sergiotest please ignore.", "location" => "sergiotest", "member_id" => "sergiotest", "member_name" => "sergiotest", "name_of_pal" => "sergiotest", "requester" => "sergiotest", "type" => "theft", "visit_date" => "2020-07-27T21:26:50.019Z"}, "to" => [%{"email" =><EMAIL_ADDRESS>"template_id" => "d-a3469d2af1934877777772d95e3e02fd"}

I'll need to reach out to sendgrid.

Thanks for keeping us informed @sergiotapia-papa! Let me know if Sendgrid is able to help.

@germsvel we needed to upgrade the bamboo package as a PR added the application/json header to the sendgrid strategy. Weird how some emails went through and some didn't though, on sendgrid's side.

Thanks so much for digging into it and letting us know the cause for those errors @sergiotapia-papa! Glad you got it resolved.

@germsvel  @sergiotapia-papa hey, I am still getting the same error after updating deps as well. I am using {:bamboo, github: "thoughtbot/bamboo"} in deps and putting the header like this:  email |> put_header("accept", "application/json")
Am I doing anything wrong?

@jatin759 I reopened this, but I'm not sure how else to help.
I think the PR @sergiotapia-papa mentioned was  https://github.com/thoughtbot/bamboo/pull/529, where Bamboo added that header to the Sendgrid adapter. So, you might not need to add the put_header("accept", "application/json") if you're using a version of Bamboo that includes that commit.
Can you provide any other info about the error you are seeing? What version of bamboo do you have in your mix.lock file?

That is correct, we just had to upgrade the package and that fixed it for us.

@jatin759 do you have any other information that might help us resolve this? Otherwise, it seems like the issue might be resolved by updating to the version of bamboo that has the correct headers.

@germsvel yes the issue has been resolved for now without making any changes that I mentioned while reopening this issue. I  am afraid if this may again come. Let's see how it goes.
Thanks @sergiotapia-papa @germsvel

Sounds good! Let us know if this comes up again. For now, I'll close this issue.


{CI} New issue template for reference doc's feedback

This PR replaces #30083

We need an additional GitHub issue template in azure-cli for customer feedback that is recieved on autogenerated reference docs. This template aligns with the Azure PowerShell template found here: https://github.com/Azure/azure-powershell/blob/main/.github/ISSUE_TEMPLATE/4-AZ-DOC-BUG.yml.
Anytime a customer uses the docs or product feedback links in MicrosoftDocs/azure-docs-cli WHEN IN AN AUTOGENERATED REFERENCE DOC, they will be taken to this new template. This will keep MicrosoftDocs/azure-docs-cli GitHub issues about conceptual content, and reference feedback is channeled correctly to the engineering teams.
MicrosoftDocs/azure-docs-cli PR 4788 is waiting on this PR to merge.

Thank you for your contribution! We will review the pull request and get back to you soon.


Add any information for repeatable words

Something like that:

That's one of the points in #2 , but maybe it makes sense to split that case into several independent ones using original case as an umbrella for several tasks

I don't particularly like the idea of allowing repetitive words in the list, so instead of that upon an attempt to enter existing word I'll move such a word at the top of the list and add shaking animation for it

I don't particularly like the idea of allowing repetitive words in the list, so instead of that upon an attempt to enter existing word I'll move such a word at the top of the list and add shaking animation for it


Add SuperGLUE leaderboard submission prediction formatter functionality

This PR is motivated by issue https://github.com/jiant-dev/jiant/issues/108. If these changes are acceptable, similar changes can be made to support the other tasks (GLUE and XTREME).

5b77da3 updates MultiRC's _create_examples to include all the identifiers necessary for SuperGLUE leaderboard submission.
bee8fae adds a SuperGLUE leaderboard submission formatter method to the MultiRC task class (super_glue_format_preds()).
84bf144 adds a new script that loads the raw predictions for the SuperGLUE tasks, calls the tasks' super_glue_format_preds() methods, and saves the results with the filenames expected by the leaderboard.

Note: superglue_leaderboard_submission_formatter.py leaves placeholder for broadcoverage diagnostic and Winogender schema diagnostic tasks because they're not yet implemented.

@pyeres Implementation approach looks good to me

@pyeres Implementation approach looks good to me

Thanks for the look, @jeswan — I plan to keep this PR open as a draft while I add formatters to the other SuperGLUE tasks (w/ commits like 3ba6cfc for RTE).

At this point 7 out of 10 SuperGLUE tasks have SuperGLUE leaderboard submission formatters. Status for remaining 3:

record: issue #51 said implementation/scoring was incomplete, PR #77 contributed fixes to example creation and tested the task end to end. Currently labels/predictions from this task are not in the expected format (they are bool, where the SuperGLUE leaderboard expects the prediction to be a string span).
superglue_broadcoverage_diagnostics: not yet implemented.
superglue_winogender_diagnostics: this task implementation has been submitted for review by @jeswan.

After SuperGLUE leaderboard submission formatters are added for these 3 tasks, we'll need to perform test submissions to the SuperGLUE leaderboard.

record: issue #51 said implementation/scoring was incomplete, PR #77 contributed fixes to example creation and tested the task end to end. Currently labels/predictions from this task are not in the expected format (they are bool, where the SuperGLUE leaderboard expects the prediction to be a string span).

Capturing notes from offline discussion with @zphang and @jeswan:

Currently ReCoRD bypasses ReCordEvaluationScheme (and uses AccAndF1EvaluationScheme instead).
ReCoRD's ReCordEvaluationScheme is written assuming that it can access the example data required for preds, however this data is not currently accessible (without retrieving it from the cache which is not currently supported without a refactor).
Some workarounds were discussed where the superglue_leaderboard_submission_formatter.py script could share responsibility with the ReCordEvaluationScheme for generating predictions.
Meeting conclusion: a wider refactor (rather than a workaround) is preferred, and ownership of the PR will be turned over to @jeswan.

Changes implemented with https://github.com/jiant-dev/jiant/pull/145.


Can I Filter Files During Multi-File Query?

I have a folder containing .parquet files. The schemas of the files are the same, and the file names are distinguished by timestamp.
The SQL statement, select * from table where timestamp<PHONE_NUMBER>000 and<PHONE_NUMBER>000, takes a long time for query. I want to filter out the files that are not within the time range during query.
In other words, I want to use the multi-file query function, but filter out files whose timestamp is not within the query time range. Is it possible?

I think the solution here would be to implement a specialized version of https://docs.rs/object_store/latest/object_store/trait.ObjectStore.html#tymethod.list where a function can be passed to determine which files get selected (based on file names).
@tustvold WDYT?

So DataFusion has fairly mature support for predicate pruning such as you describe, in particular https://docs.rs/datafusion/latest/datafusion/physical_optimizer/pruning/struct.PruningPredicate.html.
Assuming the predicate is pushed down to the TableScan. The following should happen automatically.

If using ListingTable as the catalog, any non-matching partitions will be filtered out
If using ListingTable and enabled collect_stat the files will be pruned based on their metadata
ParquetExec will prune the row groups based on the filter

So at least theoretically, this should already be being performed. Perhaps you might be able to clarify:

Do you have an actual catalog, or are you using ListingTable. In particular what TableProvider are you using
Is your data partitioned at all? Is the TableProvider aware of this?
Do you have a catalog that can provide file-level metadata?

think the solution here would be to implement a specialized version of https://docs.rs/object_store/latest/object_store/trait.ObjectStore.html#tymethod.list where a function can be passed to determine which files get selected (based on file names).

To me this sounds like a quirk of a very specific kind of data catalog. We could potentially add some sort of support for file-name extraction to ListingTable, but it is unclear why this would be pushed down to ObjectStore.

I think this ticket is not tracking anything -- it is too bad it is not a discussion so it may not be easy to find. However, I don't think it is actionable at this time so closing it


Self-closing style tag is a syntax error

A self-closing <style /> element in a templ component is a parse error, instead of a self_closing_tag. With this additional test case:
===
Self closing script block
===

package main

templ Foobar() {
  <script src="/app.js" />
}

---

(source_file
  (package_clause
    (package_identifier))
  (component_declaration
    name: (component_identifier)
    (parameter_list)
    (component_block
      (self_closing_tag
        (attribute
          name: (attribute_name)
          value: (quoted_attribute_value
            (attribute_value)))))))

The test fails:
  1. Self closing script block:

    (source_file
      (package_clause
        (package_identifier))
      (component_declaration
        name: (component_identifier)
        (parameter_list)
        (component_block
<         (ERROR
>         (self_closing_tag
            (attribute
              name: (attribute_name)
              value: (quoted_attribute_value
                (attribute_value)))))))

I tried to go into the grammar and fix this, but... I don't understand why this fails :/
_component_node includes choices for element and script_element, and element defines self_closing_tag as a valid parse. So, my assumption was that tree-sitter would handle the ambiguity and discover the correct branch of the parse tree... but it seems to get fixated on parsing as a script_element, and never goes back to try a parse as element instead.
I assumed that maybe we need to add/modify the conflicts between tag_start and self_closing_tag, but if that's the problem then the generate phase should be failing with a conflict, instead of generating a parser that never explores the self_closing_tag option :/
Any ideas?

I took a quick look and I'm not sure either.
Self-closing tags that are not style or script seem to work fine, it could be there's something wrong in the scanner functions used to handle style_element_text, script_element_text or script_block_text; something like this already happened.
I'll look into it further.

Aah, good point. I don't know much about custom scanner functions in tree-sitter, but I guess it needs to return appropriate token/state info to the parser. I will also try to investigate in that direction a bit later, thank you for the info!

So, I spent a bit of time looking into it and I don't think it's related to the scanner.
By changing $.style_element to
        style_element: $ => seq(
            '<',
            'style',
            repeat($._attribute),
            '>',
            'foo',
            '</',
            'style',
            '>'
        ),

so that the scanner is not called, it doesn't work either, I still get an error.
Looking at the output from tree-sitter parse -D foo.templ and searching around, I'm thinking this is supposed to not work. I think I'll have to try to make a minimal reproducer.

This change "fixes" the problem https://github.com/vrischmann/tree-sitter-templ/commit/eb82739eee78510f70a83891ea39b91fe47bd5d0
but now it breaks a bunch of other unrelated tests because style_element doesn't get used.
I'm not sure if it's possible to fix it but we can work around the problem: we can simply make style_element and script_element handle self closing tags themselves; I've tested it and it works.


VPN role v2 (mesh encryption use case).

Includes subnet-to-subnet and opportunistic mesh use case as described in https://issues.redhat.com/browse/CRYPTO-3247

[citest bad]

[citest commit:dd33978fe5e8d9da1227d8ee9bd420bcc4221750]

hmm - problem on rhel-8/ansible-2.8 (staging): https://fedorapeople.org/groups/linuxsystemroles/logs/linux-system-roles-vpn-pull-linux-system-roles_vpn-12-dd33978-rhel-8-20210215-163219/artifacts/test.log.html
TASK [linux-system-roles.vpn : Apply the default policy as needed] *************
task path: /tmp/tmpkpqbf1dc/linux-system-roles.vpn/tasks/mesh_conf.yml:21
fatal: [/cache/rhel-8.qcow2]: FAILED! => {"msg": "ipaddr: unknown filter type: 999.999.999.999/32"}

Is this an ansible 2.9 feature?  please use only the features mentioned at https://docs.ansible.com/ansible/2.8/user_guide/playbooks_filters_ipaddr.html so that we can use the role with ansible 2.8

I see the problem - the ipaddr(cidr) doesn't like the value '999.999.999.999/32' - I guess it wants a valid IP address.
Is there such a thing as a valid IP address or CIDR value that is valid but cannot be used for a real deployment?
I think we can use some address in the link local range - https://www.tutorialspoint.com/ipv4/ipv4_reserved_addresses.htm - so try <IP_ADDRESS>/32

One consequence of this implementation is that if the user sets vpn_opportunistic: true and they have configuration like this:
    vpn_connections:
      - name: vpn-tunnel-x
        auth_method: cert
        auto: start
        hosts:
          bastion1.example.com:
            cert_name: bastion1cert
          bastion2.example.com:
            cert_name: bastion2cert
          bastion3.example.com:
            cert_name: bastion3cert

Then the code will try to set up vpn-tunnel-x as an opportunistic mesh tunnel.  I suppose you could say "don't do that" but there is no way to say "make the default mesh, but allow me to define host-to-host tunnels explicitly".

there is no way to say "make the default mesh, but allow me to define host-to-host tunnels explicitly".

I think that even if the "global" variable vpn_opportunistic is true, you can set opportunistic: false at the vpn_connection level to accomplish what you described:
    vpn_connections:
      - name: vpn-tunnel-x
        opportunistic: false
        auth_method: cert
        auto: start
        hosts:
          bastion1.example.com:
            cert_name: bastion1cert
          bastion2.example.com:
            cert_name: bastion2cert
          bastion3.example.com:
            cert_name: bastion3cert

Otherwise, yes, it would assume that you are trying to set up a mesh configuration. The only other way around this that I can think of is if we deliberately throw an error when the user specifies a list of hosts when opportunistic | d(vpn_opportunistic) is true. But then again it may turn out that in the future we might have a use for the hosts list in opportunistic tunnels, so that doesn't seem like a futureproof solution.

there is no way to say "make the default mesh, but allow me to define host-to-host tunnels explicitly".

I think that even if the "global" variable vpn_opportunistic is true, you can set opportunistic: false at the vpn_connection level to accomplish what you described:

ah - right - so there is a way to do it - I think that should be fine

Otherwise, yes, it would assume that you are trying to set up a mesh configuration. The only other way around this that I can think of is if we deliberately throw an error when the user specifies a list of hosts when opportunistic | d(vpn_opportunistic) is true. But then again it may turn out that in the future we might have a use for the hosts list in opportunistic tunnels, so that doesn't seem like a futureproof solution.

No, I think if the user sets vpn_opportunistic: true, then they will have to set opportunistic: false at the vpn_connection level - I think that's fine.

lgtm
@letoams can you take a look?

The issues is not really "in the same subnet" but the ansible machine IP being part of any of the mesh CIDRs for encryption.

Why do I see the use of 169.254/16 ? That's a really special case - I would never associate that with IPsec as it is basically a "crippled" IP address meaning you did not really manage to get an actual IP address via DHCP.

Why do I see the use of 169.254/16 ? That's a really special case - I would never associate that with IPsec as it is basically a "crippled" IP address meaning you did not really manage to get an actual IP address via DHCP.

It is for testing the "external" IP address case - basically, an IP address that is not resolvable externally - intentionally.  Something that corresponds to using a TLD like .local or .test

[citest commit:b847f841c870e87d532c8a2d977d53edaeb7ee7e]

[citest]

[citest bad]


Rename Additional Information section

User Story
As an applicant, I would like to see the "How did you hear about the vacancy?" so that I can answer the question "How did you hear about the vacancy?" during my application process.
History/context
Currently, we are revising the application form. There is a section named "Additional Information" which has a sub-page also named "Additional information". When an applicant clicks on the sub-page, it opens up a page: "How did you hear about the vacancy?" therefore we want the page title to reflect its content. We want to change the sub-page name to "How did you hear about the vacancy?"
Please make any corresponding changes on the admin side as appropriate
Estimate
XS
Visuals
Private Zenhub Image

Hey team! Please add your planning poker estimate with Zenhub @drieJAC @HalcyonJAC @tomlovesgithub


Add acl for alpine

FAIL: test_function (test.test_url_validity.TestUrlValidity)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/runner/work/rosdistro/rosdistro/test/test_url_validity.py", line 380, in test_function
    self.assertFalse(detected_errors)
AssertionError: ["In file '''/home/runner/work/rosdistro/rosdistro/humble/distribution.yaml''': Could not validate source entry for repo diagnostics with error [[[Could not validate repository with url https://github.com/ros/diagnostics.git and version ros2-devel from entry at line 944. Error reason: No branch found matching ros2-devel]]]", "In file '''/home/runner/work/rosdistro/rosdistro/humble/distribution.yaml''': Could not validate doc entry for repo diagnostics with error [[[Could not validate repository with url https://github.com/ros/diagnostics.git and version ros2-devel from entry at line 931. Error reason: No branch found matching ros2-devel]]]"] is not false


STYLE: Replace macro's in PoolMultiThreader by ExceptionHandling class

Replaces the macro's ExceptionHandlingPrologue, WrapExceptionHandling,
and ExceptionHandlingEpilogue by a class, ExceptionHandling, aiming
to improve code readability and maintainability.
Bradley @blowekamp encouraged pursuing such a "macro free" approach,
during the discussion following the merge of pull request #1434, "BUG:
Wait for all threads when abort or exception occurs".

The class looks a lot cleaner to me than macros.
I believe the original code kept and re-threw the original exception not the subsequent... It looks like it has gotten changed along the way. The first exception may be the reason the other exceptions occur ( like compilation errors ), so it may be important to keep the original behavior.

I believe the original code kept and re-threw the original exception not the subsequent... It looks like it has gotten changed along the way. The first exception may be the reason the other exceptions occur ( like compilation errors ), so it may be important to keep the original behavior.

@blowekamp Thanks for your suggestion. 😃  So what do you think of my force-push?

Looking at the code before (or even after) this PR, it appears that an exception is sometimes thrown between the m_ThreadPool->AddWork and the corresponding "future-get". Is that OK? Here (at the master branch):
https://github.com/InsightSoftwareConsortium/ITK/blob/bde411e2b40fc325d83c54f41a4e57faf3d7a88c/Modules/Core/Common/src/itkPoolMultiThreader.cxx#L266

Yes, that is an exception we want to throw here, because our assumptions are not satisfied. If that is thrown, something is horribly wrong.

Yes, that is an exception we want to throw here, because our assumptions are not satisfied. If that is thrown, something is horribly wrong.

So what would happen if some threads from m_ThreadInfoArray would still be running at that line of code?  Would they get aborted?

Assuming their data does not get deallocated, they would continue running until completion. Otherwise they would probably crash the program due to trying to access wrong memory.

Thanks @dzenanz. Another question: my PR does not explicitly distinguish between ProcessAborted exceptions and other exceptions. It just catches all of them and rethrows the first one. Is that OK? I'm just asking, to be sure 😃 Of course, the user may still catch ProcessAborted, if it has been rethrown.


Migrate to .NET Core 3.0

First phase of project. Migration.

[x] Migrate projects
[x] Application smoothly running

Migrate Projects :

Convert NuGet to PackageReferences
Convert .csproj
Rename the namespace

Application smoothly running :
Encoding.GetEncoding(1252) raised an exception.
The solution was to add the NuGet package System.Text.Encoding.CodePages and to initialize it in the Main method of Program.cs
During the check, many exceptions were raised. I found a lot of try/catch with int.Parse()
I replaced most of them by the method int.TryParse


missing typings

Hi @LonelyCpp, thank you for this module.
I got an issue with typings while importing the package, I got no autocompletion too on ScrollViewPortTracker.
TS7016: Could not find a declaration file for module rn-scroll-viewport-tracker.
/ Users/ stathis/ IdeaProjects/ xxxxxx/ node_modules/ rn-scroll-viewport-tracker/ lib/ commonjs/ index. js
implicitly has an any type.
There are types at
/ Users/ stathis/ IdeaProjects/ xxxxx/ node_modules/ rn-scroll-viewport-tracker/ lib/ typescript/ module/ src/ index. d. ts
, but this result could not be resolved under your current moduleResolution setting. Consider updating to node16, nodenext, or bundler

my tsconfig.json
{
  "compilerOptions": {
    "emitDecoratorMetadata": true,
    "allowJs": true,
    "allowSyntheticDefaultImports": true,
    "baseUrl": ".",
    "allowUnreachableCode": false,
    "experimentalDecorators": true,
    "allowUnusedLabels": false,
    "noStrictGenericChecks": false,
    "esModuleInterop": true,
    "importHelpers": true,
    "isolatedModules": true,
    "jsx": "react-native",
    "lib": ["esnext"],
    "moduleResolution": "node",
    "noEmit": true,
    "module": "esnext",
    "paths": {
      "*": ["src/*"],
      "@assets/*": ["src/assets/*"],
      "@components/*": ["src/components/*", "components/*"]
    },
    "resolveJsonModule": true,
    "skipLibCheck": true,
    "strict": true,
    "target": "esnext",
    "typeRoots": ["./typings"]
  },
  "exclude": [
    "node_modules",
    "./node_modules/",
    "**/node_modules",
    "ios",
    "android",
    "babel.config.js",
    "metro.config.js"
  ],
  "include": ["src", "__tests__", "typings", "modules/**/*.ts"]
}

just fyi, 1.4.1 is not available on npm.

Hey, the publish is done now. could you install 1.4.1 and confirm if it works?

all good now, thank you for the quick fix!

fixed on 1.4.1

@LonelyCpp is there any chance to make this module work with reanimated Animated.ScrollView too?? Don't want to open a new issue if this is not planned.

you can make a fresh issue - I will explore if its possible to add support


Validation should require port when BackendRef refers to a Service

What would you like to be added:
In BackendObjectReference we note that "Port is required when the referent is a Kubernetes Service". We should validate that with the webhook.
Why this is needed:
This is a clear example of where the webhook could improve UX.

let me try.
/assign

@robscott, I think this may not be required now we've changed how the service reference works?

It seems like it should still be relevant?
https://github.com/kubernetes-sigs/gateway-api/blob/master/apis/v1alpha2/object_reference_types.go#L127

Changing how the Service reference works made this less ambiguous, but it would still be helpful to have webhook validation here to ensure port was always set when the BackendRef.Kind was "Service"

/lifecycle frozen

@tao12345666333 I've unassigned you as it's been about a year since we last heard from you on this. If you're still wanting to have a go at this, let us know.

sorry for the delay. I forgot about this 😅
I haven't had time to work on it lately, I'll be happy to pick it up once I'm free and the issue is still open

I will try to give a short on this one, I might need some help.

Sounds good @rushi47, reach out in here in this issue if you need some assistance :+1:
/assign @rushi47

Hello Team,
I got chance to review the code and I wanted to confirm my understanding (Apologies itself if my understanding is wrong as this is the first time, I am touching the code base)
Should we actually call Control plane API & validateService object to confirm the port, when service is actually deployed and running in cluster ?
If not, I see port is kind of being validated here : https://github.com/kubernetes-sigs/gateway-api/blob/main/apis/v1beta1/validation/httproute.go#L92
Which is being called in Admission Server, in places like :
https://github.com/kubernetes-sigs/gateway-api/blob/main/pkg/admission/server.go#L173
https://github.com/kubernetes-sigs/gateway-api/blob/main/pkg/admission/server.go#L181

You're completely right @rushi47! Sorry for the confusion here. It looks like we fixed this but never closed out the issue. Thanks for the references to where this is already implemented!

Np ! but that means i need to find new issue @robscott lol


Fix deploy scripts

Depends on #1330

Added some checks -- not sure if they are rigorous enough though.
Key Transparency can be checked out in any directory now that Go modules are a thing. This makes creating strong checks around what directory the script expects to be run in more difficult.


Firing inhibition only works for flattened layers

Description
the inhibition argument of neurons is only setup for single dimensional channels / outputs of nn.Linear
It does not work for convolutional layers.
The way I see it, there are two options:

Only allow 1 neuron to fire from an entire layer; this is how it is currently setup for Linear layers
Allow 1 neuron to fire per-channel. Trickier, as the channel dimension must be known.

The second option makes more sense to me, as features are extracted by different filters/channels. What is the meaning of the channel dimension must be known? Maybe I need to see the code to understand haha.


Failed to compile with webpack 4

Hi, receiving these errors when compiling with webpack 4
[./node_modules/node-duckdb/build/Release/node-duckdb-addon.node] 279 bytes {main} [built] [failed] [1 error]
    + 1544 hidden modules

ERROR in ./node_modules/node-duckdb/dist/addon/duckdb.js
Module not found: Error: Can't resolve 'fs' in '/home/xxxx/projectRoot/node_modules/node-duckdb/dist/addon'
 @ ./node_modules/node-duckdb/dist/addon/duckdb.js 4:13-26
 @ ./node_modules/node-duckdb/dist/addon/index.js
 @ ./node_modules/node-duckdb/dist/index.js
 @ ./components/Map/index.js
 @ ./components/main/Desktop/index.js
 @ ./Routes.jsx
 @ ./App.jsx
 @ ./index.js

ERROR in ./node_modules/node-duckdb/build/Release/node-duckdb-addon.node 1:0
Module parse failed: Unexpected character '' (1:0)
You may need an appropriate loader to handle this file type, currently no loaders are configured to process this file.

Hi all, just wanted to provide a little background info regarding this request: https://gist.github.com/edwinjue/d06e12b1a351b9b3f31f770eea52a71e
Not sure if something like this is achievable using your library is it?
Thanks for your hard work. Keep it up!


AnyClass

DO NOT REMOVE OR SKIP THE ISSUE TEMPLATE

[X] I understand that I will be blocked if I remove or skip any mandatory* field

Checklist

[X] I'm reporting a new site support request
[X] I've verified that I'm running yt-dlp version 2022.11.11 (update instructions) or later (specify commit)
[X] I've checked that all provided URLs are playable in a browser with the same IP and same login details
[X] I've checked that none of provided URLs violate any copyrights or contain any DRM to the best of my knowledge
[X] I've searched the bugtracker for similar issues including closed ones. DO NOT post duplicates
[X] I've read the guidelines for opening an issue
[X] I've read about sharing account credentials and am willing to share it if required

Region
Russia
Example URLs

Single video: https://anyclass.com/class/course/1011477/calendar/1
Playlist: https://anyclass.com/class/course/1011477/calendar

Provide a description that is worded well enough to be understood
Please add an extractor for AnyClass
Provide verbose output that clearly demonstrates the problem

[X] Run your yt-dlp command with -vU flag added (yt-dlp -vU <your command line>)
[X] Copy the WHOLE output (starting with [debug] Command-line config) and insert it below

Complete Verbose Output
[debug] Command-line config: ['-vU', 'https://anyclass.com/lesson/video/2be6f79fa8e1b50fc16b173331ace9fa5e997323a39475.24433671/720/video.m3u8', '--referer', 'https://anyclass.com']
[debug] User config: []
[debug] System config: []
[debug] Encodings: locale UTF-8, fs utf-8, pref UTF-8, out utf-8, error utf-8, screen utf-8
[debug] yt-dlp version 2023.01.02 [d83b0ad] (zip)
[debug] Python 3.10.8 (CPython x86_64 64bit) - macOS-12.6.2-x86_64-i386-64bit (OpenSSL 1.1.1s  1 Nov 2022)
[debug] exe versions: ffmpeg 5.1.2 (setts), ffprobe 5.1.2, rtmpdump 2.4
[debug] Optional libraries: sqlite3-2.6.0
[debug] Proxy map: {}
[debug] Loaded 1754 extractors
[debug] Fetching release info: https://api.github.com/repos/yt-dlp/yt-dlp/releases/latest
Latest version: 2023.01.02, Current version: 2023.01.02
yt-dlp is up to date (2023.01.02)
[generic] Extracting URL: https://anyclass.com/lesson/video/2be6f79fa8e1b50fc16b173331ace9fa5e997323a39475.24433671/720/video.m3u8
[generic] video: Downloading webpage
ERROR: [generic] None: Unable to download webpage: HTTP Error 403: Forbidden (caused by <HTTPError 403: 'Forbidden'>); please report this issue on  https://github.com/yt-dlp/yt-dlp/issues?q= , filling out the appropriate issue template. Confirm you are on the latest version using  yt-dlp -U
  File "/usr/local/bin/yt-dlp/yt_dlp/extractor/common.py", line 680, in extract
    ie_result = self._real_extract(url)
  File "/usr/local/bin/yt-dlp/yt_dlp/extractor/generic.py", line 2384, in _real_extract
    full_response = self._request_webpage(url, video_id, headers={
  File "/usr/local/bin/yt-dlp/yt_dlp/extractor/common.py", line 825, in _request_webpage
    raise ExtractorError(errmsg, cause=err)

  File "/usr/local/bin/yt-dlp/yt_dlp/extractor/common.py", line 807, in _request_webpage
    return self._downloader.urlopen(self._create_request(url_or_request, data, headers, query))
  File "/usr/local/bin/yt-dlp/yt_dlp/YoutubeDL.py", line 3725, in urlopen
    return self._opener.open(req, timeout=self._socket_timeout)
  File<EMAIL_ADDRESS>line 525, in open
    response = meth(req, response)
  File<EMAIL_ADDRESS>line 634, in http_response
    response = self.parent.error(
  File<EMAIL_ADDRESS>line 563, in error
    return self._call_chain(*args)
  File<EMAIL_ADDRESS>line 496, in _call_chain
    result = func(*args)
  File<EMAIL_ADDRESS>line 643, in http_error_default
    raise HTTPError(req.full_url, code, msg, hdrs, fp)
urllib.error.HTTPError: HTTP Error 403: Forbidden

The verbose log field is not optional. We often get site support requests for already supported pages. Show verbose log of yt-dlp failing with cookies passed

You are still not passing cookies

@pukkandan check Complete Verbose Output again

I'm a bit confused

[debug] Command-line config: ['-vU', 'https://anyclass.com/lesson/video/2be6f79fa8e1b50fc16b173331ace9fa5e997323a39475.24433671/720/video.m3u8', '--referer', 'https://anyclass.com/', '--cookies-from-browser', 'chrome']

Does this URL open in browser for you? Is this the URL you even want us to support?

@pukkandan I also tried $ yt-dlp -vU https://anyclass.com/class/course/1011477/calendar/1 --referer https://anyclass.com --cookies-from-browser chrome
Here's the response:
[debug] Command-line config: ['-vU', 'https://anyclass.com/class/course/1011477/calendar/1', '--referer', 'https://anyclass.com', '--cookies-from-browser', 'chrome']
[debug] User config: []
[debug] System config: []
[debug] Encodings: locale UTF-8, fs utf-8, pref UTF-8, out utf-8, error utf-8, screen utf-8
[debug] yt-dlp version 2023.01.02 [d83b0ad] (zip)
[debug] Python 3.10.8 (CPython x86_64 64bit) - macOS-12.6.2-x86_64-i386-64bit (OpenSSL 1.1.1s  1 Nov 2022)
[debug] exe versions: ffmpeg 5.1.2 (setts), ffprobe 5.1.2, rtmpdump 2.4
[debug] Optional libraries: sqlite3-2.6.0
[Cookies] Extracting cookies from chrome
[debug] Extracting cookies from: "/Users/skurilyak/Library/Application Support/Google/Chrome/Default/Cookies"
[debug] using find-generic-password to obtain password from OSX keychain
[Cookies] Extracted 3235 cookies from chrome
[debug] cookie version breakdown: {'v10': 3194, 'other': 0, 'unencrypted': 41}
[debug] Proxy map: {}
[debug] Loaded 1754 extractors
[debug] Fetching release info: https://api.github.com/repos/yt-dlp/yt-dlp/releases/latest
Latest version: 2023.01.02, Current version: 2023.01.02
yt-dlp is up to date (2023.01.02)
[generic] Extracting URL: https://anyclass.com/class/course/1011477/calendar/1
[generic] 1: Downloading webpage
WARNING: [generic] Falling back on generic information extractor
[generic] 1: Extracting information
[debug] Looking for embeds
ERROR: Unsupported URL: https://anyclass.com/class/course/1011477/calendar/1
Traceback (most recent call last):
  File "/usr/local/bin/yt-dlp/yt_dlp/YoutubeDL.py", line 1497, in wrapper
    return func(self, *args, **kwargs)
  File "/usr/local/bin/yt-dlp/yt_dlp/YoutubeDL.py", line 1573, in __extract_info
    ie_result = ie.extract(url)
  File "/usr/local/bin/yt-dlp/yt_dlp/extractor/common.py", line 680, in extract
    ie_result = self._real_extract(url)
  File "/usr/local/bin/yt-dlp/yt_dlp/extractor/generic.py", line 2523, in _real_extract
    raise UnsupportedError(url)
yt_dlp.utils.UnsupportedError: Unsupported URL: https://anyclass.com/class/course/1011477/calendar/1


program fails with getcwd() failing

If we are running endpoint.py continuously and then try to push first image, it works fine. For the second and later images, it starts to fail as the path has changed. Need to fix this for all of our current code.
flatenning layers...
('all_layers:parent_layers -- ', 4, ':', 3)
('copying layer -- ', u'63e9eb8285fe5e7212932f3eb78d85bfc41685cf1d7aefdf5afbd6b0e73bea6d')
sh: 0: getcwd() failed: No such file or directory
('copying layer -- ', u'6b1c8a75b2bebed4e65ffb9d21669762e846160329f9300ff152de2b1da3495e')
sh: 0: getcwd() failed: No such file or directory
('copying layer -- ', u'eefe7f608aa7f35ac7a69a65923999b4b015bf5656f0d1400bb0c8c5054121b8')
sh: 0: getcwd() failed: No such file or directory
('copying layer -- ', u'5b3e5bb377f0c2288d8ff5273bd5109e118463f57fb6b129d654c92e2ae0e9be')
sh: 0: getcwd() failed: No such file or directory

Fixed.


feat: implement Tooltip component on @rainbow-modules/

@TahimiLeonBravo Hello! can I have some more information about this feat?


SetKeyBinding with ModCtrl + rune

Hi, is it already possible to add keybindings with the ModKeys?
If so I can't figure how from the docs and examples.
I see SetKeybinding takes (inter{}, func ).
How are ModKey events handled?

There's currently no support for modifiers but this is definitely a must-have for an initial release. Apart from setting the API for SetKeyBinding there's not much work involved.
The reason it takes an interface{} is so that it can take special keys like KeySpace as well as letter keys.
Maybe we could just change the signature into SetKeybinding(r rune, k ModKey, func())?
Example usage:
ui.SetKeybinding('q', tui.ModNone, func() { ... }
ui.SetKeybinding(tui.KeySpace, tui.ModCtrl, func() { ... }

I noticed this enum in tcell
const (
KeyCtrlSpace Key = iota
KeyCtrlA
KeyCtrlB
KeyCtrlC
KeyCtrlD
KeyCtrlE
KeyCtrlF
KeyCtrlG
KeyCtrlH
KeyCtrlI
KeyCtrlJ
KeyCtrlK
KeyCtrlL
KeyCtrlM
KeyCtrlN
KeyCtrlO
KeyCtrlP
KeyCtrlQ
KeyCtrlR
KeyCtrlS
KeyCtrlT
KeyCtrlU
KeyCtrlV
KeyCtrlW
KeyCtrlX
KeyCtrlY
KeyCtrlZ
KeyCtrlLeftSq // Escape
KeyCtrlBackslash
KeyCtrlRightSq
KeyCtrlCarat
KeyCtrlUnderscore
)
So for example 'n' normally registers as 110 for the (Key or Ch, I forget), but when using the Ctrl modifier, it changes to 14 -- I didn't realize that using a modifier actually modifies the value. In any case, maybe we don't need to change the signature, but rather add the enum?
I forget why (I've been busy) but I didn't get it to work earlier

Ok... so this isn't an acceptable solution or anything, but I got the SetKeybinding() func to take as its first parameter an enum from the above, so tui.KeyCtrlN by (adding the enum)
func (b *Keybinding) Match(ev Event) bool {
	if b.Key == Key(ev.Ch) && ev.Key == Key(b.Ch) {
		return true
	}

	return ((b.Key == ev.Key) && (b.Ch == ev.Ch))
}

Problem is... I have no idea why this works. I mean, I have an idea, I logged the values of these when I smash the keyboard. But I don't really get where these values are coming from...

Currently, Key is used for special keys like Space, Enter and arrow keys. The value of a Key doesn't really mean anything (other than the order it was defined). For example, in the const group you posted KeyCtrlSpace will be 0, KeyCtrlA will be 1, KeyCtrlB 2 and so on. Meanwhile, the value of Ch is the actual ASCII code of that letter. E.g.,
package main

import (
	"fmt"
)

func main() {
	fmt.Println(int('n')) // 110
}

While the ASCII code will be constant, the value of the Key might not, and you can't really compare the two.
The "magic" is done here: https://github.com/marcusolsson/tui-go/blob/master/ui_tcell.go#L56-L61 where we do a type switch on the interface{}.
I'm actually in the middle of rewriting the event handling, so I'd probably hold off on this issue a bit. If you're interested, there's a branch called event-refactor. I'm actually leaning towards adopting the same idea as https://github.com/gdamore/tcell/blob/master/key.go#L45-L50 and use a ModMask type, hence my initial suggestion of introducing another parameter. Hopefully I'll get some time to work on this during the weekend.

Cool, thanks for clarifying -- I'll check in sometime next week :smile_cat:

No worries! Thanks for your interest in tui-go!

Good to know you are working on it, I'm working on this little thing https://github.com/gonzaloserrano/git-br and would love to bind shift or cmd + enter :-)

Cool project @sp-gonzalo-serrano ! :)
While I am working on this, I'm currently trying to better understand terminal input handling. For example, from the tcell documentation:
Note that [control keys] overlap with other keys, perhaps.  For example, KeyCtrlH is the same as KeyBackspace.

Another example: a tcell key event could contain theoretically contain a ModCtrl along with the KeyCtrlSpace (duplicated Ctrl?).
I'm going to need to read up on this before attempting a solution. For now, I won't be able to make any promises as to when this will be done.
(Meanwhile, I've just submitted a related pull request for event handling, that will unfortunately break some existing code)

So, there are currently two open pull requests (#28 and #29) with two different approaches to solving this. I'd love to hear your thoughts on what the pros and and cons are, and ultimately what you'd prefer.

#28:
ui.SetKeybinding(tui.KeyUp, tui.ModShift | tui.ModAlt, func() { ... })
ui.SetKeybinding(tui.KeyCtrlSpace, tui.ModCtrl, func() { ... })

#29:
ui.SetKeybinding("Shift+Alt+Up", func() { ... })
ui.SetKeybinding("Ctrl+Space", func() { ... })

Hey! This all seems great, I really like the #29 method -- as you say, it might be more intuitive to new users who don't feel like understanding how the keybinding work 😉 -- also, my solution is more or less incomplete, (unable to perform the Shift-Enter needed by @sp-gonzalo-serrano )
It's not totally clear to me how the innerds of #29 work, but that also doesn't matter as long as I can Mod my keybindings 😄 . And the Emacs style sequences sounds awesome! I'm cool with closing #28 (I'm not invested in the pr I submitted) and this issue if your PR does the job.
Thanks for responding/taking care of this issue so timely!

Thank you both for your feedback, especially @fenimore for both creating the issue and submitting the initial pull request!
Unfortunately, Shift+Enter and Ctrl+Enter does not yet seem to work for #29 either (although Alt+Enter does) so I'm guessing there's more to do there. Found this line that hints that Ctrl+Enter might have another code. Good thing is hopefully we'll be able to work on supporting the edge cases without users needing to bother.
I'm going ahead and merging #29, but it'll need more testing. Adding tests for more key sequences to keybinding_test.go will be much appreciated ;-)

Also, created #30


Fix issue with CSP docs

The code contained variables that would not be replaced.

@Yiyun333 Can be merged as-is.


Clean up dependencies and fix clippy warnings

Looks good. I'm not sure whether the Box removal was necessary, but it does make the code look nicer.

There was a clippy warning about the boxes. I think it caused some unnecessary heap allocations.


1.1.14_wmagent branch of fix db exception handling #8768

wmagent branch of #8768

patched cern agents and updated https://twiki.cern.ch/twiki/bin/view/CMSPublic/CompOpsWorkflowTeamWmAgentRealeases
and
https://trello.com/b/JEy8HHWr/wmagent-release-management


Remove unreachable

I can confirm that this also fixes the panics.

Hey, original author here! Thank you for picking this up & merging! I think I forgot to create a pull request out of my original patch! So, @netthier thanks again!


Fix #4948

Please don't use "Fix #xxx" as the pull request title, it's extremely hard to keep track of these.  There could also be an argument against making hard ties to GitHub -- if it disappears, you have no idea what this was about. You have plenty of places to take the commit message from -- either spec name or issue title.
However, using the "Fix #xxx" in the detailed description of the commit is great.

@oprypin You are right. I was just being lazy 😊


v1.1.5 disconnects at move 11

This happens with v1.1.5, i never encountered something like it with any engine : at move 11 it disconnects, no sooner, no later.
I reproduced this 6 (!) times with a 5m3s games, Sapling playing White and Black, with and without start FEN : Sapling-1-1-5-disconnects-around-move-11.zip all games had the same result, it's weird.
Note: i use your x64 Linux asset, because i can't compile the v1.1.5 source, it gives many errors.

OH no!! Not sure how that's slipped through. I'll investigate asap, in the mean time I've removed the release for v1.1.5
Thanks for the report, not entirely sure what could be happening there.

Would you be able to send the file generated in the logs for that game (if you still have it)

Would you be able to send the file generated in the logs for that game (if you still have it)

here : logs.zip
it's from another run ..

I tried to compile with your Makefile, but it gives many warnings and errors.
However, i'm able to do this command (from the README) : it gives only warnings, and ends without coming to the prompt, so did 'uci' and indeed it runs :
$ dotnet run --project ./Sapling/Sapling.csproj --configuration Release
/home/roelof/Compiled/Sapling-Sapling-1.1.5/Sapling.Engine/Tuning/SpsaOptions.cs(15,23): warning CS8618: Non-nullable field 'Name' must contain a non-null value when exiting constructor. Consider declaring the field as nullable. [/home/roelof/Compiled/Sapling-Sapling-1.1.5/Sapling.Engine/Sapling.Engine.csproj]
/home/roelof/Compiled/Sapling-Sapling-1.1.5/Sapling.Engine/Tuning/SpsaOptions.cs(16,23): warning CS8618: Non-nullable field 'Type' must contain a non-null value when exiting constructor. Consider declaring the field as nullable. [/home/roelof/Compiled/Sapling-Sapling-1.1.5/Sapling.Engine/Sapling.Engine.csproj]
/home/roelof/Compiled/Sapling-Sapling-1.1.5/Sapling.Engine/Tuning/SpsaOptions.cs(17,23): warning CS8618: Non-nullable field 'DefaultValue' must contain a non-null value when exiting constructor. Consider declaring the field as nullable. [/home/roelof/Compiled/Sapling-Sapling-1.1.5/Sapling.Engine/Sapling.Engine.csproj]
/home/roelof/Compiled/Sapling-Sapling-1.1.5/Sapling.Engine/Tuning/SpsaOptions.cs(18,23): warning CS8618: Non-nullable field 'MinValue' must contain a non-null value when exiting constructor. Consider declaring the field as nullable. [/home/roelof/Compiled/Sapling-Sapling-1.1.5/Sapling.Engine/Sapling.Engine.csproj]
/home/roelof/Compiled/Sapling-Sapling-1.1.5/Sapling.Engine/Tuning/SpsaOptions.cs(19,23): warning CS8618: Non-nullable field 'MaxValue' must contain a non-null value when exiting constructor. Consider declaring the field as nullable. [/home/roelof/Compiled/Sapling-Sapling-1.1.5/Sapling.Engine/Sapling.Engine.csproj]
/home/roelof/Compiled/Sapling-Sapling-1.1.5/Sapling.Engine/Tuning/SpsaOptions.cs(20,26): warning CS8618: Non-nullable field 'FieldHandle' must contain a non-null value when exiting constructor. Consider declaring the field as nullable. [/home/roelof/Compiled/Sapling-Sapling-1.1.5/Sapling.Engine/Sapling.Engine.csproj]
/home/roelof/Compiled/Sapling-Sapling-1.1.5/Sapling.Engine/Evaluation/NnueWeights.cs(56,20): warning CS8602: Dereference of a possibly null reference. [/home/roelof/Compiled/Sapling-Sapling-1.1.5/Sapling.Engine/Sapling.Engine.csproj]
/home/roelof/Compiled/Sapling-Sapling-1.1.5/Sapling.Engine/RepetitionDetector.cs(92,26): warning CS8509: The switch expression does not handle all possible values of its input type (it is not exhaustive). For example, the pattern '0' is not covered. [/home/roelof/Compiled/Sapling-Sapling-1.1.5/Sapling.Engine/Sapling.Engine.csproj]
/home/roelof/Compiled/Sapling-Sapling-1.1.5/Sapling/UciEngine.cs(29,23): warning CS8602: Dereference of a possibly null reference. [/home/roelof/Compiled/Sapling-Sapling-1.1.5/Sapling/Sapling.csproj]
/home/roelof/Compiled/Sapling-Sapling-1.1.5/Sapling/Program.cs(27,34): warning CS8602: Dereference of a possibly null reference. [/home/roelof/Compiled/Sapling-Sapling-1.1.5/Sapling/Sapling.csproj]
uci
id name Sapling 1-1-5
id author Tim Jones
option name Threads type spin default 1 min 1 max 1024
option name Ponder type check default false
option name Hash type spin default 319 min 32 max 2046
option name ReverseFutilityPruningMargin type spin default 75 min 10 max 100
option name ReverseFutilityPruningDepth type spin default 7 min 1 max 10
option name NullMovePruningDepth type spin default 2 min 1 max 10
option name NullMovePruningReductionA type spin default 3 min 1 max 10
option name NullMovePruningReductionB type spin default 4 min 1 max 10
option name NullMovePruningReductionC type spin default 3 min 1 max 10
option name RazorMarginA type spin default 125 min 10 max 400
option name RazorMarginB type spin default 300 min 10 max 400
option name InternalIterativeDeepeningDepth type spin default 2 min 1 max 10
option name LateMovePruningConstant type spin default 8 min 1 max 10
option name LateMoveReductionMinDepth type spin default 3 min 1 max 10
option name LateMoveReductionMinMoves type spin default 2 min 1 max 10
option name HistoryHeuristicMaxHistory type spin default 8192 min 7000 max 10000
option name HistoryHeuristicBonusMax type spin default 640 min 500 max 1000
option name HistoryHeuristicBonusCoeff type spin default 80 min 10 max 100
option name MoveOrderingWinningCaptureBias type spin default 10000000 min 500000 max 10000000
option name MoveOrderingLosingCaptureBias type spin default 16000 min 10000 max 30000
option name MoveOrderingPromoteBias type spin default 600000 min 70000 max 700000
option name MoveOrderingKillerABias type spin default 500000 min 70000 max 600000
option name MoveOrderingKillerBBias type spin default 250000 min 70000 max 300000
option name MoveOrderingCounterMoveBias type spin default 65000 min 20000 max 80000
option name InterestingNegaMaxMoveScore type spin default 16000 min 10000 max 30000
option name InterestingQuiescenceMoveScore type spin default 16000 min 10000 max 30000
uciok
quit

It seems in 'Sapling/bin/Release/net8.0/' a bunch of files is created (.json & .dll & more) with 'Sapling' being the executable : when i go into this folder and run that, it succeeds and i can use it in CuteChess. But i want a single binary, so i tried compiling with options like --self-contained -p:PublishSingleFile=true -p:PublishTrimmed=true -o ./Sapling-single-binary but no combination gives the desired result .. how can i create a single binary ?

i just ran CuteChess GUI in a debugger (lldb-17) and let v1.1.5 play a game .. again at move 11 (!?) it disconnects, but lldb gives only this :
$ lldb-17 /home/roelof/Apps/cutechess-1.3.1/cutechess-gui
(lldb) target create "/home/roelof/Apps/cutechess-1.3.1/cutechess-gui"
Current executable set to '/home/roelof/Apps/cutechess-1.3.1/cutechess-gui' (x86_64).
(lldb) run
Process 32125 launched: '/home/roelof/Apps/cutechess-1.3.1/cutechess-gui' (x86_64)
qt.qpa.xcb: QXcbConnection: XCB error: 3 (BadWindow), sequence: 3632, resource id: 11270034, major code: 40 (TranslateCoords), minor code: 0
Process 32125 stopped and restarted: thread 15 received signal: SIGCHLD
Terminating process of engine Sapling v1.1.5 NNUE(0)

here's the concerning log file : 10-4-2024_12-52_PM9171b843-345e-4dab-abe5-42655a2d55bd.zip

btw. i used the deafult UCI settings, threads 1.

I've tracked down two potential causes of the error you found.

The 'Searcher' was causing an 'AccessViolationException' when being disposed. I've fixed it now, though this should only happen when reducing the thread count on a running instance, so not sure if that's what you experienced.
If no best move was found it would cause an out of bounds exception by trying to select the first element from an empty list. I've put in some logic to avoid this now under various conditions (like asking for a move when in mate, the search being cancelled or running out of time)

I've also added some better logging / error handling so hopefully if it is neither of those things it should be better equipped to catch it.
Would you be able to try again since you were able to reproduce it reliably and let me know if it's fixed (v1.1.5 in the assets is up to date)
P.S will work on fixing the linux make file tonight

I've tracked down two potential causes of the error you found

as you describe those causes they don't seem related to my Issue .. the newest 1.1.5 asset runs fine in CuteChess GUI : i let it play two 5m3s games, the first with default settings playing White from start position, the second with 2 threads playing Black from some starting FEN .. all seems normal, it won both games (against 4KU v5.1) while spending time efficiently in its normal way .. some log files were created but 0 bytes.

about the 11th move : this is weird, isn't it ? Six times the same Issue .. with that buggy 1.1.5 version, when the engine is to move at 11th, it IMMEDIATELY "disconnects", not during the evaluation of that move.

P.S will work on fixing the linux make file tonight

you might consider 'Mono' for Linux users .. anyhow, you will learn new thing when solving this!

Just to clarify, the new version doesn't experience that bug you mentioned?

Just to clarify, the new version doesn't experience that bug you mentioned?

no, the newest 1.1.5 runs fine, no problems of that kind.

@Timmoth Although the following information isn't directly related to this Issue, i want to mention it here, because you're constantly working on a newer version, and many techniques are involved.
Once i found the chess engine Akimbo - newest versions use an NN - see https://github.com/jw1912/akimbo
Its README states :
Evaluation
Up to and including version 1.0.0, all data used was self-generated, starting from material values when akimbo still had an HCE and iteratively generating data and tuning to produce higher quality datasets. The final HCE dataset was then used to train akimbo's first network and further data was then generated.
This involved hundreds of hours of compute, and got incredibly tedious, so akimbo now uses data produced by Leela Chess Zero.
Additionally, akimbo uses its own trainer written in Rust and CUDA, bullet, which also used by a number of other engines.
Do you recognise the method used to train an NN and/or use data for it ?
Could this be of any help or give inspiration ?
When i read this, i was thinking about the Sapling NN -- Akimbo is written in Rust though ..

Up to and including version 1.0.0, all data used was self-generated, starting from material values when akimbo still had an HCE and iteratively generating data and tuning to produce higher quality datasets. The final HCE dataset was then used to train akimbo's first network and further data was then generated.

Sapling took this one step further, it started with entirely random weights, so at first there was 0 chess knowledge and through iteratively generating new networks it learned all knowledge itself.

This involved hundreds of hours of compute, and got incredibly tedious, so akimbo now uses data produced by Leela Chess Zero.

This is the standard path people take, data gen is long and expensive, i spend £400 on cloud servers plus the 4 I had at home for the first few weeks, then I bought two new high powered systems that I also use now. Although Leela data is well believed to be the best dataset so will always beat self gen data but it reduces the unique feeling of your engine since it's learned to play based on the moves of a much stronger engine. I refuse to use it and will keep improving my own net based on self play.

Additionally, akimbo uses its own trainer written in Rust and CUDA, bullet, which also used by a number of other engines.

I'm using bullet to do the actual training too!
Here's the training log so far:
https://github.com/Timmoth/Sapling/blob/main/Sapling.Engine/Resources/WeightsHistory/log.txt
Probably generated 20bn+ positions over all the iterations, which takes a looong time and i've still got some way to go

@Timmoth nice info, thanks!
another thing, personal : i found email address t.jones-at-aptacode.com .. is it yours ? I wrote you an email on 25 Sep with subject "JS chess" .. could you react to that ? If you're not able to help me with the concerning case, it's OK, i'm just searching for solutions ..

Yeah that's mine (can you remove from that comment as i don't want it to be public)
Also where did you find it?
I didn't see it! I'll go have a look now!

btw. i found it by the '@'info on your GitHub profile ..


play button prompt box bug

if i click on the play button a prompt is displayed with two options ok and cancel, if i choose cancel then it prompts me with welcome to the game null, i think this is not the expected behaviour

Thanks @ayaankhan98 ! I needed to.fix that thing. Well! Would you like to work on it?

@Apoorve73 go ahead :)

Wish you good luck! Hope, you will come up with a solution, soon!

if (button) {
            button.addEventListener('click', function() {
                var name = prompt("Enter your name ")
                alert("Welcome to the game " + name);
                var sum = 0;
                var count = 1;
                var compcount = 0;
                raceforit(sum, count, compcount);
            });

it seems that this part is causing this error, one possible solution is
if (button) {
       button.addEventListener('click', function() {
                  var name = prompt("Enter your name ")
                  if(name != null)
                  {
                    alert("Welcome to the game " + name);
                    var sum = 0;
                    var count = 1;
                    var compcount = 0;
                    raceforit(sum, count, compcount);
                  }
       });

Thank you @ayaankhan98 . Would you like to create a pull request or I will make the changes to the code?

go ahead and make changes :)

Sure thing!


[typing] allow Sequence inputs in several jax.numpy functions

I noticed one place where we added an ignore statement due ot a user passing a list to the axis argument of squeeze. When I saw that, I put this change on my TODO list.


Job type is missing interruptible key

Subj: https://docs.gitlab.com/ee/ci/yaml/#interruptible

Perhaps you could open a merge request?


[SMALLFIX] Add backwards compatibility test

Adding the test caught a couple bugs from the previous PR:

Needed to explicitly journal deleteMountPoint
Needed to handle SetAttributeEntry for backwards compatibility
Handling for deprecated renames was wrong - it would apply two entries instead of one

@yuzhu

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/168/
Test PASSed.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/171/
Test FAILed.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/173/
Test FAILed.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/174/
Test FAILed.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/178/
Test FAILed.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/180/
Test FAILed.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/181/
Test FAILed.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/182/
Test FAILed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/183/
Test PASSed.

@calvinjia for high-level review
@apc999 to review the pom changes

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/184/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/185/
Test PASSed.

@calvinjia the technique for avoiding conflicts atm is naming paths with respect to the Op they apply to. I don't want to fully quarantine Ops to their own directories because that will limit the ability to test Ops within the root directory. Ops in root directory could potentially behave differently from Ops in nested directories.

@calvinjia thanks for the review, PR is updated to address the comments

@apc999 This PR makes 3 pom changes:

Add a skipSlowTests profile that is on by default and skips the tests listed in build/surefire/slow-tests
Update per-project pom files to set build.path instead of separate variables for checkstyle, findbugs, and license check. Instead of those other variables, we can use build.path.
Move dependencies in tests/pom.xml to the compile scope and create a jar-with-dependencies for tests/. This is necessary to run the BackwardsCompatibilityJournalGenerator, which lives in tests/src/main and generates the data (out of band) used by the BackwardsCompatibilityIntegrationTest which is under tests/src/test. The dev/scripts/generate-backcompat-journal.sh script is a convenient way to run it. I didn't want to clutter bin/alluxio further, or reference the tests/ jar-with-dependencies from there.

What are your thoughts on these changes?

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/197/
Test FAILed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/198/
Test PASSed.


maxpool2D in TTNN should be supported for shallow depths too ( < 32)

Describe the bug
maxpool2D current requires channel depths to be >=32. We need support for shallow depths as well
please see the model summary here: model summary
also see, model status

changing this from a bug to feature. Let me know if you disagree

This is resolved for the shallow UNet. However, we still are debugging the bad PCC for the end to end model. Maxpool was contributing to bad PCC as well but now seems to be resolved at least for the max pool ops. @tapspatel and @nsmithtt Do you think we can close this issue now?

Supported added w/ 9be4a81026

Dup of https://github.com/tenstorrent-metal/tt-metal/issues/4954


Test RNTesterPods on CI with use_frameworks! enabled

Summary

This adds a test_ios_frameworks job to CircleCI to test the RNTesterPods project with use_frameworks! enabled. It will ensure the issue in https://github.com/facebook/react-native/issues/25349 is not reintroduced as suggested in https://github.com/facebook/react-native/pull/25619#issuecomment-514380653.
Changelog

[iOS] [Internal] - Added CircleCI job for testing RNTesterPods with use_frameworks! enabled.
Test Plan

Tests seem to be failing on master at the moment but you can see that the new job builds successfully here. You can confirm it installs the pods with use_frameworks! by seeing that Installing pods with use_frameworks! is at the start of the log for the Generate RNTesterPods Workspace step.

Its worth pointing out that fixing https://github.com/facebook/react-native/issues/23561 could potentially make this redundant. process-podspecs.sh validates the podspecs with pod lib lint both for frameworks and libraries. When that is working again its arguable that a full test run of RNTesterPods for use_frameworks! would not be needed.
A quick look suggests it shouldn't be too hard to fix process-podspecs.sh. I'll take a look next week.

A quick look suggests it shouldn't be too hard to fix process-podspecs.sh.

@hramos: do we still use that script? I think ios CI builds are fully using cocoapods already?

I think the suggestion in that issue is to get it working again. Even if the repo uses CocoaPods extensively it could be useful to validate the podspecs.

The CI builds are failing, do you know if it's related to this change?
https://circleci.com/gh/facebook/react-native/103930?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link
https://circleci.com/gh/facebook/react-native/103932?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link

@fkgozali Not related. master is currently failing with the same error.

The tests are now failing on 0.61-stable branch (https://circleci.com/gh/facebook/react-native/107763) with the following:

:x:  Undefined symbols for architecture x86_64
Symbol: _OBJCCLASS$__RCTTypedModuleConstants
Referenced from: objc-class-ref in RCTPlatform.o

I believe this may be related to the CocoaPods integration - does anyone happen to know where to dig this deeper?

I can take a look @grabbou. I think this should be relatively straightforward to fix.

Okay, so I did a git bisect and it seems that the test failure was first introduced by https://github.com/facebook/react-native/commit/2956eb266f1edad09165baf7c5db832c170ad41c.
It seems these tests have been failing on master for a while 😞 I'm looking into how much effort it will take to fix.

Great, thanks! Make sure to check 0.61-stable too, I've reverted one commit
there to make other lanes work as well.
In the worst case scenario, I think what we can do is we can just revert
this commit until a better solution is found.
On Wed, 21 Aug 2019 at 16:26, James Treanor<EMAIL_ADDRESS>wrote:

Okay, so I did a git bisect and it seems that the test failure was first
introduced by 2956eb2
https://github.com/facebook/react-native/commit/2956eb266f1edad09165baf7c5db832c170ad41c
.
It seems these tests have been failing on master for a while 😞 I'm
looking into how much effort it will take to fix.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/facebook/react-native/pull/25818?email_source=notifications&email_token=AASZZRUPTHOF3QTH42DLHXLQFVGBNA5CNFSM4IGZHA6KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD4Z2R6Y#issuecomment-523479291,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AASZZRXBKQ6GQ7R3LV63D2TQFVGBNANCNFSM4IGZHA6A
.

cc @osdnk
@grabbou / @jtreanor that commit seems likely culprit. To revert it, you'll have to revert https://github.com/facebook/react-native/commit/28e18e41058a612290e0cf35c974297522c3ba1f beforehand (they're related change)

Great, thanks! Make sure to check 0.61-stable too, I've reverted one commit
there to make other lanes work as well.

Yeah, I've confirmed the problem on 0.61-stable.

@grabbou / @jtreanor that commit seems likely culprit. To revert it, you'll have to revert 28e18e4 beforehand (they're related change)

Thanks @fkgozali! I'll try that out. The alternative approach which has worked for me is to add s.static_framework = true to all of the podspecs as we discussed in https://github.com/facebook/react-native/pull/25619#discussion_r306993309.

Reverting those commits fixed the RCTPlatform build error but uncovered a number of other build errors (see below) that seem to be caused by https://github.com/facebook/react-native/commit/bf78d7969a48b63f7d57bf7cdb1b1d8af2f46e5c. That didn't revert cleanly.
Undefined symbols for architecture x86_64:
  "_RCTGetImageData", referenced from:
      ___45-[RCTImageStoreManager storeImage:withBlock:]_block_invoke in RCTImageStoreManager.o
      ___47-[RCTImageStoreManager(Deprecated) storeImage:]_block_invoke in RCTImageStoreManager.o
  "_OBJC_CLASS_$_RCTImageCache", referenced from:
      objc-class-ref in RCTImageLoader.o
  "_RCTImageHasAlpha", referenced from:
      ___43-[RCTImageLoader sendRequest:withDelegate:]_block_invoke in RCTImageLoader.o
  "_RCTTransformImage", referenced from:
      ___75-[RCTImageEditingManager cropImage:cropData:successCallback:errorCallback:]_block_invoke in RCTImageEditingManager.o
      RCTResizeImageIfNeeded(UIImage*, CGSize, double, RCTResizeMode) in RCTImageLoader.o
  "_RCTGetImageMetadata", referenced from:
      ___50-[RCTImageLoader getImageSizeForURLRequest:block:]_block_invoke in RCTImageLoader.o
  "_RCTDecodeImageWithData", referenced from:
      ___80-[RCTImageLoader decodeImageData:size:scale:clipped:resizeMode:completionBlock:]_block_invoke_3.264 in RCTImageLoader.o
  "_RCTTransformFromTargetRect", referenced from:
      ___75-[RCTImageEditingManager cropImage:cropData:successCallback:errorCallback:]_block_invoke in RCTImageEditingManager.o
      RCTResizeImageIfNeeded(UIImage*, CGSize, double, RCTResizeMode) in RCTImageLoader.o
  "_RCTTargetRect", referenced from:
      ___75-[RCTImageEditingManager cropImage:cropData:successCallback:errorCallback:]_block_invoke in RCTImageEditingManager.o
      RCTResizeImageIfNeeded(UIImage*, CGSize, double, RCTResizeMode) in RCTImageLoader.o
ld: symbol(s) not found for architecture x86_64
clang: error: linker command failed with exit code 1 (use -v to see invocation)

@fkgozali It seems that this problem will continue to occur with CoreModules. What are your thoughts on using s.static_framework = true in the podspecs to resolve it?

What are your thoughts on using s.static_framework = true in the podspecs to resolve it?

I think this is fine to do to unblock. I won't have cycle to debug further for the next week or so, so let's do this quick fix.

I have reverted https://github.com/facebook/react-native/pull/25816 on the 0.61-stable branch. However, this may still provide a lot of issues for existing applications, that depend on React podspec, as I am pretty sure most of them don't have static_framework = true turned on.

Thanks @grabbou, you beat me to it.

However, from what I understand from the linked PR, the issue may still occur within existing apps that depend on React podspecs and have use_frameworks turned on.

The issue will likely be for third party libraries which have podspecs. It would now be required to have s.static_framework = true for use_frameworks! to work.

I think it makes sense to note this explicitly in the first release candidate and that we are working on providing a better solution to this problem.

That makes sense.

Okay, I have found a simple solution that does not require s.static_framework = true. We just needed to update the CoreModules podspec. I've opened a PR in https://github.com/facebook/react-native/pull/26151 to target the 0.61-stable branch.


[BUG] Vulnerability introduced by io.netty:netty-handler v4.1.68.Final

io.netty:netty-handler v4.1.68.Final used by Azure.Core is vulnerable and should be updated to newer version that resolves vulnerability.
https://github.com/Azure/azure-sdk-for-java/blob/3b13da9639580e9c5af01d6f9ab30457cbba29ab/sdk/core/azure-core-http-netty/pom.xml#L74-L77
Vulnerability Details
An issue was found in all versions of io.netty:netty-all. Host verification in Netty is disabled by default. This can lead to MITM attack in which an attacker can forge valid SSL/TLS certificates for a different hostname in order to intercept traffic that doesn?t intend for him. This is an issue because the certificate is not matched with the host.
Severity
High
State
Active
Affected component
io.netty:netty-handler
4.1.68.Final
Recommendation
Upgrade to version io.netty:netty-all - 4.0.0.Final,4.1.69.Final;io.netty:netty-handler - 4.1.68.Final-redhat-00001,4.1.67.Final-redhat-00001
This causes Component Alerts for consumer apps. Please fix in newer releases so we can update to new version of Azure SDK to solve this issue.
cc @David-Engel

We have encountered same issue - CVE-2021-4379.
The issues seems to be in the netty-codec-http.
please fix this for newer versions
p.s.
I am getting this dependency from azure-identity.

same here. azure-core-http-netty.

This is fixed now. We have removed dependency on 4.1.68


Syntax theme color control for comments / documentation conventions

For every built-in color theme with Visual Studio Code, the assigned color for comments ...
//Default Dark+ Theme
{
	"scope": "comment",
	"settings": {
		"foreground": "#608b4e"
	}
}

... is being overridden by keywords associated with documentation conventions (JSDoc, etc), such as...
//Default Dark+ Theme
{
	"scope": "storage.type",
	"settings": {
		"foreground": "#569cd6"
	}
}

Example:

What key/value can be added to the theme files, either .json defaults or TextMate theme files, so that the color of comments remains intact.

You might want to check out the section 'Descendant selectors' from https://manual.macromates.com/en/scope_selectors.
With that you can say that 'comment storage.type' with be the comment color.
We don't plan to do that for the default themes. IMO having coloring inside comments is the wanted behaviour.

"IMO having coloring inside comments is the wanted behaviour"
Sounds daft to me. What's the point of defining a color for comments at all if it is going to be overridden by everything else?

Since the new version of VSCode has editor customization overrides in the User Settings, adding the following code will color comments gray when the Visual Studio color theme is Default Dark or Dark+, but it also works for most of the other built in themes as well.
"editor.tokenColorCustomizations": {
    "textMateRules": [
        {
            "scope": [
                "comment",
                "comment storage.type",
                "comment variable",
                "comment support.variable",
                "comment support.class",
                "comment support.type",
                "comment entity.name.type",
                "comment entity.name.class",
                "comment keyword.operator"
            ],
            "settings": {
                "foreground": "#666666"
            }
        }
    ]
}


Add log message when set temperature changed/recirc turned on

Currently no log info is printed to the homebridge log whenever a heater's set temperature is changed and/or recirc mode is turned on/off. Can we add some? Would be useful to know when homekit accessories are actually receiving the commands they are supposed to be receiving. Thanks!

Created a PR making this change here: https://github.com/dustindclark/homebridge-rinnai-controlr/pull/8


UploadImportAndApply-ConfigPackageInBcContainer never finish

Describe the issue
I'm trying to use this command: UploadImportAndApply-ConfigPackageInBcContainer with "DE.DEU.EVALUATION" but it never gets finished. After 3 hours the pipeline stopped.
Scripts used to create container and cause the issue
New-BCContainer -accept_eula `
    -containerName $containerName `
    -auth NAVUserPassword `
    -Credential $adminCredentials `
    -artifactUrl $artifactUrl `
    -licenseFile $licensefile `
    -shortcuts $shortcuts `
    -includeTestToolkit:$true`
    -doNotUseRuntimePackages `
    -assignPremiumPlan `
    -accept_outdated `
    -memoryLimit 12G `
    -multitenant:$false `
    -updateHosts `
    -useTraefik `
    -PublicDnsName $env:DNSNAME `
    -Restart always

Issue on:
UploadImportAndApply-ConfigPackageInBcContainer -containerName $containerName -configPackage $configPackageName -credential $credential

Full output of scripts
BcContainerHelper is version 2.0.13
BcContainerHelper is running as administrator
Host is Microsoft Windows Server 2019 Datacenter - ltsc2019
Docker Client Version is 20.10.4
Docker Server Version is 20.10.4

Screenshots

Additional context

does it happen all the time? yes (5 times tried)
did it use to work? no (first-time use)

Please try to use Run-ConnectionTestToBcContainer on the container after creating it and before running the uploadimportandapply command.
If that doesn't work, please create a script, which I can copy/paste, which repros the problem (including a dummy password and all), thanks.

CommunicationError : Response status code does not indicate success: 502 (Bad Gateway).
at , C:\ProgramData\BcContainerHelper\Extensions\Agent-02\PsConnectionTestTool\ClientContext.ps1: line 110
at , : line 62
at AwaitState, C:\ProgramData\BcContainerHelper\Extensions\Agent-02\PsConnectionTestTool\ClientContext.ps1: line 251
at OpenSession, C:\ProgramData\BcContainerHelper\Extensions\Agent-02\PsConnectionTestTool\ClientContext.ps1: line 217
at Initialize, C:\ProgramData\BcContainerHelper\Extensions\Agent-02\PsConnectionTestTool\ClientContext.ps1: line 78
at ClientContext, C:\ProgramData\BcContainerHelper\Extensions\Agent-02\PsConnectionTestTool\ClientContext.ps1: line 45
at New-ClientContext, C:\ProgramData\BcContainerHelper\Extensions\Agent-02\PsConnectionTestTool\PsTestFunctions.ps1: line 40
at , : line 55
ClientSession State is Uninitialized (Wait time 21 seconds)
at AwaitState, C:\ProgramData\BcContainerHelper\Extensions\Agent-02\PsConnectionTestTool\ClientContext.ps1: line 251
at OpenSession, C:\ProgramData\BcContainerHelper\Extensions\Agent-02\PsConnectionTestTool\ClientContext.ps1: line 217
at Initialize, C:\ProgramData\BcContainerHelper\Extensions\Agent-02\PsConnectionTestTool\ClientContext.ps1: line 78
at ClientContext, C:\ProgramData\BcContainerHelper\Extensions\Agent-02\PsConnectionTestTool\ClientContext.ps1: line 45
at New-ClientContext, C:\ProgramData\BcContainerHelper\Extensions\Agent-02\PsConnectionTestTool\PsTestFunctions.ps1: line 40
at , : line 55
at Invoke-ScriptInBcContainer, C:\Program Files\WindowsPowerShell\Modules\BcContainerHelper\2.0.13\ContainerHandling\Invoke-ScriptInNavContainer.ps1: line 44
at Run-ConnectionTestToBcContainer, C:\Program Files\WindowsPowerShell\Modules\BcContainerHelper\2.0.13\AppHandling\Run-ConnectionTestToNavContainer.ps1: line 194
at , C:\agent-02_work\72\s\Pipeline\Create-Environment\Create-Container.ps1: line 81
at , C:\agent-02_work_temp\1ec2d97f-6325-4391-8123-8b1811f83209.ps1: line 3
at , : line 1

what could be the problem why it get Bad Gateway?

what command (with parameters) did you run?

Run-ConnectionTestToBcContainer -containerName $containerName -credential $credential

please post a full script (including all variables) which fails and I can run to repro.

Param(
    [Parameter(Mandatory = $true)]
    [string] $containerName,

    [Parameter(Mandatory = $true)]
    [string] $sharedFolder,

    [Parameter(Mandatory = $true)]
    [string] $bcImage,

    [Parameter(Mandatory = $true)]
    [string] $artifactUrl,

    [Parameter(Mandatory = $true)]
    [PSCredential] $adminCredentials,

    [Parameter(Mandatory = $true)]
    [string] $workingDirectory,

    [Parameter(Mandatory = $true)]
    $cleanContainer,

    [Parameter(Mandatory = $true)]
    $includeTestToolkit = $false,

    [Parameter(Mandatory = $false)]
    [string] $licensefile,

    [Parameter(Mandatory = $true)]
    $importConfigPackage = $false,

    [Parameter(Mandatory = $true)]
    [string] $configPackageName
)

Write-Host "Creating needed parameters."
$shortcuts = "None"

$additionalParameters = @("--volume ""$($sharedFolder):$($sharedFolder)""",
                          "--env customNavSettings=EnableTaskScheduler=$false")

if($cleanContainer){
    $bcImage = ''
} else {
    $artifactUrl = ''
}

Write-Host "Starting to create container $containerName"
New-BCContainer -accept_eula `
    -containerName $containerName `
    -auth NAVUserPassword `
    -Credential $adminCredentials `
    -imageName $bcImage `
    -artifactUrl $artifactUrl `
    -additionalParameters $additionalParameters `
    -licenseFile $licensefile `
    -shortcuts $shortcuts `
    -includeTestToolkit:$includeTestToolkit `
    -doNotUseRuntimePackages `
    -assignPremiumPlan `
    -accept_outdated `
    -memoryLimit 12G `
    -multitenant:$false `
    -updateHosts `
    -useTraefik `
    -PublicDnsName $env:DNSNAME `
    -Restart always
    #-includePerformanceToolkit:$includeTestToolkit `

Write-Host "##[section] Set sharedFolder = $sharedFolder"
Write-Host "##vso[task.setvariable variable=sharedFolder]$sharedFolder"

Write-Host "Create Users"
$users = @("USER1","USER2","USER3")
foreach ($user in $users){
    $credential = New-Object PSCredential $user, $adminCredentials.Password
    New-BcContainerBcUser -Credential $credential -containerName $containerName -PermissionSetId 'SUPER' -ChangePasswordAtNextLogOn:$false
}

if($importConfigPackage){
    Run-ConnectionTestToBcContainer -containerName $containerName -credential $credential
    UploadImportAndApply-ConfigPackageInBcContainer -containerName $containerName -configPackage $configPackageName -credential $credential
}

The Calling Parameter are:
'C:\agent-02\_work\72\s\Pipeline\Create-Environment\Create-Container.ps1' -containerName "Agent-02" -sharedFolder "C:\agent-02" -bcImage "sandbox182de:TestToolkit" -artifactUrl "https://bcartifacts.azureedge.net/sandbox/18.2.26217.27444/de" -adminCredentials ([PSCredential]::new("XXXXX", (ConvertTo-SecureString -String "XXXXXX" -AsPlainText -Force))) -workingDirectory "C:\agent-02\_work\72\s" -licensefile "C:\agent-02\_work\_temp\fin.flf" -cleanContainer $True -includeTestToolkit $True -importConfigPackage $True -configPackageName "DE.DEU.EVALUATION"

enableTaskScheduler needs to be true in order to apply configuration packages.


Create Pull-Request shows up empty in pre-release version 0.55.2022110809

execute Create Pull request
observe:
The Changes in Pull Request #xxxx viewlet (the upper part) comes up emty

@sandy081 FYI

I also see an empty viewlet

Duplicate of https://github.com/microsoft/vscode-pull-request-github/issues/4164

Closing as dup then.


[SPARK-5000][SQL] Alias support string literal in spark sql

Alias support string literal in spark sql parser, such as
select key , value as 'vvv' from tableA;

Hi @marmbrus @OopsOutOfMemory , actually we have some customer's sql which is using quotes like this, if you think backticks is enough, i will close this.

Yeah, I don't think we want to have two different ways to do the same thing in our syntax.


Rename Virtual Desktops

I would like to rename a Virtual Desktop at run time, persisting those names is not necessary for me.

Hello @achim-t
I am sorry, but I don't think I understand what you are asking. Do you want to rename a desktop in the task view (as in #55)? If this is what you want then I'm sorry to inform you that, as stated in that issue this is not possible.
Otherwise, if you want to change the desktop names shown in the pop-ups please refer to the documentation.
Best regards

I want to change the names shown in the pop-ups, but I don't want to use the same names every time.

Ok, thank you for the clarification, now I understand: this is not a supported feature, but maybe there is something I can do.
According to what do you want the names to change?

I want to change it according to the task at hand.
I was imagining a shortcut like CTRL+WIN+F2 that opens up a prompt where I can enter a name like "Heavy Browsing" or "Work for Client X".

Ok, so you want to be able to manually change desktop names "on the run". I think this could definitely be a nice addition.
In fact I was thinking of something similar the other day, however in the next weeks I won't be able to dedicate time to this project at all.
I'll notify you on this issue about any news and updates.

Thanks.

I finally found some time to think about this: I ditched my previous idea about a more complex and complete system in favor of a simpler approach. Hope this helps.
Will let you know if this is merged into master.

Hello, @achim-t
your suggestion has been implemented in the last version of the program: the release for it should be published really soon.

Thank you, great work.

A small issue (should I create a new Issue?):
After renaming, the Tray Tooltip still shows the old name for the moment.

Thank you for noticing and rerporting this: I will fix this the next time I will work on this project.

FIxed and published in the new release.
Thank you again @achim-t.


Allow navigation to the details of a single student

Currently, you can only expand the details for all of the students of a given guide.
It is possible to filter the list, but sometimes you may want to have an overview of all of them and then you spot a specific one that you would want to see the details of.
It would be nice to have some way to navigate to the details of any particular student without the need of displaying the details for all of them or having to type something to narrow the list down.
Any of these options would do:

a separate screen, either modal or normal
an individual expand/collapse button toggle button

Duplicated of #32.

It's NOT the same, as I explained on #32. Please, re-open.

Ok, my bad. Reopening.


keybase prove github; username prompt not accepting inputs

brew install keybase
keybase --version: 1.0.16
keybase prove github:
Your username on Github: wgwz
Your username on Github: wgwz
Your username on Github<EMAIL_ADDRESS>Your username on Github: wgwz
Your username on Github: wgwz
Your username on Github: wgwz
Your username on Github: ▶ ERROR input canceled

Nothing is happening after I input my username.
Is the homebrew version of keybase out of date?
If so, can it be updated?

I am also experiencing the same problem. I am using keybase version 1.0.16 on an Archlinux install using the community/keybase package.
As a quick workaround, you should be able to simply provide your username on the command line as follows (it at least worked for me):
keybase prove github username

Also worked for me.


Fix types for some API fields

Change the following fields to the correct types defined by spec to allow clients enforcing types to function correctly:

is_spark

bool -> u8

is_saved

bool -> u8

is_read

bool -> u8

Update dependencies to allow build with latest Rust toolchain, also fix the CVEs reported by cargo-audit

LGTM. Thank you for the fix.


not working with obj-c project

Absolutely nothing appears on screen.
I am running on landscape and the pod file has the "use_frameworks!" if any of these matters.

Hmm, that's weird. Can you check the example project and tell me if you implemented the view in a similar way?


how to add customized infill pattern

i need to add a customized infill pattern to the Ultimaker Cura. how it can be done

Check this site:
https://community.ultimaker.com/topic/44394-cura-55-plugin-curaengine_plugin_infill_generate/?do=findComment&comment=327186


Add to golangci-lint

Describe the solution you'd like
Assuming other folks, besides myself, find this useful, it would be nice to add it to golangci-lint (which is all I use for linting).
Additional context
Docs on adding a linter to golangci: https://golangci-lint.run/contributing/new-linters/

A couple folks said they did want this. I imagine as a pre-req to trying/using it. WIP PR here: https://github.com/golangci/golangci-lint/pull/4290/files

This is merged. I'll close this after the next golangci-lint release and after this repo's README is updated with instructions for that linter

closed with: https://github.com/jjti/go-spancheck/commit/9cab7e90d1e12df133bff647c99157b9282065a8


Thinned out the website OWNERS file

Reducing the number of approvers to a handful, and removing some reviewers who have either left the project or not shown much activity in the last year.
Also added @Jeffwan as reviewer, so that he can LGTM the AWS-related PRs.

/assign @abhi-g
/assign @animeshsingh
/assign @Jeffwan
/assign @joeliedtke
Please would you take a look and let me know if you think I should add/remove any IDs. The goal is to to trim the number of approvers to people who have responsibility for the website as a whole, and to include people as reviewers if they're looking after a specific Kubeflow component or section of the docs.
Applying a hold to make sure all reviewers have time to comment:
/hold

Would it make sense to keep @neuromage as an approver since his team works on the DSL?

/lgtm
@joeliedtke  As Sarah says we can leave people as reviewers if needed. Most of the people are not familiar with the current website setup enough to qualify as owners.

@animeshsingh Our general philosophy with owners is to keep it to a minimum
and not expand it without reasons. I think more people can remain in the
"reviewers" list but the owners list should contain people who are
genuinely familiar with the repository and the setup.
On Wed, Mar 25, 2020 at 3:46 PM Animesh Singh<EMAIL_ADDRESS>wrote:

@animeshsingh commented on this pull request.
In OWNERS
https://github.com/kubeflow/website/pull/1845#discussion_r398216794:

richardsliu

sarahmaddox

texasmichelle

willingc

dsdinter

Ark-kun

gaoning777

hongye-sun

IronPan

neuromage

paveldournov

qimingj

rileyjbauer

vicaire
joeliedtke

Maybe part of Tech writers team?
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
https://github.com/kubeflow/website/pull/1845#discussion_r398216794, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/ACZ2UZXHM3AMRVLWN4OWU4LRJKCV7ANCNFSM4LTYT3QQ
.

Yes approvers can also lgtm a PR
On Wed, Mar 25, 2020 at 4:15 PM Sarah Maddox<EMAIL_ADDRESS>wrote:

@sarahmaddox commented on this pull request.
In OWNERS
https://github.com/kubeflow/website/pull/1845#discussion_r398227137:

@@ -52,7 +31,6 @@ reviewers:

paveldournov
qimingj
rileyjbauer

thedriftofwords
vicaire

Agreed that it'd be nice to remove the approvers from the reviewers list,
to make the list less overwhelming. @abhi-g https://github.com/abhi-g
do you know: does an approver have the ability to /lgtm if they're not
listed as a reviewer?
A reason for having people in the reviewers list is to relieve the burden
on the approvers - if a reviewer gives an LGTM for their area of the docs,
then the approver doesn't need to do a full review. A quick sanity check is
usually enough.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/kubeflow/website/pull/1845#discussion_r398227137, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/ACZ2UZXTIFU25FBBV3TX5BLRJKF7ZANCNFSM4LTYT3QQ
.

Yes approvers can also lgtm a PR
Thanks @abhi-g!

/lgtm

/approve

/hold cancel


Make reading of range tombstones more reliable (CASSANDRA-12811)

Merged into https://github.com/instaclustr/cassandra/pull/14