[BUG] AWS SigV4 Override Values Not Respected

Insomnia Version: 5.16.1
Operating System: MacOS

Details
As far as I can tell, the changes made in #830 / e0bfed5 are not working as intended. The region seems to be always set to us-east-1 unless the region appears in the URL and the service is also seemingly only being determined from the URL even if you try to override it.
 I just took a look at that PR and it looks like the entire thing is UI but I never actually added the code to use the values.
I don't have an API to test this with so I never noticed.

I didn't make a new release for this yet but I've uploaded a new build to the last release page. Let me know if it works!
https://github.com/getinsomnia/insomnia/releases/download/v5.16.1/Insomnia-5.16.1-mac.zip
or
https://github.com/getinsomnia/insomnia/releases/download/v5.16.1/Insomnia-5.16.1.dmg

I suggest actually using https://ec2.amazonaws.com/?Action=DescribeRegions&Version=2013-10-15 in your URL as the test because this is a valid API call (it seems AWS endpoints validate the API call before checking authorization). Also I am not sure if your test will work as the date part of the authorization header will change depending on what the time is when you run the tests (it won't always be 20180430).
Aside from all that, it seems that SigV4 auth doesn't actually work. Your changes work perfectly, the information is being substituted correctly in the right spot, but the authorization header seems to be incorrect. I tried on the original 5.16.1 build and the build you linked above, both don't work. Seems like it should be a new issue.
I am surprised nobody has noticed this wasn't working before? Please correct me if I am wrong.

Thanks for the info about the date @c22. I didn't even realize that parameter was a date. I'll change it to a looser match inside the regex.
Ya, feel free to submit a new issue. If you could provide a specific test case (request + expected token) it would help make the issue easier to debug. Also, if you want to take a look at debugging the issue from your end that would be much appreciated too 😄


Fix Sass syntax issue with empty-line-between-block rule

NB: Work in progress.
This PR fixes an issue with the empty-line-between-block rule and the Sass syntax. This has been a real pain mainly down to the differences in node structure that gonzales pumps out dependant on syntax. The end result isn't pretty and have resulted in using different code depending on which syntax is used.
Fixes #216
DCO 1.1 Signed-off-by: Ben Griffith<EMAIL_ADDRESS>

Closing this PR as it is being replaced by #258 where the fix is being bundled for a 1.3 release.


:sparkles: feat: custom lifecyclehooks for machinepools

Backported from https://github.com/kubernetes-sigs/cluster-api-provider-aws/pull/4875
Towards https://github.com/giantswarm/giantswarm/issues/31843

Added https://github.com/sebltm/cluster-api-provider-aws/commit/c35bbc3618ffec4b9a5e8df5bdf3dd4c7a2274c7 to fix the logic at creation time (embarrassing bug)


Default application TTL for an organization

Global organization setting for application TTL

[x]  API
[ ] General Settings UI

Default application TTL can be set with POST /api/v1/organization/settings/{setting_name} endpoint.


Unable to compile Zingo-pc

Tried to compile zingo-pc but it failed.
Using node v16.20.2 and rustc 1.69.0-nightly
Linux Mint 21, kernel 5.15.0-41-generic
full error:
Compiling zingolib v0.2.0 (https://github.com/zingolabs/zingolib?branch=dev#7aef7439)
error[E0658]: use of unstable library feature 'is_some_and'
    --> /home/[username]/.cargo/git/checkouts/zingolib-2003bc87acd6fa69/7aef743/zingolib/src/lightclient.rs:1491:14
     |
1491 |             .is_some_and(|trees| {
     |              ^^^^^^^^^^^
     |
     = note: see issue #93050 <https://github.com/rust-lang/rust/issues/93050> for more information
     = help: add `#![feature(is_some_and)]` to the crate attributes to enable

For more information about this error, try `rustc --explain E0658`.
error: could not compile `zingolib` due to previous error
Did not copy "cdylib:zingolib-native"
error Command failed with exit code 101.

Steps:
git clone https://github.com/zingolabs/zingo-pc.git
cd zingo-pc
nvm use v16.20.2
yarn install
yarn build

@james-katz Fixed. Pull all out, and try again, please... and let me know if it is working.

@juanky201271 thanks for the quick response. But unfortunately I got the exact same error when trying to compile.
Tried git pull ran a cargo clean inside native, and then tried to compile, no success.
Tried deleting and cloning the repo again, but got the same error :slightly_frowning_face:
I'll try to see if it's something I'm doing wrong.

@juanky201271 thanks for the quick reply.
unfortunately i got the same error.
tried pulling, tried deleting and cloning again, but got the same error, just the line number is different.

can you paste the new error even if seems the same... please...

   Compiling zingolib v0.2.0 (https://github.com/zingolabs/zingolib?branch=dev#6e0db927)
error[E0658]: use of unstable library feature 'is_some_and'
    --> /home/thiago/.cargo/git/checkouts/zingolib-2003bc87acd6fa69/6e0db92/zingolib/src/lightclient.rs:1523:14
     |
1523 |             .is_some_and(|trees| {
     |              ^^^^^^^^^^^
     |
     = note: see issue #93050 <https://github.com/rust-lang/rust/issues/93050> for more information
     = help: add `#![feature(is_some_and)]` to the crate attributes to enable

For more information about this error, try `rustc --explain E0658`.
error: could not compile `zingolib` due to previous error
Did not copy "cdylib:zingolib-native"
error Command failed with exit code 101.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

Compiling zingolib v0.2.0 (https://github.com/zingolabs/zingolib?branch=dev#6e0db927)
error[E0658]: use of unstable library feature 'is_some_and'
    --> /home/user/.cargo/git/checkouts/zingolib-2003bc87acd6fa69/6e0db92/zingolib/src/lightclient.rs:1523:14
     |
1523 |             .is_some_and(|trees| {
     |              ^^^^^^^^^^^
     |
     = note: see issue #93050 <https://github.com/rust-lang/rust/issues/93050> for more information
     = help: add `#![feature(is_some_and)]` to the crate attributes to enable

For more information about this error, try `rustc --explain E0658`.
error: could not compile `zingolib` due to previous error
Did not copy "cdylib:zingolib-native"
error Command failed with exit code 101.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

I would say, maybe I'm wrong... that the problem is the rust version, I think you need to upgrade it with rustup update...
I have this: rustc 1.74.0-nightly (5ae769f06 2023-09-26)
honestly I'm not sure, but this update I think is harmless for you.

"The simplest solution is often the best one."
Yes, upgrading my rust version fixes my problem. Thanks.

closing then....


[ru] Fixed grammatical error

Resolved conversation in #936
I incorrectly translated the word "verify". Instead, I write "check".
This pull request fixes a bug.

thank you


[Feature Request] Rotating logo to make every boot fresh

First massive thanks for your work developing ArkOS 🙇♂
I know I can replace logo.bmp with my own pic
My suggestion is how about a folder where I can store multiple pictures for logo with fixed filename like logo001.bmp, logo002.bmp and so on
At the shutdown process add simple copy and rename from logo folder to boot partition
The order is up to you, can be random or sequential
By doing it at the shutdown process, boot process will still the same and we'll see surprise logo every time we turn on our device
Just my random idea 😁
Again massive thanks for your work 🙇♂❤

This is already possible on rk3326 devices and was enabled at one point but most people seem to not like the feature and I got a request to disable it.  You can reenable it by doing the following:

You will need a network connection in order to remote into your installation.
If you need some info on how to ssh into your device, follow the instructions here: https://github.com/christianhaitian/arkos/wiki/Frequently-Asked-Questions---rg351mp#q-how-do-i-ssh-into-ArkOS and once you're in a ssh session, copy and paste the following command then press enter:
echo "@reboot /home/ark/.config/imageshift.sh &" | sudo tee -a /var/spool/cron/crontabs/root
Copy all your logos into a BMPs (case sensitive) folder on your fat32 boot partition then it should change to a different logo on every boot.

Wait what???
People actually asked you to disable additional awesome feature? why?? 😱
I have no idea about this and when it's happened but I assume if I don't want the logo to change automatically I can just use one logo right?
I also assume that it won't have performance hit to gaming right?
Then why people asked you to disable it?? can't think of any reason 🤔
Btw I understand the folder but is there any specific filename for the logos?

Tried your image shift command and succeeded 😍🎉
Thank you master for the info 🙇♂
I understand if you kinda upset with this matter due to the complaints you've received back then and won't enable this feature
I also understand I'm not in position to ask you anything here but I beg you please don't remove this in your future update 🙇♂
Thank you soooooo much master 🍻🙇♂

Happy it's working for you.  I won't remove it in any future updates.  It will just remain disabled on initial setup from a fresh image.  Enjoy!


[HOLD] move from OpenShiftTestAssistant to Arquillian Cube

I also reformatted the pom.xmls to use 2-space indentation (because that seems to be what the original pom.xml used). This clutters the diff somewhat; append ?w=1 to the URL to see the diff without whitespace changes.

Rebased and added back the awaiting of the route to return 200.

Updated to Arquillian Cube 1.9.1.


v0.9.3: Failed to execute 'compile' on 'WebAssembly': Incorrect response MIME type. Expected 'application/wasm'

I did the following in this project:

updated from 0.9.2 to 0.9.3
re-instated docker
copied Electric Provider from here: https://electric-sql.com/docs/integrations/frontend/react#electricprovider
corrected const isMounted = true to be mutable: let isMounted = true
cleared site data / application cache
npm run dev

the result is:

Maybe I'm doing something wrong?

The error seems to point to this line:
const conn = await ElectricDatabase.init('electric.db', '')

The second argument locateSqliteDist is now optional, and the bundler used can find the sqlite distribution without it - you can look at the sample app for a working example.
You're right that the docs are outdated, I've opened a PR to fix those https://github.com/electric-sql/electric/pull/992.

Thanks.
Somehow not this provider is returning undefined for db:
import { makeElectricContext } from 'electric-sql/react'

import { Electric } from './generated/client'

export const { ElectricProvider, useElectric } = makeElectricContext<Electric>()

You mean useElectric() returns undefined even when used within a child of the provider after an Electric client has been instantiated and provided? Could you provide a full repro example? (also, are you getting this issue when running the sample app mentioned above?)

You mean useElectric() returns undefined even when used within a child of the provider after an Electric client has been instantiated and provided?

yes

Could you provide a full repro example?

Do you mean a minimized fork of my app?

are you getting this issue when running the sample app mentioned above?

I am getting it when running https://github.com/barbalex/ps/tree/electric-sql-0-9-3

I am getting it when running https://github.com/barbalex/ps/tree/electric-sql-0-9-3

Running your repo I can't seem to reproduce what you're mentioning - have you managed to resolve this?
Either way, closing this issue as it relates to the wa-sqlite import, if useElectric continues to not work it'd be great if you can open a separate issue with a reproducible example


Adding AWGN to a signal

Adding Gaussian noise to a signal of a specific SNR. The signal may or may not have noise already

Hi @adeeb10abbas,
Could you be more precise on your issue. Is this a question? Do you report a bug? Do you ask for a feature?

Yes sorry about that. I am asking for a feature! Thanks!

Did you have a look to the

Yes, this works but partially. I am looking for something that can add noise to a signal that already has some amount of noise.

Replace noiseless_signal with your already noisy signal and it's done, isn't it?

So I wanted to figure out a way to add less say x amount of noise to a signal that already has y amount of noise (x and y are the snr). The output would be something with a z snr as it can't be a direct x + y as they are ratios. Does that make sense?


JOSS review - current state & integration to NiBabel

Ahoi hoi folks,
this is in reference to the review I'm currently conducting for JOSS (here).
First of all, thank you very much for your dedicated work on this tool that definitely is much needed and fills an important gap in the python neuroimaging realm.  One central question I was wondering about and targets a lot of checkboxes in the review process is the current state & planned integration into NiBabel (#110 here & #656 in NiBabel). I understand that the general plan is to integrate NiTransforms as a module  into NiBabel. However, NiTransforms' current state appears a bit nebulous concerning its place and documentation. Regarding the first, it might be helpful to clearly state that NiTransforms evolved out of a planned addition to Nibabel to its own repository and package for development reasons, but upon finalization will be integrated back into NiBabel. This blends into the second point, documentation. While I assume that functionality and API will be part of the NiBabel docs after the planned merge (with installation instructions then becoming obsolete), it would still be necessary to have these aspects/resources during the transition period, given the review process and to allow interested parties to use the software. I saw a docs folder and docs related PRs, but wasn't able to find a respective link. Would it be possible to provide a link for the documentation and maybe update the README to include the corresponding points?
I'm very sorry if I missed something obvious, misunderstood something or assumed something wrong. Please let me know if that is the case, as well as if you have any questions. Thanks again for creating this important software tool.
Cheers, Peer

Hi Peer!
You are right, docs are not being advertised! I added the link as the repo's website (https://nitransforms.readthedocs.io), but when browsing through noticed the API section is not populating. I'll take a look into that now.
@oesteban can you add me as a maintainer on RTD?

Hi @mgxd,
thank you very much for your quick reply and the information!
Ok, coolio, sounds great. Would you mind letting me know when you finished that work and I should have a look at it?
Thanks again.
Cheers, Peer

Should be all set after #120 - https://nitransforms.readthedocs.io/en/latest/api.html

You're a maintainer now :)
On Tue, Jul 13, 2021, 21:16 Mathias Goncalves @.***>
wrote:

Should be all set after #120
https://github.com/poldracklab/nitransforms/pull/120 -
https://nitransforms.readthedocs.io/en/latest/api.html
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/poldracklab/nitransforms/issues/118#issuecomment-879336371,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAESDRTL3PCZF3WGTTR3Y3DTXSGIRANCNFSM5AHP6EIA
.

I understand that the general plan is to integrate NiTransforms as a module into NiBabel. However, NiTransforms' current state appears a bit nebulous concerning its place and documentation. Regarding the first, it might be helpful to clearly state that NiTransforms evolved out of a planned addition to Nibabel to its own repository and package for development reasons, but upon finalization will be integrated back into NiBabel.

Yes, this is a great point. NiTransforms was envisioned as part of NiBabel since the beginning. However, shortly after starting out as a PR to NiBabel, we realized that it was going to build up in a humongous PR nobody would be able to review as thoroughly as it would require. Also, NiTransforms has many connections to BIDS/BIDS-Derivatives and its X5 format specification for transforms, which falls outside of the current scope of NiBabel.
So the plan is to make it an isolated tool, and once it is finished, integrate with NiBabel. On its end, NiBabel just initiated its CZI EOSS, so there's quite a lot of work ahead refactoring the library. The grant also covers aspects of NiTransforms. Once NiTransforms is ready for integration, we will define what can go in NiBabel (presumably everything, except perhaps some final details of the X5 implementation, although NiBabel will support the data structure at least logically).
This is to say that the chances that NiTransforms is integrated into NiBabel are high and scheduled to happen in ~10 months. The "bus factor" is high in this case thanks to the CZI funding. However, we believe NiTransforms can be considered as a software component of its own that deserves a focused publication at JOSS.
Regarding documentation, there's a whole lot of action items in the CZI grant for NiBabel (and NiTransforms too). When the implementation of all planned features is concluded, we will start generating tutorials. Some of them may also be covered by other funds we are trying to put together around NiPreps (www.nipreps.org).
Finally, we are planning to transfer over the repo under nipy (or at least, nipreps). We haven't done so this far as the poldracklab organization uses fewer resources from GitHub Actions and CircleCI at the moment. However, if you believe this would be important for the visibility of the project or other reasons I cannot think of right now, we are happy to push the transfer sooner than expected.

However, we believe NiTransforms can be considered as a software component of its own that deserves a focused publication at JOSS.

Which doesn't mean we will not follow a long deprecation cycle for those who try the code as in the JOSS publication. Importing from nitransforms will be supported for a long time (as a shim that uses nibabel underneath) until we are sure everyone is using nibabel's import directly.

Hi @oesteban,
thank you very much for your response and the additional information.
IMHO the plan/ideas outlined by you are very reasonable and understandable. I completely agree with NiTransforms' role as a dedicated software package/tool that definitely deserves its own publication. My comments were rather targeted at including this information in the docs and potentially manuscript. I'm very sorry for this misunderstanding.
P.S.: The entire work package around NiBabel's CZI seems fantastic!

Hi @mgxd (& @oesteban),
thanks a lot for updating the docs and adding the link to the repo.
Would it be possible to discuss a few further things? All the points I would like to bring up are actually perfectly summarized by @robbisg in the respective issue: installation, examples and contribution guidelines. Thus, I'll just point to the comments outlined there. One small general addition that would be cool: a CoC and one potential addition to the docs: the spatial transforms section of the paper, as it would add some great background information there as well.

thanks again @PeerHerholz !


only create volume for stdio protocol

rebased and merged as https://github.com/markfisher/sk8s/commit/981a61d02c705a4b924875876b06d1ab898d3eb7


Conserve generic from future and stream to Signal

Just transmit Generic of T when calling Stream.fromSignal() and Future.
Signal now hold the generic yet we still need to be explicit as inference
it not aware because SignalState has no generic.
Open question #12
source.subscribe((v) {
    // now a int but still generic without explicit cast
    if (v is SignalValue<int>) print(v.value);
});

final v = source.value;

  switch (v) {
    case SignalValue():
      print('===> ${v.value}' ); // value is generic
    case SignalError():
      print('error');
    case SignalLoading():
      print("loading");
  }

Thank you! for the PR!


How do you guarantee FIFO order from eredis to a haproxy/twemproxy which connects to multiple redis server?

Hi,
I am reading the code in https://github.com/wooga/eredis/blob/master/src/eredis_client.erl#L257
There is an assumption that redis server will return response based on FIFO order of requests.
My set up is eredis is connected to a haproxy/twemproxy which connects to multiple redis servers, so multiple redis server can return data in different order.
Does it break your assumption? Will it still work?
Cheers,
Howard

The Redis protocol specifies FIFO so it's really the only way to go. There's no other way of stitching a response back to a request.
Judging by the README of twemproxy (https://github.com/twitter/twemproxy#features) it sounds like it parses the request to understand which backend server to send it to. To a client, the proxy looks like the Redis server, so you should be good to use eredis or any other Redis client for that matter.

However, the assumption of FIFO may not be right here, since client sends request to haproxy/twemproxy, and response may come from 2 different redis servers behind haproxy/twemproxy.
                   ---Req1----Haproxy/twemproxy--->redis1
           ---Req2----------------Haproxy/twemproxy--->redis2
  ---Resp2-------------------------Haproxy/twemproxy<---redis2

-Resp1-----------------------------------Haproxy/twemproxy<---redis1
In the above diagram, Resp2 returns before Resp1, but it should be the other around.

In case of twemproxy, it would take care of reordering the responses to
match the order the client expects. If thats not the case, no Redis client
would work.
On Tue 13. Jun 2017 at 02:17, wminghao<EMAIL_ADDRESS>wrote:

However, the assumption of FIFO may not be right here, since client sends
request to haproxy/twemproxy, and response may come from 2 different redis
servers behind haproxy/twemproxy.
               ---Req1----Haproxy/twemproxy--->redis1
       ---Req2----------------Haproxy/twemproxy--->redis2

---Resp2-------------------------Haproxy/twemproxy<---redis2
-Resp1-----------------------------------Haproxy/twemproxy<---redis1
In the above diagram, Resp2 returns before Resp1, but it should be the
other around.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/wooga/eredis/issues/99#issuecomment-307964703, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAWPxAUYlTSUB8KHxbr-grXH2zDh9NQqks5sDcuUgaJpZM4NzZkE
.

That means if everything goes through twemproxy in a single connection, one redis server is slower than a faster redis server, the faster server will have to wait for the slower server to finish before it can receive the data?
Sounds a poor design to me.
I would use multiple connections instead in such case. eredis_pool will work.

You can use https://github.com/silviucpp/redis_pool . eredis_pool have some design issues:

It's using another gen_server proxy from where get's the pid of the redis connection inside the poolboy checkout. This is most probably because in the past eredis was crashing the gen_server when connection was lost and if too many crashes takes place in a short period of time the supervisor could stop. This is no longer the case as time newer versions of eredis can reconnect without crashing the gen_server.

poolboy seems overkill for managing a pool of redis connections. Instead erlpool overhead is resumed only to one ETS counter_update operation and one lookup

Silviu


Map out all the features of the apps on different platforms

Create wiki page with all the features

Done https://github.com/toggl/toggldesktop/wiki/Toggl-Desktop-Feature-List


unciv: 4.10.5 -> 4.10.8-jdkTest

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/yairm210/Unciv/releases.
meta.description for unciv is: An open-source Android/Desktop remake of Civ V
meta.homepage for unciv is: https://github.com/yairm210/Unciv
Updates performed

Version update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 4.10.6 in filename of file in /nix/store/q75spfxg8qi6r18lfqgpil4kfaqyhbw2-unciv-4.10.6

Rebuild report (if merged into master) (click to expand)

1 total rebuild path(s)

1 package rebuild(s)

First fifty rebuilds by attrpath
unciv

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/q75spfxg8qi6r18lfqgpil4kfaqyhbw2-unciv-4.10.6 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A unciv https://github.com/r-ryantm/nixpkgs/archive/13674e68f1ee0047885e9278d61202a16944bcb1.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/13674e68f1ee0047885e9278d61202a16944bcb1#unciv

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/q75spfxg8qi6r18lfqgpil4kfaqyhbw2-unciv-4.10.6
ls -la /nix/store/q75spfxg8qi6r18lfqgpil4kfaqyhbw2-unciv-4.10.6/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

unciv

Maintainer pings
cc @tex for testing.

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/yairm210/Unciv/releases.
meta.description for unciv is: An open-source Android/Desktop remake of Civ V
meta.homepage for unciv is: https://github.com/yairm210/Unciv
Updates performed

Version update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 4.10.7 in filename of file in /nix/store/3qycgzsnwxardps8szrm53cdyi0v53ch-unciv-4.10.7

Rebuild report (if merged into master) (click to expand)

1 total rebuild path(s)

1 package rebuild(s)

First fifty rebuilds by attrpath
unciv

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/3qycgzsnwxardps8szrm53cdyi0v53ch-unciv-4.10.7 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A unciv https://github.com/r-ryantm/nixpkgs/archive/1889e2ab0484bf0e2b66f10514378e881751f15d.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/1889e2ab0484bf0e2b66f10514378e881751f15d#unciv

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/3qycgzsnwxardps8szrm53cdyi0v53ch-unciv-4.10.7
ls -la /nix/store/3qycgzsnwxardps8szrm53cdyi0v53ch-unciv-4.10.7/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

unciv

Maintainer pings
cc @tex for testing.

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/yairm210/Unciv/releases.
meta.description for unciv is: An open-source Android/Desktop remake of Civ V
meta.homepage for unciv is: https://github.com/yairm210/Unciv
Updates performed

Version update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 4.10.8-jdkTest in filename of file in /nix/store/8pdqq4qsp61g23yad8m1fjxxr32m4kpf-unciv-4.10.8-jdkTest

Rebuild report (if merged into master) (click to expand)

1 total rebuild path(s)

1 package rebuild(s)

First fifty rebuilds by attrpath
unciv

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/8pdqq4qsp61g23yad8m1fjxxr32m4kpf-unciv-4.10.8-jdkTest \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A unciv https://github.com/r-ryantm/nixpkgs/archive/deae2e48ae358da3f1608ff6bef73d3f8abcc35e.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/deae2e48ae358da3f1608ff6bef73d3f8abcc35e#unciv

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/8pdqq4qsp61g23yad8m1fjxxr32m4kpf-unciv-4.10.8-jdkTest
ls -la /nix/store/8pdqq4qsp61g23yad8m1fjxxr32m4kpf-unciv-4.10.8-jdkTest/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

unciv

Maintainer pings
cc @tex for testing.

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/yairm210/Unciv/releases.
meta.description for unciv is: An open-source Android/Desktop remake of Civ V
meta.homepage for unciv is: https://github.com/yairm210/Unciv
Updates performed

Version update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 4.10.9 in filename of file in /nix/store/3f64lh8mk6a63kgp0zymfdg0vxc76717-unciv-4.10.9

Rebuild report (if merged into master) (click to expand)

1 total rebuild path(s)

1 package rebuild(s)

First fifty rebuilds by attrpath
unciv

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/3f64lh8mk6a63kgp0zymfdg0vxc76717-unciv-4.10.9 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A unciv https://github.com/r-ryantm/nixpkgs/archive/4271eed34335c7d7c20fb2f81d84fa45c5e8e6b0.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/4271eed34335c7d7c20fb2f81d84fa45c5e8e6b0#unciv

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/3f64lh8mk6a63kgp0zymfdg0vxc76717-unciv-4.10.9
ls -la /nix/store/3f64lh8mk6a63kgp0zymfdg0vxc76717-unciv-4.10.9/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

unciv

Maintainer pings
cc @tex for testing.

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/yairm210/Unciv/releases.
meta.description for unciv is: An open-source Android/Desktop remake of Civ V
meta.homepage for unciv is: https://github.com/yairm210/Unciv
Updates performed

Version update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 4.10.10 in filename of file in /nix/store/lvaag2rnnqi3bfd1fkviz3qs9zlixm7v-unciv-4.10.10

Rebuild report (if merged into master) (click to expand)

1 total rebuild path(s)

1 package rebuild(s)

First fifty rebuilds by attrpath
unciv

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/lvaag2rnnqi3bfd1fkviz3qs9zlixm7v-unciv-4.10.10 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A unciv https://github.com/r-ryantm/nixpkgs/archive/febd59e2fbd145de165c3baee6c021070cc8e144.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/febd59e2fbd145de165c3baee6c021070cc8e144#unciv

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/lvaag2rnnqi3bfd1fkviz3qs9zlixm7v-unciv-4.10.10
ls -la /nix/store/lvaag2rnnqi3bfd1fkviz3qs9zlixm7v-unciv-4.10.10/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

unciv

Maintainer pings
cc @tex for testing.

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/yairm210/Unciv/releases.
meta.description for unciv is: An open-source Android/Desktop remake of Civ V
meta.homepage for unciv is: https://github.com/yairm210/Unciv
Updates performed

Version update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 4.10.11 in filename of file in /nix/store/20vx92p4fv8w88dfcpxdpvzclrmbnrr3-unciv-4.10.11

Rebuild report (if merged into master) (click to expand)

1 total rebuild path(s)

1 package rebuild(s)

First fifty rebuilds by attrpath
unciv

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/20vx92p4fv8w88dfcpxdpvzclrmbnrr3-unciv-4.10.11 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A unciv https://github.com/r-ryantm/nixpkgs/archive/41fa2ac80e229a5ef872d6907dddb7f130da3c80.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/41fa2ac80e229a5ef872d6907dddb7f130da3c80#unciv

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/20vx92p4fv8w88dfcpxdpvzclrmbnrr3-unciv-4.10.11
ls -la /nix/store/20vx92p4fv8w88dfcpxdpvzclrmbnrr3-unciv-4.10.11/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

unciv

Maintainer pings
cc @tex for testing.

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/yairm210/Unciv/releases.
meta.description for unciv is: An open-source Android/Desktop remake of Civ V
meta.homepage for unciv is: https://github.com/yairm210/Unciv
Updates performed

Version update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 4.10.12 in filename of file in /nix/store/74hzz0f0zxf5fs4lz0g2zwakrknzb8lz-unciv-4.10.12

Rebuild report (if merged into master) (click to expand)

1 total rebuild path(s)

1 package rebuild(s)

First fifty rebuilds by attrpath
unciv

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/74hzz0f0zxf5fs4lz0g2zwakrknzb8lz-unciv-4.10.12 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A unciv https://github.com/r-ryantm/nixpkgs/archive/7d7c59a72f4e58821888a36cdd725bce46443d8a.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/7d7c59a72f4e58821888a36cdd725bce46443d8a#unciv

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/74hzz0f0zxf5fs4lz0g2zwakrknzb8lz-unciv-4.10.12
ls -la /nix/store/74hzz0f0zxf5fs4lz0g2zwakrknzb8lz-unciv-4.10.12/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

unciv

Maintainer pings
cc @tex for testing.

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/yairm210/Unciv/releases.
meta.description for unciv is: An open-source Android/Desktop remake of Civ V
meta.homepage for unciv is: https://github.com/yairm210/Unciv
Updates performed

Version update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 4.10.14 in filename of file in /nix/store/5pmhv28pgn78jqfr75h3fbzg2ijqgl17-unciv-4.10.14

Rebuild report (if merged into master) (click to expand)

1 total rebuild path(s)

1 package rebuild(s)

First fifty rebuilds by attrpath
unciv

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/5pmhv28pgn78jqfr75h3fbzg2ijqgl17-unciv-4.10.14 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A unciv https://github.com/r-ryantm/nixpkgs/archive/2e959d4e678b650b0d8cf1eaf9716dfb43a6f6f5.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/2e959d4e678b650b0d8cf1eaf9716dfb43a6f6f5#unciv

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/5pmhv28pgn78jqfr75h3fbzg2ijqgl17-unciv-4.10.14
ls -la /nix/store/5pmhv28pgn78jqfr75h3fbzg2ijqgl17-unciv-4.10.14/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review --extra-nixpkgs-config '{ allowInsecurePredicate = x: true; }' run on x86_64-linux 1

1 package built:

unciv

Maintainer pings
cc @tex for testing.

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/yairm210/Unciv/releases.
meta.description for unciv is: An open-source Android/Desktop remake of Civ V
meta.homepage for unciv is: https://github.com/yairm210/Unciv
Updates performed

Version update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 4.10.15 in filename of file in /nix/store/9dpj45ncckvxn2ncp5y2lm800qp12vps-unciv-4.10.15

Rebuild report (if merged into master) (click to expand)

1 total rebuild path(s)

1 package rebuild(s)

First fifty rebuilds by attrpath
unciv

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/9dpj45ncckvxn2ncp5y2lm800qp12vps-unciv-4.10.15 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A unciv https://github.com/r-ryantm/nixpkgs/archive/8622761bd97f0ae3cfca6e3aa2797aca30047b1a.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/8622761bd97f0ae3cfca6e3aa2797aca30047b1a#unciv

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/9dpj45ncckvxn2ncp5y2lm800qp12vps-unciv-4.10.15
ls -la /nix/store/9dpj45ncckvxn2ncp5y2lm800qp12vps-unciv-4.10.15/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review --extra-nixpkgs-config '{ allowInsecurePredicate = x: true; }' run on x86_64-linux 1

1 package built:

unciv

Maintainer pings
cc @tex for testing.

Result of nixpkgs-review pr 286452 run on aarch64-darwin 1

1 package built:

unciv


No scaffols_FINAL file

Heys,
As previous users already mentioned, when I run my 60x Hi-C data with salsa 2.2, everything runs well but the final output does not appear. This is similar as experienced by several other users as #16 or #18. I did sort the Hi-C data with sort -k 4. I am using an enzyme-free protocol, so I add DNASE as enzyme, is that correct?
Why is it not working? Anybody with the same problem?
Thanks in advance!

I think I was specifying the DNASE within the file called re_bases and you should mention it in the function itself. I am trying this and I will let you know, just in case it is not clear for future users.

It did not worked, but I created a new environment following #155 and worked!


[bug]: [cli]  No longer can login to embassy cli

Prerequisites

[X] I have searched for existing issues that already report this problem, without success.

EmbassyOS Version
0.3.1~pre
Device
Laptop/Desktop
Device OS
Linux
Device OS Version
Ubuntu
Browser
Firefox
Browser Version
N/A
Current Behavior

I ssh into the box
I run the embassy-cli auth login
And now I get

Expected Behavior
To login
Steps to Reproduce
See behavior
Anything else?
No response

☝


created themes.md

translated the themes guide, realised that when everything is translated, a final pass to make sure all internal links match will be needed lol

I've updated the broken links, also renamed the files to their english name, because with Vitepress if you use the language picker it redirects you to a page of the same URL in the other language, so if they're not named the same they 404.


Add a way to poll metrics from an interface

Since all metrics are send to one 0mq subscriber endpoint it's harder
to get metrics from a given interface, by using get_metrics() RPC function
users can have a quick look on a given interface metrics.
This just a first step, since get_metrics() call will return results from
different instances each time it's called in case we are running different
service instance, so for now this should only be used for debugging purposes.

:+1:


JBPM-5071 - Clean up and remove the process runtimes from the workbench

this is as part of JBPM-5071 - Clean up and remove the process runtimes from the workbench
to ease collaboration some work that does not affect other components that forked would be good to be placed on master as they are functional as standalone

jenkins retest this


Update dependencies after POM refactoring

Refers to https://github.com/Activiti/Activiti/issues/1995


custom rewrite does not work without file extensions

The custom rewrite environment variables do not work if the key doesn't have a file extension.
https://github.com/awslabs/serverless-image-handler/blob/master/source/image-handler/image-request.js#L282 The regex checks if a file extension exists and custom request type is only selected if both the regex match and the environment variables are defined. Is the existence of the environment variables not a sufficient enough check? The regex limits it to keys with file extensions.
Is there any way to support custom expressions for keys without file extensions?

Thanks for the feedback. We will investigate and add this to our backlog.

@SNagappan we have updated our solution, and I believe your issue has been fixed. If you still see the issue with the latest version (v6.0.0), please feel free to reopen the issue.
You can refer to the recent changes here.


Fixed Bug: signature generation. Converting dict key order

LGTM (because I've corrected the comments myself;)).


oraclejdk: 8u65, 8u66 -> 8u71, 8u72

8u71 is Critical Patch Update (CPU), contains security vulnerability fixes.
8u72 is Patch Set Update (PSU), contains security vulnerability fixes and other bug fixes.
8u71 release notes: http://www.oracle.com/technetwork/java/javase/8u71-relnotes-2773756.html
8u72 release notes: http://www.oracle.com/technetwork/java/javase/8u72-relnotes-2775802.html
Both tested on x86_64.

@taku0 pr doesn't apply cleanly ... i'll copy paste stuff out


[networks] Eliminate allocations from gatewayLookup

What does this PR do?
Eliminate the majority of allocations in the gatewayLookup codepath. Basically three changes were made:

Fix IPBufferPool;
Cache network.Via objects directly
Use util.IPLen instead of len(address.Bytes()) which allocates;

In one of the hosts from our load test cluster these changes resulted in a ~30% decrease in the global allocation rate:

Motivation

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

Reviewer's Checklist

[ ] If known, an appropriate milestone has been selected; otherwise the Triage milestone is set.
[ ] The appropriate team/.. label has been applied, if known.
[ ] Use the major_change label if your change either has a major impact on the code base, is impacting multiple teams or is changing important well-established internals of the Agent. This label will be use during QA to make sure each team pay extra attention to the changed behavior. For any customer facing change use a releasenote.
[ ] A release note has been added or the changelog/no-changelog label has been applied.
[ ] Changed code has automated tests for its functionality.
[ ] Adequate QA/testing plan information is provided if the qa/skip-qa label is not applied.
[ ] If applicable, docs team has been notified or an issue has been opened on the documentation repo.
[ ] If applicable, the need-change/operator and need-change/helm labels have been applied.
[ ] If applicable, the config template has been updated.

💯  @p-lambert


Should I use  or a MDL class?

This is not clear to me from reading the docs - do I need to add MDL classes to all the HTML elements in order for them to take part in the subtle changes to text formatting by MDL?
Could I just use classless HTML and I would still be good?
What are the minimum classes I need to specify for a great looking, responsive MDL, mainly text  page?

V1 includes a set of direct element targets to get some basic MDL text styling by default. You can take a look at the typography component to see exactly what is done.

@Garbee That link is 404.
I have the same question. Do I need to add mdl classes to my h1, h2, h3... If I do, what are they?

I fixed the link to point to the new branch.
Check the style documentation for the classes (view source as well, checking now the docs are just saying what the display is, not the full class name to use.)
In our default builds, headings are handled by default (view the previous link to the component.) If you aren't using one of those native targets, then you'd need to use the classes.


Disable qdc by default, make it configurable

Curently QDC (queue depth control) is enabled by default, but as
this can be detrimental to performance this we now disable it by
default. However, it can be enabled again with the existing
values by setting enable_qdc true when running the
playbook.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

This is closed because we did https://github.com/redpanda-data/deployment-automation/pull/64 instead.


Add no-std fix for WASM/Substrate chains

This fixes a no-std issue to allow Substrate-based chains to use the zkvm within their WASM runtimes - at least for verification, as I'd tested. It's valuable to maintain support for WASM environments, as it opens Risc0 up to be used by hundreds more projects.
The change simply resolves an error on the Substrate-side which is fairly common for no-std issues. Though this one points at num_traits:
  error[E0152]: duplicate lang item in crate `sp_io` (which `sp_runtime` depends on): `panic_impl`.
    |
    = note: the lang item is first defined in crate `std` (which `num_traits` depends on)
    = note: first definition in `std` loaded from /home/justin/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/lib/rustlib/wasm32-unknown-unknown/lib/libstd-a643c5931c4d12de.rlib
    = note: second definition in `sp_io` loaded from /home/justin/dev/substrate-risc0/target/release/wbuild/node-template-runtime/target/wasm32-unknown-unknown/release/deps/libsp_io-3b94b351090fd32d.rmeta

  For more information about this error, try `rustc --explain E0152`.
  error: could not compile `sp-runtime` due to previous error

I tested in a sample Substrate project and found that the change works.

Hi @justinFrevert thanks for your PR. So we have a build of WASM and I'm surprised that it didn't catch this...

I see what's going on now. Our build of the wasm verifier doesn't include a lot of other crates so we don't run into this build issue!

@SchmErik is that with the wasm crate? I actually didn't figure out how that to run with/without the changes.

It's possible I may be able to help some with the WASM check, but would need help understanding the aim for this crate a bit. Are we just wanting more dependencies for this wasm crate? @SchmErik

@justinFrevert heads up, minor issue in our CI. That failure is on us, and I should have a fix in soonish.
Sorry about that.


ignore capitalization in filenames when extracting version

cf. https://github.com/Hochfrequenz/kohlrahbi/issues/381

Closed with https://github.com/Hochfrequenz/migmose/pull/123


goto_left and goto_right for next/last variants

Contributing guidelines

[X] I have read CONTRIBUTING.md
[X] I have read CODE_OF_CONDUCT.md

Module(s)
mini.ai
Description
It would be great if it was possible specify where to jump to with next/last variants, e.g. g]n). This would be especially useful with search_method = cover.

Thanks for the suggestion!
My first instinct is that it adds too even more complexity to already overcrowded config.mappings. Implementation-wise this should be pretty straightforward, but will also add documentation and testing burden (both to mappings and underlying exported implementation function).
Also while I do agree that four g{[,]}{n,l} are the right choice of mapping keys for this, they don't look too ergonomic on a standard QWERTY keyboard.
So my suggestion would be to make mappings manually. With something like this:
local map_nextlast_motion = function(lhs, side, search_method)
  local rhs = function()
    MiniAi.move_cursor(side, 'a', vim.fn.getcharstr(), { search_method = search_method, n_times = vim.v.count1 })
  end
  local desc = 'Go to ' .. side .. ' side of ' .. search_method .. ' textobject'
  vim.keymap.set({ 'n', 'x', 'o' }, lhs, rhs, { desc = desc })
end

map_nextlast_motion('g[n', 'left', 'next')
map_nextlast_motion('g]n', 'right', 'next')
map_nextlast_motion('g[l', 'left', 'prev')
map_nextlast_motion('g]l', 'right', 'prev')

Closing as not planned.


Worker doesn't start when minio enabled

When minio enabled, worker is searching for non existing pvc, because there is a missing condition.
Line 179 and 185 in worker-deployment.yaml, instead of
{{ if not .Values.global.s3.enabled }}
can someone just put
{{- if and (not .Values.global.s3.enabled) (not .Values.minio.enabled) }}

Same issue here: The PVC is still referenced in the lago-worker.
And there is no s3/minio configuration in lago-worker when minio is enabled.

{{ if not .Values.global.s3.enabled }}

Good catch here sorry about that. PR is on the way

what about S3 credentials in lago-worker if using minio? I would expect S3 environment variables in the worker-deployment just like in api-deployment: https://github.com/getlago/lago-helm-charts/blob/7d1856e362f48a0e26d868d11637469b059e7e85/templates/api-deployment.yaml#L148

Correct @grthr PR is on the way

Its now merge & should be good. Feel free to re-open  this issue if its doesn't solve.


[openimageio] Fix find and use dependencies

Fix find dependency libpng and libheif.
Restore FindOpenEXR.cmake since it calls find_dependency(OpenEXR CONFIG) and it contains the required macro FOUND_OPENEXR_WITH_CONFIG in OpenImageIOConfig.cmake.
Add dependency port libsquish.
Add 3 find_dependency in OpenImageIOConfig.cmake to fix usage issues.
Install FindLibsquish.cmake since libsquish and cmake doesn't provide the find method.
Fix vcpkg-cmake-wrapper since we always use it which in the lower-case port name path.

Fixes #19878 #19884.

@jmacey Can you please test my changes?
Thanks.

Testing now but this branch still has the glib https://github.com/microsoft/vcpkg/issues/19558  error which I need to fix first.
On 2 Sep 2021, at 07:59, Jack·Boos·Yu<EMAIL_ADDRESS>wrote:
@jmaceyhttps://eur02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fjmacey&data=04|01|jmacey%40bournemouth.ac.uk|9684a00de3404f80cb1108d96ddf2ab9|ede29655d09742e4bbb5f38d427fbfb8|0|0|637661627527533942|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=PptJOkhRUb598z2jkXlyMX1mJvq0XmJyeb2BDGQPnqc%3D&reserved=0 Can you please test my changes?
Thanks.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://eur02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fmicrosoft%2Fvcpkg%2Fpull%2F19916%23issuecomment-911284374&data=04|01|jmacey%40bournemouth.ac.uk|9684a00de3404f80cb1108d96ddf2ab9|ede29655d09742e4bbb5f38d427fbfb8|0|0|637661627527543942|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=7iYuYj7IgnSSP6ewfAc28CuFXF%2BfTWOGMKRPT4a0nMI%3D&reserved=0, or unsubscribehttps://eur02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAACK4G5WZXYIPCSE3DXF4TLT74OD3ANCNFSM5DILDGDQ&data=04|01|jmacey%40bournemouth.ac.uk|9684a00de3404f80cb1108d96ddf2ab9|ede29655d09742e4bbb5f38d427fbfb8|0|0|637661627527543942|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=r6lSQxLVr37M%2FvjYA54VvamjfxBdtskx3u%2FOuw5hSgw%3D&reserved=0.
Triage notifications on the go with GitHub Mobile for iOShttps://eur02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fapps.apple.com%2Fapp%2Fapple-store%2Fid1477376905%3Fct%3Dnotification-email%26mt%3D8%26pt%3D524675&data=04|01|jmacey%40bournemouth.ac.uk|9684a00de3404f80cb1108d96ddf2ab9|ede29655d09742e4bbb5f38d427fbfb8|0|0|637661627527553937|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=LWVdMblAerXcgv2Cw6Sv2cRkQzLN5pB9ZJGy9fvcAno%3D&reserved=0 or Androidhttps://eur02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fplay.google.com%2Fstore%2Fapps%2Fdetails%3Fid%3Dcom.github.android%26referrer%3Dutm_campaign%253Dnotification-email%2526utm_medium%253Demail%2526utm_source%253Dgithub&data=04|01|jmacey%40bournemouth.ac.uk|9684a00de3404f80cb1108d96ddf2ab9|ede29655d09742e4bbb5f38d427fbfb8|0|0|637661627527553937|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=MSHc2QGsORrPpzDrrlGPPYDGVmTf1CCVq9iXuwx3yJw%3D&reserved=0.

BU is a Disability Confident Employer and has signed up to the Mindful Employer charter. Information about the accessibility of University buildings can be found on the BU AccessAble webpages.
This email is intended only for the person to whom it is addressed and may contain confidential information. If you have received this email in error, please notify the sender and delete this email, which must not be copied, distributed or disclosed to any other person.
Any views or opinions presented are solely those of the author and do not necessarily represent those of Bournemouth University or its subsidiary companies. Nor can any contract be formed on behalf of the University or its subsidiary companies via email.

@jmacey  This PR will not fix issue https://github.com/microsoft/vcpkg/issues/19558 because I don't find out the reason.
And it should be good now for the Libsquish issue.

Tested this PR success:
cmake_minimum_required(VERSION 3.10)

project(sample)
find_package(OpenImageIO CONFIG REQUIRED)
add_executable(sample test.cpp)
target_link_libraries(sample PRIVATE OpenImageIO::OpenImageIO OpenImageIO::OpenImageIO_Util)

result:
root@usr:/home/usr/work/test# ./../vcpkg/downloads/tools/cmake-3.20.2-linux/cmake-3.20.2-linux-x86_64/bin/cmake CMakeLists.txt  -DCMAKE_TOOLCHAIN_FILE=/home/usr/work/19916/vcpkg/scripts/buildsystems/vcpkg.cmake
-- The C compiler identification is GNU 7.5.0
-- The CXX compiler identification is GNU 7.5.0
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working C compiler: /usr/bin/cc - skipped
-- Detecting C compile features
-- Detecting C compile features - done
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: /usr/bin/c++ - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Looking for pthread.h
-- Looking for pthread.h - found
-- Performing Test CMAKE_HAVE_LIBC_PTHREAD
-- Performing Test CMAKE_HAVE_LIBC_PTHREAD - Failed
-- Looking for pthread_create in pthreads
-- Looking for pthread_create in pthreads - not found
-- Looking for pthread_create in pthread
-- Looking for pthread_create in pthread - found
-- Found Threads: TRUE
CMake Warning (dev) at /home/usr/work/19916/vcpkg/installed/x64-linux/share/zlib/vcpkg-cmake-wrapper.cmake:13 (_find_package):
  Policy CMP0074 is not set: find_package uses <PackageName>_ROOT variables.
  Run "cmake --help-policy CMP0074" for policy details.  Use the cmake_policy
  command to set the policy and suppress this warning.

  CMake variable ZLIB_ROOT is set to:

    /home/usr/work/19916/vcpkg/installed/x64-linux

  For compatibility, CMake is ignoring the variable.
Call Stack (most recent call first):
  /home/usr/work/19916/vcpkg/scripts/buildsystems/vcpkg.cmake:738 (include)
  /home/usr/work/vcpkg/downloads/tools/cmake-3.20.2-linux/cmake-3.20.2-linux-x86_64/share/cmake-3.20/Modules/CMakeFindDependencyMacro.cmake:47 (find_package)
  /home/usr/work/19916/vcpkg/installed/x64-linux/share/openexr/OpenEXRConfig.cmake:29 (find_dependency)
  /home/usr/work/19916/vcpkg/installed/x64-linux/share/openexr/vcpkg-cmake-wrapper.cmake:1 (_find_package)
  /home/usr/work/19916/vcpkg/scripts/buildsystems/vcpkg.cmake:738 (include)
  /home/usr/work/vcpkg/downloads/tools/cmake-3.20.2-linux/cmake-3.20.2-linux-x86_64/share/cmake-3.20/Modules/CMakeFindDependencyMacro.cmake:47 (find_package)
  /home/usr/work/19916/vcpkg/installed/x64-linux/share/OpenImageIO/OpenImageIOConfig.cmake:36 (find_dependency)
  /home/usr/work/19916/vcpkg/installed/x64-linux/share/openimageio/vcpkg-cmake-wrapper.cmake:4 (_find_package)
  /home/usr/work/19916/vcpkg/scripts/buildsystems/vcpkg.cmake:738 (include)
  CMakeLists.txt:5 (find_package)
This warning is for project developers.  Use -Wno-dev to suppress it.

-- Found ZLIB: /home/usr/work/19916/vcpkg/installed/x64-linux/lib/libz.a (found version "1.2.11")
-- Found Libsquish: /home/usr/work/19916/vcpkg/installed/x64-linux/include
-- Found ZLIB: /home/usr/work/19916/vcpkg/installed/x64-linux/lib/libz.a (found suitable version "1.2.11", minimum required is "1.2.11")
-- Configuring done
-- Generating done
-- Build files have been written to: /home/usr/work/test
root@usr:/home/usr/work/test# make
[ 50%] Building CXX object CMakeFiles/sample.dir/test.cpp.o
[100%] Linking CXX executable sample
[100%] Built target sample

Thanks for the fix!

I've just done a git pull on the master and removed the old downloads and installs and still get this error
CMake Error at C:/Users/jpmac/vcpkg/installed/x64-windows/share/OpenImageIO/OpenImageIOConfig.cmake:33 (elseif):
given arguments:
"2.5.0" "VERSION_GREATER_EQUAL" "2.4" "AND"

If I edit the OpenImageIOConfig.cmake and add
elseif (2.5.0 VERSION_GREATER_EQUAL 2.4 AND FOUND_OPENEXR_WITH_CONFIG )
It all works fine, so it seems that there is still some sort of error with this fix in the master.
.\vcpkg.exe --version
Vcpkg package management program version 2021-08-12-85ab112d5ee102bc6eac8cdbbfdd173a71374e04

That's caused by wrongly merge to master.


0.30 RC1 Woocommerce 3.0 compatibility and other fixes

fixes #137, fixes #131, fixes #130, fixes #110, fixes #117, fixes #97, fixes #94, fixes #84, fixes #83, fixes #82      adaptations for wooCommerce 3.0
fixes #136 Variable product stock sync issue where stock managed at parent level
fixes #132 Add settings Page link to plugins page
fixes #128 Allow variation description to be editable in translations
fixes #129, fixes #138 Account page only shows orders in current language
fixes #112 Shipping Class are not sync for Product Variations
and
fixes #140, fixes #142, fixes #143, fixes #89, fixes #70 Email Translation issues
fixes #145 correct link from Polylang to Attributes Strings translations
fixes #95 WooCommmerce product shortcodes not filtering by language
fixes #104 by allowing translation of Price Display Suffix

@Jon007 , @decarvalhoaa thanks for the amazing Job


changeset process continues running when ended while waiting for external editor

Affected Packages
@changesets/cli
Problem
Related to #498. The changeset cli fails to run my external editor and simply hangs. Escaping the process using ^C does not end the process and it continues consuming a decent amount of CPU in the background.

Sometimes the process is listed as changeset and other times it's listed as node. Not entirely sure what causes the difference.
Proposed solution

Could you list the exact required steps to reproduce the problem? It would make it easier for me to try debugging this.

Could you list the exact required steps to reproduce the problem? It would make it easier for me to try debugging this.

Absolutely!

export EDITOR=vim to set editor to terminal-based process
Run changeset cli
Select a package and a version to bump
At "Summary" line, press enter to open external editor
Nothing happens, so CtrlC to escape
Find process still running in the background (was able to find it locally with ps aux | grep changeset)

Repeat 2-5 a few times and you should find a running process for each.

same issue over here

same issue over here

I've just tried this using the provided repro steps and I wasn't able to repro this - would any of you be willing to setup a call with me to hunt this down?

@Andarist Absolutely!

It seems that the root cause is the same as https://github.com/atlassian/changesets/issues/498 so let's keep that other issue open and close this one for now. I've reported the issue to the package we are using here: https://github.com/mrkmg/node-external-editor/issues/24

It seems that the root cause is the same as https://github.com/atlassian/changesets/issues/498 so let's keep that other issue open and close this one for now. I've reported the issue to the package we are using here: https://github.com/mrkmg/node-external-editor/issues/24


Use node's ipc for desktop TypeScript server

On desktop, VS Code currently communicates with the TypeScript server by passing messages over stdio. These messages are in a json rcp style format
We should instead explore using node's built-in ipc support which would let the two processes communicate using .send and .on('message', ...)
Advantages

JSON is exchanged directly so we can get rid of this parsing logic on the VS Code side: https://github.com/microsoft/vscode/blob/53350bc6661449bc097496b04a1d8712474bd301/extensions/typescript-language-features/src/tsServer/serverProcess.electron.ts#L27
Accidental console.log in a ts server plugin will not crash the process (this currently happens if any non-json content is written to stdout)
This would align the desktop TS Server more with the web version

VS Code PR: https://github.com/microsoft/vscode/pull/135341
TS PR: https://github.com/microsoft/TypeScript/pull/46418

This would also fix:

https://github.com/microsoft/TypeScript/issues/46417
https://github.com/microsoft/vscode/issues/85565

@DanielRosenwasser Let's talk about this for 4.6


Fixes NPE in HttpProxyDataFactory when is called with unknown host.

I don't think an unknown host should fail gracefully. Can you explain why you think it should?
Closed #2166 as a duplicate, why open multiple PRs?

@spencergibb @ryanjbaxter
After checking the issue in details with local builds for SCS tile I  found the root cause of the NPE.
Basically if git configuration is done using IP address instead of hostname, config-server won't be able to find the git configs.  I've changed the code to look for both hostname and IP address for ssh calls.
This new private method findEnvironmentProperties is the one that does the job.
btw, I've used <IP_ADDRESS> and localhost in unit tests to verify the fix. but i'm not sure if in the pipeline or other developers machine localhost resolves to <IP_ADDRESS>. do you have any suggestion?

@kvmw i thought there was an issue opened that this PR resolved but I don't see it, am I just missing it, or am I imagining that and there wasn't a corresponding issue open?

I don't think an unknown host should fail gracefully.

Covering up a NPE isn't satisfactory to me. There should be an error that you couldn't reach the proxy shouldn't it?

@kvmw i thought there was an issue opened that this PR resolved but I don't see it, am I just missing it, or am I imagining that and there wasn't a corresponding issue open?

@ryanjbaxter
There is no issue reported for the PR. I think I was the first one faced this issue because SCS mirror service is using IP address instead of hostname for the configuration.  I can create one if is needed.

No need for a new issue

Maybe the happy middle ground here is if there isn't any proxy information in the app configuration then we log a warning saying that no information is found and they should check their configuration. I think the issue is we are concerned that things just continue as normal without any idea that something may be wrong.

@ryanjbaxter After checking the old commits (before Apache MINA migration) and also trying few scenarios, I came to conclusion that those methods won't be called with arbitrary hostnames or IP addresses.  So I removed the unnecessary null checks and also updated the PR title to avoid confusion.

@kvmw when I merged this forward in the main branch this test is failing
https://github.com/spring-cloud/spring-cloud-config/blob/main/spring-cloud-config-server/src/test/java/org/springframework/cloud/config/server/ssh/PropertyBasedSshSessionFactoryTest.java#L251
Looks like its because there isn't any ssh configuration for the host.  This test doesn't exist in the 3.1.x branch.  Maybe there is a null check missing?

@ryanjbaxter  main branch is slightly different from the 3.1.x.  When Apache MINA was introduced there were some breaking changes which we kept in main but not in 3.1.x.
Do you want me to create a PR for the main branch too?

Sure although I might just take that and modify the merge to keep things simple as we are merging t 3.1.x into main.

Sure although I might just take that and modify the merge to keep things simple as we are merging t 3.1.x into main.

In that case you may update that test like following to avoid NPE:
	@Test
	public void defaultSshConfigIsSet() {
		JGitEnvironmentProperties sshProperties = new JGitEnvironmentProperties();
		sshProperties.setUri("ssh://gitlab.example.local:3322/somerepo.git");
		setupSessionFactory(sshProperties);

		SshConfigStore.HostConfig sshConfig = getDefaultSshHostConfig("gitlab.example.local", 123, "user.name");

		assertThat(sshConfig.getValue("HostName")).isEqualTo("gitlab.example.local");
		assertThat(sshConfig.getValue("Port")).isEqualTo("123");
		assertThat(sshConfig.getValue("User")).isEqualTo("user.name");
	}

The  JGitEnvironmentProperties needs at lest the URI.

Thanks that appears to get things working.  If you want to look at the latest commits from me on main just to make sure I didn't screw anything up that would be appreciated.


Custom Loss Functions for RL

We should think about common loss functions that are used a lot in RL that can be packaged. As of now, we're constructing everything from scratch so we're going towards implementations.
Check this: https://github.com/tensorforce/tensorforce/tree/master/tensorforce/core/objectives
This does not have a lot of them though

Yea I agree we should have loss functions of our own. Maybe make a checklist for the same here :P

I'm out of ideas here. If anyone has any idea to add something useful here, go ahead


[i18nIgnore] Add src alias

Description

[x] brings alias for docs/src path
[ ] allow users to code navigate using ctrl/cmd + left click - edit: this might be a "~Path  Intellisense~ MDX" extension issue 🤔
[x] update all necessary markdown files with alias
[ ] update all necessary .astro components with alias - edit: the components in docs/src path example: sidebar-preview.astro use dependencies from packages/starlight/components. There will another path alias for packages/starlight/components which I am doubtful since its a bit out of scope for this PR

thanks for the assist 🔥🔥


StreamSSE not working

What version of Hono are you using?
latest
What runtime/platform is your app running on?
node
What steps can reproduce the bug?
Attach video

What is the expected behavior?
No response
What do you see instead?
No response
Additional information
Hono code:
app.get("/sse", async (c) => {
  return streamSSE(c, async (stream) => {
    const user = c.get("user");

    stream.writeSSE({
      data: "Hello, world!",
    });
  });
});

Frontend code
const eventSource = new EventSource(`http://localhost:3000/sse`, {
              withCredentials: true,
            });

            eventSource.onmessage = (event) => {
              console.log("Received message:", event.data);
              sseData.value.push(event.data);
            };

            eventSource.onerror = (error) => {
              console.error("EventSource failed:", error);
              eventSource.close();
            };

This code works.
app.get("/sse", async (c) => {
  const { readable, writable } = new TransformStream();
  const stream = new SSEStreamingApi(writable, readable);

  c.header("Content-Type", "text/event-stream");
  c.header("Cache-Control", "no-cache");
  c.header("Connection", "keep-alive");

  counter++;
  setInterval(() => {
    stream.writeSSE({
      id: counter.toString(),
      event: "message",
      data: "Hello, world!",
    });
  }, 1000);

  return c.newResponse(stream.responseReadable);
});

@damianpumar
I am checking, but the use of streamSSE appears to be different from the examples you do not use. If I implement it this way, will it work as expected?
const app = new Hono()
let id = 0

app.get('/sse', async (c) => {
  return streamSSE(c, async (stream) => {
    while (true) {
      counter++
      const message = counter.toString()_
      await stream.writeSSE({
        data: message,
        event: 'time-update',
        id: String(id++),
      })
      await stream.sleep(1000)
    }
  })
})

Hi @watany-dev, I tried your code, and does not work, the problem that I saw in streamSSE is not necessary to close the stream, if you try my code should work, because I don't call the close function.
Let me reference the original code, I think is it easier to understand my point.
https://github.com/honojs/hono/pull/2320/files

@damianpumar @yusukebe
This is now closed, right?

Yes, it's closed!

@damianpumar Thanks for this!... Hono started in Japan but has been fixed globally !


adds get_nearest() functionality via new grabbit version

This replaces much of the code in get_metadata() with a cleaner approach that leverages the latest version of grabbit. Also provides a generic get_nearest() method that can be easily used to walk up the hierarchy and get the appropriate file for any given input file. E.g.,
layout = BIDSLayout(path)
event_file = layout.get_nearest('path/to/sub-03_ses-1_run-1_bold.nii.gz', type='event', all_=True)

...would return all matching event files in the hierarchy for the given functional.

Are you bundling dependencies with pybids, @chrisfilo? Or maybe the travis cache needs to be cleared? Not sure why the version conflict is occurring, but locally, it has no trouble finding 0.0.6.

I've cleared the cache on travis and begun reuilding. However, AppVeyor is
failing for other reasons:
https://ci.appveyor.com/project/chrisfilo/pybids-ilb80/build/1.0.70/job/naco7ri3g4inot9r#L156
On Fri, Mar 31, 2017 at 6:57 PM, Tal Yarkoni<EMAIL_ADDRESS>wrote:

Are you bundling dependencies with pybids, @chrisfilo
https://github.com/chrisfilo? Or maybe the travis cache needs to be
cleared? Not sure why the version conflict is occurring, but locally, it
has no trouble finding 0.0.6.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/INCF/pybids/pull/36#issuecomment-290852641, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAOkpwIxVqz18j221YiqIAh-Gz9vyCS2ks5rrYT0gaJpZM4MwGby
.

That's bizarre; tests pass locally and now also on travis (if you ignore the flake8 failure, which will go away as soon as the transformer branch is merged). Any ideas?

It's possible this has to do with the way files are ordered; the grabbit implementation of find_nearest introduces some ambiguity in edge cases about which file should be grabbed. I'm skeptical that this is what's going on, but will take a look (though it's going to be a PITA to debug if I have to push to experiment).

Maybe you made some assumptions about separators that are different on Windows? BTW could you merge master?

That's good news, but also means it will make debugging more difficult, since we don't have easy access (AFAIK) to a Windows 8 machine locally. @chrisfilo, any suggestions for how to move forward?

I take that back, I was actually able to replicate the error in Windows. Will investigate further.

Nothing comes to my mind at the moment. Nonetheless could you merge rebase master?

Removed the flake8 line in this branch too; once it passes I think we're good to merge.

Did the change happen in grabbit? I cannot see where you extract type in get_metadata

The constraint is imposed in the extensions argument rather than type. This turns out to be necessary because the grabbids.json config currently defines the type entity as only occurring within files that also have a sub- component, which means that some valid files can't be found by get_nearest (because they don't have the subject in the filename). We could redefine type to be more flexible if you like, but I think the current approach of using extensions works fine and is just as strict.

So if I ask for metadata of sub-01_task-rest_bold.nii.gz it will not consider  sub-01_task-rest_sbref.json or /task-rest_sbref.json?

Now I'm confused as to what is a type. Should "task-emotionalregulation_bold.json" type be "bold" since it applies to bold files? Or is the reasoning for the current config that that file is not actual bold data, hence not of type "bold"?
Also, answering for @tyarkoni: It will not consider those files since files must end with "_bold.nii.gz".
As an aside, my expectation is for "extension" to mean only stuff to the right of the first period (i.e. actual file extensions).

AFAIK type is the suffix so bold, sbref, dwi etc.

@chrisfilo: that's right. grabbids/grabbit has no way of knowing that sbref should be considered as a valid candidate. What you could do if you want that behavior is add a dictionary that maps the type found in the filename to a valid type definition (e.g., {'bold': 'bold|sbref|...'}). But I'm not clear on why you'd want that anyway; as far as I can tell (but I'm probably misunderstanding it), the spec requires sidecars to have the same filename except the .json extension, no?

No, no - I don't want that behavior. It just wasn't clear to me how just limiting by extension would work (without needing to specify the type). Only _bold.json files should be considered when _bold.nii.gz is being used as an input.
We should be good then.

Oh, I see. I'm just taking advantage of the fact that the extensions argument is basically just checked against a regex that matches against the end of the file. So by passing _bold.json, we're just ensuring that we get what we want. Technically this is a bit of an abuse of the idea of what an extension is, but I think it's fine here because it's called internally, and the user can't override the extension with their own, since it always returns json.
That said, this approach could potentially cause problems in edge cases where, e.g., users don't realize they can call get_metadata to get the data in the sidecar, and instead try to get the json file themselves by calling get_nearest(image_path, extensions='.json', type='bold'). In that case what could conceivably happen is that nothing would match the type because of the current requirement that type can only be defined for files that also define a sub value. So if you're worried about the latter possibility, I'd suggest relaxing the type definition (which is currently "sub-[a-zA-Z0-9_-]+_(.*?)\\."). If it's not possible to do that, then I'll have to think about this some more and come up with some other solution.

The more I think about this, the more I think we need to wrap the grabbit get_nearest in a grabbids version that does some extra checking and introduces some BIDS-specific constraints. Let me think about it some more.

I'm all for relaxing the type definition!

In that case, does just "._(.?)\." work? Periods are illegal anywhere except in extensions right? If so, I think this works, and will probably solve all of the above problems without needing any heavier logic.

Just verified that the tests pass with that approach (and reverting to constraining the type with the type argument rather than extension).

Yes that is correct. You can restrict it even more by turning the second dot into [a-zA-Z0-9].

Done!

Cool. I think conceptually that makes a lot more sense as well. Is it worth restricting extension matching to only text to the right of the first period?

Good thought, and that would make sense for grabbids... but this functionality lives in grabbit, and in grabbit we can't assume periods are invalid outside of the extension. I think a reasonable way to get that behavior would be to create a new entity in grabbids.json called, e.g., 'ent' that matches only to the right of the first period. But at this point that would probably be confusing given that entities will still be a valid argument, so I think we probably just leave it as-is.

Yeah it's fine. To be honest if I didnt know I could use extensions differently I probably wouldn't try so its not really worth holding the users hands in this scenario.

Okay to merge, @chrisfilo, or are there any remaining issues?

Thank you!

Now we get to watch the complaints stream in about production code breaking!


EVP_DigestSignFinal in OpenSSL 3.0 crashes if siglen is a null pointer

EVP_DigestSignFinal in OpenSSL 3.0 crashes if siglen is a null pointer but sigret isn't a null pointer since commit https://github.com/openssl/openssl/commit/a4e01187d3648d9ce99507097400902cf21f9b55.
I'm not sure if it's allowed to do that since because the documentation isn't 100 % clear with this constellation.
Nevertheless it was used in our code before and worked for us as expected.
So I think either the documentation has to be clarified or the behavior should be changed to let it work again.

A NULL siglen doesn't make any sense. If sigret is non-NULL, siglen is an in/out parameter. It is necessary, on input, to specify the output buffer size. That, in turn, is necessary to avoid an out-of-bounds write in your application (security bug).
On output, it tells you the size of the signature. Skipping that is also ill-advised. You may know that a priori for an algorithm like RSA, but ECDSA typically uses a variable-length ASN.1 serialization. You won't know the size of the signature ahead of time.
I think this is also covered by the documentation, which says:

If sig is not NULL then before the call the siglen parameter should contain the length of the sig buffer.

siglen == NULL cannot contain the length of the sig buffer.

Nevertheless it was used in our code before and worked for us as expected.

That was simply a bug - yes, it might not crash but it should return error at least. It should NOT just blindly compute the signature and put it in a buffer of unknown length.

I agree that returning an error is a better solution than crashing.
But assuming the specified buffer length is correct is at least as uncertain as assuming the buffer is large enough when the parameter is NULL.
So I suggest keeping the old behavior or at least letting the provider decide.
For example, with SHA-1, the required buffer length is known before.
If you think that this isn't possible the documentation should be changed because "should contain the length of the sig buffer" means optional and not mandatory.

I mean HMAC-SHA1 and function EVP_DigestSignFinal.
And we already used a pointer to a sig_len variable because the function crashes otherwise.
In the meantime we don't use the function anymore because of the performance problems reported here: #17064.

That's not what is happening. When the parameter is NULL, EVP_DigestSignFinal doesn't perform the operation at all. It merely tells you an upper bound on the output, if you don't know how to size the buffer. In effect, this is two functions jammed into one.

What you are writing here now is the behavior if the sig and not the sig_len parameter is NULL, see the documentation:

Unless sig is NULL EVP_DigestSignFinal() signs the data in ctx and places the signature in sig. Otherwise the maximum necessary size of the output buffer is written to the siglen parameter.

Of course the maximum necessary size of the output buffer of the siglen parameter could only be written if sig_len is not NULL.
And even if sig is not NULL it is not necessary to use a non NULL sig_len parameter:

If sig is not NULL then before the call the siglen parameter should contain the length of the sig buffer. If the call is successful the signature is written to sig and the amount of data written to siglen.
In this case, of course, the amount of data written cannot be returned.

That was how it worked before the change.
All I want now is to fix the new crash and either restore the old behavior or change the documentation.

Closing since this is marked as resolved.


Move telemetry report implementation to the appropriate project

Fixes more layering issues. Telemetry is only available in VS and VS Mac, but we were trying to report it everywhere. Including tests, I think??

Integration tests should find MEF errors, if any.
Validation build: https://dev.azure.com/dnceng/internal/_build/results?buildId=2145619&view=results

Val build passed.
Validation insertion looks good too: https://dev.azure.com/devdiv/DevDiv/_git/VS/pullrequest/461301


cli: support for Flask>=0.11

Signed-off-by: Jiri Kuncar<EMAIL_ADDRESS>

Coverage remained the same at 100.0% when pulling 90fd21125b11f1d3ac87492d068a544b66d6f117 on jirikuncar:cli into 9d93baa521e6c99b06eaf37ff353806f1c623a8d on inveniosoftware:master.

Seems to work locally after the following line in run-tests.sh is changed from:
python setup.py test -a'-vv' && \

to the usual:
python setup.py test && \

(BTW you may want to include tests/test.db in .gitignore as a by-product.)


Add schedule notification method

Based on https://github.com/Azure/azure-notificationhubs-java-backend/blob/master/NotificationHubs/src/com/windowsazure/messaging/NotificationHub.java#L587, Since no api reference found.

[x] add Schedule tests

@ghophp, @hva, please, review.

Looks good, :+1:


ditch semantic-ui

So, Semantic UI's css makes developing anything for our frontend really miserable.
At this point, I'm prepared to personally dis-integrate it from our codebase. Thankfully, semantic-ui-react works fine without their CSS, so it'll just require adding the missing CSS for the things that don't work out of the box.
:blobrage:

Linked with #11


Build a button that allows users to "insert" a new graph in Drive

https://github.com/tessa3/uxgraph/pull/73


what user_query can i use?

If i want to locate a specific target ,such as "a person wearing a yellow hat", what user_query can i use in inference?
python -m groma.eval.run_groma \
    --model-name {path_to_groma_7b_finetune} \
    --image-file {path_to_img} \
    --query {user_query} \
    --quant_type 'none' # support ['none', 'fp16', '8bit', '4bit'] for inference

You can simply use Locate <p> a person wearing a yellow hat </p> in the image. or something else like that. Just remember to enclose the referring expression with <p> and </p>.

But when i tested several images, i found that whether there is an object in the test image, the model will output a localization result. Is there any way to adjust the settings , or is it caused by model hallucination ?

Yes, such hallucination is probably caused by training data - for grounding training, we only got positive QA pairs, i.e., the object mentioned in the question is guaranteed to occur in the image. To remedy such hallucination, you can curate some negative QA pairs and finetune the model.

If I need to fine-tune the model for locating target elements in an image, is there certain hyper parameters to focus on, please?

If I want to provide the object's label and bounding box to Groma to help generate more accurate image descriptions, how should I structure the prompt?


Remove a few unnecessary LMI envs (per Qing's suggestion).

Issue #, if available:
Description of changes:
Remove a few unnecessary LMI envs (per Qing's suggestion).
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Updating env variables


(Frosting) Add better error message for "Task cannot be used"

I'm not sure if this is the error message being referred to but it now seems better than simply "Task cannot be used" and the code was committed after the issue was reported:
https://github.com/cake-build/cake/blob/a1893a2bba26f49e089d66beeb78421cedf6126d/src/Cake.Frosting/Internal/FrostingEngine.cs#L106-L110
Perhaps this is no longer an issue?


Clarify enable and disable rule for a device

In the section https://docs.microsoft.com/en-us/azure/iot-central/core/tutorial-create-telemetry-rules#enable-or-disable-a-rule-for-a-device you mention "the Scopes section". This needs to be clarified better, what is Scopes?.
Also It does not seem to be possible to enable/disable a rule based on device Id?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 7ee141ca-53ea-5e9f-4b50-5e46f7311034
Version Independent ID: 6a8e1cfb-169a-41b1-2e9f-8df5cd889081
Content: Tutorial - Create and manage rules in your Azure IoT Central application
Content Source: articles/iot-central/core/tutorial-create-telemetry-rules.md
Service: iot-central
GitHub Login: @dominicbetts
Microsoft Alias: dobett

@bamajeed Thank you for your query, our team will further look into it and get back to you at the earliest.

Thanks for the feedback @bamajeed ! You are correct, I cannot also see "Scopes" when adding a new filter on my rule:

@dominicbetts could you please validate that this is a doc-bug and we need to remove that from here?

Also It does not seem to be possible to enable/disable a rule based on device Id?

Your device template needs to expose deviceId as a Capability type Property in order to filter it out on your rule. MXChip Template doesn't has that property for eg. Not sure about other device templates... which one are you using?
Thanks

Hi António,
Thanks for the reply. I am using the MXChip Template, but now I understand the issue.
Regards
Basim
From: António Sérgio Azevedo<EMAIL_ADDRESS>Sent: 03 April 2020 15:42
To: MicrosoftDocs/azure-docs<EMAIL_ADDRESS>Cc: Basim Majeed<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [MicrosoftDocs/azure-docs] Clarify enable and disable rule for a device (#51364)
Thanks for the feedback @bamajeedhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fbamajeed&data=02|01|basim.majeed%40microsoft.com|a52fbb1d06ac4e9272a308d7d7dd23e3|72f988bf86f141af91ab2d7cd011db47|1|0|637215217104268109&sdata=qPxkzbQzCUIa1bVapL79jVwA3YKRAGMvbE0rURNMd1U%3D&reserved=0 ! You are correct, I cannot also see "Scopes" when adding a new filter on my rule:
[Image removed by sender. image]https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fuser-images.githubusercontent.com%2F22173500%2F78372026-a9bb0c80-75c0-11ea-9880-9db9b380c42d.png&data=02|01|basim.majeed%40microsoft.com|a52fbb1d06ac4e9272a308d7d7dd23e3|72f988bf86f141af91ab2d7cd011db47|1|0|637215217104278108&sdata=XfwDqzUeRrIzdm3qJtQ7%2FsS8fFb2CJt6d6Ld4jcR6Uk%3D&reserved=0
@dominicbettshttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fdominicbetts&data=02|01|basim.majeed%40microsoft.com|a52fbb1d06ac4e9272a308d7d7dd23e3|72f988bf86f141af91ab2d7cd011db47|1|0|637215217104278108&sdata=dl5bsrkG9FVD2Q2vYgQGRoel0nSGq7r0G4Aza7qwiVU%3D&reserved=0 could you please validate that this is a doc-bug and we need to remove that from here?
Also It does not seem to be possible to enable/disable a rule based on device Id?
Your device template needs to expose deviceId as a Capability type Property in order to filter it out on your rule. MXChip Template doesn't has that property for eg. Not sure about other device templates... which one are you using?
Thanks
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoftDocs%2Fazure-docs%2Fissues%2F51364%23issuecomment-608471481&data=02|01|basim.majeed%40microsoft.com|a52fbb1d06ac4e9272a308d7d7dd23e3|72f988bf86f141af91ab2d7cd011db47|1|0|637215217104288113&sdata=U45NhZb3GncF36aPdOGq3wvNQpPD%2BTGaO0C5bSTvoWs%3D&reserved=0, or unsubscribehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAJJMMO45REFGUJ562NZDIQDRKXYSZANCNFSM4LXTZXAA&data=02|01|basim.majeed%40microsoft.com|a52fbb1d06ac4e9272a308d7d7dd23e3|72f988bf86f141af91ab2d7cd011db47|1|0|637215217104288113&sdata=LJutCVzlsU8FnfUmDRke6Km7e84PabLRllVO6SiUP7Q%3D&reserved=0.

Thanks for confirming @bamajeed . Assigning this issue to the author to fix the doc accordingly.

Hi @bamajeed  - thanks for getting in touch. I've updated this article to clarify the section that talks about enabling and disabling rules for devices - the changes should be live shortly. You're quite correct that you can't use the device ID to enable or disable a rule - you have to use one of the properties defined for the device type. If you think this would be useful feature, consider making a suggestion on User Voice: https://feedback.azure.com/forums/911455-azure-iot-central
I'm going to close this issue now. Thanks.

#please-close