fix: race condition on outgoing stream

This fixes the race condition found on https://github.com/moscajs/aedes/pull/732, it also adds a test to detect potential future regressions.
Kind regards,
Hans

@seriousme Let me know when if you do some changes so I can merge this and create a patch

@seriousme Let me know when if you do some changes so I can merge this and create a patch

Done if @gnought  is ok ;-)

I will be on holiday until Thuesday, will release this when I come back :) @seriousme I sent you an invite to join our org if you want!

I will be on holiday until Thuesday, will release this when I come back :) @seriousme I sent you an invite to join our org if you want!

Thanks for the invite, I will think about it ;-)
Happy holiday !

LGTM

9.0.1 published. Thanks @seriousme 🎉


Deprecated API Usage - Apple will stop accepting submissions of new apps that use UIWebView APIs starting from April 2020

I have just uploaded a build and apple send me the following email:
ITMS-90809: Deprecated API Usage - Apple will stop accepting submissions of new apps that use UIWebView APIs starting from April 2020. See https://developer.apple.com/documentation/uikit/uiwebview for more information.

We covered this deprecation in a blog post. Complete details here.

What about PhoneGap Build?

You can ask on phonegap build forums, but there are plenty of questions already and no official answer. If I were you I would start looking for an alternative.


Migrate to stac-js?

I'm currently writing stac-js: https://github.com/m-mohr/stac-js
The aim is to consolidate code across projects (e.g. stac-layer, STAC Browser, STAC in OpenLayers etc). Whenever that's published we can probably refactor and simplify the code a lot...

Experimenting with this, which hopefully results in a PR soon.

awesome! 🚀


HELP!! Remarkable doesnt boot after installing oxide.

I tried installing the oxide launcher and used the "opkg install oxide" command on my RM2. Everything seemed to work fine. After I rebooted the device, it got stuck at "reMarkable is starting" (scrrenshot). Then I went ssh into the device and tried to start the "systemctl start xochitl" from there and it still showed me those grey lines. Now on each reboot the device doesnt start and gets stuck at "reMarkable is starting"

Device: Remarkable 2
OS:
Version: <IP_ADDRESS>

Additional context
I had installed DDV Hacks. I uninstalled them according to how he mentioned it on the hacks page.

Did you install rm2fb?

I did not in the beginning and now tried to install it and uninstall it
again. I went to factory reset now, but the device is just not restarting:((
Thanks a ton for your quick response!
On Tue, 16 Mar 2021 at 03:20, Nathaniel van Diepen @.***>
wrote:

Did you install rm2fb?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/Eeems/oxide/issues/182#issuecomment-799892234, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/ATH5RZGXKRMA23CGHWXOB6DTD2573ANCNFSM4ZHT2Q3Q
.

Factory reset will not actually reset your device. In fact it has soft bricked peoples devices as it changes the SSH password and doesn't properly remove third party software. Are you still able to SSH into your device?

As for getting Oxide working, you need to make sure that rm2fb is installed and running (systemctl enable --now rm2fb), xochtil needs to be disabled (systemctl disable --now xochitl) and the tarnish service needs to be enabled and running (systemctl enable --now tarnish).

Closing this as invalid for now, but feel free to keep asking questions so we can get you back to a working state. That or reach out on discord.
Something you'll want to be aware of and to read up on: https://github.com/ddvk/remarkable2-recovery

I can SSH into the device. I did the factory reset. Though I can only boot the device through ssh and command "selectctl start xochitl", otherwise the device gets stuck at "remarkable is starting" after booting. How do I delete all the previous hacks?

So what does opkg list-installed give you? You'll want to remove all the oxide and rm2fb packages, as well as re-enable xochitl.

Looks like you just haven't reenabled the xochtil service. Run systemctl enable --now rm2fb to reenable it.

I think @Eeems meant systemctl enable --now xochitl if you want to get back to stock behavior. Also not a bad idea to ensure other packages are disabled at the same time.
Basically, the opposite of his "fix oxide" steps would be the correct approach for going back to stock behavior:
systemctl enable --now xochitl
systemctl disable --now rm2fb
systemctl disable --now tarnish

Same issue here on rM1.
I reinstalled opkg after a xochitl update, ran entware-reenable, installed oxide (somehow it was no longer here) and disabled xochitl and enabled tarnish. Then I rebooted with $ reboot and screen was stuck with is starting.
So I disabled tarnish and reenabled xochitl. I am able to take screenshots (with long hold of the right button) but the left button does not bring the launcher.
Ideas? Maybe there are leftover files that need removing?
Thanks

Same issue here on rM1.
I reinstalled opkg after a xochitl update, ran entware-reenable, installed oxide (somehow it was no longer here) and disabled xochitl and enabled tarnish. Then I rebooted with $ reboot and screen was stuck with is starting.
So I disabled tarnish and reenabled xochitl. I am able to take screenshots (with long hold of the right button) but the left button does not bring the launcher.
Ideas? Maybe there are leftover files that need removing?
Thanks

Check the running processes. You shouldn't have any ability to long press for a screenshot if it's disabled and stopped. I'm guessing you missed the --now flag when you disabled?


KAFKA-10703: Better handling and doc for config defaults of topics

Default configs are not supported for topic resources, so document this
and prevent the creation of such ConfigResources.

@cmccabe grateful if you could take a look at this.
Strictly speaking, making throw ConfigResource is not entirely backwards compatible, but invalid instances could never have been successfully used before. The alternative would be to allow creation of such instances and fail on the relevant calls to the Admin client, which is more complicated for no obvious benefit imho.

@cmccabe grateful if you could take a look at this.
Strictly speaking, making throw ConfigResource is not entirely backwards compatible, but invalid instances could never have been successfully used before. The alternative would be to allow creation of such instances and fail on the relevant calls to the Admin client, which is more complicated for no obvious benefit imho.

@chia7712 maybe you could review this, if @cmccabe is busy?

@chia7712 maybe you could review this, if @cmccabe is busy?

The alternative would be to allow creation of such instances and fail on the relevant calls to the Admin client, which is more complicated for no obvious benefit imho.

I prefer this solution. There is a similar issue (empty topic) in other requests (https://github.com/apache/kafka/blob/trunk/clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java#L1430) and the exception is propagated to Future instead of throwing directly.

The alternative would be to allow creation of such instances and fail on the relevant calls to the Admin client, which is more complicated for no obvious benefit imho.

I prefer this solution. There is a similar issue (empty topic) in other requests (https://github.com/apache/kafka/blob/trunk/clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java#L1430) and the exception is propagated to Future instead of throwing directly.

@chia7712 thanks for taking a look. It's true that I should have fixed this on the broker, so it works for non-Java clients too. It turns out that the three RPCs are remarkably inconsistent in their error codes:

DescribeConfigs code INVALID_TOPIC_EXCEPTION and message Topic name is illegal, it can't be empty which could be more explicit (it could be mistaken as a bug, rather than default topic configs intentionally not being supported)
AlterConfigs code UNKNOWN_TOPIC_OR_PARTITION and message The topic '' does not exist., which again could be more explicit
IncrementalAlterConfigs code INVALID_REQUEST and message Path must not end with / character, which is downright confusing and what the JIRA describes.

To maintain compatibility I've just changed the error messages to be consistent, but left the error codes unchanged. I can open a KIP to bump the RPC versions to make these APIs use consistent error codes too. Other inconsistencies will exist between DescribeConfigs (which does a Topic.validate() then a metadata lookup) and AlterConfigs (the other way around) and IncrementalAlterConfigs (which ultimately follows the AlterConfigs path, but not before the ZK interaction using an unvalidated topic name).

@chia7712 thanks for taking a look. It's true that I should have fixed this on the broker, so it works for non-Java clients too. It turns out that the three RPCs are remarkably inconsistent in their error codes:

DescribeConfigs code INVALID_TOPIC_EXCEPTION and message Topic name is illegal, it can't be empty which could be more explicit (it could be mistaken as a bug, rather than default topic configs intentionally not being supported)
AlterConfigs code UNKNOWN_TOPIC_OR_PARTITION and message The topic '' does not exist., which again could be more explicit
IncrementalAlterConfigs code INVALID_REQUEST and message Path must not end with / character, which is downright confusing and what the JIRA describes.

To maintain compatibility I've just changed the error messages to be consistent, but left the error codes unchanged. I can open a KIP to bump the RPC versions to make these APIs use consistent error codes too. Other inconsistencies will exist between DescribeConfigs (which does a Topic.validate() then a metadata lookup) and AlterConfigs (the other way around) and IncrementalAlterConfigs (which ultimately follows the AlterConfigs path, but not before the ZK interaction using an unvalidated topic name).

Rebased for conflict.
@chia7712 could you review? And what did you think about the value of a KIP to make the error codes consistent?

Rebased for conflict.
@chia7712 could you review? And what did you think about the value of a KIP to make the error codes consistent?

@chia7712 any chance of a 2nd review here?

@chia7712 any chance of a 2nd review here?

@chia7712, @dajac, @ijuma please could someone review this?

Rebased for conflict.
@rondagostino I don't quite understand the plan for how topic configs are going to work with KIP-500. The ConfigHelper seems to provide an abstraction for DescribeConfigs RPC, but it seems that currently AlterConfigs and IncrementalAlterConfigs require ZK. Presumably an abstraction for these is in the works, and that would also need to handle default topic configs in a consistent way to what I'm trying to do here. I need to ensure that the ZKless path also has test coverage.

@tombentley Alter* RPCs will be forwarded to the Raft-based controller and won't be handled in the broker anymore.  The changes occur in the controller and are written to the metadata log, and the brokers get the changes as they read that log.  The brokers apply the changes to their CachedConfigRepository instance, and then DescribeConfigs emits the current config state as recorded there.

Thanks @rondagostino.
@chia7712 @cmccabe would one of you be able to take a look?


sahi yolov8 segmentation

hello all, i need a helo to run the code i dont know which code i should run

helo?

Could you please help me to run sahi with sam ,I don’t know which code i
should to use ,
Thanks in advance
On Fri, 27 Oct 2023 at 1:10 AM, Kadir Nar @.***> wrote:

helo?
—
Reply to this email directly, view it on GitHub
https://github.com/kadirnar/segment-anything-video/issues/95#issuecomment-1782036396,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BBVNZNVUPP255HQS4LIGVMTYBLUV7AVCNFSM6AAAAAA6RLZUZ6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOBSGAZTMMZZGY
.
You are receiving this because you authored the thread.Message ID:
@.***>

helo?

Could you please help me to run sahi with sam ,I don’t know which code i should to use ,
Thanks in advance

Dear kadirnar,
Could you share with with me the code please
On Fri, 27 Oct 2023 at 1:04 PM, Jehan Nima @.***> wrote:

Could you please help me to run sahi with sam ,I don’t know which code i
should to use ,
Thanks in advance
On Fri, 27 Oct 2023 at 1:10 AM, Kadir Nar @.***>
wrote:

helo?
—
Reply to this email directly, view it on GitHub
https://github.com/kadirnar/segment-anything-video/issues/95#issuecomment-1782036396,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BBVNZNVUPP255HQS4LIGVMTYBLUV7AVCNFSM6AAAAAA6RLZUZ6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOBSGAZTMMZZGY
.
You are receiving this because you authored the thread.Message ID:
@.***>


Added divide function and test

Resolves #3

I have found the error in the checks and corrected it. Should be good to go now


[Bug]: screenshot clips element

Bug description
Hi folks!
To reproduce, attempt to screenshot the following element:
/html/body/div[1]/div[1]/article/div/section[7]/dl[3]/dd/span/img
on the page:
https://www.wikiwand.com/en/random_forest
The screenshot turns out like this:

Here is how I am configuring the page with puppeteer:

I notice I can fix the clipping if I expand the page viewport at the beginning of program execution.  However, this changes the way the rest of the screenshots I would like to capture will render.
Is there a way I can avoid this clipping without changing the global viewport settings on the page?  When I try to change the viewport at the site of every screenshot, I get a wide variety of odd artifacts showing up in the end result screenshots.  This might be due to the fact that I have already gathered the elements I would like to screenshot with the previous viewport settings.
Puppeteer version
<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>Node.js version
v18.7.0
npm version
8.18.0
What operating system are you seeing the problem on?
macOS
Relevant log output
No response

Could you provide a sample script?

I have been working on this since my original post -- it is not clear to me that the error is actually in puppeteer.
While I was attempting to create for you an example script, I ended up getting frustrated with javascript debugging and rewrote the whole thing in Rust to A/B test.
The trouble was that the trivial example scripts all seemed to work.  The errors only popped up in my more complex, production code.
So, I wanted to know whether the problem was in my code, in puppeteer, or in some layer underneath.
I was able to eliminate many bugs from my code by using Rust.
Unfortunately, I am still seeing odd screenshotting behavior at the last stage of the pipeline.
In Rust, I am using the (also wonderful) rust library fantoccini.
The fantoccini library code seems sound.
I am concerned that the problem might be with the webdriver layer underneath, or in my usage of it.
This hunch comes from the fact that the screenshotting bugs I am encountering seem very similar between fantoccini and puppeteer.
I am not sure whether the webdriver layer is shared or similar between fantoccini and puppeteer.  It looks like it is just a protocol to talk to chromedriver.
After rewriting in rust, I have verification that the divs I want to screenshot are totally correct in terms of their html content.
The issue seems to come up when I resize the viewport several times during screenshotting several elements in a row.
I am nearly ready to cut my losses and move on to a different strategy of achieving my end goal.  I may just want to save the divs directly as text and process them downstream instead of attempting to capture their content as PNG at this stage.
I have attempted a variety of tactics while screenshotting, in order to attempt to massage correct behavior into place.
Unfortunately, the basic idea of setting the window to the size of the bbox and screenshotting (with or without padding, with or without reinitialization to some large window frist) doesn't seem to work.


Handle empty py_modules gracefully

Parse setup correctly if it doesn't have a py_modules key.
Connects to #77

Thanks, I'm not sure why I didn't catch that either.

+1


Create a DB Table for Wishlist Items

As a System Maintainer
I need relational table for Wishlist Items
So that I can persist relationships between products and Wishlists.
Details and Assumptions

We are not achieving higher normalization forms in our DB schema.  (i.e. we can accept some duplication of values and some level of inconsistency)

Wishlist Items should have the following columns:
wishlist_item_id - PK - number - auto-incrementing
wishlist_id - FK
sku (Perhaps we concatenate product_id, color_code and size_id)
product_id
product_name
color_code
color_name
size_id
size_name
quantity
unique constraint on (wishlist_id, sku) - Therefore if an item is already on a wishlist it cannot be re-added
Acceptance Criteria
Given a valid wishlist_id exists in the wishlists table
When a record is inserted to the wishlist_items
Then a new wishlist_item id is assigned

 Given an insert operation with a null wishlist_id
 When an insert is attempted
 Then a constraint violation will occur.

 Given an insert operation for an item that already exists on a given wishlist
 When an insert is attempted
 Then a unique constraint violation will occur.

 Given an delete operation for a valid wishlist_item_id
 When an delete statement is executed and a query for wishlist_id is performed
 Then the deleted record cannot be found

Let's discuss if we want a dedicated products table and then we would model wishlist collection associations as many-to-many-tables.  For this quick and dirty project it may be okay to have duplicate data.  Though, it would also be interesting to think about a ("better") solution wherein we have a products table that is synchronized using one of the patterns mentioned in lecture.  (Not sure if we'll get to this point in the semester as it would have inter-team dependencies.)

Duplicate of #19


Support multiple input files

It would be handy if multiple input files could work:
shp2json *.shp > merged.json

Try ndjson-cli:
(for s in *.shp; do shp2json -n $s; done) | ndjson-reduce | ndjson-map '{type: "FeatureCollection", features: d}'

Would you accept a PR for this? I think the direct solution is so much cleaner than the workaround using Bash loops. It's also cross-platform :)


Erorr (Requested float16 compute type, but the target device or backend do not support efficient float16 computation.)

Requested float16 compute type, but the target device or backend do not support efficient float16 computation.
Please help me

Hello i change float32 no 8 and work.my project work.
среда, 5 июля 2023 г. пользователь Jarod Mica @.***>
написал:

What GPU are you using? It should choose int8 as the compute type if it
detects you are running a CPU
—
Reply to this email directly, view it on GitHub
https://github.com/JarodMica/audiosplitter_whisper/issues/4#issuecomment-1622436693,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/A4XD454BFPTZ72MI54BJ4A3XOXDYLANCNFSM6AAAAAAZ6ZNVLI
.
You are receiving this because you authored the thread.Message ID:
@.***>

My gpu nvidia gtx 1070.i change float16 on float 32,and my work project.
четверг, 6 июля 2023 г. пользователь Zafkiel @.***>
написал:

Hello i change float32 no 8 and work.my project work.
среда, 5 июля 2023 г. пользователь Jarod Mica @.***>
написал:

What GPU are you using? It should choose int8 as the compute type if it
detects you are running a CPU
—
Reply to this email directly, view it on GitHub
https://github.com/JarodMica/audiosplitter_whisper/issues/4#issuecomment-1622436693,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/A4XD454BFPTZ72MI54BJ4A3XOXDYLANCNFSM6AAAAAAZ6ZNVLI
.
You are receiving this because you authored the thread.Message ID:
@.***>

Issue seems resolved


test: add router/common.case.test.ts

fixes #1953
Tidy up
Suppress errors from yarn lint:fix

2c521b2b771bacbba6b90072b52c7cc0849714fe
57cef10b0dee45a40b75e7fde8a0bd097bd23976

Tweaks vitest.config.ts
Exclude "*.case.test.ts" from vitest
These special files are used to share test cases between different modules or runtime environments.

shared among multiple routers
shared by renderToString and renderToDom

Since these files are test files, they should be excluded from the build, in which case it is convenient to name them "*.test.ts". However, the file itself does not contain the test execution, so it should be excluded from vitest watch. With that motivation, we added "*.case.test.ts" to the exclude of vitest.
src/router/common.case.test.ts
All routers run tests using runTest exported from this file. For routers other than "TireRouter", there are a few test cases that do not pass (this was intended at the time of implementation), so we need to explicitly specify to skip them and instead add router-specific tests.
Author should do the followings, if applicable

[x] Add tests
[x] Run tests

Hi @usualoma !
Awesome work! You did what I have wanted to do for a long time.
I checked and it is probably correct. Merging. I really appreciate you!


Custom path doesn't follow config argument

On master (and at least 1.1) if we start with a specific config file, custom path doesn't follow this change.
su -l git -s /bin/bash -c "/var/opt/gitea/gitea web --config /var/opt/gitea/project/custom/conf/app.ini"
Custom path is /var/opt/gitea/custom should be more logical to get var/opt/gitea/project/custom/
Maybe should be better to set custom path as arg and not only config file

To complete we can workaround with an export GITEA_CUSTOM=/var/opt/gitea/project/custom
Maybe should be better to provide an 'custom_path' argument and follow specification in this directory if we want use a specific app.ini , theme, ...

When you specify a config file on command line, the GITEA_CUSTOM will not be used for config file path.

I don't understand.
Without GITEA_CUSTOM, ( su -l git -s /bin/bash -c "/var/opt/gitea/gitea web --config /var/opt/gitea/project/custom/conf/app.ini"  ) I get :

[T] Custom path: /var/opt/gitea/custom
[T] Log path: /var/opt/gitea/project/log

With su -l git -s /bin/bash -c "export GITEA_CUSTOM=/var/opt/gitea/project/custom/ ;  /var/opt/gitea/gitea web --config /var/opt/gitea/project/custom/conf/app.ini"

[T] Custom path: /var/opt/gitea/project/custom/
[T] Log path: /var/opt/gitea/project/log

To set a specific custom path (to personalize theme for example) to only project looks be required to set GITEA_CUSTOM and config arg.
Should be useful to have a relative path if --config is set or provide/replace a new argument to set --custom_path.


Add an option to insert the assets inline

Example:
$middleware[] = (new Middlewares\Debugbar())->inline();

Related: #5

Done in 41d23f79495e1333c3a7c1d61e19aba1bc062d2d


Copy/Paste to create multiple tags at ones

Feature description
Hello ✌🏽,
I was wondering if its possible to copy/paste a bunch of strings, comma sepatated, and make emblor create multiple tags, instead of just 1.
Do you think this can be made somehow?
Thanks!
Additional Context
Additional details here...
Before submitting

[X] I've made research efforts and searched the documentation
[X] I've searched for existing issues and PRs

@kittenkill
The enhancements discussed in this thread have been addressed in the v1.4.3 release.

@kittenkill
The enhancements discussed in this thread have been addressed in the v1.4.3 release.

Give it a moment. It seems the publish to npm failed

Hi @JaleelB
Awesome feedback!
Not sure if im doing something wrong tho. I had to add this:
autocompleteOptions={[]}

Else, it will fail here With
TypeError: Cannot read properties of undefined (reading 'filter')

After that, however, could not see the new functionality working. Is it enabled by default for , as a separator? Should it be seenable on emblor.jaleelbennett.com?

An error was introduced in v1.4.2 hence why you had to initialize the autocompleteOptions with an empty array. This issue has been addressed in the v1.4.4 release.
In order to use the copy-paste functionality, you have to pass the addOnPaste prop. There is the demo and details for this prop on the Api reference page


Implement multi approval for Claim Subscription

Linked issue
This PR implements the claiming of ACLs in the Backend.
It implements a new multi approvals format that is extensible for all other resources (topics/connectors/schemas and the rest of acls)
It adds a specific kwaclapprovals table to isolate acl approvals from other future approvals.
Resolves: #1064
What kind of change does this PR introduce?

[ ] Bug fix
[x] New feature
[ ] Refactor
[ ] Docs update
[ ] CI update

What is the current behavior?
There is no ACl Claim an=bility
What is the new behavior?
The ability to claim an ACL and approve by two separate approvers.
Other information
UI changes will be added in a separate PR to allow angular and react UI updates to be made at the same time.
Requirements (all must be checked before review)

[x] The pull request title follows our guidelines
[x] Tests for the changes have been added (if relevant)
[x] The latest changes from the main branch have been pulled
[x] pnpm lint has been run successfully

getAclRequests endpoint returns UNKNOWN-TEAM even when team exists
"approvalType": "RESOURCE_TEAM_OWNER",
"requiredApprover": "UNKNOWN-TEAM",
May be my local setup is not correct ?

To provide I see in error log for example "User josepprat has already provided one approval, another approver is required to complete the approval process."
Can this error be sent to FE as well ?

During second approval, I see in error log for example "User josepprat has already provided one approval, another approver is required to complete the approval process." which is good.
Can this error be sent to FE as well ? As I see "Unable to process the request. Please contact our Administrator !!" which is more generic

Yes I will add that in thats a much better practice, good addition.

getAclRequests endpoint returns UNKNOWN-TEAM even when team exists "approvalType": "RESOURCE_TEAM_OWNER", "requiredApprover": "UNKNOWN-TEAM",
May be my local setup is not correct ?

This is interesting no idea why it is pulling UNKNOWN_TEAM, I'll see if I can replicate

If topic owner is the same as first approver, can we skip 2nd approval ?

If topic owner is the same as first approver, can we skip 2nd approval ?

if you set multiple approvers to true!
So there is a setting that will allow you to control that.
klaw.approvals.multiApproval=true

During second approval, I see in error log for example "User josepprat has already provided one approval, another approver is required to complete the approval process." which is good.
Can this error be sent to FE as well ? As I see "Unable to process the request. Please contact our Administrator !!" which is more generic

Yes I will add that in thats a much better practice, good addition.

Actually I looked at this, this code block only gets executed in the same loop as when they give the first approval, if multiapproval is set to true it will go ahead and give all the eligible approvals, if they are only able to give one approval, it will just log that debug statement if logging is set to debug.

UNKNOWN-TEAM

Here it looks like teamIdAndNamePerTenant is out of sync, I'm not sure why, (havent tried to replicate yet am looking at that now)


A/V Desync REC

Hi guys,
I'm experiencing a big (for my use case) problem.
The recordings are quite often in desync with audio/video after a couple of minutes, sometimes it starts in desync.
I tried everything, last test scenario was:
t2.medium EC2
ubuntu 14.04 fresh install
licode cloned from upstream/master
tried 20 different recordings half with chrome (53 latest version) half with canary (55 latest version).
few recordings are perfect, few are in complete desync (up to 4 sec).
I'm using these recordings to broadcast to another media server the stream, but if I can't rely on the quality of those I'm lost.
I haven't found a pattern which broke the mechanism yet.
Tomorrow I'll try to build some old commits, do you have an idea on where to start to debug?
Thanks,
Francesco

Most likely issue is licode doesn't sync streams using RTCP feedback, so it's possible to have drift.  To fix that, someone needs to add code to start correcting timestamps based on information in sender reports

Ok, I had this fear.
I'm trying looking into this.
Up to now I can intercept and read all the rtcp Sr packets and read these values. Do you have any suggestion about how to use these data to made a simple algorithm?

For unrelated reasons i've started work on terminating RTCP completely, so yes. :)  that said, it's not on a branch available and my local branch has deviated hugely from master licode, so.... :(  I need to get with ging/licode people and work something out.

Nice, I’d love to know more about this issue! Would you be available to continue this conversation via email? My contact is<EMAIL_ADDRESS>Have a nice day

Hi,
are there some news about this problem? I'm interested too.
I tried to implement an RTPC processing to address the A/V sync problem, but it isn't completely working yet.
@jnoring any chance to get in touch with you or have a look at your implementation? It would be very useful to me.
@lodoyun any plan to address the problem?
Thanks,
Simone

@simonemazzoni I don't have an implementation of timestamp syncing based on RTCP.  I do have code that correctly parses the necessary information out of RTCP sender reports.  Is that what you're wanting?

@jnoring I have the code to analyze RTCP packets too (it is already committed in licode master if I'm not wrong). I am more interested in how to use them. I found several papers explaining theoretically how to use RTCP packets to address A/V sync problem, but none of them implemented it.
I also had a look at chromium source code, which implements this mechanism, but obviously reverse the mechanism from code is not an easy task.
So, long story short, I am more interested in how to use that data to overcome this problem. How to do the math, to be clear :)

I haven't done it yet so I'm not sure about that, but http://www.ciscopress.com/articles/article.asp?p=705533&seqNum=6 is the best article I've seen thus far?

Yes, I used that very same article as a bible, and I obtained a "pseudo-working" solution, but I'm not sure it is completely correct.
The reason I asked you about that, is because I saw that you implemented the current recording on licode, so I guessed you are confident with that code.

Unfortunately I've never been confident of the current implementation.  I made it a lot better with the changes I made, but without RTCP info, it's definitely lacking.

By saying

I made it a lot better with the changes I made

you mean the changes you have in your branch, or the changes that you made time ago that are in the current master branch?
Anyway, is in your plans to update that code with RTCP info?

The changes I made some time ago that are in the current master branch.  Before it would constantly record completely corrupted video.
Ultimately yes, I'll fix recording with RTCP info, but I have no ETA on that.  Right now I'm working on adding RTCP termination to licode, which I'm nearly done with.

Good!
Can I ask you to drop me a line when its done?
Or you plan to pull request all to ging/licode?
Feel also free to contact me if you want to discuss my current solution.

Doubtful there will be a pull request into licode, because again, my local branch has deviated enough that it's nearly impossible.
Licode doesn't terminate RTCP, which means a publisher receives no feedback unless there's a subscriber present.  That leads to all sorts of strange issues.

Doubtful there will be a pull request into licode, because again, my local branch has deviated enough that it's nearly impossible.
Ok, I understand the problem. It would be nice to have your feedback when you've done with RTCP and A/V sync.

Licode doesn't terminate RTCP, which means a publisher receives no feedback unless there's a subscriber present. That leads to all sorts of strange issues.
Now I understand what you said. This is a problem too. I planned to have a look also at it, but at the moment I have other priorities.

@jnoring can you link to the commit in your local fork that fixes this
issue?
2016-09-28 13:53 GMT-03:00 jnoring<EMAIL_ADDRESS>
Doubtful there will be a pull request into licode, because again, my local
branch has deviated enough that it's nearly impossible.
Licode doesn't terminate RTCP, which means a publisher receives no
feedback unless there's a subscriber present. That leads to all sorts of
strange issues.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/ging/licode/issues/528#issuecomment-250227592, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AACgak7h5uqIo93BqZ86THxlr1u0jaGkks5qupt9gaJpZM4J-ATo
.

--
Alvaro

@lodoyun
https://github.com/ging/licode/pull/532
So, I made a first implementation of what can be our rtcp a/v sync but I need help to find bugs, as I wrote in the description. I'm new to C.
It would be very nice to see @jnoring implementation of rtcp termination. Do you have any public fork or can you just give us some parts of code?
Thank you guys!

@kekkokk See my comments in the PR #532 . Thanks for the work you put into it!
@jnoring We should work something out, RTP/RTCP termination is in our roadmap but still haven't got around to do it. Any suggestion on how to proceed?

@lodoyun I'll look into getting you access to our git repo and/or sharing the code directly with you.  I wish my local branch had not deviated so hugely, but....c'est la vie.


Podling scan reports errors

The podling scan at https://incubator.apache.org/clutch/pekko.html currently reports a long list of errors. This seems to be because the project site at http://pekko.apache.org/ is currently missing.

Creating the site is already covered by #99
This issue covers following the guidance at https://infra.apache.org/project-site.html to ensure the necessary data is provided on the landing page (i.e., currently, docs/src/main/paradox/index.md

the web site will be https://pekko.apache.org/ and this is allowed - if you check the podling scan output.

Thanks, corrected in description.

The Apache Pekko landing page https://github.com/apache/incubator-pekko/blob/main/docs/src/main/paradox/index.md is currently just a TOC page (rendered: https://pekko.staged.apache.org/).
There are two ways we could ensure the project landing page meets the Apache project site requirements:

We could add content to the existing TOC page, so it has the intro material and then the TOC below that.
We could replace the existing TOC page with the intro material, move the TOC to a new page, and add a link from the landing page.

Does anyone have a preference?

We are likely to clone sbt-paradox - we have an empty repo earmarked and an issue open. My preference would be to have a collapsible tab on all pages with all the required links.

Update on the status of this issue:
The podling scan at https://incubator.apache.org/clutch/pekko.html is still failing with errors stating that the Text and URIs to the ASF websites are not present. See https://whimsy.apache.org/pods/project/pekko .
From looking at the pekko docs homepage (https://pekko.apache.org/docs/pekko/current/), at least some of these are present, however the errors are still raised.
Root cause:
To me it looks like the issue may be related to the fact that our homepage URI is not actually https://pekko.apache.org (per expecatation from the crawler code) but is https://pekko.apache.org/docs/pekko/current/ (since we're matching the behaviour performed by the non-apache sbt-paradox homepage which also has a redirect to /docs/paradox/current).
The redirect from https://pekko.apache.org -> https://pekko.apache.org/docs/pekko/current/ might be causing an issue
Potentially it is attempting to crawl over the webpage https://pekko.apache.org/ , however the actual homepage is at https://pekko.apache.org/docs/pekko/current/ (which is what the initial link redirecting to)

Thanks for your interest. We are working closely with the Incubator PMC. We are aware of the issues. We will not do a release until we meet the requirements of the PMC. This release is many months away.

Thanks for the quick response. Can we add this task into the 1.0.0 milestone so that it is tracked there?


Drawer flashes content on Safari Mac

When expanding drawers on Mac Safari the content flashes to a fully expanded state before animating open.  Particularly noticeable if the background color of the drawer is different, but still quite noticeable even on the drawer sample.

Closing out - issue quite old and not a priority to retest and assess current behavior.


Task Queue can lock itself

for example https://ci.woodpecker-ci.org/repos/3780/pipeline/12015/28
shows that the queue impl. has the potential to lock itselve.
as in production you do not normaly have short task insert times, this is is hardly discovered in the wild.
and a server restart do fix it ... so i can see why we did not got an bug report.
but we should still find the cause to:

not need to restart our test pipelines to make random error disapear
fix potential bigger issues that coudl be the cause of this
dont have no-explainable hickups in deployed instances

for me this looks like some kind of race condition ... e.g. some lock&unlock is probably somewhere missing
workaround: restart server

not observed anymore - might have got catched at the reasent refactors


Update document structure.

Work in progress to break up the document structure into something more manageable.
I've split things up into

Population genetics model
Machine data model
Human data model

Hopefully this structure is good enough for us to start filling in some gaps in their final form - we can review the terminology and overall structure later, but let's try and get some content in.
Related: #86

Looks good to me. The failing docs build is due to an issue with demesdraw and the latest numpy, which is fixed in demesdraw 0.1.3.

OK, thanks @grahamgower. I think I'll merge this much - there's still a bunch of things that aren't clear, but hopefully it's a step in the right direction. At least we can fill out the popgen model.


no line number given when EOF is reached with unbalanced parens

In this example
main = (

The following error message is produced:
-- SYNTAX PROBLEM -------------------------------------------------------------

I ran into something unexpected when parsing your code!

I am looking for one of the following things:

    whitespace

A more helpful message would point to the opening ( on line 1, or at least state that it reached the end of file while looking for whitespace.

I got this error (no line number, same message) without the parens - just forgetting to finish an infix expression.
module Bitty (..) where
f a b = a +

Tracking in meta issue #177

Been improving parser. The new message for this case is:

@jessitron's is different, and would be a good issue of its own. It is also improved by the new parser though:

Really happy to see error messages keep getting better.  This one was bothersome when I ran into it occasionally in larger files, and now it just won't be.  \o/


Mapping SAML attributes

Hi,
we use a custom Identity Provider and have successfully integrated it into Cloud Foundry following your Spring example. Everything is working so far, except for mapping custom SAML attributes.
Additional used resources:

General: https://developers.sap.com/tutorials/s4sdk-secure-cloudfoundry.html
Attributes: https://help.sap.com/viewer/65de2977205c403bbc107264b8eccf4b/Cloud/en-US/4827f0bbe27d459fad8342896d4e569b.html

Actually we have configured xs-security.json and stuff and the IDP as well. Analysing the SAML assertions we can see our custom SAML attributes. But we don't get them from the token. The only things that work are these magic variables:

first_name
last_name
I call them "magic" because we don't even need to specify them in the security descriptor: They work out-of-the-box. Unfortunately nothing else.

Any help here would be greatly appreciated!

Hi @texttechne,
seems to be a similar issue to this one #146
In case the SAML attribute does not appear in the token, you will not be able to access it.
I would suggest to open a BCP (component BC-CP-CF-SEC-IAM) / or Jira Ticket for the same as this is not the right place to discuss the same.


error installing carrot gem

When I try to install carrot I'm getting the following error:
gem install carrot
ERROR:  While executing gem ... (ArgumentError)
undefined class/module YAML::PrivateType
It's only happening with carrot, I can install other gems.  Any ideas?

Looks like I got hit with this issue:
http://help.rubygems.org/discussions/problems/483-gems-built-with-rubygems-150-ruby-192-do-not-install-properly-with-150-187
I repackaged with a newer version of rubygems.
On Thu, Oct 6, 2011 at 11:41 AM, timon
<EMAIL_ADDRESS>wrote:

@famoseagle can you please rebuild gem and push it to rubygems? Repackaging gem from sources worked for me
--
Reply to this email directly or view it on GitHub:
https://github.com/famoseagle/carrot/issues/6#issuecomment-2308838

Can I close this?

Yes, works for me

Yes,  I'm able to install.
On Oct 20, 2011 12:49 PM, "Amos Elliston" <
<EMAIL_ADDRESS>wrote:

Can I close this?
--
Reply to this email directly or view it on GitHub:
https://github.com/famoseagle/carrot/issues/6#issuecomment-2472669


Add set_metadata function for streamMut

Add function for setting metadata for stream. I'm using it like this:
stream_audio.set_metadata(stream.metadata().to_owned());

This is needed to have devices show, which language stream you are listening to.

Makes sense, thanks!


Add endpoint /features/create-region

This adds the endpoint /features/create-region to add a new row to the database. Mandatory parameters in the POST request are name, namelsad and stusps.

You should return a success code at the end of the code block

@ankithkanderi24 added it. everything else fine?

Everything else looks great!


Restore Level, Array has changed during ranged-for iteration!

Hello
I had sometimes problem with RestoreLevel function and particulary with:
// Restore existing actor state
for (auto Actor : Level->Actors)    458 line SpudState.cpp
keep getting [2023.02.06-09.57.53:422][450]LogOutputDevice: Error: Array has changed during ranged-for iteration! crash
I managed to fixed it with coping an array:
TArray<AActor*> LevelActors = Level->Actors;
// Restore existing actor state
for (auto Actor : LevelActors)
Wondering, Is this even a good aproach. Error occurs when I spawn runtime actors, In my case pawns with new interface GetSpudRespawnMode AlwaysRespawn.
Regards

SPUD doesn't spawn any actors during that loop, it always spawns them just before precisely to avoid that sort of problem. So I guess it must be that you're spawning actors yourself during one of the pre/post restore hooks?
Copying the array beforehand would fix it but there can be a lot of actors in a level so it's best not to. Instead of spawning your own actors you could mark those as SPUD objects and SPUD will restore the links between them on restore.


RelatedContentField needs to be ignored by south.

merged in (though not through the github interface) Thanks for the PR


Adding a guard to error if a sysoid is present in two profiles

I think this is what we want to do? I'm not actually sure. Right now making <IP_ADDRESS>.<IP_ADDRESS>.1348 go into the cisco-call manager profiles.

LGTM 👍


Write Wiki docs explaining how to do testing

re-frame v0.2.0 allows each of the parts to be nicely tested (all without any async problems).  Or, at least that's the cunning plan.
Explain how to do each part:

db
handlers
subscriptions
components

Not testing, but debugging:
https://github.com/Day8/re-frame/wiki/Debugging-Event-Handlers

Looking forward to wiki on testing! The re-frame documentation has been simply awesome so far, thanks for all the hard work.

:+1:

See the new Wiki page:  https://github.com/Day8/re-frame/wiki/Testing


aFreeRDP keyboard not sending punctuation to the server

aFreeRDP will not send the following keys (perhaps others too) to the server it is connected to:
 . , ! ? ' " - _ / @ # $ % & * + = ( ) < > = : ;

Keyboards tested: stock Android keyboard English (US), and Hacker's Keyboard.

I think this affects more than just Android version. Also, someone duped this issue in #1568.

I this still an issue with current master?

I do not have a build environment but if someone were to build it for iOS or Android, I could certainly test. The one in iOS App Store is from 2013 and the one in the Play Store is from 2014.

I have the same issue as Gatesphere (although it does transmit the @#$%&*! characters). I have tried TruRdp and have the same issue, but from Windows 10 using stock Remote Desktop Connection all characters work. For the RDP host I am using Ubuntu 16.04 (Mate) with xrdp for the server. Any help much appreciated.

@lewkowski Currently the android client sends keyboard events as unicode symbols. To my knowledge XRDP and others do not support that kind of input. I can't tell for TruRdp.

Last AfreeRDP tested on multi android devices. Keyboard unusable because punctuation and keymaps other than US layout on a debian server not correctly detected.

@hymer-up Using XRDP? Then that one is at fault. Android has no (reliable) way to use scancodes as input, only unicode. that is not supported in that case.


Mayavi crashes spyder in the internal console

From<EMAIL_ADDRESS>on 2010-05-05T18:51:52Z
The following script crashes spyder when run in the internal console, but
runs fine in the external console or in a plain python interpreter session.
I am using spyder1.1.0beta5 (crash also occurs on beta3) and Python(x,y)
<IP_ADDRESS>
# -- coding: utf-8 --
import numpy as np
x = np.linspace(0, 1, 20)
y = np.linspace(0, 5, 20)
z = np.linspace(0, 1, 20)
from enthought.mayavi import mlab
mlab.points3d(x, y, z)
mlab.axes()
mlab.show()
Original issue: http://code.google.com/p/spyderlib/issues/detail?id=214

From pierre.raybaut on 2010-05-31T03:15:29Z
Have you tried with the latest version of Spyder/ETS?
With Spyder v1.1.0 beta7, Python 2.6.2, PyQt 4.5.4 and ETS 3.4.0 (MayaVi 3.3.1), it
works in both interactive and external consoles.

From<EMAIL_ADDRESS>on 2010-05-31T17:22:54Z
That is my exact configuration, except that I am using python 2.6.5 instead of 2.6.2.
I just uninstalled then reinstalled the ETS plugin which came with python(x,y)
<IP_ADDRESS>, but the problem is still there.  It is also there with spyder 1.0.3 (which
python(x,y) insists on installing over my more recent .exe version).
According to the crash message, the crash is occurring in _speedups.pyd, which is
part of some Cython code in Traits.  I guess this could be some problem with the fact
that I have uninstalled and reinstalled various versions of Python(x,y) on this
computer.  But then why this would work in the internal console and not the external
console?
I'd be curious to know if many other spyder users are actually using mayavi.  If
everyone else is using it and not having problems, then maybe it's just something to
do with my setup and not a more general problem with python(x,y) or spyder.  Or maybe
most people are just sticking with matplotlib (which I just noticed has recently
added a lightweight 3D plotting option).

From<EMAIL_ADDRESS>on 2010-09-11T09:22:03Z
PS: in my case, this simple line
"from enthought.mayavi import mlab"
crashes Spyder, if entered from the interactive console.

From pierre.raybaut on 2010-09-12T01:49:31Z
Fixed: https://code.google.com/p/spyderlib/source/detail?r=918419ebd3b8dc25dc79449a2ca5279ef6e17eac&repo=v11
Status: Fixed

From<EMAIL_ADDRESS>on 2010-09-11T09:12:27Z
Exactly same problem here. Crashes began to occur with the latest version of python(x,y) (<IP_ADDRESS>) and Spyder (1.1.5) and ETS (3.4.1).
I had no problem with Python(x,y) <IP_ADDRESS> and corresponding Spyder (1.0.3 I think) and ETS (3.4.0).
Help welcome!

From<EMAIL_ADDRESS>on 2010-09-12T09:07:12Z
Works like a charm. Thanks!!


Fix submenu-active class for submenu block

Filter: Grayscale(0); when sublink is active

After couple of changes it should be background-color of active class now.


Issue #9825 -- handle vendor reserved data properly

Problem
Vendor reserved data was not being handle properly in  PR #9617
Change overview

Add helper method to count VendorReserved elements in a DA blob
Uses two classes for VendorReserved data -- one for construction of DA, one for deconstruction
Does not attempt to confirm the data is correctly sorted in deconstruction.
Added test routines to confirm sorting order.

Testing
Matter unit tests

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.1 out of 2 committers have signed the CLA.:white_check_mark: mleisner:x: Marty LeisnerMarty Leisner seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


Add k8s-server to Spring Initializr

As a developer, I'd like to add k8s-server app-starter to Spring Initializr.

We don't have the k8s server versions in a BOM anywhere AFAIK, so not sure this is possible right now.

This depends on the following issues:
https://github.com/spring-cloud/spring-cloud-dataflow-server-kubernetes/issues/135
https://github.com/spring-cloud/spring-cloud-dataflow-server-kubernetes/issues/136
https://github.com/spring-cloud/spring-cloud-dataflow-server-kubernetes/issues/125

This is no longer planned, closing for now.


Regression in 2.0.3 preview: NullReferenceException in RelationalDataReader.Dispose() on Migrate()

The following simple case, which worked in 2.0.0, throws a NullReferenceException in the new preview:
var context = services.GetRequiredService<VolunteerDbContext>();
context.Database.Migrate();

Note that it happen with any of my DbContexts, not just the one shown above.
The exception is as follows:
Object reference not set to an instance of an object.
   at Microsoft.EntityFrameworkCore.Storage.RelationalDataReader.Dispose()
   at Microsoft.EntityFrameworkCore.Migrations.HistoryRepository.GetAppliedMigrations()
   at Microsoft.EntityFrameworkCore.Migrations.Internal.Migrator.Migrate(String targetMigration)
   at Microsoft.EntityFrameworkCore.RelationalDatabaseFacadeExtensions.Migrate(DatabaseFacade databaseFacade)
   at TestAspNetCore.Program.Main(String[] args)

Additionally, when executing a CountAsync and a ToListAsync the following exceptions are thrown, respectively:
Microsoft.EntityFrameworkCore.Query: Error: An exception occurred in the database while iterating the results of a query for context type 'TestAspNetCore.Model.VolunteerDbContext'.
System.NullReferenceException: Object reference not set to an instance of an object.
   at Microsoft.EntityFrameworkCore.Storage.RelationalDataReader.Dispose()
   at Microsoft.EntityFrameworkCore.Query.Internal.AsyncQueryingEnumerable`1.AsyncEnumerator.Dispose()
   at Microsoft.EntityFrameworkCore.Query.AsyncQueryMethodProvider.<GetResult>d__16`1.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.EntityFrameworkCore.Query.Internal.AsyncLinqOperatorProvider.TaskResultAsyncEnumerable`1.Enumerator.<MoveNext>d__3.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.EntityFrameworkCore.Query.Internal.AsyncLinqOperatorProvider.ExceptionInterceptor`1.EnumeratorExceptionInterceptor.<MoveNext>d__5.MoveNext()

Microsoft.EntityFrameworkCore.Query: Error: An exception occurred in the database while iterating the results of a query for context type 'TestAspNetCore.Model.VolunteerDbContext'.
System.ObjectDisposedException: Cannot access a disposed object.
Object name: 'WrappedMySqlDataReader'.
   at Microsoft.EntityFrameworkCore.Storage.Internal.WrappedMySqlDataReader.GetReader()
   at Microsoft.EntityFrameworkCore.Storage.Internal.WrappedMySqlDataReader.get_RecordsAffected()
   at Microsoft.EntityFrameworkCore.Storage.RelationalDataReader.Dispose()
   at Microsoft.EntityFrameworkCore.Query.Internal.AsyncQueryingEnumerable`1.AsyncEnumerator.Dispose()
   at System.Linq.AsyncEnumerable.SelectEnumerableAsyncIterator`2.Dispose()
   at System.Linq.AsyncEnumerable.AsyncIterator`1.<MoveNext>d__10.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.EntityFrameworkCore.Query.Internal.AsyncLinqOperatorProvider.ExceptionInterceptor`1.EnumeratorExceptionInterceptor.<MoveNext>d__5.MoveNext()

Further technical details
EF Core version: 2.0.1-rtm-203
Database Provider: Pomelo.EntityFrameworkCore.MySql (version 2.0.0 as well as 2.0.1-preview-10072)
Operating system: Windows 7 x64
IDE: Visual Studio 2017 15.4.1

@OronDF343 Can you post a project or code listing so we can try to reproduce this?

@smitpatel Please investigate this per my email.

Filed https://github.com/PomeloFoundation/Pomelo.EntityFrameworkCore.MySql/issues/418 on MySQL.

Hi @OronDF343, we are fixing this issue, but not finished. For now, you can use .AddDbContext instead of .AddDbContextPool will work.

Thanks, but unfortunately that workaround did not solve the issue (only one of the DbContext was using .AddDbContextPool and changing that produced the same exceptions). I guess I will downgrade to EF Core 2.0.0 for now (and use non-Async methods for now since 2.0.0 has a bug)

@OronDF343 A fix for this issue is being included in the 2.0.1 (2.0.3 meta package) patch.


[bug] Unable to connect to dask Gateway

Describe the bug
A clear and concise description of what the problem is.
After a fresh deployment of QHub, we are having trouble spinning up a dask-cluster. The following attempt to spin up a dask-cluster results in an error:
from dask_gateway import Gateway
gateway = Gateway()
cluster = gateway.new_cluster()
client = cluster.get_client()

Error message:
Error
---------------------------------------------------------------------------
error                                     Traceback (most recent call last)
/home/conda/store/3b3dab54b998d542178519250aa292c509490eceafc7744067950e5f365c6345-datum/lib/python3.8/site-packages/distributed/comm/core.py in connect(addr, timeout, deserialize, handshake_overrides, **connection_args)
    319         # write, handshake = await asyncio.gather(comm.write(local_info), comm.read())
--> 320         handshake = await asyncio.wait_for(comm.read(), time_left())
    321         await asyncio.wait_for(comm.write(local_info), time_left())

/home/conda/store/3b3dab54b998d542178519250aa292c509490eceafc7744067950e5f365c6345-datum/lib/python3.8/asyncio/tasks.py in wait_for(fut, timeout, loop)
    493         if fut.done():
--> 494             return fut.result()
    495         else:

/home/conda/store/3b3dab54b998d542178519250aa292c509490eceafc7744067950e5f365c6345-datum/lib/python3.8/site-packages/distributed/comm/tcp.py in read(self, deserializers)
    215             try:
--> 216                 frames = unpack_frames(frames)
    217

/home/conda/store/3b3dab54b998d542178519250aa292c509490eceafc7744067950e5f365c6345-datum/lib/python3.8/site-packages/distributed/protocol/utils.py in unpack_frames(b)
     69
---> 70     (n_frames,) = struct.unpack_from(fmt, b)
     71     lengths = struct.unpack_from(f"{n_frames}{fmt}", b, fmt_size)

error: unpack_from requires a buffer of at least 8 bytes for unpacking 8 bytes at offset 0 (actual buffer size is 2)

The above exception was the direct cause of the following exception:

OSError                                   Traceback (most recent call last)
<ipython-input-4-856b595a453b> in <module>
      3 gateway = Gateway()
      4 cluster = gateway.new_cluster()
----> 5 client = Client(cluster)

/home/conda/store/3b3dab54b998d542178519250aa292c509490eceafc7744067950e5f365c6345-datum/lib/python3.8/site-packages/distributed/client.py in __init__(self, address, loop, timeout, set_as_default, scheduler_file, security, asynchronous, name, heartbeat_interval, serializers, deserializers, extensions, direct_to_workers, connection_limit, **kwargs)
    750             ext(self)
    751
--> 752         self.start(timeout=timeout)
    753         Client._instances.add(self)
    754

/home/conda/store/3b3dab54b998d542178519250aa292c509490eceafc7744067950e5f365c6345-datum/lib/python3.8/site-packages/distributed/client.py in start(self, **kwargs)
    966             self._started = asyncio.ensure_future(self._start(**kwargs))
    967         else:
--> 968             sync(self.loop, self._start, **kwargs)
    969
    970     def __await__(self):

/home/conda/store/3b3dab54b998d542178519250aa292c509490eceafc7744067950e5f365c6345-datum/lib/python3.8/site-packages/distributed/utils.py in sync(loop, func, callback_timeout, *args, **kwargs)
    352     if error[0]:
    353         typ, exc, tb = error[0]
--> 354         raise exc.with_traceback(tb)
    355     else:
    356         return result[0]

/home/conda/store/3b3dab54b998d542178519250aa292c509490eceafc7744067950e5f365c6345-datum/lib/python3.8/site-packages/distributed/utils.py in f()
    335             if callback_timeout is not None:
    336                 future = asyncio.wait_for(future, callback_timeout)
--> 337             result[0] = yield future
    338         except Exception as exc:
    339             error[0] = sys.exc_info()

/home/conda/store/3b3dab54b998d542178519250aa292c509490eceafc7744067950e5f365c6345-datum/lib/python3.8/site-packages/tornado/gen.py in run(self)
    760
    761                     try:
--> 762                         value = future.result()
    763                     except Exception:
    764                         exc_info = sys.exc_info()

/home/conda/store/3b3dab54b998d542178519250aa292c509490eceafc7744067950e5f365c6345-datum/lib/python3.8/site-packages/distributed/client.py in _start(self, timeout, **kwargs)
   1056
   1057         try:
-> 1058             await self._ensure_connected(timeout=timeout)
   1059         except (OSError, ImportError):
   1060             await self._close()

/home/conda/store/3b3dab54b998d542178519250aa292c509490eceafc7744067950e5f365c6345-datum/lib/python3.8/site-packages/distributed/client.py in _ensure_connected(self, timeout)
   1113
   1114         try:
-> 1115             comm = await connect(
   1116                 self.scheduler.address, timeout=timeout, **self.connection_args
   1117             )

/home/conda/store/3b3dab54b998d542178519250aa292c509490eceafc7744067950e5f365c6345-datum/lib/python3.8/site-packages/distributed/comm/core.py in connect(addr, timeout, deserialize, handshake_overrides, **connection_args)
    323         with suppress(Exception):
    324             await comm.close()
--> 325         raise IOError(
    326             f"Timed out during handshake while connecting to {addr} after {timeout} s"
    327         ) from exc

OSError: Timed out during handshake while connecting to gateway://datumdeleteme.qhub.dev:8786/dev.a708ced639bd405592468d5dabe252b4 after 10 s

How can we help?
Help us help you.

What are you trying to achieve?

Trying to spin up a dask cluster on QHub.

How can we reproduce the problem?

See code snippet above and QHub version below.

What is the expected behaviour?

Expect a dask cluster to spin up without any errors.

And what is currently happening?
Any error messages?

If helpful, please add any screenshots and relevant links to the description.
See above.

Include your conda version (use conda --version), k8s and any other relevant details.

qhub was installed from GitHub main branch (commit id undocumented) at around 12-12:30 PM CST on 2021-06-10. See increase-cidr branch.
qhub --version
0.3.11

mismatched versions of dask/dask-gateway/distributed can often cause this. Especially, if they are reusing environments from an older qhub. The older envs may have pinned dask-gateway to an older version

I feel a little silly now... This was indeed the issue, I was confident we had checked for this, I guess not. Thanks @dharhas!

@dharhas, Thanks, you rock!  This really saved us!
I too feel pretty silly for not having caught this.


Removed NotImplementedError and small doc fixes

After simulation had finished, a NotImplementedError was raised in the 'stop()', but this is to my understanding not needed anymore.
In addition, some minor doc fixes were done.

Closed in favor of commit https://github.com/multiscale-cosim/EBRAINS_InterscaleHUB/commit/7426487df7b28784197c3f5bb6b739c13ab5490f


materialize: 0.15.0 -> 0.17.0

Motivation for this change
Regular package update
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

Latest version is 0.19.0 but both 0.18.0 and 0.19.0  require rust 1.58 that's not on master yet

Thank you


Problems with deletion of user.lock

The Scrivener application uses a user.lock file to indicate that a project is locked for editing. SyncTrayzor seems to detect this file getting created, but not usually (ever?) when it is deleted. As a result, the file doesn't get reliably deleted between computers, and I often must do a manual re-scan when swapping between computers.
I don't know what is special about this file. It's formatted like an .INI file, it is at least read-shareable (I can load it into Notepad++), and I don't see any special attributes set on it (at least not through Explorer).

Do things work as expected if you create and delete that file manually, rather than letting Scrivener create and delete it?
If not, cna you post an extract of your log file which shows user.lock being deleted? You'll find it in SyncTrayzor -> File -> Settings -> Logging + STTRACE -> Show SyncTrayzor Log File.

Creating and deleting a 0-byte file with that name works fine. Copying the user.lock file aside and then copying it in and deleting it also works fine. It's only through Scrivener that there's a problem.
The following is what I see in my log right after I close Scrivener. The path of the lock file is Book3.scriv\files\user.lock. As you can see it there is no event occurring for that location. It may be that the "Path Changed" which identifies the parent path (Book3.scriv and not its files subfolder) is not noticing the file underneath.


Add custom modal code & guild feature modifier

A couple of Guild features are VERIFIED and PARTNERED. To view an incomplete list, you can go here: https://gist.github.com/Techy/ecc60b12e94f8fc8185f09b82aa91dd2

How does guild feature modifier work? Most of the features don't work with this (animated icon, vanity, etc). What's the use of it?
Also, is it just client-sided?

How does guild feature modifier work? Most of the features don't work with this (animated icon, vanity, etc). What's the use of it?
Also, is it just client-sided?

This is just client-sided. But it can allow users to change things and/or experiment with certain features.
Guild verification/partnership is one example, but Discord locks most features behind their API so that's the only limitation. This is just a fun feature to mess around with.


Add support for Scala 3.4.3 & 3.5.0

[ ] Scala 3.4.3 https://github.com/scala/scala3/issues/21385
[ ] Scala 3.5.0 https://github.com/scala/scala3/issues/21368

@Gedochao
When I try ammonite under scala 3.5.0, I got the error,

Welcome to the Ammonite Repl 3.0.0-M2-15-9bed9700 (Scala 3.4.2 Java 22.0.1-internal)
@  error while loading scala,
TASTy file scala/NamedTupleDecomposition.tasty could not be read, failing with:
Forward incompatible TASTy file has version 28.5, produced by Scala 3.5.0-bin-nonbootstrapped,
expected stable TASTy from 28.0 to 28.4.
To read this TASTy file, use a Scala 3.5.0 compiler or newer.
Please refer to the documentation for information on TASTy versioning:
https://docs.scala-lang.org/scala3/reference/language-versions/binary-compatibility.html

Is this related with the issue you list here?
Thanks!
Songpeng


Update to allow access_key for version 2

Description
Fixes issue #2
Type of PR
I

[ X] Feature implementation

Testing
Create a free account at picovoice.ai
Follow documentation for creating an access_key
Add your access_key to the configuration file
CLA
I believe that I signed one of these a couple of years ago, but will again if necessary.

Thank you very much for doing the research and updating the plugin. Will update the setup.py and do a new release


[AIRFLOW-812] Fix scheduler run bug when dag file is absent

Dear Airflow Maintainers,
Please accept this PR that addresses the following issues:

https://issues.apache.org/jira/browse/AIRFLOW-812

When scheduler run_numbers and run_duration are set to -1 (unlimited),
we expect the scheduler to run continuously. However, when dag folder is
empty, the scheduler terminates immediately. This is due to a bug in
utils/dag_processing when checking max_runs_reached. Instead the
existence of dag file should be checked first. If no dag file is
present, false will be returned.
Testing Done:
Travis runs on my fork went fine.

Good catch. Can you fix your commit message per guidelines, then I'll merge.

Current coverage is 66.86% (diff: 50.00%)

Merging #2027 into master will increase coverage by 0.10%

@@             master      #2027   diff @@
==========================================
  Files           138        138
  Lines         10526      10528     +2
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
+ Hits           7028       7040    +12
+ Misses         3498       3488    -10
  Partials          0          0

Powered by Codecov. Last update dc97bcd...72879ce

@bolkedebruin, commit message revised, PTAL.

@fenglu-g revised the message myself, please have a look for future reference.


[BUG] deviceshare plugin not handle AddPod\RemovePod correctly

What happened:
in generally, when we execute AddPod logic here, the pod may be in scheduling status,it won't exist in nodeDeviceCache's used map, so there is a bug that  when the framework execute RunFilterPluginsWithNominatedPods with AddPod for high priority pods, the plugin can't reserve resource for hese high priority pods, In RDMA\VF\nv-switch scenario, it can cause high priority pods assign fail due to some resources is assigned by low priority pods. So we reused the "Reserve" logic to generate an assign placement and save it in nominator. We will clear the nominator cache In "Reserve" and "UnReserve", which means we will do clean job no matter assign success or not, this is the same process of the origin k8s framework nominate process.
What you expected to happen:
How to reproduce it (as minimally and precisely as possible):
Anything else we need to know?:
Environment:

App version:
Kubernetes version (use kubectl version):
Install details (e.g. helm install args):
Node environment (for koordlet/runtime-proxy issue):

Containerd/Docker version:
OS version:
Kernal version:
Cgroup driver: cgroupfs/systemd

Others:

/milestone someday


behavior when blocking processes are found

Hi all, currently I am facing an issue when I`m trying to use the Installomator.sh with Jamf PRO. Long story short I want to install/update applications using this value - BLOCKING_PROCESS_ACTION=prompt_user_then_kill but when  I execute the policy all works except the notifications which prompt the user to choose "Quit and Update" or "Not Now". For some reason, some apps are non-blocking for their update (Chrome, Mattermost) and there is no pop-up for the user stating that it has to be closed for an update. Please for your help (ideas/plans) to handle 'correctly'  the blocking process of apps such as Google/Mattermost.

mattermost issue resolved in https://github.com/Installomator/Installomator/pull/991

are you using the googlechromepkg label? This should take care of a running app on its own...


Use ldots instead of ... as per the convention

Odd test failure?

Seems like for 1.6 the error hint is never being printed not sure why.


[API] Add more filters to issues search

Add time filter for issue search (since, before)
Add limit option for paggination
Add Filter for: Created by User, Assigned to User, Mentioning User

Codecov Report

Merging #13514 (5175ee1) into master (374ff60) will decrease coverage by 0.01%.
The diff coverage is 52.83%.

@@            Coverage Diff             @@
##           master   #13514      +/-   ##
==========================================
- Coverage   42.17%   42.16%   -0.02%
==========================================
  Files         696      696
  Lines       76437    76467      +30
==========================================
+ Hits        32240    32243       +3
- Misses      38912    38930      +18
- Partials     5285     5294       +9

Impacted Files
Coverage Δ

routers/api/v1/notify/repo.go
72.97% <0.00%> (ø)

routers/api/v1/notify/user.go
25.00% <0.00%> (ø)

routers/api/v1/repo/issue_comment.go
34.05% <0.00%> (ø)

routers/api/v1/repo/issue_tracked_time.go
19.79% <0.00%> (ø)

routers/api/v1/repo/issue.go
50.45% <50.00%> (-0.35%)
:arrow_down:

routers/api/v1/utils/utils.go
66.66% <62.50%> (-13.34%)
:arrow_down:

models/issue.go
56.73% <100.00%> (+0.14%)
:arrow_up:

modules/charset/charset.go
68.53% <0.00%> (-4.50%)
:arrow_down:

modules/queue/workerpool.go
58.77% <0.00%> (-3.27%)
:arrow_down:

services/pull/pull.go
40.78% <0.00%> (-0.50%)
:arrow_down:

... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 374ff60...5175ee1. Read the comment docs.


SE-16475: Socket connector | How to edit the message header size.

Closing as content was merged in https://github.com/mulesoft/docs-connectors/pull/948/files


fix: [CDS-100941]: Make account id optional in gitops data resources.

Title: [Component/Feature] GitOps deprecate accountId
Summary:
Since account id may be in existing data config, even though it is not required for fetching resource we cant make it just computed, must be optional too.
Details:
Explain the changes in detail, including any relevant context or background information.
Related Issues:
Reference any related issues or tickets
Testing Instructions:
Describe how the changes were tested. Include any test cases or steps to verify the functionality.
Please include the below test scenario with your changes.

Create the resource and execute terraform apply. (Verify the resource is created)
Execute terraform apply again without any changes. (Verify no changes should be done)
Update the resource and execute terraform apply. (Verify the resource updated successfully)
Remove the content from resource file and execute terraform apply. (Verify the resource has been deleted)
Add again the resource and execute the terraform apply. (Verify the resource is created)
Verify the import the resource file is working fine.
In case of remote entity, Verify for both default and non default branch.

Screenshots:
Include before and after screenshots to visually demonstrate the changes.
Checklist:

[x] Code changes are well-documented.
[x] Tests have been added/updated.
[x] Changes have been tested locally.
[ ] Documentation has been updated.

PR Check triggers

Build: trigger build
Sub Category Field Check: trigger subcategoryfieldcheck
gitleaks: trigger gitleaks

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Mirko seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


FastFox 109

@bestplayerbot I don't know. I have not come across any relevant information. I'm always looking to see if a developer will shed more light on this topic. I would stick with literal CPU cores for now. But as I've noted, that changed since Fission was introduced, so who really knows lol.


Fixed input width sizing

If you typed a really long string into the input it would break the layout. This fixes that
https://github.com/JedWatson/react-select/issues/1127
Test

Run npm start
Goto http://localhost:8000/
Type something long into an input, it should not break the layout

This seems to cause some screwy behavior when with multi when autosize={true}.

The drop-down arrow moves leftward as more text is written.
If multiple options are already selected and then long typing occurs the appearance of the items breaks in a strange way.


Fix compilation without deprecated APIs in OpenSSL 1.1

Prior commit was tested with 1.0.2. This one with 1.1.
This is for 1.7.x

Hi @neheb , I see this:
/znc-src/src/Utils.cpp: In static member function 'static void CUtils::GenerateCert(FILE*, const CString&)': /znc-src/src/Utils.cpp:102:52: error: 'X509_getm_notBefore' was not declared in this scope
https://travis-ci.org/znc/znc/jobs/459997299
Please take a look

I would guess that buildbot is using LibreSSL. Define needs to be updated.


engine: fix engine panic during dagger call ... terminal with nesting

TODO:

[ ] Actually fix, just reproing in integ test so far and sending out so I don't forget about this

Problem is the engine hits a nil panic due to dagql.CurrentID() being nil during Query.RegisterClient, which is due to the fact that the terminal is being connected to direct over a websocket at that point, not via a gql query
This will also be fixed by https://github.com/dagger/dagger/pull/7315, so if that's merged first then I'll just throw this test in there so we have coverage of this flag on terminal now.

[ ] Perhaps separate issue, but the fact that the CLI hangs when this panic happens rather than exiting is also a bug

Okay yeah this test passes on top of https://github.com/dagger/dagger/pull/7315 due to the fact that the bug here involves client registration and that PR completely removes the entire notion of that registration (good example of why it's a worthwhile simplification...), so I just migrated the test to that PR and will let us pick up the fix from it. Closing this one out.


Modify Avatar to add imageStyles when image error

Details

Simply the avatar component was applying the style to the Image component. But not the Icon component. The icon component is used when This.state.imageError is true. which could happen when there is a problem loading the avatar image. To solive it i wrap the Icon in a View and apply the styles to it.
Fixed Issues

$ https://github.com/Expensify/App/issues/12645
$ https://github.com/Expensify/App/issues/12645#issuecomment-1318981321
Tests

Force the component to be in the error state by setting this.state.imageError to always true
Run through the entire app on all platforms confirming all locations and uses of the Avatar component still work.

[x] Verify that no errors appear in the JS console

Offline tests

The changes are only applied when the app is offline. So for offline tests simply run through the QA steps below to confirm the component styling is still proper while offline.
QA Steps

The test here could be done by having Airplane mode on. That seems to trigger the altenrative version of the component where the issue existed. So to test the app we need to check the component is still working properly (only style changes applied) in the entire app on all platforms on Airplane mode.

Turn on Airplane mode
Confirm the Avatar still looks good in all screens on all platforms

Note: because if you have airplane mode you might not be able to access some pages (i.e you need internet to login) You might have to toggle between on/off for airplane mode a few times while testing.

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above

[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms

[x] I ran the tests on all platforms & verified they passed on:

[x] iOS / native
[x] Android / native
[x] iOS / Safari
[x] Android / Chrome
[x] MacOS / Chrome
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)

[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product was added in all src/languages/* files
[x] I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers

[x] I followed the guidelines as stated in the Review Guidelines

[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)

[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)

[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such

[x] I verified that if a function's arguments changed that all usages have also been updated correctly

[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)

[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.

[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

PR Reviewer Checklist
The reviewer will copy/paste it into a new comment and complete it after the author checklist is completed

[ ] I have verified the author checklist is complete (all boxes are checked off).
[ ] I verified the correct issue is linked in the ### Fixed Issues section above
[ ] I verified testing steps are clear and they cover the changes made in this PR

[ ] I verified the steps for local testing are in the Tests section
[ ] I verified the steps for expected offline behavior are in the Offline steps section
[ ] I verified the steps for Staging and/or Production testing are in the QA steps section
[ ] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[ ] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[ ] I checked that screenshots or videos are included for tests on all platforms
[ ] I included screenshots or videos for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:

[ ] iOS / native
[ ] Android / native
[ ] iOS / Safari
[ ] Android / Chrome
[ ] MacOS / Chrome
[ ] MacOS / Desktop

[ ] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[ ] I verified proper code patterns were followed (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[ ] I verified any copy / text shown in the product was added in all src/languages/* files
[ ] I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I verified that this PR follows the guidelines as stated in the Review Guidelines
[ ] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] I verified that if a function's arguments changed that all usages have also been updated correctly
[ ] If a new component is created I verified that:

[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn't already exist
[ ] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[ ] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots

Web

https://user-images.githubusercontent.com/33489215/203200304-942b526e-4552-45fb-a4da-5a15a3885c06.mp4
Mobile Web - Chrome

https://user-images.githubusercontent.com/33489215/203212375-40869943-0b2d-4379-a32a-95386d49c82b.mp4
Mobile Web - Safari

https://user-images.githubusercontent.com/33489215/203206675-b987e5bd-9edd-49ce-929c-5e8e8b266fcc.mp4
Desktop

https://user-images.githubusercontent.com/33489215/203198941-ec147305-f918-48ff-a463-363930e109dd.mp4
iOS

https://user-images.githubusercontent.com/33489215/203212256-4cb7d169-2024-4281-8bd5-ce17a16e350f.mp4
Android

https://user-images.githubusercontent.com/33489215/203201540-f5a783c5-530b-4152-998b-23d211061351.mov

I have read the CLA Document and I hereby sign the CLA

recheck

recheck

If you notice the offline avatar shape change in the videos. Its another bug that is currently being fixed. Here is the issue associated with it
https://github.com/facebook/react-native/issues/32883
Took a while to hunt down but i was gonna report it my self.

@parasharrajat let me know once you are done with review :)

Now, we just need to filter the extra background color that is being applied to the icon. It looks a little darker as mentioned in https://github.com/Expensify/App/issues/12645#issuecomment-1319059138.
I think it won't be safe to remove the fill condition which sets the offline color. Instead, remove the background from image style for the the new View you added but keep it for the image.

@parasharrajat I just extended the component. Tested it on a few platforms looks good to me.

@parasharrajat apologies on the styling. still getting used to the app.

This does not make sense to me. Could you please add a basic offline test?

Turn the Internet off on the device by _____________.
Open New Chat from :heavy_plus_sign:  FAB button.
Add a new email that does not exist.
Create Chat.
Chat is created successfully.

etc.

@parasharrajat considering our changes are only applied when this.state.imageError is true Then isnt a better test to set this.state.imageError = true and run through the app. basically testing if all components where using the area of code i changed ?

That is a better test for developers but can QA team change the code on staging? we should write QA steps in a way that a non-technical person is able to test them.

@parasharrajat The steps under the QA section should cover that. as it will be in airplane mode(offline mode)

i updated the offline section to refer the QA section if that helps.

@parasharrajat is the build issue on ios related to yoga ?

There was cache issue which is resolved now.

@sketchydroide  any updates on the PR ?

sorry but you had to wait for me to get back to work :D

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by @sketchydroide in version: 1.2.32-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by @luacmartins in version: 1.2.32-2 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅

🚀 Deployed to production by @luacmartins in version: 1.2.32-2 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅