Order reconciliation issue

Some transactions are not getting updated correctly on the Medusa dashboard. This happened randomly.
Manually had to fulfil some orders. Successful orders (2 of them) were recorded as pending on Medusa

Hello @a11rew 👋
Just some context here... @OWUREE is a Paystack employee. I had a long call with them this week where I detailed an issue that I was having, and their investigation led back to this plugin as being the potential cause.
I've had now 2 orders that have been placed where Paystack completes the transaction and the money is cleared, but the MedusaJS store does not allocate the payment to the order and so the order is left in limbo.
It seems that this MedusaJS Paystack plugin sometimes misallocates a payment to an order and then nothing shows up in my MedusaJS backend, even though the transaction was completed with them.
Most recently, in the last 30 minutes, a colleague placed an order. They were kind enough to screenshot the message they saw (attached here)
It'd be great if you had the time to debug this a bit together and hopefully we can resolve?
Many thanks
PS: This image was taken after the payment was completed - IE the payment ref could not be attached to the order..?

PS: I also had a long chat with a MedusaJS dev on their Discord, and they also verified that its likely the payment plugin that is the issue here :/

Extra info: I can see a record in payment table in MedusaJS, and this transaction that was successful, is missing the payment field that contains the order in question

Something tells me this is similar to this issue https://github.com/a11rew/medusa-payment-paystack/issues/95#issue-2175774603.
I am curious are all amounts exactly how you want them. You mention only this one transaction had errors. But am curious of the amounts of the rest, is there that difference i.e in db cart amount being 21500 and customer paid 215. is this expected behavior on your side and how were the rest 3 transaction amounts

Same issue

Same issue

Thank you for all the information!
I see two issues to be addressed here (correct me if wrong):

Orders are paid for in Paystack but the plugin fails to mark them as paid for in Medusa
I appreciate the wealth of information you've shared here but they're missing probably the most important of them all: the backend logs at the time of these happening. Errors in the plugin should be getting logged out to give you clues on what's going wrong, whether they're Paystack API issues or internal Medusa issues. Especially with debug mode turned on. Could you share these?
This is most likely occuring because of an issue authorizing those specific payments.
Without any more information, I've seen this happen most often because of stale transaction references: The transaction reference in the cart data is updated by the plugin when the cart is updated with new information (think emails, amount, line item count etc). If for any reason your storefront is not using the latest txRef in the cart data at the time of transaction initialization, users will pay for one transaction while the plugin tries to verify another. You should confirm this is not happening in your storefront

Duplicate transaction reference error after making payment.
This I am guessing happened because the person made payment in the Paystack popup successfully, waited for order confirmation but was sent back to the checkout page. They then clicked the payment button again (because what is going on?!) and got greeted with the duplicate transaction error.
This is happening because of issue number 1: Medusa tries to confirm if the order was paid for, the plugin errors out. The default starter-kit does not have very good checkout error handling so users just get sent back to the checkout page. Concluding therefore this can be collapsed into issue number 1 above.

Again, thank you for the detailed bug report. Hoping we can resolve this here as opposed to a meeting so the fix is public, for posterity.

Saw you shared server logs in the discord, followed up there. A 504 from Paystack when trying to confirm the transaction will do this. You could handle the error and retry the cart completion to resolve this.

Thanks for the time to reply @a11rew
@OWUREE any thoughts on the above? Why would Paystack reply with a 504?

They say it is unusual and should be reported, see this on 5xx errors. So the go-to should be what @a11rew suggests. Handle the error so if it happens in future, you can retry the cart completion. I'd also suggest doing something custom like send yourself a text or email, or using something like Sentry to catch the error, and know when it happens hopefully, slim chances of it happening again.

thanks for this @a11rew - I have chatted about this with Paytstack. Question: Is the Paystack callback URL meant to be my storefront URL, or the MedusaJS URL? I have it set to storefront, but just wanting to confirm this?

@iaremarkus this plugin does not provide first class support for the Redirect payment flow which setting the callback URL implies you're looking to use.
Setting it to either the storefront or backend without doing additional work to support the flow (unless of course you've done this) will not do much.
"Additional work" here means setting up a route which when users are redirected to, calls the cart completion method which in turn gets Medusa to ask this plugin to verify the payment transaction.
I say we do not have 1st class support because the plugin exposes the authorization_url you need for the Redirect flow in the paystackTxAuthData object but does not set up the route for you. This is part of the payment session's data:
"paystackTxRef": "3eg6u4benc",
"paystackTxAuthData": {
  "reference": "3eg6u4benc",
  "access_code": "itxwli1w3yo3epx",
  "authorization_url": "https://checkout.paystack.com/itxwli1w3yo3epx"
}

You could redirect customers to the authorization_url in the storefront, handle the aforementioned calling of the complete cart method and show users the order success page (since you know the order was definitely paid for). However, this only hides the underlying problem instead: orders will not be marked as paid for in Medusa, services like order notifications and automated fulfillments will not be triggered, and the order will not show up in the user's account.
Regardless of the flow used (Redirect as opposed to the Popup flow here), a 5xx error from Paystack when verifying the transaction without great error handling in place will break the payment flow and leave the user in limbo. To fix this issue, you should be handling errors from calling the cart completion method: retrying in case of Paystack 5xx errors as a temporary fix for this particular issue (more on this below) or showing users an error page when anything else goes wrong so you don't have users clicking the payment button again after errors. This is what I meant by you should be handling the errors and retrying where appropriate.
Handling and retrying on Paystack 5xx errors should not be something you should have to do however (sorry 😅), this plugin should be handling the verification of payments better. 5xx errors from Paystack are rare and I never ran into them during dev hence the lack of support and test cases for it.
I have created issues #97 and #98  to improve this experience: both by supporting 5xx retries internally and verifying payments definitively with webhook notifications from Paystack. I hope to get to these this week, anyone is welcome to submit PRs for them too. In the meantime, handling retries on cart completion errors should fix this for you

Thanks @a11rew. TBH I didn't think your plugin needed this, but @OWUREE had asked me via email about this setting so I wanted to confirm/make sure.
Appreciate your work on this plugin. Certainly made my job easier 😊

You're awesome, thanks @a11rew

*bump 😊

No @iaremarkus the context of this thread is why retries were added. You should leave it set to false (the default). The disable_retries option was added for configuration but you should not have to use it, retries only happen on safe to retry requests.

Thank you very much 🙏

Hi @a11rew. This is Haneefat from Paystack's Developer Relations team.
Based on our investigation of the reference dhpg5ky5o2 @iaremarkus shared, there was no request to verify the transaction on our server. Kindly share the endpoint you made this request to, and the request payload.
Please share the necessary logs.
Thank you

v1.3.0 is out with support for order confirmations via webhook. This section in the readme describes setting webhooks up.
When enabled, the issue that occurred here (order confirmation failing because of a 504 from Paystack that wasn't retried when verifying the transaction) should not occur anymore because in addition to the manual verification that happens when you call completeCart, the plugin listens for webhook events from Paystack and confirms the order automatically (also with retries) on the backend.
For optimal UX in cases where completeCart fails for reasons like this, you can setup a notification system either with websockets, server-sent events or just long polling on the frontend checkout page to listen for the order being confirmed through the webhook then redirect users to the confirmation page for the cart's associated order.
Closing this issue. Feel free to re-open if this happens again with webhooks enabled.


(GH-444) Refactor code around Boxstarter specific parameters to make it clearer

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[x] I have added tests to cover my changes.
[x] All new and existing tests passed.

this PR fixes GH-444

Awesome work! Thanks for your contribution @mwallner!


bpf: Inter-cluster SNAT with ClusterIP global service

Implement very basic inter-cluster SNAT logic with ClusterIP global service. All the features are hidden behind the conditional macro, so it shouldn't affect the existing code path.
The datapath changes are split into small pieces. Here's a quick guide to how commits are organized.

bca1ca8ff1f1df771eb20406b61968e6fd0afd33 - 73912400cd443058f5b65ad4ce8b52db9f5afca0 are preparatory commits (define macros, drop reason, etc...)
138010355922b60c53104372c441733fdbe4ce3e - 52c5273d05a62793cae31ffba57047f9c437bace are commits for actual datapath logic. The commits are ordered by packet flow, so if you read the code commit by commit, you'll automatically follow the packet flow. Labels in commit titles such as Client/Egress indicates which code path you're in.
92ea731db7b01b61fb3487f2b1f4c94e6fcce3f3 - 8faed41ca1fd1430ea1be896f8c02796e5bcb9f8 are tests. Note that the failure of BPF Unit Test is expected.

bpf: Inter-cluster SNAT with ClusterIP global service

/test

/test

/test-1.26-net-next

/test

/test-1.26-net-next

/test-1.16-4.19

/test-1.16-4.19

/ci-verifier

/test-1.16-4.19

/test-only --focus="K8sDatapathVerifier"

/test-only --focus="K8sDatapathVerifier"

/test-only --focus="K8sDatapathVerifier"

/test-1.16-4.19

/test

/test

/ci-multicluster

/ci-multicluster

/ci-multicluster

/ci-multicluster

/ci-multicluster

/ci-multicluster

/test

/test-1.16-4.19

/test-1.25-4.19 --focus="K8sDatapathVerifier"

/test-only --focus="K8sDatapathVerifier" --kernel_version=419

/test

/gateway-api-conformance-test

Test failure for the BPF checks is due to the bug of Coverbee. I'm considering introducing a new BPF unit test feature that disables coverage reports in some units (e.g., per file). It's succeeding at least in my local.

@julianwiedmann Could you kindly take a look? While I was working on this PR, I had a lot of conflicts with your refactoring work, so it would make sense to have your eyes I think.

/test

/test-1.24-5.4

/test

/test

ConformanceGKE: https://github.com/cilium/cilium/issues/22368
k8s-1.24-kernel-5.4: https://github.com/cilium/cilium/issues/16122

/ci-gke

@julianwiedmann Thanks for your review. I reflected on your comment and split the commit into small pieces. Please review it again 🙏

/test

/gateway-api-conformance-test

/gateway-api-conformance-test

ConformanceGatewayAPI error looks exactly the same as https://github.com/cilium/cilium/issues/24217, but 100% reproducible so far. Let me dig in.

Now it's ready to merge @nathanjsweet. Please give me 🍏 and if I won the race, please mark this PR ready-to-merge.


Common / Multiple Middlewares

This patch enables:

setting ALL attribute to use a common middleware prior to all http method-specific middleware.
setting various kinds of methods, such as TRACE, OPTIONS, PATCH, HEAD.
Simply adding a new method name( http://expressjs.com/en/api.html#app.METHOD ) will enable any other method.
setting ALL or METHOD(e.g. GET, POST) attribute to an array of middlewares instead of a single middleware, to route them in series.

This looks good to me, thanks for taking the time to submit the PR.

Shame on me, I just found that this won't work because I thought that typeof of an array is 'array', which is 'object'. I guess I'd better check if the patch works first before commit.
If we fix line 104 in dynamic-routes.js from 'array' to 'object' and modify the for loop to for(var k in middleware) then the code will work.

I just created a new PR to fix those issues.


Add Video to README

Current coverage is 98.26% (diff: 100%)

Merging #82 into dev will not change coverage

@@                dev        #82   diff @@
==========================================
  Files             7          7
  Lines          1036       1036
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
  Hits           1018       1018
  Misses           18         18
  Partials          0          0

Powered by Codecov. Last update 6e24d34...20e7cbe


Update GeoCombine instructions for GeoDiscovery specific tasks

Document the process of setting up GeoCombine in a new deploy, including copying files from previous release and updating git repos so that the scheduled pull tasks will fire as expected.

[geoblacklight@liblamp-dev8 current]$ ls tmp/opengeometadata/
edu.illinois  edu.msu  edu.osu  edu.purdue   edu.uchicago  edu.umd    edu.umn  edu.uwm            edu.wisc.aardvark
edu.indiana   edu.nyu  edu.psu  edu.rutgers  edu.uiowa     edu.umich  edu.unl  edu.uwm.converted

RAILS_ENV=production SCHEMA_VERSION=Aardvark bundle exec rake geocombine:index
Can we be setting those ENV variables in a .env file? If not, they need to be documented.

OGM_PATH=tmp/opengeometadata/edu.uwm/metadata-aardvark/ bundle exec rake geocombine:index

Completed via https://github.com/UWM-Libraries/GeoDiscovery-Documentation/commit/c7706a17552c3bca4a34dfde630dd8420a299e43


RAG Chat - "path" undefined - error getting data retriever

Affected components(s)

[ ] Chat Agents
[x] Chat Endpoints
[x] RAG
[ ] LLM Models
[ ] Vector Stores
[ ] Chat History
[ ] Response Caching
[ ] API Key Authentication
[ ] Endpoint Deployment
[ ] Other

Describe the bug
path is undefined error when trying to get data retriever.
QvikChat version:
1.0.1
Additional context
Enable to create RAG chat endpoint.

c5198f9a0cbac9c9f868a654b5d06b764c274cf1
Fixed.


Expand Python testing to 3.12

For our awareness on setuptools, search for "setuptools" on this page:
https://docs.python.org/3/whatsnew/3.12.html


[WIP] LINK-1340 external user adds event images

Description :sparkles:
Issues :bug:
Closes :no_good_woman:
DEV-XXX:
Related :handshake:
Testing :alembic:
Automated tests :gear:
Manual testing :construction_worker_man:
Screenshots :camera_flash:
Additional notes :spiral_notepad:

Codecov Report

Merging #203 (bac8052) into develop (9c5c0c7) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff            @@
##           develop     #203   +/-   ##
========================================
  Coverage    99.88%   99.88%
========================================
  Files          507      507
  Lines         9456     9462    +6
  Branches      2075     2078    +3
========================================
+ Hits          9445     9451    +6
  Misses          11       11

Files Changed
Coverage Δ

.../common/components/imageSelector/ImageSelector.tsx
100.00% <100.00%> (ø)

...n/event/formSections/imageSection/ImageSection.tsx
100.00% <100.00%> (ø)

src/domain/image/utils.ts
100.00% <100.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Redraw 2D viewport when guides are cleared

queue_redraw() wasn't being called after the "View > Clear Guides" menu option was pressed, leading to guides remaining on screen until some other action requests a redraw (such as focus changing or clicking in on the viewport).
Fixes #72940

Thanks!

While in a sense it doesn't make any difference for the "do" action, this should've been implemented with add_do_method for consistency and to prevent errors in future, same as it's done for undo. I removed the cherrypick label because it's better to fix this inconsistency before cherrypicking.

Cherry-picked for 4.0.1 with a fixup, and opened https://github.com/godotengine/godot/pull/74904 for master.


fix(cli): Unbox command should run as release

Running aztec-cli unbox with the 0.17.0 CLI will unbox creating an .aztec-packages folder and setting dependencies as portals:
~/Projects/tmp/unbox$ which aztec-cli
/home/santiago/.aztec/bin/aztec-cli
~/Projects/tmp/unbox$ aztec-cli --version
0.17.0
~/Projects/tmp/unbox$ ls blank/.aztec-packages/
barretenberg  yarn-project
~/Projects/tmp/unbox$ jq .dependencies blank/package.json
{
  "@aztec/accounts": "portal:.aztec-packages/yarn-project/accounts",
<EMAIL_ADDRESS>"portal:.aztec-packages/yarn-project/aztec.js",
  "serve": "^14.2.1"
}

This seems to point to aztec-cli not picking up the COMMIT_TAG env var here:
https://github.com/AztecProtocol/aztec-packages/blob/fc1d5399f24edafdc10cf9810f0cc6268008a3d8/yarn-project/cli/src/cmds/unbox.ts#L38-L55
This fix should make the env var available to the CLI. However, I haven't tested this (is it possible to build the cli image as if it were a release?), and it's unclear if this is the "right" fix. Should the CLI expect that env var at all? Should the default be "release mode" and only require an env var to run in "dev mode"?

WDYT if we set the COMMIT_TAG env var here so that every project has access to it?
https://github.com/AztecProtocol/aztec-packages/blob/fc1d5399f24edafdc10cf9810f0cc6268008a3d8/yarn-project/Dockerfile.prod#L33
The reason ARG COMMIT_TAG was added to the CLI's dockerfile was so its image would be rebuild on releases tags.

I like the idea! @spypsy what do you think?

Updated, please re-review!

Just tested it, and it does:
~/Projects/tmp/docker$ cat Dockerfile.base
FROM alpine

ENV BASE_FOO=foo
ENV BASE_BAR=bar

~/Projects/tmp/docker$ cat Dockerfile.child
FROM env-test-base

ENV BASE_BAR=overridden
~/Projects/tmp/docker$ docker run --rm env-test-child env
PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin
HOSTNAME=e4a1237e0b26
BASE_FOO=foo
BASE_BAR=overridden
HOME=/root


⚠ Bofrost.fr has degraded performance

In f5d959b, Bofrost.fr (https://www.bofrost.fr) experienced degraded performance:

HTTP code: 200
Response time: 1862 ms

Resolved: Bofrost.fr performance has improved in 97a4938 after 8 minutes.


Keep persistent connections in client

Add support for persistent connections in client
Remove gojo dependency

Fixes #65

Double-checked everything and merged, nicely done 👏 👏


[MINOR][DOCS] Add proper periods and spaces for CLI help messages and config doc.

What changes were proposed in this pull request?
This PR adds some proper periods and spaces to Spark CLI help messages and SQL/YARN conf docs for consistency.
How was this patch tested?
Manual.

Test build #53625 has started for PR 11848 at commit bc171b7.

OK, it's minor, but I suppose that improves consistency. Fixing the space problems is good.

Test build #53625 has finished for PR 11848 at commit bc171b7.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/53625/
Test PASSed.

Thank you, @srowen !

Merged to master

Thank you again!


Add capabilities to add video/image to simulator

Add the capability to push a video/photo to simulator.

Updated, waiting for CI churning churning churning


navcoin-qt segfaults on linux

Tried with Arch and with Ubuntu. Recompiling from source doesn't help, and still results in:
SIGSEGV {si_signo=SIGSEGV, si_code=SEGV_MAPERR, si_addr=0xa0000028}

Fixed on v<IP_ADDRESS>


improve the about page of the application

[ ] Fixes issue #17: "improve the about page of the application"
[x] Other checks

Reason for pull request:
"to analyse my changes and give feedback & further instruction's"
Description of changes or additions:
"changes the font size and colour of the about page"
Screenshots:
"Insert screenshots here if available"

@Shiv-sharma-111 Thanks for the PR.


fix(search): tag/term should filter for both entity and field level

Checklist

[x] The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
[ ] Links to related issues (if applicable)
[ ] Tests for the changes have been added/updated (if applicable)
[ ] Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
[ ] For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

Looks like the cypress test is failing because the tag that I added for this purpose is not appearing when every other test is running. Or something else. Will need to check what is happening here before merging the PR in


Kotlin: Support JVM class hierarchy when resolving common ancestors

If a union of types (or equivalent) is known at generation time to the JVM (i.e. can be loaded via class loader), then the JVM hierarchy of that type should be considered when resolving the common ancestor of the types.
For example, given the following RAML:
types:
  Int:
    type: number
    format: int32

  Float:
    type: number
    format: float

  Number: (Int | Float)

The common ancestor of Number should resolve to kotlin.Number.
Currently it resolves to kotlin.Any.

Decided against this as it only applies to Kotlin targets


Training on GPU got error on CPU decoding

I got this error while doing d_vector extraction. Is D-vector output of 2nd CNN layers?   Error seems to be due to availability of Torch GPU version and not CPU. How did you handle in your case? Thanks! Below is error message:
import torch
File "anaconda3/lib/python3.6/site-packages/torch/init.py", line 80, in
from torch._C import *
ImportError: /lib64/libc.so.6: version `GLIBC_2.14' not found (required by /anaconda3/lib/python3.6/site-packages/torch/_C.cpython-36m-x86_64-linux-gnu.so)

This seems to be a more basic error due to the GLIBC. Could you try to
upload your python to 3.7 and you pytorch to 1.0?
Mirco
https://www.avast.com/sig-email?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail
Virus-free.
www.avast.com
https://www.avast.com/sig-email?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail
<#DAB4FAD8-2DD7-40BB-A1B8-4E2AA1F9FDF2>
On Mon, 15 Apr 2019 at 12:48, hdubey<EMAIL_ADDRESS>wrote:

I got this error while doing d_vector extraction. Is D-vector output of
2nd CNN layers? Error seems to be due to availability of Torch GPU version
and not CPU. How did you handle in your case? Thanks! Below is error
message:
import torch
File "anaconda3/lib/python3.6/site-packages/torch/init.py", line 80, in
from torch.C import *
ImportError: /lib64/libc.so.6: version `GLIBC_2.14' not found (required by
/anaconda3/lib/python3.6/site-packages/torch/
C.cpython-36m-x86_64-linux-gnu.so)
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/mravanelli/SincNet/issues/34, or mute the thread
https://github.com/notifications/unsubscribe-auth/AQGs1hvGcIkV8k7pbUI57UKRarhpcg7Eks5vhK1jgaJpZM4cwcQU
.


Call Path in a SVG with an empty content element causes an InvalidArgumentException

When you have an element like SvgText with an empty text in the documento and you call SvdDocument.Path to get the path of the entire document, it throws an InvalidArgumentException.

This problem is still present.


How to enable the font family dropdown

Maybe a dumb question, but if i use your example i don't get the second row of the bar i can see in the demo.
I also checked the demo code and i don't see any relevant differences.
Can you point me out to what i could be missing?
Thanks for your work!

Hi Paolo,
would be great if you can present your example on CodePen or relative tools
so we can see the markup.
On Sun, Apr 3, 2016 at 11:27 PM, Paolo D<EMAIL_ADDRESS>wrote:

Maybe a dump question, but if i use your example i don't get the second
row of the bar i can see in the demo.
I also checked the demo code and i don't see any relevant differences.
Can you point me out to what i could be missing?
Thanks for your work!
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
https://github.com/psergus/ngWYSIWYG/issues/60

--
Best regards,
Sergey Petrenko

Sure, i will try codepen as soon as i can.
Do you have a template to start with?

I am sorry, i didn't find the time to write down a CodePen script and found another solution.
The issue can be closed.


Validate Navier-Stokes with Re = 100 lid-driven cavity

The Travis tests passed two days ago, but in this PR the Travis integration still says it's pending. I'll merge the PR anyway and Travis will test the commit to master.


[PE-D][Tester B] Unreasonable input restriction for name field

Description
Contact names with "/" cannot be added although it makes sense to. Name field only allows alphanumeric characters and spaces.
Steps to reproduce

Launch the application
Run add n/Ramanen S/O  p/98765432<EMAIL_ADDRESS>a/John street, block 123, #01-01.

Expected behaviour
The add should be successful, since all input fields are valid.
Actual behaviour

Reason for severity
This could pose as low inconvenience as it can hinder legal names with slashes. (e.g. "s/o" is not uncommon in Singaporean Indian names).
Ideas
There could be greater flexibility in the parsing/validating of input field for name!

Labels: type.FunctionalityBug severity.Low
original: lynnetteeee/ped#9

Fixed as per #115


Use consistent naming across the board

The naming seems to be inconsitent and confusing, as we there are multiple different names to refer to the same thing.
For example for gitops alone we have:

argocd-operator
gitops-operator
openshift-gitops-operator
assemble-argocd

We need to somehow narrow down the list as it get's pretty confusing.
Here are some ideas of conventions that could possibly help us:

The easiest thing to get rid of is the assemble variant.
Another option is to adopt the upstream folder name, when possible.
Aligning folder name, with namespace

Let's come back to this and create some specific story criteria


Potential module name collision

I notice typed-domready is ambientize as:
// Compiled using<EMAIL_ADDRESS>// Source: https://raw.githubusercontent.com/unional/typed-domready/master/domready.d.ts
declare module 'domready/main' {
function domready(callback: () => any): void;

export = domready;
}
declare module 'domready' {
import main = require('domready/main');
export default main;
}

I assume it gets the name main from the file name main.d.ts.
If the module has multiple exports such as core-js, using this name may cause collision on existing declare module 'module/something'

btw, what is the reasoning behind this extra level of require('domready/main')?

Because technically it's valid to do require('domready/main'), however unlikely. I just generate all the file names right now instead of diving in and trying to do heavy rewriting on how it might be used.
The main keyword is arbitrary and it can't conflict when it's inside of the declare module '...' namespace.

Ok, make sense.


Provide data set

Hi
It'd be useful if you could provide an example dataset at least for the toy example. The training script for this one is referring to data/train/sr5.
Thanks
Ben.

See scripts/toy_gen_data.sh.

@benman1 can u generate the toy data?


core validation: deep copy IMAGE_STATE and BUFFER_STATE

Neither class was deep copying the createinfo.pQueueFamilyIndicies array, which could cause invalid warnings to be reported to the user.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Hi Mark, That would be much appreciated, thank you!
On Tue, Mar 21, 2017 at 12:33 PM, Mark Lobodzinski<EMAIL_ADDRESS>
wrote:

@mark-lunarg requested changes on this pull request.
Hey Peter, the commit message needs to be formatted to match the others in
the repo and the source needs to be run through clang-format. I can do this
before pushing if it's too much trouble.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/KhronosGroup/Vulkan-LoaderAndValidationLayers/pull/1599#pullrequestreview-28215124,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ADmNqFTS3hcZDShb7_dsTosEvEHyecP2ks5roCX1gaJpZM4MhOLq
.

Fixed commit msg, clang-formatted and pushed to Master.  Thanks Peter!


Quick-Flushable DOM

From Page Logic, allow calling DOM::quickFlush, which will flush all content up to a <!--quick-flush--> comment, or something similar.
This idea is for pages with lots of computation to allow flushing the header and navigation areas as soon as possible, to make the user's experience nice and snappy.

Can't work with the DOM model... serves no purpose apart from complicating things.


Support complex matcher types like NEQ, RE, NRE in remote read config

Proposal
Support complex matcher types like NEQ, RE, NRE in remote read config
Right now remote read config required matchers (RemoteReadConfig.RequiredMatchers) is a simple map which doesn't support complex matcher types like NEQ, RE, NRE. Actually we had already support the complex matcher types like NEQ, RE, NRE in remote read request (prometheus.Query.matchers - prometheus.LabelMatcher). Is it good to use the same complex matchers in remote read config?
Current remote read config sample:
remote_read:
- url: http://host/read
  bearer_token: <secret>
  required_matchers:
    app: test

Proposed remote read config sample:
remote_read:
- url: http://host/read
  bearer_token: <secret>
  required_matchers:
    - type: EQ
      name: app
      value: test

With this proposed remote read config format, we are able to use not equal and regex.
Sample (only use this remote read data source if the query filter app!=test):
remote_read:
- url: http://host/read
  bearer_token: <secret>
  required_matchers:
    - type: NEQ
      name: app
      value: test

Any thoughts, please advise.

This isn't really sane, as we can't in general tell if a matcher will match anything other than equality. Anything like that needs to be done on the remote endpoint.
The intention of this feature is for non-storage backends, so that we don't query them unless they're explicitly asked for. What are you trying to do?

We have multiple remote read data sources, one is clickhouse, another is thanos, we'd like to route all of the queries with storage=clickhouse only to clickhouse and others only to thanos. In the future, we might need to introduce multiple thanos clusters, then we might need to introduce regex matcher to route among these thanos clusters.
Fanout the queries to all of the remote data sources cost is high. Sometimes we might have enough knowledge to route the specific query to specific remote read data source and don't require storage backend judging in our use cases.

That sounds like a setup well beyond the simple cases that this is aimed for, and you'd be best solving this outside of Prometheus.

okay, thanks @brian-brazil

Hi @garrettlish :wave:
BTW @garrettlish for me your case totally makes sense, but I need to agree with @brian-brazil required_matchers was meant to be a very simple solution. Let's keep this discussion to make sure we can help you solve the problem.
Just curious, can you explain your setup better? e.g. you are using Prometheus to use remote read to Clickhouse... and Thanos? In what way as Thanos does not support remote read at the moment. (:

Hi @bwplotka sorry for late response, I really think it will be great that we can support complex matcher types like NEQ, RE, NRE in remote read config, please help sync with @brian-brazil and let us know if I can reopen this issue.
Yes, thanos does not support remote read officially, we did that by ourself but haven't gotten chance to communicate with community :-)

Hah, sounds like some nice StoreAPI integration  (:
On Tue, 17 Mar 2020 at 06:40, Garrett<EMAIL_ADDRESS>wrote:

Hi @bwplotka https://github.com/bwplotka sorry for late response, I
really think it will be great that we can support complex matcher types
like NEQ, RE, NRE in remote read config, please help sync with
@brian-brazil https://github.com/brian-brazil and let us know if I can
reopen this issue.
Yes, thanos does not support remote read officially, we did that by
ourself but haven't gotten chance to communicate with community :-)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/prometheus/prometheus/issues/6978#issuecomment-599903241,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABVA3O7LXQG3LTUTTFGEBDTRH4LNRANCNFSM4LG54WVQ
.


Linting and pre commit checks

This PR does:

Add a github job to lint the code-base using flake8 for PEP8 checks
Makes the codebase pass flake8 linting
Harmonize newlines at the end of files
Add a missing pattern for matching Python files to .editorconfig.conf
Rename the broken JSON file used for cc-egov testing to a different file-suffix to avoid JSON linters to complain
Moves some docstrings to their appropriate places
Adds a pre-commitconfiguration for some general checks as well as running black and flake8 before every commit

Sorry for all the noise 😄  I hope to focus now more on the actually interesting pieces (django-q + OCRmyPDF)

Thanks!


Fix Issue #398

Added presencepalette.popdown() to close presence palette when activity is shared. Hopefully fixes #398.

[x] Chat Activity

[x] Memorize Activity

[x] Paint Activity

@FreddieN Is this how it should be?

Good job. Thanks.


CI: fix Alpine

FYI for next time, != should be better.

Oh, sure, obviously. I don't know what it didn't occur to me.


WIP Add Dockerfile for fedora

Issue related #2126

Cargo rpm build gives an error
   Compiling alacritty v0.3.2 (/source/alacritty)
   Compiling nom v4.2.3
   Compiling url v1.7.2
   Compiling wayland-scanner v0.21.12
   Compiling wayland-scanner v0.22.2
error: failed to run custom build command for `alacritty v0.3.2 (/source/alacritty)`
process didn't exit successfully: `/source/target/release/build/alacritty-dcce14aa21e0720c/build-script-build` (exit code: 101)
--- stderr
thread 'main' panicked at 'couldn't get commit hash', src/libcore/option.rs:1038:5
note: Run with `RUST_BACKTRACE=1` environment variable to display a backtrace.

warning: build failed, waiting for other jobs to finish...
error: build failed

debugging it

@xliiv See https://github.com/jwilm/alacritty/pull/2443.

@xliiv See #2443.

@chrisduerr , should i wait until it gets merged?
Thanks for helping with this.

should i wait until it gets merged?

That's probably a good idea, though feel free to get it working by basing it on top of the PR if you'd like to. However merging it will likely only make sense once #2443 is resolved.

@chrisduerr who can i ask for a review?

@xliiv I'll check this out once the git PR is merged. If it works I'll rebase myself and merge it as is, otherwise I'll let you know if there's anything else left to be done.

@chrisduerr thanks!

Okay, so after a bit of discussion in https://github.com/jwilm/alacritty/pull/2506, I think that is likely the better way to solve this Fedora installation problem.
Hopefully that should provide a nice way for everyone to just install Alacritty on all Fedora systems without us actually having to build inside a specific docker container.
Thanks again for the PR and sorry it didn't work out this time.

No problem, if we get better experience, i'm happy with that. Thanks!


Feature Request: List Extractors as JSON

What is the purpose of your issue?

[x] Feature request (request for a new functionality)

Hello, this is a little suggestion that I think could be useful to be possible integrate software with youtube-dl.
I needed a way to determinate what URLs can be extracted using youtube-dl. Something like:
isYouTubeDLSupported('https://google.com') // => false

Using that I can avoid pass urls to youtube-dl that actually doesn't support video extraction.
My problem was how to determinate the list of compatible services.
Although you provide youtube-dl --list-extractors, this is not actually a list of domains services that we can use for compare, but it's something.
I created a tiny script on JavaScript to convert into something more deterministic
'use strict'

const parseDomain = require('parse-domain')
const jsonFuture = require('json-future')
const youtubedl = require('youtube-dl')
const { promisify } = require('util')

const getExtractors = promisify(youtubedl.getExtractors)

;(async () => {
  // it runs `youtube-dl --list-extractors`
  const extractors = await getExtractors()

  const providers = extractors.reduce((set, extractor) => {
    // just get the first item from ':'. e.g: twitter:card → twitter
	// convert all into lowercase
    const provider = extractor.split(':')[0].toLowerCase()
    // try to determinate if the result is a domain
    const { domain = '' } = parseDomain(provider) || {}
    set.add(domain || provider)
    return set
    // remove duplicates
  }, new Set())

  await jsonFuture.saveAsync('providers.json', Array.from(providers))
})()

Here the original source code
I run every time I install my dependencies, so the script keep the providers up to date with the last youtube-dl version. This is an example of output
Then is very easy to check if the url is youtube-dl compatible; just need to extract the domain from the input url and check it into the providers list:
const providers = require('./providers') // auto-regenerated in each youtube-dl version
const isSupportedProvided = url => providers.includes(parseDomain(url).domain)

For me, it makes sense include something like this output as part of youtube-dl.
Something similar to --dump-json that makes easy connect youtube-dl with third party software but oriented for know compatible services.
Maybe --list-extractors-json? I don't know, what do you think 🙂

I needed a way to determinate what urls can be extracted using youtube-dl.

You can't do that without running the actual extraction process.

Although you provide youtube-dl --list-extractors actually these list are not domains, so I was to convert the list into a domain list.

This is completely senseless. They are provided not as domain on purpose.

Then is very easy to check if the url is youtube-dl compatible

This won't work as already described.


Allow shell commands to provide ghci history

I would like to be able to use external bash tools like fzf (https://github.com/junegunn/fzf) fuzzy finder to the command history in ghci.
To do so, will require at least two features to be added to ghci/intero:

A ':save-history' command to save the current history to ~/.ghc/ghci_history on demand instead of at end of ghci-session. Ie, expose https://hackage.haskell.org/package/haskeline-<IP_ADDRESS>/docs/System-Console-Haskeline-History.html#writeHistory

A ':!= ' which will run a shell command and put the output onto the ghci commandline.
I could use ':cmd ' but it runs the result of  instead of printing it to the commandline. This means:
2.1. I can't select a command from history, and edit it before running it.
2.2. The ghci history will show ':cmd (readProcess "fzf-ghci-history.bash" [] "")' and the ghci stdout won't show which command was selected.

Optional: a way to bind a key to run ghci ':def' defined commands, so I will be able to bind Ctrl-R to run fzf on ~/.ghc/ghc_history.

Do you think this is a worthwhile addition?

This only applies to the intero executable? I'm not opposed to these additions. They don't seem to present a big architectural change.

Feel free to open a PR implementing exactly as you describe above. :+1:

Great! I will work on this :)


ITMS-90362 error on itunes upload

Nevermind, I fixed this issue ... Not sure how to delete the issue entirely though.

@dlr2, could you please tell me more about your issue?

The problem was that the SK version was set to 7.0 - but had to be at least
8.0 to iTunes upload. I fixed it right after I posted but I did not know
how to delete the whole issue. Sorry.
On Thu, Feb 4, 2016 at 4:39 AM, Suyeol Jeon<EMAIL_ADDRESS>wrote:

@dlr2 https://github.com/dlr2, could you please tell me more about your
issue?
—
Reply to this email directly or view it on GitHub
https://github.com/devxoul/JLToast/issues/65#issuecomment-179733772.

How did you install JLToast?

As a pod for an iOS SDK9 app. But the pod installed citing SDK 7 - I
changed that and it worked fine.
On Thu, Feb 4, 2016 at 12:04 PM, Suyeol Jeon<EMAIL_ADDRESS>wrote:

How did you install JLToast?
—
Reply to this email directly or view it on GitHub
https://github.com/devxoul/JLToast/issues/65#issuecomment-179947696.

@dir2, Which did you mean: 'SDK' or 'Minimum Deployment Target'?

Oh right I meant - Minimum Deployment Target - sorry
On Fri, Feb 5, 2016 at 9:45 AM, Suyeol Jeon<EMAIL_ADDRESS>wrote:

@dir2 https://github.com/dir2, Which did you mean: 'SDK' or 'Minimum
Deployment Target'?
—
Reply to this email directly or view it on GitHub
https://github.com/devxoul/JLToast/issues/65#issuecomment-180384714.

@dir2, you cannot install Swift libraries via CocoaPods if your Minimum Deployment Target is 7. For details, see the CocoaPods blog post.
If you want to use JLToast in iOS 7 projects, consider using CocoaSeeds. You can follow the instruction on README


Sales page search field has wrong prefilled text

On Sales page, user searches for "Buyer".
On Purchases page, user searches for "Vendor".
On Cases page, user searches for "Vendor/Buyer"? (I have no case, need to check this).

The placeholder is correct when you're on the Purchases tab, but incorrect when on the Sales tab.
We'll probably want to change the placeholder text to Search by Order #, Title or Buyer when on the Sales tab.


set auth env

The code looks fine but can you just detail what this code is needed for and why? I'm not familiar with the issue or reason behind this - so would be good to document for myself and others.

@jthomas I'll open an issue and link it so we have the history.

Related issue https://github.com/nimbella/nimbella-deployer/issues/16.

I am curious though about my question:

what happens when process.env.WHISK_AUTH = undefined (or deleted here instead)?

The CLI so far has avoided setting WHISK_AUTH.


make the clear button customizable

I added a property named clearButtonClassName which will be added to the clear button classname property, to make it customizable !

Can you add a test to make sure this keeps working in the future?

Here you go !


Investigate NLU Interpreters with Regards to spaCy

A bug on rasalit prompted me to investigate how our interpreters work.
It seems there are two methods of retrieving an interpreter.
from rasa.cli.utils import get_validated_path
from rasa.model import get_model, get_model_subdirectories
from rasa.nlu.model import Interpreter

def load_interpreter_a(model_dir, model):
    path_str = str(pathlib.Path(model_dir) / model)
    model = get_validated_path(path_str, "model")
    model_path = get_model(model)
    _, nlu_model = get_model_subdirectories(model_path)
    return Interpreter.load(nlu_model)

from rasa.core.interpreter import RasaNLUInterpreter

def load_interpreter_b(model_dir, model):
    path_str = str(pathlib.Path(model_dir) / model)
    model = get_validated_path(path_str, "model")
    model_path = get_model(model)
    _, nlu_model = get_model_subdirectories(model_path)
    return RasaNLUInterpreter(nlu_model)

It seems that we have an Interpreter and a RasaNLUInterpreter. It's not 100% clear to me what the difference is but after trying it out I noticed that the former will cause an error if a SpacyEntityExtractor is used. It would be good to investigate the subtle difference and document it properly for two reasons.

We have a lot of interpreters at this point and there might be some consolidation possible. If nothing else the difference should be made clear in the docstring.
I might need to rewrite a tutorial before other community members hit their head.

Related Slack thread: https://rasa-hq.slack.com/archives/C8LEHMTAM/p1607430725036700

Should this really be classified as a bug?

@JEM-Mosig As far as I understood @koaning the SpacyEntityExtractor does not work during prediction in some scenarios. In that case it would be a bug. @koaning can you maybe describe in more detail in what kind of situations the SpacyEntityExtractor does not work and maybe give a minimal example to reproduce the error? Thanks.

I don't think its is the research issue, I moved it to Production board

can you maybe describe in more detail in what kind of situations the SpacyEntityExtractor does not work and maybe give a minimal example to reproduce the error? T

@koaning Could you please elaborate on Tanja's questions? Would be very helpful for addressing this.

can you maybe describe in more detail in what kind of situations the SpacyEntityExtractor does not work and maybe give a minimal example to reproduce the error? T

@koaning Could you please elaborate on Tanja's questions? Would be very helpful for addressing this.

I tried again and I could not reproduce anymore. So I'm closing this issue.


separate CPP

We had to xfail some test cases like the undef one when transitioning back to a libclang-based parser. Libclang does not seem to give much information about macros, even when CXTranslationUnit_DetailedPreprocessingRecord is used. We should be able to work around this with our own very unsophisticated C preprocessor front end.

Noting some further things that don't work as a fix to the macro-parent.c test case:

the immediate parent of a CXCursor_MacroExpansion is the translation unit itself
the semantic parent is invalid
the lexical parent is invalid

What does seem to be feasible is retrieving the range of a FunctionDecl which appears to cover the entire extent of a function, and then inferring that a macro expansion within that range has a parent of the function itself. This is tricky because (1) these two pieces of information are discovered in different phases and (2) the macro expansion is discovered before its parent. But I think this is doable.

As of 512f59198bf6d0960115d1b82997a16baf628588, this is done.


Set compile test iOS app target version to not embed Swift runtime

ObjC->Swift plugin migration caused a size regression in the gallery app because the Swift runtime was also pulled in.
The gallery app minimum target version is iOS 11.0, which predates Swift ABI compatibility.  Pre iOS 12.2 apps embedded the Swift runtime since there wasn't one available to use in the OS.
Add  FLUTTER_XCODE_IPHONEOS_DEPLOYMENT_TARGET to the compile perf test environment, which gets translated by the tool to an Xcode build setting:
[2023-12-14 15:52:14.797318] [STDOUT] stdout:                IPHONEOS_DEPLOYMENT_TARGET = 12.2

On my machine on main
    "release_size_bytes": 43717389,

becomes
    "release_size_bytes": 40679432,

Fixes https://github.com/flutter/flutter/issues/139605
Pre-launch Checklist

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] I read the Tree Hygiene wiki page, which explains my responsibilities.
[x] I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
[x] I signed the CLA.
[x] I listed at least one issue that this PR fixes in the description above.
[x] I updated/added relevant documentation (doc comments with ///).
[x] I added new tests to check the change I am making, or this PR is test-exempt.
[x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8761688887906641473/+/u/run_flutter_gallery_ios__compile/test_stdout
     "release_size_bytes": 40667077,


Version 0.16.1 fails

Describe the bug
Hello contributors, I have an electron app with TypeScript. I've updated the package to the 0.16.1 and have the following error during my dev run. With 0.16.0 it starts without error.
Logs

To Reproduce (if possible)
Steps to reproduce the behavior:

Install the new package
Run the app

Thanks a lot for your work and for further replies ;)

This is because we are now an es6 module, You can read more about it here: https://github.com/onsip/SIP.js/blob/master/docs/compatibility.md
The short of it is, if your build target is es5, you need to use babel, or babel-loader in webpack, to make this and other es modules work. If you do not know why you are targeting es5, you should update that to at least es6.
I'm going to leave this open to make sure the suggested change or workaround will work, as we anticipated people have this issue, but expect the above to work.

@james-criscuolo  Thanks for your reply. But I actually use babel-loader with '@babel/preset-env' and '@babel/preset-typescript'. But it doesn't work.
rules: [
        {
          test: /\.jsx?$/,
          exclude: /node_modules/,
          use: {
            loader: 'babel-loader',
            options: {
              cacheDirectory: true,
            },
          },
        },
        {
          test: /\.tsx?$/,
          exclude: /node_modules/,
          use: {
            loader: 'babel-loader',
            options: {
              cacheDirectory: true,
            },
          },
        },
      ]

You are excluding all node_modules, you probably want a line added like
		  include: /node_modules\/sip\.js/,

Sorry, other thing i noticed, module should not be CommonJs. Switching that to ESNext should fix, instead of messing with babel-loader". I'm sure there are other values for modulethat would work, I just knowesNext` will.

Going to close as I anticipate one of the above solutions fixed this.


fix(executor): Replace default retry in executor with an increased value retryer

Replace default retry in executor with an increased value retryer.
https://github.com/argoproj/argo/pull/3675 added a pod watch retry to handle timeout.
We need to increase this retry value to several other places. e.g. the wait container could timeout requests to etcd during wait.
We are experimenting the following error with argo-workflow 2.10.0.
time="2020-08-28T16:02:23.208Z" level=info msg="Waiting on main container"
time="2020-08-28T16:02:23.702Z" level=info msg="main container started with container ID: 17ec51e28b2a528c7c5238b5858e3d3a19c8c2f599f6c4950690da0f5a5c641a"
time="2020-08-28T16:02:23.702Z" level=info msg="Starting annotations monitor"
time="2020-08-28T16:02:23.709Z" level=info msg="Waiting for container 17ec51e28b2a528c7c5238b5858e3d3a19c8c2f599f6c4950690da0f5a5c641a to complete"
time="2020-08-28T16:02:23.709Z" level=info msg="Starting to wait completion of containerID 17ec51e28b2a528c7c5238b5858e3d3a19c8c2f599f6c4950690da0f5a5c641a ..."
time="2020-08-28T16:02:23.709Z" level=info msg="Starting deadline monitor"
time="2020-08-28T16:07:23.208Z" level=info msg="Alloc=7343 TotalAlloc=42779 Sys=72128 NumGC=11 Goroutines=10"
time="2020-08-28T16:08:05.884Z" level=warning msg="Failed to wait for container id '17ec51e28b2a528c7c5238b5858e3d3a19c8c2f599f6c4950690da0f5a5c641a': etcdserver: request timed out"
time="2020-08-28T16:08:05.884Z" level=error msg="executor error: etcdserver: request timed out"
time="2020-08-28T16:08:05.884Z" level=info msg="No Script output reference in workflow. Capturing script output ignored"
time="2020-08-28T16:08:05.884Z" level=info msg="Capturing script exit code"
time="2020-08-28T16:08:05.884Z" level=info msg="Getting exit code of 17ec51e28b2a528c7c5238b5858e3d3a19c8c2f599f6c4950690da0f5a5c641a"
time="2020-08-28T16:08:05.884Z" level=info msg="Annotations monitor stopped"
time="2020-08-28T16:08:05.907Z" level=info msg="No output parameters"
time="2020-08-28T16:08:05.907Z" level=info msg="No output artifacts"
time="2020-08-28T16:08:05.907Z" level=info msg="Killing sidecars"
time="2020-08-28T16:08:05.911Z" level=info msg="Alloc=6540 TotalAlloc=46240 Sys=72128 NumGC=12 Goroutines=9"
time="2020-08-28T16:08:05.954Z" level=fatal msg="etcdserver: request timed out"

Checklist:

[ ] Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
[ ] The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
[ ] I've signed the CLA.
[ ] I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
[ ] My builds are green. Try syncing with master if they are not.
[ ] My organization is added to USERS.md.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Ang Gao seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


Add concurrent.futures.Executor implementation

This adds most of a concurrent.futures.Executor implementation for Charm4py so Charm4py can be dropped in wherever ThreadPoolExecutor, ProcessPoolExecutor, MPI4pyPoolExecutor, etc. is used.
A PoolExecutor class in pool.py implements the Executor API by calling to equivalent Pool methods. This pull request also makes charm4py.threads.Future inherit from concurrent.futures.Future and implements its API.
Functionality not currently implemented

Executor.add_done_callback

TODO:

[ ] Update dependencies
[ ] Update documentation
[ ] Add tests

Hi Nick,
This is some really cool work! I can help out later this week or early next week to help with testing and documentation.

Cool, that would be great! It could definitely use another pair of eyes.


Installation issue feedback

Describe the bug
Two main points:

https://www.cogentcore.org/core/setup/install
The <code> </code> blocks are not directly highlight-able (with brave browser on amd64 linux) which makes it basically impossible to copy only the installation command itself for cogentcore.
The only easy way to do it to highlight the whole line and do ctrl + C ; paste into an editor, and then copy the command to the terminal. Or manually type the whole thing.
it would be preferable if the installation command (or generally code blocks) had the behavior of single click copy
Additionally, the setup documentation assumes that you have GOPATH set correctly and that your GOBIN was already added to your PATH ; but this should be made explicit and not just assumed as it might confuse people.

core setup may be easy enough to remember or run, but it actually did not work for me on archlinux with my specific hardware, to install all the correct dependencies (#1223).
I recommend that the cogentcore/core runtime dependencies (installed by core setup) be listed somewhere in the installation documentation - even if this information is not useful to most people.
If cogentcore was packaged and installed as a package by the package manager on linux, installing it's runtime dependencies should be handled by the package manager. And it's deps should be installed as dependencies of cogentcore and not explicitly.
However, I assume the exact dependencies vary based on the hardware & os ; and core setup is supposed to detect this. That might be challenging to handle by the package manager automatically. It might work best with different flavors (so to speak) of the package which are intended for specific hardware and which include the specific runtime deps used by cogentcore for that hardware.
Still, i suggest informing the user of the dependencies for different hardware and operating systems, even if this is on a different page of documentation from the setup installation page.
How to reproduce

attempt to copy the installation command from here
https://www.cogentcore.org/core/setup/install

N/A

Example code
No response
Relevant output
No response
Platform
Web

Thank you for the feedback. We are aware of both of those issues and are working on fixing them. The first issue will be resolved by #1051, and we may restructure the install documentation in the meantime such that it is easier to copy. For the second point, I am currently working on #1292 to fix that after receiving similar feedback in #1275 and #1260. I will also add documentation regarding Vulkan on other distros such as Arch Linux as part of that.

Is it possible to statically compile core itself? If I'm not mistaken it uses CGO, so it should actually make it more distribute-able if i'm not mistaken.
Is it possible to create statically compiled (with musl) apps built with core? Non web-apps of course.

Are you asking about using Cogent Core as a static library / building static libraries with core? That might be theoretically possible, but I'm not sure that it would make sense relative to direct linking using Go. We are planning to improve cross-compiling support soon, but if there is any other reason using Cogent Core as a static library would be helpful, I can consider it.

Are you asking about using Cogent Core as a static library / building static libraries with core? That might be theoretically possible, but I'm not sure that it would make sense relative to direct linking using Go. We are planning to improve cross-compiling support soon, but if there is any other reason using Cogent Core as a static library would be helpful, I can consider it.

I'm talking about compiling core on one machine, and using it on a different machine.
If, for instance, core is compiled on arch linux, the gcc runtime dependency is likely to be an incompatible version when run on debian-based distros.
However, after becoming more familiar with the runtime dependency situation, it's clear that gcc runtime dep is not the only issue with doing this, because there are additional runtime dependencies for core which differ based on hardware.
I'm not sure how this is handled internally. However, as a thought experiment, suppose that core was statically compiled with musl, on one linux machine, and then the compiled binary was moved to a different machine. And suppose the first machine had an amd gpu and the second machine had NVIDIA or otherwise different hardware, or even just a built in graphics processor.
Would the (static) compilation of the core binary on the one machine work when the binary is copied to the other machine - assuming the appropriate additional deps were installed, or is the compilation (of core itself) basically specific to the (graphics) hardware of the machine on which it was compiled?
If it would work, then I think it should be possible to have a binary release of this software ; and even if you didn't want to have a binary release of core (because of the rapid pace of development or to avoid supplying an outdated binary which might cause users to report issues that have already been solved)  it would still be possible to have it packaged for different distros.
I say possible but it would likely still present a challenge in terms of the runtime deps differing based on the hardware. I'm very familiar with linux packaging, and there are two possible methods for handling this, using either:

optional dependencies
hardware-specific packages

...
For instance on archlinux - it's possible to statically compile a golang program with musl if you install the musl and kernel-headers-musl packages and then use CC=musl-gcc or export CC=musl-gcc with the go build (or go install) command.
This is typically done either as a consideration for making a binary executable more distributable or because of security concerns about the potential for arbitrary code execution ; i.e. if the host system where the binary runs might have compromised libraries.
...
In terms of statically compiling applications with core basically core build would need to observe the CC env.
And sortof on that note, how might it be possible (or is it possible) to set Ldflags when doing core build ? For setting variables at compile time or to set -s -w ldflags ; things like that

Please correct me if I am misunderstanding which core you are referring to in different contexts. The core command line tool ("core tool") itself does not use CGO and thus can be cross-compiled for any platform in the standard Go way using GOOS and GOARCH. The dependencies that core setup installs are necessary for building Cogent Core apps for native platforms, but they are not in any way attached to the core tool binary itself. Apps built with Cogent Core rely on CGO (except on web), but the core tool itself is mainly just a wrapper around other command-line tools (which is why go build also works fine for building apps on desktop; the core tool does a lot more for mobile and web platforms, so you need it there, but there are still no CGO dependencies).
I believe that the dependencies that core setup installs are largely compile-time dependencies, although some of the Vulkan drivers may be needed at runtime (for actual Cogent Core apps, not for the core tool itself).
I do not have much knowledge of the specifics of dependencies in Linux packaging, but it seems like it might be possible to have a package that contains binary versions of the core tool for each architecture (cross-compiled using the Go tool) and a list of platform-specific dependencies to be installed by the package manager for each distro and hardware combination.
I am currently in the middle of a major restructuring of the documentation (#1321), in which I am updating the installation documentation based on your feedback. As such, there will be an easily accessible list of the requisite dependencies for building Cogent Core apps, which could be used for making a Linux package. I am not necessarily interested in doing so right now given ongoing development as you mentioned, but the core tool should be relatively stable within a few months, so it is definitely a future possibility.
For cross-compiling actual Cogent Core apps, we are planning to implement that at some point relatively soon (#1107), likely once we have finished some other major features.
The core tool currently sets the linker flags automatically (it does -s -w by default), but we can certainly add an option to add additional custom linker flags.
I will add all of that information to the documentation as well. Please let me know if you have any further questions.

Okay, once I finish updating the documentation in #1321, you can make an arch linux and/or debian package for the core tool. After #1321, there shouldn't be any major changes to the core tool soon, so it should be good from a versioning perspective. Please let me know if there are any changes I need to make to the core tool for compatibility. Thank you for doing this and providing that helpful context!

I've just added the initial PKGBUILDs ; without the full list of optional dependencies for the moment. Will update when you have that after #1321.
so it should be possible to install like this
yay -S cogentcore

or, longhand
git clone https://aur.archlinux.org/cogentcore
cd cogentcore
makepkg -sif

the PKGBUILD can be viewed here
https://aur.archlinux.org/cgit/aur.git/tree/PKGBUILD?h=cogentcore
Note that because there is an expected naming convention for certain types of build, the above command will install the latest version for which a release source archive exists. To install @main as specified in the docs, there is an alternate build provided by the same repo which can be used as follows
yay --mflags " -p git.PKGBUILD " -S cogentcore

or, longhand
git clone https://aur.archlinux.org/cogentcore
cd cogentcore
makepkg -sifp git.PKGBUILD

the git.PKGBUILD can be viewed here https://aur.archlinux.org/cgit/aur.git/tree/git.PKGBUILD?h=cogentcore
it works for me. Will add builds for the debian packages in the future.
If you want me to add you as co-maintainer or anything in the future, I'm happy to do so.

Thank you for doing that! After I finish #1321 and you add the dependencies, I will add documentation for installing using yay to the website.
As the core tool gets increasingly stable in the future, the need for @main will become much smaller, so that is okay (certainly by the time we get to v1 we will move to @latest). As long as the manually specified version in the PKGBUILD stays relatively up-to-date, we should be good.

in the future, the need for @main will become much smaller, so that is okay (certainly by the time we get to v1 we will move to @latest). As long as the manually specified version in the PKGBUILD stays relatively up-to-date, we should be good.

Yes that sounds good, and I'm glad to contribute to this project, at least in a small way, by maintaining this.
There was already another package in the AUR called core so that's why I added this package as cogentcore
I think, for the sake of simplicity for users, it might be optimal to change this to a split package and define the specific dependencies for each one.
read more about split packages
Then all the user would need to do is to install the correct package for their hardware, and the dependencies would be installed in the same step instead of the user needing to manually install those runtime deps after the fact (or use core setup)
I'd ask for your input on the naming convention on what to call the variants of the packages which differ by dependencies only. It should perhaps be something like cogentcore-nvidia ; cogentcore-amd ; cogentcore-intel ; but again I'd like your input on this as I don't have a clear view of just how many dependency variations there are or how exactly to refer to the different hardware being targeted.
And I've never tried a split package build for .deb packages. It should work the same.

Thank you for the suggestion. Based on my preliminary research, it seems like the GPU-specific drivers are typically automatically installed by other driver management software (especially for NVIDIA) and thus do not need to be installed manually, but that may not always be the case. In particular, arch may be less automatic for that, although I would think that anyone with a discrete GPU has probably already configured it.
We will add vulkan-swrast to the dependencies regardless since it is useful on any device, which should guarantee at least basic functionality independent of other factors. I am not sure whether the split package would be worth it, but I don't necessarily have enough knowledge of arch GPU usage distributions to make a conclusive decision. The question is whether optional dependencies and clear documentation would be sufficient for the likely small proportion of users that have a discrete GPU but don't have the drivers already installed. If most people don't need it, split packages might add unnecessary confusion, but if most people do need it, it would probably be worth it.
Any insights you have on how to proceed would be appreciated. Regardless, you are correct that nvidia, amd, and intel are the relevant categories, and so any split package setup would have those three options, or if we go with optional dependencies, there would be one for each of those three. If you think split packages make sense, there should definitely still be a base cogentcore without any GPU additions other than vulkan-swrast, as many people will still only need that pathway.
Also, I would appreciate it if you could add me as a co-maintainer. I recently got Linux VMs working well on my computer through UTM as part of #1341, so I can now easily test on arch without having to switch between computers. Thank you again for creating and maintaining this!

If there are any hardware specific runtime deps, regardless of if they are already installed or not, they should be listed as optional deps. It makes somewhat more sense to do split packages for archlinux since the AUR makes it so that built packages only exist on the system where they are built. If you have a repo with packages (debian or arch) it would be better to have just one package, for maintenance overhead of the package repo itself ; but I'd further argue that having just one basic formula for the build would be the easiest to maintain.
Having split packages should be easier for users, because the user would just need to run one command to install cogentcore, and then everything would be working right - assuming that the user selected the right package. But regardless of that, even if they installed the wrong one, it should be possible to get a working installation, provided the right runtime deps existed. So I'm in favor of the latter even if it entails some redundancy in built packages for a potential future package repo.
You'll need to make an account for the AUR. And their captcha system may force you to actually be using archlinux to make an account there. plus you need makepkg to maintain packages anyways. I'll go ahead and add you as a co-maintainer there as soon as you have an account and post here your username.
FYI I use / recommend endeavourOS - which is an arch-based distro, very close to vanilla archlinux.
on using glxinfo - basically the limitation is that the runtime deps of the package need to be listed, and they'll be installed automatically if they are listed in the PKGBUILD. If they are optional deps they don't get installed automatically.
It may be possible to simply install all the runtime deps available, for every different hardware. But I'm not sure if that would cause errors for cogentcore/core if there are drivers for hardware that doesn't exist, or how it sorts out that situation. What happens if you have drivers installed for hardware that doesn't exist ; in terms of how cogentcore behaves? How does core determine what driver to use?
The overall goal here is just to simplify installation and setup to a single command, if possible. And that would basically replace the use of core setup.
But from what you said - i tend to agree. If there are any drivers needed, they are likely already installed. So perhaps what we should do is only list vulkan-swrast as the runtime dependency, and assume that any other drivers are already there, but list those as optional dependencies. However, I think you'd need another vulkan package like vulkan-intel or some other flavor for this to work on the appropriate hardware - but this should be tested.
A note on the maintenance of AUR packages. I've grown fond of aurpublish which basically allows for multiple packages to be managed as submodules of a git repo. That makes it easy to track changes, etc. It's only slightly overkill if you maintain just one package, but hopefully this project aspires to produce more than just one software package.
So you could, if desired, make a git repo under cogentcore and maintain the package(s) there. Depends on your reasons, but I think it's convenient for tracking potential packaging issues, etc.
Here is an example of such a repo where I maintain AUR packages for skycoin
On a tangentially related note, in the new year I'll be recommending cogentcore/core for certain UI re-designs of skycoin software.

Thank you for your response. I plan to focus on #1321 for about a week, and then I will turn to getting this all figured out.

I tested with a machine that I think uses builtin intel graphics. vulkan-intel did not make a difference. When I uninstalled vulkan-swrast, core applications wouldn't run, even with vulkan-intel installed.

Thank you for that information. I think that affirms that we can just install vulkan-swrast and provide platform-specific packages as optional additions. I have been somewhat busy recently, but I am still planning to finish #1321 soon, at which point I will write a more detailed response here. Thank you for your patience.


Issue images are not loaded when scroll using jquery

Hello,, at the top of my page I have an anchor tag, when I click on it i run this function:
  $("body").animate({scrollTop: $('#picks').offset().top}, "slow");
picks is a div with ng-lazy-image repeater. when I reach there at the bottom of the page by default I cannot see the images,, I have to scroll manually,, just a tiny scroll.then the images are loaded.
It is a common issue  with lazy images.. a lot of solution I got,, like window.resize, which didn't work, and  I give images width and height, which I cannot in my case because image size has to be fluid..
any idea?

after the animation (which is available in jquery) sent the event the afkl image is listening(see docs or code for that event) on and apply it!
M

Op 2 mrt. 2016 om 07:50 heeft bdairy<EMAIL_ADDRESS>het volgende geschreven:
Hello,, at the top of my page I have an anchor tag, when I click on it i run this function:
$("body").animate({scrollTop: $('#picks').offset().top}, "slow");
picks is a div with ng-lazy-image repeater. when I reach there at the bottom of the page by default I cannot see the images,, I have to scroll manually,, just a tiny scroll.then the images are loaded.
It is a common issue with lazy images.. a lot of solution I got,, like window.resize, which didn't work, and I give images width and height, which I cannot in my case because image size has to be fluid..
any idea?
—
Reply to this email directly or view it on GitHub.

Thanks man for your fast reply,, as per your code your listening to two events
 angular.element($window).on('resize', _onResize);
 angular.element($window).on('scroll', _onViewChangeDebounced);

and after the animation I am calling these functions :
$window.trigger('scroll');
 $window.trigger('resize');

but still nothing happens..  I wonder if it worth to know but I've added a custom directive that observes the attribute of afklLazyImageLoaded to handle error images .
THis is a plnkr to demonstrate the issue
http://plnkr.co/edit/b9P16jKVdWZXN048J8wy?p=preview

Nope, try to send the event on your scope. Also maybe better to use angular scroll directive instead of jQuery. You can trigger lazy image with:
`angular.module('sample-app', ['afkl.lazyImage'])
So in your example it looks like this:
.controller('appCtrl', ['$scope', '$rootScope', function mainCtrl($scope, $rootScope) {
var getColor = function() {
var color = Math.floor(Math.random()*16777215).toString(16);
return color;
};
var getImage = function(){
var color = getColor();
return  '//placehold.it/100x100/' + color +'/ffffff 480w, //placehold.it/150x150/'+ color +'/ffffff 768w';
}
$scope.images = [];
for(var i=0;i<4;i++){
$scope.images.push(getImage());
}
$scope.go = function() {
console.log('ho');
$("body").animate({scrollTop: $('#picks').offset().top}, "slow", function() {
// Animation complete.
$rootScope.$broadcast('afkl.lazyImage.destroyed');
});
}
}])`
This is mostly needed when you do stuff out of Angular scope. So then you dont need to trigger scroll yourself!

Again thanks for your reply.. though it didn't work,, I've updated my plnkr ,, kindly check it out here

Can you just please use the code i gave? You broadcast before the JQUERY animate is done!

my bad man, you are a great man with a wonderful directive.. I LOVE IT

Thanks, so i will close this one :)


[models] Complete the list of pretrained available models in TensorFlow and PyTorch

🚀 The feature
Ensure that each model has a pretrained available checkpoint
TensorFlow:
classification:

[ ] MAGC
[ ] MobileNetV3  (will be updated)

detection:

[ ] DB_MobileNetV3 (after update)
[ ] LinkNet (all)

recognition:

[ ] CRNN (with mobilenet as bb after update)
[ ] SAR
[ ] MASTER

PyTorch:
classification:

[ ] ResNet34_wide

detection:

[ ] DB_ResNet34
[ ] LinkNet (all)

recognition:

[ ] SAR
[ ] MASTER

Motivation, pitch

Users wants to test each available model and needs the pretrained versions to finetune on there own data

Alternatives
No response
Additional context
No response

@charlesmindee i think you are the only one who can do it (data)

@charlesmindee, what kind of data do you use to train your text recogntions models ?
Do you use custom data ? and do you use special data for french documents ?

@nikokks for text recognition, we use cropped words from various types of documents, which sum up to about 11M images.
The bias is indeed around the choice of characters (European mostly) and the language (some sequences of characters are more frequent than others).
However, a while back, we started a fully synthetic approach (cf. CharacterGenerator and WordGenerator). So far, the results are not on par, but still very decent for a fully synthetic approach :)

Training started on Linked_Resnet50 (Tensorflow), we'll post the results soon :wink:

Closing because we track it in #1364


libcriterion: Make a separate library for Criteria

Criteria interface has been enough reworked to introduce a separated
library. This library exposes a client interface to let the client dealt
with criteria and larger interface through Criteria class which allows
the parameter-framework to handle criteria.
Signed-off-by: Jules Clero<EMAIL_ADDRESS>

Coverage remained the same at 69.94% when pulling 990741b5bd240b4073a01ba58f6e2a4595101d2a on dawagner:criterion-rework-step-3 into 855a02fe777cc0c2f948e146d718928f45c1ee8f on 01org:next.


When 'Voice Target' is 'Source Text' it should auto-detect the language and use a voice of that language

Don't know if this is possible, but it would be very welcome if the voice could speak in a language of the auto-detected text. So when I select a Spanish text (which is foreign to me), I can listen to how to pronounce that text. Same for Italian, German, etc. It adds no value to me when I select Spanish text and the app tries to pronounce it in English.

Is it possible to know why this issue has been closed though it doesn't seem working? It would be very useful if it would be working.

Is it possible to know why this issue has been closed though it doesn't seem working? It would be very useful if it would be working.

I closed it because it works for me. I select English text and press my voice activation key: it speaks English with a correct English voice. I select Spanish text and press my voice activation key: it speaks Spanish with a correct Spanish voice. Same with any other language I select text of.  That is what I asked for, so I'm happy.
I guess these are the settings that are most important for it:

Thank you, now it's clear and it works, I may have overlooked something.
Would it be good to add this in the how-to-use page,
or maybe set as default Voice Target=Translated Text ?


How to do async validation

Hi,
Currently, I'm struggling with async validation. I need to call a REST API to check something.
My test code is
public class PersonValidator : AbstractValidator<Person>
	{
		public PersonValidator()
		{
			RuleFor(x => x.Name).NotEmpty();
			RuleFor(x => x.Age).InclusiveBetween(18, 80).MustAsync(RunAsync);
		}
		private async Task<bool> RunAsync(int ssss, CancellationToken ct = default)
		{
			await Task.Delay(1000);
			return false;
		}
	}

Do you have some experience how to get it working?
Currently this just does nothing.

On a glance, that code should run just fine. (That validation logic would be run normally by FluentValidation. I do not tamper with the behavior of any / async validations whatsoever)
Try following these basic troubleshooting guide:

Have you added the validator to the DI?
Is the model used by EditForm component is a Person object too?
Have you put the FluentValidator component inside the EditForm component?
Are you sure that the method is really not running? Try attaching a breakpoint into the custom validation logic.

If all fails, send a zip with minimum repro and I’ll take a quick look at it.

The method is running, but no validation message appears.
Could you take a quick look into this?
I've taken the example from https://github.com/mrpmorris/blazor-university/tree/master/src/Forms/CustomValidation
CustomValidation.zip

That... does not look like my library at all.
Are you sure you are using my library? https://www.nuget.org/packages/Accelist.FluentValidation.Blazor

By the way, my library has a demo project which you can run here:
https://github.com/ryanelian/FluentValidation.Blazor/tree/master/Demo
Simply clone this repo https://github.com/ryanelian/FluentValidation.Blazor.git or download the zip: https://github.com/ryanelian/FluentValidation.Blazor/archive/master.zip
This demo project has a remote-simulated service:
    public class EmailCheckerService
    {
        public async Task<bool> IsAvailableAsync(string email)
        {
            // simulate delay accessing remote services
            await Task.Delay(1000);

            if (email ==<EMAIL_ADDRESS>            {
                return await Task.FromResult(false);
            }

            return await Task.FromResult(true);
        }
    }

and a validator which uses such service:
    public class FormModel2Validator : AbstractValidator<FormModel2>
    {
        private readonly EmailCheckerService EmailChecker;

        public FormModel2Validator(EmailCheckerService emailCheckerService, IValidator<FormModel3> subValidator)
        {
            this.EmailChecker = emailCheckerService;

            RuleFor(Q => Q.Email).Cascade(CascadeMode.StopOnFirstFailure)
                .NotEmpty().MinimumLength(4).MaximumLength(64).EmailAddress()
                .MustAsync(EmailAvailableAsync).WithMessage(o => $"Email {o.Email} is not available.");

            RuleFor(Q => Q.FormModel3).SetValidator(subValidator);
            RuleForEach(Q => Q.SubArray).SetValidator(subValidator);
        }

        public async Task<bool> EmailAvailableAsync(string email, System.Threading.CancellationToken cancellationToken)
        {
            return await EmailChecker.IsAvailableAsync(email);
        }
    }

which can be run:

I urge you to explore this demo project first.

https://github.com/mrpmorris/blazor-university/blob/master/src/Forms/CustomValidation/CustomValidation.csproj
The repo / project you gave me, it does not show
<PackageReference Include="Accelist.FluentValidation.Blazor" Version="2.1.0" />

in the csproj file: https://github.com/mrpmorris/blazor-university/blob/master/src/Forms/CustomValidation/CustomValidation.csproj

If you are depending on other FluentValidation libraries for Blazor, I suggest that you reach to the author of the said package.
Their package may have bugs / issues with async validation, which I'm not willing to debug.

Hi @ryanelian,
no need for frustration. I didn't say that it has something to do with your library.
I just found your library while searching for async validation in Blazor and I still wonder how you got it working. I will give it a try.
Thanks
Sven


Bette resizing algorithms

We want more control over how images get resized (because some browsers do it badly).
Let’s use this issue to collect some libraries that we can use:

https://github.com/PistonDevelopers/resize (Rust, Lanczos3 & Mitchell)

Closing in favor of #131


Direction of shadow in mesh not implemented

Hi Marco,
Looking into the code of the vedo.mesh class i found that it is possible to add shadows via add_shadows function (which is already very nice thing to have as one does not have to add a plane on which the shadow casts!).
I want to cast a shadow in a specific direction but i found from the code that this is not possible as one has to specify positional argument plane which results in that the else case cannot be reached (which would generate the projection).
Things which are not yet clear to me:  will the direction cast the shadow onto the plane with normal direction or will it cast the shadow with a different direction on the e.g. the 'z' plane (i would be interested in the latter).
Thanks a lot for the great work!
Paul

Try
from vedo import *

settings.use_depth_peeling = False # depending on your system

plt = Plotter(axes=8)

msh = Mesh(dataurl+"man.vtk").c("k5")

plane = Plane(pos=(0,0,-1.6), normal=(0,0,1), s=[7,7]).alpha(0.2)

shad = msh.clone().project_on_plane(plane, direction=(0.5,1,-1))
shad.c("k7").alpha(1).lighting("off").use_bounds(False)

plane.shift(0,0,0.001) # a small tolerance to avoid coplanarity with shad

plt.show(msh, plane, shad).close()

Awesome! Especially when using
plt.show(msh, shad).close() # don't plot the plane

Allows me to generate nice plots without having the issue that the plane is blocking the view from the underside of the mesh :) Maybe you can integrate sth like this into the example section!


fix api deps versions

plus some version bumping, and a version-management plugin

sorry, I'm a dummy, I hit the wrong button again 🤦♀


The docs didn't mention how to import the naive-ui components

Hi, should I import naive-ui component from itself or this nuxt module explicitly?
Which is correct?
import { NButton } from 'naive-ui'

or
import { NButton } from '@bg-dev/nuxt-naiveui'

Hi, components are auto-imported, it's Nuxt.


Hypothesis 3.64.0 is breaking tests

Starting to test this, it looks like this error first appears in 3.64.0
https://travis-ci.org/awslabs/aws-dynamodb-encryption-python/builds/397189674

Per guidance from hypothesis, it looks like the root cause of this is that we add a "hypothesis" pytest marker to tests that use hypothesis, but hypothesis already adds this marker (currently undocumented). Hypothesis is following up with pytest about the issue with the same marker being applied multiple times, but our action here is just to remove our explicit "hypothesis" markers.


Not Authorized to access createUser on type User

I init an existing project that I made 6 month ago using amplify init --app <github url>. I pulled that project using amplify pull.
Then I executed GraphQL mutation that creates User after authenticated from Cognito user pool.
I received an Error says {"data": null, "errorInfo": null, "errorType": "Unauthorized", "locations": [Array], "message": "Not Authorized to access createUser on type User", "path": [Array]}.
I attached a policy that allows every actions on every resources on DynamoDB to Cognito authRole, and I also attached AWSAppSyncInvokeFullAccess policy, but still getting this message. I can't figure it out why I am getting this Error.This thing worked 6month ago without configuring policies on authRole when I use amplify add api and amplify add auth.
Which Category is your question related to?
Amplify cli
Cognito
API
Amplify CLI Version
4.39.0
You can use amplify -v to check the amplify cli version on your system
What AWS Services are you utilizing?
AppSync
Cognito
Provide additional details e.g. code snippets
type User
  @model
  @auth(rules: [{ allow: owner, ownerField: "id", queries: null }]) {
  id: ID!
  sex: String
  avatar: S3Object
  username : String
  conversations: [ConvoLink] @connection(name: "UserLinks")
  messages: [Message] @connection(name: "UserMessages")
}

This is the function that I call to execute the mutation.
async createUser() {
    try {
      await API.graphql(graphqlOperation(createUser, { username: "Guest" }))
    } catch (err) {
      console.log('Error creating user! :', err)
    }
  }
}

I read this https://github.com/aws-amplify/amplify-cli/issues/3064
and added   @aws_cognito_user_pools in my schema.
still get same Error.

Changing @auth(rules: [{ allow: owner, ownerField: "id", queries: null }]) to @auth(rules: [{ allow: owner, queries: null }]) worked for me.

Hi, can you please help me out with same..? I want to store cognito user to type User also. How did you call the mutation function? did you call it in lambda function or  just in your app(JS file.. maybe) ?

Hi, can you please help me out with same..? I want to store cognito user to type User also. How did you call the mutation function? did you call it in lambda function or  just in your app(JS file.. maybe) ?


Cannot see more than 64 copies of Ribbon example particle effect

Crate versions
bevy version: 0.13.2
bevy_hanabi version: 2da6d8d
Describe the bug
Spawning 100 copies of the particle effect bundle from the Ribbons example leads to only 64 being visible
Expected behavior
100 instances of the particle effect are visible
To Reproduce
https://github.com/jakkos-net/bevy_hanabi_64_issue
Screenshots

@jakkos-net the latest change #328 fixes it for me. Let me know and feel free to reopen if there's still any issue. Thanks!


Option flow cleanup

Would be nice to split up the option flow in multiple steps, possibly with a menu.
It's kinda cluttered now.

Done with #2413


[VS Code] Starting collaboration session: Unable to connect to the remote server.

<!--
For Visual Studio problems/feedback, please use the Report

TrackingId:99e7712f-ca3c-4e97-b8f1-84418349a073, Address:sb://vsls-prod-ins-euw-private-relay.servicebus.windows.net/79ef1049e810606d1746252663f8e015284c--416a8f00-22d5-4c62-a5cf-710b104262dd, Timestamp:12-Dec-18 10:01:08

TrackingId:99e7712f-ca3c-4e97-b8f1-84418349a073, Address:sb://vsls-prod-ins-euw-private-relay.servicebus.windows.net/79ef1049e810606d1746252663f8e015284c--416a8f00-22d5-4c62-a5cf-710b104262dd, Timestamp:12-Dec-18 10:01:08

Hey @ValdamireGido, thanks for reporting this. Could you attach logs for investigation? In VSCode, you can type Live Share: Export Logs which should give you logs zip archive. Thanks!

cc @Priya91

dupe #504


API Change after hotshot-primitives moved into hotshot

As Alex has helpfully explained everything that hotshot needs from hotshot-primitives has already been ported to hotshot in packages types, crates/hotshot-qc, and crates/hotshot-stake-table.
Currently the only use of hotshot-primitives is in the types package. (Yay!) However, both hotshot-qc and hotshot-stake-table depend on types. So switching from hotshot-primitives to these new packages creates a circular dependency.
I propose to eliminate this circular dependency by moving everything we need from hotshot-qc and hotshot-stake-table into types. (Presumably, anything that remains can simply be deleted?)
An alternative is to instead move the offending code out of types.  The offending code is in a single file: bn254_pub.rs. Is this something that should live in the types package? If not then where's the best place to put it?

On further discussion we decided to leave trait SignatureKey in hotshot-types and move all impls (ie. bn254) to a new crate under crates/hotshot-signature-key.


Test case description is removed upon test case display name change

Affected module
Impact UI
Describe the bug
When I change the test case display name, its test case description are removed automatically.
Illustration as below:

Expected behavior
Test case description should remain the same even when changing the display name.
Version:

OS: Ubuntu 22.04.3
Python version: 3.10.12
OpenMetadata version: <IP_ADDRESS>
OpenMetadata Ingestion package version: <IP_ADDRESS>

Fixed with https://github.com/open-metadata/OpenMetadata/pull/15867


Not able to send messages to everyone

Hello,
the communicator works fine to send messages to groups...
but when I try to send to all company I recieve this message

the first 2 options work fine...but the  third one (the one we want to use...) is not the working...we need this to send message to +45000 employees :)

Someone could help me?

Hi @cathprado10 ,
Thanks fir raising the query. Could you please respond to the below queries.

What is the version of the app?
Please share the application insights logs. Go to resource group-->Application Insights-->Under investigate click Failures. Share the logs. Here is the reference

Hello,

Logs:

Hi @cathprado10 ,
Please try sending a message using 3rd sending option after performing the below procedure.
- Navigate to Azure portal and open company communicator deployed resource group.

- Click on “Storage account”.

- Expand “Tables” section.

- Open “AppConfig” table.

- Delete the second record where Rowkey is entered as “UserAppId”.

Hello...
There's no "UserAppID" row...
here's the screenshot:

Hi @cathprado10 ,
Could you please delete the author app, user app from teams and re-upload them again via teams admin center. Then try sending the message using 3rd sending option

Didn't work...same error
and now i'm not able to send messages to individual in a group (the second option)
is it possible to schedule a call for someone to help me with this deployment?

Hi @cathprado10 ,
Please share your mail id(outlook id or teams id) so that we can continue the conversation internally.

<EMAIL_ADDRESS>

Hi @cathprado10 ,
We can continue the conversation internally from now on


[Feature] Option to install CSI Proxy on Windows Node

Description:
Azure File CSI Driver cannot currently be installed on AKS-Edge because the Windows node does not have CSI-Proxy installed.
Describe the solution you'd like
Add a new option to the deployment configuration.
{
  "WindowsVM": {
    "csiProxyURL": "https://acs-mirror.azureedge.net/csi-proxy/v1.0.2/binaries/csi-proxy-v1.0.2.tar.gz",
    "enableCSIProxy": true
  }
}

Alternatives
There are currently no alternatives for mounting AzureFile into a container.

Hi @mbelt,
Thanks for reaching out. We'll consider this enhancement for future releases.   Can you install the CSI-Proxy to the Windows node? What's the error you're getting?
Thanks,
Francisco


feat(FX-3955): Change Primary CTA on 'sold' artworks pages to "create an alert"

This PR resolves FX-3955
Description

GIVEN I land on an artwork page on App
AND that artwork is sold
THEN I am able to create an alert for similar artworks
AND I will be notified when these artworks are available

Acceptance Criteria:

Utilise existing create alert behaviour on artwork pages
Make Create Alert the primary CTA with contact gallery as secondary

Demo

Link
FF Enabled
FF Disabled

Link

Link

iOS
https://user-images.githubusercontent.com/3513494/169104309-55ae6bfc-0db7-42a2-9188-5a09e5023d3c.mp4
Android
https://user-images.githubusercontent.com/3513494/169110733-b0f224ce-e8a6-4219-a70b-8cd2cefe2c19.mp4

PR Checklist

[ ] I tested my changes on iOS / Android.
[x] I added screenshots or videos to illustrate my changes.
[x] I added Tests and Stories for my changes.
[ ] I added an app state migration.
[x] I hid my changes behind a feature flag.

To the reviewers 👀

[x] I would like at least one of the reviewers to run this PR on the simulator or device.

Changelog updates
Changelog updates

Cross-platform user-facing changes

Change Primary CTA on 'sold' artworks pages to "create an alert" - dimatretyak

iOS user-facing changes

Android user-facing changes

Dev changes

Need help with something? Have a look at our docs, or get in touch with us.

Running smoothly on the emulator 🎉 happy to wait for more people to give feedback, but I leave it up to you to merge

Thank you George!


build: bump version to v0.1.0

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 87.36%. Comparing base (b59285d) to head (c5a4684).

:exclamation:  There is a different number of reports uploaded between BASE (b59285d) and HEAD (c5a4684). Click for more details.
HEAD has 5 uploads less than BASE

Flag
BASE (b59285d)
HEAD (c5a4684)

6
1

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #105      +/-   ##
==========================================
- Coverage   96.23%   87.36%   -8.87%
==========================================
  Files          15        4      -11
  Lines        1673      467    -1206
==========================================
- Hits         1610      408    -1202
+ Misses         48       44       -4
  Partials       15       15

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


networking: cleanup&optimize WifiManager

inherit from QObject instead of QWidget
Added function WifiManager::call to simplify the d-bus calls
async scan/refresh

~Next PR: I plan to use QDBusAbstractInterface::asyncCall in WifiManager::call to solve the blocking problem~ i'll do async scan/refresh in this pr
resolve: https://github.com/commaai/openpilot/issues/23445

My IP address is showing as <IP_ADDRESS> on wifi. Seems to work fine while tethering.

reverted to the previous code to get the ip address.it should be ok know

Now it's not showing any networks besides the connected one.

The scan will start after the net panel is displayed for 5 seconds. it still no refreshed after waiting 5-6 seconds?

Weird, I tried again (without 1a0b26c49de0ed1d29ce0dd763700b3695abeee9) and it works, but the scrolling is very laggy.

There are two possibilities to cause the laggy
1.isTetheringEnabled (it make call to d-bus) is called in a loop by UI to rebuild the list.
2.clear/rebuild widigets in scrollview may also cause laggy

Can we fix those cases too or do you want to do that in another PR?

I try to fix them together in this Pr

doun't know why failed to build docs

@adeebshihadeh  Why does the "build docs" fail?  Have I done something wrong?

Looks like this is the issue  https://github.com/michaeljones/breathe/issues/616

Let's make sure to not make the PR too big, so it's hard to review. Feel free to split this up if something's already done and self-contained.

closed.it's all split up