getting a gap on Beaver Builder theme and page builder!

I'm testing out crelly on a site using the beaver builder theme and it's page builder.
I'm testing a full width row and the content is set to full width.
All good except I am getting a top and bottom gap of 10 pixels.
Not sure why - the page builder row (based on bootstrap BTW) has all the padding and margins all zero'd out.
I've worked out that changing the following css fixes it, but using -ve values is not good!
.fl-node-576e0c025ee2b > .fl-module-content {
margin-top: -10px;
margin-bottom: -10px;
}
TIA

All sorted, not caused by crelly - I recreated the row and all good.
Dave

Hi sir
i have an issue in with crelly slider..
crelly slider is loading after the content.. so it looks odd
can you please help me on this...
where i tried with "Slider Revolution" it is loading before content
example : http://chaitanya.esy.es/revo-slider/
but "Crelly Slider" is loading after content
example : http://chaitanya.esy.es/crelly-slider/
note: the above site is in fee hosting.. so some time it is not loading.. please bare with me and please press refesh
regards
Chaitanya


Add support for AMP and zero amount invoices

Pull Request Checklist

[x] PR is opened against correct version branch.
[x] Version compatibility matrix in the README and minimal required version
in lnd_services.go are updated.
[x] Update macaroon_recipes.go if your PR adds a new method that is called
differently than the RPC method it invokes.

Hey! I am trying to use LndClient to do real-time payment streaming with a static AMP invoice. I ran into two issues using lndclient v0.16.0.

Support for AMP payments does not seem to be built out yet in the AddInvoice method. Notably, the IsAmp field is not properly set in the lnrpc.Invoice object.

Zero value invoices are not properly supported in the SendPayment method. Currently, a Value is only forwarded if the Invoice is not set. Ideally, we would forward the Value independently of whether the Invoice is set to enable zero-value invoices.

Hey. I agree with the IsAmp flag, that needs to be added to the AddInvoice call. Though I'm not sure about the Amt field. It might be confusing to always add the value, especially if it gets overwritten if an invoice is also passed in.
How about we add a new field to the SendPaymentRequest called AmpAmount that is only set if the invoice has a zero amount. Would that work for your use case?


Create function for determining where to place hashcat/where hashcat executable should be located

Will vary by operating system

Implemented for windows. Still need to do for mac and linux


Windows build: missing exports

I notice that several functions are missing from the generated libeay32.def:
OPENSSL_init_crypto
RSA_*:
RSA_generate_key_ex
RSA_new
RSA_free
PEM_write_bio_PKCS8PrivateKey
and others
Maybe this is also related to the no-deprecated issue:
https://github.com/openssl/openssl/issues/684

Yes, it was.
https://github.com/openssl/openssl/commit/c35f5c3d3a557288b6c7dcaa17dbbc5916e3e263 fixed this as well.


Allow fgh ls to use case-insensitive match

Description
If reasonable, it would be pretty nice for fgh ls to allow reporting paths for repos without requiring a case-sensitive match. Especially on case-insensitive filesystems such as are common on Windows, the casing for the path on disk may not match the casing found by OwnerAndNameFromRemote, such that fgh ls can fail even when the repo name provided matches the casing on disk.

This is totally something I can do! Expect a PR soon.

This is now available in v2.0.1. Thanks again for the suggestion!


[SPARK-28077][SQL][FOLLOW-UP] Add overlay and placing to TableIdentifierParserSuite

What changes were proposed in this pull request?
This pr add overlay and placing to TableIdentifierParserSuite.
How was this patch tested?
N/A

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/12231/
Test PASSed.

Test build #107038 has started for PR 25013 at commit a31522b.

Test build #107038 has finished for PR 25013 at commit a31522b.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/107038/
Test PASSed.


build --watch ?

I know that I can backpack dev but this also executes the bundled file. Is it possible to have backpack watch for changes and only build bundle without executing it?

I'm working on a CLI app that is npm linked and need to run my CLI in a separate directory.


Getting an exception with the read_from parameter

This is odd.  In my Symfony config.yml, I have the read_from and write_to parameters set to:
assetic:
    read_from:      "%kernel.root_dir%/../../www/www"
    write_to:       "%assetic.read_from%"

After updating with composer, I'm now getting the following exception when attempting to access Symfony's console:

[Symfony\Component\DependencyInjection\Exception\ParameterNotFoundException]
You have requested a non-existent parameter "assetic.read_from".

The error remains even if I manually erase the cache, but disappears if I comment out both my read_from and write_to parameters (the latter being necessary because it references the former).
Has read_from been removed from assetic?  The only packages that were updated when I ran composer update were:
twig/twig
doctrine/cache
sensio/generator-bundle
doctrine/dbal
friendsofsymfony/user-bundle dev-master
I wouldn't think that any of those would interfere with assetic.  Any ideas?

same problem

same problem, too


Created DF2 but no files are showing up after flashing

Hi Gagetoid,
followed the instructions and I was able to create the df2 file and flashed on the Pico W. (I know was flashed because the old files are gone). After restarting the Pico no new FS is present (unless I'm missing something)
Looking to the df2 file it seems that it contains the files (using Notepad just visually) - do I need to match it to the board somehow?
Thanks
Aurash

If it uses a too new version of the .uf2 library it might be creating an incompatible filesystem, I think MicroPython have bumped to 2.8.1 recently - https://github.com/micropython/micropython/commit/7ad84e0422a521fe97ce5d742df280c6b8a3ff87 - but prior MicroPython builds wont work with anything > 0.4.0 of littlefs-python.

You must get the filesystem location correct for your specific board, size matters less but if the header is in the wrong location MicroPython will just trash it on init.

Here's where I set the FS position for Badger 2040 - for example - https://github.com/pimoroni/badger2040/blob/9b6acf25c2e79f5821f38ae7dcf881d2433c86f6/.github/workflows/micropython.yml#L165
And here's where those numbers are defined - https://github.com/pimoroni/badger2040/blob/9b6acf25c2e79f5821f38ae7dcf881d2433c86f6/.github/workflows/micropython.yml#L64-L75
(I really want to make positioning the filesystem automagic, it should be possible to read the location out of the .uf2 as mentioned here https://github.com/Gadgetoid/dir2uf2/issues/3)

Oh and the PyPi project page mentions which Python package versions correspond to which LittleFS versions and which filesystem versions - https://pypi.org/project/littlefs-python/#description

Hi Philip,
I might be out of my depth here...(I'm a hardware engineer) here is my
context
The target board a Rpi Pico W (stock one) from Rpi foundation)
MicroPython v1.20.0-62-g4e4bdbd19 on 2023-05-10; Raspberry Pi Pico W with
RP2040
When I try to crate the new FS I'm using Python (in thonny) on a Win PC
Python 3.10.9 (C:\Program Files (x86)\Thonny\python.exe)
with littlefs-python 0.9.3
which I guess is too new for what I want to do is that correct?
how can I use an older version (Thonny has no mechanism to downgrade I
think) - should I download the old littlefs  0.4  manually and put that
version in my working directory? or this is a can of worms because there
might be other dependencies down the line?
look I don't want to waste your time here just trying to understand where
I'm getting into.
Cheers,
Aurelian
On Mon, Feb 12, 2024 at 9:44 AM Philip Howard @.***>
wrote:

Oh and the PyPi project page mentions which Python package versions
correspond to which LittleFS versions and which filesystem versions -
https://pypi.org/project/littlefs-python/#description
—
Reply to this email directly, view it on GitHub
https://github.com/Gadgetoid/dir2uf2/issues/5#issuecomment-1938331355,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BGCQYYSZ6VCXKCXLHEJYVKLYTHP6RAVCNFSM6AAAAABDDVCS2OVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMZYGMZTCMZVGU
.
You are receiving this because you authored the thread.Message ID:
@.***>

--
Aurelian Lazarut
Adaptive Design ltd.
Ireland

Hi Philip,
Actually you can downgrade to littlefs 4.0 from Thonny (I told you that I'm
not the sharpest tool in the shed)
I downgraded and created the FS and it works,
Happy Days
Thanks for the pointers
Aurelian
On Mon, Feb 12, 2024 at 9:44 AM Philip Howard @.***>
wrote:

Oh and the PyPi project page mentions which Python package versions
correspond to which LittleFS versions and which filesystem versions -
https://pypi.org/project/littlefs-python/#description
—
Reply to this email directly, view it on GitHub
https://github.com/Gadgetoid/dir2uf2/issues/5#issuecomment-1938331355,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BGCQYYSZ6VCXKCXLHEJYVKLYTHP6RAVCNFSM6AAAAABDDVCS2OVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMZYGMZTCMZVGU
.
You are receiving this because you authored the thread.Message ID:
@.***>

--
Aurelian Lazarut
Adaptive Design ltd.
Ireland

Woo, good stuff! Feel free to leave this issue open since I think the lack of documentation, warnings or otherwise about this still constitute a bug.
It's great to have someone else using this project and checking my assumptions- so no worries!


[Web] Try to upgrade WebGPU API usage to the latest

The WebGPU api calling in web runtime is pretty old, it only runs on old browsers like Chrome 83.
I have tried to upgrade these API calling to the latest, but not sure whether it is correct completely.
Jest testing is passed.
Changes:

Upgrade WebGPU API calling.
Update @webgpu/types to the latest version (0.1.24).
package-lock.json has been migrated to v2.

Notice: I didn't change the version of this package.

@tqchen Please take a look later, thanks very much

Thank you @LancerComet


Modified templater.set to allow for input lists.

I'm contributing back the changes I made based on the functionality I requested in #258.

Close ref: https://github.com/javve/list.js/issues/258#issuecomment-68600592


Question: which pull request body to edit when trying to fix merged PR?

I want to fix the merged PR's commits, but based on the doc: https://github.com/googleapis/release-please#how-can-i-fix-release-notes, I am still confusing about where should I edit the merged PR's body and input below contents:
BEGIN_COMMIT_OVERRIDE
feat: add ability to override merged commit message

fix: another message
chore: a third message
END_COMMIT_OVERRIDE

For example this is the merged PR I want to fix: https://github.com/linrongbin16/fzfx.nvim/pull/240
Is it just add 1 more comment in the end (see below screenshot) ?

I searched something relate to this:
https://stackoverflow.com/questions/7279196/git-how-to-edit-reword-a-merge-commits-message
So I need to use --rebase-merges option?


Maintaining simple-optimism-node to work with latest OP Node

As an OP Technerd I have faced many support tickets regarding snapshot downloading.
I propose a fix by using aria2c to download the snapshot

More work has been done in addition to above


Include hash of kernel id in kernel information

Codecov Report

Merging #11087 (0c185b8) into main (8b098c2) will decrease coverage by 0%.
The diff coverage is 100%.

@@          Coverage Diff           @@
##            main   #11087   +/-   ##
======================================
- Coverage     63%      63%   -1%
======================================
  Files        480      480
  Lines      33730    33731    +1
  Branches    5500     5500
======================================
- Hits       21333    21292   -41
- Misses     10374    10396   +22
- Partials    2023     2043   +20

Impacted Files
Coverage Δ

src/telemetry.ts
100% <ø> (ø)

src/kernels/telemetry/helper.ts
92% <100%> (+<1%)
:arrow_up:

src/platform/common/cancellation.ts
59% <0%> (-13%)
:arrow_down:

src/kernels/execution/notebookUpdater.ts
88% <0%> (-8%)
:arrow_down:

src/kernels/raw/session/rawJupyterSession.node.ts
81% <0%> (-3%)
:arrow_down:

src/kernels/errors/kernelErrorHandler.ts
63% <0%> (-3%)
:arrow_down:

src/kernels/jupyter/jupyterKernelService.node.ts
74% <0%> (-2%)
:arrow_down:

src/kernels/telemetry/sendKernelTelemetryEvent.ts
84% <0%> (-2%)
:arrow_down:

src/kernels/kernelDependencyService.node.ts
83% <0%> (-2%)
:arrow_down:

src/kernels/kernelFinder.base.ts
82% <0%> (-2%)
:arrow_down:

... and 8 more


Could not create SSL/TLS secure channel

Reinstall module from this is not allowing me to reinstall the LT agent
Error:
Could not create SSL/TLS secure channel
Function that I ran:
(new-object Net.WebClient).DownloadString('http://bit.ly/LTPoSh') | iex; Reinstall-LTService -Server xxxxxxxx == -LocationID xxxxx

Same issue, all commands.  Started recently.  TLS Issue?

Don't think so, as you can https into this link.
Anyone have a solution?

End up running the script locally, rather than the download string

Use:
[Net.ServicePointManager]::SecurityProtocol=[enum]::GetValues([Net.SecurityProtocolType])|Where-Object
{$_ -gt [Net.SecurityProtocolType]::Tls}; (new-object
Net.WebClient).DownloadString('http://bit.ly/LTPoSh') | iex;
Reinstall-LTService -Server xxxxxxxx == -LocationID xxxxx
On Wed, Apr 7, 2021 at 8:40 PM Ben LEung @.***> wrote:

Reinstall module from this is not allowing me to reinstall the LT agent
Error:
Could not create SSL/TLS secure channel
Function that I ran:
(new-object Net.WebClient).DownloadString('http://bit.ly/LTPoSh') | iex;
Reinstall-LTService -Server xxxxxxxx == -LocationID xxxxx
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/LabtechConsulting/LabTech-Powershell-Module/issues/60,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AC2YEDTC7EZ62W7TAEPXEV3THUQSXANCNFSM42SACF4A
.

GitHub is now requiring TLS1.2 for connections, and stock powershell may not have it enabled. You just need to enable TLS1.2 using the command above (Enables all TLS+ versions) or explicitly enable TLS1.2 before pulling from GitHub. (Or host a copy on a server that allows lower security connections).


Add Depth Anything V2 as a library

This PR adds Depth Anything V2 as a library.
Make sure the following PRs are merged:

[x] https://huggingface.co/depth-anything/Depth-Anything-V2-Small/discussions/3
[x] https://huggingface.co/depth-anything/Depth-Anything-V2-Base/discussions/1
[x] https://huggingface.co/depth-anything/Depth-Anything-V2-Large/discussions/2

@NielsRogge I think the force-push above removed the changes made from @osanseviero 's last suggestion :confused: (see force push diff)

Yes it was intentional, I initially applied the suggested changes which gave me an error in VSCode, due to the fact that a key could potentially be used that is not in the modelConfig dictionary. As the PR was approved already and Omar told me it's fine to go with the existing implementation I went with that


fix build.zig

I don't know which zig version is intended to be used here,
but if it is master then this PR adjusts to the new API of Compile.addCSourceFiles()

@ryupold Thanks for the review!


Find a tool to validate/verify kubeconfigs for duplicate use of an OIDC client-id

Find a tool to validate/verify kubeconfig. Especially duplicate use of an OIDC client-id.
Found kubeval on the net: https://github.com/instrumenta/kubeval

I wanted to give kubeval a try, but failed. Installed via homebrew. Then:
$ kubeval ~/.kube/config
ERR  - /Users/marian/.kube/config: Failed initializing schema https://kubernetesjsonschema.dev/master-standalone/config-v1.json: Could not read schema from HTTP, response status is 404 Not Found

The repo https://github.com/instrumenta/kubernetes-json-schema for the schema site kubernetesjsonschema.dev has been last updated in April 2020.
Looks not promising.

This one was listed in CNCF weekly news:
Frontend: https://validkube.com/?utm_source=hs_email&utm_medium=email
Source : https://github.com/komodorio/validkube

validkube relies on kubeval for kubeconfig validation. And that didn't work for me.


Show owner and group with permissions

Please describe the problem you're trying to solve
While yazi can perfectly show the permissions for files and directories, it doesn't (or I can't find) the owner and group, which often would be very helpful to understand the permissions.
Would you be willing to contribute this feature?

[ ] Yes, I'll give it a shot

Describe the solution you'd like
I can imagine several possible solutions:

Adding user and group to the permissions mode line (but that takes a lot of space)
A separate mode line for user and group
Trying to use color in the permissions to signify users (but how exactly?)
Showing user and group in the status line

Additional context
No response

Do these work for you?

https://yazi-rs.github.io/docs/tips#user-group-in-status
https://yazi-rs.github.io/docs/tips#username-hostname-in-header

I'll try that out! Thank you very much :)

Unfortunately, that snippet throws an error for me:
The application panicked (crashed).
  Lua runtime failed: RuntimeError("[string \"yazi-plugin/src/lua.rs:50:13\"]:5: attempt to call a nil value (method 'children_add')\nstack traceback:\n\t[C]: in method 'children_add'\n\t[string \"yazi-plugin/src/lua.rs:50:13\"]:5: in main chunk")

I made to sure to follow the instructions at https://yazi-rs.github.io/docs/tips/#user-group-in-status exactly. My yazi version is 0.2.5.

You need to upgrade your Yazi to the latest 0.3, https://github.com/sxyazi/yazi/releases/tag/v0.3.0

Thank you!


How to pass the rows index in template to the handlers function?

<template slot="table-row" scope="props">
   {{ props.row.CustomerID }}
   <button class="btn btn-danger" v-on:click="del(props.row.ID, $event, $index???)"></button>

</template>

in v1.7.1 you can access index via props.index

Thanks dude it just worked as expected!!!!

Did I miss this from the docs? I always read everything before asking questions over here. If isn't there please add it for future reference for other contributors/users.

@arivera12 actually I added it in v1.7.1 after seeing your question. So thank you for pointing it out. I will add it to the docs soon.


Test-ScriptFileInfo cannot complete if the script has parse errors

Steps to reproduce
Create script with scriptfileinfo.  Paste in DSC configuration that includes import-dscresources.  List modules that are not available.
test-scriptfileinfo .\dscscript.ps1

Expected behavior
Return the metadata about the script, most importantly the list of required modules so they can be loaded during test automation.
Actual behavior
Test-ScriptFileInfo : The specified script file 'path\dscscript.ps1' has parse errors, try
again after fixing the parse errors.

The command cannot reveal the list of required modules, so that test automation can know which modules to install.  Ideally, the scriptfileinfo could be read even if the script body contains parse errors, as an "off by default" option.
Environment data
Name                           Value
----                           -----
PSVersion                      6.0.0
PSEdition                      Core
GitCommitId                    v6.0.0
OS                             Microsoft Windows 10.0.17093
Platform                       Win32NT
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0...}
PSRemotingProtocolVersion      2.3
SerializationVersion           <IP_ADDRESS>
WSManStackVersion              3.0

@mgreenegit this cmdlet comes from PSGet, you should open an issue there.


Application testing problems with CMS_PERMISSIONS

The problem is with current_user (from cms.utils.permissions), which is set in CurrentUserMiddleware.process_request. During application testing, it may cause problems.
Imagine test run scenario:

First testcase creates user, logins with it, does some testing and logouts - this sets current_user to a new user but never clears it out - logout sets current_user to the same user, because request.user is still the same user.
Second testcase creates user, which in turn triggers cms.signals.permissions.post_save_user to add created_by=get_current_user() on user. At this moment, get_current_user() is the same user from the first test case, because it wasn't cleared. This causes integration error, because this user is not in database anymore - it was automatically removed after finishing testcase.

Of course it's possible to add set_current_user(None) to test tearDown (as cms tests does), but I don't think that we have to make people rewrite tests just for using CMS_PERMISSIONS.
Also, I think testing with CMS_PERMISSIONS = False is also not an option, since I'd like to test my application as close as possible to my production.

Have you tried UserLoginContext: https://github.com/divio/django-cms/blob/develop/cms/test_utils/util/context_managers.py#L81?

@yakky - as far as I can see, it doesn't clear current_user on exit - it just calls self.testcase.client.logout(), which is what I use in my tests as well. This logout method just sets current_user to the same user which was logged in, because set_current_user is called on process_request - and request.user is still there.
After calling this function, imagine creating user model in script without making any requests (but in a different test case) - this might cause database Integration Error.

I think it's worth adding user_logged_out signal handler, which in turn calls set_current_user(None) - what do you think? If the problem is not clear at all, I could try making a test case for the scenario described above :)

@donce if you use SimpleTestCase data are discarded after each test function, it shouldn't result in any permanent data to be saved

Testcases don't discard thread data - https://github.com/divio/django-cms/blob/develop/cms/utils/permissions.py#L23 , this is kept between different test functions.

I've opened a public discussion on the developer's list in order to come up with a solution that addresses the underlying problem (using current thread to store user).
https://groups.google.com/forum/#!topic/django-cms-developers/T9OtsDl8qcQ

Closing in favor of https://github.com/divio/django-cms/issues/5411.


RFC: Widget messages

RFC: Widget messages
The current user widgets system supports exactly one kind of user widget - a widget panel, that is a piece of UI which can appear as a top-level panel next to the tactic state, messages, etc, in the infoview. Since we already have all the infrastructure for dynamic code loading in the infoview set up, there is no reason to limit ourselves to panels. Here I would like to propose widget messages. Implementation-wise, these would need one new constructor of MessageData, MessageData.ofWidget (msg : WidgetMsg). I have not implemented this, but I am happy to do it if there is interest/approval. Widget messages are primarily motivated by the use-cases they would enable:
Example 1: "Try this"
We can write a generic "Try this" UI component resulting in tryThis : Syntax → Syntax → WidgetMsg where tryThis stxRef newStx is the data of a "Try this" display that replaces stxRef with newStx upon a click. We would then include it in messages output by tactic code using something like m!"<some tactic output>{.tryThis stxRef newStx}".
Example 2: Contextual traces in failure messages
It is currently not always easy to view extra detail associated with a failure message. For instance, suppose the system prints a failed to synthesize instance SomeClass α message. In cases where it is not obvious why the synthesis failed (e.g. when debugging typeclass hierarchies), we can debug it by setting trace.Meta.synthInstance true. However we must either do so on the entire enclosing command which produces lots of irrelevant output, or extract a self-contained trace.Meta.synthInstance true in #synth SomeClass α which may be non-trivial if α depends on local context. And in any case we have to type the option in every time! It would be convenient if the failure message directly included a [Trace] button below it which would show this output when clicked. This could be achieved straightforwardly with a widget message. The idea extends to other failures, e.g. trace.Meta.isDefEq traces for expected .. but got ... Note that this is not supposed to collect traces eagerly as these can use up substantial memory. Rather, the data of a [Trace] button is just the inputs to the failed computation, and clicking it would rerun the computation with tracing enabled.
Pitfalls and alternatives

We already have specialized data associated with message, for example MessageData.ofExpr e. This is a bit more than MessageData.ofWidget (displayTheExpr e) because it contains more data than just "display this". For example, we can inspect it to check if a message contains sorry expressions. An alternative along these lines would be to add MessageData.ofTryThis, MessageData.ofTraceOnClick etc. The problem with this approach is that it's not user-extensible.
We need to maintain compatibility with text-based environments and ones without the JS-based infoview, so WidgetMsg should likely include a toText field, even if just to emit a placeholder in the case of inherently graphical messages.

MessageData.ofTraceOnClick

This function is spelled id.  😄 Note that trace messages are already MessageData.

MessageData.ofExpr

This is implemented using MessageData.ofPPFormat these days.

I'm still pretty concerned about backwards (forwards?) compatibility and deployment (where to put the javascript) when using widgets for core functionality.

MessageData.ofTryThis

This would be my preferred solution.

MessageData.ofTraceOnClick

This function is spelled id. :smile: Note that trace messages are already MessageData.

It is not, this is what I was trying to get at with "Note that this is not supposed to collect traces eagerly as these can use up substantial memory.". The point of a "trace on click" widget is to store the input data to some failed computation but not the trace of said computation because that takes additional memory and computation (pretty-printing) time. When the user clicks the button, the computation is re-ran with the same inputs but with tracing now enabled, and the trace is displayed. So it is a very-lazy trace in that it is not even gathered until you request it to be. Think of it like a convenient "add the trace.Foo option and recompute whatever with it" button.

For instance, suppose the system prints a failed to synthesize instance SomeClass α message. In cases where it is not obvious why the synthesis failed (e.g. when debugging typeclass hierarchies), we can debug it by setting trace.Meta.synthInstance true.

You usually want to set more options than just the "obvious" one.  E.g. trace.Meta.isDefEq to see why Lean couldn't apply an instance that should work.  Or maxHeartbeats 1000 to reduce the waiting time. In #400 we've proposed to add even more interesting filtering options.
Vice versa, I often want to enable Meta.synthInstance for other errors.

You usually want to set more options than just the "obvious" one

All this is a detail of how you implement the particular message widget. The point of the new MessageData constructor (and this RFC) would only be to have a direct "handle" on (RPC reference to) the input data to the failed computation (or to one that you otherwise care about).

This is implemented using MessageData.ofPPFormat these days.

Oh right, I even reviewed that PR :facepalm: In light of that, what I am suggesting is to turn ofPPFormat into a pair of (current type, a PP function which runs in StateM RpcObjectStore and may produce a widget).

I'm still pretty concerned about backwards (forwards?) compatibility and deployment (where to put the javascript) when using widgets for core functionality.

What do you think about the pair of formatters? The expectation is that one element of the pair works in text-based environments but the other need not.


Add classes to controllers package

Closes #111

Victor what happend with you my friend?
Camilla thank you!)
Daria thanks!


Problem with #if in yojimbo_reliable_ordered_channel.cpp

When compiling with MSVC i get an error in yojimbo_reliable_ordered_channel.cpp(267,19): error C1017: invalid integer constant expression.
I think this is due to MSVC not support using #if to check for checking if #defines exists. So ifdef would have to be used instead or
YOJIMBO_DEBUG would need to be assigned a value.
Compiler Version: Microsoft (R) C/C++ Optimizing Compiler Version 19.38.33133 for x86
Targeting C++23

Awesome. Do you think you could create a small PR that fixes this issue?

OK I see the issue.


[Bug] Menu editor down button selection issue [sf#18]

Reported by jdubery on 2003-03-05 16:47 UTC
Regards the 'down' button on the menu editor.
Pressing the 'down' button moves the selected item down
one place, but leaves the selection unchanged. One
consequence of this is that pressing the 'down' button a
second time undoes the initial change.
The correct behaviour is to move the selection down one
line - i.e. the moved line remains selected.
(The 'up' button is correct.)

Commented by agriggio on 2003-03-05 18:15 UTC
Logged In: YES
user_id=375945
I've checked in an experimental fix. It seems to work, but I
haven't tested it so much, so I won't close this bug for a
while.
Thanks for the report


There's a typo in modules/util.js

I had to change 'metaData' to 'metadata' in order to log in with steemconnect.

Thanks @prophen


fix issue with hardcoded display showing in meta

I tried to spend time figuring out how this was happening. I am still not 100% I tried a bunch of things in the yaml just to see if I could isolate my change from the meta stuff but didn't have any luck. I did have luck doing a simple flag that always returns a null display for meta.

Seems like we are getting cross-contamination between different CodeableConcepts.  This is scary, I am surprised we have not run into this before.  Searching for CodeableConcept_var there looks like there may be several places where we are not setting display, and so there could be bleed-through.  Adding additional reviews for their thoughts.
Writing this out to get it straight in my head.

ExtensionMeta uses CodeableConcept_var, and it in turn uses Coding which uses $display.  Which is of course set by MedicationRequest.yml in requester_1.
Practitioner.yml uses Identifier_SystemID, which also uses CodeableConcept_var (which is why you set $display originally).

Making sure there is no display for these meta fields seems reasonable.
Wondering if there is a way to not require the NO_DISPLAY function.  Does it work to do something like noDisplay: ""


doc needs updating - example text still present

section: stop-the-upgrade
currently says:
You can stop the migration before it completes. Something here about what happens when you stop it.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 3980b9c2-7327-4112-2874-616c7621aa68
Version Independent ID: 232e4b34-556d-01ed-d624-e6a74e515116
Content: Upgrade Azure Blob Storage with Azure Data Lake Storage Gen2 capabilities
Content Source: articles/storage/blobs/upgrade-to-data-lake-storage-gen2-how-to.md
Service: storage
GitHub Login: @normesta
Microsoft Alias: normesta

Thanks for reporting this. I have assigned the issue to the content author to investigate further and update the document as appropriate.

Thank you @ktremain ! We've addressed this bug!
#please-close


Question about first GAN in book

Hello,
I want to ask about the first GAN we have trained on the book,
Is it better to train the discriminator in both fake and real?
I mean is to merge the fake samples with real samples in the same data loader, and then shuffle them and train the discriminator after.
If no, why we train the discriminator on real first, then on fake samples?

It doesn't matter. Merging real and fake samples when  training won't help. You'll get the same result.


MacOS Big Sur v11.2.3

Core Library
@azure/msal or msal
Core Library Version
2.9.0
Wrapper Library
@azure/msal-angular
Wrapper Library Version
1.1.1
Description
Users on Macs that are updated to the new version of MacOS is not able to log in. Seems that they are not able to aquire any token.
Error Message
main.c0151afc310d72671d09.js:1 ERROR Error: Uncaught (in promise): RangeError: Maximum call stack size exceeded
RangeError: Maximum call stack size exceeded
at main.c0151afc310d72671d09.js:1
at l.invoke (polyfills.f586ddce03f534407210.js:1)
at Object.onInvoke (main.c0151afc310d72671d09.js:1)
at l.invoke (polyfills.f586ddce03f534407210.js:1)
at a.run (polyfills.f586ddce03f534407210.js:1)
at polyfills.f586ddce03f534407210.js:1
at l.invokeTask (polyfills.f586ddce03f534407210.js:1)
at Object.onInvokeTask (main.c0151afc310d72671d09.js:1)
at l.invokeTask (polyfills.f586ddce03f534407210.js:1)
at a.runTask (polyfills.f586ddce03f534407210.js:1)
at Z (polyfills.f586ddce03f534407210.js:1)
at polyfills.f586ddce03f534407210.js:1
at o (main.c0151afc310d72671d09.js:1)
at l.invoke (polyfills.f586ddce03f534407210.js:1)
at Object.onInvoke (main.c0151afc310d72671d09.js:1)
at l.invoke (polyfills.f586ddce03f534407210.js:1)
at a.run (polyfills.f586ddce03f534407210.js:1)
at polyfills.f586ddce03f534407210.js:1
at l.invokeTask (polyfills.f586ddce03f534407210.js:1)
at Object.onInvokeTask (main.c0151afc310d72671d09.js:1)
Msal Logs
No response
MSAL Configuration
export const OAuthSettings = {
  appId: '************',
  redirectUri:'http://localhost:4200',
  authority : "https://login.microsoftonline.com/******/",
  scopes: [
    "*****/user.read",
  ]
};

Relevant Code Snippets
async signIn(): Promise<void> {
    await this.msalService.loginRedirect(OAuthSettings)

    let loggedIn = this.isLoggedIn();
    if(loggedIn) {
      this.signInComplete.next(true);
    }

  }

  async isLoggedIn(){
    let result = await this.msalService.getAccount();
    if(result){
      this.user = await this.getUser();
      this.Store.init();
      this.authenticated.next(true);
    }else{
      this.authenticated.next(false);
    }
  }

Reproduction Steps

On signin - users are prompted to provide username, pw and 2FA as normal.
Click login and nothing happens. Users are not logged in.

Expected Behavior
Works as expected on MS-windows and linux.
Identity Provider
Azure AD / MSA
Browsers Affected (Select all that apply)
Chrome, Safari, Other
Regression
No response
Source
External (Customer)

@kimrunar Is it possible to share fiddler  and the browser logs here? This looks like a polyfill related issue and not a MSAL related one.
One more thing that confused me is that the wrapper library used for angular should be v2 instead of v1 if you are based on the core library msal v2; can you please check our angular docs here and let us know the exact MSAL browser and angular versions in use?

Ok, so i guess i use an outdated version?
So i follow the docs you provided and try to upgrade to v2.
my current versions are :
"@azure/msal-angular": "^2.0.0-beta.3",
"@azure/msal-browser": "^2.13.1",
What i struggle with at the moment is - all your samples are with a PublicClientApplication. I have a web-application..
My appmodule is as following, before i tried to upgrade.
MsalModule.forRoot({
      auth: {
        authority: OAuthSettings.authority,
        clientId: OAuthSettings.appId,
        redirectUri: OAuthSettings.redirectUri
      },
      cache: {
        cacheLocation: 'localStorage',
      },
    },
    {
      consentScopes: [
        'user.read',
        'openid',
        'profile',
        'photo'
      ],
      unprotectedResources: [],
      protectedResourceMap: [
        ['https://graph.microsoft.com/v1.0/me', ['user.read']],
        ['https://graph.microsoft.com/v1.0/me/photo/$value', ['user.read']],
        ['https://***********'/v1.0/',['user.read']],
        ['https://***********/api/v1/',['**************/user.read']]
      ],
      extraQueryParameters: {}
    }),

How do i create a factory as in your example for a webapp? (not publicclientapp).

Another issue i have, after upgrading the packages, getAccount() is not working. In your docs getAccountByHomeId() is the new method to use. But the method is not found on service.

code-snippet
import { MsalService } from '@azure/msal-angular';
constructor(
    private msalService: MsalService,
    private http  : HttpClient) {
  }

async isLoggedIn(){
    let result = await this.msalService.getAccountByHomeId();   //Property 'getAccountByHomeId' does not exist on type 'MsalService'.
    if(result){
      this.authenticated.next(true);
    }else{
      this.authenticated.next(false);
    }
  }

The question here is a bit off-topic from the issue perhaps, but i hope you can help. Thanks

Now i have set it up just like in the example but i get.
[Mon, 12 Apr 2021 12:55:30 GMT]<EMAIL_ADDRESS>: Info - Emitting event: msal:loginStart app.module.ts:82:10
ERROR Error: Uncaught (in promise): BrowserAuthError: interaction_in_progress: Interaction is currently in progress. Please ensure that this interaction has been completed before calling an interactive API.
and my url looks like this http://localhost:4200/#code=0.AY"......."

@kimrunar Please provide complete verbose logs. interaction_in_progress means your app is attempting to make an interactive request while another request is still in progress.

What i struggle with at the moment is - all your samples are with a PublicClientApplication. I have a web-application..

Are you saying you have a confidential client application?

Hey, this is solved. The original issue with "Mac OS big sur 11.2.3" was solved with an msal upgrade from v1 to v2. Any additional problems i had was just bad implementation by me.
Thanks.


feat: optionally apply plan file

Fixes

#63

To use, the user must:

Enable attach-workspace on the plan and apply jobs.
The plan parameter must be set on the apply job

The plan job now parameterizes the name and path of the plan but defaults to plan.out as before.
By leaving the plan parameter on the apply job blank, there are no breaking changes.

Preview the orb here:

You can preview what this will look like on the CircleCI Orb Registry at the following link:
https://circleci.com/developer/orbs/orb/circleci/terraform?version=dev:0cadaa0d00d2b4b54dd67f498057802e9c327329

Your development orb has been published. It will expire in 30 days.
You can preview what this will look like on the CircleCI Orb Registry at the following link:
https://circleci.com/developer/orbs/orb/circleci/terraform?version=dev:d9c944cf026614b2252007269a0099da7696900e

Your development orb has been published. It will expire in 30 days.
You can preview what this will look like on the CircleCI Orb Registry at the following link:
https://circleci.com/developer/orbs/orb/circleci/terraform?version=dev:26b9ae74a5eb88f989ba24973e45b0d080a25a4a


set podman image storage location

[//]: # kind feature
or, rather, support request.
My root is mounted at SSD for speed, and so does my home. However, I am not rich, so SSD is small, and now I want more space. First I want to move images to another disk, and if that won't help, move containers as well.
I found podman info, which printed some useful info at the end.
...
store:
  ContainerStore:
    number: 3
  GraphDriverName: vfs
  GraphOptions: []
  GraphRoot: /home/anatoli/.local/share/containers/storage
  GraphStatus: {}
  ImageStore:
    number: 1
  RunRoot: /run/user/1000/run

The path /home/anatoli/.local/share/containers/storage is 6.3G, and there is only one image 745Mb in size there.
✗ podman images -a
REPOSITORY                 TAG     IMAGE ID       CREATED        SIZE
docker.io/library/golang   1.9.4   a6c306bd0b2f   8 months ago   754MB
✗ du -hs  ~/.local/share/containers/storage
6.3G	/home/anatoli/.local/share/containers/storage

I don't see how can I move images to the other place, because vfs-images contains only meta information and vfs hosts only hash dirs.
6.3G	/home/anatoli/.local/share/containers/storage/vfs
132K	/home/anatoli/.local/share/containers/storage/vfs-containers
28K	/home/anatoli/.local/share/containers/storage/vfs-images
1.8M	/home/anatoli/.local/share/containers/storage/vfs-layers

Is there a setting that I can change to store images in a separate dir?
Output of podman version:
Version:       <IP_ADDRESS>
Go Version:    go1.10.4
OS/Arch:       linux/amd64

Sounds like podman doesn't support changing image storage location with a simple user setting. Does that qualify for a future request? Having an option in ~/.config/containers/storage.conf- ImageStore.location = /data/podman-image.

We are moving over to creating the file by default, with the correct settings (so you'll only need to swap the one setting). That should be out in our next release (hopefully tomorrow). If you're looking for a way to just swap image storage, though, I don't think that's possible as of now - we storage images and containers in the same place as part of the architecture of containers/storage. We might be able to split that, but for now both must be in the same place.

Let me know what should I do when it is released. I guess removing podman, cleaning up config files and then reinstalling it again to create the config in my home dir? Then I will be able to edit it to set storate location.

SImpler fix would be to setup a bind mount
cp -R ~/.local/share/containers /data
rm -rf ~/.local/share/containers
mkdir ~/.local/share/containers
mount -o bind /data/containers ~/.local/share/containers

+1 for the file based configuration of the storage location.

With podman <IP_ADDRESS>  It should generate ~/.lcontig/containers/storage.conf
This file can be edited to point at /data/containers.

~/.config/containers/storage.conf to be clear

➜  ~ rm -rf ~/.local/share/containers
➜  ~ rm -rf ~/.config/containers
➜  ~ sudo dnf --enablerepo=updates-testing install podman
...
podman                            x86_64       <IP_ADDRESS>-1.git66d3499.fc28        updates-testing       7.0 M

➜  ~ cat .config/containers/storage.conf
[storage]
  driver = "vfs"
  runroot = "/run/user/1000"
  graphroot = "/home/anatoli/.local/share/containers/storage"
  [storage.options]
    mount_program = ""

It's not really clear from the generated file, but graphroot there is container and image storage

@mheon you're right that it's not clear... not sure if the generated ~/.config/containers/storage.conf can include comment/documentation. That alone would help a lot.

It could, but it would be a fair bit of effort on our end (straight TOML generation to templated output). Probably worth it, though.

Looks like Tom doesn't count comments as a feature - https://github.com/toml-lang/toml/issues/284

@giuseppe I think your code is doing this, could you take a look.

How often does podman touch storage folder while sitting in a background and not starting other containers? Is there a way to measure that?

You'd need to change both storage.conf and libpod.conf to update the path to static dir.
Migration is currently blocked by us validating the config file settings with the db.
It should work if you start with a fresh storage

If migration is impossible, then the only way is remove podman, then edit files
vim $HOME/.config/containers/libpod.conf
# volume_path = "$HOME/.local/share/containers/storage/volumes"
# static_dir = "$HOME/.local/share/containers/storage/libpod"
vim $HOME/.config/containers/storage.conf
# [storage]
#   graphroot = "$HOME/.local/share/containers/storage"

, kill $HOME/.local/share/containers, and install podman again.

why do you need to remove podman and install it again?

I believe this is no longer an issue.

Not sure if anything wrong with my setup as of now I seems to hit this bug. The only way to make it work is using mount bind.
as long as I have .config/containers/storage.conf with all correct settings podman always says:
Error: mkdir /var/run/containers: permission denied
podman is in fedora 33,
podman --version
podman version 2.2.1

the only thing it works by remove the custom config and then copy the storage over the other directory and empty the original one, mount bind two dir together.
Should we re-open this issue?

how does the .config/containers/storage.conf  file look like?

The same situation, but tune in  /etc/containers/storage.conf
and no one bothers to do symlink.

how does the .config/containers/storage.conf  file look like?

I have to remove it. But when I have issues described the content is as basic
[storage]
driver = "overlay"
runroot = "/mnt/portdata/containers/stevek/storage-runroot"
graphroot = "/mnt/portdata/containers/stevek/storage"
rootless_storage_path = "/mnt/portdata/containers/stevek/storage"

how does the .config/containers/storage.conf  file look like?

I have to remove it. But when I have issues described the content is as basic
[storage]
driver = "overlay"
runroot = "/mnt/portdata/containers/stevek/storage-runroot"
graphroot = "/mnt/portdata/containers/stevek/storage"
rootless_storage_path = "/mnt/portdata/containers/stevek/storage"

Well, you have many solutions

Request a list of package file from the repository.
	rpm -vlq podman |grep ".conf" 2.
Make a choice of a package dependency, go over them ;)
yum deplist podman |grep containers-common
Look it.
	rpm -qdf /usr/bin/podman 4.Significant!
https://github.com/containers/podman/blob/master/vendor/github.com/containers/storage/storage.conf 5. My default? ok
https://gist.github.com/locaIhost/7404c69e22e18c0a4a58b9cd41136934 ......... and
man containers-storage.conf  .........
If that write - happy to answer:: Give a Certification RHCSA Discount on Women's Day!

Thanks, this saves my life!
I don't have root permission on the machine. Solved the problem by using the following steps:

mkdir -p ~/.config/containers/
cp /etc/containers/storage.conf ~/.config/containers
Change runroot, graphroot to directories inside /run/user/$UID, you don't have to create these directories manually, podman will create them for you.
export TMPDIR='/run/user/$UID/podman-tmp'
mkdir -p $TMPDIR

My /etc/containers/storage.conf in Ubuntu WSL2 is empty.

Check /usr/share/containers/storage.conf

Check /usr/share/containers/storage.conf

No such file

Here is mine on Fedora.
storage.conf

@giuseppe can you summarize the full process with docker support please?
Let's take for example the path /var/mnt/data/containers/storage as a target.
What folders/files to create/update? (storage.conf, libpod.conf, etc...)
What should we update in those files? (driver, runroot, graphroot, rootless_storage_path, etc...)
Thank you a lot 🙏

It is only storage.conf, you should never do anything with libpod.conf Remove it if  you have on on your system.
graphroot is used to change the system storage directories for images and containers.
rootless_storage_path will override the default location for rootless users ~/.local/share/containers/
No need to update driver or runroot.

Thanks @rhatdan
Can you update your answer (to keep it simple for anyone who's looking for a concise solution) for the case of someone already having containers. (from toolbox create, docker-compose up, etc...)
Can we simply move them? (the whole graphroot directory)
Should we recreate them?

If you want to copy your images from docker to podman, I was only advised this solution: https://github.com/containers/podman/discussions/16020
docker save IMAGE | podman load

I'm not sure if it is possible for containers.

I would prefer this hack.
docker images --format docker-daemon:{{.Repository}}:{{.Tag}} | grep -v none  | xargs podman pull
# podman images
REPOSITORY  TAG         IMAGE ID    CREATED     SIZE
sh-5.2# docker images
REPOSITORY                              TAG       IMAGE ID       CREATED         SIZE
<none>                                  <none>    cf88db92256c   4 weeks ago     5.59MB
<none>                                  <none>    0a793d27c5b7   4 weeks ago     5.59MB
<none>                                  <none>    aa3749da95de   4 weeks ago     5.59MB
<none>                                  <none>    63d102f81adb   2 months ago    5.59MB
nginx                                   latest    670dcc86b69d   4 months ago    142MB
<none>                                  <none>    a0d5654bf697   5 months ago    5.59MB
<none>                                  <none>    fa94027fbe29   5 months ago    5.59MB
<none>                                  <none><PHONE_NUMBER>73   6 months ago    5.59MB
<none>                                  <none>    2a9b6aeb963c   8 months ago    153MB
<none>                                  <none>    0022b42cdf0d   8 months ago    1.38GB
i386/alpine                             edge      c9930b809cba   8 months ago    5.46MB
registry.access.redhat.com/ubi8-micro   latest    a4b6df2ac2df   10 months ago   36.5MB
fedora                                  latest    b78af7a83692   12 months ago   153MB
alpine                                  latest    c059bfaa849c   12 months ago   5.59MB
sh-5.2# docker images --format docker-daemon:{{.Repository}}:{{.Tag}} | grep -v none  | xargs podman pull
Getting image source signatures
Copying blob abc66ad258e9 done
Copying blob f931b78377da done
Copying blob d7783033d823 done
Copying blob 43b3c4e3001c done
Copying blob 4553dc754574 done
Copying blob 243243243ee2 done
Copying config 670dcc86b6 done
Writing manifest to image destination
Storing signatures
670dcc86b69df89a9d5a9e1a7ae5b8f67619c1c74e19de8a35f57d6c06505fd4
Getting image source signatures
Copying blob 8329b0e13e56 done
Copying config c9930b809c done
Writing manifest to image destination
Storing signatures
WARNING: image platform ({386 linux  [] }) does not match the expected platform ({amd64 linux  [] })
c9930b809cbaef2f8784f3b8ed929caa8e95a944815bf91721cb050fe9779613
Getting image source signatures
Copying blob fe7a061dd3ad done
Copying blob 5f70bf18a086 done
Copying config a4b6df2ac2 done
Writing manifest to image destination
Storing signatures
a4b6df2ac2dfb315a4edf1c62f4e44c466ca3ad81d8acc4beba31b07daa9fe77
Getting image source signatures
Copying blob 389adea752cd done
Copying config b78af7a836 done
Writing manifest to image destination
Storing signatures
b78af7a836928efd44317e82c8f2f9c86bb83ae915deef1b58dc6465dfa5436e
Getting image source signatures
Copying blob 8d3ac3489996 done
Copying config c059bfaa84 done
Writing manifest to image destination
Storing signatures
c059bfaa849c4d8e4aecaeb3a10c2d9b3d85f5165c66ad3a4d937758128c4d18
sh-5.2# podman images
REPOSITORY                             TAG         IMAGE ID      CREATED        SIZE
docker.io/library/nginx                latest      670dcc86b69d  4 months ago   146 MB
docker.io/i386/alpine                  edge        c9930b809cba  8 months ago   5.75 MB
registry.access.redhat.com/ubi8-micro  latest      a4b6df2ac2df  10 months ago  38.7 MB
docker.io/library/fedora               latest      b78af7a83692  12 months ago  159 MB
docker.io/library/alpine               latest      c059bfaa849c  12 months ago  5.87 MB

I had to create the config file: /home/user/.config/containers/storage.conf
[storage]
driver = "overlay"
#runroot = "//containers/storage-runroot"
graphroot = "//containers/storage"
#rootless_storage_path = "//containers/storage"

The two commented lines were not needed to run rootless so far.
Move the container/* files to target and then sudo systemctl restart podman and podman info to check the config was changed.


Solves patmat ambiguities

Fixes #1888
In order to solve ambiguities the pattern generator now creates pattern names with prefix $.
Also we changed the Pattern and Case types - they now extends PartialFunction instead of Function.
Example:
Match(Some(1)).of(
    Case($Some(1), "ok")
)

The change has a long story. The release notes will contain more detailed information why it was not possible to

let our Values extends Pattern
Pattern0 (like None()) can't infer the right type within a pattern matching context

Codecov Report

Merging #1984 into master will decrease coverage by 0.23%.
The diff coverage is 71.84%.

@@             Coverage Diff              @@
##             master    #1984      +/-   ##
============================================
- Coverage     98.01%   97.77%   -0.24%
+ Complexity     5175     5167       -8
============================================
  Files            91       91
  Lines         11788    11797       +9
  Branches       1530     1565      +35
============================================
- Hits          11554    11535      -19
  Misses          116      116
- Partials        118      146      +28

Impacted Files
Coverage Δ
Complexity Δ

vavr/src/main/java/io/vavr/collection/Seq.java
98% <ø> (ø)
50 <0> (ø)
:arrow_down:

vavr/src-gen/main/java/io/vavr/API.java
92.68% <71.84%> (-5.09%)
197 <0> (-8)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b3a746d...8a8c6d5. Read the comment docs.


IMU-Lidar timestamp issue

Hello,
I am getting inconsistent (the map drifts after a while) results while using imu and lidar together in carla sim, what could be the issue for the warnings below ?
[2024-12-05 01:03:42.608] [odom] [warning] insufficient number of IMU data between LiDAR scans!! (odometry_estimation)
[2024-12-05 01:03:42.608] [odom] [warning] t_last=179.920230 t_current=179.970230 num_imu=1
[2024-12-05 01:03:42.681] [odom] [warning] insufficient number of IMU data between LiDAR scans!! (odometry_estimation)
[2024-12-05 01:03:42.681] [odom] [warning] t_last=179.970230 t_current=180.020230 num_imu=1
[2024-12-05 01:03:42.751] [odom] [warning] insufficient number of IMU data between LiDAR scans!! (odometry_estimation)
[2024-12-05 01:03:42.751] [odom] [warning] t_last=180.020230 t_current=180.070230 num_imu=1

I also always get this error at the end of the bag file..

The problem is in sub_mapping.cpp from line 217 to 242, where the imu preintegration was handled. Probably it is waiting for more frequent imu data in the defined interval (50 miliseconds in my case since the lidar frequency is at 20 hz). However i don't know how to configure carla simulator to publish more frequent imu data than lidar data.
To be able to successfully handle the imu preintegration we should have at least 2 imu inputs in this interval, as we can see from the warnings i only have one, i will try to modify the code to set this number to 1 in order to see if the imu data will be added as a factor into the graph and if the drift still occurs (since carla is a simulation environment, even with 1 imu data it should handle correctly, my imu noise rates are null).
However i don't have a clear solution for real hardware if this problem occurs, probably it is something to do with sensors hardware synchronization and time stamping. Most of the time IMU publishes data at 100hz and lidar at 20hz, so it should work :)


Fix conll.py

Change non-existent method call 'parse' with fromstring method on _get_parsed_sent.

Thanks @germanferrero. Please add yourself to our contributors list

This is still broken for me on nltk version 3.2.1 as of November 2nd 2016.

@RokoMijic 3.2.1 is the latest NLTK version so far (see ChangeLog and NLTK News). The problem has been fixed but this was after 3.2.1 was released, so the fix will be available with the next NLTK version.
If you need this feature you could install NLTK cloning it from the develop branch.


Pyupgrade: Printf string formatting

A part of #827. This one is complicated so it will take me some more time.
Please Note: I purposely did NOT implement the --keep-percent-format flag because it looks like the last flag I added was removed. If you want this flag in, just let me know.
Note: the issue of the /N{dog} format will plague us in UP030 and UP032. Whatever solution we find here needs to be applied in both of those places. Right now I am just thinking of looking for it, and if it exists, only showing a warning but not attempting top fix. I have NEVER seen this syntax in practice, and I think it is reasonable to give the people using it a warning, but don't fix.

@charliermarsh I have hit a blocker and I would love some assistance. Pyupgrade uses the regex "(?<!\)(?:\\)*(\N{[^}]+})" to get an outcome like below:

We cannot use this regex in rust, because the regex uses look behinds, which are not implemented in rust. I tried taking the post's advice and reimplementing the regex without look behinds, "^\*(\N{[^}]+})", but then the character before is included in the string, which causes the program to break:

After this I tried using the fancy_regex create; however, they do not implement the split method which is required. With this I am unsure of what to do next. We could check for my ugly regex, and just ignore those (or report them as issues but not fix them). But that really bothers the perfectionist in me. Let me know how you think we should handle this.

Why do we need / why does the regex exist? Is it to avoid treating named unicode characters as {}-style formatting placeholders?

I know its for statements like these: "%s \N{snowman}" % (a,), because they are currently causing issues in my code. However, I am not sure the specific reason they are needed.

It looks like it exists so that "%s \N{snowman}" % (a,) does not turn into "%s \N{{snowman}}" % (a,). If this happens we get the following error in python:
SyntaxError: (unicode error) 'unicodeescape' codec can't decode bytes in position 3-14: unknown Unicode character name

Is there a way that we could run the regex, extract the match, then run a second regex over the match to get a more precise range?

Is there a way that we could run the regex, extract the match, then run a second regex over the match to get a more precise range?

Right now the regex I have developed that is the closest is "[^\\](?:\\\\)*(\\N\{[^}]+\})". It has two issues:

It grabs one character before the match starts (this could in theory be fixed by your solution)
It would never match: \N{snowman}" % (a,), I am not sure how to overcome this shortcoming

Additionally, I am not sure if we could use this "double regex" with methods like split. I have been trying to think of other ways we could do this. I am sure we could do something with tokens, but not sure how we could turn this back into a string simply.

Ok, let me take a closer look. Don't worry about resolving it for now. I have to spend some time with the code to understand the problem before I can offer good advice :)

Sounds good! I am working on the dict implementation, once I get that done this is solved besides the regex issue.

@charliermarsh I am moving this out of draft now. This one was pretty complicated so I left as many notes as I could. Everything is working as I want it to besides the regex we discussed above. However, please not I departed from pyupgrade for two negative test cases (test cases where the linter should NOT run):
        # don't rewrite string-joins in dict literal
        '"%(ab)s" % {"a" "b": 1}',

Rustpython_ast automatically makes this string-join "ab". This means that not linting here would take more logic on our end, and would end up being less helpful for the user. If you can think of an edge case where this is an issue, let me know and I can fix.
        # don't rewrite strangely styled things
        '"%(a)s" % {"a"  :  1}',

The rust_python ast we are using doesnt have the spaces factored in, so they do not create issues. Fixing this one will require adding complicated logic, to decrease the user experience. As before, if you disagree just let me know.

Thanks. I know I owe you a review here! Hasn’t slipped my mind. Just trying to find time since it’s a big PR and requires focus :)

No worries! I figured it might be a day or two before you get this one! By far the most complicated one I have done.

(Reviewing now.)

I haven't finished reviewing the code yet, but I notice this is failing on a few cases:
@@ -244,8 +244,8 @@ def run(
     print(
-        "Writing merged info for %s slides (%s unrecognized)"
-        % (len(merged_slide_data), unrecognized_count)
+        "Writing merged info for {%s unrecognized:"}
+       .format(len(merged_slide_data), unrecognized_count)
     )
     merged_slide_data = sorted(
         merged_slide_data, key=lambda row: cast(str, row["Slides_slide_barcode"])

     def composite_image(self, files: List[str]) -> List[str]:
         if len(files) != len(self.channels):
             raise ValueError(
-                "Expected one image (got %d) per channel (got %d)"
-                % (len(files), len(self.channels))
+                "Expected one image (got {got %d:"}
+               .format(len(files), len(self.channels))
             )

         composited_image = None

I see you are making changes. Let me know once you are done and I can attack issues you find.

I'll stop for now :)

I have NEVER seen this syntax in practice, and I think it is reasonable to give the people using it a warning, but don't fix.

FWIW, that's fine with me for now.

--keep-percent-format

Yeah we don't need to implement these flags IIUC because that's just equivalent to --ignore UP031.

Pyupgrade won't event attempt to fix these, time to find out why and get it fixed.

@charliermarsh, unfortunately I was not able to fix the two issues you found tonight. However, I was able to determine that parse_percent_format is the function that is causing the issue. I was also able to run the same strings through the actual pyupgrade library, to determine the structs that should have been generated. This allowed me to create two failing unit tests. I am hoping to get this issue fixed by Sunday night at the latest. Also, I am wondering why pyupgrade does not change the strings at all, because the statement does not seem to violate any rules laid out in the unit tests.

@colin99d - My suggestion is to try and use CFormatString from RustPython instead of regular expressions. You can see how it works in the f-string PR. But e.g.:
let Ok(format_string) = CFormatString::from_str(&left_string[1..left_string.len() - 1]) else {
    return;
};

This gives you structured data about the string that I think we can use to reconstruct it. And the parser will be very robust. I can also take a crack at this if you're too tired of this one!

I have no problem doing it (always good to learn more tools for later PRs). Will try to have it done by this Sunday night.

Ok cool, thank you -- as always, appreciate all the effort here! Let me know how it goes. I can't guarantee that it will work, since I haven't done the exercise myself, but I suspect it should, and would lead to a really strong solution.

Ok cool, thank you -- as always, appreciate all the effort here! Let me know how it goes. I can't guarantee that it will work, since I haven't done the exercise myself, but I suspect it should, and would lead to a really strong solution.

No problem! Also, would love to chat on Discord or something about next steps after I get pyupgrade done in the next couple weeks. Right now I am thinking about attacking pylint because that takes the most time in our CI and in pre-commit.

@colin99d - Sounds great. I did setup a Discord, but... I haven't shared it with anyone yet, so it's just me :joy:

@colin99d - Sounds great. I did setup a Discord, but... I haven't shared it with anyone yet, so it's just me 😂

Awesome! Honestly a small private discord is probably the way to go, where you just invite people actively contributing. That way you dont get bots and spammers. Also, ruff should just work so once this tool is ready community members should not need a lot of support.

One thing I'm realizing, just to confirm my understanding, is that in many cases, these will actually be fixed yet again by the f-string rule, right?
E.g. '%s %s' % (a, b) to '{} {}'.format(a, b) to f'{a} {b}'.

One thing I'm realizing, just to confirm my understanding, is that in many cases, these will actually be fixed yet again by the f-string rule, right?
E.g. '%s %s' % (a, b) to '{} {}'.format(a, b) to f'{a} {b}'.

That is correct!

One thing I'm realizing, just to confirm my understanding, is that in many cases, these will actually be fixed yet again by the f-string rule, right?
E.g. '%s %s' % (a, b) to '{} {}'.format(a, b) to f'{a} {b}'.

Also, the f-strings purposely ignores strings with format specifiers, so that UP030 can handle it first.

@charliermarsh, I began working on the conversion to CFormatQuantity. This definitely looks like it will be a better way to do things! So far I have one question, how do I convert CConversionFlags to a string? So far I have been digging in here, and I have not been able to come up with anything.

Hmm, I think I'd look at the RustPython source for those flags to understand how they're created, then implement the inverse? Does that work?

Oh perfect, thanks

@charliermarsh, if you dont mind digging into this if you get some free time I think it might have some differences that are too big. For example, if the precision is just ".", this library decides to make it 6. This is different to python, which would round to 0 decimals if precision is just 0. If we decide this doesn't work we can go back to the old way of doing it.

(Will try to take a look tonight.)

I've started poking at this but there's a lot to read :)
Are there any other discrepancies beyond what you've described? (Would it make sense to fix those in RustPython, if they're actual CPython incompatibilities?)

There are a couple, yeah. Also, I would be interested in knowing why they chose 6. We could attempt a PR there, or I could Just try to fix the one we have? Let me know what you want me to do.

I think it's because of this?
>>> "%f" % 2.12
'2.120000'

You are right, but the issue is they are treating the below code as a 6. This means if we get a 6 we dont know if it should be a 0 or a 6.

Yeah that, I think, should be fixed. I'll look into fixing it as I review this. Are there other limitations though?

It looks like this and pyupgrade are disagreeing on another one. But I am not sure who is right. The pyupgrade tests is here. Pyupgrade wants to convert this into a statement, but rustpython doesn't. It looks like rustpython might be right though:
>>> "%%" % 2.12
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
TypeError: not all arguments converted during string formatting
>>> "%%" % "hello"
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
TypeError: not all arguments converted during string formatting
>>>

Yeah that seems ok. So if I go and fix the RustPython parse limitation, does this seem good to go from your perspective?

I am getting a little more weird behavior, but for right now im guessing its on me. I will let you know by EOD today if this is the only issue.

I guess a related issue is that with:
"%f" % 1

I think RustPython reports that as precision(6), so I'm not sure we can reconstruct it exactly?

Yes this issue is definitely on them, but there is some other stuff im seeing that is weird. This is good though. We get to help the whole rust/python ecosystem on this stuff.

I'll put together a PR to fix those limitations in RustPython now.

To be clear, though, I am impressed by your regex abilities!

To be clear, though, I am impressed by your regex abilities!

Haha, 2 weeks ago I would not have known that. Regex101, and a buddy I know who did them full time for a couple months got me a lot further along than I should be (and some are just copied from pyupgrade).

Yeah, my preference is to use the parser if we can. I think it will be faster and more robust (and easier for us to maintain, reason about, etc.) than regular expressions. So I want to push us down that path unless we can find a reason that it's ~impossible.

Yes. I would much rather rewrite now than deal with 100 edge case bugs once the feature gets merged.

https://github.com/RustPython/RustPython/pull/4463

BTW, I think Pyupgrade handles %.f incorrectly, maybe?
This code:
x = 1
y = 2
z = 3

print('%.2f %.f %f' % (x, y, z))

Gets changed to:
x = 1
y = 2
z = 3

print('{:.2f} {:.f} {:f}'.format(x, y, z))

Which yields:
Traceback (most recent call last):
  File "/Users/crmarsh/workspace/ruff/foo.py", line 5, in <module>
    print('{:.2f} {:.f} {:f}'.format(x, y, z))
          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
ValueError: Format specifier missing precision

Looks like you are right, maybe we keep the 6 as a default if they do not specify, OR we could just issue a warning but not fix. I like the first option a little more, but as always up to you.

@colin99d - Mind if I do a pass on this from the current state of the code?

@colin99d - Mind if I do a pass on this from the current state of the code?

I have some bad code im fixing. Unit tests caught a new edge case. Let me finish and then she's all yours.

Okay thanks. Just LMK when it's ready. I'll point to the updated RustPython branch and get it into a finished state, hopefully.

And yeah -- I think we map %.f to %.0f. Same with %.s etc.

@charliermarsh I am ready for you. Running cargo test printf_string_formatting currently results in two failures. Both are related to the precision issue.

Working my way through this one, found at least one bug but I think it might be in our logic and not the parser.

@colin99d - Ok, I think this is passing all tests now. I can think of a few ways that it could be improved so I might iterate on it a bit more. (For example: it'd be nice if we could avoid transforms that create really long string format calls.) It's a really significant transform, so I want it to be rock-solid before it goes out.

One thing I did in another check, is that if the new string is longer I would not do the change.

I guess I'm also thinking about whether we should be fixing multi-line strings.

I can see it either way. Pyupgrade did NOT fix the strings that you sent me earlier that broke.

Alright, I'm gonna merge this as soon as #4463 is released.


Rebase collab-authn to latest master

Rebase collab-authn to latest master.

@lei-tang: PR needs rebase.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: lei-tang
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: linsun
If they are not already assigned, you can assign the PR to them by writing /assign @linsun in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS
prow/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: lei-tang
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: rshriram
If they are not already assigned, you can assign the PR to them by writing /assign @rshriram in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

/cc @diemtvu

/lgtm

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: diemtvu, lei-tang
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: rshriram
If they are not already assigned, you can assign the PR to them by writing /assign @rshriram in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Registry Setting

Using the GPO, how do I check if the settings were applied? Which registry path on the client computer should this be checked?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 601039de-64e0-6f70-a5c6-f569f7d0cf87
Version Independent ID: 861e9906-f260-fdcd-9bba-eb86056e51bd
Content
Content Source
Service: o365-administration

The registry location for these GP settings are HKLM\software\policies\microsoft\office\16.0\common\officeupdate. You can find the registry location of any GP setting by looking at the office2016grouppolicyandoctsettings.xlsx Excel file that is included in the GP ADMX files download from the Microsoft Download Center. Go to the ADMX worksheet, find the setting you're interested in, and then look in column F ("Registry information").  Hope that helps.

Does this conflict in any way with the settings found in \HKLM\Software\Microsoft\Office\ClickToRun\Configuration?
There are two update location configurations found there, and one that is governing if update is enabled:

UpdateUrl
UpdateChannel
UpdatesEnabled


ISPN-4912: Switch REST store to better HTTP client library

See ISPN-4912 for discussion

Looks good!
There is one test utility that was using the HttpClient and now has a compilation error:
server/integration/testsuite/src/test/java/org/infinispan/server/test/client/rest/RESTHelper.java
I think it can keep using HttpClient, we just have to add it as a dependency for the integration tests.

Will fix and update the PR. Thanks.

Updated. Please run the tests again?

@atoulme The tests run automatically, you can see the status is still "All checks have failed", but this time there are only 3 test failures :)
@galderz could you also review?

@atoulme some minor comments. Otherwise looks good.

Looks good to me, @tristantarrant's question WRT content encoding need answering.
My only question would be whether you looked into other HTTP clients, such as OkHttp. They even have benchmark that can compare Netty vs OkHttp here. I'm not proposing that Netty is replaced by OkHttp, but if any testing/comparison/benchmarking has been done for this task, it'd be good to find out more details.

I did some talk with Wildfly Team members about choosing an embedded REST library.
From the comparison they did, it turned out that Undertow implementation was the fastest and there were very little differences between its competitors - Netty and Jetty. Similar results might be found on TechEmpower portal.
Having this in mind - I would vote for doing some benchmark before accepting this (or any other) PR which changes REST embedded server.
@atoulme @tristantarrant @galderz What do you think about it? If we want to do such comparison and such change - this is the perfect moment (we're at the beginning of ISPN9 loop). If we don't want to do that - let's close this PR.

@slaskawi This PR isn't about the REST server, it's about the HTTP client library that the REST store uses to connect to the server. For the server side I think we're going to stay with RESTEasy over Netty, although we have encountered some problems there as well (e.g. https://issues.jboss.org/browse/RESTEASY-1205).
Since our use case is pretty standard, I don't think we need to run our own benchmarks, we just need to find some published benchmarks. Unfortunately @galderz's link to the OkHttp benchmark rotted away :)

I addressed @tristantarrant's feedback.
I didn't find a good benchmark for okHttp vs netty, but I didn't look very deep. @galderz, would you have better links?
I will look at test results and will try to address them. IIRC last time I couldn't figure it out by myself though, so I'll shout for help if needed.

@danberindei Thanks for clarification.

:+1: from me.
@tristantarrant @galderz @danberindei Any other comments? Or this one can be merged into ISPN 9?

@danberindei The benchmark is still there but has been moved slightly, see here

Hi @atoulme ! We got rid of the most test failures in master branch, so could you please rebase this PR? We'd like to check if it doesn't introduce new failures.

Update PR might be found here: https://github.com/infinispan/infinispan/pull/4214

Thanks @slaskawi!


Wrong behaviour of onLayoutChange for responsive

onLayoutChange  returns wrong value for layout when responsive.
Suppose I have this layout. Two grid items in every breakpoint.
Suppose current breakpoint is lg
layout = {
    lg: [{}, {this item}], // watch this grid item below
    md: [{}, {this item}],
    xs: [{}, {this item}],
    xxs: [{}, {this item}],
    sm: [{}, {this item}]
}

If I remove a grid item in current breakpoints lg, guess what I get in a callback. For some reason onLayoutChange removes an item ONLY for current breakpoint and doesn't touch it for other breakpoints:
layout = {
    lg: [{}], // BOOM! Grid item is removed here, but still exists in all other breakpoints.
    md: [{}, {this item}],
    xs: [{}, {this item}],
    xxs: [{}, {this item}],
    sm: [{}, {this item}]
}

Screenshot. Do you see lg is 2 and all others are 4?

This is WRONG and error prone. If I remove a grid item in one breakpoint, it has to be removed for all other breakpoints! Otherwise we end up having gazillion useless layouts for grid items we don't have already.

@wzup, this is open source software free for use and free for modification. Please check your tone at the door.
Whether or not you actually want to remove an item for all breakpoints or not is really a decision best left up to the application, not the library. You can modify all other layouts yourself via the reference if you like.

hello @STRML ,
Firstly, Thank you so much for this amazing lib.
I am also facing the same issues:

when I remove item from layout, sometimes it is removed from other breakpoints and not the current breakpoint
item is not getting removed from all the breakpoints.

Can you please suggest me some ways where I can handle this scenario? What I want to have is, when item is added/removed, it should be synced for all breakpoints.


LLMonitor Callback Handler: support for future OpenAI kwargs

Hi,
This ensures support for future OpenAI kwargs (tools, tool_calls, etc.) ensuring maximum compatibility.

Thank you!

Ah actually you will need to run yarn to update the lockfile if you don't mind

@jacoblee93 Done + some other improvements, thank you!

Seems like there's some TypeScript issue now:

Hi @jacoblee93 it should be fixed, I'm not seeing the test-exports CI results though 🤔

Thank you!


bug: Content Scroll doesn't work with ion-tabs

Bug Report
Ionic version:

[x] 4.x
Current behavior:

After putting in ion-tabs into the project and running on Android the page doesn't scroll
Expected behavior:

to be able to scroll to see overflow
Steps to reproduce:

put in ion-tabs in a project that has to be scrolled horizontally
Related code:

<ion-header no-border>
  <ion-toolbar>
    <ion-buttons slot="start">
      <ion-menu-button></ion-menu-button>
    </ion-buttons>
    <ion-title text-center> ¡Hola {{ userInfo.firstNames }}! </ion-title>
    <ion-button fill="clear" class="header-right" (click)="showNotifications($event)">
    </ion-button>
  </ion-toolbar>
</ion-header>
<ion-content>
  //stuff here
</ion-content>

<ion-tabs>
  <ion-tab-bar slot="bottom">
    <ion-tab-button tab="tab1">
      <ion-icon name="flash"></ion-icon>
      <ion-label>Tab One</ion-label>
    </ion-tab-button>

    <ion-tab-button tab="tab2">
      <ion-icon name="apps"></ion-icon>
      <ion-label>Tab Two</ion-label>
    </ion-tab-button>

    <ion-tab-button tab="tab3">
      <ion-icon name="send"></ion-icon>
      <ion-label>Tab Three</ion-label>
    </ion-tab-button>
  </ion-tab-bar>
</ion-tabs>

Other information:

I've read that this was fixed earlier as well as this Stackoverflow
Also, within my application I initialized the app with the side menu flag. However, there is one section (the home section) that I want to give them quick access to either home or their profile section rather than using the side-menu exclusively
Ionic info:

Ionic:

   Ionic CLI                     : 5.0.1 (/Users/c.francia/.nvm/versions/node/v12.1.0/lib/node_modules/ionic)
   Ionic Framework               : @ionic/angular 4.4.2
   @angular-devkit/build-angular : 0.13.9
   @angular-devkit/schematics    : 7.2.4
   @angular/cli                  : 7.3.9
   @ionic/angular-toolkit        : 1.4.1

Cordova:

   Cordova CLI       : 9.0.0<EMAIL_ADDRESS>   Cordova Platforms : android 7.1.4, ios 4.5.5
   Cordova Plugins   : cordova-plugin-ionic-keyboard 2.1.3, cordova-plugin-ionic-webview 3.1.2, (and 8 other plugins)

I have the same problem on IOS. In Chrome and in Safari in MacOs it works.
Content scroll does work when page laoded with [routerLink]="['/programs']
Content scroll does not work when page loaded with [routerLink]="['/tabs/programs']
Ionic Info:
Ionic CLI                     : 5.0.2 (/Users/aj/.nvm/versions/node/v12.4.0/lib/node_modules/ionic)
Ionic Framework               : @ionic/angular 4.4.2
@angular-devkit/build-angular : 0.13.9
@angular-devkit/schematics    : 7.3.9
@angular/cli                  : 7.3.9
@ionic/angular-toolkit        : 1.5.1
Cordova:
Cordova CLI       : 9.0.0<EMAIL_ADDRESS>Cordova Platforms : android 7.1.4, ios 5.0.1
Cordova Plugins   : cordova-plugin-ionic-keyboard 2.1.3, cordova-plugin-ionic-webview 4.0.1, (and 7 other plugins)
Utility:
cordova-res : not installed
native-run  : 0.2.5
System:
Android SDK Tools : 25.2.3 (/Users/aj/Library/Android/sdk)
ios-deploy        : 1.9.4
ios-sim           : 8.0.1
NodeJS            : v12.4.0 (/Users/aj/.nvm/versions/node/v12.4.0/bin/node)
npm               : 6.9.0
OS                : macOS Mojave
Xcode             : Xcode 10.2.1 Build version 10E1001

solved with 4.5.0 Boron

the screen is still locked with tabs

Any updates with this? Still unable to use Tabs, the cli, and framework are updated to the most recent 4.6.2. I can't scroll down to the bottom.

I also have this problem. Did you manage to get it fixed?

Thanks for not replying, was very helpful. If anyone encounters this issue I have resolved it, you can read my solution and explanation on StackOverflow here:

Sorry @JamesSlater I am just arriving back to the office from vacation, and make it an effort to not do anything work related while on vacation with my family. I still have the same issue, but, I found awork around by just placing buttons in the <ion-footer> that would act like tabs.

I have a similar problem.  I have a demo here where there are two tabs set up with the same SVG image and buttons to manually pan/scroll using scrollByPoint.  You may have to use the zoom in button to get pan/scroll to work at all but the pan/scroll works on the first tab only, but not the second tab.  It seems to only work on the initially loaded page when in tabs.  I've tried without tabs at all (it works), and tried with the pan/zoom page being another tab page and it doesn't work.
https://stackblitz.com/edit/ionic-v4-tabs-scrolling

You have to wrap it with ion-toolbar tag, it works for me, credits goes to this guy here
this ion-tabs scrolling inside ion-card element, instead of being fixed to bottom (Ionic 4) >> Answer: Update: Fixed this..
<ion-header no-border>
  <ion-toolbar>
    <ion-buttons slot="start">
      <ion-menu-button></ion-menu-button>
    </ion-buttons>
    <ion-title text-center> ¡Hola {{ userInfo.firstNames }}! </ion-title>
    <ion-button fill="clear" class="header-right" (click)="showNotifications($event)">
    </ion-button>
  </ion-toolbar>
</ion-header>
<ion-content>
  //stuff here
</ion-content>

<!-- \/ -->
<ion-toolbar>
  <ion-tabs>
    <ion-tab-bar slot="bottom">
      <ion-tab-button tab="tab1">
        <ion-icon name="flash"></ion-icon>
        <ion-label>Tab One</ion-label>
      </ion-tab-button>

      <ion-tab-button tab="tab2">
        <ion-icon name="apps"></ion-icon>
        <ion-label>Tab Two</ion-label>
      </ion-tab-button>

      <ion-tab-button tab="tab3">
        <ion-icon name="send"></ion-icon>
        <ion-label>Tab Three</ion-label>
      </ion-tab-button>
    </ion-tab-bar>
  </ion-tabs>
</ion-toolbar>

Thanks for not replying, was very helpful. If anyone encounters this issue I have resolved it, you can read my solution and explanation on StackOverflow here:

You have to wrap it with ion-toolbar tag, it works for me, thanks @JamesSlater

 ¡Hola {{ userInfo.firstNames }}!
<ion-button fill="clear" class="header-right" (click)="showNotifications($event)">

//stuff here

Tab One

  <ion-tab-button tab="tab2">
    <ion-icon name="apps"></ion-icon>
    <ion-label>Tab Two</ion-label>
  </ion-tab-button>

  <ion-tab-button tab="tab3">
    <ion-icon name="send"></ion-icon>
    <ion-label>Tab Three</ion-label>
  </ion-tab-button>
</ion-tab-bar>

Thanks for not replying, was very helpful. If anyone encounters this issue I have resolved it, you can read my solution and explanation on StackOverflow here:

Sorry @JamesSlater I am just arriving back to the office from vacation, and make it an effort to not do anything work related while on vacation with my family. I still have the same issue, but, I found awork around by just placing buttons in the <ion-footer> that would act like tabs.

You have to wrap it with ion-toolbar tag, it works for me, thanks @JamesSlater
<ion-header no-border>
  <ion-toolbar>
    <ion-buttons slot="start">
      <ion-menu-button></ion-menu-button>
    </ion-buttons>
    <ion-title text-center> ¡Hola {{ userInfo.firstNames }}! </ion-title>
    <ion-button fill="clear" class="header-right" (click)="showNotifications($event)">
    </ion-button>
  </ion-toolbar>
</ion-header>
<ion-content>
  //stuff here
</ion-content>

<!-- \/ -->
<ion-toolbar>
  <ion-tabs>
    <ion-tab-bar slot="bottom">
      <ion-tab-button tab="tab1">
        <ion-icon name="flash"></ion-icon>
        <ion-label>Tab One</ion-label>
      </ion-tab-button>

      <ion-tab-button tab="tab2">
        <ion-icon name="apps"></ion-icon>
        <ion-label>Tab Two</ion-label>
      </ion-tab-button>

      <ion-tab-button tab="tab3">
        <ion-icon name="send"></ion-icon>
        <ion-label>Tab Three</ion-label>
      </ion-tab-button>
    </ion-tab-bar>
  </ion-tabs>
</ion-toolbar>

 solves the problem

i am still having this issue, i added ion-toolbar outside ion-content with ion tabs inside it and  but the content does not show up at all, please check this:
https://forum.ionicframework.com/t/ionic-4-ios-scrolls-tabs-and-not-content-header-too/181139
https://forum.ionicframework.com/t/ionic-4-ios-scrolls-tabs-and-not-content-header-too/181139

Thanks for not replying, was very helpful. If anyone encounters this issue I have resolved it, you can read my solution and explanation on StackOverflow here:

Sorry @JamesSlater I am just arriving back to the office from vacation, and make it an effort to not do anything work related while on vacation with my family. I still have the same issue, but, I found awork around by just placing buttons in the <ion-footer> that would act like tabs.

You have to wrap it with ion-toolbar tag, it works for me, thanks @JamesSlater
<ion-header no-border>
  <ion-toolbar>
    <ion-buttons slot="start">
      <ion-menu-button></ion-menu-button>
    </ion-buttons>
    <ion-title text-center> ¡Hola {{ userInfo.firstNames }}! </ion-title>
    <ion-button fill="clear" class="header-right" (click)="showNotifications($event)">
    </ion-button>
  </ion-toolbar>
</ion-header>
<ion-content>
  //stuff here
</ion-content>

<!-- \/ -->
<ion-toolbar>
  <ion-tabs>
    <ion-tab-bar slot="bottom">
      <ion-tab-button tab="tab1">
        <ion-icon name="flash"></ion-icon>
        <ion-label>Tab One</ion-label>
      </ion-tab-button>

      <ion-tab-button tab="tab2">
        <ion-icon name="apps"></ion-icon>
        <ion-label>Tab Two</ion-label>
      </ion-tab-button>

      <ion-tab-button tab="tab3">
        <ion-icon name="send"></ion-icon>
        <ion-label>Tab Three</ion-label>
      </ion-tab-button>
    </ion-tab-bar>
  </ion-tabs>
</ion-toolbar>

this work for me , but ...  is the best solution?

Thanks for the issue. Is this still an issue with the latest version of Ionic Framework? If so, please provide a repo with the code required to reproduce this issue.


Windows support

I'd really like to install consul on my windows web servers.
Are there any plans to add windows support?
I'm pretty new to chef, and I'm not a windows expert. I'm debating how big of a task this would be.

start by looking at this
https://github.com/johnbellone/consul-cookbook/pull/154
you need to download the specific revision of this repo that supports windows and use chef to install and configure consul, have already tried this on chef 11.18.6 and windows 2012 standard x64


Appium: Providing .App throw's an error.

Using Appium Dotntet client V5 RC
The below works for Microsoft/WinAppDriver
Error:
OpenQA.Selenium.WebDriverArgumentException: 'Starting app 'Microsoft.WindowsCalculator_8wekyb3d8bbwe!App' with arguments '' threw an exception: An error occurred trying to start process 'Microsoft.WindowsCalculator_8wekyb3d8bbwe!App' with working directory '.'. The system cannot find the file specified.'
Steps to repro:
    private WindowsDriver _calculatorSession;
    protected static WebElement CalculatorResult;
    private string _appId = "Microsoft.WindowsCalculator_8wekyb3d8bbwe!App";

    [OneTimeSetUp]
    public void BeforeAll()
    {
        var appCapabilities = new AppiumOptions();
        appCapabilities.AutomationName = "Windows";
        appCapabilities.App = _appId;
        appCapabilities.DeviceName = "WindowsPC";
        appCapabilities.PlatformName = "Windows";

        var serverUri = Env.ServerIsRemote() ? AppiumServers.RemoteServerUri : AppiumServers.LocalServiceUri;
        _calculatorSession = new WindowsDriver(serverUri, appCapabilities,
            Env.InitTimeoutSec);
        _calculatorSession.Manage().Timeouts().ImplicitWait = Env.ImplicitTimeoutSec;

        _calculatorSession.FindElement(MobileBy.Name("Clear")).Click();
        _calculatorSession.FindElement(MobileBy.Name("Seven")).Click();
        CalculatorResult = _calculatorSession.FindElement(MobileBy.Name("Display is 7"));
        Assert.That(CalculatorResult, Is.Not.Null);
    }

@aristotelos I assume this should be fixed under FlaUI core Library?

@Dor-bl This can probably be fixed in FlaUI.WebDriver by calling Application.LaunchStoreApp. Should FlaUI.WebDriver tell Windows Store Apps apart by a regular expression?

I've created a PR that looks if the appium:app ends with !App and if so, launches it as a Windows Store app.


mkpr

Applied mkpr on package.json
sed s/"systemd": ">=.*"/"systemd": ">=244"/

Pull Request Test Coverage Report for Build 2448

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 96.509%

Totals

Change from base Build 2429:
0.0%

Covered Lines:
361

Relevant Lines:
375

💛  - Coveralls


Support libei for input emulation

libei is a new library for input emulation under wayland. (git repository)
The libeis, libei input server is to be user by the compositor. It will provide it with inputs the same way libinput does.
Possibly related to #1203.
Possible use-cases include:

Remote desktop
KDE Connect remote control
Synergy
Task automation and cross-compositor unit testing.
Sanboxed input emulation
Password managers?

It has some support from other compositor, and should provide some backwards compatibility with XWayland relatively soon, according to the blog post linked above.

We already have Wayland protocols for input emulation. I think libei should add support for those.
Closing because it doesn't make sense for a Wayland library like wlroots to add support for libei anyways. Compositors can do it on their own.

Thanks. At least this issue will document the answer :)
I thought that would belong to wlroots, as it already supports libinput.

it doesn't make sense for a Wayland library like wlroots to add support for libeis anyways. Compositors can do it on their own.

Yes, I basically agree here. The point of libei is that it is independent of the display manager, there is nothing Wayland-y about it.
Having said that, it's a separate communication channel for emulated input events, similar to how libinput is a separate communication channel for hardware input events. libeis' API is intentionally quite similar to libinputs API so you may want wlroots to map libeis events into the same events used internally (wrl_event) with e.g. a flag to indicate emulated input. But exactly where that merging of hw input events and emulated input events happens is up to the libeis consumers.


Annoying drop-down lists i Firefox

Scale, Standard and Type of gable I have to select twice for that the selected value should be what is displayed. I use Firefox.
Reported by Johan Dahlgren

After testing in Google Chrome, Microsoft Edge and Firefox, this only happens in Firefox.
Behaviour: When user selects an item in a drop down box, Firefox presents "Please, select". When you select the second time, you get the selected value. However, at the first select, the right value is assigned even is it's not displayed correctly, because you don't get a validation error when saving.

I will dig into this article later: https://stackoverflow.com/questions/58125929/blazor-how-to-use-the-onchange-event-in-select-when-using-bind-also to see if that works better across all browsers. There is an ongoing discussion of event triggering in Blazor on Firefox, so maybe this will be solved by Microsoft.

I have tested today and and can see that this error only occurs when selecting slowly. If I select fast, it works. This is one of the issues that I assume will be fixed by Microsoft in the long run.


Take up too much memory when using 0.18.0 to preprocess

I used 0.18.0 to re-preprocess our data for testing, which were all preprocessed with 0.16.0. I found that in 0.18.0, a single subject will take nearly 50GiB (yes, it is GiB) memory at very early stage. I do not see this in 0.16.0, so I think there maybe someting wrong? This is the few last lines of the log when I kill the process, it seems the N4-correct eating this much memmory, which is wired.
[Node] Finished "skulled_1mm_resample", elapsed time 1.692178s.
230707-10:34:45,458 nipype.workflow INFO:
[Node] Finished "raw_merge", elapsed time 2.675767s.
230707-10:34:46,673 nipype.workflow INFO:
[Node] Setting-up "qsiprep_wf.single_subject_BPM100_wf.anat_preproc_wf.anat_template_wf.n4_correct" in "/work/qsiprep_wf/single_subject_BPM100_wf/anat_preproc_wf/anat_template_wf/n4_correct".
230707-10:34:46,676 nipype.workflow INFO:
 [Node] Executing "n4_correct" <nipype.interfaces.ants.segmentation.N4BiasFieldCorrection>
and this is the command I use, the --low-mem or --mem-mb seems to be useless
docker run --rm -u 1005:1005 -m 8g -v /home/weiw/Desktop/data/Philip_data/all_data_preprocessed:/data \
-v /home/weiw/Desktop/data/Philip_data/all_data_preprocessed/qsiprep_result:/out \
-v /home/weiw/Desktop/data/Philip_data/all_data_preprocessed/temp_workdir/temp_${subj}_qsiprep:/work \
pennbbl/qsiprep:0.18.0 /data/BIDS /out participant --participant-label ${subj} --output-resolution 2 \
--fs-license-file /data/license.txt --denoise-method patch2self \
--unringing-method mrdegibbs --skip_bids_validation --low-mem \
--freesurfer-input /data/fmriprep_result/sourcedata/freesurfer \
--work-dir /work --hmc-model eddy --nthreads 4 > log_shell/qsiprep_${subj}_log.txt

Adding in synthseg and synthstrip has blown up the memory use in qsiprep. @weiwei-wch can you try adding --omp-nthreads 4?

the usage of memory is down, but the process will be killed if the swap limitaion reached (I guess?) when I  do parallel processing for several participants @mattcieslak . Below is the error message:
concurrent.futures.process.BrokenProcessPool: A process in the process pool was terminated abruptly while the future was running or pending.

the usage of memory is down, but the process will be killed if the swap limitaion reached (I guess?) when I do parallel processing for several participants @mattcieslak . Below is the error message: concurrent.futures.process.BrokenProcessPool: A process in the process pool was terminated abruptly while the future was running or pending.

I guess this was caused because I use the patch2self denoise method, when I switch to the default mrtrix dtidenoise, there is not too many swap spaces used.
And the patch2self mehod can be finished when I have enough resources, so the method is good, but the problem is that it is too expensive

patch2self will use a lot of memory if you're running in parallel. Have you run both the dwidenoise and patch2self? If so I'm curious if you have the head motion estimates from both

I think this should be fixed, please reopen if now


Non locale safe RFC 3339 time strings cause browsers to reject (date)time values

I believe this is a severe issue, as it causes browsers to reject datetime and time values when pages are served with affected locales.
InputTagHelper has definitions of RFC 3399 date and time formats, which use ":" as time separator. Unfortunately ":" is also .Net time separator, which gets different values depending on locale.
For example in it-IT locale, datetime-local was formatted as "2017-11-19T<IP_ADDRESS>" instead of correct format "2017-11-19T22:52:29.223".
This can be easily corrected by replacing time separator ":" with "\:" which results in fixed ":" without substitutions. I have provided fix with pull request #7066

@jbagga / @dougbu - can you take a look at https://github.com/aspnet/Mvc/pull/7066 and merge? This does sound broken.

Yes this is a bug. Good catch @avertes.

ee5535203e
Thanks again @avertes.