Add dependency for python3-psutil module

Signed-off-by: Jhon Honce<EMAIL_ADDRESS>

LGTM

@lsm5 Is this enough to get packaging working across platforms?

bot, retest this please

bot, retest this please

bot, retest this please

bot, retest this please

@rh-atomic-bot r+


Segmentation fault running Qt Qml app on WSL2 Ubuntu 22.04

Windows Version
Microsoft Windows [Version 10.0.22621.3007]
WSL Version
<IP_ADDRESS>
Are you using WSL 1 or WSL 2?

[X] WSL 2
[ ] WSL 1

Kernel Version
<IP_ADDRESS>-1
Distro Version
Ubuntu 22.04
Other Software
Qt 5.14
Qt 5.11
cmake version 3.28.3
clang version 17.0.6
Repro Steps
I have 2 WSL2 Ubuntu:

Ubuntu 18
Ubuntu 22
On Ubuntu 18, the same source code compiles and runs as expected. the Qt application starts and functions as expected.
On Ubuntu 22, the source code compiles, but fails to run as expected. the application ends in segmentation fault.

I updated WSL, updated Qt from 511 to 514, updated Clang to latest and still I get a segmentation fault on Ubuntu 22, not on Ubuntu 18!
Expected Behavior
a Qt window should appear
Actual Behavior
segmentation fault:
Diagnostic Logs
using gdb, this is the trace:
Thread 7 "display-service" received signal SIGSEGV, Segmentation fault.
[Switching to Thread 0x7fffc85fd640 (LWP 1185878)]
0x00007ffff6b6088d in std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >::_M_assign(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) () from /opt/Qt5.14.2/5.14.2/gcc_64/lib/libQt5Qml.so.5
(gdb) strace
warning: Couldn't determine the static tracepoint marker to probe
Static tracepoint 1 at 0x7ffff6b6088d
(gdb) bt
#0  0x00007ffff6b6088d in std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >::_M_assign(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) () from /opt/Qt5.14.2/5.14.2/gcc_64/lib/libQt5Qml.so.5
#1  0x00007fffce441c73 in ?? () from /usr/lib/wsl/drivers/iigd_dch.inf_amd64_5d2ade6d9728c861/libigc.so
#2  0x00007fffce1ca332 in ?? () from /usr/lib/wsl/drivers/iigd_dch.inf_amd64_5d2ade6d9728c861/libigc.so
#3  0x00007fffce1e9ef8 in ?? () from /usr/lib/wsl/drivers/iigd_dch.inf_amd64_5d2ade6d9728c861/libigc.so
#4  0x00007fffcb7bc9d0 in llvm::FPPassManager::runOnFunction(llvm::Function&) () from /usr/lib/wsl/drivers/iigd_dch.inf_amd64_5d2ade6d9728c861/libLLVM-9.so
#5  0x00007fffcb7bcacb in llvm::FPPassManager::runOnModule(llvm::Module&) () from /usr/lib/wsl/drivers/iigd_dch.inf_amd64_5d2ade6d9728c861/libLLVM-9.so
#6  0x00007fffcb7bbc2c in llvm::legacy::PassManagerImpl::run(llvm::Module&) () from /usr/lib/wsl/drivers/iigd_dch.inf_amd64_5d2ade6d9728c861/libLLVM-9.so
#7  0x00007fffce0449d1 in ?? () from /usr/lib/wsl/drivers/iigd_dch.inf_amd64_5d2ade6d9728c861/libigc.so
#8  0x00007fffce043a40 in ?? () from /usr/lib/wsl/drivers/iigd_dch.inf_amd64_5d2ade6d9728c861/libigc.so
#9  0x00007fffcdd52a50 in ?? () from /usr/lib/wsl/drivers/iigd_dch.inf_amd64_5d2ade6d9728c861/libigc.so
#10 0x00007fffcdd5d7c1 in ?? () from /usr/lib/wsl/drivers/iigd_dch.inf_amd64_5d2ade6d9728c861/libigc.so
#11 0x00007fffcdd4955d in ?? () from /usr/lib/wsl/drivers/iigd_dch.inf_amd64_5d2ade6d9728c861/libigc.so
#12 0x00007fffd0aceb4f in ?? () from /usr/lib/wsl/drivers/iigd_dch.inf_amd64_5d2ade6d9728c861/libigd12um64xel.so
#13 0x00007fffd0ac5680 in ?? () from /usr/lib/wsl/drivers/iigd_dch.inf_amd64_5d2ade6d9728c861/libigd12um64xel.so
#14 0x00007fffd0ac3e94 in ?? () from /usr/lib/wsl/drivers/iigd_dch.inf_amd64_5d2ade6d9728c861/libigd12um64xel.so
#15 0x00007fffd0ac056d in ?? () from /usr/lib/wsl/drivers/iigd_dch.inf_amd64_5d2ade6d9728c861/libigd12um64xel.so
#16 0x00007fffd0ae0f0f in ?? () from /usr/lib/wsl/drivers/iigd_dch.inf_amd64_5d2ade6d9728c861/libigd12um64xel.so
#17 0x00007fffd0adfb06 in ?? () from /usr/lib/wsl/drivers/iigd_dch.inf_amd64_5d2ade6d9728c861/libigd12um64xel.so
#18 0x00007fffd0ae0210 in ?? () from /usr/lib/wsl/drivers/iigd_dch.inf_amd64_5d2ade6d9728c861/libigd12um64xel.so
#19 0x00007fffe0d886c0 in ?? () from /usr/lib/wsl/lib/libd3d12core.so
#20 0x00007fffe0d88e0b in ?? () from /usr/lib/wsl/lib/libd3d12core.so
#21 0x00007ffff4a3fac3 in start_thread (arg=<optimized out>) at ./nptl/pthread_create.c:442
#22 0x00007ffff4ad1850 in clone3 () at ../sysdeps/unix/sysv/linux/x86_64/clone3.S:81

Thanks to the above AI bot, I was able to get the Qt application to run successfully by running the following command:
export LIBGL_ALWAYS_SOFTWARE=1
Cheers,
Simon


profiles documentation

Hi snakemakers! I don't think this is the right place to ask, but I am not sure where else to go. Is there an introductory explanation for beginners about how to set up a profile and specify resource requirements such as memory and walltime for each rule in a snakefile? Thank you!

Hi, I'm also just recently starting to convert all my cluster config to profiles and it has been quite a headache through trial and errors.
Documentation is the only place I've seen and it is very limited so not too helpful.
There are also some example profiles that one can learn by combing through codes. But a more detailed documentation and/or tutorial would certainly be helpful!


JsonSerializable

Recommitted from https://github.com/mathiasverraes/money/pull/81 because new features go against the nextrelease branch, and the original PR was giving to many conflicts.

wrong target branch


Provide Taskbar progress indicator in Terminal

Description of the new feature/enhancement
Provide OSC 9;4 sequence to provide status in Terminals for status.
Windows Terminal added support in https://github.com/microsoft/terminal/pull/8055 for https://github.com/microsoft/terminal/issues/3004 Taskbar progress indicator.

This seems like a fun little feature I could potentially contribute, provided that @JohnMcPMS hasn't already started working on this. Does this need a spec written first?

@chausner I see this as a small work item. I'd be open to a PR against this issue :)
We would love to have your support!

I have not, and I agree that it is both fun and should be a fairly small amount of work.
Watch out for how it handles cancellation with CTRL+C; a single signal should be able to end with the proper sequence but I don't know how the second one (where we just exit process) will be handled by Terminal.  Hopefully they track the source of this and end the progress when that process terminates.
I think we did want to get this in over the next two weeks, so please let us know if you've started it.

And since neither of us explicitly answered the spec question; no, I don't see this as needing a spec.

Okay great, please assign me to this issue and I'll try to have a first implementation ready by next week.

Watch out for how it handles cancellation with CTRL+C; a single signal should be able to end with the proper sequence but I don't know how the second one (where we just exit process) will be handled by Terminal. Hopefully they track the source of this and end the progress when that process terminates.

I did a quick test with
> python
print("\x1b]9;4;2;40\x1b\\")
quit()

and Terminal did not reset the progress on the task bar after the Python process exited. So when the winget process exits abnormally and if there is no event that would notify us before the process exit, there is probably no way to reset the progress. But normally, winget should not exit unexpectedly, right? And in the case of normal exit, we can always reset the progress.

The only "expected" exit would be the second CTRL+C, where we terminate the process because cooperative cancellation didn't happen fast enough for the user.  We could probably even handle it in that case, but only of there is a clean "turn off progress" sequence.  I think it is fine to leave that as future work since most places where we are in a progress state should also be the best at cancellation.


catalog item accepts remove_resources option

Choosing retirement entry is based on :remove_resources option in the config_info
https://www.pivotaltracker.com/story/show/141500781
@miq-bot assign @gmcculloug
@miq-bot add_label providers/ansible_tower
@miq-bot add_label enhancement
@miq-bot add_label service
@miq-bot add_label euwe/no
@tinaafitz please review

@bzwei Looks good.

Look good.


Added pomodoro activity

I have created a pomodoro activity for sugarizer, it looks like this.

Pomodoro is a productivity method. More about this: https://en.wikipedia.org/wiki/Pomodoro_Technique
What I have done.

[x] created basic pomodro activity
[x] An icon for pomodoro
[x] Ability to create custom timers.

Hi @sanatankc, this looks great, thanks a lot!
@llaske let me know if I can take the initiative to merge this kind of PRs.

I have added controls for Pomodoro to change Work and Break Sessions.
Here's how it looks like after adding controls.

I hope it this pull is ready to be merged. 😊

Very nice activity. I just wonder if it's pertinent for children between 6 to 12: the target for Sugar platform. Do you have experience on using this method for children ?
Two more technical remarks:

Use a more Sugar compatible icon for the activity: should be adaptable to the user colors
Could you integrate localization using the included webL10n.js library

I don't have experience of using this method on children. It is the productivity method. I have read some articles which suggests it helps kid by giving them reward or something during break.

I will look into icon issue.
I honestly don't much about localization but I will try to learn about it and implement it.

Thanks!

The icon doesn't match prerequisite of Sugar icons to allow an auto colorize with user colors. See here for more or look how other activities icon are made. May be you could increase size of the tomato border.
Regarding localization we're using webL10n.js library. Look for example Moon activities to see how you could use it.
One question: not sure to understand how Work and Break work: you've got X minutes on work then Y minutes of break?

Yes Break and Work works precisely like that. You've got x minutes to work and then you got y minutes of break in which you can relax. and after that again work and so on.

But why it's not possible to have more than 1 minute of break?
May be it could be nice to use user colors into the activity: why not for example use the foreground for the work and the background for the break. What do you think ?
Like I said for the Game of Life, it should be interesting to use the datastore to save the context of the activity so the user could find counters in the same state.
May be adding a toolbar button to reinit could be nice too.

But why it's not possible to have more than 1 minute of break?
Confirmed, it was a bug.
May be it could be nice to use user colors into the activity: why not for example use the foreground for the work and the background for the break. What do you think ?
I was thinking about that, and I implemented it.
May be adding a toolbar button to reinit could be nice too.
Done.
Like I said for the Game of Life, it should be interesting to use the datastore to save the context of the activity so the user could find counters in the same state.
For some reason every time datastore get gives me null as data, even though I can clearly see it in chrome devtools. Setting and Getting with native localstorage worked just fine, because I thought it might not work in sugarOS.

Hmmm, strange. You right, your record seems correct in the datastore. Try to see what happens during datastore.loadText().
BTW it show that something is wrong in your source code.
I'm sorry to say that you should not use the ES6 syntax "=>" in your code. Unfortunately, all browsers do not support this syntax, specifically on iOS. So, I must ban this syntax from Sugarizer to ensure a maximum of portability. Could you make the change?

I've tested more. data is not null on my side so I've got an issue:
activity.js:44 Uncaught ReferenceError: stateFromLocal is not defined
    at datastore.loadAsText (activity.js:44)
    at DatastoreObject.loadAsText (sugarizer.js:131)
    at main (activity.js:41)
    at window.addEventListener (activity.js:11)
    at fireL10nReadyEvent (webL10n.js:114)
    at onResourceLoaded (webL10n.js:319)
    at webL10n.js:280
    at XMLHttpRequest.xhr.onreadystatechange (webL10n.js:131)

stateFromLocal is not declared in the context. I guess it was something that you've not finished yet.
But I don't understand why data is null in your context.

Didn't know that. I will use Babel to compile all files in Es5 because I am using many ES6 features.

Cool it's nice to use the user color.
BTW still an issue, due to datastore: all values are "undefined" after datastore load.
Guess it's the same issue than in your other activity

Still few issues:

Reload of a saved activity doesn't work. It's related to the with the JSON.parse() in the loadText method. If you don't stringify into the saveText, you don't need to parse
When the counter is reload an the play button is push, the counter restart from the beginning instead of continue
When the counter is paused and the reinit button is clicked, nothing happen

I have fixed almost all visible errors, and dataStore is working fine now.

Very good work. I'm going to test it on mobile platforms and merge it.
Thanks.

Merged in https://github.com/llaske/sugarizer/commit/0394f80e7ad1ae06df4894f06bf9deb9c050cd01


no customer support

been trying to reach customer support for weeks. changed to new iphone. 2FA didnt transfer over. now it wont let me remove 2FA. please help. reached out multiple times to support

Dang!! The more popular the more issues

Did you resolve your issue? You can remove 2FA with security questions you have.

Like bitconnectcoin said, you can use the security questions now to bypass the 2FA.
Login with your user name and password
When the 2FA screen challenges you, click on the link that says Remove G2FA in the lower right-hand corner.  You will be presented with security questions.  If you didn't write them down or forgot them, it's your fault.  Sorry!
Whenever, you use 2FA anywhere, ALWAYS write down the backup key.  ALWAYS!  Some people even take pictures of the QR code and store them in a safe.  Do not leave a picture of a QR code on your computer or cloud backup.  Always write down security questions and secret pins and store multiple copies of them in multiple places.
Also, a warning for anyone using GOOGLE 2FA.
The Google authenticator app does not backup all of the 3rd party websites' codes.  If you move to a new phone or get locked out, the Google app will only restore the code for the Google website only.  You will need the backup codes on paper to reinstall the application properly or you will need to use another application like Authenticator Plus or Auth since they make backups.  Google 2FA can cause problems in the future SO BE PREPARED!


Fix slru_segment_key_range function: segno was assigned to incorrect Key field

A regression test would be nice

A regression test would be nice

I wonder what kind of test do you expect?
Unit test which  checks that this function produce correct interval?
Or test for deletion of SRU segments?
I do not know how to force Postgres to truncate for example CLOG segment in some reasonable amount of time.
I run pgbench during 1000 seconds and then try to get status of transaction preceded this pgbench iteration (using txid_satus)
and it still reports correct status.

According to the problems with forcing CLOG truncation (see https://neondb.slack.com/archives/C033RQ5SPDH/p1674037379794899) I failed to create some meaningful test for this fix.
But frankly speaking I consider this bug just as mistyping and do not think that we need some separate test exactly for  srlu_segment_key_range function.
Moreover I wonder do we need this Key structure with this obscure fieldN fields at all?
May be just replace it with i128?
We in any case are using i128 representation of key in layer map.
I expect that replacing struct with scalar type will save some memory allocations and memcpys...

@knizhnik
do we need to add some handling around slru_segment_key_range calls` for already existing incorrect keys ?
What will happen, if we mix both "old-format" and "new-format" keys in one call? Or it is an impossible situation?

This function is used only by delete when SLRU is truncated. So there are no bad keys stored in the storage.
Truncation of CLOG happens only after 200M transactions and this is why nobody of  our customers still suffer from this bug.
But sooner or latter it will definitely happen. And it can happen that all CLOG segments will be deleted as result of such truncation.  In this case all user database will be lost because accessing it without CLOG is problematic.

Sounds like that would be easily reproducible. Can we add a test like that to the test suite?

Do you know fsater way to perform 200M transactions than our test_runner/sql_regress/sql/neon-clog.sql:
create or replace procedure do_commits() as $$
declare
    xid xid8;
	i integer;
begin
    for i in 1..200000000 loop
	    xid = txid_current();
		commit;
		if (pg_xact_status(xid) <> 'committed') then
		   raise exception 'CLOG corruption';
		end if;
	end loop;
end;
$$ language plpgsql;

call do_commits();

But it takes about half an hour for this test to perform 200M transactions.
And yes, I can confirm that after i CLOG is lost.

Should we have an issue for the test? Otherwise we can easily lose it (cc @vadim2404)


LV_Arduino-3.0.1 esp32 add xpt2046 with a parallel screen

I had a question I have the ESP32 and have a parallel screen ssd1963 with tft espi working, but I want to add the xpt2046 to work for the example to test out. because tft esp lib can’t handle for now the spi xpt2046 together with a parallel screen. How can I add the touchscreen and how can I calibrated it ? Also I saw that ssd1963 could be use directly in lvgl with the LV_drivers package how does that work. but my main question for now is the xpt2046 can work together with the tft esp parallel screen handeling.
try to add this lib for xpt2046 from https://github.com/lvgl/lv_drivers but during compiling I got an error in Arduino. lv_arduino-3.0.1\indev\xpt2046.c:13:30: fatal error: drv_XPT2046.h: No such file or directory
What do I miss here? I am now trying the ESP32_TFT_eSPI_slider test
I change this in the initial input device driver
indev_drv.read_cb = XPT2046_read;
I get it as error so I also check in the XPT2046.c but couldn’t find it. So that is why I am also asking it or maybe possible it doesn’t work with it. still unknown for me how to add the xpt2046 driver in the simple slide example.
In file included from C:\Users\XX\AppData\Local\Temp\arduino_modified_sketch_902530\ESP32_TFT_eSPI_Slider.ino:4:0:
c:\users\XX\downloads\arduino-1.8.12\arduino-1.8.12\libraries\lv_arduino-3.0.1\indev\xpt2046.c:13:30: fatal error: drv_XPT2046.h: No such file or directory
compilation terminated.
exit status 1
Error compiling for board ESP32 Dev Module.
Already thak you for your reply.

This repository is obsolete (as written in the readme) so please use lvgl as described here https://github.com/arduino/Arduino/issues/10592 and post your question about touch panel to the forum here https://forum.lvgl.io/ .

@Pablo2048  I posted a question add https://forum.lvgl.io/ but no response there https://forum.lvgl.io/t/lv-arduino-3-0-1-esp32-add-xpt2046-with-a-parallel-screen/3566/6 so that is why I asked it here.

@CrocKlok I've answered on the forum.


⚠ Economy API Endpoint has degraded performance

In 10a56b7, Economy API Endpoint (https://economy.roblox.com) experienced degraded performance:

HTTP code: 200
Response time: 1536 ms

Resolved: Economy API Endpoint performance has improved in 580661c.


Skull Data Values are not working

If you try to spawn a mob head/skull with terrain control it will always spawn the skeleton skull no matter if the data value is set to other's mob skull

It was a TC bug. Author fixed the bugs.Here is the fixed version:
http://build.mctcp.com/job/TerrainControl - Master - Gradle/162/default/


wrap the display window

I want enable wrap the display window of vim-clap, when i set
autocmd User ClapOnEnter call g:clap.display.setbufvar('&wrap', 1)

but it's no affect. Anyone can help me? I use gvim for windows.

The right way to set wrap for vim popup seems to use popup_setoptions(), this should work.
autocmd User ClapOnEnter call popup_setoptions(g:clap.display.winid, {'wrap': 1})


Hex does not include the telemetry dependency

In the telemetry_poller hex 0.4.0 release its does include the telemetry dependency.
The version 0.3.0 includes.
The problem is when we add the telemetry_poller and has an older version of telemetry, like 0.3.0, it will not have a dependency issue, it will run and them crash, since the telemetry:execute/3 change its api.

It seems we do list telemetry as a dependency in rebar.config though. @arkgil, do you have any idea what may have happened?

Yeah, that's strange. Rebar3 correctly lists telemetry as a dependency, even in docs profile we use to publish the package. I'll investigate.

@CaiqueMitsuoka can you provide a mix.exs/rebar.config file which causes this problem? I was able to reproduce, however I'm not sure if I hit exactly the same problem as you did.

@josevalim funny thing is that for Poller we pin Telemetry version using ~> syntax:
https://github.com/beam-telemetry/telemetry_poller/blob/master/rebar.config#L3
However, I'm not really sure if it's a valid rebar3 dep specification.

@arkgil that is right.
But somehow it was published without the dep https://hex.pm/packages/telemetry_poller/0.4.0

@arkgil afaik its is valid syntax the ~>, I think hackney uses just fine.
I've create an example app, here is the mix.lock if you just run the iex -S mix you will get the error of poller calling telemetry:execute/3 with bad args.

This will cause it to get 0.3.0, right? https://github.com/CaiqueMitsuoka/telemetry_dep_example/blob/master/mix.exs#L24
But telemetry_pollerdoes need to be published again so it picks up the dependency on telemetry 0.4.0.

I remember that we had to publish the docs again (the audit log confirms that), so I wonder if something goofy happened. Seems like republishing should correct it.

When publishing rebar3 will output the dependencies before it asks you Y/n if you want to continue. Be sure to see if it does that, in case it does include it there but still doesn't include it in the actual published packages. And of course if it isn't listed in that output something is also wrong.

So hackney is using the ~> syntax but I noticed that it doesn't have a space like Elixir uses. Could that be the cause? I would have thought the behavior would be the same in both langs now.
I don't have a commit bit.

Yes @tsloughter, basically the situation is when some dependency lock a version other than 0.4 and poller crash only on runtime.

Let's just ship a new patch version and see if this time the proper deps will be pushed to Hex?

So I checked what would happen if I published it and indeed it shows no deps for me?
$ ~/.mix/rebar3 hex publish
===> Verifying dependencies...
===> Using deprecated rebar_utils:vcs_vsn/3. Please upgrade your plugins.
Publishing telemetry_poller 0.4.1
  Description: Periodically collect measurements and dispatch them as Telemetry events.
  Dependencies:

  Included files:
    /Users/jose/OSS/telemetry_poller/LICENSE
    /Users/jose/OSS/telemetry_poller/NOTICE
    /Users/jose/OSS/telemetry_poller/README.md
    /Users/jose/OSS/telemetry_poller/rebar.config
    /Users/jose/OSS/telemetry_poller/rebar.lock
    /Users/jose/OSS/telemetry_poller/src/telemetry_poller.app.src
    /Users/jose/OSS/telemetry_poller/src/telemetry_poller.erl
    /Users/jose/OSS/telemetry_poller/src/telemetry_poller_app.erl
    /Users/jose/OSS/telemetry_poller/src/telemetry_poller_builtin.erl
    /Users/jose/OSS/telemetry_poller/src/telemetry_poller_sup.erl
  Maintainers:

  Licenses: Apache 2.0
  Links:
    Github: https://github.com/beam-telemetry/telemetry_poller
  Build tools: rebar3
Before publishing, please read Hex CoC: https://hex.pm/docs/codeofconduct
Proceed? ("Y")>

$ rebar3 version
rebar 3.12.0 on Erlang/OTP 22 Erts 10.4

$ rebar3 plugins upgrade rebar3_hex
===> No upgrade needed for rebar3_hex

It seems my rebar3_hex version was out of date, but even after an upgrade the issue persists:
$ ~/.mix/rebar3 plugins upgrade rebar3_hex
===> No upgrade needed for rebar3_hex
===> No upgrade needed for hex_core
===> No upgrade needed for verl

Running on v6.5.0 now.

@arkgil I have pushed the tag and master, can you please ship a new release? I am unsure how to fix my rebar. :(

@josevalim done!

Its working perfectly, thanks all of you ❤


Reordering @preconcurrency imports should be suppressed even if they're in #if conditions

@preconcurrency imports need to come before future modules that also export them (without @preconcurrency). swift-format avoids reordering these, except if they are behind compiler guards. In particular:
#if canImport(Glibc)
@preconcurrency import Glibc
#endif
import Foundation

When formatting, swift-format will move Foundation first:
import Foundation

#if canImport(Glibc)
@preconcurrency import Glibc
#endif

This breaks the effect of @preconcurrency, so we shouldn't do this transformation.

Synced to Apple’s issue tracker as rdar://136999610

I don’t think the order of imports should matter for anything. Would you mind also filing an issue to https://github.com/swiftlang/swift/issues/new/choose with an example where the import order does matter?

Ok, filed as https://github.com/swiftlang/swift/issues/76842


PowerShell Gallery Exception Fails Pester Test Runner Task

Azure DevOps Extension you are using
Pester Test Runner
Where are you running it?

Azure DevOps Service (VSTS)

Version of Extension/Task
8.13.3
Expected behaviour and actual behaviour
When there is problem communicating with the PowerShell Gallery to download the latest version of Pester and an exception is generated, the task fails. The bundled/fallback version is used and the Pester tests still complete, but the exception still causes the task to fail.

Steps to reproduce the problem

This should be fixed now with release 8.14.5


Reproducible issue leveraging notebook opened from folder in a git repo

Issue Type: Bug
I have the same experience on 3 machines now with the latest Azure Data Studio (Macbook - Catalina, SurfaceBook Win10, Dell T7600 Win10).
I created a notebook, everything works.
Pushed the notebook into git.
Opened folder in ADS, via a git repo, and tried to run the notebook again, and unexpected errors occur.
I click on File->New for a new notebook, using the same connection and I can run the new notebook fine.
Azure Data Studio version: azuredatastudio 1.16.1 (16801c522df68e63218b39ccb5b4a7431f9bf667, 2020-03-23T22:08:06.892Z)
OS version: Windows_NT x64 10.0.19603

System Info

Item
Value

CPUs
Intel(R) Xeon(R) CPU E5-2620 0 @ 2.00GHz (24 x 1995)

GPU Status
2d_canvas: enabledflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onoop_rasterization: disabled_offprotected_video_decode: unavailable_offrasterization: enabledskia_renderer: disabled_off_okvideo_decode: enabledviz_display_compositor: enabled_onviz_hit_test_surface_layer: disabled_off_okwebgl: enabledwebgl2: enabled

Load (avg)
undefined

Memory (System)
63.93GB (46.55GB free)

Process Argv

Screen Reader
no

VM
0%

Extensions: none

Can you detail what errors that you're seeing, @danmanrique? It's a little hard to see from your screenshot.
If you open the Developer Tools (Help --> Toggle Developer Tools), and go to the Console, are there any errors printed there after you repro the issue?

Closing issue as we need more info here. Feel free to reopen with more details if this still reproes.


improve fields parsing performance by eliminating temp strings.

improve parser performance by statically precompiling regex

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area API-version

/area build

/area CI

/area driver-kmod

/area driver-bpf

/area driver-modern-bpf

/area libscap-engine-bpf

/area libscap-engine-gvisor

/area libscap-engine-kmod

/area libscap-engine-modern-bpf

/area libscap-engine-nodriver

/area libscap-engine-noop

/area libscap-engine-source-plugin

/area libscap-engine-savefile

/area libscap-engine-udig

/area libscap

/area libpman

/area libsinsp

/area tests

/area proposals

Does this PR require a change in the driver versions?

/version driver-API-version-major

/version driver-API-version-minor

/version driver-API-version-patch

/version driver-SCHEMA-version-major

/version driver-SCHEMA-version-minor

/version driver-SCHEMA-version-patch

What this PR does / why we need it:
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:

NONE

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: VadimZy
Once this PR has been reviewed and has the lgtm label, please assign andreagit97 for approval by writing /assign @andreagit97 in a comment. For more information see:The Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Thanks for your pull request. Before we can look at it, you'll need to add a 'DCO signoff' to your commits.
:memo: Please follow instructions in the contributing guide to update your commits with the DCO
Full details of the Developer Certificate of Origin can be found at developercertificate.org.
The list of commits missing DCO signoff:

c94ae85 improve fields parsing performance by eliminating temp strings.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Also, please sign-off your commits (https://github.com/falcosecurity/.github/blob/master/CONTRIBUTING.md#developer-certificate-of-origin). Thanks Vadim!

This looks like a great set of changes! While we're in here mucking with regexes, what do you (and other reviewers) think about using RE2 instead of c++ regex? I believe all of these are compatible with RE2 (e.g. don't backtrack) and from what I recall, including https://github.com/HFTrader/regex-performance, RE2 appears to be much much faster.

Thanks for your pull request. Before we can look at it, you'll need to add a 'DCO signoff' to your commits.
:memo: Please follow instructions in the contributing guide to update your commits with the DCO
Full details of the Developer Certificate of Origin can be found at developercertificate.org.
The list of commits missing DCO signoff:

c94ae85 improve fields parsing performance by eliminating temp strings.
048338b -regex changes dropped

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Thanks for your pull request. Before we can look at it, you'll need to add a 'DCO signoff' to your commits.
:memo: Please follow instructions in the contributing guide to update your commits with the DCO
Full details of the Developer Certificate of Origin can be found at developercertificate.org.
The list of commits missing DCO signoff:

c94ae85 improve fields parsing performance by eliminating temp strings.
048338b -regex changes dropped
7d1fc0d -regex changes dropped

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Thanks for your pull request. Before we can look at it, you'll need to add a 'DCO signoff' to your commits.
:memo: Please follow instructions in the contributing guide to update your commits with the DCO
Full details of the Developer Certificate of Origin can be found at developercertificate.org.
The list of commits missing DCO signoff:

db2977f - improve falco parsing performance by eliminating temp strings

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/ok-to-test

@mstemm

While we're in here mucking with regexes, what do you (and other reviewers) think about using RE2 instead of c++ regex?

I think it  would quite beneficial to have a portable REGEX in Falco/Libs

While we're in here mucking with regexes, what do you (and other reviewers) think about using RE2 instead of c++ regex?

I think that would be a very good contribution in our case. Regex inconsistency makes our code troublesome and harder to maintain. We'll need to open separate PRs and track the progress in an issue eventually.

LGTM label has been added.  Git tree hash: 3f057211ddf02873415d027b14a51d4735d9df69

FYI the regex portability problem has been addressed in https://github.com/falcosecurity/libs/pull/556.

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: FedeDP, VadimZy
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [FedeDP]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


type_object: fix new clippy complaint about length of doc comment

On beta/nightly:
warning: first doc comment paragraph is too long
  --> src/type_object.rs:19:1
   |
19 | / /// `T: PySizedLayout<U>` represents that `T` is not a instance of
20 | | /// [`PyVarObject`](https://docs.python.org/3.8/c-api/structures.html?highlight=pyvarobject#c.PyVarObject).
21 | | /// In addition, that `T` is a concrete representation of `U`.
   | |_
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_long_first_doc_paragraph
   = note: `#[warn(clippy::too_long_first_doc_paragraph)]` on by default

I lumped another very minor fix in this...


ci: remove ubuntu-18.04 due to GH action support deprecation

https://github.blog/changelog/2022-08-09-github-actions-the-ubuntu-18-04-actions-runner-image-is-being-deprecated-and-will-be-removed-by-12-1-22/

Ah, I see. I assume this is setup w/2 different test jobs because Ubuntu 22.04 doesn't have Python 3.6? If we drop Python 3.6 (pretty old at this point) then we could collapse those into the same matrix/job.

Ah, I see. I assume this is setup w/2 different test jobs because Ubuntu 22.04 doesn't have Python 3.6? If we drop Python 3.6 (pretty old at this point) then we could collapse those into the same matrix/job.

Yeah, I just re-read the thread in that PR where we discussed that. It works fine atm so I don't think we need to worry about it. I hope sentinel won't be necessary at all by the time 20.04 moves out of support :crossed_fingers: :sweat_smile: @PastaPastaPasta when sentinel functionality in Core?!?


Skip ITs in Travis build

I have been seeing lots of Travis builds time out lately.  Thinking it may be best to skip ITs for the Travis build.

The build ran faster, but mini accumulo still started.   I looked into skipping it if skipITs is set but maven does not support activation based on multiple properties.

It already skips when skipTests is set.  Seems there is no easy way to skip when skipTests or skipITs is set.

Looking into this a little more I see a lot of test are failing at Running org.apache.fluo.integration.client.FluoAdminImplIT so I am going to look into that test

So, I'm not a fan of skipping ITs in Travis CI for a few reasons:

It means less testing,
It encourages more ITs over UTs when a faster UT would be appropriate, simply because we aren't as aware of the running cost ITs have as we would be if they ran all the time, and
It's most likely indicative of a bad test.

I think we should try to find a way to make the ITs work in Travis.
As for skipping the accumulo-maven-plugin, it's probably best to tie that to -DskipITs, rather than -DskipTests anyway. Also, could just use the built-in -Daccumulo.skip property.

I am not a fan of SkippingITs either as long as we can get the to run reliably.  I will make an attempt to get them to run reliably.  However, if ITs are causing the travis build to regularly fail then it makes automated PR testing useless.
We could skip them for now.  Personally, I think having builds that run reliably is better than having builds that run sometimes and test more.

Fixed by #959

I'm very glad we didn't have to skip them and you were able to find the problem by reproducing in a local Docker container. Kudos to you for the work you did on finding that.


🌱 Replace jetstack from cert-manager URL and update version to v1.5.3

/test-v1b1-ubuntu-integration

I was surprised to see tilt_modules here in the repo. My understanding is that these should most likely be put in .gitignore like node_modules and similar.
The content in the cert_manager tilt module is coming from here. So if we update the files in our repo I guess they will just be overridden when we run tilt up. Or maybe I'm missing something?

I do not know TBH how this is working, I am just updating the reference URL and version here.

I do not know TBH how this is working, I am just updating the reference URL and version here.

I think it will have no effect but I'm fine with merging it. I have created an issue upstream so they will hopefully update it there also soon. Will also try to find out if tilt_modules should be included in git or not.

/test all


[maps-geolocations-rest][test] Authentication should work with AAD authentication failing

Looks that this test has been failing since the beginning.
latest run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=2187391&view=logs&j=49bb90fd-ec2d-5416-ef10-2a6d86fff2c7&t=b3b4cfd7-3453-5920-bad4-3d8acc30f0d2&l=84 (MS INTERNAL)

Thanks @jeremymeng, we're investigating the issue. Thank you!


Could I use the model 't5' when I fine tune with lora.py?

Could I use the model 't5' when I fine tune with lora.py?

The MLX LM doesn't support T5 for fine-tuning. But you could adapt the lora script to work with the T5 example.  We will probably not add it here, but getting it to work should not be too difficult.. all the pieces are there, just need to combine them.

to w

Thanks a lot.


Support for non-rubygems vulnerabilities

Appears that you get rubygem vulnerabilities by way of GHSA  database feed.
Do you have support for the rubies (ruby-lang.org, jruby.org, mruby.org) languages?
Thanks.

I assume you're asking about checking the version of Ruby itself? That is not supported currently, mainly because afaik neither the osv.dev or GitHub advisory databases contain entries for Ruby - in terms of parsing, it would be trivial to have the Gemfile.lock parser support parsing the RUBY VERSION block for the actual version.

Example: https://github.com/advisories/GHSA-w9fp-2996-hhwx

yeah, those exist but are not actually in the database since they're marked as unreviewed - that's because the osv spec doesn't have a way of representing things like "ruby the language/sdk" so the advisory itself has no affected data meaning there's nothing osv-detector can do (since it needs that to be able to match the advisory).
ruby-advisory-db is not using the OSV specification for its entries, so its not directly compatible, though they do have versions so you should write a script to create OSVs from their entries, and use that as a custom database](https://github.com/G-Rath/osv-detector#extra-databases) then passing in the Ruby version(s) as a as a CSV (I've been playing with something similar for doing end-of-life checks).

Example: GHSA-w9fp-2996-hhwx

I tried to review them but they do not have a required "ecosystem" value for non-rubygems. Go
to the bottom right corner of the above advisory and click on "improve..." and click on
"Ecosystems" to see.
I have 11 GHSA "rubygems" PRs approved or merged in the last few weeks.

In that case those advisories will be reported by osv-detector - the exception is advisories for Ruby itself since that isn't a gem; if you have gotten an advisory for a Ruby SDK reviewed then I think it would make sense for osv-detector to start parsing the Ruby version from Gemfile.lock and include it as a "package" in its output (at least until the OSV spec decides how to handle those kind of vulnerabilities)

Also found a few GHSA adversaries that were just ruby application code and pointed to a specific repo to demo it.

Duplicated issue on osv-schema repo: https://github.com/ossf/osv-schema/issues/123

Move this issue to osv-schecma repo: https://github.com/ossf/osv-schema/issues/123


Development: Update Spring Boot to 3.4.0

Checklist
General

[x] I tested all changes and their related features with all corresponding user types on a test server.
[x] I chose a title conforming to the naming conventions for pull requests.

Server

[x] Important: I implemented the changes with a very good performance and prevented too many (unnecessary) and too complex database calls.
[x] I strictly followed the server coding and design guidelines.

Motivation and Context
We want to use the latest versions to keep the code modern, stable and secure
Description
Update Spring Boot and related dependencies to the latest version
Steps for Testing
Go through the whole app and test all kinds of functionality. Everything should be exactly the same as before
Testserver States

[!NOTE]
These badges show the state of the test servers.
Green = Currently available, Red = Currently locked
Click on the badges to get to the test servers.

Review Progress
Code Review

[ ] Code Review 1
[ ] Code Review 2

Manual Tests

[x] Test 1
[ ] Test 2

Summary by CodeRabbit

New Features

Enhanced mocking capabilities for Jenkins job permissions in various test classes.
New methods added to the ProgrammingExerciseTestService for importing programming exercises and managing repository access.

Bug Fixes

Improved error handling in tests related to programming submissions and exercise creation.

Refactor

Updated annotations from @SpyBean to @MockitoSpyBean across multiple classes to align with updated mocking practices.

Documentation

Clarified guidelines and comments regarding the use of Mockito in tests.

Tested exercise submissions, plagiarism detection, tutorials and learning path generation. The latter seems to trigger the following 500 error on initial request. Does not seem to be related to the upgrade though:


Apple CarPlay has broken

I have a MIB2 HIGH unit, after installing the MIB2 High toolbox and applying the Ignore navigation-active status from smartphone patch, Apple Carplay stopped working, the iPhone sees it, but does not start. Moreover, Android Auto works properly. iOS is the latest up-to-date, the cable is native, working and tested on another car.
Can I somehow fix it or roll it back to working condition?

Can you share the brand / version (train) of firmware running on your unit?
The carplay Java code in particular seems to differ more than most between versions of mib firmware.
Currently the only way to disable the patch is via console, eg. SSH / Telnet
https://github.com/jilleb/mib2-toolbox/pull/189#issuecomment-1004448576
https://github.com/jilleb/mib2-toolbox/wiki/SSH-Login
I really should add another menu item to disable it from gem...

As long as I remember version  MHI2_ER_VWG11_K3332_MU1187

Ah, that means your unit would be compatible with MHI2_ER_VWG11_K3342_MU1427 which is the version i developed with, upgrading to that would be a great way forward. You could get more assistance with that if needed on the telegram channel https://t.me/joinchat/T_pADdwJyUXq0VoH

I had the same issue but on an older FW version. MHI2_ER_VWG11_S2125.
Installing the ignore active smartphone navi patch broke the carplay alltogether.
I've since upgraded to a MU0814 and then to MU1427 FW where on both versions the carplay is working just as it's supposed to. But I have been hasitant to apply the patch on the latest FW even though it is a version you developed it for in a fear it might break the carplay once again.
I do not have a dlink adapter so I guess I would have to find someone who would be able to fix it for me.
If there was a "undo" patch as you have mentioned that would be great and I would feel much more comfortable applying the patch.

Went from MHI2_ER_VWG11_S2125 to K3342 then patched.
This patch works for AA but not for Carplay, same issue as with original poster

The uninstall script works and fixes Carplay.

Is there any way to make this work on MHI2_ER_VWG11_S2125 for both AA & Carplay? This patch is the main reason why I want to install this mod.

@adrianmihalko I don't think it will be possible to support such an old firmware, much better if you can update the firmware on your unit first.

@adrianmihalko I don't think it will be possible to support such an old firmware, much better if you can update the firmware on your unit first.

Thank you. Somehow I need to find a way how to upgrade my SW. Unfortunately I have have no one around me who would be help me with that.

Hello, is there any changes or way how to make it work…? Same problem here…

Before we have this fw and it does same problem, that carplay wont work anymore (tried different phones). So decided to update to k3342 without any change…

@dandamc you've got MHI2_ER_VWG11_K3342_MU1427 which is the same MU version as my unit I developed on, so it should work there. What exact problem are you seeing, can carplay not connect at all? Or does maps start but the navigation stuff not work?
The older 0814 definitely will not have worked, but the upgrade the 1427 should have fixed it. Perhaps try uninstall of the patch in the toolbox menus, then install it again.

@andrewleech the problem is that after ignore navigation status patch carplay doesnt start anymore. It shows you that you connected phone but it comes with info that connection cant be eastablished… when i go to gem and uninstall patch of ignore navigation data then it comes back to work after mu restart…

@dandamc that's strange and unfortunate, perhaps there's some other setting/adaptation enabled on your unit that breaks the patch.
The only way to diagnose issues like this is via Java Logging which is a bit harder to get to. The best method I've come up with so far is quite manual, documented here: https://gitlab.com/alelec/mib2-lsd-patching/-/wikis/home
I'm hoping to add a function on toolbox to do this automatically, hasn't happened yet though.

I also reflashed MIB2 with the firmware you suggested MHI2_ER_VWG11_K3342_MU1427. The situation has not changed CarPlay also does not start. I applied and removed the patch several times and nothing changes. Moreover, Android Auto with the patch works properly.

@andrewleech i think that on this unit is no other patch, it is stock unit with services unlocked directly in vw service centre… so there shouldnt be any other setting/adaptation i hope…
I am intrested and I will try java loging to get to know where problems comes from. Does it means connection through dlink for example?

@andrewleech i think that on this unit is no other patch, it is stock unit with services unlocked directly in vw service centre… so there shouldnt be any other setting/adaptation i hope…

Every unit has a multitude of different settings / adaptations / long-coding - these are all the official settings that are different for each brand of car / country / installed features in car.
For example I have heard of someone who's car natually allowed built-in nav on VC while AA is on mib without this patch, it just wouldn't allow navigation on both at once. Having map visible on both seemed to be from one of the adaptation / long-coding settings but we haven't figured out which one yet.

I am intrested and I will try java loging to get to know where problems comes from. Does it means connection through dlink for example?

I've figured out a simpler method of enableing Java Logging and turned it into a toolbox script to enable/disable in this PR: https://github.com/jilleb/mib2-toolbox/pull/216


feat(value): add graphql-toolkit-value crate

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 86.79%. Comparing base (1f7e4dd) to head (2858028).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #32   +/-   ##
=======================================
  Coverage   86.79%   86.79%
=======================================
  Files           5        5
  Lines         780      780
=======================================
  Hits          677      677
  Misses        103      103

Flag
Coverage Δ

integration
87.80% <ø> (ø)

unit
0.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Remove coffeescript

replace it with es7

I'm happy to accept a pull request which compiles the CoffeeScript to JS at build time. Then the NPM package will contain plain-JS for projects to use, and the coffee-script dependency can be moved to dev-dependencies.
Also happy to include an example written in ES6 (ES7 is not supported in PhantomJS yet).

Also note that one can use JsJob in Node.js from plain JavaScript today (ES6 or whatever your node version supports). One example here: https://github.com/wikihouseproject/buildx-editor/blob/master/src/nestingserver.js
And the JsJob which runs inside is always standard JavaScript.


pwalletMain lock is removed

Possible fix #2104
Please check if this fix breaks something else.

Even though I can't reproduce #2104 , I agree that the line you removed should not be there because UnlockContext should take care of the wallet lock state already and there is no need to lock the wallet explicitly. So it's a conceptual ACK from me. However, we do not merge into master, so pls submit this patch to develop branch.

done


Split cloudbuild build-all.yaml into 2 separate build commands to avoid length overflow

Build fails otherwise due to too long arguments, it says:
Your build failed to run: generic::invalid_argument: invalid build: invalid .steps field: build step 2 arg 0 too long (max: 4000)

Will merge since CI cannot validate cloudbuild compilations.


Update copyright license script

add Update copyright license

This is a good idea! But what actually could be configurable there?

@Panquesito7 This is a good idea! But what actually could be configurable there?

Hmm, that's right. I guess it's a good idea to stick to this. 👍
To use this in other repositories, the whole file will need to be copied.

There are a few other changes that I would like you to make but to explain them over PR would be difficult. I've made those changes in the attached patch file. Just download and do git apply workflow.patch where workflow.patch is the file you downloaded.
workflow.patch
Let me know if you don't understand something inside this patch 😄

Would you like to add these in the C/C++ repositories, or should we create an issue to have it open to someone else? @alexpantyukhin.

@Panquesito7 I think I can do it. What is the best way to do this? Just copy this script into the .github folder?


record not found????? why i get this err?

Why set this error? What is the purpose?

https://gorm.io/docs/logger.html#Logger


run tests with avro enabled when verifying a release candidate

Which issue does this PR close?

Related to https://github.com/apache/arrow-datafusion/issues/6399 but does not close the issue
Rationale for this change

I would like the release verification script to work so that I can create the next release
What changes are included in this PR?

Enable avro feature when running tests in the release verification script
Are these changes tested?

Yes, manually
Are there any user-facing changes?

No

I can also look into fixing the sqllogictest so that it only runs when avro is enabled

Thanks @andygrove @izveigor  and @comphead !


Content: Vigenere Cipher

📚 Documentation
Add content for Vigenere Cipher
Have you read the Contributing Guidelines on Pull Requests?
Yes

@iamrajiv Can you please assign this issue to me

Just found out it already exists , sorry for the trouble, closing the issue

@Ayushjain2205 I don't see it anywhere. Has somebody else created the same issue? Because it is not on the website already.


FS-120 Split Tests Module

This PR fulfills #120.
We move all of the tests from the tests module to the freestyle module, since they mostly concerned the definitions at the core package. It turns out that most of the tests in the tests module only depend on freestyle, and a few test on monix, so we also have to add this dependency.

Codecov Report

Merging #121 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #121   +/-   ##
=======================================
  Coverage   75.74%   75.74%
=======================================
  Files          29       29
  Lines         268      268
  Branches        2        2
=======================================
  Hits          203      203
  Misses         65       65

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e51acd...4ae55c5. Read the comment docs.


first draft non contiguous interface allocation

lets us provision interfaces however we want in containerlab. basically allocates "dummy" interfaces up to the highest user provisioned interface.
is it ever possible for a file/dir name starting with "eth" in /sys/class/net to be anything but eth1, eth9, eth99 etc. (as in eth + some digits)? there's a probably fragile down and dirty regex to just yoink out the digits from those eth objects so we know the "highest provisioned interface" number.
fairly messy, but functional. gen_nics should probably get a little re-write love at some point :)

sorry, fixed conflicts!

nice, tested with sros and all is super


handle invalidParameters error response

In case when order_ref is non existing bankid api returns error message with additional attributes error_code && details like
{"errorCode":"invalidParameters","details":"No such order"}
this should fix this problem.

Thanks! Sorry for letting your PR rot here - I noticed this myself and fixed it, didn't get the notification I guess :(


Spelling: "Colinear"

"Collinear" is spelled as "colinear" in some places.

Thanks. I've actually got rid of it for now because it was wrong but I will add it back when I have time.


Change some suit storage sprites to be on the hip instead of the back

Sprites are from Cm13
They look better with backpacks, the gun back sprites are supposed to be if you're wearing them on your back, the suit slot ones look like they're on the hip

Changed the M54CE2 and M54C suit slots to use a modified version of the M4SPR suit slot rather than M45A1 sprites


feat: add Lif3 Chain Testnet

Add new chain
Please fill the following form:
Provide the Chain ID (Only 1 chain id per PR).

Chain_ID: 1811

Provide RPC URL for the chain (should be able to query atleast 10 requests per minute for automatic PR check).

RPC_URL: https://rpc-testnet.lif3.com

Relevant information:

Chainlist: https://chainlist.org/chain/1811
Block explorer: https://testnet.lif3scout.com

Could you please follow the PR Template and only add the required content, and not remove the identifiers? Thanks!

Thanks for quick response! Done.


difficulty with fwd and backword cycle group mappings

Hello,
I'm trying to use tab, s-tab to cycle match groups. The issue is every time I hit tab neovim produces an actual white space movement and ends the search all together.
Is this something with my neovim configuration?

I cannot reproduce this,
require'lightspeed'.setup { cycle_group_fwd_key = '<tab>', cycle_group_bwd_key = '<s-tab>' }

should work...

Is this something with my neovim configuration?

That shouldn't be a problem, the shift/cycle keys are just getchar-d inside the function, separated from the outside world...

Unless I am not using this correctly, I hit "s" then "l" since I'm searching for the word "lua". The lines I'm interested are highlighted in blue, so I hit "tab". Once I hit tab tho, it ends my search.
https://user-images.githubusercontent.com/5642902/144469645-fd12c2ec-e053-4c06-af91-70fc08a821d9.mp4

I see! You should finish the 2-char pattern first (lu), and only then can you use the group-shift keys.

there we go! thanks a lot.


Crash on item insert with Builder.

Hi McJty,
I have been having this crash with the builder on quarry. I tried to change the storage Modular Storage, vanilla chest or Iron Chest to no avail. Would you mind looking into it please?
See crash file attached.
crash-2016-07-23_11.54.52-server.txt

Hmm weird. Can you give more information? Perhaps a screenshot?

Closing due to lack of info


Colours not displaying properly

Hello! I uninstalled the theme + re-copied the CSS from this github, but I'm still facing this issue where the colours are not displaying properly (see pic above). Accent colour is not present for the button on the top left. The borders around the notes are also not according to what was displayed. Things were working fine before until today. Tried to look into the code to find the cause but I'm not very experiencd with CSS and I couldn't find anything. Hope to be able to get some assistance :")

Everything solveld itself somehow. Thank you!


Custom scripts and custom tags / formats

I've look around the wiki and haven't seen a way I can add custom tags to format the output.
I would like to display the content of my custom script using a custom format such
format = <one-label><another-label>
Is is possible already? How should I format the output of my script?
Thx!

I don't understand exactly what you want to achieve.
The script module has a format and a label parameter where you can set colors and so on. They also accept the formatting tags described here.

I updated the previous comment, the tags were not included.
I try to formulate my question again here:
I want to know how I should format the output of my script in other to select only the tags I want to display inside the module config
Something like
[module/mycustommodule]
type = custom/script
format = <one-label><another-label><ramp>
...

My question goes here how should I format the output of my script to have those labels?
I guess should be something similar to the following, but I dont really know how
print('<one-label>data1</one-label><another-label>data2<another-label><ramp>2</ramp>')

I think you're misunderstanding the functionality of the script module. It only has <label> which contains the token %output% by default, which is replaced by whatever the output of the script is. There are no multiple labels or ramps defined in the module.

ok, I see :) I though I could create a module with the same behaviour as the included ones.
I think is quite beautiful the way Polybar modules work, just tweaking a bit the conf you can configure the bar so much without tweaking scripts!
Would it be difficult to add that function? Would it make sense to have it?
Thanks anyway!

I don't think it would be that easy. We'd have to write another parser for the command output and then dynamically instantiate the different draw types. While it would be possible, I don't think that right now we have the capacity for it.


Realms mapped

Now only 4 inner classes left in that giant block state data generator, planning to use cloak
Most mappings are straight from 09a.
Signed-off-by: liach<EMAIL_ADDRESS>

Fyi since we have the habit of putting classes in net/minecraft whenever possible, i left the new classes in net/minecraft package


Don't store all-null dimension columns

When a Druid segment is created, it could be checked that a dictionary-encoded dimension column contains all null values, and just not written to the segment if so.
Probably the same couldn't be done for all-zero numeric columns, because if they are queried as dimensions they should appear as dimensions with all "0" values, not "null" values.

@leventov do you have something in mind like adding a new 'version' to the dictionary column part header to indicate a constant null dimension if we notice that the dictionary only has null at serialization time, so that way the header of the part is still written, just not the sub parts in order to be able to still distinguish an all null dimension from a dimension that doesn't exist?
With regards to constant elimination (all-zero columns), #6016, does this at the "column chunk scale", by collecting statistics within the chunk in a class called IntFormMetrics which is passed row values as they are sent to the serializer.
These statistics are discarded after the chunk is encoded, but longer term, I was considering saving until all chunks were processed, and making additional optimizations to eliminate constant columns almost entirely by encoding that information in the int column header, allowing the column supplier to return specialized/optimized implementations for these situations. I would imagine all null columns would also be relatively cheap represented in this manner, but would have more overhead in the form of a few function calls, since we could i think we could just push all of this up into a specialized selector that always returns nulls and wouldn't have to call into dictionaries/columns/indexes if we have a specialized dictionary column part for nulls like you are suggesting?
Additionally, I was planning to explore if that same information could be used beyond serialization of the int column to advise on index creation, e.g. whether to use concise or roaring (i need to do some experimentation here to see if any patterns pop up that would be good indicators to decide one way or another), or if we add any additional types of indexes in the future.
I think maybe also would be worthwhile to continue the discussion of #5347 since this relates to segment format perhaps? I plan on weighing in on that issue based on my experiences working on that branch in the very near future.

I don't think this particular thing requires any format change.

in order to be able to still distinguish an all null dimension from a dimension that doesn't exist?

I think you don't need to be able to distinguish them.


Additional device support

I came across this project and was extremely excited until I saw it was only available for Pis.
Is there any chance you could add additional device support?  I have 3 ODroid C2s and an XU4 that I would love to run this on.
I tried deploying on the XU4, but the deployment failed on the Bluetooth drivers.
Thank you
Ryan

@rmcburney86 can you give me the logs of the deployment?

Sure thing.
This appears to be the fatal step:
Step 4/15 : RUN install_packages   alsa-
utils   bluealsa   bluez   python-dbus   python-gobject   python-
gpiozero
---> Running in 4ce9c37863d0
Reading package lists...
Building dependency tree...
Reading state information...
E: Unable to locate package bluealsa
E: Unable to locate package python-gpiozero
-----Original Message-----
From: Alex<EMAIL_ADDRESS>Reply-To: balenalabs/balena-sound <
<EMAIL_ADDRESS>To: balenalabs/balena-sound<EMAIL_ADDRESS>Cc: rmcburney86<EMAIL_ADDRESS>Mention <
<EMAIL_ADDRESS>Subject: [PossibleSpam] Re: [balenalabs/balena-sound] Additional device
support (#155)
Date: Thu, 09 Apr 2020 08:04:45 -0700
@rmcburney86 can you give me the logs of the deployment?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "
https://github.com/balenalabs/balena-sound/issues/155#issuecomment-611578159
",
"url": "
https://github.com/balenalabs/balena-sound/issues/155#issuecomment-611578159
",
"name": "View Issue"
},
"description": "View this Issue on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]

@rmcburney86 are you sure they support bluetooth? I cant find any information about that.

@AlexProgrammerDE
No, they don't natively.
Do you think it would make more sense to add a USB Bluetooth adapter or run the project with only WiFi connectivity?
I think I have a USB Bluetooth\Wifi adapter in my parts bin I could try.

I think we can get bluetooth working with a dongle and some time. Bluealsa is the bridge between bluetooth and your device output. We have to build it from source and then install it. I will later work on it. But if you dont need bluetooth can we just use airplay and spotify. Do you want bluetooth?

I'd be happy to start with airplay and Spotify and work on Bluetooth down the road.

@rmcburney86 lets check if everything works without bluetooth.
You have to change some code in the compose file: https://github.com/balenalabs/balena-sound/blob/master/docker-compose.yml This file is the main of the project and says which services should be build and where they are pointed. To disable bluetooth you have to delete this part of the file:

bluetooth-audio:
build: ./bluetooth-audio
restart: on-failure
network_mode: host
privileged: true
labels:
io.balena.features.dbus: 1
volumes:
- bluetoothcache:/var/cache/bluetooth
- snapcast:/var/cache/snapcast

That worked, mostly.
The project installed on the XU4 and I can connect to it using
AirPlay.  But there is no audio output,I'm guessing because the DAC a
different.
How would I find the settings for the onboard DAC to use the audio that
runs through the HDMI?
Thank you
Ryan
-----Original Message-----
From: Alex<EMAIL_ADDRESS>Reply-To: balenalabs/balena-sound <
<EMAIL_ADDRESS>To: balenalabs/balena-sound<EMAIL_ADDRESS>Cc: rmcburney86<EMAIL_ADDRESS>Mention <
<EMAIL_ADDRESS>Subject: [PossibleSpam] Re: [balenalabs/balena-sound] Additional device
support (#155)
Date: Thu, 09 Apr 2020 10:22:37 -0700
@rmcburney86 lets check if everything works without bluetooth.
You have to change some code in the compose file:
https://github.com/balenalabs/balena-sound/blob/master/docker-compose.yml
This file is the main of the project and says which services should be
build and where they are pointed. To disable bluetooth you have to
delete this part of the file:

bluetooth-audio:
build: ./bluetooth-audio
restart: on-failure
network_mode: host
privileged: true
labels:
io.balena.features.dbus: 1
volumes:

bluetoothcache:/var/cache/bluetooth

snapcast:/var/cache/snapcast

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "
https://github.com/balenalabs/balena-sound/issues/155#issuecomment-611649202
",
"url": "
https://github.com/balenalabs/balena-sound/issues/155#issuecomment-611649202
",
"name": "View Issue"
},
"description": "View this Issue on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]

@rmcburney86 i think this comment could help you: https://github.com/balenalabs/balena-sound/issues/79#issuecomment-583712988
It must be set in Fleet Configuration / Device Configuration

@rmcburney86 does it work?

No, I still don't have audio through the HDMI.
I have tried RESIN_HOST_CONFIG_hdmi_mode 2
With and without RESIN_HOST_CONFIG_dtparam "audio=off"
which I found on the DAC Configuration page - https://github.com/balenalabs/balena-sound/blob/master/DAC_configuration.md
But still no luck.
Any of the other DAC settings make sense to try?

And another oddity.
My Apple devices see the XU4 as an airplay destination, but my android doesn't.
They both can see and play through my AV receiver.

@rmcburney86 Airplay is a Apple exclusive product. You can try it with Spotify connect if you have premium. I am searching now a solution for the output.

Closing due to inactivity from author.


Add a GitHub action to publish tagged releases

Building and publishing releases locally is too slow and error-prone, leading to fewer releases. We should add a GitHub action that will publsh tagged releases securely.

Apparently we already have this, jeez.


CARGO environment variable not set when cargo check runs through ra

When trying to use one of SQLx'es query macros (using the master branch), this error currently happens in VSCodium when ra runs cargo check:
proc macro returned error: proc-macro panicked: `CARGO` must be set
proc macro returned error: proc-macro panicked: Lazy instance has previously been poisoned
proc macro returned error: proc-macro panicked: Lazy instance has previously been poisoned
... (one poisoned error for every but the first query macro invocation)

The error comes from here: https://github.com/launchbadge/sqlx/blob/df393128f8b07e3b858e65446b2a508a73bf5135/sqlx-macros/src/query/mod.rs#L33
Since cargo there is only used to run cargo metadata, it would most likely be fine for 99% of the cases to fall back to cargo, but it would be nice if it just worked as-is.

It's kind of scary to me that proc macros are depending on this :confused: (Are these env variables at least documented for proc macros?)
On the other hand, why complain about this with a proc macro that also makes an actual database connection...

It's kind of scary to me that proc macros are depending on this :confused: (Are these env variables at least documented for proc macros?)
On the other hand, why complain about this with a proc macro that also makes an actual database connection...

Yes, this is documented: https://doc.rust-lang.org/cargo/reference/environment-variables.html#environment-variables-cargo-sets-for-crates
Of course ideally proc-macros wouldn't rely on cargo-specific things since some users might want to use a different build system. The most prominent cargo-specific thing a lot of proc-macros do is probably using proc-macro-crate, although I guess most uses of it use a fallback instead of erroring when proc_macro_crate::crate_name fails.

Yes, this is documented: https://doc.rust-lang.org/cargo/reference/environment-variables.html#environment-variables-cargo-sets-for-crates
Of course ideally proc-macros wouldn't rely on cargo-specific things since some users might want to use a different build system. The most prominent cargo-specific thing a lot of proc-macros do is probably using proc-macro-crate, although I guess most uses of it use a fallback instead of erroring when proc_macro_crate::crate_name fails.


Use read_at instead of read_exact_at

I am trying to use libsql API library and aiming to cross compile my app across OS. Currently it uses a *nix OS specific import and can't be used on Windows. This patch tries to fix that.

We are using read_exact_at but at offset zero, so it is same as read_exact
Earlier, it was reading twice into buffer. Any particular reason for that? I changed it to read it once

This PR currently breaks, but #324 fixes the import error

Hey @avinassh! The change looks good to me, but I also wonder why we're reading twice. Let's try to get @MarinPostma or @psarna to have a look at this before merging.

Looks good. Idk why we were reading twice, likely a mistake

Do we want to bother with making sqld compile on windows? Just asking

@MarinPostma Sure, I think it's good to keep stuff running on Windows when possible.


Look for patterns in all directories

This is in response to https://github.com/wp-cli/i18n-command/pull/312/files#r863120121
Related:

https://meta.trac.wordpress.org/changeset/11809
https://meta.trac.wordpress.org/changeset/11810
https://meta.trac.wordpress.org/changeset/11811

The downside of this change is that now pattern headers are also extracted from files outside the patterns directory. Can we live with that?

cc @ocean90

Perhaps in the extractor we can add a separate check to just extract the strings if the current file is in a patterns directory.

The downside of this change is that now pattern headers are also extracted from files outside the patterns directory. Can we live with that?

Ah, now it makes sense, why it was done like that. To me this sounds like this task should then only look in patterns and only extract the headers and no other strings. But it seems the current extractor doesn't support this?
I just noticed that we have the same issue with styles from https://github.com/wp-cli/i18n-command/commit/752a4d4dd14a2d6c93dba5ae4410677c0b5d3c34#diff-1197c2ddc1381faef42d8ac1eaf93f93a7b205617cca46cf7611a7462c64f9eeR690, see https://wordpress.slack.com/archives/C02RP50LK/p1651528912931309.

Yeah that would also work but I think you‘re right, it doesn‘t support that. Plus it would mean potentially unnecessarily scanning a file twice.
Checking for the expected folder structure within the extractor could work for both patterns and styles.
I‘ll neee to experiment with that.

Plus it would mean potentially unnecessarily scanning a file twice.

That would only be a file_get_contents() + get_file_data_from_string() call right? Sounds okay for me.
What about adding a skip_default option which can be set to true to prevent running
https://github.com/wp-cli/i18n-command/blob/bcb1a8159679cafdf1da884dbe5830122bae2c4d/src/IterableCodeExtractor.php#L93

Tried a different approach now. The downside is that it hardcodes the logic for included folders and file names, but at least it does not mess with the include/exclude options nor scan files twice.


[1166] Remove primary schools from universities list

Context
There are Primary Schools in the universities list. We need to remove these.

 There's a school in the universities list 🙊


blah

for test only

Coverage decreased (-0.4%) to 68.142% when pulling 6918fdbe5ce08389a38d544643e0a43ba642c197 on test into fc6ee03f60f99940c28699120d9d414e2b36093f on master.


Update pp sdk version

This PR is about operator-sdk version PP uses.
It contains couple of changes:

First Commit

operator-sdk version changes from 1.12.0 to 1.17.0
making sure that the specified version will be used even if an older version is cached.

-Second commit
Generated bundle files with new sdk

/lgtm


fix react main.ts example

Hey @Dank-del, thanks for submitting this.
I'd like to keep the main.tsx file content short for readability, but having the root element as app may be problematic/confusing and it was reported before #99. However, defining React in the files scope or using StrictMode may be a preference and it's not necessary at the getting started sections.
I've updated all examples 268aedd to use root as the html mount target instead of app as that's what you'd get after creating a Vite project. Also tried to follow the getting started steps and it should work perfectly fine:

Thanks again.


Default to using standard GitHub API token during build

Resolves an issue where the GitHub API is rate-limited during the build when attempting to download Electron.
/cc @kevinsawicki

:+1: :key:


prepare for awesome listing

Pull Request Test Coverage Report for Build<PHONE_NUMBER>5
Warning: This coverage report may be inaccurate.
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 91.402%

Totals

Change from base Build<PHONE_NUMBER>3:
0.0%

Covered Lines:
1552

Relevant Lines:
1698

💛  - Coveralls


Linux: reload confirm dialog looks odd

See:

And how typical confirm dialogs look like otherwise:

Ended up just doing small tweaks:


Add stream response to zipkinhttpclient

We're using a lot of streamed responses in our Ratpack apps and this seemed like a useful thing to be able to trace with Zipkin.
I've tested this MR out against a locally running application using a console reporter and things seemed to look good.
Curious if this was left out of the current API due to some issue you came across, or was it simply an issue of time?  The only thing that came to our minds was that potentially the timings maybe under represented depending on how Ratpack internally represents a StreamedResponse as being completed.

We've run load tests against the PR and had positive results.  Zipkin tracing looks as expected in Zipkin UI.

@hyleung Are you still wanting to maintain this project?

@jeff-blaisdell shit, sorry - for some reason I either missed or didn't get a notification on this PR.
First of all, great to hear that you're getting some use out of the library!
Re. why streamed responses wasn't added to ZipkinHttpClient - it was really just a time thing. I kinda got side-tracked on trying to get tracing more tightly integrated into the stock Ratpack http client. That sort of ended up being a big diversion that's still ongoing. TLDR; Ratpack's http client doesn't have any sort of interceptor API so I've been trying to add that with limited success (https://github.com/ratpack/ratpack/pull/979).
Re. whether I still want to maintain this project - absolutely. Having said that, for me this is really just a side project (in my current job, we don't use Ratpack or Zipkin in any form) so my bandwidth can sometimes be limited. The other thing is that I am certainly no expert on Ratpack or Zipkin (tho' I am learning a lot) so I don't think it would hurt to have other folks jump in. Maybe we can look for a more suitable home for this to help keep some momentum going. Maybe @adriancole might have some ideas on how to move things forward?

No worries.  We really appreciate the work you have done.  We're actively instrumenting all of our ratpack apps with this lib right now.  I just wanted to make sure you wanted to maintain it.  Right now, we're maintaining a separate fork of it under our OSS repo:
https://github.com/SmartThingsOSS/ratpack-zipkin
As we patch, improve things we are trying to submit PRs back here.  Just wanted to make sure you were still onboard w/ reviewing / merging / driving it forward.  If it becomes a burden I'm sure we'd be willing to take it up and we could work out some way to give you due credit.  However, patching back here is fine for us as long as you remain willing.

@jeff-blaisdell yup, I'm still on board with reviewing, merging, etc.  I should fix that PR build, too huh?


Set leap_day=True as default in pvlib.iotools.get_psm3()

Is your feature request related to a problem? Please describe.
Several functions require equal timesteps with no gaps (e.g., pvlib.temperature.prilliman and detect_clearsky). Having weather data that excludes leap day will cause an error. Specifically, using pvlib.iotools.get_psm3 for a leap year with the default leap_day=True would be a common reason for encountering this error.
Describe the solution you'd like
As suggested by @adriesse here https://github.com/pvlib/pvlib-python/issues/1476#issuecomment-1163130675, perhaps the default should be changed to leap_day=True?
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Related to https://github.com/pvlib/pvlib-python/issues/1476.
On the topic of "is this a good idea", some comments from issue 1476:

"I wonder if there are any compelling reasons to keep it as False, other than the fact that other tools (e.g., NREL SAM) can't handle leap day."

(by me)

"I suspect leap_day=False is rooted in matching the PSM3 API's decision to set it False by default."

(by @kanderso-nrel)

I want to make sure I understand the API... PSM3 ignores leap_day for tmy/tgy requests and always returns a year with 365 days? But defaults to skipping the leap day when requesting, say, 5 minute data for 2020? If I understand correctly, I agree that the default should change.

In regards to the NREL NSRDB API, there is no leap_day parameter for PSM3 typical years like there is for hourly PSM3 and 5min PSM3. I think it is safe to assume that the PSM3 TMY API will never return a leap day, even if February for the given TXY dataset happened to come from a leap year. But I've never seen that documented.
For pvlib.iotools.get_psm3, I'll defer to someone else to confirm, but I think you are correct on both points.

A potential alternative would be not to have a default behavior in order to force users to make a conscious choice.

I do not know of any other service that excludes leap days when requesting normal (non TMY) time-series data; hence, I think changing the get_psm3 to include leap days by default would be in line with the remaining iotools and the general expectations of users. I also prefer this to not having a default choice. After all real-world systems do indeed observe leap days!

Any thoughts on whether this deserves a deprecation cycle like we've done for map_variables in #1374?  I could go either way.

I'm ok with no deprecation cycle. I suppose then it should first be implemented in 0.10 (change the milestone)?


Use ctrl-a a as detach Key

@d11wtq sorry, opened this PR by incident. On the other hand, it's a hack for myself - do you intend to add support for custom detachKeys?


Audit can be broken with .env files

Thanks to @OiCMudkips  for finding this 👍
detect-secrets scan test_data/config.env > teeth
detect-secrets audit teeth

😬  and you get
Secret:      1 of 1
Filename:    test_data/config.env
Secret Type: Base64 High Entropy String
----------
ERROR: Secret not found on line 1!
Try recreating your baseline to fix this issue.
----------
What would you like to do? (s)kip, (q)uit: q
Quitting...
Saving progress...

I remains to be seen if this is the same bug as the yaml one I mentioned at the end of issue #204, but I shall try to add a test case for that, as our test_data/ yaml currently works fine.

What does the config file look like? Could this be a duplicate of https://github.com/Yelp/detect-secrets/issues/189?

Closed as dupe of #189 👍


Fix #435: add cert option to util.openURL

This PR fixes #435.
Changes:

add cert option to util.openURL to be passed to requests for client side certificates.

merged.


modified build process

Current dependencies on/for this PR:

main

PR #97   👈

This stack of pull requests is managed by Graphite.


FCS errors not showing up in dashboard

appears FCS errors not showing up in dashboard for some reason.

all regressions passing, not sure whats hapening with the clients system. its clearly being written to the system event log file, but dashboard for some reason nothing gets added.

likely a precision issue. due to how the FCS counter is accumulated beleive its dropping bits when the FCS error counts overflow 64bit float precision. test underway

Specifically the problem is with FCS errors of 735,036,747,292  packets. For small # of FCS errors the code functions correctly.
sf0       Link encap:Ethernet  HWaddr 00:0F:53:20:B2:F0
inet6 addr: fe80::20f:53ff:fe20:b2f0/64 Scope:Link
UP BROADCAST RUNNING MULTICAST  MTU:9216  Metric:1
RX packets:775034282013 errors:735036747292 dropped:0 overruns:0 frame:735036747292
TX packets:23587574 errors:0 dropped:0 overruns:0 carrier:0
collisions:0 txqueuelen:1000
RX bytes:57816662242649 (52.5 TiB)  TX bytes:1509605240 (1.4 GiB)
Interrupt:29

the SHM stats file RxErrors (and drop counts) were 32bit floating point numbers. This causes LSB bit drops when the Rx Error counts are extremely high.
fixed.


[marathon-lb] Enable privileged mode, sysctl.

This bumps to marathon-lb 1.1.0.

Please attach evidence of successful installation on a DCOS cluster :)

Thanks!

Is this the new standard going forward? screenshot evidence required prior
to merge?
On Tue, Feb 9, 2016 at 12:32 PM, Sunil Shah<EMAIL_ADDRESS>wrote:

Thanks!
—
Reply to this email directly or view it on GitHub
https://github.com/mesosphere/multiverse/pull/83#issuecomment-181972179.

@jdef, until we have automated tests, yeah! We've had a surprising number of PRs that just don't run.


Automated cherry pick of #9544: fix(region): lbbackend: better error reporting for finding influxdb info

Cherry pick of #9544 on release/3.6.
#9544: fix(region): lbbackend: better error reporting for finding influxdb info

Codecov Report

Merging #9545 (48f1cf1) into release/3.6 (b9d30c0) will decrease coverage by 1.89%.
The diff coverage is 3.40%.

@@               Coverage Diff               @@
##           release/3.6   #9545       +/-   ##
===============================================
- Coverage         5.86%   3.96%    -1.90%
===============================================
  Files              828     170      -658
  Lines           129133   25499   -103634
===============================================
- Hits              7577    1012     -6565
+ Misses          120876   24373    -96503
+ Partials           680     114      -566

Flag
Coverage Δ

aFlag
3.96% <3.40%> (-1.90%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

pkg/cloudcommon/db/apply_manager_method.go
0.00% <0.00%> (ø)

pkg/cloudcommon/db/archs.go
0.00% <0.00%> (ø)

pkg/cloudcommon/db/db_dispatcher.go
0.00% <0.00%> (ø)

pkg/cloudcommon/db/models.go
0.00% <0.00%> (ø)

pkg/cloudcommon/db/scoperesource.go
0.00% <0.00%> (ø)

pkg/cloudcommon/db/sharablebase.go
6.01% <0.00%> (-0.06%)
:arrow_down:

pkg/cloudcommon/db/virtualjointbase.go
0.00% <0.00%> (ø)

pkg/cloudcommon/db/virtualresource.go
0.00% <0.00%> (ø)

pkg/cloudcommon/policy/policy.go
1.20% <0.00%> (-0.01%)
:arrow_down:

pkg/cloudprovider/instance.go
0.00% <ø> (ø)

... and 609 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 74d0502...48f1cf1. Read the comment docs.


Return empty PageSource when there's unsupported Serde property

This change checks if the configuration contains unsupported Serde properties. If there's an unsupported property included, it will return an empty PageSource.
Unsupported properties:

ion.serialize_null
ion.fail_on_overflow
ion.<column>.fail_on_overflow
ion.ignore_malformed
ion.<column>.serialize_as
ion.timestamp.serialization_offset
ion.<column>.path_extractor
ion.path_extractor.case_sensitive

I think we need to allow folks to explicitly pass the defaults. That can be a follow up, but I think we need that for this milestone.

Yes, I can include allowing defaults in this PR.


fix(pull_schedual) add the namespace wrapper in callback

What is the purpose of the change
Fixed the cannot find callback issue when access namespace instance.
Brief changelog
XX
Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

[x] Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
[x] Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
[x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
[x] Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test  to make sure integration-test pass.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

Coverage increased (+0.03%) to 50.883% when pulling e5fb7049753b5dc388a0cb57a3f4fbd3579429f6 on duhenglucky:pull_schedual_fix into b6281144ac1f9db1e9e4b5f9967cf10393b12f9f on apache:develop.


The extension dels all my comments in .feature file

👓 What did you see?
The extension dels all my comments in .feature file when I try to save it.
✅ What did you expect to see?
I expect to see all my comments after #-sign
📦 Which tool/library version are you using?
VS Code v1.82.1
Cucumber v1.7.0
🔬 How could we reproduce it?
Steps to reproduce the behavior:

Install VS Code version 1.82.1 and Cucumber v1.7.0
Create a file called foo.feature with text

Feature: test feature
  Some text

  #foobar
  Background:
    Given I try to login as "McGonagall" user
    When I have open survey
    And wait until the page loads

Try to save file with Cucumber prettier
See file without #foobar

I have the same problem

Thank you for the bug report. This is fixed in v1.8.0 which should be published to the Visual Studio Code Marketplace soon, or you can install from the .vsix file in the linked release.

Thank you for the bug report. This is mostly fixed in v1.8.0 which should be published to the Visual Studio Code Marketplace soon, or you can install from the .vsix file in the linked release.
There is still one case that isn't fixed; see @cucumber/gherkin-utils#38 -- I will address this separately as it requires updates to underlying packages.

I've just installed version 1.8.0 and it is still buggy. When I put a comment on top of a scenario and save, it adds an empty line under the comment. For instance, this code
Scenario: 1
  ...

# This is a comment
Scenario: 2
  ...

results in
Scenario: 1
  ...
# This is a comment

Scenario: 2
  ...

This is highly problematic as this extension seems to be the only thing in Gherkin/JS land that automatically format tables. Having to disable the extension because of this issue makes writing tests much more painful than it needs to be.

Thank you for the bug report. I've added this to my list of formatting issues to fix in the related package. I don't have much time to devote to Cucumber just now but I am hoping to have more time later this quarter to work on reliability of the formatter.


InvalidArgumentError with MirroredStrategy under graph mode when using tf.summary

Please make sure that this is a bug. As per our
GitHub Policy,
we only address code/doc bugs, performance issues, feature requests and
build/installation issues on GitHub. tag:bug_template
System information

Have I written custom code (as opposed to using a stock example script provided in TensorFlow): no
OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Debian GNU/Linux 9
Mobile device (e.g. iPhone 8, Pixel 2, Samsung Galaxy) if the issue happens on mobile device:
TensorFlow installed from (source or binary): source
TensorFlow version (use command below):2.3.1
Python version:3.7.8
Bazel version (if compiling from source):
GCC/Compiler version (if compiling from source):6.3.0
CUDA/cuDNN version: CUDA Version: 10.1
GPU model and memory: Tesla T4 * 2

Describe the current behavior
When I use tf.summary and tf.map_fn(tf.io.decode_jpeg) under distributed strategy and graph mode, the error appears.
When I remove tf.summary, it works well.
When I remove tf.function, it works well.
When I remove tf.map_fn, it works well.
When I remove tf.io.decode_jpeg out of the serving() scope, like putting it in the init func, it works well.
Describe the expected behavior
I guess this is the bug of tensorflow.
Standalone code to reproduce the issue
import tensorflow as tf
from tensorflow.keras import layers

class Evaluation:

    def __init__(self, strategy=None):

        # prepare for encoded img data
        self.strategy = strategy
        H, W, C = 10, 10, 3
        imgs = tf.cast(tf.zeros([8, H, W, C]), tf.uint8)
        encodes = []
        for img in imgs:
            encode = tf.io.encode_jpeg(img)
            encodes.append(encode)
        encodes = tf.stack(encodes, axis = 0)

        # convert encoded img data to tf.data
        self.dataset = tf.data.Dataset.from_tensor_slices(encodes)
        self.dataset = self.dataset.batch(2)
        self.dataset = self.strategy.experimental_distribute_dataset(self.dataset)
        with self.strategy.scope():
            self.conv = layers.Conv2D(32, (1, 1), strides=(1, 1), padding='same')
        self.parallel_iterations = 10

    def preprocess(self, encoded):
        # preprocess for tf.data
        image = tf.io.decode_jpeg(encoded, channels=3)
        image = tf.image.resize(image, [20,20])
        return image

    @tf.function
    def serving(self, inputs):
        # data preprocess
        image = tf.map_fn(self.preprocess,
                          inputs,
                          fn_output_signature=tf.float32,
                          parallel_iterations=self.parallel_iterations)

        # inference for each batch
        prediction = self.conv(image)
        return prediction

    @tf.function
    def infer(self, serve_summary_writer):
        # inference for all batches
        with serve_summary_writer.as_default():
            batch = tf.cast(0, tf.int64)
            for data in self.dataset:
                prediction_perReplica = strategy.run(self.serving, args=(data,))
                prediction_tensor = prediction_perReplica.values
                prediction_concat = tf.concat(prediction_tensor, axis = 0)
                tf.summary.write(tag="prediction", tensor=prediction_concat, step=batch)
                batch += 1

    def eval(self):
        serve_summary_writer = tf.summary.create_file_writer('save_file', max_queue=100000, flush_millis=100000)
        self.infer(serve_summary_writer)
        serve_summary_writer.close()
        tf.io.gfile.rmtree('save_file')

if __name__ == "__main__":

    strategy = tf.distribute.MirroredStrategy()
    e = Evaluation(strategy)
    e.eval()

Other info / logs
Traceback (most recent call last):
File "test.py", line 66, in
e.eval()
File "test.py", line 58, in eval
self.infer(serve_summary_writer)
File "/opt/conda/lib/python3.7/site-packages/tensorflow/python/eager/def_function.py", line 780, in call
result = self._call(*args, **kwds)
File "/opt/conda/lib/python3.7/site-packages/tensorflow/python/eager/def_function.py", line 846, in _call
return self._concrete_stateful_fn._filtered_call(canon_args, canon_kwds)  # pylint: disable=protected-access
File "/opt/conda/lib/python3.7/site-packages/tensorflow/python/eager/function.py", line 1848, in _filtered_call
cancellation_manager=cancellation_manager)
File "/opt/conda/lib/python3.7/site-packages/tensorflow/python/eager/function.py", line 1924, in _call_flat
ctx, args, cancellation_manager=cancellation_manager))
File "/opt/conda/lib/python3.7/site-packages/tensorflow/python/eager/function.py", line 550, in call
ctx=ctx)
File "/opt/conda/lib/python3.7/site-packages/tensorflow/python/eager/execute.py", line 60, in quick_execute
inputs, attrs, num_outputs)
tensorflow.python.framework.errors_impl.InvalidArgumentError: 3 root error(s) found.
(0) Invalid argument:  2 root error(s) found.
(0) Invalid argument: During Variant Host->Device Copy: non-DMA-copy attempted of tensor type: string
(1) Invalid argument: During Variant Host->Device Copy: non-DMA-copy attempted of tensor type: string
0 successful operations.
0 derived errors ignored.
[[{{node while/body/_17/while/StatefulPartitionedCall/map/TensorArrayUnstack/TensorListFromTensor/_109}}]]
[[while/loop_body_control/_45/_96]]
(1) Invalid argument:  2 root error(s) found.
(0) Invalid argument: During Variant Host->Device Copy: non-DMA-copy attempted of tensor type: string
(1) Invalid argument: During Variant Host->Device Copy: non-DMA-copy attempted of tensor type: string
0 successful operations.
0 derived errors ignored.
[[{{node while/body/_17/while/StatefulPartitionedCall/map/TensorArrayUnstack/TensorListFromTensor/_109}}]]
(2) Invalid argument:  2 root error(s) found.
(0) Invalid argument: During Variant Host->Device Copy: non-DMA-copy attempted of tensor type: string
(1) Invalid argument: During Variant Host->Device Copy: non-DMA-copy attempted of tensor type: string
0 successful operations.
0 derived errors ignored.
[[{{node while/body/_17/while/StatefulPartitionedCall/map/TensorArrayUnstack/TensorListFromTensor/_109}}]]
[[Func/while/body/_17/while/StatefulPartitionedCall/replica_1/map/while/body/_181/input/_266/_187]]
0 successful operations.
0 derived errors ignored. [Op:__inference_infer_620]
Function call stack:
infer -> infer -> infer

Hi @ZhixinLai, this seems to be a duplicate of #44072? Let's keep one of the issues open and close the other. It's easier for us to track in a single place.