feat: On Android, use the file-based camera mode by default

We will rename the camera modes to:

File-based mode (previously called the alternative mode)
Bytes array mode (previously the default mode)

On Android, both modes are available and the file-based one is now used by default.
On iOS, only the bytes array is supported

Codecov Report

Merging #3114 (3406c2d) into develop (7d681a8) will increase coverage by 0.00%.
The diff coverage is 6.25%.

:exclamation: Current head 3406c2d differs from pull request most recent head 03fa3ce. Consider uploading reports for the commit 03fa3ce to get more accurate results

@@           Coverage Diff           @@
##           develop   #3114   +/-   ##
=======================================
  Coverage     6.46%   6.46%
=======================================
  Files          246     246
  Lines        12212   12199   -13
=======================================
  Hits           789     789
+ Misses       11423   11410   -13

Impacted Files
Coverage Δ

...s/smooth_app/lib/data_models/user_preferences.dart
11.88% <0.00%> (ø)

...s/smooth_app/lib/pages/scan/camera_controller.dart
0.73% <0.00%> (-0.02%)
:arrow_down:

...b/pages/preferences/user_preferences_settings.dart
11.25% <7.14%> (+0.06%)
:arrow_up:

...ckages/smooth_app/lib/pages/scan/camera_modes.dart
14.28% <14.28%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Wrong url for generating the SystemKey

The documentation is not correct, for V2 the endpoint to get the SystemKey should be:
http://{functionappname}.azurewebsites.net/admin/host/systemkeys/eventgrid_extension?code={masterkey}

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: a6bb013c-83b0-84fd-f4eb-364db7b3c507
Version Independent ID: 6a2a7e4a-769f-034a-c9a2-c3decc6b20b0
Content: Event Grid trigger for Azure Functions
Content Source: articles/azure-functions/functions-bindings-event-grid.md
Service: azure-functions
GitHub Login: @ggailey777
Microsoft Alias: glenga

Hi @olandese Thank you for reporting this issue! We will investigate and make any necessary changes.

i am working on this

Oh thank god I found this.
I see this issue has been closed. The MSFT docs still have the old URL.

Glad I could help! I wrote a blog about this:
https://blog.olandese.nl/2018/10/16/create-an-event-grid-subscription-to-an-azure-function-v2/


Add sudo restorecon -R /opt/mattermost/ command line to the documenta…

Summary
Add sudo restorecon -R /opt/mattermost/ command line to the documentation.
Restorecon command will reset the SELinux security context for files and directories to its default values.

Ticket Link
Fixes https://github.com/mattermost/docs/issues/4101

Hello @Francois-D,
Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

@DSchalla @jupenur Any of you knows better if this command is right in this context? I think it is, but I don't have the environment to test it and I'm not very familiarized with SELinux enough.

@DSchalla @jupenur Any of you knows better if this command is right in this context? I think it is, but I don't have the environment to test it and I'm not very familiarized with SELinux enough.

Sorry, I have no idea. This is a bit too far outside my area of expertise. Maybe Daniel can pitch in though.

Generally the command makes sense in that context, the thing I am uncertain about is whether there are any other bits that may need adaption for SELinux - For example, if we add it here we may need to make a note in our upgrade guide as well to do a restorecon to fix the SELinux context.
If we don't we would be inconsistent at least.

Running restorecon would reset the files to the default setting.  If the user had made customized changes you would overwrite these changes possibly leading to a unexpected upgrade experience.
Perhaps recommending to  run restorecon -n option to check the current settings to ensure that the settings are what is desired.   This would be added after point 12 in the document below.
https://docs.mattermost.com/upgrade/upgrading-mattermost-server.html#id3.

Right, my proposal was to mention during the server upgrade that another restorecon would be necessary.

Right, my proposal was to mention during the server upgrade that another restorecon would be necessary.

"might" be necessary or is necessary?  Sorry I just want to clear on your point.  Thank you.

I've logged https://mattermost.atlassian.net/browse/MM-37745 to capture the follow-on work needed for the Upgrade documentation. Thanks @DSchalla and @Francois-D!


Customizable hand-sim poses

Currently, controllers and mice simulate hands by blending through different hand poses on button-press. This would add the ability to override the default hand poses, as well as map them to additional buttons that are present. For example, a thumbs-up hand-pose when pressing 'X1' on the controller.

Still needs commentdocs! But is otherwise in


API Link

📚 Documentation
I was just looking at the new docs homepage and realised it’s not that obvious how to browse the various modules (“reference documentation” in the legacy docs).  This is served by the “Iris API” link in the new docs, but that’s under “Developer Guide”.  Should we have this linked somewhere more prominent?

The link could move to User Guide or Reference section, which I think makes more sense.
In terms of making it more prominent, there is a sphinx extension named sphinx-panels that may be of use (I've not played with it yet).  I've mentioned this extensions in an issue I just created https://github.com/SciTools/iris/issues/3883 capturing some thoughts after getting the docs to the state it is in now (a good one).

I had a quick play with the panels extensions, see https://iris-test-doc.readthedocs.io/en/latest/ (this link will only show the content until this issue is closed)

I like the examples under “More links....” Nice bold buttons for people who know what they’re looking for and a helpful description for those who don’t.

I've iterated on this, see https://iris-test-doc.readthedocs.io/en/latest/#play-4

The links shared to show the rendered html has now moved onto to show the PR I've created for this https://github.com/SciTools/iris/pull/3884.


[WIP] Test segment reload (don't review)

This is a testing PR, please don't review.

Codecov Report

Merging #8536 (1a50fc6) into master (45e3827) will increase coverage by 1.31%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master    #8536      +/-   ##
============================================
+ Coverage     69.28%   70.60%   +1.31%
+ Complexity     4289     4286       -3
============================================
  Files          1674     1674
  Lines         87699    87701       +2
  Branches      13279    13279
============================================
+ Hits          60763    61922    +1159
+ Misses        22664    21478    -1186
- Partials       4272     4301      +29

Flag
Coverage Δ

integration1
26.91% <100.00%> (?)

integration2
26.02% <100.00%> (+0.18%)
:arrow_up:

unittests1
67.03% <ø> (-0.04%)
:arrow_down:

unittests2
14.15% <ø> (+0.06%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...server/starter/helix/HelixInstanceDataManager.java
78.86% <100.00%> (+0.22%)
:arrow_up:

...nt/local/startree/v2/store/StarTreeDataSource.java
40.00% <0.00%> (-13.34%)
:arrow_down:

...ot/segment/local/startree/OffHeapStarTreeNode.java
72.22% <0.00%> (-5.56%)
:arrow_down:

...ders/forward/VarByteChunkMVForwardIndexReader.java
93.05% <0.00%> (-2.78%)
:arrow_down:

.../java/org/apache/pinot/spi/data/TimeFieldSpec.java
88.63% <0.00%> (-2.28%)
:arrow_down:

.../helix/core/realtime/SegmentCompletionManager.java
71.80% <0.00%> (-1.02%)
:arrow_down:

...ion/function/DistinctCountAggregationFunction.java
51.56% <0.00%> (ø)

...ntroller/helix/core/PinotHelixResourceManager.java
67.92% <0.00%> (+0.45%)
:arrow_up:

...ot/core/query/pruner/ColumnValueSegmentPruner.java
75.13% <0.00%> (+0.52%)
:arrow_up:

...ery/optimizer/filter/NumericalFilterOptimizer.java
83.43% <0.00%> (+0.59%)
:arrow_up:

... and 117 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 45e3827...1a50fc6. Read the comment docs.


Ensure EFS is securely encrypted

Possible check to target the following resource

[ ] aws_efs_file_system

closing, tracking in spreadsheet

closing, tracking in spreadsheet


Generic subclasses are not handled consistently

Describe the Bug
The graphql schema generated by Generic subclasses is incorrect.
System Information

Operating system: Ubuntu 20.04.3 LTS
Strawberry version (if applicable): 0.171.1

Additional Context
Consider this code.
class MyGeneric(Generic[T]):
    ...

@strawberry.type
class Child(MyGeneric[int]):
    attr: int

@strawberry.type
class Parent:
    child: Child
    children: list[Child]
    maybe_child: Child | None
    annotated_child: Annotated[Child, 1]

@strawberry.type
class Query:
        parent = strawberry.field(resolver=get_parent)

The generated schema is
type Parent {
    annotatedChild: Child!
    child: IntChild!
    children: [Child!]!
    maybeChild: Child
}

That is a problem, because I write the same object everywhere in my python code, but my graphql schema doesn't use the same name. It duplicates my types for no good reason. It makes the frontend code harder to write as the classes change depending on if they are contained/annotated.
Note that Child itself will be a Child (and not an IntChild) when used as the root object.
I think the behaviour should be to have Child everywhere. In a more generic way:
class GenericChild(MyGeneric[T]):
    ...
 class Child(MyGeneric[int]):
 ...
 class Parent:
    generic_child : GenericChild[MyGeneric[int]]
   concrete_child: Child

should give:
type Parent {
   genericChild: IntGenericChild # This is a true generic which needs to be given details
   concreteChild: Child # This is not a generic anymore and doesn't need details
}

What do you say?

I can reproduce this: https://play.strawberry.rocks/?gist=2cba09383bbb8edc0353eb06de8ff2d6
The issue is that just for Parent.child, right?
type Child {
  attr: Int!
}

type IntChild {
  attr: Int!
}

type Parent {
-  child: IntChild!
+  child: Child!
  children: [Child!]!
  maybeChild: Child
  annotatedChild: Child!
}

type Query {
  parent: Parent!
}

Exactly.


Functional Options: Create a relative package, set the link

Hi @tmrts, First of all I don't want this to act like 'advertisement' ( I personally don't like 'advertisements' in github), if it's acted like that then do not approve this PR.
I made a package only to help readers of this go-patterns repository to understand how they can extend Pattern: Functional Options to fit to their needs, so I added a section with relative links of this particular pattern. I could also recommend search and do the same for other patterns, it's good to add relative links  in order to see how they(readers) can extend a pattern, it will help to understand better the subject, I hope.

@kataras I have no problem with people advertising their good implementations and I'd be happier if they got publicity from it. And I believe iris is a very clean framework kudos!
Its a good idea to link more in-depth real-world examples at the end of patterns too
Thanks for the suggestion and the PR, I only have comments about naming and linking other than that I'm fine with it


"native" accessor method for sections

Hi,
I'm working on a new project using site_prism and I'm pretty pumped about it.  So first off, thanks!  :)
Feature request: I'm using applitools eyes to take screenshots of regions of the page.  To take a screenshot of a region, I need to give the applitools gem a native selenium element.  It would be helpful if sections had a helper method to make this easier.
Image this page model:
class Home < SitePrism::Page
  element :search_field, "input[name='q']"
  section :menu, MenuSection, "#gbx3"
end

For a site_prism element, the capybara native method is already there, so my code is very clean:
eyes.check_region(:element, @home.search_field.native, "my search field")

For a site_prism section, the capybara native method isn't there, so I always have to go through the root_element, which is a bit awkward:
eyes.check_region(:element, @home.menu.root_element.native, "my menu")

What I'd like todo, if you are cool with it, is an open a pull request to add this helper:
class SitePrism::Section
  def native
    root_element.native
  end
end

So that my code could look like this:
eyes.check_region(:element, @home.menu.native, "my menu")

Does this sound like a good change?  It's working in my project but are there stumbling blocks you can think of which I'm not aware of?
Thanks,
Tom

I think this is a useful idea Tom. (Upvote)

@Carlbc18 - thanks!  :)
@natritmeyer - any thoughts on this?  Good idea?  Terrible idea?  If you like it, I'll open up a pull request with tests.

Great idea :)

Hi there. You've raised a good point, and in short we're curious to know where you got to with t.
If you're happy landing the PR yourself, then feel free to do so. Ideally you need to make sure that you include some Documentation and a snippet or SSCCE to test against so we can see your code in action.
Even better would be 2 SSCCE's. One where it fails and one where it works (But this isn't 100% necessary)
Can you give us an update when you're available to, as to where you're at with this.

Closing in favour of https://github.com/natritmeyer/site_prism/pull/223


ValueError: cannot convert float NaN to integer during Predict sometimes at runtime

Also mentioned in the closed issue here:
https://github.com/jeasinema/VoxelNet-tensorflow/issues/13
predict ['007029' '006278' '007221' '005063']
/home/tensorflow/lib/python3.5/site-packages/numpy/core/_methods.py:29: RuntimeWarning: invalid value encountered in reduce
  return umr_minimum(a, axis, None, out, keepdims)
Traceback (most recent call last):
  File "train.py", line 142, in <module>
    tf.app.run(main)
  File "/home/tensorflow/lib/python3.5/site-packages/tensorflow/python/platform/app.py", line 124, in run
    _sys.exit(main(argv))
  File "train.py", line 118, in main
    sess, valid_loader.load(), summary=True)
  File "/home/Work/VoxelNet-tensorflow/model/model.py", line 320, in predict_step
    batch_gt_boxes3d[0])
  File "/home/Work/VoxelNet-tensorflow/utils/utils.py", line 339, in draw_lidar_box3d_on_image
    projections = lidar_box3d_to_camera_box(boxes3d, cal_projection=True)
  File "/home/Work/VoxelNet-tensorflow/utils/utils.py", line 298, in lidar_box3d_to_camera_box
    minx = int(np.min(points[:, 0]))
ValueError: cannot convert float NaN to integer

Hi!
I have the same problem, do you have solve it?

Sorry, I don't have a proper solution for this. But the problem seems to be in the summary part where the predicted bounding boxes are converted to camera coordinates for plotting on images.

Hi!
I have the same problem, have you solved it?

Hi!
I have the same problem, have you solved it?


Support other URI patterns

When an application is bound to the service, it will receive a credentials hash with an URI following this pattern: mongodb://admin:<RANDOM PASSWORD>@<HOST IP>:<HOST PORT MAPPED TO CONTAINER PORT 27017/tcp>/<RANDOM DBNAME>.
Some database uris, such as influxdb, don't follow this pattern. Uris are then  defined without database specificed as uri path ( ex : http://admin:<RANDOM PASSWORD>@<HOST>:<PORT> )
Just wondering if such a pattern could be supported  ?
Thanks

Can you give prefix: http a try?

Hi @drnic,
Thanks for your quick response.
Specifying http as a scheme gives me following uri : `http://admin:password@host:port/dbnamewhereas influxdb requireshttp://admin:password@host:port``

https://github.com/cloudfoundry-community/cf-containers-broker/blob/master/app/models/credentials.rb#L97
You should only get the suffix dbname if you've included it in your service plan.

Thanks for your help @drnic.
Indeed, on service binding I would need to get something credentials like this :
"credentials": {
     "dbname": "dsrm0paktgy63qzl",
      "uri": "http://<user>:<password>@<host>:<port>",
	 ...
    },

where

dbname is still set by the service broker
uri does not contain any dbname value

Awesome


fix: serialize datetime objects as strings

Description
This PR fixes an issue when serializing as JSON the course data where some attributes were dates cannot be encoded by default. We use the code from event-tracking to allow the serialization of datetime objects as JSON.
Merge checklist:
Check off if complete or not applicable:

[ ] Version bumped
[ ] Changelog record added
[ ] Documentation updated (not only docstrings)
[ ] Fixup commits are squashed away
[ ] Unit tests added/updated
[ ] Manual testing instructions provided
[ ] Noted any: Concerns, dependencies, migration issues, deadlines, tickets

Thanks for the pull request, @Ian2012! Please note that it may take us up to several weeks or months to complete a review and merge your PR.
Feel free to add as much of the following information to the ticket as you can:

supporting documentation
Open edX discussion forum threads
timeline information ("this must be merged by XX date", and why that is)
partner information ("this is a course on edx.org")
any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.
Please let us know once your PR is ready for our review and all tests are green.

I'd rather not bring in event-tracking and all of its sub-dependencies just for this one small class that has basically not changed in 11 yrs. I'd rather just copy it in, or use an altered version of the accepted SO answer with the addition of the very good UTC changes from event-tracking.

@Ian2012 🎉 Your pull request was merged!  Please take a moment  to answer a two question survey so we can improve your experience in the future.


Add CODEOWNERS for /docs/open-source/

Thanks for contributing to the Harness Developer Hub! Our code owners will review your submission.
Description

Please describe your changes: Add CODEOWNERS for /docs/open-source/
Jira/GitHub Issue numbers (if any): ______________________________
Preview links/images (Internal contributors only): __________________

PR lifecycle
We aim to merge PRs within one week or less, but delays happen sometimes.
If your PR is open longer than two weeks without any human activity, please tag a code owner in a comment.
PRs must meet these requirements to be merged:

[ ] Successful preview build.
[ ] Code owner review.
[ ] No merge conflicts.
[ ] Release notes/new features docs: Feature/version released to at least one prod environment.

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://66fc04be537e8d4abff92a9e--harness-developer.netlify.app


The setValue and setKey state-setters do not take callback functions

Is your feature request related to a problem? Please describe.
The setValue and setKey state-setters do not take callback functions.
Describe the solution you'd like
To make the hook as React-y as possible, these state-setters should optionally take a callback function.
Describe alternatives you've considered
Leaving as-is, but that could cause async issues and potentially stale data

I'm working on this right now

I'm working on this right now


add analyticswithali's file

created a branch, created a file and made a commit, and opened a pull request


[CUBRID] Uppercase for Reserved Keyword in SQL Editor

Describe

Change SQL Editor default case(lowercase) to uppercase for reserved keyword.

Thank you for request.


Allow access for Runtime struct?

Hi
I'm trying to benchmark tokio-uring and different implementations. As criterion requires Runtime struct to run async code, I'd like to ask for changing Runtime struct visibility.
Is it valid change or any other viable solution to achieve it?
Thanks

I just found recent PR(https://github.com/tokio-rs/tokio-uring/pull/88) to achieve it.

I think it might be useful to constrain this issue to something like "make tokio-uring work with criterion" - whatever makes that work is fine by me, at least. Does anyone have any other reasons for referencing the Runtime struct?

For an API, I think it should look like the normal tokio runtime API, except with only spawn, block_on, new, and spawn_blocking. We can add a handle as well, either here or later.

So you are thinking of making the struct public with public implementations with the same signature as those methods? I might be able to have a look in the next few days. Or, if you want it, please go ahead. I don't know what I'm doing and I don't get in the way.

When I pull this locally I get a few test failures randomly - explicit_close and drop_off_runtime and sometimes the tests hang around the same place. Is that normal?

What kernel do you have?

Linux porco 5.19.5-arch1-1 #1 SMP PREEMPT_DYNAMIC Mon, 29 Aug 2022 15:51:05 +0000 x86_64 GNU/Linux

@nik9000 see #119.

When I pull this locally I get a few test failures randomly - explicit_close and drop_off_runtime and sometimes the tests hang around the same place. Is that normal?

As you indicated in #119, that problem from Sep seems fixed.

I'm glad the question of a handle came up in this thread already.


Feature request: add support for passing command-line arguments to BugCheckers

I've been working on a plugin check for Error Prone, implemented as described here:
http://errorprone.info/docs/plugins
For my checker, it would be great if I could pass in configuration flags via the command line.  I can work pass flags using JVM system properties or -XD, but those options are a bit hackish.  An officially sanctioned way to pass flags to a checker would be great.

Note that as part of this feature we may need a new way to initialize checkers.  I think right now plugin checkers are created via a zero-argument constructor.

previously: https://groups.google.com/d/topic/error-prone-discuss/aDsIo2LEhr8/discussion
@eaftan pointed out in the thread that this would help with #512.

New Error Prone command line args are in the latest snapshot and ready to use! Check out the documentation at http://errorprone.info/docs/flags

Thanks @epmjohnston!  We'll be trying these soon.


AVRO-3248 Rust: Support named types in UnionSchema

Drop the index map in UnionSchema. It is not common to have many schemata in the union. Usually it is either "null"+otherType or just a few of otherType. Iterating over a short list is not that slow
Jira

[X] My PR addresses the following AVRO-3248 issue

Tests

[X] My PR adds new unit tests

Commits

[X] My commits all reference Jira issues in their subject lines.

I checked and ur solution seems to be wrong if we have a union like this
["A", "B"]
where A and B are like this –
// A and B are the same except the name.
let schema_str_1 = r#"{
"name": "A",
"type": "record",
"fields": [
{"name": "field_one", "type": "float"}
]
}"#;
let schema_str_2 = r#"{
"name": "B",
"type": "record",
"fields": [
{"name": "field_one", "type": "float"}
]
}"#;
in this case, the schema found by a value will always be "A"'s schema.
this also applies to A, B being "fixed" type, which seems more plausible in reallife (for example A =
{"name": "fieldA", "type": "fixed", "size": 10}
, B =
{"name": "fieldB", "type": "fixed", "size": 10}
)
here is my PR for these scenario . https://github.com/apache/avro/pull/1396

Closed in favour of https://github.com/apache/avro/pull/1396


[Discussion] Remove dependency on ngrx store (in particular on ActionSubject)

Intro
First of all thanks for coming up with this amazing library, it's just the perfect tool for handling the dependencies between controls  - how updates of one control impacts values, validation, etc. on other controls.
Description
Every directive has ngrx's ActionSubject injected into its constructor which is used to dispatch actions to the store (e.g. the control's directive).
I would like to propose adding another directive that makes the output of actions explicit:
In your component you could listen for those actions and update the local component's state yourself,
dispatching any additional data loading or validation asynchronous requests:
// my-component.ts
@Component({
  selector: 'my-component',
  template: `
    <form novalidate
        [ngrxFormState]="(formState$ | async)"
        (ngrxFormState)="handleAction($event)">

    <input type="text"
        [ngrxFormControlState]="(formState$ | async).controls.countryCode"
        (ngrxFormControlState)="handleAction($event)">

    <input type="text"
        [ngrxFormControlState]="(formState$ | async).controls.country"
        (ngrxFormControlState)="handleAction($event)">

    </form>
  `,
})
export class MyComponent {
    const formState: FormGroupState<MyFormValue> = undefined;

    constructor(private actionSubject: ActionSubject) {
    }

    ngOnInit() {
        this.actionSubject.subscribe(action => {
            this.formState = myComponentReducer(this.formState, action);
        });
    }

    handleAction(action: Action) {
        this.actionSubject.next(action);
        if (action.payload.controlId === 'countryCode') {
            // this triggers loading in effect
            this.actionSubject.next(new RequestCountry({ countryCode: action.payload.value }));
        }
    }
}

// reducer.ts - although I would even inline this into component
const initialState: ComponentState = {
  loadCountryForCountryCode: null,
  myForm: initialFormState
};

export function myComponentReducer(state = initialState, action: Action): ComponentState {
    const myForm = formGroupReducer(state.myForm, action);
    if (myForm !== state.myForm) {
        state = { ...state, myForm };
    }

    switch (action.type) {
        // response from effect
        case RespondCountry: {
            state = {
                ...state,
                myForm = formStateReducer(state.myForm, new SetValueAction('country', action.payload.value))
            }
            return state;
        }
        // ...
        default: {
            return state;
        }
    }
}

Motivation
I think is the missing link to the ngrx-ecosystem:

You have local, component state which perishes after component is destroyed and does not taint global state.
You have a way of dealing with form state that can become quite complex and inter-dependent using easy-to-reason and easy-to-test pure functions (read: reducers).
You often use forms in modal dialog popups that cease to exist after they are submitted to server.
Global state is updated after the request returns from server with the entity you just created / updated, which you now see in your list, table, etc.

Implementation
As easy as wrapping the current directives into new directives,
while passing an @EventEmitter to the constructor of the original directive.
Conclusion
What do you think?

Yeah, makes sense. In fact, I started doing something similar once by extracting all the form state logic into a separate library that doesn't depend on Angular. The idea was to then write specific adapters for each framework, but also to allow using it directly for local component state as you did. I even used it like this in one of my projects and it worked quite well (the usage was basically exactly what you are suggesting with having a local reducer in the component).
I haven't updated that fork in some time, so there's probably some drift compared to ngrx-forms itself, but that should be simple enough to fix. However, I am not 100% certain how I could add this to ngrx-forms itself without breaking the existing behavior (which all consumers of course depend on).
Thinking about it, this could be a property on the form state itself set when you create it. And then in the directive based on this property the actions are either emitted on an EventEmitter or on the global ActionsSubject.

Great, PR coming right up with [createLocalFormState] directive input

Resolved through #166


Partitioning mis-match can lead to bad query results in Realtime

The current code simply assumes partitionId from kafka partition to be in accordance with the partition function defined in table config. In case there is a mis-match on kafka partition and what's set in table config, that leads to incorrect pruning of segments causing bad results for query.
There was indeed an old behavior were we wiped out the incorrect partition metadata when committing the segment, which would limit the scope to consuming queries. At the very minimum, we should bring back that behavior. This is important as we can run into these issues in various situations:

Increase in number of partitions from Kafka side.
Partition function change on either side (accidental or intentional).

Fix for the issue: #6031

Perf testing branch which removes the partition info for consuming segments: https://github.com/apache/incubator-pinot/tree/remove_consuming_partition_info

Removing the partition info for consuming segments could cause performance degradation for extremely high QPS use cases. Filed #6078 as a work-around without performance impact.


Theme changes to blue for a bit whenever I skip songs, happens on playlists only

Describe the bug
 As what the title says, it happens when I skim through songs, only on playlists but not on albums.
To Reproduce
Steps to reproduce the behavior:

Pull any playlist you have in your library
skip songs

Screenshots

https://user-images.githubusercontent.com/100902107/156711921-654676b7-b8fd-404b-8ca8-e6d16da585ff.mp4
Desktop Setup

Operating System:  Windows 10
Spotify:   <IP_ADDRESS>9
Spicetify:  2.9.2
Dribbblish:  4.1.2

Duplicate of #179 ?

maybe, but it's still a recurring error even tho I'm using the latest version which has the fix

Should be closed in latest builds


Cleared Statement Reappears Briefly When Deleting Comment Changes

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Access the staging Expensify website.
Open any chat and write a message.
Hover over the message and click on the edit icon.
Clear the message and click on the save changes icon.
Observe that the delete page popup appears, click on the delete button.
Notice that the cleared statement briefly reappears before being deleted.

Expected Result:
When clearing and deleting a comment, the cleared statement should not reappear even briefly.
Actual Result:
The cleared statement reappears briefly when deleting comment changes.
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[x] MacOS / Chrome / Safari
[ ] MacOS / Desktop

Version Number: 1.3.56-3
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://github.com/Expensify/App/assets/38435837/46086de4-0e5b-423e-8d99-f51e0b51e6eb
https://github.com/Expensify/App/assets/38435837/7cfe95f7-91da-4b90-b53a-c4a896f4b358
Expensify/Expensify Issue URL:
Issue reported by: @tewodrosGirmaA
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1692693288512319
View all open jobs on GitHub

:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

Unable to repro in DEV

I can reproduce on staging, cannot reproduce on production. Not sure if it's a deploy blocker, but looking into possible offending PRs.

I can reproduce on Dev too.

Reverting https://github.com/Expensify/App/pull/24544 fixes this, I am going to send the revert.

Seems regression from this PR
Currently whenever report action updates it executes setDraft here and return condition will be false
https://github.com/Expensify/App/blob/eef7f066a673aa62e101b7f946b740daa51ae715/src/pages/home/report/ReportActionItemMessageEdit.js#L114-L119
I think we can add 1 more condition to return early when action message is empty.
if (!props.action.message[0].text || props.draftMessage === props.action.message[0].html) {

Thanks for looking @Pujan92 - I am glad we came to the same conclusion. I am going to revert as I think this will get this fixed the fastest, then we can work with the original author to improve their original PR.

Fine 👍

This was deployed.

Hy @AndrewGable am I eligible for payment?

Yes!

Hello @johncschuster, I didn't get the offer letter incase if you sent it to another person. Thank you

Hello @johncschuster , the payment deadline has passed, but I have not received either the offer or payment. Could you kindly assist me with this matter?

@tewodrosGirmaA - it's a little hard to keep track of our issue comments but have reopened the issue so that @johncschuster can issue payment. Thanks for your patience!
@johncschuster - looks like the reporting bonus is still owed here.

Thank you

Hi @tewodrosGirmaA sorry for missing that! Let me dig in now and get things sorted.

Adding the External label so the job gets created.

@tewodrosGirmaA can you accept the offer for the Reporter role?

I accept  it thank you

Ah yes, I see the merge date was Aug 28, which is 2 days before the change was made (Slack announcement here).

@tewodrosGirmaA it looks like you've accepted the Contributor job, which is incorrect. Can you please accept the Report job instead?

Excuse me, @johncschuster. I apologize for my mistake earlier. I was on the bus and didn't read carefully. I noticed that you had sent me two offers, but this issue was created before August 31st, which means the offer should be $250. However, you had offered $50 instead. Could you please clarify? Thank you

Thank you 😊

@tewodrosGirmaA I've extended an offer for $250. Can you accept that one when you get a moment? I'll get that payment issued right away.

@johncschuster , I accept  it , Thank you 😊

Payment issued! Thanks, @tewodrosGirmaA!

Summary of payments:
Reporter: @tewodrosGirmaA - $250
Reviewer: @0xmiroslav - $1000
Both paid via Upwork


Diarization should be improved for audio with >2 speakers

Issue
Current diarization works OK for single and two-speaker conversations. However, things get messy when guessing the number of speakers for multi-speaker conversations (>2 speakers). In this case agglomerative clustering is not enough.
Proposal
Try Nvidia Nemo's diarizer as shown in this notebook and see if diarization for multi-speaker conversations gets improved.

Adding this library as a reference as well: https://github.com/MahmoudAshraf97/whisper-diarization
It uses faster-whisper and Nemo for STT+diarization


Tag/Topic compression - back end or front end?

I was looking into using cascade filtering to combine tags for the Topics menu page.
Using cascades on the front end would be more accessible to most people. Unfortunately, the cascades make tag/topic counts very challenging. A single url may be represented by several tags that all combine to form one tag. Working the cascade backwards turns out to be problematic. I could only do it using wikify, which doesn't work on the main topics page because of performance issues.
A version of this approach would be to use the cascade filters in conjunction with a data dictionary, so that the reverse lookup process would not be so intensive. This would require keeping the cascade and the data dictionary in synch. Possibly by generating the dictionary from the cascade.
A completely different approach would be to have, perhaps, a JSON file of conversions that is used on the backend when the wikis are downloaded and analyzed. This approach would produce a clean slate of url tiddlers that would be already encoded. This would make display counts straightforward. In fact, nothing on the front end would have to change. But since it's done in javascript, it would be a little less accessible to the general public. I say "a little less", because there doesn't seem to be that much engagement in the first place.
So I'm looking for feedback which approach, if any, would be preferable. Thanks!

I was curious who would run the UI? Would there be a backdoor tiddlywiki.org presence?


Test contentCollectionCache

Please ignore

Lunaria Status Overview
🌕 This pull request will trigger status changes.

Learn more
By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.
You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

Locale
File
Note

en
recipes/build-forms.mdx
Source changed, localizations will be marked as outdated.

Warnings reference

Icon
Description

🔄
The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.


[rlgl] Complements the #4348 GPU skinning fix

Rationale: although it may not get defined in config.h#L124-L132, it ends up always getting defined on rlgl.h#L350-L355 defaults, which is more noticeable when using rlgl standalone.
CC @JeffM2501 for review.

@asdqwe Thanks for the improvement!
Actually, I'm considering exposing a new config flag for RL_SUPPORT_MESH_GPU_SKINNING.

@raysan5 That would be super helpful, specially for 2D oriented builds that wouldn't use GPU skinning.


Update the sample machineset config with the new provider config

What this PR does / why we need it: Fix up the sample config files.
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Special notes for your reviewer:
Release note:

NONE

@kubernetes/kube-deploy-reviewers

/lgtm


Raise error if target storage class is AbstractFileSystem

Recently observed by @jbusecke and @rsignell-usgs, if the config file is not picked up, we are not erroring out early enough.

Per conversion with @rsignell-usgs, probably if we specify a config file (and it's not found) that should be an error as well.

Closing as dupe of https://github.com/pangeo-forge/pangeo-forge-runner/issues/73

Is this fully a dupe? This should also error out if no target/cache filesystem is in an (existing) config?

@jbusecke yeah that's fair, re-opening


RuntimeError: new(): expected key in DispatchKeySet(CPU, CUDA, HIP, XLA, MPS, IPU, XPU, HPU, Lazy, Meta) but got: PrivateUse1

🐛 Describe the bug
Microsoft directml custom backend for pytorch gpu acceleration in WSL receives error in huggingface transormer .generate method.
directml_torch reference:
https://learn.microsoft.com/en-us/windows/ai/directml/gpu-pytorch-windows
huggingface transformer reference: https://github.com/huggingface/transformers/blob/v4.26.1/src/transformers/generation/utils.py#L2424
import torch
import torch_directml
dml = torch_directml.device()

tensor1 = torch.tensor([1]).to(dml)
tensor2 = torch.tensor([2]).to(dml)

tensor1 = tensor1.new(tensor1.shape[0]).fill_(0)
tensor2 = tensor2.new(tensor2.shape[0]).fill_(0)

print("sum:", (tensor1 + tensor2).item())

---------------------------------------------------------------------------
RuntimeError                              Traceback (most recent call last)
Cell In[24], line 8
      5 tensor1 = torch.tensor([1]).to(dml)
      6 tensor2 = torch.tensor([2]).to(dml)
----> 8 tensor1 = tensor1.new(tensor1.shape[0]).fill_(0)
      9 tensor2 = tensor2.new(tensor2.shape[0]).fill_(0)
     11 print("sum:", (tensor1 + tensor2).item())

RuntimeError: new(): expected key in DispatchKeySet(CPU, CUDA, HIP, XLA, MPS, IPU, XPU, HPU, Lazy, Meta) but got: PrivateUse1

Versions
Collecting environment information...
PyTorch version: 1.13.1
Is debug build: False
CUDA used to build PyTorch: None
ROCM used to build PyTorch: N/A

OS: Ubuntu 22.04.2 LTS (x86_64)
GCC version: (Ubuntu 11.3.0-1ubuntu1~22.04) 11.3.0
Clang version: Could not collect
CMake version: version 3.22.1
Libc version: glibc-2.35

Python version: 3.8.16 (default, Jan 17 2023, 23:13:24)  [GCC 11.2.0] (64-bit runtime)
Python platform: Linux-<IP_ADDRESS>-microsoft-standard-WSL2-x86_64-with-glibc2.17
Is CUDA available: False
CUDA runtime version: No CUDA
CUDA_MODULE_LOADING set to: N/A
GPU models and configuration: No CUDA
Nvidia driver version: No CUDA
cuDNN version: No CUDA
HIP runtime version: N/A
MIOpen runtime version: N/A
Is XNNPACK available: True

CPU:
Architecture:                    x86_64
CPU op-mode(s):                  32-bit, 64-bit
Address sizes:                   48 bits physical, 48 bits virtual
Byte Order:                      Little Endian
CPU(s):                          32
On-line CPU(s) list:             0-31
Vendor ID:                       AuthenticAMD
Model name:                      AMD Ryzen 9 5950X 16-Core Processor
CPU family:                      25
Model:                           33
Thread(s) per core:              2
Core(s) per socket:              16
Socket(s):                       1
Stepping:                        0
BogoMIPS:                        6800.05
Flags:                           fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ht syscall nx mmxext fxsr_opt pdpe1gb rdtscp lm constant_tsc rep_good nopl tsc_reliable nonstop_tsc cpuid extd_apicid pni pclmulqdq ssse3 fma cx16 sse4_1 sse4_2 movbe popcnt aes xsave avx f16c rdrand hypervisor lahf_lm cmp_legacy svm cr8_legacy abm sse4a misalignsse 3dnowprefetch osvw topoext perfctr_core ssbd ibrs ibpb stibp vmmcall fsgsbase bmi1 avx2 smep bmi2 erms invpcid rdseed adx smap clflushopt clwb sha_ni xsaveopt xsavec xgetbv1 xsaves clzero xsaveerptr arat npt nrip_save tsc_scale vmcb_clean flushbyasid decodeassists pausefilter pfthreshold v_vmsave_vmload umip vaes vpclmulqdq rdpid fsrm
Virtualization:                  AMD-V
Hypervisor vendor:               Microsoft
Virtualization type:             full
L1d cache:                       512 KiB (16 instances)
L1i cache:                       512 KiB (16 instances)
L2 cache:                        8 MiB (16 instances)
L3 cache:                        32 MiB (1 instance)
Vulnerability Itlb multihit:     Not affected
Vulnerability L1tf:              Not affected
Vulnerability Mds:               Not affected
Vulnerability Meltdown:          Not affected
Vulnerability Mmio stale data:   Not affected
Vulnerability Retbleed:          Not affected
Vulnerability Spec store bypass: Mitigation; Speculative Store Bypass disabled via prctl and seccomp
Vulnerability Spectre v1:        Mitigation; usercopy/swapgs barriers and __user pointer sanitization
Vulnerability Spectre v2:        Mitigation; Retpolines, IBPB conditional, IBRS_FW, STIBP always-on, RSB filling, PBRSB-eIBRS Not affected
Vulnerability Srbds:             Not affected
Vulnerability Tsx async abort:   Not affected

Versions of relevant libraries:
[pip3] numpy==1.22.4
[pip3] torch==1.13.1+rocm5.2
[pip3] torch-directml==<IP_ADDRESS>.dev230119
[pip3] torchaudio==0.13.1+rocm5.2
[pip3] torchdata==0.5.1
[pip3] torchtext==0.14.1
[pip3] torchvision==0.14.1+rocm5.2
[conda] blas                      1.0                         mkl
[conda] mkl                       2022.1.0           hc2b9512_224
[conda] numpy                     1.22.4                   pypi_0    pypi
[conda] pytorch                   1.13.1              py3.8_cpu_0    pytorch
[conda] pytorch-mutex             1.0                         cpu    pytorch
[conda] torch                     1.13.1+rocm5.2           pypi_0    pypi
[conda] torch-directml            <IP_ADDRESS>.dev230119          pypi_0    pypi
[conda] torchaudio                0.13.1+rocm5.2           pypi_0    pypi
[conda] torchdata                 0.5.1                    pypi_0    pypi
[conda] torchtext                 0.14.1                   pypi_0    pypi
[conda] torchvision               0.14.1+rocm5.2           pypi_0    pypi

linked pytorch issue: https://github.com/pytorch/pytorch/issues/95734

Resolved by https://github.com/pytorch/pytorch/pull/95748

I am facing the same problem, would you please tell me how to solve it. Thanks in advance.

See this commit to pytorch: https://github.com/pytorch/pytorch/pull/95748/files
It hasn't been released yet so only option is to build from source currently. I haven't verified the fix, but plan to shortly.

Reopening until this gets into a supported pytorch release.  It looks like using a locally patched version of pytorch isn't possible due to dependencies in torch_directml_native

I got this working after a lot of work figuring out how to run a locally patched pytorch build that satisfied all of the statically linked symbols in torch_directml_native.cpython-38-x86_64-linux-gnu.so (<IP_ADDRESS>.dev230119).
I was also able to get hugging face transformers working with directML after a monkey patch.  Happy to share if anyone else is stuck on this.

How to solve it? Can you please tell me? And another issue is notebook crashes while training T5 transformer model using dml. Thanks in advance.

This should get you pretty close (ubuntu 22.04) for the patched pytorch build (cpu only).  Wheels will be in the artifacts directory:
sudo apt-get install -y g++-10
sudo update-alternatives --install /usr/bin/gcc gcc /usr/bin/gcc-10 30
sudo update-alternatives --install /usr/bin/g++ g++ /usr/bin/g++-10 30
sudo update-alternatives --install /usr/bin/gcov gcov /usr/bin/gcov-10 30

git clone --recursive --branch v1.13.1 https://github.com/pytorch/pytorch
git clone --recursive --branch release/1.13 https://github.com/pytorch/builder

cd pytorch
git cherry-pick --no-commit cbec22fe6e1b5d8716a2daf056c773252b220dea
! sudo git submodule sync
! sudo git submodule update --init --recursive
cd ..
mkdir -p artifacts

sudo su -p
conda create --name pytorch -y python=3.10
conda activate pytorch
conda install cmake ninja -y

export CMAKE_PREFIX_PATH=${CONDA_PREFIX:-"$(dirname $(which conda))/../"}
export PYTORCH_BUILD_VERSION=1.13.1+cpu
export PYTORCH_BUILD_NUMBER=1
export _GLIBCXX_USE_CXX11_ABI=0
export CXXFLAGS=-D_GLIBCXX_USE_CXX11_ABI=0
export DESIRED_PYTHON=3.10
export BUILD_SPLIT_CUDA=1
export PYTORCH_ROOT=./pytorch
export PYTORCH_FINAL_PACKAGE_DIR=./artifacts
export GPU_ARCH_TYPE=cpu
export USE_NUMA=OFF
export USE_MPI=OFF
export USE_CUDA=OFF
export USE_MKLDNN=OFF

bash ./builder/common/install_mkl.sh
bash ./builder/common/install_patchelf.sh
bash ./builder/manywheel/build.sh > build.log  2>&1

After I compiled pytorch_cpu by myself and installed it, it returned an error with import torch_directml
>>> import torch_directml
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "C:\Users\lizel\AppData\Local\Packages\PythonSoftwareFoundation.Python.3.10_qbz5n2kfra8p0\LocalCache\local-packages\Python310\site-packages\torch_directml\__init__.py", line 16, in <module>
    import torch_directml_native
ImportError: DLL load failed while importing torch_directml_native: The specified module could not be found.

This should get you pretty close (ubuntu 22.04) for the patched pytorch build (cpu only). Wheels will be in the artifacts directory:
sudo apt-get install -y g++-10
sudo update-alternatives --install /usr/bin/gcc gcc /usr/bin/gcc-10 30
sudo update-alternatives --install /usr/bin/g++ g++ /usr/bin/g++-10 30
sudo update-alternatives --install /usr/bin/gcov gcov /usr/bin/gcov-10 30

git clone --recursive --branch v1.13.1 https://github.com/pytorch/pytorch
git clone --recursive --branch release/1.13 https://github.com/pytorch/builder

cd pytorch
git cherry-pick --no-commit cbec22fe6e1b5d8716a2daf056c773252b220dea
! sudo git submodule sync
! sudo git submodule update --init --recursive
cd ..
mkdir -p artifacts

sudo su -p
conda create --name pytorch -y python=3.10
conda activate pytorch
conda install cmake ninja -y

export CMAKE_PREFIX_PATH=${CONDA_PREFIX:-"$(dirname $(which conda))/../"}
export PYTORCH_BUILD_VERSION=1.13.1+cpu
export PYTORCH_BUILD_NUMBER=1
export _GLIBCXX_USE_CXX11_ABI=0
export CXXFLAGS=-D_GLIBCXX_USE_CXX11_ABI=0
export DESIRED_PYTHON=3.10
export BUILD_SPLIT_CUDA=1
export PYTORCH_ROOT=./pytorch
export PYTORCH_FINAL_PACKAGE_DIR=./artifacts
export GPU_ARCH_TYPE=cpu
export USE_NUMA=OFF
export USE_MPI=OFF
export USE_CUDA=OFF
export USE_MKLDNN=OFF

bash ./builder/common/install_mkl.sh
bash ./builder/common/install_patchelf.sh
bash ./builder/manywheel/build.sh > build.log  2>&1

How can I do this in Windows env?

It seems that pytorch-2.0.0's code does not include this change. In the file, torch/csrc/utils/tensor_new.cpp, it does not include PrivateUse1, though it is there in the main branch.

How can I do this in Windows env?

Haven't tried it on windows, but you can probably start with the builder scripts for windows here: https://github.com/pytorch/builder/tree/release/1.13/windows

It seems that pytorch-2.0.0's code does not include this change. In the file, torch/csrc/utils/tensor_new.cpp, it does not include PrivateUse1, though it is there in the main branch.

Correct this commit has not been included in an official pytorch release yet (it seems torch-directml is only built against the latest pytorch 1.x release) - hence the git cherry-pick when building locally.

How can I do this in Windows env?

Haven't tried it on windows, but you can probably start with the builder scripts for windows here: https://github.com/pytorch/builder/tree/release/1.13/windows

It seems that pytorch-2.0.0's code does not include this change. In the file, torch/csrc/utils/tensor_new.cpp, it does not include PrivateUse1, though it is there in the main branch.

Correct this commit has not been included in an official pytorch release yet (it seems torch-directml is only built against the latest pytorch 1.x release) - hence the git cherry-pick when building locally.

Thank you for your reply! But I still encountered many errors when I execute your commands in the WSL2 to compile pytorch-1.13.1 by myself. It's exhausting.
Would you love to share the wheels you compiled? I will be so appreciated for that!

If it helps @Looong01, locally compiled wheel (Ubuntu 22.04 dependant) is here: https://file.io/jZYHjII2ocMM (one-time download)

If it helps @Looong01, locally compiled wheel (Ubuntu 22.04 dependant) is here: https://file.io/jZYHjII2ocMM (one-time download)

Thank you very much! It works.

This should get you pretty close (ubuntu 22.04) for the patched pytorch build (cpu only). Wheels will be in the artifacts directory:
sudo apt-get install -y g++-10
sudo update-alternatives --install /usr/bin/gcc gcc /usr/bin/gcc-10 30
sudo update-alternatives --install /usr/bin/g++ g++ /usr/bin/g++-10 30
sudo update-alternatives --install /usr/bin/gcov gcov /usr/bin/gcov-10 30

git clone --recursive --branch v1.13.1 https://github.com/pytorch/pytorch
git clone --recursive --branch release/1.13 https://github.com/pytorch/builder

cd pytorch
git cherry-pick --no-commit cbec22fe6e1b5d8716a2daf056c773252b220dea
! sudo git submodule sync
! sudo git submodule update --init --recursive
cd ..
mkdir -p artifacts

sudo su -p
conda create --name pytorch -y python=3.10
conda activate pytorch
conda install cmake ninja -y

export CMAKE_PREFIX_PATH=${CONDA_PREFIX:-"$(dirname $(which conda))/../"}
export PYTORCH_BUILD_VERSION=1.13.1+cpu
export PYTORCH_BUILD_NUMBER=1
export _GLIBCXX_USE_CXX11_ABI=0
export CXXFLAGS=-D_GLIBCXX_USE_CXX11_ABI=0
export DESIRED_PYTHON=3.10
export BUILD_SPLIT_CUDA=1
export PYTORCH_ROOT=./pytorch
export PYTORCH_FINAL_PACKAGE_DIR=./artifacts
export GPU_ARCH_TYPE=cpu
export USE_NUMA=OFF
export USE_MPI=OFF
export USE_CUDA=OFF
export USE_MKLDNN=OFF

bash ./builder/common/install_mkl.sh
bash ./builder/common/install_patchelf.sh
bash ./builder/manywheel/build.sh > build.log  2>&1

BTW, I want to ask which lines of your codes are the key points to avoid the errors of torch_directml_native when we run a locally patched pytorch build? Where is the difference between the official compiling steps and yours?
So that I can reproduce it on Windows env. Thank you very much!

git cherry-pick --no-commit e6e1b5d8716a2daf056c773252b220dea

its just this line that addresses the issue (since the pytorch team agreed to fix🙏), which is just applying this commit (https://github.com/pytorch/pytorch/commit/cbec22fe6e1b5d8716a2daf056c773252b220dea) onto the local v1.13.1 source code.
if you already have a working windows build based on v1.13.1 branch source, i would think this should be the only change you need.
i did see that pytorch 2.0 was recently released, and you are correct that the change hasn't made it in there yet (maybe next release?): https://github.com/pytorch/pytorch/compare/cbec22f..v2.0.0#diff-dafad7c78f9f0da499157bce059930b4945084a73ed7bbf52719c714d29cc0ab

Will this be fixed in a 1.13.2 release? Probably it will take some time to get a compiled version with the fix included.

Reopening until this gets into a supported pytorch release. It looks like using a locally patched version of pytorch isn't possible due to dependencies in torch_directml_native

I mean that how did you solve this problem? Was that the same with the following?

After I compiled pytorch_cpu by myself and installed it, it returned an error with import torch_directml
>>> import torch_directml
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "C:\Users\lizel\AppData\Local\Packages\PythonSoftwareFoundation.Python.3.10_qbz5n2kfra8p0\LocalCache\local-packages\Python310\site-packages\torch_directml\__init__.py", line 16, in <module>
    import torch_directml_native
ImportError: DLL load failed while importing torch_directml_native: The specified module could not be found.

Will this be fixed in a 1.13.2 release? Probably it will take some time to get a compiled version with the fix included.

No more 1.13.2. It's 2.0.0.

Will this be fixed in a 1.13.2 release? Probably it will take some time to get a compiled version with the fix included.

No more 1.13.2. It's 2.0.0.

When I try to install torch-directml it requires the 1.13.1 version of torch. DirectML sipports torch 2.x?

Will this be fixed in a 1.13.2 release? Probably it will take some time to get a compiled version with the fix included.

No more 1.13.2. It's 2.0.0.

When I try to install torch-directml it requires the 1.13.1 version of torch. DirectML sipports torch 2.x?

No. Only for 1.13.1.

If 1.13.2 will not be released I cannot solve this issue without compiling by myself?

If 1.13.2 will not be released I cannot solve this issue without compiling by myself?

I think the only thing we can do is waiting for Microsoft releases the new version of torch-directml.

Still not fixed in <IP_ADDRESS>.dev230413

Unfortunately, I tried version 0.2 of torch-directml and it didn’t solve this problem either, but version 2.0 of torch should have solved this problem. I don’t understand.


Switch tika to use latest tagchowder-2.0.22

Switch tika to use latest tagchowder-2.0.22
Remove downloading artifacts from bintray/jcenter
Bump up pom.xml version

Current tika using tagchowder-2.0.17 downloaded from Bintray (EOL now)
New changes move tika to use tagchowder-2.0.22 downloaded from Maven Central
Difference between  tagchowder-2.0.17 and tagchowder-2.0.18
Add AMP validation features to support literal attribute value, e.g [].
https://github.com/yahoo/tagchowder/commit/11925a4b5d611a26a13726e45585490f26ce7b7e

Difference between  tagchowder-2.0.18 and tagchowder-2.0.22 is
Migrate from bintray to Maven Central

@lafa

@lafa please review


Setting icon_url in chat_postMessage works for some and not for others

Reproducible in:
The slack_bolt version
1.18.1
Python runtime version
Python 3.11.1
OS info
Alpine Linux 3.19.1
Steps to reproduce:
(Share the commands to run, source code, and project settings (e.g., setup.py))

Get all users that are in a Slack channel:

def fetch_slack_users(app):
  logging.info("Fetching users from Slack")

  # Get all Slack users
  users_list = app.client.users_list()
  if users_list["ok"] != True:
      raise LookupError("Unable to fetch user list. Exiting.")

  logging.info("Slack users fetched")
  return users_list["members"]

app = App(token=os.environ.get("SLACK_BOT_TOKEN"))
slack_users = fetch_slack_users(app)

2.Acquire some user that's in a Slack channel
i.e
def look_up_slack_user_by_id(uid):
  logging.info("Looking up Slack user by ID %s", uid)
  for user in slack_users:
    if uid == user["id"]:
      return user

  raise SlackUserLookupError(name=event["user"] + ".", comment="This should never happen") # A custom exception

user = look_up_slack_user_by_id(SOME_EXISTING_USER_ID)

Try to post a reply to some thread using the name and icon of the user:

text_to_channel = "Some text."
reply_text = "Replying as some user: %s"%(SOME_EXISTING_USER_ID)

username = event_user["profile"]["display_name"] if event_user["profile"]["display_name"] else event_user["profile"]["real_name"]

post = app.client.chat_postMessage(channel=SOME_EXISTING_CHANNEL_ID, text=text_to_channel, mrkdwn=True)
reply = app.client.chat_postMessage(token=os.environ.get("SLACK_BOT_TOKEN"), channel=SOME_EXISTING_CHANNEL_ID,
                                                           text=reply_text, icon_url=user["profile"]["image_48"], mrkdwn=True,
                                                           thread_ts=post["ts"], username=username)

Expected result:
The reply posted to the thread is posted with the name of 'user' as well as the icon of 'user' and this can be constantly observed in different clients.
Actual result:
Although the name is correct, the icon is set correctly for some reading the thread while is not set correctly for others reading the thread (the icon of the bot itself is seen in these cases).
The following are 2 screenshots, one taken in Arch linux and using Slack web client (Ferdium v6.5.1 using Chromium) and the other screenshot is of the same thread logged in to Slack as the same user but using iPhone Slack app.

Hi, @rsoome! Thanks for submitting your question! 🙌
Based on the examples you provided, this looks like a parity issue between web vs. mobile client - is that correct? Have you been able to see what the desired output for the messages for the desktop client as well?

Hi, thank you for your quick reply!
This issue, at first glance at least, does not seem to have any real pattern. What I've seen thus far:

TWO cases of Android Slack apps BEING ABLE to display the icons
TWO cases of Slack web client BEING ABLE to display the icons (Using Ferdium)
ONE case of Slack web client BEING ABLE to display the icons (Using Rambox)
THREE cases of the iPhone Slack apps NOT being able to display the icons
ONE case of Slack web client NOT being able to display the icons (Using Rambox)

Right now I haven't been able to find anyone in the office who is using desktop client. Will try my luck again tomorrow.

@rsoome Thank you so much, please keep me updated! Yeah, as of right now it seems like there's no clear pattern 😢 In the meantime I'll do some digging on my end through old issues as well to see if I can find some history on this issue or a potential workaround, will drop back in with updates!
If anyone else is facing this issue, I encourage them to post a comment here so we can track it better and see if there's any consistencies 😄

Hi again, @hello-ashleyintech
I got ahold of 3 people who are using the Slack Desktop Client. For all of them, the icons display correctly. (2 people using  version 4.36.138 and 1 using 4.36.140).

Ah, interesting @rsoome! This does sound like it could be an issue based on what client you're using - sounds like it might be working and configured perfectly for desktop but is flaky on other clients.
I will mark this as a server side issue and reach out to the appropriate team internally to get additional insight into whether this is a known issue or not! Thank you for submitting this. I'll drop in any updates I receive! 🙌


Improve support ticket triage, logging and analysis

What
Improve support ticket triage, logging and analysis.
Why
This will enable us to work more efficiently and identify improvements we can make to our products.
Done when...
We've done these things:

[x]  Run a support ticket analysis
[x] Improve the triage process to make it more efficient
[x] Put measures in place to respond to new issues and pull requests
[x] Reduce the backlog of open issues and pull requests

We SHOULD do these things:

[x] Simplify the labelling taxonomy
[x] Prioritise the most common issues from the analysis

We COULD also do these things:

[x] Explore use of Probot reminders

Closed as epic completed


Optimizing Sugarizer Codebase: Removing Unnecessary CSS Code for Improved Performance

After My yesterday Pull request https://github.com/llaske/sugarizer/pull/1308 , I tried to review other activities as well During my review, I identified similar instances where CSS code is no longer being used due to the implementation of Intro JS for our tutorials. I strongly believe that removing this unused code is necessary for maintaining the efficiency and readability of the project's codebase.
now I can confidently confirm that after conducting a thorough review of the Sugarizer project, I did not come across any other instances similar to the one that was addressed in my previous and this Pull request.

Vote , Write , Xo editor  already raised in pr https://github.com/llaske/sugarizer/pull/1302

Ok, I'm fixing it  @NischayGoyal1

Vote , Write , Xo editor already raised in pr #1302

I have fixed it 😇 .

Hello @llaske ,
I hope you're doing well! Just wanted to check in on my pull request [#1296 #1316 ]. Is there any additional information or action required from my side?

Ok. Thanks.


BUG: special.spherical_in: derivative at z=0, n=1 incorrect

Describe your issue.
When calculating the derivative of the modified spherical Bessel function of the first kind scipy.special.spherical_in(n=1, z=0, derivative=True) for order n=1 at z=0 one obtains 0. However, at the origin this should be 1/3 as one can show analytically or simply verify by comparing the values to a numerical derivative.
The actual values (derivative=False) and the derivative for other orders look fine!

Reproducing Code Example
from scipy.special import spherical_in
import numpy as np

z = np.linspace(0, 3, int(1e4))
n = 1

values = spherical_in(n, z, derivative=False)
derivatives_numerical = np.gradient(values, z)
derivatives_analytical = spherical_in(n, z, derivative=True)

print("Numerical derivative:", derivatives_numerical[0:4])
print("Analytical derivative:", derivatives_analytical[0:4])

Error message
None

SciPy/NumPy/Python version and system information
1.12.0 1.26.4 sys.version_info(major=3, minor=11, micro=9, releaselevel='final', serial=0)
Build Dependencies:
  blas:
    detection method: pkgconfig
    found: true
    include directory: /opt/arm64-builds/include
    lib directory: /opt/arm64-builds/lib
    name: openblas
    openblas configuration: USE_64BITINT= DYNAMIC_ARCH=1 DYNAMIC_OLDER= NO_CBLAS=
      NO_LAPACK= NO_LAPACKE= NO_AFFINITY=1 USE_OPENMP= SANDYBRIDGE MAX_THREADS=3
    pc file directory: /opt/arm64-builds/lib/pkgconfig
    version: 0.3.21.dev
  lapack:
    detection method: pkgconfig
    found: true
    include directory: /opt/arm64-builds/include
    lib directory: /opt/arm64-builds/lib
    name: openblas
    openblas configuration: USE_64BITINT= DYNAMIC_ARCH=1 DYNAMIC_OLDER= NO_CBLAS=
      NO_LAPACK= NO_LAPACKE= NO_AFFINITY=1 USE_OPENMP= SANDYBRIDGE MAX_THREADS=3
    pc file directory: /opt/arm64-builds/lib/pkgconfig
    version: 0.3.21.dev
  pybind11:
    detection method: config-tool
    include directory: unknown
    name: pybind11
    version: 2.11.1
Compilers:
  c:
    commands: cc
    linker: ld64
    name: clang
    version: 14.0.0
  c++:
    commands: c++
    linker: ld64
    name: clang
    version: 14.0.0
  cython:
    commands: cython
    linker: cython
    name: cython
    version: 3.0.8
  fortran:
    commands: gfortran
    linker: ld64
    name: gcc
    version: 12.1.0
  pythran:
    include directory: ../../pip-build-env-ewarq4oq/overlay/lib/python3.11/site-packages/pythran
    version: 0.15.0
Machine Information:
  build:
    cpu: aarch64
    endian: little
    family: aarch64
    system: darwin
  cross-compiled: false
  host:
    cpu: aarch64
    endian: little
    family: aarch64
    system: darwin
Python Information:
  path: /private/var/folders/76/zy5ktkns50v6gt5g8r0sf6sc0000gn/T/cibw-run-73jfxkej/cp311-macosx_arm64/build/venv/bin/python
  version: '3.11'

This is correct. I initially thought this was related to https://github.com/scipy/scipy/pull/20483#event-12527781530, but it can't be because that was just merged now and this issue is from yesterday. We also hadn't touched the spherical Bessel functions until that PR, so it seems this may have been an issue for a while. Trying to trace it, I found this has actually been wrong since the spherical Bessel functions were introduced into SciPy:
https://github.com/scipy/scipy/commit/6e80abd32930b459666f402e8d648447c4b910fb#diff-fd1a84b3fdbe5f4d5061866329e8b4f770275c45b83021292926d704527fb952R340
Will fix this soon as we can.

Thanks @izaid for sharing this insight. Based on your recent PR and if I tracked this down correctly we have to do some changes here:
https://github.com/scipy/scipy/blob/ac6bcaf00411286271f7cc21e495192c73168ae4/scipy/special/special/sph_bessel.h#L298-L308
I can do this if this is the correct function. I would also like to add a test for the derivative at 0 for all n to
https://github.com/scipy/scipy/blob/ac6bcaf00411286271f7cc21e495192c73168ae4/scipy/special/tests/test_spherical_bessel.py#L145

Thanks @izaid for sharing this insight. Based on your recent PR and if I tracked this down correctly we have to do some changes here:
https://github.com/scipy/scipy/blob/ac6bcaf00411286271f7cc21e495192c73168ae4/scipy/special/special/sph_bessel.h#L298-L308
I can do this if this is the correct function. I would also like to add a test for the derivative at 0 for all n to
https://github.com/scipy/scipy/blob/ac6bcaf00411286271f7cc21e495192c73168ae4/scipy/special/tests/test_spherical_bessel.py#L145

That's the correct function, certainly happy if you want to make these changes!


suggest raster metadata

[ ] I added an entry to CHANGELOG.md if knowledge of this change could be valuable to users.

Here is a brief summary of what I did:

 Loading Info im Manager

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

194 of 238 (81.51%)  changed or added relevant lines in 5 files are covered.
19 unchanged lines in 10 files lost coverage.
Overall coverage decreased (-0.02%) to 90.669%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

services/src/pro/datasets/postgres.rs
0
18
0.0%

services/src/api/handlers/datasets.rs
175
201
87.06%

Files with Coverage Reduction
New Missed Lines
%

services/src/api/handlers/layers.rs
1
88.8%

services/src/datasets/external/netcdfcf/mod.rs
1
94.79%

services/src/pro/users/postgres_userdb.rs
1
96.16%

services/src/pro/quota/mod.rs
1
94.98%

services/src/api/handlers/datasets.rs
1
94.82%

services/src/datasets/create_from_workflow.rs
1
89.62%

operators/src/processing/raster_vector_join/mod.rs
1
91.78%

services/src/api/handlers/projects.rs
1
98.59%

services/src/datasets/external/netcdfcf/ebvportal_provider.rs
5
92.06%

services/src/pro/contexts/postgres.rs
6
96.95%

Totals

Change from base Build<PHONE_NUMBER>:
-0.02%

Covered Lines:
133309

Relevant Lines:
147028

💛  - Coveralls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

198 of 268 (73.88%)  changed or added relevant lines in 10 files are covered.
18 unchanged lines in 8 files lost coverage.
Overall coverage decreased (-0.03%) to 90.654%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

services/src/contexts/postgres.rs
0
10
0.0%

services/src/pro/contexts/postgres.rs
0
12
0.0%

services/src/pro/datasets/postgres.rs
0
18
0.0%

services/src/api/handlers/datasets.rs
176
206
85.44%

Files with Coverage Reduction
New Missed Lines
%

services/src/contexts/postgres.rs
1
97.6%

services/src/datasets/external/netcdfcf/ebvportal_api.rs
1
88.35%

services/src/api/handlers/datasets.rs
1
94.67%

services/src/api/handlers/wms.rs
1
95.3%

services/src/pro/quota/mod.rs
2
94.56%

services/src/datasets/external/edr.rs
3
85.58%

services/src/pro/contexts/postgres.rs
3
96.82%

services/src/datasets/external/netcdfcf/ebvportal_provider.rs
6
91.99%

Totals

Change from base Build<PHONE_NUMBER>:
-0.03%

Covered Lines:
133309

Relevant Lines:
147052

💛  - Coveralls


Area of the Confirm and Next button is mismatching the shape of the button

the area in the code for the confirm&next button extends the full length of the screen. This means that if you click in that area you move forward without intending to.

Hint: This is most likely the result of a css error, or a button wrapper container error related to it being a flexbox element. I noticed it before, hope this helps.

Good catch with this one @hobbitsyfeet. Looks to be corrected.


add more stubs to shooter, and implement JRAD controller

This PR adds a couple more stubs to the shooter subsystem, and implements 254's JRAD flywheel velocity controller in Lib5K

The shooter isn't register it in robot.java. Would you mind adding it to this PR.

Nice catch. I have fixed that


I think  use  self's width is better.

i change it  ;then it work better when it in dialog;

I valid. Each iron-grid need to manage its own width.

why not?

Yes why not ?

Pull request is behind #24 @maxiplay @gemron

oh yes ! but, #24 is not solve my problem. @The5heepDev
I changed _onResize  method  .
when grid node's dialog container  change it's width , this grid node to adapt to the width of the dialog container .
I hope it's right ,thnks to make sure it.

@gemron If you add your fix to the latest version, I'll merge.

@The5heepDev ok .see #25


UnstructuredDataLabelerProfile needs an options class

Is your feature request related to a problem? Please describe.
Need the ability to enable / disable calculations in the labeler
or set the parameters for labeling.
Describe the outcome you'd like:
options = UnstructuredDataLabelerOptions(...)
options.is_enabled = True/False
options.data_labeler...
options.separators = ...

Is this appropriate still?


src/parameters.h > #include <mysql/mysql.h> //terminates compile missing

I'm guessing this is because I needed a cpp dependency? I tried adding c++ connector but it says I need to use bzr and from there I get this directory called trunk ...but the cmake command doesnt work in there which I presume would give me the mysql/mysql.h dependencies
This is on a linux machine I have everything else setup including using the apt-get dependencies

Hi @Frankenmint,
Does the file /usr/include/mysql/mysql.h exist on your system? If the header file mysql.h is somewhere else, say /opt/mysql/include, then you need to add that path to the GCC line with the option -I/opt/mysql/include.

Alright so Installing Mysql-Client requested me to use mysql-client-5.5 as a dependency first...I do that then look for the created /usr/include/mysql/mysql.h as you mention and it's never installed...doing libmysqlclient-dev created the dependencies, thank you...I'm now having the same step with openssl I've figured that its because i need libssl-dev by now so i'll just iterate through what I need and will possibly put together a dependency list string so you can add that to the readme.

No dice....now I'm stuck...I followed as you suggest with getting the latest jansson driver and its still throwing me an error:
!(error2)[http://puu.sh/mBDB9/6f94b54a75.png]
I'm going to see if I can pin this down

Hi @Frankenmint,
I hope you were able to manually install Jansson 2.7.
So if I summarize, this is what needs to be installed:
libssl-dev
libjansson-dev
libcurl4-openssl-dev
sendemail
libmysqlclient-dev

Thanks!

I was...now its simply a config hangup on my end and I should be good to roll...thank you for all your help!  Review coming soon...


Collection migration optimization

Upgrade to sqlx 1.3.5
Copy batcher from 2.6 migration to 2.5 migration
Utilize batcher to improve performance of 2.5 collection migrations

CORE-1884

I would like to see a test where this is being used.  Also, fix what the linter complains about and take a look at: https://github.com/golang/go/wiki/CodeReviewComments and https://google.github.io/styleguide/go/

I had a bunch of input into the current solution — taking myself off as a reviewer because I am biased☺


Add Path#match? method

Path#match?(pattern : String) : Bool

Similar to File:
File.match?(pattern : String, path : Path | String) : Bool

Related to #11014


Object assign gives error when bundling react native package

Using react native and this line: https://github.com/apollostack/react-apollo/blob/master/src/connect.tsx#L158 gives me the following error in the react native simulator:
One of the sources for assign has an enumerable key on the prototype chain. This is an edge case that we do not support. This error is a performance optimization and not spec compliant.

Anybody else receiving this?

changed from
var storeState = this.store.getState();
this.state = Object.assign({}, storeState)

to
var storeState = this.store.getState();
this.state = storeState.toJS()

And it started working again. Seems like an issue with Object.assign and react native, prooobably not related to this lib :))

@jbaxleyiii perhaps we should use lodash.assign?

@stubailo sounds good too me. I can change that out and open a PR this evening for it, unless you or someone else wants to get to it sooner?

Hey good to be back! So relaxing :) I can try, but I have a lot of meetings so it might be much later today.

Does assign even work with immutable Map?

nvm.. Seems like react-apollo doesn't treat immutable data very well :)

@AlmaasAre can you show me your usage? I'd love to improve this lib to support immutable data! Are you using immutable.js?

@jbaxleyiii Yes sure, thanks! Yes i am! When using the connect function it fails. Tries to deep copy state by using Object.assign which i believe doesn't work well with immutablejs. I also got some errors of wrong usage of Object.assign:
One of the sources for assign has an enumerable key on the prototype chain. This is an edge case that we do not support. This error is a performance optimization and not spec compliant.

I get this error by just using connect from apollo.
Dunno what needs to be done tho. Check if the state is immutable before assigning? not sure

@AlmaasAre yep! I need to add in a check for immutablejs 👍

Does it make more sense to provide a way for the user to map their storeState to connect's local state? If you just add a check for immutable.js you'll still have the same problem when users are using other immutable libraries.
Instead maybe connect call accept a function like getStateFromStoreState that passes in storeState and lets the user return whatever is appropriate for their state.

Apollo Client now supports React Native as of 0.3.27! Going to close this issue because most of the conversation is about Immutable.js and not React Native.

I think that with the 0.5.25 version of apollo-client that uses object spread and polyfills with Object.assign, this bug came back..
In my implementation this happens on refetch.
Also I think this issue belongs in apollo-client rather than here.

@davidyaha is this still the case for you with 0.7.1? If so, please open an issue on apollo-client! :heart:

Not sure.. I will update next week probably and if it reappears I'll open a new issue.


retrain model

hi :
i have train an model , how do i set the args to retrain the model with exist one

@shangjingbo1226 @LiyuanLucasLiu can u give me some advice?

I don't think the current version can support this feature. You may want to add some model loading function in the training code at the very beginning.


Option to revert back to the old merge editor

I find the new 3-way editor confusing and difficult to work with. It’s completely unusable. And there is no way to go back to the good old inline diff editor. Please add a button or an option to go back to the old editor. Thank you!

/duplicate
This is coming in 1.71, expected tomorrow.

Thanks for creating this issue! We figured it's covering the same as another one we already have. Thus, we closed this one as a duplicate. You can search for similar existing issues. See also our issue reporting guidelines.
Happy Coding!


Should linebreak/wrap text when it exceeds

Text should wrap when it exceeds depending on the space between words like normal text area block.

Please read the documentation at http://docs.mathjax.org/en/latest/output.html#automatic-line-breaking.


Update readme and announcements for 17.9

@echoix Good catch, thanks! Fixed in https://github.com/microsoft/VSExtensibility/pull/328


Minio native support #2040

fixes https://github.com/apache/camel-quarkus/issues/2040
supersedes https://github.com/apache/camel-quarkus/pull/2102
Extension leverages quarkiverse-minio. There are several problems/limitations:

It seems that there is a bug in quarkiverse-minio - it misses some reflection registrations (which are probably not needed in simpler scenario) - I'll try to report/fix it in quarkiverse-minio extension and then remove registration from camel-quarkus extension.
There is a limitation because of quiarkiverse-minio which prevents to use more different minio endpoint at once. (minio client has to be defined in application.properties). Limitation is described in doc. I see an option in update of camel-minio component to allow overriding of autowired client by endpoint's configuration. @jamesnetherton , @ppalaga WDYT? Should I prepare an upgrade in camel-minio component?

] An issue should be filed for the change unless this is a trivial change (fixing a typo or similar). One issue should ideally be fixed by not more than one commit and the other way round, each commit should fix just one issue, without pulling in other changes.
[ ] Each commit in the pull request should have a meaningful and properly spelled subject line and body. Copying the title of the associated issue is typically enough. Please include the issue number in the commit message prefixed by #.
[ ] The pull request description should explain what the pull request does, how, and why. If the info is available in the associated issue or some other external document, a link is enough.
[ ] Phrases like Fix # or Fixes # will auto-close the named issue upon merging the pull request. Using them is typically a good idea.
[ ] Please run mvn process-resources -Pformat (and amend the changes if necessary) before sending the pull request.
[ ] Contributor guide is your good friend: https://camel.apache.org/camel-quarkus/latest/contributor-guide.html

Failed build is not linked to minio extension.

Failed build is not linked to minio extension.

There is a limitation because of quiarkiverse-minio which prevents to use more different minio endpoint at once. (minio client has to be defined in application.properties). Limitation is described in doc. I see an option in update of camel-minio component to allow overriding of autowired client by endpoint's configuration.

Sounds like a potentially important limitation. I think we should at least file a feature request on Quarkiverse, link the issue in our docs and advise users to upvote it if they need it. In that way we can see whether it is worth to invest our time into fixing it.

There is a limitation because of quiarkiverse-minio which prevents to use more different minio endpoint at once. (minio client has to be defined in application.properties). Limitation is described in doc. I see an option in update of camel-minio component to allow overriding of autowired client by endpoint's configuration.

Sounds like a potentially important limitation. I think we should at least file a feature request on Quarkiverse, link the issue in our docs and advise users to upvote it if they need it. In that way we can see whether it is worth to invest our time into fixing it.

@ppalaga I've created an issue about optional configuration of minio client in quarkiverse-minio and added to the doc how to upvote the issue if needed.
I've also created https://github.com/quarkiverse/quarkiverse-minio/issues/21 about missing registration for reflection and then I've created https://github.com/apache/camel-quarkus/issues/2120 to observe the issue.

@ppalaga I've created an issue about optional configuration of minio client in quarkiverse-minio and added to the doc how to upvote the issue if needed.
I've also created https://github.com/quarkiverse/quarkiverse-minio/issues/21 about missing registration for reflection and then I've created https://github.com/apache/camel-quarkus/issues/2120 to observe the issue.

@JiriOndrusek can you fix up conflicts and we can merge.

@JiriOndrusek can you fix up conflicts and we can merge.

I'll fix it

I'll fix it

@jamesnetherton  done

@jamesnetherton  done

Fixes released in 0.2.0.
Warning, as per convention artifact will be prefixed with quarkiverse- from 0.3.0.

Fixes released in 0.2.0.
Warning, as per convention artifact will be prefixed with quarkiverse- from 0.3.0.

Issue https://github.com/quarkiverse/quarkiverse-minio/issues/21 is fixed and incorporated into this PR
Unfortunately issue https://github.com/quarkiverse/quarkiverse-minio/issues/22 still causes problems, so limitation with configuration is still valid.

Issue https://github.com/quarkiverse/quarkiverse-minio/issues/21 is fixed and incorporated into this PR
Unfortunately issue https://github.com/quarkiverse/quarkiverse-minio/issues/22 still causes problems, so limitation with configuration is still valid.


add implementation for CVPR2020 Scale-Equalizing Pyramid Convolution …

…for Object Detection

Also following this guide to modify the docs accordingly https://github.com/TuSimple/simpledet/pull/334#issuecomment-647294964

Also following this guide to modify the docs accordingly #334 (comment)

Hi, I have checked the sepc doc and updated the main readme.


Update clap dependency and address the breaking changes

Clap's move from beta.5 to rc.0/rc.1 introduced some breaking changes, namely the splitting-out of clap_derive. I have updated the clap dependencies, added clap_derive, and fixed the resulting errors.

This seems to have caused some issues with the command-line argument parsing now, according to the new help messages. Will address this shortly.


Time Capsule Website

Time Capsule Website
issue no. : #1783
https://github.com/user-attachments/assets/83dffc42-13b4-431d-900d-61cfc91d19cb

@shriyadindi there is a conflict

@iamrahulmahato resolved


some russian translations

Thank you for contributing translation! :heart:
To avoid duplicated work, we don't accept direct PRs: would it be ok for you to close this PR and submit translations using Transifex project at https://www.transifex.com/ipfs/ipfs-companion/ ?
Let me know your Transifex account name, I will add you to thr Russian translation team :)
We synchronize translations with Transifex before each release. You can find more information at /docs/localization-notes.md and ipfs/i18n.

sure, my profile is CupIvan in transifex
https://www.transifex.com/user/profile/CupIvan/

@CupIvan added you to Russian Translation team, you should be able to add your translations there. Thank you for your contributions!


set command empty value

In line 24 of set.js:
if (!value) seems to be always false as u can parse "nothing".
After parsing "nothing" you can not change it back via "set edit key value" as the empty key can not be found by: if (!settings[key])
My solution for now:
if (!value && value == "")

Thank you for bringing that to our attention, I will do some testing and
debugging after I have cleaned my PC, unless evie beats me to it.
On 24 Aug 2017 17:33, "BannukDE"<EMAIL_ADDRESS>wrote:

In line 24 of set.js:
if (!value) seems to be always false as u can parse .
After parsing you can not change it back via "set edit key value" as the
empty key can not be found by: if (!settings[key])
My solution for now:
if (!value && value == "")
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/An-Idiots-Guide/guidebot/issues/8, or mute the thread
https://github.com/notifications/unsubscribe-auth/AT353jSLa9_UKbndTtZ1w57iHEM7pDd9ks5sbaXbgaJpZM4PBoGu
.

You're correct that the condition doesn't work, but wrong about the reason. value being an array, an empty array is truthey, not falsey, so that's the issue.
Will fix.


Class/struct capitalization: ParsedJson or padded_string?

I struggle with how to capitalize new structs and classes; I see both ParsedJson and padded_string.
I don't spend enough time in C++ or any one language, so I tend to copy whatever naming convention the standard library uses--in this case snake_case--but C++ doesn't seem to have an accepted culture, so I'll go with whatever y'all prefer. If asked, my preference is for PascalCase simply because it makes the code less of an "underscore soup," but I'm really not partial.

See pr #238 . When I did this, all structs were snake_case and somewhat POD, except for ParsedJson and Iterator that were more object oriented. That's how I've tried to make sense out of it without changing everything.

We don't have a style guide. We should have a consistent style and ideally some way to check that commits abide by style conventions. Alas I never found a satisfying way to automate such a process in C++, without just forcing a specific formatting. That is, I don't know how to set a few basic rules and then have a check of these rules, without actually having to forcefully reformat (e.g., as with clang-format). It is doable in Java.
I want to avoid/discourage bike-shedding. One can spend a lot of time debating how to format the code... but as long as it is readable, what matters is the compiler output.
Please let us not get into epic discussions regarding style. It can be wasteful.

Let's snake_case_all_the_things
@lemire yeah, I don't want to spend much time on this, just want us to pick something :) Consistency is all I really want--not have to spend time thinking about it when I make a new thing.
I usually solve this by stealing the "prevailing style" for the language, but there is huge variation in the ecosystem. The top 3 results for "c++ json library" for me use snake_case, a PascalCase/camelCase combo, and PascalCase.
Given all that, I suggest we go with the the top one (JSON for modern C++), which accords with C++ stdlib naming, even though it's not my personal favorite: snake_case_all_the_things.
That would mean renaming ParsedJson -> parsed_json, among other things, but we're already mostly snake_cased, so it's not going to be hugely disruptive. That cool?

Note: by "all the things," I mean classes, structs, methods, variables and functions. UPPERCASE_CONSTANT_OR_MACRO is pretty consistent in our code and we should keep it.

That would be fine by me.

Macros should stay upper case, it is pretty standard.

Closing this, I have my guidance, thanks!

@jkeiser Do not hesitate to hack the CONTRIBUTING.md file. As @DBJDBJ  remarked, it is unfair to have unwritten rules.

@lemire @jkeiser
Of course, there will be always styling warriors fighting to the bitter end ...  But, in C++ universe that discussion is settled approx 10 years ago. std lib style is The Style.
namespace  simdjson::yes_this_is_ok_too {
    struct supported_naming_style final {
       // there is set of "required" nested types too
        using value_type  = whatever_works ;
        using type  = supported_naming_style ;
   } ;
}
  //  this is very often seen
  using ssns =   simdjson::yes_this_is_ok_too::supported_naming_style ;
  //
 template<typename json_char_type >
  using json_sview = std::basic_string_view< json_char_type > ;

// and so on ...

The benefit of simdjson API "must" also be malleability when using it with other libraries and inside end users app's.

@DBJDBJ Thanks. So it is settled.


Updated python script to find latest release version and set env var

Description

This PR modifies one of the python scripts used in the Github Actions Workflows to fix the issue mentioned in https://github.com/dapr/dapr/issues/5625. It defines a boolean function that checks the .md file names in docs/release_notes to find semantic versions (minus -rc release candidates) and compares the highest version against the release version being inputted to the script.
This was required as the script currently was not actually checking whether the release was the latest version, and instead just validating that the provided version had a release note against it and that it wasn't an -rc release. This introduces issues with the :latest image tag when a patch for a previous major version (e.g., 1.9.*) is released.
Issue reference

Please reference the issue this PR will close: #5625
Checklist
I tested the code locally but there are no unit / end-to-end tests that exist, since it is just a workflow script.
Please make sure you've  completed the relevant tasks for this PR, out of the following list:

[ ] Code compiles correctly
[ ] Created/updated tests
[ ] Unit tests passing
[ ] End-to-end tests passing
[ ] Extended the documentation / Created issue in the https://github.com/dapr/docs/ repo: dapr/docs#[issue number]
[ ] Specification has been updated / Created issue in the https://github.com/dapr/docs/ repo: dapr/docs#[issue number]
[ ] Provided sample for the feature / Created issue in the https://github.com/dapr/docs/ repo: dapr/docs#[issue number]

Thanks a lot for this PR!
I am not good at Python so I can’t comment on the code, but the way you’ve approached the problem seems perfect.

Thanks a lot for this PR!
I am not good at Python so I can’t comment on the code, but the way you’ve approached the problem seems perfect.

No problem at all @ItalyPaleAle 😄
If anyone knows if there is a standardised way of testing these scripts please let me know.

Testing scripts like these is particularly complex 🙃 Sometimes you can try them if you have a fork of Dapr by running them in your fork. That's how far as you can go normally.

Thanks a lot for this PR!
I am not good at Python so I can’t comment on the code, but the way you’ve approached the problem seems perfect.

No problem at all @ItalyPaleAle 😄
If anyone knows whether there is a standardised way of testing these scripts please let me know.

I would test this via mechanical markdown, using a .md file. We use that for our quickstarts. You can set the environment variables before invoking the function and all with command line: https://github.com/dapr/quickstarts/blob/master/tutorials/hello-world/README.md

/test-sdk-js


Don't throw the errror "Expected a token named 'token'" on 403

That would be nice. I'm using 403 to respond to user which has correct credentials, but not yet activated his account by providing a confirmation token.

this will be resolved when the next version drops, as it will just warn on the console instead https://github.com/sahat/satellizer/blob/master/satellizer.js#L325

Thank you very much. Thats good to know.

Fixed in 0.13.


Update pt.yml

Updated spelling of word on line 150 from "Node" to Nome" as per Desk case https://fetlife.desk.com/agent/case/1381560

👍

👍

thank you all! ❤


Atom Team ID error

I get a Team ID mismatch error when running the Atom install. The Application itself if downloaded and installed independently reports the same Team ID as the one in the script. So I am unsure where the mismatch is occurring.

This was a problem with using tar to expand on Mojave. Fixed in dev with commit ee91690a0da63aacd59777c9f0301f6b7558d81c


Weather on running activities

Hi,
I was just wondering, why are the weather overlays only available on cycling activities? (and not on running activities)
Thanks,
Nicolas

Because it's not possible for technical reason. I tried OFC


BMI Calculator

Could you plz assign me this issue under gssoc 24
Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
Calculating BMI can be time-consuming and prone to errors, especially for those who are not familiar with the formula or what the BMI ranges mean. Additionally, there's a lack of a user-friendly, accessible tool that can quickly provide accurate BMI calculations along with health recommendations based on the results.
Describe the solution you'd like
A clear and concise description of what you want to happen.
I would like an easy-to-use BMI calculator feature that:
Allows users to input their height and weight.
Instantly calculates their BMI.
Provides immediate feedback on which BMI category they fall into (e.g., underweight, normal weight, overweight, obese).
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Using existing online BMI calculators, but many are cluttered with ads and not user-friendly
Additional context
Add any other context or screenshots about the feature request here.

What problem is this feature trying to solve?
How do we know when the feature is complete?

Is this an extension issue? Because currently not accepting sample projects

yes


Added analytics data attributes to demo code

What I did

JVP requested I update this file with example data-analytics attributes. I followed the structure for data analytics attributes that is being used currently in the main redhat.com nav.

Testing Instructions

Visit: https://deploy-preview-466--red-hat-design-system.netlify.app/components/secondary-nav/demo/
Verify that the data-analytic attributes are correct.

Notes to Reviewers

This will need to be looked over by the analytics team to ensure the structure meets their requirements.

tagging @heyMP

I suggest moving this to it's own demo file, e.g. instead of changing the existing elements/rh-secondary-nav/demo/rh-secondary-nav.html file, I suggest creating a new elements/rh-secondary-nav/demo/analytics.html. There are two advantages to this approach:

keeping the analytics attributes in a specific place for each component makes it easy for users who need analytics attrs to find it, without cluttering other demo files
We could add some automated visual feedback to files called analytics.html, e.g. an output pane which logs syntax-highlighted JSON payloads for each relevant click