[ANDROID] Simplify Contributor Entry

(dynamic issue)
This is a top-level (or epic) issue that spawns several sub-issues.
A new contributor sets up the android development-system with the goal to contribute. Any upcoming issues are filed in the tracker. The issues are solved in a way so that the next newcomer does not have to deal with the same problem. This has more effort, but is of benefit in the long-term.
Initial Setup/Build/Test/Run

[x] https://github.com/maplibre/maplibre-native/issues/1913
It is unclear what devices to use for testing

[ ] https://github.com/maplibre/maplibre-native/issues/1915

Test failures, style related

[x] https://github.com/maplibre/maplibre-native/issues/1916
[ ] Error messages need to be more viewable (e.g. err-message + abort)
[ ] Test should work without an account, negate need
[ ] Follow env-var standard-procedure

Test failure GLSurfaceViewReopenTest

[x] https://github.com/maplibre/maplibre-native/issues/1920

[ ] duplicate of: https://github.com/maplibre/maplibre-native/issues/1833

[ ] Provide more documentation re local test-run requirements
[ ] All test should work locally (can take long, but it should work)

[ ] make the simple unit-test (mentioned in comment) more visible/accessible

https://github.com/maplibre/maplibre-native/issues/1920#issuecomment-1842841044

Bounties
(this is general, but is processed in context of Android)

Getting an overview of bounties

[ ] https://github.com/maplibre/maplibre/issues/349

Pick an initial bounty to work on

https://github.com/maplibre/maplibre-native/issues/1922

Go through the Bounty System (https://github.com/maplibre/maplibre/wiki/Bounty-System)

Misnaming/misleading: this is a "Freelance System", not a "Bounty System"

Bounties are "in the open" (not much bureaucracy, everyone can start work)
Bounties are very fast (e.g. payout a day after merge)
"Freelance System" can attract long-term freelancers, but can alienate super-fast Bounty-Workers

https://maplibre.org/jobs/

My Individuality(!!!), is it respected?

I don't do phone, I don't even have a working voice number (just SMS)
I don't post personal information lightly over web-forms
I do not use chat-systems during work (only asynchronous media, free from emojis)

https://github.com/maplibre/maplibre/wiki/Developer-Role

I do not want my real name in public
- => Deciding to continue work for now and ignore bounty (bureaucracy kills my flow/motivation/drive)

Project Resources
(...)

Please move your ideas and suggestions about the bounty system to a [Discussion[(https://github.com/maplibre/maplibre/discussions). It is off-topic in this repo.

Feedback is welcome @abebeos. You can also text me directly in slack


Documentation: "Vuepress website update" has destroyed code examples containing "id:"

What are you trying to achieve?
Code examples containing the text id: have been replaced with permalink: /.
Example: https://codecept.io/locators/#id-locators

#user or { permalink: /'user' } finds element with id="user"

insteadof

#user or { id: 'user' } finds element with id="user"

broken with https://github.com/codeceptjs/CodeceptJS/pull/2085 (https://github.com/codeceptjs/CodeceptJS/commit/9eb401d1569a2ee788f947d05de34b2f4015d5ae)

Doing a global search reveals even more suspicious changes, e.g.
https://github.com/codeceptjs/CodeceptJS/blob/3.x/runok.js#L52

Doing a global search reveals even more suspicious changes, e.g.
https://github.com/codeceptjs/CodeceptJS/blob/3.x/runok.js#L52

Other occurrences of this bug have been fixed, but only partly (e.g. leaving the slash "/" before the string): https://github.com/codeceptjs/CodeceptJS/pull/2429/commits/3c89196b9f06f13ab39a10dbef3074b76d4c4f19

Other occurrences of this bug have been fixed, but only partly (e.g. leaving the slash "/" before the string): https://github.com/codeceptjs/CodeceptJS/pull/2429/commits/3c89196b9f06f13ab39a10dbef3074b76d4c4f19


Integrate 4.8 pipeline

A lot of changes are planned in 4.8 pipeline and 4.2 zafira for launchers and capabilities transfer.
New approach should thoroughly tested.

4.8.2 is the right version for default pipeline.
delivered changes can be tracked via:
https://github.com/qaprosoft/qps-pipeline/milestone/27?closed=1
https://github.com/qaprosoft/qps-pipeline/milestone/30?closed=1
https://github.com/qaprosoft/qps-pipeline/milestone/29

@okamara right after installing from scratch 4.8-beta1 version you should check in Manage Jenkins -> Configure System that QPS_PIPELINE_BRANCH=4.8
Also in scope of testing we should register new organization, repositorye and execute api/web jobs successfully

Configure System contains old version for me QPS_PIPELINE_BRANCH=4.87

Reverified now QPS_PIPELINE_BRANCH=4.8

jobs successfully were running


Python 3.6 wheels

OK for me to upload wheels for Python 3.6?  I just built them: https://travis-ci.org/MacPython/pywavelets-wheels/builds/191711596

Sure.  That would be great.  Thanks!

Go for it. Thanks Matthew!

done, closing. thanks again Matthew


Added localhost check for Ghost Mailer

no issue
Allow localhost mails to bypass validator email check and assign blog title as email name when missing. Uses same logic as used for sending bulk emails here

Do we wanna just fix our validator though to accept localhost emails

We are using this lib as validator atm, not sure if ideal to extend using it for our custom validator to include localhost check immediately as its really an edge case for now 🤔

https://github.com/validatorjs/validator.js/issues/908 This issue suggests we can pass a flag to make it validate emails without a TLD

we can pass a flag to make it validate emails without a TLD

TIL ! We indeed can, tested with the flag and it works perfectly, much better solution  🙌 Pushed up the change with flag


About plugins.

In OgarConsole does not work Shortcuts plugin commands, commands like ka sp etc but in cmd works.

You can't use it with plugin commands. Can you like not create these spam issues? Thanks. No more issues about OgarConsole now.

Ok @LegitSoulja

@LegitSoulja You want me to stop creating issues?


gulp sharp is no longer maintained

Hi. I no longer maintained https://github.com/rizalp/gulp-sharp. Could you remove it from build-tools section ? Thanks

Sorry to hear that Mohammad, thanks for letting me know.


SOLR-16626: Upgrade to Netty 4.1.87.Final

https://issues.apache.org/jira/browse/SOLR-16626

+1 (assume tests pass)


Unable to change setpoint when in Celcius

Chamber setpoint changes work in F, not in C.  Reported in this post.

.. reminding myself to check on this.  I thought it was fixed.


[stable/sentry] Fix sentry icon

The sentry icon is currently broken. See https://hub.helm.sh/charts?q=sentry
Fix icon based on https://sentry.io/branding/
This PR updates the URL to use a supported link that is not likely to get broken (see https://sentry.io/branding/)

What this PR does / why we need it:
Which issue this PR fixes
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

fixes #

Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[x] DCO signed
[x] Chart Version bumped
[ ] Variables are documented in the README.md
[x] title of the PR contains starts with chart name e.g. [stable/chart]

/ok-to-test
/assign
/lgtm


After I add a user they can't add host.  Get stuck in Host registration URL

Rancher Version: Prachi Master 6/15
Steps to Reproduce:

Authenticate using AD credentials
Restrict Site Access and add another user
In different browser log in as other user and try to add host

Results: Get sent to Host Registration URL page and you can't get passed it.
Expected:  Since the host URL is actually set by the admin, you probably should not see this page.  And I should be able to add host as a different user

Version - master 6/15
Verified fixed


Add a cloud function for posting vulnerabilities to PyPI.

Follow up to #183.

@dekkagaijin Could you please review this to make sure it's consistent with https://github.com/pypa/warehouse/pull/9552 ?
Thanks!


RBD striping image feature support

Describe the feature you'd like to have
CSI RBD currently supports only the layering image feature. I think it will be a good idea to support the striping v2 image feature too. If possible the parameter imageFeatures becomes another value e.g striping
apiVersion: storage.k8s.io/v1
kind: StorageClass
metadata:
   name: csi-rbd-sc
provisioner: rbd.csi.ceph.com
parameters:
   pool: rbd
   imageFeatures: striping

What is the value to the end user? (why is it a priority?)
I think I/O performance on RBD PV's could be possibly better with striping feature.
Description of striping v2 image feature in Ceph RBD config reference documentation:
"Striping spreads data across multiple objects. Striping helps with parallelism for sequential read/write workloads"

Cc @dillaman

One of the model we could think of here is, passing through any values, but not sure will it land on issues later or when mutually exclusive feature combination comes in the list.

Not sure if this will work. As fas as i know you will need to use the sum of the internal numeric values for the features enabled when creating an RBD image.
# rbd create <image-name> -s <size in bytes> --image-format=2 --image-features=3
As a result layering AND striping feature are enabled. If you use --image-features=striping my conclusion aftre reading the rbd man page is that layering is not enabled anymore, am i right?
--image-feature feature-name
              Specifies which RBD format 2 feature should be enabled when cre‐
              ating  an  image.  Multiple features can be enabled by repeating
              this option multiple times.

striping is an implicitly enabled feature where a stripe unit < object size and stripe count > 1 is specified when creating the image. Therefore, I don't think it should ever be something allowed / permitted on the imageFeatures PVC parameters. In fact, recent versions of librbd will just ignore it if you attempt to pass it.

Not sure if this will work. As fas as i know you will need to use the sum of the internal numeric values for the features enabled when creating an RBD image.
# rbd create <image-name> -s <size in bytes> --image-format=2 --image-features=3

You can pass the feature names as comma-delimited values:
# rbd create <image-name> -s <size in bytes> --image-format=2 --image-features=layering,striping

@togoschi do you require any more information on this ? as @dillaman mentioned, we may not want to open it up  via Storage class parameter . If you still got some query, please revert, otherwise I would like to close this issue.

I understand as much as it won't be possible to enable striping via storageClass parameters. But for me the question remains open how it could be possible to set stripe parameters over CSI layer to customize RBD images in such a way that pod I/O requests will be distributed across many OSD nodes.

customize RBD images in such a way that pod I/O requests will be distributed across many OSD nodes.

Just so we are clear, that happens automatically since RBD images have a default striping of 4MiB stripe units (i.e. each 4MiB extent will probabilistically land on a different OSD for large enough clusters). The "fancy" striping that you are referring to with the "striping" feature is for very limited use-cases of sequential IO + direct IO (since otherwise the OS page cache will merge sequential IOs before it even gets to the RBD client) + high queue depth.

Yes, we are clear now. @dillaman thanks for the clarification.

Yes, we are clear now. @dillaman thanks for the clarification.

Cool! Thanks @dillaman for your help here.
@togoschi I am closing this issue for now, please feel free to open a new one if required !! :+1:


thinking Authorization and Authentication together

This issue is to highlight aspects where interaction between issues from the Authorization Panel and Authentication Panel come together, and where looking at them together makes issues visible that would not be apparent separately.
A solid client differs from normal web2.0 app in that it is likely to be fetching data from all over the web by following links, in order to build a display for the user.  To build a single display the client may therefore need to authenticate to a number of different resources located potentially on many different servers.
If we look at just one authentication event:

The client may have many different credentials at its disposal: a WebID, a WebKey, a verifiable claim of some property (eg: user is over 21, user has a drivers licence, user is member of a football club, user has a BA, user is a doctor,  ).
The server may

propose different ways to allow authentication: using a WebID, using OpenID, HTTP Basic Auth,...
specify different groups of agents that are allowed access (the client may belong to some groups but not to others, some may have read access others also write access, ...)

Because of privacy and efficiency concerns it would not do to have the client try out every single credential/identity it can. What it should be able to do is on a 401, look at the access control rules and the HTTP header telling it which methods of authentication are allowed, and work out what credentials it may need before authenticating, ordering them according some metric such as privacy. Even if the client has none of the needed credentials it could at least work out from the wACL what it would need to do to be able to interact with the resource -- perhaps become member of a club, or a friend of someone, ... It may even want to ask for a wACL change, say if the client knows it should have access.
This interaction between client and server indicates that there are very good reasons and use cases for many wACLs to be public. (note: it is not an argument to require them all to be public). Since there are also reasons for some ACLs to be protected, there must be a way to separate wACLs into public and protected parts, by say including one ACLs (through a link) into another.
It should be possible for the user of the app then to set policies about when to automatically authenticate, when to warn the user, or even to ask the user for information.

The server may
propose different ways to allow authentication: using a WebID, using OpenID, HTTP Basic Auth,...

As we touch during last Authentication Panel call, we may aim at having limited authentication methods for Resource Servers (possibly just one). OIDC Providers on the other hand can offer whatever. I've created issue to track authenticating users with different parties https://github.com/solid/authentication-panel/issues/27
@bblfish I don't see clear way forward to resolve this issue. If you would like to propose adding independent access control for acl resources themselves, I suggest making PR with proposal which should include or reference Use Cases it tries to address.


curl module

Using only std python libs (httplib, urllib, urllib2).
httplib - is a parsing nightmare
urllib/urllib2 can only handle GET and POST
OR
Find a way to use without stdlibs that won't cause dependency probs.
Checkout issue #44
For now have it use basic RESTful calls.
result["output"] = {'status': status_code, 'headers': headers, 'body': body}

Best thing is to use requests module but we should refrain from having a local pip setup if possible.

After implementating issue #44 we can access the module locally. Wouldn't need to install


Sharing a video to YouTube doesn't work

Hi,
I'm seeing an issue on android when trying to share to YouTube (haven't tested on iOS yet).
In Youtube I'm consistently seeing this error message:
Failed (Transfer Failed)
There was a problem uploading this video to YouTube
Has anybody successfully shared a video to YouTube using this plugin?

FYI, I'm using the generic share() method obviously (no dedicated method for YouTube).

Could be related to this: http://stackoverflow.com/a/19127592
Sorry I can't offer a PR, my android development experience is very limited.


[BUG] TW Light Reverts to RGBW Selector

I have a very curious one @kpsuperplane, originally these TW lights (model ESP56_SHTW3_01) showed only white selections and only the temperature wheel; once selecting from the temperature wheel the menu selection now displays colours and both a colour and temperature wheel. It seems to be stuck as an RGBW light now.

This has not broken anything, but definitely a bug.

I have the same problem with my filament bulbs ESP06_SHTW1_01

V3.0.1 should theoretically fix this, let me know if it does!

Looks fixed to me :) nice work! Thanks!


remove buildUrlWithParams from globa-utils

Checklist

[x] I tested all changes and all related features with different users (student, tutor, instructor, admin) on the test server
[x] Client: I followed the coding and design guidelines.

Motivation and Context

The buildUrlWithParams utility function is broken when using more than one parameter. Furthermore it was only used with a single parameter.
Also add a couple of small tests for Utils.ts.
Description

I removed buildUrlWithParams and adapted the existing code. I also added a couple of tests in utils.spec.ts
Steps for Testing

Simply save an assessment for a file upload and programming exercise and make sure it works correctly
Test Coverage

global-utils.ts : 100%
utils.ts : 97.14%

Thank you for testing and finding issues. I fixed the code so the problems should be gone now.

@SimonEntholzer Isn't that the normal behavior when assessing exercises? I tested that using the develop branch on a File Upload Exercise and it has the same behaviour.

@airelawaleria No worries! It's better to double-check then to oversee something :)


Default Admin Account

Cool admin package, I would like to test it online with this starter. Any way to get the credentials for the default admin that is configured? Having them in the README.md would be even better

The readme for admin is foudn here: https://github.com/yogiben/meteor-admin
The first user is made admin when they go to /admin

I mean this URL http://starter.meteor.com/. Btw the link in this README is wrongly linked.

Link is fixed.
Added default login to readme.

thank you


Add the ability to enable and disable the Profiler via HTTP API.

Motivation

Add /start_profile and /stop_profile to enable and disable the profiler for long-term monitoring.

Usage example
export SGLANG_TORCH_PROFILER_DIR=/home/work/

curl http://localhost:30000/start_profile -H "Content-Type: application/json"
curl http://localhost:30000/stop_profile -H "Content-Type: application/json"

Result
/home/work/1728625868.5155685.trace.json.gz

Modifications

Checklist

[ ] Format your code according to the Contributor Guide.
[ ] Add unit tests as outlined in the Contributor Guide.
[ ] Update documentation as needed, including docstrings or example tutorials.

Interesting, support Chrome trace is indeed a good idea. May you write a brief doc to describe this feature usage?

Interesting, support Chrome trace is indeed a good idea. May you write a brief doc to describe this feature usage?

Sure.

Set environment variables to specify the save path for trace files, for example:

export SGLANG_TORCH_PROFILER_DIR=/home/work/

Enable and disable profiling.

curl http://localhost:30000/start_profile -H "Content-Type: application/json"
curl http://localhost:30000/stop_profile -H "Content-Type: application/json"

Trace file will be generated in the path from the first step, for example:

/home/work/1728625868.5155685.trace.json.gz

Use the link(https://ui.perfetto.dev/) to load the trace file.

Yeah I’m familiar with https://ui.perfetto.dev/. Thanks for the guidance.

@abatom Thanks for the contribution. It is merged.


Fixing build issue due to context removal in region join.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/RNAdam-prb/73/
Test PASSed.


Store to misaligned address in WebSocketProtocol.h

Description
Sending a message with length > UINT16_MAX triggers the following error when compiling with -fsanitize=undefined:
# gcc v7.4.0
$ ./EchoServer
Listening on port 9001
src/WebSocketProtocol.h:200:9: runtime error: store to misaligned address 0x55ebb3d0f712 for type 'uint64_t', which requires 8 byte alignment
0x55ebb3d0f712: note: pointer points here
 00 00  00 7f 00 00 00 00 00 00  00 00 00 00 00 00 00 00  00 00 00 00 00 00 00 00  00 00 00 00 00 00

# clang v6.0.0
$ ./EchoServer
Listening on port 9001
src/WebSocketProtocol.h:200:9: runtime error: store to misaligned address 0x631000078802 for type 'uint64_t' (aka 'unsigned long'), which requires 8 byte alignment
0x631000078802: note: pointer points here
 80 71  be 7f be be be be be be  be be be be be be be be  be be be be be be be be  be be be be be be
              ^
SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior src/WebSocketProtocol.h:200:9

Steps to reproduce

Checkout master HEAD
Apply following patch and run EchoServer example:

diff --git a/Makefile b/Makefile
index e68ee51..2aa9f39 100644
--- a/Makefile
+++ b/Makefile
@@ -1,6 +1,6 @@
 EXAMPLE_FILES := HelloWorld EchoServer
 THREADED_EXAMPLE_FILES := HelloWorldThreaded EchoServerThreaded
-override CXXFLAGS += -std=c++17 -Isrc -IuSockets/src
+override CXXFLAGS += -std=c++17 -Isrc -IuSockets/src -fsanitize=undefined
 override LDFLAGS += uSockets/*.o -lz

 # If we are on macOS we need libuv
diff --git a/examples/EchoServer.cpp b/examples/EchoServer.cpp
index 8eb9cf1..3730e34 100644
--- a/examples/EchoServer.cpp
+++ b/examples/EchoServer.cpp
@@ -10,14 +10,15 @@ int main() {
     uWS::App().ws<PerSocketData>("/*", {
         /* Settings */
         .compression = uWS::SHARED_COMPRESSOR,
-        .maxPayloadLength = 16 * 1024,
+        .maxPayloadLength = 128 * 1024,
        .idleTimeout = 10,
         /* Handlers */
         .open = [](auto *ws, auto *req) {

         },
         .message = [](auto *ws, std::string_view message, uWS::OpCode opCode) {
-            ws->send(message, opCode);
+            std::vector<char> msg(UINT16_MAX + 1, 0);
+            ws->send({ msg.data(), msg.size() }, opCode);
         },
         .drain = [](auto *ws) {
             /* Check getBufferedAmount here */

Issue #877 seems related

https://github.com/uNetworking/uWebSockets/blob/master/src/WebSocketProtocol.h#L200
Yep this is a bug. Very nice report, thanks

f4b7e9ee700a701837153f7fc7d7372c63a626d8

Thanks for the fix


Feature/FE-25

This PR has two important new features: dropdown category selection and art item deletion. See #363 and #373 .

Category selection upon art item upload has been transformed from plain text to dropdown selection.
Art item deletion related interfaces such as on click dropdown and notification pop up are implemented and connected to backend. It takes a bit to delete an art item, about 1-2 s, a spinner might be added in the future.
Hover effect and cursor changes are added for a better user experience in the profile page both for me and others. See #241 . (Should be closed after the review.)

Please write if you find any bugs or serious performance issues. Also please let me know if you have any suggestions about the interface or functionalities.

Reviewed delete artitem, category and changes in css together with @kostanya  on discord. Merging directly.


Idle SPIGOT container using Single core of cpu, tried nogui --noconsole

Hi,
I'm trying to host a simple Spigot server for home use on my Ubuntu-server 19.04 homeserver.
This docker container looks very good so I tried to add it to my Docker-compose 3.7 stack.
  minecraft:
    container_name: minecraft
    restart: always
    image: itzg/minecraft-server
    volumes:
      - ${USERDIR}/docker/minecraft:/data
    ports:
      - "25565:25565"
    environment:
      - EULA=TRUE
      - ENABLE_RCON=false
      - VERSION=1.15.2
      - MAX_PLAYERS=20
      - UID=${PUID}
      - GID=${PGID}
      - TYPE=SPIGOT
      - SNOOPER_ENABLED=false
      - MAX_TICK_TIME=60000
      - MEMORY=1G
      - MAX_MEMORY=4G
      - CONSOLE=FALSE
      - GUI=FALSE
      - OPS=Update94
 #   tty: true #tried both true and false
 #   stdin_open: true #tried both true and false
 #    command: nogui --noconsole #tried this too
    networks:
      - web

Unfortunately the server keeps hogging 100% on one full core at any time. I don't think this is normal. The CPU I'm using is an Intel 7700T.
This issue is very similar to this topic https://github.com/itzg/docker-minecraft-server/issues/80 however none of the proposed solutions seems to solve my problem.
Any help/suggestions/ideas are most welcome, Maybe I'm just missing something simple.
Regards,
Lars

Can you provide the logs at the point where the CPU goes to that level? If you re-pull the latest image it might actually fix this issue, but wanted to see the logs to confirm.

I have tried repulling the image and also building from source. But so far no luck.
Here are my docker logs:
lars@homeserver:~/docker$ docker logs minecraft
[init] Changing gid of minecraft to 115
[init] Changing ownership of /data to 1000 ...
[init] Running as uid=1000 gid=115 with /data as 'drwxrwxr-x    2 1000     115           4096 Apr  6 13:06 /data'
[init] Resolved version given 1.15.2 into 1.15.2
[init] Resolving type given SPIGOT
[init] Downloading Spigot from https://cdn.getbukkit.org/spigot/spigot-1.15.2.jar ...
[init] Creating server.properties in /data/server.properties
[init] Setting server-name to 'Dedicated Server' in /data/server.properties
[init] Skip setting server-ip
[init] Setting server-port to '25565' in /data/server.properties
[init] Setting motd to 'A Spigot Minecraft Server powered by Docker' in /data/server.properties
[init] Skip setting allow-nether
[init] Skip setting announce-player-achievements
[init] Skip setting enable-command-block
[init] Skip setting spawn-animals
[init] Skip setting spawn-monsters
[init] Skip setting spawn-npcs
[init] Skip setting spawn-protection
[init] Skip setting generate-structures
[init] Skip setting view-distance
[init] Skip setting hardcore
[init] Setting snooper-enabled to 'false' in /data/server.properties
[init] Skip setting max-build-height
[init] Skip setting force-gamemode
[init] Setting max-tick-time to '60000' in /data/server.properties
[init] Skip setting enable-query
[init] Skip setting query.port
[init] Setting enable-rcon to 'false' in /data/server.properties
[init] Setting rcon.password to 'minecraft' in /data/server.properties
[init] Setting rcon.port to '25575' in /data/server.properties
[init] Setting max-players to '20' in /data/server.properties
[init] Skip setting max-world-size
[init] Setting level-name to 'world' in /data/server.properties
[init] Skip setting level-seed
[init] Setting pvp to 'true' in /data/server.properties
[init] Skip setting generator-settings
[init] Setting online-mode to 'true' in /data/server.properties
[init] Skip setting allow-flight
[init] Setting level-type to 'DEFAULT' in /data/server.properties
[init] Skip setting resource-pack
[init] Skip setting resource-pack-sha1
[init] Setting difficulty to '1' in /data/server.properties
[init] Setting/adding ops
[init] Creating log4j2.xml in /data/log4j2.xml
[init] Checking for JSON files.
[init] Copying any mods over...
[init] Copying plugins over...
[init] Setting initial memory to 1G and max to 4G
[init] Starting the Minecraft server...
*** Error, this build is outdated ***
*** Please download a new build as per instructions from https://www.spigotmc.org/go/outdated-spigot ***
*** Server will start in 20 seconds ***
Loading libraries, please wait...

After the loading log message there are no more new log messages in docker. The server works (I can play on it) but one core is always at 100%.
Here are my minecraft logs:
lars@homeserver:~/docker/minecraft/logs$ sudo cat latest.log
[13:07:13] [Server thread/INFO]: Starting minecraft server version 1.15.2
[13:07:13] [Server thread/INFO]: Loading properties
[13:07:14] [Server thread/INFO]: This server is running CraftBukkit version git-Spigot-800b93f-8160e29 (MC: 1.15.2) (Implementing API version 1.15.2-R0.1-SNAPSHOT)
[13:07:14] [Server thread/INFO]: Console input is disabled due to --noconsole command argument
[13:07:14] [Server thread/INFO]: Server Ping Player Sample Count: 12
[13:07:14] [Server thread/INFO]: Using 4 threads for Netty based IO
[13:07:14] [Server thread/INFO]: Debug logging is disabled
[13:07:14] [Server thread/INFO]: Default game type: SURVIVAL
[13:07:14] [Server thread/INFO]: Generating keypair
[13:07:14] [Server thread/INFO]: Starting Minecraft server on *:25565
[13:07:14] [Server thread/INFO]: Using epoll channel type
[13:07:18] [Server thread/INFO]: Preparing level "world"
[13:07:18] [Server thread/INFO]: Found new data pack file/bukkit, loading it automatically
[13:07:18] [Server thread/INFO]: Found new data pack vanilla, loading it automatically
[13:07:18] [Server thread/INFO]: Reloading ResourceManager: Default, bukkit
[13:07:18] [Server thread/INFO]: Loaded 6 recipes
[13:07:19] [Server thread/INFO]: -------- World Settings For [world] --------
[13:07:19] [Server thread/INFO]: View Distance: 10
[13:07:19] [Server thread/INFO]: Max TNT Explosions: 100
[13:07:19] [Server thread/INFO]: Tile Max Tick Time: 50ms Entity max Tick Time: 50ms
[13:07:19] [Server thread/INFO]: Experience Merge Radius: 3.0
[13:07:19] [Server thread/INFO]: Item Merge Radius: 2.5
[13:07:19] [Server thread/INFO]: Item Despawn Rate: 6000
[13:07:19] [Server thread/INFO]: Allow Zombie Pigmen to spawn from portal blocks: true
[13:07:19] [Server thread/INFO]: Arrow Despawn Rate: 1200 Trident Respawn Rate:1200
[13:07:19] [Server thread/INFO]: Nerfing mobs spawned from spawners: false
[13:07:19] [Server thread/INFO]: Zombie Aggressive Towards Villager: true
[13:07:19] [Server thread/INFO]: Hopper Transfer: 8 Hopper Check: 1 Hopper Amount: 1
[13:07:19] [Server thread/INFO]: Mob Spawn Range: 6
[13:07:19] [Server thread/INFO]: Cactus Growth Modifier: 100%
[13:07:19] [Server thread/INFO]: Cane Growth Modifier: 100%
[13:07:19] [Server thread/INFO]: Melon Growth Modifier: 100%
[13:07:19] [Server thread/INFO]: Mushroom Growth Modifier: 100%
[13:07:19] [Server thread/INFO]: Pumpkin Growth Modifier: 100%
[13:07:19] [Server thread/INFO]: Sapling Growth Modifier: 100%
[13:07:19] [Server thread/INFO]: Beetroot Growth Modifier: 100%
[13:07:19] [Server thread/INFO]: Carrot Growth Modifier: 100%
[13:07:19] [Server thread/INFO]: Potato Growth Modifier: 100%
[13:07:19] [Server thread/INFO]: Wheat Growth Modifier: 100%
[13:07:19] [Server thread/INFO]: NetherWart Growth Modifier: 100%
[13:07:19] [Server thread/INFO]: Vine Growth Modifier: 100%
[13:07:19] [Server thread/INFO]: Cocoa Growth Modifier: 100%
[13:07:19] [Server thread/INFO]: Bamboo Growth Modifier: 100%
[13:07:19] [Server thread/INFO]: SweetBerry Growth Modifier: 100%
[13:07:19] [Server thread/INFO]: Kelp Growth Modifier: 100%
[13:07:19] [Server thread/INFO]: Entity Activation Range: An 32 / Mo 32 / Ra 48 / Mi 16 / Tiv true
[13:07:19] [Server thread/INFO]: Entity Tracking Range: Pl 48 / An 48 / Mo 48 / Mi 32 / Other 64
[13:07:19] [Server thread/INFO]: Custom Map Seeds:  Village: 10387312 Desert: 14357617 Igloo: 14357618 Jungle: 14357619 Swamp: 14357620 Monument: 10387313Ocean: 14357621 Shipwreck: 165745295 Slime: 987234911
[13:07:27] [Server thread/INFO]: -------- World Settings For [world_nether] --------
[13:07:27] [Server thread/INFO]: View Distance: 10
[13:07:27] [Server thread/INFO]: Max TNT Explosions: 100
[13:07:27] [Server thread/INFO]: Tile Max Tick Time: 50ms Entity max Tick Time: 50ms
[13:07:27] [Server thread/INFO]: Experience Merge Radius: 3.0
[13:07:27] [Server thread/INFO]: Item Merge Radius: 2.5
[13:07:27] [Server thread/INFO]: Item Despawn Rate: 6000
[13:07:27] [Server thread/INFO]: Allow Zombie Pigmen to spawn from portal blocks: true
[13:07:27] [Server thread/INFO]: Arrow Despawn Rate: 1200 Trident Respawn Rate:1200
[13:07:27] [Server thread/INFO]: Nerfing mobs spawned from spawners: false
[13:07:27] [Server thread/INFO]: Zombie Aggressive Towards Villager: true
[13:07:27] [Server thread/INFO]: Hopper Transfer: 8 Hopper Check: 1 Hopper Amount: 1
[13:07:27] [Server thread/INFO]: Mob Spawn Range: 6
[13:07:27] [Server thread/INFO]: Cactus Growth Modifier: 100%
[13:07:27] [Server thread/INFO]: Cane Growth Modifier: 100%
[13:07:27] [Server thread/INFO]: Melon Growth Modifier: 100%
[13:07:27] [Server thread/INFO]: Mushroom Growth Modifier: 100%
[13:07:27] [Server thread/INFO]: Pumpkin Growth Modifier: 100%
[13:07:27] [Server thread/INFO]: Sapling Growth Modifier: 100%
[13:07:27] [Server thread/INFO]: Beetroot Growth Modifier: 100%
[13:07:27] [Server thread/INFO]: Carrot Growth Modifier: 100%
[13:07:27] [Server thread/INFO]: Potato Growth Modifier: 100%
[13:07:27] [Server thread/INFO]: Wheat Growth Modifier: 100%
[13:07:27] [Server thread/INFO]: NetherWart Growth Modifier: 100%
[13:07:27] [Server thread/INFO]: Vine Growth Modifier: 100%
[13:07:27] [Server thread/INFO]: Cocoa Growth Modifier: 100%
[13:07:27] [Server thread/INFO]: Bamboo Growth Modifier: 100%
[13:07:27] [Server thread/INFO]: SweetBerry Growth Modifier: 100%
[13:07:27] [Server thread/INFO]: Kelp Growth Modifier: 100%
[13:07:27] [Server thread/INFO]: Entity Activation Range: An 32 / Mo 32 / Ra 48 / Mi 16 / Tiv true
[13:07:27] [Server thread/INFO]: Entity Tracking Range: Pl 48 / An 48 / Mo 48 / Mi 32 / Other 64
[13:07:27] [Server thread/INFO]: Custom Map Seeds:  Village: 10387312 Desert: 14357617 Igloo: 14357618 Jungle: 14357619 Swamp: 14357620 Monument: 10387313Ocean: 14357621 Shipwreck: 165745295 Slime: 987234911
[13:07:27] [Server thread/INFO]: -------- World Settings For [world_the_end] --------
[13:07:27] [Server thread/INFO]: View Distance: 10
[13:07:27] [Server thread/INFO]: Max TNT Explosions: 100
[13:07:27] [Server thread/INFO]: Tile Max Tick Time: 50ms Entity max Tick Time: 50ms
[13:07:27] [Server thread/INFO]: Experience Merge Radius: 3.0
[13:07:27] [Server thread/INFO]: Item Merge Radius: 2.5
[13:07:27] [Server thread/INFO]: Item Despawn Rate: 6000
[13:07:27] [Server thread/INFO]: Allow Zombie Pigmen to spawn from portal blocks: true
[13:07:27] [Server thread/INFO]: Arrow Despawn Rate: 1200 Trident Respawn Rate:1200
[13:07:27] [Server thread/INFO]: Nerfing mobs spawned from spawners: false
[13:07:27] [Server thread/INFO]: Zombie Aggressive Towards Villager: true
[13:07:27] [Server thread/INFO]: Hopper Transfer: 8 Hopper Check: 1 Hopper Amount: 1
[13:07:27] [Server thread/INFO]: Mob Spawn Range: 6
[13:07:27] [Server thread/INFO]: Cactus Growth Modifier: 100%
[13:07:27] [Server thread/INFO]: Cane Growth Modifier: 100%
[13:07:27] [Server thread/INFO]: Melon Growth Modifier: 100%
[13:07:27] [Server thread/INFO]: Mushroom Growth Modifier: 100%
[13:07:27] [Server thread/INFO]: Pumpkin Growth Modifier: 100%
[13:07:27] [Server thread/INFO]: Sapling Growth Modifier: 100%
[13:07:27] [Server thread/INFO]: Beetroot Growth Modifier: 100%
[13:07:27] [Server thread/INFO]: Carrot Growth Modifier: 100%
[13:07:27] [Server thread/INFO]: Potato Growth Modifier: 100%
[13:07:27] [Server thread/INFO]: Wheat Growth Modifier: 100%
[13:07:27] [Server thread/INFO]: NetherWart Growth Modifier: 100%
[13:07:27] [Server thread/INFO]: Vine Growth Modifier: 100%
[13:07:27] [Server thread/INFO]: Cocoa Growth Modifier: 100%
[13:07:27] [Server thread/INFO]: Bamboo Growth Modifier: 100%
[13:07:27] [Server thread/INFO]: SweetBerry Growth Modifier: 100%
[13:07:27] [Server thread/INFO]: Kelp Growth Modifier: 100%
[13:07:27] [Server thread/INFO]: Entity Activation Range: An 32 / Mo 32 / Ra 48 / Mi 16 / Tiv true
[13:07:27] [Server thread/INFO]: Entity Tracking Range: Pl 48 / An 48 / Mo 48 / Mi 32 / Other 64
[13:07:27] [Server thread/INFO]: Custom Map Seeds:  Village: 10387312 Desert: 14357617 Igloo: 14357618 Jungle: 14357619 Swamp: 14357620 Monument: 10387313Ocean: 14357621 Shipwreck: 165745295 Slime: 987234911
[13:07:27] [Server thread/INFO]: Preparing start region for dimension 'world'/minecraft:overworld
[13:07:27] [Server-Worker-2/INFO]: Preparing spawn area: 0%
[13:07:28] [Server-Worker-1/INFO]: Preparing spawn area: 0%
[13:07:28] [Server-Worker-2/INFO]: Preparing spawn area: 0%
[13:07:29] [Server-Worker-3/INFO]: Preparing spawn area: 0%
[13:07:29] [Server-Worker-1/INFO]: Preparing spawn area: 1%
[13:07:30] [Server-Worker-2/INFO]: Preparing spawn area: 3%
[13:07:30] [Server-Worker-3/INFO]: Preparing spawn area: 6%
[13:07:31] [Server-Worker-1/INFO]: Preparing spawn area: 7%
[13:07:31] [Server-Worker-1/INFO]: Preparing spawn area: 7%
[13:07:32] [Server-Worker-3/INFO]: Preparing spawn area: 14%
[13:07:32] [Server-Worker-1/INFO]: Preparing spawn area: 15%
[13:07:33] [Server-Worker-2/INFO]: Preparing spawn area: 19%
[13:07:33] [Server-Worker-3/INFO]: Preparing spawn area: 20%
[13:07:34] [Server-Worker-3/INFO]: Preparing spawn area: 24%
[13:07:34] [Server-Worker-3/INFO]: Preparing spawn area: 24%
[13:07:35] [Server-Worker-1/INFO]: Preparing spawn area: 29%
[13:07:35] [Server-Worker-1/INFO]: Preparing spawn area: 29%
[13:07:36] [Server-Worker-3/INFO]: Preparing spawn area: 34%
[13:07:36] [Server-Worker-3/INFO]: Preparing spawn area: 34%
[13:07:37] [Server-Worker-1/INFO]: Preparing spawn area: 42%
[13:07:38] [Server-Worker-3/INFO]: Preparing spawn area: 48%
[13:07:38] [Server-Worker-3/INFO]: Preparing spawn area: 48%
[13:07:38] [Server-Worker-2/INFO]: Preparing spawn area: 53%
[13:07:39] [Server-Worker-3/INFO]: Preparing spawn area: 59%
[13:07:39] [Server-Worker-2/INFO]: Preparing spawn area: 62%
[13:07:40] [Server-Worker-2/INFO]: Preparing spawn area: 65%
[13:07:40] [Server-Worker-2/INFO]: Preparing spawn area: 73%
[13:07:41] [Server-Worker-2/INFO]: Preparing spawn area: 75%
[13:07:41] [Server-Worker-1/INFO]: Preparing spawn area: 82%
[13:07:42] [Server-Worker-2/INFO]: Preparing spawn area: 88%
[13:07:42] [Server-Worker-3/INFO]: Preparing spawn area: 91%
[13:07:43] [Server-Worker-1/INFO]: Preparing spawn area: 98%
[13:07:43] [Server thread/INFO]: Time elapsed: 15621 ms
[13:07:43] [Server thread/INFO]: Preparing start region for dimension 'world_nether'/minecraft:the_nether
[13:07:43] [Server-Worker-3/INFO]: Preparing spawn area: 0%
[13:07:43] [Server-Worker-2/INFO]: Preparing spawn area: 0%
[13:07:44] [Server-Worker-1/INFO]: Preparing spawn area: 1%
[13:07:44] [Server-Worker-2/INFO]: Preparing spawn area: 4%
[13:07:45] [Server-Worker-2/INFO]: Preparing spawn area: 11%
[13:07:45] [Server-Worker-1/INFO]: Preparing spawn area: 23%
[13:07:46] [Server-Worker-1/INFO]: Preparing spawn area: 26%
[13:07:46] [Server-Worker-2/INFO]: Preparing spawn area: 35%
[13:07:47] [Server-Worker-1/INFO]: Preparing spawn area: 47%
[13:07:47] [Server-Worker-2/INFO]: Preparing spawn area: 57%
[13:07:48] [Server-Worker-1/INFO]: Preparing spawn area: 66%
[13:07:48] [Server-Worker-3/INFO]: Preparing spawn area: 78%
[13:07:49] [Server-Worker-1/INFO]: Preparing spawn area: 91%
[13:07:49] [Server thread/INFO]: Time elapsed: 6428 ms
[13:07:49] [Server thread/INFO]: Preparing start region for dimension 'world_the_end'/minecraft:the_end
[13:07:49] [Server-Worker-2/INFO]: Preparing spawn area: 0%
[13:07:50] [Server-Worker-1/INFO]: Preparing spawn area: 4%
[13:07:50] [Server-Worker-2/INFO]: Preparing spawn area: 35%
[13:07:51] [Server-Worker-3/INFO]: Preparing spawn area: 73%
[13:07:51] [Server thread/INFO]: Time elapsed: 1679 ms
[13:07:51] [Server thread/INFO]: Done (33.280s)! For help, type "help"

Thanks for taking the time to help me/looking at this.

Strange, it does seem like the same issue that should have been fixed. Can you also provide the output of
docker images --digests itzg/minecraft-server

lars@homeserver:~/docker/minecraft/logs$ docker images --digests itzg/minecraft-server
REPOSITORY              TAG                 DIGEST                                                                    IMAGE ID            CREATED             SIZE
itzg/minecraft-server   latest              sha256:2c043ec271a77f88c6e82cded6eab4587a2310c3f3de2bce8513c179643bac32   814e205aadf7        46 hours ago        273MB

Yes, I figured I might be missing something but I really can't find what.

I just pulled the latest version again, and it seems to be solved!

I fixed the issue late yesterday, so that timing makes sense actually :)
Thanks for the coffee!


cli to list all possible node-field values for a workflow

https://argoproj.github.io/argo-workflows/cli/argo_retry/ accepts --node-field-selector but I'm struggling to find key/values to pass into it.
I tried different keys (ie field names) from https://argoproj.github.io/argo-workflows/node-field-selector/ and then different formats of values including dag.steps.thestep(0) among 10s of other combos but no luck!
would be great if there was a cli command that accepts argument of workflowname and nodefield, then it returns output of all possible values for that nodefield in that workflow

Could you paste what you tried exactly?

maybe related to https://github.com/argoproj/argo-workflows/issues/2861


Add option to enable CORS

Calling the API from a webpage is currently not possible, if the webpage is hosted on a different domain than gotenberg. The "Access-Control-Allow-Origin" is missing, thus a browser won't let you make the request.
Please consider adding an option to whitelist certain user defined origins.
For example (Docker):
docker run -e ALLOW_ORIGINS='http://some-domain.com,https://another.domain.com:8080'

Hello @phlppnhllngr! IMO Gotenberg should be called behind a proxy. Not sure if it is in the scope of Gotenberg ^^

this didn't help me, I have gotenberg on localhost:9055 and I call it on localhost:6006
I have a CORS error, please how can I solve it?
I installed Gotenberg using docker compose
version: "3"
services:
gotenberg:
image: gotenberg/gotenberg:7
ports:
- "<IP_ADDRESS>:9055:3000"
Please help, thanks

I'd like to ask that this be revisited.
As part of my work on the rust gotenberg client (https://github.com/phayes/gotenberg_pdf), I'm enabling web-assembly support. I believe it should be working just fine, except that I'm getting errors from firefox due to CORS headers not being emitted by the gotenberg API.
I understand that it's recommended to run gotenberg behind a reverse proxy, but it would still be useful to be able to set CORS headers on gotenberg directly.
I'd be happy to open a pull request if this is something you think could be supported.

@phayes Wow, that’s bold—WebAssembly support, I mean!
I am the author of JS client library and still planning to add browser support as well :)
Note, though, that CORS headers are not the only thing you will need to add. You will also need to handle OPTIONS requests, HTTPS support (you’re not using plain HTTP, are you?) with the ability to define an SSL certificate, and possibly HTTP/2 or HTTP/3 support. There is a significant amount of work involved if you want to expose Gotenberg to the internet — it would need to function almost like a fully-fledged HTTP server.
Personally, I don’t think this is necessary when you can simply add a reverse proxy, which already supports everything you need.

Hey @phayes @yumauri,
I agree with @yumauri, I think the best option is to put Gotenberg behind a reverse-proxy if you want to expose it to the external world (although I do not recommend this for security reasons).


Type of "apply" is partially unknown

I am again interested in getting some pyright strict warnings fixed that i get due to a lack of type parameters. This time for df.apply. However this already has a lot of overloads and i do not yet fully understand all of them.
Firstly i do not quite understand this one:
   @overload
    def apply(
        self,
        f: Callable[..., Mapping],
        axis: AxisIndex = ...,
        raw: _bool = ...,
        result_type: None = ...,
        args=...,
        **kwargs,
    ) -> Series: ...

that would be something like
def returns_dict(x: pd.Series) -> dict[str, int]:
    return {"col4": 7, "col5": 8}

df = pd.DataFrame(data={"col1": [1, 2], "col2": [3, 4], "col3": [5, 6]})
print(df.apply(returns_dict))

Which just gives me an object series.
col1    {'col4': 7, 'col5': 8}
col2    {'col4': 7, 'col5': 8}
col3    {'col4': 7, 'col5': 8}

is that really the intended thing here? In that case that one could just go from taking a Mapping -> Series to Mapping[Any, Any] -> Series[Any].
All the ones that just return a dataframe should probably also have Series[Any] (or the equivalent for other  generics).
For all overloads that take a
ListLikeExceptSeriesAndStr = TypeVar(
    "ListLikeExceptSeriesAndStr", MutableSequence, np.ndarray, tuple, Index
)

and return a series i think one could probably try to parametrize that further and have the series again be Series[S1]. But bounds in a typevar cant be generic themselves.

We can only use Series[S1] as a return type if we know that the input type is also Series[S1].  My hypothesis here is that wherever we just use Series in the stubs without specifying the associated type, we could just replace that with Series[Any], and then you'd get strict mode to work better.

Yeah, replacing every Unknown that pyright reports with Any would fix most issues with strict mode. I am currently just doing that bit by bit as i am encountering them in my own project and also checking if there are any spots missed where there could be a more constrained one.

Yeah, replacing every Unknown that pyright reports with Any would fix most issues with strict mode. I am currently just doing that bit by bit as i am encountering them in my own project and also checking if there are any spots missed where there could be a more constrained one.

If we really want to add better support for strict mode, we could add something in the CI, but I haven't had the time to figure out how to set up the github workflows/actions to handle 2 different pyproject.toml files.

Ill try to have a look if i have time

Simplest case would probably to make a separate CI job that deletes the normal pyproject.toml and either generates a second right there or renames/moves another on in the repo before initializing the environment.

I have created a CI configuration here: https://github.com/pandas-dev/pandas-stubs/pull/954


Adjust maximum max frame size

Need two significant bits to distinguish between framed/unframed/http, so limit frames to 1GB.
Also rearranged the assertions on creation of a ThriftServerDef a bit.

lgtm


Reduce boilerplate in a few more service testers [cdnjs continuousphp node shippable wercker]

Follow up to #1934.

Messages

:book:

:sparkles: Thanks for your contribution to Shields, @paulmelnikow!

  Generated by :no_entry_sign: dangerJS

Looks good :+1:
It looks like NPM downloads and Gem downloads also got overlooked in #1934 for some reason:
https://github.com/badges/shields/blob/ae190c5f073e828ec2c0bc522f5dcff37d74b7cd/services/gem/gem-downloads.tester.js#L8-L13
https://github.com/badges/shields/blob/ae190c5f073e828ec2c0bc522f5dcff37d74b7cd/services/npm/npm-downloads.tester.js#L9-L14
was that oversight, or is there something we're waiting on for those? (like with APM)

I thought I responded to this comment, though I don't see it now. 🤔
I updated gem-downloads. npm-downloads can't be handled using this shortcut, because that module exposes four separate services.
This should be good to merge!


push request issue

Expected Behavior
for it to push the changes to the dev branch
Actual Behavior
git push origin dev
remote: Permission to PokemonGoF/PokemonGo-Bot.git denied to Wheaties466.
fatal: unable to access 'https://github.com/PokemonGoF/PokemonGo-Bot.git/': The requested URL returned error: 403
Steps to Reproduce
git push origin dev
(confirmed that the username and password are correct.)
Other Information
OS:
Git Commit: (run 'git log -n 1 --pretty=format:"%H"' and paste it here)

Man, this is not even an issue for the project.
Read: https://help.github.com/articles/fork-a-repo/

I apologize

You need to fork the project, commit the changes to the forked repository then create a pull-request.
Also, you can close the issue yourself.


feat: enable v2alpha1 API with conversion webhook

This PR makes the new v2alpha1 version of the API served and enables the conversion webhook using logic established in https://github.com/cybozu-go/accurate/pull/96.
After this, I will suggest changing the SubNamespace controller to watch/reconcile version v1alpha1 (using SSA). When the controller watches v2alpha1 version, I think it also makes sense to switch the stored version.

@zoetrope @ymmt2005 Do you have any suggestions on how to solve the CRD issue in the Helm chart? It won't work as it stands now, and an additional problem is that Helm is unable to template CRD. For this reason, several open-source projects have moved the CRDs out of the Helm crds folder. And provides a Helm value to control if CRDs are provisioned or not. Helm has never had proper support for CRDs, and I think they have given up now. Please take a look at how cert-manager, which I know pretty well "solves" the Helm issue: https://cert-manager.io/docs/installation/helm/#3-install-customresourcedefinitions
If you think that's a good approach, I can prepare a preparation PR making the CRDs possible to template. And then I can progress on this PR.

@erikgb
I had a look at the cert-manager technique.
https://github.com/cert-manager/cert-manager/blob/d2f6bbe579fd9d5f88b82f9a4bfe9241709e9eb8/make/manifests.mk#L107-L110
I agree that it seems like a very good approach.
Let's proceed with this method.

I agree that it seems like a very good approach. Let's proceed with this method.

Thanks for the feedback. I will prepare a PR.

@zoetrope I think this PR is ready for review now. I have also added a simple e2e-test to check conversion works. Next PR will be a lot more interesting - I think. 😸


Change rdfs:label and fix definition of 'Wolbachia prerelease adult vector control strategy', and move it under 'efficacy' as its parent class

We'll also need to redefine this class or deprecate it and create a new one.


Nothing on localhost:3000

What I'm trying to achieve
Seeing the changes as a client.
Steps to reproduce the problem

docker-compose up
going to localhost:3000

What I expected to happen
To have a user friendly store view
Screenshots

Dashboard is working nicely, i guess graphql also (i don't use it yet)

System information
Operating system:

Browser:
Firefox, Chromium, Curl -> nothing normal on 3000

@GBernard314 Hi there! Please follow the instructions from here https://github.com/mirumee/saleor-storefront#getting-started. If you still have any issues, please let us know.
Cheers,

I'm sorry i should have started by saying I was using the docker version of saleor.
That's why I opened the issue because everything else is running but the storefront.

@GBernard314 can you try to start storefront on its own (without docker) and see what happens?

In dockerfile.dev copy and replace this code:
FROM node:10
WORKDIR /app
COPY package*.json ./
RUN npm install
COPY . .
ARG APP_MOUNT_URI
ARG API_URI
ARG STATIC_URL
ENV API_URI ${API_URI:-http://localhost:8000/graphql/}
ENV APP_MOUNT_URI ${APP_MOUNT_URI:-/storefront/}
ENV STATIC_URL ${STATIC_URL:-/storefront/}
EXPOSE 3000
CMD npm start -- --host <IP_ADDRESS>

@mehrdad-shokri I'm sorry I cannot try that for the moment, plus I really want to use docker for this.

There's an error in the saleor-platform docker-compose.yml - replace --hostname with --host and it will work. See: https://github.com/mirumee/saleor-platform/issues/95

@bhrebec I think there's a bug in storefront because I cant build the project anyway

could Saleor team get working Dockerfile and docker-compose.yml for once? I tried both --hostname and --host, it will either return empty response or NPM would throw errors.

I started all saleor-platform with docker and saleor-storefront with cmder and I set API_URI=http://localhost:8000/graphql/  and then : npm start and it work

I experience the same issue - storfront won't load. I followed the guid to the letter. There is noting obvious in startup logs.
The API_URI is set correctly as I see this from the container:
# echo $API_URI
http://localhost:8000/graphql/

During the startup I see one warning:
storefront_1  | WARNING in EnvironmentPlugin - GTM_ID environment variable is undefined.

but webpack emits files with no problems the whole process ends with:
storefront_1  | ℹ ｢wdm｣: Compiled with warnings.

if you try npm start from the container I'm getting:
<EMAIL_ADDRESS>start /app
> cross-env NODE_ENV=develop webpack-dev-server --history-api-fallback --watch --port 3000 --mode development --hotOnly

Starting type checking service...
Using 1 worker with 2048MB memory limit
✖ ｢wds｣:  { Error: listen EADDRINUSE: address already in use <IP_ADDRESS>:3000
    at Server.setupListenHandle [as _listen2] (net.js:1280:14)
    at listenInCluster (net.js:1328:12)
    at GetAddrInfoReqWrap.doListen [as callback] (net.js:1461:7)
    at GetAddrInfoReqWrap.onlookup [as oncomplete] (dns.js:61:10)
  code: 'EADDRINUSE',
  errno: 'EADDRINUSE',
  syscall: 'listen',
  address: '<IP_ADDRESS>',
  port: 3000 }
Browserslist: caniuse-lite is outdated. Please run next command `npm update`

so npm started correctly first time.
The Saleor can you checkout fresh copy from the repo and try for yourself?

@slav-pilus your error indicates that port 3000 is already in use. maybe you haven't closed the previous terminal

This error is expected and it was just to demonstrate that node started correctly in the docker container. The issue is that docker container is not serving storefront on port 3000 (dashboard is working fine).

I think it may relate to this issue:
https://github.com/mirumee/saleor-storefront/issues/1067
https://github.com/mirumee/saleor/issues/7601

I don't it is @mehrdad-shokri this issue only occurs in docker container if I run storefront on local everything works as expected.

There's an error in the saleor-platform docker-compose.yml - replace --hostname with --host and it will work. See: mirumee/saleor-platform#95

this did it for me, i'm closing the issue.


Add GitHub actions

🚀 🚀 Pull Request
Checklist:

[ x  My code follows the style guidelines of this project and the Contributing document
[ ]  I have commented my code, particularly in hard-to-understand areas
[x]  I have kept the coverage-rate up
[x]  I have performed a self-review of my own code and resolved any problems
[x]  I have checked to ensure there aren't any other open Pull Requests for the same change
[x]  I have described and made corresponding changes to the relevant documentation
[x]  New and existing unit tests pass locally with my changes

Changes
This PR brings GitHub actions support in Hub repository. All the checks (including complex) tests were taken from appropriate CircleCI workflow.
Note
Since GitHub actions workers (including paid ones) have only 2 CPU cores, the worker number was reduced from 4 to 2.
Kaggle tests were disabled by removing --kaggle flag from tests.
After merge
After the PR is merged, the build must be included in settings area as a required step for PR checks

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


images/{Dockerfile.dockerignore}: do not ignore .git

The .git directory is important to detect the git commit SHA. This
commit SHA is then used to present as part of the cilium --version
command.
Signed-off-by: André Martins<EMAIL_ADDRESS>

It was meant to be an optimisation to make initial context transfer faster and avoid potentially spoiling cache too. I was hoping to find a different solution to how version is set, but if this is an issue already, let's get it fixed in a simple way.

@aanm In what scenario did the cilium SHA (GIT_VERSION) passing to the docker context not work? I have a huge .git and would not like to be copying it around when not needed.

Oh, I see this is only in the new images directory, so I don't care that much. The main repo Makefiles have a workaround for for passing the GIT_VERSION to docker, but that would not work when docker build is run directly on the repo, without invoking make, so not sure if that would be applicable to images.

There is a lot of baggage in top-level Makefile, and I wanted to start clean with new images and there is a very simple images/Makefile that is being used. I hope to find a cleaner way of passing the git metadata to the build, it's not a big to just copy the dir for now.


Opt-In js.Any reflective call support

We could support reflective calls on subtypes of js.Any if we are "allowed" to leak prototype members of the objects in question.
To some projects this could be acceptable. Should we add opt-in support for this? (Note that this will require us to generate code for RawJS types).

This feature can improve the interoperability with TypeScript, because TypeScript's interfaces are structural types.
Currently we convert a TypeScript interface to a Scala.js trait that extends js.Object. As a result, compatible TypeScript types will not be able to convert to each other in Scala.js.

You really wouldn't want to declare every single interface coming from TypeScript as a structural type. Structural types in Scala are a second-class citizen to begin with. For example, they cannot be recursive. They have no support in the compiler to cache recurring subtyping checks, so each check has to go through the whole member list, increasing compile times. They cannot declare concrete members, so the = js.undefined optional members of JS traits wouldn't be an option. Etc.

You are right. Scala's type system is almost a superset of Java's, while TypeScript's type system is more natural for JavaScript.


Update My college : Central Campus of Technology

Add Central Campus of Technology  to list.
College official website: http://cctdharan.edu.np/ College Email Domain  http://cct.tu.edu.np/
college listed in Institute of Science and Technology  https://tuiost.edu.np/college/constituent

@akash-karki First stage of verification passed, official domain is cctdharan.edu.np as far as I verified. This is just an informational note. Pull request is still in the review. I appreciate your patience while waiting for the final decision. Proof of domain ownership: https://cctdharan.edu.np/

@akash-karki Pull request merged. Thank you.


Add EXTRA_VOLUME_NAME, EXTRA_VOLUME_MOUNT_DIR and EXTRA_VOLUME_SIZE.

Currently we have an option DOCKER_ROOT_VOLUME (Default: no).
If this is set to "yes" i.e. DOCKER_ROOT_VOLUME=yes,
docker-storage-setup creates a logical volume "docker-root-lv"
and mount it on docker root directory.
This patch replaces DOCKER_ROOT_VOLUME with a new option
ROOT_VOLUME_MOUNT_DIR (Default: ""). A user can set
this option to a fully qualified path where he/she wants to mount
his/her logical volume. e.g ROOT_VOLUME_MOUNT_DIR=/var/lib/containers
would create a logical volume and mount it on /var/lib/containers.
This patch is part of an ongoing effort to support docker-storage-setup
with multiple container runtimes e.g. OCID (CRI-O).
Signed-off-by: Shishir Mahajan<EMAIL_ADDRESS>

ping @rhatdan @rhvgoyal
Few key things:
a) I have replaced DOCKER_ROOT_LV_NAME with ROOT_LV_NAME. However I have still kept the value as docker-root-lv. The keyword docker is required here to support docker-latest as the script for docker-latest grep for keyword docker and replaces it with docker-latest.
b) I have left DOCKER_ROOT_VOLUME_SIZE as it is. Dan's PR would replace it with ROOT_VOLUME_SIZE.
Shishir

@rhatdan Fixed.

I am fine with all of @rhvgoyal comments.

@rhvgoyal I have fixed the comments. PTAL.

@shishir-a412ed This is beginning to look good. I have one more concern though about naming. We are calling this thing ROOT_VOLUME and its very easy to confuse it with system rootfs volume. In fact we already have a knob named ROOT_SIZE which specifies how big rootfs should be.
Previously I was calling it DOCKER_ROOT_VOLUME and it was very clear that it is not system root volume.
How about renaming this variable to say EXTRA_VOLUME_MOUNT_DIR. And other knob could be called EXTRA_VOLUME_SIZE. This makes it plenty clear that this script will setup an extra volume and mount it on MOUNT_DIR.
What this volume is used for, its none of the dss business. It could be a root for a container run time or used for storage of some data or used specifically for volumes or something else.

@rhatdan @rhvgoyal PTAL.

@rhvgoyal PTAL.

LGTM

@shishir-a412ed I trid it quicky and it complained that it could not start mount unit file. Did it work for you? I am trying again.

@shishir-a412ed I tried EXTRA_VOLUME_MOUNT_DIR=/var/lib/docker/ and that fails.
systemd says following.
Jan 13 13:37:16 vm7-f25 systemd[1]: var-lib-docker-.mount: Where= setting doesn't match unit name. Refusing.

I think it does not like the - at the end. So var-lib-docker.mount is fine but not var-lib-docker-.mount
systemd man page says following.
The root directory "/" is encoded as single dash, while otherwise the initial and ending "/" are removed from all paths during transformation

@rhvgoyal I think we need to introduce the realpath logic back.

I guess using realpath is a good idea. Also I am thinking that there is no need to use -m. That way realpath will expect all components to exist except last one and I think its a reasonable thing to ask for.
For normal users /var/lib/ will be present and /var/lib/docker/ will be resolved and last component will be created by dss.

@rhvgoyal I think it is reasonable to assume that all components of the path WILL exist. Since we are doing mkdir -p $EXTRA_VOLUME_MOUNT_DIR. So we can drop -m from realpath command.
I ll make the changes.
Shishir

@rhvgoyal I have pushed a fix. I tested it with $EXTRA_VOLUME_MOUNT_DIR=/var//lib/containers// and it works for me. Try it out, and if you need any changes, let me know I will update the code.

@rhvgoyal PTAL.

@shishir-a412ed We have agreed to change the names to
CONTAINER_LV_NAME and CONTAINER_LV_MOUNT_PATH

@rhatdan I think it is:
a) CONTAINER_ROOT_LV_NAME
b) CONTAINER_ROOT_LV_MOUNT_PATH
c) CONTAINER_ROOT_LV_SIZE
@rhvgoyal Can you confirm this ? and I ll make the changes.
Shishir

I am fine with those also. I just want to be done with it.  :^)

@shishir-a412ed yes, those names are fine.
a) CONTAINER_ROOT_LV_NAME
b) CONTAINER_ROOT_LV_MOUNT_PATH
c) CONTAINER_ROOT_LV_SIZE

@shishir-a412ed I did some testing and it looks pretty good.
This PR is almost there. Please make small changes I have requested for and then I will provide my ack.

@rhvgoyal PTAL.

LGTM

@rh-atomic-bot r+


Update copyright headers to 2015.

@badlogic

The copyright notice states the date the contribution was made. If multiple contributions are made over time, multiple years (1993, 1995) or a range of years (1993-1995) should be used. It is incorrect to just update the copyright date to the latest year.


MM-23402 Fix for Mobile Web: Attach button only works with double tap on iOS

Summary
This was a regression was caused when we added conditional checks for mobile for preventing opening of file picket twice when clicked on attach button https://github.com/mattermost/mattermost-webapp/pull/4499.
The isMobileApp util func used here is not all that appropriate as it skips considering mobile browsers, i think it should have been isMobile util func(if we need a similar check In future we probably should check if touch listeners are available instead for reliability).
Fixing this did not help as i think we need onClick to get around some of the security concerns in browsers with user initiated actions and trying to open file pickers programmatically.
I resorted to passing simulateClick event to both onClick and onTouchEnd events and stop propagation as well as defaults to prevent them from opening the file picker twice. If touch events exist then it is fired first and the checks prevent click method from executing solving the root issue too.
Ticket Link
https://mattermost.atlassian.net/browse/MM-23402

Creating a new SpinWick test server using Mattermost Cloud.

Mattermost test server created! :tada:
Access here: https://mattermost-webapp-pr-5211.test.mattermost.cloud

Account Type
Username
Password

Admin
sysadmin
Sys@dmin123

User
user-1
User-1@123

Test server destroyed

/update-branch

waiting to see if this is needed for 5.22v


pre-commit/action is deprecated

Its documentation instead recommends using https://pre-commit.ci/
https://github.com/pre-commit/action

This affects generated templates https://github.com/cookiecutter/cookiecutter-django/blob/8cf57ca1872508874c50da0493dc22df6827066c/{{cookiecutter.project_slug}}/.github/workflows/ci.yml#L34-L35
If there are alternative GitHub Actions rather than using pre-commit's CI itself, that'd be great since many people use cookiecutter-django in private repos. Additionally, it's in maintenance mode, so I'm not really panicking. We could perhaps leave a note saying "if your project is open source, please use pre-commit.ci"


SCAN RESUME TIME

SCAN RESUME TIME -This parameter does not work correctly, the radio station waits for the end of the transmission and continues scanning

Hopefully fixed, let me know of any problems at all.
In the early days I didn't understand much of the code layout and what all the variables did etc, so basically now fixing any bugs I may have introduced back then ;)


$uibmodal.open partially opening on internet explorer angularjs v1.6.9

On IE 11, The modal sometime does not open fully and shows like faded pane.

This happens 1 in 3 times.
We are calling below method to open and close the modal
For open:
$scope.Submit = function (row){
var uibModalInstance = $uibModal.open({
templateUrl: '/SiteAssets/ERAssets/EditMasterData.html',
controller: 'editController',
windowClass: 'app-modal-window',
backdrop: 'static',
resolve: {
details: function () {
return row;
}
}
});
}
For closing
$scope.close = function () {
    $uibModalInstance.close();
    $uibModalInstance.destroy();
      $scope.$emit('UpdateERMasterPlan');
}

I'm submitting a ...

[ ] regression from 1.7.0
[ ] security issue
[ ] issue caused by a new browser version
[ ] other

Current behavior:

Expected / new behavior:

Minimal reproduction of the problem with instructions:

AngularJS version: 1.6.9

Browser: [IE 11  ]
Anything else:

$uibModal is part of angular-ui/bootstrap, which is a 3rd-party package (i.e. not maintained by the AngularJS team). You could try asking on their issue tracker.


It doesn't work in Windows, or I don't understand it's logic

I'm able to write to a file despite the library is working. Here is my "locking" code:

const file = './file.txt';

function delay(ms) {
    return new Promise(resolve => setTimeout(resolve, ms));
}

// === main logic ===
lockfile.lock(file)
.then(async (release) => {

    await delay(10000);

    return release();
})
.catch((e) => {
    console.error(e)
});

It locks the file.txt for 10 seconds, and during this time I shouldn't be able to write the file from other processes(if I understand it correctly), but I can open the file in windows "notepad" and change the text.
Here is the code I run in parallel, and it also does rewrite the file.txt :

(() => {
    try {
        const fd = fs.openSync('./file.txt', 'a+');
        fs.writeFileSync(fd, 'some nasty text')
    } catch (e) {
        console.error(e);
    }
})();

So, what does the lib do?
Thanks!

Hi @SpacewormSera!
I was searching for a solution of AWS EFS advisory locking mechanism inside Node.js and just find this library.
As I understand the mechanics of the library, every thread, process, application or machine must access the shared file-system with this library, because it uses mkdir and mtime system functions to provide the locking behaviour. These guarantee atomicity of operations. If you lock a file with proper-lockfile, but then access the same file directly (even using Node.js), then you are not using the locking behaviour, you're just "jumping over it". This is because it works like an advisory lock in PostgreSQL, that is, it works if every party respects the mechanism, but is not enforced by the system.
See Understanding Node.js file locking (A. Evans, 2022).


BUGFIX: add recursive directory creation in setup db command

Current behavior:
If an custom flow context like Development/Docker is configured before configuring the database, then the db config file can not be written.
Expected behavior:
Need subcontext folders are create and the db conifg file ist written correctly.

@kitsunet not sure about the directory handling, something rings a bell with symlink resolution etc. Is this an issue here or can we just assume this works everywhere?

Created also a pr for the neos.neos thing https://github.com/neos/neos-setup/pull/17

Hey, I am really not sure were to address this.
Is it possible to merge this bugfix into main? I had the same issue, got a little confused, tried to fix the docs and then found out it was a bug and got fixed. When I installed Neos in the recommended way using docker, the bug got shipped as well.
Where is the right place to address this?
In the Forum discuss.neos.io I get currently a Http 500 when trying to sign up, so I can't ask there.

Hi @jonaphil
@mhsdesign will take care of releasing/versioning here 👍 .
If you have questions or issues you can ask in our Slack: https://slack.neos.io/ - you should get quick responses there.
We are also fixing the signup for the forum, thanks for notifying us!

voila https://github.com/neos/setup/releases/tag/6.0.1

Thanks a lot!


Fail when running IW Cells against failed kernel

Fixes #9444

Codecov Report

Merging #9457 (824d5cc) into main (eaca55d) will increase coverage by 0%.
The diff coverage is n/a.

@@          Coverage Diff          @@
##            main   #9457   +/-   ##
=====================================
  Coverage     73%     73%
=====================================
  Files        228     228
  Lines      10501   10501
  Branches    1539    1539
=====================================
+ Hits        7699    7701    +2
+ Misses      2176    2174    -2
  Partials     626     626

Impacted Files
Coverage Δ

src/platform/errors/sessionDisposedError.ts
100% <0%> (+40%)
:arrow_up:

Closing to add more tests


More instructions needed

I'm pulling my hair out here guessing how to properly navigate through the NBT structure.
In my case, I need to iterate through a TAG_LIST, taking a TAG_STRING with a known key from each TAG_COMPOUND and comparing against it. If a match is found I want to modify another TAG_STRING with a known key within the same TAG_COMPOUND, and if a match isn't found I want to create a new TAG_COMPOUND and fill it. Finally, I want to write the changes to the file I read from.
I'm essentially trying to modify an IP for a specific name within MC's servers.dat file.

In PyNBT a TAG_List is just a list, and a TAG_Compound is just a dict. You can treat them exactly the same way you would the native python types.

So I've gotten navigation working:
with open('servers.dat', 'rb') as io:
    nbt_file = NBTFile(io)

    for serverIndex in nbt_file[u'servers']:
        if serverIndex['name'].value == server_title:
            serverIndex['ip'].value = new_server_ip

But how do I save nbt_file to an nbt formatted file?

So I've gotten navigation working:
with open('servers.dat', 'rb') as io:
    nbt_file = NBTFile(io)

    for serverIndex in nbt_file[u'servers']:
        if serverIndex[u'name'].value == server_title:
            serverIndex[u'ip'].value = new_server_ip

But how do I save nbt_file to a file? (servers2.dat) comes out blank when I try the following:
with open('servers2.nbt', 'wb') as io2:
    nbt_file.save(io2)


[SPARK-21163][SQL] DataFrame.toPandas should respect the data type

What changes were proposed in this pull request?
Currently we convert a spark DataFrame to Pandas Dataframe by pd.DataFrame.from_records. It infers the data type from the data and doesn't respect the spark DataFrame Schema. This PR fixes it.
How was this patch tested?
a new regression test

cc @ueshin @BryanCutler

Test build #78392 has started for PR 18378 at commit 8a033fb.

Test build #78392 has finished for PR 18378 at commit 8a033fb.

This patch fails Python style tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/78392/
Test FAILed.

Test build #78395 has started for PR 18378 at commit e352817.

LGTM, pending Jenkins.

Test build #78395 has finished for PR 18378 at commit e352817.

This patch fails PySpark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/78395/
Test FAILed.

Test build #78398 has started for PR 18378 at commit afa74ab.

Test build #78398 has finished for PR 18378 at commit afa74ab.

This patch fails PySpark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/78398/
Test FAILed.

How about applying astype only for primitive types?
I guess the problem here is up-convert from Byte/Short/IntegerType to int64, FloatType to float64.

How about applying astype only for primitive types?

Yeah, that might work since astype takes a dict you probably don't need to specify all the columns.  It does seem like it makes a deep copy of the data that is being casted, so still might have an impact on performance.

Test build #78426 has started for PR 18378 at commit 36f9cb6.

Test build #78426 has finished for PR 18378 at commit 36f9cb6.

This patch fails Python style tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/78426/
Test FAILed.

Test build #78427 has started for PR 18378 at commit 36dc5e7.

Test build #78427 has finished for PR 18378 at commit 36dc5e7.

This patch fails PySpark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/78427/
Test FAILed.

It sounds ok to me just except missing _have_pandas = False above try: .

Test build #78429 has started for PR 18378 at commit 1e98c49.

Test build #78429 has finished for PR 18378 at commit 1e98c49.

This patch fails PySpark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/78429/
Test FAILed.

Test build #78432 has started for PR 18378 at commit dfaa392.

Hm.. actually. this failure looks legitimate. I can reproduce this in my local too.

@HyukjinKwon can you give me a hand for this? I can't reproduce this locally...

My pleasure.

Test build #78432 has finished for PR 18378 at commit dfaa392.

This patch fails PySpark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/78432/
Test FAILed.

It sounds astype with the dict added from 0.19.0 - https://github.com/pandas-dev/pandas/commit/63a1e5c58af8ddc8dec192f39a0999aad74acaf9#diff-fb14ed747473b618d0c021fdef7ee85b. Mine was lower then that and I assume Jenkins one is the same case too.

(I will try to find a workaround ...)

I sent a PR to your branch - https://github.com/cloud-fan/spark/pull/7 @cloud-fan. I will double check as well.

Test build #78443 has started for PR 18378 at commit 357a798.

Test build #78443 has finished for PR 18378 at commit 357a798.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/78443/
Test PASSed.

LGTM

LGTM except for the nit ^.

the last commit just fixes a typo in comment, and the python style check passed locally, I'm going to merge this PR to unblock #15821

Test build #78448 has started for PR 18378 at commit d8ba545.

merged, thanks for your review!

Test build #78448 has finished for PR 18378 at commit d8ba545.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/78448/
Test PASSed.

Looks good, I'll update #15821 with this

Ok I see, I can see part of the rationale is performance (from discussion of astype above) and consistency with pyarrow   https://arrow.apache.org/docs/python/pandas.html
I guess without knowing much about the work with Arrow I was expecting it to be consistent with how pandas converts python types e.g in Spark 2.2
What happens with Double and DateType?

It's pretty natural to convert integer type to int32. Although Spark tries its best to avoid behavior changes, it's allowed to fix some wrong behaviors in new releases, and I believe it's well documented in the Spark 2.3 release notes.

@edlee123 a Spark DoubleType will produce a float64 dtype in Pandas and FloatType will be float32.  DateType will be Python datetime.date objects.  Also keep in mind that if you have integer data with null values, then Pandas will treat it as floats and represent the null values as NaNs.  In this case, Spark will not change the dtype.


Use automated code formatting

Closes #5
I've gone through every file and added exclusions where black doesn't play nice, using # fmt: off and # fmt: on blocks
I think this works quite well, and gives a consistency across the project.
Note this builds on PR #33 so if rejected I will rebuild on current master - all that's really needed is to copy/paste the exclusion blocks.

@ox-baloo  - Rebase done


Pushing latest to DockerHub?

I'm able to pull down the latest code, build it, and run it (admittedly without exhaustive testing), but was curious if anyone would be pushing the latest to DockerHub in the near future.

Can you build yourself and try it out? Bazel's not too much of a pain to install and the bazel-remote build pulls down it's own copy of go. If it does fix your problem, that could be an extra motivation for the project maintainer(s) to push the latest to DockerHub...

(spring cleaning) docker hub should be updated more frequently now.


Activity Report

Determine:

Streamlit; or
Notebook and Google Sheets

Track:

Completed ARs
Completed Accounts
Abandoned ARs
Abandoned Accounts

Review with @trishreimer to determine stack

The activity report would be helpful so we can report out on our KPI's:

of corps to transition / accounts setup

#of AR's filed in the new BizReg

Can we make this a quick and easy real time report that is accessible to others?

sure, realtime would lean more towards streamlit or a some Nuxt pages

I'm hoping to get this in place for the next iteration as I'd like to send the next round to about 50 corps.


wiki: Docker

https://nixos.org/wiki/Docker
@lethalman could you review if documentation from wiki is included in nixpkgs manual?

Note that the "Docker on NixOS" section should use users.extraUsers..extraGroups, not gpasswd.

If moved, this probably should go in docker module meta.doc.

hmm ... i'm not sure there is something to migrate from here... i guess docker+btrfs might be interesting, but i don't see this being something for the manual.


Issue with runing on android

Plugin project :flutter_wallet_card not found. Please update settings.gradle.
FAILURE: Build failed with an exception.

Where:
Script '/Users/nimrsawafta/Development/flutter/packages/flutter_tools/gradle/flutter.gradle' line: 462

What went wrong:
A problem occurred evaluating root project 'android'.

A problem occurred configuring project ':app'.
Cannot invoke method afterEvaluate() on null object

Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.

Get more help at https://help.gradle.org

I made a fix on this pull request,
https://github.com/WebEferen/flutter_wallet_card/pull/3


[Material] Tabs-bar overlapping tabs-content

If we have a Navbar and .toolbar .tabbar underneath it the content of .tab is overlapped by the navbar. Here's a fix:
.page-content.tab {
  padding-top: 104px;
}

104px = 56px (Navbar) + 48px (Tabbar)

Yes, just forgot to add toolbar-fixed class to .page


Sort tags by version number

Summary of PR changes
Cause of problem
This action sometimes fails with "line 28: printf: write error: Broken pipe"
Which is apparently caused because grep finds the tag it's looking for and terminates successfully before printf has finished writing its content into the pipe, so printf errors.
This is likely to happen when the list of tags is larger than the pipe's buffer and when the tag being searched is not at the end of the list.
Because tags are sorted lexicographically, a tag like v4.0.149 is listed ahead of tags v4.0.2–v.4.0.99
Poor and partial solution in this PR
Modify the git tag --merged command to output the list of tags in order by the version number in the tag name. This way recent tags that are likely to be searched will be found at the end of the list so grep will be less likely to exit early.
Better complete solution
Use grep to read from a file instead of reading input through a pipe from another command. See this StackOverflow question for more discussion.
PR Requirements

[X] For major, minor, or breaking changes, at least one of the commit messages contains the appropriate +semver: keywords.

See the Incrementing the Version section of the repository's README.md for more details.

[X] The action code does not contain sensitive information.

NOTE: If the repo's workflow could not automatically update the README.md, it should be updated manually with the next version.  For javascript actions, if the repo's workflow could not automatically recompile the action it should also be updated manually as part of the PR.

It might be better to use a command such as the following to find only the tags on commits that were actually merged into the default branch (and therefore we assume were reviewed and approved).
git log --first-parent --simplify-by-decoration --decorate-refs=refs/tags --pretty=%D

--first-parent will follow the history of the default branch but ignore commits that were on source branches preceding the merge. Otherwise, commits that were originally made in a branch and later merged into the default branch would still be eligible, but those commits weren't reviewed. If fast-forward merges are allowed in the repository, this doesn't help.
--simplify-by-decoration says to log only the commits that have a tag or branch pointing to them.
--decorate-refs=refs/tags says to log only the commits that have a tag pointing to them (ignoring those that only have a branch pointing to them) and don't show the branch names if a commit has both a tag and a branch pointing at it.
--pretty=%D say to only output the name(s) of the decoration (in this case the tag names).
The output is like the following, so a grep would need to deal with the possibility of multiple tags on the same line.
tag: 4.0.15
tag: 4.0.14
tag: 4.0.14-marketplace-url-incorrect.221102200046, tag: 4.0.13
tag: 4.0.12
tag: 4.0.12-drx-caching.221101222450, tag: 4.0.11
tag: 4.0.10
tag: 4.0.9
tag: 4.0.9-fullstory-set-vars.221027233558, tag: 4.0.9-drx-caching.221028174305, tag: 4.0.8
tag: 3.169.93, tag: 3.169.92
tag: 3.169.56
tag: 3.167.2


Update Context to zContext

Relevant: https://github.com/zeta-chain/protocol-contracts/pull/65

it's done part of PR https://github.com/zeta-chain/node/pull/912


Definition of the "lastColumnLetter" is not correct.

https://github.com/Janson-Leung/PHPExcel/blob/07ddc15b44c1f3ee967ded35cffeab5fec49a215/src/Parser/Excel2007.php#L221
Excel2007 parser returns a wrong value of the "lastColumnLetter" if a sheet has more than 27 columns and columns with an index like "AH" are empty for latest rows.
I suggest that will be better to use condition like
if (strlen($columnLetter) > strlen($info['lastColumnLetter'])
    || (strlen($columnLetter) == strlen($info['lastColumnLetter']) && $columnLetter > $info['lastColumnLetter'])) {
    $info['lastColumnLetter'] = $columnLetter;
}

columnLetter can be directly compared


added style for autocomplete menu

This addresses #2122.
The updated menu looks like this:

You'll need to sign the Google CLA as outlined by the cla/google action result.

@parlough I have now signed the CLA.


Only show fb-2727288282

Describe the bug
Install tze plugin , edit config.yml and start , you see only "fb-182736253" not a board
Screenshots
Not able while not can create screenshots (Not Supported By Device)
Device (please complete the following information):

Android MC 1.20.2
spigotmc.com
2.2.7

Additional context
We cant fix it by editing any data :/

Android MC 1.20.2

Sorry i can't replicate this, SternalBoard 2.2.7 (main branch) works properly

Android MC 1.20.2

Sorry i can't replicate this, SternalBoard 2.2.7 (main branch) works properly

I will close by no response


Use fmt machinery instead of io one

This is in preparation of a #![no_std] port

#![no_std] is needed for https://github.com/gimli-rs/addr2line/issues/89 .

@est31 the motivation is that core::fmt exists and core::io does not, correct?

@fitzgen exactly. We only use std::io in order to write stuff, so we can fully replace it with std::fmt usage, which exists inside core.


The chat field doesnt expand when I'm trying to ask a longer multi-line question. It's hard to read my own question

Bug report
Describe the bug
Type two to three lines in the chat field. Notice that you can't see the earlier lines that you typed.

Ideally, it should expand like how it does in ChatGPT

BTW, phenomenal product! It's helping me answer so many questions about our database schema and stuff!
Thank you!

Thanks @rajaraodv! Working on it https://github.com/supabase-community/postgres-new/pull/58 🫡


[Lab6] Populate the root file system

Hi,
I'm a bit confused of the meaning of "populate":

Populate the root file system with initramfs using the VFS APIs and the tmpfs.

Does it mean that we have to reorganize the content of initramfs so that open/read/write/close can play with it?
thanks

No, "populate" here means you need to extract the files from the initramfs(initramfs is read-only) to your rootfs(tmpfs)


FastLogin support

Is your feature request related to a problem? Please describe.
Hello, when FastLogin is used and you try to put your name in the whitelist while being Premium, the message appears that your session is invalid.
Describe the solution you'd like
Allow adding both names and UUIDs in the configuration file regardless of whether your server is online or offline.
Describe alternatives you've considered
Add FastLogin support, but I think it will be better with the solution above.
Screenshot
This is the screen that appear when trying to log in while being Premium in an offline mode server with FastLogin.

I don't know why, but he let me in normally this time and the other times, so I take it back.


Fix set 1

changes the sub-question labels to (a) from 1.
also fixes some unnecessary spaces

@andersle this is ready for review


Print certificate's SHA512 fingerprint, not its SHA512 hash sum

Current instruction has been taken verbatim from freenode's, with SHA1 being replaced by SHA512.
Both instructions are wrong as they print certificate's hash sum, not its fingerprint. The updated command prints the fingerprint as it is being displayed and accepted by NickServ, i.e. all lower case and without colons (':'). This makes it for an easy comparison.
Added bonus is that the pipe also works on the OpenBSD, where sha1sum, sha256sum, and sha512sum, equivalent utilities, don't have the suffix sum :^)

Both instructions are wrong as they print certificate's hash sum, not its fingerprint. The updated command prints the fingerprint as it is being displayed and accepted by NickServ, i.e. all lower case and without colons (':'). This makes it for an easy comparison.

The sha512 fingerprint of a certificate is the sha512 hash of its DER encoding, by definition. I have no real opinion on whether the awk way is better, but to my eyes it's a little less forgiving to type.

D'oh! Of course it is! base64 output fooled me into thinking they're different :^P
However, in it's current for, the command still have several issues, which my PR adresses:

base64 notation is being used, while NickServ uses hex
-fingerprint option already exists in openssl(1) so there's no need to use an external tool
sha512sum utulity doesn't exist on OpenBSD
pipe is being reduced from three to two commands ;^)

So, IMHO, this is still an improvement :^D

Ping.

@rjc thanks!

I had a bit of a dig into the source code and in openssl/apps/x509.c I found:
  else if (fingerprint == i)
    {

...
    BIO_printf(STDout,"%s Fingerprint=",
                     OBJ_nid2sn(EVP_MD_type(fdig)));
    for (j=0; j<(int)n; j++)
      {
      BIO_printf(STDout,"%02X%c",md[j],
                        (j+1 == (int)n)
                        ?'\n':':');
      }
    }

from which it appears that the formatting (with "Blah Fingerprint=", colons, and upper-case hex digits) is not controllable.
But we can still do better in terms of the number of programs that need to run to get the desired output, assuming your shell is Bash or Ksh or Zsh:
typeset -l sha  # only if you REALLY need lower-case

IFS== read _ sha < <(
    openssl x509 -in libera.pem -noout -fingerprint -sha512
) &&
printf '%s\n' "${sha//:}"


Some improvements

This pr contains

Adding page numbers to the Shapeshifter and Vitals menus like it's there for Meetings
Added a mono behaviour for Vitals (and removing its related Postfix in the process)
The minimum lobby size you can set is 5 with this mod instead of the vanilla 4 so it fixes that (by reducing it to 3 to make it funny)
Pages now loop instead of clamping them to either end
Bumps Among Us and Reactor versions because why not

Haven't been able to test it fully since 15+ player lobbies are rare, but through some solo testing using bots they work for the most part

oops accidentally requested review my bad will make those changes

im thinking of moving
PageText.text = $"({PageIndex + 1}/{MaxPageIndex + 1})";
into the OnPageChanged() method instead of Update()

worked on it aa wee bit more, and went ahead with my earlier idea

so is this pr good enough to be merged? or is there something else that's to be done

@Galster-dev made your requested changes


video aspect ration not display properly

https://d1wdlxthirotoy.cloudfront.net/aab64d56-7846-409f-b47f-06fb2938de58/abd3b1df-a666-41a9-8369-2bbc03791a8a/a749e3a3-377f-43db-aed9-34d00b0d5874mov?Expires=1629378207&Signature=abp0JYG1PmtQXjH2kaA~S2eEu4SH6~mrRBa-6VdoynN1~d-Q9P5doRc~W16kQ2e1mHn3gJUg6LJ28d~~eaZozl3R4vBtkHDIPZvomiEpv2vMemrE1fciNDS58kenarSaJIyqBQ1PJ7c9M2PzfKwXRO6kDZk~tzZPQBWcqJCIZwkppbFBpMCjnR0slmby5zFvfo5UtKXG6OxV8AZAEPXk2LMJcmaNMuGah8rQJcHO0y45AZ17K3o9FmicHLTit2R1PSxf2LqpijxqO7oi-LGRJpu6IVxBfyxD13dn78G1ldikLU-RH1UB~f-18SVq0xrroBrO46ualGr9NU8dMg6itg__&Key-Pair-Id=KRVGDZNHIDR6A
this is video url
not displaying properly
its working fine in android

original code:

(CGAffineTransform)fixTransform:(AVAssetTrack*)videoTrack {
CGAffineTransform transform = videoTrack.preferredTransform;
// TODO(@recastrodiaz): why do we need to do this? Why is the preferredTransform incorrect?
// At least 2 user videos show a black screen when in portrait mode if we directly use the
// videoTrack.preferredTransform Setting tx to the height of the video instead of 0, properly
// displays the video https://github.com/flutter/flutter/issues/17606#issuecomment-413473181
if (transform.tx == 0 && transform.ty == 0) {
NSInteger rotationDegrees = (NSInteger)round(radiansToDegrees(atan2(transform.b, transform.a)));
NSLog(@"TX and TY are 0. Rotation: %ld. Natural width,height: %f, %f", (long)rotationDegrees,
videoTrack.naturalSize.width, videoTrack.naturalSize.height);
if (rotationDegrees == 90) {
NSLog(@"Setting transform tx");
transform.tx = videoTrack.naturalSize.height;
transform.ty = 0;
} else if (rotationDegrees == 270) {
NSLog(@"Setting transform ty");
transform.tx = 0;
transform.ty = videoTrack.naturalSize.width;
}
}
return transform;
}
new code

(CGAffineTransform)fixTransform:(AVAssetTrack*)videoTrack {
CGAffineTransform transform = videoTrack.preferredTransform;
// TODO(@recastrodiaz): why do we need to do this? Why is the preferredTransform incorrect?
// At least 2 user videos show a black screen when in portrait mode if we directly use the
// videoTrack.preferredTransform Setting tx to the height of the video instead of 0, properly
// displays the video https://github.com/flutter/flutter/issues/17606#issuecomment-413473181
NSInteger rotationDegrees = (NSInteger)round(radiansToDegrees(atan2(transform.b, transform.a)));
NSLog(@"TX and TY are 0. Rotation: %ld. Natural width,height: %f, %f", (long)rotationDegrees,
videoTrack.naturalSize.width, videoTrack.naturalSize.height);
if (rotationDegrees == 90) {
NSLog(@"Setting transform tx");
transform.tx = videoTrack.naturalSize.height;
transform.ty = 0;
} else if (rotationDegrees == 180) {
transform.tx = videoTrack.naturalSize.width;
transform.ty = videoTrack.naturalSize.height;
} else if (rotationDegrees == 270) {
NSLog(@"Setting transform ty");
transform.tx = 0;
transform.ty = videoTrack.naturalSize.width;
}
return transform;
}

its working fine now with these changes

Closing the issue as its resolved.


Deep wounds/unholy blight dot refreshing fix

@Tharre sorry something that changed warrior tests was merged so this needs a test update with latest master in


⚠ Bofrost.lu has degraded performance

In 5c6c01a, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 936 ms

Resolved: Bofrost.lu performance has improved in 1536fb8.


Use gzip to compress the dump file

close #4

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (e73e820) to head (bd0fa61).

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff            @@
##            master       #19   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files           11        11
  Lines          296       297    +1
=========================================
+ Hits           296       297    +1

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Flag when an app opens for the first time after it previously crashed

Flag when an app opens for the first time after it previously crashed. For example, the flag could be used as a way to prompt the user for help and also to avoid asking the user to rate an app if it just crashed.

:+1:


Ill-formed include guard fix

I've discovered that if one includes transform_reduce.hpp and inclusive_scan.hpp they cannot use functions from the last included header.
The reason is ill-formed include guard in inclusive_scan.hpp, originally copy-pasted from transform_reduce.hpp. I've fixed it.

Thanks for the bug fix.
I'm less enamored with the doc fix; I'm not sure that's an improvement.

I'm less enamored with the doc fix; I'm not sure that's an improvement.

Feel free to change the description as you want. I've copied the description from here:
https://en.cppreference.com/w/cpp/algorithm/inclusive_scan
A similar version is available here:
https://thrust.github.io/doc/group__prefixsums_ga7109170b96a48fab736e52b75f423464.html

Fixed (w/o the doc update) in 8c26a50. Thank you!


Exit non-zero when compilation fails

My build script got confused when a template failed to compile because there wasn't a non-0 exit code. I think it would be useful to signal when compilation fails like this

Thanks for raising this. Hopefully it is resolved by the 0.9.0 release that I've just done. That is the only change in that release I'm afraid despite your other good tickets!