Weird cargo build rust-lld failure

The error.
I can build with the rp_pico crate, but when I add the embassy-rp crate, it breaks.
But since rp_pico doesn't support the wifi card, Im kinda in a rock and a hard place.
error: linking with `flip-link` failed: exit status: 1
  |
  = note: LC_ALL="C" PATH="/home/jwjoh/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/lib/rustlib/x86_64-unknown-linux-gnu/bin:/home/jwjoh/.nvm/versions/node/v18.17.0/bin:/home/jwjoh/.cargo/bin:/usr/local/sbin:/usr/local/bin:/usr/bin:/opt/android-ndk:/opt/cuda/bin:/opt/cuda/nsight_compute:/opt/cuda/nsight_systems/bin:/var/lib/flatpak/exports/bin:/usr/lib/jvm/default/bin:/usr/bin/site_perl:/usr/bin/vendor_perl:/usr/bin/core_perl:/home/jwjoh/.local/share/JetBrains/Toolbox/scripts" VSLANG="1033" "flip-link" "-flavor" "gnu" "/tmp/rustcNvXfQT/symbols.o" "/home/jwjoh/pico-rs/target/thumbv6m-none-eabi/release/deps/pico_rs-29d6265513c479e2.pico_rs.e732090dcefed44-cgu.0.rcgu.o" "--as-needed" "-L" "/home/jwjoh/pico-rs/target/thumbv6m-none-eabi/release/deps" "-L" "/home/jwjoh/pico-rs/target/release/deps" "-L" "/home/jwjoh/pico-rs/target/thumbv6m-none-eabi/release/build/pico-rs-f2977f5257e91e79/out" "-L" "/home/jwjoh/pico-rs/target/thumbv6m-none-eabi/release/build/cortex-m-0c42e772d7af24ef/out" "-L" "/home/jwjoh/pico-rs/target/thumbv6m-none-eabi/release/build/cortex-m-rt-9208c8d590359f68/out" "-L" "/home/jwjoh/pico-rs/target/thumbv6m-none-eabi/release/build/defmt-fe22307e866e2637/out" "-L" "/home/jwjoh/pico-rs/target/thumbv6m-none-eabi/release/build/embassy-rp-80a67dd867a6b61d/out" "-L" "/home/jwjoh/pico-rs/target/thumbv6m-none-eabi/release/build/rp-pac-27778f3176c6d416/out" "-L" "/home/jwjoh/pico-rs/target/thumbv6m-none-eabi/release/build/rp2040-pac-f0f36508880e9118/out" "-L" "/home/jwjoh/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/lib/rustlib/thumbv6m-none-eabi/lib" "-Bstatic" "/tmp/rustcNvXfQT/libcortex_m-6a6b4e074f0f9577.rlib" "/home/jwjoh/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/lib/rustlib/thumbv6m-none-eabi/lib/libcompiler_builtins-817955aa7e4d0a1a.rlib" "-Bdynamic" "--eh-frame-hdr" "-z" "noexecstack" "-L" "/home/jwjoh/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/lib/rustlib/thumbv6m-none-eabi/lib" "-o" "/home/jwjoh/pico-rs/target/thumbv6m-none-eabi/release/deps/pico_rs-29d6265513c479e2" "--gc-sections" "-O1" "--nmagic" "-Tlink.x" "-Tdefmt.x"
  = note: rust-lld: error: undefined symbol: SW0_IRQ
          >>> referenced by pico_rs.e732090dcefed44-cgu.0
          >>>               /home/jwjoh/pico-rs/target/thumbv6m-none-eabi/release/deps/pico_rs-29d6265513c479e2.pico_rs.e732090dcefed44-cgu.0.rcgu.o:(__INTERRUPTS)

          rust-lld: error: undefined symbol: SW1_IRQ
          >>> referenced by pico_rs.e732090dcefed44-cgu.0
          >>>               /home/jwjoh/pico-rs/target/thumbv6m-none-eabi/release/deps/pico_rs-29d6265513c479e2.pico_rs.e732090dcefed44-cgu.0.rcgu.o:(__INTERRUPTS)

          rust-lld: error: undefined symbol: SW2_IRQ
          >>> referenced by pico_rs.e732090dcefed44-cgu.0
          >>>               /home/jwjoh/pico-rs/target/thumbv6m-none-eabi/release/deps/pico_rs-29d6265513c479e2.pico_rs.e732090dcefed44-cgu.0.rcgu.o:(__INTERRUPTS)

          rust-lld: error: undefined symbol: SW3_IRQ
          >>> referenced by pico_rs.e732090dcefed44-cgu.0
          >>>               /home/jwjoh/pico-rs/target/thumbv6m-none-eabi/release/deps/pico_rs-29d6265513c479e2.pico_rs.e732090dcefed44-cgu.0.rcgu.o:(__INTERRUPTS)

          rust-lld: error: undefined symbol: SW4_IRQ
          >>> referenced by pico_rs.e732090dcefed44-cgu.0
          >>>               /home/jwjoh/pico-rs/target/thumbv6m-none-eabi/release/deps/pico_rs-29d6265513c479e2.pico_rs.e732090dcefed44-cgu.0.rcgu.o:(__INTERRUPTS)

          rust-lld: error: undefined symbol: SW5_IRQ
          >>> referenced by pico_rs.e732090dcefed44-cgu.0
          >>>               /home/jwjoh/pico-rs/target/thumbv6m-none-eabi/release/deps/pico_rs-29d6265513c479e2.pico_rs.e732090dcefed44-cgu.0.rcgu.o:(__INTERRUPTS)

          flip-link: the native linker failed to link the program normally; please check your project configuration and linker scripts

Cargo.toml

[package]
edition = "2021"
name = "pico-rs"
version = "0.1.0"
license = "MIT OR Apache-2.0"

[dependencies]
cortex-m = { version = "0.7" }
cortex-m-rt = "0.7"
embedded-hal = { version = "0.2.5", features = ["unproven"] }

defmt = "0.3"
defmt-rtt = "0.4"
panic-probe = { version = "0.3", features = ["print-defmt"] }

#rev = "2a4ebdc150ba7c32d7dacc12aec85bccf05a41ff"
embassy-rp = { version = "0.1.0", git = "https://github.com/embassy-rs/embassy.git", features = [
    "critical-section-impl",
] }

# We're using a Pico by default on this template
rp-pico = "0.7"
embassy-net = { version = "0.1.0", features = [
    "proto-ipv4",
    "tcp",
    "udp",
    "dhcpv4",
    "dns",
] }
# but you can use any BSP. Uncomment this to use the pro_micro_rp2040 BSP instead
# sparkfun-pro-micro-rp2040 = "0.6"

# If you're not going to use a Board Support Package you'll need these:
# rp2040-hal = { version="0.8", features=["rt", "critical-section-impl"] }
# rp2040-boot2 = "0.2"

# cargo build/run
[profile.dev]
codegen-units = 1
debug = 2
debug-assertions = true
incremental = false
opt-level = 3
overflow-checks = true

# cargo build/run --release
[profile.release]
codegen-units = 1
debug = 2
debug-assertions = false
incremental = false
lto = 'fat'
opt-level = 3
overflow-checks = false

# do not optimize proc-macro crates = faster builds from scratch
[profile.dev.build-override]
codegen-units = 8
debug = false
debug-assertions = false
opt-level = 0
overflow-checks = false

[profile.release.build-override]
codegen-units = 8
debug = false
debug-assertions = false
opt-level = 0
overflow-checks = false

# cargo test
[profile.test]
codegen-units = 1
debug = 2
debug-assertions = true
incremental = false
opt-level = 3
overflow-checks = true

# cargo test --release
[profile.bench]
codegen-units = 1
debug = 2
debug-assertions = false
incremental = false
lto = 'fat'
opt-level = 3

config.toml

[target.'cfg(all(target_arch = "arm", target_os = "none"))']
# Choose a default "cargo run" tool:
# - probe-run provides flashing and defmt via a hardware debugger, and stack unwind on panic
# - elf2uf2-rs loads firmware over USB when the rp2040 is in boot mode
# - "probe-rs run" is similar to probe-run but it uses the latest probe-rs lib crate
runner = "probe-run --chip RP2040"
# runner = "elf2uf2-rs -d"
# runner = "probe-rs run --chip RP2040 --protocol swd"

rustflags = [
  "-C",
  "linker=flip-link",
  "-C",
  "link-arg=--nmagic",
  "-C",
  "link-arg=-Tlink.x",
  "-C",
  "link-arg=-Tdefmt.x",

  # Code-size optimizations.
  #   trap unreachable can save a lot of space, but requires nightly compiler.
  #   uncomment the next line if you wish to enable it
  "-Z",
  "trap-unreachable=no",
  "-C",
  "inline-threshold=5",
  "-C",
  "no-vectorize-loops",
]

[build]
target = "thumbv6m-none-eabi"

[env]
DEFMT_LOG = "debug"

I used the wifi_blinky example and removed rp_pico and it gave me
Error: An ARM specific error occurred.

Caused by:
    Timeout occurred during operation.

The official example worked, by just cloning the repo, but my repo doesn't work. I added all the things that are in the regular examples/rp/Cargo.toml to my cargo toml and it is still giving me some attitude.

I got it figured out, but now I want to disable the DEBUG logs. How would I go about doing this?

Nvm, just solved all my issues i guess. Just had to put ENV at the top of config.toml


Release <IP_ADDRESS>

OpenSearch 1.3.14 has been released, see release notes.
Official OpenSearch release ticket: https://github.com/opensearch-project/opensearch-build/issues/4069
Checklist:

[x] Compatibility Matrix is updated (#244)
[x] Release <IP_ADDRESS> tag is present in the repo
[x] Release artifacts are available and downloadable
[x] Release notes published
[x] Forum announcement published

Done.


cmd/go: point tidy errors to https://go.dev/ref/mod#graph-pruning

What version of Go are you using (go version)?

$ go version
go version go1.17.2 linux/amd64

Does this issue reproduce with the latest release?
Yes
What operating system and processor architecture are you using (go env)?
go env Output
$ go env
GO111MODULE=""
GOARCH="amd64"
GOBIN=""
GOCACHE="/home/chris/.cache/go-build"
GOENV="/home/chris/.config/go/env"
GOEXE=""
GOEXPERIMENT=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOINSECURE=""
GOMODCACHE="/home/chris/Code/go/pkg/mod"
GONOPROXY=""
GONOSUMDB=""
GOOS="linux"
GOPATH="/home/chris/Code/go"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/home/chris/.local/lib/go-1.17.2"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/home/chris/.local/lib/go-1.17.2/pkg/tool/linux_amd64"
GOVCS=""
GOVERSION="go1.17.2"
GCCGO="gccgo"
AR="ar"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"

What did you do?

I updated the version of a package we depend upon and ran go mod tidy.
What did you expect to see?
I expected to see nothing, or an error pointing me to documentation explaining the error.
What did you see instead?
proprietaryproject.com/internal/assets tested by
        proprietaryproject.com/internal/assets.test imports
        github.com/stretchr/testify/assert imports
        gopkg.in/yaml.v3 loaded from<EMAIL_ADDRESS>        but go 1.16 would select v3.0.0-20210107192922-496545a6307b

To upgrade to the versions selected by go 1.16:
        go mod tidy -go=1.16 && go mod tidy -go=1.17
If reproducibility with go 1.16 is not needed:
        go mod tidy -compat=1.17
For other options, see:
        https://golang.org/doc/modules/pruning

I don't understand the problem, so I followed the link at the bottom of the error: https://golang.org/doc/modules/pruning
That link redirects to https://golang.org/doc/modules/managing-dependencies, which contains no information about these -compat and -go flags. It also doesn't contain the word prune anywhere.
So my report is really a documentation bug. I'm confused by the decision that go is making, and the resource the CLI points me to does not help. Did the contents of that page change recently or something?

cc @bcmills

Yep, I'm still writing the full doc.

@bcmills Is there a draft version available anywhere?

Not yet. (What I'm working on is basically a tutorial on exclude, replace, and Go 1.17 module graph pruning.)
In the meantime, though, I'm happy to advise on specific cases. (Generally if you're not sure it's easiest to just take the upgrade: go mod tidy -go=1.16 && go mod tidy -go=1.17.)

Hi @bcmills,
What I'm finding confusing in the output is that go1.17 won't upgrade the transitive dependencies, but then complains about the transitive dependency versions. The cli suggestion is to use -go=1.16, but we've made the decision to not support go1.16 by specifying go1.17. The output also says that if go1.16 compatibility isn't needed to use -compat=go1.17, but that does not fix the go.mod and go mod tidy still fails.
I guess my questions is that if go mod tidy -go=1.16 && go mod tidy -go=1.17 does the right thing here, why do I need to use "go1.16 mode" when I don't need to support go1.16? Is it because somewhere in the dependency tree there is a go.mod with go1.16?

The cli suggestion is to use -go=1.16, but we've made the decision to not support go1.16 by specifying go1.17.

The complete suggestion is to use -go=1.16 followed by -go=1.17.
go mod tidy -go=1.16 updates the selected versions to what Go 1.16 would select.
go mod tidy -go=1.17 then changes it back to satisfy the 1.17 invariants, at which point the dependencies should be stable.
(That is: go mod tidy should not downgrade them once they have been upgraded in this way. If that is not the case, please file a separate issue with steps to reproduce.)

The output also says that if go1.16 compatibility isn't needed to use -compat=go1.17, but that does not fix the go.mod and go mod tidy still fails.

It should not “fix the go.mod” because there is nothing broken about it if you do not care about compatibility.
However, if you take that option you need to use -compat=go1.17 flag at every go mod tidy, because the -compat flag is not preserved in the go.mod file.
(It exists in order to facilitate the one-time 1.16-to-1.17 transition for projects that test against all supported Go versions, so it didn't seem worth adding a permanent go.mod directive.)

if go mod tidy -go=1.16 && go mod tidy -go=1.17 does the right thing here, why do I need to use "go1.16 mode" when I don't need to support go1.16?

Without the -compat flag, the go tool has no way to know that you do not need to support consumers of the module on Go 1.16 or earlier.
However, you can indicate that you really don't care about the transitive requirement using an exclude directive:
exclude gopkg.in/yaml.v3 v3.0.0-20210107192922-496545a6307b

Thanks for the clarification @bcmills!

Without the -compat flag, the go tool has no way to know that you do not need to support consumers of the module on Go 1.16 or earlier.

I think this is where I was confused. I thought that specifying go 1.17 in go.mod did this, removing the need for the -compat flag. I agree that manual step of some sort needs to be taken here, but we started with a go1.17-only go.mod, updated a dependency using go1.17, then suddenly go mod tidy is failing to work without first upgrading as go1.16.

I've come across the same issue and eventually found the content at https://go.dev/ref/mod#graph-pruning. Shouldn't the URL reported in the error message be https://go.dev/ref/mod#graph-pruning instead of https://golang.org/doc/modules/pruning (which redirects to https://go.dev/doc/modules/managing-dependencies)?

How come this is unplanned? I can send the CL to change this line to the correct URL
https://github.com/golang/go/blob/c46ba1f9efeb8efa6d8f513ec92f36ae1bfb8cd0/src/cmd/go/internal/modload/load.go#L2081
Will the change be accepted?

sure?

CL is at: https://go-review.googlesource.com/c/go/+/633421

Thanks so much for tackling this @mohammed90!


TECH-558: Added cucumber tests for GET /services

Description:
Add cucumber test for GET /services.
Ticket: https://govstack-global.atlassian.net/browse/TECH-558

@ingmarvali
The serviceKey property is required in the schema, but there is no serviceKey in the properties - does that mean that id should be required because the id description contains information about the service key?
If so, I can update the API spec and change serviceKey to id in the list of required fields


jamulus: 3.6.2 -> 3.7.0

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/jamulus/versions.
meta.description for jamulus is: "Enables musicians to perform real-time jam sessions over the internet"
meta.homepage for jamulus is: "https://github.com/corrados/jamulus/wiki"
meta.changelog for jamulus is: ""
Updates performed

Version update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS

The tests defined in passthru.tests, if any, passed

0 of 0 passed binary check by having a zero exit code.

0 of 0 passed binary check by having the new version present in output.

found 3.7.0 with grep in /nix/store/5qdr1s64bwdn35far4s4a8kcmj26x292-jamulus-3.7.0

directory tree listing: https://gist.github.com/a9134f7dee9618e642e1a287d8614d01

du listing: https://gist.github.com/612ce828e990ebb5815352ac8f24a096

Rebuild report (if merged into master) (click to expand)

3 total rebuild path(s)

1 package rebuild(s)

1 x86_64-linux rebuild(s)
1 i686-linux rebuild(s)
0 x86_64-darwin rebuild(s)
1 aarch64-linux rebuild(s)

First fifty rebuilds by attrpath
jamulus

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/5qdr1s64bwdn35far4s4a8kcmj26x292-jamulus-3.7.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A jamulus https://github.com/r-ryantm/nixpkgs/archive/40dfc62347ad86a4d62abfca4c3038456f5bf055.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/5qdr1s64bwdn35far4s4a8kcmj26x292-jamulus-3.7.0
ls -la /nix/store/5qdr1s64bwdn35far4s4a8kcmj26x292-jamulus-3.7.0/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

jamulus

Maintainer pings
cc @seb314 for testing.

Result of nixpkgs-review pr 117337 at 40dfc623 run on x86_64-linux 1

1 package built successfully:

jamulus

2 suggestions:

warning: unclear-gpl
gpl2 is a deprecated license, please check if project uses gpl2Plus or gpl2Only and change meta.license accordingly.
Near pkgs/applications/audio/jamulus/default.nix:23:5:
   |
23 |     license = lib.licenses.gpl2; # linked in git repo, at least
   |     ^

warning: unused-argument
Unused argument: fetchpatch.
Near pkgs/applications/audio/jamulus/default.nix:1:39:
  |
1 | { mkDerivation, lib, fetchFromGitHub, fetchpatch, pkg-config, qtscript, qmake, libjack2
  |                                       ^

The version from this PR seems to work fine (on my laptop).
I asked about the license.
Is there a way to push an extra commit to this pr to get rid of the unused argument?

Also, the jamulus repo was apparently transferred from corrados (the main contributor) to to github.com/jamulussoftware. There seems to be a redirect by github.
Should we update the repo owner? Any verifications necessary?

@seb314 yeah, we should update it but it can be a separate PR.


bug: bytecode for Account trait returns length as well

Bug Report
Kakarot RPC version: a8bd946

Current behavior:
The bytecode function from the Account trait will return the bytecode length included in the bytecode.

Expected behavior:
The bytecode function should just return the bytecode and remove the length.

Steps to reproduce:

Deploy bytecode to a contract and set the bytecode length.
Create a KakarotAccount object.
Call bytecode on it.

Related code:
https://github.com/kkrt-labs/kakarot/blob/main/src/kakarot/accounts/contract/library.cairo#L123
https://github.com/kkrt-labs/kakarot-rpc/blob/a8bd946b437b5a3ce2988a97cdf00d58f15c6641/crates/core/src/contracts/account.rs#L41-L44

Is this still up for grab? I think it is important

still available yes


Problem decoding base64 value for x-ms-client-principal and x-ms-auth-token

[Enter feedback here]
This is a coding problem, please share with the SWA team
The base64 encodedvalue is not padded out such that the string length is divisible by 4
Consequently the line..
var decoded = Convert.FromBase64String(data);
..will throw an exception intermittently, depending on the length of the string
To fix, pad out the encoded value with '=' chars so that the length is divisible by 4
Ref: https://en.wikipedia.org/wiki/Base64#Decoding_Base64_with_padding
"x-ms-auth-token" has the same issue.
Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 89705f24-082e-d4e9-547c-1992db4470cb
Version Independent ID: 5df6b7d0-7e8a-f6c5-ea28-289b9a0ca84e
Content: Accessing user information in Azure Static Web Apps
Content Source: articles/static-web-apps/user-information.md
Service: static-web-apps
GitHub Login: @craigshoemaker
Microsoft Alias: cshoe

@mike-westaway
Thanks for your feedback! We will investigate and update as appropriate.

Proceeding to close this thread. However, feel free to comment to my question above to continue the discussion. Having clarity will help in attempting to identify the issue.


Structblock in Streamfield on regular Django model errors out when editing attempted

Issue Summary
Editing a StreamField that is a property on a regular Django model and that is made up of StructBlocks does not work.
Steps to Reproduce

Add a StreamField property to a regular Django model (the following also uses Wagtail Font Awesome):

from wagtail.core import blocks

RICH_TEXT_STANDARD_FEATURES = ['h2', 'h3', 'h4', 'bold', 'italic', 'ol', 'ul', 'undo', 'redo', 'link', 'document-link', 'image', 'embed']

class OneColumnBlock(blocks.StructBlock):
    class Meta:
        icon = 'form'
        label = 'Full-width'
        template = 'snippets/columns_1.html'

    content = blocks.RichTextBlock(icon="fa-paragraph", features=RICH_TEXT_STANDARD_FEATURES)

class ImageLinkBlock(blocks.StructBlock):
    class Meta:
        icon='image'
        label = 'Image Link block'
        template = 'snippets/image_link_block.html'

    image = ImageChooserBlock(required=True)
    external_url = blocks.URLBlock(label="external URL", required=True)

class BlogPost(models.Model):
    content = StreamField([
        ('one_column', OneColumnBlock()),
        ('image_link', ImageLinkBlock()),
    ], default='')

    panels = [
        FieldPanel('content'),
    ]

Click on one of the StructBlocks to choose it.  The following error shows in the console:

stream.js:87 Uncaught TypeError: Cannot read property 'initializer' of undefined
    at Object.onInitializeMember (stream.js:87)
    at postInsertMember (sequence.js:102)
    at Object.self.insertMemberAtStart (sequence.js:203)
    at Object.onChooseBlock (stream.js:140)
    at HTMLButtonElement.<anonymous> (stream.js:60)
    at HTMLButtonElement.dispatch (jquery-3.2.1.min.js:3)
    at HTMLButtonElement.q.handle (jquery-3.2.1.min.js:3)

I have tried this on a couple of different regular Django models, and it fails the same on both.  It works fine when content is a property on a Page-type model.
Update:  This error is also occurring with Wagtail 2.7.  The same error message comes up in the console.
Technical details

Python version:  3.6.9
Django version:  2.2.6
Wagtail version:  2.6.2
Browser version:  Chrome 78 (also fails in latest Firefox)

Note:  Template files left out here because not necessary to verify above behavior.

I found the problem - turns out it wasn't a bug, but it is odd behavior - and I will leave this issue up in case it helps someone else.   I was puzzled because the exact same panel definition for content (using FieldPanel in the panels definition for content) actually works in the editor when content is a property of a Page-based model.  The solution, of course, was to use StreamFieldPanel in the panels definition for content when it is a property on a regular Django model.

Warning would be really nice :)


AppRailTile example not valid svelte "Classes can only be applied to DOM elements, not components"

Link to the Page
https://www.skeleton.dev/components/app-rail
Describe the Issue
Creating the app using the CLI and pasting the example causes error.

"Classes can only be applied to DOM elements, not components"
Are you able to create a Pull Request with the fix?
No

https://dev.skeleton.dev/components/app-rail
Already fixed in the updated docs :)


Fix HttpUrlConnection instrumentation

Currently our instrumentation only looks at the java.net.URLConnection#connected field and not the sun.net.www.protocol.http.HttpURLConnection#connecting when trying to add the header.
Since the connecting field was only introduced in Java 8, we are doing something instead.
In addition - removing the restriction for using ThreadLocal within advice classes.

:broken_heart: Build Failed

Expand to view the summary

Build stats

Build Cause: [Pull request #1391 opened]

Start Time: 2020-09-09T08:08:36.084+0000

Duration: 9 min 29 sec

Steps errors
Expand to view the steps failures

Name: Shell Script

Description: /_java_apm-agent-java-mbp_PR-1391/src/github.com/elastic/apm-agent-java/apm-agent-plugins/apm-es-res

Duration: 2 min 28 sec

Start Time: 2020-09-09T08:15:31.962+0000

log

Log output
Expand to view the last 100 lines of log output

[2020-09-09T08:18:00.284Z] [INFO] co.elastic.apm:apm-jms-plugin ...................... SUCCESS [  3.356 s]
[2020-09-09T08:18:00.284Z] [INFO] co.elastic.apm:apm-jmx-plugin ...................... SUCCESS [  0.886 s]
[2020-09-09T08:18:00.284Z] [INFO] co.elastic.apm:apm-jsf-plugin ...................... SUCCESS [  0.640 s]
[2020-09-09T08:18:00.284Z] [INFO] co.elastic.apm:apm-hibernate-search-plugin ......... SUCCESS [  0.421 s]
[2020-09-09T08:18:00.284Z] [INFO] co.elastic.apm:apm-hibernate-search-plugin-common .. SUCCESS [  0.614 s]
[2020-09-09T08:18:00.284Z] [INFO] co.elastic.apm:apm-hibernate-search-plugin-5_x ..... SUCCESS [  2.709 s]
[2020-09-09T08:18:00.284Z] [INFO] co.elastic.apm:apm-hibernate-search-plugin-6_x ..... SUCCESS [  2.199 s]
[2020-09-09T08:18:00.284Z] [INFO] co.elastic.apm:apm-es-restclient-plugin ............ SUCCESS [  0.397 s]
[2020-09-09T08:18:00.284Z] [INFO] co.elastic.apm:apm-es-restclient-plugin-common ..... SUCCESS [  1.154 s]
[2020-09-09T08:18:00.284Z] [INFO] co.elastic.apm:apm-es-restclient-plugin-5_6 ........ SUCCESS [  2.139 s]
[2020-09-09T08:18:00.284Z] [INFO] co.elastic.apm:apm-es-restclient-plugin-6_4 ........ SUCCESS [  2.409 s]
[2020-09-09T08:18:00.284Z] [INFO] co.elastic.apm:apm-grpc ............................ SUCCESS [  1.756 s]
[2020-09-09T08:18:00.284Z] [INFO] co.elastic.apm:apm-grpc-plugin ..................... SUCCESS [  2.023 s]
[2020-09-09T08:18:00.284Z] [INFO] co.elastic.apm:apm-kafka-plugin .................... SUCCESS [  0.798 s]
[2020-09-09T08:18:00.284Z] [INFO] co.elastic.apm:apm-kafka-base-plugin ............... SUCCESS [  1.037 s]
[2020-09-09T08:18:00.284Z] [INFO] co.elastic.apm:apm-kafka-headers-plugin ............ SUCCESS [  1.557 s]
[2020-09-09T08:18:00.284Z] [INFO] co.elastic.apm:apm-mongoclient-plugin .............. SUCCESS [  7.102 s]
[2020-09-09T08:18:00.284Z] [INFO] co.elastic.apm:apm-okhttp-plugin ................... SUCCESS [  0.898 s]
[2020-09-09T08:18:00.284Z] [INFO] co.elastic.apm:apm-opentracing-plugin .............. SUCCESS [  0.662 s]
[2020-09-09T08:18:00.284Z] [INFO] co.elastic.apm:apm-profiling-plugin ................ SUCCESS [  1.826 s]
[2020-09-09T08:18:00.284Z] [INFO] co.elastic.apm:apm-servlet-plugin .................. SUCCESS [  1.581 s]
[2020-09-09T08:18:00.284Z] [INFO] co.elastic.apm:apm-log-correlation-plugin .......... SUCCESS [  0.912 s]
[2020-09-09T08:18:00.284Z] [INFO] co.elastic.apm:apm-micrometer-plugin ............... SUCCESS [  1.041 s]
[2020-09-09T08:18:00.284Z] [INFO] co.elastic.apm:apm-log-shipper-plugin .............. SUCCESS [  0.854 s]
[2020-09-09T08:18:00.284Z] [INFO] co.elastic.apm:apm-spring-resttemplate-plugin ...... SUCCESS [  1.079 s]
[2020-09-09T08:18:00.284Z] [INFO] co.elastic.apm:apm-spring-webmvc-plugin ............ SUCCESS [  4.799 s]
[2020-09-09T08:18:00.284Z] [INFO] co.elastic.apm:apm-urlconnection-plugin ............ FAILURE [  0.129 s]
[2020-09-09T08:18:00.284Z] [INFO] co.elastic.apm:apm-scheduled-annotation-plugin ..... SKIPPED
[2020-09-09T08:18:00.284Z] [INFO] co.elastic.apm:apm-quartz-job-plugin ............... SKIPPED
[2020-09-09T08:18:00.284Z] [INFO] co.elastic.apm:apm-process-plugin .................. SKIPPED
[2020-09-09T08:18:00.284Z] [INFO] co.elastic.apm:apm-dubbo-plugin .................... SKIPPED
[2020-09-09T08:18:00.284Z] [INFO] co.elastic.apm:apm-scala-concurrent-plugin ......... SKIPPED
[2020-09-09T08:18:00.284Z] [INFO] co.elastic.apm:elastic-apm-agent ................... SKIPPED
[2020-09-09T08:18:00.284Z] [INFO] co.elastic.apm:apm-agent-benchmarks ................ SKIPPED
[2020-09-09T08:18:00.284Z] [INFO] co.elastic.apm:apm-es-restclient-plugin-7_1 ........ SKIPPED
[2020-09-09T08:18:00.284Z] [INFO] co.elastic.apm:apm-jedis-2-tests ................... SKIPPED
[2020-09-09T08:18:00.284Z] [INFO] co.elastic.apm:apm-jedis-3-tests ................... SKIPPED
[2020-09-09T08:18:00.284Z] [INFO] co.elastic.apm:apm-lettuce-3-tests ................. SKIPPED
[2020-09-09T08:18:00.284Z] [INFO] co.elastic.apm:apm-grpc-test-1.6.1 ................. SKIPPED
[2020-09-09T08:18:00.284Z] [INFO] co.elastic.apm:apm-opentracing ..................... SKIPPED
[2020-09-09T08:18:00.284Z] [INFO] co.elastic.apm:integration-tests ................... SKIPPED
[2020-09-09T08:18:00.284Z] [INFO] co.elastic.apm:simple-webapp ....................... SKIPPED
[2020-09-09T08:18:00.284Z] [INFO] co.elastic.apm:jsf-app ............................. SKIPPED
[2020-09-09T08:18:00.284Z] [INFO] co.elastic.apm:jsf-app-dependent ................... SKIPPED
[2020-09-09T08:18:00.284Z] [INFO] co.elastic.apm:jsf-app-standalone .................. SKIPPED
[2020-09-09T08:18:00.284Z] [INFO] co.elastic.apm:cdi-app ............................. SKIPPED
[2020-09-09T08:18:00.284Z] [INFO] co.elastic.apm:cdi-app-dependent ................... SKIPPED
[2020-09-09T08:18:00.284Z] [INFO] co.elastic.apm:cdi-app-standalone .................. SKIPPED
[2020-09-09T08:18:00.284Z] [INFO] co.elastic.apm:soap-test ........................... SKIPPED
[2020-09-09T08:18:00.284Z] [INFO] co.elastic.apm:apm-agent-attach .................... SKIPPED
[2020-09-09T08:18:00.284Z] [INFO] co.elastic.apm:application-server-integration-tests  SKIPPED
[2020-09-09T08:18:00.284Z] [INFO] co.elastic.apm:spring-boot-1-5 ..................... SKIPPED
[2020-09-09T08:18:00.284Z] [INFO] co.elastic.apm:spring-boot-2 ....................... SKIPPED
[2020-09-09T08:18:00.284Z] [INFO] co.elastic.apm:spring-boot-2-base .................. SKIPPED
[2020-09-09T08:18:00.284Z] [INFO] co.elastic.apm:spring-boot-2-jetty ................. SKIPPED
[2020-09-09T08:18:00.284Z] [INFO] co.elastic.apm:spring-boot-2-tomcat ................ SKIPPED
[2020-09-09T08:18:00.284Z] [INFO] co.elastic.apm:spring-boot-2-undertow .............. SKIPPED
[2020-09-09T08:18:00.284Z] [INFO] co.elastic.apm:external-plugin-test ................ SKIPPED
[2020-09-09T08:18:00.284Z] [INFO] ------------------------------------------------------------------------
[2020-09-09T08:18:00.284Z] [INFO] BUILD FAILURE
[2020-09-09T08:18:00.284Z] [INFO] ------------------------------------------------------------------------
[2020-09-09T08:18:00.285Z] [INFO] Total time:  02:25 min
[2020-09-09T08:18:00.285Z] [INFO] Finished at: 2020-09-09T08:18:00Z
[2020-09-09T08:18:00.285Z] [INFO] ------------------------------------------------------------------------
[2020-09-09T08:18:00.285Z] [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.8.1:compile (default-compile) on project apm-urlconnection-plugin: Compilation failure
[2020-09-09T08:18:00.285Z] [ERROR] /var/lib/jenkins/workspace/_java_apm-agent-java-mbp_PR-1391/src/github.com/elastic/apm-agent-java/apm-agent-plugins/apm-urlconnection-plugin/src/main/java/co/elastic/apm/agent/urlconnection/HttpUrlConnectionInstrumentation.java:[56,74] error: cannot infer type arguments for ThreadLocal<T>
[2020-09-09T08:18:00.285Z] [ERROR]   reason: '<>' with anonymous inner classes is not supported in -source 7
[2020-09-09T08:18:00.285Z] [ERROR]     (use -source 9 or higher to enable '<>' with anonymous inner classes)
[2020-09-09T08:18:00.285Z] [ERROR]   where T is a type-variable:
[2020-09-09T08:18:00.285Z] [ERROR]     T extends Object declared in class ThreadLocal
[2020-09-09T08:18:00.285Z] [ERROR] -> [Help 1]
[2020-09-09T08:18:00.285Z] [ERROR]
[2020-09-09T08:18:00.285Z] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[2020-09-09T08:18:00.285Z] [ERROR] Re-run Maven using the -X switch to enable full debug logging.
[2020-09-09T08:18:00.285Z] [ERROR]
[2020-09-09T08:18:00.285Z] [ERROR] For more information about the errors and possible solutions, please read the following articles:
[2020-09-09T08:18:00.285Z] [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
[2020-09-09T08:18:00.285Z] [ERROR]
[2020-09-09T08:18:00.285Z] [ERROR] After correcting the problems, you can resume the build with the command
[2020-09-09T08:18:00.285Z] [ERROR]   mvn <args> -rf :apm-urlconnection-plugin
[2020-09-09T08:18:01.969Z] Stage "Tests" skipped due to earlier failure(s)
[2020-09-09T08:18:02.210Z] Stage "Unit Tests" skipped due to earlier failure(s)
[2020-09-09T08:18:02.224Z] Stage "Smoke Tests 01" skipped due to earlier failure(s)
[2020-09-09T08:18:02.238Z] Stage "Smoke Tests 02" skipped due to earlier failure(s)
[2020-09-09T08:18:02.251Z] Stage "Benchmarks" skipped due to earlier failure(s)
[2020-09-09T08:18:02.264Z] Stage "Javadoc" skipped due to earlier failure(s)
[2020-09-09T08:18:02.459Z] Failed in branch Unit Tests
[2020-09-09T08:18:02.469Z] Failed in branch Smoke Tests 01
[2020-09-09T08:18:02.478Z] Failed in branch Smoke Tests 02
[2020-09-09T08:18:02.487Z] Failed in branch Benchmarks
[2020-09-09T08:18:02.495Z] Failed in branch Javadoc
[2020-09-09T08:18:02.781Z] Stage "Integration Tests" skipped due to earlier failure(s)
[2020-09-09T08:18:02.883Z] Stage "AfterRelease" skipped due to earlier failure(s)
[2020-09-09T08:18:02.926Z] Stage "AfterRelease" skipped due to earlier failure(s)
[2020-09-09T08:18:03.621Z] Running on Jenkins in /var/lib/jenkins/workspace/_java_apm-agent-java-mbp_PR-1391
[2020-09-09T08:18:04.002Z] [INFO] getVaultSecret: Getting secrets
[2020-09-09T08:18:04.100Z] Masking supported pattern matches of $VAULT_ADDR or $VAULT_ROLE_ID or $VAULT_SECRET_ID
[2020-09-09T08:18:05.050Z] + chmod 755 generate-build-data.sh
[2020-09-09T08:18:05.050Z] + ./generate-build-data.sh https://apm-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/apm-agent-java/apm-agent-java-mbp/PR-1391/ https://apm-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/apm-agent-java/apm-agent-java-mbp/PR-1391/runs/1 FAILURE 568691
[2020-09-09T08:18:05.601Z] INFO: curl https://apm-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/apm-agent-java/apm-agent-java-mbp/PR-1391/runs/1/steps/?limit=10000 -o steps-info.json

Is there a good way to test this fix?

Is there a good way to unit test this fix?

Not a very straightforward one. The reported stack trace is:
java.lang.IllegalStateException: Already connected
at sun.net.www.protocol.http.HttpURLConnection.addRequestProperty(HttpURLConnection.java:3190)
at co.elastic.apm.agent.urlconnection.UrlConnectionPropertyAccessor.setHeader(UrlConnectionPropertyAccessor.java:44)
at co.elastic.apm.agent.urlconnection.UrlConnectionPropertyAccessor.setHeader(UrlConnectionPropertyAccessor.java:34)
at co.elastic.apm.agent.impl.transaction.TraceContext.propagateTraceContext(TraceContext.java:530)
at co.elastic.apm.agent.impl.transaction.AbstractSpan.propagateTraceContext(AbstractSpan.java:558)
at sun.net.www.protocol.https.AbstractDelegateHttpsURLConnection.connect(AbstractDelegateHttpsURLConnection.java:175)
at sun.net.www.protocol.https.DelegateHttpsURLConnection.connect(DelegateHttpsURLConnection.java)
at sun.net.www.protocol.http.HttpURLConnection.getOutputStream0(HttpURLConnection.java:1350)
at sun.net.www.protocol.http.HttpURLConnection.getOutputStream(HttpURLConnection.java:1325)

We shouldn't get to the point of trying to add headers again, unless the instrumentation of sun.net.www.protocol.http.HttpURLConnection.getOutputStream is disabled. I don't know exactly what happened causing this, but in any case trying to add headers to a connection while its connecting state is true is not allowed.


Update ug with images

Codecov Report

Merging #327 (7a5d0a5) into master (de5b624) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #327   +/-   ##
=========================================
  Coverage     68.81%   68.81%
  Complexity      954      954
=========================================
  Files           137      137
  Lines          3168     3168
  Branches        446      446
=========================================
  Hits           2180     2180
  Misses          828      828
  Partials        160      160

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de5b624...7a5d0a5. Read the comment docs.


Search/Filter by license

First, thanks for all the awesome work !
It would be nice to be able to search / filter by license on this page https://ollama.com/library

I agree that the library needs a bit of work.
For exemple there is a lot of models that appears during a search, but you don't really know where they came from, how they are sorted etc.
There is a "view all" that is only accessible when you click on the search input.
Also this: 4596


Update the Buildkite logo

This updates the Buildkite logo, since it was updated last January.
Pre-submission checklist:

[x] Are you only including a repo_url if your project is 100% open source? If so, you need to pick the single best GitHub repository for your project, not a GitHub organization.
[x] Is your project closed source or, if it is open source, does your project have at least 250 GitHub stars?
[x] Have you picked the single best (existing) category for your project?
[x] Does it follow the other guidelines from the new entries section?
[x] Have you included a URL for your SVG or added it to hosted_logos and referenced it there?
[x] Does your logo clearly state the name of the project/product and follow the other logo guidelines?
[x] Does your project/product name match the text on the logo?
[x] Have you verified that the Crunchbase data for your organization is correct (including headquarters and LinkedIn)?
[x] ~5 minutes after opening the pull request, the CNCF-Bot will post the URL for your staging server. Have you confirmed that it looks good to you and then added a comment to the PR saying "LGTM"?

Deploy preview for landscape ready!
Built with commit 9992c972baa635c037e070c9775b837af8ea1749
https://deploy-preview-1172--landscape.netlify.com

LGTM 👍🏼


Level 1 crashes when using the recommended tauto tactic

I tried playing robo and even on the first level
https://adam.math.hhu.de/#/g/hhu-adam/robo/world/Proposition/level/1
the game immediately crashes and redirects me to a page saying
Oops!
Sorry, an unexpected error has occurred.

(intermediate value)(intermediate value)(intermediate value) is not iterable

Sorry for this.  This is probably a version conflict between the game and the server.  I checked that the development version at
https://adam-dev.math.hhu.de
is up and runnig.  (For the early planets this is identical with the deployed version.)  So you could start playing there until this problem is sorted out.

We updated the robo game and its playable again on https://adam.math.hhu.de/


Coerce ascii flags in MQTT publish service call.

Description:

Coerce QOS flag to integer
Parse humanized truthy values for RETAIN flag
Properly handle empty string for payload
Got tired trying to figure out how to make a vol.Exclusive option also required, ended up moving the goalposts in case no payload or template is given by sending an empty message

Related issue (if applicable): #1683
Checklist:
If the code does not interact with devices:

[X] Local tests with tox run successfully. Your PR cannot be merged unless tests pass
[X] Tests have been added to verify that the new code works.

This introduced a linting error. PyLint does not seem to realize that we have to call vol.Boolean as a function. Weird thing is that I can't seem to find why that would actually work :/

Already fixed it in dev.


If I have nested parallel loop, how can I change number of threads of inner parallel loop?

I have a function f that uses Rayon's parallel iterator to parallelize heavy computing. I want to run this f with different parameters in parallel. This scenario is very often like hyperparameter search in Machine Learning.
Here is a simple example code of the above case.
use rayon::prelude::*;
use std::{thread, time::Duration};

fn dummy_func(i: usize) -> usize {
    println!("started {}", i);
    let duration = Duration::from_secs(1);
    (0..4).into_par_iter().for_each(|_| thread::sleep(duration));
    println!("ended {}", i);
    i
}

fn main() {
    let mut res = vec![];
    (0..100)
        .into_par_iter()
        .map(|i| dummy_func(i))
        .collect_into_vec(&mut res);
    dbg!(res);
}

If the range of outer loop is large enough, turning off parallelization of the inner loop is preferred.  Now I want to know how I can dynamically change parallelization level of the inner loop function dummy_func. Shall I create a dedicated threadpool each time I call dummy_func ?

fn main() {
    let mut res = vec![];
    (0..100)
        .into_par_iter()
        .map(|i| {
            let pool = rayon::ThreadPoolBuilder::new()
                .num_threads(1)
                .build()
                .unwrap();
            pool.install(|| dummy_func(i))
        })
        .collect_into_vec(&mut res);
    dbg!(res);
}

If the range of outer loop is large enough, turning off parallelization of the inner loop is preferred.

I don't think you need to do anything to achieve this. If all of your threads are busy processing a task from the outer loop, the inner loop should be effectively single-threaded.
(Tasks will be created but they will never leave local task queue of the current thread as the other threads are busy and will there not steal them. This work stealing paradigm will generally keep all of your threads busy will minimal overhead. For example, think about the situation were different iterations of the outer loop will take significantly different amounts of time e.g. due to randomness. Work stealing will still keep are your cores busy whereas if you force the inner loop to be sequential, then some threads will idle as soon as fewer long-running tasks than threads remain.)
((If the remaining task creation overhead is measured to be too high, you can you with_min_len on the inner iterator to reduce the number of tasks it can be split into the worst case, but that really is fine-tuning.))

@adamreichold  Thank you for the explanation.
To check what you said, I changed my code as follows.
fn dummy_func(i: usize) -> usize {
    println!("started {}", i);
    let duration = Duration::from_secs(1);
    (0..4).into_par_iter().for_each(|j| {
        println!(
            "i = {}, j = {}, thread_id = {:?}",
            i,
            j,
            thread::current().id()
        );
        thread::sleep(duration);
    });
    println!("ended {}", i);
    i
}

I confirmed that for the same outer loop index i the thread id is also the same ragardless of the inner loop index j.
started 75
started 12
started 25
started 18
i = 18, j = 0, thread_id = ThreadId(6)
started 0
i = 0, j = 0, thread_id = ThreadId(7)
started 62
i = 75, j = 0, thread_id = ThreadId(9)
i = 12, j = 0, thread_id = ThreadId(2)
i = 25, j = 0, thread_id = ThreadId(4)
started 50
started 37
i = 62, j = 0, thread_id = ThreadId(5)
i = 50, j = 0, thread_id = ThreadId(3)
i = 37, j = 0, thread_id = ThreadId(8)
i = 37, j = 1, thread_id = ThreadId(8)
i = 50, j = 1, thread_id = ThreadId(3)
i = 62, j = 1, thread_id = ThreadId(5)
i = 25, j = 1, thread_id = ThreadId(4)
i = 0, j = 1, thread_id = ThreadId(7)
i = 12, j = 1, thread_id = ThreadId(2)
i = 18, j = 1, thread_id = ThreadId(6)
i = 75, j = 1, thread_id = ThreadId(9)
i = 75, j = 2, thread_id = ThreadId(9)
i = 12, j = 2, thread_id = ThreadId(2)
i = 0, j = 2, thread_id = ThreadId(7)
i = 25, j = 2, thread_id = ThreadId(4)
i = 18, j = 2, thread_id = ThreadId(6)
i = 62, j = 2, thread_id = ThreadId(5)
i = 50, j = 2, thread_id = ThreadId(3)
i = 37, j = 2, thread_id = ThreadId(8)
i = 50, j = 3, thread_id = ThreadId(3)
i = 62, j = 3, thread_id = ThreadId(5)
i = 37, j = 3, thread_id = ThreadId(8)
i = 25, j = 3, thread_id = ThreadId(4)
i = 18, j = 3, thread_id = ThreadId(6)
i = 12, j = 3, thread_id = ThreadId(2)
i = 0, j = 3, thread_id = ThreadId(7)
i = 75, j = 3, thread_id = ThreadId(9)
ended 12
ended 18
...


suite: use "suite_hash" as the default sha1 for workunit

as "workunits" reside in ceph/qa/workunits, it's more intuitive to
respect suite-branch option when cloning workunits.
Signed-off-by: Kefu Chai<EMAIL_ADDRESS>

This affects all of teuthology and all tasks, though, not just workunit; I'm not sure that's what we'd want, or how to tell what might break

@tchaikov I think we need one more change here: https://github.com/ceph/teuthology/commits/wip-teuth-config-suite-repo.  Otherwise it attempts to clone from git://git.ceph.com/ceph.git.
Do you want to pull into your branch or should I open a separate PR?

@idryomov cherry-picked and repushed. this PR is a bug fix now!

shouldn't the workunit match whatever ceph version is under test? as specified by -c flag, on the other hand I have been requesting to make workunits more generic so that they dont fail if not tested with right ceph version and skip tests that are not valid.

@vasukulkarni It will match the ceph version under test, if you don't specify --suite-repo / --suite-branch.
All this does is allows you to change that, should you want to.

@idryomov bit confusing, the placeholder change will overwrite all the workunits config, where will it select ceph version when no option is specified?

@vasukulkarni suite_hash defaults to ceph_hash, so if you don't specify --suite-repo / --suite-branch you'll get ceph_hash in there -- the current behavior IOW.

It makes sense to me.  I'd also like to see the commandline argument from teuthology, --suite-path, be able to set the path for workunits, but that's yet another PR

I think we definitely want to test this for 1 or 2 days with this, although it makes sense to me that it should match suite-repo, I am thinking there will be cases where we want to use ceph version even when we specify the separte suite branch for some of the qa wip branches during testing.

As mentioned in https://github.com/ceph/ceph/pull/13495, I tested this with http://pulpito.ceph.com/dis-2017-02-17_15:43:00-krbd-luminous-testing-basic-smithi/.
I don't see why, when running tests from branch A against branch B, you would want to use workunit scripts (i.e. a small subset of tests) from branch B.  If you really want to do that, just pull those scripts into A.
My use case is trying out new workunit scripts with existing (i.e. already built) (named) ceph branches.  For example, I paired a workunit from my ceph fork with luminous binaries from a week ago in that run.

@idryomov that is my use case as well,  but now since we are changing the behavior one has to  be careful when making wip-* branches which doesn't change workunits but work on other scripts(eg install script changes etc)
probably we can make that as an additional cli option to enforce this option and keep default as is?
Again for both the use cases we have overrides option to override the workunit branch option, but what I am asking here is we should keep the default as is, since that is the most common use case.

This looks good to me - any objections?

@zmc sure feel free to merge


NU1102: Unable to find package Ookii.CommandLine with version (>= 3.0.0)

I tried building the solution

I cant find Ookii.CommandLine 3.0.0 on Nuget even checking pre-releases

Hmmmm seams like Ookii.CommandLine deleted their 3.0.0 package from nuget.
Unfortunatly there is no netstandard version of the package. So it seams like I have to switch to another command line parser...

@kgreed I've replaced the Ookii commandline parser with a different one. Let me know if it's working now for you :)
If you need to push the packages to a server, you need to fiddle a little bit with the arguments in the buildPackages.bat file. The way this new command line parser handles optional params it a little bit different, but I don't have a private nuget feed by hand right now to test stuff out.

@biohazard999  thankyou. Only when I run buildpackages.bat I get an error saying that  build.ps1 is not digitally signed.

@kgreed that should normally not happen, but you can open a powershell with elevated permission and set the execution policy to unrestricted:
Set-ExecutionPolicy -ExecutionPolicy Unrestricted

Thanks
2 more questions. ( I will research them too)

Now I get an error message
System.IO.DirectoryNotFoundException: C:\Program Files (x86)\DevExpress 18.1\DevExpressCodedUIExtensions\Tools does not exists
I do have the universal version installed

I am unsure what to put in the buildPackages.bat for
set NugetPush=
given the build server is Azure DevOps

For the codedui stuff, Just ignore it, If you dont need it. I used codedui a Lot, so i included it.
Push is just a flag to automatically push the new packages to the source you define at nugetsource.
I did this so people dont push them to nuget.org by Default.
But If you Run the build, you should have a directory of packages (in c:/tmp/nuget)
Cause there are so much single packages i included the push option to Push them to a private Feed.
So setting the nuget source to the Azure Feed and and the push flag, it should mirror the nuget directory created.

Ah, I will look forward to that :-)  I am reading up on making my own Azure feeds,  Logging my progress at Stack Overflow

ah mybad for ooki - v3.0 was never published, I atttached it with the issue, and made a pull request on ooki.commandline repo, but got no answer so far. I tried to contact the maintainer through nuget in hope of an answer. I guess the next step would be to ask for nuget rights to the package, or create an alternative package ooki.commandline.core.

@thieum i changed the dependency with an alternative. I think tomorrow I'll got the global Tool finished :)


Added android equivalent code of Parse.initialize()

Way to initialize Parse from android

Thanks! This will hopefully answer a lot of the questions people have been asking :)

🎉 This change has been released in version 1.2.0


element isStuck bug when element is hidden and then unhidden

I'm using bootstrap and am hiding/unhiding a column depending on the browsers viewport width. The element in this column that is being fixed will automatically have the stuck state even though it's not in a vertical position where the isStuck state should be triggered.
I tried using the disableOn option that returns false on smaller viewport widths with no luck and think a possible solution would be to use some type of destroy method so that I can destroy/initialize the script.

Hey
I didn't notice this issue being open. Can you provide an example? I think we can solve this ;-)
Thanks


e2e: add workflow for e2e module.

Description
this has bugged me for some time, running make lint locally always found something in the e2e module to complain about. This workflow adds the linting step for the e2e module and it runs a few of the tests it defines.
closes: #XXXX

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

[ ] Targeted PR against the correct branch (see CONTRIBUTING.md).
[ ] Linked to GitHub issue with discussion and accepted design, OR link to spec that describes this work.
[ ] Code follows the module structure standards and Go style guide.
[ ] Wrote unit and integration tests.
[ ] Updated relevant documentation (docs/).
[ ] Added relevant godoc comments.
[ ] Provide a conventional commit message to follow the repository standards.
[ ] Include a descriptive changelog entry when appropriate. This may be left to the discretion of the PR reviewers. (e.g. chores should be omitted from changelog)
[ ] Re-reviewed Files changed in the GitHub PR explorer.
[ ] Review SonarCloud Report in the comment section below once CI passes.

Summary by CodeRabbit

New Features

Introduced a GitHub Actions workflow "E2E Module" for automated testing and linting on PRs targeting the e2e module.

Refactor

Simplified type conversion and comparison logic in GenesisTestSuite within the e2e tests.

I believe this closes #3695 as well.


Remove Update button

Not needed as AppEngine on backend will successfully update the transcriptions. This fixes the errors seen from firebase functions timing out

👍 good call. I was wondering what the update button is for.


Get products from API

Important: Make sure you have mongodb setup locally and seed it with data & the backend is running
Call the GET /products endpoint in the frontend
Use an env var for API URL since local and prod will be different
Set the products response into react state
Make sure the products display from react state

Hello, @hinchley2018 l would like to work on this issue.

Hi @mademoiselle-chantal go ahead I assigned you. LMK if you have any questions

Hello @hinchley2018. I apologize for not providing any feedback on this issue for such a long time. I've never worked with MongoDB before, and I was prepared to dive in and learn it while working on this problem. Unfortunately, it's been days, and I haven't been able to even install MongoDB on my computer.


Set attachment content from path

#491

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Rémi Parpaillon seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

@rparpa
We have not been able to merge your Pull Request, but because you are awesome - we wanted to make sure you could still get a SendGrid Hacktoberfest shirt.
Please go fill out our swag form before Nov 5th and we will send the shirt! (We know that you might have tried this before and it didn’t work, sorry about that!)
You have till Nov 5th to fill out this form in order to get the Hacktoberfest shirt!
Thank you for contributing during Hacktoberfest! We hope to see you in the repos soon! Just so you know, we always give away a SendGrid shirt for your first ever non-Hacktoberfest PR that gets merged.

Hello @rparpa,
Could you please fix the merge conflicts so that I may complete the code review? Thanks!
With Best Regards,
Elmer

Hello @thinkingserious
It's done, you should be able to review now.
Rémi

Hello @rparpa,Thanks again for the PR! We appreciate your contribution and look forward to                                              continued collaboration. Thanks!                                             Team SendGrid DX


Link each day with a pdf file

Hi,
I am wondering on how we can have the hyperlink on each day in the calendar. For instance, if i clicked certain date, it will link me to a pdf file. Since the html code is generated by the jquery function, is there any way to make this possible?
Thanks.

Hi @thaqiftaher
I'm really sorry for late answer.
Atm. I'm afraid it's impossible in only HTML way.
But don't worry.  You can always use built-in event to do things like that. Checkout documentation for more info.
Regards


Support generating authors pages for multiple blogs

Currently, the authors page shows all authors associated with all blogs. Each blog should have its own authors list – the blog model was designed to support independent blogs so that we could also reuse it for a current CC tech blog. As part of this, we should also not hardcode the blog title in the author templates.

@kgodey Can I work on this issue?

sure

You might find these commits useful: https://github.com/creativecommons/creativecommons.github.io-source/compare/704788fed5288d41d0176086bc7888cf493d4b01...7fea06684de5539a3a1c20835cbecff3e052459d for removing the duplication of the blog name.

Cool! Thanks for this.

@kgodey  I think we should change
{% block title %}{{ this.parent.title }} - {{ this.name }}{% endblock %}
{% block header %}{{ this.parent.title }}{% endblock %}

in blog-category.html template to
{% block title %}{{ this.parent.parent.children.get('entries').title + ' - ' + this.name }}{% endblock %}
{% block header %}{{ this.parent.parent.children.get('entries').title }}{% endblock %}

Title field was removed from blog-categories.ini model in 27badd06cbb3ae7c6c8635aabdea26f0703eef65

@makkoncept that looks good, thanks.

@makkoncept I made the change in https://github.com/creativecommons/creativecommons.github.io-source/commit/2edf7a9da84b32f89ea91b82546cb975988ae6ce.


Form support lacks related fields

FormComponent is capable of simple choice fields and saves their values correctly.
But if a field is a ForeignKey, the uploaded value doesn't seem to get into the backend - the field always is empty after a POST.

This bug is fixed by 9ad7189827c3d7cedbe6b1a05911dc807863434a


Unexpected behaviour with cuda.

When building a nvidia drivers image with micromamba as explained in https://micromamba-docker.readthedocs.io/en/latest/advanced_usage.html#adding-micromamba-to-an-existing-docker-image
with this env file
name: base
channels:
  - pytorch
  - nvidia
  - conda-forge
dependencies:
  - pytorch
  - numpy
  - pytorch-cuda=12.1
  - python=3.10

all works as expected and pytorch is installed with cuda. But if
channels:
  - conda-forge
  - pytorch
  - nvidia

is used (conda-forge is first), then the cpu only version of pytorch is installed. Is this a bug or expected behaviour?
My expectation is that channel order does not matter.
Thanks

I'm not so familiar with the particulars of GPU PyTorch, but I can say definitively that channel order matters. It's a list from highest to lowest priority. For details, please see https://conda.io/projects/conda/en/latest/user-guide/tasks/manage-channels.html.

Thanks for the clarification. So this is expected.


Compilation of tflite model shows that all operations will be on CPU rather than TPU even though all ops are supported.

I converted and quantized the cpm_hand model provided in the repo https://github.com/timctho/convolutional-pose-machines-tensorflow to tflite.
The quantized tflite file can be found at https://drive.google.com/file/d/15aHHyR-iamsDDpooV-GaKE9rjRqzZsfe/view?usp=sharing.
When I executed edgetpu_compiler -s -m 10  hand_quant.tflite command in the terminal then it provided the following output:
Edge TPU Compiler version 14.1.317412892

Model compiled successfully in 70 ms.

Input model: tflite_model/hand_quant.tflite
Input size: 23.38MiB
Output model: hand_quant_edgetpu.tflite
Output size: 23.38MiB
On-chip memory used for caching model parameters: 0.00B
On-chip memory remaining for caching model parameters: 0.00B
Off-chip memory used for streaming uncached model parameters: 0.00B
Number of Edge TPU subgraphs: 0
Total number of operations: 42
Operation log: hand_quant_edgetpu.log

Model successfully compiled but not all operations are supported by the Edge TPU. A percentage of the model will instead run on the CPU, which is slower. If possible, consider updating your model to use only operations supported by the Edge TPU. For details, visit g.co/coral/model-reqs.
Number of operations that will run on Edge TPU: 0
Number of operations that will run on CPU: 42

Operator                       Count      Status

QUANTIZE                       6          Operation is otherwise supported, but not mapped due to some unspecified limitation
CONCATENATION                  2          Operation is working on an unsupported data type
CONV_2D                        31         Operation is working on an unsupported data type
MAX_POOL_2D                    3          Operation is working on an unsupported data type

As per the docs https://coral.ai/docs/edgetpu/models-intro/#ops-table CONCATENATION, CONV_2D and MAX_POOL_2D are supported by Edge TPU and should run on TPU but that is not the case here.
Please comment on this and any help would be appreciated.

@akssieg apologies, it seems to be hitting a compiler bug that we've fixed. We're expecting a new release round mid Q4 along with this fix, for now, here is your model:
https://drive.google.com/file/d/13Lm9WrcJIyP-iIX13_piyef9YyGEhfYE/view?usp=sharing
FYI, that looks like a really kool project o_0

@Namburger thanks for the reply, I tried unzipping the files you provided via the link  using the command tar -xzf hand_quant.tar.gz but every time I get the following output:
gzip: stdin: not in gzip format
tar: Child returned status 1
tar: Error is not recoverable: exiting now

Secondly, I have a query regarding Coral TPU. Can I create my own custom ops for the TPU and then register it on the TPU compiler backend for its use?

@akssieg oh, you should be able to decompress it with this tar -xvf hand_quant.tar.gz
Unfortunately, since the compiler isn't opensource, you won't be able to implement this support for custom ops

@Namburger there was a little issue from my end regarding the decompression :| . Now its fine.

@Namburger quantized tflite model which has float input and output produces the desired correct results but when I do full integer quantization then the inference produces wrong results.
Since full integer quantized tflite model is not working, TPU compiled model is also not working.
Is there any way around? Could graph surgery be a good option? Like executing first layer on the cpu and the rest on coral usb accelerator?

@akssieg Oh, may I see how you perform the post processing ops?
Make sure you take the scale and zero points into consideration, similar to this: https://github.com/google-coral/tflite/blob/master/python/examples/classification/classify.py#L40-L41

Is there any way around? Could graph surgery be a good option? Like executing first layer on the cpu and the rest on coral usb accelerator?

The compiler should already take care of this for you :) When you compile the model and your i/o is still float, those ops wil automatically be on the CPU, fyi, quantize and dequantize is also a very lightweight ops, so I wouldn't worry too much about that in the first place if the float i/o model is working fine for you

For the float Input/Output tflite model, I do the following:
interpreter.set_tensor(input_details[0]['index'], img.astype("float32"))
interpreter.invoke()
output_data = interpreter.get_tensor(output_details[0]['index'])

The float model could be found at https://drive.google.com/file/d/1LymgBrWkUbxKk1njQFagbiYYCB6_8AAN/view?usp=sharing.
And for the full integer quantized tflite model:
scale, zero_point = input_details[0]['quantization']
img_input = img / scale + zero_point
interpreter.set_tensor(input_details[0]['index'], np.uint8(img_input))
interpreter.invoke()
output_data = interpreter.get_tensor(output_details[0]['index'])
scale1, zero_point1 = output_details[0]['quantization']
output_data = scale1 * (output_data - zero_point1)

Fully quantized float model => https://drive.google.com/file/d/1HHeNbsYQnyYwMODYsz-2sYmFp7XklBe_/view?usp=sharing.
@Namburger Sorry for asking you again but could you please also compile the float tflite model for coral usb accelerator as well?

@akssieg It is actually our fault that the compiler is being flaky :) Hopefully we'll have less bugs on the next release, here is the models you requested:
https://drive.google.com/file/d/1OGyBGKDcvnHO_iHt7R8ANscSUdHwvxVa/view?usp=sharing

Hi Namburger,
My Project is experiencing the same issue regarding the compiled tflite model having 0 Edge TPU subgraphs.  As we need the formfactor of the Pi Zero combined with an Edge TPU, we don't have another option and our project is completely blocked.
We look forward to your team's next release that will address this issue, but can you help us now by compiling our quantized tflite model linked to here: https://drive.google.com/file/d/1sVhXYgJeZVOjaSvkCPaGorYoUDv2ssSx/view?usp=sharing
This will unblock us and should keep us productive for weeks.  We are huge fans of the Edge TPU and plan to use them at scale with our commercial product.
Please help!

@JavierGSanchez sincerely apologize for this issue. As it turn out, even with our latest compiler, I can map everything to the edgetpu for the newest runtime version, but for runtime version 10
second_part.tar.gz
Since libedgetpu and tflite_runtime are both open source, would you like to try with a  newer runtime version instead?
Here is a related query: https://github.com/google-coral/edgetpu/issues/229#issuecomment-704576309

@JavierGSanchez See this answer for everything you need to get a very updated version of everything that works on a pi0!
Cheers!

Hi @Namburger, this is invaluable information and we'll be working on this today as moving to the latest version of the runtime is perfect for our project.
Just to confirm, you are recommending that we cross-compile both the tflite_runtime (or use rhadnum's wheels) and the libedgetpu.so for the armv6 arch per you instructions on #229 (comment)?

@JavierGSanchez Hello!
I definitely suggest using rhadnum's wheel (2.3.1) as he is nice enough to to provide it and we know for sure his wheel is working, then compile libedgetpu.so using my instruction.

And this would remove the need to use the edgetpu compiler correct, as the tflite_runtime would handle that for us?

Unfortunately, you'll still need to use the compiler, but you can use the latest runtime as opposed to the runtime version 10.

Perfect!  Will do!

Feel free to reopen if this issue still persists.

Hi @Namburger , unfortunately I am facing the same problem with my model, can you help me to fix it?
This is the output that I'm getting when i try to compile the model:
`Edge TPU Compiler version 16.0.384591198
Started a compilation timeout timer of 180 seconds.

Model compiled successfully in 69 ms.

Input model: pi_tflite.tflite
Input size: 10.96MiB
Output model: pi_tflite_edgetpu.tflite
Output size: 10.96MiB
On-chip memory used for caching model parameters: 0.00B
On-chip memory remaining for caching model parameters: 0.00B
Off-chip memory used for streaming uncached model parameters: 0.00B
Number of Edge TPU subgraphs: 0
Total number of operations: 157
Operation log: pi_tflite_edgetpu.log

Model successfully compiled but not all operations are supported by the Edge TPU. A percentage of the model will instead run on the CPU, which is slower. If possible, consider updating your model to use only operations supported by the Edge TPU. For details, visit g.co/coral/model-reqs.
Number of operations that will run on Edge TPU: 0
Number of operations that will run on CPU: 157

Operator                       Count      Status

RESHAPE                        4          Tensor has unsupported rank (up to 3 innermost dimensions mapped)
RESHAPE                        10         Operation is working on an unsupported data type
LOGISTIC                       1          Operation is working on an unsupported data type
CONV_2D                        72         Operation is working on an unsupported data type
DEPTHWISE_CONV_2D              51         Operation is working on an unsupported data type
ADD                            12         Operation is working on an unsupported data type
CUSTOM                         1          Operation is working on an unsupported data type
PACK                           4          Tensor has unsupported rank (up to 3 innermost dimensions mapped)
CONCATENATION                  2          Operation is working on an unsupported data type
Compilation child process completed within timeout period.
Compilation succeeded!`


Qingwei/mobile

Coverage remained the same at 29.828% when pulling cebf1915d9091ae6b3603e6bb0ecc8f847bc3bd1 on qingweibinary:qingwei/mobile into 167558eeb481fd2ca0d932b72f502a3b5b8becb0 on binary-com:master.

Tested in chrome mobile

Coverage remained the same at 29.828% when pulling 25bf2ee34536df2ae93dbe9a0781f0452cb5f6ac on qingweibinary:qingwei/mobile into 167558eeb481fd2ca0d932b72f502a3b5b8becb0 on binary-com:master.

Coverage remained the same at 29.828% when pulling 8c3bd238acc0fe02173a9b90e8ede4931b2ba80a on qingweibinary:qingwei/mobile into 167558eeb481fd2ca0d932b72f502a3b5b8becb0 on binary-com:master.


Broken links in ems-providers show-list view

Description
The show-list view of restful ems-providers has broken links, in the text below icon.
Screenshot
The bug showing bad links:

The fix showing good links:

Issue
https://github.com/ManageIQ/manageiq/issues/9874

@miq-bot add_label providers/containers, providers, ui, bug
@simon3z @moolitayer @zeari please review

@miq-bot assign yaacov

@yaacov First, thanks for adding a test! This mostly looks good to me, but I want to be sure this change doesn't effect other places where the action isn't supposed to be "show". I'm investigating this now.

I want to be sure this change doesn't effect other places where the action isn't supposed to be "show"

@hayesr we have a test for a none restful provider in line 319 so we have one test for none-restful provider, and one for restful provider.

I want to be sure this change doesn't effect other places where the action isn't supposed to be "show"

@hayesr ahh sorry, .... I didn't read ... calling url_for_db without "show" default to action = "show" so no change in the action here, only adding the item.

@h-kataria This fixes a regression with links under quadicons. I don't believe this negatively effects anything else. Can you check and merge if possible?

LGTM

@yaacov @h-kataria sorry for raising this again, but we are we sure we don't need this in darga? (e.g. it was a regression recently introduced only in master?). Thanks.

@simon3z @yaacov I'm pretty sure the problem was introduced when I refactored some code recently. (It was not backported) I tried your example above on darga and it was working correctly.

Thanks @hayesr for the clarification!


version.sbt missing?

Did you mean to add a version.sbt to the repo?
You seem to be talking about this file in your blog post, but it doesn't exist in the repo
Otherwise, where is the version kept?

Set the project’s version to the next development version and write it to the version file.

Hi @danyaljj
No part of the point of my blog article is to avoid the version.sbt file. The line you quote is taken from the paragraph where I detail the default behavior of sbt-release.
I then go on to explain that the version.sbt mechanism is not compatible with what I want (sha1 based versions)

With our setup, if we want to be able to repeat a specific version build all we have to do is checkout the corresponding tag which will automatically set the version to the correct value. Additionally, writing the version to an SBT file will kill the SHA-1 based versioning scheme we were using.

The version is defined either by the current SHA-1 (for snapshot builds) or by the git tag for the commit.
Building a check-out of the commit for a given tag will automatically rebuild the artifacts for this version.

I see I see. makes perfect sense.


Add 20190711, fix dates in other notes

Signed-off-by: Michael Ducy<EMAIL_ADDRESS>

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: mfdii
If they are not already assigned, you can assign the PR to them by writing /assign @mfdii in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

LGTM label has been added.  Git tree hash: 2b5980cc88c2db8710f9801f6871b874ab01d418

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: leodido
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [leodido]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Bad layout when using native title bar on Windows

VS Code version: Code - Insiders 1.38.0-insider (c8d44e24dd250d416475a10efe64e35c9e2c65b3, 2019-08-19T12:53:53.607Z)
OS version: Windows_NT x64 10.0.18956
Remote OS version: Linux x64 4.15.0-55-generic

System Info

Item
Value

CPUs
Intel(R) Xeon(R) CPU E5-1620 v4 @ 3.50GHz (8 x 3492)

GPU Status
2d_canvas: enabledflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onnative_gpu_memory_buffers: disabled_softwareoop_rasterization: unavailable_offprotected_video_decode: unavailable_offrasterization: unavailable_offskia_deferred_display_list: disabled_offskia_renderer: disabled_offsurface_synchronization: enabled_onvideo_decode: enabledviz_display_compositor: disabled_offwebgl: enabledwebgl2: enabled

Load (avg)
undefined

Memory (System)
63.92GB (44.07GB free)

Process Argv

Screen Reader
no

VM
0%

Item
Value

Remote
SSH: ubuntu

OS
Linux x64 4.15.0-55-generic

CPUs
Intel(R) Xeon(R) CPU E5-1620 v4 @ 3.50GHz (4 x 3491)

Memory (System)
10.79GB (0.86GB free)

VM
0%

Extensions (14)

Extension
Author (truncated)
Version

vscode-svgviewer
css
2.0.0

EditorConfig
Edi
0.13.0

vscode-pull-request-github-insiders
Git
2019.8.19623

vscode-docker
ms-
0.7.0

remote-containers
ms-
0.67.4

remote-ssh-edit-nightly
ms-
2019.8.26820

remote-ssh-explorer-nightly
ms-
2019.8.26820

remote-ssh-nightly
ms-
2019.8.26820

remote-wsl
ms-
0.39.3

vscode-typescript-tslint-plugin
ms-
1.2.2

debugger-for-chrome
msj
4.11.7

material-icon-theme
PKi
3.8.1

vscode-terminal-api-example
vsc
0.0.1

vscode-todo-highlight
way
1.0.4

(2 theme extensions excluded)

Happened again, this was in a workspace I haven't opened in a while:

I've tried using the native titlebar with a bunch of my old workspaces and haven't been able to repro, yet. I'm hoping someone else can repro this.

Just happened again when I opened the first new window of the morning. Successive new windows don't show the problem though.

/duplicate #79580

@sbatten while related, it might be a different issue? The status bar was affected for #79580 but not this

In console:
ERR Cannot read property 'toString' of undefined: TypeError: Cannot read property 'toString' of undefined
    at Object.t.asCSSUrl (file:///C:/Users/daimms.REDMOND/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:266:660)
    at new k (file:///C:/Users/daimms.REDMOND/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:5252:198)
    at d._createInstance (file:///C:/Users/daimms.REDMOND/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:1476:255)
    at d.createInstance (file:///C:/Users/daimms.REDMOND/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:1475:676)
    at e.getCompositeActions (file:///C:/Users/daimms.REDMOND/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:5272:96)
    at Object.getActivityAction (file:///C:/Users/daimms.REDMOND/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:5267:767)
    at Object.get activityAction [as activityAction] (file:///C:/Users/daimms.REDMOND/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:5264:607)
    at e.forEach (file:///C:/Users/daimms.REDMOND/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:5262:54)
    at Array.forEach (<anonymous>)
    at S.updateCompositeSwitcher (file:///C:/Users/daimms.REDMOND/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:5261:760)
    at S.layout (file:///C:/Users/daimms.REDMOND/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:5258:111)
    at e.layout (file:///C:/Users/daimms.REDMOND/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:5274:454)
    at v.layout (file:///C:/Users/daimms.REDMOND/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:489:535)
    at m.layoutView (file:///C:/Users/daimms.REDMOND/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:462:813)
    at m.layout (file:///C:/Users/daimms.REDMOND/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:463:66)
    at viewItems.forEach.e (file:///C:/Users/daimms.REDMOND/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:474:814)
    at Array.forEach (<anonymous>)
    at b.layoutViews (file:///C:/Users/daimms.REDMOND/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:474:801)
    at b.layout (file:///C:/Users/daimms.REDMOND/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:468:921)
    at f.layout (file:///C:/Users/daimms.REDMOND/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:482:685)
    at p.layoutView (file:///C:/Users/daimms.REDMOND/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:462:813)
    at p.layout (file:///C:/Users/daimms.REDMOND/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:462:981)
    at viewItems.forEach.e (file:///C:/Users/daimms.REDMOND/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:474:814)
    at Array.forEach (<anonymous>)
    at b.layoutViews (file:///C:/Users/daimms.REDMOND/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:474:801)
    at b.layout (file:///C:/Users/daimms.REDMOND/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:468:921)
    at f.layout (file:///C:/Users/daimms.REDMOND/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:482:685)
    at b.layout (file:///C:/Users/daimms.REDMOND/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:491:106)
    at b.layout (file:///C:/Users/daimms.REDMOND/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:499:88)
    at b.layout (file:///C:/Users/daimms.REDMOND/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:504:895)
    at W.layout (file:///C:/Users/daimms.REDMOND/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:5393:265)
    at W.<anonymous> (file:///C:/Users/daimms.REDMOND/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:5403:437)
    at Generator.next (<anonymous>)
    at file:///C:/Users/daimms.REDMOND/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:35:566
    at new Promise (<anonymous>)
    at n (file:///C:/Users/daimms.REDMOND/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:35:343)
    at e.invokeFunction.t (file:///C:/Users/daimms.REDMOND/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:5403:79)
    at d.invokeFunction (file:///C:/Users/daimms.REDMOND/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:1475:444)
    at W.startup (file:///C:/Users/daimms.REDMOND/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:5403:61)
    at Q.<anonymous> (file:///C:/Users/daimms.REDMOND/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:5931:430)
    at Generator.next (<anonymous>)
    at r (file:///C:/Users/daimms.REDMOND/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:35:399)

asDomUri returning undefined:
https://github.com/microsoft/vscode/blob/6e43f06929b810ab02fecc4d68d9f533271d7027/src/vs/base/browser/dom.ts#L1191-L1199

@alexandrudima looks like this could be caused by 623855b7c45993cf3eae9bef262f5222cd9fd827

I'm guessing this is the problem?
https://github.com/microsoft/vscode/blob/026b470f49bc27ace5b270521c837657d0794970/src/vs/base/browser/dom.ts#L1191-L1194
Shouldn't strict null checks cover that case 🤔

Not just windows, also got it on Mac, every window is totally broken.

I could not reproduce, but I pushed code to protect asCSSUrl from bad callers with type confusion...

@Tyriar What version were you using? You can deminify stacks using https://github.com/alexandrudima/vscode-stack-beautifier


Plutarch 1.2

Minor update because of #314 , new Plutus breaks a lot of things. How should we do this?
@srid
@TotallyNotChase
@t1lde
@blamario
@emiflake
(sorry for the ones whom I forgot)

new Plutus breaks a lot of things

Are these visible to users of Plutarch (aside from differing benchmarks)?

Yes, e.g. PSignature was removed as Signature was removed upstream.

Well, we should perhaps switch to staging workflow if we have breaking changes right now but still have issues to fix. If everything can be fixed with one PR, then I'm all for merging to master, drafting up the changelog and just releasing.
Can we please have a list of the issues that need tackling for this release?

I agree with that. Let's switch to that.

We need to fix #331


README.md: Update include and cmake instructions.

I had two (slight) difficulties when I wanted to depends on this
library.

I had to find myself the cmake target was named
subprocess::subprocess
I had to correct the include. The real one is
<subprocess/subprocess.hpp>

This patch attempts to clarify the README.md so that it will be clear for
the next developer after me.

Hi @https://github.com/rajatjain1997
Very nice library!
Could you please take a look? What do you think?

Thanks for your contribution!

Thanks for your library! I looked at 3 other ones, and this is the best one I have seen.


[spi_host] Verification sign-off for M2.5

Description
This tracks open verification tasks for M2.5.
See effort estimation docs for details.
CC @andreaskurth @hcallahan-lowrisc @a-will

estimate 3

[ ] DESIGN_DELTAS_CAPTURED_V2.5 [0.25d]
[ ] ALL_TOOL_WARNINGS_ARE_REVIEWED [0.5d]

Closing since SPI_HOST has been signed off.
Please re-open if that is not accurate.


NIFI-3138 - Adding urls, transport, proxy settings to rpg portion of …

Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:

[x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?

[x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

[x] Has your PR been rebased against the latest commit within the target branch (typically master)?

[x] Is your initial contribution a single, squashed commit?

For code changes:

[x] - N/A - Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
[x] - N/A - Have you written or updated unit tests to verify your changes?
[x] - N/A - If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[x] - N/A - If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
[x] - N/A - If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
[x] - N/A - If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

[x] - N/A - Have you ensured that format looks appropriate for the output in which it is rendered?

Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
…flow config xsd

@brosander Thanks for fixing this!
The error messages were logged in nifi-bootstrap.log as well when NiFi starts. Confirmed that the error messages are not logged after applying this fix. Merged into master.


Why don't we use regular functions?

I'm currently working on a PR that adds uglify.js to this. I'm wondering why instead of
function getSidebarElem() {

we use
https://github.com/matt8707/kiosk-mode/blob/039fc16d53fbadcff3201e9008c988ab4986cdcf/kiosk-mode.js#L18

Just habit I guess. They are the same thing, one is using ES6 arrow functions:
https://www.w3schools.com/js/js_arrow_function.asp
I'll be changing those functions soon anyhow:
I'm currently working on migrating everything over to mutationObservers as right now it's all in a setTimeout and that can be problematic. It's counting on the fact that everything will be rendered in the DOM within 200 milliseconds, when often it's not. If I set kiosk mode now and cache it, then quickly switch between dashboards, occasionally kiosk mode won't activate. On slower systems this would happen more often, like older tablets and devices.
Changing over to mutation observers would guarantee that the elements exist and the styles are inserted as soon as they exist. This would cut down on the time it takes for the header/sidebar to disappear and would only run code when needed.
I'm not sure uglify is really necessary. This is a very small script and if installed with HACS it gets compressed anyhow.

Yeah, babel would probably help since this would get used on old devices like wall mounted tablets and it would handle the conversion of any ES6 stuff we're using in there

Any use for GitHub Actions with git commit --amend, or do you think only manual running it would be needed?

I'd probably do it like https://github.com/custom-cards/boilerplate-card
Make it all automatic on release with actions. Check out the old Custom Header actions as well (not the ones for docs). There was some handy stuff in there like inserting the version number into the console tag automatically, etc.

If you're over on the HA discord, feel free to hit me up there. It's quite a bit easier than trying to communicate via issues and PRs

Not on Discord yet, but I wish I was.
Here's what I previously made:
name: Build

on:
  push:
    branches: [ master ]
  pull_request:
    branches: [ master ]

jobs:
  build:
    runs-on: ubuntu-latest
    steps:
    - uses: actions/checkout@v2
      with:
        fetch-depth: 0
    - name: Use Node.js 14.x
      uses: actions/setup-node@v1
      with:
        node-version: 14.x
    - run: npm install uglify-js @babel/core @babel/cli @babel/preset-env
    - run: |
        git config user.email<EMAIL_ADDRESS>        git config user.name "GitHub Actions"
        git pull
        mkdir -p dist
        touch dist/kiosk-mode.js
    - run: npx babel kiosk-mode.js --out-file kiosk-mode.js --presets @babel/preset-env
    - run: npx uglify-js kiosk-mode.js -b beautify=false,max_line_len=150 --compress --mangle toplevel --output dist/kiosk-mode.js
    - run: |
        git add dist/kiosk-mode.js
        git commit --amend --no-edit || true
        git push --force || true

LGTM. Have you tried it out and does it get hung up because of the arrow functions or was that just a general question?

Babel did a weird thing, and it prevented it from compressing it properly. And it looks like the compressed version was 64% size gzipped, 52% regular.

Not sure why it's having issues, I'm no babel expert, but arrow functions are just normal modern code.

It was doing this:

It should have been
function locIncludes(keywords) {

instead of
var locIncludes = function locIncludes(keywords) {

which was odd.

Pretty sure that's just how babel handles arrow functions for very old browsers, like anything lower than 3% usage.
At 3% it would do const locIncludes = function (keywords) {
At 2% it would do const locIncludes = function locIncludes(keywords) {
Not sure why that would affect anything else though.

If this was a large project I could maybe understand rewriting and attempting to avoid modern code to save space, but I don't really think it's necessary for a 4 kb file.

Going back on that, changed a bunch of functions from arrow to regular function declarations. Might help. Haven't released yet, but you could test with the code that's up now.


Compose and reminder buttons show up on print page

What I did
From an email, I clicked the 3 dots button->Print
What happened
When I go to print an email, the compose and reminder buttons show up there, blocking text in the printed pdf
What I expected
The compose and reminder buttons don't show up, just the email content as normal.

@voidlily Solved in latest commit


Component persisting on page change when not required

Thank you for a great plugin!
I have tried implementing it on my website, but there seems to be a weird issue. When I switch from a page that needs the ToC to a one that doesn't, there is a brief moment where a Table of Contents for the latter page is loaded before the component disappears. The lag is noticeable.
You can try it by going to this page and navigating to the homepage.
Recording:

I have included my component like this
Any thoughts on why this might be happening?

Thanks for reporting! 👍 Should be fixed in v0.1.11. Could you give that a try?

Thank you for the prompt patch, this seems to have fixed it!


Move x axis to the bottom

Probably this will sound as a really dumb question, but how do I move the x axis to the bottom of a chart?
I tried to use style={{ orient: BOTTOM }}, but that affects only the ticks, not the <g> element of the axis.
<Axis {...axisPropsFromBandedScale(widthScale)} style={{ orient: BOTTOM }} />

Are there any props I can pass to translate the <g> element?
By the way, cool library, I was looking for a way to avoid using refs for d3 axes.

Thanks! This library is pretty low-level -- so you can wrap the <g> with another <g> with a transform to position it in your chart. Something like:
<g transform={`translate(${padding}, ${padding + innerHeight})`}>
          <Axis
            {...axisPropsFromTickScale(xScale, 10)}
            style={{orient: BOTTOM}}
          />
        </g>
        <g transform={`translate(${padding}, ${padding})`}>
          <Axis
            {...axisPropsFromTickScale(yScale, 10)}
            style={{orient: LEFT}}
          />
        </g>


Update README.md

brew cask install blurred -> brew install --cask blurred

Oops this is a duplicate of #18.. my bad

heh, i was just thinking the same thing.


External Card/project link and goto button

Hello @tobybatch
Currently, ChromeKimaiBridge only supports External Card/Project ID.

However, if I want to quickly find out which project or card the record was created from, it requires too many actions to search.
I think it would be great to have another text field that would save the full link, as well as a button quick open on this link (opening a new tab in the browser).

What do you think about this improvement? Thanks!

Yes, it is!  I'm currently doing a full re-write, see here: https://github.com/tobybatch/ChromeKimaiBridge/issues/10#issuecomment-718963038
I'll incorporate it.


Using std::gmtime (Instead of gmtime_r and gmtime_s)

I'm using crow on MinGW, which does not build. Would it be possible to use std::gmtime as a more portable equivalent?
(This is my very first Github pull request. Let me know if I am failing any rules of etiquette. Thank you very much for Crow.)

From http://en.cppreference.com/w/cpp/chrono/c/gmtime

This function may not be thread-safe.

Since std::gmtime is not guaranteed to be thread-safe like gmtime_r or gmtime_s, it is probably not a good substitute.

From http://en.cppreference.com/w/cpp/chrono/c/gmtime

This function may not be thread-safe.

std::gmtime is not guaranteed to be thread-safe like gmtime_r or gmtime_s, so it is probably not a good a substitute.

Of course that's right, std::gmtime is not thread safe. Makes sense to me now why it wasn't used already!
Would this be acceptable instead?
-#ifdef _MSC_VER
+#if defined(_MSC_VER) || defined(__MINGW32__)
                                 gmtime_s(&my_tm, &last_time_t);

Since gmtime_s (but not gmtime_r) is available on MinGW.

Yes, using gmtims_s for MinGW seems OK. Would you make another PR for mingw32 and mingw64?
Also it will be a good idea to add a MinGW build command to travis.

__MING32__ is defined for both 32 and 64 bit, so https://github.com/ipkn/crow/pull/274 should work for both.
I am new to Travis, but I thought it was Linux/Mac only. Do you mean cross-compile on Linux with mingw toolchain?  I will try to learn how to set that up.

Sorry, I didn't know whether travis supporting mingw or not and adding to travis was a different issue.
I will merge #274 after you rollback changes on .travis.yml. Currently it removes test for other compilers.

It's possible to cross-compile to mingw on (Travis) Linux, but there is no easy way of getting mingw versions of boost-system that crow needs. Building Boost seems like overkill in this context.
#274 is ready to merge.


Wine integration request

Would love to have the interface running via wine, that way I don't need to boot into windows to play. The interface is looking for game.exe atm.

Sorry to say that, but most likely this wont be happening. I installed ubuntu in a vm and tried to get D2 running, without success (directx or graphic issues i suppose).
DiabloInterface launched, but only the main window, also with terrible layout (was cut in half).
I dont even know if you can debug c# applications in linux correctly.
So unless someone with a real linux system (and some knowledge about debugging c# apps in it) will take a look at this, there are very low chances that this will be a thing. :disappointed:

Going with what @Zutatensuppe previously commented, we're not going to support this for now.


Add new slangs

New slangs needed
While I was giving a try to Abbreve, i typed ngl but unfortunately didn't get any results in return - i know the project is still so young but no problem.
Same thing goes for ftw.

This is currently being worked on! The reason the slang didn't show is that the abbreviation for it isn't available yet. You can open a pr to add them.

Oh yeah I know they don't exist yet. Will do ;)

Oh yeah I know they don't exist yet. Will do ;)

ngl was just recently added. If you are still keen on making a contribution, I'd say add only ftw


Support Custom errors

Whern you have a custom error struct
// (APIError) implements Error
func Stats(req *StatsRequest) (Stats, *APIError) {
    retur nsomething, nil
}

The error hook is always fired even if you return nil

I will look at it, thanks for your report!

Problem solved in pull request #6


MULTICUE checkpoint

Dear @pkuCactus,
thanks again for your work. Please, could you provide us the checkpoint trained in the Multicue dataset?
Cheers,
Xavier

waiting for that too