Deploying to Heroku

Hi @nyancodeid , 🙂
How can I use your fork with Heroku? I tried to make a fork of your project and after that to deploy to Heroku but without success. Thanks!

This fork need docker-compose run first to make it run rethinkdb. And 'til now i don't know how to configure it on heroku and what should i write on configuration file.
'cause this repository structure and how it's work is totally different from the original, that's why we need different treatment.

I try to fork your git and added app.json from original git, but it's still show error
-----> Node.js app detected
-----> Creating runtime environment
   NPM_CONFIG_LOGLEVEL=error
   NODE_ENV=production
   NODE_MODULES_CACHE=true
   NODE_VERBOSE=false

-----> Installing binaries
engines.node (package.json):  unspecified
engines.npm (package.json):   unspecified (use default)
   Resolving node version 12.x...
   Downloading and installing node 12.20.0...
   Using default npm version: 6.14.8

-----> Installing dependencies
Installing node modules
   ><EMAIL_ADDRESS>install /tmp/build_d242d8f1_/node_modules/fsevents
   > node install.js

   Skipping 'fsevents' build as platform linux is not supported

   ><EMAIL_ADDRESS>install /tmp/build_d242d8f1_/node_modules/sharp
   > (node install/libvips && node install/dll-copy && prebuild-install --runtime=napi) || (node-gyp rebuild && node install/dll-copy)

   info sharp Downloading https://github.com/lovell/sharp-libvips/releases/download/v8.9.1/libvips-8.9.1-linux-x64.tar.gz

   ><EMAIL_ADDRESS>install /tmp/build_d242d8f1_/node_modules/bcrypt
   > node-pre-gyp install --fallback-to-build

   [bcrypt] Success: "/tmp/build_d242d8f1_/node_modules/bcrypt/lib/binding/napi-v3/bcrypt_lib.node" is installed via remote

   ><EMAIL_ADDRESS>postinstall /tmp/build_d242d8f1_/node_modules/nodemon
   > node bin/postinstall || exit 0

   Love nodemon? You can now support the project via the open collective:
    > https://opencollective.com/nodemon/donate

   ><EMAIL_ADDRESS>postinstall /tmp/build_d242d8f1_/node_modules/core-js
   > node -e "try{require('./postinstall')}catch(e){}"

   added 1009 packages in 16.493s

-----> Build
Running build
   ><EMAIL_ADDRESS>build /tmp/build_d242d8f1_
   > npm run clean && npm run build:source && cp -r ./src/views ./build/views

   ><EMAIL_ADDRESS>clean /tmp/build_d242d8f1_
   > rm -rf build && mkdir build

   ><EMAIL_ADDRESS>build:source /tmp/build_d242d8f1_
   > babel -d ./build ./src -s

   Successfully compiled 13 files with Babel (1102ms).

-----> Caching build
- node_modules
-----> Pruning devDependencies
removed 740 packages and audited 263 packages in 10.05s
   10 packages are looking for funding
     run `npm fund` for details

   found 3 vulnerabilities (2 low, 1 high)
     run `npm audit fix` to fix them, or `npm audit` for details

-----> Build succeeded!
-----> Discovering process types
Procfile declares types     -> (none)
Default types for buildpack -> web
-----> Compressing...
Done: 36.7M
-----> Launching...
Released v3
https://****.herokuapp.com/ deployed to Heroku
I'm trying to paste compiled version on extension, and it gives me that error Invalid compression service address
Given URL does not appear to be running Bandwidth Hero data compression service.

I try to fork your git and added app.json from original git, but it's still show error
-----> Node.js app detected
-----> Creating runtime environment
   NPM_CONFIG_LOGLEVEL=error
   NODE_ENV=production
   NODE_MODULES_CACHE=true
   NODE_VERBOSE=false

-----> Installing binaries
engines.node (package.json): unspecified
engines.npm (package.json): unspecified (use default)
   Resolving node version 12.x...
   Downloading and installing node 12.20.0...
   Using default npm version: 6.14.8

-----> Installing dependencies
Installing node modules
   ><EMAIL_ADDRESS>install /tmp/build_d242d8f1_/node_modules/fsevents
   > node install.js

   Skipping 'fsevents' build as platform linux is not supported

   ><EMAIL_ADDRESS>install /tmp/build_d242d8f1_/node_modules/sharp
   > (node install/libvips && node install/dll-copy && prebuild-install --runtime=napi) || (node-gyp rebuild && node install/dll-copy)

   info sharp Downloading https://github.com/lovell/sharp-libvips/releases/download/v8.9.1/libvips-8.9.1-linux-x64.tar.gz

   ><EMAIL_ADDRESS>install /tmp/build_d242d8f1_/node_modules/bcrypt
   > node-pre-gyp install --fallback-to-build

   [bcrypt] Success: "/tmp/build_d242d8f1_/node_modules/bcrypt/lib/binding/napi-v3/bcrypt_lib.node" is installed via remote

   ><EMAIL_ADDRESS>postinstall /tmp/build_d242d8f1_/node_modules/nodemon
   > node bin/postinstall || exit 0

   Love nodemon? You can now support the project via the open collective:
    > https://opencollective.com/nodemon/donate

   ><EMAIL_ADDRESS>postinstall /tmp/build_d242d8f1_/node_modules/core-js
   > node -e "try{require('./postinstall')}catch(e){}"

   added 1009 packages in 16.493s

-----> Build
Running build
   ><EMAIL_ADDRESS>build /tmp/build_d242d8f1_
   > npm run clean && npm run build:source && cp -r ./src/views ./build/views

   ><EMAIL_ADDRESS>clean /tmp/build_d242d8f1_
   > rm -rf build && mkdir build

   ><EMAIL_ADDRESS>build:source /tmp/build_d242d8f1_
   > babel -d ./build ./src -s

   Successfully compiled 13 files with Babel (1102ms).

-----> Caching build

node_modules

-----> Pruning devDependencies
removed 740 packages and audited 263 packages in 10.05s
   10 packages are looking for funding
     run `npm fund` for details

   found 3 vulnerabilities (2 low, 1 high)
     run `npm audit fix` to fix them, or `npm audit` for details

-----> Build succeeded!
-----> Discovering process types
Procfile declares types -> (none)
Default types for buildpack -> web
-----> Compressing...
Done: 36.7M
-----> Launching...
Released v3
https://****.herokuapp.com/ deployed to Heroku
I'm trying to paste compiled version on extension, and it gives me that error Invalid compression service address
Given URL does not appear to be running Bandwidth Hero data compression service.

Unfortunately, this repository not compatible with Heroku yet. cause we need run docker-compose first. I think we can create unauthenticated version so we can use heroku as a server.

Now, it's available. Happy deploy to Heroku :)

Deployed on Heroku and paste generated URL but got this error: Invalid compression service address
Given URL does not appear to be running Bandwidth Hero data compression service.

yes

Deployed on Heroku and paste generated URL but got this error: Invalid compression service address Given URL does not appear to be running Bandwidth Hero data compression service.

yes


Show every RemovedInDjango19Warning once instead of ignoring it

Kind of superseded by EuroPython/epcon#771; the filter should just be removed instead


consider renaming the repo to fcli

It seems this became a standalone tool, so better treat it as such.
With repo renamed to fcli and pypi package matching it.

@wdesmedt shall we go with the repo rename?


Possibly reading from tarfiles before file is streamed from S3?

I'd tried to stream .tar and .tar.gz files from S3 compatible storages and it seems like due to a slightly slow connection or something, we might read and get the filename from the tarball first, i.e. here, but then the rest of the bytes might now load because the associated file might be bigger and this line fails. And as such we end up with errors such as:
[rank7]:     raise ReadError("unexpected end of data")
[rank7]: tarfile.ReadError: ("unexpected end of data @ <Pipe (('aws s3 cp --profile r2 --endpoint-url S3_URL s3://BUCKET/KEY.tar -',), {'shell': True, 'bufsize': 8192})>", <webdataset.gopen.Pipe object at 0x7319f759d600>, 'pipe:aws s3 cp --profile r2 --endpoint-url S3_URL s3://BUCKET/KEY.tar -')

The URL that we run is pipe:aws s3 cp --endpoint-url CUSTOM_S3_URL s3://BUCKET/KEY.tar.gz -
Currently trying with pipe:aws s3 cp --endpoint-url CUSTOM_S3_URL s3://BUCKET/KEY.tar.gz - | cat to see if it improves things a little somehow.
This is probably related to #21 and #35

Ended up writing an exception handler which helped to skip files that aren't streamed fully, e.g.:
handler=lambda x: print(x)

And an alternative was also to use the local cache directory to download tarballs first before reading from them. Nonetheless don't think this is meant to be expected behaviour from well used S3/S3-compatible object stores.

Subscribing. I'm also seeing those unexpected end of data when reading from GCS.


[stable/dokuwiki] Fix defaults, references to Joomla in Dokuwiki README.md

What this PR does / why we need it:
The README for Dokuwiki had some references to Joomla. Additionally, some of the default values specified did not match those set in Values.yaml - this corrects these

/assign @carrodher

/lgtm
/ok-to-test


[SPARK-33591][SQL][FOLLOWUP] Add legacy config for recognizing null partition spec values

What changes were proposed in this pull request?

This is a follow up for https://github.com/apache/spark/pull/30538.
It adds a legacy conf spark.sql.legacy.parseNullPartitionSpecAsStringLiteral in case users wants the legacy behavior.
It also adds document for the behavior change.
Why are the changes needed?

In case users want the legacy behavior, they can set spark.sql.legacy.parseNullPartitionSpecAsStringLiteral as true.
Does this PR introduce any user-facing change?

Yes, adding a legacy configuration to restore the old behavior.
How was this patch tested?

Unit test.

cc @cloud-fan @HyukjinKwon @MaxGekk

Test build #134741 has started for PR 31421 at commit b062f8b.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39327/

Test build #134741 has finished for PR 31421 at commit b062f8b.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/134741/

@MaxGekk Thanks for the suggestions. I have addressed all of them.

Test build #134756 has started for PR 31421 at commit 971ccbd.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39342/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39342/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39342/

Merged to master.
@gengliangwang would you mind changing the version and making backporting PRs please?

@cloud-fan Thanks for the comments. I have addressed them in https://github.com/apache/spark/pull/31434

Test build #134756 has finished for PR 31421 at commit 971ccbd.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/134756/


fix syntax in error case

Originally reported in #215.

Codecov Report

Merging #221 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #221   +/-   ##
=======================================
  Coverage   77.42%   77.42%
=======================================
  Files          54       54
  Lines        3109     3109
  Branches      512      512
=======================================
  Hits         2407     2407
  Misses        675      675
  Partials       27       27

Impacted Files
Coverage Δ

colcon_core/task/python/build.py
0% <ø> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 521dc36...9ee21d5. Read the comment docs.


visualising bboxes/masks

Hey, how about an extension for the Detection class and drawing.py to add bboxes and masks to directly visualize them?
Do you think this would fit norfair?

Hey, thanks for the proposal! We are currently in the process of merging support for MOT metrics into the library, which includes a bbox drawing function, so that capability will soon be added. Regarding segmentation, I don't think it currently fits into Norfair's use cases, though I may be wrong.
I think for the time being these capabilities won't be needed, but I really appreciate the ideas. Any other ideas you have are most definitely welcome. Thanks!

Hi, I just wanted to add a note of support for the proposed functionality of drawing masks. I think it would be really helpful to be able to visualise the predicted segmentation in addition to the centroid spot. This will help to verify the quality of the detections.
Thanks!

Hey @nachonacho2 thanks for the feedback. I think we'll add mask drawing through https://github.com/tryolabs/norfair/pull/24/files as it seems to be something people need, doesn't really expand norfair's surface area too much, and is easy to implement. So stand by for it!


Fix missing period in README

Missing period in module name Ecto.Repo was added.

:heart: :green_heart: :blue_heart: :yellow_heart: :purple_heart:


support for Objective-C and Objective-C++

i just added these two lines and it worked fine:
'.m': { parserName: 'defaultParser' },
'.mm': { parserName: 'defaultParser' },

Glad to hear! Feel free to add a PR

Thanks @core-code, added support for those languages!


[0.12.n regression] Asset Mutability Test

Sync fails for non-authoritative peer. The non-authoritative peer did not see the asset update.

Fixed with microsoft/mixed-reality-extension-unity#92


Safari needs to be restarted to get the content to play

Have you read the FAQ and checked for duplicate open issues?
What link can we use to reproduce this?
https://shaka-player-demo.appspot.com/demo/#audiolang=en-US;textlang=en-US;uilang=en-US;asset=https://d1sz9kpfvhhqqm.cloudfront.net/6bc94da86c90696cdfb9a29d3c6a5ed35cad8d43cf008798d912ff691a61982d/533c5bcb5dc450a03c0b44f0659ecb84f0318f142f10bf4ca3a15e95bc7053b9/5ce259b1-8144-11ed-a41d-cba3bd8fcc26/asset_video/AV_asset_5ce259b1-8144-11ed-a41d-cba3bd8fcc26.m3u8;license=https://fp.service.expressplay.com/hms/fp/rights/?ExpressPlayToken=BwAqVaU0KckAJDI2NzUwMjgyLTI2M2ItNGRlZi1iZGQzLTZiNzdiNjM4ZDNhZAAAAJBhcrwQWsK3sNMXFVHfC_vOomFlMFRhbovMuGxQTRVUcA4YogCEwftPMNxkyvKtuEU2gYptjNrhsTcgUkvHt8Y1DMJhyQZbps-_Pxt_VahdO4b8JbiB6cQmZLaLUaIdhq6oesabQM5NuJ5w2DjjJVurgMoRmfoE4cu0RTYbuU82gkJmf66Tn9g2MzFmjKMiFTY4b_J44FisHAxGbhAonTwlwYPykg;certificate=https://fpexpressplay.s3.amazonaws.com/fairplay.cer;panel=CUSTOM CONTENT;build=uncompiled
What version of Shaka Player are you using?
v4.3.2-uncompiled
What browser and OS are you using?
Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/16.1 Safari/605.1.15
What did you do?

What did you expect to happen?
The content is supposed to playback every time I press the play button.
What actually happened?
The content plays once, then if I tried to play it again it does not and the error (Shaka Error MEDIA.VIDEO_ERROR (3,,Media failed to decode)) is returned.  Once I shut down safari (quit)and restart it, then the content plays again.

If you call player.load() (or click the "load" button in the demo) a second time instead of clicking the play button, is that an effective workaround?  The answer to that could help point us toward the root cause.


EXC_Bad_Access on GULMutableDictionnary (Google Utilities)

[REQUIRED] Step 2: Describe your environment

Xcode version: XCode 10.1
Firebase SDK version: 5.15.0
Firebase Component: Auth, Core, Database, Firestore, Messaging, Storage, Performance
Component version: 5.15.0

[REQUIRED] Step 3: Describe the problem
When running our app in debug mode on the Simulator (tested iPhone 8), the app crashes right away due to an Exc_Bad_Access error. Based on the XCode log report the issue seems to be here in Google Utilities/ Network/ GULMutableDictionnary:
- (void)removeObjectForKey:(id)key {   dispatch_async(_queue, ^{     [self->_objects removeObjectForKey:key];   }); }
I noticed a memory corruption bug in our app in production that highlighted a pointer being freed that was not allocated. Given that the above happens at launch, it could very well be the same issue (i.e., object not initiated but being deallocated).
Steps to reproduce:
Running firebase SKD v5.15.0 and launching an app on iPhone 8 simulator. Given the memory corruption issue noticed in production, I turned on the Zombie Object debugging in my debug scheme, which is the one I run. When I turn Zombie Object debugging off in my scheme, the app runs fine (but I suspect the memory corruption still happens, just undetected).
Problem only occurs when running on the Xcode simulator (tried using iPhone 8 simulator), NOT on the physical device. Only tested in debug mode.
Relevant Code:
Not particular code to reproduce the problem. The EXC_bad_Access is being triggered in the GoogleUtilities pod and highlight the following code (line 61):
- (void)removeObjectForKey:(id)key {   dispatch_async(_queue, ^{     [self->_objects removeObjectForKey:key]; <== Line highlighted   }); }
Thanks for the help!

Thanks for the report @fschaus - can you please share a Podfile or list of frameworks you're including with the project that causes this to happen?
A stack trace would be extremely helpful as well, giving us the full stack to see where the call to removeObjectForKey: originated from.
If you update to the latest Firebase (5.17.0 as of this writing) does it happen still?

This is the same as the new crash reported in the comments in https://github.com/firebase/firebase-ios-sdk/issues/1624.

Closing for staleness. Please open a new issue if this reoccurs in a recent release.


rclone move overwrite

When moving files to ACD:
rclone move ~/Main acd:/Main

How can I make it overwrite files that are different? In the current doc it says:

Rclone will error if the source and destination overlap.

I want it to overwrite files if they already exist and if they are different.

The source and the destination don't overlap in your example, one is on the local disk, the other is on acd so it should work fine.
If you did
rclone move acd:Main acd:/Main/Sub

Then they would overlap

I see, so when using move it will overwrite?

It will use the same logic as sync or copy - by default it will overwrite if it is different, otherwise it will just delete the source.

I think you should find this is fixed in the latest beta: http://beta.rclone.org/v1.35-19-g499766f/

I issued the command for Amazon cloud drive:
rclone move remote:images/acbd remote:images
I got this error message:
amazon drive root 'images': can't move files on overlapping remotes
Failed to move: can't move files on overlapping remotes
I then checked images/abcd folder.  The files are still there, not erased.


New saga utils: applied to devices

This introduces the 2 new saga utils which will replace safeTake* and actionTo*
as mentioned in the confluence doc we now have
  yield* Saga.chainAction<DevicesGen.RevokePayload>(DevicesGen.revoke, revoke)

and
  yield* Saga.chainGenerator<DevicesGen.ShowPaperKeyPagePayload>(DevicesGen.showPaperKeyPage, requestPaperKey)

originally I was trying to coerce flow to derive the action types but this proved very hard. Instead you have to explicitly pass the generic. if you don't pass the type then your action will be untyped totally. as we get more flow-strict that should be caught
good news is coverage goes up due to this pr. I think 90% of the time we can just use chainAction and be done
actions/devices.js
master:
Covered: 96.12% (322 of 335 expressions)
pr:
100.00% (319 of 319 expressions)

@keybase/react-hackers this is ready


Java Triple Quotes not working properly

I have this weird bug while coding by using jdk 17, Syntax highlighting colors are not working as intended.
Take a look here

Hello @chiqors - thanks for raising this issue. Could you please post the code sample as well so I can try it out locally?

Hello @chiqors - thanks for raising this issue. Could you please post the code sample as well so I can try it out locally?

this is my repo: https://github.com/chiqors/java17-plain

Looks like this issue happens with the default theme as well, so seems like a vscode thing rather than the theme. Closing this issue.

Java extension pack by microsoft and redhat solve the case if you install it. But, you need to disable this theme and use default dark+ theme


Issues loading on 1.21.1 paper #52

I tried a fresh config to make sure it wasnt something with my settings. doing /mgive wand gives me the unknown item instead.
latest.log
I tried looking at some tickets but nothing jumped out as similar

Heres a plugin list
AdvancedServerList, ajLeaderboards, ArmorTrimEdit, Citizens, ClearLag, CMI, CMILib, CreeperRecover, CustomCrops, DtlPlayershops, dtlTraders, Dwellin, ExcellentEnchants, FastAsyncWorldEdit, HeadDatabase, HuskHomes, Jobs, LibsDisguises, Lootin, LuckPerms, Magic, MapModCompanion, MarriageMaster, mcMMO, McmmoGuiV2, Multiverse-Core, MyPet, MythicMobs, MythicMobsExtension, nightcore, Oraxen, packetevents, PeacefulPlayerRepacified, PhantomSpawnControl, PlaceholderAPI, PlugManX, ProtocolLib, PyroFishingPro, PyroLib, PyroMining, RealScoreboard, SafeNBT, ServerSigns, StripArmour, SwimmingHorses, Vault, ViaBackwards, ViaVersion, Vivecraft-Spigot-Extensions, WorldEditSelectionVisualizer, WorldGuard, XConomy, LightAPI, WanderingTrades

Wandering  Trades caused this error


sidekiq errors aren't handled by Rollabr?

We've set config.sidekiq_threshold = 3 and it used to send a Rollbar error when the sidekiq job raised an error and automatically retried more than 3 times.
Recently however, we spotted a couple of jobs that raised errors and were retried more than 3 times, but no error was logged on Rollbar.
Other errors are working fine. We're using the latest rollbar-gem (2.21.0), rails 5.2.3 and Sidekiq  5.2.7 with ruby 2.5.3

@waltjones was able to help us out, and it turned out that the specific sidekiq error was ignored in config.exception_level_filters. To fix this, we'll update our sidekiq initializer to something like
Sidekiq.configure_server do |config|
  ...
  Rollbar.configure do |config|
    config.exception_level_filters = {}
  end
  ...
end

This will ensure that all Sidekiq errors are reported.
Thanks again, Walt!


Dedupe analyzer messages

When collecting messages we include a quick check to remove any duplicates.

@selmanj: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

lint_istio
0aff202fa79c2edd08c287c5a9db8650fd652d8b
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@selmanj: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

lint_istio
d833d15217e95add06f846247f42ce5b395f63ee
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

I considered doing that initially but decided not to as it would be a more invasive change. But now that you mention it, the fact that a Message isnt comparable due to the interface{} parameters would have prevented that approach entirely.

@selmanj: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

lint_istio
d833d15217e95add06f846247f42ce5b395f63ee
link
/test lint_istio

pilot-multicluster-e2e_istio
d833d15217e95add06f846247f42ce5b395f63ee
link
/test pilot-multicluster-e2e_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest


Added an exclamation point.

1, 2, 3!

Both have comedic value.  We'll try it your way for a while :-)

I thought the same thing when reading it! :+1:

I'm a valuble member of the open source community! :wink:


fix: storage migration permissions

Description of changes

Issue #, if available

Description of how you validated changes
Checklist

[ ] PR description included
[ ] yarn test passes
[ ] Tests are changed or added
[ ] Relevant documentation is changed or added (and PR referenced)
[ ] New AWS SDK calls or CloudFormation actions have been added to relevant test and service IAM policies

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Codecov Report

Merging #8835 (a0474db) into master (c4835c4) will decrease coverage by 0.02%.
The diff coverage is 19.38%.

@@            Coverage Diff             @@
##           master    #8835      +/-   ##
==========================================
- Coverage   56.57%   56.55%   -0.03%
==========================================
  Files         837      837
  Lines       47331    47358      +27
  Branches     9489     9505      +16
==========================================
+ Hits        26778    26781       +3
- Misses      19742    19766      +24
  Partials      811      811

Impacted Files
Coverage Δ

packages/amplify-category-auth/src/index.js
16.31% <0.00%> (ø)

...rc/extensions/amplify-helpers/root-stack-status.ts
33.33% <0.00%> (ø)

...mation/service-walkthroughs/s3-user-input-state.ts
7.25% <14.63%> (-1.16%)
:arrow_down:

...cloudformation/service-walkthroughs/s3-auth-api.ts
18.75% <25.00%> (+1.10%)
:arrow_up:

...udformation/service-walkthroughs/s3-walkthrough.ts
75.08% <66.66%> (-0.17%)
:arrow_down:

...wscloudformation/utils/check-for-auth-migration.ts
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d6eb740...a0474db. Read the comment docs.


Improve documentation of benchmark setup/teardown usage

Hi, first of all thanks for this library, it's great! However, I think I'm using it wrong, because I'm spending a lot of time waiting for benchmarks with expensive setup to finish running.
The docs for Criterion::bench_function() include:

The function under test must follow the setup - bench - teardown pattern:
use self::criterion::{Bencher, Criterion};

fn routine(b: &mut Bencher) {
    // Setup (construct data, allocate memory, etc)

    b.iter(|| {
        // Code to benchmark goes here
    })

    // Teardown (free resources)
}

Criterion::default().bench_function("routine", routine);

I've been using bench_function_over_inputs() similarly, putting expensive setup outside the b.iter() call, and I've been seeing very long benchmark times (1000s of seconds to benchmark functions that take < 1 ms to run). I just assumed that Criterion thought this was necessary for statistical rigour, but then I noticed that I could significantly change how much work b.iter() was doing without affecting the running time much, which doesn't seem right.
I've just noticed that Bencher.iter_with_large_setup() exists, which I didn't spot mentioned in the getting started guide, but a quick go at using it just seems to have made things worse.
What should I be using and how? If it helps, my benchmark code is here.

Hey, thanks for trying Criterion!
I'm not entirely sure what you should use. For the most part, I think you could do your setup once before doing any benchmarking - especially the parts that access the file system - and then clone the structure or something. The way you've structured your code here, it will repeat the file-system setup 100 times for each of your benchmarks, and file-system access is always slow. Try to do your setup in-memory and avoid writing to the disk in your benchmarks if possible. Something like this:
let tmp_dir = TempDir::new("libloadorder_test_").unwrap();
let mut load_order = prepare(
	game_id,
	&tmp_dir.path(),
	plugins_count,
	active_plugins_count,
);

load_order.load().unwrap();
let plugins = load_order.plugin_names();
let plugin_refs: Vec<&str> = plugins.iter().map(AsRef::as_ref).collect();

c.bench_function_over_inputs(
	"WritableLoadOrder.set_load_order()",
	|b, &&(game_id, plugins_count, active_plugins_count)| {
		  b.iter(move || load_order.set_load_order(&plugin_refs).unwrap())
	},
	LOAD_ORDERS,
);

iter_with_large_setup is mostly for benchmarks that need some setup for each iteration - eg. when benchmarking insertion into a collection, you want to make sure that each iteration is inserting into a collection of the same size.
Yeah, I should probably update the documentation.
Hope this helps!

I've modified the code so that the filesystem setup happens out the c.bench_function_over_inputs() calls, and the benchmarks run much faster now.
I guess my main point of confusion was that I thought the function passed to b.iter() was the benchmark code, and the outer closure was the "fixture" code. I didn't realise that sample_size controls how many times the outer closure is run, I think that could be made more obvious.
Since my problem is solved, I'll close this, thanks for the clarification!


The inline script in Prototype Implementation cannot be moved down.

Description:

When trying to edit the generated inline script in Prototype implementation by pressing "Enter" at the first and last lines they cannot be moved down, it is unresponsive.

This issue needs to be fixed in 3.1.0 as well


2020-04-10 tc1580 M3SS single subject crashes with and without pre-dose negative times

Testcase tc1580 is stored on onedrive.
This test case was executed with 2 subsets of data to attempt to isolate the issue.
A single profile/subject was extracted from the initial complete dataset and executed with Actual Time (PKATPDnew) which retains a negative time post dose at  -3 hours.
Execution of this dataset crashes with an error message:
## <simpleError in value[[3L]](cond): Error in auc_lin_log(conc = new_conc, time = new_time, exflag = exflag, : Error in auc_lin_log: length of 'time' and 'conc' vectors are not equal
## For SDEID 216997173>
## no parameters generated...

The concern here is that the rule for data handling incorporating records with negative times is not being followed.
The expectation is that for profiles with negative time, the Computation Engine will generate an "error" message identifying the profile (via mct$SDEID value contained within the dataset) and indicate that "Error:  for SDEID==, the following negative times are present from <value of mct$ACTTIME>: ", use  (mct$NOMTIME, if mct$TIME=="NOMINAL").
Instead here, it's clear that the computation engine is attempting to compute an AUC with auc_lin_log routine. That's unexpected.
The same test case incorporates a separate scenario for the sample subject but having removed the negative time records prior to computation engine execution. This unexpectedly fails with the same  message:
## <simpleError in value[[3L]](cond): Error in auc_lin_log(conc = new_conc, time = new_time, exflag = exflag, : Error in auc_lin_log: length of 'time' and 'conc' vectors are not equal
## For SDEID 216997173>
## no parameters generated...

This is unexpected. There's no apparent reason for this execution to fail.
Refer to tc1580_M3SS.html document for details.

Retested with commit 97455c7 with testcase tc1580 and can be closed.


HDDS-6296. Update Netty to the latest 4.1.74.Final.

Change-Id: I88692a6327d7aa734f8e380e622a34be4d0edf75
What changes were proposed in this pull request?
Update our Netty dependency to the latest version.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-6296
How was this patch tested?
Existing unit tests/acceptance tests.

Alright, sounds like we should table it for now, working on the Ratis side before coming back to this.

Alright, sounds like we should table it for now, working on the Ratis side before coming back to this.

I've already started:
https://issues.apache.org/jira/browse/RATIS-1515
but encountered some compatibility issues (will try to post some details).

Closing for now.


Implement Sum and Product traits for fixed point numbers

This makes it so simd_horizontal_sum and simd_horizontal_product can be implemented for fixed point numbers.
f32 and f64 have these traits implemented in std, we need to implement them manually so fixed point numbers can be used instead floating point numbers

Hello, I understand that this PR can be closed, as it has been developed more in #48 ?

Yes, the linked PR contains these changes. This is just subset, so it could be reviewed more easily. If it is desirable, this can be closed in favor of #48.

I am not maintainer obviously, but its already in review for few months with no response. you can see exact same commit in the second PR, so its nicely splitted and you can clearly see this subset there. So I would close this one.
I just wanted to say that i like this change, and if you need any help I can try and help you.


Remove dependence on company for fish and bash completion in eshell

Bash and fish completion work without company, e.g. when the user uses
the minibuffer for completion.

I've removed the feature gate behind company for fish and bash-completion. It works without company and there are people who don't use company. Furthermore it seems to cause some errors, see https://discord.com/channels/406534637242810369/406554085794381833/852098110624235550

Makes sense to me. Thanks!


Test admin modal PR

Test for https://github.com/silverstripe/silverstripe-admin/pull/1631

Please don't create PRs for these - you can just look at the CI results in creative-commoners.

Ah sorry - aimed at the wrong place I meant to create PR to my personal account


nitrokey-app2: 2.3.2 -> 2.3.3

Changelog: https://github.com/Nitrokey/nitrokey-app2/releases/tag/v2.3.3
Changes: https://github.com/Nitrokey/nitrokey-app2/compare/v2.3.2...v2.3.3
Noteworthy:

changes the appearance of the Nitrokey App2 by removing the theme included

The appearance of the GUI was so far somewhat broken in nixpkgs. But with this improvement the graphical elements e.g. the symbol for each plugged-in nitrokey some buttons etc. are displayed correctly!
Like #363032 but additionally cleaning up an unused dependency.
Closes #363032

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)

Appearance is now fixed!

25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review pr 365211

x86_64-linux

:white_check_mark: 2 packages built:

nitrokey-app2
nitrokey-app2.dist

aarch64-linux

:white_check_mark: 2 packages built:

nitrokey-app2
nitrokey-app2.dist


Feature Request - search and install from a private repository

I'd like to be able to install from our local, private repository. For example, maybe go into Advanced Settings and change the repo you search to a local url, i.e. https://docker.example.com:5000/v1/search

+1. It looks awesome but makes it pretty impractical for me to use without being able to access my private repos

Private repos are part of our roadmap. Thanks!

Duplicate request. See #232.  ( https://github.com/kitematic/kitematic/issues/232 )


Use Statement and Prestatments to execute the same query with different results

Environment
server：opendistro version 1.13
client：jdbc jar maven

com.amazon.opendistroforelasticsearch.client
opendistro-sql-jdbc
<IP_ADDRESS>

query sql like this：
select
count(sql_id) as access_num,count(case when result_msg = 'QUERY SUCCESS' then 1 end) as success_num
from index_really_magneto_query_log_2021-03-30
When the query is executed in the Statement mode ,the field success_num returns normal data information;
But
When the query is executed in the PreparedStatement mode ,the field success_num returns 0 ;
 String query="select " +  	            		" count(sql_id) as access_num, " +  	            		" count(case when result_msg = 'QUERY SUCCESS' then 1 end) as success_num " +  	            		" from index_really_magneto_query_log_2021-03-29 "  	        ; 	            PreparedStatement stmt=Conn.prepareStatement(query); 	            ResultSet rs=stmt.executeQuery();  ResultSet rs=stmt.executeQuery(); 	            if(rs.next()){ 	            	System.out.println(rs.getLong("success_num")); 	            	System.out.println(rs.getLong("access_num")); 	            }
Print result like this:
0
2442
    Statement stmt = Conn.createStatement(); 	            ResultSet rs=stmt.executeQuery(query); 	            if(rs.next()){ 	            	System.out.println(rs.getLong("success_num")); 	            	System.out.println(rs.getLong("access_num")); 	            }
Print result like this：
2440
2442

@ashwinkumar12345
@keithhc2

@STTianXiang I think this is because the prepared statement was not supported by our new SQL engine. Then your query was handled by legacy which doesn't support COUNT(CASE .... Recently the prepared statement support is already merged in https://github.com/opendistro-for-elasticsearch/sql/pull/1077. It would be available in next release. Thanks!

@STTianXiang I think this is because the prepared statement was not supported by our new SQL engine. Then your query was handled by legacy which doesn't support COUNT(CASE .... Recently the prepared statement support is already merged in opendistro-for-elasticsearch/sql#1077. It would be available in next release. Thanks!

Hi，@dai-chen：
Thanks for you answer. Would you tell me  the next release plan?

@STTianXiang I think this is because the prepared statement was not supported by our new SQL engine. Then your query was handled by legacy which doesn't support COUNT(CASE .... Recently the prepared statement support is already merged in opendistro-for-elasticsearch/sql#1077. It would be available in next release. Thanks!

Hi，@dai-chen：
Thanks for you answer. Would you tell me the next release plan?

Hi @STTianXiang , it seems our most recent 1.13.2 is a minor release without latest code. You have to wait for next major ODFE release or build from our develop branch directly. Thanks!


docs: fix missing git prefix for pip install

FIX Missing 'git+' prefix for pip install

Rewords slightly to clarify difference between installing
from PyPI and GitHub

Signed-off-by: Dan Michael O. Heggø<EMAIL_ADDRESS>

@danmichaelo we use labels FIX|BETTER|... only for messages that worth to be mentioned in RELEASE NOTES. IMHO documentation fixes is not strictly needed to be listed there.
Can you also finish bullets with a dot (.)? Thanks
docs: fix missing git prefix for pip install

* Adds missing 'git+' prefix for pip install.

* Rewords ...
  ... and GitHub.

...

There you go.

@danmichaelo thanks :+1:


Fixing type hint in '_get_account'

Breaking change

Proposed change
Solved the '_get_account' function by replacing the return value with value of type 'IcloudAccount' so it matches with the function type hint.
Type of change

[ ] Dependency upgrade
[ ] Bugfix (non-breaking change which fixes an issue)
[ ] New integration (thank you!)
[ ] New feature (which adds functionality to an existing integration)
[ ] Deprecation (breaking change to happen in the future)
[ ] Breaking change (fix/feature causing existing functionality to break)
[x] Code quality improvements to existing code or addition of tests

Additional information

This PR fixes or closes issue: fixes #
This PR is related to issue:
Link to documentation pull request:

Checklist

[x] The code change is tested and works locally.
[x] Local tests pass. Your PR cannot be merged unless tests pass
[x] There is no commented out code in this PR.
[ ] I have followed the development checklist
[ ] I have followed the perfect PR recommendations
[x] The code has been formatted using Black (black --fast homeassistant tests)
[ ] Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

[ ] Documentation added/updated for www.home-assistant.io

If the code communicates with devices, web services, or third-party tools:

[x] The manifest file has all fields filled out correctly.
Updated and included derived files by running: python3 -m script.hassfest.
[ ] New or updated dependencies have been added to requirements_all.txt.
Updated by running python3 -m script.gen_requirements_all.
[ ] For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
[ ] Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

[ ] I have reviewed two other open pull requests in this repository.

Waled Mohammad Group 10
Rule 2: The issue/code smell is significant because it involves a type hint problem that can potentially cause issues when maintaining the code. The problem arises from a mismatch between the expected behaviour of the function (its return value) and the type hint provided
Rule 3: The solution is to change the return value from 'NoneType' to 'IcloudAccount', which accurately represents the function's purpose. This adjustment aligns the code with the intended behavior of the function and improves code clarity and reliability.

Hm, I'm not sure if this does not actually change the behavior of the code... returning a new instance with default values might be unexpected for the caller.


Continuous applications cleanup - process stale applications service

Context
Continuous applications was built using a feature flag. Now we’ve launched it we’re left with a lot of redundant code relating to the “old flow”. It’s now time for us to start paying back the tech debt and to eventually remove the feature flag.
The focus on this PR is process stale applications
Link to Trello card
https://trello.com/c/3xZ1ngWG/1030-catd-process-stale-applications-service

@vassyz / @avinhurry I did one more change. Do you mind to re-review, please?