chore: bumps pino version

Updated pino version to 7.11.0 in logger
Tests

npm run test
published a canary
tested canary with @walletconnect/core & @walletconnect/sign-client

Nice, thanks for updating here 👍
Maybe already on your radar, but there's also monorepo pkgs that use pino directly as pointed out in the issue: https://github.com/WalletConnect/walletconnect-monorepo/issues/1612#issuecomment-1309318045

Thanks for the heads up! Monorepo is also ready to be updated. Pending is merging this PR + publishing so I can update the packages there too

Yeah great point, makes sense to move downstream in terms of dependencies with this and do it all in one go 👌

Thanks for the heads up! Monorepo is also ready to be updated. Pending is merging this PR + publishing so I can update the packages there too

Yeah great point, makes sense to move downstream in terms of dependencies with this and do it all in one go ok_hand

Shall I go a head and merge or there's a feedback as you haven't approved it yet 🙏


Make PathCache stylus resolving a little more like stylus standalone

When running stylus outside of stylus-loader it synchronously resolves
files while evaluating. While it evaluates as it imports a file, it
adds the context (its directory path) of that file to the stylus
instance's paths array. paths is used to look up relative paths by
iterating from the end of the array to the start.
stylus-loader since we added PathCache, left paths alone. This was an
oversight that leads to relative paths not working (unless stylus can't
find it and we fall back to resolving with webpack). stylus-loader
can't modify paths like stylus does since it can potentially resolve
multiple dependencies at once. We can concat and create separate
paths copies. This change does that by appending the context variable
that for stylus resolving PathCache was otherwise throwing away.
This doesn't accurately follow stylus yet. If you had a tree of stylus
files depending on each other paths would have a layer for each
context as it goes deeper.
So this change just represents the last context and not the contexts in
between. This should hopefully cover 99% of relative path use.
@exogen @ryan-roemer @ryanisinallofus I think this should resolve what you all are doing with stylus-relative-loader. #123

@mzgoddard Thanks, I'll check it out and see if it resolves the various path cases we encountered!
Although we've since expanded how stylus-relative-loader works to also support dynamic runtime imports like Stylus, which is another feature that was important to us. Check out walmartlabs/stylus-relative-loader#3 and walmartlabs/stylus-relative-loader#11 if you're interested in the details.

@exogen Please let me know what you find out. That'd be useful in the short term.
I've spent a little time over the last two days looking over the two PRs you linked. I think I have a medium level understanding of the code. I'm going to make an issue to start trying to figure out in finer detail getting that work in here and target a release of those changes for a version 3 of stylus-loader.

Merging for stylus-loader version 2. Excited to upstream stylus-relative-loader in here.


Rust Webview JavaScript interface

Is your feature request related to a problem? Please describe.
I am developing a Web plug-in of Rust native app (Plug-in will be loaded into a Webview instance of native Rust app). My plug-in must fetch ( via GET/POST/PUT/DELETE requests) data from remote servers. Currently, my Web plug-in could not use default JavaScript fetch due to blocking by CORS errors. Therefore, I must find a way to call fetch handlers from Rust native app.
Describe the solution you'd like
A clear and concise description of what you want to happen.
I know that Android apps can expose JavaScript interface APIs to web plugins (run inside a Webview).
I would like to ask: How can Rust native apps expose JavaScript interface APIs to web plugins (run inside a Webview)" ?
Thanks

This recent blog post may be interesting for you: https://wpewebkit.org/blog/06-integrating-wpe.html
We currently use the same APIs in Wry/Tauri to power our JS<->Rust communication. Wry may be a helpful resource here too, to see how that C code may translate to Rust.


feat!: add context to transformers

This pull request is an alternative to https://github.com/spatie/laravel-data/pull/588, which I personally prefer.
Along with also allowing multiple transformers for a class, it adds a context property to the Transformer contract, which can be an arbitrary string.
This allows to transform data differently depending on the context (response, eloquent, a custom context...).
Unfortunately, this is a breaking change if using a custom Transformer implementation. I couldn't find a way to implement the feature in a backwards-compatible way.

Example

Usage:
// In a controller
return SomeData::collection($query->paginate())->transform(context: 'hybridly');
// or
return SomeData::from($data)->transform(context: 'hybridly');

App-specific stuff:
// Custom TypeScript Transformer that generates a proper type using `HasOptions`
final class OptionsTransformer extends EnumTransformer
{
    protected function toEnumValue(ReflectionEnumBackedCase $case): string
    {
        if ($case->getEnum()->implementsInterface(HasOptions::class)) {
            return json_encode($case->getValue()->toOption());
        }

        $value = $case->getBackingValue();

        return \is_string($value) ? "'{$value}'" : "{$value}";
    }
}

// Custom Laravel Data transformer for transforming the enum in options
final class OptionsTransformer implements Transformer
{
    public function transform(DataProperty $property, mixed $value, ?string $context = null): null|string|array
    {
        if (!$value instanceof BackedEnum) {
            return null;
        }

        if ($context === 'hybridly' && $value instanceof HasOptions) {
            return $value->toOption();
        }

        return $value->value;
    }
}

// Interface for my enums
interface HasOptions
{
    public function toOption(): array;
}

// Example implementation
enum PilotGrade: string implements HasOptions
{
    case CAPTAIN = 'captain';
    case FIRST_OFFICER = 'first_officer';
    case PILOT = 'pilot';

    public function toHumanReadableString(): string
    {
        return match ($this) {
            static::FIRST_OFFICER => 'First officer',
            static::CAPTAIN => 'Captain',
            static::PILOT => 'Pilot',
        };
    }

    public function toOption(): array
    {
        return [
            'value' => $this->value,
            'label' => $this->toHumanReadableString(),
        ];
    }
}

Concerns:

$context as a string might be restrictive, this could be an array or even a dedicated class
Calling transform with the same context everywhere would be repetitive, but this could be attenuated by making the BaseData class Macroable
This is a breaking change so we have to wait until v4... :(

Looks like v4's TransformationContext might help with this feature? 👀

Great to hear, not sure if we want an array for context but maybe that's really useable. Was also thinking about adding a TransformationOutput enum or such a thing with values : array, Model, response, json, ... not yet sure about the exact implementation.
As for this PR I'm gonna close it for now since it has a lot of conflicts and the issue seems resolved.


core: Add signature algorithm validation

PR Checklist
PR Structure

[x] This PR has reasonably narrow scope (if not, break it down into smaller PRs).
[x] This PR avoids mixing refactoring changes with feature changes (split into two PRs
otherwise).
[x] This PR's title starts with name of package that is most changed in the PR, ex.
paymentservice.stellar, or all or doc if the changes are broad or impact many
packages.

Thoroughness

[ ] This PR adds tests for the most critical parts of the new functionality or fixes.

What
Added signature algorithm validation.
Why
This is to avoid the security vulnerability https://www.oracle.com/security-alerts/cpuapr2022.html
We should make sure the signature is accepted only when it is signed by H256.
Known limitations
N/A

Reference Server Preview is available here:https://anchor-ref-pr204.previews.kube001.services.stellar-ops.com/SEP Server Preview is available here:https://anchor-sep-pr204.previews.kube001.services.stellar-ops.com/

Reference Server Preview is available here:https://anchor-ref-pr204.previews.kube001.services.stellar-ops.com/SEP Server Preview is available here:https://anchor-sep-pr204.previews.kube001.services.stellar-ops.com/

❗ There does not appear to be any tests for this. Can you add tests?

Great catch. Was in an unnecessary hurry and missed the tests.


Re-build and re-deploy the .mtar file

Tutorials: https://developers.sap.com/tutorials/btp-app-launchpad-service.html
I got the an error related to service plan for html5-repo when trying to deploy via 'cf deploy cpapp_1.0.0.mtar':
"Creating service "cpapp-html5-repo-host" from MTA resource "cpapp-html5-repo-host"...
Service operation failed: Controller operation failed: 404 Updating service "cpapp-html5-repo-host" failed: Not Found: Error creating service "cpapp-html5-repo-host" from offering "html5-repo-host" and plan "app-host": Service plan app-host not found."
I tried creating the service manually in BTP COCKPIT which works, but then I get this error during deployment:
"Error determining actions to execute on service "cpapp-html5-repo-host": Service described by MTA resource "cpapp-html5-repo-host" of type [html5-repo-host/app-host] does not match already existing service "cpapp-html5-repo-host" of type [html5-apps-repo/app-host] and needs to be recreated. Use command line option "--delete-services" to enable the deletion of the existing one."
Adding "--delete-services" to the command line results in the first error.
Any help would be appreciated.
/Alex

Hi Alex,
You could try to undeploy it first using:
cf undeploy cpapp --delete-service-keys --delete-services.
Also kindly check that you have the following entitlements:

if you still get the same errors please share your mta.yaml.
Best regards,
Manjunath

Hi @manjuX,
Thanks for your reply. I've tried the undeploy command which went successul.
Unfortunately the error on deploy still persists. Here is the full console output
`C:\Users\Alex\git\sap-tut\cpapp>cf deploy cpapp_1.0.0.mtar
Deploying multi-target app archive cpapp_1.0.0.mtar in org xxxxxxxtrial / space dev as xxxxx..
Uploading 1 files...
C:\Users\Alex\git\sap-tut\cpapp\cpapp_1.0.0.mtar
OK
Operation ID: d328531b-f0d8-11ec-807e-eeee0a9143f8
Deploying in org "6a9fcae7trial" and space "dev"
Detected MTA schema version: "3"
No deployed MTA detected - this is initial deployment
Detected new MTA version: "1.0.0"
Processing service "cpapp-destination"...
Creating service "cpapp-destination" from MTA resource "cpapp-destination"...
Processing service "cpapp-db"...
Creating service "cpapp-db" from MTA resource "cpapp-db"...
Processing service "cpapp-html5-repo-host"...
Creating service "cpapp-html5-repo-host" from MTA resource "cpapp-html5-repo-host"...
Service operation failed: Controller operation failed: 404 Updating service "cpapp-html5-repo-host" failed: Not Found: Error creating service "cpapp-html5-repo-host" from offering "html5-repo-host" and plan "app-host": Service plan app-host not found.
Processing service "cpapp-uaa"...
Setting service "cpapp-uaa" parameters from "xs-security.json"
Proceeding with automatic retry... (3 of 3 attempts left)
Creating service "cpapp-uaa" from MTA resource "cpapp-uaa"...
Creating service "cpapp-html5-repo-host" from MTA resource "cpapp-html5-repo-host"...
Service operation failed: Controller operation failed: 404 Updating service "cpapp-html5-repo-host" failed: Not Found: Error creating service "cpapp-html5-repo-host" from offering "html5-repo-host" and plan "app-host": Service plan app-host not found.
Proceeding with automatic retry... (2 of 3 attempts left)
Creating service "cpapp-html5-repo-host" from MTA resource "cpapp-html5-repo-host"...
Service operation failed: Controller operation failed: 404 Updating service "cpapp-html5-repo-host" failed: Not Found: Error creating service "cpapp-html5-repo-host" from offering "html5-repo-host" and plan "app-host": Service plan app-host not found.
Proceeding with automatic retry... (1 of 3 attempts left)
Creating service "cpapp-db" from MTA resource "cpapp-db"...
Creating service "cpapp-html5-repo-host" from MTA resource "cpapp-html5-repo-host"...
Service operation failed: Controller operation failed: 404 Updating service "cpapp-html5-repo-host" failed: Not Found: Error creating service "cpapp-html5-repo-host" from offering "html5-repo-host" and plan "app-host": Service plan app-host not found.
1 of 1 done
1 of 1 done
Process failed.`
I am working with a fresh trial account and the entitlements look fine:

Here is my mta.yaml file (which is basically the same as from there https://github.com/SAP-samples/cloud-cap-risk-management/tree/cap-mta-deployment) and the operation log that I was able to download.
mta.yaml.zip
Thanks,
Alexander

Hi Alexander,
looking at the logs there seem to be errors with the db creation as well: Caused by: com.sap.cloudfoundry.client.facade.CloudControllerException: Controller operation failed: 502 Updating service "cpapp-db" failed: Bad Gateway: Error creating service "cpapp-db" from offering "hana" and plan "hdi-shared": CF-ServiceBrokerRequestRejected(10001): Service broker error: Service broker hana-broker failed with: Can not create service instance 'cpapp-db': There is no database available. Ensure that you have a database available in space 'dev' within organization 'xxxxxxxxtrial'. Do you start your database before deployments?
can you checkout the logging branch from the repository as described here, and deploy the application?
Best Regards,
Manju

Hi @AlexanderSchmidt,
Thank you for your feedback. We haven't heard from you in a while, so we are closing the issue. If you still have questions, feel free to open a new issue.
Best regards,
Iwona


Numba warnings after numba update

I updated my conda packages (including numba) and now I am getting a lot of Numba warnings when running openTSNE. They seem harmless (everything still works correctly), but annoying. Here is a full output.
The keyword argument 'parallel=True' was specified but no transformation for parallel execution was possible.

To find out why, try turning on parallel diagnostics, see http://numba.pydata.org/numba-doc/latest/user/parallel.html#diagnostics for help.

File "../../../../anaconda3/lib/python3.6/site-packages/pynndescent/rp_trees.py", line 133:
@numba.njit(fastmath=True, nogil=True, parallel=True)
def euclidean_random_projection_split(data, indices, rng_state):
^

  self.func_ir.loc))
/home/localadmin/anaconda3/lib/python3.6/site-packages/pynndescent/pynndescent_.py:177: NumbaPerformanceWarning:
The keyword argument 'parallel=True' was specified but no transformation for parallel execution was possible.

To find out why, try turning on parallel diagnostics, see http://numba.pydata.org/numba-doc/latest/user/parallel.html#diagnostics for help.

File "../../../../anaconda3/lib/python3.6/site-packages/pynndescent/utils.py", line 79:
@numba.njit(parallel=True)
def rejection_sample(n_samples, pool_size, rng_state):
^

  indices = rejection_sample(n_neighbors, data.shape[0], rng_state)
/home/localadmin/anaconda3/lib/python3.6/site-packages/pynndescent/pynndescent_.py:199: NumbaPerformanceWarning:
The keyword argument 'parallel=True' was specified but no transformation for parallel execution was possible.

To find out why, try turning on parallel diagnostics, see http://numba.pydata.org/numba-doc/latest/user/parallel.html#diagnostics for help.

File "../../../../anaconda3/lib/python3.6/site-packages/pynndescent/utils.py", line 459:
@numba.njit(parallel=True)
def new_build_candidates(
^

  seed_per_row,
/home/localadmin/anaconda3/lib/python3.6/site-packages/numba/compiler.py:602: NumbaPerformanceWarning:
The keyword argument 'parallel=True' was specified but no transformation for parallel execution was possible.

To find out why, try turning on parallel diagnostics, see http://numba.pydata.org/numba-doc/latest/user/parallel.html#diagnostics for help.

File "../../../../anaconda3/lib/python3.6/site-packages/pynndescent/pynndescent_.py", line 38:
    @numba.njit(parallel=True, fastmath=True)
    def init_from_random(n_neighbors, data, query_points, heap, rng_state):
    ^

  self.func_ir.loc))
/home/localadmin/anaconda3/lib/python3.6/site-packages/numba/compiler.py:602: NumbaPerformanceWarning:
The keyword argument 'parallel=True' was specified but no transformation for parallel execution was possible.

To find out why, try turning on parallel diagnostics, see http://numba.pydata.org/numba-doc/latest/user/parallel.html#diagnostics for help.

File "../../../../anaconda3/lib/python3.6/site-packages/pynndescent/pynndescent_.py", line 49:
    @numba.njit(parallel=True, fastmath=True)
    def init_from_tree(tree, data, query_points, heap, rng_state):
    ^

  self.func_ir.loc))

Yes, I am aware of these warnings and have opened up an issue on pynndescent a while ago https://github.com/lmcinnes/pynndescent/issues/65. However, this is not something I have any influence on, and I don't know numba enough to fix the problems myself.

So it seems that this PR https://github.com/lmcinnes/pynndescent/pull/68 should have removed these  parallel=True warnings in Numba 0.44, but I am still getting them now. Is it because pynndescent version on conda does not include this PR yet?

That's probably it, yeah. The conda and PyPI versions are both 0.3.0, while the current master has version 0.3.1.

Apparently version 0.3.2 should be out on PyPI and conda since two days ago: https://github.com/lmcinnes/pynndescent/issues/72#issuecomment-529134883 -- so I wonder if this issue is resolved now. My conda packages are somehow screwed up at the computer I'm currently working on, so I couldn't update everything to try it out yet :-/

Check if these warnings went away with pynndescent 0.4. Then this could hopefully be closed too.

I think these problems were fixed a while ago, so this should have stopped occurring a long time ago. I'll keep an eye out on this, but I'm closing it. If by some chance, it hasn't been fixed yet, we can always reopen.

Also, I've just noticed that you published "The art of using t-SNE" in Nature Communications. Congrats! 🎉

Thanks! Yes indeed, it's finally out. Oh, by the way -- could you update the reference in readme?

No problem, I've updated it.


[Analytics 2.5.0] log4j files within APIM Analytics 2.5.0 pack.

Description
We recently have recently carried out vulnerability scans on APIM servers and has discovered that log4j v1.x files are still present in the latest updated APIM Analytics version 2.5.0 package.
Upon further investigation, we discovered that in other products (such as APIM 2.5.0, APIM 2.6.0, APIM Analytics 2.6.0), to mitigate the known vulnerabilities of Apache Log4j v1.x (related to Security Advisory WSO2-2022-1828) the related jars have been removed and the dependency has been replaced with Reload4j 1.2.19.
The security update has also been applied to APIM Analytics 2.5.0 (through WSO2 Carbon 4.4.X Update 2022-04-18).
However, even though the reload4j jar files have been added, the existing log4j v1.x jar files have not been removed.
As a result, these jars still remain in the latest updated (37) APIM Analytics 2.5.0 package.
Since this seems to be a defect in the security update, could you please provide a solution/fix to resolve this issue.
Best regards,
Hamool
Steps to Reproduce

Update the APIM Analytics version 2.5.0 to the latest level.
Check for log4j v1.x files within the APIM Analytics version 2.5.0.

Affected Component
Analytics
Version
2.5.0
Environment Details (with versions)
No response
Relevant Log Output
No response
Related Issues
No response
Suggested Labels
No response

Public fix is not applicable for this issue


vscode-shellcheck is awesome

It's become an indispensable part of my toolbox, and it's always one of the first things I recommend to coworkers working in shell scripts.
Just wanted to say thanks for all the work on this. :)  That's all.

I'm glad you like it :)


Task activity status

Hi
Description
Sometimes you need to pause a task, and it would be nice if you could set a status for tasks.

Actively
Pause
Disabled

And so on, it would be good to think
Also display the "Status" column in the schedule:list table
Example
use Crunz\Schedule;

$scheduler = new Schedule();
$task = $scheduler->run('command/to/execute');
$task
    ->description('Task description')
    ->in('path/to/your/command')
    ->preventOverlapping()
    ->everyThirtyMinutes()
    ->weekdays()

    ->setStatusPause() //  Set status
;

return $scheduler;

Hello, what is your use case?

Hello, sometimes you just need to pause the task for a while. Now either rename the file or remove the code in the task. It would be more convenient to simply display the status.

But changing status will also require code change, so what is a gain?

But changing status will also require code change, so what is a gain?

More convenient and beautiful.
Also display the "Status" column in the schedule:list table
use Crunz\Schedule;

/*
$scheduler = new Schedule();
$task = $scheduler->run('command/to/execute');
$task
    ->description('Task description')
    ->in('path/to/your/command')
    ->preventOverlapping()
    ->everyThirtyMinutes()
    ->weekdays();

return $scheduler;
*/

or

use Crunz\Schedule;

$scheduler = new Schedule();
$task = $scheduler->run('command/to/execute');
$task
    ->description('Task description')
    ->in('path/to/your/command')
    ->preventOverlapping()
    ->everyThirtyMinutes()
    ->weekdays()

    ->setStatusPause() //  Set status
;

return $scheduler;

I would use :)

Would you consider sponsoring (financially) this feature?


Reporter failes when a failed assertion contains html markup

Reporter fails with an error in the following situation:
var div1 = document.getElementById('div1');
var div2 = document.getElementById('div2');

eq(div1, div2);

In you compare jQuery objects eq($(div1), $(div2)); reporter writes:
expected: []
actual: []

\cc @kirovboris Seems like in this case diffs fails

ping @kirovboris

This error causes on client side, reporter mustn't receive html markup, we have to escape html in src/client/runner/api/assertions.js.

\cc @AlexanderMoskovkin

I'll research the issue soon. It works with the 15.1 version, and there were no changes on client in this mechanism. We should understand why it was working before and how it should work now

@AlexanderMoskovkin There were changes on server side, now we use HTML for templates markup. So, HTML content should be escaped to be presented as the text

It could be easily done with:
function escapeHTML(s) {
    return s.replace(/&/g, '&')
            .replace(/"/g, '"')
            .replace(/</g, '<')
            .replace(/>/g, '>');
}

It works with the 15.1, because i had made the escaping all markdown messages on the server side. It was necessary for markdown module. There were some problems with rendering html.

I'm working on this


Not maintained any more?

I've been led to believe that CloudBees are no longer maintaining this plugin as they had kindly been previously.
@Vlatombe - is it possible to get a statement that this is, in fact, the case and maybe get the README in this Repo updated to reflect that and whether there are any plans going forward?

Yes. that would be great as this plugin hasn't worked since Jenkins 2.27.   Appreciate the response on status of this plugin.

@sjcollin I'll fix the plugin for the issue with Jenkins 2.X. @damomurf Can you please let me know what is the issue you are facing ?

I think there are currently 49 issues that folks are currently facing. In particular I've had to invest significant effort in working around things related to #270 and something similar to #268. I've just had a look at the latest Jenkins 2 and noticed that support seems to be non-existent with regard to pipeline builds.

@damomurf I maintain
@damomurf what kind of support are you looking with pipeline? Any cloud plugin should work using the node keyword.

@Vlatombe Support for the MesosSingleUseSlave wrapper would be handy. I've tried it but it throws an exception.

@damomurf I've added an option to select Single Use Slave default for all the jobs. https://github.com/jenkinsci/mesos-plugin/pull/275. Will this work for you ?

Release 0.14.0 is available in update center which includes a fix for using MesosSingleUseSlave with Jenkins pipeline. https://github.com/jenkinsci/mesos-plugin/pull/277

@maselvaraj #277 is only at steps level in each stage as far as i can see, if i set a agent for the complete pipeline there is no way i found that you can specify that agent to be singe use. Would it not be beter to use the options mechanism for this:
pipeline {
    agent { label 'mesos-agent' }
    options {
        timeout(time: 30, unit: 'MINUTES')
        mesosSingleUseSlave(true)
    }
}

The options can also be set at stage level:
pipeline {
    agent none
    stages {
        stage('build') {
            agent { label: 'mesos-agent' }
            options {
                mesosSingleUseSlave(true)
            }
        }
    }
}

see: https://jenkins.io/doc/book/pipeline/syntax/#options

@damomurf, I'm the new maintainer. We've recently released 1.0 of the plugin and an experimental 2.0.


Fixing type stability issues for constructors

Fixes #64 by adding more type parameters to the constructors to make the NamedTuples concrete.

bors try

bors r+


bug with minified knockout v3.4.0

Commit: d904767bcd9aa4db90d4334a0467cb46621a03d3 [d904767]
Parents: 887e9a0822
Author: unknown<EMAIL_ADDRESS>Date: 02 September 2015 21:54:22
fix "target" to "_target" for knockout 3.3
"this._target || this.target" check works only for non-minified version of knockout v3.4.0 , because this._target is changed by minifier to short name. For v3.4.0 it's this.ia. Now there is call stack size exceeded error in Chrome, when changing observable value from code for multi select.

Better then, the calls to triggerChangeQuietly should use allBindings.value and allBindings.selectedOptions directly, this should prevent that issue

Better then, the calls to triggerChangeQuietly should use allBindings.value and allBindings.selectedOptions directly, this should prevent that issue

This problem still exist in knockpout v3.5.1, and i confirm this fix works.
Thank´s


SW-15908  - change badwords

Is good to standardise a bad word option for all forms.

Thanks @matzmu
We decided to close this PR because the change is incomplete and does not fix the underlying issue. If this change is still important to you, feel free to create a new pull request or create an issue on https://issues.shopware.com.


make "package" configurable

Either allow the package(s) to be specified as an option, or add dirs that should be ignored (like tests).

The current mechanism uses setup_tools' find: directive to bundle/publish all the packages in the root dir. That's not configurable AFAIK. From its perspective, it's okay to have multiple packages, but it would mean publishing unintended packages (like tests) to clients via pip.
The guardrail which produces an error on the GH action prevents this scenario. Now what we could do in the action itself is temporarily alter the repo dir tree, kick out the not-to-be-published packages. Then, publish. It depends if we want to blacklist or whitelist.

Apparently setup_tools is configurable for this:
https://setuptools.pypa.io/en/latest/userguide/package_discovery.html#finding-simple-packages
[options]
packages = find:

[options.packages.find]
include = pkg*
exclude = additional

Note that the default exclude list takes care of these things with automatic discovery, but not if you use manual discovery with find:.
Note that their alternative is using a "src layout" where the python src is in a directory called src

Great! That would be an easy fix, at least for just ignoring tests: *tests. There may be a regex corner case out there.
Of course, there's the pattern that one pip package should contain just one python package. So, manually listing the package name would not be bad (no find:), but would require an extra attribute for [wipac:cicd_setup_builder]. Then again, this could be a list attribute.


Since Update 2.1.20 and onwards, VRM model conflict

I'm not sure what exactly changed between versions 2.1.19 to 2.1.20, I saw you fixed the third person camera, but when using lethal vrm or better vrm mods where they both worked previously with ver 2.1.19 and I could see the character just fine, now they outright are invisible. I've included what it looks like with the third person mode.

I've tested it seperately with only toomanyemotes and either bettervrm or lethal vrm, and the issue still happens, so I know its not a mod conflict with other mods except for this :( I just want to see my 3d model emote with your mod again T^T
I will say I can still see my friends emote with it just fine and I can see them dance, but when we emote and enter third person can't see ourselves emote just whatever accessory we have on our model.
01912386-03a0-ec1e-7b42-904baba9bebe - this is the profile code that is just better vrm, too many emotes, and bepin

Reproduced this issue with my group; emote wheel shows the default Lethal Company model, but when performing the emote you will be invisible in the third-person view. Other players will see you just fine, but you will not be able to see yourself. I tried rolling back to older versions and encountered the same issue, except in the older versions our models were also invisible in the emote wheel.

Yeah that's what I thought idk if it's something that can be fixed thank you for checking it out. Maybe one day but at least we can still see each other's models with it just not our own in 3rd person. I did consider just using the first person mode if I don't want to see my invisible self.

I looked into this, but it looks like the mod renders their models on layer 23, and for various reasons, I don't render the third person emotes on that layer anymore.
I tried to see if I could change the layer of the vrm models, but the mod seems to change it back to layer 23 immediately unfortunately.
I could probably make a makeshift exception when this mod is enabled, to allow the emote camera to also view layer 23, but considering some mods use this layer to hide things that are not supposed to be seen, there may be uncommon visual issues with some mod combinations. I don't think this part will be that big of an issue, though.

Could anyone verify for me if this seems to be working on the latest version?

It works! Thank you so much 🥹💖

You're welcome!


Add support for setReserveFreeze operations to the generator

Currently this operation isn't exposed in the generator, but is a pretty common thing to do in proposals. Would be nice to have this feature enabled as well.

Mostly just to avoid any manual human operations, when possible I think it's optimal that the proposals should be generatable entirely from config, so that if any updates are made to the generator or to the params one can just update the config and regenerate without any possibility of human error when combining changes or making manual updates.

@reem , i misunderstoof before - yes sounds perfectly reasonable to me.
Feel free to create a pr in case you got time - if not we'll pick that up eventually.

@reem this is now supported (at least for v3) so closing.


Scrollable calls setState within a build phase due to extent change

11:01:05.832: I/flutter : ══╡ EXCEPTION CAUGHT BY RENDERING LIBRARY ╞═════════════════════════════════════════════════════════
11:01:05.834: I/flutter : The following assertion was thrown during performLayout():
11:01:05.837: I/flutter : Build scheduled during frame.
11:01:05.839: I/flutter : While the widget tree was being built, laid out, and painted, a new frame was scheduled to rebuild
11:01:05.841: I/flutter : the widget tree. This might be because setState() was called from a layout or paint callback. If a
11:01:05.844: I/flutter : change is needed to the widget tree, it should be applied as the tree is being built. Scheduling a
11:01:05.846: I/flutter : change for the subsequent frame instead results in an interface that lags behind by one frame. If
11:01:05.849: I/flutter : this was done to make your build dependent on a size measured at layout time, consider using a
11:01:05.852: I/flutter : LayoutBuilder, CustomSingleChildLayout, or CustomMultiChildLayout. If, on the other hand, the one
11:01:05.855: I/flutter : frame delay is the desired effect, for example because this is an animation, consider scheduling the
11:01:05.857: I/flutter : frame in a post-frame callback using SchedulerBinding.addPostFrameCallback or using an
11:01:05.860: I/flutter : AnimationController to trigger the animation.
11:01:05.895: I/flutter : When the exception was thrown, this was the stack:
11:01:05.904: I/flutter : #0      BindingBase&SchedulerBinding&GestureBinding&ServicesBinding&RendererBinding&WidgetsBinding._handleBuildScheduled.<anonymous closure> (package:flutter/src/widgets/binding.dart:199:9)
11:01:05.907: I/flutter : #2      BindingBase&SchedulerBinding&GestureBinding&ServicesBinding&RendererBinding&WidgetsBinding._handleBuildScheduled (package:flutter/src/widgets/binding.dart:197:12)
11:01:05.909: I/flutter : #3      BuildOwner.scheduleBuildFor (package:flutter/src/widgets/framework.dart:1456:23)
11:01:05.912: I/flutter : #4      BuildableElement.markNeedsBuild (package:flutter/src/widgets/framework.dart:2223:11)
11:01:05.914: I/flutter : #5      State.setState (package:flutter/src/widgets/framework.dart:840:14)
11:01:05.916: I/flutter : #6      ScrollableState._setScrollOffset (package:flutter/src/widgets/scrollable.dart:386:5)
11:01:05.919: I/flutter : #7      ScrollableState.scrollTo (package:flutter/src/widgets/scrollable.dart:431:7)
11:01:05.922: I/flutter : #8      ScrollableState.didUpdateScrollBehavior (package:flutter/src/widgets/scrollable.dart:468:5)
11:01:05.924: I/flutter : #9      ScrollableState.handleExtentsChanged (package:flutter/src/widgets/scrollable.dart:481:5)
11:01:05.927: I/flutter : #10     ScrollableViewport._buildViewport.<anonymous closure> (package:flutter/src/widgets/scrollable.dart:916:15)
11:01:05.929: I/flutter : #11     RenderViewport.performLayout (package:flutter/src/rendering/viewport.dart:289:46)
11:01:05.932: I/flutter : #12     RenderObject.layout (package:flutter/src/rendering/object.dart:1546:21)
11:01:05.934: I/flutter : #13     RenderBox&RenderObjectWithChildMixin&RenderProxyBoxMixin.performLayout (package:flutter/src/rendering/proxy_box.dart:91:13)
11:01:05.937: I/flutter : #14     RenderObject.layout (package:flutter/src/rendering/object.dart:1546:21)
11:01:05.939: I/flutter : #15     RenderBox&RenderObjectWithChildMixin&RenderProxyBoxMixin.performLayout (package:flutter/src/rendering/proxy_box.dart:91:13)
11:01:05.942: I/flutter : #16     RenderObject.layout (package:flutter/src/rendering/object.dart:1546:21)
11:01:05.945: I/flutter : #17     RenderBox&RenderObjectWithChildMixin&RenderProxyBoxMixin.performLayout (package:flutter/src/rendering/proxy_box.dart:91:13)
11:01:05.947: I/flutter : #18     RenderObject.layout (package:flutter/src/rendering/object.dart:1546:21)
11:01:05.950: I/flutter : #19     RenderConstrainedBox.performLayout (package:flutter/src/rendering/proxy_box.dart:249:13)
11:01:05.953: I/flutter : #20     RenderObject.layout (package:flutter/src/rendering/object.dart:1546:21)
11:01:05.955: I/flutter : #21     RenderPositionedBox.performLayout (package:flutter/src/rendering/shifted_box.dart:336:13)
11:01:05.958: I/flutter : #22     RenderObject.layout (package:flutter/src/rendering/object.dart:1546:21)
11:01:05.960: I/flutter : #23     RenderStack.performLayout (package:flutter/src/rendering/stack.dart:394:15)
11:01:05.963: I/flutter : #24     RenderObject.layout (package:flutter/src/rendering/object.dart:1546:21)
11:01:05.965: I/flutter : #25     RenderStack.performLayout (package:flutter/src/rendering/stack.dart:354:15)
11:01:05.968: I/flutter : #26     RenderObject.layout (package:flutter/src/rendering/object.dart:1546:21)
11:01:05.971: I/flutter : #27     RenderConstrainedOverflowBox.performLayout (package:flutter/src/rendering/shifted_box.dart:512:13)
11:01:05.973: I/flutter : #28     RenderObject.layout (package:flutter/src/rendering/object.dart:1546:21)
11:01:05.976: I/flutter : #29     RenderBox&RenderObjectWithChildMixin&RenderProxyBoxMixin.performLayout (package:flutter/src/rendering/proxy_box.dart:91:13)
11:01:05.978: I/flutter : #30     RenderObject.layout (package:flutter/src/rendering/object.dart:1546:21)
11:01:05.981: I/flutter : #31     RenderConstrainedBox.performLayout (package:flutter/src/rendering/proxy_box.dart:249:13)
11:01:05.983: I/flutter : #32     RenderObject.layout (package:flutter/src/rendering/object.dart:1546:21)
11:01:05.986: I/flutter : #33     RenderFlex.performLayout (package:flutter/src/rendering/flex.dart:421:15)
11:01:05.989: I/flutter : #34     RenderObject.layout (package:flutter/src/rendering/object.dart:1546:21)
11:01:05.991: I/flutter : #35     _RenderLayoutBuilder.performLayout (package:flutter/src/widgets/layout_builder.dart:203:13)
11:01:05.994: I/flutter : #36     RenderObject.layout (package:flutter/src/rendering/object.dart:1546:21)
11:01:05.997: I/flutter : #37     RenderStack.performLayout (package:flutter/src/rendering/stack.dart:354:15)
11:01:05.999: I/flutter : #38     RenderObject.layout (package:flutter/src/rendering/object.dart:1546:21)
11:01:06.002: I/flutter : #39     _RenderLayoutBuilder.performLayout (package:flutter/src/widgets/layout_builder.dart:203:13)
11:01:06.004: I/flutter : #40     RenderObject.layout (package:flutter/src/rendering/object.dart:1546:21)
11:01:06.007: I/flutter : #41     RenderFlex.performLayout (package:flutter/src/rendering/flex.dart:471:17)
11:01:06.009: I/flutter : #42     RenderObject._layoutWithoutResize (package:flutter/src/rendering/object.dart:1424:21)
11:01:06.012: I/flutter : #43     PipelineOwner.flushLayout (package:flutter/src/rendering/object.dart:874:18)
11:01:06.015: I/flutter : #44     BindingBase&SchedulerBinding&GestureBinding&ServicesBinding&RendererBinding.beginFrame (package:flutter/src/rendering/binding.dart:202:19)
11:01:06.018: I/flutter : #45     BindingBase&SchedulerBinding&GestureBinding&ServicesBinding&RendererBinding&WidgetsBinding.beginFrame (package:flutter/src/widgets/binding.dart:297:23)
11:01:06.021: I/flutter : #46     BindingBase&SchedulerBinding&GestureBinding&ServicesBinding&RendererBinding._handlePersistentFrameCallback (package:flutter/src/rendering/binding.dart:147:5)
11:01:06.024: I/flutter : #47     BindingBase&SchedulerBinding._invokeFrameCallback (package:flutter/src/scheduler/binding.dart:608:15)
11:01:06.027: I/flutter : #48     BindingBase&SchedulerBinding.handleBeginFrame (package:flutter/src/scheduler/binding.dart:543:9)
11:01:06.030: I/flutter : #49     _beginFrame (file:///b/build/slave/Linux_Engine/build/src/flutter/lib/ui/hooks.dart:48)

It looks like https://github.com/flutter/flutter/pull/5752 was supposed to avoid this issue but the ScrollableState.handleExtentsChanged() clearly leads to a setState() in _setScrollOffset().
cc @Hixie

Do you recall how to trigger this?

I think one way to trigger this would be to have a scroll behavior that always tried to be scrolled to half the contentExtent. When the size of the scrollable changes during layout, this would change the scroll offset synchronously during layout.

fix in https://github.com/flutter/flutter/pull/5966

Fixed by https://github.com/flutter/flutter/pull/6310

Based on the last comment sounds like we can close this?


openfl_next get/setVector of openfl.display.BitmapData implemented in terms of get/setPixels

Being that getVector() and setVector() should be faster than getPixels() and setPixels() due to the aligned 32-bit access that Vector provides, these should have a direct call to lime, like getPixels() and setPixels() does.
Currently, a copy operation happens as part of getVector() and setVector(), and they use getPixels() and setPixels() to get access to what they're copying, which means that there's no chance of the *Vector() functions ever being faster than the *Pixels() functions.

BitmapData aren't stored as vector so it's expected that get/setVector will be slower.
Should be the same in flash since the documentation mentions "Converts a Vector" and "Generates a vector".


Fix nvcc crashes in transform_stream.cu and synchronize.cu

With CUDA 12.3 nvcc does not outright crash anymore when compiling sender-receiver code.
Though, to make them compile, we still need to conditionally remove the noexcept with an IFDEF, which this PR adds.
Hence, we can activate the synchronize and the transform_stream tests when the CUDA version ist 12.3 and newer.
Fixes #5799

Performance test reportHPX PerformanceComparisonBENCHMARKFORK_JOIN_EXECUTORPARALLEL_EXECUTORSCHEDULER_EXECUTORFor Each(=)??(=)InfoPropertyBeforeAfterHPX Datetime2023-05-10T12:07:53+00:002024-03-13T22:29:13+00:00HPX Commitdcb541576898d370113946ba15fb58c20c8325b280173691c00db081f1da7f3f2192523f85fcb2d1ClusternamerostamrostamHostnamemedusa08.rostam.cct.lsu.edumedusa08.rostam.cct.lsu.eduDatetime2023-05-10T14:50:18.616050-05:002024-03-13T17:35:00.370890-05:00EnvfileCompiler/opt/apps/llvm/13.0.1/bin/clang++ 13.0.1/opt/apps/llvm/13.0.1/bin/clang++ 13.0.1ComparisonBENCHMARKNO-EXECUTORFuture Overhead - Create Thread Hierarchical - Latch+++InfoPropertyBeforeAfterHPX Datetime2023-05-10T12:07:53+00:002024-03-13T22:29:13+00:00HPX Commitdcb541576898d370113946ba15fb58c20c8325b280173691c00db081f1da7f3f2192523f85fcb2d1ClusternamerostamrostamHostnamemedusa08.rostam.cct.lsu.edumedusa08.rostam.cct.lsu.eduDatetime2023-05-10T14:52:35.047119-05:002024-03-13T17:36:48.122897-05:00EnvfileCompiler/opt/apps/llvm/13.0.1/bin/clang++ 13.0.1/opt/apps/llvm/13.0.1/bin/clang++ 13.0.1ComparisonBENCHMARKFORK_JOIN_EXECUTOR_DEFAULT_FORK_JOIN_POLICY_ALLOCATORPARALLEL_EXECUTOR_DEFAULT_PARALLEL_POLICY_ALLOCATORSCHEDULER_EXECUTOR_DEFAULT_SCHEDULER_EXECUTOR_ALLOCATORStream Benchmark - Add(=)(=)(=)Stream Benchmark - Scale+(=)(=)Stream Benchmark - Triad(=)-(=)Stream Benchmark - Copy+(=)(=)InfoPropertyBeforeAfterHPX Datetime2023-05-10T12:07:53+00:002024-03-13T22:29:13+00:00HPX Commitdcb541576898d370113946ba15fb58c20c8325b280173691c00db081f1da7f3f2192523f85fcb2d1ClusternamerostamrostamHostnamemedusa08.rostam.cct.lsu.edumedusa08.rostam.cct.lsu.eduDatetime2023-05-10T14:52:52.237641-05:002024-03-13T17:37:04.707585-05:00EnvfileCompiler/opt/apps/llvm/13.0.1/bin/clang++ 13.0.1/opt/apps/llvm/13.0.1/bin/clang++ 13.0.1Explanation of SymbolsSymbolMEANING=No performance change (confidence interval within ±1%)(=)Probably no performance change (confidence interval within ±2%)(+)/(-)Very small performance improvement/degradation (≤1%)+/-Small performance improvement/degradation (≤5%)++/--Large performance improvement/degradation (≤10%)+++/---Very large performance improvement/degradation (>10%)?Probably no change, but quite large uncertainty (confidence interval with ±5%)??Unclear result, very large uncertainty (±10%)???Something unexpected…

@G-071 could you please fix the inspect and clang-format issues reported?

@G-071 ping?

Thanks for the ping, I forgot about this PR. It should be fixed now though!


Can't disable authorization

Steps to reproduce

Just running any 4.4.x version with the NEO4J_AUTH env var set as none; e.g.
docker run -d --publish=7474:7474 --publish=7687:7687 --env=NEO4J_AUTH='none' --name neo4j neo4j:4.4.9

Expected behaviour

The container starts without authentication.

Actual behaviour

The container does not starts, and logs the following error:

none is invalid
Invalid value for NEO4J_AUTH: 'none'

Neo4j image tag being used, eg neo4j:latest, neo4j:enterprise-3.5 etc

Any 4.4.x community image appears to be affected, but I personally tested with latest, 4.4.9, 4.4.8 & 4.4.7

The output of the docker version command

Client: Docker Engine - Community
 Cloud integration: v1.0.24
 Version:           20.10.17
 API version:       1.41
 Go version:        go1.17.11
 Git commit:        100c701
 Built:             Mon Jun  6 23:03:17 2022
 OS/Arch:           linux/amd64
 Context:           default
 Experimental:      true

Server: Docker Desktop
 Engine:
  Version:          20.10.17
  API version:      1.41 (minimum version 1.12)
  Go version:       go1.17.11
  Git commit:       a89b842
  Built:            Mon Jun  6 23:01:23 2022
  OS/Arch:          linux/amd64
  Experimental:     false
 containerd:
  Version:          1.6.6
  GitCommit:        10c12954828e7c7c9b6e0ea9b0c02b01407d3ae1
 runc:
  Version:          1.1.2
  GitCommit:        v1.1.2-0-ga916309
 docker-init:
  Version:          0.19.0
  GitCommit:        de40ad0

Operating system: (for example Windows 95/Ubuntu 16.04)

Ubuntu 20.04 on WSL 2 on Windows 10

Maybe this is related to the change of the base docker image?
PS: Also, the 4.4.9 image is actually running the 4.4.8 version of Neo4j

When I pasted your command into a terminal it added some weird extra characters:
docker run -it --rm \
--publish=7474:7474 \
--publish=7687:7687 \
--env=NEO4J_AUTH='none<200b>' neo4j:4.4.8

and gave the same error message you reported. The extra characters didn't show up in a text editor.
When I re-wrote the 'none' it worked as expected. You can even set it as --env=NEO4J_AUTH=none to avoid the single quotes.
I think this might be some weird whitespace or character encoding that's crept into your code and is causing problems (maybe through copy and pasting from different sources?).  If you just re-type the --env=NEO4J_AUTH=none by hand it should work.
Also thanks for reporting 4.4.9 community being the wrong version. It looks like I made a typo in the release, I've submitted a PR to docker to fix it.


Tuwat has problems connection to alertmanager

Jan 29 07:48:15 tuwat docker-compose[3537615]: tuwat  | 2024-01-29T07:48:15.438+0100        DPANIC        alertmanager/connector.go:88        Cannot parse: Unknown state        {"state": "active", "severity": "email"}
Jan 29 07:48:15 tuwat docker-compose[3537615]: tuwat  | github.com/synyx/tuwat/pkg/connectors/alertmanager.(*Connector).Collect
Jan 29 07:48:15 tuwat docker-compose[3537615]: tuwat  |         /home/runner/work/tuwat/tuwat/pkg/connectors/alertmanager/connector.go:88
Jan 29 07:48:15 tuwat docker-compose[3537615]: tuwat  | github.com/synyx/tuwat/pkg/aggregation.(*Aggregator).collect.func1
Jan 29 07:48:15 tuwat docker-compose[3537615]: tuwat  |         /home/runner/work/tuwat/tuwat/pkg/aggregation/aggregator.go:194
Jan 29 07:48:15 tuwat docker-compose[3537615]: tuwat  | panic: Cannot parse: Unknown state
Jan 29 07:48:15 tuwat docker-compose[3537615]: tuwat  |
Jan 29 07:48:15 tuwat docker-compose[3537615]: tuwat  | goroutine 24 [running]:
Jan 29 07:48:15 tuwat docker-compose[3537615]: tuwat  | go.uber.org/zap/zapcore.CheckWriteAction.OnWrite(0x2?, 0x2?, {0x0?, 0x0?, 0xc0001e0720?})
Jan 29 07:48:15 tuwat docker-compose[3537615]: tuwat  |         /home/runner/go/pkg/mod/go.uber.org/zap@v1.26.0/zapcore/entry.go:196 +0x54
Jan 29 07:48:15 tuwat docker-compose[3537615]: tuwat  | go.uber.org/zap/zapcore.(*CheckedEntry).Write(0xc0001bec30, {0xc000216c80, 0x2, 0x2})
Jan 29 07:48:15 tuwat docker-compose[3537615]: tuwat  |         /home/runner/go/pkg/mod/go.uber.org/zap@v1.26.0/zapcore/entry.go:262 +0x3ec
Jan 29 07:48:15 tuwat docker-compose[3537615]: tuwat  | go.uber.org/zap.(*Logger).DPanic(0xc00019b280?, {0xbda1a6?, 0xc0001fa620?}, {0xc000216c80, 0x2, 0x2})
Jan 29 07:48:15 tuwat docker-compose[3537615]: tuwat  |         /home/runner/go/pkg/mod/go.uber.org/zap@v1.26.0/logger.go:274 +0x51
Jan 29 07:48:15 tuwat docker-compose[3537615]: tuwat  | github.com/uptrace/opentelemetry-go-extra/otelzap.LoggerWithCtx.DPanic({{0xcecfa0?, 0xc0001fa620?}, 0xc00019b280?}, {0xbda1a6, 0x1b}, {0xc000216c80?, 0xace8c0?, 0xc0002144e0?})
Jan 29 07:48:15 tuwat docker-compose[3537615]: tuwat  |         /home/runner/go/pkg/mod/github.com/uptrace/opentelemetry-go-extra/otelzap@v0.2.3/otelzap.go:302 +0x8c
Jan 29 07:48:15 tuwat docker-compose[3537615]: tuwat  | github.com/synyx/tuwat/pkg/connectors/alertmanager.(*Connector).Collect(0xc0001bc1c0, {0xcecfa0, 0xc0001fa620})
Jan 29 07:48:15 tuwat docker-compose[3537615]: tuwat  |         /home/runner/work/tuwat/tuwat/pkg/connectors/alertmanager/connector.go:88 +0x7ca
Jan 29 07:48:15 tuwat docker-compose[3537615]: tuwat  | github.com/synyx/tuwat/pkg/aggregation.(*Aggregator).collect.func1({0xceb400, 0xc0001bc1c0})
Jan 29 07:48:15 tuwat docker-compose[3537615]: tuwat  |         /home/runner/work/tuwat/tuwat/pkg/aggregation/aggregator.go:194 +0x90
Jan 29 07:48:15 tuwat docker-compose[3537615]: tuwat  | created by github.com/synyx/tuwat/pkg/aggregation.(*Aggregator).collect in goroutine 23
Jan 29 07:48:15 tuwat docker-compose[3537615]: tuwat  |         /home/runner/work/tuwat/tuwat/pkg/aggregation/aggregator.go:191 +0x265
Jan 29 07:48:16 tuwat docker-compose[3537615]: tuwat exited with code 2

Cannot parse: Unknown state        {"state": "active", "severity": "email"}
seemed to work with 1.4 previously

In non-development deployments this will not panic.  Use -environment prod when deploying a production environment.


fix: add permission check and reject call

If permission is not granted. There was no unified way to catch this and show a fallback UI.
Changes already exists for android. Needed this to be implemented for iOS and webview.
Now you can do
await CameraPreview.start({
      ...
    }).catch(({ message }: { message: string }) => {
      if (message === 'permission failed') {
        // Show fallback ui or do something.
      }
    });

Hey, @arielhernandezmusa I can see this fix is merged to master but still, I'm facing this issue in iOS.
I'm using v1.2.1.

Hey, @arielhernandezmusa @damngamerz I can see this fix is merged to master but still, I'm facing this issue in iOS.
I'm using v1.2.1.

I used 2.0.0-beta.0 versions but still, it is going inside then() block even if permission is denied.


Fix macro expansion diagnostic for multi-binding variable declarations in MacroSystem

When there are no macro attributes attached to the visited VariableDeclSyntax node, proceed without performing any additional checks or transformations.

Addressed the erroneous triggering of MacroApplicationError.accessorMacroOnVariableWithMultipleBindings diagnostic for nested multi-binding variable declarations.
Added corresponding tests to validate the fix.
Introduce fileprivate NoOpMemberMacro, extracted from testCommentAroundeAttachedMacro and used in 2 new tests.

Fixes #2133
rdar://114836887

@swift-ci Please test

Would you mind also creating a second PR that targets the package-release/509 branch? That way we can get this fix into the swift-syntax 509.0.0 release.

Would you mind also creating a second PR that targets the package-release/509 branch? That way we can get this fix into the swift-syntax 509.0.0 release.

Done, see #2141.

It looks like your changes are not formatted using swift-format. Could you run format.py to format them? Both in this PR and in https://github.com/apple/swift-syntax/pull/2141?

@swift-ci Please test

It looks like your changes are not formatted using swift-format. Could you run format.py to format them? Both in this PR and in #2141?

I reformatted with format.py and amended both this PR and #2141.

Thank you!

@swift-ci Please test


Problems with using gdb debugger on MAC

Opened from comment in report https://github.com/microsoft/vscode-cmake-tools/issues/884.
Zrealshadow commented 3 hours ago
I still face this problem in MacOS Catalina 10.15.4
And the cmake-tool verison is 1.6.0
When i try to debug,
the log is:
[build] Starting build
[proc] Executing command: /snap/cmake/current/bin/cmake --build /home/hristo/Projects/GitHub/GunBox/GunBox/GunBox/build --config Debug --target GunBox_Game -- -j 10
[build] ninja: no work to do.
[build] Build finished with exit code 0
[debugger] Unable to automatically determine debugger corresponding to compiler: /usr/local/bin/g++-8
[main] Failed to generate debugger configuration
My cmake tool setting:
"C_Cpp.default.configurationProvider": "ms-vscode.cmake-tools",
"cmake.configureOnOpen":true,
"cmake.debugConfig": {
    "stopAtEntry": false,
    "MIMode": "gdb",
    "miDebuggerPath": "/usr/local/bin/gdb",
}

Any solution to this problem ?

This is not a CMake Tools bug. We recommend that you open a report in the VSCode repository on GitHub: https://github.com/microsoft/vscode/issues.

Appologies, that text was meant for closing a different report, not this one.

Is there any workaround for this at the moment?

I am not sure it would work, but you can try to create an environment where lldb or lldb-mi would not be found in the path (hack the path environment variable). And also don't define miDebuggerPath (not an intuitive move, but I'm hoping it will go through a different code path that will enable you in the end to use gdb on mac).
We'll have a fix for this in 1.7 release and as soon as the fix is in I'll point you to a vsix to test (and unblock you) even earlier.

CMake Tools 1.7.0 was released today and it contains a fix for this issue. Upgrade the extension in VSCode and let us know if you encounter any other problems.


[DRAFT] Opentitantool voyager

This PR adds support to the Voyager board by adding a ftdi transport to opentitantool.
The first commit is just an autogenerate update of the crate index.
Note: Voyager is a simple board lowRISC and NewAE designed to demonstrate the OpenTitan Earl Grey chip at conferences and other events.

Curious... What is the Voyager board? How is it associated with this project?

Sorry for letting that unexplained. I updated the description.


Shopping List exercise: Replace Utils.feedback with TestedCell

Todos

[x] add tested_cell as dependencies
[x] replace all feedbacks with TestedCell
[x] add solution for each TestedCell
[x] remove all assertions in feedback.ex
[x] remove all solution in  solutions.ex

Your hard work replacing Utils with TestedCell is appreciated!


Validation issue with<PHONE_NUMBER>0 (US)

Please read the "guidelines for contributing" (linked above) and fill in the template below.
Country/region affected (e.g., "US"): US
Example number(s) affected ("+1<PHONE_NUMBER>"): +1<PHONE_NUMBER>
The phone number range(s) to which the issue applies ("+1 555 555-XXXX"): +1 564 XXX-XXXX
The type of the number(s) ("fixed-line", "mobile", "short code", etc.):  All
The cost, if applicable ("toll-free", "premium rate", "shared cost"):  All
Supporting evidence (for example, national numbering plan, announcement from mobile carrier, news article): IMPORTANT - anything posted here is made public. Read the guidelines first!
https://en.wikipedia.org/wiki/Area_code_564
https://www.verizonwireless.com/support/area-code-overlay-360-faqs/
link to demo

Thank you for taking the time to improve libphonenumber!
This issue is a duplicate of #1875 . Closing this issue.


Missing UpdateState FabricCall implementation

Was there some sort of nuance prohibiting one from implementing the "UpdateState" namespace in FabricCall()? Or is just a matter of duplicating the "CreateState" implementation for this operation since it ultimately needs to call the same PutState method for the update operation?

No nuance; just not quite got to all the features we want to implement yet ;-)

Ok cool ... will get a PR up for this.

I think this is done now


Replace deprecated<EMAIL_ADDRESS>with URLSearchParams in Examples

ran npx create-sst@latest --template=examples/api-sst-auth-google
Got this error
 WARN  deprecated<EMAIL_ADDRESS>The querystring API is considered Legacy. new code should use the URLSearchParams API instead.

Hmm we'll update all the auth examples in the near future. So this should get fixed then.

We are transition this repo to https://github.com/sst/v2 and are closing this issue for now. If it is still relevant please reopen it there - sorry for the trouble


Using functions in effects [Draft one]

Explaining how and why useCallback is used.

Is it even alright if I want to contribute to docs?

Hi! Appreciate the effort but I'm planning to do this slightly differently.


Topology change stops manually registered processes on another nodes

Hello!
I am using Swarm 3.0.5 with libcluster. Imagine, I have two nodes starting up.
On every node startup same procedure is invoked:

Swarm.whereis_name to see if name is registered
if not, start GenServer using via tuple
try to register with Swarm.register_name/2

NodeA starts up and follows procedure and registers new process
NodeB follows same procedure, but as soon as Swarm application starts on the NodeB, before even proceeding to my custom logic, on NodeA I get the following in debug log level:

topology change (nodeup....)
removing registration for XXXX, nodeA is down

even though nodeA is up and after that I can run Swarm.registered/0 and see process registered on NodeB.
Any thoughts about this behavior?
Thanks!

Definitely a bug if still happening. Have you tried recent releases? Is this still an issue?

I think, this was mis-configuration issue on my side. Thanks for following it up.


Include README content in book

This is brittle (uses line numbers) but I think better than
copying and pasting.

Phew, we would need to remember this whenever the readme changes.
Could we have a simple build script that excludes stuff without relying on line numbers?
Also imo the badges wouldn't really hurt in the book, any specific reason why you removed them?

Could cargo-sync-readme be used instead?


add missing Docker copyright

The package originates from the seccomp implementation in
github.com/moby/moby.  Add the copyright to properly
attribute the code's origin.
Signed-off-by: Valentin Rothberg<EMAIL_ADDRESS>@rhatdan PTAL

If we are going to add copyright notices to each individual file, please consider adding license info into each file as well.  If you don't want to clutter each file with the full license text you can consider using the SPDX markings.

https://spdx.org

Done. @pcmoore @rhatdan PTAL


[index] Fix default value for listening to unit changes

Was preventing index from being populated by default.

@swift-ci please test


Remove version: eibol.FFmpegBatchAVConverter version 2.8.1

[Automated] It returns code over 400 in all urls
Microsoft Reviewers: Open in CodeFlow

URL: https://sourceforge.net/projects/ffmpeg-batch/files/FFBatch_AV_Converter_2.8.1_64bit.exe/download
Status Code: 200
(Automated message - build 897)

Close with reason: Package still available.;


Warning not shown for websites with different tld

Noticed that the warning is not shown for kayak.co.uk but when checking opentable.com it does show. Even though they are both in the same group (booking).
Looks like the issue is related to the tld, for example if I go to www.opentable.com it works however www.opentable.co.uk it doesn't.

Yes this is on purpose.. companies are identified with their full domain name.
Because there are many cases where companies share same name but have different tlds.. in that case we don't want to give false alarms.
But for the case you're concerned about, we can just add more records for the same company but with its different tlds.

"Because there are many cases where companies share same name but have different tlds.. in that case we don't want to give false alarms." that should be illegal :) I've not seen a company allow another company to use their name just under a different tld. However, I see your point :) i can think of is Aldi, where Aldi in europe is on boycott but Aldi in UK is not IIRC.


Remote Desktop Protocol Basic Integration

Integration of a toggle to enable RDP on the client and forward connections on a special hostname (<IP_ADDRESS>) to the client.
This simply for now activates the default administrator account made by Windows and allows you to join it without any password (registry change for that as well).
To test it out:

Toggle so RDP connections are on (under Surveillance)
Start Proxifier or similar
Start the Reverse Proxy (on any port)
Add the reverse proxy to Proxifier
Add a rule for mstsc.exe (Remote Desktop Connections client)
Open up mstsc, put in <IP_ADDRESS> as host.
When asked for username, enter in "administrator" and no password.
Should be working.

More can be added for example a proper toggle with more packets and a nice form to allow users to add, remove, or edit user accounts on the client's machine.
Custom hostname could also be quite easily integrated or a list of appropriate hostnames (rewriting handler or similar for reverse proxy client?)
Food for thought, anyway :+1:

So... I should get a move on with a real manager...

this will only work English systems, because non-english systems have another administrator name.

@Vigorian Indeed. Certainly a few problems there.
I wonder if I can enumerate the results from net users and get the inactive administrator account.
It should be the first username when entering the 'net users' command


Instagram

I need same functionality for instagram

Hello! Unfortunately Instagram does not allow share url (or something else) through the web version. Also API has no endpoints to get share counters for specific link. So in current time it is impossible.


SmartyPants-Unicode handling of quotes, dashes, and ellipses

John Gruber's original Markdown has often been used with a long-standing hack called SmartyPants to improve typographic consistency on quotes, dashes, and ellipses. Python's Markdown package also implements it here.
A variant of this, that converts ASCII quotes, dashes, and ellipses to their appropriate Unicode equivalents, could be helpful in markdownfmt. Instead of converting to HTML entities, it would convert to Unicode, and then the Markdown doc would be consistent (including on GitHub, which does not by default do smarty-style conversion).
This is just another feature to note and discuss/consider. Inconsistent typographic usage is yet another pain point I've seen with large-scale collaborative Markdown.
It could also be implemented as a separate tool, perhaps. Gruber notes some (rare) algorithmic shortcomings like
'Twas the night...  -> ‘Twas the night...

But it's worth remembering authors can avoid that by using the correct oriented quotes in the original:
’Twas the night...

Hi @jlevy,
Thanks for the issue. This is a valid point for discussion.
I should first say that I'm aware of the smarty-pants option that blackfriday offers, but so far, I choose to ignore it. I already think markdown is way too complicated, and I want to make it as simple as possible.
So I currently use plain ASCII quotes everywhere and have very little desire in them to become something else.

This is just another feature to note and discuss/consider.

I'm not dismissing it completely and happy to discuss it, but realistically, I think it would have to be another project (possibly a fork) that takes this on. I think this is an interesting idea, and a tool like this has opportunities.
I just wanted to acknowledge this issue, and I'm open with it staying open, but I don't plan to spend much time on this. There are other things that are occupying my budget for time and attention for now.
Thanks!

Hi,
I agree with @jlevy, this is a much needed feature. Basically, people using markdownfmt are looking for a markdown-tidy tool to keep their markdown source files clean — not only for aesthetic reasons, but mostly to avoid diffing nightmares and problems with Git (tidy sources make it easier to view what really changed in a commit).
I was already looking into trying to implement this feature, but as far as I've understood blackfriday's smartypants is for html rendering only.
As @jlevy pointed out, it would be nice to have UTF-8 Unicode chars, instead of HTML entities.
Any tips on how I could try to implement this? (I'm fresh in Go lang)
Thanks

people using markdownfmt are looking for a markdown-tidy tool to keep their markdown source files clean

I've touched on that point in https://github.com/shurcooL/markdownfmt/issues/34#issuecomment-269025427, so I won't repeat that here.
I'm still not convinced that this is a great thing.
I haven't looked at any of the implementation matters here, but I suspect it might be tricky and probably not very clean.
At this time, my recommendation would be to experiment with a prototype and consider it going into a fork or separate tool. If the prototype works well, I would consider pulling it it, but I don't expect that at this time.
At this stage of this project, I'm not looking to grow the feature set of markdownfmt, instead, I want to keep it as simple as possible while still being viable to use. And in the last few years of using Markdown, I have had very little desire to have non-ascii quotes.

Makes sense. I guess that the issue really should be opened on GitHub, asking for a markdown previewer that implements smart quotes and punctuation — so users could stick to a strict Ascii markdown source, and let converters/previewers handle it.
But for some reasons GitHub's markdown html renderer/previewer doesn't use smartypants — and this has some impact on users expectations, because having to use Alt codes to get an em-dash (even here, as I type this comment) is quite tyring.
Anyhow, it seems that all markdown cleanup tools agree that ascii only characters (or html entities as a last restort) are the only sound approach — of course, the latter make a document quite unreadable.
A solution could be writing some script to filter the output of markdownfmt — and since markdownfmt enforce an Ascii standard on quotes, dashes, etc., it would quite easy. A single batch/shell script cold handle invoking markdownfmt and pipe it to this script before rewriting the source file.
I guess that would be the simple approach, and coul be created in any language.
Thanks again (and Season Greetings)
Tristano


Fix copy/paste error

Comment and Property refer to wrong example

@MatthewSteeples : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Hey @MatthewSteeples - Thank you so much for catching this! We really appreciate your help! We just had a big move of sql-database doc files, and some of the names have changed. Would it be possible for you to submit the same changes in the new link so that we can avoid the merge conflict? https://docs.microsoft.com/en-us/azure/azure-sql/database/connectivity-settings
Thanks!
Van

Done - #55989

Closing this one as a new PR has been submitted to avoid merge conflicts.
#please-close


fix(extras.treesitter-context): map toggle in config instead of opts

Description
Previously, treesitter-context was loaded on VeryLazy and its toggle map in opt, which also required it. Now, mapping happens in config, after treesitter-context is setup (also how toggle is handled in other extras, eg for render-markdown). Additionally, load on LazyFile instead.
Checklist

[x] I've read the CONTRIBUTING guidelines.

I don't understand this change. Why does it matter if it was required in opts? opts are passed into setup either way and whatever require happens after the plugin is loaded, no? Just asking out of pure curiosity to understand better in case I'm misunderstanding something.

You're right that there's no functional difference with respect to whether the mapping happens in opts or setup. I didn't consider that because opts is a function, it wouldn't get called until the plugin is configured. However, IMHO this change makes it easier to understand exactly when exactly the toggle is mapped - it's clear that this happens when the plugin is setup, as opposed to when the spec is parsed (as I initially thought might happen). In that sense I guess I mislabeled this as a fix when it could have been more accurately considered a refactor. This is also very similar to how render-markdown is configured.
The other change here is that I changed the event back to LazyFile, from #4059 when I changed the event it to VeryLazy. I've thought about this some more and IMO it didn't make sense to load the plugin earlier just so that the toggle is available, especially when the toggle won't actually change anything until a file is opened.

Moving the Snacks.toggle mapping into config means that if the user for whatever reason wants to configure the plugin via the config function, he will have to redefine the Snacks.toggle mapping himself again. Whereas if the mapping is in opts and the user still does
config = function(_, opts)
  require("treesitter-context").setup(opts)
  -- whatever else he wants here
end

the Snacks.toggle mapping will remain. In my personal opinion I believe that config should generally be avoided in Neovim distros and leave it as a last measure to the user to change if he knows what he's doing. render-markdown has also the same "disadvantage" in my opinion, but it's out of scope with regards to this PR.

That's a very good point that I didn't consider. I'll remove the changes in opts and config, and keep only the change to the event.

Please do keep in mind that I'm just a regular user like you (and not an experienced programmer) and everything I say is just a suggestion from a user's perspective. But in my eyes, in the time I've been using LazyVim, is that config is used mostly to define specific behavior that doesn't have to do with user's settings really (like treesitter having to require("nvim-treesitter.configs").setup(opts) or the recent changes you did in the Extra blink.cmp with the wrappers or something else). And although Snacks.toggle mappings are not explicitly user settings, it would really be a hassle having to redefine them again.
I really hope I didn't come off as obnoxious and didn't offend you (I apologize if I gave any such vibes) as I myself explicitly use opts myself and it wouldn't matter to me, I just tried to think from a user's perspective and in my personal experience with LazyVim (which of course I certainly may be misunderstanding some things due to my lack of knowledge).

You didn’t come off as obnoxious at all, and I really appreciate your feedback and suggestions!


Fix width of open sidebar on mobile

The mobile width was too wide, making it hard to click outside of it with your thumb. Also, the Filament Brand component in the Sidebar's header had a wide clickable area, causing issues when trying to tap outside the sidebar near the top to go back to the dashboard on mobile. Users would accidentally end up on the Laravel Welcome page (or the filament home_url). So, I made the clickable area match the text width of the Filament Brand Component.
Old:

New:

Unfortunately we can't do the width change. I know it's just swapping Tailwind classes and technically not a breaking change, but there's no way I'm spending the next 2 months telling people to recompile their Tailwind custom themes because their sidebars are broken 😭 Painful
The other change seems good though.

Unfortunately we can't do the width change. I know it's just swapping Tailwind classes and technically not a breaking change, but there's no way I'm spending the next 2 months telling people to recompile their Tailwind custom themes because their sidebars are broken 😭 Painful
The other change seems good though.

Wait so which one can we do? Because the width of the whole sidebar when open on mobile was changed by only adjusting max-w-[20em] to max-w-[16rem]. I'm pretty sure 20em isn't a thing either.

Apart from the breaking change, I think the new sidebar would look too narrow on mobile.

I mean I guess I was just trying to add a little more space so I could click outside of it on my phone. If it is a breaking change or the width is too narrow, all good!

@andrewdwallo both max width classes exist as Tailwind arbitrary classes, thats not the problem. The problem is that people who want to access the new class must recompile Tailwind, which will cause problems for those with custom themes who choose not to compile.
The fix for the brand not overflowing the sidebar is good.

Okay sounds good, whatever is fine with me.

Thanks for the info as well. I will keep that in mind.

Since it is a breaking change do you want me to just remove the sidebar width part and keep the adjustment to the clickable area of the header where the brand is? The width seems similar to what Twitter currently has compared to Filament's Website on mobile so maybe that would be best?...

Yes please

Thanks


 You might be able to make a re-usable component we can use in the /author view for updating profiles. If not no biggie, but keep that in mind.

@KarimBaaba  It looks like the backend is already done for this. Should be able to hit POST /author/profile and it will update their info.


Support custom directives

Description
Though there are some open questions/discussions about the requirement for #843 , here are some drafted changes as a proof of concept.
At a high level, there will be a new setting customDirective to allow printing information of custom directives. The setting accepts an object mapping between the directive name and a descriptor function. Users will define the setting in the plugin config file (not currently supported by plugin cli). Once the plugin CLI runs, the flow will be as follows:

Validate configuration and account for "skip doc directives"
Once schema root types are fetched, collect the defined directive types for each configured custom directive. The collected data will then be passed to the Printer object during initialization.
In Printer object, add new function to print section "type directives". For each schema type, it will detect any matching custom directives declared and print information about the directive (name, link, description).
In Printer object, update function to print section "type metadata". For each schema type, it will detect  any matching custom directives declared on its fields/arguments and print information about the directive (name, description).

Some testings are done by updating the existing "group by" documentation. Made some adjustments in earthly build-examples to run the plugin cli command with additional argument to identify the plugin instance.
Checklist

[x] My changes follow the contributing guidelines of this project.
[x] I have performed a self-review of my code.
[x] I have made corresponding changes to the documentation.
[x] I have added tests that prove my fix is effective or that my changes work.
[x] New and existing unit tests pass locally with my changes.

@ljiang-ti - you can ignore the failure on Mutation Test / Mutation tests package utils. This is just a threshold on the quality of the unit tests, but not enforced. Also, there's an issue with Stryker dashboard and the reports are not available (see #845).

Big thanks @ljiang-ti
The PR seems pretty good now. I'll do some testing, especially in regards to the discussion on #843, over the weekend before approving and merging.
You can expect it to be released next week.

Reviewing the usage of customDirective, I think we can improve the of-the-shelf helpers by:

providing a getDirectiveArgsMap instead of getDirectiveArgValue. The function would return the full map of the directive args with associated values. Thus, we can be a bit lazier on the parsing, and also it gives more flexibility as one does not have to call it for every usage or even build a custom one.

providing a generic descriptor function like descriptor = (directiveType, constDirectiveType, descriptionTemplate)  that would allow one to quickly declare custom directive handling, eg
plugins: [
  [
    "@graphql-markdown/docusaurus",
    {
      // ... other options
      customDirective: {
        auth: {
          descriptor: descriptor(directiveType, constDirectiveType, "This requires the current user to be in ${requires} role.)",
        },
        // ... other custom directive options
      },
    },
  ],
],

A quick dummy demo in this Gist: https://gist.github.com/edno/ab43356aa75457e7767845eaf7045a7a

@ljiang-ti - if this make sense to you then I can push a commit into this PR. There's no reason for you to get all the burden of implementing my ideas.

For rendering the directive, I feel a bit confuse by not seeing arg values used by it.

In this case, it is hard to understand why the description states a value 3.

In this case, it is hard to understand why the description states an ADMIN role

A possible option can be something like:
UpdateGrade
No description
UpdateGrade(
  input: String
): String

Directives
auth(role=ADMIN) ●  auth

This requires the current user to be in ADMIN role.

What do you think?

Thank you for the detailed review and feedbacks!
Regarding https://github.com/graphql-markdown/graphql-markdown/pull/844#issuecomment-1528755285, agree that displaying how the directive is declared will be informative. Think there would be couple cases to consider to get the argument values:

for optional argument, when it's not declared and a default value is set. Will get the value through both declared directive node ConstDirectiveNode and defined directive type GraphQLDirective.
for argument of type input object and list, it might complicate the display

That leads to https://github.com/graphql-markdown/graphql-markdown/pull/844#issuecomment-1528745898, I like the idea of simplifying the code and your demo solution looks awesome. To account for the 2 cases mentioned above for variations of the arguments, thought that might be handled in getDirectiveArgsMap to account for cases for: declared value, default value, and when argument is of list or of input type. Given the map the function returns, users can then locate the path to the field in the description template. The current getDirectiveArgValue is a naive implementation to get argument values of type scalar or enum. Looks like the gist is a great start, please feel free to update this PR with what you have. I would be curious to see how to implement getDirectiveArgsMap.

for optional argument, when it's not declared and a default value is set. Will get the value through both declared directive node ConstDirectiveNode and defined directive type GraphQLDirective.
:+1:

for argument of type input object and list, it might complicate the display
:thinking: You have a point here. Lists being less of an issue is they only contains scalar or enum. But, input and object will definitely be tricky.

I think we should stick to your current implementation for now, and refine the rendering later.

@ljiang-ti
I did some refactoring of the code, and introduced a generic descriptor called directiveDescriptor() that consumed a mapper of directive args/values getTypeDirectiveArgValue() (a tweaked version of the graphql-js function  getDirectiveValues).
After a lot of back and forth, I finally decided to keep the option as per your PR, ie customDirective at top level plugin configuration.

@ljiang-ti - Unless you want to revisit some points, I plan to merge this PR and publish a release today 🚀

@edno - Thank you for the updates! It is looking great. This refactor is a cleaner solution to provide user-facing config APIs ❤

@ljiang-ti - Release in 1.18.0.
Thank you a lot for this great contribution :pray: :heart:


timeout from 5 mins to 30 sec

https://github.com/rancher/rancher/issues/9451
@ibuildthecloud

LGTM


Remove Content Type from Http Body

@DanSimon  @benblack86  @aliyakamercan  @amotamed  @jlbelmonte
Second stab at https://github.com/tumblr/colossus/issues/545
So what we'd like to be able to do is set the content-type on the HttpResponse without having to bother the internal HttpBody. I don't see an inherent reason why the content-type has to be part of HttpBody anyway; after all, the only substantial place it's used is in the encode() method that writes to the DynamicOutBuffer, and the body itself is just a byte array. If we add the content-type Header properly, HttpResponseHead.encode() will take care of it just the same.
The only issue I see is potential duplicate headers since HttpHeaders is just a wrapper around a linked list, but I think that should still be handled in HttpHeaders alone. In fact I'm thinking about going a bit further and making HttpHeaders wrap a HashMap[String, HttpHeader] instead.
Discuss.

Codecov Report

Merging #569 into develop will increase coverage by 0.09%.
The diff coverage is 83.33%.

@@             Coverage Diff             @@
##           develop     #569      +/-   ##
===========================================
+ Coverage    84.75%   84.85%   +0.09%
===========================================
  Files           98       98
  Lines         4422     4411      -11
  Branches       349      339      -10
===========================================
- Hits          3748     3743       -5
+ Misses         674      668       -6

Impacted Files
Coverage Δ

...rc/main/scala/colossus/service/ServiceClient.scala
94.4% <ø> (ø)
:arrow_up:

...rc/main/scala/colossus/protocols/http/Header.scala
84.02% <0%> (+0.69%)
:arrow_up:

...n/scala/colossus/controller/OutputController.scala
88.09% <0%> (ø)
:arrow_up:

...a/colossus/protocols/http/HttpResponseParser.scala
68.18% <100%> (+0.32%)
:arrow_up:

...la/colossus/protocols/http/HttpRequestParser.scala
95.23% <100%> (+3.23%)
:arrow_up:

...n/scala/colossus/protocols/http/HttpResponse.scala
89.13% <100%> (+0.24%)
:arrow_up:

.../main/scala/colossus/protocols/http/HttpBody.scala
85.71% <100%> (+6.54%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d3a3a43...844d106. Read the comment docs.

You are correct that you can set the content-type via withHeader, but that isn't very useful since you'll end up with two content-type headers when you actually want one (the one set withHeader). I know the problem has bitten me twice and at least one other person. I'm not sure what functionality we would lose/break if content type was removed from the body.

Yeah that's definitely a good point.  I'm going to go ahead and approve this PR.  I'm still a little concerned that there's a better reason for keeping the header with the body that I'm just not thinking of right now, but since the PR still allows the HttpBodyEncoder to work properly, which was my main concern, I think it should be ok.
👍

bump @benblack86 updated docs


IntelGPU backend: Use clDNN matrix operations for nGraph::Dot

tests are aligned to current passrate
used cldnn::gemm for nGraph::Dot in supported cases. Other cases are covered by custom kernel
made uniwersal custom kernel (for Dot) instead of a set of custom kernels
updated clDNN version for automatic build (does not affect current clDNN version in the PR testing)

Man I  am  so over my head.


Release app on F-droid

Once we have the first version ready, we should try to get the app on F-droid.

Is the app or are there any plans to release it on Google Play?

Yes, google play store and the apple app store are planned as well, but F-droid should be slightly less friction so that one is targeted first.

Given fdroid release is done, time to close ticket?

Yep, probably a good idea. We have a personal F-droid repository for Dana: https://fdroid.silentpayments.dev/
Dana isn't available in the official F-droid repository yet, but we should probably make a separate issue for that.

I added a section to the README for downloading the app using F-Droid.


Include git hash in info

As I user, I would like to know what code was used to make the torxakis version I am currently using.
So info should return the git SHA-1 hash.
(Like is done by Z3).

Issue moved to TorXakis/SourceWindowsInstaller #19 via ZenHub


[Bug]: Cannot access the Board plugin on Windows

Before you file a bug report

[X] I have checked the issue tracker and have not found an issue that matches the one I'm filing.
[X] This issue is not a troubleshooting question. Troubleshooting questions go here: https://forum.mattermost.com/c/trouble-shoot/16.
[X] This issue is not a feature request. You can request features and make product suggestions here: https://mattermost.com/suggestions/.
[X] This issue doesn't reproduce on web browsers (such as in Chrome). If it does, issue reports go to the Mattermost Server repository.
[X] I have read the contribution guidelines.

Mattermost Desktop Version
5.2.2
Operating System
Windows 11 x64
Mattermost Server Version
7.9.x
Steps to reproduce
Navigate to the Boards tab
Expected behavior
The Boards show up
Observed behavior
White screen with message

Redirecting to error page…

In the Browser everything works fine and both URLs mentioned in the log output are accessible and show the focalboard.
On at least two Linux clients it is working (did not yet have the opportunity to check on other windows machines)
Log Output
[2023-03-28 13:12:42.293] [debug] webContentEvents.did-start-navigation {
  webContentsId: 28,
  url: 'https://chat.asdf.com/boards/plugins/focalboard/error?id=unknown'
}
[2023-03-28 13:12:42.294] [debug] webContentEvents.will-navigate {
  webContentsId: 28,
  url: 'https://chat.asdf.com/boards/plugins/focalboard/error?id=unknown'
}
[2023-03-28 13:12:42.295] [info]  Prevented desktop from navigating to: https://chat.asdf.com/boards/plugins/focalboard/error?id=unknown
[2023-03-28 13:12:42.674] [debug] WindowManager.handleReactAppInitialized Mattermost-INS___TAB_FOCALBOARD
[2023-03-28 13:12:42.675] [debug] WindowManager.handleBrowserHistoryButton Mattermost-INS___TAB_FOCALBOARD
[2023-03-28 13:12:43.736] [debug] WindowManager.handleLoadingScreenAnimationFinished
[2023-03-28 13:13:04.023] [debug] Utils.flushCookiesStore
[2023-03-28 13:13:06.155] [debug] Config.handleGetConfiguration undefined
[2023-03-28 13:13:06.192] [debug] DownloadsManager.hasDownloads
[2023-03-28 13:13:33.482] [debug] Initialize.UserActivityMonitor.on(status) { userIsActive: true, idleTime: 0, isSystemEvent: false }
[2023-03-28 13:14:34.101] [debug] Initialize.UserActivityMonitor.on(status) { userIsActive: true, idleTime: 1, isSystemEvent: false }
[2023-03-28 13:15:34.709] [debug] Initialize.UserActivityMonitor.on(status) { userIsActive: true, idleTime: 0, isSystemEvent: false }
[2023-03-28 13:16:35.266] [debug] Initialize.UserActivityMonitor.on(status) { userIsActive: true, idleTime: 0, isSystemEvent: false }
[2023-03-28 13:17:04.131] [debug] WindowManager.focusBrowserView

### Additional Information

The following things did not help:
1. Logout and login again
2. Delete the server and do a fresh connect

Thanks for your reply. What exactly do you mean?
What I tried yesterday: I copied the URL https://chat.asdf.com/boards/plugins/focalboard from the error message and entered it in the Browser and could access the board…
What I am curious about in the error log is the error?id=unknown part. Shouldn't there be an 28?

Ah sorry, there is something strange. In my browser https://chat.asdf.com/boards/plugins/focalboard also is empty. https://chat.asdf.com/boards/ works fine...
But this link is generated by the desktop application… When connecting to the server I entered (on all devices) https://chat.asdf.com

@q-wertz Okay so seems like the URL is correct, but I'm not sure why you're being redirected to https://chat.asdf.com/boards/plugins/focalboard. I'm wondering if the link is wrong or something is misconfigured on your server.

But as it is working in the Browser and the other clients it shouldn't be an issue on the server side, or?
I checked it on my Linux machine (where no issues appear). There it looks like
17:40:28.558 › webContentEvents.did-start-navigation {
  webContentsId: 8,
  url: 'https://chat.asdf.com/boards/team/ugxy7475s3rz9mq5d9dpnm747c/babco1x4hmpdn3rzjutapcpc3uc/v4kd4cgrj3ty63eaqtkmpdhhq9w'
}
17:40:28.564 › WindowManager.handleAppLoggedIn INS___TAB_MESSAGING
17:40:28.565 › webContentEvents.did-start-navigation {
  webContentsId: 8,
  url: 'https://chat.asdf.com/boards/team/ugxy7475s3rz9mq5d9dpnm747c/babco1x4hmpdn3rzjutapcpc3uc/v4kd4cgrj3ty63eaqtkmpdhhq9w'
}
17:40:28.621 › MattermostView.handleTitleUpdate { tabName: 'INS___TAB_FOCALBOARD', title: 'Boards - Mattermost' }

So the link and redirect is fine (no plugins/focalboard part).
Will check tomorrow again on the Windows machine and report back. Thanks for your help so far

But for some reason couldn't show INS___TAB_FOCALBOARD, not ready

That's normal to come up while the view is loading. viewManager.showByName INS___TAB_FOCALBOARD is where it should actually be displayed.

Ok.
I tested on another Windows instance (Windows 10) and there also no problems.
So only on one Client so far.
I already tried Clear Cache and Reload functionality, logging out, deleting the server. Any other suggestions? :sweat_smile:

Maybe a full re-install of the app? Also, just double check that there are no pre-configured servers on that machine (via Group Policy, build config, etc.)
Could also be some kind of redirect on that exact machine.

closing the issue as it seems to be a specific problem of that one PC.


Jenkins: testing parallel jobs

Signed-off-by: Eloy Coto<EMAIL_ADDRESS>

test-me-please

test-me-please

test-me-please

test-me-please

test-me-please

test-me-please

test-me-please

test-me-please

test-me-please

test-me-please

test-me-please

test-me-please

test-me-please

test-me-please

test-missed-k8s-eloy

test-me-please

test-me-please

test-me-please

test-me-please

test-me-please

test-me-please

test-me-please

test-me-please

test-me-please

test-me-please

test-me-please

test-me-please

test-missed-k8s-eloy

test-me-please

test-me-please

test-me-please

test-me-please

test-me-please

test-me-please

test-me-please

test-me-please

test-me-please

test-me-please

test-me-please

test-me-please

test-me-please


remove cloudinary provider module

The cloudinary provider module which requires the image/document payload to be passed through the xyz host has been removed.
The signer module has now been reviewed and documented.
The cloduinary signer module has now been reviewed and documented.
The module will not fail silently but return an error message.
The cloudinary entry is now using the cloudinary signer module.
The cloudinary entry is now reviewed and documented.
The cloudinary entry requires a cloudinary account. However, no third party module is required to sign requests, hence the cloudinary signer is included in the XYZ core and the cloudinary entry method is included in the mapp location entries.

Works as expected. I've replaced alerts and confirms with ui elements plus more human wording on removal confirm;

This can't work with both images and documents.


code cleanup, remove attribute error from /api/provider_tasks

fixes 11130.  also includes some code clean up

Coverage increased (+0.05%) to 80.733% when pulling<PHONE_NUMBER>d3d17c9351c5763cb8619375711dc2 on 11130-attribute-error into 033d663f2cd87dcf6e03e6d1aea9198d87cf8517 on master.


unable to create an node.jd environment variable for sendgrid on windows

There are 3 steps at the Sendrig Docs to set the enviorment variable :

echo "export SENDGRID_API_KEY='YOUR_KEY'" > sendgrid.env

echo "sendgrid.env" >> .gitignore

source ./sendgrid.env

1-2 are working fine , but when i tried the 3rd step i got this message : 'source' is not recognized as an internal or external command, operable program or batch file.
I understand that the 'source' command belongs to linux , so my question is what is the equivalent for this step in windows ? for some reason i found no mentions for this in the documentaion

You can just use set SENDGRID_API_KEY='YOUR_KEY' on Windows.

how to do this on windows?

@shaheryarshaikh1011

You can just use set SENDGRID_API_KEY='YOUR_KEY' on Windows.


Question about add() method in Book model (chapter 5)

In chapter 5, Book Model part, add() method, here is the code:
  static async add({ name, price, githubRepo }) {
    const slug = await generateSlug(this, name);
    if (!slug) throw new Error("Error with slug generation");
    return this.create({ name, slug, price, githubRepo });
  }

I concern about the if(!slug) part, how can it be falsy? If generateSlug() threw an error, it would crash the program before the if part, there would be no slug to be falsy.
For my suggestion, I think that we can use await-to-js to deal with this:
import to from "await-to-js";
...
  static async add({ name, price, githubRepo }) {
    const [err, slug] = await to(generateSlug(this, name));
    if (err) throw new Error("Error with slug generation");
    return this.create({ name, slug, price, githubRepo });
  }

What the point to use this 'to' method instead of try-catch? Kind of readability improvement? But it will confuse readers who is not familiar with this package..

slug can be falsy if it's empty string.
This possible in two cases:

name is empty string
name contains no letter or numbers.
If this happened it means Book validator failed.
Another case if some Exception was thrown from generateSlug method (perhaps from mongo or mongoose).
Since we throw an Exception here, it's ok to not replace original Exception by meaningless "Error with slug generation".

So I think we do not need to change here anything, or, may be slightly adjust error text.
For example to `Error with slug generation for string ${name}`
So user will see input string and will be able to guess something is wrong with content of some text input.

@PercyPham Thanks for the comment. I think @YuriGor explained it well.
I agree to add name string like this:
if (!slug) throw new Error(`Error with slug generation for name: ${name}`);
@klyburke Would you please update code and content?

@tima101 for sure.
@PercyPham thanks for bringing up your question and suggestion. And @YuriGor thank you for the explanation and suggestion.

@YuriGor : thanks for the explanation


Add API for checking proofs for multi usage

What changed? Why?
Add an api endpoint for checking proofs from a storage.
We went to postgres storage to avoid proofs amount limitation. The current solution makes use of a single table using a composed PK with address + namespace. This way the lift for adding new proofs is very low.
API: GET ->  <base-url>/api/addresses/<address>/proof?namespace=<usernames>
Notes to reviewers
NOTE: since this is using different storage from NFT Builders, then this endpoint iw not compatible with NFTBuilders proofs.
How has it been tested?
tested locally by populating the proofs and accessing them through the api

Review Error for JFrankfurt @ 2024-06-18 17:44:39 UTC
User failed mfa authentication, see go/mfa-help


fix(ipld): fix reconstruction by re-enabling re-importing of rsmt2d.ExtendedDataSquare

An update of rsmt2d happened in https://github.com/celestiaorg/celestia-node/pull/737 during Mamaki launch preparation. This update changed our code not to reimport the square on each reconstruction attempt which silently sneaked in the problem, which is not reproducible with current tests. Reconstruction tests(#702) reproduce it, but they are not yet merged.
I was able to change the code to reproduce it reliably. Mainly I had to fetch only from columns and force the code to download only [2:4) quadrants. Unfortunately, it is hard to extract the reproducible case in a separate test, so we can either rely on reconstruction tests that are soon to be merged, or I can still try to make a test.
The reason for the bug is explained in #787, as well as a cleaner way to fix it.
Closes #787
P.S. Was pretty hard to debug this case. I went on the wrong paths like 3 times. Though collected some minor findings that I am going to submit further.

Force push with a cleaner commit

Codecov Report

Merging #804 (bd5daa5) into main (a422ce1) will decrease coverage by 0.00%.
The diff coverage is 72.72%.

@@            Coverage Diff             @@
##             main     #804      +/-   ##
==========================================
- Coverage   53.15%   53.15%   -0.01%
==========================================
  Files         117      117
  Lines        6750     6760      +10
==========================================
+ Hits         3588     3593       +5
- Misses       2798     2803       +5
  Partials      364      364

Impacted Files
Coverage Δ

ipld/retriever.go
87.76% <72.72%> (-2.93%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a422ce1...bd5daa5. Read the comment docs.

@liamsi, I added a test anyway. You can try removing the fix commit and reproduce it yourself. Sometimes it fails with other rsmt2d errors besides byzantine. The test ensures that at least 2 more quadrants are fetching besides the initial one, and all of those written into the shared square, and somewhere in between, the reconstruction fails.

As always on CI something goes not like locally, aaaaa

Force push with an updated test that should fail on CI, lets see...

Ok, test is fixed


Document plugin removing links without type

Folks, this is about a change I've introduces here
I've introduced this function to sweep out incomplete links (who either have no type or no href)
Unfortunately, I've forgotten, that we in Hypothes.is fill the document's field with links which has no type
So, we this is an example of what we're saving:
            "link": [
            {
                "href": "http://www.forbes.com/sites/realspin/2014/03/31/the-ipccs-latest-report-deliberately-excludes-and-misrepresents-important-climate-science/print/"
            },
            {
                "href": "http://onforb.es/1ffC1p9",
                "type": "",
                "rel": "shortlink"
            }
            ]

And because the first one does not have a link type, we drop that.
My question is, should we keep them, or should we modify our document filling mechanism at H to provide a type for those links?

Where do we do this and why?

Actually the annotator document plugin does it, that we use.
https://github.com/openannotation/annotator/blob/v1.2.x/src/plugin/document.coffee#L101
It creates a link without a type for the current document.location.href.
I think I should allow links without type then.
@nickstenning: Your thoughts on this?

We currently store that information also in the annotation's uri field so I'm not concerned about dropping it. I'd rather spend time on crafting a different approach to document metadata.


[Event request] Codeunit 90 "Purch.-Post" - OnBeforeCheckPostRestrictions

Hi AL-Team,
can you please add new events in the method CheckAndUpdate
if Invoice then
if WithhSocSec.Get("Document Type", "No.") and
(WithhSocSec."Withholding Tax Code" <> '') and
(WithhSocSec."Total Amount" = 0) and
("Document Type" = "Document Type"::Invoice)
then
Error(Text1130006,
WithhSocSec.FieldCaption("Total Amount"), WithhSocSec.FieldCaption("Withholding Tax Code"));
//New Event
OnBeforeCheckPostRestrictions(WithhSocSec,Invoice,PurchHeader);
//New Event
CheckPostRestrictions(PurchHeader);

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.