Cannot Build: compareSizes

/----------
| Run Ghc Stage1 (package = compareSizes)
|     input: utils/compare_sizes/stage1/build/Main.o
| => output: utils/compare_sizes/stage1/build/tmp/compareSizes
\----------
Undefined symbols for architecture x86_64:
  "_TRACE_gc", referenced from:
      _traceEventHeapInfo in libHSrts.a(Storage.o)
      _traceEventGcStats in libHSrts.a(Stats.o)
  "_TRACE_sched", referenced from:
      _traceTaskCreate in libHSrts.a(Schedule.o)
      _traceTaskCreate in libHSrts.a(RtsAPI.o)
      _traceTaskDelete in libHSrts.a(RtsAPI.o)
ld: symbol(s) not found for architecture x86_64
clang: error: linker command failed with exit code 1 (use -v to see invocation)
`clang' failed in phase `Linker'. (Exit code: 1)
shakeArgsWith    0.002s    0%
Function shake   0.030s    0%
Database read    0.128s    0%
With database    0.012s    0%
Running rules  294.047s   99%  =========================
Total          294.219s  100%
Error when running Shake build system:
* utils/compare_sizes/stage1/build/tmp/compareSizes
user error (Development.Shake.cmd, system command failed
Command: inplace/bin/ghc-stage1 -hisuf hi -osuf o -hcsuf hc -static -hide-all-packages -no-user-package-db -package-id base-<IP_ADDRESS> -package-id directory-<IP_ADDRESS> -package-id filepath-<IP_ADDRESS> -i -iutils/compare_sizes/stage1/build -iutils/compare_sizes/stage1/build/autogen -iutils/compare_sizes -Iutils/compare_sizes/stage1/build -Iutils/compare_sizes/stage1/build/autogen -I/Users/angerman/Projects/Haskell/ghc/libraries/directory/include -I/Users/angerman/Projects/Haskell/ghc/libraries/unix/include -I/Users/angerman/Projects/Haskell/ghc/libraries/time/lib/include -I/Users/angerman/Projects/Haskell/ghc/libraries/bytestring/include -I/Users/angerman/Projects/Haskell/ghc/libraries/base/include -I/Users/angerman/Projects/Haskell/ghc/libraries/integer-gmp/include -I/Users/angerman/Projects/Haskell/ghc/rts/dist/build -I/Users/angerman/Projects/Haskell/ghc/includes -I/Users/angerman/Projects/Haskell/ghc/includes/dist-derivedconstants/header -optP-include -optPutils/compare_sizes/stage1/build/autogen/cabal_macros.h -XHaskell2010 -odir utils/compare_sizes/stage1/build -hidir utils/compare_sizes/stage1/build -stubdir utils/compare_sizes/stage1/build -rtsopts -H32m -O2 -Wall -fwarn-tabs -no-auto-link-packages -optl-liconv -optl-lm -optl-ldl -optl-L/Users/angerman/Projects/Haskell/ghc/libraries/directory/stage1/build -optl-L/Users/angerman/Projects/Haskell/ghc/libraries/unix/stage1/build -optl-L/Users/angerman/Projects/Haskell/ghc/libraries/time/stage1/build -optl-L/Users/angerman/Projects/Haskell/ghc/libraries/filepath/stage1/build -optl-L/Users/angerman/Projects/Haskell/ghc/libraries/bytestring/stage1/build -optl-L/Users/angerman/Projects/Haskell/ghc/libraries/deepseq/stage1/build -optl-L/Users/angerman/Projects/Haskell/ghc/libraries/array/stage1/build -optl-L/Users/angerman/Projects/Haskell/ghc/libraries/base/stage1/build -optl-L/Users/angerman/Projects/Haskell/ghc/libraries/integer-gmp/stage1/build -optl-L/Users/angerman/Projects/Haskell/ghc/libraries/ghc-prim/stage1/build -optl-L/Users/angerman/Projects/Haskell/ghc/rts/dist/build utils/compare_sizes/stage1/build/Main.o -o utils/compare_sizes/stage1/build/tmp/compareSizes
Exit code: 1
Stderr:
Undefined symbols for architecture x86_64:
  "_TRACE_gc", referenced from:
      _traceEventHeapInfo in libHSrts.a(Storage.o)
      _traceEventGcStats in libHSrts.a(Stats.o)
  "_TRACE_sched", referenced from:
      _traceTaskCreate in libHSrts.a(Schedule.o)
      _traceTaskCreate in libHSrts.a(RtsAPI.o)
      _traceTaskDelete in libHSrts.a(RtsAPI.o)
ld: symbol(s) not found for architecture x86_64
clang: error: linker command failed with exit code 1 (use -v to see invocation)
`clang' failed in phase `Linker'. (Exit code: 1)
)

This happens when we link rts/dist to rts/stage1, and copy libffi into place. (e.g. cp libffi/build/inst/lib/libffi.a rts/dist/build/libCffi.a)

Running the command by hand with -verbose yields:
inplace/bin/ghc-stage1 -hisuf hi -osuf o -hcsuf hc -static -hide-all-packages -no-user-package-db -package-id base-<IP_ADDRESS> -package-id directory-<IP_ADDRESS> -package-id filepath-<IP_ADDRESS> -i -iutils/compare_sizes/stage1/build -iutils/compare_sizes/stage1/build/autogen -iutils/compare_sizes -Iutils/compare_sizes/stage1/build -Iutils/compare_sizes/stage1/build/autogen -I/Users/angerman/Projects/Haskell/ghc/libraries/directory/include -I/Users/angerman/Projects/Haskell/ghc/libraries/unix/include -I/Users/angerman/Projects/Haskell/ghc/libraries/time/lib/include -I/Users/angerman/Projects/Haskell/ghc/libraries/bytestring/include -I/Users/angerman/Projects/Haskell/ghc/libraries/base/include -I/Users/angerman/Projects/Haskell/ghc/libraries/integer-gmp/include -I/Users/angerman/Projects/Haskell/ghc/rts/stage1/build -I/Users/angerman/Projects/Haskell/ghc/includes -I/Users/angerman/Projects/Haskell/ghc/includes/dist-derivedconstants/header -optP-include -optPutils/compare_sizes/stage1/build/autogen/cabal_macros.h -XHaskell2010 -odir utils/compare_sizes/stage1/build -hidir utils/compare_sizes/stage1/build -stubdir utils/compare_sizes/stage1/build -rtsopts -H32m -O2 -Wall -fwarn-tabs -no-auto-link-packages -optl-liconv -optl-lm -optl-ldl -optl-L/Users/angerman/Projects/Haskell/ghc/libraries/directory/stage1/build -optl-L/Users/angerman/Projects/Haskell/ghc/libraries/unix/stage1/build -optl-L/Users/angerman/Projects/Haskell/ghc/libraries/time/stage1/build -optl-L/Users/angerman/Projects/Haskell/ghc/libraries/filepath/stage1/build -optl-L/Users/angerman/Projects/Haskell/ghc/libraries/bytestring/stage1/build -optl-L/Users/angerman/Projects/Haskell/ghc/libraries/deepseq/stage1/build -optl-L/Users/angerman/Projects/Haskell/ghc/libraries/array/stage1/build -optl-L/Users/angerman/Projects/Haskell/ghc/libraries/base/stage1/build -optl-L/Users/angerman/Projects/Haskell/ghc/libraries/integer-gmp/stage1/build -optl-L/Users/angerman/Projects/Haskell/ghc/libraries/ghc-prim/stage1/build -optl-L/Users/angerman/Projects/Haskell/ghc/rts/stage1/build utils/compare_sizes/stage1/build/Main.o -o utils/compare_sizes/stage1/build/tmp/compareSizes -v
Glasgow Haskell Compiler, Version 7.11.20151228, stage 1 booted by GHC version 7.10.2
Using binary package database: /Users/angerman/Projects/Haskell/ghc/inplace/lib/package.conf.d/package.cache
loading package database /Users/angerman/Projects/Haskell/ghc/inplace/lib/package.conf.d
wired-in package ghc-prim mapped to ghc-prim-<IP_ADDRESS>
wired-in package integer-gmp mapped to integer-gmp-<IP_ADDRESS>
wired-in package base mapped to base-<IP_ADDRESS>
wired-in package rts mapped to rts
wired-in package template-haskell not found.
wired-in package ghc not found.
wired-in package dph-seq not found.
wired-in package dph-par not found.
Hsc static flags:
Created temporary directory: /var/folders/fv/xqjrpfj516n5xq_m_ljpsjx00000gn/T/ghc21085_0
*** C Compiler:
/usr/bin/clang -m64 -fno-stack-protector -DTABLES_NEXT_TO_CODE -c /var/folders/fv/xqjrpfj516n5xq_m_ljpsjx00000gn/T/ghc21085_0/ghc_1.c -o /var/folders/fv/xqjrpfj516n5xq_m_ljpsjx00000gn/T/ghc21085_0/ghc_2.o -I/Users/angerman/Projects/Haskell/ghc/rts/stage1/build -I/Users/angerman/Projects/Haskell/ghc/includes -I/Users/angerman/Projects/Haskell/ghc/includes/dist-derivedconstants/header -fno-common -U__PIC__ -D__PIC__
*** Linker:
/usr/bin/clang -m64 -fno-stack-protector -DTABLES_NEXT_TO_CODE -m64 -liconv -lm -ldl -L/Users/angerman/Projects/Haskell/ghc/libraries/directory/stage1/build -L/Users/angerman/Projects/Haskell/ghc/libraries/unix/stage1/build -L/Users/angerman/Projects/Haskell/ghc/libraries/time/stage1/build -L/Users/angerman/Projects/Haskell/ghc/libraries/filepath/stage1/build -L/Users/angerman/Projects/Haskell/ghc/libraries/bytestring/stage1/build -L/Users/angerman/Projects/Haskell/ghc/libraries/deepseq/stage1/build -L/Users/angerman/Projects/Haskell/ghc/libraries/array/stage1/build -L/Users/angerman/Projects/Haskell/ghc/libraries/base/stage1/build -L/Users/angerman/Projects/Haskell/ghc/libraries/integer-gmp/stage1/build -L/Users/angerman/Projects/Haskell/ghc/libraries/ghc-prim/stage1/build -L/Users/angerman/Projects/Haskell/ghc/rts/stage1/build -o utils/compare_sizes/stage1/build/tmp/compareSizes -Wl,-no_compact_unwind utils/compare_sizes/stage1/build/Main.o -L/Users/angerman/Projects/Haskell/ghc/libraries/directory/stage1/build -L/Users/angerman/Projects/Haskell/ghc/libraries/unix/stage1/build -L/Users/angerman/Projects/Haskell/ghc/libraries/bytestring/stage1/build -L/Users/angerman/Projects/Haskell/ghc/libraries/time/stage1/build -L/Users/angerman/Projects/Haskell/ghc/libraries/deepseq/stage1/build -L/Users/angerman/Projects/Haskell/ghc/libraries/array/stage1/build -L/Users/angerman/Projects/Haskell/ghc/libraries/filepath/stage1/build -L/Users/angerman/Projects/Haskell/ghc/libraries/base/stage1/build -L/Users/angerman/Projects/Haskell/ghc/libraries/integer-gmp/stage1/build -L/Users/angerman/Projects/Haskell/ghc/libraries/ghc-prim/stage1/build -L/Users/angerman/Projects/Haskell/ghc/rts/stage1/build /var/folders/fv/xqjrpfj516n5xq_m_ljpsjx00000gn/T/ghc21085_0/ghc_2.o -Wl,-u,_ghczmprim_GHCziTypes_Izh_static_info -Wl,-u,_ghczmprim_GHCziTypes_Czh_static_info -Wl,-u,_ghczmprim_GHCziTypes_Fzh_static_info -Wl,-u,_ghczmprim_GHCziTypes_Dzh_static_info -Wl,-u,_base_GHCziPtr_Ptr_static_info -Wl,-u,_ghczmprim_GHCziTypes_Wzh_static_info -Wl,-u,_base_GHCziInt_I8zh_static_info -Wl,-u,_base_GHCziInt_I16zh_static_info -Wl,-u,_base_GHCziInt_I32zh_static_info -Wl,-u,_base_GHCziInt_I64zh_static_info -Wl,-u,_base_GHCziWord_W8zh_static_info -Wl,-u,_base_GHCziWord_W16zh_static_info -Wl,-u,_base_GHCziWord_W32zh_static_info -Wl,-u,_base_GHCziWord_W64zh_static_info -Wl,-u,_base_GHCziStable_StablePtr_static_info -Wl,-u,_ghczmprim_GHCziTypes_Izh_con_info -Wl,-u,_ghczmprim_GHCziTypes_Czh_con_info -Wl,-u,_ghczmprim_GHCziTypes_Fzh_con_info -Wl,-u,_ghczmprim_GHCziTypes_Dzh_con_info -Wl,-u,_base_GHCziPtr_Ptr_con_info -Wl,-u,_base_GHCziPtr_FunPtr_con_info -Wl,-u,_base_GHCziStable_StablePtr_con_info -Wl,-u,_ghczmprim_GHCziTypes_False_closure -Wl,-u,_ghczmprim_GHCziTypes_True_closure -Wl,-u,_base_GHCziPack_unpackCString_closure -Wl,-u,_base_GHCziIOziException_stackOverflow_closure -Wl,-u,_base_GHCziIOziException_heapOverflow_closure -Wl,-u,_base_ControlziExceptionziBase_nonTermination_closure -Wl,-u,_base_GHCziIOziException_blockedIndefinitelyOnMVar_closure -Wl,-u,_base_GHCziIOziException_blockedIndefinitelyOnSTM_closure -Wl,-u,_base_GHCziIOziException_allocationLimitExceeded_closure -Wl,-u,_base_ControlziExceptionziBase_nestedAtomically_closure -Wl,-u,_base_GHCziEventziThread_blockedOnBadFD_closure -Wl,-u,_base_GHCziWeak_runFinalizzerBatch_closure -Wl,-u,_base_GHCziTopHandler_flushStdHandles_closure -Wl,-u,_base_GHCziTopHandler_runIO_closure -Wl,-u,_base_GHCziTopHandler_runNonIO_closure -Wl,-u,_base_GHCziConcziIO_ensureIOManagerIsRunning_closure -Wl,-u,_base_GHCziConcziIO_ioManagerCapabilitiesChanged_closure -Wl,-u,_base_GHCziConcziSync_runSparks_closure -Wl,-u,_base_GHCziConcziSignal_runHandlersPtr_closure -Wl,-search_paths_first -lHSdirectory-<IP_ADDRESS> -lHSunix-<IP_ADDRESS> -lHSbytestring-<IP_ADDRESS> -lHStime-1.6 -lHSdeepseq-<IP_ADDRESS> -lHSarray-<IP_ADDRESS> -lHSfilepath-<IP_ADDRESS> -lHSbase-<IP_ADDRESS> -lHSinteger-gmp-<IP_ADDRESS> -lHSghc-prim-<IP_ADDRESS> -lHSrts -lCffi -liconv -lm -ldl
Undefined symbols for architecture x86_64:
  "_TRACE_gc", referenced from:
      _traceEventHeapInfo in libHSrts.a(Storage.o)
      _traceEventGcStats in libHSrts.a(Stats.o)
  "_TRACE_sched", referenced from:
      _traceTaskCreate in libHSrts.a(Schedule.o)
      _traceTaskCreate in libHSrts.a(RtsAPI.o)
      _traceTaskDelete in libHSrts.a(RtsAPI.o)
ld: symbol(s) not found for architecture x86_64
clang: error: linker command failed with exit code 1 (use -v to see invocation)
*** Deleting temp files:
Deleting: /var/folders/fv/xqjrpfj516n5xq_m_ljpsjx00000gn/T/ghc21085_0/ghc_4.rsp /var/folders/fv/xqjrpfj516n5xq_m_ljpsjx00000gn/T/ghc21085_0/ghc_3.rsp /var/folders/fv/xqjrpfj516n5xq_m_ljpsjx00000gn/T/ghc21085_0/ghc_2.o /var/folders/fv/xqjrpfj516n5xq_m_ljpsjx00000gn/T/ghc21085_0/ghc_1.c
*** Deleting temp dirs:
Deleting: /var/folders/fv/xqjrpfj516n5xq_m_ljpsjx00000gn/T/ghc21085_0
`clang' failed in phase `Linker'. (Exit code: 1)

Some more info
/----------
| Run Ar (stage = Stage1, package = rts)
|     input: rts/stage1/build/Adjustor.o (and 86 more)
| => output: rts/stage1/build/libHSrts.a
\----------
ar: creating archive rts/stage1/build/libHSrts.a
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: rts/stage1/build/libHSrts.a(Disassembler.o) has no symbols
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: rts/stage1/build/libHSrts.a(LdvProfile.o) has no symbols
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: rts/stage1/build/libHSrts.a(OldARMAtomic.o) has no symbols
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: rts/stage1/build/libHSrts.a(Profiling.o) has no symbols
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: rts/stage1/build/libHSrts.a(RetainerProfile.o) has no symbols
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: rts/stage1/build/libHSrts.a(RetainerSet.o) has no symbols
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: rts/stage1/build/libHSrts.a(RtsDllMain.o) has no symbols
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: rts/stage1/build/libHSrts.a(Trace.o) has no symbols
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: rts/stage1/build/libHSrts.a(EventLog.o) has no symbols
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: rts/stage1/build/libHSrts.a(Sanity.o) has no symbols

I am now stuck at this point too on Windows.

I'm building C files in rts using C compiler, however, the old build system is using GHC. I wonder whether this is relevant and I don't know why use GHC for compiling C files.

Here is the current command we use to produce Trace.o:
D:/msys/home/nam83/ghc/inplace/mingw/bin/gcc.exe
-Iincludes
-Iincludes/dist
-derivedconstants/header
-Irts/stage1/build
-Irts/stage1/build/autogen
-c rts/Trace.c
-o rts/stage1/build/Trace.o
-Irts
-Irts/stage1/build "
-DRtsWay=\"rts_v\""
-DCOMPILING_RTS "
-DProjectVersion=\"8.1.20160104\""

Here is what the old system uses:
"inplace/bin/ghc-stage1.exe"
-optc-fno-stack-protector
-optc-Wall
-optc-Wall
-optc-Wextra
-optc-Wstrict-prototypes
-optc-Wmissing-prototypes
-optc-Wmissing-declarations
-optc-Winline
-optc-Waggregate-return
-optc-Wpointer-arith
-optc-Wmissing-noreturn
-optc-Wnested-externs
-optc-Wredundant-decls
-optc-Iincludes
-optc-Iincludes/dist
-optc-Iincludes/dist-derivedconstants/header
-optc-Iincludes/dist-ghcconstants/header
-optc-Irts
-optc-Irts/stage1/build
-optc-DCOMPILING_RTS
-optc-fno-strict-aliasing
-optc-fno-common
-optc-Irts/stage1/build/autogen
-optc-Wno-error=inline
-optc-O2
-optc-fomit-frame-pointer
-optc-g
-optc-DRtsWay=\"rts_v\"
-optc-DWINVER=0x06000100
-optc-DProjectVersion=\"8.1.20160104\"
-static
-H32m
-O
-Wall
-Iincludes
-Iincludes/dist
-Iincludes/dist-derivedconstants/header
-Iincludes/dist-ghcconstants/header
-Irts
-Irts/stage1/build
-DCOMPILING_RTS
-this-package-key rts
-dcmm-lint
-i
-irts
-irts/stage1/build
-irts/stage1/build/autogen
-Irts/stage1/build
-Irts/stage1/build/autogen
-O2
-c rts/Trace.c
-o rts/stage1/build/Trace.o

Quite a big difference, but I wonder which flag is crucial for this issue, and how the result is affected by the choice of builder (gcc vs ghc)

Strangely enough, my make log, lists -DDTRACE. And otherwise the only difference in the built file is -g, which adds debug information.  Without -g I obtain an empty 200 byte file.
For -DDTRACE to work, I would need RtsProbes.h, which doesn't exist.

The big differences I see are:
-O2 -fomit-frame-pointer -fno-strict-aliasing -fno-common

-O2 being the most important here, as it forces the inlining (or at least that's what I think).
In Trace.h we find:
INLINE_HEADER void traceEventHeapInfo(...) { ... }

for which includes/Stg.h contains the definition:
134:# define INLINE_HEADER static inline
163:# define INLINE_HEADER __inline static

As far as I can tell, for llvm's clang, -inline comes with -O2. Then again, I'm not sure if inline is actually supposed to be a hint to the compiler, or force the compiler to actually inline a function. Experimental results (-O0 vs -O2), imply the compiler handles it as a suggestion.
Can anyone more knowledgeable support make any sense out of this?

According to http://stackoverflow.com/questions/25602813/force-a-function-to-be-inline-in-clang-llvm/25623448#25623448, my suspicion is correct.

@angerman Awesome! Many thanks for finding the reason. I couldn't imagine -O2 affected linking... And I don't remember seeing any comments about this while looking through makefiles for a solution.

@snowleopard I ended up comparing the symbols in the object files, and wondered why they were missing in one, but not the other... after looking for the symbols in the source I kept wondering what was different wrt the inlining. Then it dawned on me that it had to be an optimization pass.


Improve WkbWriter constructors

This PR adresses #156 (first commit) and should fix different dimensions in reader and writer (second commit).
Follow-up to discussion with @Oreilles in https://github.com/georust/geozero/issues/153#issuecomment-1675943714
Instead of the ugly with_extended_opts constructor we should probably use a builder pattern.

I think this is a good direction, thx! Would it make sense to perhaps simplify all readers/writers to own underlying impl Read/impl Write?  Same as std::io::BufWriter and others?  The wrappers would still allow access to the underlying inner reader/writer, same as buffer - with get_ref and get_mut

Thanks for solving this, I was about to go at it when I saw your PR 🙂
Regarding the constructor issue: I don't know if that's a common pattern in rust, but in Typescript you often create functions accepting a single parameter object containing all the options, rather than one function argument for each parameter. It makes it easier to merge default values and reduce friction with adding new options. It has the disadvantage of being a bit more verbose though.
In this case, it could look something like this (untested):
#[derive(Default)]
pub struct WkbWriterParams {
    pub dialect: WkbDialect,
    pub dims: CoordDimensions,
    pub srid: Option<i32>,
    pub envelope: Vec<f64>,
    pub envelope_dims: CoordDimensions,
    pub extended_gpkg: bool,
}

impl<'a, W: Write> WkbWriter<'a, W> {
    pub fn new(out: &'a mut W, params: WkbWriterParams) -> WkbWriter<'a, W> {
        WkbWriter {
            dialect: params.dialect,
            dims: params.dims,
            srid: params.srid,
            envelope: params.envelope,
            envelope_dims: params.envelope_dims,
            extended_gpkg: params.extended_gpkg,
            empty: false,
            endian: scroll::LE,
            dialect,
            first_header: true,
            geom_state: GeomState::Normal,
            out,
        }
    }
}

which you would then call as such:
let writer = WkbWriter::new(out, WkbWriterParams { srid: Some(4326), Default::default() })

Rust usually uses builder pattern as it is far more concise and does not break when options are changed, e.g. this guide.  The biggest unknown is if the builder should return &mut Self or Self on each setter

I'm hesitating to put too much work into this mostly internal API. We could also implement Default for writer structs instead of having with_extended_opts or builder functions. But implementingDefault isn't easy because of out: &'a mut W. So yes, we should probably switch to out: W.

So yes, we should probably switch to out: W.

This is done in #162


Add option to reset default settings

Description
I found it incredibly difficult to reset the editor back to it's default settings.  Previously you had to clear localstorage manually and delete the query params off of the url and refresh.  I updated the Editor and Settings component to reset back the default settings and clear local storage.

This was very needed, thanks for adding this!

No problem, love the tool!


Broken fonts on Alacritty

Describe the bug
Broken symbols ( probably missing symbols ) on Alacritty after installing both Alacritty and the bash config file from linutil. Latest version at the time of writing.
To Reproduce
Steps to reproduce the behavior:

Open linutil
Applications Setup > Alacritty Setup & Bash Prompt Setup
Open alacritty

Expected behavior
It should show the correct symbols, symbols that we can see on Chris' videos. Kitty works just fine though.
Screenshots

Additional context
I've read mixed things about this issue. Some people say that nerd fonts, which is used by the config of this script, are not supported on Alacritty. Elsewhere I read that it should work.
Nevertheless, whether the issue is due to Alacritty or not, the script should provide a good user experience, so I think that something could be done. [ Hopefully this is not taken the wrong way, not trying to be mean :P ]

The issue is that the bash prompt script installs the FiraCode Nerd Font by default, but Alacritty is set to use the MesloLGS Nerd Font. I’ve created a PR that might fix this issue. In the meantime, I suggest either downloading the MesloLGS Nerd Font from the Nerd Fonts Website or installing the FiraCode Nerd Font from the same website and updating the font in your Alacritty config, depending on your preference.

Yep, perfect, it works now. Thanks!

@tsuza well as your issue is solved you can close this issue ... thanks!


[Feature Request] Implement a backing off strategy for

Describe the feature
Currently, the NuxtLoadingIndicator component is not very smart about the way it shows page loading. For example if you set the duration prop to 2000 ms it will simply go to the end in 2 seconds and that's all. But if the page takes 5 seconds to load then the loading bar will be at the end stuck for 3 seconds. Not a very good UX.
I have seen loading indicators where it slowly backs off from reaching the end if the page is not loaded yet. For example if it gets  to about 50% and the page is still not loaded it starts moving more slowly and gets slower with time so it does not reach the end. It's an incremental back-off strategy.
Additional information

[ ] Would you be willing to help implement this feature?
[ ] Could this feature be implemented as a module?

Final checks

[X] Read the contribution guide.
[X] Check existing discussions and issues.

@danielroe I'd like to contribute on this, could I be assigned on the issue?
I consider adding adaptive property to the component, to switch between current and proposed behaviors.
This adaptive property is false by default. When it is true - use arctangent function to decrease step after reaching 50% of progress.

@danielroe I'd like to contribute on this, could I be assigned on the issue?
I consider adding adaptive property to the component, to switch between current and proposed behaviors. This adaptive property is false by default. When it is true - use arctangent function to decrease step after reaching 50% of progress.

I think this should be the default, and only behaviour. As the OP mentioned, the current implementation is not very user-friendly

@danielroe I'd like to contribute on this, could I be assigned on the issue?
I consider adding adaptive property to the component, to switch between current and proposed behaviors. This adaptive property is false by default. When it is true - use arctangent function to decrease step after reaching 50% of progress.

I think this should be the default, and only behaviour. As the OP mentioned, the current implementation is not very user-friendly

Sounds pretty much reasonable, I'll stick this approach. Thank you!

I consider adding adaptive property to the component, to switch between current and proposed behaviors.
This adaptive property is false by default. When it is true - use arctangent function to decrease step after reaching 50% of progress.

I also think it would be nice to make it configurable when it starts to decrease step. At 50% or 20% or 30% and how large the decrease step is. But also with sane defaults that would work for most people.


 Through which IO is this possible?
The combined size of the channels is still too large to load at once into memory. Ideally it would be something where I write all the signals into one file, and then can read parts of it just as you already have implemented it the current read/lazy methods, but I can't figure out which IO I need to save the data.

Hi @TRuikes,
I think your only option is RawBinarySignalIO.
>>> import neo
>>> from neo.rawio.baserawio import BaseRawIO
>>> for io in neo.iolist:
>>>     if io.is_writable and io.support_lazy:
>>>         print(io)
<class 'neo.io.rawbinarysignalio.RawBinarySignalIO'>

Allright! I think this one is WIP aswell. I'll use h5 for now.

I found my answer (Nixio in combination with NixioFr can do it) in #786, in case anyone ends up here!


New material theming support

Feature Description
What is the roadmap on new material theming.
Google IO'19

We have some work in progress that will expand our theming system with density levels, but nothing beyond that (e.g. shapes)

Ok


How to merge .PNG files of voxel

Hi
Thanks for this code. It saved me man. Anyway I am getting multiple layers voxel in .PNG images from stl
How I can stack them so they fit at perfect co-ordinate and I can set them as label
any script or guideline will be great
thanks
sagar

Hi @sagarhukkire !
I don't know if you wnat to do this, but I'm composing a forenic facial reconstruction. Firts I convert to voxel the skull, after the muscles and now I'm creating the skin voxel data.

To merge all I'm using the Blender's video editor. After I'll convert the images into a DICOM with img2dcm.
A big hug!

Hi @sagarhukkire I used https://imagemagick.org/ to convert the png files into an animated gif. There are some instructions here: https://legacy.imagemagick.org/discourse-server/viewtopic.php?t=24912

Hi @sagarhukkire, a change was just merged to enable you to use multiple stl files at the same time. Images will be produced with a different color for each input stl file. I hope this is helpful for what you are doing. :)


I used pnpm run dev to run, and the web page was blank, and then an error was reported.

Bug report 🐞
Version & Environment
"@varlet/cli": "^3.3.11"
node：V18.20.2

varlet/CLI

Fixed in 3.3.12


Unit tests for OAuth2Manager API

Unit tests for OAuth2Manager APIs

/azp run

@ayushjai30 please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
@microsoft-github-policy-service agree [company="{your company}"]

Options:

(default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.

@microsoft-github-policy-service agree

(when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.

@microsoft-github-policy-service agree company="Microsoft"

Contributor License Agreement

@ayushjai30 please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
@microsoft-github-policy-service agree [company="{your company}"]

Options:

(default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.

@microsoft-github-policy-service agree

(when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer.


Heart Disease Prediction

Issue Title : Heart Disease Prediction

Info about the related issue (Aim of the project) : Created a prediction model based on classification algorithms that can be used to predict the likelihood of a heart disease.
[x] SWOC Participant
[x] Contributor

Closes: #40
Describe the add-ons or changes you've made
Added the entire project folder, including Dataset, Images, Model and a requirements file.
Type of change

[x] New feature (non-breaking change which adds functionality)

Checklist:

[x] My code follows the guidelines of this project.
[x] I have performed a self-review of my own code.
[x] I have commented my code, particularly wherever it was hard to understand.
[x] I have made corresponding changes to the documentation.
[x] My changes generate no new warnings.

Good work @shivangisehgal. Keep it up 🎉


Add step execution Telemetry

When debugging a latency increase in our Req clients we found it extremely useful to have the ability to create otel spans around Req step execution. We gain a similar level of granularity by attaching to Finch telemetry, but this helps us visualize everything that is happening in a request not just the connection pool and network bits.
What do you think?

Thank you for the PR. I’d rather not do this by default since it’s easy to do it yourself and you have more flexibility, you can add any measurement and metadata without having to configure it elsewhere. You can do:
People can do: update_in(req.request_steps, &wrap_in_telemetry_span/1)

there is also small but nonzero overhead in emitting each Telemetry event so I’d rather avoid that too.

Hi @wojtekmach. I was wondering if you would consider this req-native telemetetry approach as an opt-in option?
I looked into emitting telemetry from CarReq and while this approach seems OK, I feel like it would be better if the telemetry can from req itself. One small reason is the masking of the step function names in the request struct itself.
Thanks

Could you clarify masking step function names?

Could you clarify masking step function names?

Sure, making the change in car_req:
request_steps: [
    fuse: #Function<2.48640514/1 in CarReq.telemetry_spanner/2>,
    put_user_agent: #Function<2.48640514/1 in CarReq.telemetry_spanner/2>,
    compressed: #Function<2.48640514/1 in CarReq.telemetry_spanner/2>,
    encode_body: #Function<2.48640514/1 in CarReq.telemetry_spanner/2>,

vs in req:
request_steps: [
    put_user_agent: &Req.Steps.put_user_agent/1,
    compressed: &Req.Steps.compressed/1,
    encode_body: &Req.Steps.encode_body/1,
    put_base_url: &Req.Steps.put_base_url/1,

Got it. I could add support for steps as MFArgs:
request_steps: [
  {Req.Steps, :put_user_agent, []},
  {CarReq, :telemetry_spanner, [&Req.Steps.compressed/1]}
]

Otherwise I'd reimplement Req.Request.run_request in CarReq. There's a bit of boilerplate but not too much imo.
What do you think?

I think either suggestion sounds good.
I'll look into the Req.Request.run_request approach first, but I think the MFA support would be good too.
I think the MFA would allow telemetry be added as a plugin, which would be nice. WDYT?

Oh, the step/plugin would basically do: update_in(req.request_steps, &{CarReq, :telemetry_spanner, [&1]} right? Yes that would totally work. The only problem with that however is if there are any steps after this wrapper step (e.g. they have been added since) they wouldn't be wrapped.
There's basically no way to ensure that given step is pinned to be at the end. That's something I'd like to support but not sure about the API. The closest thing at the moment is request.adapter, which is just a step, is guaranteed to be the last request step.
For all these reasons I believe the best choice for you is a custom Req.Request.run_request reimplementation in CarReq.

@ckoch-cars sorry this can totally be a plugin. When we execute update_in(req.request_steps, ...) in a step we're good. Because even if we add more steps down the road, our wrapping step is not executed until we make the request. The only concern is in theory steps can append steps and the latter wouldn't be wrapped. But that's probably an anti pattern.

I have added https://github.com/wojtekmach/req/issues/262 to the backlog.


Add salt to _VoteRevealed event emission args

claimReward in its current implementation requires the user to remember their salt even after revealVote. this PR exposes the user's salt in an event so that in case a user loses their ticket, a UI can recall a voter's salt after they have revealed.
currently a UI can already do this by interpreting the input data of the reveal transaction. however exposing the salt in an event would require less effort on the frontend.

we should .estimateGas in truffle to see if this is worth it

currently: 71320
emit-salt: 71596

@skmgoldin when you have a moment, would you inspect this PR so we can merge this bad boy for the civil team?


Unknown props issue

I have an issue with props. My render method is something like this :
render() {
        const language = this.props.language.default.portal;
        const cars = this.props.cars;
        const favorites = this.props.favorites;
        const cartContent = this.props.cartContent;
        const addToFavorites = this.props.addToFavorites;
        const removeFromCard = this.props.removeFromCard;
        const addToCard = this.props.addToCard;
        const handleOffers = this.props.handleOffers;
        const offers = this.props.offers;
        const currentUserEmail = getUserEmail();

        return (

                        <Shuffle>
                        {cars.map((car, i) => {
                            const initialReg = car.initialRegistration.slice(0,3) + car.initialRegistration.slice(6,10);
                            // str.slice(1, 4) extracts the second character through the fourth character (characters indexed 1, 2, and 3)

                            return (

                                        <PhotoAndFavorites car={car} language={language} changeStarIcon={this.changeStarIcon} addToFavorites={addToFavorites} userEmail={currentUserEmail} favorites={favorites}/>

<Link to="" style={{textDecoration: 'none'}}>{car.make}</Link>

{car.desc}

{car.price}

{car.btw}

 {car.fuel}

 {car.mileage}

 {initialReg}

                                        <Buttons car={car}
                                                 language={language}
                                                 changeButton={this.changeButton}
                                                 addToCard={addToCard}
                                                 removeFromCard={removeFromCard}
                                                 cartContent={cartContent}
                                                 userEmail={currentUserEmail}
                                                 handleChange={handleOffers}
                                                 offers={offers}
                                                 opacity={this.props.opacity}
                                                 />

                            );
                        })}
                        </Shuffle>

        );
    }

But the animation doesn't happening and I'm getting warning
bundle.js:8394 Warning: Unknown props duration, fade, initial on div tag. Remove these props from the element. For details, see https://fb.me/react-unknown-prop

Hi, this issue is fixed by https://github.com/FormidableLabs/react-shuffle/pull/25
Waiting for 2.0.1 bump

My package.json is something like :
"dependencies": {
    "classnames": "^2.2.5",
    "lodash": "^4.13.1",
    "react": "^15.1.0",
    "react-addons-css-transition-group": "^15.3.1",
    "react-dom": "^15.1.0",
    "react-fontawesome": "^1.1.0",
    "react-icons": "^2.2.1",
    "react-redux": "^4.4.5",
    "react-router": "^2.4.1",
    "react-shuffle": "^2.0.0",
    "react-slick": "^0.13.3",
    "react-telephone-input": "^3.4.6",
    "redux": "^3.5.2",
    "redux-thunk": "^2.1.0"
  },
  "devDependencies": {
    "babel-plugin-transform-object-rest-spread": "^6.8.0",
    "babel-preset-es2015": "^6.9.0",
    "babel-preset-react": "^6.5.0",
    "babel-preset-stage-0": "^6.5.0",
    "babelify": "^7.3.0",
    "browserify": "^13.0.1",
    "crypto-js": "^3.1.6",
    "eslint-plugin-react": "^6.2.0",
    "gulp": "^3.9.1",
    "gulp-browserify": "^0.5.1",
    "gulp-concat": "^2.6.0",
    "gulp-connect": "^5.0.0",
    "gulp-eslint": "^3.0.1",
    "gulp-open": "^2.0.0",
    "gulp-sass": "^2.3.1",
    "lodash": "^4.15.0",
    "merge-stream": "^1.0.0",
    "react-addons-css-transition-group": "^15.3.1",
    "reactify": "^1.1.1",
    "vinyl-source-stream": "^1.1.0"
  }

And the render in src/shuffle.js is something like :
render() {
    let { initial, fade, duration, ...props } = this.props;
    var showContainer = initial ? 0 : 1;
    if (this.state.ready) {
      showContainer = 0;
    }
    return (

          {this._childrenWithRefs()}

    );
  }

But the warning still exists.

Any idea why this is not working?

When will this fix available on npm?

@kenwheeler could you publish the module with the new fixes? Thanks.

The lib folder needs to be recompiled, that is all.

If @kenwheeler could publish this. would be fantastic..


[tools] fix Android Studio duplicate detection when installed via Jetbrains Toolbox

Added condition to check if detected Android Studio.app has correct executable and tests to avoid duplicate Android Studio detections when installed via Jetbrains
Pre-launch Checklist

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] I read the Tree Hygiene wiki page, which explains my responsibilities.
[x] I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
[x] I signed the CLA.
[x] I listed at least one issue that this PR fixes in the description above.
[ ] I updated/added relevant documentation (doc comments with ///).
[x] I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt.
[x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@jmagman
Updated the PR and added test, the root of the cause is that, there are two Android Studio.app, one from the launcher and one from apps folder, to avoid launcher app, I have added condition that checks for expected executable string and added test that simulates this exact issue and test passes with one Android Studio being detected (rather than two)

one from the launcher and one from apps folder, to avoid launcher app

Is one a symlink?

@jmagman
Path for launcher app is /Users/tahatesser/Applications/JetBrains Toolbox/Android Studio.app, I am not sure this is a symlink. This app only has launcher resources such as an icon and some metadata that points to  actual location but in flutter_tools, we're treating it as a real Android Studio app since it ends with the same name but this PR avoids that by checking  if the app's info list has an executable studio

Launcher app is only used here and has a size less than 500kb

This app only has launcher resources such as an icon and some metadata that points to actual location but in flutter_tools, we're treating it as a real Android Studio app since it ends with the same name but this PR avoids that by checking if the app's info list has an executable studio

I understand avoiding the placeholder launcher bundle. But why is it duplicated though?

One of them is detected from directories scan, which I fixed and the other one detected from mfind so the array size is increased to two and we get duplicates as a result.
If we comment out directories scan, we only get one detection

One of them is detected from directories scan, which I fixed and the other one detected from mfind so the array size is increased to two and we get duplicates as a result.

I don't think the solution is to peg to a particular executable name since we don't really care about that, and this would break if this ever changed.  What is candidatePaths is made into a Set?

I agree, it looks unnecessary, I have toSet and ==, it does solve the issue however I am not sure what proper changes are needed to make the class immutable so I will close the PR, Appreciate your review, learned a lot from this PR

I agree, it looks unnecessary, I have toSet and ==, it does solve the issue however I am not sure what proper changes are needed to make the class immutable so I will close the PR, Appreciate your review, learned a lot from this PR

I think you were close!  I want to make sure we are fixing the right thing though.  candidatePaths is currently a List<FileSystemEntity> so it doesn't need anything to be immutable.

@jmagman
Applying to toSet to List<FileSystemEntity> doesn't have an impact since both locations are already unique in List (one from the toolbox folder and one from apps)
I confirmed it by printing it before we map this list of AndroidStudio
However when applied toSet to AndroidStudio and add ==, issues are resolved
I want to contribute more and better, so I am going to study the inner workings for a few weeks and then send better PR. I also wanna fix VS Code 2022 issue but not before I completely understand the file system, classes, etc :)

Applying to toSet to List<FileSystemEntity> doesn't have an impact since both locations are already unique in List (one from the toolbox folder and one from apps)

I get it now.  https://github.com/flutter/flutter/issues/86291#issuecomment-899708390

I see the problem. The bundle finder is discovering ~/Applications/JetBrains Toolbox/Android Studio.app and ~/Library/Application Support/JetBrains/Toolbox/apps/AndroidStudio/ch-0/203.7583922/Android Studio.app. The former has its Info.plist JetBrainsToolboxApp is pointing to the latter ~/Library/Application Support/JetBrains/Toolbox/apps/AndroidStudio/ch-0/203.7583922/Android Studio.app. The latter does not have a JetBrainsToolboxApp in its Info.plist
So the path discovery logic works as of the addition of #80475, but the AndroidStudio.fromMacOSBundle(e.path) is finding both.

I want to contribute more and better, so I am going to study the inner workings for a few weeks and then send better PR.

Awesome!  Instead of dealing with sets, I think we can instead get rid of the logic that parses that Info.plist file to follow the JetBrainsToolboxApp path since as of #80475 it already handles finding the "real" Android Studio via Spotlight.
A way to do this would be to change https://github.com/flutter/flutter/blob/f9aa5842c285686fc553976e68d60f4351963191/packages/flutter_tools/lib/src/android/android_studio.dart#L319-L322 to:
    return candidatePaths
        .map<AndroidStudio?>((FileSystemEntity e) => AndroidStudio.fromMacOSBundle(e.path))
        .whereType<AndroidStudio>()
        .toList();

and https://github.com/flutter/flutter/blob/f9aa5842c285686fc553976e68d60f4351963191/packages/flutter_tools/lib/src/android/android_studio.dart#L43-L54 to
  static AndroidStudio? fromMacOSBundle(String bundlePath) {
    final String studioPath = globals.fs.path.join(bundlePath, 'Contents');
    final String plistFile = globals.fs.path.join(studioPath, 'Info.plist');
    final Map<String, dynamic> plistValues = globals.plistParser.parseFile(plistFile);
    // As AndroidStudio managed by JetBrainsToolbox could have a wrapper pointing to the real Android Studio.
    // If we've found a JetBrainsToolbox wrapper, ignore it.
    if (plistValues.containsKey('JetBrainsToolboxApp')) {
      return null;
    }

Writing tests for this left as an exercise to the reader.  😄
Let me know if you need any help!

@jmagman
I would like to work on it, file a new PR by tomorrow. I really appreciate your time


Reduce excessive calls to /totals

Checklist

[x] Manual verification
[ ] Unit test coverage
[ ] E2E test coverage
[x] Needs manual QA?

Summary
Issue addressed:
Notion page
Details:
This PR applies TanStack Query's enabled flag to each /totals request. We ensure that we only submit a request once the dashboard's time range and filters have been set.
Most significantly, if we issue the request without a time range, the backend will assume the query applies to the all time range. Querying the all time range locks up a Druid cluster.
Steps to Verify

Open a dashboard
Open your browser devtools
Go to the Network tab
Filter for /totals
Refresh the dashboard page and observe 1 request to /totals and that request has a specified time range. Previously, there were 4 requests to /totals, some of which did not have a specified time range.

Dang, you're right, I'm seeing a redundant call as well. It seems to happen about 25-50% of the time, and only for custom time ranges. Where you see 3 calls, I believe you have comparisons enabled, which should trigger 2 calls to totals, so you're seeing n+1 requests.
Based on the call stack of the redundant request, it looks to be deriving from the TimeControls.svelte file. Because of the complexity in that file, it's a bigger project to track this down.
Given it's complex, somewhat of an edge case, and this PR accomplishes its main goal of reducing requests without a time range, I propose we merge this as is. Does that work?

Yes I agree, lets not let perfect be the enemy of good. Lets merge it


fixes template usage

terraform template_file is deprecated. the plugin does not have a version for arm64 (apple silicon macs). this pr updates terraform usage so kubitect can be run on apple silicon macs again
https://registry.terraform.io/providers/hashicorp/template/latest/docs#deprecation

LGTM, thanks


Webcam.freeze() doesn't work?

Hi,
I'm using this plugin for almost 8 months, however since 2 weeks ago the Webcam.freeze() doesn't work anymore. I haven't changed anything in my server side or client side code but I don't understand why this is happening?
For your information, when I click on take snapshot which is the same as Freeze, it doesn't freeze but when I save the image, it saves that frozen image. I need to make that Freeze visible so the user knows that the webcam has been frozen so they can decide whether to save it or take another.
Checklist (All browsers below are running on the latest updates):

Chrome (not working)

Opera (not working)

Firefox (not working)

MS Edge (Working)

IE 11 (Working)

Any help would be appreciated.
Best,
Alex

Hey @AlexMVC,
I haven't changed anything that would have broken the freeze system.  The freeze demo also works fine for me in all browsers:
https://pixlcore.com/demos/webcamjs/demos/preview.html
Can you try that demo page and let me know if it works for you?  Perhaps there is something in your client application that is interfering with Webcam.JS.  What version of Webcam.JS are you using?
It would really help me if you could create a reproducible case as a standalone HTML file that I can test from here.  I can't see your code, so I can't troubleshoot the issue.
Thanks.
- Joe

@jhuckaby thank you for the quick response. I'm using the latest version of WebcamJS and I also tested the freeze on your demo and it's working fine.
I don't see any console error and that makes me confused because I haven't changed anything on client side.
Please see my HTML file. I'm using ASP.NET MVC
https://gist.github.com/AlexMVC/68c5ecf970540c82924d5c297f873d5f
Thanks,
Alex

Hey @AlexMVC,
Apologies, but I cannot run your ASP.NET MVC code.  What I need is a standalone HTML page where the bug is reproducible.  Is it possible for you to create this?
You could also try downgrading to an older version of Webcam.JS and see if that helps.
- Joe

Hello @jhuckaby
HTML: https://gist.github.com/AlexMVC/68c5ecf970540c82924d5c297f873d5f
I actually upgraded the WebcamJS today because of this issue. I had the same experience with the previous versions.
How is that possible that IE and Edge respond properly but not the other ones?
Best,
Alex

I'm so sorry, but I still can't troubleshoot your HTML.  You see, it won't run on it's own.  For example, it looks like you're using some kind of modal dialog library that loads WebcamJS in a floating dialog:
$('#flex_modal').on('shown.bs.modal', function (e) {

I don't have the code to run this, and it isn't included in the page.  Your HTML is also missing the SCRIPT tag to even load WebcamJS.  What you've given me is a partial HTML snippet, extracted from your ASP.NET application.  What I actually need is a complete, running standalone HTML page that I can click and it loads WebcamJS, and displays the freeze bug.
If I cannot reproduce the bug from here, I cannot troubleshoot it.
I have no idea why IE / Edge are working for you but the other browsers are not.
Sorry!

@jhuckaby  my application is currently running from localhost as it's in production stage. I'm using the regular Bootstrap modal. It's partial because I'm using Master Page and main layout is coming from different source/folder.
Thanks, I will try to find a solution.

@jhuckaby  Hello, I've created a new HTML file. Even on this stand-alone test I'm not able to Freeze the cam.
https://gist.github.com/AlexMVC/68c5ecf970540c82924d5c297f873d5f
Thanks

@jhuckaby I tested my application and above html on another laptop and webcam and it behaves the same.

You have to match the height of the device capture (dest_height) with the crop_height.  Meaning, one of the two dimensions has to match, either width or height, so it can do a proper crop out of the center.  So change crop_width and crop_height both to 720 to match the dest_height:
crop_width: 720,
crop_height: 720,

OR, I think you can change the device capture (dest_height) to 700 to match your existing crop size of 700.  However, 700 is a non-standard size, so I'd recommend you stick with 720 to be compatible with more webcams.
Working demo here:
https://pixlcore.com/demos/webcamjs/demos/alex.html
I have no idea why this suddenly stopped working for you.  I believe there was always a bug (feature?) where the crop size has to match one of the two dimensions of the device capture size.

@jhuckaby Hi, you're right. After changing the height to 720 everything started to function.
I'm also wondering how and why it suddenly stopped working. Maybe this information should be visible on your website so others can be aware of this issue.
Thanks Joseph

Hey @AlexMVC,
Yeah, you're right, that is a really odd thing, and I do want to get to the bottom of it.  I think it's a bug, because you should be able to crop the image to any dimensions, regardless of the device capture size.  If I can't fix the bug, I will put a note in the docs about this.
Very sorry you ran into it.  I'll leave this issue open until I resolve it via bug fix or docs.

@jhuckaby you should check out the iOS part, auto scale and crop (line 362), because based on our tests it should properly crop and auto scale the image as independent from the original size of the picture. Maybe you can reuse this algorithm to solve this issue.

Thanks, I'll check it out!


Token data is not being updated after edit account flow

Core Library
MSAL.js v2 (@azure/msal-browser)
Core Library Version
2.22.1
Wrapper Library
MSAL React (@azure/msal-react)
Wrapper Library Version
1.3.1
Description
We're trying to implement an edit account feature in our application but we're encountering a problem with the edit account flow. When user has ended the flow and the SSO returns the user to the application the account is not being updated, the user needs to sign-out and sign-in again to get the updated data.
Error Message
No error message is received
Msal Logs

MSAL Configuration
{
		clientId: '2fdd06f3-7b34-49a3-a78b-0cf1dd87878e',
		authority: b2cPolicies.authorities.signUpSignIn.authority,
		knownAuthorities: [b2cPolicies.authorityDomain],
		redirectUri: 'http://localhost:3000',
	},
	cache: {
		cacheLocation: 'localStorage',
	},
	system: {
		loggerOptions: {
			loggerCallback: (level, message, containsPii) => {
				if (containsPii) {
					return;
				}
				// eslint-disable-next-line default-case
				switch (level) {
					case LogLevel.Error:
						// eslint-disable-next-line no-console
						console.error(message);
						return;
					case LogLevel.Info:
						// eslint-disable-next-line no-console
						console.info(message);
						return;
					case LogLevel.Verbose:
						// eslint-disable-next-line no-console
						console.debug(message);
						return;
					case LogLevel.Warning:
						// eslint-disable-next-line no-console
						console.warn(message);
				}
			},
		},
	},
}

Relevant Code Snippets
// Here's how I'm getting the token into a useEffect in our AuthContext

useEffect(() => {
		if (accounts.length === 0) {
			return false;
		}

		console.log(accounts);
		const account = accounts[0];
		const authority = b2cPolicies.authorities.signUpSignIn.authority;

		if (accounts.length > 0) {
			instance
				.acquireTokenSilent({
					authority,
					scopes: loginRequest.scopes,
					account,
					forceRefresh: true,
				})
				.then(response => {
					if (response) {
						setUser({
							...account.idTokenClaims,
							token: response.accessToken,
						});
						setOnHeadersAndLocalStorage(response.accessToken);
					}
				})
				.catch(err => {
					if (err instanceof InteractionRequiredAuthError) {
						const request = {
							authority,
							scopes: loginRequest.scopes,
							prompt: 'login',
						};
						return instance.acquireTokenRedirect(request);
					}
					throw Error(err);
				});
		}
	}, [accounts, instance]);

Reproduction Steps

Click on Edit Account button
Edit account data and save
SSO returns the user to the application and the old data is shown

Expected Behavior

Click on Edit Account button
Edit account data and save
SSO returns the user to the application and the new data is shown

Identity Provider
Azure B2C Custom Policy
Browsers Affected (Select all that apply)
Chrome, Firefox, Edge
Regression
No response
Source
External (Customer)

I've uploaded a sample project so anyone can reproduce the problem.
https://github.com/ranzolinrafa/sample-sso-azure-b2c-react

Are you experiencing something similar to this https://github.com/AzureAD/microsoft-authentication-library-for-js/issues/4411 ?
If so, we are looking into it.

I'm closing this issue since there is another already in progress.
https://github.com/AzureAD/microsoft-authentication-library-for-js/issues/4411


Build error Could not find method implementation() for arguments...

I get gradle build error after upgrading libraries
* Where:
Build file '.../node_modules/react-native-i18n/android/build.gradle' line: 31

* What went wrong:
A problem occurred evaluating project ':react-native-I18n'.
> Could not find method implementation() for arguments [com.facebook.react:react-native:+] on object of type org.gradle.api.internal.artifacts.dsl.dependencies.DefaultDependencyHandler.

package versions:
"react": "16.4.1"
"react-native": "0.56.0"
"react-native-i18n": "^2.0.14"
ext values in my project android/build.gradle
ext {
    buildToolsVersion = "26.0.3"
    minSdkVersion = 16
    compileSdkVersion = 26
    targetSdkVersion = 26
    supportLibVersion = "26.1.0"
}

upgrading gradle helped, changes I made
/android/build.gradle
buildscript {
    repositories {
        jcenter()
        google() //added this
        maven {
            url 'https://maven.google.com/'
            name 'Google'
        }
    }
    dependencies {
        classpath 'com.android.tools.build:gradle:3.0.1' //changed version

        // NOTE: Do not place your application dependencies here; they belong
        // in the individual module build.gradle files
    }
}
...

/android/gradle/wraper/gradle-wrapper.properties
distributionBase=GRADLE_USER_HOME
distributionPath=wrapper/dists
zipStoreBase=GRADLE_USER_HOME
zipStorePath=wrapper/dists
distributionUrl=https\://services.gradle.org/distributions/gradle-4.1-all.zip //changed version

Upgrading my gradle version to the same as yours causes an aapt crash when building my app 😕

I think the cause is some different library, I know it happened to me in some projects and only solution I found was disabling it by adding android.enableAapt2=false to android/gradle.properties

I misunderstood your issue, it happened to me during build project too. Found this issue suggesting to add to android/build.gradle:
subprojects {
     afterEvaluate {
         project -> if (project.hasProperty("android")) {
             android {
                 compileSdkVersion 26
                buildToolsVersion '26.0.2'
             }
         }
     }
 }

that worked for me, hope nothing broke in app

I got this problem too :sad:

This started to happen in my project as well. I am running 2.0.12 and suddenly the project does not build in AppCenter with the error mentioned in the first post. I have not made any change at all to my project...

I've created PR for this. I don't think users should be forced to bump their project gradle version, also when the docs don't mention it.

I had the same issue with 2.0.14 version. Downgrading react-native-i18n to 2.0.12 fixed the issue.

Same problem

I revert the breaking changes and publish the version 2.0.15. Sorry for the caused issues.
I will try to find time to update https://github.com/react-community/react-native-languages this weekend (using semver, so 3.0.0 will be for RN >=0.56, 2.0.0 for RN <=0.55) and to deprecate this package + write a "switch dependency" guide. It's literally 3 lines of JavaScript.
react-native-languages is not tied to a particular intl lib, so you'll can continue to use i18n-js, but also i18next, react-intl or else if you want.

upgrading gradle helped, changes I made
/android/build.gradle
buildscript {
    repositories {
        jcenter()
        google() //added this
        maven {
            url 'https://maven.google.com/'
            name 'Google'
        }
    }
    dependencies {
        classpath 'com.android.tools.build:gradle:3.0.1' //changed version

        // NOTE: Do not place your application dependencies here; they belong
        // in the individual module build.gradle files
    }
}
...

/android/gradle/wraper/gradle-wrapper.properties
distributionBase=GRADLE_USER_HJS server already running.

Building and installing the app on the device (cd android && gradlew.bat installDebug)...
Exception in thread "main" java.lang.RuntimeException: Could not load wrapper properties from 'C:\Users\CR-27\creatise\clap\android\gradle\wrapper\gradle-wrapper.properties'.
at org.gradle.wrapper.WrapperExecutor.(WrapperExecutor.java:62)
at org.gradle.wrapper.WrapperExecutor.forWrapperPropertiesFile(WrapperExecutor.java:46)
at org.gradle.wrapper.GradleWrapperMain.main(GradleWrapperMain.java:60)
Caused by: java.net.URISyntaxException: Illegal character in path at index 60: https://services.gradle.org/distributions/gradle-4.1-all.zip
at java.net.URI$Parser.fail(URI.java:2848)
at java.net.URI$Parser.checkChars(URI.java:3021)
at java.net.URI$Parser.parseHierarchical(URI.java:3105)
at java.net.URI$Parser.parse(URI.java:3053)
at java.net.URI.(URI.java:588)
at org.gradle.wrapper.WrapperExecutor.readDistroUrl(WrapperExecutor.java:79)
at org.gradle.wrapper.WrapperExecutor.prepareDistributionUri(WrapperExecutor.java:68)
at org.gradle.wrapper.WrapperExecutor.(WrapperExecutor.java:56)
... 2 moreOME

distributionPath=wrapper/dists
zipStoreBase=GRADLE_USER_HOME
zipStorePath=wrapper/dists
distributionUrl=https://services.gradle.org/distributions/gradle-4.1-all.zip //changed version

its not work for me getting error like

Upgrading my gradle version to the same as yours causes an aapt crash when building my app 😕

Even m facing same issue.

Even m facing same issue.


[Event Request] codeunit 5760 "Whse.-Post Receipt"- OnBeforePostSourceDocumentPurchPost

Hi, in the codeunit 5760 "Whse.-Post Receipt", would it be possible to get an event OnBeforePostSourceDocumentPurchPost, like this :

   local procedure PostSourceDocument(WhseRcptLine: Record "Warehouse Receipt Line")
    var
        WhseSetup: Record "Warehouse Setup";
        WhseRcptHeader: Record "Warehouse Receipt Header";
        PurchPost: Codeunit "Purch.-Post";
        SalesPost: Codeunit "Sales-Post";
        TransferPostReceipt: Codeunit "TransferOrder-Post Receipt";
        IsHandled: Boolean;
    begin
        WhseSetup.Get();
        with WhseRcptLine do begin
            WhseRcptHeader.Get("No.");
            case "Source Type" of
                DATABASE::"Purchase Line":
                    begin
                        if "Source Document" = "Source Document"::"Purchase Order" then
                            PurchHeader.Receive := true
                        else
                            PurchHeader.Ship := true;
                        PurchHeader.Invoice := false;

                        PurchPost.SetWhseRcptHeader(WhseRcptHeader);
                        case WhseSetup."Receipt Posting Policy" of
                            WhseSetup."Receipt Posting Policy"::"Posting errors are not processed":
                                PostPurchErrorsNotProcessed(PurchPost);
                            WhseSetup."Receipt Posting Policy"::"Stop and show the first posting error":
                                begin
                                    IsHandled:= false;
                                    OnBeforePostSourceDocumentPurchPost(PurchPost, IsHandled);
                                    if not IsHandled then
                                    PurchPost.Run(PurchHeader);
                                    CounterSourceDocOK := CounterSourceDocOK + 1;
                                end;
                        end;
                        OnPostSourceDocumentOnAfterPostPurchaseHeader(PurchHeader);
                        Clear(PurchPost);
                    end;

    [IntegrationEvent(false, false)]
    local procedure OnBeforePostSourceDocumentPurchPost(var PurchPost: Codeunit "Purch.-Post"; var IsHandled: Boolean)
    begin
    end;

Thanks

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. We will update this issue with information about availability. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. We will update this issue with information about availability. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.


Read buffer size always

read buffer sizes

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 50s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:

0m  0s
test4tests
The patch appears to include 3 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
32m 47s

trunk passed

+1 :green_heart:
compile
0m 34s

trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1

+1 :green_heart:
compile
0m 33s

trunk passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

+1 :green_heart:
checkstyle
0m 24s

trunk passed

+1 :green_heart:
mvnsite
0m 36s

trunk passed

+1 :green_heart:
shadedclient
17m 34s

branch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
0m 36s

trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1

+1 :green_heart:
javadoc
0m 31s

trunk passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

+0 :ok:
spotbugs
1m 12s

Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
1m  9s

trunk passed

_ Patch Compile Tests _

-1 :x:
mvninstall
0m 30s
/patch-mvninstall-hadoop-tools_hadoop-azure.txt
hadoop-azure in the patch failed.

-1 :x:
compile
0m 35s
/patch-compile-hadoop-tools_hadoop-azure-jdkUbuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.txt
hadoop-azure in the patch failed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.

-1 :x:
javac
0m 35s
/patch-compile-hadoop-tools_hadoop-azure-jdkUbuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.txt
hadoop-azure in the patch failed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.

-1 :x:
compile
0m 31s
/patch-compile-hadoop-tools_hadoop-azure-jdkPrivateBuild-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01.txt
hadoop-azure in the patch failed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01.

-1 :x:
javac
0m 31s
/patch-compile-hadoop-tools_hadoop-azure-jdkPrivateBuild-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01.txt
hadoop-azure in the patch failed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01.

-0 :warning:
checkstyle
0m 20s
/diff-checkstyle-hadoop-tools_hadoop-azure.txt
hadoop-tools/hadoop-azure: The patch generated 23 new + 4 unchanged - 0 fixed = 27 total (was 4)

-1 :x:
mvnsite
0m 30s
/patch-mvnsite-hadoop-tools_hadoop-azure.txt
hadoop-azure in the patch failed.

+1 :green_heart:
whitespace
0m  0s

The patch has no whitespace issues.

+1 :green_heart:
shadedclient
15m 43s

patch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
0m 26s

the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1

+1 :green_heart:
javadoc
0m 24s

the patch passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

-1 :x:
findbugs
0m 30s
/patch-findbugs-hadoop-tools_hadoop-azure.txt
hadoop-azure in the patch failed.

_ Other Tests _

-1 :x:
unit
0m 29s
/patch-unit-hadoop-tools_hadoop-azure.txt
hadoop-azure in the patch failed.

+1 :green_heart:
asflicense
0m 33s

The patch does not generate ASF License warnings.

78m 24s

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2362/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2362

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux dad1ce60d6cb 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 6ece6407e18

Default Java
Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2362/1/testReport/

Max. process+thread count
414 (vs. ulimit of 5500)

modules
C: hadoop-tools/hadoop-azure U: hadoop-tools/hadoop-azure

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2362/1/console

versions
git=2.17.1 maven=3.6.0 findbugs=4.0.6

Powered by
Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
1m 52s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:

0m  0s
test4tests
The patch appears to include 3 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
44m 34s

trunk passed

+1 :green_heart:
compile
1m  3s

trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1

+1 :green_heart:
compile
0m 53s

trunk passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

+1 :green_heart:
checkstyle
0m 35s

trunk passed

+1 :green_heart:
mvnsite
1m  4s

trunk passed

+1 :green_heart:
shadedclient
23m 28s

branch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
0m 48s

trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1

+1 :green_heart:
javadoc
0m 46s

trunk passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

+0 :ok:
spotbugs
1m 46s

Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
1m 43s

trunk passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 53s

the patch passed

+1 :green_heart:
compile
0m 46s

the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1

+1 :green_heart:
javac
0m 46s

the patch passed

+1 :green_heart:
compile
0m 38s

the patch passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

+1 :green_heart:
javac
0m 38s

the patch passed

-0 :warning:
checkstyle
0m 23s
/diff-checkstyle-hadoop-tools_hadoop-azure.txt
hadoop-tools/hadoop-azure: The patch generated 22 new + 4 unchanged - 0 fixed = 26 total (was 4)

+1 :green_heart:
mvnsite
0m 44s

the patch passed

+1 :green_heart:
whitespace
0m  0s

The patch has no whitespace issues.

+1 :green_heart:
shadedclient
21m 46s

patch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
0m 44s

the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1

+1 :green_heart:
javadoc
0m 36s

the patch passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

-1 :x:
findbugs
2m  6s
/new-findbugs-hadoop-tools_hadoop-azure.html
hadoop-tools/hadoop-azure generated 5 new + 0 unchanged - 0 fixed = 5 total (was 0)

_ Other Tests _

-1 :x:
unit
1m 58s
/patch-unit-hadoop-tools_hadoop-azure.txt
hadoop-azure in the patch passed.

+1 :green_heart:
asflicense
0m 48s

The patch does not generate ASF License warnings.

111m 30s

Reason
Tests

FindBugs
module:hadoop-tools/hadoop-azure

Write to static field org.apache.hadoop.fs.azurebfs.services.AbfsInputStream.READ_AHEAD_BLOCK_SIZE from instance method new org.apache.hadoop.fs.azurebfs.services.AbfsInputStream(AbfsClient, FileSystem$Statistics, String, long, AbfsInputStreamContext, String)  At AbfsInputStream.java:from instance method new org.apache.hadoop.fs.azurebfs.services.AbfsInputStream(AbfsClient, FileSystem$Statistics, String, long, AbfsInputStreamContext, String)  At AbfsInputStream.java:[line 99]

Dead store to thresholdAgeMilliseconds in org.apache.hadoop.fs.azurebfs.services.ReadBufferManager.testResetReadBufferManager(int, int)  At ReadBufferManager.java:org.apache.hadoop.fs.azurebfs.services.ReadBufferManager.testResetReadBufferManager(int, int)  At ReadBufferManager.java:[line 515]

Self assignment of thresholdAgeMilliseconds rather than assigned to field in org.apache.hadoop.fs.azurebfs.services.ReadBufferManager.testResetReadBufferManager(int, int)  At ReadBufferManager.java:than assigned to field in org.apache.hadoop.fs.azurebfs.services.ReadBufferManager.testResetReadBufferManager(int, int)  At ReadBufferManager.java:[line 515]

Write to static field org.apache.hadoop.fs.azurebfs.services.ReadBufferManager.BLOCK_SIZE from instance method org.apache.hadoop.fs.azurebfs.services.ReadBufferManager.testResetReadBufferManager(int, int)  At ReadBufferManager.java:from instance method org.apache.hadoop.fs.azurebfs.services.ReadBufferManager.testResetReadBufferManager(int, int)  At ReadBufferManager.java:[line 514]

Write to static field org.apache.hadoop.fs.azurebfs.services.ReadBufferManager.BUFFER_MANAGER from instance method org.apache.hadoop.fs.azurebfs.services.ReadBufferManager.testResetReadBufferManager()  At ReadBufferManager.java:from instance method org.apache.hadoop.fs.azurebfs.services.ReadBufferManager.testResetReadBufferManager()  At ReadBufferManager.java:[line 507]

Failed junit tests
hadoop.fs.azure.TestClientThrottlingAnalyzer

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2362/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2362

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux 5299b8ebfaf6 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 6ece6407e18

Default Java
Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2362/2/testReport/

Max. process+thread count
366 (vs. ulimit of 5500)

modules
C: hadoop-tools/hadoop-azure U: hadoop-tools/hadoop-azure

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2362/2/console

versions
git=2.17.1 maven=3.6.0 findbugs=4.0.6

Powered by
Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.


Release to pypi

Hi,
Do you plan to release django-cas to pypi?

Probably not.  This CAS setup has some fairly specific implementations.  There are also a multitude of other CAS libraries available on Pypi and we don't want to flood it with multiple libraries.  That being said, if there is a strong support for it, we'll consider it.

Thanks for the heads up.

Version 1.0.0 which was what is currently in master has been released on pypi.  I'll document more on this later.
https://pypi.python.org/pypi/django-cas-client/1.0.0


can preload images with authentication?

@glennmichaelmejias Sorry I cant understand your issue. Also as mentioned in the description:
NOTE: This is not an alternative to webview packages. This package only deals with text.

So, I'm going to close this issue. But feel free to reopen it if you can provide more info.


Enable defining and running tests inside same Scala file

Is your feature request related to a problem? Please describe.
Languages such as Rust enable you to define tests (usually unit tests) together with the code one is testing. This is useful and a productivity booster:

It allows readers to see how an API is immediately used and what tests are present; and,
It allows writers to avoid the tax to create an independent test file for everything you want to test and benefit from the locality of having the tests right next to the tested source.

All in all, the following a.scala source should be valid:
//> using scala "3.1"
//> using lib "org.scalameta::munit::0.7.27"

class NumAPI:
  def foo(): Int = 3

class NumAPISpec extends munit.FunSuite:
  test("check foo returns 3") {
    assertEquals(NumAPI().foo(), 3)
  }

Describe the solution you'd like
scala-cli could enable us to define and run tests in the same source code. This would involve making scala-cli test a.scala compile and run the tests defined in a.scala, regardless of whether //> using target.scope "test" has been defined or not.
Additional context
Here's a few design considerations to take into account just from the user and semantics POV (not discussing implementation details).
Should test code defined in a.scala be available/importable (when https://github.com/VirtusLab/scala-cli/issues/948 is implemented)? I don't think it should. Tests defined with the tested code should be treated as private. The benefit of this is that we can also drop the test dependencies from being depended on.
What should we do with test dependencies? The unit tests might need to import additional test dependencies aside from the test framework. We should have a way that these test dependencies are not leaked to the classpath of other modules depending on the source.

I like this idea.
Implementation-wise, I think we would likely compile everything together (main scope + tests), then split things in a second time. So we would have to:

split test-specific classes from the rest (test suites, that we can detect like the test command does, would automatically go in the test scope, plus… maybe classes with a specific annotation, like @scala.testOnly, would be put there too)
check that no class in the main scope references a class in the test scope
split transitive dependencies (resulting in main ones and test ones), and maybe warn if some dependencies in the main scope were bumped by dependencies in test
check that no class in the main scope references test-specific dependencies

@antholeole if you're indeed interested in implementing this, let me know if you need any help with setting up.
I think having this would be cool, Markdown sources could also benefit from this.

I'll break ground on this when I get free time - if it's blocking anyone I can try to prioritize this

Sat down to get started on this today and it seems the request is actually working more or less without any modification?
//> using dep "org.scalameta::munit::0.7.29"

object NumAPI:
  def foo(): Int = 4

  @main
  def main() = print(foo())

class NumAPISpec extends munit.FunSuite:
  test("check foo returns 3") {
    assertEquals(NumAPI.foo(), 3)
  }

scala-cli test foo.scala runs the test in the source; scala-cli foo.scala runs the main block, as the RFC requested. Not sure if this is intended behavior (in the sense that someone wrote it for this purpose) but it does what I want it to. I think this is enough for my use case, so I will unassign this from myself.

Are you fine with test dependencies polluting the classpath?


Docker container with OpenBGPD portable?

When I started the rpki-client Docker container, I also played around with OpenBGPD in a container for testing purposes (but never finished it). During my Easter holidays I decided to get rid of the half finished bits on my disk, did the remaining work and published it. Now I wonder if you're interested in getting openbgpd-container transferred into your openbgpd-portable GitHub organisation. I would continue the maintenance of course (fortunately most OpenBGPD changes are internally, but not relevant for packaging etc. which makes it quite easy for me to maintain it), like I do for rpki-client already.

Thank you very much! Unfortunately I've most likely killed my granted owner permissions when just transferring my existing repository to the "openbgpd-portable" namespace (I chose to transfer rather to import to keep the stored secrets, workflow settinsg etc.), because I no longer can access the settings of the "openbgpd-container" repository. Other than that the transfer worked absolutely fine. May I kindly ask you to apply the permissions again? And again, thank you!

No worries, thanks for all your work. I changed you role to admin for "openbgpd-container". Lets see if that was enough.

Yes, now it looks like before! Thanks :)


support JGI and EMSL project identifiers that aren't CURIES registered with identifiers.org

We have use cases from JGI, EMSL and external projects where we need to point to data/projects/analysis where the base url is not registered as a CURIE with identifiers.org
JGI genome portal proposal link (where JGI proposal ID is 502930)
https://genome.jgi.doe.gov/portal/lookup?keyName=proposalId&keyValue=502930&groupOnly=1&app=Info, this resolves to https://genome.jgi.doe.gov/portal/BioDefcarcycling/BioDefcarcycling.info.html
This is an example of a possible valid slot for a JGI genome portal proposal, analogous to GOLD study, url.
https://github.com/microbiomedata/nmdc-schema/blob/jgi_genome_portal_id/src/data/valid/Study-genome_portal_identifiers.yaml
Processed metabolomics data in GNPS
https://gnps.ucsd.edu/ProteoSAFe/status.jsp?task=4b848c342a4f4abc871bdf8a09a60807
EMSL examples
study example https://www.emsl.pnnl.gov/project/60141
samples and data https://search.emsl.pnnl.gov/?project_id_search=60141
cc @mslarae13
As a starting point we could focus how to do this for class Study. The JGI genome portal schema support is important for the upcoming bioscales publication since the paper cites some data that aren't in GOLD.

Here is the SOP
To go:
https://github.com/biopragmatics/bioregistry/issues/new/choose
Fill in the fields as best you can. Ideally rearrange the order of http params so the local ID comes last, e.g.
https://genome.jgi.doe.gov/portal/lookup?keyName=proposalId&groupOnly=1&app=Info&keyValue=$1
I suggest the following prefixes:

jgi.proposal
emsl.study
gnps

Here is an example of how you could fill this in for jgi.proposal

prefix jgi.proposal
regex ^\d+
local id: 502930
URI format string: https://genome.jgi.doe.gov/portal/lookup?keyName=proposalId&groupOnly=1&app=Info&keyValue=$1

I recommend tagging the person in charge of the JGI proposal database that we are doing this, same for others

Feedback from Ming on prefixes
gnps.task: # these are analyses
gnps.library: # these are collections of spectra that are reference data
gnps.libraryentry: # these are individual MS/MS spectra that are part of libraries

https://github.com/biopragmatics/bioregistry/issues/833

Chris and I got the gnps.task and emsl.project prefixes into the Bioregistry in https://github.com/biopragmatics/bioregistry/pull/836 and https://github.com/biopragmatics/bioregistry/pull/834, respectively. These will be available momentarily (following database rebuild and re-deploy) at https://bioregistry.io/gnps.task and https://bioregistry.io/emsl.project

Anyone who is interested to add more prefixes to the Bioregistry can feel free to reach out to me directly or open an issue on the tracker like Chris mentioned

@mslarae13  what is your suggested prefix for the 'samples and data' search? https://search.emsl.pnnl.gov/?project_id_search=60141

I think that is the same object, it's a study, so no need for a separate prefix. You could register this as a separate resolver for a study but I don't think it's necessary as the samples are linked from the study page

This is actively being worked on, once the curies are registered we'll need schema slots for these. I'll update my branch with valid data based on the newly defined curies.

OK, we have all 3 categories - I think we can close this now?

I'd like to discuss this at the 1pm sync today (05/24)
@cmungall , @aclum

Can we try and make a slide deck that explains the workflow that happened here?
I'd like to get a conceptual overview of what happened here, both 1) for people working on LinkML projects and 2) to have a high-level use case that we can communicate for the utility of the Bioregistry.
Specifically, I think it would be great to summarize:

How does a project using LinkML determine it needs a new prefix
How does a project request a new prefix (okay, I know how this works ;))
What does the project do after the new prefixes are available?

can someone work with me to make a brief slide deck or google doc describing this? I guess this would also be useful to include as a tutorial in the LinkML documentation, right?

@turbomam can you update range for gnps_identifiers to be curie instead of string?

I just changed all alternative_identifiers to have a uriorcurie range in src/schema/basic_slots.yaml. I'm rebuilding and testing now. I got an error and am invesitgating.
We may also want to apply a pattern constraint
We should check for how those propagate to sub-properties. I have seen some attributes of id not get propagated, but that may have been though some convoluted paths.
I feel like @sujaypatil96 proposed doing the same thing I'm doing now, but we hesitated to merge the PR. I'll try to dig that up now.

Note to self

I'm going to move the emsl study identifiers to a different ticket since that requires further discussion.


Add Hosting section

Closes #155
This pull request addresses two changes: it corrects the improper padding of the title in the #Home section in the mobile view and adds a Hosting section to the sidebar.
Padding issue of Home section:
Screenshots
Previously it looked like

Currently it looks like this

Hosting Section:
Added Hosting section in the sidebar
This section encompasses two sub-categories:

resources for hosting static websites
resources for hosting server-side websites.
The changes are depicted in the provided screenshots.

Screenshots

This is my first pull request so any kind of feedback would be helpful.

Ok

Ok

Yeah, also remove the commits from this PR


[WIP] - Use CSV header converters

In the Importer classes (Service, Interaction, ServiceInteraction), we previously converted some header names to more readable names (such as "Mapped identifier" -> :lgil_code). This forced another level of indirection for imported CSV rows, having to call the parsed_hash method on a row first before it could get passed to the create_or_update_method.
This commit makes use of the CSV library's support for converters, so we can pass a hash of conversions to the CsvDownloader class, and the conversions are applied as the CSV rows are imported. This helps to declutter the Importer classes, makes the CsvDownloader (rightfully) responsible for the conversions and makes the tests more readable.

I like this.  Getting rid of the parsed_hash method feels like a big improvement.

Thank you @h-lame for the comments, have addressed and rebased. I've also made the 'field_name_conversion` hash into a constant for each Importer class.

Changes look good to me.  Merging.


mention maintainers

Very ugly hack in before https://github.com/NixOS/nixpkgs/pull/34842

Thanks!


pppd: 2.5.0 -> 2.5.1

As there are no maintainers, I guess I'll eventually merge this myself.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[x] sandbox = true

[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

OK sorry will retarget for staging.
I do not want to break too many things, and the package looks both reasonable and readable, so I am not sure what is even worth trying to remove.


Add ViT export support and image classification

What does this PR do?
Export

CLI

optimum-cli export neuron --model facebook/deit-base-patch16-224 --batch_size 1 --task image-classification vit_neuron/

API

import requests
from PIL import Image
from transformers import AutoImageProcessor
from optimum.neuron import NeuronModelForImageClassification

# Create the feature extractor and model
model_id = "facebook/deit-base-patch16-224"
feature_extractor = AutoImageProcessor.from_pretrained(model_id)
model = NeuronModelForImageClassification.from_pretrained(model_id, export=True, batch_size=1)
save_directory = "vit_neuron"
model.save_pretrained(save_directory)

Before submitting

[ ] This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
[ ] Did you make sure to update the documentation with your changes?
[ ] Did you write any new necessary tests?

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.


Implementing various models

To implement several sets of equations (barotropic vorticity equation, shallow water equations, primitive equations) one could define
BaroptropicModel <: ModelSetup
ShallowWaterModel <: ModelSetup
PrimitiveEquationModel <: ModelSetup

and then dispatch to functions like
function get_tendencies(...,M::BarotropicModel) = ...
function get_tendencies(...,M::ShallowWaterModel) = ...

where ever functions should do something different and otherwise
function leapfrog(...,M::ModelSetup) = ...

when they are the same. That would be a Julian way of avoiding if-calls in an effort to support various equations simultaneously. But hard to tell whether later on this will lead to ugly design choices to still enable compatibility with BarotropicModel and ShallowWaterModel ...

further addressed with #87


Add EventsStream

Adding Events stream at the repository level

@laurentS @aaronsteers
Looks like we are hitting a limitation of the GitHub API on this one:
Request: https://api.github.com/repos/octocat/Hello-World/events?per_page=1000&page=4&sort=updated
{
  "message": "In order to keep the API fast for everyone, pagination is limited for this resource. Check the rel=last link relation in the Link response header to see how far back you can traverse.",
  "documentation_url": "https://docs.github.com/v3/#pagination"
}

It looks like we won't be able to traverse back in time very far for Events. Should we just find a way to stop after a few pages?

I tried curl -vvv -H "Accept: application/vnd.github.v3+json"   "https://api.github.com/repos/octocat/Hello-World/events?per_page=1000&page=1&sort=updated" now and got this header included in the response:
link: <https://api.github.com/repositories/1296269/events?per_page=1000&page=2&sort=updated>; rel="next", <https://api.github.com/repositories/1296269/events?per_page=1000&page=3&sort=updated>; rel="last"
On facebook/react-native (which I'd assume to be a lot more active than Hello-World, the last page allowed was 2.
So I suppose we could use one of the tap's methods to figure out how many pages we're allowed to fetch based on it. Then I guess it's the tap user's job to figure out how often to fetch this stream if they want full data coverage?

So I suppose we could use one of the tap's methods to figure out how many pages we're allowed to fetch based on it. Then I guess it's the tap user's job to figure out how often to fetch this stream if they want full data coverage?

I think that is reasonable. If the tap knows how to paginate "as far back as possible" and "as possible" gets documented in the readme, this doesn't sound unreasonable. There are other data sources which have a similar max lookback window, and the guidance turns into "start early to capture a history of data" + "beware of letting the tap get disabled for longer than x days or you'll have gaps".

@aaronsteers ready to merge? :)

@edgarrmondragon and @ericboucher - For my part, this PR looks good to me.  Feel free to holler if you see any issues or blockers.


Smithing templates + Table and Armour Trims

Co-authored-by: Flonja
Everything works properly but the smithing recipes are still missing
would like some help generating the smithing_data.nbt file.

Thank you for the contribution!


Deprecated constant in HA 2025.1

Version of the custom_component
Latest (3.19.5)
Configuration
Describe the bug
Some constants will disappear in HA 2025.1
Debug log
Logger: homeassistant.const
Source: helpers/deprecation.py:204
First occurred: 4 janvier 2024 à 16:31:40 (14 occurrences)
Last logged: 4 janvier 2024 à 16:32:06
PRESSURE_BAR was used from tesla_custom, this is a deprecated constant which will be removed in HA Core 2025.1. Use UnitOfPressure.BAR instead, please create a bug report at https://github.com/alandtse/tesla/issues
PRESSURE_PSI was used from tesla_custom, this is a deprecated constant which will be removed in HA Core 2025.1. Use UnitOfPressure.PSI instead, please create a bug report at https://github.com/alandtse/tesla/issues
SPEED_MILES_PER_HOUR was used from tesla_custom, this is a deprecated constant which will be removed in HA Core 2025.1. Use UnitOfSpeed.MILES_PER_HOUR instead, please create a bug report at https://github.com/alandtse/tesla/issues
TEMP_CELSIUS was used from tesla_custom, this is a deprecated constant which will be removed in HA Core 2025.1. Use UnitOfTemperature.CELSIUS instead, please create a bug report at https://github.com/alandtse/tesla/issues
ELECTRIC_CURRENT_AMPERE was used from tesla_custom, this is a deprecated constant which will be removed in HA Core 2025.1. Use UnitOfElectricCurrent.AMPERE instead, please create a bug report at https://github.com/alandtse/tesla/issues
Logger: homeassistant.components.device_tracker
Source: helpers/deprecation.py:204
Integration: Dispositif de suivi (documentation, issues)
First occurred: 4 janvier 2024 à 16:32:06 (2 occurrences)
Last logged: 4 janvier 2024 à 16:32:06
SOURCE_TYPE_GPS was used from tesla_custom, this is a deprecated constant which will be removed in HA Core 2025.1. Use SourceType.GPS instead, please create a bug report at https://github.com/alandtse/tesla/issues

Thanks for reporting. We're near the end of the lifecycle for this, but perhaps we can resolve it.

It seems that no action is functional anymore (opening windows, managing temperature, heating, etc.)

It seems that no action is functional anymore (opening windows, managing temperature, heating, etc.)

Yea I can push any changes to my car such as heat cool or anything really but it seems to be reading the data ok for now.


Add Interfaces for Graceful shutdown

Related to #689

Add ConnectionOfflineTask for IServiceConnection

Use for waiting for a server connection to be offlined.

Add AllConnectionsCompleted for IClientConnectionLifetimeManager

Use for waiting for existing client connections to be stopped.

All fixed @vwxyzh @vicancy


[Infrastructure] Automate Testing in Github

Current Situation

Currently, we have no automated testing of new pushes or Pull Requests in this repo.  We therefore occasionally receive Pull Requests where the tests are failing.
Suggested Improvement

We should somehow automate running tests in this repo whenever new code is pushed, and for Pull Requests.  The specifics are left to the implementer.
Benefit

It should be obvious, but this will:

Help avoid deploying defective code
Give immediate feedback to contributors so they can fix some errors before involving a human reviewer.

Additional context

The relevant tests are designed to be run via pytest, and are under the src/cc_catalog_airflow/ directory.

@mathemancer We can use Travis CI for the same https://travis-ci.org/

@amartya-dev I'd be fine with that.  @kgodey What do you think?  Long term, it might be useful for getting a build image onto the running VM as well.

N.B. The testing method and environment have changed.  Now, we use docker-compose, and all tests should run in the appropriate docker container.

I think it's better to use GitHub Actions so that we standardize on the same tool across all our repos, unless there's some technical reason not to.
If there's a technical reason not to use GitHub Actions, let's use Circle CI since that's the other tool that we're using in multiple places.

Ok I will try the same with Github Actions


Update README

Currently, repo is displaying readme from docs-superstaq. We'll need a new readme for clients that displays info on all the client submodules + interesting graphics, contact info, etc.
Good reference: https://github.com/AgnostiqHQ/covalent

Temporary fix: https://github.com/SupertechLabs/client-superstaq/pull/406

Update logo, demo GIF

For code snippet GIFs: https://recoded.netlify.app/

Decide on code snippet closer to release date

make GIF as hello example
seeing pulses

we should probably also update general-superstaq/README.md (which currently reads as if it's the top of the monorepo)

Closed by https://github.com/Infleqtion/client-superstaq/pull/577, https://github.com/Infleqtion/client-superstaq/pull/568


Fix XDEL

What do these changes do?
Allows you to pass multiple IDs to XDEL.

Are there changes in behavior for the user?
No.
Related issue number
#737
Checklist

[x] I think the code is well written
[x] Unit tests for the changes exist
[x] Documentation reflects the changes
[x] If you provide code modification, please add yourself to CONTRIBUTORS.txt

The format is <Name> <Surname>.
Please keep alphabetical order, the file is sorted by names.

[x] Add a new news fragment into the CHANGES/ folder

name it <issue_id>.<type> (e.g. 588.bugfix)
if you don't have an issue_id change it to the pr id after creating the PR
ensure type is one of the following:

.feature: Signifying a new feature.
.bugfix: Signifying a bug fix.
.doc: Signifying a documentation improvement.
.removal: Signifying a deprecation or removal of public API.
.misc: A ticket has been closed, but it is not of interest to users.

Make sure to use full sentences with correct case and punctuation, for example:
Fix issue with non-ascii contents in doctest text files.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.1 out of 2 committers have signed the CLA.:white_check_mark: seandstewart:x: art1415926535You have signed the CLA already but the status is still pending? Let us recheck it.

@art1415926535 thanks for your submission!
Maintenance for aioredis is back on 👍
Would you be willing to sign the CLA? Then I think this PR is good to merge.

Resolved by a separate PR #708


Unable to open A-tuning

I have a MSI mother board and have the issue with my 5600x and I can’t open A-tuning and I’m greeted with an error saying “This Utility is not for this platform”

You don't need to open atuning after installing, go ahead with step 2.
Il sab 3 dic 2022, 00:05 Chipchap12 @.***> ha scritto:

I have a MSI mother board and have the issue with my 5600x and I can’t
open A-tuning and I’m greeted with an error saying “This Utility is not for
this platform”
—
Reply to this email directly, view it on GitHub
https://github.com/Hangovers/Amd-startup-throttle-automatic-fix/issues/1,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AFZ54EPA6JXSH7DSJEOP5QTWLJ6B7ANCNFSM6AAAAAASSL6GUE
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

Any idea what I should use for step two in order to write a text file