Error when building shared libs on Windows.

Hi!
When building OCIO with shared libs on windows it fails to link correctly with Imath.
I get the following when building with Imath 3.1.10, OpenExr 3.2.1 and OpenColorIO 2.3.2
Lut1DOpData.obj : error LNK2001: unresolved external symbol imath_half_to_float_table
OpHelpers.obj : error LNK2001: unresolved external symbol imath_half_to_float_table
CPUProcessor.obj : error LNK2001: unresolved external symbol imath_half_to_float_table
FileFormatDiscreet1DL.obj : error LNK2001: unresolved external symbol imath_half_to_float_table
MathUtils.obj : error LNK2001: unresolved external symbol imath_half_to_float_table
Lut1DOpCPU.obj : error LNK2001: unresolved external symbol imath_half_to_float_table
..\vfxplatform_build\build\OpenColorIO\src\OpenColorIO\Release\OpenColorIO_2_3.dll : fatal error LNK1120: 1 unresolved externals

This seem to be a common issue with Imath and I think the solution is to define IMATH_DLL when needed, but I'm not sure where or with what logic it should be defined, but I guess only when building shared on Windows.
In my test to see if I could work around it I just added the define to FindImath.cmake and then it builds correctly.
More info in this Imath ticket https://github.com/AcademySoftwareFoundation/Imath/issues/212#issuecomment-1502764231

FYI, recent Imath ships with its own CMake config files which should already take care of adding the IMATH_DLL compile definition to the imported Imath::Imath target. E.g. on MinGW I have this in lib/cmake/Imath/ImathTargets.cmake:
set_target_properties(Imath::Imath PROPERTIES
  INTERFACE_COMPILE_DEFINITIONS "IMATH_DLL"
  INTERFACE_COMPILE_FEATURES "cxx_std_11"
  INTERFACE_INCLUDE_DIRECTORIES "${_IMPORT_PREFIX}/include"
  INTERFACE_LINK_LIBRARIES "Imath::ImathConfig;m"
)


LibGfx: Remove home-grown JPEG codec in favor of libjpeg-turbo

Hrmf, this setjmp style error handling is going to require some finessing to avoid leaking on error..


Fix #1080 [BUG] Support for images loading from allowed domains not working and 💬 Update 'ru' locale

Fix #1080 [BUG] Support for images loading from allowed domains not working
💬 Update 'ru' locale

With this regex, it will allow any URL that is possibly malicious. Will take a look later today with a fix to support Discord's CDN.


merge to live

excel workbook article
plus topics with minor changes

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/develop/dialog-api-in-office-add-ins.md
:white_check_mark:Succeeded

docs/excel/excel-add-ins-core-concepts.md
:white_check_mark:Succeeded

docs/excel/excel-add-ins-workbooks.md
:white_check_mark:Succeeded

docs/excel/excel-add-ins-worksheets.md
:white_check_mark:Succeeded

docs/images/dialog-prompt-before-open.png
:white_check_mark:Succeeded

docs/reference/manifest/rule.md
:white_check_mark:Succeeded

docs/toc.yml
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Glory and Victory are awarded before the card is tucked

We just had an odd finish to our 4 player game where Hamburg was tucked to finish the game (it has a fountain), but as soon as the card was selected the game ended.
I think the card should be transferred first before the achievement is transferred.

https://boardgamearena.com/2/innovationalpha?table=337552209


APK generated

Congratulations on the project, it looks very promising, tell me if we can build the apk to run on an android phone

Thank you for your congratulations! I never thought about build an APK with it, but I'll make an attempt to check if it is posible

The idea to build the apk still open. It is delayed because the team behind flet, the framework used for this project, still actively developing the support of python packages (specially opencv) in the apk build


Certificate Issue in V3

I was working on a project locally with v2 but since i upgraded to v3 - I am getting this error:
S3Exception in WrappedHttpHandler.php line 152:
Error executing "HeadObject" on "https://s3-sa-east-1.amazonaws.com/gambero/user_files"; AWS HTTP error: cURL error 60: Peer certificate cannot be authenticated with given CA certificates
The odd thing is that if i run the same thing on v2, on the same local server - it works pretty well.
Is there any way to disable the ssl check in v3?

The aws docs suggest updating the certificate: http://docs.aws.amazon.com/aws-sdk-php/v3/guide/faq.html#what-do-i-do-about-a-curl-ssl-certificate-error
From flysystem's end there's really not much I can do. Perhaps open an issue on the sdk repo?

I'll close this issue since it's not solvable from this end.

anyone come to this issue because similar problem in laravel trying to connect to local installation of minio with self-signed certificate, you can update your filesystems.php like this:
's3' => [
  ...
  'use_path_style_endpoint' => true,
  'http_handler' => new App\GuzzleHandler(),
];

with GuzzleHandler.php is
namespace App;
use GuzzleHttp\Client;
use Aws\Handler\GuzzleV6\GuzzleHandler as BaseAwsGuzzleHandler;

class GuzzleHandler extends BaseAwsGuzzleHandler
{
    public function __construct()
    {
        parent::__construct(new Client(
            ['verify' => false]
        ));
    }
}

anyone come to this issue because similar problem in laravel trying to connect to local installation of minio with self-signed certificate, you can update your filesystems.php like this:
's3' => [
  ...
  'use_path_style_endpoint' => true,
  'http_handler' => new App\GuzzleHandler(),
];

with GuzzleHandler.php is
namespace App;
use GuzzleHttp\Client;
use Aws\Handler\GuzzleV6\GuzzleHandler as BaseAwsGuzzleHandler;

class GuzzleHandler extends BaseAwsGuzzleHandler
{
    public function __construct()
    {
        parent::__construct(new Client(
            ['verify' => false]
        ));
    }
}

For those coming to look for a Symfony alternative to develop locally, you can define your client this way:
    Aws\S3\S3Client:
        arguments:
            -   version: 'latest'
                endpoint: '%aws_s3_endpoint%'
                region: '%aws_s3_bucket_region%'
                use_path_style_endpoint: true
                credentials:
                    key: '%aws_s3_access_key%'
                    secret: '%aws_s3_secret_key%'
                http: { verify: false } }

The important thing to note is the http: { verify: false } }, that disables the peer verification. It is somehow documented in the Aws\AwsClient constructor
Please, take into account that this configuration should only be enabled in a local environment, never in a production system.


[ADDON] - Backstage

Addon for Backstage

@mbeacom we don't plan on adding backstage as add-on in blueprints at this time. However you should be able to deploy the helm chart as described here.


Slides missing until animation completes

Slides appear to be missing when animating from end to beginning when infinite = true, animation is enabled, and .slick-list is set to overflow: visible.

We're trying to create a carousel that fades out the slides on the ends of the frame to show a 'preview' of which slide is previous/ next. We tried setting .slick-list to overflow: visible which gives us the desired effect, however, anytime we advance from the end of the carousel to the beginning again there is a flicker, as some of the slides are missing until the animation completes.
====================================================================
http://jsfiddle.net/00bakyc0/1/
====================================================================
Steps to reproduce the problem

Create a slider with the following options

{
    speed: 1000,
    infinite: true,
    slidesToShow: 3,
    slidesToScroll: 1
}

Adjust the css slightly:

.slick-list{
    overflow: visible;
}
.slick-prev, .slick-next{
    z-index: 99;
}

when slider is ready, click the left arrow to view the last slide
click the right arrow to return to the beginning, notice the empty space on the right end of the slider
when the animation completes, notice the slides pop back into place

====================================================================
What is the expected behaviour?
Slides will seamlessly toggle from beginning to end and vice versa
====================================================================
What is observed behaviour?
When moving from the end of the slider to the beginning a jitter occurs because slides appear to be missing until the animation completes.
====================================================================
More Details

Which browsers/versions does it happen on?
chrome/ 56
Which jQuery/Slick version are you using?
jquery 3.1.1/ slick 1.6.0
Did this work before?
No, never used slick carousel before

Got the exact same problem, i don't use slides to show, but center mode:
  Drupal.behaviors.paragraph_reference_slider = {     attach: function (context, settings) {         // Init slider         var $slider = $('.paragraph-reference-slider__slider .slider');         $slider.slick({             arrows: true,             dots: false,             swipe: true,             infinite: true,             centerMode: true,             slidesToScroll: 1,             slidesToShow: 1,             variableWidth: true,         });     }   };

Thanks @mgoubert!

Was this ever resolved? I'm having the same issue.


Thanks for this!

This is not an issue just saying thanks and wishing you the best!
The docs are a bit hard to find, but other than that this is a gem!

Yes great tool, exactly what I was looking for and works great. I found the lack of installation instructions or even a link to the docs in the main readme confusing and assumed it didn't have docs till I saw this issue. I think it would be helpful to add a link to the docs and put the installation instructions in the main readme @brc-dd if you're still maintaining it? I'm happy to send a PR if you'll merge it?
For anyone lost the installation guide does exist and all the documentation is in the docs folder.

There is a link on top in both GitHub and NPM. Is it hard to find?

(BTW the logo itself is also clickable and opens the docs, yeah but that might not be obvious.)

Unfortunately I missed both those links and I assume @Stevemoretz did as well. When I'm investigating a project on NPM or GitHub I typically scroll down to the README and quickly skim that for links to the documentation or website, so when I didn't see any I assumed it didn't have them. I've opened #220 proposing some inclusions that I typically find helpful.


Support DNS setup with different domain

Is your feature request related to a problem? Please describe.
Currently our NGINX setup assumes uds.dev as the domain. While this is great and works well for most dev use-cases sometimes it is helpful to deploy a dev/demo instance with a different domain and be able to inherit the dns setup from uds-k3d.
Describe the solution you'd like
By swapping uds.dev to the zarf var for DOMAIN, defaulting to uds.dev this would ensure that it remains as expected for current users but allows a configuration option for dev/demo scenarios where this is useful.
Describe alternatives you've considered

End users can build their own k3d + metallb + nginx setup to account for this
End users should not use k3d for their custom domain demo needs

@rjferguson21 I don't recall if there was a reason for us locking the setup down to only uds.dev, outside of being clear that this is a dev setup?

I agree, I think it was mostly to avoid it being used outside of dev, as opposed to a technical limitation.

I have another similar issue related to this.  I am trying to test a multi-gateway setup locally on k3d (related to this issue in uds-core).
I am currently building a package to enable a custom Istio Gateway and associated Netpols/Virtual services to enable ingress on a different domain.
In order to test this I am deploying a new gateway using a new domain uds2.dev with self signed certs.  I believe I now have the capabilities to provide CoreDNS overrides, but I don't have a method to override the nginx config to add domain routes to the new gateway.
Would be against exposing the nginx config here as a value do that it can be overridden?  If not, I'd be happy to toss up a PR.
Alternatively I could just create my own dev package, but would really like to hook into this package for continual updates if possible.

@joelmccoy definitely nothing technical stopping this, and as you indicated we just added support for coredns overrides. I think we have primarily been focused on the needs of core CI/dev where multi-domain isn't supported and wasn't really a consideration here. Adding support for the extra ports was similar - we have it now, but initially didn't have any support for that because core defaults to just using the default http/https ports.
I don't have any strong objections to exposing this as another option, with the same qualifications as the coredns and nginx port overrides - they aren't really tested in CI and it's sort of "use at your own risk and discretion". We do already have the note about this being for dev/CI only so I think we might be okay exposing more flexibility, we just don't want people to see this as a real cluster solution for prod type use cases.


Fix depth detection

There was an issue with loading files of a directory when providing an directory as input path. This PR fixes this.

LGTM


i18n: adds Occitan translation

Hi!
I forgot about that.
Sorry. Merged!

Oups, I didn't know deleting the fork would close my request :S


Add note about returning current results

Making sure the API is clearer in the README for users who want to get the results from the background sampler

Good point -- updated 👌


Support for wallet & transactions commands in cardano-wallet-byron

Issue Number

#1477
Overview

12339ede10eab98e6543650b5a2ed0aec3ded35b
:round_pushpin: capture network discriminant from command-line options
This enables mounting commands in the command-line to work with both
mainnet and testnet; chosen at runtime. This commit won't work properly
with Jörmungandr and need to be adjusted to work fine there too.

403e031c298e9031bcf8c3dde9222de0e2fd6755
:round_pushpin: Allow caller to choose how to parse network discriminant
This enables correct support of the network discriminant in the Byron CLI while,
at the same time, keep the interface for Jörmungandr unchanged by forcing the
network discriminant to testnet, as before.

29081d293264af115b39341735773a1352f2ce51
:round_pushpin: wire the new discriminant option in existing command-lines

9b5a89f61273e7e5dbeef882104175833374e00f
:round_pushpin: break 'walletClient' into several smaller clients
This enables to provide different clients for each commands, and in particular
to define and make use of clients for byron wallet endpoints where needed.
There's still an annoying bit regarding the creation of wallets that differs
between Byron and new ones. This will be addressed in another commit

3a33b6e6e91a61818ffdc6d90e91cea6e4ea20cf
:round_pushpin: remove now obsolete discriminant flag for wallet commands
The wallet client split introduced in the previous commmit makes this option now
pointless. Indeed, it was needed to instantiate a (WalletClient n) in the past
because of the addresses, transactions and stake pools endpoints. Now that the
wallet client is only about wallets, the network discrimination matters not.

a3ecef20116f62133c59a707349be521c5163622
:round_pushpin: implement cmdByronWalletCreate for creating wallets from mnemonic
This can be extended later on to create a wallet from a raw XPrv. Didn't do it yet though
as the endpoint is still under testing.

4e444482e50b23b7a05cab6d89a5ef6363c67f27
:round_pushpin: Fix postTransactionFeeViaCLI (which is not interactive CLI)

7ee58476744dd25f743b2ba6bdbdbbd3f4143d75
:round_pushpin: Integration tests for transactions via CLI for cardano-node

02557e613b0dbc706e22cc4901577b81bfe6966e
:round_pushpin: use Haskell magic and strong family bonds to remove the need for passing discriminant as option
The main trick here was to make the 'Api' type poly-kinded and then allow some of the problematic types
to be defined as family of the given type parameter. This enables us to use more flexible data-types in
the Haskell typed client (like plain Aeson.Value) since the client is in the end simply returning JSON.

what we loose however by doing this is the ability to catch early (i.e. in the command-line client code)
that an address may be of the wrong discriminant. This is deferred until the server sees the address and
reject the API call. I think this is really acceptable.

e855f4fd5e276eb9e1b61ceb07953b68a8a594de
:round_pushpin: Fix protocol magic not being verified when decoding addresses
Pretty big deal and which explains why the wallet was actually crashing when submitting an address that
was illed-formed and the API not catching it.

aedcd00e252abeeb8b66df52d6163fa81727be58
:round_pushpin: defer network discriminant check from command-line client to the API
This way, we need not to know or pass the network discriminant as an option when parsing payments
from the command-line. If an address has an invalid network discrimination, the API will reject it

c52a7d8a6c7048add3880a013cef70d4eaaf4779
:round_pushpin: more integration tests for list/forget tx

e6e04230010c3ce898bb937875ccfb98d1774d3e
:round_pushpin: do not enforce network discriminant for legacy address on the ITN...

f243a7de02a0aae4b89cdf08e9af780b49f7b21b
:round_pushpin: re-generate nix machinery

Comments

:warning: I've only tested this superficially. So I'd be keen not to merge that before this week's release but only after while we work out the integration tests. Most of existing scenarios should be portable (modulo the endpoints that aren't yet implemented on the byron API).

bors try

running $ stack test cardano-wallet-byron:cardano-node-integration locally

bors try

bors try

stack test cardano-wallet-byron:cardano-node-integration
[...]
Finished in 402.7320 seconds
123 examples, 0 failures

bors try


Can not download nws

I have installed nws but when I choose export, always the program wants to download, where I can place de nws sdk for avoiding this issue

Sorry for not responding. If downloads ever fail, you can put the zip file for NW.js inside the Download location you have specified in the Download settings tab.


TextSpan could use Tooltip support

It would be really useful to add tooltip property to a TextSpan so you can pass a tooltip to the particular part of the text

I would like to look into this, if the team plans to add this to TextSpan.

Hi there, I would love to work on this too, if @tahirgani07 did not start yet.

@campovski I have started working on it, but I am a beginner and I am facing some issues, but I will try to do it. I will inform if I will be unable to do it in a few days.

@tahirgani07 Acknowledged. Good luck, you can do it! 💪

I am trying to do this but, I can't figure out a few things, if anyone would like to give me a rough idea on how to add a tooltip property for TextSpan, it would be really helpful. Thank you.🙂

@tahirgani07 Take a look at IconButton's implementation. IconButton already has a tooltip property so adding it to TextSpan should be pretty much the same.

@campovski I tried to do that but the problem is that IconButton extends StatelessWidget so you get a build method to return a widget, but TextSpan extends InlineSpan and you cannot return a widget and that is where i'm stuck. Any suggestions? Thank you.

Yes, I have an idea but currently don't have time to research it further. If we strive for simplicity, a possible solution would be to change current InlineSpan into _InlineSpan and create new class InlineSpan extends StatelessWidget for example wherein you create _InlineSpan. This was a quick thought during lunch, but the impacts would need to be checked, e.g. Text.rich takes InlineSpan as an argument. This change would affect also other descendants of InlineSpan (which could also use tooltip property IMHO, but would need to be discussed further). I will check this idea in the evening CET, if you have time to check it out I am interested in your findings.

@campovski I'll definitely give it a try👍. Thanks for all the help. I really appreciate it.

I am a bit busy at my work this week so sadly I wasn't able to check it out yesterday myself. Hope it would be of any help.

Is anyone still working on this ??

@jp803333 I am currently stuck, so you can work on it.

@tahirgani07 yeah same here I am also trying

Hello
is anyone working on this ?!

Hello, I tried to investigate this a bit and I don't think we can make TextSpan a StatelessWidget as it was suggested.
I tried to take a look at this PR: https://github.com/flutter/flutter/issues/77754 that added the onEnter and onExit parameters to the TextSpan to see if was reusable but I didn't get anything. The issue is that TextSpan is used in RichText which creates a RenderParagraph and a TextPainter and I have no clue on how to get the position of the current text span and display a tooltip from those objects.
Moreover, it was a bit useless/hard to go try to go deep in the implementation of the objects as it is calling native functionalities which I'm definitely not familiar with.
I'm not sure this issue should still be labeled as good first contribution and easy fix

Hey there I would love to work on this issue, is anyone else working on it? If not can I work on it?

Hey there. Hope you all fine. I would like to contribute to flutter framework. Am a beginner. I notice that flutter master channel has in some source file a switch block without a case so my intellij juste underline these line and tells ""The 'case' shouldn't complete normally.". I check other branch such as flutter-3.7-candidate.10 , everything seems ok, case are added to the switch block so I wonder if there is a particular version of dart we are supposed to work with on master branch. Thanks.

Just had a look at it...
I've considered adding a TooltipSpan extending InlineSpan and implementing HitTestTarget.
TooltipSpan should have a property child being an InlineSpan. Most of the InlineSpan-behavior could just be passed to the child. Additionally, TooltipSpan would have to implement the entire TooltipState logic.
One could probably do some clever refactoring to avoid duplicate code.
But, at one point, we would need an TickerProvider inside the TooltipSpan to do the animation stuff. And that seems to be a problem. A solution to this could be the addition of a TooltipController, that has to be provided when creating a TooltipSpan.
However, that's where I'll leave it for now. Feel free to implement my idea or let me know what you think about it.


Remove the unused make file variables

Summary

boards/nrf52: Remove ARCHCCVERSION/ARCHCCMAJOR which isn't used
boards/nrf52: Remove toolchain macro which is already defined in Toolchain.defs
boards/bm3803: Remove toolchain macro which is already defined in Toolchain.defs

Impact
No, code refactor
Testing
Pass CI

@pkarashchenko how about this PR?

Will merge as soon as CI pass.


Huginn should be an oauth endpoint and have an open API

Manage oAuth applications
Create and edit Agents via the API

This would allow a 3rd party to make an Agent dashboard or Scenario-sharing site and push into individuals' Huginn instances.

Any progress on this? I just found a usage for an API with which i can manipulate agents with from another program


Wrong output shape inferred for SpaceToBatchNd

Hi, I'm trying to run a tflite model that consists of SpaceToBatchNd operation. For now, the code I'm running is:
armnn::ConfigureLogging(true, false, LogSeverity::Warning);
armnn::NetworkId networkIdentifier;
armnnTfLiteParser::ITfLiteParserPtr parser = armnnTfLiteParser::ITfLiteParser::Create();

INetworkPtr myNetwork = parser->CreateNetworkFromBinaryFile("model.tflite");

armnnTfLiteParser::BindingPointInfo inputBindingInfo = parser->GetNetworkInputBindingInfo(0, "input_name");
armnnTfLiteParser::BindingPointInfo outputBindingInfo = parser->GetNetworkOutputBindingInfo(0, "output_name");

IRuntime::CreationOptions options;
IRuntimePtr run = IRuntime::Create(options);

armnn::IOptimizedNetworkPtr optNet = Optimize(*myNetwork, {Compute::CpuRef}, run->GetDeviceSpec());

Unfortunately Optimize function gives me this exception:
terminate called after throwing an instance of 'armnn::LayerValidationException'
  what():  SpaceToBatchNdLayer: TensorShape set on OutputSlot[0] does not match the inferred shape. : [3,520,192] != [3,520,51745]
Aborted (core dumped)

What is strange, the last dimension of the inferred shape is always different every time I rerun the program.
I was able to reproduce the issue with tflite model consisting of only two operations: ReLU -> SpaceToBatchNd
Is this a bug or am I doing something wrong?
Thanks

Hi @r-czarnecki
I think there are two possible issues that could cause this.
First, the fact that the last dimension is different every time may might indicate that one of the other variables in your model is being left uninitialised. If that's the case then we could get random values when inferring the output shape. The output shape height and width dimensions are calculated using the input shape's width or width, the padding and the height or width of the blockShape, if any of these are undefined you might have this issue.
Second, there is currently a limitation in ArmNN where most of our layers including SpaceToBatchNd can only accept a 4 dimensional shape with either an NCHW or NHWC data layout (NHWC by default). You've given a 3 dimensional shape which may be confusing the outputshape calculation to change this to a four dimensional shape you could put it in as [3,520,192,1] and it should behave the same as [3,520,192].
If that doesn't work then can you share your model?
Best regards,
Mike

I have tried to use the 4 dimensional input and it solves the problem with the wrong output shape. Unfortunately now I get Floating point exception (core dumped) whenever I run the Optimize function.
This is the model that causes this error. I use the same code as described in my first post to run it.

Hi @r-czarnecki
Thanks for sharing the model, I ran it through the parser and I get the same error you originally posted (something like TensorShape set on OutputSlot[0] does not match the inferred shape. : [3,520,192,1] != [3,520,59523,1]) so I still see the random 3rd dimension.
Looking at the model I can see that the blockshape only has a single dimension with a value of [3]. According to the TfLite specification (https://www.tensorflow.org/api_docs/python/tf/space_to_batch) it should have the same number of dimensions as the spatial shape of the input tensor (i.e. it should have a height and width) so we'd expect a 2-dimensional blockshape, like [3,3].
Currently, the code we have doesn't check the length of the blockshape vector it just get's the 0th entry for the height and the 1st entry for the width, in this case the width could be anything as it's just the next piece of memory after the blockshape vector. I'll fix that so that it throws a more useful exception in future.
Can you please check if setting a 2-dimensional blockshape fixes your issues?
Best regards,
Mike

I've changed the model to use 4-dimensional input and 2-dimensional blockshape and it seem to be working fine now. Thank you for the help.


Test zonal on geometries with extents that go beyond the raster

We could probably degrade these tests to rasterize.  But IMO it's pretty important to test these edge cases.
If these tests pass, we can enable tiled zonal on pretty much any chunk size, so you could calculate the max elevation on Greenland using a 30-meter cell size DEM like Copernicus, all on your local laptop.
This spawned #816.

Yeah the edge cases are important, but zonal is very abstract and hardly does anything.
Its not actually rasterize that matters either, rasterize is a really complicated set of tools for writing a wide range of things into rasters where they intersect geometries in some way or other.
zonal is just mask, which is boolmask, which internally is burn_geometry!
Probably testing boolmask! more is the cleanest thing. But we could aslo just test burn_geometry! directly.

Was an edge search optimization breaking things, guess I slightly misunderstood the space when I wrote it or just made a dumb mistake.
I think this is solved with very little additional overhead, we just need to look for off-grid points early in the scan or we lose the start line and don't know we are inside a polygon.
Hopefully there is nothing this bad left around.


accept lang_code parameter on reverse osm

hey ,
this is  a support for additional  parameter on reverse osm
it allows you to chose the language of the return data
thanks

Coverage decreased (-0.7%) to 53.444% when pulling d48cce42c8c0565315a0abf0510a4f996e114a98 on eliranmoyal:master into f8d049f4b0b53ee8140de2162c476a0576b7c448 on DenisCarriere:master.

Thanks for the PR


Add golint as Warning instead of Error

According to golint the linter is giving style errors which imho should be considered as warnings instead of errors.
Golint differs from gofmt. Gofmt reformats Go source code, whereas golint prints out style mistakes.

Golint differs from govet. Govet is concerned with correctness, whereas golint is concerned with coding style. Golint is in use at Google, and it seeks to match the accepted style of the open source Go project.

The suggestions made by golint are exactly that: suggestions.```

Thanks!
What do you think about https://github.com/neomake/neomake/issues/584 in this context?

It could actually make sense, in that case it's not any more a matter of opinion since we could have our own category for those kind of errors/warnings. Everyone should be happy then :)


Download GeoPackage Layers from the server

Features

Download GeoPackages that are linked to the events, from the server

Bug Fixes

Fix new observation form picker crash when theme is set to auto.
Invalidate server token when a user logs out on the app
Bug fixes for some exceptions when opening invalid GeoPackage files

Pull Request Test Coverage Report for Build 202

0 of 615 (0.0%)  changed or added relevant lines in 12 files are covered.
181 unchanged lines in 8 files lost coverage.
Overall coverage decreased (-0.1%) to 5.743%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

Mage/SettingsTableViewController.m
0
1
0.0%

Mage/EventChooserCoordinator.m
0
1
0.0%

Mage/ObservationViewController.m
0
1
0.0%

Mage/Map/Cache/GeoPackageCacheOverlay.m
0
2
0.0%

Mage/Map/Cache/GeoPackageFeatureTableCacheOverlay.m
0
5
0.0%

Mage/MapSettingsCoordinator.m
0
9
0.0%

Mage/MapSettings.m
0
21
0.0%

Mage/Map/Cache/CacheOverlays.m
0
26
0.0%

Mage/MapViewController.m
0
31
0.0%

Mage/AppDelegate.m
0
69
0.0%

Files with Coverage Reduction
New Missed Lines
%

Mage/Map/Cache/GeoPackageFeatureTableCacheOverlay.m
1
0.0%

Mage/Map/Cache/CacheOverlays.m
1
0.0%

Mage/AppDelegate.m
2
0.0%

Mage/OfflineMapTableViewController.m
4
0.0%

Pods/mage-ios-sdk/MAGE/UserUtility.m
19
53.75%

Pods/mage-ios-sdk/MAGE/Event.m
26
8.79%

Pods/mage-ios-sdk/MAGE/Observation.m
46
0.0%

Pods/mage-ios-sdk/MAGE/Layer.m
82
0.0%

Totals

Change from base Build 179:
-0.1%

Covered Lines:
1256

Relevant Lines:
21872

💛  - Coveralls


Missing response headers in response.headers object

Hello,
I have some custom response headers coming back from my request, but superagent seems to ignore them and only picks up "content-type".
Any ideas?

It must be related to this: http://jaketrent.com/post/expose-http-headers-in-cors/
We are using CORS requests so this explains it.


Use the project.group value for Zip POM groupId value

Description
When publishing Zip POM the groupId value was hard-coded to org.opensearch.plugin value which works fine for existing core plugins but is not convenient for other plugins (such as community plugins maintained in independent repositories).
This PR introduces a main change in where the value for the groupId is taken from. Instead of using a hard-coded value it is taken from the project.group value.
This PR also brings a major rework of tests in PublishTests class. Individual testing scenarios are driven by "real" gradle building scripts (utilizing java-gradle-plugin gradle plugin).
Issues Resolved
Closes #3692
Check List

[x] New functionality includes testing.

[x] All tests pass

[ ] New functionality has been documented.

[x] New functionality has javadoc added

[x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.
Signed-off-by: Lukáš Vlček<EMAIL_ADDRESS>

Before merging the Plugin usage part of the documentation will need some update as well.

Codecov Report

Merging #4156 (6beec00) into main (c665e7c) will decrease coverage by 0.04%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##               main    #4156      +/-   ##
============================================
- Coverage     70.62%   70.57%   -0.05%
+ Complexity    57073    57050      -23
============================================
  Files          4603     4603
  Lines        274500   274493       -7
  Branches      40206    40206
============================================
- Hits         193856   193721     -135
- Misses        64393    64548     +155
+ Partials      16251    16224      -27

Impacted Files
Coverage Δ

.../java/org/opensearch/gradle/pluginzip/Publish.java
0.00% <0.00%> (-58.00%)
:arrow_down:

...adcast/BroadcastShardOperationFailedException.java
33.33% <0.00%> (-66.67%)
:arrow_down:

.../java/org/opensearch/node/NodeClosedException.java
50.00% <0.00%> (-50.00%)
:arrow_down:

...cluster/coordination/PendingClusterStateStats.java
20.00% <0.00%> (-48.00%)
:arrow_down:

...search/aggregations/pipeline/HoltWintersModel.java
21.47% <0.00%> (-44.97%)
:arrow_down:

...cluster/coordination/PublishClusterStateStats.java
33.33% <0.00%> (-37.51%)
:arrow_down:

...pensearch/action/ingest/DeletePipelineRequest.java
31.25% <0.00%> (-37.50%)
:arrow_down:

.../opensearch/client/indices/CloseIndexResponse.java
42.50% <0.00%> (-35.00%)
:arrow_down:

...arch/search/aggregations/pipeline/LinearModel.java
23.07% <0.00%> (-30.77%)
:arrow_down:

... and 469 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

BTW: Looking at https://github.com/opensearch-project/project-website/pull/930 it seems an article about zip POMs is in preparation 👍
What I see is that all the core plugins are expected to have org.opensearch.plugin groupId value. I think this will hold true as long as all the individual plugin project.group values result into this value as well. And if I read it correctly it should be the case, see: https://github.com/opensearch-project/OpenSearch/blob/9168f1fb43015cf7f33eab30f1300ec85f4d4305/plugins/build.gradle#L37
Though we need to double-check and test it.

I also tested this on the analysis-icu plugin:
I added the following line:
apply plugin: 'opensearch.pluginzip'

below this section in its build.gradle file https://github.com/opensearch-project/OpenSearch/blob/006c832c5fe8f509aa6285de90f2c7583b3dff35/plugins/analysis-icu/build.gradle#L31-L32
and run ../../gradlew --info publishPluginZipPublicationToZipStagingRepository while being in the root folder of the ICU plugin.
 Do you think it would make sense to add an example use of it in some plugin under plugins/example folder?

Hey @lukas-vlcek thanks for PR, quick question here, if the plugins not part of OpenSearch/plugins folder and does not have a group specified as group = 'org.opensearch.plugin', what would be the default groupID? From your PR i see as String groupId = getProperty("group", project);, I dont see any default set, so the all listed plugins, that are not part of OpenSearch/plugins folder should they explicitly mention the group to be org.opensearch.plugin?
@dblock @reta @bbarani
Thank you

Hi @prudhvigodithi
If the project.group value is not found then the build will fail (see relevant test that I created for this case https://github.com/opensearch-project/OpenSearch/pull/4156/files#diff-ecd94c54475d67ab08078a5cdb6e381c01094427bad63b70c4e67c7978b3d895R58-R70) in which case I think the failure is a product of the maven-publish plugin (or some its dependencies).
So there is nothing like default or fall-back value for missing group. I think the value should be always specified (IMO it is perfectly fine if the value is defined in parent project).
Do we have any examples of plugins that will be using opensearch.pluginzip and do not have project.group defined?

Do we have any examples of plugins that will be using opensearch.pluginzip and do not have project.group defined?

@lukas-vlcek mostly all of them that have used opensearch.pluginzip so far, example
job-scheduler
./gradlew properties
group: org.opensearch

asynchronous-search
./gradlew properties
group: org.opensearch
opensearch_group: org.opensearch

@prudhvigodithi
I need to look at it but my initial (naive) question would be why there needs to be a code that actually live under different group than it wants to manifest itself. It almost sounds like we are asking for troubles but again, I am not familiar with the details about why this is done like that.
However, with recent release 2.2.0 I noticed this issue:
https://github.com/opensearch-project/notifications/issues/501#issue-1330364398
and it makes me think is this related?

This LGTM.
@lukas-vlcek do you want to make a PR updating https://github.com/opensearch-project/opensearch-plugins/blob/main/BUILDING.md#opensearchpluginzip?
@prudhvigodithi Any reason not to merge this as is?
I think we can go and add project.group in the plugins where needed to make it explicit if that's the right solution. There should be no difference between plugins that ship with the default distribution vs. other plugins.

Two things, one is for all existing plugins that has publication pluginZip should have a new line groupID
Example as
publishing {
    publications {
        pluginZip(MavenPublication) { publication ->
            groupId = 'org.opensearch.plugin'
            pom {
              name = pluginName
              description = pluginDescription
              licenses {
                license {
                  name = "The Apache License, Version 2.0"
                  url = "http://www.apache.org/licenses/LICENSE-2.0.txt"
                }
              }
              developers {
                developer {
                  name = "OpenSearch"
                  url = "https://github.com/opensearch-project/opensearch-plugin-template-java"
                }
              }
            }
        }
    }
}

Second is there will be 2 groupID always as minimum per project (which is fine), but when not mentioned groupId explicitly for  pluginZip MavenPublication , it will default to org.opensearch, then the idea of plugins (that ship with the default distribution)  being in central place would no longer be true, each could have its own groupID within the maven and it would be hard to locate. So my thought is why not it be default as org.opensearch.plugin, unless it overrides with a specific groupId only within the MavenPublication.

Hey,
Just to add, here is the issue created from community feedback https://github.com/opensearch-project/documentation-website/issues/838, the ask is for a reference of Maven Coordinates for the plugins, it would be good if the default is org.opensearch.plugin and the artifcatID being the plugin name. To allow this pluginZip MavenPublication to other plugins, configuring a groupID should override org.opensearch.plugin. So long story short lets go with default (when no groupID specified for pluginZip(MavenPublication)) as org.opensearch.plugin, but still an option to override with groupID.
Note: This groupID override should only consider if it's part of the specific publication pluginZip(MavenPublication), else it might override the entire project groupID (should test this though).
Thoughts? @dblock @lukas-vlcek

@dblock @prudhvigodithi Thanks for the review. I was out last week. I am getting back to this now.

Oops, some precommit check are failing, I forgot to run the formatting check before the commit ... my bad. Fixing it now.

@prudhvigodithi Are you good with this?

Hi @prudhvigodithi
I updated the PR. It is now possible to override (customize) the groupId value directly in the Maven publication object. This will override whatever the actual value of Gradle project.group is.
So this means that for any existing OpenSearch plugin that does not have the project.group value equal to org.opensearch.plugin we can add a single line into the publication task to override it. Do you think that would be acceptable?
I added a test to illustrate this case as well. Please see the customizedGroupValue.gradle (line 20).
Notice that this also means that the maven publication task will reflect the new groupId value when uploading the artifact into maven repo. See PublishTests.java, the customizedGroupValue test (around the line 200). When the groupId is changed to I.am.customized then the flie is uploaded into ../I/am/customized/.. path as well. Which I think is correct from the maven POW.
So in essence that we two ways how to configure what the groupId value will be:

The value is taken from Gradle project.group
The value can be overridden in ZIP Maven publication task (as explained and demonstrated by new test)

I do not think there can be anything like a default value. You either need to set the Gradle project.group correctly or you have to override it in the publication object.

These check failures seems to be unrelated.

I updated the PR. It is now possible to override (customize) the groupId value directly in the Maven publication object. This will override whatever the actual value of Gradle project.group is.

Thanks for the update @lukas-vlcek, nice, this is good change, ideally for each publication the groupID configured could be different, not necessarily be the project groupID.
Also @lukas-vlcek lets go with the default as org.opensearch.plugin this line https://github.com/opensearch-project/OpenSearch/blob/5f35f1dd3422bade670a21ce312cd0eeff683889/buildSrc/src/main/java/org/opensearch/gradle/pluginzip/Publish.java#L54
would publish all the publication outputs to the same project groupID, which can be tar, zip and jar extensions under same path, why not this to be org.opensearch.plugin for pluginZip. This value is already configured and published for all OpenSearch plugins.
Once You have this change I will do a quick test with your fork and we are good to go, rest all code and tests i'm fine with them.
Thank you

This value is already configured and published for all OpenSearch plugins.

but that's only true for plugins from the OpenSearch project itself. 3rd party plugins shouldn't be published under that path. but if you set it as the default they'll end up there (because who bothers reading the docs or changing default values? 😉) which would be wrong. i vote for no default / taking it from the build, as currently done by @lukas-vlcek

I partially agree ;) @rursprung
There needs to be some default value set, every publication need not directly use the default project groupID, if thats the case and imagine they have the same artifcatID, ideally which will have, because the project name would be same, then under same folder you end up having multiple format of files if the project has several publications of different formats.
Again I'm open both thoughts, both has equal pros :)
@dblock @bbarani thoughts?
Thank you

Hi @prudhvigodithi
If I understand correctly what you mean then I would have the same objection as @rursprung.
The whole point of this PR is to enable external plugins to benefit from the ZIP publication mechanism. But with the hard-coded default value it would work differently for core plugins and external plugins, the authors of external plugins will always have to specify the groupId in the ZIP publication config (unless they want to publish their artifact under org.opensearch.plugin namespace) and the core plugins will always publish under org.opensearch.plugin namespace regardless of which namespace they actually live in. This can definitely create some confusion. I am not sure if it is neccessary.
If we, however, make the rules the same for all the plugin authors (regardless whether they implement a core plugin or external one) then we will make things more predictable and the documentation will not need complicated exceptions.
How about this: If we take the changes in this PR then how many of existing core plugins will have to add groupId =  "org.opensearch.plugin" to its ZIP publication config? Does it apply to "Bundled plugins" list? Or perhaps all the plugins listed in opensearch-build/issues/1916 under the "Campaign Issues"?
If that is the case then I was checking some of those plugins and I am ok with adding the one extra line into their publication config. Such as here or here.
Then the only challenge would be correct synfronization of mergin all the changes. I think we could safely merge changes in all affected plugins first (nothing should break at this point) and then we could merge this PR (with no notion of the default value, basically as it is now). And all should be fine IMO...
WDYT?
Lukáš

Then the only challenge would be correct synfronization of mergin all the changes. I think we could safely merge changes in all affected plugins first (nothing should break at this point) and then we could merge this PR (with no notion of the default value, basically as it is now). And all should be fine IMO...

i wanted to suggest to create a new major release of the gradle plugin as introducing a new mandatory parameter can be considered a breaking change, but now i just realised that this lives within the release cycle of OpenSearch :(
maybe this uncovered something else: i'd propose to untangle these releases (or is there a specific reason for it?) so that opensearch.pluginzip is in a dedicated repository with its own semver based lifecycle. but that's definitely not something to fix with this PR here!

Ya @rursprung @lukas-vlcek adding this could be a breaking change, One way I see is we merge to main and not backport to 2.2 branch, and use this for next Major release (~3.0), by then a new campaign can be initiated to add a single line to all plugins main branch. This way when 3.x branch is cut the change is pushed to 3.x version.

Ya @rursprung @lukas-vlcek adding this could be a breaking change, One way I see is we merge to main and not backport to 2.2 branch, and use this for next Major release (~3.0), by then a new campaign can be initiated to add a single line to all plugins main branch. This way when 3.x branch is cut the change is pushed to 3.x version.

I would like to throw one idea at you @prudhvigodithi @lukas-vlcek @prudhvigodithi: so publishing artifacts under org.opensearch is obvously no-go for 3rd party plugin authors. BUT we don't backport this change to 2.x, we leave them with no choice if they want to publish plugin ZIPs. As such, what about:

make in 3.0.0 this as breaking change: explicit plugin groupId is required
keep org.opensearch.plugin default in 2.0.0: plugin authors would be able to change it for publishing (or do not changes at all)

Thoughts?

+1 on only doing this for 3.0 (main)

Hey @reta thanks, I'm on the same page too https://github.com/opensearch-project/OpenSearch/pull/4156#issuecomment-1228595255
Once the checks pass, lets only merge to main and not backport to any other release branches. So that existing on going  releases are not impacted.
Also @lukas-vlcek is that something you can take care to raise the PR's across the bundled plugins to add the groupID to pluginZip else let me know we can do it together to a campaign issue and create sub issues in each component repo for this breaking change.
Thank you

@prudhvigodithi

Also @lukas-vlcek is that something you can take care to raise the PR's across the bundled plugins to add the groupID to pluginZip else let me know we can do it together to create a campaign issue and create sub issues in each component repo for this breaking change.

I am happy to open individual PRs for all the affected plugins. Let me create a first plugin for (say) job-scheduler and after we review it then I can open tickets for the rest of the plugins.

Hey @lukas-vlcek I have created a META issue consolidating all the details which the required changes for each plugin, lets work on this together, so that it does not break any existing plugin functionality to publishing the plugin zips to maven.
Thank you

Hey @lukas-vlcek merged the PR, can you please raise a PR for 2.x. Next updates we can follow up on this META issue.
Thank you


Tracking implementation progress

This issue will track the current progress of AutoIt JS. The list below is generated from the impl-count.test.ts unit test.
Progress:

Total Functions
117

Total Implemented
117

Total Tested
107

Status
Function Name
Status
Notes

✅
GetError
Implemented and tested

✅
Init
Implemented and tested

✅
AutoItSetOption
Implemented and tested

✅
ClipGet
Implemented and tested

✅
ClipPut
Implemented and tested

✅
ControlClick
Implemented and tested

✅
ControlClickByHandle
Implemented and tested

❌
ControlCommand
Implemented but broken
Sets the error flag and ion certain cases causes a segfault

❌
ControlCommandByHandle
Implemented but broken
Sets the error flag and ion certain cases causes a segfault

✅
ControlListView
Implemented and tested

✅
ControlListViewByHandle
Implemented and tested

✅
ControlDisable
Implemented and tested

✅
ControlDisableByHandle
Implemented and tested

✅
ControlEnable
Implemented and tested

✅
ControlEnableByHandle
Implemented and tested

✅
ControlFocus
Implemented and tested

✅
ControlFocusByHandle
Implemented and tested

✅
ControlGetFocus
Implemented and tested

✅
ControlGetFocusByHandle
Implemented and tested

✅
ControlGetHandle
Implemented and tested

✅
ControlGetHandleAsText
Implemented and tested

✅
ControlGetPos
Implemented and tested

✅
ControlGetPosByHandle
Implemented and tested

✅
ControlGetText
Implemented and tested

✅
ControlGetTextByHandle
Implemented and tested

✅
ControlHide
Implemented and tested

✅
ControlHideByHandle
Implemented and tested

✅
ControlMove
Implemented and tested

✅
ControlMoveByHandle
Implemented and tested

✅
ControlSend
Implemented and tested

✅
ControlSendByHandle
Implemented and tested

✅
ControlSetText
Implemented and tested

✅
ControlSetTextByHandle
Implemented and tested

✅
ControlShow
Implemented and tested

✅
ControlShowByHandle
Implemented and tested

🟨
ControlTreeView
Implemented but untested
Need to find an app that uses TreeView

🟨
ControlTreeViewByHandle
Implemented but untested
Need to find an app that uses TreeView

🟨
DriveMapAdd
Implemented but untested
Need to test

🟨
DriveMapDel
Implemented but untested
Need to test

🟨
DriveMapGet
Implemented but untested
Need to test

✅
IsAdmin
Implemented and tested

✅
MouseClick
Implemented and tested

✅
MouseClickDrag
Implemented and tested

✅
MouseDown
Implemented and tested

✅
MouseGetCursor
Implemented and tested

✅
MouseGetPos
Implemented and tested

✅
MouseMove
Implemented and tested

✅
MouseUp
Implemented and tested

✅
MouseWheel
Implemented and tested

🟨
Opt
Implemented but untested
Need to test

✅
PixelChecksum
Implemented and tested

✅
PixelGetColor
Implemented and tested

✅
PixelSearch
Implemented and tested

✅
ProcessClose
Implemented and tested

✅
ProcessExists
Implemented and tested

✅
ProcessSetPriority
Implemented and tested

✅
ProcessWait
Implemented and tested

✅
ProcessWaitClose
Implemented and tested

✅
Run
Implemented and tested

✅
RunWait
Implemented and tested

🟨
RunAs
Implemented but untested
Need to test

🟨
RunAsWait
Implemented but untested
Need to test

✅
Send
Implemented and tested

✅
Shutdown
Implemented and tested

✅
Sleep
Implemented and tested

🟨
StatusbarGetText
Implemented but untested
Need to find an app that has a Win32 StatusBar

🟨
StatusbarGetTextByHandle
Implemented but untested
Need to find an app that has a Win32 StatusBar

🟨
ToolTip
Implemented but unable to test
Seems to run successfully but the Tooltip never appears. This seems to be an AutoIt issue

✅
WinActivate
Implemented and tested

✅
WinActivateByHandle
Implemented and tested

✅
WinActive
Implemented and tested

✅
WinActiveByHandle
Implemented and tested

✅
WinClose
Implemented and tested

✅
WinCloseByHandle
Implemented and tested

✅
WinExists
Implemented and tested

✅
WinExistsByHandle
Implemented and tested

✅
WinGetCaretPos
Implemented and tested

✅
WinGetClassList
Implemented and tested

✅
WinGetClassListByHandle
Implemented and tested

✅
WinGetClientSize
Implemented and tested

✅
WinGetClientSizeByHandle
Implemented and tested

✅
WinGetHandle
Implemented and tested

✅
WinGetHandleAsText
Implemented and tested

✅
WinGetPos
Implemented and tested

✅
WinGetPosByHandle
Implemented and tested

✅
WinGetProcess
Implemented and tested

✅
WinGetProcessByHandle
Implemented and tested

✅
WinGetState
Implemented and tested

✅
WinGetStateByHandle
Implemented and tested

✅
WinGetText
Implemented and tested

✅
WinGetTextByHandle
Implemented and tested

✅
WinGetTitle
Implemented and tested

✅
WinGetTitleByHandle
Implemented and tested

✅
WinKill
Implemented and tested

✅
WinKillByHandle
Implemented and tested

✅
WinMenuSelectItem
Implemented and tested

✅
WinMenuSelectItemByHandle
Implemented and tested

✅
WinMinimizeAll
Implemented and tested

✅
WinMinimizeAllUndo
Implemented and tested

✅
WinMove
Implemented and tested

✅
WinMoveByHandle
Implemented and tested

✅
WinSetOnTop
Implemented and tested

✅
WinSetOnTopByHandle
Implemented and tested

✅
WinSetState
Implemented and tested

✅
WinSetStateByHandle
Implemented and tested

✅
WinSetTitle
Implemented and tested

✅
WinSetTitleByHandle
Implemented and tested

✅
WinSetTrans
Implemented and tested

✅
WinSetTransByHandle
Implemented and tested

✅
WinWait
Implemented and tested

✅
WinWaitByHandle
Implemented and tested

✅
WinWaitActive
Implemented and tested

✅
WinWaitActiveByHandle
Implemented and tested

✅
WinWaitClose
Implemented and tested

✅
WinWaitCloseByHandle
Implemented and tested

✅
WinWaitNotActive
Implemented and tested

✅
WinWaitNotActiveByHandle
Implemented and tested

Closing this as the C++ rewrite (#4) is now in progress and all of the functions need to be re-implemented.


Sweet client

Hey, nice socket client! We use yahoo as a fallback data provider.
I lead engineering at Fey and we're looking for engineers (Backend | TS/Node). Wondering if you'd be interested to learn more?

Hey @brotzky ! I took a peek at your platform and I think that Fey’s mission is really exciting and fills a void. I'm especially curious about the mysterious Phase II. I’d love to hear more!

Email me at<EMAIL_ADDRESS>and I'd love to fill you in on all the details!


[Doc]Need to update IS 5.11.0 migration document

Description:
If we used a separate BPS server with the deployment and execute the IS migration client, we get the following error[1].
This is due to the migration client being unable to decrypt the passwords on the WF_BPS_PROFILE table.
Need to need to add a note section for migration docs[2] by mentioning changing the default passwords on the WF_BPS_PROFILE table if using a separate BPS server.
[1]ERROR {org.wso2.carbon.is.migration.MigrationClientImpl} - Migration process was stopped. org.wso2.carbon.identity.core.migrate.MigrationClientException: Error while checking whether the passwords are encrypted with new encryption algorithm.
Caused by: org.wso2.carbon.core.util.CryptoException: An error occurred while decrypting data.
Caused by: org.wso2.carbon.crypto.api.CryptoException: An error occurred while decrypting using the algorithm : 'RSA'
Caused by: java.security.InvalidKeyException: unknown key type passed to RSA
Caused by: org.wso2.carbon.core.util.CryptoException: An error occurred while decrypting data.
Caused by: org.wso2.carbon.crypto.api.CryptoException: An error occurred while decrypting using the algorithm : 'RSA'
[2]https://is.docs.wso2.com/en/5.11.0/setup/migrating-to-5110/

Hi @nilminiwso2,
As per the analysis done in https://github.com/wso2/product-is/issues/12777, CipherTransformation is not defined in IS 5.3.0, IS 5.4.0, and IS 5.4.1 in the <IS_HOME>/repository/conf/carbon.properties file. Hence this issue will be affected to any migration from IS 5.3.0, 5.4.0, or 5.4.1 versions to the latest IS versions.
Thanks,
Sachini

This issue is being closed due to extended inactivity. Please feel free to reopen it if further attention is needed. Thank you for helping us keep the issue list relevant and focused!


ion-item text-center not working ionic 4

Bug Report
Ionic version:
[x] 4.10.3
Current behavior:
<ionic-item text-center>This is some centered text</ion-item>
Text is still left aligned
Expected behavior:
As per docs...
"Text Alignment
Items left align text and add an ellipsis when the text is wider than the item. See the Utility Attributes Documentation for attributes that can be added to  to transform the text."
If text-center is not a valid Utility Attribute for an ion-item, please update the docs.
Steps to reproduce:
As above

Thanks for the issue! Could you please run ionic info and paste that output when you create issues? The 4.10.3 version is the CLI version which doesn't explain as much when it's a framework issue. 🙂
As for the original issue, the item is required to be wrapped in an ion-label in v4:
<ion-item text-center>
  <ion-label>Text centered</ion-label>
</ion-item>

I am seeing the above working here: https://codepen.io/brandyscarney/pen/XOOJzv
All of our usage examples show the item is using an ion-label: https://ionicframework.com/docs/api/item#usage
And we have it added to the breaking changes here: https://github.com/ionic-team/ionic/blob/master/angular/BREAKING.md#label-required
If you find any uses where this is missing in the docs please create a new issue on our ionic-docs repository. Thank you!

Thanks, I missed that "text" must be contained within a label...
"Items are elements that can contain text, icons, avatars, images, inputs, and any other native or custom elements."


init

ready for discussion :)

Awesome! This is a great first cut. We can add more tests as we go but LGTM!! :shipit:


Directory.dir_exists() always fails on res:// type paths even though Directory.open() works

Operating system or device - Godot version:
Windows 10, Godot 2.1 alpha custom build
Issue description (what happened, and what was expected):
directory = Directory.new()
if not directory.dir_exists("res://path/to/dir"):
   print ("Directory does not exist")
if directory.open("res://path/to/dir) == OK:
  print("Directory open works")

Output:
Directory does not exist
Directory open works
Expected:
Directory open works
Steps to reproduce:
directory.dir_exists(directory.get_current_dir())

Link to minimal example project (optional but very welcome):

Fails only after exporting to pck, zip or exe) even tough directory.open(path)
The fix_path(p_dir) call in core/drivers/windows/dir_access.cpp (dir_exists function) does not touch anything when using "res://" on directory access.
directory.open() calls create_for_path in core/os/dir_access.cpp which set _access_type to ACCESS_RESOURCE then da->change_dir() calls fix_path and now "res.//" is replaced with "". Thats why directory.open() works while directory.dir_exists() fails on "res://" type paths.
directory.get_current_dir() returns "res://" so directory.dir_exists(directory.get_current_dir()) always fails on "res://" type paths.
I still don't understand why it works when running from the editor (and not after exporting)

I still don't understand why it works when running from the editor (and not after exporting)

When running in editor, res:// is an actual directory (your project dir). When exported, be it .pck, .zip or .exe, there's no actual directory, only a single binary file. If dir_exists rely on the OS filesystem functions, this is expected result.
I can't really tell if this is intended behavior. Technically you have full control of res:// (especially in binary formats) and have no need to check if a certain directory exists. But to just fail seems weird for me.

But to just fail seems weird for me

In case I was misunderstood: The call does not fail but returns false when one would expect it to return true.
It's weird to be able to open a directory path which reportedly does not exist.

In case I was misunderstood: The call does not fail but returns false when one would expect it to return true.

Yes, that's what I understood. I meant it shouldn't silently return false.


Supporting Custom Events API

Are there any plans to support the Custom Events API (https://chatbase.com/documentation/events)? It would be nice to have the support of the full feature set that chatbase offers.

agree

Any news? Or ChatBase is dead?

Any update on that ? :)

Hey Everybody,
Sorry for the delay we do have plans to support the custom events API and will be releasing updates to the Chatbase libraries in the next couple months. Sorry for the delay!

Hi @cristiancavalli,
Any update on this?
I found that the link of Custom Events API above (https://chatbase.com/documentation/events) no longer exists.


Update approvers list to include Omer and Toni

/cc @omertuc @celebdor

/verify-owners

/hold
(we'll first add them to the org)

/verify-owners

/verify-owners

/lgtm

/verify-owners

/verify-owners

/unhold


Add reactivity to update chart options when options change

Closes #1477
📑 Description

This PR adds reactivity from the props to run the Apex charts update method
Status

[x] Not Completed
[ ] Completed

✅ Checks

[X] My pull request adheres to the code style of this project
[X] My code requires changes to the documentation
[ ] I have updated the documentation as required
[ ] I have checked the page with https://validator.unl.edu/
[ ] All the tests have passed
[X] My pull request is based on the latest commit (not the npm version).

ℹ Additional Information

Summary by CodeRabbit

New Features

Enhanced the chart component to dynamically update its options when the configuration changes, improving user experience with real-time updates.

Bug Fixes

Ensured proper cleanup of the chart instance to prevent memory leaks when the component is unmounted.

I may be wrong here, since you would expect this action to handle this already? https://github.com/themesberg/flowbite-svelte/blob/main/src/lib/charts/Chart.svelte#L29

Since https://github.com/themesberg/flowbite-svelte/commit/50c84cff293a190a57021bb76b0b7723b4c80768 solves this issue, I am going to close it


[WIP]Remove unused declarations

[ ] Any interfaces changed?

[ ] Any backward compatibility impacted?

[ ] Document update required?

[ ] Testing done
Please provide details on
- Whether new unit test cases have been added or why no new tests are required?
- How it is tested? Please attach test report.
- Is it a performance related change? Please attach the performance test report.
- Any additional information to help reviewers in testing this change.

[ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

Build Failed  with Spark 2.3.4, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbonPRBuilder2.3/1287/

Build Failed with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbonPRBuilder2.2/1276/

Build Failed  with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbonPRBuilder2.1/1266/

Build Failed  with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbonPRBuilder2.1/1268/

Build Failed with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbonPRBuilder2.2/1278/

Build Failed  with Spark 2.3.4, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbonPRBuilder2.3/1289/

Build Failed  with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbonPRBuilder2.1/1270/

Build Failed with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbonPRBuilder2.2/1280/

Build Failed  with Spark 2.3.4, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbonPRBuilder2.3/1291/

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbonPRBuilder2.1/1274/

Build Success with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbonPRBuilder2.2/1284/

Build Success with Spark 2.3.4, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbonPRBuilder2.3/1295/


App crash when turn on notifications

When you switch to on notifications, the app crash and it closes seconds later

i downloaded apk from play store. Notifications do still crash. this thread may help https://stackoverflow.com/questions/58134023/flutter-local-notification-causing-crash-only-in-the-apk-version


Refer SDN plugin names and annotations by constants

Remove unused GetName() from ovs controller and we already have
Name() to return the name of the sdn plugin if needed.

@openshift/networking PTAL

LGTM

LGTM


reorder the administration cmds and add vacuum drop-table and table

This is better the the old, merge it. cc @soyeric128


"style" is a reserved attribute in "form-input.vue"

when i use <f7-list from> component, Vue throw a warn "style" is a reserved attribute and cannot be used as component prop.
Vue version: 2.2.6

I meet it too. Beg for help

The code is fixed, but there hasn't been a release so the package installed uses 0.9.0 which has the bug.

If you want to use it follow these instructies: https://gist.github.com/rvanzon/a83b579d7c0775150ca51c6a3b0a0389

I think npm install -S git+https://github.com/KirinHuang/Framework7-Vue.git is more easier, OR you can just fork the project and build for own repository and npm install -S git+https://github.com/YOURNAME/Framework7-Vue.git. It's more controllable!

Oh，thank you. This warning I think is tolerable. So I choose to ignore it

Yes, it's not a functionality issue

npm install -S git+https://github.com/KirinHuang/Framework7-Vue.git
unluckily . it seems that the problem steal exists


Removed warning for handle-callback-err

Removed the warning we are getting when running npm test for test/cli.js.
The warning was:
86:42 warning Expected error to be handled  handle-callback-err

Looks good! Unfortunately the flaky 0.10 Travis test is failing. @sindresorhus can you restart it?

Thanks @allensb!


Module GoogleMapsBase not Found

When building Cordova for iOS using this plugin I get this error
 /Plugins/com.googlemaps.ios/GoogleMaps.framework/Headers/GMSCoordinateBounds+GoogleMaps.h:13:9: fatal error: module       'GoogleMapsBase' not found
Which causes the Build to fail. Has anyone else found this problem or know a solution?
My config.xml has this:
<plugin name="cordova-plugin-googlemaps" spec="git+https://github.com/mapsplugin/cordova-plugin-googlemaps.git"> <variable name="API_KEY_FOR_ANDROID" value="androidkey" /> <variable name="API_KEY_FOR_IOS" value="ioskey" /> <variable name="NSLOCATIONWHENINUSEUSAGEDESCRIPTION" value="Show your location on the map" /> <variable name="NSLOCATIONALWAYSUSAGEDESCRIPTION" value="Trace your location on the map" /> </plugin>
The values have my api keys in them.

It works on Android. The issue is linked to the iOS build

Same for me on the master branch and also on v2.0 branch.
Its very critics, I can not release a new version of my app.
Any solution or work around?

Please show me the result of cordova plugin list

com.googlemaps.ios 2.2.0 "Google Maps SDK for iOS"
cordova-admob-sdklibs 2.1.4 "Google Mobile Ads SDK for Cordova"
cordova-background-geolocation 2.7.0 "BackgroundGeolocation"
cordova-plugin-admob-simple 3.3.3 "Cordova-Phonegap AdMob Plugin"
cordova-plugin-app-event 1.2.0 "Application Events"
cordova-plugin-app-version 0.1.9 "AppVersion"
cordova-plugin-background-fetch 4.0.2 "CDVBackgroundFetch"
cordova-plugin-cocoalumberjack 0.0.4 "CocoaLumberjack"
cordova-plugin-device 1.1.6 "Device"
cordova-plugin-dialogs 1.3.3 "Notification"
cordova-plugin-globalization 1.0.7 "Globalization"
cordova-plugin-google-analytics 1.8.2 "Google Universal Analytics Plugin"
cordova-plugin-googlemaps 1.4.0 "phonegap-googlemaps-plugin"
cordova-plugin-inappbrowser 1.7.1 "InAppBrowser"
cordova-plugin-insomnia 4.3.0 "Insomnia (prevent screen sleep)"
cordova-plugin-network-information 1.3.3 "Network Information"
cordova-plugin-spinner-dialog 1.3.1 "SpinnerDialog"
cordova-plugin-splashscreen 4.0.3 "Splashscreen"
cordova-plugin-statusbar 2.2.3 "StatusBar"
cordova-plugin-tts 0.2.3 "TTS"
cordova-plugin-vibration 2.1.5 "Vibration"
cordova-plugin-x-socialsharing 5.1.8 "SocialSharing"
cordova-plugin-x-toast 2.6.0 "Toast"
cordova-plugin-yanap 0.8.9 "Yanap"
cordova-sqlite-storage 2.0.4 "Cordova sqlite storage plugin"
cordova.plugins.diagnostic 3.6.1 "Diagnostic"
de.appplant.cordova.plugin.local-notification 0.8.4 "LocalNotification"
es6-promise-plugin 4.1.0 "Promise"

Here is mine:
com.googlemaps.ios 2.2.0 "Google Maps SDK for iOS"
cordova-plugin-console 1.0.5 "Console"
cordova-plugin-device 1.1.4 "Device"
cordova-plugin-googlemaps 1.4.0 "phonegap-googlemaps-plugin"
cordova-plugin-splashscreen 4.0.3 "Splashscreen"
cordova-plugin-statusbar 2.2.2 "StatusBar"
cordova-plugin-whitelist 1.3.1 "Whitelist"
ionic-plugin-keyboard 2.2.1 "Keyboard"

Thank you for letting me know. I modified symbolic links for cordova.
Please reinstall the plugin.
You can do
$> cordova plugin rm com.googlemaps.ios --force

$> cordova plugin add https://github.com/mapsplugin/cordova-plugin-googlemaps-sdk --nofetch

The app now builds successfully but the map is a black image.

I could display a map without no problem.
The reason of blank map is different reason.
https://github.com/mapsplugin/cordova-plugin-googlemaps-doc/blob/master/v1.4.0/TroubleShooting/Blank-Map/README.md

It is not blank. Where the map should appear is solid black, no map functions work and it does not access for location permissions.

I have tried both:
ion-app._gmaps_cdv_ .nav-decor {     background-color: rgba(0,0,0,0); }
and
ion-app._gmaps_cdv_ .nav-decor{   background-color: transparent !important; }
and map map always looks like this

please share your whole project files on github (or other git repository services). Then I will check it.

I have just added you as a collaborator on the project.

Works perfect for me, thanks a lot!

@tgb20 I checked your code, but I don't know why the plugin does not work in your app.
I also noticed that your app blocks the script running of this plugin.
Unfortunately I'm not familiar with ionic.
I recommend you use the plugin v2 instead of v1.4.
Please check this document page, and try it.
https://github.com/mapsplugin/cordova-plugin-googlemaps-doc/tree/master/v2.0.0/For-ionic2-users#how-to-install-the-cordova-googlemaps-plugin-v2-beta-on-ionic-2

@tgb20 ping

Since @tgb20 does not reply in one week, and the original issue (Module GoogleMapsBase not Found) was already solved, I close this issue at once.
If you have any update, you can still reply and open this issue.


git dependency data lost

before:
dep = { git = "https://github.com/org/repo", rev = "longhexstring" }

after:
dep = "*"

Needless to say, this doesn't work :)

doesnt look right!


chore(package): update @kronos-integration/service to version 5.3.0

:tada: This PR is included in version 3.0.1 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Add terraform module

Issue

Solution

TODO:

[x] Update the .gitignore file for terraform files.
[x] Call terraform fmt -check -recursive as part of CI

[x] github workflow (local demo)
[x] Tandem PR in observability repo

[x] Add .tftest.hcl files to use with terraform test as part of itests.

[x] Use local-exec to create the s3 bucket.
[ ] Include OpenTofu in itests (?)
[ ] See if we want to use pytest-terraform instead of terraform test.

[x] Add integrations into module itself (is it possible / sensible?)
[x] Decide where (which repo) to keep the worker module, the coordinator module, and potentially the mimir-ha module.
[x] Add a "constraints" input var. Example.

Refs:

https://discourse.charmhub.io/t/introducing-the-juju-terraform-provider/6939
https://github.com/juju/terraform-provider-juju/blob/main/.github/workflows/test_integration.yml
https://registry.terraform.io/providers/juju/juju/latest/docs#example-usage
https://github.com/canonical/terraform-modules/tree/main/modules/machine/postgresql-ha

Context

Testing Instructions
terraform test

Release Notes

Note that the unit tests are failing due to a breaking change in ops > 2.16.
Here is a PR that addresses it.

@MichaelThamm Thanks for the update in my old PRs :)


fix(fieldset): Support customProperties with sub-fields clashing with reserved words.

The bug(what)
Passing the below jsfOption config to createHeadlessForm, we get an error;
createHeadlessForm(schema, {
  customProperties: {
    a_field_set: {
      name: { // 🔥 name is a reserved keyword
        type: "hidden",
      },
    },
  },
});

The solution
This PR updates the path used for getting customizing (jsfOptions) of the fields inside a fieldset.  Before this was been read from the parent field (fieldset) but now we read them within the customProperties of the parent field
// BEFORE
{
...
customProperties: get(config, `customProperties.${name}`, {})
}

//AFTER
{
...
customProperties: get(config, `customProperties.${name}.customProperties`, {})
}

And so the failing jsfOption example above becomes;
// 👍 works as expected
createHeadlessForm(schema, {
  customProperties: {
    a_field_set: {
      customProperties: {
        name: {
          type: "hidden",
        },
      },
    },
  },
});

It also updates test cases to read the customisation from the new path.

This is all good my side from testing it internally with Remote.


implement -h and/or --help to display help

$ wcag -h

or
$ wcag --help

to print out usage/help-text.
If there are no objections I can implement this on my next iteration

:+1: Very much needed.

Fixed by https://github.com/cfpb/node-wcag/pull/6


Update to recent busybox 2014.11 tar

Move up to the latest busybox tarball that has the fix for ip command
segfault.
Docker-DCO-1.1-Signed-off-by: Phil Estes<EMAIL_ADDRESS>(github: estesp)

LGTM

Nice!
LGTM


Feature request: Only routes

Like the ignore option, add a only: string[] option to only accept routes like
{
  only: ['/api/_']
}

I think it should be usable WITH ignore to only apply routes like /api and ignore /docs /swagger (default name provided by the doc)

PRs are always welcome.
Also, I think the number of routes that should be shown outweights the ones that shouldn't. So this is mostly redundant, especially since the config is copy & paste, which has everything setup correctly.


Rspec unit tests PR

Hello,
In this branch me and @josuerushanika;

Added below unit tests:

Book
Person
Student
Teacher
Classroom
Rental
Decorator
Capitalize decorator
Trimmer decorator

Fixed linter errors

Looking forward to hearing from you.
Thanks.

Thank you @hiromataba 👍


feat: OSC escape sequence progress bar status support

Depends: #32
Fixes: #25

Screencast From 2024-12-05 01-28-46.webm


Minor optimization for Cherrytree.dispatch

This PR does the following optimizations:

Returns pathname in match and use alongside the dispatch code path preventing Path.withoutQuery being called more than once
Use some instead of forEach in match to break loop earlier and allow remove of found var

By analyzing the blame information on this pull request, we identified @KidkArolis, @nathanboktae and @oliverwoodings to be potential reviewers

Some is not available in IE8, but who cares, am i right?

Many thanks


[MINOR][SQL][SS] Move streaming source impl to separate package

What changes were proposed in this pull request?
Only refactor current code structure. There is not new code added.
Put streaming source impl (v1 or v2) into separate package
How was this patch tested?
No new unit test added.

Build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/9545/
Test PASSed.

Test build #104208 has started for PR 24275 at commit 969a706.

Test build #104208 has finished for PR 24275 at commit 969a706.

This patch fails Scala style tests.
This patch does not merge cleanly.
This patch adds no public classes.

Build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/104208/
Test FAILed.

Retest this please

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/9546/
Test PASSed.

Test build #104209 has started for PR 24275 at commit 30f13f9.

Test build #104209 has finished for PR 24275 at commit 30f13f9.

This patch fails Scala style tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/104209/
Test FAILed.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/9547/
Test FAILed.

Test build #104210 has started for PR 24275 at commit 963c496.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/9548/
Test PASSed.

Would any of those classes be public, and visible to users?
Also is it not reasonable to call the existing packages "v1" and only put "v2" in new subpackages?
Don't strongly object here, just wondering how much it's worth moving all that code.

Test build #104210 has finished for PR 24275 at commit 963c496.

This patch fails PySpark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/104210/
Test FAILed.

@srowen Thanks for your reply.

Would any of those classes be public, and visible to users?

No, there is not any user-visible class changes.

Also is it not reasonable to call the existing packages "v1" and only put "v2" in new subpackages?

There are some data source implementations located in different packages, and it looks like a little bit confusing. Besides, there are some implementation based on DataSource V2. So this PR slightly reorganized these classes. And honestly, I am not totally sure "v1" and "v2" subpackages is a good idea.
Any suggestion is appreciated!

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/9570/
Test PASSed.

Test build #104234 has started for PR 24275 at commit 83a0574.

Test build #104234 has finished for PR 24275 at commit 83a0574.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/104234/
Test FAILed.

Retest this please.

Test build #104237 has started for PR 24275 at commit 83a0574.

Test build #104237 has finished for PR 24275 at commit 83a0574.

This patch fails PySpark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/104237/
Test FAILed.

pending on fixing unit test failure

I tend to agree with @srowen . Removing the extra * is absolutely fine but I wouldn't have also confidence to commit such sudden movement without measurable value.


Implement QR-Code Reader

User story

As a user
I want to take an image of a qr code
So that I can open the door

Acceptance criteria (Frontend Only)

Open camera to scan QR Code
Send Data on scan to backend

Definition of done

Added only after week 5
The same for all features