How to write the declaration document with typescript?

Hi can you add more detail, I'm unfamiliar with TS?

Hi Danielasy if you’d like to then that would be great!

I would also appreciate, as I'm using react-image-crop in a project that we're moving to typescript (Thanks @DominicTobias btw for your work).
To be compatible with typescript, you only need a declaration file for the interfaces of the component (like PropTypes but more powerful) and a line in your package.json to precise to the typescript compiler where to find the declaration file

Hello all, it took a while but I opened a PR at DefinitelyTyped. Feel free to check it out: https://github.com/DefinitelyTyped/DefinitelyTyped/pull/25431

This has been merged now so closing, thanks @danielasy

Would you consider merging the types in with this library and setting them up in package.json/types so that we don't have to install the @types package separately?

Hi we don't need to merge them we can simply declare them as a dependency in this module so you don't have to install them yourself as per this comment https://github.com/Microsoft/types-publisher/issues/81#issuecomment-234051338
If you want to make a PR for that I'd be happy to merge as I won't be able to do it until some time next week.


[BUG] Query creates unexpected behaviour and cannot be explained

Describe the bug
Some queries will execute and yet cannot be explained. Query result was unexpected.
To Reproduce
Steps to reproduce the behavior:

Go to Query Workbench
Run SHOW tables LIKE .% (note the .)
Click the Run button
See the results (I have two less here than with SHOW tables LIKE % - why? 🤷♂ Doesn't seem to follow the wildcard pattern)
Click 'Explain'
The results will be "This query is not explainable."

Expected behavior
Any run-able query can be explained.
Plugins
All OpenSearch Plugins.
Host/Environment (please complete the following information):

OS: MacOs
Version Chrome Version 90.0.4430.212 (Official Build) (x86_64)
OpenSearch 1.0 RC-1

Hi Kyle @stockholmux  thanks for reporting the bug. I just reproduced this issue in my local host. For the SHOW statement, the (valid) system indices are by default not showing up from the query engine. I also tried out the query show tables like '.%' where the wildcard is quoted with single quotes since the wildcard name has special character in it, and the result gives the full list of indices starting with dot including the valid system indices. We will investigate this bug to make it behavior more properly. Thanks!
As for the explanation of queries, I tried the queries show tables like % andshow tables like '.%' in devtools and workbench to test the behavior of both the engine and the workbench, looks like it's working fine:
POST _plugins/_sql/_explain
{
  "query": "show tables like '.%'"
}

{
  "root": {
    "name": "ProjectOperator",
    "description": {
      "fields": "[TABLE_CAT, TABLE_SCHEM, TABLE_NAME, TABLE_TYPE, REMARKS, TYPE_CAT, TYPE_SCHEM, TYPE_NAME, SELF_REFERENCING_COL_NAME, REF_GENERATION]"
    },
    "children": [
      {
        "name": "FilterOperator",
        "description": {
          "conditions": """like(TABLE_NAME, ".%")"""
        },
        "children": [
          {
            "name": "OpenSearchSystemIndexScan",
            "description": {
              "request": "OpenSearchCatIndicesRequest{}"
            },
            "children": []
          }
        ]
      }
    ]
  }
}

I thinks the "not runnable" issue might come from the missing single quotes.

Closing. Please reopen as needed. Thanks!


SS VAE

I noticed that the example does not explicitly use a classifier like mentioned in Kingma et al. 2014 to predict the labels, is that right?

It actually does. The objective functions objectives.montecarlo.elbo and objective.importance.elbo both incorporate the classification term with default strength alpha=0.1. The objective is montecarlo is the one that is defined in the paper.


1.33 Release [T - 4w] Updating boringssl

@yashykt

Basic Tests Python MacOS (also seen in fusion consistently)
Basic Tests Ruby MacOS (seen in fusion intermittently)


Vertical and horizontal scrollbar not displayed in the lateral panel

STR :

Open the lateral panel with the details of a WS
Press Esc to open the split console
Expand the height of the console so a scrollbar should appear

Actual result : There is no scrollbar in the lateral panel.
Florent

I can see a scrollbar, see my screenshot...
Or should I look somewhere else?
Honza

Yep, you have them. It looks like a specific issue with the Linux theme. I'll take a screenshot once at home.
Florent

This commit should fix that.
Please let me know if it helps.
Honza

Have checked that right know and that works like a charm. I close the issue.
Florent

Cool, thanks for the update.
Honza


Not able to deploy apps in new project because of error relating to no default regions being present.

Acorn version v0.6.0-77-g5c64a93e+5c64a93e
Steps to reproduce the problem:
Create a new project.
Deploy app in that project.
App deployment fails with following errors:
  ✗  ERROR:  App.api.acorn.io "mytest2" is invalid: spec.region: Invalid value: "": no region can be determined because project default region is not set

 %acorn project create testnew
testnew
% acorn project use testnew
% acorn run -n mytest2 .
[+] Building 3.5s (5/5) FINISHED
 => [internal] load build definition from Dockerfile                                                                                0.0s
 => => transferring dockerfile: 48B                                                                                0.0s
 => [internal] load .dockerignore                                                                                0.0s
 => => transferring context: 35B                                                                                0.0s
 => [internal] load metadata for docker.io/library/nginx:latest                                                                                1.2s
 => CACHED [1/1] FROM docker.io/library/nginx@sha256:f4e3b6489888647ce1834b601c6c06b9f8c03dee6e097e13ed3e28c01ea3ac8c                                                                           0.0s
 => => resolve docker.io/library/nginx@sha256:f4e3b6489888647ce1834b601c6c06b9f8c03dee6e097e13ed3e28c01ea3ac8c                                                                                0.0s
 => exporting to image                                                                                2.3s
 => => exporting layers                                                                                0.0s
 => => exporting manifest sha256:0ff71b46d22886f535ff153809798ba0fea5343f0f93c1d174f4e2222445c3be                                                                                0.0s
 => => exporting config sha256:71e271c6570043c75162588a9534cf04d9c3803a8e24175422b88509000ac2c3                                                                                0.0s
 => => pushing layers                                                                                2.3s
 => => pushing manifest for <IP_ADDRESS>:5000/acorn/testnew:latest@sha256:0ff71b46d22886f535ff153809798ba0fea5343f0f93c1d174f4e2222445c3be                                                         0.0s
[+] Building 0.1s (5/5) FINISHED
 => [internal] load build definition from Dockerfile                                                                                0.0s
 => => transferring dockerfile: 58B                                                                                0.0s
 => [internal] load .dockerignore                                                                                0.0s
 => => transferring context: 64B                                                                                0.0s
 => [internal] load build context                                                                                0.0s
 => => transferring context: 505B                                                                                0.0s
 => CACHED [1/1] COPY . /                                                                                0.0s
 => exporting to image                                                                                0.0s
 => => exporting layers                                                                                0.0s
 => => exporting manifest sha256:5c477f161b5c6294285e11cd4982823589180a073dbade0b0f4e8a4ca9025721                                                                                0.0s
 => => exporting config sha256:0b487a76c9baa0c1ac350513e16fdfe10bc5463806c5056db7f820a5f83cdfc0                                                                                0.0s
 => => pushing layers                                                                                0.0s
 => => pushing manifest for <IP_ADDRESS>:5000/acorn/testnew:latest@sha256:5c477f161b5c6294285e11cd4982823589180a073dbade0b0f4e8a4ca9025721                                                         0.0s
  ✗  ERROR:  App.api.acorn.io "mytest2" is invalid: spec.region: Invalid value: "": no region can be determined because project default region is not set

Tested with acorn version v0.6.0-81-g5856fe34+5856fe34
Create a new project.
Able to deploy apps successfully in new projects.


Resolve linter issues

Description
Per #184, we stopped redirecting npm run lint to /dev/null. This PR fixes some existing linting issues.
Issue reference
Please reference the issue this PR will close: #188
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list:

[X] Code compiles correctly
[ ] Created/updated tests (NA
[ ] Extended the documentation (NA)

@XavierGeerinck, should we enforce linting, going forward?

/cc @XavierGeerinck for review

LGTM


[extractor/megatvcom] Add new extractor

Please follow the guide below

You will be asked some questions, please read them carefully and answer honestly
Put an x into all the boxes [ ] relevant to your pull request (like that [x])
Use Preview tab to see how your pull request will actually look like

Before submitting a pull request make sure you have:

[x] Searched the bugtracker for similar pull requests
[x] Read adding new extractor tutorial
[x] Read youtube-dl coding conventions and adjusted the code to meet them
[x] Covered the code with tests (note that PRs without tests will be REJECTED)
[x] Checked the code with flake8

In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:

[x] I am the original author of this code and I am willing to release it under Unlicense
[ ] I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

[ ] Bug fix
[ ] Improvement
[x] New extractor
[ ] New feature

Description of your pull request and other information
This patch adds support for video extraction from megatv.com, a popular Greek content provider and (recently re-)established TV network.

Add new IEs

MegaTVComBaseIE: Base IE class
MegaTVComIE: Extract from TV VOD pages and news articles, i.e. all sorts of pages showing videos on megatv.com
MegaTVComEmbedIE: Extract iframe-embeddable megatv.com videos

When video_id is not matched in the URL, namely for news articles, extract it (article_id) from a particular element on the web page
Derive metadata and sources directly from the web page, from data attributes of the player placeholder element and other commonly used elements
Let MegaTVComEmbedIE defer to MegaTVComIE for extraction, as the metadata on the embeddable page are some times slightly different, for the same video

Is there anything else I can do to have this patch reviewed?


ESCAPE not being cleared on BREAK

Another Escape clearing bug!  If you push ESCAPE somewhere that it won't be handled and then push BREAK, you're dropped back into RVBASIC but whatever command you type (e.g. OLD) will print Escape when you push RETURN and not be executed.
For example, in my case, I've assembled some RISC-V code using the BASIC assembler and have CALLed it and it runs.  My code doesn't, however, check for nor handle ESCAPE, so pushing it does nothing and the machine code continues running.  But, after pushing BREAK, I get the spurious Escape after the first command back in RVBASIC.
This is similar to bug #15.

I suppose this could be a PiTubeDirect copro bug - I haven’t seen what happens if you do this outside RVBASIC.  You’ll know better than me, though!

The case you reported was BBC Basic, but there may well be a similar issue in the tube ROM itself, as I don't think the workspace (inc the default escape flag) is cleared on reset. I'll investigate with the debugger,

I just tried running the code from the * prompt directly (i.e. not in RVBASIC) and didn't get the same behaviour there (i.e. running commands after BREAK didn't do a spurious Escape).

I think there is a latent bug in the RISC-V Tube ROM, because it doesn't clear the escape flag on BREAK. It's not causing an error because nothing is currently reading it directly.
The escape flag is a bit unusual. On the 6502 Co Pro it's in a well known location (&FF) and it's effectively part of the MOS API, i.e. languages are allowed to check it directly. I think this is for efficiency.
On the RISC-V Tube ROM the escape flag is at a different address (&FBFE00), so I'm not sure we want programs to be hard-coded with that.
In JGH's PDP11 Co Pro docs, he gives various ways of checking for escape. See the section titled "Escape state" here. It's possible to use OS_HANDLERS to ask for the address of the escape flag, or even change it. That also works the same on RISC-V.
Anyway, this does I think need clearing as well on BREAK. So I'll add that code as well.


can't use transactions with sqlhooks

I can't start transaction with non default isolation level because connection returned from sqlhooks.Conn wrapper doesn't implement driver.ConnBeginTx interface https://github.com/golang/go/blob/master/src/database/sql/ctxutil.go#L100

@minaevmike see the implementation of sqlhooks. There are many optional interfaces which sqlhooks does not implement. Depending on how many upstream drivers implement ConnBeginTx sqlhooks can always support it, or do a more complicated implementation which first checks the underlying driver (unfortunately go doesn't make it easy to hook in with the driver pattern).

@minaevmike looks like you have a pretty good understanding of the solution, how long do you htink it could take to implement ConnBeginTx?

@gchaincl I don't think that it would take a lot of time. If you are not mind I can do it.

@minaevmike please that would be great! as @keegancsmith contributions are welcome

@minaevmike any progress on this one?

tx interface
func (conn *Conn) BeginTx(ctx context.Context, opts driver.TxOptions) (driver.Tx, error) {
}


Scheduling Parameters don't work

https://sendgrid.com/docs/API_Reference/SMTP_API/scheduling_parameters.html
Using the Python API setting this header either results in a JSON Parsing error (if the send_at parameter is an integer) or has no effect on delivery time (if cast to a string).
I am calling set_headers on my message before sending with the SendGrindClient as follows: message.set_headers({'send_at': calendar.timegm(datetime.utcnow().utctimetuple()) + 100}).
The header is being attached to the message, but the API responds with a 400: "(400, b'{"errors":["JSON in headers could not be parsed"],"message":"error"}')".
I'm not sure if I am using set_headers() correctly or if I am misinterpreting the SMTP API itself.
When I form the header as follows: {'send_at': str(calendar.timegm(datetime.utcnow().utctimetuple()) + 100)} I receive a 200, but the email is sent immediately (so the header has no effect).
Technical details:
sendgrid-python Version: 1.6.22 and 2.2.1
Python Version: 3.4.4

Hello @cjmochrie,Thanks for your suggestion or question! In an attempt to clear out our backlog,                                              we are closing out issues over 90 days old.                                             If this is still an issue, please feel free to reopen it.                                             Team SendGrid DX-Docs


feat(ast, syntax, ast_tools): Introduce GetNodeId trait.

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#5776  👈
#5775
#5774
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @rzvxa and the rest of your teammates on  Graphite


add Extents as input to map + test

Damn I messed up the merge somehow.

No, the tests are not passing!
I'm not sure how this PR changes the number of tiles downloaded

Oh you have just changed the number of tiles and the tests slightly. Fix that and we can merge

Thanks

@rafaqz thank you for your patience as a battle git


Upgrade claims installer type changed while it hasn't

Brief description of your issue
When trying to upgrade the package "BelgianGovernment.eIDViewer" from version 5.1.5998 to version 5.1.6019, winget claims that the installer type changed.
However when querying the information of both versions it clearly shows the same installer type. See screenshot below

Steps to reproduce

Install version 5.1.5998 of "BelgianGovernment.eIDViewer"
Try upgrading to version 5.1.6019 (currently the latest version)

Expected behavior
The upgrade to be installed successfully.
Actual behavior
The upgrade fails with the text:

A newer version was found, but the install technology is different from the current version installed. Please uninstall the package and install the newer version.

Environment
Windows Package Manager v1.4.10173
Copyright (c) Microsoft Corporation. All rights reserved.

Windows: Windows.Desktop v10.0.19045.2965
System Architecture: X64
Package: Microsoft.DesktopAppInstaller v1.19.10173.0

Looks like the installer actually extracts and runs an MSI, which causes the mismatch. I'll try updating the manifest

@denelon - The AppsAndFeaturesEntries have been updated so that it should expect the MSI entry type, but the issue is still occurring. Probably an edge case that wasn't considered during the initial implementation.

Does it have a productCode or upgradeCode?

Does it have a productCode or upgradeCode?

I don't believe the AppsAndFeaturesEntries have the product code specified, but I did specify InstallerType: msi in the AppsAndFeaturesEntries

OK, I'll see if I can find someone else to look into what's going on here.


Remove lodash

This pr is for #85.

@sttk Can you remove the travis changes? I know OSX takes a long time to run but it's nice to have.

@phated I've removed the travis changes.
The failure of travis will be fixed by  #87.

Ran this on a new branch and it passed.  Thanks again @sttk

@phated Thank you for merging this, too.


Update multigym.py

Types of changes

[ ] Docs change / refactoring / dependency upgrade
[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Motivation and Context / Related issue

How Has This Been Tested (if it applies)

Checklist

[ ] The documentation is up-to-date with the changes I made.
[ ] I have read the CONTRIBUTING document and completed the CLA (see CLA).
[ ] All tests passed, and additional code has been covered with new tests.

Same as #1166 ?

Same as #1166 ?

This is PR to PR actually: I merge it.


unins000.exe

Every 5 minutes this error notification appears on my screen when vscode is running:
image

Same here.  I am also using Jupyter files in browser at same time. Error appeared first time today when I opened an .ipynb file in VS Code.
unins000.exe appears to be an uninstall file and is accompanied by a .dat and .msg file of same name, both binary. Dragging them into Notepad++ reveals some readable text that appears to include messages that might appear during an installation.
.msg file top line: Inno Setup Uninstall Log (b)
.dat file top line: Inno Setup Messages (5.5.3)

When you installed the UserSetup of VS Code... did you run the setup as an administrator?

I was logged to my Win10 Notebook in an account that is an administrator.
Did I need to right click the setup file and "Run as administrator" as well?
If so, can I uninstall VSCode, then reinstall, with settings saved?
I expect that I would need to note and reinstall extensions.
(Would the same all apply to my Visual Studio install?)

Did I need to right click the setup file and "Run as administrator" as well?

No no. That's exactly what you shouldn't do.

If so, can I uninstall VSCode, then reinstall, with settings saved?

Yes you can, nothing will be deleted.

So, Is there anything that should be done so as to "run the setup as an administrator" - other than be logged on as an administrator?
And, does it matter whether it installed for All Users or only Current User (if it asks).
The VS Code install guideline pages seem to offer very limited guidance, such as at https://code.visualstudio.com/docs/setup/setup-overview
This 3rd party one looks more helpful https://www.thewindowsclub.com/visual-studio-code-download
Is there a better guide so as to get the install correct?
BTW, this unins000.exe error has only appeared in the last couple of days when using a couple of particular Jupyter notebooks. I have only recently starting use Code and VStudio but this issue did not occur till yesterday.

Something to consider.
I also have Anaconda installed on this laptop and Anaconda recently added vscode to its distribution. In the Anaconda Navigator, I now see vscode 1.26.1 available to "Launch" which appears to open the same vscode with the same set of installed extensions.

Keeping my suggestion:
If you are going to install VS Code on a machine for other users to use, please use the old, global, system-wide Setup. Do not use the UserSetup.
If you are already doing that, and this specific error still shows up, let me know.

In my case, I uninstalled and re-installed VS Code with it installed into my user appdata folder.
Since doing that I no longer receive the unins000.exe error.


Tab completion doubles e every time e is the current character when hitting tab or right-cursor to finish completion.

Prerequisites

[X] I've checked the existing issues and I'm not duplicating a report.
[X] I've checked the zimfw Changelog and I'm not being affected by documented changes.
[X] I've checked the zimfw 📢 Announcements and I'm not being affected by announced changes.

Bug description
When performing a tab completion or cursor right to use the selection as shown the rest of the way, zim seems to always repeat the e again. This happens on Linux and macOS both, and it's repeatable but not consistent. Once resolved once it seems to stop doing it, but it's consistent that it continues to happen.
On a fresh booted system, for something, especially previous in history, type the command and stop where it has the e, then tab or right cursor, and often times it will duplicate the e.
Steps to reproduce

On a fresh booted system, for something, especially previous in history, type the command and stop where it has the e, then tab or right cursor, and often times it will duplicate the e.

Current behavior
e is duplicated causing an error if you try to run it.
Expected behavior
Completion works without duplicating the e.
zimfw info
zimfw version:        1.12.1 (built at 2023-09-16 18:25:16 UTC, previous commit is 26151d2)
LANG:                 en_CA.UTF-8
LC_TELEPHONE:         en_CA.UTF-8
LC_MEASUREMENT:       en_CA.UTF-8
LC_ADDRESS:           en_CA.UTF-8
LC_NAME:              en_CA.UTF-8
LC_NUMERIC:           en_CA.UTF-8
LC_IDENTIFICATION:    en_CA.UTF-8
LC_PAPER:             en_CA.UTF-8
LC_MONETARY:          en_CA.UTF-8
LC_TIME:              en_CA.UTF-8
OSTYPE:               linux-gnu
TERM:                 screen-256color
TERM_PROGRAM:         tmux
TERM_PROGRAM_VERSION: 3.3a
ZIM_HOME:             /home/psi-jack/.zim
ZSH_VERSION:          5.9

Additional context
No response

Hi @erenfro. Check https://github.com/zimfw/zimfw/issues/504, https://github.com/starship/starship/issues/4669 and stackoverflow.com/q/19305291/2654518

I looked at them, but I'm not thinking this is the same. This has been going on a while, but literally only ever does it on the e character, and nothing else. Newly installed systems too.  I can also go back to the repeated e, delete/backspace it, and correct it, too. When I say it's been going on a while, I mean probably a couple years now,. I just finally broke down and saw it happen on my MacBook and decided it's time to look into this and report it. It happens on Fedora 18-38, Debian 12+, Arch Linux, and also macOS. I am using eriner. LANG has been en_US.UTF-8, and now en_CA.UTF-8.


Donut chart improvements

This change improves donut chart interactivity and adds following new functionality:

Donut chart now supports custom colors on top of existing support for predefined types,
Added thickness property for whole chart as well as individual segments,
Improved hover indication and added tooltip for selected segment,
Fixed chart sizing and some other small issues,

Signed-off-by: Milan Klanjsek<EMAIL_ADDRESS>Which issue(s) this PR fixes

Fixes #1465

Note that for single segment charts we show small gap at the end of the segment. This is due to limitation of svg arc functionality and I decided not to work around it because it's consistent with the way we show gaps between segments. Could be addressed in future if deemed necessary.

Note that for single segment charts we show small gap at the end of the segment. This is due to limitation of svg arc functionality and I decided not to work around it because it's consistent with the way we show gaps between segments. Could be addressed in future if deemed necessary.

@GuessWhoSamFoo PTAL

@GuessWhoSamFoo PTAL


Call function with args

Can we not call functions and pass in arguments? i.e t.setTimeout(lightEyes(true), 40000);

No, it doesn't work that way, setTimeout expects a function to be passed to its first argument, the example that you gave executes the function and passes the result of the executed function as the first argument of setTimeout, the function to be passed must not have any arguments and return void

you can do this instead:
t.setTimeout([]() {
  lightEyes(true);
}, 40000);

Ok thats brill thanks for clearing up


.active class on a table-stripped doesn't work anymore

I'm not sure if this is an issue on version 2.0 but adding .active doesn't change the background of a row any more if I use table-stripped.

As I recall, we never had a .active on striped tables. What exactly are referring to?

maybe I was wrong. So is there any way to change the background of a specific row? I tried to use in-line CSS but it doesn't work.

Make sure you're setting the background color on the td/th elements, not the tr.

@cgunther is correct—target your CSS like so, .table td { ... }. In 2.0.1-wip, be aware though that we have added back the hover styles for rows that do change the background color of any td and th in a tbody tr.


fix:copy-update admin only posting rooms

Details

Fixed Issues

$  https://github.com/Expensify/App/issues/23819
PROPOSAL: https://github.com/Expensify/App/issues/23819#issuecomment-1662149068
Tests

Verify that no errors appear in the JS console.
Create 2 accounts "User A" "User B".
As "User A" account Create a Workspace. Invite "User B".
As "User A" account Create a room (say #test). Invite "User B".
Verify Hero text in begining of chat history of room  is

in English - Welcome to #room_name!
in Spanish - ¡Bienvenido a #room_name!

As "User A" Navigate to room Details -> Settings -> change Who Can Post to "Admins Only"
Verify Body text in begining of chat history of any room is

in English - Only admins can send messages in this room.
in Spanish - Solo los administradores pueden enviar mensajes en esta sala.

Offline tests

Same as Test steps above

QA Steps

[x] Verify that no errors appear in the JS console
Same as Test steps above

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web
https://github.com/Expensify/App/assets/104348397/848d8468-57cb-4983-8baa-7b35b60c26b2

Mobile Web - Chrome
https://github.com/Expensify/App/assets/104348397/f2aedf2d-8d1d-4149-af2b-3d92a10d4f2f
https://github.com/Expensify/App/assets/104348397/655a03f9-51db-468c-8d49-4caa99e2b34f

Mobile Web - Safari
https://github.com/Expensify/App/assets/104348397/a380b8c3-040c-43d1-af14-71d03df79e20

Desktop
https://github.com/Expensify/App/assets/104348397/995d1049-d764-4641-8c1f-aa63852c7664

iOS
https://github.com/Expensify/App/assets/104348397/f6cec05b-71e0-4fee-a005-72479e96b35b

Android
https://github.com/Expensify/App/assets/104348397/70135dd1-f633-4092-8a28-6980e2a54fed

I have read the CLA Document and I hereby sign the CLA

will update videos for all platforms, waiting for confirmation https://github.com/Expensify/App/issues/23819#issuecomment-1681020370

@eVoloshchak PR is up for your review

@joelbettner since you are assigned by melvin can you review please?

@ishpaul777, the code looks good, there are a couple of small changes required

Change Tests to a numbered list of tests a manual QA tester would perform (something like tests in https://github.com/Expensify/App/issues/23819, but extended)
It shouldn't say Only admins can send messages in this room if user is an admin
Pull the latest changes from main

PolicyUtils.isPolicyAdmin is what you need I think

what should be the copy for admins in room? is it the same as when room is for all Members to send messages.
Collaboration between all {workspace} members starts here! 🎉 Use #announce to chat about anything {workspace}  related.

please confirm if these are copy for welcome messages in different conditions. (I dont want to make a assumption that may results is regression later). i'll upload videos as soon as i get confirmation
 if (isAdminsOnlyPostingRoom(report)) {
        if (isUserPolicyAdmin) {
            if (isAnnounceRoom(report)) {
                welcomeMessage.phrase1 = Localize.translateLocal('reportActionsView.beginningOfChatHistoryAnnounceRoomPartOne', {workspaceName});
                welcomeMessage.phrase2 = Localize.translateLocal('reportActionsView.beginningOfChatHistoryAnnounceRoomPartTwo');
            } else {
                welcomeMessage.phrase1 = Localize.translateLocal('reportActionsView.beginningOfChatHistoryUserRoomPartOne');
                welcomeMessage.phrase2 = Localize.translateLocal('reportActionsView.beginningOfChatHistoryUserRoomPartTwo');
            }
        } else {
            welcomeMessage.phrase1 = Localize.translateLocal('reportActionsView.beginningOfChatHistoryAdminOnlyPostingRoom');
        }
    } else if (isAnnounceRoom(report)) {
        welcomeMessage.phrase1 = Localize.translateLocal('reportActionsView.beginningOfChatHistoryAnnounceRoomPartOne', {workspaceName});
        welcomeMessage.phrase2 = Localize.translateLocal('reportActionsView.beginningOfChatHistoryAnnounceRoomPartTwo', {workspaceName});
    }

is it the same as when room is for all Members to send messages

@ishpaul777, yes, exactly

@ishpaul777, tests are failing

@eVoloshchak fixed

@eVoloshchak Please review changes I'll add videos in meantime

🚀 Deployed to staging by https://github.com/joelbettner in version: 1.3.56-2 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

This PR is causing this regression: https://github.com/Expensify/App/issues/25718

🚀 Deployed to production by https://github.com/roryabraham in version: 1.3.56-24 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅

🚀 Deployed to staging by https://github.com/joelbettner in version: 1.3.58-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/luacmartins in version: 1.3.58-5 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


ILike string method not working on Test

When using iLike operation on a test, the query sql became ILIKE and make the test error when generating the sql string, but when the code run normally, the query sql became LIKE so it doesn't make the application error.
Am I missing something?
Thank you

Im going to need an example that demonstrates this error. Closing for now, please reopen if you can provide a working example.


Fix: 2022-05-27

Hello Hors,
I hope my contribution can expand the project, until the next opportunity :)
Thx,
Keowu

Thanks a lot!


When process.env.NODE_PATH is set, npm-check -g still goes in…

bugfix: When process.env.NODE_PATH is set, npm-check -g still goes into globalModulesPath instead of NODE_PATH

@lcxfs1991 could you review this please? ☺

Can anyone merge this pull request? That would be super handy, because I just had exactly this problem when working with NVM (node version manager) on windows, because it uses different, symlinked folders, so setting NODE_PATH helps alot.

@totkeks I just hit the same issue. @dylang Can we please merge this in, it will help us few Window users out here!

I have encountered the same error too.
===============================
The global path you are searching is: D:\xampp\node\node_modules
[npm-check] debug
set key cwd to value C:\Users\Karin\AppData\Roaming\npm\node_modules
I sincerely hope that this will improve.


Remove Python2 leftovers

This PR removes Python2 leftovers since this project aims for Python3.6+ (and as of 2020 Python2 is no longer officially supported)

merging since the CI is fixed on master


container-images: add a kompute variant

Add a container variant that enables llama.cpp's kompute backend to enable GPU acceleration using Vulkan.
Tested with krunkit on Apple Silicon with mistral-7b-instruct-v0.2.Q4_0.gguf and Wizard-Vicuna-13B-Uncensored.Q4_0.gguf (>=13B models benefit the most being offloaded to GPU vs. running them on the CPU).
TODO:

[ ] Teach ramalama to choose the best container image for the context.
[ ] Ensure every operation works transparently when operating on a container.
[ ] Add some Q4_0 models to shortnames.conf
[ ] Expose shortnames.conf into the container.
[ ] Expose llama.cpp's server port when running in a container.

Would it make more sense to layer this on the original image?
from quay.io/ramalama/ramalama:latest
...

That's not a bad idea @rhatdan, we can just replace the CPU-only binaries with these kompute ones.
We do have an issue though, been trying to make these ubi9-based as Scott McCarthy requested, I think that makes sense, but UBI images are missing access to a small set of required packages, we can make it work by pulling the CentOS Stream ones via something like:
RUN dnf install -y git procps-ng vim dnf-plugins-core cmake gcc-c++ \
      python3-pip python3-argcomplete && \
    dnf clean all && \
    rm -rf /var/cache/*dnf*

RUN dnf config-manager --add-repo https://mirror.stream.centos.org/9-stream/AppStream/$(uname -m)/os/
RUN dnf config-manager --add-repo https://mirror.stream.centos.org/9-stream/BaseOS/$(uname -m)/os/
RUN curl -O http://mirror.centos.org/centos/RPM-GPG-KEY-CentOS-Official
RUN mv RPM-GPG-KEY-CentOS-Official /etc/pki/rpm-gpg/
RUN rpm --import /etc/pki/rpm-gpg/RPM-GPG-KEY-CentOS-Official

RUN dnf install -y vulkan-headers vulkan-loader-devel vulkan-tools glslc
      glslang && \
    dnf copr enable -y slp/mesa-krunkit && \
    dnf install -y mesa-vulkan-drivers-24.1.5-101 && \
    dnf clean all && \
    rm -rf /var/cache/*dnf*

But then it becomes kinda a hybrid UBI9/Stream image.

Could you turn on x86_64 epel builds for this also @slp :
https://copr.fedorainfracloud.org/coprs/slp/mesa-krunkit/
I wanna try that out with an x86_64 GPU 😄

I think EPEL would be a better solution then centos-stream if they are all available.

Then aren't in EPEL @rhatdan :'(

UBI repos seem to be a subset of RHEL:
https://cdn-ubi.redhat.com/content/public/ubi/dist/ubi9/9/x86_64/appstream/os/Packages/
https://cdn-ubi.redhat.com/content/public/ubi/dist/ubi9/9/x86_64/baseos/os/Packages/
not sure exactly what defines a package being RHEL-only or RHEL+UBI

I'm afraid the situation the Vulkan-related packages in CentOS Stream 9 is kind of broken (i.e. spirv-headers-devel is nowhere to be found, even though some packages that depend on it are present in the repos). I can't even rebuild the same Mesa spec in my COPR.
I think F40 is the only option for now.   Isn't the one in the parent layer the same?
Or do you have to compile it differently for kompute?

Who is using the     dnf install -y spirv-headers-devel package?
Should this be just used during build and removed before finished?

So it would be more like this:
FROM quay.io/ramalama/ramalama:latest

RUN dnf config-manager --add-repo https://mirror.stream.centos.org/9-stream/AppStream/$(uname -m)/os/
RUN dnf config-manager --add-repo https://mirror.stream.centos.org/9-stream/BaseOS/$(uname -m)/os/
RUN curl -o /etc/pki/rpm-gpg/RPM-GPG-KEY-CentOS-Official http://mirror.centos.org/centos/RPM-GPG-KEY-CentOS-Official
RUN rpm --import /etc/pki/rpm-gpg/RPM-GPG-KEY-CentOS-Official

RUN dnf install -y vulkan-headers vulkan-loader-devel vulkan-tools glslc \
      glslang epel-release && \
    dnf install -y spirv-headers-devel && \
    dnf copr enable -y slp/mesa-krunkit epel-9-$(uname -m) && \
    dnf install -y mesa-vulkan-drivers-24.1.5-101 && \
    dnf clean all && \
    rm -rf /var/cache/*dnf*

RUN git clone --recurse-submodules https://github.com/ggerganov/llama.cpp && \
    cd llama.cpp && \
    git reset --hard ${LLAMA_CPP_SHA} && \
    cmake -B build -DCMAKE_INSTALL_PREFIX:PATH=/usr -DGGML_KOMPUTE=1 -DGGML_CCACHE=0 && \
    cmake --build build --config Release -j $(nproc) && \
    cmake --install build && \
    cd / && \
    rm -rf llama.cpp

But I there may be other reasons @slp cannot build the latest variant for EPEL9 I guess... I notice only an older version is build for EPEL9 aarch64...
If RHEL9/RHEL10 won't be suitable for this kind of thing, it would be nice to document somewhere was packages are missing in both RHEL9 and RHEL10 and if they are in EPEL, etc.

Do RHEL/RHEL AI customers have access to full-RHEL containers? Not just the subset of packages in UBI, this is also something I am curious about...

Yes they have full access to RHEL content.

v2:

Extend the existing Containerfile instead of building a new one.
Use ubi9 instead of Fedora 40.
Add a cli option to request GPU offloading.

I'm curious if we need the llama.cpp downgrade and would be nice to see the total size difference between cpuonly and a cpuonly+kompute container image

Sadly, we do need the downgrade because the kompute backend it's broken in master. This happens frequently with pretty much every backend except cpu. I want to take a look to see if I can fix it myself in master, but can't make any promises.
As for the size, this is what I'm getting here:
localhost/ramalama-cpuonly           latest               56a6236affe0  About a minute ago  660 MB
localhost/ramalama-kompute           latest               c312022f66a5  About an hour ago   862 MB

Should I add a commit renaming the directory? Feels weird keeping the name cpuonly

Yes rename, I would prefer to keep one image for CPU and Kompute with the limited size difference.

cpuonly + kompute (merged image) = generic
Just a suggestion...

I would rather name it ramalama or vulcan.
If ramalama then others can build their Vendor specific images from it.


Add redundancy to multipod codeowners

Description
We need some redundancy for multipod reviewers, as a single point of failure can be a bottleneck.
This changes add @tonyjohnchen @raymondzouu  from the perf side and @RissyRan for the MOE side, since these areas are the most frequent code changes.
Tests
Please describe the tests that you ran on Cloud VM to verify changes.
N/A
Checklist
Before submitting this PR, please make sure (put X in square brackets):

[x] I have performed a self-review of my code.
[x] I have necessary comments in my code, particularly in hard-to-understand areas.
[x] I have run one-shot tests and provided workload links above if applicable.
[x] I have made or will make corresponding changes to the doc if needed.

Ran's out for a couple of weeks still, I'll see if she wants to join when she's back.


User selectable default units.

Feature/enhancement would be to have user selectable default units. Maybe as global/keyword variables?
Default_Length = [mm] or something like that and then any length result that doesn't specifically call out a unit would use that value. I would not expect it to change any other unit for example torque would still come out as N*m and not N*mm. For the scale of my work most of the data is in inches or millimeters and having to add the extra four characters ([mm] or [in]) just to keep my result in the same units as my input data gets old.
The next two ideas are related although I'd aim for the above one first:

Detect local cell units, if I type 25[mm] + 75 [mm] = it would notice than all of my values use the same units and then give me my result in mm.

Allow results in multiple units. 25[mm] + 75[mm] = [mm | in] = 100[mm] | 3.937[in] I do a lot of work back and forth between English and metric and different people have a better feel for one or the other so I often just present both values. This would save an extra cell just for unit conversion.

In case you couldn't tell I discovered your application this week and think it is pretty great. I am a full time mechanical engineer and was looking for an open source solver that would help me keep track of units and provide easy graphs etc, pretty much everything your work is doing.  Please keep up the great work!

Thanks for the feedback and encouragement, much appreciated. I don't notice some of the pain points a new user may notice, so I appreciate the feedback from that prospective.
Yes, I agree that output units should match user units. I actually prefer the approach to keeping track of the units the user is using and mirroring those in the results as apposed to manually specifying the preferred unit. Would need to keep track of units across the entire sheet, since using variables, the user might not specify units in the cell they are querying the result in. This could apply to units on the RHS of a query statement as well, so that a unit would only need to be specified once for compatible units.
Nice idea about allowing querying values with multiple units. It's a little more involved since it involves changing the equation parser, but doable.
I'm working on updating some of the core code from JavaScript to TypeScript (#163) to make some of these changes easier to implement. The current core code is a bit gnarly and hard to update safely because of how it constructs objects on the fly rather than all at once with types.


How to add a blank attribute

How to add an attribute that does not equal anything.

I figured it out, you just make it = None


Create cm-facebook.json

creating cameroon facebook file using github website

Thanks @aawiseman - looks perfect!  welcome to the project! 👋

BTW thanks @aawiseman for all your contributions recently! To speed things up, I've invited you to be a maintainer on this project.  Feel free to triage issues, merge PRs, and commit directly to the main branch anything that you feel good about. 🙇


ReferenceError when variable does not exist

Hello, Stephenson
I'm getting the following exception when I try to compile a template function without any variables.
Uncaught ReferenceError: id is not defined

Suppose I have the following template:
<span data-id="<%= id %>"><%= content %>

And I run this with the function:
JST["template"]()

It won't work.
Using Rails 3.1.1 with Asset Pipeline.

Please, ignore this issue. It was my mistake.


Feature or bug? Imported local variables from external files (modules) are visible in NB.

Describe the bug
Let us have the files functions.py and local_test.py (marimo notebook) in the same directory.
File functions.py:
import marimo as mo

def _md(s):
    return mo.md(s)

File local_test.py generated by marimo:
import marimo

__generated_with = "0.1.88"
app = marimo.App()

@app.cell
def __():
    import marimo as mo
    return mo,

@app.cell
def __():
    from functions import _md
    return

@app.cell
def __():
    _md("# Hello marimo")
    return

if __name__ == "__main__":
    app.run()

The "local" variable _md is visible in cell below and the application runs correctly. I like such behaviour, because I can define things in (several) .py files and use them in notebook. It works with substantially larger notebook. Is this intended, or I should better not rely on that remarkable feature?
Environment
{
"marimo": "0.1.88",
"OS": "Linux",
"OS Version": "5.19.0-0.deb11.2-amd64",
"Processor": "",
"Python Version": "3.11.2",
"Binaries": {
"Chrome": "--",
"Node": "v18.19.0"
},
"Requirements": {
"black": "23.12.1",
"click": "8.1.7",
"jedi": "0.19.1",
"pymdown-extensions": "10.7",
"starlette": "0.36.1",
"tomlkit": "0.12.3",
"typing_extensions": "4.9.0",
"uvicorn": "0.27.0"
}
}
Code to reproduce
No response

This is a feature you can rely on. We explicitly don't mangle imported names, with our reasoning being that in many cases the user may not have control over the naming conventions of imported packages. Not that you would have seen it, but there is a comment to this effect in our codebase.
Glad this feature was helpful for you!


Update Spark Iceberg image to v0.13.1

Required for testing v2 tables with merge-on-read deletes.

release as 55

@alexjo2144 can you please also rename the image to spark3-... ?
it looks like an omission in https://github.com/trinodb/docker-images/pull/119, but I would be grateful if you could fix that


Site review

first batch
probably a more subjective change, but suggesting the following order to help with flow of content:
FHIR for Research
FHIR from 10,000 Feet
FHIR History
FHIR from 1,000 Feet
FHIR Resources
Using the FHIR API
Terminology and FHIR
Common Data Models
Real World Research - wasn't sure with this one, but could also be placed near history
Genomics Data Standardization with FHIR
Community & Documentation

is 'Accessible PDF' in index.qmd in suppose to be a link as well or are users expected to manually print to PDF the previous Printable web page?

On 'Overview', 'Genomics Data Standardization with FHIR' needs highlighting for 'Research Leader'

On 'Using the FHIR API', right navigation arrow should point to 'Genomics Data & FHIR'

check navigation arrows, left comments on modules


handle validate user case api down

Hey @elhachimi - what's the situation where data would not be returned? Are you using this in conjunction with devise_token_auth? A little bit of background would be great. We also need this branch to be rebased against master before it can be merged. Thanks in advance for any follow-up.

Hey @booleanbetrayal i'me using it with python-social-auth in a django-rest backend, and when the backend is down it returns no data so the front-end bugs while trying to retrieve data.error.

@elhachimi - Seems reasonable. Do you mind rebasing against master and resolving the conflicts? Also, not to nitpick, but capitalizing the "No" in that return message would make it a bit more consistent, and it would be nice to get some test coverage on this use case. Please let me know if you have any questions. Thanks!

Hey  @booleanbetrayal rebased this branch against master

I'll open another pull request


Need new release for Blazor 0.9.0

Just saw that there is an outstanding Pull Request that will accomplish this, although there is no corresponding issue for the PR.

+1

Updated to preview4


using tar.bz2 for releases instead of .bz2 to preserve permissions.

Currently restic uses bz2 files of the binaries for the releases on GitHub. bz2 clobbers file permissions, including executability, resulting in an extra step of having to chmod the binary after extracting but before running it. This is the first time I've seen compressed software like this, where the binary isn't wrapped in tar before compression and distribution. I'm just wondering why releases are packaged like this and/or if there was a discussion about it at some point. Thanks!

This might be out of scope, but if packaging is changed anyway, it might be a good idea to switch from .bz2 to .tar.xz. The archive would be smaller and decompression faster.

As a saltstack user installing restic from Github, I second this motion since it would also make state management a lot easier. Saltstack doesn't support decompressing a bz2 compressed file using the archive module (since bz2 isn't an archive). Instead, I have to download and decompress the file myself.

The current packaging using just .bz2 makes it easy to reproducibly create the release binaries. To use .tar.bz2 we'd need a way to deterministically generate the tar file.
Regarding the compression method, we'd probably also want to consider this comment: https://github.com/restic/restic/issues/2705#issuecomment-618493679

I have the exact same issue with Ansible as @thefirstofthe300 has with saltstack

The current packaging using just .bz2 makes it easy to reproducibly create the release binaries. To use .tar.bz2 we'd need a way to deterministically generate the tar file.

If it's of use, this reference page includes some flags you can add to tar to help make the output more deterministic, including overriding file modification timestamps and specifying file order.
https://reproducible-builds.org/docs/archives/


[dv,chip_sw] Add all_escalation_resets_test

This supersedes the pwrmgr and rstmgr escalation reset tests, and replaces
the clkmgr_escalation_reset test. In addition, it tests most other ip instances.
Signed-off-by: Guillermo Maturana<EMAIL_ADDRESS>

Dear reviewers, there are some details that may need ironing out regarding specific hardware details for some IPs, like the ones marked with a TODO. The software side should be ready for review, and I think the overall flow is solid.
But comment away!

When I ran rstmgr tests, they were stopped due to errors.
This error check is executed before LC reset request is generated so, rst_lc is not generated and I was not able to see fault_status reg is cleared by rst_lc.
I ran this command : ./util/dvsim/dvsim.py ./hw/top_earlgrey/dv/chip_sim_cfg.hjson -i chip_sw_all_escalation_resets --run-opts +inject_fatal_error_for_ip=rstmgr
If there is a specific way or command option, please let me know.
Error message is as follows.
UVM_ERROR @ 3496.441324 us: (cip_base_scoreboard.sv:433) [uvm_test_top.env.scoreboard] Check failed item.d_error == exp_d_error (1 [0x1] vs 0 [0x0]) On interface chip_reg_block, TL item: req: (cip_tl_seq_item@121378) { a_addr: 'h100000b4  a_data: 'h0  a_mask: 'hf  a_size: 'h2  a_param: 'h0  a_source: 'h0  a_opcode: 'h4  a_user: 'h2482a  d_param: 'h0  d_source: 'h0  d_data: 'hffffffff  d_size: 'h2  d_opcode: 'h1  d_error: 'h1  d_sink: 'h0  d_user: 'heaa  a_source_is_overridden: 'h0  a_valid_delay: 'h0  d_valid_delay: 'h0  a_valid_len: 'h0  d_valid_len: 'h0  req_abort_after_a_valid_len: 'h0  rsp_abort_after_d_valid_len: 'h0  req_completed: 'h0  rsp_completed: 'h0  tl_intg_err_type: TlIntgErrNone  max_ecc_errors: 'h3  }
, unmapped_err: 0, mem_access_err: 0, bus_intg_err: 0, byte_wr_err: 0, csr_size_err: 0, tl_item_err: 0, write_w_instr_type_err: 0, cfg.tl_mem_access_gated: 0 ecc_err: 0

Updated and ready to go... @jeoongp please try this version, since it has a few fixes.

As I ran this test, it's still failed with errors as follows.
UVM_ERROR @ 5677.997250 us: (sw_logger_if.sv:521) [all_escalation_resets_test_prog_sim_dv(w/device/tests/sim_dv/all_escalation_resets_test.c:893)] CHECK-fail: Failed to get an interrupt due to alerts
As I checked the waveform, falut_status regs are successfully cleared but the interrupt is also cleared by this LC reset because alert_handler is driven by LC reset.


GKE kubelet Pod probe source IP denied when using allow-localhost: always

Bug report
Hello! Bumped GKE to 1.21.5-gke.1802 (running Cilium 1.10.4) and all Pods with healthchecks started to fail. Noticed that the probes have started to originate from the source <IP_ADDRESS> (the GKE metadata server IP) which got dropped, therefore failing the Pod healthchecks. Adding a CNP allowing the traffic resolved it. Have previously relied on https://docs.cilium.io/en/v1.10/concepts/kubernetes/concepts/#default-ingress-allow-from-local-host. I'm guessing that the problem is that <IP_ADDRESS> counts as an unmanaged/external IP and not as "local host". It sits on the node lo interface:
# ip -br a
lo               UNKNOWN        <IP_ADDRESS>/8 <IP_ADDRESS>/32 ::1/128

allow-localhost is not explicitly set, so using the default value (auto -> always, being in Kubernetes)
General Information

Cilium version: 1.10.4
Kernel version: 5.4.144
Kubernetes:  GKE 1.21.5-gke.1802

Server Version: version.Info{Major:"1", Minor:"21", GitVersion:"v1.21.5-gke.1802", GitCommit:"d464a255a4acb8dca1e0914586f4f5085681fb51", GitTreeState:"clean", BuildDate:"2021-10-21T21:43:23Z", GoVersion:"go1.16.7b7", Compiler:"gc", Platform:"linux/amd64"}

How to reproduce the issue

Create a GKE cluster at 1.21.5-gke.1802 and install Cilium 1.10.4
Create a default-deny CNP for a namespace

---

apiVersion: cilium.io/v2
kind: CiliumNetworkPolicy
metadata:
  name: default-deny
  namespace: <namespace>
spec:
  endpointSelector:
    matchLabels: {}
  egress:
  - {}
  ingress:
  - {}

Create a workload with network liveness-/readiness-probes in <namespace>
Liveness-/readiness-probes get dropped

Related thread on the Cilium Slack: https://cilium.slack.com/archives/C1MATJ5U5/p1636378965255900
@pchaigno @aditighag

We are also experiencing this issue, and are wondering where the change originates from. Is this caused by a change in the Kubernetes nodes, control plane or Cilium?

It's a change in the nodes, specific to GKE it seems. https://github.com/kubernetes/kubernetes/commit/297ad30610c8212a414846fb7b5d6e90c4875d7d is a suspect.
As Joe mentioned in the linked Cilium Slack thread, one possible solution is to scan the lo interface for IP:s and associating them with the host identity, in order to keep the behaviour in https://docs.cilium.io/en/v1.10/concepts/kubernetes/concepts/#default-ingress-allow-from-local-host

FWIW, newer version of GKE has host in the lo scope for the metadata server IP, which should fix this problem.


Adding a more descriptive README.md

Adding a more descriptive README.md that contains the following information:

Information on the tech stack:

What we're using,
What technologies there are, how to use them, (**what information needs to be included in the CoC Docs)

Why we're using it,
Why was this specific selection of software technology selected, where can it be used in,

how it's being integrated into the implementation of out system
All the technical information including: installation, setup, running, implement

to be reopened in the future

Miscellaneous fixes, typos


running python -m bots.auto_terminal.start raises an attribute error unless it's done within the bots root directory.

workaround: used absolute imports in bots/auto_terminal/start.py


Move lock id to pallet config

Move lock identifier of pallets(staking/democracy/vesting) to the pallet config.
polkadot companion: paritytech/polkadot#3533

what is the interest of having them configurable ? I think having them hardcoded is ok no ?
If it is about discoverability we can add them in the metadata with extra_constant.

related https://github.com/paritytech/substrate/issues/8583


IDE replaces the node contents with the removed node

Discord username
No response
What type of issue is this?
Permanent – Occurring repeatably
Is this issue blocking you from using Enso?

[ ] Yes, I can't use Enso because of this issue.

Is this a regression?

[ ] Yes, previous version of Enso did not have this issue.

What issue are you facing?
When you delete a node, ctrl-click another node to edit, then exit without editing. The contents of the node is replaced with the deleted node.
Expected behaviour
The node contents remain the same.
How we can reproduce it?
No response
Screenshots or screencasts
https://user-images.githubusercontent.com/357683/236467410-80247756-be1b-42c1-8d1d-872338fa7ad7.mp4
Enso Version
a842130ff3162595f093e554a7d943c967146e63
Browser or standalone distribution
Chromium
Browser Version or standalone distribution
113.0.5672.63
Operating System
Linux
Operating System Version
No response
Hardware you are using
No response

Duplicate of #6411
Removing node is not necessary here, the issue is fixed in #6594


Cell type handlers is not good idea.

It's wrong to test a date is date;
for example '11.15%',
new Date('11.15%') ;   // is date, but unexpected;

Sometimes 1245.67% gets into a date and sometimes into a ###############. Everything else is really great. Thanks!


Update condition.js

Please fill in this pull request template before submitting
1. This pull request resolves #64
2. Description
Added tutorial for ternary operator with description and example.
3. Fill in checklist by marking [x]

[x] I've read the CONTRIBUTING.md
[ ] I was assigned to this issue
[x] My code is formatted using required linting
[x] I've run my code locally and checked it works

Kindly merge this under Hacktoberfest

Kindly read it and merge under hacktoberfest.
Closes #64
@sabderemane

I'm sorry @sshikhar09 , someone ask for the assignment on the issue before


cp: add support for copy filename with ":"

We use ":" as separator for CONTAINER:PATH.
This patch enables copy filename with ":"
to host.
Signed-off-by: Chen Hanxiao<EMAIL_ADDRESS>

The new test failed on Windows.
Can you add testRequests(SameHostDaemon) to the top of your test since you're creating dirs that are being used for the test?

@cpuguy83
Sure, I'm not familiar with Windows.
@duglin
Fine, will do

@cpuguy83 @duglin
updated, please check.

LGTM

this probably closes an issue, so that needs to be in the first commet as fix #blah

LGTM

ping @cpuguy83 for the merge

@jfrazelle
I made a quick search on open issues with key words "docker cp", found no related issues with this PR.

LGTM


[Event Request] page 7018 "Purchase Price List" - OnAfterGetDefaultSourceType

Could we please get the following event?
local procedure GetDefaultSourceType(SourceGroup: Enum "Price Source Group") DefaultSourceType: Enum "Price Source Type";
begin
    case SourceGroup of
        SourceGroup::Vendor:
            DefaultSourceType := Rec."Source Type"::"All Vendors";
        SourceGroup::Job:
            DefaultSourceType := Rec."Source Type"::"All Jobs";
    end;
    //+EVENT
    OnAfterGetDefaultSourceType(SourceGroup, DefaultSourceType);
    //-EVENT
end;

[IntegrationEvent(true, false)]
local procedure OnAfterGetDefaultSourceType(PriceSourceGroup: Enum "Price Source Group"; var DefaultPriceSourceType: Enum "Price Source Type")
begin
end;

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.
Build ID: 10741.


Create utp.txt

https://pbs.edu.pl/pl/

@hns5 Thank you for your patience while waiting for a review and processing your request. Pull request merged.


Adds logo with no text and small square icons.

Fixes #1025

Edges on the lower-res ones are pretty pixel-y, are there different re-sampling settings you can use when you scale it down?


Add ANTELA Smart WLAN Lamp E27

Device information
Amazon-Link
Home Assistant Device information
ANTELA-9W-RGB+CCT (bf0f80ef7db65f56bfwkpm)
von Tuya
Firmware: 3.3
Checklist

[x] I have created a single PR per device. When you have multiple submissions please create separate PR's.
[x] For lights - I have only included the gzipped files (*.gz), not the raw CSV files.
[x] For lights - I have provided a CSV file per supported color mode. Look that up in Developer Tools -> States

Additional info
Measured quite precisely with an PZEM004T module

Great! Everything looks fine to me.


As a user I would like names sorted alphabetically in the Agent String search

When I see a list of names, and I am searching for synonyms of myself, then I have to look at the whole list, when many could be side/by/side enhancing potential issues?

That's a tricky one. Elasticsearch scores are used for the sort, which operates on weights of various parts of names. See https://github.com/bionomia/bionomia/blob/master/helpers/query_helper.rb#L8. What you see here are agent name strings that come back with roughly equal weight & so it's a blast of everything. Contrast the resultset ordering with a search for "M. Yoder". Something so simple is maddeningly hard because it'll affect paging. Will require some digging.

OK, I might have something here to play with that can use both scores and specific fields https://www.elastic.co/guide/en/elasticsearch/reference/current/sort-search-results.html

Could just sort client side?  That is a small number of names?

Could. But, would hate to introduce any conditions that need to watch for resultset size. Contrast yours with https://bionomia.net/agents?q=Smith :)~

So desperately want to paste an Agent Smith meme... but issue ethics.

Done, deployed, and re-indexed! Thanks for the prompt.

Much better, and far more informative IMO.  One letter difference scream out.  Thanks for the super speed!


⚠ DesiTorrents has degraded performance

In 62591a4, DesiTorrents ($DST) experienced degraded performance:

HTTP code: 200
Response time: 1706 ms

Resolved: DesiTorrents performance has improved in 2804156 after 18 minutes.


Fix sendMessage being unable to tag names

Fix issue where sendMessage is unable to tag other users due to a Facebook change.
https://github.com/Schmavery/facebook-chat-api/issues/507

Thanks so much!


#458 Changed font to the desired font in the image

#458

Because

This PR

Issue

Closes #XXXXX
Additional Information

Pull Request Requirements

[x] I have thoroughly read and understand The Odin Project Contributing Guide
[x] The title of this PR follows the location of change: brief description of change format, e.g. 01-flex-center: Update self check
[x] The Because section summarizes the reason for this PR
[x] The This PR section has a bullet point list describing the changes in this PR
[x] If this PR addresses an open issue, it is linked in the Issue section
[x] If applicable, I have ensured that the TOP solution files match the Desired Outcome image

Hi @Soonull,
Thank you for addressing the font issue in this pull request.
I've been following the discussion on the related issue, and I believe there might be a slight misunderstanding. While I value the effort you put into this, I was already prepared to make the changes and had been awaiting confirmation from TOP before proceeding.
Looking forward to hearing your thoughts and those of the TOP representative. Thanks!


Aid Treeshaking by importing only what is needed

There are two big dependencies within iD, one is lodash, the other is d3. By using:
import * as d3 from 'd3' everything is imported. Within a modern setup using Rollup or Webpack2 this hinders Treeshaking to perform well. If only e.g. the dispatch function is used from d3 within an iD module, then its just fine to import:
import dispatch from 'd3-dispatch';
If this is done consequently, the build system is able to get rid of unused modules easily, saving tons of KBs. While d3 is already split into various modules, for lodash we would have to switch to https://www.npmjs.com/package/lodash-es
Any thoughts or blockers on this issue?

Yes, when we did #3257 and #3344, I had the idea that we would eventually replace those import * with better imports that just target the modules that are really needed.  Thanks for opening this issue!
There aren't any real blockers, but it would probably be good to wait until we release 2.2 and then clear out some of the PR backlog before changing lots of files.

I did some work on this which lives here:  https://github.com/openstreetmap/iD/pull/4372#issuecomment-332292559
Leaving this issue open because the bundle didn't actually shrink at all and there are other blockers now - but maybe we are closer!


Provide Orbie App Icon

1024 x 1024 pixel
PNG or SVG
no rounded corners!

@n8fr8, I cannot assign Carrie. Can you add her to the project?

hmmm, that is a bit lofi

I'm not sure that is the official icon anyhow... I will add Carrie.

Yeah. Sorry. This totally doesn't fill the spec and I really doubt it will look good, after Xcode did it's resizing, edge cutting and what-not magic.


critical: UNIX line endings instead of windows CRLF

Currently the builder spits out UNIX Line endings instead of the required Windows line endings.
This results in none of the files being read by the LP engine. (At least on Windows host OS)

To be precise: as the bulder also touches all other file this renders the lpmod, lpaction, lpstat etc etc ununsable as well.

To be precise: as the bulder also touches all other file this renders the lpmod, lpaction, lpstat etc etc ununsable as well.

Not fixed completely. 👎
Includes will still result in LF.

Not fixed completely. 👎
Includes will still result in LF.


Tutorial Video for installation?

I'm new and only got basic skill of programming. Is there tutorial video for backend / dashboard installation out there?
Would be appreciate it! Thank you

There is no video yet, we are trying to make our documentation better first. The idea is prettty nice, I will try to record one in spare time if I get any :)

You're awesome! appreciate it! Thanks!

Hi, did you manage to get free time to make the video for installation, as i am a newbe. If not do you have better documentation ?

Hi! Sorry, nope, we are developing and maintaining a bunch of projects now and pretty busy for making a video. The documentation has been updated couple of times during the last few months. It would be really helpful if you ask concrete questions and help us to improve docs.


About capturing the imagedata

Hi~Is it possible to capture the imagedate from Android Phone？Do you have this plan in the future? I think it's good to the popularization and spread of your work.

We don't have the capacity to develop an Android app currently but we will definitely consider your advice in the future. Thanks!


upload zebi coin

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

[x] Filename in the lowercase format
[x] Image format: png
[x] Image size: 256 by 256 px

Is something still missing?

Take a look at requirements: https://github.com/TrustWallet/tokens#requirements

not sure, tokens logo still not showing....

From: Viktor Radchenko<EMAIL_ADDRESS>Sent: Sunday, April 29, 2018 4:08 PM
To: TrustWallet/tokens
Cc: artictypsrsx; Author
Subject: Re: [TrustWallet/tokens] upload zebi coin (#130)
Is something still missing?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/TrustWallet/tokens/pull/130#issuecomment-385277800, or mute the threadhttps://github.com/notifications/unsubscribe-auth/Ak6QLA4s4t2f6R-cvihaeUEAoquXiaV3ks5tth21gaJpZM4Tr7k1.

@artictypsrsx PR not merged yet because it doesn't satisfy requirements.

Zebi Coin (ZCO)
Chainium (CHX)
Fintab (FNTB)
1Worldonline (1WO)
Dropil (Drop)
Appreciate your help!
Sent from my iPhone
Joe
On Apr 30, 2018, at 3:50 PM, Viktor Radchenko <notifications<EMAIL_ADDRESS>wrote:
@artictypsrsxhttps://github.com/artictypsrsx which one didn't show an image? can you list them in here I will fix it for you
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/TrustWallet/tokens/pull/130#issuecomment-385508983, or mute the threadhttps://github.com/notifications/unsubscribe-auth/Ak6QLPUnxaQjMJTzgACAuhsoLuZwvOVZks5tt2sSgaJpZM4Tr7k1.

@artictypsrsx show me your screenshot, can you make sure you have the latest version of Trust?

[image1.png]
[image2.jpeg]
[image3.jpeg]
Sent from my iPhone
Joe
On Apr 30, 2018, at 5:01 PM, Viktor Radchenko <notifications<EMAIL_ADDRESS>wrote:
@artictypsrsxhttps://github.com/artictypsrsx show me your screenshot, can you make sure you have the latest version of Trust?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/TrustWallet/tokens/pull/130#issuecomment-385527493, or mute the threadhttps://github.com/notifications/unsubscribe-auth/Ak6QLACC2EOlEFYVHdxril4jmM3Q87oRks5tt3uigaJpZM4Tr7k1.

@artictypsrsx images not attached


4.x: Unable to change Swagger doc title and description while using web-context property

Environment Details

Helidon Version: 4.0.1
Helidon MP
JDK version:
OS:
Docker version (if applicable):

Problem Description
After upgrading from Helidon 3.2.1 MP to 4.0.1 MP Swagger doc title and description do not change when it is used with web-context property. This was working fine with Helidon 3.2.1.
This issue is easily reproducible.
Steps to reproduce

Add below dependencies in pom.xml

io.helidon.microprofile.openapi
helidon-microprofile-openapi
4.0.1

io.helidon.integrations.openapi-ui
helidon-integrations-openapi-ui
4.0.1

io.smallrye
smallrye-open-api-ui

Add below config in microprofile-config.properties file.
openapi.web-context=/jobstatus/api/openapi
openapi.services.ui.web-context=/jobstatus/api/doc
mp.openapi.extensions.smallrye.info.title=Jobstatus Documentation

Here the Swagger title will be changed but it will be available on this default path http://localhost:8080/openapi/ui/index.html Hence web-context property is ignored.

If you add the below config.
openapi.web-context=/jobstatus/api/openapi
openapi.services.ui.web-context=/jobstatus/api/doc

Here the Swagger title will not be changed and it is available on this path http://localhost:8080/jobstatus/doc
You can also reproduce using this property mp.openapi.model.reader=fre.fabs.podinfo.common.configuration.SimpleAPIModelReader instead of mp.openapi.extensions.smallrye.info.title=Jobstatus Documentation

It worked with replacing all the config with mp. Below config worked for me.
mp.openapi.web-context=/jobstatus/api/openapi
mp.openapi.services.ui.web-context=/jobstatus/api/doc
mp.openapi.services.ui.options.title=Jobstatus Service APIs Documentation
mp.openapi.extensions.smallrye.info.title=Jobstatus Service APIs Documentation
mp.openapi.extensions.smallrye.info.description=This page list out all the APIs related to Jobstatus Service. It will also let you test the APIs.


[BUG][OpenSearchDashboards] OpenSearch Dashboards fails to start when readOnlyRootFilesystem set to 'true'

Describe the bug
When I set the readOnlyRootFilesystem key to 'true', the OpenSearch Dashboards pod cannot be started.  The following messages appear in the pod log:

FATAL  Error: Unable to write OpenSearch Dashboards UUID file, please check the uuid.server configuration value in opensearch_dashboards.yml and ensure OpenSearch Dashboards has sufficient permissions to read / write to this file. Error was: EROFS

In addition, I can find no example or documentation showing the configuration variable (uuid.server) mentioned in the error message.
To Reproduce
Steps to reproduce the behavior:

I added the following stanza to my user-values.yaml file:

securityContext:
  readOnlyRootFilesystem: true

Deploy OpenSearch Dashboards using Helm (and pointing to the user-values.yaml file)
I can see the OpenSearch Dashboards pod starting up but fails fairly early with the error messages shown above.
If I remove that stanza, OpenSearch Dashboards comes up without problems.

Expected behavior
I expected OpenSearch Dashboards to come up without problems.   I would also expect to find some mention of the configuration variable (uuid.server) in the documentation or sample opensearch-dashboards.yml files.
Chart Name
I've seen this error with using both OpenSearch Dashboards version 1.3.5 (Helm chart version 1.5.1) and 2.4.1 (Helm chart version 2.7.0).
Host/Environment (please complete the following information):

Helm Version: 3.7.0
Kubernetes Version: 1.22.3

Additional context

I notice that readOnlyRootFilesystem key is included (on line 95) in the Helm charts values.yml file but commented out.
I also noticed is that if I omit the readOnlyRootFilesystem key (which allows OpenSearch Dashboards to come up), and SSH onto the running OpenSearch Dashboard pod, the file /usr/share/opensearch-dashboards/data/uuid and owned by user "opensearch-dashboards" (UID:1000) rather than root.

@prudhvigodithi Could you please advise here?

@rishabh6788 @prudhvigodithi   I've just tested with OpenSearch Dashboards 2.6.0 and the problem persists. The log messages have not changed from what I reported earlier. Can either of you provide some guidance on how to overcome this and/or when it might be fixed?  Thanks!

@rishabh6788 @prudhvigodithi
I may have found a work-around.  Obviously, a true fix would be better but maybe this will work until then.  I added an extra volume/mount for the uuid file to my yaml file and that appears to let OpenSearch Dashboards come up.   Here's what I added to the yaml file:
 extraVolumes:
 - name: uuid-file
   emptyDir: {}

 extraVolumeMounts:
 - name: uuid-file
   mountPath: "/usr/share/opensearch-dashboards/data/"
   subPath: uuid

Based on a few minutes of quick testing, OSD appears to be functional at a basic level (documents are returned, security is enforced).     Do you see any potential issues/problems with this work-around?  As I said earlier, a real fix to eliminate the need for this kind of hack would be a much better solution.  And I was not successful finding something similar for the OpenSearch readOnlyFileSystem (#369).

Hey @gsmith-sas to work with readOnlyRootFilesystem you need a custom volume and mounts where the readOnlyRootFilesystem is not applicable. The solution you provided seem to be a right way to move forward. @DandyDeveloper @TheAlgo can you please advise?
Thank you


Time Series Anomaly Detection

Hi, I would like to know if there is a Time Series Anomaly Detection model present in Anomalib codebase. If yes, please share me the link else if there are any plans to build a model –
[1] What is the dataset that is being considered for developing such model (LSTM/GRU) ?
[2] Will this model be trained on multiple features i.e Multivariate LSTM ?
Thanks and Regards

Hi @aryanxk02, I think the following paper would be of interest since it proposes a model that could be used in image and time series domains, respectively.
https://paperswithcode.com/paper/set-features-for-fine-grained-anomaly

Thanks for sharing, I will go through it @samet-akcay


Support bootstrap 4

Hi @AllenFang:
I'm trying to support bootstrap 4 and I'll take a look on how it was implemented in react-bootstrap-table. It would be take refer to but won't be the same. If there's any concern or advices, please let me know. Thanks a lot :)

@AllenFang
Ok got it. Currently I'm trying to come up with a new way to not use a flag as react-bootstrap-table did. Unless there's no better solution, I will pick up the same way.
const isBootstrap4 = Util.isBootstrap4(this.props.version);

@Chun-MingChen sure, that's a good idea!!

Hello @Chun-MingChen, good job! Please what is the status of this? Can we start using Bootstrap 4?

@coommark it does need some time, we will support it ASAP, thanks!!

Also the table-condensed class changed to table-sm. The condensed prop for ReactBootstrapTable2 adds the incorrect class name right now and has no effect. You can get around it by using classes="table-sm" right now.

just wondering (since I'm about to finish a project, and I'm still doubting if I should revert to the react-bootstrap-table or not): any ETA for bootstrap4 support?

@kurt-o-sys I think before July or middle of June :)

:+1:

see also #321

thanks @ssorallen

Works like a charm! Thank you so much @ssorallen and thank you too @AllenFang

Any update on the move to BS4? I'm still facing issues with the pagination component that is causing an overflow and thus a horizontal scrollbar. I could fix the pagination dropdown with a fix mentioned here on the forums.

Support from<EMAIL_ADDRESS>https://react-bootstrap-table.github.io/react-bootstrap-table2/docs/bootstrap4.html


"(23) Failed writing body" when running the gather script

Hi, for some reason I get "(23) Failed writing body" when running the gather script.
$ ./gather <IP_ADDRESS>
Writing to: Twinkly Gold_2.8.3.txt
GET /xled/v1/gestalt
jq - commandline JSON processor [version 1.5-1-a5b5cbe]
Usage: jq [options] <jq filter> [file...]

        jq is a tool for processing JSON inputs, applying the
        given filter to its JSON text inputs and producing the
        filter's results as JSON on standard output.
        The simplest filter is ., which is the identity filter,
        copying jq's input to its output unmodified (except for
        formatting).
        For more advanced filters see the jq(1) manpage ("man jq")
        and/or https://stedolan.github.io/jq
        Some of the options include:
        -c             compact instead of pretty-printed output;
        -n             use `null` as the single input value;
        -e             set the exit status code based on the output;
        -s             read (slurp) all inputs into an array; apply filter to i
        -r             output raw strings, not JSON texts;
        -R             read raw strings, not JSON texts;
        -C             colorize JSON;
        -M             monochrome (don't colorize JSON);
        -S             sort keys of objects on output;
        --tab  use tabs for indentation;
        --arg a v      set variable $a to value <v>;
        --argjson a v  set variable $a to JSON value <v>;
        --slurpfile a f        set variable $a to an array of JSON texts read from <f>;
        See the manpage for more options.
(23) Failed writing body
$

gather wraps all to write output to a file. Try to run ./all <IP address> if you see the same result. And since it runs a lot of commands, next step would be to run it as bash -x all <IP address>.

Thanks for your answer. The "all" script works fine.

@gobo-ws if you are interested in looking into gather you could run it with bash -x as well. Please make sure that you pull latest changes though - Recently I have made some changes in that script.

Same error with bash -x using the latest script.
Problem related to jq?
$ bash -x gather <IP_ADDRESS>
+ set -eu
+ set -o pipefail
+ '[' 1 '!=' 1 ']'
+ H=<IP_ADDRESS>
+ [[ ! -v XLED_DEBUG ]]
+ '[' -t 1 ']'
+ XLED_DEBUG_INTERNAL=1
++ ./auth <IP_ADDRESS>
+ T=wI+XHDPfIsc=
++ ./get <IP_ADDRESS> wI+XHDPfIsc= device_name
++ sed s/Twinkly_//
++ jq -r .name
+ DN='Twinkly Gold'
++ ./get <IP_ADDRESS> fw/version
++ jq -r .version
+ V=2.8.3
+ FN='Twinkly Gold_2.8.3.txt'
+ '[' 1 -ne 0 ']'
+ echo 'Writing to: Twinkly Gold_2.8.3.txt'
Writing to: Twinkly Gold_2.8.3.txt
+ export XLED_DEBUG=1
+ XLED_DEBUG=1
+ ./all <IP_ADDRESS>
+ tee 'Twinkly Gold_2.8.3.txt'
GET /xled/v1/gestalt
jq - commandline JSON processor [version 1.5-1-a5b5cbe]
Usage: jq [options] <jq filter> [file...]

        jq is a tool for processing JSON inputs, applying the
        given filter to its JSON text inputs and producing the
        filter's results as JSON on standard output.
        The simplest filter is ., which is the identity filter,
        copying jq's input to its output unmodified (except for
        formatting).
        For more advanced filters see the jq(1) manpage ("man jq")
        and/or https://stedolan.github.io/jq

        Some of the options include:
         -c             compact instead of pretty-printed output;
         -n             use `null` as the single input value;
         -e             set the exit status code based on the output;
         -s             read (slurp) all inputs into an array; apply filter to it;
         -r             output raw strings, not JSON texts;
         -R             read raw strings, not JSON texts;
         -C             colorize JSON;
         -M             monochrome (don't colorize JSON);
         -S             sort keys of objects on output;
         --tab  use tabs for indentation;
         --arg a v      set variable $a to value <v>;
         --argjson a v  set variable $a to JSON value <v>;
         --slurpfile a f        set variable $a to an array of JSON texts read from <f>;
        See the manpage for more options.
(23) Failed writing body

Please try again. I have realized that I haven't pushed latest changes for gather and all until now.

Please try again. I have realized that I haven't pushed latest changes for gather and all until now.

Works fine now, thanks!


User Account Confirmation Problem

Users who are registered are unable to confirm their account. Whenever they click on the link, they are redirected to the login page. I know that you have provided admin the power to confirm others account. But, this is should also work without admins intervention.
Sample link:
 http://localhost:8080/Project/All/beta-v0.1.1/backend/user/confirm/4/C73DxRcjQoJvl6qaZeX1CKAc1sPIGiEv

This links works only if the user is logged in. Can you help me out where I might have committed the mistake.

Yii2-user allows both guests and logged-in users to access confirmation links (https://github.com/dektrium/yii2-user/blob/master/controllers/RegistrationController.php#L58).
It seems that you have some application-wide access control checks somewhere in your application.

I'm using yii2-admin. Is there a work-around?

I never used yii2-admin, but it seems to me that it denies access for guests. You should configure that extension so that it will not deny yii2-user actions.


#include is designed not to be used under condtion

As the title, I tried to put #include filename in  a #if.#end if loop.
It does not error but load all the file under different  comditions.
Maybe this is how it's.designed to work.

Includes and macros are preprocessed and after that the assembled code is executed. You can even review it if you click the "Unwrapped code" checkbox. The condition cannot affect the include, because it is evaluated after it.
So, it works as expected and it is not an error. You just insert some code from external file inside your condition.
After that this code will execute or not, depending on how the condition.

Includes and macros are preprocessed and after that the assembled code is executed. You can even review it if you click the "Unwrapped code" checkbox. The condition cannot affect the include, because it is evaluated after the inclusion is performed.
So, it works as expected and it is not an error. What you do is to simply insert some code from external file inside your condition. After that, this code will execute or not, depending on the condition result.

Ok, it's preprocessed before excution. I will try more to take advantage of it.


node-agent got "panic: runtime error: invalid memory address or nil pointer dereference"

node-agent is crashing, check attached stack error.
coroot node-agent version: 1.22.2
OS: Debian (5.4.210-amd64)
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x1bbfd5c]

goroutine 242 [running]:
github.com/coroot/coroot-node-agent/containers.(*Process).Close(0xc001d06380)
	/tmp/src/containers/process.go:105 +0x3c
github.com/coroot/coroot-node-agent/containers.(*Container).onProcessExit(0xc000a68780, 0x20df650?, 0x0)
	/tmp/src/containers/container.go:434 +0x96
github.com/coroot/coroot-node-agent/containers.(*Registry).handleEvents(0xc000b11ef0, 0xc0008eb680)
	/tmp/src/containers/registry.go:234 +0x3fc
created by github.com/coroot/coroot-node-agent/containers.NewRegistry in goroutine 1
	/tmp/src/containers/registry.go:124 +0x685

@nashtsai
I don't see how this line could cause the panic, as p is always non-nil here. Are you using our build of node-agent? It looks like a custom build that is panicking elsewhere.


Add seqspec task to ATAC and RNA

Missing task to extract the whitelist and the xstring from seqspec

#5 solves adding seqspec task to RNA. ATAC needs to done


Move rlimits to process

As discussed at the 9/3/16 weekly call and on IRC, this moves the rlimits struct on to process to match capabilities, apparmor, selinux etc which were moved in 5a8a779.
Also fixed a typo (systemd -> systems)

LGTM

LGTM

We can update the formatting post merge

Through 9d9ed06d looks good to me, with a minor backtick nit 1.
I think summarizing the discussion for the PR or commit message would
be useful for folks who wonder about this later on, and am happy to
take a stab at writing that summary if folks want.


GDScript enums override constants.

I'm using Windows version of 2.1.
The problem I ran into is that enums using the same names as constants will replace their value.
Such as:
const NUMBER = 100

enum INT { NUMBER = 2 }

func _ready():
	print(NUMBER) # Shows 2

I haven't tested but it's likely the same in master too, so should be fixed for both. cc @bojidar-bg

AFAIK, this is expected. It's similar to C++ enums. It should error because NUMBER is already declared though.

Yeah, I tagged "bug" because it's a bug that it allows this shadowing instead of erroring out.

Related to  #6221.

Per https://github.com/godotengine/godot/issues/6221#issuecomment-320932451 @reduz intends (intended?) to leave this issue for 3.1.

I think we should add some way to mark enums as "to-be-kept-as-dictionary-only". Some examples to explain it:
enum {INT = 1, STRING}
# equivalent to:
const INT = 1; const STRING = 2

# ---

enum Type {INT = 1, STRING}
# equivalent to:
const INT = 1; const STRING = 2
const Type = {INT = 1, STRING = 2}

# ---

!enum Type {INT = 1, STRING} # some cool proposal here
# equivalent to:
const Type = {INT = 1, STRING = 2}

Now, the question is how to mark those enums, feel free to propose the syntax 😃 .

No, we don't need to add support for half shadowing. Just trigger a syntax error when an enum shadows a constant.

@bojidar-bg I don't get the point, if you need just a dictionary you can simply make one. There's no much gain in avoiding to set the values manually.

@bojidar-bg guess popular demand here just wants an error to be triggered :)

@vnen , @bojidar-bg what to do with this?


unbound: don't run tests when cross compiling

Motivation for this change
Follow-up to #144762 which hopefully fixes cross-compiling unbound.
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

@lovesegfault did this actually fix cross-compiling for you?  I get the same build failure before and after this change (at 28e5327e96bca1f62f9b78963220d5019a74fffe) when cross-compiling from x86_64-linux to aarch64-linux.


draw fixed QR code on Windows

fixes https://github.com/claudiodangelis/qr-filetransfer/issues/32

If you don't break original behaviour, I can add following code to detect user's locale is CJK.
if runewidth.IsEastAsian() {
    // snip
}

Many thanks for this @mattn, I will review it soon.

mattn, how well do the CJK fonts handle the unicode block drawing characters which are suppose to be fixed width? I have been working on a patch to address another issue and as part of it I am using the unicode block characters. Could switching to the unicode block characters resolve the issue without introducing another dependency?
qrConfig = qrterminal.Config{
			HalfBlocks:     true,
			Level:          qrterminal.L,
			Writer:         os.Stdout,
			BlackWhiteChar: "\u001b[37m\u001b[40m\u2584\u001b[0m",
			BlackChar:      "\u001b[30m\u001b[40m\u2588\u001b[0m",
			WhiteBlackChar: "\u001b[30m\u001b[47m\u2585\u001b[0m",
			WhiteChar:      "\u001b[37m\u001b[47m\u2588\u001b[0m",
}


BRS-573 adding FormulaService UTs

Jira Ticket:
BRS-573
Jira Ticket URL:
https://bcparksdigital.atlassian.net/browse/BRS-573
Description:
This is a description.

lost my HEAD hahahahahahahahahahahahaaha


Format datetime fields in API as ISO8601

Motivation

When implementing the API, we replicated the WordPress API as similar as possible, including some weird date formats which are not ideal for processing them in the apps.
Proposed Solution

For every datetime field, add a new field to represent the same date in ISO_8601 format. This affects e.g.:

The start_date, start_time/ end_date, end_time fields of events - combine them into start/end
The sent_date field of push notifications
The modified_gmt field of all other objects (maybe also rename this to last_updated or last_modified)

Alternatives

Additional Context

Could we move this a little bit up please? We still have to live with moment :/

Should be possible, yes :)

Is it correct, that the sent_date and modified_gmt have already been modified beforehand?

Is it correct, that the sent_date and modified_gmt have already been modified beforehand?

The modified_gmt field of pages & imprint is already correct, but e.g. the modified_gmt field of the event and location API reponse and the timestamp field of the  push notification API are in the Y-m-d H:i:s format, but the desired format is YYYY-MM-DDTHH:MM:SS.fff - the representation of datetime.isoformat() (which is also the default string representation of a DateTimeField in Django, so just use the unformatted - but timezone aware - model field in the API response and Django will automatically format it correctly).


Refactor WAS_Image_Batch Class for Flexibility and Dimension Checking

Hi,
I've made some adjustments to the WAS_Image_Batch class, aimed at improving its robustness and flexibility.
I've changed the INPUT_TYPES attribute to view all inputs as "optional". Users can provide any number of images as needed. If no images are provided, an exception is thrown.
I've added a _check_image_dimensions method to verify the dimensions of all images. If there are inconsistencies in the dimensions, it will throw an exception and indicate which images do not match.
I've refactored the image_batch method. Now, it accepts keyword arguments and can flexibly handle an undetermined number of images.
These modifications help the code to better adapt to a variety of user inputs, improve the efficiency of error detection, and enhance the user experience.
Please review these changes when convenient, I look forward to hearing your feedback.

Looks good. Thanks for the PR.