Migrate System.Memory

I included all the change history from corefx/src/System.Memory.
I did not include the change history of the files added to corefx/src/Common.
Please help confirm that the csprojs are conditioned correctly.
Some tests show failures when comparing arrays. The answers seem to be fine but I think the problem is in the usage of Assert.Equal.
Pending: I enabled IsPackable locally but have not yet been able to generate the package and run ApiCompat. I'm investigating what I'm missing.

No issues when building and packing:
.\build.cmd  -pack
  Microsoft.Bcl.HashCode -> C:\Users\calope\source\repos\maintenance-packages\artifacts\bin\Microsoft.Bcl.HashCode\Debug\net6.0\Microsoft.Bcl.HashCode.dll
  System.Buffers -> C:\Users\calope\source\repos\maintenance-packages\artifacts\bin\System.Buffers\Debug\net462\System.Buffers.dll
  System.Buffers -> C:\Users\calope\source\repos\maintenance-packages\artifacts\bin\System.Buffers\Debug\netstandard2.0\System.Buffers.dll
  System.Memory -> C:\Users\calope\source\repos\maintenance-packages\artifacts\bin\System.Memory\Debug\net462\System.Memory.dll
  System.Memory -> C:\Users\calope\source\repos\maintenance-packages\artifacts\bin\System.Memory\Debug\netstandard2.0\System.Memory.dll
  Microsoft.Bcl.HashCode -> C:\Users\calope\source\repos\maintenance-packages\artifacts\bin\Microsoft.Bcl.HashCode\Debug\net462\Microsoft.Bcl.HashCode.dll
  Microsoft.Bcl.HashCode -> C:\Users\calope\source\repos\maintenance-packages\artifacts\bin\Microsoft.Bcl.HashCode\Debug\netstandard2.0\Microsoft.Bcl.HashCode.dll
  Microsoft.Bcl.HashCode -> C:\Users\calope\source\repos\maintenance-packages\artifacts\bin\Microsoft.Bcl.HashCode\Debug\netstandard2.1\Microsoft.Bcl.HashCode.dll
  The package System.Memory.4.6.0-dev.23612.1 is missing a readme. Go to https://aka.ms/nuget/authoring-best-practices/readme to learn why package readmes are important.
  Successfully created package 'C:\Users\calope\source\repos\maintenance-packages\artifacts\packages\Debug\Shipping\System.Memory.4.6.0-dev.23612.1.nupkg'.
  The package Microsoft.Bcl.HashCode.1.2.0-dev.23612.1 is missing a readme. Go to https://aka.ms/nuget/authoring-best-practices/readme to learn why package readmes are important.
  Successfully created package 'C:\Users\calope\source\repos\maintenance-packages\artifacts\packages\Debug\Shipping\Microsoft.Bcl.HashCode.1.2.0-dev.23612.1.nupkg'.

Build succeeded.
    0 Warning(s)
    0 Error(s)

Time Elapsed 00:00:03.36

Look at these beauties, @ericstj @ViktorHofer:

I still see some CI failures that I don't see locally. I'll take a look at them tomorrow.

What benefit do we get by changing netcoreapp2.1 to NetMinimum ? We're not actually building or targeting those out-of-support TFMs, we're just representing the threshold where a library went inbox.

NuGet.org displays a package's dependency groups in the frameworks tab as supported TFMs. In this case, netcoreapp2.1 will be shows as supported. I don't like that as it sends a weird signal to our customers. That said, I can't think of a better option without breaking the netcoreapp2.1 - NetMinimum customers.

An additional suggestion for those targets - we could have an error if any PackageReferences or ProjectReferences were defined for that placeholder case. We don't want folks to accidentally apply references for these frameworks. We could also do the same for Compile items if we wanted folks to be explicit about excluding those, though that might be pedantic since they won't actually be used.

Agreeing with both of these. DefaultItems should be false for the build and targets could validate that there are no manual compile or *reference items declared for that TFM.

NuGet.org displays a package's dependency groups in the frameworks tab as supported TFMs. In this case, netcoreapp2.1 will be shows as supported. I don't like that as it sends a weird signal to our customers. That said, I can't think of a better option without breaking the netcoreapp2.1 - NetMinimum customers.

If we're talking about sending a message with that view - it's even worse to imply some support on newer frameworks.  This package isn't needed at all on those frameworks.  I'd recommend we just add some strong messaging in the package README that this package is necessary only when targeting .NETFramework or .NETStandard - it's not required on newer versions of .NET.

@ericstj @ViktorHofer woohoo! CI passed finally!


Start menu icons do not appear

Windows Terminal version
1.16.10262.0
Windows build number
10.0.22622.0
Other Software
No response
Steps to reproduce

Install Terminal
Install a Linux distribution with WSL (for showcasing multiple icons)
Search for "Terminal" in the Start Menu
See the icons for each profile missing

Expected Behavior
Icons for all the different profiles showing up.
Actual Behavior
No icons show up.

Huh, interesting. Not sure there's anything for us to fix here. Probably a bug in the Start Menu. Mind filing feedback using the Feedback Hub/? If you hit "Share" and share the aka.ms link here, I can make sure to promote it to the right team internally.
The Start menu team should be able to dig into this better than we can 😉 Thanks!

 This issue has been marked as requiring author feedback, but hasn't had any activity in the last week. We're gonna close it to tidy up. Feel free to continue the discssion in the comments - we can always reopen if new information comes to light. Thanks!

Not sure if related but the icon refuses to show up for WSL on my jump menu but is OK within the app!


batch: lookup join accesses invalid epoch

When running e2e parallel on CI:
2022-12-20T06:12:18.527699Z ERROR risingwave_storage::monitor::monitored_store: Failed in get: Hummock error: Expired Epoch: watermark<PHONE_NUMBER>259328, epoch<PHONE_NUMBER>375744.
  backtrace of inner error:
   0: <risingwave_storage::hummock::error::HummockError as core::convert::From<risingwave_storage::hummock::error::HummockErrorInner>>::from
             at ./src/storage/src/hummock/error.rs:65:10
   1: <T as core::convert::Into<U>>::into
             at /rustc/bdb07a8ec8e77aa10fb84fae1d4ff71c21180bb4/library/core/src/convert/mod.rs:726:9
   2: risingwave_storage::hummock::error::HummockError::expired_epoch
             at ./src/storage/src/hummock/error.rs:119:9
   3: risingwave_storage::hummock::utils::validate_epoch
             at ./src/storage/src/hummock/utils.rs:60:20
   4: risingwave_storage::hummock::state_store::<impl risingwave_storage::hummock::HummockStorage>::build_read_version_tuple
             at ./src/storage/src/hummock/state_store.rs:117:9
   5: risingwave_storage::hummock::state_store::<impl risingwave_storage::hummock::HummockStorage>::get::{{closure}}
             at ./src/storage/src/hummock/state_store.rs:67:13
   6: <risingwave_storage::store_impl::verify::VerifyStateStore<A,E> as risingwave_storage::store::StateStoreRead>::get::{{closure}}
             at ./src/storage/src/store_impl.rs:316:79
   7: <S as risingwave_storage::store_impl::boxed_state_store::DynamicDispatchedStateStoreRead>::get::{{closure}}
             at ./src/storage/src/store_impl.rs:707:47
   8: <core::pin::Pin<P> as core::future::future::Future>::poll
             at /rustc/bdb07a8ec8e77aa10fb84fae1d4ff71c21180bb4/library/core/src/future/future.rs:124:9
   9: <async_stack_trace::StackTraced<F,_> as core::future::future::Future>::poll
             at ./src/utils/async_stack_trace/src/lib.rs:149:36
  10: <risingwave_storage::monitor::monitored_store::MonitoredStateStore<S> as risingwave_storage::store::StateStoreRead>::get::{{closure}}
             at ./src/storage/src/monitor/monitored_store.rs:112:17
  11: risingwave_storage::table::batch_table::storage_table::StorageTable<S>::get_row::{{closure}}
             at ./src/storage/src/table/batch_table/storage_table.rs:259:81
  12: <risingwave_batch::executor::join::distributed_lookup_join::InnerSideExecutorBuilder<S> as risingwave_batch::executor::join::local_lookup_join::LookupExecutorBuilder>::add_scan_range::{{closure}}
             at ./src/batch/src/executor/join/distributed_lookup_join.rs:389:17
  13: <core::pin::Pin<P> as core::future::future::Future>::poll
             at /rustc/bdb07a8ec8e77aa10fb84fae1d4ff71c21180bb4/library/core/src/future/future.rs:124:9
  14: risingwave_batch::executor::join::lookup_join_base::LookupJoinBase<K>::do_execute::{{closure}}
             at ./src/batch/src/executor/join/lookup_join_base.rs:102:65

Compute node logs at https://buildkite.com/risingwavelabs/pull-request/builds/14221#01852e1b-256d-4d2a-ba95-45a72ff71360.

Another occurrence: https://buildkite.com/risingwavelabs/main/builds/2564#01852f37-a26b-4215-a3c8-8ce5ded9129f

cc @chenzl25 Would you please help to take a look? 🥰

cc @chenzl25 Would you please help to take a look? 🥰

Sure.

I think I know why epoch expired, because for distributed queries, once we have scheduled the query, we will unpin epoch immediately. However it is impossible for a distributed lookup join to create all its iterators at the beginning, because it needs to wait for the outer side to send data to the inner side so that it can lookup the table at runtime.
Stage(Scheduled(stage_id)) => {
    tracing::trace!(
        "Query stage {:?}-{:?} scheduled.",
        self.query.query_id,
        stage_id
    );
    self.scheduled_stages_count += 1;
    stages_with_table_scan.remove(&stage_id);
    if stages_with_table_scan.is_empty() {
        // We can be sure here that all the Hummock iterators have been created,
        // thus they all successfully pinned a HummockVersion.
        // So we can now unpin their epoch.
        tracing::trace!("Query {:?} has scheduled all of its stages that have table scan (iterator creation).", self.query.query_id);
        pinned_snapshot_to_drop.take();
    }


Confusion over skip-compilation option

As described in REFERENCE.md, this framework will (compile and) run all the code in the test directory on the developer's desktop/laptop against the mock Arduino board. Then, as a separate task an attempt is made to build everything in the examples directory using the Arduino IDE (which has different includes and a different compiler) so as to avoid later surprises due to the different build environment and target. These tasks are very reasonable and distinct, but I was confused by the names.
I spent a lot of time fiddling with test code to get the unit tests to compile and run and the idea that I'm running the unit tests without compiling seems very odd. Now that I'm understanding better I wonder if "compilation of examples" would be a better phrase (even though it is more verbose).
So, the command line option --skip-compilation would probably remain but would be deprecated in favor of --skip-compilation-of-examples or simply --skip-examples (more analogous to --skip-unittests).

I'll probably do --skip-examples-compilation, this is a great suggestion


REQUEST: New Committer rights request for yboaron

GitHub Username
@yboaron
Code you are requesting Committer rights for
submariner/*
Requirements

[x] I have reviewed the contributor roles guidelines (https://submariner.io/community/contributor-roles/)
[x] I have enabled 2FA on my GitHub account (https://github.com/settings/security)
[x] I have subscribed to the submariner-dev e-mail list (https://groups.google.com/forum/#!forum/submariner-dev)
[x] I have been actively contributing to Submariner for at least 3 months
[x] I have two sponsors that meet the sponsor requirements listed in the community membership guidelines
[x] I have spoken to my sponsors ahead of this application, and they have agreed to sponsor my application

Sponsors

@tpantelis
@vthapar

List of required reviews to Submariner project PRs

At least 20 PRs to the relevant codebase that you reviewed, and at least 5 for which you were the primary reviewer:
https://github.com/submariner-io/submariner/pulls?q=is%3Apr+reviewed-by%3Ayboaron+-author%3Ayboaron

+1

+1

+1

https://github.com/submariner-io/submariner/pull/3054


[Ionic v4] Multiple ion-router-outlets not working

Bug Report
Ionic Info
Ionic:
   ionic (Ionic CLI)          : 4.1.1 (C:\Users\knuterik\AppData\Roaming\npm\node_modules\ionic)
   Ionic Framework            : @ionic/angular 4.0.0-beta.5
   @angular-devkit/core       : 0.7.3
   @angular-devkit/schematics : 0.7.3
   @angular/cli               : 6.1.3
   @ionic/ng-toolkit          : 1.0.6
   @ionic/schematics-angular  : 1.0.5

System:

   NodeJS : v9.3.0 (C:\Program Files\nodejs\node.exe)
   npm    : 6.4.0
   OS     : Windows 10

Describe the Bug
Navigation is stuck after navigating between two components with child routes and ion-router-outlets. This works in angular with router-outlet but not after IonicModule is imported.
Steps to Reproduce
Steps to reproduce the behavior:

Go to https://stackblitz.com/github/knutto/bug-ion-router-outlet
Click through Tab 1 - 3 and see the content change.
Click "Second Tabs Page"
Click through Tab 4 - 6 and see the content change.
Click "First Tabs Page" (navigating you back)
The content is now stuck to the last tab you clicked.

Related Code
https://stackblitz.com/github/knutto/bug-ion-router-outlet
https://github.com/knutto/bug-ion-router-outlet
Expected Behavior
Navigation should still work after navigating from /first to /second
The docs states that ion-router-outlet should behave as angular's router-outlet but it does not support having multiple/nested ion-router-outlet
Update
This was supposedly fixed in f84bb76 (beta.3) and closed #14888
After this update only the first tabs/ion-router-outlet page is stuck - the second is functioning as intended.

Your Ionic Info says "@ionic/angular 4.0.0-beta.0" have you tried with the updated beta?

Yes, forgot to update it.
Ive tested it with beta.5
The test repo uses beta.3
ons. 29. aug. 2018 kl. 16:16 skrev Abdelaziz Bennouna <
<EMAIL_ADDRESS>
Your Ionic Info says "@ionic/angular 4.0.0-beta.0" have you tried with the
updated beta?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/ionic-team/ionic/issues/15370#issuecomment-416969261,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACLZcFsrRaLSRUUkwqeisXPLnz_mPooCks5uVqJbgaJpZM4WRkqZ
.

--
Vennlig hilsen, Knut Erik Langdahl +47 934 95 417 (Sendt fra en mobil enhet)

I've updated the repo to beta.5 and provided an updated stackblitz.
https://stackblitz.com/github/knutto/bug-ion-router-outlet

Same issue here, another thing while we are on a route in child router outlet and use this.routerOutlet.pop(); to go back and then want to visit same child component 2nd time this doesn't work.

These issues seem to be the same:

https://github.com/ionic-team/ionic/issues/15449
https://github.com/ionic-team/ionic/issues/15295

There are also some open issues about a nav back button bug, may also be the same.

Closing as duplicate of https://github.com/ionic-team/ionic/issues/14566
Please track that issue instead of opening new issues.

@mhartington I don't think it's a duplicate. Like I said in my comment above the problem is not with Tabs per se, and after a little more digging I find it's still a problem when I don't lazy load anything.

@jurgen-reconcept @mhartington  Might it be due to relative routing as reported here: https://github.com/ionic-team/ionic/issues/15449

Seems like a few things, but mostly coming down to needing to specify a name for the multiple router-outlets. other wise, there's no logic in place to say what outlet should be active.
https://github.com/mhartington/bug-ion-router-outlet
This has the fixed setup. Let me know if that solves your issues @jurgen-reconcept

@doender i can confirm that uses absolute paths fixes it for me, but it's definitely less than ideal.
@mhartington your repo seems empty

😄 Silly me, forgot to push. Refresh

@mhartington My demo repo doesn't use multiple outlets but still has a similar issue (not being able to navigate back after to an already visited page): https://github.com/doender/routingError

@doender your's is related to the relativeTo config in the navigate method. Removing that works fine.

@mhartington Excuse me for hijacking this thread, but do you mean Ionic currently doesn't support relative routing?

It does, but they way your were routing here was not correct.

Could you please explain why the routing works the first time (before going back)?

@doender let's move your questions/conversation over the ionic forum as this is getting off topic.

@mhartington I've tried a lot of things, but for the life of me I can't get it to work with relative paths. In your example all paths are absolute. For me it's not about multiple outlets but just about plain old relative navigation. I made a simple example:

the green buttons keep working, but they're absolute hrefs
a relative href never seems to work
using routerLink instead of href seems to work only once for each page (this is the big WHY!?)

https://github.com/jurgen-reconcept/bug-ion-router-outlet

Seems like a few things, but mostly coming down to needing to specify a name for the multiple router-outlets. other wise, there's no logic in place to say what outlet should be active.
https://github.com/mhartington/bug-ion-router-outlet
This has the fixed setup. Let me know if that solves your issues @jurgen-reconcept

This works, but does not solve the issue. As stated in the first post, this code works in plain angular, but once you load in the IonicModule, it breaks the router for router outlets without names (ion-router-outlet and router-outlet).
My main concern is that some end users will see the url with (outlet:something) and think its an error - which is why I want to avoid having named outlets. This is only a problem for Web.

@manucorporat @mhartington thanks for adding to the backlog. Since the title of this issue describes a different problem than what we discussed, maybe it should be renamed?

@mhartington please also take a look at https://github.com/ionic-team/ionic/issues/15428 . It seems that the  ion-router-outlet have some bug that's causing various issues related to routing.

@mhartington @manucorporat at ng-conf Deborah Kurata explained a solution how to fix this problem without named outlets and ugly url paths. Here is the YouTube video and Github repo:
https://www.youtube.com/watch?v=LaIAHOSKHCQ
https://github.com/DeborahK/MovieHunter-routing
In the comments of this YouTube video she pointed out, that named outlets are a bad pattern at the moment, espacially in combination with lazy loading. It would be great, if the Ionic team implements this solution which is nothing more than just accept multiple ion-router-outlets on multiple views without named outlets. I hope this will help, because clean navigation stack (without ugly paths) is elementary for every app and even more for end users.
Kind regards,
Thomas

Didn't create a ticket because I figure this was related to this.
I have updated to the latest in my package.json.
Issue I am having is:

The main tab page can be lazy loaded. The pages that go in the tabs, don't work being lazy loaded.
example:

const routes: Routes = [
  {
    path: 'groups',
    component: GroupTabPage,
    children: [
      {
        path: 'home',
        outlet: 'group',
        component: GroupHomePage
        // loadChildren: '../group-home/group-home.module#GroupHomePageModule'
      },
      {
        path: 'info',
        outlet: 'group',
        component: GroupInfoPage
        // loadChildren: '../group-info/group-info.module#GroupInfoPageModule'
      },
      {
        path: 'members',
        outlet: 'group',
        component: GroupMembersPage
        // loadChildren: '../group-members/group-members.module#GroupMembersPageModule'
      },
      {
        path: '',
        redirectTo: '/groups/(group:home)',
        pathMatch: 'full'
      }
    ]
  }
];

Attempting to lazy load will not render the view correctly. Everything is rendering right above the tabs on bottom of the screen. Ion content doesn't show. Ion header will show.
Work around is to do it like this:
<ion-header>
  <ion-toolbar>
    <ion-buttons slot="start">
      <ion-menu-button></ion-menu-button>
    </ion-buttons>
    <ion-title>
      Group
    </ion-title>
  </ion-toolbar>
</ion-header>

<ion-content padding>
  <ion-router-outlet name="group"></ion-router-outlet>
</ion-content>

<ion-tabs tabbarPlacement="bottom" color="primary" tabbarHighlight="true">
    <ion-tab label="Group Home" icon="home" href="/groups/(group:home)">

    </ion-tab>
    <ion-tab label="Info" icon="list" href="/groups/(group:info)">

    </ion-tab>
    <ion-tab label="Members" icon="people" href="/groups/(group:members)">

    </ion-tab>
  </ion-tabs>

So this is the only way I could get this show up correctly and work with the side menu.
Also tabbarLayout top isn't working. It won't appear anywhere.

This issue is really confusing. In fact I believe I'm using multiple router outles with no problems (lazyloading and nesting a lot of routing levels), the point is just that the relativeTo property doesn't work

Do you have multiple ion-router-outlets nested without the name property set?

I should. I have something like:
app.component:
then in a sub module loaded with lazyloading (bookslist) I have another:

I've updated the repo, here's a picture of the relevant code and the relations between them:
https://imgur.com/a/rtDpRoA
After navigating from the first-tabs-page to the second-tabs-page and then back to the  first-tabs-page again. The first-tabs-page stops working - you can no longer navigate between tab1, tab2, tab3. Navigating forward to  second-tabs-page and its tabs (tab4,tab5,tab6) works as expected.
My developer console also shows:

router-outlet destroyed

when navigating from second-tabs-page to first-tabs-page

#15798

i found a temporal hacky workaround till they fix it, since named outlets breaks lazy load, and the no-named outlets breaks with components with childs, doing a 'copy' of the directive , will make that the views can difference between 1 outlet and the other one,
i got a full lazy loaded app with 3 levels of tabs finally working without any problem.

The tabs component just use ion-toolbar and ion-buttons, to make the tabs (now im going to try,if it works with the standard ion-tabs component )

navigator.html =>

<ion-content padding>
  <bn8-router-outlet></bn8-router-outlet>
</ion-content>
<ion-footer>
  <tabs [tabs]=mainTabs></tabs>
</ion-footer>

navigator-routing.module.ts =>

const routes: Routes = [{
  path:'',
  component: NavigatorPage,
  children: [
    { path: '', redirectTo: 'eventos-handler', pathMatch: 'full' },
    { path: 'eventos-handler', loadChildren: './event-handler/event-handler.module#EventHandlerPageModule' },
    { path: 'entradas', loadChildren: './entradas/entradas.module#EntradasPageModule' },
    { path: 'chat', loadChildren: './chat/chat.module#ChatPageModule' },
    { path: 'notificaciones', loadChildren: './notificaciones/notificaciones.module#NotificacionesPageModule'  },
    { path: 'perfil', loadChildren: './perfil-handler/perfil-handler.module#PerfilHandlerPageModule' },
    { path: '**', redirectTo: '', pathMatch: 'full' }
  ]
},
{ path: '**', redirectTo: '', pathMatch: 'full' },
]

event-handle.html (child of navigator) =>

<tabs [tabs]=eventosTabs></tabs>
<ion-content>
 <ion-router-outlet></ion-router-outlet>
</ion-content>

event-handler-routing.module.ts =>

const routes: Routes = [
  {
    path: '',
    component: EventHandlerPage,
    children: [
      {
        path: '',
        children: [
          { path: '', redirectTo: 'eventos', pathMatch: 'full'  },
          { path: 'eventos', loadChildren: './eventos/eventos.page.module#EventosPageModule' },
          { path: 'planes', loadChildren: './planes/planes.page.module#PlanesPageModule' },
          { path: 'clubs', loadChildren: './clubs/clubs.page.module#ClubsPageModule' },
          { path: 'mapa', loadChildren: './mapa/mapa.page.module#MapaPageModule' },
          { path: '**', redirectTo: 'eventos', pathMatch: 'full' }

        ]
      }
    ]
  },
  { path: '**', redirectTo: '', pathMatch: 'full' }
]

try to use  in the 1st level instead the copied directive, and  in the nested ones

@idanzapp actually I refactored my application in order to not use multiple nested ion-router-outlet and... the same problem occurs... now I don't even have anymore "router-outlet destroyed" logged in the console... this is weird as f***.
I'm going to create a well documented issue with an example video on this repo that groups all the outlet related issues too like this.

@idanzapp actually I refactored my application in order to not use multiple nested ion-router-outlet and... the same problem occurs... now I don't even have anymore "router-outlet destroyed" logged in the console... this is weird as f***.
I'm going to create a well documented issue with an example video on this repo that groups all the outlet related issues too like this.

Do named router outlets as of angular 7 support lazy loading ? Or is this something that needs to be fixed by ionic ?

Will be fixed by https://github.com/ionic-team/ionic/pull/16637

@manucorporat sorry to bother, but part of this issue is involved in this other issue #15959
Means that that other one is solved too?


Cannot find code addresses starting from version 0.14.1

First of all, thanks for this amazing tool that helps getting better code :wink:
I've been running following command line in our CI:
cargo tarpaulin --force-clean -v -f -t 7200 --out Xml --ignore-tests --exclude-files resources/*
Getting this error:
...
 Error: Failed to run tests: ERROR: Tarpaulin cannot find code addresses
check that pie is disabled for your linker. If linking with gcc try adding -C link-args=-no-pie to your rust flags
Error: "Failed to get test coverage! Error: Failed to run tests: ERROR: Tarpaulin cannot find code addresses
check that pie is disabled for your linker. If linking with gcc try adding -C link-args=-no-pie to your rust flags"

After investigating, running with version 0.14.0 is fine, but running >=0.14.1 is not.
I am not so worried about Instrumentation address clash, though it doesn't appear in 0.14.0.
This is a closed source project so I can't share the code, and it's pretty big, not sure i'll be able to minimize it.
Anyway feel free to ask me if you need more info or if I can run some tests

Upgrading to version 0.15.0 solved this issue.
Thanks a lot :wink:


[SR-1355] Add Performance Measurement APIs

What's in this pull request
This is an initial implementation of the XCTest performance measurement APIs. All public facing APIs from Apple XCTest are present, but not all behaviors are implemented at this point. It is currently possible to measure the wall clock time that a given block of code takes to execute, and see the measured times, the mean value, and the relative standard deviation in the printed test output.
The core behaviors mimic those described in the Apple XCTest framework headers, supplemented by information presented in the Testing in Xcode 6 WWDC session.

The code being measured is always executed exactly 10 times (assuming no test failures occur)
A test failure is triggered if the relative standard deviation of the times measured is greater than 10%, and the standard deviation value is greater than 0.1

This does not include any support for recording baseline values or triggering test failures due to a regression relative to a baseline.
Resolves SR-1355.
Code structure
Although the build system does not currently facilitate the use of multiple Swift modules, I have structured the code with modularity in mind. The PerformanceMeter.swift and WallClockTimeMetric.swift contain the heart of the implementation and have (almost) no dependence on other parts of the XCTest library. XCTestCase+Performance.swift contains the public APIs which delegate to the PerformanceMeter class.
Test coverage
There are extensive functional tests covering of API misuse scenarios and basic measurement output, however many finer points (e.g. standard deviation calculation and situations triggering failure) have only cursory tests due to the lack of a usable unit testing infrastructure (see this PR for previous discussion about this.)
I attempted to make the tests robust, however due to the time-sensitive nature of the APIs under test, there is an increased possibility of flakiness that could appear when running in a CI environment. I would greatly appreciate feedback on this aspect of the test cases and what approaches we could take to minimize the risk of false negative results. I would also like to hear feedback on the test_measuresWallClockTimeInBlock test case in Performance/main.swift, which currently includes a 1-second sleep in order to
test that time passing is being measured.
Error reporting
I took pains to implement failure reporting due to API misuse, just as Apple XCTest does. One element of this is reporting the file and line number where the misuse occurred. I have taken cues from @modocache's XCTestExpectation implementation and added file and line params where necessary to capture that information. The current implementation records test failures for API misuse, allowing test suite execution to continue at the cost of some additional bookkeeping code. An alternative would be to simply fatalError in these scenarios, since they are clearly programmer error. I would appreciate others' input on these options.
Time measurement
I am no expert in benchmarking, so I am not especially confident in the optimal mechanism for measuring the passage of time for this purpose, however after some cursory research, I settled on using NSProcessInfo's systemUptime property, which ultimately calls down to mach_absolute_time on Darwin, and clock_gettime with CLOCK_MONOTONIC on Linux. As far as I can tell, these are the appropriate primitives to use for this purpose in these environments. One potential source of error is introduced in that the time values are being converted to Double, but I'm unsure of the practical impact of that.
--
While not complete, this is still a significant step towards feature parity with Apple XCTest, and should be sufficient to start gathering feedback on future implementation directions. In particular, it should put us in a good position to productively carry on discussions like this one from @drewcrawford which have great potential to improve the value that these tools provide.
cc @ddunbar @paulofaria

@swift-ci please test

Amazing!! Thanks for this. Swift 3.0, here we come!!

Although the build system does not currently facilitate the use of multiple Swift modules, I have structured the code with modularity in mind.

Is this something you think we should address? Are there consequences for end-users if we split it up, such as requiring them to link multiple modules, besides XCTest?

XCTestCase+Performance.swift contains the public APIs which delegate to the PerformanceMeter class.

This has been in the back of my mind for a while now: Apple places its asynchronous testing APIs in a category on XCTestCase, placed in a file called XCTestCase+AsynchronousTesting.h. Do you think we should split the asynchronous testing portion of SwiftXCTest.XCTestCase into an extension in its own file? Following your naming convention, perhaps XCTestCase+Asynchronous.swift? Or is this not worth the effort? One tricky part is that XCTestCase uses an internal variable to hold onto the expectations it's vended, whereas we can't place additional variables on extensions...
More granular comments to follow.

This looks fantastic! I only had minor nit-picks, which I feel could adequately be addressed after merging. Considering:

The API matches Apple XCTest
We can make improvements over time (the implementation doesn't have to be perfect right now)
CI is passing

I'd encourage you to hit the big green merge button. 😄
I don't know much about time measurement, but as for the other things you mention in your pull request:

Code structure: 💯
Test coverage: I agree that unit tests would be nice, but I think we can wait for #61 to add those. A one second sleep doesn't seem like a big deal to me at this point in this codebase's life, but it'd be nice to make it shorter if possible.
Error reporting: If Apple XCTest reports failures and keeps executing, I'd prefer to do that. fatalError seems harsh -- but again, I think we should always do whatever Apple XCTest does. Asynchronous tests report failures for this reason.

The time measurement parts sound reasonable to me for an initial implementation:

Imprecision w.r.t. conversion to Double is a non-issue for this level of API.
Using mach_absolute_time is the right answer on OS X, via a wrapper in Foundation seems reasonable to me.

Thanks for the positive feedback guys! 😎 I'm going to go ahead and merge this. Exciting that it appears to be making it in before the creation of the swift-3.0-preview-1-branch.

Oh, regarding modules - I do believe it should be possible to split the library internals into multiple modules without require consumers to modify their imports (which would make this a non-starter), but I'm not certain yet. @ddunbar or @mxcl could likely confirm the feasibility of this given their experience with SwiftPM?


[ADAM-2099] Add python realignIndelsFromKnownIndels method

Fixes #2099

Coverage increased (+0.1%) to 79.233% when pulling a4c9ca6e978a0bd72876049a633d9c81d6e24d88 on heuermh:realign-indels-python into e696b64c358222a4ef50c1b87f51c4f1f08c68ff on bigdatagenomics:master.


[#40, #54] Configuration file with computed fields and include/exclude file options

Closes #40
Closes #54

Integrate a configuration file options.
Implement computed fields.
Provide the ability to configure include and exclude file patterns similar to the approach used in Next.js/TypeScript.

@mohamedsalem401 does this reflect the comments in the PR yesterday re the definition in the README PR of this feature?

@mohamedsalem401 another general comment - i'd have kept the include/exclude feature for a separate PR. It makes the review easier and faster ...

I will close this for now


bundle-gen and build version updates

Backport of #2001 and #2029

Rewrite bundle-gen and version discovery scripts
Use app-sre image by default
Validate existence of image

See individual commits for details
HIVE-2202

/assign @lleshchi
/cc @gurnben

/test e2e-pool
This flake should be addressed by #2033.

/lgtm


fix(migration): The migration script will now migrate entries too

What does it do?
The migration script can now take care of migrating entries too, obsoleting some of the migration done during bootstrap.
Why is it needed?
The migrations could not really run in production and would require two consecutive deployments, one where the old plugin option was still set, and a new one where the new one was set.
This PR works with just the migration script
Related issue(s)/PR(s)
resolves #102

I also have a small change that I want to add to the script regarding to the inserts. If there is no entries to insert it will throw an error.


[RFC] Flag sprawl is real

Docker commands have lots of flags (specifically docker run), most of which will not ever be used by a majority of Docker users.
Here is docker run --help now:
      --add-host list                         Add a custom host-to-IP mapping (host:ip) (default [])
  -a, --attach list                           Attach to STDIN, STDOUT or STDERR (default [])
      --blkio-weight uint16                   Block IO (relative weight), between 10 and 1000, or 0 to disable (default 0)
      --blkio-weight-device weighted-device   Block IO weight (relative device weight) (default [])
      --cap-add list                          Add Linux capabilities (default [])
      --cap-drop list                         Drop Linux capabilities (default [])
      --cgroup-parent string                  Optional parent cgroup for the container
      --cidfile string                        Write the container ID to the file
      --cpu-count int                         CPU count (Windows only)
      --cpu-percent int                       CPU percent (Windows only)
      --cpu-period int                        Limit CPU CFS (Completely Fair Scheduler) period
      --cpu-quota int                         Limit CPU CFS (Completely Fair Scheduler) quota
      --cpu-rt-period int                     Limit CPU real-time period in microseconds
      --cpu-rt-runtime int                    Limit CPU real-time runtime in microseconds
  -c, --cpu-shares int                        CPU shares (relative weight)
      --cpus decimal                          Number of CPUs (default 0.000)
      --cpuset-cpus string                    CPUs in which to allow execution (0-3, 0,1)
      --cpuset-mems string                    MEMs in which to allow execution (0-3, 0,1)
      --credentialspec string                 Credential spec for managed service account (Windows only)
  -d, --detach                                Run container in background and print container ID
      --detach-keys string                    Override the key sequence for detaching a container
      --device list                           Add a host device to the container (default [])
      --device-read-bps throttled-device      Limit read rate (bytes per second) from a device (default [])
      --device-read-iops throttled-device     Limit read rate (IO per second) from a device (default [])
      --device-write-bps throttled-device     Limit write rate (bytes per second) to a device (default [])
      --device-write-iops throttled-device    Limit write rate (IO per second) to a device (default [])
      --disable-content-trust                 Skip image verification (default true)
      --dns list                              Set custom DNS servers (default [])
      --dns-option list                       Set DNS options (default [])
      --dns-search list                       Set custom DNS search domains (default [])
      --entrypoint string                     Overwrite the default ENTRYPOINT of the image
  -e, --env list                              Set environment variables (default [])
      --env-file list                         Read in a file of environment variables (default [])
      --expose list                           Expose a port or a range of ports (default [])
      --group-add list                        Add additional groups to join (default [])
      --health-cmd string                     Command to run to check health
      --health-interval duration              Time between running the check (ns|us|ms|s|m|h) (default 0s)
      --health-retries int                    Consecutive failures needed to report unhealthy
      --health-timeout duration               Maximum time to allow one check to run (ns|us|ms|s|m|h) (default 0s)
      --help                                  Print usage
  -h, --hostname string                       Container host name
      --init                                  Run an init inside the container that forwards signals and reaps processes
      --init-path string                      Path to the docker-init binary
  -i, --interactive                           Keep STDIN open even if not attached
      --io-maxbandwidth string                Maximum IO bandwidth limit for the system drive (Windows only)
      --io-maxiops uint                       Maximum IOps limit for the system drive (Windows only)
      --ip string                             Container IPv4 address (e.g. <IP_ADDRESS>)
      --ip6 string                            Container IPv6 address (e.g. 2001:db8::33)
      --ipc string                            IPC namespace to use
      --isolation string                      Container isolation technology
      --kernel-memory string                  Kernel memory limit
  -l, --label list                            Set meta data on a container (default [])
      --label-file list                       Read in a line delimited file of labels (default [])
      --link list                             Add link to another container (default [])
      --link-local-ip list                    Container IPv4/IPv6 link-local addresses (default [])
      --log-driver string                     Logging driver for the container
      --log-opt list                          Log driver options (default [])
      --mac-address string                    Container MAC address (e.g. 92:d0:c6:0a:29:33)
  -m, --memory string                         Memory limit
      --memory-reservation string             Memory soft limit
      --memory-swap string                    Swap limit equal to memory plus swap: '-1' to enable unlimited swap
      --memory-swappiness int                 Tune container memory swappiness (0 to 100) (default -1)
      --name string                           Assign a name to the container
      --network string                        Connect a container to a network (default "default")
      --network-alias list                    Add network-scoped alias for the container (default [])
      --no-healthcheck                        Disable any container-specified HEALTHCHECK
      --oom-kill-disable                      Disable OOM Killer
      --oom-score-adj int                     Tune host's OOM preferences (-1000 to 1000)
      --pid string                            PID namespace to use
      --pids-limit int                        Tune container pids limit (set -1 for unlimited)
      --privileged                            Give extended privileges to this container
  -p, --publish list                          Publish a container's port(s) to the host (default [])
  -P, --publish-all                           Publish all exposed ports to random ports
      --read-only                             Mount the container's root filesystem as read only
      --restart string                        Restart policy to apply when a container exits (default "no")
      --rm                                    Automatically remove the container when it exits
      --runtime string                        Runtime to use for this container
      --security-opt list                     Security Options (default [])
      --shm-size string                       Size of /dev/shm, default value is 64MB
      --sig-proxy                             Proxy received signals to the process (default true)
      --stop-signal string                    Signal to stop a container, SIGTERM by default (default "SIGTERM")
      --stop-timeout int                      Timeout (in seconds) to stop a container
      --storage-opt list                      Storage driver options for the container (default [])
      --sysctl map                            Sysctl options (default map[])
      --tmpfs list                            Mount a tmpfs directory (default [])
  -t, --tty                                   Allocate a pseudo-TTY
      --ulimit ulimit                         Ulimit options (default [])
  -u, --user string                           Username or UID (format: <name|uid>[:<group|gid>])
      --userns string                         User namespace to use
      --uts string                            UTS namespace to use
  -v, --volume list                           Bind mount a volume (default [])
      --volume-driver string                  Optional volume driver for the container
      --volumes-from list                     Mount volumes from the specified container(s) (default [])
  -w, --workdir string                        Working directory inside the container

Probably most users need no more than this:
      --cpus decimal                          Number of CPUs (default 0.000)
  -d, --detach                                Run container in background and print container ID
      --device list                           Add a host device to the container (default [])
      --dns list                              Set custom DNS servers (default [])
  -e, --env list                              Set environment variables (default [])
      --help                                  Print usage
  -h, --hostname string                       Container host name
      --init                                  Run an init inside the container that forwards signals and reaps processes
  -i, --interactive                           Keep STDIN open even if not attached
  -l, --label list                            Set meta data on a container (default [])
      --link list                             Add link to another container (default [])
  -m, --memory string                         Memory limit
      --name string                           Assign a name to the container
      --network string                        Connect a container to a network (default "default")
      --network-alias list                    Add network-scoped alias for the container (default [])
      --no-healthcheck                        Disable any container-specified HEALTHCHECK
      --pids-limit int                        Tune container pids limit (set -1 for unlimited)
      --privileged                            Give extended privileges to this container
  -p, --publish list                          Publish a container's port(s) to the host (default [])
       --read-only                             Mount the container's root filesystem as read only
      --restart string                        Restart policy to apply when a container exits (default "no")
      --rm                                    Automatically remove the container when it exits
      --tmpfs list                            Mount a tmpfs directory (default [])
  -t, --tty                                   Allocate a pseudo-TTY
  -u, --user string                           Username or UID (format: <name|uid>[:<group|gid>])
   -v, --volume list                           Bind mount a volume (default [])
   -w, --workdir string                        Working directory inside the container

Even with the short list, the help output probably isn't all that helpful.
With the plethora of things there are to tweak on docker run it may be helpful to simply hide advanced flags by default (e.g. all the cgroup related stuff other than cpus and memory).
Alternatively flags could be broken down into sections.
WIth --help we could show the common flags and a set of sections.
So something like:
$ docker --help
Most commonly used flags:

    <short flag list>

Help Sections:

    Resource Management:   See `docker --help=resources`
    Networking:            See `docker --help=network`
    Health monitoring:     See `docker --help=health`
    Process configuration: See `docker --help=process
    Storage:               See `docker --help=storage`

Full command line reference:

    https://docs.docker.com/engine/reference/run/

Or see the manpages:

    $ man docker-run

I like the idea. However, one concern comes to mind. When I'm looking at --help output, I'll typically grep for something or scan visually for a particular flag. I usually don't read text outside of the options list because it tends to be boilerplate about licensing, where to find docs, etc. So there's a risk of burying the "help sections" information and making it look like certain flags don't exist or aren't documented.
I think I'd prefer to sort the flags into logical sections and show all sections by default with --help. Then grep still works as expected, and so on. However, even this can be confusing. We do something similar with docker help, showing management commands separately from "commands". When docker image was added I was quite confused because I didn't see it next to images in the commands list. Eventually I realized that there was a separate list for certain commands, but it wasn't obvious at the time.

Yes, my preference would be to logically group them as well. Agreed that there's a big list of options, but yeah, they're there, so I'd rather make them presented better than "shove them under the carpet"


fix: restructure test suite to avoid to many external dependencies

The intention behind this is to make tests faster and more robust. Especially to avoid false positives where the test works, but fails due to interaction with HF, the OS (CLI commands).

Restructure the test suite to make it easier to find specific tests and add tests in the future. e.g. added all evaluator's test to a folder
splits test_mteb into multiple segments, one for testing SentenceTransformers, one for testing evaluation workflow, one for testing integration with datasets
avoid using encoders when testing evaluation workflow (one extra interaction with hf which can fail and it is slow)
Added MockEncoders for testing torch, numpy, and torch bf16 return types (see FP16 embeddings fail with BitextMining #1064)
Added MockTask for all task types to avoid downloading too many datasets and to allow for more diverse tests without making the test suite too slow

The slowest test are now the mteb_rerank tests along with the integration tests. @orionw was hoping we might be able to replace the dataset with a dummy dataset. However the slowest atm. is 20s (when dataset and models are downloaded).
This PR also added a few minor fixes (surprisingly few actually) for handling torch bf16 which was not handled and a minor fix to AbstaskClusteringFast (@isaac-chung)
Fixes #1064

Checklist

[x] Run tests locally to make sure nothing is broken using make test.
[x] Run the formatter to format the code using make lint.

Thanks @KennethEnevoldsen, this is awesome!!

The slowest test are now the mteb_rerank tests along with the integration tests. @orionw was hoping we might be able to replace the dataset with a dummy dataset. However the slowest atm. is 20s (when dataset and models are downloaded).

Lets definitely replace with a dummy dataset to speed it up. Do we already have a mockup of that or do you mean upload a new dummy data to mteb's huggingface that has only a few examples?

Lets definitely replace with a dummy dataset to speed it up. Do we already have a mockup of that or do you mean upload a new dummy data to mteb's huggingface that has only a few examples?

We already have a MockReranking task. If you can re-use that it would be great (however the results might just always be 1 or 0).


Broken link for Blueprint

Broken link: https://docs.microsoft.com/en-us/azure/governance/blueprints/samples/hipaa-hitrust/

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: b545aa0d-ba68-3113-413b-0c0b176b08bd
Version Independent ID: bb2ce8e1-7f40-e5ed-60c4-f8bb0912661d
Content: Health Insurance Portability and Accountability (HIPAA) & HITECH Acts - Microsoft Compliance
Content Source: microsoft-365/compliance/offering-HIPAA-HITECH.md
Product: microsoft-365-enterprise
GitHub Login: @robmazz
Microsoft Alias: robmazz

@balivo Thank you for your feedback. We have made changes to the document via PR#https://github.com/MicrosoftDocs/microsoft-365-docs/pull/2898
Thanks
Sri

@msbemba Thank you very much for the contribution and updating the documentation with PR. @balivo Hope this update is helpful for you. Thanks for taking out some time to open the issue. Appreciate and encourage you to do the same in future also.


Nice product, but without hierarchy view I can't use it

I was surprised that the folders were not expandable in the left pane to show sub-folders.  Nice product, but, having hundreds of nested folders, this is pretty useless without it, as that is an important navigational feature for developers, who, I would expect to be one of your primary targets.  I like the multiple tabs.  Tried because of a shout-out in Verge this morning.  Good luck.

Merging with #1928


problem building an application after update 1.0.0-next.181 --> 1.0.0-next.294

Describe the bug
The production build is different, and I don't know why. It seems that I have a problem of bundling?
When I run my application I get the error Error [ERR_MODULE_NOT_FOUND]: Cannot find package 'tslib' imported from /app/server/entries/pages/__layout.svelte.js
Before the update, the build directory was:
assets/
index.js
middlewares.js
package.json
prerendered/

and now:
client/
handler-b078b6a3.js
handler.js
index.js
manifest.js
multipart-parser-75f7689d.js
package.json
server/
shims-eb608bdd.js
shims.js
static/

I am sorry because I'm sure it's a problem of configuration, but I don't find it...
Reproduction
not sure it's necessary...
Logs
No response
System Info
System:
    OS: Linux 5.11 Ubuntu 21.04 (Hirsute Hippo)
    CPU: (16) x64 AMD Ryzen 7 4800H with Radeon Graphics
    Memory: 998.07 MB / 30.78 GB
    Container: Yes
    Shell: 3.1.2 - /usr/bin/fish
  Binaries:
    Node: 16.10.0 - ~/.volta/tools/image/node/16.10.0/bin/node
    npm: 7.24.0 - ~/.volta/tools/image/node/16.10.0/bin/npm
  Browsers:
    Chrome: 99.0.4844.51
    Firefox: 96.0
  npmPackages:
    @sveltejs/adapter-node: ^1.0.0-next.71 => 1.0.0-next.71
    @sveltejs/kit: 1.0.0-next.294 => 1.0.0-next.294
    svelte: ^3.42.6 => 3.46.4

Severity
blocking an upgrade
Additional Information
No response

Yes, a reproduction is necessary.

@christophemacabiau it might be advisable to use the repo Discussions forum until you have confirmed it's actually a bug. That's what i'm trying to do. Fundamental things are still in flux, so asking for help there, instead, allows the devs to keep working on Sveltekit, without us slowing them down. :)

I added a reproduction. You can run npm run build.
If it's better for you, I can close this bug and go forward with a discussion as mentionned @ITwrx


chore: add first load telemetry to evaluations

Description
This PR adds an attribute to evaluations span that tells whether the evaluation is first evaluation on page load or a subsequent one.
This attribute will help us filter evaluations and measure gains in update evaluations and first page load evaluations separately.
Fixes #Issue Number
or
Fixes Issue URL

[!WARNING]
If no issue exists, please create an issue first, and check with the maintainers if the issue is valid.

Automation
/ok-to-test<EMAIL_ADDRESS>:mag: Cypress test results

[!TIP]
🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/9381739425
Commit: 4cdd01dc24c70aa29b908420e60c984d20b2494d
Cypress dashboard url: Click here!

Communication
Should the DevRel and Marketing teams inform users about this change?

[ ] Yes
[ ] No

Summary by CodeRabbit

Bug Fixes

Added a conditional check before calling endSpan to handle parentSpan in action execution.

Refactor

Updated types and interfaces related to telemetry data handling to enhance type safety and clarity.
Adjusted telemetry data processing to accommodate new SpanAttributes.

New Features

Introduced filtering for telemetry span data to exclude specific entries, improving data management.

LGTM


Initial implementation of ALTER CURRENT MIGRATION REJECT PROPOSED

This adds the capability of making "guided" schema diffs, where certain
predicted operations have been prohibited.
Fixes: #1681

There are two unrelated commits in this PR. Please rebase

Rebased.


:bug: Cookie domain missing

Problem Statement
Browser auth now runs every time. The cookies aren't saved.
Regression introduced by #145.
Solution

Set cookie domain during browser auth

@mraible fully manual tested both with and without browser-auth enabled. Ready to merge.

@AlainODea I'm going on vacation for the next two weeks (starting today). I can roll a release before I go if you'd like.

@mraible sorry for the delay. Please do roll a release. There's some major gold in there now for users.


.nuget.props and .nuget.targets files are not loaded in MSBuild on .NET Core

After https://github.com/NuGet/Home/issues/3102 is fixed.  The next issue that the CLI will be blocked on is that the generated $(ProjectName).nuget.props and $(ProjectName).nuget.targets files are not loaded when using MSBuild on .NET Core.
From my preliminary debugging, it appears that the Common.props/targets files are not loading up the Microsoft.NuGet.props/.targets when on .NET Core.
Normally on desktop builds, these NuGet .props and .targets files are loaded because they are installed to the "ImportBefore"/"ImportAfter" folders in Program Files.  However, these folder locations are not applicable on .NET Core.
This is blocking the CLI using MSBuild to build .csprojs for .NET Core cross-plat.

To get this going we'll need Microsoft.NuGet.ImportAfter.targets and friends in a NuGet package that we can unpack into an MSBuild directory, or to incorporate that functionality directly into common targets.
Workaround for now: you can get past this by copying the nuget files from C:\Program Files (x86)\MSBuild\14.0\Microsoft.Common.Targets\ImportAfter\Microsoft.NuGet.ImportAfter.targets to {msbuildlocation}\Extensions\15.0\Microsoft.Common.targets\ImportAfter\ (and so on for props).

Being designed in #784


use proptest to fuzz the resolver

This has been a long time goal. This uses proptest to generate random registry indexes and throws them at the resolver.
It would be simple to generate a registry by,

make a list of name and version number each picked at random
for each pick a list of dependencies by making a list of name and version requirements at random.

Unfortunately, it would be extremely unlikely to generate any interesting cases, as the chance that the random name you depend on was also generated as the name of a crate is vanishingly small. So this implementation works very hard to ensure that it only generates valid dependency requirements.
This is still a WIP as it has many problems:

[x] The current strategy is very convoluted. It is hard to see that it is correct, and harder to see how it can be expanded. Thanks to @centril for working with me on IRC to get this far. Do you have advice for improving it?
[X] It is slow as molasses when run without release. I looked with a profilere and we seem to spend 2/3 of the time in to_url. Maybe we can special case example.com for test, like we do for crates.io or something? Edit: Done. lazy_static did its magic.
[x] proptest does not yet work with minimal-versions, a taste of my own medicine.
[x] I have not verified that, if I remove the fixes for other test that this regenerates them.

The current strategy does not:

[x] generate interesting version numbers, it just dose 1.0.0, 2.0.0 ...
[x] guarantee that the version requirements are possible to meet by the crate named.
[ ] generate features.
[ ] generate dev-dependencies.
[x] build deep dependency trees, it seems to prefer to generate crates with 0 or 1 dependents so that on average the tree is 1 or 2 layers deep.

And last but not least, there are no interesting properties being tested. Like:

[ ] If resolution was successful, then all the transitive requirements are met.

[x] If resolution was successful, then unpublishing a version of a crate that was not selected should not change that.

[x] If resolution was unsuccessful, then it should stay unsuccessful even if any version of a crate is unpublished.

[ ] @maurer suggested testing for consistency. Same registry, same cargo version, same lockfile, every time.

[ ] @maurer suggested a pareto optimality property (if all else stays the same, but new package versions are released, we don't get a new lockfile where every version is <= the old one, and at least one is < the old one)

r? @matklad
(rust_highfive has picked a reviewer for you, use r? to override)

cc @AltSysrq wrt. advice.

Sounds like a great idea to me! I don't have many thoughts in terms of how best to approach this or how to solve the open issues, but when you're comfortable merging I'm game for that :)

When the core functionality is working, I may decide to merge before all the things are checked off transferring the remainder to new issues. The code is far to inscrutable for it to be worth doing now, but before merge it needs comments so that other programers can understand what it is doing. I will need help finding the confusing parts, and making me explain them.

generate a u16::any() then in the last prop_map I can use that u16 as an index into the vec

I think the Index type added in proptest 0.8.6 would be usable for this purpose.

@AltSysrq I was just reading through the changes in 0.8.6 one commit at a time. Each commit was more perfectly what I needed then the last! I nearly fell out of my seat with excitement for several of them! Thank you! Thank you! Thank you!

I was not expecting that to fail! Either there is something wrong with the assertion in my last commit or we have a live bug!

@Centril and I just had a long conversation about how to get shrinking to work better on discord. Thanks for the help!
We had 2 approaches worth exploring.
1, get proptest to do the process I did by hand. Us something like the code we have now to generate the input, but also generate a BitSet with all bits set to true. Then have shrinking only run on the BitSet. Removing dependencies, and crates when the corresponding bit is shut off. this would not have shrinking on the names/version numbers. Unless we have a prop_flat_map that renames them after the BitSet thing.
2, use a separate edge list. (Index, Index) the min is the dependent, the max is the depender.
3, whaght for State machine support, and see if it would work.

Heh I don't think I really understand much of what's going on here, but don't let that stop you! It's already found at least one bug so I'm fine merging whenever :)

So the only change to cargo's code (not test code) is
https://github.com/rust-lang/cargo/pull/5921/files#diff-2305770923daa439ab4f47bb3f1abf5c
but I don't think it is common for people to use cargo with debug assertions. If that looks ok, then we can r+ and do more in follow up PR's.

@bors: r+
Ok!

:pushpin: Commit 40d9de46d6de46cde1c66f302d2553e77562764c has been approved by alexcrichton

@bors: retry

:cake: Activated

:pushpin: Commit 3e7192ea5d4bb5b99645b59a7d7bbdf77bc64ec3 has been approved by alexcrichton

I added a commit that added a new type so that the output of a proptest failing can be copy/pasted into a new normal test.
@bors: r=alexcrichton

:hourglass: Testing commit 3e7192ea5d4bb5b99645b59a7d7bbdf77bc64ec3 with merge 6b83bb619216c1a645030f4cb01df73fda874501...

:boom: Test timed out

What is going on with appveyor!? That one timed out on cargo check!?

@bors: retry

:hourglass: Testing commit 3e7192ea5d4bb5b99645b59a7d7bbdf77bc64ec3 with merge 702df0e21095549e1b9600d0f049b797bd31cbaf...

:broken_heart: Test failed - status-travis

test resolve::limited_independence_of_irrelevant_alternatives ... test resolve::limited_independence_of_irrelevant_alternatives has been running for over 60 seconds
[....]

No output has been received in the last 10m0s, this potentially indicates a stalled build or something wrong with the build itself.
Check the details on how to adjust your build configuration on: https://docs.travis-ci.com/user/common-build-problems/#Build-times-out-because-no-output-was-received

The build has been terminated

maybe the test is just too slow in debug mode?

It is randomize testing of NP complete code, so it is possible that some random portion of the time it finds an example the take so long to complete that we don't see the error message.
Locally I have had this test running repeatedly in a loop for a couple of days trying to find an example that might be causing this. So far no luck.
I know proptest has some fancy features specifically for dealing with this issue, when I get a chance I will investigate using them.

The limited_independence_of_irrelevant_alternatives is very slow in debug mode.
It took 16 minutes to complete on my system which I deem to be faster than the average travis virtual env.
So if it is launched somewhere at the end, travis will autokill the job because no output has been supplied for 15 minutes.

Thanks for the sample! It is randomized so it may take different amounts of time on different runs. Also it is setup to run a smaller number of cases on CI then locally.
Possible solutions include:

Have CI run fewer cases.
Have each case loop fewer times hear and hear
Find ways for the test to run more efficiently.
See if with the new debug the result_cache is worthwhile.
Find the slow casses and mark them as bugs, possibly with the timeout.
Split the test up into more test that each run faster.

I am experimenting.

@bors: r=alexcrichton

:pushpin: Commit a4da525b92877fb7405042bc75b74723d83a51a6 has been approved by alexcrichton

:broken_heart: Test failed - status-appveyor

[35] SSL connect error (schannel: next InitializeSecurityContext failed: Unknown error (0x80092013) - The revocation function was unable to check revocation because the revocation server was offline.)

@bors: retry

:hourglass: Testing commit a4da525b92877fb7405042bc75b74723d83a51a6 with merge 4e09634983cf24e3886d0846b0ee54d1f0e5a6d3...

:sunny: Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing 4e09634983cf24e3886d0846b0ee54d1f0e5a6d3 to master...


Isolates credential expiration/validity logic.

This better encapsulates the credential expiration logic, aligning it
with the semantics used by google-auth-library-python. The logic can be
seen in the Credentials class in this module:
https://github.com/googleapis/google-auth-library-python/blob/master/google/auth/credentials.py
This also alters the AuthorizationHeader method to avoid unnecessary
locking if the credential is not expired/invalid.

This change is

We should ignore the AppVeyor failure, it tried to build after we removed the support scripts from master.


Adapter  Error

I registered a user resource in my json-api-default.php
'resources' => [
    'users' => \App\Repositories\UserRepository::class,
]

I also have the following configuration for namespace and by-resource
'namespace' => 'App\Api',
'by-resource' => true,

I created an adapter and a schema for users resources which are located in App\Api\Users
When I try the following request /api/users/1 I get the error below
[2019-08-16 10:49:58] local.ERROR: Class [App\Api\Users\Adapter] is not a resource adapter. {"exception":"[object] (CloudCreativity\LaravelJsonApi\Exceptions\RuntimeException(code: 0): Class [App\Api\Users\Adapter] is not a resource adapter. at [project-folder]/vendor/cloudcreativity/laravel-json-api/src/Container.php:378)
[stacktrace]
Do you know why I am getting this error ?
The error come from the Class cloudcreativity/laravel-json-api/src/Container.php:378
/**
 * @param $className
 * @return ResourceAdapterInterface
 */
protected function createAdapterFromClassName($className)
{
    $adapter = $this->create($className);
    if (!$adapter instanceof ResourceAdapterInterface) {
        throw new RuntimeException("Class [$className] is not a resource adapter.");
    }
    return $adapter;
}

I found the problem. I was wrong in the namespace in users adapter.

No problem, glad you found the solution!


Is there a way to define Array of Array?

Hi, I just see this tool and it's really cool! But I don't know how to define a type with 2d array. Is it like Array<Array(Integer)>?
I am using the solargraph in vscode, but looks like this can't intellisense the integer part. So I want to know is there a way to define it? thanks!

my bad. it worked with Array<Array(Integer)>. Close this as it's not a issue.


Role of probe_resistance

What is the domain name added after probe_resistance used for? Is it the domain name that is accessed only when the user name and password are incorrect?

It's a "secret link" that if you visit it, will prompt your client for authentication. It is needed if your client does not send authentication on its own.

It's a "secret link" that if you visit it, will prompt your client for authentication. It is needed if your client does not send authentication on its own.
How do I access a Baidu domain name if it is added to probe_resistance

Typically you need to have control over the domain.
(Sorry, I am not much help there. You might want to get feedback from someone else who lives in China.)

通常，您需要控制域。
（抱歉，我帮不上什么忙。您可能想从住在中国的其他人那里获得反馈。）

Thank you very much for your answer


Change fade transient view background color

thank you for creating this library @davdroman!
I have a global background color in my app (implemented using the ZStack approach). How do I change the fade transition to have the same color?
https://github.com/davdroman/swiftui-navigation-transitions/assets/21252681/0f49c294-4243-4d7f-bbac-22537352081b
notice how the background changes to white (black if dark mode) during the fade transition.

I am wondering the same thing. did you find a solution?

Just chiming in about this case:
The fade transition in itself works great! However, all the fading seems to not keep the previous view which leaves an opportunity to show the internal hosting controller background.
There are workarounds to this; you can tint the color of the internal hosting by just making an UIViewRepresentable that returns an UIView that doesn't do anything other than access the superview internally and setting the background to the color you want:
struct TransparentBackground: UIViewRepresentable {
    func makeUIView(context: Context) -> UIView {
        let view = UIView()

        DispatchQueue.main.async {
            view.superview?.superview?.backgroundColor = .clear
        }
        return view
    }

    func updateUIView(_ uiView: UIView, context: Context) {}
}

Then using it with .background(TransparentBackground())
The other thing was to bring other the UIKit fade animation so it correctly fades both the views with PrimitiveNavigationTransition, however, it seems there are some internal issues with this as I get a wonky navigation bar behavior when returning to the root view and pushing again (the navigation bar visibility is hidden but you can still interact with it), as well I also found that on func transition(with animator: Animator, for operation: TransitionOperation, in context: Context), the destination view for some reason has it's user interaction disabled.
I was wondering @davdroman if there is a way to make a fade that keeps the current view in place and just fades in the new view to present? 🤔


reconsidering the usage of term tracker item

Description of the issue
This comes from https://github.com/information-artifact-ontology/ontology-metadata/issues/175
We discussed this in the last oeo-dev meeting:

IAO proposal: tighten range of IAO:0000223 to URL
In future, only URLs are allowed, not comments, strings etc

Ideas of solution

think of a solution how we deal with that:

only link to issue or PR
add several term tracker items (issues/PRs) for discussion history

Update IAO import once the changes are released
apply solution to existing entities, i.e. write a script
document in wiki

Workflow checklist

[ ] I discussed the issue with someone else than me before working on a solution
[ ] I already read the latest version of the workflow for this repository
[ ] The goal of this ontology is clear to me

I am aware that

[ ] every entry in the ontology should have a definition
[ ] classes should arise from concepts rather than from words

Other option: define our own term tracker item and replace IAO:0000223 with our own.

Other option: define our own term tracker item and replace IAO:0000223 with our own.

Sure. Maybe we can even combine our own annotation and the proper usage of IAO:0000223. Topic for next dev meeting❗
As an example, this is how IAO document the devolopment history:

From latest oeo-dev 79:

discussion:

only URLs as range and no longer plain strings: this may be a lot of work - we have many URLs to add and thousands of term trackers
alternative: replace IAO:0000223 with editor notes or RDFS:comment
we could do more research before decision?
implementation would be done by @madbkr
having the history of issues is nice

decision: create subannotation of "editor note" -> term tracker annotation

First try for a definition of term tracker annotation: A term tracker annotation is an editor note used within the Open Energy Ontology to track the history of a term. I tracks for each change the related GitHub issue and pull request.

@stap-m : Any thoughts about my proposal in the comment above?

I like the proposal. I don't think we should restrict it to the usage within OEO, esp with respect to new energy ontologies.
What about:
A term tracker annotation is an editor note used to track the history of an entity. For each change, it records the related GitHub issue and pull request.

Being open for other ontologies is a good idea. So I agree to your improved definition.
To move on I suggest the following approach:

One PR to introduce this new annotation property term tracker annotation first.
Then one PR per OEO file to replace all uses of term tracker item with term tracker annotation. This can probably be done using search & replace in in a text editor.

Sounds good to me. I'll create a PR for the new annotation.

Reopen: Not completely finished, see https://github.com/OpenEnergyPlatform/ontology/pull/1922#issuecomment-2355068869

Reopen: Not completely finished, see #1922 (comment)

@madbkr please have another look.

I re-open this issue:
While using term tracker annotation in #1925 I noticed that Protégé does not show the annotation properly:

Which class and module?
I cannot reproduce that:

Oh, it is even weirder, the annotation appears twice, at least in oeo.omn:

I don't have that either. Which branch?

Branch feature-1873-licence-axioms of PR #1925.
It appears twice in if I look into the following files:

oeo.omn
oeo-physical-axioms.owl

In oeo-physical-axiom.owl it even shows:

Those two have the following IRIs:

http://openenergy-platform.org/ontology/oeo/OEO_00020426
http://openenergy-platform.org/ontology/oeo/oeo-physical-axioms/OEO_00020426

Looks like a bug in oeo-physical-axioms.owl. Maybe something with the namespaces?


Add Skip button while creating the patient without creating consulation

To improve the user experience when creating patients, you can add a "Skip" button that allows users to proceed without creating a consultation. This way, users can avoid confusion and avoid having to click "Cancel," which might imply abandoning the entire patient creation process.

and I would like to improve the Linked facilties and linked skills

We shouldn't be encouraging users to skip creating a consultation.


[BUG] Incorrect code coverage when converting from V8 to istanbul

Hi @cenfun,
Bug description
I mainly use the V8 code coverage when working in my dev machine and all works great. However, I have a requirement to upload code coverage to SonarQube and it requires an lcov file. When I enable the monocart-reporter option to get the lcov file as such:
coverage: {
    toIstanbul: true,
    lcov: true,
    ...
},

The code coverage that I get is incorrect. Please see screenshots below for more information. The code coverage screenshots were produced by running with:

babel + istanbul: this shows correct code coverage.
v8 + monocart reporter without the toIstanbul property set which defaults to false:  this shows correct code coverage.
v8 + monocart reporter with the toIstanbul property set to true:  this shows INCORRECT code coverage.

babel+istanbul

Note
The code coverage below is correct

app/core/ui-services/ui-helper-functions.ts

app/features/find-institution/institutions-list/institutions-list.component.ts

v8 + monocart reporter without the toIstanbul property set which defaults to false

Note
The code coverage below is correct

src/app/core/ui-services/ui-helper-functions.ts

src/app/features/find-institution/institutions-list/institutions-list.component.ts

v8 + monocart reporter with the toIstanbul property set to true

Warning
The code coverage below is INCORRECT. Some lines are showed as covered when they should not be.

app/core/ui-services/ui-helper-functions.ts

app/features/find-institution/institutions-list/institutions-list.component.ts

How to reproduce

Checkout the temp branch at edumserrano/monocart-code-coverage-demo/tree/temp.
run npm install to install all the required packages

To get the babel+istanbul code coverage:

run npm run test-istanbul.

To get the v8 + monocart reporter without the toIstanbul property set which defaults to false code coverage:

run npm run test-monocart. The first time tests will fail because of missing snapshots, you can ignore this.
run npm run open-monocart-coverage.

To get the v8 + monocart reporter with the toIstanbul property set to true code coverage:

go to the playwright.confi.ts for the monocart setup and uncomment the lines:

// toIstanbul: true,
// lcov: true,

run npm run test-monocart. The first time tests will fail because of missing snapshots, you can ignore this.
run npm run open-monocart-coverage.

More notes
To clarify, the problem is that when using toIstanbul set to true the code coverage conversion marks some lines as covered when they should not be.
Let me know if you need more information.

if toIstanbul = true, the v8-to-istanbul will take the conversion work.
seems it has bug, i'm not very familiar with it, could you please go here to find out if this bug already exists
https://github.com/istanbuljs/v8-to-istanbul/issues

Got it, I've reported this issue at istanbuljs/v8-to-istanbul#216.
Let's see what they say.

For anyone else reading this thread, I'd like to leave here feedback about how the workaround I've used until the issue the the v8-to-istanbul conversion is solved.
What I did was have a 2 fixtures as part of my playwright tests:

one of the fixtures instruments the code with v8 and I also use monocart-reporter configured with global code coverage which makes use of the v8 instrumentation. This is my preferred code coverage reporting experience and the one I use on the day to day dev.
one of the fixture instruments the code with istanbul. To do this I use the babel-plugin-istanbul to get istanbul instrumentation added to my Angular app and then the fixture saves that code coverage into a folder which is then used by the nyc tool to produce a cobertura and lcov files. These files are what I need to upload to my Azure DevOps pipeline and SonarQ.

To understand more about how you could implement the above please read this comment on microsoft/playwright#7030.
For a code example read the README and see the code on the edumserrano/monocart-code-coverage-demo repo. My workaround is essentially the merging of both configurations and fixtures on /tests/babel-istanbul and [/tests/monocart(https://github.com/edumserrano/monocart-code-coverage-demo/tree/main/tests/monocart).
Potential downsides of this workaround is that I'm instrumenting the code twice. I haven't noticed any added slowness when running the tests but your mileage may vary. You could argue that instrumenting the code via istanbul only is enough since it gives me a code coverage report which I could attach to the monocart-reporter but I really like the user experience given by the monocart-reporter when a v8 report is available.

@edumserrano I'm guessing you are using the workaround for normal playwright tests, not Component Testing right?

@edumserrano It's been a week, but there is no update on the issue.
I did some research and found that the conversion is really complicated, it seems that the v8-to-istanbul library can't resolve this issue, so I rewrote a new own converter, which should fix this issue.
please try<EMAIL_ADDRESS>

@cenfun you're a genius! 👏
I can confirm this is now all working properly! Well done, thank you very much 🎉


tester has been broken

The ethereum.tester has been broken in 1.3.3 (in 1.3.2 it works):
  File "/home/ubuntu/virtualenvs/venv-system/local/lib/python2.7/site-packages/ethereum/tester.py", line 114, in __init__
    for function_name in self.translator.function_data:
AttributeError: 'str' object has no attribute 'function_data'

There is not enough detail to figure out the problem. ABIContract could be instantiated at line 227, but that path always use a ContractTranslator, not a str object. Could you provide a minimum failing test?
Also, have you tried a more up-to-date version? The current version is 1.3.6

The test is from https://github.com/imapp-pl/ethereum-contracts/blob/master/tests/test_bankofdeposit.py#L43. It might be a change in the ABIContract constructor, I pass a string containing JSON there.
The API change is precisely in version 1.3.3. I tested everyone in from 1.3.0 to 1.3.6 and 1.2.
Exemple builds: https://circleci.com/gh/imapp-pl/ethereum-contracts
If it is still not enough information I will prepare a test later on.

Thank you.
On Wed, Jun 29, 2016, 09:45 konradkonrad<EMAIL_ADDRESS>wrote:

Closed #370 https://github.com/ethereum/pyethereum/issues/370 via
584f15e
https://github.com/ethereum/pyethereum/commit/584f15e2ab0d802f2ee868e971c6d8eb6b4bb74d
.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/ethereum/pyethereum/issues/370#event-707383738, or mute
the thread
https://github.com/notifications/unsubscribe/AAi_xG7wmAA2ReJ-op5IgSzpkBPW-xzPks5qQiKxgaJpZM4I_Fh_
.


[Enhancement] Support drop storage volume if exists

Fixes #issue
What type of PR is this:

[ ] BugFix
[ ] Feature
[x] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Checklist:

[x] I have added test cases for my bug fix or my new feature
[ ] This pr will affect users' behaviors
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

[x] I have checked the version labels which the pr will be auto-backported to the target branch

[x] 3.1
[ ] 3.0
[ ] 2.5
[ ] 2.4

[FE PR Coverage Check]
:heart_eyes: pass : 11 / 11 (100.00%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/sql/ast/DropStorageVolumeStmt.java
1
1
100.00%
[]

:large_blue_circle:
com/starrocks/server/StorageVolumeMgr.java
2
2
100.00%
[]

:large_blue_circle:
com/starrocks/qe/DDLStmtExecutor.java
8
8
100.00%
[]

[FE PR Coverage Check]
:heart_eyes: pass : 11 / 11 (100.00%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/sql/ast/DropStorageVolumeStmt.java
1
1
100.00%
[]

:large_blue_circle:
com/starrocks/server/StorageVolumeMgr.java
2
2
100.00%
[]

:large_blue_circle:
com/starrocks/qe/DDLStmtExecutor.java
8
8
100.00%
[]

[FE PR Coverage Check]
:heart_eyes: pass : 11 / 11 (100.00%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/sql/ast/DropStorageVolumeStmt.java
1
1
100.00%
[]

:large_blue_circle:
com/starrocks/server/StorageVolumeMgr.java
2
2
100.00%
[]

:large_blue_circle:
com/starrocks/qe/DDLStmtExecutor.java
8
8
100.00%
[]

@Mergifyio backport branch-3.1

[FE PR Coverage Check]
:heart_eyes: pass : 11 / 11 (100.00%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/sql/ast/DropStorageVolumeStmt.java
1
1
100.00%
[]

:large_blue_circle:
com/starrocks/server/StorageVolumeMgr.java
2
2
100.00%
[]

:large_blue_circle:
com/starrocks/qe/DDLStmtExecutor.java
8
8
100.00%
[]


Small error in documentation

requirements.txt is not in workpackages directory.
This should be changed:
 cd mergin-work-packages/workpackages
 python3 -m venv venv
 ./venv/bin/pip3 install -r requirements.txt
 ./venv/bin/python3 wp_mergin.py --help

to:
 cd mergin-work-packages/workpackages
 python3 -m venv venv
 ./venv/bin/pip3 install -r ../requirements.txt
 ./venv/bin/python3 wp_mergin.py --help

can you make Pull RRequest with the change @jozef-budac ?

yep

this is already fix on main


PSA Add match kind docs

The text is based on this PR merged into the BMv2 documentation: https://github.com/p4lang/behavioral-model/pull/699
It adds notes on the relative priority of 'const entries' table entries, which should resolve this issue: https://github.com/p4lang/p4c/issues/1663
It resolves that issue without any changes required to p4c, by saying that if you have a longest-prefix match table, the relative priority of multiple entries specified via 'const entries' is based upon the prefix lengths, ignoring the order that the entries appear in the source code.


searchlight: outputs more than a 3d array?

Hello,
I use searchlight to compare the activation pattern in each cube to a predicted pattern (correlation).
To do my statistic analysis, I also permute the data for 1000 iterations to get the null distribution.
My problem is that, the output of searchlight is a 3D imaging, e.g. z-value, but I need more than one outputs.
For example, I might need the r-value, the z-value, and the std of the null distribution in each cube.
I also need the maximum r-value across voxels in each iteration. Therefore, a 4D outputs with dimension 4 equals the number of iteration might be useful.
Is it possible to get a 4D output from searchlight?
Thanks.

The searchlight result can contain arbitrary (pickle-able) Python objects. So you could return a tuple containing all the values you are interested in from your searchlight function.

I tried and failed.
Could you give me an example.
And below is my codes:

def rsa_perm(fmri,msk,myrad,bcast_var):
...     fmri = np.array(fmri)
...     fmri = fmri.reshape((-1,fmri.shape[-1]))
...     fmri=fmri[~np.isnan(fmri).any(axis=1)] # remove rows containing NA
...     fmriSim = np.corrcoef(fmri,rowvar=0)
...     r_p = np.corrcoef(np.concatenate(fmriSim),np.concatenate(textSim))[0,1]
...
...     np.random.seed(0)
...     r_perm_holder = []
...     for i in range(iteration):
...         fmriSim_perm=np.random.permutation(fmriSim)
...         fmriSim_perm=np.random.permutation(fmriSim.T).T
...         r_p_perm = np.corrcoef(np.concatenate(fmriSim_perm),np.concatenate(textSim))[0,1]
...         r_perm_holder.append(r_p_perm)
...     std=np.std(r_perm_holder)
...     z = (r_p - np.mean(r_perm_holder))/np.std(r_perm_holder)
...     return r_p, std, z
...
sl = Searchlight(sl_rad=rad,max_blk_edge=10) # rad unit is voxel
sl.distribute([fmri_datam_zscore_4d],roi_img)
sl.broadcast(textSim)
print('Running Searchlight...')
Running Searchlight...
r, std, z = sl.run_searchlight(rsa_perm)
Traceback (most recent call last):
File "", line 1, in
File "/jukebox/pkgs/ANACONDAPY/ni/lib/python3.6/site-packages/brainiak/searchlight/searchlight.py", line 378, in run_searchlight
return self.run_block_function(_singlenode_searchlight)
File "/jukebox/pkgs/ANACONDAPY/ni/lib/python3.6/site-packages/brainiak/searchlight/searchlight.py", line 294, in run_block_function
for (idx, mypt) in enumerate(self.blocks)]
File "/jukebox/pkgs/ANACONDAPY/ni/lib/python3.6/site-packages/brainiak/searchlight/searchlight.py", line 294, in
for (idx, mypt) in enumerate(self.blocks)]
File "/jukebox/pkgs/ANACONDAPY/ni/lib/python3.6/site-packages/brainiak/searchlight/searchlight.py", line 373, in _singlenode_searchlight
outmat[i, j, k] = outlist[cnt]
ValueError: cannot copy sequence with size 3 to array axis with dimension 1

Looking at the last line in the traceback you posted (outmat[i, j, k] = outlist[cnt]), I think you are using an old version of BrainIAK. Could you please upgrade before continuing testing?
Finally, note that run_searchlight will return a single array that has multiple values in each element, as opposed to multiple arrays, so you will not be able to write r, std, z = sl.run_searchlight(rsa_perm).

Ur...So what function should I use instead of "run_searchlight??"

You should use run_searchlight. As you saw, the output is a 3D array. Each element of that array is a tuple containing r_p, std, z, the elements you return in your searchlight function, rsa_perm.

I finally got it right!
The problem with my testing is that the mask I used contains NaN.
Therefore, only one NaN value is returned.
It works now.
Thanks a lot! :)

Happy to help. :)
FYI, I created another issue (issue #267) about adding an example that deals with multiple return values to make it easier for others in the future.


[24.05] ci/OWNERS: remove ckiee

They're not part of the NixOS org anymore after they're removed themselves in https://github.com/NixOS/nixpkgs/pull/323895. This makes CI fail on 24.05 now though.

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

CI check is green now :)


compose: Align blue selection properly in Drafts.

Removed the css rule for the grey border around draft-info-boxes which was creating the gap between the box and its outline - which is the blue selection.
Fixes: #20950.
Testing plan:
Tested manually, both for light and dark modes, to check that the blue selection outline now fits snuggly around the draft info box.
GIFs or screenshots:

I don't think this is the right fix -- the drafts that aren't selected look wrong without a border.
It seems like the proper fix would be to just adjust the positioning of either the grey or blue box to avoid the gap.

I don't think this is the right fix -- the drafts that aren't selected look wrong without a border.
It seems like the proper fix would be to just adjust the positioning of either the grey or blue box to avoid the gap.

I understand. I'll make it so that the blue box covers the grey box in active state by adding a negative offset. This way the unselected boxes will look the same as they did before (that it, with the grey border), while the selected boxes will have the blue box without a gap. Hope that sounds alright?

@timabbott I've updated the PR message and screenshots as well. As is visible, now the unselected drafts retain their grey border, while selected ones have no gap.

This is great, merged, thanks @N-Shar-ma!


Clean up includes in processing blocks

mostly moves synthetic-stream.h include to .h files where its necessary, and cleaning up unnecessary includes from the .cpp files (environment.h and context.h were the worst offenders)

its also worth mentioning that this PR is not exhaustive. It's possible more changes need to be made to other files, or even these ones. This is just what I discovered while working on something else


marathon 1.5.3 bump

High-level description
Bugfixes
Corresponding DC/OS tickets (obligatory)
These DC/OS JIRA ticket(s) must be updated (ideally closed) in the moment this PR lands:
Fixed issues

MARATHON_EE-1701 Pods now respect hostname: UNIQUE constraint
MARATHON_EE-1768 Proper reading of secrets from volumes
MARATHON_EE-1764 Speed up service port assignment
MARATHON_EE-1770 Speed up service port assignment

Related tickets (optional)
Checklist for all PRs

[x] Included a test which will fail if code is reverted but test is not. If there is no test please explain here:
[x] Read the DC/OS contributing guidelines
[x] Followed relevant code rules Rules for Packages and Systemd

Checklist for component/package updates:
If you are changing components or packages in DC/OS (e.g. you are bumping the sha or ref of anything underneath packages), then in addition to the above please also include:

[x] Change log from the last version integrated (this should be a link to commits for easy verification and review): https://github.com/mesosphere/marathon/compare/v1.5.2...bbf1bacca3d32078045a472747d6323e726685cb
[x] Test Results: https://jenkins.mesosphere.com/service/jenkins/view/Marathon/job/marathon-pipelines/job/releases%252F1.5/38/
[x] Code Coverage (if available): N/A

@mesosphere-mergebot label ready for review

@mesosphere-mergebot bump-ee

Read @mellenburg comment on mesosphere/dcos-enterprise#1823


style: set line length to 99

The maximum line length recommended in PEP-8 is 99.

https://peps.python.org/pep-0008/#maximum-line-length

Some teams strongly prefer a longer line length. For code maintained exclusively or primarily by a team that can reach agreement on this issue, it is okay to increase the line length limit up to 99 characters, provided that comments and docstrings are still wrapped at 72 characters.

I prefer a longer line length. For what it's worth, the GitHub diff view side-by-side fits comfortably on my screen at this length.


Use metrics-json module

It would be nice for the reporter to use the metrics-json lib (https://github.com/dropwizard/metrics/tree/master/metrics-json).
One of the missing fields in the current JSON serializers is the samples for any metric with a histogram (timer etc..) which could be used in kibana to plot the latest samples instead of plotting statistical values.

That would be nice - but the one in metrics doesn't allow for easy customization (adding fields) - and there is an additionalFields and timestamp in the current imp that would be gone missing: https://github.com/dropwizard/metrics/blob/master/metrics-json/src/main/java/io/dropwizard/metrics/json/MetricsModule.java

You're right, sorry for overlooking that. However I'll explain further my initial need.
Suppose I have a timer, and I setup an ElasticsearchReporter to report my timer. What I would like to be able to do in Kibana, is to plot my timer (last sample value) with date histogram bucketing. What's available with the current impl is only the statistical values (stddev, percentials, avg etc..). I saw the samples serialization commented out, and that was why I original created this issue. This for example is very easy to do using simple gauges (because the gauge itself is an instantaneous snapshot of the metric at the time the reporting occurs).
I'll try to find a way to figure it out, and post the solution in case that happens.
Issue closed :)
Thanks

If the one in metrics core could cater for additional fields it would probably invite for wider reuse


Sidebar not generated based on .md files in the /docs folder

Docs: https://docsify.js.org/#/more-pages

By default, the table of contents in the sidebar is automatically generated based on your markdown files.

10 seconds YouTube video https://www.youtube.com/watch?v=O1hlHow0xXw

Potential duplicate: #157
Reason for opening a new issues - VISIBILITY - ever though previous issue was closed I don't seem to find a solution.
Manually adding...
<!-- docs/_sidebar.md -->

- [Home](/)
- [Guide](guide.md)

...and setting . loadSidebar: true seems cumbersome, I would imagine sidebar should be generated automagically, just like the overall philosophy of the docs?

I think it should be my English did not express clearly.
My meaning is that the TOC in the article are automatically generated.

I see, headers are populated automatically.
Is it possible to populate list of pages automatically? (with an optional ordering)

This is impossible.
First, We can not get your list of files from the static server, so it is not dynamically generated.
Second, Perhaps we can automatically generate locally and write to _sidebar.md, but we do not know the order of the documents what you wanted.
There are currently no documentation tools that provide this feature and I think it is better to manually maintain the _sidebar.md.

Thank you for clarifying. Technical limitation of fetching list of the files.
docsify serve docs If _sidebar.md is not present, it could create _sidebar-autogen.md
That could run locally, with access to the list of files.

We can not know the list what the user wants. Sorting rules in alphabetical order, or create time? Do users need to include subdirectories?
Documents are not blogs, not simply files sorted by time. This automatic feature does not make sense.

Hey, it's all good, thank you for great work.
My reasoning...
The moment we use phrase Custom sidebar it suggest there is a sidebar created by default.
No such thing, no default sidebar, the _sidebar.md is obligatory.
Chances are users want to navigate between files.
OUCH chances are users want to have single long documentation file...
OK. At least I've learnt something.


[Snyk] Security upgrade python from 3.11 to 3.13.0b3-slim

Snyk has created this PR to fix 3 vulnerabilities in the dockerfile dependencies of this project.
Keeping your Docker base image up-to-date means you’ll benefit from security fixes in the latest version of your chosen image.
Snyk changed the following file(s):

Dockerfile

We recommend upgrading to python:3.13.0b3-slim, as this image has only 43 known vulnerabilities. To do this, merge this pull request, then verify your application still works as expected.
Vulnerabilities that will be fixed with an upgrade:

Issue
Score

Integer Overflow or Wraparound SNYK-DEBIAN12-AOM-7197979
  500

Link Following SNYK-DEBIAN12-GIT-6846203
  500

Link Following SNYK-DEBIAN12-GIT-6846203
  500

Integer Overflow or Wraparound SNYK-DEBIAN12-ZLIB-6008963
  500

Integer Overflow or Wraparound SNYK-DEBIAN12-ZLIB-6008963
  500

[!IMPORTANT]

Check the changes in this PR to ensure they won't cause issues with your project.
Max score is 1000. Note that the real score may have changed since the PR was raised.
This PR was automatically created by Snyk using the credentials of a real user.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic

Learn how to fix vulnerabilities with free interactive lessons:
🦉 Learn about vulnerability in an interactive lesson of Snyk Learn.

update docker file dependency for base image


Add DOCX to PDF conversion functionality.

This PR is related to issue: #55

Hi @naylin-dev ,
Thank you for your contribution :),
you can checkout more opened issues or you can also submit your own ideas/code.
Happy Coding!


[WIP] Enable seccomp filters

Setting seccomp filters is enabled. Additional flush after dumping the
seccomp config ensures that the file is flushed before passing to
libminijail.

Superseded by #114