Add contact info row

It would be good to have a contact info row so people could contact the hospitals with questions (i.e. one I've been asking lately is "do you accept 3D printed masks or face shields?"). Even if it was optional, as I'm sure hospitals are way too busy right now to answer a lot of questions.

We are letting hospitals decide whether to add contact info. many have! it's folded into the instructions usually.

In that case, how about changing the instructions form question from: "Drop off instructions, eg curbside procedure or mailing address ATTN: instructions:"
to something like:
"Drop off instructions, e.g. curbside procedure, mailing address, contact person/information"

Done, thank you!
On Sat, Mar 21, 2020 at 11:45 AM liamrosen<EMAIL_ADDRESS>wrote:

In that case, how about changing the instructions form question from:
"Drop off instructions, eg curbside procedure or mailing address ATTN:
instructions:"
to something like:
"Drop off instructions, e.g. curbside procedure, mailing address, contact
person/information"
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/r-pop/findthemasks/issues/52#issuecomment-602085868,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACV3JSX2LXSEMDYY5NDOZB3RIUDOPANCNFSM4LRAEMSQ
.

I had to revert this, it broke the parser we are trying to launch.

obsolete.


broken link fixed w/signoff

Notes for Reviewers
previous PR on ImageHub didn't solve the issue. I have fixed three broken link issues in "https://docs.meshery.io/guides/configuration-management/working-with-designs"

ImageHub link
sample applications link
Performance Management with meshery link

This PR fixes #9957
Signed commits

[ ] Yes, I signed my commits.

🚀 Preview for commit 992f77298baacc52889ba5b9316d20531c08dd64 at: https://65a39566f7a4795005ad9bc9--meshery-docs-preview.netlify.app

Hi @prathyushmadhu   ,
Thanks for your PR! I encourage you to share this in the Website Meeting tomorrow at 6:30 PM IST. Share your screen, and walk us through it. It's cool to take and share feedback. Check the Doc here to include this PR.
You're welcome at the meeting
Check to community calendar for more details of meetings at Layers.

🚀 Preview for commit 2ff4c1d7d573e7a81212d66892da51507cc6ff28 at: https://65a4a308e7ac41ee91c30c6f--meshery-docs-preview.netlify.app

@MUzairS15 I will look into that and will get to you.


devenv: split out library

I'm going to merge https://github.com/cachix/devenv/pull/1194 next and make 1.0.6, then this can go in ASAP :)


increase code quality as reported by scrutinizer

@padraic scrutinizer score is now increased to  7.69

I think we both had same idea ;). It's late here but will check merge tomorrow.

thanks ;). I've rebased against latest master.


2024-10-23_01-35-27_master-next_python3-botocore

Automatically created.

Successfully created backport PR for kirkstone-next:

#10111

Successfully created backport PR for scarthgap-next:

#10112

Successfully created backport PR for styhead-next:

#10113


Is there a real working example of using secure TLS ratchet websocket server?

I've been looking and looking without much success. I see hints that there is such a thing but no real documentation or examples. Any help would be greatly appreciated.
Thanks,
Daryl

Your question should be more specific, but here is an example how to establish secure WebSocket server:
$loop = React\EventLoop\Factory::create();
$pusher = new MyApp\Pusher;

// Listen for the web server to make a ZeroMQ push after an ajax request
$context = new React\ZMQ\Context($loop);
$pull = $context->getSocket(ZMQ::SOCKET_PULL);
$pull->bind('tcp://<IP_ADDRESS>:5555'); // Binding to <IP_ADDRESS> means the only client that can connect is itself
$pull->on('message', [$pusher, 'onUpdate']);

// Set up our WebSocket server for clients wanting real-time updates
$webSock = new React\Socket\Server('<IP_ADDRESS>:8443', $loop);
$webSock = new React\Socket\SecureServer($webSock, $loop, [
    'local_cert'        => 'C:/xampp/apache/conf/ssl.crt/server.crt', // path to your cert
    'local_pk'          => 'C:/xampp/apache/conf/ssl.key/server.key', // path to your server private key
    'allow_self_signed' => TRUE, // Allow self signed certs (should be false in production)
    'verify_peer' => FALSE
]);
//$webSock->listen(8443, '<IP_ADDRESS>'); // Binding to <IP_ADDRESS> means remotes can connect
$webServer = new Ratchet\Server\IoServer(
    new Ratchet\Http\HttpServer(
        new Ratchet\WebSocket\WsServer(
            new Ratchet\Wamp\WampServer(
                $pusher
            )
        )
    ),
    $webSock
);

$loop->run();

You should run this code via PHP CLI, then you can connect to your websocket via wss://server_name_or_ip:8443
If you get any timeout error while you try to connect you should check your firewall settings.
Hope it helps

Hi SFlame, Thanks for your reply. Sorry for not being more specific; let me remedy that. I have built the simple Ratchet hello world/chat example which works fine. I need to move this chat example to use a secure connection.
I appreciate your sample code and am playing with it now, but I'm not understanding the pusher piece. Is this a library I can install using composer? Googling pusher and websockets seems to lead to pusher.com which appears to require registration. I feel like I'm missing something here and I'm still bootstrapping my understanding of both reactphp and ratchet.
Thanks,
Daryl

Well, it's only my app that using the pusher integration, and it's a requirement for running a websocket server over a secure connection (If you're still interested in the pusher integration, you should check it out http://socketo.me/docs/push - no additional installation needed).
In order to run the your app over a secure connection, I think it should be as simple as that (not tested):
require dirname(__DIR__) . '/vendor/autoload.php';

use MyApp\Chat;

$loop = React\EventLoop\Factory::create();
$webSock = new React\Socket\Server('<IP_ADDRESS>:8443', $loop);
$webSock = new React\Socket\SecureServer($webSock, $loop, [
    'local_cert'        => 'C:/xampp/apache/conf/ssl.crt/server.crt', // path to your cert
    'local_pk'          => 'C:/xampp/apache/conf/ssl.key/server.key', // path to your server private key
    'allow_self_signed' => TRUE, // Allow self signed certs (should be false in production)
    'verify_peer' => FALSE
]);

$webServer = new Ratchet\Server\IoServer(
    new Ratchet\Http\HttpServer(
        new Ratchet\WebSocket\WsServer(
            new Chat()
        )
    ),
    $webSock
);

$webServer->run();

@darylwilliams update me if it worked for you.

Thanks @SFlame, I modified the paths to the cert and key files and have your sample code running and I can connect to the port using netcat, but the browser refuses the connection with the error "failed: Error in connection establishment: net::ERR_SSL_VERSION_OR_CIPHER_MISMATCH", so I'm guessing I'm not pointing at the right cert. I'm using certs from letsencrtypt. I'm going to play with it and I'll let you know what progress I make.
Thanks again for your help, it's much appreciated.
D.

I could start a TLS connection to a ratchet websocket server. I didn't used Ratchet/React at all, but I used stunnel.
So I guess it's always possible with apache/nginx/stunnel to provide a TLS layer without impacting Ratchet application. That could be an alternative solution.

Hi,
I cannot make this work when I deploy to server. I have used exact same settings above, except the server's crt and key files and I've set 'allow_self_signed' to false. But it is not working. Any help please?

@cometofsky Can you please share your settings?

Below is the code I have used
 require dirname(__DIR__) . '/vendor/autoload.php';

$loop   = React\EventLoop\Factory::create();
$pusher = new UGR\SocketIOBundle\Pusher;

  $context = new React\ZMQ\Context($loop);
  $pull    = $context->getSocket(ZMQ::SOCKET_PULL);

$pull->bind('tcp://<IP_ADDRESS>:5555');
$pull->on('message', [$pusher,
                                      'onUpdate']);

$webSock = new React\Socket\Server("<IP_ADDRESS>:8443", $loop);

  $webSock = new React\Socket\SecureServer($webSock, $loop, [
      'local_cert'        => '/var/www/ssl/my-cert-file.crt',
       'local_pk'          => '/var/www/ssl/my-key-file.key',
      'allow_self_signed' => FALSE,
        'verify_peer'       => FALSE,
      ]);

$webServer = new Ratchet\Server\IoServer(
    new Ratchet\Http\HttpServer(
        new Ratchet\WebSocket\WsServer(
            new Ratchet\Wamp\WampServer(
                $pusher
            )
        )
    ),
    $webSock
);

$loop->run();

I could solve my issues. In safari now I am getting this error - WebSocket network error: OSStatus Error -9807: Invalid certificate chain. Although I have e valid SSL certificate for my site, I guess they are telling me otherwise.

How did you get this cert? from where?

It was purchased from COMODO. It was not generated by me.

Check my current settings, working well for me:
$context = new React\ZMQ\Context($loop);
$pull = $context->getSocket(ZMQ::SOCKET_PULL);
$pull->bind('tcp://<IP_ADDRESS>:5555');
$pull->on('message', [$pusher, 'onUpdate']);

$webSock = new React\Socket\Server('{MY SERVER IP}:8443', $loop);
$webSock = new React\Socket\SecureServer($webSock, $loop, [
    'local_cert'        => '{MY_CERT_PATH}',
    'local_pk'          => '{MY_KEY_PATH}',
    'verify_peer' => FALSE
]);
$wsServer = new Ratchet\WebSocket\WsServer(
    new Ratchet\Wamp\WampServer(
        $pusher
    )
);
$webServer = new Ratchet\Server\IoServer(
    new Ratchet\Http\HttpServer(
        new \Ratchet\Session\SessionProvider($wsServer
            ,new \Illuminate\Session\CookieSessionHandler(new \Illuminate\Cookie\CookieJar(),20))
    ),
    $webSock
);
$wsServer->enableKeepAlive($loop,30);

$loop->run();

I'm using my domain names for the connection string:
new ab.Session('wss://'+window.location.hostname+':8443/ws',
            function () {
                //subscribe here
            },
            function () {
                //connection closed
            },
            {'skipSubprotocolCheck': true,'multiplex':false,'force new connection':true}
        );

Are you still getting the same error?

@SFlame - THANKS A LOT!!! I have just changed to domain name and now its working perfect!!! A pain relieved! (Y)

I've the same problem...
i've tried with
require '/opt/bitnami/apache2/htdocs/gestionaleCore/vendor/autoload.php';
$loop = ReactLoop::create();

  $pusher = new Pusher;
  // In ascolto del web sever per fare un push ZeroMQ dopo una richiesta AJAX.
  $context = new ReactContex($loop);
  $pull = $context->getSocket(\ZMQ::SOCKET_PULL);
  $pull->bind('tcp://<IP_ADDRESS>:5552');
  $pull->on('message', [$pusher, 'onSignRequest'] );

  $webSock = new SecureServer(
		new ReactServer('<IP_ADDRESS>:32000', $loop),
		$loop,
    array(
      'local_cert'        => '/opt/bitnami/apache2/conf/server.crt', // path to your cert
      'local_pk'          => '/opt/bitnami/apache2/conf/server.key', // path to your server private key
      'allow_self_signed' => FALSE, // Allow self signed certs (should be false in production)
      'verify_peer' => FALSE
    )
	);

  $wsServer = new WsServer(
        new WampServer(
          $pusher
        )
      );

  $webServer = new IoServer(
    new HttpServer(
      new SessionProvider(
        $wsServer,
        new CookieSessionHandler(
          new CookieJar(), 20
          )
        )
    ),
    $webSock
  );
  $wsServer->enableKeepAlive($loop,30);

  $this->info('Run handle');
  $loop->run();

and with
require '/opt/bitnami/apache2/htdocs/gestionaleCore/vendor/autoload.php';

    $loop = ReactLoop::create();

    $pusher = new Pusher;
    // In ascolto del web sever per fare un push ZeroMQ dopo una richiesta AJAX.
    $context = new ReactContex($loop);
    $pull = $context->getSocket(\ZMQ::SOCKET_PULL);
    $pull->bind('tcp://<IP_ADDRESS>:5552');
    $pull->on('message', [$pusher, 'onSignRequest'] );

    $webSock = new SecureServer(
  		new ReactServer('<IP_ADDRESS>:32000', $loop),
  		$loop,
      array(
        'local_cert'        => '/opt/bitnami/apache2/conf/server.crt', // path to your cert
        'local_pk'          => '/opt/bitnami/apache2/conf/server.key', // path to your server private key
        'allow_self_signed' => FALSE, // Allow self signed certs (should be false in production)
        'verify_peer' => FALSE
      )
  	);

    $webServer = new IoServer(
      new HttpServer(
        new WsServer(
          new WampServer(
            $pusher
          )
        )
      ),
      $webSock
    );

    $this->info('Run handle');
    $loop->run();

without any success...
please help me,
I use the certificate i found on amazon lightsail vps
Best regards

@andreadompe - please follow what I used and what SFlame suggested. I hope you will get to the solution.

@cometofsky you mean this solution
'wss://'+window.location.hostname+':8443/ws' ?
i actually don't have a domain i only have a static ip, i use this vps for test

@andreadompe - instead of binding to <IP_ADDRESS>, consider using <IP_ADDRESS>. Also make sure your ports are not occupied by other services. It may be not but worth checking - your ssl certificate folder have proper permissions.

@cometofsky if i change the address to <IP_ADDRESS>
i get this error
autobahn.min.js:62 WebSocket connection to 'wss://....:30000/' failed: Error in connection establishment: net::ERR_CONNECTION_REFUSED

These are the things you should consider mainly -

$pull->bind('tcp://<IP_ADDRESS>:5555');
new React\Socket\SecureServer($new React\Socket\Server("{ip}:{port}", $loop);, $loop, [
              'local_cert'  => {cert-path},
              'local_pk'    =>{key-path},
              'verify_peer' => FALSE,
          ])
new ab.Session(protocol + "://" + host + ":" + port, successCallback(), errorCallback(), {})
$socket->connect('tcp://<IP_ADDRESS>:5555');

Hello there, I guess i am late posting this one, but I have here a working example with routing also. the code is working well as per the latest ratchet version.
`<?php
use Ratchet\MessageComponentInterface;
use Ratchet\ConnectionInterface;
require DIR . '/vendor/autoload.php';
use Ratchet\Server\IoServer;
use Ratchet\Http\HttpServer;
use Ratchet\WebSocket\WsServer;
use Psr\Http\Message\RequestInterface;
use Ratchet\Http\Router;
use Ratchet\Http\HttpServerInterface;
use Symfony\Component\Routing\RequestContext;
use Symfony\Component\Routing\RouteCollection;
use Symfony\Component\Routing\Route;
use Symfony\Component\Routing\Matcher\UrlMatcher;
use Symfony\Component\HttpFoundation\Request;
$routes = new RouteCollection;
$loop = React\EventLoop\Factory::create();
$decorated = new WsServer(new ChatRoom);
$decorated->enableKeepAlive($loop);
$routes->add('chat-room', new Route('/chat-room', array('_controller' => $decorated), array('Origin' => $GLOBALS['Address']),
array(), $GLOBALS['Address'], array(), array('GET')));
$decorated = new WsServer(new SingleChat);
$decorated->enableKeepAlive($loop);
$routes->add('single-chat', new Route('/single-chat', array('_controller' => $decorated), array('Origin' => $GLOBALS['Address']),
array(), $GLOBALS['Address'], array(), array('GET')));
$decorated = new WsServer(new Ratchet\Server\EchoServer);
$decorated->enableKeepAlive($loop);
$routes->add('echo', new Route('/echo', array('_controller' => $decorated), array('Origin' => $GLOBALS['Address']),
array(), $GLOBALS['Address'], array(), array('GET')));
$app = new HttpServer(new Router(new UrlMatcher($routes, new RequestContext)));
$secure_websockets = new \React\Socket\Server('<IP_ADDRESS>:8091', $loop);
$secure_websockets = new \React\Socket\SecureServer($secure_websockets, $loop, [
'local_cert' => 'path/to/certificate.crt',
'local_pk' => '/path/to/your-key.key',
'verify_peer' => false
]);
$secure_websockets_server = new \Ratchet\Server\IoServer($app, $secure_websockets, $loop);
$secure_websockets_server->run();`
Regards

Dear All
I have an issue which I have posted at https://github.com/ratchetphp/Ratchet/issues/783#issue-566596974. I strongly feel that experts involved in the present discussion may give me some positive feedback on my issue. Any help is appreciated.
Thank you very much

Definitely a late post but I completed the following code with the help of @michaelphipps and its working for me. I did not replace <IP_ADDRESS> with the server IP.
`<?php
use Ratchet\Server\IoServer;
use Ratchet\Http\HttpServer;
use Ratchet\WebSocket\WsServer;
use MyApp\Chat;
require dirname(DIR) . '/vendor/autoload.php';
require_once dirname(DIR) . '/src/chat.php';
$loop = React\EventLoop\Factory::create();
$webSock = new React\Socket\Server('<IP_ADDRESS>:8088', $loop);
$webSock = new React\Socket\SecureServer($webSock, $loop, [
'local_cert' => '/etc/letsencrypt/live/mydomain.com/fullchain.pem', // path to your cert
'local_pk' => '/etc/letsencrypt/live/mydomain.com/privkey.pem', // path to your server private key
'allow_self_signed' => FALSE, // Allow self signed certs (should be false in production)
'verify_peer' => FALSE
]);
$webServer = new Ratchet\Server\IoServer(
new Ratchet\Http\HttpServer(
new Ratchet\WebSocket\WsServer(
new Chat()
)
),
$webSock, $loop
);
$webServer->run();
?>`

Well, it's only my app that using the pusher integration, and it's a requirement for running a websocket server over a secure connection (If you're still interested in the pusher integration, you should check it out http://socketo.me/docs/push - no additional installation needed).
In order to run your app over a secure connection, I think it should be as simple as that (not tested):
require dirname(__DIR__) . '/vendor/autoload.php';

use MyApp\Chat;

$loop = React\EventLoop\Factory::create();
$webSock = new React\Socket\Server('<IP_ADDRESS>:8443', $loop);
$webSock = new React\Socket\SecureServer($webSock, $loop, [
    'local_cert'        => 'C:/xampp/apache/conf/ssl.crt/server.crt', // path to your cert
    'local_pk'          => 'C:/xampp/apache/conf/ssl.key/server.key', // path to your server private key
    'allow_self_signed' => TRUE, // Allow self signed certs (should be false in production)
    'verify_peer' => FALSE
]);

$webServer = new Ratchet\Server\IoServer(
    new Ratchet\Http\HttpServer(
        new Ratchet\WebSocket\WsServer(
            new Chat()
        )
    ),
    $webSock
);

$webServer->run();

@darylwilliams update me if it worked for you.

what does the correct key and cert look like? I have three keys and three certs in my ssl folder and i know which one belongs to which however how do i know which one to use? Also should i be stripping them of any extra additional text like '-----begin"?

Well, it's only my app that using the pusher integration, and it's a requirement for running a websocket server over a secure connection (If you're still interested in the pusher integration, you should check it out http://socketo.me/docs/push - no additional installation needed).
In order to run your app over a secure connection, I think it should be as simple as that (not tested):
require dirname(__DIR__) . '/vendor/autoload.php';

use MyApp\Chat;

$loop = React\EventLoop\Factory::create();
$webSock = new React\Socket\Server('<IP_ADDRESS>:8443', $loop);
$webSock = new React\Socket\SecureServer($webSock, $loop, [
    'local_cert'        => 'C:/xampp/apache/conf/ssl.crt/server.crt', // path to your cert
    'local_pk'          => 'C:/xampp/apache/conf/ssl.key/server.key', // path to your server private key
    'allow_self_signed' => TRUE, // Allow self signed certs (should be false in production)
    'verify_peer' => FALSE
]);

$webServer = new Ratchet\Server\IoServer(
    new Ratchet\Http\HttpServer(
        new Ratchet\WebSocket\WsServer(
            new Chat()
        )
    ),
    $webSock
);

$webServer->run();

@ghost update me if it worked for you.

what does the correct key and cert look like? I have three keys and three certs in my ssl folder and i know which one belongs to which however how do i know which one to use? Also should i be stripping them of any extra additional text like '-----begin"?

Quick answer is they are the same certs you would use if you set up apache with SSL.  Let me know if that answer is too vague and I will give more details.

Hi everyone, thanks a lot for the comments!
I put the pieces of the puzzle together and wrote these posts which I hope will be helpful too.

A Simple Example of SSL/TLS WebSocket With ReactPHP and Ratchet
Creating a Local WebSocket Server With TLS/SSL Is Easy as Pie

Hi @programarivm
In reference to the first article link you have posted, In the newer version of ReactPHP you can simplify the SecureServer like this:
<?php

namespace ChessServer;

use ChessServer\Socket;
use Ratchet\Http\HttpServer;
use Ratchet\Server\IoServer;
use Ratchet\WebSocket\WsServer;
use React\Socket\Server;

require __DIR__  . '/../vendor/autoload.php';

$secureServer = new React\Socket\Server('tls://<IP_ADDRESS>:8443', null, [
    "tls"=>[
        'local_cert'  => __DIR__  . '/../ssl/certificate.crt',
        'local_pk' => __DIR__  . '/../ssl/private.key',
        'verify_peer' => FALSE
    ]
]);

$httpServer = new HttpServer(
    new WsServer(
        new Socket()
    )
);

$ioServer = new IoServer($httpServer, $secureServer);

@clue says that verify_peer shouldn't be needed because it defaults to FALSE, but I've found that I need to explicitly state it.

Thank you @michaelphipps
I just realized that Google Chrome can't connect to the WSS server if verify_peer if set to false even with a certificate issued by a trusted CA, but it does work with Firefox.
verify_peer is been set to true and my WSS server works on all browsers now.
namespace ChessServer;

use ChessServer\Socket;
use Ratchet\Http\HttpServer;
use Ratchet\Server\IoServer;
use Ratchet\WebSocket\WsServer;
use React\EventLoop\Factory;
use React\Socket\Server;
use React\Socket\SecureServer;

require __DIR__  . '/../vendor/autoload.php';

$loop = Factory::create();

$server = new Server('<IP_ADDRESS>:8443', $loop);

$secureServer = new SecureServer($server, $loop, [
    'local_cert'  => __DIR__  . '/../ssl/certificate.crt',
    'local_pk' => __DIR__  . '/../ssl/private.key',
    'verify_peer' => false,
]);

$httpServer = new HttpServer(
    new WsServer(
        new Socket()
    )
);

$ioServer = new IoServer($httpServer, $secureServer, $loop);

$ioServer->run();


Require pagination in list API endpoints + Console API docs clean up

Added pagination parameters requirements
Added info tips to communicate parameters requirements will be effective from July 1st 2024
Moved OpenAPI data to JSON file to ease of preview with editor tools and parsing.
Restyled the content page:

Styled warning for console key
Update overview header
Hide info section of rapi which repeats the same title. We dont have version also.
Hide api summary since we use rapi for list of functions already.

Example cleaned up Content (Please look at Production for differences):

Example Pagination Requirement:

Extracted to JSON for OpenAPI and take advantage of live Preview from extension:

#1551  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @anle-statsig and the rest of your teammates on  Graphite

Graphite messed up my change. Redo it here https://app.graphite.dev/github/pr/statsig-io/docs/1559/Docs-Require-pagination-in-list-API-endpoints-Clean-up-Console-API-layout


Direct links for examples on app.rerun.io

I often want to include a link to a specific example on app.rerun.io on social media or in user conversations. Since that is not possible right now I am linking to app.rerun.io and then have to add an explanation on how to find the right example. This feels cumbersome and is likely costing us traffic.

https://github.com/rerun-io/rerun/pull/4165 will add a command to copy a direct link to the fully qualified URL of an example, so you will:

Open app.rerun.io
Navigate to the example you want to point people to
Open the command palette (CTRL+P / CMD+P)
Run the "Copy direct link" command


nsh: Accept the command line arguments like sh

Summary
See the dissussion here: https://github.com/apache/incubator-nuttx/pull/1597
Impact
Testing
Please ignore the false nxstyle alarm:
nshlib/nsh_timcmds.c:115:35: error: Multiple data definitions

@patacongo @v01d @davids5 could you review this patch which is paired with https://github.com/apache/incubator-nuttx/pull/1597? so user can let nsh exit after the initialization finish by:
CONFIG_INIT_ARGS="\"-c\", \"exit\""

I'm not that familiar with this part of NuttX but I couldn't find anything that caught my attention.
I'm curious, how do you manage nsh to exit? I'm assuming nsh starts some other task via init script, which
you fork, otherwise it this child task would also exit once nsh exits.
In that case, wouldn't be simpler to just add an "exit" at the end? Also, it is typical to end this kind of scripts with an exec()
call so that the calling process (nsh) is replaced by your second task. Not sure if that works in NuttX though.
Anyway, this PR is more general than that, so I agree with the change and aligns with your previous PR.

I'm not that familiar with this part of NuttX but I couldn't find anything that caught my attention.
I'm curious, how do you manage nsh to exit? I'm assuming nsh starts some other task via init script, which
you fork, otherwise it this child task would also exit once nsh exits.

Yes, we have many services which is started by init.d/rcS run on the background.

In that case, wouldn't be simpler to just add an "exit" at the end? Also, it is typical to end this kind of scripts with an exec()
call so that the calling process (nsh) is replaced by your second task. Not sure if that works in NuttX though.

Yes, adding 'exit' at the end of init.d/rcS should work, but we want to control the behaviour through defconfig since developers are more familiar to modify defconfig than init.d/rcS. And this also make nsh align with sh's behaviour.

Anyway, this PR is more general than that, so I agree with the change and aligns with your previous PR.

@xiaoxiang781216 - I would like to test this and the sister PR. But I need some time. I am fixing other breakage in kinetis at the moment.

Here is my test(sim:nsh), the behaviour is good:
xiaoxiang@DESKTOP-JH2VEP6:~/nuttx/nuttx$ ./nuttx
nsh: mkrd: command not found
login: admin
password:
User Logged-in!

NuttShell (NSH) NuttX-9.1.0
MOTD: username=admin password=Administrator
nsh> poweroff

Could you set breakpoint in fopen? so I can see the context when the error happen, or try on sim:nsh.

This was a complicated debug, it was the last open on nested scripts.....

The info you asked for is above.
I believe this is wrong https://github.com/apache/incubator-nuttx-apps/pull/367/files#diff-1037d1ad14b4ee447c6ca07d40ccb9f7R131

I have no clue why you do not  see it on the sim.

@xiaoxiang781216 this is the problem the PR apache/incubator-nuttx#1597 did not do what @patacongo asked for with CONFIG_INIT_ARGS
from config.h
#define CONFIG_INIT_ARGS ""

But I am different from yours, here is nsh arguments:

and include/nuttx/config.h:

Yes, .config contain the empty string:

But mkconfig will remove the empty string macro, do you have this line:
https://github.com/apache/incubator-nuttx/blob/master/tools/cfgdefine.c#L69

@xiaoxiang781216 - yes I have it,
Sorry, the problem was old version of mkconfig binary in my tools dir. I need to fix the out of tree build on our side.


Errors#merge! breaks with autosave associations

Hi,
I have a Post object that has_one :schedule with accepts_nested_attributes_for :schedule as well. The latter method sets autosave: true, which unfortunately has the effect of hoisting up errors into the parent object so that the errors object on Post looks like this:
(byebug) post.errors.details
{:"schedule.publish_at"=>[{:error=>:blank}]}

The naughty pseudo-attribute name with the dot in it breaks Active Interaction's errors.merge!(post.errors), resulting in the stracktrace below.
Any idea on the best way to resolve this if I want to keep autosave enabled?
Failure/Error: errors.merge!(post.errors)

NoMethodError:
  super: no superclass method `schedule.publish_at' for #<Post:0x0055bcbe0fe058>
  Did you mean?  scheduled_for_publication?
  Did you mean?  scheduled_for_publication?
# /home/andrew/.rbenv/versions/2.4.1/lib/ruby/gems/2.4.0/gems/activemodel-5.0.3/lib/active_model/attribute_methods.rb:433:in `method_missing'
# /home/andrew/.rbenv/versions/2.4.1/lib/ruby/gems/2.4.0/gems/enumerize-2.1.2/lib/enumerize/base.rb:61:in `read_attribute_for_validation'
# /home/andrew/.rbenv/versions/2.4.1/lib/ruby/gems/2.4.0/gems/activemodel-5.0.3/lib/active_model/errors.rb:494:in `generate_message'
# /home/andrew/.rbenv/versions/2.4.1/lib/ruby/gems/2.4.0/gems/active_interaction-3.5.2/lib/active_interaction/errors.rb:145:in `translate'
# /home/andrew/.rbenv/versions/2.4.1/lib/ruby/gems/2.4.0/gems/active_interaction-3.5.2/lib/active_interaction/errors.rb:132:in `merge_detail!'
# /home/andrew/.rbenv/versions/2.4.1/lib/ruby/gems/2.4.0/gems/active_interaction-3.5.2/lib/active_interaction/errors.rb:123:in `block (2 levels) in merge_details!'
# /home/andrew/.rbenv/versions/2.4.1/lib/ruby/gems/2.4.0/gems/active_interaction-3.5.2/lib/active_interaction/errors.rb:119:in `each'
# /home/andrew/.rbenv/versions/2.4.1/lib/ruby/gems/2.4.0/gems/active_interaction-3.5.2/lib/active_interaction/errors.rb:119:in `block in merge_details!'
# /home/andrew/.rbenv/versions/2.4.1/lib/ruby/gems/2.4.0/gems/active_interaction-3.5.2/lib/active_interaction/errors.rb:118:in `each'
# /home/andrew/.rbenv/versions/2.4.1/lib/ruby/gems/2.4.0/gems/active_interaction-3.5.2/lib/active_interaction/errors.rb:118:in `merge_details!'
# /home/andrew/.rbenv/versions/2.4.1/lib/ruby/gems/2.4.0/gems/active_interaction-3.5.2/lib/active_interaction/errors.rb:95:in `merge!'
# ./app/interactions/admin/posts/create.rb:33:in `execute'

Based on the stack trace it looks like the issue is coming from generate_message inside of ActiveModel. I tried it on a local Rails app I have and generate_message failed to properly handle the nested error. I think this might be an issue for Rails.

That is a good point. The Rails side doesn't support any handling of these nested attribute names in the error yet it generates them from somewhere. I'll have a look further at the Rails side but won't realistically be able to until September, so I'll close this ticket for now. Thanks!

I had to use something like this:
      occupancy.errors.messages.each do |column, messages|
          messages.each { |m| errors.add(column, m) }
      end


Collapsed nodes in the shader graph

Mac OSX El Capitan - Godot 2.1 RC.
When deleting a node in shader graph, with other nodes selected all selected nodes are "collapsed" at the mouse position.
To reproduce:

Open a shader graph with some nodes
Select some of them (sometimes they are automatically selected)
Delete one node (clicking on x)
Move the mouse -> all selected nodes are collapsed. (if you double click when deleting this does not happen)

CC @MarianoGnu.

Not critical for the upcoming 2.1, so moving to the next milestone (though an early fix would of course be very welcome).

The visual shader editor was removed (temporarily) from 3.0, and will be readded in 3.1. Since the code will be different, assuming this issue won't apply anymore (if it does, please open a new issue about it or comment here).


filtering-stack-trace

add "ThrowableFormat.Filter" with options to NoFilter" and "Excluding"
add test for "Filter"
add example

I suppose, I need to add scala-2.12 compatibility)


Can't support color words's display(My english is poor )_)  )

as the pictures shows, the color words can't show Color dot in the front.

Duplicate of https://github.com/ggordan/GutterColor/issues/16


a11y black and white terminal css template

deppends on https://github.com/E-xyza/ex_term/issues/8

completed in e05cf48


Ignore segments feature proposal

First of all, thank you for your great library :)
I have some GPX files with several segments (<trkseg></trkseg> tags), which results in several start and end icons being displayed on the map, and gaps in the displayed track.
Would it make sense to add an option that would only show one track, and with only one start icon (the start point of the first track segment) and one end icon on the map (the end point of the last track segment)? This option could be called like ignoreSegments (with the false value by default).
If you think this is overkill, feel free to close this issue, and I will edit my GPX files instead.
To the contrary, if you think that could be an interesting feature, I can open a PR implementing it.

Closing as duplicate of https://github.com/mpetazzoni/leaflet-gpx/issues/123


[Semaphore SDK] Issue 2: Create Code of Conducts Template and Contributing file for Semaphorse SDK

To foster a welcoming and inclusive environment, the Semaphore SDK needs a Code of Conduct and a comprehensive Contributing file. These documents will ensure that contributors understand the expectations for participation and the processes for making contributions.

I would love to work on this issue

Could I take on this issue?

May I pick this up?

Hi, I'm Josué, and I'm part of the Dojo Coding community. I have experience in programming languages such as Angular, React, C#, .NET, C++, PHP, Python, Java, Node.js, and JavaScript, among others. I'm passionate about software development and enjoy contributing to open-source projects, applying my knowledge to solve problems in a practical way. Additionally, I’m working on the project Citizen Of Arcanis, where I’ve had to use Unity, so I’m also skilled with this tool.
First, I will create a Code of Conduct using the Contributor Covenant as a foundation, highlighting respect and inclusion. Then, I'll make a Contribution file with clear steps to report issues, propose ideas, and submit pull requests. Finally, I will add both documents to the repository and link them in the README for everyone to see easily.

I'd like to handle this task.

I’d like to help with this.

May I pick this up?

Hello can i be assigned this issue, i am a new contributor and i  would love to work on this , my ETA is >12 Hours and ill create a draft PR in 10 hours time. Thank you for this opportunity. :)

Could I take a shot at this? I would love to help you develop a clear Code of Conduct to make it easy for contributors to know exactly what to do when working on your project. As a contributor to other projects, I understand what a good contributing file should look like.

Let me try this one!

Hello can I be assigned this please? I am a blockchain developer and I'm also good at documentations. I'll provide code of conducts documentation and a comprehensive contributing file.
Below are some of the documentations I've done that were merged:
https://github.com/dojoengine/book/pull/308,
https://github.com/keep-starknet-strange/joyboy/pull/143,
https://github.com/Scaffold-Stark/ss2-docs/pull/31,
https://github.com/horuslabsio/Starknet-Scaffold/pull/94,
https://github.com/Hyle-org/examples/pull/15,
Please I’m ready to work, assign me please.

Is it okay if I tackle this?

hey sir I'd like to handle this task.
i'm a frontend developer and a blockchain dev
i would really love to contribute to your project
please kindly assign :)

Am a frontend dev and an experienced technical writer. Can I take this from here?

hey sir I'd like to handle this task.
i'm a frontend developer and a blockchain dev
i would really love to contribute to your project
please kindly assign :)

Hello! My name is t0fudev and I'm currently a computer science student. I'm fully confident on tackling this issue successfully since I've worked before on this type of documentation. Also, I had contributed on this fantastic project on the last OD Hack.
I'm looking forward to continue contributing to this awesome project.
Best rewards!
ETA: 1 day


Fix : Issue 101

Related Issue

Fixes #101  .

Proposed Changes

Instead of passing multiple fields pass the Product model object (data being saved in the constructor.

Checklist

[x] Tested
[x] No Conflicts
[x] Change In Code
[ ] Change In Documentation

Screenshots

PR
ScreenShot

Before PR

After PR

hey, @himanshusharma89  kindly take a look into it, any suggestion If I can achieve this in some better way or is it cool?


Table: Horizontal scrollbar appears after resizing column and shrinking table

Describe the bug (actual behavior)
Resize the column and then shrink the table. A horizontal scrollbar appears and columns move out of view. Without resizing column, everything works fine.
Expected behavior
After resizing the column and then shrinking the table, horizontal scroll bar should not appear. Columns should shrink.
Steps to reproduce

Resize any column
Shrink table

Has any work started on this? Is there any work item in the backlog linked with this issue?

Hi @GintV, the work has not been started yet.

Hey @medikornov & @GintV, we spent some time looking into this and have determined that this is indeed working as was intended.  We're not considering this a regression because v1.38.1 didn't have full support for horizontal scrolling.  However we do see & understand the need for the option you are detailing.  When we rework our table in the next major version (expected in 2nd half of 2023), we'll look into offering an option to allow toggling either behavior and/or have "smart" detection that takes window resizing into account.

@FlyersPh9 Got it. If you're not considering this as a bug, can't this be converted to a feature? Or you already created a feature item for that in GitHub?

@GintV Yes, we had it as a backlog item that wasn't visible to non-team members.  I've changed it to an issue so it's visible to everyone now: #1144


Error while setting up platform directv

Make sure you are running the latest version of Home Assistant before reporting an issue.
You should only file an issue if you found a bug. Feature and enhancement requests should go in the Feature Requests section of our community forum:
Home Assistant release (hass --version):
0.51.2
Python release (python3 --version):
using homeassistant/home-assistant:0.51.2
Component/platform:
media_player
Description of problem:
After upgrading to 0.51.2 I'm seeing the following in the logs:
2017-08-15 21:47:12 ERROR (MainThread) [homeassistant.components.media_player] Error while setting up platform directv
Traceback (most recent call last):
  File "/usr/src/app/homeassistant/helpers/entity_component.py", line 164, in _async_setup_platform
    SLOW_SETUP_MAX_WAIT, loop=self.hass.loop)
  File "/usr/local/lib/python3.6/asyncio/tasks.py", line 358, in wait_for
    return fut.result()
  File "/usr/local/lib/python3.6/asyncio/futures.py", line 245, in result
    raise self._exception
  File "/usr/local/lib/python3.6/concurrent/futures/thread.py", line 55, in run
    result = self.fn(*self.args, **self.kwargs)
  File "/usr/src/app/homeassistant/components/media_player/directv.py", line 62, in setup_platform
    dtvs.append(DirecTvDevice(*host))
TypeError: __init__() missing 1 required positional argument: 'device'

I do not use the media_player component (it seems that discovery was finding them).  When I disabled the discovery component, I no longer saw those errors.
Expected:
No error.
Problem-relevant configuration.yaml entries and steps to reproduce:
n/a
Traceback (if applicable):
n/a
Additional info:

+1.  Same issue and same exact error as above.  I'm not using docker though.  I'm running natively on Mac OS Sierra 10.12.6.
hass --version
0.51.2
python3 --version
Python 3.6.2
2017-08-25 19:25:31 ERROR (MainThread) [homeassistant.components.media_player] Error while setting up platform directv
Traceback (most recent call last):
  File "/usr/local/lib/python3.6/site-packages/homeassistant/helpers/entity_component.py", line 164, in _async_setup_platform
    SLOW_SETUP_MAX_WAIT, loop=self.hass.loop)
  File "/usr/local/Cellar/python3/3.6.2/Frameworks/Python.framework/Versions/3.6/lib/python3.6/asyncio/tasks.py", line 358, in wait_for
    return fut.result()
  File "/usr/local/Cellar/python3/3.6.2/Frameworks/Python.framework/Versions/3.6/lib/python3.6/asyncio/futures.py", line 245, in result
    raise self._exception
  File "/usr/local/Cellar/python3/3.6.2/Frameworks/Python.framework/Versions/3.6/lib/python3.6/concurrent/futures/thread.py", line 55, in run
    result = self.fn(*self.args, **self.kwargs)
  File "/usr/local/lib/python3.6/site-packages/homeassistant/components/media_player/directv.py", line 62, in setup_platform
    dtvs.append(DirecTvDevice(*host))
TypeError: __init__() missing 1 required positional argument: 'device'

@chriskacerguis I appear to have resolved this.  I disabled discovery in HA and then manually added the HR54/200 as below:
media_player:
  - platform: directv
    host: <IP_ADDRESS>
    port: 8080
    name: dtv_living
    device: 0

This led to a different error that was resolved by this comment in an already closed issue:  https://github.com/home-assistant/home-assistant/issues/2876#issuecomment-270480085.
Hope this resolves for you as well.

@jmery thanks, I appreciate your follow up :)
That said, I never had (or wanted) to setup DirecTV so while that's a great workaround, it doesn't resolve the core issue that is HASS auto-detecting it and failing out.

@chriskacerguis True.  I literally started with HA for the first time ever yesterday so I'm still learning :-).
There was a recent PR on the DirectPy.py project to add some error checking.  That's what needs to be done here as well.  Without the setting I linked above, the API to the /tv/getTuned?clientAddr=%s returns a 403.
Some code needs to be added to catch that and move along.
@firstof9 -
I saw you submitted the PR for the other issue on DirectPy.py. This looks very, very similar.  Would you have the cycles to add a similar fix here?  I've got zero python experience.  Here's a link to the specific function that needs the fix: https://github.com/sentry07/DirectPy/blob/master/DirectPy.py#L71-L74

I think @fabaff and @sielicki could provide some assistance in this.

I've submitted PR #5 for the get_tuned function as pointed out @jmery.

Yeah, the fix is in this commit in #8800, been sitting for over 3 weeks.

Perhaps @pvizeli can assist with getting some traction on #8800


Put isForum in ChatTypeSupergroup chat

It would be useful to check if a chat is a forum directly without request to a cache with supergroup IDs to improve performance when loading lists

is_forum can be changed any time, so it isn't part of the chat's type. It can be added only with the updateChatType update, which sounds a bit strange.
While it is true that this looks like the only reason to fetch the supergroup object from cache while showing chat list, I don't think that the change will result in any reasonable performance improvements.

Hi


Create a model board esp32-wroom to test without wifi interface

_No description provided.
where is the description? xD


Implement (weighted) interval score

References:

Gneiting T, Raftery AE. Strictly proper scoring rules, prediction, and estimation. J Am Stat Assoc. 2007;102(477):359–378
Bracher J, Ray EL, Gneiting T, Reich NG (2022) Correction: Evaluating epidemic forecasts in an interval format. PLOS Computational Biology 18(10): e1010592

Then let's continue with this one: Question about the API: do we want a forecast array that is (n x 2 x a) where alpha is the length of the $\alpha$ vector or do we want to have upper and lower parameters? Or both?
I was thinking about somehting like this:
def winkler(obs, lower, upper, alpha, backend=None):
    """Winkler or Interval Score for prediction interval PI[lower, upper] and observations."""
    B = backends.active if backend is None else backends[backend]
    width = upper - lower
    inside = (obs[:, None] >= lower) & (obs[:, None] <= upper)
    above = (obs[:, None] > upper)
    below = (obs[:, None] < lower)
    W = (
        below * width + (2 / alpha) * (lower - obs[:, None]) +
        inside * width +
        above * width + (2 / alpha) * (obs[:, None] - upper)
    )
    return B.mean(W, axis=-1)

I'd call it interval_score since it's based on intervals :smile:, and then mention Winkler in the docs.
About the API...good question. I worked a bit on this a while a go but wasn't sure about the best way to go. If I remember correctly, I had something like lower = (n, a), upper=(n, a) and alpha=(a,). That's a good solution for now.
My idea was to also have an additional keyword argument for the weights given to each interval.

There are probably more scoring functions for PIs than the Winkler Score only 😅 your call though :)
All right, then I'll go with the upper, lower, alpha and weights and will implement a first draft 👍🏽

There are probably more scoring functions for PIs than the Winkler Score only 😅 your call though :)

You are right, but as far as I know it's by far the most popular denomination in the literature. I've rarely seen "Winkler score" alone but more commonly "Winkler interval score" or similar so we could go with that (interval_score_winkler, interval_score_xxx, etc.) :slightly_smiling_face:  What's important for me is that we also include "interval score" in the function name because it's sort of self-explanatory for users. What do you think?


Build breaks on FreeBSD

This line and another one like this causes this failure:
ld: error: undefined symbol: environ
>>> referenced by hpx_init.cpp
>>>               hpx_init.cpp.o:(hpx::detail::init_impl(hpx::function<int (hpx::program_options::variables_map&), false> const&, int, char**, hpx::init_params const&, char const*)) in archive lib/libhpx_init_runtime.a
>>> referenced by hpx_init.cpp
>>>               hpx_init.cpp.o:(hpx::detail::start_impl(hpx::function<int (hpx::program_options::variables_map&), false> const&, int, char**, hpx::init_params const&, char const*)) in archive lib/libhpx_init_runtime.a

Specifications

HPX Version: 1.9.1
Platform (compiler, OS): clang-15, FreeBSD 13.2

Thanks, this finally explains the issues you were reporting. I think this is an easy fix.


Installing through homebrew fails

Version of Archi, Operating System
None, Mac OS Mojave
Expected Behaviour
Homebrew should install when running brew cask install archi
Actual Behaviour
The install fails with a 404 error:
==> Downloading https://www.archimatetool.com/downloads/460/Archi-Mac-4.6.0.zip

curl: (22) The requested URL returned error: 404
Error: Download failed on Cask 'archi' with message: Download failed: https://www.archimatetool.com/downloads/460/Archi-Mac-4.6.0.zip

Download link should be https://www.archimatetool.com/downloads/20191111/Archi-Mac-4.6.0.zip
Steps to Reproduce the Behaviour

brew cask install archi

I've checked the documentation over at the homebrew repo: https://github.com/Homebrew/homebrew-cask/blob/master/doc/reporting_bugs/curl_error.md and thus ended up here :).

Not an Archi issue. Please take this up with them.


Names associated to sender and recipients emails are not displayed + email size is appended to sender text.

Hi,
I get these display issues:

Name of sender and recipients are not displayed, i.e. "Test Name<EMAIL_ADDRESS>is only displayed as<EMAIL_ADDRESS>The size of the message is appended to the "from" text, as you can see on the picture.

The emails that are sent via normal SMTP server are OK. I don't use mailcatcher directly but via https://github.com/jgiannuzzi/docker-mailcatcher, but this is just dockerizing mailcatcher and I don't see how it could be responsible for these issues.
Cheers,
Adrien

Correct, the From and To at the top of the screen are the SMTP sender and recipient which usually do not contain names, but do reflect how the message would be routed. The mail message body may have To and From headers which usually do have names, and usually have matching addresses, and they will be displayed in the bottom part.

OK, I won't discuss about that :-)
But what about the size information which is appended to the From address?

That I can’t account for, maybe a bug in your client? Can you provide a message which replicates the issue?

Hi there, awesome software!
I know this is a two-part issue, but on the first part (displaying the sender name), I also think it would be very useful/sensible to display it if possible. The reason being, it wouldn't detract from current use, but it would also give the developer a better idea of how their users will experience the email in the context of using their website/software.
To highlight why this is important, certain software (e.g. rails) doesn't use a gsuite/google workspace sender name, but instead overrides it with a title case version of the part of the email before the @. Which is kinda weird, but it necessitates the developer looking at how to change that default name and it would be great to be able to test locally using mailcatcher :)

SIZE=XXXXX in the "from" field happens for us as well, via MailKit as the client. From my incredibly limited understanding of SMTP and MailKit's codebase, I believe it's following RFC1870's size declaration, and is detecting something on Mailcatcher's end which makes it believe that it accepts and understands the size extension.

Thanks @jeremyZX, I've been able to replicate 👍

Actually let's open a separate issue


chore(release): 2.20.0

Version bump in package.json and package-lock.json for release 2.20.0

:tada: This PR is included in version 2.20.1 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


change to use non-deprecated header

Looks like it was missed in this pr or has since regressed: https://github.com/ros-visualization/rviz/pull/1217

Turns out it was missed by the auto-PR because of the # include format

Looks like it was missed in this pr

Yeah, as mentionned to @dhood  offline, I didnt account for whitespaces when writing my search replace script :/. The last released version of pluginlib should not throw the warning anymore so there shouldnt be any rush releasing this


Auth Oddities / Vulnerabilities

There's a (minor?) security issue and a few oddities I noticed with the way auth is being handled.
OAuth Callback Auth Session Vulnerability
The action in oauth.callback.tsx accepts a form data encoded AuthSession from the client and trusts its contents. Consequently, you can submit a real email with a fake access token etc. and side effects will be triggered.
If an account exists for the email, the server will commit (sign) the bogus auth session data and store it in a cookie used for future requests. If a user doesn't exist for the email, one will be created and we'll also end up with bogus auth session cookie as above.
Whilst not great, this is fairly safe at present since requireAuthSession() is being used on endpoints, and it calls through to verifyAuthSession(), and consequently it'll catch the bad access token. That does assume APIs are calling through to verifyAuthSession(). However, that leads into another concern, which is admittedly more of a query.
Why create our own auth session cookie at all?
The Supabase JS library is already creating its own sb-access-token cookie which contains all the same data. The main difference is it's created/verifiable with the Supabase instance's JWT secret key. Thus, in order to validate the token we need do one of:

Perform a round trip to Supabase as verifyAuthSession() does.
Grab the JWT secret from the Supabase dashboard and add it as a server-only environment variable. Then we can then validate the JWTs directly on our server without the round trip.

I guess the advantage of our own session cookie is that we can validate it ourselves on the server without needing to grab the Supabase JWT secret and save on a round trip i.e. we can trust its contents. However, we're not doing that, we are performing round trips via requireAuthSession(). Just as well because of the aforementioned OAuth Callback vulnerability. However, it does make the contents of the cookie redundant, since we can't trust the contents without verifying the access token, and in doing so, we're fetching the same data that's found in the cookie anyway.
Email Addresses as Unique Keys
Email addresses are being used as unique keys. This stack doesn't claim to support oauth beyond magic links, so it's fine. However, this approach becomes problematic when integrating social OAuth - which is what I was doing when I discovered all the above. Basically, users can change the email address associated with their OAuth provider. Say for example someone signs up via Github social auth whilst their email is<EMAIL_ADDRESS>If they proceed to change their primary email on Github to<EMAIL_ADDRESS>when that user returns to a site built on this stack and attempts to authenticate, no account will be found.
Again, the stack doesn't claim to support social auth, so it's by no means a bug. However, that part of the auth design could probably be shored up a bit to make it more robust/extensible.
Thank you
After me ranting about problems, just wanted to say thanks for all the hard work! Despite the above, this is my first time using Remix and this repo is, at the very least, super informative.

Actually I think this may infact be quite severe. requireAuthSession does not validate the auth session matches the access token. It simply verifies that the access token is a valid access token.
So to impersonate someone else you can submit an auth session with a valid access token for your own account, but with the other users email.

Hello,
First, thanks for your review, I really appreciate it.

The action in oauth.callback.tsx accepts a form data encoded AuthSession from the client and trusts its contents. Consequently, you can submit a real email with a fake access token etc. and side effects will be triggered.

You are absolutely right, I miss the first rule: never trust user input.
I'll work on a fix asap, using verifyAuthSession to challenge the access token and compare the session it returns with the session received in formData.

Why create our own auth session cookie at all?

Maybe I'm wrong, but in previous work, we face this issue: https://github.com/mitchelvanbever/remix-auth-supabase/issues/15
Supabase tokens are really huge with some 3rd party providers (Twitch for example). So, to prevent cookie overflow, I choose to pick only what "I" need (the benefit of a Remix Stack is that you can customize It to add or remove what you want in mapAuthSession).
In the end, it seems that I do almost the same thing as Supabase.
When looking at the code, it seems that they don't check what's in the request too 🤔
But again, you are right, there is an issue with oauth.callback and I'll work on a fix.

Email Addresses as Unique Keys
Funny, It's what happens to me with the Supabase dashboard itself.
Even with a new email, I didn't lose my account.

Supabase seems to work differently. In its private table auth.identities the primary key is not the email but an id provided by the social Oauth provider (at least for GitHub).

Again, I can be wrong.
It's hard to test (don't want to change my email 🤭)

Actually I think this may infact be quite severe. requireAuthSession does not validate the auth session matches the access token. It simply verifies that the access token is a valid access token.

If someone hacks this and set a stolen access token in our secure session cookie, we are roasted but I don't know if we can do something to prevent that.
It's a common issue when a user has his token stolen. (and easy in a public wifi)
But I guess you still speak about oauth.callback for this?
Currently, outside of oauth.callback, we can trust requireAuthSession.
If secure session cookies are compromised, it'll be a major world problem 😅.
It cost nothing to me to add a double check in requireAuthSession > verifyAuthSession:  always be sure that we store/use the email and userId associated with the access token.
Maybe I'll end to remove email and userId from the session cookie and provide these values on the fly in requireAuthSession. In the end, It's useless to store that because we always call verifyAuthSession that returns supabase user (with email and userId associated with the access token) 🧐
PS:  Why I don't grab the JWT secret to check the access token is because I think it's Supabase's business and I want a "fresh" "user" from supabase auth api to be able to check various things, like if it's banned, if it has a verified email, etc.
When I'll have a PR, would you like to review it ?
Thank you again for the time you take to write your comment, and forgive me if my English is approximative 😇

Thanks, fixed here: https://github.com/rphlmr/supa-fly-stack/pull/46


CI: Perl test hang after segfault in t/test_multi_device_exec.t

[2020-04-27T02:17:39.397Z] t/test_multi_device_exec.t ..

[2020-04-27T02:17:39.397Z] 1..10

[2020-04-27T02:17:39.397Z] ok 1

[2020-04-27T02:17:39.397Z] ok 2

[2020-04-27T02:17:39.397Z] ok 3

[2020-04-27T02:17:39.397Z] ok 4

[2020-04-27T02:17:39.397Z] ok 5

[2020-04-27T02:17:39.397Z] ok 6

[2020-04-27T02:17:39.397Z] ok 7

[2020-04-27T02:17:39.397Z] ok 8

[2020-04-27T02:17:39.397Z] ok 9

[2020-04-27T02:17:39.397Z] ok 10

[2020-04-27T02:17:39.397Z] ok

[2020-04-27T02:17:40.320Z]

[2020-04-27T02:17:40.320Z] Segmentation fault: 11

[2020-04-27T02:17:40.320Z]

[2020-04-27T06:14:50.181Z] Sending interrupt signal to process

[2020-04-27T06:14:54.754Z] 2020-04-27 06:14:50,209 - root - WARNING - Signal 15 received, cleaning up...

[2020-04-27T06:14:54.754Z] 2020-04-27 06:14:50,209 - root - WARNING - Cleaning up containers

[2020-04-27T06:14:54.754Z] 2020-04-27 06:14:53,647 - root - INFO - ☠: stopped container 9f83fbfb8698

[2020-04-27T06:14:54.754Z] 2020-04-27 06:14:53,654 - root - INFO - 🚽: removed container 9f83fbfb8698

[2020-04-27T06:14:54.754Z] 2020-04-27 06:14:53,655 - root - INFO - Cleaning up containers finished.

[2020-04-27T06:14:54.754Z] 2020-04-27 06:14:53,655 - root - WARNING - done. Exiting with error.

[2020-04-27T06:14:54.757Z] script returned exit code 1

http://jenkins.mxnet-ci.amazon-ml.com/blue/organizations/jenkins/mxnet-validation%2Funix-cpu/detail/master/1880/pipeline/373

http://jenkins.mxnet-ci.amazon-ml.com/blue/organizations/jenkins/mxnet-validation%2Funix-cpu/detail/PR-18146/49/pipeline/373


Added support for a Pandas DataFrame OutputParser

Description: Added support for a Pandas DataFrame OutputParser with format instructions, along with unit tests and a demo notebook.
Issue: https://github.com/langchain-ai/langchain/issues/11532
Dependencies: No additional dependencies :)
Tag maintainer: @baskaryan
Twitter handle: No need. :)

Hi @hwchase17, we noticed you reviewed the XML output parser, would you lend us your expertise and review this PR too please?

@baskaryan Updated the PR description to include a lot more detail on what was implemented. This PR is ready for review. It is our first PR on a public repo, so it is possible that this code is not ready to be immediately merged into LangChain. I highly encourage feedback and am happy to add more details/make more changes to get this merged in!


🏗 clarify structure of cli controller

Generated summary (powered by Graphite)

TL;DR
This pull request refactors the project structure by moving the main application logic to a new cli module under the controller package. It also updates the pyproject.toml file to reflect this change and modifies the test cases to use the new module path.
What changed

The pyrb.controller:app script in pyproject.toml has been updated to pyrb.controller.cli.main:app.
The controller.py file has been moved to controller/cli/main.py.
All the test cases in test_controller.py have been updated to import app from pyrb.controller.cli.main instead of pyrb.controller.
The create_rebalance_context function is now being mocked from pyrb.controller.cli.main instead of pyrb.controller in the test cases.

How to test

Pull the changes from this branch to your local environment.
Run the test suite using the command pytest.
Ensure all tests pass without any errors.
Run the application using the command specified in pyproject.toml and ensure it works as expected.

Why make this change
This change improves the project structure by separating the command-line interface (CLI) logic from the main application logic. This makes the codebase easier to navigate and maintain. It also allows for potential expansion of the application, as additional modules can be added under the controller package if needed in the future.

Current dependencies on/for this PR:

main

PR #39   👈

This stack of pull requests is managed by Graphite.

Merge activity

Nov 11, 1:29 PM: @mingi3314 started a stack merge that includes this pull request via Graphite.


Doc: "foldable" example error in the doc page

Hi 👋,
this is what I see on the foldable page
https://sql.datapage.app/component.sql?component=foldable
Screenshots

Additional
love the project !

Fixed ! Thanks for reporting the issue. I still haven't automated updating the official website to the latest development version of sqlpage.
I love that you love it ! What are you building with it ?

an internal KPI dashboard at work.
it's the best tool for a great Time-to-Delivery


BUG: Raven error message if the channel is implicitly changed by clicking a Mattermost notification

I'm a user, not an admin.  I've been working with our IT department, and there seems to be no solution available to them.
Here's how to reproduce the problem.  Our Standup Raven is only visible in a single Mattermost channel.  I'm running Windows 10.

Start entering my standup information.
Receive a notification that a Mattermost message has come in addressed to me, from a different channel.
Click on the notification.
In the background, Mattermost switches to the channel for the incoming notification.
Finish filling in the pages for Raven, and click Submit.
Receive an error message: "An error occurred while submitting standup. Please try again. standup not configured for the channel: bmcf9c3g---snip---abapoao"
Click Cancel, and start all over with a blank slate.

IT reports we're running:
Standup Raven(3.1.1)LOCAL +
Mattermost Version: 5.29.0
My Mattermost client is version 4.6.1.
If any other information is needed I'll do my best to supply it.
Thanks.

@SAMeuse thanks for reporting the bug.
This is correct and it happens because the channel ID is picked as the channel you're currently in, at the time of submission of standup.
I think if we pick the channel ID at the time of opening of standup modal instead, this issue will be resolved. Let me try that out and get back to you.


[metrics] prototype attributes instrument advisory parameter

Goal:
We should prototype the attributes instrument advisory parameter as described in the spec. We should ensure that this parameter is appropriately marked as experimental in both the API and SDK.
Resources:

https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/metrics/api.md#instrument-advisory-parameter-attributes

im looking into this, just making sure i understand it;
we want to be able to set attributes on the Instrument level and those attributes will be on all metrics recorded from it?

As I understand it, it acts as an allow-list for attributes, filtering out all attribute keys that are not in that list.
I'll open an issue on the spec to seek clarification.

I added a link to the SDK spec to the description where it mentions that it's an allow-list:

If the user does not provide any value, the SDK SHOULD use
the Attributes advisory
parameter configured on the instrument instead. If the Attributes
advisory parameter is absent, all attributes MUST be kept.

Thanks


Why 297110 edges？

thx，but I parsed the raw data and obtained 297,110 edges. However, the dataset description seems to indicate there are 216,123?

I have the same question！

thx，but I parsed the raw data and obtained 297,110 edges. However, the dataset description seems to indicate there are 216,123?

I'm sorry I didn't read it carefully. This question has already been answered, in closed issue.


K8s testsuite log collection on failure reports invalid arguments

This PR failed a run on jenkins:
https://jenkins.cilium.io/job/cilium/job/cilium/job/PR-2302/1/execution/node/35/log/
When attempting to gather logs in the k8s tests, I see this:
21:40:48                             Cilium logs (last 200 lines)
21:40:48 docker: "logs" requires 1 argument.
21:40:48 See 'docker logs --help'.
21:40:48
21:40:48 Usage:	docker logs [OPTIONS] CONTAINER

Seems like there's some assumption being violated here - perhaps the docker ID is unexpectedly empty?
The test itself is a pure documentation change, so should not have any relationship to the issue (though it appears to be a flake that may affect master occasionally)

The logic for this in the K8s tests is the following:
cilium_id=$(docker ps -aql --filter=name=cilium-agent)
echo "------------------------------------------------------------------------"
echo "                            Cilium logs (last 200 lines)"
docker logs ${cilium_id} --tail 200
echo ""
echo "------------------------------------------------------------------------"

I suspect cilium_id was empty for whatever reason. This ticket can track adding more output to console to see what containers are currently running, and not gather logs if cilium_id is empty? Also maybe it should output a warning in the case that cilium_id is empty, as that indicates Cilium isn't running :(

@joestringer this is for the old bash test. I'll close this one due is not longer used.


FEATURE:

Description
To make the search much more effective, I suggest we add fuzzy search such that "idcc" if not found will suggest "idc" instead of showing This entry does not exist in our records as of yet. The best match should be returned.
Screenshots
No response

Do you still want to be assigned to this @MistaZidane ? Asking in relation to our conversation on LinkedIn.


Move /examples and /dev to new mattermost-app-examples repository

This PR should not be merged until https://github.com/mattermost/mattermost-developer-documentation/pull/1106 is merged.
Fixes:

https://github.com/mattermost/mattermost-plugin-apps/issues/330
https://github.com/mattermost/mattermost-plugin-apps/issues/329
https://github.com/mattermost/mattermost-plugin-apps/issues/300

Updates:

README points to developer resources and guides

This PR moves:

the content from /examples to the new https://github.com/mattermost/mattermost-app-examples repository.
the /dev environment to the new https://github.com/mattermost/mattermost-app-examples repository
the new content from merged PR https://github.com/mattermost/mattermost-plugin-apps/pull/352 to correspond with the new Python quick start guide in https://github.com/mattermost/mattermost-developer-documentation/pull/1106.

/examples/goapp has been preserved in this repository as /goapp.

@mickmister Can we do this relative to https://github.com/mattermost/mattermost-plugin-apps/pull/336?

@azigler Heads up that lots of the files have changed locations due to https://github.com/mattermost/mattermost-plugin-apps/pull/336


http-01 challenge propagation: wrong status code '404', expected '200'

Describe the bug:
I know there were other issues related with this bug and I've tried them, but for some reason, they didn't work. It worked for the namespace DEV. That is the thing that I found strange.
So basically I've tested different things:

Added annotation acme.cert-manager.io/http01-edit-in-place: "true"
Change to false the annotation nginx.ingress.kubernetes.io/ssl-redirect: "false"
Deleted the ingress and launched new ones
Deleted the ingress-controller and run the script again

My current architecture is an Ingress Controller and 2 Ingress for 2 namespaces.
FYI: This was working but it stopped working without any change on the infrastructure
I'm able to get the domain/.well-known/acme-challenge/ but it isn't applied
The issue I've tried to follow https://github.com/jetstack/cert-manager/issues/2517
** More info **
I've omitted hosts and rules. But I can add them if needed.
Prod ingress
apiVersion: extensions/v1beta1
kind: Ingress
metadata:
  name: ingress-prod
  annotations:
    kubernetes.io/ingress.class: "nginx"
    kubernetes.io/tls-acme: "true"
    nginx.ingress.kubernetes.io/proxy-read-timeout: "12h"
    nginx.ingress.kubernetes.io/ssl-redirect: "false"
    nginx.ingress.kubernetes.io/proxy-body-size: 10m
    cert-manager.io/cluster-issuer: letsencrypt-prod
    acme.cert-manager.io/http01-edit-in-place: "true"
  namespace: prod

Dev ingress
apiVersion: extensions/v1beta1
kind: Ingress
metadata:
  name: ingress-dev
  annotations:
    kubernetes.io/ingress.class: "nginx"
    kubernetes.io/tls-acme: "true"
    nginx.ingress.kubernetes.io/proxy-read-timeout: "12h"
    nginx.ingress.kubernetes.io/ssl-redirect: "true"
    nginx.ingress.kubernetes.io/proxy-body-size: 10m
    cert-manager.io/cluster-issuer: letsencrypt-prod
    acme.cert-manager.io/http01-edit-in-place: "true"
  namespace: dev

Environment details::

Kubernetes version (e.g. v1.10.2): 1.15.12-gke.2
Cloud-provider/provisioner (e.g. GKE, kops AWS, etc): GKE
cert-manager version (e.g. v0.4.0): cert-manager-v0.14.1
Install method (e.g. helm or static manifests): static manifests

/kind bug

When you use curl to check the challenge URL from inside a Kubernetes pod what response do you get?
/remove-kind bug
/triage support

I've tested that, I got the token.
I've managed to put it working but I had to delete all the ingresses and create new ones and didn't learn what it went wrong.

Seems to have been an ingress issue...
Going to close this as it is solved, feel free to /reopen if needed
/close


LinkedIn Learning and Ads reappear after site refresh

When Learning and Ads are on, and the website is refreshed, they are still present until the hider is triggered again, for example, by toggling the extension.

This might be happening because the onload function is not triggering correctly, or because the onload function triggers before the elements in question are rendered in.

Added a solution, but it is not ideal. The code attempts to add/remove the hide property, and uses a timeout and a Promise to keep doing that until it is found. Currently capped it at 50 attempts. Won't work if LinkedIn takes more than 20ish seconds to load.
The document_end property cannot be used since LinkedIn is a Single Page App.

Also need a better listener for URL changes, the current one is not working well. The old less optimal one might have been better...


Minor changes

Hi there,
thanks for your library.
I just made some minor changes, mostly to the documentation. Since it was not possible to reuse a Wrapper-object I added a new method unsetDocuments(). It just clears the list of documents to process.
When executing Tika I now use headless mode. This is necessary at least when working under OSX. You loose your current window/focus for every call of Tika (see http://stackoverflow.com/questions/11988899/how-can-i-start-apache-tika-in-console-without-open-the-gui).
Robert

Thank's for your work


Unable to use<EMAIL_ADDRESS>on deno main

At least as of https://github.com/denoland/deno/commit/be7e2bd8c1883c6bf58db8ff40954ed7ee53b5c5 (and earlier), I can't import and use skia_canvas.
Example code in ffi_bug.ts:
import { createCanvas } from<EMAIL_ADDRESS>
const canvas = createCanvas(800, 250);

Running it:
➜ cargo run -- --unstable run --allow-all ffi_bug.ts
   Compiling semver v1.0.14
   Compiling napi_sym v0.50.0 (/Users/kai/code/src/github.com/denoland/deno/cli/napi/sym)
   Compiling rustc_version v0.4.0
   Compiling curve25519-dalek v4.1.1
   Compiling x25519-dalek v2.0.0
   Compiling deno_node v0.57.0 (/Users/kai/code/src/github.com/denoland/deno/ext/node)
   Compiling deno_crypto v0.134.0 (/Users/kai/code/src/github.com/denoland/deno/ext/crypto)
   Compiling deno_kv v0.28.0 (/Users/kai/code/src/github.com/denoland/deno/ext/kv)
   Compiling deno_runtime v0.128.0 (/Users/kai/code/src/github.com/denoland/deno/runtime)
   Compiling deno v1.37.1 (/Users/kai/code/src/github.com/denoland/deno/cli)
    Finished dev [unoptimized + debuginfo] target(s) in 1m 13s
     Running `target/debug/deno --unstable run --allow-all ffi_bug.ts`
error: Uncaught (in promise) TypeError: expected typed ArrayBufferView
const METRICS_PTR = Deno.UnsafePointer.of(METRICS);
                                       ^
    at Function.of (ext:deno_ffi/00_ffi.js:230:23)
    at https://deno.land/x/skia_canvas@0.5.4/src/context2d.ts:191:40
    at eventLoopTick (ext:core/01_core.js:183:11)

Looks like the op -> op2 for ffi did this in https://github.com/denoland/deno/pull/20509. I discovered it using git bisect.

Closing as the issue is in Deno main and is being worked on.


In the [Bug Report] el-input component, the v-model.lazy modifier does not trigger synchronization in native change as expected

Element UI version
1.3.3
OS/Browsers version
windows10 opera
Vue version
2.3.3
Reproduction Link
https://jsfiddle.net/hgfkq78j/2/
Steps to reproduce
在v-model.lazy绑定的input中输入数据，value值根据输入的数据实时变化
What is Expected?
vue文档描述
在默认情况下， v-model 在 input 事件中同步输入框的值与数据 (除了 上述 IME 部分)，但你可以添加一个修饰符 lazy ，从而转变为在 change 事件中同步
如第二个input，在原生的change中输入数据，value值在enter或焦点离开时变化
What is actually happening?
lazy修饰符未生效

Has this issue fixed yet? What is the solution?

Has this issue been fixed yet? What is the solution?

@Leopoldthecoder
Should we align with native input tag's behavior?
This should be quite easy to fix.

I have run into this issue recently. If this won't be fixed, does anyone have a workaround for it?

@rDr4g0n you can use the second input example in my link https://jsfiddle.net/hgfkq78j/2/.
or you can write a component to package the el-input

Suppported.

已经修复了。https://jsfiddle.net/9qow0514/

已经修复了。https://jsfiddle.net/9qow0514/

从给出的例子看未修复，lazy修饰符按照预期（失去焦点后数据同步至vm上）生效

This does not work. None of the jsfiddles recognize lazy, and the original fiddle does not work.

see #14463


ui: Improve readablity of balances in light mode on dark backgrounds

Balances do not look very nice in light mode on dark backgrounds, e.g. in tooltips.
They should be made more readable and easy on the eyes.

Originally posted by @barrytra in https://github.com/joinmarket-webui/jam/issues/766#issuecomment-2135791517

@theborakompanioni is this issue still open ?

@barrytra Can I take up this issue

Lets discuss it here @SnehalSrivastava27
Can u show me what error do u get on running npm run regtest:rebuild and npm run regtest:up

This is what I get on npm run regtest:rebuild

and This is what I get on npm run regtest:up

I am almost ready with solving the issue but facing problem in running backend

@barrytra yes

Regarding the second error: Since it seems you are using some version of Windows, I am afraid I cannot reproduce the issue. I would have thought there is some kind of posix subsystem to make it work ("Windows Services for Linux", WSL?) or something.. (but I am not familiar with it and hence unable to help).

WSL2 is the way to go for Windows nowadays. It allows to run Ubuntu or whatever Linux distro you want under Windows 10/11.
P.S. "Windows Subsystem for Linux" (not "Services"). :)

@theborakompanioni in the first issue I have run the command several times

Hi everyone
I am unable to locally setup the project tried more than 15 times therefore I apologize that I cannot contribute into this issue looking forward to contribute in future when I may face good device

Hi everyone I am unable to locally setup the project tried more than 15 times therefore I apologize that I cannot contribute into this issue looking forward to contribute in future when I may face good device

Hey @SnehalSrivastava27 that is very unfortunate. I apologize that it is not working for you and that it does not seem to work or still needs effort to run the dev setup on Microsoft Windows™ Operating System.

I'll take a look at this when I'll have time.

Hi everyone I am unable to locally setup the project tried more than 15 times therefore I apologize that I cannot contribute into this issue looking forward to contribute in future when I may face good device

Try dual booting your system with Fedora.

@0xSaksham I have dual booted with Ubuntu and now the project is working smoothly also I have got my one PR merged


Basic Capslock remapping does not work

Capslock remapping doesn't work in either Keyd or Application Mapper. Other keys I've tested randomly in application mapper and keyd work, except for capslock = control. I can tell that Keyd is capturing my keyboard as the ids shown in keyd monitor have changed to the keyd virtual keyboard and are showing the default keys. Other than that application-mapper and keyd are working correctly. Thanks for the help.

On a whim, I decided to try overloading capslock to only be control when held. So my app.conf looks like this:
[emacs]
capslock = overload(control, capslock)
This works as expected. Am I misunderstanding whether capslock can be simply remapped?

[main]
capslock = oneshot(control)

this did work for me. The overloading with overload(control, control)  did also not work.

This also didn't work for me, but using the latest commit helped

Can you elaborate? Please provide a minimally viable sample config which reproduces the problem, as well as the expected behaviour.

The app.conf that doesn't work looks like this:
[emacs]
capslock = control

I'd like to have the capslock key output control when I'm in Emacs, but not in other programs.


[template] Hermes is a runtime dependency

Please select one of the following

[ ] I am removing an existing difference between facebook/react-native and microsoft/react-native-macos :thumbsup:
[ ] I am cherry-picking a change from Facebook's react-native into microsoft/react-native-macos :thumbsup:
[x] I am making a fix / change for the macOS implementation of react-native
[ ] I am making a change required for Microsoft usage of react-native

Summary
Hermes is a runtime dependency
Microsoft Reviewers: Open in CodeFlow

@orta How can we get “merge on green” functionality in this repo? Like, are you aware of a GitHub Action replacement?

@alloy, the AutoMerge label should do that.

wow, what?


Tick count on y-axis

Hi,
When you use c3 without options, ticks on y-axis are matching with the grid and show rounded values, which is great.
The tick count option on y-axis is working well, but shows min, max and values matching the interval (example : min, max and (max/2) if count = 3). It would be nicer, I think, if values could still match the grid, which is easier to read.
Furthermore, max value is a problem when you rotate axis and use 100% of container's width : half of the label will be hidden.
Thanks !
J.

@masayuki0812
I'm also struggling with this. If I leave the default settings, the tick count is too high for my data. If I set tick count, I have issues with precise values that are too hard to read.
Setting tick values is not an option for me, because my chart is generated dynamically, and I have no idea what the numbers (and their order of magnitude) will be.
I know vanilla d3 handles this pretty well, what can we do in c3 to make this better? How do you calculate the default y-axis tick values? (sorry, wasn't able to find in source code)

Has anyone solved this?

I solved it trough manualy calculating the distances:
x: {
  tick: {
    count: 24 / 3.56
  }
}

I just calculated it based only by trial & error until the ticks match the datapoints.
It's pretty dirty but it solves the problem.


[Migration] Need to change PROPERTY_KEY of existing audiences in IDN_OIDC_PROPERTY Table when migrating to 6.1.0

Description:
Changes made in https://github.com/wso2-extensions/identity-inbound-auth-oauth/pull/1902 require audiences to be stored separately in the DB.
The PROPERTY_KEY values in the table IDN_OIDC_PROPERTY with the value 'audience' need to be duplicated as 'idTokenAudience' and 'accessTokenAudience' during migration.

This issue is being closed due to extended inactivity. Please feel free to reopen it if further attention is needed. Thank you for helping us keep the issue list relevant and focused!


Drop unsupported nuproj and use "nuget pack"

NuProj does not support VS2017 so use "nuget pack" directly like with
the vswhere project.

:x: Build vssetup.powershell 2.0.3+gc63f7eec57 failed (commit https://github.com/Microsoft/vssetup.powershell/commit/c63f7eec57 by @heaths)

:white_check_mark: Build vssetup.powershell 2.0.4+g36d45a5dc5 completed (commit https://github.com/Microsoft/vssetup.powershell/commit/36d45a5dc5 by @heaths)

:white_check_mark: Build vssetup.powershell 2.0.5+g74c45258cf completed (commit https://github.com/Microsoft/vssetup.powershell/commit/74c45258cf by @heaths)


Access to trained checkpoints

Hello,
Congratulations on this promising work and many thanks for sharing models and code!
I'm very excited to explore your method. Unfortunately, for some reason, I cannot access the Google drive where you stored your checkpoints.
Could you make the Google drive accessible, please?

Hello funny-spark,
I just checked again and it was successfully downloaded using Microsoft Edge browser.
Best wishes

Thank you for your prompt response!
Maybe you are still logged in to your Google account in the browser?
Because I get the error message below:

I guess you can reproduce the problem when you try to open the link to the Google drive in a new private window.

Sorry about that, it could be downloaded now.

Great, it worked! Thank you so much!


Blip function

When the function is called it will reveal players every x second in order to force engagement

It could be useful to use the schedule command here in order to loop the occurrence of the glow. I think the way to go is to keep looping as long as a variable is set to true, then stop the scheduling when the variable is disabled again.

Commented
That sounds like a good idea, i'll look into schedule, thanks for the pointer.
I'll design the functions for the blink, and then piggyback off how you design the late game detection to fully implement it :)

I've now integrated two hooks into the datapacks for you to use. One is before the "end game" starts and one is when endgame finishes (and sudden death begins)

Ok awesome, will implement them this afternoon

Hi Geoffry! Have you done any progress? No stress I'm just curious

Hi, sorry, had a bunch of work stuff come up, i should hopefully have it done tomorrow night, if its still not done by then i might need to yield it back to you, sorry about the runaround.

Fixed the blip function


sanitycheck doesn't work on Windows (mkfifo not supported)

The instructions to invoke sanitycheck (in CONTRIBUTING) are Linux-specific.  Running python .\scripts\sanitycheck (as a workaround), produces errors such as "AttributeError: module 'os' has no attribute 'mkfifo'"  (mkfifo is not available on Windows)

duplicate of #2664


Replace LLNL E3SM License with xCDAT License

Closes #419

Checklist

[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] My changes generate no new warnings
[ ] Any dependent changes have been merged and published in downstream modules

If applicable:

[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass with my changes (locally and CI/CD build)
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] I have noted that this is a breaking change for a major release (fix or feature that would cause existing functionality to not work as expected)

Codecov Report
Patch and project coverage have no change.

Comparison is base (d0a4892) 100.00% compared to head (a46eaf8) 100.00%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@            Coverage Diff            @@
##              main      #443   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files           14        14
  Lines         1308      1308
=========================================
  Hits          1308      1308

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


fix: propagate default provider tags to volume tags

Fixes issue where provider tags were not being used as defaults in volume tags. Provider defaults propagating to volume_tags was introduced in version v5.39.0 of the aws provider https://github.com/hashicorp/terraform-provider-aws/issues/19890.
To accomodate this functionality we add any of the default tags with the volume_tags prefix if the current resource supports volume_tags (currently just aws_instance). This is only done if the version constraint specified at the root level terraform require_providers block is compatible with the 5.39.0 version. e.g. >= 5.0. Versions which specify a maximum version, e.g. ~> 3.0 below 5.39 will not have the default tags passed to volume tags. If no version constraint is found/can be parsed we add default tags to volume_tags by default. This is to ensure we have no false positive tagging policy failures.

@tim775 can you have another look at this - see the updated PR desc for more info. Note: the team decided the propagation of default tags to volume_tags should happen by default unless a user has explicitly specified a version that is below 5.39

@tim775 yeah I'm thinking it would be a lot easier/cleaner if we do it in HCL, but for now it's probably just a bit too much.


Update devnet.md

minor change

Hi @Romainua This was accurate at the time you submitted it, but we were a day away from deprecating gateway and replacing with full node. So this would have needed an update the next day. Sorry I overlooked it. Thank you.

@randall-Mysten great, will closed pr


guides: verify all guides use the correct single and double quotes

Somehow we had a stray instance of it‘s where we should have had it's
Search to ensure we all instances right across guides pre launch.

Moving to "next" - we should automate as part of preguide.


fix(db): Fix write stalls in RocksDB (again)

What ❔
RocksDB write stalls are still happening, this time for a different reason. Previously, they were caused by too many immutable memtables, this time – by too many level-0 SST files. This PR:

Tunes RocksDB options some more (the main tuning point is optimizing level-style compaction).
Increases the number of retries on stall and introduces exponential backoff.
Introduces a dozen of RocksDB metrics that should help monitoring RocksDB health.

Why ❔
Having write stalls leads to panics and is obviously bad.
Checklist

[x] PR title corresponds to the body of PR (we generate changelog entries from PRs).
[x] Tests for the changes have been added / updated.
[x] Documentation comments have been added / updated.
[x] Code has been formatted via zk fmt and zk lint.

On the stage env (if I read RocksDB logs correctly), the latest write stalls were caused by compaction that ran just a bit too long (~2s) to be covered by retries. Since now the interval before the last retry is ~1.9s, it could fix the problem on its own. One thing that we could try is to check whether the writes are stopped immediately after DB initialization, and if they are, wait until writes become unstuck (maybe, with an upper cap like 10s), folding this time into RocksDB initialization. A problem with this is approach – if I read RocksDB logs correctly – is that writes are stopped ~0.5s after the DB is initialized, not immediately (not sure why).


Cannot Login

I could not able to login. I followed the procedure. Everytime I am getting the message - Not authenticated - Try signing out and back in. Please Help.
Also can you share a sample playlist file for upload to know the pattern of the file?

Hello,
I'm just guessing based on the instructions, since I stole my cookies from Vivaldi instead of Firefox, but the text above contains both request and response cookies, whereas the video shows only copying the request cookies. From the video, you are supposed to right-click on one of the request cookie rows and choose "Copy All." This seems to copy properly for me in Firefox 92.0.1.

Specifically, the above text is a JSON object containing the two keys "Response Cookies" and "Request Cookies" whose values are objects, but this is too much, and only that second object should be included. So instead of looking like the following
{
    "Response Cookies": {
        "name1": { /* cookie properties omitted */ },
        "name2": {}
    },
    "Request Cookies": {
        /* this is the object you want */
        "name3": {},
        "name4": {}
    }
}

it should just be
{
    "name3": {},
    "name4": {}
}

Hey,
Thanks Aldaviva!
Yes, I don't think the app is able to parse the cookie text properly onto the desired request cookie object.
I do plan on making the parsing more lenient...
As for a playlist, a .m3u type playlist is quite common. You should be able to make one using most media player applications... iTunes, VLC, Windows media player...
Kind regards,
Jamie

Thanks Aldaviva & Jamesbrindle.  Followed the instructions shared by Aldaviva.  Got the validation successful.
Regarding .m3u playlist, let me try
Regards,
Franklin

Thanks.  Playlist upload also done
Thank you Jamesbrindle for this wonderful tool for music lovers
Regards
Franklin


Pla 711 create panel component

Description
Adds a dedicated component for the Panel.
Updates prettier and its tailwind plugin, with some config, so it sorts the classes on save.
Marked Section.Panel as deprecated.
I found uses in v2 and on Portal. In some cases, only the Panel was used. Since the Panel is simple and Atomic, it should take precedence over having it tied to another component. The deprecation is for internal reference, shouldn't affect any build that uses it.
The plugin set up raised some eslint errors due to unordered classes, so fixed those.
Also fixed some long-standing linter warning about using one "any" prop
Checklist

[ ] Change increases quality
[ ] Change is validated by tests
[ ] Change is readable and easy to understand
[ ] Documentation is updated
[ ] Security impact has been considered
[ ] Changes validated in runtime

To remove the Panel is also a benefit to reduce the misuse of a panel without the section surrounding itself.

I would like to see a corresponding Figma component to be in sync. It looks like the panel will be widely used and we should secure us for doing mistakes when we changed it for so many references.

I got a response from UX.

it wouldn’t get added to Figma as it works differently on the design side. It’s just styles applied to a frame. The frame itself wouldn’t be a component.
Components don’t work exactly the same in design and code. This is an example of something that shouldn’t be a component in design, just Styles.
In the end, same results, meaning when we use a frame, you already know you can pick up that component and it’ll match the styling.i wish I could also pick it up as a component but since the inner content varies, I’d have to detach it each time. Design components don’t allow for choosing the children later on, like the dev components can.

I checked hailstorm, and we have several components that are not in Figma, so if we take this argument we're not breaking previous consistency. I imagine we might want to make the case for having a clear rule, but I would consider this OOS for the context of this PR.

I got a response from UX.

it wouldn’t get added to Figma as it works differently on the design side. It’s just styles applied to a frame. The frame itself wouldn’t be a component.
Components don’t work exactly the same in design and code. This is an example of something that shouldn’t be a component in design, just Styles.
In the end, same results, meaning when we use a frame, you already know you can pick up that component and it’ll match the styling.i wish I could also pick it up as a component but since the inner content varies, I’d have to detach it each time. Design components don’t allow for choosing the children later on, like the dev components can.

I checked hailstorm, and we have several components that are not in Figma, so if we take this argument we're not breaking previous consistency. I imagine we might want to make the case for having a clear rule, but I would consider this OOS for the context of this PR.

Yes we have some components, especially the Layout components are missing in the Figma file because it is seemingly hard to create components with dynamic childs. If we stick with the figma effects/styles, we need to define any communication process.


Passing black/whitelist keys to Redis scripts

This ensures that whitelists/blacklists are prefixed properly to protect from collisions. The members of the whitelist/blacklist sets need to have a prefix prepended as well due to the way the rate limit keys are tracked and passed around. Using the RateLimit#blacklist and RateLimit#whitelist functions will handle this for you.
Fixes https://github.com/dudleycarr/ratelimit.js/issues/15

Made some additions in #20 to add a little documentation and what not :)

RFR @dudleycarr

The fixes for ioredis are awesome. Thanks for that as well! is RFR == reference?

RFR means "Ready for review" since @dudleycarr is the lead maintainer of this project he's got to review any non-trivial changes before merging up!

lgtm


Update the version of Kotlin and Gradle

Hi, I updated app/build.gradle and gradle-wrapper.properties by the latest Kotlin/Gradle version.
Somehow I couldn't resolve the dependency of 'android-P', so I also replaced it with 28.

I signed it!

@dazza5000 Thanks, I fixed merge conflicts, so please check it out.


Fix broken links on "Getting Started" page

Fixes two broken links on "Getting Started" page.

Removes link to docs page for glint-language-server that was removed in
https://github.com/typed-ember/glint/pull/416
Fixes broken link to "Configuration"

Side Note
There are a few other broken links throughout the docs but I don't understand how/why they're broken and they seem to magically sometimes not be broken in different preview versions.
For example, in the current live version of the "Getting Started" page the link to "Ember.js Installation" does not work. The path looks correct to me and the link works properly on GitHub when previewing the markdown files.
If you view the preview "revision" linked by GitBook in the checks for this PR this link is magically fixed. I'm not sure if that means that it will actually be fixed after merging this though.
Another example is the link to "Authoring Guide" on the "Using Addons" page. This link is broken in the live version AND the preview revision for this branch but seems to fix itself if ANY changes are made to the markdown file for page.

Thank you! Internal link rot in these docs has definitely been a struggle—I try and do a pass any time something moves or changes, but inevitably we wind up with stragglers.

This link is broken in the live version AND the preview revision for this branch but seems to fix itself if ANY changes are made to the markdown file for page.

I honestly have no clue what's going on there 🤔
I wonder if we have any options to force a rebuild of all the pages on the GitBook side... regardless, thanks for flagging these!


replace libff/libsecp256k1 submodules with plugin versions

This change:

avoids redundant clones of libff/libsecp256k1 because ---
the plugin now includes its own libff/libsecp256k1 submodules for ease of testing.

Currently, the build recipes are preserved except for removing the LIBFF_CC and LIBFF_CXX flags which are not needed on Ubuntu 18.04 and more recent distributions.

The K sysroot changes are in @sskeirik .

@ehildenb I have rebased this change on master with the K sysroot updated.


Leaderboard

Hi Reviewer 👋
in this branch, I create My own design using CSS

Hi @franclobo  thanks for your hard work I made the changes in the readme file and I just want to know if it's good now to ask for another review

Hi, @boo-shehab yes, you can submit it for a new re-review. Please 🙏🏽 take in mind on next week it will be mandatory to use the new README template in your repository.

@franclobo  Thanks for your help and your, yes I'll use the new readme.md for all upcoming repo thanks again


Is it possible to specify field name?

By default angular formly auto names your inputs, for example:
formly_1_input_password_3

Is is possible to give this a custom name, such as:
password

You can specify your own id and the name will match that. You can also keep the random id and instead specify a custom name. https://github.com/formly-js/angular-formly/blob/master/src/providers/formlyApiCheck.js#L92-L93

Note: The github issues in this project are not for questions but rather bugs reports or feature requests. Please follow the instructions here instead: http://help.angular-formly.com
Thanks for using angular-formly :D

Thanks for the quick response! In the future I will post questions to the
designated channels, and save github for bugs and features.
On Fri, Jul 10, 2015 at 11:26 AM, Kent C. Dodds<EMAIL_ADDRESS>wrote:

Note: The github issues in this project are not for questions but rather
bugs reports or feature requests. Please follow the instructions here
instead: http://help.angular-formly.com
Thanks for using angular-formly :D
—
Reply to this email directly or view it on GitHub
https://github.com/formly-js/angular-formly/issues/386#issuecomment-120436084
.

--
Matt Miller
Web Master
609-335-4417
<EMAIL_ADDRESS>https://www.superpedestrian.com/
https://www.google.com/url?q=https%3A%2F%2Fwww.superpedestrian.com%2F&sa=D&sntz=1&usg=AFQjCNHLEDFaMLgggeXL8rh4gGlNfN0WSA

Superpedestrian Inc.
84 Hamilton St.
Cambridge, MA 02139
This message is intended only for the addressee named above.  If you are
not the intended recipient of this message, you are hereby notified that
you must not use, disseminate, or copy it in any form or take any action in
reliance upon it.  If you have received this message in error, please
delete it and any copies of it from your email system and reply immediately
to the sender at the address shown above.  This message may contain
confidential and/or proprietary information.  Neither confidentiality, nor
any proprietary rights are intended to be waived or lost by any error in
transmission.

Thanks! :+1:


QRCode

Display a QRCode of the short link to ease copying on mobile phone devices.

solved by 06e395d89be5b0dda