Support more emojis in signoffs

QA
Copy this new regex to from the example config to the real config, and
make sure it:

works with emojis that our current regex doesn't like 🪂
doesn't match things that aren't emojis

cr_req 1
CC @ianrohde
Closes iFixit/pulldasher#176

CR 🐙

CR :shipit:

I found this library...
https://github.com/mathiasbynens/emoji-regex
But I don't know how to tell if the regex is equivalent to the one here.
script
const emojiRegex = require('emoji-regex');

const regex = emojiRegex();
console.log(regex);

regex
addison@Addison-Desktop-2DJGT2I:~/Emoji$ node getRegex.js /\uD83C\uDFF4\uDB40\uDC67\uDB40\uDC62(?:\uDB40\uDC77\uDB40\uDC6C\uDB40\uDC73|\uDB40\uDC73\uDB40\uDC63\uDB40\uDC74|\uDB40\uDC65\uDB40\uDC6E\uDB40\uDC67)\uDB40\uDC7F|\uD83D\uDC69\u200D\uD83D\uDC69\u200D(?:\uD83D\uDC66\u200D\uD83D\uDC66|\uD83D\uDC67\u200D(?:\uD83D[\uDC66\uDC67]))|\uD83D\uDC68(?:\uD83C\uDFFF\u200D(?:\uD83E\uDD1D\u200D\uD83D\uDC68(?:\uD83C[\uDFFB-\uDFFE])|\uD83C[\uDF3E\uDF73\uDF7C\uDF93\uDFA4\uDFA8\uDFEB\uDFED]|\uD83D[\uDCBB\uDCBC\uDD27\uDD2C\uDE80\uDE92]|\uD83E[\uDDAF-\uDDB3\uDDBC\uDDBD])|\uD83C\uDFFE\u200D(?:\uD83E\uDD1D\u200D\uD83D\uDC68(?:\uD83C[\uDFFB-\uDFFD\uDFFF])|\uD83C[\uDF3E\uDF73\uDF7C\uDF93\uDFA4\uDFA8\uDFEB\uDFED]|\uD83D[\uDCBB\uDCBC\uDD27\uDD2C\uDE80\uDE92]|\uD83E[\uDDAF-\uDDB3\uDDBC\uDDBD])|\uD83C\uDFFD\u200D(?:\uD83E\uDD1D\u200D\uD83D\uDC68(?:\uD83C[\uDFFB\uDFFC\uDFFE\uDFFF])|\uD83C[\uDF3E\uDF73\uDF7C\uDF93\uDFA4\uDFA8\uDFEB\uDFED]|\uD83D[\uDCBB\uDCBC\uDD27\uDD2C\uDE80\uDE92]|\uD83E[\uDDAF-\uDDB3\uDDBC\uDDBD])|\uD83C\uDFFC\u200D(?:\uD83E\uDD1D\u200D\uD83D\uDC68(?:\uD83C[\uDFFB\uDFFD-\uDFFF])|\uD83C[\uDF3E\uDF73\uDF7C\uDF93\uDFA4\uDFA8\uDFEB\uDFED]|\uD83D[\uDCBB\uDCBC\uDD27\uDD2C\uDE80\uDE92]|\uD83E[\uDDAF-\uDDB3\uDDBC\uDDBD])|\uD83C\uDFFB\u200D(?:\uD83E\uDD1D\u200D\uD83D\uDC68(?:\uD83C[\uDFFC-\uDFFF])|\uD83C[\uDF3E\uDF73\uDF7C\uDF93\uDFA4\uDFA8\uDFEB\uDFED]|\uD83D[\uDCBB\uDCBC\uDD27\uDD2C\uDE80\uDE92]|\uD83E[\uDDAF-\uDDB3\uDDBC\uDDBD])|\u200D(?:\u2764\uFE0F\u200D(?:\uD83D\uDC8B\u200D)?\uD83D\uDC68|(?:\uD83D[\uDC68\uDC69])\u200D(?:\uD83D\uDC66\u200D\uD83D\uDC66|\uD83D\uDC67\u200D(?:\uD83D[\uDC66\uDC67]))|\uD83D\uDC66\u200D\uD83D\uDC66|\uD83D\uDC67\u200D(?:\uD83D[\uDC66\uDC67])|(?:\uD83D[\uDC68\uDC69])\u200D(?:\uD83D[\uDC66\uDC67])|[\u2695\u2696\u2708]\uFE0F|\uD83D[\uDC66\uDC67]|\uD83C[\uDF3E\uDF73\uDF7C\uDF93\uDFA4\uDFA8\uDFEB\uDFED]|\uD83D[\uDCBB\uDCBC\uDD27\uDD2C\uDE80\uDE92]|\uD83E[\uDDAF-\uDDB3\uDDBC\uDDBD])|(?:\uD83C\uDFFF\u200D[\u2695\u2696\u2708]|\uD83C\uDFFE\u200D[\u2695\u2696\u2708]|\uD83C\uDFFD\u200D[\u2695\u2696\u2708]|\uD83C\uDFFC\u200D[\u2695\u2696\u2708]|\uD83C\uDFFB\u200D[\u2695\u2696\u2708])\uFE0F|\uD83C[\uDFFB-\uDFFF])|\uD83E\uDDD1(?:(?:\uD83C[\uDFFB-\uDFFF])\u200D(?:\uD83E\uDD1D\u200D\uD83E\uDDD1(?:\uD83C[\uDFFB-\uDFFF])|\uD83C[\uDF3E\uDF73\uDF7C\uDF84\uDF93\uDFA4\uDFA8\uDFEB\uDFED]|\uD83D[\uDCBB\uDCBC\uDD27\uDD2C\uDE80\uDE92]|\uD83E[\uDDAF-\uDDB3\uDDBC\uDDBD])|\u200D(?:\uD83E\uDD1D\u200D\uD83E\uDDD1|\uD83C[\uDF3E\uDF73\uDF7C\uDF84\uDF93\uDFA4\uDFA8\uDFEB\uDFED]|\uD83D[\uDCBB\uDCBC\uDD27\uDD2C\uDE80\uDE92]|\uD83E[\uDDAF-\uDDB3\uDDBC\uDDBD]))|\uD83D\uDC69(?:\u200D(?:\u2764\uFE0F\u200D(?:\uD83D\uDC8B\u200D(?:\uD83D[\uDC68\uDC69])|\uD83D[\uDC68\uDC69])|\uD83C[\uDF3E\uDF73\uDF7C\uDF93\uDFA4\uDFA8\uDFEB\uDFED]|\uD83D[\uDCBB\uDCBC\uDD27\uDD2C\uDE80\uDE92]|\uD83E[\uDDAF-\uDDB3\uDDBC\uDDBD])|\uD83C\uDFFF\u200D(?:\uD83C[\uDF3E\uDF73\uDF7C\uDF93\uDFA4\uDFA8\uDFEB\uDFED]|\uD83D[\uDCBB\uDCBC\uDD27\uDD2C\uDE80\uDE92]|\uD83E[\uDDAF-\uDDB3\uDDBC\uDDBD])|\uD83C\uDFFE\u200D(?:\uD83C[\uDF3E\uDF73\uDF7C\uDF93\uDFA4\uDFA8\uDFEB\uDFED]|\uD83D[\uDCBB\uDCBC\uDD27\uDD2C\uDE80\uDE92]|\uD83E[\uDDAF-\uDDB3\uDDBC\uDDBD])|\uD83C\uDFFD\u200D(?:\uD83C[\uDF3E\uDF73\uDF7C\uDF93\uDFA4\uDFA8\uDFEB\uDFED]|\uD83D[\uDCBB\uDCBC\uDD27\uDD2C\uDE80\uDE92]|\uD83E[\uDDAF-\uDDB3\uDDBC\uDDBD])|\uD83C\uDFFC\u200D(?:\uD83C[\uDF3E\uDF73\uDF7C\uDF93\uDFA4\uDFA8\uDFEB\uDFED]|\uD83D[\uDCBB\uDCBC\uDD27\uDD2C\uDE80\uDE92]|\uD83E[\uDDAF-\uDDB3\uDDBC\uDDBD])|\uD83C\uDFFB\u200D(?:\uD83C[\uDF3E\uDF73\uDF7C\uDF93\uDFA4\uDFA8\uDFEB\uDFED]|\uD83D[\uDCBB\uDCBC\uDD27\uDD2C\uDE80\uDE92]|\uD83E[\uDDAF-\uDDB3\uDDBC\uDDBD]))|\uD83D\uDC69\uD83C\uDFFF\u200D\uD83E\uDD1D\u200D(?:\uD83D[\uDC68\uDC69])(?:\uD83C[\uDFFB-\uDFFE])|\uD83D\uDC69\uD83C\uDFFE\u200D\uD83E\uDD1D\u200D(?:\uD83D[\uDC68\uDC69])(?:\uD83C[\uDFFB-\uDFFD\uDFFF])|\uD83D\uDC69\uD83C\uDFFD\u200D\uD83E\uDD1D\u200D(?:\uD83D[\uDC68\uDC69])(?:\uD83C[\uDFFB\uDFFC\uDFFE\uDFFF])|\uD83D\uDC69\uD83C\uDFFC\u200D\uD83E\uDD1D\u200D(?:\uD83D[\uDC68\uDC69])(?:\uD83C[\uDFFB\uDFFD-\uDFFF])|\uD83D\uDC69\uD83C\uDFFB\u200D\uD83E\uDD1D\u200D(?:\uD83D[\uDC68\uDC69])(?:\uD83C[\uDFFC-\uDFFF])|\uD83D\uDC69\u200D\uD83D\uDC66\u200D\uD83D\uDC66|\uD83D\uDC69\u200D\uD83D\uDC69\u200D(?:\uD83D[\uDC66\uDC67])|(?:\uD83D\uDC41\uFE0F\u200D\uD83D\uDDE8|\uD83D\uDC69(?:\uD83C\uDFFF\u200D[\u2695\u2696\u2708]|\uD83C\uDFFE\u200D[\u2695\u2696\u2708]|\uD83C\uDFFD\u200D[\u2695\u2696\u2708]|\uD83C\uDFFC\u200D[\u2695\u2696\u2708]|\uD83C\uDFFB\u200D[\u2695\u2696\u2708]|\u200D[\u2695\u2696\u2708])|\uD83C\uDFF3\uFE0F\u200D\u26A7|\uD83E\uDDD1(?:(?:\uD83C[\uDFFB-\uDFFF])\u200D[\u2695\u2696\u2708]|\u200D[\u2695\u2696\u2708])|\uD83D\uDC3B\u200D\u2744|(?:\uD83C[\uDFC3\uDFC4\uDFCA]|\uD83D[\uDC6E\uDC70\uDC71\uDC73\uDC77\uDC81\uDC82\uDC86\uDC87\uDE45-\uDE47\uDE4B\uDE4D\uDE4E\uDEA3\uDEB4-\uDEB6]|\uD83E[\uDD26\uDD35\uDD37-\uDD39\uDD3D\uDD3E\uDDB8\uDDB9\uDDCD-\uDDCF\uDDD6-\uDDDD])(?:\uD83C[\uDFFB-\uDFFF])\u200D[\u2640\u2642]|(?:\u26F9|\uD83C[\uDFCB\uDFCC]|\uD83D\uDD75)(?:\uFE0F\u200D[\u2640\u2642]|(?:\uD83C[\uDFFB-\uDFFF])\u200D[\u2640\u2642])|\uD83C\uDFF4\u200D\u2620|(?:\uD83C[\uDFC3\uDFC4\uDFCA]|\uD83D[\uDC6E-\uDC71\uDC73\uDC77\uDC81\uDC82\uDC86\uDC87\uDE45-\uDE47\uDE4B\uDE4D\uDE4E\uDEA3\uDEB4-\uDEB6]|\uD83E[\uDD26\uDD35\uDD37-\uDD39\uDD3C-\uDD3E\uDDB8\uDDB9\uDDCD-\uDDCF\uDDD6-\uDDDF])\u200D[\u2640\u2642])\uFE0F|\uD83D\uDC69\u200D\uD83D\uDC67\u200D(?:\uD83D[\uDC66\uDC67])|\uD83C\uDFF3\uFE0F\u200D\uD83C\uDF08|\uD83D\uDC69\u200D\uD83D\uDC67|\uD83D\uDC69\u200D\uD83D\uDC66|\uD83D\uDC15\u200D\uD83E\uDDBA|\uD83C\uDDFD\uD83C\uDDF0|\uD83C\uDDF6\uD83C\uDDE6|\uD83C\uDDF4\uD83C\uDDF2|\uD83D\uDC08\u200D\u2B1B|\uD83E\uDDD1(?:\uD83C[\uDFFB-\uDFFF])|\uD83D\uDC69(?:\uD83C[\uDFFB-\uDFFF])|\uD83C\uDDFF(?:\uD83C[\uDDE6\uDDF2\uDDFC])|\uD83C\uDDFE(?:\uD83C[\uDDEA\uDDF9])|\uD83C\uDDFC(?:\uD83C[\uDDEB\uDDF8])|\uD83C\uDDFB(?:\uD83C[\uDDE6\uDDE8\uDDEA\uDDEC\uDDEE\uDDF3\uDDFA])|\uD83C\uDDFA(?:\uD83C[\uDDE6\uDDEC\uDDF2\uDDF3\uDDF8\uDDFE\uDDFF])|\uD83C\uDDF9(?:\uD83C[\uDDE6\uDDE8\uDDE9\uDDEB-\uDDED\uDDEF-\uDDF4\uDDF7\uDDF9\uDDFB\uDDFC\uDDFF])|\uD83C\uDDF8(?:\uD83C[\uDDE6-\uDDEA\uDDEC-\uDDF4\uDDF7-\uDDF9\uDDFB\uDDFD-\uDDFF])|\uD83C\uDDF7(?:\uD83C[\uDDEA\uDDF4\uDDF8\uDDFA\uDDFC])|\uD83C\uDDF5(?:\uD83C[\uDDE6\uDDEA-\uDDED\uDDF0-\uDDF3\uDDF7-\uDDF9\uDDFC\uDDFE])|\uD83C\uDDF3(?:\uD83C[\uDDE6\uDDE8\uDDEA-\uDDEC\uDDEE\uDDF1\uDDF4\uDDF5\uDDF7\uDDFA\uDDFF])|\uD83C\uDDF2(?:\uD83C[\uDDE6\uDDE8-\uDDED\uDDF0-\uDDFF])|\uD83C\uDDF1(?:\uD83C[\uDDE6-\uDDE8\uDDEE\uDDF0\uDDF7-\uDDFB\uDDFE])|\uD83C\uDDF0(?:\uD83C[\uDDEA\uDDEC-\uDDEE\uDDF2\uDDF3\uDDF5\uDDF7\uDDFC\uDDFE\uDDFF])|\uD83C\uDDEF(?:\uD83C[\uDDEA\uDDF2\uDDF4\uDDF5])|\uD83C\uDDEE(?:\uD83C[\uDDE8-\uDDEA\uDDF1-\uDDF4\uDDF6-\uDDF9])|\uD83C\uDDED(?:\uD83C[\uDDF0\uDDF2\uDDF3\uDDF7\uDDF9\uDDFA])|\uD83C\uDDEC(?:\uD83C[\uDDE6\uDDE7\uDDE9-\uDDEE\uDDF1-\uDDF3\uDDF5-\uDDFA\uDDFC\uDDFE])|\uD83C\uDDEB(?:\uD83C[\uDDEE-\uDDF0\uDDF2\uDDF4\uDDF7])|\uD83C\uDDEA(?:\uD83C[\uDDE6\uDDE8\uDDEA\uDDEC\uDDED\uDDF7-\uDDFA])|\uD83C\uDDE9(?:\uD83C[\uDDEA\uDDEC\uDDEF\uDDF0\uDDF2\uDDF4\uDDFF])|\uD83C\uDDE8(?:\uD83C[\uDDE6\uDDE8\uDDE9\uDDEB-\uDDEE\uDDF0-\uDDF5\uDDF7\uDDFA-\uDDFF])|\uD83C\uDDE7(?:\uD83C[\uDDE6\uDDE7\uDDE9-\uDDEF\uDDF1-\uDDF4\uDDF6-\uDDF9\uDDFB\uDDFC\uDDFE\uDDFF])|\uD83C\uDDE6(?:\uD83C[\uDDE8-\uDDEC\uDDEE\uDDF1\uDDF2\uDDF4\uDDF6-\uDDFA\uDDFC\uDDFD\uDDFF])|[#\*0-9]\uFE0F\u20E3|(?:\uD83C[\uDFC3\uDFC4\uDFCA]|\uD83D[\uDC6E\uDC70\uDC71\uDC73\uDC77\uDC81\uDC82\uDC86\uDC87\uDE45-\uDE47\uDE4B\uDE4D\uDE4E\uDEA3\uDEB4-\uDEB6]|\uD83E[\uDD26\uDD35\uDD37-\uDD39\uDD3D\uDD3E\uDDB8\uDDB9\uDDCD-\uDDCF\uDDD6-\uDDDD])(?:\uD83C[\uDFFB-\uDFFF])|(?:\u26F9|\uD83C[\uDFCB\uDFCC]|\uD83D\uDD75)(?:\uD83C[\uDFFB-\uDFFF])|(?:[\u261D\u270A-\u270D]|\uD83C[\uDF85\uDFC2\uDFC7]|\uD83D[\uDC42\uDC43\uDC46-\uDC50\uDC66\uDC67\uDC6B-\uDC6D\uDC72\uDC74-\uDC76\uDC78\uDC7C\uDC83\uDC85\uDCAA\uDD74\uDD7A\uDD90\uDD95\uDD96\uDE4C\uDE4F\uDEC0\uDECC]|\uD83E[\uDD0C\uDD0F\uDD18-\uDD1C\uDD1E\uDD1F\uDD30-\uDD34\uDD36\uDD77\uDDB5\uDDB6\uDDBB\uDDD2-\uDDD5])(?:\uD83C[\uDFFB-\uDFFF])|(?:[\u231A\u231B\u23E9-\u23EC\u23F0\u23F3\u25FD\u25FE\u2614\u2615\u2648-\u2653\u267F\u2693\u26A1\u26AA\u26AB\u26BD\u26BE\u26C4\u26C5\u26CE\u26D4\u26EA\u26F2\u26F3\u26F5\u26FA\u26FD\u2705\u270A\u270B\u2728\u274C\u274E\u2753-\u2755\u2757\u2795-\u2797\u27B0\u27BF\u2B1B\u2B1C\u2B50\u2B55]|\uD83C[\uDC04\uDCCF\uDD8E\uDD91-\uDD9A\uDDE6-\uDDFF\uDE01\uDE1A\uDE2F\uDE32-\uDE36\uDE38-\uDE3A\uDE50\uDE51\uDF00-\uDF20\uDF2D-\uDF35\uDF37-\uDF7C\uDF7E-\uDF93\uDFA0-\uDFCA\uDFCF-\uDFD3\uDFE0-\uDFF0\uDFF4\uDFF8-\uDFFF]|\uD83D[\uDC00-\uDC3E\uDC40\uDC42-\uDCFC\uDCFF-\uDD3D\uDD4B-\uDD4E\uDD50-\uDD67\uDD7A\uDD95\uDD96\uDDA4\uDDFB-\uDE4F\uDE80-\uDEC5\uDECC\uDED0-\uDED2\uDED5-\uDED7\uDEEB\uDEEC\uDEF4-\uDEFC\uDFE0-\uDFEB]|\uD83E[\uDD0C-\uDD3A\uDD3C-\uDD45\uDD47-\uDD78\uDD7A-\uDDCB\uDDCD-\uDDFF\uDE70-\uDE74\uDE78-\uDE7A\uDE80-\uDE86\uDE90-\uDEA8\uDEB0-\uDEB6\uDEC0-\uDEC2\uDED0-\uDED6])|(?:[#\*0-9\xA9\xAE\u203C\u2049\u2122\u2139\u2194-\u2199\u21A9\u21AA\u231A\u231B\u2328\u23CF\u23E9-\u23F3\u23F8-\u23FA\u24C2\u25AA\u25AB\u25B6\u25C0\u25FB-\u25FE\u2600-\u2604\u260E\u2611\u2614\u2615\u2618\u261D\u2620\u2622\u2623\u2626\u262A\u262E\u262F\u2638-\u263A\u2640\u2642\u2648-\u2653\u265F\u2660\u2663\u2665\u2666\u2668\u267B\u267E\u267F\u2692-\u2697\u2699\u269B\u269C\u26A0\u26A1\u26A7\u26AA\u26AB\u26B0\u26B1\u26BD\u26BE\u26C4\u26C5\u26C8\u26CE\u26CF\u26D1\u26D3\u26D4\u26E9\u26EA\u26F0-\u26F5\u26F7-\u26FA\u26FD\u2702\u2705\u2708-\u270D\u270F\u2712\u2714\u2716\u271D\u2721\u2728\u2733\u2734\u2744\u2747\u274C\u274E\u2753-\u2755\u2757\u2763\u2764\u2795-\u2797\u27A1\u27B0\u27BF\u2934\u2935\u2B05-\u2B07\u2B1B\u2B1C\u2B50\u2B55\u3030\u303D\u3297\u3299]|\uD83C[\uDC04\uDCCF\uDD70\uDD71\uDD7E\uDD7F\uDD8E\uDD91-\uDD9A\uDDE6-\uDDFF\uDE01\uDE02\uDE1A\uDE2F\uDE32-\uDE3A\uDE50\uDE51\uDF00-\uDF21\uDF24-\uDF93\uDF96\uDF97\uDF99-\uDF9B\uDF9E-\uDFF0\uDFF3-\uDFF5\uDFF7-\uDFFF]|\uD83D[\uDC00-\uDCFD\uDCFF-\uDD3D\uDD49-\uDD4E\uDD50-\uDD67\uDD6F\uDD70\uDD73-\uDD7A\uDD87\uDD8A-\uDD8D\uDD90\uDD95\uDD96\uDDA4\uDDA5\uDDA8\uDDB1\uDDB2\uDDBC\uDDC2-\uDDC4\uDDD1-\uDDD3\uDDDC-\uDDDE\uDDE1\uDDE3\uDDE8\uDDEF\uDDF3\uDDFA-\uDE4F\uDE80-\uDEC5\uDECB-\uDED2\uDED5-\uDED7\uDEE0-\uDEE5\uDEE9\uDEEB\uDEEC\uDEF0\uDEF3-\uDEFC\uDFE0-\uDFEB]|\uD83E[\uDD0C-\uDD3A\uDD3C-\uDD45\uDD47-\uDD78\uDD7A-\uDDCB\uDDCD-\uDDFF\uDE70-\uDE74\uDE78-\uDE7A\uDE80-\uDE86\uDE90-\uDEA8\uDEB0-\uDEB6\uDEC0-\uDEC2\uDED0-\uDED6])\uFE0F|(?:[\u261D\u26F9\u270A-\u270D]|\uD83C[\uDF85\uDFC2-\uDFC4\uDFC7\uDFCA-\uDFCC]|\uD83D[\uDC42\uDC43\uDC46-\uDC50\uDC66-\uDC78\uDC7C\uDC81-\uDC83\uDC85-\uDC87\uDC8F\uDC91\uDCAA\uDD74\uDD75\uDD7A\uDD90\uDD95\uDD96\uDE45-\uDE47\uDE4B-\uDE4F\uDEA3\uDEB4-\uDEB6\uDEC0\uDECC]|\uD83E[\uDD0C\uDD0F\uDD18-\uDD1F\uDD26\uDD30-\uDD39\uDD3C-\uDD3E\uDD77\uDDB5\uDDB6\uDDB8\uDDB9\uDDBB\uDDCD-\uDDCF\uDDD1-\uDDDD])/g

Anyway, I guess the changes in this PR are probably good enough. I'll test it out tomorrow if no one gets to it today.

QA 👍   The regexer link in the comment says it all.


how can user disable some symbols appearance repeatedly?

'|' and  '¦' appear twice in one line, how can user disable its appearance repeatedly?

after update of https://github.com/Shougo/defx.nvim. the symbols disappear.


[Developer Guide] Adjust Model Component

Will be reopening this issue until Chenglong has updated his part of his DG.


Use standards

Use the Standards!

Removes references to the pattern portfolio and updates layout to fall in line with single page applications.

Looks great, and love the hero image. The only thing I'm worried about is including the dependency as part of the source control of this particular project :-/ If we're pulling it in via npm, I guess the ideal approach would be to have a build script run and deploy to gh-pages...but that also seems a bit much for a simple site. Perhaps we should brainstorm about this a bit tomorrow.

Sure, we can discuss. I purposefully chose to include the dependency in the source control because this project is so simple and doesn't have a build process currently in place. Another option is to point directly to the latest version of the standards compiled files through https://cityofphiladelphia.github.io/standards-docs/css/standards.css (eventually standards.phila.gov).

Hi! Are there URLs for each version of standards.css? Seems like that would be useful for simple apps that don't get updated as often.

@gsf I moved away from individual URLs for each release of Standards, in part because Patterns started to look like this.
Ideally, these smaller sites would adopt a build process, eliminating the need to include the compiled files. I don't think we're there yet, though. That's why the option to download the /dist files directly exists at all.

Gotcha. The option to src specific release files is a nice to have, but vendoring it in is actually more robust.

I just discovered https://unpkg.com/ which looks like it will make @timwis happy and solve the issue of cluttering up the repo.

Instead of vendoring, I used unpkg links for the assets.
This now also updates the footer and related content links.


Update to JE 1.19.4

New problem: The client thinks it can't execute the commands (but it can)
Old problem: The very long join time is still present :(
The registry codec was generated from the mappings generator. New size is %140.


Problem in Data Generation

Hi! Wonderful work.
I am currently training the model with my own data using the dataset-generation code you provided.
However, there is an error returning as
.
I am training on 2 RTX4090 GPUs with 24Gb for each one, is this ram enough for training data generation?
If not, how can I revise the script to decrease the GPU ram for data generation.
Thank you.

Hi, I suggest using GPUs with higher memory for running the data generation codes. Additionally, consider generating the bounding boxes/masks first using the bounding box/mask generation section of the code, and then save these results locally. Once saved, you can proceed with running the instance-caption generation codes. This approach should help in reducing memory usage by avoiding the need to generate everything simultaneously.
Hope it helps.

Not sure if you have solved the problem, but I can run the Data Generation Process using two RTX A5000 GPUs by distributing the setup as follows: Loading the BLIP2 model to a GPU, while the rest of the models are loaded to another
Doing so will use ~24GB on the BLIP2 GPU and ~11GB on the other models GPU.
Hope this helps!


[SPARK-41049][SQL][FOLLOW-UP] Mark map related expressions as stateful expressions

What changes were proposed in this pull request?

MapConcat contains a state so it is stateful:
private lazy val mapBuilder = new ArrayBasedMapBuilder(dataType.keyType, dataType.valueType)

Similarly MapFromEntries, CreateMap, MapFromArrays, StringToMap, and TransformKeys need the same change.
Why are the changes needed?

Stateful expression should be marked as stateful.
Does this PR introduce any user-facing change?

No
How was this patch tested?

N/A
Was this patch authored or co-authored using generative AI tooling?

No

@cloud-fan

thanks, merging to master/3.5!

There is one test failed after this one merged into branch-3.5:

https://github.com/apache/spark/actions/runs/9264103519/job/25483620452

[info] - SPARK-41049: stateful expression should be copied correctly *** FAILED *** (105 milliseconds)
[info]   "["keys: [key], values: [value]"]" did not equal "[{key -> value}]" (DataFrameSuite.scala:3644)
[info]   Analysis:
[info]   "["keys: [key], values: [value]"]" -> "[{key -> value}]"
[info]   org.scalatest.exceptions.TestFailedException:
[info]   at org.scalatest.Assertions.newAssertionFailedException(Assertions.scala:472)
[info]   at org.scalatest.Assertions.newAssertionFailedException$(Assertions.scala:471)
[info]   at org.scalatest.Assertions$.newAssertionFailedException(Assertions.scala:1231)
[info]   at org.scalatest.Assertions$AssertionsHelper.macroAssert(Assertions.scala:1295)
[info]   at org.apache.spark.sql.DataFrameSuite.$anonfun$new$733(DataFrameSuite.scala:3644)
[info]   at scala.collection.IndexedSeqOptimized.foreach(IndexedSeqOptimized.scala:36)
[info]   at scala.collection.IndexedSeqOptimized.foreach$(IndexedSeqOptimized.scala:33)
[info]   at scala.collection.mutable.ArrayOps$ofRef.foreach(ArrayOps.scala:198)
[info]   at org.apache.spark.sql.DataFrameSuite.$anonfun$new$731(DataFrameSuite.scala:3642)
[info]   at scala.runtime.java8.JFunction0$mcV$sp.apply(JFunction0$mcV$sp.java:23)

cc @amaliujia @cloud-fan

I am wondering if there are some commits missing in the branch 3-5 @cloud-fan ?

yea there was a commit to change the pretty string. @amaliujia can you open a fix PR for 3.5 to update the test?

sending out https://github.com/apache/spark/pull/46795


Add documentation for Server Side rendering from Angular templates

We should update https://docs.microsoft.com/en-us/aspnet/core/client-side/spa/angular?view=aspnetcore-2.1&tabs=visual-studio#server-side-rendering to include the new steps for enabling SSR (Server Side Rendering) as mentioned here.
Per @SteveSandersonMS

In the worst case we could remove the whole section about SSR and just say it's not something we have any recommendations about how to do. But it would be better if there was a known set of steps to enable SSR that we could document.

So 3 sprints later and this has still not been completed?
How is that even possible, just update the damn file already.

Angular SSR docs ended up being removed entirely. Details can be found here.

The framework changes way too much lately to provide a proper documentation about server-side rendering.
Aside from that, the implementation relies on third-party libraries such as express-engine.
If you really want to implement SSR, please consult https://medium.com/@pieterjandeclippel/server-side-rendering-in-asp-net-core-angular-6df7adacbdaa for ASP.NET Core 2.2 and Angular 8.1.

The framework changes way too much lately to provide a proper documentation about server-side rendering. Aside from that, the implementation relies on third-party libraries such as express-engine.
That's why Microsoft decided to remove this from the documentation.
If you really want to implement SSR, please consult https://medium.com/@pieterjandeclippel/server-side-rendering-in-asp-net-core-angular-6df7adacbdaa for ASP.NET Core 2.2 and Angular 8.1.


pipeline failure

The pipelines are failing as a result of error (unable to unpack string object type) from the ingest data notebook

Sorry for the delay on this @linkmarshal, we had actually gotten some updates and moved the solution to a Microsoft repo. I will nevertheless fix this issue this week, but we will have future releases and features on: https://github.com/microsoft/Azure-Social-Media-Analytics-Solution-Accelerator


nested XML reading

Closes #602 for the rework branch.

Note that using xmlUtils to expand xml is exclusive to the rework branch, so this fix applies only to that.

Job Test linux on fee436b : invalidated by @PaulTalbot-INL
likely a fluke (with file i/o?)

news on this?

Job Mingw Test on fee436b : invalidated by @PaulTalbot-INL
Windows test machine is updated

Job Mingw Test on fee436b : invalidated by @PaulTalbot-INL
Issues fixed in #590 might have fixed this test, too.

Job Test linux on fee436b : invalidated by @PaulTalbot-INL
Issues fixed in #590 may have fixed this, too.

@mandd this has passed tests; am I okay to merge?


No binary support with transport=websocket in the nodejs client

My server code:
var io = require('socket.io')(9000);
io.on('connection', function (socket) {
    socket.on('message', function(data) {
        console.log(data);
    });
});

My client code also running in nodejs:
var io = require('socket.io-client');
var socket = io('http://localhost:9000');
socket.on('connect', function() {
    process.stdin.on('data', function(data) {
        socket.send(data);
   });
});

Using wireshark I can see that messages are encoding as base64. The problem seems to be at
https://github.com/Automattic/engine.io-client/blob/master/lib/transports/websocket.js#L95
because https://github.com/websockets/ws does not have any binaryType attribute. A workaround may be to look also at supports.binary.
Not sure this is a ws bug or an engine.io-client bug but it looks like binary will currently only work between a browser and a nodejs server, not between two nodejs process.

Thanks, I could reproduce the issue and your explanation seems completely correct.

Oops I missed that there was already a pull request for this bug: #383

Ah, I also didn't notice, thx.


copy to clipboard "lightning run notebook my_notebook" is coppying "lightning run notebook my_notebook"

Yes, this is a known limitation of chrome. I think we will simply disable it locally. @ethanwharris


make the pb pinch to zoom work in android

trying to help to solve it couldn't find the reason

is there a way to steal the zooming capabalities from photo browser to swiper?

The problem is that Android doesn't have awesome "gesturestart/change/end" events which are in iOS. So yes, you can steal it from Photo Browser, which is by already realized on Swiper there, but it will not work on Android. If you need it on Android, you probably need to use Hammer.js which has custom cross-browser implementation of gestures


Results intepretation for HTS ranking

Hi,
Thanks for the great work. I am using DynamicBind to screen 2000 compounds. What result should I used for the ranking of compounds? I have the affinity in affinity_prediction.csv, Iddt and affinity from complete_affinity_prediction.csv.
Thanks!

I recently put together a simple script that automates this process.
It combines and ranks ligands based on these scores.
If you're interested, you can check it out here: DBSA GitHub Repo.
Hope this helps!


Port minor fixes and resolve GCC/LGTM warnings

Description
Port some minor bugfixes from skyDobby. Enable -Wall by default and resolve a number of GCC and LGTM warnings.
Test Procedure
Ensure basic functionality of Dobby and other components is not affected.
Type of Change

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Other (doesn't fit into the above categories - e.g. documentation updates)

Requires Bitbake Recipe changes?

[ ] The base Bitbake recipe (meta-rdk-ext/recipes-containers/dobby/dobby.bb) must be modified to support the changes in this PR (beyond updating SRC_REV)

Blackduck scan failure details
Summary: 0 violations, 0 files pending approval, 1 file pending identification.

Protex Server Path: /home/blackduck/github/Dobby/95/rdkcentral/Dobby

Commit: bcb477b78eaac2cf51289e19c323399228e01e1e

Report detail: gist


Fix some typos in docs

Thanks for all the work! Just noticed some typos while implementing ;)

Thanks!


End of carousel and resize with decimal value for slides to show

when slidesToShow is decimal value ie 3.5 we show 3 and 1/2 of a slide when we are at the end of the carousel and resize we get blank carousel. Also in some cases the order of the slides are not correct.
https://jsfiddle.net/earlyster/q1qznouw/321/

@kenwheeler whats the word on floating point slidesToShow ? I never even considered this before...

I mean, its not officially supported, but even i've used it as a workaround.

Will you accept this pull request?

I have to test it thoroughly first

Thanks!


use PaintingStyle.stroke for border

something's wrong with this or I'm not understanding it correctly. When drawing 2 RRects of same size, border is too far out. Create minimal example and file an issue to Flutter.

Aha, stroke is going along the edge and painting half of width out and half of width in the shape


Avalonia.Headless.NUnit.AvaloniaTestAttribute is missing constructors from base class

Describe the bug
I want to use AvaloniaTestAttribute from Avalonia.Headless.NUnit to identify test cases for my NUnit tests, but it is missing the constructors from its base class (NUnit.Framework.TestCaseAttribute) so I can't pass any arguments to it.
To Reproduce
Attempt to write a test with AvaloniaTestAttribute, e.g.
[TestFixture]
public class Tests
{
    [AvaloniaTest(1, 2, 3)]
    public void Test(int arg1, int arg2, int expected)
    {
        int result = arg1 + arg2;
        Assert.AreEqual(expected, result);
    }
}

This causes error CS1729: 'AvaloniaTestAttribute' does not contain a constructor that takes 3 arguments.
Expected behavior
This code should compile and run successfully. AvaloniaTestAttribute should include the following constructors.
        public AvaloniaTestAttribute(params object?[]? arguments) : base(arguments) { }
        public AvaloniaTestAttribute(object? arg) : base(arg) { }
        public AvaloniaTestAttribute(object? arg1, object? arg2) : base(arg1, arg2) { }

Desktop (please complete the following information):

OS: Windows 11
Version 11.0.0-rc1.1

Alternatively, maybe what was intended is that AvaloniaTestAttribute extends TestAttribute (note TestCaseAttribute)? So it would be used in conjunction with TestCaseAttribute like this:
    [AvaloniaTest]
    [TestCase(1, 2, 3)]
    public void Test(int arg1, int arg2, int expected)

maybe what was intended is that AvaloniaTestAttribute extends TestAttribute

Yes, it was this mistake. Interesting that it still works without any parameters.
For test cases there is a separated AvaloniaTheoryAttribute attribute.

Yes, it was this mistake. Interesting that it still works without any parameters. For test cases there is a separated AvaloniaTheoryAttribute attribute.

So is it just a matter of changing
https://github.com/AvaloniaUI/Avalonia/blob/dc9b47b9bef586b404e04372bbd4bb47cd14f3fb/src/Headless/Avalonia.Headless.NUnit/AvaloniaTest.cs#L16
to
public sealed class AvaloniaTestAttribute : TestAttribute, IWrapSetUpTearDown

?

Yes


Make production name explicit when name and altNames are both AGL-compliant

Would it be possible to explicitly populate the production field in GlyphsData.xml when name and altNames are both according to the AGL syntax? If the production name was explicit in the data, consumers of GlyphsData.xml won’t have to guess which one to use.
<glyph name="f_f" category="Letter" subCategory="Ligature" script="latin" altNames="uniFB00" description="LATIN SMALL LIGATURE FF" />
<glyph name="f_f_i" category="Letter" subCategory="Ligature" script="latin" altNames="uniFB03" description="LATIN SMALL LIGATURE FFI" />
<glyph name="f_f_l" category="Letter" subCategory="Ligature" script="latin" altNames="uniFB04" description="LATIN SMALL LIGATURE FFL" />
<glyph name="longs_t" category="Letter" subCategory="Ligature" script="latin" altNames="uniFB05" description="LATIN SMALL LIGATURE LONG S T" />
<glyph name="s_t" category="Letter" subCategory="Ligature" script="latin" altNames="uniFB06" description="LATIN SMALL LIGATURE ST" />

If there is not production field, use the name as is.

Thanks for the explanation, will do that.


[Design QA] Extend Connected Wallet Component on Top Nav

Connected Wallet and balance component should extend with screen and keep an 8px space from the the menu button (also 8px distance between network and balance)
Devs: attached are different screens sizes with the current problem:

Design:

Fixed.


install lua-requests fails du to internal server error

Lua-requests has a MD5 dependencies.
I can't install md5 (nor lua-requests) du to an internal server error.

Error: Failed installing dependency: https://luarocks.org/md5-1.3-1.rockspec - Error fetching file: Failed downloading https://luarocks.org/md5-1.3-1.rockspec -
HTTP/1.1 500 Internal Server Error
HTTP/1.1 500 Internal Server Error
HTTP/1.1 500 Internal Server Error

their server seems to work again, gonna close this issue


chore: move to npm-run-all2

This switches npm-run-all (used in watch scripts) to the drop-in replacement, npm-run-all2.
This package provides the same binaries but is actively maintained, with security updates and a leaner install size (the original has long been inactive).
Do let me know if you have any concerns

Thanks for this PR, but we do not accept PRs that touch  the yarn.lock file from contributors.

Thanks for this PR, but we do not accept PRs that touch the yarn.lock file from contributors.

what's the process for this normally? a maintainer would need to do it?
i can open and issue instead if that's the case, just let me know.

Yes, a maintainer would need to do it. Thanks


support glyph ids

Is your feature request related to a problem? Please describe.
I'm using a german client. Whenever I use the WoWSims Exporter Addon, there is no information about glyphs contained ("glyphs":{"major":[],"minor":[]}. Everytime I import my character, I have to manually adjust the glyphs again.
After digging into the issue, I found the problem at line 75 in WowSimsExporter.lua:
			local name, _ = string.match(link,"Glyph of .+]")
			if(name) then
				local formattedName = name:gsub('%]', '')

In German, the Glyph of Holy Light is named Glyphe 'Heiliges Licht'.
However, as far as I can tell the AddOn and the website use the string names of glyphs. So in order to support another lanugage, one would need to translate every glyph name.
Describe the solution you'd like
In order to fix this, you can support glyphs by id analogous to how ids are used for enchants and gems already. This would allow for easy support of other languages, since we don't even need to extract the name at all.
Describe alternatives you've considered
I've considered two other possible solutions:

Support trnaslation support for glyüphs
Give me an option not to overwrite glyphs with every import

I've been digging deeper, and it seems this feature request could require very little change.
/ui/core/components/importers.ts
		const glyphsConfig = classGlyphsConfig[charClass];
		const majorGlyphIDs = importJson['glyphs']['major'] as Array<string>).map(glyphName => glyphNameToID(glyphName, glyphsConfig.majorGlyphs));
		const minorGlyphIDs = (importJson['glyphs']['minor'] as Array<string>).map(glyphName => glyphNameToID(glyphName, glyphsConfig.minorGlyphs));

Here we can remove the code getting a glyph's id from its name, since we can pass the id in the export string directly.
		local enabled, glyphType, glyphTooltipIndex, glyphSpellID, icon = GetGlyphSocketInfo(t);
		local link = GetGlyphLink(t);

		if(enabled) then

			local name, _ = string.match(link,"Glyph of .+]")
			if(name) then
				local formattedName = name:gsub('%]', '')

				if(glyphType == 1 ) then-- major
					table.insert(major, formattedName)
				else if(glyphType == 2 ) then -- minor
					table.insert(minor, formattedName)
				end
			end

		end

In this file, we could simplfy the loop with id export - I'd propose something like this:
		local enabled, glyphType, glyphTooltipIndex, glyphSpellID, icon = GetGlyphSocketInfo(t);
		local link = GetGlyphLink(t);

		if(enabled) then
				if(glyphType == 1 ) then-- major
					table.insert(major, glyphSpellID)
				else if(glyphType == 2 ) then -- minor
					table.insert(minor, glyphSpellID)
				end
			end

		end

I'm sorry that I'm too inexperienced with go and lua to do a proper pull request on this, but I hope you will consider it! Thanks

Yeah this should be feasible. Note that in your proposed change, you still have to do one translation because GetGlyphSocketInfo returns spell IDs, not item IDs. We can just translate either the name or the spell ID to the item ID, and we can keep it backwards compatible.

Thank you for the quick reply and your work!
This will increase the usability greatly for gamers with localized clients.


Multiple pipelines

Hey, awesome package.
Have you considered adding the ability to trigger different pipelines?

Thanks for the feedback, currently you can only use one workflow at the same time but it would be a nice idea.

Thanks for the feedback, currently you can only use one workflow at the same time but it would be a nice idea.

This would be a neat feature to have! We currently have multiple sites relying on the same strapi server.

Hey.. Your plugin is really awesome.
We would also have the need for the feature to trigger different pipelines. Are there any news about it? For us it would be sufficient to change the workflow within the settings page :)
Thanks and BR

@everythinginjs do you have any news regarding this feature?
It would be really crucial for us to have such possibility!
Thanks a lot in advance.


Use sortedKeys option for JSON encoder

A test case in CodableContextTests produced a failure here on Xcode 15.0.1, emitting a JSON document with different order of keys. Using the .sortedKeys option on JSONEncoder should help getting the same result on all machines.

          1 Error

:no_entry_sign:
Any changes to library code need a summary in the Changelog.

  Generated by :no_entry_sign: Danger


plz can i stop circle swipe

when i am at the last image, on scrolling it finish
doesnt return at the first image
help me plz
thnx

try my library @leonid-Kiev https://github.com/jjhesk/LoyalNativeSlider


bit and

hello, wonderful project, thanks for the project.
I have a question. you have this line in your code:
return get_script().new((value & mask & (~effect.mask)) | (effect.value & effect.mask), mask | effect.mask)
and In my opiniton, mask always contains value , so value & mask is always the same as value! that is , you can use following code to replace previous code.
return get_script().new((value  & (~effect.mask)) | (effect.value), mask | effect.mask)
Is this right?

Yes, may be I say it unclearly. What I mean is,
value & mask is always the same as value
if value bit is 1, then mask bit must be 1. if value bit 0, mask bit can be 1 or 0. So
1 & 1  = 1,  0 &(anything) is 0
that is,
value & mask is always the same as value!

You're right, this operation is useless if value and mask are correctly set ("value and not mask" should be 0) which cannot be guaranteed. So if the user fails to define his action correctly, the state will still be correct.

ok got it.


New release?

Thanks for accepting my PR.  However, can you do a new release?
The v1.1.0 release is broken.  Master is now fixed but there is no tag for it.  So this module will still not work in xcaddy or really even in go...
All that is needed is for someone to tag what is currently on master with a new version number.

I am busy today, maybe @danlsgiga will have a chance before I do.
In the meantime there's absolutely no reason you can't use master or cb329a5c3ab0a49b8e8fee1cccb3fa621ef1902b (the latest commit, currently) to build from.

I am busy today, maybe @danlsgiga will have a chance before I do.
In the meantime there's absolutely no reason you can't use master or cb329a5c3ab0a49b8e8fee1cccb3fa621ef1902b (the latest commit, currently) to build from.

Thanks for bringing this up @rayjlinden. I've tagged v1.1.1!

Thanks for bringing this up @rayjlinden. I've tagged v1.1.1!


Make entity recognizers to be simple Recognizer

Fixes #3039
Description

EntityRecognizers are simple wrappers around TextAnalytics APIs, but currently are only usable from within RegExRecognizer via the EntityRecognizerSet.
This delta makes all EntityRecognizers full blown recognizers, allowing them to be composed like any other recognizer in the system.
Specific Changes

Make EntityRecognizer class
Added ChannelMentionEntityRecognizer
Exposed EntityRecognizerSet in AdaptiveComponentRegistration
Updated @microsoft/recognizers-text-suite to latest version
Renamed protected method recognize in all EntityRecognizers to avoid conflicts with recognize method from parent EntityRecognizer

Testing

Ported tests from C#.

Pull Request Test Coverage Report for Build 391469847

0 of 0   changed or added relevant lines in 0 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage increased (+0.1%) to 84.864%

Files with Coverage Reduction
New Missed Lines
%

libraries/botbuilder-dialogs-adaptive/src/recognizers/entityRecognizers/entityRecognizerSet.ts
1
91.18%

Totals

Change from base Build 382585824:
0.1%

Covered Lines:
17419

Relevant Lines:
19599

💛  - Coveralls


Fix weightlessness status effect appearing only after something checks if an entity is weightless

The one on space-wizards/space-station-14#2384 only appears after IsWeightless is called once.

Ready for review.


workflow fails on Run actions/setup-node@v1

Associated GitHub Community ticket: https://github.community/t/ci-started-to-fail-on-run-actions-setup-node-v1/131883
The customer is using CI workflow to generate NPM package. Recently, the workflow started to fail when running actions/setup-node@v1 .
The customer said that they did not changed any configurations of workflow.
The following is the error message:
Run actions/setup-node@v1
  with:
    node-version: 12
    registry-url: https://npm.pkg.github.com/
    scope: @ierp-ai
    always-auth: false
##[error]No such file or directory
##[debug]System.ComponentModel.Win32Exception (2): No such file or directory
##[debug]   at System.Diagnostics.Process.ForkAndExecProcess(String filename, String[] argv, String[] envp, String cwd, Boolean redirectStdin, Boolean redirectStdout, Boolean redirectStderr, Boolean setCredentials, UInt32 userId, UInt32 groupId, UInt32[] groups, Int32& stdinFd, Int32& stdoutFd, Int32& stderrFd, Boolean usesTerminal, Boolean throwOnNoExec)
##[debug]   at System.Diagnostics.Process.StartCore(ProcessStartInfo startInfo)
##[debug]   at System.Diagnostics.Process.Start()
##[debug]   at GitHub.Runner.Sdk.ProcessInvoker.ExecuteAsync(String workingDirectory, String fileName, String arguments, IDictionary`2 environment, Boolean requireExitCodeZero, Encoding outputEncoding, Boolean killProcessOnCancel, Channel`1 redirectStandardIn, Boolean inheritConsoleHandler, Boolean keepStandardInOpen, Boolean highPriorityProcess, CancellationToken cancellationToken)
##[debug]   at GitHub.Runner.Common.ProcessInvokerWrapper.ExecuteAsync(String workingDirectory, String fileName, String arguments, IDictionary`2 environment, Boolean requireExitCodeZero, Encoding outputEncoding, Boolean killProcessOnCancel, Channel`1 redirectStandardIn, Boolean inheritConsoleHandler, Boolean keepStandardInOpen, Boolean highPriorityProcess, CancellationToken cancellationToken)
##[debug]   at GitHub.Runner.Worker.Handlers.DefaultStepHost.ExecuteAsync(String workingDirectory, String fileName, String arguments, IDictionary`2 environment, Boolean requireExitCodeZero, Encoding outputEncoding, Boolean killProcessOnCancel, Boolean inheritConsoleHandler, CancellationToken cancellationToken)
##[debug]   at GitHub.Runner.Worker.Handlers.NodeScriptActionHandler.RunAsync(ActionRunStage stage)
##[debug]   at GitHub.Runner.Worker.ActionRunner.RunAsync()
##[debug]   at GitHub.Runner.Worker.StepsRunner.RunStepAsync(IStep step, CancellationToken jobCancellationToken)
##[debug]Finishing: Run actions/setup-node@v1

I also tested the setup-node v1 action with the similar inputs on my side, but did not reproduce the issue. The action can work fine without any errors.

Adding some details to this

We started hitting this issue some time at night thursday september 10th
We are using self-hosted runners, on ubuntu 18.04
We see the problem for multiple marketplace as well as custom actions, e.g. also "setup-java"
Forcing the runnings back onto the previous version 2.273.0 seems to make it work again, but since they are auto-upgraded it is not a useful workaround
It seems like there is a race condition involved as it will work sometimes, but not very often. Stomach feeling is it fails >90% of the time
it becomes a bigger problem because you cannot re-run a single job, only all of them

Let me know what other details you need


Fix Crash - Check if PostRegistry is enabled before using it.

The PostRegistry is supposed to be optional according to the README, but the Enabled flag wasn't being checked in the Like and Block handlers in event_calbacks.go, which caused segmentation faults.

As I've learned more about this code it seems the graph file feature was deprecated and the database is now required. Therefore this change is unnecessary and I am withdrawing the PR.


[bug]await joypad on actor <>^v issues

when you put await joypad on an actor with any of the directions you still require the a button to be pressed to make the code run
i expected that the script would run when the player collided with the actor with the dpad inputs, i image this has to do with how the player moves? i dont think its designed to work this way, but this could be helpful in rpg games that have actors like cacti that deal damage to the player or spiky roaming actors, without the need for crazy background code
running
Windows
version 1.1 release

I feel like this is the same as Issue #167. (Or, at least, could be solved by it.)

Actor scripts only fire when interacted with, not a bug, but a feature request

Pause script until only <>^v are selected, still requires a pressed first even if a isn't selected as an option, doesn't seem intended to me that is why I put it as a bug


tsdb: use roaring bitmap as MemPostings implement

Warning: this patch has very very bad performance. blame RoaringBitmap's interface based API
prometheus's tsdb uses u64 array as posting list implementation.
Those arrays will use huge memory when loading chunks. the bench:
BenchmarkRoaringMemoryUsage/list-8     38 31332405 ns/op     240222274 B/op    22 allocs/op   = 229.093813 MiB/op
BenchmarkRoaringMemoryUsage/roaring-8  7  155508017 ns/op    7024749   B/op    3296 allocs/op = 6.6993227  MiB/op

use roaring bitmap as a postlist implement will save a lot of memory.
https://github.com/RoaringBitmap/roaring/issues/228
will fix https://github.com/prometheus/prometheus/issues/7483 and https://github.com/prometheus/prometheus/issues/5547 and a lot
full bench

goos: linux
goarch: amd64
pkg: github.com/prometheus/prometheus/tsdb/index
BenchmarkIntersect
BenchmarkIntersect/LongPostings1
BenchmarkIntersect/LongPostings1-8         	 9544412	       119 ns/op	      96 B/op	       2 allocs/op
BenchmarkIntersect/LongPostings2
BenchmarkIntersect/LongPostings2-8         	10448314	       108 ns/op	      96 B/op	       2 allocs/op
BenchmarkIntersect/ManyPostings
BenchmarkIntersect/ManyPostings-8          	    1772	    624165 ns/op	      32 B/op	       1 allocs/op
BenchmarkRoaring
BenchmarkRoaring/LongPostings1_roaring
BenchmarkRoaring/LongPostings1_roaring-8   	   19692	     60626 ns/op	    2480 B/op	     113 allocs/op
BenchmarkRoaring/LongPostings2_roaring
BenchmarkRoaring/LongPostings2_roaring-8   	       3	 345627385 ns/op	   11200 B/op	     347 allocs/op
BenchmarkRoaring/ManyPostings_roaring
BenchmarkRoaring/ManyPostings_roaring-8    	       1<PHONE_NUMBER> ns/op	16000032 B/op	  400001 allocs/op
BenchmarkPostings_Stats
BenchmarkPostings_Stats-8                  	      27	  38904193 ns/op
BenchmarkRoaringMemoryUsage
BenchmarkRoaringMemoryUsage/list
BenchmarkRoaringMemoryUsage/list-8         	      28	  43142683 ns/op	240222252 B/op	      21 allocs/op
BenchmarkRoaringMemoryUsage/roaring
BenchmarkRoaringMemoryUsage/roaring-8      	       6	 195825095 ns/op	 7024736 B/op	    3296 allocs/op
BenchmarkPostingStatsMaxHep
BenchmarkPostingStatsMaxHep-8              	      10	 118487476 ns/op

Thank you for this. Tests are currently failing.
Do we also have existing benchmarks that would be improved by this?

/funcbench tsdb

/funcbench master tsdb

/funcbench cancel

/funcbench master BenchmarkCompaction

Sorry, I am trying to launch a benchmark.

Hold on, we need to discuss more about this before we go ahead. There could be better ones. There is also this work https://github.com/prometheus/prometheus/pull/5884/ which uses 64 bit postings on disk and uses prefix compression on postings as roaring bitmaps didn't work out that well in terms of performance. And for compressions like this it would be better to implement it inside TSDB instead of importing a package for it.

Thanks for the PR btw! If any of these compressions work on par with current performance, it would be nice enhancement.

/prombench master BenchmarkCompaction

There is a mistake in the comment.
Postings.Seek() return true when the posting still has value.
https://github.com/prometheus/prometheus/blob/fe8d412ce9b7313ea5c31686d25a648aba11fc21/tsdb/block_test.go#L359-L379
the genSeries generate test data in memory, I think half of the memory consumed in generate test data.
roaring bitmap only uses a little memory and 150% slower than array when iterating.

@Sasasu would you have time to implement roaring bitmaps and prefix compression and benchmark both of them out? I am afraid the PR at the current state is not feasible.

only roaring bitmap in memory, not interest in prefix compression on disk.
I prefer to split to block first then use delta encoding + varint encoding + and some other encoding method as the on-disk structure.

I was talking about trying out roaring bitmaps and prefix compression for in-memory postings. Regarding on-disk, that discussion could continue in https://github.com/prometheus/prometheus/pull/5884 as there are other things to consider with the disk involved.

Hello @codesome , do you think we should close this in favor of #5884? Thanks!


"Make bricks" isn't possible even with adequate materials.

When forced to become enabled, process works fine.

Fixed. I #%*&@$ up a variable name.


Add AdminState Property to Virtual Network Gateway Resource Properties

Adding property AdminState to Virtual Network Gateway. This will allow users to choose which Express Route gw to use to serve traffic during Express Route gateway migration.
ARM API Information (Control Plane)
MSFT employees can try out our new experience at OpenAPI Hub  - one location for using our validation tools and finding your workflow.

Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo.  If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.
Changelog
Add a changelog entry for this PR by answering the following questions:

What's the purpose of the update?

[ ] new service onboarding
[ ] new API version
[ ] update existing version for new feature
[ ] update existing version to fix swagger quality issue in s360
[x] Other, please clarify

When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
This release is managed by networking team.
By default, Azure SDKs of all languages (.NET/Python/Java/JavaScript for both management-plane SDK and data-plane SDK, Go for management-plane SDK only ) MUST be refreshed with/after swagger of new version is published. If you prefer NOT to refresh any specific SDK language upon swagger updates in the current PR, please leave details with justification here.

Contribution checklist (MS Employees Only):

[x] I commit to follow the Breaking Change Policy of "no breaking changes"
[x] I have reviewed the documentation for the workflow.
[x] Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist

Applicability: :warning:
If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

Change to data plane APIs
Adding new properties
All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

[ ] Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review.  Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.

Adding a new service
Adding new API(s)
Adding a new API version
-[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.

[ ] Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

[ ] If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist
If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.
NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)
Please follow the link to find more details on PR review process.

@nimaller  is this pr ready for review ?

@JackTn Yes, it is ready for review

/azp run

@JackTn could you please review?

@nimaller   Can you add headers that to fix model validation https://github.com/Azure/azure-rest-api-specs/pull/23978#issuecomment-1546479311

/azp run

@nimaller did you need merge this pr now ?

@JackTn yes please

@JackTn yes please

@msyyc take a look on this pr and help to merge it, Thanks

@nimaller Please remove the label before we merge:

@tadelesh @qiaozha Please help confirm SDK breaking

@tadelesh @qiaozha Please help confirm SDK breaking

No breaking for Go. Removed the label.

@JackTn removed tags, PR is ready to be merged.

@JackTn removed tags, PR is ready to be merged.

@msyyc


Cannot persist / load GitHub Authentication SignIn Token to macOS Ventura Beta 2 Keychain

Issue Type: Bug
Using the latest macOS 13.0 Beta (22A5286j), I experience an issue / bug that reloading Window or restarting logs me out of all the extensions, e.g. Copilot, Settings Sync, Github Issues & Pull Request.
VS Code version: Code - Insiders 1.69.0-insider (668c538b8d2fec1258ed786ae212124d6d68023c, 2022-06-23T05:16:19.393Z)
OS version: Darwin arm64 22.0.0
Restricted Mode: No

System Info

Item
Value

CPUs
Apple M1 Max (10 x 24)

GPU Status
2d_canvas: enabledcanvas_oop_rasterization: disabled_offdirect_rendering_display_compositor: disabled_off_okgpu_compositing: enabledmetal: disabled_offmultiple_raster_threads: enabled_onopengl: enabled_onrasterization: enabledraw_draw: disabled_off_okskia_renderer: enabled_onvideo_decode: enabledvideo_encode: enabledwebgl: enabledwebgl2: enabled

Load (avg)
7, 39, 28

Memory (System)
64.00GB (40.71GB free)

Process Argv
--crash-reporter-id 092694b8-f2ad-4473-8608-b513d685cc96

Screen Reader
no

VM
0%

Extensions (16)

Extension
Author (truncated)
Version

iconify
ant
0.3.3

vscode-eslint
dba
2.2.2

gitlens-insiders
eam
2022.6.2205

prettier-vscode
esb
9.5.0

copilot-labs
Git
0.1.176

copilot-nightly
Git
1.30.6180

vscode-pull-request-github
Git
0.44.0

better-shellscript-syntax
jef
1.1.0

i18n-ally
lok
2.8.1

vscode-docker
ms-
1.22.0

remote-containers
ms-
0.240.0

vscode-github-issue-notebooks
ms-
0.0.119

material-icon-theme
PKi
4.18.1

fortnite-vscode-theme
sdr
1.3.0

svelte-vscode
sve
105.17.0

windicss-intellisense
voo
0.23.5

(4 theme extensions excluded)

A/B Experiments
vsliv695:30137379
vsins829:30139715
vsliv368:30146709
vsreu685:30147344
python383cf:30185419
vspor879:30202332
vspor708:30202333
vspor363:30204092
vslsvsres303:30308271
pythonvspyl392:30422396
pythontb:30258533
vsc_aa:30263845
pythonptprofiler:30281269
vshan820:30294714
pythondataviewer:30285072
vscod805:30301674
bridge0708:30335490
bridge0723:30353136
vsaa593:30376534
pythonvs932:30404738
wslgetstarted:30449409
vscscmwlcmt:30465136
cppdebug:30492333
pylanb8912:30496796
vsclangdf:30492506
c4g48928:30513948

A asked y'all nicely
On Thu, Jun 23, 2022, 6:14 AM Alexander Niebuhr @.***>
wrote:

Issue Type: Bug
Using the latest macOS 13.0 Beta (22A5286j), I experience an issue that
reloading Window or restarting logs me out of all the extensions, e.g.
Copilot, Settings Sync, Github Issues & Pull Request.
VS Code version: Code - Insiders 1.69.0-insider (668c538
https://github.com/microsoft/vscode/commit/668c538b8d2fec1258ed786ae212124d6d68023c,
2022-06-23T05:16:19.393Z)
OS version: Darwin arm64 22.0.0
Restricted Mode: No
System Info
Item Value
CPUs Apple M1 Max (10 x 24)
GPU Status 2d_canvas: enabled
canvas_oop_rasterization: disabled_off
direct_rendering_display_compositor: disabled_off_ok
gpu_compositing: enabled
metal: disabled_off
multiple_raster_threads: enabled_on
opengl: enabled_on
rasterization: enabled
raw_draw: disabled_off_ok
skia_renderer: enabled_on
video_decode: enabled
video_encode: enabled
webgl: enabled
webgl2: enabled
Load (avg) 7, 39, 28
Memory (System) 64.00GB (40.71GB free)
Process Argv --crash-reporter-id 092694b8-f2ad-4473-8608-b513d685cc96
Screen Reader no
VM 0% Extensions (16)
Extension Author (truncated) Version
iconify ant 0.3.3
vscode-eslint dba 2.2.2
gitlens-insiders eam 2022.6.2205
prettier-vscode esb 9.5.0
copilot-labs Git 0.1.176
copilot-nightly Git 1.30.6180
vscode-pull-request-github Git 0.44.0
better-shellscript-syntax jef 1.1.0
i18n-ally lok 2.8.1
vscode-docker ms- 1.22.0
remote-containers ms- 0.240.0
vscode-github-issue-notebooks ms- 0.0.119
material-icon-theme PKi 4.18.1
fortnite-vscode-theme sdr 1.3.0
svelte-vscode sve 105.17.0
windicss-intellisense voo 0.23.5
(4 theme extensions excluded)
A/B Experiments
vsliv695:30137379
vsins829:30139715
vsliv368:30146709
vsreu685:30147344
python383cf:30185419
vspor879:30202332
vspor708:30202333
vspor363:30204092
vslsvsres303:30308271
pythonvspyl392:30422396
pythontb:30258533
vsc_aa:30263845
pythonptprofiler:30281269
vshan820:30294714
pythondataviewer:30285072
vscod805:30301674
bridge0708:30335490
bridge0723:30353136
vsaa593:30376534
pythonvs932:30404738
wslgetstarted:30449409
vscscmwlcmt:30465136
cppdebug:30492333
pylanb8912:30496796
vsclangdf:30492506
c4g48928:30513948
—
Reply to this email directly, view it on GitHub
https://github.com/microsoft/vscode/issues/152964, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AYYXGWRMUNZ4IDBAFCFODW3VQRBJPANCNFSM5ZT6XO3A
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

I'm experiencing the same. Same log messages, also on the MacOS Beta.

I have same issue. Any way for fix it?

I tried to login with a different Macbook and transferring the token manually to the keychain. Even this made it possible to get a prompt, it still breaks with the same error. Therefore I expect some changes in the behaviour the keychain is working, and VSCode might to adapt. :(

I'm suspicious of this new Passkeys feature in Ventura:

which mentions iCloud Keychain...
I don't have a machine with Ventura on it, but we use http://github.com/atom/node-keytar for this interaction so we should get an issue going there.

I was seeing the same thing on Ventura. Troubleshooting attempts that didn't work:

Deleting VSCode's GitHub auth in Keychain Access, then signing in again.
Disconnecting VSCode from my authorized apps on GitHub, then signing in again.
Clearing VSCode's caches in ~/Library/Application Support/Code, then signing in again.

if you have nodejs installed, you can run this simple one-liner to see if the problem is how your keychain is setup:
npx @emacs-grammarly/keytar-cli find-creds -s vscode-insidersvscode.github-authentication

This is using the following open source package: https://github.com/emacs-grammarly/keytar-cli
What you should get is something like this:
[
  {
    account: 'github.auth',
    password: '....... longggg string ......'
  }
]

NOTE: on macOS I got a system prompt to allow this process to access the keychain... that may or may not be the case for you

If that succeeds, then the problem is possibly in vscode.
If that does complain, then we'll need a fix in keytar itself.

@TylerLeonhardt I can both get and set values with keytar-cli and they do show up in the Keychain Access utility.

In addition to the error message initially reported in the "GitHub Authentication" output, I'm seeing this in "Log (main)":

[2022-06-24 23:03:25.187] [main] [warning] Error attempting to set a password:  Password is required.
[2022-06-24 23:03:25.388] [main] [warning] Error attempting to set a password:  Password is required.
[2022-06-24 23:03:25.592] [main] [warning] Error attempting to set a password:  Password is required.

@TylerLeonhardt

If that succeeds, then the problem is possibly in vscode.

@TylerLeonhardt I can both get and set values with keytar-cli and they do show up in the Keychain Access utility.

Being the same behaviour as @rotu. Using suggested package keytar-cli, gives the following outputs
alexanderniebuhr@Alexanders-MBP ~ % npx @emacs-grammarly/keytar-cli find-creds -s vscode-insidersvscode.github-authentication
[ { account: 'github.auth', password: 'ASD' } ]
alexanderniebuhr@Alexanders-MBP ~ % npx @emacs-grammarly/keytar-cli set-pass -s vscode-insidersvscode.github-authentication -a github.auth -p TEST
Successfully set the password for<EMAIL_ADDRESS>alexanderniebuhr@Alexanders-MBP ~ % npx @emacs-grammarly/keytar-cli find-creds -s vscode-insidersvscode.github-authentication
[ { account: 'github.auth', password: 'TEST' } ]

Even using the package atom/node-keytar in a demo project works. Therefore I really think there is some issue in VSCode. Can we get some higher priority on this?

@TylerLeonhardt I can't even figure out how to debug this. Building and running VSCode from source does not load the vscode.github-authentication extension. How do I a debugger on this in OSS VSCode?

@rotu it's because there's nothing in OSS that uses auth.
You can debug it by either side-loading a GH extension (download VSIX on the marketplace and then in OSS go to the extension pane and hit the three dots to Install from VSIX)
Or just add a SecretStorage usage in any of the built in extensions. Secrets is in the ExtensionContext

So far no dice. It seems the OSS version works just fine with persisting authentication. Unlike the distributed VSCode (both stable and insiders), OSS is able to write to the system keychain.

@rotu so using a version you built from source of this repo does work, while the distributed version (which I thought is also built from the repo) does not work?

@alexanderniebuhr that is correct.

Knowing this, I wonder if this could be a problem with App Signing. Since the distributed one is probably signed differently.
@TylerLeonhardt, what do you think? Any update from VSCode Team?

Not sure if that works, but some output if running VSCode with --verbose flag
[main 2022-06-26T17:35:44.762Z] menubarService#updateMenubar 1
[2567:0626/193545.621575:INFO:CONSOLE(602)] "%cTRACE color: #888 onWillActivateByEvent:  onAuthenticationRequest:github", source: vscode-file://vscode-app/Applications/Visual%20Studio%20Code%20-%20Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js (602)
[2567:0626/193545.623188:INFO:CONSOLE(602)] "%cTRACE color: #888 DialogService#show The extension 'GitHub Copilot Nightly' wants to sign in using GitHub.", source: vscode-file://vscode-app/Applications/Visual%20Studio%20Code%20-%20Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js (602)
[main 2022-06-26T17:35:49.776Z] app#handleURL:  REPLACED_FOR_PRIVACY {
  originalUrl: 'REPLACED_FOR_PRIVACY'
}
[main 2022-06-26T17:35:49.777Z] app#handleURL: windowOpenableFromProtocolLink =  undefined
[main 2022-06-26T17:35:49.822Z] ExtensionUrlTrustService#isExtensionUrlTrusted There are no configured trusted keys
[2567:0626/193549.827670:INFO:CONSOLE(602)] "%cTRACE color: #888 CommandService#executeCommand workbench.getCodeExchangeProxyEndpoints", source: vscode-file://vscode-app/Applications/Visual%20Studio%20Code%20-%20Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js (602)
[main 2022-06-26T17:35:50.033Z] menubarService#updateMenubar 1
[main 2022-06-26T17:35:50.641Z] Error attempting to set a password:  Password is required.
[main 2022-06-26T17:35:50.809Z] update#checkForUpdates, state =  idle
[main 2022-06-26T17:35:50.810Z] update#setState checking for updates
[main 2022-06-26T17:35:50.847Z] Error attempting to set a password:  Password is required.
[main 2022-06-26T17:35:51.052Z] Error attempting to set a password:  Password is required.
[main 2022-06-26T17:35:51.094Z] update#setState idle
[2567:0626/193551.266835:INFO:CONSOLE(602)] "%cTRACE color: #888 Settings Sync: Getting accounts for microsoft", source: vscode-file://vscode-app/Applications/Visual%20Studio%20Code%20-%20Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js (602)
[2567:0626/193551.276541:INFO:CONSOLE(602)] "%cTRACE color: #888 onWillActivateByEvent:  onAuthenticationRequest:github", source: vscode-file://vscode-app/Applications/Visual%20Studio%20Code%20-%20Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js (602)
[2567:0626/193551.280980:INFO:CONSOLE(602)] "%cTRACE color: #888 Settings Sync: Updated accounts for microsoft", source: vscode-file://vscode-app/Applications/Visual%20Studio%20Code%20-%20Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js (602)
[2567:0626/193551.281380:INFO:CONSOLE(602)] "%cTRACE color: #888 Settings Sync: Getting accounts for github", source: vscode-file://vscode-app/Applications/Visual%20Studio%20Code%20-%20Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js (602)
[2567:0626/193551.283427:INFO:CONSOLE(602)] "%cTRACE color: #888 Settings Sync: Updated accounts for github", source: vscode-file://vscode-app/Applications/Visual%20Studio%20Code%20-%20Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js (602)
[2567:0626/193551.284187:INFO:CONSOLE(602)] "%cTRACE color: #888 onWillActivateByEvent:  onAuthenticationRequest:github", source: vscode-file://vscode-app/Applications/Visual%20Studio%20Code%20-%20Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js (602)
[2567:0626/193551.600546:INFO:CONSOLE(602)] "%cTRACE color: #888 CommandService#executeCommand setContext", source: vscode-file://vscode-app/Applications/Visual%20Studio%20Code%20-%20Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js (602)
[2567:0626/193552.018763:INFO:CONSOLE(31)] "%cTRACE color: #888 [code cache cleanup]: Starting to clean up old code cache folders.", source: vscode-file://vscode-app/Applications/Visual%20Studio%20Code%20-%20Insiders.app/Contents/Resources/app/out/vs/code/electron-browser/sharedProcess/sharedProcessMain.js (31)
[2567:0626/193552.020051:INFO:CONSOLE(31)] "%cTRACE color: #888 [storage cleanup]: Starting to clean up storage folders.", source: vscode-file://vscode-app/Applications/Visual%20Studio%20Code%20-%20Insiders.app/Contents/Resources/app/out/vs/code/electron-browser/sharedProcess/sharedProcessMain.js (31)
[2567:0626/193552.020889:INFO:CONSOLE(31)] "%cTRACE color: #888 [storage cleanup]: Deleting workspace storage folder<PHONE_NUMBER>632.", source: vscode-file://vscode-app/Applications/Visual%20Studio%20Code%20-%20Insiders.app/Contents/Resources/app/out/vs/code/electron-browser/sharedProcess/sharedProcessMain.js (31)
[2567:0626/193552.020932:INFO:CONSOLE(31)] "%cTRACE color: #888 [storage cleanup]: Deleting workspace storage folder<PHONE_NUMBER>296.", source: vscode-file://vscode-app/Applications/Visual%20Studio%20Code%20-%20Insiders.app/Contents/Resources/app/out/vs/code/electron-browser/sharedProcess/sharedProcessMain.js (31)
[2567:0626/193552.021956:INFO:CONSOLE(31)] "%c  ERR color: #f33 [uncaught exception in sharedProcess]: A system error occurred (EACCES: permission denied, unlink '/Users/alexanderniebuhr/Library/Application Support/Code - Insiders/User/workspaceStorage/1655991696632/state.vscdb.backup'): Error: EACCES: permission denied, unlink '/Users/alexanderniebuhr/Library/Application Support/Code - Insiders/User/workspaceStorage/1655991696632/state.vscdb.backup'", source: vscode-file://vscode-app/Applications/Visual%20Studio%20Code%20-%20Insiders.app/Contents/Resources/app/out/vs/code/electron-browser/sharedProcess/sharedProcessMain.js (31)

Okay, I found an interesting workaround. Using the x64 Intel published version of VSCode stable, does save and load successfully from the keychain.
@rotu @phyllisstein @und3fined could you verify that for your case too?
If that is true, it seams that there is something broken with the Apple Silicon version :/

Also, if you're in need of a workaround, the Settings Sync Extension appears to still work

Alright @TylerLeonhardt I made some progress but I think I'm at the end of my debugging abilities, and the problem lies in the native vscode-encrypt service. I think the issue is here, where await this.encryptionService.encrypt is getting a valid JSON object but returning "":
https://github.com/microsoft/vscode/blob/c22cb87311b5eb1a3bf5600d18733f7485355dc0/src/vs/workbench/api/browser/mainThreadSecretState.ts#L83-L84
It seems like the EncryptionService

@alexanderniebuhr thank for workaround. It's auth worked, but VS Code sloooowwww with Intel version.
I'll use VS Code (arm) until it fixed or Zed/Fleet released. Maybe i'll never comeback VSCode, if Zed/Fleet release

@alexanderniebuhr @und3fined, I found an even better workaround!
Simply remove the encryption module:
rm -rf /Applications/Visual Studio Code.app/Contents/Resources/app/node_modules.asar.unpacked/vscode-encrypt

@rotu Wow. it's magic =))
Note: Allow update/deteled app on Privacy & Security > App Management
With backslash command:
rm -rf /Applications/Visual\ Studio\ Code.app/Contents/Resources/app/node_modules.asar.unpacked/vscode-encrypt

@rotu your workaround does not work for me.

@rotu your workaround does not work for me.

@alexanderniebuhr, are you still using the insiders build? If so, remove vscode-encryption from that app package instead

remove vscode-encryption from that app package instead

well it allows to safe the token, but it still loses it on reload. But thanks for your help debugging this. Hope we get a fix soon.

This workaround worked for me as well, but I wonder what are the consequences of this change to the app.

Not much, I think. Keychain is a secure storage mechanism so the additional encryption seems redundant.

This workaround worked for me as well, but I wonder what are the consequences of this change to the app.

Not much, I think. Keychain is a secure storage mechanism so the additional encryption seems redundant.

I think, it's a layer of defense against other extensions

Thanks for all the info so far! It's been very helpful. We will be investigating this issue next week since we've already started our VS Code release process.

@alexanderniebuhr @und3fined, I found an even better workaround! Simply remove the encryption module:
rm -rf "/Applications/Visual Studio Code.app/Contents/Resources/app/node_modules.asar.unpacked/vscode-encrypt"

yesss it works for me as well

workaround worked for me. I was close to throwing the whole computer out the window :)

ahh the price of early adoption :)
Just keep in mind that you will need to remove this every time VS Code updates...(daily on insiders, weekly-ish on stable) and once we figure out why vscode-encrypt isn't working on this platform and it starts to work again, you'll need to relog in to everything because we are expecting what's stored in the keyring to be decryptable by vscode-encrypt.

Just keep in mind that you will need to remove this every time VS Code updates…

This is true. Hopefully this issue is resolved at the root soon. Unfortunately VS Code is not open source or else this would be fixable by the community.

you'll need to relog in to everything

I don’t think so. it looks like the logic can handle unencrypted credentials.

price of early adoption

I generously wonder why the encryption breaks on Ventura. If it used x64-specific stuff, it would have been damaged before on Apple Silicon, and I can't recall that I had read something about the deprecation of encryption-related things in the release notes by Apple. I might miss some, hidden changes.
@TylerLeonhardt to get this back in this thread. The Workaround only works in Stable for me; Insider stays broken even after applying. That could be due to a corrupted installation while debugging, but it could also hint that there are some other caveats to check for macOS Ventura.

@TylerLeonhardt can we see the fix on the latest Insiders? Or is there any particular reason you closed this?

Great. I will verify the solution and let you know!

@TylerLeonhardt actually can't verify on the latest insider. (others report this too)
I actually wonder why you have closed an issue, which is not verified fixed. I suggest reopening this issue and waiting for verification of users before closing it again.

@alexanderniebuhr thanks for verifying, we are aware of the issue as well. Currently tracked in https://github.com/microsoft/vscode/pull/154762
The issue was closed as part of fix in the module and another side effect is for our release bot to track fixes shipped in a certain insider version so that certain github actions can work https://github.com/microsoft/vscode-github-triage-actions. Issue will be closed to signal for verification and if issue persists then it will be reopened for further investigation.

@alexanderniebuhr not even sure why this issue is tracked on GitHub, since neither the buggy code nor the fix is part of the open-source codebase.

Shouldn't this issue be closed when it's confirmed fixed?
The merged fix seems to only apply to the arm64 build of VSCode, however this issue also happens on the universal insider builds, which either means that universal builds need a similar fix, or the issue is still there.

Any ETA on this coming to stable? @deepak1556

Problem fixed with Sync with Github account.
But Copilot not work. It's required re-auth.

Problem fixed with Sync with Github account. But Copilot not work. It's require re-auth.

Are you still seeing this? Because I thought the same at first too, but now it seems intermittent, as it at least stays logged in for longer periods of time now, regardless of how many times VSCode is (re)opened.

@gjsjohnmurray Is this solved in the latest insider build?


Multiple POS's with no name don't assign locations as expected

Doing some scanning and i hit a system with 4 POS's all the same type with no name set.
i set the corp on the first one i hit, and location was good but for every other one i found it reset the location on the first one i found.

Would you mind to send me a pastebin of the scan please?
Am 20. Oktober 2019 10:04:22 MESZ schrieb Aaron<EMAIL_ADDRESS>
Doing some scanning and i hit a system with 4 POS's all the same type
with no name set.
i set the corp on the first one i hit, and location was good but for
every other one i found it reset the location on the first one i found.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/chrRtg/eve-skylizer/issues/27

--
Diese Nachricht wurde von meinem Android-Mobiltelefon mit K-9 Mail gesendet.


API to parse requirements.txt for setup.py

requirements.txt could a convenient single declarative point for specifying dependencies if it could be pasted info setup.py install_requires as-is. But requirements.txt contains comments and references to other requirements files, which seem to be incompatible with install_requires (reference needed).
It would be nice to have official API that parses requirements.txt file into a list suitable for install_requires section.
https://stackoverflow.com/questions/14399534/reference-requirements-txt-for-the-install-requires-kwarg-in-setuptools-setup-py

There's also no support for environment markers in install_requires requirements (e.g. python-xlib==0.19; "linux" in sys_platform will not work), something that is handled by extras_require.
Note that install_requires can just be a multi-lines string, so if you stick to a subset of pip's requirements format that is supported by setuptools, you should be able to use something as simple as:
with open('requirements.txt') as fp:
    install_requires = fp.read()

setup(install_requires=install_requires, ...)

in your setup.py.
Also looks like a duplicate of #1074.

Note that install_requires can just be a multi-lines string

Nice. Save me a lot of time. If only I could detect when requirements.txt becomes incompatible without waiting for setup.py to fail.

so if you stick to a subset of pip's requirements format that is supported by setuptools

Are those differences documented somewhere?

Well, at the very least, setuptools should error out if environment markers are used:
 setuptools/dist.py | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git i/setuptools/dist.py w/setuptools/dist.py
index 6b97ed33..eb9e4442 100644
--- i/setuptools/dist.py
+++ w/setuptools/dist.py
@@ -153,7 +153,11 @@ def assert_bool(dist, attr, value):
 def check_requirements(dist, attr, value):
     """Verify that install_requires is a valid requirements list"""
     try:
-        list(pkg_resources.parse_requirements(value))
+        reqs = []
+        for r in pkg_resources.parse_requirements(value):
+            if r.marker:
+                raise ValueError("environment markers are not supported, in '%s'" % r)
+            reqs.append(r)
     except (TypeError, ValueError) as error:
         tmpl = (
             "{attr!r} must be a string or list of strings "

And the documentation should be fixed, as both direct install with setup.py and from the generated wheel may fail.

After inspection, environment markers do work when install from source, but not with the generated wheels, see #1081.

Agreed this is a duplicate of #1074.

 E.g. parsing/converting following from a requirements.txt file:
extras_requires={
    'extra_scope': 'somepackage >= 1.0.0'
}

#1074 needs a better title.
Also, there are two scenarios in parsing requirements.txt which add the complexity into resolution of this issue:

parsing requirements.txt just to get structured data about all package dependencies (including optional and platform specific)
parsing requirements.txt to match requirements with specific current system

2 is actually two step process, which includes step 1. But because 2 is more often needed than 1, it is mixed up together and makes API hard.

Might be a stupid question, but does pip's requirements.txt format even support named extras_requires dependencies?

@tuukkamustonen https://stackoverflow.com/a/43090648/239247 - is that it?

https://stackoverflow.com/a/43090648/239247 - is that it?

@techtonik That is for depending on named extras in other packages. I'm after being able to declare them in mine, so to say something like pip install -r requirements.txt [extra1, extra2] (like in pip install .[extra1, extra2].
So some format that I can parse from requirements.txt into setup.pys:
extras_requires={
    'extra_scope': 'somepackage >= 1.0.0'
}

@tuukkamustonen  so, you want a mechanism to specify different sets of optional dependencies? I believe it is done with tags specified in square brackets.
somepackage >= 1.0.0 [extra_scope]

https://www.python.org/dev/peps/pep-0508/#extras
https://stackoverflow.com/questions/3664478/optional-dependencies-in-a-pip-requirements-file

@techtonik That syntax just gives a parsing error (in pip 9.0.1).

@tuukkamustonen then it is a bug.

@tuukkamustonen You use setup.py to declare your package's dependencies (and extras). You use requirements.txt to install any number of packages (and their dependencies).
So if you want to declare an extra scope for your package, you do that in setup.py:
extras_require={
  'extra_scope': [
    'somepackage >= 1.0.0',
  ],
}

Then, if you want to install your package with the extra scope, you can pip install .[extra_scope] or put .[extra_scope] in your requirements.txt or if you've uploaded your package to pypi, you can pip install your_package[extra_scope] or pip install your_package[extra_scope] >= 9.0.
Does that help?

@jaraco Thanks for the write-up, but my question was if I can do that (setup_requires declaration) in requirements.txt. So to define named extras in requirements.txt.
The reason I asked this in the context of this ticket is that if I wanted to parse named extras from requirements.txt into setup_requires programmatically (even though everyone is recommending against it, but this ticket is about supporting that use case anyway), the API that this ticket suggests, should also support that. But that leads to a question if requirements.txt syntax even supports named extras.
Maybe an easier to understand use case would be this: Let's forget setup.py altogether and say that I have dev-requirements.txt which define requirements for being able to build and upload my project. In addition to that I could have test-requirements.txt and doc-requirements.txt for also being able to run tests and compile documentation.
Why would I split the dev requirements into several files? In CI (e.g. Jenkins), not every job needs all the dependencies, and maybe I want to optimize the time it takes to setup a virtualenv (let's say I'm spinning up a new Docker container for each build).
In order to avoid cluttering my repository with *-requirements.txt files, it would be fun to describe them all in one dev-requirements.txt, as in:
# Base
setuptools
twine >= 1.0.0

# Tests
pytest >= 2.0.0 [tests]

# Doc
sphinx [tests]

And then being able to run something like:
pip install -r dev-requirements.txt
pip install -r dev-requirements.txt [tests]  # yeah I don't think this is supported?
pip install -r dev-requirements.txt [doc]

I followed the syntax suggested by https://github.com/pypa/setuptools/issues/1080#issuecomment-342147121 here (but note that it gives a parsing error). According to @techtonik that's a bug. There may be some confusion here, so is it really a bug, or just feature that is not specified/supported?

requirements.txt does not support optional requirements sections. Extras are supported for asking for a requirement optional dependencies to be installed, not for declaring optional requirements themselves. For example, you can use:
pytest-runner [testing]

To include all the testing dependencies required by pytest-runner, but that's not a way to declare an optional testing requirement. The format used by requirements.txt does not support that (unlike the format used by requires.txt as part of egg-info).

So that's just not supported then. Ok. Thanks for clarifying things up.

@pganssle there is no proposal in #1074, so nothing to fix, and here I made sure that there is a proposal to make a way for programmatic access to requirements.txt files.

Note that install_requires can just be a multi-lines string, so if you stick to a subset of pip's requirements format that is supported by setuptools, you should be able to use something as simple as:
with open('requirements.txt') as fp:
    install_requires = fp.read()

setup(install_requires=install_requires, ...)

in your setup.py.
Also looks like a duplicate of #1074.

This can cause problems with hyphenated package names. It is fairly common for PyPi packages to be listed with a hyphen in their name, but for all other references to them to have underscores. An example package is pytorch-transformers, where you pip install pytorch-transformers, but when using, you import pytorch_transformers.
Because of this, you need to replace - with _. I tried to parse things myself, but after realizing that a line in requirements.txt could be a URL, or something like mymodule>1.5,<1.6, I decided that the parser I was writing must already exist... and it does, requirements-parser. So, using that, I've got:
import requirements

install_requires = []

with open('requirements.txt') as fd:
    for req in requirements.parse(fd):
        if req.name:
            name = req.name.replace("-", "_")
            full_line = name + "".join(["".join(list(spec)) for spec in req.specs])
            install_requires.append(full_line)
        else:
            # a GitHub URL doesn't have a name
            # just copy it verbatim
            install_requires.append(req.line)
setup(install_requires=install_requires, ...)
> ```

It's not pretty, and it adds a dependency, though.

Judging from https://github.com/davidfischer/requirements-parser/issues/45 the author probably would not object if requirements-parser would be merged into pypa.


cmctl renew command unable to re-generae a new CertificateRequest

Describe the bug:
Cert manager while issuing the certificates with Venafi TPP, shows the following error:
E0323 16:31:40.426122       1 controller.go:158] cert-manager/controller/certificaterequests-issuer-venafi "msg"="re-queuing item due to error processing" "error"="Unexpected status code on TPP Certificate Request.\n Status:\n 400 This CSR appears to reuse a private key.  Private key reuse has not been allowed.. \n Body:\n {\"Error\":\"This CSR appears to reuse a private key.  Private key reuse has not been allowed.\"}\n" "key"="default/app-certificate-lb7tg"

However, our certificate.yaml has been correctly set with:
privateKey:
  rotationPolicy: Always

With each request from cert-manager, the Venafi is indeed generating certificates, as can be seen here:

However, the process seems to not be picking up the newly created certs after they are generated.
Expected behaviour:
Cert-manager should successfully request & update the certificate in k8s cluster, since it Venafi has successfully generated the certificate. With rotationPolicy: Always, cert-manager should not throw this error.
Steps to reproduce the bug:
Not sure on how to reproduce this on a separate k8s cluster.
Anything else we need to know?:
Environment details::

Kubernetes version: v1.18.20-eks-8c49e2
Cloud-provider/provisioner: Venafi, EKS
cert-manager version:  cert-manager.io/v1
Install method: helm

Logs
logs_cert_manager.txt
certificate.yaml:
apiVersion: cert-manager.io/v1
kind: Certificate
metadata:
  name: app-certificate
spec:
  commonName: ..
  secretName: ..
  dnsNames:
  - ..
  issuerRef:
    name: venafi-prod-issuer
    kind: ClusterIssuer
  privateKey:
    rotationPolicy: Always

/kind bug

@irbekrm Thanks for the prompt response.
As per our yaml, we are using v1.0 (apiVersion: cert-manager.io/v1)
If there is a specific version that I need to share, can you please help me on how to find out the specific version of cert-manager ?

As per our yaml, we are using v1.0 (apiVersion: cert-manager.io/v1)

This is the cert-manager API version, you want to know what cert-manager release version you have installed.
You can find the release version either by looking at the image tags, either in cluster or in your yamls if you are sure that cluster state matches the yamls.
Or you could use cmctl version

Oh, thanks for the help. This is what cmctl version gives me:
~ cmctl version
Client Version: util.Version{GitVersion:"v1.7.1", GitCommit:"527537d0354f731ed0fa9ae91c82d1088ee00f7c", GitTreeState:"clean", GoVersion:"go1.17.1", Compiler:"gc", Platform:"darwin/amd64"}
Server Version: &versionchecker.Version{Detected:"v1.3.1", Sources:map[string]string{"crdLabelVersion":"v1.3.1", "webhookPodImageVersion":"v1.3.1", "webhookPodLabelVersion":"v1.3.1", "webhookServiceLabelVersion":"v1.3.1"}}

Also, I think we used helm_release to install cert_manager chart, like this:
resource "helm_release" "cert_manager" {
  name       = "cert-manager"
  namespace = "cert-manager"

  depends_on = [ kubernetes_namespace.cert_manager]

  repository = "https://charts.jetstack.io"
  chart      = "cert-manager"
  create_namespace = true

  values = [
    file("${path.module}/cert-manager-config.yaml")
  ]
}

It seems like, after some retries, the issue seems to have gone.
The certificate is now updated correctly in our cluster.
Happy to help you with more logs, if this seems like a legit bug?

Hi, thanks for the extra info, the cert-manager version that you have installed in cluster is v1.3.1 (v1.7.1 is the client version, in this case the version of the cmctl CLI)
I had another look at the issue description and it is not the issue that I linked earlier.
v1.3.1 is not supported anymore, so I would recommend that you upgrade to a newer supported version, preferably latest  there have been a bunch of changes to cert issuance process, so might be that the issue is already fixed in the latest version.
However, if it still happens after the upgrade, we'll need to look into it more, definitely looks like a bug to me!

Sure, I will do that in sometime, and will open a new ticket, with a reference to this one.
For now, closing this one since it is not blocking anything in our workflow.
Thanks for the help 🙏


Sprite3D displays wrong colors when displaying a ViewportTexture containing a VideoPlayer with a WebM video

Godot version:
3.2.3
OS/device including version:
GTX 1650
Issue description:
I noticed someone else asking this question but with no file example and the conversation stopped at the possibility that there
is a webm colorspace conversation error on the source video's side, so here is a direct comparison
showing the colors working perfectly and as expected in the VideoPlayer component in 2D mode but get totally screwed up useless when handled by Sprite3D.
And also notice the error report when NOT A SINGLE SCRIPT have been typed at all, I didn't even do anything !:
get_node: Node not found: Sprite3D/Viewport.
setup_local_to_scene: ViewportTexture: Path to node is invalid.
webm_bug.zip

This is probably due to sRGB conversion not being applied, being applied twice or something along those lines.

And also notice the error report when NOT A SINGLE SCRIPT have been typed at all, I didn't even do anything !:
get_node: Node not found: Sprite3D/Viewport.
setup_local_to_scene: ViewportTexture: Path to node is invalid.

This is a known bug, see https://github.com/godotengine/godot/issues/27790.

Question to @Calinou, so is using the MeshInstance node more efficient resource wise ?
Or Sprite3D is "supposed" to be the way to do it all along and it is just broken ?

Question to @Calinou, so is using the MeshInstance node more efficient resource wise ?

It's not any more efficient since 3.2.3 (https://github.com/godotengine/godot/pull/39867), but it's more flexible than Sprite3D for sure.

@Calinou...thank you, for your patience and your kindness.
I appreciate your help and your presence.


Pod identity in ztunnel could be mistaken

Describe the feature request
Sorry if this is a dup but I can't find another issue related to this.  In the very small chance scenario, it is possible pod identity in ztunnel could be mistaken when ztunnel isn't getting update from k8s API server and using a stale IP from workload xDS, as described in the blog:  https://www.solo.io/blog/could-network-cache-based-identity-be-mistaken/
This could be considered a beta blocker.  I can update the test scripts from the blog if needed to demonstrate this problem.
cc @kdorosh @bleggett to chime in additional details.
Affected product area (please put an X in all that apply)
[ x ] Ambient
[ ] Docs
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Extensions and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure
Affected features (please put an X in all that apply)
[ ] Multi Cluster
[ ] Virtual Machine
[ ] Multi Control Plane
Additional context

In the ztunnel case, this could only happen if old workload pointed to by the stale IP happened to be on the same node as the ztunnel in question. The probability is smaller, but it could probably still happen. I feel like to avoid this, ztunnel would have to get access to and utilize the service account token for the workloads. Either that or enforce a harsh ttl on the ip address xDS

IPs are not identities. They're addresses. As long as we treat them as identities the potential for this kind of problem exists.

Don't we use the IP to determine which identity ztunnel impersonates? That effectively makes it a proxy for identity

Don't we use the IP to determine which identity ztunnel impersonates? That effectively makes it a proxy for identity

Yep.
And we don't check or validate the identity of the workload with any other factor, which makes it something of a weak point.
(Though less of a weak point than other kinds of single-factor identity attestation like passwords or preshaped keys, because IPs are values that have external guarantees up to a point).

We can mitigate the mistake in some degree via checking the workload must reside in the same node as ztunnel:
For outbound: checking the original source workload, can not validate whether the dst workload is stale or not.
For inbound: checking the original dst workload(maybe during tls handshake), cannot validate the original source workload

If workload certs were guaranteed unique per-pod, this would be potentially easier to catch in-mesh with timely workload identity invalidation/revocation and crosschecking.
Both of those are likely out of the question tho, so yeah we're at the mercy of the xDS cache when it comes to matching IP<->identity in ztunnel.

Initial idea was IP address was temporary and we would use something unique to the pod (likely network device (veth)) longer term. Obviously we haven't implemented that

An update from on this problem based on LinkedIn discussion:
With ztunnel, the problem easily solvable, We (at solo.io) are working to upstream a better model that solves this problem entirely by accepting/originating ztunnel connections from within the pod's netns. Stay tuned!
cc @bleggett @yuval-k

A proposal has been presented to upstream today - In-pod Traffic tradirection model proposal (ambient that works on any CNI)
https://docs.google.com/document/d/1dynKlnNgIOywv3cwuw_2RCk_SKFRs7IrESaC8_r-sm0

once in-pod mode lands, this becomes a lot easier to do

p.o.c branch here https://github.com/yuval-k/ztunnel/tree/inpod-dest-id (will need corresponding changes in istiod)

The ztunnel side is complete, but we still need to implement the istio CNI side


AWS getting started guide wrong order of commands

I am trying toset up the AWS stack as per instructions here: INSTRUCTIONS
I am able to get to the section titled "Install Bifravst into your AWS account" without issue.
In this section, the operations are as follows:
npx cdk bootstrap
npx cdk -a 'node dist/cdk/cloudformation-sourcecode.js' deploy
npx cdk deploy '*'

Running the first command (npx cdk bootstrap) gets the following error:
Error [ValidationError]: Stack with id bifravst-sourcecode does not exist
    at Request.extractError (/home/comemaster/Documents/IRNAS/Nordic/bifravst-aws/node_modules/aws-sdk/lib/protocol/query.js:50:29)
    at Request.callListeners (/home/comemaster/Documents/IRNAS/Nordic/bifravst-aws/node_modules/aws-sdk/lib/sequential_executor.js:106:20)
    at Request.emit (/home/comemaster/Documents/IRNAS/Nordic/bifravst-aws/node_modules/aws-sdk/lib/sequential_executor.js:78:10)
    at Request.emit (/home/comemaster/Documents/IRNAS/Nordic/bifravst-aws/node_modules/aws-sdk/lib/request.js:683:14)
    at Request.transition (/home/comemaster/Documents/IRNAS/Nordic/bifravst-aws/node_modules/aws-sdk/lib/request.js:22:10)
    at AcceptorStateMachine.runTo (/home/comemaster/Documents/IRNAS/Nordic/bifravst-aws/node_modules/aws-sdk/lib/state_machine.js:14:12)
    at /home/comemaster/Documents/IRNAS/Nordic/bifravst-aws/node_modules/aws-sdk/lib/state_machine.js:26:10
    at Request.<anonymous> (/home/comemaster/Documents/IRNAS/Nordic/bifravst-aws/node_modules/aws-sdk/lib/request.js:38:9)
    at Request.<anonymous> (/home/comemaster/Documents/IRNAS/Nordic/bifravst-aws/node_modules/aws-sdk/lib/request.js:685:12)
    at Request.callListeners (/home/comemaster/Documents/IRNAS/Nordic/bifravst-aws/node_modules/aws-sdk/lib/sequential_executor.js:116:18) {
  message: 'Stack with id bifravst-sourcecode does not exist',
  code: 'ValidationError',
  time: 2019-12-10T10:54:44.798Z,
  requestId: '9f651436-1cb9-4ddd-aae5-9d29c5b62f93',
  statusCode: 400,
  retryable: false,
  retryDelay: 2.069632182324943
}
Subprocess exited with error 1

Running the commands in a different order:
npx cdk -a 'node dist/cdk/cloudformation-sourcecode.js' deploy
npx cdk bootstrap
npx cdk deploy '*'

does not produce any errors (each ones gives a check mark). Issuing the commands like above I was able to continue and complete the whole guide/installation process and can access the online cat-tracker GUI as well as use the simulator to simulate cat activity. The system thus appears to be working.
I suggest switching the order of the commands in the guide, unless the cause of my error is related to something else?

Yes, right, because the default cdk command tries to upload the lambdas to S3 here:
https://github.com/bifravst/aws/blob/5dc6a3c27743960e0fde2219ef4bb8e0eba8faeb/cdk/cloudformation.ts#L12-L16

Thanks for taking the time to report this issue, @comemaster!


Android Basics: SQL Basics

The section "Practice" in this paragraph is not highlighted in green. But this was done in the previous paragraphs. This confused me.

Hello @TrombBone,
Thanks for reaching out to us and sharing your concern. Could you please be more specific what codelab/section/paragraph confused you?

Hello @TrombBone,
We appreciate you opening this issue but as we did not receive additional feedback from you, we will be closing this issue at this time as there unfortunately is nothing further we can do to assist you.
Hope you are enjoying the course!
Regards.


Remove extra space from VersionMinor

Signed-off-by: Mrunal Patel<EMAIL_ADDRESS>

On Wed, Oct 07, 2015 at 01:41:25PM -0700, Mrunal Patel wrote:

Fix an extra space in VersionMinor

Looks good to me.
This would have been caught before landing if we had a check like
(bdaf4467e, .tools: Run 'git show --check ...' on each commit, #182)
in place.

LGTM


Bugfix/consolidate exch accounting book

PR Overview
This PR will address the following Issue/Feature:
https://github.com/fivetran/dbt_netsuite/issues/72
This PR will result in the following new package version: v0.6.3

Non breaking as these changes are happening under the hood and will not impact downstream fields that customers see.
Please detail what change(s) this PR introduces and any additional information that should be known during the review of this PR:
Brought in accounting_book_id (accountingbook) to the stg_netsuite2__consolidated_exchange_rates model.
Details:
This is responding to a customer issue seeing duplicate records were showing in end models transaction_details (and potentially balance_sheet too...).
The int_netsuite2__consolidated_exchange_rates model was the root cause for duplicates because the join:
    from consolidated_exchange_rates
    left join accounting_book_subsidiaries
        on consolidated_exchange_rates.to_subsidiary_id = accounting_book_subsidiaries.subsidiary_id

was resulting in multiple accounting_book_id 's. We should add accounting_book_id to the join. But --
We can remove int_netsuite2__consolidated_exchange_rates entirely now since that was to bring accounting_book_id in, and now we have that via the consolidated_exchange_rates staging model.
PR Checklist
Basic Validation
Please acknowledge that you have successfully performed the following commands locally:

[x] dbt compile
[x] dbt run –full-refresh
[x] dbt run
[x] dbt test
[n/a] dbt run –vars (if applicable)

Before marking this PR as "ready for review" the following have been applied:

[x] The appropriate issue has been linked and tagged
[x] You are assigned to the corresponding issue and this PR
[ ] BuildKite integration tests are passing

Detailed Validation
Please acknowledge that the following validation checks have been performed prior to marking this PR as "ready for review":

[x] You have validated these changes and assure this PR will address the respective Issue/Feature.
[x] You are reasonably confident these changes will not impact any other components of this package or any dependent packages.
[x] You have provided details below around the validation steps performed to gain confidence in these changes.

Validating with customer that duplicate records are removed/ tests are passing
Standard Updates
Please acknowledge that your PR contains the following standard updates:

Package versioning has been appropriately indexed in the following locations:

[x] indexed within dbt_project.yml
[x] indexed within integration_tests/dbt_project.yml

[x] CHANGELOG has individual entries for each respective change in this PR

[ ] README updates have been applied (if applicable)

[ ] DECISIONLOG updates have been updated (if applicable)
[ ] Appropriate yml documentation has been added (if applicable)

dbt Docs
Please acknowledge that after the above were all completed the below were applied to your branch:

[ ] docs were regenerated (unless this PR does not include any code or yml updates)

If you had to summarize this PR in an emoji, which would it be?

:dancer:

regen docs

Your changes look mostly good, I just had a suggestion to make some small changes in the CHANGELOG which look to be artifacts of the merge conflicts.
Additionally, I wanted to do a quick test to run this package version with the current live version of the dbt_netsuite package to make sure this field addition wouldn't cause any failures.... and surprisingly it does!
This is because in the downstream intermediate model when we reference the accounting_book_id we do not specify the source table and therefore we get this ambiguous column error 😱. Therefore, we cannot make this be a patch upgrade. Instead we will want to make this a breaking change as well.
Can you make the appropriate breaking change version bump updates (don't forget to update the README version as well) and then let me know once those are applied for re-review.

@fivetran-joemarkiewicz Ahh.. Thanks for noticing that, definitely needs to be a breaking change then. Updated the versions, readme, and made a note in the changelog. I'll make the downstream updates as well.