remove timeouts in xds proxy

As discussed in https://github.com/istio/istio/issues/31943
[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[X] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure
Pull Request Attributes
Please check any characteristics that apply to this pull request.
[X] Does not have any changes that may affect Istio users.

@ramaraochavali: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
195d9525b6e953ad10f7db4021f6f64dc3bf511b
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ramaraochavali: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
b01efe5dfbbd155a25d5d8573a9b5482f099fdce
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

I tried to unify the timeout logic for Istio and xds proxy. Right now I have left the xds timeout for Istiod as 5s and proxy to 0 (disabled). Based on what we decided - we can default it to zero for istiod also and if we run in to issues we can ask users to configure whatever time.
Let me know what you think

@ramaraochavali: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
a9987164dce0944d2b4a47a38e30e2ccfeb6c894
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ramaraochavali: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
a9987164dce0944d2b4a47a38e30e2ccfeb6c894
link
/test unit-tests_istio

integ-ipv6-k8s-tests_istio
a9987164dce0944d2b4a47a38e30e2ccfeb6c894
link
/test integ-ipv6-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ramaraochavali: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
a9987164dce0944d2b4a47a38e30e2ccfeb6c894
link
/test unit-tests_istio

integ-ipv6-k8s-tests_istio
a9987164dce0944d2b4a47a38e30e2ccfeb6c894
link
/test integ-ipv6-k8s-tests_istio

integ-distroless-k8s-tests_istio
a9987164dce0944d2b4a47a38e30e2ccfeb6c894
link
/test integ-distroless-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ramaraochavali: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
a9987164dce0944d2b4a47a38e30e2ccfeb6c894
link
/test unit-tests_istio

integ-ipv6-k8s-tests_istio
a9987164dce0944d2b4a47a38e30e2ccfeb6c894
link
/test integ-ipv6-k8s-tests_istio

integ-distroless-k8s-tests_istio
a9987164dce0944d2b4a47a38e30e2ccfeb6c894
link
/test integ-distroless-k8s-tests_istio

integ-multicluster-k8s-tests_istio
a9987164dce0944d2b4a47a38e30e2ccfeb6c894
link
/test integ-multicluster-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ramaraochavali: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
a9987164dce0944d2b4a47a38e30e2ccfeb6c894
link
/test unit-tests_istio

integ-ipv6-k8s-tests_istio
a9987164dce0944d2b4a47a38e30e2ccfeb6c894
link
/test integ-ipv6-k8s-tests_istio

integ-distroless-k8s-tests_istio
a9987164dce0944d2b4a47a38e30e2ccfeb6c894
link
/test integ-distroless-k8s-tests_istio

integ-multicluster-k8s-tests_istio
a9987164dce0944d2b4a47a38e30e2ccfeb6c894
link
/test integ-multicluster-k8s-tests_istio

integ-helm-tests_istio
a9987164dce0944d2b4a47a38e30e2ccfeb6c894
link
/test integ-helm-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ramaraochavali: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
a9987164dce0944d2b4a47a38e30e2ccfeb6c894
link
/test unit-tests_istio

integ-ipv6-k8s-tests_istio
a9987164dce0944d2b4a47a38e30e2ccfeb6c894
link
/test integ-ipv6-k8s-tests_istio

integ-distroless-k8s-tests_istio
a9987164dce0944d2b4a47a38e30e2ccfeb6c894
link
/test integ-distroless-k8s-tests_istio

integ-multicluster-k8s-tests_istio
a9987164dce0944d2b4a47a38e30e2ccfeb6c894
link
/test integ-multicluster-k8s-tests_istio

integ-helm-tests_istio
a9987164dce0944d2b4a47a38e30e2ccfeb6c894
link
/test integ-helm-tests_istio

integ-operator-controller-tests_istio
a9987164dce0944d2b4a47a38e30e2ccfeb6c894
link
/test integ-operator-controller-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ramaraochavali: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
a9987164dce0944d2b4a47a38e30e2ccfeb6c894
link
/test unit-tests_istio

integ-ipv6-k8s-tests_istio
a9987164dce0944d2b4a47a38e30e2ccfeb6c894
link
/test integ-ipv6-k8s-tests_istio

integ-distroless-k8s-tests_istio
a9987164dce0944d2b4a47a38e30e2ccfeb6c894
link
/test integ-distroless-k8s-tests_istio

integ-multicluster-k8s-tests_istio
a9987164dce0944d2b4a47a38e30e2ccfeb6c894
link
/test integ-multicluster-k8s-tests_istio

integ-helm-tests_istio
a9987164dce0944d2b4a47a38e30e2ccfeb6c894
link
/test integ-helm-tests_istio

integ-operator-controller-tests_istio
a9987164dce0944d2b4a47a38e30e2ccfeb6c894
link
/test integ-operator-controller-tests_istio

integ-pilot-multicluster-tests_istio
a9987164dce0944d2b4a47a38e30e2ccfeb6c894
link
/test integ-pilot-multicluster-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ramaraochavali: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
a9987164dce0944d2b4a47a38e30e2ccfeb6c894
link
/test unit-tests_istio

integ-ipv6-k8s-tests_istio
a9987164dce0944d2b4a47a38e30e2ccfeb6c894
link
/test integ-ipv6-k8s-tests_istio

integ-distroless-k8s-tests_istio
a9987164dce0944d2b4a47a38e30e2ccfeb6c894
link
/test integ-distroless-k8s-tests_istio

integ-multicluster-k8s-tests_istio
a9987164dce0944d2b4a47a38e30e2ccfeb6c894
link
/test integ-multicluster-k8s-tests_istio

integ-helm-tests_istio
a9987164dce0944d2b4a47a38e30e2ccfeb6c894
link
/test integ-helm-tests_istio

integ-operator-controller-tests_istio
a9987164dce0944d2b4a47a38e30e2ccfeb6c894
link
/test integ-operator-controller-tests_istio

integ-pilot-multicluster-tests_istio
a9987164dce0944d2b4a47a38e30e2ccfeb6c894
link
/test integ-pilot-multicluster-tests_istio

integ-telemetry-mc-k8s-tests_istio
a9987164dce0944d2b4a47a38e30e2ccfeb6c894
link
/test integ-telemetry-mc-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ramaraochavali: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
a9987164dce0944d2b4a47a38e30e2ccfeb6c894
link
/test unit-tests_istio

integ-ipv6-k8s-tests_istio
a9987164dce0944d2b4a47a38e30e2ccfeb6c894
link
/test integ-ipv6-k8s-tests_istio

integ-distroless-k8s-tests_istio
a9987164dce0944d2b4a47a38e30e2ccfeb6c894
link
/test integ-distroless-k8s-tests_istio

integ-multicluster-k8s-tests_istio
a9987164dce0944d2b4a47a38e30e2ccfeb6c894
link
/test integ-multicluster-k8s-tests_istio

integ-helm-tests_istio
a9987164dce0944d2b4a47a38e30e2ccfeb6c894
link
/test integ-helm-tests_istio

integ-operator-controller-tests_istio
a9987164dce0944d2b4a47a38e30e2ccfeb6c894
link
/test integ-operator-controller-tests_istio

integ-pilot-multicluster-tests_istio
a9987164dce0944d2b4a47a38e30e2ccfeb6c894
link
/test integ-pilot-multicluster-tests_istio

integ-telemetry-mc-k8s-tests_istio
a9987164dce0944d2b4a47a38e30e2ccfeb6c894
link
/test integ-telemetry-mc-k8s-tests_istio

integ-security-multicluster-tests_istio
a9987164dce0944d2b4a47a38e30e2ccfeb6c894
link
/test integ-security-multicluster-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ramaraochavali: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
a9987164dce0944d2b4a47a38e30e2ccfeb6c894
link
/test unit-tests_istio

integ-ipv6-k8s-tests_istio
a9987164dce0944d2b4a47a38e30e2ccfeb6c894
link
/test integ-ipv6-k8s-tests_istio

integ-distroless-k8s-tests_istio
a9987164dce0944d2b4a47a38e30e2ccfeb6c894
link
/test integ-distroless-k8s-tests_istio

integ-multicluster-k8s-tests_istio
a9987164dce0944d2b4a47a38e30e2ccfeb6c894
link
/test integ-multicluster-k8s-tests_istio

integ-helm-tests_istio
a9987164dce0944d2b4a47a38e30e2ccfeb6c894
link
/test integ-helm-tests_istio

integ-operator-controller-tests_istio
a9987164dce0944d2b4a47a38e30e2ccfeb6c894
link
/test integ-operator-controller-tests_istio

integ-pilot-multicluster-tests_istio
a9987164dce0944d2b4a47a38e30e2ccfeb6c894
link
/test integ-pilot-multicluster-tests_istio

integ-telemetry-mc-k8s-tests_istio
a9987164dce0944d2b4a47a38e30e2ccfeb6c894
link
/test integ-telemetry-mc-k8s-tests_istio

integ-security-multicluster-tests_istio
a9987164dce0944d2b4a47a38e30e2ccfeb6c894
link
/test integ-security-multicluster-tests_istio

integ-pilot-k8s-tests_istio
a9987164dce0944d2b4a47a38e30e2ccfeb6c894
link
/test integ-pilot-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ramaraochavali: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-ipv6-k8s-tests_istio
a9987164dce0944d2b4a47a38e30e2ccfeb6c894
link
/test integ-ipv6-k8s-tests_istio

integ-distroless-k8s-tests_istio
a9987164dce0944d2b4a47a38e30e2ccfeb6c894
link
/test integ-distroless-k8s-tests_istio

integ-multicluster-k8s-tests_istio
a9987164dce0944d2b4a47a38e30e2ccfeb6c894
link
/test integ-multicluster-k8s-tests_istio

integ-helm-tests_istio
a9987164dce0944d2b4a47a38e30e2ccfeb6c894
link
/test integ-helm-tests_istio

integ-operator-controller-tests_istio
a9987164dce0944d2b4a47a38e30e2ccfeb6c894
link
/test integ-operator-controller-tests_istio

integ-pilot-multicluster-tests_istio
a9987164dce0944d2b4a47a38e30e2ccfeb6c894
link
/test integ-pilot-multicluster-tests_istio

integ-telemetry-mc-k8s-tests_istio
a9987164dce0944d2b4a47a38e30e2ccfeb6c894
link
/test integ-telemetry-mc-k8s-tests_istio

integ-security-multicluster-tests_istio
a9987164dce0944d2b4a47a38e30e2ccfeb6c894
link
/test integ-security-multicluster-tests_istio

integ-pilot-k8s-tests_istio
a9987164dce0944d2b4a47a38e30e2ccfeb6c894
link
/test integ-pilot-k8s-tests_istio

unit-tests_istio
8c6744bf31e6e5ce1ef411573ac08185158ba54d
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ramaraochavali: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-ipv6-k8s-tests_istio
a9987164dce0944d2b4a47a38e30e2ccfeb6c894
link
/test integ-ipv6-k8s-tests_istio

integ-multicluster-k8s-tests_istio
a9987164dce0944d2b4a47a38e30e2ccfeb6c894
link
/test integ-multicluster-k8s-tests_istio

integ-helm-tests_istio
a9987164dce0944d2b4a47a38e30e2ccfeb6c894
link
/test integ-helm-tests_istio

integ-operator-controller-tests_istio
a9987164dce0944d2b4a47a38e30e2ccfeb6c894
link
/test integ-operator-controller-tests_istio

integ-pilot-multicluster-tests_istio
a9987164dce0944d2b4a47a38e30e2ccfeb6c894
link
/test integ-pilot-multicluster-tests_istio

integ-telemetry-mc-k8s-tests_istio
a9987164dce0944d2b4a47a38e30e2ccfeb6c894
link
/test integ-telemetry-mc-k8s-tests_istio

integ-security-multicluster-tests_istio
a9987164dce0944d2b4a47a38e30e2ccfeb6c894
link
/test integ-security-multicluster-tests_istio

integ-pilot-k8s-tests_istio
a9987164dce0944d2b4a47a38e30e2ccfeb6c894
link
/test integ-pilot-k8s-tests_istio

unit-tests_istio
8c6744bf31e6e5ce1ef411573ac08185158ba54d
link
/test unit-tests_istio

integ-distroless-k8s-tests_istio
8c6744bf31e6e5ce1ef411573ac08185158ba54d
link
/test integ-distroless-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ramaraochavali: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-multicluster-k8s-tests_istio
a9987164dce0944d2b4a47a38e30e2ccfeb6c894
link
/test integ-multicluster-k8s-tests_istio

integ-helm-tests_istio
a9987164dce0944d2b4a47a38e30e2ccfeb6c894
link
/test integ-helm-tests_istio

integ-operator-controller-tests_istio
a9987164dce0944d2b4a47a38e30e2ccfeb6c894
link
/test integ-operator-controller-tests_istio

integ-pilot-multicluster-tests_istio
a9987164dce0944d2b4a47a38e30e2ccfeb6c894
link
/test integ-pilot-multicluster-tests_istio

integ-telemetry-mc-k8s-tests_istio
a9987164dce0944d2b4a47a38e30e2ccfeb6c894
link
/test integ-telemetry-mc-k8s-tests_istio

integ-security-multicluster-tests_istio
a9987164dce0944d2b4a47a38e30e2ccfeb6c894
link
/test integ-security-multicluster-tests_istio

integ-pilot-k8s-tests_istio
a9987164dce0944d2b4a47a38e30e2ccfeb6c894
link
/test integ-pilot-k8s-tests_istio

unit-tests_istio
8c6744bf31e6e5ce1ef411573ac08185158ba54d
link
/test unit-tests_istio

integ-distroless-k8s-tests_istio
8c6744bf31e6e5ce1ef411573ac08185158ba54d
link
/test integ-distroless-k8s-tests_istio

integ-ipv6-k8s-tests_istio
8c6744bf31e6e5ce1ef411573ac08185158ba54d
link
/test integ-ipv6-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ramaraochavali: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-helm-tests_istio
a9987164dce0944d2b4a47a38e30e2ccfeb6c894
link
/test integ-helm-tests_istio

integ-operator-controller-tests_istio
a9987164dce0944d2b4a47a38e30e2ccfeb6c894
link
/test integ-operator-controller-tests_istio

integ-pilot-multicluster-tests_istio
a9987164dce0944d2b4a47a38e30e2ccfeb6c894
link
/test integ-pilot-multicluster-tests_istio

integ-telemetry-mc-k8s-tests_istio
a9987164dce0944d2b4a47a38e30e2ccfeb6c894
link
/test integ-telemetry-mc-k8s-tests_istio

integ-security-multicluster-tests_istio
a9987164dce0944d2b4a47a38e30e2ccfeb6c894
link
/test integ-security-multicluster-tests_istio

integ-pilot-k8s-tests_istio
a9987164dce0944d2b4a47a38e30e2ccfeb6c894
link
/test integ-pilot-k8s-tests_istio

unit-tests_istio
8c6744bf31e6e5ce1ef411573ac08185158ba54d
link
/test unit-tests_istio

integ-distroless-k8s-tests_istio
8c6744bf31e6e5ce1ef411573ac08185158ba54d
link
/test integ-distroless-k8s-tests_istio

integ-ipv6-k8s-tests_istio
8c6744bf31e6e5ce1ef411573ac08185158ba54d
link
/test integ-ipv6-k8s-tests_istio

integ-multicluster-k8s-tests_istio
8c6744bf31e6e5ce1ef411573ac08185158ba54d
link
/test integ-multicluster-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ramaraochavali: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-operator-controller-tests_istio
a9987164dce0944d2b4a47a38e30e2ccfeb6c894
link
/test integ-operator-controller-tests_istio

integ-pilot-multicluster-tests_istio
a9987164dce0944d2b4a47a38e30e2ccfeb6c894
link
/test integ-pilot-multicluster-tests_istio

integ-telemetry-mc-k8s-tests_istio
a9987164dce0944d2b4a47a38e30e2ccfeb6c894
link
/test integ-telemetry-mc-k8s-tests_istio

integ-security-multicluster-tests_istio
a9987164dce0944d2b4a47a38e30e2ccfeb6c894
link
/test integ-security-multicluster-tests_istio

integ-pilot-k8s-tests_istio
a9987164dce0944d2b4a47a38e30e2ccfeb6c894
link
/test integ-pilot-k8s-tests_istio

unit-tests_istio
8c6744bf31e6e5ce1ef411573ac08185158ba54d
link
/test unit-tests_istio

integ-distroless-k8s-tests_istio
8c6744bf31e6e5ce1ef411573ac08185158ba54d
link
/test integ-distroless-k8s-tests_istio

integ-ipv6-k8s-tests_istio
8c6744bf31e6e5ce1ef411573ac08185158ba54d
link
/test integ-ipv6-k8s-tests_istio

integ-multicluster-k8s-tests_istio
8c6744bf31e6e5ce1ef411573ac08185158ba54d
link
/test integ-multicluster-k8s-tests_istio

integ-helm-tests_istio
8c6744bf31e6e5ce1ef411573ac08185158ba54d
link
/test integ-helm-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ramaraochavali: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-operator-controller-tests_istio
a9987164dce0944d2b4a47a38e30e2ccfeb6c894
link
/test integ-operator-controller-tests_istio

integ-telemetry-mc-k8s-tests_istio
a9987164dce0944d2b4a47a38e30e2ccfeb6c894
link
/test integ-telemetry-mc-k8s-tests_istio

integ-pilot-k8s-tests_istio
a9987164dce0944d2b4a47a38e30e2ccfeb6c894
link
/test integ-pilot-k8s-tests_istio

integ-distroless-k8s-tests_istio
8c6744bf31e6e5ce1ef411573ac08185158ba54d
link
/test integ-distroless-k8s-tests_istio

integ-ipv6-k8s-tests_istio
8c6744bf31e6e5ce1ef411573ac08185158ba54d
link
/test integ-ipv6-k8s-tests_istio

integ-multicluster-k8s-tests_istio
8c6744bf31e6e5ce1ef411573ac08185158ba54d
link
/test integ-multicluster-k8s-tests_istio

integ-helm-tests_istio
8c6744bf31e6e5ce1ef411573ac08185158ba54d
link
/test integ-helm-tests_istio

unit-tests_istio
c796aed538ca25ad0dc22bdd52c9f73538604103
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test unit-tests_istio

@ramaraochavali: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
c796aed538ca25ad0dc22bdd52c9f73538604103
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ramaraochavali: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
da5183802797860d4bcb65b4443c364d7b92152e
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn addressed all the comments. PTAL

@howardjohn removed the go routine for normal case.
@hzxuzhonghu  PTAL when you get chance

@ramaraochavali: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-security-multicluster-tests_istio
6e3d107b505e2a99419ad10f5a274912727f0fb4
link
/test integ-security-multicluster-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test integ-security-multicluster-tests_istio

@ramaraochavali: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
3296df7696f299d5c18ad37326a6703d79a1dd7e
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ramaraochavali: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
862fa781ce24f3fd69de3754e309f7161847b93d
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test unit-tests_istio


Setting colorSequence property doesn't obey for a little bit time at first.

Hi I am using this control and it is very good effort.
But I am facing an issue while setting colorSequence property to loadingSpinner.
Actually when I set this property 'colorSequence', it saves my assigned colors. But it displays previous color sequence just for a little moment and doesn't look good.
Please resolve this issue.

Hi @asifbilal786 - could you please detail the repro steps and potentially pass along a gif that shows the behavior you're describing?


Style no_emails.html.

Remove incorrect / unused markup.
Align text center only to h1.

Hello - I am unsure why the CircleCI build is failing. I suspect that it might be due to MIX_ENV=prod mix compile --warnings-as-errors returned exit code 1, as when I run the tests locally, I do get one warning. However, this is addressed on a separate pull request #184. I'm not sure how to proceed.

@StevenXL I left a comment on #184. Thank you so much for tackling this :) Could you post a screenshot of what it looks like now?

The code looks good. After a screenshot I think we could finalize the last little bits :D Thanks again for your patience with the CI stuff. I think after a rebase it should pass CI

I am closing down this pull request in favor of PR #188, since it would take more time to fix the merge conflicts in this branch than it it worth.


Unfortunately, the previous issue has not been resolved~

hey,bro:
In my previous article, I explained that when Ebsynth utility is enabled, a "Value Error: images do not match" error will occur. At that time, I thought it was caused by the different sizes of "video_mask" and "video_key", but now I have found that this is not the case. Ensuring the same size will also cause that error.
But I feel like I've found the problem and I'm not sure if it can be solved:
When Ebsynth's "Input Area" is set to "only masked" and the characters in the screen are relatively small, an error will occur. Perhaps it's because the area of Face Editor exceeds the mask range?
When I set "Input Area" to "Whole picture", an error will not occur, and the resulting image is as follows:

The temporary solution is to only use the "Whole picture" option

I was able to reproduce the same error in my environment and was able to fix it.
Please try the latest version 😃


docs: Add user guide for Restore the last unsent message feature

Task duplication; Split up and made new doc for Restore unsent feature, added Table of Contents redirect links to other docs along the way

Automated message from Dropbox CLA bot
@synicalsyntax, it looks like you've already signed the Dropbox CLA. Thanks!

@synicalsyntax, LGTM. I'll approve your task but you will have to wait for @showell to merge this.

Merged, thanks @synicalsyntax!


Prevent ABI poisoning through FPU/SSE registers

Hi,
First off, thanks for open sourcing your interesting work! In the context of a larger security evaluation of Intel SGX runtimes, together with colleagues from KU Leuven and the Universtity of Birmingham, we have found a subtle ABI sanitization issue in GoTEE's low-level assembly entry code. As you wrote that GoTEE is research prototype under active development, and not suited for production environments, we wanted to reach out to you in this way and inform about a possible fix.
Vulnerability description
Lack of sanitization of hidden x87 FPU (control word and tag) and SSE (mxcsr) control registers in the trusted enclave runtime, allowing unprivileged adversaries in the containing host application to influence the rounding, precision, and outcome of enclaved floating point operations. The vulnerability applies to ABI-compliant compiled enclave application code that uses x87 FPU or SSE features (i.e., compiled Go code and/or trusted asm/C libraries included in the enclave). We include a minimal proof-of-concept attack to demonstrate the vulnerability below.
This issue is similar to our previously disclosed vulnerabilities in the Intel SGX-SDK (CVE-2020-0561) and OpenEnclave (CVE-2020-15107):
https://www.intel.com/content/www/us/en/security-center/advisory/intel-sa-00336.html
https://github.com/openenclave/openenclave/security/advisories/GHSA-7wjx-wcwg-w999
For a more general overview of trusted runtime ABI and API sanitization responsibilities, excluding floating-point issues, we refer to our CCS19 Tale of 2 Worlds paper. This paper also describes an ABI sanitization issue with the x86 direction flag that might apply to GoTEE as well:
https://jovanbulck.github.io/files/ccs19-tale.pdf
Proposed mitigation
The trusted runtime in the enclave (src/runtime/asm_amd64.s) should always properly initialize all low-level CPU state according to the ABI-level calling conventions expected by the compiler. For reference, we repeat the relevant System V ABI snippet below:

The CPU shall be in x87 mode upon entry to a function. Therefore, every function that uses the MMX registers is required to issue an emms or femms instruction after using MMX registers, before returning or calling another function. [...] The control bits of the MXCSR register are callee-saved (preserved across calls), while the status bits are caller-saved (not preserved). The x87 status word register is caller-saved, whereas the x87 control word is callee-saved.

Given that this issue once again shows the intricacy of extended state, we strongly recommend to properly initialize all extended state to sane predefined values through an XRSTOR instruction on enclave entry, as a more complete and hopefully future-proof option.
For reference, this is also the mitigation that Intel and Microsoft adopted in response to our recommendations for more principled ABI sanitization:
https://github.com/intel/linux-sgx/blob/sgx_2.9.1/sdk/trts/linux/trts_pic.S#L164
https://github.com/openenclave/openenclave/commit/ad57b943be8f4caaa43174ed25f2a11a477786f3
Let us know if you have any questions or comments and we would be happy to clarify!
Kind regards,
Jo Van Bulck (imec-DistriNet, KU Leuven)
Fritz Alder (imec-DistriNet, KU Leuven)
David Oswald (The University of Birmingham, UK)
Frank Piessens (imec-DistriNet, KU Leuven)
Proof-of-concept ABI poisoning attack
The patch below demonstrates a minimal PoC demonstrating x87 and SSE poisoning on top of the current master.
diff --git a/README.md b/README.md
index 066a550..1078072 100644
--- a/README.md
+++ b/README.md
@@ -35,6 +35,15 @@ Gotee only supports linux x86 platforms.

 Gotee has one dependency on a [serializer](https://github.com/aghosn/serializer), required to communicate with the Intel AESM module. This package must be installed and the `serializer` command available in your shell environment (`go install` command).

+```
+$ go get github.com/aghosn/serializer
+$ PATH=$PATH:$HOME/go/bin
+$ sudo make
+$ cd example/
+$ make
+$ ./main
+```
+
 Moreover, you need to have an SGX enabled processor with the Intel AESM enclave running (for more information about how to set up Intel SGX, go to Intel SGX SDK [repositories](https://github.com/intel/linux-sgx).
 The Intel SGX SDK itself is not required.

diff --git a/example/hello-world/.gitignore b/example/hello-world/.gitignore
new file mode 100644
index 0000000..9dadae2
--- /dev/null
+++ b/example/hello-world/.gitignore
@@ -0,0 +1,2 @@
+enclavebin
+main
diff --git a/example/hello-world/README.md b/example/hello-world/README.md
index d4f405f..0d87c98 100644
--- a/example/hello-world/README.md
+++ b/example/hello-world/README.md
@@ -2,6 +2,43 @@

 This folder contains a hello-world sample code that executes a print from both the untrusted and trusted domains.

+## FPU poisoning PoC
+
+```
+jo@breuer:~/Documents/gotee/example/hello-world$ ./main
+From an untrusted domain:
+Hello World!
+[ENTRY] Control Word: 0x37f
+[ENTRY] MXCSR: 0x1fa0
+From a trusted domain:
+Hello World!
+[ENTRY] Control Word: 0x1f7f
+[ENTRY] MXCSR: 0xffff
+```
+
+Faulty result for `VADDPD` when poisoning denormals-as-zero MXCSR flag:
+
+```
+jo@breuer:~/Documents/gotee/example/hello-world$ ./main
+From an untrusted domain:
+Hello World!
+[ENTRY] Control Word: 0x37f
+[ENTRY] MXCSR: 0x1fa0
+
+Add(1,2) is 3
+[EXIT] Control Word: 0x37f
+[EXIT] MXCSR: 0x1fa2
+--
+From a trusted domain:
+Hello World!
+[ENTRY] Control Word: 0x1f7f
+[ENTRY] MXCSR: 0x1fe0
+
+Add(1,2) is 0
+[EXIT] Control Word: 0x1f7f
+[EXIT] MXCSR: 0x1fe0
+```
+
 ## Compiling

 Just type `make` in `example/hello-world/`.
diff --git a/example/hello-world/src/hw/asm.s b/example/hello-world/src/hw/asm.s
new file mode 100644
index 0000000..b3b1bcd
--- /dev/null
+++ b/example/hello-world/src/hw/asm.s
@@ -0,0 +1,23 @@
+DATA op1+0x00(SB)/8, $1
+DATA op1+0x08(SB)/8, $0
+GLOBL op1(SB), 8, $32
+
+DATA op2+0x00(SB)/8, $2
+DATA op2+0x08(SB)/8, $0
+GLOBL op2(SB), 8, $32
+
+TEXT ·do_add(SB),$0-24
+    VMOVUPS op1(SB), X1
+    VMOVUPS op2(SB), X2
+    VADDPD X1, X2, X3
+    VMOVUPS X3, ret+16(FP)
+
+    RET
+
+TEXT ·get_fcw(SB),$0-0
+    FSTCW ret+0(FP)
+    RET
+
+TEXT ·get_mxcsr(SB),$0-0
+    STMXCSR ret+0(FP)
+    RET
diff --git a/example/hello-world/src/hw/impl.go b/example/hello-world/src/hw/impl.go
index 78944e2..a35e5b4 100644
--- a/example/hello-world/src/hw/impl.go
+++ b/example/hello-world/src/hw/impl.go
@@ -1,8 +1,24 @@
 package hw

-import "fmt"
+import (
+	"fmt"
+	//"math"
+)
+
+func do_add(a int64, b int64) int64
+func get_fcw() uint16
+func get_mxcsr() uint16

 func HelloWorld(done chan bool) {
 	fmt.Println("Hello World!")
+
+        fmt.Printf("[ENTRY] Control Word: %#x\n", get_fcw())
+        fmt.Printf("[ENTRY] MXCSR: %#x\n", get_mxcsr())
+
+	fmt.Println("\nAdd(1,2) is", do_add(1,2))
+
+        fmt.Printf("[EXIT] Control Word: %#x\n", get_fcw())
+        fmt.Printf("[EXIT] MXCSR: %#x\n", get_mxcsr())
+
 	done <- true
 }
diff --git a/example/hello-world/src/main.go b/example/hello-world/src/main.go
index f3a1d7a..dd1f019 100644
--- a/example/hello-world/src/main.go
+++ b/example/hello-world/src/main.go
@@ -15,7 +15,7 @@ func main() {
 	<-done

 	// Now a secured routine
-	fmt.Println("From a trusted domain:")
+	fmt.Println("--\nFrom a trusted domain:")
 	gosecure hw.HelloWorld(done)
 	<- done
 }
diff --git a/src/gosec/assembly_amd64.s b/src/gosec/assembly_amd64.s
index 3b31953..113d84e 100644
--- a/src/gosec/assembly_amd64.s
+++ b/src/gosec/assembly_amd64.s
@@ -2,9 +2,23 @@

 // func asm_eenter(tcs, xcpt, rdi, rsi uint64)
 TEXT gosec·asm_eenter(SB),$0-40
+
+    /* XXX Poison MXCSR */
+    //MOVQ $0xFFFF, AX
+    MOVQ $0x1FC0, AX
+    PUSHQ AX
+    LDMXCSR (SP)
+    POPQ AX
+
+    /* XXX Poison FPUCW */
+    MOVQ $0x1f3f, AX
+    PUSHQ AX
+    FLDCW (SP)
+    POPQ AX
+
     MOVQ $2, AX				//EENTER
     MOVQ tcs+0(FP),BX
-    MOVQ xcpt+8(FP), CX
+    MOVQ xcpt+8(FP), CX
     BYTE $0x0f; BYTE $0x01; BYTE $0xd7 //ENCLU EENTER
     MOVQ rdi+16(FP), AX
     MOVQ DI, (AX)

Hi Adrien,
Wanted to briefly follow up: we made an updated proof-of-concept and some more information on the issue and different SGX runtimes available here (part of an ongoing artifact evaluation):
https://github.com/fritzalder/faulty-point-unit/tree/master/02_table2_affected_runtimes
Let us know if you have any questions! As I wrote above, and as is also more detailed in the linked repository and the fixes implemented by Intel and Microsoft, we strongly advise to rule out this class of vulnerabilities entirely by doing a full xrstor with dummy CPU state on enclave entry. We'll be finishing the paper camready by September 28, so let us know (here or via email) if you'd like us to update Table2 with a (planned or finished) mitigation for Go-TEE?

Hi,
Thanks for the follow-up. I had an overloaded agenda the past few weeks (and now I'm on a break), but I will start looking at the mitigation next week (so it is definitely planned). I will keep you posted.
Thanks again, and good luck (and congrats) for the camera ready!

Thanks, sounds great. Enjoy your break this week! :sun_with_face:

Hi,
I had a look into it this week, thanks again for reporting that issue.
I have a partial fix relying on xrstore, but ran into Go peculiarities about de-referencing global arrays that requires a bit more work to make sure the cleanup of xstate is done everywhere it is needed.
Best,
Adrien

Hi Adrien,
Thanks for the update, the xrstor approach seems indeed the best way to address the issue. We'll update the table in the camready paper to indicate GoTEE adopts this mitigation approach.
I was not aware that GoTEE also offers a simulation mode, very nice work! :+1: It took a bit of time to figure out how to modify the simulation runtime (and some failed attempts with function pointers and horrible Go assembler ;-) ), but I managed to update our ABI poisoning PoC to also work in the simulator. We setup full Travis-CI integration for the ongoing ACSAC artifact evaluation, so you should be able to see the full attack simulation here:
https://travis-ci.org/github/fritzalder/faulty-point-unit/jobs/725653061
Btw, as part of the CI, we automatically build and run GoTEE in a Docker container. If you're interested to add continuous integration to your GoTEE repo, please feel free to re-use any parts of our Travis-CI script as you see fit!
https://github.com/fritzalder/faulty-point-unit/blob/master/.travis.yml#L47

Awesome, I'll have a look.
Yes the simulation environment was my approach to debugging things more easily (as I was the only one working on this project and discovering sgx intricacies).  It's not perfect as it doesn't follow exactly the same paths as SGX mode.
Good luck with the camera ready!

Awesome, I'll have a look and might indeed reuse the script!
Yes the simulation environment was my approach to debugging things more easily.  It's not perfect as it doesn't follow exactly the same paths as SGX mode but it helped a lot.


Funny Export with Invalid Geoms...

The geoms in this table, https://mappingmashups.cartodb.com/tables/geotheory_uk_2016_eu_referendum_with_ni/public/map

Seem to not have any issues while inside of CartoDB.
You can export GeoJSON, but it drops the geoms in N.I.
You can export as SHP and they are all contained.

not sure where the validity issue should be raised, but it was confusing for sure

Oh, I remember this issue! It's an old one if I'm not wrong. :-) I think this was mentioned/discussed in the past but I'm not able to find it now here neither in the SQL API repo. I'll take a look, thanks for reporting!


Move connect() from event_loop to net

It is a violation of the most fundamental layers of abstraction rules. It also violates any other notions of abstration.  Event_loops don't "connect".  Sockets "connect".

This has been done.


Partyinfo module

Moves the network information sync code into its own module. This will allow the core to not depend on the internals too much and give scope for other implementations.

Codecov Report

Merging #771 into master will not change coverage.
The diff coverage is 100%.

@@            Coverage Diff            @@
##             master     #771   +/-   ##
=========================================
  Coverage     99.43%   99.43%
  Complexity     1915     1915
=========================================
  Files           288      288
  Lines          5689     5689
  Branches        288      288
=========================================
  Hits           5657     5657
  Misses            5        5
  Partials         27       27

Impacted Files
Coverage Δ
Complexity Δ

...com/quorum/tessera/partyinfo/P2pClientFactory.java
100% <ø> (ø)
3 <0> (?)

...quorum/tessera/partyinfo/PartyInfoServiceImpl.java
100% <ø> (ø)
12 <0> (?)

...java/com/quorum/tessera/p2p/PartyInfoResource.java
100% <ø> (ø)
14 <0> (ø)
:arrow_down:

.../com/quorum/tessera/partyinfo/PartyInfoParser.java
100% <ø> (ø)
19 <0> (?)

.../quorum/tessera/grpc/p2p/PartyInfoGrpcService.java
100% <ø> (ø)
9 <0> (ø)
:arrow_down:

...va/com/quorum/tessera/admin/ConfigServiceImpl.java
100% <ø> (ø)
7 <0> (?)

.../com/quorum/tessera/partyinfo/model/Recipient.java
91.66% <ø> (ø)
7 <0> (?)

...va/com/quorum/tessera/partyinfo/URLNormalizer.java
100% <ø> (ø)
3 <0> (?)

...va/com/quorum/tessera/partyinfo/ResendRequest.java
100% <ø> (ø)
7 <0> (?)

.../main/java/com/quorum/tessera/sync/SyncPoller.java
100% <ø> (ø)
10 <0> (ø)
:arrow_down:

... and 27 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d186ddb...c9e0661. Read the comment docs.

Part of https://github.com/jpmorganchase/tessera/issues/773


TagBot trigger issue

This issue is used to trigger TagBot; feel free to unsubscribe.
If you haven't already, you should update your TagBot.yml to include issue comment triggers.
Please see this post on Discourse for instructions and more details.
If you'd like for me to do this for you, comment TagBot fix on this issue.
I'll open a PR within a few hours, please be patient!

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/98189

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/118428

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/118433

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/118442

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/118740

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/121858

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/122035

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/122054


1 second delay seem to be too low

This commit 334e1655c1a31cbdc2c3c094191e9a4f5c79954a introduced:

Made google recognizer cancellation after 1 sec from last partial results for google app starts with v5.9.26.

Which is really low amount of time if you want to input whole sentence. You need to speak really fast.
I think it should be at least configurable by SDK user.

Interesting... I was playing with this delay a bit and it seem like Google app (recognizer component) would stop listening anyway. So, even if you set STOP_DELAY to a couple of seconds, it would still end listening much sooner.


Missing Local Development Instructions

Please add instructions on running the game locally in order to make contributing easier!

Just do a git clone /Users/matthiaslee/Desktop/2048, cd into the folder and run open $(pwd)/index.html.


Video not playing on iPhone 7

It gives some kind of JavaScript exception on iPhone

Yes. same issue i facing.

+1

+1

#2


If there are no facets, the content should align with the H of "home" within the nav bar

Currently, space is being reserved for the facets (even if none are displayed), pushing the content on the exhibit home page over to the right.

@escowles, is it possible to get this ready by tomorrow morning?

I just figured out how to fix this — on each page, you can go to the Edit mode, and there is an "Options" tab at the top, where you can turn of displaying the sidebar.  I've done that for the WA home page, and now the content is aligned without a big blank space for the non-existent sidebar.


TS Server fatal error:  Maximum call stack size exceeded

Type: Bug
❗❗❗ Please fill in the sections below to help us diagnose the issue ❗❗❗
TypeScript Version: 5.6.2
Steps to reproduce crash

TS Server Log
❗ Server logging disabled. To help us fix crashes like this, please enable logging by setting:
"typescript.tsserver.log": "verbose"

After enabling this setting, future crash reports will include the server log.
VS Code version: Code 1.94.1 (Universal) (e10f2369d0d9614a452462f2e01cdc4aa9486296, 2024-10-05T05:44:32.189Z)
OS version: Darwin arm64 23.4.0
Modes:

System Info

Item
Value

CPUs
Apple M1 (8 x 2400)

GPU Status
2d_canvas: enabledcanvas_oop_rasterization: enabled_ondirect_rendering_display_compositor: disabled_off_okgpu_compositing: enabledmultiple_raster_threads: enabled_onopengl: enabled_onrasterization: enabledraw_draw: disabled_off_okskia_graphite: disabled_offvideo_decode: enabledvideo_encode: enabledwebgl: enabledwebgl2: enabledwebgpu: enabledwebnn: disabled_off

Load (avg)
55, 36, 16

Memory (System)
8.00GB (0.38GB free)

Process Argv
--crash-reporter-id ffd9080d-aee6-41a4-9ca3-96a6807ba9ef

Screen Reader
no

VM
0%

Extensions (15)

Extension
Author (truncated)
Version

codeium
Cod
1.16.18

es7-react-js-snippets
dsz
4.4.3

gitlens
eam
15.6.0

prettier-vscode
esb
11.0.0

figma-vscode-extension
fig
0.3.5

vscode-power-mode
hoo
3.0.2

vs-color-picker
lih
1.0.0

debug-tracker-vscode
mcu
0.0.15

git-graph
mhu
1.30.0

color-highlight
nau
2.8.0

material-icon-theme
PKi
5.11.1

vscode-thunder-client
ran
2.27.6

LiveServer
rit
5.7.9

vscode-import-cost
wix
3.3.0

grammarly
znc
0.25.0

(1 theme extensions excluded)

A/B Experiments
vsliv368cf:30146710
vspor879:30202332
vspor708:30202333
vspor363:30204092
vswsl492:30256859
vscod805:30301674
binariesv615:30325510
vsaa593:30376534
py29gd2263:31024239
c4g48928:30535728
azure-dev_surveyone:30548225
2i9eh265:30646982
962ge761:30959799
pythongtdpath:30769146
pythonnoceb:30805159
asynctok:30898717
pythonmypyd1:30879173
h48ei257:31000450
pythontbext0:30879054
accentitlementst:30995554
dsvsc016:30899300
dsvsc017:30899301
dsvsc018:30899302
cppperfnew:31000557
dsvsc020:30976470
pythonait:31006305
dsvsc021:30996838
724cj586:31013169
a69g1124:31058053
dvdeprecation:31068756
dwnewjupyter:31046869
2f103344:31071589
impr_priority:31102340
nativerepl1:31139838
refactort:31108082
pythonrstrctxt:31112756
flightc:31134773
wkspc-onlycs-t:31132770
wkspc-ranged-t:31151552
cf971741:31144450
defaultse:31146405
iacca2:31150323
notype1cf:31151524
controlgs:31153265
cc771715:31146322

Please try collecting the TS Server log from the crashed instance:

Set "typescript.tsserver.log": "verbose"

Restart VS Code and reproduce the problem

Open the TypeScript section of the output panel

At the very top, find the first line that prints to path to the semantic error log file. It should look something like:
[Info  - 19:54:59.247] <semantic> Log file: /Users/matb/Library/Application Support/Code - Insiders/logs/20200213T104930/exthost55/vscode.typescript-language-features/tsserver-log-ZT2zau/tsserver.log

That file contains the typescript logs.

Look through that log file for the first error or stack trace you see. If you can share the log, I can also take a look to see if anything stands out

⚠Warning: The TypeScript log may include information from your workspace, including file paths and source code. If you have any concerns about posting this publicly on Github, just let me know and we can arrange something else. On our side, we only use these logs to investigate issues like this


Split off a surfman-api crate?

This would allow webxr-api and surfman-chains-api to depend on surfman-api.

IRC chat with @jdm and @pcwalton here: https://mozilla.logbot.info/servo/20200108#c16844705


Array order not respected in checklist.

@vitalets , thanks for this great package. I have no issues with it other than this:
When an array is sent to x-editable sorted alphabetically. x-editable rearranges the order based on key value.
http://jsfiddle.net/wmc0ck6h/
I'm guessing it's an easy one to fix?

Having the same issue as well, I need to display a list of user id's but they are getting sorted by their actual id's and not alphabetically.

Just found something in the docs https://vitalets.github.io/x-editable/docs.html
It seems the array has to follow the {value:1, text:foo} format otherwise sorting is not guaranteed. Made changes to my code and the listing is showing alphabetically now.

Shoot, I'm not seeing this in the doc's..


MAINT: Make load_adjusted_array return a dict.

Rather than a list that's ordered the same as the received columns.
Most nontrivial loaders were constructing dicts internally and then
converting back to lists, only to have the engine convert back again
into a dict.  This cuts out the middleman, and prevents bugs due to
incorrect ordering of the output arrays.

@richafrank I think this is a better solution to the nondeterministic failures we were getting upstream.  You can't return things in the wrong order if you're returning an unordered collection!

:+1: from me!


Unable to download attached docx\xlsx files (IOS)

Summary
There is no button to download. Preview shows only docx\xlsx icon but no ways to download. In same time others files could be downloaded e.g, pdf. In same time on android devices docx\xlsx files are downloaded successfully.
Environment Information

Iphone\Ipad
OS Version: 11.2.6
Mattermost App Version: 1.6.1 (build 86)
Mattermost Server Version: 4.8.0 (postgres)

Steps to reproduce

Sent any docx\xlsx file
Try download it from device

Expected behavior
docx\xlsx could be downloaded
Observed behavior
it dowsn't

Android works a little bit different than iOS, on Android you have access to the whole storage as on iOS only to the sandbox the app lives in and there is the Photo Gallery.
Where do you want to save those files? is it not enough that you can open them in within the app and then share it to any other app?
Do you know how to accomplish saving the file to another location in the device? or perhaps you are thinking something along the lines of iCloud/dropbox/google drive/box/etc.. if it is the later, do you think you can help?
thanks

I’m seeing the same behaviour with a plain text file that someone has shared.
Also regarding doc files I believe iOS has built in support for previewing them and many other formats: https://developer.apple.com/documentation/quicklook/qlpreviewcontroller#//apple_ref/occ/cl/QLPreviewController


fixed genus in geospatial ellipse definition

@neilotte

@cameronmore Was my comment here addressed yet?

@neilotte yes, and I adjusted a number of other labels and definitions to conform to the correct genus-species. I would recommend looking at via Protege to ensure I did not error.


build fs and thread test failed

Ubuntu 22.04
g++ version : 11.20
glibc version :  2.35
fs-test
the reason why fs test build failed : From  glibc  2.24  onwards,  the  __malloc_initialize_hook variable has been removed from the API.It wasted me some time to find the answer.I thought it was caused by something changed by the mimmalloc(micsoft's malloc) I installed yesterday. Myabe we could remind users to check the version of glibc before compiling fs/test.
thread-test
I am not very familiar with c++ templates. I am very interested in your implementation of thread pool and want to learn the following. So please help me solve this problem.
build info :
FAILED: thread/test/CMakeFiles/test-thread.dir/test.cpp.o  /usr/bin/c++  -I/home/susun/code/cpp/PhotonLibOS/include -mcrc32 -msse4.2 -O0 -g -fPIE   -w -Wall -DGTEST_HAS_PTHREAD=1 -std=c++14 -MD -MT thread/test/CMakeFiles/test-thread.dir/test.cpp.o -MF thread/test/CMakeFiles/test-thread.dir/test.cpp.o.d -o thread/test/CMakeFiles/test-thread.dir/test.cpp.o -c /home/susun/code/cpp/PhotonLibOS/thread/test/test.cpp In file included from /home/susun/code/cpp/PhotonLibOS/thread/test/test.cpp:31: /home/susun/code/cpp/PhotonLibOS/thread/test/../thread11.h: In instantiation of ‘typename std::enable_if<(! std::is_void<decltype (& typename std::decay<_Tp>::type::operator())>::value), photon::thread*>::type photon::thread_create11(FUNCTOR&&, ARGUMENTS&& ...) [with FUNCTOR = thread11_lambda_Test::TestBody()::<lambda(photon::semaphore&)>&; ARGUMENTS = {photon::semaphore&}; typename std::enable_if<(! std::is_void<decltype (& typename std::decay<_Tp>::type::operator())>::value), photon::thread*>::type = photon::thread*; decltype (& typename std::decay<_Tp>::type::operator()) = void (thread11_lambda_Test::TestBody()::<lambda(photon::semaphore&)>::*)(photon::semaphore&) const; typename std::decay<_Tp>::type = std::decay<thread11_lambda_Test::TestBody()::<lambda(photon::semaphore&)>&>::type]’: /home/susun/code/cpp/PhotonLibOS/thread/test/test.cpp:1502:28:   required from here /home/susun/code/cpp/PhotonLibOS/thread/test/../thread11.h:156:54: error: call of overloaded ‘thread_create11<thread11_lambda_Test::TestBody()::<lambda(photon::semaphore&)>&, photon::semaphore&>(const uint64_t&, thread11_lambda_Test::TestBody()::<lambda(photon::semaphore&)>&, photon::semaphore&)’ is ambiguous   156 |         return thread_create11<FUNCTOR, ARGUMENTS...>(       |                ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^   157 |             DEFAULT_STACK_SIZE, std::forward<FUNCTOR>(f),       |             ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~   158 |             std::forward<ARGUMENTS>(args)...);       |             ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

We are still investigating this issue. High version gcc may have a different behavior when installing lambda to template functions.

When I rethink this problem, I find that the problem is not the template, but how we think lambda calls.
When you create a lambda, the compiler will generate an anonymous class with the operator () method. In other words, we should regard the lambda call as a class function call, not a function call.
So I changed the error code to this, and successfully compiled  test-thread on my host, and passed all thread tests.
    auto lambda = [](photon::semaphore &sem){
        sem.signal(1);
    };
    photon::thread_create11(&decltype(lambda)::operator(),&lambda,sem);

It's because C++ 20 introduced template lambda.
High version gcc seems to obey this rule even if we have explicitly set -std=C++14.
That would cause template mismatch when using our old implementation.
So we have uploaded a small fix. https://github.com/alibaba/PhotonLibOS/pull/50

Could you try the latest code on your environment?

It was successfully compiled on my environment.
thank you.


Add config option to switch IMERG versions

This commit will add the a new config option "IMERG product:". The
previously added "IMERG version:" will now refer to the version
number (ex. V06B) and the "IMERG product" option will refer to the
early, late, or final product of IMERG.
This removes the previously hardcoded version of V05B from the IMERG reader.
If these options are not in the config file, the reader will default to V06B
and 'final' as the IMERG version and product.
A new testcase has also been created for the reader: /discover/nobackup/dpsarmie/work/gitLIS/testcase/imerg_lis/
Resolves: #145

I reviewed the code and tested with both Intel and GNU.  The only bug I see is a typo in the lislog file:
IMERG prodcut : late
should read
IMERG product : late
Can you correct the write statement to fix the typo?

Typo in readcrd_imerg.F90 has been fixed

I believe this is ready to merge.  However, since this includes a new test case, the actual acceptance needs to be done by Jim who will add the test case to his collection.
Apologies for the delay. :-(


report typo

on lines 33 and 38 'static' is missing. it should be:
private static function ...

Fixed


add ucr database and url to ansible

have already tested and deployed these to prod
@benrudolph

(goes with https://github.com/dimagi/commcare-hq/pull/8227)

(deployed to india as well)

nice this a good move


gatts_add_char_descr_evt_param struct changes required

With normal situation, one characteristic with distinctive UUID per service, this structure works fine:
https://github.com/espressif/esp-idf/blob/master/components/bt/bluedroid/api/include/esp_gatts_api.h#L161-L166
But when we have 2 or more characteristics with the same UUID in the same service, like here >> https://github.com/nkolban/esp32-snippets/issues/175, then we have a problem. Could we change this structure to identify characteristics by handle?
struct gatts_add_char_descr_evt_param {
        esp_gatt_status_t status;       /*!< Operation status */
        uint16_t attr_handle;           /*!< Descriptor attribute handle */
        uint16_t service_handle;        /*!< Service attribute handle */
        esp_bt_uuid_t char_handle;        /*!< Characteristic handle*/  <--- change
        esp_bt_uuid_t char_uuid;        /*!< Characteristic uuid */         <--- left for backward compatibility
    } add_char_descr;                   /*!< Gatt server callback param of ESP_GATTS_ADD_CHAR_DESCR_EVT */

I just found this issue in expressif https://github.com/espressif/esp-idf/issues/1079 which faces the same situation (multiple UUIDs).


Defining mutable variables for parsers

Hello, I have managed to create a parser for mathematical expression. It's been very easy with petitparser! This is the code I'm using right now:
import 'dart:math' as math;
import 'package:petitparser/petitparser.dart';

/// Parses mathematical expressions with support for variables.
class ExpressionParser {
  /// Builds a new expression parser accepting strings with a single `x` variable.
  /// For example, valid expressions are:
  ///
  ///   - `2 + x`
  ///   - `3 * x - 6`
  ///   - `x^2 + cos(x / 2)`
  const ExpressionParser();

  /// Evaluates the parsed expression using the given [value].
  num evaluate(String expression, double value) {
    final builder = ExpressionBuilder();

    // Definition of operator groups. This defines how numbers are parsed and how
    // variables are recognized.
    builder.group()
      ..primitive(digit()
          .plus()
          .seq(char('.').seq(digit().plus()).optional())
          .flatten()
          .trim()
          .map(num.tryParse))
      ..primitive(
          char('x').map((value) => value))
      ..primitive(
          char('e').map((value) => math.e))
      ..primitive(
          string('pi').map((value) => math.pi))
      ..wrapper(char('(').trim(), char(')').trim(), (_, num a,__) => a)
      ..wrapper(string('sqrt(').trim(), char(')').trim(), (_, num a,__) => math.sqrt(a))
      ..wrapper(string('sin(').trim(), char(')').trim(), (_, num a,__) => math.sin(a))
      ..wrapper(string('cos(').trim(), char(')').trim(), (_, num a,__) => math.cos(a))
      ..wrapper(string('exp(').trim(), char(')').trim(), (_, num a,__) => math.exp(a))
      ..wrapper(string('log(').trim(), char(')').trim(), (_, num a,__) => math.log(a))
      ..wrapper(string('acos(').trim(), char(')').trim(), (_, num a,__) => math.acos(a))
      ..wrapper(string('asin(').trim(), char(')').trim(), (_, num a,__) => math.asin(a))
      ..wrapper(string('atan(').trim(), char(')').trim(), (_, num a,__) => math.atan(a));

    // Defining operations among operators.
    builder.group()
      ..prefix(char('-').trim(), (String op, num a) => -a);
    builder.group()
      ..right(char('^').trim(), (num a, String op, num b) => math.pow(a, b));

    // multiplication and addition are left-associative
    builder.group()
      ..left(char('*').trim(), (num a, String op, num b) => a * b)
      ..left(char('/').trim(), (num a, String op, num b) => a / b);
    builder.group()
      ..left(char('+').trim(), (num a, String op, num b) => a + b)
      ..left(char('-').trim(), (num a, String op, num b) => a - b);

    return builder
        .build()
        .end()
        .parse(expression)
        .value as num;
  }
}

While this works, I don't really like this at all. To be more precise, this is the line giving me issues:
..primitive(char('x').map((value) => value))

Consider this example:
const expr = ExpressionParser();

for(var value in List<double>.generate(100.0, (i) => i)) {
  expr.evaluate("x+3*sqrt(x)", i);
}

In this case, evaluate is called 100 times adn I'm building a parser using build() for 100 times. Sure, I could "cache" a parser inside a static variable but then how can I pass a value to x?
In other words, how can I avoid building multiple times the parser? Basically, a part from x the whole parser will always be the same. I may work with static variables but I don't like the idea.
Thank you!

There are different ways of solving your problem, each with different performance characteristics of performance, flexibility and required coding:
The typical approach described in compiler-construction books is to build an abstract syntax tree (AST), a tree of objects that represent your expression. To evaluate your expression you can then traverse the tree (or print, simplify, or optimize it). However, this comes at the cost of creating a lot of classes for each node type (unary operator, binary operator, value, variable, ...); but is likely the best way in terms of execution speed and flexibility.
A quick and dirty alternative for your use-case is to make you parser build functions of type typedef Evaluator = double Function(double value);. So the digit production would end with .map((String input) => (double value) => double.parse(input)) (could be further optimized); the add production would end with .map((Evaluator a, String op, Evaluator b) => (double value) => a(value) + b(value)); and finally the variable production would simply end with .map((String variable) => (double value) => value). The parse result is then directly a function that you can evaluate repeatedly with different inputs: final expression = parser.parse('x+3*sqrt(x)'); print(expression(16));.

Added an example that shows the second approach with c6fdc5e2281bf4778adee23f0c24bd6465f95c53.


Ability to specify the host on which server runs, e.g http://me.dev:54614/teaspoon

In previous versions, Teaspoon allow the host to be specificed via the server_host configuration param. Is there a reason for this to have been removed?

In what version did we have a server_host config? I can't find it looking all the way back to 0.5. Also, what's your use case? The booted server is for headless testing, but are you using it for something other than that?


fix: updated package version

:tada: This PR is included in version 1.0.3 :tada:
The release is available on:

GitHub release
npm package (@latest dist-tag)

Your semantic-release bot :package::rocket:


Adding an IPP-Everywhere printer only creates a 'Local Raw Printer'

Hello,
since Cups version 2.4.x, the command:
/usr/sbin/lpadmin -p 'GAR-P-08' -D '' -L '' -o printer-is-shared=false -E -v ipp://<IP_ADDRESS>/ipp/print -m everywhere
only creates a 'Local Raw Printer' printer. With Cups 2.3.3 the printer was added correctly.
The Log shows the following:
D [11/Jan/2023:10:43:15 +0000] [Client 117] Returning IPP successful-ok for CUPS-Add-Modify-Printer (ipp://localhost:631/printers/GAR-P-08) from localhost.
D [11/Jan/2023:10:43:15 +0000] [Client 117] Content-Length: 75
D [11/Jan/2023:10:43:15 +0000] [Client 117] cupsdSendHeader: code=200, type="application/ipp", auth_type=0
D [11/Jan/2023:10:43:15 +0000] [Client 117] con->http=0x55dc534b0120
D [11/Jan/2023:10:43:15 +0000] [Client 117] cupsdWriteClient error=0, used=0, state=HTTP_STATE_POST_SEND, data_encoding=HTTP_ENCODING_LENGTH, data_remaining=75, response=0x55dc534a4220(IPP_STATE_DATA), pipe_pid=0, file=-1
D [11/Jan/2023:10:43:15 +0000] [Client 117] Writing IPP response, ipp_state=IPP_STATE_DATA, old wused=0, new wused=0
D [11/Jan/2023:10:43:15 +0000] [Client 117] bytes=0, http_state=0, data_remaining=75
D [11/Jan/2023:10:43:15 +0000] [Client 117] Flushing write buffer.
D [11/Jan/2023:10:43:15 +0000] [Client 117] New state is HTTP_STATE_WAITING
D [11/Jan/2023:10:43:15 +0000] [Client 117] Waiting for request.
D [11/Jan/2023:10:43:15 +0000] cupsdSetBusyState: newbusy="Dirty files", busy="Active clients and dirty files"
D [11/Jan/2023:10:43:15 +0000] [Notifier] state=3
D [11/Jan/2023:10:43:15 +0000] [Notifier] PrinterStateChanged
D [11/Jan/2023:10:43:15 +0000] [Notifier] state=3
D [11/Jan/2023:10:43:15 +0000] [Notifier] PrinterStateChanged
D [11/Jan/2023:10:43:15 +0000] [Notifier] state=3
D [11/Jan/2023:10:43:15 +0000] [Notifier] PrinterAdded
D [11/Jan/2023:10:43:15 +0000] [Client 117] HTTP_STATE_WAITING Closing for error 32 (Broken pipe)
D [11/Jan/2023:10:43:15 +0000] [Client 117] Closing connection.
D [11/Jan/2023:10:43:15 +0000] cupsdSetBusyState: newbusy="Dirty files", busy="Dirty files"
D [11/Jan/2023:10:43:15 +0000] [Client 114] HTTP_STATE_WAITING Closing for error 32 (Broken pipe)
D [11/Jan/2023:10:43:15 +0000] [Client 114] Closing connection.
D [11/Jan/2023:10:43:15 +0000] cupsdSetBusyState: newbusy="Dirty files", busy="Dirty files"
D [11/Jan/2023:10:43:15 +0000] GAR-P-08: Connected to <IP_ADDRESS>:631, sending Get-Printer-Attributes request...
D [11/Jan/2023:10:43:16 +0000] GAR-P-08: Get-Printer-Attributes returned server-error-internal-error (Success)
E [11/Jan/2023:10:43:16 +0000] GAR-P-08: PPD creation failed: Keine IPP-Attribute.
I [11/Jan/2023:10:43:16 +0000] Expiring subscriptions...
The PPD File was not created.
But i don't know the reason, and what to do, can anybody help me please. Thank You.
best regrads
franz

Hi Franz,
I guess <IP_ADDRESS> is your printer's IP, not a print server's IP, so you can try the following:
$ ipptool -tv ipp://<IP_ADDRESS>/ipp/print get-printer-attributes.test

it does the same request as cupsd during permanent queue's installation, so it can give  you an additional info if it fails.

Hi zdohnal,
yes, it's the IP of the printer and i have executed the command and it returns the following:
root@cups:/var/log/cups# ipptool -tv ipp://<IP_ADDRESS>/ipp/print get-printer-attributes.test
"/usr/share/cups/ipptool/get-printer-attributes.test":
Get-Printer-Attributes:
attributes-charset (charset) = utf-8
attributes-natural-language (naturalLanguage) = en
printer-uri (uri) = ipp://<IP_ADDRESS>:631/ipp/print
requested-attributes (1setOf keyword) = all,media-col-database
Get printer attributes using get-printer-attributes                  [FAIL]
RECEIVED: 0 bytes in response
status-code = server-error-internal-error (Unable to read response.)
IPP request failed with status server-error-internal-error (Unable to read response.)
I also executed it on the old machine with cups 3.3 and it returns the following:
"/usr/share/cups/ipptool/get-printer-attributes.test":
Get-Printer-Attributes:
attributes-charset (charset) = utf-8
attributes-natural-language (naturalLanguage) = en
printer-uri (uri) = ipp://<IP_ADDRESS>:631/ipp/print
requested-attributes (1setOf keyword) = all,media-col-database
Get printer attributes using get-printer-attributes                  [FAIL]
RECEIVED: 0 bytes in response
status-code = server-error-internal-error (IPP 1setOf Attribut mit inkompatiblen Werte-Markierung.)
IPP request failed with status server-error-internal-error (IPP 1setOf Attribut mit inkompatiblen Werte-Markierung.)
The return is nearly similar, but the printer is created correctly.
Thank you and best regards
Franz

I've checked the code of create_local_bg_thread(), which does the installation now, and get_printer_ppd() which did it in the past and the only change I can find there is that we set IPP version to 2.0 now.
To simulate this we can adjust /usr/share/cups/ipptool/get-printer-attributes.test by commenting out the line:
VERSION 2.0

Now if the ipptool command passes, then the setting of IPP version is really the culprit.
Can you make the change and call the ipptool command again? If the output is different, please put it into a file and attach it here.
What is your printer model?

I have commented out the line, but the return of the ipptool command is the same.
<IP_ADDRESS>.txt
The Printer Model is: Canon iR-ADV DX C5840i MFP
I tried it with many Canon models. It did not work with all of them except for one. A new Canon iR-ADV C257 (IP <IP_ADDRESS>) was added successfully. Please see the follwoing output:
<IP_ADDRESS>.txt

Interesting - so you are still able to install the printer with CUPS 2.3.3op2? It would be great if you uploaded the PPD it created from /etc/cups/ppd and two network captures - one when you install the printer with CUPS 2.3.3op2 and one when you install it with CUPS 2.4.x.
You can get a network capture via:
$ sudo tcpdump -w net.pcap -s0 -i any host <IP_ADDRESS>

It is really strange to me that two same requests give a different response...
BTW, I have problems with Canon ImageRunner Advance printers in our office as well - I've found out printer's firmware puts an IPP collection into attribute which accepts only keywords, so that firmware breaks Airprint specification IMO. Maybe the same firmware bug is your printers.

Now I found out what to do to add a printer successfully. I have to restart the printer, and after the restart, I have to wait for about a minute, then the printer can be added successfully.
At first glance, it looks like the same behavior exists with CUPS 2.3.3op2.
But I don't know why I haven't stumbled upon this problem before. We've been using CUPS for about 2 years now with about 50 printers and until now, this hasn't occurred to me.
I will do more testing this weekend. Also with a new installed CUPS 2.4.

It is as described before. If it is not possible to add a printer, then a restart of it can help. After that, it is possible to add it successfully for a certain period of time. This applies to Canon printers.


opts.except isn't implemented

@rultor release, tag=0.4.2

@rultor release, tag=0.4.2

@dgroup OK, I will release it now. Please check the progress here

@rultor release, tag=0.4.2

@dgroup Done! FYI, the full log is here (took me 4min)


Shrink station selector on mobile

Motivation
Fix #744
Changes
Shrink the selector. Ideal future solution would be to make sure it is on top of top nav bar.
Testing Instructions
Open on the smallest phone you own.

can you add a pic?


Mac Spacebar does not working in shell under v1.2.0

Rancher Version:
v1.2.0
Docker Version:
v1.2.3
OS and where are the hosts located? (cloud, bare metal, etc):
Mac (local)
Setup Details: (single node rancher vs. HA rancher, internal DB vs. external DB)
Single
Environment Type: (Cattle/Kubernetes/Swarm/Mesos)
Cattle
Steps to Reproduce:
Open shell and type "curl "
Results:
"curl" no space;
Expected:
"curl" followed by space.
FYI - to get space, need to hit Command key first...this unlocks spacebar

Works fine for me...

Can't reproduce on macOS 10.12.1 and Chrome or Safari.

macOs 10.12.1
Problem on Chrome: 54.0.2840.98 and 55.0.2883.75 (both 64-bit)
Works correctly on

Firefox 49.02
Safari 10.0.1

On Chrome 54.0.2840.98 and macOS 10.12.1 and cannot reproduce it either...
Running cattle on Digital Ocean hosts.

Closing ... must be one of my browser extensions


Wrong cross-axis position in wrap mode

In a layout with these parameters:
Direction: Column
Wrap :Wrap
AlignItems: Start
AlignContent: End
The items are aligned on the right side while they should remain on the left side. Changing Wrap to NoWrap brings them to the left side.

Turns out this is behaving as expected, we were trying this in chrome which doesn't seem to fully support align_content.


Implement #[derive(Debug)] expansion for #[bitfield]

Builds on top of https://github.com/Robbepop/modular-bitfield/pull/32.
Closes https://github.com/Robbepop/modular-bitfield/issues/31.

Oh sorry! I meant to wrap it up but was busy. Thank you.

Oh sorry! I meant to wrap it up but was busy. Thank you.

No problem, I was just a bit too impatient to get this in. :upside_down_face:
Thanks for your commitment!

Is there a way to use this such that you can print the raw hex next to the bitfield?


Support for linux/amd64 and arm64

I littered your code with preprocessor directives to make it a bit more portable and added syscall numbers for amd64 and arm64.
Besides, _syscall now takes variadic arguments, silencing compiler warnings and also seemingly reducing binary size by a few bytes.
So far, tested on:

linux 5.9 (amd64)
linux 5.4 (arm64, actually a raspberry pi)
OpenBSD virtual machine

Also, it should now be straightforward to support more architectures by adding another syscall table and the corresponding assembly code in crt.S

Hello.
Thanks for the port to Linux. I have some questions about this, particularly around your choice of preprocessor logic, which seems to imply that some very OpenBSD-specific bits are applicable to all operating systems !linux. But I think I have a solution for these things.
What would you say to having one git branch per OS/CPU combination? Then we don't need all these preprocessor tricks (which are surely to grow quite unwieldy with lots of OSes and CPUs) and can still easily grep the differences between the combinations. And I can definitely put in clearer comments in the main branch code highlighting what needs to be changed for future porters.

Hi!
Thanks for looking into it. You're definitely right about the preprocessor logic, it's a bit ugly. I think I just went with a conservative "don't break anything that might be working on !linux" assumption.
Keeping the code in different branches sounds solid! I have to admit I'm not sure how to cleanly do that with git. Should I create these on my side and create separate pull requests then?
One question by the way, I had to swap %rcx for %r10 as parameter register. Does OpenBSD have a different syscall convention than Linux?

As for the registers, I took the list from here: https://wiki.osdev.org/System_V_ABI which says "Parameters to functions are passed in the registers rdi, rsi, rdx, rcx, r8, r9, and further values are passed on the stack in reverse order." This appears to be corroborated by Wikipedia and the official docs. Perhaps Linux is slightly different? I don't know.

You should have an invite now.

So, after a little fight with my commits I now have the code nicely organized (I think) :)

Neat. I see they've gone in and you even generated new QR codes for them.


Refactor penv-workon

do not deactivate the current virtualenv until the user selects a new
one. Fixes #39.
remove temporary variable
add the name of the invalid virtualenv to the error message
always error-check the provided name, could catch cases where the
input handling changes in future

I have not added any tests; from what I can tell testing interactive
functions is not straightforward.

thank you! much better.


source_id add EC-Earth3-ESM-1

The EC-Earth consortium (institution_id is EC-Earth-Consortium) kindly asks for the following changes in the CMIP6_CV.json:
Please add a new configuration, i.e. a new source_id: EC-Earth3-ESM-1 as follows:
        "EC-Earth3-ESM-1":{
            "activity_participation":[
                "C4MIP",
                "CDRMIP",
                "CMIP",
                "DCPP",
                "LUMIP",
                "OMIP",
                "ScenarioMIP"
            ],
            "cohort":[
                "Published"
            ],
            "institution_id":[
                "EC-Earth-Consortium"
            ],
            "label":"EC-Earth3-ESM-1",
            "label_extended":"EC-Earth3-ESM-1",
            "license_info":{
<EMAIL_ADDRESS><- cmip6-data",
                "history":"2024-03-15: initially published under CC BY 4.0",
                "id":"CC BY 4.0",
                "license":"Creative Commons Attribution 4.0 International (CC BY 4.0; https://creativecommons.org/licenses/by/4.0/)",
                "source_specific_info":"",
                "url":"https://creativecommons.org/licenses/by/4.0/"
            },
            "model_component":{
                "aerosol":{
                    "description":"none",
                    "native_nominal_resolution":"none"
                },
                "atmos":{
                    "description":"IFS cy36r4 (TL255, linearly reduced Gaussian grid equivalent to 512 x 256 longitude/latitude; 91 levels; top level 0.01 hPa) and co2box v1.0 (CO2 box model; global grid)",
                    "native_nominal_resolution":"100 km"
                },
                "atmosChem":{
                    "description":"none",
                    "native_nominal_resolution":"none"
                },
                "land":{
                    "description":"HTESSEL (land surface scheme built in IFS) and LPJ-GUESS v4.1.2",
                    "native_nominal_resolution":"100 km"
                },
                "landIce":{
                    "description":"PISM v1.2 (5 km x 5 km for Greenland, 31 levels)",
                    "native_nominal_resolution":"5 km"
                },
                "ocean":{
                    "description":"NEMO3.6 (ORCA1 tripolar primarily 1 degree with meridional refinement down to 1/3 degree in the tropics; 362 x 292 longitude/latitude; 75 levels; top grid cell 0-1 m) and MWE v1.0 (Melt Water Emulator; same grid as ocean for the Antarctic surroundings) ",
                    "native_nominal_resolution":"100 km"
                },
                "ocnBgchem":{
                    "description":"PISCES v2 (same grid as ocean)",
                    "native_nominal_resolution":"100 km"
                },
                "seaIce":{
                    "description":"LIM3 (same grid as ocean)",
                    "native_nominal_resolution":"100 km"
                }
            },
            "release_year":"2024",
            "source_id":"EC-Earth3-ESM-1"
        },

Additional context: In the first place this EC-Earth3-ESM-1 configuration will be used for another project than the CMIP6 project, but that project will use the CMIP6 cmor tables as base (and the fork will be updated for the upstream updates). However, this EC-Earth3-ESM-1 might be later on also used for CMIP6 activities, therefore registration here is considered as the best option.
Thanks a lot,
Thomas

Hi, we are eagerly waiting for the registration of this new configuration ;)
Regards, Thomas

@treerink apologies for the delay, EC-Earth3-ESM-1 is now registered. Take a peek at CMIP6_source_id.html and let me know of any issues.
As you do not plan to publish data to ESGF, I'll leave this issue closed for now. If, in the future you want to publish to the project, we can always reopen this issue and amend the information.

@treerink apologies for the delay, EC-Earth3-ESM-1 is now registered. Take a peek at CMIP6_source_id.html and let me know of any issues.

Great, thanks a lot, looks perfect fine to me!

As you do not plan to publish data to ESGF, I'll leave this issue closed for now. If, in the future you want to publish to the project, we can always reopen this issue and amend the information.

Actually we will publish at the ESGF nodes with this configuration soon for the OptimESM project. However, this won't be as part of the CMIP6 framework, but as part of a new framework which has to cover OptimESM/TipESM/TipMIP maybe established as part of the CMIP6plus project, but this currently heavily under discussion.

@treerink as we have EC-Earth3-ESM-1 registered here with no intention of publishing to the project, I wonder whether migrating the registration across to the WCRP-CMIP/CMIP6Plus_CVs repo might be a good idea?
If registration here is intended to enable the CMOR-required code to be useable by the project, this would be achieved by migrating the registration
ping @wolfiex @matthew-mizielinski @taylor13 - reopening as there may be actions required

@treerink just circling on the query above - about migrating this registration out of the CMIP6_CVs, project that you have no intention of publishing data to

Hi @durack1, as long as the CMP6+ has not adopted our and the related projects (OptimESM, TIPMIP etc.) we actually need to have it here. It's a little difficult story, but in order to avoid delay of delivery of products in our projects we will use the current CMIP6 CV and MIP tables so we can cmorise all the data (which is quite a lot) so results can be shared and analysed across partners. In a late stage when all is set with either an overarching CMIP6+ project or separate projects, we will fix the metadata with a fixer to make it ESGF publishable.

Hi @durack1, as long as the CMP6+ has not adopted our and the related projects (OptimESM, TIPMIP etc.) we actually need to have it here.

The statement above wasn't completely obvious to me. There are ongoing discussions with TIPMIP etc about registering their experiments into the CMIP6Plus_CVs for exactly the reason you outline - making it easier to CMORize and potentially publish these data on ESGF
@matthew-mizielinski ping

I've started on the steps towards registering TIPMIP in CMIP6Plus (more tomorrow). Once that is done lets look at clearing this out  as it would be preferable to ensure that the CVs match the archive contents once we close CMIP6 to new submissions (timescales to be discussed at the next WIP meeting)

Sorry, I was under the impression that the registration of EC-Earth3-ESM-1 was complete because the model shows up in CMIP6_source_id.html, but that doesn't seem to be the case. We need this source_id not only for CMIP6plus but also for CMIP6. The DECK experiments with this model have already been published as part of CMIP6 on the ESGF datanode at NSC (@pchengi can tell more about how he did this despite the incomplete registration of the source_id). It would be good if the registration of EC-Eerath3-ESM-1 could be finalised as soon as possible to get everything in sync again.

@durack1 after consulting the EC-Earth partners and as clear form the post of @klauswyser  above, we need the full and permanent registration of the EC-Earth3-ESM-1 configuration for CMIP6 as well (besides the CMIP6Plus registration), because there is and will be data published on the ESGF node for this  EC-Earth3-ESM-1 configuration for CMIP6. I hope with this all proper action got clear? Thanks in advance and sorry for the slightly unclear trajectory we walked through.


Rule for ConditionManager::createInstance() when 'context' is passed as array key

Fixes #337

Blah, I forgot to add a minor version check with this. We'll see if that causes problems.


MAINT update classifiers entry in setup.py

To be in line with the current continuous integration.

Thanks!


Fix leave_submit

v2
leave submit .

Thanks for your pull request.
I think it can be merged.
@abc873693
Need your review.

But I think this feature maybe to implement in v3?

Because this feature will implement in v3.
Must close it first.


Multiple runners at same time

Hi there,
Would it be easy to setup two or more runners to split tests?
Our CI has lots of tests and it now takes >20mn to run.
Thanks

Hi @HugoHeneault,
unfortunately no.
You should not even try to split your tests.
Pls consider it as a bad practice.
If you have a long running scripts, consider caching elements taking long time.
If your tests by itself are causing excessive time then you should review your code or your infrastructure (maybe it is just too slow)

We have a 70$ - 16 core CI runner. More than 200 tests (huge project)
Each dusk test is slow (even on a macbook) and takes about 2-3s each.
We did manage to split our tests between 6 runners on the same machine and that reduced the dusk tests time by 3.
Why would it be a bad practice?

Hi @HugoHeneault,
normally huge project has thousands or even more tests.
If you split them between many other machines than you probably hit the problem of troubleshooting where the error comes from.
Did you try using caching mechanisms in the first place?

Things taking long time is juste opening the browser.
Are your test running sub second?
We're splitting and we're quite happy with it.


IF-284: Asset wizard thresholds and save asset

Task linked: IF-284 Add Thresholds to metrics (page 3) and save asset


Consider improving hipify-perl header replacement

Currently hipify-perl's regexp use \b to detect word boundaries which has the side effect of replacing #include "user-cuda.h" by #include "user-hip/hip_runtime.h" when #include "user_cuda.h" is unaffected.
Really it is a minor issue (requiring a manual fix of the source code headers) but it would be nice to have it corrected if it can be done.
$ hipify-perl --version
HIP version 4.2.0

Transferring the issue to [HIPIFY] (https://github.com/ROCm-Developer-Tools/HIPIFY).


Rename many functions to follow lowercase convention

Also replaced functions like spinHalfSites, electronSites, with a single function siteinds which takes a string and the number of sites. For example:
sh_sites = siteinds("S=1/2",N)
so_sites = siteinds("S=1",N)
e_sites = siteinds("Electron",N)

Codecov Report

Merging #141 into master will decrease coverage by 0.01%.
The diff coverage is 91.93%.

@@            Coverage Diff            @@
##           master    #141      +/-   ##
=========================================
- Coverage   87.52%   87.5%   -0.02%
=========================================
  Files          31      31
  Lines        2941    2946       +5
=========================================
+ Hits         2574    2578       +4
- Misses        367     368       +1

Impacted Files
Coverage Δ

src/physics/site_types/spinone.jl
100% <ø> (ø)
:arrow_up:

src/indexset.jl
85.43% <ø> (ø)
:arrow_up:

src/physics/site_types/electron.jl
100% <ø> (ø)
:arrow_up:

src/physics/site_types/tj.jl
100% <ø> (ø)
:arrow_up:

src/physics/site_types/spinhalf.jl
100% <ø> (ø)
:arrow_up:

src/tensor/linearalgebra.jl
92.18% <100%> (ø)
:arrow_up:

src/mps/mps.jl
100% <100%> (ø)
:arrow_up:

src/mps/projmpo.jl
100% <100%> (ø)
:arrow_up:

src/tagset.jl
88.43% <100%> (ø)
:arrow_up:

src/physics/autompo.jl
92.02% <100%> (ø)
:arrow_up:

... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 63e2fb4...03b638b. Read the comment docs.


[joy-ui] Publish new version

Summary
I am now creating the new UI Library for my company based on Joy-UI, so I hope to know the formal version of Joy-UI publish time. can you give me some idea? you said before that you are developing the material UI version 6, and now v6 is released, so what time to deal with joy-ui?
Examples
No response
Motivation
No response
Search keywords: Joy UI
Order ID: 97037
Search keywords:

Duplicate of https://github.com/mui/material-ui/issues/44242. See https://github.com/mui/material-ui/issues/44242#issuecomment-2467175157


python310Packages.asyncssh: 2.13.1 -> 2.13.2

https://github.com/ronf/asyncssh/blob/v2.13.2/docs/changes.rst
Description of changes

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 239149 run on x86_64-linux 1

2 packages failed to build:

python311Packages.dvclive
python311Packages.dvclive.dist

27 packages built:

dvc
dvc-with-remotes
dvc-with-remotes.dist
dvc.dist
home-assistant-component-tests.asuswrt
python310Packages.aioasuswrt
python310Packages.aioasuswrt.dist
python310Packages.asyncssh
python310Packages.asyncssh.dist
python310Packages.dvc-ssh
python310Packages.dvc-ssh.dist
python310Packages.dvclive
python310Packages.dvclive.dist
python310Packages.scmrepo
python310Packages.scmrepo.dist
python310Packages.sshfs
python310Packages.sshfs.dist
python311Packages.aioasuswrt
python311Packages.aioasuswrt.dist
python311Packages.asyncssh
python311Packages.asyncssh.dist
python311Packages.dvc-ssh
python311Packages.dvc-ssh.dist
python311Packages.scmrepo
python311Packages.scmrepo.dist
python311Packages.sshfs
python311Packages.sshfs.dist


Fix typo on fly-gzip link

The link for fly-gzip was pointed to fly-zip.
Great work on fly!

Thanks for this @tylersnyder


Optimize SVG icons

I’ve used svgo to optimize the SVG icons embedded in serve’s stylesheet. No visual change but shaves off a few bytes 👍
Let me know if I should make any changes!

Wonderful idea! ☺


update(app): update dependencies

:tada: This PR is included in version 1.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Unable to override Ctrl+P with Meta+P on Ubuntu

Does this issue occur when all extensions are disabled?: Yes

VS Code Version:  Version: 1.61.2
OS Version: Ubuntu 20.04 (Linux x64 5.10.0-1050-oem)

Steps to Reproduce:

Replace key binding "Ctrl + P" with "meta + P" in settings
Press "meta + P" => nothing happens
Press "Ctrl + P" => nothing happens

Notes:

The same  problem happens with Ctrl+O
Ctrl+T and Ctrl+W work as expected

I also tried to set up the keys manually in the keybindings.json file, please see below:
// Place your key bindings in this file to override the defaults
[
    {
        "key": "meta+b",
        "command": "workbench.action.toggleSidebarVisibility"
    },
    {
        "key": "ctrl+b",
        "command": "-workbench.action.toggleSidebarVisibility"
    },
    {
        "key": "meta+t",
        "command": "workbench.action.showAllSymbols"
    },
    {
        "key": "ctrl+t",
        "command": "-workbench.action.showAllSymbols"
    },
    {
        "key": "meta+w",
        "command": "workbench.action.closeActiveEditor"
    },
    {
        "key": "ctrl+w",
        "command": "-workbench.action.closeActiveEditor"
    },
    {
        "key": "meta+o",
        "command": "workbench.action.files.openFile"
    },
    {
        "key": "ctrl+o",
        "command": "-workbench.action.files.openFile"
    },
    {
        "key": "meta+p",
        "command": "workbench.action.quickOpen"
    },
    {
        "key": "ctrl+p",
        "command": "-workbench.action.quickOpen"
    }
]

Let's first try to find out what command executes on your machine, with your settings and your keybindings when pressing meta+o. Could you please try the following:

Run the command Developer: Toggle Keyboard Shortcuts Troubleshooting
This will activate logging of dispatched keyboard shortcuts and will open an output panel with the corresponding log file.
Press exactly the keybinding you desire.
check what VS Code detects and what command is invoked.

If you are having trouble understanding the output, please feel free to paste here and I can try to help.

@alexdima, thank you for the quick reply. There is no output when I press either "meta+o" or "meta+p".

@f-squirrel Thank you for getting back to me. This indicates that VS Code does not receive "meta+o", nor "meta+p" from the OS. There is nothing we can do on our side if we don't receive the keybindings from the OS. In most cases, I have heard that there is some piece of software that "steals" keybindings globally or that the OS itself does so for some built-in features.


Add "Authorization" Header if spring.zipkin.base-url as uri have userinfo

I have a zipkin-server using http collector to follow trace, I can get trace data.
after adding spring-boot-starter-security, I got nothing.
but I found No Authorization Header to send to zipkin-server from zipkin-client when I set Authorization info in spring-zipkin-base-url.
This PR can fix it.

@yoker Please sign the Contributor License Agreement!
Click here to manually synchronize the status of this Pull Request.
See the FAQ for frequently asked questions.

@yoker Thank you for signing the Contributor License Agreement!

Hi @yoker . Thanks for the PR. Can you write some tests for this functionality? Also @adriancole , WDYT?


Adjust Status Visibility on Mode & Browser Selectors

We should only show the status dot for the Mode and Browser selectors when there is more than one browser or mode.
To test

View the Browser Selector and Mode Selector Stories.
Run a build with multiple browsers enabled. You should see status dots on errors or changes on the Browser Selector.
Run a build with a story that has multiple modes. You should see status dots on errors or changes on the Modes Selector.
Run a build with a single browser enabled. You should not see status dots on errors or changes on the Browser Selector.
Run a build with a story with a single mode enabled. You should not see status dots on errors or changes on the Modes Selector.

Note: I also updated the readme to remove config info and point people at the hosted docs.

Code looks good, finishing up on testing now

lgtm


Spam report

github.com/zhzyker/exphub/issues/12

Please report to GitHub.
I have also reported.
/close


Page slow down after view the content many times

I found that after view the content many times the page will significant slow down and type the input will be delay.
Reproduce step:

Go to URL https://hallysonh.github.io/ngx-imageviewer/basic-usage
Switch tab between PDF test, Image1 and Image2 around 20-30 times.
Page will significant slow down and when type the input will be delay.

Facing the same issue

Fixed in my fork of the project, commit https://github.com/Softec-Open-Source-Division/ngx-imageviewer/commit/3caab5013509248574083539b78023d7efc80c99

The correct fix for this is storing the handle that requestAnimationFrame returns and making sure to call cancelAnimationFrame on it when render() is called  to make sure every image has only one image render loop. You should then also call cancelAnimationFrame in the onDestroy, like this:
  private animationFrameHandle: number;

  private render() {
    if (this.animationFrameHandle) {
      cancelAnimationFrame(this.animationFrameHandle);
      this.animationFrameHandle = null;
    }

    // ... Existing render code here ...

    this.animationFrameHandle = requestAnimationFrame(() => this.render());
  }

  ngOnDestroy() {
    // ... Existing destroy code here ...

    // Stop animation frame when image viewer is destroyed.
    if (this.animationFrameHandle) {
      cancelAnimationFrame(this.animationFrameHandle);
      this.animationFrameHandle = null;
    }
  }


feature selection

installation of package 'C:/Users/ht/AppData/Local/Temp/Rtmpua1BVo/downloaded_packages/FSelector_0.31.tar.gz' had non-zero exit status
installation of package 'recipes' had non-zero exit status
Why ?

If you meet this error, please unzip this "recipes" *.zip (you can find in this Github depository) file on your base R location (e.g. C:\Users[username]\Documents\R\win-library\3.6).

Thank you very much. I solved one of these issues, but still showing FSelector had a non-zero exit status when going to the second step.

just like this
ERROR: dependencies 'randomForest', 'RWeka', 'entropy' are not available for package 'FSelector'

removing 'D:/software/R/R-3.6.3/library/FSelector'
Warning in install.packages :
installation of package ‘D:/HT/explore/FSelector_0.31.tar.gz’ had non-zero exit status

just like this ERROR: dependencies 'randomForest', 'RWeka', 'entropy' are not available for package 'FSelector'

removing 'D:/software/R/R-3.6.3/library/FSelector'
Warning in install.packages :
installation of package ‘D:/HT/explore/FSelector_0.31.tar.gz’ had non-zero exit status

try to install java x64


No candidate version available for xfsprogs

yum_package[xfsprogs] action install[2020-03-19T09:54:31+00:00] INFO: Processing yum_package[xfsprogs] action install (filesystem::default line 23)
       * No candidate version available for xfsprogs
       ================================================================================
       Error executing action `install` on resource 'yum_package[xfsprogs]'
       ================================================================================

       Chef::Exceptions::Package
       -------------------------
       No candidate version available for xfsprogs

       Resource Declaration:
       ---------------------
       # In /tmp/kitchen/cache/cookbooks/filesystem/recipes/default.rb

        23:   package %w(xfsprogs)
        24: end

       Compiled Resource:
       ------------------
       # Declared in /tmp/kitchen/cache/cookbooks/filesystem/recipes/default.rb:23:in `from_file'

       yum_package("xfsprogs") do
         package_name ["xfsprogs"]
         action [:install]
         default_guard_interpreter :default
         declared_type :package
         cookbook_name "filesystem"
         recipe_name "default"
       end

       System Info:
       ------------
       chef_version=14.12.9
       platform=redhat
       platform_version=6.9
       ruby=ruby 2.5.5p157 (2019-03-15 revision 67260) [x86_64-linux]
       program_name=/opt/chef/bin/chef-client
       executable=/opt/chef/bin/chef-client

Are you using anything similar to satellite? Your yum repo might be out of date.

not a satellite server  and yum repo is up to date
[root@ip-10-61-11-23 ~]# cat /etc/redhat-release
Red Hat Enterprise Linux Server release 6.10 (Santiago)
[root@ip-10-61-11-23 ~]#
[root@ip-10-61-11-23 ~]# yum search xfsprogs
Loaded plugins: amazon-id, search-disabled-repos, security
rhui-REGION-rhel-server-releases                                                                                | 2.0 kB     00:00
rhui-REGION-rhel-server-releases/primary                              80% [===============================================-           ]  0.0 B/s |  34 MB     --:-- ETA rhui-REGION-rhel-server-releases/primary                                                                                |  41 MB     00:00
rhui-REGION-rhel-server-releases                                                                                21031/21031 rhui-REGION-rhel-server-rh-common                                                                                | 2.1 kB     00:00
rhui-REGION-rhel-server-rh-common/primary                                                                                |  38 kB     00:00
rhui-REGION-rhel-server-rh-common                                                                                129/129 rhui-client-config-server-6                                                                                | 2.1 kB     00:00
rhui-client-config-server-6/primary                                                                                | 1.7 kB     00:00
rhui-client-config-server-6                                                                                6/6 Warning: No matches found for: xfsprogs
No Matches found
[root@ip-10-61-11-23 ~]#

XFS is part of rhel7 and up.
Red Hat Scalable File System can be used on rhel 5 an rhel 6 servers.
The red-hot site says.
Access
Red Hat Scalable File System requires a subscription entitlement

Contact Red Hat Sales for pricing information for the subscriptions
Red Hat Scalable File System is only delivered online through the Red Hat Network
RHN Satellite customers:
After purchasing Scalable File System subscriptions, a new satellite certificate will need to be procured and activated
After that, channel profiles will need to be updated to include the new channel
Getting access to xfsprogs isn't really a filesystem cookbook problem.  XFS support needs to be available.
I'm going to close this request as being out of scope for the cookbook.
Mark


CircleCI: Add overview page to select between HTML and PDF artifacts

That's the page: https://25-210404706-gh.circle-artifacts.com/0/artifacts.html


Code highlighting c#

Hi,
Is C# syntax highlighting supported? If not is there a easy way to add it?
Thanks

Docsify uses PrismJs.
So, just add
<script src="//unpkg.com/prismjs/components/prism-csharp.min.js"></script>