[Proposal] Add new getDerivedConfigFromRequest API method

Description
This PR adds a new API method to the AppConfig component called getDerivedConfigFromRequest. The purpose of this method is to allow us to pass a derived configuration to any component (typically providers) defined in the PWA's _app-config definition. This method will have the request object as an argument so you can conditionally determine config values based on the information inside it (like the originalURL).
This async method runs on the server and its return value will be frozen in HTML to be used on the client side (this is transparent to the end user). The object returned is made available to the AppConfig component as a property called derivedConfig. Additionally the resultant config object will be passed to the AppConfig.extraGetPropsArgs method where it can be used for any kind of argument initialization there.
This new method is essentially a slimmed down version of getProps.
This is not a breaking change, but does change the signature to the following methods by adding derivedConfig as an additional argument:

getRoutes
routeComponent
extraGetPropsArgs

Why getDerivedConfgFromRequest over getProps

Adding getProps to the AppConfig component starts to blur the lines between with the App component, and there starts to be no obvious reason why those 2 can't be the same component.
Also, making AppConfig a routeComponent brings a long other API methods like shouldGetProps which imply we might want the application to have a different configuration from one page to the next, which doesn't feel right.
getDerivedConfgFromRequest is self explanatory and narrow in its focus, it allows you to define a derived config to be applied to components in the SDK.
It also only happens one time, during in the application rendering on the server, on the client it will simply use it's frozen configuration state.

Types of Changes

[ ] Bug fix (non-breaking change that fixes an issue)
[ ] New feature (non-breaking change that adds functionality)
[ ] Documentation update
[ ] Breaking change (could cause existing functionality to not work as expected)
[ ] Other changes (non-breaking changes that does not fit any of the above)

Breaking changes include:

Removing a public function or component or prop
Adding a required argument to a function
Changing the data type of a function parameter or return value
Adding a new peer dependency to package.json

Changes

(change1)

How to Test-Drive This PR

(step1)

Checklists

General

[ ] Changes are covered by test cases
[ ] CHANGELOG.md updated with a short description of changes (not required for documentation updates)

Accessibility Compliance
You must check off all items in one of the follow two lists:

[ ] There are no changes to UI

or...

[ ] Changes were tested with a Screen Reader (iOS VoiceOver or Android Talkback) and had no issues
[ ] Changes comply with WCAG 2.0 guidelines levels A and AA
[ ] Changes to common UI patterns and interactions comply with WAI-ARIA best practices

Localization

[ ] Changes include a UI text update in the Retail React App (which requires translation)

@olibrook Can you have a quick read possibly before EOW (Thursday Nov 4th). 👍

I took a good look! I'm just going to restate the problem I think we're trying to solve here:
Root problem
class AppConfig {

  // Restore a state-management library, eg. Redux
  AppConfig.restore = (locals = {}) => {}

  // Freeze a state-management library, eg. Redux
  AppConfig.freeze = () => undefined

  // Return resources that get injected into all `getProps` methods – eg. an api client.
  AppConfig.extraGetPropsArgs = (locals = {}) => {
    // Root problem: When we create an `CommerceAPI` client we need to know
    // the users locale, but we don't have access to the request object.
    return {api: new CommerceAPI({locale: 'what-should-go-here'})}
  }
}

So, why do we not have access to req, res in these special methods? I think there was a scenario where we thought that to support that we would have had to come up with a fake request object to use on the client side. We didn't want to do that because we don't do so for getProps either and we didn't want weird asymmetries in our APIs.
(Reminder that in getProps req and res are defined on the server and undefined on the client).
Does this suggestion fix it?
We are providing a way for users to persist information from the request in getDerivedConfigFromRequest and make it available in special methods. This would let us access, eg. a locale in extraGetPropsArgs, so, yes.
Is it an API we want to maintain though?
Pros/cons
!!!!!! Warning: Personal opinions !!!!!
✅ It'll work!
❌ I personally hate the name getDerivedConfigFromRequest! Much too long and you'll end up having to write docs about "your derived config", which means what, exactly?
❌ This re-uses and expands upon the dependency-injection pattern we have for getProps. Clearly that is established, but I don't actually think it's really well understood – do we really want more of it? Also, how do we reliably know where to inject this derivedConfig thing?
Ideas
I think what you have here is good. I would tweak the API/naming before going ahead. I'd also probably avoid injecting the derivedConfig all over the place, because I think the injection is complicated enough as it is.
How about the idea of freezing the original request and then providing a way of accessing that frozen request anywhere in the app? Eg.
AppConfig {
  // Called exactly once on the server-side, frozen in the rendered HTML and
  // made globally available on the variable `ssrRequest`.
  static freezeRequest(req, res) {
    return {
      url: req.url,
      headers: {
        'Accept-Language': req.headers['Accept-Language']
      }
    }
  }
}

If you make ssrRequest globally available then, later on you could do this:
  AppConfig.extraGetPropsArgs = () => {
    return {api: new CommerceAPI({locale: ssrRequest.headers['Accept-Language']})}
  }

I think the name ssrRequest would give users enough info to make it clear that the object is the original, frozen request, not something that corresponds to the current rendered page on the client. Other okay names: originalRequest, frozenRequest...

Two things I just remembered to be careful of:

If you do the ssrRequest thing, you can't make it "global, global" on the server-side. You'd have to just make it available while rendering somehow.
Embedding parts of the request on the page would make open up opportunities for XSS attacks, but I think we already have that problem and guard against it.

ssrRequest

I like this suggested approach. I'm going to run with this and see what comes out of it. I'll consider this PR closed and open a new one again.


docs: fix Mathjax startup

Summary of Changes
Update the MathJax config script, so math blocks get rendered properly already the first time a page is visited.

:tada: This PR is included in version 0.3.0 :tada:
The release is available on:

v0.3.0
GitHub release

Your semantic-release bot :package::rocket:


Enforce property clobbering in BONText instead of BONChain

The mutual exclusivity of properties like adobeTracking and pointTracking is enforced in BONChain, but you can use BONText on its own, in which case you don't get the auto-clobbering.

Also indentSpacer.

Never mind about indentSpacer, because the property it is supposed to clobber, trailingString, went the way of the dodo in #72.

Fixed in #74


noop assignment instead of assign

unique := λ(: t Token). (: (tail(
   (match t (
      ()
      ( (Token( s id loc )) (
         (set t (Token( s (iuid()) loc )))
      ))
   ))
   t
)) Token);

does not yield a new token

Just a bug in source, not compiler.


WIP: Patch/72 new test data set for ehrbase/project management#72

Changes

Adds first contribution-context checks

Adds check if a version with change type CREATION also has preceding_version_uid set, or with type MODIFICATION has the version uid not set. Both are invalid.

Also fixed integration test for the first case.
Small change to existing test data

Related issue
fixes https://github.com/ehrbase/project_management/issues/72
Additional information and checks

[x] Pull request linked in changelog

quick command to run related test (on this branch!)
robot -i 72 -d results -L TRACE robot/CONTRIBUTION_TESTS

(added to current sprint - was not transferred from last to current from the beginning)


Dash ocean optics

Issue for app: https://github.com/plotly/dash-sample-apps/issues/49
App pull request

[x] This is a new app
[ ] I am improving an existing app (redesigns/code "makeovers")

About

Playground deployment URL (new version): https://dash-playground.plotly.host/dash-ocean-optics/
Current gallery app URL: (delete this line if inapplicable)
Python app repository link: (delete this line if you are working on a Python app)

Workflow

[x] I have created a branch in the appropriate monorepo, and the
elements necessary for successful deployment are in place.
[x] If the app is a redesigned and/or restyled version of an
existing gallery app, I've summarized the changes requested in the
appropriate Streambed issue and confirm that they have been applied.
[x] If the app is on the Dash Gallery portal, I have added a link to
the GitHub repository for the source code in the portal description.
[x] If the app is a reimplementation of a Python gallery app for the
DashR gallery, the app in this PR mimics, as closely as possible,
the style and functionality of the existing app.=
[x] I have removed all Google Analytics code from the app's
assets/ folder.

The pre-review review
I have addressed all of the following questions:

[x] Does everything in my code serve some purpose? (I have removed
any dead and/or irrelevant code.)
[x] Does everything in my code have a clear purpose? (My code is
readable and, where it isn't, it has been commented appropriately.)]
[x] Am I reinventing the wheel? (I have used appropriate packages to
lessen the volume of code that needs to be maintained.)

Please rebase this pull request onto master before merging.

Please rebase this pull request onto master before merging.

will do.

[x] Dash version > 1.0.0
[x] Successfully deployed on playground https://dash-playground.plotly.host/dash-ocean-optics/()
[x] Restyling & Mobile responsiveness

TODO Before merging:

[ ] Make sure deployment into gallery is using correct account.


Who We Are Block on HomePage Display is broken

see screenshot

Fixed with updating Card variation to icon cta rather than icon.
This was a new variation added recently to support another card style that contains icons, but no links.


[INTERPRETER] Define min_dot_size

538556a added assertion in semantic checking of dot.
This commit defines min_dot_size for interpreter,
so kernels including dot can be run correctly for interpreter.

how come none of our tests caught this? @Jokeren do you know?

@ThomasRaoux Somehow interpreter tests have been accidentally disabled for days...I'll reenable it by fixing the CI file


fix rename refactor

Codecov Report

Merging #34 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master      #34   +/-   ##
=======================================
  Coverage   94.11%   94.11%
=======================================
  Files          75       75
  Lines        1817     1817
=======================================
  Hits         1710     1710
  Misses        107      107

Impacted Files
Coverage Δ

py_hcl/core/module_factory/merger.py
100% <ø> (ø)
:arrow_up:

py_hcl/firrtl_ir/type/field.py
100% <ø> (ø)
:arrow_up:

py_hcl/core/module_factory/extractor.py
100% <ø> (ø)
:arrow_up:

py_hcl/firrtl_ir/type/width.py
100% <ø> (ø)
:arrow_up:

py_hcl/core/module_factory/error/__init__.py
100% <ø> (ø)
:arrow_up:

py_hcl/firrtl_ir/type/__init__.py
100% <ø> (ø)
:arrow_up:

py_hcl/firrtl_ir/stmt/defn/module.py
100% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 011a8ff...e3fef7f. Read the comment docs.


Rename TestVSphereDownloadArtifacts E2E test

Description of changes:
This test needs the env vars for vsphere clusters. Adding 'VSphere' in
the test name will take care of this automatically.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/retest

/lgtm


Schedule Tasks (cron jobs)

Create a  a Cron-Tab like extension (https://github.com/alseambusher/crontab-ui).

one place where all the jobs live
monitor, pause or kill jobs
cron jobs can be created in the UI by the users
or via API by other extensions
in case the server is slow, the admin can stop some jobs and see if the cron job was the reason
the cron extension can limit what can be scheduled (for example hide the every X seconds part and only allow every X minutes or less)
each cron job has a REST API endpoint that it must call (GET/PUT/POST/DELETE)

LNbits can pay 1.5 million sat bounty for such a thing
hop into https://t.me/lnbits to propose

I want this feature. I can also try to implement it as an extension if someone else hasn't already done it.

Not sure how two step scheduled tasks like this could be executed:

https://github.com/lnbits/lnbits/pull/881

But it would very cool if that was possible.

Initial Draft, will rename to scheduler very soon and fix all the outstanding bugs/issues
https://github.com/bitkarrot/crontabs/releases/tag/v0.0.3

Discussions will continue at: https://github.com/bitkarrot/scheduler
Closing this issue.


if var doesn't remove nil from type inference

According to documentation and if I understand correctly, using a if var is supposed to restrict the type in the if branch. This isn't working on the latest crystal build. Here's a sample code to reproduce
class Test
  @callback = nil

  def on_callback(&block)
    @callback = block
  end

  def call
    if @callback
      @callback.call
    end
  end
end

test = Test.new
test.on_callback { puts "Called !" }
test.call

Running the previous code yields the following output:
Error in /tmp/test.cr:17: instantiating 'Test#call()'

test.call
     ^~~~

in /tmp/test.cr:10: undefined method 'call' for Nil (compile-time type is (( -> Void))?)

      @callback.call
                ^~~~

================================================================================

Nil trace:

  /tmp/test.cr:2

      @callback = nil
      ^

  /tmp/test.cr:2

      @callback = nil
                  ^

Is this the intended behavior ? If so, what's the correct implementation ?
If this is a bug, my crystal compiler and llvm knowledge is nil but I'm willing to have a look if you give me some pointers in the codebase

Damn, i can't bisect this :-/

Closing as a duplicate of #477. Assign it to a local variable first.

Thanks @jhass. I was sure there were similar bugs but i wasn't able to find them


Front end pages. (GUI)

Not sure if I mentioned this properly before but I have been putting together a frontend "dashboard" for  Shinobi. Alpha release is out if you want to see it and tell me to rip your name the hell off of it. :smile:
https://github.com/SmarchSoftware/watchtower
Anyway, the docs are under construction but the install works as explained. Going to get the config options, roles / permissions pages up on the wiki shortly.
Probably said it before but, thanks again for the package.

No way man, this is bad ass! I'll have to check this out later today - keep up the good work!

Thanks!
No problem. I will be using Shinobi instead of my old RBAC package as I move more and more sites to L5 so I figured I would need this over and over again. I hope to have the other docs done soon (holiday timing right?) but it should be pretty "click and go" without the docs anyway once it is set up.

Very nice. Would you mind I linked to this within the readme for shinobi?

Not at all. Encourages me to finish docs faster. :)
On Dec 21, 2015 14:51, "Shea Lewis"<EMAIL_ADDRESS>wrote:

Very nice. Would you mind I linked to this within the readme for shinobi?
—
Reply to this email directly or view it on GitHub
https://github.com/caffeinated/shinobi/issues/24#issuecomment-166401992.

Done. Awesome work, keep it up!


PostgreSQL database in UK, Gen4 hardware not supported.

When trying to create a postgres server in UK south region I get an error about hardware.
az postgres server create --resource-group myResourceGroup --name <> --location "uksouth" --admin-user <>  --admin-password <> --sku-name B_Gen4_1

Deployment failed. Correlation ID: bd0ad130-cd1c-4874-9073-99ec75264fa0. Gen4 hardware is not supported for this region.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 791bd216-532f-7f28-fa51-d95798397310
Version Independent ID: 4f7ff676-e4a5-cc41-6a43-ecb8fa1095fb
Content: Build a Python app with PostgreSQL on Linux - Azure App Service
Content Source: articles/app-service/containers/tutorial-python-postgresql-app.md
Service: app-service-web
GitHub Login: @cephalin
Microsoft Alias: beverst;cephalin

Hi @OMARI1988, Thanks for the feedback! We are currently investigating and will update you shortly.

@o365devx,  The UK South region only supports Gen 5 hardware. Please update your SKU to “B_Gen5_1". See this doc for a list of regions by hardware generation. We will update this doc to mention this change.
We will now proceed to close this thread. If there are further questions regarding this matter, please tag me in your reply. We will gladly continue the discussion and we will reopen the issue.


HELP for config file

I have created a feeds.yml file that looks like this:
headers:   "User-Agent": "Mozilla/5.0 (Windows NT 10.0; rv:68.0) Gecko/20100101 Firefox/68.0" feeds: channel:   url: https://www.horoscope.com/us/horoscopes/general/horoscope-general-daily-today.aspx?sign=10     language: en selectors:   items:     selector: "div.main-horoscope"   description:     selector: "p"   link:     selector: "#src-horo-today"     extractor: "href"
And I have added that file in the lib folder.
But I also see that I should create a config file that looks like this:
`require 'html2rss'
rss =
Html2rss.feed(
channel: { url: 'https://stackoverflow.com/questions' },
selectors: {
items: { selector: '#hot-network-questions > ul > li' },
title: { selector: 'a' },
link: { selector: 'a', extractor: 'href' }
}
)
puts rss`
Where should I add this file?
So far, my app doesn't work, so I guess I'm doing something wrong... I'm a beginner, so...

Hi!
I'm afraid the README might be a bit unclear and the interfaces to html2rss a bit unintuitive. I hope to find the time to revise it soon.
You already created a yaml file, so let's go with that.
https://github.com/gildesmarais/html2rss#usage-with-a-yaml-config-file
Since the yaml file can contain multiple feed configuration, you need to give yours a name, e.g. horoscope by adding it to line 4 and indent the lines below it.
Then the channel's language indention was off in line 7. I've fixed the yaml for you:
headers:
  "User-Agent": "Mozilla/5.0 (Windows NT 10.0; rv:68.0) Gecko/20100101 Firefox/68.0"
feeds:
  horoscope:
    channel:
      url: https://www.horoscope.com/us/horoscopes/general/horoscope-general-daily-today.aspx?sign=10
      language: en
    selectors:
      items:
        selector: "div.main-horoscope"
      title:
        selector: "strong"
      description:
        selector: "p"
      link:
        selector: "#src-horo-today"
        extractor: "href"

I assume you installed the gem with gem install html2rss already.
If you want to print the generated RSS to your command line, inside the folder with your yaml file, type:
ruby -e "require 'html2rss'; puts  Html2rss.feed_from_yaml_config('feeds.yml', 'horoscope')"

It loads the feeds.yml and selects the horoscope config.btw,  I already stared to work on making a nicer command line interface for such scenarios in #88.
Is printing to the command line sufficient or would you like to have the RSS available via http?


Hotfix test units

Please merge this branch to develop. The fixes include:

Tests for mails and the hashes have been refactored and moved to test_units.py.
Tests involving calls to the Mailgun API have been patched/mocked using the Mock module.Resolves #13.
Tests in test_views.py that simply test for the success of a route have been moved to routes.py. Resolves #10.

Change all occurences of password2 to password_conf.

I'm done with the mods. You may still notice 'password1' and 'password2' in the User Registration views and forms because Django's default User model and authentication system implements it that way. Samuel uses their convention so he can register and authenticate users in a way that's consistent with the Django default, I didn't change that.


avif files not cached

Hi
I noticed today that avif (images) files are not cached by pingap

Have you set max_file_size? If not, the default is 1mb.

I have a 10mb setting for this site so this is not a problem, my avif files are around 25kb.

Please show me the config of cache plugin, I tried it and it's ok for avif.
curl 'http://<IP_ADDRESS>:6119/download.avif' -v
*   Trying <IP_ADDRESS>:6119...
* Connected to <IP_ADDRESS> (<IP_ADDRESS>) port 6119
> GET /download.avif HTTP/1.1
> Host: <IP_ADDRESS>:6119
> User-Agent: curl/8.7.1
> Accept: */*
>
* Request completely sent off
< HTTP/1.1 200 OK
< Content-Type: image/avif
< etag: W/"1b29-676fd2b7"
< Transfer-Encoding: chunked
< Cache-Control: public, max-age=3600
< Date: Sat, 28 Dec 2024 10:33:43 GMT
< Connection: keep-alive
< Age: 7
< X-Cache-Status: hit
< X-Cache-Lookup: 0ms

Sorry, for some reason these images do not return the cache-control header and I have the ‘Check Cache-Control response header’ set so it is my fault.


Implement "create schema" and "drop schema" functionality

Acceptance criteria

CREATE SCHEMA my_schema
DROP SCHEMA IF EXISTS my_schema CASCADE/RESTRICT;

Closed with #44


Diners format

I'm using this test card diners with 14 digits: 3056<PHONE_NUMBER>
However, on typing numbers, react credit cards component expect a last digit: https://prnt.sc/rmscy4
On preview is showing as it has 15 digits, not 14 digits: https://prnt.sc/rmsdjy

Almost same here.
Without preview prop it works fine.
When in use, I got 15 preview digits but it returns maxLength = 14 from callback.

This is being tracked in #79


Fixed #23813 -- Added checks for common URL pattern errors

The main problem I see here is that the error doesn't point to the offending pattern. In a large project, it could be very tedious to track down the problem.

Thanks for the review. I'll fix up the minor changes tomorrow. It should be straight forward to report the regex that is causing the errors, but I'm not sure it will be as easy to report which module the errors are in. Hopefully that will be more obvious when I look at the code tomorrow.

I've made 3 suggestions for wrapping the format pattern in quotes. Feel free to add yourself to AUTHORS too if you like. Squash/Rebase, and hopefully we can squeeze this in for 1.9 which alpha's today/tomorrow.

@jarshwah I've wrapped the regex in quotes - I did it slightly differently than you suggested, so that it displays
'^$' [name='name']

instead of
'^$ [name='name']'

I have squashed and rebased. No need to add myself to AUTHORS, I'm already there :-)

Merged in fe3fc52. Thanks!

I guess it might be nice to move the URLconfs into a module to avoid cluttering up the main directory as more checks are added.

I can fix up the docstrings and move the URL confs to a directory this
evening (UK) Does dropping the url_ prefix sound ok, i.e.
urls_include.py -> urls/include.py
urls_name.py -> urls/name.py
...
On 21 September 2015 at 15:05, Tim Graham<EMAIL_ADDRESS>wrote:

I guess it might be nice to move the URLconfs into a module to avoid
cluttering up the main directory as more checks are added.
—
Reply to this email directly or view it on GitHub
https://github.com/django/django/pull/5301#issuecomment-141991761.

Yep, thanks.

urls_include.py -> urls/include.py

Actually, the directory can't be in a directory 'urls' since the checks are
already in urls.py. So could do e.g.
urlconfs/include.py
On 21 September 2015 at 15:14, Alasdair Nicol<EMAIL_ADDRESS>wrote:

I can fix up the docstrings and move the URL confs to a directory this
evening (UK) Does dropping the url_ prefix sound ok, i.e.
urls_include.py -> urls/include.py
urls_name.py -> urls/name.py
...
On 21 September 2015 at 15:05, Tim Graham<EMAIL_ADDRESS>wrote:

I guess it might be nice to move the URLconfs into a module to avoid
cluttering up the main directory as more checks are added.
—
Reply to this email directly or view it on GitHub
https://github.com/django/django/pull/5301#issuecomment-141991761.


chore: Activate project-manager in demo environment

I think, we are missing lens-dktk-datashield-test (a second server of Jan), lens-bonn and less-tuebingen

I added dktk-datashield-test, I'm not aware of Bonn or Tübingen.


mrpt_navigation: 0.1.10-0 in 'kinetic/distribution.yaml' [bloom]

Increasing version of package(s) in repository mrpt_navigation to 0.1.10-0:

upstream repository: https://github.com/mrpt-ros-pkg/mrpt_navigation.git
release repository: https://github.com/mrpt-ros-pkg-release/mrpt_navigation-release.git
distro file: kinetic/distribution.yaml
bloom version: 0.5.21
previous version for package: 0.1.8-0

mrpt_bridge

No changes

mrpt_local_obstacles

No changes

mrpt_localization

No changes

mrpt_map

No changes

mrpt_msgs

No changes

mrpt_navigation

No changes

mrpt_rawlog

No changes

mrpt_reactivenav2d
* fix build error against mrpt < 1.5.0
* Contributors: Jose-Luis Blanco-Claraco

mrpt_tutorials

No changes

Thanks!! :+1:


Added franzbot command about the 12.3 controller regression

Added a new command for the 12.3 controller woes, no rush!

also added a command with a set of controller aliases for xbox one that work for easy references


[Bug/Glitch] GUI glitches

Legacy4J Version
1.20.1
Mod Loader Version
Fabtic Loader 0.15.11
Bug/Glitch Occurrence Context
The craft GUI opens even when the pause menu is open.
https://github.com/user-attachments/assets/8b1f0541-2597-4099-9916-425727a75c0f
Crash Report
No response
What happened wrong?
I have assigned craft on the cross keys, which makes it difficult to navigate the menus.
This problem did not occur in 1.21.
(I used a translator so the text may be wrong.)

Not a problem with Legacy4J, it's certainly an external program, like Steam, that is remapping some buttons.

PCに詳しくないのでわからないのですが、おそらく外部プログラムは起動していないと思うのですが...。
有線のxbox oneコントローラー、Prism Launcher、legacy4Jのみをインストールしたブート構成で遭遇しました。
的外れだったらごめんなさい。

I don't know, I'm not familiar with PCs, but I'm probably not running any external programs...
I encountered this with a wired xbox one controller, Prism Launcher, and a boot configuration with only legacy4J installed.
Sorry if I'm missing the point.


warning: Undefined or garbage value returned to caller [clang-analyzer-core.uninitialized.UndefReturn]

Clang-tidy 12 is complaining:
/home/runner/work/cherry_blazer/cherry_blazer/_deps/boost_pfr-src/include/boost/pfr/detail/sequence_tuple.hpp:53:5: warning: Undefined or garbage value returned to caller [clang-analyzer-core.uninitialized.UndefReturn]
    return t.value;
    ^
/home/runner/work/cherry_blazer/cherry_blazer/src/canvas.cc:126:37: note: Assuming 'nth_batch' is < 'batch_count'
    for (std::size_t nth_batch = 0; nth_batch < batch_count; ++nth_batch) {
                                    ^
/home/runner/work/cherry_blazer/cherry_blazer/src/canvas.cc:126:5: note: Loop condition is true.  Entering loop body
    for (std::size_t nth_batch = 0; nth_batch < batch_count; ++nth_batch) {
    ^
/home/runner/work/cherry_blazer/cherry_blazer/src/canvas.cc:127:9: note: Loop condition is true.   Just my first time using this library.

Please, provide a minimal working example to reproduce the issue

Here: https://godbolt.org/z/GsEd7YqjP

Looks like it was fixed in https://github.com/boostorg/pfr/commit/2a1fd53724d41fe590633d67f8f712c2e06a6398
Thanks for the bugreport!


[IP/Domain/URL] Incorrect HTTP requests

Bug overview:
Incorrect HTTP requests type (GET instead of POST) [1, 2, 3].
Code proposal:
Now:
    def scan_ip(self, target: str) -> dict:
        ...
        response = requests.get(url, headers=header)
        ...

To be:
    def scan_ip(self, target: str) -> dict:
        ...
        response = requests.post(url, headers=header)
        ...

Affected methods:
Currently, confirmed:

scan_ip;
Seems like master branch affected.

References:

Metadefender IP scan API
Metadefender Domain scan API
Metadefender URL scan API

Not-a-bug, label removed.

Not-a-bug, label removed.


nvm.sh - add NVM_INC for the include path

This is a very simple change that makes it easy to configure include paths when developing node addons in C/C++. I use vscode which is not aware of the nvm. As a result it cannot find node include files and flags them as errors.
I worked on creating a vscode extension that would handle this but it didn't work well and requires significantly more work than this change. The one line change in this PR is a much cleaner approach (provided that one more NVM environment variable is ok).
I opted for NVM_INC as opposed to NVM_INCLUDE just because all the other NVM env vars were 3 characters or less.
This allows my c_cpp_properties.json file to use the env var like:
{
    "configurations": [
        {
            "name": "Linux",
            "includePath": [
                "${workspaceFolder}/**",
                "${workspaceFolder}/node_modules/nan",
                "${workspaceFolder}/node_modules/node-addon-api",
                "${env:NVM_INC}"
            ],
            "defines": [],
            "compilerPath": "/usr/bin/gcc",
            "cStandard": "c11",
            "cppStandard": "c++11",
            "intelliSenseMode": "clang-x64"
        }
    ],
    "version": 4
}

I have not tested it everywhere because if export works for NVM_BIN it should work for NVM_INC as well.

thank you - i don't think i've ever deactivated or unloaded. changes submitted.
i added it to both but it looks like "unload" invokes "deactivate" so maybe the unset in "unload" is not needed? i'm happy to make another change if you'd like.
btw, i can't live without nvm - awesome job.

You’ve unset dir but not inc?

yes, i did. that was pretty careless of me - sorry.

it doesn't look like anything went wrong in the one test that failed - it timed out. is there something i should fix?

Nah, I reran it.

if you'd like i'll take a stab at adding this to the docs.

Thanks, that'd be great :-)


Update setup.py

just a minor typo :)

Hah, I missed this PR and independently fixed it. But merged anyway so you get credit for catching it. ;)

Hey, thanks! No credit for me at all, I just bumped into your project and saw this minor typo, nothing special. But your lib is awesome! No dependencies, highly pythonic; I can use it without any effort with other libs, including Twisted. Exactly how a SM should behave ;) Thaks a lot!


doc: front page of etcd3 doc

/cc @heyitsanthony @joshix @weiliendang
Fix https://github.com/coreos/etcd/issues/5106

/cc @philips

via style linter
docs.md.3: eschew you ("etcd is a distributed key-value store designed for serving most critical data. It enables reliable distributed coordination, like distributed locking, leader election and barrier. Once an etcd cluster is set up, it is supposed to be there for you \"forever\".")
docs.md.5: header: word capitalized ("Started" in "## Getting Started")
docs.md.37: header: word capitalized ("Compatibility" in "## Upgrading and Compatibility")

@joshix Fixed. PTAL.

@heyitsanthony Good job...

@heyitsanthony Fixed.

lgtm aside from the concepts/internals nit


[Bug]: CodeCompanionChat Attempt to index a nil value

Your minimal.lua config
---@diagnostic disable: missing-fields

--NOTE: Set config path to enable the copilot adapter to work.
--It will search the follwoing paths for the for copilot token:
--  - "$CODECOMPANION_TOKEN_PATH/github-copilot/hosts.json"
--  - "$CODECOMPANION_TOKEN_PATH/github-copilot/apps.json"
vim.env["CODECOMPANION_TOKEN_PATH"] = vim.fn.expand("~/.config")

vim.env.LAZY_STDPATH = ".repro"
load(vim.fn.system("curl -s https://raw.githubusercontent.com/folke/lazy.nvim/main/bootstrap.lua"))()

-- Your CodeCompanion setup
local plugins = {
  {
    "olimorris/codecompanion.nvim",
    dependencies = {
      { "nvim-treesitter/nvim-treesitter", build = ":TSUpdate" },
      { "nvim-lua/plenary.nvim" },
      { "hrsh7th/nvim-cmp" },
      { "stevearc/dressing.nvim", opts = {} },
      { "nvim-telescope/telescope.nvim" },
    },
    opts = {
      --Refer to: https://github.com/olimorris/codecompanion.nvim/blob/main/lua/codecompanion/config.lua
      strategies = {
        --NOTE: Change the adapter as required
        chat = { adapter = "openai" },
        inline = { adapter = "openai" },
        agent = { adapter = "openai" },
      },
      opts = {
        log_level = "DEBUG",
      },
    },
  },
}

require("lazy.minit").repro({ spec = plugins })

-- Setup Tree-sitter
local ts_status, treesitter = pcall(require, "nvim-treesitter.configs")
if ts_status then
  treesitter.setup({
    ensure_installed = { "lua", "markdown", "markdown_inline", "yaml" },
    highlight = { enable = true },
  })
end

-- Setup completion
local cmp_status, cmp = pcall(require, "cmp")
if cmp_status then
  cmp.setup({
    mapping = cmp.mapping.preset.insert({
      ["<C-b>"] = cmp.mapping.scroll_docs(-4),
      ["<C-f>"] = cmp.mapping.scroll_docs(4),
      ["<C-Space>"] = cmp.mapping.complete(),
      ["<C-e>"] = cmp.mapping.abort(),
      ["<CR>"] = cmp.mapping.confirm({ select = true }),
      -- Accept currently selected item. Set `select` to `false` to only confirm explicitly selected items.
    }),
  })
end

Error messages
Error executing Lua callback: .../nvim/lazy/codecompanion.nvim/lua/codecompanion/init.lua:98: attempt to index a nil value
stack traceback:
        .../nvim/lazy/codecompanion.nvim/lua/codecompanion/init.lua:98: in function 'chat'
        ...m/lazy/codecompanion.nvim/lua/codecompanion/commands.lua:63: in function <...m/lazy/codecompanion.nvim/lua/codecompanion/commands.lua:62>

Log output
No log file was created
Health check output
codecompanion: require("codecompanion.health").check()

- Neovim version: 0.11.0
- Log file: /home/eslamallam/personal_projects/testing/nvim/.repro/state/nvim/codecompanion.log

Plugins:
- OK plenary.nvim installed
- OK nvim-treesitter installed
- OK nvim-cmp installed
- OK telescope.nvim installed
- OK dressing.nvim installed

Tree-sitter parsers:
- OK markdown parser installed
- OK yaml parser installed

Libraries:
- OK curl installed

Describe the bug
When I run the command :CodeCompanionChat it throws the error pasted above. All other commands such as :CodeCompanionToggle or opening it from the actions menu works fine.
Reproduce the bug

Open neovim
Run :CodeCompanionChat

Final checks

[X] I have made sure this issue exists in the latest version of the plugin
[X] I have tested with the minimal.lua file from above and have shared this
[X] I have shared the contents of the log file

Thanks and great timing...this is fixed now as per 0fa1748


task scheduler that support parallelization and crash recovery (continue with only unfinished job and dont rerun existing results)

reference solution: https://github.com/marrlab/DomainLab/pull/79/files

What happens if the code crashes? Could you still retrieve partially the results instead of letting the whole benchmark to restart again?

How do you read a yml file and according to the configuration there execute the benchmark?

How do you paralllelize the experiment for stochastic variations and hyper-parameter variations?

snakemake support MPI, slurm, and other task dispatcher
https://snakemake.readthedocs.io/en/stable/executing/cluster.html

I think the easiest way for parallelization would be to run different algorithms alongside each other.

Based on the slurm scripts, a possible yaml file to represent benchmarking could be:
task_1:
	aname: diva
	epos: 1
	batchsize:
	startseed:
	endseed:
	paths:
		tpath: examples/tasks/demo_task_path_list_small.py
		npath: examples/nets/resnet.py
	algo_conf:
		npath_dom: examples/nets/resnet.py
		gamma_y: 1e5
		gamma_d: 1e5

task_2:
	aname: jigen
	epos: 1
…….

This can be combined with the yaml format @schoersch created in https://github.com/marrlab/DomainLab/pull/90

@schoersch @rahulbshrestha @Car-la-F @xinyuejohn
snakemake support MPI, slurm, and other task dispatcher
https://snakemake.readthedocs.io/en/stable/executing/cluster.html

@rahulbshrestha
I think it would be easier if we replace
	algo_conf:
		npath_dom: examples/nets/resnet.py
		gamma_y: 1e5
		gamma_d: 1e5

by
	npath_dom: examples/nets/resnet.py
        parameters:
		gamma_y: 1e5
		gamma_d: 1e5

such that we have one node containing only parameters

I'm going to start with snakemake for task setup and scaling and see how far we get. But there is at least stated:
"[Workflows] can be seamlessly scaled to server, cluster, grid and cloud environments, without the need to modify the workflow definition."
snakemake

I changed the format of the yaml file a bit. The current yaml file looks like this:
# Example benchmark config script.

# Arguments set here are passed to each task.
# Specifications inside the tasks taking precedence.

tpath: examples/tasks/task_vlcs.py  # dataset

# list of all domains that are used as test domain
# in a leave-one-out setup, i.e. for each run,
# one domain from this list is chosen as test domain
# while training is performed on all other domains
# of the specified dataset.
# TODO domains is a misleading name here.
domains:
  - caltech
  # - sun
  # - labelme

output_dir: zoutput/benchmarks/demo_benchmark

# number of hyperparameter samples per task.
# Thus, the total runs of each task are given
# by len(domains) * num_param_samples * num_seeds (see below)
num_param_samples: 2

epos: 2
batchsize: 2
# the seed is increased by +1 until it reaches endseed.
# endseed is included, so in total startseed - endseed + 1
# different seeds are used to estimate the stochastic
# variance.
startseed: 1
endseed: 2  # currently included

# Each node containing the aname property is considered as a task.
Task1:  # name
  # Parameters that are fixed for all runs of this task.
  aname: diva
  nname: alexnet
  nname_dom: alexnet

  # specification of parameters that shall vary
  # between runs to analyze the sensitivity
  # of this task w.r.t. these parameters.
  hyperparameters:
    # Each parameter must contain:
    # - distribution (uniform | loguniform | normal | lognormal)
    # - min and max if distribution is uniform or loguniform
    # - mean and std if distribution is normal or lognormal

    # step is optional and defines discrete parameters
    # with the given step size.
    # If min/mean and step are integer valued,
    # the hyperparameter is ensured to be integer valued too.
    # Otherwise, it is a float and rounding errors can occur.
    gamma_y:
      min: 10e4
      max: 10e6
      step: 1
      distribution: uniform

    gamma_d:
      min: 1e4
      max: 1e6
      step: 1
      distribution: uniform

Task2:
...

The snakemake file is design to receive this benchmark yaml file as configfile. As of now, the snakemake than samples the hyperparameters, runs the experiments and aggregates the results in a single csv file.

I spent some time with snakemake and got an early wip state.
@smilesun this adds snakemake as dependency. I'm going to make a pr for this to main_benchmark. Is this fine, or do we need to have the dependencies on master for the ci pipeline?
Also @Car-la-F uses seaborn for plotting. Since this makes life much easier than plain matplotlib, I would consider adding both. Please let us know how you feel about these packages.
FYI: the early wip code for snakemake is on benchmark_snakemake. Please be aware that this is incomplete and I might force push to this branch anytime. So you're welcome to have a look, but don't build on this. I'm going to open a PR towards the end of this week.

sorry I kind of missed this thread among the simultaineous developments of many branches, yes, i think we can support more packages. those packages have been there for a long time, stable enough!


cue fmt changed well formated code

What version of CUE are you using (cue version)?

$ cue version
v0.7.0-rc.1

Does this issue reproduce with the latest stable release?
no
What did you do?

exec cat fmt.cue
cmp stdout fmt.cue

exec cue fmt fmt.cue
cmp stdout fmt.cue

-- fmt.cue --
a: {
	b: ""
	c: *{} | {d: string}
}

What did you expect to see?
PASS
What did you see instead?
FAIL: ... stdout and fmt.cue differ
spoiler: formated output is

a: {
	b:           ""
	c: *{} | {d: string}
}

Same with arrays:
aaa: string
b:   string
c:   [...string]

Since 0.7, it will be reformatted as
aaa: string
b:   string
c: [...string]

looks like this is a duplicate of #3015

Agreed, thanks @NoamTD


Improved error Messaging

issue #64
Have added login to improve handling, have also changed how submission works(added submission login in Form.js instead of index.js).
Do let me know if any changes.

what are your thoughts on .....

have used useReducer and dispatch instead of a callback, do let me know if this is correct.

With the most recent changes I am now seeing a blank screen when clicking to RSVP for the event https://deploy-preview-75--friendly-rosalind-7571fd.netlify.app/online-2021-june

With the most recent changes I am now seeing a blank screen when clicking to RSVP for the event https://deploy-preview-75--friendly-rosalind-7571fd.netlify.app/online-2021-june

It was because I did extract  error from the state, have fixed it.


Fixed Link

#35
changed link from
https://github.com/approachable-io/approachable-io/issues
to
https://github.com/approachable-io/software-interview-prep/issues

Thank you!


Remove bounds on T for Debug, PartialEq and Hash impls

RawParts derives Debug, PartialEq, and Hash. The derive macros from core add bounds on T even when they are not required, as is the case with the T in RawParts which is only a pointer and impls these traits regardless of what T is.
Remove the derived impls and manually implement these traits.
Such a change warrants a minor version bump.

I've been looking to get back into rust and have been following artichoke for a while now, I would like to work on this.

Thanks @molinarim it's all yours. Looking forward to your PR.

@lopopolo Sorry I've been taking so long on this issue, I'm a little rustier than I realized. I do have a couple of questions I hope you can answer:

For PartialEq, should it compare the raw parts themselves or just compare the pointer to show that the vector's are the same?
https://github.com/molinarim/raw-parts/blob/68a1fc8d14824da540ecbd294f147e9ed993297b/src/lib.rs#L134-L140
For Hash, should every part get hashed or just the ptr?

@molinarim I think for now, let's keep the manual impls the same as the derived ones, which means that every property is checked for equality and every property is hashed.

@molinarim for this bit, you can use f.debug_struct.
https://github.com/molinarim/raw-parts/blob/68a1fc8d14824da540ecbd294f147e9ed993297b/src/lib.rs#L128-L132
https://doc.rust-lang.org/stable/std/fmt/struct.Formatter.html#method.debug_struct

Thanks for the insights! I'll get back on it shortly.


[ci] Fix maestro publishing for stable packages

We've seen the build promotion pipeline fail when trying to publish
stable package versions:
error : Package 'Microsoft.iOS.Ref.net8.0_17.5' has stable version '17.5.8001' but is targeted at a non-isolated feed 'https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet8/nuget/v3/index.json'

This is because we were not declaring these packages as stable when
building the build asset registry manifest.
Fix this by adding passing the $(IsStableBuild) property to the build
asset manifest creation task. This property needs to be updated manually
when switching to stable package versioning (see commit 4ea5dbb921).
When $(IsStableBuild) is set to true, packages will be pushed to an
isolated feed during publishing, such as:
  Package<EMAIL_ADDRESS>(Shipping) should go to https://pkgs.dev.azure.com/dnceng/public/_packaging/darc-pub-dotnet-android-b8317b6f/nuget/v3/index.json (Isolated, Public)

Tested this by rebuilding the manifest for some .NET 8 stable packs with $(IsStableBuild)=true, and manually trying to add that build to the "General Testing" channel: https://dev.azure.com/devdiv/DevDiv/_build/results?buildId=9898256&view=logs&j=ba23343f-f710-5af9-782d-5bd26b102304&t=74531eb2-9b39-5603-839e-94e3ba212b65


Callback-Function

Hello, i read the article https://2captcha.com/2captcha-api#solving_recaptchav2_new and because the site, where i try to solve the captcha do not have a button that need to be pressed after the captcha is solved, it tells me that i need to call a callbackfunction. However i do not find the name of this function on the Website. Does anyone probably could tell me what the callbackfunction from discord.com/register is? Would be really kind.

I have to close this because this issue isn't related to this module. Sorry.


test(types): contextual types

Enable test and include temporary workaround by providing explicit types:
// FIXME: contextual types should work with express path middleware (without providing explicit types)
middleware<express.Request, express.Response>

coverage: 97.619%. remained the same when pulling b18eb7711742bf4678e180d89bc8c840eb8ce303 on test-contextual-types into a7039693e6094546ead45f462ce1e79ec8d0d616 on master.


Fixed existsById API in ReactiveCosmosTemplate

Fixed existsById API in ReactiveCosmosTemplate
Fixes: https://github.com/Azure/azure-sdk-for-java/issues/40019

API change check
API changes are not detected in this pull request.

@trande4884  - CosmosTemplate doens't have existsById API, so we are good.

/azp run java - spring - cosmos - tests

/azp run spring - cosmos - tests

/azp run java - spring - tests


Add netlink Statistics to nodes

Add Statistics returned by netlink to interface nodes so that we can get dropped packet number, etc...
This need to add an async mechanism to get metrics in order to have them updated.

I see two possible go libraries to do that :

https://github.com/safchain/ethtool : to get stats with syscalls
https://github.com/shirou/gopsutil/tree/master/net : to get stats from linux net/dev files

Something we have to take care is the way the library is implemented especially around the syscalls as we got issues with namespace and goroutine. Something fixed in ethtool lib but that doesn't mean this is the best choice.

I'm currently playing with the ethtool lib, and indeed, I'm having issues with syscall. I was suggesting your ethtool lib to avoid another dependency. but it might be safer to use gopsutil that only poll net/dev files. BTW, should it be treated as a new probe?

I meant that ethtool is safe with namespaces, not sure about gopsutil. And yes it should be treated as another probe polling interface metrics. I'll have a look at gopsutil to be sure.

I had at quick look at gopsutil and indeed no namespace safe, so If we want to use it we will have to send some PR to fix it.

What kind of issue you have with ethtool ? maybe you could open an issue

done :
https://github.com/safchain/ethtool/issues/11

fixed: https://softwarefactory-project.io/r/#/c/6331/


Punishments: Fix Punishments.roomUnblacklistAll

should use Punishments.saveRoomPunishments() instead of the global version at the end of the Punishments.roomUnblacklistAll
add an extra ignoreWrite argument to be passed to roomUnblacklist => roomUnpunish.  That way, it doesn't try to write to the tsv file for each loop of the forEach called in roomUnblacklistAll

Ohh, my bad, thanks for pointing this out!


[RFC] () "method"/operator on types meaning .new

I've been thinking about this for a while.
Used ~2488 times in the compiler source (some faux matches, semi-naïve RE)
foo = some_array[some_index]

Used ~5676 times in the compiler source:
foo = SomeType.new(possibly, arguments)

I can't see why new doesn't have a terser () "method"/operator mapped to it, while we are relieved of writing some_array.get(some_index) and some_array.set(some_index, some_val) - a construct used half as often.
Both are too commonly used to necessitate cluttering them with latin lettered methods.
foo = Foo(47)
bar = Bar("Gimme Two Foos", foo, Foo(42))
some_var[0] = other_var[0] + third_var[some_index]

Compared too:
foo = Foo.new(47)
bar = Bar.new("Also Takes Two Foos", foo, Foo.new(42))
some_var.set(0, other_var.get(0) + third_var.get(some_index))

Explicit generics are seldom used, thanks to inference, but would use doubled ():
foo = Foo(Int32)(47)

The first on creates the type instance from the generic type constructor (already established syntax), the second creates the value instance.
Reasons for

Less boiler plate for these strongly mindshared constructs
By the usage stats above
What feels simply right to many coders (presidency in many different languages)
The fact that Crystal with it's strong rules on Types being capitalized, vars beginning with underscores (I think that's a great idea!) - has an ideal situation for visual disambiguation.

Against

Some from the Ruby camp seem to be very locked in to what's been done before and what they're habituated too, and wants Crystal to look like that (OK, OK, this puts me in the center of flame throwing armageddon - it's said tongue in cheek - alright!? :-)

Thoughts? Wish from me: please try to see Crystal as a distinct unique language, even though inspired by a great clean syntax from another, there will definitely be more and more users of it from all kinds of language backgrounds, because it's great.

This change would require changing the syntax of generic types. Otherwise this is ambiguous:
Foo(Int32)

Is that a new instance of the Foo class? or is Foo a generic class that's a generic instance type?

I'm not against this idea. In fact we though about it some time ago. But it will need a different syntax. Or we will need to change how to specify generic types, but Foo[...] means array access and Foo{...} means custom array or custom hash, and Foo<...> is hard to parse (but could be an option, maybe by having Foo< and Foo < be different things).
There's also the thing that parentheses are optional in calls. So it would make sense to allow this:
Foo<Int32> 47
Point 42, 32

Which starts to feel strange. You can say "parentheses are optional except in implicit constructor syntax", but we don't like inconsistencies.

@waj, @asterite: Yes, I thought about that. One notation that came to mind was Foo[Bar] for generics, as you also mention. It gives a tighter impression in my eyes.
I'm not too fond of the C++ style (also used by Java, Kotlin, C# etc. C braces like linguas), even though I've coded it 16+ years. On a side note, there's a bunch of languages that require spacing all operators, but I'm uncertain that's a wise path, however still open to that idea.
The Foo[Bar] shouldn't be ambiguous contextually and it should be possible to determine already at the parsing stage whether we're dealing with a type or an instance - if indeed the initial uppercase/lowercase rules are 100% consistent?
The optional parentheses would indeed be nice for this too in my eyes, and consistent which is good.
Some extreme examples with current and two proposed styles compared. This is kind of stupid to use as comparison though, since you'd most never write code like this:
Note: Since the highlighter is not adapted to these different styles, I've purposely removed it to get a fairer comparison.
foo1 = Foo(Int32).new 47
foo2 = Foo(Int32).new(47)
foo3 = Foo.new 47
foo4 = Foo.new(47)
point = Point.new 42, 32

def mystic_method(wants_type, wants_value); end

something = mystic_method Bar(Foo(Float64)), Bar.new(47.0)
nextthing = mystic_method(Bar(Foo(Float64)), Bar.new(47.0))
verboser = mystic_method(Bar(Foo(Float64)), Bar(Foo(Float64)).new(47.0))

foo1 = Foo<Int32> 47
foo2 = Foo<Int32>(47)
foo3 = Foo 47
foo4 = Foo.new(47)
point = Point 42, 32

def mystic_method(wants_type, wants_value); end

something = mystic_method Bar<Foo<Float64>>, Bar 47.0
nextthing = mystic_method(Bar<Foo<Float64>>, Bar(47.0))
verboser = mystic_method(Bar<Foo<Float64>>, Bar<Foo<Float64>>(47.0))

foo1 = Foo[Int32] 47
foo2 = Foo[Int32](47)
foo3 = Foo 47
foo4 = Foo.new(47)
point = Point 42, 32

def mystic_method(wants_type, wants_value); end

something = mystic_method Bar[Foo[Float64]], Bar 47.0
nextthing = mystic_method(Bar[Foo[Float64]], Bar(47.0))
verboser = mystic_method(Bar[Foo[Float64]], Bar[Foo[Float64]](47.0))

And, worth repeating, it should be kept in mind that the explicit type class instantiations likely will remain very uncommon.
Anyone have any crazy out of the box ideas for instantiation syntax? Wild ideas often distil down to innovative sane ones :-)

I'll close this. new works well, it's just three chars, it's a method that you can redefine and give any meaning you want, etc. Another syntax will hide this and make users having to learn more things.

There's also the thing that parentheses are optional in calls. So it would make sense to allow this:

Foo<Int32> 47
Point 42, 32

What's wrong with that? It's actually quite elegant. Also, could : work?
Foo:Int32(47)


ASCII easter egg is broken

Looks like the API request goes to fusion.artsy.net which returns an empty object for the .txt api request. The client then gets that and appends `[object Object] below the artwork.

@craigspaeth

@mzikherman - did the new image pipeline stuff end up removing the ASCII-fy-ness?

Yes, we don't really support that anymore :(

OK, calling the feature dead - if you care @zamiang - it's still alive in iOS where we do the conversion natively


Can't download video from ABC iview.

Please follow the guide below

You will be asked some questions and requested to provide some information, please read them carefully and answer honestly
Put an x into all the boxes [ ] relevant to your issue (like this: [x])
Use the Preview tab to see what your issue will actually look like

Make sure you are using the latest version: run youtube-dl --version and ensure your version is 2018.11.18. If it's not, read this FAQ entry and update. Issues with outdated version will be rejected.

[ ] I've verified and I assure that I'm running youtube-dl 2018.11.18

Before submitting an issue make sure you have:

[ x] At least skimmed through the README, most notably the FAQ and BUGS sections
[ x] Searched the bugtracker for similar issues including closed ones
[x ] Checked that provided video/audio/playlist URLs (if any) are alive and playable in a browser

What is the purpose of your issue?

[ ] Bug report (encountered problems with youtube-dl)
[ ] Site support request (request for adding support for a new site)
[ ] Feature request (request for a new functionality)
[ x] Question
[ ] Other

This is my first time using youtube-dl. I'm trying to download a video from ABC iview (using the steps shown in this tutorial video https://www.youtube.com/watch?v=fKe9rV-gl1c), but, I get the error message "ERROR: Unsupported URL".
The video I'm trying to download is https://iview.abc.net.au/show/christmas-with-poh
Am I doing something wrong? Any help would be appreciated.
Thank you.

Duplicate of #16868


Fix RadecoFunction#call_sites

The implementation of RadecoFunction#call_sites is fixed. (But map field is empty)
Also I have added a method RadecoFunction#call_refs.

@kriw I'm sorry, but I think I missed it, can I know what this PR is for? What was the original bug and what is this trying to fix?

I think you've misunderstood what CallGraph is; nodes are functions and edges are callsites/call-instructions.
I'm not entirely sure what call_refs is supposed to do but the vector it returns should always have a length of exactly one and that one value should always be RadecoFunction.cgid. A violation of either of these is (imho) a panic-worthy bug.

If it helps, an example of how I used CallGraph is in fix_opcalls.

@HMPerson1 it helps. Thank you.

@sushant94 ping?
I will rebase #139 after you merge this PR.


Install self in CI workflow

I think this was running an older bugged version where it kept rolling the times. Restarting the container to get a new version


Refactor Hash Size Warning Logic into Common Module

While manually breaking up lines which were too long, I encountered the same chunk of code copied and pasted many times over and over again in various scripts in scripts/ and sandbox/. We definitely want to place this in a common module for maintainability and reusability reasons.

working on this.

The threshold for what collision rate is too high varies in different parts of the code. What threshold(s) would you like to use? For now, I will pass the existing thresholds as an argument to the check function.
Here are the places the duplicate logic is found (or should be found?), and their thresholds:
Collect variants -- .2 (with a comment saying don't change)
Collect Reads -- .2 (with a comment saying don't change)
Sort by med. -- .8
do partition -- .15 (with a comment saying the actual max is .18, don't change)
filter abund. -- no check
load graph -- .15
load into c. -- no check
norm by med. -- no check
trim low abund. -- no check

Also!
Some places had the opportunity to force listed and others didn't. Is there a pattern to where where you'd like to allow for a force? Right now, I'm fixing as if you want to allow for a force at any time.

Fixed by #944


Menu won't open on iOS 14.2 beta 2

I have read the guidelines for contributing and I understand

[✔] My issue is happening in the latest version of SideMenu (older versions are no longer maintained).
[✔] My issue was not solved in the README.
[✔] My issue can not be answered on stackoverflow.com.
[✔] My issue is not a request for new functionality that I am unwilling to build and contribute with a pull request.
[✔] My issue is reproducible in the demo project.

Describe the bug
Menu won't open on iOS 14.2 beta 2. App stops responding.
To Reproduce
Steps to reproduce the behavior:

Install iOS 14.2 beta 2 or download Xcode 12.2 beta 2.
Run the demo either on device or in the simulator.
Try to open the menu.

Expected behavior
Menu should open. App should stay responsive.

Yeah this is giving a memory leak for me as well.

Betas being what they are, I am not supporting anything until it is released. You're welcome to produce a fix to support others updating for beta until then. Please reopen this issue if it persists after release.
@RMSchlachter, SideMenu is held in memory deliberately to increase gesture responsiveness for reveal.


respect userOptions.eslintPath

#user should not depend eslint/lib/formatters/stylish if he appoint an eslintPath.

Can you fix failing test please?

@MoOx  I edited the test/eslint-path to fix some test check。but still has one test faild.
I don't know why..

It's related to a specific version of node/npm with webpack one. You need to check here https://travis-ci.org/MoOx/eslint-loader/builds/289800514

@lmnsg I think I fixed CI on master branch. Can you rebase your branch on master? Should help :)

@MoOx  It's ok. 😆

@MoOx I re-pushed my code, please review it again...

Released in 2.0.0


Anti-Cap Feature is broken ?

Cap Option Is Broken even disabled it still doen't let players say anything "LIKE THAT"
I made everything on false in config.yml and even with every features false + a server restart the anti cap still enabled or does there anything else doing this outside of config.yml ? I'm asking that here cause there no discord for support.

Oh great :D

I want to add also that if i use cap letter when i am op it works.

Yes, this function already exists in TChat, but it does not work for the same reason that does not work to disable anti cap (the Banned Words turns the entire sentence in uppercase to check for banned words and I did not think at the time that would affect this system) is corrected in 4.1.3, now the Banned Words do not differentiate uppercase and lowercase


Webcord turns blank after a few seconds of use

Describe the bug
webcord window turns blank after a few seconds of use.
The issue started about a week ago after an update.
running under -v gives this output:
Renderer process crashed - see https://www.electronjs.org/docs/tutorial/application-debugging for potential debugging information.
Steps To Reproduce
Steps to reproduce the behavior:

install webcord on unstable branch
open app and wait for a few seconds

Expected behavior
open the app without a crash
Notify maintainers
@huantianad
Metadata
❯ nix-shell -p nix-info --run "nix-info -m"

system: "x86_64-linux"
host os: Linux 6.5.1, NixOS, 23.11 (Tapir), 23.11.20230908.db9208a
multi-user?: yes
sandbox: yes
version: nix-env (Nix) 2.17.0
nixpkgs: /nix/store/9incrwprw2s90minyy0gpmwbxmrkcx1v-source

Yes, I can reproduce this. This is a known upstream bug in Electron, and it has already been reported on both webcord and electron repos. The only workaround for now is to revert back to Electron 25 (for example the AUR package over on Arch has already done this).
I suggest that the webcord package should revert back to electron 25 until electron 27 comes out (which seems to not have this problem anymore).

Thanks :)


issue-665: fix example when using json=",string"

Describe the PR
Fix the json example when a struct field has the json:",string" tag.
Relation issue
https://github.com/swaggo/swag/issues/665
Additional context
encoding/json states:

The "string" option signals that a field is stored as JSON inside a JSON-encoded string. It applies only to fields of string, floating point, integer, or boolean types. This extra level of encoding is sometimes used when communicating with JavaScript programs:

Before this fix, the provided example would fail json.Unmarshal:

After fix:

Codecov Report

Merging #677 into master will increase coverage by 0.29%.
The diff coverage is 90.00%.

@@            Coverage Diff             @@
##           master     #677      +/-   ##
==========================================
+ Coverage   85.00%   85.29%   +0.29%
==========================================
  Files           7        7
  Lines        1807     1823      +16
==========================================
+ Hits         1536     1555      +19
+ Misses        172      171       -1
+ Partials       99       97       -2

Impacted Files
Coverage Δ

parser.go
80.42% <90.00%> (+0.63%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc90151...fa78550. Read the comment docs.


Add failing tests for rendering with layouts

Summary

This is a merge request for discussing a possible API for implementing #391
I would have liked to have layouts included by default with render. I would understand if that is deemed an API break and a alternative needs to be determined.
Additionally, I have added a test that checks the view context is shared between the layout and the component.
Other Information

@fsateler would you be up for pairing on this one? Email me<EMAIL_ADDRESS>

@fsateler would you be up for updating this PR?

Can we merge this @joelhawksley?


qualname inconsistent on Python 2, returns a descriptor on the class instead of class name

Over in https://github.com/zopefoundation/zope.app.apidoc/issues/25 we noticed an issue with the __qualname__ of functions (at least) on Python 2. Because it's implemented as a PyGetSetDef, when accessed on the class, it returns a getset_descriptor object instead of the class name.
Python 2.7.15 (default, May  2 2018, 00:53:27)
[GCC 4.2.1 Compatible Apple LLVM 9.1.0 (clang-9<IP_ADDRESS>)] on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>> from Cython.Compiler.Visitor import recursively_replace_node
>>> recursively_replace_node
<cyfunction recursively_replace_node at 0x10cd04950>
>>> recursively_replace_node.__class__
<type 'cython_function_or_method'>
>>> recursively_replace_node.__qualname__
'recursively_replace_node'
>>> recursively_replace_node.__class__.__qualname__
<attribute '__qualname__' of 'cython_function_or_method' objects>

That breaks code expecting a string.
Python 3 (at least 3.6, the only version I checked) doesn't seem to have this problem; presumably the built-in meaning of __qualname__ is taking over? The results are consistent with other built-in functions by returning a string.
Python 3.6.6 (default, Jun 28 2018, 05:43:53)
[GCC 4.2.1 Compatible Apple LLVM 9.1.0 (clang-9<IP_ADDRESS>)] on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>> from Cython.Compiler.Visitor import recursively_replace_node
>>> recursively_replace_node
<cyfunction recursively_replace_node at 0x10e9a66c0>
>>> recursively_replace_node.__class__
<class 'cython_function_or_method'>
>>> recursively_replace_node.__qualname__
'recursively_replace_node'
>>> recursively_replace_node.__class__.__qualname__
'cython_function_or_method'
>>> import os
>>> os.chmod.__class__.__qualname__
'builtin_function_or_method'

It seems like it would be a lot of work to transform the PyGetSetDef for __qualname__ into a custom descriptor that does in the __dict__ (the only way I know how to fix it, but I am no CPython API expert!). Python 2 functions don't generally have __qualname__, perhaps the easiest thing to do would just be to #ifdef the __qualname__ out of the __pyx_CyFunction_getsets?
(I understand if that's not appealing either; this isn't a big deal, we plan to workaround it on that project.)

Isn't it just a matter of adding a constant string to the class dict? I think it's a bug that this used a descriptor in the first place. The PEP only refers to the attribute on classes (and functions).

Isn't it just a matter of adding a constant string to the class dict?

Maybe? You're not supposed to be able to assign to __qualname__, though, so some code still needs to run to prevent that.

I think it's a bug that this used a descriptor in the first place.

That's how CPython implements it for its builtin functions, though. Compare the __dict__ for all with the dict for a Cython function (Python 3 by necessity, since Python 2 doesn't have __qualname__):
>>> type(all).__qualname__
'builtin_function_or_method'
>>> type(all).__dict__
mappingproxy({...
              '__ge__': <slot wrapper '__ge__' of 'builtin_function_or_method' objects>,
              '__module__': <member '__module__' of 'builtin_function_or_method' objects>,
              '__doc__': <attribute '__doc__' of 'builtin_function_or_method' objects>,
              '__name__': <attribute '__name__' of 'builtin_function_or_method' objects>,
              '__qualname__': <attribute '__qualname__' of 'builtin_function_or_method' objects>,
...
              '__text_signature__': <attribute '__text_signature__' of 'builtin_function_or_method' objects>})
>>> type(recursively_replace_node).__dict__
mappingproxy({
              '__module__': <member '__module__' of 'cython_function_or_method' objects>,
              'func_doc': <attribute 'func_doc' of 'cython_function_or_method' objects>,
              '__doc__': <attribute '__doc__' of 'cython_function_or_method' objects>,
              'func_name': <attribute 'func_name' of 'cython_function_or_method' objects>,
              '__name__': <attribute '__name__' of 'cython_function_or_method' objects>,
              '__qualname__': <attribute '__qualname__' of 'cython_function_or_method' objects>,
              '__self__': <attribute '__self__' of 'cython_function_or_method' objects>,
...
              '__annotations__': <attribute '__annotations__' of 'cython_function_or_method' objects>})

Duplicate of #2772 and fixed by #2773.


Release notes 0.3.6

Description
Release notes for 0.3.6

Why is windows failing again? 😞

Why is windows failing again? 😞

I say we drop support for it

Why is windows failing again? 😞

Unfortunately that PR didn't fix it - it still seems the failure is sporadic, not every time - and maybe that fixed reduced the number of times, but it might not be gone entirely.
Just because it might be of interest, according to https://pypistats.org/packages/napari
~20% of our installs are windows

~20% of our installs are python 3.6

I will merge this after some tests pass


Document search

Description
A document search functionality would be a great feature for Verba.
The goal is to find relevant documents based on a text input.
Additional context
https://qatalog.com/product/
https://dash.dropbox.com/features/universal-search

The Document Explorer should have a search bar to find documents via Bm25 search, you can find it in the Documents tab 😄

I cannot see the document explorer button over here, can you help me?

Hey @SaiAkhil066 , what are you seeing on the UI?


Cannot download grpc precompiled binaries

<EMAIL_ADDRESS>macOS 10.14
Running following npm command:
npm install -g composer-cli
I expect to see a successful installation, but I get some errors, the first of those is:
node-pre-gyp ERR! Tried to download(403): https://storage.googleapis.com/grpc-precompiled-binaries/node/grpc/v1.10.1/node-v64-darwin-x64-unknown.tar.gz
node-pre-gyp ERR! Pre-built binaries not found for<EMAIL_ADDRESS>and<EMAIL_ADDRESS>(node-v64 ABI, unknown) (falling back to source compile with node-gyp)
node-pre-gyp ERR! Pre-built binaries not installable for<EMAIL_ADDRESS>and<EMAIL_ADDRESS>(node-v64 ABI, unknown) (falling back to source compile with node-gyp)
node-pre-gyp ERR! Hit error Connection closed while downloading tarball file

Trying to download requested binaries directly I get:
<Error>
AccessDenied
<Message>Access denied.</Message>

Anonymous caller does not have storage.objects.get access to grpc-precompiled-binaries/node/grpc/v1.10.1/node-v64-darwin-x64-unknown.tar.gz.

</Error>

gRPC version 1.10.1 didn't have NodeJS 10 support at the time. Please either upgrade to a more recent version of gRPC, or downgrade nodejs to 8.


Sidekick appears to be offline.

I've been having issues with it going offline for the past hour or two. It came back online for a few minutes, but it wasn't responsive to any commands and went back offline almost immediately after that and has been offline ever since.

Hey, @Hawdkoah !
Looks online to me.
Discord sometimes having issues.
Let me restart the shards, it might help.

Looks like that fixed it. Thanks!


[WIP] Update to 4.0

As you already know, PleasantUI looks in the style of Windows 11. I don't like it at all, as the library is not different from others that use Windows 11 style, except for the optimization.
The goal of this PR: (at least try) to develop your own style for PleasantUI
There will be VERY many breaking changes once the 4.0 update is released. This is a great opportunity before this update is released to change things that were thought impossible.
All your suggestions, comments are also welcome!
Tasks

[ ] Add new stylized controls;
[ ] Reimagine all the styles.

If possible:

[ ] Create several new design themes (in addition to dark and light).

Please be advised that this PR will be updated

Showing the latest changes.
I managed to change the appearance. In the screenshots you can see how it will look like on the light and dark theme. To me, it looks better than it was


-bash: gb: command not found

I'm running on OSX and I'm getting this message.
Every shortcut that deals with branch seems to not be working.

Double check your own aliases (defined after scm_breeze script is run). I was getting the same message for "gh" which happened to be defined as my own alias.

@darwin that's right. I should've closed this issue as I've got it working moments after.
Thank you anyway.


Modify Node Role Naming

Description
This is a general question and opportunity to improve documentation.
My node role is {cluster_name}-KarpenterNodeRole vs the default KarpenterNodeRole-{cluster_name}.  Everything seems to be working except in the karpenter controller im seening the below error.
AccessDenied: User: arn:aws:sts::ACCOUNT_ID:assumed-role/CLUSTER_NAME-KarpenterControllerRole/1704838296921190277 is not authorized to perform: iam:PassRole on resource: arn:aws:iam::ACCOUNT_ID:role/KarpenterNodeRole-CLUSTER_NAME because no identity-based policy allows the iam:PassRole action\n\tstatus code: 403, request id: 8cf2c336-d3c4-4a9b-9b9a-640487705252"}

Which is due to the naming addressed above.  Is there currently a way to change the set the KarpenterNodeRole that the Karpenter Controller is trying to assign to new instances if so I have not been able to find that in documentation anywhere.

Karpenter Controller is trying to assign to new instances if so I have not been able to find that in documentation anywhere

If you have assigned a different role to your instances through the EC2NodeClass, you need to make sure the Karpenter controller policy has iam:PassRole permission on that role. This is documented (though it is in the CloudFormation permission reference here: https://karpenter.sh/docs/reference/cloudformation/#:~:text=Additionally%2C you would ensure that the Controller Policy has iam%3APassRole permission to the role attached to the generated instance profiles)

@jonathan-innis thanks for the response and the link to the docs!
The AWS IAM was all correct, I just could not find the missing piece of where that role was defined and assigned.  But I see now its in the EC2NodeClass under spec.role which as you said is in the CloudFormation section but also under the EC2NodeClass specifications!  With that i just cant search and appears docs are just fine :D.
Appreciate the assist.


term "producer" is not defined

https://github.com/DataInteroperability/xapi-profiles/blob/master/xapi-profiles-spec.md#using-profiles-in-statements
The term "producer" is not defined, but from the context I assume this refers to what xAPI calls a Learning Record Provider or LRP. If that's right, let's use the same term as xAPI.

Yeah, this is just quick-typing that needs fixing up rather than an intent to introduce a new term. There're a lot of little things like that in here, it is intentionally a very rough draft.

Cool. Not judging, just issue raising :-) I'll keep noting what I see so we can fix them.

+1 Andrew. Keep going :)
On April 5, 2017 at 5:17:12 AM, Andrew Downes<EMAIL_ADDRESS>wrote:

Cool. Not judging, just issue raising :-) I'll keep noting what I see so
we can fix them.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/DataInteroperability/xapi-profiles/issues/21#issuecomment-291802808,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABLKsaNJtSlzH-NGwQrMRfOcxVsEu3ISks5rs1wYgaJpZM4My43D
.


Hardcoded gas limit can break on future gas cost change

https://github.com/ditto-lab/ditto/blob/2dd8b7f20a0f223160466a8d2953551a796c5306/src/DittoMachine.sol#L592

I'm wondering if we should increase the gas stipend? or if there is some way we can allow a user to increase some minimum amount.

how about taking it as a function argument? any new attack vectors here?

yeah, if there's a protocol built with the token ejector and and 0 is passed as the arg then none of their business logic will be executed, so there needs to be a minimum guaranteed amount of gas fro execution.

Allowing user to increase minimum gas amount through an argument will not work in cases where the nft seller is not benefitting from ejector code execution. They'll always prefer the minimum gas amount.
Thinking out loud: what if we let the clone owner send eth to DittoMachine to be used as gas when ejector is called. So there is a mapping(cloneId => value) and anyone can bump up the value. I can't decide if this is a good or a bad idea.


Daffodil International University

Request JetBrains to add Daffodil International University's educational mail as student mail.

daffodilvarsity.edu.bd

@philipto daffodil is maintaining two domains. mail provide with diu.edu.bd ex<EMAIL_ADDRESS>
https://daffodilvarsity.edu.bd
https://diu.edu.bd

Great. I have used it previously. But Suddenly it was not working. Then I checked this repository and saw that my varsity is not listed here. Then I made the request. After closing this pull request, I tried again. Now it's working.


Exported models lack textures

Hello again!
I've tried exporting models in both .fbx and .obj and both formats seem to export geometry fine (including those quads we talked about earlier, they work fine w/o triangles) but do not bring the texture along with them.
I've tried importing the models into Blender, Unity and Rhinoceros to test. No dice!
Since i've used the same texture image for crocotile models, I tried adding the crocotile mtl to the exported object and it works perfectly, so I'm assuming it's just a matter of binding the image to the file.

Model formats like fbx and obj don't export textures with them, they just contain the UV coordinates. You have to import the textures as well and set the materials for them (How you do that depends on the software you are using). For more details, see here: https://blender.stackexchange.com/questions/57531/fbx-export-why-there-are-no-materials-or-textures

Weird that the option isnt available! Im used to Rhinoceros and Crocotile doing it by default, which seems like it would be fine for this implementation?

Yeah, blender doesn't have an option to automatically copy the textures over afaik, so you have to manually copy them. (Maybe the rationale is that Rhinoceros/Crocotile don't have complex node based materials like blender does, so it makes more sense for them to export textures by default)


Metrics within prometheus is not real time

I made a bunch with consul, consul_exporter and prometheus.
After that i made alert rule:
ALERT ConsulClientCount
  IF sum(consul_health_node_status{check="serfHealth",node=~".*-services-.*"}) < 100
  FOR 30s
  ANNOTATIONS {description="Consul Client Count value={{$value}})", summary="Consul Client Count LESS 100"}

but in case when consul client is down the alert is worked out only after ~5m
  scrape_interval:     5s
  evaluation_interval: 5s.

P.S. consul_exporter returns data correctly

It sounds like you're running into a staleness issue, as old timeseries that are no longer exported are still considered for 5 minutes. I'd suggest alerting on something that represents direct user experience, rather than trying to catch every possible failure mode such as a drop in clients.

thanx
-query.staleness-delta 5s is solved my issue

I'd strongly advise against dropping -query.staleness-delta to that low a value, it'll cause things to break in fun ways.

@brian-brazil what would you consider a safe minimum? 1m?


Add Terminology class to easy module

Nothing fancy. This will develop more later, but at least this gives a quick way to search for terms (just like the UI).

 We've deprecated the /search endpoint in Terminology Service and will be deleting it in a few weeks.
What's your use case here? You can do something pretty similar using the FHIR DSL API.

I'm going to close this since we'll need another approach as per @tdstein's comment.


Reset password unit tests

Description
This includes a refactor of the Reset Password screen to make it more easily testable and the tests themselves.
Fix #94
On what platform have you tested the change?

[ ] Android - Emulator
[ ] Android - Physical device
[ ] iOS - Emulator
[ ] iOS - Physical device

Screenshots
Checklist

[ ] I have updated mockServer

Out of scope and potential follow-up
I think a similar refactor should be applied to all the screen using Formik.
It makes writing tests really easy.

@mnecchi This looks like a sweet bit of refactoring!

FYI - I tested functionality on Android Device and all looks good.


CI: change "linux arm" asset from debian to ubuntu

this is a workaround for the version GLIBC_2.35' not found` error affecting users of GitHub's new ARM-based Ubuntu actions runner issues.
in addition to publishing codecov-cli to PyPI, we run pyinstaller to produce standalone executables which are served at https://cli.codecov.org. https://github.com/codecov/codecov-action fetches the CLI from there instead of installing from pip. the problem is, our platform support for these standalone executables is sparse, and the executable that our action is trying to fetch for these Ubuntu ARM runners was actually built on Debian Bullseye.
a proper fix for the issue is one or both of the following:

make https://github.com/codecov/codecov-action install the CLI via pip
rework how we build + serve these pyinstaller artifacts in a way that recognizes things like different glibc versions and musl

not doing this now. https://github.com/codecov/internal-issues/issues/108 describes work we could do to make these names more descriptive when we invest generally in our packaging


Domain hijack?

Hi,
It came to my attention that your website https://scottyfillups.io/ contains an obscure link to a website named "Zynga Chips", but this doesn't exist in this GitHub Pages repo.
It appears that scottyfillups.io is now deployed from another repo located here: https://github.com/invisiblethings/sco This Github user also created a GitHub Pages repo linked to rustbyexample.com (https://github.com/invisiblethings/demowp/blob/gh-pages/CNAME).
I believe this has been done without your consent and thought you might want to be notified about this.

Thanks, I just sent a report to Github. Out of curiousity, how did you bump into this repository?

Through https://rustbyexample.com/ (the former URL of Rust by Example; the current URL is https://doc.rust-lang.org/stable/rust-by-example/), which was hijacked by the same GitHub user. It had been returning 404 for a while, but now it was returning someone else's GitHub Pages, which I found to be suspicious.


Add simple imports for observable creation methods

Problem
Currently when you want to use a creation method in an ad-hoc way, you need to import the type of Observable, then use it's static create method or new it up directly.
This poses two problems:

You have to know the name of the observable: rxjs/observable/FromObservable for example
It makes using it ugly:

import { FromObservable } from 'rxjs/observable/FromObservable';
const from = FromObservable.create;

from([1,2,3]).subscribe(console.log.bind(console));

Solution
Add additional files next to the observable files that export the create methods under a more useful name:
eg:
src/observable/from.ts
import { FromObservable } from './FromObservable';

export const from = FromObservable.create;

src/observable/never.ts
import { NeverObservable } from './NeverObservable';

export const never = NeverObservable.create;

etc.
That means that using these in an ad hoc way would be as simple as:
import { from } from 'rxjs/observable/from'; //LOL: from from from

from([1, 2, 3]).subscribe(console.log.bind(console));

How do you suggest to import throw?

@staltz right now it's import { _throw } from XXX same for _do, _finally and _catch.


Update identity.md

Thanks for the contribution! this is a read-only mirror. please read the contribution guide.


Add support for image dimension extraction

I've seen this requested numerous times. It's a bit gross to implement since we have to special case it in the JS code, and we'd have to depend on mini_magick in the core gem, unless we can come up with something clever. At least we should look into if there's a sane way to implement this.

How is this affected by mini_magick being extracted into a separate gem? Makes this even trickier/weirder.


changeset comment too easy to get reused without noticing it until it is too late

Users find out only too late that their previous changeset comment has been reused, perhaps many times.
And now there is no way to fix it.
"Sludge retaining wall" on my supermarket, day care center edits! - he exclaims.
At least have a checkbox
[ ] and use this comment for my next edit.
Or OK, still fill in the box with the comment from last edit, but force the user to at least click somewhere in the textbox to acknowledge he is aware that it is going to be reused again.
All I know is that it had a blue background (selected text) when it happened.

I suppose the intention is to make it faster to upload subsequent changesets of the same task. However, I agree it's also easy to forget to change the comment—I've done this myself.
Let's just leave the initial comment blank. It's easy enough to click in the box and then click the last-used comment from the suggestion list.


Fix: conditions to display "Execute transaction"

What it solves
Resolves #2942
How this PR fixes it
Extracted to a new hook useCanTxExecute the logic to check if a tx can execute.
Display the "Execute transaction" checkbox based on with this logic.
How to test it
In a single owner Safe, "Execute transaction" checkbox shall display when creating a transaction and

There is no tx in the next queue and the tx nonce is equal to the safe nonce

In a multi owner Safe, "Execute transaction" checkbox shall display when:

Approving transaction and the number of confirmations meets the Safe threshold

Screenshots

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

3 of 30 (10.0%)  changed or added relevant lines in 5 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.2%) to 32.305%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/logic/hooks/useEstimateTransactionGas.tsx
0
1
0.0%

src/routes/safe/components/Balances/SendModal/screens/ReviewSendFundsTx/index.tsx
0
3
0.0%

src/logic/hooks/useGetRecommendedNonce.tsx
1
12
8.33%

src/logic/hooks/useCanTxExecute.tsx
1
13
7.69%

Totals

Change from base Build<PHONE_NUMBER>:
-0.2%

Covered Lines:
3107

Relevant Lines:
8538

💛  - Coveralls

I would also make sure to test this across all instances where an execute button could appear.

I would also make sure to test this across all instances where an execute checkbox could appear.

I tried to test them in all the scenarios I could come up with but nevertheless it requires a thorough QA assessment

There is one case that I am trying to address now but should be the last one: if you edit the safe nonce to execute next

Issues:
1 - Gas limit is not being calculated for tx with higher nonce. Even tho gas limit is not needed for tx that will not be executed right away, the problem is that if the user decides to change the nonce to the current one he will submit the tx with a gas limit of 0. Currently in dev the gas limit is calculated for all tx, even those with a higher nonce than the current one

2 - Switching from future nonce to current nonce and back causes the warning message of "tx might fail" error message to popUp.
Create a tx and leave it in queue
Start the creation of a new tx, it will have current nonce + 1, so it cannot be executed
Edit that nonce to be the current one, the execute button shows up just fine
Edit it once again to be current + 1.
Now a message of "tx might fail" will show up and won't go away

3 - The confirm icon was replaced with the execute one:
Create a tx in a safe of 3 out of x owners and see the tx

This is the Icon that should show there:

Issues:
1 - Gas limit is not being calculated for tx with higher nonce. Even tho gas limit is not needed for tx that will not be executed right away, the problem is that if the user decides to change the nonce to the current one he will submit the tx with a gas limit of 0. Currently in dev the gas limit is calculated for all tx, even those with a higher nonce than the current one
2 - Switching from future nonce to current nonce and back causes the warning message of "tx might fail" error message to popUp. Create a tx and leave it in queue Start the creation of a new tx, it will have current nonce + 1, so it cannot be executed Edit that nonce to be the current one, the execute button shows up just fine Edit it once again to be current + 1. Now a message of "tx might fail" will show up and won't go away
3 - The confirm icon was replaced with the execute one: Create a tx in a safe of 3 out of x owners and see the tx
This is the Icon that should show there:

@francovenica I've tackled points 1. and 2. the point 3. is fixed in other PR https://github.com/gnosis/safe-react/pull/3283
Please give it another round 🙏

I have a estrange behavior with a tx I want to sign, the tx is ready for execution, but it triggers a multisig first and then the proper execution modal.
This is the safe, you can try to execute the tx with a non-owner now, and you should see the same behavior
https://pr3257--safereact.review-safe.gnosisdev.com/app/rin:0xFfDC1BcdeC18b1196e7FA04246295DE3A17972Ac/transactions/queue
Gif:

Hey Franco, I am having the same behaviour in DEV and I think we should address it asap. However if it is not related with this issue I suggest it shouldn't block this ticket unless it impedes QAing properly. Let me know


Cleanup application context

Hi,
remove unused schema from application context.

Codecov Report

Merging #3524 into master will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3524      +/-   ##
==========================================
+ Coverage   40.12%   40.14%   +0.01%
==========================================
  Files        2186     2186
  Lines       71348    71348
  Branches     9795     9795
==========================================
+ Hits        28630    28642      +12
+ Misses      39984    39976       -8
+ Partials     2734     2730       -4

Impacted Files
Coverage Δ

...npoint/rpc/server/SimpleServerMessageListener.java
80% <0%> (-20%)
:arrow_down:

...m/navercorp/pinpoint/rpc/packet/RequestPacket.java
82.05% <0%> (-7.7%)
:arrow_down:

...tor/metric/datasource/DefaultDataSourceMetric.java
75.75% <0%> (-3.04%)
:arrow_down:

...ofiler/sender/StandbySpanStreamDataSendWorker.java
80.59% <0%> (-2.99%)
:arrow_down:

...inpoint/profiler/sender/AsyncQueueingExecutor.java
76.08% <0%> (-1.09%)
:arrow_down:

...orp/pinpoint/rpc/server/DefaultPinpointServer.java
81.11% <0%> (+0.69%)
:arrow_up:

.../com/navercorp/pinpoint/profiler/context/Span.java
50% <0%> (+1.72%)
:arrow_up:

...navercorp/pinpoint/rpc/common/SocketStateCode.java
85.36% <0%> (+2.43%)
:arrow_up:

...p/pinpoint/profiler/sender/AbstractDataSender.java
100% <0%> (+2.94%)
:arrow_up:

...m/navercorp/pinpoint/test/OrderedSpanRecorder.java
74.03% <0%> (+3.84%)
:arrow_up:

... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 990be00...3a2a8de. Read the comment docs.

Thank you all for your contribution


JVM ConsoleLoggerPlugin

This PR makes available a JVM ConsoleLoggerPlugin that can be added to any supported JS runtime in for the JVM, forwarding all console logs to a provided logger
Change Type (required)
Indicate the type of change your pull request is:

[ ] patch
[ ] minor
[ ] major
[ ] N/A

Does your PR have any documentation updates?

[ ] Updated docs
[ ] No Update needed
[ ] Unable to update docs

📦 Published PR as canary version: 0.9.2--canary.552.18545

Try this version out locally by upgrading relevant packages to 0.9.2--canary.552.18545

/canary

/canary


account #0 selected upon initial opening of Account window

if a wallet has multiple accounts (for reproduction purposes, 5+), and you last closed it while an account other than #0 was selected, opened it again and opened the Account window, the account selection jumps to #0 without any further user action. you lose your view as far as accounts are concerned.
the behavior seems to be limited to the first time the Account window is opened during a wallet session, and no similar anomalous account selection seems to occur if the wallet was last closed while account #0 was selected.
tested on: v2.7.0 AppImage

Thanks. Fixed in 147e8c04f6b4c11bf80f4eda4b38c8d9d21a6f35.


Side navbar arrows are in correct direction on page load

PR: 331 https://github.com/cyberark/secretless-broker/pull/331


feat: make ConnectivityListener configurable, and remove unnecessary network availability checks

Closes #1099

Eliminate direct use of InternetConnectivityChecker from at_client package except for a dead-code method in RemoteSecondary where the usage is fine (checks if atServer's host and port are reachable)
Eliminate wrapper class at_client.NetworkUtil and all its usages in at_client
Eliminate indirect (via at_client.ConnectivityListener) use of InternetConnectivityChecker from at_client package
For backwards compatibility, still exports ConnectivityListener  (which is in use by multiple programs including sshnpd), but adds optional constructor parameters which programs can use if they wish to continue to use ConnectivityListener

- What I did

[x] Deprecate RemoteSecondary.isAvailable()
[x] Remove Monitor's use of NetworkUtil.isNetworkAvailable
[x] Remove use of ConnectivityListener from NotificationServiceImpl
[x] Remove SyncServiceImpl's usage of NetworkUtil.isNetworkAvailable
[x] Remove AtClientValidation.validateAtKey's usage of NetworkUtil.isNetworkAvailable
[x] Adjust any unit tests which currently use mock network availability checks to simulate atServer reachability to instead use other mock approaches instead, without changing those tests's other setup or expects
[x] Remove the now-unused NetworkUtil class
[x] Add hostname, port and a checkInterval as optional parameter to ConnectivityListener constructor and use accordingly

- How I did it
- How to verify it
Tests pass
- Description for the changelog
feat: Make ConnectivityListener configurable by adding optional parameters to its constructor.
feat: Remove unnecessary use of network availability checks in various places

Another process wrap but well done
https://pub.dev/packages/dart_ping

I hate that connectivity listener uses tcp rather than ICMP

ConnectivityListener is ours; it wraps InternetConnectivityChecker
Neither are being used by at_client any more so 🤷♂

Another process wrap but well done
https://pub.dev/packages/dart_ping
And some discussion on the topic
dart-lang/sdk#33764

Now that at_client makes no use of it, I'd be happy to mark at_client's ConnectivityListener class as Deprecated and leave it to programs to use whatever they want to instead, since really it's nothing to do with AtClient

Checks currently failing because one of our cicd hosts is down

Checks complete thank you @cpswan

Every works as expected thanks @gkc


Feature request: Renaming enum abstract values

In Haxe you can define a enum type but there is also a @:enum abstract which can be used to define finite value sets:
@:enum abstract MyEnum(String) {
  var VALUE1 = "value1";
  var VALUE2 = "value2";
  var VALUE3 = "value3";
}

This is a nice, typed alternative to this:
class PoorManEnum {
  public static inline var VALUE1 = "value1";
  public static inline var VALUE2 = "value2";
  public static inline var VALUE3 = "value3";
}

HaxeDevelop gives the option to rename the values of the @:enum abstract, but it basically never does anything with it in the classes that use it. I think you can assume the fields in this enum abstract are static, I think it now treads it as a class member, because it only renames itself.
It would be great if FlashDevelop/HaxeDevelop supports renaming enum abstracts. Thanks!

I think it's possible to do it, but I need time to write the tests

depends on #1772

fixed #2143


proposal: x/exp/slog: add ability to attach Logger to context

It would be helpful if we can attach a slog.Logger to a context.Context, so that added attributes can be shared down the call chain. Much like library zerolog does with functions Ctx and Logger.WithContext).
Now that slog is becoming the standard log interface, it makes sense to also define context attachment. This would allow package authors to look for a logger in a context and if available use when needed. Likewise, it would give the author of a main package all the power to configure the logger, or not.
Use cases

Request logger created in middleware with request ID and other metadata, passed down in the http.Request context.
The ability to send the logger into a library, like facilitated in pgx-zerolog.

Using the current implementation
slog does provide the ability to pass a context using the XXXContext() methods. With a custom handler one could extract data from the context. However, this creates the need of implementing a custom Handler and trying each context value one wants to log. IMO this will result in much boilerplate code.

This was a highly contentious point in the slog proposal, with a final decision to leave it out: https://github.com/golang/go/issues/56345#issuecomment-1468513073

@muhlemmer check out https://github.com/veqryn/slog-context


how can I open page in a new tab ?

I want to open one more tab, how can I do?
such as tab 1  open http://www.google.com
tab 2 open http://www.youtube.com
is this enable?

Closing as duplicate of #749.


Eddie Jaoude added

Thanks for the PR!
Could you please add specific technologies you can mentor people who're new to OSS in?

Sure, thanks @lenadroid 👍

Added 😉


why not support redis for hash and list so on...

I check all over the Cache_redis , did not found like 'hSet,hGet,lSet....' and so no. i had problem about this , weather need to write they by myself?
thank you

The Cache library isn't a Redis library ... it doesn't implement everything that Redis does, it just uses it as yet another driver. If you need these methods, just use directly the phpredis extension.
Also, please post your questions on the forums, we only accept bug reports here.


Remove hidden TaggableInterface dependencies from paginator

This is an example for discussion on issue #7174 Cache in Paginator module supports only Memory and Filesystem adapters

I'm not sure, why the Travis build on PHP 5.4 fails on ZendTest\Cache\Storage\Adapter\FilesystemTest::testClearExpired. I have modified only Paginator and PaginatorTest, these changes should not affect Filesystem adapter.

Those tests are sadly time-bound, and tend to fail when the travis
infrastructure is stressed out.
On Feb 4, 2015 8:10 AM, "Hennadiy (Gena) Verkh"<EMAIL_ADDRESS>wrote:

I'm not sure, why the Travis build on PHP 5.4 fails on
ZendTest\Cache\Storage\Adapter\FilesystemTest::testClearExpired. I have
modified only Paginator and PaginatorTest, these changes should not
affect Filesystem adapter.
—
Reply to this email directly or view it on GitHub
https://github.com/zendframework/zf2/pull/7181#issuecomment-72806891.

Merged to develop for release with 2.4.