[Bug] stickyScroll ignores maxLineCount? Only sticks 1 line

Reproducible in vscode.dev or in VS Code Desktop?

[X] Not reproducible in vscode.dev or VS Code Desktop

Reproducible in the monaco editor playground?

[ ] Not reproducible in the monaco editor playground

Monaco Editor Playground Link
https://microsoft.github.io/monaco-editor/playground.html?source=v0.35.0#XQAAAAL4AQAAAAAAAABBqQkHQ5NjdMjwa-jY7SIQ9S7DNlzs5W-mwj0fe1ZCDRFc9ws9XQE0SJE1jc2VKxhaLFIw9vEWSxW3yscw0TKWpjN898w8vXcYTGSMs5sUpNh6UB0XRaMhEtbSa7F_AYLMU68VMTzjdzbgpvNt8twSv1rycxa4dRmOnhf8zLGscpbBj3ASW9PDifqh6m5IIQMyYLtU28MN9DGBsCDMKnXJJyCWpQ1PA45TQlCruVoD-ddznQDPqBZ0CYMLRQKAtBYaW73bNcLG82Lgy-NcbqMAG9IIaW4jSihFywEoliD7pc9slSBBLQHAriDPH2m9ShKH1E6LhHH73A5hr1cG7IRzldCrHwC_-puFHPCqhP_xDKII
Monaco Editor Playground Code
var editor = monaco.editor.create(document.getElementById("container"), {
	value: "function hello() {\n\talert('Hello world!');\n\nfunction hello() {\n\talert('Hello world!');\n\nfunction hello() {\n\talert('Hello world!');\n\nfunction hello() {\n\talert('Hello world!');\n\nfunction hello() {\n\talert('Hello world!');\n\n};\n};\n};\n};\n};",
	language: "javascript",
	stickyScroll: {
		enabled: true,
		maxLineCount: 5
	},
});
// no editor onReady :/
setTimeout(() => editor.trigger("setValue", "editor.action.formatDocument", null), 500);

Reproduction Steps
Scroll down
Actual (Problematic) Behavior
It only/barely sticks 1 of the lines function hello() {
Expected Behavior
Each function should be sticked as it does in vscode app + vscode.dev (works in both)

Additional Context
No response

@aiday-mar can you look into this?

Just a minor FYI: Without going into reading "all the source" - I hacked it for now in getCandidateStickyLinesIntersectingFromOutline where I changed the for (let i = lowerBound; i <= upperBound; i++) { to for (let i = 1; i <= outlineModel.children.length; i++) {
P.S. README.md has a bad link to "try it out" / playground


Add KSTS?

Hello, could you add the "Kerbal Space Transport System" to the repo: https://github.com/mmoench/KSTS ?
It should already have a valid netkan-file. Thnaks.

Do you wish to continue hosting your own netkan, or would you prefer it be added to the main repository to be curated here?

I think I would like to keep hosting it myself.

Ok. I think you have an extra comma at the end of your install block that needs to be deleted.

I've removed the additional comma. Thanks.


(Suggestion) Mount patterns

Allow to save mount settings, drive and etc. in pattern, which can be loaded easily later at any point, with ability to create new pattern, edit it or delete pattern.

+1


Add Meetup events to homepage

Add a section to represent Meetup events on the website home page.
Meetup has an API to show all events of a target group.

being worked on in #45


Platform abstraction

Here's a WIP graphics interface : https://sr.ht/qGXi.h
Texture abstraction : store textures as PNG and add custom loaders for each platform. Texture unloading would be a good idea if memory is a concern. Basically a wrapper around platform-specific texture objects.
Timing abstraction : I have some ideas for that, it's not hard at all.
Interrupts : the Nspire code uses interrupts for vsync. On other platforms we can probably use multithreading to avoid blocking on vsync. Needs more planning.
Input : again, trivial. We definitely need an input mapper to allow the user to bind keys as they wish. Not too hard, just needs a little bit of planning required.

Graphics subsystem mostly done as of 292ab06.

Timing API was added as of e36891b.

5254e4e adds platform-specific quirks that allow hooking into the init/deinit sequence of the engine to set up additional stuff that is very specific to a platform, such as interrupts.

Input API done as of f2c536f. New keys can be added in the future if the engine needs them.

Texture abstraction is done as of ed8414b. Added pixel format abstraction to the list.


feature: adding an edge for file to symbol

Sculpt could be exactly what I need to break large scala targets into minimal dags for bazel to build.
The only thing missing is a mapping of which file each symbol is defined in, since bazel’s finest units (currently) are files.
How hard would it be to add this mapping? Something like [{ “file”: “Foo.scala”} , “produces”, {“sym”: [...
If you can coach me through this, I’m happy to send a PR if you thing this would be easy ish for someone unfamiliar with the compiler/plug-in.

deja vu :-)  https://contributors.scala-lang.org/t/sculpt-dependency-graph-extraction-for-scala/1507/3
yes, I think this is a modest, doable change, and if you get stuck, I'd be happy to help get you unstuck.

Thanks for the reminder. I’ll take a stab at this.

someone could pick up the old WIP PR at #61


Failed to compile on v1.1.1 fresh install

Before opening a new issue, please take a moment to review our community guidelines to make the contribution process easy and effective for everyone involved.
Description
Hello,
I just installed the last version (v.1.1.1), but the compilation failed with those errors.
`
src/index.tsx
Line 30:52:  Parsing error: Unexpected token, expected ";"
28 |
29 | const store = configureAppStore();
30 | const MOUNT_NODE = document.getElementById("root") as HTMLElement;
31 | ReactDOM.render(
33 |
src/locales/translations.ts
Line 7:76:  Parsing error: Unexpected token, expected ";"
5 |  * Your components can import this file in 'messages.ts' files which would ruin the HMR if this isn't a separate module
6 |  */
7 | export const translations: ConvertedToObjectType = {} as any;
src/utils/loadable.tsx
Line 6:25:  Parsing error: Unexpected token, expected ";"
4 |   fallback: React.ReactNode;
5 | }
6 | type Unpromisify = T extends Promise ? P : never;
`
Steps to reproduce
Steps to reproduce the behavior:
git clone https://github.com/react-boilerplate/react-boilerplate-cra-template.git
cd react-boilerplate-cra-template
yarn
yarn run cleanAndSetup
yarn start
Expected behavior
Not a failed compilation.
Versions

react-boilerplate-cra-template: 1.1.1
Node/NPM/Yarn: v.14.15.1 / 6.14.5 / 1.22.5

this project is not meant to be cloned.

Ok thank you, I will use the cra cli :)


Rainbow Bracket Issue

Hi, for some reason when the rainbow brackets are toggled on in Nova preference, the brackets never match in blade syntax.
to reproduce:

preferences -> editor -> tick "use rainbow brackets"
then open any blade file and for example type {} or {{}

}

thanks
Emran

Thanks @benwittorf , but in my case, did not work...

@benwittorf Thanks for the reply!!

Thanks @benwittorf , but in my case, did not work...

The hack works. I would say, once you save the file, and restart nova, also tick and untick the extension in the extension menu, this will disable and re-parse the extension again. If not leave a comment here and we debug!
I am not sure if this project is active but I will do a pull request for this. as well as some other minor issues. If not I might fork and we take it from there. The API is there to make a super rich Laravel extension not just for syntax but other things as well. ✊ Just have to find the time! 😅

@EmranMR I appreciate the effort, but it doesn't work for me Screenshot
As you can see here, the chamge in the blade file is already done.
Thanks

HI @benwittorf ... Thanks but the problem persist.

Hi @juancarlosso and @benwittorf I finally managed to put something together, it was a hell of a challenge esp the tree-sitter-blade, god damn nightmare 😅 please try Laravel Suit extension and raise issue on that repo for features and problems
This issue is fully resolved by that extension. Unfortunately you can not have both {{ as the same colour due to shortcomings by Nova but was already reported in their forum. But at least you get a symmetrical colouring if you use rainbow brackets


brew cask doctor error "Error: wrong number of arguments (1 for 0)"

When running brew cask doctor I get the following output:
 larrygordon in /usr
○ → brew cask doctor
Error: wrong number of arguments (1 for 0)

  Most likely, this means you have an outdated version of homebrew-cask. Please run:

      brew update && brew upgrade brew-cask && brew cleanup && brew cask cleanup

  If this doesn’t fix the problem, please report this bug:

      https://github.com/caskroom/homebrew-cask/issues

/usr/local/Cellar/brew-cask/0.54.1/rubylib/hbc/cli/doctor.rb:2:in `run'
/usr/local/Cellar/brew-cask/0.54.1/rubylib/hbc/cli.rb:79:in `run_command'
/usr/local/Cellar/brew-cask/0.54.1/rubylib/hbc/cli.rb:119:in `process'
/usr/local/Cellar/brew-cask/0.54.1/rubylib/brew-cask-cmd.rb:18:in `<main>'

 larrygordon in /usr
○ → brew update && brew upgrade brew-cask && brew cleanup && brew cask cleanup
Already up-to-date.
Error: caskroom/cask/brew-cask 0.54.1 already installed

 larrygordon in /usr
○ → brew --version
0.9.5

 larrygordon in /usr
○ → ruby --version
ruby 2.0.0p481 (2014-05-08 revision 45883) [universal.x86_64-darwin14]

Here is my system info:
System Info

Software:

    System Software Overview:

      System Version: OS X 10.10.3 (14D136)
      Kernel Version: Darwin 14.3.0
      Time since boot: 2 days 4:54

Hardware:

    Hardware Overview:

      Model Name: MacBook Pro
      Model Identifier: MacBookPro11,3
      Processor Name: Intel Core i7
      Processor Speed: 2.8 GHz
      Number of Processors: 1
      Total Number of Cores: 4
      L2 Cache (per Core): 256 KB
      L3 Cache: 6 MB
      Memory: 16 GB
      Boot ROM Version: MBP112.0138.B14
      SMC Version (system): 2.19f12

Can’t reproduce.

@psyrendust Could you please do echo $HOMEBREW_CASK_OPTS and post the result here?

 larrygordon in ~
○ → echo $HOMEBREW_CASK_OPTS
--appdir=/Applications --binarydir=/usr/local/bin --caskroom=/usr/homebrew-cask/Caskroom --fontdir=~/Library/Fonts --input_methoddir=~/Library/Input\ Methods --prefpanedir=~/Library/PreferencePanes --qlplugindir=~/Library/QuickLook --screen_saverdir=~/Library/Screen\ Savers --widgetdir=~/Library/Widgets

It also doesn't list any of the casks that I installed either:
 larrygordon in ~
○ → brew cask list --verbose
Error: No available Cask for --widgetdir=~/Library/Widgets

 larrygordon in ~
○ → ls /usr/homebrew-cask/Caskroom
animated-gif-quicklook  cert-quicklook  qlcolorcode  qlmarkdown     qlstephen  quicklook-csv   quicknfo            webpquicklook
betterzipql             provisionql     qlimagesize  qlprettypatch  qlvideo    quicklook-json  suspicious-package

Which is really odd. I uninstalled brew-cask and reinstalled it after a restart of my machine. I'm still seeing the same results.

It also doesn't list any of the casks that I installed either

That’s unrelated, and we’re aware of that.
As for the original issue, try removing options from $HOMEBREW_CASK_OPTS. Not only are most of those redundant, at least one of them doesn’t exist anymore (--widgetdir, as widget support as been removed a while ago),

I suspect the issue might be caused by your HOMEBREW_CASK_OPTS environment variable containing the

--widgetdir

option, which homebrew-cask no longer supports. Support for widgets has been removed altogether earlier this year as per #8751.
To fix this, locate the file where your HOMEBREW_CASK_OPTS is being declared. (If unsure, do grep -R HOMEBREW_CASK_OPTS ~/.*). Edit that file and remove the part from your HOMEBREW_CASK_OPTS variable where it says --widgetdir=~/Library/Widgets. Close Terminal.app and try again.
Does that fix both issues?

@vitorgalvao High five :joy:

So close. I still saw your comment appear mere seconds after. Nice thinking with the HOMEBREW_CASK_OPTS.

Success! Removing --widgetdir option did it.
 larrygordon in ~
○ → brew cask doctor
==> OS X Release:
10.10
==> OS X Release with Patchlevel:
10.10.3
==> Hardware Architecture:
intel-64
==> Ruby Version:
2.0.0-p481
==> Ruby Path:
/System/Library/Frameworks/Ruby.framework/Versions/2.0/usr/bin/ruby
==> Homebrew Version:
0.9.5
==> Homebrew Executable Path:
/usr/local/bin/brew
==> Homebrew Cellar Path:
/usr/local/Cellar
==> Homebrew Repository Path:
/usr/local
==> Homebrew Origin:
https://github.com/Homebrew/homebrew
==> Homebrew-cask Version:
0.54.1
==> Homebrew-cask Install Location:
/usr/local/Cellar/brew-cask/0.54.1
==> Homebrew-cask Staging Location:
/usr/homebrew-cask/Caskroom
==> Homebrew-cask Cached Downloads:
/Library/Caches/Homebrew
/Library/Caches/Homebrew/Casks
0 files
0.00 megs
==> Homebrew-cask Default Tap Path:
/usr/local/Library/Taps/caskroom/homebrew-cask
==> Homebrew-cask Alternate Cask Taps:
<NONE>
==> Homebrew-cask Default Tap Cask Count:
2609
==> Contents of $LOAD_PATH:
/usr/local/Cellar/brew-cask/0.54.1/rubylib
/Library/Ruby/Site/2.0.0
/Library/Ruby/Site/2.0.0/x86_64-darwin14
/Library/Ruby/Site/2.0.0/universal-darwin14
/Library/Ruby/Site
/System/Library/Frameworks/Ruby.framework/Versions/2.0/usr/lib/ruby/vendor_ruby/2.0.0
/System/Library/Frameworks/Ruby.framework/Versions/2.0/usr/lib/ruby/vendor_ruby/2.0.0/x86_64-darwin14
/System/Library/Frameworks/Ruby.framework/Versions/2.0/usr/lib/ruby/vendor_ruby/2.0.0/universal-darwin14
/System/Library/Frameworks/Ruby.framework/Versions/2.0/usr/lib/ruby/vendor_ruby
/System/Library/Frameworks/Ruby.framework/Versions/2.0/usr/lib/ruby/2.0.0
/System/Library/Frameworks/Ruby.framework/Versions/2.0/usr/lib/ruby/2.0.0/x86_64-darwin14
/System/Library/Frameworks/Ruby.framework/Versions/2.0/usr/lib/ruby/2.0.0/universal-darwin14
==> Contents of $RUBYLIB Environment Variable:
<NONE>
==> Contents of $RUBYOPT Environment Variable:
<NONE>
==> Contents of $RUBYPATH Environment Variable:
<NONE>
==> Contents of $RBENV_VERSION Environment Variable:
<NONE>
==> Contents of $CHRUBY_VERSION Environment Variable:
<NONE>
==> Contents of $GEM_HOME Environment Variable:
<NONE>
==> Contents of $GEM_PATH Environment Variable:
<NONE>
==> Contents of $BUNDLE_PATH Environment Variable:
<NONE>
==> Contents of $PATH Environment Variable:
PATH="/Users/larrygordon/.nvm/versions/io.js/v2.3.1/bin:/Users/larrygordon/.dotfiles/plugins/asciinema2gif/bin:/Users/larrygordon/.dotfiles/plugins/safe-rm/bin:/Users/larrygordon/.dotfiles/plugins/pretty-print/bin:/Users/larrygordon/.dotfiles/plugins/sublime/bin:/Users/larrygordon/.dotfiles/plugins/npmlist/bin:/Users/larrygordon/.dotfiles/bin:/Users/larrygordon/.tmpbin:/usr/local/opt/coreutils/libexec/gnubin:/usr/local/opt/go/libexec/bin:/usr/local/bin:/usr/bin:/bin:/usr/sbin:/sbin:/Users/larrygordon/.rvm/bin:/usr/local/Library/ENV/scm"
==> Contents of $SHELL Environment Variable:
SHELL="/bin/zsh"
==> Contents of Locale Environment Variables:
LANG="en_US.UTF-8"
LC_CTYPE="en_US.UTF-8"
==> Running As Privileged User:
No

 larrygordon in ~
○ → brew cask list
animated-gif-quicklook	 provisionql		  qlmarkdown		   qlvideo		    quicknfo
betterzipql		 qlcolorcode		  qlprettypatch		   quicklook-csv	    suspicious-package
cert-quicklook		 qlimagesize		  qlstephen		   quicklook-json	    webpquicklook


Namespace setting disappeared from Page Advanced Settings

Hello there!
I was in need of defining an application namespace for one of my apphooked page. Usually, in older projects I could do that from the Advanced Settings of the Page admin. But I went there and in version 3.2.2 that field is gone. I checked the docs to see if something changed there but there are still references to that field so I suppose it should be there (while it is not).

Hello,
The namespace field only shows if you've defined a namespace on the CMSApp subclass.
You can find more info in http://docs.django-cms.org/en/release-3.4.x/how_to/apphooks.html#apphooks-for-namespaced-applications.
@evildmp
We should add a note on that section about the namespace field.

@evildmp Can you confirm whether this was ever documented, actioned?


fix(relays): Improved handling of relay connections

:tada: This PR is included in version 1.2.12 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Hotfix/parking

This change is

Reviewed 2 of 2 files at r1.
Review status: all files reviewed at latest revision, 2 unresolved discussions.

app/src/main/AndroidManifest.xml, line 688 at r1 (raw file):

			android:label="Add Vehicle"
			android:parentActivityName=".features.parking.controller.ParkingMainActivity"
			android:windowSoftInputMode="adjustResize" />

What is this?

app/src/main/java/edu/byu/suite/features/parking/controller/AddVehicleActivity.java, line 307 at r1 (raw file):

				if (data.codeSetId == null) {
					if (data.vehicleAttributeTitle.equals(getString(R.string.vehicle_model))) {

Comment before this if statement about what each of these is doing

Comments from Reviewable

Reviewed 1 of 1 files at r2.
Review status: all files reviewed at latest revision, 1 unresolved discussion.

app/src/main/AndroidManifest.xml, line 688 at r1 (raw file):
Previously, coreywoodfield (Corey Woodfield) wrote…
Instead of moving the activity up just to show whatever text view is in focus, it resizes the whole activity so that it fits above the keyboard. This makes it so you can see the register button and scroll up and down in the list of inputs even when the keyboard is visible

Could you send me a screenshot and/or video of what this looks like (before and after)?

Comments from Reviewable

Review status: all files reviewed at latest revision, 1 unresolved discussion.

app/src/main/AndroidManifest.xml, line 688 at r1 (raw file):
Previously, romrell4 (Eric Romrell) wrote…
Could you send me a screenshot and/or video of what this looks like (before and after)?

Done.

Comments from Reviewable

Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable


Analyze all is stuck when genes that are 'unknown' are passed from panel.iobio

[Uploading Screen Shot 2018-10-03 at 8.42.58 PM.png...]

Also, in gene.iobio if a gene doesn't have any trascripts (MT-TQ), copy/paste genes logic should treat this as an unknown gene and bypass it.


Some confusion about output layer: does this paper use pointer network in output layer?

Thanks for sharing, but there is some confusion about the output layer: does this paper use Pointer Network in the output layer?

Yes. P^s=q W P^T where q is the vector of question and P is the matrix of the passage.

Hi, Is P^s the starting position of the answer? If it's, and this paper is calculated by bilinear function. But in the next paragraph, using a Pointer network to predict the start and end position of the answer.
So, this confuses me, and what should I understand these two parts
thanks again!

Hi, based on the probability in P^s, choose the largest number as the pointer to point the start position. Is that right

Hi, based on the probability in P^s, choose the largest number as the pointer to point the start position. Is that right

Yes

Hi, Is P^s the starting position of the answer? If it's, and this paper is calculated by bilinear function. But in the next paragraph, using a Pointer network to predict the start and end position of the answer.
So, this confuses me, and what should I understand these two parts
thanks again!

In my opinion, the Pointer network is indeed the bilinear function.

That makes it clear. Thank you very much


Create unique names for simulator executables and update tooling to check that the correct one is running

flutter -d iPhone run to my Simulator shows a white screen on the Simulator for ~2 seconds, and then the Flutter apps quits.
When I try to manually run the app in my Simulator, I get this error:

cc @chinmaygarde

We think this is because I had multiple apps named "runner" installed on my simulator. Once I cleaned the simulator and reset its data, flutter run started to work just fine.

Could this be causing https://github.com/flutter/flutter/issues/3360 ?

I am redoing the Xcode projects for the different buckets anyway. Will take a stab at fixing this while I am at it.

This isn't really actionable any more. If you see this again please file a new bug with more specifics.


Multi-GPU training not starting or freezing. GPUs at 100%

Very same script runs without issues on 1 GPU (setting NVIDIA_VISIBLE_DEVICES to one GPU) but freezes with 2 or 3 GPUs.
System information

Have I written custom code (as opposed to using a stock example script provided in TensorFlow): yes
OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Ubuntu Server 20.04
Mobile device (e.g. iPhone 8, Pixel 2, Samsung Galaxy) if the issue happens on mobile device: -
TensorFlow installed from (source or binary): 2.7 (Anaconda), 2.8 (official docker), 2.8 (self compiled docker)
TensorFlow version (use command below): 2.8 & 2,7
Python version: 3.9
Bazel version (if compiling from source): 4.2.1
GCC/Compiler version (if compiling from source): 9
CUDA/cuDNN version: 11.4
GPU model and memory: 3x RTX A6000 / 3x 48GB

Describe the current behavior
Training script hangs at executing model.fit(). Terminal shows Loaded cuDNN version 8201 thrice (once for each GPU) and displays "TensorFloat-32 will be used..." once. GPUs turn to 100% but nothing gets calculated, CPU usage is nearly 0%, "Epoch 1/50" is displayed by model.fit() but no progress bar and nothing happens. Script is also unresponsive, even to Ctrl+C => process has to be killed manually.
Describe the expected behavior
After showing "Loaded cuDNN 8201" training should start and progress bar of model.fit() call should show up.
Contributing

Do you want to contribute a PR? (yes/no): no
Briefly describe your candidate solution(if contributing): -

Standalone code to reproduce the issue
My code is a more complex scenario but even this simple code here shows the same issue (executes right away on 1 GPU but freezes with 2 or 3 GPUs):
import tensorflow as tf
import numpy as np

X = np.random.random((1000, 128, 128, 3)).astype(np.float32)
Y = np.random.random((1000, 10)).astype(np.float32)

dat_x = tf.data.Dataset.from_tensor_slices(X)
dat_y = tf.data.Dataset.from_tensor_slices(Y)
ds = tf.data.Dataset.zip((dat_x, dat_y))
ds = ds.batch(96)
ds = ds.repeat(50)

strategy = tf.distribute.MirroredStrategy()

with strategy.scope():
    inputs = tf.keras.Input(shape=(128, 128, 3))
    x = tf.keras.layers.Conv2D(32, (3, 3))(inputs)
    x = tf.keras.layers.MaxPool2D()(x)
    x = tf.keras.layers.Conv2D(32, (3, 3))(x)
    x = tf.keras.layers.MaxPool2D()(x)
    x = tf.keras.layers.Flatten()(x)
    x = tf.keras.layers.Dense(10)(x)
    model = tf.keras.Model(inputs=inputs, outputs=x)
    optim = tf.optimizers.Adam()

    model.compile(optim, loss=tf.keras.losses.CategoricalCrossentropy())

model.fit(ds, epochs=50)

I have the same problems, I have checked the driver(ok), cuda(ok), cudnn(ok), nccl(ok), all of these were normal operation. However, the distribution training was broken and frozen. It is so disappointing.

Do you have any logs that I can look into?

Commenting that I'm seeing the same behavior though with cuDNN version 8400

After lots of headache and different attempts I am suspecting that it actually has to do with the cuda architecture in use and the OS version / driver version / linux kernel version.
In my case, nothing helped to get multiple GPUs to work other than updating to Ubuntu 22.04, ensuring that a new linux kernel 5.15 is running and having CUDA >= 11.3 + updating to latest driver.
I guess for new(er) GPUs, as mentioned I was using 3x RTX A6000, thus Ampere generation NVIDIA GPUs, there is something that simply breaks with Ubuntu 20.04 and/or the old linux kernel available in aforementioned Ubuntu. Even an Ubuntu 22.04 in a docker environment was not helping.
So TL;DR:
For me updating to a more modern Ubuntu, updating linux kernel and then using CUDA >= 11.3 and latest nvidia driver worked.
Any other attempt, like different CUDA versions, driver versions, with or without docker, with Anaconda, ... did not work under Ubuntu 20.04 and older linux kernel with new NVIDIA Ampere cards.

This could be a nccl problem.
https://github.com/NVIDIA/nccl-tests
Try
NCCL_DEBUG=INFO ./build/all_reduce_perf -b 8 -e 128M -f 2 -g 3

and you will get the same result

Is there a solution to this? Running into the same issue and all my packages are upgraded as suggested.

Assigning to @rohan100jain to find the right owner for this issue.

I had an issue similar to this, and i fixed it by disabling IOMMU in the bios. This is relevant if you have an AMD CPU and using Data Parallel

I got around the issue for now by modifying the cross_device_ops to tf.distribute.HierarchicalCopyAllReduce() as per stackoverflow . Full code snippet:
strategy = tf.distribute.MirroredStrategy( cross_device_ops=tf.distribute.HierarchicalCopyAllReduce())
I still think this is an issue with the nccl, because the default argument for that parameter is tf.distribute.NcclAllReduce

Hi,
Thank you for opening this issue. Since this issue has been open for a long time, the code/debug information for this issue may not be relevant with the current state of the code base.
The Tensorflow team is constantly improving the framework by fixing bugs and adding new features. We suggest you try the latest TensorFlow version with the latest compatible hardware configuration which could potentially resolve the issue. If you are still facing the issue, please create a new GitHub issue with your latest findings, with all the debugging information which could help us investigate.
Please follow the release notes to stay up to date with the latest developments which are happening in the Tensorflow space.


Fix compile error caused by entc template when Entity name has initials TX

When creating an Entity with initials "TX", e.g. TumorXrays,
the code generated by entc cannot compile, because of a name clash in the generated transaction (tx) Unwrap() function:
func (tx *TumorXrays) Unwrap() *TumorXrays {
	tx, ok := tx.config.driver.(*txDriver)
	...

Thanks for the contribution @hax10 🙏

@all-contributors please add @hax10 for code


TestKitchen test coverage and add ability to control binding config at runtime

The dynamic binding option has been introduced to account for cases where a machine configured by Ansible is assigned a new IP at boot/reboot time. This is a typical scenario in cloud environments.

@savagegus - Any questions/concerns about this PR? I'd like to move on to pick up https://github.com/jivesoftware/ansible-consul/issues/9, but am waiting to see reactions to this before I proceed.
I'd like to add test coverage for my PR that will address that other issue and don't want to submit a series of dependent PRs.

Looks good @trumant thanks for the pull request.


Added support for integTest remote on Remote clusters

Description
https://github.com/opensearch-project/cross-cluster-replication/issues/532
Issues Resolved
Added support for running Integtest on Remote clusters.
Check List

[ ] New functionality includes testing.

[ ] All tests pass

[ ] New functionality has been documented.

[ ] New functionality has javadoc added

[ ] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.
Signed-off-by: Monu Singh<EMAIL_ADDRESS>

Codecov Report

Merging #543 (9e646bd) into main (5ac1023) will decrease coverage by 2.82%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main     #543      +/-   ##
============================================
- Coverage     75.10%   72.27%   -2.83%
+ Complexity     1008      979      -29
============================================
  Files           141      141
  Lines          4595     4595
  Branches        506      506
============================================
- Hits           3451     3321     -130
- Misses          832      953     +121
- Partials        312      321       +9

Impacted Files
Coverage Δ

...cation/action/changes/TransportGetChangesAction.kt
63.49% <0.00%> (-26.99%)
:arrow_down:

...arch/replication/metadata/UpdateMetadataRequest.kt
77.27% <0.00%> (-22.73%)
:arrow_down:

...rch/replication/action/status/ShardInfoResponse.kt
72.26% <0.00%> (-19.33%)
:arrow_down:

...ch/replication/task/index/IndexReplicationState.kt
51.66% <0.00%> (-15.00%)
:arrow_down:

...ication/action/setup/TransportSetupChecksAction.kt
59.52% <0.00%> (-14.29%)
:arrow_down:

...ication/seqno/RemoteClusterRetentionLeaseHelper.kt
80.00% <0.00%> (-11.67%)
:arrow_down:

...tion/repository/RemoteClusterMultiChunkTransfer.kt
90.24% <0.00%> (-9.76%)
:arrow_down:

.../replication/metadata/store/ReplicationMetadata.kt
62.96% <0.00%> (-8.65%)
:arrow_down:

...action/stop/TransportStopIndexReplicationAction.kt
60.75% <0.00%> (-5.07%)
:arrow_down:

...ication/action/stop/StopIndexReplicationRequest.kt
50.00% <0.00%> (-5.00%)
:arrow_down:

... and 15 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


BBox squezeed during inference.

I tried inference in the images provided in your repo as well as other images.. It works perfectly for the samples provided by you but the bbox seems to squeeze in my samples.

please can you tell me if there is Val data in thatPubTables1M-Structure-PASCAL-VOC/ folder,i don't have val and test data in the PubTables1M-Structure-PASCAL-VOC/

I tried inference in the images provided in your repo as well as other images.. It works perfectly for the samples provided by you but the bbox seems to squeeze in my samples.

Can you please provide the code for inferencce?

I suspect it may be due to overfitting on the training samples because all of the training samples have a margin around the table.
You can try image = cv2.copyMakeBorder(image, 40,40,40,40, cv2.BORDER_CONSTANT, None, value=(255,255,255)) to add a margin before passing into the model

@finnthedawg, thanks a lot for this, it solved the squeezing issue for me

Hi @sanjaychamlagain123
Can you please provide the inference code? Thanks in advance!


NavigationView Pane Toggle Button is not aligned properly on first load.

Describe the bug
The Pane Toggle Button in NavigationView is not aligned with the rest of the navigation items and back button on the very first load. It is slightly shifted to the right. This issue sometimes also appears in the XAML  Controls Gallery App.
However, on clicking the Pane Toggle Button, it aligns itself properly.
The issue exists with both WinUI3 and 2.x.
Steps to reproduce the bug

Create a new WinUI3 App or UWP App.
Add Navigation View to the Page.

Expected behavior
The Pane Toggle Button should align itself properly on the first load.
Screenshots

NuGet package version
WinUI 3 - Windows App SDK 1.0 (If you're seeing your issue in older previews of WinUI 3, please try this release)
Windows app type

[X] UWP
[X] Win32

Device form factor
Desktop
Windows version
No response
Additional context
No response

Present in winui2 as well.  @karenbtlai I think you may have looked into this in the past, right?

Yes I have. Let me investigate further.

I have this same issue. The part of toggle pane button on the right side is missing.

Is thre some temporary fix for this util this bug is fixed?

Quick fix for this is to forse toggle pan button size recalcuation.
Togle size calculation will be trigger when pane title is changed https://github.com/microsoft/microsoft-ui-xaml/blob/main/dev/NavigationView/NavigationView.cpp#L3963.
On NaviagtionView load event pan title can be changed, this will recalculate button size
private void NavigationView_Loaded(object sender, RoutedEventArgs e) {
    var navigation = (NavigationView)sender;
    navigation.PaneTitle = " ";
    navigation.PaneTitle = "";
}

Quick fix for this is to forse toggle pan button size recalcuation. Togle size calculation will be trigger when pane title is changed https://github.com/microsoft/microsoft-ui-xaml/blob/main/dev/NavigationView/NavigationView.cpp#L3963.
On NaviagtionView load event pan title can be changed, this will recalculate button size
private void NavigationView_Loaded(object sender, RoutedEventArgs e) {
    var navigation = (NavigationView)sender;
    navigation.PaneTitle = " ";
    navigation.PaneTitle = "";
}

Yes, this works. Thanks.


Meta issue: In the new bug-report and feature-request issue templates, help users determine whether the cmdlet / module in question is maintained in this repo

Summary of the new feature / enhancement
This is primarily a problem on Windows, where several modules that ship with Windows and are maintained elsewhere are available by default in PowerShell Core too, due to C:\WINDOWS\system32\WindowsPowerShell\v1.0\Modules  being included in $env:PSModulePath.
It is a recurring problem that users create issues that don't belong in this repo, because it isn't readily obvious where a given cmdlet / module is being maintained, and it is cumbersome to explain the problem every time - see #23978 for a recent example.
Thus, I suggest adding a bullet point under Prerequisites to https://github.com/PowerShell/PowerShell/blob/master/.github/ISSUE_TEMPLATE/Bug_Report.yaml entitled, say, "Make sure that any affected cmdlet is maintained in this repository.", that links to a yet-to-be-created help topic, which:

explains how to determine for a given cmdlet whether its source code is maintained in this repository.
if not, and if it is part of a module that ships with Windows, advises users to report the issue via the the Feedback Hub app instead.
also, it's worth listing and linking to those modules that do ship with PowerShell, but are maintained in separate repos, such as PSReadLine, PSResourceGet, and ThreadJob.

Said topic can then also be pointed to should inapplicable reports be filed nonetheless.
The same prerequisite is worth adding to https://github.com/PowerShell/PowerShell/blob/master/.github/ISSUE_TEMPLATE/Feature_Request.yaml, to spare users from creating feature requests in vain.
Proposed technical implementation details (optional)
Said topic could include the following helper function, Get-CommandOrigin (source code below), which accepts any command name (and resolves aliases first), and whose output object offers two Boolean properties of interest, BuiltIn, and ShipsWithWindows:
For instance (run on Windows):
PS> Get-CommandOrigin New-ScheduledTaskSettingsSet

Command          : New-ScheduledTaskSettingsSet
Type             : Function
BuiltIn          : False
ShipsWithWindows : True
Module           : ScheduledTasks
RepositoryUri    :

The output can guide users as follows:

If BuiltIn is $true, this repository is the right place to file an issue.
Otherwise:

If ShipsWithWindows is $true, use the Feedback Hub.
Otherwise, contact the module's authors, using the (hopefully filled-in) RepositoryUri value.

Get-CommandOrigin source code (can be pasted at the prompt):
function Get-CommandOrigin {
  param([Parameter(Mandatory)] $Command)
  Set-StrictMode -Version 1
  $cmd = Get-Command $Command -ErrorAction Stop
  if ($cmd.ResolvedCommand) { $cmd = $cmd.ResolvedCommand }
  [pscustomobject] @{
    Command = $cmd
    Type = $cmd.CommandType
    # Note: One Microsoft.PowerShell.* module, Microsoft.PowerShell.Core, is built into the binary
    #       and has no external representation in the file-system. It can be identified by having a
    #       a non-empty .ModuleName property while having a $null-valued .Module property.
    BuiltIn = (-not $cmd.Module -and $cmd.ModuleName) -or ($cmd.Module -and $cmd.Module.Path.StartsWith($PSHOME + [IO.Path]::DirectorySeparatorChar, 'InvariantCultureIgnoreCase'))
    ShipsWithWindows = $(if ($env:OS -eq 'Windows_NT') { $cmd.Module -and $cmd.Module.Path.StartsWith("$env:SystemRoot\System32\WindowsPowerShell\v1.0\Modules\", 'InvariantCultureIgnoreCase') })
    Module = $cmd.ModuleName
    RepositoryUri = [string] $cmd.Module.ProjectUri
  }
}

I like your intent, but getting folks used to running script they see on the web is probably not a good idea.  I think an alternative approach might be to create an AzureFunction that periodically scans the issues to identify if they are appropriate for this repo.  However, although I've come across some for WInPS5.1 or Windows, in general, I don't think it's been a large enough number to warrant efforts in any change (if you have some data handy, that might convince me otherwise).

getting folks used to running script they see on the web is probably not a good idea.

I don't think that'll be a problem; someone who's willing to report an issue here (a) can be assumed to be savvy enough to know under what circumstances running code found on the web is safe and (b) can be assumed to trust a piece of code that is published by the team / as part of the official docs (also, the function is so short that it's easy to tell what it does and that it doesn't do anything nefarious).

alternative approach might be to create an AzureFunction that periodically scans the issues to identify if they are appropriate for this repo.

That sounds like a great idea, and is worth implementing either way, but to me it would complement what I'm proposing here, which is to prevent posting of inapplicable issues to begin with.

I don't think it's been a large enough number to warrant efforts in any change (if you have some data handy, that might convince me otherwise).

I have no data other than my anecdotal experience, and I'm not interested in digging deeper.
In my anecdotal experience the problem occurred often enough to first get me to write up reusable canned responses, and finally to create this issue, in order to ideally prevent the problem to begin with and at least have official documentation to point to, should inapplicable issues still slip through.
I half wrote this issue in anticipation of no action being taken, and wrote it in a way that it can serve as a - suboptimal - substitute for official documentation / guidance in the issue template.
In the future, I'll be pointing users who post inapplicable issues to this one.
Furthermore, users interested in curating this repo can use the Get-CommandOrigin themselves to easily ascertain themselves whether a given cmdlet is maintained in this repo or not.


如何实现一个锚点接受多条线

如何实现一个锚点接受多条线

If I understood you correctly, the answer to your question is here:
https://github.com/ghostiam/vue-blocks/issues/16


Leetcode virtual judge

This PR is not completed yet. Opened for code review and tracking progress.

@yukozh Leetcode only provide last failed / timeout test case and it have already been attached in Hint


Laravel Mix empties file while “watch”-ing

Laravel Mix Version: 0.12.1
Node Version 8.1.2
NPM Version (npm -v): 5.4.2
OS: CentOS

Description:
I am running npm run watch and it works perfectly with all my SASS or CSS files. I also have this line of code there:
.scripts(['resources/assets/js/specific/dashboard.js'], 'public/js/specific/all.js')
Every time I run npm run watch dashboard.js is succesfully compiled into all.js.
However every time I make a change in dashboard.js laravel mix instantly empties all.js never to fill it up again. If I Ctrl+c the process and run npm run watch again it compiles it successfully again.
This is bad because every time I make a change in the js (that I'm currently developing) I need to go back and restart the process and wait for it.

Please update your install of Laravel Mix to a current version. You have a very outdated version.

Your readme File:

Laravel Project
Laravel 5.4 ships with everything you need to get started. Simply:
Install Laravel
Run npm install
Visit your webpack.mix.js file, and get started!

I have installed Laravel 5.4 and somehow I am running a very outdated version...

Laravel Mix. It’s now 1.5.1.

I know ... My point was that Laravel-Mix readme says "Laravel 5.4 ships with everything you need" which apparently is not true since it comes with very outdated version.
Should npm update laravel-mix update it?

Just sent a PR to the docs to fix the reference to Laravel 5.4. #1285


Handles MISSING_EMAIL error from server.

Also fixed the public error name string for the error.

Added unit test for the new error message translation.


lua-language-server: 3.13.3 -> 3.13.4

Release: https://github.com/LuaLS/lua-language-server/releases/tag/3.13.4
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review pr 364882

x86_64-linux

:white_check_mark: 8 packages built:

lua-language-server
lua51Packages.llscheck
lua52Packages.llscheck
lua53Packages.llscheck
lua54Packages.llscheck
luajitPackages.llscheck
lunarvim
vscode-extensions.sumneko.lua


User names inconsistent between core and contrib

I just noticed that the user names for the linux services for otelcol and otelcol-contrib are not consistently named.

distro
  username

otelcol
 otel

otelcol-contrib
 otelcol-contrib

I believe this is a bug :-)

Changing the username sounds like a breaking change to me. Do I need to keep anything in mind while fixing this?

I can't think of anything important other than taking care of the files created by the previous user, like the persistent sending queue files.

i guess this is a duplicate of https://github.com/open-telemetry/opentelemetry-collector-releases/issues/417


Non-deterministic behaviour for describe and the ` character

1 case
I have the following spec:
RSpec.describe User do
  subject(:user) { record }

  let(:record) { create(:user) }

  describe `validations` do
    it { is_expected.to allow_values('', nil).for :username }
  end
end

I run tests and I get:
ydakuka@yauhenid:~/Work/main_app$ bin/rails_docker rspec spec/models/user_spec.rb

An error occurred while loading ./spec/models/user_spec.rb.
Failure/Error:
  describe `validations` do
    it { is_expected.to allow_values('', nil).for :username }
  end

Errno::ENOENT:
  No such file or directory - validations
# ./spec/models/user_spec.rb:11:in ``'
# ./spec/models/user_spec.rb:11:in `block in <top (required)>'
# ./spec/models/user_spec.rb:5:in `<top (required)>'

2 case
RSpec.describe User do
  subject(:user) { record }

  let(:record) { create(:user) }

  describe `.custom_search` do
    subject(:result) { described_class.custom_search(query) }

    let(:query) { nil }

    let!(:user) { create(:user, email: email, username: username) }

    let(:email) { Faker::Internet.email }
    let(:username) { Faker::Internet.unique.username(specifier: 5..30, separators: []) }

    context 'when query is blank' do
      let(:query) { '    ' }

      specify do
        expect(result.to_set).to eq Set.new [user]
      end
    end
  end
end

I run tests and get the error again.
ydakuka@yauhenid:~/Work/main_app$ bin/rails_docker rspec spec/models/user_spec.rb

An error occurred while loading ./spec/models/user_spec.rb.
Failure/Error:
    describe `.custom_search` do
      subject(:result) { described_class.custom_search(query) }

      let(:query) { nil }

      let!(:user) { create(:user, email: email, username: username) }

Errno::ENOENT:
  No such file or directory - .custom_search
# ./spec/models/user_spec.rb:10:in ``'
# ./spec/models/user_spec.rb:10:in `block in <top (required)>'
# ./spec/models/user_spec.rb:5:in `<top (required)>'

3 case
And the last case, I have the following code:
RSpec.describe User do
  subject(:user) { record }

  let(:record) { create(:user) }

  describe `#confirmation_period` do
    subject(:result) { user.confirmation_period }

    let :user do
      create(:user, confirmation_token: confirmation_token,
                    confirmation_sent_at: confirmation_sent_at)
    end

    let(:confirmation_token) { Devise.friendly_token }
    let(:confirmation_sent_at) { Time.zone.yesterday }

    context 'when confirmation_sent_at is nil' do
      let(:confirmation_sent_at) { nil }

      specify do
        expect(result).to be_within(3).of(Time.now.utc)
      end
    end
  end
end

I run tests and get the output:
ydakuka@yauhenid:~/Work/main_app$ bin/rails_docker rspec spec/models/user_spec.rb

Randomized with seed 52396

User

    when confirmation_sent_at is nil
      is expected to be within 3 of 2024-02-16 13:31:06.595864359 +0000

Finished in 0.51541 seconds (files took 3.68 seconds to load)
1 example, 0 failures

I expected to see the following output
User
  #confirmation_period
    when confirmation_sent_at is nil
      is expected to be within 3 of 2024-02-16 13:32:56.238174256 +0000

, but the next sentence (#confirmation_period) had disappeared.

This will be fixed in #1796 ?

I hadn't seen this pull request before, but I checked - yes, it fixes my issue.


Multistage: connect(..) failed: Address family not supported by protocol release v1.0.0

Pinot1.0.0 using multistage v2 option deployed from distribution, gets error running query.
Can see server/broker listening on the query and mailbox ports ok but client cannot connect to query.
Tried switching netty native v java implementation =  no difference
Tried prefer ipv4 = no difference apart from the query showed that multistage was not enabled until the cluster config enable multistage was added in.
Online search suggests a shading issue with the grpc library in the distro.
https://stackoverflow.com/questions/73286776/grpc-unsupportedaddresstypeexception-but-only-when-packaged-with-shadowjar
QueryExecutionError:
Error dispatching query to server=yourserver.com@{10124,10126} stage=2
org.apache.pinot.query.service.dispatch.QueryDispatcher.submit(QueryDispatcher.java:144)
org.apache.pinot.query.service.dispatch.QueryDispatcher.submitAndReduce(QueryDispatcher.java:93)
org.apache.pinot.broker.requesthandler.MultiStageBrokerRequestHandler.handleRequest(MultiStageBrokerRequestHandler.java:179)
org.apache.pinot.broker.requesthandler.BaseBrokerRequestHandler.handleRequest(BaseBrokerRequestHandler.java:263)
UNAVAILABLE: io exception
io.grpc.Status.asRuntimeException(Status.java:539)
io.grpc.stub.ClientCalls$StreamObserverToCallListenerAdapter.onClose(ClientCalls.java:487)
io.grpc.internal.ClientCallImpl.closeObserver(ClientCallImpl.java:576)
io.grpc.internal.ClientCallImpl.access$300(ClientCallImpl.java:70)
connect(..) failed: Address family not supported by protocol: /yourserver.com:10124
connect(..) failed: Address family not supported by protocol
io.grpc.netty.shaded.io.netty.channel.unix.Errors.newConnectException0(Errors.java:155)
io.grpc.netty.shaded.io.netty.channel.unix.Errors.handleConnectErrno(Errors.java:128)
io.grpc.netty.shaded.io.netty.channel.unix.Socket.connect(Socket.java:313)
io.grpc.netty.shaded.io.netty.channel.epoll.AbstractEpollChannel.doConnect0(AbstractEpollChannel.java:773)
connect(..) failed: Address family not supported by protocol
io.grpc.netty.shaded.io.netty.channel.unix.Errors.newConnectException0(Errors.java:155)
io.grpc.netty.shaded.io.netty.channel.unix.Errors.handleConnectErrno(Errors.java:128)
io.grpc.netty.shaded.io.netty.channel.unix.Socket.connect(Socket.java:313)
io.grpc.netty.shaded.io.netty.channel.epoll.AbstractEpollChannel.doConnect0(AbstractEpollChannel.java:773)

This is a good question to be posted in the slack troubleshooting channel

Have tagged you in the post on the slack channel.

I don't have an answer to this, but this line seems suspicious: connect(..) failed: Address family not supported by protocol: /yourserver.com:10124
@walterddr @xiangfu0 Any idea?

looks related to https://github.com/grpc/grpc-java/issues/9387. did we recently updated io.grpc package version?

@walterddr Last update was in #10312


Jupyter Statusbar doesn't exist

this command cannot locate the statusbar package; was it recently deprecated?
https://github.com/NVIDIA-AI-IOT/jetcard/blob/master/install.sh#L61

Hi Dwaynekj,
Thanks for reaching out.  Yes, I think status bar is now included in the latest version of Jupyter Lab.
We've removed the status bar dependency from the install script in this branch which is a WIP
https://github.com/NVIDIA-AI-IOT/jetcard/tree/jetpack_4.2.1
Best,
John

Thanks

I filed this pull request to remove the status bar.
https://github.com/NVIDIA-AI-IOT/jetcard/pull/12

Awesome. Glad to see the responsiveness and support


Gradle complains about invalid tool chain - picking up the source package location - it should just ignore them [Backport]

See

#22921

Done in #25181


Add inso export spec command

inso export spec [-o, --output] [identifier]
Prompt if no identifier

Print to console

Output to file, file in directory, or a directory

TODO:

[x] Unit tests

Mocking of the db isn't easily possible for unit tests right now, hoping to improve that in the future.
Closes #2368

I really like the thorough testing 🎉


Type of variable is inferred from literal instead of annotation

Search Terms:
variable
literal
type inference
type annotation
TS2367
TS2339
Code
type Foo = number | "test";

let x: Foo = 5;
let y = <Foo>5;

function bar() {
    x = "test";
    y = "test";
}
bar();

if (x === "test") { // TS2367 This condition will always return 'false' since the types 'number' and 'string' have no overlap.
    console.log(x.length); // TS2339 Property 'length' does not exist on type 'number';
}
if (y === "test") {
    console.log(y.length);
}

Expected behavior:
No error should be produced here, since the variable x was declared to be of type Foo, not number, even though it was initialized with a number literal, it's not declared as a const and thus could change (and in fact does).
Actual behavior:
The compiler seems to infer the type of x as number, from the literal 5 used to initialize it, even though the variable type is explicitly declared to be of type Foo.
Playground Link:
Playground
Related Issues:
#26979
#10195

Your real complaint here is that the side effect in the function wasn't considered; see #9998.
Initialization is the same as assignment, so
let x: Foo = 5;

gets the same treatment as
let x: Foo = (whatever);
x = 5;

Given this, it would be ridiculous to error on
let x: Foo = (whatever);
x = 5;
x.toFixed(); // Error, Foo might be "test" ?????

That's fair. I also think it's fair for the compiler to not recognize that side-effect. It can't investigate everything.
For context, the real-world scenario where this came up was...
interface ValidationErrorMap {
    readonly [errorCode: string]: string | ValidationErrorMap;
}

type ValidationResult = ValidationErrorMap | "success";

function combine(ReadonlyArray<ValidationResult>results): ValidationResult {
    let finalResult: ValidationResult = "success";

    for(const result of results) {
        finalResult = (result === "success") ? finalResult
            : (finalResult === "success") ? result
            : { ...finalResult, ...result };
    }

    return finalResult;
}

Here, I would definitely expect the side-effect to be recognizable, as it's happening in the same scope, just inside a loop.


AllowedIdentityTokenSigningAlgorithms does not exist

Hi,
I've updated to 4.0.0 version, rebuilt and run in develop the IdentityServer.
I tried to get token but i got an Sql exception:
"column c.AllowedIdentityTokenSigningAlgorithms does not exist"
I dropped my test db to try created from null via migration.
I recognized the two sql script are not contains the column:
CREATE TABLE "Clients" (
"Id" integer NOT NULL GENERATED BY DEFAULT AS IDENTITY,
"Enabled" boolean NOT NULL,
"ClientId" character varying(200) NOT NULL,
"ProtocolType" character varying(200) NOT NULL,
"RequireClientSecret" boolean NOT NULL,
"ClientName" character varying(200) NULL,
"Description" character varying(1000) NULL,
"ClientUri" character varying(2000) NULL,
"LogoUri" character varying(2000) NULL,
"RequireConsent" boolean NOT NULL,
"AllowRememberConsent" boolean NOT NULL,
"AlwaysIncludeUserClaimsInIdToken" boolean NOT NULL,
"RequirePkce" boolean NOT NULL,
"AllowPlainTextPkce" boolean NOT NULL,
"AllowAccessTokensViaBrowser" boolean NOT NULL,
"FrontChannelLogoutUri" character varying(2000) NULL,
"FrontChannelLogoutSessionRequired" boolean NOT NULL,
"BackChannelLogoutUri" character varying(2000) NULL,
"BackChannelLogoutSessionRequired" boolean NOT NULL,
"AllowOfflineAccess" boolean NOT NULL,
"IdentityTokenLifetime" integer NOT NULL,
"AccessTokenLifetime" integer NOT NULL,
"AuthorizationCodeLifetime" integer NOT NULL,
"ConsentLifetime" integer NULL,
"AbsoluteRefreshTokenLifetime" integer NOT NULL,
"SlidingRefreshTokenLifetime" integer NOT NULL,
"RefreshTokenUsage" integer NOT NULL,
"UpdateAccessTokenClaimsOnRefresh" boolean NOT NULL,
"RefreshTokenExpiration" integer NOT NULL,
"AccessTokenType" integer NOT NULL,
"EnableLocalLogin" boolean NOT NULL,
"IncludeJwtId" boolean NOT NULL,
"AlwaysSendClientClaims" boolean NOT NULL,
"ClientClaimsPrefix" character varying(200) NULL,
"PairWiseSubjectSalt" character varying(200) NULL,
"Created" timestamp without time zone NOT NULL,
"Updated" timestamp without time zone NULL,
"LastAccessed" timestamp without time zone NULL,
"UserSsoLifetime" integer NULL,
"UserCodeType" character varying(100) NULL,
"DeviceCodeLifetime" integer NOT NULL,
"NonEditable" boolean NOT NULL,
CONSTRAINT "PK_Clients" PRIMARY KEY ("Id")
);
CREATE TABLE "Clients" (
"Id" integer NOT NULL GENERATED BY DEFAULT AS IDENTITY,
"Enabled" boolean NOT NULL,
"ClientId" character varying(200) NOT NULL,
"ProtocolType" character varying(200) NOT NULL,
"RequireClientSecret" boolean NOT NULL,
"ClientName" character varying(200) NULL,
"Description" character varying(1000) NULL,
"ClientUri" character varying(2000) NULL,
"LogoUri" character varying(2000) NULL,
"RequireConsent" boolean NOT NULL,
"AllowRememberConsent" boolean NOT NULL,
"AlwaysIncludeUserClaimsInIdToken" boolean NOT NULL,
"RequirePkce" boolean NOT NULL,
"AllowPlainTextPkce" boolean NOT NULL,
"AllowAccessTokensViaBrowser" boolean NOT NULL,
"FrontChannelLogoutUri" character varying(2000) NULL,
"FrontChannelLogoutSessionRequired" boolean NOT NULL,
"BackChannelLogoutUri" character varying(2000) NULL,
"BackChannelLogoutSessionRequired" boolean NOT NULL,
"AllowOfflineAccess" boolean NOT NULL,
"IdentityTokenLifetime" integer NOT NULL,
"AccessTokenLifetime" integer NOT NULL,
"AuthorizationCodeLifetime" integer NOT NULL,
"ConsentLifetime" integer NULL,
"AbsoluteRefreshTokenLifetime" integer NOT NULL,
"SlidingRefreshTokenLifetime" integer NOT NULL,
"RefreshTokenUsage" integer NOT NULL,
"UpdateAccessTokenClaimsOnRefresh" boolean NOT NULL,
"RefreshTokenExpiration" integer NOT NULL,
"AccessTokenType" integer NOT NULL,
"EnableLocalLogin" boolean NOT NULL,
"IncludeJwtId" boolean NOT NULL,
"AlwaysSendClientClaims" boolean NOT NULL,
"ClientClaimsPrefix" character varying(200) NULL,
"PairWiseSubjectSalt" character varying(200) NULL,
"Created" timestamp without time zone NOT NULL,
"Updated" timestamp without time zone NULL,
"LastAccessed" timestamp without time zone NULL,
"UserSsoLifetime" integer NULL,
"UserCodeType" character varying(100) NULL,
"DeviceCodeLifetime" integer NOT NULL,
"NonEditable" boolean NOT NULL,
CONSTRAINT "PK_Clients" PRIMARY KEY ("Id")
);
This my config:

What did i make wrong?
Please help.
Peter

I solved. When i updated to version 4, i missed to create EF migration, because i didn't know about models are changed. So i created migration, now everything is ok in related to this issue.


⚠ Mobitopup has degraded performance

In 5114d69, Mobitopup (https://napcard.voz.tech) experienced degraded performance:

HTTP code: 200
Response time: 7362 ms

Resolved: Mobitopup performance has improved in 6ef1559.


DayPickerSingleDateController: initialVisibleMonth prop doesn't do anything

react-dates version
<EMAIL_ADDRESS>Describe the bug
Defining initialVisibleMonth prop for DayPickerSingleDateController doesn't do anything.
Source code (including props configuration)
<DayPickerSingleDateController
    initialVisibleMonth={() => moment().add(10, "months")}
/>

Is the issue reproducible in Storybook?
https://codesandbox.io/s/romantic-vaughan-yh5ux?file=/src/App.js:267-365
Additional context
I found this issue when tried to block some days on the calendar while using the prop. It caused unexpected behavior with blocking days.

@meness just noticed that it doesn't work without focused prop:
<DayPickerSingleDateController focused initialVisibleMonth={() => moment().add(10, "months")} />


Address issue #216: rename the klass argument to create_protocol.

This addresses issue #216.
One minor note: you'll notice in the signatures that I made the default value None instead of the default class. The reason is that this makes the API somewhat friendlier when it comes to composing functions, etc. For example, if an end user defines a wrapper function and wants the same default, they can get the same default by passing None. They don't need to hard-code the default value in a second place. Secondarily, when it comes to deciding between create_protocol and klass, this makes it easier to know which arguments were explicitly passed.

Excellent! :+1: for using None as a default value.
I suggested a few tweaks. If you're OK with them, please merge.
Thanks!

Thanks, Aymeric!


Errors in Setup installing canvas-node

I had to work around several errors in the Setup section trying to install canvas-node.
Per the setup instructions I ran:
cargo install canvas-node --git https://github.com/paritytech/canvas-node.git --tag v0.1.4 --force --locked

The error output was:
      Finished release [optimized] target(s) in 3m 43s
       Running `/var/folders/0_/dlzw2fln1p92431h0vhwcy8r0000gn/T/cargo-installGXZhpP/release/wbuild-runner/canvas-runtime13762416086584014943/target/x86_64-apple-darwin/release/wasm-build-runner-impl`
  Rust WASM toolchain not installed, please install it!

  Further error information:
  ------------------------------------------------------------
     Compiling wasm-test v1.0.0 (/var/folders/0_/dlzw2fln1p92431h0vhwcy8r0000gn/T/.tmpKzTi9d)
  error[E0463]: can't find crate for `std`
    |
    = note: the `wasm32-unknown-unknown` target may not be installed

  error: aborting due to previous error

  For more information about this error, try `rustc --explain E0463`.
  error: could not compile `wasm-test`

  To learn more, run the command again with --verbose.
  ------------------------------------------------------------

warning: build failed, waiting for other jobs to finish...
error: failed to compile `canvas-node v0.1.0 (https://github.com/paritytech/canvas-node.git?tag=v0.1.4#258b0fab)`, intermediate artifacts can be found at `/var/folders/0_/dlzw2fln1p92431h0vhwcy8r0000gn/T/cargo-installGXZhpP`

Caused by:
  build failed

I am new to rust so though I solved the problem by cargo-culting various commands I found searching for the error I didn't really know what was going on. I went into the Setup process with what I believe is a fairly stock rust install. I don't believe I have done anything exotic. So I suspect others trying to run this setup would likely run into the same problem.
The fix involved, I believe, downgrading my version of rust and installing some very specific nightly toolchain from almost 6 months ago. Going in to the setup my rust version was rustc 1.48.0 (7eac88abb 2020-11-16). I then ran the following which I found in some github issue:
rustup default 1.45.1
rustup toolchain install nightly-2020-08-23
rustup target add wasm32-unknown-unknown --toolchain nightly-2020-08-23
rustup toolchain list

After running this my rustup show was:
rustup show
Default host: x86_64-apple-darwin
rustup home:  /Users/marcel/.rustup

installed toolchains
--------------------

stable-x86_64-apple-darwin
nightly-2020-08-23-x86_64-apple-darwin
nightly-x86_64-apple-darwin
1.45.1-x86_64-apple-darwin (default)

active toolchain
----------------

1.45.1-x86_64-apple-darwin (default)
rustc 1.45.1 (c367798cf 2020-07-26)

Not really knowing what was going on I then tried to install canvas-node again but prefixed with cargo +nightly-2020-08-23. This seemed to work.
So again, I am new to rust and I should stress that I have no idea if what I did to fix this is the right way to fix it or why my environment caused the error in the first place. Apologies if I'm not providing standard debugging information that would be useful.

Closing this as I see instructions now about needing to use nightly toolchains in the linked https://substrate.dev/docs/en/knowledgebase/getting-started/ page.

Closing this as I see instructions now about needing to use nightly toolchains in the linked https://substrate.dev/docs/en/knowledgebase/getting-started/ page.


Unable to build on Windows 10

This issue is meant to track the current inability to build virtual_camera ROS2 package on Windows 10.
The failure to build has been identified to be:
The inability to build `cv_bridge` dependency on Windows 10.

Being unable to have that dependency, `virtual_camera` is thus unable to build.

This inability to build cv_bridge is shown in the screenshot provided below:

This error is encountered when trying to build cv_bridge from source using  ros2 branch of vision_opencv. Click here.

Issue resolved.
Please see Issue 349 of vision_opencv.


Set start index through command flag in abb_runner

From #37

This is now done through progress files.


Unparser cannot display the correct list units.

If I have the following definition:
module TEST

   syntax ParamAttr ::= "sret"
   syntax FunAttr ::= "abc"
   syntax Types ::= "i32"
   syntax ArgType ::= FunAttrs Types ParamAttrs
   syntax ParamAttrs ::= List{ParamAttr," "}
   syntax FunAttrs ::= List{FunAttr," "}

   configuration <k> $PGM:ArgType </k>

endmodule

If I run the program "i32", the output of K will be:
<k>
    .FunAttrs i32 .FunAttrs
</k>

Even if the sort of FunAttrs is different the sort of ParamAttrs and the FunAttr and ParamAttr have not common terms, K cannot display the correct units for the two different lists.

Interesting.  @laurayuwen, can you take a look to see if it can be fixed trivially?  If not, let's then wait until we transit to KORE.  On the other hand, if this is happening already in KORE, then we need to fix it asap.

I also noticed this problem, when we don't assign different KLabels in List declaration, the list terminator is the same for lists using the same seperator, thus just seeing a list terminator, like in the example '.List{" "}(.KList), we don't know which list it is (FunAttrs or ParamAttrs). Just reasoning about the problem, I think of three solutions can be for the users to add different KLabels to different lists, or for the developers to change the representation of list terminators, or to perform some context analysis from syntax defined.  The last two solutions are non-trivial. I will have a look at code to see if there is anything missing that can provide a trivial solution.

In KORE, each KLabel should have attached to it the production it comes from.  That should be enough for the pretty printer to know what to do.  Please don't spend much time on this, especially if @liyili2 is talking about the KIL pretty printer.

We need to test that this is correct in the new parser implementation.


[Breaking Change] Generic math shifts should use the appropriate mask

Description
Introduced with https://github.com/dotnet/runtime/pull/103900
Version
.NET 10 Preview 1
Previous Behavior
The behavior when utilizing generic math to perform a shift on a T could differ based on the type. In some case it would appropriately mask the shift amount by sizeof(T) - 1 and in other cases it would do no masking. This meant that "overshifting" (such as shifting a byte by 8) could result in different answers being produced than expected.
New Behavior
The implementations were updated to mask the shift amount, as appropriate, to ensure consistent behavior across all built-in integer types and with the behavior documented by the IShiftOperators interface.
Reason for change
The behavior differed from the designed behavior due to a difference in how masking works for small integer types in C#.
Feature Area
Numerics
Affected APIs
operator <<, operator >>, and operator >>> for byte, char, sbyte, short, and ushort when used via Generic Math, which requires a T constrained to where T : IShiftOperators<T, int, T> or a similar interface.

A small correct: The mask was 31 (not no mask) because they were converted to int.


Conversions should not consume String

Looks like most (all?) conversions create a new String, which means it should be sufficient for them to accept &str and not a String.
This way it would be possible to convert borrowed strings without cloning them (which is expensive due to extra temporary heap allocation and copying data).

:+1:. I'd be interested in a PR if you're up for it. If not I'll have a look over the next few days.


HTTP::Client Wont support SSL

It wont automatically set port to 443 if the URI begins with https://
when specified :443 in URI it wont negotiate SSL connection

I'm aware of that maybe we should handle it by parsing the URI

Btw is this related to Crystal std?

Btw i just gave this a try like below
./cryload -s https://www.google.com.tr -r 1000
And it was okay. What's the uri you trying ?

@Sdogruyol it tries to connect to google.com on port 80, and it works, but, looks at this:
 ./cryload --server https://<IP_ADDRESS>/ -r 1000                                                     :(
Preparing to make it CRY for 1000 requests!
Unhandled exception: Error connecting to '<IP_ADDRESS>:80': Connection refused

Is it something DNS related or what? It's pretty strange that it tries to connect to port 80 https lol

@Sdogruyol I suspect its an issue in Up-stream crystal std libs, we can open an issue

Want me to open it ?

@Sdogruyol Sure, just link the issue in upstream to this issue, so we know what's the issue and when it's fixed :)

Guess i find the root of the problem it's URI.parse related
https://github.com/Sdogruyol/cryload/blob/master/src/cryload.cr#L20-L22

You need to specify the "ssl" parameter while creating the HTTP::Client. Something like this:
client = HTTP::Client.new uri.host.not_nil!, port: uri.port, ssl: uri.scheme == "https"

What if i pass the scheme from URI.parse does it handle this ?

BTW... it worked fine with "https://www.google.com.tr/" because Google also has port 80 open ;-)

Ah yeah you are right :+1:

HTTP::Client will connect to port 80 or 443 (depending on the ssl parameter) unless another port is specified. URI#port is nil unless there is an explicit port specified in the URI string.

So i think getting the geting from URI.parse will solve this issue :+1:

Thanks @waj

Hey @bararchy can you rerun the test with head please :)

@Sdogruyol you're welcome!
Please close manastech/crystal#1089 once you know this fixed the issue.

Sure @waj thanks alot :+1:

@Sdogruyol Works like charm ;)
./cryload -s https://<IP_ADDRESS>/ -n 50
Preparing to make it CRY for 50 requests!
Unhandled exception: Error connecting to '<IP_ADDRESS>:443': Connection refused


[ENHANCEMENT] Bump rancher-logging chart version in Harvester v1.3.0

Is your enhancement related to a problem? Please describe.

Bump the proper version of rancher-logging in Harvester v1.3.0
https://github.com/rancher/charts/tree/b4221314e3eb0fbf777a5b0ea74df3fcda80ed46/charts/rancher-logging/102.0.1%2Bup3.17.10
Describe the solution you'd like

Depends on the Rancher version used in Harvester v1.3.0, the rancher-logging and rancher-logging-crd need to be bumped to related new version.
We also need a new release of event-router after PR https://github.com/harvester/eventrouter/pull/5  and use the new image  in rancher-logging.
Tasks:

[x] Bump harvester-eventrouter to v0.1.2 (https://github.com/harvester/harvester-installer/pull/628)
[x] Bump rancher-logging-crd and rancher-logging chart version (https://github.com/harvester/harvester-installer/pull/629)

Describe alternatives you've considered

Additional context

https://github.com/harvester/harvester/issues/4782
Rancher: v2.7.9
RKE2: v1.26.x

Tested together with #4941, close as fixed.


Bug in Collections/Compound tasks?

There seems to be a bug with the test(s) for
fun Shop.getNumberOfTimesProductWasOrdered(product: Product): Int
I've tried the the following two solutions:
Provided solution:
fun Shop.getNumberOfTimesProductWasOrdered(product: Product): Int {
    return customers.flatMap { it.getOrderedProductsList() }.count { it == product }
}

fun Customer.getOrderedProductsList(): List<Product> {
    return orders.flatMap { it.products }
}

My original solution:
fun Shop.getNumberOfTimesProductWasOrdered(product: Product): Int =
    customers.flatMap { it.orders }.flatMap { it.products }.count { it == product }

at the following two sites:

https://play.kotlinlang.org/koans/Collections/Compound tasks/Task.kt
https://try.kotlinlang.org/#/Kotlin Koans/Collections/Compound tasks/Task.kt

and I get

Assigning single elements to varargs in named form is forbidden

Just to add, I tried the same solution in the Playground at https://play.kotlinlang.org/ (using the same code from Shop.kt and simplified code from TestShop.kt) and it runs fine, giving the correct result.
I've attached the file with code copied from Playground.
Kotlin Playground.kt.zip

Got yesterday same issue. Because of that cant make 100% progress :(

I just hit this now. The easy solution is to change the runtime to something other than 1.3 in the bottom right corner.

Just hit the bug. It is just the testcase that is (now) wrong since it tries to assign a single value in named form to a collection. However @EhsanKia s temporary workaround does indeed work.

The bug is still not fixed, and looks like there is no way to change the Kotlin version in Koans.

Still there for me too :( its a shame I won't be able to get satisfaction of seeing 100% in the completion bar now 😢

Its still not working :(

@mgwizdal please hard refresh the page

@AlexanderPrendota Tried on different browsers and refreshsed hard - still the same issue

Please try one in private mode. Maybe it helps. Thanks


Fix python version

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[x] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

@conda-forge-admin Just updated the package, please help me merge the PR, thanks!


#112 Adding feature to insert document when overwrite and putIfAbsent…

… true

@jasonpet @rabbah This is for #112. Added putIfAbsent flag which if set to true along with overwrite=true will do an insertion operation if the document does not already exists(404)

Thanks for submitting the PR. Do you have an Apache ICLA on file? https://github.com/apache/incubator-openwhisk-package-cloudant/blob/master/CONTRIBUTING.md

It would be nice to add a unit test similar to the one here https://github.com/apache/incubator-openwhisk-package-cloudant/blob/master/tests/src/test/scala/system/packages/CloudantDatabaseActionsTests.scala#L290.

I can add a test and update the documentation.  I will open a separate PR

Added a new variable to provide backward compatibility. I'll update the code as per @csantanapr review comments, do @jasonpet and @rabbah agree?

@csantanapr I generally agree the intended behavior is to just update. The concern was about breaking existing code.
There are create and update actions which do the more conservative behavior. So we can treat this as a bug, remove the parameter and just do the update on 404. I'm OK with that too.

I guess only a test is needed now since we are not adding a new parameter.

Removed putIfAbsent flag, document is inserted if overwrite=true and it does not already exists in the database

@csantanapr changes updated, can you update your review?


Acorn.js contains invalid utf-8 sequence

My assumption is that acorn.js is utf-8 encoded, without a BOM.
I'm trying to use acorn in a chrome extension.  Chrome refuses to load the extension when acorn is included, claiming it "isn't UTF-8 encoded".
I've tried to verify that acorn is utf-8 encoded by processing it with iconv:
iconv -f utf-8 node_modules/acorn/dist/acorn.js

However, this fails when it gets to one of the unicode characters in the big regular expressions.
Interestingly, with a python script, I can read acorn.js, decode it from utf-8 to a string, re-encode it in utf-8, and end up with a file that is binary-identical to the original.
How is this file encoded?  Is my original assumption wrong?

It's just UTF-8. Looks like a duplicate of #238.

I believe you're right - thanks


Upgrade preact-compat

Summary

Updrading preact-compat fixes IE 11 + Google Maps clashing. My previous commit (see below) did not address the issue in the preact-compat library, which is also effecting. Upgrading the library resolves this.
Result

https://github.com/algolia/instantsearch.js/pull/2749
https://github.com/developit/preact-compat/pull/423

Folks responding to https://github.com/algolia/instantsearch.js/pull/2749 were correct: I was confused about where the error was actually coming from. While the Symbol checks in instantsearch might have also caused a problem, the real issue was the checks in preact-compat, which the mentioned PR resolves.
My apologies for my wrongness.

Hi @bronzehedwick thanks for opening this PR and for taking the time to contribute. However we can't upgrade to this version because it breaks the slider (https://deploy-preview-2751--algolia-instantsearch.netlify.com/v2/dev-novel/?selectedStory=RangeSlider.default) I haven't had time to investigate this specific issue even though encountered it when trying to upgrade the preact-compat lib too.

Ah ok, that's a bummer. I think we're going to go ahead with a fork for now, since we're not using the slider and we'd like to release this coming Tuesday. We can switch back to reference the upstream code once the issues have been worked through.
Thanks so much for your help!

Sorry about that @bronzehedwick Going with your own fork might be the best for now indeed


Improve base + blockfrost module maintainability

Background

Optional attributes in GenesisParameters and ProtocolParameters raises various errors.
Updating these dataclasses to be non-optional and frozen/immutable would produce less errors in the future in my opinion.

Goals

Update GenesisParameters and ProtocolParameters to be non-optional and frozen

$ make qa
poetry run flake8 pycardano
poetry run mypy --install-types --non-interactive pycardano
pycardano/backend/base.py:26: error: Incompatible types in assignment (expression has type "None", variable has type "float")
pycardano/backend/base.py:28: error: Incompatible types in assignment (expression has type "None", variable has type "int")
pycardano/backend/base.py:30: error: Incompatible types in assignment (expression has type "None", variable has type "int")
pycardano/backend/base.py:32: error: Incompatible types in assignment (expression has type "None", variable has type "int")
pycardano/backend/base.py:34: error: Incompatible types in assignment (expression has type "None", variable has type "int")
pycardano/backend/base.py:36: error: Incompatible types in assignment (expression has type "None", variable has type "int")
pycardano/backend/base.py:38: error: Incompatible types in assignment (expression has type "None", variable has type "int")
pycardano/backend/base.py:40: error: Incompatible types in assignment (expression has type "None", variable has type "int")
pycardano/backend/base.py:42: error: Incompatible types in assignment (expression has type "None", variable has type "int")
pycardano/backend/base.py:44: error: Incompatible types in assignment (expression has type "None", variable has type "int")
pycardano/backend/base.py:51: error: Incompatible types in assignment (expression has type "None", variable has type "int")
pycardano/backend/base.py:53: error: Incompatible types in assignment (expression has type "None", variable has type "int")
pycardano/backend/base.py:55: error: Incompatible types in assignment (expression has type "None", variable has type "int")
pycardano/backend/base.py:57: error: Incompatible types in assignment (expression has type "None", variable has type "int")
pycardano/backend/base.py:59: error: Incompatible types in assignment (expression has type "None", variable has type "int")
pycardano/backend/base.py:61: error: Incompatible types in assignment (expression has type "None", variable has type "int")
pycardano/backend/base.py:63: error: Incompatible types in assignment (expression has type "None", variable has type "int")
pycardano/backend/base.py:65: error: Incompatible types in assignment (expression has type "None", variable has type "float")
pycardano/backend/base.py:67: error: Incompatible types in assignment (expression has type "None", variable has type "float")
pycardano/backend/base.py:69: error: Incompatible types in assignment (expression has type "None", variable has type "float")
pycardano/backend/base.py:71: error: Incompatible types in assignment (expression has type "None", variable has type "float")
pycardano/backend/base.py:73: error: Incompatible types in assignment (expression has type "None", variable has type "str")
pycardano/backend/base.py:75: error: Incompatible types in assignment (expression has type "None", variable has type "int")
pycardano/backend/base.py:77: error: Incompatible types in assignment (expression has type "None", variable has type "int")
pycardano/backend/base.py:79: error: Incompatible types in assignment (expression has type "None", variable has type "int")
pycardano/backend/base.py:81: error: Incompatible types in assignment (expression has type "None", variable has type "int")
pycardano/backend/base.py:83: error: Incompatible types in assignment (expression has type "None", variable has type "float")
pycardano/backend/base.py:85: error: Incompatible types in assignment (expression has type "None", variable has type "float")
pycardano/backend/base.py:87: error: Incompatible types in assignment (expression has type "None", variable has type "int")
pycardano/backend/base.py:89: error: Incompatible types in assignment (expression has type "None", variable has type "int")
pycardano/backend/base.py:91: error: Incompatible types in assignment (expression has type "None", variable has type "int")
pycardano/backend/base.py:93: error: Incompatible types in assignment (expression has type "None", variable has type "int")
pycardano/backend/base.py:95: error: Incompatible types in assignment (expression has type "None", variable has type "int")
pycardano/backend/base.py:97: error: Incompatible types in assignment (expression has type "None", variable has type "int")
pycardano/backend/base.py:99: error: Incompatible types in assignment (expression has type "None", variable has type "int")
pycardano/backend/base.py:101: error: Incompatible types in assignment (expression has type "None", variable has type "int")
pycardano/backend/base.py:103: error: Incompatible types in assignment (expression has type "None", variable has type "int")
pycardano/backend/base.py:105: error: Incompatible types in assignment (expression has type "None", variable has type "Dict[str, Dict[str, int]]")
pycardano/backend/blockfrost.py:76: error: Incompatible return value type (got "None", expected "int")
pycardano/backend/blockfrost.py:87: error: Incompatible types in assignment (expression has type "GenesisParameters", variable has type "None")
pycardano/backend/blockfrost.py:88: error: Incompatible return value type (got "None", expected "GenesisParameters")
pycardano/backend/blockfrost.py:94: error: Incompatible types in assignment (expression has type "ProtocolParameters", variable has type "None")
pycardano/backend/blockfrost.py:126: error: Incompatible return value type (got "None", expected "ProtocolParameters")
pycardano/backend/blockfrost.py:141: error: Invalid self argument "Type[NativeScript]" to attribute function "from_dict" with type "Callable[[NativeScript, Dict[Any, Any], bool], Union[ScriptPubkey, ScriptAll, ScriptAny, ScriptNofK, InvalidBefore, InvalidHereAfter]]"
pycardano/backend/blockfrost.py:170: error: Argument 1 to "Value" has incompatible type "Optional[int]"; expected "int"
Found 45 errors in 2 files (checked 8 source files)
make: *** [Makefile:65: qa] Error 1

Codecov Report

Merging #120 (c9a8ba6) into main (a2c3a8e) will decrease coverage by 0.08%.
The diff coverage is 91.83%.

@@            Coverage Diff             @@
##             main     #120      +/-   ##
==========================================
- Coverage   86.36%   86.27%   -0.09%
==========================================
  Files          24       24
  Lines        2647     2631      -16
  Branches      514      510       -4
==========================================
- Hits         2286     2270      -16
  Misses        267      267
  Partials       94       94

Impacted Files
Coverage Δ

pycardano/backend/ogmios.py
60.00% <63.63%> (+1.05%)
:arrow_up:

pycardano/backend/base.py
100.00% <100.00%> (ø)

pycardano/address.py
76.40% <0.00%> (-1.26%)
:arrow_down:

pycardano/serialization.py
87.44% <0.00%> (-0.23%)
:arrow_down:

pycardano/plutus.py
91.23% <0.00%> (-0.14%)
:arrow_down:

pycardano/transaction.py
94.19% <0.00%> (-0.04%)
:arrow_down:

pycardano/txbuilder.py
91.61% <0.00%> (-0.04%)
:arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Major Updates

Enforcing GenesisParameters and ProtocolParameters to be frozen dataclasses with non-optional attributes

Refactor Ogmios context ProtocolParameter instantiation.
Adding missing ProtocolParameter.min_pool_cost for Blockfrost context

NativeScript

from_dict() method used to return either List or NativeScript instance depending on top_level boolean field. Removed this ambiguity by pulling out List generating logic into a separate helper method.
Adding a new testcase to ensure nested native scripts are parsed correctly

Minor Updates

base.py and blockfrost.py are included in mypy analysis

Hi @cffls
Please merge this one if everything looks good from your perspective.

I thought you had permission to merge. Let me double check. Thanks for the reminder.


Add API to change data visibility

This came up when removing the HTML legend. Adds two new public methods to the core Chart class for setting data & dataset visibility.

Oh, I so hate long function names. It could be even clearer if called setDatasetVisibilityAtIndex 😈  (j/k)
Seriously though, one of the argument behind setVisibility vs show / hide is less functions. If that's what we are looking for, why not just setVisibility(datasetIndex, index), where you can omit the index if setting for dataset?
Another argument is the usage pattern:
setVisible(shouldItBeVisible())

vs
if (itShouldBeVisible()) {
  show();
} else {
  hide();
}

Add animations to those:
let visible = shouldItBeVisible();
setVisibility(datasetIndex, index, visible);

// need to add some parameters to limit the update to those correct elements.
// `update` should not be a side effect of `set` function.
update(visible?'show':'hide', datasetIndex, index);

vs
if (itShouldBeVisible()) {
  show(datasetIndex, index); // update can be a side effect
} else {
  hide(datasetIndex, index);
}

And finally, I can live with the proposed ones, just wanted to share my thoughts.


Invalid ssh key format

Hey guys!
I have similar issue like #1  - and get same error. But same key works with fifsky/ssh-action@master without any problems, can you specify key format?

Found possbile fix - converted key to RSA format and all ok, I think better add this to README

can you please create a PR ?

Ok, I'll create PR with updated README


feat: Added Hebrew language to firebase_ui_localizations

Description
Added Hebrew language to firebase_ui_localizations
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

[x ] I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
[ x] My PR includes unit or integration tests for all changed/updated/fixed behaviors (See [Contributor Guide]).
[ x] All existing and new tests are passing.
[ x] I updated/added relevant documentation (doc comments with ///).
[ x] The analyzer (melos run analyze) does not report any problems on my PR.
[ x] I read and followed the [Flutter Style Guide].
[ x] I signed the [CLA].
[ x] I am willing to follow-up on review comments in a timely manner.

Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?

[ ] Yes, this is a breaking change.
[x ] No, this is not a breaking change.

Hey @beyondeye, do you mind having the translations checked over by someone else who speaks Hebrew with an approval, please? Perhaps a friend/colleague on GitHub? Unfortunately, no maintainers speak Hebrew.

Hi @russellwheatley. I speak Hebrew myself; I can search also for somebody else for a double check, do you have any specific requirement for the person I should that should check the translation?

@russellwheatley . So once I have somebody proofread all the translations what will be the procedure next? should I communicate his/her GitHub handle and you will give them authorization  to approve the pull request?

Thanks for the input @lironhl 😄. What do you think, @beyondeye?

@lironhl Thanks a lot! I have committed all the fixes.

@lironhl Again thank you. I hope that now we hunted down all the errors.