HBASE-24709 Support MoveCostFunction use a lower multiplier in offpea…

…k hours

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m  7s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 21s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 55s
master passed

+1 :green_heart:
checkstyle
2m 17s
master passed

+0 :ok:
refguide
5m 26s
branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.

+1 :green_heart:
spotbugs
11m 44s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 12s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 48s
the patch passed

-0 :warning:
checkstyle
2m 19s
root: The patch generated 1 new + 60 unchanged - 0 fixed = 61 total (was 60)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+0 :ok:
refguide
5m 34s
patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.

+1 :green_heart:
hadoopcheck
12m 17s
Patch does not cause any errors with Hadoop 3.1.2 3.2.1.

+1 :green_heart:
spotbugs
12m 17s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 26s
The patch does not generate ASF License warnings.

69m 39s

Subsystem
Report/Notes

Docker
Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2044/1/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2044

Optional Tests
dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle refguide

uname
Linux 3807de65804c 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 67dfbe0406

refguide
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2044/1/artifact/yetus-general-check/output/branch-site/book.html

checkstyle
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2044/1/artifact/yetus-general-check/output/diff-checkstyle-root.txt

refguide
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2044/1/artifact/yetus-general-check/output/patch-site/book.html

Max. process+thread count
122 (vs. ulimit of 12500)

modules
C: hbase-server . U: .

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 13s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
4m 45s
the patch passed

+1 :green_heart:
compile
3m 16s
the patch passed

+1 :green_heart:
javac
3m 16s
the patch passed

+1 :green_heart:
shadedjars
6m 40s
patch has no errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m 51s
hbase-server in the patch failed.

-0 :warning:
javadoc
0m 13s
root in the patch failed.

_ Other Tests _

+1 :green_heart:
unit
264m 10s
root in the patch passed.

299m  8s

Subsystem
Report/Notes

Docker
Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2044/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2044

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux e640fab0ccef 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 67dfbe0406

Default Java
2020-01-14

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2044/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-root.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2044/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2044/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2044/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-root.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2044/1/testReport/

Max. process+thread count
4406 (vs. ulimit of 12500)

modules
C: hbase-server . U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2044/1/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m  3s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 20s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 57s
master passed

+1 :green_heart:
checkstyle
2m 16s
master passed

+0 :ok:
refguide
5m 20s
branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.

+1 :green_heart:
spotbugs
11m 50s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 13s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 41s
the patch passed

+1 :green_heart:
checkstyle
2m 15s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+0 :ok:
refguide
5m 32s
patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.

+1 :green_heart:
hadoopcheck
12m 14s
Patch does not cause any errors with Hadoop 3.1.2 3.2.1.

+1 :green_heart:
spotbugs
12m  5s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 25s
The patch does not generate ASF License warnings.

69m 18s

Subsystem
Report/Notes

Docker
Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2044/2/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2044

Optional Tests
dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle refguide

uname
Linux aaa909b985ca 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 67dfbe0406

refguide
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2044/2/artifact/yetus-general-check/output/branch-site/book.html

refguide
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2044/2/artifact/yetus-general-check/output/patch-site/book.html

Max. process+thread count
122 (vs. ulimit of 12500)

modules
C: hbase-server . U: .

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 13s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
4m 40s
the patch passed

+1 :green_heart:
compile
3m  9s
the patch passed

+1 :green_heart:
javac
3m  9s
the patch passed

+1 :green_heart:
shadedjars
6m 33s
patch has no errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m 49s
hbase-server in the patch failed.

-0 :warning:
javadoc
0m 15s
root in the patch failed.

_ Other Tests _

+1 :green_heart:
unit
263m 51s
root in the patch passed.

298m 42s

Subsystem
Report/Notes

Docker
Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2044/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2044

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 77fbe74d915b 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 67dfbe0406

Default Java
2020-01-14

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2044/2/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-root.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2044/2/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2044/2/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2044/2/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-root.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2044/2/testReport/

Max. process+thread count
4232 (vs. ulimit of 12500)

modules
C: hbase-server . U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2044/2/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 38s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 25s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
4m 33s
master passed

+1 :green_heart:
checkstyle
2m 33s
master passed

+0 :ok:
refguide
6m 29s
branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.

+1 :green_heart:
spotbugs
14m 43s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 15s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
4m 29s
the patch passed

+1 :green_heart:
checkstyle
2m 37s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+0 :ok:
refguide
6m 30s
patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.

+1 :green_heart:
hadoopcheck
14m 21s
Patch does not cause any errors with Hadoop 3.1.2 3.2.1.

+1 :green_heart:
spotbugs
15m  5s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 30s
The patch does not generate ASF License warnings.

82m 42s

Subsystem
Report/Notes

Docker
Client=19.03.9 Server=19.03.9 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2044/1/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2044

Optional Tests
dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle refguide

uname
Linux 023cb3be288b 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / af1cc2fc44

refguide
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2044/1/artifact/yetus-general-check/output/branch-site/book.html

refguide
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2044/1/artifact/yetus-general-check/output/patch-site/book.html

Max. process+thread count
123 (vs. ulimit of 12500)

modules
C: hbase-server . U: .

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 16s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
5m 32s
the patch passed

+1 :green_heart:
compile
3m 41s
the patch passed

+1 :green_heart:
javac
3m 41s
the patch passed

+1 :green_heart:
shadedjars
7m 37s
patch has no errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m 51s
hbase-server in the patch failed.

-0 :warning:
javadoc
0m 16s
root in the patch failed.

_ Other Tests _

+1 :green_heart:
unit
249m 59s
root in the patch passed.

291m 16s

Subsystem
Report/Notes

Docker
Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2044/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2044

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 044d62a6f085 4.15.0-91-generic #92-Ubuntu SMP Fri Feb 28 11:09:48 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / af1cc2fc44

Default Java
2020-01-14

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2044/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-root.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2044/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2044/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2044/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-root.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2044/1/testReport/

Max. process+thread count
4483 (vs. ulimit of 12500)

modules
C: hbase-server . U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2044/1/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@virajjasani  Seems no more comments, could you help merge it? Thanks.

@virajjasani Ping.

The prob is that here we want change the multiplier everyday when the current hour switch between peak and offpeak, there will not a config changed event.
Thanks. @virajjasani

In my last comment,

That said, to remove this.conf = conf dependency, we can get two multipliers from config, and call setMultiplier() accordingly here in cost() by checking isOffPeakHour().

I meant in constructor, we can get two multipliers from config and remove the this.conf field. In cost() we call setMultiplier()  and choose the right parameter by checking isOffPeakHour().

In my last comment,

That said, to remove this.conf = conf dependency, we can get two multipliers from config, and call setMultiplier() accordingly here in cost() by checking isOffPeakHour().

I meant in constructor, we can get two multipliers from config and remove the this.conf field. In cost() we call setMultiplier() and choose the right parameter by checking isOffPeakHour().

Here need conf also: OffPeakHours.getInstance(conf).isOffPeakHour()

Here need conf also: OffPeakHours.getInstance(conf).isOffPeakHour()

Right. Unless we also save OffPeakHours instance in constructor...so the value of removing conf need much effort. We can stay with current implementation I guess then.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 19s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 20s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 58s
master passed

+1 :green_heart:
checkstyle
2m 20s
master passed

+0 :ok:
refguide
5m 43s
branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.

+1 :green_heart:
spotbugs
12m 13s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 12s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 49s
the patch passed

+1 :green_heart:
checkstyle
2m 17s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+0 :ok:
refguide
5m 40s
patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.

+1 :green_heart:
hadoopcheck
12m 47s
Patch does not cause any errors with Hadoop 3.1.2 3.2.1.

+1 :green_heart:
spotbugs
13m  6s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 27s
The patch does not generate ASF License warnings.

72m 16s

Subsystem
Report/Notes

Docker
Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2044/2/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2044

Optional Tests
dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle refguide

uname
Linux 88d3b4a74c8c 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 9b02a26a1d

refguide
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2044/2/artifact/yetus-general-check/output/branch-site/book.html

refguide
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2044/2/artifact/yetus-general-check/output/patch-site/book.html

Max. process+thread count
122 (vs. ulimit of 12500)

modules
C: hbase-server . U: .

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 12s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 56s
the patch passed

+1 :green_heart:
compile
2m 46s
the patch passed

+1 :green_heart:
javac
2m 46s
the patch passed

+1 :green_heart:
shadedjars
5m 45s
patch has no errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m 39s
hbase-server in the patch failed.

-0 :warning:
javadoc
0m 15s
root in the patch failed.

_ Other Tests _

-1 :x:
unit
163m 57s
root in the patch failed.

195m  7s

Subsystem
Report/Notes

Docker
Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2044/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2044

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 9254a5ab6f7c 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 9b02a26a1d

Default Java
2020-01-14

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2044/2/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-root.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2044/2/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2044/2/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2044/2/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-root.txt

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2044/2/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-root.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2044/2/testReport/

Max. process+thread count
6394 (vs. ulimit of 12500)

modules
C: hbase-server . U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2044/2/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Thanks @bsglz , let me merge this after QA results are out.

Seems the test failture unrelated to this PR, could you help to return QA to confirm?
Thanks. @virajjasani

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 34s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 23s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 38s
master passed

+1 :green_heart:
compile
2m 21s
master passed

+1 :green_heart:
shadedjars
5m 34s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
2m 37s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 13s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 24s
the patch passed

+1 :green_heart:
compile
2m 17s
the patch passed

+1 :green_heart:
javac
2m 17s
the patch passed

+1 :green_heart:
shadedjars
5m 34s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
2m 36s
the patch passed

_ Other Tests _

-1 :x:
unit
326m 27s
root in the patch failed.

358m 12s

Subsystem
Report/Notes

Docker
Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2044/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2044

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 886d7460b2ca 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 9b02a26a1d

Default Java
1.8.0_232

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2044/2/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-root.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2044/2/testReport/

Max. process+thread count
5627 (vs. ulimit of 12500)

modules
C: hbase-server . U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2044/2/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 32s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 22s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
4m  8s
master passed

+1 :green_heart:
checkstyle
2m 20s
master passed

+0 :ok:
refguide
5m 33s
branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.

+1 :green_heart:
spotbugs
13m 25s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 12s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 43s
the patch passed

+1 :green_heart:
checkstyle
2m 30s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+0 :ok:
refguide
6m 33s
patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.

+1 :green_heart:
hadoopcheck
13m 20s
Patch does not cause any errors with Hadoop 3.1.2 3.2.1.

+1 :green_heart:
spotbugs
14m 22s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 25s
The patch does not generate ASF License warnings.

75m 47s

Subsystem
Report/Notes

Docker
Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2044/3/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2044

Optional Tests
dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle refguide

uname
Linux fec8c79a9ecf 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 9b02a26a1d

refguide
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2044/3/artifact/yetus-general-check/output/branch-site/book.html

refguide
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2044/3/artifact/yetus-general-check/output/patch-site/book.html

Max. process+thread count
122 (vs. ulimit of 12500)

modules
C: hbase-server . U: .

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 13s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
4m  4s
the patch passed

+1 :green_heart:
compile
2m 44s
the patch passed

+1 :green_heart:
javac
2m 44s
the patch passed

+1 :green_heart:
shadedjars
5m 40s
patch has no errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m 39s
hbase-server in the patch failed.

-0 :warning:
javadoc
0m 15s
root in the patch failed.

_ Other Tests _

-1 :x:
unit
164m  9s
root in the patch failed.

195m 18s

Subsystem
Report/Notes

Docker
Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2044/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2044

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 5ce5d49295ee 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 9b02a26a1d

Default Java
2020-01-14

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2044/3/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-root.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2044/3/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2044/3/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2044/3/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-root.txt

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2044/3/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-root.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2044/3/testReport/

Max. process+thread count
6565 (vs. ulimit of 12500)

modules
C: hbase-server . U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2044/3/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

It's weird, yetus check is consistently failing for JDK11. I don't see suspect code here, triggered one more build. I saw some open master branch PRs, they don't have yetus failures. If next build also fails on yetus check, can we create another PR? I am not very sure but it could be PR specific?

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 33s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 22s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
4m  4s
master passed

+1 :green_heart:
compile
2m 33s
master passed

+1 :green_heart:
shadedjars
6m 10s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
3m 25s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 14s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
4m 25s
the patch passed

+1 :green_heart:
compile
2m 58s
the patch passed

+1 :green_heart:
javac
2m 58s
the patch passed

+1 :green_heart:
shadedjars
6m 15s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
2m 51s
the patch passed

_ Other Tests _

-1 :x:
unit
395m 29s
root in the patch failed.

432m  0s

Subsystem
Report/Notes

Docker
Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2044/3/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2044

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 1a94f71c1aae 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 9b02a26a1d

Default Java
1.8.0_232

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2044/3/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-root.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2044/3/testReport/

Max. process+thread count
4128 (vs. ulimit of 12500)

modules
C: hbase-server . U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2044/3/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 22s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 24s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
4m 48s
master passed

+1 :green_heart:
checkstyle
2m 45s
master passed

+0 :ok:
refguide
6m 10s
branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.

+1 :green_heart:
spotbugs
13m 55s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 14s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
4m  5s
the patch passed

+1 :green_heart:
checkstyle
2m 30s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+0 :ok:
refguide
6m  7s
patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.

+1 :green_heart:
hadoopcheck
13m 23s
Patch does not cause any errors with Hadoop 3.1.2 3.2.1.

+1 :green_heart:
spotbugs
14m 41s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 28s
The patch does not generate ASF License warnings.

79m 29s

Subsystem
Report/Notes

Docker
Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2044/4/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2044

Optional Tests
dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle refguide

uname
Linux 1f30b932d48c 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 9b02a26a1d

refguide
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2044/4/artifact/yetus-general-check/output/branch-site/book.html

refguide
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2044/4/artifact/yetus-general-check/output/patch-site/book.html

Max. process+thread count
122 (vs. ulimit of 12500)

modules
C: hbase-server . U: .

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 13s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
4m  9s
the patch passed

+1 :green_heart:
compile
2m 50s
the patch passed

+1 :green_heart:
javac
2m 50s
the patch passed

+1 :green_heart:
shadedjars
5m 50s
patch has no errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m 44s
hbase-server in the patch failed.

-0 :warning:
javadoc
0m 15s
root in the patch failed.

_ Other Tests _

-1 :x:
unit
182m  4s
root in the patch failed.

218m 24s

Subsystem
Report/Notes

Docker
Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2044/4/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2044

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux da338d2f4f6f 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 9b02a26a1d

Default Java
2020-01-14

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2044/4/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-root.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2044/4/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2044/4/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2044/4/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-root.txt

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2044/4/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-root.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2044/4/testReport/

Max. process+thread count
6387 (vs. ulimit of 12500)

modules
C: hbase-server . U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2044/4/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
4m 54s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 23s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 40s
master passed

+1 :green_heart:
compile
2m 22s
master passed

+1 :green_heart:
shadedjars
5m 34s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
2m 40s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 14s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 28s
the patch passed

+1 :green_heart:
compile
2m 25s
the patch passed

+1 :green_heart:
javac
2m 25s
the patch passed

+1 :green_heart:
shadedjars
5m 37s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
2m 39s
the patch passed

_ Other Tests _

-1 :x:
unit
344m 22s
root in the patch failed.

380m 47s

Subsystem
Report/Notes

Docker
Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2044/4/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2044

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux fd1d6b275dd3 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 9b02a26a1d

Default Java
1.8.0_232

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2044/4/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-root.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2044/4/testReport/

Max. process+thread count
6835 (vs. ulimit of 12500)

modules
C: hbase-server . U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2044/4/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
2m 33s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 20s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 58s
master passed

+1 :green_heart:
checkstyle
2m 16s
master passed

+0 :ok:
refguide
5m 22s
branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.

+1 :green_heart:
spotbugs
11m 45s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 11s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 44s
the patch passed

+1 :green_heart:
checkstyle
2m 18s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+0 :ok:
refguide
5m 34s
patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.

+1 :green_heart:
hadoopcheck
12m 16s
Patch does not cause any errors with Hadoop 3.1.2 3.2.1.

+1 :green_heart:
spotbugs
12m  3s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 25s
The patch does not generate ASF License warnings.

70m 43s

Subsystem
Report/Notes

Docker
Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2044/5/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2044

Optional Tests
dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle refguide

uname
Linux 1461b6aa7bd3 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 9b02a26a1d

refguide
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2044/5/artifact/yetus-general-check/output/branch-site/book.html

refguide
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2044/5/artifact/yetus-general-check/output/patch-site/book.html

Max. process+thread count
122 (vs. ulimit of 12500)

modules
C: hbase-server . U: .

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 13s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
4m 44s
the patch passed

+1 :green_heart:
compile
3m 11s
the patch passed

+1 :green_heart:
javac
3m 11s
the patch passed

+1 :green_heart:
shadedjars
6m 44s
patch has no errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m 48s
hbase-server in the patch failed.

-0 :warning:
javadoc
0m 16s
root in the patch failed.

_ Other Tests _

-1 :x:
unit
263m 53s
root in the patch failed.

299m  5s

Subsystem
Report/Notes

Docker
Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2044/5/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2044

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 69be96bb7a15 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 9b02a26a1d

Default Java
2020-01-14

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2044/5/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2044/5/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-root.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2044/5/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2044/5/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-root.txt

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2044/5/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-root.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2044/5/testReport/

Max. process+thread count
4354 (vs. ulimit of 12500)

modules
C: hbase-server . U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2044/5/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.


Examples\SQL+FillColumns+Pivot\Example2.ps1

https://github.com/dfinke/ImportExcel/blob/master/Examples/SQL%2BFillColumns%2BPivot/Example2.ps1
Get-SQL : The term 'Get-SQL' is not recognized as the name of a cmdlet

That code is bad for a test environment, it said in the supporting explanation that it relied on another module which I wrote, (GetSQL which contains Get-Sql) and it has a hard coded path to a file which won't be valid when testing.


Analyzer crashes compiling deeply nested code

The analyzer crashes when compiling deeply nested expressions or statements.
Tests: language/deep_nesting1_test, language/deep_nesting2_test

Where are these tests located? I just resynced but they're not where I expected to find them (tests/language). If they're not checked in yet, could you attach it here or send it to me via e-mail? Thanks.

The are checked in now. I had to rename them to deep_nesting1_negative_test
and deep_nesting2_negative_test, btw.
On Fri, Jan 22, 2016 at 9:10 AM, Brian Wilkerson<EMAIL_ADDRESS>wrote:

Where are these tests located? I just resynced but they're not where I
expected to find them (tests/language). If they're not checked in yet,
could you attach it here or send it to me via e-mail? Thanks.
—
Reply to this email directly or view it on GitHub
https://github.com/dart-lang/sdk/issues/25558#issuecomment-173980556.

CL to avoid crashing, and reporting a parse error instead.
https://codereview.chromium.org/2823993002


Scrollbar Positioning Incorrect in Firefox when Reopening

In Firefox, the scrollbar inside the select2 component doesn't behave properly when reopening it after having scrolled.

Open the demo site in Firefox.
Open the first select2 control, then scroll inside it all the way to the bottom.
Click outside of the control, closing the control.
Open the control again. The list is reset (you see the top of it), but the scrollbar is positioned at the bottom.

This should be fixed in 4.0.
If it is not fixed, please add a :+1: to the ticket to bring it to our attention. Please also include an example that we can test to verify that it is not actually working.


Repetitive basic instruction in few shot

I believe there is a bug in the code. When I use few-shot, I expect the basic instruction to appear only once at the beginning, not multiple times. Specifically, this part:
The following are multiple choice questions (with answers) about science.
should appear only at the beginning and not before every question. What do you think?

This behaviour is intended for that specific template: https://www.unitxt.ai/en/latest/catalog/catalog.templates.qa.multiple_choice.with_topic.fm_eval.html
It did not define an instruction just and input_format.
This template do work as you expect for example:
https://www.unitxt.ai/en/latest/catalog/catalog.templates.qa.multiple_choice.with_topic.title.html

Thanks for the clarification!


⚠ Bofrost.de has degraded performance

In 590a0a0, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 5755 ms

Resolved: Bofrost.de performance has improved in 809c92a.


Release 0.1.1

### v0.1.1

* Relax constraints on s (allow arrays). #24
* Consolidate input array normalization. #26
* Style adjustment to frequency grid arguments. #27
* Normalize dtype in type tests. #28
* Support 32-bit precision. #29

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.


370-update-github-workflows-for-s3-images

There were several issues with the S3 storage used for staging & production that were solved (non-code), and environmental variables were added to GitHub to pass the storage location to the app and CMS.

Hey @ivanslabbert ! There is some conflicts that need to be resolved.


Waiting for parallel swarm fix

See: https://github.com/libp2p/js-libp2p-swarm/pull/195#issuecomment-289497688

https://github.com/libp2p/js-libp2p-swarm/pull/200 should fix the issues

Closing in favour of https://github.com/ipfs/js-libp2p-ipfs-nodejs/pull/88


Setting 'Item' property

Besides using the 'SelectedItem' property of a gallery control, it would be useful to include in this documentation other mechanisms of defining the Item.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: ff0a7da6-b4ea-bc58-efff-ab3016765dd1
Version Independent ID: 8993631e-75eb-4685-936c-f1c10df6e4dd
Content: Display form and Edit form controls: reference - PowerApps
Content Source: powerapps-docs/maker/canvas-apps/controls/control-form-detail.md
Service: powerapps
GitHub Login: @gregli-msft
Microsoft Alias: gregli

@aneesmsft Do you have any ideas here? Thanks.

@HairyDrumroll You can also set that property to the selected value of a drop-down control (as described in the procedure topic for adding a form) or by using the First and Lookup functions. We expect to add more information soon, but I wanted to let you know that we added a link from this reference topic to that procedure topic. Thanks!
cc @aneesmsft


[BUG] publishing an API fails with code":"ValidationError","message":"Cannot use OAuth2AuthenticationSettings in combination with OAuth2 nor openid. using v6.0.1-rc1

Release version
v6.0.1-rc1
Describe the bug
Publishing an API fails with the error message: code":"ValidationError","message":"Cannot use OAuth2AuthenticationSettings in combination with OAuth2 nor openid.
In the apiInformation.json of the failing API, there are these lines:
    "authenticationSettings": {
      "oAuth2": {
        "authorizationServerId": "oauth2b2b"
      },
      "oAuth2AuthenticationSettings": [
        {
          "authorizationServerId": "oauth2b2b"
        }
      ],
      "openidAuthenticationSettings": []
    },

This is produced by the extractor, with no modification.
In the APIM portal, User authorization setting is set to OAuth 2.0

The API will publish successfully if oAuth2 and openidAuthenticationSettings field is removed, leaving only oAuth2AuthenticationSettings. But since these files are produced by the extractor, these modifications should not be necessary.
Expected behavior
The API to be published successfully.
Actual behavior
API fails to publish
Reproduction Steps

Create an API with User authorization set to OAuth 2, and provide an OAuth 2.0 server
Use the extractor to extract the API
Use the publisher to publish the API the extractor just extracted

We are getting the same issue. @waelkdouh  any fix for this issue ?

Thanks, was able to replicate the issue. Will roll out a fix.

I have three env's, and I'm facing this with only one. I'm not sure if it's related to APIOps or an Azure side issue. my all envs are on same version. Thanks!
ref: https://github.com/Azure/azure-cli/issues/26895

It's an issue with the Azure REST API. Retrieving an API returns both oAuth2 and oAuth2AuthenticationSettings. Information is duplicated in both properties.
Making a PUT request with both properties fails with the error message above. Workaround is to remove one of the two properties.

Hi, I can see some fix is merged in v6-rc2 branch by @guythetechie and I tested this scenario again, I'm no longer facing this issue.

I am still seeing this issue with 'az apim api update' in my yaml pipeline


Update lebron.R

short example to filter a player's shots to a specific game_id to address feature request below
https://github.com/toddwschneider/ballr/issues/6

Thank @mikejacktzen but I'm going to close this since I think it's covered by this PR: https://github.com/toddwschneider/ballr/pull/8, which uses dates instead of game IDs

awesome, thanks for the new addition.


Targeting browser in scss

Ionic version:  (check one with "x")
(For Ionic 1.x issues, please use https://github.com/ionic-team/ionic-v1)
[ ] 2.x
[x] 3.x
[ ] 4.x
I'm submitting a ...  (check one with "x")
[ ] bug report
[x] feature request
It would be great to have a simple css class applied to the application root for when an ionic app is running in the browser.  Maybe "browser".
Currently the application i'm working on is targeting ios, Android, and web and styling the latter two via scss is very easy as i just have to extend from "md" or "ios" in my scss files. However when targeting browser there is no such "browser" class applied to root, so styling for browser is more difficult.
Maybe there is already a way to achieve this via "platform-core" class, but I have heard this is not very dependable.
Thanks in advance!

Hello! Thank you for the feature request. I'm going to move this issue over to our internal list of feature requests for evaluation. We are continually prioritizing all requests that we receive with outstanding issues. We are extremely grateful for your feedback, but it may not always be our next priority. I'll copy the issue back to this repository when we have begun implementation. Thanks!

This issue was moved to ionic-team/ionic-feature-requests#334


fix: unable to determine Swift version

lottie-react-native-tvOS does not specify a Swift version and none of the targets ({project_name}) integrating it have the SWIFT_VERSION attribute set.

Hi,
We checked lottie-ios library and they support minimum swift version 5.6.  I am going to refactor some stuff here in this branch.

Hi,
We checked lottie-ios library and they support minimum swift version 5.6. I am going to refactor some stuff here in this branch.

Swift 5.6 requires the removal of some stuff we have used for 5.7. And needs a bit of refactoring on the code base

This should now be usable under https://github.com/lottie-react-native/lottie-react-native/releases/tag/v6.1.1
Let us know @amochkin


Why can't the picture be cached to disk?

UIImage *image = [UIImage<EMAIL_ADDRESS>[[PINCache sharedCache]setObject:image forKey:@"image_key"];
dispatch_after(dispatch_time(DISPATCH_TIME_NOW, (int64_t)(10 * NSEC_PER_SEC)), dispatch_get_main_queue(), ^{
[[PINCache sharedCache]objectForKey:@"image_key" block:^(PINCache * _Nonnull cache, NSString * _Nonnull key, id  _Nullable object) {
NSLog(@"------>%@",object); //print the null
}];
});
Now when a MemoryWarningNotification event arrive，i can't get the object like the SDWebImage? is that a bug or not supported?

Suggest you use PINRemoteImage, which is designed to drive PINCache for
this use case.
Have you set some breakpoints in PINDiskCache to make sure it is being
created and configured correctly?
On Sun, Jun 17, 2018 at 3:27 AM lizitao<EMAIL_ADDRESS>wrote:

UIImage *image = [UIImage<EMAIL_ADDRESS>[[PINCache sharedCache]setObject:image forKey:@"image_key"];
dispatch_after(dispatch_time(DISPATCH_TIME_NOW, (int64_t)(10 *
NSEC_PER_SEC)), dispatch_get_main_queue(), ^{
[[PINCache sharedCache]objectForKey:@"image_key" block:^(PINCache *
_Nonnull cache, NSString * _Nonnull key, id _Nullable object) {
NSLog(@"------>%@",object); //print the null
}];
});
Now when a MemoryWarningNotification event arrive，i can't get the object
like the SDWebImage? is that a bug or not supported?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/pinterest/PINCache/issues/229, or mute the thread
https://github.com/notifications/unsubscribe-auth/AAigA3p3_0BxQ_mImXFCW4wN18uqoQ8Nks5t9i8pgaJpZM4UqyOc
.

thank u for your reply, I've tried the following way:
UIImage *image = [UIImage<EMAIL_ADDRESS>[[PINDiskCache sharedCache]setObject:image forKey:@"image_disk_key"];
[[PINDiskCache sharedCache]objectForKey:@"image_disk_key" block:^(PINDiskCache * _Nonnull cache, NSString * _Nonnull key, id  _Nullable object, NSURL * _Nonnull fileURL) {
NSLog(@"------>%@",object); //null
}];
and it is always nil. After I debug the problem, I found that the cache files create successfully and read it fail. But I when i try store the "NSData" instead of the "UIImage" like the SDWebImage, It seems to be successful.

@Leon0206 PINDiskCache only supports caching objects which support the NSCoding protocol. UIImage doesn't support this (but you could probably add support).
Hope this helps!

As @appleguy said though, PINRemoteImage will handle this for you and supports local file paths.


ETA on new release?

AFAIK the last release was on April 11th for version 2.4.9
Since then many new things have been merged in.  (I was trying to use CloudflareAI and kept getting errors that it doesn't exist.  it turns out it doesn't in 2.4.9)  Some of those things have even made it into the documentation.
Am I doing this wrong, is there a more recent version than this one somewhere?
https://pypi.org/project/dspy-ai/
Of course, we could do something like
poetry add git+https://github.com/stanfordnlp/dspy.git
but that seems less than ideal for new users just trying it out and following the documentation.

Updated.

Thank you.  This community is amzaing.


About reference points in temporal cross-attention

Hello! I encountered some confusion while reading the code, for example, in the temporal cross-attention part of the future decoder, why are the  future BEV queries  coordinates in historical frames calculated as reference points? The key and value are current bev feature,right?

In case I understand your issue correctly, could you please provide some code parts as reference?

https://github.com/OpenDriveLab/ViDAR/blob/936dbf7e010189b68b83b4b61568cfd0fa23e655/projects/mmdet3d_plugin/bevformer/modules/vidar_decoder.py#L253

Keys and values are all previous bev features.


add test files for log.go and rule.go

What problem does this PR solve?
Add test files for log.go and rule.go. Improve the coverage of server/api. #2287

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Thanks. Please add lisence at the begining of each file.

/rebuild

/merge


Anonymous classes are also autowired

Hi there,
PHP7 introduced anonymous classes and I wanted to play with them, until I found a bug related to DunglasActionBundle (at first I thought the problem came from Symfony DI component)
When using an anonymous class inside an autowired-class, the bundle also tries to autowire the anonymous object, which can lead the autowiring to fail.
Let's assume the following configuration:
# app/config/config.yml
dunglas_action:
    directories:
        - ../src/AppBundle/Services

And the following code:
# src/AppBundle/Services/MyService.php

namespace AppBundle\Services;

use Psr\Log\LoggerAwareTrait;
use Psr\Log\LoggerInterface;
use Webmozart\Assert\Assert;

class MyService {

    use LoggerAwareTrait;

    /**
     * MyService constructor.
     * @param LoggerInterface $logger
     */
    public function __construct(LoggerInterface $logger) {
        $this->logger = $logger;
    }

    public function doSomething() {

        Assert::isInstanceOf($this->logger, LoggerInterface::class); // true, Logger has been autowired at that point

        $generator = function () {
            yield 'hello';
        };
        $dummyAnonymousObject = new class($generator) implements \IteratorAggregate {

            /**
             * @var callable
             */
            private $generator;

            public function __construct(callable $generator) {
                $this->generator = $generator;
            }

            public function getIterator() {
                $generator = $this->generator;
                return $generator();
            }

        };

        foreach ($dummyAnonymousObject AS $message) {
            $this->logger->info($message);
        }

    }
}

You'll get the following exception:
RuntimeException in AutowirePass.php line 114:
Unable to autowire argument index 0 ($generator) for the service "class@anonymousc:\www\dev\bug-di\src\appbundle\services\myservice.php000000128974043d". If this is an object, give it a type-hint. Otherwise, specify this argument's value explicitly.

Since anonymous classes are pretty runtime-specific, shouldn't they be ignored by the autowire pass?
Thanks,
Ben

Indeed, they should be excluded.


CIV-9132 Refactor Solicitor OrgID

Before creating a pull request make sure that:

[x] commit messages are meaningful and follow good commit message guidelines
[x] README and other documentation has been updated / added (if needed)
[x] tests have been updated / new tests has been added (if needed)
[ ] Screenshot attached for the Evidence of manual testing
[ ] Functional, Smoke and API tests have been run locally
[x] Full gradle build and run tests with coverage have been completed (if needed)

Please remove this line and everything above and fill the following sections:
JIRA link (if applicable)
https://tools.hmcts.net/jira/browse/CIV-9132
Change description
OrgID for the respondent solicitor are copied into respondent1OrganisationIDCopy and respondent2OrganisationIDCopy rather than storing it in respondent1OrganisationPolicy and respondent2OrganisationPolicy respectively in Civil Service.
Refactor Respondent Solicitor OrgID to use respondent1OrganisationIDCopy and respondent2OrganisationIDCopy
Testing branch and instruction
Does this PR introduce a breaking change? (check one with "x")
[ ] Yes
[ ] No

RESPONDENT 2


Broken CPE ID when supplier contains -

The following line will result in a broken CPE ID when a supplier contain a - such as d-bus_project or json-c_project:
https://github.com/anthonyharrison/lib4sbom/blob/498355a41d85fc42696e25948f94597a643113ec/lib4sbom/cyclonedx/cyclonedx_generator.py#L212
For example, above line will split d-bus_project as d, bus and project and concatenate it into d bus project.
Then, the piece of code below will replace   to _ resulting in the wrong d_bus_project vendor instead of the correct d-bus_project:
https://github.com/anthonyharrison/lib4sbom/blob/498355a41d85fc42696e25948f94597a643113ec/lib4sbom/cyclonedx/cyclonedx_generator.py#L352
I don't understand what is the goal of this piece of code so I don't know how to "fix" it properly.

Thanks @ffontaine.
Line 212 assumes that product authors are alphabetic and not project names which is why it only allow names such as Fred Smith or F. Smith and not Project123 or Awesome-project-team. Extending the regex to include '-' should hopefully resolve your problem.
Line 352 is removing spaces in supplier names as a space is not allowed in a supplier name for a CPE. However there is no consistency in CPE supplier names as I have seen both A_B and A-B used as the concatenation form so maybe there should be an improvement in which the concatenation character '_' or '-' is chosen depending of whether the character is already present in the name to avoid names such as A-B_C.

Thanks @anthonyharrison, adding - will indeed allow d-bus_project. But perhaps a better solution would be to just delete line 212? It would probably be more future-proof.


UNCONFIRMED: If Drop and Create DBI with same name within 1 transaction, keys will not disappear

Still see Entries: 8893 after successful Drop and Create DBI with same name within 1 transaction.

Checked just now, not confirmed.

ouch. yes, i confused.


Upgrade Java Mail to version 1.6.0

Java Mail 1.6.0 should be binary compatible to 1.5.x according to https://javaee.github.io/javamail/docs/COMPAT.txt
Camel-mail tests pass.

Thanks @PascalSchumacher I'm merging this one.

Thanks for the PR @PascalSchumacher


Fix small problems in docs

Related to https://github.com/simple-login/documentation/issues/47

@nguyenkims check this please;)

@nguyenkims i fixed problems, that you mentioned here https://github.com/simple-login/documentation/pull/48/commits/d32bbc80de9357a75e3538e3314d7ac3f8518fde ;)


New unboxing backend sketch (comments are welcomed)

The diff is rather massive - anyway, please comment just on this file: https://github.com/hkuplg/fcore/pull/129/files#diff-96801f5121d12909d81eec9634934d47L1
I sketched the first initial implementation of the new unboxing backend: it currently only works for a limited language subset (the one in the formalization document - i.e. non-recursive functions, applications and primitive literals and operations).
Adding other cases will hopefully not be too difficult, but before that, please comment on:

other ideas on overall “design” changes in the backend - the new backend is kinda written from scratch, so any ideas how to structure it better than the current one are welcomed.
the type of the return Java expressions. Currently it is Either (J.Name, J.Name) J.Literal, i.e. a tuple of variable names (first one is primitive, the second one is reference) or a literal value. Some cases only produce one variable, in which case I return (varname, error …), because based on the type, the error should never be read - this helped me to debug some cases, but not sure whether this is a good way.
any other comments - the code is a bit messy, so feel free to annotate it with some suggestions, so that I don’t forget to clean it :)

Name-propagation is rather ad-hoc taking it from where Haoyuan left it. It will need a more careful thought how to propagate it through the group lambdas - i.e. change the type of Scopes - please comment with your advices on how to go about it.
Also the name-propagation is only done on the variable names, not the class names - again if you have a suggestion how to go about it, please comment.
(Currently, only the top level closure names are propagated, e.g. (haha : Int) -> (notret : Int) -> haha gets translated to:
    class Fun1 extends f2j.unbox.Closure
    {
      f2j.unbox.Closure haha1 = this;
      public void apply ()
      {
        final long lhaha2 = haha1.larg;
        class Fun3 extends f2j.unbox.Closure
        {
          f2j.unbox.Closure haha3 = this;
          public void apply ()
          {
            final long lhaha4 = haha3.larg;
            lres = lhaha2;
          }
        }
        f2j.unbox.Closure haha3 = new Fun3();
        ores = haha3;
      }
    }
```)

Hi Tomas,
Thanks for this. I had a quick look. Was trying to leave a comment directly on the linked file, but was having some problems. The code is generally looking good, my small remark would be to pull-out all nested case analysis that you do inside the translation function as separate auxiliary definitions. That should make the code shorter and more readable.
Bruno

On 19 Mar 2015, at 00:40, tomtau<EMAIL_ADDRESS>wrote:
I sketched the first initial implementation of the new unboxing backend: it currently only works for a limited language subset (the one in the formalization document - i.e. non-recursive functions, applications and primitive literals and operations).
Adding other cases will hopefully not be too difficult, but before that, please comment on:

other ideas on overall “design” changes in the backend - the new backend is kinda written from scratch, so any ideas how to structure it better than the current one are welcomed.
the type of the return Java expressions. Currently it is Either (J.Name, J.Name) J.Literal, i.e. a tuple of variable names (first one is primitive, the second one is reference) or a literal value. Some cases only produce one variable, in which case I return (varname, error …), because based on the type, the error should never be read - this helped me to debug some cases, but not sure whether this is a good way.
any other comments - the code is a bit messy, so feel free to annotate it with some suggestions, so that I don’t forget to clean it :)

Name-propagation is rather ad-hoc taking it from where Haoyuan left it. It will need a more careful thought how to propagate it through the group lambdas - i.e. change the type of Scopes - please comment with your advices on how to go about it.
Also the name-propagation is only done on the variable names, not the class names - again if you have a suggestion how to go about it, please comment.
(Currently, only the top level closure names are propagated, e.g. (haha : Int) -> (notret : Int) -> haha gets translated to:
class Fun1 extends f2j.unbox.Closure
{
  f2j.unbox.Closure haha1 = this;
  public void apply ()
  {
    final long lhaha2 = haha1.larg;
    class Fun3 extends f2j.unbox.Closure
    {
      f2j.unbox.Closure haha3 = this;
      public void apply ()
      {
        final long lhaha4 = haha3.larg;
        lres = lhaha2;
      }
    }
    f2j.unbox.Closure haha3 = new Fun3();
    ores = haha3;
  }
}

You can view, comment on, or merge this pull request online at:

  https://github.com/hkuplg/fcore/pull/129 <https://github.com/hkuplg/fcore/pull/129>
Commit Summary

Halcyon in Travis
halcyon in Travis update
Update .travis.yml
Update .travis.yml
Update .travis.yml
Update .travis.yml
Update .travis.yml
Update .travis.yml
alex and happy in halcyon
Update .travis.yml
Update .travis.yml
Update .travis.yml
Update .travis.yml
BaseTransCFJava.hs (JMethod): Update error message
Recursively ignore java files in example directory
Fix parse errors caused by syntax change of type arguments
Fix parse error #60
Fix parse error #63
Fix parse error in list directory #59
Rename "test2.sf" -> "Issue_27.sf"
Typo
Allow the list syntax of type params and type args
Rename docs/ to doc/
Fix over-nested directory
Fix broken example
A simple pretty printer
A simple pretty printer (Scala version)
Encoding bounded polymorphism
Add specification stubs
Use curly braces to enclose the body of a module
Clean up parser
Rename `arg` to `param`
Change syntax of type params, lambdas; Remove the `in` keyword
Typo
Merge commit '040ad7f00ce6ec18f0e09ef640d123da15a8c850' into develop
Rename record-related constructors in AST
Refactor parser rules
Merge branch 'develop' of https://github.com/hkuplg/fcore into develop
Sketch Language Cheatsheat
Organize the doc/ directory
Format
Improve instructions on building the compiler
Correct copyright in the absence of IP Assignment Agreement
.sf file names start with upper case letters as in Haskell and Scala
Merge branch 'develop' into feature/syntax-improvements
cp compiler/*.sf examples and format
Fix Mixin.sf
Styles in examples
Clean up
Show line and column number at parse errors
Merge branch 'feature/syntax-improvements' into develop
Fix examples broken by change of syntax
Merge branch 'feature/syntax-improvements' into develop
Convention: String literals for terminals
Call it "type ascription"
Permit an extra comma before "}" in record construction & record types
Allow type declarations to miss the trailing comma
Fix not reversing fields in record update
Update author list
Update cheat sheet
Merge branch 'datatype' into develop
Update for syntax change
Fix typo
Design string interpolation
travis build is passing (despite some test fail)
Weird git issue
Add back Module1.sf
Merge branch 'develop' of https://github.com/hkuplg/fcore into develop
Replace intersperseSpace with hsep
Merge
Add test cases for type synonym shadowing
Put a .gitignore in testsuite/tests
allow constructor to have the same name as datatype.
Merge branch 'develop' of https://github.com/hkuplg/fcore into develop
Declare multiple type parameters for datatype using [A,B...]
Merge branch 'develop' of https://github.com/hkuplg/fcore into develop
Revert "allow constructor to have the same name as datatype."
fix #76
Add test case for epynomous data constructors
Merge remote-tracking branch 'origin/develop' into develop
Merge branch 'develop' of https://github.com/hkuplg/fcore into develop
Merge branch 'develop' of https://github.com/hkuplg/fcore into develop
Put tests in `should_compile`, `should_run`, and `should_fail`
Syntax change
Merge branch 'develop' of https://github.com/hkuplg/fcore into develop
Remove accidentally added files
Merge develop into master
Fix `make test2` (Issue #77)
Fix `make test2` (Issue #77) (reverted from commit db1c82a668fbdce7ebd67ead5243f5e7ca7f5bbf)
Fix `make test2` again (Issue #77)
Whitespace cleanup
(partially fix #70): typeserver return boxed types
Add an adt example in Cheatsheet
Lexer.x: support Java-style escaped characters
Add test cases (now failing) on creating Java objects
Update .travis.yml
Merge pull request #80 from linusyang/escape-fix
Removed no longer used folder
merge
Merge remote-tracking branch 'origin/develop' into develop
bring back list and datatype examples
Merge remote-tracking branch 'origin/develop' into develop
Add tests for associativity of function application
Untracked files?
Update cheatsheet.md
Update cheatsheet.md
Merge branch 'develop' of https://github.com/hkuplg/fcore into develop
Fix for parse errors
Clean up...
Merge branch 'develop' of https://github.com/hkuplg/fcore into develop
Fix #27
Fix parse error v2
Merge branch 'develop' of https://github.com/hkuplg/fcore into develop
Add a test case
travis should only watch develop and master
Merge branch 'develop' of https://github.com/hkuplg/fcore into develop
Update issue reporting URL
Merge branch 'testsuite' of https://github.com/hkuplg/fcore into testsuite
Use a single Cabal file instead using multiple ones
`make test` calls `cabal test`, among others
git mv client.hs Client.hs
Should use `&&` instead of `;` to sequence commands in shell scripts
Fix Makefile
Re-organize the project into a library and executables
git mv lib/* examples
Move source files from compiler/ to lib/
Remove duplicate module-related .sf files in compiler/
git mv lib/Main.hs compiler
Update directory names in Makefile and Cabal file
Duplicate `build-depends` to executables
Remove a prehistoric script for running tests
git rm select-cabal.sh
git mv lib/REPL.hs interpreter
Add `default-language: Haskell2010`
[Fix #83] need different indexes for type variables
Add a test case for #83
Allow duplicate compilation for now otherwise it won't even compile
Format only
Merge branch 'develop' of https://github.com/hkuplg/fcore into develop
Merge branch 'testsuite' into develop
Let Travis also temp. watch the 'testsuite' branch
Add stub of integration of Tasty with Cabal and trying that on Travis
Reviewing .travis.yml
Need to tell Travis the build language is Haskell, not Ruby
That linking error is due to a module missed in `exposed-modules`
Merge branch 'parse' into develop
No need to mention Lexer and Parser in executable sections
Extract the runtime task and make it a dependency for others
Dev/Travis parity
Remove the sample failing test
Merge branch 'testsuite' into develop
Add a dependencies task
Add tasty-golden
Add tasty-golden (reverted from commit 8038ef1cf0db99cfafedca5895f4e5c29ff0f18b)
Merge remote-tracking branch 'origin/testsuite' into develop
Add badge license
Update badge
Merge branch 'develop' into feature/string-interpolation
Add a test for issue #92
Merge remote-tracking branch 'origin/develop' into develop
Add a section about case expr
More datatype tests
[Fix #92] distinguish different type variables when substituting
A temporary solution for Simplify.hs fixing bug 'Segmentation fault'
Typo
Merge remote-tracking branch 'origin/develop' into develop
Fix one testcase parse error
[#36] Seems no need to create an empty closure
Merge branch 'develop'
Workaround for simplifier
add waffle.io badge
add waffle.io badge
add waffle.io badge
Add test case for tuple equality
To avoid confusion, rename `should_fail` to `shouldnt_typecheck`
To avoid confusion, rename `should_fail` to `shouldnt_typecheck`
Update README of testsuite
Merge branch 'develop'
Styles only
consist list examples with syntactic change.
Don't qualify module names in panic messages
document of list
Renaming only
change List<> to List[]
Pretty print code using smart quotes
Merge pull request #100 from waffle-iron/develop
Place Waffle badge under the title
[#99] Proper handle unit type in ClosureF
Merge branch 'develop' of github.com:hkuplg/fcore into develop
Add test case for mapping Java void/Void to Unit
Styles only
Use `compatible` defined by `subtype` instead of `alphaEq`
git rm JavaVoidMapsToUnit.sf
Comments only
Relax the typing of `if`s
Add test case for Issue #98
Pretty-print `MissingTyAscription`
Resolve Issue #98 by expanding type ascription
Finish issue-98
Finish issue-98
Remove files in `compiler` that were merged from master except `Main.hs`
Merge branch 'develop'
Renaming only
Change wording of type mismatch message
Improve error message
Merge branch 'develop'
Add a test case for #103
Group foralls when pretty printing
[Fix #103] Allow '_' to be the name of uninterested variables in pattern matching
Add Issue98.sf
Add test case for #89; fix one test case parse error
Merge branches 'develop' and 'develop' of github.com:hkuplg/fcore into develop
Update syntax of test case
Resolve Issue #98 by always desugaring to SystemFI.LetRec
Merge branch 'develop' of https://github.com/hkuplg/fcore into develop
Finish issue-98
Finish issue-98
Use _ to name uninteresting variables
Merge branch 'develop' of https://github.com/hkuplg/fcore into develop
Makefile in compiler/ has been moved to lib/
pattern match of string.
More test points for underscore
More tests on underscore
[Fix #103 and #107] Support variable names starting with underscore
[Fix #106] `make smt` works again
a better version for string pattern match.
Small fixes
__ is a valid variable name
Merge branch 'develop' of https://github.com/hkuplg/fcore into develop
remove duplicated infer
add syntax
1.

Future changes:
Scope to include Strings
data type for Java return expression
cleaned code and more cases


Consider if a LocalBackstack in a navigator should attempt to find a parent LocalBackstack  and connect itself as a child

See backstack.setParentServices() in Simple-Stack 2.8.0  https://github.com/Zhuinden/simple-stack/issues/239

LocalBackstack is unfortunately not reliable, and ComposeNavigator/rememberBackstack initializer is not set up in a way that I can hijack this parameter.
I feel like this initializer might have been a bit overkill as such. Who knows? Anyway, at least now it's possible to set it at all https://github.com/Zhuinden/simple-stack-compose-integration/issues/32#issuecomment-2545238592


Implement skipped tests in EventsByGeographyQueryHandlerShould

@tonysurma please label with jump-in

picked up.
This is similar to #1438
The problem was an extension method that can't be mocked in the test. I decided to wrap the extension method call.

@peerhenry cc @tonysurma there should be no unit test for this.  Check my comments on PR #1542 for clarification.


Add editable basic info card

Create a card for basic profile information (name, email, and image), and allow those fields to be edited.

Partially implements #2

Addressed by #10


implement a way to use training images of any set size

this sounds like a lot of effort to do, but maybe at somepoint i will implement this... or maybe someone else can. i would prefer the latter cause im kinda lazy. easier to merge a PR than actually make it

also i havent touched NNs in so long i barely remember how tf a convolutional layer works (or rly just pytorch in general) lol. so that also might hinder the implementation of this (assuming i am the one to implement this; which is a pretty realistic assumption)


README: Add initial usage instructions

Signed-off-by: Orel Misan<EMAIL_ADDRESS>

Change: Removed $ sign from shell input examples.

Change: Answered code-review comments.

Change: Added cleanup instruction after the checkup execution had finished.

Change: Answered code review comments.
Added input / output fields sub-titles.

Change: Answered code review comment.

Change: Rebase
Answered review comments.

Change: Squashed the two commits into one.


As an account manager, I'd like to communicate the potential cost savings that cg could bring to potential users

Can we publish accounts from Adrian Webb + Jay Huie about how by transitioning clients to cloud.gov, they're hoping to save them from significant costs?

@nikzei same question here as https://github.com/18F/cg-product/issues/256 – do we expect to plan/groom this item for our squad to pick up as part of the Liberator stream?

@suprenant as with #256, I'm removing the Liberator tag so that this is a Skyporter issue. If we need Liberator assistance, we'll reach out then.

To talk about how cg could save customers money, we should be prepared to talk about the expense of going through the FedRAMP process. @mogul - I here that we haven't been formally tracking this, but can we quickly brainstorm about ways for us to make a guestimate about this cost?

For FedRAMP costs, you could refer to the two FedRAMP blog posts on this: One and two.
However, that may not be relevant for a CIO/CISO, because generally they are not granting ATO to their own applications for FedRAMP purposes. They might compare with leveraging their existing on-premise data center, where the sunk costs for infrastructure are already there and they're only looking at the specific application under consideration.
That more closely approaches what we're after: "You're trying to close your data center and/or obey the OMB cloud-first mandate... What will it take for you to get your app hosted in the cloud and fully-compliant, vs what it looks like if you use FedRAMP-authorized cloud.gov?"

(In other words, few things they deploy on cloud.gov will themselves be made available as FedRAMP services to others, so talking about FedRAMP costs isn't very relevant.)

That's interesting and really helpful @mogul. I'd still love to talk with you more about this to make sure that I am clear. There are other more immediate needs for now but still an interesting talking point for us to craft!

Sure, set up a time on the calendar!
On Mon, Oct 3, 2016 at 6:23 PM, Nikki Zeichner<EMAIL_ADDRESS>wrote:

That's interesting and really helpful @mogul https://github.com/mogul.
I'd still love to talk with you more about this to make sure that I am
clear. There are other more immediate needs for now but still an
interesting talking point for us to craft!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/18F/cg-product/issues/258#issuecomment-251272381, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAC6krx4KHrUeFuIqvzc4udIcg38a5Epks5qwaqlgaJpZM4Jv7le
.


598DLH: GPM Dataset contribution

Bonus points for Mayank Sharma, Team 155, of CS 598 DLH.
Adding the Global Proteomics Machine DB to available datasets.

Tested, it works well while I change the default dataset save path to pyhealth default cache path. Thanks @mayank-sharma-16 .
"""
from pyhealth.datasets.utils import MODULE_CACHE_PATH
"""


Update min_stack.cpp

Made solution simpler and easier to understand by making minStk a stack of int instead of stack<pair<int,int>>. Passes all test cases on leetcode.

Sorry for the delay, @hanlinm2! Closing this as stale as the C++ files have moved.


Objective-C compatibility

Is your feature request related to a problem? Please describe.
How is the compatibility with objective-c code?
Describe the solution you'd like
To see how to use the library with objective
Describe alternatives you've considered
none so far
Additional context
I have a mixed objc-swift project (that we are migrating slowly and painfully) and I would like to use this awesome library

Thanks, @josecostamartins for opening the issue. Honestly, I haven't yet tried integrating SwiftEntryKit intro an existing Objective C project, and I think that's a good requirement.
I'll look into it in the upcoming week to see if I can find an out-of-the-box solution to this.

Hi @josecostamartins!
Sorry it took some time, but I investigated it a bit and my conclusions are:

SwiftEntryKit doesn't and won't support Objective-C by design since most of the APIs provided by SwiftEntryKit use Swift exclusive types.
SwiftEntryKit can be integrated pretty easily into an ObjC.
I created this example project that demonstrates how to do it in a straightforward manner.

Please let me know your thoughts.

For anyone who stumbles upon this issue as well. Please reference Swift and Objective-C Interoperability.

Thank you very much for your time and knowledge


This PR set supports of PVPANIC_CRASHLOADED in the pvpanic driver

This patch set supports PVPANIC_CRASHLOADED in the pvpanic driver, and it contains 3 patches.
The 1/3 patch unifies the code style.
The 2/3 patch requires the patch posted for QEMU -<EMAIL_ADDRESS>In Patch 3/3, when the crash dump is enabled in Windows guest, PVPANIC_CRASHLOADED will be triggered before the crash dump. It indicates a crash dump file will be generated in the guest. Otherwise, PVPANIC_PANICKED will be emitted. This means the guest crashes without a crash dump file created.

HI @annie-li,
Is there some more documentation other than<EMAIL_ADDRESS> I want to understand what should be the right behavior after the driver notifies that OS is in the process of saving the crash. Should it still notify the guest crash at the end of the process (marking the place where it will be safe to kill the guest VM process)?
Best regards,
Yan.

Hi Yan,
The document of pvpanic in QEMU side is following,
https://github.com/qemu/qemu/blob/master/docs/specs/pvpanic.txt
The related patch of supporting PVPANIC_CRASHLOADED in QEMU is here,
https://github.com/qemu/qemu/commit/7dc58deea79a343ac3adc5cadb97215086054c86
PVPANIC_CRASHLOADED event is sent out before the crash dump. It notifies user that a crash dump file is generated, and the guest keeps running to dump the memory. After crash dump is done, the Windows guest will reboot automatically if the "Automatically restart" is configured in Windows guest. No event is sent after the crash dump is done. See function qemu_system_guest_crashloaded that gets called in QEMU after PVPANIC_CRASHLOADED is triggered.
https://github.com/qemu/qemu/blob/master/softmmu/vl.c#L1465
PVPANIC_PANICKED event only notifies user that the guest crashes. With no-shutdown option, the guest stays in "STOP" state. Without no-shutdown option, the guest will be shutdown. See function qemu_system_guest_panicked that gets calls in QEMU after PVPANIC_PANICKED  is triggered.
https://github.com/qemu/qemu/blob/master/softmmu/vl.c#L1428
Thanks
Annie

Hi Annie,
Thank you for the information.
Best regards,
Yan.

@annie-li Hi Annie, I have a question about the PR and the driver behavior.
if ((features & (PVPANIC_PANICKED | PVPANIC_CRASHLOADED))
                       == (PVPANIC_PANICKED | PVPANIC_CRASHLOADED))
    {
        bSupportCrashLoaded = TRUE;
        TraceEvents(TRACE_LEVEL_INFORMATION, DBG_POWER,
            "PVPANIC_PANICKED and PVPANIC_CRASHLOADED notification features are supported.");
    }
    else if ((features & PVPANIC_PANICKED) == PVPANIC_PANICKED)
    {
        TraceEvents(TRACE_LEVEL_INFORMATION, DBG_POWER,
            "PVPANIC_PANICKED notification feature is supported.");
    }

Why bSupportCrashLoaded is enabled only if both flags are set?
QEMU  command line enables the selection of only one of the events. And if PVPANIC_CRASHLOADED selected alone, the driver will not notify it.
Best regards,
Yan.

@YanVugenfirer Hi Yan, By default, PVPANIC_PANICKED is supported in QEMU. PVPANIC_CRASHLOADED is the feature supported in later version of QEMU. 'bSupportCrashLoaded' represents PVPANIC_CRASHLOADED is supported besides the original PVPANIC_PANICKED feature.
Theses features can be read from the IO port. See the code in hw/misc/pvpanic.c of older QEMU version, pvpanic_ioport_read only return PVPANIC_PANICKED. In newer version of QEMU, PVPANIC_PANICKED | PVPANIC_CRASHLOADED is returned. The above code in Windows pvpanic driver is meant to check if these features are supported in QEMU itself. Related patch is<EMAIL_ADDRESS>the final patch in upstream is<EMAIL_ADDRESS>With QEMU only supporting PVPANIC_PANICKED, Windows pvpanic driver only triggers the PVPANIC_PANICKED event. With QEMU supporting both PVPANIC_PANICKED and PVPANIC_CRASHLOADED, Windows pvpanic driver triggers PVPANIC_CRASHLOADED when crashdump file is being generated, otherwise, PVPANIC_PANICKED event is triggered.
In QEMU command line, the option of enabling pvpanic is '-device pvpanic'. What is the option that you mentioned "QEMU command line enables the selection of only one of the events"?
Thanks
Annie

@annie-li  Hi Annie,

What is the option that you mentioned "QEMU command line enables the selection of only one of the events"?

You can use the "events" command-line option to set a specific feature. The default is "3" (PVPANIC_PANICKED  and PVPANIC_CRASHLOADED are set).
-device pvpanic, events=2 - is a valid option from the QEMU point of view today.
So either the driver is such case should trigger PVPANIC_CRASHLOADED or QEMU should not allow such option.
Best regards,
Yan.

Hi Annie, Yan,
When I described the behavior of the QEMU patches to Annie, I missed the fact that the events property of the device could be used to specify a "non-default" value for the capabilities.
I believe the reason that Paolo added the events property to the original patch I submitted was to be able to restrict it to new machines types (he never replied to my question in<EMAIL_ADDRESS>But as Yan points out, the ability to specify a event mask with only PVPANIC_CRASHLOADED is available, even though it might not have many use cases.

I see. 'event = 2' scenario is missed. I'll fix it.
Current driver covers scenario of 'event = 1' and 'event = 3'. From debug point of view, user may not intend to only choose 'event = 2' since the event is only triggered when crashdump file is generated. But it is better to deal with this scenario just in case.

@aljimenezb Hi Alejandro,
Thank you for the clarification.


Fix chunk overflow appending samples at a variable rate

When appending samples at a slow rate, and then appending at a higher rate, the prediction we made to cut a new chunk is no longer valid. Sometimes this can even cause an overflow in the chunk, if more samples than uint16 can hold are appended.
Thanks @bboreham and @pracucci for pointing to the issue.

Not sure why test_ui is failing, can't re-run it.

Not sure why test_ui is failing, can't re-run it.

IIRC I had the same problem before when contributing to Prometheus, I think the test is unstable.


use collected.getDroppedItem() in playerCollect and dont use removed func findItemOrBlockById

LGTM

Looks good to me

merge this when


Create template helper library

Create a library with a collection of helper methods to generate forms in html templates.

this feature can be a separate library or a part of the infrastructure module on a project.

Added form helper as part of the infra module


Consider full height detail

@Ptrhnk I think this is already implemented - an extension over the statements list upon click. I like it. If this was all that the issue is about, feel free to close.


[PTRun][System] Sort NetworkInterfaces by IPv4, then IPv6

Summary of the Pull Request
Updated NetworkInterfaces to first sort by IPv4, then IPv6 to match the logic from the DelayedQuery test.

PR Checklist

[ ] Closes: #xxx
[ ] Communication: I've discussed this with core contributors already. If work hasn't been agreed, this work might be rejected
[ ] Tests: Added/updated and all pass
[ ] Localization: All end user facing strings can be localized
[ ] Dev docs: Added/updated
[ ] New binaries: Added on the required places

[ ] JSON for signing for new binaries
[ ] WXS for installer for new binaries and localization folder
[ ] YML for CI pipeline for new test projects
[ ] YML for signed pipeline

[ ] Documentation updated: If checked, please file a pull request on our docs repo and link it here: #xxx

Detailed Description of the Pull Request / Additional comments
On devices with multiple NICs / those connected primarily to WiFi, the DelayedQuery test fails, as it expects to find ipv4 interfaces first. On some of my devices, mainly Windows Dev Kit 2023, the MAC addresses return first and somehow matches. This PR sorts the resolves of the network interfaces list to match the logic of the test.

Validation Steps Performed
After sorting the Network Interfaces, the tests properly succeed.

@snickler
This could be a solution. But the cause is that typedString only contaibs address and that matche all result types: IPv4 address, IPv6 address, Mac address. I think the best solution would be to have a better typedString


Not arming at all

Can You please explain - what is pre-requisites to arm area?
Have created area, added sensor into, configured some actions, but...

^^ nothin happens pressing ARM buttons - state still Disarmed.

There are probably some sensors active which block the arming.
Only motion (and door sensors for arm away) may be active prior to arming.
Windows / tamper / environmental sensors should be off.
I recommend to configure a notification for the "failed to arm" event, such that Alarmo tells you what's wrong.
Otherwise it is printed in the HA log (if you have "info" logging enabled)

Only one environmental sensor attached - see issue #150.
Logging enabled by
logger:
default: info
Notification on 'failed to arm' created.
!!! Arming/disarming works ONLY on out-of-the-box created Area !!!
But NOT working on my manually created Area: pressing ARM % in panel - happens nothing, no logs, no notification.

Actually this is IMHO bug/feature of Alarm panel in Lovelace.
ARM buttons enabled for Modes, which is DISABLED for particular Area.
Mode disabled, Button enabled - arming not happens.

I agree with you. I already reported a bug for this to the HA team months ago.
I'm planning to create an "alarmo card" which is a bit more intelligent for these matters.


'ceph-salt' should require the correct 'ceph-salt-formula' version

We already have Requires: ceph-salt-formula on ceph-salt.spec, but ideally we should have:
Requires:       ceph-salt-formula = <ceph_salt_version>

@smithfarm do you know if this is possible to implement?

Yeah, with something similar to
https://github.com/ceph/ceph/blob/cc16516fd851ee9b8175fee18435a9b8b507bf77/ceph.spec.in#L356


Supply an app context in storybook plugin test

Unbreaks the Plugin storybook views.

Tugboat has finished building the preview for this pull request!
Link:

https://pr4678-qp6jlw88ruhuodbl0oxcqdawxskzish0.tugboat.qa

Dashboard:

https://dashboard.tugboat.qa/60364a10f285af60af96e895

Tugboat has finished building the preview for this pull request!
Link:

https://pr4678-qp6jlw88ruhuodbl0oxcqdawxskzish0.tugboat.qa

Dashboard:

https://dashboard.tugboat.qa/60364a10f285af60af96e895


After VSC restart I get notification

Hello,
I'm using latest stable VSC. Every time I get this notification even if I press "Activate".

This was reported yesterday  in VSCode Insiders version and fixed in #1098. A patch will be released soon.
The thing is that this is the first time reported in VSCode (not insiders). Can you confirm the version number? 1.14.2?

Yes, it's 1.14.2.

@robertohuertasm The issue is generic no matter the vscode version.

Same issue for me on 1.14.2

This has been fixed in #1098 and will be released in 7.12.0


CosmosClient singleton is added in Startup but not used in the Function

In the code example, a CosmosClient singleton is added in Startup. However, the CosmosClient is not used in the Function.
How do I access the CosmosClient  from the function?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 5786402e-9d88-5de0-607a-1c2a143af006
Version Independent ID: 15368d1c-b22e-7eb2-413f-cc0d41d2b909
Content: Use dependency injection in .NET Azure Functions
Content Source: articles/azure-functions/functions-dotnet-dependency-injection.md
Service: azure-functions
GitHub Login: @craigshoemaker
Microsoft Alias: cshoe

Hi @mfalkvidd Thanks for reaching out. We will review and update this as appropriate.

@mfalkvidd You can inject the CosmosClient directly.
There's an example of this in the Cosmos client samples directory which includes the following code:
private CosmosClient cosmosClient;
public AzureFunctionsCosmosClient(CosmosClient cosmosClient)
{
this.cosmosClient = cosmosClient;
}

Thanks @DixitArora-MSFT
Sorry for being unclear.
I'm not actually interested in using the Cosmos client. I just expected the documentation on how to use dependency injection to actually use the dependencies that are injected.
Imho, the documentation could be made clearer by either of:
a) Remove everything that mentions Cosmos, since the cosmos service isn't used
b) Add the CosmosClient to the HttpTrigger constructor and use the cosmos client from the GetPosts function.

@mfalkvidd I have created the PR for this which will address this. Thanks so much for providing the feedback that help us in improving the documentation. For now I will proceed with closure of this and If there are further questions regarding this matter, please tag me in your reply. We will gladly continue the discussion and we will reopen the issue.

@DixitArora-MSFT could you add a reference to the PR here (or reference this issue from the PR)?

@mfalkvidd, @DixitArora-MSFT Just a heads-up that I have a draft of this article currently in review by the Product Team that removes the Cosmos DB references as well as many other updates. Once we finish the final review the new version will go live soon after.


Alert rules

We will need to be able to doc how to provide custom alert rules in a way that user friendly and extensible.
This component should optionally provide useful Deis alerts out of the box - but also provide instructions for rolling ones owns and adding them.

Initially this can be as simple as a manual workflow to include alternative rules that works without too much pain. The long term goal here might be to improve the alerting mechanism itself to play nicer within k8s setups - eg, less just baked in alert files, more friendly to programmatic config.


Importing in TypeScript

What is the proper way to import the module in typescript?
The definition file suggests that it's a default export, however, TypeScript interprets that as having module.default, which this module does not in fact have. With the current definition file, the only way to get typed and working function is this:
import * as fileDownload_ from 'js-file-download';
const fileDownload = fileDownload_ as any as typeof fileDownload_.default;

Using default import returns undefined.
import fileDownload from 'js-file-download';
fileDownload === undefined // true

#67

I use it like this: import fileDownloader from 'js-file-download';
Maybe there is a problem with your configuration

Let's compare tsconfig.json for now:
{
    "compilerOptions": {
        /* Basic Options */
        "target": "es3", /* Specify ECMAScript target version: 'ES3' (default), 'ES5', 'ES2015', 'ES2016', 'ES2017', or 'ESNEXT'. */
        "module": "commonjs", /* Specify module code generation: 'none', commonjs', 'amd', 'system', 'umd', 'es2015', or 'ESNext'. */
}

@rsxdalv , here's a tsconfig.json that I'm using in a simple "Hello World" test app.
{
  "compilerOptions": {
    "strict": true,
    "module": "commonjs",
    "jsx": "preserve",
    "esModuleInterop": true,
    "sourceMap": true,
    "allowJs": true,
    "lib": [
      "es6",
      "dom"
    ],
    "rootDir": "src",
    "moduleResolution": "node"
  }
}

index.ts:
import fileDownload from "js-file-download";

document.getElementById("downloadButton")!.onclick = () => {
  fileDownload("Hello World!", "hello_world.txt");
};

Thank you, it seems that --esModuleInterop is the change, my tsconfig file was so old it didn't even have it.
I'll test it and close this if enabling this setting causes no problems.

Seems to be the way to go, since all of my newly generated tsconfigs include it by default.


Add completion for ack2

ack2 is a tool like grep, optimized for programmers. http://beyondgrep.com

:+1:


separate shuffle io connect timeout and idle timeout

What changes were proposed in this pull request?

When reading shuffle data, some fetch request may go to some shuffle server that go unstable/wrong and now the connection timeout to the shuffle server is controlled by spark.shuffle.io.connectionTimeout. Normally the connect time is just several ms in an internal cluster, in order to fail fast, we hope to shorten the time to around 10s.
But this timeout also controls the connection idle timeout (https://github.com/apache/spark/pull/27963), that means if the connection seems idle for this time period, the connection will be killed even there is on-going request on it. For some big job with large chunks, the timeout could not be that small.
I think these 2 timeout should be separated since they are for different purpose and their timeout maybe dramatically different.
Why are the changes needed?

To save time for some cases.
Does this PR introduce any user-facing change?

Yes, we have one more parameter that user may need to be aware of.
How was this patch tested?

Existing UTs.

Can one of the admins verify this patch?

Can one of the admins verify this patch?

cc @rxin @aarondav  who worked on #5584 before

cc @cloud-fan , would you please help check also?

Please take a look at https://spark.apache.org/contributing.html. For example, file a JIRA, fix the PR title, etc.

Please take a look at https://spark.apache.org/contributing.html. For example, file a JIRA, fix the PR title, etc.

Thanks. already fire a jira and added in the ticket.

Can one of the admins verify this patch?

Can one of the admins verify this patch?


Prefixed event names with 'OneSignal'

This PR will fix #240, it's just a prefix on all OneSignal app events to avoid conflicts :)
In this way this library can coexist with others such as react-native-push-notification.

cc @avishayil

Thank you!

it isn't available yet on npm. To take effects this change I had to do npm install --save geektimecoil/react-native-onesignal


SPARKC-220: Changed default query timeout from 12 seconds to 2 minutes

Build against Scala 2.10 finished with failure

Build against Scala 2.11 finished with failure

Build against Scala 2.10 finished with failure

Build against Scala 2.11 finished with failure


Fix Grafana dashboard

Fixed variable injection into targets
Fixed funtion arguments for the gpu label templating

Sorry @glowkey I didn't know I had to sign the commit. Could you please approve it again? Thanks