Spinner is inaccessible by default

The Spinner component is, at first glance, a convenient way to render a loading state:
<Box>
  {isLoading ? <Spinner /> : content}
</Box>

This appears straightforward, but in reality this is a bad idea because it's completely inaccessible. Spinner has no label by default, so the box will simply appear empty to screen readers.
The US Government CMS design system renders Spinner as a status with hidden "Loading" text. I think we probably should do the same by default, rendering it like so (hiding the SVG to avoid duplication):
<Box role="status">
  <VisuallyHidden>Loading</VisuallyHidden>
  <SpinnerSvg aria-hidden />
</Box>

This would make the accessible path much easier to follow.

Thanks for the suggestion, this does seem like a nice improvement to me as the current Spinner doesn't appear to have any label at all!
@TylerJDev do you concur?

One alternative might be to label the SVG properly, however I'm not sure that's the best approach in this case because the spinner being an image is not useful context. image labelled "Loading" makes less sense than just "Loading".
One concern I do have with this approach is that while it announces a loading state, it doesn't announce loading completion. Unmounting the Spinner removes the status from the UI, which results in no announcement. I'm not sure if this is a big deal -- do we need to announce loading completion? One approach could be to do useEffect(() => () => announce("Loading completed"), []) where announce causes an aria-live announcement.

Definitely agree. The <Spinner> component as it is now could be improved for accessibility.

The US Government CMS design system renders Spinner as a status with hidden "Loading" text.

I like this pattern! If we did utilize a live region, using plaintext is probably the way to go. Any <Spinner> usage that exists now that uses some sort of text alternative (e.g.  aria-label) for the component would need to be adjusted so that it uses the new pattern instead. If the current <Spinner> is hidden (i.e. aria-hidden), then we might want to respect that with this pattern, as this might suggest that there's an alternative text-based loading indication to supplement the visual.
The only thing I'm slightly wary about is providing the live region by default. Sometimes loading indicators aren't needed if they are quick (e.g. < 2 seconds). Although, this is something we could probably handle internally within the component. We may also want to make sure that the role can be adjusted.
The other concern is that we might need to check any existing usage where there might be multiple <Spinner> components on a page at the same time and if this is a common occurrence, but only if we did go the route of providing a live region within the component by default.

One concern I do have with this status approach is that while it announces a loading state, it doesn't announce loading completion.

This is a great point. I'm wondering if this should be the responsibility of this component though? We definitely could add something here, but I think this may be mainly on the developer, or a different type of component entirely.

@iansan5653 as an Accessibility Champion, do you have any interest in contributing this improvement?
If not, Primer will move this in the backlog and aim to prioritize it when we pick up Spinner for accessibility remediation. For now, we're focused first on components that have the most usage within strategic services as per https://github.com/github/primer/issues/1973.

@lesliecdubs I might be able to in a few weeks. I don't want to commit to that but if I can, I'll pick it up.

Thanks for the feedback @TylerJDev - sorry I missed it. I just scheduled an a11y office hours session to discuss further: https://github.com/github/accessibility/issues/5454

@TylerJDev - during office hours I was told we're working on resolving the issues with aria live regions: https://github.com/github/accessibility/issues/4887

I mentioned this in a thread in Slack that pointed towards this issue ... it may have already been discussed/noted, but just just in case: simply adding a status role may not work consistently though - as with all live regions, in general (barring a few idiosyncracies/heuristics in certain browser/screen reader combinations), live regions need to first be primed (present in the markup), and only as a second step can be populated with content that will then be "seen" by screen readers as a change and announced. Generating a fully-populated live region container does not consistently result in its content being announced.


feat(pkg/objstore/s3): support for prefixes

[] CHANGELOG Support for s3 prefixes

Changes
I added support for s3 prefixes based on the amazing work proposed by #1318
Verification
Tested configuration changes via unit test, tested integration wise by running it.

Going to fix the docs related stuff... as soon as I figure out how that works

Ready to go :tada:

@edevouge feel free to nullify this PR with your work, I needed to implement this for my own use cases, and I would much rather you get credit than I.

So, it looks good, but why are we limiting ourselves to S3 implementation? If we are getting into this, I think it might be a part of our interface instead. E.g Adding Prefix to https://github.com/thanos-io/thanos/blob/2c5f2cde11f5cd100f147ad2e5d4dbeccbd604c5/pkg/objstore/client/factory.go#L32
This will be then consistent across all object storages.

@edevouge feel free to nullify this PR with your work, I needed to implement this for my own use cases, and I would much rather you get credit than I.

@jaredallard : I appreciate your contribution, but it would be great the next time you decided to implement a design proposal to post a small comment on the issue thread to explain your intention. Because, I was also writing some code for this feature and it's not really efficient to do the job twice. I'll let you finish the job.

So, it looks good, but why are we limiting ourselves to S3 implementation? If we are getting into this, I think it might be a part of our interface instead. E.g Adding Prefix to
https://github.com/thanos-io/thanos/blob/2c5f2cde11f5cd100f147ad2e5d4dbeccbd604c5/pkg/objstore/client/factory.go#L32
This will be then consistent across all object storages.

Good point, I'll rework this.

hi folks, is this waiting for the equivalent implementation on the other object stores for merging?
would like to see prefix supported for s3 soon

This looks like a good feature, do you think it will re-open?

Well it really depends on @jaredallard if he is willing to continue this change.
I believe to merge it we need to do it per global object storage config, not just S3, so all providers can reuse this prefix logic (: We can also discuss if it should be Prefix or Prefixes potentially on issue: https://github.com/thanos-io/thanos/issues/1318
Help wanted, we definitely would like to have this in!

Hey, I'm likely to not drive this work to completion. I am no longer on the team that needed this change at my company (they have maintained a fork with this AFAIK). I may come and do it in my spare time, but I have a massive backlog of things to do outside of work and this is pretty low on that list for that reason 😓
Sorry everyone!

This is totally ok (: No worries, and good luck!
It's best if you are transparent about the priorities, so someone else can take your work. :+1 Thanks!
so... let's keep it close and help wanted (:


tic tac toe game made using swing framework.

Issue: In this example, we are going to see the example of tic tac toe game (also known as 0 and x (cross)).
It can be developed only through AWT api, but we are using here swing framework.

Looks good to me! Accepted the PR for Hacktoberfest.


Files not edited when reading Excel files

When reading the excel file, the file that has not been edited will be reported as vm5053:14 uncaught unrecognized tag: null|workbook, false|worksheet, false|table, false

Please share a sample file

75e2052ea253413a971f4e6ae38a4c7d.xls

If this file has not been edited, it will report an error. After editing, it will not report an error

There's a literal <ss:Null/> which does not appear in the XML2003 reference schemas.  Since Excel accepts the file, we'll accept a patch.   Period.


libwebp: 1.0.0 -> 1.0.1

Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/libwebp/versions.
meta.description for libwebp is: '"Tools and library for the WebP image format"'.

Checks done (click to expand)

built on NixOS
/nix/store/rdw7zx8x7a2rka97kgnh4sbrzr92pih4-libwebp-1.0.1/bin/dwebp passed the binary check.
/nix/store/rdw7zx8x7a2rka97kgnh4sbrzr92pih4-libwebp-1.0.1/bin/cwebp passed the binary check.
/nix/store/rdw7zx8x7a2rka97kgnh4sbrzr92pih4-libwebp-1.0.1/bin/gif2webp passed the binary check.
/nix/store/rdw7zx8x7a2rka97kgnh4sbrzr92pih4-libwebp-1.0.1/bin/img2webp passed the binary check.
/nix/store/rdw7zx8x7a2rka97kgnh4sbrzr92pih4-libwebp-1.0.1/bin/webpmux passed the binary check.
/nix/store/rdw7zx8x7a2rka97kgnh4sbrzr92pih4-libwebp-1.0.1/bin/webpinfo passed the binary check.
6 of 6 passed binary check by having a zero exit code.
0 of 6 passed binary check by having the new version present in output.
found 1.0.1 with grep in /nix/store/rdw7zx8x7a2rka97kgnh4sbrzr92pih4-libwebp-1.0.1
directory tree listing: https://gist.github.com/24d07facc71832a101e922f648faf1e3
du listing: https://gist.github.com/239c471745392de46cdb53d0e5cd6c07

Rebuild report (click to expand)

10681 total rebuild path(s)
3800 package rebuild(s)
3556 x86_64-linux rebuild(s)
3185 i686-linux rebuild(s)
599 x86_64-darwin rebuild(s)
3341 aarch64-linux rebuild(s)
First fifty rebuilds by attrpath
AgdaSheaves
AgdaStdlib
DisnixWebService
EmptyEpsilon
R
SDL
SDL2
SDL2_gfx
SDL2_image
SDL2_mixer
SDL2_net
SDL2_ttf
SDL_gfx
SDL_image
SDL_mixer
SDL_net
SDL_sound
SDL_stretch
SDL_ttf
TotalParserCombinators
_20kly
_90secondportraits
aacskeys
abcde
abcl
abiword
acoustidFingerprinter
actdiag
adapta-gtk-theme
adms
adom
adoptopenjdk-bin
adoptopenjdk-hotspot-bin-11
adoptopenjdk-jre-bin
adoptopenjdk-jre-hotspot-bin-11
adoptopenjdk-jre-openj9-bin-11
adoptopenjdk-openj9-bin-11
adwaita-qt
aegisub
aesop
afew
agdaBase
agdaIowaStdlib
agdaPrelude
agg
ahoviewer
airstrike
airtame
akonadi
akregator

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/rdw7zx8x7a2rka97kgnh4sbrzr92pih4-libwebp-1.0.1 \
  --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
  --option trusted-public-keys '
  r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(r-ryantm's Cachix cache is only trusted for this store-path realization.)
Or, build yourself:
nix-build -A libwebp https://github.com/r-ryantm/nixpkgs/archive/1b93d160366a208f8395d58a549ee33847cc3ab6.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/rdw7zx8x7a2rka97kgnh4sbrzr92pih4-libwebp-1.0.1
ls -la /nix/store/rdw7zx8x7a2rka97kgnh4sbrzr92pih4-libwebp-1.0.1/bin

cc @codyopel for testing.

Success on x86_64-linux (full log)
Attempted: libwebp
Partial log (click to expand)
shrinking /nix/store/7a8nz28x105hri3kvc5z9kxk0hqm3spj-libwebp-1.0.1/bin/cwebp
shrinking /nix/store/7a8nz28x105hri3kvc5z9kxk0hqm3spj-libwebp-1.0.1/bin/webpinfo
shrinking /nix/store/7a8nz28x105hri3kvc5z9kxk0hqm3spj-libwebp-1.0.1/bin/webpmux
shrinking /nix/store/7a8nz28x105hri3kvc5z9kxk0hqm3spj-libwebp-1.0.1/bin/img2webp
shrinking /nix/store/7a8nz28x105hri3kvc5z9kxk0hqm3spj-libwebp-1.0.1/bin/gif2webp
gzipping man pages under /nix/store/7a8nz28x105hri3kvc5z9kxk0hqm3spj-libwebp-1.0.1/share/man/
strip is /nix/store/j13c9z0z495wxdc97if8z451x53m1j25-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/7a8nz28x105hri3kvc5z9kxk0hqm3spj-libwebp-1.0.1/lib  /nix/store/7a8nz28x105hri3kvc5z9kxk0hqm3spj-libwebp-1.0.1/bin
patching script interpreter paths in /nix/store/7a8nz28x105hri3kvc5z9kxk0hqm3spj-libwebp-1.0.1
checking for references to /build/ in /nix/store/7a8nz28x105hri3kvc5z9kxk0hqm3spj-libwebp-1.0.1...

Success on aarch64-linux (full log)
Attempted: libwebp
Partial log (click to expand)
shrinking /nix/store/n0i72migbqvmr69c5zy5zh8nmp8xadjz-libwebp-1.0.1/lib/libwebpdemux.so.2.0.5
shrinking /nix/store/n0i72migbqvmr69c5zy5zh8nmp8xadjz-libwebp-1.0.1/lib/libwebpmux.so.3.0.3
shrinking /nix/store/n0i72migbqvmr69c5zy5zh8nmp8xadjz-libwebp-1.0.1/lib/libwebpdecoder.so.3.0.3
shrinking /nix/store/n0i72migbqvmr69c5zy5zh8nmp8xadjz-libwebp-1.0.1/lib/libwebp.so.7.0.3
gzipping man pages under /nix/store/n0i72migbqvmr69c5zy5zh8nmp8xadjz-libwebp-1.0.1/share/man/
strip is /nix/store/1jprj383qnzd50vn8qq3a0id6a08a9fi-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/n0i72migbqvmr69c5zy5zh8nmp8xadjz-libwebp-1.0.1/lib  /nix/store/n0i72migbqvmr69c5zy5zh8nmp8xadjz-libwebp-1.0.1/bin
patching script interpreter paths in /nix/store/n0i72migbqvmr69c5zy5zh8nmp8xadjz-libwebp-1.0.1
checking for references to /build/ in /nix/store/n0i72migbqvmr69c5zy5zh8nmp8xadjz-libwebp-1.0.1...
/nix/store/n0i72migbqvmr69c5zy5zh8nmp8xadjz-libwebp-1.0.1

Timed out, unknown build status on x86_64-darwin (full log)
Attempted: libwebp
Partial log (click to expand)
cannot build derivation '/nix/store/kd0dgkzl8apiyxgsg591p01wlxys2r4y-configd-osx-10.8.5.drv': 8 dependencies couldn't be built
cannot build derivation '/nix/store/33sd35pk35alb1r654g8vmvqg137s8yv-python-2.7.15.drv': 8 dependencies couldn't be built
cannot build derivation '/nix/store/qn3l6rl1m43sgs4s017sasrvaasdcwag-libxml2-2.9.8.drv': 3 dependencies couldn't be built
cannot build derivation '/nix/store/5b7wqzrhhisp9qyigs1d78dymg75kw6r-autogen-5.18.12.drv': 6 dependencies couldn't be built
cannot build derivation '/nix/store/8xvasfj2bppsmhlyxakb3q86s407h6k1-libxslt-1.1.32.drv': 4 dependencies couldn't be built
cannot build derivation '/nix/store/7ydwmx28ss15shaq4l653vnj8d8l810r-libtiff-unstable-2018-11-04.drv': 7 dependencies couldn't be built
cannot build derivation '/nix/store/rgjamranx5a80v5rvi37dqdfiw80fcjr-xmlto-0.0.28.drv': 8 dependencies couldn't be built
cannot build derivation '/nix/store/l9dfacdb51fs30n7q1v6g4dy181z9y09-giflib-5.1.4.drv': 5 dependencies couldn't be built
cannot build derivation '/nix/store/z8z7sricsx4kv31xyhdvgwnhvahb147g-libwebp-1.0.1.drv': 6 dependencies couldn't be built
error: build of '/nix/store/z8z7sricsx4kv31xyhdvgwnhvahb147g-libwebp-1.0.1.drv' failed


Remove sonatype-lift

@mandy-chessell @davidradl @planetf1
Hi all, hope you're doing well. Can anyone from you remove the sonatype-lift app from this repository. As sonatype-lift is obviously not working anymore we can't merge any PRs. Also it would be great, if you could add me as codeowner for this repo
Thanks, Jürgen

Hello @juergenhemelt - do you know where this is enabled?  I can't find it

Hi @mandy-chessell @davidradl ,
there is an integration which you can find in Settings--> Integrations --> GitHub Apps
You should remove sonatype-lift from there.

@mandy-chessell Can you please check if the above solution is possible? I need to close the PR so that we can remove the fork.
Thanks in advance!


Main rename code changes

updates README Ref #292
updates CONTRIBUTING Ref #293
adds step to github ci to detect master #291

After github changes, this PR should cover everything else in #290

you can see in the history that i specifically failed the branches job to prove that it works


commander: HITL skip auto disarm if lockdown

auto disarm when locked down was added in #14766 to prevent user
confusion in regular usage, but also breaks HITL where lockdown is
enabled for safety
fixes #15686

I'd actually like to purge most of these HITL special cases in commander, but not today.

@bperseghetti

@dagar can you rebase now that the fix for Nuttx in MacOS is in?

This works for now, but again I'd really like to cut down on the HITL special cases.


Update zio-prelude to 1.0.0-RC25

About this PR
📦 Updates dev.zio:zio-prelude from 1.0.0-RC24 to 1.0.0-RC25
📜 GitHub Release Notes - Version Diff
Usage
✅ Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

⚙ Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "dev.zio", artifactId = "zio-prelude" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "dev.zio", artifactId = "zio-prelude" }
}]

labels: library-update, early-semver-pre-release, semver-spec-pre-release, commit-count:1

Superseded by #424.


h5bp & jQuery; clean slate for blueprints

Blueprints Everywhere!

[x] Burnin' down the house!
[x] Yo. H5BP, yo. Hey, yo, H5BP.
[ ] Skitchers gonna Skitch.
[ ] Planners gonna plan.
[ ] Yak shaved.

Blueprints Everywhere!

[ ] Project A: created first feature!
[ ] Project A: merged first feature!
[ ] Project B: created first feature!
[ ] Project B: merged first feature!
[ ] Project C: created first feature!
[ ] Project C: merged first feature!
[ ] BEAST MODE Started features on all projects!
[ ] BEAST MODE Merged features on all projects!

Grab a few more screen shots for your Blueprints assignments, and be systematic about naming them. You should definitely have a small, medium, and large set for each one, and you need to break each down into smaller pieces to zoom in on important details. As you build out and realize you've missed parts, update your specs.

Also regarding your specs, there's no need to include the name of the project in the filename. They're in the project directory, after all.

You should be ignoring the <header> element in the reference implementation.

Don't just leave floating arrows pointing at items: write something! Seeing an undocumented arrow in one of these diagrams is like seeing a comment in your code that just reads // IMPORTANT! WHY IS IT IMPORTANT!?!?


Fixed deprecated squeeze_dims argument

WARNING:tensorflow:From retrain.py:688: calling squeeze (from tensorflow.python.ops.array_ops) with squeeze_dims is deprecated and will be removed in a future version.
Instructions for updating:
Use the `axis` argument instead

Fixed.

Thank you!


tab: Fix error when no dropdown is used with tabs

If there is no dropdown being used as a tab self.dropdown is null. This
results in an error when attempting to test/set the active class on the null
dropdown variable.
This bug was introduced in commit "Removed classList dependency " 7acaaac...

Here is the line in the old code that checks if self.dropdown is present:
https://github.com/thednp/bootstrap.native/commit/7acaaac373e548ff6fdb4a84c30fece1dbfed65d#diff-4cdd7d0bfa2ae363723cb4b563c0c695L1629

Thank you for the catch.


The P256 code update

[!] This is a draft!
This PR modifies the existing P-256 code by

changing the way to talk about elliptic curves in general
Introducing 2 more ways to compute scalar multiplication
Introducing P-384 curve

Much of the functionality in this PR was incorporated in PR #802 and subsequent follow-ups.
Thanks for all the work!


feat(rust): scope some repositories to a given node name

We realized some time ago that some data needed to be segregated by node name in the database:

Resources (type, policies).
Identity attributes.
Credentials.

We fixed this by using mutation and allowing a database to temporarily have a node_name which could be used by the repositories needing it (the ones storing the data mentioned above).
This is problematic because:

This introduces some temporal coupling: we need to think of setting the right node name before invoking any operation that could potential touch resources, identity attributes or credentials.
This creates more potential states in the system: now any repository can potentially use a node name to store data, while in reality only a few of them need this.

This PR addresses this issue by:

Adding a node_name directly on the XXXSqlDatabase implementations needing it. For example in CredentialSqlxDatabase because credentials are segregated by node name in the database.
Changing the various builder functions so that a node_name is passed as a parameter as necessary. Typically, in the NodeManager we create storage that is scoped to a specific node.

This is still not great:

The fact that we share some storage, for example for the list of all identities, and that we segregate some, for example credentials, is the result of building a command line application and a NodeManager on top of the functions provided by  the ockam_identities crates. So, the constraints introduced at a "high" level in the architecture have some consequences on the "low" level of the architecture.

Concretely speaking, the Identities struct is mostly node agnostic but not entirely. When we use it to create an identity, that identity is accessible by any node. On the other hand if we use it to store a credential, it's node specific. One thing we could potentially do is revisit this choice and make every repository under Identities node specific. But this would be a much larger refactoring.

@SanjoDeundiak thanks for the review, I rebased and addressed your comments.


Disassociate workflow task names from individual tasks

Separate the task name in new workflow construction from task implementation. This enables re-use of tasks within a single workflow.
Additionally, an exported error has been added for easier programmatic identification of duplicate task names that are typically a programmer error.

/approve


hosted update on homepage and mark page

I have made changes in the Index and Mark pages

Nice work @krishnaglodha! Just fixed some typos.
We can talk about some contents in detail tomorrow.


Hide In-transit Encryption checkbox when MCG deployment mode is selected

The encryption in transit option is based on Ceph’s MSGR v2 protocol and is meant for traffic interacting with & within the ceph cluster (client-osd, osd-osd). MCG is not covered by this, so it doesn't make sense to show the option when deployment mode is MCG Only.

Tested the changes in cluster, Checkbox is now hidden.

/approve

/cherrypick release-4.17

/cherrpick release-4.17-compatibility

/cherrypick release-4.17-compatibility


Linter rule use-recent-api-versions suggests non-existent version for resource type

Bicep version
0.28.1
Describe the bug
Building or deploying a bicep file that includes a Microsoft.Insights/scheduledQueryRules@2023-03-15-preview resource emits an inaccurate warning message:
Warning use-recent-api-versions: Use more recent API version for 'Microsoft.Insights/scheduledQueryRules'. '2023-03-15-preview' is a preview version and there is a more recent non-preview version available. Acceptable versions: 2023-12-01, 2022-06-15 [https://aka.ms/bicep/linter/use-recent-api-versions]

2023-12-01 is not a valid API version for Microsoft.Insights/scheduledQueryRules, and attempting to deploy with the suggested change results in an error.
To Reproduce

Create a bicep file (named e.g. main.bicep) with a Microsoft.Insights/scheduledQueryRules@2023-03-15-preview resource.
Run az bicep build --file main.bicep

Unfortunately this is an RP issue, please open up a support ticket with the Microsoft.Insights team.


chore(tools): Remove unused old release tools

What does this PR do?
Remove unused old release tools
Motivation
Tech debt
Describe how to test/QA your changes
Possible Drawbacks / Trade-offs
Additional Notes

/merge

/merge


Disabling Better Stone Tools Removes Vanilla Stone Tool Recipes

Describe the bug (Required)
After setting the betterStoneTools option to false, the vanilla recipes are not added instead of the new recipes.
To Reproduce (Required unless not known)
Steps to reproduce the behavior:

In the vanillatweaks\Crafting.toml file, change betterStoneTools to false
In-game, the Vanilla recipes for the stone tools will not work.

Log output/error (via. Pastebin)
Expected behavior (Required)
Stone tools should use the default, vanilla recipes.
Screenshots

Versions:(check log if you don't know)

Forge Version: 28.1.76
MC Version: 1.14.4
Mod Version: <IP_ADDRESS>
JEI Version (if present) : <IP_ADDRESS>

Hmm better stone tools and better recipe for stone stairs doesn't work at all. I am sure this is due to some other mod.


[Enhancement] Add stackoverflow and keybase icons

This is a simple addition of two icons, taken from the Simple-Icons project at https://github.com/simple-icons/simple-icons.

@mjpieters thanks for contributing and proposing this change! I'm going to leave this open for now as what I'm hoping is that people +1 / 👍 it enough to get it merged in. At the minute I don't see these icons being requested that much, but I'd like to see people prove me wrong

Perhaps we should consider some kind of extension mechanism instead then? Each and every site needs a different set of icons, and I'd love to avoid having to override includes as much as I can.
Would it be an idea to have an _icons collection instead here we can add or remove these as needed?


Fixed Demo Files

Corrected the following error thrown in every demo:

Mixed Content: The page at 'https://stutrek.github.io/scrollMonitor/demos/stress.html' was loaded over HTTPS, but requested an insecure script 'http://cdnjs.cloudflare.com/ajax/libs/jquery/1.8.3/jquery.min.js'. This request has been blocked; the content must be served over HTTPS.

Thanks! Would you mind squashing this to one commit?

Created a different pull request with only one commit.


Removing parent folder from terminal links doesn't work on Windows

The terminal has a feature where links such as ../README.md that can't be detected as files will open the quick pick with the ../ removed as the quick pick doesn't support parent folders, plus in many cases the ../ is actually relative to a sub folder of the workspace folder.

Expected:


Airtable has deprecated API Keys in favor of oAuth and Personal Access Tokens

This Node-Red Integration appears to rely on API Keys.  As of last August, you can no longer create API keys and as of February 2024 (next month), that access method will be shut off.  Is there a plan to update this Node to support Personal Access Tokens?
https://support.airtable.com/docs/airtable-api-key-deprecation-notice
January 2023: Initial community forum announcement and emails
Mid-February 2023: We will email API key owners with recent API key usage to directly inform them of the changes
August 1st, 2023: Users can no longer create new API keys
February 1st, 2024: Existing API keys can no longer be used to access the Airtable API

https://github.com/joeartsea/node-red-contrib-airtable/issues/17


Fixing tests: adding support for SSHAgent and fixing a missing method in Pharo5

Hi Mariano, it is a problem with the authentication of iceberg in Pharo 7,
but I couldn't fix it. It is still failing . I have talked with Guille and
he told I will be fixed in the next version, to be released tomorrow. With
that version the ssh agent should not be needed.
If it does not have proper rights it should default to use https read only.
Tomorrow I will try to do a new test, to see if the fix is correct.
Abrazo,
Pablo
On Tue, 24 Apr 2018, 19:20 marianopeck<EMAIL_ADDRESS>wrote:

Thanks Pablo. I am not aware of this need of the ssh agent setup on the
CI. Could you shortly explain me why you need this? is this something new
for SmalltalkCI?
Thanks
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/marianopeck/OSSubprocess/pull/32#issuecomment-384012321,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAVsfxou9SJqmrcUNNLts-fbWQN9aV3iks5tr17EgaJpZM4Thvyc
.

@tesonep do you know what;s the status about this? Should I merge or not ?

The change is already integrated in upstream.


Automatic worker restart

The problem
When a worker dies due to an unexpected reason the master process doesn't restart it.
My suggested solution
Adding a signal handler to workers to start a new one (with proper parent process) in case of receiving termination signals.
Additional context
I believe it can be added in sanic/server.py in function serve_multiple

Automatic restarting is handled in the Trio branch that I am testing on (but the whole branch is very experimental and not suitable for real use at this time). The main process always keeps the configured number of workers alive and frequently polls for any dead ones, and will also restart all of them when it receives SIGHUP. The whole multiworker fork logic should probably be restructured for other reasons as well (Windows compatibility/signal handling, and not pickling the app object). That would also allow completely graceful restarts when source code is modified, etc. See #1662 and #1684 for more information.
If you are willing to fix it yourself, feel free to do a pull request. Otherwise it'll take a few months at least until it gets fixed. You'll probably want to keep all restarting/shutdown logic in the parent process that otherwise doesn't really do much, and just have the workers terminate on (any) signals. All help is highly appreciated here.

Thanks for the detailed response @Tronic
We are using Sanic in some sensitive microservices and can't afford to test experimental codes. We managed to go around the problem by tailoring some features of Kubernetes and increasing the resources for those microservices. Even though this problem is still bothering us from time to time, it's not doing so much harm to be given priority. So, I guess we'll wait. But we might decide to contribute in the future if the situation changes.
By the way, the Gunicorn mode has this functionality, but we failed to run it with ASGI. Did we make a mistake or it's not being supported anymore?


[Bug] Draw line cannot cross itself

Describe the bug
When using the line tool, the point is not placed on click when it is crossing the current line being created/edited.
Tested on MapLibre

This issue might be related to the self-intersecting polygon prevention

I am not able to reproduce this without enabling specific validations. For example you can enable this by doing:
		new TerraDrawLineStringMode({
			validation: (feature, { updateType }) => {
				if (updateType === "finish" || updateType === "commit") {
					return ValidateNotSelfIntersecting(feature);
				}
				return true;
			},
		}),

Can you share the code with me you are using? Thanks

@y3nd I didn't hear back here so going to assume you managed to resolve the problem. As I mentioned I wasn't able to reproduce - as you mention it is probably that the example you're looking at uses some validation to prevent self intersection. Please feel free to raise another issue if you are still having problems, providing a reproduction case so I can take a look.


@testcontainers/redis isn't published to npm

Expected Behaviour
The instructions in the documentation should work.
Actual Behaviour
$ npm install @testcontainers/redis --save-dev

npm ERR! code E404
npm ERR! 404 Not Found - GET https://registry.npmjs.org/@testcontainers%2fredis - Not found
npm ERR! 404
npm ERR! 404  '@testcontainers/redis@*' is not in this registry.
npm ERR! 404
npm ERR! 404 Note that you can also install from a
npm ERR! 404 tarball, folder, http url, or git url.

npm ERR! A complete log of this run can be found in: /Users/hassankhan/.npm/_logs/2024-01-12T00_22_31_797Z-debug-0.log

Testcontainer Logs
N/A
Steps to Reproduce

Run the install command from the documentation
See a dependency not found error

Environment Information

Operating System: macOS 14.2.1
Docker Version: 4.26.0
Node version: 20.10.0
Testcontainers version: 10.2.2

Released just now in https://github.com/testcontainers/testcontainers-node/releases/tag/v10.5.0

Thanks @cristianrgreco


log error when meet invalid json

In some special cases, json may failed to escape. This pr log errors in these cases and help user to find bug quickly.

Codecov Report
Attention: 12 lines in your changes are missing coverage. Please review.

Comparison is base (707e216) 99.08% compared to head (03cae20) 98.88%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #473      +/-   ##
==========================================
- Coverage   99.08%   98.88%   -0.21%
==========================================
  Files          82       82
  Lines        5820     5839      +19
==========================================
+ Hits         5767     5774       +7
- Misses         40       48       +8
- Partials       13       17       +4

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


[Azure Functions][Bindings]Update table binding docs  - IQueryable is not supported in V2 and V3

Please update following section:

https://docs.microsoft.com/en-us/azure/azure-functions/functions-bindings-storage-table?tabs=csharp#cloudtable

IQueryable isn't supported in the Functions V2 and V3 runtimes  or be more explicit IQueryable is supported only in the Functions V1 runtime

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 6d35c032-eae7-ac4b-2ad3-32fd0cd2318f
Version Independent ID: 92b0a972-eabe-8048-36b1-a1cefb3acf43
Content: Azure Table storage bindings for Azure Functions
Content Source: articles/azure-functions/functions-bindings-storage-table.md
Service: azure-functions
GitHub Login: @craigshoemaker
Microsoft Alias: cshoe

Thank you, @pragnagopa! We have assigned this issue to the content author to review and take the next course of action.

This update is made. The live site will reflect these changes with the next refresh.
#please-close


FFM-7270: clarifies how targets are typically added

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app


Feature Post Update Bug

Issue Summary
When you go to make a change to a published post and only toggle the "Feature this post" checkbox, the Update button isn't activated. You can get around this by going and adding and removing a space to the post content (which makes it think there's been a change made).
Steps to Reproduce

Go edit a post in the dashboard
Don't make any changes other than step 3
Toggle the "Feature this post" checkbox
Try to update the post (you can't)

Ghost Version
Latest (Ghost Pro)
Node.js Version
Ghost Pro (not sure what they're running)
How did you install Ghost?
N/A
Database type
Whichever Ghost Pro uses
Browser & OS version
Chrome  106.0.5249.121 & Windows 11
Relevant log / error output
No response
Code of Conduct

[X] I agree to be friendly and polite to people in this repository

Hey there, thank you so much for the detailed bug report.
That does look like something that shouldn't happen! A PR to fix this issue would be very welcome 🙂
In the meantime a workaround is that the standard keyboard shortcut for saving -  cmd+s or ctrl+s depending on your OS - will always save the post.

Hi 👋
I've checked on this bug.
The published post seems to update automatically when you change anything from the post settings. So, clicking on Feature this post checkbox will toggle the featured post instantly.
The update button will only be available if you edit the title / post itself

The published post seems to update automatically when you change anything from the post settings. So, clicking on Feature this post checkbox will toggle the featured post instantly.
The update button will only be available if you edit the title / post itself

So is this a feature rather than a bug? haha

Hello there,
I think it's not a bug. As @h2akim said it's updating automatically.
Not only on the feature post but also when we change the Post URL, Meta title, meta description, etc.

Hmm I'd need to check with @kevinansfield but I thought none of the changes should auto-apply on a published post 🤔

@ErisDS the post settings menu has always been a bit of an odd one in that respect, changes there save instantly. From what I can remember it was mostly to do with validations, where server-side validation could trigger and put the post into an invalid state but if the post settings menu was closed - as it would always have been before the recent sticky sidebar introduction - the validation message would effectively be invisible.
It's one of those things that's "expected but a bit odd" and has been waiting for more comprehensive design review for a long time.


Update deployment scripts for 2.0.4 and test campaigns in central couch

Fixes #11073
Status
In development
Description
Short summary of changes is:

remove 2 deployment variables no longer needed (DASHBOARD_URL and REQMGR_URL)
update deployment script examples to the latest WMAgent production release candidate
update test campaigns to be inserted in central CouchDB
data location must be set with the RSE name (not the site name)

But the real work in the relevant GH issue is actually the full validation of a new stable WMAgent release...
Is it backward compatible (if not, which system it affects?)
YEs
Related PRs
None
External dependencies / deployment changes
None

test this please

test this please

@todor-ivanov this is the usual deployment changes that come with WMAgent upgrade campaigns, but just in case you want to have a look. I am still waiting for a PR to be merged in the deployment repository though.

test this please

New issue created to follow up on these unit test failures, unrelated to these changes: https://github.com/dmwm/WMCore/issues/11194


[ISSUE-647] Upload artifacts to GH

Purpose
Resolves #647
Add junit report, logs to artifacts
PR checklist

[x] Add link to the issue
[x] Choose Project
[x] Choose PR label
[ ] New unit tests added
[ ] Modified code has meaningful comments
[ ] All TODOs are linked with the issues
[ ] All comments are resolved

/ci


Image for ARM (armhf)

Hi,
are there any plans to have official docker image for ARM devices?

Since ARM isn't officially supported by the Swift project I think it would be out of scope for this project to simultaneously support Swift on ARM and a docker image based on that. While I'm very interested and supportive of this effort, perhaps we should create an experimental image under this organisation - Docker Swift ARM?

I found some docker iamge for armhf Ubuntu 16.04, and compiled Swift with 3.0.2 version. Maybe this is a good point to start? What do you think?

Please share what Dockerfile have in a repository!

I found that repo: https://hub.docker.com/r/armv7/armhf-ubuntu/

I mean that plus the instruction for how to build an ARM docker image.
One thing: I doubt we can offer this under the official repo - we need the base image to be an official repo too, unless it's FROM scratch.

Unfortunately currently there are only "experimental" images [according this info[(https://github.com/docker-library/official-images).

Okay, well if you could contribute a Dockerfile that produces an ARM image with working Swift then we can have a look!

Ok, I will try and let you know about results ;)

Doesn't have arm64, but might still be useful: dockSwiftOnARM

I don't think this is something many people have stepped forward and asked for, nor something that others have offered to support. I'm closing this issue for now, however I strongly encourage anyone passionate about running Swift on ARM Linux to bring us a working Dockerfile. If you do so, it will have a home here.

Well, my Dockerfile is working just fine. At least for Swift 3.1. Swift 4 is still stuck. So how would you suggest to go forward with this? Another Dockerfile as a PR, moving over dockSwiftForArm into the swiftdocker org?

@helje5 I was entirely mistaken – we can support multiple architectures.
If you're willing to support arm, we'd be happy to have it. I assume we need a separate Dockerfile? Please propose it as a PR inside 3.1/arm64.

For other contributors, we can make this official: https://github.com/docker-library/official-images#multiple-architectures

I think the core problem is that swift.org provides no ARM packages. So either you compile Swift from the source (which I can do in Docker), or you pickup a tarball from somewhere non-standard. Not sure what we would want here.

@helje5 If you're ok with maintaining them. Can you define a Dockerfile that compiles it?

@krystiansliwa We are moving Swift Docker issues to https://bugs.swift.org Component: Docker. Can you please file your issue on bugs.swift.org?
We are planning on closing GitHub swift-docker issues on Dec 20th, 2018 (PST).

This issue is very old - please reopen if it's still a problem.

@krystiansliwa I've created scripts to cross compile the Swift 5.7 runtime (Not the entire compiler) from x86 or Arm64 to Armv7. You can also cross compile SwiftPM packages from macOS and deploy to Debian 11 armhf.
https://github.com/colemancda/swift-armv7
https://hub.docker.com/repository/docker/colemancda/swift-armv7

Debian 11 docker with Swift 5.7 runtime installed
colemancda/swift-armv7:5.7-debian11

Cross compilation environment
colemancda/swift-armv7:latest


addContext, multiremote sessionId

2 Changes:

Add mochawesome's addContext functionality
Fix sessionId's for Multiremote and display as object (see below). (In Multiremote session id is stored in runner.capabilities)

Usage:
const {addContext} = require('wdio-mochawesome-reporter').default;

describe('Add Context', function() {
    it('Add context with title', function() {
        addContext({
            title: 'Some Context',
            value: 'test'
        })
    });

    it('Add string context', function() {
        addContext('string, string, string, string, string, string');
    });

    it('Add array context with title', function() {
        addContext({
            title: 'Some Array',
            value: [1,2,3,4,5]
        })
    });
});

Result (in Multiremote):

Thanks for the PR.  Looks like the build failed. Can you review and fix any issues?

Thanks for the PR. Looks like the build failed. Can you review and fix any issues?

Done. The problem was the addTestContext() function in test.js. I removed it because I thought it's not needed (and forgot to run the tests...)
This is how tests are initialized:
onTestStart (test) {
  this.currTest = new Test(test, this.currSuite.uuid)
  this.currTest.addSessionContext(this.sessionId)
}

So you pass test object which from @wdio/runner docs looks like this:
TestStats {
  type: 'test',
  start: '2018-02-09T13:30:40.180Z',
  duration: 0,
  uid: 'passing test3',
  cid: '0-0',
  title: 'passing test',
  fullTitle: 'passing test',
  state: 'pending' } }

This is test constructor which calls addTestContext with the test object from onTestStart:
constructor (data, suiteUUID) {
        // ...
        this.context = addTestContext(data) // see below
    }

Here is what addTestContext does:
function addTestContext (data) {
    let testContext = []
    if (data.context) {
        if (Array.isArray(data.context)) {
            data.context.forEach((ctx) => {
                testContext.push(ctx)
            })
        } else {
            testContext.push(data.context)
        }
    }
    return testContext
}

Basically in case the TestStats object doesn't have "context" in it, the test.context will be "[]". Which is always.
I put it back so that tests pass as this doesn't really change anything, but if I understood correctly there might be need for a little refactoring and removing that test which failed - "Should successfully instantiate a TEST object with context".

Bump

@arnisgustins are using @wdio/mocha-framework?  asking because that already has support for addContext which is supported by this reporter

Yes, I am using @wdio/mocha-framework.
Is it really supported? By the open issues I assumed it's not as I have never been able to make it work.
https://github.com/fijijavis/wdio-mochawesome-reporter/issues/43
https://github.com/fijijavis/wdio-mochawesome-reporter/issues/50
I am talking about WebdriverIO v5 and v6. Have never used v4.

@arnisgustins I think I see the issue.  It looks like between WDIO v4 and WDIO v5 something changed (not sure what) and test:start event no longer contains the context key.
Anyway.... I honestly haven't tried using addContext since v4 so it's not totally surprising it doesn't work any longer.
We originally added this to wdio-mocha-framework because we thought it could be useful for any reporter to take advantage.  But it feels to me like you solution is a good idea b/c it will isolate this need from any future changes in WDIO.

For reference... in @wdio/mocha-framework this line pulls in the context
I put a console.log in the emit function of @wdio/mocha-framework
{ type: 'test:start',   title: 'Add context with title',   parent: 'Add Context',   fullTitle: 'Add Context Add context with title',   pending: false,   file: '/Users/javis/repos/sandbox/wdio/test/specs/sample.spec.js',   duration: undefined,   cid: '0-0',   specs:    [ '/Users/javis/repos/sandbox/wdio/test/specs/sample.spec.js' ],   uid: 'test-00-0' }
{ type: 'test:pass',   title: 'Add context with title',   parent: 'Add Context',   fullTitle: 'Add Context Add context with title',   pending: false,   file: '/Users/javis/repos/sandbox/wdio/test/specs/sample.spec.js',   duration: 1,   context: { title: 'Some Context', value: 'test' },   cid: '0-0',   specs:    [ '/Users/javis/repos/sandbox/wdio/test/specs/sample.spec.js' ],   uid: 'test-00-0' }
{ type: 'test:end',   title: 'Add context with title',   parent: 'Add Context',   fullTitle: 'Add Context Add context with title',   pending: false,   file: '/Users/javis/repos/sandbox/wdio/test/specs/sample.spec.js',   duration: 1,   context: { title: 'Some Context', value: 'test' },   cid: '0-0',   specs:    [ '/Users/javis/repos/sandbox/wdio/test/specs/sample.spec.js' ],   uid: 'test-00-0' }
You'll notice the test:start event doesn't have the context.  This is a problem because the @wdio/reporter instantiates the test object at test:start here from there only the relevant status information is updated from the other events.

@arnisgustins I have to get to my day job :) I'll merge this change and update the README tonight.  Thanks again for the PR

Thank you very much for the thorough answer :). It makes more sense now.

@arnisgustins published new version 4.0.0


App validator (Request for review)

This is a first draft on an app validator to ensure all json files parse, and that references are valid.
Some of the functionality might be better to do in frontend instead, but we need the infrastructure in backend, because some of the checks are not frontend relevant.

applicationmetadata.json appLogic.classRef is not possible to validate on frontend
the C# model must match the json schema model.
I also implemented some of the reference validations that has hurt our productivity badly. I don't think duplication is really a big issue here, as apps with these issues will never be valid.

See also

https://github.com/Altinn/app-frontend-react/issues/648

A big advantage of validation in C# is that I can print file name and location, to get a clickable link in the vsCode terminal to the exact location of the error.

Solution description
New implementation of IAppResources that depends on the new AppFilesBytes so that all files can be loaded async in a hosted service on startup. That way accessing resources don't rely on reading from disk (I do json parsing for each return, to ensure that modifications to the results don't get preserved.) I have not yet changed the default registration of IAppResources, but tested that it works for some of our apps.
New AppFilesSyncHostedService that is a hosted service that loads AppFilesBytes on startup before the app is ready to serve http requests.
New AppFilesSyncHostedServiceDebug that runs validations and updates AppFilesBytes on startup and every time any json, xml or bpmn file is changed. Prints validation errors to the console.
For discussion
How do we report errors? (terminal, 503 with content so that frontend can show the error)
Should the app crash, or continue on an error?

PS: This also includes the commits for https://github.com/Altinn/app-lib-dotnet/pull/95

Fantastic!! :partying_face: :heart_eyes:
I haven't looked properly at the code, but from the description it seems we agree on a lot here. If you didn't see my comment yesterday, I'm thinking that each project validates the app on their own, and that we collect all validations, merge them, and present them to the user. I'm leaning towards making a JsonSchema for validation messages that each project can use. Something like:
{
  "Some headline/category of validation errors": [
    {
      "class": "duplicate-component-id",
      "title": "Component ID is a duplicate, the same ID was found in page3",
      "description": "These should be unique for every component, across all pages in the same process task",
      "file": "App/ui/layouts/page2.json", // Optional, frontend doesn't know this
      "line": 55, // Optional
      "context": "..." // Optional, backend shouldn't need to fill this in, but it could contain a multi-line string with a formatted representation of the area around where the error occurred in the file
    },
    ...
  ],
  "Other headline/category": [...]
}

That way, we could:

Render the validation messages locally (for this project that means in the terminal, potentially while crashing the app)
Pass the validations to some other system (frontend via a 503, Studio via a command-line tool that outputs the JSON) that can merge the messages along with other messages and present nicely to the user.

What do you think?

I think my AppValidationError is pretty close to your suggestion.
Adding a middleware that responds with the error for all requests when a static list of errors isn’t empty would be easy, but then we obviously can’t stop the app on error.

Ah, great - I did not see that part. We should probably consider adding severity information, then. One or more fatal errors should probably refuse to start the app, but maybe a regular error shouldn't. Same with warnings (and possibly notices).

Great!
Love the idea of fail fast and tell the developer whats wrong.
One thing I started to think about: could we fail even earlier/faster? If this is analysis of static files present at compile time, could we write an analyser that leverages the same checks and giving feedback when we try to compile an application with bad configuration?

@tjololo That was my first thinking, and would be a reasonable way to also ensure docker builds fail, and give very nice red squiggles in json files in VSCode. A few reasons made me reconsider.

Running C# inside the compilation process is restrictive and including libraries (for json/jsonSchema) is problematic because you might get into versioning issues (you run in a host process with their dependencies). It might be true (as Microsoft says) that this is a tooling issue, but I don't really see how to solve the compatibility issues of publishing code that should run in process can really be fixed.
Users might not want to restart their app every time they change a json file (that doesn't really affect compilation). It is much smoother to just refresh the browser to see the changes.
The same code might be used in studio, or other places where a compile interface would make integration much harder.

Valid points that I didn't think of!
To have the same validation in studio would it make sense to extract the validation logic into a separate nuget that both app and studio use?

To have the same validation in studio would it make sense to extract the validation logic into a separate nuget that both app and studio use?

Maybe. Or studio can just depend on Altinn.App.Core to get everything (exept the parts of Altinn.App.Api that registrers controllers and stuff).

In regards to the question "how do we fail" I have always thought that if the app can not run as expected and we know it, the application should log the error and then crash hard. Id this happens at startup we need to make sure the logs are flushed to application insights as not to leave those who deploy to tt02 in the dark as to why the crash.
Could you make the test pass again?

@tjololo The tests kind of passes, but I dissagree with CodeQL that catch (Exception e) is bad (in code that isn't guarded by the request pipeline), and I can't figure out a way to parse JsonDocuments in a loop, and still dispose them with the using keyword.

Sorry, thought I had posted a reply, but apparently it was forgotten! 🙈
As we are checking if the config files are valid it makes sense to me to catch a generic exception to.
We are getting more pull requests that is handling caching of static files, but with variations in implementation. If the caching implementation you have introduced isn't strictly necessary to solve the validation I think we need to take a step back in our team and solve the caching solution in consistent way. We also need to keep the memory footprint in mind as having applications that are used once a week or  less using memory to cache static files would affect the cost.

Sorry, for opening so many pull requests (especially like this one that only represents a partial solution in the hope that you would engage in some sort of discussion to make this solution better). I'll close this and work on alternative approaches for app validation instead.


publishToCrates - publish to crates.io (rust artifacts)

Add a jenkins library to allow artifacts to be able to published to crates https://crates.io/
Acceptance Criteria

[ ] Artifacts should be signed before publishing
[ ] Artifacts should be published in an automated manner without any human intervention

[Triage] We will be working on this in next few weeks.


Library Source does not match the bytecode for class RxBleConnection

Summary
Getting the message "Library Source does not match the bytecode for class RxBleConnection" when I command "Go To Declaration" on RxBleConnection in my project.
Library version
1.4.1
Preconditions
I have this in build.gradle:
compile "com.polidea.rxandroidble:rxandroidble:1.4.1"
Steps to reproduce actual result
Use the library in a project
Minimum code snippet reproducing the issue
unknown
Logs from the application running with setting RxBleLog.setLogLevel(RxBleLog.VERBOSE)
n/a (but the Application seems to work OK)
Actual result
Getting the message from Android Studio that "Library Source does not match the bytecode for class RxBleConnection" when I command "Go To Declaration" on RxBleConnection in my project.
(but the Application seems to work OK)
Expected result
Do not see this message.

Have you tried suggested stackoverflow solutions?

Yes I looked there but everything I found seemed to involve maven. I will look some more.

How about clean + rebuild?

clean: no
rebuild: no
rm -rf $HOME/.gradle/caches/  and rebuild: this gets rid of the message, but now when I command "Go To Declaration" it just decompiles RxBleConnection.class. There is an option to "Choose Sources" but I don't know where to find those, if they even exist on my computer.
Re-launch Android Studio: no change.
Why is this happening? I've never seen anything like this before.

It looks like a bug in your local build toolchain. The sources are a part of the distribution package of the library.
You can use the Invalidate caches and restart option from Android Studio menu.
Either way this is not related to the library itself.
Best Regards

Since there are no new posts here I assume that the problem is solved. Feel free to reopen if not.

Method 'Clicks(com.example.android.miwok.View)' is never used error . can you help me? please


If aws already exists pass --update

Probably not needed as github runner appears to have v2 of aws cli now.


Original image color was changed

I use the hugging demo to remove image background, but the color changed in image which background was removed.
From these two images, it can be seen that the color of the processed image has become lighter
huggingface space link: https://huggingface.co/spaces/ZhengPeng7/BiRefNet_demo

original image

result

I found through debugging that there are many floating-point data with very small differences in the mask. Is this the reason for this

Yeah. If you don't apply hard thresholding, the pixel values of the predicted maps of BiRefNet are actually float ones between 0 and 1. What's more, floats also represent transparency.


Launcher icon size not fixed

Launcher can sometimes display icons taller than intended, making bar very tall

Have set FORCE_SIZE flag when loading them icons, hopefully that does it


Panic occurs when I try to watch multiple key ranges.

Package Version: etcd-rs = "0.2.2"
Error Message: thread 'main' panicked at 'take the unique watch response receiver', src/watch/mod.rs:125:9

Below is the code to reproduce the error.
use tokio::stream::StreamExt;

use etcd_rs::*;

async fn watch(client: &Client) -> Result<()> {
    println!("watch key value modification");

    {
        let mut inbound = client.watch(KeyRange::key("foo")).await;

        // print out all received watch responses
        tokio::spawn(async move {
            while let Some(resp) = inbound.next().await {
                println!("watch response: {:?}", resp);
            }
        });
    }

    {
        let mut inbound = client.watch(KeyRange::key("foo2")).await;

        tokio::spawn(async move {
            while let Some(resp) = inbound.next().await {
                println!("watch response: {:?}", resp);
            }
        });
    }

    let key = "foo";
    client.kv().put(PutRequest::new(key, "bar")).await?;
    client.kv().put(PutRequest::new(key, "baz")).await?;
    client
        .kv()
        .delete(DeleteRequest::new(KeyRange::key(key)))
        .await?;

    Ok(())
}

#[tokio::main]
async fn main() -> Result<()> {
    let client = Client::connect(ClientConfig {
        endpoints: vec!["http://<IP_ADDRESS>:2379".to_owned()],
        auth: None,
        tls: None,
    })
    .await?;

    watch(&client).await?;

    client.shutdown().await?;

    Ok(())
}

The cause of this issue is that Watch uses only one WatchTunnel and it is designed to have only one receiver.

it is designed to have only one receiver.

Yes, that's the cause. And I don't have a better idea to change it, so keeping it still for now. 😢


feat: updated Moonbeam/Moonriver logos

Description
Updated Moonbeam logos so they follow the new brand guidelines
Changes include

[ ] Bugfix (non-breaking change that solves an issue)
[ ] New feature (non-breaking change that adds functionality)
[ ] Breaking change (change that is not backwards-compatible and/or changes current functionality)
[ ] Tests
[ ] Documentation
[x] Other (for changes that might not fit in any category)

Hello @albertov19, shouldn't these two glyphs be updated accordingly as well ?

glyphs/chain_1284_64px.gif
glyphs/chain_1285_64px.gif

@apaillier-ledger, thanks for the nudge. I updated the gif you mentioned.
Let me know if anything else


Doesnot it support append file method?

No, the library does not support this as of now. Feel free to submit a PR for this functionality for iOS and Android though.

@susylPearl @johanneslumpe We do have appendFile in V2, see README.md

@cjdell my oh my, how could I miss that :D ok great, closing!


Start developing end-user API for temporal graphs

An end user API should have at least the following points:

[ ] Patch constructor for each day
[ ] Node features for each patch
[ ] Node renumbering, nodes should be numbered $0 \ldots|V|-1$ where V is the full vertex set, but also need to be numbered $0 \ldots|P_k| -1$ where $P_k \subset V$ is a patch. There should be a way to get back the node numbering in the full vertex set and the node label
[ ] Generate embeddings for each patch using a method such as VGAE. Methods could be abstract classes or functions following a typing.Protocol
[ ] Align embeddings using a EmbeddingMethod (could be local2global, or the new method being developed).

Further processing of embeddings, such as using them for classification is out of scope for this issue.

Sketch
from l2g import make_patch_graph, DataLoader, make_embedding, align_embeddings

# TODO: see what other graph embedding libraries use and try to be compatible
# L2Gv2 should be able to work with any embedding
from l2g.embeddings import VGAEEmbedding

# Local2Global is the old algorithm, ManifoldOptimizer the new one
from l2g.align import Local2Global, ManifoldOptimizer

# Load data
ds = DataLoader('l2gv2/nas')  # loads from web (HuggingFace?)

P = make_patch_graph(ds, patch_identifier: str | V -> str)
vgae = VGAEEmbedding(**kwargs)

# Create embeddings, can use trivial parallelism here (multiprocessing.Pool)
embs: dict[str, np.array] = make_embedding(vgae, P)  # calls emb.fit_transform(P[i]) for patch node i
# ^do node and edge embeddings need to be disambiguated?

# Alignment
aligner = ManifoldOptimizer()

# .fit() could generate the alignment criteria (scaling, orthogonal transformations and translation)
# whereas .fit_transform() applies it. Not clear whether keeping them separate makes sense.
X = aligner.fit_transform(embs)  # X is xarray with node labels

Need to consider how much of this is portable to large graphs (perhaps by using dask and xarray) - should the use of multiprocessors / GPU / cluster be transparent to user which adds complexity or we handle that ourselves (such as using CPU for toy datasets), allowing the user to override as necessary.


support commands concatenation

I think we should add support for command concatenation.
This would allow users to run commands like:
arkmanager stop update start

And in future it could be used to prepare one line commands like:
arkmanager update broadcast "Server is again up!"

Well, once RCON is supported i'm pretty sure most people will set up cronjobs for this purpose.

+1. each users should use it's own script that call many arkmanager command for this purpose.

This issue should have been satisfied by b52770f


Saving the generated audio for WAV or MP3

Dear Brian, it's me again, needing your assistance. I would like to generate the sound and be able to export it to wav or any other format with the JS version.
Can you give me directions on how to do it?
Thank you very much as always!

Hi @carlosguedes,
The JS lib doesn't have that functionality. I didn't think it'd be particularly useful.
You could fork it to get the raw samples relatively easily, but then you would still need to put them in the WAV container. The C library uses libsndfile to do that, which won't be present here.
If you want to try, the first step would be to add a new function that wrap quiet_encoder_emit. It's already called by the webaudio callbacks in JS, so you could just find those and copy/paste into a new function that returns the samples. You'd also have to add some way to disable the webaudio bits so that you could invoke consume directly.
Let me know if you have more questions.

Dear Brain, first of all thanks for great api.
can you please share the code for generating audio ?

Hi @brian-armstrong,
I'm trying to get raw samples, could you please tell me if this function returns them?
 var written = Module.ccall('quiet_encoder_emit', 'number', ['pointer', 'pointer', 'number'], [encoder, samples, sampleBufferSize]);

Hi @carlosguedes,
Have you managed to set it up somehow?

@brian-armstrong, may I ask your attention here, I've created a PR for this issue that allows downloading transmissions in ".wav" format.


Add a way to insert multiple objects at once

It might have missed it (apologies if so), but would we want to add a guardrail for the input data size? CQL (for reference) appears to have per-request input size restriction.

Do you mean batch size? Good idea, but let's add it in a separate ticket. The @atomic was already working before this PR without such a guardrail. So this new guardrail would need to impact the existing and the new code.

On the other, if the batch size is too big, it will result in the exception from the backed, right? [...]

My concern is that just processing overly large query input in Stargate (before sending it to persistence) might be enough overhead to cause performance issues and allow DOS attacks.
Yes, we can certainly address this in a separate PR.


[WIP] drivers: mfd: add support for stm32 timers

So, I was a bit upset due to extensibility of the timer driver for the stm32 within Zephyr.
I opened up an enhancement issue #20262. And started digging around how Linux does this.
So I got inspired by by the MFD driver for stm32-timers, see stm32-timers.
I'm using the stm32f4 series as a motorcontroller (with hall sensors and field oriented control). And the timer can do a pretty good job here. But I want to use the timer as a base for other modules, like hall sensors and 3 phase generation. So I got it to work, and changed it only for the F4 series (all is based on the original drive, but I moved from the bulky HAL driver to to LL driver).
Also I moved from the DTS fixups to the instance based implementation. But it still needs more cleanup.
So I would like to hear from you, if it's useful I will cleanup things further so it can be merged.
TODO's

Fix DTS files for complete stm32 series
Cleanup dts_fixups
Test on more platforms

@maxvankessel, thanks for this contribution. Looks pretty nice with interesting bonuses like transition to LL API.
Since we're getting closer to V2.1 end of merge window. I'm tagging V2.2 as a merge target.
Also it is likely that closer review won't happen before V2.1 release.

@avisconti , FYI, IIRC, you need a timer driver for some application

@avisconti , FYI, IIRC, you need a timer driver for some application

You remember correctly. It was the #17140 PR, which is frozen for the moment as there was some
points to be clarified (timer driver was one of the points).
I may come back again to this PR in the next future.
Thanks!!

@maxvankessel, I'm starting having a deeper look.
To see real interest of the mfd, it would be nice to have an (even light) implementation of another driver based on this mfd_timer. Current in-tree potential user would be counter(timer).
Would you have time to work on a mfd based stm32 counter_timer ?
Also, to ease the review, it would be nice to split the PR in commits (spliting based on subystem would be a good start for now). This would be anyway a pre-requisite if we want to get this merged.

@erwango So I've split the commit, removed pwm contents from the mfd commit.
What do you mean with "counter"?

Current in-tree potential user would be counter(timer).

Quadrature decoder? Or a capture interface? What is it you want to count?

@erwango So I've split the commit, removed pwm contents from the mfd commit.

Thanks for having taken the point into account, but I didn't meant to remove the PWM impact purely for the PR. Splitting the PR into several commits is generally a good way to ease the review  process (then maybe we split the PR into several PRs to speed up the merge of large PRs, but we're not there yet).

What do you mean with "counter"?
Quadrature decoder? Or a capture interface? What is it you want to count?

include/drivers/counter.h is zephyr public API for counter and timer drivers.
You can find it's documentation here: https://docs.zephyrproject.org/latest/reference/peripherals/counter.html
Since interest of mfd is to serve multiple drivers, it would be valuable to demonstrate it within this change. This is why it would be valuable in your PR to have both pwm and counter demonstrated as timer-mfd users.

I don't see any particular issue with an MFD approach, just that the MFD subsystem should probably handle / provide tracking of the "child" devices.

I'm working on it. Something else came up.

In the Linux kernel, MFD is more aimed at devices which are able to fulfill multiple different device APIs at once (like an RTC which also provides an EEPROM). As I read this, the STM32 timers are able to fulfill only one out of many possible device APIs/roles at a time?

@henrikbrixandersen I hear what you are saying, it's more like a base for all timer based drivers.
The ST timer is a base for multiple drivers, but I'm not sure if it could do more than one function at a time. It could trigger the DMA.
I have made a quadrature decoder, and I realised it was a near copy of the PWM driver.
Then I implemented a capture interface, again a near copy of the PWM driver.
So I needed a base driver, because there were more features I needed, e.g. HALL driver and PWM outputs for motor control. A timer could also be used to sync USB timings by receiving a SOF event. Same goes for the SAI driver.
Currently the PWM driver holds the complete timer instance, and a driver couldn't be written without kernel modification.
I was not planning to modify the PWM api, as the way Linux implements several features for the timer driver (capture, encoder, hall). But I was stuck using the current implementation.
Suggestions are welcome.

Suggestions are welcome.

@maxvankessel I am currently implementing quadrature decoder, frequency counter and pulse width measurement support atop of the NXP FlexTimer. What I have done so far is to use different device tree bindings per function, but this too feel wrong (the devicetree should describe the hardware, not the software configuration of the hardware). I too have a bit of duplicated code between the various drivers utilizing the FlexTimer, but it's not too much, I think.
A common approach to this problem (one device instance, different drivers on top) within Zephyr would be nice. IMO, this should be taken into consideration in the current devicetree rework effort. /cc @galak.


backward compatibility

Hi,
I found this component very useful for our project but at present we are on angular 5 and have no plans to update.I was just wondering the same github project can be made backward compatible or if you have any archives of the same project done in angular 5 it would be helpful.

Hi @muhmadtabrez,
Unfortunately, we never released a version for Angular 5. You can use<EMAIL_ADDRESS>for Angular 4 and<EMAIL_ADDRESS>for Angular 6.
Keep in mind that these versions are outdated and may contain bugs that were fixed later.


Enable qemu support for libvirt and add related dependencies

Libvirt requires yajl libs during the build for qemu support.
Currently it's silently built w/o it since it's not requested
explicitly. This commit adds yajl-devel package to dependencies
and requires qemu support.
Also adds recommended runtime dependencies (ebtables, dnsmasq, dmidecode).
Closes: #1836
Signed-off-by: Andrii Ostapenko<EMAIL_ADDRESS>
Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

[*] The toolchain has been rebuilt successfully (or no changes were made to it)
[*] The toolchain/worker package manifests are up-to-date
[*] Any updated packages successfully build (or no packages were changed)
[*] Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
[*] All package sources are available
[*] cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/tools/cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
[*] LICENSE-MAP files are up-to-date (./SPECS/LICENSES-AND-NOTICES/data/licenses.json, ./SPECS/LICENSES-AND-NOTICES/LICENSES-MAP.md, ./SPECS/LICENSES-AND-NOTICES/LICENSE-EXCEPTIONS.PHOTON)
[*] All source files have up-to-date hashes in the *.signatures.json files
[*] sudo make go-tidy-all and sudo make go-test-coverage pass
[*] Documentation has been updated to match any changes to the build system
[*] Ready to merge

Does this affect the toolchain?

NO
Associated issues

#1836

Test Methodology

Pipeline build id: local build

Is there a pressing reason to target 1.0 with this? Would likely be simpler to just target 2.0 (aka main branch) and avoid the cherry-pick forward.

Closing this PR due to inactivity.  Note that many of these changes appear to be integrated into Mariner 2.0.  Feel free to open a new PR against the main branch if further changes are required to support qemu with libvirt


Is designer the charter, and the artist the music artist, or is it swapped?

I'm confused.

Yes, designer is the charter and artist is the music artist

ok thanks :D


Make reals npm packages (web/react/angular)

Packages available at :

https://www.npmjs.com/package/@geovistory/design-system-web
https://www.npmjs.com/package/@geovistory/design-system-angular
https://www.npmjs.com/package/@geovistory/design-system-react


Fix bug: cannot run unit tests

The instrumentation code that solidity-coverage adds to files that declared/defined modifiers in interface (IAllowlistedAdminRole.sol, IAllowlistedRole.sol, IBlocklistedAdminRole.sol, IBlocklistedRole.sol) is not declared so it cause out error.
I fixed bug that I have reported at #135.
Please review it! Thanks.

I have read the CLA Document and I hereby sign the CLA

I have read the CLA Document and I hereby sign the CLA


[develop] Evaluate lookup selectors

This is the counterpart to https://github.com/MinaProtocol/mina/pull/13699, via https://github.com/o1-labs/snarkyjs-bindings/pull/95.

Changing base to develop as discussed with @mitschabaude. There is a missing PR for the develop counterpart of https://github.com/o1-labs/snarkyjs/pull/1047, which is include in this PR.


ENH: Remove dropna from beta function

Sometimes returns have an np.nan value which causes beta to return np.nan. In the case that either contains np.nan, calculate covariance of only those dates that have both returns and benchmark return values.

======================================================================
FAIL: test_max_drawdown_transformation_1 (empyrical.tests.test_stats.TestStats)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/travis/miniconda/envs/testenv/lib/python3.5/site-packages/nose_parameterized/parameterized.py", line 365, in standalone_func
    return func(*(a + p.args), **p.kwargs)
  File "/home/travis/build/quantopian/empyrical/empyrical/tests/test_stats.py", line 188, in test_max_drawdown_transformation
    assert constant*max_dd <= transformed_dd
AssertionError
======================================================================
FAIL: test_max_drawdown_transformation_4 (empyrical.tests.test_stats.TestStats)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/travis/miniconda/envs/testenv/lib/python3.5/site-packages/nose_parameterized/parameterized.py", line 365, in standalone_func
    return func(*(a + p.args), **p.kwargs)
  File "/home/travis/build/quantopian/empyrical/empyrical/tests/test_stats.py", line 190, in test_max_drawdown_transformation
    assert constant*max_dd >= transformed_dd
AssertionError

These seem unrelated, but why are we getting them?

PR looks good to me. Would be good to have a test with nans here.


Need training code

Thanks for your code! Is the performance of pytorch version comparable to the original TF one? Could you please provide code for data loading and training?

me too

me too

me too


Improve FAQ re: Docker for Windows and Windows/Linux containers option

Problem description
Some feed back on your FAQs page based on work we have been doing, specifically implementing a Linux based container on Windows Server 2016 (containers which run very successfully on Windows 10) .
Your FAQs page at: https://docs.docker.com/engine/faq/ states that:
Does Docker run on Linux, macOS, or Windows?
The Docker Engine client runs natively on ... Windows. By default, these clients ... provide the required features to run Linux-based containers within ... Windows, or Windows-based containers on Windows.
It this 100% correct?  Is it 100% clear?
What's that "or" doing there and what does it imply ... that we can run either Linux based containers OR Windows-based-containers on Windows? Should this be an "and"?
Specifically, what about Linux containers running on Windows Server 2016?
At best, this does not appear to be straightforward ... an indication to this effect (assuming it is true?) and a link to recommended approaches would be very valuable.
In summary, there seems to be a significant difference between the implementations for Windows-10 and Windows Server 2016 that I think is not clear in the FAQs as they stand, and that could be usefully added.
Related
@friism @ncbateman filed this issue as an email

Duplicate of #4264


docs: add Pull Request Template

Checkbox is updated so it will reflect as expected.
fixes: #91
related to: #2708
Signed-off-by: ruzell22<EMAIL_ADDRESS>

Hello @jagpreetsinghsasan @petermetz , pushed a changed and the md file is now displaying the checkboxes as expected.
https://github.com/ruzell22/cactus/blob/prtemplate91/PULL_REQUEST_TEMPLATE.md

@petermetz noted on that Peter, thank you. I have updated the commit message with [skip ci] .


ThinkTime test route /think/async fails with KituraNIO

ThinkTime test with the route /think/async crashes in Kitura-NIO.
The crash is because the thread that initiated the I/O task is not the same thread that performs the I/O operation.  ie, the current thread that tries to perform the operation is not as the same thread that was tied with EventLoop.
Hence we must ensure that we perform the I/O task on the same thread or we submit the task to be executed to the EventLoop.

PR : https://github.com/IBM-Swift/Kitura-NIO/pull/64

@nethraravindran Can you provide a description of the bug please?

#64 merged. Thanks @nethraravindran


ddp_cpu breaks while lookinf for .module: ModuleAttributeError: 'BoringModel' object has no attribute 'module'

🐛 Bug
https://colab.research.google.com/drive/1hMW-0sTTgK-r6xfdwuSDyRNJBH7YYm9V?usp=sharing
To Reproduce
Set num_processes=2 in the trainer (without accelerator="ddp_cpu"`). I know this is an invalid combination but a user of my library got confused with the error.
/usr/local/lib/python3.6/dist-packages/pytorch_lightning/utilities/distributed.py:45: UserWarning: num_processes is only used for distributed_backend="ddp_cpu". Ignoring it.
  warnings.warn(*args, **kwargs)
GPU available: True, used: False
TPU available: False, using: 0 TPU cores
/usr/local/lib/python3.6/dist-packages/pytorch_lightning/utilities/distributed.py:45: UserWarning: GPU available but not used. Set the --gpus flag when calling the script.
  warnings.warn(*args, **kwargs)

---------------------------------------------------------------------------

ModuleAttributeError                      Traceback (most recent call last)

<ipython-input-12-1f9f6fbe4f6c> in <module>()
----> 1 test_x(tmpdir)

4 frames

/usr/local/lib/python3.6/dist-packages/torch/nn/modules/module.py in __getattr__(self, name)
    770                 return modules[name]
    771         raise ModuleAttributeError("'{}' object has no attribute '{}'".format(
--> 772             type(self).__name__, name))
    773
    774     def __setattr__(self, name: str, value: Union[Tensor, 'Module']) -> None:

ModuleAttributeError: 'BoringModel' object has no attribute 'module'

Expected behavior
The property num_processes is ignored as mentioned in the warning:
UserWarning: num_processes is only used for distributed_backend="ddp_cpu". Ignoring it.
Environment

CUDA:

GPU:

Tesla T4

available:         True
version:           10.1

Packages:

numpy:             1.18.5
pyTorch_debug:     False
pyTorch_version:   1.6.0+cu101
pytorch-lightning: 1.0.0
tqdm:              4.41.1

System:

OS:                Linux
architecture:

64bit

processor:         x86_64
python:            3.6.9
version:           #1 SMP Thu Jul 23 08:00:38 PDT 2020

Thanks for the issue! Want to submit a fix?

I took a shot at it, but realized this is part of a larger issue.
There is not much documentation about what are the supported uses for num_processes (other than ddp_cpu). Looking at the code, it seems like the following accelerator values can use num_processes>1:

None: What does it default to? Execution goes through here: https://github.com/PyTorchLightning/pytorch-lightning/blob/ebe3a31ddd82c616df6612cb880b0b3b13b9ecde/pytorch_lightning/accelerators/accelerator_connector.py#L301-L306 with the comment suggesting that ddp_cpu is used but that does not seem to be the case.
ddp_spawn: with a very brief mention in the docs
ddp: Another brief mention here. For the previous two, execution goes through here: https://github.com/PyTorchLightning/pytorch-lightning/blob/ebe3a31ddd82c616df6612cb880b0b3b13b9ecde/pytorch_lightning/accelerators/accelerator_connector.py#L325-L328
ddp_cpu: as expected

So the error reported in this issue refers to 1., but 2. also seems to fail. Here is one test to check (fails on master):
@pytest.mark.parametrize("accelerator", [None, "ddp_spawn"])
def test_trainer_num_processes_without_ddp_cpu(tmpdir, accelerator):
    trainer = Trainer(
        default_root_dir=tmpdir,
        weights_summary=None,
        logger=False,
        checkpoint_callback=False,
        progress_bar_refresh_rate=0,
        fast_dev_run=True,
        num_processes=2,
        accelerator=accelerator,
    )
    trainer.fit(EvalModelTemplate())

If what Im saying is correct, also means that this warning is wrong:
https://github.com/PyTorchLightning/pytorch-lightning/blob/ebe3a31ddd82c616df6612cb880b0b3b13b9ecde/pytorch_lightning/accelerators/accelerator_connector.py#L99-L100
and should be updated/removed.
Hopefully someone can clear up what is the expected behaviour and provide sensible warnings/errors as appropriate.
cc @s-rog @williamFalcon

@tchaton why was this labeled "wont fix"? is this not an issue?

This will probably get cleaned-up by the proposal here:

Closing in favor of #6090 which will clarify the accelerator arguments


When group is created, there are no owners nor members in it, although I added them using as ArrayOfStrings?

[Enter feedback here]

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: ff78b7f4-0927-27d0-0b1d-5bd00bb93d26
Version Independent ID: 321cb4f2-43a1-1732-e429-3432af07a511
Content: New-PnPMicrosoft365Group (PnP.Powershell)
Content Source: sharepoint/sharepoint-ps/sharepoint-pnp/New-PnPMicrosoft365Group.md
Service: sharepoint-powershell
GitHub Login: @pamgreen-msft
Microsoft Alias: pamgreen

Hello @mvanders
how are you?
Even though the PnP documentation articles are on this repository, I need to kindly redirect you to open PnP cmdlets issues/pull requests here, in that repository, where a member of the PnP community will be able to correct the article/review your inquiry with your feedback.
The documentation for PnP cmdlets is then synced from that repo into this one.
Thank you!

@get-itips Thank you very much for the contribution and sharing this explanation. @mvanders Hope this comment is helpful for you. If you see a documentation update is required, please feel free to open an issue for the same. We proceed here to close it. Thanks for taking out some time to open the issue. Appreciate and encourage you to do the same in future also.


Reset Stripe token when resubmitting order

Following up from https://github.com/opencollective/opencollective/issues/2747
When contributing with a new credit card, if the order is failing, we should reset the token so it's not reused if the user submit the form again with the same credit card.
That way we can avoid the error "You cannot use a Stripe token more than once".
I'm not able to find steps to reproduce the issue using Test Credit Cards from Stripe https://stripe.com/docs/testing.
Testing with 4000 0000 0000 0002 and making sure that the stripe token is refreshed before re-submitting should do the job.

@znarf I think I could fix this issue. Could I be assigned?

🏆 This issue was completed by @CanerSezgin
To claim the bounty please, as a recurring contributor, please simply add it to your next invoice to Open Collective Engineering https://opencollective.com/engineering/expenses/new  Please make sure to mention the ticket number in the invoice and in the expense title.
Note: because the complexity was simpler than expected, I'll kindly ask you to jump in if there is small follow up on it.


[BEAM-7899] Fix Python Dataflow VR tests by specify sdk_location

We forgot to explicitly set sdk_location for Python2 dataflow VR tests after moved them to test-suites/dataflow/py2. The default value build/apache-beam.tar.gz is still in use which is incorrect.
Following change should fix the failure.
+R: @udim

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Choose reviewer(s) and mention them in a comment (R: @username).
[ ] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

Run Python Dataflow ValidatesRunner

run python 2 postcommit

python2 postcommit passed https://builds.apache.org/job/beam_PostCommit_Python2_PR/55/.
PTAL @udim


add sdg chart titles

add sdg chart titles to the cached chart titles
updates chart titles to include a list of blocklisted dcs

Nice!
Can you expand the description with the motivation of this change? Specifically, call out how this behavior is different on UN SDG DC vs. main DC.

in case you missed this :)

Nice!
Can you expand the description with the motivation of this change? Specifically, call out how this behavior is different on UN SDG DC vs. main DC.

in case you missed this :)

oh yes, totally missed that, updated now!

thanks for the review!


Undo only works once

It's working for me

Actually it doesn't matter if it's duplicate or not.. I can only undo once. Either using Cmd+Z or the buttons (when the width is too small).
Chrome/macOS latests.

Can repro. Also redo doesn't work at all.

We need E2E tests :)


Add support for kurtosis Spark aggregate function

Spark uses Pearson's formula for calculating the kurtosis coefficient, which is m4 / (m2^2) - 3. Meanwhile, Presto employs the sample kurtosis calculation formula. The results from the two methods are completely different, necessitating the implementation of a separate ResultAccessor for Spark's kurtosis.
Spark's implement
https://github.com/apache/spark/blob/e22ddcbd852c95375d39fd6074627e1b5a91c6e7/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/CentralMomentAgg.scala#L333-L336

@Yuhta Hi, Jimmy. Could you help to review?

@liujiayi771 Can you run fuzzer on the new function to make sure corner cases is not blowing things up?

@Yuhta DuckDB uses the same sample kurtosis as Presto, but the calculation formula is different from Spark's, so the results cannot be compared. Perhaps we should ignore the comparison in the fuzzer test, just like we do with skewness.

@liujiayi771 You can supply a custom ResultVerifier or nullptr to skip the result verification for now.

@liujiayi771

DuckDB uses the same sample kurtosis as Presto, but the calculation formula is different from Spark's

It would be nice to start working towards building SparkQueryRunner (similar to PrestoQueryRunner) to allow Fuzzer to compare results with Spark.
CC: @rui-mo @FelixYBW @PHILO-HE

It would be nice to start working towards building SparkQueryRunner (similar to PrestoQueryRunner) to allow Fuzzer to compare results with Spark.

@mbasmanova We are prototyping SparkQueryRunner with ODBC as https://github.com/facebookincubator/velox/issues/6595#issuecomment-1829141664 proposed. Will update our status once it works, thanks.

Can you run fuzzer on the new function for like 20 min to make sure corner cases are not blowing things up?
I have tested 30min with the command below, and it did not generate any exceptions.

_build/debug/velox/functions/sparksql/fuzzer/spark_aggregation_fuzzer_test --seed 1234 --duration_sec 1800 --logtostderr=1

@rui-mo

We are prototyping SparkQueryRunner with ODBC as https://github.com/facebookincubator/velox/issues/6595#issuecomment-1829141664 proposed. Will update our status once it works, thanks.

That's great. Let's create a GitHub issue and post updates there. Do you have an idea about when this might be available?

That's great. Let's create a GitHub issue and post updates there. Do you have an idea about when this might be available?

We will prioritize the work.


Support for CodeBehind Binding (somehow)

I'm assuming that since the only things being rehydrated are the axaml and some parts related to it, then its expected that any code-behind binding done in the constructor inevitably gets discarded on hot reload.
The issue that arises from this is simply that it forces the use of Avalonia's MarkupExtension for all binding, which is pretty limiting and might be incompatible with a lot of projects.
I'm really not sure what would be the best option for handling this, I guess something as simple as an OnHotReloaded() event could be enough. It's a rather crude example, I don't quite know enough about what's going on inside to make a better suggestion at the moment. I'd be curious to hear what other possibilities might be viable.
Regardless, this library is absolutely incredible already :) thanks for the hassle-free productivity boost 👍

Big preesh on the kind words! They're always nice to hear!
Regarding the issue itself, I had a completely unhinged idea of rerunning a constructor (or at least parts of it) on its corresponding rehydrated component whenever a hot reload occurs. However, I quickly dismissed it, as it creates a host of other problems.
And I much prefer your suggestion of allowing users to explicitly opt-in for such behavior! I think an attribute would suffice since C# allows you to slap Conditional on top of the attributes, meaning they can be completely eradicated from the non-relevant environments (like production), thus avoiding unnecessary metadata pollution. It should also be pretty straightforward for users:
  public FooControl()
  {
    InitializeComponent();
-   DoSomething();
+   Initialize();
  }

+ [HotReload]
+ private void Initialize()
+ {
+   DoSomething();
+ }

How does that sound?

How does that sound?

Wonderful!
Sorry for the late reply, but yes this does sound like a perfect way of doing things.
Looking forward to hearing more about it😄


Hello i need some help

Problem encountered on https://dotnet.microsoft.com/learn/dotnet/hello-world-tutorial/install
Operating System: windows
Provide details about the problem you're experiencing. Include your operating system version, exact error message, code sample, and anything else that is relevant.
I dont know what to do .Net dosent work
Keeps showing me this

Hi @MRGODUP! Did you click on the install SDK button on the tutorial? Can you run dotnet --info so we can see what you have installed? It seems you only have the runtime on your machine.

Hi @MRGODUP! Did you click on the install SDK button on the tutorial? Can you run dotnet --info so we can see what you have installed? It seems you only have the runtime on your machine.

Found the problem i dident install the SDK  Anyways ty for the help

Given this is a common issue here, I'd love to understand how you ended up installing the runtime even though the tutorial points directly to the latest SDK. Can you help me to understand? This could help other customers that end up in a similar situation.

Given this is a common issue here, I'd love to understand how you ended up installing the runtime even though the tutorial points directly to the latest SDK. Can you help me to understand? This could help other customers that end up in a similar situation.


Issues with RHEL7 repos configuration

Hello,
On my RHEL7 releasever is set to 7Server:
# python -c 'import yum, pprint; yb = yum.YumBase(); pprint.pprint(yb.conf.yumvar, width=1)'
Loaded plugins: langpacks, rhnplugin
This system is receiving updates from RHN Classic or Red Hat Satellite.
Repository 'local' is missing name in configuration, using id
{'arch': 'ia32e',
 'basearch': 'x86_64',
 'releasever': '7Server',
 'uuid': '20a2ac23-07d1-4d8a-9ae9-7fd280a712e6'}

And Zabbix repo is configured as:
# grep base /etc/yum.repos.d/Zabbix_7_x86_64.repo
baseurl=http://repo.zabbix.com/zabbix/2.4/rhel/$releasever/$basearch/

But that URL doesn't exist, just http://repo.zabbix.com/zabbix/2.4/rhel/7/ and yum is looking for http://repo.zabbix.com/zabbix/2.4/rhel/7Server/
Workaround that worked for me, but no idea if it will break something else:
diff --git a/manifests/repo.pp b/manifests/repo.pp
index 4ae59f0..1f69f8d 100644
--- a/manifests/repo.pp
+++ b/manifests/repo.pp
@@ -40,7 +40,7 @@ class zabbix::repo (
         $reponame     = $majorrelease
       }
       default       : {
-        $majorrelease = '$releasever'
+        $majorrelease = $::operatingsystemmajrelease
         $reponame     = $::operatingsystemmajrelease
       }
     }

That is exactly what I had to do to patch this issue with RHEL as well. Thanks for posting this, @kuduka

I believe I had fixed this a while ago. Which version of the puppet module you are using right now?

I'm using your master version and 2.1.1 tag, same issue on both.

I saw the issue on master and at 2.1.1 as well.

I just pushed an fix for this. Would you please validate it?

At @dj-wasabi dj-wasabi, should we work on a validation check in the commit for this? or you think it's probably solved and wont happen again, im surprised it didn't get picked up on build test

@ericsysmin Me too.
This weekend I try to release 2.2.0, so this fix will be in it.

Fix worked for me with 2.2.0 tag, thank you!
grep baseurl /etc/yum.repos.d/Zabbix_7_x86_64.repo
baseurl=http://repo.zabbix.com/zabbix/2.4/rhel/7/$basearch/

sweet! @dj-wasabi  lets close this :+1:

Was able to install the 2.2.0 module today, worked as expected. Sorry for the delay in reporting back!

Nice! Will close this ticket!


can not bundle project and server into wgt.

Previously I used Tizen studio and it generate wgt file with all content in it. I recently migrated an app from react-native to renative and am done with the final changes for the TIZEN TV app. I am able to run and debug app on real device. But when i tried to install WGT using sdb, it is not working on tizen because it is not able load server files from my mac machine.
App is not completely bundled into WGT file.
I tried other rnv commands like package deploy etc but none of it creates wgt or (tpk not sure)? I am aware of it that we can provide url of our web content in wgt and it works fine even in production. BUT how can i publish RNV app to production?
I also tried to import tizen output folder to tizen studio but again index.js is having url form local-ip-server which is then targeting to target.js => which is not even present in created project.
I hope somebody understands the question and responds. Thanks in advance.

the development app has an "app shell", which is nothing but a simple HTML with a redirect after 5s to your development machine that is running a webpack-dev-server, for easy development and hot reloads. That's why you don't see your app inside the output. You should be able to produce a production build with rnv export

Yes correct this is what i thought first.

I have done a workaround, that is copy content from server folder into tizen studio project and created WGT file from tizen studio.

I was also stuck on this for a while. In the end, I found out that I can produce a release version of .wgt by using rnv build -p tizen -s release. We should add this into docs.

updated the docs

Althouh i crea


Add many-to-many transformation

It does so by automatically decomposing a Bundle with merge=False in one Bundle for
each file.
Example:
environment.register(
	'styles', '*.scss',
	merge=False, filters='scss',
	output='build/%(name)s.%(version)s.css'
)

wil be transformed to
environment.register(
    'styles/file1.scss', 'file1.scss',
    filters='scss',
    output='build/file1.%(version)s.css'
)
environment.register(
    'styles/file2.scss', 'file2.scss',
    filters='scss',
    output='build/file2.%(version)s.css'
)
environment.register(
    'styles/file3.scss', 'file3.scss',
    filters='scss',
    output='build/file3.%(version)s.css'
)

When merge is False in addition to %(version)s you can use the placeholders:

%(name)s (the name without the original extension)
%(path)s (path and filename without extension) and
%(ext)s (just the extension)

I know this took a long time. I am wary of merging complex changes because I don't have the time to review them, but this seemed pretty good and is a useful feature. Thanks!


Project incorrectly packaged with .blend1 files (uncommitted)

Try putting the blend files in a folder with a tilde so that it doesn't get included


More colormapping for segmentation visualization

Right now, #88 only adds VOC's colormapping. We should add:

ade20K
coco
cityscapes

https://github.com/tensorflow/models/blob/master/research/deeplab/utils/get_dataset_colormap.py


Crafthead retrieves old skin instead of the newer one

I'm using crafthead with essentialsx discord and I noticed that crafthead retrieves my old skin, if I use mojang apis, it retrieves the newer one
Old image:

New image:

Yikes - turns out this was because during some refactoring I forgot to add TTLs to the Cloudflare KV that we use as the primary cache for Crafthead.
In 4581cb7c33612ed4de6c632b224ce21d79b263f4 I've added in expiry (it will now expire 24 hours after fetch). I have also purged the live production cache, so your skin should now be visible.