[UI Improvement] : The login page may need a few css changes.

🔖 Feature description
The login page definitely needs a few UI improvements.
Something like this one...

🎤 Why is this feature needed ?
The login page, as for now looks like this..

And will look good after the design improvement.
✌ How do you aim to achieve this?
By changing a few CSS properties and adding some new ones.
🔄 Additional Information
No response
👀 Have you spent some time to check if this feature request has been raised before?

[X] I checked and didn't find a similar issue

🏢 Have you read the Contributing Guidelines?

[X] I have read the Contributing Guidelines

🏢 Have you read the Code of conduct

[X] I have read the Code of conduct

Are you willing to submit PR?
Yes I am willing to submit a PR!

Assign this issue to me, Let me fix this

yeah I can improve this login page ,assign it to me plz for hacktoberfest

thank you guys, please send a PR ❤

We split up the work and deliver together @Nexusrex18 ?

I was facing an error, but anyway, if @arun0452 has already started work. @Nexusrex18 you guys continue.
I'm unassigning myself.


Chrome on travis

#patch#
Also includes fix for chrome. Plus ignore svgExperimental on Chrome cause it works.
Only downside is you have to use Chromium in Testem rather than Chrome. So you have to remove it on Mac OS X. But totally worth it for Chrome on Travis

Visual Acceptance tests:
No changes

Approved - the one complication here is that we switch off Chrome to FireFox because we were having issues with ember-cli-blanket on Chrome, so we'll need an updated solution to that.  We can either fix ember-cli-blanket, or more ideally get ember-cli-code-coverage to work with addons/engines.  I'd vastly prefer the second option.  I'll get you and @srowhani in contact with @rwjblue and we can see what can be done to help land a PR for that feature.


Migration timestamps() should useCurrent() and useCurrentOnUpdate()

Laravel Version: 9.x
PHP Version: 8.1
Database Driver & Version: MySQL

Description:
Maybe not particularly a bug, but when creating migrations and using the $table->timestamps(), the current definition from the Illuminate\Database\Schema\Blueprint class is;
    /**
     * Add nullable creation and update timestamps to the table.
     *
     * @param  int  $precision
     * @return void
     */
    public function timestamps($precision = 0)
    {
        $this->timestamp('created_at', $precision)->nullable();

        $this->timestamp('updated_at', $precision)->nullable();
    }

The timestamp columns usually get nicely handled by eloquent when you're dealing with a single model instance.
In my opinion, I think this implementation completely assumes that the table will always have an eloquent model and that Eloquent will always handle the timestamps that go in there.
Even with Eloquent, those timestamp columns however don't get updated when you do mass inserts/updates/upserts/deletes. For example;
User::where('status', true)->update(['status' => false]);

Also, if for some reason, I were to write some quick custom query directly in MySQL CLI, I'd expect that those columns get handled internally by MySQL.
My Proposition
What I think that the $table->timestamps() should be doing internally is something like;
    /**
     * Add creation and update timestamps to the table.
     *
     * @param  int  $precision
     * @return void
     */
    public function timestamps($precision = 0)
    {
        $this->timestamp('created_at', $precision)->useCurrent();

        $this->timestamp('updated_at', $precision)->nullable()->useCurrentOnUpdate();
    }

Notice that created_at isn't nullable, since in fact, every DB row must be created and of course should have a creation timestamp.
This way, when eloquent is not involved, mysql can handle it internally. (PS: I know there may some timezone considerations, but that's a different topic).
Off course, I can easily use the methods useCurrent(); and useCurrentOnUpdate(); provided by the Illuminate\Database\Schema\Blueprint class in my migrations or make my own macro to wrap the definitions, but it usually feels better to use built-in methods than creating custom ones.
I hope all of this makes any sense at all.

This would make it very difficult to temporarily disable timestamps when working with Eloquent models. For example, you might have a User model which records a last_login_at timestamp. Without timestamps being enforced at the database level, you can write:
$user = Auth::user();
$user->timestamps = false;
$user->last_login_at = now();
$user->save();

This updates the last_login_at field, but without modifying updated_at. You might want to do this if you have application logic which checks the updated_at column to see the last time a user changed their account settings, for example.
I guess adding a new timestampsWithUpdates() function would be a better approach than modifying the existing timestamps() default.

@JackWH  valid point for the updated_at field!
But with your example, it then means the updated_at field is not actually a source of truth. Because ideally, when you do $user->last_login_at = now(), you have actually updated the row, and your updated_at field should reflect that change, else the table isn't idiot-proof.
How about the created_at field? I suppose you can only create a DB row once, and that timestamp remains forever unchanged.

The useCurrent() method does not honor the timezone of application, does not fire eloquent model events either

This is a feature request. I don't think we'll take any action here at the risk of breaking changes.


Fix/refactor java sdk step 1

Refactored as follows:

add getters + setters to all fields
mark all public fields as Deprecated
Remove 'I' prefix for all interfaces
extract interfaces for all service classes. This will allow customers to proxy the services, to
efficiently apply aspects, etc. The interfaces will replace the actual services, keeping backwards
compatibility. Implementations will be in different package, with some 'Impl' suffix.
change field names from _hungarian_notation to camelCase. I saw that all are internal SDK
fields, so we will change them directly, in one step. (did not change fields in OAuthToken, as this resulted in serialization errors.)

rename the extracted interfaces from ApiUsers to UsersClient (Apply same convention to all client interfaces)
from MangoPayApi class, rename client getters from getUsers() to getUsersClient() (Apply same convention to all getters). Also apply it for all the setters

Thanks @eusuntpetri and @catacraciun for all of this !


How to disable the OpenAI initialization when you're not using an OpenAI model

Feature request
how to disable the OpenAI initialization when you're not using an OpenAI model.
Please check this issue
Motivation
I am trying to build a VectorstoreIndexCreator using the following configuration
embeddings= SentenceTransformerEmbeddings embeddings
vectorstore_cls = Chroma
llm = HuggingfaceHub Model
Note: I am not using any openai model as llm or embedding purpose
here is the code
  from langchain.indexes import VectorstoreIndexCreator
  from langchain.vectorstores import Chroma
  from langchain.text_splitter import CharacterTextSplitter
  from langchain.embeddings import SentenceTransformerEmbeddings
  from langchain.llms import HuggingFaceHub
  from langchain.document_loaders import PyPDFLoader
  loader = PyPDFLoader("pdffile.pdf")

  embeddings =  SentenceTransformerEmbeddings(model_name="paraphrase-MiniLM-L6-v2")
  model = HuggingFaceHub(repo_id="facebook/mbart-large-50",
                       model_kwargs={"temperature": 0, "max_length":200},
                       huggingfacehub_api_token=HUGGING_FACE_API_KEY)
  index = VectorstoreIndexCreator(
                                  embedding=embeddings,
                                  vectorstore_cls=Chroma,
                                  text_splitter=CharacterTextSplitter(chunk_size=100,chunk_overlap=0)
                                  ).from_loaders([loader])
  result = index.query(llm=model,question=query,chain_type="refine")

But still iam getting the open_ai key dependency error when i run the code
Did not find openai_api_key, please add an environment variable `OPENAI_API_KEY` which contains it, or pass  `openai_api_key` as a named parameter. (type=value_error)

using langchain version: langchain==0.0.219
Your contribution
To disable the OpenAI initialization when you're not using an OpenAI model

Any work around for this? I'm also running into same issue.

From what I understand, as long as we are using Chroma we can't disable OpenAI since it runs remotely on their servers?

Chroma provides a convenient wrapper around OpenAI's embedding API. This embedding function runs remotely on OpenAI's servers, and requires an API key. You can get an API key by signing up for an account at OpenAI.

https://docs.trychroma.com/embeddings/openai
I would like to prevent this as well, but I believe it is a hard dependency from what I understand of it.


how to done password validation in react-redux-form

The Problem
Steps to Reproduce
Expected Behavior
Actual Behavior
Reproducible Code Example
(please fork from this CodePen template or this CodeSandbox template)

how  to compare values of two models in react-redux-form?


Harmonized World Soils Database version 2.0

Harmonized World Soils Database version 2.0

To access on Linux:
https://github.com/mdbtools/mdbtools
mdb-tables HWSD2.mdb
then to export a table to csv
mdb-export HWSD2.mdb TABLE > /path/to/output.csv

data associated with each SMU can be complex, need to decide what we actually want to provide (e.g., dominant soil type vs other soil types vs other characteristics of each SMU). Each would have to be a separate layer if providing more than one metric


updated readme for private endpoint

Signed-off-by: Nitish kulkarni<EMAIL_ADDRESS>

:tada: This PR is included in version 0.1.5 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


@deprecated tag

Search Terms
@deprecated, jsdoc, typedoc, vs code, vscode
Problem
I am contemplating moving from JSDoc to TypeDoc, but could not find if you support a @deprecated tag. It would be a nice additon. E.g. VS Code can infer a lot form this tag and cross-over text for deprecated methods etc.
Suggested Solution
Support the @deprecated tag.

isn't this a duplicate of #1381?

So it is, thanks!


CJK characters are corrupted

I'm a Japanese.

Same with cyrillic characters, I'm pretty sure any non-ASCII symbols are broken. Hope developers will improve broadcasting soon, it is very limited right now.

Thank you for information.
As a workaround, I escaped string with uconv
https://github.com/miscord-dev/palog/pull/7


Fixes #162

#162

Out of curiosity, does zig cc not use ming64 includes? MinGW64 should be compatible with MSVC CRT, as such I'd expect it to expose fseeki64, see https://github.com/Alexpux/mingw-w64/blob/master/mingw-w64-crt/stdio/fseeko64.c#L133

Yes, zig cc uses mingw64. But, it looks like zig version of the fseeko64.c file does not contain _ftell64i function. See: https://github.com/ziglang/zig/blob/master/lib/libc/mingw/stdio/fseeko64.c

Interesting, so their version has some parts of the library that are normally unique to MSVC CRT, but missing this one specifically. Thanks!

@zeux  In mingw-w64 9.0.0 (latest) implementation of _ftelli64 has been moved to fseeki64.c file. But, zig does not include this file at all.

I have submitted a PR to Zig which adds those functions. See: https://github.com/ziglang/zig/pull/9766
So, I guess we can close this PR.


Change data-decoder E2E test data payload

Changes

Changes data-decoder E2E test data payload for a simpler one.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 48.265%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
4259

Relevant Lines:
7095

💛  - Coveralls


does explainshell have a place in here?

if so, let's add it!
(https://explainshell.com/)

some of the utils listed
+ https://github.com/idank/explainshell/issues/241
shore do !
eg
https://github.com/idank/explainshell/issues/4#issuecomment-71395039


[zk-sdk] Flatten out arguments for ciphertext validity proofs

Problem
In the ciphertext validity proofs, the argument variables to functions are grouped into tuples that are related to each other. It was done this way to tidy things up in the beginning, but it actually seems to make the syntax a lot more messy.
Summary of Changes
Flatten out the argument variables as was also done in https://github.com/anza-xyz/agave/pull/1084.
Fixes #

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 82.1%. Comparing base (9403ca6) to head (343682b).

Additional details and impacted files
@@            Coverage Diff            @@
##           master    #1134     +/-   ##
=========================================
- Coverage    82.1%    82.1%   -0.1%
=========================================
  Files         880      880
  Lines      235665   235633     -32
=========================================
- Hits       193716   193662     -54
- Misses      41949    41971     +22


Fix EKS chart installation

Fix https://github.com/clastix/kamaji/issues/186
Test on an EKS cluster, took inspiration from https://github.com/helm/helm/issues/8113#issuecomment-1312455197

I see that in https://github.com/clastix/kamaji-etcd/blob/master/charts/kamaji-etcd/Chart.yaml#L28 you just do a >= comparison

Let's avoid the upper limit, there's no need for that.


Uri object does not implement league/uri-interfaces' UriInterface

Bug Report
Declaration of League\Uri\Uri::withScheme($scheme): League\Uri\Contracts\UriInterface must be compatible with League\Uri\Contracts\UriInterface::withScheme(?string $scheme): League\Uri\Contracts\UriInterface

Information
Description

Version
6.2

PHP version
7.3

OS Platform
OSX

Summary
String parameters of method withXXX() such as withScheme or withUser are not explicitely specified in league/uri concrete class as they are supposed to in the relative interface.
Standalone code, or other way to reproduce the problem
Uri::createFromString('random valid URI')
Expected result
Should not throw a fatal error
Actual result
Throws a fatal error.

Tried to push a branch with a fix but it seems I can't push to the repo. :(

@ChargemapHakan this is not a bug but an expected behaviour in PHP please review https://blog.kelunik.com/2018/01/23/parameter-type-widening.html for more informations

Hi ! Well sorry, somehow I ended up composer updating with PHP 7.3 and testing my code with php 7.1... Anyway, thanks for your quick reply and sorry for the useless bug report !


Send token /login

Hey, I'm trying to understand how the thing works, and it would be really cool, and useful for newer programmers if you could write a small documentation, maybe link to key words etc. Also would be amazing if you'd make a small example where /login: returns the token to the user.

Hi, this library provides only middleware for processing requests with JWT token and small permission helpers. It does not provide functionality for login and obtaining token, if i got your question right.

I see, I guess i got a bit confused with the @login_required

As login mechanism vary from project to project it is hard to come with good unified solution for all flows. But you can try aiohttp-security or aiohttp-login for your needs to provide user auth facilities.

https://steelkiwi.com/blog/jwt-authorization-python-part-1-practise/
may be helpful

Closing for now, feel free to re-open if necessary.

Yeah, I read the code, good work, Thank you! And thanks for the tips!


create the partition soon after installing the as3

Please help to review the logic at first and I am working on the UT coverage now.


Editor-junction drag resizing from wrong pane junction

Issue Type: Bug
I have the "Explorer" pane open on the left, two editor-windows open in the middle (stacked vertically), and another open editor on the right.
 However when I try and drag the junction, the other junction (two vertical editors, and the editor on the right) moves instead. I can move the left pane by itself with the normal "horizontal-drag", and the two vertical panes by themselves with the "vertical-drag".
VS Code version: Code 1.47.3 (91899dcef7b8110878ea59626991a18c8a6a1b3e, 2020-07-23T13:12:49.994Z)
OS version: Windows_NT x64 10.0.18362

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-8565U CPU @ 1.80GHz (8 x 1992)

GPU Status
2d_canvas: enabledflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onoop_rasterization: disabled_offprotected_video_decode: enabledrasterization: enabledskia_renderer: disabled_off_okvideo_decode: enabledviz_display_compositor: enabled_onviz_hit_test_surface_layer: disabled_off_okwebgl: enabledwebgl2: enabled

Load (avg)
undefined

Memory (System)
15.87GB (4.01GB free)

Process Argv

Screen Reader
no

VM
0%

Extensions (19)

Extension
Author (truncated)
Version

xml
Dot
2.5.1

gitlens
eam
10.2.2

vscode-pull-request-github
Git
0.18.0

rainbow-csv
mec
1.7.1

snapcode
moy
1.1.0

vscode-docker
ms-
1.4.1

csharp
ms-
1.22.1

mssql
ms-
1.9.0

python
ms-
2020.7.96456

vscode-pylance
ms-
2020.8.0

remote-wsl
ms-
0.44.4

cpptools
ms-
0.29.0

powershell
ms-
2020.6.0

autodocstring
njp
0.5.3

vscode-yaml
red
0.9.1

vscode-sort-json
ric
1.18.0

cython
tcw
0.1.0

sort-lines
Tyr
1.9.0

vscode-icons
vsc
10.2.0

(2 theme extensions excluded)

Can you please provide a screen recording?

@joaomoreno I have not seen this since I filed this ticket. I closed and reopened vscode and the bug went away.


Error span displayed around unicode characters in code

I having a strange issue that I can't seem to work around. When I use unicode characters in code blocks, there's a red box drawn around them with a span.err class. I can't seem to remove them using a custom css, and converting the notebook to html, stripping the class, and then to PDF produces something that doesn't look so good (issue with converters).
Is there anything that can be done to fix how this is rendered?

Dup of https://github.com/JuliaLang/IJulia.jl/issues/308


Document new settings for TCP listener(s) and IPv6 support

Summary
Documenting the new settings we are planning to include in the next version, namely:

TCP Server Address and TCP Server Port

To configure the listener(s) to generate TCP candidates.

Enable IPv6

To enable experimental support for dual-stack connectivity.

Ticket Link
https://mattermost.atlassian.net/browse/MM-50294
https://mattermost.atlassian.net/browse/MM-52268

@streamer45 - Is this docs PR intended for the v8.0 release?

@streamer45 - Is this docs PR intended for the v8.0 release?

@cwarnermm Yes, they can be merged any time I suppose.


Use drag item in combinaison with Flickity handle

Hi, I am trying to use a drag item with Flickity (https://flickity.metafizzy.co). Do you have an idea as how I could bind the drag of the item with the drag of the slider?
Basically I want the custom handle in Flickity to be the draggable element setup with PlainDraggable. If you see in the JSFiddle bellow, the gray square is the custom handle that is used to switch slides in Flickty on drag.
Here is a basic slider with a custom handle and the draggable item.
https://jsfiddle.net/1unbwmja/10/
Thanks

Hi @yepecece, thank you for the comment.
You can get the handle element and pass it to PlainDraggable.
new PlainDraggable(document.querySelector('.custom-handle'))

However, that element is already able to be draggable by Flickity, you don't have to use PlainDraggable.
Sorry, I couldn't understand what you want to do and why you use PlainDraggable well.

I see.
If you want to add a handle, you can do that easily because you can control the Flickity by using its APIs.
For example:
https://jsfiddle.net/7kyznh43/

Thanks. Great libraries by the way.

:smile:


Addressing Concurrency Issues In Application class

As alluded to in #22, there are going to be a bunch of issues needed to address concurrency issues that are causing a wide variety of sporadic and nondeterministic problems at runtime and in unit tests, with increasing frequency.
The changes necessary to fix them are not terribly difficult, and they happen to also overlap to a pretty significant degree with work I am already doing on other branches, such as the event handling refactoring.
This is more critical to be tackled first, for a lot of reasons, so I'm starting with where I was already working on null fixes: the Application class and types it directly interacts with.
More to follow....

Closing as abandoned.
This is still important, but it's not the time to be doing this, right now.


parentheses bug

This code:
$this->seeder->status = 'cart';
list($order, $promo) = ($this->seeder)->createFullOrder('', [], [], []);

gives me this this error :

Http/Controllers/Backend/Admin/HomeController.php (align_equals)
when I run this:
vendor/bin/php-cs-fixer --dry-run -v fix

But when I run:
vendor/bin/php-cs-fixer fix
error is not fixed.....
I fixed problem when I edit code to be like:
$this->seeder->status = 'cart';
list($order, $promo) = $this->seeder->createFullOrder('', [], [], []);

without parentheses ...

What does it mean "gives me this error" ? provide full CLI command and whole output.
Also, this would be nice as well:
php --version
php-cs-fixer --version
cat .php_cs
cat .php_cs.dist

?

I think what he means is that fixer keeps saying it made a change to the file over and over?

<?php

/*
 * This file is part of PHP CS Fixer.
 *
 * (c) Fabien Potencier<EMAIL_ADDRESS> *     Dariusz Rumiński<EMAIL_ADDRESS> *
 * This source file is subject to the MIT license that is bundled
 * with this source code in the file LICENSE.
 */

$this->seeder->status = 'cart';
list($order, $promo) = ($this->seeder)->createFullOrder('', array(), array(), array());

$ php -v
PHP 7.0.9-1+deb.sury.org~xenial+1 (cli) ( NTS )

$ php-cs-fixer -V
PHP CS Fixer version 1.12.0 by Fabien Potencier and Dariusz Ruminski (ddac737)

and
$ php php-cs-fixer -v
PHP CS Fixer version 1.12.1-DEV by Fabien Potencier and Dariusz Ruminski

no issues, so we need more info

ping @fico7489 please provide more info @ see https://github.com/FriendsOfPHP/PHP-CS-Fixer/issues/2172#issuecomment-245323481


fix: Allow Twig array filters to accept null

1. Why is this change necessary?
Currently the following (cached) code is generated, when using for example the Twig filter-filter (reformatted for some more readability):
$context['_seq'] = twig_ensure_traversable($this->extensions['Shopware\Core\Framework\Adapter\Twig\SecurityExtension']->filter(
    sw_get_attribute(
        $this->env,
        $this->source,
        sw_get_attribute($this->env, $this->source, sw_get_attribute(
            $this->env, $this->source, ($context["page"] ?? null), "cart", [], "any", false, false, false, 1
        ),
        "lineItems", [], "any", false, false, false, 1), "elements", [], "any", false, false, false, 1), function ($__lineItem__) use ($context, $macros) { $context["lineItem"] = $__lineItem__; return (sw_get_attribute($this->env, $this->source, $context["lineItem"], "type", [], "any", false, false, false, 1) == "promotion"); }
    )
);

This leads to the problem, that only twig_ensure_traversable converts null to an empty array, see: https://github.com/twigphp/Twig/blob/v3.8.0/src/Extension/CoreExtension.php#L1230-L1237 but this is only called after the filtering.
Also other Twig methods, like the length-filter, can work with null, see for example the following code, which would also yield an error:
$context["hasDifferentPrice"] = (
    twig_length_filter(
        $this->env,
        $this->extensions['Shopware\Core\Framework\Adapter\Twig\SecurityExtension']->filter(
            ($context["totalVariants"] ?? null),
            function ($__variant__) use ($context, $macros) { $context["variant"] = $__variant__; return (sw_get_attribute($this->env, $this->source, ($context["variant"] ?? null), "default", [], "any", false, false, false, 18) != null); }
        )
    ) > 0
);

2. What does this change do, exactly?
Also accept null as a valid value of the filters.
3. Describe each step to reproduce the issue or behaviour.
See above and in the tests.
4. Please link to the relevant issues (if any).
-
5. Checklist

[x] I have rebased my changes to remove merge conflicts
[x] I have written tests and verified that they fail without my change
[x] I have created a changelog file with all necessary information about my changes
[ ] I have written or adjusted the documentation according to my changes
[ ] This change has comments for package types, values, functions, and non-obvious lines of code
[x] I have read the contribution requirements and fulfil them.

6. Changes in older versions
This should probably also be changed in the security plugin and in the 6.5.x versions.

thanks for your contribution @aragon999  👍🎉💙


#277 IMWG_vignette: Add Vignette for ADRS Using IMWG Criteria

Thank you for your Pull Request! We have developed this task checklist from the Development Process Guide to help with the final steps of the process. Completing the below tasks helps to ensure our reviewers can maximize their time on your code as well as making sure the admiral codebase remains robust and consistent.
Please check off each taskbox as an acknowledgment that you completed the task or check off that it is not relevant to your Pull Request. This checklist is part of the Github Action workflows and the Pull Request will not be merged into the main branch until you have checked off each task.

[ ] Place Closes #<insert_issue_number> into the beginning of your Pull Request Title (Use Edit button in top-right if you need to update). Then the issue is closed automatically once it is merged to main.
[ ] Code is formatted according to the tidyverse style guide. Run styler::style_file() to style R and Rmd files
[ ] Updated relevant unit tests or have written new unit tests - See Unit Test Guide
[ ] If you removed/replaced any function and/or function parameters, did you fully follow the deprecation guidance?
[ ] Update to all relevant roxygen headers and examples
[ ] Run devtools::document() so all .Rd files in the man folder and the NAMESPACE file in the project root are updated appropriately
[ ] Address any updates needed for vignettes and/or templates
[ ] Update NEWS.md
[ ] Build admiral site pkgdown::build_site() and check that all affected examples are displayed correctly and that all new functions occur on the "Reference" page.
[ ] Address or fix all lintr warnings and errors - lintr::lint_package()
[ ] Run R CMD check locally and address all errors and warnings - devtools::check()
[ ] Link the issue so that it closes after successful merging.
[ ] Address all merge conflicts and resolve appropriately
[ ] Pat yourself on the back for a job well done!  Much love to your accomplishment!

The following line requests to update the man pages by the "Man Pages" workflow.
/roxygenize

The rendered version of the vignette is available at https://bundfussr.github.io/admiralonco/277_imwg_vignette/articles/adrs_imwg.html.

I have pushed a new commit.

Thanks for all comments. I have pushed a new commit.

@amitjaingsk , regarding checking for "many" "NE"s in a row we could use
filter_consecutive_vals <- function(dataset, by_vars, order, var, val, n) {
  var <- enexpr(var)
  var_join <- sym(paste0(as.character(var), ".join"))
  data <- derive_var_obs_number(dataset, by_vars = by_vars, order = order, new_var = temp_seq)

  left_join(
    data, select(data, !!!by_vars, temp_seq, !!var),
    by = admiraldev::vars2chr(by_vars),
    suffix = c("", ".join"),
    relationship = "many-to-many"
  ) %>% filter(temp_seq <= temp_seq.join & !!var == !!val) %>%
    filter_relative(
      by_vars = c(by_vars, expr(temp_seq)),
      order = exprs(temp_seq.join),
      condition = !!var_join != val,
      mode = "first",
      selection = "before",
      keep_no_ref_groups = TRUE,
      inclusive = FALSE
    ) %>%
    derive_var_merged_summary(
      dataset = .,
      dataset_add = .,
      by_vars = c(by_vars, expr(temp_seq)),
      new_vars = exprs(nr_vals = n())
    ) %>% filter(nr_vals >= n) %>%
    filter_extreme(
      by_vars = c(by_vars, expr(temp_seq)),
      order = exprs(temp_seq.join),
      mode = "first",
      check_type = "none"
    ) %>%
    select(-temp_seq, -temp_seq.join, -val.join)
}

# filter on three or more NEs in a row
many_nes <- filter_consecutive_vals(
  adrs,
  by_vars = exprs(STUDYID, USUBJID,
  order = exprs(ADTM),
  var = AVALC,
  val = "NE",
  n = 3
)

if (nrow(many_new) > 0) {
  cli_warn("There are subject with more than three NEs in a row")
}

I'm not sure where we should place it. Or if we should add it at all. Shouldn't the handling of the NEs be specified in the SAP and the ADaM specs?


Branch blank branch for v2.0

Create a new branch to use as "develop branch" for v2.0

A new branch than can be used as baseline for v2.0


wrong content-type when sharing image as attachment from whatsapp

Expected behaviour
I expect to have an email with the correct content-type of the attachment. The image should be viewable.
Snippet from the raw email, for example
----_com.android.email_66919854356700
Content-Type: image/jpeg;
 name="IMG-20160327-WA0004.jpg"
Content-Transfer-Encoding: base64
Content-Disposition: attachment;
 filename="IMG-20160327-WA0004.jpg";
 size=144895

I checked on another phone with no k9.
Actual behaviour
wrong content-type
------E63KOBT6S2CMWF65RZO58S1RLOK4XK
Content-Type: message/rfc822;
 name="IMG-20160327-WA0000.jpg"
Content-Disposition: attachment;
 filename="IMG-20160327-WA0000.jpg";
 size=270447
Content-Transfer-Encoding: 7bit

Steps to reproduce

open image in whatsapp
share with k9 (email + send to self)
open this email and get offered another email programm for viewing the image

Environment
K-9 Mail version: 5.008
Android version: 6.0.1
Account type: IMAP/SMTP

Fixed by #776

I failed to backport this to 5.008. It'll be fixed in 5.009.


Port probing isn't working for wemo.

Home Assistant release (hass --version):
0.58.0
Python release (python3 --version):
Python 3.5.3
Component/platform:
wemo
Description of problem:
wemo start up scanning is throwing exceptions, and inexplicably (to me), they are not being caught but rather reported in the logfile.
I've tested the pywemo component itself, and it seems to be able to control the devices perfectly.
I've tried cursory debugging via reading the code but cannot understand how the exceptions are not being caught.  Not being experienced in debugging Tornado development, I'm finding it difficult to get to the bottom of.
Expected:
Problem-relevant configuration.yaml entries and steps to reproduce:
Just have a vanilla config, it's a clean install.   I added an empty "wemo:" block to it.
wemo:

Traceback (if applicable):
2017-11-21 04:12:45 INFO (MainThread) [homeassistant.setup] Setting up wemo
2017-11-21 04:12:45 INFO (Wemo HTTP Thread) [pywemo.subscribe] Listening on port 8989
2017-11-21 04:12:45 INFO (Thread-13) [homeassistant.components.wemo] Scanning for WeMo devices.

2017-11-21 04:12:52 ERROR (MainThread) [homeassistant.setup] Error during setup of component wemo
Traceback (most recent call last):
  File "/srv/homeassistant/lib/python3.5/site-packages/urllib3/connection.py", line 141, in _new_conn
    (self.host, self.port), self.timeout, **extra_kw)
  File "/srv/homeassistant/lib/python3.5/site-packages/urllib3/util/connection.py", line 83, in create_connection
    raise err
  File "/srv/homeassistant/lib/python3.5/site-packages/urllib3/util/connection.py", line 73, in create_connection
    sock.connect(sa)
ConnectionRefusedError: [Errno 111] Connection refused

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/srv/homeassistant/lib/python3.5/site-packages/urllib3/connectionpool.py", line 601, in urlopen
    chunked=chunked)
  File "/srv/homeassistant/lib/python3.5/site-packages/urllib3/connectionpool.py", line 357, in _make_request
    conn.request(method, url, **httplib_request_kw)
  File "/usr/lib/python3.5/http/client.py", line 1107, in request
    self._send_request(method, url, body, headers)
  File "/usr/lib/python3.5/http/client.py", line 1152, in _send_request
    self.endheaders(body)
  File "/usr/lib/python3.5/http/client.py", line 1103, in endheaders
    self._send_output(message_body)
  File "/usr/lib/python3.5/http/client.py", line 934, in _send_output
    self.send(msg)
  File "/usr/lib/python3.5/http/client.py", line 877, in send
    self.connect()
  File "/srv/homeassistant/lib/python3.5/site-packages/urllib3/connection.py", line 166, in connect
    conn = self._new_conn()
  File "/srv/homeassistant/lib/python3.5/site-packages/urllib3/connection.py", line 150, in _new_conn
    self, "Failed to establish a new connection: %s" % e)
urllib3.exceptions.NewConnectionError: <urllib3.connection.HTTPConnection object at 0x69483330>: Failed to establish a new connection: [Errno 111] Connection refused

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/srv/homeassistant/lib/python3.5/site-packages/requests/adapters.py", line 440, in send
    timeout=timeout
  File "/srv/homeassistant/lib/python3.5/site-packages/urllib3/connectionpool.py", line 639, in urlopen
    _stacktrace=sys.exc_info()[2])
  File "/srv/homeassistant/lib/python3.5/site-packages/urllib3/util/retry.py", line 388, in increment
    raise MaxRetryError(_pool, url, error or ResponseError(cause))
urllib3.exceptions.MaxRetryError: HTTPConnectionPool(host='<IP_ADDRESS>', port=49153): Max retries exceeded with url: /setup.xml (Caused by NewConnectionError('<urllib3.connection.HTTPConnection object at 0x69483330>: Failed to establish a new connection: [Errno 111] Connection refused',))

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/srv/homeassistant/lib/python3.5/site-packages/homeassistant/setup.py", line 193, in _async_setup_component
    component.setup, hass, processed_config)
  File "/usr/lib/python3.5/asyncio/futures.py", line 380, in __iter__
    yield self  # This tells Task to wait for completion.
  File "/usr/lib/python3.5/asyncio/tasks.py", line 304, in _wakeup
    future.result()
  File "/usr/lib/python3.5/asyncio/futures.py", line 293, in result
    raise self._exception
  File "/usr/lib/python3.5/concurrent/futures/thread.py", line 55, in run
    result = self.fn(*self.args, **self.kwargs)
  File "/srv/homeassistant/lib/python3.5/site-packages/homeassistant/components/wemo.py", line 89, in setup
    port = pywemo.ouimeaux_device.probe_wemo(address)
  File "/srv/homeassistant/lib/python3.5/site-packages/pywemo/ouimeaux_device/__init__.py", line 30, in probe_wemo
    timeout=10)
  File "/srv/homeassistant/lib/python3.5/site-packages/requests/api.py", line 72, in get
    return request('get', url, params=params, **kwargs)
  File "/srv/homeassistant/lib/python3.5/site-packages/requests/api.py", line 58, in request
    return session.request(method=method, url=url, **kwargs)
  File "/srv/homeassistant/lib/python3.5/site-packages/requests/sessions.py", line 508, in request
    resp = self.send(prep, **send_kwargs)
  File "/srv/homeassistant/lib/python3.5/site-packages/requests/sessions.py", line 618, in send
    r = adapter.send(request, **kwargs)
  File "/srv/homeassistant/lib/python3.5/site-packages/requests/adapters.py", line 508, in send
    raise ConnectionError(e, request=request)
requests.exceptions.ConnectionError: HTTPConnectionPool(host='<IP_ADDRESS>', port=49153): Max retries exceeded with url: /setup.xml (Caused by NewConnectionError('<urllib3.connection.HTTPConnection object at 0x69483330>: Failed to establish a new connection: [Errno 111] Connection refused',))
2017-11-21 04:12:52 INFO (MainThread) [homeassistant.core] Bus:Handling <Event call_service[L]: service_call_id=1972005072-2, service_data=notification_id=invalid_config, title=Invalid config, message=The following components and platforms could not be set up:

 - [wemo](https://home-assistant.io/components/wemo/)

Please check your config., domain=persistent_notification, service=create>
2017-11-21 04:12:52 INFO (MainThread) [homeassistant.core] Bus:Handling <Event state_changed[L]: entity_id=persistent_notification.invalid_config, new_state=<state persistent_notification.invalid_config=notifying; title=Invalid config, message=The following components and platforms could not be set up:

 - [wemo](https://home-assistant.io/components/wemo/)

Please check your config. @ 2017-11-21T15:12:52.046673+11:00>, old_state=None>
2017-11-21 04:12:52 INFO (MainThread) [homeassistant.core] Bus:Handling <Event service_executed[L]: service_call_id=1972005072-2>
2017-11-21 04:12:52 INFO (MainThread) [homeassistant.bootstrap] Home Assistant initialized in 11.27s
2017-11-21 04:12:52 INFO (MainThread) [homeassistant.core] Starting Home Assistant core loop
2017-11-21 04:12:52 INFO (MainThread) [homeassistant.core] Starting Home Assistant
2017-11-21 04:13:08 INFO (MainThread) [homeassistant.components.discovery] Found new service: belkin_wemo {'model_number': '1.0', 'mac_address': '94103E430A88', 'serial': '221608K1200339', 'model_name': 'Insight', 'name': 'Heater', 'host': '<IP_ADDRESS>', 'port': 49153, 'ssdp_description': 'http://<IP_ADDRESS>:49153/setup.xml'}
2017-11-21 04:13:08 INFO (MainThread) [homeassistant.core] Bus:Handling <Event platform_discovered[L]: discovered=model_number=1.0, mac_address=94103E430A88, serial=221608K1200339, model_name=Insight, name=Heater, host=<IP_ADDRESS>, port=49153, ssdp_description=http://<IP_ADDRESS>:49153/setup.xml, service=belkin_wemo>
2017-11-21 04:13:08 INFO (MainThread) [homeassistant.components.discovery] Found new service: belkin_wemo {'model_number': '1.0', 'mac_address': '94103E4338A4', 'serial': '221608K1200EC0', 'model_name': 'Insight', 'name': 'WeMo Insight 2', 'host': '<IP_ADDRESS>', 'port': 49154, 'ssdp_description': 'http://<IP_ADDRESS>:49154/setup.xml'}
2017-11-21 04:13:08 INFO (MainThread) [homeassistant.core] Bus:Handling <Event platform_discovered[L]: discovered=model_number=1.0, mac_address=94103E4338A4, serial=221608K1200EC0, model_name=Insight, name=WeMo Insight 2, host=<IP_ADDRESS>, port=49154, ssdp_description=http://<IP_ADDRESS>:49154/setup.xml, service=belkin_wemo>
2017-11-21 04:13:08 INFO (MainThread) [homeassistant.components.discovery] Found new service: belkin_wemo {'model_number': '1.0', 'mac_address': '94103E43413C', 'serial': '221608K12010E6', 'model_name': 'Insight', 'name': 'WeMo Insight 3', 'host': '<IP_ADDRESS>', 'port': 49154, 'ssdp_description': 'http://<IP_ADDRESS>:49154/setup.xml'}
2017-11-21 04:13:08 INFO (MainThread) [homeassistant.core] Bus:Handling <Event platform_discovered[L]: discovered=model_number=1.0, mac_address=94103E43413C, serial=221608K12010E6, model_name=Insight, name=WeMo Insight 3, host=<IP_ADDRESS>, port=49154, ssdp_description=http://<IP_ADDRESS>:49154/setup.xml, service=belkin_wemo>
2017-11-21 04:13:08 INFO (MainThread) [homeassistant.core] Bus:Handling <Event component_loaded[L]: component=switch>
2017-11-21 04:13:08 INFO (MainThread) [homeassistant.core] Bus:Handling <Event platform_discovered[L]: discovered=model_number=1.0, mac_address=94103E430A88, serial=221608K1200339, model_name=Insight, name=Heater, host=<IP_ADDRESS>, port=49153, ssdp_description=http://<IP_ADDRESS>:49153/setup.xml, platform=wemo, service=load_platform.switch>
2017-11-21 04:13:08 INFO (MainThread) [homeassistant.core] Bus:Handling <Event platform_discovered[L]: discovered=model_number=1.0, mac_address=94103E4338A4, serial=221608K1200EC0, model_name=Insight, name=WeMo Insight 2, host=<IP_ADDRESS>, port=49154, ssdp_description=http://<IP_ADDRESS>:49154/setup.xml, platform=wemo, service=load_platform.switch>
2017-11-21 04:13:08 INFO (MainThread) [homeassistant.core] Bus:Handling <Event platform_discovered[L]: discovered=model_number=1.0, mac_address=94103E43413C, serial=221608K12010E6, model_name=Insight, name=WeMo Insight 3, host=<IP_ADDRESS>, port=49154, ssdp_description=http://<IP_ADDRESS>:49154/setup.xml, platform=wemo, service=load_platform.switch>
2017-11-21 04:13:08 INFO (MainThread) [homeassistant.loader] Loaded switch.wemo from homeassistant.components.switch.wemo
2017-11-21 04:13:08 ERROR (MainThread) [homeassistant.setup] Unable to setup dependencies of switch.wemo. Setup failed for dependencies: wemo
2017-11-21 04:13:08 ERROR (MainThread) [homeassistant.setup] Unable to prepare setup for platform switch.wemo: Could not setup all dependencies.
2017-11-21 04:13:08 ERROR (MainThread) [homeassistant.setup] Unable to setup dependencies of switch.wemo. Setup failed for dependencies: wemo
2017-11-21 04:13:08 ERROR (MainThread) [homeassistant.setup] Unable to prepare setup for platform switch.wemo: Could not setup all dependencies.
2017-11-21 04:13:08 ERROR (MainThread) [homeassistant.setup] Unable to setup dependencies of switch.wemo. Setup failed for dependencies: wemo
2017-11-21 04:13:08 ERROR (MainThread) [homeassistant.setup] Unable to prepare setup for platform switch.wemo: Could not setup all dependencies.

Additional info:
Exception is being raised here:
https://github.com/pavoni/pywemo/blob/master/pywemo/ouimeaux_device/__init__.py#L29-L30
Exception should be being caught here:
https://github.com/pavoni/pywemo/blob/master/pywemo/ouimeaux_device/__init__.py#L46-L47
However it is not being caught.
Further ipython transcript here, just demonstrating that pywemo component itself seems to be functioning correctly, e.g. it doesn't throw an exception when calling probe_wemo()
In [6]: import pywemo

In [7]: pywemo.discover_devices()
Out[7]:
[<WeMo Insight "WeMo Insight 3">,
 <WeMo Insight "WeMo Insight 2">,
 <WeMo Insight "Heater">]

In [9]: device1, device2, device3 = pywemo.discover_devices()

In [15]: device1.insight.hostname
Out[15]: '<IP_ADDRESS>:49153'

In [16]: device2.insight.hostname
Out[16]: '<IP_ADDRESS>:49154'

In [17]: device3.insight.hostname
Out[17]: '<IP_ADDRESS>:49154'

In [18]: device1.update_insight_params()

In [19]: device1.current_power
Out[19]: 0

In [20]: device1.toggle()

In [21]: device1.update_insight_params()

In [22]: device1.current_power
Out[22]: 2384440

In [23]: device1.toggle()

In [25]: pywemo.ouimeaux_device.probe_wemo('<IP_ADDRESS>')
Out[25]: 49153

In [26]: pywemo.ouimeaux_device.probe_wemo('<IP_ADDRESS>')
Out[26]: 49154

In [27]: pywemo.ouimeaux_device.probe_wemo('<IP_ADDRESS>')
Out[27]: 49154

I have the exact same problem here

Same issue her:
2017-12-07 17:21:34 ERROR (MainThread) [homeassistant.setup] Error during setup of component wemo
Traceback (most recent call last):
  File "/srv/homeassistant/lib/python3.5/site-packages/urllib3/connectionpool.py", line 387, in _make_request
    six.raise_from(e, None)
  File "<string>", line 2, in raise_from
  File "/srv/homeassistant/lib/python3.5/site-packages/urllib3/connectionpool.py", line 383, in _make_request
    httplib_response = conn.getresponse()
  File "/usr/lib/python3.5/http/client.py", line 1198, in getresponse
    response.begin()
  File "/usr/lib/python3.5/http/client.py", line 297, in begin
    version, status, reason = self._read_status()
  File "/usr/lib/python3.5/http/client.py", line 258, in _read_status
    line = str(self.fp.readline(_MAXLINE + 1), "iso-8859-1")
  File "/usr/lib/python3.5/socket.py", line 576, in readinto
    return self._sock.recv_into(b)
socket.timeout: timed out

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/srv/homeassistant/lib/python3.5/site-packages/requests/adapters.py", line 440, in send
    timeout=timeout
  File "/srv/homeassistant/lib/python3.5/site-packages/urllib3/connectionpool.py", line 639, in urlopen
    _stacktrace=sys.exc_info()[2])
  File "/srv/homeassistant/lib/python3.5/site-packages/urllib3/util/retry.py", line 357, in increment
    raise six.reraise(type(error), error, _stacktrace)
  File "/srv/homeassistant/lib/python3.5/site-packages/urllib3/packages/six.py", line 686, in reraise
    raise value
  File "/srv/homeassistant/lib/python3.5/site-packages/urllib3/connectionpool.py", line 601, in urlopen
    chunked=chunked)
  File "/srv/homeassistant/lib/python3.5/site-packages/urllib3/connectionpool.py", line 389, in _make_request
    self._raise_timeout(err=e, url=url, timeout_value=read_timeout)
  File "/srv/homeassistant/lib/python3.5/site-packages/urllib3/connectionpool.py", line 309, in _raise_timeout
    raise ReadTimeoutError(self, url, "Read timed out. (read timeout=%s)" % timeout_value)
urllib3.exceptions.ReadTimeoutError: HTTPConnectionPool(host='<IP_ADDRESS>', port=49153): Read timed out. (read timeout=10)

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/srv/homeassistant/lib/python3.5/site-packages/homeassistant/setup.py", line 193, in _async_setup_component
    component.setup, hass, processed_config)
  File "/usr/lib/python3.5/asyncio/futures.py", line 380, in __iter__
    yield self  # This tells Task to wait for completion.
  File "/usr/lib/python3.5/asyncio/tasks.py", line 304, in _wakeup
    future.result()
  File "/usr/lib/python3.5/asyncio/futures.py", line 293, in result
    raise self._exception
  File "/usr/lib/python3.5/concurrent/futures/thread.py", line 55, in run
    result = self.fn(*self.args, **self.kwargs)
  File "/srv/homeassistant/lib/python3.5/site-packages/homeassistant/components/wemo.py", line 89, in setup
    port = pywemo.ouimeaux_device.probe_wemo(address)
  File "/srv/homeassistant/lib/python3.5/site-packages/pywemo/ouimeaux_device/__init__.py", line 30, in probe_wemo
    timeout=10)
  File "/srv/homeassistant/lib/python3.5/site-packages/requests/api.py", line 72, in get
    return request('get', url, params=params, **kwargs)
  File "/srv/homeassistant/lib/python3.5/site-packages/requests/api.py", line 58, in request
    return session.request(method=method, url=url, **kwargs)
  File "/srv/homeassistant/lib/python3.5/site-packages/requests/sessions.py", line 508, in request
    resp = self.send(prep, **send_kwargs)
  File "/srv/homeassistant/lib/python3.5/site-packages/requests/sessions.py", line 618, in send
    r = adapter.send(request, **kwargs)
  File "/srv/homeassistant/lib/python3.5/site-packages/requests/adapters.py", line 521, in send
    raise ReadTimeout(e, request=request)
requests.exceptions.ReadTimeout: HTTPConnectionPool(host='<IP_ADDRESS>', port=49153): Read timed out. (read timeout=10)

Appears to be only an issue on Hassbian, as others have reported it working on Hass.io.
https://community.home-assistant.io/t/cannot-find-wemo-using-hassbian/35039/3?u=coolie1101

I guess I won't be showing off my smart home over the holidays, when the family visits :grinning:
“We are proud to announce the availability of Home Assistant 0.59. To keep you in the loop: This is the second last release in 2017. We have stuck to our bi-weekly release cycle for another year but we decided that we will take a little break between Christmas and New Year.”

I have the same issue.  Running 0.56.2 on Raspbian Stretch.  pywemo.discover_devices() shows all my devices, but Home Assistant log just shows
2017-12-18 15:46:20 ERROR (MainThread) [homeassistant.setup] Error during setup of component wemo
Traceback (most recent call last):
  File "/home/homeassistant/homeassistant/lib/python3.5/site-packages/requests/packages/urllib3/connectionpool.py", line 386, in _make_request
    six.raise_from(e, None)
  File "<string>", line 2, in raise_from
  File "/home/homeassistant/homeassistant/lib/python3.5/site-packages/requests/packages/urllib3/connectionpool.py", line 382, in _make_request
    httplib_response = conn.getresponse()
  File "/usr/lib/python3.5/http/client.py", line 1198, in getresponse
    response.begin()
  File "/usr/lib/python3.5/http/client.py", line 297, in begin
    version, status, reason = self._read_status()
  File "/usr/lib/python3.5/http/client.py", line 258, in _read_status
    line = str(self.fp.readline(_MAXLINE + 1), "iso-8859-1")
  File "/usr/lib/python3.5/socket.py", line 576, in readinto
    return self._sock.recv_into(b)
socket.timeout: timed out

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/home/homeassistant/homeassistant/lib/python3.5/site-packages/requests/adapters.py", line 438, in send
    timeout=timeout
  File "/home/homeassistant/homeassistant/lib/python3.5/site-packages/requests/packages/urllib3/connectionpool.py", line 649, in urlopen
    _stacktrace=sys.exc_info()[2])
  File "/home/homeassistant/homeassistant/lib/python3.5/site-packages/requests/packages/urllib3/util/retry.py", line 357, in increment
    raise six.reraise(type(error), error, _stacktrace)
  File "/home/homeassistant/homeassistant/lib/python3.5/site-packages/requests/packages/urllib3/packages/six.py", line 686, in reraise
    raise value
  File "/home/homeassistant/homeassistant/lib/python3.5/site-packages/requests/packages/urllib3/connectionpool.py", line 600, in urlopen
    chunked=chunked)
  File "/home/homeassistant/homeassistant/lib/python3.5/site-packages/requests/packages/urllib3/connectionpool.py", line 388, in _make_request
    self._raise_timeout(err=e, url=url, timeout_value=read_timeout)
  File "/home/homeassistant/homeassistant/lib/python3.5/site-packages/requests/packages/urllib3/connectionpool.py", line 308, in _raise_timeout
    raise ReadTimeoutError(self, url, "Read timed out. (read timeout=%s)" % timeout_value)
requests.packages.urllib3.exceptions.ReadTimeoutError: HTTPConnectionPool(host='<IP_ADDRESS>', port=49153): Read timed out. (read timeout=10)

Facing the same issue and it was driving me insane. As a quick and dirty test, I re-implemented the probe_wemo function in components/wemo.py as shown here:
https://github.com/NidalM/home-assistant/blob/master/homeassistant/components/wemo.py#L90
Running this version detected all my switches correctly.

I just submitted a patch to pywemo that fixes this, though I'm still completely baffled as to why it's happening
Patch https://github.com/pavoni/pywemo/pull/94
My debugging story https://github.com/pavoni/pywemo/issues/93
Once the PR is merged, I'm not sure if we need to bump a version here or something.

Thanks @ViViDboarder ! This is really strange.
Once the PR is merged and a new pywemo version is on pypi, the requirements_alll.txt in home assistant needs to be updated to point to the new version:
https://github.com/home-assistant/home-assistant/blob/master/requirements_all.txt#L952
I believe that should be it.

Hello
Raspbian is not the problem, i have a pure debian armhf distro, same issue, i hope a minor release with new version of pywemo because after upgrading debian jessie to stretch, wemo works random

Yes, can confirm that @ViViDboarder's fix has remediated the issue.


improvement: dynamic type support and notification adjustment

Problem

when increasing the font size for accessibility, the notifications and styling icons/text on multiple screens were becoming obstructed

Solution

added in allowFontScaling={false} and maxFontMultipliers to Text components across all screens to set a max value for font increases so that views don't become obstructed by larger text
set maxWidth and center-aligned text for notification for even spacing between words and icons

Video shows normal font and then largest font setting:
https://github.com/ACE-IoT-Solutions/connecting-mha-app/assets/94999450/519b19dc-cc67-4783-b4f1-abcef51bd3f7

would also suggest squashing all commits before merge, but other than that- it all looks great!


...

...

This question smells like https://xyproblem.info. I can answer your question, but I suspect it actually wont help you unless you ask what u really want
-f best -S res:720,tbr~7200

Ok, I want the best video equal or lower to 720p, or the closest to 2000 kbps, and the worst audio above a bitrate of 64 kbps without exception. And if there is no audio I don't want the video. That is the broadest picture I can think of to avoid the XY problem.
So you are not mentioning the audio in the solution.

gotcha.

to refuse to download a video without audio stream

This gave me the impression you wanted only pre-merged formats. Hence why I gave best in my solution

or the closest bitrate to 2000 kbps

Just to clarify, you want the bitrate closest to 2000k, not necessarily less than, correct? So 2400k would be preferred over 1000k. Then, use:
-f bv+ba[abr<64] -S res,tbr~2000

If you actually mean less than, replace ~ with :

btw, if you are only concerned with youtube, you don't need any of this complexity. Youtube always provides abr=128k and height<=720

-f bv+wa[abr>=64] -S res:720,tbr~2000

Why doesn't -S require the less than or equal for the resolution? I haven't seen it on the README.

btw, if you are only concerned with youtube, you don't need any of this complexity. Youtube always provides abr=128k and height<=720

I'm doing this because I've encountered a website that defaults to generic extractor and was giving me an error about an option not found. I was using this before and I needed to generalize it:
-f 'best[height<=720]'

Thanks you can mark the discussion as solved. I don't know how to do it.

Why doesn't -S require the less than or equal for the resolution?

Filtering formats (-f) and sorting formats (-S) uses different syntax. Your problem was easiest to solve using a combination of both - it would get complicated with just -f

This isn't working. I get
ERROR: Requested format is not available. Use --list-formats for a list of available formats

I need something generic that works with any extractor.

ERROR: Requested format is not available. Use --list-formats for a list of available formats

Can you please send the output of yt-dlp URL --list-formats?

ID         EXT RESOLUTION FPS │   FILESIZE   TBR PROTO │ VCODEC        VBR ACODEC    ABR
────────────────────────────────────────────────────────────────────────────────────────
240p       mp4 240p           │                  https │ unknown           unknown
hls-386    mp4 426x240     30 │ ~ 30.17MiB  387k m3u8  │ avc1.640015  387k mp4a.40.2  0k
480p       mp4 480p           │                  https │ unknown           unknown
hls-816-0  mp4 854x480     30 │ ~ 63.65MiB  816k m3u8  │ avc1.64001f  816k mp4a.40.2  0k
hls-816-1  mp4 854x480     30 │ ~ 63.65MiB  816k m3u8  │ avc1.64001f  816k mp4a.40.2  0k
720p       mp4 720p           │                  https │ unknown           unknown
hls-1605-0 mp4 1280x720    30 │ ~125.25MiB 1606k m3u8  │ avc1.640020 1606k mp4a.40.2  0k
hls-1605-1 mp4 1280x720    30 │ ~125.25MiB 1606k m3u8  │ avc1.640020 1606k mp4a.40.2  0k

[debug] Sort order given by user: res:720, tbr~2000
[debug] Sort order given by extractor: height, width, fps, format_id
[debug] Formats sorted by: hasvid, ie_pref, res:720(720.0), tbr~2000(2000.0), height, width, fps, id, lang, quality, hdr:12(7), vcodec:vp9.2(10), channels, acodec, filesize, fs_approx, vbr, abr, asr, proto, vext, aext, hasaud, source

There is no format matching your conditions. Specifically, yt-dlp doesn't know the bitrate of the audio formats. So it cant tell if they are >64k

If you also want to allow formats with unknown info, use the ? operator

ID EXT RESOLUTION FPS │ FILESIZE TBR PROTO │ VCODEC VBR ACODEC ABR ──────────────────────────────────────────────────────────────────────────────────────── 240p mp4 240p │ https │ unknown unknown hls-386 mp4 426x240 30 │ ~ 30.17MiB 387k m3u8 │ avc1.640015 387k mp4a.40.2 0k 480p mp4 480p │ https │ unknown unknown hls-816-0 mp4 854x480 30 │ ~ 63.65MiB 816k m3u8 │ avc1.64001f 816k mp4a.40.2 0k hls-816-1 mp4 854x480 30 │ ~ 63.65MiB 816k m3u8 │ avc1.64001f 816k mp4a.40.2 0k 720p mp4 720p │ https │ unknown unknown hls-1605-0 mp4 1280x720 30 │ ~125.25MiB 1606k m3u8 │ avc1.640020 1606k mp4a.40.2 0k hls-1605-1 mp4 1280x720 30 │ ~125.25MiB 1606k m3u8 │ avc1.640020 1606k mp4a.40.2 0k

How can formats have an ABR of 0k? That looks like a bug to me 🤷♂

If it can't get the worst audio above 64k, I want to get the best audio. Would that be like this?
-f bv+wa[abr>=64]/ba -S res:720,tbr~2000

Previously, you explicitly said you do not want to download anything if there is no matching audio...

If it can't get the worst audio above 64k, I want to get the best audio. Would that be like this?
-f bv+wa[abr>=64]/ba -S res:720,tbr~2000

Almost. That still does not account for pre-merged formats
-f (bv+(wa[abr>=64]/ba))/b -S res:720,tbr~2000

Should cover everything
but then it's easier to give:
-S res:720,vbr~2000,+abr:64

which accomplishes nearly the same thing
I strongly recommend you go through the docs I linked above

I don't want to download videos without an audio stream. But if there is audio and I can't find the worst above 64k, I still want to find one.
I'll try this for a couple of days and then close it if it works fine, so we are not opening and closing the issue.

I don't want to download videos without an audio stream

According to my understanding of the documentation, -f (bv+(wa[abr>=64]/ba))/b -S res:720,tbr~2000 shouldn't download anything if there is either no video or no audio.
But by my understanding, the default option (bv*+ba/b) also shouldn't download anything if there is either no video or no audio, and yt-dlp definitely works on Spotify podcasts, so now I'm confused

and yt-dlp definitely works on Spotify podcasts, so now I'm confused

There's some special handling for this case

Why'd u re-open?

There's some special handling for this case

I see

Why'd u re-open?

I thought that my question related to OP's question enough that I could just reuse this issue. I'll open a new issue next time

Don't remove your post


Doesn't work on android 12

Hello and good day, thanks for the wonderful library but it currently doesn't work on my android 12 device. I have been using it on android 11 and below and it works fine.
I'm running the example code, It specifically stops working once i minimise or kill the app.

Oh, that's why it's not working for me, i am in Android 12. Sad... I will go search how I can get around this problem.

Closing as duplicate of #168.


Cleaned compiled TSX

Hi,
I read your Reddit post regarding this repo. Great work! I found you might have left the compiled TSX files in the repo. so I removed all the JS and map files. Merge this PR if you think they need to be removed and its helpful to you.
Otherwise please feel free to cancel this PR.

Looks good. 👍
Thanks so much for your initiative and effort! 😊


Cleaning out unused rename endpoint for pipeline & strategy

Removed move endpoint for pipeline/strategy rename in favor of the update endpoint
spring security annotated the update endpoint for good measure

@anotherchrisberry / @ajordens PTAL

LGTM


[bug] external register type seems to not be working

It seems that external registers mode does not work
Fatal: (vsim-3420) Array lengths do not match. Left is 11 (10 downto 0). Right is 12 (11 downto 0).
#    Time: 473200 ps  Iteration: 1  Process: csr_i/g_DATA/u_register/line__119 File: rggen/rggen_external_register.vhd
# Fatal error in Process line__119 at rggen/rggen_external_register.vhd line 47

failing line:
address := std_logic_vector(unsigned(register_address) - START_ADDRESS);

external register is defined with offset 0x10 (determined byregisters existing before it)

version:
$ rggen --plugin rggen-vhdl --verbose-version
RgGen 0.33
  - rggen-core 0.33.0
  - rggen-default-register-map 0.33.0
  - rggen-sv-rtl 0.33.0
  - rggen-sv-ral 0.33.0
  - rggen-c-header 0.5.0
  - rggen-markdown 0.26.0
  - rggen-spreadsheet-loader 0.25.2
  - rggen-vhdl 0.10.0

Issue occurs because instantiation of rggen_external_register in the autogenerated code
    u_register: entity work.rggen_external_register
      generic map (
        ADDRESS_WIDTH => 11,
        BUS_WIDTH     => 32,
        STROBE_WIDTH  => DATA_STROBE_WIDTH,
        START_ADDRESS => x"010",
        BYTE_SIZE     => 1024
      )

doesn't provide the size of string, thus it's by default expanded to 12 in START_ADDRESS
    u_register: entity work.rggen_external_register
      generic map (
        ADDRESS_WIDTH => 11,
        BUS_WIDTH     => 32,
        STROBE_WIDTH  => DATA_STROBE_WIDTH,
        START_ADDRESS => 11x"010",
        BYTE_SIZE     => 1024
      )

Specifying the actual size represented by string START_ADDRESS => 11x"010", fixes the issue.

Hi @SzymonHitachi ,
Thank you for your reporting this issue.
I've pushed the fix for this error to the branch below.
https://github.com/rggen/rggen-vhdl-rtl/tree/fix_width_mismatch
Can you checkout this branch and confirm this error is resolved?

Hi @SzymonHitachi ,
Does this change resolve your issue?

Hi @SzymonHitachi , Does this change resolve your issue?

I apologize for late response. It did indeed slip my mind. Yes this one fixes the issue.


Update installation documentation

Rewrites the installation instructions to reflect updates to dependencies. Also streamlines the installation process to reduce the number of steps. Confirmed to work with a new Conda test environment.
Closes #62.

Should we add a yml environment file that matches these install instructions? Both for users and for use in the dockerfile for testing. I have one that is similar but not identical that I have been using while writing the dockerfile, but it would probably be best to have it match the install guide.
We could also add a little paragraph mentioning that the conda and pip stuff can be obtained using the yml file.

Oh, that's a good idea. I'll add a YML file soon.


[Bug]: Hop Server  REST api

Apache Hop version?
2.9.0
Java version?
11
Operating system
Windows
What happened?
How to call the interfaces of the following APIs? It's a get method, but how to pass XML into the method? On line 93 of the AddPipeServlet.doGet in the source code, the value of the StringBuilder XML is set to 'new StringBuilder' (request. getContentLength()) It will report an error because in the get method, request. getContentLength() may be -1. How should this API be called?
ADDWORKFLOW
name
addWorkflow
description
Add a workflow for execution
endPoint
GET hop/addWorkflow
Content-Type: text/xml;charset=UTF-8
parameters
xml Request body should contain xml containing workflow_configuration (pipeline and workflow_execution_configuration wrapped in pipeline_configuration tag).
example request
http://localhost:8081/hop/addWorkflow/xml=Y with XML payload
result
Issue Priority
Priority: 3
Issue Component
Component: Hop Server

That get method requires content, the get will return a status after content parsing

That get method requires content, the get will return a status after content parsing

Can you provide a detailed introduction on how to operate it ？

We don't suggest manually crafting these calls, you can use the CLI to start pipelines on a remote server.
The code we use to send pipelines to the server can be found here
Closing this ticket as it is not a bug but a question.
Questions can be sent to our Mailing lists: https://hop.apache.org/community/mailing-list/


[core] Remove framer from workspace

To prevent error when doing release.
lerna ERR!
lerna ERR! lerna ENOENT: no such file or directory, open '/Users/siriwatknp/Personal-Repos/material-ui/framer/Material-UI.framerfx/build/package.json'
error Command failed with exit code 1.

Ref: https://mui-org.slack.com/archives/C0170JAM7ML/p1632313083002800

[x] I have followed (at least) the PR section of the contributing guide.

It's a workspace. Instead, we need to find out how to exclude it from the release workflow.

@eps1lon using private: true in package.json should work, right?


TAJO-1276: Link to tsql guide 404s in tajo cli

Ended up being a big hassle repushing the 0.9.0 docs, so I just went ahead and wrote up a quick page to redirect from cli.html and added it to the website.  Going forward, I've fixed all the references to the cli.html in the website and code to tsql.html (a more correct name anyway).  Also, fixed typo in mailing list page.  Once this is committed, I'll re-generated and re-publish the website.

+1
Thanks for your contribution!


[Terra Clinical Label Value View] Link the definition list in the LabelValueView with a text provided by the consumer, that describes what the definition list is about

Summary

What was changed:

Created a new prop topicTextId on the LabelValueView component.
Applied the aria-labelledby attribute on the definition list returned by the LabelValueView, to link it to a topic text defined by the consumer.
Updated the component and tests examples for the new prop topicTextId.

Why it was changed:
The change was required for the accessibility purpose, so the user understand better each LabelValueView to which topic is associated.
Testing

This change was tested using:

[x] WDIO
[x] Jest
[x] Visual testing (please attach a screenshot or recording)
[ ] Other (please describe below)
[ ] No tests are needed

Reviews
In addition to engineering reviews, this PR needs:

[x] UX review
[x] Accessibility review
[ ] Functional review

Additional Details

This PR resolves:
UXPLATFORM-9190

Thank you for contributing to Terra.
@cerner/terra

@brooksienoodlesoup and @supreethmr - could you please confirm you are ok with all the changes I've made after your suggestions and approve the PR if everything looks good to you?


Changed jackson version to 2.7.5

Can you test that brooklyn-tosca works with this change please?

Since we are upgrading suggest doing this change as well https://github.com/neykov/brooklyn-server/commit/62613c05c2ba08c3ad9055d1fa3006f100a58b38.
I also tried bumping to latest releases available (with same major number) in https://github.com/neykov/brooklyn-server/commit/da1073484ec24b555fed0c0f40b89e561dc929a8 - seems to work fine deploying kubernetes.

@Graeme-Miller happy to merge once you cherry-pick https://github.com/neykov/brooklyn-server/commit/62613c05c2ba08c3ad9055d1fa3006f100a58b38 into this PR as well

@grkvlt @Graeme-Miller I am not happy for this to be merged before you have confirmed or we have at least discussed what happens to the brooklyn-tosca dist.

@sjcorbett, @Graeme-Miller, I will pull this and test it out with brooklyn-tosca when I've done my next commit.

👍 LGTM; I have pulled this PR, built brooklyn with it and then brooklyn-tosca on top of that (actually using https://github.com/cloudsoft/brooklyn-tosca/pull/117) and I can deploy and undeploy a sample application successfully.

@geomacy did you use the dist tgz that brooklyn-tosca builds? I will also test shortly.

@sjcorbett good point, no, I was using the Karaf distro.

out of curiosity is there a reason for this bump?  if there is can you say what it is for posterity?  otoh if it's just good hygiene that's fine although probably we should do a sweep as i'm sure there are other stale versions.

@ahgittin another downstream project has a dependency on https://github.com/fabric8io/kubernetes-client which requires the later version.

The version bump was held back on purpose due to incompatibility with brooklyn-tosca transitive dependencies. Now that we are running in Karaf we can finally update (to a semi-recent version).
Agree there are lots of stale library versions in there which need updating.

I've tested Brooklyn 0.10.0-SNAPSHOT master + this PR against brooklyn-tosca master. The standard Tomcat/MySQL blueprint deployed fine from Alien4Cloud. The brooklyn-tosca dist includes these jars in its lib directory:
jackson-annotations-2.7.5.jar
jackson-core-2.7.5.jar
jackson-databind-2.7.5.jar
jackson-dataformat-xml-2.4.5.jar
jackson-dataformat-yaml-2.4.5.jar
jackson-datatype-joda-2.4.5.jar
jackson-jaxrs-base-2.7.5.jar
jackson-jaxrs-json-provider-2.7.5.jar
jackson-module-jaxb-annotations-2.7.5.jar

By the look of it the 2.4.5 dependencies have come from io.swagger:swagger-core and swagger-jaxrs via brooklyn-utils-rest-swagger.
So sounds like we're good to go but keeping this at the back of our minds. @ahgittin do you think we need to maintain brooklyn-tosca-dist any more?

Worth testing that the apidocs (Swagger REST docs) page works with these versions?
+1 to dropping brooklyn-tosca-dist in favour of the karaf way.  brooklyn-tosca docs and README probably will need updating also.

I have just tested the swagger page works as expected with this PR.

That's a good spot @sjcorbett. The jackson library version mix seems important. I think it's better to stick to the same version (even if higher than required for swagger), than to risk incompatibility. It's higher risk to use two parts of the library with different versions than upgrade all of them.
Another reason to upgrade everything is that in Karaf we are explicitly adding the dependencies and pinning them to  the fasterxml.jackson.version. This causes the classic distribution to have a different mix of jars than the karaf one - best to keep them consistent.

replacing with:
https://github.com/apache/brooklyn-client/pull/28
https://github.com/apache/brooklyn-server/pull/339


[Bug] CSS classes for themes only applied in docs if there exists a story

I use theme switching by class name in Angular:
themes: {
            "Theme1 (light)": "theme1 light",
            "Theme1 (dark)": "theme1 dark",
            "Theme2": "theme2",
        },
defaultTheme: "Theme2",
parentSelector: "body",

When using a custom doc that is not linked to a story element and just documentation, the css classes are not inserted in the body. I would need the css styles for example in case I want to render a color palette with variables instead of hard-coding the values.
Workaround:
I created an empty component and render it in the docs. Then it works again:
import {Meta, ColorPalette, ColorItem, Story} from '@storybook/blocks';
import * as WorkaroundStories from "./theme.component.stories";

<Meta title="Colors"/>

<div style={{display: "none"}}>
Workaround: The theme variable is not injected when no story is used on the page, so we inject some story here
<Story of={WorkaroundStories.Empty} meta={WorkaroundStories}></Story>
</div>

# Colors

<ColorPalette>
    <ColorItem
        title="Primary color"
        subtitle=""
        colors={{
            "Primary": 'var(--color-primary)',
        }}
    />
</ColorPalette>

Hey @markusnissl 👋
I'll need to dig a little deeper into this. Can you share a reproduction that I can use to test?

Hey @Integrayshaun
sorry that my response took so long.
I created now a demo repository. You find the issue in the colors and colors-fixed doc part when switching themes.
https://stackblitz.com/~/github.com/markusnissl/storybook-demo

Hey @markusnissl 👋
Now worries at all. Apologies for taking a few weeks to get back to you. There's been a few developments since you created this issue.
The biggest of which is, this package is deprecated. For theme switching you should use @storybook/addon-themes however right now it will likely have the same issue.
The switcher relies on the code in the decorator to run when the theme is changed. Without a story in your MDX, there is no decorator on the bag either to respond to this. Support for switching themes for your components in docs is quite a finicky and I'd like to tackle this in Storybook 8 As we tackle some other theme changes in the UI to account for this


docs(dpg): fix no return statement in DeveloperDrivenEvolution.md

Contributing to the Azure SDK
Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.
For specific information about pull request etiquette and best practices, see this section.

/check-enforcer reset

/check-enforcer evaluate


Faucet for Origin token on Testnet

In order to be able to test the DApp on Testnet, we'll need a way for test wallets to get credited with some OGN tokens.
A simple UI similar to https://faucet.ropsten.be/ will be exposed (perhaps hosted under https://faucet.originprotocol.com ?). The user enters her wallet address and will get credited with a fixed amount of tokens. There won't be any rate limiting.
Additionally, for ease of testing on local development environment, it would be nice to have a simple JS script that can be run manually and credits OGN token to a wallet address passed as argument on the command line.

CC @cuongdo @nick @DanielVF as FYI since this is related to the token project.

Done 😁


Redirect non-www (naked domain) to www

I didn't want to go messing with nginx settings myself, so wondered if there's a way for us to redirect naked domains like https://example.com to https://www.example.com, perhaps with a flag of some sort.


refactor: make argocd-image-updater-config volume mapping optional

Signed-off-by: Alexander Matyushentsev<EMAIL_ADDRESS>https://github.com/argoproj-labs/argocd-image-updater/issues/109
PR make argocd-image-updater-config ConfigMap volume optional to simplify bootstapping process. The image updater fallback to "default" registries configuration and still support public image registries.

What do you think @jannfis ?

What do you think @jannfis ?


Just updated from 0.1.3 to master and getting many errors...

Please see the screenshot...

You may have to clean your derived data folder.

Cleaned Build + derived data without success.

Try creating a new project with the 1.0.0 version.

It's working. Why not in my existing project? Argh :(


Using metrics apart from accuracy

Keras allows using metrics apart from accuracy when compiling the model as below -
model.compile(     optimizer='adam',     loss='mean_squared_error',     metrics=[         metrics.MeanSquaredError(name='my_mse'),         metrics.AUC(name='my_auc'),     ] )
However, I came to notice that when using tf2crf, no matter what metrics I specify while compiling the model, it only displays the accuracy metric during training.
Is this the expected behaviour? If so, any chance of implementing support for different metrics in a future release?

That is because it uses a customed training and testing step. To use different metrics, you can override the train_step and test_step function in the class.


chore(ci): rename scanner-v4-tests to scanner-v4-install-tests

Description
The current Scanner V4 installation tests are simply called scanner-v4-tests, which has brought some confusion among the team. As the team works towards creating Scanner V4 CI tests, we believe it'd make more sense to change the name of these tests to "install tests".
This is accompanied by https://github.com/openshift/release/pull/56006.
User-facing documentation

[x] CHANGELOG update is not needed
[x] documentation PR is not needed

Testing and quality

[x] the change is production ready: the change is GA or otherwise the functionality is gated by a feature flag
[x] CI results are inspected

Automated testing

[x] modified existing tests

How I validated my change
OpenShift CI is a pain to test, so may just test it live...
The OpenShift CI tests know which script to run based on the job's name. In the accompanying PR, you can see the job names changes to include "install". For example, gke-scanner-v4-tests --> gke-scanner-v4-install-tests. This is eventually converted to gke_scanner_v4_install_tests.py in .openshift-ci/dispatch.sh, which now exists due to this PR.

Haven't done a review as of now, but I am definitely in favor of such a renaming.

@BradLugo @mclasmeier @dcaravel I removed the line which updates the worker node type for scanner v4 install tests, as scanner v4's resource requirements are much lower than they used to be

@BradLugo @mclasmeier now that the 4.6 branch has been cut, can we come back to this? The team aims to add some scanner v4 e2e tests so it may be best to make it clear the tests these reference, here, are installation-related


[GUI] template: problem in button display

Save and Discard buttons are not visible in a template with many attributes

The problem has been corrected.


Explicitly mention that snapshots should be reviewed

Summary
This paragraph alluded to the fact that snapshots should be reviewed (by mentioning pretty-format), but it should be explicitly mentioned.
Test plan
It's just a text modification

thanks!


remove the verbose from construction of SlidingEstimator as it was not being used anywhere and it was only making people confused .

Thanks for contributing a pull request! Please make sure you have read the
contribution guidelines
before submitting.
Please be aware that we are a loose team of volunteers so patience is
necessary. Assistance handling other issues is very welcome. We value
all user contributions, no matter how minor they are. If we are slow to
review, either the pull request needs some benchmarking, tinkering,
convincing, etc. or more likely the reviewers are simply busy. In either
case, we ask for your understanding during the review process.
Again, thanks for contributing!
Reference issue
Example: Fixes #1234.
What does this implement/fix?
Explain your changes.
Additional information
Any additional information you think is important.

Hi @DeepakSingh26, we were just discussing this in #11444. I think it is better to make fix verbose instead of removing it.

yes let's rather fix. It will avoid an API change and the need for a deprecation.

Sure ,

The verbose behavior for sliding and generalizing estimator has been fixed.


FluentAppBarItem Add Click Event

🙋 Feature Request
FluentAppBarItem Add Click Event
🤔 Expected Behavior
I hope FluentAppBarItem can have a click event, for example, when used as a primary menu, clicking FluentAppBarItem can refresh the submenu.

😯 Current Behavior
There are currently no click events.

Will be in next release

Oh，Thanks!


Issue - PlayState.hx w/ Null Object Reference.

Describe your bug here.

I recently added something to PlayState.hx.
Do you guy's know what it is?
Command Prompt/Terminal logs (if existing)
PlayState.hx (line 5600)
PlayState.hx (line 1596)
flixel/FlxGame.hx (line 637)
flixel/FlxGame.hx (line 724)
flixel/FlxGame.hx (line 677)
flixel/FlxGame.hx (line 545)
openfl/events/EventDispatcher.hx (line 402)
openfl/display/DisplayObject.hx (line 1399)

Are you modding a build from source or with Lua?
Source
What is your build target?
Linux
Did you edit anything in this build? If so, mention or summarize your changes.
Literally almost everything has been modified.

Describe your bug here.
 I recently added something to PlayState.hx.
Do you guy's know what it is?
Command Prompt/Terminal logs (if existing)
PlayState.hx (line 5600)
PlayState.hx (line 1596)
flixel/FlxGame.hx (line 637)
flixel/FlxGame.hx (line 724)
flixel/FlxGame.hx (line 677)
flixel/FlxGame.hx (line 545)
openfl/events/EventDispatcher.hx (line 402)
openfl/display/DisplayObject.hx (line 1399)

Are you modding a build from source or with Lua?
Source
What is your build target?
Linux
Did you edit anything in this build? If so, mention or summarize your changes.
Literally almost everything has been modified.

if almost everything has been modified then it isn't a Psych Engine bug...?

if almost everything has been modified then it isn't a Psych Engine bug...?

It is literally ON psych engine.

I think what he meant is that it's a problem with your code ig

you modified a lot of it, so we can't be sure

you modified a lot of it, so we can't be sure

But could we at least see what the error might be?

idk, you asked yourself

you modified a lot of it, so we can't be sure

^^ If you modified a lot of code, and the issue isn't present on base Psych Engine then it's probably an issue with your code


Filter HaplotypeCaller variants

Expected Behavior
Filter the calls from HaplotypeCaller with Variant Quality Score Recalibration according to GATK best practise (Tools VariantRecalibrator, ApplyRecalibration, see https://gatkforums.broadinstitute.org/gatk/discussion/39/variant-quality-score-recalibration-vqsr or a more recent version)
Current Behavior
Variant quality score recalibration currently not included.

 Filter HaplotypeCaller variants

Keep in mind, that you'd need a "bit" of data for doing VQSR properly. The recommendation was to use at least 30 WES or 1WGS sample for performing VQSR.
I started working on a solution  (in NGI-ExoSeq) to automatically download 35 of the 1000G Exome Datasets, run HaplotypeCaller on them and use them for analysis procedures with less than the minimum required 30 WES samples.


kubefed2 enable succeeds if federation of the type already enabled

kubefed2 enable now succeeds if federation of the type is already enabled. If the federated type is already enabled, it will update the FederatedTypeConfig to stay consistent with #628 for CRDs.
Fixes #720

LGTM.  Will rely on an impartial reviewer to merge.
cc: @xunpan @shashidharatd
As an aside, I'd really like to see some helper functions to facilitate idempotency factored out of this PR and #555 at some point in the near future.

/lgtm
After Get, even it tells not found at the moment, it may still failed in Create because others  operate on the same resource to create it. But it is fine. We do not need to guarantee a transction with complex code. And after the potential error above happens, it still succeed for the next execution.


Remove the limitation of associated attributes in DB2 and SAP HANA since it's no longer applicable.

The once documented limitation regarding associated attributes in DB2 and SAP HANA  is no longer applicable. We therefore should remove the related section in the documentation.

Passed team review

Hi Pavel, So this change is for 9.8.0? - I'll put a label on it to make sure it isn't merged before! It sounds like we need to keep something in the doc for customers who are using other versions which are not LTS? Perhaps, rather than deleting the section we could add a banner which says

This limitation has been removed in versions x.xx.xx and above

What do you think?

Hi @MarkvanMents, the changes were updated as suggested. They might also require a review by someone from the security team.

Hi Pavel, So this change is for 9.8.0? - I'll put a label on it to make sure it isn't merged before! It sounds like we need to keep something in the doc for customers who are using other versions which are not LTS? Perhaps, rather than deleting the section we could add a banner which says

This limitation has been removed in versions x.xx.xx and above

What do you think?

Hi @MarkvanMents, the changes were updated as suggested. They might also require a review by someone from the security team.

Done

Revived in #3908


[Feature Request] Performance of org-journal-list-files

On Windows 10, org-journal-list-files is very slow for having a journal file per day. For example, opening the calendar buffer with journal integration takes 10-20 seconds on my computer (~80% of overall time is taken by org-journal-list-files according to profiler). This is mostly due to multiple file-truename calls, which seems to be pretty slow (at least on Windows).
If I am not completely mistaken, calling file-truename is not necessary in the predicate, as this has already been mapped to the file list.
Would it be possible to have the file list cached?

@philScholl I have removed the two file-truename calls in org-journal-list-files. Please let me know if this has improved the speed. We have support for caching the dates, but not for files, see org-journal-enable-cache.

@cslux yes, this helped a lot - the execution time approximately halved for opening the calendar.