[API Integration] Walters Art Museum

Provider API Endpoint / Documentation
http://api.thewalters.org/
Provider description
The Walters Art Museum’s collection spans more than seven millennia, from 5,000 BCE to the 21st century, and encompasses 36,000 objects. This is considering for ingestion to CC Search, because it uses the same data structure as over a dozen other institutions, working with the American Art Collaborative (http://americanartcollaborative.org/tools/) and if this ingestion is successful, we can look to set up similar integrations with other collaborative members.
Licenses Provided
All images and data are CC0 licensed. License information does not appear to be available through the API on a per-object basis, which shouldn't be an issue given that all objects have the same license.
Provider API Technical info
Same as information above: http://api.thewalters.org/
The API does require a key, which we will sign up to receive before this ticket is worked on.
Their object info appears to include title, description, URL of object, etc:
http://data.americanartcollaborative.org/page/wam/object/4617
General Recommendations for implementation

The script should be in the src/cc_catalog_airflow/dags/provider_api_scripts/ directory.
The script should have a test suite in the same directory.
The script must use the ImageStore class (Import this from
src/cc_catalog_airflow/dags/provider_api_scripts/common/storage/image.py).
The script should use the DelayedRequester class (Import this from
src/cc_catalog_airflow/dags/provider_api_scripts/common/requester.py).
The script must not use anything from
src/cc_catalog_airflow/dags/provider_api_scripts/modules/etlMods.py, since
that module is deprecated.
If the provider API has can be queried by 'upload date' or something similar,
the script should take a --date parameter when run as a script, giving the
date for which we should collect images. The form should be YYYY-MM-DD (so,
the script can be run via python my_favorite_provider.py --date 2018-01-01).
The script must provide a main function that takes the same parameters as from
the CLI. In our example from above, we'd then have a main function
my_favorite_provider.main(date). The main should do the same thing calling
from the CLI would do.
The script must conform to PEP8. Please use pycodestyle (available via
pip install pycodestyle) to check for compliance.
The script should use small, testable functions.
The test suite for the script may break PEP8 rules regarding long lines where
appropriate (e.g., long strings for testing).

Examples of other Provider API Scripts
For example Provider API Scripts and accompanying test suites, please see

src/cc_catalog_airflow/dags/provider_api_scripts/flickr.py and
src/cc_catalog_airflow/dags/provider_api_scripts/test_flickr.py, or
src/cc_catalog_airflow/dags/provider_api_scripts/wikimedia_commons.py and
src/cc_catalog_airflow/dags/provider_api_scripts/test_wikimedia_commons.py.

I'd work on it

This issue is marked "not ready for work" and isn't ready for contributors yet.

@annatuma @kgodey can i start working on this ? as part of gsoc application for the add api provider idea ?

@Pac23 Go for it.  Feel free to ask questions in comments on this issue if you run into trouble.

@mathemancer On the registration page to get an API key, after entering the details and requesting registration, the site is giving an internal server error, hence the account is not getting created, and the key is not obtained. What should I do?
The page: https://api.thewalters.org/SGAccount/Register

@akshgpt7 I can confirm this behavior, at least at the moment.  I'll mark it as 'CC Staff Only' for the moment, we should check back in on this in a couple of weeks and see if they have it resolved.

@mathemancer I mailed the Walters' team regarding the following behavior some time back. They have come up with a reply and have fixed the issue of internal server error. The key is generating successfully now.
I guess we can proceed with the integration now, and the 'CC Staff Only' label can be omitted.

I want to work on this. Please assign this issue to me (if no one else is working on this).

go ahead @dravadhis

Just a small doubt. How often should I query the API? Every 24 hours seems good to me since there is no such information I found in the documentation.

@kgodey I think there is no way to query the API by upload date. In fact the only way to group images is by classification (for e.g. Ivory, Manuscripts, Print, Ceramics, etc.). So I am thinking of querying on the basis of classification. The GET request for object type (the other types do not return image data so they are not useful for us I guess) does return a Public Access Date but it is not accessible as a query (from what I found in the documentation).

@annatuma @mathemancer @kgodey Do I also need to write the workflow file for the provider script? Like the ones present in src\cc_catalog_airflow\dags.

@dravadhis I think it'd be good to make the script first, and then make an issue and implement the DAG separately.  However, you are correct in that we'll need to make an associated DAG before the script will be able to run in production.

@dravadhis How many total items are there?  Is it possible to tell?  If it's not too many, partitioning isn't necessary.  If there are a large number, we'll need to ensure that partitioning by classification is indeed a proper partition; i.e., we need to be sure that every item is in one of the classifications and that no item is in more than one classification.  Can you confirm this?

@dravadhis I think it'd be good to make the script first, and then make an issue and implement the DAG separately.  However, you are correct in that we'll need to make an associated DAG before the script will be able to run in production.

In that case I will first complete the script. After which I will open an issue and implement the DAG.

@dravadhis How many total items are there?  Is it possible to tell?  If it's not too many, partitioning isn't necessary.  If there are a large number, we'll need to ensure that partitioning by classification is indeed a proper partition; i.e., we need to be sure that every item is in one of the classifications and that no item is in more than one classification.  Can you confirm this?

Every item has one classification. I have manually checked all responses. I dont know the actual count of images but I am sure that the max is 50k (I did the maths behind that). I did have the doubt of dual classification. I have asked about that from the maintainers and am waiting for their reply.

@dravadhis How many total items are there?  Is it possible to tell?  If it's not too many, partitioning isn't necessary.  If there are a large number, we'll need to ensure that partitioning by classification is indeed a proper partition; i.e., we need to be sure that every item is in one of the classifications and that no item is in more than one classification.  Can you confirm this?

Every item has one classification. I have manually checked all responses. I dont know the actual count of images but I am sure that the max is 50k (I did the maths behind that). I did have the doubt of dual classification. I have asked about that from the maintainers and am waiting for their reply.

I don't know if 50k is a large number for partition or not. Please point this out.

I wanted to introduce myself here. I'm Dylan Kinnett, manager of web for the Walters Art Museum. I'd like to invite you, and please do feel free, to reach out to me via Github with any questions you may have for us, related to this, the API in general, or the collection.

Hey @dylan-k !  Thanks for the invitation.  To reciprocate, we have a public slack (instructions for joining at https://opensource.creativecommons.org/community/)  .  You might be interested in the #cc-dev-catalog channel, where we discuss integrations with various APIs such as the one provided by the Walters Art Museum!


Enable bloom extension

I didn't see that we've built contrib extensions in such a way. Should we?


[CELEBORN-1176] Server side support for Sasl Auth

What changes were proposed in this pull request?
This adds the server side Sasl authentication support in the transport layer. Most of this code is taken from Apache Spark.
Why are the changes needed?
The changes are needed for adding authentication to Celeborn. See CELEBORN-1011.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Added UTs.

@waitinfuture @mridulm @RexXiong @FMX @pan3793 @akpatnam25 @rmcyang
Could you please take a look.


feat: publish and edit featurestore with abstract and keywords

Added optional arguments abstract and keywords
for function publish_featurestore and edit_featuretype

Thank you very much @wickes1 for this PR.


Add an approximation method for non-scanned configurations

I just added a few new lights and now everything works wonderfully. However, I noticed that many light configurations in between scans (for the bri and mired steps) fail by up to 5% or more. Currently I'm using Wiz automatic circadian cycle and looking to use adaptive lighting, so my lights are all the time changing temp.
In an attempt to fill the gaps between bri and mired steps I tested some Machine Learning algorithms and unsurprisingly the best one was K-nearest neighbors with 4 neighbors. Without getting too complicated on the final model, this simple algorithm just summarizes in a very simple approximation to the untested configuration by using the 4 closest configurations that are indeed measured. I even generated the full 77010 possible configurations using that criterion and its always performing better.
The idea is not to fill the gaps in the .gz that exist, just add this logic when making the lookup. I am guessing it can be done without too much computational effort and it’s not even an interpolation or anything complex.
I am not sure if this has been proposed/attempted before, but if you see value on doing it i can do my best on helping to implement it. Either provide with a detailed explanation on the theoretical part (no big deal) or dig into the code and do it myself.
In the image you can see (plug cyan, proposal blue, .gz purple) they start perfectly with a known configuration on the .gz, then I move to three configurations in between .gz measurements and the proposal is almost always on the spot (actually the "error" is just the plugs rounding to one decimal, otherwise they would be the same value). On this example the purples error is around 5%.

As measuring is... very slow, it'd be interesting to be able to take a very loose sampling and use a technique like this to provide approximated calculations.

@dsolva I read you have a lot of experience with Machine learning algorithms, data science and math in general. I don't have so I'm probably not up to the task ;-). Sounds very promising. I did try my best to do some simple interpolation, but I only did that across one dimension (brightness).
You can give it a shot and try to implement if you want. I can give you some pointers to the relevant code:
Initial lookup dictionary is build here. Only once per startup of powercalc.
https://github.com/bramstroker/homeassistant-powercalc/blob/master/custom_components/powercalc/strategy/lut.py#L47
Interpolation between lower and higher brightness is done here. It's done each time the calculation is called (on state changes of the bind light).
https://github.com/bramstroker/homeassistant-powercalc/blob/master/custom_components/powercalc/strategy/lut.py#L194
Would this K-means algorithm only apply to color temp mode of als for HS mode? Because when you want to pre generate all possible configurations it would get massive.
Also it's important to do some quick checks about the computational overhead when generating the lookup tables. To make sure it doesn't delay the startup that much. This problem will get bigger probably on low end devices (like the raspberry pi's)
@CloCkWeRX
Even for approximation algorithms it needs enough data points to do any realistic proximations. Previously the default measure tool settings took a lot more data points. HS mode took more then a day to complete. We have lowered the requirements so each measure session will take max ~2 hours. Which seem fine by me as it is a one time job only per light.
Maybe @dsolva can advice if the amount of data points can be lowered still? But personally I'd like to keep up the quality of the LUT files by having a high number of real measured data points.

@bramstroker I only tested the model for color temp but certainly will try with hs and let you know. Given that the best performing algorith was KNN and its greatest weakness is carrying over its entire training set (which is already done by having de Lut file) I'm expecting no huge increment. I pregenerated the lookup table as an alternative to implementing this properly, once programed no massive tables will have to be generated beforehand. In terms of computational effort, it would be the same as looking for the 4 closest values in the original LUT file and thats it, the rest is simple math. Maybe as I understand the code I will se how the model can be adapted. Still I totally agree on testing it before to see the impact. I know my NUC might be doing well right now, but if we see a slightly questionable spike on loading time then it could be an option to the user to use the "approximation".
About @CloCkWeRX comments on minimum datapoints, what we can do is that I finish the champion model and I will throw at it all the existing LUT files and start dropping datapoints and test. It would be a sort of compression with loss. With that we can see the overall metrics of highest error and root mean squared error and see how much we are willing to give up. The model would be challenged for its capacity to recover the lost granularity. We will see how low we can go and still be able to reconstruct. For what I saw with my own measurement I would go below that for now, it feels like a sweet spot of granularity. Also I need to see how manufacturers put the bri, mired,etc values into the real world. For my Wiz lightbulbs some colors are very similar in consumption but other manufacturers might distribute their spectrum quite different, 10 increment in one value could mean something very different for each model and even change exponentially in the same bulb! Too many things, in the end, leveraging the entire model base we have will give us an answer.

Sounds promising. I also have a NUC btw. We can of course make it an option to activate the approximation. But when it does  not have any significant overhead I would opt to make it the default.

@dsolva Do you have any update? Still have plans to work on this in the near future?

@dsolva No worries, thanks for the update.

@dsolva I assume you are not working on this anymore? Do you still plan to continue working on this. Cleaning up the issue list, so when this is stale I will close the issue.

Closed due to inactivity. We can reopen when you want to work on this again.


kubeContext override is broken

Hello,
I use kubeContext override per release, and it's broken starting from v.0.106.0. Simple helmfile.yaml is following:
helmDefaults:
  kubeContext: default
releases:
  - name: cert-manager
    namespace: cert-manager
    version: v0.14.0
    chart: jetstack/cert-manager
    kubeContext: {{ env "KUBE_CONTEXT" | default ( printf "gke-%s" .Environment.Name ) }}

I see doubled --kube-context in debug log
helmfile -e dev -l name=cert-manager --log-level=debug diff
...
Comparing release=cert-manager, chart=jetstack/cert-manager
exec: helm diff upgrade --reset-values --allow-unreleased cert-manager jetstack/cert-manager --version v0.14.0 --tiller-namespace kube-system --kube-context gke-dev --namespace cert-manager --values /var/folders/0b/7qzzv73j7cg5sh97xds05c8r0000gn/T/values826630363 --kube-context default

Thus, kubeContext from release is ignored.
kubeContext in helmDefaults is dummy in my case and I use it as a safe plug to prevent  access to current k8s context while debugging (incorrect) releases which do not  specify kubeContext explicitly.

@voron Thanks for reporting. I'll see what's going wrong soon.

Maybe the issue is bigger, setting kubecontext works for me only inside release, not via helmfiles.
I have cascading structure with helmfiles like this:
# example-customer-helmfile
helmfiles:
- path: common/helmfile.yaml
- path: ../monitoring/prometheus/customers/helmfile.yaml
  selectors: [ customer=example ]

# common helmfile
helmfiles:
- path: ../common-charts/helmfile.yaml

In prometheus customers helmfile.yaml I defined several identical releases with different labels and kubectonext.  Then, when executing example-customer-helmfile, I see proper kubecontext picked up:
Comparing release=prom, chart=stable/prometheus-operator
exec: helm diff upgrade --reset-values --allow-unreleased prom stable/prometheus-operator --kube-context example-customer --namespace monitoring --values ...

For the common charts, I was hoping to define helmDefaults per customer, but it doesn't work like this:
helmDefaults:
  kubeContext: customer

helmfiles:
- path: common/helmfile.yaml
- path: ../monitoring/prometheus/customers/helmfile.yaml
  selectors: [ customer=customer ]

Neither does it work like this:
helmfiles:
- path: common/helmfile.yaml
  values:
  - kubeContext: customer
- path: ../monitoring/prometheus/customers/helmfile.yaml
  selectors: [ customer=customer ]

And not like this:
values:
- kubeContext: customer

helmfiles:
- path: common/helmfile.yaml
- path: ../monitoring/prometheus/customers/helmfile.yaml
  selectors: [ customer=customer ]

The only way common helmfile will pickup kubecontext is if i add it to the release definition like with customer prometheus helmfiles, so this seems to be the only way to enforce kubecontext:
releases:
- name: blackbox-exporter
  namespace: monitoring
  chart: stable/prometheus-blackbox-exporter
  kubeContext: customer

Environment:
helm version
Client: &version.Version{SemVer:"v2.16.6", GitCommit:"dd2e5695da88625b190e6b22e9542550ab503a47", GitTreeState:"clean"}
Server: &version.Version{SemVer:"v2.16.6", GitCommit:"dd2e5695da88625b190e6b22e9542550ab503a47", GitTreeState:"clean"}
helmfile --version
helmfile version v0.115.0 (and tried with previous release as well)

@mlushpenko Hey! Thanks for reporting.
Sorry, but I didn't get it.
Neither helmDefaults nor values are designed to be automatically propagated to sub-helmfiles.
Did you see anything other than that?

Oh, my bad then @mumoshu , I didn't realise that. Do you have suggestion in that case how to structure modular setup with helmfiles accross clusters?
For every chart that has to be deployed on all clusters, I could create a file similar to this:
releases:
- name: prom
  namespace: monitoring
  chart: stable/prometheus-operator
  labels:
    customer: customer-1
  kubeContext: customer-1
  values: [ customer-1 ]

- name: prom
  namespace: monitoring
  chart: stable/prometheus-operator
  labels:
    customer: customer-2
  kubeContext: customer-2
  values: [ customer-2 ]

And then have a folder with helmfile per customer like I showed above. Such setup currently allows me to run one command to apply monitoring changes across all clusters:
helmfile -f helmfiles/ -l name=prom sync --skip-deps

But creating such files with labels and kubectonext per customer for every chart seems like too much work/copying. Would be better to import whatever sub-helmfiles I need and then apply kubecontext to all of them or maybe you have some other idea.

@mumoshu it looks like v0.115.0 broke kubeContext per release completely. I see --kube-context  in debug with v0.114.0, but not with v0.115.0 with kubeContext per release. I don't have kubeContext defined in helmDefaults, I had to remove kubeContext from helmDefaults to make kubeContext per release to work after v.0.106.0.

It looks like v0.119.0 works with kubeContext per release again.
I still cannot combine  kubeContext from helmDefaults and kubeContext per release, I get doubled --kube-context in debug log and default context is the last and thus it wins, while we need release context to win.


[INF-138] Remove workaround for data not existing in response

Removes workarounds for the data object not being included in the response if no results were in the data response. Goes with bi-api INF-138.

 INF-138 - API result for GET /programs not returning an empty data array


timeouts ignored for Async calls

When testing with the Synchronous API and testing my timeouts I can see both:
SocketTimeoutException: connect timed out

and
SocketTimeoutException: Read timed out

however, when trying the Async calls timeouts are completely ignored

@naory could this be related to #64 ?

@naory can you please try again with the latest version?

thanks @thefosk, I will look to retest with the latest version.

the issue was on version 1.3.27.
I retested with 1.4.5. and it is working fine.


CreateButton does not change colour when disabled

Problem
When setting disabled={true}, the CreateButton component does not change color.
Which means there is no visual clue that the button is disabled by default.
The developers needs to manually set a style on the button to change the color based on the disabled property.
Solution
Make it a default behavior to change to a grey-ish background color (it can be se per theme) when disabled.

@Szymx95 can you please review, is it an easy change?


Using a property from the object to validate another property

Hello.
I need to do something like this
RuleFor(p => p.Value).Matches(p => p.Regex).WithMessage("Regex");
where p.Regex is a valid Regex... does this works or is there a way to make it work?

The matches method takes either a string or a Regex instance, not a lambda. You should instead use Must to do the work:
RuleFor(x => x.Value).Must((model, value) => model.Regex.IsMatch(value)).WithMessage("Regex");

Regex is a valid regex but on a string format so i can't do Regex.IsMatch

In that case just construct a Regex object inside the Must call

eg:
RuleFor(x => x.Value).Must((model, value) => new Regex(model.Regex).IsMatch(value)).WithMessage("...");

That worked


Fix error when lauching in windows

Code from linux font loader was executed causing error at startup

The FontLoaderLinux should not be instanciated at all on a Windows environment. Do not change it as it is not the source of the problem. It seems there is something wrong with the get_font_loader_class module function. Please investigate this way.

The FontLoaderLinux is not instanciated, it seems this code is executed when loading the fonts_loader file.
Which makes sense since this is not specific to each instance.
I believe that's the way python load classes.

Ah, true

But I do agree this fix is ugly.
My first attempt to fix this was to move the code to the init() method, but this made some tests crash.
maybe we can update the tests for it to work this way.

We can use os.path.expanduser in an elegant way I think.

So, this fix allows to keep the two class variables as parameters (as intended), while the actual access to the user directory is processed within the methods.

Can't approve my own pr, but I approve of all the changes you made


Adds celerybeat db to gitignore

When testing "production mode" locally, celery of course generates it's task scheduling database for celery beat. It doesn't really make much sense to track this with any VCS :)
Might also be nice to add this to #460 ?

Thanks @originell!

Yay :yellow_heart: so nice :D


[Bug]: Log In broken link from register page

Is there an existing issue for this?

[X] I have searched the existing issues

Describe the bug
Encountered a broken link on the Register page when attempting to navigate to the Log In page. Clicking the "Sign In" button results in a "Page Not Found" error, displaying the message: "Looks like you've followed a broken link or entered a URL that doesn't exist on this site." This issue prevents users from accessing the login functionality, hindering the registration process.
Expected behavior
When a user clicks on the "Sign In" button from the Register page, they should be redirected to the Log In page without any errors. The Log In page should load correctly, allowing users to enter their credentials and access their accounts.
Add ScreenShots

On which device are you experiencing this bug?
No response
Record

[X] I have read the Contributing Guidelines
[X] I'm a GSSOC-EXT contributor
[X] I'm a HACKTOBERFEST contributor
[X] I have starred the repository

@AbhijitMotekar99 go ahead!


looks like strings containing newlines (not \n) are parsed but result in nonsense concat translations

i guess it should either interpret the string correctly or throw a syntax error if we don't actually support things that look like that

Yeah, I mean this should just work. Our language is simple enough that multiline strings are pretty unambiguous.

already fixed


[WIP] Fix glob nd hive sync in deltastreamer tests

What is the purpose of the pull request
(For example: This pull request adds quick-start document.)
Brief change log
(for example:)

Modify AnnotationLocation checkstyle rule in checkstyle.xml

Verify this pull request
(Please pick either of the following options)
This pull request is a trivial rework / code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)

Added integration tests for end-to-end.
Added HoodieClientWriteTest to verify the change.
Manually verified the change by running a job locally.

Committer checklist

[ ] Has a corresponding JIRA in PR title & commit

[ ] Commit message is descriptive of the change

[ ] CI is green

[ ] Necessary doc changes done or have another open PR

[ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

the CI will fail. but if you can put screenshots showing which testcases become passing with this patch, would be great


second and third generics on Generator should be optional

Generator[int, None, None] is super gross, especially since they are pretty much never used

would need some kind of default type parameter support first, can you raise that?

i dont understand how it works enough, maybe you should

idk if this is related, being able to specify an arbitrary number of type parameters to Generic? https://github.com/KotlinIsland/basedmypy/issues/126


Invite friends modal fixes

lllustration doesn't overflow width on desktop
Phone number state clears correctly on submit

cc @keybase/y2ksquad

Added nicer error for rate limit


UIButton: Using gradients + state colours broken.

I've just noticed an odd behaviour while I'm writing the first set of tests. If you set a button gradient colour, then set block colours for button states, then the clipping is wrong. Here is the theme:
Button {
    background-color-top: @redColor;
    background-color-bottom: @greenColor;
    background-color-disabled: @blueColor;
    background-color-highlighted: @yellowColor;
    background-color-selected: @cyanColor;
    border-color: @primaryBorderColor;
    border-width: @primaryBorderWidth;
    font-color: @secondaryFontColor;
    font-color-highlighted: #666666;
    font-name: @primaryFontName;
    font-size: 17;
    height: 37;
    corner-radius: 8;
    padding: 7;
}

Normal state:

Disabled state:

Highlighted state:

Selected state:

I know it's ugly but its purely a test :)

Should be fixed by 32b8a338b309c9cafdca8021184a298330ba4a6f

Note: Assumed fix is a year older than the issue. Tested this by plugging the given theme into the demo project though. Could not reproduce issue anymore.


Property edit window not reused

Most likely this is not a bug, but it seems to me that it does not make sense to open a new edit window each time the same property is clicked for edit. Maybe it would be enough to bring any other previous edit window to the front, in case it got hidden by other Morphs in the display. But not a new window every time I hit the property.

On 2022-12-09 03:12, Ricardo Pacheco wrote:

Most likely this is not a bug, but it seems to me that it does not make
sense to open a new edit window each time the same property is clicked
for edit. Maybe it would be enough to bring any other previous edit
window to the front, in case it got hidden by other Morphs in the
display. But not a new window every time I hit the property.

This is a tough call, but it seems to me that every time you ask for a
new window or panel you should get one.
World Menu -> Windows -> Find Window
is your friend..
-KenD

I buy it. Thanks a lot for the tip!


Added animated faq section with both dark and light mode

Title and Issue number

**Title: Enhance the ui of FAQ page
**Issue No.: #313
Close #313
https://github.com/user-attachments/assets/6069f36d-2165-4a66-9bb2-e3cda4a7e8ed
Created theme oriented faq page with best design
design for both dark and light theme
uses modular css to make it customizable whenever you need
easy to add backend as i have populate data from array
maked its ui clean and clear
good user experience
if more enhancement required i am ready to do !!
can i get level 3 for it ?
Checklist:

[ X] I have mentioned the issue number in my Pull Request.
[ X] I have commented my code, particularly in hard-to-understand areas.
[ X] I have created a helpful and easy-to-understand README.md if it's a new page/tech stack.
[X ] I have gone through the contributing.md file before contributing.

Additional context (Mandatory):
Are you contributing under any Open-source programme?

[ X] I'm a GSSOC-EXT contributor
[ X] I'm a HACKTOBERFEST contributor

Well done @Sawan-Kushwah


Some ui fixes

fix a missing argument for handling an event /fixes #317
allow mutliple command line inputs and clean up the code around keeping history/rerunning /fixes #321

/cc @dtabwhite @eherot

WIP => when done also /fixes #897

Finished changes now, overall:
/fixes #897
/fixes #321
/fixes #317
/fixes #945

Does this pull request add support for properties like requiredSlaveAttributes on the request create/edit forms?

@bradjorgensen it is not in this PR, we can add it into another one


Chat timerange picker

When in responsive should open to the right not left :)

It does it properly when in mobile view but does not do it properly as you reduce the size of the window and it starts being displayed on 2 lines

No need for the hovers they interfere with the rest of the UI when on 2 lines and they don't really bring a lot of additional value do they?

lint error from connectors?


Please create a note explaining Real-Time Analytics

https://learn.microsoft.com/en-us/fabric/real-time-analytics/overview

Hi, I can work on this. Is it already in development?


Skipping latex tasks does not work when latexmk is not installed

Hey!
As the title says, when I try to skip a task marked with pytask.mark.latex, I get an error unless latexmk is installed. I imagine you already know this, but I've included a use case and an MRE below, nevertheless.
Use Case
I run/develop a project on multiple machines and want to skip latex- related tasks on some of them; and I do not want to install latexmk on them.
MRE
Using pytask's conftest.py:
from pytask import cli, ExitCode
import textwrap

def test_pytask(runner, tmp_path, monkeypatch):
    source = """
    from pathlib import Path
    from pytask import mark

    @mark.skip()
    @mark.latex(script=Path("document.tex"), document=Path("document.pdf"))
    def task_compile_latex_document():
        pass
    """
    # Works with latexmk in PATH.
    tmp_path.joinpath("task_module.py").write_text(textwrap.dedent(source))
    result = runner.invoke(cli, [tmp_path.as_posix()])
    assert result.exit_code == ExitCode.OK

    # Fails with latexmk removed from PATH.
    monkeypatch.setenv("PATH", "")
    tmp_path.joinpath("task_module.py").write_text(textwrap.dedent(source))
    result = runner.invoke(cli, [tmp_path.as_posix()])
    assert result.exit_code == ExitCode.FAILED

    # Print error message
    print(result.stdout)

Which produces:

Versions

pytask: 0.5.1
pytask-latex 0.4.2
python: 3.13

Thanks for the fantastic reproduction! pytask-latex probably checks for latexmk before we evaluate the skip. Maybe we want to check for latexmk only right before the execution.

That would be a nice solution. But wouldn't that imply that, for example, pytask collect won't throw an error if latexmk is not installed (even if there is no skip present)? Though, maybe pytask collect shouldn't raise an error in that case anyway.


Add underline support

Hello,
Could we add a UnderlineExtension in a new artifact commonmark-ext-gfm-underline? It would be a cousin class of the existing StrikethroughExtension in artifact commonmark-ext-gfm-strikethrough, with few little changes on this new class and others related to.
If you agree this issue, I could submit a pull request. However, I just need to know which delimiter should be the more accurate to do so.
I thing we should use an "easy to use" character on both QWERTY and AZERTY keyboards (and some others?), with a double occurrence. Here are some proposals: -- or && or %%.
Thank you in advance for your feedback.

Hey :).
Can you point me to an existing Markdown implementation that has support for this? From this StackExchange question, it looks like this is not really something that is intended.
I'm also interested in your use case, what do you need this for? And is the HTML support not suitable to do this (e.g. use foo)?

I had been reading the same StackExchange question and I understand the answer, only regarding the Markdown philosophy (more or less "meaning versus presentation"). I also notice the underline is not easy to read and should introduce some confusion with the conventional rendering of hyperlinks.
In my use case, I want to allow my final user to easily format a text with understandable code (not HTML code). So I think Markdown can help me to do this easily and efficiently. But the underline feature is one of the favourite features needed by these end users (with the 2 existing levels of emphasis which are traduced by italic and bold presentation) and is not in the Markdown perimeter.
I can't use foo because my end user will forget the / to close the tag, or make any other mistake. It would also force me to break the user input escaping of my UI framework to rebuild it with my small arms, just for a  tag.
So, as your implementation offers a strikethrough extension, which doesn't seem to be part of the Markdown specification, I suggest to had an underline extension. As I understand, as an extension, it won't change the default implementation which respects the Markdown specification.
I know the  tag is a semantic one contrary to the  one, but I think it should be a useful feature in some case.
Note: looking for markdown implementation with underline, I found a source talking about the  tag. This little-used tag mean that its content has been inserted and the default presentation is to underline the text.

If  would work for you, I think it would be ok to add it as an extension. There's precedence for the ++ syntax as well:

https://github.com/markdown-it/markdown-it-ins
https://github.com/aleray/mdx_del_ins

Do you want to contribute this extension? It should be fairly simple, it should work the same way as the strikethrough extension. We could probably call it commonmark-ext-ins.

Thank you for  references you found on other projects. The ++ seems to make sense !
I tried to contribute this extension which should be quite simple, but I'm facing an unexpected issue with my development environment (Eclipse) which is not able to build the project. It seems that I can't access the Atlassian repositories to get few dependencies.
Unfortunately, I don't think I will have enough time during next weeks to solve this problem. If someone could take it in charge, it would be great. If not, I will try to do it when I have some time to do so.

It seems that I can't access the Atlassian repositories to get few dependencies.

Really? All the dependencies are in Maven Central. Can you add the full error message here?

If not, I will try to do it when I have some time to do so.

Cool, let me know if you have any other problems.

@pabranch contributed this, see linked pull request above :). I'm keeping this issue open until it's in a released version.

New PR #61 to add the InsExtension to the integration tests. Missed it the first time around, sorry 'bout that.

Released 0.7.0 with these changes, thanks @pabranch and @rjoly 🎉: https://github.com/atlassian/commonmark-java/releases/tag/commonmark-parent-0.7.0


JMX integration should be split into its own module

Considering the need for linking java.management to even load JMX, this should be separated into its own module.

Closing this, since JMX has been removed.


Is the actual sdk free to use?

For a commercial app

Hi @srameshr, the actual SDK is not free for a commercial app.
See https://www.photoeditorsdk.com/pricing#contact
Cheers
Daniel

Well I guess this can be closed then :)


Swift 5 not supported?

Swift 5 not supported?
Have any plan?

Hi @hsleedevelop Hey! It will be available in couple of days. Will let you know.

Hello @hemangshah
Are you going to update it to the last Swift version?
Thank you

@bill350 and @hsleedevelop sorry for the delay, I've planned it for this week.


special matrix dropdown with radiogroup columns

Are you requesting a feature, reporting a bug or asking a question?
requesting a feature / asking question
What is the current behavior?
I am replacing an old lime survey configuration with surveyJs
I have a matrixdropdown element, with 2 radiogroup columns
lets say for example that I have a radioGroup 1 that is a question like :
"did it goes well ?" with choices : very bad, bad, well, very well
and a radioGroup 2 with a question "was it long ?" with choices : short long, very long
I am displaying it like that  (the "o"'s are the radio button)  :

_______|___________"did it goes well ?"__________|_________"was it long ?"________|
part 1__|__o verybad_o bad_o well_o very well__|__o short_o long_o very long__|
part 2__|__o verybad_o bad_o well_o very well__|__o short_o long_o very long__|

What is the expected behavior?
I want it to be displayed the way matrix shows it, column headers being the choices, and column only radiobutton
_______|__very bad_|_bad_|_well_|_very well_||_short_|_long_| very long |
part_1__|______o_____|__o__|___o__|____o_____||___o___|___o__|_____o____|
part_2__|______o_____|__o__|___o__|____o_____||___o___|___o__|_____o____|

adding another header with the question will be better, something like :

_______|________"did it goes well ?"_________||_______"was it long ?"_____|
________|__very bad_|_bad_|_well_|_very well_||_short_|_long_| very long |
part_1__|______o_____|__o__|___o__|____o_____||___o___|___o__|_____o____|
part_2__|______o_____|__o__|___o__|____o_____||___o___|___o__|_____o____|

Provide the test code and the tested page URL (if applicable)
Tested page URL: https://plnkr.co/edit/DQPIllPZRSKza77GRJZj?p=preview

I also wanted to change paneldynamic template to make it like a table, to have the remove button in the same line (row) like the panel to remove. something like this :
module.exports = "";
is it possible without changing survey.angular.js ??

@MugiwaraNoMehdi I would not suggest to change the template, since we may change it in the next version(s).
Will this example work for you?
You may put these two questions into a panel.
Thank you,
Andrew

The panel is a good Idea but it repeat part1 and part 2
Here is the result with limesurvey :

limesurvey has some options that could be very nice to add to surveyJs

for the template of panel dynamic, here is the picture of the two results, may be you will understand why I am doing this, here is the picture of my question with the original template :

and with the modified template :

@MugiwaraNoMehdi There are two separate issues.
The first one, I would suggest to use the onAfterRenderQuestion event.
Here is the example.
Regarding adding this functionality in limesurvey. How do they do it? Do they have the list of columns with a header? Do they store the results separately? What about "none answer", is it a special option?
Regarding the second issue. I would agree that it definitely looks better for this layout.
Thank you,
Andrew

@MugiwaraNoMehdi I have created the separate issue for the second problem.
Thank you,
Andrew

thank you, it's my fault since I knew the issues were totally unrelated...
for the first issue, in Limesurvey, when you have a matrix like, you can give it questions as columns, like in surveyJs, but the rendering of a radiogroup will result in the picture I have posted, I think it's better than rewriting the radio labels as many times as you have rows, and for the "no answer", it's because you can't undo a selection for radio button, so there is an option to add it for a radiogroup, and when you have 2 radiogroups with this option, it is displayed one time only at the end of the table like it is in the picture.

I dont know if my explanation was good, but i'll try explaining it better.
If you select a choice on a radiogroup, you can't unselect-it, so you can add an option to have "no answer" at the end, and it's like you unselected your answer, it is the default value and the result will be like you have not answered the question.
when you have 2 radiogroups (or more) with this option, and you add them to a matrix columns, it can be rendered as many times as you have radiogroups, or just once at the end. I think it's a good option.

in limesurvey, if you add in matrix columns a textArea, the header of the column will be the textArea label, and the content of the column will be the textArea, same thing if you add input text or datepicker.

+1 for the LimeSurvey style matrix radio groups. I used that question type a lot in the past. It would be great to be able to replicate that in SurveyJS (which, by the way, is much easier to work with than LS since it uses more a modern approach). LimeSurvey has been around for quite a while so SurveyJS could benefit from their experience about what has been needed by their users.


[QUESTION] Do you plan moving some of these issues to the main Windows development team?

I mean, some of them might actually be bugs in Windows itself or even overlooked improvements that make more sense as being part of the real thing and not a Power Toy... Like #135 that I've opened a couple days ago.
I just realised that that request might actually make more sense as part of the virtual keyboard core behaviour, just like some other issues here...

Per my comment in #135, the Windows Feedback Hub is the official way to get feedback to the Windows Shell team.  There are certainly some great ideas here which could apply more broadly than to just power users and developers, however the bulk of these suggestions really wouldn't make sense for 80%+ of Windows users.
The goal of the PowerToys project is to help optimize Windows for power users and developers with widgets and utilities that wouldn't give an optimum experience for the bulk of the Windows user base.

Alright
I'll open some of my issues there as well, then.
Thanks, @indierawk2k2


docs(servers): order by github stars and npm downloads

Coverage remained the same at 84.516% when pulling 0dda29af3f811b56454da408827592cbdc59396f on docs-servers into b47e0a56f67ae843ed57333d537515f34a16d5fc on master.


How can i block youtube ,facebook and google share using cookie consent.

Please help me, I trying to implement cookie consent on my website. I need to provide a checkbox for user acceptance like Marketing,  analytics etc . how can I implement these using cookies consent?

This isn't something that cookie consent is designed for. This tool only provides a yes/no acceptance for cookies. I believe this is something that may be done by a tool we are making to deal with GDPR compliance, but I'm not currently involved in the development of it, so I cannot say for certain.


Instructions for adding and testing new python modules needed

If I submit a new notebook for my connector and it has one or more modules that are not used by the foundation course I need to know if/when these get installed so that I can test my notebook on the remote hub.  I cannot use the jupyter notebook hub environment if I cannot get these modules installed  a week before I distribute an assignment so that I can test it. What is the process for ensuring this? Should I upload the notebook and then add a new issue to install any needed modules? If you could add some info on this to the documentation that would be great.

In terms of procedure and policy I'll defer to @papajohn.
But I think it would be good to create a new issue and attach your notebook to it. We'll try to integrate any additional libraries that your notebook specifies. The more lead time we have the better.
When we do update the single user server with new software, it requires that students stop and start their server.

I like Ryan's plan of creating an issue. Ryan will be the central point of
contact for adding new modules.
On Tue, Jan 19, 2016 at 11:37 AM, Ryan Lovett<EMAIL_ADDRESS>wrote:

In terms of procedure and policy I'll defer to @papajohn
https://github.com/papajohn.
But I think it would be good to create a new issue and attach your
notebook to it. We'll try to integrate any additional libraries that your
notebook specifies. The more lead time we have the better.
When we do update the single user server with new software, it requires
that students stop and start their server.
—
Reply to this email directly or view it on GitHub
https://github.com/data-8/connector-instructors/issues/8#issuecomment-172961881
.

Hey all - is Ryan's response going to be the party line on how to deal with adding new modules? If so I can add it to the Readme and then I'll close this...

Yes, thanks Chris.

OK, added this to the readme in the FAQ section


useless change

add rpc

Looks good, just need to format the code and I can merge it in.

Looks good, just need to format the code and I can merge it in.


Data Extractor, multiple rows and optimizations

Much work needed on the "Data extractor" facility.
Optimize queries (each table queried at most once)
For multiple-row returning, some thinking is needed (perhaps even just another extractor altogether?)

Multiple rows left out of scope for now.

shipped 0.1.3


Error message when trying to connect with MongoDB

Repro steps:

Action: cosmosDB.attachDatabaseAccount
Error type: Error
Error Message: {"name":"cluster0-shard-00-02-lixgw.mongodb.net:27017","err":{"name":"MongoError","message":"bad auth Authentication failed.","ok":0,"errmsg":"bad auth Authentication failed.","code":8000,"codeName":"AtlasError"}}
Version: 0.10.1
OS: darwin
VS Code Version: 1.33.1

Call Stack
Function.MongoError.create (dist/node_modules/mongodb-core/lib/error.js:31:11)
dist/node_modules/mongodb-core/lib/topologies/replset.js:1253:38
dist/node_modules/mongodb-core/lib/connection/pool.js:760:7
dist/node_modules/mongodb-core/lib/connection/pool.js:736:20
finish (dist/node_modules/mongodb-core/lib/auth/scram.js:168:16)
handleEnd (dist/node_modules/mongodb-core/lib/auth/scram.js:178:7)
dist/node_modules/mongodb-core/lib/auth/scram.js:269:11
dist/node_modules/mongodb-core/lib/connection/pool.js:469:18
process._tickCallback (internal/process/next_tick.js:61:11)

It looks like an authentication error. Did using the same credentials work in the shell?
Does your password/primary key contain symbols like "@", '/' , etc. ?

Try this connection string format:
<EMAIL_ADDRESS>If you have a cluster's connection string with servers' names like:
cluster0-_shard-00-00-_jxeqq.mongodb.net
modify your server's name by removing shards' info so your <cluster_name> looks like this:
cluster0-jxeqq.mongodb.net

Closing this due to inactivity.


Update CORS support

CORS response headers should only be returned for preflight OPTIONS calls by the browser. Also, we should be able to specify whether or not we want these headers to be returned.
See here for more information on CORS support for browsers.

Fixed via #100


Can't Enable Scroll Reverser

I am using v1.8 on macOS Big Sur
the scroll reverser icon is greyed out in the status bar. when I try to enable Scroll Reverser, the window shakes once and the checkbox becomes unchecked

Images

Hi there, thanks for the great report with GIF.
This is due to a bug in macOS which sometimes happens.
I have some steps for you which ought to resolve it:

Quit Scroll Reverser.
Ensure Scroll Reverser is located in your Applications folder and not in any other location.
Go to System preferences → Security & Privacy → Privacy
In the Accessibility category, use the "–" button to remove Scroll Reverser from the list.
Then click the "+" to add Scroll Reverser to the list again, and enable it.
Now restart Scroll Reverser.

Thanks! that fixed the problem

Use the "–" button to remove Scroll Reverser from the list, then click the "+" to add it back.

It was important to do this step for both of Accessibility and Input Monitoring.


Out of bound memory access in TLSF implementation

previous issue
Well, after some test, I believe the bug still exist.
I add a assertion in the vma header as followed:
void VmaBlockMetadata_TLSF::InsertFreeBlock(Block* block)
{
    // ...
    uint32_t index = GetListIndex(memClass, secondIndex);
    VMA_ASSERT(index < m_ListsCount); // THE ASSERTION
    block->PrevFree() = VMA_NULL; // Line 10342
    block->NextFree() = m_FreeList[index];
    m_FreeList[index] = block;
    if (block->NextFree() != VMA_NULL)
    // ...

And in the example code (compiled in debug mode)
#define VMA_IMPLEMENTATION
#include "vk_mem_alloc.h"

#include <cstdio>
#include <cstdlib>

VmaVirtualBlock block{VK_NULL_HANDLE};

int main() {
	{
		VmaVirtualBlockCreateInfo info = {};
		info.flags = VMA_VIRTUAL_BLOCK_CREATE_TLSF_ALGORITHM_BIT;
		info.size = 50331648;
		vmaCreateVirtualBlock(&info, &block);
	}
	{
		VmaVirtualAllocationCreateInfo info = {};
		info.alignment = 2;

		VmaVirtualAllocation allocation[3] = {};

		info.size = 576;
		vmaVirtualAllocate(block, &info, allocation + 0, nullptr);

		info.size = 648;
		vmaVirtualAllocate(block, &info, allocation + 1, nullptr);

		vmaVirtualFree(block, allocation[0]);

		info.size = 720;
		vmaVirtualAllocate(block, &info, allocation + 2, nullptr);
	}
	return 0;
}

the assertion fails, which indicates there are surely some memory access errors.
This can cause segfault in more complex scenarios.

Hi and thank you for bringing up this issue! Unfortunately when I tested it with code you provided the mentioned assert did not fire. Could you please share what values are present in variables memClass, secondIndex, index and block->size? It would help me to debug this further. Also on what machine are you running this, 32 or 64 bit?
Marek Machliński, Developer Technology Engineer Intern, AMD

(here's the only modifications in vma header https://github.com/AdamYuan/VulkanMemoryAllocator/commit/22c49610c646cc9ea55469f6ed22023e2a36820b)
Before the assertion failure, I print these variables and get the following
memClass = 47
secondIndex = 32
index = 1536
m_ListsCount = 1025
block->size = 576

The machine I use is 64 bit and the compiler is g++ (GCC) 11.1.0

Thank you for that data. Could you in your setup change the contents of the function uint8_t VmaBitScanMSB(uint64_t mask) (line 3125) to disable compiler intrinsic for your platform and fallback to classic loop and then post results?
Marek Machliński, Developer Technology Engineer Intern, AMD

Disabling the usage of builtin_clzl:
memClass = 248
secondIndex = 32
index = 7968
m_ListsCount = 7969
block->size = 576

but the following compiler warning occurs
vk_mem_alloc.h:3136:23: warning: left shift count >= width of type [-Wshift-count-overflow]
 3136 |     uint64_t bit = 1u << 63;
      |                    ~~~^~~~~

I changed the line to
    uint64_t bit = 1ull << 63;

and then got this
memClass = 2
secondIndex = 4
index = 68
m_ListsCount = 593
block->size = 576

I changed to builtin_clzl line to
         return 63 - static_cast<uint8_t>(__builtin_clzl(mask));

and also got
memClass = 2
secondIndex = 4
index = 68
m_ListsCount = 593
block->size = 576

Can you please check if the bug is fixed now?

I think it is fixed, no segfault anymore. Thanks!

This is great. Thank you for reporting this bug.


Values of the parameter pixels

Hello, in the article,
The values of the parameter pixels were chosen empirically in the range **[-1.50,1.30] with spaces of 0.05**. These values were selected to match the existing range in the Lytro dataset.
This refocused coefficient is for Lytro dataset, but in the current python code it is mentioned that the coefficient range is only half of the article, how should I set this range if I want to train for Lytro dataset?  What does "an additional resizing step" mean? Will it have a critical impact on the training?

Is there anyone, please?

Hello!
First, let me apologize for not responding to your first mail. I have busy
times at work lately and I simply missed it.
Originally I trained the network using data that was interpolated. That
means that I used a synthesis network to generate the in-between views of a
9x9 light field grid, to get a field of 17x17.
Then I computed one ground truth refocused image for each focus using the
17x17 grid, by shifting and averaging (traditional refocusing method).
The interpolation was needed in order to smooth the ground truth refocused
image.
I am not sure I understand your question. Are you trying to re-train on the
data? Do you have a code for training?
Regards,
Shachar
בתאריך שבת, 8 בינו׳ 2022, 13:56, מאת sky-fly97 @.***>:

Is there anyone, please?
—
Reply to this email directly, view it on GitHub
https://github.com/shacharBD/LightFieldRefocusing/issues/4#issuecomment-1007969802,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AHWWK5EZZKMCNUACYYEVN7LUVAQ53ANCNFSM5KC5ANDQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

Hello! First, let me apologize for not responding to your first mail. I have busy times at work lately and I simply missed it. Originally I trained the network using data that was interpolated. That means that I used a synthesis network to generate the in-between views of a 9x9 light field grid, to get a field of 17x17. Then I computed one ground truth refocused image for each focus using the 17x17 grid, by shifting and averaging (traditional refocusing method). The interpolation was needed in order to smooth the ground truth refocused image. I am not sure I understand your question. Are you trying to re-train on the data? Do you have a code for training? Regards, Shachar בתאריך שבת, 8 בינו׳ 2022, 13:56, מאת sky-fly97 @.>:
…
Is there anyone, please? — Reply to this email directly, view it on GitHub <#4 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHWWK5EZZKMCNUACYYEVN7LUVAQ53ANCNFSM5KC5ANDQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub. You are receiving this because you are subscribed to this thread.Message ID: @.>

Thank you very much for your reply.I am not understanding the different ranges of Matlab and python code that you mentioned. [-1.50,1.30] or [-0.75, 0.65]?
Note: Original code for shifting and refocusing was written in Matlab, and was using an additional resizing step. The current python code does not include this step and therefore the parameter "focus" should be half of the range that was mentioned in the paper **(-0.75 instead of -1.50, etc.).**
I currently want to retrain the network and improve its performance, but I don't have the training code yet, could you share the training code with me？ I would appreciate it if you could!

Hi!
Regarding the training code - I do not have it available. I only released
the inference code.
Regarding the refocusing range: originally I added another resizing step to
the code, which was written in matlab. In this release, I transferred this
code to python, so it would be more compatible with the rest of the code. I
adjusted the code without the resizing step, so the focus parameter needs
to be halved for the same dataset. However, if you use a different dataset,
the focus parameter will probably be different anyway. In this case, you
can run with different focus ranges and find the correct parameter
empirically.
Please let me know if you have any questions! You can also send me a direct
email if it's easier for you.
Regards,
Shachar
On Sun, Jan 9, 2022 at 5:55 PM sky-fly97 @.***> wrote:

Hello! First, let me apologize for not responding to your first mail. I
have busy times at work lately and I simply missed it. Originally I trained
the network using data that was interpolated. That means that I used a
synthesis network to generate the in-between views of a 9x9 light field
grid, to get a field of 17x17. Then I computed one ground truth refocused
image for each focus using the 17x17 grid, by shifting and averaging
(traditional refocusing method). The interpolation was needed in order to
smooth the ground truth refocused image. I am not sure I understand your
question. Are you trying to re-train on the data? Do you have a code for
training? Regards, Shachar בתאריך שבת, 8 בינו׳ 2022, 13:56, מאת sky-fly97
@.
>: … <#m_4743825262422078394_> Is there anyone, please? — Reply to this
email directly, view it on GitHub <#4 (comment)
https://github.com/shacharBD/LightFieldRefocusing/issues/4#issuecomment-1007969802>,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AHWWK5EZZKMCNUACYYEVN7LUVAQ53ANCNFSM5KC5ANDQ
https://github.com/notifications/unsubscribe-auth/AHWWK5EZZKMCNUACYYEVN7LUVAQ53ANCNFSM5KC5ANDQ
. Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you are subscribed to this thread.Message
ID: @.>
Thank you very much for your reply.I am not understanding the different
ranges of Matlab and python code that you mentioned. [-1.50,1.30] or
[-0.75, 0.65]?
Note: Original code for shifting and refocusing was written in Matlab, and
was using an additional resizing step. The current python code does not
include this step and therefore the parameter "focus" should be half of the
range that was mentioned in the paper (-0.75 instead of -1.50, etc.).
I currently want to retrain the network and improve its performance, but I
don't have the training code yet, could you share the training code with
me？ I would appreciate it if you could!
—
Reply to this email directly, view it on GitHub
https://github.com/shacharBD/LightFieldRefocusing/issues/4#issuecomment-1008323776,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AHWWK5AGJKZAK7XWH3K46ETUVGVXZANCNFSM5KC5ANDQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you commented.Message ID:
@.***>

Hello, sorry to interrupt again, I have a new problem in the reproduction process~
Refocusnet is implemented in the paper, compared with the traditional algorithm, but the traditional method generally uses a 5D matrix (u,v,h,w,c) to input and achieve refocusing. But now if we use 22 views in the shape of a rhomboid , how can we achieve refocusing by the traditional refocusing algorithm? Is it by arranging these four views into 22 (2,2,h,w,c) for input?

Can I get your email, maybe it will be easier to ask for advice

Hi, of course! Please send me your email so we can discuss :)
בתאריך יום ה׳, 3 בפבר׳ 2022, 4:48, מאת sky-fly97 @.***

:

Can I get your email, maybe it will be easier to ask for advice？
—
Reply to this email directly, view it on GitHub
https://github.com/shacharBD/LightFieldRefocusing/issues/4#issuecomment-1028551856,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AHWWK5EXKJEDSUAYMEEQS4TUZHUGRANCNFSM5KC5ANDQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you commented.Message ID:
@.***>

Thanks， my email is<EMAIL_ADDRESS>

Hi, of course! Please send me your email so we can discuss :) בתאריך יום ה׳, 3 בפבר׳ 2022, 4:48, מאת sky-fly97 @.***
…
: Can I get your email, maybe it will be easier to ask for advice？ — Reply to this email directly, view it on GitHub <#4 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHWWK5EXKJEDSUAYMEEQS4TUZHUGRANCNFSM5KC5ANDQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub. You are receiving this because you commented.Message ID: @.***>

Thanks， my email is<EMAIL_ADDRESS>

Maybe this problem needs your help too, thanks~

Hello, sorry to interrupt again, I have a new problem in the reproduction process~ Refocusnet is implemented in the paper, compared with the traditional algorithm, but the traditional method generally uses a continuous 5D matrix (u,v,h,w,c) to input and achieve refocusing. But now if we use 2 * 2 discrete views in the shape of a rhomboid , how can we achieve refocusing by the traditional refocusing algorithm? Is it by arranging these four views into 2 * 2 (2,2,h,w,c) for input?

Maybe this problem needs your help too, thanks~


Add latest version check and unit test isValidReleaseVersion

What this PR does / why we need it:
Add latest version check and unit test isValidReleaseVersion
Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes #
Checklist

[x] Subject and description added to both, commit and PR.
[ ] Relevant issues have been referenced.
[ ] This change includes docs.
[ ] This change includes unit tests.

/lgtm
thx!


Possible Garbage Collection Bug in Pharmacophore Generation

I've encountered a bug involving the Python API when a FeatureFactory is defined inside a method and the output features are returned and accessed by the caller. Specifically, this results in MemoryError when you try to access the family name with GetFamily(), but for some reason GetType()/GetFactory() doesn't result in an error. I haven't tried the latest source, so this may be now fixed. Thanks!

RDKit Version: 2018.03.02
Platform: Fedora 29 (Installed from package manager)

from rdkit import Chem
from rdkit.Chem import ChemicalFeatures

def extract_features_from_mol(m, factory):
    return factory.GetFeaturesForMol(m)

def extract_features_from_mol_memory_error(m):
    factory = ChemicalFeatures.BuildFeatureFactory("BaseFeatures.fdef")
    return factory.GetFeaturesForMol(m)

m = Chem.MolFromSmiles('OCc1ccccc1CN')

# No error
factory = ChemicalFeatures.BuildFeatureFactory("BaseFeatures.fdef")
feats = extract_features_from_mol(m, factory)
print(feats[0].GetFamily())

# Memory error
feats = extract_features_from_mol_memory_error(m)
print(feats[0].GetFamily())

Confirmed that there's a problem here with v2019.03.4 as well.
What's going on is that the lifetime of the factory isn't being tied to the lifetime of the features themselves.
This should be fixable.


[main] Upgrade to latest dependencies

Cron -knative-prow-robot
/cc knative-sandbox/client-writers
/assign knative-sandbox/client-writers
Produced by: knative-sandbox/knobots/actions/update-deps
Details:
bumping knative.dev/serving 2858ef6...1c335d7:
  > 1c335d7 Update net-istio nightly (# 12023)
  > b225e6e upgrade to latest dependencies (# 12018)
bumping knative.dev/client 47558c1...d669111:
  > d669111 upgrade to latest dependencies (# 1452)
  > e89bdc7 Update community files (# 1451)
  > ae5bce3 Update actions (# 1453)
bumping knative.dev/eventing dcb0aea...f031ba2:
  > f031ba2 upgrade to latest dependencies (# 5744)
bumping knative.dev/pkg a49a60e...5ae4821:
  > 5ae4821 [release-0.26] Source validation fixes (# 2291)

/approve
/lgtm


Add quotes to multiword arguments.

This adds quotes around multiword arguments before they are passed to
/bin/sh -c in an exec command.
Example:
I connect to irc like this:
exec termite -e "mosh server tmux a"

Without this patch the arguments are passed to sh as:
termite -e mosh server tmux a

When it should be:
termite -e "mosh server tmux a"

For the command to work.

Nice fix. Will merge when build passes.

Updated, sorry about that.


Integrate animations

https://motion.dev/ would be a good choice for this.
Twind animate (https://twind.dev/handbook/styling-with-twind.html) is another option.

This concern goes beyond Gustwind.


A flat badge for Paypal

Here is a repository for making badges more acceptable in documenting, and I hope that the flat badge can be used in documenting of such an awesome company.

Thanks. Using the badge in the Readme now(https://github.com/paypal/accessible-html5-video-player/commit/42e21395970d125512e46cfac6a4d0b7348c768a).


Add support for passwordless login

hi @LeoMcA why did you close this? I was planning to test it and merge this week

After seeing Mozilla IT's implementation of passwordless login using lock, rather than lock-passwordless, I realised my implementation was far from ideal.
If you like it, you are of course free to test and merge it, but I don't think it's the approach we're going to be taking forward within Mozilla (instead opting to use our own fork so we can apply all the customisation we want, and probably implementing passwordless login alongside LDAP like linked above).

shame this was closed because we would have loved to use it (we don't have access to the server right now so can't switch to the oauth2 plug in).


printing Last price from ticker

from bittrex import Bittrex
my_bittrex = Bittrex(None, None)
ticker = my_bittrex.get_ticker('USDT-BTC')
print (ticker)
{'message': '', 'success': True, 'result': {'Last': 10930.0, 'Ask': 10930.0, 'Bid': 10924.535}}
Works fine ,  but now i want to print only 'Last'
I tried all kind of possibilities , i mix up lists , arrays with dictionaries.
Can someone show me a example?
I got it :
tick = ticker['result']
print (tick['Last'])

Correct. These are regular Python dictionaries. https://docs.python.org/3/tutorial/datastructures.html#dictionaries


[FR] Ability to replace GitHub embed footer image with our own

What type of issue are you creating?

[x] Feature request

I noticed while looking through bot.py that the image for the little github icon next to the footer text is just an imgur link. I could, of course, just edit this myself, but I figure this could conflict with future updates or break things. It would be wonderful if we could replace this with our own image link in the options.ini file, similar to how we can set custom footer text.

I don’t think it would conflict with anything if you ask me
I changed it and it works fine

Hey there! You're more than welcome to edit the code to change the footer text/image. I don't see a need for another configuration option for this at the moment.


Change depreciated delim_whitespace

Change depreciated delim_whitespace=True to sep='\s+'

@bowguy PR couldn't be more timely.  I was getting that warning today and I was so annoyed that I just added the following to my code knowing it isn't the classy way to handle this. :)
import warnings
warnings.filterwarnings("ignore")

@aerispaha will ultimately need to approve this but until then, go ahead and add your name to the Authors list too.

@bowguy , I don’t see any issues with your PR. That action is failing since I think we are only setup to build the docs on a tag release. @aerispaha just needs to approve it since he’s central maintainer. Should be soon. Thanks for submitting this PR!


Console spamming

function getName() on null
[03:07:51] [Server thread/CRITICAL]: Error: "Call to a member function getName() on null" (EXCEPTION) in "plugins/BossAnnouncement-master/src/xenialdan/BossAnnouncement/Main" at line 105
[03:07:52] [Server thread/CRITICAL]: Could not execute task xenialdan\BossAnnouncement\SendTask: Call to a member function getName() on null
[03:07:52] [Server thread/CRITICAL]: Error: "Call to a member function getName() on null" (EXCEPTION) in "plugins/BossAnnouncement-master/src/xenialdan
I am using ClearSky and how do i enable xdebug?

Re-Duplicate. Banned for Spamming. https://github.com/thebigsmileXD/BossAnnouncement/issues/14


Filter feeds on categories to select contents related to QGIS

RSS 2.0 and Atom 1.0 standards support some categories at item level, which can be considered as tags:

https://cyber.harvard.edu/rss/rss.html#ltcategorygtSubelementOfLtitemgt
https://www.w3schools.com/xml/rss_tag_category_item.asp
https://en.wikipedia.org/wiki/RSS

Depending on the tool used to generate RSS for a website, it can tricky to generate a custom feed for specific parts of the whole content. As Mkdocs RSS Plugin maintainer, it's still on the plans but not so easy to implement.
I suggest that the planet allow to filter on categories. It could be specified in the subscriber model:
  {
    "feed": "https://geotribu.fr/feed_rss_created.xml",
    "name": "Geotribu",
    "shortname": "geotribu_fr",
    "is_active": true,
    "filter_categories": [
      "QGIS",
      "QField",
      "QGIS Server",
      "PyQGIS",
      "Mergin",
    ],
    "languages": {
      "available": [
        "fr_FR"
      ],
      "main": "fr_FR"
    }
  },

Typically:
<item>
    <title>Track the Vendée Globe race with Python and QGIS</title>
    <author>ffougeres</author>
    <category>Article</category>
    <category>GeoPandas</category>
    <category>Pandas</category>
    <category>Python</category>
    <category>QGIS</category>
    <category>Vendée Globe</category>
    <category>sailing</category>
    <description>
Create and visualize GIS data on the progress of the Vendée Globe 2024 race from official spreadsheets.
    </description>
    <link>
https://blog.geotribu.net/2024/12/02/track-the-vend%C3%A9e-globe-race-with-python-and-qgis/?utm_source=rss-feed&utm_medium=RSS&utm_campaign=feed-syndication
    </link>
    <pubDate>Mon, 02 Dec 2024 09:09:00 +0000</pubDate>
    <source url="https://blog.geotribu.net/feed_rss_created.xml">Geotribu in English</source>
    <comments>
https://blog.geotribu.net/2024/12/02/track-the-vend%C3%A9e-globe-race-with-python-and-qgis/#__comments
    </comments>
    <guid isPermaLink="true">
https://blog.geotribu.net/2024/12/02/track-the-vend%C3%A9e-globe-race-with-python-and-qgis/
    </guid>
    <enclosure url="https://blog.geotribu.net/assets/images/social/2024/12/02/track-the-vendée-globe-race-with-python-and-qgis.png" type="image/png" length="65577"/>
</item>

Thanks for the suggestion @Guts.


mxnet.numpy and original numpy differ on bitwise right shift of uint64 types

Description
This difference was flagged by the array api tests, so it's likely that mxnet.numpy is not producing the correct value.  Test failure log is: https://jenkins.mxnet-ci.com/blue/organizations/jenkins/mxnet-validation%2Funix-cpu/detail/PR-20957/3/pipeline/286/#step-438-log-636
When mxnet.numpy does a right shift on a uint64 type, it uses a low level instruction that duplicates the most significant bit (i.e. an arithmetic right shift).  The simplest example showing the issue involves a right shift by 1 of 2**63 (a value with just the most significant bit set):
$python
>>> import mxnet.numpy as mxnp
>>> import numpy as np
>>> 2**63
9223372036854775808
>>> bin(2**63)
'0b1000000000000000000000000000000000000000000000000000000000000000'
>>> 2**63 >> 1
4611686018427387904
>>> np.right_shift(np.array(2**63, dtype='uint64'), np.array(1, dtype='uint8'))
4611686018427387904
>>> mxnp.bitwise_right_shift(mxnp.array(2**63, dtype='uint64'), mxnp.array(1, dtype='uint8'))
array(13835058055282163712, dtype=uint64)
>>> bin(13835058055282163712)
'0b1100000000000000000000000000000000000000000000000000000000000000'

A recent issue I filed involving an array api unittest failure involved Cython vs. ctypes, but this issue is unrelated and most likely an issue with the cast to int64_t in the lines:
https://github.com/apache/incubator-mxnet/blob/master/src/operator/mshadow_op.h#L835-L847

Hi, I added a fix here: https://github.com/apache/incubator-mxnet/pull/20974. It was caused by static_cast to int64.


docs: shields are fun :shield:

:tada: This PR is included in version 0.8.1 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 0.8.2 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


[stable/prometheus-operator] fix specifying resources for tlsProxy sidecar of prometheus-operator

What this PR does / why we need it:
Currently the tlsProxy sidecar of prometheus-operator does not allow for configurable resource requests and limits, as the indent is wrong. This PR fixes it, and also updated the README for the tlsProxy values.
Checklist

[x] DCO signed
[x] Chart Version bumped
[x] Variables are documented in the README.md
[x] Title of the PR starts with chart name (e.g. [stable/chart])

/ok-to-test

/ok-to-test
/lgtm


Feature/parallel more

Issue
There are more API calls that need to run in parallel
Solution

Move API calls related to the form to be concurrent.
Removed the constant ThreadPoolExecutor as it was closing and trying to re-fetch with other options for example with github action status would fail because the task_pool was closed.

Note: The API calls for reviewing the PRS still need to be moved and made concurrent, will do either in this pr or seperately when time allows.
Testing
Ran the app locally to fetch some PRs before the change
Ran the app again locally after the change and ensured it fetches the same PRs

An issue that needs solving before merging this:
The refetch after making a review action is broken after last commit.


docs: sealer is not supported by root users

Signed-off-by: Xinwei Xiong<PHONE_NUMBER>nss@gmail.com<!--  Thanks for submitting a pull request! Here are some tips for you:

Please make sure you have read and understood the contributing guidelines: https://github.com/alibaba/blob/master/CONTRIBUTING.md
Please make sure the PR has a corresponding issue.
-->

Describe what this PR does / why we need it
Does this pull request fix one issue?

Describe how you did it
Describe how to verify it
Special notes for reviews

pls fix lint


Add my first file

I have created a branch, created a file ,and made a commit!.

done merging to main


invalid character '<' looking for beginning of value

I'm not sure if SAP changed anything on their side or maybe I miss something, but I'm getting the following error trying to get a build information.
invalid character '<' looking for beginning of value
I checked last week and was working fine.
Regards.

BTW I could try to fix by myself and create a PR, but I have no idea about Go, sorry ¯_(ツ)_/¯

hm, I also get this error from time to time.
The weird part is that if I run the same command again, it works
Do you have a sure-fire ware to reproduce it, by any chance?

Hi.
I just tried several times but keep the same issue.
I don't know what you mean with "sure-fire ware", sorry.
Thank you for your quick answer.

do get this error every time you try to use ccv2ctl?

Yep.
I'm running ./ccv2ctl --certfile certfile.pem --keyfile keyfile.pem --subscription my-subscription-id get build -a and the result is the same all the time.
Session expired, logging in...
invalid character '<' looking for beginning of value

Could be something wrong with my cert and key files?

yes, that could be.
Have you tried using the certificate / SAP Passport in your browser to access the cloud portal for the subscription?

Sorry If I haven't answer you in so long, but I have been really busy.
I just checked to log into cloud with the certificate and as you guessed, I cannot acces, I get HTTP Status 401 – Unauthorized
I also tried with different ROLES for the same user but the result is the same.
So, obviously is not a problem with this awesome tool. Thank you so much.
I will try to figure out what is happening.

Hello guys,
The same story with me. Just yesterday I've created SAP PAssport and tool worked  like a charm.
But today I face the same answer every time. Just a wild guess that SAP is somehow blocking requests from the tool.
I tried to reissue SAP Passport, but it doesn't help.

What I figured out was I cannot use different SAP account with the same email in this way in the same CCv2 account (I created a dummy SAP account just for deployment but linked with the same email as my account which was also added to the same CCv2). I don't know if that is the problem but when I had only one account I could use this tool but it started failing when I added the second dummy account.
Also you can try what @mpern told me, to log into CCv2 Portal using that certificate, if you get a 401 then could be the same issue...


Section of conditional access to be updated

The section about Conditional Access should be updated. CA can be enabled by activation of MS Authentication Library (Preview) in the settings.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 06b6cadc-f93d-75de-7611-b1e3d80917e2
Version Independent ID: bcf194d8-3442-b284-576f-407af9ca1067
Content: Azure Storage Explorer troubleshooting guide
Content Source: articles/storage/common/storage-explorer-troubleshooting.md
Service: storage
GitHub Login: @Deland-Han
Microsoft Alias: delhan

@ingoke Thanks for reporting this. I have assigned the issue to the content author to investigate further and update the document as appropriate.

Thank you for your dedication to our documentation.
We sincerely apologize for the delayed response. After a careful review, we are closing this issue. If you feel that the problem persists, please respond to this issue with additional information.
Please continue to provide feedback about the documentation. We appreciate your contributions to our community.
#please-close


Index of Sigstore case studies

I was looking for the Sigstore case-studies and couldn't easily find them indexed in one place. I was able to find them by searching on Medium, but perhaps we can list them somewhere (in the community repo? on sigstore.dev?) with a brief summary to help potential readers find them?
Case-studies I found:

DB Schenker: internal supply chain integrity https://blog.sigstore.dev/securing-your-software-supply-chain-without-changing-your-devops-workflow-e23393a5fffa
Verizon: attaining SLSA level 3 https://blog.sigstore.dev/security-by-default-how-verizon-new-business-incubation-uses-sigstore-to-demonstrate-provenance-7beed5714738
Autodesk: meeting FedRAMP compliance requirements https://blog.sigstore.dev/using-sigstore-to-meet-fedramp-compliance-at-autodesk-6f645a920abc

cc @tracymiranda

Are you thinking of https://github.com/sigstore/friends ?

I just found that the case studies are listed on the Sigstore landscape (and that there are five, not the three I originally found through searching).

CC @tracymiranda ICYMI

Thanks @znewman01
Yes, @joshuagl the landscape is intended to be the source of truth for the case studies. The nice thing about it is that you can link out the groups and embed them elsewhere... so for example we could embed this link somewhere on the website or wherever makes sense for discoverability
https://landscape.openssf.org/card-mode?category=case-studies&grouping=category&embed=yes&style=borderless


Request: Add Dry Run for Uninstall

Verification

[X] This issue's title and/or description do not reference a single formula e.g. brew install wget. If they do, open an issue at https://github.com/Homebrew/homebrew-core/issues/new/choose instead.

Provide a detailed description of the proposed feature
Could we have the ability to uninstall as a dry-run?
brew uninstall [formula] --dry-run
What is the motivation for the feature?
To test what would be removed and potentially bugged with missing dependencies.
How will the feature be relevant to at least 90% of Homebrew users?
Ensuring we don't potentially remove necessary files, scripts and programs.
What alternatives to the feature have been considered?
Running uninstall not as a dry run

Good idea.

Sorry, I misread this as a request for dry run for https://github.com/Homebrew/install/blob/master/uninstall.sh. If this is a request for that or e.g. brew autoremove: I'd consider it but as-is I won't, sorry.

Sorry I don't understand well enough to say which I was suggesting. Basically like how we can --dry-run with brew install. It won't actually install, but it prints what would have been installed as a result. Something like that but for uninstall.

My exact scenario is that I have two versions of openssl, @1 and @3. I assume I only need @3, but I'm hesitant to remove @1 because other packages may rely on it as dependencies.
When uninstalling a package, it'd be helpful to see what all would be removed (aliases, files, folders, etc.) and what could cause potential problems with other packages before going through with the uninstall.
I hope I'm explaining that well enough.

brew uninstall should print an error message and refuse to remove an packages that are actively being used as dependencies of other packages.
I'm not personally opposed to adding this option but it might be difficult since there are some extra checks to see if a package is still being used that show up pretty late in the uninstall code. It might be kind of a pain to try and pre-evaluate that stuff just to be able to add a dry run command. At the same time, dry run is really helpful when you don't know or aren't interested in figuring out all of the technical details of a random command line program.
Also, brew autoremove already has a dry run option. That could be combined here since autoremove gets run automatically if you have the HOMEBREW_AUTOREMOVE environment variable set.


Improve histograms with outliers

It's not quite uncommon to have datasets with outliers.
However, using histograms with that kind of datasets, sometimes, is not as good as it could be. The outliers affect too much the representation and make the filtering completely useless.
As an alternative, we should provide an option to show/hide the outliers from the histogram. That will improve the visualization of the distribution and, also, the filtering capabilities of the widget.
An example of a histogram with outliers:

The same histogram removing the top and bottom 1 percent:

When talking about this the other day, we proposed an idea having an option for this on the "..." submenu.

In these cases autostyle should be really smart and style using outliers styling -> https://github.com/CartoDB/turbo-carto/issues/32
A "see outliers" filter would be also nice

Same as (or hightly related to) https://github.com/CartoDB/solutions/issues/684, isn't it? :thinking:

yep @AbelVM

Then... I'm not comfortable with the "range shrinking" proposed here. I'd like to have all my data there, but higher LOD (x-axis) in the range where most of the values live, as described in the issue above

I understand, and that's another option. Anyway a logarithmic scale wouldn't fix this problem always neither, so we will experiment first.

As inspiration, here you have some 3rd party examples of semi-log histograms, using different data sources:

Mathematica

Matlab

SAS

R

It's important to not forget that histograms should keep a consistent binning when data is filtered in other dimensions. Having a variable bucket width makes more difficult to keep that consistency in place.

:(


Consider making PullBuffer size change dynamically (especially on startup)

Currently PullBuffer size is configurable but fixed during playback. We should consider if it helps to adjust it basing on current demand. This is most important on change to playing state, because huge demands occur then, what might affect stream fluency and cause significant processor usage at the moment.

According to the planning meeting on 25.06.2018 seems like something that is not our first requirement.


[feature] upgrade opentelemetry v1.0.0-RC3

Codecov Report

Merging #1395 (5fb1181) into master (077a419) will decrease coverage by 0.03%.
The diff coverage is n/a.

:exclamation: Current head 5fb1181 differs from pull request most recent head 1242733. Consider uploading reports for the commit 1242733 to get more accurate results

@@            Coverage Diff             @@
##           master    #1395      +/-   ##
==========================================
- Coverage   70.67%   70.64%   -0.04%
==========================================
  Files         381      381
  Lines       32488    32488
==========================================
- Hits        22962    22952      -10
- Misses       7907     7916       +9
- Partials     1619     1620       +1

Impacted Files
Coverage Δ

os/gspath/gspath_cache.go
82.60% <0.00%> (-10.87%)
:arrow_down:

net/gtcp/gtcp_pool.go
36.84% <0.00%> (-3.95%)
:arrow_down:

container/gtree/gtree_avltree.go
93.48% <0.00%> (-0.23%)
:arrow_down:

container/gtree/gtree_btree.go
89.10% <0.00%> (-0.20%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 077a419...1242733. Read the comment docs.


Remove dependency of jq util

Instead use a built-in json-util script (from https://github.com/dominictarr/JSON.sh) to parse the json and output list of file paths for touch
Existing tests covers this code (aka test will fail if this does not work) so no new test is added for now.

Agree with Sam that it would be better to use python for this.

Another look @segiddins ? Have to rename xcodeproj-shim toxcodeproj_shim as python don't want - in the path, let me know if there is an alternative.

One nit, it'd be nice to rebase to get rid of the commits that just say "fixup"

@segiddins i always do squash and merge to get rid of these msgs


fix 1403

fixes #1403
fix incorrect document references to former openblockchain/obc-docs to correctly reference the hyperledger/fabric/docs documentation
Also addressed a couple of lint errors in asset_management_with_roles.go
Signed-off-by: Christopher Ferris<EMAIL_ADDRESS>

FYI @srderson @ghaskins apparently, the GitHub desktop client doesn't honor the pull request template

LGTM
Reviewed-by: Greg Haskins<EMAIL_ADDRESS>


Customize icon color with themes

Hi,
Is there a way to customize all FontIcon and IconButton colors using MUI themes? I digged up the code and noticed that FontIcon is bound by textColor property, that's absolutely sad.
Thoughts?

@igorpreston Yes, I looked into the issue and couldn't find any way to change the color of all FontIcon and IconButton components. The only way I could figure out was to change the styles prop wherever you use the components. If you are going down that path, then I would recommend creating a new styling and importing it, rather than creating an object on every page. What do you say?

@aahan96 yes, that's what i've been doing recently as well. I also tried creating HOC to wrap FontIcon and providing custom iconColor variable to the MUi theme, but it is becoming annoying to import decorated FontIcon from local project, rather than from MUI.
MUI themes need definitely to support separate iconColor variable with fallback to textColor, which applies to all FontIcon and IconButton components.

This seems to be more of a Enhancement than a Question.
Any updates on this?

I digged up the code and noticed that FontIcon is bound by textColor property

That's right. We would accept a PR to add a fontIcon and iconButton key into getMuiTheme.js.

It is becoming annoying to import decorated FontIcon from local project, rather than from MUI.

That's a pattern we will most likely encourage for the next branch. It's call composition. That sounds right. Still, I agree doing it for the theme sounds overkill.

@oliviertassinari can you clarify the intent of closing this issue? Will a convenient way to set icon colors separately from text color only come when v1 is released? Is v1 close enough that solving these issues in v0.x is no longer a concern?

@tgiddings The issue was closed by the linked pull request. With the following change, users can override all the styles injected by Material-UI with ease. But even without this change, you should be able to change the color by providing your own CSS.

Is v1 close enough that solving these issues in v0.x is no longer a concern?

Yes.


Selfie rebase

Secondary PR for squashing commits

There are now 2 PRs for this.  Can you guys please consolidate this into just one so I can review?

See #284


hold the mutex while calling notify_all

This is a precondition when calling notify_all and fixes a dead lock in Electron on Windows

I have verified this PR fixes multi-process write in Electron. There was a failing test in Realm JS now when on_change is called with the mutex released this RJS tests are green on Windows.
Also https://github.com/realm/realm-object-store/issues/872 is fixed as well.
There is still another deadlock on windows on process exit.

I think I might know why there's a deadlock on process exit. The ExternalCommitHelper destructor attempts to acquire m_mutex to signal to the worker thread that it should stop listening. However it's the same mutex that we now use to coordinate calls to notify_all, and that's because the worker thread is always waiting on the condition variable so the only way to wake it up and let it know it needs to wrap things up is to "notify" it.
Ordinarily I would have used a second mutex just for that, and waited with WaitForMultipleObjectsEx, but the API of InterprocessConditionVariable doesn't allow for that.
Under what conditions does the deadlock on process exit occur? Can we afford to merge this PR without breaking anything else?

The deadlock on process exit existed before this PR (at least when running the repro in #872).

yes indeed it's a separate deadlock.
While its true that the exit deadlock is related to the destructor in ExternalCommitHelper I think it's not the cause. I suspect our design of syncing  multiple process is not robust enough.
My investigations in Electron showed that when the window is closed the renderer process exits succesfully (exitcode = 0) and the main is still waiting for a specific number of listeners to notify it in ExternalCommitHelper::listen->m_commit_available.wait

https://github.com/realm/realm-core/issues/4174 is probably the cause of the deadlock on shutdown


How to increase websocket connections?

Hello and thanks for developing Javalin.
I'm playing around with the websockets chat example
From my js code I have simulated about 500 websocket connections:
id("btnConnect").addEventListener("click", () => {
    const totalConnections = 500;
    for(ind=0; ind<totalConnections; ind++){
        setTimeout(() => new WebSocket("ws://" + location.hostname + ":" + location.port + "/chat"), ind * 100);
    }
});

And on the Javalin server I see that only a maximum of 255 connections are made.
I understand that each websocket connection uses a thread.
I have tried to increase the number of threads as it is done in the code of the project Loomylin
Javalin.create(config -> {
    config.server(() -> new Server(new QueuedThreadPool(400, 400)));
    })
    .start(8000);

But the max websocket connections are still 255.
I am missing something or there is some kind of bug?
Thanks greetings.

I understand that each websocket connection uses a thread.
...
I have tried to increase the number of threads as it is done in the code of the project Loomylin
But the max websocket connections are still 255.

Javalin doesn't use one thread per WS connection. Sounds like this is perhaps a limitation of the client you are using to connect with?

Do you by chance use Chrome? 😁

You are right, thank you very much!
Yes i am using chrome.
I just tried with firefox and the limit is 200 connections.
I was confusing.
If I'm not mistaken, websockets in Jetty also use a ThreadPool just like Http requests.
Thank you very much.
What you are doing with Javalin is awesome.
Javalin and JavalinVue are my new development stack :)

If I'm not mistaken, websockets in Jetty also use a ThreadPool just like Http requests.

The ThreadPool is used for WebSockets (for sending and receiving, for example), but one connection doesn't hold one thread busy. You can potentially have thousands of WebSocket connections on the default ThreadPool.

What you are doing with Javalin is awesome.
Javalin and JavalinVue are my new development stack :)

Thank you, happy to hear that ☺


Retention/deletion/prune policy

Describe the solution you'd like
Would be great to have the ability to control what happens to Secret object when ExternalSecret is deleted (either with new value for "creationPolicy", or a new field such as "deletionPolicy", "retentionPolicy", "prune", etc.).
What is the added value?
Currently it's only possible to retain Secret when using creationPolicy: Merge, which implies you need to create the Secret separately first. In my case, I need ExternalSecret to be able to create and update Secret, but still preserve Secret when the parent object is deleted.

Will be implemented in scope of #695

@moolen I've read through #695, and I'm not sure that it covers request in this ticket. It says that deletionPolicy=None will delete Secret if the provider returns no data, and that is already the current behavior. But my request was about the ability to preserve Secret regardless of whether provider returns the data or not.

Hi @artem-nefedov ! Sorry to jump in, but I wanted to understand better your use case. Right now, if a given ES generates a given Secret with creationPolicy:Owner, if ES cannot find the source anymore it is going to be in a secretSyncedError , but will not delete the Secret itself. Are you experiencing something different than this behavior? Are you intending to preserve deleted keys from a given source?

Hi @gusfcarvalho . My feature request is not related to "source" being changed/deleted. I just need the ability to always keep Secret object whenever ExternalSecret object is deleted (while still allowing Secret to be created and/or updated). Maybe it was not clear from the description.

I see! So basically there should be no garbage collection via ownerReference. My bad, that was a misunderstanding!


[PORT] clean up activityhandler and teamsactivityhandler

Port this change from botbuilder-dotnet/master branch:
https://github.com/microsoft/botbuilder-dotnet/pull/3482

fixes #3446
(duplicate code and new compiler warning introduced with sso fixes)
Changed projects

Microsoft.Bot.Builder
Microsoft.Bot.Builder.Tests

Needs porting to JS although I don't completely agree with how you're doing the code to protect against sending multiple invoke responses. This protection should be done in the adapter if anything.

This is a dup of #1680

This is now an issue follow the SSO check-in. Its slightly different to the C# but the principle it the same: we want any additional Invoke handling we do in ActivityHandler to be consistent with the work we had already done in TeamsActivityHandler. Basically move the code up to the base class.

@johnataylor - is this waiting on a review from someone?


minor typos and tweaks

Please have a look and the check changes look ok, otherwise I think we're ready to mint 😄


Add QueuedThreadPool to Jetty server

I prefer the approach from #149, #151. In few words:

create a JettySettings (similar with UndertowSettings) and put your settings in that file.
change JettyServer to take into account the JettySettings class

I prefer each server with a custom settings POJO with some constants (properties names) and common settings in WebServerSettings.
What you say, make sense?

definitely your approach is better.

You come with another pull request or you want to create an issue?

I'll try again with a new pull request, with your approach.


Fix documents of check_backward

Docstring in check_backward was broken. This PR fixes to it.
Related to #874


Adding managed identity subcommands and moving old identity commands to new subgroup

This checklist is used to make sure that common guidelines for a pull request are followed.

For new extensions:

[ ] My extension description/summary conforms to the Extension Summary Guidelines.

About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Thank you for your contribution! We will review the pull request and get back to you soon.


Added missing " from the end of actions list

Looks like eda83298 commit misses two " from the end of actions list in rule 930050 here and here. This PR fixes it.
I'm wondering why mod_security2 allows it...

Thanks @fzipi for describing these typos.

I wonder how we can prevent this in the future...

Integrate msc_pyparser into the GH test workflow? :)

@fzipi: #2236