PHOENIX-1118 : Tracing Web Application

Tracing Web App

[x] Web app create from jetty

[x]  Web App creation / build
[x] Pom file mapping to root pom
[x] Starting script in bin file

[x] Adding angularjs and google chart
[x] Feature list for trace web application

[x] Listing trace in web UI (table view)
[x] Timeline by trace Id
[x] Dependency Tree for trace
[x] Trace distribution over the host
[x] Trace Count by trace trypes

[x] Communicating from Java to Javascript

[x] Remove sample data

[x] Adding test

[x] Adding test specs for to test JS
[x] Adding test for build

Building trace web app from root.

You can start the web app from the command given below.
java -jar target/phoenix-tracing-webapp-4.4.1-HBase-0.98-SNAPSHOT-runnable.jar
You can change the web app port from
-Dphoenix.traceserver.http.port=8887
A view similar to screenshot will be seen from the Phoenix tracelist.
http://localhost:8864/webapp/#/list
Enable tracing before you attempt above steps.

Starting Trace WebApp
python traceserver.py start
Trace web app will start in [http://localhost:8864/webapp/] (http://localhost:8864/webapp/)
Stop Trace-WebApp
python traceserver.py stop

Test Specs are written in jasmine and jasmine-maven-plugin is used to integrate test to build

Timeline works with Phoenix actual dataset.

Phoenix binding for Trace Count Chart

Trace Distribution

Attaching dependency tree view

Trace count supported with different chart types - pie,bar,column,area,line

Items are listed with button linked to dependency chart.

Dependency chart with tooltip

Dependency tree with text and tooltip

Thanks for the update, Nishani. This is definitely an improvement. The primary information missing is the query itself. Without this, the user doesn't know what they're looking at. The query should be the description of the root span. I'd recommend displaying this at the top of the page in the blue box instead of the "data retrieved" text. It's important enough to always see this information rather than making it a tooltip.

Hi, James
I will try to added description of the root span for state notification box.
Thanks

@JamesRTaylor : Here is new look of dependency tree with SQL query

Already merged.


jdk15 build using wrong repository(jdk11u)

https://ci.adoptopenjdk.net/view/Failing Builds/job/build-scripts/job/jobs/job/jdk/job/jdk-windows-x64-hotspot/151/console
09:12:25  Checking and download CaCerts dependency
09:12:25  Retrieving cacerts file if needed
09:12:25  origin	https://github.com/adoptopenjdk/openjdk-jdk11u.git (fetch)
09:12:25  origin	https://github.com/adoptopenjdk/openjdk-jdk11u.git (push)
09:12:25  jdk
09:12:26  origin	https://github.com/adoptopenjdk/openjdk-jdk11u.git (fetch)
09:12:26  Resetting the git openjdk source repository at /cygdrive/j/jenkins/tmp/workspace/build/src in 10 seconds...

09:12:37  Pulling latest changes from git openjdk source repository

09:12:38  Fetching origin

09:12:41  HEAD is now at 8b1d825628 Merging origin/master HEAD into dev

09:12:42  Pulling latest tags and getting the latest update version using git fetch -q --tags --depth=1
09:12:42  NOTE: This can take quite some time!  Please be patient

09:13:05  From /cygdrive/j/jenkins/tmp/workspace/./build//src
09:13:05   * branch                  HEAD       -> FETCH_HEAD
09:13:05  usage: git rev-list [OPTION] <commit-id>... [ -- paths... ]

Fix: https://github.com/AdoptOpenJDK/openjdk-build/pull/1850


Subnetwork Laplace

This PR implements subnetwork Laplace, addressing issue #16.
As you can see from the code, this is fairly straightforward. We basically just need to ask the user to specify/pass a definition of a subnetwork. We then internally store the subnetwork as a vector of indices of the flattened/vectorized model parameters that form the subnetwork (for convenience to the user, we also allow passing the subnetwork as a binary mask/vector of the size of the parameter vector, where 1s indicate the subnetwork parameters). All we then need to do is index the Jacobians / gradients to extract the part corresponding to the subnetwork, both during inference time (i.e. for constructing the GGN/Fisher) and during prediction time (i.e. for constructing the predictive covariance matrix).
Some comments/questions:

I'm aware that I still need to write tests, which I'll do (I ran some tests locally to ensure that the code works generally).
The code also doesn't support the NN+MC predictive yet, which I'll add; it shouldn't be hard to implement, as we just need to sample the subnetwork weights and then combine them with the remaining MAP weights to form a parameter vector.
Should we allow the user the change the subnetwork after instantiation, or should the subnetwork remain fixed? In either case I'd need to adapt the code accordingly. For us it would be easier to not allow changing the subnetwork, as that'd require re-fitting the Hessian etc.
We'll have to be especially careful with the logic of the subnetwork_mask setter of SubnetLaplace, which needs to correctly check that the passed subnetwork_mask is in the right format (we currently support the two formats mentioned above), as the code would break otherwise. I'll double-check the logic and also add sufficient test cases for this.
Should we update all the internal documentation to reflect the subnetwork Laplace option? As the subnetwork Laplace implementation is integrated into the full Laplace code (and just adds lines to index the Jacobians/gradients), we'd have to change everything where we refer to the full parameter vector (incl. when we define tensor shapes, e.g. where parameters would become parameters_subnet). It's not hard to change, but might make the documentation more cluttered / harder to read, as we'd have to include conditional clauses I guess.
Is there are reason why jacobians() is static? Just wondering, as it makes the code and documentation a bit uglier/longer with the subnetwork option, as we always have to pass the subnetwork_indices when calling it. Compare this with gradients(), which is not static and can therefore simply access self.subnetwork_indices.
The code currently only supports using subnetwork Laplace with a full Hessian (and throws an error otherwise). In principle it'd also be possible to also use it with diagonal or KFAC Hessians, but it makes less sense conceptually, so I'd rather not support it. But then again, we also support options like diagonal last-layer, which are also not too sensible arguably?
Finally, the current implementation requires the user to specify / pass the subnetwork. We could consider also adding functionality for automatically selecting the subnetworks. Simple choices like random subnetworks or subnetworks of the largest magnitude weights would be easy to implement. But e.g. the approach we ended up using in the subnetwork inference paper (i.e. selecting weights with the largest marginal variances, where we used SWAG for variance estimation) is a bit more involved and might make the codebase too bloated. But happy to discuss this.

Thanks a lot for your efforts in looking at this (there's no rush of course)!

1.-7. Minor comments
Looks quite nice already. I made two comments on the code directly. Here the answer/discussion to the more minor points:

Suggestions for tests: with all parameters retained, all should be equivalent to FullLaplace. With last layer retained, all should be equal to that as well.
The subnetwork should be static as you suggest because changing it really requires to rerun the entire .fit() method which is the only setup function that has a non negligible runtime.
It could make sense to reimplement the code separately for SubnetLaplace to make it more clear and potentially changeable in the future. Otherwise, one could add @property values for all class parameters that need to be masked and then override these in the Subnet class and mask correspondingly.
Yes, probably we could make the change and have Jacobians be an instance-method instead of static. I don't remember why it is like this right now. In fact, we have a similar change right now in the FunctionalLaplace PR: #55. If you can make the change to Jacobians in the backends on this branch, that would also work. I don't see any problem with this right now but there might be some..
I agree that diagonal or KFAC subnet don't make sense because KFAC would require a certain subnet structure to be sensible and the full diagonal is usually used to select the parameters of interest. I think diagonal last layer makes a little more sense but is probably also not something that should be used much..

8. Choice of subnetwork
One question regarding the choice of subnetwork in your paper: would it be possible to use the diagonal Laplace-GGN to choose the subnetwork? In fact, I thought that's what you did. Is there any reason that you (need to) use SWAG instead of Laplace to choose the subnetwork?
Because I thought that the subnetwork would be chosen using the diagonal GGN, I was thinking to just override the .fit() method with a separate run over the data_loader to select and set the subnetwork indices and then run the true .fit() computing the masked full GGN. If the method does not work with a diagonal GGN as selection criterion and we anyway also want to include different policies for selecting subnetworks, it might make sense to design a class that can be passed to the SubnetLaplace. One could implement it as follows
class SubnetMask(object):
    def __init__(self, model, likelihood, ..):
        ...

    def __call__(self, train_loader, ...):
        # select mask based on train loader, model and other hyperparams similar to a subclass of CurvatureInterface
        return mask

Then, different policies can subclass this mask, and one could potentially separately implement a SWAG-Mask, random-mask, last-layer mask (for testing?). Also, the method using diagonal GGN would be easy to implement.  What do you think about this?

I now addressed most of the remaining issues discussed. Most notably, I followed your suggestion of adding a SubnetMask class where subclasses implement different subnetwork selection strategies. For now, random, largest magnitude and last-layer subnetworks are supported. I am considering to also add the diag-Laplace subnet selection strategy you mentioned, which should indeed also be easy to implement. I am currently finalising the tests and will push those soon as well.

I also finished implementing subnet selection based on the largest marginal variances (using diagonal Laplace for variance estimation).

I also just added an implementation of the sample() method for SubnetLaplace (e.g. to use the NN predictive), which simply only samples the weights in the subnetwork and sets all other weights to their MAP estimates (had forgotten to add that earlier). I also added tests for the predictives (which are basically identical to those from test_baselaplace.py).

Hi Erik
I'm interested in this feature! Would it be possible to specify the layer names of the subnetwork. E.g. if I want to use the Laplace approximation at layer 2 and 4 and the MAP estimate at layer 1 and 3. Could you provide an example of how I could do this?

Hi @FrederikWarburg, thanks a lot for checking out our library and for your interest in the subnetwork Laplace approximation!
I agree that it would be a useful feature to be able to simply specify the names of the layers to perform the Laplace approximation over. I just implemented this functionality in two new subclasses of SubnetMask:

ParamNameSubnetMask: allows you to specify a list of parameter names (as in model.named_parameters()) to do inference over
ModuleNameSubnetMask: the same, but with module names instead (as in model.named_modules()); this for now only supports leaf modules (i.e. modules that have no children(), i.e. individual layers), as nested modules would be more complex and require a bit more thought; however, nested modules would certainly be useful to add in the future (e.g. allowing one to specify blocks of layers to perform inference over rather than having to list individual layers), as the current functionality arguably does not add much on top of ParamNameSubnetMask

Here's an example on how to use these:
import torch
from laplace import Laplace
from laplace.subnetmask import ParamNameSubnetMask, ModuleNameSubnetMask

model = torch.nn.Sequential(nn.Linear(3, 20), nn.Linear(20, 2))
likelihood = 'classification'
dataloader = None   # define valid data loader here

# subnetwork Laplace where we specify subnetwork by parameter names
subnetwork_mask = ParamNameSubnetMask
subnetmask_kwargs = dict(parameter_names=['0.weight', '1.bias'])
lap = Laplace(model, likelihood=likelihood, subset_of_weights='subnetwork', subnetwork_mask=subnetwork_mask, hessian_structure='full', subnetmask_kwargs=subnetmask_kwargs)
lap.fit(dataloader)

# subnetwork Laplace where we specify subnetwork by module names
subnetwork_mask = ModuleNameSubnetMask
subnetmask_kwargs = dict(module_names=['0'])
lap = Laplace(model, likelihood=likelihood, subset_of_weights='subnetwork', subnetwork_mask=subnetwork_mask, hessian_structure='full', subnetmask_kwargs=subnetmask_kwargs)
lap.fit(dataloader)

Finally, I changed LastLayerSubnetMask to simply be a subclass of ModuleNameSubnetMask where module_names=[last_layer_name].
@FrederikWarburg I hope this is useful. Please let me know in case you have any further questions or something doesn't work!

Awesome! Thank you for your quick reply!
I found a small error, when running on GPU. Line 59 in subnetmask.py the type is torch.cuda.ByteTensor if running on gpu. This is not part of the list and the program fails. My quick fix was just to append the cuda types to the list. Besides this, it seems to work for me!

Ah, thanks a lot for pointing that out -- I indeed haven't tested the code on GPU!
I've fixed that check to be independent of the device (your fix works as well of course).
Great to hear that it works otherwise -- let me know in case there's anything else I can help with!

Just made some small refactorings, and added an implementation of a subnetwork mask that selects the parameters with the largest marginal variances, where the variances are estimated using a diagonal SWAG posterior approximation (which is the approach used in the subnetwork inference paper).
The build seems to be failing now (locally everything was working fine), I'll investigate and fix this.

Ah ok, this was due to the recent changes introduced by https://github.com/AlexImmer/Laplace/pull/72. I merged the latest main into subnetlaplace and fixed the issue.

One question might be how to structure the new files. This PR adds three new files (subnetlaplace.py, subnetmask.py and swag.py), which are currently simply in laplace/. Perhaps it makes sense to put (a subset of) these into a dedicated sub-directory (e.g. laplace/subnetlaplace/ or laplace/subnetwork/)?

One question might be how to structure the new files. This PR adds three new files (subnetlaplace.py, subnetmask.py and swag.py), which are currently simply in laplace/. Perhaps it makes sense to put (a subset of) these into a dedicated sub-directory (e.g. laplace/subnetlaplace/ or laplace/subnetwork/)?

Other options would be:

Leave subnetlaplace.py and subnetmask.py, move content of swag.py into utils.py or create new utils directory with utils.py and swag.py.
Also create a utils directory, but move subnetmask.py, matrix.py, and feature_extractor.py there as well.

Also create a laplace/utils directory, but move subnetmask.py, matrix.py, and feature_extractor.py there as well.

I like this option, as it would make laplace a bit cleaner, but no strong preference.

On another note, I was just going to update the README to include subnetwork Laplace, and realized that low-rank Laplace is also not yet mentioned. Also, we might want to update the paper citation to mention NeurIPS. Happy to quickly make these changes.

I like this option, as it would make laplace a bit cleaner, but no strong preference.

I think this is also my preferred option. @AlexImmer?

I went through the code and it looks very good already! I have one main point to discuss:
Currently, the SubnetMask child class is passed to Laplace for initialization, along with subnetmask_kwargs; this follows the same flow used for the backend class. However, this results in some inconveniences, most notably that the subnetwork is only selected when calling fit() because only at this point the train_loader is available. If the selection was happening outside the fit() method, it would also be possible to use subnet Laplace for continual learning with the standard interface, i.e. the posterior is initialized to the prior during initialization and the Hessian is accumulated with the override=False keyword to fit() (which is currently still missing and needs to be added in any case).
So an alternative would be to keep the whole subnet selection process separate from Laplace, i.e. instantiate the SubnetMask child class outside of the Laplace class with all necessary keywords and the train loader, and also call the select method. I think then we only need to pass the subnet indices to Laplace, which also makes the code in SubnetLaplace a bit cleaner. Since the selection method and the keywords have to be manually selected by the user outside of the Laplace class anyway, I think just doing everything outside does not add much overhead for the user.
Minor notes:

Structure of laplace directory, as mentioned above.
Cost of Jacobians, but there is no easy and general fix I think.

Thanks for looking over the code and your suggestion, Runa!
You're raising a good point. I was also considering outsourcing the subnetwork mask instantiation/selection to the user, but in the end decided for the current design as it makes the user interface a little bit simpler IMO. But I agree that it might be a bit cleaner if we keep the subnetwork selection separate (and just pass either the SubnetMask instance after subnet selection or directly the subnetwork indices to Laplace()). In particular, I haven't considered the continual learning setting, which is a good reason to use this alternative design.
Happy to make that change. @AlexImmer what do you think?

Cost of Jacobians, but there is no easy and general fix I think.
By this you mean the issue that we compute the full Jacobians (over all parameters) before selecting the relevant entries corresponding to the subnetwork parameters, rather than only computing the required Jacobian entries in the first place (which should be much more efficient in theory)? I agree -- this is something I have tried to figure out for some time but couldn't find a solution for. AFAIK the PyTorch autograd engine can only compute gradients w.r.t. full parameter tensors but not sub-tensors, unfortunately (see e.g. https://discuss.pytorch.org/t/how-to-turn-off-requires-grad-for-individual-params/103303/8). Would be great to find a solution to this at some point, as it could significantly speed things up for large models.

I've now also updated the README to include both subnetwork Laplace and low-rank Laplace, and updated the paper citation to the NeurIPS version -- feel free to take a look.
@AlexImmer What were the papers that you based the low-rank Laplace implementation on? For now I've just mentioned Sharma et al. 2021 in the reference list in the README, but there's e.g. also Maddox et al. 2020 that might be relevant. We might also want to consider citing the relevant papers in the doc string of LowRankLaplace (as we e.g. also do for the marginal likelihood training script and SubnetLaplace).

Re structuring masks, utils, feature_extractor, matrix, etc. into utils/ makes sense but subnet could also have its own directory subnet/ with corresponding utilities inside. I would be fine with both.
Re passing masks only: I think this is a good idea if it works as expected. Would it be a problem that the backend requires fitting the mask before initializing laplace? This is necessary because the backend requires the subnet-indices, right?
Re references: I just implemented one way of doing subnet-laplace using the eigendecomposition. I think the Sharma reference does almost the same so let's use that one. Maddox et al don't propose a low-rank LA. In the future, we should probably add references to the docstrings, I will make an issue for that. It's a separate thing.
Re jacobians: I also thought it would be doable more efficiently but couldn't find any way for the general case when they are fully indexed.
@FrederikWarburg thanks for spotting the device error!

Thanks for your comments, Alex!
I'll address the remaining issues next week, then we can hopefully merge this in and ship the new release by the end of the year (or whenever you guys are available)?

Re structuring masks, utils, feature_extractor, matrix, etc. into utils/ makes sense but subnet could also have its own directory subnet/ with corresponding utilities inside. I would be fine with both.

Yes that's also an option. I'll try both options to see which one feels better.

Re passing masks only: I think this is a good idea if it works as expected. Would it be a problem that the backend requires fitting the mask before initializing laplace? This is necessary because the backend requires the subnet-indices, right?

Yes exactly, we'd need to fit the mask before passing it to Laplace(), as the backend will need the subnet indices. I don't think this is an issue, as it's the same way we do it now -- we'd just outsource the mask fitting to the user and not do it internally before fitting Laplace. But I might also have misunderstood your concern. In the end using subnet Laplace would look something like this:
subnetwork_mask = SubnetMask(**subnetmask_kwargs) # instantiate subnet mask
subnetwork_mask.select(train_loader) # select subnetwork
lap = Laplace(model, likelihood, subset_of_weights='subnetwork', subnetwork_mask=subnetwork_mask)

Then internally we just need to pass subnetwork_mask.indices to the backend (probably simply in the Laplace() constructor) and we're good to go.

Re references: I just implemented one way of doing subnet-laplace using the eigendecomposition. I think the Sharma reference does almost the same so let's use that one. Maddox et al don't propose a low-rank LA. In the future, we should probably add references to the docstrings, I will make an issue for that. It's a separate thing.

Sounds good!

End of year release sounds good!

Re laplace directory structure: my preferred option is a utils directory, simply because it makes everything cleaner and we already have files which would fit well in there, e.g. matrix.py and feature_extractor.py.
Re keeping the SubnetMask logic external: is it also possible to only pass subnetwork_mask.indices to Laplace? I think nothing else is needed (the n_params_subnet attribute can be derived from it)  and this enables users to choose indices even without using the SubnetMask classes or writing their custom subclass.

I have now implemented the remaining things we had discussed, namely:

I moved all utility files (feature_extractor.py, matrix.py, subnetmask.py, swag.py, utils.py) into a new laplace/utils folder
I changed the logic of SubnetLaplace to take subnetwork_indices instead of a subclass of SubnetMask; this includes careful checks for the validity of the passed subnetwork_indices
I updated the tests accordingly (i.e. by adapting existing tests to the new structure and adding new tests for custom subnetwork_indices not derived from any SubnetMask subclass)

Let me know what you think and if there is anything else that I should take care of!

I also just added an example for using SubnetLaplace (with different ways to choose the subnetwork_indices) to the README.

Probably also good for autocomplete?
On Tue, 11 Jan 2022 at 15:47, Runa Eschenhagen @.***>
wrote:

@.**** commented on this pull request.
In laplace/subnetlaplace.py
https://github.com/AlexImmer/Laplace/pull/58#discussion_r782218005:

@@ -0,0 +1,129 @@
+import torch
+from torch.distributions import MultivariateNormal

+from laplace.baselaplace import FullLaplace
+from laplace.curvature import BackPackGGN
+
+
+all = ['SubnetLaplace']
I think it determines what is imported when you call
from laplace.subnetlaplace import *
and maybe there are other effects too.
—
Reply to this email directly, view it on GitHub
https://github.com/AlexImmer/Laplace/pull/58#discussion_r782218005, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AB23RXDHXZ6RGWPMUUQD5MLUVQ7H5ANCNFSM5JBQQBVQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you were mentioned.Message ID:
@.***>

Regarding the line length, I also think 100 is fine for now. I think we have always used brackets ([{ for line breaks, so it would be nice to be consistent with that.
We could consider also moving marglik_training.py to the new utils directory (or just leave it where it is or in the future add something like a methods directory).

Agree with the first comment. I think in the PR are plenty of linebreaks backslash.
I wouldn't put it into utils. I think utils should only contain utilities that are required for the package and not utilities for users. The latter we can call methods later as discussed.

Thanks a lot for your comments, Alex and Runa, which I have now addressed! I also recompiled the documentation. Let me know if there is anything else that needs to be resolved.

Just realised that for some reason Travis has not been running the tests here anymore for the latest commits (I ran tests locally, where everything worked). Any idea why it's not doing this check anymore?

Just realised that for some reason Travis has not been running the tests here anymore for the latest commits (I ran tests locally, where everything worked). Any idea why it's not doing this check anymore?

We have limited compute available on Travis, so we only run the tests when merging PRs from now on. If you ran the tests locally it should be fine.

We have limited compute available on Travis, so we only run the tests when merging PRs from now on. If you ran the tests locally it should be fine.

Ah I see, makes sense!
I just merged main into subnetlaplace and re-ran the tests locally, and everything still works. So feel free to merge this into main!


Show more than 20 results

Please add a way to view more than 20 entries per page in the search results page

Duplicate of https://github.com/pypa/warehouse/issues/3463.


Can't install app due to non matching architecture.

I have integrated the ios-charts. It worked fine on iphone6+.
Now testing app on iPhone5 (ios 9.0.2).
following are build setting for project and target.

But I am getting this error.

I am not getting any clue. Has anybody got any suggestions please.

Check your app's plist
On Thu, Oct 15, 2015 at 10:51 AM, Ganesh<EMAIL_ADDRESS>wrote:

I have integrated the ios-charts. It worked fine on iphone6+.
Now testing app on iPhone5 (ios 9.0.2).
following are build setting for project and target.
[image: screen shot 2015-10-15 at 1 15 24 pm]
https://cloud.githubusercontent.com/assets/3005149/10507616/5a96e148-733f-11e5-80a6-03114c083836.png
But I am getting this error.
[image: screen shot 2015-10-15 at 1 13 19 pm]
https://cloud.githubusercontent.com/assets/3005149/10507649/8bd6c44e-733f-11e5-9f6a-67f3c6bda995.png
I am not getting any clue. Has anybody got any suggestions please.
—
Reply to this email directly or view it on GitHub
https://github.com/danielgindi/ios-charts/issues/476.

Thanks @danielgindi ,
Yes it solved my problem.
armv7 was not included in app's plist file.


Add button to format query

On export query page, add a button to format the input query, it would include:

removing breaklines
removing double spaces
removing space before a comma, and add a space after a comma
format SOQL keywords (select=> SELECT, from=>FROM etc.)

Where can i find this feature, or is it not released in current chrome version?

Hi @ehsky,
I did not released this functionality but if you're interested in, I can reopen it and add it to the backlog


epiphany: 3.36.2 -> 3.36.3

Semi-automatic update generated by nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/epiphany/versions.
meta.description for epiphany is: "WebKit based web browser for GNOME"
meta.homepage for epiphany is: "https://wiki.gnome.org/Apps/Epiphany"
meta.changelog for epiphany is: ""
Updates performed

Version update

To inspect upstream changes
Impact

Checks done (click to expand)

built on NixOS

The tests defined in passthru.tests, if any, passed

0 of 0 passed binary check by having a zero exit code.

0 of 0 passed binary check by having the new version present in output.

found 3.36.3 with grep in /nix/store/llqadvm5sp0qkdsg996rmnpys78zhr4k-epiphany-3.36.3

directory tree listing: https://gist.github.com/cb0f3217e362f5df302524fde141b8c3

du listing: https://gist.github.com/f11099b962403912c8ee80103ba34a15

Rebuild report (if merged into master) (click to expand)

7 total rebuild path(s)

3 package rebuild(s)

3 x86_64-linux rebuild(s)
2 i686-linux rebuild(s)
0 x86_64-darwin rebuild(s)
2 aarch64-linux rebuild(s)

First fifty rebuilds by attrpath
epiphany
gnome3.epiphany
pantheon.elementary-gsettings-schemas

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/llqadvm5sp0qkdsg996rmnpys78zhr4k-epiphany-3.36.3 \
  --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
  --option trusted-public-keys '
  r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(r-ryantm's Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A epiphany https://github.com/r-ryantm/nixpkgs/archive/b184040712f6ab1e3592389656c91994855772bd.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/llqadvm5sp0qkdsg996rmnpys78zhr4k-epiphany-3.36.3
ls -la /nix/store/llqadvm5sp0qkdsg996rmnpys78zhr4k-epiphany-3.36.3/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review 1

2 packages built:
- epiphany
- pantheon.elementary-gsettings-schemas

Maintainer pings
cc @hedning @jtojnar @worldofpeace for testing.

Closing in favour of #92210


Create a componentize-js CLI experience

Instead of requiring componentize-js to be used as a library, it would be nice if there was also a CLI experience. To begin with the CLI could take two mandatory arguments (the path to the wit package and the path to write the encoded component) and one optional argument (the world to be selected).

jco componentize is designed to be the CLI here - https://github.com/bytecodealliance/jco?tab=readme-ov-file#componentize. For now that is the place to discuss this, although we could split out a ComponentizeJS-specific CLI in future.

That seems fine. Though it did seem more intuitive to me for ComponentizeJS to also have a CLI and be (at least spiritually) the main tool for componentizing JavaScript. I think however this stems from my misunderstanding of what jco is. I wasn't aware that jco was branded as a full toolchain and instead mistakenly thought of it as the runtime support for components in node.
At the very least, would it make sense to point to jco in the README here as the main dev experience for components and JavaScript? Something akin to "use this library if you really need a library for componentizing JavaScript, otherwise you might find more of what you need in the jco project".

I've included a note about jco componentize in https://github.com/bytecodealliance/ComponentizeJS/commit/519256f5632f48e42cfea54bfd588f383eccb855.


Fix some shadow warnings

Fix shadow warning when GnuTLS is enabled
Fix shadow warnings in ND and RT with MFEM_THREAD_SAFE (caused by a merge conflict)

This PR is now under review (see the table in the PR description). To help with the review process, please do not force push to the branch.

Merged in next for testing...


Keep language and options in Code snippet

Every time I make a request and go to the Code Snippet, it always defaults to
Language:JavaScript
Options: Axios
Is there a way to keep the same language and options previously chosen? Or have an option in settings to choose the default one?

@c4ldas  I have made an update to save the selection. Please install the latest version and try again. Also if you like my extension so far Please give a good review.

Hey @subasraj thank you for the update. I can see it works fine on first click, but the next click (or after some more clicks), it changes again to Axios. Check this video below:
https://github.com/user-attachments/assets/77c922b5-63f6-4a56-b3cd-37973fcb79b8
Also, I don't know if it is related to the extension itself, but I need to click twice on the dropdown menu to enable it.
I have just written a review on VS Marketplace, thank you so much for creating such a good extension!

Hi @c4ldas im able to start the video. Can you please upload again

Hi @c4ldas im not able to start the video. Can you please upload again

Thanks for taking your time to check that, I uploaded the video to Youtube, you can check it here:
https://youtu.be/mTM0DMucThM

Hi @c4ldas Please try the latest version, it should work now.

Hi @c4ldas Please try the latest version, it should work now.

Great, I have just tested it and it's keeping the same Language and options as expected! Thank you very much fore that!


refactor(stackable-telemetry)!: Rename Tracing to Telemetry

This PR renames Tracing to Telemetry to more appropriately reflect what the type does: constructing subscribers to process different telemetry signals (currently logs and traces).

We'll hold off on this change until @NickLarsenNZ and I can take a look at how metrics will be handled and if they can be incorporated into the Tracing / Telemetry type.


Weird layout at high number of events

I think events should fill the day instead of being 5 px wide.

We would be glad to donate you again if you could fix this issue for us.


(I #1011) Rename facets

Here's a VERY simple implementation of renaming a facet.

I uses document.prompt() JS function to minimize the risk and difficulty. This count be easily updated to an input type="text" in a next revision, incremental upgrade.
Regards,
Antoine

This is a partial implementation of I #1011.

@thadguidry: both of your request have been forfilled.
The last thing is that now, this ONLY applies to ListFacets. Now, the proper way to add it to all would be to subclass the Facets object in JS.
I have already opened an issue about that, but it is stalled. I think we could just go with this, and later extended it to other facets with the subclassing power.
Regards,
Antoine

@thadguidry: I've added the request to see the column name when hover the title.
I had to be creative, because, for Flags, Stars, and others, there is no column name. So I improvised with a « source value », like for flags, it's <internal-flags>. What do you think of that?
Regards,
Antoine

@antoine2711 I don't understand this. Sorry.  Perhaps Antonin can comment when he has time.

@antoine2711 I don't understand this. Sorry. Perhaps Antonin can comment when he has time.

In I #1011, you asked, when the cursor is over the title, to see the column name of the facet.

So, I just coded that more in this PR. Is it like you wanted?
Regards,
Antoine

@antoine2711 Not really.  See my comment in #1011

I am not sure why you need to add the column in the hover message. Facets can rely on more than one column too (for instance the scatterplot facet or any custom facet with an expression that is relying on multiple columns). I think the simple message you had initially was good.

I am not sure why you need to add the column in the hover message. Facets can rely on more than one column too (for instance the scatterplot facet or any custom facet with an expression that is relying on multiple columns). I think the simple message you had initially was good.

Yes, multi-columns or custom expression would have no particular values.
@thadguidry & @wetneb, the reason I tried this was because in #1011, there is this:

And I thought it was what you mean, Thad. But no problem, it's easy to remove. It could also stay, it's informative most of the time.
Regards,
Antoine

For me it is trying to put too much information in an alt message, which I would normally expect to be a static help text (as a user I would not look for info like this in a help text by hovering an element).

For me it is trying to put too much information in an alt message, which I would normally expect to be a static help text (as a user I would not look for info like this in a help text by hovering an element).

Niether for me is it a hill that I'll die for.
Also, I also think this kind of Tooltip, HTML attribute title, is mostly static and must be optional.
But, by enabling the user to change the name of the facet, the user can loose the information of the column. Of course, this information is sometimes not even very indicative from the start. And this PR doesn't cover all the facets that can be created in OR, but still, it's useful information. I just think that we should not consider this as a solution for providing core configuration data about a facet to the user. A little screen snapshot and a line in the docs should be enough for this, and we should continue to improve the facets.
I also think, @wetneb & @thadguidry, that we could mimic the hover use now in OR to change the title of a project, the yellow background. (And we should also change the cursor of the « Edit project name » to the « click-hand » instead of the I-beam that cannot select letters like it should.)

What do you think of that? Consistency in the user interface and a more visible and discoverable « Rename facet » functionality?
Regards,
Antoine

Let's stick to #1011 needs for now.

Allow the user to rename the facet name

When hovering over the name of the facet, show hover text of the original name always (not the last custom name given)

The hover text should not say anything about "clicking" or whatever... that can be handled visually through a better icon like in 4 below.

(optional) Have a nice edit pointer available for hovering over items in the UI that can be renamed/changed/edited.  A Pencil icon is ideal. https://material.io/resources/icons/?search=edit&icon=create&style=baseline

Then we can merge this and close #1011 to the benefit of users more quickly! :-)
(I don't see an enhancement request for Project renaming changes...so discussion of that can go into a new issue or our mailing list. Thanks!)

(optional) Have a nice edit pointer available for hovering over items in the UI that can be renamed/changed/edited.  A Pencil icon is ideal. https://material.io/resources/icons/?search=edit&icon=create&style=baseline

Do you mean like wikidata? (But maybe on the right?)

Then we can merge this and close #1011 to the benefit of users more quickly! :-)
(I don't see an enhancement request for Project renaming changes...so discussion of that can go into a new issue or our mailing list. Thanks!)

It's not that I want to be OT, but since we are talking about the same action, I think OR should be consistent within itself. Editing the name of the project should not be different than editing the name of a facet.
Regards,
Antoine

Also, I don't think this « closes » #1011, that's why I didn't write (Closes #1011) in the description, nor did I linked it to that issue. But if you believe I'm wrong, I'll go along.
Regards,
Antoine

This is a partial implementation of I #1011.

This statement?  And also the title of this PR states (I #1011)
but yes, I understand that you didn't allude to closing or fixing #1011

(optional) Have a nice edit pointer available for hovering over items in the UI that can be renamed/changed/edited.  A Pencil icon is ideal. https://material.io/resources/icons/?search=edit&icon=create&style=baseline

Do you mean like wikidata? (But maybe on the right?)

Yes.  Location of icon up to you and how it looks and most importantly usefulness to users.

It's not that I want to be OT, but since we are talking about the same action, I think OR should be consistent within itself. Editing the name of the project should not be different than editing the name of a facet.

Great! then you are now thinking like me and Antonin!

@antoine2711 concerning consistency, note that on your screenshot above, the cursor is the one I suggested - even if before the user clicks, the field is not editable yet. So I think it would be consistent to have the same in the facets - and perhaps it would be worth highlighting the facet name in a similar fashion. When the user discovers this feature, they do not know that a JS alert will be used - and that should not cause any issue (you want to give the user clues about editability before they click).

I am closing this PR as stale, given the lack of recent activity. For me the blocking points are:

the use of a JS alert: we should aim for an input field just like for project name editing (in the project view)
using the same cursor as for project name editing.
Feel free to reopen to push this forward!

I am closing this PR as stale, given the lack of recent activity. For me the blocking points are:

the use of a JS alert: we should aim for an input field just like for project name editing (in the project view)
using the same cursor as for project name editing.
Feel free to reopen to push this forward!

Hi @wetneb : this now does exactly like the project renaming.
I changed the cursor for text although IMOO it's not the best choice.
Regards,
Antoine


SFO hives crash pop up on windows restart

As the title says it gives a pop up saying it crashes with some error code. But after clicking continue windows resumes restarting.

Also a repose to your comment in the other issue sorry should've made a separate one.
You did say don't mention known issues but the only issue I saw was the one I made.

This is a known issue as mentioned in the readme.

Fixed in 0.0.7


Complex example

Hello.
Is there somewhere a full example of the using this library? (Not wiki, just code)
Thank's.

Not that I know of. I've not had time to overhaul the documentation yet.
I'm hoping those that will use it will go through the source.
If you have any questions sing out as there are a number of helpful folk
using it that may be able to give you a hand.
On Tue, 19 May 2015 23:06 Eugene Glotov<EMAIL_ADDRESS>wrote:

Hello.
Is there somewhere a full example of the using this library?
Thank's.
—
Reply to this email directly or view it on GitHub
https://github.com/dingo/api/issues/412.

I'm looking for a way to combine this package with laravel-api-generator
I was hoping to find an example of a controller for an object (eg, a user or an article) using dingo / api.

I ask someone from the developers to make a short example of "good practice" usage. For the REST API with normal HTTP response codes and simple Model.

Something like that?
https://github.com/laravelista/Lissandra (I did not test it)

Lissandra does not uses dingo/api, but thank you. It can help me to understand Fractal

Sorry I don't have time to write a complex example for you nor should I be required too. I'm working on documentation but you must realize that I do this in my free time and as such I'm not able to get it done in a couple of days.
So I ask that you be patient. Honestly, there's not a whole lot to this package and the older documentation on the Wiki is still somewhat relevant. Most differences are class names have changed and some methods may be different. My advice is to read over the old documentation, have a play with the package and flick through the source code.


Blank pages

Hi @github-young , thank you very much for contributing such a great template for the UST community. I just have a question regarding the blank pages at around toc, lof, lot, etc., is it required to have these blank pages? Also, how can I remove them? I tried to remove all \clearpage and \cleardoublepage in hkustthesis.cls, but it seemed to be not working...
Thanks in advance!

Hi thank you. These blank pages are not required explicitly by the RPG handbook, but it is a common practice in typesetting books (thesis).
This is a newly-added feature.
You can disable the blank pages by changing the config term blankpages = false in the document options. You can refer to the PDF documentation hkustthese-v0.7.4.pdf in the latest release.

I also uploaded it to Overleaf, but it has not been approved. You can either wait for its approval (probably next Monday) or download all the files in GitHub and then upload them onto your Overleaf project (overwriting the files)

That should be done by the twoside term in document options passed to book documentclass defined in LoadClass line


pressed F10 by accident instead of F9

Description
What steps will reproduce the problem?

Press F10
a window popped up
pressed ESC to close it
Traceback
  File "C:\ProgramData\Anaconda3\lib\site-packages\spyder_profiler\widgets\profilergui.py", line 264, in <lambda>
    self.finished(ec, es))
  File "C:\ProgramData\Anaconda3\lib\site-packages\spyder_profiler\widgets\profilergui.py", line 335, in finished
    self.show_data(justanalyzed=True)
  File "C:\ProgramData\Anaconda3\lib\site-packages\spyder_profiler\widgets\profilergui.py", line 362, in show_data
    self.datatree.show_tree()
  File "C:\ProgramData\Anaconda3\lib\site-packages\spyder_profiler\widgets\profilergui.py", line 526, in show_tree
    rootkey = self.find_root()  # This root contains profiler overhead
  File "C:\ProgramData\Anaconda3\lib\site-packages\spyder_profiler\widgets\profilergui.py", line 507, in find_root
    self.profdata.sort_stats("cumulative")
AttributeError: 'NoneType' object has no attribute 'sort_stats'

Versions

Spyder version: 3.3.1
Python version: 3.7.0
Qt version: 5.9.6
PyQt5 version: 5.9.2
Operating System: Windows 10

Dependencies
pyflakes >=0.6.0  :  2.0.0 (OK)
pycodestyle >=2.3 :  2.4.0 (OK)
pygments >=2.0    :  2.2.0 (OK)
sphinx >=0.6.6    :  1.7.9 (OK)
rope >=0.9.4      :  0.11.0 (OK)
jedi >=0.9.0      :  0.12.1 (OK)
nbconvert >=4.0   :  5.4.0 (OK)
pandas >=0.13.1   :  0.23.4 (OK)
numpy >=1.7       :  1.15.1 (OK)
sympy >=0.7.3     :  1.1.1 (OK)
cython >=0.21     :  0.28.5 (OK)
qtconsole >=4.2.0 :  4.4.1 (OK)
IPython >=4.0     :  6.5.0 (OK)
matplotlib >=2.0.0:  2.2.3 (OK)
pylint >=0.25     :  2.1.1 (OK)

For info: Doesn't happen on OSX.
If you go to the menu at the top, hit 'Run' > 'Profile'  do you get the same error?

Please give us a step-by-step description to reproduce this error. Else we don't know how to solve it.

I have seen the issue I reported one more timeBut now, it doesn't happen, and hitting run > profile doesn't cause it either. FYI, I am running Windows 10
thanks
On Friday, November 30, 2018, 7:37:49 PM CST, Joel Godin<EMAIL_ADDRESS>wrote:
For info: Doesn't happen on OSX.
If you go to the menu at the top, hit 'Run' > 'Profile' do you get the same error?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.


Pass SVF data directly in as String or Array Bugger

Is it possible to directly pass in svf data as a string or array buffer (instead of setting document to a url)?
For example:
    http({
      url: 'http://developer-autodesk.github.io/translated-models/shaver/0.svf',
      responseType: 'arraybuffer'
    }).then(response => {
      const viewer = new Autodesk.Viewing.Private.GuiViewer3D(this.refs.cadCanvas);
      console.log(response.data);
      const options = {
        'env' : 'Local',
        'document' : response.data
      };
      Autodesk.Viewing.Initializer(options, function() {
        viewer.start(options.document, options);
      });
    })

Unfortunately I could not find any documentation on options.env = 'Local' here

The options.env = 'Local' is not officially supported therefore no documentation.
You should pass in the url itself to options.document

So there is no way to pass in the data directly?
Passing a url is not really an option in my use case 😢
Are there any other workarounds? Maybe something like a blob-url would work?

You can also download the entire translated file and reference the entry .svf like this sample.

I cannot reference a local file or a url in my application.
I was hoping I could use a blob url (as follows)
    http({
      url: 'http://developer-autodesk.github.io/translated-models/shaver/0.svf',
      responseType: 'blob'
    }).then(response => {
      const viewer = new Autodesk.Viewing.Private.GuiViewer3D(this.refs.cadCanvas);
      const blobUrl = URL.createObjectURL(response.data);
      const options = {
        'env' : 'Local',
        'document' : blobUrl
      };
      Autodesk.Viewing.Initializer(options, function() {
        viewer.start(options.document, options);
      });
    })

Unfortunately, this throws an error.
Uncaught TypeError: l is not a constructor
e.loadModel	@	viewer3D.min.js?v=v2.10:27
a.loadModel	@	viewer3D.min.js?v=v2.10:29
e.start	@	viewer3D.min.js?v=v2.10:27
(anonymous function)	@	AutodeskLocalViewer.jsx?9ecd:18

I suppose I will have to modify the source code to allow the passing in of data directly if it is not already possible.

Would you share with us your solution when you do? Honestly don't think we've thought of making it possible to not pass in an url.


language server crash on azure-mgmt-network install

Environment data

Language Server version: v2022.4.3
OS and version:

Version: 1.67.1 (system setup)
Commit: da15b6fd3ef856477bf6f4fb29ba1b7af717770d
Date: 2022-05-06T12:37:03.389Z
Electron: 17.4.1
Chromium: 98.0.4758.141
Node.js: 16.13.0
V8: <IP_ADDRESS>-electron.0
OS: Windows_NT x64 10.0.19043

Python version (& distribution if applicable, e.g. Anaconda): 3.10.4

Expected behavior
language server and intellisense should continue to run
Actual behavior
intellisense stopped working and upon investigation in the language server logs it seemed to have crashed
Logs

These are the new logs I see just after the pip3 install azure-mgmt-network
[Info  - 12:24:33 PM] (4436) Found 102 source files
[Info  - 12:24:51 PM] (4436) [BG(1)] Long operation: parsing: XXX/dev_env/lib/python3.10/site-packages/azure/mgmt/network/v2019_12_01/operations/_operations.py (2541ms)
[Info  - 12:24:56 PM] (4436) [BG(1)] Long operation: parsing: XXX/dev_env/lib/python3.10/site-packages/azure/mgmt/network/v2020_04_01/operations/_operations.py (4044ms)
[Info  - 12:25:04 PM] (4436) [BG(1)] Long operation: parsing: XXX/dev_env/lib/python3.10/site-packages/azure/mgmt/network/v2020_05_01/operations/_operations.py (7680ms)
[Error - 12:25:21 PM] (4436) Error occurred on background thread: {"code":"ERR_WORKER_OUT_OF_MEMORY"}

Code Snippet / Additional information
Working on a venv hosted on WSL2 Ubuntu20.04

pip3 install azure-mgmt-network

Thanks for the report, unfortunately, this is not enough data for us to debug.
Would you please add the information in the report as described in the troubleshooting guide?

Closing old issue. If this is still a problem, please reopen with the information requested. thanks


Does ETH have a plan to support eth-proxy stratum mode?

Many miners are using this model, and if they do not support them, they will lose many miners.
To that end, I 'd like to donate some of ETH.

Currently no plans for that. Feel free to submit a PR.


fix: autocommit ui issues

Description

Adds initial checks in Sagas to avoid showing the auto-commit progress bar unnecessarily
Adds component-level checks to avoid rendering progress when auto-commit is disabled
Adds logic to remove branch tab from git settings modal when neither default branch nor protected branch permissions are present

PR fixes following issue(s)
Fixes #30628
Fixes #30631
Fixes #30706
Fixes #30704
Fixes #30737
Media

Type of change

Please delete options that are not relevant.

Bug fix (non-breaking change which fixes an issue)

Testing

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Also list any relevant details for your test configuration.
Delete anything that is not relevant

[x] Manual
[ ] JUnit
[ ] Jest
[ ] Cypress

Test Plan

Add Testsmith test cases links that relate to this PR

Issues raised during DP testing

Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR)

Checklist:
Dev activity

[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] PR is being merged under a feature flag

QA activity:

[ ] Speedbreak features have been covered
[ ] Test plan covers all impacted features and areas of interest
[ ] Test plan has been peer reviewed by project stakeholders and other QA members
[ ] Manually tested functionality on DP
[ ] We had an implementation alignment call with stakeholders post QA Round 2
[ ] Cypress test cases have been added and approved by SDET/manual QA
[ ] Added Test Plan Approved label after Cypress tests were reviewed
[ ] Added Test Plan Approved label after JUnit tests were reviewed

Summary by CodeRabbit

New Features

Enhanced autocommit functionality with improved progress polling, error handling, and branch tabs visibility based on permissions.

Refactor

Adjusted autocommit progress polling logic and action types for better performance and reliability.

/ok-to-test<EMAIL_ADDRESS>


Issue with map and pose

Thank you for sharing your code. I added the static transformation between velodyne and base_link in the launch file. However, after running the launch file, I noticed that there was no displacement between base_link and map. As a result, the full map did not increase. Could you please provide guidance on how to address this issue? Thank you.

Thank you for your response, I have rechecked. I have already changed the frame name to Velodyne. However, I found that my rosbag does not contain the /odom topic. Why do ndt_mapper and ndt_localizer need to subscribe to the /odom topic? Can't they directly use the method of ndt match? Because my wheel encoder is very inaccurate and cannot provide accurate odometry

Thank you very much for your response and explanation. I also set "prediction_method" to "zero" (tried "linear") but the AGV still did not move. I attached the result shown in RViz. There are some warnings when I compile the ndt_opt file. Could that be causing the problem? I also added the link to my rosbag here.

https://drive.google.com/file/d/1vhKqErlnq-MhoyAD_eO2IeWS1NvXEtxF/view?usp=drive_link

I'm not sure whether that warning related to the version of pcl matters. But before that, just to make sure, have you set your initial position in rviz using "2D Pose Estimate"?

yes, I use the pose estimate in rviz, but still the same problem.

I am terribly sorry for my late response. I've been swamped with other tasks. If you're still having the same issue, could you please provide me the rosbag once again? I can try to make things work.


(PUP-7218) systemd service provider missing double dash

Without applying this page any service beging with a '-' (dash) cannot
be started by systemd. This is a problem because it's conventional in
systemd services to do so. This patch allows users to run commands
systemctl enable [service] and systemctl disable [service] by
appending a -- (em dash) between the command and service name. Tests
have been updated to verify corrected output.

Can one of the admins verify this patch?

Waiting for CLA signature by @j-collier
@j-collier - We require a Contributor License Agreement (CLA) for people who contribute to Puppet, but we have an easy click-through license with instructions, which is available at https://cla.puppet.com/
Note: if your contribution is trivial and you think it may be exempt from the CLA, please post a short reply to this comment with details. http://docs.puppet.com/community/trivial_patch_exemption.html

CLA signed by all contributors.

@j-collier , LGTM, you still need to squash your commits also to update tests expectations with new systemctl commands

Thanks all, this should be complete now

jenkins please test this on debian8-64a,debian8-32a,debian9-64a,debian9-32a,fedora28-64a,fedora29-64a,redhat5-64a,centos6-64a,centos6-32a,redhat7-64a,redhat8-64a,redhatfips7-64a,sles11-64a,sles11-32a,sles12-64a,sles12-POWERa,sles15-64a,ubuntu1604-64a,ubuntu1604-32a,ubuntu1804-64a

superseded by #7798


Apply codecov.io configuration

Fixes #132

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@6007d2e). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #134   +/-   ##
=========================================
  Coverage          ?   65.32%
  Complexity        ?      919
=========================================
  Files             ?       87
  Lines             ?     4782
  Branches          ?      561
=========================================
  Hits              ?     3124
  Misses            ?     1417
  Partials          ?      241

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6007d2e...fdc30bc. Read the comment docs.


Update router.go

Removes unused code

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

I don't think that this should be dropped.


Add GitHub contributors and releases

Please have the GitHub fetcher pull the current number of contributors and the date of the last release.
The contributor number we want is 1,605 for Kubernetes.

However, it doesn't seem easily available from the API. This trick is giving me the wrong answer. https://api.github.com/repos/kubernetes/kubernetes/contributors?per_page=1 shows 391.
So, scraping the GitHub HTML page may be easier.
The releases date (which should say 4 days ago) should be a link to https://github.com/kubernetes/kubernetes/releases
If there's no data just don't show.
The contributors number should be a link to https://github.com/kubernetes/kubernetes/graphs/contributors
Cc @caniszczyk

I guess this should go after the last commit date, am I correct ?

Right above first commit is good.
--
Dan Kohn<EMAIL_ADDRESS>Executive Director, Cloud Native Computing Foundation https://www.cncf.io
+1-415-233-1000 https://www.dankohn.com
On Thu, Mar 8, 2018 at 1:07 PM, Andrey Kozlov<EMAIL_ADDRESS>wrote:

I guess this should go after the last commit date, am I correct ?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/cncf/landscape/issues/302#issuecomment-371572685, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AC8MBuEZL3D4wpVulTZIWpj7awPT3rrsks5tcXNvgaJpZM4Sbmr8
.


Unforgiving Timeout

The plugin is logging active users out roughly every 10 minutes, without warning or saving progress. I would think if the user was active it wouldn't timeout. However, currently the plugin will kill the session while the user is editing an entry. There's no way of knowing this until the page refreshes, so our editors are continuing to make edits, but since the session is dead autosave is no longer saving their progress. So whenever they try to save manually, they get redirected to login with any work they've done since the session ended lost.
Ideally the session would not get interrupted if the user is active... Or at least auto-saving changes before killing it would be helpful.

HI @jacksutherland, which version of craft, this plugin and maybe other plugins are you using?
Current versions of this plugin sets values on the current session, which means craft itself should be in charge of session duration.

Hi @roelvanhintum, we keep the site updated to the latest. It's currently at <IP_ADDRESS>, but was doing this before this update as well. There are quite a few other plugins installed:
Knock Knock, Mix, Redactor, Retour, SEOMatic, Servd Assets and Helpers, Sherlock, Super Table, and Typed Link Field.
Disabling the 2FA plugin corrects the problem and session is maintained as usual, even with the rest of these enabled.

Is the 2FA plugin at version 2.10.0? Do you have any session related settings in your general.php? You could check what the $sessionDuration on controllers/VerifyController.php:L43 returns.

No. It's pretty minimal. We use Servd, which handles some configuration across environments. Could that be a factor?
Also, if it were just a shortened session duration, it wouldn't be too bad. The bigger problem is that it's ending abruptly while they're making changes, without any notification to the user. So they're continuing to make edits, and it's all lost as soon as they click save... Then the CP redirects to the login.

@roelvanhintum we upgraded to Craft 4 and it still happens. But I noticed this log entry when it last occurred....
[06/Aug/2022:00:26:47 +0000] "GET /index.php/control/actions/users/session-info?dontExtendSession=1 HTTP/1.1" 200 464 0.078 "https://www.mywebsite.com/control/entries/solutions?sort=structure-asc" "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/<IP_ADDRESS> Safari/537.36" upstream
Any ideas?

Those are both craft's own calls, which looks normal. I'm guessing you're using 2FA 3.0.1?
I think we need to debug this. Can you check what $sessionDuration returns in your case?
https://github.com/born05/craft-twofactorauthentication/blob/3.0.1/src/controllers/VerifyController.php#L42
And just to be sure, can you dump $event->cookieBased and $event->duration?
https://github.com/born05/craft-twofactorauthentication/blob/3.0.1/src/Plugin.php#L66

We were finally able to resolve this with the help of the team at Servd. They ultimately wound creating a new PHP session handler. They wrote a blog article about it if you're interested... https://servd.host/blog/craft-yii-and-redis-session-absentee
As it turns out, the 2FA plugin was NOT the cause the problem. But it was contributing to data loss when the timeout occurred. When Craft times out it gives you a modal window to re-enter your password, so you can seamlessly resume whatever you were doing after re-authenticating. However, since the plugin requires 2FA as well, it redirects you to the 2FA screen, losing any unsaved data you had open. If possible, it may help to present the user with a 2FA modal after they re-enter their password, to avoid the redirect?
Just a thought. Thanks for your help!

Thanks for all the info!! I'm happy Servd was able to find what was going on.
Regarding the login popup: Previously it wasn't possible to hook into the login popup flow (AuthManager.js). I don't think this has changed yet, but i'm still hoping this will become an option.


Setting allwedClasses for "*" tag allows all classes, regardless of the filter

sanitize('Text', {
        allowedTags: [...sanitize.defaults.allowedTags, 'span'],
        allowedClasses: {
            '*': ['allowed'],
        },
    })

Expected:
Text

Actual:

This does not happen when span instead of '*' is used as the tag name for allowedClasses.

Observing the same issue.


this brings setup.py up to date with upstream

This critically fixes missing lit binary by ignoring it.

LGTM


Add two use cases to forks

Hi GMD workgroup,
I just had an interview and we discussed forks.
I am sure there is literature to back up the two use cases, but I wanted to make sure to capture this thought first and we can improve on it later.
Best,
Georg

References:
chaoss/wg-gmd#21
chaoss/wg-gmd#19


docs: Add required Docs PR verbiage to PR template

PR Checklist
Please check if your PR fulfills the following requirements:

[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/device-mqtt-go/blob/master/.github/CONTRIBUTING.md
What is the current behavior?
PR Template doesn't have any verbiage about related Docs PR
Issue Number: n/a
What is the new behavior?
PR Template has verbiage about related Docs PR
Specific Instructions

Other information

Codecov Report

Merging #302 (92c9df6) into main (346d8b8) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #302   +/-   ##
=======================================
  Coverage   23.31%   23.31%
=======================================
  Files           5        5
  Lines         446      446
=======================================
  Hits          104      104
  Misses        329      329
  Partials       13       13

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 346d8b8...92c9df6. Read the comment docs.


Help test first draft of script

@CarlaAstudillo and @sstirling, can you take a few minutes to read the README and test the csver.rb script on your machine?
There's no rush on this, but it's a functioning first draft that works on my machine. I just need help breaking it and isolating issues to fix and improve it.

Also, this script appears to work for both monthly and annual reports. It needs a little bit of tweaking to function entirely properly for the annuals (ie - #9), but any and all bugs you spot, or features you'd like to see, I'd love to hear 'em.

Tested it. The only error I got was it didn't find pdftk (because I didn't have it installed in my computer).
But once I installed pdftk, it worked for both monthly and annual. I think the naming convention for the annual numbers (https://github.com/HackJersey/crime/issues/9) is fine.
I guess the only thing I would say is make sure to tell users to have pdftk installed, although if you're thinking of removing docsplit (see https://github.com/HackJersey/crime/issues/15), then I'm guessing it's not really an issue anymore?

Thanks, Carla! This is super helpful.
I closed #15, so pdftk shouldn't be a problem any more. If you have any other thoughts on command line options you'd be interested in using, in addition to the ones I've listed so far in #11, please let me know.

Also, adding @esagara to this thread in case he wants to kick the tires on this and chime in with some helpful advice.

Officially made this a public beta release today: https://github.com/HackJersey/crime/tree/v0.1.0
Still eager for any and all feedback on the script, but will turn my attention to the data pipeline now.

Closing this issue. If you spot anything we need to address, or have any ideas for improvements, please add an issue.


Moves the Google Search Console verif file to the correct location

Moves the Google Search Console verification file to the content directory so Hugo will serve it.

This change is

Part of issue https://github.com/kubeflow/website/issues/98

/assign @abhi-g

/lgtm
/approve


Add Mkhitar Sebastatsi Educational Complex

Website - https://mskh.am/
Website for college - https://college.mskh.am/
Domain for emails - mskh.am
Provider - outlook
Example for email -<EMAIL_ADDRESS>

@VladimirKaroyan Pull request merged. Thank you!


CorsPolicy not working if matched by headers

Is this the right place to submit this?

[X] This is not a security vulnerability or a crashing bug
[X] This is not a question about how to use Istio

Bug Description
In the VS conf, if I match a request by uri, the corsPolicy works and the related headers are added to the response header. But if I match the request by headers, then non cors related headers are added to the response header.
Here's the config:
When match by uri, it works:
spec:
  http:
    - match:
        - uri:
            prefix: /hello/
      route:
        - destination:
            host: hello.test.svc.cluster.local
            port:
              number: 8080
      corsPolicy:
        allowMethods:
          - POST
          - GET
          - PUT
          - DELETE
          - OPTIONS
        allowHeaders:
          - '*'
        maxAge: 24h
        allowOrigins:
          - regex: .*

The response contains the cors header:
< date: Sat, 07 Oct 2023 09:46:24 GMT
< content-type: application/json
< content-length: 178
< x-content-type-options: nosniff
< x-envoy-upstream-service-time: 161
< access-control-allow-origin: https://example.com
< server: istio-envoy

While matched by headers, it doesn't work:
spec:
  http:
    - match:
        - headers:
            x-i-wantto-go:
              exact: hello.test.svc.cluster.local
      route:
        - destination:
            host: hello.test.svc.cluster.local
            port:
              number: 8080
      corsPolicy:
        allowMethods:
          - POST
          - GET
          - PUT
          - DELETE
          - OPTIONS
        allowHeaders:
          - '*'
        maxAge: 24h
        allowOrigins:
          - regex: .*

No access-control-xxx header in response
Version
istio version: 1.16.5
k8s version: 1.24

Additional Information
No response

Yes. Because the OPTIONS request won't contain the header x-i-wantto-go. You can set cors policy for the defualt route which can match all requests with your host.

@SpecialYang I'm still a little confused about this. Here's the actual request diagram:
client ->  istio-gateway( wasm-filter  ----------------------->  vs (match by header) )  -> upstream
                           inject x-i-wanttgo header

in the wasm-filter, i didn't restrict the type of the Method, so the wasm filter should inject the header to all the requests.
I've tested it and the wasm-filter did inject header even for the OPTIONS requests.
In the vs, requests are matched by the header and then routed to a specific destination. Since the request goes to the right upstream and get the right response, it should contain x-i-wantto-go header.
But there's no cors header in the response. While I make it matched by uri rather than by headers, the cors header appeared.
This is not occur in the browser, just in my terminal via curl. So I guess it's not a problem of OPTIONS?

For the people arriving till here.
The curl command need to include an Origin Header curl -H "Origin: http://localhost:5173/" .... -I


(GH-470) Use Cake.Issues.Recipe for issue management

Replace issue management with Cake.Issues.Recipe. This will bring integration with build servers (currently Azure Pipelines and AppVeyor) and pull request systems (currently Azure Repos).
BuildData class is now empty, but I kept it here since using it is part of #396.
Should wait until final release of 0.3.0 with merging. Once it is released, I'll update it in this PR and mark the PR as ready for review.
Fixes #470

@pascalberger nice!  This looks pretty good to me!  Thanks for doing this!

@pascalberger your changes have been merged, thanks for your contribution 👍


Update downloading-workflow-artifacts.md

Artifacts cannot be downloaded unless a user is logged in, and this is not specified in the current version of the page. Updating for clarity.

Why:
It was unclear why I was not able to download artifacts for a project I wanted to help test. After doing some research, I concluded that even for public repositories, users must be logged in to access artifacts. Even for public repositories, the downloads links are not there unless a user is logged in. This information should be in the relevant documentation page so it is clear to users that this is a requirement.

What's being changed (if available, include any code snippets, screenshots, or gifs):
Added statement that artifacts cannot be downloaded unless a user is logged in.

Check off the following:

[x] I have reviewed my changes in staging (look for the "Automatically generated comment" and click the links in the "Preview" column to view your latest changes).
[x] For content changes, I have completed the self-review checklist.

@TheNH813 Thanks so much for opening a PR! I'll get this triaged for review :zap:


Perf/remove noop casts

While removing isinstance calls, @rayanht added some noop casts to may mypy happy.
In my testing, the class check + the noop cast to satisfy mypy is slower than an isinstance call.
In some cases, mypy can be satisfied with an assert, which means the optimized can run without the cast.
Very minor speedup, but mainly neater without the noop casts.
This branch
codegen         mean runtime:  139.25ms, runs:   164.62,  171.97,  133.90,  129.46,  135.23,  130.50,  128.49,  131.80,  132.25,  134.24
methodcache     mean runtime:  134.42ms, runs:   172.48,  124.85,  126.02,  124.91,  122.18,  122.96,  127.17,  130.37,  124.42,  168.88

Master
codegen         mean runtime:  147.10ms, runs:   168.93,  194.08,  144.76,  141.64,  132.99,  144.88,  130.67,  143.57,  135.97,  133.52
methodcache     mean runtime:  141.62ms, runs:   168.17,  125.07,  127.03,  128.15,  126.01,  122.48,  124.39,  128.67,  155.49,  210.71

Some of these improve the code quality, some make it worse. I'd only merge this if it's a clear code quality win

Updated.
I think this is worth it, see this example form the very busy tensor init. Note the cast in line 55.
master
Total time: 0.735203 s
File: /home/rvd/src/roelofvandijk/tinygrad/tinygrad/tensor.py
Function: __init__ at line 41

Line #      Hits         Time  Per Hit   % Time  Line Contents
==============================================================
    41                                             @profile
    42                                             def __init__(self, data:Union[int, float, list, tuple, LazyBuffer, np.ndarray], device:Optional[str]=None, dtype:Optional[DType]=None, requires_grad:Optional[bool]=None):
    43    188815      49434.0      0.3      6.7      assert dtype is None or isinstance(dtype, DType), f"invalid dtype {dtype}"
    44    188815     115312.8      0.6     15.7      device = Device.canonicalize(device)
    45                                               # tensors have gradients, buffers do not
    46    188815      41352.6      0.2      5.6      self.grad: Optional[Tensor] = None
    47
    48                                               # NOTE: this can be in three states. False and None: no gradient, True: gradient
    49                                               # None (the default) will be updated to True if it's put in an optimizer
    50    188815      33112.4      0.2      4.5      self.requires_grad: Optional[bool] = requires_grad
    51
    52                                               # internal variables used for autograd graph construction
    53    188815      32631.8      0.2      4.4      self._ctx: Optional[Function] = None
    54    178486      47766.2      0.3      6.5      if data.__class__ is LazyBuffer:
    55    178486     131869.0      0.7     17.9        data = cast(LazyBuffer, data) # NOTE: this is a noop, it makes mypy happy
    56    178486      28598.4      0.2      3.9        assert dtype is None or dtype == data.dtype, "dtype doesn't match, and casting isn't supported"
    57    178486      67920.6      0.4      9.2        self.lazydata = data if data.device == device else LazyBuffer.loadop(LoadOps.FROM, data.shape, data.dtype, device, src=data)
    58    178486      27692.3      0.2      3.8        return
    59
    60     10298       7829.1      0.8      1.1      if isinstance(data, (int, float)):
    61     10298     146372.1     14.2     19.9        self.lazydata = LazyBuffer.loadop(LoadOps.CONST, tuple(), dtype or Tensor.default_type, device, data)
    62     10298       2201.2      0.2      0.3        return
    63
    64        30          9.0      0.3      0.0      if data.__class__ is list:
    65        30        440.8     14.7      0.1        data = np.array(data, dtype=(dtype or Tensor.default_type).np)
    66
    67        31         42.9      1.4      0.0      if data.__class__ is np.ndarray:
    68        31         32.8      1.1      0.0        data = cast(np.ndarray, data)
    69        31       1749.2     56.4      0.2        data = LazyBuffer.fromCPU(data)
    70        31        829.0     26.7      0.1        self.lazydata = data if data.device == device else LazyBuffer.loadop(LoadOps.FROM, data.shape, data.dtype, device, src=data)
    71        31          7.0      0.2      0.0        return
    72
    73                                               raise RuntimeError(f"can't create Tensor from {data}")

This branch
Total time: 0.605383 s
File: /home/rvd/src/roelofvandijk/tinygrad/tinygrad/tensor.py
Function: __init__ at line 41

Line #      Hits         Time  Per Hit   % Time  Line Contents
==============================================================
    41                                             @profile
    42                                             def __init__(self, data:Union[int, float, list, tuple, LazyBuffer, np.ndarray], device:Optional[str]=None, dtype:Optional[DType]=None, requires_grad:Optional[bool]=None):
    43    188815      50771.7      0.3      8.4      assert dtype is None or isinstance(dtype, DType), f"invalid dtype {dtype}"
    44    188815     109645.7      0.6     18.1      device = Device.canonicalize(device)
    45                                               # tensors have gradients, buffers do not
    46    188815      51856.6      0.3      8.6      self.grad: Optional[Tensor] = None
    47
    48                                               # NOTE: this can be in three states. False and None: no gradient, True: gradient
    49                                               # None (the default) will be updated to True if it's put in an optimizer
    50    188815      30687.0      0.2      5.1      self.requires_grad: Optional[bool] = requires_grad
    51
    52                                               # internal variables used for autograd graph construction
    53    188815      32578.5      0.2      5.4      self._ctx: Optional[Function] = None
    54    178486      53988.0      0.3      8.9      if type(data) is LazyBuffer:
    55    178486      27955.6      0.2      4.6        assert dtype is None or dtype == data.dtype, "dtype doesn't match, and casting isn't supported"
    56    178486      64601.8      0.4     10.7        self.lazydata = data if data.device == device else LazyBuffer.loadop(LoadOps.FROM, data.shape, data.dtype, device, src=data)
    57    178486      30845.8      0.2      5.1        return
    58
    59     10298       5426.6      0.5      0.9      if type(data) in (int, float):
    60     10298     141989.2     13.8     23.5        self.lazydata = LazyBuffer.loadop(LoadOps.CONST, tuple(), dtype or Tensor.default_type, device, data)
    61     10298       1868.5      0.2      0.3        return
    62
    63        30          9.4      0.3      0.0      if data.__class__ is list:
    64        30        430.1     14.3      0.1        data = np.array(data, dtype=(dtype or Tensor.default_type).np)
    65
    66        31         22.5      0.7      0.0      if type(data) is np.ndarray:
    67        31       1819.5     58.7      0.3        data = LazyBuffer.fromCPU(data)
    68        31        879.9     28.4      0.1        self.lazydata = data if data.device == device else LazyBuffer.loadop(LoadOps.FROM, data.shape, data.dtype, device, src=data)
    69        31          6.1      0.2      0.0        return

A bit more detail:
Mypy understands type(x) is abc', isinstance(x,abc)`. The first should theoretically by  faster, since it does not check for subclasses.
Note that while type(x) is abc and isinstance(x, abc) perform similar when the outcome is true, type is faster if the outcome is false.
I would suggest using type where possible (e.g. if you don't care about subclasses), and definitely not add any casts just to make mypy happy.
Here is a microbenchmark:
x = Tensor([[2]])
0.345 - x.__class__ is Tensor
0.375 - type(x) is Tensor
0.372 - isinstance(x, Tensor)
0.389 - x.__class__ == Tensor
0.452 - type(x) == Tensor
0.798 - cast(x, Tensor) if x.__class__ is Tensor else 1

0.374 - type(x) is int
0.480 - isinstance(x, int)

from timeit import timeit
from tinygrad.tensor import Tensor
from typing import cast
import inspect

x = Tensor([[2]])
print("x = Tensor([[2]])")
n = 10000000

a = lambda: x.__class__ is Tensor
b = lambda: type(x) is Tensor
c = lambda: isinstance(x, Tensor)
d = lambda: x.__class__ == Tensor
e = lambda: type(x) == Tensor
f = lambda: cast(x, Tensor) if x.__class__ is Tensor else 1

for z in (a,b,c,d,e,f):
  print(f"{timeit(z, number=n):.3f} - {inspect.getsource(z)[12:-1]}")

print("\n")
g = lambda: type(x) is int
h = lambda: isinstance(x, int)
for z in (g,h):
  print(f"{timeit(z, number=n):.3f} - {inspect.getsource(z)[12:-1]}")

This is way too close in the microbenchmark. Maybe I let too much go.
Just use isinstance. Readability matters so much more

Quoting what I said last time:
I think this is less readable. In general, unless there's a 5%+ perf gain, I won't merge. The risk of bugs in general outweighs the gains.
The assert isinstance and cast removal increases lines. I'm much more excited about conceptual refactors that either improve perf 20%+ or improve readability.


Revert "ci: remove concern with CARGO_TARGET_DIR"

This reverts commit 56a0aaa6185e2e5db46aef54fb61a4388f89943f.

Codecov Report

Merging #67 (62e9357) into main (083ce2e) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #67   +/-   ##
=======================================
  Coverage   99.39%   99.39%
=======================================
  Files           2        2
  Lines         166      166
=======================================
  Hits          165      165
  Misses          1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 083ce2e...62e9357. Read the comment docs.


Should @context be the CodeMeta schema instead of schema.org?

This issue is referring to https://github.com/citation-file-format/cff-converter-python/blob/master/cff_converter_python/citation.py#L303:
CFF-Core can easily be represented in a pure schema.org contexted codemeta.json file. However, I think there are two reasons why it would perhaps make sense to change the context to https://doi.org/10.5063/schema/codemeta-2.0 (cf. https://github.com/codemeta/codemeta/blob/master/codemeta.json#L2).

It makes the exported codemeta.json future-proof in that it doesn't require the user to change the @context value in order to use the CodeMeta fields that extend schema.org.
There are plans to extend CFF to cover the full field set of CodeMeta, in which case the converter (once it would include the new CFF "module") would produce invalid CodeMeta files if the context was left at schema.org.

On the other hand (cf. https://github.com/codemeta/codemeta/issues/180#issuecomment-375437906), "plain" schema.org files are "unknowingly compatible", hence I'm not sure what the best option would be here, and hence would like to hear your thoughts on this.

I am kind of on the fence on this. I do remember consciously changing the context from codemeta to schema.org because I realized I wasn't using any of the keys that codemeta adds. Additionally, I would like to be able to have an online validation tool to such as https://search.google.com/structured-data/testing-tool, which currently doesn't seem to understand either
  "@context": [
    "https://doi.org/10.5063/schema/codemeta-2.0",
    "http://schema.org"
  ],

or
  "@context": "https://doi.org/10.5063/schema/codemeta-2.0",

or
  "@context": "https://raw.githubusercontent.com/codemeta/codemeta/2.0/codemeta.jsonld",

However, after some more looking around, I found https://json-ld.org/playground/ which seems to be able to deal with e.g.
  "@context": [
    "https://doi.org/10.5063/schema/codemeta-2.0",
    "http://schema.org"
  ],

I guess another argument in favor of changing the context to codemeta is that the function is advertised as exporting citation information to codemeta.


Change the color of share and delete in UITableViewRowAction

Delete container should be darker than table view cell. Share container should be darker than Delete container.

solution: https://github.com/yoha/Thoughtless/commit/9f54e4c1a561035c6a536d079b0f15b38ed77368


Add hobbies section

Like experiences, create a hobbies sections :
  hobbies:
    - title: First hobby
      description: First hobby description
    - title: Second hobby
      description: Second hobby description

Do hobbies really need description ? For now we could only add title (or another single keyword) because I think people could then describle in a few word in the same variable. For example :
  hobbies:
    - title: First hobby (some more infos)
    - title: First hobby (some more infos)

Yes only the title is enought for now.


Added models information to documentation.

Added Joe's information to model.

Codecov Report

Merging #985 into master will increase coverage by 0.07%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #985      +/-   ##
==========================================
+ Coverage   62.61%   62.69%   +0.07%
==========================================
  Files          65       65
  Lines        5080     5080
  Branches      761      761
==========================================
+ Hits         3181     3185       +4
+ Misses       1681     1678       -3
+ Partials      218      217       -1

Impacted Files
Coverage Δ

torchvision/transforms/transforms.py
81.89% <0%> (ø)
:arrow_up:

torchvision/transforms/functional.py
71.12% <0%> (+1.21%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7716aba...f045d08. Read the comment docs.


Add new car component

@R0ixy
Could you please link the Asana to the PRs description and assign yourself?

https://app.asana.com/0/1202525679663009/1202720798232766/f


Not work with http

Not work with http (only https). No any error just not work

Sorry. It's problem with my docker (with 80 port) Closed


"process out of memory" error

Hi, really interested in using the lib, thanks! Got this error, though, after hanging for a few minutes:
(trusty)warren@localhost:~/sites/plots2$ name-your-contributors ipfs --since=2016-10-15T00:20:24Z
Got response
wrote issue_creators
wrote issue_commenters

<--- Last few GCs --->

  403290 ms: Mark-sweep 701.8 (738.5) -> 699.6 (738.5) MB, 8779.9 / 0 ms [allocation failure] [GC in old space requested].
  413027 ms: Mark-sweep 699.6 (738.5) -> 699.6 (738.5) MB, 9736.6 / 0 ms [allocation failure] [GC in old space requested].
  429222 ms: Mark-sweep 699.6 (738.5) -> 698.8 (738.5) MB, 16195.4 / 13 ms [last resort gc].
  441528 ms: Mark-sweep 698.8 (738.5) -> 697.9 (738.5) MB, 12302.8 / 0 ms [last resort gc].

<--- JS stacktrace --->

==== JS stack trace =========================================

Security context: 0x29d65341 <JS Object>
    1: /* anonymous */(aka /* anonymous */) [/home/warren/.nvm/versions/node/v4.4.0/lib/node_modules/name-your-contributors/node_modules/octokat/dist/node/verb-methods.js:79] [pc=0x25676570] (this=0x29d080dd <undefined>,verbFunc=0x47f8f695 <JS Function module.exports.SimpleVerbs.verbs.create (SharedFunctionInfo 0x3a6b53e5)>,verbName=0x29d25431 <String[6]: create>)
    2: injectVerbMethods [/home/wa...

FATAL ERROR: CALL_AND_RETRY_LAST Allocation failed - process out of memory
Aborted (core dumped)

That looks like a lot of data for just the past couple weeks of data; any ideas?

Hey! Sorry for the massive delay getting back to you on this. Currently on vacation // hacking in Japan, haven't had much time. I think we've fixed this issue elsewhere, but I'm not sure I merged it in. Give me a couple of days to take a look at it.

Just encountered the same problem FATAL ERROR: CALL_AND_RETRY_LAST Allocation failed - JavaScript heap out of memory

I'm using:
var nameYourContributors = require('name-your-contributors');

nameYourContributors('ipfs', {
  since: '2016-12-01T00:00:00Z'
});

with prepended env variables in the node nyc.js. Thanks!

But also the above-referenced direct CLI method:
(trusty)warren@localhost:~/$ name-your-contributors ipfs --since=2016-10-15T00:20:24Z

Hey! So! I found @tgetgood, and with his help, this issue is no longer an issue! 🎉
This should now be fixed as of 3.0.0, which uses GraphQL to stop all overfetching issues.
@jywarren Try it again? @diasdavid Feel free to use it for IPFS, too. :)

This works great now. Thanks!
On Mon, Oct 9, 2017 at 10:38 AM, Richard Littauer<EMAIL_ADDRESS>wrote:

Hey! So! I found @tgetgood https://github.com/tgetgood, and with his
help, this issue is no longer an issue! 🎉
This should now be fixed as of 3.0.0, which uses GraphQL to stop all
overfetching issues.
@jywarren https://github.com/jywarren Try it again? @diasdavid
https://github.com/diasdavid Feel free to use it for IPFS, too. :)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/RichardLitt/name-your-contributors/issues/15#issuecomment-335178207,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AABfJ47rvSXG0Wp817LpaDA6fJUTWSKRks5sqi_4gaJpZM4KkQUd
.


upcoming: [M3-7816] - Hide "Switch Account" buttons if child_account_access is false

Description 📝
For parent account users (non-admin), we need to ensure Switch Account button doesn't show if they don't have the child_account_access grant.
Changes  🔄

Checking for child_account_access as part of condition
Added unit test for UserMenu

Target release date 🗓
03/04/2024
Preview 📷

Before
After

How to test 🧪
Prerequisites

Create a parent account
Create a non-admin user on the account
Ensure this new users child_account_access grant is set to false

Reproduction steps

Go to http://localhost:3000/account/billing
Observe that without changes you can see the Switch Account buttons

Verification steps

Checkout local changes or preview link
Observe that the Switch Account button is not rendered

As an Author I have considered 🤔
Check all that apply

[x] 👀 Doing a self review
[x] ❔ Our contribution guidelines
[ ] 🤏 Splitting feature into small PRs
[x] ➕ Adding a changeset
[x] 🧪 Providing/Improving test coverage
[ ] 🔐 Removing all sensitive information from the code and PR description
[x] 🚩 Using a feature flag to protect the release
[ ] 👣 Providing comprehensive reproduction steps
[ ] 📑 Providing or updating our documentation
[ ] 🕛 Scheduling a pair reviewing session
[ ] 📱 Providing mobile support
[ ] ♿  Providing accessibility support

@jdamore-linode I added some E2E tests, but I think I'm getting a false positive (see my TODO in the test).


I May Know Why onShouldStartLoadWithRequest prop Not Work in Android

Bug description:
if I use WebView in JS:
<WebView
        source={{ uri: url }}
        onShouldStartLoadWithRequest={(request)=>{
          console.log(request);
          return true;
        }}
      />

I cannot receive the onShouldStartLoadWithRequest in JS. and if I have  in H5, it jump to browser directly. Then I debug in Android and find it doesn't go to shouldOverrideUrlLoading in WebViewClient. Then I find some solutions in #1869. One is to set setSupportMultipleWindows as false in JS. It works well.
And I find the implementations of setSupportMultipleWindows in Android(RNCWebChromeClient) works like this:

if we allow setSupportMultipleWindows, in Android, it will create a new WebView but not RNCWebView

  protected static class RNCWebChromeClient extends WebChromeClient implements LifecycleEventListener {
    ...
    @Override
    public boolean onCreateWindow(WebView view, boolean isDialog, boolean isUserGesture, Message resultMsg) {

      final WebView newWebView = new WebView(view.getContext());
      final WebView.WebViewTransport transport = (WebView.WebViewTransport) resultMsg.obj;
      transport.setWebView(newWebView);
      resultMsg.sendToTarget();

      return true;
    }
}

the new WebView is not th RNCWebView we create in JS, so the RNCWebView's RNCWebChromeClient doesn't work.
when we meet ， if WebView doesn't set WebViewClient, it will jump to browser to handle something.

above steps may explain why onShouldStartLoadWithRequest in JS not work and why it jumps to browser.
Environment:

OS: Android
react-native version: 0.69.2
react-native-webview version: 11.23.1

Thanks @Juanjuanquanliu . What you describe sounds like the expected behavior, as per the documented changes in https://github.com/react-native-webview/react-native-webview/releases/tag/v11.0.0
But others may have missed those release notes as well, so I appreciate your bringing attention to it. Do you think adding a note about that to the documentation for onShouldStartLoadWithRequest would help reduce confusion in the future? I'm not sure where else we could put that information where people would be likely to see it...
(Also, if https://github.com/react-native-webview/react-native-webview/pull/2640 were to be completed/merged, that might help with some of these use cases.. it still wouldn't trigger onShouldStartLoadWithRequest, but it would raise a new event instead)

yeah, it isn't a bug. I didn't see the type dicussion, sorry. I think it actually needs to add a note to the documentation for onShouldStartLoadWithRequest, this prop is used frequently. The action whether we jump to browser or do other things may be handled or determined by frontend. #2640 can solve the problem but seems to make the onShouldStartLoadWithRequest useless and I think .

https://github.com/react-native-webview/react-native-webview/pull/2640 can solve the problem but seems to make the onShouldStartLoadWithRequest useless

onShouldStartLoadWithRequest is still used for navigation within the WebView (i.e., if the web page isn't asking to open a new window).

Thanks @Juanjuanquanliu . What you describe sounds like the expected behavior, as per the documented changes in https://github.com/react-native-webview/react-native-webview/releases/tag/v11.0.0
But others may have missed those release notes as well, so I appreciate your bringing attention to it. Do you think adding a note about that to the documentation for onShouldStartLoadWithRequest would help reduce confusion in the future? I'm not sure where else we could put that information where people would be likely to see it...
(Also, if #2640 were to be completed/merged, that might help with some of these use cases.. it still wouldn't trigger onShouldStartLoadWithRequest, but it would raise a new event instead)

Hi, I tried to set setSupportMultipleWindows to false but onShouldStartLoadWithRequest still not called for android


build!: Move OpenEXR/Imath minimum to 3.1

These are build-breaking changes that impose a new minimum OpenEXR/Imath version supported of 3.1 or higher.
Needless to say, this will not be backported to any release branches, which guarantee that they will never raise the minimum supported versions of any dependencies. This is just for future OIIO. There is already a "developer preview" branch dev-2.6.1 marking the last spot in master in which the old dependencies are supported.

Thoughts? I have a really interesting one that will come after this!

Fixes #4156


Added overlapping marker spiderfier and refactored in process

Markers which overlap now separate
Modified resource add fake function to randomly create resources at same location
Removed part of marker click listener which zoomed and re-centered map. The default behavior is much better.

r @anniemeng @riyer15 @stephanieyshi


Version 3.1

Is the new version still planned?

I’m watching this also. If the fix can be described, that would help as well. Thanks!

Yes that might help. @pgrady3 could you describe the problem?

A description of the problem would be very helpful to us as well!

Hi all, apologies for the slow reply. I'm pretty busy here finishing up with my PhD, hence the slow progress. Adding a 22 ohm resistor between the transistor gate and the gate drivers fixes the problem of the gate drivers blowing up.
However, there were a few other issues that I've also been working on:

The components are a bit too hard to solder, and determining the orientation of the SOT-23-6's is almost impossible. I'm switching them out for bigger components
The code is a mess. It needs to be cleaned up and
I think the gate driver deadtime is too short, and the transistors heat up a too much during operation.

Apologies on the buggy release. I rushed this one, and as a result it's not very polished.

Thanks very much. This gives me enough confidence to fork it and design a smaller version that fits into a certain application.

@krekr I'd be interested in checking out your fork if you could post it here.

Huzzah for v3.2! Thanks @pgrady3


Tests and main

Now you have the main binary crate, which is used as a playground. That's okay for testing, but it is not organized in the repo.
My idea is that you should not maintain main crate in the repo, but instead write tests for your exercises (or copy-paste them from exercise).
You should start with moving all your code to a lib crate, and then add the tests.

Closed in #6


Streetworks not loading

Occasionally, the streetworks map doesn't load for me. Normally, when I initially load the page, the streetworks are present. When I navigate around the map, the proxy starts returning an empty array of results for locations that previously had results. Is there some rate limiting in place?
e.g. South coast around Worthing

Same problem for me as well, hit and miss whether the data comes through or not.
Hopefully can be fixed as this is a great resource to actually see the description of works.

Unfortunately this is still very mcuh an issue all these months on, is there any sign of a fix coming in the future?