Cannot achieve automated connection and write

Hi,
I'm trying to write a Flutter bloc to achieve automatic connection, write and confirmation between to mobile, for both Android and iOS platform.
I was able to test successfully the respond of my PeripheralManager to the correct write, but I can't achieve to establish a connection with the CentralManager in order to send a write request. I suspect part of the problem is the change of role, but I cannot block the peripheral changing with my semaphore because connectionStateChanged is not available for iOS. I also receive a "trying to send a message from platform API to a non-API platform" when I'm testing the connection between a Windows instance running the CentralManager and an Android instance instance running the PeripheralManager.
I've set static uuid to find the right characteristics but I'm still unable to achieve the correct behavior.
Here's my connection function :
Future _onAddFriendDetection(
AddFriendDetection event,
Emitter emit
) async {
  emit(state.copyWith(status: AddFriendStatus.detection, displayMessage: 'Searching ...'));

  // Changing role permission (semaphore)
  bool changingRole = true;
  // Define role, true = central, false = peripheral
  bool role = true;
  // Max turn
  int maxTurn = 3;

  // Central Stream Subscription
  final StreamSubscription centralSubscription = _centralManager.discoveriesStream.listen((eventArgs) async {
    final peripheral = eventArgs.peripheral;
    final advertisement = eventArgs.advertisement;
    final name = advertisement.name!;
    print("(Central) Detected name : $name");
    if (name == state.friendName) {
      changingRole = false;
      emit(state.copyWith(status : AddFriendStatus.found));
      await _centralManager.stopDiscovery();
      final connect = await _centralManager.connect(peripheral);
      final canWrite = await _centralManager.discoverGATT();
      if (connect && canWrite) {
        final writeResult = await _centralManager.writeRequest(state.id);
        if (writeResult) {
        // POST new friend
        //_friendsRepository.post()
        // Status.success
      } else {
        // Error
        emit(state.copyWith(
          status: AddFriendStatus.failure,
          errorMessage: 'Failed to add your new friend'
        ));
        // State to retry
        emit(state.copyWith(
          status: AddFriendStatus.notFound,
          displayMessage: 'Friend not found. Try again ?'
        ));
      }
      }
    }
    print("Let role switching again");
    changingRole = true;
  });

  // Peripheral Stream Write Subscription
  final StreamSubscription peripheralSubscription =
    _peripheralManager.writeRequestStream.listen((eventArgs) async {
      changingRole = false;
      final request = eventArgs.request;
      final value = utf8.decode(request.value);
      print('(Peripheral) Value received : $value');
      emit(state.copyWith(displayMessage: '(Peripheral) Value received : $value'));
      if (value == state.friendName) {
        // Emit status to break while loop
        emit(state.copyWith(status : AddFriendStatus.found));
        // If correct, respond to request,
        await _peripheralManager.respondWrite(request);
        // POST new friend
        //_friendsRepository.post()
        // Status.success
      } else {
        await _peripheralManager.respondWriteWithError(request);
      }
      changingRole = true;
  });

  // Loop break on status change
  while (state.status == AddFriendStatus.detection) {
    // Launch central
    if (changingRole && role && !_centralManager.discovering) {
      print('Central');
      emit(state.copyWith(displayMessage: "Searching (Central)"));
      await _peripheralManager.stopAdvertising();
      await _centralManager.startDiscovery();
      // Delay
      await Future.delayed(Duration(seconds: 5), () {
        role = false;
      });
    }
    // Launch Peripheral
    if(changingRole && !role && !_peripheralManager.advertising) {
      print('Peripheral');
      emit(state.copyWith(displayMessage: "Searching (Peripheral)"));

      await _centralManager.stopDiscovery();
      await _peripheralManager.startAdvertising(state.id);
      // Delay
      await Future.delayed(Duration(milliseconds: (5000 + Random().nextInt(5000))), () {
        role = true;
        maxTurn --;
      });
    }
    // Breaking loop after maxTurn
    if (maxTurn == 0) {
      // State to retry
      emit(state.copyWith(
        status: AddFriendStatus.notFound,
        displayMessage: 'Friend not found. Try again ?'
      ));
    }
  }
  // State to retry
  emit(state.copyWith(
    status: AddFriendStatus.notFound,
    displayMessage: 'Friend not found. Try again ?'
  ));
  // Cancel subscriptions
  if (state.status == AddFriendStatus.found) {
    _centralManager.dispose();
    _peripheralManager.dispose();
  }
  centralSubscription.cancel();
  peripheralSubscription.cancel();
}

And both my BleCentral and BlePeripheral are based on the ViewModel of the exemple. Sorry if my question is too trivial or doesn't have her place here, I'm still a bit new in the coding community.
Thank you for your answer and the librairy, which is helping me a lot.

Typically we don't act both central role and peripheral role at the same time.
I see there are some methods of the _centralManager does not belong to this plugin.
I don not suggest to change roles in this way. There should always be a peripheral act as GATT server. And other devices use the CentralManager act as GATT client to communicate with the GATT server

Thank you for your response.
What I'm trying to achieve is a connection and "hand shake" between 2 mobile without asking the user to choose between being the central or the peripheral, just a way to add another user close to him physically as a friend automatically. I don't need any more connection or functionality than a write between a machine and the other.
So I've thought that launching each role until one detect another would define the role of each one, with one always acting as a central and the other as a peripheral.
Do you think there would be another way to achieve this connection without changing the roles ? Maybe be launching the two roles together and stopping the other role when one begin to work ? If the split is absolutely necessary, I'll do it but it will be way more unintuitive for the user I think.
Also, I've taken the method connect, discoverGatt(which include discovering GATT services and characteristics) and writeRequest from the PeripheralViewModel to put them into the CentralManager as they are the only method I need to achieve my handshake, could it be a source of problems ? Is it necessary to split the discovery of devices and the connection/write request ?
Thanks again, I admit it make quite some time that I'm stuck on this functionality and not progressing any more.

@RobinSteiger I have no idea about this serverless situation. But I think you can try to seprate the two roles instead of switch between them. Run central and peripheral roles in parallel on newest device should be ok.

@yanshouwang It was this idea that I hadn't, it's working perfectly now. Thanks again for your help and library.


chore: finish up add select testing

Contributes to #2124
adds additional testing to finish up AddSelect coverage.

note- the coverage isn't 100% because an error caused by carbon is preventing me from creating passing tests

@matthewgallo fixt


rustc: 1.74.0 -> 1.74.1

Description of changes
https://blog.rust-lang.org/2023/12/07/Rust-1.74.1.html

Things done

Built on platform(s)

[ ] x86_64-linux
[x] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

I've rebuilt my system with this changed and all packages that use rust compiled fine.

Add a :+1: reaction to pull requests you find important.

This is a duplicate of #272969, which is already in staging-next.

This is a duplicate of #272969, which is already in staging-next.

Oh god, I couldn't find it. Sorry and thanks.


[Question] What does Rectification do?

Noticed this was a new stat provided by some shelf types, but there is no in-game description for it and nothing on the Curseforge page.

Rectification reduces the lower bound on quanta modifications
Standard quanta modifications work by changing your base power (the level) to a value in the range [-Q, +Q].
Having rectification changes this range to [-Q * (1-R), +Q]
So if you had 100% rectification, the quanta modifier range becomes [0, +Q] meaning all rolls are beneficial.


A Way to change VPC/Network/Zone

Just a Suggestion, options to change vpc / network-id . We faced a problem where was not availability of a instance type in the current zone and we had to change network id changing zone

Hi,
Thanks for this suggestion. I had also colleagues that suggested the same recently for the same reasons than yours... It raises some specific challenges (Ip address change and EBS volume zonal affinity especially): I may create a tool dedicated for that purpose (EC2-instance-mover for instance) to move first as-is and convert after with existing ec2-spot-converter in the target subnet/VPC

I'm closing this issue as it won't be solved by modifying ec2-spot-converter but in another tool.


PVE003: Improved Validation Upon Blacklist Activation

acknowledged but intend to keep as it is, explained in https://github.com/Kinza-Finance/KZA-lending/pull/55


Dcv 2040 unit tests dbt coves generate airflow dags

@BAntonellini please fix merge conflicts

still a draft? @BAntonellini

Codecov Report
Attention: 578 lines in your changes are missing coverage. Please review.

Comparison is base (c9fcd60) 44.65% compared to head (01d2260) 44.85%.
Report is 129 commits behind head on main.

Files
Patch %
Lines

dbt_coves/tasks/load/airbyte.py
13.28%
111 Missing :warning:

...bt_coves/tasks/generate/airflow_generators/base.py
0.00%
78 Missing :warning:

...coves/tasks/generate/airflow_generators/airbyte.py
0.00%
76 Missing :warning:

...oves/tasks/generate/airflow_generators/fivetran.py
0.00%
60 Missing :warning:

dbt_coves/tasks/generate/docs.py
40.25%
46 Missing :warning:

dbt_coves/tasks/generate/airflow_dags.py
74.53%
41 Missing :warning:

dbt_coves/tasks/load/fivetran.py
18.60%
35 Missing :warning:

dbt_coves/utils/flags.py
61.01%
23 Missing :warning:

dbt_coves/utils/secrets.py
15.38%
22 Missing :warning:

dbt_coves/core/main.py
60.00%
14 Missing :warning:

... and 14 more

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #411      +/-   ##
==========================================
+ Coverage   44.65%   44.85%   +0.19%
==========================================
  Files          34       42       +8
  Lines        2770     3451     +681
==========================================
+ Hits         1237     1548     +311
- Misses       1533     1903     +370

Flag
Coverage Δ

unittests
44.85% <40.65%> (+0.19%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

@ssassi test worked, removed Draft


Changes

removed functionality not needed from the Appbar
added open maintenance form in the app menu bar

@BrunoJay I am not sure you meant to open this pull request to the master branch of ODK-X tables. Can you please provide the reasoning for the the changes. Referencing issues you fixed is always a positive.

Oh no
Really sorry about that, it was a mistake.
I did that in a rush, I was meant to make the pull request to our master
branch not the odk-x master.
Sorry about that.
And thank you so much, you and your team for ODK-X.
Regards.
On Fri, 28 Aug 2020, 8:15 pm wbrunette<EMAIL_ADDRESS>wrote:

@BrunoJay https://github.com/BrunoJay I am not sure you meant to open
this pull request to the master branch of ODK-X tables. Can you please
provide the reasoning for the the changes. Referencing issues you fixed is
always a positive.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/odk-x/tables/pull/160#issuecomment-682950899, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AJO257BN4J3UGCI5V5WGQBTSC7Q4HANCNFSM4QN2ZPMA
.


Does the requirement for transformers<=4.30 necessary?

Thanks for the great work!
I'm just wondering if the transformers version <=4.30 should be necessary or not.
This is because there are newer audio models (e.g. generative model or other models like Encodec in transformers) that are only available in newer versions of transformers.
Is there potential for conflict between the newer version of transformers and your implementation?

@y10ab1 I did a further check, and I find that the fixated transformers version originates from laion_clap: https://github.com/LAION-AI/CLAP/blob/main/requirements.txt#L16. Unfortunately it needs to be relaxed on the CLAP side.
I believe Encodec should not have restriction on the transformers version. So overall, our library should be able to run fine. Do you have a specific case where there is a conflict?

Just the error message from the dependency check occurs when I install a newer version of transformers (Encodec needstransformers >=4.31 )
I believe the package can still function properly though.

I see, you mean the transformers version of Encodec.
Unfortunately there's not much I can do on this side, but feel free to raise an issue on laion_clap's repo regarding the fixated version.

Got it, thanks!


fix(input field): clear input field:

What does this PR do?

Fix frontend glitch with input fields

Description of Task to be completed?

clear input fields for comments and create on submit

How should this be manually tested?

creating an idea or commenting on an idea

Any background context you want to provide?

none

What are the relevant pivotal tracker stories?

https://www.pivotaltracker.com/story/show/153748110

Screenshots (if appropriate)

Questions:

none

finishes(#153748110)

Coverage remained the same at 84.719% when pulling 415bd6cab322f0a8fa37003ac7b9a099d94215c4 on fix-clear-input-field-153748110 into 730de08d4e24b33a8a9bd01eb4fe81a486693391 on development.


Improvements to qgis and grass packaging, introduce qgis-ltr derivation (revised)

Motivation for this change
Picking up on @mpickering's #150286

Rebased #150286 to latest master to address merge conflicts
Adopts the suggestions from the latest set of review from @SuperSandro2000 in #150286 (amending @mpickering's previous commits for the qtlocation changes, with one final additional commit for the smaller stylistic stuff)
Also updates qgis and qgis-ltr to latest point releases

I've built it on an x86_linux machine but don't actually have a working X environment on it that I can access so I can only confirm that it builds rather than test functionality.
@sikmir @erictapen @lsix
Things done

Built on platform(s)

[X] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[X] Fits CONTRIBUTING.md.

Thanks for pushing this forwards @willcohen

other than that, diff LGTM
the git history could use some squashing of fixup commits. I think there's around 8 logical actions done, there should be a commit for each:
the 3 bumps
wrapping of 2 packages
enabling of more use cases

Got it. Will squash and cleanup.

Squashed and reordered. Re-running nixpkgs-review.

Result of nixpkgs-review pr 156747 run on x86_64-linux 1

3 packages built:

grass
qgis
qgis-ltr

ofborg seems stuck on darwin but we know it'll fail there, so this looks ready to go from my perspective, unless there's any other changes!

Many, many thanks @jonringer!


fix: now search input is no longer squised on non-macOS devices

Description
Used ternary operator to switch between w-56 and w-64, did not use w-72 as the header logo gets very small when approaching sm breakpoint.
Related Tickets & Documents
Fixes #3481
Mobile & Desktop Screenshots/Recordings
Before
Non-macOS

macOS

After
Non-macOS

macOS

Steps to QA

Visit the main page from a mac machine.
Visit the main page from a windows machine.

Tier (staff will fill in)

[ ] Tier 1
[ ] Tier 2
[ ] Tier 3
[x] Tier 4

[optional] What gif best describes this PR or how it makes you feel?

@nickytonline if it's okay to ask, what is the tool you used to show the design across different platforms?


docs: $filter('filter')  Migration 1.2.x to 1.3.x ; Broken change

Here are the facts:
ng-repeat="el in list | filter:{'key': undefined}"

Does not behave the same on 1.2 and 1.3; here are some jsfiddles:
for angular 1.2.x (http://jsfiddle.net/guilbep/2w8ouzr0/)
for angular 1.3.x (http://jsfiddle.net/guilbep/3kj5ug98/)
I've seen nothing in /guide/migration nor in that section 'Angular Expression Parsing'  .. Maybe it is; But it is not clear enough;
I'd be glad to have direction on how and where to improve the docs for this part.
Thank you.

This was a regression (introduced in v1.3.6). It has been fixed with 63b9956 and will be fixed with the next 1.3.x release.
(In fact, it is working as expected in master.)

Thanks @gkalpak - I think we can close this issue then.

@gkalpak @Narretz Good :) thank you for being that fast.


Using vue-paypal-checkout with Nuxt.js as a plugin

I'm currently trying to implement vue-paypal-checkout as a nuxt plugin, but can’t get it to work.
/plugins/vue-paypal.js
import Vue from 'vue'
import PayPal from 'vue-paypal-checkout'

Vue.use(PayPal, {name: 'paypal'})

nuxt.config.js
plugins: [
    { src: '~/plugins/vue-paypal.js', ssr: false }
]

Console error
[Vue warn]: Unknown custom element: <paypal> - did you register the component correctly? For recursive components, make sure to provide the "name" option.

Any idea why this is not working?

Solved with /plugins/vue-paypal.js:
import Vue from 'vue'
import paypal from 'vue-paypal-checkout'

Vue.component('paypal', paypal)


Lotsa improvements

Remove old travis config error
Move pypi to standard reporting
Add pylint versioning checks
Delete tokens that aren't added to Travis successfully

Ping!


Can not open the same folder in a separate window

VSCode Version: 1.10.2

Version 1.10.2
Commit 8076a19fdcab7e1fc1707952d652f0bb6c6db331
Date 2017-03-08T14:00:46.854Z
Shell 1.4.6
Renderer 53.0.2785.143
Node 6.5.0

OS Version: Arch Linux

Linux 4.10.2-1-ARCH SMP PREEMPT Mon Mar 13 17:13:41 CET 2017 x86_64 GNU/Linux

Steps to Reproduce:

Open Folder in VSCode
Create New Window
Try to open the same folder in the second window

Result: nothing happens.
Expected: the same folder opened in both VSCode windows.

boooooooooooring

its the default and expected behavior. you can safely close the issue.


Store pipeline cluster logs in a queryable manner

Parent objective:  #59
Progress: 0%

[x] [P0] Store logs
[x] [P1] Be able to query logs

Done. See https://github.com/src-d/backlog/issues/964


Tiphaine

Hi Tiphaine, you have already conmpleted the first task here : https://github.com/mathurinm/github-assignment/pull/40
so the changes are already integrated in upstream/main. Now you can move to the second part of the assignment.

I will close this PR as the first task is already completed.


v5.3.2 audit merge back

Tag v5.3.2 was created at 692e937dcdbc9637427e60f8458a371a16663af0. Will upload the audit report after merging back.

Need to adjust WETH address in test. Checkout to a new branch #214.


add error param to types for onBeforeNotify callback

Looks like the TypeScript definitions haven't caught up to the work that was done in #103 yet. This PR just updates the definition for onBeforeNotify so that it can optionally accept the original error as the second parameter.

Wonderful, thank you!
We intend to make Typescript checking part of CI in future to prevent regressions like this, as it's not the first time this has happened.

Hey, thanks for getting this merged and released!


Cube Image generation error

I have following the method to generate the cube image by using the staging buffer. However, I copy all the image by using a single vkCmdCopyBufferToImage.  The result image is wrong. Please see the following code:
// Use stagging buffer to copy the skybox image
struct {
VkBuffer buffer;
VkDeviceMemory memory;
} staging_res;
VkBufferCreateInfo buffer_info = {
	VK_STRUCTURE_TYPE_BUFFER_CREATE_INFO, NULL, 0,
	1024 * 1024 * 4 * 6,
	VK_BUFFER_USAGE_TRANSFER_SRC_BIT, VK_SHARING_MODE_EXCLUSIVE, 0, NULL
};
VK_VALIDATION_RESULT(vkCreateBuffer(s_gpu_device, &buffer_info, VK_ALLOC_CALLBACK, &staging_res.buffer));

VkMemoryRequirements mreq_buffer = { 0 };
vkGetBufferMemoryRequirements(s_gpu_device, staging_res.buffer, &mreq_buffer);

VkMemoryAllocateInfo alloc_info_buffer = {
	VK_STRUCTURE_TYPE_MEMORY_ALLOCATE_INFO, NULL, mreq_buffer.size,
	get_mem_type_index(s_gpu, VK_MEMORY_PROPERTY_HOST_VISIBLE_BIT)
};
VK_VALIDATION_RESULT(vkAllocateMemory(s_gpu_device, &alloc_info_buffer, VK_ALLOC_CALLBACK, &staging_res.memory));
VK_VALIDATION_RESULT(vkBindBufferMemory(s_gpu_device, staging_res.buffer, staging_res.memory, 0));

uint8_t *ptr;
VK_VALIDATION_RESULT(vkMapMemory(s_gpu_device, staging_res.memory, 0, VK_WHOLE_SIZE, 0, (void **)&ptr));

const char *name[6] = {
	"Texture/Skybox_right1.png", "Texture/Skybox_left2.png",
	"Texture/Skybox_top3.png", "Texture/Skybox_bottom4.png",
	"Texture/Skybox_front5.png", "Texture/Skybox_back6.png"
};

VkDeviceSize offset = 0;
std::array<VkBufferImageCopy, 6> buffer_copy_regions;
for (int i = 0; i < 6; ++i) {
	int w, h, comp;
	stbi_uc* data = load_image(s_app->activity->assetManager, name[i], &w, &h, &comp, 4);
	if (!data)
		continue;

	size_t size = w * h * comp;
	memcpy(ptr + offset, data, size);

	buffer_copy_regions[i].bufferRowLength = 0;
	buffer_copy_regions[i].bufferImageHeight = 0;
	buffer_copy_regions[i].bufferOffset = offset;
	buffer_copy_regions[i].imageSubresource.aspectMask = VK_IMAGE_ASPECT_COLOR_BIT;
	buffer_copy_regions[i].imageSubresource.baseArrayLayer = i;
	buffer_copy_regions[i].imageSubresource.layerCount = 1;
	buffer_copy_regions[i].imageSubresource.mipLevel = 0;
	buffer_copy_regions[i].imageExtent.width = w;
	buffer_copy_regions[i].imageExtent.height = h;
	buffer_copy_regions[i].imageExtent.depth = 1;
	buffer_copy_regions[i].imageOffset.x = 0;
	buffer_copy_regions[i].imageOffset.y = 0;
	buffer_copy_regions[i].imageOffset.z = 0;

	offset += size;
	stbi_image_free(data);
}
vkUnmapMemory(s_gpu_device, staging_res.memory);

// update the stagging buffer into the cubebox image
VkCommandBufferAllocateInfo staggingCmdInfo;
staggingCmdInfo.sType = VK_STRUCTURE_TYPE_COMMAND_BUFFER_ALLOCATE_INFO;
staggingCmdInfo.pNext = NULL;
staggingCmdInfo.level = VK_COMMAND_BUFFER_LEVEL_PRIMARY;
staggingCmdInfo.commandPool = s_command_pool;
staggingCmdInfo.commandBufferCount = 1;

VkCommandBuffer staggingCmd;
vkAllocateCommandBuffers(s_gpu_device, &staggingCmdInfo, &staggingCmd);

VkCommandBufferBeginInfo staggingBeginInfo = {};
staggingBeginInfo.sType = VK_STRUCTURE_TYPE_COMMAND_BUFFER_BEGIN_INFO;
staggingBeginInfo.pNext = NULL;
staggingBeginInfo.flags = VK_COMMAND_BUFFER_USAGE_ONE_TIME_SUBMIT_BIT;
staggingBeginInfo.pInheritanceInfo = NULL;

VkImageSubresourceRange skybox_subresource_range;
skybox_subresource_range.aspectMask = VK_IMAGE_ASPECT_COLOR_BIT;
skybox_subresource_range.baseMipLevel = 0;
skybox_subresource_range.levelCount = 1;
skybox_subresource_range.baseArrayLayer = 0;
skybox_subresource_range.layerCount = 6;

vkBeginCommandBuffer(staggingCmd, &staggingBeginInfo);

setImageLayout(staggingCmd, s_skybox_image, VK_IMAGE_LAYOUT_UNDEFINED, VK_IMAGE_LAYOUT_TRANSFER_DST_OPTIMAL,
	 skybox_subresource_range, VK_PIPELINE_STAGE_TOP_OF_PIPE_BIT, VK_PIPELINE_STAGE_TRANSFER_BIT);

vkCmdCopyBufferToImage(staggingCmd, staging_res.buffer, s_skybox_image, VK_IMAGE_LAYOUT_TRANSFER_DST_OPTIMAL, buffer_copy_regions.size(), buffer_copy_regions.data());

setImageLayout(staggingCmd, s_skybox_image, VK_IMAGE_LAYOUT_TRANSFER_DST_OPTIMAL, VK_IMAGE_LAYOUT_SHADER_READ_ONLY_OPTIMAL,
	skybox_subresource_range, VK_PIPELINE_STAGE_TRANSFER_BIT, VK_PIPELINE_STAGE_FRAGMENT_SHADER_BIT);

vkEndCommandBuffer(staggingCmd);

VkFence skyboxFence;
VkFenceCreateInfo skyboxFenceInfo;
skyboxFenceInfo.sType = VK_STRUCTURE_TYPE_FENCE_CREATE_INFO;
skyboxFenceInfo.pNext = NULL;
skyboxFenceInfo.flags = 0;
vkCreateFence(s_gpu_device, &skyboxFenceInfo, VK_ALLOC_CALLBACK, &skyboxFence);

VkPipelineStageFlags skyboxPipelineStage = VK_PIPELINE_STAGE_TRANSFER_BIT;
VkSubmitInfo skyboxSubmitInfo = {};
skyboxSubmitInfo.sType = VK_STRUCTURE_TYPE_SUBMIT_INFO;
skyboxSubmitInfo.pNext = NULL;
skyboxSubmitInfo.commandBufferCount = 1;
skyboxSubmitInfo.pCommandBuffers = &staggingCmd;

vkQueueSubmit(s_gpu_queue, 1, &skyboxSubmitInfo, skyboxFence);

vkWaitForFences(s_gpu_device, 1, &skyboxFence, true, UINT64_MAX);

I will look into it during the working week and I'll get back to You.

The staging method is right. The error is related to the skybox geometry generation method. Thanks for your reply.

Hi. I've checked Your code, copied it to my own project and executed. The resulting image indeed looks strange. But when I added one small modification, it started working fine:
int w, h, comp;
stbi_uc* data = load_image(s_app->activity->assetManager, name[i], &w, &h, &comp, 4);
if (!data)
	continue;
comp = 4;
size_t size = w * h * comp;

As far as I remember, stbi_image library always converts loaded image data so it has 4 components. But it also stores the original number of components in the provided variable (comp - in my case it was 3). After adding the line "comp = 4;" the resulting image started looking as it should.
Does it help? If not, could You post more information about the problem You are facing? Some screenshots, or maybe a full source code?

Thanks for your reply.  I will try it. I am just porting the intel's stardust demo to the android platform. The demo demonstrates the power of Vulkan's multithread rendering. The repository is https://github.com/cylof22/Stardust. The original respository is https://github.com/GameTechDev/stardust_vulkan.

Send me a message with information if this helped You or not. But don't forget to change image format according to the number of components that were read from the file.


Spelling mistake in README.md

Correct misspelling of 'flexible' in README.md

Thanks for the pull request! This issue has already been fixed on my local branch but hasn't made its way to GitHub yet. Will merge the one on master as it'll be a bit before I update it but not dev as it'll get fixed next push.


Middle Mouse Button Drag on Wagons and markable slots.

instead of having to middle click every slot with item on hand, or use shift right click then drag around with shift left click and an auto-clicker, it would be awesome to just be able to hold and drag middle click over the slots with item in hand.
Don't know if it's possible but would be very awesome if you could take a look.
Best regards.

Unfortunately this is straight-up impossible. Sorry. :/


increase code testing coverage

It wasn't very good.  I found a bug or two!
close #15

Codecov Report

Merging #34 (84b2b09) into master (1649c56) will increase coverage by 8.67%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #34      +/-   ##
==========================================
+ Coverage   80.90%   89.58%   +8.67%
==========================================
  Files          11       11
  Lines         885      864      -21
==========================================
+ Hits          716      774      +58
+ Misses        169       90      -79

Impacted Files
Coverage Δ

src/atomic_masses.jl
100.00% <ø> (+36.84%)
:arrow_up:

src/cpk_colors.jl
100.00% <ø> (+24.00%)
:arrow_up:

src/bonds.jl
77.63% <100.00%> (+1.97%)
:arrow_up:

src/cordero.jl
100.00% <100.00%> (+5.00%)
:arrow_up:

src/crystal.jl
90.29% <100.00%> (+4.69%)
:arrow_up:

src/misc.jl
98.33% <100.00%> (+30.59%)
:arrow_up:

src/Xtals.jl
100.00% <0.00%> (+18.75%)
:arrow_up:

src/box.jl
95.16% <0.00%> (+32.66%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1649c56...84b2b09. Read the comment docs.


Release: v0.8.2

cc @lvwerra

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.


[Disabled Tests] test/switchStatement/rlexe.xml: Disabled -testtrace cases to eliminate maintenance headache

Either remove or fix/update these tests.

Please fix this.  I do not like having unittests that contain bytecode offsets or enums, as they constantly break when these values change.  Let's see if we can easily fix this or delete the tests if they don't appear to provide a lot of value.

Fixed in ad9a12ab247ac1f48d91ecb8de9499af517a5aa4.


Rework scheduled actions

Shedlock
Maybe work with DB-side triggers

Done with exact scheduling and a backfill mechanism on reboot.


Credit

https://github.com/rabbitmq/rabbitmq-server/blob/master/deps/rabbitmq_stream/docs/PROTOCOL.adoc#credit
How does it work?

You need to ask for credits to receive the messages from the server.
See the .NET implementation
 var (consumerId, response) = await _client.Subscribe(
                _config,
                InitialCredit,
                consumerProperties,
                async deliver =>
                {
                    // receive the chunk from the deliver
                    // before parsing the chunk, we ask for more credits
                    // in this way, we keep the network busy
                    await _client.Credit(deliver.SubscriptionId, 1).ConfigureAwait(false); // before parse the cuck you need to send the credits
                    // parse the chunk, we have another function because the sequence reader
                    // can't be used in an async context
                    ParseChunk(deliver.Chunk);


POC: feat: methods for NamedType

Since dynamic properties are to be removed in PHP 9, we should start working on replacing them.
E.g. this https://github.com/webonyx/graphql-php/pull/1252 is not really sufficient either as graphql-php now gives mixed errors on dynamic properties to consumers.
Also, AllowDynamicProperties attribute is supported only on classes, not interfaces.

I have implemented basic getters for NamedType as an example how it should look in the future. WDYT?

We are not actually using dynamic properties anywhere.

Hm, I see. BTW how do you access name of NamedType in consumer libs? PHPStan does not see those props there on 8.2.

Well currently we and others have to ignore the PHPStan errors.
I defnitely see your point, introducing methods would definitely be one way of making this problem go away. Unfortunately we can not have properties on interfaces - or something like sealed interfaces / union types.

Sure. So what about this POC introducing interface contracts that would allow consumers to call methods?

I am fine with this.


HTML and CSS validation

Check if your HTML and CSS are valid.

Hi Andrey, would you like me to check your HTML and CSS?


git-gutter-fringe isn't dispaly color on the fringe. when i use othe theme

I turn off the default theme, then using the doom-theme. but the git-gutter-fringe can't work correctly.  if i use the default theme zerodark , it is ok.  I think the reason is about the advice radian--advice-git-gutter-remove-bitmaps  I was trying to fix it, but i don't understand how it is working.
Thank you for your share.
Emacs version: 28.0.50
OS: windows 10

Does the problem occur with every other theme, or only with your specific theme? You can test to see if the problem is the advice by disabling it and checking if that changes anything:
(advice-remove #'git-gutter-fr:view-diff-infos #'radian--advice-git-gutter-remove-bitmaps)

I test on the theme of doom-themes zenburn-theme  leuven-theme, the color of fringe is still disappeared.  Evenly after adding (advice-remove #'git-gutter-fr:view-diff-infos #'radian--advice-git-gutter-remove-bitmaps)
It is strange that the gutter-fringe is coming, when i comment out the following code in radian.el
    (radian-defadvice radian--advice-git-gutter-remove-bitmaps
        (func &rest args)
      :around #'git-gutter-fr:view-diff-infos
      "Disable the cutesy bitmap pluses and minuses from `git-gutter-fringe'.
Instead, display simply a flat colored region in the fringe."
      (radian-flet ((defun fringe-helper-insert-region
                        (beg end _bitmap &rest args)
                      (apply fringe-helper-insert-region
                             beg end 'radian--git-gutter-blank args)))
        (apply func args)))

the style of fringe after comment out radian-defadvice radian--advice-git-gutter-remove-bitmaps

the image of fringe with problem

Thank you for the report. I believe the problem is fixed now. The problem was that Zerodark defined a background color for the face, while other themes did not.

Now, It's normally displayed on lenven-theme.  but on doom-theme  zenburn-theme it is still invisible.

I can confirm that that is still a problem. I looked at it, and was unable to figure out what's going on. The face is customized correctly, however for some reason when the doom-one theme is enabled the background of the fringe bitmap is never shown. I checked to see if the problem was the customization of the fringe face, but no dice.

This seems fixed to me now with Emacs 28.1:


Support Deletion of Mame Settings

When a table is deleted, it should also be possible to delete the Mame settings from the Windows registry.

Fixed with version >2.11.2


[ECS] Skip rules which are not part of PSR-2 level

Fixes #696.
I also synced the config with recent changes in PSR-2 ruleset.xml of PHP_CodeSniffer.
BTW... I did not try, will the parameters apply to configs which imports this one, right? And if so, is it possible to "un-skip" these parameters in custom easy-coding-standard.yml, even when the psr2.yml will be imported?

I recommend trying first

Might help:
https://github.com/symfony/symfony/blob/374f6e2353781709356e334665539bc31f2c4e11/src/Symfony/Component/DependencyInjection/Loader/YamlFileLoader.php#L129
Not in parent I guess

Well, so It seems applying the skip params from the imported resrouces does work until you define the same section (like skip in this case) on your own, which then "resets" the all the skipped fixers :disappointed: . So the usecase "just run vendor/bin/ecs check -- level=psr2 src/" does fork and applies PSR-2 properly, however it does not, when you include the PSR-2 check in your custom easy-coding-standard.yml` and use some custom skip there :(
So there are two issues which IMO needs to be solved:

there should be a way how to "inherit" skip from parent resource, even when setting custom skips; so maybe some merging etc. could be done inside the Kernel? Or something completely different?
once :top: is done, there should also be a way how to reenable skip applied by some imported resource (something like setting the skip value to false?)

there should be a way how to "inherit" skip from parent resource, even when setting custom skips; so maybe some merging etc. could be done via the Kernel? Or something completely different?

I'd start with adding failing test - using imports in .yml config, similar to this: https://github.com/Symplify/Symplify/blob/d0a36f2965e63b5ed4506de821116d00fc8bb0ef/packages/EasyCodingStandard/tests/Yaml/CheckerTolerantYamlFileLoaderTest.php#L23, just checking parameters instead of definitions. You can add it to same directory just with different name.
Then I'd try to solve the same way checker short services definitions are made. In this method: https://github.com/Symplify/Symplify/blob/d0a36f2965e63b5ed4506de821116d00fc8bb0ef/packages/EasyCodingStandard/src/Yaml/CheckerTolerantYamlFileLoader.php#L55 There you can add new parameters to ContainerBuilder.
We can continue after this is resolved. I hear you need for undisabling this

Hi Tomáš, thanks for the suggestions. Though I'm not quite sure I'll be able to this, I'd love to help but its currently out of my time possibilities to study the codebase so that I'm able to implement this kind of change properly :-/.
However without this, this PR won't work as expected if someone use custom skip parameters in their own easy-coding-standard.yml  file... :-(
Also we are now trying to define our company-wide rules using ECS, but we came across the same problem - if anyone will use his own skip section (which is quite common), it will overwrite the whole common "skip" section and the codestyle will not work as it should.

Hi Ondra, I feel you.
If you can send failing test with few cases, I can help with the rest.

So I rebased the PR and can confirm this is now working as expected :+1: . The skips are applied even when the resource is imported and custom rules are skipped.
However - if eg. some code was skipped by some imported resource, is there a way how to reenable it, as mentioned here?

Thank you :+1:

However - if eg. some code was skipped by some imported resource, is there a way how to reenable it in my easy-coding-standard.yaml, as mentioned here?

Well, I liked the solution you proposed - it's clear to me:

something like setting the skip value to false

Could you prepare failing test with config trying to exclude parent value by false value?

@TomasVotruba I'm not sure this will be responsibility of the YamlFileLoader (or will it?).
The issue is:

parent config has parameters: skip: Some.Code: ~
you wan't to re-enable this code in your config, so you add you own skip with false value: parameters: skip: Some.Code: false

As a result, skip should not contain Some.Code, ie. it will be applied. So should this be done on YamlFileLoader level? I'm not sure, because this behavior specific probably only for the skip section...

Probably not. It's too specific as you said.
Where would you put it?

I think null/false syntax could be very confusing since null is a valid value in service definitions.
I remembered this custom yaml tag syntax: https://symfony.com/blog/new-in-symfony-3-3-custom-yaml-ags
tl;dr;
$yaml = "!my_tag { foo: bar }";
$config = Yaml::parse($yaml, Yaml::PARSE_CUSTOM_TAGS);

$tag = $config->getTag();     // $tag = 'my_tag'
$value = $config->getValue(); // $value = array('foo' => 'bar')

Example
We could use it like this:
parameters:
    skip:
        - !this_value_will_be_removed

Then we detect parameters to be removed and after loading of all config files we call compiler pass and clean the ParameterBag.
What do you think?

Yes, this would be an option as well. Though you must somehow handle inheritance here as well (What if imported resource already adds this negative flag, would it be possible to override it again :-D?)
BTW the linked page on Symfony blog does not exists :).

Link fixed :+1:
Well, the last wins :)


Revamp of the launch tutorials.

Clean them up with more clear language.  Also make sure to
add in Python, XML, and YAML examples for everything so we
have parity.
Signed-off-by: Chris Lalancette<EMAIL_ADDRESS>Inspired by #2920 .  Note that I only had time to add in XML and YAML examples for the first two tutorials; we'll need to follow up later on the substitutions and event handlers.

Thanks for the review!  I made the requested fixes, so I'm going to go ahead and merge this and backport it.


dnssec_key: Add names for ED curves to algorith()

https://datatracker.ietf.org/doc/html/rfc8080.html

Merged. Thx!


The Brush received two methods which offers the possibility to access…

… the extent of either the Y or X axis directly.

GWT-D3 Official Repo » gwt-d3 #30 SUCCESS
This pull request looks good
(what's this?)

GWT-D3 Official Repo » gwt-d3 #31 SUCCESS
This pull request looks good
(what's this?)

I could not see a place to start a conversation other than this .. Please update the license of gwt-d3 in your home page or wiki. I hope it is BSD license.

Hi,
I've added a "LICENSE" section in the home page. Is it ok for you ?
Anthony
2015-06-08 12:06 GMT+02:00 Anil Franklin<EMAIL_ADDRESS>
I could not see a place to start a conversation other than this .. Please
update the license of gwt-d3 in your home page or wiki. I hope it is BSD
license.
—
Reply to this email directly or view it on GitHub
https://github.com/gwtd3/gwt-d3/pull/123#issuecomment-109940217.

--
Anthoni Schiochet
+33 (0)6 51 81 11 87

but it doesn't say it is a BSD license. That is why I mentioned. Thanks
On Mon, Jun 8, 2015 at 4:43 PM, anthonime<EMAIL_ADDRESS>wrote:

Hi,
I've added a "LICENSE" section in the home page. Is it ok for you ?
Anthony
2015-06-08 12:06 GMT+02:00 Anil Franklin<EMAIL_ADDRESS>
I could not see a place to start a conversation other than this .. Please
update the license of gwt-d3 in your home page or wiki. I hope it is BSD
license.
—
Reply to this email directly or view it on GitHub
https://github.com/gwtd3/gwt-d3/pull/123#issuecomment-109940217.

--
Anthoni Schiochet
+33 (0)6 51 81 11 87
—
Reply to this email directly or view it on GitHub
https://github.com/gwtd3/gwt-d3/pull/123#issuecomment-109953510.

--
regards
-Anil Franklin
http://anilnf.co.nr


ipv6 support

Hi Federico,
I guess libvmod-geoip2 doesnt support ipv6 from https://support.maxmind.com/ipv6-data-faq/
Do you plan to support it?
Thanks.

It should just work fine if the DB you are using has the data.
See https://github.com/fgsch/libvmod-geoip2/blob/master/src/tests/b00001.vtc#L27 for example.

Thanks a lot. Works for me.


Updating the Slider Widget to allow up and down arrow keys to navigate out of the slider.

Updating Slider Widget to allow up and down arrow keys to navigate out of the slider.
This prevents users using directional navigation from becoming stuck on the slider once they navigate to it.

Do you have a repro to demonstrate the problem?

cc @clocksmith
cc @gspencergoog
This is a fresh copy of https://github.com/flutter/flutter/pull/102116

@chunhtai this happens when a directional interface is created (like with a TV remote), and if up and down are mapped as well as left and right, then the slider "traps" the focus, since you move onto the slider and then can't move off at all (it just adjusts the slider no matter which direction you try to go).  This PR will change it so that left and right still adjust the slider, but up and down can navigate you off of it.
I've asked the material designers about this, but they don't appear to have any specs yet for key bindings.

I've CC'd you both on the internal Google bug in our app if that helps.  There is a link to a video in there.

I am just throwing ideas. can the slider bubble up the intent if the slider reach the max/min value when arrow up and down?

It could, but then it would be impossible to adjust the slider to any value other than max/min (and leave it set there and move on to something else).

I did a few test on different platforms. on Android, it looks like the up and down can escape the slider while left right change the value. On the mac chrome, surprisingly, the left down arrow changes the value, I am using this example https://www.w3schools.com/howto/howto_js_rangeslider.asp

This is because Android has directional navigation built in and the web doesn't.  Perhaps this change should be sensitive to kIsWeb and only disable up/down value changes there, but if the developer wants to implement a TV or game interface that runs in a browser, I'm not sure how they would disable them.

Right, the chrome browser is being primarily navigated via tab and shift-tab, not directional navigation.
The TV interface in a browser is exactly what we are building here, so kIsWeb would not help us.  One alternative that would work for us would be to check for NavigationMode.directional in the MediaQuery, which was my first attempt at this.

We may need to be careful about mobile web user if we check kIsWeb though. I think we can make it platform dependent. For example, Android/iOS can up down navigate, while macOS/Windlows/Linux can't.
Although we may not be able fix case where people want this behavior on desktop (for example steam app), but I think we can figure that out if that becomes a problem?

I like the idea of predicating it on the NavigationMode.  That's why we added that in the first place.

OK, so, back to the predicating this change NavigationMode.directional then?

I went ahead and reverted the change to my original NavigationMode-based implementation since that seems to be where this discussion is leaning now.


service_registry.dart should use the service registry handle instead of shell handle

R=@abarth,@tonygentilcore

lgtm

Oops!   LGTM


Multiple vlan interfaces on same interface not working

Describe the bug
This issue was already hinted at in issue #26235, but the author was asked to create a separate issue. I could not find such a followup issue, if I missed it please link it here and close this one.
I want to run two vlan interfaces on the same ethernet interface in addition to the normal interface (board: nucleo f767zi). To achieve this, I extended the vlan sample with an additional vlan interface, similar to the one that is already present (I extended the code, the KConfig file and the prj.conf accordingly). On my machine, I used the zeth-vlan.conf from the net-tools repo.
I can ping all interfaces indivually. I can also ping one vlan interface and the normal interface at the same time. But pinging both vlan interfaces at the same time stops working quickly.
In the previous issue, it was already discovered that the problem shows itself in ethernet_send in ethernet.c. It can easily be observed by enabling the debug output and checking the output of set_vlan_tag, which discovers that the interface indicated in the packet and the interface given to the function are different. set_vlan_tag handles this by overwriting the interface that was passed as parameter with the interface returned by net_if_ipv6_addr_lookup(&NET_IPV6_HDR(pkt)->src, &target)). As far as I can tell, the interface returned by net_if_ipv6_addr_lookup(&NET_IPV6_HDR(pkt)->src, &target)) is the correct one.
This change is never propagated to ethernet_send, which then proceeds with the wrong vlan interface, resulting in an error.
The interface parameter iface is created in process_tx_packet in net_if.c:
pkt = CONTAINER_OF(work, struct net_pkt, work);
net_pkt_set_tx_stats_tick(pkt, k_cycle_get_32());
iface = net_pkt_iface(pkt);

Unfortunately, I am not familiar enough with the inner workings to know where the packet originates from.
To Reproduce
Steps to reproduce the behavior:

Extend the vlan sample with an additional vlan interface.
Compile and flash it to the board with debug output enabled.
Ping multiple vlan interfaces at the same time.
After a short amount of time, the pings stop working. You can also check the output in a serial terminal: Iface <iface1> should be <iface2>

Expected behavior
Pings with multiple vlans should work normally.
Logs and console output
prj.conf:
CONFIG_NETWORKING=y
CONFIG_NET_LOG=y
CONFIG_NET_IPV6=y
CONFIG_NET_IPV4=n
CONFIG_NET_DHCPV4=n
CONFIG_NET_UDP=y
CONFIG_NET_TCP=n
CONFIG_NET_STATISTICS=y
CONFIG_TEST_RANDOM_GENERATOR=n
CONFIG_NET_PKT_RX_COUNT=32
CONFIG_NET_PKT_TX_COUNT=32
CONFIG_NET_BUF_RX_COUNT=32
CONFIG_NET_BUF_TX_COUNT=32
CONFIG_NET_IF_UNICAST_IPV6_ADDR_COUNT=10
CONFIG_NET_IF_MCAST_IPV6_ADDR_COUNT=10
#CONFIG_NET_IF_UNICAST_IPV4_ADDR_COUNT=1
CONFIG_NET_MAX_CONTEXTS=20
CONFIG_INIT_STACKS=y
CONFIG_PRINTK=y
CONFIG_NET_SHELL=y
# Ethernet is needed for VLAN
CONFIG_NET_L2_ETHERNET=y
CONFIG_NET_CONFIG_NEED_IPV6=y
CONFIG_NET_CONFIG_NEED_IPV4=n
CONFIG_NET_CONFIG_SETTINGS=y
# First ethernet interface will use these settings
CONFIG_NET_CONFIG_MY_IPV6_ADDR="2001:db8::1"
CONFIG_NET_CONFIG_PEER_IPV6_ADDR="2001:db8::2"
# VLAN tag for the first interface
CONFIG_SAMPLE_VLAN_TAG_1=100
CONFIG_SAMPLE_IPV6_ADDR_1="2001:db8:100::1"
CONFIG_LOG_STRDUP_BUF_COUNT=40
# Settings for the second network interface
CONFIG_SAMPLE_IPV6_ADDR_2="2001:db8:200::1"
CONFIG_SAMPLE_VLAN_TAG_2=200
CONFIG_LOG=y
CONFIG_NET_VLAN=y
CONFIG_NET_VLAN_COUNT=3
CONFIG_NET_ROUTING=y

Environment (please complete the following information):

OS: Linux
Toolchain: (arm-none-eabi-gcc 10.2.0)
Version: 2.4.99 (latest master)

Additional context
pr #29865 is from the same author that mentioned the problem in the issue but does not seem to address this problem.

I just tested this and it definitely works for me (with echo-server sample app). I tested it like this:
Terminal 1 (net-tools):
cd net-tools
./net-setup.sh -c zeth-vlan.conf

Terminal 2 (zephyr):
cd samples/net/sockets/echo_server
cmake -Bbuild -DBOARD=qemu_x86 . -DOVERLAY_CONFIG="overlay-e1000.conf overlay-vlan.conf"
make -C build run

Then in net-shell in terminal 2:
uart:~$ net iface

Interface 0x14d8b4 (Ethernet) [1]
===================================
Link addr : 52:54:00:12:34:56
MTU       : 1500
Ethernet capabilities supported:
	Virtual LAN
	10 Mbits
	100 Mbits
	1 Gbits
IPv6 unicast addresses (max 3):
	fe80::5054:ff:fe12:3456 autoconf preferred infinite
	2001:db8::1 manual preferred infinite
IPv6 multicast addresses (max 4):
	ff02::1
	ff02::1:ff12:3456
	ff02::1:ff00:1
IPv6 prefixes (max 2):
	<none>
IPv6 hop limit           : 64
IPv6 base reachable time : 30000
IPv6 reachable time      : 15012
IPv6 retransmit timer    : 0
IPv4 unicast addresses (max 1):
	<IP_ADDRESS> manual preferred infinite
IPv4 multicast addresses (max 1):
	<none>
IPv4 gateway : <IP_ADDRESS>
IPv4 netmask : <IP_ADDRESS>

Interface 0x14d978 (Ethernet) [2]
===================================
Link addr : 52:54:00:12:34:56
MTU       : 1500
VLAN tag  : 100 (0x64)
Ethernet capabilities supported:
	Virtual LAN
	10 Mbits
	100 Mbits
	1 Gbits
IPv6 unicast addresses (max 3):
	fe80::a9b6:7cff:fe3c:8617 autoconf preferred infinite
	2001:db8:100::1 manual preferred infinite
IPv6 multicast addresses (max 4):
	ff02::1
	ff02::1:ff3c:8617
	ff02::1:ff00:1
IPv6 prefixes (max 2):
	<none>
IPv6 hop limit           : 64
IPv6 base reachable time : 30000
IPv6 reachable time      : 27477
IPv6 retransmit timer    : 0
IPv4 unicast addresses (max 1):
	<IP_ADDRESS> manual preferred infinite
IPv4 multicast addresses (max 1):
	<none>
IPv4 gateway : <IP_ADDRESS>
IPv4 netmask : <IP_ADDRESS>

Interface 0x14da3c (Ethernet) [3]
===================================
Link addr : 52:54:00:12:34:56
MTU       : 1500
VLAN tag  : 200 (0xc8)
Ethernet capabilities supported:
	Virtual LAN
	10 Mbits
	100 Mbits
	1 Gbits
IPv6 unicast addresses (max 3):
	fe80::a40c:b4ff:fee8:d64e autoconf preferred infinite
	2001:db8:200::1 manual preferred infinite
IPv6 multicast addresses (max 4):
	ff02::1
	ff02::1:ffe8:d64e
	ff02::1:ff00:1
IPv6 prefixes (max 2):
	<none>
IPv6 hop limit           : 64
IPv6 base reachable time : 30000
IPv6 reachable time      : 38215
IPv6 retransmit timer    : 0
IPv4 unicast addresses (max 1):
	<IP_ADDRESS> manual preferred infinite
IPv4 multicast addresses (max 1):
	<none>
IPv4 gateway : <IP_ADDRESS>
IPv4 netmask : <IP_ADDRESS>

So there is 3 interfaces, the master one is the first 1, the other two are the VLAN interfaces.
In Linux side, I am seeing also three interfaces:
$ ifconfig
zeth: flags=4099<UP,BROADCAST,MULTICAST>  mtu 1500
        inet <IP_ADDRESS>  netmask <IP_ADDRESS>  broadcast <IP_ADDRESS>
        inet6 fe80::200:5eff:fe00:53ff  prefixlen 64  scopeid 0x20<link>
        inet6 2001:db8::2  prefixlen 128  scopeid 0x0<global>
        ether 00:00:5e:00:53:ff  txqueuelen 1000  (Ethernet)
        RX packets 39  bytes 3546 (3.4 KiB)
        RX errors 0  dropped 0  overruns 0  frame 0
        TX packets 57  bytes 5338 (5.2 KiB)
        TX errors 0  dropped 1 overruns 0  carrier 0  collisions 0

vlan.100: flags=4163<UP,BROADCAST,RUNNING,MULTICAST>  mtu 1500
        inet <IP_ADDRESS>  netmask <IP_ADDRESS>  broadcast <IP_ADDRESS>
        inet6 2001:db8:100::2  prefixlen 128  scopeid 0x0<global>
        inet6 fe80::200:5eff:fe00:53ff  prefixlen 64  scopeid 0x20<link>
        ether 00:00:5e:00:53:ff  txqueuelen 1000  (Ethernet)
        RX packets 2  bytes 156 (156.0 B)
        RX errors 0  dropped 0  overruns 0  frame 0
        TX packets 8  bytes 832 (832.0 B)
        TX errors 0  dropped 0 overruns 0  carrier 0  collisions 0

vlan.200: flags=4163<UP,BROADCAST,RUNNING,MULTICAST>  mtu 1500
        inet <IP_ADDRESS>  netmask <IP_ADDRESS>  broadcast <IP_ADDRESS>
        inet6 fe80::200:5eff:fe00:53ff  prefixlen 64  scopeid 0x20<link>
        inet6 2001:db8:200::2  prefixlen 128  scopeid 0x0<global>
        ether 00:00:5e:00:53:ff  txqueuelen 1000  (Ethernet)
        RX packets 2  bytes 156 (156.0 B)
        RX errors 0  dropped 0  overruns 0  frame 0
        TX packets 8  bytes 832 (832.0 B)
        TX errors 0  dropped 0 overruns 0  carrier 0  collisions 0

I can then use echo-client in net-tools
$ ./echo-client <IP_ADDRESS>
.......
Average round trip 4 ms
Sent 7 packets

here the data will be routed via vlan.200 interface in Linux and interface 3 in zephyr.

Can you elaborate more detail what you are doing so I can try to replicate the issue?

Sorry for the late reply.
Here are my exact steps starting from a fresh zephyr setup with the echo_server example.

Modify the prj.conf to enable vlan. I do this by copying the config from overlay-vlan.conf to prj.conf. Nothing else in this project was touched.

This is the output of west diff for the prj.conf file:
# Generic networking options
 CONFIG_NETWORKING=y
 CONFIG_NET_UDP=y
-CONFIG_NET_TCP=y
+CONFIG_NET_TCP=n
 CONFIG_NET_IPV6=y
-CONFIG_NET_IPV4=y
+CONFIG_NET_IPV4=n
 CONFIG_NET_SOCKETS=y
 CONFIG_NET_SOCKETS_POSIX_NAMES=y
 CONFIG_POSIX_MAX_FDS=6
@@ -20,6 +20,7 @@ CONFIG_NET_LOG=y
 CONFIG_LOG=y
 CONFIG_NET_STATISTICS=y
 CONFIG_PRINTK=y
+CONFIG_NET_SHELL=y

 # Network buffers
 CONFIG_NET_PKT_RX_COUNT=16
@@ -34,7 +35,7 @@ CONFIG_NET_IF_MCAST_IPV6_ADDR_COUNT=4
 CONFIG_NET_MAX_CONTEXTS=10

 # Network shell
CONFIG_SHELL=y

 # Network application options and configuration
@@ -42,7 +43,7 @@ CONFIG_NET_CONFIG_SETTINGS=y
 CONFIG_NET_CONFIG_NEED_IPV6=y
 CONFIG_NET_CONFIG_MY_IPV6_ADDR="2001:db8::1"
 CONFIG_NET_CONFIG_PEER_IPV6_ADDR="2001:db8::2"
-CONFIG_NET_CONFIG_NEED_IPV4=y
+CONFIG_NET_CONFIG_NEED_IPV4=n
 CONFIG_NET_CONFIG_MY_IPV4_ADDR="<IP_ADDRESS>"
 CONFIG_NET_CONFIG_PEER_IPV4_ADDR="<IP_ADDRESS>"

@@ -52,3 +53,27 @@ CONFIG_POSIX_MAX_FDS=12

 # How many client can connect to echo-server simultaneously
-CONFIG_NET_SAMPLE_NUM_HANDLERS=1
+CONFIG_NET_SAMPLE_NUM_HANDLERS=5
+
+
+CONFIG_NET_VLAN=y
+
+# We have one non-vlan interface and two VLAN interfaces
+CONFIG_NET_VLAN_COUNT=3
+
+# There will be three network interfaces.
+
+# First ethernet interface will use these settings
+CONFIG_NET_CONFIG_MY_IPV6_ADDR="2001:db8::1"
+CONFIG_NET_CONFIG_PEER_IPV6_ADDR="2001:db8::2"
+
+# Second ethernet interface will have these settings
+CONFIG_NET_SAMPLE_IFACE2_MY_IPV6_ADDR="2001:db8:100::1"
+# TEST-NET-2 from RFC 5737
+# VLAN tag for the second interface
+CONFIG_NET_SAMPLE_IFACE2_VLAN_TAG=100
+
+# Settings for the third network interface
+CONFIG_NET_SAMPLE_IFACE3_MY_IPV6_ADDR="2001:db8:200::1"
+# TEST-NET-3 from RFC 5737
+# VLAN tag for the second interface
+CONFIG_NET_SAMPLE_IFACE3_VLAN_TAG=200

Build the example (I use west).
west build zephyr/samples/net/sockets/echo_server -b nucleo_f767z

Flash it to the board.

Check board network

uart:~$ net iface

Interface 0x20024e18 (Ethernet) [1]
===================================
Link addr : 02:80:E1:FB:E7:4E
MTU       : 1500
Ethernet capabilities supported:
        Virtual LAN
        10 Mbits
        100 Mbits
IPv6 unicast addresses (max 3):
        fe80::80:e1ff:fefb:e74e autoconf preferred infinite
        2001:db8::1 manual preferred infinite
IPv6 multicast addresses (max 4):
        ff02::1
        ff02::1:fffb:e74e
        ff02::1:ff00:1
IPv6 prefixes (max 2):
        <none>
IPv6 hop limit           : 64
IPv6 base reachable time : 30000
IPv6 reachable time      : 28799
IPv6 retransmit timer    : 0

Interface 0x20024e90 (Ethernet) [2]
===================================
Link addr : 02:80:E1:FB:E7:4E
MTU       : 1500
VLAN tag  : 100 (0x64)
Ethernet capabilities supported:
        Virtual LAN
        10 Mbits
        100 Mbits
IPv6 unicast addresses (max 3):
        fe80::a554:b1ff:feac:b33 autoconf preferred infinite
        2001:db8:100::1 manual preferred infinite
IPv6 multicast addresses (max 4):
        ff02::1
        ff02::1:ffac:b33
        ff02::1:ff00:1
IPv6 prefixes (max 2):
        <none>
IPv6 hop limit           : 64
IPv6 base reachable time : 30000
IPv6 reachable time      : 44038
IPv6 retransmit timer    : 0

Interface 0x20024f08 (Ethernet) [3]
===================================
Link addr : 02:80:E1:FB:E7:4E
MTU       : 1500
VLAN tag  : 200 (0xc8)
Ethernet capabilities supported:
        Virtual LAN
        10 Mbits
        100 Mbits
IPv6 unicast addresses (max 3):
        fe80::5d68:e3ff:fe9e:28fb autoconf preferred infinite
        2001:db8:200::1 manual preferred infinite
IPv6 multicast addresses (max 4):
        ff02::1
        ff02::1:ff9e:28fb
        ff02::1:ff00:1
IPv6 prefixes (max 2):
        <none>
IPv6 hop limit           : 64
IPv6 base reachable time : 30000
IPv6 reachable time      : 23901
IPv6 retransmit timer    : 0

Client-side setup: similar to what you did. bash zeth-vlan.conf enp4s0

$ ip -6 addr

2: enp4s0: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 state UP qlen 1000
    inet6 2001:db8::2/128 scope global nodad
       valid_lft forever preferred_lft forever
    inet6 fe80::200:5eff:fe00:53ff/64 scope link
       valid_lft forever preferred_lft forever
4: vlan.100@enp4s0: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 state UP qlen 1000
    inet6 2001:db8:100::2/128 scope global
       valid_lft forever preferred_lft forever
    inet6 fe80::200:5eff:fe00:53ff/64 scope link
       valid_lft forever preferred_lft forever
5: vlan.200@enp4s0: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 state UP qlen 1000
    inet6 2001:db8:200::2/128 scope global
       valid_lft forever preferred_lft forever
    inet6 fe80::200:5eff:fe00:53ff/64 scope link
       valid_lft forever preferred_lft forever

$ ip -6 route

2001:db8::2 dev enp4s0 proto kernel metric 256 pref medium
2001:db8::/64 dev enp4s0 metric 1024 pref medium
2001:db8:100::2 dev vlan.100 proto kernel metric 256 pref medium
2001:db8:100::/64 dev vlan.100 metric 1024 pref medium
2001:db8:200::2 dev vlan.200 proto kernel metric 256 pref medium
2001:db8:200::/64 dev vlan.200 metric 1024 pref medium
fe80::/64 dev enp4s0 proto kernel metric 256 pref medium
fe80::/64 dev vlan.100 proto kernel metric 256 pref medium
fe80::/64 dev vlan.200 proto kernel metric 256 pref medium

Test network connection (udptest.py is a copy of net-tools/tcptest.py for udp)

$ ping -6 2001:db8::1 -I enp4s0
PING 2001:db8::1(2001:db8::1) von 2001:db8::2 enp4s0: 56 data bytes
64 Bytes von 2001:db8::1: icmp_seq=1 ttl=64 Zeit=0.331 ms
64 Bytes von 2001:db8::1: icmp_seq=2 ttl=64 Zeit=0.489 ms
64 Bytes von 2001:db8::1: icmp_seq=3 ttl=64 Zeit=0.405 ms
64 Bytes von 2001:db8::1: icmp_seq=4 ttl=64 Zeit=0.491 ms
...

$ ping -6 2001:db8:100::1 -I vlan.100
PING 2001:db8:100::1(2001:db8:100::1) von 2001:db8:100::2 vlan.100: 56 data bytes
64 Bytes von 2001:db8:100::1: icmp_seq=2 ttl=64 Zeit=0.860 ms
64 Bytes von 2001:db8:100::1: icmp_seq=3 ttl=64 Zeit=0.404 ms
64 Bytes von 2001:db8:100::1: icmp_seq=4 ttl=64 Zeit=0.474 ms
64 Bytes von 2001:db8:100::1: icmp_seq=5 ttl=64 Zeit=0.474 ms

$ ping -6 2001:db8:200::1 -I vlan.200
PING 2001:db8:200::1(2001:db8:200::1) von 2001:db8:200::2 vlan.200: 56 data bytes
64 Bytes von 2001:db8:200::1: icmp_seq=1 ttl=64 Zeit=1021 ms
64 Bytes von 2001:db8:200::1: icmp_seq=2 ttl=64 Zeit=1.22 ms
64 Bytes von 2001:db8:200::1: icmp_seq=3 ttl=64 Zeit=0.496 ms
64 Bytes von 2001:db8:200::1: icmp_seq=4 ttl=64 Zeit=0.497 ms

$ python udptest.py enp4s0 2001:db8::1
Thu Dec  3 10:42:00 2020: Connecting to [2001:db8::1]:4242 (through interface enp4s0, scope_id 2)
Thu Dec  3 10:42:00 2020: Connection established. Will begin sending data
Thu Dec  3 10:42:01 2020: Will try sending 0 and read it back
Thu Dec  3 10:42:01 2020: Got 0 back in 0.000597 seconds
Thu Dec  3 10:42:02 2020: Will try sending 10 and read it back
...
Thu Dec  3 10:42:05 2020: Will try sending 100 and read it back
Thu Dec  3 10:42:05 2020: Got 100 back in 0.000742 seconds
Thu Dec  3 10:42:05 2020: Roundtrip takes 0.000691 seconds on average
Thu Dec  3 10:42:05 2020: So far, so good: no timeouts or errors

$ python udptest.py vlan.100 2001:db8:100::1
Thu Dec  3 10:45:19 2020: Connecting to [2001:db8:100::1]:4242 (through interface vlan.100, scope_id 4)
Thu Dec  3 10:45:19 2020: Connection established. Will begin sending data
Thu Dec  3 10:45:20 2020: Will try sending 0 and read it back
Thu Dec  3 10:45:20 2020: Got 0 back in 0.000806 seconds
Thu Dec  3 10:45:20 2020: Will try sending 10 and read it back
...
Thu Dec  3 10:45:25 2020: Will try sending 100 and read it back
Thu Dec  3 10:45:25 2020: Got 100 back in 0.000587 seconds
Thu Dec  3 10:45:25 2020: Roundtrip takes 0.000729 seconds on average
Thu Dec  3 10:45:25 2020: So far, so good: no timeouts or errors

$ python udptest.py vlan.200 2001:db8:200::1
Thu Dec  3 10:46:31 2020: Connecting to [2001:db8:200::1]:4242 (through interface vlan.200, scope_id 5)
Thu Dec  3 10:46:31 2020: Connection established. Will begin sending data
Thu Dec  3 10:46:31 2020: Will try sending 0 and read it back
Thu Dec  3 10:46:31 2020: Got 0 back in 0.000588 seconds
Thu Dec  3 10:46:32 2020: Will try sending 10 and read it back
...
Thu Dec  3 10:46:36 2020: Will try sending 100 and read it back
Thu Dec  3 10:46:36 2020: Got 100 back in 0.000736 seconds
Thu Dec  3 10:46:36 2020: Roundtrip takes 0.000781 seconds on average
Thu Dec  3 10:46:36 2020: So far, so good: no timeouts or errors

discover problem
Open 3 terminals and let all of them ping the different interfaces in parallel.

$ ping -6 2001:db8::1 -I enp4s0
$ ping -6 2001:db8:100::1 -I vlan.100
$ ping -6 2001:db8:200::1 -I vlan.200

The first terminal that does not ping a vlan works consistently all the time. The other two have big gaps and from time to time completely stop working.
64 Bytes von 2001:db8:200::1: icmp_seq=52 ttl=64 Zeit=0.420 ms
64 Bytes von 2001:db8:200::1: icmp_seq=53 ttl=64 Zeit=0.410 ms
64 Bytes von 2001:db8:200::1: icmp_seq=99 ttl=64 Zeit=0.792 ms
64 Bytes von 2001:db8:200::1: icmp_seq=100 ttl=64 Zeit=0.679 ms
64 Bytes von 2001:db8:200::1: icmp_seq=101 ttl=64 Zeit=0.477 ms

Note the icmp_seq gap.
Also, zephyr reports a lot of dropped packets for the vlan interfaces.
uart:~$ net stats

Interface 0x20024e18 (Ethernet) [1]
===================================
IPv6 recv      145      sent    152     drop    1       forwarded       0
IPv6 ND recv   16       sent    29      drop    0
IPv6 MLD recv  0        sent    3       drop    0
IP vhlerr      0        hblener 0       lblener 0
IP fragerr     0        chkerr  0       protoer 0
UDP recv       0        sent    0       drop    0
UDP chkerr     0
Bytes received 16986
Bytes sent     17156
Processing err 3

Interface 0x20024e90 (Ethernet) [2]
===================================
IPv6 recv      166      sent    55      drop    124     forwarded       0
IPv6 ND recv   129      sent    16      drop    124
IPv6 MLD recv  0        sent    3       drop    0
IP vhlerr      0        hblener 0       lblener 0
IP fragerr     0        chkerr  0       protoer 0
UDP recv       0        sent    0       drop    0
UDP chkerr     0
Bytes received 16468
Bytes sent     5986
Processing err 2

Interface 0x20024f08 (Ethernet) [3]
===================================
IPv6 recv      128      sent    115     drop    41      forwarded       0
IPv6 ND recv   42       sent    28      drop    40
IPv6 MLD recv  0        sent    3       drop    0
IP vhlerr      0        hblener 0       lblener 0
IP fragerr     0        chkerr  0       protoer 0
UDP recv       0        sent    0       drop    0
UDP chkerr     0
Bytes received 14264
Bytes sent     10296
Processing err 0

Enable debug output and repeat 7. to reproduce the Iface <iface1> should be <iface2> debug output line on the serial console.

Retried this with the same nucleo board.
cd samples/net/sockets/echo_server
cmake -Bbuild . -DBOARD=nucleo_f767zi -DOVERLAY_CONFIG=overlay-vlan.conf
make -C build flash

Setting up the interfaces:
cd net-tools
sudo bash zeth-vlan.conf enp0s20u2u4u2

pings work ok
$ ping <IP_ADDRESS>
PING <IP_ADDRESS> (<IP_ADDRESS>) 56(84) bytes of data.
64 bytes from <IP_ADDRESS>: icmp_seq=1 ttl=64 time=0.585 ms
64 bytes from <IP_ADDRESS>: icmp_seq=2 ttl=64 time=0.339 ms
^C
--- <IP_ADDRESS> ping statistics ---
2 packets transmitted, 2 received, 0% packet loss, time 1031ms
rtt min/avg/max/mdev = 0.339/0.462/0.585/0.123 ms
$ ping 2001:db8::1
PING 2001:db8::1(2001:db8::1) 56 data bytes
64 bytes from 2001:db8::1: icmp_seq=1 ttl=64 time=0.791 ms
64 bytes from 2001:db8::1: icmp_seq=2 ttl=64 time=0.423 ms
^C
--- 2001:db8::1 ping statistics ---
2 packets transmitted, 2 received, 0% packet loss, time 1059ms
rtt min/avg/max/mdev = 0.423/0.607/0.791/0.184 ms
$ ping 2001:db8:100::1
PING 2001:db8:100::1(2001:db8:100::1) 56 data bytes
64 bytes from 2001:db8:100::1: icmp_seq=1 ttl=64 time=0.965 ms
64 bytes from 2001:db8:100::1: icmp_seq=2 ttl=64 time=0.371 ms
^C
--- 2001:db8:100::1 ping statistics ---
2 packets transmitted, 2 received, 0% packet loss, time 1001ms
rtt min/avg/max/mdev = 0.371/0.668/0.965/0.297 ms
$ ping 2001:db8:200::1
PING 2001:db8:200::1(2001:db8:200::1) 56 data bytes
64 bytes from 2001:db8:200::1: icmp_seq=1 ttl=64 time=1060 ms
64 bytes from 2001:db8:200::1: icmp_seq=2 ttl=64 time=1.19 ms
64 bytes from 2001:db8:200::1: icmp_seq=3 ttl=64 time=0.363 ms
^C
--- 2001:db8:200::1 ping statistics ---
3 packets transmitted, 3 received, 0% packet loss, time 2060ms
rtt min/avg/max/mdev = 0.363/353.826/1059.926/499.288 ms, pipe 2
$ ./echo-client 2001:db8::1
.......
Average round trip 648 us
Sent 7 packets

Then some UDP traffic
$ ./echo-client 2001:db8:100::1
.......
Average round trip 657 us
Sent 7 packets
$ ./echo-client 2001:db8:200::1
.......
Average round trip 697 us
Sent 7 packets
$ ./echo-client <IP_ADDRESS>
.......
Average round trip 650 us
Sent 7 packets
$ ./echo-client <IP_ADDRESS>
.......
Average round trip 592 us
Sent 7 packets

I had some issues with my firewall settings, so I disabled firewall for the vlan.100, vlan.200 and the main interface.

Interesting. Just to confirm: you ran the pings/UDP traffic in parallel I assume?
The issue does not necessarily happen immediately. Maybe you can run the described test setup for a longer period of time, e.g. 10 minutes.
Also: what connections are shown in the statistics and why is there a large amount of dropped packets?

Hi @rtzu6 sorry for very late reply. This issue was just lost to a sea of other issues. I tried this again, and noticed one issue in the echo-server sample application for IPv4 connections. The sample app did not set the netmask of the VLAN network interfaces, which then meant that the network packet could be sent to wrong virtual interface. For example, I was pinging <IP_ADDRESS> from zephyr, the packet should go to third interface but the second interface (src address <IP_ADDRESS>) was selected instead. This could lead to packets to be dropped unexpectedly or some other connection failures. I have a fix for the echo-server sample at #32163.

Thanks for looking into this and for the fix. Does this also affect IPv6? I am testing with IPv6 and it had the same issues, but as far as I can tell this is not affected by your modification.

Does this also affect IPv6?

No, my fix was only for IPv4.
I tried again with nucleo_f767zi with echo-server sample (without any modifications) and with this config
cmake . -Bbuild -DBOARD=nucleo_f767zi -DCONFIG_LOG_BUFFER_SIZE=65536 -DCONFIG_LOG_STRDUP_BUF_COUNT=400 -DCONFIG_NET_DEBUG_NET_PKT_ALLOC=y -DCONFIG_NET_BUF_POOL_USAGE=y DCONFIG_NET_PKT_RX_COUNT=100 -DCONFIG_NET_PKT_TX_COUNT=100 -DCONFIG_NET_BUF_RX_COUNT=640 -DCONFIG_NET_BUF_TX_COUNT=640 -DOVERLAY_CONFIG=overlay-vlan.conf

In Linux side, I had 6 terminals running with these commands
ping 2001:db8::1
ping 2001:db8:100::1
ping 2001:db8:200::1

and
./echo-client -e -r 2001:db8::1
./echo-client -e -r 2001:db8:100::1
./echo-client -e -r 2001:db8:200::1

Zephyr net-shell becomes unresponsive with this load but I did not see excessive dropped packets. This load is too much for this board.
Also it helps if one disables the output from echo-server using this command
log disable net_echo_server_sample

Please note that if you have multiple terminals sending data to echo-server, you need to increase the amount of net_pkt and net_buf used. So these options CONFIG_NET_PKT_RX_COUNT, CONFIG_NET_PKT_TX_COUNT, CONFIG_NET_BUF_RX_COUNT and CONFIG_NET_BUF_TX_COUNT need to be increased from the default values.

Interesting. I modified the config to your recommendations
CONFIG_LOG_BUFFER_SIZE=65536
CONFIG_LOG_STRDUP_BUF_COUNT=400
CONFIG_NET_DEBUG_NET_PKT_ALLOC=y
CONFIG_NET_BUF_POOL_USAGE=y
CONFIG_NET_PKT_RX_COUNT=100
CONFIG_NET_PKT_TX_COUNT=100
CONFIG_NET_BUF_RX_COUNT=640
CONFIG_NET_BUF_TX_COUNT=640

but I still have the same problem. Also, the shell it not unresponsive for me and I still have the high number of dropped packets.
Interface 0x20022684 (Ethernet) [1]
===================================
IPv6 recv      64       sent    71      drop    1       forwarded       0
IPv6 ND recv   7        sent    16      drop    0
IPv6 MLD recv  0        sent    3       drop    0
IP vhlerr      0        hblener 0       lblener 0
IP fragerr     0        chkerr  0       protoer 0
UDP recv       0        sent    0       drop    0
UDP chkerr     0
TCP bytes recv 0        sent    0       resent  0
TCP seg recv   0        sent    0       drop    0
TCP seg resent 0        chkerr  0       ackerr  0
TCP seg rsterr 0        rst     0
TCP conn drop  0        connrst 0
TCP pkt drop   0
Bytes received 7320
Bytes sent     7886
Processing err 0

Interface 0x20022734 (Ethernet) [2]
===================================
IPv6 recv      63       sent    16      drop    54      forwarded       0
IPv6 ND recv   56       sent    9       drop    53
IPv6 MLD recv  0        sent    3       drop    0
IP vhlerr      0        hblener 0       lblener 0
IP fragerr     0        chkerr  0       protoer 0
UDP recv       0        sent    0       drop    0
UDP chkerr     0
TCP bytes recv 0        sent    0       resent  0
TCP seg recv   0        sent    0       drop    0
TCP seg resent 0        chkerr  0       ackerr  0
TCP seg rsterr 0        rst     0
TCP conn drop  0        connrst 0
TCP pkt drop   0
Bytes received 5886
Bytes sent     1664
Processing err 0

Interface 0x200227e4 (Ethernet) [3]
===================================
IPv6 recv      55       sent    33      drop    27      forwarded       0
IPv6 ND recv   24       sent    2       drop    24
IPv6 MLD recv  0        sent    3       drop    0
IP vhlerr      0        hblener 0       lblener 0
IP fragerr     0        chkerr  0       protoer 0
UDP recv       0        sent    0       drop    0
UDP chkerr     0
TCP bytes recv 0        sent    0       resent  0
TCP seg recv   0        sent    0       drop    0
TCP seg resent 0        chkerr  0       ackerr  0
TCP seg rsterr 0        rst     0
TCP conn drop  0        connrst 0
TCP pkt drop   0
Bytes received 5838
Bytes sent     3898
Processing err 0

Would you mind sharing you autoconf.h just to confirm that we have the same config?

Would you mind sharing you autoconf.h just to confirm that we have the same config?

Sure, although if using same Kconfig options, board and same revision, we should end up with identical compilation.
I am at commit 8f8cdc18c4a7af5b833bc3e5b630bbe527a942b7 in master
autoconf.h.gz

Strange.
I also tried a complete rebuild, zephyr is at commit 1ff7a843.
Scenario 1:
I built the echo_server example via west without touching anything code-wise. Autoconf: autoconf_west.h.gz
A bit different. This results in the same error as always: pinging two different vlan interfaces in parallel as described above does not work.
Scenario 2:
I built the echo_server example with the exact cmake command from above:
cmake . -Bbuild -DBOARD=nucleo_f767zi -DCONFIG_LOG_BUFFER_SIZE=65536 -DCONFIG_LOG_STRDUP_BUF_COUNT=400 -DCONFIG_NET_DEBUG_NET_PKT_ALLOC=y -DCONFIG_NET_BUF_POOL_USAGE=y -DCONFIG_NET_PKT_RX_COUNT=100 -DCONFIG_NET_PKT_TX_COUNT=100 -DCONFIG_NET_BUF_RX_COUNT=640 -DCONFIG_NET_BUF_TX_COUNT=640 -DOVERLAY_CONFIG=overlay-vlan.conf
Autoconf: autoconf_cmake.h.gz
Diff:
35d34
< #define CONFIG_ZEPHYR_TRUSTED_FIRMWARE_M_MODULE 1
463d461
< #define CONFIG_SRAM_OFFSET 0x0

Same issue: the pings dont work reliably after a certain amount of time.
Scenario 3:
I used the same setup as in Scenario 2 and waited until at least one got "stuck". Then I sent data via the echo client:
./echo-client -e -r 2001:db8::1
./echo-client -e -r 2001:db8:100::1
./echo-client -e -r 2001:db8:200::1

(Every command in a different terminal). The interface that got "stuck" with the ping also did not get a response from the server.
Scenario 4:
Same setup as in Scenario 3, but I sent the data via the echo client at a point in time where all three pings worked (they work only for a few seconds in parallel, but I started the clients in this timeframe). This resulted in the scenario that you described: all three clients get a response albeit a bit slow (the board is under heavy load, as you said). The pings continue to work, at least for some amount of time (after around 5 minutes, one echo-client did not get responses anymore and the ping stopped working. I don't know if this always happens).
How do these scenarios behave for you?

Perhaps this is not related to anything you are seeing, but I noticed that if we have multiple network interfaces, then the network packet might be sent to wrong network interface (always to first interface even if it was meant to be sent to second or third one) in some rare cases.
This issue should be fixed in #32783


✨ AP Control Panel API access

Describe the feature request.
To be able to read and update parts of the control panel programatically
Describe the context.
The gold-scorecard-form app has two layers of authentication, the first is through adding customers via the control panel. The second is adding each customer to an individual scorecard which is done through the app itself. Customers are added to each scorecard by other customers and often we're not made aware of them being added/removed. I'd like to reconcile the list of all customers who have access to a scorecard within the app with the list of customers on the control panel.
Value / Purpose
By having this access, I'll be able to pre-emptively and automatically add customers when they've been added as contributors within the app. This will prevent them from emailing us asking to be given access to the scorecard and it will enable us to remove customers when they no longer contribute to any scorecard. It will cut down on our time maintaining the app and it'll make the process more of a smooth experience for the user.
User Types
App maintainers, commercial stakeholders

Presented at Feature Request formum on 7/10
Forum outcome: To be taken to refinement for discussion with team.  May have implications for 5533 which will also be refined.


Have documentation for DockerHub images

The website should have some sentences somewhere that highlight that official Temurin Docker images are available at https://hub.docker.com/_/eclipse-temurin?tab=description

Does the Container Images bullet not cover this at https://adoptium.net/installation?

Yes it does, thanks.


Dead link in demo when creating a new project

Expected behavior
When I create a new project from scratch and start it, the link to code examples works as expected.
Actual Behavior
I get a 404.
Additional context
I only used npm init @open-wc and create a new project using the generator. I opened the generator and ran npm start.
The project opens on this :

When clicking the code examples link, I get a 404.
See

The link should probably be https://open-wc.org/guides/developing-components/code-examples/

The link should probably be https://open-wc.org/guides/developing-components/code-examples/

I think the issue is actually located in the create project. See https://github.com/open-wc/create/search?q=developing%2F%23code-examples

I think the issue is actually located in the create project. See https://github.com/open-wc/create/search?q=developing%2F%23code-examples

I think the issue is actually located in the create project. See https://github.com/open-wc/create/search?q=developing%2F%23code-examples

I think the issue is actually located in the create project. See https://github.com/open-wc/create/search?q=developing%2F%23code-examples

Proposed a change here : https://github.com/jlengrand/create/pull/1

Proposed a change here : https://github.com/jlengrand/create/pull/1


llm.with_structured_output(RouteQuery) fails running AdaptiveRAG Example with AzureOpenAI

Checked other resources

[X] I added a very descriptive title to this issue.
[X] I searched the LangChain documentation with the integrated search.
[X] I used the GitHub search to find a similar question and didn't find it.
[X] I am sure that this is a bug in LangChain rather than my code.

Example Code
from langchain_openai import AzureChatOpenAI
from langchain_openai import AzureOpenAIEmbeddings
from langchain.text_splitter import RecursiveCharacterTextSplitter
from langchain_community.document_loaders import WebBaseLoader
from langchain_community.vectorstores import Chroma
from typing import Literal
from langchain_core.prompts import ChatPromptTemplate
from langchain_core.pydantic_v1 import BaseModel, Field
from langchain import hub
from langchain_core.output_parsers import StrOutputParser
from langchain_community.tools.tavily_search import TavilySearchResults
Docs to index
urls = [
"https://lilianweng.github.io/posts/2023-06-23-agent/",
"https://lilianweng.github.io/posts/2023-03-15-prompt-engineering/",
"https://lilianweng.github.io/posts/2023-10-25-adv-attack-llm/",
]
Load
docs = [WebBaseLoader(url).load() for url in urls]
docs_list = [item for sublist in docs for item in sublist]
Split
text_splitter = RecursiveCharacterTextSplitter.from_tiktoken_encoder(
chunk_size=500, chunk_overlap=0
)
doc_splits = text_splitter.split_documents(docs_list)
Add to vectorstore
vectorstore = Chroma.from_documents(
documents=doc_splits,
collection_name="rag-chroma",
embedding=embeddings,
)
retriever = vectorstore.as_retriever()
Data model
class RouteQuery(BaseModel):
"""Route a user query to the most relevant datasource."""
datasource: Literal["vectorstore", "web_search"] = Field(
    ...,
    description="Given a user question choose to route it to web search or a vectorstore.",
)

LLM with function call
llm = AzureChatOpenAI(model="gpt-3.5-turbo-0125", temperature=0)
structured_llm_router = llm.with_structured_output(RouteQuery)
Prompt
system = """You are an expert at routing a user question to a vectorstore or web search.
The vectorstore contains documents related to agents, prompt engineering, and adversarial attacks.
Use the vectorstore for questions on these topics. Otherwise, use web-search."""
route_prompt = ChatPromptTemplate.from_messages(
[
("system", system),
("human", "{question}"),
]
)
question_router = route_prompt | structured_llm_router
print(question_router.invoke({"question": "Who will the Bears draft first in the NFL draft?"}))
print(question_router.invoke({"question": "What are the types of agent memory?"}))
Error Message and Stack Trace (if applicable)
C:\Users\prakotian\AppData\Local\miniconda3\envs\Py10\lib\site-packages\langchain_core_api\beta_decorator.py:87: LangChainBetaWarning: The function with_structured_output is in beta. It is actively being worked on, so the API may change.
warn_beta(
---ROUTE QUESTION---
Traceback (most recent call last):
File "C:\Users\prakotian\Desktop\Projects\GenAI Projects\AdaptiveRAG\app.py", line 255, in
for output in app.stream(inputs):
File "C:\Users\prakotian\AppData\Local\miniconda3\envs\Py10\lib\site-packages\langgraph\pregel_init_.py", line 686, in stream
panic_or_proceed(done, inflight, step)
File "C:\Users\prakotian\AppData\Local\miniconda3\envs\Py10\lib\site-packages\langgraph\pregel_init.py", line 1049, in _panic_or_proceed
raise exc
File "C:\Users\prakotian\AppData\Local\miniconda3\envs\Py10\lib\concurrent\futures\thread.py", line 58, in run
result = self.fn(*self.args, **self.kwargs)
File "C:\Users\prakotian\AppData\Local\miniconda3\envs\Py10\lib\site-packages\langchain_core\runnables\base.py", line 2499, in invoke
input = step.invoke(
File "C:\Users\prakotian\AppData\Local\miniconda3\envs\Py10\lib\site-packages\langgraph\utils.py", line 49, in invoke
ret = self.func(input, merge_configs(self.config, config), **self.kwargs)
File "C:\Users\prakotian\AppData\Local\miniconda3\envs\Py10\lib\site-packages\langgraph\graph\graph.py", line 67, in _route
result = self.condition.invoke(reader(config) if reader else input, config)
File "C:\Users\prakotian\AppData\Local\miniconda3\envs\Py10\lib\site-packages\langchain_core\runnables\base.py", line 3961, in invoke
return self._call_with_config(
File "C:\Users\prakotian\AppData\Local\miniconda3\envs\Py10\lib\site-packages\langchain_core\runnables\base.py", line 1625, in _call_with_config
context.run(
File "C:\Users\prakotian\AppData\Local\miniconda3\envs\Py10\lib\site-packages\langchain_core\runnables\config.py", line 347, in call_func_with_variable_args
return func(input, **kwargs)  # type: ignore[call-arg]
File "C:\Users\prakotian\AppData\Local\miniconda3\envs\Py10\lib\site-packages\langchain_core\runnables\base.py", line 3835, in _invoke
output = call_func_with_variable_args(
File "C:\Users\prakotian\AppData\Local\miniconda3\envs\Py10\lib\site-packages\langchain_core\runnables\config.py", line 347, in call_func_with_variable_args
return func(input, **kwargs)  # type: ignore[call-arg]
File "C:\Users\prakotian\Desktop\Projects\GenAI Projects\AdaptiveRAG\app.py", line 142, in route_question
source = question_router.invoke({"question": question})
File "C:\Users\prakotian\AppData\Local\miniconda3\envs\Py10\lib\site-packages\langchain_core\runnables\base.py", line 2499, in invoke
input = step.invoke(
File "C:\Users\prakotian\AppData\Local\miniconda3\envs\Py10\lib\site-packages\langchain_core\runnables\base.py", line 4511, in invoke
return self.bound.invoke(
File "C:\Users\prakotian\AppData\Local\miniconda3\envs\Py10\lib\site-packages\langchain_core\language_models\chat_models.py", line 158, in invoke
self.generate_prompt(
File "C:\Users\prakotian\AppData\Local\miniconda3\envs\Py10\lib\site-packages\langchain_core\language_models\chat_models.py", line 560, in generate_prompt
return self.generate(prompt_messages, stop=stop, callbacks=callbacks, **kwargs)
File "C:\Users\prakotian\AppData\Local\miniconda3\envs\Py10\lib\site-packages\langchain_core\language_models\chat_models.py", line 421, in generate
raise e
File "C:\Users\prakotian\AppData\Local\miniconda3\envs\Py10\lib\site-packages\langchain_core\language_models\chat_models.py", line 411, in generate
self._generate_with_cache(
File "C:\Users\prakotian\AppData\Local\miniconda3\envs\Py10\lib\site-packages\langchain_core\language_models\chat_models.py", line 632, in _generate_with_cache
result = self._generate(
File "C:\Users\prakotian\AppData\Local\miniconda3\envs\Py10\lib\site-packages\langchain_openai\chat_models\base.py", line 548, in _generate
response = self.client.create(messages=message_dicts, **params)
File "C:\Users\prakotian\AppData\Local\miniconda3\envs\Py10\lib\site-packages\openai_utils_utils.py", line 275, in wrapper
return func(*args, **kwargs)
File "C:\Users\prakotian\AppData\Local\miniconda3\envs\Py10\lib\site-packages\openai\resources\chat\completions.py", line 667, in create
return self._post(
File "C:\Users\prakotian\AppData\Local\miniconda3\envs\Py10\lib\site-packages\openai_base_client.py", line 1233, in post
return cast(ResponseT, self.request(cast_to, opts, stream=stream, stream_cls=stream_cls))
File "C:\Users\prakotian\AppData\Local\miniconda3\envs\Py10\lib\site-packages\openai_base_client.py", line 922, in request
return self._request(
File "C:\Users\prakotian\AppData\Local\miniconda3\envs\Py10\lib\site-packages\openai_base_client.py", line 1013, in _request
raise self._make_status_error_from_response(err.response) from None
openai.BadRequestError: Error code: 400 - {'error': {'message': "Invalid parameter: 'response_format' of type 'json_object' is not supported with this model.", 'type': 'invalid_request_error', 'param': 'response_format', 'code': None}}
(Py10) C:\Users\prakotian\Desktop\Projects\GenAI Projects\AdaptiveRAG>
(Py10) C:\Users\prakotian\Desktop\Projects\GenAI Projects\AdaptiveRAG>python router.py
C:\Users\prakotian\AppData\Local\miniconda3\envs\Py10\lib\site-packages\langchain_core_api\beta_decorator.py:87: LangChainBetaWarning: The function with_structured_output is in beta. It is actively being worked on, so the API may change.
warn_beta(
Traceback (most recent call last):
File "C:\Users\prakotian\Desktop\Projects\GenAI Projects\AdaptiveRAG\router.py", line 87, in
print(question_router.invoke({"question": "Who will the Bears draft first in the NFL draft?"}))
File "C:\Users\prakotian\AppData\Local\miniconda3\envs\Py10\lib\site-packages\langchain_core\runnables\base.py", line 2499, in invoke
input = step.invoke(
File "C:\Users\prakotian\AppData\Local\miniconda3\envs\Py10\lib\site-packages\langchain_core\output_parsers\base.py", line 169, in invoke
return self._call_with_config(
File "C:\Users\prakotian\AppData\Local\miniconda3\envs\Py10\lib\site-packages\langchain_core\runnables\base.py", line 1625, in _call_with_config
context.run(
File "C:\Users\prakotian\AppData\Local\miniconda3\envs\Py10\lib\site-packages\langchain_core\runnables\config.py", line 347, in call_func_with_variable_args
return func(input, **kwargs)  # type: ignore[call-arg]
File "C:\Users\prakotian\AppData\Local\miniconda3\envs\Py10\lib\site-packages\langchain_core\output_parsers\base.py", line 170, in
lambda inner_input: self.parse_result(
File "C:\Users\prakotian\AppData\Local\miniconda3\envs\Py10\lib\site-packages\langchain_core\output_parsers\openai_tools.py", line 182, in parse_result
json_results = super().parse_result(result, partial=partial)
File "C:\Users\prakotian\AppData\Local\miniconda3\envs\Py10\lib\site-packages\langchain_core\output_parsers\openai_tools.py", line 129, in parse_result
tool_calls = parse_tool_calls(
File "C:\Users\prakotian\AppData\Local\miniconda3\envs\Py10\lib\site-packages\langchain_core\output_parsers\openai_tools.py", line 85, in parse_tool_calls
raise OutputParserException("\n\n".join(exceptions))
langchain_core.exceptions.OutputParserException: Function RouteQuery arguments:
{
datasource: "web_search"
}
are not valid JSON. Received JSONDecodeError Expecting property name enclosed in double quotes: line 2 column 3 (char 4)
Description
Expected Output:-
datasource='web_search'
datasource='vectorstore'
System Info
System Information

OS:  Windows
OS Version:  10.0.19045
Python Version:  3.10.13 | packaged by Anaconda, Inc. | (main, Sep 11 2023, 13:24:38) [MSC v.1916 64 bit (AMD64)]

Package Information

langchain_core: 0.1.43
langchain: 0.1.16
langchain_community: 0.0.33
langsmith: 0.1.31
langchain_cohere: 0.1.2
langchain_experimental: 0.0.54
langchain_openai: 0.1.3
langchain_text_splitters: 0.0.1
langchainhub: 0.1.15
langgraph: 0.0.37

I am getting a very similar error

Yes, I'm also

I am facing a similar issue. Although my LLM with function call slightly differs in client call.
llm = AzureChatOpenAI( openai_api_version=os.environ["AZURE_OPENAI_API_VERSION"],     azure_deployment=os.environ["AZURE_OPENAI_CHAT_DEPLOYMENT_NAME"],     ) structured_llm_grader = llm.with_structured_output(GradeDocuments, method="json_mode")
This gives a similar error. And If I remove json_mode, the following error:
GradeDocuments({binary_score: "no"})
are not valid JSON. Received JSONDecodeError Expecting value: line 1 column 1 (char 0)

I was also having the same issue with using Cohere's command-r-plus. But instead of using .with_structured_output() I changed to `.bindtools()'.
My code:
`
Router
from langchain_core.prompts import ChatPromptTemplate, FewShotChatMessagePromptTemplate
from langchain_core.pydantic_v1 import BaseModel, Field
from langchain_cohere import ChatCohere
Data model
class web_search(BaseModel):
"""
The internet. Use web_search for questions that are related to anything else than agents, prompt engineering, and adversarial attacks.
"""
query: str = Field(description="The query to use when searching the internet.")

class vectorstore(BaseModel):
"""
A vectorstore containing documents related to Graph Neural Networks. Use the vectorstore for questions on these topics.
"""
query: str = Field(description="The query to use when searching the vectorstore.")

LLM with function call
llm = ChatCohere(model="command-r-plus", temperature=0)
structured_llm_router = llm.bind_tools(
tools=[web_search, vectorstore]
)
Few shot prompting
routing_examples = [
{"question": "What are the main components of a Graph Neural Network?", "decision": "vectorstore"},
{"question": "Who won the Nobel Prize in Physics in 2023?", "decision": "web_search"},
{"question": "How do GNNs handle the over-smoothing problem?", "decision": "vectorstore"},
{"question": "What is the capital of Japan?", "decision": "web_search"},
{"question": "Can you explain how Graph Attention Networks (GATs) work?", "decision": "vectorstore"},
]
example_prompt = ChatPromptTemplate.from_messages(
[
("human", "{question}"),
("ai", "{decision}"),
]
)
few_shot_prompt = FewShotChatMessagePromptTemplate(
example_prompt=example_prompt,
examples=routing_examples,
)
Prompt
system = """You are an expert at routing a user question to a vectorstore or web search.
The vectorstore contains documents related to Graph Neural Networks (GNNs).
Use the vectorstore for questions on these topics. Otherwise, use web-search."""
route_prompt = ChatPromptTemplate.from_messages(
[
("system", system),
few_shot_prompt,
("human", "{question}"),
]
)
question_router = route_prompt | structured_llm_router
response = question_router.invoke({"question": "Who won the Nobel Prize in Physics in 2023?"})
print(response.response_metadata["tool_calls"])
response = question_router.invoke({"question": "What are the types of Graph Neural Network?"})
print(response.response_metadata["tool_calls"])
response = question_router.invoke({"question": "Hi how are you?"}) # answers directly
print("tool_calls" in response.response_metadata)
`
Response:
[{'id': '30415ef1fb324ca28ad456109271c5f4', 'function': {'name': 'web_search', 'arguments': '{"query": "Nobel Prize Physics 2023"}'}, 'type': 'function'}]
[{'id': '992dc30308e44e328ad1155606ad6038', 'function': {'name': 'vectorstore', 'arguments': '{"query": "types of graph neural network"}'}, 'type': 'function'}]
False


Nullable enums break strict mode tsc checks.

What are the steps to reproduce this issue?
Have a swagger file with a nullable enum, e.g.
"choices": {
  "enum": [1, 2, 3],
  "type": "integer",
  "nullable": true,

What happens?
The following code is generated:
export const Choices = {
  NUMBER_1: 1,
  NUMBER_2: 2,
  NUMBER_3: 3,
  null: null,
} as const;

With the --noImplicitAny or strict mode on, tsc complains with the following error, as it is unable to infer the type for null for some reason.
error TS7018: Object literal's property 'null' implicitly has an 'any' type.

What were you expecting to happen?
One way to sidestep this would be to type it explicitly, if a bit redundantly:
export const Choices: {
  NUMBER_1: 1;
  NUMBER_2: 2;
  NUMBER_3: 3;
  null: null;
} = {
  NUMBER_1: 1,
  NUMBER_2: 2,
  NUMBER_3: 3,
  null: null,
} as const;

Alternatively, leaving out null as an option of the object and having it as part of the type declaration instead
export const Choices = {
  NUMBER_1: 1,
  NUMBER_2: 2,
  NUMBER_3: 3,
} as const;

...

export type Choices = typeof Choices[keyof typeof Choices] | null;

Any other comments?
I could take a stab at contributing a fix.

Also reported here: https://github.com/anymaniax/orval/issues/981  if you two want to collaborate on a fix.


Update dev example after #113

I don't agree with the changes for moment.js.
By using the already minified version of moment, we reduce the chance of the minifier of vfg to do it's best job. It has to minify normal code with minified code, and I don't claim to know how it work, but I think that's not the best.
Also, we loose the sourcemap of moment.js.


github-backup: 0.42.0 -> 0.43.1

Changelog: https://github.com/josegonzalez/python-github-backup/blob/0.43.1/CHANGES.rst
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 240682 run on x86_64-linux 1

2 packages built:

github-backup
github-backup.dist