LINK-1743 | Accessibility statement page

Description
A new page to display accessibility statement.
Accessibility statement -link to the footer
Closes
LINK-1743
Screenshot

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (dd4516c) 99.73% compared to head (4b8df29) 99.73%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #287   +/-   ##
=======================================
  Coverage   99.73%   99.73%
=======================================
  Files         591      592    +1
  Lines        9756     9765    +9
  Branches     2157     2157
=======================================
+ Hits         9730     9739    +9
  Misses         23       23
  Partials        3        3

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Add driver type to nodePool resources

Issue: https://github.com/rancher/rancher/issues/22080
Types PR: https://github.com/rancher/types/pull/971
Adds a virtual field (not stored in db) to the nodepool resource via formatter that identifies the driver type (string).
Hit /v3/schemas/nodePool to see schema
Hit /v3/nodePool to see resources
Schema

Resource

The change looks fine but this should be split into multiple commits, one for vendor and another for your changes.

lgtm


Sprint6

This week sucked, sqlite3 gave me issues everywhere I turned.

I did very important work. I created html templates. You can call me the next steve wozniak.

This sprint was a difficult one. Sydney had difficulty completing her work due to a large workload outside of Class, and there was a last-minute issue with a push to the master on the reop which overwrote previous work. Thankfully we were able to recover the work done. To fix this we need to be sure to pull the latest commit to the master branch before pushing to master. For next sprint Sydney will need to finish what wasn't completed. I may reassign myself or Andrew to help with one of the two tasks if she needs some help with them.

It was difficult to write css and template code without any data to test with, so I'm not sure if the code even works. Also, I'm never pushing to master again.


Can't get OAuth

I have
import {OAuthErrorEvent, OAuthSuccessEvent} from 'angular-oauth2-oidc/events';

but the events package is not found. Looking in the node_modules/angular-oauth2-oidc there is only a events.d.ts file, and perhaps something is missing. The core package works to my satisfaction.

Some Editors, like VS Code, suggest wrong names sometime. Just use 'angular-oauth2-oidc' instead of 'angular-oauth2-odic/file-name':
import {OAuthErrorEvent, OAuthSuccessEvent} from 'angular-oauth2-oidc;

Wished it was only a editor problem. (I use IntelliJ IDEA)
ERROR in /home/niclas/dev/sensetif/sink/angular2/src/app/components/home/home.component.ts (2,23): Module '"/home/niclas/dev/sensetif/sink/angular2/node_modules/angular-oauth2-oidc/angular-oauth2-oidc"' has no exported member 'OAuthErrorEvent'.
ERROR in /home/niclas/dev/sensetif/sink/angular2/src/app/components/home/home.component.ts (2,40): Module '"/home/niclas/dev/sensetif/sink/angular2/node_modules/angular-oauth2-oidc/angular-oauth2-oidc"' has no exported member 'OAuthSuccessEvent'.

I am adding the content of the node_modules/angular-oauth2-oidc for comparison
niclas@devdesk:~/dev/sensetif/sink/angular2$ find node_modules/angular-oauth2-oidc/
node_modules/angular-oauth2-oidc/
node_modules/angular-oauth2-oidc/events.d.ts
node_modules/angular-oauth2-oidc/auth.config.d.ts
node_modules/angular-oauth2-oidc/index.d.ts
node_modules/angular-oauth2-oidc/base64-helper.d.ts
node_modules/angular-oauth2-oidc/angular-oauth2-oidc.d.ts
node_modules/angular-oauth2-oidc/angular-oauth2-oidc.umd.js
node_modules/angular-oauth2-oidc/package.json
node_modules/angular-oauth2-oidc/token-validation
node_modules/angular-oauth2-oidc/token-validation/jwks-validation-handler.d.ts
node_modules/angular-oauth2-oidc/token-validation/null-validation-handler.d.ts
node_modules/angular-oauth2-oidc/token-validation/validation-handler.d.ts
node_modules/angular-oauth2-oidc/angular-oauth2-oidc.metadata.json
node_modules/angular-oauth2-oidc/tokens.d.ts
node_modules/angular-oauth2-oidc/README.MD
node_modules/angular-oauth2-oidc/url-helper.service.d.ts
node_modules/angular-oauth2-oidc/oauth-service.d.ts
node_modules/angular-oauth2-oidc/index.js
node_modules/angular-oauth2-oidc/types.d.ts

And when declaring
import {OAuthErrorEvent, OAuthSuccessEvent} from 'angular-oauth2-oidc/events';

both IDEA and the compiler are happy, but can't be found in runtime.

@niclash have you found a solution for this?
@manfredsteyer I noticed that the angular-oauth2-oidc.metadata.json file in the package folder does not have a reference to the events. For example the AuthConfig is mentioned in the file ... perhaps this could be part of the cause of the issue?

Oh, I see it now. Will be fixed in the next version (lands in a few days). Thanks for pointing this out.


Codegen - fix tests

Fixes on top of #280

rebased on dependent PR

I've changed the PR base for easier review

thank you for the review! regarding bloop exit, we need more work on the mass-generation of the package anyway, so in a followup I'll try to further optimize this problem


networkmanager: add information from wiki to docs

Motivation for this change
move the wiki!
Things done

[x] Fits CONTRIBUTING.md.

Specifically:

mention nmcli, nmtui
mention gtk and kde applets

fixes #13273

With this patch, the manual fails to validate. I've not yet looked into why.

Fixed! Thanks for the tips, all!


Industrial craft compatibility

Hi there,
Did you though about making your engines using ic2 (or alike) energy ?
Could be quite fun to have a movable version of the warpdrive mod !
While talking about that, you are currently using floating blocks to make a structure fly, would it be a lot of work to have an other block act like plan wings (getting lifting force depending on speed) ?

We might make it accept power from other mods eventually, but currently both me and Big are busy with other projects and irl things.  And before adding such a feature, we'd need to make it work better by itself first :P

Seem quite logic indeed ^^
And does the wing stuff could someday be in your backlog ?


Running snapshot testing in the Jenkins pipeline fails

Hey,
I am trying to run Roborazzi snapshots in the pipeline which is configured on Jenkins. However, I am facing a few issues (or maybe this is something I misunderstood in the setup process and you will be able to guide me). There are two issues that I want to stress, which might be related:
Prerequisites:

I am running the 1.2.0 version
Have baseline stored in the project
I am using the most simple Roborazzi Rule setup. RoborazziRule(onView(isRoot()))

Running verifyRoborazziDebug task in Jenkins.
No matter what path I will declare in the captureRoboImage(path) for the snapshot using, it will always fail. However, this doesn't apply to the local gradle task run. I have a test that should be using a custom path to record and verify the snapshot state. It works locally, but in Jenkins, I always get this:

<...>MyTest > example1 FAILED
    java.lang.AssertionError: Roborazzi: /var/lib/jenkins/workspace/<...>/build/outputs/roborazzi/example1_compare.png is added.
    See compare image at /var/lib/jenkins/workspace/<...>/build/outputs/roborazzi/example1_compare.png
        at com.github.takahirom.roborazzi.RoborazziOptions$RoborazziCompareReporter$VerifyRoborazziCompareReporter.report(capture.kt:349)
        at com.github.takahirom.roborazzi.RoborazziKt.processOutputImageAndReport(Roborazzi.kt:666)
        at com.github.takahirom.roborazzi.RoborazziKt.saveLastImage(Roborazzi.kt:472)
        at com.github.takahirom.roborazzi.RoborazziKt.access$saveLastImage(Roborazzi.kt:1)
        at com.github.takahirom.roborazzi.RoborazziKt$captureAndroidView$3.invoke(Roborazzi.kt:432)
        at com.github.takahirom.roborazzi.RoborazziKt$captureAndroidView$3.invoke(Roborazzi.kt:431)
        at com.github.takahirom.roborazzi.RoborazziRule$apply$1.evaluate(RoborazziRule.kt:133)
        at org.junit.rules.TestWatcher$1.evaluate(TestWatcher.java:61)
        at org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:54)
        at org.junit.rules.TestWatcher$1.evaluate(TestWatcher.java:61)
        at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
        at org.robolectric.RobolectricTestRunner$HelperTestRunner$1.evaluate(RobolectricTestRunner.java:589)
        at org.robolectric.internal.SandboxTestRunner$2.lambda$evaluate$2(SandboxTestRunner.java:290)
        at org.robolectric.internal.bytecode.Sandbox.lambda$runOnMainThread$0(Sandbox.java:99)
        at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
        at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
        at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
        at java.base/java.lang.Thread.run(Thread.java:829)

It wasn't working by setting outputDirectoryPath too. By the stacktrace it is clear that Roborazzi is using the DEFAULT_ROBORAZZI_OUTPUT_DIR_PATH for the snapshot verification.
A bit more context:
I have tried to force the snapshot to fail (with an outdated baseline) I got the *_compare.png generated in the path I declared in the captureRoboImage(path) method. So the outcome was as expected but logs were stating a different path to the *_capture.png image. When I update the baseline for the test to succeed, it had no *_compare.png image under the declared path. However, it still got me the top error.
The only way to run the task is by adding the flag to the gradle command ./gradlew verifyRoborazzi --rerun-tasks.

Running any Roborazzi task in Jenkins.
It doesn't work properly, since it always gets the Skipped even tho each time I change the test count or snapshotted view content or test steps/content. As I was investigating why that happens I made a conclusion, that if Gradle consistently marks tasks as up-to-date even though they aren't, it suggests that the tasks' inputs or outputs may not be configured correctly. Roborazzi needs to ensure that any files tasks rely on are properly declared as inputs, and any files or directories tasks generate are declared as outputs.
It might be related to the first issue.

Skipping task ':testDebugUnitTest' as it is up-to-date.
Resolve mutations for :verifyRoborazziDebug (Thread[included builds,5,main]) started.
:verifyRoborazziDebug (Thread[included builds,5,main]) started.

> Task :verifyRoborazziDebug UP-TO-DATE
Skipping task ':verifyRoborazziDebug' as it has no actions.

p.s. if you will try to set up a Jenkins pipeline to test, don't forget to append to the start of the path variable the working directory path System.getProperty("user.dir"). This cost me some time to figure this out.
Thanks for the great library and for the support!

Thank you for reaching out with your issues. I have a couple of suggestions that may help resolve your problems:

If you're using captureRoboImage(), there's no need to declare RoborazziRule. Could you try removing RoborazziRule and see if the problem persists?

The error message suggests that the file /var/lib/jenkins/workspace/<...>/build/outputs/roborazzi/example1_compare.png is being added. Could you please verify if the file /var/lib/jenkins/workspace/<...>/build/outputs/roborazzi/example1.png actually exists in your Jenkins workspace?

I hope these suggestions help. Please let me know if the issues continue. I'm here to help.

Thanks for the quick answer!
Removing RoborazziRule solved the first issue. As you mentioned, it seems that rule was adding an additional layer of capturing. So /var/lib/jenkins/workspace/<...>/build/outputs/roborazzi/example1_compare.png is not an issue anymore.
However, the task is still always skipped without the --rerun-tasks flag.

Thanks, I have updated the issue title. 👍
How about both restoring baseline images and restoring the cache? That way, we might be able to skip the task.

Played with both, but was no success.

@galisamas
I would like to ask a few questions to better understand the issue.

Expected Behavior: Could you please describe what you anticipated would happen?
Actual Outcome: What was the actual result? Please provide any error messages or logs if possible.
Procedure: Could you explain the process in more detail? For instance, when you encountered the skipped task, had the test or source code been changed? (This will help me determine whether the task being skipped is normal behavior.)

These questions will give me a clearer picture of your situation and assist in troubleshooting your issue.

I have a recorded baseline in the project scope. Running the verifyRoborazziDebug task should revalidate the snapshots. Especially when any of the tests or testing code changes. So I would expect the verifyRoborazziDebug task to run and e.g. fail after the test is changed that snapshot would look differently.
No matter what is changed in the tests or testing code scope, the verifyRoborazziDebug task is always marked as skipped (see initial message's 2nd code snippet).
I try to change one of the screens by commenting on half of its visible views. With the correct baseline, I am running the verifyRoborazziDebug task in the Jenkins pipeline. Everything passes, since the : verifyRoborazziDebug is skipped due to no actions.

Thank you. I understand the issue you're experiencing. I attempted to replicate it, but was unable to reproduce the skipped test task. Could you possibly provide any steps to reproduce the problem?
 ./gradlew app:verifyRoborazziDebug  --info
# change some tests
 ./gradlew app:verifyRoborazziDebug  --info

And If this issue occurs only in your Jenkins environment, could you please try running testDebugUnitTest to check if the task gets skipped and whether it's a problem related to Roborazzi?

Sorry for not getting back to you sooner, was off. I have a stage in the current pipeline structure that probably affects it. It builds the app and runs all tests. So when the other stage with the roborazzi or testDebugUnitTest is run, nothing is changed in the code and it skips the task. Briefly, testDebugUnitTest is skipped as well. So these might be the steps to reproduce it ./gradlew clean build check

@galisamas
I have created some failing tests and fixed them. Can you verify if this was your intention?

Yes, it was 🙇 Thanks for your great support!


[Web] Expanded(Text) in Dialog Box is shown as grey

Hi,
I have experienced an issue where I get a grey box in Web Release mode only on 2.6.0-12.0.pre.535, when I add an Expanded widget in a Dialog box.
Release mode:

Debug mode:

minimal code sample
import 'dart:math';
import 'package:flutter/material.dart';

void main() {
  runApp(const MyApp());
}

class MyApp extends StatelessWidget {
  const MyApp({Key? key}) : super(key: key);

  // This widget is the root of your application.
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'Flutter Demo',
      theme: ThemeData(
        primarySwatch: Colors.blue,
      ),
      home: const MyHomePage(),
    );
  }
}

class MyHomePage extends StatefulWidget {
  const MyHomePage({Key? key}) : super(key: key);

  @override
  State<MyHomePage> createState() => _MyHomePageState();
}

class _MyHomePageState extends State<MyHomePage> {
  @override
  Widget build(BuildContext context) {
    return Scaffold(
      floatingActionButton: FloatingActionButton(
        onPressed: () async {
          await Dialog1(context);
        },
        tooltip: 'Show',
        child: const Icon(Icons.add),
      ),
    );
  }

  Future<void> Dialog1(
    BuildContext context,
  ) async {
    return showDialog(
        context: context,
        builder: (context) {
          return StatefulBuilder(builder: (context, setState) {
            return AlertDialog(
              content: SizedBox(
                height: 300,
                width: 450,
                child: ListView(padding: EdgeInsets.zero, children: [
                  ListTile(
                    title: Expanded(child: Text('Sample Text', style: const TextStyle(fontWeight: FontWeight.bold))),
                  ),
                ]),
              ),
            );
          });
        });
  }
}

flutter doctor
[√] Flutter (Channel master, 2.6.0-12.0.pre.535, on Microsoft Windows [Version 10.0.17763.2237], locale en-IE)
[√] Android toolchain - develop for Android devices (Android SDK version 30.0.3)
[√] Chrome - develop for the web
[√] Android Studio (version 2020.3)
[√] VS Code (version 1.62.0)
[√] Connected device (2 available)

Hi @zambetpentru, thanks for filing the issue.

What platform are you experiencing this issue on?
Do you see any errors in your console? (in the case of web, check browser console)

That grey box usually means there's an issue with layout, and taking a quick glance at your code, I can see you're using Expanded in a ListTile, which would be the incorrect use of the Expanded widget, which would likely be the cause of the issue.

Hi,
The issue was experienced on Web, I didn't notice there was actually an error in Debug while it was still showing. Cheers!


Question: dva-admin Vs react-admin (formerly admin-on-rest)

How does it compare with https://github.com/marmelab/react-admin (which is from https://github.com/marmelab/ng-admin) ?
With react-admin, if we setup few configurations, the whole admin is up and ready. Is dva-admin works like that? (or, mere components that still needs assembling?) If not, is there any similar projects available that is comparable to https://github.com/marmelab/react-admin in this Ant ecosystem? TIA

FWIW, I also posted similar question here https://github.com/zuiidea/antd-admin/issues/855


MSBuild should continue to support calling batches containing piped finds

After updating to Visual Studio 2015 Update 1 (MSBuild 14.0.24720.0) batches containing piped find commands do not work anymore.
The following batch command searches for 'b' in 'abc' and finds a match. The errorlevel is set to 0 by the find command.
echo abc | find "b"

When executing a batch file containing the above command from MSBuild, then no match is detected. This worked before with MSBuild 14.0.23107.0.
But when using findstr instead of find there is no issue with  MSBuild 14.0.23107.0.
echo abc | findstr /L "b"

see https://gist.github.com/bluerobotch/5d160080dba4400e2c6b for a full example.

By the way, is there an official source for the Build Tools 2015 "Update 1" (The build tools installed with visual studio 2015 update 1)?
I can only find the Build Tools 2015 download:
https://www.microsoft.com/en-us/download/details.aspx?id=48159

Thanks for the report (and the nice repro)! This (like #397) is more fallout from the change in #143 to change the default codepage of the cmd.exe shell spawned by the Exec task. Your workaround is a good one.
As with the others, you should also be able to work around the problem by running
chcp 437

at the beginning of the Exec's Command or in the batch file that you're calling.  I confirmed that find.exe does use the current console codepage to determine what string conversions to apply--though I'm still confused about exactly what's going wrong in this case.

There is no standalone update for the Build Tools package, but my understanding is that if you install Build Tools 2015 and then run the Update 1 installer, you'll get an updated MSBuild.

@rainersigwald thanks for the quick response. Its a good thing to know that MSBuild now executes commands using the utf-8 code page when running on hosts with >= win7.
As i understand it's more a problem with find.exe than with MSBuild. Therefore we will keep our workaround.
Concerning Update 1, thanks pointing that out.

Thanks for following up. I'm going to leave this issue open for now as we decide whether or not to adjust the codepage policy going forward.

Incidences of this should have been reduced with #442 and Build Tools 2015 Update 2.


Several revisions to intro docs

This is a series of edits I made as I spotted things in the course of beginning to read through our docs. No large substantive changes, I think.

Automated message from Dropbox CLA bot
@gnprice, it looks like you've already signed the Dropbox CLA. Thanks!

Thanks for working on this @gnprice!  I merged all but the first commit, since that's the only one with material comments.
A few notes:

I think our "version control" guide still needs significant reworking.  It was originally written for Zulip, Inc. in very rough notes form, and despite some editing since then, I still don't feel is where it should be in terms of teaching the concept.  A task for larger future work, though.
We probably should advertise the zulipbot "area teams" a bit more strongly.

Nice, merged, thanks @gnprice!


CRS for load_collection

Here's a proposal for #98 to base discussions upon. Please comment and/or up/down-vote.

Not a big fan of this proposal, I prefer that users and process graphs do not enforce a CRS, unless the use case strictly demands it.
There is also not really a concept of a 'multi-crs' collection, in the sense that it is not exposed in the metadata. So users might be tempted to start defining crs's everywhere 'just in case', at the expense of performance and cost.

There is also not really a concept of a 'multi-crs' collection, in the sense that it is not exposed in the metadata.

That's not correct, the API supports it since version 0.4.

I agree with @jdries that performance may be badly affected. Many users will be tempted to specify the CRS without a proper understanding of the implications (whereas if they explicitly use the resample_spatial process at any point in the pg, they are conscious about their choice).
If we go for it, the CRS should be null by default (as in the current PR), because we should also consider that EO includes lots of data still in sensor geometry (e.g. S1 and S3 L1 data), and simply specifying a CRS at load_collection will not suffice in this case (maybe relatively few users will need to work with this level of data, but many scientists do research on the L1 to L2 processing step).

I agree with @jdries that performance may be badly affected. Many users will be tempted to specify the CRS without a proper understanding of the implications (whereas if they explicitly use the resample_spatial process at any point in the pg, they are conscious about their choice).

We can simply add a note to the description of the parameter so a user is aware of the issue.

@jdries and I had a long discussion on this issue in the train on Wednesday, and may have come to a possible resolution. The problem is that load_collection() shall return a data cube, that a data cube with x and y dimensions shall have an unambiguous from index to coordinates, and that this is not the case when tiles in a collection span several UTM zones. Pragmatic solutions to this (picking the CRS at the center of the extent, picking the single CRS when the extent only spans a single CRS) may sometimes work but not always. Of course for downloading a GeoTIFF or viewing a WMTS a CRS needs to be set, but the use case where someone wants to compute (and save) NDVI (or something much more expensive) in the native pixel / tile space spanning several CRS's is valid, and should not be cut off by requiring setting a single CRS (and working on it) here.
The way out I propose here is to make CRS a dimension.
This way, x and y map into the same coordinates for different CRS, and the CRS slice you're in determines how they map to world coordinates. This way, you can do everything on spectral and time dimensions, and simply loop over x, y and CRS with no need for resampling.
Certain spatial things that only work on the local (relative) context can also be done, think of a low-pass filter. Other spatial things, like aggregate_spatial with a set of polygons, need an unfolding of the CRS dimension into a mosaic with a single CRS before they make sense, or be done in an apply over the CRS dimension (in which case polygons crossing UTM zones will not result in a single result).
A similar idea of having CRS as a dimension would be having tile ID as a dimension: x and y indexes are the row/cols and then map into coordinates relative to the tile origin, with similar consequences.
@mkadunc what do you think?

Hm, interesting idea. We need to think about how that would work with our processes. What do we need to change in resample_spatial / resample_spatial_cube and how would for example a reduce on the crs dimension work?

I'm planning to write a bit of a longer piece about this, looking into the topics you mention.

Having CRS as a dimension makes a lot of sense, especially if it is treated as one of the spatial dimensions.
One concern I have is that adding CRS dimension might unnecessarily burden the user with this extra "singleton" dimension - just the fact that it's there is not a problem, but it can become one if you need to take it into account on almost each node of the process graph, even when the operations are not spatial. Maybe we should do some experiments with extra singleton dimensions and see how much they impact working with data cubes - if there's no impact we're OK, but if it's significant, we could find ways to implicitly take such extra dimensions into account without burdening the user.

Side note: There is another (a bit more involved) option, where CRS would not necessarily be a dimension - if we extended the concept of axis labels into a more general concept of "cell-attributes", then we could just require that every spatial cell has a non-null crs attribute: the value of this could come from:

the root of the cube (when the whole cube is a single CRS)
the separate CRS axis (when there are different CRSs and not aligned with other axes)
some other axis (when CRS can be derived from some other axis, as in the tileId-axis example)
In NetCDF, one would solve this with an extra variable (whose value is defined just once as a scalar or along a subset of axes), but since we decided to only hold a single value in a cube, we can't use the same mechanism.

The cell-attributes concept has additional uses, e.g.:

absoluteOrbitId can be used as a dimension, and its labels can provide the well-known time attribute so it can function as a temporal axis
productId as a dimension could, in addition to time and crs, provide per-scene info about the platform (S2A / S2B), processing version and other scene-related metadata (sun angles, viewing angles etc.)

This are maybe all things that could be handled with extra dimensions, but I think that it is more intuitive to think about dimensions, especially in the data cubes world, as "the minimal independent set of cell attributes that unambiguously address a single value" (in relational world these would be called "candidate key") — adding extra dimensions just to provide some metadata to the cells feels wrong.

We (@flahn and me) went a bit crazy discussing this proposal and have some more thoughts:

The proposal with the crs parameter in load_collection is the simplest from the user perspective. This would be very similar to what GEE offers.
The proposal with crs as Data Cube is not easy to understand, I think. A GEE user will probably not want to think about how to reduce a crs dimension and just stick with the simpler GEE approach. Scientists who strictly want to work on the original data/crs will probably like this approach.

So could we combine these two approaches? Could we say that if crs is not required and only if the collection has multiple CRS and the crs parameter in load_collection is not set, then a user gets a crs dimension?
The question really is: Who is the target audience? Who do we cater for? Which audience would lead to most uptake? etc.
Another thought was to allow something like this (in JS-like pseude code):
epsgCodesArray = get_metadata(field = 'eo:epsg') // Get all epsg codes from metadata
dataCubesArray = epsgCodesArray.apply(epsgCode => {
  dataCube = load_collection(id = "Sentinel-2", temporal_extent = null, spatial_extent = null, properties = eq('eo:epsg', epsgCode)) // Load all data that is stored in this epsg code
  // further process data cubes
})
var mergedDataCube = dataCubesArray.reduce((cube1, cube2) => {
  return resample_spatial_cube(cube1, cube2);
}, binary = true)
save_result(mergedDataCube)

That's mostly possible already. It basically returns one data cube per crs defined for the collection, all of them just containing the data that is available for that specific crs. Afterwards process them individually and merge them using a binary reducer if wanted.

Closing, we are going the route described in #98.


driver.url still reporting URL of original tab after using switchPage

We have a workflow in our web app which opens in a second tab.  We had a test which was able to verify the correct behavior.
This test was working with Karate version 0.9.6.  We have since upgraded to version 1.0.1 and this test is now failing.  Visually, I can see the browser switch between tabs, but driver.url is still reporting the URL of the original tab.
I put together a simple demonstration of the problem, which does not use our website.  This test passes with Karate version 0.9.6, but fails with version 1.0.1.
Feature: Second Tab Demo

  Passes with Karate version: 0.9.6
  Fails with Karate version: 1.0.1

  Scenario: Verify link opens in new tab
    * driver 'https://google.com'

    * text replaceLink =
      """
        document.querySelectorAll('a')[0].innerHTML = 'Yahoo!'
      """

    * script(replaceLink)
    * click("#yahoo")
    * delay(5000)
    * switchPage('Yahoo')
    * karate.log("driver.url", driver.url)
    * match driver.url contains 'yahoo.com'

@ptrthomas Thank you for your prompt response!
I tried * def theUrl = script('window.location.href'), but it returns the same value as driver.url.  I can run switchPage('Yahoo') and switchPage('Google') in the debug console and see the active tab switching in the browser, but no matter which tab appears to be active, the responses from the driver object's methods and from executing JavaScript, still indicate that they are interacting with the original tab:

@nathanchilton okay, we'll look at it, and hope someone picks it up sooner

@nathanchilton it should be fixed. it would be great if you can build from source as I tried to make some fundamental improvements. and note that switchPage(string) is now "retry aware" so you don't need to use a delay. let me know how it goes !

@ptrthomas I just confirmed that this is fixed in v1.1.0.RC2
Thank you!

@nathanchilton Could you please provide details of your POM file as I am facing similar too issue..I havent updated to a latest version before and I am unable to do so..Would be of much help if I know what I am doing wrong.
Thanks!

@nathanchilton Could you please provide details of your POM file as I am facing similar too issue..I havent updated to a latest version before and I am unable to do so..Would be of much help if I know what I am doing wrong.
Thanks!

@janmenezes28, I'm sorry to be so late to reply to your comment.  I learned Java back in the late 90s, before the magic of Maven, and I haven't dedicated the time to learning it yet.
I actually have filed an issue in my backlog to move to using Maven to manage dependencies.
Currently, I am using the stand-alone executable (.jar file) for Karate, and I maintain a directory full of other .jar files for all of our dependencies.  So, unfortunately, I do not have a POM file to share with you at this time.  I hope you have managed to find a solution by now.

@nathanchilton Thank you for the response and yes I am able to proceed after switching to a newer version..

1.1.0 released

switchpage is still not working even after the 1.1.0 fix . I also validated the same with the older versions 1.1.0.RC4,RC3,RC2 and latest version 1.2.0.RC1 none of them seems working ! Below is the sample script , even after the switchpage statement it return the url of the original tab and none of the element being identified from the new tab !
Script
 Given driver 'https://www.w3schools.com/jsref/tryit.asp?filename=tryjsref_win_open'
Then maximize()
When switchFrame('#iframeResult')
 * print 'driver.url before switch----------------', driver.url
And highlight("{}Try it")
And click("{}Try it")
* delay(2000)
And switchPage('https://www.w3schools.com/')
* delay(2000)
* print 'driver.url after switch----------------', driver.url
* highlight("//a[@href='https://www.w3schools.com ']")
* delay(5000)

Console Log:
15:26:36.385 [pool-1-thread-1] INFO  com.intuit.karate - [print] driver.url before switch---------------- https://www.w3schools.com/jsref/tryit.asp?filename=tryjsref_win_open
15:26:43.818 [pool-1-thread-1] INFO  com.intuit.karate - [print] driver.url after switch---------------- https://www.w3schools.com/jsref/tryit.asp?filename=tryjsref_win_open

@subra86 please contribute code ! or for now at lease follow this process and open a new issue: https://github.com/intuit/karate/wiki/How-to-Submit-an-Issue


Wrong image order when uploading images to cvat

I extracted every 5th frame from a 25,000 frame video, resulting in 5,000ish images that I uploaded to cvat. Everything is fine when annotating the images in cvat until I transition past image 999. Instead of going from 999 -> 1004 it goes from 999 -> 10,003, 10,008 etc all the way up to 10,035, where the next frame afterward is 1004. This makes it very difficult to use tracking to annotate the images since the 1000s and 10,000s images are mixed up. I'm going to go ahead and rewrite the name of each frame so that it caps out at around 5,000, but I was curious to know if there was a work around for future uses where I have more than 10,000 frames. Let me know if I need to clarify, I appreciate any help!

Hi @TheBurntWaffl3
Append leading zeros to all images names. This way: 00000, 00005, 00999, 10003
From the lexicographical POV (default sorting method), '10003' < '1004'.


Switchboard should expose a port for non-primary nodes

We have several larger CF installations (2500 spaces, 15000 apps), and period scraping of CAPI for metadata to power logging and telemetry causes significant performance impact due to the load on the primary DB node.
It would be great if I could configure a set of read-only CAPI nodes pointed at a separate port on switchboard which directs to the non-primary nodes.  I could then register these CAPI nodes to a new route like reporting-api.<system domain> and use this for my telemetry queries.

Hi there @Freakin, sorry for the delayed response.
It turns out we have done this feature, it's implemented and distributed in pxc-release v0.11.0. Read more in the story: #158778252
Please let us know what you think! I'll close this issue for now, but please feel free to re-open or send us feedback.
--
Marco Nicosia
Product Manager
Pivotal Software, Inc.


create new object instead of setting the padding directly on props in Content component

Hey,
I ran into crashes as my props were somehow converted into immutable objects. Maybe there are some performance things happening in newer versions of react-native and thus this error hasn't surfaced before.
Anyways, here's a pull request that doesn't directly modify the props object and allows overwriting of the padding by the user :)

But this will copy all content of this.props.contentContainerStyle that misses StyleSheet's caching, better way is using arrayed-styles, see my issue https://github.com/GeekyAnts/NativeBase/issues/227

Ah, sounds good!


Changed the default setting

Description

Changed the default command to mgcb-editor

Installing the Monogame pipeline tool, the mgcb-editor can be used/invoked globally. Therefore, the default setting is changed to "mgcb-editor". Also added a bit of instruction in the README.md

@mihnea-s Kindly review this

Thank you and sorry for not seeing it sooner.


Fixed lambda.invokeAsync tracing according to its spec in AWSIntegration.ts

Pull Request Test Coverage Report for Build d95e938f-fc84-4408-9896-241ac94e625d

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.04%) to 66.825%

Totals

Change from base Build aa16134d-df84-4645-85f5-956854a81725:
0.04%

Covered Lines:
1193

Relevant Lines:
1685

💛  - Coveralls


Rich Presence Client does not work anymore

Starting next week, it will be two weeks since the Discord Rich Presence Client can no longer be used (as for my case).
I did a reinstall using Homebrew, which was unsuccessful.

Can you send me:

the output of brew services
the content of /usr/local/var/apple-music-discord-rpc/music-rpc.log
the output when you manually run music-rpc.ts

The output of brew services:

The content of /usr/local/var/apple-music-discord-rpc/music-rpc.log:
music-rpc.log
The output when I manually run music-rpc.ts

Addition to the manual execution of music-rpc.ts:

Many apologies for my delayed response.
I appreciate your efforts as well as your willingness to help.

So there is no presence even when you manually run music-rpc.ts? The different outputs/logs seem correct to me...

That's correct.

Did you check that presences are correctly enabled within the Discord client settings?
Maybe try to reinstall Discord, all I see on the manual run is that the script correctly handshakes the Discord RPC and is getting track infos from Apple Music.

[...] all I see on the manual run is that the script correctly handshakes the Discord RPC and is getting track infos from Apple Music.
So did I.
I'll try to re-install the Discord client.

Hmm, let's try something.

Edit ~/Library/Application\ Support/discord/settings.json and add "DANGEROUS_ENABLE_DEVTOOLS_ONLY_ENABLE_IF_YOU_KNOW_WHAT_YOURE_DOING": true then relaunch Discord.
This should enable the access to the JS console (opt+cmd+i).
Launch music-rpc.ts and inspect the Discord console. If everything work well you should see SET_ACTIVITY messages like this:

Send me what you see here.

So the client is correctly receiving the activity but does not rebroadcast it.
If you have indeed enabled presence sharing within the settings, it may be a bug of the Discord client outside of the scope of the script.
Are presences working with other applications that support it?

I just changed a setting that was previously disabled. I remember having this function enabled by default. It must have changed during an update. Accordingly, I would like to apologize for the inconvenience caused by this inconspicuous feature.
Thank you for helping me with all the tools at your disposal. Stay healthy and have a pleasant day.


Add "tooltip-format" to temperature module

Thx, could you also update the github wiki?

Thx, could you also update the github wiki?


fix: rig loader now validates that prefab exits

Description

The Interaction Rig Loader now validates that the prefabs exist for each rig.
https://user-images.githubusercontent.com/6911992/107626432-116cca00-6c5e-11eb-8c56-22775bbf1208.mp4
Type of change

[x] Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Try renaming, moving out from the Resources folder, or deleting the XR Rig prefabs, the Interaction Rig Loader should mark a Rig as invalid if its corresponding prefab is missing.
For testing purposes, the [XR_Setup_Simulator] can be deleted from the XR-Interaction-Component/Resources and regenerate by setting again the training scene from the innoactive menu.

:tada: This PR is included in version 1.7.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


"This server does not have crafting tweaks installed"

I have crafting tweaks installed on the server, but players get this message regardless.  Is there something special that has to be done in order for crafting tweaks to flag that it is installed?

Huh. Is the Crafting Tweaks on the server & clients updated to the latest version?
Are they running on a super slow connection? The message should only appear if the server didn't reply to the clent's hello-message within ten seconds.
Is this on 1.7.10 or 1.8.9?

1.8.9 on 3.0.52

I think it might be an issue with the server.  Hold off on troubleshooting until I'm certain it's a crafting tweaks issue

Server related issue.


Anonymous cross mounting a blob results in invalid Location header

Describe the bug
When sending an anonymous blob cross mount, the returned Location header includes the mount parameter, and the upload location is appended to that query parameter.
To Reproduce
I'm testing this with regclient:
$ regctl artifact put -f sbom.json localhost:5207/sbom -v debug
DEBU[0000] regclient initialized                         VCSRef=0e8ba98e23a78839b7d514bbc7ab1cbf3a6e1fbd-dirty VCSTag=
DEBU[0000] http req                                      method=POST url="http://localhost:5207/v2/sbom/blobs/uploads/?mount=sha256%3A44136fa355b3678a1146ad16f7e8649e94fb4fc21fe77e8310c060f61caaff8a" withAuth=false
DEBU[0000] Received put URL                              digest="{ 2 sha256:44136fa355b3678a1146ad16f7e8649e94fb4fc21fe77e8310c060f61caaff8a [] map[] [] <nil>}" err="<nil>" location="/v2/sbom/blobs/uploads/?mount=sha256%3A44136fa355b3678a1146ad16f7e8649e94fb4fc21fe77e8310c060f61caaff8a/c43c16a9-0cd8-458e-bd61-82ece2f25b8b" putURL="http://localhost:5207/v2/sbom/blobs/uploads/?mount=sha256%3A44136fa355b3678a1146ad16f7e8649e94fb4fc21fe77e8310c060f61caaff8a/c43c16a9-0cd8-458e-bd61-82ece2f25b8b" target="localhost:5207/sbom:latest"
DEBU[0000] http req                                      method=PUT url="http://localhost:5207/v2/sbom/blobs/uploads/?mount=sha256%3A44136fa355b3678a1146ad16f7e8649e94fb4fc21fe77e8310c060f61caaff8a/c43c16a9-0cd8-458e-bd61-82ece2f25b8b&digest=sha256%3A44136fa355b3678a1146ad16f7e8649e94fb4fc21fe77e8310c060f61caaff8a" withAuth=false
DEBU[0000] Request failed                                Status="Method Not Allowed" URL="http://localhost:5207/v2/sbom/blobs/uploads/?mount=sha256%3A44136fa355b3678a1146ad16f7e8649e94fb4fc21fe77e8310c060f61caaff8a/c43c16a9-0cd8-458e-bd61-82ece2f25b8b&digest=sha256%3A44136fa355b3678a1146ad16f7e8649e94fb4fc21fe77e8310c060f61caaff8a"
WARN[0000] Sleeping for backoff                          Host="localhost:5207" Seconds=1.999942473
DEBU[0002] http req                                      method=PATCH url="http://localhost:5207/v2/sbom/blobs/uploads/?mount=sha256%3A44136fa355b3678a1146ad16f7e8649e94fb4fc21fe77e8310c060f61caaff8a/c43c16a9-0cd8-458e-bd61-82ece2f25b8b&digest=sha256%3A44136fa355b3678a1146ad16f7e8649e94fb4fc21fe77e8310c060f61caaff8a" withAuth=false
DEBU[0002] Request failed                                Status="Method Not Allowed" URL="http://localhost:5207/v2/sbom/blobs/uploads/?mount=sha256%3A44136fa355b3678a1146ad16f7e8649e94fb4fc21fe77e8310c060f61caaff8a/c43c16a9-0cd8-458e-bd61-82ece2f25b8b&digest=sha256%3A44136fa355b3678a1146ad16f7e8649e94fb4fc21fe77e8310c060f61caaff8a"
failed to send blob (chunk), ref localhost:5207/sbom:latest: request failed: unexpected http status code: Method Not Allowed [http 405]:

Note the location header: location="/v2/sbom/blobs/uploads/?mount=sha256%3A44136fa355b3678a1146ad16f7e8649e94fb4fc21fe77e8310c060f61caaff8a/c43c16a9-0cd8-458e-bd61-82ece2f25b8b"
Expected behavior
Location header above should have been: /v2/sbom/blobs/uploads/c43c16a9-0cd8-458e-bd61-82ece2f25b8b
Screenshots
n/a
Additional context
Related to #442

Thanks for filing this issue, to set location we are relying on request URL itself.  I will raise a PR with fix.


feat(@schematics/angular): add migration to enable AOT by default

With this change we enable the AOT option for the browser builder when an application will use Ivy as rendering engine.

Should we enable aot in the schema by default?


add multer support for fastify

This PR implements the functionality discussed in this issue https://github.com/samchon/nestia/issues/819
I need some help with the testing though, cause I cannot make test run in my computer @samchon
Thanks :)

#819 (comment)

any news here?

@samchon any news about this PR? has been 4 months, you asked us for a PR and we opened one, if you will discard this, just told us and we will make a fork cause we need this feature in order to fully migrate to nestia

Preparing major update to dependent libraries @samchon/openapi and typia.
After these libraries' major updates, nestia will also take the major update too, and this PR would be accept at that time.
The next major update may come in a month.

Well, not working on CJS
https://github.com/samchon/nestia/actions/runs/12042762353/job/33576977029


Cut-n-paste between X11 apps and Windows

With WSL 2 support for GUI (X11) applications, I no longer need to set up a local X11 server on Windows.
However, I may yet have to do that since the clipboard does not work.
That is, I am running a standard X11 tool that runs with the X11 implicit clipboard highlight and paste.  (It is rxvt but traditional xterm would also be the same)
Anyway, between two X11 windows (two rxvt windows) I get the right cut-n-paste behavior but I can not paste the results into a Windows window (say Notepad or VS Code) nor can I paste something I cut from Windows into the X11 terminals.
This is a major flaw and something that makes it very hard to work in the environment with Windows 11 and the WSL compared to Windows 10 and WSL and a Windows X11 server (specifically, I have been using  VcXsrv https://sourceforge.net/projects/vcxsrv/ before Windows 11)
Could we get cut-n-paste to work across WSL GUI and Windows or do we need to figure out how to run our own X11 server software again?

@Michael-Sinz, would you please double check if you are using WSL from aka.ms/wslstorepage, not the one from Windows's optional features. We have fixed various issues with clipboard in newer release from Store. Also, WSLg does not yet support copy by primary selection from X11, thanks!

@hideyukn88,  I am using the one from the store - installed last night
It is the primary selection from X11 - I use actual rxvt windows for my xterm (as I have lots of tools that throw new windows for status/etc)
The problem right now is that I can't cut-n-paste results from those windows into anything on the Windows side.  If I open up a Linux X11 notepad or VSCode on the Linux side it works but nothing works to the Windows side.
In Windows 10, I used my own VcXsvr installation and this was working wonderfully - I have yet to figure out what to do here with Windows 11 and the implementation there.  I may have to revert to VcXsrv to have a working environment again - which would be very unfortunate given that otherwise this works nicely.

Close as duplicate of https://github.com/microsoft/wslg/issues/642


TypeConverter for custom struct is ignored (.NET Core)

Hello everyone,
It seems that custom TypeConverters are now ignored for custom structs.
Additional info: I am using NUlid (see PR to include the TypeConverter: https://github.com/RobThree/NUlid/pull/7 - https://github.com/rcollina/NUlid/blob/2bd8b3ad648cafa9bb8dc4159a62739f73cab48d/NUlid/UlidTypeConverter.cs).
Works in .NET Framework:

Doesn't seem to work anymore in .NET Core:

Is there anything I'm missing / something I might be overlooking?
Thanks in advance.

It wasn't supported in 9.0.1
Get that latest pre-release version off NuGet and try again.

Thank you.


Fix typo

Thanks! Sorry, I noticed it while updating the readme before I saw your pull request. I appreciate the contributions. I'll close this one, but happy to accept future PRs.


[Material] Create material Banner component

Description
This PR creates a new material widget for the Banner component. This includes a theme as well. This widget can be dropped into any application, ideally at the top of a listview or scrollview.
Coming later will be a demo in the gallery and the ability to animate the Banner in/out.
Screenshot of the Banner:

Related Issues
#18001
Tests
I added the following tests:

Widget tests for the Banner itself.
Widget tests for the Banner theme.

Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] I signed the CLA.
[x] I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
[x] I updated/added relevant documentation (doc comments with ///).
[x] All existing and new tests are passing.
[x] The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
[x] I am willing to follow-up on review comments in a timely manner.

Breaking Change
Does your PR require Flutter developers to manually update their apps to accommodate your change?

[ ] Yes, this is a breaking change (Please read Handling breaking changes). Replace this with a link to the e-mail where you asked for input on this proposed change.
[x] No, this is not a breaking change.

What happened with the part:

Banners that appear after a screen loads should animate on screen from the top of a layout. If the banner is at the same elevation as content, it pushes content downwards.

The hard part of the component for us is the animations and having it fixed on the screen.
Is there any plan to have it fully implemented? Can our team help somehow?


Databook unable to load xls

I'm trying to load an xls file however it fails with the following error
with open("xls_file", "rb") as fh:
    imported_data = Databook().load(fh, "xls")

Traceback (most recent call last):
  File ".\test.py", line 5, in <module>
    imported_data = Databook().load(fh, "xls")
  File "lib\site-packages\tablib\core.py", line 872, in load
    fmt.import_book(self, stream, **kwargs)
  File "lib\site-packages\tablib\formats\_xls.py", line 103, in import_book
    xls_book = xlrd.open_workbook(file_contents=in_stream)
  File "lib\site-packages\xlrd\__init__.py", line 166, in open_workbook
    file_format = inspect_format(filename, file_contents)
  File "lib\site-packages\xlrd\__init__.py", line 57, in inspect_format
    peek = content[:PEEK_SIZE]
TypeError: '_io.BufferedReader' object is not subscriptable

Databook is not supported for xls, only for xlsx.
You should probably avoid using xls files wherever possible, xlsx is the default Office format since 2007.

Databook is not supported for xls, only for xlsx.

Could you please provide more context or clarify where you came across the information stating that databook is not supported for XLS? I noticed that in the documentation, there's an example of exporting a databook as XLS, and the XLSFormat class seems to implement both both export_book and import_book methods. Additionally, when checking the tests, XLS is not listed as an unsupported format for books. So the evidence suggests that Databook indeed supports XLS format.

Databook is not supported for xls, only for xlsx.

So the evidence suggests that Databook indeed supports XLS format.

 My bad. 😳
I do however stand by the other part of my statement, which is that XLS is old and creaky and should be avoided. 😊

…XLS is old and creaky and should be avoided.

Of course, however you don't always have the choice, typically when you are not the data producer.


Add scope attribute to support partial document updates

Is there a way to create a separate form for an embedded schema (as if it was its own document)? I'm doing it right now with onSumbit–is there a better way?

@nate331  @aldeed  Is there anything new on how to update object which is part of array? All Arrays are overwritten :( I need to update just one.

As a workaround I am doing it the way I described in my previous post. Number validation is not working properly, so I changed the type of the Field to String. It is not ideal, but good enough.
This is the way I do it:
        before: {
            update: function(docId, modifier, template) {
                var fieldIdentifier = Meteor.userId();
                var path = getSubObjPath(template.data.doc, "optgroupA.$.optgroupB.$.identifierField", fieldIdentifier) + ".field1";
                var mod = {};
                mod[path] = AutoForm.getFieldValue("myFormId", path);
                var newModifier = {
                    $set: mod
                };
                return newModifier;
            }
        },

/*
 * eg. getSubObj(obj, "recommendedTeams.$.members.$.userId", "a32jrlwo3jk2j2")
 * -> return something like: "recommendedTeams.2.members.0"
 */
//prevPath is optional parameter (needed for recursion)
getSubObjPath = function(obj, path, value, prevPath) {

    if (prevPath === undefined)
        prevPath = "";

    if (!obj)
        return undefined;

    var parts = path.split(".");

    if (parts.length === 1) {
        if (obj[path] === value) {
            return prevPath;
        } else {
            return undefined;
        }
    }

    if (parts[0] === "$") {
        for (var i = 0; i < obj.length; i++) {
            var prevPathTmp = prevPath === "" ? "" : prevPath + ".";
            var resultPath = getSubObjPath(obj[i], trimPath(path), value, prevPathTmp + i);
            if (resultPath) {
                return resultPath;
            }
        }
    } else {
        var prevPathTmp = prevPath === "" ? "" : prevPath + ".";
        var resultPath = getSubObjPath(obj[parts[0]], trimPath(path), value, prevPathTmp + parts[0]);
        if (resultPath) {
            return resultPath;
        }
    }
};

Done in AutoForm 5.0, now released. See new form type update-pushArray plus other fixes related to this.


Advanced Page fields are missing

The following errors are thrown:
Notice: Undefined index: registration_page in /var/www/allterrain.nl/public_html/wp-content/plugins/ssv-frontend-members/models/FrontendMembersField.php on line 276
Notice: Undefined index: field_class in /var/www/allterrain.nl/public_html/wp-content/plugins/ssv-frontend-members/models/FrontendMembersField.php on line 277
Notice: Undefined index: field_style in /var/www/allterrain.nl/public_html/wp-content/plugins/ssv-frontend-members/models/FrontendMembersField.php on line 278

Hidden fields added. Now it doesn't warn anymore. It does however still adds the new fields with fields for advanced view (these should also be removed).

Somewhere this went wrong.


Fixing a bug with recent Structure-of-arrays PR and multiple grids

Since the recent #678, ParticleSet.particle_data.xi (and same for yi, zi and ti) is a vector of length of the ParticleSet instead of the length of the Gridset. This means that if multiple Grids are present, Parcels currently breaks.
A solution could be to make ParticleSet.particle_data.xi an array of size (Particleset.size, fieldset.gridset.size). However, I had a look but couldn't see where to make these changes.
@angus-g, since you so wonderfully drafted most of the initial #678, could you also have a look at how to incorporate this change?

Hi @erikvansebille, I think your suggestion of changing the size of the index arrays is pretty sensible! I've made that change and pushed to my fork at https://github.com/angus-g/parcels/tree/soa_multigrid_indexing
I haven't run the full test suite, but this is failing the test_pset_from_field test because the index arrays are never assigned. I'm a little bit confused as to why this wasn't failing before?

Thanks @angus-g, for the quick response! Can you merge your changes into this PR, so that I can easily check them out locally and work on them too?

Unfortunately not, since I don't have commit access!

Thanks for committing this fix, @angus-g!
I think one of the reasons that some of the unit tests break is because of the code below:
https://github.com/OceanParcels/parcels/blob/soa_multigrid_indexing/parcels/particleset.py#L720-L726
In particular, if this is changed to
        for i in range(self.size):
            p.set_index(i)
            # try:  # breaks if either p.xi, p.yi, p.zi, p.ti do not exist (in scipy) or field not in fieldset
            #     if p.ti[field.igrid] < 0:  # xi, yi, zi, ti, not initialised
            #         raise('error')
            #     xi = p.xi[field.igrid]
            #     yi = p.yi[field.igrid]
            # except:
            _, _, _, xi, yi, _ = field.search_indices(p.lon, p.lat, p.depth, 0, 0, search2D=True)
            density[yi, xi] += particle_val[i]

then the unit tests pass. Note however that removing the commented code altogether is not ideal, because it means that calculating ParticleSet.density() is much slower (as  field.search_indices is very slow). So ideally the commented lines are fixed. Do you see how, @angus-g?

I've just pushed a possible idea for this, which is a bit ugly. If we make a JIT kernel that samples the field, the indices get set correctly.

If we make a JIT kernel that samples the field, the indices get set correctly.

Nice idea; I actually like it quite a lot!

OK, so is this ready for merge when we get green ticks on the CI?


Table suffix to create tables with InnoDB engine

Hi all,
I've forked jinzhu/gorm more than a year ago, and did modify the code at that time to provide another mysql engine. For instance, the goal was to create tables with InnoDB engine without changing the default storage engine. It's time to share the code if some of you find some interest.
Code is pretty simple, but I did create a new function to distinguish the regular Open and the version with table options, called "OpenWithTableSuffix". Looking at latest syntax, https://dev.mysql.com/doc/refman/5.7/en/create-table.html, it exists several table options. Engine is one of the many possibilities.
Best regards,
Gabriel

HI @eirmag
Thank you for your PR.
What about we only support this? db.Set("gorm:table_suffix", "...").Create(&User{}) and don't need to introduce another API

Hi @jinzhu,
I've modified the PR to remove the OpenWithTableSuffix function, and updated the README accordingly. I've also renamed the gorm parameter to gorm:table_options to better reflect its purpose.
Best regards,
Gabriel

Thank you.


deployment_token provided was invalid.

Standing up an azure static web app but i keep getting error saying deployment_token provided was invalid.

trigger:

main
pool:
vmImage: ubuntu-latest
steps:
checkout: self
submodules: true
task: AzureStaticWebApp@0
inputs:
app_location: /
skip_app_build: true
skip_api_build: true
azure_static_web_apps_api_token: $(deployment_token)
cwd: $(Pipeline.Workspace)/CloudNextWebPage-DocFx
env: $(CloudNextWebPage-DocFx)

Hi, are you using BitBucket as a provider? We recently released a fix for this. Can you please try the deployment again?

I am not using bit bucket but azure repos

This is the error message i am getting
App Directory Location: '/_site' is invalid. Could not detect this directory. Please verify your deployment configuration file reflects your repository structure


[feat] change Polyline Component to named export and version up

Refactor polyline comonent as named export and modify README.md

LGTM👍


No Related Resource link between PVCs and Pods

Internal reference: SURE-4367
Reported in 2.5.12 & 2.6.4
Issue description:
The UI has a "Related Resources" tab on PVCs and Pods, but there is no related resource for pods that consume a PVC
Repro steps:

Create Pod that consumes a PVC
View the "Related Resources" tab on that PVC

Workaround:
Is workaround available and implemented? no
Actual behavior:
There is no reference to the Pod that consumes that PVC
Expected behavior:
The Pod would be considered a related resource, so should show up as one.

Blocked on backend ticket: https://github.com/rancher/rancher/issues/37599

Do we need it to be in the related resources tab? We could create separate tabs for them, similar to Services and Ingresses on the workload detail page. We already have access to all the Pods, PVs and PVCs, and we know which Pods are bound to PVs. I think we already have enough info to add a Pods tab to the PVC detail page which could show which PVs the Pods are bound to.

There should be no UI work - leaving this open to validate once the backend work is done

Pod to pvc don`t have ownerReferences, not like pod  to deployment. anotherway to fix it  is list all pod of  namespace and  filter which pod is use pvc. I have fix it in my environment, although it is not elegant enough


Some performance optimizations to dockerTools.build{,Layered}Image

Motivation for this change
This PR aims to speed up creation of Docker images using the dockerTools utilities by reducing the disk I/O performed while creating layers.
The first commit reduces the number of of tar -r invocations, and the second one calculates tarsum's on the fly while creating the tarball. These two changes seem to make the buildLayeredImage function almost twice as fast when building large (> 4GB) images when disk I/O is the bottleneck (eg. on cloud machines).
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[x] Tested via one or more NixOS test(s) if existing and applicable for the change (nix-build release.nix -A tests.docker-tools)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Adding a little more context, some of the reason for the original slowness is the inefficiency of appending to TAR files - see http://tiamat.name/blogposts/fast-appending-files-to-tar-archive-is-impossible/
The portions of this change that eliminate the separate pass with tarsum are less significant in their effect.
We have a case with a client where a sizeable image built with buildImage takes around 4-5 minutes, while buildLayeredImage takes 20 minutes with the same contents: the changes in this PR bring the latter down to around 12 minutes, but further opportunities exist for improvements. In particular, multiple layer tar files are currently realised on disk before being joined into an overall archve, but this intermediate storage could likely be eliminated. It might be that a tailored program for this task would be the right approach. It would also be ideal to unify the code paths for buildImage and buildLayeredImage.

@nlewo @bjornfor Thank you for the reviews! Do you think there is anything else I should to before we can merge this? I think I addressed @nlewo 's comment above.

@GrahamcOfBorg test docker-tools


Message Notification "Default" not playing sounds

My Setup

Operating System: Fedora Release 32
App Version: 3.1.1
Installation type: Flatpak

[x] I have tested with the latest version
[x] I can simulate the issue easily

Description
The message notification sound that is set to default does not play. I've tried all selectable tones and the issue persists for all of them. The "Notifications sound volume" is set to 99/max. Right now I've set "New Message Notification" to "Chime". In the "Notification Preferences" of a conversation, the Sound will not play, neither in preview nor after receiving a message, when the sound is set to "Default". When I manually select a specific sound for the conversation, such as "Chime", it works both in preview and when receiving messages. Resetting the app data, logging out and in, rebooting the system and reinstalling the application did not fix the issue.
Current Behavior
Sound notifications won't play for conversation where the message tone is set to "Default".
Expected Behavior
"Default" message sounds should play as intended.

Hi! the same issue. App Versions tested 3.5.7 - 3.6.0
#2239
ENV: (disable_presence_monitor seems doesn't matter)
Windows 10 Build 19042.1348

Please test if the problem persists with our latest release. I will be closing the issue but if there is any problem yet, we will open it again.


/opt/mesosphere/detect_ip -- should be made configurable

Hey guys,
I have a requirement to make my kafka install publicly accessible so this would be nice if it were configurable.
/opt/mesosphere/detect_ip_public
https://github.com/mesosphere/dcos-kafka-service/blob/master/kafka-config-overrider/src/main/java/com/mesosphere/dcos/kafka/config/Overrider.java#L239
So i can use that one

@andreimc:  Were you planning on deploying Kafka on agents with role slave_public?  Deploying dcos-kafka-service on statically reserved resources is not supported.

@gabrielhartmann yeah I wanted to make it public with SASL auth but I ended up doing something else.

Closing stale Issue.


Wrong parameter definition

https://github.com/Azure/Bio-Compliancy/blob/48cc443ca01d9fd0dfc00c5091b33fe386e7a315/ARM/BIO-azuredeploy.json#L3796
Hi, everywhere in the ARM/BIO-azuredeploy.json file are the parameters defined in a wrong way, with double [[

Somehow these parameter references do work as intended, though.
When I use this ARM-template to deploy the initiative (policySet) definition to a management group, and then assign the initiative with some custom parameter values, then the underlying policy assignment does get the correct parameter value applied to it.
For example, for listOfAllowedLocations I had selected only westeurope, at the initiative assignment level. Then when I try and create a resource group in northeurope (on the allow-list by default), this does get blocked.
Perhaps this has to do with the fact that these parameters are declared at the initiative-level, rather than at the ARM-template-level.

https://learn.microsoft.com/en-us/azure/azure-resource-manager/templates/template-expressions

Escape characters
To have a literal string start with a left bracket [ and end with a right bracket ], but not have it interpreted as an expression, add an extra bracket to start the string with [[. For example, the variable:
"demoVar1": "[[test value]"

Resolves to [test value].


Add comment on generated code

Please add some comment on generated code. As reference look at here

Fixed https://github.com/PacViewer/jrpc-gateway/commit/05f5f1a2764accbe3be17ea2dfd7082cf78fc4bb


feat!: remove net package, use @actions/http-client instead

Yea, I'll update that in a bit. For now, it can stay pinned to the older version.


Add FOSSA scan

/hold
/un-cc @JustinKuli @ycao56

/close since a fork may not be able to access secrets when attempting to merge a PR with a new/modified workflow


[DO NOT MERGE] Auto PR to update dependencies of pilot

This PR will be merged automatically once checks are successful.
none

@istio-testing: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/pilot-presubmit.sh
c1994bd5637237b2f945f3cec364df519fb5cb80
link
/test pilot-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


Offline Mode

Is this plugin works offline (Without Internet)?
If yes then how to force the plugin to run offline (Without Internet)?
My code is not working Offline, I just copied the docs code below.
this.geolocation.getCurrentPosition().then((resp) => {
// resp.coords.latitude
// resp.coords.longitude
}).catch((error) => {
console.log('Error getting location', error);
});

Can anyone please reply me?

Using the GPS without having a mobile/wifi connection available will result your device relying solely on GPS satellites. It can take a really long time to receive a "GPS Fix" to the satellites. Even in perfect conditions, it can take upwards of 10-15 minutes for an average phone to get a satellite fix. Note that once, the phone has received the satellite fix, gps updates will become much more stable. The satellite positions will be cached, so the next time the GPS requires a fix, in theory should be a lot quicker from a "cold" startup. Note that this doesn't have anything to do with the library or the phone itself. This is simply how GPS satellites and hardware work.
Ideal conditions is being outside, clear weather, open skies (no tall buildings/mountains). Things taht can interfere with GPS signals is being in large buildings, poor/stormy weather, lots of concrete objects in the way limiting the "sky visibility",  etc. The following documents may explain why it takes so long to start up better than I can:
https://en.wikipedia.org/wiki/Time_to_first_fix
https://gpslogger.app/gps-fix-details.html
The reason GPS works quickly when internet access is available is because of "A-GPS" (Assisted-GPS) which completely skips the requirement to look for & connect to several satellites. So obviously, if possible, it's best to have an online connection, but if offline support is necessary then you'll need to be prepared for a lengthy period of time before the phone can begin receiving GPS events.
I realize this is probably not an answer you were expecting, but I hope this information helps provide you a better understanding of GPS technology and in turn, help you make informed decisions in your app development.

Background updates are not currently supported. The main challenge with this is that not all devices allows webview javascript to run in the background.


Convert examples/components/simpleviewer.js to await/async

Please do not work on this issue unless you have applied to the outreachy project.
The simpleviewer.js example currently uses the older style of promise.then and callbacks. Convert it to use an async function and await style.

Hey I am Jane from Outreachy would love to work on this issue!

Jane, I see you have picked several issues. Please which one are you working on? I want to pick one but I see your trail all over the place.


Update images on console

In this PR, we only change the images to focus mode.
We also need to change some text on the following places:

It seems that we don't show the errors in focus mode. see the below picture, the link is here

The same problem as above is in another doc. See here

Docs Build status updates of commit 483a133:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

[Error: CannotMergeCommit] Cannot merge commit 483a133540c5c1f688df50b7f6dda3de519e468e in branch user/xiaofeihan/focus-mode of repository https://github.com/xiaofeihan1/edge-developer into branch focus-mode-docs-bash (commit d6658ce1ddf129a53b9ba13a67ed8453879d7221). Please follow this documentation: https://help.github.com/articles/resolving-a-merge-conflict-using-the-command-line/ to use git.exe to resolve you content conflicts locally and then push to remote.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit 0517040:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

[Error: CannotMergeCommit] Cannot merge commit 0517040f1c3575577e67ea5fbb4a72f23920ea0d in branch user/xiaofeihan/focus-mode of repository https://github.com/xiaofeihan1/edge-developer into branch focus-mode-docs-bash (commit d6658ce1ddf129a53b9ba13a67ed8453879d7221). Please follow this documentation: https://help.github.com/articles/resolving-a-merge-conflict-using-the-command-line/ to use git.exe to resolve you content conflicts locally and then push to remote.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Thanks @xiaofeihan1, I'll rebase this branch to get rid of the build errors, and will make the required documentation changes.

@xiaofeihan1 I fixed the issues locally, but since I couldn't push back to your fork, I just moved your commits to another branch on this repo. Here it is: #2119. So I'll close this PR now. That doesn't mean we're not accepting your changes :) It's just that your work is now in the other PR.


AbapGit releases/tag

IMHO I guess each release of AG and AG-related-tools should be accompanied with corresponding git tag (and probably release, which changelog abstract) :)
Would be helpful for this in particular #2236 and as a good practice in general

yes, see https://github.com/larshp/abapGit/issues/960
suggest closing this issue as duplicate

agree :) closing


ci: add workflow_dispatch to GitHub Actions Lint and Test workflow

Add workflow_dispatch to lint.yml and test.yml in .github/workflows/ so that we can trigger them in the schxslt branch (or any others) at any time.

Lint and Test were triggered by hand successfully.


Write core values of the project in the kanban board

Core Values

providing a reliable service to smartly supply the requesting browser with required feature implementations that it does not support
improving ease of web development
support localization
real-time service usage monitoring


Deprecated React Lifecycle Methods

Hi,
Do you plan to migrate away from the deprecated React methods such as:
componentWillReceiveProps
componentWillUpdate
Thanks,
Justin

Hi,
I forgot about this so yes, I'll do it soon :).
Thanks for reminding me!
Cheers,
Jeremy

Great stuff - thanks!
On Thu, 6 Dec 2018 at 19:58, Jérémy Farnault<EMAIL_ADDRESS>wrote:

Hi,
I forgot about this so yes, I'll do it soon :).
Thanks for reminding me!
Cheers,
Jeremy
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/fnzc/react-native-pincode/issues/58#issuecomment-445009224,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AKT5VRUdz1S_qbU34f-jKSOcFATqyGxKks5u2XbmgaJpZM4ZCfjS
.

Hi,
Done in 1.10.7 :)
Cheers,
Jeremy

Awesome - responsive as always! :)
On Sun, 9 Dec 2018 at 01:11, Jérémy Farnault<EMAIL_ADDRESS>wrote:

Closed #58 https://github.com/fnzc/react-native-pincode/issues/58.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/fnzc/react-native-pincode/issues/58#event-2014203912,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AKT5Vb-H7k9Mn0Y86J4Iyk2mVnnCcdFJks5u3GMzgaJpZM4ZCfjS
.


Here is a gist with relevant logs. This can be reproduced on #20

Update at 20k blocks

Command to return only the block number:
cast block finalized --field number --rpc-url http://localhost:9545
Example for Optimism testnet:
cast block finalized --field number --rpc-url https://rpc.ankr.com/optimism_testnet

This may be specific to the devnet setup for ethereum-optimism, but not our setup.

This is due to the L1 not finalizing in the devnet. It is a POA chain. Goerli finalizes, so it would work as expected when deployed to Goerli.


vulkan-loader doesn't build and breaks nixos-19.03pre155110.60ae563293e

Issue description
On the current nixos-unstable-small channel vulkan-loader doesn't build because of an assertion error. This prevents system upgrades altogether.
Steps to reproduce
On the current nixos-unstable-small channel
$ sudo -i nixos-rebuild switch --upgrade
unpacking channels...
building Nix...
building the system configuration...
error: assertion failed at /nix/store/xlmja9agydii8nazmp5c9n40573kdpys-nixos-19.03pre155260.276b99a847e/nixos/pkgs/development/libraries/vulkan-loader/default.nix:4:1

Technical details

system: "x86_64-linux"
host os: Linux 4.14.75, NixOS, 19.03pre155110.60ae563293e (Koi)
multi-user?: yes
sandbox: yes
version: nix-env (Nix) 2.1.3
channels(chisui): ""
channels(root): "nixos-19.03pre155260.276b99a847e"
nixpkgs: /nix/var/nix/profiles/per-user/root/channels/nixos

vulkan-headers auto-update was reverted in ac6f4851480e3a7016a2257a62c34ed46dcea789, so this
should be fixed when the channel advances.

I've just checked both packages. We might get away with just removing the assertion as it seems not to hold in general. It was only added in the last version bump.

Oops, just merged bae3fd3d83cc9f227ae7974c32506afdda103ea6 which fixes vulkan-loader. @xeji, do you think I can re-revert https://github.com/NixOS/nixpkgs/commit/ac6f4851480e3a7016a2257a62c34ed46dcea789?

Re-reverted in 45351e6916ac56a04b633b445e5f42a357d0437e, both packages are now on 1.1.85:
$ nix-build . -A vulkan-headers -A vulkan-loader
/nix/store/82b2k5ij7y6pibibb5gjgmn760bj30lp-vulkan-headers-1.1.85
/nix/store/s1vm5zzqgbmbi7idhl3znyw2gv9yk0nb-vulkan-loader-1.1.85

Thanks @yegortimoshenko  !

This is back today on the most recent nixos-unstable-small.

Just ran into this too.
{
  "url": "https://github.com/NixOS/nixpkgs-channels",
  "rev": "fab6d810b5ac32f6d20fa2a77b97e8fbe0ffbd90",
  "date": "2019-04-18T10:14:50+02:00",
  "sha256": "1k5sgd3s6b1ka7fpssc0h8xv6jmgx7lfc8myczhsa1vkmga2kwvh",
  "fetchSubmodules": false
}


⚠ ClamAV has degraded performance

In 71d785f, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 215 ms

Resolved: ClamAV performance has improved in 984bcf7.


Add cross files for AVR

We cross-compile for AVR - work on this support with the ariadne-bootloader project.

This has been done.


Proof of Work for Flag Submission

This provides an option to provide a proof of work on flag submission.  The difficulty of finding a matching key is proportional to 2**PROOF_OF_WORK_BITS.  Values around ~12 provide a few seconds delay per operation (implemented in javascript, using the WebCrypto API).
If you don't want to use this, just set the PROOF_OF_WORK_BITS value to 0, which disables it completely.  (Also is the default value.)
This implements #133.

Codecov Report

Merging #138 into master will decrease coverage by 0.44%.
The diff coverage is 33.33%.

@@            Coverage Diff             @@
##           master     #138      +/-   ##
==========================================
- Coverage   66.41%   65.97%   -0.45%
==========================================
  Files          26       26
  Lines        2156     2178      +22
  Branches      266      272       +6
==========================================
+ Hits         1432     1437       +5
- Misses        616      632      +16
- Partials      108      109       +1


MB-15034 Replace deepcopy package

Jira ticket for this change
Summary
Switched to a newer, more active package, old package also failed to do what I needed.
Setup to Run Your Code
make server test is good to test this.

Messages

:book:
:link: MB-15034

  Generated by :no_entry_sign: dangerJS against 03d02d2911dfb50d334319e4d2b6d6d5f0e72add


Missing APIs for core types

Hello! I'm working on a new native binding for Godot (https://github.com/raniejade/godot-kotlin) and I have notice that there are quite a lot of missing APIs for the core types.
One example is that the getters and setters for Vector3 are missing, e.g:

godot_vector3_get_x
godot_vector3_get_y
godot_vector3_get_z
godot_vector3_set_x
godot_vector3_set_y
godot_vector3_set_z

I know that there are versioned struct aside from the core one, however, I didn't find the missing APIs there.

I think we can close this issue?
For GDNative take a look at godot-cpp where for core classes like Vector2, we've done a re-implementation on the godot-cpp side because this is far more efficient than getting/setting members through the API barrier.
For GDExtensions we've done the same but the new extension_api.json does include all core types and I can confirm these setters and getters are callable.
All in all, this repo is a mirror of the headers and implementation found in Godot. If after all these years we do wish to have this enhancement added to Godot 3, the issue should be raised in the main Godot repo.

Yes this can be closed. Future issues related to this should be split with one issue per actual problem, so that they can be properly addressed. Inconsistency in the Godot API exposed through ClassDB in the API JSON should be raised at the main Godot repository if they're a bug, or on https://github.com/godotengine/godot-proposals if it would be an enhancement for clarity's sake (e.g. unifying APIs in a way that would make them clearer but break compatibility).


Grants table should be sorted by status, with active grants first and terminated grants later

if possible, the secondary short criteria would be by project name, alphabetically

Adding an extra sort criteria for projectName will require an update to pass-indexer : Elasticsearch does not allow sorting on fields indexed as text by default, so this behavior would have to be enabled.
"root_cause" : [
      {
        "type" : "illegal_argument_exception",
        "reason" : "Fielddata is disabled on text fields by default. Set fielddata=true on [projectName] in order to load fielddata in memory by uninverting the inverted index. Note that this can however use significant memory. Alternatively use a keyword field instead."
      }
    ]

Reference: https://www.elastic.co/guide/en/elasticsearch/reference/current/fielddata.html
Possible solutions:

Simply not sort on projectName or other text fields
Enable this fielddata
Create a new field explicitly used for sorting?

Looks like any changes to pass-indexer that could enable sorting on these fields will require reindexing of the data


egui_glium: Use config_dir instead of data_dir

The documentation stated .config would be used but since data_dir is used here, it really ends up in .local/share.
Of course, alternatively the documentation could be updated. I'm personally not sure what is the more suitable location for storing the application state. Does it count as configuration or data?

Oops, good catch! In this case I'd say it's the docs that are wrong. The paths are used to store application state, which is more than just "configurations" in my opinion.


[posix] add Thread network default interface name configuration

The default Thread interface name wpan0 has been occupied by other programs in Android. Thread network has to use other network interface name. Then users have to specify an interface name when they are using the command ot-ctl. It's very inconvenient.
This commit adds a configuration for developers to set the default Thread interface name.

how about retrieving the interface name from the first socket file found?

That's a good idea.  It could be implemented in another PR.


Safer UI by re-arranging the grouping of context menu

The horizontal breakers are functional not just aesthetic. They provide non-clickable buffer space. I have just accidentally deleted a file I wanted to rename that was not yet in GIT - because I was off by one or two pixels using my trackball.
Destructive UI elements should not be next to other UI elements, please re-group these to avoid this sort of issue in future.

From the OS level, at least checking in Windows, Delete and Rename are adjacent and not separated.
/cc @bpasero @alexdima

Personally, I think destructive actions that cannot be undone should prompt. @MattWilcox did the delete not prompt in your case?

/cc @isidorn
This is controlled by this setting I believe explorer.confirmDelete

Personally, I think destructive actions that cannot be undone should prompt. @MattWilcox did the delete not prompt in your case?

Nope it didn't. I'd guess the default option is not to, as I've not changed that - but I think these are two separate things tbh. prompting confirms would really annoy me more often than help me. This is about minimising UI errors without introducing friction.

Yeah this prompts by default.
Let me know if you can reproduce it not prompting with latest vscode insiders
We will not change order due to users muscle memory, and putting a seperator might work, I just do not like having one item separator groups since it looks ugly.

I would argue that "looks ugly" is less of a concern than "data loss", but I do get your viewpoint :) There are already two single-item-groups in that menu.


Update Firestore manual code to reflect GAX changes

(The QueryTest change seems to be just reverting a previous change, but that wouldn't have compiled. Not sure what happened there, but this is correct.)

Integration tests are failing - looking into that now.

Think I've fixed it - will update the PR.

Done, ready for review again :)


[FLINK-24733][connector/pulsar] Data loss in pulsar source when using shared mode

What is the purpose of the change
This pull request fix data loss when using flink pulsar source.
Brief change log

Add invalid CompletableFuture cancel when poll messages.

Verifying this change
This change added tests and can be verified as follows:

Add simple pulsar source e2e test

Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
The serializers: (don't know)
The runtime per-record code paths (performance sensitive): (no)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
The S3 file system connector: (no)

Documentation

Does this pull request introduce a new feature? (no)
If yes, how is the feature documented? (not documented)

I don't think this fixed the data loss issue. Pulsar internally wrap the CompletableFuture in receiveAsync() with a CompletableFutureCancellationHandler. The pending receiver would be automatically removed when meeting TimeoutException.
That means we don't meet data loss when we don't manually cancel the future.
@AHeise Can you confirm this?

I think that you are wrong. The  CompletableFutureCancellationHandler

internally

I don't think this fixed the data loss issue. Pulsar internally wrap the CompletableFuture in receiveAsync() with a CompletableFutureCancellationHandler. The pending receiver would be automatically removed when meeting TimeoutException.
That means we don't meet data loss when we don't manually cancel the future.
@AHeise Can you confirm this?

I think that you are wrong. As the source code, The pending receiver cannot remove the future with CompletableFutureCancellationHandler.  What you used is CompletableFuture.get(timeout) ,   not the CompletableFuture.orTimeout(timeout). If you don't manually cancel the future, the future will lost in connector, but still in the pending receiver queue in  internal pulsar client. So the data lost. Please take a look.

@syhily Based on my test, if we don't manually cancel the future, the data will lost. If we manually cancel the future as this PR, we don't meet data loss. Just Test it !

For every fix, we should add a test case. In that way, we can determine exactly why the original code fails and why the fix helps. Imho that would cut the discussion, so could you please add a test?

For every fix, we should add a test case. In that way, we can determine exactly why the original code fails and why the fix helps. Imho that would cut the discussion, so could you please add a test?

okay, I will commit some tests.

@wsz94 The data loss is confusing. I think we need more tests on this situation. After discussing with my Pulsar team member and test on my local machine. The pending wouldn't be removed. This is a bug on the Pulsar side. We can have a patch for the reader. But it should be fixed on pulsar client.

@wsz94 I have created a patch by using consumer.receive(timeout, timeunit). Can you confirm this fix works?
https://gist.github.com/syhily/fbf47b581257f94869c59660002bbfa1

@wsz94 I have created a patch by using consumer.receive(timeout, timeunit). Can you confirm this fix works?
https://gist.github.com/syhily/fbf47b581257f94869c59660002bbfa1
You can checkout a brand new branch and run the command below:
curl https://gist.githubusercontent.com/syhily/fbf47b581257f94869c59660002bbfa1/raw/072f26a8946a753b41be832c54f1c54f342a41e8/FLINK-24733.patch | git apply

Thanks. According to your suggestion, I modified the commit to fix the PulsarOrderedPartitionSplitReader  too. Could you help me to confirm this PR.

@wsz94 I have created a patch by using consumer.receive(timeout, timeunit). Can you confirm this fix works?
gist.github.com/syhily/fbf47b581257f94869c59660002bbfa1_ (too large to embed)_
You can checkout a brand new branch and run the command below:
curl https://gist.githubusercontent.com/syhily/fbf47b581257f94869c59660002bbfa1/raw/072f26a8946a753b41be832c54f1c54f342a41e8/FLINK-24733.patch | git apply

Thanks. According to your suggestion, I modified the commit to fix the PulsarOrderedPartitionSplitReader  too. Could you help me to confirm this PR?

We may need some tests to confirm this issue has been fixed.

@wsz94 You can check my fix and test on https://github.com/streamnative/flink/tree/hotfix/data-lose-when-timeout

@AHeise I think this PR is ready. Can you perform the final review?

Hi @syhily , thanks for the fix. I was a bit lost in the initial discussions but the fix definitively looks good. The only change that I'd request is to merge both commits into one as they are the same logical entity: You'd usually write a test to showcase the issue and then turn it green with a fix. Since we don't want a commit that fails, we merge them both.


Prevent scrolling in 1 direction

Dragging to a list box where there are items wider than the list box sees the list box scroll horizontally as the cursor passes the list box boundary. This is undesired behaviour as most of the information scrolls away leaving only the tail of the larger items showing.

Is there a way to prevent scrolling in a certain direction while dragging?
Scrolling vertically in this instance is fine as the user may want to do that when the list box contains many items.

@osicka I planed to make the scrolling behavior better (e.g. adding new attached properties) for v1.1.0

@osicka With v1.1.0 comes a new attached property DropScrollingMode with this enum values
  /// <summary>
  /// Specifies how <see cref="T:System.Windows.Controls.ScrollViewer" /> reacts to drop operation.
  /// </summary>
  public enum ScrollingMode
  {
    None,
    HorizontalOnly,
    VerticalOnly,
    Both
  }


Day of week icons should adjust text size

When we draw a DayOfWeekIcon the text has a static size, regardless of the size of the icon. It should expand to fill a given percentage.

This was as simple as setting the font size to be equal to the icon size.


Badge component

This PR adds a badge component to core and removes the import of the Bootstrap badge. Issue #5271.

Looks good :+1:

Looks great! :+1:
I just have one question – I noticed that badges with a single character in them tend to produce a circle, instead of a "pill" or "capsule" shape – was that intentional?

I just have one question – I noticed that badges with a single character in them tend to produce a circle, instead of a "pill" or "capsule" shape – was that intentional?

Yes, that's intentional. Good or bad? I wouldn't mind some more padding on the sides, but for single characters, if it's almost a circle but not quite, it kinda feels odd.

Documented another feature. If you add the badge-flexible class, the size of the badge changes depending on the parent's size (using ems). For example if a badge is used inside an <h1>, the badge becomes bigger. Settings will look like this:

Good or bad? I wouldn't mind some more padding on the sides, but for single characters, if it's almost a circle but not quite, it kinda feels odd.

I'm not sure. I think I'm experiencing an optical illusion – even though the circle badges should be the same height as the capsule badges, they seem taller, and a little out of place.
This has happened to me before with typography and optical alignment (versus "perfect" alignment). Say you're trying to center a fragment of text – depending on the characters used / capitalization, even if it's technically perfectly centered in the center of a document, it could look un-centered because of the shapes of the characters. I think something like that might be happening here?

Could it be that it depends on the number? The 5 in the screenshot does look a bit strange. Here a couple different ones:

@simurai Oh sorry I meant when they were all in a line:

For some reason the single character badge ('3') looks to me a little taller than the others, even though I'm sure it's the same height, because of the circle shape.

Maybe the "roundness" makes it seem more "pointy" and thus taller? Here just a bit more padding to make them oval.

Hmm.. the "almost" a circle makes them look a bit weird when stand-alone.
Ohh.. wait. Maybe it's the color? Here they are all green:

Yes, I would say better, right?

Ah yeah I see what you mean, they definitely look better as circles than as "almost circles." And it does look fine all the same color. Looks good to me :+1:

Phew... :sweat_smile:

Is this ready to :ship:?

Yes, I think it's good to go. Next to the settings, the only other place I found them being used is in the Select List:

Maybe some other packages use them, but but since the class name stays .badge, it should be fine there too.


Throw exceptions if the context isn't running during a call to begin()

It's easy to make this mistake--because the main thread is often the one making the call to begin, do not allow users to block on a call to autowiring::parallel::begin until after the context is started.
Fixes #688

makes sense.


Create my profile route

Description
In this PR, I created the Profile route and linked it to "My profile" NavLink.
I also added the active class to all the NavLinks.
this closes #22
Thank you for taking the time to review this pull request.

STATUS: APPROVED :green_circle: :clap:
Hi @Sboursen  ,  Nice Job on the setup
it's time to merge it :shipit:
Congratulations! 🎉

You set up linter files and no errors. 👏
Best practices 👏

Cheers and Happy coding!👏👏👏


docs: Group the left menu of APIs

Adds sections in the navigation bar as requested in https://github.com/probabl-ai/skore/issues/836.

in we want toggle menus instead, we can add "show_nav_level": 0, in html_theme_options dict.

Thanks!


Empty repo migration bug

Description

When attempting to run a migration on an empty repository (no code), it errors out.  There could potentially be scenarios where the repo would not have any code, but still have issues created in it that want to be migrated.
A potential solution around this is to simply init the repo by creating a README and then to the migration. But right now the error otherwise requires additional investigation to confirm that the repo was indeed empty.
[1:51 PM] [INFO] You are running the latest version of the gei CLI [v0.31]
[1:51 PM] [INFO] Waiting for test migration (ID: RM_kgDaACRkNDk5MjA1Ni0zZmU2LTQ5ZTEtYjAxOS1mNDRjMTY5ZWNmNjI) to finish...
[1:51 PM] [ERROR] Migration RM_kgDaACRkNDk5MjA1Ni0zZmU2LTQ5ZTEtYjAxOS1mNDRjMTY5ZWNmNjI failed for test
[1:51 PM] [ERROR] Git source migration failed. Error message: reference 'refs/heads/main' not found
=============== Summary ===============
Total number of successful migrations: 9
Total number of failed migrations: 1

Reproduction Steps

create empty repo in github (no git) (and create an issue perhaps that you want to attempt to migrate)
run gh gei generate-script
run the migration powershell script generated for the org

Closing this as it's a backend issue rather than a CLI issue, and we have internal issues to track this problem.


Minor doc fix for #1196

Fixes incorrect docstring example in calicoctl profile command

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Stephen Schlie seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.

@heschlie You should sign the CLA :)

LGTM.

@caseydavenport I have, not sure why it isn't updating on github, checking the cla again just tells me I've signed it :/


setDefaultTemplate() doesn't work when schema is created on the front end

This might not actually be an issue (or it might just be an issue with autoform) but, in our project (haven't tested it outside of the project yet). But it seems like the code below doesn't work when you create a schema that only exists on the front-end.
Meteor.startup(() => {
  AutoForm.setDefaultTemplate("semanticUI");
});

Can you elaborate on the use case?
A code example would be nice, I can't see what you are trying to do.
I tried a client-only collection with a schema (client side only too), the template works.