[Web] Dragging negative X value breaks usePrice hook.

Watch what happens when I go below 0 on the x-axis. The error points to usePrice. Presumably we just need to clamp the values to the min and max X values.
https://user-images.githubusercontent.com/13172299/139600005-826016ab-64c0-4d29-a5df-aa0991102152.mp4

It also shows this value for the SVG:

Fixed both issues at #25


Do not ask to save for dirty files on delete

VSCode Version: 0.10.12-alpha (latest)
OS Version: Windows 10

Steps to Reproduce:

Modify a file and do not save
Delete the file

Actual:
Confirmation that you want to delete shows up, then after it asks if you would like to save the file.
Expected:
No confirmation asking if you would like to save after confirming delete.

We prompt to prevent data loss, but I agree that the provided options do not make so much sense in that case.

Now doing the same as when deleting a folder with dirty files, not asking for confirmation. But keeping the file dirty in the editor.


Login | Revise IE browser not supported messaging |2|

We want to revise the current messaging on our login screen when a user is accessing TFRS via Internet Explorer. The current messaging contains too much text and does not necessarily catch the user's eye that there is an issue with their current browser.

Consider adding a more visible message, such as "Warning: Your browser is not supported" in bigger bold text, and then have the remaining text appear below it.

https://trello.com/c/XkkfeqEF/2074-login-revise-ie-browser-not-supported-messaging-0

 Login | Revise IE browser not supported messaging |2|


Fix OnyxTab Navigator performance issues on web

Details

This PR tries to fix performance isseus with OnyxTabNavigator(and underlying MaterialTopTab) on web by disabling animations. The root cause lies in high intensity of calculations going on on each transition between tabs and in a way Animated works on web.
The navigation flow is bound to be changed in near future, that's why PR aims to be as concised as it can (without performing deeper changes to the animation etc.)
More details can be found in the original PR and in the quickfix.
Fixed Issues

$ https://github.com/Expensify/App/issues/31190
PROPOSAL: https://github.com/Expensify/App/issues/31190#issuecomment-1851723261
Tests

Open FAB -> RequestMoney
Switch to Manual and check if it is rendered correctly
Switch to Scan and check if it is rendered correctly
Switch to Distance and check if it is rendered correctly

Offline tests

QA Steps

N/A
PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

https://github.com/Expensify/App/assets/62747088/fcf2fbb9-6db1-4153-83ee-02e50d3f9168

iOS: Native

https://github.com/Expensify/App/assets/62747088/cb12d6d7-768b-426c-89fe-285df0aa115a

iOS: mWeb Safari

https://github.com/Expensify/App/assets/62747088/124d85eb-d357-4e05-a5ff-491861bf91de

MacOS: Chrome / Safari

https://github.com/Expensify/App/assets/62747088/1fb32288-b90a-49c6-878a-b58373b0a6e5

MacOS: Desktop

https://github.com/Expensify/App/assets/62747088/c5cef007-af84-4a61-94a1-caa56dda5ae8

@kacper-mikolajczak Can you profile this PR so we can know the performance improvement here?

@kacper-mikolajczak Can you profile this PR so we can know the performance improvement here?

Definitely!
Setup
As a test I went through each tab like this:
https://github.com/Expensify/App/assets/62747088/c06dbbca-9425-4db3-ade4-858392d4e584
Results
Here are the results of profiling that on Web.
Before (profiled prod at new.expensify):

After (profiled current branch):

As you can see, there is less high-traffic going on after disabling animations (the rAF callbacks tend to go way beyond frametime threshold, thus slowing down the whole app).
Hope that helps 👍

@mountiny Can you start an adhoc build to test this branch on physical device?
And @mananjadhav can you check this PR in physical iphone?

Making the build here https://github.com/Expensify/App/actions/runs/7411340404

Hi folks @mountiny @shubham1206agra 👋
What is the status of the review for this one? Thanks! 👍

@kacper-mikolajczak You may want to also request review from @mananjadhav as he was the original reviewer.

@kacper-mikolajczak You may want to also request review from @mananjadhav as he was the original reviewer.

Sure thing! I cannot add reviewer myself but I guess @mananjadhav already knows as we pinged him 😄

@mananjadhav whats your ETA for this review?

I'll have them reviewed by today end of day and finish the checklist by tomorrow.

@kacper-mikolajczak Can you please resolve the conflicts?

Reviewer Checklist

[x] I have verified the author checklist is complete (all boxes are checked off).
[x] I verified the correct issue is linked in the ### Fixed Issues section above
[x] I verified testing steps are clear and they cover the changes made in this PR

[x] I verified the steps for local testing are in the Tests section
[x] I verified the steps for Staging and/or Production testing are in the QA steps section
[x] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[x] I checked that screenshots or videos are included for tests on all platforms
[x] I included screenshots or videos for tests on all platforms
[x] I verified tests pass on all platforms & I tested again on:

[ ] Android: Native
[ ] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[x] I verified proper code patterns were followed (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I verified that this PR follows the guidelines as stated in the Review Guidelines
[x] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[ ] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native
https://github.com/Expensify/App/assets/3069065/e40ccae9-038a-458e-b045-d1b808e55e24

Android: mWeb Chrome
https://github.com/Expensify/App/assets/3069065/5678e91c-d0f5-4bd0-ba33-b93f20ec3709
https://github.com/Expensify/App/assets/3069065/4f00a1ac-99cd-48e6-92d2-0fb1c5beebca

iOS: Native
https://github.com/Expensify/App/assets/3069065/759a8baa-e2ea-46ce-85c5-81e88a145dc8

iOS: mWeb Safari
https://github.com/Expensify/App/assets/3069065/22f38e42-26f6-4577-8887-8e5c47720a4e

MacOS: Chrome / Safari
https://github.com/Expensify/App/assets/3069065/6eac5fdc-a6d7-4604-ad3f-529f2539df3f

MacOS: Desktop
https://github.com/Expensify/App/assets/3069065/c650ca99-819a-4764-9624-b665b0493a2a

iOS seems to work well for me. and yes Chelsea is loosing 😢
https://github.com/Expensify/App/assets/36083550/01073296-d939-4beb-a2b7-4c90dc720805

@kacper-mikolajczak merging main should fix the reassure test failure

@kacper-mikolajczak I am currently facing a problem with a real Android device.
Steps:

Open request money from FAB
Go to scan tab. Make sure camera works correctly.
Using manual route, go to confirmation step.
Click on Add reciept. Make sure camera is working correctly here too.
Go back to the amount step using back button.
Now go to scan tab again.

Expected - Camera is working
Actual - Camera is black screen.

NVM, this is also repro in prod. But maybe this can be fixed here.

@mountiny @shubham1206agra Conflicts resolved ✅
The Blues did not win tho, let's hope they can come back in the second leg ⚽

NVM, this is also repro in prod. But maybe this can be fixed here.

If the bug did not originate here, let's tackle it in separate issue 👍

The Blues did not win tho, let's hope they can come back in the second leg ⚽

hopefully 🙏
@shubham1206agra @mananjadhav could we wrap this up?

The Blues did not win tho, let's hope they can come back in the second leg ⚽

hopefully 🙏
@shubham1206agra @mananjadhav could we wrap this up?

Its good to go from my side. Waiting for @mananjadhav to approve the request.

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/stitesExpensify in version: 1.4.24-4 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
cancelled 🔪

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/mountiny in version: 1.4.24-8 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Add Source::KeyAndPattern and DIDMethods::generate

Allow passing an additional string to a DID method in the generate function.
Implementing generate on DIDMethods allows generating a DID from a set of DID methods given a DID method name and optional additional string, separated by a colon (:).
The additional string may be a prefix or pattern for the DID's method-specific ID, according to the DID method.
This is intended to enable #124.

@sbihel yes, it is kindof like an inner DID or sub-DID. DID Core doesn't say DIDs must use a hierarchical namespace. I was thinking maybe for some DID methods it might be a suffix or glob pattern instead of only a prefix, e.g. *-example. It also might be an arbitrary string that might not be a pattern at all. So the naming is questionable, as is the meaning - but effectively it is just a string input argument for the generate function alongside the JWK.
An alternative could be to use a Metadata structure instead of string. DID Core specifies Metadata structure (map of properties) for DID resolution, DID URL dereferencing, and "other DID-related processes". Then we could define a property, which could be registered in the DID Specification Registries, to indicate the public key hash type for did:pkh. That would just be a little more verbose, as in the CLI it might be used this:
didkit key-to-did pkh -i publicKeyHashName=tz

instead of the shorter way based on this PR:
didkit key-to-did pkh:tz

Also the DIDKit API (non-CLI) would need to be updated to take an additional metadata/options object. That would be a breaking change, unless a new set of functions is defined (e.g. keyToDIDWithMetadata and keyToVerificationMethodWithMetadata). This PR's approach doesn't require changing the type signatures of the functions keyToDID and keyToVerificationMethod - but it changes the name and meaning of the methodName argument.
For a bigger picture, we could consider how this might work with DID creation more generally. There isn't a standard interface for creating or generating a DID like there is for resolving one, but we could look at what Universal Registrar does: it has a CreateRequest type in its HTTP API, and a register() function for drivers to implement. CreateRequest takes an options property. register takes an options property and also an identifier string, which is the DID to registry (when known). For generative DID methods (e.g. did:pkh and did:key), we don't know the identifier at creation time, so could not use the identifier parameter of the register function, unless we bend the meaning of it to include partial DIDs or patterns, like what this PR uses. Otherwise, we would need to use options, and need to define an option name for this PR's pattern/name string. In that case, maybe it would be better to just use metadata/options here instead of a method-pattern string. It seems it would be simpler semantically to define an option like publicKeyHashName, although it would be more verbose on the CLI and require API changes in DIDKit.

I agree that using metadata would be simpler semantically, but as an end user I find the current interface better.
Thank you for the explanation, I think this PR is good as it is :+1:

Thanks, @sbihel

Rebased


[gdal] Patch find_package2, test with tiff[zstd]

What does your PR fix?
Fixes regression in using gdal with tiff[zstd], appearing #27928.
Upstream: https://github.com/OSGeo/gdal/pull/7048, https://github.com/OSGeo/gdal/issues/7040
Closes #28803.

CC @Neumann-A

This does not fix that: https://github.com/microsoft/vcpkg/blob/5bb5f3923a33d862b25c18fd4514e08c74c698e1/ports/tiff/vcpkg-cmake-wrapper.cmake.in#L40 is wrong and leads to calling the wrong module which is the underlying fix https://github.com/microsoft/vcpkg/pull/28803 provides.
Furthermore, this has nothing to do with find_package2 since it is simply not defined for the offending targets/packages.
https://github.com/OSGeo/gdal/blob/6bdeb5623b5e7febde1fcfb932ee9214db9594dc/cmake/modules/DefineFindPackage2.cmake#L85-L87
acts as the implicit stop gate for find_package2 and does the same as your explicit variable here. Just study the CI trace logs from https://github.com/microsoft/vcpkg/runs/10517848810
Since you didn't add the tiff changes from #28803 you probably won't see the regression in gdal in this PR which makes the test itself invalid.

I'm still looking into completing the test coverage because I'm aware of the relevant ports not being built.

Furthermore, this has nothing to do with find_package2 since it is simply not defined for the offending targets/packages.
https://github.com/OSGeo/gdal/blob/6bdeb5623b5e7febde1fcfb932ee9214db9594dc/cmake/modules/DefineFindPackage2.cmake#L85-L87
acts as the implicit stop gate for find_package2 and does the same as your explicit variable here. Just study the CI trace logs from https://github.com/microsoft/vcpkg/runs/10517848810

IMO still missing the point I made in https://github.com/OSGeo/gdal/issues/7040#issuecomment-1376169052.

IMO still missing the point I made in https://github.com/OSGeo/gdal/issues/7040#issuecomment-1376169052.

Yeah but that is not to be discussed in vcpkg since vcpkg just needs a working solution for itself. Having a general upstream solution is a nice to have but not a hard requirement for vcpkg.
But let me tell you: target generation itself is always guarded by if(TARGET) and as such will not lead to any interactions when the if is removed. However, target name collisions are a problem with gdals current design and that might cause issues. I would rather like to see them use GDAL::ZSTD (VTK Style) and stuff for external deps instead of ZSTD::zstd which might create a collision as already observed in the tribits parts of https://github.com/microsoft/vcpkg/pull/27928 where i went ahead an prefixed all meaningful targets with TPL:: to avoid at least a collision with fmt::fmt.

The gdal patch was accepted upstream.

Close this PR? @dg0yt https://github.com/microsoft/vcpkg/pull/28929#issuecomment-1382672584

@LilyWangLL  Now that #28929 is green and approved, too, I can reset this PR to draft and close it as soon as the other is merged.

@dg0yt close?

Now that #28929 is green and approved, too, I can reset this PR to draft and close it as soon as the other is merged.

close?

@Neumann-A As announced, now.


Pass args correctly by quoting $@ in your_grep.sh

Fix for #24.
Running docker compose run tester scripts/compile_and_test.sh courses/build-your-own-grep haskell did not fix your_grep.sh in all stage solutions (IIRC only the first one).
I ran ruby scripts/propagate_changes.rb courses/build-your-own-grep/ to fix all stages.
I'll look into removing the unwords trick from the solutions as well with another commit in this PR.

propagate_changes.rb worked nicely after removing unwords from the first stage solution where it was used 👍

Some GitHub API says Resource not accessible by integration during post_diffs 🤷♂

Some GitHub API says Resource not accessible by integration during post_diffs 🤷♂

Yeah, we need to find a workaround for this - weirdly enough, PRs from forks don't get the kind of token required to post comments.
I think we're good here though, diff looks clean - merging! Thanks @bert2 🙂


Run a grandpa validator node without become an aura validator node

Please forgive me if I misunderstand how the consensus works.
Aura is used for block production and a offline aura validator means increased average block time until it is removed from the validator list.
Grandpa is used for block finalization and less than 1/3 of total validator offline should not affect the block finalization time.
This basically means Aura node have high availability requirement whereas Grandpa have a lower availability requirement compare to Aura node. It will be good to allow node to become Grandpa validator without become Aura validator. This allows home server to become grandpa validators to improve decentralization without hurting the block production in case anything unexpected happens.

This is already possible.


METRON-870: Add filtering by packet payload to the pcap query

Contributor Comments
Currently we have the ability to filter packets in the pcap query tool by header information (src/dest ip/port). We should be able to filter by binary regex on the packets themselves.
Probably the state of the art and the goal to get to here is integration with Yara, but I'd like to iterate toward that solution for a couple of reasons:

Yara is hard to integrate with in our stack.

It's C and, while the yara-java project does exist, it would make the build a bit of a pain and no longer platform agnostic (i.e. you'd have to build certain modules against the machines that you're running in the cluster).  There are paths through that for sure, but it's more than I wanted to tackle just now.

The core abstraction for the obvious integration yara-java is running yara over a file, not a byte array.  This would necessitate taking the performance penalty with JNI AND writing out every packet to a temporary file, then deleting it, in the MR job.  I did not deem that a sensible approach.
Yara is a whole language, similar to stellar.  The point of integration would be as a proper org.apache.metron.pcap.filter.PcapFilter, not as a portion of an existing one.

That lead me to look for a stop-gap that was simpler and had the following characteristics:

Worked within Java easily
Was permissively licensed
Functioned on byte arrays
Could do both hex regex as well as interpreting the byte array as a string (similar to Yara)

bytestream ( an all java regex library that functions on byte arrays, not files) fit the bill without eating all of a full-on Yara integration and fit within our core abstractions better.
As such, the approach that I took is to provide the capability both of the packet filters that we currently have in place:

Fixed via a new command line option --packet_filter or -pf wherein you pass the binary regex.

This would restrict to a single pattern

Query via a new Stellar function BYTEARRAY_MATCHER(pattern, packet)

This allows you to compose multiple filters with logic operations to get a closer to Yara-esque feel via Stellar

I have made a follow-on task to integrate with Yara at METRON-871.
Testing plan will be in the comments.
Pull Request Checklist
Thank you for submitting a contribution to Apache Metron (Incubating).
Please refer to our Development Guidelines for the complete guide to follow for contributions.
Please refer also to our Build Verification Guidelines for complete smoke testing guides.
In order to streamline the review of the contribution we ask you follow these guidelines and ask you to double check the following:
For all changes:

[x] Is there a JIRA ticket associated with this PR? If not one needs to be created at Metron Jira.
[x] Does your PR title start with METRON-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
[x] Has your PR been rebased against the latest commit within the target branch (typically master)?

For code changes:

[x] Have you included steps to reproduce the behavior or problem that is being changed or addressed?

[ ] Have you included steps or a guide to how the change may be verified and tested manually?

[x] Have you ensured that the full suite of tests and checks have been executed in the root incubating-metron folder via:
mvn -q clean integration-test install && build_utils/verify_licenses.sh

[ ] Have you written or updated unit tests and or integration tests to verify your changes?

[x] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?

[ ] Have you verified the basic functionality of the build by building and running locally with Vagrant full-dev environment or the equivalent?

For documentation related changes:

[x] Have you ensured that format looks appropriate for the output in which it is rendered by building and verifying the site-book? If not then run the following commands and the verify changes via site-book/target/site/index.html:
cd site-book
bin/generate-md.sh
mvn site:site

Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
It is also recommended that travis-ci is set up for your personal repository such that your branches are built there before submitting a pull request.

It appears that byteseek has a LGPL dependency in gnu trove, a primitive collections library.  As a stopgap, I:

excluded the dependency
provided a translation layer inside of metron-pcap based on mahout-math (which is, in turn, loosely based on Colt, a primitive collections library)

This is less than ideal in the long-run, so I submitted a PR against the library and asked for a new release.

On second thought, the part of the byteseek library that we're using doesn't use trove, so we can safely exclude it without providing the colt translation layer.  I have taken it out.

Hi, byteseek author here.  I notice you're using the standard BoyerMooreHorspool searcher.  Just to let you know that the HorspoolFinalFlagSearcher offers much better performance than the standard Horspool searcher - about 1.5 to 2 times faster in my tests - and uses no more memory or pre-processing time.
It's essentially the same algorithm as Horpsool, but re-arranges it a bit so that it only needs to verify a match when the algorithm detects that the last character matches the pattern, which can be done using a negative shift value (the "final flag").   Since verification is expensive to perform on each loop iteration, this performs much better in general.

Hey, thanks for that feedback @nishihatapalmer !  I adjusted to use the suggested searcher.  I did have one more question, I'm looking to document the possible regex's available for binary search, is there any documentation on the restrictions or capabilities of the compiled regex's?

There is a slightly out of date (note to self: update this!) syntax document at:
https://github.com/nishihatapalmer/byteseek/blob/master/src/main/java/net/byteseek/parser/regex/Regular Expression syntax.txt
It gives an overview of most of the syntax, but some of it is only usable by full regexes, not sequence matchers.  In particular it can only accept syntax which leads to a fixed length expression, so these are excluded:
*  zero to many
+ one to many
() groups
{n,n} n to m copies.
 X | Y alternatives.

Shorthands defined in this document also do not currently function properly (e.g. [ascii].
Finally note that inversion  ^ functions differently to most regular expression syntaxes.  The token being inverted is the following token, not the entire set.  So most regex would say something like [^ 01 02 03] meaning every byte except 01, 02 and 03.  In byteseek this would be ^[ 01 02 03], as you are inverting the set.  [ ^01 02 03] is also valid - except you are now specifying a set containing everything but 01 (which already covers 02 and 03).
It's fairly easy to create a different parser if necessary, but most of byteseek regex syntax is fairly standard - but oriented towards bytes rather than strings as the default atomic unit.
Any questions please feel free to ask (and I really must update the syntax document!).
Regards,
Matt.

When you say use regexes, do you mean use the regex syntax to create fixed length sequences, or do you mean use full regex functionality?  Full regex exists using NFAs and DFAs, but needs testing, as I haven't looked at that part of byteseek for quite some time.

Currently, I'm using the SequenceMatcher to compile a matching expression and then using a searcher to search in the byte array for that expression (code is here ).  From what I can tell, this isn't using the NFA or DFA under the hood, is that wrong?

Correct, there's no NFA or DFA under the hood of the SequenceMatcher.
You can create sequences using the regex syntax using the SequenceMatcherCompiler, as long as only syntax which creates fixed length sequences is used.  So you can match bytes (hex values), sets of bytes [01 02 03], any bytes ., bitmasks, strings and case insensitive strings, but not wildcards or optional bytes.  For example:
01 ^02 'a string' [f0-ff] 'another string' [0a 0d]
The RegexCompiler can accept the full regex syntax including *, +, ?, and it does create NFAs - but this isn't tested.

I have placed an updated syntax document as a markdown file syntax.md in the main byteseek project.  Hopefully it's a little clearer than the old text file.  As ever, any questions...
https://github.com/nishihatapalmer/byteseek/blob/master/syntax.md

Also added a SequenceMatcher syntax which tells you what is valid for a SequenceMatcher, rather than the full syntax.  It can be found here:
https://github.com/nishihatapalmer/byteseek/blob/master/sequencesyntax.md

Testing Plan
Preliminaries

Please perform the following tests on the full-dev vagrant environment.
Set an environment variable to indicate METRON_HOME:
export METRON_HOME=/usr/metron/0.4.0

Ensure Data Flows from the Indices
Ensure that with a basic full-dev we get data into the elasticsearch
indices and into HDFS.
(Optional) Free Up Space on the virtual machine
First, let's free up some headroom on the virtual machine.  If you are running this on a
multinode cluster, you would not have to do this.

Stop and disable Metron in Ambari
Kill monit via service monit stop
From ambari, stop the metron service
Kill the sensors via service sensor-stubs stop

Install and start pycapa
# set env vars
export PYCAPA_HOME=/opt/pycapa
export PYTHON27_HOME=/opt/rh/python27/root

# Install these packages via yum (RHEL, CentOS)
yum -y install epel-release centos-release-scl
yum -y install "@Development tools" python27 python27-scldevel python27-python-virtualenv libpcap-devel libselinux-python

# Setup directories
mkdir $PYCAPA_HOME && chmod 755 $PYCAPA_HOME

#Grab pycapa from git
cd ~
git clone https://github.com/apache/incubator-metron.git
cp -R ~/incubator-metron/metron-sensors/pycapa* $PYCAPA_HOME

# Create virtualenv
export LD_LIBRARY_PATH="/opt/rh/python27/root/usr/lib64"
${PYTHON27_HOME}/usr/bin/virtualenv pycapa-venv

# Build it
cd ${PYCAPA_HOME}/pycapa
# activate the virtualenv
source ${PYCAPA_HOME}/pycapa-venv/bin/activate
pip install -r requirements.txt
python setup.py install

# Run it
cd ${PYCAPA_HOME}/pycapa-venv/bin
pycapa --producer --topic pcap -i eth1 -k node1:6667

Ensure pycapa can write to HDFS

Ensure that /apps/metron/pcap exists and can be written to by the
storm user.  If not, then:

sudo su - hdfs
hadoop fs -mkdir -p /apps/metron/pcap
hadoop fs -chown metron:hadoop /apps/metron/pcap
hadoop fs -chmod 775 /apps/metron/pcap
exit

Start the pcap topology via $METRON_HOME/bin/start_pcap_topology.sh
Watch the topology in the Storm UI and kill the packet capture utility from before, when the number of packets ingested is over 3k.  Ensure that at at least 3 files exist on HDFS by running hadoop fs -ls /apps/metron/pcap

Note that if your MR job fails because of a lack of user directory for root, then the following will create the directory appropriately:
sudo su - hdfs
hadoop fs -mkdir /user/root
hadoop fs -chown root:hadoop /user/root
hadoop fs -chmod 755 /user/root
exit

Regression Test
Fixed

Run a fixed pcap query by executing a command similar to the following:

$METRON_HOME/bin/pcap_query.sh fixed --ip_dst_port 8080 -st "20170425" -df "yyyyMMdd"

Verify the MR job finishes successfully. Upon completion, you should see multiple files named with relatively current datestamps in your current directory, e.g. pcap-data-20160617160549737+0000.pcap
Copy the files to your local machine and verify you can them it in Wireshark. Open the files and ensure that they contain only packets to the destination port of 8080.

Stellar

Run a fixed pcap query by executing a command similar to the following:

$METRON_HOME/bin/pcap_query.sh query --query "ip_dst_port == 8080" -st "20170425" -df "yyyyMMdd"

Verify the MR job finishes successfully. Upon completion, you should see multiple files named with relatively current datestamps in your current directory, e.g. pcap-data-20160617160549737+0000.pcap
Copy the files to your local machine and verify you can them it in Wireshark. Open the files and ensure that they contain only packets to the destination port of 8080.

Binary Payload Search : Strings
Fixed

Run a fixed pcap query by executing a command similar to the following:

$METRON_HOME/bin/pcap_query.sh fixed --ip_dst_port 8080 --packet_filter "\`persist\`" -st "20170425" -df "yyyyMMdd"

Verify the MR job finishes successfully. Upon completion, you should see multiple files named with relatively current datestamps in your current directory, e.g. pcap-data-20160617160549737+0000.pcap
Copy the files to your local machine and verify you can them it in Wireshark. Open the files and ensure that they contain only packets to the destination port of 8080 and are api calls involving  /api/v1/persist/wizard-data in Ambari.

Stellar

Run a fixed pcap query by executing a command similar to the following:

$METRON_HOME/bin/pcap_query.sh query --query "ip_dst_port == 8080 && BYTEARRAY_MATCHER('\`persist\`', packet)" -st "20170425" -df "yyyyMMdd"

Verify the MR job finishes successfully. Upon completion, you should see multiple files named with relatively current datestamps in your current directory, e.g. pcap-data-20160617160549737+0000.pcap
Copy the files to your local machine and verify you can them it in Wireshark. Open the files and ensure that they contain only packets to the destination port of 8080 and are api calls involving  /api/v1/persist/wizard-data in Ambari.

Binary Payload Search : Hex Regex
Stellar
NOTE: To the astute reader, 0x1F90 in hex is 8080 in decimal

Run a fixed pcap query by executing a command similar to the following:

$METRON_HOME/bin/pcap_query.sh query --query "BYTEARRAY_MATCHER('1F90', packet) && BYTEARRAY_MATCHER('\`persist\`', packet)" -st "20170425" -df "yyyyMMdd"

Verify the MR job finishes successfully. Upon completion, you should see multiple files named with relatively current datestamps in your current directory, e.g. pcap-data-20160617160549737+0000.pcap
Copy the files to your local machine and verify you can them it in Wireshark. Open the files and ensure that they contain only packets to the destination port of 8080 and are api calls involving  /api/v1/persist/wizard-data in Ambari.

Yeah, no 0x for specifying the regex syntax.  I'll update the function docs to point to the syntax guide.  Also, I'm going to give a bit of a better effort at the testing too.  Good catches all around.

+1, pending Travis.  Was able to spin this up and full dev and everything worked as expected.  Thanks a lot for the contribution.


fix(): #455 flash message needs to be compatible with custom navbar/CSS (#522)

addresses https://github.com/restarone/violet_rails/issues/455

fix issue where flash message was not showing as expected for violet.restarone.solutions/challenge.restarone.solutions

tested on violet.restarone.solutions and challenge.restarone.solutions we see that the flash message is not clearing the navbar in the case of violet.restarone.solutions-- @alis-khadka


[Doc-enhancement][Meeting-details-APIs-CART-API]

Added CART API

Docs Build status updates of commit 58b6d14:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/apps-in-teams-meetings/API-references.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit 43ef29e:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/apps-in-teams-meetings/API-references.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit 747cd31:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/apps-in-teams-meetings/API-references.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit 1ffc450:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/apps-in-teams-meetings/API-references.md
:white_check_mark:Succeeded
View

msteams-platform/whats-new.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit 2a41cfe:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/apps-in-teams-meetings/API-references.md
:white_check_mark:Succeeded
View

msteams-platform/whats-new.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit 73f18e7:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/apps-in-teams-meetings/API-references.md
:white_check_mark:Succeeded
View

msteams-platform/whats-new.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/apps-in-teams-meetings/API-references.md
98
8
link
:white_check_mark:

msteams-platform/whats-new.md
89
40
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Docs Build status updates of commit a407a0a:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/apps-in-teams-meetings/API-references.md
:white_check_mark:Succeeded
View

msteams-platform/whats-new.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit df382f6:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/apps-in-teams-meetings/API-references.md
:white_check_mark:Succeeded
View

msteams-platform/whats-new.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit 6eb2d6b:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/apps-in-teams-meetings/API-references.md
:white_check_mark:Succeeded
View

msteams-platform/whats-new.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit d77b856:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/apps-in-teams-meetings/API-references.md
:white_check_mark:Succeeded
View

msteams-platform/whats-new.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/apps-in-teams-meetings/API-references.md
98
9
link
:white_check_mark:

msteams-platform/whats-new.md
89
40
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.


Splitting string literal

cannot split string literal into lines using a backslash, the norm just keeps increasing the cols counter of the first line by one.

Have you tried splitting the literal by just putting it in several literals together?
Like this:
#include <stdio.h>

int     main(void)
{
        printf("Hello "
                        "world\n");
        return (0);
}

I think it works that way, if you don't mind can you add this case to the norm pdf just to let other students know, thank u


Sequencer remember/forget with "eval" mode

Hi,
Recent changes to the Sequencer remember/forget mechanism introduced modes like "both" and "eval", which is very convenient. However, in "eval" mode, a forward step during evaluation will set the maximum number of BPTT steps (rho value) to the size of the input. Then, a subsequent epoch of training on a sequence of different size will fail in the backward step. Before the change, remember() worked fine.
The reason is probably the setting of rho in the recurrent module (in this case LSTM), which then causes the backward step during training to stop before reaching the beginning of the sequence. See LSTM:updateGradInputThroughTime().
Note: I know that the README says it is recommended to set mode="both" for LSTM, but I prefer the "eval" mode because each training example is independent. In any case, I suppose both modes should be possible for any AbstractRecurrent instance.
A minimal working example with LSTMs:
lstm = nn.LSTM(5,5)
seq = nn.Sequencer(lstm)
inputTrain = {torch.randn(5), torch.randn(5), torch.randn(5)}
inputEval = {torch.randn(5)}

modes = {'both', 'eval'}
for i, mode in ipairs(modes) do
  print('\nmode: ' .. mode)
  seq:remember(mode)

  -- do one epoch of training
  seq:training()
  seq:forward(inputTrain)
  seq:backward(inputTrain, inputTrain)

  -- evaulate
  seq:evaluate()
  seq:forward(inputEval)

  -- do another epoch of training
  seq:training()
  seq:forward(inputTrain)
  -- this will fail when mode = 'eval'
  seq:backward(inputTrain, inputTrain)
end

Could you look into that?
Many thanks for your help.

I love these corner cases. Looking into it.

fixed in https://github.com/Element-Research/rnn/commit/e1f0c5049b8c41ad952d7b252b74035987b4a02b . Thank you for the detailed bug report!

Thank you for the quick solution!

Hi,
I notice a strange problem when using the new version. Before the update of the new remember/forget mechanism, I was training a model with LSTMs (in a sequencer) and got good training behaviour: training error was continuously decreasing, validation error was decreasing for a while, then converging. After the update, I notice the training error stops decreasing after a couple of epochs and starts increasing.
I know this is a very high-level description, but do you have any idea what might have changed? I suspect there is a problem with the gradients, although all the tests pass.
Thanks for your help.

Let me start an LSTM experiment on PennTreeBank to see how it does.

Seems to work on my end. Do you have particular use case you want me to test? Like with remember('eval') with and LSTM?

Hi,
It's difficult to debug and narrow down the problem to a simple example, but I'll try.
The general symptom is that before the change I was seeing good convergence and decreasing training errors, and after the change I see the training error first decreasing, then increasing continuously.
I'll see if I can recreate the problem in a simple example.

Thanks boknilev.
Nicholas Léonard
917-741-7570
On Wed, Aug 5, 2015 at 4:57 PM, boknilev<EMAIL_ADDRESS>wrote:

Hi,
It's difficult to debug and narrow down the problem to a simple example,
but I'll try.
The general symptom is that before the change I was seeing good
convergence and decreasing training errors, and after the change I see the
training error first decreasing, then increasing continuously.
I'll see if I can recreate the problem in a simple example.
—
Reply to this email directly or view it on GitHub
https://github.com/Element-Research/rnn/issues/19#issuecomment-128146365
.

Hi,
I still can't track down the source of the problem. I did notice the following behaviour:
After the code update, my gradients are much larger than before (an order of magnitude larger). I believe the problem may be with some nn code update and not with rnn, because I tried reverting to a previous rnn version (by downloading the .lua files from the repo) and still had the problem.
Do you have any suggestion what might cause this behaviour?
Do you know how to revert back to a previous state of the nn package? I can't simply download .lua files from a previous repo version, because it also needs compilation, which I only know to do with "luarocks install nn",
Thanks for your help.

git clone git@github.com:torch/nn.git
cd nn
git checkout [commit hash]
luarocks make rocks/[tab]

Maybe you should try a smaller learning rate. What does your model look like?

Hi,
Thanks. I'll try that.
Yes, a smaller learning rate and larger dropout rate helps a bit. I still don't get as good performance as I had prior to the code update though.
It's an LSTM autoencoder for sentences, a la sequence-to-sequence learning. Model is roughly an LSTM in the encoder and an LSTM in the decoder, with dropout layers, and Softmax on the decoded words. Interface of encoder-decoder is currently by using the final output of the encoder as the first input to the decoder, although I'm aware of issue https://github.com/Element-Research/rnn/issues/16.

You really have to find an older version where your code was working. You could also try older versions of the rnn package if trying older versions of nn doesn't work.

Closing for now.


New feature: refining the points-based reward system

I want to improve the reward system.
First, my suggestion is to get rid of the rule « +1 point goes to the player whose card was chosen » because it does not make sense rewarding it.
Then, I propose the following changes in the current rules to rethink the initial reward system:
All players draw 5 white cards from their stack
Click the spinner to choose the first player who will be the Card Czar.
The Card Czar then pull a black « prompt » card and reads it to the group
All other players then put 1 white « response » card face down in their slot.
The Card Czar then flips and reads each white card out loud.
The Card Czar then picks one of the white cards for further discussion. The player whose card was chosen becomes the Secretary for this round.As the Secretary, the selected player does not participate in the ensuing debate but listens carefully.
After the discussion winds down (after a few minutes), the Secretary has 1 minute to summarize all the arguments made and present their own position based on the debate.
The other players then vote on whether the Secretary has been convincing. If the majority finds the summary and position convincing, the Secretary earns 1 point.
The next player becomes the Card Czar and clicks the “Deal” button. Each player then draws a new white card, so that they again have 5 cards in their hand.
This revision aims to encourage deeper engagement with the topics discussed and rewards players for actively listening, synthesizing arguments, and articulating a well-considered stance on the issue.

Is the debate based on the 'winning card's relevance'? Or is it everyone else justifying why their/another card is better, and the chosen Secretary gets to defend against arguments?

While the proposal aims to encourage more engaged participation and reward players for their contributions to the discussion, there are some aspects that could be contested.
Firstly, by eliminating the rule that automatically awards a point to the player whose card was chosen, there is a risk of reducing the incentive to propose creative and interesting responses. This rule may have been perceived as a reward for proposing a response that captured the attention of the Card Czar, thus encouraging player creativity.
Moreover, the appointment of a secretary may introduce biases into the selection process. Some players may not feel comfortable or qualified to effectively synthesize arguments and present a position, potentially skewing the outcome of the vote on their performance.
Lastly, the vote of other players on the persuasiveness of the secretary may be subject to biases or personal influences, which could compromise the fairness of the reward process.
In summary, while the proposal aims to enhance engagement and reward participation, it also carries potential risks in terms of creativity, impartiality, and fairness in the reward process.

@ca-lida I get your point. Indeed, my suggestion needs a bit more precisions. The winning car relevance is an important element to get the point (it is necessary in the process of being chosen by the card Czar).
As in the original game rules, the discussion is based on what could go wrong (!) based on the chosen card.
I guess I should have add a "reflection time" while each participant picks his card.


Remove packages and fix the VAnchor errors

Remove packages
Fix the commitment comparison in the leafCreatedAtBlock method of VAnchor class
Process from start to final block in the getDepositLeaves method of VAnchor class

Any chance we could add tests of these functions too @AtelyPham ? Also ts-check is failing

@drewstone Fixed the ts-check, I can add tests for these methods, but I want to focus on the dapp first. I can open an issue for this and add tests in subsequent PR. What do you think?

Sounds good @AtelyPham


Configuration for more than 255 clients

What Changes do i need to made if i want to make client files more than 255 users as /24 is for 255 users only.

make a new wg interface with new ip pool

check it out
https://github.com/ExtremeDot/ExDOT-WireGuard-Server


Calculate adjusted Near DAU for all of time

:pushpin: References
🎄 Asset Checklist

[ ] Added to databases.csv or already exists

🧮 Metric Checklist

[ ] Added new fact tables if necessary
[ ] Pulled fact table into ez_asset_metrics.sql table
[ ] Compiles in Github
[ ] Show Changed Models in Github matches expectations for what metric value should be

@akan72 5x-ing the time window to ~1 year increased the job time by ~10min (out of 1hr 20min). Thankfully it's sub-linear. NEAR data only goes back to 2020 anyway so about 4 years of data. Gonna run for all of time now.


Build(deps-dev): Bump @storybook/react from 6.4.4 to 6.4.5 (#2086)

Pull request opened by the merge tool on behalf of #2086

Merged in 8ffd55df0a95da06b600627bb57bd7e0a9e88635


Version 2.0

Version 2

[x] Move to PSR-7 (Guzzle 6) #27
[x] Consistent API with OAuth 2 client #28

This PR replaces #34.

Hi @bencorlett. Are you planning to merge this changes soon to develop or master? I am looking for the standard between both oauth1 and oauth2 client. Great work btw.

@ajibarra soon(ish), still working through the rewrite for v2 in my spare time. No real ETA as yet unfortunately. v1 is stable, just has an API that doesn't match the OAuth 2 client (it used to, but OAuth 2 has since moved forward and I'm catching up here).

@bencorlett you're making things happen! I'm happy to help out here and I don't want to impede your existing flow. If you can provide a deeper layer of detail about your current plan/thought process for the refactor, I can take care of some of the work.

#40 encapsulates a bit of refactoring that I've been wanting to do. I've moved a handful of methods that are factories or static in nature to appropriate classes and created new classes where appropriate.

Send arbitrary requests

This will be possible with the getAuthenticatedRequest method.
// The server provides a way to get an authenticated API request for
// the service, using the access token; it returns an object conforming
// to Psr\Http\Message\RequestInterface.
$request = $server->getAuthenticatedRequest(
    'GET',
    'http://your.service/endpoint',
    $tokenCredentials
);

$client = $server->getHttpClient();

$response = $this->getHttpClient()->send($request);

@bencorlett I see you are circling this project again. What are your thoughts on moving along this refactor? What is left to accomplish?

Good question!

I’ll do that today :)

On 23 Mar 2016, at 9:28 AM, Steven Maguire<EMAIL_ADDRESS>wrote:
@bencorlett https://github.com/bencorlett I see you are circling this project again. What are your thoughts on moving along this refactor? What is left to accomplish?
—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub https://github.com/thephpleague/oauth1-client/pull/35#issuecomment-200061675

Any ETA on v2 folks?

Any movement here?

Any idea when this will be finished? Guzzle 4 is also EOL now, and v1 is still requiring Guzzle 3.

I'm back actively spending time on this project and I'm hoping to have the final refactoring done from the feature/switch-to-phpspec branch merged in within the week to release a beta of v2.
Following that, we just need to add implementations for more OAuth2 Servers and then we are good tor release.

@bencorlett Not to put too much more pressure on you, but a patch for a security vulnerability was included in Guzzle 6.2.1. I'm assuming the vulnerability exists in all prior versions and that those versions won't receive patches. So, the sooner the switch to Guzzle 6 can happen, the better. 😄

Ooo, interesting. Could you please provide me with a link? I might see if I can also patch 1.x to run on a newer Guzzle as well without needing a major bump. Pretty sure we won't be modifying any public methods so it could be a patch version.
Sent from my iPhone
Please excuse my brevity

On 23 Mar. 2016, at 9:55 am, Ben Corlett<EMAIL_ADDRESS>wrote:
Good question!

I’ll do that today :)

On 23 Mar 2016, at 9:28 AM, Steven Maguire<EMAIL_ADDRESS>wrote:
@bencorlett I see you are circling this project again. What are your thoughts on moving along this refactor? What is left to accomplish?
—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub

@bencorlett Here's the site for the vulnerability: httpoxy.org. The Guzzle release notes I linked in my earlier comment include a related item.

@bencorlett I am still interested in helping to get this project moved up and out to 2.0. It seems like the current test suite configuration is causing some issues with CI. I've added some comments and would like some input and/or direction from you on how we should proceed.
I am happy to get some more work done here :)

Yoo-hoo @bencorlett

Progress on the project has kind of screamed to a halt. I did speak with @philsturgeon about having @stevenmaguire or somebody else equally keen to take over the lead. I would be more than happy for this, just unsure what his movements are and whether he is interested :)

On 5 Apr 2018, at 9:17 pm, Daniel Bannert<EMAIL_ADDRESS>wrote:
Do you need some help or is this project dead?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/thephpleague/oauth1-client/pull/35#issuecomment-378902186, or mute the thread https://github.com/notifications/unsubscribe-auth/AALGnyYUclxdV-plGuUXZqU_CXapsrF1ks5tlf08gaJpZM4FwWtN.

We had this conversation over a year ago @bencorlett so yeah I'd say the swap should happen! 😅
I'm not involved in the League anymore, so pester @frankdejonge or somebody to get this a new home.

I'm happy to take on more responsibility with this project. I'll need to get back up to speed a bit. I've been very involved in this last round of changes but it's been quite some time since my head has been in this space :)

Any update here? :) We have Guzzle 7 now with PHP 7.2+ support.

Another question of mine is: who uses OAUTH-1 nowadays?! Haven't whole world moved to OAUTH-2 already?

Twitter still uses oauth 1 only.

 :(

@GrahamCampbell , are you sure? https://developer.twitter.com/en/docs/authentication/oauth-2-0

Indeed, all the "real stuff" is still OAuth 1.0a => https://developer.twitter.com/en/docs/authentication/oauth-1-0a
(basically the most important stuff for serious Twitter interaction)

Yea. I know for sure almost noone will bother updating this package. Tech is too old to be of any value to anyone.
Maybe for the sake of moving forward, at Socialite side there should be new major version release with Oauth-1 and Twitter left behind. Otherwise everything will be stuck in past.

Can someone add me as a Member to this repo?

I need that to be able to stop Travis-CI runs which I know will fail. Waiting for them takes too long.

After spending 7-8 hours to refactor this codebase, I can say the following:

This codebase has very critical typing issues. Many methods can return totally unrelated, multiple types (sometimes int|string, sometimes object|string, even void|string as well).
For some reason it attempts to re-implement PHP's http_build_query() function and with errors at that.
Even after I completely refactored it, adding declare(strict_types=1) in all files is completely impossible. One of the main methods, sign() method attempts to use non-strings (booleans, nulls and similar) as strings, url-decoding and re-encoding them back and forth, which completely breaks the outcome. I attempted to add fixes there, but it was too much hassle to go through, so no PHP declarations for the moment.

Overall, even though there is Version-2 branch half-done, I'd strongly suggest actually redoing that work on top of my refactoring, also adding declare() s to files.


Unable to retrieve all documents from Azure Search Index

Package Name: azure-search-documents
Package Version:  11.6.0b3
Operating System: macOS 14.4.1 (23E224)
Python Version: 3.11.8

Describe the bug
Similar to issue mentioned in 31406.
Unable to retrive all documents from the Azure Search Index.
To Reproduce
Steps to reproduce the behavior:

Using the above mentioned versions of python SDK.
Below are the variants of the code

from azure.core.credentials import AzureKeyCredential
from azure.search.documents import SearchClient

search_endpoint: str = "your-endpoint"
search_api_key: str="your-key"
index_name: str="your-index"

credential = AzureKeyCredential(search_api_key)
search_client = SearchClient(endpoint=search_endpoint,
                      index_name=index_name,
                      credential=credential)

doc_count = search_client.get_document_count()
print(f'Index document count = {doc_count}')

results = search_client.search(search_text="*")
doc_set = set()
for result in results:
    id = result["key-attribute"]
    doc_set.add(id)
print(f'Unique documents in search output = {len(doc_set)}')

Another approach of doing the same thing
from azure.core.credentials import AzureKeyCredential
from azure.search.documents import SearchClient

search_endpoint: str = "your-endpoint"
search_api_key: str="your-key"
index_name: str="your-index"

credential = AzureKeyCredential(search_api_key)
search_client = SearchClient(endpoint=search_endpoint,
                      index_name=index_name,
                      credential=credential)

doc_count = search_client.get_document_count()
print(f'Index document count = {doc_count}')

results = search_client.search(search_text="*")
doc_set = set()

# Retrieve the documents in batches
top = 1000
skip = 0
all_documents = []

while len(all_documents) < doc_count:
    # Retrieve the next batch of documents
    results = search_client.search(search_text="*", skip=skip, top=top)
    all_documents.extend(list(results))

    # Update the skip value for the next batch
    skip += top

    print(f"Retrieved {len(all_documents)} out of {doc_count} documents")

for document in all_documents:
    print(document['key-attribute'])
    doc_set.add(document['key-attribute'])
print(f'Unique documents in search output = {len(doc_set)}')

Expected behavior
the Index document count and the Unique documents should be the same
Screenshots
Missing some documents in the search output. Below is an example of an index containing 4536 documents.
Index document count = 4536  Unique documents in search output = 4142
Additional context
If we use CURL and get the result in batches it works fine.

This is the service behavior. Please open a service ticket for it.

Can you elaborate on what you mean by service behavior and where does the ticket need to be opened ?


#4 Push built in CSS and JS frameworks

We are using the Materialize Framework (https://materializecss.com/).

Complete!


Merge develop into main

Codecov Report
Attention: Patch coverage is 11.11111% with 16 lines in your changes are missing coverage. Please review.

Project coverage is 42.24%. Comparing base (de7515c) to head (93aea10).
Report is 1 commits behind head on main.

Files
Patch %
Lines

src/transaction/deserialize.c
11.11%
16 Missing :warning:

Additional details and impacted files
@@             Coverage Diff             @@
##             main      #15       +/-   ##
===========================================
- Coverage   63.46%   42.24%   -21.23%
===========================================
  Files          13        5        -8
  Lines         802      419      -383
===========================================
- Hits          509      177      -332
+ Misses        293      242       -51

Flag
Coverage Δ

unittests
42.24% <11.11%> (-21.23%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


HSTS preload test fails on subdomains?

Version: 1.2.1
If my understanding of the spec isn't deserting me, the preload statement in the HSTS header is only relevant for requests to the apex, such as https://hsts.example/, and not for subdomains, since subdomains cannot be preloaded. This means that, for something like https://subdomain.hsts.example/, the following should pass;
strict-transport-security: max-age=63072000

as long as hsts.example has the proper header set, like this;
strict-transport-security: max-age=63072000; includeSubDomains; preload

This probably goes for the includeSubDomains test as well?
Example: ipv4.ur.nl currently fails those two tests;
[FAIL] HSTS Header should have includeSubdomains (max-age=63072000)
[FAIL] HSTS Header should have preload (max-age=63072000)

Oh, and minor niggle; example.com is a second-level domain, not first level 😄
https://en.wikipedia.org/wiki/Second-level_domain
Example:
Domain: ipv4.ur.nl, Domain (no path): ipv4.ur.nl, First Level Domain: ur.nl

Oh, and minor niggle; example.com is a second-level domain, not first level 😄

🤦♂
FYI: that term came from the tld library that I'm using.

These checks were not really designed with subdomains in mind. Working with subdomains while keeping the tool dependency free is tricky. Plus the number of requests this tool makes is increasing and always in the back of my mind.

preload I agree should only be present on the second-level domain, and I will update the check to reflect that soon (just need to think about how to determine if it's a second-level domain or not)
includeSubdomains I believe can exist on subdomains (to indicate that subdomains of that subdomain require HTTPS) but that also means that we should check all parent domains for the header before marking this as a failure.

I'll work on both of these at some point soon.

You can use the publicsuffix2 module for this;
https://pypi.org/project/publicsuffix2/
This uses the Public Suffix List maintained by Mozilla, and allows you to distinguish between, say, example.com and example.co.uk with just a few lines of code.
Also incorporates usage with domains where subdomains are individual users, such as 'github.io' and the like, so for some subdomains it may require an extra logic that I have not had to deal with before 🤔

I forgot to write this up yesterday, but this is done and should be working in v1.5.0.
The behaviour is documented on the release, but to put it here too:

HSTS checks have been updated to behave better when testing a subdomain

Check the second-level domain when checking for preload (subdomains cannot be submitted)
If the includeSubdomains check fails it will attempt to check the second-level domain

Feel free to reopen this if it doesn't handle your use case properly.

Nice, thanks! 🙂
[ OK ] HSTS Header should have includeSubDomains (max-age=63072000; includeSubDomains; preload (from apex domain))
[ OK ] HSTS Header should have preload and includeSubDomains (max-age=63072000; includeSubDomains; preload (from apex domain))


pilot-discovery --registries=Mock not working

I am trying to follow the example setup given at istio/tools/packaging/deb_test.sh. But when I tried to start pilot-discovery discovery service, it complained about:
2022-09-08T11:55:03.629786Z     info    Adding Mock registry adapter
2022-09-08T11:55:03.629855Z     error   failed to create discovery service: error initializing service controllers: service registry Mock is not supported
From the error message, it seemed that the instructions given are no long valid. is there any alternative? or maybe the instructions need to be updated to explicitly clarify that Mock is not supported.

Instead of using latest image gcr.io/istio-testing/pilot:latest or istio/pilot:1.15.0-debug@sha256:0db0d47671b03387667d5bc8583dff59ccd64a6dd67b3641a319d6638e1e2eed, i switched to istio/pilot:1.14.3-debug, now pilot-discovery service started successfully.


Where does the oarfish-installer.sh come from?

I was trying to see what the installer script is like before running it - but I couldn't find it in the repo. Where does it come from?
I'm talking about this script:
https://github.com/COMBINE-lab/oarfish/releases/download/v0.5.1/oarfish-installer.sh

Hi @corneliusroemer,
Thanks for the question!  This is generated by cargo-dist which we use as part of our release management cycle.  It generates the pre-compiled binaries, as well as the installer script to download them for the appropriate architecture from the github releases page.
You can find out all of the cargo-dist details in their GitHub repo. It's an (awesome) open-source tool that really helps make releasing rust projects easier.
Best,
Rob


Tolerate incorect date-time while API platform fix PPNS API

Probably fix the above too -- but yes, you're right, the model wasn't tested but I should do that.

I've fixed the tests and formatting.
I'm not going to worry about the PR commenter for now. This isn't a service that's even on the environments, and we need this in quickly and not mess about updating Scala and various other things that can go wrong. I suggest we just do the minimum we need to do on this for now.


Add composer, contributor credits

There should be composer/lyrics/etc. credits, both at an album and per-track level.

Unfortunately the tags for that are a complete mess and no players seem to support it. In the meantime I added cover-of which tries to do the right thing on both mp3 and vorbis tags (although the vorbis tags work in a way which players, big surprise, don't support correctly), and this is why we can't have nice things.
Anyway, fixed-ish in 61a75436ef401ee8b56182c0baaa524db387f329.


Set Swift bridging header location

Fixes #31 by setting the Swift bridge header location to the Objective-C
output header location.

I do not think that the current change will break anything, it is a header and it will be found , since it is there where the other headers that needs to be found are. So that's fine.
Yes, of course should that be in docs, change log management is still something on the todo list (pls a list of resolved issues and PRs since the last release)

I'm not sure if we are talking about the same thing regarding documentation. What I meant was that it should be documented here in the docs https://djinni.xlcpp.dev/djinni-generator/cli-usage/#objective-c and in the output of djinni --help where the header file is created (in --objc-header-out)

Ah, thanks Johan, good catch!
You should un approve until I have updated the docs ...  so I do not accidental merge this PR


UI change

https://github.com/gregdavill/KiBuzzard/pull/8
Arturo has made a UI + Command Line when we click on plugin. Is there easy way to change files on his version so we can get his UI working with 5.1.9?

@iharshadec Yes this can be done. I'll try to merge it my freetime. A bit busy these days.

@VedantParanjape
The version https://github.com/VedantParanjape/KiBuzzard/tree/wip-gui-change worked on Linux, but not on Win10.
A few hours ago I was able to make it work on Win10 my cherry-picked version and I will look into why your version to see why it did not work on Win10.

@iharshadec
I am working on this as time permits.

@iharshadec Please check the latest version, I have incorporated changes by @DCelectronics

@iharshadec Please check the latest version, I have incorporated changes by @DCelectronics

Right now I have @DCelectronics copy working. Today I will replace it with this master branch and update you if this works directly or not. BTW @gregdavill is also working on something that works with KiCad in-built 2.7 as well.

I will close this issue now


SamAutomaticMaskGenerator

May I ask if there is a function to obtain all the masks, similar to the SamAutomaticMaskGenerator in SAM?

Hi, you can refer to the discussion in a previous issue. Thanks.


Azure Voice Mail licensing

Is SfB Plan 1 / Plan 2 or Microsoft Phone System license required for Azure Voice Mail? Is it sufficient if the SfB Onprem user has SfB Enterprise CAL Plus license?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 6e342c08-c1d8-8c1d-944d-d6489a17c42b
Version Independent ID: 5c9987d5-4c98-8115-55c8-f629dbd25799
Content: Plan Cloud Voicemail service
Content Source: Skype/SfBServer2019/hybrid/plan-cloud-voicemail.md
Product: skype-for-business-itpro
GitHub Login: @CarolynRowe
Microsoft Alias: crowe

@joaoalhinho - Thank you for submitting feedback.
I think the best way forward is if you can open a service ticket in your tenant so you can get your answer ASAP. Based on the outcome, let me know if it is something that can be called out in the docs.
Here is a quick video on opening a ticket: https://www.youtube.com/watch?v=puuOy0sEg1Y
If you don't mind, please keep us posted here on the resolution, as I really want to get this information you are discovering back into the docs.


didn't relable the id

hi xiaotong:
i change some place in the code in https://github.com/Cysu/open-reid/blob/master/reid/utils/data/dataset.py
        self.meta = read_json(osp.join(self.root, 'meta.json'))         identities = self.meta['identities']         self.train = _pluck(identities, train_pids, relabel=True)         self.val = _pluck(identities, val_pids, relabel=True)         self.trainval = _pluck(identities, trainval_pids, relabel=True)         self.query = _pluck(identities, self.split['query'])         self.gallery = _pluck(identities, self.split['gallery'])         self.num_train_ids = len(train_pids)         self.num_val_ids = len(val_pids)         self.num_trainval_ids = len(trainval_pids)
i change the" relabel=True" to" relabel=False" and  the errors occured when i run the code .dubug the code i find the paremeters show "unable to get repr for ..."when compute the loss at
    def _forward(self, inputs, targets):          outputs = self.model(*inputs)          if isinstance(self.criterion, torch.nn.CrossEntropyLoss):                loss = self.criterion(outputs, targets)                prec, = accuracy(outputs.data, targets.data)                prec = prec[0]
i didn't find why the error occur ,can you help  @Cysu  @wk910930  @zydou

Hi @Linranran :
In the code we can see that:
https://github.com/Cysu/open-reid/blob/5db4f6b4245b8b24073f19c161a3b869121a1d2c/reid/utils/data/dataset.py#L18-L21
relabel=True makes the pids continuous from 0 to the total number of persons in the datasets(or subsets).
If you change relabel=True to relabel=False, the pids will be the real id according to the original datasets.
In the training progress at here:
https://github.com/Cysu/open-reid/blob/5db4f6b4245b8b24073f19c161a3b869121a1d2c/reid/trainers.py#L69-L72
the variable outputs is a tensor which the size is B * C and targets is a tensor which the size is B, where B is minibatch size and C is number of classes.
C is defined at here:
https://github.com/Cysu/open-reid/blob/5db4f6b4245b8b24073f19c161a3b869121a1d2c/examples/softmax_loss.py#L89-L90
and used to create the model:
https://github.com/Cysu/open-reid/blob/5db4f6b4245b8b24073f19c161a3b869121a1d2c/reid/models/resnet.py#L58
Let's take Market1501 for example:
If relabel=True:
outputs is B * 751, because the trainval dataset contains 751 persons. targets is pids which ranges from 0 to 750.
If relabel=False:
outputs is B * 751 but targets is ranging from 2 to 1500.( targets is the real id according to the original datasets)
From the PyTorch official docs about CrossEntropyLoss:

The input is expected to contain scores for each class.
input has to be a 2D Tensor of size (minibatch, C).
This criterion expects a class index (0 to C-1) as the target for each value of a 1D tensor of size minibatch

So it will raise an error when you use CrossEntropyLoss because the targets is exceeded index (0 to C-1).

@zydou Thank you so much for your detailed explaination. I really appreciate it.


SASS / SCSS @Error Issue

Hi,
I am uses VS 16.5.5 and inside a SCSS document and have created a mixin. All I am doing is setting a property depending on a true / false value passed to it and checking the value is correct using an if, else if, else statement. In that else statement I am using the @error directive.
The error I keep getting is
    @if $yes-no == false {
        $yes-no: none;
    }

    @else if $yes-no == true {
        $yes-no: inherit;
    }

    @else {
        @error "Some Message Here";
    }

and receiving this error:
Validation (CSS 4.0): "error" is not a known '@' directive.
Of course it's not in the directive list and I think it's a bug within VS. If VS supports SASS / SCSS then should support the syntax, too.
I do not wish to change

This is the issue tracker for VS Code, not VS.
I tried your sample in VS Code and it works. Please file the issue against VS


VS2015 Execute MSBuild InlineTask

Hello,
I'm trying to run this simple inline task at the end of njsproj file without success:
<UsingTask TaskName="Hello2" TaskFactory="CodeTaskFactory" AssemblyName="Microsoft.Build.Tasks.v12.0" >
  <ParameterGroup />
  <Task>
    <Code Type="Fragment" Language="cs">
      Log.LogMessage("Hello, world!", MessageImportance.High);
    </Code>
  </Task>
</UsingTask>
<Target Name="TestBuild" BeforeTargets="Build">
  <Hello2 />
  <Message Text="hello message" Importance="high"/>
</Target>

I get the error MSB4175, but even if I copy the dll to MSBuild 12.0 folder, the task is unable to run.
I'm using VS2015, but I think the problem occurs in VS2013 too.
Thanks in advance for your help.

Not sure this is NTVS specific. While I'm not too familiar with msbuild and tasks, but was able to get this working by changing the line: AssemblyName="Microsoft.Build.Tasks.v12.0" to read AssemblyName="$(MSBuildToolsPath)\Microsoft.Build.Tasks.v12.0"
If anyone is still running into this problem, give that a shot.
Sorry for the delay getting around to this.


[BUG] chemical reactor need more input hatch

[Please fill out the form below and delete the sections in square brackets after reading them]
Version of Advanced Rocketry

1.16.5-2.0.0-12-universal

Why is this important?
Knowing the version of Advanced Rocketry helps us narrow down an offending piece of code faster because we can easily determine what code is added and when.]

Have you verified this is an issue in the latest unstable build
[x] Y

[Why is this important?
If you're not testing with the latest build, you may be encountering a bug that's already been fixed.
Reporting bugs that have already been fixed wastes everyone's time.  (please look in open issues too, somebody else could have already reported it!)]

Version of LibVulpes

1.16.5-1.0.2-25-universal

Why is this important?
Advanced rocketry depends on a library mod (LibVulpes), some errors can really be in that mod.  So knowing the verison helps us not only start looking for fixes there without you needing to anwer more questions, it also helps us know if you have a version mismatch.]

Version of Minecraft

1.16.5

Why is this important?
Different versions of minecraft have different codebases for Advanced Rocketry.  Knowing the version of minecraft (and thus AR) helps us pinpoint issues quicker!]

Does this occur without other mods installed
Y

If Y, what is the MINIMUM set of mods required.

[Why is this important?
Sometimes interactions between mods cause issues.  While it can be a problem with Advanced Rocketry, sometimes it's not.  When there are a lot of mods, it can take bugtesters HOURS to go through the list to determine the root cause.  When there are a lot of bug reports, that can add DAYS to the time it takes to fix a large set of issues.]

Crash report or log or visualVM (if applicable)
http://pastebin.com is a good place to put them
crash reports that are put in the issue itself are
hard to read

no crash

If it's an issue involving lag, please submit a visualVM sampler snapshot.  Mods like lag goggles often do not provide the kind of information needed to debug lag.
For more information on how to create a snapshot, please see "How to Run CPU Sampling" here.  Then export the snapshot as an .nps.  You may have to zip it since github is weird, then please upload it here.

Why is this important?
Full crashlogs contain valuable information like where exactly in the code the error occurred, what other mods may be running and what version of forge you have.  This helps us replicate and diagnose the issue FAR faster.]

Description of the problem

Netherite Chestplate needs other 4 item to make it airtight seal,but input hatch only has 4 slot

Why is this important?
If we cannot reproduce the problem, we probably cannot fix it at all.]

Fixed in latest


[BEAM-14171] More explicit asserts in CoGBKResult.

Ensure this is invoked in case asserts are not enabled in the worker.

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Choose reviewer(s) and mention them in a comment (R: @username).
[ ] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

R: @nielm Could you let me know if this looks good to you?

R: @nielm Could you let me know if this looks good to you?

Confirmed that this resolves the issue in my test repro code, and also in my 'real world' pipeline.

Thanks.

org.apache.beam.runners.fnexecution.control.RemoteExecutionTest.testSplit seems to be flaking again.


Trailing line comments in indented code block are deleted by snakefmt 0.7.0

Another serious bug: In an indented if block, trailing line comments with # are deleted:
Start:
if config.get("s3_dst"):

    include: "workflow/snakemake_rules/upload.smk"
    include: "workflow/snakemake_rules/trigger.smk"
    # Only include rules for trigger if uploading files since the trigger
    # rules depend on the outputs from upload.

After formatting
if config.get("s3_dst"):

    include: "workflow/snakemake_rules/upload.smk"
    include: "workflow/snakemake_rules/trigger.smk"

# Only include rules for trigger if uploading files since the trigger
# rules depend on the outputs from upload.

After another formatting:
if config.get("s3_dst"):

    include: "workflow/snakemake_rules/upload.smk"
    include: "workflow/snakemake_rules/trigger.smk"

Workaround: put comment at the beginning of the code block
if config.get("s3_dst"):

    # Only include rules for trigger if uploading files since the trigger
    # rules depend on the outputs from upload.
    include: "workflow/snakemake_rules/upload.smk"
    include: "workflow/snakemake_rules/trigger.smk"
    include: "workflow/snakemake_rules/trigger.smk"

This bug still exists after v0.8.0 sorry. We'll try and get to it soon

This is resolved in v0.8.0 from my testing

Excellent, thank you so much! This appears to be fixed in 0.8 indeed in my tests.


[syn/otbn/aes] Add block-level OTBN synthesis and fix AES synthesis

This fixes the AES block-level synthesis environment and adds a block-level synthesis environment for OTBN.
Signed-off-by: Michael Schaffner<EMAIL_ADDRESS>

Indeed, there is nothing special to these constraints at the moment.


Cors issue with webserver

[ x] I have read the FAQ.

Describe the bug
[A clear and concise description of what the bug is.]
Cors error with the default configuration.
Errors
Fetch error
NetworkError when attempting to fetch resource. http://bar-assistant:3000/api/server/openapi
Fetch error
Possible cross-origin (CORS) issue? The URL origin (http://bar-assistant:3000) does not match the page (http://<ipaddress>:3000). Check the server returns the correct 'Access-Control-Allow-*' headers.

To Reproduce
[If possible, steps to reproduce the behavior.]
I followed the documentation to setup with the following docker compose:
  meilisearch:
    image: getmeili/meilisearch:v1.0
    environment:
      - MEILI_MASTER_KEY=$MEILI_MASTER_KEY
      - MEILI_ENV=production

    restart: unless-stopped
    volumes:
      - ${USERDIR}/docker/meilisearch:/meili_data
  redis:
    image: redis
    environment:
      - ALLOW_EMPTY_PASSWORD=yes
    restart: unless-stopped
  bar-assistant:
    image: barassistant/server:latest
    depends_on:
      - meilisearch
      - redis
    networks:
      - default
    environment:
      - APP_URL=$API_URL
      - LOG_CHANNEL=stderr
      - MEILISEARCH_KEY=$MEILI_MASTER_KEY
      - MEILISEARCH_HOST=$MEILISEARCH_URL
      - REDIS_HOST=redis
      - ALLOW_REGISTRATION=true
    restart: unless-stopped
    volumes:
      - ${USERDIR}/docker/barassistant:/var/www/cocktails/storage/bar-assistant

  salt-rim:
    image: barassistant/salt-rim:latest
    depends_on:
      - bar-assistant
    environment:
      - API_URL=$API_URL
      - MEILISEARCH_URL=$MEILISEARCH_URL
      - BAR_NAME=$BAR_NAME
      - DESCRIPTION=$BAR_DESCRIPTION
      - DEFAULT_LOCALE=en-US
    restart: unless-stopped
    networks:
      - default
  webserver:
    image: nginx:alpine
    restart: unless-stopped
    ports:
      - 3000:3000 #
    volumes:
      - ${USERDIR}/docker/bar-webserver/nginx.conf:/etc/nginx/conf.d/default.conf

My files look like:
#.env
# Your Meilisearch master key
# Find out more here: https://docs.meilisearch.com/learn/getting_started/quick_start.html#securing-meilisearch
MEILI_MASTER_KEY=<key>
# Base URL of the application
# You should update this value to the one you are using (ex: http://<IP_ADDRESS>, https://my-personal-bar.com)
# In this case it's the URL and port that is exposed in webserver service
# The value MUST be without trailing slash
BASE_URL=http://ipaddress:3000

# Meilisearch server instance URL, change if you are using different host from base url, otherwise leave as default
MEILISEARCH_URL=http://meilisearch:7700

# Bar Assistant server instance URL, change if you are using different host from base url, otherwise leave as default
API_URL=${BASE_URL}/bar

# (Optional) Bar name
BAR_NAME=Cool Bar

# (Optional) Short bar description
BAR_DESCRIPTION=Cool Descrip

#nginx.conf
server {
    listen 3000 default_server;
    listen [::]:3000 default_server;
    server_name _;

    location = /favicon.ico { access_log off; log_not_found off; }
    location = /robots.txt  { access_log off; log_not_found off; }

    client_max_body_size 100M;

    location /bar/ {
        proxy_pass http://bar-assistant:3000/;
    }

    location /search/ {
        proxy_pass http://meilisearch:7700/;
    }

    location / {
        proxy_pass http://salt-rim:8080/;
    }
}

Versions:

Docker: 23.0.6, run with docker version
Browser (if applicable) [e.g. chrome, safari] - All edge and firefox

Hello.
Your salt-rim instance should try to send requests to <your-url>/bar/api.
Seems like your config files are not setup correctly.
Are you using the config from https://bar-assistant.github.io/docs/setup/ since it seems you made some changes:

In you compose MEILISEARCH_HOST=$MEILISEARCH_URL should be MEILISEARCH_HOST=http://meilisearch:7700
In your .env there should be MEILISEARCH_URL=${BASE_URL}/search

When modifying the default configuration, the only things you really need to change are volume configuration and .env base url.

The swagger preview is broken atm. If you need schema information you can check the specification here: https://github.com/karlomikus/bar-assistant/tree/master/docs


Invalid syntax in the latest repo

Hi, when I tried to run the example.py with the latest repo, I ran into this issue:
Traceback (most recent call last):
File "/home/chenc/dreamerv3_new/example.py", line 4, in
import dreamerv3
File "/home/chenc/dreamerv3_new/dreamerv3/init.py", line 1, in
from .agent import Agent
File "/home/chenc/dreamerv3_new/dreamerv3/agent.py", line 4, in
import embodied
File "/home/chenc/dreamerv3_new/embodied/init.py", line 7, in
from . import replay
File "/home/chenc/dreamerv3_new/embodied/replay/init.py", line 1, in
from .replay import Replay
File "/home/chenc/dreamerv3_new/embodied/replay/replay.py", line 12, in
from . import selectors
File "/home/chenc/dreamerv3_new/embodied/replay/selectors.py", line 88
segment = prob[*path]
^
SyntaxError: invalid syntax
Could someone help me with this issue? I would be very grateful.

What's your Python version? Can you try running with a newer version?

I just installed Python 3.11. And everything looks fine with the new version now. Thanks


[material-ui][TextField] Fix id being passed to HTML input instead of root div

Fixes #42951

Wait, please check the older GitHub issue about this.

The id was designed to apply on the <input> in <InputBase id={id} />

I know that. It's about the difference between inputProps/slots.htmlInput and InputProps/slots.input. Props passed through InputProps are for the root div, so id passed through it is for the root div, not the HTML input. The custom id passed through inputProps is for the HTML input, not the root div.

Props passed through InputProps are for the root div

To me, it should be "Props passed through InputProps are for the InputBase element."


Fade Transition Between Screens

faded transition between screen means when we change screen from one to another it will fade out and fade in with another screen?
i wanna take it, please assign me

Yeah, @AyushRajSharma. Assigning it to you.

i want jetbrains license or activation key or activated jetbrains credentials for markdown navigator in existing app to get all dependencies install in android studio,
please help me,
thanks.

@AyushRajSharma There is no need for this plugin for this issue. Check this for fade transition: https://medium.com/flutter-community/everything-you-need-to-know-about-flutter-page-route-transition-9ef5c1b32823

Ok I will make PR soon.

@AyushRajSharma Any update?

i have created this gif with 3 sec duration of screen transition to see the animation.
i hope you want like this.

we can also use other type of animation like
fade,
rightToLeft,
leftToRight,
upToDown,
downToUp,
scale,
rotate,
size,
rightToLeftWithFade,
leftToRightWithFade
by single change of pageTransitionType.
i hope this will close the issue,
thanks

Hey, can I work on this issue?

Hey, can I work on this issue?

Sure, @Saransh-cpp

Sure, @Saransh-cpp


AZure CLI2 Released

@jomolnar Please review this change.

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot

@AftabAnsari10662 : Thanks for your contribution to the Azure documentation! The author, @cephalin, has been notified to review your proposed change.

@jomolnar Request you to review the PR.

@AftabAnsari10662 @cephalin is the author who will review the changes. Thanks.

@AftabAnsari10662, thanks for signing the contribution license agreement. We will now validate the agreement and then the pull request.
Thanks, Microsoft Pull Request Bot

@AftabAnsari10662 Thanks! #sign-off


Update using-monos-serial-port.md

Additional tutorial steps added to help beginners configure minicom for use with Mono.

Most of the changed have been applied manually. Also, to keep the documentation brief, we dont want to add too much docs on minicom itself.