Stop disabling fallthrough in integration tests

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: howardjohn
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

tests/integration/pilot/OWNERS [howardjohn]
tests/integration/security/OWNERS [howardjohn]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@howardjohn: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/integ-pilot-k8s-presubmit-tests.sh
707b01b410f25d95490a770218ca394572ae718e
link
/test integ-pilot-k8s-presubmit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: howardjohn, yangminzhu
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

tests/integration/pilot/OWNERS [howardjohn]
tests/integration/security/OWNERS [howardjohn,yangminzhu]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@howardjohn: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/integ-pilot-k8s-presubmit-tests.sh
707b01b410f25d95490a770218ca394572ae718e
link
/test integ-pilot-k8s-presubmit-tests-master

prow/integ-security-k8s-presubmit-tests.sh
707b01b410f25d95490a770218ca394572ae718e
link
/test integ-security-k8s-presubmit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

The tests failing are not due to this, see https://github.com/istio/istio/pull/14613. Known flakes

New changes are detected. LGTM label has been removed.

@howardjohn: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/integ-security-k8s-presubmit-tests.sh
707b01b410f25d95490a770218ca394572ae718e
link
/test integ-security-k8s-presubmit-tests-master

prow/integ-pilot-k8s-presubmit-tests.sh
734a666692f06708b6f76d4e5224f6b2a9009409
link
/test integ-pilot-k8s-presubmit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/integ-security-k8s-presubmit-tests.sh
707b01b410f25d95490a770218ca394572ae718e
link
/test integ-security-k8s-presubmit-tests-master

prow/integ-pilot-k8s-presubmit-tests.sh
734a666692f06708b6f76d4e5224f6b2a9009409
link
/test integ-pilot-k8s-presubmit-tests-master

prow/integ-telemetry-k8s-presubmit-tests.sh
734a666692f06708b6f76d4e5224f6b2a9009409
link
/test integ-telemetry-k8s-presubmit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/integ-security-k8s-presubmit-tests.sh
707b01b410f25d95490a770218ca394572ae718e
link
/test integ-security-k8s-presubmit-tests-master

prow/integ-pilot-k8s-presubmit-tests.sh
734a666692f06708b6f76d4e5224f6b2a9009409
link
/test integ-pilot-k8s-presubmit-tests-master

prow/integ-telemetry-k8s-presubmit-tests.sh
734a666692f06708b6f76d4e5224f6b2a9009409
link
/test integ-telemetry-k8s-presubmit-tests-master

prow/e2e-bookInfoTests-trustdomain.sh
734a666692f06708b6f76d4e5224f6b2a9009409
link
/test e2e-bookInfoTests-trustdomain-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/integ-security-k8s-presubmit-tests.sh
707b01b410f25d95490a770218ca394572ae718e
link
/test integ-security-k8s-presubmit-tests-master

prow/integ-pilot-k8s-presubmit-tests.sh
734a666692f06708b6f76d4e5224f6b2a9009409
link
/test integ-pilot-k8s-presubmit-tests-master

prow/integ-telemetry-k8s-presubmit-tests.sh
734a666692f06708b6f76d4e5224f6b2a9009409
link
/test integ-telemetry-k8s-presubmit-tests-master

prow/e2e-bookInfoTests-trustdomain.sh
734a666692f06708b6f76d4e5224f6b2a9009409
link
/test e2e-bookInfoTests-trustdomain-master

prow/integ-istioctl-k8s-presubmit-tests.sh
734a666692f06708b6f76d4e5224f6b2a9009409
link
/test integ-istioctl-k8s-presubmit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/integ-security-k8s-presubmit-tests.sh
707b01b410f25d95490a770218ca394572ae718e
link
/test integ-security-k8s-presubmit-tests-master

prow/integ-pilot-k8s-presubmit-tests.sh
734a666692f06708b6f76d4e5224f6b2a9009409
link
/test integ-pilot-k8s-presubmit-tests-master

prow/integ-telemetry-k8s-presubmit-tests.sh
734a666692f06708b6f76d4e5224f6b2a9009409
link
/test integ-telemetry-k8s-presubmit-tests-master

prow/e2e-bookInfoTests-trustdomain.sh
734a666692f06708b6f76d4e5224f6b2a9009409
link
/test e2e-bookInfoTests-trustdomain-master

prow/integ-istioctl-k8s-presubmit-tests.sh
734a666692f06708b6f76d4e5224f6b2a9009409
link
/test integ-istioctl-k8s-presubmit-tests-master

prow/e2e-dashboard.sh
734a666692f06708b6f76d4e5224f6b2a9009409
link
/test e2e-dashboard-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/integ-security-k8s-presubmit-tests.sh
707b01b410f25d95490a770218ca394572ae718e
link
/test integ-security-k8s-presubmit-tests-master

prow/integ-pilot-k8s-presubmit-tests.sh
734a666692f06708b6f76d4e5224f6b2a9009409
link
/test integ-pilot-k8s-presubmit-tests-master

prow/integ-telemetry-k8s-presubmit-tests.sh
734a666692f06708b6f76d4e5224f6b2a9009409
link
/test integ-telemetry-k8s-presubmit-tests-master

prow/e2e-bookInfoTests-trustdomain.sh
734a666692f06708b6f76d4e5224f6b2a9009409
link
/test e2e-bookInfoTests-trustdomain-master

prow/integ-istioctl-k8s-presubmit-tests.sh
734a666692f06708b6f76d4e5224f6b2a9009409
link
/test integ-istioctl-k8s-presubmit-tests-master

prow/e2e-dashboard.sh
734a666692f06708b6f76d4e5224f6b2a9009409
link
/test e2e-dashboard-master

prow/integ-framework-k8s-presubmit-tests.sh
734a666692f06708b6f76d4e5224f6b2a9009409
link
/test integ-framework-k8s-presubmit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/integ-security-k8s-presubmit-tests.sh
707b01b410f25d95490a770218ca394572ae718e
link
/test integ-security-k8s-presubmit-tests-master

prow/integ-pilot-k8s-presubmit-tests.sh
734a666692f06708b6f76d4e5224f6b2a9009409
link
/test integ-pilot-k8s-presubmit-tests-master

prow/integ-telemetry-k8s-presubmit-tests.sh
734a666692f06708b6f76d4e5224f6b2a9009409
link
/test integ-telemetry-k8s-presubmit-tests-master

prow/e2e-bookInfoTests-trustdomain.sh
734a666692f06708b6f76d4e5224f6b2a9009409
link
/test e2e-bookInfoTests-trustdomain-master

prow/integ-istioctl-k8s-presubmit-tests.sh
734a666692f06708b6f76d4e5224f6b2a9009409
link
/test integ-istioctl-k8s-presubmit-tests-master

prow/e2e-dashboard.sh
734a666692f06708b6f76d4e5224f6b2a9009409
link
/test e2e-dashboard-master

prow/integ-framework-k8s-presubmit-tests.sh
734a666692f06708b6f76d4e5224f6b2a9009409
link
/test integ-framework-k8s-presubmit-tests-master

prow/integ-mixer-k8s-presubmit-tests.sh
734a666692f06708b6f76d4e5224f6b2a9009409
link
/test integ-mixer-k8s-presubmit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/integ-pilot-k8s-presubmit-tests.sh
734a666692f06708b6f76d4e5224f6b2a9009409
link
/test integ-pilot-k8s-presubmit-tests-master

prow/integ-telemetry-k8s-presubmit-tests.sh
734a666692f06708b6f76d4e5224f6b2a9009409
link
/test integ-telemetry-k8s-presubmit-tests-master

prow/e2e-bookInfoTests-trustdomain.sh
734a666692f06708b6f76d4e5224f6b2a9009409
link
/test e2e-bookInfoTests-trustdomain-master

prow/integ-istioctl-k8s-presubmit-tests.sh
734a666692f06708b6f76d4e5224f6b2a9009409
link
/test integ-istioctl-k8s-presubmit-tests-master

prow/e2e-dashboard.sh
734a666692f06708b6f76d4e5224f6b2a9009409
link
/test e2e-dashboard-master

prow/integ-framework-k8s-presubmit-tests.sh
734a666692f06708b6f76d4e5224f6b2a9009409
link
/test integ-framework-k8s-presubmit-tests-master

prow/integ-mixer-k8s-presubmit-tests.sh
734a666692f06708b6f76d4e5224f6b2a9009409
link
/test integ-mixer-k8s-presubmit-tests-master

prow/integ-security-k8s-presubmit-tests.sh
734a666692f06708b6f76d4e5224f6b2a9009409
link
/test integ-security-k8s-presubmit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test all

@howardjohn: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/integ-pilot-k8s-presubmit-tests.sh
734a666692f06708b6f76d4e5224f6b2a9009409
link
/test integ-pilot-k8s-presubmit-tests-master

prow/integ-telemetry-k8s-presubmit-tests.sh
734a666692f06708b6f76d4e5224f6b2a9009409
link
/test integ-telemetry-k8s-presubmit-tests-master

prow/e2e-bookInfoTests-trustdomain.sh
734a666692f06708b6f76d4e5224f6b2a9009409
link
/test e2e-bookInfoTests-trustdomain-master

prow/integ-istioctl-k8s-presubmit-tests.sh
734a666692f06708b6f76d4e5224f6b2a9009409
link
/test integ-istioctl-k8s-presubmit-tests-master

prow/e2e-dashboard.sh
734a666692f06708b6f76d4e5224f6b2a9009409
link
/test e2e-dashboard-master

prow/integ-framework-k8s-presubmit-tests.sh
734a666692f06708b6f76d4e5224f6b2a9009409
link
/test integ-framework-k8s-presubmit-tests-master

prow/integ-mixer-k8s-presubmit-tests.sh
734a666692f06708b6f76d4e5224f6b2a9009409
link
/test integ-mixer-k8s-presubmit-tests-master

prow/integ-security-k8s-presubmit-tests.sh
734a666692f06708b6f76d4e5224f6b2a9009409
link
/test integ-security-k8s-presubmit-tests-master

prow/istio-lint.sh
734a666692f06708b6f76d4e5224f6b2a9009409
link
/test istio-lint-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/integ-pilot-k8s-presubmit-tests.sh
734a666692f06708b6f76d4e5224f6b2a9009409
link
/test integ-pilot-k8s-presubmit-tests-master

prow/integ-telemetry-k8s-presubmit-tests.sh
734a666692f06708b6f76d4e5224f6b2a9009409
link
/test integ-telemetry-k8s-presubmit-tests-master

prow/e2e-bookInfoTests-trustdomain.sh
734a666692f06708b6f76d4e5224f6b2a9009409
link
/test e2e-bookInfoTests-trustdomain-master

prow/integ-istioctl-k8s-presubmit-tests.sh
734a666692f06708b6f76d4e5224f6b2a9009409
link
/test integ-istioctl-k8s-presubmit-tests-master

prow/e2e-dashboard.sh
734a666692f06708b6f76d4e5224f6b2a9009409
link
/test e2e-dashboard-master

prow/integ-framework-k8s-presubmit-tests.sh
734a666692f06708b6f76d4e5224f6b2a9009409
link
/test integ-framework-k8s-presubmit-tests-master

prow/integ-mixer-k8s-presubmit-tests.sh
734a666692f06708b6f76d4e5224f6b2a9009409
link
/test integ-mixer-k8s-presubmit-tests-master

prow/integ-security-k8s-presubmit-tests.sh
734a666692f06708b6f76d4e5224f6b2a9009409
link
/test integ-security-k8s-presubmit-tests-master

prow/istio-lint.sh
734a666692f06708b6f76d4e5224f6b2a9009409
link
/test istio-lint-master

prow/integ-galley-k8s-presubmit-tests.sh
734a666692f06708b6f76d4e5224f6b2a9009409
link
/test integ-galley-k8s-presubmit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/integ-pilot-k8s-presubmit-tests.sh
734a666692f06708b6f76d4e5224f6b2a9009409
link
/test integ-pilot-k8s-presubmit-tests-master

prow/e2e-bookInfoTests-trustdomain.sh
734a666692f06708b6f76d4e5224f6b2a9009409
link
/test e2e-bookInfoTests-trustdomain-master

prow/integ-mixer-k8s-presubmit-tests.sh
734a666692f06708b6f76d4e5224f6b2a9009409
link
/test integ-mixer-k8s-presubmit-tests-master

prow/integ-security-k8s-presubmit-tests.sh
734a666692f06708b6f76d4e5224f6b2a9009409
link
/test integ-security-k8s-presubmit-tests-master

prow/istio-lint.sh
734a666692f06708b6f76d4e5224f6b2a9009409
link
/test istio-lint-master

prow/integ-galley-k8s-presubmit-tests.sh
734a666692f06708b6f76d4e5224f6b2a9009409
link
/test integ-galley-k8s-presubmit-tests-master

prow/integ-telemetry-k8s-presubmit-tests.sh
734a666692f06708b6f76d4e5224f6b2a9009409
link
/test integ-telemetry-k8s-presubmit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-lint.sh
734a666692f06708b6f76d4e5224f6b2a9009409
link
/test istio-lint-master

prow/integ-telemetry-k8s-presubmit-tests.sh
734a666692f06708b6f76d4e5224f6b2a9009409
link
/test integ-telemetry-k8s-presubmit-tests-master

prow/integ-security-k8s-presubmit-tests.sh
734a666692f06708b6f76d4e5224f6b2a9009409
link
/test integ-security-k8s-presubmit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: howardjohn, nmittler, yangminzhu
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

tests/integration/pilot/OWNERS [howardjohn,nmittler]
tests/integration/security/OWNERS [howardjohn,nmittler,yangminzhu]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@howardjohn: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-lint.sh
734a666692f06708b6f76d4e5224f6b2a9009409
link
/test istio-lint-master

prow/integ-framework-k8s-presubmit-tests.sh
853fb4b791f010d972b1fc5bc6f5ac2d082dc826
link
/test integ-framework-k8s-presubmit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-lint.sh
734a666692f06708b6f76d4e5224f6b2a9009409
link
/test istio-lint-master

prow/integ-framework-k8s-presubmit-tests.sh
853fb4b791f010d972b1fc5bc6f5ac2d082dc826
link
/test integ-framework-k8s-presubmit-tests-master

prow/e2e_pilotv2_auth_sds.sh
853fb4b791f010d972b1fc5bc6f5ac2d082dc826
link
/test istio_auth_sds_e2e-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-lint.sh
734a666692f06708b6f76d4e5224f6b2a9009409
link
/test istio-lint-master

prow/integ-framework-k8s-presubmit-tests.sh
853fb4b791f010d972b1fc5bc6f5ac2d082dc826
link
/test integ-framework-k8s-presubmit-tests-master

prow/e2e_pilotv2_auth_sds.sh
853fb4b791f010d972b1fc5bc6f5ac2d082dc826
link
/test istio_auth_sds_e2e-master

prow/istio-pilot-multicluster-e2e.sh
853fb4b791f010d972b1fc5bc6f5ac2d082dc826
link
/test istio-pilot-multicluster-e2e-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test istio_auth_sds_e2e-master
/test integ-framework-k8s-presubmit-tests-master

@howardjohn: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-lint.sh
734a666692f06708b6f76d4e5224f6b2a9009409
link
/test istio-lint-master

prow/integ-security-k8s-presubmit-tests.sh
853fb4b791f010d972b1fc5bc6f5ac2d082dc826
link
/test integ-security-k8s-presubmit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


Issue when managing private DNS zone

Hey,
We are trying to manage our private DNS zone with octo.
We already have created our main private zone on Azure which looks like env.cloudprovider.company.internal.
Our problem is when we create a record using this module. It create a complete new DNS Zone (and not a private one) which looks like record.env.cloudprovider.company.internal instead of using the existing private zone
Are we doing something wrong or the module just don't support private DNS zone ?
Thanks

Hrm. I'm not familiar with private zones/dns in Azure. Looks like it may be a fairly new feature (GA) https://azure.microsoft.com/en-us/blog/announcing-azure-dns-private-resolver-general-availability/#:~:text=Azure Private DNS manages and,Azure-provided names during deployment.
It looks like they're a completely different resource as far as Azure is concerned. When I go to private DNS in the portal I have no zones, even though I have a number of them over in the original/public DNS resource page.

I'm guessing/hoping there's just a flag that needs to be configured in the Azure client libs to tell things to work with private rather than normal DNS zones. If it's that simple then adding support should be straightforward. If it's more involved/a different API then I don't know what would be required.

Azure is such a pita to work with 😦, looks like it's a completely separate client lib https://learn.microsoft.com/en-us/python/api/overview/azure/private-dns?view=azure-python.
That said there's a section under the general DNS rest docs https://learn.microsoft.com/en-us/rest/api/dns/ for private DNS, e.g. https://learn.microsoft.com/en-us/rest/api/dns/privatedns/private-zones and there are some parameters in the zone create/update api that only apply to private zones https://learn.microsoft.com/en-us/rest/api/dns/zones/create-or-update?tabs=HTTP.
I'm not sure that I'm going to have the bandwidth to sort out what's going on with all of this without a specific setup/use-case for it since it'd probably be fairly involved to get the required VNets and associated resources all set up to poke around at it, figure out how it works, and what would be necessary to get it supported.
/cc @viranch may be able to chime in with thoughts, they're generally more familiar with azure

Hello Ross, thx for the quick response and thx for links. But just for information private DNS is not really new feature on Azure: https://azure.microsoft.com/en-us/updates/azure-dns-private-zones-is-now-generally-available/ ==> 2019... the link you give in your first post was about private resolver only.
But what I see the article for the python library for Azure DNS private is pretty new.
In our side (with jpuchois) we will try to adapt to permit manage private also and we will send you code update proposal.

Yeah private zones use a separate (but similar) API, so out-of-the-box support yet. Code change wise should not be challenging to add support. Like @ross said, setting up the right testing env is involving. As always, contributions very welcome!


Add UNIVERSIDAD UCAD (ucad.edu.mx)

The university official website URL, if it is different from the domain you are submitting
(https://ucad.edu.mx)

A URL of a page on the official website where a long-term (>1 year) IT related course is offered by the university
https://ucad.edu.mx/Becas_Universitarias/Promocion_Facebook/Ingenieria_En_Sistemas/Licenciatura-En-Ingenieria-En-Sistemas.html

A URL of a page or some other proof (.pdf or a screenshot are OK) showing that the university recognizes the domain which you are submitting as an official email domain for the enrolled students.
https://ucad.edu.mx/images/screenshot.png

@ucadmx First stage of verification passed, official domain is ucad.edu.mx as far as I verified. This is just an informational note. Pull request is still in the review. I appreciate your patience while waiting for the final decision.

@ucadmx Pull request merged. Thank you.


i18n: unable to save content

Describe the bug
The bug is inconsistent and I can't yet point out what the issue is but I keep getting an error when trying to save a translated version of a collection the save button is not responsive.

and I get a not very helpful error in the console:

To Reproduce
The following is my config.yml
site_url: https://SOMETHING.netlify.app/
logo_url: https://SOMETHING.netlify.app/logo.png

publish_mode: editorial_workflow
backend:
  name: git-gateway
  branch: master

media_folder: static/img
public_folder: /img

i18n:
  # Required and can be one of multiple_folders, multiple_files or single_file
  # multiple_folders - persists files in `<folder>/<locale>/<slug>.<extension>`
  # multiple_files - persists files in `<folder>/<slug>.<locale>.<extension>`
  # single_file - persists a single file in `<folder>/<slug>.<extension>`
  structure: multiple_folders

  # Required - a list of locales to show in the editor UI
  # en - English
  # ar - Arabic
  # ms - Malay
  # sw - Swahili
  locales: [en, ar, ms, sw]

  # Optional, defaults to the first item in locales.
  # The locale to be used for fields validation and as a baseline for the entry.
  default_locale: en

# Docs: https://www.netlifycms.org/docs/configuration-options/#collections
collections:
  - label: 'Site settings'
    name: 'site'
    files:
      - label: 'Info'
        name: 'info'
        file: 'content/site/info.json'
        format: 'json'
        editor:
          preview: false
        fields:
          - { label: Site Name, name: sitename, widget: string, hint: 'This is used for the site title' }
          - { label: Email Contact, name: contact, widget: string, hint: 'This email is used for the contact form' }
          - {
              label: Site Description,
              name: sitedescription,
              widget: string,
              hint: 'This is used as descriptive text for links that link to this site',
            }
          - {
              label: Site Language,
              name: sitelang,
              widget: string,
              pattern: ['^[a-z]{2}([-])?([A-Za-z]{2})?$', 'Must match "xx" or "xx-XX" syntax (ex. "en" or "sv-SE")'],
              hint: 'The default website language'
            }
          # - { label: Site Email, name: siteemail, widget: string, required: false }
  - name: 'blog'
    label: 'Blog'
    folder: 'content/blog'
    create: true
    i18n: true
    format: 'frontmatter'
    slug: '{{year}}-{{month}}-{{day}}-{{slug}}'
    # editor:
    #   preview: true
    fields:
      - { label: 'Title', name: 'title', widget: 'string', required: true, i18n: true }
      - { label: 'Description', name: 'description', widget: 'string', required: false, i18n: true }
      - { label: 'Body', name: 'body', widget: 'markdown', required: false }

  - name: 'campaigns'
    label: 'campaigns'
    label_singular: 'Campaign'
    folder: 'content/campaigns'
    create: true
    i18n: true
    format: 'frontmatter'
    slug: '{{slug}}'
    preview_path: 'campaigns/{{slug}}'
    fields:
      - {
          label: 'Campaign tag',
          name: 'tags',
          widget: 'list',
          default: ['zakat'],
          min: 1,
          max: 3
        }
      - { label: 'Title', name: 'title', widget: 'string', i18n: true, required: true }
      - { label: 'Description', name: 'description', widget: 'string', i18n: true, required: false }
      - { label: 'Cover Image', name: 'cover', widget: 'image', required: false, i18n: duplicate,  allow_multiple: false }
      - { label: 'Content', name: 'body', widget: 'markdown', i18n: true, required: true }
      - {
          label: 'Gallery',
          name: 'gallery',
          widget: 'list',
          required: false,
          summary: '{{fields.image}}',
          field: { label: 'Image', name: 'image', widget: 'image' },
        }

Expected behavior
the save button should save properly and there should be no errors
Applicable Versions:

Netlify CMS version: 2.10.99
Git provider: GitHub
OS: windows 10
Browser version: chrome 89.0.4389.82 (Official Build) (64-bit), firefox 86.0.1 (64-bit)
Node.JS version: 12

I get exactly the same error message with this minimum reproducible config.yml:
backend:
  name: git-gateway
local_backend: true

# i18n:
#   structure: single_file
#   locales: [en, es]
#   default_locale: en

media_folder: "src/assets/img"
public_folder: "/assets/img"

collections:
  - name: pages
    label: Pages
    # i18n: true
    files:
      - name: about
        label: About
        # i18n: true
        file: src/_data/blocks/about.yml
        fields:
          - { label: Intro, name: intro, widget: text, i18n: true }

With the i18n keys commented out, the file is saved  fine. With the comments removed, the two editors appear, but when I tap publish, the quoted javascript error triggers and the changes are not saved.

My problem is probably because I tried to use i18n in a files collection. I have now restructured to use it in a folder collection which gives a really confusing UX experience to the content editor, but at least I can save the edits. This works for me:
backend:
  name: git-gateway
  branch: master

i18n:
  structure: multiple_folders
  locales: [en, es, ar, hi, zh]
  default_locale: en

media_folder: "src/assets/img"
public_folder: "/assets/img"
local_backend: true

collections:
  [
    {
      label: "Home",
      name: "home",
      folder: "src/_data/blocks",
      create: false,
      editor: { preview: false },
      format: "json",
      extension: "json",
      slug: "home",
      i18n: true,
      fields:
        [
          {
            name: "intro",
            label: "Introduction",
            widget: "markdown",
            i18n: true,
          },
          {
            label: "Title",
            name: "title",
            widget: "string",
            required: true,
            i18n: true,
          },
        ],
    },
    {
      label: "Privacy",
      name: "privacy",
      folder: "src/_data/blocks",
      create: false,
      editor: { preview: false },
      format: "json",
      extension: "json",
      slug: "privacy",
      i18n: true,
      fields:
        [
          {
            name: "statement",
            label: "Statement",
            widget: "markdown",
            i18n: true,
          },
          {
            label: "Title",
            name: "title",
            widget: "string",
            required: true,
            i18n: true,
          },
        ],
    },
  ]


JAMES-2586 Module chooser: S3, file blobStore

resolve [PGSQL] Module chooser: S3, file blobStore
I tested the normal docker-compose and distributed one, they work normally too.

Ah and it needs a rebase :)

conflict, neet to rebase


Remove option for types being able to be closures

There's some inconsistency in the codebase now, where some places typehint Type, while other don't.
This comment made it clear that this is confusing: https://github.com/spatie/typed/pull/3#discussion_r190845906
Let's remove the possibility to work with callables as types. Makes everything more clear.

It's fixed.


[SPARK-47785][BUILD][TESTS] Upgrade bouncycastle to 1.78

What changes were proposed in this pull request?
This PR aims to upgrade bouncycastle to 1.78.
Why are the changes needed?
To use the latest bug fixed version.

https://github.com/bcgit/bc-java/blob/main/docs/releasenotes.html

Does this PR introduce any user-facing change?
No, this is a test dependency.
How was this patch tested?
Pass the CIs.
Was this patch authored or co-authored using generative AI tooling?
No.

All tests passed except the known CSV failures which were fixed already in master branch an hour ago.

https://github.com/apache/spark/pull/45958

Could you review this test dependency PR, @huaxingao ?

Thank you, @huaxingao !
Merged to master.


Followup fixes for #129

PR #129 broke the helper wrapper and the bufferline plugin support. This PR fixes them.

I've fixed this in the meantime so I won't be merging it, but thank you anyway :)

It seems that
https://github.com/pta2002/nixvim/blob/8d41514bbef2b5ee213c22c70b39e8c976d6200a/wrappers/_shared.nix#L14 hasn't been fixed.
error: undefined variable 'pkgs'

       at /nix/store/ihakrpl6f8wqwg4rv310x2zr6zq78kzg-source/wrappers/_shared.nix:14:56:

           13|     description = "Use this option to access the helpers";
           14|     default = import ../plugins/helpers.nix { inherit (pkgs) lib; };
             |                                                        ^
           15|   };

oh! sorry

Rebased this PR on the latest commit.


Add service account support to the clusterpool module

Summary of Changes
This PR includes some new conditional logic in clusterclaim creation focused on serviceaccounts.  If the calling user is a serviceaccount on the target kube cluster, they will be automatically added to the subjects array of the clusterclaim.  If the user is a non-serviceaccount user, they can set CLUSTERPOOL_SERVICE_ACCOUNT and that string will be added as a subject on the claim.  A serviceaccount cannot add other serviceaccounts to its claim in this use case, RBAC groups or service account groups should be used instead.
Validation of Changes
If you need access to a serviceaccount with which to test these changes before merging them, please contact me.

This PR is the next step to functionally resolve https://github.com/open-cluster-management/backlog/issues/8524

This PR is the next step to functionally resolve https://github.com/open-cluster-management/backlog/issues/8524


fix: use new glob source API

Fixes #1973 and adds unit tests. I also stopped using object.addLink and used the same strategy as in https://github.com/ipfs/ipfs-webui/pull/1890.

@lidel this should fix #1973.


Windows support

The mechanism for changing Windows app icons is pretty easy and doesn't require a third-party script


Uncaught TypeError: Cannot read property 'rangeCount'

I don't know why but when I look at the console I always see hundreds of time same log.
Uncaught TypeError: Cannot read property 'rangeCount' of undefined

When clicking the filename it highlights this 3902. line.
sel._ranges.length = sel.rangeCount = sel.nativeSelection.rangeCount;

Could you provide the the minimal code you use initiate the editor, and that produces these errors. Also could you provide browser and version?

We're building a CMS like Wordpress and using the text editor in "add post" page.
Posts can be added in different languages for this reason we have a tab in "add post" page.
Every tab is a different language and we have a text editor in each of them.
Here's a screenshot how it's look like.

I use these codes after I included the main wysihtml-toolbar.js.
editor0 = new wysihtml5.Editor("content_addPost[en]", { toolbar: "toolbar_addPost[en]" });
editor1 = new wysihtml5.Editor("content_addPost[tr]", { toolbar: "toolbar_addPost[tr]" });

I get that error in Chrome 45, 46, 47 & Opera 31.
In Firefox 40
TypeError: sel.nativeSelection is null

In Safari 9
Error: Error in Rangy WrappedSelection module: getNativeSelection(): Parameter must be a Window object or DOM node

I'm experiencing the same issue. Chrome 46.
new wysihtml5.Editor("wysihtml5-justification",
        toolbar:      "wysihtml5-toolbar-justification",
        stylesheets:  "<%= stylesheet_path('wysihtml') %>",
        parserRules:  wysihtml5ParserRules)

to setup the editor.

I had the same problem. The deal was that I used the editor in a popup (vitalets/x-editable) which creates a new editor instance and removes it when closing. But the editor was not properly destroyed and it kept calling the above code which breaks if its IFRAME is no longer in the DOM.
The solution - make sure to call the editor's .destroy() so it knows it's being removed and cleans up.

Ah, ya, that would do it. Thanks for the tip!


Live chart support

Hi,
Are there any plans to include live chart support through a data stream from an API?

https://wuba.github.io/react-native-echarts/docs/getting-started/write-a-dynamic-data-chart


Add an iife in the minified file

so to not 'leak' use strict.

@leon Can you look at the PRs? Otherwise I'll close them.


[Event Request] - OnBeforeAppliesToEntryEntryTypeTest in Table 83 "Item Journal Line"

Hello, please consider adding the following event to Table 83 "Item Journal Line":
[IntegrationEvent(false, false)]
local procedure OnBeforeCalcRoutingCostPerUnit(var ItemJnlLine: Record "Item Journal Line"; var ProdOrderRtngLine: Record "Prod. Order Routing Line"; var IsHandled: Boolean)
begin
end;

and raise it accordingly inside the "OnValidate" trigger of "Cap. Unit of Measure Code" field:
        trigger OnValidate()
        var
            ProdOrderRtngLine: Record "Prod. Order Routing Line";

            **IsHandled: Boolean;**

        begin
            if Type <> Type::Resource then begin
                "Qty. per Cap. Unit of Measure" :=
                  Round(
                    CalendarMgt.QtyperTimeUnitofMeasure(
                      "Work Center No.", "Cap. Unit of Measure Code"),
                    UOMMgt.QtyRndPrecision);

                Validate("Setup Time");
                Validate("Run Time");
                Validate("Stop Time");
            end;

            if "Order No." <> '' then
                case "Order Type" of
                    "Order Type"::Production:
                        begin
                            GetProdOrderRtngLine(ProdOrderRtngLine);
                            "Unit Cost" := ProdOrderRtngLine."Unit Cost per";

                            **OnBeforeCalcRoutingCostPerUnit(Rec, ProdOrderRtngLine, IsHandled);
                            IF NOT Handled THEN**

                                CostCalcMgt.RoutingCostPerUnit(
                                  Type, "No.", "Unit Amount", "Indirect Cost %", "Overhead Rate", "Unit Cost", "Unit Cost Calculation");
                        end;
                    "Order Type"::Assembly:
                        CostCalcMgt.ResourceCostPerUnit("No.", "Unit Amount", "Indirect Cost %", "Overhead Rate", "Unit Cost");
                    else
                        OnValidateCapUnitOfMeasureCodeOnCaseOrderTypeElse(Rec);
                end;

            ReadGLSetup;
            "Unit Cost" :=
              Round("Unit Cost" * "Qty. per Cap. Unit of Measure", GLSetup."Unit-Amount Rounding Precision");
            "Unit Amount" :=
              Round("Unit Amount" * "Qty. per Cap. Unit of Measure", GLSetup."Unit-Amount Rounding Precision");
            Validate("Unit Amount");
        end;

Thank you!

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.
Build ID: 49264.


add test case for multipart/form-data

fixes https://github.com/Azure/cadl-ranch/issues/156
Have used https://github.com/Azure/cadl-ranch/issues/156#issuecomment-1815742334 to pass this new test case.

Issues left for typespec design:
(1) typespec doesn't support set content-type for each item of multipart model but swagger can: https://swagger.io/docs/specification/describing-request-body/multipart-requests/
Issues left for cadl-ranch:
(1) Shall we test the property order? https://github.com/Azure/cadl-ranch/pull/452#discussion_r1396721421

After discussion, I simplify the basic scenario with reference of real case from OpenAI and Face

The multipart form case reveals a question: how do we provide File in Typespec? For a file upload, the actual content will be like:

Content-Disposition: form-data; name="file1"; filename="a.txt"
Content-Type: text/plain

Note there is a filename. bytes doesn't contain that information.
Or each language just creates a random file name. I remember some clients adopt that strategy for safety. Server sides normally only care about name.

Good question. According to https://github.com/Azure/cadl-ranch/pull/452#discussion_r1400057567, fileName is not necessary. So I think it is OK to use random name or just None.

Should it be under parameters folder, instead of payload folder?

We will need Timothee approve on cadl-ranch-api

@timotheeguerin Please help review again.

Let's support basic scenario at first and then grow it for more complicated scenario if needed


[Bug] Table's visible columns are not saved

Description
The table's configuration about what fields are not visible is not saved.
Steps to reproduce the behaviour:
Add steps to reproduce this behaviour, include console / network logs & screenshots

Create table
Bind it to the query
Hide some columns
Ensure app was saved
Exit the app
Reopen the app

Now you see that all fields are visible again

@President thank you for reporting this!

Similar issue reported in #6454 where the column order is not saved, This is not reproducible on our release environment.
@vivekverma2312 @YogeshJayaseelan can you verify this?
@Tooluloope we need to understand the difference here, Please look into this at priority


docs(readme): update links to pushy

Picking up maintenance of Pushy [Update: Moved to clj-commons] #39
https://github.com/clj-commons/pushy

Thanks!


Sprint 4 - Team 9 Task Ticket 3: Graphic Design for Collecting Games

Description
Feature: Sprint 4 - Team 9 Feature Ticket: Improvement of Collecting Games
This task will mainly show the graphic requirements and design plan for the graphic drawing part.
Dependencies

[x] Pixel Grid Resolution

Milestones

[x] Communicate with team members and other teams(if needed) to make sure the requirements (Oct. 13)
[x] Design for the graphic drawings (Oct. 17)
[ ] Update the wiki (Oct.18)

Completion Deadline: Oct. 18
Documentation

Main description of feature

Member

Jingyi Li (@AlynnLi) (Jingyi Li)

The announcement board for switch game in Chap1

The congratulation board for switch game in Chap1

The pale scale (as the reward)

The announcement board for reward collection

The congratulation board for collection pale scale in Chap2

The congratulation board for collecting fixed scale in Chap3

The reward collecting place


Is this an alternative to sw-precache? (newb question)

Probably. If you are using sw-precache already then you don't need to switch.
The idea of this plugin is that it's integrated to webpack, it's easy to setup and it supports AppCache if it's needed. Also it's probably written differently than sw-precache and may not have all features sw-precache has.

Okay, closing this. Feel free to ask other questions :-)


SCA integration

I just want to know that if we have support for SCA in this plugin or plans for implementing it near future?

@AhmadAyyaz1993
Support for SCA is implemented in the Capacitor version: https://github.com/zyra/capacitor-stripe
This PR is to merge that implementation into this repo to make it work for Cordova.
It works but requires the following plugins to be installed on Cordova:

cordova-plugin-androidx
cordova-plugin-androidx-adapter
cordova-support-kotlin

New version highlights:

All the essential features are working and tested (card, bank, pii, and source tokens, payment intents, setup intents, google pay, apple pay)
UI components were partially implemented but they're removed for now. Will implement if https://github.com/stripe/stripe-android/issues/1778 is resolved.
Payment methods (listing customer cards) is implemented but not very well tested.

In the near future payment methods will be tested more thoroughly  to squeeze out any existing bugs. Once things are looking stable I'll do another round of quick refactoring to port both the Android + iOS implementations here.

Thanks  for the information.


Radarr sensor issue

Home Assistant release (hass --version):
0.47.1
Python release (python3 --version):
3.6.1
Component/platform:
sensor.radarr
Description of problem:
Errors are logged and the upcoming monitored condition sensor entity never shows up.
Expected:
No errors logged and the entity exists (and is populated)
Problem-relevant configuration.yaml entries and steps to reproduce:
- platform: radarr
  api_key: !secret radarr_api_key
  host: media.local
  urlbase: /movies
  monitored_conditions:
    - upcoming
    - commands
    - status

restart hass

Traceback (if applicable):
2017-06-29 13:44:14 ERROR (MainThread) [homeassistant.core] Error doing job: Task exception was never retrieved
Traceback (most recent call last):
  File "/usr/local/lib/python3.6/asyncio/tasks.py", line 179, in _step
    result = coro.send(None)
  File "/home/hass/hass/lib/python3.6/site-packages/homeassistant/helpers/entity_component.py", line 368, in async_process_entity
    new_entity, self, update_before_add=update_before_add
  File "/home/hass/hass/lib/python3.6/site-packages/homeassistant/helpers/entity_component.py", line 225, in async_add_entity
    yield from entity.async_update_ha_state()
  File "/home/hass/hass/lib/python3.6/site-packages/homeassistant/helpers/entity.py", line 246, in async_update_ha_state
    device_attr = self.device_state_attributes
  File "/home/hass/hass/lib/python3.6/site-packages/homeassistant/components/sensor/radarr.py", line 181, in device_state_attributes
    attributes[to_key(movie)] = get_release_date(movie)
  File "/home/hass/hass/lib/python3.6/site-packages/homeassistant/components/sensor/radarr.py", line 219, in get_release_date
    date = data['physicalRelease']
KeyError: 'physicalRelease'

Additional info:

@tboyce021,  I found the issue and propose a tweak to https://github.com/home-assistant/home-assistant/blob/dev/homeassistant/components/sensor/radarr.py#L217
I'll submit a PR, but wanted to post it up here first as it addresses the issue.
def get_release_date(data):
    """Get release date."""
    if 'physicalRelease' in data:
        date = data['physicalRelease']
    else:
        date = data['inCinemas']
    return date

Could inCinemas be missing too? If so, maybe using get() could help (assuming data is actually a dictonary):
def get_release_date(data):
    """Get release date."""
    date = data.get('physicalRelease')
    if not date:
        date = data.get('inCinemas')
    return date;

Then just be sure that having a None value for the attribute doesn't cause any issues.


accelerate support for train_finetune.py with one GPU

Request per https://github.com/yl4579/StyleTTS2/issues/96#issuecomment-1828819805. Current finetuning script is quite slow because it doesn't support accelerate due to #7, but a lot of people are finetuning using a single GPU, so we don't really have to worry about DP or DDP and can directly turn to accelerate which supports mixed precision that saves time and RAM. It would be great if someone could implement this feature for a single GPU. For multi-GPU we are still trying to solve #7 .

I'm doing a few tests now... but I believe I may have implemented this, following this guide

After testing, it doesn't appear that VRAM usage drops by very much, however, training speed is seemingly faster from what I'm observing. I could be missing a few things, however.

@korakoe Did you do 16 bit mixed precision? Does it involve diffusion training or SLM adversarial training?

@korakoe Did you do 16 bit mixed precision? Does it involve diffusion training or SLM adversarial training?

I'm using fp16 mixed precision, Diffusion training but not SLM (due to Colab, however the implementation does work)

after it jumps to 14GB it drops to 11GB, so I'm assuming that accelerate is doing some form of offloading?

@korakoe I think the main concern in https://github.com/yl4579/StyleTTS2/issues/96#issuecomment-1828493779 is the speed, so if the speed is faster I guess it's fine, even if VRAM drop is not that big.


Fix configuration for Nginx service (status_url prefix)

Before this fix for Nginx in config file only status_ulr without "nginx" prefix works.

Thanks!

Thank you for taking care of this bug. All this configuration file thing is not something that I actively use, and some subtle bugs are possible. If you encounter anything similar or need further clarification on this, just let me know. Feel free to report any issues you run into


Custom compiler options get double-quoted then rejected by GCC

Hi, I have this particular issue everytime I want to feed my own options to GCC in the Compiler options textbox. The options are supplied to the compiler in double quotes, and GCC won't recognize them.

The arguments are split by line break. https://wandbox.org/permlink/FyaiXJDHKbeUaBEO
(I think it is design error, but can not change it for compatibility)


i18n filter does not work

It's simple, with this :
common.lang.json
{
    "test" :  "Ca marche !"
}

ctrl.js
$scope.strings = [];
locale.ready('common').then(function () {
    $scope.strings.test = locale.getString('common.test');
});

app.js
     .value('localeConf', {
            basePath: 'languages',
            defaultLocale: 'en-US',
            sharedDictionary: 'common',
            fileExtension: '.lang.json',
            persistSelection: true,
            cookieName: 'language',
            observableAttrs: new RegExp('^data-(?!ng-|i18n)'),
            delimiter: '::'
    })
    .value('localeSupported', [
        'en-US',
        'fr-FR',
    ])
    .value('localeFallbacks', {
        'en': 'en-US',
        'fr': 'fr-FR'
    })

I can do this :
.html

<input data-i18n-attr="{placeholder: 'common.test'}" />

{{strings.test}}

But not this :
.html

{{ 'test' | i18n }}

{{ test | i18n }}

{{'common.test' | i18n}}

{{common.test | i18n}}

+1 having the same issue.

@sean-roberts, @CrunchyArtie what version of angular are you using?

1.3.8

+1 also having this issue with Angular 1.3.13

+1 with 1.3.14

Attempting to figure out a bit more about this issue...
The filter is quite simple:
    .filter('i18n', ['locale',
        function (locale) {
            return function (input, args) {
                return locale.getString(input, args);
            };
        }
    ])

So if I have a page that only uses the filter, then locale.getString needs to somehow do the work of fetching and resolving mappings.
On the first load for the filter,
var result = '';
...
} else {
                        if (!bundle) {
                            loadBundle(txt);
                        }
                    }
...
return result;

this above is the code path taken within getLocalizedString (a.k.a. getString). loadBundle does broadcast and follow up on promises, but we haven't registered either of those. Instead we just return result, which is an empty string at this point, and are done.
So with that simpleton's view of the operation, it seems that the bundle is loaded but resolving the mapping is not paid attention to thereafter. @doshprompt , what is the expected operation after the call to loadBundle? Is there something/someone that should be coming by later and resolving the mapping?

The filter function needs to be marked as $stateful (see "Stateful filters": https://docs.angularjs.org/guide/filter).  You need a named function to do this...
function i18nFilterFactory(LocationService) {

        function i18Filter(input, args) {
            return LocationService.getString(input, args);
        }

        i18Filter.$stateful = true;

        return i18Filter;

    }

Not working using 1.4.0-rc.0


How to export all compilation errors and warnings from Problems view to txt/excel or similar?

Hi, team.
Is there any opportunity to export all compilation errors and warnings from Problems view to some tabular format?
If the number of errors is quite big, it's useful to analyse them somewhere, outside of VSCode.

The best approach would be to compile using alc.exe. This will list all errors in the standard console output.

This is 1 object example
The result from ALC.exe

The result from VSCode problem view

You see that alc.exe don't show about 19 errors

That's interesting, there shouldn't be any differences in the reported errors. Alc.exe is just a command line wrapper for the same compiler code as used from VS Code.
Perhaps you're using different settings from VS Code? Specifically these 3 needs to be in sync:
/packagecachepath: Specify the cache location for the symbols.
/target:              Specify the compilation target.
/features:      List of feature flags.

Strange.
I've added /target:extention => the result is as expected. Identical to vscode problems view.
Then I deleted /target:extention => the result is as expected. Identical to vscode problems view.
Seems yesterday was not my day)
Will experiment tomorrow

The difference is currently by design. Alc.exe fails early since it is primarily targeted towards automated builds where we don't normally expect to encounter issues. VS Code on the other hand lists all issues since it is often used with projects that don't correctly compile yet. We are currently not planning changes to this behavior.

There doesn't seem to be a straightforward way to do it. See if this API might help: https://github.com/Microsoft/vscode/issues/30075


Enable resolution changes without restarting the application

This is possible, but it will take some changes to the architecture of the library to achieve.
There is a scaling function in tcl/tk that can be used. However, the images that I'm using for the styles are created with the scaling at the time the styles is generated, so a change to scaling would not affect this image-based styles currently.
However, this does sounds like a reasonable thing to do, so I will look at how this can be implemented in version 2.0 of ttkbootstrap which I'm working on now.
To document this for my own notes later... I need to create and generate a <> event when the resolution changes. Add an event handler (on_resolution_changed) that will erase the style assets and registry. Then, generate a '<>' event that will automatically cause the styles for all widgets to rebuild with the new scaling. I'll need to test whether or not the widgets resize their own geometry as this is an open question in the current documentation (perhaps widget specific?).
Originally posted by @israel-dryer in https://github.com/israel-dryer/ttkbootstrap/discussions/336#discussioncomment-3466786

On the roadmap for Version 2.0


[version update] use serde-generate v0.6.1 to fix LCS hashing in C++

Motivation
Update external reference and deploy fix to LCS runtime in C++: https://github.com/facebookincubator/serde-reflection/pull/26
Test Plan
see external PR

@bors-libra r=dmitri-perelman

:pushpin: Commit 147e043 has been approved by dmitri-perelman

:hourglass: Testing commit 147e043ae5b786be82c3f2bc65fe606d47edb981 with merge 880091530c3a24226a338e8f9a0e9426710077c7...

:sunny: Test successful - checks-actions_land_blocking_test, checks-circle_commit_workflow
Approved by: dmitri-perelman
Pushing 880091530c3a24226a338e8f9a0e9426710077c7 to master...


WIP DO NOT MERGE IT IGD support

This change is

r? @canndrew
(maidsafe_highfive has picked a reviewer for you, use r? to override)

Review status: 0 of 9 files reviewed at latest revision, 3 unresolved discussions.

src/igd/http_request.rs, line 94 [r2] (raw file):

             token: Token,
             event_set: EventSet) {
        if !event_set.is_readable()

Is it not better as if error() || hup() { .. } else { if readable() {...} if writable() {...} }

src/igd/http_request.rs, line 125 [r2] (raw file):

                    let read = match self.socket.read(&mut buf) {
                        Ok(r) => r,
                        Err(ref e) if e.kind() == io::ErrorKind::WouldBlock => break,

Maybe also include ErrorKind::Interrupted which is benign as well and not and error

src/igd/http_request.rs, line 150 [r2] (raw file):

                            Ok(None) => break,
                            Err(e) => {
                                self.callback.invoke(Err(HttpError::ParsingError(e)),

why are we not dergistering token from mio loop followed by removing context and token from core ?  Do you still want them there ?

Comments from Reviewable

Review status: 0 of 9 files reviewed at latest revision, 3 unresolved discussions.

src/igd/http_request.rs, line 94 [r2] (raw file):
Previously, ustulation (Spandan Sharma) wrote…
> Is it not better as `if error() || hup() { .. } else { if readable() {...} if writable() {...} }`

HTTP/1.0 closes the connection after the response is sent. I want to avoid discarding any data. There **will** be a hup/error after the reply is sent, but there will also be buffered data to be read.

src/igd/http_request.rs, line 150 [r2] (raw file):
Previously, ustulation (Spandan Sharma) wrote…
> why are we not dergistering token from mio loop followed by removing context and token from `core` ?  Do you still want them there ?

That's why I wanted your review for. Gonna fix these errors.

Comments from Reviewable

r? @ustulation

Review status: 0 of 9 files reviewed at latest revision, 3 unresolved discussions.

src/igd/http_request.rs, line 125 [r2] (raw file):
Previously, ustulation (Spandan Sharma) wrote…
> Maybe also include `ErrorKind::Interrupted` which is benign as well and not and error

Done.

src/igd/http_request.rs, line 150 [r2] (raw file):
Previously, vinipsmaker (Vinícius dos Santos Oliveira) wrote…
> That's why I wanted your review for. Gonna fix these errors.

Done.

Comments from Reviewable

This is no longer needed right now. Existing IGD has been intrgrated and crust is working fine with it.


Investigate why the reservations unittest suddenly starts failing

https://github.com/rogerthat-platform/rogerthat-backend/pull/262


No image renderer available/installed

Hi, I have created a dashboard using Grafana and I used grafana-reporter for download PDF. PDF is opened but the dashboard image is not displayed. I got the below error.

And I followed this link for grafana image renderer but it did not help me.
While I was installing it stuck like the below image.

Can anybody help me?

See https://grafana.com/docs/grafana/latest/administration/image_rendering/#troubleshoot-image-rendering for troubleshooting the image rendering.
Enabling the [log] option might give you a hint to what went wrong trying to render the image.
Usually it's a missing dependency.
(re-)installing chromium and maybe Xorg should give you all you need.

See https://grafana.com/docs/grafana/latest/administration/image_rendering/#troubleshoot-image-rendering for troubleshooting the image rendering.
Enabling the [log] option might give you a hint to what went wrong trying to render the image.
Usually it's a missing dependency.
(re-)installing chromium and maybe Xorg should give you all you need.


Unit Testing for the Keyframe Image Upload Java Servlet

This PR includes the following tests:

Tests for the POST and GET methods of the Keyframe Image Upload Servlet
Tests for the POST method of the Keyframe Image Delete Servlet (i.e. the delete method of keyframe images)
Tests for calling the DetectSafeSearchGcs' detectSafeSearchGcs() method, including tests for incorrect bucket url path formats
A Mockito Controller which mocks http request and response parameters and calls the POST and GET methods for KeyframeImageUploadServlet and KeyframeImageDeleteServlet

Sorry, I was trying to fix merge conflicts between this and cem-image-serving-and-effect and accidentally merged. For Di and Vikki, please still review this code and I will make the changes accordingly. Sorry about this!


[v2] Convert receivers to use App#processEvent

Summary
This receivers to use App#processEvent instead of being an event emitter as per #353
Depends on #369
NOTE I didn't include any documentation updates as #369 got giant because of it. They're in a separate pr #381
Requirements (place an x in each [ ])

[x] I've read and understood the Contributing Guidelines and have done my best effort to follow them.
[x] I've read and agree to the Code of Conduct.

Note, this pr is huge, I feel kinda bad about it.
There are really 3 refactors in it.

processEvent per #353
Converting coded errors and their helpers to be subclasses so they work in JS land as well as TS land
Pulling out the signature verification (discussion https://github.com/slackapi/bolt/pull/380#discussion_r374473361)

I've run out of time in the immediate future to make significant changes to anything except 1. I'm happy to remove 2 and 3 for easier reviews.
Otherwise, I feel good about all 3 and coverage is nice 🤷♂

First of all, I'd greatly appreciate @barlock's massive efforts and quality works (for not only this PR but the discussion and a series of PRs). Thank you very much again.
As for this PR, I don't have any concerns if we have all the three. This PR looks excellent to me.
I would like to hear other Bolt maintainers' thoughts!

It's ready!

Branches updated and ready to go again!

Related to this pr, but not caused by it, I discovered errors are being swallowed in event listeners here: https://github.com/slackapi/bolt/pull/380/files#diff-0286657a0789ea9446fa3de979ff3e09R559
Not sure why yet. I don't think it should hold this PR up as it's a bug in the last one. I'll see if I can identify the fix and either slip it in with a test case or follow up in a later pr.

@stevengill When I removed those tests you asked me to it dropped the coverage for the commit which apparently breaks codecov even though the pr as a whole raises it?
Can we remove that requirement or can I export some stuff so I can test it? You're not going to release v2 until you break those packages apart anyway?

@barlock we were planning on releasing v2 first and then breaking out those packages. If we expose an export to them, it means we need to continue to provide that export even after we break those packages out (or do another major version bump). We don't want to provide that export as people might start depending on it as they make their own receivers.
I'm personally fine with the drop.


Open to Unit Tests?

Hey there :wave:
I was looking into learning Godot.
As a software developer, I'm used to writing tests to help me learn a codebase.
I've seen Godot having GUT for this.
Would you be okay with adopting it? I can create a PR.

Hey, yes, unit tests are a really good thing. I just still didn't get into the habit of writing them before writing the working code. So feel free to do so, I have no problem with that 😊


Executing ‘run selection’ on function definition line (without selecting it) does not execute lines under it

Steps to reproduce:

Write some non-lambda function in the editor, e.g.

def afunction(x):
	x = x + 1
	return x

Click on the line that starts the function, without selecting any text (e.g. def afunction(x):)
Execute the keyboard shortcut for “run selection”

Expected behavior: should execute the whole function like in other IDEs.
Actual behavior: executes only the first line, and thus fails to define the function.

This is a known issue and not an easy one to fix, but thanks for reporting.


Fix Toggle Splits

Github Issue (if applicable): #969
Explanation of Bugfix/Feature/Enhancement:
A change was made where YNAB is no longer setting contentResults so we couldn't hijack the setter to filter split transactions anymore. Now we're hijacking the getter instead :pogchamp:
Recommended Release Notes:
Fixed a bug related to latest YNAB release.

@jorgehmv @Taytay

Thank you!


[skip ci] WIP: Fix dependency convergence issues

Addresses #1559
Helidon has transitive (or explicit and transitive) dependencies on both JBoss logging and Jakarta JSON along different dependency paths and the transitive dependencies are pulling in conflicting versions.
In OpenAPI, our dependency on SmallRye's OpenAPI pulls in JBoss logging. And an artifact outside of Helidon -- org.glassfish.jersey.media:jersey-media-json-binding-- itself depends on jarkata.json and also depends on yasson which in turn depends on a newer version of jakarta.json.

Tomas has taken on this work, so I'm closing this PR.


Can not add a removed node into the cluster

how to add a removed node into the cluster?

It is a feature. See the implementation in the link below.
https://github.com/lni/dragonboat/blob/79bcef060698c5c0e200c7f72fc3fda03b99feae/internal/rsm/membership.go#L134

Can the function be modified so that deleted nodes can be added to the cluster again after RemoveData is called?


Qingwei/remove page reload

Coverage increased (+0.06%) to 28.035% when pulling e3b35eb539672ced25e96e6e258e5cd67791d0c4 on qingweibinary:qingwei/remove_page_reload into 491c94dea74908492a705f4c77b4be17b5c6eeda on binary-com:master.

Coverage increased (+0.06%) to 28.035% when pulling e3b35eb539672ced25e96e6e258e5cd67791d0c4 on qingweibinary:qingwei/remove_page_reload into 491c94dea74908492a705f4c77b4be17b5c6eeda on binary-com:master.


clarify that modify_ack_deadline resets the deadline

source request

CLA signed.

@kir-titievsky do you mind taking a look to see if this satisfies your request?

@jonparrott: lgtm.
@opyate Thank you!

@googlebot yes, I consent.


Create a copy of the page collection for rendering purpose

Fixes an issue when looping through the pages collection in a page derails the rendering of other pages.
Fixes #57

Great, good thinking! Do you have merge access @LaurentGoderre? If so please feel free to merge and publish! If not, I'll add you so you can. Thanks!

I have merge access but try not to merge my own PRs

I just confirmed too, made sure you have admin access.

I have merge access but try not to merge my own PRs

awesome, thanks for asking for review first. we do the same when we're invited onto other projects. much appreciated but not required.

I don't however access to release to npm but it's not urgent. I'm trying to get our project upgrade to this and this and the render error that is fixed by upgrading the handlebars helpers are the last two issue stopping me.


vagrant up fails on OS X

I'm seeing rancher: ERROR: http://<IP_ADDRESS>:8080 is not accessible
Any suggestions on debugging?

$ uname -a
Darwin jw-macbook-pro.local 14.1.0 Darwin Kernel Version 14.1.0: Mon Dec 22 23:10:38 PST 2014; root:xnu-2782.10.72~2/RELEASE_X86_64 x86_64

$ vagrant version
Installed Version: 1.7.2
Latest Version: 1.7.2

You're running an up-to-date version of Vagrant!

$ vagrant up
Bringing machine 'rancher' up with 'virtualbox' provider...
==> rancher: Box 'coreos-alpha' could not be found. Attempting to find and install...
    rancher: Box Provider: virtualbox
    rancher: Box Version: >= 308.0.1
==> rancher: Loading metadata for box 'http://alpha.release.core-os.net/amd64-usr/current/coreos_production_vagrant.json'
    rancher: URL: http://alpha.release.core-os.net/amd64-usr/current/coreos_production_vagrant.json
==> rancher: Adding box 'coreos-alpha' (v598.0.0) for provider: virtualbox
    rancher: Downloading: http://alpha.release.core-os.net/amd64-usr/598.0.0/coreos_production_vagrant.box
    rancher: Calculating and comparing box checksum...
==> rancher: Successfully added box 'coreos-alpha' (v598.0.0) for 'virtualbox'!
==> rancher: Importing base box 'coreos-alpha'...
==> rancher: Matching MAC address for NAT networking...
==> rancher: Checking if box 'coreos-alpha' is up to date...
==> rancher: Setting the name of the VM: rancher_rancher_1424910970989_97700
==> rancher: Clearing any previously set network interfaces...
==> rancher: Preparing network interfaces based on configuration...
    rancher: Adapter 1: nat
    rancher: Adapter 2: hostonly
==> rancher: Forwarding ports...
    rancher: 8080 => 8080 (adapter 1)
    rancher: 22 => 2222 (adapter 1)
==> rancher: Running 'pre-boot' VM customizations...
==> rancher: Booting VM...
==> rancher: Waiting for machine to boot. This may take a few minutes...
    rancher: SSH address: <IP_ADDRESS>:2222
    rancher: SSH username: core
    rancher: SSH auth method: private key
    rancher: Warning: Connection timeout. Retrying...
    rancher: Warning: Connection timeout. Retrying...
    rancher:
    rancher: Vagrant insecure key detected. Vagrant will automatically replace
    rancher: this with a newly generated keypair for better security.
    rancher:
    rancher: Inserting generated public key within guest...
    rancher: Removing insecure key from the guest if its present...
    rancher: Key inserted!  Vagrant
assumes that this means the command failed. The output for this command
should be in the log above. Please read the output to determine what
went wrong.

That looks like an error we had on an older rancher/agent image.  @cloudnautique did we merge the agent register timeout bug?

@josephwinston Would you mind doing a vagrant destroy and then up again?  I believe the rancher/agent:latest tag was not pointed to the actual latest image.  I've changed the tag and that issue should be fixed.

@ibuildthecloud yeah it was merged but we left the tag as is because cattle would correct it.

I can interact with http://<IP_ADDRESS>:8080/  I think then it is working.
Here is the log if needed.
$ git pull
remote: Counting objects: 12, done.
remote: Compressing objects: 100% (10/10), done.
remote: Total 12 (delta 3), reused 0 (delta 0), pack-reused 2
Unpacking objects: 100% (12/12), done.
From https://github.com/rancherio/rancher
   9e9f8ff..020f0de  master     -> origin/master
 * [new tag]         agent-v0.4.0 -> agent-v0.4.0
Updating 9e9f8ff..020f0de
Fast-forward
 .gitignore                            |   1 +
 agent/.idea/.name                     |   1 -
 agent/.idea/encodings.xml             |   5 --
 agent/.idea/misc.xml                  |   5 --
 agent/.idea/modules.xml               |   9 ---
 agent/.idea/rancher-agent.iml         |   9 ---
 agent/.idea/scopes/scope_settings.xml |   5 --
 agent/.idea/vcs.xml                   |   7 --
 agent/.idea/workspace.xml             | 336 --------------------------------------------------------------------------------------
 agent/Dockerfile                      |   4 +-
 agent/run.sh                          |   6 +-
 11 files changed, 7 insertions(+), 381 deletions(-)
 delete mode 100644 agent/.idea/.name
 delete mode 100644 agent/.idea/encodings.xml
 delete mode 100644 agent/.idea/misc.xml
 delete mode 100644 agent/.idea/modules.xml
 delete mode 100644 agent/.idea/rancher-agent.iml
 delete mode 100644 agent/.idea/scopes/scope_settings.xml
 delete mode 100644 agent/.idea/vcs.xml
 delete mode 100644 agent/.idea/workspace.xml
$ vagrant destroy
    rancher: Are you sure you want to destroy the 'rancher' VM? [y/N] y
==> rancher: Forcing shutdown of VM...
==> rancher: Destroying VM and associated drives...
==> rancher: Running cleanup tasks for 'shell' provisioner...
==> rancher: Running cleanup tasks for 'shell' provisioner...
$ vagrant up
Bringing machine 'rancher' up with 'virtualbox' provider...
==> rancher: Importing base box 'coreos-alpha'...
==> rancher: Matching MAC address for NAT networking...
==> rancher: Checking if box 'coreos-alpha' is up to date...
==> rancher: Setting the name of the VM: rancher_rancher_1424923447886_16254
==> rancher: Clearing any previously set network interfaces...
==> rancher: Preparing network interfaces based on configuration...
    rancher: Adapter 1: nat
    rancher: Adapter 2: hostonly
==> rancher: Forwarding ports...
    rancher: 8080 => 8080 (adapter 1)
    rancher: 22 => 2222 (adapter 1)
==> rancher: Running 'pre-boot' VM customizations...
==> rancher: Booting VM...
==> rancher: Waiting for machine to boot. This may take a few minutes...
    rancher: SSH address: <IP_ADDRESS>:2222
    rancher: SSH username: core
    rancher: SSH auth method: private key
    rancher: Warning: Connection timeout. Retrying...
    rancher: Warning: Connection timeout. Retrying...
    rancher:
    rancher: Vagrant insecure key detected. Vagrant will automatically replace
    rancher: this with a newly generated keypair for better security.
    rancher:
    rancher: Inserting generated public key within guest...
    rancher: Removing insecure key from the guest if its present...
    rancher: Key inserted!  I did a vagrant destroy vagrant box update  and vagrant up.
± |master ✓| → vagrant up
Bringing machine 'rancher' up with 'virtualbox' provider...
==> rancher: Importing base box 'coreos-alpha'...
==> rancher: Matching MAC address for NAT networking...
==> rancher: Checking if box 'coreos-alpha' is up to date...
==> rancher: Setting the name of the VM: rancher_rancher_1429260152151_29129
==> rancher: Clearing any previously set network interfaces...
==> rancher: Preparing network interfaces based on configuration...
    rancher: Adapter 1: nat
    rancher: Adapter 2: hostonly
==> rancher: Forwarding ports...
    rancher: 8080 => 8080 (adapter 1)
    rancher: 22 => 2222 (adapter 1)
==> rancher: Running 'pre-boot' VM customizations...
==> rancher: Booting VM...
==> rancher: Waiting for machine to boot. This may take a few minutes...
    rancher: SSH address: <IP_ADDRESS>:2222
    rancher: SSH username: core
    rancher: SSH auth method: private key
    rancher: Warning: Connection timeout. Retrying...
    rancher:
    rancher: Vagrant insecure key detected. Vagrant will automatically replace
    rancher: this with a newly generated keypair for better security.
    rancher:
    rancher: Inserting generated public key within guest...
    rancher: Removing insecure key from the guest if its present...
    rancher: Key inserted!


Heimdall v1.4.0 fails setting up interaface when libusbx fails to build endpoint table

OS: OS X 10.8.4 Mountain Lion
Heimdall suite version: v1.4.0
Device:  Galaxy S2 LTE GT-i9210T
Other relevant information: Kies has never been installed on my computer, so the problem isn't related to that specific issue.
Steps to the error:

Installed the suite
Restarted the computer as advised
Put device into Download mode
Heimdall detects the device but I get a error produced from libusbx telling me it can't build a endpoint table.

Could it be that it fails iterating through all endpoints, hence not creating the endpoints table?
Thanks in advance for any help and for creating an option for us OS X users rather than installing Windows on a VM and using Odin!
Verbose output of the error:
$ sudo heimdall print-pit --verbose --stdout-errors
Heimdall v1.4.0

Copyright (c) 2010-2013, Benjamin Dobell, Glass Echidna
http://www.glassechidna.com.au/

This software is provided free of charge. Copying and redistribution is
encouraged.

If you appreciate this software and you would like to support future
development please consider donating:
http://www.glassechidna.com.au/donate/

Initialising connection...
Detecting device...
      Manufacturer: "Sasmsung"
           Product: "MSM8x60"

            length: 18
      device class: 2
               S/N: 0
           VID:PID: 04E8:685D
         bcdDevice: 0100
   iMan:iProd:iSer: 1:2:0
          nb confs: 1

interface[0].altsetting[0]: num endpoints = 1
   Class.SubClass.Protocol: 02.02.01
       endpoint[0].address: 82
           max packet size: 0010
          polling interval: 09

interface[1].altsetting[0]: num endpoints = 2
   Class.SubClass.Protocol: 0A.00.00
       endpoint[0].address: 81
           max packet size: 0200
          polling interval: 00
       endpoint[1].address: 01
           max packet size: 0200
          polling interval: 00
Claiming interface...
Setting up interface...
libusbx: error [get_endpoints] error getting pipe information for pipe 1: unknown error
libusbx: error [darwin_set_interface_altsetting] could not build endpoint table
ERROR: Setting up interface failed!
ERROR: Setting up interface failed!
Releasing device interface...

Same exact error with a Samsung Galaxy Tab 4

i suspect samsung's usb driver is locked out in firmware layer. bad fruit.
-rpp
On Sun, May 03, 2015 at 11:20 AM, JKGisMe <<EMAIL_ADDRESS><EMAIL_ADDRESS>> wrote:
Same exact error with a Samsung Galaxy Tab 4
—
Reply to this email directly or view it on GitHub
[https://github.com/Benjamin-Dobell/Heimdall/issues/137#issuecomment-98493261] .[https://github.com/notifications/beacon/AGLYbbCanqF2sPHLbBYx3PgwAslrt4hbks5oFjRLgaJpZM4Ay1n-.gif]

Has anyone figured this out yet? I'm getting the same lubusbx error during setting up interface with Galaxy Tab 3 7.0 T210R. Anyone know how to successfully root this thing?

Still happening with the 1.4.1 unofficial build with the Skyrocket on Yosemite. Is there a specific version of libusb we need to use? Or should we make our own build. Because I am currently stuck with a brick.

I have the same issue with Samsung Galaxy S4 GT-i9506 in Windows 10, using the latest night release.

Here some details which I did not manage to send to Cyanogenmod forum:
I follow these instructions found here wiki.cyanogenmod.org/w/Install_CM_for_ks01lte.
[CODE]

On the computer, open a terminal (or Command Prompt on Windows) in the directory where the recovery image is located and type:
heimdall flash --RECOVERY recovery.img --no-reboot
Tip: The file may not be named identically to what's in this command. If the file is wrapped in a zip or tar file, extract the file first, because heimdall isn't going to do it for you.
[/CODE]

I run heimdall flash --RECOVERY recovery.img --no-reboot in Windows 10 and in the folder where I have heimdall.exe and renamed recovery.img download from here download.cyanogenmod.org/?device=ks01lte with the date 2015-12-13 12:19:16.  I get

Initializing protocol... ERROR: failed to send data!Releasing device interface.

I tested many drivers (WinUSB, libusb-win32, libusbK) unsuccessfully with the command.
I do heimdall detect and get mostly

Device detected
but sometimes I get at the end of writing this thread
libusbx: error [init_device] device '\.\USB#VID_046E&PID_52CF&MI_01#7&194726C7&0&0001' is no longer connected!
Actually, I get the same error from heimdall print-pit --verbose.

How can you flash GT-i9606 successfully?

the same here on el capitain:
executing:
heimdall print-pit --verbose --usb-log-level debug
Heimdall v1.4.1

Copyright (c) 2010-2014 Benjamin Dobell, Glass Echidna
http://www.glassechidna.com.au/

This software is provided free of charge. Copying and redistribution is
encouraged.

If you appreciate this software and you would like to support future
development please consider donating:
http://www.glassechidna.com.au/donate/

Initialising connection...
Detecting device...
[timestamp] [threadID] facility level [function call] <message>
--------------------------------------------------------------------------------
[ 0.000548] [0000050f] libusbx: debug [libusb_get_device_list]
[ 0.002397] [0000050f] libusbx: debug [process_new_device] allocating new device for location 0x14000000
[ 0.002469] [0000050f] libusbx: debug [darwin_cache_device_descriptor] device descriptor:
[ 0.002482] [0000050f] libusbx: debug [darwin_cache_device_descriptor]  bDescriptorType:    0x01
[ 0.002492] [0000050f] libusbx: debug [darwin_cache_device_descriptor]  bcdUSB:             0x0100
[ 0.002502] [0000050f] libusbx: debug [darwin_cache_device_descriptor]  bDeviceClass:       0x09
[ 0.002512] [0000050f] libusbx: debug [darwin_cache_device_descriptor]  bDeviceSubClass:    0xff
[ 0.002522] [0000050f] libusbx: debug [darwin_cache_device_descriptor]  bDeviceProtocol:    0x00
[ 0.002532] [0000050f] libusbx: debug [darwin_cache_device_descriptor]  bMaxPacketSize0:    0x08
[ 0.002546] [0000050f] libusbx: debug [darwin_cache_device_descriptor]  idVendor:           0x05ac
[ 0.002557] [0000050f] libusbx: debug [darwin_cache_device_descriptor]  idProduct:          0x8005
[ 0.002567] [0000050f] libusbx: debug [darwin_cache_device_descriptor]  bcdDevice:          0x0198
[ 0.002577] [0000050f] libusbx: debug [darwin_cache_device_descriptor]  iManufacturer:      0x00
[ 0.002587] [0000050f] libusbx: debug [darwin_cache_device_descriptor]  iProduct:           0x00
[ 0.002599] [0000050f] libusbx: debug [darwin_cache_device_descriptor]  iSerialNumber:      0x00
[ 0.002609] [0000050f] libusbx: debug [darwin_cache_device_descriptor]  bNumConfigurations: 0x01
[ 0.002634] [0000050f] libusbx: debug [darwin_check_configuration] active config: 0, first config: 1
[ 0.002656] [0000050f] libusbx: debug [process_new_device] found device with address 0 port = 0 parent = 0x7fa1f3601ac8 at 0x0
[ 0.003228] [0000050f] libusbx: debug [process_new_device] allocating new device for location 0x14400000
[ 0.004149] [0000050f] libusbx: debug [darwin_cache_device_descriptor] device descriptor:
[ 0.004188] [0000050f] libusbx: debug [darwin_cache_device_descriptor]  bDescriptorType:    0x01
[ 0.004200] [0000050f] libusbx: debug [darwin_cache_device_descriptor]  bcdUSB:             0x0200
[ 0.004210] [0000050f] libusbx: debug [darwin_cache_device_descriptor]  bDeviceClass:       0x00
[ 0.004220] [0000050f] libusbx: debug [darwin_cache_device_descriptor]  bDeviceSubClass:    0x00
[ 0.004229] [0000050f] libusbx: debug [darwin_cache_device_descriptor]  bDeviceProtocol:    0x00
[ 0.004239] [0000050f] libusbx: debug [darwin_cache_device_descriptor]  bMaxPacketSize0:    0x08
[ 0.004250] [0000050f] libusbx: debug [darwin_cache_device_descriptor]  idVendor:           0x05ac
[ 0.004263] [0000050f] libusbx: debug [darwin_cache_device_descriptor]  idProduct:          0x0263
[ 0.004273] [0000050f] libusbx: debug [darwin_cache_device_descriptor]  bcdDevice:          0x0225
[ 0.004283] [0000050f] libusbx: debug [darwin_cache_device_descriptor]  iManufacturer:      0x01
[ 0.004293] [0000050f] libusbx: debug [darwin_cache_device_descriptor]  iProduct:           0x02
[ 0.004303] [0000050f] libusbx: debug [darwin_cache_device_descriptor]  iSerialNumber:      0x00
[ 0.004312] [0000050f] libusbx: debug [darwin_cache_device_descriptor]  bNumConfigurations: 0x01
[ 0.004361] [0000050f] libusbx: debug [darwin_check_configuration] active config: 1, first config: 1
[ 0.004376] [0000050f] libusbx: debug [process_new_device] found device with address 5 port = 4 parent = 0x7fa1f3601b88 at 0x7fa1f3601a30
[ 0.004978] [0000050f] libusbx: debug [process_new_device] allocating new device for location 0x14300000
[ 0.038127] [0000050f] libusbx: debug [darwin_cache_device_descriptor] device descriptor:
[ 0.038171] [0000050f] libusbx: debug [darwin_cache_device_descriptor]  bDescriptorType:    0x01
[ 0.038178] [0000050f] libusbx: debug [darwin_cache_device_descriptor]  bcdUSB:             0x0200
[ 0.038185] [0000050f] libusbx: debug [darwin_cache_device_descriptor]  bDeviceClass:       0x09
[ 0.038191] [0000050f] libusbx: debug [darwin_cache_device_descriptor]  bDeviceSubClass:    0x00
[ 0.038197] [0000050f] libusbx: debug [darwin_cache_device_descriptor]  bDeviceProtocol:    0x00
[ 0.038204] [0000050f] libusbx: debug [darwin_cache_device_descriptor]  bMaxPacketSize0:    0x08
[ 0.038210] [0000050f] libusbx: debug [darwin_cache_device_descriptor]  idVendor:           0x0a5c
[ 0.038216] [0000050f] libusbx: debug [darwin_cache_device_descriptor]  idProduct:          0x4500
[ 0.038223] [0000050f] libusbx: debug [darwin_cache_device_descriptor]  bcdDevice:          0x0100
[ 0.038229] [0000050f] libusbx: debug [darwin_cache_device_descriptor]  iManufacturer:      0x01
[ 0.038236] [0000050f] libusbx: debug [darwin_cache_device_descriptor]  iProduct:           0x02
[ 0.038242] [0000050f] libusbx: debug [darwin_cache_device_descriptor]  iSerialNumber:      0x00
[ 0.038249] [0000050f] libusbx: debug [darwin_cache_device_descriptor]  bNumConfigurations: 0x01
[ 0.038280] [0000050f] libusbx: debug [darwin_check_configuration] active config: 1, first config: 1
[ 0.038290] [0000050f] libusbx: debug [process_new_device] found device with address 12 port = 3 parent = 0x7fa1f35017d8 at 0x7fa1f3601a30
[ 0.038711] [0000050f] libusbx: debug [process_new_device] allocating new device for location 0x14330000
[ 0.072382] [0000050f] libusbx: debug [darwin_cache_device_descriptor] device descriptor:
[ 0.072414] [0000050f] libusbx: debug [darwin_cache_device_descriptor]  bDescriptorType:    0x01
[ 0.072425] [0000050f] libusbx: debug [darwin_cache_device_descriptor]  bcdUSB:             0x0200
[ 0.072435] [0000050f] libusbx: debug [darwin_cache_device_descriptor]  bDeviceClass:       0xff
[ 0.072445] [0000050f] libusbx: debug [darwin_cache_device_descriptor]  bDeviceSubClass:    0x01
[ 0.072455] [0000050f] libusbx: debug [darwin_cache_device_descriptor]  bDeviceProtocol:    0x01
[ 0.072465] [0000050f] libusbx: debug [darwin_cache_device_descriptor]  bMaxPacketSize0:    0x40
[ 0.072479] [0000050f] libusbx: debug [darwin_cache_device_descriptor]  idVendor:           0x05ac
[ 0.072489] [0000050f] libusbx: debug [darwin_cache_device_descriptor]  idProduct:          0x8289
[ 0.072499] [0000050f] libusbx: debug [darwin_cache_device_descriptor]  bcdDevice:          0x0118
[ 0.072509] [0000050f] libusbx: debug [darwin_cache_device_descriptor]  iManufacturer:      0x01
[ 0.072518] [0000050f] libusbx: debug [darwin_cache_device_descriptor]  iProduct:           0x02
[ 0.072528] [0000050f] libusbx: debug [darwin_cache_device_descriptor]  iSerialNumber:      0x00
[ 0.072538] [0000050f] libusbx: debug [darwin_cache_device_descriptor]  bNumConfigurations: 0x01
[ 0.072581] [0000050f] libusbx: debug [darwin_check_configuration] active config: 1, first config: 1
[ 0.072596] [0000050f] libusbx: debug [process_new_device] found device with address 15 port = 3 parent = 0x7fa1f3407768 at 0x7fa1f3501740
[ 0.073205] [0000050f] libusbx: debug [process_new_device] allocating new device for location 0x14100000
[ 0.073511] [0000050f] libusbx: debug [darwin_cache_device_descriptor] device descriptor:
[ 0.073538] [0000050f] libusbx: debug [darwin_cache_device_descriptor]  bDescriptorType:    0x01
[ 0.073549] [0000050f] libusbx: debug [darwin_cache_device_descriptor]  bcdUSB:             0x0200
[ 0.073559] [0000050f] libusbx: debug [darwin_cache_device_descriptor]  bDeviceClass:       0x02
[ 0.073569] [0000050f] libusbx: debug [darwin_cache_device_descriptor]  bDeviceSubClass:    0x02
[ 0.073579] [0000050f] libusbx: debug [darwin_cache_device_descriptor]  bDeviceProtocol:    0x00
[ 0.073589] [0000050f] libusbx: debug [darwin_cache_device_descriptor]  bMaxPacketSize0:    0x40
[ 0.073603] [0000050f] libusbx: debug [darwin_cache_device_descriptor]  idVendor:           0x04e8
[ 0.073634] [0000050f] libusbx: debug [darwin_cache_device_descriptor]  idProduct:          0x685d
[ 0.073644] [0000050f] libusbx: debug [darwin_cache_device_descriptor]  bcdDevice:          0x0000
[ 0.073654] [0000050f] libusbx: debug [darwin_cache_device_descriptor]  iManufacturer:      0x01
[ 0.073663] [0000050f] libusbx: debug [darwin_cache_device_descriptor]  iProduct:           0x02
[ 0.073673] [0000050f] libusbx: debug [darwin_cache_device_descriptor]  iSerialNumber:      0x03
[ 0.073683] [0000050f] libusbx: debug [darwin_cache_device_descriptor]  bNumConfigurations: 0x01
[ 0.073725] [0000050f] libusbx: debug [darwin_check_configuration] active config: 1, first config: 1
[ 0.073739] [0000050f] libusbx: debug [process_new_device] found device with address 10 port = 1 parent = 0x7fa1f3501898 at 0x7fa1f3601a30
[ 0.073867] [0000050f] libusbx: debug [libusb_get_device_descriptor]
[ 0.073885] [0000050f] libusbx: debug [libusb_get_device_descriptor]
[ 0.073893] [0000050f] libusbx: debug [libusb_get_device_descriptor]
[ 0.073900] [0000050f] libusbx: debug [libusb_get_device_descriptor]
[ 0.073908] [0000050f] libusbx: debug [libusb_get_device_descriptor]
[ 0.073918] [0000050f] libusbx: debug [libusb_unref_device] destroy device 20.0
[ 0.073938] [0000050f] libusbx: debug [libusb_unref_device] destroy device 20.5
[ 0.073949] [0000050f] libusbx: debug [libusb_unref_device] destroy device 20.12
[ 0.073959] [0000050f] libusbx: debug [libusb_unref_device] destroy device 20.15
[ 0.073971] [0000050f] libusbx: debug [libusb_open] open 20.10
[ 0.074550] [0000050f] libusbx: debug [usbi_add_pollfd] add fd 6 events 1
[ 0.074570] [0000050f] libusbx: debug [darwin_open] device open for access
[ 0.074606] [0000050f] libusbx: debug [libusb_get_device_descriptor]
[ 0.074664] [0000050f] libusbx: debug [libusb_get_next_timeout] no URB with timeout or all handled by OS; no timeout!
[ 0.074682] [0000050f] libusbx: debug [libusb_handle_events_timeout_completed] doing our own event handling
[ 0.074693] [0000050f] libusbx: debug [handle_events] poll() 2 fds with timeout in 60000ms
[ 0.074892] [00000e03] libusbx: debug [darwin_async_io_callback] an async io operation has completed
[ 0.074937] [0000050f] libusbx: debug [handle_events] poll() returned 1
[ 0.074951] [0000050f] libusbx: debug [op_handle_events] checking fd 4 with revents = 0
[ 0.074962] [0000050f] libusbx: debug [op_handle_events] checking fd 6 with revents = 1
[ 0.074976] [0000050f] libusbx: debug [darwin_handle_callback] handling control completion with kernel status 0
[ 0.074986] [0000050f] libusbx: debug [usbi_handle_transfer_completion] transfer 0x7fa1f37001b0 has callback 0x10b651260
[ 0.074997] [0000050f] libusbx: debug [ctrl_transfer_cb] actual_length=4
[ 0.075061] [0000050f] libusbx: debug [libusb_get_next_timeout] no URB with timeout or all handled by OS; no timeout!
[ 0.075076] [0000050f] libusbx: debug [libusb_handle_events_timeout_completed] doing our own event handling
[ 0.075087] [0000050f] libusbx: debug [handle_events] poll() 2 fds with timeout in 60000ms
[ 0.075214] [00000e03] libusbx: debug [darwin_async_io_callback] an async io operation has completed
[ 0.075257] [0000050f] libusbx: debug [handle_events] poll() returned 1
[ 0.075272] [0000050f] libusbx: debug [op_handle_events] checking fd 4 with revents = 0
[ 0.075282] [0000050f] libusbx: debug [op_handle_events] checking fd 6 with revents = 1
[ 0.075296] [0000050f] libusbx: debug [darwin_handle_callback] handling control completion with kernel status 0
[ 0.075306] [0000050f] libusbx: debug [usbi_handle_transfer_completion] transfer 0x7fa1f34074c0 has callback 0x10b651260
[ 0.075317] [0000050f] libusbx: debug [ctrl_transfer_cb] actual_length=16
      Manufacturer: "SAMSUNG"
[ 0.075377] [0000050f] libusbx: debug [libusb_get_next_timeout] no URB with timeout or all handled by OS; no timeout!
[ 0.075391] [0000050f] libusbx: debug [libusb_handle_events_timeout_completed] doing our own event handling
[ 0.075402] [0000050f] libusbx: debug [handle_events] poll() 2 fds with timeout in 60000ms
[ 0.075610] [00000e03] libusbx: debug [darwin_async_io_callback] an async io operation has completed
[ 0.075650] [0000050f] libusbx: debug [handle_events] poll() returned 1
[ 0.075664] [0000050f] libusbx: debug [op_handle_events] checking fd 4 with revents = 0
[ 0.075674] [0000050f] libusbx: debug [op_handle_events] checking fd 6 with revents = 1
[ 0.075688] [0000050f] libusbx: debug [darwin_handle_callback] handling control completion with kernel status 0
[ 0.075698] [0000050f] libusbx: debug [usbi_handle_transfer_completion] transfer 0x7fa1f3501210 has callback 0x10b651260
[ 0.075709] [0000050f] libusbx: debug [ctrl_transfer_cb] actual_length=4
[ 0.075764] [0000050f] libusbx: debug [libusb_get_next_timeout] no URB with timeout or all handled by OS; no timeout!
[ 0.075778] [0000050f] libusbx: debug [libusb_handle_events_timeout_completed] doing our own event handling
[ 0.075789] [0000050f] libusbx: debug [handle_events] poll() 2 fds with timeout in 60000ms
[ 0.075847] [00000e03] libusbx: debug [darwin_async_io_callback] an async io operation has completed
[ 0.075875] [0000050f] libusbx: debug [handle_events] poll() returned 1
[ 0.075887] [0000050f] libusbx: debug [op_handle_events] checking fd 4 with revents = 0
[ 0.075897] [0000050f] libusbx: debug [op_handle_events] checking fd 6 with revents = 1
[ 0.075910] [0000050f] libusbx: debug [darwin_handle_callback] handling control completion with kernel status 0
[ 0.075920] [0000050f] libusbx: debug [usbi_handle_transfer_completion] transfer 0x7fa1f3501210 has callback 0x10b651260
[ 0.075931] [0000050f] libusbx: debug [ctrl_transfer_cb] actual_length=38
           Product: "SAMSUNG USB DRIVER"
[ 0.075976] [0000050f] libusbx: debug [libusb_get_next_timeout] no URB with timeout or all handled by OS; no timeout!
[ 0.075990] [0000050f] libusbx: debug [libusb_handle_events_timeout_completed] doing our own event handling
[ 0.076000] [0000050f] libusbx: debug [handle_events] poll() 2 fds with timeout in 60000ms
[ 0.076109] [00000e03] libusbx: debug [darwin_async_io_callback] an async io operation has completed
[ 0.076134] [0000050f] libusbx: debug [handle_events] poll() returned 1
[ 0.076145] [0000050f] libusbx: debug [op_handle_events] checking fd 4 with revents = 0
[ 0.076155] [0000050f] libusbx: debug [op_handle_events] checking fd 6 with revents = 1
[ 0.076168] [0000050f] libusbx: debug [darwin_handle_callback] handling control completion with kernel status 0
[ 0.076178] [0000050f] libusbx: debug [usbi_handle_transfer_completion] transfer 0x7fa1f3501210 has callback 0x10b651260
[ 0.076188] [0000050f] libusbx: debug [ctrl_transfer_cb] actual_length=4
[ 0.076228] [0000050f] libusbx: debug [libusb_get_next_timeout] no URB with timeout or all handled by OS; no timeout!
[ 0.076240] [0000050f] libusbx: debug [libusb_handle_events_timeout_completed] doing our own event handling
[ 0.076251] [0000050f] libusbx: debug [handle_events] poll() 2 fds with timeout in 60000ms
[ 0.076353] [00000e03] libusbx: debug [darwin_async_io_callback] an async io operation has completed
[ 0.076383] [0000050f] libusbx: debug [handle_events] poll() returned 1
[ 0.076408] [0000050f] libusbx: debug [op_handle_events] checking fd 4 with revents = 0
[ 0.076419] [0000050f] libusbx: debug [op_handle_events] checking fd 6 with revents = 1
[ 0.076434] [0000050f] libusbx: debug [darwin_handle_callback] handling control completion with kernel status 0
[ 0.076434] [0000050f] libusbx: debug [darwin_handle_callback] handling control completion with kernel status 0
[ 0.076444] [0000050f] libusbx: debug [usbi_handle_transfer_completion] transfer 0x7fa1f3501210 has callback 0x10b651260
[ 0.076455] [0000050f] libusbx: debug [ctrl_transfer_cb] actual_length=42
         Serial No: "   SAMSUNG SERIAL BULK"

            length: 18
      device class: 2
               S/N: 3
           VID:PID: 04E8:685D
         bcdDevice: 0000
   iMan:iProd:iSer: 1:2:3
          nb confs: 1
[ 0.076502] [0000050f] libusbx: debug [libusb_get_config_descriptor] index 0

interface[0].altsetting[0]: num endpoints = 1
   Class.SubClass.Protocol: 02.02.01
       endpoint[0].address: 83
           max packet size: 0010
          polling interval: 09

interface[1].altsetting[0]: num endpoints = 2
   Class.SubClass.Protocol: 0A.00.00
       endpoint[0].address: 81
           max packet size: 0200
          polling interval: 00
       endpoint[1].address: 02
           max packet size: 0200
          polling interval: 00
Claiming interface...
[ 0.076561] [0000050f] libusbx: debug [libusb_claim_interface] interface 1
[ 0.077464] [0000050f] libusbx: debug [get_endpoints] building table of endpoints.
[ 0.077487] [0000050f] libusbx: debug [get_endpoints] interface: 1 pipe 1: dir: 1 number: 1
[ 0.077497] [0000050f] libusbx: debug [get_endpoints] interface: 1 pipe 2: dir: 0 number: 2
[ 0.077524] [0000050f] libusbx: debug [darwin_claim_interface] interface opened
Setting up interface...
[ 0.077536] [0000050f] libusbx: debug [libusb_set_interface_alt_setting] interface 1 altsetting 0
[ 0.079706] [0000050f] libusbx: debug [get_endpoints] building table of endpoints.
[ 0.079735] [0000050f] libusbx: error [get_endpoints] error getting pipe information for pipe 1: unknown error
[ 0.079868] [0000050f] libusbx: error [darwin_set_interface_altsetting] could not build endpoint table
ERROR: Setting up interface failed!
Releasing device interface...
[ 0.079898] [0000050f] libusbx: debug [libusb_release_interface] interface 1

[ 0.079909] [0000050f] libusbx: debug [libusb_close]
[ 0.079991] [0000050f] libusbx: debug [usbi_remove_pollfd] remove fd 6
[ 0.080016] [0000050f] libusbx: debug [libusb_unref_device] destroy device 20.10
[ 0.080024] [0000050f] libusbx: debug [libusb_exit]
[ 0.080030] [0000050f] libusbx: debug [libusb_exit] destroying default context


Update btrfs-driver.md

Please sign your commits following these rules:
https://github.com/docker/docker/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:
$ git clone -b "patch-8" git@github.com:mqliang/docker.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f

Ammending updates the existing PR. You DO NOT need to open a new one.

@mqliang please sign off your commits, also see my comments on your other PRs

@thaJeztah PR updated. Sorry for the inconvenience bring to you, it's blame on me.

Thanks! LGTM