Add icons and separator per lang

For ruby, I'd like to be able to see the location in ruby's standard format, like ::Namespace::Class#method. My solution was to use the icons to define the proper separators and disable the global separator. But, on the other hand, for other languages, like lua, I'd like to keep the default behavior. For this reason, I propose to enables the user to set icons and separator by language type, like:
gps.setup({
  icons = {
    ['class-name'] = ' ',
    ['function-name'] = ' ',
    ['method-name'] = ' ',
    ['container-name'] = ' ',
    ['tag-name'] = ' ',
    ['ruby'] = {
      ['class-name'] = '::',
      ['function-name'] = '.',
      ['method-name'] = '#',
      ['container-name'] = '::',
      ['tag-name'] = '',
    },
  },
  separator = {
    default = ' › ',
    ruby = '',
  },
})

** config

** ruby

** lua

@SmiteshP, if you like the approach I can add the documentation. 😄

I like the idea of having language specific icons, but I don't think this will be a good way to implement it. Writing custom transforms would become a more complicated as every time we will have to check if custom icons are defined or not.
I think a more cleaner approach will be to have a single table that has all icons to be used for the current file type, and that table get updated using a BufEnter autocmd. This should minimize unnecessary if else statements and keep the code clean and simple.

I think a more cleaner approach will be to have a single table that has all icons to be used for the current file type, and that table get updated using a BufEnter autocmd. This should minimize unnecessary if else statements and keep the code clean and simple.

I am not able to put my thoughts properly into words 😆 , but I have a pretty clear idea of how I want to implement this. Let me know if you understand what I am saying. Anyways I will try to work on this soon if possible. 😄

@SmiteshP, I think I understood. To be honest, the first version I tried to make the smallest change possible to implement the idea. Now that you mentioned the number of ifs, another though I had was to use lua metatable __index to set the default icons/separator. (https://www.lua.org/manual/5.4/manual.html#2.4)
I don't want to push my implementation too much, but another idea would be to always have the default key for any language, and the user could add the keys for the desired languages, like:
gps.setup({
  icons = {
    default = {
      ['class-name'] = ' ',
      ['function-name'] = ' ',
      ['method-name'] = ' ',
      ['container-name'] = ' ',
      ['tag-name'] = ' ',
    },
    ruby = {
      ['class-name'] = '::',
      ['function-name'] = '.',
      ['method-name'] = '#',
      ['container-name'] = '::',
      ['tag-name'] = '',
    },
  },
  separator = {
    default = ' › ',
    ruby = '',
  },
})

In lua, when a table key doesn't exist, it calls the table __index from its metatable, this way we wouldn't need to populate a table with vim BufEnter event, but we also wouldn't have so many ifs in the code.
This is implemented on another commit, what do you think?

Using meta-tables is an interesting idea. I should definitely read up about them 😆
I think I would prefer to work on this on my own, I also want to add ability to define unique icons for some special languages like YANG (related PR #24). I think I can solve both these issues with a single implementation.
Thanks for the ideas, I will use the PR as a reference. :)

Closing in favor of #32

I also want to add ability to define unique icons for some special languages like YANG (related PR #24)

I now you're working on that on the other MR, but just to keep track, the approach here would also enable the users to have special icons per language. (😄 again, just commenting to keep historical information here for future reference)

the approach here would also enable the users to have special icons per language.

Ok, In that case this seems to be a better implementation than my PR #32 . 😄

Tried it out just now, it is throwing a lot of errors when scrolling through this init.lua file. Also, the separator doesn't seem to be working too. I would like you to continue working on this and fix the issues.

@SmiteshP, can you post your configuration so I can try the same setup, please?

Tried it out just now, it is throwing a lot of errors when scrolling through this init.lua file
Thanks for pointing that up, I think all the errors are fixed now.

I would like you to continue working on this and fix the issues. Also keep in mind the use case of PR #24, to be able to have language specific icons by default that can be overridden by users.

That's great! I'm glad to work on that. 😄
I think we need to define how you'd like to keep the setup structure. As I mentioned on your PR, I think a good, user-friendly, way would be something like:
 {
  -- all the default behavior would be inside the "default".
  -- If new _default configs_ were  created they should go inside this  key
  defaults = {
    separator = ' > ',
    icons = {
      ["class-name"] = ' ',
      ["function-name"] = ' ',
      ["method-name"] = ' ',
      ["container-name"] = '⛶ ',
      ["tag-name"] = '炙'
    }
  },
  -- All the language specific behavior could go inside the lang name key
  -- This way, in the future we could move the transformations to these keys to be
  -- overridable by the user as well.
  bash = { disable = true },
  go = { disable = true },
  cpp = {
    separator = '»',
    icons = {
      ["class-name"] = '',
      ["function-name"] = '',
      ["method-name"] = '',
      ["container-name"] = '',
      ["tag-name"] = ''
    }
  },
  --- ...
}

With this config, the code could either load the language config when loading the buffer, like you did on https://github.com/SmiteshP/nvim-gps/pull/32, or just use table fallbacks like I did in this PR:
current_config = config[filelang] or config.defaults
-- the use current_config on all the functions.

What do you think?

@SmiteshP, I'm having some trouble in finding time to work on that, but I started a total revamp of the configuration. It's a bit different of my original proposal, but I think it'd make the code more maintainable and the setup process more clear and powerful to users. The difference of my original proposal is to put the languages overrides under a override key on the table, this way the users could even override the transform function, since I move it to the config table, somethig like:
{
  -- all the default behavior would be inside the "default".
  -- If new _default configs_ were  created they should go inside this  key
  defaults = {
    separator = ' > ',
    icons = {
      ["class-name"] = ' ',
      ["function-name"] = ' ',
      ["method-name"] = ' ',
      ["container-name"] = '⛶ ',
      ["tag-name"] = '炙'
    },
    transform = function(capture_name, capture_text, config)
      if config.icons[capture_name] then
        return config.icons[capture_name] .. capture_text
      else
        return capture_text
      end
    end
  },
  -- All the language specific behavior could go inside the lang name key
  -- This way, in the future we could move the transformations to these keys to be
  -- overridable by the user as well.
  override = {
    bash = { enabled = false },
    cpp = {
      transform = function(capture_name, capture_text, config)
        if capture_name == "multi-class-name" then
          return config.icons["class-name"]..string.gsub(capture_text, "%s*%:%:%s*", config.separator..config.icons["class-name"])
        else
          return config.transform(capture_name, capture_text, config)
        end
      end
    },
    ruby = {
      separator = '',
      icons = {
        ["class-name"] = '',
        ["function-name"] = '',
        ["method-name"] = '',
        ["container-name"] = '',
        ["tag-name"] = ''
      }
    },
  }
  --- ...
}

The code was updated with this proposal, but I didn't test it too much.
I know this is a huge change, maybe we can break it down and introduce smaller changes per PR to make it easier to test and revert in case of failures, what do you think?

I don't think its a good idea to expose transform functions to end users, because anyways they don't have control over the queries.

Also, if we don't move the icons and seperator under defaults table and instead of overrides use languages, we might be able to make this change without any breaking changes. What do you think? I would prefer if there weren't any breaking changes for end user.

@SmiteshP, I updated the description. Changes:

Now the configuration is backwards compatible
The user can change icons and separator per language
The user can add custom icons
The is_available() is calculated based on:

if the user ran the setup();
if the user enabled/disabled the language;
if there's a parser for the language;
if there's a querye for the language;
and the result is cached in a buffer variable (b:nvim_gps_available)

transform_lang and configs uses lua metatable to fallback to their defaults

What do you think of this new approach?

Hey @kassio ! Sorry for the delay :(
I will test this out as soon as possible.

What do you think of this new approach?

Yep, I like this approach for is_available! This removes the table filled with langname = true

I just tested it out. Its working great!
The setup time has also decreased significantly 😄

Could you add info about this new feature in the README. Then I will merge this :)

Hey! I just found a bug
when I changed the default_config to this inside the init.lua. With default setup function.
local default_config = {
	enabled = true,
	icons = {
		["class-name"] = ' ',
		-- ["function-name"] = ' ',
		["method-name"] = ' ',
		["container-name"] = '⛶ ',
		["tag-name"] = '炙'
	},
	languages = {
		cpp = {
			["function-name"] = 'func '
		}
	},
	separator = ' > ',
}

the function icon won't appear in c++ files. This is something that would be used in languages like YANG (PR #24 )
Where there would be language specific icons defined because they don't fit class, method, function paradigm.

@SmiteshP,

Hey! I just found a bug

I'll work on fix that later today and add the README information. 🏃


Unable to install with Swift Package Manager

Running swift build results in the following error:
Fetching https://github.com/amadeus4dev/amadeus-swift.git
error: the package dependency graph could not be resolved; unable to find any available tag for the following requirements:
    https://github.com/amadeus4dev/amadeus-swift.git @ 1.0.0..<2.0.0

By the time of this writing there were no git tags indeed.

Hi Cristian, sorry for my late response!
The SDK is not fully stable and that's why we didn't release (tag) any 1.0.0 version yet. In the meantime, if you want to test the SDK, try to use 'master' branch as dependency on your Package.swift:
.package(
    url: "https://github.com/amadeus4dev/amadeus-swift",
    .branch("master")
)

We hope to release a stable version very soon. Stay tuned!


fill-column indicator module is no longer working after chaning min emacs version to 27.1

[X] I have searched the FAQ and the documentation for solutions.
[X] I have searched the issue tracker for similar issues (the closed issues too).
[X] I have searched the Discourse for any errors and solutions.
[X] I can reproduce my issue on the latest commit of Doom Emacs.
[X] I have read How to Debug Issues and found no solution.

What did you expect to happen?
Enabling fill-column module in init.el, should automatically enable display-fill-column-indicator-mode
What actually happened?
Even after enabling fill-column module, display-fill-column-indicator is not enabled on any of the major-modes in emacs. I tried running doom sync multiple times, but the issue is not resolved.
Describe your attempts to resolve the issue
I manually enabled fill column indicators for org-mode, conf-mode and prog-mode by using hooks.
Steps to reproduce
Enable fill-colmn module in init.el
run doom sync
restart emacs and open any programming language file
System Information
https://pastebin.com/avRSkTrE

The fill-column module was removed because it became too trivial once we dropped 26.x support in 044a1a5f2. display-fill-column-indicator is built into Emacs 27.1+. To activate it add (add-hook 'doom-first-buffer-hook #'global-display-fill-column-indicator-mode).
As this is not a bug I will close this.

Thanks for the quick response and tips on activation.


fix: support client side initAuth

You can use this version with ssr: false
Original ssr version from docs:
export const actions = {
  nuxtServerInit ({ commit, dispatch }, { req }) {
    return initAuth({
      commit,
      dispatch,
      req,
      moduleName: 'auth',
      cookieName: 'feathers-jwt'
    })
  },
  nuxtClientInit ({ state, dispatch, commit }, context) {
    // Run the authentication with the access token hydrated from the server store
    if (state.auth.accessToken) {
      return dispatch('auth/onInitAuth', state.auth.payload)
    }
  }
}

You can use the new version for client side only also:
export const actions = {
  nuxtClientInit ({ state, dispatch, commit }, context) {
    // Run the authentication without server side hydration
    initAuth({
      commit,
      dispatch,
      moduleName: 'auth',
      cookieName: 'feathers-jwt'
    }).then(()=> {
      if (state.auth.accessToken) {
        return dispatch('auth/onInitAuth', state.auth.payload)
      }
    })
  }
}

@GaborTorma Thanks for this!  Could you also open this same PR against the vue-demi branch?  If not let me know and I'll create an issue so it doesn't get lost.


Export extra data?

Hi, and thank you for making this project available.
Will it work with moving cameras?
Is it possible to export the clean background as rgb frames, and the segmentation masks as frames, as well as the animated 3d mesh?
Thanks!

Hi, thanks for your interest. Yes, it works for moving cameras and you can export everything you mentioned by running our algorithm. But in case of dynamic cameras, our rendered background is not that compelling compared to videos with static cameras. You can refer to the Fig.16 of our supplementary document  to see more examples of our background rendering.


monit issue: All events disabled - but still sending alert notifications via mail

Describe the bug
I wanted to monitor a link of the FW itself. I was not very sure which of the "Events" I should use under "Alert settings". Therefore I tried it with trial and error. I ended up with "Do not send alerts for the following events but on all others." enabled and checked all items one by another until all were checked.
Basically I would expect that when I set "Do not send alerts for the...." and I have checked all of them, that no emails about the Link Down would be send in any way. Suprisingly I still get emails. Even with everything "disabled"
I've reloaded the plugin also many times. Result is the same.
As all are disabled, and I'm still getting the mails, I assume some setting must be hidden in the drop down list and I cannot see it.
=> What would be the correct "Event" for this type I'm looking for?
To Reproduce
Steps to reproduce the behavior:

Go to Services - monit - settings - Alert Settings - pass your email settings
Click on "not on"
Select "all" Events
go to Service Settings - add new e.g LINK_DOWN
Type = Network, Add IP of one of your interfaces of the FW, Tests; NetworkLink, Rest standard...

Expected behavior
With the given settingsI would not expect to get an alarm via email.
Describe alternatives you considered
=> Like said, I did trial and eror to find the correct "Event" in fact even when all are disabled due to the "no", I get what I wanted.
But with a very strange behavior.
Relevant log files
If applicable, information from log files supporting your claim.
Environment
OPNsense 20.7.1 (amd64, OpenSSL).

reopen another one "complete"


test: fix delegate cosmos teston LLD

📝 Description
fix issue on the delegate Comos tests on LLD.
how ? the amount to allow staking has changed so they were not enough found to trig the staking flow.
User data file has been to updated with enough found to run the test.
❓ Context

Impacted project: LLD delegate cosmos

✅ Checklist

[ ] Test coverage
[ ] Atomic delivery
[ ] No breaking changes

📸 Demo

🚀 Expectations to reach
Please make sure you follow these Important Steps.
Pull Requests must pass the CI and be internally validated in order to be merged.

/generate-screenshots


Unable to find Zeal.settings-user in windows

Unable to find the settings file for the plugin on windows on fresh install on SublimeText 3

Oops I was searching for my User directory. You should specify sublime user directory in the readme.


Feature/adding some load tests

Description
Adding a couple tests for contraction and misspelling

Adding tests, discussed offline merging without review.


Pseudo PR - DO NOT MERGE

Pseudo-PR for review of full pipeline prior to initial release, as described in https://nf-co.re/developers/adding_pipelines#core-pipeline-review
Do not merge - this PR just provides an interface to look over and comment on all pipeline code. Any suggestions can be applied to the dev branch and this PR will automatically update. Once it has two community reviews, preferably one from someone in @nf-core/core , it can be closed and release 1.0 can go.

How do I correct changes and push to this protected branch?

You can make a PR to dev and I'll review these changes there directly

@ggabernet I've made a bunch of small changes in this dsl2 -> dev PR that should address most of your recommendations I hope.

Hi @drpatelh
I think I resolved your comments. To be pulled in from https://github.com/nf-core/bactmap/pull/39

Great work all! Pipeline looks awesome :)


Heartbeat Retry Interval time (seconds) not working

Is it a duplicate question?
No.
Describe the bug
I noticed this issue since 1.7.0, but I was unsure it was a configuration error from my side or a bug...
The setting Heartbeat Retry Interval time in seconds is not working.
Screenshot settings:

When a service goes down, it should retry 3 times every 60 seconds before it sends a notification the service is down.
Screencapture: https://user-images.githubusercontent.com/8298741/135232370-e0cd2714-80dc-4c39-beb8-39badebf913e.mp4
As you can see in this screencapture, all three (3) Heartbeat Retries are send within one (1) minute and  the service is marked as down.
Expected behavior
Retries: 3
Heartbeat Retry Interval: 60
Send 3 heartbeats every 60 seconds before the service is marked as down and a notification is sent.
Info
Uptime Kuma Version: 1.7.0.
Using Docker?: Yes
OS: Ubuntu 21.04
Browser: Chrome

Thanks for the report, I have addressed the problem, will release 1.7.2.

1.7.3 is available now


Animal crossing example documentation

Do you happen to have the documentation for the Animal Crossing protocol, or did you just reverse the single finding island with Dodo code feature?
Also, do you have a documentation on the setup you use on capturing the traffic to avoid getting banned?

There isn't much documentation about AC:NH currently. It uses a combination of NEX and a custom HTTP API. If you want to find out something specific, I would recommend inspecting the traffic.
Capturing traffic should be safe. My own setup is as follows:

Use exefs_patches to disable CA verification.
Run Charles on a laptop and enable SSL proxying.
Configure the IP address and port of the Charles proxy in the system settings on the Nintendo Switch.

Any other proxy that can intercept SSL traffic should work just as well though.
Some servers, such as dauth, require a device certificate. In this case, you have two options:

If you want to capture the traffic to these servers: configure Charles to use your device certificate in the connection with these servers.
If you don't care about the traffic: add the servers to the SSL blacklist, such that Charles does not try to intercept the communication with these servers.


RFC 59: Get rid of upwards propagation of clock domains.

Rendered

More generally, since we have a pending full redesign of the system, we should probably not add functionality we might have to deprecate later, if it's avoidable.

We have discussed this RFC on the 2024-03-25 weekly meeting. The disposition was to merge.


crypto/tls: expose implemented cipher suites

Allows to dynamically retrieve a list of available cipher suites. This change allows a variety of applicatoins:

Enable all available ciphers programmatically, without hardcoding, and always refering to the latest set of implemented ciphers
Filter ciphers by desired flags and use them dynamically, without hardcoding, and always refering to the latest set of implemented ciphers
Build application configs for user-decided selection of ciphers to allow

Ciphers are returned as copies, in order to avoid messing up internal stuff.
In contrast to the already discussed solutions, this one reduced the amount of necessary changes. Maintainability will be equal to before. This should not contain any breaking changes, as it only makes former private variables public, respectively, adds functions.
Fixes #30325 and #21167

The CLA hasn't been signed in over a month, and the patch now has conflicts; closing for now. If both are solved, feel free to reopen or post a new PR.


Update to use jersey and cloudant

@rvennam

Looks good! Next step would be to use spring cloud connectors


Does not resize when the state of the child changes.

If one of the children changes state, then the height remains the same even if it has changed.

same here

same here

Any update? :(

Finally found solution with contentsize_tabbarview: ^0.0.2


Plat 305: smexecute migration and counter

- What I did

counters are now incremented only if we acquired lock for execution
if counter is increased VE will be able continue to runner on migration
if lock was not acquired VE will not continue request processing and will not touch SMObject

- How I did it
ControlledSlotMachine now can migrate in between step, big thanks to @cyraxred and @bigbes
- How to verify it
run tests

Please also consider
https://github.com/insolar/assured-ledger/compare/PLAT-305_smexecute_migration...NOISSUE-step-debug-improvements


league/flysystem": "^2.0" Released，recommended to update

Laravel Version: 8.x
PHP Version: 8.0
Database Driver & Version:

Description:
league/flysystem": "^2.0" Released，recommended to update
Steps To Reproduce:

Will come in Laravel 9


Set response Content-length to prevent 'Transfer-Encoding: chunked'

Recently, I tried to use docker for linux to run my ASP .NET Core project based on .net core 3.0, but, some problems blocked me all day.
After published the application on docker successfully for the first time,  error appeared when I visited the home page

I run curl http://localhost:5001/Account/Login on server

https://github.com/aspnet/KestrelHttpServer/issues/2417 told me that Kestrel always add transfer-encoding: "chunked" response header by design

So, one workaround is to add Content-Length to response header to prevent Transfer-Encoding: chunked
I customized a middleware like this:
public class CustomMiddleware
{
    private readonly RequestDelegate _next;

    public CustomMiddleware(RequestDelegate next)
    {
        _next = next;
    }

    public async Task Invoke(HttpContext context)
    {
        var originalBody = context.Response.Body;
        using (var ms = new MemoryStream())
        {
            context.Response.Body = ms;
            long length = 0;
            context.Response.OnStarting((state) =>
            {
                context.Response.Headers.ContentLength = length;
                return Task.FromResult(0);
            }, context);
            await _next(context);
            length = context.Response.Body.Length;
            context.Response.Body.Position = 0;
            await ms.CopyToAsync(originalBody);
        }
    }
}

Middleware order:
app.UseHttpsRedirection();
app.UseStaticFiles();

app.UseRouting();
app.UseAuthentication();
app.UseAuthorization();

app.UseMiddleware<CustomMiddleware>();

app.UseEndpoints(endpoints =>
{
    endpoints.MapControllerRoute(
        name: "default",
        pattern: "{controller=Home}/{action=Index}/{id?}");
});

Unfortunately, it still doesn't work. I tried to access /User/Index while it would redrict to the login page due to the Authorize attribute on UserController. After login, I accessed the page again, it shows this

the docker logs as follows

At last, I create MemoryStream directly instead of using using.
public async Task Invoke(HttpContext context)
{
    var originalBody = context.Response.Body;
    var ms = new MemoryStream();
    context.Response.Body = ms;
    long length = 0;
    context.Response.OnStarting((state) =>
    {
        context.Response.Headers.ContentLength = length;
        return Task.FromResult(0);
    }, context);
    await _next(context);
    length = context.Response.Body.Length;
    context.Response.Body.Position = 0;
    await ms.CopyToAsync(originalBody);
}

Amazing, everything is OK, what happeded? Is there a better solution?

Your original incomplete chunked encoding error implies there was an exception after the response started and the response had to be aborted by closing the connection. Check the app logs for that original scenario.
Buffering the response adds memory and latency overhead and should be avoided.

it's my fault, thanks


Hi! I'm good at asynchronous loading screens. thank you! But I have one problem.

GetMoviePlayer()->IsLoadingFinished() There is a problem that this function is not called. Do you know the cause?
What I want is for that function to be called and the loading screen to end.

GetMoviePlayer()->IsLoadingFinished() It does not return true even though the map has finished loading.  Do you know the cause?
What I want is for that function to be called and the loading screen to end.


Added missing export of createUseSignalREffect hook

Request to added missing createUseSignalREffect

Why you need this function?
useSignalREffect has is your context you should use it

Why you need this function?
useSignalREffect has in your context you should use it

There are no export for useSignalREffect hook.

Why you need this function?
useSignalREffect has in your context you should use it

I need to custom for advance use.

This is internal function, it is unstable because maybe we change it in the future. I recommended don't use it.
What is your custom usage.


Mutiple Audio Output Selection

Description of the new feature / enhancement
Add ability to select multiple audio output when needed
Scenario when this would be used?
It can be used when multiple audio devices are connected to the computer
Supporting information
No response

/dup #24869


chore(main): release 1.3.1

:robot: I have created a release beep boop
1.3.1 (2023-04-19)
Bug Fixes

deps: update dependency colorette to v2.0.20 (#191) (932053b)
deps: update dependency commander to v10.0.1 (#192) (cd96d24)
deps: update dependency undici to v5.21.2 (2177b41)
deps: update dependency ytdl-core to v4.11.3 (2d55597)
deps: update dependency ytdl-core to v4.11.4 (#190) (9b35a24)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/EvolutionX-10/Ariaa/releases/tag/v1.3.1 :sunflower:


gRPC 1.2.0 compatibility

Updates the C bindings and wrapper code for gRPC 1.2.0. This will only be compatible with 1.2.0 (and possibly 1.1.4) because of changes in the C API. Basically, gpr_slice was replaced with grpc_slice and several functions/structs that used to use char* are now using grpc_slice. This required some fixes in the Unsafe and LowLevel layers. From a practical perspective, it looks like quite a few bugs and performance problems have been fixed in the C gRPC library since version 1.0.
Additionally, I updated the nix expressions to pin to the new 17.03 release, so I could pull in protobuf3_2. This in turn required relaxing the cabal dependency bounds in a few places.

Yes, thanks @crclark, sorry I wasn't able to get to this earlier in the week! Thanks @Gabriel439 for reviewing.


combine float and sink mixins

the gif shows the default properties

@incuna/frontend please review

Coool ! I like it !


[FEATURE] Clear filters for map

Description
Create a clear filters tag/button for the map page to be able to reset the data. Currently the only path to do this is refreshing the browser.
Screenshots

Additional information
No response

Hello, I was wondering if I could be assigned to work on this issue. I am very interested in contributing and would love the opportunity to do so. Thank you!

Hello, I was wondering if I could be assigned to work on this issue. I am very interested in contributing and would love the opportunity to do so. Thank you!

Assigned! Thank you for contributing


Missing 1st point of variable Rage

STR:

Run default char.
Press 'minus' rage button.
Press 'default' rage button.
Result:
There is no abalible variable rage points.

If press 'plus' the 2nd point is marked.

https://github.com/darkmind/resources/commit/a8c23683c1e2c9d82a65c8264edfb96d6ce506c1


ElectricPy website bug

Describe the bug
A clear and concise description of what the bug is.
Reproduction Code
docsource/index.rst
# Setup
-------------------------
Contents:
-------------------------

.. toctree::
   :maxdepth: 1

   electricpyapi
   constants
   additionalresources
   changes
   Github <https://github.com/engineerjoe440/ElectricPy>
   PyPI <https://pypi.org/project/electricpy>

# Code which causes failure
   Github <https://github.com/engineerjoe440/ElectricPy>
   PyPI <https://pypi.org/project/electricpy>

Expected behavior
proper logo rendering

Screenshots
Acutal web site

Additional context
ElectricPy { URL from google top search )
Our documentation html page is not rendered properly try to correct docsource/index.rst

Looks like this might be something related to the transition to use ReadTheDocs: https://electricpy.readthedocs.io/en/latest/
That said, there's still some issues there:

OK! I think I've corrected this with the use of the MyST-Parser package (rather than m2r2, which seems to have been the culprit). I'll note that the change is only relevant on the GH-pages site, and the develop branch of the ReadTheDocs site as of this moment in time. It'll update the latest branch when we cut a new release of ElectricPy (which I'll need to start thinking about, here, pretty soon).


arelle: 2017-06-01 -> 2017-08-24

Motivation for this change
fixes tests for python 3.6.
Remove \m from regex (not supported anymore)
Also, implicitly specify from arelle import in Cntlr in CntlrProfiler.py
arelle released a new release for RedHat on 2017-08-24, so I'm considering code from that date a stable release.
tests break on headless expecting tkinter library, so tests are only ran on when gui == true.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] Linux

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

@roberth can I get a review since your the maintainer?

@disassembler, thank you for looking into this. Removing the \m seems to be the right thing to do. I'll check with the author to be sure, but the spec seems to suggest it is ok. Looks good to me, but I can't merge it because github doesn't know I'm the maintainer. Calling @chaoflow


Frontend: Use Swift introduction as the default inlining availability floor instead of ABI stability

Replace the abi magic value accepted by -target-min-inlining-version with a min magic value instead. The new value corresponds to the OS versions in which Swift was introduced. The introduction OS is a better floor for availability checking than the OS in which Swift became ABI stable because inlinable functions may reference clang declarations which have availability between Swift's introduction and ABI stability. Framework developers ought to get diagnostics for unguarded use of those clang APIs in inlinable code.
Resolves rdar://90184740

This came out of feedback @lorentey had on https://github.com/apple/swift/pull/41789.

@swift-ci please test

@swift-ci please clean test macOS


📝 Add documentation URL to pyproject.toml

Codecov Report

Merging #47 (eebd75a) into master (4307868) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #47   +/-   ##
=======================================
  Coverage   96.07%   96.07%
=======================================
  Files           8        8
  Lines         561      561
=======================================
  Hits          539      539
  Misses         22       22

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4307868...eebd75a. Read the comment docs.


Update ms graph android sdk to java sdk

Update MSGraphServiceClientManager class
Update MSGraphServiceController class

@deepak2016 @jthake-msft Please review the pr for the update and pull in. Thanks

Each training repo actually has a completed project with it as well. For the PR to be approved, you would need to submit the PR with those changes also. I would actually just pull down the repo and run that completed project to validate this works ok, rather than follow the lab steps.

@jthake-msft  Sorry for missing code file changes. But it seems that I didn't have write permission to this repo, my push failed with the permission denied. Could you add write permission for me?

The way we do this is via submitting PRs. We do not need to grant permissions directly to the repo. If you reject your own PR and then submit a new PR with the branch with the completed project folder location that would be great!


chore: Fix script not found

Pull Request
Description
This change optimises the Dockerfile and run script:

Simplifies the COPY command for run.sh by using the --chmod flag to set permissions in a single step.
Updates the ENTRYPOINT to directly execute run.sh without invoking sh.
Changes the shebang in run.sh from #!/bin/bash to #!/bin/sh for better compatibility with Alpine Linux.

These modifications streamline the Docker image build process and improve the execution of the entry point script.
fixes #92

Merge activity

Sep 30, 2:38 PM EDT: @JackPlowman started a stack merge that includes this pull request via Graphite.


fix: Validate requestRedirect with backendrefs

What type of PR is this?

/kind bug
/kind test
What this PR does / why we need it:
Validate and  Prevent Redirect Filters and BackendRefs in same HTTPRoute Rules.
Which issue(s) this PR fixes:

Fixes #2148
Does this PR introduce a user-facing change?:

/ok-to-test

@slayer321 The job failed due to a lint error:
./hack/invalid-examples/v1beta1/httproute/invalid-request-redirect-with-backendref.yaml
  16:19     error    no new line character at the end of file  (new-line-at-end-of-file)
[0;31mTest FAILED: hack/../hack/verify-yamllint.sh
make: *** [Makefile:114: verify] Error 1

Hi, as api-verify CI is failing so I tried running the golangci-lint run command .. but it is just showing Killed
sachinmaurya@sachin:~/go/src/github.com/gateway-api (test-request-route-w-backend-ref)$ golangci-lint run
WARN [runner] The linter 'structcheck' is deprecated (since v1.49.0) due to: The owner seems to have abandoned the linter.  Replaced by unused.
WARN [runner] The linter 'deadcode' is deprecated (since v1.49.0) due to: The owner seems to have abandoned the linter.  Replaced by unused.
WARN [runner] The linter 'varcheck' is deprecated (since v1.49.0) due to: The owner seems to have abandoned the linter.  Replaced by unused.
Killed

What can be the reason for that :thinking:

golangci-lint run

@slayer321  can you rebase to main and try ./hack/verify-golint.sh ?

I tried it but still got below error
sachinmaurya@sachin:~/go/src/github.com/gateway-api (test-request-route-w-backend-ref)$ ./hack/verify-golint.sh
level=warning msg="[runner] Can't run linter goanalysis_metalinter: musttag: running `go list all`: exit status 1"
level=error msg="Running error: 1 error occurred:\n\t* can't run linter goanalysis_metalinter: musttag: running `go list all`: exit status 1\n\n"

After looking for it , I found that there where many similar errors but nothing same as this one. most of them says that we need to run go build.
has anyone else faced the similar error while working on this project or is it some issue with my local setup.

@slayer321 I don't have idea about it. Even if you can't run the ./hack/verify-golint.sh in your environment, you can find the details from the CI job logs: https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/kubernetes-sigs_gateway-api/2161/pull-gateway-api-verify/1676963399549849600

/release-note "Webhook validation now ensures that BackendRefs can not be specified in the same HTTPRoute rule as a Redirect filter"

/release-note-edit Webhook validation now ensures that BackendRefs can not be specified in the same HTTPRoute rule as a Redirect filter

Thanks @slayer321!
/lgtm
/approve


Document AWS logger and video recorder containers

Need to document how to use Moon with S3 bucket with role-based access.

Won't fix as Moon 2.0.0 containers are based on aws-cli and so support both role-based and static credentials.


[T4A5][T13-B4] Aloisius Stephen

Good job. Let's write more comments to explain what each class does and how they are linked with each other.

alright, thank you


Configure a custom domain for the project

Currently, this example is running on Heroku on the following domain - https://hacksoft-styleguide-example.herokuapp.com/
Configure it so it's running on something like styleguide-example.hacksoft.io

https://django-styleguide.hacksoft.io/ :heavy_check_mark:


Requires gcloud to build docker image

Can a different build method be provided?

yes, the command in the build script is just an example. feel free to use any build method you prefer.


Update the top level Merlin image to include new libraries

This is the existing image:
https://developer.nvidia.com/sites/default/files/akamai/merlin/recommender-systems-dev-web-850.svg

@mikemckiernan , please take a look. close it if its already done.


Document ignoreChanges support for paths (nested properties)

ignoreChanges supports providing paths to nested properties, but this is not yet documented at https://www.pulumi.com/docs/intro/concepts/programming-model/#ignorechanges.  We should add docs on this.

Addressed in #4861


Add content between head tags

Hi,
Is it possible to add content between <head> and </head> tags? Actually, I want and insert CSS or JS links there. Hope there has a way.
Thanks.

You can't add anything to the head tag directly. Your content will be added to the body, but you can still use link or script tags there.
Here's a simple demo for loading jQuery and Bootstrap:
http://jsbin.com/woneka/edit?html,js,output

Why not just include options for script, css, etc.  and when the iframe is created, add those?


Fails to load from Google Drive

When I log in I get the following message

This app is blocked
This app tried to access sensitive info in your Google Account. To keep your account safe, Google blocked this access.

The app had been verified in the past but Google has changed a few things and now they need to review it again. The Google Drive integration is momentarily not working but I am in the middle of the procedure.

Thanks @vcoppe, I really like your app, and I'm sure that its hard to keep up with Google.

It should work correctly again, can you confirm?
Don't hesitate to leave a review here, the score suffered a bit from this issue.

It works!


Would you add tls-.dns.alidns DNS Providers plug-in ?

I find the code here but i dont know how to add it .I almost have no idea about golang https://godoc.org/github.com/go-acme/lego/providers/dns/alidns.

Read before ask.
https://github.com/mholt/caddy/wiki/Plugging-in-Plugins-Yourself

For any future usage questions, please ask on https://caddy.community. This is the issue board for bugs and feature requests.


Remove installation of libevent from the build

Gevent now uses libev and it already provides it.

Hi! This PR has been untouched for a very long time so I am closing it. Let me know if this was a mistake and feel free to open it again.


Instructions for running on localhost, or a server on my LAN?

I'd like to run this code on either my localhost, or a server on my LAN, so it will work even when the internet is down or being flaky.  What am I missing?

That's fair @JamesDBartlett3, I've now added a clarification to the readme file:
This project runs right in the web browser; you can serve it from any HTTP/HTTPS server with no additional setup.
For instance, when I test it locally on my Mac, I just cd to my git repo and python3 -m http.server, like a chump. GitHub Pages is honestly more stringent than the environment I locally host it in, with its CORS and its relative path shenanigans. 😁

Thanks for clarifying that. 😊👍
If I may make a suggestion, I think it would be very helpful if you included that "for instance" bit with the python command in your readme as well.
All of the open source web apps I've worked with so far came with their own dedicated launch commands, like npm start, yarn start, etc., so the idea that I could just throw this code into a directory, fire up any ol' web server daemon there, and point my browser directly at localhost didn't occur to me. I think I was expecting something more complicated. 😅
If you hadn't added that bit at the end, I think I'd still be scratching my head, though I'm probably a lot less savvy than most folks who find this repo and decide to play with it, so I dunno. 🤷♂


Error reporting seriously lags behind

The extension is very slow to realize when errors have been resolved. Doing Java: Clean Workspace clears the false positives, but that's not a solution (and sometimes the cleaning itself hangs and I need to restart VS Code altogether).

I think some a little bit more description of what exactly you do and see would be helpful. I don't normally see very slow error updates, but there's probably some information I am missing. One particular thing that comes to mind is whether the errors get updated if you do File/Save All. Thanks!

Here's an example of 2 warnings which persist, even after saving all files. Maybe the logs in #65 can help. They contain warnings like:
WARNING [org.netbeans.modules.java.hints]: document changed, but not canceled?
WARNING [org.netbeans.modules.java.hints]: len = 872
WARNING [org.netbeans.modules.java.hints]: startOffset = 872
WARNING [org.netbeans.modules.java.hints]: endOffset = 872

An example of autocompletion lagging behind:
in file ContentNormalizer.java I've changed the second record component from boolean dirtyBit to List<String> reasonsForRewriting:

However, when attempting to adapt code in other classes, autocompletion still only gives the old component:

Another example where adding a method isn't noticed elsewhere in the code (even after having saved all files and running a Maven build outside VS Code to verify this is indeed a false positive):

Another example. I just opened VS Code, opened the file, deleted a block of code within a method which had no impact on the correctness of the method (verified with a successful mvn clean verify outside VS Code), yet suddenly it gives me the error below:

where links is defined as:
var links = new ArrayList<String>();

Note how the first line correctly says for join(String,List<String>) (for which there are suitable methods), but then during the actual matching it seems to think there's a variable of type Path involved.

This NetBeans issue which I filed at the time was very similar.
For reproducing, making a change like adding a parameter to a method, renaming a method, removing an enum constant (all without using a refactoring) should do the trick. I just tried:

renaming an enum constant: a usage of the constant elsewhere (in a class in another package) was not detected as an error
adding a parameter to a method: invocations of the method elsewhere (in a class in another package) were not detected as an error (navigating to the method from the other class, opens the file that contains the method at the beginning of the file)

Doing Java: Clean Workspace does mark the errors due to the changes.

Closing this issue due to inactivity. If you encounter this issue again or have any further questions please feel free to reopen it.


Trick bundler into correctly building D3

Closes #3672
It appears that this is tricking parcel into correctly importing d3 by including a reference to the library in the module syntax-tree (I guess).
The library is referenced, but no calls are made.

including a reference to the library in the module syntax-tree

Yes, neat, this is why adding the debug message console.log(d3) probably  fixed it too.

Works for me as well - hooray Jordan!


Fix typo, schema to scheme

Please apply this patch.

Thanks for the fix.
Finally got to merge it in.
Sorry for the delay.


Enable Yaw Damper function

This change enables the yaw dampening function of the autopilot and makes the button in the cockpit functional.

Thank you very much for this!


Get Rid of Flash Profile editor.

We should really get rid of the Flash Profile editor, there is no reason why we can't use Korvin's editor or even just a basic jquery plugin to crop and rotate.

I think it'd be nice to have a simplified, in-page version of the image editor

I just wanted to give this a bump since users on the forum and Slack have asked about it.

+1 Flash is not just dead, it's a security hazard. Somebody is going to get hacked...

+1. Chrome is no longer supporting Flash by default. We need to replace it.

A while back I did some experiments with webcam access on JavaScript: see https://mlocati.github.io/js-webcam-screenshot/
The problem is that AFAIK recently Chrome requires HTTPS in order to use webcams (so, https://mlocati.github.io/js-webcam-screenshot/ works but http://mlocati.github.io/js-webcam-screenshot/ doesn't)

Is webcam support required? If not, users could just upload their own webcam/regular images, then use the core Image Editor to crop/resize it. I imagine dropping webcam support would reduce the complexity. I would be curious to know how often the feature is used (webcam image capture).

The webcam support was really cool and definitely a feature that we really wanted when we tasked that profile picture editor to a former employee – but given how long in the tooth flash is it's definitely not a deal breaker if we can get something else working in its place. We definitely would want to use the JS image editor as a basis for whatever we include though

Another bump, I'm trying to set up a pretty custom profile page right now and running into issues where I can't preview what it would look like with an avatar because I can't run flash under chrome. Can we at least get this by version 9?

+1 for getting rid of Flash in concrete5.
You may be loosing potential new users.
I was considering concrete5 as a possible alternative to Drupal until I noticed the Flash requirements, pretty jarring discovery.

This has come up again as my client was testing the application and they were prompted to install flash. We really need to get this updated to something javascript based. As is, I might end up doing a custom upload and requiring people to crop their images square before uploading. Not ideal, but better than requiring flash.

In our C5DK Blog package we actually solved this problem (creating custom thumbnails out of original image) by using the https://github.com/fengyuanchen/cropper
It look like this:

This is complete! 🎉

It would be neat if you could replace this on your own website too


Unable to customize default handlers in Story

export default {
  title: 'Example',
  parameters: {
    msw: {
      handlers: [
        rest.get('/foo', ....),
        rest.get('/bar', ....),
      ]
    }
} satisfies Meta<Props>;

type Story = StoryObj<Props>;

export const Story: Story = {
  parameters: {
    msw: {
      handlers: [
        // Overwrite or add a handler here; you lose the /bar handler here
        rest.get('/foo', ....)
      ]
    }
  }
};

So in the "Story" story, you lose the /bar handler. My expectation was that I could add or overwrite any default handlers in a story.

RTFM: https://github.com/mswjs/msw-storybook-addon#composing-request-handlers

I guess the piece that was unclear and tripped me up for a while is the fact that all parameters.msw.handlers need to be objects with keys in order for inheritance to work as expected, in the default exports and in individual stories. The Composing request handlers doesn't explicitly state this is the case. Of course in hind site this totally makes sense now.
@yannbf I created #158 to address this in the README and hopefully make this clearer for the next dev.


Update branch name

Main is the branch name.
Also to trigger doc build action to test the recent changes.

New Documenter key seems to be correct, it did not deploy though (until we merge this PR)
Deployment criteria for deploying preview build from GitHub Actions:
- ✔ ENV["GITHUB_REPOSITORY"]="Tractables/DirectedAcyclicGraphs.jl" occurs in repo="github.com/Tractables/DirectedAcyclicGraphs.jl.git"
- ✔ ENV["GITHUB_REF"] corresponds to a PR number
- ✘ `push_preview` keyword argument to deploydocs is `true`
- ✔ ENV["GITHUB_ACTOR"] exists
- ✔ ENV["DOCUMENTER_KEY"] exists
Deploying: ✘

Seems deployed succesfully after merging the PR:
https://github.com/Tractables/DirectedAcyclicGraphs.jl/actions/runs/8748220177/job/24007909648
Deployment criteria for deploying devbranch build from GitHub Actions:
- ✔ ENV["GITHUB_REPOSITORY"]="Tractables/DirectedAcyclicGraphs.jl" occurs in repo="github.com/Tractables/DirectedAcyclicGraphs.jl.git"
- ✔ ENV["GITHUB_EVENT_NAME"]="push" is "push"
- ✔ ENV["GITHUB_REF"] matches devbranch="main"
- ✔ ENV["GITHUB_ACTOR"] exists
- ✔ ENV["DOCUMENTER_KEY"] exists
Deploying: ✔

Yes, looks good! https://tractables.github.io/DirectedAcyclicGraphs.jl/dev/


CQ-4351390 - File Attachment preview fix

Description
Fix for File attachment preview.
Bug present in fileinputwidget.
Also changed Prefill and Submit services to different names to avoid conflictwith v1 services.

Related Issue
https://jira.corp.adobe.com/browse/CQ-4351390

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] I have signed the Adobe Open Source CLA.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes and the overall coverage did not decrease.
[ ] All unit tests pass on CircleCi.
[ ] I ran all tests locally and they pass.

@TalmizAhmed Build is failing, please check the logs and fix the PR

Please check and fix this.


Unable to find custom job in lib/ directory

I just deployed a change to my Rails app where instead of calling @label_sheet.render.delay I enqueue a custom job with Delayed::Job.enqueue LabelSheetJob.new(@label_sheet.id).
The custom job is in the lib/ directory and looks like:
class LabelSheetJob < Struct.new(:label_sheet_id)
  def perform
    LabelSheet.find(label_Sheet_id).render
  end
end

This was all working fine the previous way, and works fine the new way in development, but now in production the jobs all fail with Job failed to load: uninitialized constant LabelSheetJob. Handler: \"--- !ruby/struct:LabelSheetJob \\nlabel_sheet_id: 4721\\n\".
When I fire up the Rails console, I can successfully execute YAML.load handler where handler is the string from any of the failed jobs, for example "--- !ruby/struct:EmailJob \nlabel_sheet_id: 4721\n".
The workers are running via rake jobs:work, managed by Ubuntu's Upstart (config generated by Foreman).
How can I get the workers to find my custom job class in production?
Rails 3.0.9
Delayed Job 2.1.14
Ubuntu 10.04

Try adding a require 'label_sheet_job' somewhere like an initializer.

I added that line to my existing DJ initializer, restarted the Rails app and restarted the rake task.
Same problem unfortunately.

By the way, I already have my lib directory added to config.autoload_paths in config/application.rb.

I found the problem and it wasn't Delayed Job.
Upstart manages by rake jobs:work processes, and its configuration is generated by Foreman.  However that configuration had paths hard-coded to an old release of my app.  Updating the Upstart configuration and restarting fixed everything.
It turns out I didn't need a require in an initializer.
Thanks for your help -- I appreciate it.


🐾 Process-supervised RM Trainer

What does this PR do?
Adding support for process-supervised reward training to TRL as requested in #2110 .
List of papers using PRMs: [1], [2], [3], [4]...
Fixes # (issue)
#2110
Before submitting

[X] This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
[X] Did you read the contributor guideline,
Pull Request section?
[X] Was this discussed/approved via a GitHub issue? Please add a link
to it if that's the case.
[X] Did you make sure to update the documentation with your changes? Here are the
documentation guidelines.
[X] Did you write any new necessary tests?

Who can review?
@lewtun @kashif

Hey @lewtun, thank you for the message. Currently, the only files that are more or less ready are prm_trainer.py and prm_config.py. The rest are just placeholders that I haven’t had the opportunity to work on yet.
Implementing a PRMs seems to be pretty straighforward, it seems to be a token classification task where only prediction for the last token of each step gets assigned a label and other tokens are ignored during loss calculation.
If the dataset isn’t pre-tokenized, I assume it should contain the following columns:

prompt: Either a string or past messages
steps: A list of strings
labels: A list of integers corresponding to the label associated to each step

Are you aware of an HF dataset to train PRMs for the example file? Also, how can I add a new subset to the trl-internal-testing/zen dataset to support stepwise reward models for the unit test of the prm_trainer?
Thanks again for your time!

PR ready for review.
Tests: I created a dummy_dataset but we should add a subset to trl-internal-testing/zen as done in other scripts.
Example: The example is currently using a placeholder for the dataset name as to the best of my knowledge trl didn't release a dataset for stepwise reasoning on HF. We should add this too.

Thanks for looking at this @lewtun. Seems like trl-internal-testing/zen is the dataset you are using for testing. I have done a PR to trl-lib/zen, should I also PR trl-internal-testing/zen to add 19 samples of PRM800K for testing or are you handling it on your side?

Seems like trl-internal-testing/zen is the dataset you are using for testing. I have done a PR to trl-lib/zen, should I also PR trl-internal-testing/zen to add 19 samples of PRM800K for testing or are you handling it on your side (it looks like they are both the same dataset)?

trl-lib/zen is a mistake. I'll remove it. Can you make the PR to trl-internal-testing/zen?

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Thanks a lot @gaetanlop! I left some comments.
I think we need to first define a new standard for the dataset required here. I prefer working on it an another PR: #2148.
Once we've merged #2148 we'll need to update this one.
Feel free to share your thoughts in #2148 btw.

Thanks for the reviews @qgallouedec. I will wait that #2148 is completed and merged before resolving your comments. Don't hesitate to ping me here when you have done your decisions regarding the new standard dataset format.

hi,a good job?  when  will this be merged?

Hey @lewtun @qgallouedec, thanks for the reviews. I will incorporate your comments by the end of the week. I should be able to run the experiments on my side and share some logs here.

I think the user should be able to train on the last step only (still framing it as a token classification task).
Looking at prm800k, training the model to predict the correctness of each step in a solution means that we will train the very same prefix solution multiple times (look at the first 6 rows for example). A better approach for this dataset seems to be training the model to predict the correctness of only the last step in the solution, not the intermediate ones. For this approach, if the model is autoregressive, scoring all steps of a solution in one forward pass during inference is still possible without training-inference mismatch.
The sentence from the OpenAI paper Let's verify step by step seems to support this: “We train our PRMs by fine-tuning the MathMix model to predict the probability of positive, negative, and neutral labels given a solution prefix ending in one of our labeled steps.” (refer to Appendix F1 for more details).

This would require either letting the user specify an ignore step value in labels (1, 0 or -100) or just specify that we want to train on the last step only in the config. What's your preference?

PR #2148 do not introduce any conversational dataset format for Stepwise trainings. Is this an oversight or is this on purpose? I think supporting conversational datasets is important as reward models are usually initialized with the sft models.

The dataset config standard_step for zen seems to not be available. The tests won't pass. I have let the PR in DRAFT mode.

We now have have a dataset for testing:
>>> from datasets import load_dataset
>>> dataset = load_dataset("trl-internal-testing/zen", "standard_stepwise_supervision")
>>> dataset["train"][4]
{'prompt': 'Flat is better than', 'completions': [' in terms of structure,', ' nested.'], 'label': [True, False]}

@qgallouedec the term used for the labels in standard_stepwise_supervision and prm800K differs, prm800K uses labels while standard_stepwise_supervision uses label.

@gaetanlop about the tokenize function, it would be better to

have it as a static method
using it with a single example (not a batch).

In fact take example from the implementation of DPOTrainer. I can fix this quickly. I offer to do a PR on your branch, wdyt?

@qgallouedec yes of course, as you prefer, I was following the implementation done in the KTOTrainer. You can open a PR otherwise I will make the changes later today

Should we add the separator token between the prompt and the first step? If you don't (like the current code) you get something like:
prompt = "This is my prompt."
completions = ["This is my first step.", "This is my second step."]
separator = "\n"

# Processing here

result == ""This is my prompt.This is my first step. This is my second step."

https://github.com/gaetanlop/trl/pull/1
I still need to add the collator and then it's ready

First trained model: https://huggingface.co/qgallouedec/Qwen2-0.5B-Reward

Thank you for the refactoring work on the tokenize_row function, @qgallouedec. I have made some adjustments to ensure proper handling of special tokens. Also, I refined the label creation process and updated the tokenize_row function to support truncation based on both max_length and max_completion_ids. I have added some tests to confirm that the updated tokenize_row function behaves as intended.
I believe the PR is ready

Thanks, good catch aa33e6292a4b65df5c0cfd478722a0bfb6c11fcc! I don't know how the training code worked without it, maybe with the padding?

to ensure proper handling of special tokens

Yes that was my question with 228aa31268b40a638a59f07bd5578670bb9bd850. Do you have any example of decoder model that have a bos_token?

With the fix it seems to overfit. Is it related to the redundancy in the data?

Hey it might be good to run a test on the Math-Shepherd dataset: https://huggingface.co/datasets/peiyi9979/Math-Shepherd
It will need to be formatted in our schema, but has the advantage of not being derived from multi-step human preferences and should give a clearer signal / speed up debugging

Yes good idea, would you like this dataset to be in trl-lib ?

Yes good idea, would you like this dataset to be in trl-lib ?

I'm on it

Finally... So data cleaning was needed: https://huggingface.co/datasets/trl-lib/math_shepherd
>>> from datasets import load_dataset
>>>
>>> ds = load_dataset("trl-lib/math_shepherd")
>>> ds["train"][0]
{'prompt': 'Janet pays $40/hour for 3 hours per week of clarinet lessons and $28/hour for 5 hours a week of piano lessons. How much more does she spend on piano lessons than clarinet lessons in a year?', 'completions': ['Step 1: Janet spends 3 hours + 5 hours = <<3+5=8>>8 hours per week on music lessons.', 'Step 2: She spends 40 * 3 = <<40*3=120>>120 on clarinet lessons per week.', 'Step 3: She spends 28 * 5 = <<28*5=140>>140 on piano lessons per week.', 'Step 4: Janet spends 120 + 140 = <<120+140=260>>260 on music lessons per week.', 'Step 5: She spends 260 * 52 = <<260*52=13520>>13520 on music lessons in a year. The answer is: 13520'], 'labels': [True, True, True, True, False]}

Isn't it the case for llama 3.2 for example?

Indeed!
>>> from transformers import AutoTokenizer
>>> tokenizer = AutoTokenizer.from_pretrained("meta-llama/Llama-3.2-1B-Instruct")
>>> tokenizer("Hey")
{'input_ids': [128000, 19182], 'attention_mask': [1, 1]}
>>> tokenizer("Hey", add_special_tokens=False)
{'input_ids': [19182], 'attention_mask': [1]}
>>> tokenizer.decode(128000)
'<|begin_of_text|>'
>>> tokenizer.bos_token
'<|begin_of_text|>'

Very nice curves

Some examples:
from datasets import load_dataset
from transformers import pipeline

pipe = pipeline("token-classification", model="qgallouedec/Qwen2-0.5B-Reward-Math-Sheperd")
dataset = load_dataset("trl-lib/math_shepherd")
example = dataset["test"][10]

scores = []
print("\n".join((example["prompt"], *example["completions"])))
for idx in range(1, len(example["completions"])+1):
    text = "\n".join((example["prompt"], *example["completions"][0:idx])) + "\n"
    score = float(pipe(text)[-1]["score"])
    print(f"Step {idx}\tScore: {score:.2f}\tLabel: {example['labels'][idx-1]}")

Grandma gave Bryce and Carter some raisins. Bryce received 6 more raisins than Carter, and Carter received half the number of raisins Bryce received. How many raisins did Bryce receive?
Step 1: Let $b$ be the number of raisins Bryce received and $c$ be the number of raisins Carter received.
Step 2: We are given that $b = c + 6$ and $c = \frac{1}{2}b$.
Step 3: Substituting the second equation into the first equation, we get $b = c + 6 = \frac{1}{2}b + 6$.
Step 4: Simplifying, we have $b = \frac{1}{2}b + 6$.
Step 5: Subtracting $\frac{1}{2}b$ from both sides, we get $\frac{1}{2}b - b = 6$.
Step 6: Simplifying further, we have $\frac{1}{2}b - 2b = 6$.
Step 7: Combining like terms, we have $-\frac{1}{2}b = 6$.
Step 8: Multiplying both sides by $-2$, we get $b = -12$.
Step 9: Therefore, Bryce received $\boxed{-12}$ raisins.The answer is: -12
Step 1  Score: 1.00     Label: True
Step 2  Score: 1.00     Label: True
Step 3  Score: 1.00     Label: True
Step 4  Score: 0.99     Label: True
Step 5  Score: 0.98     Label: True
Step 6  Score: 0.82     Label: False
Step 7  Score: 0.82     Label: False
Step 8  Score: 0.87     Label: False
Step 9  Score: 0.94     Label: False

Dylan filled his glass with ice cubes before he poured his soda into it. He counted and there were 8 ice cubes in his glass. Later when he prepares a pitcher of lemonade he puts two times as many ice cubes in the pitcher. Then it is time to refill the ice cube trays which have 12 spaces each for ice cubes. How many trays does Dylan need to fill if he used exactly all the ice they had in them?
Step 1: Dylan used 8 ice cubes in his glass and he used 2 * 8 = <<8*2=16>>16 ice cubes in the pitcher.
Step 2: There are 12 spaces in each ice cube tray and he used 8 + 16 = <<8+16=24>>24 ice cubes.
Step 3: Dylan needs to fill 24 / 12 = <<24/12=2>>2 ice cube trays. The answer is: 2
Step 1  Score: 1.00     Label: True
Step 2  Score: 0.92     Label: True
Step 3  Score: 0.87     Label: True

Jeremy buys 3 bags of chips for a party. Stacy and Emily also buy chips for the party. If they need 10 bags of chips total, and Stacy buys 4 bags, how many bags of chips should Emily buy?
Step 1: Jeremy and Stacy have already bought 4 + 3 = <<4+3=7>>7 bags of chips.
Step 2: Thus, Emily needs to buy 10 - 7 = <<10-7=3>>3 bags of chips. The answer is: 3
Step 1  Score: 1.00     Label: True
Step 2  Score: 1.00     Label: True

A charity is delivering chicken and rice dinners to a shelter for the hungry. They have a hundred plates to deliver. The rice cost ten cents a plate and the chicken cost forty cents a plate. How many dollars did the charity spend on the food for the dinners?
Step 1: They spent 10 + 40 = <<10+40=50>>50 cents per plate on food.
Step 2: So they spent 50 x 100 = <<50*100=50>>50 dollars on the food for the dinners. The answer is: 50
Step 1  Score: 0.97     Label: True
Step 2  Score: 0.55     Label: True  # <- here the model right and the label wrong

There was a tricky bug in the processing: the label column was casted to its original dtype (bool) after the map, instead of staying in its new dtype (int). It implied that -100 were converted to True.
# what we want after tokenization
{"input_ids": [2, 4, 6, ...], "labels": [-100, -100, 0, -100, 1, ...]}
# what we got after tokenization
{"input_ids": [2, 4, 6, ...], "labels": [True, True, False, True, True, ...]}

Consequently, instead of being ignored in the loss computation, most tokens were associated to the label True.
It explains why we got such high values for accuracy right from start, and why the model predicted most of the time True in evaluation.
It has been fixed in 049fdf9.

New results look way better:

The new curves look way more reasonable! Thanks for finding the bug @qgallouedec

Thank you for your contribution to the development of the well-written stepwise RM trainer. To further advance RLHF with PRM, some RL trainers, such as the PPO trainer, could potentially benefit from PRMs trained using a stepwise RM trainer. Several points may be considered:

A suitable step_separator must be defined, ensuring it is always tokenized into a fixed token ID.
Implementing a generate function that outputs one step at a time is unnecessary. Instead, an SFT model trained on a CoT dataset (with a defined step_separator in the answers) is essential to prepare PPO with PRM. Thus, CoT SFT datasets should be constructed, albeit in small quantities, as SFT is only performed to ensure the model outputs CoT answers in a specific format.
The get_reward function already supports scoring across all positions, as it is also utilized by the value model. To integrate PRM scores, an additional mask can be used to extract scores at step_separator positions and directly add them to the non_score_reward.
The score column in the wandb table should include lists of PRM scores with varying lengths.

Sounds good to me, that's how I named it in my initial commits.


Connection Closed

When i run the tool , I keep getting a connecton closed message. I have the s_server running on https://localhost:4433 . is it because its trying to connect on http://localhost ?

Can you give a bit more details on what you try exactly and what goes wrong (which configuration file do you use, which command line parameters, etc)?


feat: reference kit types in ambient file

Closes #5677. Includes reference to @sveltejs/kit types in ambient file, and removes reference from app.d.ts.
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

[x] It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
[x] This message body should clearly illustrate what problems it solves.
[ ] Ideally, include a test that fails without this PR but passes with it.

Tests

[x] Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

[x] If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

Thanks for review! @dummdidumm @Conduitry

thank you!


If there is a jinja error you don't get any error message

I'm hacking on a track change now and getting messages like:
[ERROR] Cannot race. Error in race control (Could not load '/home/nik9000/Code/Elastic/rally-tracks/http_logs/track.json'. The complete track has been written to '/tmp/tmpo8b2g1ng.json' for diagnosis.)

There isn't a /tmp/tmpo8b2g1ng.json. I'm fairly sure this is because I have a syntax error in my jinja somewhere and jinja is bailing before it can write the file. I think jinja should have an error message telling me what I'm doing wrong. But I think we're eating the error message and not reporting it. Can we?

In my case it was because I had a kebab case variable (rutime-fields) in the jinja. It needs snake case (runtime_fields).

I see something pretty similar now with a message like:
[ERROR] Cannot race. Error in race control (Could not load file template for 'definition for index logs-181998 in index-runtime-fields.json')

I'm guessing I have new and unique jinja errors.

It looks like I can get some or all of this from rally.log. It'd be nice to have the actual message from the json parser or jinja on the regular output though.

This is a more technical one, not a meta item that I am looking at for overall priority.
Daniel can decide on where this goes in terms of priority.


Start slow start window on first successful HC, make slow start re-enterable

Signed-off-by: Kateryna Nezdolii<EMAIL_ADDRESS>New changes to "slow start" logic:

When active HC is enabled per cluster, start "slow start" calculation after first passing HC (drop cluster membership duration condition).
When no active HC is enabled per cluster, enter "slow start" immediately (drop cluster membership duration condition).
Endpoint can re-enter "slow start" if active HC is configured per cluster, on each "unhealthy -> healthy" state transition.

Those changes make "slow start" in Envoy to align more with ELB slow start feature.
Commit Message:
Additional Description:
Risk Level: Medium
Testing: Done
Docs Changes: Done
Release Notes: Not Done
Platform Specific Features:
Fixes #18351

/retest

need to increase test coverage

There was a failure in unrelated test, merged latest main. Let's see if it helps

@mattklein123 so far the CI has been complaining about overall low test coverage for class RealHostDescription in logical_host.h. That class is not used anywhere in code and in tests. I have added test for RealHostDescription, but had to change visibility for the library that included it (now format check if complaining because of changed visibility) Wonder if better approach would have been to remove that class altogether?

Yes please remove if it's dead code! Thank you.
/wait


cmd/scollector: prevent panic if v.Frequency_Object is ever zero

This can occur in IIS if the service is disabled/removed and can probably happen in other collectors too.

testing on ny-itweb01 to fix a panic on startup


Better feeds management

I have made following improvement.
This would help user to find the most useful/read feeds.

Differentiate the actual "read" items from the items "marked as read"
By adding a new status "marked".
Fever API is unchanged. always marked as "read".
In the feeds page, in addition to "unread/read" count, add the "total" count.

Allow to sort feeds by a given order
allow to sort feeds by last published time.
Solved #632
This is intentional done on the client side. No need to send requests to the server.

in the history page, allow user to show only "viewed/read" items.

ALTER TYPE ... ADD cannot run inside a transaction block
I did not see such a problem in postgres 12.
What version of postgres are you using?

Here is the solution I found for postgres 10
http://stackoverflow.com/a/10404041/350428

This should also fix https://github.com/miniflux/miniflux/issues/632

in the history page, allow user to show only "viewed/read" items.

allow to sort feeds by last published time.
Solved https://github.com/miniflux/miniflux/issues/632

Done. Thanks.

I've added some improvements for german translation.

The CI error seems due to the github outage.
Can you help me re-run it?

If you think this push is two big, could you consider firstly merging the first two parts of the push. They do not change the database, mostly UI tweaks only? I can send separated pull request. If you want.

 It's hard to see what is going to cause regressions.

 It's hard to see what is going to cause regressions.

If I break this into multiple pull requests (<100 lines each), would you like to review them?

If I break this into multiple pull requests (<100 lines each), would you like to review them?

1 pull-request = 1 feature
Breaking changes have less chances to be merged

I can break this into smaller features.

@shizunge can you add me as reviewer in future PRs to fix some Russian language localization mistakes?

@L11R you can just add comment to the code and then you automatically become a reviewer.


Made inspectdb used Cursor.description.display_size for CharFields' max_length.

internal_size is size for fixed-size types not for char types.

buildbot, test on oracle.


Spot & Reserved Instance Feasibility

I have two questions
What is the process like for connecting reserved instances manually to the cluster? Should I follow the aws-cluster-startup.sh script manually?
Is it feasible to run the worker nodes as spot instances? How does this setup handle node failures?

For reserved instances, you dont have to anything as RIs are an accounting/billing construct. Just change the instance types in the slurm-aws-startup.sh script to match which RIs you have setup in your account.
   if [[ $host == *ip-10-0-1* ]]; then
      export AWS_SUBNET_ID=@PRIVATE1@
      aws_startup $host $private_ip c4.2xlarge
   elif [[ $host == *ip-10-0-2* ]]; then
      export AWS_SUBNET_ID=@PRIVATE2@
      aws_startup $host $private_ip c4.2xlarge
   elif [[ $host == *ip-10-0-3* ]]; then
      export AWS_SUBNET_ID=@PRIVATE3@
      aws_startup $host $private_ip c4.2xlarge
   fi

It is possible to invoke it with Spot, future updates will have this support


'just.library(...)' as it is undefined

TypeError: Cannot destructure property 'http' of 'just.library(...)' as it is undefined. in /root/just/examples/test.js on line 3
OS: Ubuntu 20.04.2 LTS 64-bit
My steps.
step 1:
git clone git@github.com:just-js/just.git
step 2:
make runtime-static
sudo make install
step 3:
make MODULE=http module
sudo make -C modules/http install
(/usr/local/lib/just directory has http.so)

step 4:
make examples
step 5:
cd examples
touch test.js
vi test.js
const { http } = just.library('http', 'http.so')
or
const { http } = just.library('http', '../modules/http/http.so')
or
const { http } = just.library('http', '/usr/local/lib/just/http.so')
step 6:
just test.js

thanks. i cannot reproduce this issue. agree it's a bad error message but the module code is still very much a first pass/PoC.
can you try running with strace and post the logs?
strace just test.js

i'll see if i can test on a clean ubuntu 20. i am still on 18.04 at moment.

@billywhizz
execve("/usr/local/bin/just", ["just", "test.js"], 0x7ffd2a252cb8 /* 67 vars /) = 0
arch_prctl(0x3001 / ARCH_??? /, 0x7ffed4018140) = -1 EINVAL (Invalid argument)
brk(NULL)                               = 0x1151000
brk(0x1152240)                          = 0x1152240
arch_prctl(ARCH_SET_FS, 0x1151900)      = 0
uname({sysname="Linux", nodename="Ubuntu-Virtual", ...}) = 0
set_tid_address(0x1151bd0)              = 4280
set_robust_list(0x1151be0, 24)          = 0
rt_sigaction(SIGRTMIN, {sa_handler=0xeb2750, sa_mask=[], sa_flags=SA_RESTORER|SA_SIGINFO, sa_restorer=0xeb1cf0}, NULL, 8) = 0
rt_sigaction(SIGRT_1, {sa_handler=0xeb27f0, sa_mask=[], sa_flags=SA_RESTORER|SA_RESTART|SA_SIGINFO, sa_restorer=0xeb1cf0}, NULL, 8) = 0
rt_sigprocmask(SIG_UNBLOCK, [RTMIN RT_1], NULL, 8) = 0
prlimit64(0, RLIMIT_STACK, NULL, {rlim_cur=81921024, rlim_max=RLIM64_INFINITY}) = 0
readlink("/proc/self/exe", "/usr/local/bin/just", 4096) = 19
brk(0x1173240)                          = 0x1173240
brk(0x1174000)                          = 0x1174000
mprotect(0x108e000, 274432, PROT_READ)  = 0
futex(0x10f88bc, FUTEX_WAKE_PRIVATE,<PHONE_NUMBER>) = 0
futex(0x10f88c8, FUTEX_WAKE_PRIVATE,<PHONE_NUMBER>) = 0
openat(AT_FDCWD, "/sys/devices/system/cpu/online", O_RDONLY|O_CLOEXEC) = 3
read(3, "0-3\n", 8192)                  = 4
close(3)                                = 0
mmap(NULL, 8392704, PROT_NONE, MAP_PRIVATE|MAP_ANONYMOUS|MAP_STACK, -1, 0) = 0x7f29dc412000
mprotect(0x7f29dc413000, 8388608, PROT_READ|PROT_WRITE|PROT_EXEC) = 0
clone(child_stack=0x7f29dcc11df0, flags=CLONE_VM|CLONE_FS|CLONE_FILES|CLONE_SIGHAND|CLONE_THREAD|CLONE_SYSVSEM|CLONE_SETTLS|CLONE_PARENT_SETTID|CLONE_CHILD_CLEARTID, parent_tid=[4281], tls=0x7f29dcc12700, child_tidptr=0x7f29dcc129d0) = 4281
futex(0x1168d98, FUTEX_WAKE_PRIVATE, 1) = 1
mmap(NULL, 8392704, PROT_NONE, MAP_PRIVATE|MAP_ANONYMOUS|MAP_STACK, -1, 0) = 0x7f29dbc11000
mprotect(0x7f29dbc12000, 8388608, PROT_READ|PROT_WRITE|PROT_EXEC) = 0
clone(child_stack=0x7f29dc410df0, flags=CLONE_VM|CLONE_FS|CLONE_FILES|CLONE_SIGHAND|CLONE_THREAD|CLONE_SYSVSEM|CLONE_SETTLS|CLONE_PARENT_SETTID|CLONE_CHILD_CLEARTID, parent_tid=[4282], tls=0x7f29dc411700, child_tidptr=0x7f29dc4119d0) = 4282
futex(0x1168f58, FUTEX_WAKE_PRIVATE, 1) = 1
mmap(NULL, 8392704, PROT_NONE, MAP_PRIVATE|MAP_ANONYMOUS|MAP_STACK, -1, 0) = 0x7f29db410000
mprotect(0x7f29db411000, 8388608, PROT_READ|PROT_WRITE|PROT_EXEC) = 0
clone(child_stack=0x7f29dbc0fdf0, flags=CLONE_VM|CLONE_FS|CLONE_FILES|CLONE_SIGHAND|CLONE_THREAD|CLONE_SYSVSEM|CLONE_SETTLS|CLONE_PARENT_SETTID|CLONE_CHILD_CLEARTID, parent_tid=[4283], tls=0x7f29dbc10700, child_tidptr=0x7f29dbc109d0) = 4283
futex(0x1169118, FUTEX_WAKE_PRIVATE, 1) = 1
openat(AT_FDCWD, "/dev/urandom", O_RDONLY) = 3
fstat(3, {st_mode=S_IFCHR|0666, st_rdev=makedev(0x1, 0x9), ...}) = 0
ioctl(3, TCGETS, 0x7ffed4017ab0)        = -1 EINVAL (Invalid argument)
read(3, "\220\347\306_\177zR#\365\200x\337~\217\231\252\221A\334zv\266S\354\304's\32\363C7\352"..., 4096) = 4096
close(3)                                = 0
mmap(0x3c8400000000,<PHONE_NUMBER>, PROT_NONE, MAP_PRIVATE|MAP_ANONYMOUS|MAP_NORESERVE, -1, 0) = 0x3c8400000000
munmap(0x3c8400000000,<PHONE_NUMBER>)      = 0
mmap(0x3c8400000000,<PHONE_NUMBER>, PROT_NONE, MAP_PRIVATE|MAP_ANONYMOUS|MAP_NORESERVE, -1, 0) = 0x3c8400000000
mprotect(0x3c8400000000, 262144, PROT_NONE) = 0
madvise(0x3c8400000000, 262144, MADV_FREE) = 0
mprotect(0x3c8400000000, 57344, PROT_READ|PROT_WRITE) = 0
brk(0x119f000)                          = 0x119f000
futex(0x10e1f50, FUTEX_WAKE_PRIVATE,<PHONE_NUMBER>) = 0
brk(0x11cf000)                          = 0x11cf000
getpid()                                = 4280
mprotect(0x3c8400040000, 134217728, PROT_NONE) = 0
madvise(0x3c8400040000, 134217728, MADV_FREE) = 0
brk(0x11f0000)                          = 0x11f0000
brk(0x1211000)                          = 0x1211000
mprotect(0x3c8408040000, 262144, PROT_NONE) = 0
madvise(0x3c8408040000, 262144, MADV_FREE) = 0
mprotect(0x3c8408040000, 262144, PROT_READ|PROT_WRITE) = 0
openat(AT_FDCWD, "/dev/urandom", O_RDONLY) = 3
fstat(3, {st_mode=S_IFCHR|0666, st_rdev=makedev(0x1, 0x9), ...}) = 0
ioctl(3, TCGETS, 0x7ffed40172e0)        = -1 EINVAL (Invalid argument)
read(3, "\264\314W\0172#\207Q\243yf\341?\252\214\314{\t\235%\257\20\376:ae-e\245~\232\250"..., 4096) = 4096
close(3)                                = 0
mprotect(0x3c840805f000, 135168, PROT_NONE) = 0
madvise(0x3c840805f000, 135168, MADV_FREE) = 0
mprotect(0x3c8408040000, 126976, PROT_READ) = 0
mprotect(0x3c8408080000, 262144, PROT_NONE) = 0
madvise(0x3c8408080000, 262144, MADV_FREE) = 0
mprotect(0x3c8408080000, 262144, PROT_READ|PROT_WRITE) = 0
mprotect(0x3c84080c0000, 262144, PROT_NONE) = 0
madvise(0x3c84080c0000, 262144, MADV_FREE) = 0
mprotect(0x3c84080c0000, 262144, PROT_READ|PROT_WRITE) = 0
openat(AT_FDCWD, "/dev/urandom", O_RDONLY) = 3
fstat(3, {st_mode=S_IFCHR|0666, st_rdev=makedev(0x1, 0x9), ...}) = 0
ioctl(3, TCGETS, 0x7ffed4017570)        = -1 EINVAL (Invalid argument)
read(3, "\23\n\327P\356%Qp\273\20\247<EMAIL_ADDRESS>4096) = 4096
close(3)                                = 0
mprotect(0x3c8408100000, 262144, PROT_NONE) = 0
madvise(0x3c8408100000, 262144, MADV_FREE) = 0
mprotect(0x3c8408100000, 262144, PROT_READ|PROT_WRITE) = 0
mprotect(0x3c8408140000, 262144, PROT_NONE) = 0
madvise(0x3c8408140000, 262144, MADV_FREE) = 0
mprotect(0x3c8408140000, 262144, PROT_READ|PROT_WRITE) = 0
mprotect(0x3c8400040000, 262144, PROT_NONE) = 0
madvise(0x3c8400040000, 262144, MADV_FREE) = 0
mprotect(0x3c8400040000, 12288, PROT_READ|PROT_WRITE) = 0
mprotect(0x3c8400043000, 4096, PROT_NONE) = 0
madvise(0x3c8400043000, 4096, MADV_FREE) = 0
mprotect(0x3c8400044000, 241664, PROT_READ|PROT_WRITE) = 0
mprotect(0x3c840007f000, 4096, PROT_NONE) = 0
madvise(0x3c840007f000, 4096, MADV_FREE) = 0
mprotect(0x3c840810c000, 212992, PROT_NONE) = 0
madvise(0x3c840810c000, 212992, MADV_FREE) = 0
mprotect(0x3c8400053000, 4096, PROT_NONE) = 0
madvise(0x3c8400053000, 4096, MADV_FREE) = 0
mprotect(0x3c8400054000, 180224, PROT_NONE) = 0
madvise(0x3c8400054000, 180224, MADV_FREE) = 0
mprotect(0x3c8408143000, 249856, PROT_NONE) = 0
madvise(0x3c8408143000, 249856, MADV_FREE) = 0
mprotect(0x3c8400044000, 61440, PROT_READ|PROT_EXEC) = 0
mprotect(0x3c8408180000, 262144, PROT_NONE) = 0
madvise(0x3c8408180000, 262144, MADV_FREE) = 0
mprotect(0x3c8408180000, 262144, PROT_READ|PROT_WRITE) = 0
uname({sysname="Linux", nodename="Ubuntu-Virtual", ...}) = 0
mprotect(0x3c84081c0000, 262144, PROT_NONE) = 0
madvise(0x3c84081c0000, 262144, MADV_FREE) = 0
mprotect(0x3c84081c0000, 262144, PROT_READ|PROT_WRITE) = 0
sysinfo({uptime=227, loads=[18656, 30080, 14592], totalram=4119932928, freeram=2010189824, sharedram=2416640, bufferram=48328704, totalswap=2147479552, freeswap=2147479552, procs=494, totalhigh=0, freehigh=0, mem_unit=1}) = 0
getcwd("/root/just/examples", 4096)     = 20
epoll_create1(EPOLL_CLOEXEC)            = 3
times({tms_utime=0, tms_stime=0, tms_cutime=0, tms_cstime=0}) =<PHONE_NUMBER>
getcwd("/root/just/examples", 4096)     = 20
openat(AT_FDCWD, "test.js", O_RDONLY)   = 4
fstat(4, {st_mode=S_IFREG|0777, st_size=49, ...}) = 0
read(4, "const { http } = just.library('h"..., 49) = 49
close(4)                                = 0
write(2, "TypeError: Cannot destructure pr"..., 130TypeError: Cannot destructure property 'http' of 'just.library(...)' as it is undefined. in /root/just/examples/test.js on line 1
) = 130
write(2, "    at /root/just/examples/test."..., 39    at /root/just/examples/test.js:1:9
) = 39
write(2, "    at startup (just.js:374:13)\n", 32    at startup (just.js:374:13)
) = 32
write(2, "    at main (just.js:411:8)\n", 28    at main (just.js:411:8)
) = 28
write(2, "    at just.js:420:3\n", 21    at just.js:420:3
)  = 21
futex(0x11687a0, FUTEX_WAKE_PRIVATE,<PHONE_NUMBER>) = 3
futex(0x11687a8, FUTEX_WAKE_PRIVATE, 1) = 1
exit_group(0)                           = ?
+++ exited with 0 +++

ah sorry. i missed that you built the static version of the runtime. if you do this, then you cannot use dlopen to dynamically load a libary at runtime. you would only use runtime-static to build a just binary that could run scripts but not import any binary modules.
if you want this to work, please recompile and reinstall just with
make clean runtime-static
sudo make install

and it should work then.
if you want to build a static binary with specific modules included in the binary you can do that too.

It works.
Thank you for your answer.
:)


Add support for Google Scholar profile

@frgossen I regret to inform you that we won't be bundling additional social icons with Minima theme. Sorry


Nightly build not flagged as  on MacOS

Reproduce

Download MacOS nightly
Unzip and Open
Version is 2.x, indicating an actual release

Expected Behavior

[ ] Version should be 2.x-nightly, indicating a nightly build

Environment
Please complete the following information:

OS: MacOS 10.x
Camunda Modeler Version: 2.3.0-nightly

I can't reproduce this on my mac (v10.14.6)

Thanks for the heads up. Closing this then.


chore: Remove not needed ignore from licenserc

Do we ignore the warning?

Do we ignore the warning?

Yes, I think they are just unknown which is OK


bug: allowing insertion at any element

fixes #26

Could you rename this to fix: allow insertion at any element in apply_diff()? This is because:

we should stay consistent with tense in commit messages
we should be specific about what feature allowing this in
change the prefix to fix:  since we're fixing a bug, the other way it sounds like we're introducing one :P


Generating CONTRIBUTORS.txt

Hey folks,
I've written a script to look at git commits and make a CONTRIBUTORS.txt file. It works in the same manner as add_font.py
Shall I include this in FontBakery or GoogleFonts/tools?
@felipesanches @davelab6

Sounds like a generic tool that could have its own repo. But I would be OK with having a copy of it on Fontbakery repo as well.

Here is better, thanks!


Rectifying naming disparity for cherrypy server

https://github.com/mar10/wsgidav/issues/69

Thanks!


Implement "Heads up" for PGP users

Implement issue #275, for users arriving from PGP. After they click "Continue to Open Humans", first show this content, then "continue" takes them to where they would have gone (e.g. welcome page).

Here's the design: https://docs.google.com/presentation/d/1Feh9P8DJtnTdC29YYnfmsBQsi40dUUq_iLajK44j7OY/edit
However, looking at the code, it's not clear to me that there's an easy way to implement this (or something like it).


GK no longer opening PRs

I've noticed on several repositories that GK was correctly creating a branch to update a (pinned) dependency, Travis tested it, but apparently GK didn't open a PR to update the dependency.
one example is https://github.com/simplabs/ember-test-selectors:

you can see the greenkeeper/ember-cli-2.11.0 branch in https://github.com/simplabs/ember-test-selectors/branches

you can see that the tests ran and passed at https://travis-ci.org/simplabs/ember-test-selectors/branches

but there is no corresponding PR at https://github.com/simplabs/ember-test-selectors/pulls?q=is%3Apr

/cc @kellyselden @marcoow

Hey @Turbo87,
yes this is a known issue that we already fixed. For a few days some pull requests were not created. We would ask you to create those PRs manually. Future dependencies should work as expected again Sorry for the inconvenience.

@finnp good to know, thanks for the feedback and for a great service!


Hotfix/storage caps size type issue tests

Purpose
Fixing tests related to size type issue.
Changes
Replacing size with sizeint
QA Notes
Please make verification statements inspired by your code and what your code touches.

Verify
Verify

What are the areas of risk?
Any concerns/considerations/questions that development raised?
Documentation

Side Effects

Ticket

Hmmm. Looks like tests are still failing.

Hmmm. Looks like tests are still failing.

👍


Upgrade nokogiri and paperclip because of security vulnerabilities

See http://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2017-9050
and https://nvd.nist.gov/vuln/detail/CVE-2017-0889

Thanks. This has already been taken care of in another PR.


add support for modules in the site.json

We can do modular theme work the same way we do the dynamic imports stuff. This is the same paradigm / data structure except this will just load and append elements of that type to the DOM when everything is setup. This will allow for slapping on / enabling data analytics (for example) and beginning the path towards modular front end functionality.

merging with #204


Allow the user to exclude folder paths

This PR allows the user to use the -exclude flag to exclude directories.

@markbates any chance to get this merged?

Can you add tests please?

I'm not sure how to test this; could you help walk me through the process?

I've worked on a very similar feature as @A1Liu did and added tests—my proposed API change is a bit different, though, as I would recommend against mutating defaultIgnoredFolders. The API will replace the elegant variadic includes parameter, but I couldn't imagine something else:
https://github.com/falafeljan/pkger/blob/3c71152a456b7720c008188ef5b79c7d910d710a/parser/parser.go#L35-L44
The test looks like this:
https://github.com/falafeljan/pkger/blob/3c71152a456b7720c008188ef5b79c7d910d710a/parser/parser_test.go#L74-L100
Tests fail though, as they do on the main branch atm. @markbates to me it occurs that there is a bug in pkging/pkgtest that will somehow keep references to the first directory created by pkgtest.NewRef() for subsequent tests. As the first directory will be deleted after the first test passed, subsequent tests will fail due to the missing directory. Didn't find a solution for that bug, but if you comment out line 26 in the above parser_test.go, tests for the excludes argument will pass.

@A1Liu do you intend to update your PR or shall I open my own one?

Go for it dude


test rest client broken for get deleted secret of key vault

Describe the bug
wrong url is generated by the test client
e.g.
GET https://docs.microsoft.com/en-us/rest/api/keyvault/getdeletedsecret/{vaultBaseUrl}/deletedsecrets/{secret-name}?api-version=7.0
To Reproduce
attempt to use the test ("try it out") client for keyvault get deleted secret, it will attempt to call wrong url - resulting in 404
Expected behavior
correct rest call
Desktop (please complete the following information):

OS: Win10
Browser firefox
Version [67.0.2]

Smartphone (please complete the following information):

Device: [e.g. iPhone6]
OS: [e.g. iOS8.1]
Browser [e.g. stock browser, safari]
Version [e.g. 22]

Additional context
Add any other context about the problem here.

@VaclavK what test client are you using? Is there specific documentation you are referencing?

@ryanmajidi this is weird. There used to be a test/try it out client embedded within the REST reference on MSDN e.g. https://docs.microsoft.com/en-us/rest/api/keyvault/getdeletedsecret/getdeletedsecret
I do not not see the "try it out" button anymore so if this feature was indeed removed, this ticket is no longer applicable.
ultimately the client allowed consumer to see sample requests/response payloads but given the nature of the KV REST the URL was generated on the fly when given the key vault name. For the REST method mentioned above, the url was not being generated correctly in this embedded client and pointed back to docs.microsoft.com, which is not valid REST URL for KV