Can we feed back SQL errors for correction ala SQLDatabaseChain in Langchain?

Hello:
I just started testing with your models and I've run into a snag with our PostgreSQL database.  My column names are not as transparent as they should be.  Specifically, I used abbreviations when I created them years ago, such as "purchdate" for a purchase date field.
Here is what is happening:
Question = How many items were purchased in the past year?

Here are the results (which I passed back to the postgres_connect.run_sql_as_df() function to execute:
sqlalchemy.exc.ProgrammingError: (psycopg2.errors.UndefinedColumn) column "purchasedate" does not exist
LINE 1: SELECT COUNT(*) FROM items WHERE purchasedate < DATEADD(year...
                                         ^
HINT:  Perhaps you meant to reference the column "items.purchdate".

[SQL: SELECT COUNT(*) FROM items WHERE purchasedate < DATEADD(year, -1, GETDATE());]
(Background on this error at: https://sqlalche.me/e/14/f405)

As you can see, it incorrectly used a column named "purchasedate" instead of "purchdate".  Postgres can guess the correct column, but the model can't.  The Langchain.SQLDatabaseChain has the option to validate and correct a query before it gets executed.   Does your model have the same capability?   I have tried it by passing a second prompt formatted like this (added to prompt_formatters.py):
    def format_error(self, error: str,) -> str:
        return f"""{self.table_str}\n\n\n-- PostgreSQL returned the following error:\n{error}\n\n.  Please rewrite the SQL using valid PostgreSQL and ONLY the tables and fields provided above.\n\nSELECT"""

It looks like this:
 CREATE TABLE customers(....)
 CREATE TABLE items(...)
 CREATE TABLE lines(...)

-- PostgreSQL returned the following error:
(psycopg2.errors.UndefinedColumn) column "purchasedate" does not exist
LINE 1: SELECT COUNT(*) FROM items WHERE purchasedate < DATEADD(year...
                                         ^
HINT:  Perhaps you meant to reference the column "items.purchdate".

[SQL: SELECT COUNT(*) FROM items WHERE purchasedate < DATEADD(year, -1, GETDATE());]
(Background on this error at: https://sqlalche.me/e/14/f405)

.  Please rewrite the SQL using valid PostgreSQL and ONLY the tables and fields provided above.

Unfortunately, it did not work.  Do you have any suggestions?
Here is my code:
from db_connectors import PostgresConnector
from prompt_formatters import RajkumarFormatter
from manifest import Manifest
import argparse

parser = argparse.ArgumentParser(description="Test NL to SQL")
parser.add_argument('--question', metavar='q', required=True, type=str, help='question to ask')

args = parser.parse_args()

postgres_connector = PostgresConnector(
    user="*****", password="******", dbname="pas", host="postgres.paslists.com", port=5432
)
postgres_connector.connect()

#db_schema = [postgres_connector.get_schema(table) for table in postgres_connector.get_tables()]

# NOTE that I only load a few tables. I also had to modify the code to only read one schema, as I have the same table names
# in multiple schemas.  Your original code loaded all of the tables from all schemas.

db_schema = [postgres_connector.get_schema(schema='rbm',table=table) for table in ['customers','items','lines']]
formatter = RajkumarFormatter(db_schema)

manifest_client = Manifest(client_name="huggingface", client_connection="http://<IP_ADDRESS>:5000")

def get_sql(instruction: str, max_tokens: int = 300) -> str:
    prompt = formatter.format_prompt(instruction)
    res = manifest_client.run(prompt, max_tokens=max_tokens)
    return formatter.format_model_output(res)

question=args.question
sql=get_sql(question, max_tokens=512)

print(f'Question = {question}\n')
print(f'SQL = {sql}\n')

try:
    df = postgres_connector.run_sql_as_df(sql);
    print(df)
except Exception as exc:
    print('Error in SQL - attempting to repair')
    prompt = formatter.format_error(exc)
    print(f'New Prompt = {prompt}')
    res = manifest_client.run(prompt, max_tokens=512)
    print(res)
    sql = formatter.format_model_output(res)
    print(f'New SQL = {sql}\n')
    df = postgres_connector.run_sql_as_df(sql)
    print(df)

Hi @ericraskin,
Right now the model doesn't have the capability to do self-correction but it's on our to-do list for further releases. Stay tuned!
Do you mind sharing your database schema so we can take a look? One trick we use in this case is to quote the column names. Let me know if it helps.

Here is the full prompt:
CREATE TABLE customers (
    phone character varying,
    company character varying,
    sexcode character,
    canceldate timestamp without time zone,
    id bigint,
    hotline timestamp without time zone,
    jobtitle character varying,
    address3 character varying,
    province character varying,
    email character varying,
    srcode character,
    city character varying,
    address2 character varying,
    birth_place character varying,
    origdate timestamp without time zone,
    address1 character varying,
    birthdate timestamp without time zone,
    rtype character,
    fpurch numeric,
    fname character varying,
    cusid bigint,
    lpurch numeric,
    altmatch character varying,
    primmatch character varying,
    lname character varying,
    japan_ward character varying,
    donotrent boolean,
    numpurch bigint,
    country character varying,
    name character varying,
    cpurch numeric,
    postalcode character varying,
    countrycode character varying
)

CREATE TABLE items (
    pacnet_status character varying,
    traynumber integer,
    refundamt numeric,
    nsfflag character,
    inactivedate timestamp without time zone,
    shipping numeric,
    fulfill_type character,
    stepid bigint,
    bank_account character varying,
    ordertype character varying,
    correct4 character,
    correct2 character,
    correct3 character,
    pacnet_tracking bigint,
    pasid bigint,
    paymentcode character varying,
    amount numeric,
    ordnum character varying,
    bank_route bigint,
    ach_date timestamp without time zone,
    final_score numeric,
    check_no bigint,
    continuity character,
    currencycode character varying,
    id bigint,
    entrynumber integer,
    ordersource character varying,
    updatedate timestamp without time zone,
    correct1 character,
    fulfilldate timestamp without time zone,
    source character varying,
    purchdate timestamp without time zone,
    refunddate timestamp without time zone,
    altordnum character varying,
    jobid bigint,
    product character varying,
    whitemail character,
    source_id bigint,
    updtrans_id bigint,
    pin character varying,
    origordnum character varying,
    subid character varying
)

CREATE TABLE lines (
    assemblysku character varying,
    entrydate timestamp without time zone,
    l_ordnum character varying,
    l_refunddate timestamp without time zone,
    sku character varying,
    l_refundamt numeric,
    pasid bigint,
    updatedate timestamp without time zone,
    id bigint,
    jobid bigint,
    itemid bigint,
    linetotal numeric,
    quantity bigint,
    price numeric,
    product character varying
)

-- Using valid Postgresql, answer the following questions for the tables provided above.

-- how many items were purchased in the past year?
SELECT

The resulting SQL was:
SELECT COUNT(*) FROM items WHERE purchasedate < DATEADD(year, -1, GETDATE());

Not only did it miss the purchase date -> purchdate column mapping, it also got the WHERE clause wrong.
From reading other posts, I saw somebody input comments on their PG tables/columns and the schema dumper included them in the prompt.  Those might help the system understand that "purchdate" is the same as "purchase date".  Also adding examples seems to help, but those need to be hand-written, which defeats the purpose a bit.
For your amusement, this was my error correction prompt:
<<<same table structure as above - omitted for brevity>>>

-- PostgreSQL returned the following error:
(psycopg2.errors.UndefinedColumn) column "purchasedate" does not exist
LINE 1: SELECT COUNT(*) FROM items WHERE purchasedate < DATEADD(year...
                                         ^
HINT:  Perhaps you meant to reference the column "items.purchdate".

[SQL: SELECT COUNT(*) FROM items WHERE purchasedate < DATEADD(year, -1, GETDATE());]
(Background on this error at: https://sqlalche.me/e/14/f405)

.  Please read the error message and rewrite the SQL making the recommended corrections using valid PostgreSQL and the tables and fields provided above.

  Got a better one to try?

My hypothesis is that the model might be confused by the multiple-word column types in the prompt. I recommend you quote the column names to get better results. Here is an example:
import torch
from transformers import AutoTokenizer, AutoModelForCausalLM
tokenizer = AutoTokenizer.from_pretrained("NumbersStation/nsql-llama-2-7B")
model = AutoModelForCausalLM.from_pretrained("NumbersStation/nsql-llama-2-7B", torch_dtype=torch.bfloat16).to(0)

text = """CREATE TABLE customers (
    "phone" character varying,
    "company" character varying,
    "sexcode" character,
    "canceldate" timestamp without time zone,
    "id" bigint,
    "hotline" timestamp without time zone,
    "jobtitle" character varying,
    "address3" character varying,
    "province" character varying,
    "email" character varying,
    "srcode" character,
    "city" character varying,
    "address2" character varying,
    "birth_place" character varying,
    "origdate" timestamp without time zone,
    "address1" character varying,
    "birthdate" timestamp without time zone,
    "rtype" character,
    "fpurch" numeric,
    "fname" character varying,
    "cusid" bigint,
    "lpurch" numeric,
    "altmatch" character varying,
    "primmatch" character varying,
    "lname" character varying,
    "japan_ward" character varying,
    "donotrent" boolean,
    "numpurch" bigint,
    "country" character varying,
    "name" character varying,
    "cpurch" numeric,
    "postalcode" character varying,
    "countrycode" character varying
)

CREATE TABLE items (
    "pacnet_status" character varying,
    "traynumber" integer,
    "refundamt" numeric,
    "nsfflag" character,
    "inactivedate" timestamp without time zone,
    "shipping" numeric,
    "fulfill_type" character,
    "stepid" bigint,
    "bank_account" character varying,
    "ordertype" character varying,
    "correct4" character,
    "correct2" character,
    "correct3" character,
    "pacnet_tracking" bigint,
    "pasid" bigint,
    "paymentcode" character varying,
    "amount" numeric,
    "ordnum" character varying,
    "bank_route" bigint,
    "ach_date" timestamp without time zone,
    "final_score" numeric,
    "check_no" bigint,
    "continuity" character,
    "currencycode" character varying,
    "id" bigint,
    "entrynumber" integer,
    "ordersource" character varying,
    "updatedate" timestamp without time zone,
    "correct1" character,
    "fulfilldate" timestamp without time zone,
    "source" character varying,
    "purchdate" timestamp without time zone,
    "refunddate" timestamp without time zone,
    "altordnum" character varying,
    "jobid" bigint,
    "product" character varying,
    "whitemail" character,
    "source_id" bigint,
    "updtrans_id" bigint,
    "pin" character varying,
    "origordnum" character varying,
    "subid" character varying
)

CREATE TABLE lines (
    "assemblysku" character varying,
    "entrydate" timestamp without time zone,
    "l_ordnum" character varying,
    "l_refunddate" timestamp without time zone,
    "sku" character varying,
    "l_refundamt" numeric,
    "pasid" bigint,
    "updatedate" timestamp without time zone,
    "id" bigint,
    "jobid" bigint,
    "itemid" bigint,
    "linetotal" numeric,
    "quantity" bigint,
    "price" numeric,
    "product" character varying
)

-- Using valid SQL query, answer the following questions for the tables provided above.

-- How many items were purchased in the past year?
"""

input_ids = tokenizer(text, return_tensors="pt").input_ids.to(0)

generated_ids = model.generate(input_ids, max_length=1000)
print(tokenizer.decode(generated_ids[0], skip_special_tokens=True))

The SQL output is
SELECT SUM("numpurch") FROM items WHERE "purchdate" >= DATEADD(year, -1, GETDATE())

We will support self-correction capabilities in future releases. Stay tuned!
Thanks for the feedback! Please let us know if you have any other questions.

OK, thank you.  Interestingly, your provided torch example worked fine without quotes.  I did have to expand my context to 1024 tokens due to the large prompt.  And I'm working with a minimal GPU here (RTX 2060 Super with 8GB of VRAM) so the process is only good for educational purposes. ;-)
I wonder if there is some weird interaction with Manifest.
I will integrate this example with my executor and see what happens.  I look forward to the self-correction capabilities.

I've done as you asked and I'm having what appear to be hallucination issues.  I have modified your postgres database connector to include primary key and foreign key information in the prompt as well as adding single quote around all column names.    I'm still using the 350M model due to the memory available with my GPU:
Question: How many customers purchased since jan 1 2023?
CREATE TABLE customers (
    'phone' character varying,
    'company' character varying,
    'sexcode' character,
    'canceldate' timestamp without time zone,
    'id' bigint,
    'hotline' timestamp without time zone,
    'jobtitle' character varying,
    'address3' character varying,
    'province' character varying,
    'email' character varying,
    'srcode' character,
    'city' character varying,
    'address2' character varying,
    'birth_place' character varying,
    'origdate' timestamp without time zone,
    'address1' character varying,
    'birthdate' timestamp without time zone,
    'rtype' character,
    'fpurch' numeric,
    'fname' character varying,
    'cusid' bigint,
    'lpurch' numeric,
    'altmatch' character varying,
    'primmatch' character varying,
    'lname' character varying,
    'japan_ward' character varying,
    'donotrent' boolean,
    'numpurch' bigint,
    'country' character varying,
    'name' character varying,
    'cpurch' numeric,
    'postalcode' character varying,
    'countrycode' character varying,
    primary key ('id')
)

CREATE TABLE items (
    'pacnet_status' character varying,
    'traynumber' integer,
    'refundamt' numeric,
    'nsfflag' character,
    'inactivedate' timestamp without time zone,
    'shipping' numeric,
    'fulfill_type' character,
    'stepid' bigint,
    'bank_account' character varying,
    'ordertype' character varying,
    'correct4' character,
    'correct2' character,
    'correct3' character,
    'pacnet_tracking' bigint,
    'pasid' bigint,
    'paymentcode' character varying,
    'amount' numeric,
    'ordnum' character varying,
    'bank_route' bigint,
    'ach_date' timestamp without time zone,
    'final_score' numeric,
    'check_no' bigint,
    'continuity' character,
    'currencycode' character varying,
    'id' bigint,
    'entrynumber' integer,
    'ordersource' character varying,
    'updatedate' timestamp without time zone,
    'correct1' character,
    'fulfilldate' timestamp without time zone,
    'source' character varying,
    'purchdate' timestamp without time zone,
    'refunddate' timestamp without time zone,
    'altordnum' character varying,
    'jobid' bigint,
    'product' character varying,
    'whitemail' character,
    'source_id' bigint,
    'updtrans_id' bigint,
    'pin' character varying,
    'origordnum' character varying,
    'subid' character varying,
    primary key ('id'),
    foreign key ('subid') references 'subscriptions'('subid'),
    foreign key ('id') references 'customers'('id')
)

CREATE TABLE lines (
    'assemblysku' character varying,
    'entrydate' timestamp without time zone,
    'l_ordnum' character varying,
    'l_refunddate' timestamp without time zone,
    'sku' character varying,
    'l_refundamt' numeric,
    'pasid' bigint,
    'updatedate' timestamp without time zone,
    'id' bigint,
    'jobid' bigint,
    'itemid' bigint,
    'linetotal' numeric,
    'quantity' bigint,
    'price' numeric,
    'product' character varying,
    primary key ('id')
)

-- Using valid Postgresql, answer the following questions for the tables provided above. Only provide a SELECT statement.

-- How many customers purchased since jan 1 2023?
SELECT

Here's what the model output:
SELECT COUNT(*) FROM customers WHERE id IN (SELECT customerid FROM orders WHERE ordersource = 'web' AND orders.date >= '2023-01-01')

If you look at the table definitions, you will see that there is no column named "customerid", as the execution reports:
Failed = Error in SQL:  (psycopg2.errors.UndefinedColumn) column "customerid" does not exist
LINE 1: ...ELECT COUNT(*) FROM customers WHERE id IN (SELECT customerid...

Is this just due to the 350M model?  Any suggestions on where to go from here?
Here's the code:
from db_connectors import PostgresConnector
from prompt_formatters import RajkumarFormatter

import torch
from transformers import AutoTokenizer, AutoModelForCausalLM

print("Connecting to PostgreSQL database")
postgres_connector = PostgresConnector(
    user="******", password="******", dbname="pas", host="postgres.paslists.com", port=5432
)
postgres_connector.connect()
print("Loading schema rbm");
db_schema = [postgres_connector.get_schema(schema='rbm',table=table) for table in ['customers','items','lines']]
formatter = RajkumarFormatter(db_schema)

# Import the model
print("Loading the model")
tokenizer = AutoTokenizer.from_pretrained("NumbersStation/nsql-llama-2-7B")
model = AutoModelForCausalLM.from_pretrained("NumbersStation/nsql-llama-2-7B", torch_dtype=torch.bfloat16).to(0)

def get_sql(instruction: str, max_tokens: int = 300) -> str:
    prompt = formatter.format_prompt(instruction)
    print(prompt)
    input_ids = tokenizer(prompt, return_tensors="pt").input_ids.to(0)
    generated_ids = model.generate(input_ids, max_length=max_tokens)
    res=tokenizer.decode(generated_ids[0], skip_special_tokens=True)
    return formatter.format_model_output(res)

while True:
    question=input('Question: ');
    if question == "End" or question == "":
        break
    sql=get_sql(question, max_tokens=1024)
    print(f'Generated SQL = {sql}\n')

    try:
        df = postgres_connector.run_sql_as_df(sql);
        print(df)
    except Exception as exc:
        print('Failed = Error in SQL: ', exc)

After conducting observations, we have found that larger models tend to perform better than smaller ones. In particular, the NumbersStation/nsql-llama-2-7B model surpasses the other nsql models in terms of capability. However, we have noticed that all models exhibit some level of hallucination issues, which remains a challenging problem for foundation models. We are actively working to reduce these hallucination issues in future releases. If you have any other feedback, please don't hesitate to share it with us, as we are always looking to improve. Thank you!
Alos here is an example works for me with NumbersStation/nsql-llama-2-7B:
CREATE TABLE customers (
    'phone' character varying,
    'company' character varying,
    'sexcode' character,
    'canceldate' timestamp without time zone,
    'id' bigint,
    'hotline' timestamp without time zone,
    'jobtitle' character varying,
    'address3' character varying,
    'province' character varying,
    'email' character varying,
    'srcode' character,
    'city' character varying,
    'address2' character varying,
    'birth_place' character varying,
    'origdate' timestamp without time zone,
    'address1' character varying,
    'birthdate' timestamp without time zone,
    'rtype' character,
    'fpurch' numeric,
    'fname' character varying,
    'cusid' bigint,
    'lpurch' numeric,
    'altmatch' character varying,
    'primmatch' character varying,
    'lname' character varying,
    'japan_ward' character varying,
    'donotrent' boolean,
    'numpurch' bigint,
    'country' character varying,
    'name' character varying,
    'cpurch' numeric,
    'postalcode' character varying,
    'countrycode' character varying,
    primary key ('id')
)

CREATE TABLE items (
    'pacnet_status' character varying,
    'traynumber' integer,
    'refundamt' numeric,
    'nsfflag' character,
    'inactivedate' timestamp without time zone,
    'shipping' numeric,
    'fulfill_type' character,
    'stepid' bigint,
    'bank_account' character varying,
    'ordertype' character varying,
    'correct4' character,
    'correct2' character,
    'correct3' character,
    'pacnet_tracking' bigint,
    'pasid' bigint,
    'paymentcode' character varying,
    'amount' numeric,
    'ordnum' character varying,
    'bank_route' bigint,
    'ach_date' timestamp without time zone,
    'final_score' numeric,
    'check_no' bigint,
    'continuity' character,
    'currencycode' character varying,
    'id' bigint,
    'entrynumber' integer,
    'ordersource' character varying,
    'updatedate' timestamp without time zone,
    'correct1' character,
    'fulfilldate' timestamp without time zone,
    'source' character varying,
    'purchdate' timestamp without time zone,
    'refunddate' timestamp without time zone,
    'altordnum' character varying,
    'jobid' bigint,
    'product' character varying,
    'whitemail' character,
    'source_id' bigint,
    'updtrans_id' bigint,
    'pin' character varying,
    'origordnum' character varying,
    'subid' character varying,
    primary key ('id'),
    foreign key ('subid') references 'subscriptions'('subid'),
    foreign key ('id') references 'customers'('id')
)

-- Using valid SQLite, answer the following questions for the tables provided above.

-- how many customers purchase item since jan 1 2023?

SELECT

And model outputs:
SELECT COUNT(DISTINCT customers.id) FROM customers WHERE customers.id IN (SELECT items.id FROM items WHERE items.purchdate >= '2023-01-01')

As I expected, but thank you.  If I could run a full 70B model, I could get
ChatGPT performance.  But that's way beyond my budget.  I can try the 7B
and see how long it takes to run.
On Mon, Aug 28, 2023, 5:40 PM senwu @.***> wrote:

After conducting observations, we have found that larger models tend to
perform better than smaller ones. In particular, the
NumbersStation/nsql-llama-2-7B model surpasses the other nsql models in
terms of capability. However, we have noticed that all models exhibit some
level of hallucination issues, which remains a challenging problem for
foundation models. We are actively working to reduce these hallucination
issues in future releases. If you have any other feedback, please don't
hesitate to share it with us, as we are always looking to improve. Thank
you!
Alos here is an example works for me with NumbersStation/nsql-llama-2-7B:
CREATE TABLE customers (
'phone' character varying,
'company' character varying,
'sexcode' character,
'canceldate' timestamp without time zone,
'id' bigint,
'hotline' timestamp without time zone,
'jobtitle' character varying,
'address3' character varying,
'province' character varying,
'email' character varying,
'srcode' character,
'city' character varying,
'address2' character varying,
'birth_place' character varying,
'origdate' timestamp without time zone,
'address1' character varying,
'birthdate' timestamp without time zone,
'rtype' character,
'fpurch' numeric,
'fname' character varying,
'cusid' bigint,
'lpurch' numeric,
'altmatch' character varying,
'primmatch' character varying,
'lname' character varying,
'japan_ward' character varying,
'donotrent' boolean,
'numpurch' bigint,
'country' character varying,
'name' character varying,
'cpurch' numeric,
'postalcode' character varying,
'countrycode' character varying,
primary key ('id')
)
CREATE TABLE items (
'pacnet_status' character varying,
'traynumber' integer,
'refundamt' numeric,
'nsfflag' character,
'inactivedate' timestamp without time zone,
'shipping' numeric,
'fulfill_type' character,
'stepid' bigint,
'bank_account' character varying,
'ordertype' character varying,
'correct4' character,
'correct2' character,
'correct3' character,
'pacnet_tracking' bigint,
'pasid' bigint,
'paymentcode' character varying,
'amount' numeric,
'ordnum' character varying,
'bank_route' bigint,
'ach_date' timestamp without time zone,
'final_score' numeric,
'check_no' bigint,
'continuity' character,
'currencycode' character varying,
'id' bigint,
'entrynumber' integer,
'ordersource' character varying,
'updatedate' timestamp without time zone,
'correct1' character,
'fulfilldate' timestamp without time zone,
'source' character varying,
'purchdate' timestamp without time zone,
'refunddate' timestamp without time zone,
'altordnum' character varying,
'jobid' bigint,
'product' character varying,
'whitemail' character,
'source_id' bigint,
'updtrans_id' bigint,
'pin' character varying,
'origordnum' character varying,
'subid' character varying,
primary key ('id'),
foreign key ('subid') references 'subscriptions'('subid'),
foreign key ('id') references 'customers'('id')
)
-- Using valid SQLite, answer the following questions for the tables provided above.
-- how many customers purchase item since jan 1 2023?
SELECT
And model outputs:
SELECT COUNT(DISTINCT customers.id) FROM customers WHERE customers.id IN (SELECT items.id FROM items WHERE items.purchdate >= '2023-01-01')
—
Reply to this email directly, view it on GitHub
https://github.com/NumbersStationAI/NSQL/issues/10#issuecomment-1696454410,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABVKI2HFVBVMTIBJOCE2SFDXXUF3NANCNFSM6AAAAAA35S5P6I
.
You are receiving this because you modified the open/close state.Message
ID: @.***>

FYI - you might find this paper interesting if you have not seen it:
C3: Zero-shot Text-to-SQL with ChatGPT
It appears that they have achieved better results with a specific prompting method.  The benefit is that they cut the tokens down to around 1,000 per question.  This is tuned to ChatGPT but I'll bet you can modify it to match your model training.  I am going to attempt to integrate some of their code with the example I set up to see what happens.  Maybe the combination of their prompt strategies with your tuned model will make a difference.


Fix: disklessset - More direct confirmation request message in menu

Less confusing confirmation requests for options 3 and 7.

Dear @thiagocardozo
Thank you for this proposal. This is ok for me 😊
Could you please also update the changelog at the bottom of the readme, and also add an entry in the main CHANGELOG file of the repository ? Every code modification is added in changelogs.


Error during training

Hi, Thanks for your code~
I try to apply the code to my environment. During training, I found out

I was wondering if you also had issues like this, is it due to some uninstalled module?

I use this to solve the problem, but I am not sure this is correct though:

The vmap needs to be initialized again after setting the dropout. Try doing this
        def set_drop_out(self, dropout):
                for m in self.original_modules.modules():
                        if isinstance(m, nn.Dropout):
                                m.p = dropout
                fn, params, _ = combine_state_for_ensemble(self.original_modules)
                self.vmap = torch.vmap(fn, in_dims=(0, 0, None), randomness='different', **self.kwargs)

@aditya-spood Thanks a lot !

Hi @hanshuo-shuo @aditya-spood , thanks for initiating the discussion. Is this an issue with the current code, or does it only occur with some changes? I'd like to dig into this and fix any issues with the codebase (or anything that would make it easier to use/extend). It is possible that some behaviors are inconsistent across package versions, in which case I'd like for the code to be less sensitive to the exact versions installed.

@nicklashansen Hi, thanks for your reply.

I made some changes to the envs file and changed the config.yaml

    - override hydra/launcher: basic

And I also change all the devices into cpu: simply change all the device into self.device = torch.device('cuda' if torch.cuda.is_available() else 'cpu') And I also store the memory on cpu only.

Then during training, it produces such errors. I checked pytorch document, and I don't think torch.vmap has the wrapped attribute. But after all the changes I listed above, I can get a really good training result with the smallest model parameter setting after training for 100000 steps.

Thanks for sharing. In that case, I suspect that it might be due to package versions. Would you mind copy/pasting the output of conda list or conda env export here? I'll see if I can reproduce the error on my end.

@nicklashansen  Hi, the output is
channels:
  - pytorch
  - conda-forge
dependencies:
  - aom=3.6.1=hb765f3a_0
  - brotli-python=1.1.0=py39hb198ff7_1
  - bzip2=1.0.8=h93a5062_5
  - ca-certificates=2023.7.22=hf0a4a13_0
  - cairo=1.18.0=hd1e100b_0
  - dav1d=1.2.1=hb547adb_0
  - expat=2.5.0=hb7217d7_1
  - ffmpeg=6.0.0=gpl_h1ceb99f_105
  - filelock=3.13.1=pyhd8ed1ab_0
  - font-ttf-dejavu-sans-mono=2.37=hab24e00_0
  - font-ttf-inconsolata=3.000=h77eed37_0
  - font-ttf-source-code-pro=2.038=h77eed37_0
  - font-ttf-ubuntu=0.83=hab24e00_0
  - fontconfig=2.14.2=h82840c6_0
  - fonts-conda-ecosystem=1=0
  - fonts-conda-forge=1=0
  - freetype=2.12.1=hadb7bae_2
  - fribidi=1.0.10=h27ca646_0
  - gettext=0.21.1=h0186832_0
  - gmp=6.2.1=h9f76cd9_0
  - gmpy2=2.1.2=py39h0b4f9c6_1
  - gnutls=3.7.8=h9f1a10d_0
  - graphite2=1.3.13=h9f76cd9_1001
  - harfbuzz=8.2.1=hf1a6348_0
  - icu=73.2=hc8870d7_0
  - idna=3.4=pyhd8ed1ab_0
  - jinja2=3.1.2=pyhd8ed1ab_1
  - lame=3.100=h1a8c8d9_1003
  - lcms2=2.15=hf2736f0_3
  - lerc=4.0.0=h9a09cb3_0
  - libass=0.17.1=hf7da4fe_1
  - libblas=3.9.0=19_osxarm64_openblas
  - libcblas=3.9.0=19_osxarm64_openblas
  - libcxx=16.0.6=h4653b0c_0
  - libdeflate=1.19=hb547adb_0
  - libexpat=2.5.0=hb7217d7_1
  - libffi=3.4.2=h3422bc3_5
  - libgfortran=5.0.0=13_2_0_hd922786_1
  - libgfortran5=13.2.0=hf226fd6_1
  - libglib=2.78.1=hd9b11f9_0
  - libiconv=1.17=he4db4b2_0
  - libidn2=2.3.4=h1a8c8d9_0
  - libjpeg-turbo=3.0.0=hb547adb_1
  - liblapack=3.9.0=19_osxarm64_openblas
  - libopenblas=0.3.24=openmp_hd76b1f2_0
  - libopus=1.3.1=h27ca646_1
  - libpng=1.6.39=h76d750c_0
  - libsqlite=3.43.2=h091b4b1_0
  - libtasn1=4.19.0=h1a8c8d9_0
  - libtiff=4.6.0=ha8a6c65_2
  - libunistring=0.9.10=h3422bc3_0
  - libvpx=1.13.1=hb765f3a_0
  - libwebp-base=1.3.2=hb547adb_0
  - libxcb=1.15=hf346824_0
  - libxml2=2.11.5=h25269f3_1
  - libzlib=1.2.13=h53f4e23_5
  - llvm-openmp=17.0.4=hcd81f8e_0
  - markupsafe=2.1.3=py39h0f82c59_1
  - mpc=1.3.1=h91ba8db_0
  - mpfr=4.2.1=h9546428_0
  - mpmath=1.3.0=pyhd8ed1ab_0
  - ncurses=6.4=h7ea286d_0
  - nettle=3.8.1=h63371fa_1
  - openh264=2.3.1=hb7217d7_2
  - openjpeg=2.5.0=h4c1507b_3
  - openssl=3.1.4=h0d3ecfb_0
  - p11-kit=0.24.1=h29577a5_0
  - pcre2=10.40=hb34f9b4_0
  - pillow=10.1.0=py39h755f0b7_0
  - pip=23.2.1=pyhd8ed1ab_0
  - pixman=0.42.2=h13dd4ca_0
  - pthread-stubs=0.4=h27ca646_1001
  - pysocks=1.7.1=pyha2e5f31_6
  - python=3.9.7=hc0da0df_3_cpython
  - python_abi=3.9=4_cp39
  - pytorch=2.1.0=py3.9_0
  - pyyaml=6.0.1=py39h0f82c59_1
  - readline=8.2=h92ec313_1
  - requests=2.31.0=pyhd8ed1ab_0
  - setuptools=68.2.2=pyhd8ed1ab_0
  - sqlite=3.43.2=hf2abe2d_0
  - svt-av1=1.7.0=hb765f3a_0
  - sympy=1.12=pypyh9d50eac_103
  - tk=8.6.13=hb31c410_0
  - torchaudio=2.1.0=py39_cpu
  - torchvision=0.16.0=py39_cpu
  - typing_extensions=4.8.0=pyha770c72_0
  - wheel=0.41.2=pyhd8ed1ab_0
  - x264=1!164.3095=h57fd34a_2
  - x265=3.5=hbc6ce65_3
  - xorg-libxau=1.0.11=hb547adb_0
  - xorg-libxdmcp=1.1.3=h27ca646_0
  - xz=5.2.6=h57fd34a_0
  - yaml=0.2.5=h3422bc3_2
  - zlib=1.2.13=h53f4e23_5
  - zstd=1.5.5=h4f39d0f_0
  - pip:
    - absl-py==2.0.0
    - antlr4-python3-runtime==4.9.3
    - astunparse==1.6.3
    - cachetools==5.3.1
    - cellworld==0.0.376
    - certifi==2023.7.22
    - charset-normalizer==3.3.0
    - chex==0.1.83
    - cloudpickle==2.2.1
    - contourpy==1.1.1
    - crafter==1.8.1
    - cv==1.0.0
    - cycler==0.12.1
    - decorator==5.1.1
    - dm-tree==0.1.8
    - farama-notifications==0.0.4
    - flatbuffers==23.5.26
    - fonttools==4.43.1
    - fsspec==2023.10.0
    - gast==0.5.4
    - google-auth==2.23.3
    - google-auth-oauthlib==1.0.0
    - google-pasta==0.2.0
    - grpcio==1.59.0
    - gym==0.26.2
    - gym-notices==0.0.8
    - gymnasium==0.29.1
    - h5py==3.10.0
    - huggingface-hub==0.17.3
    - hydra-core==1.3.2
    - imageio==2.31.5
    - importlib-metadata==6.8.0
    - importlib-resources==6.1.0
    - jax==0.4.18
    - jaxlib==0.4.18
    - json-cpp==1.0.91
    - keras==2.14.0
    - kiwisolver==1.4.5
    - libclang==16.0.6
    - markdown==3.5
    - markdown-it-py==3.0.0
    - matplotlib==3.8.0
    - mdurl==0.1.2
    - ml-dtypes==0.2.0
    - networkx==3.1
    - numpy==1.26.1
    - oauthlib==3.2.2
    - omegaconf==2.3.0
    - opensimplex==0.4.5
    - opt-einsum==3.3.0
    - optax==0.1.7
    - packaging==23.2
    - pandas==2.1.2
    - pettingzoo==1.24.1
    - protobuf==4.24.4
    - pyasn1==0.5.0
    - pyasn1-modules==0.3.0
    - pygments==2.16.1
    - pyparsing==3.1.1
    - python-dateutil==2.8.2
    - pytz==2023.3.post1
    - regex==2023.10.3
    - requests-oauthlib==1.3.1
    - rich==13.6.0
    - rsa==4.9
    - ruamel-yaml==0.17.35
    - ruamel-yaml-clib==0.2.8
    - safetensors==0.4.0
    - scipy==1.11.3
    - six==1.16.0
    - stable-baselines3==2.1.0
    - supersuit==3.9.0
    - tcp-messages==1.0.45
    - tensorboard==2.14.1
    - tensorboard-data-server==0.7.1
    - tensordict==0.2.1
    - tensordict-nightly==2023.6.8
    - tensorflow==2.14.0
    - tensorflow-estimator==2.14.0
    - tensorflow-io-gcs-filesystem==0.34.0
    - tensorflow-macos==2.14.0
    - tensorflow-probability==0.22.0
    - termcolor==2.3.0
    - tinyscaler==1.2.7
    - tokenizers==0.14.1
    - toolz==0.12.0
    - torch==2.1.0
    - torchrl==0.2.1
    - tqdm==4.66.1
    - transformers==4.34.1
    - typing-extensions==4.5.0
    - tzdata==2023.3
    - urllib3==2.0.6
    - werkzeug==3.0.0
    - wrapt==1.14.1
    - zipp==3.17.0

Sorry, my env is a mess.

Hello! Thank you for sharing your great work with all of us.
I also got the same errors when I ran the following command, which is from README instructions. I did not change anything in the code.
python train.py task=dog-run steps=7000000

@purewater0901 I get same error too，but it still dosn't work after I edit the code like above. Could you please tell me how you fix it.

@VitaLemonTea1 I only did this part and it works quite well(Just overwrite it on previous layer's code)

I use this to solve the problem, but I am not sure this is correct though:

@VitaLemonTea1 @hanshuo-shuo
Yes, I changed the code as @hanshuo-shuo showed here.
You can also add a new function to this class that is indicated in this thread, but I'm not sure if it's necessary.

@purewater0901 @hanshuo-shuo
Thanks a lot！

Hi all,
Thank you for your patience. I spent a few hours investigating this today, and it appears that the existence of vmap.__wrapped__ in torch/functorch was very short-lived. I have issued a fix here https://github.com/nicklashansen/tdmpc2/commit/f3139291e2dc8e47480184a4a1bce05e8980caa3 which removes the modules() function call altogether. This specific part of the implementation is not critical, and I have verified that results are reproduced on a handful of tasks.
This commit also updates environment.yaml to circumvent the broken gym setup mentioned here https://github.com/openai/gym/issues/3176 and here https://github.com/nicklashansen/tdmpc2/issues/2.
I'll close this issue, but please feel free to re-open if you run into any other issues.


MJ4.0.0-beta.4: \rm in subscript yields Math input error

Issue Summary
\rm in the subscript yields Math input error in beta.4, but not beta.3 and earlier
Steps to Reproduce:

Go to https://codepen.io/alexedgcomb/pen/BabMpmG
Observed: \(a_\rm{b}\) yields `Math input error

Expected: No such error, like in 4.0.0-beta.3
https://codepen.io/alexedgcomb/pen/QWoYdOR

Technical details:

MathJax Version: 4.0.0-beta.4
Client OS: MacOS 13.4
Browser: Firefox 122 and Chrome 121

I am not using a MathJax configuration and loading MathJax via
<script<EMAIL_ADDRESS>
Supporting information:
Interestingly, the following typeset as expected:

\(\rm{b}\): So, not just a bad \rm
\(a_\textrm{b}\): So, not just a bad subscript followed by command

Repro steps:

Go to https://codepen.io/alexedgcomb/pen/QWoYdOR
Observed:

Actually, both v3 and v4 are incorrect for this, as a_\rm{b} is not a valid LaTeX expression (actual LaTeX throws an error for this).  Note that \rm is not a macro that takes an argument, like \mathrm, but is a switch that makes everything following it be in upright letters.  So a_\rm{b} is effectively {a_\rm}{b}, which produces an error in LaTeX (due to how \rm is implemented).  Note that if you did \rm{b}x then the x would also be upright since \rm makes everything after it be upright.  The macros \bf, \it, etc. also work the same way.  So you should do {\rm b} not \rm{b}, and a_{\rm b} would do what you expect.
This is in contrast to commands like \mathrm, \textrm, \symrm, and so on, which take an argument and put that in upright form.  Because of that (and how they are implemented), a_\mathrm{b} is effectively the same as a_{\rm b}, which is a valid expression.  Similarly, \mathrm{b}x should have the b upright, but the x in italics, where \rm{b}x has both upright.
I was surprised to see that v3 didn't give an error for a_\rm{b} as it should have, but looking into the internals, I have found out why.  It is not an easy fix, and I will have to think about how best to handle it.
The error in v4 is due to new code that tries to attach to the internal MathML nodes the LaTeX that produced that node, and it is crashing on this construction.  I know where it is happening, but haven't tried to resolve the issue yet.
In any case, you should be using either a_{\rm b} or a_\mathrm{b}, but not a_\rm{b}, which will produce an error in future versions.

Thank you for explaining!


connecting to graphenedb fails with "Error receiving data"

As a test, I've recently created a graphenedb instance in the cloud.
I've filled in the remote connection strings in the config.yml and then I get an "Error receiving data", with no clue what part of the connection is not established.
The scheme, host and port are correct because if I change them, they give a different error.
Changing the user or password results in error. Reading the graphene PHP guide, it appears to need a TLS required setting. How do I check if this is set? And how do I determine what part of the connection string causes the error?

Hello @sfdreverman, I think you should post your issue on the https://github.com/graphaware/neo4j-bolt-php repository since this bundle is just an enhancer for a usage with Symfony.

True, but the problem is that I don't have access to the call that builds the connection (I just call getClient)... so I wondered if there is a way to specify or configure (from Symfony) that I need a TLS connection?


Starting from a specific playback point

It's helpful to be able to start from middle of a record. e.g.
http://asciinema.org/a/5970?t=3:20
http://asciinema.org/a/5970#t=3:20

This enables more efficient sharing.

There's related issues in player's repo: https://github.com/asciinema/asciinema-player/issues/13
Implementing it first in the player will enable us to add this feature asciinema.org.

Works now: https://asciinema.org/a/5970?t=3:20
@hupili can you test?

@sickill  works perfectly! Thanks for keeping on improving this cool service!


Compare arrays by value only when passed to assert methods directly

In all the other cases (when inside other collections, e.g.) test arrays equality by reference. That's the only way to make array equality consistent across all possible cases. See #790 for detailed explanations.
These are breaking changes, so perhaps they should be released in a major TestNG version. The solution looks ugly and has lot's of boilerplate code caused by how Java method dispatch works regarding arrays.
N.B. assertEquals/assertNotEquals aren't implemented for arrays of floating point types yet.

@juherr I've composed the PR of separate commits for tests and implementation to make it clear how the behavior changed in a "TDD way" :wink:

Another approach would be to compare arrays by assertEquals(Object, Object) but I consider sacrificing shorter implementation for properly typed interface worthwhile.
If you're okay with proposed solution I'll add methods for comparing arrays of floating point numbers as well.

These are breaking changes, so perhaps they should be released in a major TestNG version.

I think so too.
BTW, we have to wait @cbeust feedbacks :)

Bit scared by the breaking change. And since the use of arrays is discouraged overall anyway, I'm not really inclined to merge this...
Thoughts?

I think we are all agree we should wait a major release before merging, even if array assertion is currently "broken".
@cbeust
But what do you think about the functionnal change?
@raindev
I supposed the alternative you proposed has the same drawbacks and deap changes?

@cbeust there still lot's of APIs using arrays, they aren't going away anytime soon. I think that keeping current behavior is more dangerous than introducing breaking changes as it could cover bugs and give false positives. Predictability and consistency are obviously very important for a framework we rely on to verify code of our correctness.
Also, it may be a good idea to warn users that use of arrays inside collections could lead to unpredictable results in assertions before the fix will be released.
@juherr an alternative implementation, while retaining the same behavior, would result in less cumbersome code. But I think that using assertEquals(Object, Object) for array assertion is confusing from a user standpoint. If you think it is worthwhile, I could try to rewrite the code in the alternative approach so we could compare the results.

@cbeust any plans regarding major version release?

I can release any time since there have been a reasonable number of fixes and patches since the last version thanks to the indefatigable @juherr.
Julien, anything you'd like to squeeze in before I cut a new release? (probably this coming week)

Nope, there is nothing urgent on my side.

If we're going to release this patch in the next major version, I need to prepare it a little bit. Methods for arrays of floating point numbers assertions need to be implemented.

@raindev I think we will release a new version in the next days. We can add this PR too if you have time to finish it.

@juherr thank you for pinging me. Yes, I'm going to finish this PR the following days.

I decided to not pursue precise separate methods for each array type and aim for much simpler implementation despite somewhat looser interface.
The PR is feature complete from my perspective and ready to review/merge/release.

@juherr ping me if anything else needs to be updated to make the patch ready for the release.

I will check it asap, thank @raindev :)

It looks good for me :+1:
To be sure to understand: you removed tests because they were wrong with the new implementatation, rigth?

Thank you for the review. Yes, MapTest doesn't represent current behavior anymore, the same case is covered in ArrayEqualityAssertTest.arrayInsideMapAssertEquals. The behavior described in int_Integer_Arrays is still the same but is tested in ArrayEqualityAssertTest.mixedArraysAssertEquals.

I have messed assertions tests for arrays of boxed values a little bit so cleared them out in two recent commits.

@cbeust any hope to get this PR merged?

Thanks @raindev !


[1.19.2] This could use Deep Mob Learning's comprehensive config

I personally loved the config DML had, and it's one reason I always used it - however, this has basically no options you can change, which is a shame.
It'd be great if we got a config akin to DML's - setting custom variants of mobs, adding/removing loot from the Fabricator, changing the TF usage per-tier of each model, etc.

All of these can be accomplished by using a datapack to change the data models https://github.com/Shadows-of-Fire/Hostile-Neural-Networks/tree/1.19/src/main/resources/data/hostilenetworks/data_models

god, why it always a datapack :'c

Because that is the direction Mojang has opted for Minecraft to take.


[keyvault] keyvault-keys: fix listPropertiesOfKeysVersions pagination

Packages impacted by this PR

@azure/keyvault-keys

Issues associated with this PR

Fixes #26547

Describe the problem that is addressed by this PR
Fixes a bug introduced in the Core v2 migration breaking pagination of listPropertiesOfKeysVersions. The call to the generated getKeyVersionsNext had the arguments for the continuation token (nextLink) and the key name the wrong way around.
Are there test cases added in this PR? (If not, why?)
Fixed tests to actually cover pagination when there are multiple pages.

API change check
API changes are not detected in this pull request.


fix: lazy require other dependencies

I'm using lazy.nvim and I've just began learning lean. However, even when I'm editing projects in other languages, some annoying errors popped out from this plugin.
Failed to run `config` for lspsaga.nvim
/home/cl/.config/nvim/lua/modules/utils/init.lua:39: attempt to index field 'colors_name' (a nil value)
# stacktrace:
  - ~/.config/nvim/lua/modules/utils/init.lua:39 _in_ **get_palette**
  - ~/.config/nvim/lua/modules/utils/init.lua:150 _in_ **gen_lspkind_hl**
  - ~/.config/nvim/lua/modules/configs/completion/lspsaga.lua:2 _in_ **config**
  - /lean.nvim/ftdetect/lean.lua:5
  - vim/_editor.lua:0 _in_ **cmd**
  - ~/.config/nvim/lua/core/pack.lua:128 _in_ **load_lazy**
  - ~/.config/nvim/lua/core/pack.lua:131
  - ~/.config/nvim/lua/core/init.lua:166 _in_ **load_core**
  - ~/.config/nvim/lua/core/init.lua:174
  - ~/.config/nvim/init.lua:2

As is mentioned in its README, Lazy.nvim will automatically run init for all plugins, regardless of their laziness (by lazyness I mean lazy-loading). And unfortunately, the plugin has required other plugins in its ftdetect script.
It's actually an easy one-line fix, the function to call will be lazily loaded. The file is reformatted.

Ah, thanks! I would like to transition to lazy.nvim myself in the near future. Feel free to add your config to the wiki if you find the time (which reminds me that I also need to add my packer config).

My NeoVim config is based on nvimdots, it's actively developed and willing to adopt new configs.


update dates for Barcelona

@stevepiercy could you add a changelog entry?

The commit message is the change log entry. Is a duplicate entry really necessary for this minor change?

Thank you!

thanks for your contribution :-)


Poor Naming  convention

file link :
https://github.com/the-moonLight0/Hactober-fest-2021/blob/089d4d6c5c8833ef8f11fc0686a61dc68b8262e5/Solution.java
This file contains the solution to detect loops in a linked list.
Please give this file a good and descriptive name.

Please assign me this issue. thanks.

Here is the PR.
https://github.com/the-moonLight0/Hactober-fest-2021/pull/53
Kindly assign this PR to me

done


Adding PKCE support for Developer portal applications.

Purpose
Adding the following properties to key manager operations
pkceMandatory:
type: boolean
pkceSupportPlain:
type: boolean
bypassClientCredentials:
type: boolean

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Tests implementation

75 coverage:

Edit
TimeGroup
TimeField
ActiveDayTime
LabouredStatistics
WeeklyCalendar
MonthlyCalendar
WeekGraph
GaugeBar

And some minor fixes.

Tests were failing because of missing definition of moment locale @ America/Sao_Paulo

Codecov Report

Merging #63 into master will increase coverage by 29.38%.
The diff coverage is 75.75%.

@@             Coverage Diff             @@
##           master      #63       +/-   ##
===========================================
+ Coverage   47.06%   76.44%   +29.38%
===========================================
  Files          41       42        +1
  Lines        1243     1261       +18
  Branches      243      243
===========================================
+ Hits          585      964      +379
+ Misses        624      262      -362
- Partials       34       35        +1

Impacted Files
Coverage Δ

client/components/edit/ActiveDayTimes.jsx
82.25% <0%> (+77.49%)
:arrow_up:

client/components/Edit.jsx
94.67% <100%> (+92.32%)
:arrow_up:

client/components/edit/TimeGroup.jsx
94.73% <100%> (+73.68%)
:arrow_up:

client/components/edit/SuggestionBox.jsx
95.65% <100%> (+82.6%)
:arrow_up:

client/components/edit/TimeField.jsx
92.3% <100%> (+88.46%)
:arrow_up:

shared/utils.js
91.3% <100%> (+34.78%)
:arrow_up:

client/components/edit/WeeklyCalendar.jsx
100% <100%> (+73.33%)
:arrow_up:

client/components/edit/MonthlyCalendar.jsx
90.9% <100%> (+72.72%)
:arrow_up:

client/components/edit/WeekGraph.jsx
94.44% <100%> (ø)

client/components/edit/ActiveDayTasks.jsx
92.3% <75%> (+69.23%)
:arrow_up:

... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e02f645...06d5fe4. Read the comment docs.


Filters don't work

Filters don't work if the title contains the word "brain." It won't filter out this story even when I have "brain" set as a filter.
It don't work in top 24 and 48 view.

Good catch, seems i forgot to implement this for the Algolia API's. Fixed in https://github.com/SimonHalvdansson/Harmonic-HN/commit/027e725d00ebd4e9bff33819d744a2a9d7d09af7 just now


feat: add experimental rust-based client

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (4ac99a5) 90.04% compared to head (4698ced) 89.86%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #494      +/-   ##
==========================================
- Coverage   90.04%   89.86%   -0.18%
==========================================
  Files          19       19
  Lines        1125     1125
==========================================
- Hits         1013     1011       -2
- Misses        112      114       +2

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


fix broken table formatting for Httpupstream

The table markup for Httpupstream section was broken. This fixes it.

Coverage remained the same at 92.748% when pulling cb0f078d641ca182e43dfb49023235745d1c1d78 on shamrin:patch-1 into 88356fac2c095537e5364298da5f43ba500932db on tarent:master.

thx


i need help???

Describe your problem here.
How do i change the misses text to combo breaks?????
Are you modding a build from source or with Lua?
Source
What is your build target?
Windows x86/x32
Did you edit anything in this build? If so, mention or summarize your changes.
No

no but like in the source code???

no but like in the source code???

Playstate.hx line 2304


After compiling in dev mode, the sprite annotations cannot be found

This is caused by removeURLVersion in SpriteResource._onImageLoad expecting there to be a version, and so removing everything before the resolution in the URL.

This has been fixed as of 809e7d9.

This has been fixed as of 809e7d9.


Main

👷 Deploy Preview for peaceful-eclair-57a940 processing.

Name
Link

🔨 Latest commit
f1d39487e4d91ecc9270c4bb6bf19678680e2742

🔍 Latest deploy log
https://app.netlify.com/sites/peaceful-eclair-57a940/deploys/663101b8fd9f60000833cdde


Add option to install with sudo

As @wjwwood suggested during our discussion of #42, we could accommodate system installations by adding an option to ament build, say, --sudo-install that would prefix the install steps (but not the build steps) with sudo.  Windows compatibility would be an issue, so perhaps this option wouldn't be supported on that platform.

Some additional thoughts.
The script could detect that the target location is not writable by the user and prompt for escalated privileges automatically, something like:
+++ Installing 'test_rclcpp'
The target location '<install dir>' is not writable by your user, would you like to escalate your privileges?
[Y/n] Y
password:
==> '. /Users/william/ros2/build/test_rclcpp/cmake__install.sh && /usr/bin/make install' in '/Users/william/ros2/build/test_rclcpp'
[  3%] Built target test_rclcpp__cpp
[ 24%] Built target test_rclcpp__rosidl_typesupport_opensplice_cpp
[ 30%] Built target test_rclcpp__rosidl_typesupport_introspection_cpp
[ 33%] Built target test_rclcpp__c
[ 51%] Built target test_rclcpp__rosidl_typesupport_connext_cpp
[ 51%] Built target test_rclcpp
[ 54%] Built target gtest_intra_process__rmw_connext_cpp
[ 57%] Built target gtest_intra_process__rmw_connext_dynamic_cpp
[ 60%] Built target gtest_intra_process__rmw_fastrtps_cpp
[ 63%] Built target gtest_intra_process__rmw_opensplice_cpp
[ 66%] Built target gtest_subscription__rmw_connext_cpp
[ 69%] Built target gtest_subscription__rmw_connext_dynamic_cpp
[ 72%] Built target gtest_subscription__rmw_fastrtps_cpp
[ 75%] Built target gtest_subscription__rmw_opensplice_cpp
[ 78%] Built target gtest_timeout_subscriber__rmw_connext_cpp
[ 81%] Built target gtest_timeout_subscriber__rmw_connext_dynamic_cpp
[ 84%] Built target gtest_timeout_subscriber__rmw_fastrtps_cpp
[ 87%] Built target gtest_timeout_subscriber__rmw_opensplice_cpp
[ 90%] Built target gtest_timer__rmw_connext_cpp
[ 93%] Built target gtest_timer__rmw_connext_dynamic_cpp
[ 96%] Built target gtest_timer__rmw_fastrtps_cpp
[100%] Built target gtest_timer__rmw_opensplice_cpp
...

To prevent this from happening on a build farm it could detect that the shell is not interactive and just bailout.
Another strategy could be that you run the whole command as sudo, but you can tell the command what user to run itself as (except for the installs). This is probably harder/less common.

Closing since the repo is archived.


Surface capabilities query causes a validation error on windows

Version of vulkano: 0.32.3 and master
OS: Windows 10
GPU (the selected PhysicalDevice): Nvidia 1080 Ti
GPU Driver: 516.94

Running the triangle example with validation layers injected at runtime by the vulkan configurator results in this validation error:
    Objects: 1
        [0] 0x2916bb1aa60, type: 1, name: NULL
Using device: NVIDIA GeForce GTX 1080 Ti (type: DiscreteGpu)
VUID-vkGetPhysicalDeviceSurfaceCapabilities2KHR-pNext-02671(ERROR / SPEC): msgNum: -1949531159 - Validation Error: [ VUID-vkGetPhysicalDeviceSurfaceCapabilities2KHR-pNext-02671 ] Object 0: VK_NULL_HANDLE, type = VK_OBJECT_TYPE_DEVICE;
| MessageID = 0x8bcc83e9 | vkGetPhysicalDeviceSurfaceCapabilities2KHR(): pSurfaceCapabilities->pNext contains VkSurfaceCapabilitiesFullScreenExclusiveEXT, but pSurfaceInfo->pNext does not contain VkSurfaceFullScreenExclusiveWin32InfoEX
T The Vulkan spec states: If a VkSurfaceCapabilitiesFullScreenExclusiveEXT structure is included in the pNext chain of pSurfaceCapabilities, a VkSurfaceFullScreenExclusiveWin32InfoEXT structure must be included in the pNext chain of pS
urfaceInfo (https://vulkan.lunarg.com/doc/view/<IP_ADDRESS>/windows/1.3-extensions/vkspec.html#VUID-vkGetPhysicalDeviceSurfaceCapabilities2KHR-pNext-02671)
    Objects: 1
        [0] 0, type: 3, name: NULL

The validation layer is less detailed than the spec, which says:

If the pNext chain includes a VkSurfaceFullScreenExclusiveInfoEXT structure with its fullScreenExclusive member set to VK_FULL_SCREEN_EXCLUSIVE_APPLICATION_CONTROLLED_EXT, and surface was created using vkCreateWin32SurfaceKHR, a VkSurfaceFullScreenExclusiveWin32InfoEXT structure must be included in the pNext chain


Feature: safe stop

The base controller stops the robot if there is no command received in a defined amount of time.

This is a needed security feature. lgtm

@adamantivm JFYI, this was a difference between the public repository's code and my local copy of base_controller, so it seemed a good and simple feature to upstream.


[Bug Report] Write Barrier in DRAM Sharded MM Reader causing a hang

Describe the bug
Inserting a barrier inside matmul/device/kernels/dataflow/reader_bmm_tile_layout_in0_sender_dram_sharded.cpp after a noc_async_write_multicast_loopback_src causes DRAM Sharded Matmul tests to hang consitently.
There is a possibility that this is causing LLAMA to hang (tracked here: https://github.com/tenstorrent/tt-metal/issues/15018).
To Reproduce
Please check out asaigal/dram_sharded_reader_hang and run:
pytest -svv tests/tt_eager/python_api_testing/unit_testing/misc/test_matmul_dram_sharded.py::test_matmul_in1_dram_sharded_with_mm_chain
The test should hang immediately. NOC should report that at least one of the worker NCRISC cores is stuck at waypoint BWW, which corresponds to the barrier issued in the reader kernel.

pushed a change to yugao/hang. with barrier it can pass now because the number of dest set in mcast matches the actual num cores sent.
The reason is that when receiving responses from noc, I purposely set the number of cores to be less than the actual num dest (was under the impression that this could save some cycle).
Fixing this does not solve hang, as this shouldn't affect the following ops (the sw counter for noc is reset for each op).

I'm seeing the same hang even with https://github.com/tenstorrent/tt-metal/commit/f3291fb52e6931b28ebd93e1e4571bb456b5b63c . The difference is I've got the noc_async_write_barrier at the end of the kernel, not in the middle, so it's possible the error is happening after the other barrier, or on a different codepath.

@jbaumanTT the hang is for the unit test or llama? if it's the dram sharded unit test, could you please share your code changes so I can repro

@jbaumanTT I pushed a fix to the barrier error, the number of cores set for one type of mcast sender is wrong (should -1).
however, the tested kernel is now passing, but the dispatcher is stuck at noc_async_atomic_barrier, and test hangs at "NABW"
I confirm that all the kernels for MM now has thre barriers at the very end and they passed the barrier.
Could you also try on your end, see if it's a dispatcher issue, or the interaction with MM? Thanks
I pushed to yugao/hang

@tt-asaigal the fix is in main, could we close if this issue is resolved?

thanks @yugaoTT !


Doc iter-tools/regex impl

See: https://github.com/iter-tools/regex. It contains a proposed API as well as a polyfill implementation. Thanks to @jcbhmr for pointing this proposal out to me!

To my knowledge backtracking is fully impossible to support in a proper streaming engine. Lookahead is tricky but possible to support. I also happen to support quantized repetition. Re2 simply blocks quantized repetition when streaming! I pay a price for that though, since I don't have any DFA optimization and the optimization that makes quantized repetition work OK blocks me from implementing a DFA optimization.
As a note if I do finish supporting lookahead all lookahead state would be fully preserved between subsequent matches.


Gradle plugin: Local JAR dependencies fail to copy

When running copyAppDependencies from the Gradle plugin, I'm bumping into an issue where the local jar dependencies I've defined are not being copied to the fxlauncher folder, and have no entry in app.xml
So in my build.gradle I'll use either 'fileTree' or 'files' to compile my local dependencies (I've tried testing both)
dependencies {
        compile fileTree(dir: 'lib', include: '*.jar')
        compile files('lib/example1.jar', 'lib/example2.jar')
}

I'm fairly new to Gradle so not sure if I'm missing something obvious.
Cheers.

Hi! I'm fairly new to gradle myself and had help creating the plugin, but I suspect the plugin will only copy dependencies defined in a repo, not adhoc stuff based on files. To make this work with the current version of the plugin you can install these files into your local maven repo and refer to them with maven coordinates (remember to add mavenLocal()). I'll try to figure out how to deal with adhoc files ASAP, but unfortunately I'm bogged down with work at the moment, so this could take a while. I hope you can use the workaround described above in the meantime.

I use small apps the task jar fat to generate just one jar with embedded dependencies. Modifying the pluggin fxlauncher to catch only the jar generated by fatjar?

For FXLauncher deployment I see no upside to this. It means that even if you just change one dependency your clients would have to download all dependencies again.

I followed your suggestion with the local maven repo, so it's copying across as expected now, thanks for pointing me in the right direction!

Great to hear :) Can you live with this for now, so we close the issue?

Yep, solution works well. Closing :)


Make CommitList display "Working tree clean"

When there are no changes in the working directory, the top placeholder commit says "Working tree clean".
I added a function bool is_working_tree_clean(void) const in class CommitModel : public QAbstractListModel.  Is there a better place to put this function?  I'm a C++ beginner.  I was trying to figure out how to access the is_working_tree_clean() function in other places in CommitList.cpp but couldn't figure out a clean way to do it...

Resolves #704

Looks like the macos build failed because of a timeout - Did I do that?  Or does the timeout need to be increased?

Thanks for the changes. Is this ready?
I think the is_working_tree_clean function is fine there

@Murmele
I think this is good to merge in, but it might be nice to merge #714 first, because that fixes a bug with this element.  But it's your call of course.

@Murmele
I will leave this as a Draft until #714 gets merged in because this depends on #714.

Now this can be rebased as well :)

Hmmm... Looks like I broke some tests... I'll look into this...


Brillig linking could result in code segments being overwritten

Problem
See here
When we are linking two independent artifacts, it could be the case that their labels collide and one artifact overwrites the labels in another artifact.
A traditional linker may error here or in some cases just issue a warning.
Happy Case
We should provide an error here and in order to ensure that the labels are unique, we can add the function ID and possibly the name to the label, instead of just the basic block ID
Alternatives Considered
No response
Additional Context
No response
Would you like to submit a PR for this Issue?
No
Support Needs
No response

This may be more helpful if it was stateful, ie when we are in a particular block, and we add a label, it will automatically prepend the function id and block. Then when you exit the block, you "pop off" that block from the label stack

@sirasistant what is the status of this issue?

It was done in https://github.com/noir-lang/noir/pull/1652, It didn't auto close because it was merged to a branch that we used as a  batch merge to master. Closing this!


Source control status bar not detecting git worktree branch name

Does this issue occur when all extensions are disabled?: Yes/No

VS Code Version:: 1.73.0
OS Version: macOS 12.6.1

Steps to Reproduce:

cd some_git_repo
git worktree add ../second_some_git_repo -b new_branch
code ../second_some_git_repo
Source control status bar shows the branch of the main git worktree instead of the new worktree
CTRL + P Git rename branch shows wrong branch name -> returns am
But gitlens copy current branch name works correctly returns new_branch
Hence bug is in source control

In this image you see that my terminal displays the right branch name am but

Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.73.1. Please try upgrading to the latest version and checking whether this issue remains.
Happy Coding!

1.73.1 has fixed it!!!


Configure API Key not found

Hi,
I installed the extention CodeCursor to my VScode. I tried the command: aicursor.configureApiKey
The command is not found

VS Code console
Activating extension 'ktiays.aicursor' failed: Cannot set property crypto of #<Object> which has only a getter


Fix for KeyError: 'message'

PR TYPE

Why did you open this PR (If it is other, please write a more detailed description.)

[ ] New feature
[x] Fix bug
[ ] Typo
[ ] Other

Checks

[ ] Did you use the black formatter?
[ ] Does this requires the users to change their code?
[x] Did you test?
[ ] Have you updated the docs?
[ ] Can you listen to our requests?
[ ] Did you use conventional commits

Could you change res["d"]["type"] in (1, 2) to res["d"]["type"] == 3

Changed, tested.
Changed to res["d"]["type"] != 3 because of it being a return statement.


util/log: stop syncing writes excessively

PR: https://github.com/cockroachdb/cockroach/pull/58995
From release notes:

The parameter sync-writes for file sink configurations has been removed. (This is not a backward-incompatible change because the configuration feature is new in v21.1.) [#58995][#58995] {% comment %}doc{% endcomment %}

Closed by #10273.


python312Packages.hstspreload: 2024.5.1 -> 2024.6.1

Diff: https://github.com/sethmlarson/hstspreload/compare/refs/tags/2024.5.1...2024.6.1
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 319780 run on x86_64-linux 1

4 packages built:

python311Packages.hstspreload
python311Packages.hstspreload.dist
python312Packages.hstspreload
python312Packages.hstspreload.dist


Dismissing a suggestion at the end of buffer leaves extra empty lines

First of all, thank you for this amazing package!
Steps to reproduce:

Open an empty file test.el with global-copilot-mode enabled
Type something like (defun test () nil) and press Enter
You'll see a suggestion like (defun test2 () nil).
Dismiss it by hitting C-g or going back to the first line
Save the buffer
You can see the saved file has an empty line at the end.

I understand that you need to add empty lines at the step 3 for a suggestion to be shown, so I'm just wondering if it is possible to remove them when the suggestion is dismissed.

Workaround: use https://github.com/lewang/ws-butler
I will try to fix it later.

It seems that the problem comes from these lines:
    (if (= (line-end-position line) (1- (point-max)))
        ; special case if the last line is empty
        (progn
          (goto-char (point-max))
          (newline)
          (forward-char -1))
      (forward-line line)
      (forward-char col))

Do we actually need this special case? I tested removing it and everything worked fine for me:
@@ -389,14 +389,8 @@ USER-POS is the cursor position (for verification only)."
   (save-excursion
     (widen)
     (goto-char (point-min))
-    (if (= (line-end-position line) (1- (point-max)))
-        ; special case if the last line is empty
-        (progn
-          (goto-char (point-max))
-          (newline)
-          (forward-char -1))
-      (forward-line line)
-      (forward-char col))
+    (forward-line line)
+    (forward-char col)

     ; remove common prefix
     (let* ((cur-line (s-chop-suffix "\n" (or (thing-at-point 'line) "")))

(my Emacs version is 30.0.50)

@Rogach Patch applied. Thanks for your elegant solution!


Fixes to Environment articles on iOS and Android

Android system property server store
Changed the old MSDN URLs to point to the API section of Microsoft Docs
Replaced Xamarin Studio with Visual Studio for Mac, since VS for Mac was already referenced in the earlier paragraph.

Thanks for the PR, @HankiDesign! @mgmclemore the iOS changes on this look good - would you mind reviewing the Android changes?


RelativeTo transform does not take non-zero worldspace positions into account for remote users?

When I specify the relative transform, it's fine on the owner, but on the remote user, it doesn't appear to restore the position point back to the world space from the local space of the object. I had to move the element to worldspace 0,0,0 in order for the sync to line up on remote users.

That feature is not completely implemented, there is a lot missing so I suggest not using origins that are either rotated, scaled or offset from the world origin yet. Thanks for creating a ticket though.


Link into this article appears misleading

The link I followed in here was about events to commands but I can't find anything about this in this article.  This was the page I came from: https://developer.xamarin.com/samples/xamarin-forms/Behaviors/EventToCommandBehavior/

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: de196cde-8c57-8c92-4495-fcfa066682f9
Version Independent ID: 50986b5c-9e22-fd23-aed7-2d3b15ae0dbf
Content: Xamarin.Forms Behaviors - Xamarin
Content Source: docs/xamarin-forms/app-fundamentals/behaviors/creating.md
Product: xamarin
GitHub Login: @davidbritch
Microsoft Alias: dabritch

Hi @PatrickRyder
The page you want is: https://docs.microsoft.com/en-gb/xamarin/xamarin-forms/app-fundamentals/behaviors/reusable/event-to-command-behavior
I'll update the link.


Feedback Form

Describe new feat
Create a feedback form to propose a feature, request new sounds or report an error.
This can be done using the GitHub API, to create new issues when the form is submitted.
Referencies
No response

Github issues can be used for this


Errors getting count on SQL server with queries that have repeated columns (and SQLite)

System information:

Operating system (distribution) and version: Windows 10 Pro  10.0.19042 N/A Build 19042
DBeaver version: 21.0.1
Additional extensions: none

Connection specification:

Database name and version: Microsoft SQL Server 2017 (RTM) - 14.0.1000.169 (X64) ¶ Aug 22 2017
Driver name: Microsoft JDBC Driver for SQL Server
Do you use tunnels or proxies (SSH, SOCKS, etc)?  no

Describe the problem you're observing:
Select Version, *
from table

Error when clicking Calculate Total Row Count column:
Error executing row count
  SQL Error [8156] [S0001]: The column 'Version' was specified multiple times for 'dbvrcnt'.
  SQL Error [8156] [S0001]: The column 'Version' was specified multiple times for 'dbvrcnt'.
    The column 'Version' was specified multiple times for 'dbvrcnt'.
    The column 'Version' was specified multiple times for 'dbvrcnt'.

thanks for the bug report

This also happens with sqlite 3.32.3 with query like this:
select distinct col1, col2 from table

Error executing row count
  SQL Error [1]: [SQLITE_ERROR] SQL error or missing database (wrong number of arguments to function count())
  SQL Error [1]: [SQLITE_ERROR] SQL error or missing database (wrong number of arguments to function count())
    [SQLITE_ERROR] SQL error or missing database (wrong number of arguments to function count())
    [SQLITE_ERROR] SQL error or missing database (wrong number of arguments to function count())

This problem is specific to SQLite and SQL Server syntax and how DBeaver processes row count for this databases. Unfortunately we don't have a solution for this so far. For the time being, as a workaround, you can count rows (if you need to know exact number) by doing minor adjustments to your query to not include duplicate columns.


[idea] Allow set to open an editor to input the data

Instead of typing a one-liner such as set /test '{"super": "long", "json": "file", "with": {"nested": "values"}}, we could only type set /test, wich would open the user's EDITOR, in which the value would be typed in, saved to a tmpfile, read, and assigned to the znode.

Fixed in 50d9e5f42e32edccb5962a8b6b4b0e1400f03afc


make ExecutableFlow initialization methods common util methods

This PR consolidates some methods of initialization of ExecutableFlow which used in multiple places  into common static util methods.
The motivation is to let flow trigger leverage those method to start an executable flow(https://github.com/azkaban/azkaban/issues/1526).

LGTM except for the thing @kunkun-tang pointed out. Once that's fixed I'll give a ship it :+1:.

@reallocf updated


[Deep-links][Removal]

Deleted file

Docs Build status updates of commit 4833857:
:warning: Validation status: warnings

File
Status
Preview URL
Details

msteams-platform/TOC.yml
:warning:Warning
View
Details

msteams-platform/tabs/how-to/access-teams-context.md
:warning:Warning
View
Details

msteams-platform/tabs/design/tabs.md
:warning:Warning
View
Details

msteams-platform/resources/bot-v3/bots-with-tabs.md
:warning:Warning
View
Details

msteams-platform/samples/integrating-web-apps.md
:warning:Warning
View
Details

msteams-platform/whats-new.md
:warning:Warning
View
Details

msteams-platform/tabs/how-to/create-tab-pages/content-page.md
:warning:Warning
View
Details

msteams-platform/concepts/build-and-test/deep-links.md
:white_check_mark:Succeeded

msteams-platform/TOC.yml

Line 70, Column 11: [Warning-file-not-found] Invalid file link: 'concepts/build-and-test/deep-links.md'.

msteams-platform/tabs/how-to/access-teams-context.md

Line 37, Column 56: [Warning-file-not-found] Invalid file link: '~/concepts/build-and-test/deep-links.md'.

msteams-platform/tabs/design/tabs.md

Line 137, Column 70: [Warning-file-not-found] Invalid file link: '../../concepts/build-and-test/deep-links.md'.
Line 145, Column 1: [Warning-duplicate-alt-text] Alt text 'Illustration showing what to do with tab navigation design.' is duplicated. Within an article, alt text must be unique.
Line 153, Column 1: [Warning-duplicate-alt-text] Alt text 'Illustration showing what not to do with tab navigation design.' is duplicated. Within an article, alt text must be unique.
Line 166, Column 1: [Warning-duplicate-alt-text] Alt text 'Illustration showing what to do with tab navigation design.' is duplicated. Within an article, alt text must be unique.
Line 174, Column 1: [Warning-duplicate-alt-text] Alt text 'Illustration showing what not to do with tab navigation design.' is duplicated. Within an article, alt text must be unique.

msteams-platform/resources/bot-v3/bots-with-tabs.md

Line 25, Column 332: [Warning-file-not-found] Invalid file link: '~/concepts/build-and-test/deep-links.md'.

msteams-platform/samples/integrating-web-apps.md

Line 68, Column 264: [Warning-file-not-found] Invalid file link: '../concepts/build-and-test/deep-links.md'.
Line 94, Column 61: [Warning-file-not-found] Invalid file link: '../concepts/build-and-test/deep-links.md'.

msteams-platform/whats-new.md

Line 62, Column 97: [Warning-file-not-found] Invalid file link: 'concepts/build-and-test/deep-links.md'.
Line 66, Column 80: [Warning-file-not-found] Invalid file link: 'concepts/build-and-test/deep-links.md'.

msteams-platform/tabs/how-to/create-tab-pages/content-page.md

Line 53, Column 153: [Warning-file-not-found] Invalid file link: '~/concepts/build-and-test/deep-links.md'.
Line 25, Column 57: [Suggestion-preserve-view-not-set] Did you mean to link to a specific version? It's usually better not to specify a version, so the link always goes to the canonical version. If you really need to link to a specific version, add &preserve-view=true to the URL: /javascript/api/overview/msteams-client?view=msteams-client-js-latest. Otherwise, remove the view parameter.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit 1d91adb:
:warning: Validation status: warnings

File
Status
Preview URL
Details

msteams-platform/TOC.yml
:warning:Warning
View
Details

msteams-platform/tabs/design/tabs.md
:warning:Warning
View
Details

msteams-platform/whats-new.md
:warning:Warning
View
Details

msteams-platform/tabs/how-to/create-tab-pages/content-page.md
:warning:Warning
View
Details

msteams-platform/samples/integrating-web-apps.md
:warning:Warning
View
Details

msteams-platform/resources/bot-v3/bots-with-tabs.md
:warning:Warning
View
Details

msteams-platform/tabs/how-to/access-teams-context.md
:warning:Warning
View
Details

msteams-platform/concepts/build-and-test/deeplinks.md
:white_check_mark:Succeeded
View

msteams-platform/TOC.yml

Line 70, Column 11: [Warning-file-not-found] Invalid file link: 'concepts/build-and-test/deep-links.md'.

msteams-platform/tabs/design/tabs.md

Line 137, Column 70: [Warning-file-not-found] Invalid file link: '../../concepts/build-and-test/deep-links.md'.
Line 145, Column 1: [Warning-duplicate-alt-text] Alt text 'Illustration showing what to do with tab navigation design.' is duplicated. Within an article, alt text must be unique.
Line 153, Column 1: [Warning-duplicate-alt-text] Alt text 'Illustration showing what not to do with tab navigation design.' is duplicated. Within an article, alt text must be unique.
Line 166, Column 1: [Warning-duplicate-alt-text] Alt text 'Illustration showing what to do with tab navigation design.' is duplicated. Within an article, alt text must be unique.
Line 174, Column 1: [Warning-duplicate-alt-text] Alt text 'Illustration showing what not to do with tab navigation design.' is duplicated. Within an article, alt text must be unique.

msteams-platform/whats-new.md

Line 62, Column 97: [Warning-file-not-found] Invalid file link: 'concepts/build-and-test/deep-links.md'.
Line 66, Column 80: [Warning-file-not-found] Invalid file link: 'concepts/build-and-test/deep-links.md'.

msteams-platform/tabs/how-to/create-tab-pages/content-page.md

Line 53, Column 153: [Warning-file-not-found] Invalid file link: '~/concepts/build-and-test/deep-links.md'.
Line 25, Column 57: [Suggestion-preserve-view-not-set] Did you mean to link to a specific version? It's usually better not to specify a version, so the link always goes to the canonical version. If you really need to link to a specific version, add &preserve-view=true to the URL: /javascript/api/overview/msteams-client?view=msteams-client-js-latest. Otherwise, remove the view parameter.

msteams-platform/samples/integrating-web-apps.md

Line 68, Column 264: [Warning-file-not-found] Invalid file link: '../concepts/build-and-test/deep-links.md'.
Line 94, Column 61: [Warning-file-not-found] Invalid file link: '../concepts/build-and-test/deep-links.md'.

msteams-platform/resources/bot-v3/bots-with-tabs.md

Line 25, Column 332: [Warning-file-not-found] Invalid file link: '~/concepts/build-and-test/deep-links.md'.

msteams-platform/tabs/how-to/access-teams-context.md

Line 37, Column 56: [Warning-file-not-found] Invalid file link: '~/concepts/build-and-test/deep-links.md'.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Closing the PR


ScrollTop Feature added for ToDo - application with new Branch

Avinash,
Created a new PR with new branch, accepted incoming changes then added the scrollTop css which are conflicted earlier.
Now from my side it labels are Able to merge.
Adding screenshot for your references. Kindly approve my PR.

Thank you for your contribution !


Update NAT AMIS to address CloudFormation Resource Errors

High-level description
StackStatus changed unexpectedly to: ROLLBACK_IN_PROGRESS - Resource unavailability issue
was observed due to resource unavailability of the NAT AMI. The error message in the console had this errror
Your requested instance type (m3.medium) is not supported in your requested Availability Zone (us-west-2d). Please retry your request by not specifying an Availability Zone or choosing us-west-2c, us-west-2b, us-west-2a. (Service: AmazonEC2; Status Code: 400; Error Code: Unsupported; Request ID: 11bba17d-87a4-4e7c-a0b1-3d3c09257a4a)

Attempting to resolve this issue by upgrading the NAT AMI provided by Amazon to the latest version (https://aws.amazon.com/amazon-linux-ami/2018.03-release-notes/)

https://jira.mesosphere.com/browse/DCOS-18825

@mesosphere-mergebot label ready for review


Fixed #25594 -- Propagated validators from model to form fields

I'll revisit the PR once someone confirms the approach taken in the PR is viable.

@claudep, seems like nobody has confirmed, would you like to poke people to check this PR?

@claudep, seems like nobody has confirmed, would you like to poke people to check this PR?

maybe @felixxm is the person

Is this PR still relevant to remain open?

I'm doing some PR housekeeping. I'll be closing this since I believe that the diff is too outdated to review it properly.
@claudep If you still would like to have this reviewed, could you please rebase onto main and ping for me to re-open? It would also help if you could add a small description about the goal of the changes. Thanks!


Add new OpenGTS protocol for Android mendhak/gpslogger client

I created an additional one:

because t55 is already pretty bloated with various variants
because mendhak/gpslogger does not terminate the message with a newline, thus no seperator
because I prefer udp over tcp/http

No need to merge, this is just for information. I can understand if you would like to keep protocol inflation down...

Do you have any links to the protocol documentation? I'm thinking to implement support for this format in T55 decoder.

This is the implementation of the OpenGTS protocol in gpslogger:
https://github.com/mendhak/gpslogger/blob/master/gpslogger/src/main/java/com/mendhak/gpslogger/senders/opengts/OpenGTSManager.java
For the specification see the second format in the following comment from src/org/opengts/servers/template/TrackClientPacketHandler.java from the opengts software:
// ------------------------------------------------------------------------
// This data parsing template contains *examples* of 2 different ASCII data formats:
//
// Format # 1: (see "parseInsertRecord_ASCII_01")
//   <MobileID>,<YYYY/MM/DD>,<HH:MM:SS>,<Latitude>,<Longitude>,<Speed>,<Heading>
//
// Format # 2: (see "parseInsertRecord_ASCII_02")
//   <AccountID>/<DeviceID>/$GPRMC,025423.494,A,3709.0642,N,14207.8315,W,0.094824,108.52,200505,,*12
//   /<MobileID>/$GPRMC,025423.494,A,3709.0642,N,14207.8315,W,0.094824,108.52,200505,,*12
//   <MobileID>// $GPRMC,025423.494,A,3709.0642,N,14207.8315,W,0.094824,108.52,200505,,*12
//   <MobileID>/_mid_/$GPRMC,025423.494,A,3709.0642,N,14207.8315,W,0.094824,108.52,200505,,*12
//
// Format # 3: (see "parseInsertRecord_ASCII_03")
//   <Seq>,<Code>,<MobileID>,<Format>,<YYYYMMDD>,<HHMMSS>,<GPSValid>,<HDOP>,<Lat>,<Lon>,<Heading>,<Speed>,<Alt>
//
// Format # 9: (see "parseInsertRecord_RTProps")
//   mid=<MobileID> ts=<EpochTS> code=<EventCode> gps=<Lat>/<Lat> kph=<Speed> dir=<Heading> odom=<OdomKM>
//
// Format #11: (see "parseInsertRecord_Device_1")
//   $<EventCode>,<MobileID>,<HHMMSS>,<GPSValid>,<NMEALat>,<N|S>,<NMEALon>,<E|W>,<SpeedKnots>,<Heading>,<DDMMYY>
//
// These are only *examples* of an ASCII encoded data protocol.  Since this 'template'
// cannot anticipate every possible ASCII/Binary protocol that may be encounted, this
// module should only be used as an *example* of how a Device Communication Server might
// be implemented.  The implementation of a Device Communication Server for your chosen
// Device may take a signigicant and substantial amount of programming work to accomplish,
// depending on the Device protocol.

I've added support into T55 decoder. Can you please verify if it works.

Hmmm, the ProtocolDecoder tries to send an acknowledgement to the client even for an incoming UDP message, so I get a NotYetConnectedException.

Fixed the problem.

Tested, works fine!


Since WINE-8.x, loading ReShade makes WINE crash with "Assertion failed: !csw->is32" error

UPDATE: DXVK is to blame https://github.com/doitsujin/dxvk/issues/3677#issuecomment-1742049453
EDIT: I've edited the issue to focus on ReShade, the issue with the addon will be covered in a future issue
Loading a game with ReShade's dll too causes WINE to crash with a weird error:
Assertion failed: !csw->is32, file /home/builder/build_wine/wine/dlls/dbghelp/cpu_x86_64.c, line 650
System information

GPU: Nvidia GTX 1050TI
Driver: 535.113.01
Wine version: 7.20 works with DXVK-2.3, 8.x works only with DXVK-2.2
DXVK version: 2.3
Pop!_Os 22.04

Log files

Proton.log

Just to make sure, did you run winetricks d3dcompiler_47 (or get d3dcompiler_47.dll from other game and put it next to bf4.exe) on your wine prefix? ReShade iirc requires native d3dcompiler_47.dll to work.

Just to make sure, did you run winetricks d3dcompiler_47 (or get d3dcompiler_47.dll from other game and put it next to bf4.exe) on your wine prefix? ReShade iirc requires native d3dcompiler_47.dll to work.

Yes, I have native d3dcompiler_47 in system32 and syswow64, otherwise with wine 7.20 it wouldn't work.
There's a little problem by the way, I've been having this weird problem since half a month.
Sometimes wine crashes with the error Assertion failed: !csw->is32, file /home/builder/build_wine/wine/dlls/dbghelp/cpu_x86_64.c, line 650

I also have similar issues with some anime game but let me check if our situation is really similar:

Is removing dxvk-cache file before launching the game fix the problem temporarily?
When using older dxvk version release (for example: DXVK 2.2), is it has the exact same error/problem?

* Is removing `dxvk-cache` file before launching the game fix the problem temporarily?

YES, It did fix the problem once, I've also tried with deleting nvidia shader cache, I tried once and it worked.

* When using older dxvk version release (for example: DXVK 2.2), is it has the exact same error/problem?

I don't remember if I've tried, but I will try using DXVK 2.2 and report back in less than one hour

Bisecting the problem leads to this:
428ca9416d60cf7025ae97da88f44eabc2ec0aa2 is the first bad commit
commit 428ca9416d60cf7025ae97da88f44eabc2ec0aa2
Author: Joshua Ashton<EMAIL_ADDRESS>Date:   Wed Aug 23 14:50:42 2023 +0100

    [d3d11] Implement synchronization on keyed mutexes

    Co-authored-by: Paul Gofman<EMAIL_ADDRESS>
 src/d3d11/d3d11_context_imm.h   |  1 +
 src/d3d11/d3d11_initializer.cpp | 12 ++++++++++++
 src/d3d11/d3d11_initializer.h   |  2 ++
 src/d3d11/d3d11_resource.cpp    | 36 +++++++++++++++++++++++++++++++-----
 src/d3d11/d3d11_resource.h      |  2 ++
 5 files changed, 48 insertions(+), 5 deletions(-)

Wow good work, I never investigate this far into the issue, it seems that we have the exact same issue (although on different game).. I just switched back to DXVK 2.2, continue using ReShade with REST plugin and pretend this never happen, hehe.. Thanks for reporting this, I wish the issue will be resolved soon :pray:

Wow good work, I never investigate this far into the issue, it seems that we have the exact same issue (although on different game).. I just switched back to DXVK 2.2, continue using ReShade with REST plugin and pretend this never happen, hehe.. Thanks for reporting this, I wish the issue will be resolved soon 🙏

Latest REST versions don't work though... plus, going back to DXVK-2.2 is simply not so acceptable, the drawbacks compared to v2.3 are simply too many

UPDATE: DXVK is to blame #3677 (comment) also relevant PR
EDIT: I've edited the issue to focus on ReShade, the issue with the addon will be covered in a future issue
Loading a game with ReShade's dll too causes WINE to crash with a weird error: Assertion failed: !csw->is32, file /home/builder/build_wine/wine/dlls/dbghelp/cpu_x86_64.c, line 650
System information
* GPU: Nvidia GTX 1050TI

* Driver: 535.113.01

* Wine version: 7.20 works with DXVK-2.3, 8.x works only with DXVK-2.2

* DXVK version: 2.3

* Pop!_Os 22.04

Log files
* [Proton.log](https://github.com/doitsujin/dxvk/files/12764023/steam-heroic-0.log)

Can you retest with latest master? A reshade crash regression was indeed found and fixed since 2.3.
You can download a pre compiled build here https://github.com/doitsujin/dxvk/actions/runs/6240574600

Can you retest with latest master? A reshade crash regression was indeed found and fixed since 2.3. You can download a pre compiled build here https://github.com/doitsujin/dxvk/actions/runs/6240574600

That is a nice surprise! It works... for now.
Let's see if it didn't break other stuff, testing now, will update the comment.
Also @Stereo-3D (sorry for another tag) try this!

Can you retest with latest master? A reshade crash regression was indeed found and fixed since 2.3. You can download a pre compiled build here https://github.com/doitsujin/dxvk/actions/runs/6240574600

With DXVK-2.3 I also had this weird error with Call of Duty: Black Ops 3
Assertion failed: !status && "vkDestroyBufferView", file ../dlls/winevulkan/loader_thunks.c, line 3226
something that with DXVK-2.2 wasn't happening, I'll try to bisect that too.

Can you retest with latest master? A reshade crash regression was indeed found and fixed since 2.3. You can download a pre compiled build here https://github.com/doitsujin/dxvk/actions/runs/6240574600

Yes, I can confirm that this pre compiled build is working with ReShade 5.9.2 (+REST addon) loaded on anime game I'm playing! Thank you very much @Blisto91 and @gabriele2000 :pray:

Yes, I can confirm that this pre compiled build is working with ReShade 5.9.2 (+REST addon) loaded on anime game I'm playing! Thank you very much @Blisto91 and @gabriele2000 🙏

Hell yeah!

Good to hear.
@gabriele2000 Please open news issues for anything else you think is a dxvk bug.

Good to hear.
@gabriele2000 Please open news issues for anything else you think is a dxvk bug.

Of course, I will reference the relevant comment in a new issue once I succesfully bisect the relevant commit... plus I have to be certain that it's a DXVK bug since sometimes it's a random error.

@gabriele2000 Was all good for this particular issue?

@gabriele2000 Was all good for this particular issue?

Upon further testing I'm not seeing any problem since when I claimed that the problem was fixed.
IMPORTANT
I want to write something that will be useful to everyone.
Since Reshade 5.9 something tells me that the particular error message Assertion failed: !csw->is32, file /home/builder/build_wine/wine/dlls/dbghelp/cpu_x86_64.c, line 650 is spitted thanks to a quirk of ReShade.
I've reason to believe this, since (it happens even with the commit that fixes the issue) if a game can't load ReShade properly without using a native d3d_compiler47 dll.
As you might know, ReShade needed the native dll (in the past, before WINE-8.10 or something, now I guess it doesn't anymore but there are games that don't accept that, causing the issue.
Basically ReShade (or the hooking process for that particular game?) does something "illegal" and triggers a check in WINE, introduced years ago.
If it happens, place a native d3d_compiler47.dll next to the game's executable then:

winecfg
In the library tab, add a custom rule for d3d_compiler47.dll as native, builtin
Click on "OK" or "Apply" then "OK"

@K0bin Close it as "fixed", I forgot to close the issue since it's fixed for good starting from that commit.

Doesn't matter anyway.