Unexpected Flag Output: Flag values returning as lists

Version Outputs:
[11:27:20 INFO]: This server is running Paper version git-Paper-196 (MC: 1.14.4) (Implementing API version 1.14.4-R0.1-SNAPSHOT)
[11:27:20 INFO]: Checking version, please wait...
[11:27:21 INFO]: Previous version: git-Paper-192 (MC: 1.14.4)
[11:27:21 INFO]: You are running the latest version
[11:27:22 INFO]: Denizen version 1.1.1-SNAPSHOT (build 4201-DEV)
[11:27:22 INFO]: Author: The DenizenScript Team

A link to a paste of a script demonstrating the issue: https://one.denizenscript.com/paste/58678
The issue is:
after flagging a player with a flag such as flag <player> thing:1, the output of the <player.flag[thing]> tag returns li@1

Please pay attention to the public changelog.
Also that debug isn't related to the issue you describe.


Can't login

I insert all fields correctly but the app says that I'm not a premium user in Spotify but I have an Individual Premium Plan.

Known issue. I'm trying to rebuild the app but the core things has changed a lot and it's hard to keep good.

is there progress with this or any workaround?

@BobbyESP any progress yet? Problem still seems to occur.

Yeah, and it will stay. The app needs a rework. I think I'm gonna archive the repo because it really needs work

Yeah, and it will stay. The app needs a rework. I think I'm gonna archive the repo because it really needs work

I'd be very much open to at least create a workaround or patch, if you could lmk how to setup the development environment up.

Yup, I found the same - currently looking at what could be done.

I took at look at the fork, and it looks like a baseless one. There were no commits made by iTaysonLab, it was simply a fork of librespot-java without any changes made, at a old commit.
I switched the dependency to use the latest official librespot-java implementation. Will update if all goes well.

The solution is to remake the app from the ground and scratch with the original librespot-java lib

I took at look at the fork, and it looks like a baseless one. There were no commits made by iTaysonLab, it was simply a fork of librespot-java without any changes made, at a old commit.
I switched the dependency to use the latest official librespot-java implementation. Will update if all goes well.

I see. I tried to update the lib also, but the compiler gives 800000000 errors and it brokes all (missing classes and proto files changed, etc...)

I took at look at the fork, and it looks like a baseless one. There were no commits made by iTaysonLab, it was simply a fork of librespot-java without any changes made, at a old commit.
I switched the dependency to use the latest official librespot-java implementation. Will update if all goes well.

I see. I tried to update the lib also, but the compiler gives 800000000 errors and it brokes all (missing classes and proto files changed, etc...)

My assumption was incorrect, he did indeed make edits.
https://github.com/iTaysonLab/librespot-java/commits/dev-jsp

Oh and, I'm not a professional JVM dev or anything, so I barely have any clue as to what I'm doing haha... just trying to pick things up as we go.

Hahah okay, don't worry, but yeah, this app is kind of special. I can do my own fork and fix this but I'm focused in Spowlo right now

That'd be great if you could that whenever you're free :)

Could you at least tell me what the last functional version of Jetispot was?

Hahah okay, don't worry, but yeah, this app is kind of special. I can do my own fork and fix this but I'm focused in Spowlo right now

That'd be great if you could that whenever you're free :)

Okayy, will try!

Could you at least tell me what the last functional version of Jetispot was?

The latest published was. Spotify changed its auth flow and all went broken

Could you at least tell me what the last functional version of Jetispot was?

The latest published was. Spotify changed its auth flow and all went broken

Ah, I see. Thought it was an issue with a bug in the library or something at some commit.

Upstream Jetispot just got a fix by updating librespot-java I believe. Could the same thing be done with this fork to make it work?

My build already has it fixed, but I haven't uploaded it, sorry. Maybe I will check later for the build and upload it here, but I'm very busy rn 😩💀

That's awesome! Please consider pushing & creating a release ASAP, would be greatly appreciated :)

Fixed

Sorry but the problem is still there and still can't login. Its either says wrong Usernam or password or 2~3 sec after pressing sign in, app will close itself.

Yes, I have also been prompted for incorrect username or password, but I am sure they are correct.

Doesn't work for me currently.


Avoid calling clusterMap.getReplicas() in VCR mode.

Codecov Report

Merging #1152 into master will decrease coverage by 0.03%.
The diff coverage is 60%.

@@             Coverage Diff              @@
##             master    #1152      +/-   ##
============================================
- Coverage     69.41%   69.38%   -0.04%
+ Complexity     5215     5207       -8
============================================
  Files           411      411
  Lines         32232    32236       +4
  Branches       4109     4111       +2
============================================
- Hits          22375    22368       -7
- Misses         8741     8744       +3
- Partials       1116     1124       +8

Impacted Files
Coverage Δ
Complexity Δ

...m.github.ambry.replication/ReplicationManager.java
90.62% <100%> (+0.3%)
4 <4> (ø)
:arrow_down:

...ava/com.github.ambry.cloud/CloudBackupManager.java
83.33% <100%> (ø)
3 <0> (ø)
:arrow_down:

...om.github.ambry.replication/ReplicationEngine.java
52.86% <42.85%> (-0.71%)
20 <0> (ø)

...in/java/com.github.ambry.clustermap/Partition.java
77.01% <0%> (-3.45%)
25% <0%> (-1%)

.../main/java/com.github.ambry.store/ScanResults.java
81.25% <0%> (-1.57%)
16% <0%> (-1%)

...in/java/com.github.ambry.store/BlobStoreStats.java
70.92% <0%> (-1.45%)
103% <0%> (-2%)

...b.ambry.network/BlockingChannelConnectionPool.java
69.56% <0%> (-0.87%)
8% <0%> (-1%)

...in/java/com.github.ambry.network/SocketServer.java
83.6% <0%> (-0.41%)
15% <0%> (ø)

...src/main/java/com.github.ambry.commons/BlobId.java
93.18% <0%> (-0.36%)
71% <0%> (-1%)

...java/com.github.ambry.network/SSLTransmission.java
69.42% <0%> (-0.32%)
68% <0%> (-1%)

... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be2f7a8...2f11db9. Read the comment docs.


How to use order by id

Hi @glu0516,
could you provide a little more context?
What type of database do you use?

MySQL Database
sql：SELECT * from table order by id desc limit 10 OFFSET 10

Thank you. I see


only publish sha512, skip md5+sha1+sha256

ASF does not need md5 nor sha1 nor sha256: only .asc and .sha512

Homebrew packager will need the sha256, so I'd rather keep them instead of having to regenerate them at a later phase.

Homebrew packager will need the sha256, so I'd rather keep them instead of having to regenerate them at a later phase.
See https://github.com/mvndaemon/homebrew-mvnd/blob/master/Formula/mvnd.rb

@hboutemy no problem with that ?

yes, sha256 is ok regarding ASF policy, then ok for me


Thread Safety

Hey,
Stoplight with MemoryStore is not threadsafe.
It would be awsome if stoplight would be usable in threaded ruby code.
The only shared state between Stoplights seems to be the class variables in Stoplight::Light and the DataStore.

I would like Stoplight to be thread safe, but I don't have a lot of experience with thread safety in Ruby. If I understand you correctly, we would have to do at least two things to make Stoplight thread safe:

Do something with these class variables in Stoplight::Light.

Do something with the in-memory data store.

Is that correct?

First off, a bit of clarification why we should care about threadsafety. Its not only about writing concurrent code ourselfs but another important usecase is using threaded libraries or frameworks for example just using Rails in a threaded server, like Puma or Phusion Passenger with PassengerConcurrencyModel thread.
class SomeController < ApplicationController
  def serve
    light = Stoplight('example') do
      # some interaction with active record
      # some interaction with a web service
    end
    light.run
  end
end

Regarding the class vars we should use a thread safe array for default_notifiers for the case that during initialization multiple threads append notifiers.

regarding the memory store the easiest fix would be to synchronize all methods using a Mutex.
Also the failures array for a light is exposed and mutated in record_failure, but this can also be easily mitigated. There is probably room for performance improvements over this simple approach.

I'll give it a shot during the next week and come back to you with a suggested implementation.

Ok great! I will be happy to review a pull request. Let me know if I can help.

Any movement on this?

sorry mate havnt found the time yet, this weekend is also pretty stuffed, give me till next friday

No rush.

Did #92 close this, or is there more to do?

think its fine  :thumbsup:

Great, thanks!


fix resume in train.py for ssd

Why do you want to change that line?
We should resume trainer because it contains the number of proceeded iterations, status of the optimizer and learning rate.


Add support for ruff format in python.lua

Adding support for ruff's formatting module. It's 99.9% black compliant and runs orders of magnitude faster.

@mhartington, hope this meets the requirements for merging, happy to make any changes if required. Have tested locally with my nvim install and it's working nicely :)

Thank you :)


New version: Mozilla.Firefox.DeveloperEdition.sc version 133.0 (133.0b1)

Created by 🥟 Dumplings.
Microsoft Reviewers: Open in CodeFlow

@wingetbot run

@wingetbot run


Support for storing and retrieving data off-chain and on-chain.

Different parachains may be dependent on data external to polkadot. Example: A fantasy football app rewards users depending on the real scores during a football match. Every user locks in their estimate of total score of each team on the parachain in the form of an on-chain bid. The rewarding mechanism needs live scores of the game while it transfers tokens to the winning bidders.
If Capi could support interacting with a football score transmitting extrinsic/oracles, then it would be wonderful and handy for the devs to code this dApp.
import * as C from "capi";

// NOTE: psuedo code as SomeOraclePallet / SomeOracleEntry is yet to be finalized
const retrievedData = await C.readEntry(
  C.config("wss://some.chain.io", 0),
  "SomeExtrinsicPallet",
  "SomeExtrinsicEntry",
   dataId);
).read();

let winningBid = chooseWinningBid(bids, retrievedData.teamOneScore, retrievedData.teamTwoScore)

Outside of Capi's scope––would require some on-chain program specifics + oracle interaction.


Error in Unity WebGL build

Hey there,
First of all, thanks for this awesome library.
I'm importing the binary unity (not unity-full, version 0.9.0-beta1) and building for the web and here's the error that I get:
Attempting to call method 'MsgPack.Serialization.SerializationContext::GetSerializer' for which no ahead of time (AOT) code was generated.
Rethrow as TargetInvocationException: Exception has been thrown by the target of an invocation.

Is this error expected? I see that @tametick had a similar issue, but I'm not sure if it's the same.
Cheers!

Sorry for delay. It should be same (AOT issue) which is caused by missing MessagePackSerialiazer.PrepareType<T>() call for required types...
Please try to call PrepareType<T> for you want to (de)serialize and its dependencies.


Meeting 2: Problem Identification Converging Stage

Agenda: it is a meeting regarding our group status and the converging stage of problem Identification

Would like to stay in this group and contribute

Join other group( if yes, why)

Discussing and finalizing the converging stage of problem identification

Meeting time: Tomorrow at 11:00 Am EST time. Google link will be shared

[ ]  addition to the agenda:

We need to work on the other deliverables for this milestone.
finalize READme, communication.md and pull the other documents to this repo.
choosing a name for our group?

Meeting Minutes:

Agreed to stay as a team and keep up the great work. xD

Discussed the ideas proposed and decided to further expand on two of the topics proposed and meet again on Sunday to make an informed decision;

Media Analysis
Political conflicts' effect on Education

We need to schedule a check-in with Evan to check whether the methods we want to choose if we decide to go with media analysis are OK.


phpPackages.maxminddb: Init at 1.5.0

Motivation for this change
Speeds up Matomo when used
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Notify maintainers
cc @

@GrahamcOfBorg build phpPackages.maxminddb

Speeds up Matomo when used

Could you possibly share some documentation or a blog post explaining this comment? A quick search mostly returns results on geoip stuff. Mostly curious because I have users complain about a slow matomo instance my co-worker manages :smile:

@aanderse So what's needed is the Geoip 2 database somewhere (see also my #73578 PR for which I have a module ready). Then, (this is probably the most important part), enable the Geoip 2 plugin in Matomo. If you load the PHP module (extension=${pkgs.phpPackages.maxminddb}/lib/php/extensions/maxminddb.so), Matomo says something like this in the Geolocation config:

This sounds like it would fix #64759

Ah on NixOs, the GeoLite files need to be in /var/lib/matomo/misc btw


System.OverflowException at Octokit.PocoJsonSerializerStrategy.DeserializeObject exceptions in dotnet-status

Starting on 6/4, we are seeing a lot of exceptions in the logs.
App insights query

Release Note Category

[ ] Feature changes/additions
[ ] Bug fixes
[ ] Internal Infrastructure Improvements

Release Note Description

See discussion here: https://teams.microsoft.com/l/message/19:276707cdcf5d431caaa8792b29bd832d@thread.skype/1717778544799?tenantId=72f988bf-86f1-41af-91ab-2d7cd011db47&groupId=147df318-61de-4f04-8f7b-ecd328c256bb&parentMessageId=1717778544799&teamName=.NET Eng Services&channelName=FR Internal&createdTime=1717778544799

there is a version with this fixed.
The fixed for this are rolling out tomorrow: https://github.com/dotnet/dnceng/pull/3043

this was already fixed. closing


Support tsconfig.json

Since projects can specify their compiler options and included files via tsconfig.json, it would be great if typedoc would support specifying generating documentation by passing it a tsconfig.json. I could see the following as the command-line invocation:
$ typedoc --mode modules --exclude **/tests/** --excludeNotExported --out docs tsconfig.json

In my mind, this would get the list of project files from tsconfig.json's files property, apply the exclude pattern to those files, get the compiler options from the compilerOptions property, and then generate the docs.

Hi Bryan, thank you for sharing this. I think this is a good idea, maybe we could even append the documentation parameters to tsconfig.json so they can be easily shared with others.

+1

:+1:

+1

+1

:+1:

:+1:

+1

+1

+1

+1

+1

+1

+1

+1
Any news on this ?

Yeah, typedoc is pretty much worthless for me without this. Also ships with moldy old typescript version ( 1.6 ) and can't find how to get it to use different version.

+1

Guys, please!
When you are intressted in this topic, please click on Subscribe.
If you want to to say that this is a nice feature just click on the smiley and press your reaction. Github added that for a reason. One of the reason is that the +1 is annoying for all that subscribed or watch a issue/repo.
Thanks!

But reactions don't make me a participant and when watching a repo I want to me notified in a different way for certain topics.

Then click the subscribe button in the column on the right

There is only an Unsubscribe Button.

It's an unsubscribe button only because you're already subscribed...

Yes and it was already an Unsubscribe when I entered this topic. But now I see it in my Participating block in my Notifications.

Seems like its supported now. With typedoc --help you get

--tsconfig                          Specify a js option file that should be loaded. If not specified TypeDoc will look for 'typedoc.js' in the current directory.

Thanks @TobiaszCudnik
Feel free to open a new issue if there's any problems that come up 😄


Base href path for ios  (cordova)

images not loading after app build.
this task on android is working .

Hi @ghatul,
with such limited information on your issue, we are not able to help you.


swap devnet magic bytes around

Prevents testnet and devnet messages from being confused and helps differentiate which network messages should refer to.

This ^^^^ is probably a good idea, though I don't think it has anything to do with this specific PR (there is no devnet at all in mininode.py) and it should be fixed independently imo.


When the user tries to open more than 200 mnemonics the request fails

Request Template Witsml Explorer
Fixes #365
Description
I created a GetLargeLogData Post endpoint in the API, on the client side if the URI is too long it will use this endpoint otherwise the already existing one.
Type of change

[x] Bugfix
[ ] New feature (non-breaking change which adds functionality)
[x] Enhancement of existing functionality
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Impacted Areas in Application
CurveValuesView, logObjectService
Checklist:

[x] PR is related to an issue
[ ] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have used descriptive naming on components, functions and variables to avoid additional explanatory comments in the code
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings

Further comments
Do we need to keep the original endpoint and make a request like the current implementation, or can we remove the old endpoint and use only the Post implementation?

Works fine here, I left a comment on the GET/POST switch, maybe should use POST in all cases to simplify the codebase? What do you think?

I think this should be considered, but it is out of scope for this PR. I think the PR should be merged once the conflict is solved and then we can make a separate issue for the get/post if necessary.


DATAJDBC-431 - ReadOnlyProperty now gets properly handled.

The problem was that the SqlGenerator honoured the annotation but they were included as query parameters and therefore automatically added back again.
Also simplified the relevant filter in the SqlGenerator.
Issue: https://jira.spring.io/browse/DATAJDBC-431

That's merged, squashed, and backported now.


Bug: "page isn't redirecting properly" after refresh on /boot/

If you navigate to nativeplanet.local/boot directly, you get a screen saying the page isn't redirecting properly.

this is an issue with bundling embedded static assets and vite; i think it can come up in other ways though i am not much of an authority on vite routers. i recall poking at this a bit when goseg was under early development though i think it's worth revisiting as things have stabilized; @nallux-dozryl you definitely know this stuff better than me, though i think we also need to do something with the http mux in goseg to make 404s failover to the root path or something

the issue stems from dynamic paths being built into a static html bundle. The html for said page doesn't exist (but redirecting works using svelte's goto()).
The way we're serving the frontend:
built with static adapter -> move build dir to goseg/web -> serve with go
There's definitely room for improvement in this department. Though I haven't looked into it. We could possibly handle the paths manually in go but I'd prefer a solution from the svelte side

Makes sense


Explore using dashes with date ranges

For example, if someone is going to be absent from August 1st until August 8th, make it possible to add these dates with "Aug 1-8 (Some Comment)" instead of "Aug 1 Aug 8 (Some Comment)"

Satisfied with new slash command. :)


Add boolean env override rule

I did this so that users could override their feature toggles at runtime based
on the environment the application is running in. I also added a Provided
Rules Reference to the README.md to aid people in understand what rules exist
and how they can use them.
Note: This includes the changes from pull request https://github.com/codebreakdown/togls/pull/9  as it is a dependency of this pull request.

Looks good


Changed default notebook code indenting.

In practical1 there seems to be a mismatch between the default code indenting setting on the VM notebooks on AWS and the indenting used in the code (making several of the code snippets appear in red). The code uses two spaces and I think the default is set to four spaces, therefore I added some javascript in practical0 to set the notebook default indenting on the VMs to 2 spaces.

VERY COOL! Thanks!


[Decision Issue] User Experience for RPM/DEB distributions with default admin credential changes

Is your feature request related to a problem?
It was recently brought to our attention that the way we are expecting the initial admin password to be set (via env. variable) may be problematic for RPM/DEB distributions. As a refresher, we are expecting the initial admin password to be set via OPENSEARCH_INITIAL_ADMIN_PASSWORD variable on install for example:
sudo env OPENSEARCH_INITIAL_ADMIN_PASSWORD=myStrongPassword123! dpkg -i opensearch.deb (deb)
sudo env OPENSEARCH_INITIAL_ADMIN_PASSWORD=myStrongPassword123! yum install opensearch.rpm (rpm)
@peterzhuamazon brought up a few issues with this approach:

Users may have sudo access to yum, but but not sudo access to env (this would make them unable to run opensearch)
Users may not have experience with the command line and may instead be using GUI's to install (they would not be able to pass in their initial admin password)
Install demo configuration is run on the install, not on the start of the service. This means that in case of no/weak password, they would not know about this issue until they try to start the service, at which point the script has already ran and the only way out would be to uninstall/re-install - bad UX

Possible solutions (ranked from low to high effort):

Simply print out an error message alerting user to this change
Early termination of installation script when we detect that the env variable is not present
Inspired by another similar situation run into by the build team, have an interactive prompt which allows user to input initial admin password, we would skip this prompt if the user already has set the necessary env. variable
Change the spec files to not run install demo configuration until they start the service (instead of on installation) - this would be significant work, and maybe more of a long term project which requires expertise of build team

A bunch of though from my perspective.
About being allowed to pass environment variables with sudo

Users may have sudo access to yum, but but not sudo access to env (this would make them unable to run opensearch)

I would expect users allowed to run yum as root to be basically authorized to run anything and be considered trusted users.  I would also not expect untrusted users to be allowed to run any command with random environment variables (sudoers(5) describe how the running environment of run processes can be managed), env being probably one of the worst ideas that come to mind (sudo env LD_PRELOAD=/path/to/my/evil/library.so true) :upside_down_face:
So I would not consider the above an issue… but this lead to the next point:
About passing environment variables at install time / on first start
I really don't like this.  It feels fragile, it's not something usual when installing a package.  For less advanced users, it makes things harder (and as stated above, GUI "wrappers" may lack options to do so).
I would not consider this as a viable option (neither at install time nor at first start).
About stopping with an error at install time
I don't like this neither.    Installation should finish successfully.
About stopping with an error at first start
This feels acceptable.  If a configuration file is missing or absent, a service will not start and display an appropriate error.  If a required password was not provided, an error message telling how it must be seeded is fine.  Interactively prompting the user can be a pain for configuration management tools, so I would not go that way.
Service managers generally have a pre-start section to handle this (e.g. systemd has ExecStartPre=), and check service requirements.
The secret can be read from a configuration file (allowing a configuration management system to install the package, setup the config — including the password — and start the service).  Passing the password in the environment can also be an option here (but it means the clear-text secret is available from the context of the application, or from /proc if user can access files there, which concerns me quite a bit).
Avoiding interruption on first start
If a password is required but not available, generating one and printing it to stdout make sense if the user has to change it on first connection.
Locating it can be a pain if there is a lot of output however, which may make this impractical.
About the demo certificates

Change the spec files to not run install demo configuration until they start the service (instead of on installation) - this would be significant work, and maybe more of a long term project which requires expertise of build team

:100:
This should definitely be a separate action: installing the package should not generate them, starting the service should not generate them.
Also, if the user wants demo certificates and run a utility that configure them, it must generate the demo CA / service cert+key and admin user cert+key so that all demos do not share the same admin credentials by default.
If these files are missing, the service should refuse to start and says that it could not find the server certificate and key (indicating where they are looked for), and tell that demo PKI can be generated using the command described above.
Summary
IMHO, the least astonishment is provided by a plain configuration file containing the required secrets.  The package can install a sample configuration file with commented examples so that the user has to tune the config before being able to start the service for the first time (e.g. the pre-start command check that an admin user has been properly configured).

[Triage] Hi @derek-ho thank you for filing this issue. This seems well detailed and it is great to see you getting input from various people! Going to mark as triaged since the issue can be closed when a decision is reached etc.

Path Forward for RPM/DEB
Decisions to be made:
Should we keep install demo script inside the spec or postinstall? OR make it its own thing?

What are the benefits of moving the script outside?

Users do not have to re-download OpenSearch if they failed it. If we keep it as is, after failing, the user needs to redownload:

Steps for DEB:sudo env OPENSEARCH_INITIAL_ADMIN_PASSWORD=myStrongPassword123! dpkg -i opensearch-2.12.0-linux-arm64.deb

We can add check in preinstall script to verify whether the valid password variable was defined. If not fail it.

Steps for RPM:sudo env OPENSEARCH_INITIAL_ADMIN_PASSWORD=myStrongPassword123! yum install opensearch-2.12.0-linux-x64.rpm

Same as above, we add a check in pre-install section and fail if a valid password is not defined.

What are the cons of moving the script outside?

More significant changes that need to be tested, unsure about 2.12.0 release time frame

Should we improve logs to indicate what the issue is and how to solve it?

Yes, the install scripts should indicate the issue, so it is easier to see that admin credential changes are the cause of new startup errors

DEB postinst script
RPM spec file

Should we support opensearch setup via GUI for people without terminal access? If yes, how?

Out of scope. e.g. GNOME supports creation of rcs which can have env variables defined.

Are we supporting people access to env command?

No, because it is assumed that people with sudo access to yum command should be granted access to env command as well.
If they do not, we are assuming that they can be given access with little concern, based on community feedback: GitHub Issue

Options:
1. Do Nothing:
The status quo is that if users who have access to install package, do not have access to env command, they will not be able to set up demo configuration as >= 2.12 version requires an admin password to be supplied.
Pros:

No change to the current implementation for bundling and installing distributions

Cons:

Users who do not have access to env command will not be able to use demo configuration

2. Modify the install script (DEB) and spec file (RPM) to read the password from a config file
This requires end users to create a config file that contains this admin password value. Further modification is needed to install and spec files to read this value from config file and set it in the environment to be picked up by the demo installation script.
Pros:

Users without sudo access to env command can now pass the password and utilize demo installation script.

Cons:

Storing clear-text passwords in a file is not a great security posture
Requires significant changes to spec and install files

3. Move demo config setup to the opensearch service startup phase
This involves changing the startup process to now have an additional check for install demo configuration as ExecStartPre=. This is a significant change to service startup flow as well as experience and would involve modifying a stable startup process.
Pros:

No need to re-install if installation fails
Organized env variables in env file

Cons:

Plain text password in config
Alters a very stable startup system

4. Update the pre-install script (PROPOSED)
This requires adding an extra check in the pre-install script to check whether the env variable is defined and if so whether the password is valid. (Yes, this will be on top of the weak password validation done by the tool itself). In addition, the script should print clear messages on what can users do next. This change is small, and the installation will quit before the package is installed leaving a clear message for the user that the password needs to be supplied to spin-up a >=2.12 cluster.
Pros:

Able to inform user early on. (No broken installations)
Don’t have to change the startup service setup

Cons:

Messy user experience during setup leading to potential doubts about stability of the package itself
Users probably won’t read doc and lead to decrease in user base
Need to add checks for the presence of env variable and validation check to give the best user experience

Path Forward for RPM/DEB
Decisions to be made:
Should we keep install demo script inside the spec or postinstall? OR make it its own thing?

What are the benefits of moving the script outside?

Users do not have to re-download OpenSearch if they failed it. If we keep it as is, after failing, the user needs to redownload:

Steps for DEB:
sudo env OPENSEARCH_INITIAL_ADMIN_PASSWORD=myStrongPassword123! dpkg -i opensearch-2.12.0-linux-arm64.deb

We can add check in preinstall script to verify whether the valid password variable was defined. If not fail it.

Steps for RPM:
sudo env OPENSEARCH_INITIAL_ADMIN_PASSWORD=myStrongPassword123! yum install opensearch-2.12.0-linux-x64.rpm

Same as above, we add a check in pre-install section and fail if a valid password is not defined.

What are the cons of moving the script outside?

More significant changes that need to be tested, unsure about 2.12.0 release time frame

Should we improve logs to indicate what the issue is and how to solve it?

Yes, the install scripts should indicate the issue, so it is easier to see that admin credential changes are the cause of new startup errors

DEB postinst script
RPM spec file

Should we support opensearch setup via GUI for people without terminal access? If yes, how?

Out of scope. e.g. GNOME supports creation of rcs which can have env variables defined.

Are we supporting people access to env command?

No, because it is assumed that people with sudo access to yum command should be granted access to env command as well.
If they do not, we are assuming that they can be given access with little concern, based on community feedback: GitHub Issue

Options:
1. Do Nothing:
The status quo is that if users who have access to install package, do not have access to env command, they will not be able to set up demo configuration as >= 2.12 version requires an admin password to be supplied.
Pros:

No change to the current implementation for bundling and installing distributions

Cons:

Users who do not have access to env command will not be able to use demo configuration

2. Modify the install script (DEB) and spec file (RPM) to read the password from a config file
This requires end users to create a config file that contains this admin password value. Further modification is needed to install and spec files to read this value from config file and set it in the environment to be picked up by the demo installation script.
Pros:

Users without sudo access to env command can now pass the password and utilize demo installation script.

Cons:

Storing clear-text passwords in a file is not a great security posture
Requires significant changes to spec and install files

3. Move demo config setup to the opensearch service startup phase
This involves changing the startup process to now have an additional check for install demo configuration as ExecStartPre=. This is a significant change to service startup flow as well as experience and would involve modifying a stable startup process.
Pros:

No need to re-install if installation fails
Organized env variables in env file

Cons:

Plain text password in config
Alters a very stable startup system

4. Update the pre-install script (PROPOSED)
This requires adding an extra check in the pre-install script to check whether the env variable is defined and if so whether the password is valid. (Yes, this will be on top of the weak password validation done by the tool itself). In addition, the script should print clear messages on what can users do next. This change is small, and the installation will quit before the package is installed leaving a clear message for the user that the password needs to be supplied to spin-up a >=2.12 cluster.
Pros:

Able to inform user early on. (No broken installations)
Don’t have to change the startup service setup

Cons:

Messy user experience during setup leading to potential doubts about stability of the package itself
Users probably won’t read doc and lead to decrease in user base
Need to add checks for the presence of env variable and validation check to give the best user experience

IMHO we cannot support password validation in the script - although we have regex that we can use, we also have an additional requirements of strength provided by a library: https://github.com/opensearch-project/security/blob/main/src/main/java/org/opensearch/security/dlic/rest/validation/PasswordValidator.java#L103, unless we convert that to a tool (which would be non-trivial), we can only check the existence and regex, but not guarantee that it would pass the password strength requirement overall.

IMHO we cannot support password validation in the script - although we have regex that we can use, we also have an additional requirements of strength provided by a library: https://github.com/opensearch-project/security/blob/main/src/main/java/org/opensearch/security/dlic/rest/validation/PasswordValidator.java#L103, unless we convert that to a tool (which would be non-trivial), we can only check the existence and regex, but not guarantee that it would pass the password strength requirement overall.

Agreed. To keep it uniform, let's only check if the variable is defined as part of pre-install. We can add a log if there are any errors. To add more logging and make it easier for end-users, we can also catch the error, if any, thrown by the demo install script , and print out a message redirecting users to check the install script logs. Note: This approach prereqs the user already has access to read the logs.

Here's the updated proposal number 4:
4. Update the pre-install script (PROPOSED)
This requires adding an extra check in the pre-install script to check whether the env variable is defined. In addition, the script should print clear messages on what can users do next. This change is small, and the installation will quit before the package is installed leaving a clear message for the user that the password needs to be supplied to spin-up a >=2.12 cluster.
In case, if a variable is defined and if it turns out to be weak, then the demo install will fail with -1. We then print out another console log from the post-install script asking users to check install_demo_configuration.log for more information.
Pros:

Able to inform user early on. (No broken installations if no variable is defined)
Able to inform user to check for logs from post-install script if there were any failures.
Don’t have to change the startup service setup

Cons:

Messy user experience during setup leading to potential doubts about stability of the package itself
Users probably won’t read doc and lead to decrease in user base
Need to add checks for the presence of env variable and a postinstall  check to give the best user experience

Implementation

Preinstall fails if no OPENSEARCH_INITIAL_ADMIN_PASSWORD is defined for OpenSearch >= 2.12. A clear message is printed out to let users know that this variable is required. (Package will not be installed)

ERROR: Opensearch 2.12 and later requires the env variable OPENSEARCH_INITIAL_ADMIN_PASSWORD to be defined to setup the opensearch-security demo configuration

Postinstall fails if a weak password is supplied, e.g. 'admin'. A message is printed in the logs to redirect users to the install_demo_configuration.log file to check what went wrong. (Package will be installed and users may have to uninstall the package (or at-least delete the config files))

ERROR: Something went wrong during demo configuration installation. Please see the logs in %{log_dir}/install_demo_configuration.log.

(${log_dir} above for DEB)

Installation will only be successful if OPENSEARCH_INITIAL_ADMIN_PASSWORD is defined and a strong password is supplied as the value.

Tests:

Debian logs
RPM logs

PR: https://github.com/opensearch-project/opensearch-build/pull/4332

Feel free to re-open if any more input required.


GUI blinks badly while populating quickfix from a background function (timer/channel cb)

GUI/CUI will blink frequently while a background function (timer/channel cb) is using caddexpr to append text to quickfix. This issue could be reproduce from a script:

function! TimerBlink(id)
    caddexpr "TIMER: " . a:id
endfunc

let s:id = timer_start(100, 'TimerBlink', {'repeat':300})

copen 10
cexpr ""
wincmd k

tabnew %

key step to reproduce the issue:

open the quickfix window in the default tabpage
open a new tabpage (with quickfix window closed by default)

important:
I am experimenting async-build with job/channel feature. and found caddexpr blinking is very boring especially for multi tabpage users.
environment:
vim 7.4.1856  (console)
gvim 7.4.1856 (windows)
Could it be fixed in the future release ? it is a very bad user experience.
screen capture:

Linwei wrote:

GUI/CUI will blink frequently while a background function
(timer/channel cb) is using caddexpr to append text to quickfix.
This issue could be reproduce from a script:
function! TimerBlink(id)
    caddexpr "TIMER: " . a:id
endfunc

let s:id = timer_start(100, 'TimerBlink', {'repeat':300})

copen 10
cexpr ""
wincmd k

tabnew %

key step to reproduce the issue:

open the quickfix window in the default tabpage
open a new tabpage (with quickfix window closed by default)

important:
I am experimenting async-build with job/channel feature. and found
caddexpr blinking is very boring especially for multi tabpage users.
environment:
vim 7.4.1856  (console)
gvim 7.4.1856 (windows)
Could it be fixed in the future release ? it is a very bad user experience.
screen capture:

Possibly this is caused by updating the quickfix window.  Yegappan
suggested that adding to the quickfix list results in the quickfix
window to be refreshed, which would also cause the cursor to restart
blinking.
Does the problem go away when the quickfix window is not open?
--
I am also told that there is a logical proof out there somewhere
that demonstrates that there is no task which duct tape cannot handle.
-- Paul Brannan
/// Bram Moolenaar --<EMAIL_ADDRESS>-- http://www.Moolenaar.net   \
///        sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \
\\  an exciting new programming language -- http://www.Zimbu.org        ///
\\            help me help AIDS victims -- http://ICCF-Holland.org    ///

In my test, quickfix windows is not open in the current tabpage (tabpage2) and it is only open in tabpage1 and blink frequently.
And as you say if I comment copen 10 in tabpage1, it will not blink in tabpage2.
But I don't understand in my case, I am in tabpage2, and quickfix window in tabpage2 has not been open yet, it is only open in tabpage1, why does it blink in tabpage2 ??

Linwei wrote:

In my test, quickfix windows is not open in the current tabpage
(tabpage2) and it is only open in tabpage1 and blink frequently.
And as you say if I comment copen 10 in tabpage1, it will not blink
in tabpage2.
But I don't understand in my case, I am in tabpage2, and quickfix
window in tabpage2 has not been open yet, it is only open in tabpage1,
why does it blink in tabpage2 ??

Even though the window isn't visible, it probably still triggers a
redraw.  Vim doesn't really expect hidden windows to get updated, thus
there probably is no check for the window to be hidden.
--
One difference between a man and a machine is that a machine is quiet
when well oiled.
/// Bram Moolenaar --<EMAIL_ADDRESS>-- http://www.Moolenaar.net   \
///        sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \
\\  an exciting new programming language -- http://www.Zimbu.org        ///
\\            help me help AIDS victims -- http://ICCF-Holland.org    ///

Since I am not familiar with the vim source code and don't have the ability to make a pull request.
I would greatly appreciate if it could be fixed in the future release.

Could using the lazyredraw flag help with this @skywind3000?

@crzytrane lazyredraw is useless here.

excited !!


[QA] Map | Search dropdown remains open when selecting parcels or other tabs

Explorer Alpha build versions:
Not version specific
Issue Description:

If we click on the search place option on the map and the dropdown with the latest searchs appear, then the dropdown doesn't go away. In order for the dropdown to hide, we need to select a place of the list.
The dropdown remains open when closing and re-opening the map, change to the backpack or settings and overlaps the pannel of scenes when clicking on a space in the map.
STR:

Go to the map and click on the search bar, the dropdown appears
Click on any parcel in the map
Close the map
Re-open, the dropdown is still present
Change tabs to Backpack or Settings and go back to Map, the dropdown is still visible

Expected behaviour:
The dropdown should hide if we click on anywhere else, being the map, or closing the map or changing to other tabs.
Current behavior:
The dropdown remains visible
Evidence:
https://github.com/user-attachments/assets/b7e7c763-4777-4929-bba4-e07df258cfc1
Additional Notes:

This issue is still happening on latest dev and latest release (0.49.0)
Evidence:
https://github.com/user-attachments/assets/bd5122a0-a011-4b22-80fb-b854950ff289


Adding github templates

AutoDispose leverages html comments for added context if you're interested, but this LGTM


Integration with Google oss-fuzz fuzzing service

Hi, I would like to help integrate this project into Google oss-fuzz.
It is a fuzzing service Google provided for automatically testing important open-source repositories.
I've submitted an integration PR to oss-fuzz.
The integration contains the scripts and fuzzers for testing this project.
Are you happy to support this integration?
Additionally, can you provide your email? It will be used to notify you when oss-fuzz found bugs of this project.

Yes, I would be more than happy to support the integration. My email id is srikanth.mailbox (at) gmail (dot) com


The image id '[ami-a00461c8]' does not exist

Follow up on #283
Commit 7efdb5a0ca5fe43a6f52851827140de4dff36ccb
The default AMI cannot be used eu-central-1 or eu-west-1 in apparently.
$ machine create -d amazonec2 --amazonec2-access-key=$ACCESS_KEY --amazonec2-secret-key=$SECRET_KEY --amazonec2-vpc-id=$VPC_ID --amazonec2-region=eu-central-1 dockerbox
INFO[0000] Launching instance...
ERRO[0001] Error creating host: Error launching instance: Problem with AWS API call: Non-200 API response: code=400 message=The image id '[ami-a00461c8]' does not exist

WARN[0001] Removing created machine. You can run machine with the --debug flag to avoid this.
WARN[0001] You will want to check the provider to make sure the machine and associated resources were properly removed.
FATA[0001] Error creating machine

Using the standard amazon linux AMI fails too. The instance runs and then stops for a unknown reason. (Launching one in the AWS console works just fine)
But anyway, the ssh command from machine will never succeed. The default login user for that AMI is ec2-user and not ubuntu.
 machine create -d amazonec2 --amazonec2-access-key=$ACCESS_KEY --amazonec2-secret-key=$SECRET_KEY --amazonec2-vpc-id=$VPC_ID --amazonec2-region=eu-central-1 --amazonec2-ami="ami-b43503a9" testbox --debug
INFO[0000] Launching instance...
DEBU[0000] executing: /usr/bin/ssh-keygen ssh-keygen -t rsa -N  -f /Users/orobert/.docker/machines/testbox/id_rsa

Generating public/private rsa key pair.
Your identification has been saved in /Users/orobert/.docker/machines/testbox/id_rsa.
Your public key has been saved in /Users/orobert/.docker/machines/testbox/id_rsa.pub.
The key fingerprint is:
26:8d:b2:ee:b6:12:3a:9e:1a:f6:72:cf:32:cc:0d:08<EMAIL_ADDRESS>The key's randomart image is:
+--[ RSA 2048]----+
|                 |
|                 |
|                 |
|E      o         |
|. . . o S        |
| ... o o         |
|.oo.+            |
|+o+Bo.           |
|++o=B+           |
+-----------------+
DEBU[0000] creating key pair: testbox
DEBU[0000] creating security group in vpc-4d876924
DEBU[0000] authorizing <IP_ADDRESS>/0
DEBU[0001] launching instance in subnet subnet-71ac5818
DEBU[0024] created instance ID i-37daa4f9, IP address <IP_ADDRESS>
INFO[0024] Waiting for SSH on <IP_ADDRESS>:22
DEBU[0166] Settings tags for instance
DEBU[0166] Setting hostname: testbox
DEBU[0166] executing: ssh -o IdentitiesOnly=yes -o StrictHostKeyChecking=no -o UserKnownHostsFile=/dev/null -o LogLevel=quiet -p 22 -i /Users/orobert/.docker/machines/testbox/id_rsa<EMAIL_ADDRESS>echo "<IP_ADDRESS> testbox" | sudo tee -a /etc/hosts && sudo hostname testbox && echo "testbox" | sudo tee /etc/hostname
ERRO[0167] Error creating host: exit status 255
WARN[0167] Removing created machine. You can run machine with the --debug flag to avoid this.
WARN[0167] You will want to check the provider to make sure the machine and associated resources were properly removed.
FATA[0167] Error creating machine

AMIs only exist in one region, the default one only exists in us-east-1.
The docs should specify. Or machine should keep a list.

Yes Simon is correct, the default AMI is intended for use in the default
region (us-east-1).  I think we could do what Simon said and keep a list of
what AMIs are intended for use in the other regions and switch based upon
region selection.  For now you can use the following:
ap-northeast-1  ami-50eaed51
ap-southeast-1  ami-f95875ab
eu-central-1    ami-ac1524b1
eu-west-1       ami-823686f5
sa-east-1       ami-c770c1da
us-east-1       ami-4ae27e22
us-west-1       ami-d1180894
cn-north-1      ami-fe7ae8c7
us-gov-west-1   ami-cf5630ec
ap-southeast-2  ami-890b62b3
us-west-2       ami-898dd9b9
On Thu, Jan 15, 2015 at 5:27 PM, Simon Thulbourn<EMAIL_ADDRESS>wrote:

AMIs only exist in one region, the default one only exists in us-east-1.
The docs should specify. Or machine should keep a list.
—
Reply to this email directly or view it on GitHub
https://github.com/docker/machine/issues/287#issuecomment-70174570.

I'll encapsulate this into my work with stripe/AWS-go

@sthulb thanks!

@ehazlett thanks!

I've covered this in #290

@sthulb Do you think we could pull that out and use it now?  I would like to get this fixed without having to replace the entire lib.  We will almost definitely switch to that eventually but I think having this fix now would be tremendously beneficial to those not using us-east-1 by default.

Sure. I can submit a different PR containing just that :)

@sthulb awesome thanks!

@sthulb @ehazlett Great, thanks!

Closing - #400 merged

how to create ec2 instance in java


iOS build error: PushyModule.h Not Found

Hey,
I am trying to implement Pushy in my React Native application. Android works fine but I cannot get iOS build to work. I always get error "'PushyModule.h' file not found" in Xcode (see screenshot).

I have run "react-native link pushy-react-native" successfully without any errors. Probably my mistake is in installation part "Add blank swift file". That seems pretty unclear for me. Could you provide more instructions for that part?

Hi @anttivuor,
We'd be glad to help.

Open your React Native iOS app in Xcode by running the following command in your React Native project root:

open ios/*.xc*

In the file explorer (left panel), right click your project folder and select New File....

Select Swift File and name it Pushy.swift.

When prompted, you may decline the creation of a bridging header for your project.

Please let us know if you encounter any further issues.

Hi guys! I have the same issue.
@pushy-me followed all instructions from your docs but can't import the PushyModule in Xcode
'PushyModule.h' file not found
Maybe there is just a problem with Header Search Paths, but I can't figure out how to fix it.
Any help will be appreciated

HI @dmydry,
Were you able to create a blank Swift file using the instructions above? Also, were you able to run react-native link pushy-react-native successfully?

Hello,
I am still having the same error. I tried adding the empty Pushy.swift file but that didn't fix the problem. Do you have some kind of example project? I think that would help since I could see how the installation has been done.
In case you these information.
I am using:
XCode 10.1 (10B61)
MacOS Mojave 10.14
React Native 58.6
pushy-react-native 1.0.8

Hello @pushy-me
Yes, I had no problem with all the steps provided in the instructions including a blank swift file and react-native link pushy-react-native command.
In my case I have an ejected expo project, sometimes it matters but for most of libraries it works as expected.
Anyway, as @anttivuor asked, a sample project would be a nice start to investigate.

Hi @dmydry,
This original issue by @anttivuor relates to a pure React Native project, please refer to our response regarding Expo / ExpoKit projects:
https://github.com/pushy-me/pushy-react-native/issues/20#issuecomment-497177504

Hi @anttivuor,
We have started preparing a React Native demo project and let you know once it's ready.

Hi @anttivuor,
In addition, please let us know if running the react-native link pushy-react-native command on your project directory returned the following output:
info Linking "pushy-react-native" iOS dependency
info iOS module "pushy-react-native" has been successfully linked

HI @anttivuor,
We have just published a sample project which integrates the Pushy SDK for React Native into a new React Native app:
https://github.com/pushy-me/pushy-demo-react-native

Finally got the app to compile. I replaced "#import <PushyModule.h>" with "#import './../../node_modules/pushy-react-native/ios/PushyModule.h'" to get that working

Thanks so much for letting us know how you managed to solve it @anttivuor. It's quite strange you had to use this import statement but if it works then perfect. 👍

Hi, any pushy imported Objective C project sample available. I'm not able to add header to my project. Pushy module not found it says

Hi @rajazz,
Please make sure to add a blank Swift file (as mentioned in https://github.com/pushy-me/pushy-react-native/issues/19#issuecomment-493658935).
Also, please check whether use_frameworks! is uncommented in your ios/Podfile.


Create a development environment

As a Developer
I need to create a development environment
So that we have a place to test without impacting end users.
Details and Assumptions

Use Vagrant to create configurations
Use Docker for development environment
Use VS Code to create containerized environments

Acceptance Criteria
When the development environment is run
Then new application updates can be tested without interruption to the live environment.

Per feedback, not needed as a user story


Incoming vioce is not captured on samsung S8.

Issue with samsug galaxy s8 edge, Incoming vioce is not captured on samsung S8. Only external voice recorded.

have found a solution to this?

Use setAudioSource(MediaRecorder.AudioSource.VOICE_CALL) instead setAudioSource(MediaRecorder.AudioSource.VOICE_COMMUNICATION)

I already checked but no success. :(

As suggested by "Tabs" in thread (https://github.com/aykuttasil/CallRecorder/issues/17)

OK it works! you shuold request permisstions like this:
ActivityCompat.requestPermissions(this, new String[]{Manifest.permission.READ_EXTERNAL_STORAGE, Manifest.permission.PROCESS_OUTGOING_CALLS, Manifest.permission.READ_PHONE_STATE }, 321);

I have same issue with S8, S8+, S9, S9+, Xioami MI A2 and others, why?

Same issue in Xioami MI A1 too .


[system][docs] Missing content regarding possible Box's styling approaches

Related page
https://mui.com/system/getting-started/usage/#performance-tradeoffs
Kind of issue
Missing information
Issue description
The docs talk about the performance of the sx prop compared to styled() and plain CSS. Where do the style properties of <Box> fit in? For example, is <Box display="block" /> more performant than <Box sx={{ display: 'block' }}>?
Context
I'm refactoring a very large Next.js project that is facing performance issues. We use <Box sx={{ prop1, prop2 }}> a lot, and I'm wondering whether I should change them to <Box prop1="" prop2=""> or if I should create CSS classes.
Search keywords: performance, box, props, sx

I should change them to

Do not change it. We plan to deprecate <Box prop1="" prop2=""> in v6.
Regarding performance, if you don't have a performance issue (related to style recalculation), I suggest doing nothing at this point and waiting for Material UI v6 that we are working on. v6 will let you switch to Pigment CSS to remove runtime style calculation while preserving similar API, e.g. styled and sx.


Added Email,google and YouTube option to implement

Yes that was good code , i am just added extra feature!!


"Starchiojd" , "Brădet", "Gresia", "Rotarea", "Valea Anei" and "Zmeuret" villages are listed in the drop-down menu

The villages are listed in the drop-down menu alongside its corresponding county and commune, according to the law
Preconditions : the website (https://peviitor-ro.github.io/ui.orase/) is up and runing. After every step delete the text you typed from the search bar.

Step 1
Type "Starchiojd" in the search bar.

Expected results
The location is listed in the drop-down menu as "Sat Starchiojd, PRAHOVA (Starchiojd)".

Step 2
Type "Brădet" in the search bar.

Expected results
The location is listed in the drop-down menu as "Sat Brădet, PRAHOVA (Starchiojd)".

Step 3
Type "Gresia" in the search bar.

Expected results
The location is listed in the drop-down menu as "Sat Gresia, PRAHOVA (Starchiojd)".

Step 4
Type "Rotarea" in the search bar.

Expected results
The location is listed in the drop-down menu as "Sat Rotarea, PRAHOVA (Starchiojd)".

Step 5
Type "Valea Anei" in the search bar.

Expected results
The location is listed in the drop-down menu as "Sat Valea Anei, PRAHOVA (Starchiojd)".

Step 6
Type "Zmeuret" in the search bar.

Expected results
The location is listed in the drop-down menu as "Sat Zmeuret, PRAHOVA (Starchiojd)".


[DO NOT MERGE] ofborg test

Just testing if ofborg re-requests a review from the same maintainer after changes have been made to their files

Ugh, it won't work if I'm the author...


Make update process faster on Windows

I'm in a corp environment where we have a policy-driven on-demand virus scanner. This painfully slows down the update process of VS Code due to the scanning of every individual .js file.
I'm using a HP Z620 with SSDs... I can't imagine how slow it is for the average user with the same virus scanner.
Is there a way to 'bundle' the installation files together to increase speed during installation, or even maybe  update VS Code in the background and ask me for confirmation before the update-enabling relaunch?

Going with #13308 instead. It should just be done in the background, regardless of speed.


v2.9 not starting: Error in Go routine: runtime error: invalid memory address or nil pointer dereference

Welcome!

[X] Yes, I've searched similar issues on GitHub and didn't find any.
[X] Yes, I've searched similar issues on the Traefik community forum and didn't find any.

What did you do?
I attempted to run the current v2.9 tagged docker image.
What did you see instead?
project-1  | time="2022-09-22T14:19:26Z" level=info msg="Configuration loaded from flags."
project-1  | time="2022-09-22T14:19:27Z" level=error msg="Error in Go routine: runtime error: invalid memory address or nil pointer dereference"
project-1  | time="2022-09-22T14:19:27Z" level=error msg="Error in Go routine: runtime error: invalid memory address or nil pointer dereference"
project-1  | time="2022-09-22T14:19:27Z" level=error msg="Stack: goroutine 85 [running]:\nruntime/debug.Stack()\n\truntime/debug/stack.go:24 +0x65\ngithub.com/traefik/traefik/v2/pkg/safe.defaultRecoverGoroutine({0x32d2be0?, 0x62c5880})\n\tgithub.com/traefik/traefik/v2/pkg/safe/routine.go:66 +0xa5\ngithub.com/traefik/traefik/v2/pkg/safe.GoWithRecover.func1.1()\n\tgithub.com/traefik/traefik/v2/pkg/safe/routine.go:56 +0x36\npanic({0x32d2be0, 0x62c5880})\n\truntime/panic.go:884 +0x212\ngithub.com/traefik/traefik/v2/pkg/provider/acme.(*Provider).resolveDomains.func1()\n\tgithub.com/traefik/traefik/v2/pkg/provider/acme/provider.go:400 +0x29b\ngithub.com/traefik/traefik/v2/pkg/safe.GoWithRecover.func1()\n\tgithub.com/traefik/traefik/v2/pkg/safe/routine.go:59 +0x5b\ncreated by github.com/traefik/traefik/v2/pkg/safe.GoWithRecover\n\tgithub.com/traefik/traefik/v2/pkg/safe/routine.go:53 +0x72\n"
project-1  | time="2022-09-22T14:19:27Z" level=error msg="Stack: goroutine 84 [running]:\nruntime/debug.Stack()\n\truntime/debug/stack.go:24 +0x65\ngithub.com/traefik/traefik/v2/pkg/safe.defaultRecoverGoroutine({0x32d2be0?, 0x62c5880})\n\tgithub.com/traefik/traefik/v2/pkg/safe/routine.go:66 +0xa5\ngithub.com/traefik/traefik/v2/pkg/safe.GoWithRecover.func1.1()\n\tgithub.com/traefik/traefik/v2/pkg/safe/routine.go:56 +0x36\npanic({0x32d2be0, 0x62c5880})\n\truntime/panic.go:884 +0x212\ngithub.com/traefik/traefik/v2/pkg/provider/acme.(*Provider).resolveDomains.func1()\n\tgithub.com/traefik/traefik/v2/pkg/provider/acme/provider.go:400 +0x29b\ngithub.com/traefik/traefik/v2/pkg/safe.GoWithRecover.func1()\n\tgithub.com/traefik/traefik/v2/pkg/safe/routine.go:59 +0x5b\ncreated by github.com/traefik/traefik/v2/pkg/safe.GoWithRecover\n\tgithub.com/traefik/traefik/v2/pkg/safe/routine.go:53 +0x72\n"

What version of Traefik are you using?
traefik             v2.9             6f3f4055952e   5 days ago     107MB

Version:      2.9.0-rc3
Codename:     banon
Go version:   go1.19.1
Built:        2022-09-16T14:06:50Z
OS/Arch:      linux/amd64

What is your environment & configuration?
image: traefik:v2.9

If applicable, please paste the log output in DEBUG level
No response

Hello,
can you provide your configuration (yaml, toml, docker-compose file, etc.)?

Hello,

Hi

can you provide your configuration (yaml, toml, docker-compose file, etc.)?

Unfortunately, not at this time due to the vast number of fields containing sensitive data that I would have to go over and redact.
I do use ACME with Let's Encrypt, which might be related (see below), so here is the part that deals with certificate resolvers:
      - --certificatesresolvers.letsencrypt.acme.dnschallenge.provider=SOMEPROVIDER
      -<EMAIL_ADDRESS>      - --certificatesresolvers.letsencrypt.acme.storage=/letsencrypt/acme.json

and the debug log from the start of Traefik?

Same for this one, but I did have a minute to take a quick peek into the debug log and the one thing that stood out to me:
During the startup, it iterates over all my services and domain names when logging ACME-related things. The runtime errors don't start until it starts logging about ACME. It basically goes from

Trying to challenge certificate [...] ACME CA="https://acme-v02.api.letsencrypt.org/directory" [...]

over

Looking for provided certificate(s) [...]

and then ends up with

No ACME certificate generation required for domains ["redacted.tld"]." ACME CA="https://acme-v02.api.letsencrypt.org/directory" providerName=letsencrypt.acme routerName=someservice@docker rule="Host(redacted.tld)

This happens with all the configured domains and subdomains, and it's all interleaved with the aforementioned runtime errors.
Feels like it might indeed be ACME-related.

Closed by #9365.


Load styles from external files at build time for Angular Projects

Is there a way to do the following with SystemJS, and can it be done with both html and css external references.
"If you use module bundlers like Webpack, you can also use the styles attribute to load styles from external files at build time. You could write:
styles: [require('my.component.css')]
Set the styles property, not the styleUrls property. The module bundler loads the CSS strings, not Angular. Angular sees the CSS strings only after the bundler loads them. To Angular, it's as if you wrote the styles array by hand. For information on loading CSS in this manner, refer to the module bundler's documentation." -- Angular Documentation 04/19/2017, https://angular.io/docs/ts/latest/guide/component-styles.html

This should be possible with the text plugin in SystemJS (https://github.com/systemjs/plugin-text). Where the require would be require('component.css!text'). Although I haven't tested this exact use case myself. Let me know if that works out for you.

I ended up piping my javascript files through gulp-inline-ng2-template during the TypeScript transpilation step.  Now that I got this to work I don't think SystemJS would want to know to much about Angular's implementation.  You see the gulp-inline-ng2-template package is specifically designed to look for templateUrl: and styleUrls: properties in Components and re-write them as tempate: and styles: properties with inline html and css content.
Here is a snippet of my gulp file...
var ts = require("gulp-typescript");
var tsProject = ts.createProject("./tsconfig.json");
var inlineNg2Template = require("gulp-inline-ng2-template");
var htmlMinifier = require("html-minifier");
const sass = require('node-sass');
...
gulp.task("transpile-typescript", function () {
var tsResult = tsProject.src()
.pipe(inlineNg2Template({
templateProcessor: templateProcessor
, styleProcessor: styleProcessor
, removeLineBreaks: true
, useRelativePaths: true }))
.pipe(ts(tsProject));
return tsResult.js.pipe(gulp.dest(paths[settings.buildType].out));

});
function templateProcessor(path, ext, file, cb) {
try {
var minifiedFile = htmlMinifier.minify(file, {
collapseWhitespace: true,
caseSensitive: true,
removeComments: true,
removeRedundantAttributes: true
});
cb(null, minifiedFile);
}
catch (err) {
cb(err);
}
}
function styleProcessor(stylePath, ext, styleFile, cb) {
try {
if (ext[0] === '.scss') {
let sassObj = sass.renderSync({ file: stylePath, outputStyle: "compressed" });
if (sassObj && sassObj['css']) {
styleFile = sassObj.css.toString('utf8');
}
}
cb(null, styleFile);
}
catch (err) {
cb(err);
}
}


TypeError on _exit_span() with Pydantic 1

Description
  File "/app/.venv/lib/python3.10/site-packages/logfire/_internal/integrations/fastapi.py", line 108, in patched_run_endpoint_function
    return await instrumentation.run_endpoint_function(
  File "/app/.venv/lib/python3.10/site-packages/logfire/_internal/integrations/fastapi.py", line 223, in run_endpoint_function
    with self.logfire_instance.span(
  File "/app/.venv/lib/python3.10/site-packages/logfire/_internal/main.py", line 1236, in __exit__
    _exit_span(self._span, exc_value)
  File "/app/.venv/lib/python3.10/site-packages/logfire/_internal/main.py", line 1350, in _exit_span
    _record_exception(span, exception, escaped=True)
  File "/app/.venv/lib/python3.10/site-packages/logfire/_internal/main.py", line 1378, in _record_exception
    err_json = exception.json(include_url=False)
  File "pydantic/error_wrappers.py", line 67, in pydantic.error_wrappers.ValidationError.json
TypeError: json() got an unexpected keyword argument 'include_url'

Python, Logfire & OS Versions, related packages (not required)
logfire="0.32.0"
platform="Linux-6.5.0-35-generic-x86_64-with-glibc2.38"
python="3.10.13 (main, Apr  8 2024, 12:55:10) [GCC 13.2.0]"
[related_packages]
requests="2.31.0"
pydantic="1.10.15"
fastapi="0.111.0"
openai="1.26.0"
protobuf="4.25.3"
rich="13.7.1"
tomli="2.0.1"
opentelemetry-api="1.24.0"
opentelemetry-exporter-otlp-proto-common="1.24.0"
opentelemetry-exporter-otlp-proto-http="1.24.0"
opentelemetry-instrumentation="0.45b0"
opentelemetry-instrumentation-aiohttp-client="0.45b0"
opentelemetry-instrumentation-asgi="0.45b0"
opentelemetry-instrumentation-asyncpg="0.45b0"
opentelemetry-instrumentation-fastapi="0.45b0"
opentelemetry-instrumentation-httpx="0.45b0"
opentelemetry-instrumentation-starlette="0.45b0"
opentelemetry-proto="1.24.0"
opentelemetry-sdk="1.24.0"
opentelemetry-semantic-conventions="0.45b0"
opentelemetry-util-http="0.45b0"

Can you share a snippet that is causing this, or how the endpoint looks like?

@Kludex I'm pretty sure it's just any validation error with pydantic v1.

@Kludex I'm pretty sure it's just any validation error with pydantic v1.

Were you able to reproduce it?

It's not a FastAPI integration issue, but a Pydantic integration issue:
I can reproduce with:
from pydantic import BaseModel

import logfire

class Item(BaseModel):
    name: str
    description: str | None = None
    price: float
    tax: float | None = None

with logfire.span('my-span') as span:
    Item(name='Foo', price=32, tax='invalid')


Supporting NumPy >= 1.26.3 which includes NumPy 2.0 versions

Made minor updates to the ikpls package, all consisting of type annotations.
Updated the test files to use vstack explicitly instead of row_stack.
Removed .github/workflows/draft-pdf.yml as the JOSS review is over and PDF is published.

Now supporting NumPy>=1.26.3. This includes NumPy 2.0.x. Related to #36.


[NoErrorObjectAvailable] Script error.

We have got script error on production (new sandboxes too).

Even there are any files/folders (clean sandbox).

I need help getting rid of this error message. Has this issue been resolved?

I cloned this repo and deployed the source code into a sandbox and found the error.  In qsydFileExplorer.js, lines 98 should be changed from this:
this.addEventListener(CONSTANTS.CUSTOM_DOM_EVENT_TYPES.DATA_LOADED,this.handleDataLoaded);
to this:
this.addEventListener(CONSTANTS.CUSTOM_DOM_EVENT_TYPES.DATA_LOADED,this.handleDataLoaded.bind(this));
I will be deploying the unpackaged code and changing all references to the package, after which I will uninstall the package.

Do You see some date for new release with this fix ?

Hi @GlynAndersonSlalom did this worked for you. I'm still facing an error pop up with the component script error, Can you please help me out in resolving this

Hi @GlynAndersonSlalom did this worked for you. I'm still facing an error pop up with the component script error, Can you please help me out in resolving this

@Madhuri3011 The code change I describe in my comment did work for me.  It was the only change I found to be necessary.

Hey,
I am also facing the same issue. Was anyone able to resolve it?
Please let me know

Hey, I am also facing the same issue. Was anyone able to resolve it? Please let me know

Please see my post above from Dec 27, 2023.  It describes the required code change.


[5.6] add diff as custom date casting

This would add the ability for someone to use a date casting like this
$casts = [
    'created_at' => 'datetime:diff',
];

and receive the equivalent to doing $model->created_at->diffForHumans()

On obvious (and highly odd case) is that this breaks for those that wants to use the actual format diff (current day, current minutes, two f). That is a very specific use-case that sounds unlikely to be a problem.
But the idea do to this in the database layer sounds weird. Isn't this something you would do in your ui layer? I'll admit that those times I present these type of values to the user I use moment.js client-side to generate it, and not php at all.
We would at least need to properly document how to localize this diff, and consider if we need to have two different localizations in one database load (load two models at once using eager-load, having two different localizations).

@sisve I suppose we could change the key used to trigger this to be diff_for_humans to prevent that from being a problem.
Apart from that, the decision to make this happen in the "database" layer has already been made. I'm simply bolting on some additional useful behavior. The ability to do it in the UI layer still exists and this won't prevent you from doing so, just adds some convenience for people who want to utilize this new casting stuff.
The localized diff sounds interesting. Although I'm guessing that could be handled by setting some sort of global Carbon stuff that would be used throughout the application.

Won’t use this, but absolutely cool feature. Maybe make it unique as suggested, otherwise I’m voting for this

consider it changed @LasseRafn

Devs have begged for this cast per field ability for years. Seems we probably stayed away for a reason. Model / db seems like a strange place for this level of presentation.
That being said, now that it's baked in, I'm sure I'll use it. 🤷🏼♂ I'm a sucker for opportunities to use less code.

I find it totally weird to have this in the DB layer.
This is a representational issue and shouldn't be handled in a model.

👎
Maybe we need change the description here then to get rid of native types and replace it with anything you want 🙄
    /**
     * The attributes that should be cast to native types.
     *
     * @var array
     */
    protected $casts = [];

With this, we will move way beyond "casting" to native types.

May hold off on this for now.


Add details on how changes to the roadmap should be made

This is required by the graduation process!
I'll share this in Slack to seek feedback on it, and I'll explicitly share it with members of the steering committee too.

/lgtm


Ability to change attributes by keyboard without AAM mode

It can be more convenient to change attributes by shortcuts without necessary to go to attribute annotation mode. You just move cursor and setup attributes by keyboard instead of mouse. In such case you don't need find object in right panel.

The feature was deprioritized due to other more agent requests.

I will close the issue as outdated.


New algorithm stat

Maybe SR should be changed back to restoration? @nbei
Could you please add links to configs in the READMEs as other repos (mmaction2, mmpose, etc.)?

Maybe SR should be changed back to restoration? @nbei
Could you please add links to configs in the READMEs as other repos (mmaction2, mmpose, etc.)?


Add 1.21.1 tag to 1.21 versions on curseforge please

Also on Modrinth the tag 1.21.1 is needed, due to the update of RyoamicLights.


feat: make elderjs compat with a ts project

If the src/ directory files are .ts, elder should
load them correctly. Removes use of hardcoded .js file extensions
and relax to include check for .ts extension.
With this change the developer no longer needs to point elder.config.js
at the typescript build directory. As long as the build is executed
via ts-node all modules will be transpiled to JS during execution. This
will result in build times being slower to incorporate the ts compilation
overhead.
However overall it offers a big usability improvement for developers looking
to work with elder.js and Typescript.

🖐  Just saying I fully intend to pick this up again asap but will have low availability over the next week. More than happy if other folks would like to pick this up.

@thisislawatts Enjoy the new addition to the family! 👍 Take your time.

@thisislawatts if the remaining stuff is just fixing the build, LMK if you'd like to hand it off. I would like to contribute to Elder so it'd be a way to get started.

Hey @hangtwenty please do have a look at this if you've got the time. I am not sure this is only an issue with the build. I imagine this branch is pretty stale at the moment. I will be picking things up again in January.
Let me know if you start work on it! Would love to see this finished off 🙌

really interested in getting this done, where can I help test or implement?


Fixed StartupActivity issue; Made Version-Info visible

Bug-Fix: After closing the SettingsActivity the StartupActivity remainded visible
Improvements: SettingsActivity and Intent-Dump show App-Versionnumber
Fixed some minor lint-warnings
Note: i removed some local branches from my repro and merged all my changes into main.
Unfortunately this

automatically closed my previous pull request so i had had to re-issue a pull request.
destroyed the github-networ graph

I have added a few comments but please can you separate each issue into separate pull requests? There are so many commits I can't tell what is changing what.


Added Operations_on_linkedlist.c

Description
Added all operations on LinkedList-DS in C language.
operations :-

Insertion (at beginning, at end and at a certain given location)
Deletion (from beginning, from end and from a certain given location)
Searching
Sorting
Reverse
Traversing (display entire list)

Fixes #184
Type of change

[ ] New feature (non-breaking change which adds functionality)

Checklist:

[ ] My code follows the style guidelines(Clean Code) of this project
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings

@KshitijS01 add test case

@Amit366 Done.
Please check and merge this PR.


A more convenient constructor for Curve

People used to matplotlib may find the requirement to supply the x values to a Curve annoying. I don't see why the Curve constructor couldn't just take a list/array of y-values and automatically generate the x-values by the index.

I've added the new constructor in the commit above. All Chart Element types may now be instantiated with a simple iterable of y-values, e.g. this is now valid:
hv.Curve(range(10))

I'll close the issue now.

Ok great!
Now we must remember that the reason for this change is so that Curve is just as usable for quick  plotting as plt.plot.


command line with ruler

Hello, I'm using bufferline in the command line, but i have a problem using it together with set ruler.
When bufferline 'overlaps' the ruler, this happens:
Is there a way to limit the space it occupies or some other workaround?
Thanks.

Same here. I disabled the ruler as a temporary workaround with: set noruler


[RFC] Declarative navigator routeStack API

The Navigator component stores quite a bit of information internally in this.state, which makes sense given the complexity of scene transitions. However, the imperative APIs needed to work with the Navigator component (pop, push, replaceAtIndex, etc.) are unfamiliar when coming from other traditionally declarative React core components.
I'd like to propose adding a new (optional) declarative API:
<Navigator routeStack={routes} />

The routeStack prop would be an Array acting as both the initialRouteStack during getInitialState as well as diff'ed against the current state.routeStack in componentWillReceiveProps. When the routeStack entries differ, the component would make its best guess at how to transition, mount/unmount scenes, etc. This would allow for more complex manipulation of a scene route stack outside of the component, while also simplifying the API surface area of the Navigator.
If this seems like a reasonable proposal, I'd be happy to take a shot at implementing - haven't explored enough to see if there are any blockers that would prevent this from being possible, I'd imagine there are some complexities with gestures, etc.
I searched a bit for other issues and didn't happen upon any related tickets, but let me know if I missed one!

This is an interesting idea... I think that having some way to store the stack outside of the Navigator would extremely useful -- I'd like to be able to store it within a Redux store, for example, so I can save my entire app state in Redux and reload from there.
cc @hedgerwang @ericvicenti @ide

Yep, serializing with redux is precisely what I'm doing now and it's really convenient but extremely awkward with current apis.
I'll take a shot at it and see where I get.

I believe a declarative API is in the works (or is at least being considered, even if the next version of Navigator doesn't end up declarative). Regarding route serialization you may want to consider using URLs and react-router, which would then make it possible to deeplink into parts of your app. Currently there isn't a good story around this in RN land and we need more people exploring how to do this.

Awesome @tgriesser!

@tgriesser
Internally, we have built the low-level component that renders a stack of route reactively.
For now, the code look like this:

class Playground extends React.Component {
  constructor(props, context) {
    super(props, context);

    this.state = {
      stack: new NavigationRouteStack(0, [0]),
    };

    this.pop = this.pop.bind(this);
    this.push = this.push.bind(this);
  }

  render() {
    return (
      <View style={styles.main}>
        <NavigationUICardStack
          renderScene={renderScene}
          stack={this.state.stack}
          style={styles.stackView}
        />
        <Button onPress={this.pop} text="Pop" />
        <Button onPress={this.push} text="Push" />
      </View>
    );
  }

  push() {
    this.setState({
      stack: this.state.stack.push(this.state.stack.index + 1),
    });
  }

  pop() {
    if (this.state.stack.size > 1) {
      this.setState({
        stack: this.state.stack.pop(),
      });
    }
  }
}

I've been using the URL as a declarative way.
I found it very a nice pattern to never actually push or pop to the navigator, but rather always set the whole stack via the URL.
Then in componentDidUpdate, I check to see how the stack being pushed is different than the current one. If it's completely different, I just immediatelyResetRouteStack, but if it's one added or removed from the current one, I used push/pop.
This space is all still very early, so I've been meaning to put up a sample app about the patterns that we've been using. Let me know if you're interested in hearing more about this routing technique.

@bleonard I'd love to see a sample implementation.  Working on something similar to this right now in my RN app with declarative routing.

Hey everyone, I just published a blog post and sample app with our URL-driven routing.
http://tech.taskrabbit.com/blog/2015/09/21/react-native-example-app/

@bleonard– this is a great post.  I'm doing something similar now for declarative navigation with multiple route histories, as our app's primary nav is a tab bar, and each tab has its own history.

@ericvicenti put up an experimental declarative Navigator here: https://github.com/ericvicenti/navigation-rfc. Closing this issue here so that discussion moves to that repo.


container crash (Panic)

I am using Crawlab pro as a stack deployed on a docker swarm, all features are working fine. I am also using 1 worker node on a different machine.
However every few days the master node panics with the below error messages.
panic: runtime error: index out of range [104] with length 62
goroutine 15940761 [running]:
github.com/emirpasic/gods/lists/arraylist.(*List).Add(...)
/go/pkg/mod/github.com/emirpasic/gods@v1.18.1/lists/arraylist/arraylist.go:47
github.com/crawlab-team/crawlab-pro/core/metric.(*Service).getAllNodeMetrics.func1.1({0xc000dcc000?, 0xd4, 0xc0010ec2b0?})
/go/src/app/core/metric/service.go:226 +0x22d
github.com/crawlab-team/crawlab-pro/core/metric.(*Service).requestRemoteNodeMetrics(0xc000024480, {0x229d490, 0xc001c37860}, {0x22aa028, 0xc000af5930}, 0x1985063?, 0xc001990ee8)
/go/src/app/core/metric/service.go:334 +0x4da
github.com/crawlab-team/crawlab-pro/core/metric.(*Service).getAllNodeMetrics.func1({{0x65, 0xa7, 0xc1, 0xbd, 0xdc, 0x6e, 0x24, 0xde, 0x5b, 0x5a, ...}, ...})
/go/src/app/core/metric/service.go:224 +0xfa
created by github.com/crawlab-team/crawlab-pro/core/metric.(*Service).getAllNodeMetrics
/go/src/app/core/metric/service.go:223 +0x40c
Steps to reproduce the behavior:
I don't think there are set of steps to reproduce the issue, simply leaving the stack running will eventually make the container panic

@saleh-hom hi, have the same panic issue runtime error: index out of range in pro version.
It appears randomly during requests to API performed my Crawlab frontend side.


Bug: tear-offs don't trigger computed()

Added a test case illustrating the issue.

I think this is working as expected. Computed needs to return a value but with a tear off it returns a function.
When would you need to provide a tear off like that?

My understanding was that using a tearoff would be equivalent to an explicit call - after all, the input to computed() is still very much an instance of

something callable
taking no inputs
generating no output (or output is simply ignored)

I am obviously wrong about the "equivalence" part of that assumption, but if the criterion for supporting these is literal need, that point is irrelevant anyway.
In that case, however, some type of hint about the unsupported use case would be highly appreciated - ideally an assertion causing the call to fail or an analysis error. That way, others could be spared from first having to realize this is not an issue with the computation content, which in my case was what I initially focused on attempting to debug. The fact that this currently does not result in an error, but just a lack of signal updates, also feels like it could easily just go unnoticed and end up in deployed code. (looks like ImplicitCallTearoff might be the corresponding AST class to trigger on)

I think it would be a great addition to signals_lint for sure.
The reason it needs to be called is that is when the dependencies are discovered and connected to other signals.
With a tear off it just says that it will run but not actually computed.
There are times you do want a computed to return a function but your example is a good case to add a lint for.
Also to double check you can always test the JS equivalent to see if it is a bug or actual issue too:
https://www.npmjs.com/package/@preact/signals-core

Hah I have to admit it is quite the feeling when you open the codebase of a package written in an entirely different language but feeling right at home because the APIs are completely identical ❤

That was the goal 💙


Added list functionality to registry object

Very small change which I'm personally going to find useful shortly, I think others will too.

Can one of the admins verify this patch?

I signed it!

@tensorflow-jenkins test this please

OK Indentation fixed, my editor is set to 4 spaces.

@tensorflow-jenkins test this please

@rohan100jain is there anything left to do on this?

Jenkins, test this please.

Jenkins, test this please.

Sorry, jenkins broken because of a broken merge. See thread on #5103

Jenkins, test this please.

Jenkins, test this please.


fixing build errors for julia v0.5

minor changes for dictionary syntax

I'm not super familiar with build testing, but it looks like the failed checks are related to LibBSON 0.2.2 not yet being available.

Oops sorry, this is my bad -- will fix.

Merging since master has the fix for the LibBSON dependency


Upgrade dependencies

like ring's current version is 0.16, 0.12.5 is around 2 years ago

from #49
removing ring is better

Don't know why one check succeeded and another one failed

Failed one: https://travis-ci.org/KZen-networks/curv/jobs/572583063

Looks like it randomly failed at check_bit_length....

yes, there's an issue I think about it. it s a probabilistic test and therefore it fails once in a while

@omershlo
Looks like it always worked on my dev machine and github's builtin travis
But repeatedly failed on travis-ci.org

coincidence I would say.

Cool, I guess it's better to remove travis-ci.org check

@omershlo
Did some minor updates on this, do you have some time to review?

Yes, I was planning on doing it over the weekend. My main issue is with updates to secp256k1 library. I need to make sure what changes are included in that version and why not bump it to the latest

yes, there's an issue I think about it. it s a probabilistic test and therefore it fails once in a while

I guess I know why.
It should be related with prefix zeros in hex format of BigInt numbers
        let l63 = BigInt::from_str_radix(
            "96208c61220f2cce171f0c1d10db7c094245fb66b17b9de3e0c4fbf4e68e73d",
            16,
        )
        .unwrap();
        assert_eq!(l63.to_str_radix(16).len(), 63);

And since HashCommitment is the BigInt format of sha256, it probably starts with zero, this check is not appropriate.

This check is indeed problematic because of the probabilistic nature. Do you suggest we just remove it ?

I'll remove it in #61


Add Location lookup to API SDK, WebApi, CLI.

Adding reference to an existing GSF issue Green-Software-Foundation/carbon-aware-sdk#175

Adding reference to #214

PR: Green-Software-Foundation#239


Make rows default sortable by multiple columns

For example:
return $table
            ->columns([
                TextColumn::make('title')
                          ->label('Title'),

                BadgeColumn::make('is_active')
                           ->label('Status')
                           ->enum([
                               0 => 'Inactive',
                               1 => 'Active',
                           ])
                           ->colors([
                               'success',
                               'danger' => 0,
                           ])->sortable(),

                TextColumn::make('created_at')
                          ->label('Created at')
                          ->sortable()
                          ->dateTime('d/m/Y H:i'),
            ])
            ->actions([
                Tables\Actions\ViewAction::make(),
            ])->defaultSort('is_active-desc,created_at-asc');

This shows the active records first, ordered by creation date and then shows the inactive records ordered by creation date.

Thanks for the PR, @dev!
I'm not sure if this is the right API though.
What did you have in mind, @danharrin?

I think it would be better if we either use array syntax or a dedicated class:
['is_active', 'DESC']

``php
Order/Sort::column('is_active')->desc()

I think it would be better if we either use array syntax or a dedicated class:
['is_active', 'DESC']

new Sort('is_active')->asc()
Sort::column('is_active')->desc()
Order::column('is_active')->desc()

I agree with you. It will be easy to to maintain if there is sorting with relational column.
As filament table automatically handle relational column.

I don't feel comfortable mixing the $tableSortColumn and $tableSortDirection properties data together, and merging them would be a breaking change in v2. So I'm going to hold off on implementing this feature until v3. Thanks for the PR though.


Bitmask Picking Broken In HuBMAP Data Portal

Describe the bug
When you make a selection in the bitmask in the data portal, it does not make the selection and instead continues to use the selection tool.
To Reproduce
Open a CODEX dataset like https://portal.hubmapconsortium.org/browse/dataset/b1b4493122e8965e3684b0a7a5dd270a and try to select cells spatially.
This only happens in the data portal
Expected behavior
Cells should be selected
Environment:

Release or git hash: 1.1.7
Browser: FF
Browser version: 94.0.2

Uncaught Error: coordinates must be an Array
    at g (/static/public/10.79f498f20f45918fde18.js:16)
    at /static/public/10.79f498f20f45918fde18.js:44
    at c.l.visit (/static/public/15.79f498f20f45918fde18.js:8)
    at aR._selectPolygonObjects (/static/public/10.79f498f20f45918fde18.js:44)
    at Object.onEdit (/static/public/10.79f498f20f45918fde18.js:44)
    at Object.onEdit (/static/public/10.79f498f20f45918fde18.js:33)
    at nR.value (/static/public/10.79f498f20f45918fde18.js:50)
    at a.value (/static/public/10.79f498f20f45918fde18.js:33)
    at a.value (/static/public/10.79f498f20f45918fde18.js:38)
    at a.value (/static/public/10.79f498f20f45918fde18.js:38)