(discussion) thumbnail key format

The key format for resized images used by this program is /widthxheight/originalkey. I think /originalkeydir/originalkeyfilename-widthxheight.ext is better because it enables the removal of the original image and all its derivatives from S3 with one wildcard delete operation. If the width and height are the first part of the key this is much harder.
I wonder if my argument is right or if there are stronger arguments in favor of the current key format.

I didn't give this any thought. I made it a prefixed directory because it was conspicuous as I wrote this code for an explanatory blog post. Generally, I assumed people would use lifecycle rules to age out resizes images so I didn't consider the delete case. Happy to revisit if beneficial to do so - but since the blog post is written with this format it might be difficult to change in this repository. Hope that helps.

I see. I didn't think of lifecycle rules, thanks for that idea.


[FEATURE REQUEST] Pass array to WHERE IN statements.

I'm a little irritated when I need to use JDBC for any kind of query that demands complicated WHERE clauses.
Since requirements state that we are able to filter the lowest grain over 11 different parameters of a query, WHERE X IN (Z), where Z is an array would be the logical solution.
So, getting the array information from a request could lead to a prepared statement like this:
Array arrayToSet = this.connection.createArrayOf("String", paramArrayString.split(","));
this.preparedStatement .setArray(x, pp);

But any attempt of using the setArray returns throwNotSupportedException, according to source code:
@Override
    public final void setArray(int i, java.sql.Array x) throws SQLException {
        SQLServerException.throwNotSupportedException(connection, this);
    }

Stackoverflow seems to understand this as stated in the top voted answer:

There's indeed no straightforward way to do this in JDBC. Some JDBC drivers seem to support PreparedStatement#setArray() on the IN clause. I am only not sure which ones that are.

Another reply to another question seems more concise:

The suggested options are:

Prepare SELECT my_column FROM my_table WHERE search_column = ?, execute it for each value and UNION the results client-side. Requires only one prepared statement. Slow and painful.

Prepare SELECT my_column FROM my_table WHERE search_column IN (?,?,?) and execute it. Requires one prepared statement per size-of-IN-list. Fast and obvious.

Use a stored procedure to construct the result set.

Prepare N different size-of-IN-list queries; say, with 2, 10, and 50 values. To search for an IN-list with 6 different values, populate the size-10 query so that it looks like SELECT my_column FROM my_table WHERE search_column IN (1,2,3,4,5,6,6,6,6,6). Any decent server will optimize out the duplicate values before running the query.

But he states in the end:

The Right Answer, if you are using JDBC4 and a server that supports x = ANY(y), is to use PreparedStatement.setArray as described here.

In the other question there's a small implementation which solves the problem:
/**
 * Converts a SQL statement containing exactly one IN clause to an IN clause
 * using multiple comma-delimited parameters.
 *
 * @param sql The SQL statement string with one IN clause.
 * @param params The number of parameters the SQL statement requires.
 * @return The SQL statement with (?) replaced with multiple parameter
 * placeholders.
 */
public static String any(String sql, final int params) {
    // Create a comma-delimited list based on the number of parameters.
    final StringBuilder sb = new StringBuilder(
            new String(new char[params]).replace("\0", "?,")
    );

    // Remove trailing comma.
    sb.setLength(Math.max(sb.length() - 1, 0));

    // For more than 1 parameter, replace the single parameter with
    // multiple parameter placeholders.
    if (sb.length() > 1) {
        sql = sql.replace("(?)", "(" + sb + ")");
    }

    // Return the modified comma-delimited list of parameters.
    return sql;
}

The setArray example in JDBC 4.1 specs states that

methods setArray and setObject may be called to
pass an Array value as an input parameter to a PreparedStatement object.

and while the example mentioned talks about storing array objects,  its use for IN or X = ANY(y) seems universal, while not generally implemented.

Hi @johnnybigoode
Investigations are underway, we'll let you know soon!

Hi @johnnybigoode
As per JDBC Specifications, setArray() API:
Sets the designated parameter to the given java.sql.Array object. The driver converts this to an SQL ARRAY value when it sends it to the database.
I'm sure you're aware that SQL Server has no SQL ARRAY equivalent Type. Hence the driver cannot send a SQL ARRAY type object to database. This is the main reason why this API could never be supported.
Now coming to your proposal, if you are trying to work with java.sql.Array object by:

First, converting a SQL query containing IN clause to an IN clause with multiple comma-delimited parameters based on Array size.
And then, opening Array object internally in the driver and attaching them to the prepared statement on execution.

IMO, I don't like the idea and it does not seem a promising solution due to many factors, some of which are below:

It does not still respect JDBC Specifications to pass java.sql.Array object to an equivalent SQL ARRAY object.
The implementations of java.sql.Array are very different than being just list of values, and have further complexities related to them which will not get supported completely due to SQL Server limitations.
Its an overhead for the driver to parse query and replace IN clause in the query based on Array Size and then open the Array object and attach the data to the SQL Query.
The driver will also have to handle duplicate data possibilities, etc.

It looks like a forced solution to make the API work, and not something that respects specifications with a clean defined solution. If you think differently and have a cleaner solution to answer all the concerns I mentioned, please go ahead with a PR against dev branch, we can review it.

@cheenamalhotra
Oh wow, thanks for the detailed reply. I trully appreciate it.
And I guess since SQL Server has no SQL ARRAY, it's obviously not a good idea to implement a hack for a specific use-case.
I guess this issue should be closed until further notice.


prereq: Linux machines

Linux machines

Docker
Docker-compose
K8s

For K8s
1 master machine
2 nodes with cubeadm on it.

k8s kubeadm installation:
sudo -i
apt-get update && apt-get install -y apt-transport-https
curl -s https://packages.cloud.google.com/apt/doc/apt-key.gpg | apt-key add -
cat </etc/apt/sources.list.d/kubernetes.list
deb http://apt.kubernetes.io/ kubernetes-xenial main
EOF
apt-get update
apt-get install -y kubelet kubeadm kubectl

They all need to have port 6443 open, since I don't know which master people will choose.

Probably also all need access to port 80

Scratch this - I dont need any of this since we are taking a different approach.
@sami-alajrami
I may need the google sdk, do you think you can help me set that up if needed ? We're running a bit tight on time, but I hope we can talk tomorrow when me and Sofus go through the material?
I have instructions for whats needed, I just need your help implementing it.

@Sharor I am afraid I am occupied till the end of the week .. if you give me more information on whats needed, I can see if I can fit it somewhere tomorrow evening

@sami-alajrami we're running everything so far as it should be, and I think we're good :) thanks though !


Query : Get Birk Parameters

Purpose
Added support for GetBirkParameters
Changes
Added support for GetBirkParameters
Checklist

[x] My code follows the style of this project.
[x] The code compiles without warnings.
[x] I have performed a self-review of the changes.
[x] I have documented my code, in particular the intent of the
hard-to-understand areas.
[x] (If necessary) I have updated the CHANGELOG.

CLA acceptance
By submitting the contribution I accept the terms and conditions of the
Contributor License Agreement v1.0

link: https://developers.concordium.com/CLAs/Contributor-License-Agreement-v1.0.pdf

[x] I accept the above linked CLA.

Depends on #88

Please add unit test.

done

Closed via https://github.com/Concordium/concordium-java-sdk/pull/91


Fix UB of defining stuff in namespace std. Just include the headers.

Having this UB may randomly break just by some compiler update.
Fixes #194

I can confirm that the code is correct, even though clang gives the Wdynamic-class-memaccess warning. I'll suppress it.

I tried with clang and indeed got that warning. Fixing the warning requires header <new> which is another cheap header and using placement new.
Suppressing the warning is just hiding more bugs.

When we go down that line... why not get rid of the String class altogether and use std::string? I shouldn't have said that :| Now I'm thinking about it...

Well, in C++ constructing object with memcpy is UB. The String class is not UB.

regarding the memcpy and  - I'm convinced, that's the right way to go indeed.

No, to be completely correct, memcpy can be used only on trivially copyable types. Otherwise you have UB.

I will close this as obviously more stuff needs fixing.

It's just that object construction - I'll fixup the code once I get to it.
Here's the deal: I'll work a few more days on the framework and before the release I'll experiment with stdlib headers. I'll most probably merge this.

OMG this is just frustrating. MSVC 2015 fails for warnings in its own headers.
I can't be bothered to fix this anymore, please just reduce the warning level. MSVS level 4 is known to produce warnings in its own headers, nobody uses that.

@dimztimz :D It's actually not /W4 but /Wall that is used... and I have absolutely no clue as to why I decided to go down that road and suffer.
Anyway don't bother - I'll handle this PR going forward.

I would suggest you to do the following

Reduce the reported warnings to something sane like Wall Wextra on gcc and clang
Delete almost all suppresions of warnings. I hace never seen code that wasted 100s of lines just to supress warnibgs.
Fix the actual warnings

Someone made a PR where even std::tuple is forward-declared... https://github.com/onqtam/doctest/pull/203
And in there he uses _LIBCPP_BEGIN_NAMESPACE_STD so apparently there is an easy way to deal with the inline namespaces of some stdlib implementations. I also found facebook/folly forward-declaring types in the std namespace:
https://github.com/facebook/folly/blob/master/folly/Traits.h#L628
So if Facebook are OK with this kind of UB - then I'm fine with it as well. I'm guessing that if other stdlib implementations (not only libc++) move to inline namespaces they will provide a similar macro.
I will make a compromise however: I'll change DOCTEST_CONFIG_USE_IOSFWD to something like DOCTEST_CONFIG_USE_STD_HEADERS and when it is defined - the appropriate std headers will be included (not only for the streams but also for nullptr_t) instead of the forward-declarations. So the only piece of UB left when using that identifier will be the construction of the object with memcpy instead of using placement new.
This has the following benefit for me: I don't have to think about this right now and I'm skipping having to re-do the benchmarks & update the graphs (because the compilation times will have significantly changed) which takes around 1 day...
So I'm closing this PR.

I'd advise you not to make the code any messier with more config macros.
But I don't really care anymore, I decided not to use doctest at all. The forward declaring is not the only UB. The memcpy you use instead of placement new to construct object is another much dangerous UB. Abd probable there is more ub hidden somewhere.

@dimztimz I think you would be interested in Catch2


Release :gem: v0.3.1

For #18. @jhubert

Coolio.

merged and released. thanks @parkr and @rubybrowncoat

Thanks!!


Song stats

Hi, I love your theme! Very glad I found it. Only thing I wish it included from the default theme is the detailed song stats (screenshots below). Is it possible for this to be enabled in Superuser? Thank you for all your hard work on this!

detailed stats havent had any work done, but im planning on doing them at some point. really, i want to make it as performant as possible, since ive noticed some things about the stats in soundwaves im not too keen on. this is definitely on my list of things to do, though! probably near the top, i also want detailed stats lol

Yay! Happy to hear you're on it. Forgive my ignorance, but is it possible to use the default theme stats as a starting point? Seems crazy to have to reinvent the wheel for every theme.


Some metering hive tables are not getting updated

I can see some of the metering hive tables are not getting updated
PFA the screenshot highlighting this issue
Please help

@amalkurup89 hmm, can you post a dump of the reporting-operator logs? I believe you said you were deploying Metering w/o TLS support, so it should just be kubectl -n $METERING_NAMESPACE logs <reporting-operator pod name>.

rpt-operator-logs-1.txt

I haven't seen this error before, did you change anything post install? In the case where you updated the top-level tls.enabled: false in your MeteringConfig CR post-install, it may be causing problems, and you would need to nuke your namespace and re-deploy metering.
time="2020-01-09T09:46:42Z" level=error msg="error syncing ReportDataSource \"metering/node-allocatable-memory-bytes\", adding back to queue" ReportDataSource=metering/node-allocatable-memory-bytes app=metering component=reportDataSourceWorker error="ImportFromLastTimestamp errored: failed to store Prometheus metrics into table hive.metering.datasource_metering_node_allocatable_memory_bytes for the range 2020-01-08 01:33:00 +0000 UTC to 2020-01-08 01:38:00 +0000 UTC: failed to store metrics into presto: presto SQL error: presto: query failed (200 OK): \"io.prestosql.spi.PrestoException: Error moving data files from file:/tmp/presto-reporting-operator/59644000-4ad5-40da-9d3e-82fc73b18b8c/dt=2020-01-08/20200109_094550_00023_2sz2w_2928bc64-db63-470c-b602-14a285e781cd to final location file:/user/hive/warehouse/metering.db/datasource_metering_node_allocatable_memory_bytes/dt=2020-01-08/20200109_094550_00023_2sz2w_2928bc64-db63-470c-b602-14a285e781cd\"" logID=xet8foeoo6

@timflannagan1 I haven't yet updated tls.enabled to false. The above error logs are with tls setting as true

Okay, understood. Can you walk me through the steps you used to install metering? It still looks like you may have changed something post-installation that's causing the presto insert query to fail.


Use nvm to manage node versions in containers

This is more of a suggestion than an issue; but keeping up with node releases and the versions that people want to use on projects can be a bit of a pain. As a suggestion; what do people thing about using nvm to install and manage node versions in the Jenkins slaves?
We could then install v4, v6, v8 (and any other version really!) into the image and when a person runs their npm build in Jenkins; they can just set nvm use v4 and away they go?

Hey @springdo
Interesting idea, I would like to go this way.
Unfortunately, we cannot include binaries that are not packaged in rpm's and installable via yum/dnf on centos7 and rhel7.
Looking at link you provided, along with trying to install locally and searching a bit, I was unable to find rpms.
Certainly, if I have overlooked something and you can point me to a repo, let me know.
thanks

Yeah I think the nvm script uses the prebuilt binaries made specific for the os distro. Perhaps there is a way we achieve the same goal (multiple node versions just by selecting the one you want to use at execution) with the scl node versions in the existing slaves? Do you think its worth me lookin into this?

A single image w/ multiple SCL versions of nodejs installed seems plausible but it has not been the direction we've gone so far out of a desire to:

keep the images slightly smaller
avoid the issue that occurs when a particular version goes EOL:  if we have a single image w/ multiple versions, and then one version goes EOL, we have no choice but to publish a new version of the image that no longer includes the EOL version.  That would negatively affect anyone still trying to use the EOL version.  By having an image for each version, we can simply stop updating the image w/ the EOL version, while continuing to update the other images.  So it provides better granularity.

So i think it might be a reasonable thing to look into for your own agent image if you want to create one, but i don't think it's a pattern we'd adopt for the image we distribute.


restore global storage pool in test cases

Signed-off-by: hehechen<EMAIL_ADDRESS>What problem does this PR solve?
Issue Number: close #4872
Problem Summary:
What is changed and how it works?
Check List
Tests

[ ] Unit test
[ ] Integration test
[ ] Manual test (add detailed scripts or steps below)
[ ] No code

Side effects

[ ] Performance regression: Consumes more CPU
[ ] Performance regression: Consumes more Memory
[ ] Breaking backward compatibility

Documentation

[ ] Affects user behaviors
[ ] Contains syntax changes
[ ] Contains variable changes
[ ] Contains experimental features
[ ] Changes MySQL compatibility

Release note

None

/run-all-tests

/run-all-tests

/run-all-tests

/run-all-tests

/merge

/merge


PWA - Error running Knowzy app inside VM.

In Build a Responsive web app section, after I get the PWA source code and run the app, I get this error

cause identified. need .net core 1.1 installed. will get this included in the vm image.

fixed.


Add possibility to load file from url

Hello,
Here's a feature request in the form of a pull request.
I suspect that you wouldn't accept as is but I'm open to modify it to respect your conventions I could have missed.
The feature is to be able to load a keepass file directly from an url and let the app download it.
It works perfectly for uris in the same domains that the one hosting the keeweb app.
For other domains, the header 'Access-Control-Allow-Origin' should be set.
It can be convenient if you store your file on a web server. It saves the user to first download the file, load it in the app, and optionally not forgetting to delete it afterwards.
Thanks for the great app by the way :)

Sorry, I had branched from your master, I synced my master branch with your develop branch to have a tidier pull request :)

Hello!
URL sync will be implemented as part of WebDAV protocol and configured as a storage provider... For now, I'm working on providers in a separate branch (I've not pushed it yet), they will be loaded as modules and plugged into the app. Webdav will be one of them, with its settings and name.
There will be a button on start screen to turn on different providers, so the UI will be a bit more complex than just a field on homepage.

Will it support web servers which do not support WebDav specific methods ?

Yes, I think

Great ! Thanks and good work then.
Looking forward to see that :-)


fix(diagnostics): Hex-encode debug format of commitments, nonces, and nullifiers

Motivation
Zebra's debug output shows block header commitments and nonces as an array of integers, rather than hexadecimal. This makes them very hard to debug.
This diagnostics bug is impacting RPC testing.
Most of the changes in this PR are in test code, or they are tiny changes to existing code.
Solution

Create a HexDebug type wrapper, which automatically makes the wrapped type encode as hex during derive(Debug)
Apply the wrapper to the block header commitments and nonce
Apply the wrapper to Sprout nullifiers and commitments
Apply the wrapper to Sapling nullifiers
Apply the wrapper to Orchard redpallas keys

I also opened ticket https://github.com/ZcashFoundation/redjubjub/issues/155 to make similar changes in redjubjub.
Review
This is blocking RPC testing, it is important to review soon.
Reviewer Checklist

[x] Will the PR name make sense to users?

[ ] Does it need extra CHANGELOG info? (new features, breaking changes, large changes)

[x] Are the PR labels correct?
[x] Does the code do what the ticket and PR says?

[ ] Does it change concurrent code, unsafe code, or consensus rules?

[ ] How do you know it works? Does it have tests?

Looks like crates.io is having some network or capacity issues, I'll retry those parts of CI later. (Or anyone can do it if I'm not around.)

@mergifyio refresh

Failed with bug #5958 in the merge queue:
https://github.com/ZcashFoundation/zebra/actions/runs/3934423672/jobs/6729152365#step:9:2156

It looks like this has a build conflict with some code in other PRs, I'll see what I can do to fix it.

This needs a quick re-approval.
I added commit 0912da3 to make it build with the latest main branch, which gets reverted straight away in PR #5944 and replaced with a different fix.


Password update

Every 45 days admin password gets updated without user's knowledge. Please fix by either notifying users of impending password reset or not updating passwords without user's knowledge.

Hello @sidbannet -
We are tracking this issue internally. Support for AD is not currently released, so I am closing this ticket. SOCA stable version with AD support will mitigate this issue.


Support metric to monitor import lag

We need a metric to measure the import lag during processing messages from a jdbc source. We were wondering whether it is possible to add further metrics to the source connector that can be added to the kafka connect Prometheus metrics.
Our goal: Especially during first or initial import of database rows we want to monitor how many rows still need to be imported and are not already processed.
There is a metric that displays the number of polled rows (e.g. source-record-poll-total). This metric represents the number of rows which the connector has already processed/read from database. One cannot determine how many unpolled rows are left in the database and still need to be read from db.
I am new to kafka connect plugin development. First of all: is it possible to add such a metric to this kafka connect plugin? Second, if we would implement that metric would you merge that pull request to your code base?

This would be important to us too. Is anybody here that can answer a few question regrading how this can be achieved? After that we would be open to implement it ourselfs and merge it back here.
@jlprat, @ftisiot

We plan to use such a metric for an initial spool up. After all rows are imported other processes in our application landscape can start processing. In other words, other processes must wait for the initial spool up to finish. Our main goal is to recognize that the spool up is finished.
Technically, it would be a count on the database. If I understand you correct, you suggest implementing the count query during jdbcSourceTask.start(…) or jdbcSourceTask.poll depending on whether the count must be updated or not.
How would you store the metric? Is it possible within a kafka connector to define custom metrics that are forwarded to kafka connect and will be provided to external sources via Prometheus? Or would you suggest another way to provide the metric to external sources?
To answer your questions:

Continuous vs startup metric: In our use case we would be fine with a startup metric. We do not expect the number of rows to grow over time.
Streaming vs batch/ETL task: We would like to use the additional metric for monitoring an initial load of data. So I would say our use case is more batch/ETL based.
Query complexity: Our queries are rather complex. We use multiple joins and it takes the database a while to execute those queries.

Hey @Ugbot,
If you talk about metrics, do you talk about a metric that is published via JMX MBean? Or is there another way to provide metrics. I’m not sure, if I got what you mean by 'metrics'.
Does your second proposal refer to a general metrics topic that is provided by kafka connect?
If I understand you correct, we prefer the first option. We already use a jmxPrometheusExporter to extract and store the values in our Prometheus. To store a further value would just be another config line for the exporter.

Hi @Ugbot,
I did some programming and provided a solution with a PullRequest!
As a first step, my solution on startup just executes an inital Select count(*) ... with the given query or tables. It then provides that metric to an JMX endpoint. All other kafka connect metrics are provided via jmx export as well. I just needed to add another jmxPrometheusExporter rule to provide the new metric via Prometheus:
`

pattern: io.aiven.connect.jdbc.initialImportCount<task="(.)", topic="(.)">
name: aiven_startup_count
labels:
topic: "$2"
task: "$1"
help: "Kafka JMX metric initialImportCount"
type: COUNTER
`

Is there anything I can do to speedup the merge process?


Add Favicon Icon to the Game

The game currently does not have a favicon icon displayed in the browser tab. Adding a favicon will enhance the overall user experience by giving the game a recognizable symbol when it’s opened in a browser tab.
note : icon must be designed not copied and generated from AI

Create a favicon icon representing the tic-tac-toe game (could be a simple "X" and "O" design).
Convert the icon into appropriate .ico and .png formats.
Add the favicon to the root directory or the public folder.

Please provide description about design

I would like to work on this issue.

go ahead

I would like to work on this issue. Allow me to fork and make relevant changes to the repo.

go ahead !

I would like to work on this issue. Allow me to fork and make relevant changes to the repo.

go ahead !

I've done accept the pull request.

I would like to work on this. Please assign this to me.

I would like to work on this. Please assign this to me.

I would like to work on this issue.please assiign me

I would like to work on this issue. Allow me to fork and make relevant changes to the repo.

go ahead !

I've done accept the pull request.

i have done some changes in existing repository so , please look at new one and update the change in the updated repo
a
note**
provide screenshot of before and after

Hi @iamparas0 I would like to work on it

I would like to work on this. Please assign this to me.

I would like to work on this. Please assign this to me.

go for it , please read description carefully and put ss before pr otherwise i will reject pr.

@iamparas0 can you assign me this please!!!

I want to work on this issue can you assign me


Fonts supporting wider set of diacritics and accented characters

The change introduced #48, while generally a step in the right direction, unfortunately broke my non-latin site, because the local fonts are only in latin set, which does not contain some Czechs letters (such as ě,š,...) and I am sure many others from other languages.
I could submit a PR which would include the full font character set, but that would of course increase the size of the font files.
Alternatively, there could be some configuration setting to select the desired sets, but that will be quite complicated to do and use.
Or I can do that locally on my site, replacing the fonts.css with my own version and add the proper font files.
What do you think, @janraasch ? BTW: Thank you so much for creating the theme and sharing it with us.

Hi @whizz, thank you for getting in touch 👍.

Alternatively, there could be some configuration setting to select the desired sets, but that will be quite complicated to do and use.

I agree 💯- %. I'd say that's out of scope.
Could you open a pr

which would include the full font character set

please 🙏? Then, we can check how much of an increase in filesize this is. Maybe it's not that much 😇 ☺?!
If it seems too big, we'll go with

Or I can do that locally on my site, replacing the fonts.css with my own version and add the proper font files.

Sounds like a plan?

BTW: Thank you so much for creating the theme and sharing it with us.

Thank you for the kind words. You have to thank Yonatan Wolowelsky for the original theme though. I just ported it from Ghost to Hugo 🤓😄.

Apparently, Open Sans Condensed is no longer available at Google Fonts 🤦♂ I'll have to figure out what to do about it.

Lighthouse gives me this warning:

Ensure text remains visible during webfont load

Leverage the font-display CSS feature to ensure text is user-visible while webfonts are loading. Learn more.

Could you add font-display: swap; to all fonts? Or can i make a PR?
But the way, i 2nd this issue. I would like to have easy option to disable custom fonts

@whizz This is also issue for me, you you have any specific fonts in mind?


[Feature Request] Warning/error for having no Returns section if Args section is present

It would be great if, for example in Google docstring style, missing a second Returns section would issue an error it is already written as a multiline docstring.
http://google.github.io/styleguide/pyguide.html#doc-function-returns
Same goes for other docstring styles.

Following the style guide's recommendation, it could also be great if this section is optional if the first word of the summary string is "Returns" or "Yields", or if there is a None type hint.

I want to bring up an issue currently present with version 5.1.1:
If there is no Returns: section for a functions that returns None, then pydocstyle falsely falgs a D417 Error.
But this happens only for the hanging indent style. According to the google style guide (as linked by @ljades), both versions are allowed.
So I would ask for a different Error than D417, because that one does not include the Returns: section in its description.
And of course for a fix of the issue with returning None.
Output is:
pydocstyle --convention=google my_code.py
my_code.py:4 in public function `some_function_fails`:
        D417: Missing argument descriptions in the docstring (argument(s) arg1, optarg1 are missing descriptions in 'some_function_fails' docstring)

from this code:
"""Some module."""

def some_function_fails(arg1, optarg1=None):
    """This perfectly valid docstring fails.

    Args:
        arg1:
            If the arg description is too long, the google style
            allows hanging indents.
        optarg1:
            If the arg description is too long, the google style
            allows hanging indents. Default None.
    """

def some_function_pass(arg1, optarg1=None):
    """Adding Return: does the fix.

    Args:
        arg1:
            If the arg description is too long, the google style
            allows hanging indents.
        optarg1:
            If the arg description is too long, the google style
            allows hanging indents. Default None.

    Returns:
        None. But this is not necessary!
    """

def why_this_function_pass(arg1, optarg1=None):
    """But this is not a problem with this style.

    Args:
        arg1: If the arg description is too long, the google style
            allows hanging indents.
        optarg1: If the arg description is too long, the google style
            allows hanging indents. Default None.
    """

Also, adding a Raises: section for some_function_fails fixes the error.


T11.4 Display the individual ratings of the other users for the corresponding course

show rating per user for each category (teaching, workload, content) on a 5-star scale and show text rating

In conflict with #139 , therefore closed


Author: App Settings

How to read/write in to app settings? i want to add an field in to the settings so that my app can read from the settings.

i dont want to see the custom page instead if we go settings > apps > pick my app > i would like to see there?

You'll need to create a standard Settings bundle as part of the iOS project generated: https://developer.apple.com/library/content/documentation/Cocoa/Conceptual/UserDefaults/Preferences/Preferences.html
Then, accessing these settings seems to be possible from the react native application: http://stackoverflow.com/questions/39081688/open-settings-app-from-another-app-in-ios-react-native
To be experimented


"Arguments too long" error when including a large number of files

Prerequisites
Can you reproduce the problem reliably?

Yes

Did you check current release notes for known issues?

Not found in release notes

If this is not the latest release, have you checked newer releases?

Using version 1.8.0

Description:
When placing a folder with a large number of tiles, inside the project sources directory, the Makefile will iterate through all the sub-directories in the include path as well (this is what we want).
Unfortunately, this results in the following error "Argument list too long". The problem is caused due to build.mk (Found in ~/ModusToolbox/workspace/mtb_shared/core-make/release-v1.8.0/make/core/build.mk). To include all the dependencies, all the filenames are echoed into a rpt (report) file using command line parameters. Because there is a maximum limit for bash command line parameters, the process will fail if there are too many files included.
A possible fix will be to use the Makefile $file directive. The $file function is for the Makefile to write values directly to a file. With this, we do not depend on bash parameter expansion and thus do not have the issue of having too many arguments
See my github commit for possible fix

https://github.com/zst123/Element14_Low-Power-IoT/commit/f7e30b41c3e962c2d41a1b9b5be77976c9bfd499

Steps to Reproduce:

Add many files into the "sources" directory

Compile and see the error

Image of the error: https://www.element14.com/community/servlet/JiveServlet/showImage/38-38593-1092618/fix0.png

Expected Result:
Project compiles successfully
Actual Result:
Project fails to compile with "Arguments too long" error
Frequency (1/1, 1/50, 1/100):
Always happens
Build/Commit:
v1.8.0
Target:

PSoC 6 WiFi-BT Pioneer Kit (CY8CKIT-062-WiFi-BT).

Host OS and Version:
Linux / Ubuntu 20.04.02 LTS
Compiler:
ModusToolbox version 2.3
Environment
More information of project is documented on my Element14 project page.

https://www.element14.com/community/community/design-challenges/low-power-iot/blog/2021/10/21/wearable-gesture-control-5-deploying-edge-impulse-model-fixing-a-makefile-issue

Hi @zst123 ,
I have raised an internal ticket for this bug and the same is expected to be resolved with the next release i.e. core-make version 2.0.
Thank you for pointing out the same.
Warm Regards
Alen

@AlenAn14 when could we expect the release of core-make version 2.0?

Hi @tomoveu ,
This fix will be available in the core-make version 3.0.0.
Regards
Alen

@AlenAn14 The current version of core-make is 1.9.1.    When would 3.0.0 come out?

Hi @tomoveu ,
The version 3.0 of core-make is expected to come out in September of 2022.
Warm Regards
Alen

Hi @tomoveu ,
Can you please let me know if this issue has been resolved?
I tried cloning the project here, and running it in ModusToolbox with core-make 1.9.1 and and not observing this error.
Can you please verify on this once.

@AlenAn14 I am a bit confused by the versioning. Are we now at core-make version 3.0 or 1.9.1? 😃
I'd be happy to test. This issue can be found on multiple threads in the Infineon forum with 1.8.0

I was using 1.9.1 with MTB2.4 today and then cloned your project into it, but the error is now not visible. Instead it build successfully.
I also tried using 1.8.0, but was not able to reproduce the error.

@AlenAn14 I don't know about @zst123's project, but I believe he has also hardcoded the fix in his project when using 1.8.0. At least, this was the only fix we could come up - Add PREBUILD command in the Makefile.

What should I assign the PREBUILD flag?

@AlenAn14  sorry for the confusion, the fix is applied directly to the build.mk in core-make like show here
mtb_shared/core-make/release-v1.8.0/make/core/build.mk
I am not familiar with the @zst123 project. We are using core-make v1.9.0 and the issue exists.

Hi @tomoveu ,
I have cloned the mtb_shared folder newly, so I do not have the fix in my build.mk file of core make.
It is building successfully.
Will it be possible for you to create a sample project that throws this error and share the same with me?

@AlenAn14 the issue is with long paths, for example:
/Users/dimitomov/work/mtb-example-edgeimpulse-keyword-spotting/build/APP_CY8CKIT-062-BLE/Debug/ei-model/edge-impulse-sdk/tensorflow/lite/core/api/tensor_utils.cc
I just tried with Modus Toolbox 3.0 and the issue seems to persist.
What are you building to test?


Client: Add some default timeouts

Recently during an instability/outage in the LXC hosting infrastructure I noticed that the image download attempt that was being made hung for several minutes.
This sounds similar to the issue reported here https://github.com/lxc/lxd/issues/10279
This lead me to notice that several of the HTTP clients we use do not include any timeouts beyond establishing the initial TCP/Unix connection.
This is an attempt to introduce some (I hope) sensible defaults.

Testsuite passed


[fix](hive catalog)When using the hive catalog the hive table name is uppercase, t…

…he Doris query is reported wrong #29058
Proposed changes
Issue Number: close #29058

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall


Unexpected behaviour applying minimum clause to missing property

Hi!
I'm seeing a somewhat weird behaviour when I try to apply a conditional minimum clause to a message where the minimum clause subject is missing.
For example:
{
  "$schema": "http://json-schema.org/draft-07/schema#",
  "type": "object",
  "properties": {
      "amount": {
          "type": "number"
      },
      "sometimesOptional": {
        "type": "string"
      }
  },
  "if": {
      "properties": {
          "amount": {
              "minimum": 1
          }
      }
  },
  "then": {
      "required": ["sometimesOptional"]
  }
}

Applying this schema to an empty JSON doc ({}) raises the following error:
jsonschema.exceptions.ValidationError: 'sometimesOptional' is a required property

Failed validating 'required' in schema['if']['then']:
    {'required': ['sometimesOptional']}

On instance:
    {}

Is this expected? It looks like in the absence of amount the if/minimum clause is considered valid. I checked the spec but could not find anything related to this particular edge case. I'm not sure what the correct behaviour is as I'm not very familiar with JSON schemas. In classic python or javascript testing if None or undefined was greater than 1 would raise an error... Anyway, I thought I might open an issue to know if it's a bug or just a quirk of schemas :)
As a side note, I think it worked in jsonschema 2.6.0 because I've had issues only since I upgraded to 3.2.0.
For now, as a fix, I added "required": ["amount"] in my if clause so that it's only enforced if the attribute is present.
Looking into the code of 3.2.0 it looks logical at least: the minimum validator returns None because the attribute is not found and I think the if validator checks if there was an error validating the schema so...
Thank you for your time and this amazing lib! :)

Hi!

Thank you for your time and this amazing lib! :)

Thanks! Glad you like it.

Is this expected? It looks like in the absence of amount the if/minimum clause is considered valid. I checked the spec but could not find anything related to this particular edge case.

Yes, both in the current spec and all previous ones. properties applies a schema only when a property is present. If it's not present, that doesn't make the schema invalid. Making the property need to be present is exactly what required is for, as you're using it -- maybe you meant to make amount required always?

Thanks for your answer!
I see! I want sometimesOptional to be required only if amount is greather than 1 (which in my mind implied amount was there in the first place so I guess adding required in my if close was the way to go. Except if there is a better way to say "if this field is defined" in a if clause?
As a side note, do you know why it worked differently before? The example above was valid in 2.6.0. (I understand it's more like a bug fix though).

As a side note, do you know why it worked differently before? The example above was valid in 2.6.0. (I understand it's more like a bug fix though).

As I mentioned, this didn't work differently before -- would have to see specifically what you're referring to to know what you were running -- but also, 2.6.0 was before draft 7 was out, 3.x was the first version to support draft 7 of the spec -- so if you're saying you were running a draft 7 spec on pre-draft 7 validators that may be a reason why it appeared to validate successfully.
Glad you've got it working now though.

Maybe it is, I'm not sure, that's old code. Anyway, the issue was definitely on my side :/
Sorry for that, and thanks for your help!


Send emails directly from the email tabs

Allow the emails to be sent directly from the email tabs.  To stop spamming or pushing things twice there should be some flag so trying to push for a second time creates some sort of warning.

code is committed, waiting for https://issues.apache.org/jira/browse/INFRA-22021 to move to production

done, live, https://github.com/iamamoose/Vulnogram/commit/afbbda42cdc45efbab6a9f8502b016c66f14e2ef


Document ability to pin images by digest

Problem description
Document the work done in https://github.com/docker/docker/pull/28173
Project version(s) affected
Engine 1.13
cc/ @nishanttotla

@joaofnfernandes how did this happen?

@joaofnfernandes I don't think it's a good idea to use commit messages that could have 'fixes' with a valid issue number in docker.github.io if that's not the issue the commit is talking about. I think that's what happened here, and I'm not sure how to check for other issues which may have been closed by this merge.

Closed via #531


captureContent should maybe work on content-types instead of urls?

A lot of times when you use phantomjs to load/render a page you have no idea what kind of URLs it loads. This makes it hard to block loading of video or large binary files while capturing other interesting bodies. In slimerjs captureContent works on the Content-Type instead of the url. Using this it's much easier to ignore videos and capture all javascript content for example.
I have already written a patch that we are using internally. Would there be interest if I created a pull request for this?
I know it would break backwards compatibility with the current implementation of captureContent. Maybe we could add it as a new property called captureContentTypes if this is an issue?

The only discussion I see on content-type versus url is https://github.com/ariya/phantomjs/pull/11484#discussion_r19300381 . I think URL was chose because it was easier to implement?

I like this idea in principle...

Changing the old property or adding the new captureContentTypes property?


Poll: Countries for in-text npl citations extraction/consolidation

Recent evidence from Bryan et al (2019) based on the US patent corpus suggest that front page npl citations and in text npl citations are partly unrelated.
In this context, we consider extending our dataset to in-text citations for non US countries. As usual, we want to be as useful as possible to the community. We will prioritize countries in leading positions in the poll below ⬇  - conditional on data availability.

The above list is restricted to the top 20 patent offices by number of all time patents reported in the GBQ Patents Public Data (patents-public-data:patents.publication). If you miss some important country for your research, feel free to spot it in comments, I will add it to the poll asap.

Hi,
Does the PatCit database cover citation made by the patents filed in the India patent office?
Thanks,
Sumit


Improved the progress slider. Also the pre-exisiting logs will be cle…

…ared on removing or adding new zip file. Fixes the issue #957.
Behaviour of slider before changes
https://www.opentest.co/share/d25d2c70d4cb11e68531cf81a6426bba
After changes
https://www.opentest.co/share/63aa3ed0d4cb11e68531cf81a6426bba
@mariobehling @aayusharora Please review. Thanks!!

Current coverage is 34.08% (diff: 0.00%)

Merging #958 into development will not change coverage

@@           development       #958   diff @@
=============================================
  Files                7          7
  Lines             1021       1021
  Methods            131        131
  Messages             0          0
  Branches           157        157
=============================================
  Hits               348        348
  Misses             673        673
  Partials             0          0

Powered by Codecov. Last update c3a4c5b...7266f93

Thanks LGTM @Princu7 please Squash the commits.

As there have been some changes, conflicts appeared.
Please help to resolve this. Thanks!

I made a mistake.


[Suggestion] Making enchanted books being useful again

Books are "removed" with this mods, as they don't spawn anymore. But I think it would be cool if we had a toggleable option to do the following:

Enchanted books spawn normally again
To level up your gear, you need: the actual item + lapis lazulli + the book with the desired level + essence of the enchantment
Essences would be less rare, and they would be consumed by each level up we do

Example:

If you want to enchant your pickaxe to fortune 1, but you only have the book for fortune 2, you can't upgrade it to fortune 1, as you need to find the fortune 1 book first.

I think this system would allow a lot more of progression and reward exploration and taking risks in dungeos with better loot even more.

The goal of the mod is precisly to remove enchanted books. But theire concept is kept, as any books that would drop are instead replaced with the coresponding(s) ingredients for the enchants in questions.
So the object is removed but it's utility is not.
I might, hower add suport for enchantaned books anyway, as big modpack may create new ways to aquire then that i can't entirely prevent.
Making them usable in place of the corresponding enchanting ingredient in the enchanting table is a good idea.

I would love to see this happen. I really like your concept but it's unfortunate how agressive it is against the enchanted book.
Now my datapack, Librarian's Balance, tries to work around the problems the enchanted book made with villagers. Essentially it makes villagers charge emeralds to make renewed copies of any enchantment book you craft, which is kind of like a 'save point' for an enchantment set. This gives them a use beyond trading. With your mod, it's impossible to have that functionality.
If you have to remove them from being naturally occuring then could you at least still make them craftable? Just to put a regular book in the tool slot and enchant it up. And then allow books to be combined into tools again because it wouldn't be such a big deal anymore. This would amend enchantment books and add compatibility for my mod too.

That's a good solution yeah.
I'll work onto that as soon as i've fix all the bugs of my "Config update".
Thank you for your suggestions.


Swift 3

This will make the project compile with Swift 3. As any Swift 3 migration this will be a big one.
It'll also include a rewrite of the Deferred<Result<T>> to the Task used in BNRDeferred, so buckle up!

I'm merging this, after creating issue https://github.com/BlurredSoftware/BSWFoundation/issues/4


Private conversation

Is there possible that slackbot starts conversation in private chat?

For now slackbot is "re-active", it responds to commands sent to it in direct messages or in channels.
I think client/server pattern is the most common usage pattern of chat bots: a real user send it some commands, and the chat bot does the predefined actions for the user -- Much like you push a button on a website in your browser.
That being said, I'd like to have the feature that the bot can start a  conversation pro-actively, which can be used to implement features like ifttt.

This is a must. For example, a good use of this feature is automatic status stand-ups:

Bot asks all developers same questions in private conversations, saves answers.
When bot gets all of the answers it posts status report update to the selected channel

In the above case the trigger for launching this behaviour should be some kind of a scheduler..

Once a private conversation has been initiated, is there a way to "keep listening" or expect a response?
I'm envisioning a conversation something like this:

me: @slackbot config plugin
slackbot: great! can you give me the value for foo?
me: bar
slackbot: Nice. Now can you give me the value for baz?
me: wat
slackbot: Oh no, wat is not an appropriate value for baz.

I know that slackbot currently can't initiate a private conversation...but is there a way to have behavior like the one above given existing functionality? Something like access to the stream of all messages in a conversation/channel?

that's a great idea @elbasti, to be able to "lock" the conversation to a certain function once activated, so more complex conversations can be developed. Now that python3 will be hopefully added to the master maybe some async trick could be used for that. :+1: I'll gladly help with that

@elbasti Good idea!
It would be an advanced but useful feature. It reminds me the official robot would ask a new member of the team to update his profile by asking him a series of questions like timezone, first/last name, etc.
I don't think I have time to implement this in the following weeks. So anyone who is interested, feel free to implement it. (Better come up with a design proposal before writing code).

I would also be interested in @elbasti's suggestion for a "conversation" bot, rather than one q/a. Subscribing.


Best way to handle 'nil' values as 'null' in json schema

Hello, thank you for the awesome library.
I am using this library to validate some events that are Ruby objects.
What would be the best way to handle treating ruby 'nil' values as 'null'.  There is an example here is in json-schema for a reference.
Thanks again!

Hi @Austio. I'm not sure exactly what you mean here. nil should already be treated as null:
>> JSONSchemer.schema({ 'type' => 'null' }).valid?(nil)
=> true
>> JSONSchemer.schema({ 'type' => 'null' }).valid?(1)
=> false

Or do you mean something else?

@davishmcclurg my mistake here, you are 100% right, i misinterpreted the error.
:tophat: for the code to validate and thanks again for your work on this library and help on issues.


Combine triangle and sawtooth oscillators and implement the "colour" param

It will become TriSaw or something like that. When colour is 0.5, it will be triangle. When colour is 0 or 1, it will be a sawtooth.

Moved to TODO file


sim:bluetooth build broken

This has not been triaged further, but this is the output running the sim target.
sim:bluetooth
❯ ./nuttx
ERROR: btnull_register() failed: -116

NuttShell (NSH) NuttX-9.1.0
nsh> uname -a
NuttX NuttX-SIM 9.1.0<PHONE_NUMBER> Oct 24 2020 12:48:16 sim sim

This is due to timeouts not waiting. The bluetooth CMD times out immediately. Also sleep 1 returns immediately.
@xiaoxiang781216 I believe you were working recently with timing in sim right?

This is due to timeouts not waiting. The bluetooth CMD times out immediately. Also sleep 1 returns immediately.
@xiaoxiang781216 I believe you were working recently with timing in sim right?

I think that SIM_WALLTIME should be enabled for this to run correctly with SIM_WALLTIME_SIGNAL=y

Enabling SIM_WALLTIME indeed makes the wait function as expected (although HCI initialization still fails). I would say that either SIM_WALLTIME=n is broken or it makes no sense to have it disabled if timeouts will not work.
Regarding bluetooth stack itself, I get the following:
bt_initialize: btdev 0x5648f0b60080
bt_hci_cmd_create: opcode 0c03 param_len 0
bt_buf_alloc: buf 0x5648f0b63590 type 0 reserve 0
bt_hci_cmd_create: buf 0x5648f0b63590
bt_buf_extend: buf 0x5648f0b63590 len 3
bt_hci_cmd_send_sync: opcode 0c03 len 3
hci_tx_kthread: started
hci_tx_kthread: Sending command 0c03 buf 0x5648f0b63590 to driver
btnull_send: Bit bucket: length 3
btnull_send: CMD: 0c03
bt_buf_alloc: buf 0x5648f0b63560 type 1 reserve 0
btnull_send: Send CMD complete event
bt_hci_receive: buf 0x5648f0b63560 len 5
priority_rx_work: list 0x5648f0b63650
priority_rx_work: buf 0x5648f0b63560 type 1 len 5
bt_buf_consume: buf 0x5648f0b63560 len 2
hci_cmd_complete: opcode 0c03
bt_buf_consume: buf 0x5648f0b63560 len 3
hci_reset_complete: status 0
bt_buf_release: buf 0x5648f0b63560 ref 1 type 1
bt_buf_release: Buffer freed: 0x5648f0b63560
bt_buf_release: buf 0x5648f0b63590 ref 1 type 0
bt_buf_release: Buffer freed: 0x5648f0b63590
hci_initialize: ERROR: BT_HCI_OP_RESET failed: -116
bt_initialize: ERROR:  hci_initialize failed: -116
ERROR: btnull_register() failed: -116

'SIM_WALLTIME=n' is not broken, it tries to run the simulation as fast as possible by driving the tick events from Idle Task. I agree with you that this is not ideal, this is the reason why I implemented 'SIM_WALLTIME_SIGNAL=y'.

I had this fix as part of my work on the nRF52 LL branch, while I was still using NuttX's stack.

'SIM_WALLTIME=n' is not broken, it tries to run the simulation as fast as possible by driving the tick events from Idle Task. I agree with you that this is not ideal, this is the reason why I implemented 'SIM_WALLTIME_SIGNAL=y'. @xiaoxiang781216 maybe we should make 'SIM_WALLTIME' option enabled by default. By looking at the bluetooth stack logs, it seems that you receive a cmd response for HCI_RESET. Why did it fail though ?

But you have to realize this is not the normal case and of course many things will break. I would set SIM_WALLTIME=y by default.

If the driver interact with the real device and can't work without the correct host timing, it should select SIM_WALLTIME in Kconfig like what SIM_X11FB and SIM_NETDEV have done.

But why not making it the default? There's more risk in default disabled than default enabled doesn't it?

Consider the large number of configurations that require this to work, you would have to go one by one and check.

But why not making it the default? There's more risk in default disabled than default enabled doesn't it?

I don't know why SIM_WALLTIME isn't default. Maybe SIM_WALLTIME is added later, and the owner want to keep the old behavior.

Consider the large number of configurations that require this to work, you would have to go one by one and check.

But we don't need to check all defconfig in boards/sim/, because if you add 'select SIM_WALLTIME' inside 'config SIM_HCISOCKET', kbuild will automatically enable CONFIG_SIM_WALLTIME if some defconfig enable CONFIG_SIM_HCISOCKET.

@sebastianene07 do you see a problem in having this enabled by default?
If SIM_WALLTIME=n means sleep 1 returns immediately I would change this to y by default. Otherwise if with n sleep should still work, then we have another problem.

@sebastianene07 do you see a problem in having this enabled by default?
If SIM_WALLTIME=n means sleep 1 returns immediately I would change this to y by default. Otherwise if with n sleep should still work, then we have another problem.

I think that we should keep this enabled by default. There are many features that depend on this timing.

I also don't see any reason in this case to not change the default to enabled. The worst impact is a test runs long and we can explicitly disable it for that test.  Im thinking an OS interface test were time bounds might be being tested.

It should be easy to create a test that kill nuttx in that case.
@sebastianene07 could you open a PR to change the default and refresh all sim configs?

It should be easy to create a test that kill nuttx in that case.
@sebastianene07 could you open a PR to change the default and refresh all sim configs?

I created a pull request here https://github.com/apache/incubator-nuttx/pull/2116
This enabled the option by default from Kconfig.

Enabling SIM_WALLTIME indeed makes the wait function as expected (although HCI initialization still fails). I would say that either SIM_WALLTIME=n is broken or it makes no sense to have it disabled if timeouts will not work.

Yeah I reverted back to commit 8934f2ed79c0e2fe6e94b4116f924444cc7dbe12 and it works fine, so I think some of the bluetooth stack changes after broke this.

Ok, I'll take a look

@v01d Have you had a chance to look into this?  I think the BLE issues are some of the last remaining that I know of for the 10.0.0 release.

Sorry, no. I'll see what I can find later today

@btashton I'm confused, did you apply the fix I linked to this PR? It went much further ahead during initialization for me than what you last copied.

From what I'm seeing this is something that will not ever work with bt_null. The command that is failing is LE_ENCRYPT, which should encrypt the passed data and return it as part of the return parameters of the CMD COMPLETE HCI command. bt_null simply returns generic CMD COMPLETE events without return parameters for any unhandled opcode, so the BT stack chokes when this does not contain the expected response. I don't see how this could have worked before, unless something else was wrong and hiding this problem.
I'm not sure what would be the best way to deal with this, I don't think it makes much sense to be testing such a stub driver.

Sorry I think I'm mixing the two ble tickets (I think they are related).  The HCI socket is still broken on master as I posted above and works fine if I revert back the new bluetooth changes.

Well, regarding this issue, as I mentioned I think we may have to close it with "wontfix" and maybe even remove that config as it will never work as is.
Regarding the bthcisock, 10.0 works for me. Maybe there's something strange with your BT stack or BT adapter.

There is nothing wrong with my adapter. Look at the log I posted it is not handling the most basic completion event. Plus it works prior to the recent changes.

I was confused because that issue was marked as blocker for 10.0 and on 10.0 there's no problem, but indeed I see it on master. I'll update any findings there (you can remove the blocker tag in the mean time).

This smp functionality can be disabled by a config flag.  This PR disables it now https://github.com/apache/incubator-nuttx/pull/2305

Ah, that's better.


Timing not working in miragejs server instance

Bug
Expected behaviour:
this.timing = 10000
Slows down and allows me to get data with a bit of "loading".
Current behaviour:
Responds with data right away.
routes() {
  this.namespace = "api"
  this.timing = process.env.NODE_ENV === "development" ? 9999999 : 400
  this.get(/users, (schema)=>schema.all("user")) // returns the list right away

}

I've tried:
I've checked and console.logged the value that goes with the server and it's proper (9999999).

This was fixed in this commit in mirageJS https://github.com/miragejs/miragejs/commit/f68581a1b56c4d3e5efcee94641fa761fd3add60. It just hasnt been released yet.


fix(signup): Fix loopback async issue

Hey @BerkeleyTrue are we going to support npm@5? As per the addition of package-lock.json. I think it would be good to have.

Yes I've used it long enough now. The lock file is definitely a huge benefit. I've added it here mainly to speed up issues like this.
Mind giving this a merge?

Sure, thanks for the update.


Add Features

Hello, Can You Add Encryption Feature of All Drives Like C:\ D:\ and Others

This feature is already present here.
However, at the moment the decryptor does not work if this function is enabled, I will try to fix it as soon as possible


feat: dashboard setup

Added initial approach for Dashboard according to requisites
Implemented unit tests for Dashboard components
Added and configured routing
Added some dummy pages to check routing and Dashboard outlet
Added prettier to the project for code format consistency
Installed styled components

Did you add tailwind? @fracergu

Hi @devvspaces
Not yet, because I saw it subsequently to opening the PR and I didn't know if I was going to go ahead with it. Give me a moment and I'll replace styled-components with it.
I also have other suggestions for the frontend project, which would be a good time to implement since it still has very little content and would not be expensive:

Replace create-react-app with vite. Vite is a packer that I see more appropriate and efficient for this application since it will not require excessive configuration and it will not have a large size, we could take advantage of its greater speed: more information here

Use typescript. Typescript has static typing that helps the compiler make sure that the code is correct. On the other hand, in JavaScript, no errors are detected by the compiler because it's dynamically typed.

These changes will make it more attractive to potential contributors and the frontend will be equipped with more cutting-edge technology, which will make its use and development much more efficient.
I could implement them after this PR without complications, if they are suitable, you can open an issue for it.

Yo, no need

I think styled-components is ok

Typescript and vite use it @fracergu

As you prefer!
I already have the tailwind implementation ready as well. We can go ahead with whatever you prefer. I'm used to work with both and tailwind might be a bit more attractive for contributors, if you want we'll leave it with tailwind. 😉

@devvspaces
Here is the current status of the application with Tailwind and routing.
I haven't bothered much with the aesthetics because I think that should be addressed later in another issue. As you will see, the dashboard works correctly with its internal routing outlet.
Grabación de pantalla desde 2023-10-22 10-50-23.webm

@fracergu have you done the Vite migration or do i need to create an issue

@devvspaces, no I didn't, please open an issue and assign it to me.

@fracergu comment here #27


Update changelog

Some of the commit messages in the git log were a bit hard to follow, so
I'm not sure I got it all in correctly, but it is definitely better than
what was here before.

I think you got it all. I actually forgot that we kept this log.

Thanks for merging! This is really helpful for people who want to upgrade without breaking things.

Cool. Let me know if you run into any issues after upgrading!


Fix VMSnapshot + Manual RunStrategy

What this PR does / why we need it:
Runstrategy Manual + VM stopped would result in VMSnapshot hanging until VM started
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #9944
Special notes for your reviewer:
Release note:

NONE

also you write in the description: VMSnapshot hanging until VM started but as long as the snapshot is in progress you cant start the VM

also you write in the description: VMSnapshot hanging until VM started but as long as the snapshot is in progress you cant start the VM

That is not what I just observed with mainline code

/approve


HSEARCH-3290 Search 6 groundwork - Finalize the Search DSL syntaxes

https://hibernate.atlassian.net//browse/HSEARCH-3290
Best reviewed commit by commit, as some of these commits are just renamings and introduce a lot of noise. And best reviewed in the topological order, i.e. not the order GitHub displays commits in...
Here is a summary of what this PR brings:

It removes the fluent ("fluid") syntax from the predicate/sort DSLs, as we agreed to during the face-to-face meeting, in order to reduce the confusion. Only the object-based and lambda-based syntaxes remain.
It renames the .end() methods in the predicate/sort DSLs to toPredicate()/toSort(), as we agreed to during the face-to-face meeting.
Additionally, it changes the lambda syntax substantially in order to avoid confusing contexts when nesting predicates with the lambda syntax. See commit HSEARCH-3290 Remove any notion of "position in the predicate tree" fr… and its commit message for details.
And finally, it allows to pass SearchPredicateTerminalContext to DSL methods such as must(...) or .except(...), in order to reduce the verbosity of the DSL. It's a bit dangerous in my opinion, as it may lead people into using SearchPredicateTerminalContext to model cached predicates instead of SearchPredicate, but it's far less dangerous now than it used to be: before item 4., it could lead to unpredictable results, especially when using the cached predicate at different locations of the tree; now it's just sub-optimal (as we would keep references to DSL context objects that are no longer needed).

Pull Request Test Coverage Report for Build 1

217 of 222 (97.75%)  changed or added relevant lines in 58 files are covered.
2 unchanged lines in 2 files lost coverage.
Overall coverage decreased (-0.09%) to 86.606%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

engine/src/main/java/org/hibernate/search/engine/search/dsl/predicate/impl/BooleanJunctionPredicateContextImpl.java
20
21
95.24%

engine/src/main/java/org/hibernate/search/engine/search/dsl/query/impl/SearchQueryPredicateCollector.java
8
9
88.89%

engine/src/main/java/org/hibernate/search/engine/search/dsl/sort/impl/RootSearchSortDslContextImpl.java
13
16
81.25%

Files with Coverage Reduction
New Missed Lines
%

engine/src/main/java/org/hibernate/search/engine/search/dsl/predicate/impl/NestedPredicateContextImpl.java
1
92.31%

engine/src/main/java/org/hibernate/search/engine/search/dsl/predicate/impl/BooleanJunctionPredicateContextImpl.java
1
91.67%

Totals

Change from base Build 46:
-0.09%

Covered Lines:
11225

Relevant Lines:
12961

💛  - Coveralls

Merged, thanks!


arty-a7: add UART harness

Signed-off-by: Alessandro Comodi<EMAIL_ADDRESS>

Replaced by https://github.com/SymbiFlow/prjxray-db/commit/85022780e809fa405ff7aefd09d085fbe3dac8b2


need to recompile with the new version of mudblazor

Because of https://github.com/MudBlazor/MudBlazor/pull/4639 , the extension cannot run with the new version of mudblazor.

Please update the nuget package dependencies and recompile the release

done 1.3.0


Reduce tolerance for Identify KML sample

Identify tolerance was probably a little too high for the given map.

Identify KML features -WPF only: Unhandled exception - 'Invalid argument: Target extent is empty'
I am getting the above error for WPF only.
It is working perfectly fine in other platforms.

@pragatisahu I think I've fixed the issue, can you please retest?

using Esri.ArcGISRuntime.Geometry; is missing in WPF-fix.


*: use operator.Builder to create operators

What problem does this PR solve?
Close https://github.com/pingcap/pd/issues/1959
What is changed and how it works?

Create*Operator switch to use builder
fix tests

Check List
Tests

Unit test

Related changes

Need to be included in the release notes

Codecov Report

Merging #1984 into master will increase coverage by 0.28%.
The diff coverage is 75.49%.

@@            Coverage Diff             @@
##           master    #1984      +/-   ##
==========================================
+ Coverage   77.16%   77.44%   +0.28%
==========================================
  Files         177      177
  Lines       18132    17997     -135
==========================================
- Hits        13991    13938      -53
+ Misses       3044     2986      -58
+ Partials     1097     1073      -24

Impacted Files
Coverage Δ

server/schedulers/shuffle_leader.go
88.23% <100%> (+6.98%)
:arrow_up:

pkg/testutil/operator_check.go
100% <100%> (ø)
:arrow_up:

tests/pdctl/helper.go
100% <100%> (ø)
:arrow_up:

pkg/mock/mockcluster/mockcluster.go
90.47% <100%> (ø)
:arrow_up:

server/schedulers/grant_leader.go
73.71% <100%> (+0.45%)
:arrow_up:

server/schedule/checker_controller.go
91.3% <100%> (ø)
:arrow_up:

server/schedulers/balance_leader.go
90.71% <25%> (-1.99%)
:arrow_down:

server/schedulers/hot_region.go
87.01% <25%> (-1.73%)
:arrow_down:

server/schedulers/label.go
74.24% <25%> (-3.54%)
:arrow_down:

server/schedulers/adjacent_region.go
75.4% <25%> (-1.23%)
:arrow_down:

... and 27 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 47533aa...58641e9. Read the comment docs.

/merge

/merge


[Neighborhood finder] Looking up a specific address errors out

Bug
Looking up 1768 Union Street on the Neighborhood finder displays an error. The endpoint it hits  /api/geo/address-metadata, returns a 500 with an error log of Address couldn't be found.
This address is valid in Brooklyn, so we should look into why this address cannot be found.
Server logs on prod (should be similar to dev):
2020-11-05T01:03:10.432892+00:00 app[web.1]: TypeError: Cannot read property 'geometry' of undefined
2020-11-05T01:03:10.432901+00:00 app[web.1]: at exports.addressHandler (/app/src/api/neighborhood-finder/get-address-meta.js:35:9)
2020-11-05T01:03:10.432901+00:00 app[web.1]: at runMicrotasks (<anonymous>)
2020-11-05T01:03:10.432902+00:00 app[web.1]: at processTicksAndRejections (internal/process/task_queues.js:97:5)
2020-11-05T01:03:10.433491+00:00 app[web.1]: POST /api/geo/address-metadata 500 148 - 239.425 ms
2020-11-05T01:03:10.433597+00:00 app[web.1]: Address couldn't be found

Expected behavior

Endpoint should return a 400 instead of 500 with an error message describing that the address cannot be found.
UI should display the informative error message

Hi @piratefsh, I took a look at this issue and was not able to replicate the behavior for 1768 Union Street in neither prod or on my local dev instance. I don't yet have permissions to view prod logs but the post to /api/geo/address-metadata returns a 200 in my dev. When you are able, could you please attempt looking up 1768 Union Street on the Neighborhood finder again to see if the issue persists? Thanks.

Hi @piratefsh, I took a look at this issue and was not able to replicate the behavior for 1768 Union Street in neither prod or on my local dev instance. I don't yet have permissions to view prod logs but the post to /api/geo/address-metadata returns a 200 in my dev. When you are able, could you please attempt looking up 1768 Union Street on the Neighborhood finder again to see if the issue persists? Thanks.

Hi @jconard3, thanks for looking at this! It appears that the issue no longer persists with this address. You can still replicate this when an invalid address is entered, e.g. sjnjkgjkgs (keyboard smash a random string).
Right now we return a 500, which just displays an unhelpful message Error loading. Please try again. If it fails again, let us know in #wg_tech. We should be returning a 4xx error to indicate that the address is not found (and not a server error) and display a more helpful message.
We can definitely still use help with issue.

Hi @jconard3, thanks for looking at this! It appears that the issue no longer persists with this address. You can still replicate this when an invalid address is entered, e.g. sjnjkgjkgs (keyboard smash a random string).
Right now we return a 500, which just displays an unhelpful message Error loading. Please try again. If it fails again, let us know in #wg_tech. We should be returning a 4xx error to indicate that the address is not found (and not a server error) and display a more helpful message.
We can definitely still use help with issue.

Here's a screenshot of an example address that could not be found. This is on prod but should be the same on dev. Do let me know if you have issues replicating this as well.

Here's a screenshot of an example address that could not be found. This is on prod but should be the same on dev. Do let me know if you have issues replicating this as well.


Update ru.json

Hi vanja-san,
I don't know if you'll get a notification for this message but I haven't found any contact info on your profile (twitter, email...) so I'll try it here. Just wanted to let you know that I'm working on a new version of the program with some new tools and changes to the old ones and there are already a bunch of new keys in the localization files, in case you want and have the time to update the Russian localization one some day (to make it easier to find the new keys, I've marked them as [NEEDS TRANSLATION]).


Improve readability of error messages

Current colors (white text on red background) make it quite hard to read the error messages

A darker red would be better here, we still generally associate red with errors but more contrast would be ideal. Maybe bolder text too. Here's an example with hex value #B20000:


Add bower as install source in README.md

bower is not supported

https://github.com/sroze/ngInfiniteScroll/pull/293

Bower users must have npm installed anyway, they can install and use the package with npm from the ./node_modules directory.


Get repo

coverage: 100.0%. remained the same
when pulling e8d1c9228de4eec6a56e86017003b525d7420552 on get_repo
into 71194cf3478a79c8b21085228a3df6f99f637ddb on master.


liars poker

As per @richdewey we have added liar's poker to the games folder.

Closing as we imported a python version of the game.

Closing this now since a Python implementation has been contributed. Please reopen if you intend to continue.


noticed some big undocumented changes

It seems like we have to use index as method name instead of indexAction in Symfony 4?
Also make fails because it can not be used on/ is not available on Windows but Symfony tries to execute it (running Git Bash on Windows which uses Mingw64).
~And in the cache directory I found some de_ next to the dev directory (and saw a message about Kerne_) and the namespace is App instead of AppBundle.~ (probably forgot one cache command)

It seems like we have to use index as method name instead of indexAction in Symfony 4?

This is not a SF4 issue, this is about the routing system, allowing us not to add the suffix Action to controller methods when using annotations or controller as services.

Also make fails because it can not be used on/ is not available on Windows but Symfony tries to execute it (running Git Bash on Windows which uses Mingw64).

For the makefile, I tried my best to find the possible issues with the Win32 version of GNU make, but couldn't find what's going on. Make is available on Windows, but it is not exactly the same as 100% unix one. And Windows doesn't use unix commands like rm -rf for clear-cache for example. So I think the makefile will never be compatible with windows, and we'll have to either refactor it manually, or consider not using it on Windows at all. Or use Bash On Ubuntu On Windows, or Cygwin, or Mingw, or any unix emulator, and it'll work like a charm.

And in the cache directory I found some de_ next to the dev directory (and saw a message about Kerne_) and the namespace is App instead of AppBundle.

About de_, I think it's because the cache:clear command warms up the cache and therefore create other directories for this, this is something that should disappear when SF4 comes up, because the --no-warmup will be implicit in SF4 when clearing the cache.
About the namespace, it has changed because there is no default bundle in the SF4 / Flex structure, which is quite obvious when creating a project with Flex & Symfony.
The fact that the namespace is App instead of an empty one is because having a configured namespace in psr-4 directives in composer.json gives a boost to performances contrary to the use of "": "src/" or other empty psr-4 directives.
Any nice IDE with PHP & Composer features will automatically understand the namespaces.
These are not "big undocumented" changes. The "no-warmup" deprecation has been announced in the blog, Flex structure is not completely documented because it's still in alpha, therefore possibly subject to changes, and the action suffix is just a native Symfony feature since years ago. And for the makefile, I don't know why there would be documentation. Just type "makefile documentation" on any search engine and you'll end up with thousands of pages, because makefiles have been existing for years.

What about shelljs for the make commands? https://github.com/shelljs/shelljs

This is not a SF4 issue, this is about the routing system, allowing us not to add the suffix Action to controller methods when using annotations or controller as services.
But it works just without Action or does it just work with Action when we switch to annotations? Because it did not work this way.

About the namespace, it has changed because there is no default bundle in the SF4 / Flex structure, which is quite obvious when creating a project with Flex & Symfony.
The fact that the namespace is App instead of an empty one is because having a configured namespace in psr-4 directives in composer.json gives a boost to performances contrary to the use of "": "src/" or other empty psr-4 directives.
Any nice IDE with PHP & Composer features will automatically understand the namespaces.

Right, I miss this bit of information in the SF4 blogposts and master docs ;-)
I just meant that the de_ dir which was left was a bit weird. We already found both commands and used them but this directory was still there in one case.

What about shelljs for the make commands? https://github.com/shelljs/shelljs

I'd say "no way", adding a node.js layer just for commands sounds like an overhead to me. Make is standard in all unix-based systems, and Windows can handle unix-based systems too via Cygwin, Mingw or WSL.

But it works just without Action or does it just work with Action when we switch to annotations? Because it did not work this way.

Routing annotations & routing with controller as services accept the full method name. Only the Bundle:Controller:method need method to be named methodAction() in the controller class.

I'd say "no way", adding a node.js layer just for commands sounds like an overhead to me. Make is standard in all unix-based systems, and Windows can handle unix-based systems too via Cygwin, Mingw or WSL.

You are right but I guess we also have a solution for composer.
Mingw is used by the Git Bash as I stated in the initial comment but the make command is not available there.

Only the Bundle:Controller:method need method to be named methodAction() in the controller class.

Isn't this the case in the default config when I comment the first few lines in?

It's just a behavior from the cache:clear command when --no-warmup is not specified.

Ok, so it was probably some remnant of a previous execution where this was forgotten?
Hm, so this line https://github.com/symfony/recipes/blob/master/symfony/routing/3.3/config/routes.yaml#L3 has nothing to do with indexAction and wants index? Just to be clear, this only worked with index and not indexAction.
Thanks for answering my questions so far.

At least it is not a great solution with the make file. I' research further and hope to find some solutions that we could use instead of make.
https://packagist.org/packages/tivie/command
https://github.com/MrRio/shellwrap

Hm, so this line https://github.com/symfony/recipes/blob/master/symfony/routing/3.3/config/routes.yaml#L3 has nothing to do with (...)

It's using the services syntax, because the controller is automatically registered as service in default Flex project, and the service name is the FQCN, so this syntax is the service one, and the method name should then be index().

At least it is not a great solution with the make file. I' research further and hope to find some solutions that we could use instead of make.
https://packagist.org/packages/tivie/commandhttps://github.com/MrRio/shellwrap

These packages add more coupling to the project.
I'd like more something that would be a single composer script, like composer make ... for example, but same, it's not the best option either because it also adds coupling to another script.
There are only two solutions:

Keep the Makefile as-is, and forget about native Windows compliancy (too much work)
Spend hours/days/weeks/months/years maintaining a makefile that would be compatible with Windows

I'd go for 1.

Thanks for the clarification. Makes much sense as it is now provided as a service.
You are right regarding Windows support, not easy. I had hopes to have better support on Windows 10.

@DanielRuf The fact that we have WSL is a form of better support 😉

For sure = )


Cronitor Kubernetes Agent log format

Hi Team,
The agent works great but I was wondering if we could enhance the formatter to spit out json instead of txt or the loglevel via variables in the values file.
Thank you!

Thanks for the comment! I'm sure we could make adjustments, but would you mind clarifying what it is you're looking for? Is it to have the logs be JSON output instead of text, and then adjust the log level via values.yaml?  (Log level via values.yaml is coming!)

json log format would be really useful


Feat/built in linter

As described in #1037
Pylint library selected as optional
Shows errors and warnings

UPDATE:

pylint is not provided and not mentioned in poetry as it is not treated as optional. User should install pylint on their own pick the version that best suites their environment.
pylint log warnings and errors only - ignores all PEP suggestions, refactor suggestions and import errors (ie. missing splunk platform libs)
smoke test mocks pylinter thus the library is not required for testing

should the title be chore: add build-in linter?


Add certificateAuthority field in structured authn docs

Add certificateAuthority in structured authn docs for v1.30 release.

KEP issue: https://github.com/kubernetes/enhancements/issues/3331
/sig auth
/assign enj

Closing as per https://github.com/kubernetes/website/pull/45811#issuecomment-2046230046.
/close


Add a property of table name to the migration stubs

In the early days of the project, more is the rename table, instead of writing a new migration file.
I think most developers do this, this will make it easier for us to develop.
I have tested the code, it can working.
Forgive my poor English.

A migration doesn't have to be tied to a single table.

@lagbox
Will, i didn't meet this situation, maybe I don't have enough experience.
Please close this pull request.
Thank you for your reply.

No plans to add this right now.


Allow section titles to be hidden inline

@hossainemruz I wanted to be able to hide the title for certain sections. What is the best way to have them enabled by default so the user doesn't need to set showTitle?

Can you please explain the use-case?

I wanted to show some of the sections without title as they are somewhat obvious. For example, the projects section is pretty clear as is the achievements section at the bottom. The achievements section is very graphical and interactive. The title didn't always fit with the images. It was just a styling preference for some cases.

Ok. Then, make showing title default behavior. Use hideTitle  instead of showTitle.

I was trying to match up with showOnNavbar. I am running into something similar with title showing up in the footer. I would like to use showOnNavbar, showOnSection and showOnFooter. What do you think?

I would like to use showOnNavbar, showOnSection and showOnFooter.
I don't think we should add new variable for footer. If it was not shown on the navbar, then don't show in the footer too.

I have updated the PR per the conversation above. Should be ready

@blueyetisoftware Looks good so far. I will merge after some testing.


Very slow upload

I'm getting very strange results
$ speedtest-cli
Retrieving speedtest.net configuration...
Testing from Telefonica de Espana Static IP (<IP_ADDRESS>)...
Retrieving speedtest.net server list...
Selecting best server based on ping...
Hosted by ServiHosting Networks (Madrid) [16.00 km]: 4.434 ms
Testing download speed................................................................................
Download: 621.67 Mbit/s
Testing upload speed......................................................................................................
Upload: 4.16 Mbit/s

Using web based speed tests, I get 600 Mbps upload
This happens both in my desktop and laptop computers (using linux), but surprisingly on a raspberry pi4 I get 600/600.
All tests using ethernet cable connected directly to the router
I see there were similar issues in the past and closed without any solution.
The readme says:
Issues relating to inconsistencies will be closed as wontfix and without additional
reason or context

But I think this is worth to investigate

I've removed the package installed from apt (using latest linux mint) and installed using:
wget -O speedtest-cli https://raw.githubusercontent.com/sivel/speedtest-cli/master/speedtest.py
This time I get:
$ ./speedtest-cli
Retrieving speedtest.net configuration...
Testing from Telefonica de Espana Static IP (<IP_ADDRESS>)...
Retrieving speedtest.net server list...
Selecting best server based on ping...
Hosted by ServiHosting Networks (Madrid) [16.00 km]: 4.535 ms
Testing download speed................................................................................
Download: 622.00 Mbit/s
Testing upload speed................................................................................................
Upload: 606.33 Mbit/s

I don't know why the apt package performs so bad, performs a note in README warning about this would be useful

@pladaria i think the issue is related to https://github.com/sivel/speedtest-cli#inconsistency
Anyways fyi, use SpeedTest++ and you will get correct results...


[Issue]: nvm install latest runtime error

What happened?
I'm on Windows 11 22H2 22621.2134 trying to execute "nvm install latest" or "nvm install 20.6.0".
What did you expect to happen?
I expected nvm to install specified node version for me.
Version
1.1.10
Which version of Windows?
Windows 11+
Which locale?
Other Non-English
Which shell are you running NVM4W in?
ConEmu
User Permissions?
Administrative Privileges, Elevated
Is Developer Mode enabled?
No (Default)
Relevant log/console output
panic: runtime error: index out of range [3] with length 3

goroutine 1 [running]:
main.checkVersionExceedsLatest({0x1398e180, 0x6})
        C:/Users/corey/OneDrive/Documents/workspace/libraries/oss/coreybutler/nvm-windows/src/nvm.go:875 +0x220
main.install({0x1380e198, 0x6}, {0x509d26, 0x2})
        C:/Users/corey/OneDrive/Documents/workspace/libraries/oss/coreybutler/nvm-windows/src/nvm.go:308 +0x337
main.main()
        C:/Users/corey/OneDrive/Documents/workspace/libraries/oss/coreybutler/nvm-windows/src/nvm.go:87 +0xaea

Debug Output
Running "nvm debug" just gives me the same output as simply running "nvm" (list of available commands).

Anything else?

You need to upgrade. This runtime error was resolved in NVM for Windows 1.1.11. Duplicate of #955.


Units and translation

I am trying to work out what units the PDF is using, I want to translate the information into mm.
I'm using a module called pdf2json which as far as I can tell is based on PDF.js, I think this node module is no longer supported as there doesn't seem to be any feed back from the author in recent months....here is my post which I hope will mean something to people here and hopefully someone can help me....please?
https://github.com/modesty/pdf2json/issues/133

Support of pdf2json is out of scope of this project. But based on https://stackoverflow.com/questions/42494394/pdf2json-page-unit-what-is-it, it's about 24px. Converting px to mm is device specific and purely subjective. Closing as answered.


lodash.assign dependency

Hi, any chance you can replace lodash.assign dependency with object-assign as in gulp-header - I'm having problems using it on Windows (too much subfolders in lodash.assign and Windows doesn't like more than 260 characters). Thanks.

Just a heads up. lodash v3 has significantly reduced the dep graphs of its modularized packages:
<EMAIL_ADDRESS>├─┬<EMAIL_ADDRESS>│ ├──<EMAIL_ADDRESS>│ └─┬<EMAIL_ADDRESS>│   ├──<EMAIL_ADDRESS>│   ├──<EMAIL_ADDRESS>│   └──<EMAIL_ADDRESS>└─┬<EMAIL_ADDRESS>  ├──<EMAIL_ADDRESS>  └──<EMAIL_ADDRESS>
There's even a simplified form:
<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>└─┬<EMAIL_ADDRESS>  ├──<EMAIL_ADDRESS>  ├──<EMAIL_ADDRESS>  └──<EMAIL_ADDRESS>


Vintl01_10x16 fixed font not displaying correctly

I don't find the default large font (used for the clock) easy to read, so I changed the large font in the pages file to Vintl01_10x16_fixed.fnt, in place of BigFont.  The Vintl font already exists in displays/fonts.
Unfortunately, some portions of the time are rendered as question marks.  There are no errors in the log file.
I'm using v0.31 alpha on a Pi 3B+ with Moode Audio.  Otherwise not had any problem configuring the display (44780_i2c, 20x4).
Am I missing a step?  And/or are there other suitable large (perhaps even larger?) fonts I could use?

Thanks for the reply.
It's only being asked to the time, and parts of the numbers are showing.  It's mostly the lower half that has question marks.  According to the png file, the font has numbers in it, so that's why I'm wondering if I've missed a step.  Does the Vintl font need to be treated differently to the BigFont font?


ChartPointViewBarStacked: allowing only rounding some corners

Example:
ChartBarViewSettings(
                cornerRadius: barWidth / 2.0,
                roundedCorners: [.topLeft, .topRight]
            )

Thanks! Would it be possible to get this working for the plain bars too? They also use ChartBarViewSettings and if you pass the settings you posted, will round all the corners.
Besides of this I wonder if we should add some "magic" to transpose the corners for vertical / horizontal bars. When you pass [.topLeft, .topRight] to horizontal bars it will round the top corners of the view, which is likely not what the user wanted in this case (you could for example have a chart that allows the user to toggle between horizontal / vertical, and it seems awkward having to change manually the bars settings for this). This is not very important though.

Would it be possible to get this working for the plain bars too? They also use ChartBarViewSettings and if you pass the settings you posted, will round all the corners.

@i-schuetz thanks, I haven't been able to do what you suggested, but maybe this could be merged as is, and let someone else (or me if I need this in the future) work on that?

Besides of this I wonder if we should add some "magic" to transpose the corners for vertical / horizontal bars. When you pass [.topLeft, .topRight]

Yeah that would be good. I'll try to do that at some point, but for now it doesn't seem "wrong" to not be as smart.


[Chip] Correct Chip Typescript Definition Class Keys

[x] I have followed (at least) the PR section of the contributing guide.

@oliviertassinari It's not matching https://next.material-ui.com/api/chip/#css anymore. It's missing clickableColor*.

Oh wrong IDE transformation 😱 thank you!

I'm fixing the missing description.


Update changelog with recent PR merges, and fix #38

This will update the changelog to reflect the merges from:

#36 / #27
#25
#26
#32
#34

And fixes #38 to correct the repository link in Cargo.toml

We just need to land #25 before we can merge this.

@eldruin
Think we are ready for a release PR after this has passed CI


[Test only] 0.9.1 test

This branch is for testing changes that are planned to be included in version 0.9.1.

Should I upload a build of this branch to Debian unstable to get people test it?

Good idea. But let's test it for ourselves first. I started seeing reconnect issues with VNC. Let's try to fix it before giving this code to Debian testers.

Now we can upload this branch to Debian unstable. Please make sure to use --enable-painter to enable the new noorders functionality.

I think we should also include #539

Update to the current remaining PRs. No more fixups, everything is in PRs.

All patches have been applied, the "devel" branch can be used for testing now. Closing this PR.


How to keep cell formatting while adding cell from one sheet to another sheet?

How to keep cell formatting while adding cell from one sheet to another sheet?

@serin-github We will look into this feature-request soon.


Add negative caching tests and fixes.

This adds test coverage for the negative caching feature and makes some
fixes as a result of the test's findings.

[approve ci autest]

Am I missing the tests that the commit message talks about?

Am I missing the tests that the commit message talks about?

Oh, good catch. That comment is a copy and paste from the master PR comment that contains the test:
https://github.com/apache/trafficserver/commit/8eb68266167d8f8b3fa3a00ca9f6b7889e8ec101#diff-ee4f5dc00b390358f90ea4edbaa09f0130c95c646920fa25c9c0af9f72407533R1
That test cannot be ported over into 8.1.x nor 7.1.x because it uses Proxy Verifier which is not supported in the AuTest extension in those branches.


Add output manifests

Types of changes

[X] Enhancement (project structure, spelling, grammar, formatting)
[ ] Bug fix (non-breaking change which fixes an issue)
[X] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

A description of the changes proposed in the Pull Request

@MariamKhalatova, I noticed that some files in the manifest folder (all files in the bugs and features folders) have been removed but at the same time they have output files in the outputs folder. Was that done by mistake?

@manushak @MariamKhalatova  yea this is ok - the examples folder is really just demo manifests for people to see how to implement our builtins and some common patterns - the outputs folder is more comprehensive and is intended to have larger coverage to uspport automated testing.