Styles/update landing page

Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Please mark relevant issues as closed/resolved here.
Please include a screenshot of relevant change if helpful.
Type of change
Please delete options that are not relevant.

[ ] Bug fix
[ ] New feature
[ ] Refactor
[ ] Documentation

How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration.

[ ] Developer Tools
[ ] Cypress
[ ] CI

Is it intentional the count down doesn't show if one is set?

Yes, it wasn't in the other website.

Reviewing now!

Would you mind posting screenshots so I can see what the end result is? I was about to clone & run this, but realized I'm incredibly tight on time. Also keep in mind the goal of this project is to be maximally bland + easy to modify. The goal of fork and modify is a primary goal of the overall project, so I don't want people to unwind too much.

Sure, here's the screenshot:

Let me know if there's any changes you'd like.

Sure, here's the screenshot:

Let me know if there's any changes you'd like.

This looks great, but I don't want to feature a specific project. Would you mind turning this into something more generic with placeholders?
(And full transparency, I've used this to launch other projects & kept their brands out of it too :))

Sure, here's the screenshot:

Let me know if there's any changes you'd like.

This looks great, but I don't want to feature a specific project. Would you mind turning this into something more generic with placeholders?
(And full transparency, I've used this to launch other projects & kept their brands out of it too :))

Sure, I'll just place generic images and text.
If you want I can make a file which you just enter the relevant text and images and then it generates the react code for you?

@willflemmer when running yarn build or yarn start.
candy-machine-mint/src/Home.tsx
TypeScript error in candy-machine-mint/src/Home.tsx(172,9):
Object is possibly 'undefined'.  TS2532

@willflemmer when running yarn build or yarn start.
candy-machine-mint/src/Home.tsx
TypeScript error in candy-machine-mint/src/Home.tsx(172,9):
Object is possibly 'undefined'.  TS2532

Should be fixed now. Let me know if there's anything else

@willflemmer , ConnectButton doesn't render since wallet is falsey.

@levicoo attached the current look, no specific project in the template.
React App.pdf

@ohaddahan buttons now display correctly.

@willflemmer works, thanks!

After connecting the wallet to an empty candy machine, the "Sold Out" message flashes quickly and disappears. I had to refresh the page to see that.

Extra gap in navbar


Refactor code to fix SwiftLint warnings

This PR is a follow-up to #195. This makes the code more readable, fixes swiftlint warnings introduced by #195 and reverts some whitespace changes #195 introduced.
There should be no changes in behaviour.

Warnings

:warning:

Any changes to library code should be reflected in the Changelog.
Please consider adding a note there and adhere to the Changelog Guidelines.

:warning:

Sources/Danger/Plugins/SwiftLint/SwiftLint.swift#L125 - Function should have 5 parameters or less: it currently has 6 (function_parameter_count)

  Generated by :no_entry_sign: Danger Swift against 895ae5a08ac668bf74e4946475f02605a8acb8ff

can you please fix or add a swiftlint:disable to Sources/Danger/Plugins/SwiftLint/SwiftLint.swift#L125? Thank you :)


assure duplicated type error definitions are equivalent

To avoid having oloop-top depend on sexplib, we avoid adding with sexp to the definition of type error in Oloop_types. However, we want the same definition in Oloop with with sexp. This ends up causing us to duplicate the definitions, but there is no compiler enforcement that they are identical. Is there a way to make it so? If we used regular variants, we could use manifest type:
module A = struct
  type t = A | B
end

type u = A.t = A | B
with sexp

but the analogous idea doesn't work with polymorphic variants. This is a syntax error:
module A = struct
  type t = [`A | `B]
end

type u = A.t = [`A | `B]
with sexp

On Thu, 2 Apr 2015 15:02:31 -0700, Ashish Agarwal wrote:

To avoid having oloop-top depend on sexplib, we avoid adding with sexp to the definition of type error in Oloop_types. However, we want the same definition in Oloop with with sexp.

This is no longer true! ;-) The definition in Oloop_types is similar but different — one needs to be able to serialize it...

On Thu, 2 Apr 2015 15:02:31 -0700, Ashish Agarwal wrote:

module A = struct
type t = [A | B]
end
type u = A.t = [A | B]
with sexp

You do not need to rexport because polymorphic variants are not
attached to the module.  To ensure that you have equality, you can use
type u = [A | B] as 'a constraint 'a = A.t

Thanks. A type constraint is what I was looking for. But anyway this issue is now moot since the definitions are not equivalent anymore. I'll close.


Prior to Android API 24 (Android 7), camera connection does not work

Because the code uses the OutputConfiguration class available only from API 24
surfaces.Add(new OutputConfiguration(previewSurface));
surfaces26.Add(previewSurface);
previewBuilder.AddTarget(previewSurface);
if (imgReader != null)
{
    surfaces.Add(new OutputConfiguration(imgReader.Surface));
    surfaces26.Add(imgReader.Surface);
}
if (mediaRecorder != null)
{
    surfaces.Add(new OutputConfiguration(mediaRecorder.Surface));
    surfaces26.Add(mediaRecorder.Surface);
    previewBuilder.AddTarget(mediaRecorder.Surface);
}
Need to add something like this
if (OperatingSystem.IsAndroidVersionAtLeast(24))
{
    surfaces.Add(new OutputConfiguration(previewSurface));
}
I also had a situation that map.GetOutputSizes returns an empty array and the connection to the camera was not completed.
StreamConfigurationMap map = (StreamConfigurationMap)camChars.Get(CameraCharacteristics.ScalerStreamConfigurationMap);
videoSize = ChooseVideoSize(map.GetOutputSizes(Class.FromType(typeof(ImageReader))));
var maxVideoSize = ChooseMaxVideoSize(map.GetOutputSizes(Class.FromType(typeof(ImageReader))));
I used the standard resolution of 1280x720 for this situation.
try
{
    videoSize = ChooseVideoSize(map.GetOutputSizes(Class.FromType(typeof(ImageReader))));
    maxVideoSize = ChooseMaxVideoSize(map.GetOutputSizes(Class.FromType(typeof(ImageReader))));
}
catch
{
    videoSize = new Size(1280, 720);
    maxVideoSize = new Size(1280, 720);
}

And this line while (textureView.SurfaceTexture == null) Thread.Sleep(100); located in the StartPreview method
causes the application to freeze if the SurfaceTexture has not been loaded beforehand because you then block via Thread.Sleep, it will continue indefinitely.
You need to use SurfaceTextureAvailable Event:
https://learn.microsoft.com/en-us/dotnet/api/android.views.textureview.surfacetextureavailable?view=xamarin-android-sdk-13&viewFallbackFrom=xamarin-android-sdk-12

But it seems the author forgot about his plugin and I’m writing these comments just like that


Furnaces don't drop

On Minecraft 1.21 fabric, when i have More Smoker Variants as well as More Furnaces Variants, the smokers can be mined and drop as normal but the deepslate furnace and blackstone furnace take forever to mine and don't drop. I don't think there's supposed to be incompatibility between the two since more furnace is required for the deepsltae smoker.

Thanks for reporting this. It was caused by a bug fix that fortunately is no longer needed and as such I removed the offending files in version 1.1.1 that was just released. Let me know if there's anything else and thanks again. (:


Windows7 Conflict

Greetings!
I'm having trouble decrypting messages. I'm actually having problems compiling this script, with version 2.0 RC. I get error that Crypt.ahk is missing a comma.
The script partially runs on version 1.1, but I can't decrypt it.
; #Requires AutoHotkey v2.0-
#NoEnv
#include Cryptv1.ahk
SetBatchLines, -1
Gui, Margin, 20, 10
Gui, Font, s10, Courier New
Gui, Add, Edit, w600 r10 vInput, %Dummy%
Gui, Font
Gui, Add, Button, gEncode, Encode
Gui, Add, Button, x+m yp gDecode, Decode
Gui, Add, edit, x180 y190 w180 h20 vKey, abcdef0123456789
Gui, Add, edit, x400 y190 w180 h20 vIV, abcdef0123456789
Gui, Font, s10, Courier New
Gui, Add, Edit, xm w600 r10 vResult +ReadOnly
Gui, Show, , EncryptGUI
Return

GuiClose:
ExitApp

Encode:
Gui, Submit, NoHide
GuiControl, , Result, % Crypt.Encrypt.String("AES", "CBC", Input, Key, IV)
Return

Decode:
Gui, Submit, NoHide
GuiControl, , Result, % Crypt.Decrypt.String("AES", "CBC", Input, Key, IV)
Return

The function to encrypt works well and is compatible with OpenSSL, but the function Crypt.Decrypt.String() does not work, it always gives errors.
How to proceed?

Used compiler shipped with AHK v<IP_ADDRESS> and it works for me


Remove or replace the sc- class prefix

I'd like to remove/replace the sc- prefix thats added before each class name.
I am using the Babel module. And I've tried namespace, but it does not remove sc-. And I don't want the __ double underscore as well.

I've created a fix for this issue. Pull request is submitted.


Adding contributing docs

Adding the stock AWS contributing/code of conduct files.

note: Travis is failing because of a recent bug in mypy that I need to track down and chase upstream.


Updating the kit instructions – beta.9 to beta.10

I have just updated the kit from beta.9 to beta.10 and it seems as though the instructions on updating the kit are missing a few bits: https://govuk-prototype-kit.herokuapp.com/docs/updating-the-kit
I had to update app/includes/scripts.html
and the window.GOVUKFrontend.initAll() is now in application.js
Cheers.

Hi @gazjoy thanks for raising this. I have opened this issue in the prototype kit repo and will close this one here.


Image service needs to be integrated into single VM

The single VM script currently downloads and prepares some images, copies them into /var/lib/ciao/images and then setups up the appropriate symbolic links so that the images match the workloads.  We should really be using the image-service to do this, so that it gets some testing in the SingleVM tests.  There's no need to enable ceph in Single VM for this to work.

@obedmr You'll need this https://github.com/01org/ciao/pull/637 to get ciao-cli to work with the image service in Single VM.  I have the volume stuff working locally now and will submit the remaining patches tomorrow.


Add License

I apparently forgot to include a license when creating the repo. The intent was BSD-3.
@daniel-severo, @mrocklin, as the other contributors up to this point, are you OK with adding that?

Yes
On Tue, Oct 17, 2017 at 7:38 PM, Tom Augspurger<EMAIL_ADDRESS>wrote:

I apparently forgot to include a license when creating the repo. The
intent was BSD-3.
@daniel-severo https://github.com/daniel-severo, @mrocklin
https://github.com/mrocklin, as the other contributors up to this
point, are you OK with adding that?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/dask/dask-ml/issues/44, or mute the thread
https://github.com/notifications/unsubscribe-auth/AASszG1kCE6ko-Zvro3zuGyr5ol-A2Kuks5stTpvgaJpZM4P89zj
.

Yeap!


Add class to read CST power beams into UVBeam object, add method to convert to Healpix

I'm not sure this is quite ready, but I wanted to get more people's eyes on it. If anyone has some example CST files, I'd like to know how this does reading them -- I understand that not all CST files are created equal.

Ok, I think this is now ready for review. It has been tested by Adam Lanman on the Fagnoni CST files.

This now supports reading in the Efield beams from the CST files, but converting Efield beams to Healpix is not yet supported (this requires careful work and will be left to a later PR).


Client provide uncles

PR for issue #1448

@rphmeier @bkchr further thoughts?

Thanks for the reviews @bkchr @rphmeier.

Ready for review again?

Ready for review again?

Yes, I think I handled all the points in the reviews.

cool. @bkchr / @rphmeier happy to sign off?

what has changed since the last review?

what has changed since the last review?

Mainly, I removed the hashmap from the implementation of children as you asked.
I was thinking to create a new issue for this (I took a look to the ethereum repo).
Should I create a meta issue about refactoring db related code?
\cc @rphmeier


Consider signing storage apply operations

Even after implementing storage access control (see #1570) bad txn scheduler/compute/merge nodes can spam the storage node with bogus state updates. Although the storage node may safely prune any non-finalized (not included in a block for a specific round) roots after receiving a block for that round it will still need to do work related to applying bogus updates.
To disincentivize such behavior nodes could be required to sign their Apply/ApplyBatch operations, more specifically (namespace, srcRound, srcRoot, dstRound, dstRoot) so that it would be easy to prove that the given inserted state was bogus. After a round is finalized, the storage node may present such signatures as proofs of bad behavior.
Another case of spamming may also be submission of bogus write logs that don't derive the correct dstRoot when applied against srcRoot. Such updates are discarded, but still take storage node resources for verification on each Apply operation. While creating a separate proof by signing the (srcRoot, dstRoot, writeLog) is possible, this requires the verifier to have the full state of srcRoot and the full writeLog available which takes additional resources which is undesirable unless verifiers are rewarded.

No longer relevant.


Danger check for "unpackaged" code

To package all of our files, Gusto has created a pack (see stimpack) called packs/unpackaged_code_that_needs_to_be_organized. All code that we couldn't find a home for we put there, with the intent that users would gradually move it into other packs.
Gusto has an internal danger plugin to aid us with this process. When a new file is created in that pack, we ask them to not create new files that are not packaged. When a file is modified, we ask if they have additional context that could permit them to move the file to a more appropriate pack.
If there is interest, we could port this over to danger-packwerk (with a configurable name for the unpackaged pack).

This seems like potentially a good idea! Leaving this issue open for now to track, though it is probably low priority for us.


fix dubious ownership error message

This fixes error message fatal: detected dubious ownership in repository at '/github/workspace' referenced in issue https://github.com/hasretsariyer/firebase-app-distribution-github-action/issues/4
I found the solution documented here: https://github.com/repo-sync/pull-request/issues/84

@alex-dybsetter thank you for your effort 🙏  I will test your solution and merge if it works.

Hi @hasretsariyer. Are there any updates on this? I found this action really helpful but I'm having this issue when trying to make it work


Broken with the last update

I know discord has change a lot since the recent updated, i just wanted let you know it is broken the js

Nevermind seems now its working

seems it now working


Allow id to be specified at insert

As mentioned in the previous PR ( from master ).
The purpose in to allow insert using a specific ID

File is correctly indent.
Where do i put the documentation about this ?

@rolljee thank you for PR.
Published as v1.9.7


Minimum client (.py) for development use

Description
It repeats only them. (and connect/disconnect process)

Get mic input
Send mic input
Receive raw audio (mixed audio expected)
Play received raw audio

It is useful for development (debugging), because it is simple than web-app. (But difficult use for mobile.)

Need addition usage to README.md.


Fix the definition of duplicate parameter

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

[ ] N
[x] Y #524

2. What is the scope of this PR (e.g. component or file name):
kclvm/sema/src/advanced_resolver/node.rs

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

[ ] Affects user behaviors
[ ] Contains syntax changes
[ ] Contains variable changes
[ ] Contains experimental features
[ ] Performance regression: Consumes more CPU
[ ] Performance regression: Consumes more Memory
[x] Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

[x] N
[ ] Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

[x] Unit test
[ ] Integration test
[ ] Benchmark (add benchmark stats below)
[ ] Manual test (add detailed scripts or steps below)
[ ] Other

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 16 (100.0%)  changed or added relevant lines in 4 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage increased (+0.003%) to 72.296%

Files with Coverage Reduction
New Missed Lines
%

kclvm/sema/src/advanced_resolver/node.rs
1
84.68%

Totals

Change from base Build<PHONE_NUMBER>:
0.003%

Covered Lines:
43902

Relevant Lines:
60725

💛  - Coveralls


update rails defaults - enable sha256

migrate pupil password field

rename field, copy contents
needs environment variables setting

later PR needed to drop old field and remove EncryptedField
[x] is the index still needed?

don't think it can because using the default non-deterministic encryption

[x] migration actiontext signed urls

https://systemweakness.com/unravelling-signed-url-changes-in-rails-7-e9156da43022?gi=bc753743ca11

[ ] set environment variables on elastic beanstalk environments

bin/rails db:encryption:init

Left a couple of questions. Overall looks OK, but wondering how we handle rolling back if there's an issue. The Trix migration looks destructive so wondering how we add a safety net and some extra testing.

would manual testing on test and that looks ok be sufficient confidence?

Also wondering about time required to do the user and trix updates. E.g. should we expect any more downtime than usual during a release that includes this?

yeah, took a couple of minutes locally, would expect slower on production

deploy to test
2024/08/13 09:29:52.276041 [INFO] Running script: .platform/hooks/predeploy/99_after_party.sh
2024/08/13 09:32:05.152115 [INFO] Finished running scripts in /var/app/staging/.platform/hooks/predeploy


Error in a CTSM branch that includes cam6_4_016 with v0.8.2 and v0.8.4

In branch_tags/dustemisdev.n08_ctsm5.2.018 which includes CAM and CICE there is a gitfleximod issue when trying to update cam. The only thing needed from this branch is the .gitmodules file
https://github.com/ESCOMP/CTSM/blob/branch_tags/dustemisdev.n08_ctsm5.2.018/.gitmodules
Doing
bin/git-fleximod update cam

results in an error as below.
I've tried this both with v0.7.8, v0.8.2 and the latest v0.8.4. The error I see with the latest is:
bin/git-fleximod update cam
                 cam up to date.
Recursively checking out submodules of cam
Recursively checking out submodules of fv3
Recursively checking out submodules of hemco
Recursively checking out submodules of HEMCO
Sparse checkout mpas fxsparse ../.mpas_sparse_checkout
Traceback (most recent call last):
  File "bin/git-fleximod", line 8, in <module>
    sys.exit(main())
  File "/glade/work/erik/ctsm_worktrees/external_updates/.lib/git-fleximod/git_fleximod/git_fleximod.py", line 350, in main
    submodules_update(gitmodules, root_dir, fxrequired, force)
  File "/glade/work/erik/ctsm_worktrees/external_updates/.lib/git-fleximod/git_fleximod/git_fleximod.py", line 254, in submodules_update
    submodules_update(gitsubmodules, repodir, newrequiredlist, force=force)
  File "/glade/work/erik/ctsm_worktrees/external_updates/.lib/git-fleximod/git_fleximod/git_fleximod.py", line 244, in submodules_update
    submod.update()
  File "/glade/work/erik/ctsm_worktrees/external_updates/.lib/git-fleximod/git_fleximod/submodule.py", line 334, in update
    self.sparse_checkout()
  File "/glade/work/erik/ctsm_worktrees/external_updates/.lib/git-fleximod/git_fleximod/submodule.py", line 222, in sparse_checkout
    assert os.path.isdir(os.path.join(gitroot, ".git"))
AssertionError

@cacraigucar you must have gitfleximod working for cam in cam6_4_16, what might be different about what I'm doing than what you are doing for CAM?

Yes cam6_4_016 is working for other projects such as cesm3_0_beta02.   Have you exceeded your disk quota?

@ekluzek - Yes, numerous people have checked out cam6_4_016 (and subsequent versions) without any issue.  If you still have a problem, please let me know.

@billsacks with try checking this out in a worktree of CTSM and see if he sees the same thing.
I did check quota, and it looks like that's NOT the problem. But, it was a great suggestion.
I do have it working doing a new clone under $SCRATCH for example. And similarly cam6_4_016 works for me. I'll also try CESM. It might just be an issue with git worktree's?  But I'm not completely sure.

I would be happy to look into the git worktree issue but I will need a crash course on how to use that git feature.

@jedwards4b - This looks like it might be a good tutorial (I've spent all of 2 minutes looking at it, but it was recommended to me by someone else).   https://www.gitkraken.com/learn/git/git-worktree

Yes, I can reproduce this error, and it seems related to the use of git worktrees. The issue seems to be that, in a git worktree, .git is not a directory: instead, it is a plain text file pointing back to the .git directory in the original git clone.
Steps to reproduce:
git clone git@github.com:ESCOMP/CTSM.git CTSM2
cd CTSM2
git worktree add --detach ../CTSM3
./bin/git-fleximod update  # I'm not sure if this step is necessary to reproduce the issue
cd ../CTSM3
git checkout branch_tags/dustemisdev.n08_ctsm5.2.018
./bin/git-fleximod update cam

I'm getting a slightly different traceback, but it looks like it's fundamentally the same error:
$ ./bin/git-fleximod update cam
Recursively checking out submodules of cam

e            chem_proc not checked out, aligned at tag chem_proc5_0_06
e                carma not checked out, aligned at tag carma4_01
e                pumas not checked out, aligned at tag pumas_cam-release_v1.36
e         pumas-frozen not checked out, aligned at tag pumas_cam-release_v1.17_rename
e             ali_arms not checked out, aligned at tag ALI_ARMS_v1.0.1
e           atmos_phys not checked out, aligned at tag atmos_phys0_02_006
e                  fv3 not checked out, aligned at tag fv3int_053124
e             geoschem not checked out, aligned at tag 14.1.2
e                hemco not checked out, aligned at tag hemco-cesm1_2_1_hemco3_6_3_cesm_rme
e           rte-rrtmgp not checked out, aligned at tag v1.7
e          rrtmgp-data not checked out, aligned at tag v1.8
e                 mpas not checked out, aligned at hash b8c33daa
e                cosp2 not checked out, aligned at tag v2.1.4cesm
e                clubb not checked out, aligned at tag clubb_4ncar_20231115_5406350
Recursively checking out submodules of fv3

e   atmos_cubed_sphere not checked out, aligned at tag FV3-202204-public
Recursively checking out submodules of hemco

e                HEMCO has no fxtag defined in .gitmodules
Recursively checking out submodules of HEMCO

e docs/source/geos-chem-shared-docs has no fxtag defined in .gitmodules
Traceback (most recent call last):
  File "/Users/sacks/temporary/CTSM3/./bin/git-fleximod", line 8, in <module>
    sys.exit(main())
             ^^^^^^
  File "/Users/sacks/temporary/CTSM3/.lib/git-fleximod/git_fleximod/git_fleximod.py", line 607, in main
    submodules_update(gitmodules, root_dir, fxrequired, force)
  File "/Users/sacks/temporary/CTSM3/.lib/git-fleximod/git_fleximod/git_fleximod.py", line 421, in submodules_update
    single_submodule_checkout(
  File "/Users/sacks/temporary/CTSM3/.lib/git-fleximod/git_fleximod/git_fleximod.py", line 255, in single_submodule_checkout
    submodules_checkout(gitmodules, repodir, requiredlist, force=force)
  File "/Users/sacks/temporary/CTSM3/.lib/git-fleximod/git_fleximod/git_fleximod.py", line 512, in submodules_checkout
    submodule_sparse_checkout(root_dir, name, url, path, fxsparse, tag=fxtag)
  File "/Users/sacks/temporary/CTSM3/.lib/git-fleximod/git_fleximod/git_fleximod.py", line 106, in submodule_sparse_checkout
    assert os.path.isdir(os.path.join(gitroot, ".git"))
AssertionError

@billsacks thank you for the clear, complete instructions to reproduce the issue - that was very helpful.
v0.8.5 solves the problem.

v0.8.5 solves the problem.

Thank you very much @jedwards4b !

Yes, this is great. Thanks @jedwards4b and also @billsacks!


Schema:dump and schema:load commands

MySQL only implementation of #109. After your review I'll continue with other adapters.

Anyone know if this fork is compatible with recent additions to the master branch i.e. 4.x?
The new functionality for using Phinx via web interface is just what I am trying to implement, currently via php exec(). However also need to use schema:load to automate creation of new databases. Described here: https://github.com/robmorgan/phinx/blob/0.4.x-dev/docs/commands.rst

@adamski, not yet. I'm going to look at 0.4.x and new schema type support this weekend.

Thank you @detook, your efforts are very much appreciated!

:+1:

Please create a new pull request against 0.4.x-dev branch. Thanks!


fix(TYP-6955): Autoresize fullscreen popup on mobile

Prevents browser navbar from covering form controls

:tada: This PR is included in version @typeform/embed-v1.35.1 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Added Hyperlink to SHiPs module to Readme.md

PR Summary

PR Checklist

[ ] Write Help
[ ] Write Unit Test
[ ] Update VSTeam.psd1
[ ] Update CHANGELOG.md

Thanks for the contribution and support.


Id is null for groups

Very similiar to the bug that was fixed in package 2.0.3: the Id is set to null once it gets saved to cache. This was solved for Scene and Light but still occurs for Group.
private StorageHelper<IReadOnlyCollection> GroupsHelper = new StorageHelper<IReadOnlyCollection>(Windows.Storage.ApplicationData.Current.LocalCacheFolder);
IReadOnlyCollection Groups = await hueClient.GetGroupsAsync();
await GroupsHelper .SaveAsync(Groups , "Groups ");
Get from cache:
IReadOnlyCollection CachedGroups = await GroupsHelper.LoadAsync("Groups ");
After this, most properties are still there, but Id is set to null.

Group.Id was missing the [DataMember] attribute. Fixed now in version 2.2.3


serac spack pkg: add +asan variant

This commit adds a +asan variant to the Serac Spack package to
expose more readily the ENABLE_ASAN option to users building Serac
through Spack and Uberenv. This change is probably more convenient for
downstream users of Serac that build it as a dependency of their
projects via Spack/Uberenv.
Resolves #531.

I'm going to go investigate why this is failing CI


Prepare for new release of Bitbucket

Workflow links: https://github.com/atlassian-labs/atlassian-slack-integration-server/actions/runs/3334597009, https://github.com/atlassian-labs/atlassian-slack-integration-server/actions/runs/3334598115.

This ticket will be addressed in #242


oracle lib link has changed

https://github.com/linkedin/WhereHows/tree/master/wherehows-etl/extralibs
i found the jar here:
http://www.oracle.com/technetwork/database/features/jdbc/jdbc-drivers-12c-download-1958347.html

I also had an issue with my Oracle jobs failing.
When using Wherehows with Docker, I also had to alter my Dockerfile at Wherehows/wherehows-docker/wherehows-backend/Dockerfile to include some extra apt-gets, ENV declarations and some folder COPYing. I'll just post the whole Dockerfile, though I don't completely understand why the additions help:
FROM openjdk:8

#(I added the libaio imports, and the jython but that was for something separate)
RUN apt-get update && \
    apt-get install -y wget && \
	apt-get install -y libaio1 && \
	apt-get install -y libaio-dev \
	apt-get install -y jython

# Install dockerize
ENV DOCKERIZE_VERSION v0.5.0
RUN wget https://github.com/jwilder/dockerize/releases/download/$DOCKERIZE_VERSION/dockerize-linux-amd64-$DOCKERIZE_VERSION.tar.gz \
    && tar -C /usr/local/bin -xzvf dockerize-linux-amd64-$DOCKERIZE_VERSION.tar.gz \
    && rm dockerize-linux-amd64-$DOCKERIZE_VERSION.tar.gz

# (I added these steps, found from a StackOverflow post when debugging my Oracle job failing)
COPY lib/ /app/lib/
RUN unzip -qq /app/lib/instantclient-basic-linux.x64-<IP_ADDRESS>.0.zip \
    -d /usr/local/lib
RUN unzip -qq /app/lib/instantclient-sdk-linux.x64-<IP_ADDRESS>.0.zip \
    -d /usr/local/lib
RUN ln -s /usr/local/lib/instantclient_12_2/libclntsh.so.12.2 \
    /usr/local/lib/instantclient_12_2/libclntsh.so

# Setup app environment
ADD tmp/wherehows-backend /application
WORKDIR /application
RUN mkdir -p logs/etl
ENV WHZ_ETL_JOBS_DIR=/application/jobs
ENV WHZ_ETL_TEMP_DIR=/application/logs/etl

# (I added the following ENV's)
ENV ORACLE_HOME /usr/local/lib/instantclient_12_2
ENV LD_LIBRARY_PATH /usr/local/lib/instantclient_12_2
ENV CLASSPATH /application/lib/ojdbc8.jar

I put some "I added...." comments in there so you could see what I personally inserted.
I also made a small edit to a file inside the ojdbc8.jar archive that had something to do with a timezone error, but I forget off the top of my head what that was exactly. Would have to dig through my notes.

Dear issue owner,
Thanks for your interest in WhereHows. We have recently announced DataHub which is the rebranding of WhereHows. LinkedIn improved the architecture of WhereHows and rebranded WhereHows into DataHub and replaced its metadata infrastructure in this direction. DataHub is a more advanced and improved metadata management product compared to WhereHows.
Unfortunately, we have to stop supporting WhereHows to better focus on DataHub and offer more help to DataHub users. Therefore, we will drop all issues related to WhereHows and will not accept any contribution for it. Active development for DataHub has already started on datahub branch and will continue to live in there until it's finally merged to master and project is renamed to DataHub.
Please check the datahub branch to get familar with DataHub.
Best,
DataHub team


fix HeliosSoloDeployment library for Docker For Mac

InetAddress.getLocalHost() returns the loopback device. This does not allow an application that is running inside a container from being able to communicate with the host, since hitting <IP_ADDRESS> will make it talk to itself. An ipv4 address of the host needs to be given to the container.
@davidxia @mavenraven @mattnworb

Codecov Report

Merging #1195 into master will decrease coverage by 0.08%.
The diff coverage is 0%.

@@             Coverage Diff              @@
##             master    #1195      +/-   ##
============================================
- Coverage     52.55%   52.46%   -0.09%
  Complexity     1609     1609
============================================
  Files           268      268
  Lines         13009    13016       +7
  Branches       1502     1504       +2
============================================
- Hits           6837     6829       -8
- Misses         5652     5668      +16
+ Partials        520      519       -1

@danielhan What're the steps to repro the issue that this fixes? I was curious and wanted to run this code on both DFM and docker toolbox to see they both work now.

@davidxia i would agree that this is fairly complex.  to reproduce the issue, you have to set up a helios integration test environment with at least two containers, and one needs to talk to the other.  what is supposed to happen is that each container is supposed to know the host's ip address, in order to route requests to other containers.  however, on docker for mac, the containers get the <IP_ADDRESS> as the host's ip.

Is there a simple mvn verify cmd I can just run on a repo that’ll do this? I’m assuming this PR was motivated by a user raising an issue when running tests on their code?

@mattnworb @davidxia is this worth doing?  folks on Docker for Mac can address the issue by mapping their Mac's name to an externally routable IP address.  There is no clean way I can think of to programmatically discover an IP address that is guaranteed to work in all scenarios.

Given that this seems to be an edge case and the difficulties you've had trying to do it in code, I'm fine updating the helios FAQ with a workaround.

@dxia https://github.com/spotify/helios/blob/master/docs/integration_tests_with_helios_solo.md#docker-for-mac-address-for-temporaryjob-containers-is-returned-as-127001 exists.  i did not see this

:( Do you want to close this PR and just point affected users to that part of the docs?


icon-sets website is broken

I'm sorry if this isn't the most appropriate place to create an issue, but I couldn't find better.
The website https://icon-sets.iconify.design/ is broken. Icons' search box appears only on some inner pages. Filtering doesn't work.
I'm guessing there is/was some migration? Some of the Nuxt js files cannot be loaded and parts of the sites are completely broken.

Thanks for reporting!
Fixed by purging cache. Old page was cached linking to resources that no longer exist.
Not sure why this happened, deployment is supposed to keep scripts from previous deployment to avoid exactly this scenario, so something went wrong in today's update. I'll investigate and fix it.

Actually, it wasn't a deployment issue or cache issue, but a server issue. Experiencing weird problems with one server that I cannot explain. Switched website to another server while trying to figure out why Nuxt on one specific server returns 404 for static assets that do exist, but works fine on other server.
Thanks a lot for report!


Work around function std name collision in MSVC

Refs https://github.com/ml-explore/mlx/issues/1513.
There is a bug in MSVC that, if the std function is exposed to current scope with using namespace mlx::core, all following std::xxx invocations that try to access the namespace std will fail with very unhelpful errors:
C:\cygwin\home\zcbenz\codes\mlx\python\src\array.cpp(28,18): error C2874: using-de
claration causes a multiple declaration of 'std' [C:\cygwin\home\zcbenz\codes\mlx\
build\temp.win-amd64-cpython-311\Release\mlx.core\python\src\core.vcxproj]
      C:\Program Files\Microsoft Visual Studio\2022\Community\VC\Tools\MSVC\14.42.
  34433\include\numeric(22,1):
      see declaration of 'std'
C:\Users\zcbenz\AppData\Roaming\Python\Python311\site-packages\nanobind\include\na
nobind\nb_cast.h(160,27): error C2872: 'std': ambiguous symbol [C:\cygwin\home\zcb
enz\codes\mlx\build\temp.win-amd64-cpython-311\Release\mlx.core\python\src\core.vc
xproj]
  (compiling source file '../../../../../../python/src/convert.cpp')
      C:\Program Files\Microsoft Visual Studio\2022\Community\VC\Tools\MSVC\14.42.
  34433\include\numeric(22,1):
      could be 'std'
      C:\Users\zcbenz\AppData\Roaming\Python\Python311\site-packages\nanobind\incl
  ude\nanobind\nb_cast.h(160,27):
      or       'std'

(MSVC thinks std:: is ambiguous.)
There are 2 solutions, one taken by this PR is to rename the std function to std_dev and use it internally, while adding a std alias only available in public mlx.h header. It makes minimum changes to existing code with the cost of adding a new header.
The other solution would be replacing the using namespace mlx::core with namespace mx = mlx::core and use mx::xxx() instead of xxx() in the python bindings code. I prefer this one but it would result in a relatively large PR.

I kind of prefer the second solution as well ... it feels like the right way to fix name collisions and how the C++ namespace should be used in user code. It is a big and tedious diff though 😓

Will go the 2nd solution, feels like the right way to go.


Implement a method to mark the live location of the user (feature request)

Since this is a community involving app, it is vital that every person gets involve in this community service and mark their location by them-self in the app if they are infected . It is a kind of responsibility as well. Then government and other relevant organization can take necessary actions to stop the spread of disease. (This is relevant to any disease and highly important for fast spreading diseases like covid-19 )
This is a extension of #219

i would like to work on this @viradhanus


Ranging issues

When having heavy step loads during ranging (particularly if near range edge), it takes meter few samples for meter to switch ranges (while in autorange).
Recommendation:
Use max range for ranging, accuracy is good enough (about 40mA in 20A range, per yokogawa calculator) to be able to make correct decision about wat is appropriate range to be used for measurement.
Alternative solution is to update checker to ignore ERROR: Current appears to be too high for set range and ERROR: Bad watts reading inf from WT330 during ranging phase

Just to bump here, my WT210 is having this issue now during almost every run when ranging. It is making it difficult to get passing logs.

not too surprising since wt210 as lower internal sampling rate, so it will take more time for to come to its senses in autorange mode.
are your run logs clean of errors?

Yep --
run1/spl.txt has good values/no errors for every poll
ranging/spl.txt has the occasional few lines of:
Time,03-18-2021 16:30:51.243,Watts,-1.000000,Volts,121.610000,Amps,-1.000000,PF,-1.000000,Mark,2021-03-18_16
-30-17_resnet50_Server_ranging

Whitelist:
ERROR: Current appears to be too high for set range
ERROR: Bad \w+ reading *+ from \w+

Grabbed the wrong error, here are the correct one that relates to Po-Hans whitelist above:
03-18-2021 19:56:18.516: ERROR: Bad watts reading<PHONE_NUMBER>0000005192630646116011999232.000000 from Yokogawa Buffer was 121.57E+00,9.91E+37,9.91E+37,9.91E+37,60.022E+00,9.91E+37,9.91E+37;10.000E+00;150.0E+00;0
+00;0

03-18-2021 19:56:18.517: ERROR: Bad amps reading<PHONE_NUMBER>0000005192630646116011999232.000000 from Yokogawa Buffer was 121.57E+00,9.91E+37,9.91E+37,9.91E+37,60.022E+00,9.91E+37,9.91E+37;10.000E+00;150.0E+00;0
+00;0

03-18-2021 19:56:18.517: ERROR: Bad pf reading<PHONE_NUMBER>0000005192630646116011999232.000000 from Yokogawa Buffer was 121.57E+00,9.91E+37,9.91E+37,9.91E+37,60.022E+00,9.91E+37,9.91E+37;10.000E+00;150.0E+00;0
+00;0

The decision is:
if WARNING then prints a WARNING and passes
endif
if ERROR is "uncertainty" and is in Ranging phase then ignore and passes,
else if ERROR is in Ranging phase then prints a WARNING and passes
else prints an ERROR and fails
endif


[backport] Document scipy.fft backend usage

Backport of #5514 by @leofang

[automatic post] Jenkins, test this please.

Jenkins CI test (for commit 091fcadd9a5dd6cdbf5b16aaabe811f0f49ea6a8, target branch v9) succeeded!


Feature/gechina 84

model translations using traco
applied to groups importer
locale param applied to controllers TODO: make it show up in swagger
region type enum

i thought that was ready to review and looks good to me. let me know when is ready.


Sample Tracking Updates

This is an issue for updating the sample tracking calls based on the discussions happening at BTI on Dec 14, 2017
These will need more discussion and refinement before being officially added to BrAPI.
New Calls
/sample-search{?sampleDbId}{?plateDbId}{?germplasmDbId}...
/sample/{sampleDbId}
/sample/{sampleDbId}/xref
/plate-search{?plateDbId}{?germplasmDbId}...
/plate/{plateDbId}
/plate/{plateDbId}/xref
/plate/{plateDbId}/samples
/plate/{plateDbId}/sample/{sampleDbId}

New Models
Plate
{
	plateDbId: (string)

	studyDbId: (string)

	xrefs: []

	plateType: (string)
	plateSize: (int)
	samples: []
}

Sample
{
	sampleDbId: (string)
	observationUnitDbId: (string)

	germplasmDbId: (string)
	studyDbId: (string)
	plotDbId: (string)
	plantDbId: (string)

	xrefs: []

	plateDbId: (string)
	plateIndex: (int)
	takenBy:  (string)
	sampleTimestamp:  (timestamp)
    sampleType:  (string)
    tissueType:  (string)
    notes:  (string)
}

Plate xref
{
	plateDbId:
	xrefId:
	xrefURL:
	xrefSystemId:
}

Sample xref
{
	sampleDbId:
	xrefId:
	xrefURL:
	xrefSystemId:
}

old issue, made irrelevant by further sample/vendor related discussions


fix: use vite@5

Relates #341, https://github.com/sveltejs/cli/pull/311#issuecomment-2531023527
From https://github.com/vitest-dev/vitest/issues/7014#issuecomment-2527453004

Vitest 2 doesn't support Vite 6 and will not support Vite 6 officially. You can use resolutions or pnpm.overrides to change the version range locally, Vite 6 API is the same and should work for Vitest 2.
If you migrated to Vite 6, use Vitest 3 (currently in beta), release is planned for January.
If you see any type errors in your config, check the lockfile to confirm that you have several Vite versions installed and resolve it with your package manager.

whats missing to get this merged?

preview: https://svelte-dev-git-preview-cli-353-svelte.vercel.app/
this is an automated message


wakatime: 7.0.4 -> 8.0.2

Motivation for this change
Upgrade to latest version and switch from buildPythonPackage to buildPythonApplication.
Things done

[ ] Tested using sandboxing
(nix.useSandbox on NixOS,
or option build-use-sandbox in nix.conf
on non-NixOS)
Built on platform(s)

[ ] NixOS
[x] macOS
[ ] Linux

[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

Acoording to travis, the hash seems to be wrong: https://travis-ci.org/NixOS/nixpkgs/jobs/236475922#L1520

This happened to me once before. It works on my system. Is it possible there's something wrong with it?

Can someone sort out the hash issues?

@yurrriq How are you generating the hash?

nix-build -A wakatime and copying from where it says "has hash ... but expected ..."

Thanks, @orivej!


KAFKA-5887: Replace findBugs with spotBugs and upgrade to Gradle 4.10

findBugs is abandoned, it doesn't work with Java 9 and the Gradle plugin will be deprecated in
Gradle 5.0: https://github.com/gradle/gradle/pull/6664
spotBugs is actively maintained and it supports Java 8, 9 and 10. Java 11 is not supported yet,
but it's likely to happen soon.
Also fixed a file leak in Connect identified by spotbugs.
Manually tested spotBugsMain, jarAll and importing kafka in IntelliJ and running
a build in the IDE.
Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

@cmccabe, can you please review this?

LGTM.  Thanks, @ijuma

@lindong28 can you please review this?


Handle generics from array methods in pyconverter

We still don't support generics except for arrays
Fixes https://github.com/microsoft/pxt-microbit/issues/3579

@jwunderl @livcheerful Please take another look, I just updated this to handle all the generic methods for Arrays. I cheated on map though.


inserted missing include

needed for std::istream_iterator

http://en.cppreference.com/w/cpp/iterator/istream_iterator


Windows: Implement Refresh event

Fixes #180
This is based on the snippet provided by @LPGhatguy, with one key difference: rather than returning 0, we pass the event along to the default handler. The reason for this is made clear in the docs:

If an application processes a WM_PAINT message but does not call BeginPaint or otherwise clear the update region, the application continues to receive WM_PAINT messages as long as the region is not empty. In all cases, an application must clear the update region before returning from the WM_PAINT message.

Using the original snippet, event processing slows down massively and my laptop fan gets quite loud. With this, Refresh appears to have the same behavior on Windows as on X11.

Thanks! Feel free to merge after conflicts are resolved.


chancloser+lnwire: add range-based negotiation

This PR adds FeeRange to ClosingSigned and makes lnd spec-compliant wrt FeeRange. Last 3 commits are new.
This patch also introduces the first place we'll send out a warning in lnd per the spec:
- if the message contains a fee_range:
  - if there is no overlap between that and its own fee_range:
    - SHOULD send a warning

Handling the warning is left for a future PR, since it is unclear what the funder should do as the FeeRange is already set and shouldn't change.

[x] needs tests
[x] depends on https://github.com/lightningnetwork/lnd/pull/6840
[ ] depends on https://github.com/lightningnetwork/lnd/pull/6760
[ ] probably should wait for https://github.com/lightning/bolts/issues/1013
[ ] testing with other impls

Fixes #4413

@crypt-iq, remember to re-request review from reviewers when ready

@crypt-iq, remember to re-request review from reviewers when ready

@crypt-iq, remember to re-request review from reviewers when ready

@crypt-iq, remember to re-request review from reviewers when ready

@crypt-iq, remember to re-request review from reviewers when ready

@crypt-iq, remember to re-request review from reviewers when ready

@crypt-iq, remember to re-request review from reviewers when ready

@crypt-iq, remember to re-request review from reviewers when ready

@crypt-iq, remember to re-request review from reviewers when ready

@crypt-iq, remember to re-request review from reviewers when ready

@crypt-iq, remember to re-request review from reviewers when ready

@crypt-iq, remember to re-request review from reviewers when ready

@crypt-iq, remember to re-request review from reviewers when ready

@crypt-iq, remember to re-request review from reviewers when ready

@crypt-iq, remember to re-request review from reviewers when ready

@crypt-iq, remember to re-request review from reviewers when ready

@crypt-iq, remember to re-request review from reviewers when ready

@crypt-iq, remember to re-request review from reviewers when ready

@crypt-iq, remember to re-request review from reviewers when ready

@crypt-iq, remember to re-request review from reviewers when ready

@crypt-iq, remember to re-request review from reviewers when ready

@crypt-iq, remember to re-request review from reviewers when ready

@crypt-iq, remember to re-request review from reviewers when ready

@crypt-iq, remember to re-request review from reviewers when ready

@crypt-iq, remember to re-request review from reviewers when ready

@crypt-iq, remember to re-request review from reviewers when ready

@crypt-iq, remember to re-request review from reviewers when ready

@crypt-iq, remember to re-request review from reviewers when ready

@crypt-iq, remember to re-request review from reviewers when ready

@crypt-iq, remember to re-request review from reviewers when ready

@crypt-iq, remember to re-request review from reviewers when ready

@crypt-iq, remember to re-request review from reviewers when ready

@crypt-iq, remember to re-request review from reviewers when ready

Closing due to inactivity

Closing due to inactivity

Adding this comment so the bot sees it as active

comment

@crypt-iq, remember to re-request review from reviewers when ready

@crypt-iq, remember to re-request review from reviewers when ready

@crypt-iq, remember to re-request review from reviewers when ready

@crypt-iq, remember to re-request review from reviewers when ready

@crypt-iq, remember to re-request review from reviewers when ready

@crypt-iq, remember to re-request review from reviewers when ready

@crypt-iq, remember to re-request review from reviewers when ready

@crypt-iq, remember to re-request review from reviewers when ready

@crypt-iq, remember to re-request review from reviewers when ready

@crypt-iq, remember to re-request review from reviewers when ready

@crypt-iq, remember to re-request review from reviewers when ready

@crypt-iq, remember to re-request review from reviewers when ready

@crypt-iq, remember to re-request review from reviewers when ready

@crypt-iq, remember to re-request review from reviewers when ready

@crypt-iq, remember to re-request review from reviewers when ready

@crypt-iq, remember to re-request review from reviewers when ready

@crypt-iq, remember to re-request review from reviewers when ready

@crypt-iq, remember to re-request review from reviewers when ready

@crypt-iq, remember to re-request review from reviewers when ready

@crypt-iq, remember to re-request review from reviewers when ready

@crypt-iq, remember to re-request review from reviewers when ready

@crypt-iq, remember to re-request review from reviewers when ready

@crypt-iq, remember to re-request review from reviewers when ready

Closing due to inactivity

Closing due to inactivity

Closing due to inactivity

Closing due to inactivity


CloudService 2022-04-04 release

MSFT employees can try out our new experience at OpenAPI Hub  - one location for using our validation tools and finding your workflow.

Changelog
Add a changelog entry for this PR by answering the following questions:

What's the purpose of the update?

[ ] new service onboarding
[x] new API version
[ ] update existing version for new feature
[ ] update existing version to fix swagger quality issue in s360
[ ] Other, please clarify

When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
If updating an existing version, please select the specific language SDKs and CLIs that must be refreshed after the swagger is published.

[ ] SDK of .NET (need service team to ensure code readiness)
[ ] SDK of Python
[ ] SDK of Java
[ ] SDK of Js
[ ] SDK of Go
[ ] PowerShell
[ ] CLI
[ ] Terraform
[ ] No refresh required for updates in this PR

Contribution checklist:

[x] I commit to follow the Breaking Change Policy of "no breaking changes"
[x] I have reviewed the documentation for the workflow.
[x] Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist

Applicability: :warning:
If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

Change to data plane APIs
Adding new properties
All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

[x] Check this box if any of the following appy to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review.  Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.

Adding a new service
Adding new API(s)
Adding a new API version
-[ ] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.

[x] Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

[ ] If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist
If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.

[ ] Removing API(s) in a stable version
[ ] Removing properties in a stable version
[ ] Removing API version(s) in a stable version
[ ] Updating API in a stable or public preview version with Breaking Change Validation errors
[ ] Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.

@zizw123 please review. this is a new PR with clean commit history to help you review more efficiently. The original PR is:
https://github.com/Azure/azure-rest-api-specs/pull/19354

breaking change approved in: https://github.com/Azure/azure-rest-api-specs/pull/19311

@zizw123

/azp run

/azp run

this is ready for merge


Add handling for waiting for Map load to test suite

As per discussion and link here, we need a nice way to handle waiting for the map to load before running tests that interact with the map.
@Sparrow0hawk TODO rest of this PR

Test


[a11y] VoiceOver focus doesn't work well when there's a semantic overlap

Is there an existing issue for this?

[X] I have searched the existing issues
[X] I have read the guide to filing a bug

Steps to reproduce
Hi !
In the video showing the bug, I have 2 RawApplePayButtons which are supposed to open a bottomSheet when onPressed is triggered.
The first Apple Pay button is used "conventionally", i.e. there are no other Semantics wrapped around it, so the widget works fine.
The second button is wrapped by a SizedBox(), itself wrapped by a Semantics(). When the RawApplePayButton is tapped, the callback is not triggered.
However, as you can see in the video, if I focus on my SizedBox() and click on it, the onPressed on my RawApplePayButton is called, which shouldn't be the case.
In my Apple Pay button KO, the focus seems to be directly on the PKPaymentButton and so Flutter's onPressed callback isn't triggered.
The bug seems to be only from iOS 16.5 onwards, and only when voice is used. (I tested on iPhone 14 pro on 16.5.1)
I've already opened an issue on the google-pay github but they told me that their library used the standard apple pay button behavior.
If you want to reproduce you can take the code sample and install the pay package
Expected results
onPressed on the ApplePay button is triggered when it is tapped while the VoiceOver focus is on it.
Actual results
onPressed on the ApplePay button is triggered while VoiceOver focus is on the parent (Container).
Code sample
Code sample
class ApplePayIssue extends StatefulWidget {
  const ApplePayIssue({super.key});

  @override
  State<ApplePayIssue> createState() => _ApplePayIssueState();
}

class _ApplePayIssueState extends State<ApplePayIssue> {
  @override
  Widget build(BuildContext context) {
    return Scaffold(
        body: Center(
      child: Column(
        mainAxisAlignment: MainAxisAlignment.center,
        children: [
          const Text("apple pay button OK"),
          RawApplePayButton(
            style: ApplePayButtonStyle.black,
            type: ApplePayButtonType.plain,
            onPressed: () {
              showModalBottomSheet(
                  context: context,
                  builder: (context) {
                    return const SizedBox(
                      height: 200,
                      child: Text("apple pay modal OK"),
                    );
                  });
            },
          ),
          const SizedBox(
            height: 50,
          ),
          const Text("apple pay button KO"),
          Semantics(
            label: "paiement card",
            excludeSemantics: false,
            explicitChildNodes: true,
            child: Container(
              color: Colors.red,
              padding: const EdgeInsets.all(10),
              child: RawApplePayButton(
                style: ApplePayButtonStyle.black,
                type: ApplePayButtonType.plain,
                onPressed: () {
                  showModalBottomSheet(
                      context: context,
                      builder: (context) {
                        return const SizedBox(
                          height: 200,
                          child: Text("apple pay modal OK"),
                        );
                      });
                },
              ),
            ),
          ),
        ],
      ),
    ));
  }
}

Screenshots or Video

Screenshots / Video demonstration
https://github.com/flutter/flutter/assets/72022928/30d5a150-189c-4303-b2de-fa743b26ae65

Logs
No response
Flutter Doctor output
Doctor output
[!] Flutter (Channel stable, 3.7.12, on macOS 13.4 22F66 darwin-arm64, locale fr-FR)
    • Flutter version 3.7.12 on channel stable at /Users/romain_greaume/fvm/versions/3.7.12
    ! Warning: `dart` on your path resolves to /opt/homebrew/Cellar/dart/3.0.7/libexec/bin/dart, which is not inside your current Flutter SDK checkout at
      /Users/romain_greaume/fvm/versions/3.7.12. Consider adding /Users/romain_greaume/fvm/versions/3.7.12/bin to the front of your path.
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 4d9e56e694 (4 months ago), 2023-04-17 21:47:46 -0400
    • Engine revision 1a65d409c7
    • Dart version 2.19.6
    • DevTools version 2.20.1
    • If those were intentional, you can disregard the above warnings; however it is recommended to use "git" directly to perform update checks and upgrades.

[✓] Android toolchain - develop for Android devices (Android SDK version 33.0.2)
    • Android SDK at /Users/romain_greaume/Library/Android/sdk
    • Platform android-33, build-tools 33.0.2
    • Java binary at: /Applications/Android Studio.app/Contents/jbr/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 17.0.6+0-17.0.6b802.4-9586694)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 14.3)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 14E222b
    • CocoaPods version 1.12.1

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2022.2)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 17.0.6+0-17.0.6b802.4-9586694)

[✓] IntelliJ IDEA Ultimate Edition (version 2023.1.4)
    • IntelliJ at /Applications/IntelliJ IDEA.app
    • Flutter plugin version 73.1.1
    • Dart plugin version 231.9065

[✓] VS Code (version 1.80.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.70.0

[✓] Connected device (3 available)
    • sdk gphone64 arm64 (mobile) • emulator-5554 • android-arm64  • Android 13 (API 33) (emulator)
    • macOS (desktop)             • macos         • darwin-arm64   • macOS 13.4 22F66 darwin-arm64
    • Chrome (web)                • chrome        • web-javascript • Google Chrome 115.0.5790.114

[✓] HTTP Host Availability
    • All required HTTP hosts are available
    ```

</details>

Hi @huycozy  :)
Thanks for the answer.
So I upgraded flutter to be in 3.13.0-19.0.pre.78, the issue is always there when you use the ApplePay button on the lib.
However, if I use an ElevatedButton for example, the issue is no longer there. (you can see the version upgrade through the modals/buttons which have changed their appearance)
https://github.com/flutter/flutter/assets/72022928/fc28a1d1-6e48-4e8d-966c-2c1f036421b0
https://github.com/flutter/flutter/assets/72022928/86489519-3322-4aeb-a6c4-f654e49c4123
however, strangely, in 3.7.12, with the ElevatedButton I also have a KO. If I tap on the red card it opens the modal, as well as when I click on the button. The code hasn't changed
https://github.com/flutter/flutter/assets/72022928/ca5a7573-9554-4ec1-b85c-7fa9487d30d5
When I'm in KO in my logs I get this message. I've looked a bit and it seems to be a problem on the iOS side so that voiceOver can find each nested element.
[Accessibility] Went all the way up the container chain from @, but could not find any container that was one of the ordered children of @. This may be acceptable if it happened right around a layout change, but it would be best to double check by swiping left/right to see if you can get to all elements.

I have to admit that I'm a bit stuck here, I've the impression that the issue is really between flutter and iOS in terms of managing nested Semantics.
What do you think?

I took a look at the RawApplePayButton code and see it's using a platform view with UiKitView. I have created a minimal code sample here a11y-ios-131780. Unfortunately, I don't have a higher iOS version to test (the issue doesn't reproduce with my iOS 15.7). Can you pull this sample code and check it on your device? If it's reproducible, it could be an OS-specific + platform-views + a11y issue.

@huycozy
I've pulled the repo but I've got an error on FLNativeViewFactory, the linter tells me it can't find it in the scope.
I do have the UIKit and Flutter imports.
I saw that you had gitIgnore your podfile, I've created one but I don't know if a lib is missing?
It seems to me that FLNativeViewFactory is directly integrated into UIKit so I don't understand what the problem is...
Did you take over the code from  https://docs.flutter.dev/platform-integration/ios/platform-views ?

Did you take over the code from https://docs.flutter.dev/platform-integration/ios/platform-views ?

Yes, basically that's the code base. I have just pushed the remaining local changes to that branch, please pull and check if it works.
Also, you can check the commit which updates to that code base and replace the text with a button to reproduce this issue.

Hey @huycozy, from my tests, the issue is linked to the native Apple Pay Button (PKPaymentButton), something might have changed with iOS 16.5 and the communication between Flutter and the button might have changed. I tried to change it to a normal UIButton in the pay plugin locally and it's working again.
https://github.com/google-pay/flutter-plugin/blob/af2e70d121778337bf4bda9b5ef12ffbe4df664d/pay_ios/ios/Classes/ApplePayButtonView.swift#L141

@Jerem42 I haven't dug into it so I'm not sure how PKPaymentButton is built, I guess it's a native UI component like UIButton but more complex. I think if it can be solved from google-pay package side, it should be reported there for better support (I see there is an existing issue but closed, you can forward this info to that issue).


Adjust how fonts render in Windows

Windows is great at supporting a vast amount of hardware but for some users, they want their fonts to render differently.  This comes into play more and more with higher resolution screens.
Possible knobs:

Default text rendering
Force symmetric smoothing on
Force symmetric smoothing on and hinting off

Smashing magazine has a good overview of different rendering.
Note there are two major rendering systems inside Windows, DirectWrite and GDI.  Some applications handle their own rendering as well.
There is an open source project under GPLv3 that does something like this. https://github.com/snowie2000/mactype
Here is additional discussions on ClearType and other Microsoft Typography.

https://docs.microsoft.com/en-us/typography/cleartype/
https://docs.microsoft.com/en-us/typography/

DirectWrite Core is getting open sourced, so maybe that would be where these changes can come first?
https://github.com/microsoft/ProjectReunion/issues/112

A nerd font patcher would be cool considering the amount of time I spend for getting this python conda env symbol working properly:

There is an open-source project that fixes the rendering. And it uses DirectWrite btw https://github.com/snowie2000/mactype
Additionally it allows to choose, create and save preferences/profile, and it ships with some predefined profiles to get started right away
It could be such a nice PowerToy...

@murrto i directly called mactype out in my description 😄
But it is GPL so the licenses are incompatible

Another worth reading article:
https://pandasauce.org/post/linux-fonts/
I personally love mactype. Meslo looks horrible on Windows, I have to switch back to Lucida Console or something ClearType-optimized. However, mactype is not native, blurry in some places, and crashes many software.

What would be awesome is to get a font option that removes all the ClearType and anti-aliasing that causes what I perceive as a blurriness to fonts in order to get crisp clear edges on the font like Windows XP or when doing an RDP session to an old server. With Windows 7 I used to be able to do this with various tricks but since Windows 10 I haven't been able to do this. Even MacType doesn't do it.

What would be awesome is to get a font option that removes all the ClearType and anti-aliasing that causes what I perceive as a blurriness to fonts in order to get crisp clear edges on the font like Windows XP or when doing an RDP session to an old server. With Windows 7 I used to be able to do this with various tricks but since Windows 10 I haven't been able to do this. Even MacType doesn't do it.

@enricogior, while #6918 and the others, #10235 and #10466, are all about fonts, these are different requests. #6918 is about rendering. And the others are regarding more granular control over fonts, which is possible today but not supported in the Windows Shell. Since you closed #10466 and asked me to add comments here, I will gladly do that. :-)
Similar to #10235, I wrote:
People with low vision can manage fonts in a couple of different ways on Windows, including by changing their "Display Resolution" (in Display Settings) and by "Making text bigger" (in Ease of Access Settings).
However, these Settings do not enable users to adjust specific font sizes such as: Title bar, Menu, Message box, Secondary title, Icon or Status bar, which Windows used to support and can be adjusted independently with 3P apps. Similarly, 3P OSs and apps enable users to select Bold fonts for these same elements. They enable users to substitute their preferred font for the system font. They also enable users to save and to import and export font profiles.
In addition to being great for accessibility, this would be a great feature for power users that want to personalize their Windows experience.
@crutkas, I am also interested in your thoughts (as always :).

https://winaero.com/winaero-tweaker/
This program can change text and icons in various UI places.

@jeffpetty your ask is totally valid  but this issue much more on getting fonts to render via DWM differently where yours is more getting more surfaces enabled for font size adjustment.
We can clone your issue into a new one if I'm correct on your ask.

@crutkas that's right. Perhaps just reactive #10466, which was a new feature request for a UX to be able to manipulate the system fonts.

@Jay-o-Way, thanks for the link, I am looking for an app that does just this. Best case scenario, it would be from a trusted publisher and even ship inbox with Windows.

The current font rendering in Windows is awful, even compared to Linux desktops. Coding and reading text all day I always envied those with a Mac solely because of their fonts and font rendering. Hell even SF Mono on Windows looks bad.
If this ever gets implemented in a way it’d be my dream come true, so thank you for suggesting this as a feature.

@crutkas I support your suggestion to have a setting to force symmetric smoothing. Currently it is controlled by the GASP header in the font files. It says: at this font resolutions I want symmetric, at that font resolutions I want asymmetric and at other font resolutions I want no antialias at all. Only Windows is interpreting this, even at webfonts. The GASP header can be patched (search for GASPHACK) to enable symmetric rendering at all font resolutions. This fixes a lot but cannot be applied to all fonts.
2nd. At some modes, I think there is a real bug with cleartype. First cleartype is used to render the font including subpixel antialias (rgb in my case). But then this is converted to a monochrome rendering causing the subpixels converted to blurriness. This disables all optimizations of the font hinting. So if monochrome rendering is required due to some graphics driver limitations, I suggest to render without subpixel antialias. The trend to ultra HD monitors is hiding this a little.

Is this function still on schedule or has been abandoned already?

I'm waiting on this one as it would truly polish the experience on Windows. Especially zooming in and out and having trouble when changing font size, it's needed.
I assume Segoe UI Variable was intended to address the existing font rendering system, but the whole UI would benefit from this function.

This was my most anticipated feature. Now I am wondering if I'm ever going to see it implemented.

Windows font rendering is very thin. Looks especially poor on hi-res screens. Have to install Chrome plugins like this https://chrome.google.com/webstore/detail/fuentes-más-oscuras/hfpjgcmoeaohdmamngjmlenolmbhlnnd to make it at least somewhat thicker. Previously was using low-res screens to make fonts look thicker, but this isn't a solution at all anymore.

Still waiting....

A needed feature indeed.


[Build Script Helper] Setup environment variables for the specified toolchain's executables

If a toolchain is specified, set the search environment variable for each tool executable the driver cares about to ensure that the specified toolchain's specific version is used.

@swift-ci please test

I ran into this because on Ubuntu 16.04, even with a specified toolchain, the driver could not locate some executables. Curiously, this did not happen on Ubuntu 18.04 or 20.04.
I'm still trying to figure out why this specific version of Ubuntu breaks; but, regardless, I think this change is an improvement because it ensures that we do use the provided toolchain's executables, instead of relying on search paths and potentially accidentally using a wrong executable for any of these tools.


feat: preemptive authentication (#2435)

I like this change because I think preemptive authentication should be the default when clients know  ahead of time it will be required.  I've implemented this using network interceptors and it's works except that the oauth2 refresh token flow means to do it right (and not expose to clients) you would need the network interceptor and an authenticator to retry.  So I do like this and wouldn't put up much of a fight.
That said to do this right if we are implementing a more complete authenticator API I think we should consider the following features

Applying multiple authenticators e.g. a Twitter authenticator + Facebook authenticator
Which requests does a particular authenticator apply to?
synchronous token refresh flows.

my 2c, on the other hand it does vastly increase the scope of this change.

Authenticator predates Interceptor. It's less capable and I'd like to consider deprecating Authenticator.
I'd like for our users to use interceptors instead. We should fix whatever we need to fix in interceptors to make that nice. Perhaps built-in Basic and Digest interceptors?
We also need a strategy for proxy auth, but that can be completely separate.

Do we land this PR or similar before that bigger support library?

I don’t think we can land this because it adds a method to an interface, and that’s incompatible in all kinds of painful ways for our users.

sub interface is a possibility.  But that said, since it is possible with an interceptor, it does raise the question of why it's needed in the API you want to deprecate


404 Page not change after server start

Describe the bug
We have started the server, but the 404 error if you use a page that is not there, is only using the page version that is used on start. but not update it while you have changed the complete source.
To Reproduce

start server
open not existing url
change 404.html
open another not existing url

Expected behavior
use the updated 404.html
Logs/Screenshots
If applicable, add logs or screenshots to help explain your problem.
Environment and Specs

static-web-server: latest
OS: Ubuntu 20.04 with docker
Docker: latest
Client: latest chrome, latest firefox

Additional context
Add any other context about the problem here if needed.

Would it be alright to include a static 404 page for different MIME request types? And by default serve those?

I'm uploading the server but I have "404 Not Found" I want the files to appear and I don't expect an html file


Automated cherry pick of #2146: Update GO_BUILD_VERSION

Cherry pick of #2146 on release-v1.25.
#2146: Update GO_BUILD_VERSION

/merge-when-ready delete-branch

OK, I will merge the pull request when it's ready, leave the commits as is when I merge it, and delete the branch after I've merged it.

I'm sorry but I failed delete the branch after merging the pull request.


Please provide Docker file

Could you please provide Docker file to create needed environment?
I have downloaded project in the pytorch/pytorch docker, but has to fix some problems inside.
Also it will be useful to get instructions or script in Dockerfile how to download and build Openface project, which is dependency.

Also, it seems, there is no example how to run face emotions recognition only in the README.md file.

Sorry but at this moment, we are not using Docker and I am a little busy with other projects to create it. If I get some free time I will try to implement it, but for now, the repository is provided as it is, sorry. But if you create a new docker version, please, let me know and I will include it into the README to let other people have access to it. :)
Regarding face emotion recognition, I don't know if you are speaking about the 'static models' or the 'sequential models'.
For the static models, you can see an example in the comments at the header of the file MMEmotionRecognition/src/Video/models/staticModels/FeatureTrainingAUs.py (or in the README, as you say).
And for the sequential model, I have attached a new README in: MMEmotionRecognition/src/Video/models/sequenceLearning/README_AUS.md
I added a new README because the running of this model is more complex and I think it was easier to follow in a different README.
Thanks!

My current problem is in running emotion recognition using downloaded models.
I have downloaded and unpacked all RAVDESS video in the MMEmotionRecognition/RAVDESS directory.
And also models.zip was unpacked to the MMEmotionRecognition/models directory.
I have input video input.mp4 and picture file input.jpg.
What commands should be run to recognize emotions in there files?