Keyevent usb-hid code and AltGr

Steps to reproduce
Run the example code on macOS.
Expected results

PhysicalKeyboardKey. Usb hid code is 0x68, but the code should be 0x46 https://www.usb.org/sites/default/files/documents/hut1_12v2.pdf

LogicalKeyboardKey. Germany (DEU) input. AltGr will nerge be generated, instead it generate Alt Right.

Actual results
See above
Code sample
Code sample
import 'package:flutter/material.dart';

void main() {
  runApp(MyApp());
}

class MyApp extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'Keyboard Event Demo',
      theme: ThemeData(
        primarySwatch: Colors.blue,
      ),
      home: const KeyboardEventPage(),
    );
  }
}

class KeyboardEventPage extends StatefulWidget {
  const KeyboardEventPage({super.key});

  @override
  _KeyboardEventPageState createState() => _KeyboardEventPageState();
}

class _KeyboardEventPageState extends State<KeyboardEventPage> {
  final List<String> _lastKeyEvents = [];
  final FocusNode _focusNode = FocusNode();

  @override
  Widget build(BuildContext context) {
    final child = Scaffold(
      appBar: AppBar(
        title: const Text('Keyboard Event Demo'),
      ),
      body: Center(
        child: Column(
          mainAxisAlignment: MainAxisAlignment.center,
          children: <Widget>[
            const Text(
              'Press any key:',
              style: TextStyle(fontSize: 20),
            ),
            const SizedBox(height: 20),
            for (final keyEvent in _lastKeyEvents)
              Text(
                keyEvent,
                style: const TextStyle(fontSize: 16),
              ),
          ],
        ),
      ),
    );
    return FocusScope(
      autofocus: true,
      child: Focus(
        autofocus: true,
        canRequestFocus: true,
        focusNode: _focusNode,
        onKeyEvent: (node, event) {
          setState(() {
            _lastKeyEvents.add(event.toString());
            if (_lastKeyEvents.length > 10) {
              _lastKeyEvents.removeAt(0);
            }
          });
          return KeyEventResult.handled;
        },
        child: child,
      ),
    );
  }
}

Screenshots or Video

Screenshots / Video demonstration

Logs
No response
Flutter Doctor output
Doctor output
[✓] Flutter (Channel stable, 3.19.6, on macOS 12.7.5 21H1222 darwin-x64, locale en-US)
    • Flutter version 3.19.6 on channel stable at /Users/admin/workspace/devenv/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 54e66469a9 (4 months ago), 2024-04-17 13:08:03 -0700
    • Engine revision c4cd48e186
    • Dart version 3.3.4
    • DevTools version 2.31.1
    • Pub download mirror https://mirrors.tuna.tsinghua.edu.cn/dart-pub
    • Flutter download mirror https://mirrors.tuna.tsinghua.edu.cn/flutter

[✗] Android toolchain - develop for Android devices
    ✗ Unable to locate Android SDK.
      Install Android Studio from: https://developer.android.com/studio/index.html
      On first launch it will assist you in installing the Android SDK components.
      (or visit https://flutter.dev/docs/get-started/install/macos#android-setup for detailed instructions).
      If the Android SDK has been installed to a custom location, please use
      `flutter config --android-sdk` to update to that location.

[!] Xcode - develop for iOS and macOS (Xcode 14.2)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 14C18
    ! CocoaPods 1.12.1 out of date (1.13.0 is recommended).
        CocoaPods is used to retrieve the iOS and macOS platform side's plugin code that responds to your plugin usage on the Dart
        side.
        Without CocoaPods, plugins will not work on iOS or macOS.
        For more info, see https://flutter.dev/platform-plugins
      To upgrade see https://guides.cocoapods.org/using/getting-started.html#updating-cocoapods for instructions.

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[!] Android Studio (not installed)
    • Android Studio not found; download from https://developer.android.com/studio/index.html
      (or visit https://flutter.dev/docs/get-started/install/macos#android-setup for detailed instructions).

[✓] VS Code (version 1.92.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.94.0

[✓] VS Code (version 1.73.1)
    • VS Code at /Users/admin/Downloads/Visual Studio Code.app/Contents
    • Flutter extension version 3.94.0

[✓] Connected device (2 available)
    • macOS (desktop) • macos  • darwin-x64     • macOS 12.7.5 21H1222 darwin-x64
    • Chrome (web)    • chrome • web-javascript • Google Chrome 127.0.6533.120

[!] Network resources
    ✗ An HTTP error occurred while checking "https://github.com/": Connection closed before full header was received

! Doctor found issues in 4 categories.

Hi @fufesou
Can Option + Control be equivalent to AltGR? (Per https://support.apple.com/en-vn/102221)
I checked this using keychron k1 bluetooth keyboard which has Option + Control on the right and here is the result:

Can you also verify this on the latest Flutter stable/master channel? Thanks!

Can Option + Control be equivalent to AltGR? (Per https://support.apple.com/en-vn/102221)

No. I've tried Option Left + Control Left and  Option Right + Control Left.
And your screenshot also did not generate AltGr.
https://github.com/flutter/flutter/blob/fbed99fd4bc43bea899c4de39240badb82235809/packages/flutter/lib/src/services/keyboard_key.g.dart#L732

Can you also verify this on the latest Flutter stable/master channel? Thanks!

I've tried flutter 3.24.0, same issue.

I just want to make the steps to be more clearly. Can you confirm the steps below?

Run the example code on macOS
In case it's US keyboard layout, press Option/Alt Left + Control Left or Option/Alt Right + Control Left. In case it's Germany keyboard layout, press AltGR key.

Actual result: it detects separate key events (Option/Alt Left + Control Left or Option/Alt Right + Control Left) instead of AltGR key event
Expected result: able to detect AltGR key event

I don't have a keyboard that has AltGR key so I can't try this. Can you also confirm this on Web app?

I've tested. Still the same issue. Both macOS and Web app.
BTW, I don't think you need to have a keyboard that has AltGR.
I just change the input source to German. The Alt/Option Right should be AltGr.

Thanks for the update. I changed the input source to German and saw Alt Right only as well. Checked on Flutter stable 3.24.1`` and master 3.25.0-1.0.pre.102`.

cc @dkwingsmt


Post and Put not working

In this simple script:

const express = require('express')
const expressNedbRest = require('express-nedb-rest')
const Datastore = require('nedb')
// setup express app
const oApp = express()
// create  NEDB datastore
//const nedb = require('nedb');
//const dbUsers = new Datastore({ filename: 'database/users.db', autoload: true })
const dbFruits = new Datastore({ filename: 'database/fruits.db', autoload: true })
// create rest api router and connect it to datastore
const restApi = expressNedbRest()
//restApi.addDatastore('test', dbUsers)
restApi.addDatastore('fruit', dbFruits)
// setup express server to serve rest service
oApp.use('/', restApi);
oApp.listen(8080, function () {
console.log('you may use nedb rest api at port 8080');
});
//http://localhost:8080/fruit

Gets work fine but when I test Puts and Posts with Postman, it only writes the _id field. Any help?

Hi,
which data did you send to the URL? You have to post a JSON with the properties.
Regards
Torsten

Hi. I send data as is show in this printscreen:

Hi! I tried that, but the result was the same... :(

Sorry for my wrong example, You have to use the POST method to create an entry. The PUT method is for updating an existing entry. Please have a look in the README (https://github.com/bi-tm/express-nedb-rest#api-schema) and the examples in the little test program.
Regards
Torsten

Problem solved! TY!


Making the Classloader threadsafe

:tada: This PR is included in version 0.8.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


[service-bus] Clear out the connectionContext.streamingReceiver (and probably batchingReceiver) when a close happens.

As part of #10448 there were a few great suggestions, one of which was to see if we could just clear out the connectionContext.streamingReceiver field when we close the StreamingReceiver. Changes have been made so that the connection context is basically per-receiver at this point so this should be a pretty safe change.
So it just needs testing.

@ramya-rao-a basically did this in #10674 when she made deleteFromCache a formal part of LinkEntity (combined with migrating all the relevant fields of ClientEntityContext to ConnectionContext).


Signing threshold

I created 5 instances with local parties.
Key generation is okay.
Signing step is okay when all parties are "available".
When I stop 1 instance (after key was generated), signing is not going. Other parties stuck with message tss-libtss/party.go:162	party {1,test}: signing round 1 update
Threshold e.g = 2

@grkamil  Can you help in creation of keys and signing


[nrf fromtree] net: http: update status if no status text is provided

Call on_status if the Reason-Phrase is not provided.
This allows for the numeric status code to be set.
Also, ensure the numeric status code is always set
in on_status, not just if the specific callback is set.
Signed-off-by: Justin Morton<EMAIL_ADDRESS>

This commit is needed for https://github.com/nrfconnect/sdk-nrf/pull/4609
The cloud items blocking the above PR will be resolved the week of July 26.
If the next upmerge will occur between now and July 31, this PR can be closed.

@carlescufi When do we start the next upmerge?

@carlescufi When do we start the next upmerge?

Just saw this now, can we close this?

closing, changes will be brought in via upmerge.


Documention link are not working

The updated documentation links are broken. It shows Unresolved directive in ... error.
https://camunda.github.io/camunda-bpm-spring-boot-starter/
example:
https://camunda.github.io/camunda-bpm-spring-boot-starter/docs/current/index.html

Documentation is broken since 28f7e50d3d6c4408c5c2b3271767790d6f2e6fa3

Do you know if this is because of
a) filenames beginning with number are illegal
b) the relative path changelog/index.adoc -> index.adoc -> 212.adoc is broken?

Hi Guys,
Is there any alternative link for these tutorials? I am looking for something, where on spring rest API calls, I can run any process or task with data. Instead of too much conversion of data.

The 2.0.0 documentation still works https://camunda.github.io/camunda-bpm-spring-boot-starter/docs/2.0.0/index.html
and of Cours you can always check the doc files directly https://github.com/camunda/camunda-bpm-spring-boot-starter/tree/master/docs/src/main/asciidoc

I worked on the includes, so at least maven clean generate does not fail or warn anymore ... how to apply these changes? Do I have to run publish-docs? Not really sure what to do ... can you help, @hawky-4s- ?

any news @hawky-4s- ?

I will check today


HADOOP-16524. Reloading SSL keystore for both DataNode and NameNode

Addresses https://issues.apache.org/jira/browse/HADOOP-16524, in addition covering the DataNode use case.

Following the existing ReloadingX509TrustManager, a new ReloadingX509KeystoreManager was created.
Existing code slightly refactored so both trust manager and keystore reloading managers share the monitoring logic within a single java.util.Timer (and therefore a single thread).
In HttpServer2, the same strategy as a previously proposed patch (see above) is used with SSLContextFactory.reload, but with the addition of cleanup upon stopping the server.
A new config parameter which applies to all of the above FileBasedKeyStoresFactory.SSL_STORES_RELOAD_INTERVAL_TPL_KEY supersedes the existing FileBasedKeyStoresFactory.SSL_TRUSTSTORE_RELOAD_INTERVAL_TPL_KEY which only applies to trust store reloading. Setting the value to 0 (default is 10s) to this parameter disables the reloading.

If this PR is accepted, I would need guidance where/how to update the docs with that new configuration parameter.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
1m 25s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+1 :green_heart:
@author
0m  1s

The patch does not contain any @author tags.

+1 :green_heart:

0m  0s
test4tests
The patch appears to include 2 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
36m 56s

trunk passed

+1 :green_heart:
compile
21m 45s

trunk passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04

+1 :green_heart:
compile
18m 27s

trunk passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

+1 :green_heart:
checkstyle
0m 49s

trunk passed

+1 :green_heart:
mvnsite
1m 29s

trunk passed

+1 :green_heart:
shadedclient
19m 56s

branch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
1m 28s

trunk passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04

+1 :green_heart:
javadoc
1m 33s

trunk passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

+0 :ok:
spotbugs
2m 22s

Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
2m 20s

trunk passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 56s

the patch passed

+1 :green_heart:
compile
21m 14s

the patch passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04

+1 :green_heart:
javac
21m 14s

the patch passed

+1 :green_heart:
compile
18m 25s

the patch passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

+1 :green_heart:
javac
18m 25s

the patch passed

-0 :warning:
checkstyle
0m 49s
/diff-checkstyle-hadoop-common-project_hadoop-common.txt
hadoop-common-project/hadoop-common: The patch generated 270 new + 68 unchanged - 11 fixed = 338 total (was 79)

+1 :green_heart:
mvnsite
1m 26s

the patch passed

+1 :green_heart:
whitespace
0m  0s

The patch has no whitespace issues.

+1 :green_heart:
shadedclient
17m 15s

patch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
0m 57s

the patch passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04

+1 :green_heart:
javadoc
1m 28s

the patch passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

+1 :green_heart:
findbugs
2m 29s

the patch passed

_ Other Tests _

+1 :green_heart:
unit
10m  7s

hadoop-common in the patch passed.

+1 :green_heart:
asflicense
0m 47s

The patch does not generate ASF License warnings.

185m 34s

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2470/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2470

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux c8a7c4d33c05 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / a7b923c80c6

Default Java
Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2470/1/testReport/

Max. process+thread count
1879 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2470/1/console

versions
git=2.17.1 maven=3.6.0 findbugs=4.0.6

Powered by
Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m  0s

Docker mode activated.

-1 :x:
docker
5m 36s

Docker failed to build yetus/hadoop:4b312810ae0.

Subsystem
Report/Notes

GITHUB PR
https://github.com/apache/hadoop/pull/2470

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2470/2/console

versions
git=2.17.1

Powered by
Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
30m 48s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:

0m  0s
test4tests
The patch appears to include 2 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
35m 34s

trunk passed

+1 :green_heart:
compile
21m 27s

trunk passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04

+1 :green_heart:
compile
18m  4s

trunk passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

+1 :green_heart:
checkstyle
0m 49s

trunk passed

+1 :green_heart:
mvnsite
1m 27s

trunk passed

+1 :green_heart:
shadedclient
19m 40s

branch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
0m 57s

trunk passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04

+1 :green_heart:
javadoc
1m 29s

trunk passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

+0 :ok:
spotbugs
2m 21s

Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
2m 19s

trunk passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 54s

the patch passed

+1 :green_heart:
compile
21m 55s

the patch passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04

+1 :green_heart:
javac
21m 55s

the patch passed

+1 :green_heart:
compile
20m 20s

the patch passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

+1 :green_heart:
javac
20m 20s

the patch passed

-0 :warning:
checkstyle
1m  0s
/diff-checkstyle-hadoop-common-project_hadoop-common.txt
hadoop-common-project/hadoop-common: The patch generated 168 new + 68 unchanged - 11 fixed = 236 total (was 79)

+1 :green_heart:
mvnsite
1m 42s

the patch passed

+1 :green_heart:
whitespace
0m  0s

The patch has no whitespace issues.

+1 :green_heart:
shadedclient
19m 27s

patch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
1m 11s

the patch passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04

+1 :green_heart:
javadoc
1m 39s

the patch passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

+1 :green_heart:
findbugs
2m 50s

the patch passed

_ Other Tests _

-1 :x:
unit
10m 40s
/patch-unit-hadoop-common-project_hadoop-common.txt
hadoop-common in the patch passed.

+1 :green_heart:
asflicense
0m 57s

The patch does not generate ASF License warnings.

217m 30s

Reason
Tests

Failed junit tests
hadoop.security.TestFixKerberosTicketOrder

hadoop.metrics2.source.TestJvmMetrics

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2470/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2470

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux 055faef77fb3 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / aaf9e3d320a

Default Java
Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2470/3/testReport/

Max. process+thread count
1345 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2470/3/console

versions
git=2.17.1 maven=3.6.0 findbugs=4.0.6

Powered by
Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

LGTM.
Have you tried it? If so, want to dump in here what you've done?
The original patch posted did not cover DN (See JIRA). This works for DN and NN?
Thanks.

Yes, both DN and NN are covered and this was integration tested (manually) in a pre-prod environment on all nodes. DevOps team happy with it.
Thanks so much for the review!

Rerunning tests to see if failures related (Getting ready to merge)

Rerunning tests to see if failures related (Getting ready to merge)

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
1m 23s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:

0m  0s
test4tests
The patch appears to include 2 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
36m 23s

trunk passed

+1 :green_heart:
compile
21m 56s

trunk passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04

+1 :green_heart:
compile
18m 21s

trunk passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

+1 :green_heart:
checkstyle
0m 48s

trunk passed

+1 :green_heart:
mvnsite
1m 30s

trunk passed

+1 :green_heart:
shadedclient
19m 30s

branch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
0m 59s

trunk passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04

+1 :green_heart:
javadoc
1m 33s

trunk passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

+0 :ok:
spotbugs
2m 20s

Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
2m 19s

trunk passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 56s

the patch passed

+1 :green_heart:
compile
25m 46s

the patch passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04

+1 :green_heart:
javac
25m 46s

the patch passed

+1 :green_heart:
compile
22m  7s

the patch passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

+1 :green_heart:
javac
22m  7s

the patch passed

-0 :warning:
checkstyle
0m 49s
/diff-checkstyle-hadoop-common-project_hadoop-common.txt
hadoop-common-project/hadoop-common: The patch generated 167 new + 68 unchanged - 11 fixed = 235 total (was 79)

+1 :green_heart:
mvnsite
1m 32s

the patch passed

+1 :green_heart:
whitespace
0m  0s

The patch has no whitespace issues.

+1 :green_heart:
shadedclient
17m 54s

patch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
1m  0s

the patch passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04

+1 :green_heart:
javadoc
1m 32s

the patch passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

+1 :green_heart:
findbugs
2m 30s

the patch passed

_ Other Tests _

+1 :green_heart:
unit
10m 19s

hadoop-common in the patch passed.

+1 :green_heart:
asflicense
0m 50s

The patch does not generate ASF License warnings.

191m 58s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2470/4/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2470

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux 75ee856a1074 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 1b1791075a8

Default Java
Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2470/4/testReport/

Max. process+thread count
2328 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2470/4/console

versions
git=2.17.1 maven=3.6.0 findbugs=4.0.6

Powered by
Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
1m 23s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:

0m  0s
test4tests
The patch appears to include 2 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
36m 23s

trunk passed

+1 :green_heart:
compile
21m 56s

trunk passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04

+1 :green_heart:
compile
18m 21s

trunk passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

+1 :green_heart:
checkstyle
0m 48s

trunk passed

+1 :green_heart:
mvnsite
1m 30s

trunk passed

+1 :green_heart:
shadedclient
19m 30s

branch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
0m 59s

trunk passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04

+1 :green_heart:
javadoc
1m 33s

trunk passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

+0 :ok:
spotbugs
2m 20s

Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
2m 19s

trunk passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 56s

the patch passed

+1 :green_heart:
compile
25m 46s

the patch passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04

+1 :green_heart:
javac
25m 46s

the patch passed

+1 :green_heart:
compile
22m  7s

the patch passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

+1 :green_heart:
javac
22m  7s

the patch passed

-0 :warning:
checkstyle
0m 49s
/diff-checkstyle-hadoop-common-project_hadoop-common.txt
hadoop-common-project/hadoop-common: The patch generated 167 new + 68 unchanged - 11 fixed = 235 total (was 79)

+1 :green_heart:
mvnsite
1m 32s

the patch passed

+1 :green_heart:
whitespace
0m  0s

The patch has no whitespace issues.

+1 :green_heart:
shadedclient
17m 54s

patch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
1m  0s

the patch passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04

+1 :green_heart:
javadoc
1m 32s

the patch passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

+1 :green_heart:
findbugs
2m 30s

the patch passed

_ Other Tests _

+1 :green_heart:
unit
10m 19s

hadoop-common in the patch passed.

+1 :green_heart:
asflicense
0m 50s

The patch does not generate ASF License warnings.

191m 58s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2470/4/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2470

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux 75ee856a1074 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 1b1791075a8

Default Java
Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2470/4/testReport/

Max. process+thread count
2328 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2470/4/console

versions
git=2.17.1 maven=3.6.0 findbugs=4.0.6

Powered by
Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

@saintstack Thanks for your contribution.
This PR caused failures to other unit tests. Can you please take a look to the list of failures.
https://issues.apache.org/jira/browse/HADOOP-16524?focusedCommentId=17262765&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17262765

@saintstack Thanks for your contribution.
This PR caused failures to other unit tests. Can you please take a look to the list of failures.
https://issues.apache.org/jira/browse/HADOOP-16524?focusedCommentId=17262765&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17262765


igv: 2.17.1 -> 2.17.2

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://repology.org/project/igv/versions.
meta.description for igv is: A visualization tool for interactive exploration of genomic datasets
meta.homepage for igv is: https://www.broadinstitute.org/igv/
Updates performed

Version update

To inspect upstream changes
Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 2.17.2 in filename of file in /nix/store/8rwhin7gba28v8h4m9agb9rprw99agn6-igv-2.17.2

Rebuild report (if merged into master) (click to expand)

1 total rebuild path(s)

1 package rebuild(s)

First fifty rebuilds by attrpath
igv

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/8rwhin7gba28v8h4m9agb9rprw99agn6-igv-2.17.2 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A igv https://github.com/r-ryantm/nixpkgs/archive/5ca14e22c6673701224986dd34662b99d9aee08a.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/5ca14e22c6673701224986dd34662b99d9aee08a#igv

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/8rwhin7gba28v8h4m9agb9rprw99agn6-igv-2.17.2
ls -la /nix/store/8rwhin7gba28v8h4m9agb9rprw99agn6-igv-2.17.2/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

igv

Maintainer pings
cc @mimame for testing.

Result of nixpkgs-review pr 287668 run on aarch64-darwin 1

1 package built:

igv


Seperate loot tracker entries for fail/completed corrupted gauntlet

I think it would be better if loot tracker entered gauntlet completions and fails into seperate entries, it would be nice to be able to get a better idea of average loot from a completion rather than it being like this, which is probably like 15 deaths 10 completions

In the same vein, being able to separate normal from corrupted gauntlet would be useful, since the loot is given out in higher quantities.
How I'm thinking it would work would be to track what you were fighting directly before you open the chest. An alternative would be to track chat messages, though there aren't too many of them.

Is there any progress on this one? I can't find much in the plugin hub and this would be a great option to have.

Would love this!


ModMenu thinks v2.6.10 on Modrinth is newer than v2.6.11 (Also on Modrinth)

ModMenu's update check doesn't seem to be that good or accurate as it tells me that the mod "Fast Load" has a new update available on Modrinth.
The update in question is v2.6.10 (Or v1.19.3.fabric.2.6.10 as it is shown), which obviosuly isn't newer than 2.6.11 which is installed.
I think ModMenu thinks it's newer because the latest version for the loader (Fabric) is set to 2.6.11, while the previous version is set as 1.19.3.fabric.2.6.10.
Idk if there would be a fix for this, but perhaps a tool like FlexVer should be used for comparing versions, as it usually is capable of recognizing different version patterns like the above and properly determine if the version is actually new or not.
Screenshot:

Ah, yeah. You're running Quilt and the latest version on Modrinth available for Quilt is 2.6.10. Hmm...

Ah, yeah. You're running Quilt and the latest version on Modrinth available for Quilt is 2.6.10. Hmm...

Yeah... Idk, it's a bit weird for me. It should still prioritize the version tho imo, even if latest version is only fabric and not quilt.

Going to say this is an issue on Modrinth's end: https://github.com/modrinth/labrinth/issues/545

Makes sense. I'll close this issue and hope this can be resolved on Modrinth's end.


Applying Grayscale GLFilter removes BitmapOverlayFilters

Hi there,
I am using LiTr to transcode videos and apply video overlays, in the 1.4.3 update I have found a bug.
Applying a GrayscaleFilter seems to prevent BitmapOverlayFilter from being applied. We apply the filters as such
                if (targetTrack is MediaTrackSettings.VideoSettings) {
                    val overlayFilters: MutableList<GlFilter> = overlays.map {
                        val bitmap = BitmapFactory.decodeFile(it.filepath)
                        BitmapOverlayFilter(bitmap, Transform(PointF(1f, 1f), PointF(.5f, .5f), 0f))
                    }.toMutableList()
                    overlayFilters.apply {
                        if (applyGrayscaleFilter) {
                            add(GrayscaleFilter())
                        }
                    }
                    setRenderer(GlVideoRenderer(overlayFilters))
                }

Previously, on version 1.3.2, adding multiple filters (when applyGrayscaleFilter is true) was working as intended for us.
Is there an issue in how I am applying the filters? Or perhaps a bug here.

Filter ordering matters, since it defines a Z order. So usually, implementations of GlFrameRenderFilter (such as GrayscaleFilter) should be applied first, so that video is rendered underneath bitmaps. I tried that, it works for me. Discovered an unrelated bug, which I will be fixing, so thank you. :)

Thank you! Will try that

Works! Closing


Troubleshoot build failures by skipping tests that sometime precipita…

…te unpredictable errors.

merging for expediency in troubleshooting cycle


Add support for Fabric Loader 0.16.0 and higher

There may be a bug, but the mod does not run on fabric loader versions above 0.15.11 and above

https://github.com/ThinkingStudios/RyoamicLights/issues/40#issuecomment-2295410720
try 0.2.8

hmm 0.2.9 and 0.2.11 work perfectly on latest loader 0.16.2

Hmm, when I run the latest version 0.2.11, I get an error and the game does not start https://mclo.gs/WKF2XDy

0.2.8 not work


exchange mode only direct, it not enought, may be should add topic etc.

exchange mode only direct, it not enought, may be should add topic etc.

Sure, I can look into that

Hi @lorentz-wu, sorry for the big delay, can you elaborate more on your use case?

Hi @pmorelli92, can you see if other exchange types can be added?
It would be very helpful, thank you!
https://medium.com/trendyol-tech/rabbitmq-exchange-types-d7e1f51ec825

@tomaswarynyca, as I asked before, what is the use case you are trying to achieve? The direct exchange approach that the library supports does not mean one event one receiver, as if multiple queues bind to the same routing key on the same exchange they will all receive the event:
Queue1 binds to "order.processed" on exchange Foo
Queue2 binds to "order.processed" on exchange Foo
Publisher publishes event "order.processed" on exchange Foo.
Queue1 receives event.
Queue2 receives event.
Configuring different exchange type is not hard to do, but I want to make sure what is the use case for it :)

@pmorelli92 In my case I would like to use the library for an event system, a service publishes a message and there are multiple services listening to do something with that message.

That is doable with the functionality I exposed above :)
I suggest you to check the tests to get a better understanding on how to make it work but I will also add a snippet in this comment. Please tell me if you could make it work :)
User service:
eventHandler := func(ctx context.Context, event bunnify.ConsumableEvent[orderProcessed]) error {
	return nil
}

consumer := connection.NewConsumer(
		"user-queue",
		bunnify.WithQuorumQueue(),
		bunnify.WithBindingToExchange("default-exchange"),
		bunnify.WithHandler("order.processed",  eventHandler))

Invoice service:

eventHandler := func(ctx context.Context, event bunnify.ConsumableEvent[orderProcessed]) error {
return nil
}
consumer := connection.NewConsumer(
"invoice-queue",
bunnify.WithQuorumQueue(),
bunnify.WithBindingToExchange("default-exchange"),
bunnify.WithHandler("order.processed",  eventHandler))

Order service:

eventToPublish := bunnify.NewPublishableEvent(orderProcessed{
ID: orderID,
})
err := publisher.Publish(
context.TODO(),
"default-exchange",
"order.processed",
eventToPublish)
if err != nil {
t.Fatal(err)
}

You can look more information here: https://github.com/pmorelli92/bunnify/blob/a44442cab4ad794244b80947451853845c09009c/tests/consumer_publish_test.go#L15

I assume the use case is fulfill with what I explained above, can I close @tomaswarynyca ?

I assume the use case is fulfill with what I explained above, can I close @tomaswarynyca ?

For my case it seems that yes, in the next few days I will develop it and I will comment you

@pmorelli92 for my use case with the current code it works perfectly, unless @lorentz-wu has a different use case we can close this issue for the moment, thanks for your help!


Helm chart rename - Step #1

IMPORTANT - This needs to be merged before PR https://github.com/kubernetes-sigs/descheduler/pull/457 and PR https://github.com/kubernetes-sigs/descheduler/pull/459.
This PR will deprecate the existing descheduler-helm-chart ready for it to renamed to descheduler.

/assign @damemi

/ok-to-test

Deprecation notice seemed to work well: https://github.com/kubernetes-sigs/descheduler/blob/9e35349/index.yaml#L8
Will move on to Step 2 now...


OPA/Rego AND operator usage

I am new to OPA(and Rego) and writing simple policies. My use-case is the policy should return true when both input.path and input.headers values match and return false when one of them does not match. When I execute below policy I am not getting expected result. Could you please point me an example policy that shows usage of AND operator. I tried using semi-colon and it also did not work. I am using Rego playground to execute my examples.
Policy:
package demo

default allow = false

allow = {
        input.path == "/api/v1/employees/departments",
        input.headers["x-custom-header"] == "foo"
}

Input:
{
       "path":"/api/v1/employees/divisions",
       "headers": {
              "x-custom-header" :"foo"
        }
}

As I have passed incorrect path, expected Output should be below:
{
     "allow": [
           false
     ]
}

However i see actual Output as below:
{
     "allow": [
           false,
           true
     ]
}

@gituserjava ; you could do something like:

https://play.openpolicyagent.org/p/y0EIjvH1tZ

but, since you said you are new to rego, I'd join the slack channel and ask questions there.

https://slack.openpolicyagent.org/


We don't support VolumesFrom or links

Signed-off-by: Daniel J Walsh<EMAIL_ADDRESS>

@umohnani8 PTAL

LGTM

Git validation is complaining because you have trailing whitespace on your commit message

That is why  you never use vi to edit, emacs cleans this up automatically.  Repushed.

LGTM

@rh-atomic-bot r=mheon


MM-15871 strengthened one-time checks for auth links

The issue was that specific (Jira-side) "connect" links could not be reused, but a user could generate a number of simultaneously valid links.
For the cloud auth now handle this by storing the mmuserid->secret mapping, and then verifying the secret in the link.
For Server, Jira appears to ignore the secret value, but still protect the link from multiple use by deleting the stored key after its first use.

Taking a look at the security around this more closely.

Replacing with https://github.com/mattermost/mattermost-plugin-jira/pull/110


Coalesce function match error in tpcds

Describe the bug
The tpcds query: 49,67,77,80 which has the subquery like sum(coalesce(decimal, int)) could not be executed.
The exception (SUM requires a numeric parameter: sum(coalesce(ss_sales_price * ss_quantity, 0))) will be thrown.
To Reproduce

create a table with decimal column.
select sum(coalesce(decimal_column, 1)) from table
palo thrown exception

Expected behavior
If the value of  decimal_column is notnull return the value of column, else return 1.

The reason is that the function coalesce(varchar, varchar) match the function of coalesce(decimal, int) in doris.
For the IS_SUPERTYPE_OF of compare mode, it will find the match function from front to back. In function declaration, the coalesce(varchar, varchar) in front of the coalesce(decimal, decimal).
The priority of coalesce function in IS_SUPERTYPE_OF compare mode is incorrect. So the outer layer function(sum) could not handle the varchar of input param.

#2003


Add support for multi-modal navigation

As a developer I want to be able to present several modals with the router in place.
This might also fix the leak described in #380 (issue 3).
Hints
A recipe is provided in the following article.
Acceptance criteria

Playlist demo modals are managed with the app router.

Tasks

[ ] Update router for multi-modal support (see linked article above).
[ ] Update PlaylistView.
[ ] Update TransitionView.

Here is a possible problem statement for the general case of displaying N modals, with basic API design inspired by NavigationStack.
MultipleModal.zip


[docs] Demo LoadingButtonsTransition crashes

[ ] I have searched for similar issues in this repository and believe that this is not a duplicate.

Steps to Reproduce

Visit https://mui.com/components/buttons/
NotFoundError: Failed to execute 'insertBefore' on 'Node': The node before which the new node is to be inserted is not a child of this node.
demo LoadingButtonsTransition crashes

Your Environment

Tech
Version

MUI
v5.4.4

netlify deploy
https://622508383de09400082811a4--material-ui-docs.netlify.app

Browser
Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/99.0.4844.51 Safari/537.36

Hey @Kosuko , thanks for the headsup. I'm not being able to reproduce this issue, can you point me to what exactly crashed for you?

Same problem here with LoadingButton. I'm not sure why this happens, but I have a boolean-type state and when executing a function it sets this value to true and when finished, sets it to false. I use this to determine if loading should appear. Whenever this state is changed, the error reported in the issue occurs.


Conflict after stree pull

I was giving git-stree a try, because it seemed to be a good alternative to git-subtree. But even in my very simple scenario, I ran into a conflict:
both added:      lib/sub/README

The conflicted file looks like this:
My super library

<<<<<<< HEAD
hahaha
=======
>>>>>>> stree-sub/master

In the "sub" repo, I just removed the line containing "hahaha". In the container repo, I didn't make any change, so there shouldn't be a conflict. What am I doing wrong?
Here's my complete test scenario:

Create a "main" repo (the container), add a "hello.txt" file to it, and commit it
Create a "sub.git" bare repo
Create a "sub" repo, add a README file to it, commit and push to sub.git
In main, add a subtree for sub:

git stree add sub -P lib/sub ../sub.git

Still in main, make an edit to "hello.txt" and commit it
In sub, make an edit to README.txt, commit it and push it
In main, pull the changes from sub:

git stree pull sub

The tree looks like this:
test-stree
├───main
│   │   hello.txt
│   │
│   └───lib
│       └───sub
│               README
│
├───sub
│       README
│
└───sub.git

I didn't make any edit to README in the main repo, so why is there a conflict?

For completeness, here's the history for main:
8d02fd4 (HEAD, master) Edited hello.txt
6214710 [STree] Added stree 'sub' in lib/sub
d344ac8 Initial commit

And for sub:
8eb3d80 (HEAD, origin/master, master) Removed 'hahaha'
2e492da Initial commit

I can resolve the conflict manually of course, but then, everytime I pull new changes from sub, I get a similar conflict on a file I didn't touch...

Hey Thomas,
You’re correct, I can reproduce this.  Clearly there are issues with
Git's subtree merge.  This behavior happens even when attempting a
regular merge with -X subtree=lib/sub, which is as explicit as it goes.
We're currently investigating an alley based on an early git merge -s  ours, that might help fix a number of pull-related issues.  Stay tuned.
Best,
--
Christophe Porteneuve
Founder & CTO, Delicious Insights
<EMAIL_ADDRESS>+33 662 059 656

Ref: https://github.com/tdd/git-stree/pull/23
I fixed it for my needs by adding a merge strategy option: https://gist.github.com/anonymous/5ca8bc8abd59c7006370#file-git-stree-L458

I made a simple test, two remote repositories (#1, #2). Clone #1, git stree #2 in the subfolder.
git stree push works as expected.
If I edit a file in #2, add and commit and then do the git stree pull #2 I get the conflict in this edited file.
This is sadly useless for any edits made upstream in the library I want to stree in the main repo I am running now. I thought that this will solve all my problems as it looked very promising. Sadly it does not work at all, every edit in the lib is conflicting with the untouched files in the imported stree... :(

There are more changes than just that one line in the gist.  Did you use the entire gist version?

Yes, I just copied it over to old, I have also seen that it makes .gitstree file etc.. but for me it still creates the conflict merge

Just an added note to throw into the mix and in preparation for the holiday fix....  The "standard" stree (TDD's) was working great for me pushing and pulling from shared repo(s) on multiple libraries to and from multiple containers.  But the last pull I did pulled in code from the wrong stree.  I can't put code out as an example so will need to come up with one that I can post on github that replicates this (TODO).  I reviewed the gist code but there were so many changes I felt a little uncomfortables with the -Xours and -Xtheirs options so just did a manual git merge -X subtree="<subt-tree-name" stree-/.  And that "worked" but this option on the recursive strategy seems to always flag any change to any file in the repository as a conflict.  I tried this with multiple "test repositories" and the same thing every time.  Then I realized this is probably why the -Xours and the -Xtheirs options were created in the first place and why the gist includes two different pull commands (pullours/pulltheirs).  But again, if their really is a conflict I'd rather be the one making the call on which code I am going to keep.  So for now I've opted to just used the subtree strategy (TDD's original) but before I do a stree pull I create a branch specifically for that purpose so I can see what is happening and can revert back to the pre-pull state if there is a problem.  Thus far I've only had one instance where I needed to use the recursive strategy with the -X subtree option and, of course, I had to manually resolve conflicts on that pull.  But believe me this is still better than the subtree's push and pull approach.  Especially since the push takes forever traversing every commit.

Below is a bash script that demonstrates a very simple case where the both the subtree strategy (e.g. -s subtree) and the recursive strategy with the subtree option (e.g. -s recursive -X subtree="<sub-tree-name>") detect a conflict where there really should not be a conflict.  Which makes me think that the bug lies in the git merge command code itself.
#! /bin/bash

#This script replicates an example of when the `git stree pull command`
#detects a conflict that should not be a conflict.

echo "Checking for existence of temp_stree_test directory...."
if [ -d "temp_stree_test" ]
then
	echo "Deleting temp_stree_test directory...."
	rm -rf temp_stree_test
fi
echo "Making directory 'temp_stree_test'...."
mkdir temp_stree_test

cd temp_stree_test

mkdir container_app

mkdir stree_lib

cd container_app

echo "Create ReadMe.txt file..."
echo "This is a container example..." > ReadMe.txt

echo "Create git repository with ReadMe.txt file..."
git init

git add ReadMe.txt

git commit -m "Initial Commit"

echo "Create git repository with another ReadMe.txt file for repo that will later be stree...."
cd ../stree_lib
cd ../stree_lib

echo "This is library repository..." > ReadMe.txt

git init

git add ReadMe.txt

git commit -m "Initial Commit"

echo "Move back into container repository to add stree...."
cd ../container_app

git stree add stree_lib -P stree_lib ../stree_lib master

echo "Move back into standalone stree repo and make a change..."
cd ../stree_lib

echo "Appending new line of text to ReadMe.txt..."
echo "\rHere is a new line of text" >> ReadMe.txt
git add ReadMe.txt

git commit -m "Added new Line of text"

echo "Moving back into container to perform stree pull..."


Snowplow SDK request

Please provide information about the SDK
Name: Snowplow Tracker
Uses:
Owner: Snowplow
Links to the SDK:
This is a well-formatted table for the Google Play Data Safety https://docs.snowplowanalytics.com/docs/collecting-data/collecting-from-own-applications/mobile-trackers/android-google-play-data-safety/
Please tell us about the platforms for which the SDK exists
[X] Android
[X] iOS

Thanks @chao2zhang - I have added the information in Android report and updated.


minified version doesn't work

Minified version doesn't work, and inserts strange characters instead of quotes. Normal version works fine and I love it.
Using an online minification tool on the normal version also breaks it and makes it insert strange characters. Must be something about minification that breaks the script.

I didn't see this. Is it still a problem? I will look into it if it is

The bug is still there. Tested with Chrome on a Mac. Happens even in the demo. I edited badger.html to use the minified version of the script and this is what I see:

It's not a big deal because unminified script is only 3KB. But if you're able to fix it then that would be great

Definitely need to get that fixed. I'd like to update the handling a bit
and am out of town, but I'll take a look at it this weekend if @callumacrae
doesn't get to it first. Thanks for keeping up with this issue.
On Thu, Oct 15, 2015 at 10:45 AM, jtlocsei<EMAIL_ADDRESS>wrote:

The bug is still there. Tested with Chrome on a Mac. Happens even in the
demo. I edited badger.html to use the minified version of the script and
this is what I see:
[image: image]
https://cloud.githubusercontent.com/assets/6704966/10519072/05c2708e-735c-11e5-95ed-31ebd20d61ed.png
[image: image]
https://cloud.githubusercontent.com/assets/6704966/10519079/140df1cc-735c-11e5-8fa9-df9790431bcb.png
It's not a big deal because unminified script is only 3KB. But if you're
able to fix it then that would be great
—
Reply to this email directly or view it on GitHub
https://github.com/kellym/smartquotesjs/issues/9#issuecomment-148428614.

@jtlocsei from your screenshot, it looks like smartquotes is correctly replacing straight quotes with curly quote characters, but the curly quote characters aren't being displayed correctly. I'd guess it's an encoding issue.
Do you have <meta charset="utf-8"> or <?xml version="1.0" encoding="UTF-8"?> in your HTML?
Is the web server serving the minified version with Content-Type: text/javascript;charset=UTF-8?

@kemitchell you're right, adding to the html file fixes it. So, how come the non-minified version works even without adding  to the html file?

Unfortunately, I'd need to use an inspection tool like Chrome Inspector to look at how the browser is interpreting charset on the page, the script file, etc. to figure it out. I suspect it has to do as much with how the server is providing the content to the browser, hence my comments about Content-Type.
It sounds like this issue is resolved. Would you mind closing?


Link to the online version of Aldo Colombo's Portfolio

https://acolombo1.github.io

[ ] Congratulations @acolombo1 👏
[ ] OPTIONAL
There is an empty "Deployment" section in your ReadMe file, you can update the section by adding the link (https://acolombo1.github.io/) to the online version. 🥇

Done


LFS-995: maxPerSubject, maxAnswers sometimes stored and retrieved as string instead of long

Nothing seems to be broken. Is there anything special that I need to verify?

After using the questionnaire editor, use Composum to check that maxPerSubject and maxAnswers have type Long. Or, in the .deep json, the values for these properties are not in quotes.


Drop JSCS?

ESLint has basically replaced JSCS completelly, almost all rules are supported and missing ones are in process of addition (eslint/eslint#5856). It may need some reviewing the used JSCS rules, but I think Bootstrap can stop using JSCS in v4.
Thoughts?

Once they finish porting the missing rules, SGTM.

I'm in the process of reviewing the build system anyway, so I'll volunteer to review and add the missing rules once upstream merges if that would help.


Issue with Moving the Terraform Resource.

Describe the bug
The new version of the Terraform provider (11.1.0) for Artifactory no longer supports artifactory_access_token as it is deprecated. The customer is attempting to move the resource using the command terraform state mv but is encountering an error.
The error message is:

Cannot move artifactory_access_token.code_dependencies to artifactory_scoped_token.code_dependencies: resource types don't match."

Requirements for and issue
Snippet:
This is the initial resource:
resource "artifactory_access_token" "code_dependencies" {
  username          = artifactory_user.code_dependencies.name
  end_date_relative = "0s"
}

which is changed to:
resource "artifactory_scoped_token" "code_dependencies" {
  username   = artifactory_user.code_dependencies.name
  expires_in = 0
}

Artifactory Version: Saas/ 7.90.2
Expected behavior
The customer should be able to move the resource using the terraform state mv command without errors.
Additional context
Currently, the customer is unable to move the resource using the terraform state mv command.

Hello
We are impacted by this.
Can you tell us how to move the terraform resource without destroying the old one and creating the new one?
Thanks

@AlessioCasco It is not possible as far as I can see.
This is the reason artfactory_access_token resource has been marked as deprecated since May 2022 to give ample time for existing tokens to expire and migrate to the new artifactory_scoped_token resource.


feat(android): aware of version info from tauri config

This PR makes generated Android packages having the same versionName as it's defined in tauri.config.json, and providing 2 ways to define versionCode:

Calculated: version.major * 1000000 + version.minor * 1000 + version.patch
Overridden 1 by bundle > android > versionCode in tauri.config.json

Hello! I have updated & signed the commit.

Seems like you need to run cargo fmt and you're also missing documentation on version_code field and schema is not generated so run cargo -b tauri-config-schema to generate it,

nice one!


Source maps do not have to be on their own line

(NB: This PR builds on https://github.com/rails/propshaft/pull/132. I can't see a way to do a pull request on top of the prior pull request, so the diff on this one will make more sense once https://github.com/rails/propshaft/pull/132 is completed. I had to build on it since the source map removal logic of https://github.com/rails/propshaft/pull/132 is now extended further.)

While some older resources claim that source maps must be on their own line at the end of a file and while Propshaft's Regexp for this asserts such, this is not the case. Consider:
sass ./app/assets/stylesheets/application.scss ./app/assets/builds/application.css --no-source-map --style compressed --load-path=node_modules

...in package.json. This results in application.css including a source map comment in /* ... */ form at the end of the last line of minified CSS:
<very-long-line>...vertical-align:middle}/*# sourceMappingURL=application.css.map */

...noting that a terminating line feed is also present afterwards. Since this is a CSS comment appearing at the end of a line it is syntactically valid and browsers such as Chrome do read the source map. Under e.g. Propshaft 0.7.0, CSS source maps promptly break because it doesn't consider the not-on-own-line map comment to be valid.

It seems that so long as the comment is the last thing in the file, whether on its own line or not, then it is processed
Source map comments in the middle of the file are, as before, not processed
The regexp is therefore updated to check for end-of-stream (\Z) rather than start-of-line (^)
This means it might optionally capture a closing */ in comments of that form, so the internal private methods now need to be given both an opening and closing string for the comment captures
Test coverage for JS with //# and CSS with /* ... */ style comments included

Bump on this.

Do you need to make any changes to this now that #132 is merged?

@brenogazzola Thanks for the reminder - updated to resolve conflicts after merge of #132 and now ready for review.

@pond I apologize for not merging this PR for so long. I was going to merge it now, but it seems there are conflicts again. Could you fix them, and I'll immediately merge this?

@brenogazzola I too have been extraordinarily busy and apologies in turn for taking so long to fix the conflicts - they were a little fiddly. It's done now and CI is green. Hopefully a merge can happen before conflicts re-emerge! :-D

@brenogazzola (bump on this, thanks...)

@pond Thanks!

Ah! Great. Legend. Thanks :-)


WIP [IT-1234] Setup AWS TGW and VPN

Setup the AWS Transit Gateway service
Setup the AWS VPN service.

Both services are setup with org-formation to allow us to
easily scale out the services to more AWS accounts and VPCs.
depends on https://github.com/Sage-Bionetworks-IT/organizations-infra/pull/376

@brucehoff sorry if it wasn't clear but this is still work in progress (WIP).  I usually put WIP in the PR title to indicate it's not yet ready for review.


fatal error: checkptr: pointer arithmetic result points to invalid allocation

Describe the bug
I’m getting a really annoying issue with using protoactor-go. Running go test -race fails for:
var system = actor.NewActorSystem()

with the error:
fatal error: checkptr: pointer arithmetic result points to invalid allocation

This is due to a known issue in the murmur3 package: https://github.com/spaolacci/murmur3/issues/34.
The line in protoactor-go which is using it is: https://github.com/asynkron/protoactor-go/blob/dev/actor/process_registry.go#L35.
Some other repos have worked around this issue by using murmur3.Sum64 instead of murmur3.Sum32 e.g. https://github.com/rudderlabs/rudder-server/pull/2645. Would that be an acceptable workaround?
It would be a good opportunity to add a proper go compatible tag, e.g. v0.3.0.
To Reproduce

Create a test file, e.g. tmp/tmp_test.go:

package tmp_test

import (
        "testing"

        "github.com/asynkron/protoactor-go/actor"
)

func TestNewActorSystem(t *testing.T) {
        _ = actor.NewActorSystem()
}

Then run that test with the race flag: go test -race ./tmp
Result:

fatal error: checkptr: pointer arithmetic result points to invalid allocation

goroutine 6 [running]:
runtime.throw({0x10063d750?, 0x100155aa0?})
	/opt/homebrew/Cellar/go/1.19.2/libexec/src/runtime/panic.go:1047 +0x40 fp=0xc000062a80 sp=0xc000062a50 pc=0x10016b230
runtime.checkptrArithmetic(0x100b4b080?, {0x0, 0x0, 0x10013e404?})
	/opt/homebrew/Cellar/go/1.19.2/libexec/src/runtime/checkptr.go:69 +0xac fp=0xc000062ab0 sp=0xc000062a80 pc=0x10013879c
github.com/spaolacci/murmur3.Sum32WithSeed({0xc000062b68, 0xa, 0x20}, 0x0)
	/Users/mec07/pkg/mod/github.com/spaolacci/murmur3@v1.1.0/murmur32.go:129 +0x7c fp=0xc000062b20 sp=0xc000062ab0 pc=0x1006048cc
github.com/spaolacci/murmur3.Sum32(...)
	/Users/mec07/pkg/mod/github.com/spaolacci/murmur3@v1.1.0/murmur32.go:111
github.com/asynkron/protoactor-go/actor.(*SliceMap).GetBucket(0xc00000eeb8, {0x10062677c, 0xa})
	/Users/mec07/pkg/mod/github.com/asynkron/protoactor-go@v0.0.0-20221002142108-880b460fcd1f/actor/process_registry.go:35 +0x44 fp=0xc000062ba0 sp=0xc000062b20 pc=0x10061aa14
github.com/asynkron/protoactor-go/actor.(*ProcessRegistryValue).Add(0xc0001ac080, {0x1007fdc18?, 0xc0001a0018}, {0x10062677c, 0xa})
	/Users/mec07/pkg/mod/github.com/asynkron/protoactor-go@v0.0.0-20221002142108-880b460fcd1f/actor/process_registry.go:89 +0x60 fp=0xc000062c30 sp=0xc000062ba0 pc=0x10061adb0
github.com/asynkron/protoactor-go/actor.NewDeadLetter(0xc000118140)
	/Users/mec07/pkg/mod/github.com/asynkron/protoactor-go@v0.0.0-20221002142108-880b460fcd1f/actor/deadletter.go:28 +0x104 fp=0xc000062cc0 sp=0xc000062c30 pc=0x1006139b4
github.com/asynkron/protoactor-go/actor.NewActorSystemWithConfig(0xc000110300)
	/Users/mec07/pkg/mod/github.com/asynkron/protoactor-go@v0.0.0-20221002142108-880b460fcd1f/actor/actor_system.go:66 +0x660 fp=0xc000062e30 sp=0xc000062cc0 pc=0x100612e40
github.com/asynkron/protoactor-go/actor.NewActorSystem({0x0, 0x0, 0x0})
	/Users/mec07/pkg/mod/github.com/asynkron/protoactor-go@v0.0.0-20221002142108-880b460fcd1f/actor/actor_system.go:55 +0x40 fp=0xc000062e60 sp=0xc000062e30 pc=0x1006127a0
github.com/godragons/draughthublink/tmp_test.TestNewActorSystem(0x0?)
	/Users/mec07/src/github.com/GoDragons/draughthublink/tmp/temp_test.go:10 +0x30 fp=0xc000062e90 sp=0xc000062e60 pc=0x100622880
testing.tRunner(0xc000003ba0, 0x1007f7fc0)
	/opt/homebrew/Cellar/go/1.19.2/libexec/src/testing/testing.go:1446 +0x18c fp=0xc000062fa0 sp=0xc000062e90 pc=0x10027b6ac
testing.(*T).Run.func1()
	/opt/homebrew/Cellar/go/1.19.2/libexec/src/testing/testing.go:1493 +0x44 fp=0xc000062fd0 sp=0xc000062fa0 pc=0x10027c814
runtime.goexit()
	/opt/homebrew/Cellar/go/1.19.2/libexec/src/runtime/asm_arm64.s:1172 +0x4 fp=0xc000062fd0 sp=0xc000062fd0 pc=0x1001a0b44
created by testing.(*T).Run
	/opt/homebrew/Cellar/go/1.19.2/libexec/src/testing/testing.go:1493 +0x560

Expected behavior
This should not trigger an error!

There is a temporary workaround that you can do, until this issue is fixed. You need to make your go.mod file replace the package github.com/spaolacci/murmur3 with github.com/twmb/murmur3. You can either use the go mod edit tool like this:
go mod edit -replace<EMAIL_ADDRESS>go mod tidy -compat=1.17

or you can just edit the go.mod file yourself by adding this line at the end of the file:
replace github.com/spaolacci/murmur3 => github.com/twmb/murmur3 v1.1.0

and then run:
go mod tidy -compat=1.17


Create a hello contract and go through the deploy and run workflow

Follow this guide: https://remix-ide.readthedocs.io/en/latest/create_deploy.html
More references:

https://remix-ide.readthedocs.io/en/latest/run.html
https://remix-ide.readthedocs.io/en/latest/udapp.html

Also follow this style guide when creating the contract: https://docs.soliditylang.org/en/latest/style-guide.html

The hello version of PiggyBank contract has been created, compiled, deployed to Remix VM (Shanghai), run, and finally committed. The whole workflow worked smoothly in Remix IDE.
Note that a public property will have its getter generated automatically which will cost no gas when called by external just like a view function.


[TC-495] Queue Updates for all children of a mid cache group

Traffic Ops lets me queue updates in the following ways:
1) For an individual cache
2) For all caches in a given cache group
3) For all caches in a CDN
I would also like to be able to queue updates for all children of a given mid cache group. When operating on mid's, today one must discover all children cache groups of the mid being worked on and individually queue updates for each of those edge CGs. This is prone to error and can be repetitive if there are many children groups
Author: Eric Friedrich
JIRA Link: https://issues.apache.org/jira/browse/TC-495

any reason why you'd want to "queue updates for all children of a given mid cache group" @limited ?


Only check end-entity certificate revocation status on Android

Description
This branch proposes an alternative to https://github.com/rustls/rustls-platform-verifier/pull/34, addressing https://github.com/rustls/rustls-platform-verifier/issues/13 based on discussion with @complexspaces and others.
In summary, given the constraints[^1] imposed by the Android platform we feel that checking revocation information for only the end-entity certificate of a given validated certificate chain is the least-worst option. This is a closer match to how Conscrypt handles revocation checking (with the caveat that they also prevent fallback to CRLs while we, at least for now, allow this). In general this approach is easier to understand, and easier to align with other platform verifiers.
This branch updates the Android CertificateVerifier.kt platform specific verifier logic used by the Rust code to configure revocation checking such that we:

Only check revocation status for the end entity certificate
Prefer OCSP, if stapled or otherwise
Allow fallback to CRLs
Allow soft failure for network issues

As a result of these changes the logic to determine if a trust anchor was one installed in the system trust store is no longer required, so it falls away along with its dedicated unit test. A new real world verification test case is added for a Let's Encrypt certificate chain that previously failed due to the R3 intermediate in use not providing an AIA OCSP URI. To make keeping the shorted lived EE certificate up-to-date the bash script for fetching valid example certs is generalized to include this test case as well. In the future (https://github.com/rustls/rustls-platform-verifier/issues/39) it might be nice to rewrite this in Rust.
[^1]: We can't control revocation checking preferences per-certificate, it must be configured for the whole chain. If we check revocation status for the whole chain preferring OCSP, and a certificate is missing AIA OCSP URI information, it is hard failure. We can't easily check ahead of time whether a given certificate has an AIA OCSP URI. Stapled responses are only available for EE certs. Network access to fetch revocation information can't be controlled (e.g. to only use cached/local information).

@complexspaces Thanks for the review! I understand this is a tricky set of compromises to navigate and taking time to consider carefully them is very reasonable.

In hindsight we should have merged this two weeks ago and followed up with documentation later 😅

Is there any way I can help with this as follow-up? If you have super rough bullet-points about what you'd like covered I could take a crack at drafting some text if it would be helpful. LMK.


Bug: abnormal output of .bed result from "macs2 callpeak" function

Describe the bug
I use macs2 callpeak to do peak finding for Chip-Seq data. I notice there are something wrong happen when *.bed results were output.
To Reproduce

I use code as following:

ws=/home/huangwb8/Test/test_chip_3
cd $ws/output/align
ls *merge.rmdup.bam | grep -v Control | while read id
do (nohup macs2 callpeak --tempdir /data/ \
-c Control*bam -t $id -f BAM -B -g mm \
-n $ws/output/peaks/$(basename $id ".bam") > \
$ws/log/peaks/$(basename $id ".bam").log 2>&1 &)
done

Here is a peak record for example. They are produced by the same code

*.narrowPeak
chr1	4481756	4481888	/home/huangwb8/Test/test_chip_3/output/peaks/H2Aub1.ChIPSeq-GSM850471.merge.rmdup_peak_1	47	.      4.83060	9.25272	4.70255	96

*.xls
chr1    4481757 4481888<PHONE_NUMBER> 18.32   9.25272 4.83060 4.70255 /home/huangwb8/Test/test_chip_3/output/peaks/H2Aub1.ChIPSeq-GSM850471.merge.rmdup_peak_1

*.bed
chr1    4481852 4481853 /home/huangwb8/Test/test_chip_3/output/peaks/H2Aub1.ChIPSeq-GSM850471.merge.rmdup_peak_1        4.70255

Thus, I found the gene fragment is from 4481852 to 4481853, which means that the lenght of the peak is 1! However, from *.narrowPeak or *.xls, the gene fragment of the peak should be from 4481756/7 to 4481888.

System (please complete the following information):

the environment of my softwares

conda 4.7.12; envs=chip-seq
Ubuntu 18.04.3
Python 3.7.3; path=/usr/bin/python3
Python 2.7.15; path=/home/huangwb8/Downloads/conda/location/envs/chip-seq/bin/python2
macs2 <IP_ADDRESS>; path=/home/huangwb8/Downloads/conda/location/envs/chip-seq/bin/macs2

here is one of the log of macs2 callpeak. Hope it helps!

INFO  @ Wed, 09 Oct 2019 21:46:40:
# Command line: callpeak --tempdir /data/ -c Control.MockIP-GSM850473.merge.rmdup.bam -t H2Aub1.ChIPSeq-GSM850471.merge.rmdup.bam -f BAM -B -g mm -n /home/huangwb8/Test/test_chip_3/output/peaks/H2Aub1.ChIPSeq-GSM850471.merge.rmdup
# ARGUMENTS LIST:
# name = /home/huangwb8/Test/test_chip_3/output/peaks/H2Aub1.ChIPSeq-GSM850471.merge.rmdup
# format = BAM
# ChIP-seq file = ['H2Aub1.ChIPSeq-GSM850471.merge.rmdup.bam']
# control file = ['Control.MockIP-GSM850473.merge.rmdup.bam']
# effective genome size = 1.87e+09
# band width = 300
# model fold = [5, 50]
# qvalue cutoff = 5.00e-02
# The maximum gap between significant sites is assigned as the read length/tag size.
# The minimum length of peaks is assigned as the predicted fragment length "d".
# Larger dataset will be scaled towards smaller dataset.
# Range for calculating regional lambda is: 1000 bps and 10000 bps
# Broad region calling is off
# Paired-End mode is off

INFO  @ Wed, 09 Oct 2019 21:46:40: #1 read tag files...
INFO  @ Wed, 09 Oct 2019 21:46:40: #1 read treatment tags...
INFO  @ Wed, 09 Oct 2019 21:46:49:  1000000
INFO  @ Wed, 09 Oct 2019 21:46:57:  2000000
INFO  @ Wed, 09 Oct 2019 21:47:06:  3000000
INFO  @ Wed, 09 Oct 2019 21:47:14:  4000000
INFO  @ Wed, 09 Oct 2019 21:47:24:  5000000
INFO  @ Wed, 09 Oct 2019 21:47:33:  6000000
INFO  @ Wed, 09 Oct 2019 21:47:41:  7000000
INFO  @ Wed, 09 Oct 2019 21:47:49:  8000000
INFO  @ Wed, 09 Oct 2019 21:47:56:  9000000
INFO  @ Wed, 09 Oct 2019 21:48:02:  10000000
INFO  @ Wed, 09 Oct 2019 21:48:09:  11000000
INFO  @ Wed, 09 Oct 2019 21:48:16:  12000000
INFO  @ Wed, 09 Oct 2019 21:48:21:  13000000
INFO  @ Wed, 09 Oct 2019 21:48:26:  14000000
INFO  @ Wed, 09 Oct 2019 21:48:26: #1.2 read input tags...
INFO  @ Wed, 09 Oct 2019 21:48:30:  1000000
INFO  @ Wed, 09 Oct 2019 21:48:34:  2000000
INFO  @ Wed, 09 Oct 2019 21:48:37:  3000000
INFO  @ Wed, 09 Oct 2019 21:48:41:  4000000
INFO  @ Wed, 09 Oct 2019 21:48:45:  5000000
INFO  @ Wed, 09 Oct 2019 21:48:49:  6000000
INFO  @ Wed, 09 Oct 2019 21:48:53:  7000000
INFO  @ Wed, 09 Oct 2019 21:48:57:  8000000
INFO  @ Wed, 09 Oct 2019 21:49:01:  9000000
INFO  @ Wed, 09 Oct 2019 21:49:04: #1 tag size is determined as 48 bps
INFO  @ Wed, 09 Oct 2019 21:49:04: #1 tag size = 48.0
INFO  @ Wed, 09 Oct 2019 21:49:04: #1  total tags in treatment: 14005406
INFO  @ Wed, 09 Oct 2019 21:49:04: #1 user defined the maximum tags...
INFO  @ Wed, 09 Oct 2019 21:49:04: #1 filter out redundant tags at the same location and the same strand by allowing at most 1 tag(s)
INFO  @ Wed, 09 Oct 2019 21:49:04: #1  tags after filtering in treatment: 14005404
INFO  @ Wed, 09 Oct 2019 21:49:04: #1  Redundant rate of treatment: 0.00
INFO  @ Wed, 09 Oct 2019 21:49:04: #1  total tags in control: 9869716
INFO  @ Wed, 09 Oct 2019 21:49:04: #1 user defined the maximum tags...
INFO  @ Wed, 09 Oct 2019 21:49:04: #1 filter out redundant tags at the same location and the same strand by allowing at most 1 tag(s)
INFO  @ Wed, 09 Oct 2019 21:49:04: #1  tags after filtering in control: 9869713
INFO  @ Wed, 09 Oct 2019 21:49:04: #1  Redundant rate of control: 0.00
INFO  @ Wed, 09 Oct 2019 21:49:04: #1 finished!
INFO  @ Wed, 09 Oct 2019 21:49:04: #2 Build Peak Model...
INFO  @ Wed, 09 Oct 2019 21:49:04: #2 looking for paired plus/minus strand peaks...
INFO  @ Wed, 09 Oct 2019 21:49:06: #2 number of paired peaks: 5543
INFO  @ Wed, 09 Oct 2019 21:49:06: start model_add_line...
INFO  @ Wed, 09 Oct 2019 21:49:06: start X-correlation...
INFO  @ Wed, 09 Oct 2019 21:49:06: end of X-cor
INFO  @ Wed, 09 Oct 2019 21:49:06: #2 finished!
INFO  @ Wed, 09 Oct 2019 21:49:06: #2 predicted fragment length is 125 bps
INFO  @ Wed, 09 Oct 2019 21:49:06: #2 alternative fragment length(s) may be 125 bps
INFO  @ Wed, 09 Oct 2019 21:49:06: #2.2 Generate R script for model : /home/huangwb8/Test/test_chip_3/output/peaks/H2Aub1.ChIPSeq-GSM850471.merge.rmdup_model.r
INFO  @ Wed, 09 Oct 2019 21:49:06: #3 Call peaks...
INFO  @ Wed, 09 Oct 2019 21:49:06: #3 Pre-compute pvalue-qvalue table...
INFO  @ Wed, 09 Oct 2019 21:49:57: #3 In the peak calling step, the following will be performed simultaneously:
INFO  @ Wed, 09 Oct 2019 21:49:57: #3   Write bedGraph files for treatment pileup (after scaling if necessary)... /home/huangwb8/Test/test_chip_3/output/peaks/H2Aub1.ChIPSeq-GSM850471.merge.rmdup_treat_pileup.bdg
INFO  @ Wed, 09 Oct 2019 21:49:57: #3   Write bedGraph files for control lambda (after scaling if necessary)... /home/huangwb8/Test/test_chip_3/output/peaks/H2Aub1.ChIPSeq-GSM850471.merge.rmdup_control_lambda.bdg
INFO  @ Wed, 09 Oct 2019 21:49:57: #3   Pileup will be based on sequencing depth in control.
INFO  @ Wed, 09 Oct 2019 21:49:57: #3 Call peaks for each chromosome...
INFO  @ Wed, 09 Oct 2019 21:52:00: #4 Write output xls file... /home/huangwb8/Test/test_chip_3/output/peaks/H2Aub1.ChIPSeq-GSM850471.merge.rmdup_peaks.xls
INFO  @ Wed, 09 Oct 2019 21:52:00: #4 Write peak in narrowPeak format file... /home/huangwb8/Test/test_chip_3/output/peaks/H2Aub1.ChIPSeq-GSM850471.merge.rmdup_peaks.narrowPeak
INFO  @ Wed, 09 Oct 2019 21:52:00: #4 Write summits bed file... /home/huangwb8/Test/test_chip_3/output/peaks/H2Aub1.ChIPSeq-GSM850471.merge.rmdup_summits.bed
INFO  @ Wed, 09 Oct 2019 21:52:00: Done!

Hi @huangwb8, first, please do not use -n, the name of the run, to specify output directories. Instead, use --outdir.  Do this:
macs2 callpeak --tempdir /data/ \
-c Control*bam -t $id -f BAM -B -g mm \
-n $(basename $id ".bam") \
--outdir $ws/output/peaks/

Regarding your question, please check the README to understand the output files from MACS2. The ".bed" file output is for peak "summits" which is the highest 1bp within a peak. The purpose of this file has been indicated in the filename "xxx_summits.bed".

OK, I got it. Thanks a lot!

@taoliu Hi, I'm currently doing an analysis in MACS2 with m6A-seq data and i had the same doubt, but if it is normal that the lenght of the peak summit is of 1, why would you recommend it to search motifs at binding sites. For example, I want to use meme to search motifs from the summits.bed results, previously extracting the sequences from the locations indicated in that file using bedtools bedintersect. But like i mentioned before is just 1 of lenght, so my question here is What would you recommend me to do? or do i take the locations indicated in the .narrowPeak file or .xls file (outputs of MACS2).

@Esteban-Escobar To use MEME to search for motif at peak summit, which is assumed to be the binding site, we usually search for an x00bps (e.g. 200bps) window around the summit.
awk -v OFS="\t" '{print $1,$2-100,$2+100,$4,$5}' xxx_summits.bed > xxx_200bp_around_summits.bed


Feature request: Scope to folder

There few requests already both were closed without any notes about "why":

https://github.com/Microsoft/vscode/issues/31368
https://github.com/Microsoft/vscode/issues/17696

This is a really useful feature, especially after adding workspaces.
For example: I want to concentrate on one particular "Project" inside "workspace".
It's not a deal to open just this folder because there a lot of settings were made for workspace, not for the specific project.

@eiva Not sure if you still care or not, but I believe that this was closed as a dupe of https://github.com/Microsoft/vscode/issues/41860

@zumpiez Thanks for the information.


rollback #842

If you guys prefer this over #851, this should also fix #845.

It looks like this rolls things back to Artem's last change to this file: https://github.com/thrust/thrust/blob/33a4e1fae8b8bb380cd8fb0f94fe271d61c236cf/thrust/detail/config/compiler.h#L73
Looks OK to me, we can merge if @egaburov agrees.

LGTM


Theme logos Usermin only

Under 'Theme Logos' i have images set for authenticated and unauthenticated users. These appear during a Wemin login for an unauthenticated user and for an authenticated user after logging in.
However, this doesn't occur with Usermin (as it used to).
Usermin version | 1.751
Authentic theme version | 19.22-beta3
Webmin version | 1.900
Operating system | Debian Linux 9

root@host:~# ls -lsa /etc |grep usermin
 4 drwxr-xr-x  36 root     bin       4096 Dec  7 14:19 usermin

It's odd. It should be working.
Did you try to force reload the theme and Webmin as well, and afterwards adding logos again?
Are there any errors in browser's console or logged at /var/webmin?

Also which browser do you use and on which OS?

Did you try to force reload the theme and Webmin as well, and afterwards adding logos again?
Yes, that worked

Are there any errors in browser's console or logged at /var/webmin?
No

Also which browser do you use and on which OS?
Google Chrome with Gnome on Archlinux

Thank you :)

Okay, I'm glad the issue was resolved for you. 🙂


[squid:S1118] Utility classes should not have public constructors

This pull request is focused on resolving occurrences of Sonar rule
squid:S1118 - “Utility classes should not have public constructors ”.
You can find more information about the issue here:
https://dev.eclipse.org/sonar/rules/show/squid:S1118
Please let me know if you have any questions.
Ayman Abdelghany.

Coverage decreased (-0.02%) to 41.221% when pulling ddcc9890274b27533cd8012d9acb49a37299046c on DevFactory:release/adding-private-constructor-fix-1 into 0e96cfed7b3e4254cbed82b0e4a6adc33f99433a on ViDA-NYU:master.


Remove all HTML from messages

Currently messages are being sanitised, but leave img tags which can compromise security. Remove all HTML tags from messages.

Fixed by not allowing HTML in messages #1039


fix(completion): wrong select after leader change

compl_shown_match update not correct afte refacot
this will make select wrong item after leader change we can generate compl_match_arraysie within before update compl_shown_match range, split generate compl_match_array into range match_head
Fix https://github.com/vim/vim/issues/16128

ah I see, thanks


HTML Link Broken

HTML link to Project type is broken in:
https://github.com/sbt/website/blob/master/src/reference/00-Getting-Started/05-Basic-Def.md

It's a relative link.  When the page is rendered with pamflet it produces a link to the apidocs for Project that works for me.
http://www.scala-sbt.org/0.13/docs/Basic-Def.html
Was that the issue?

@ashawley is correct, the intent is for the link to work when rendered in scala-sbt.org.
We don't cater for the documentation being read via GitHub.


Missing link to roadmap in README

https://github.com/a-b-street/abstreet/blob/324ef84b3cf6640e77b086853971fb1c56c39283/README.md?plain=1#L46

The refered link https://a-b-street.github.io/docs/project/roadmap.html is nonexistent.

Good catch, thanks! The github homepage is in dire need of an overhaul, but at least this link is fixed.


Return all qualified beans from BeanScope map method

Before the map didn't actually contain all the qualified beans. (say you had an interface and wanted to get all the implementations annotated with a @Qualifier annotation, it wouldn't work)
Fixes #289 (because you can get the list of qualified beans from a qualified map)

it wouldn't work

I what way would it not work? The combination of Qualifier and Type should be unique apart from the issue of priority - @Primary, @Secondary ... but we wire unique instances by  Qualifier + Type.
So Map<String, Type> should be correct as I see it ... and I don't think we should expect multiple instances per Qualifier and hence not expect any use cases that expect or need multiple instances per qualifier?

this doesn't actually fulfill @Tim203's request to get objects of disparate types


[BUG] -UseWebLogin needs a way to ignore existing credentials or "work/school" account you are signed into Windows

Pull forward of https://github.com/pnp/PnP-PowerShell/issues/1656 which is still an issue
-ForceAuthentication or -ClearTokenCache or something like that would be ideal for the parameter name.

Doesn't -Interactive instead of -UseWebLogin work better for you?

Doesn't -Interactive instead of -UseWebLogin work better for you?

@jansenbe as of 1.2.0, -Interactive isn't an available switch, unless I'm missing something.
ModuleType Version    PreRelease Name                                ExportedCommands
---------- -------    ---------- ----                                ----------------
Manifest   1.2.0                 PnP.Powershell                      {Add-PnPAlert, Add-PnPApp, Add-PnPApplicationCustomizer, Add-PnPContentType…}

    Connect-PnPOnline -AADDomain <String> -ClientId <String> -ClientSecret <String> [-CreateDrive] [-DriveName <String>] [-Realm <String>] [-ReturnConnection]
    [<CommonParameters>]

    Connect-PnPOnline -AADDomain <String> [<CommonParameters>]

    Connect-PnPOnline [-Url] <String> [-AzureEnvironment {Production | PPE | China | Germany | USGovernment}] -ClientSecret <String> [-CreateDrive] [-DriveName
    <String>] [-Realm <String>] [-ReturnConnection] [-TenantAdminUrl <String>] [<CommonParameters>]

    Connect-PnPOnline [-Url] <String> [-AzureEnvironment {Production | PPE | China | Germany | USGovernment}] -ClientId <String> -ClientSecret <String> [-CreateDrive]
    [-DriveName <String>] [-Realm <String>] [-ReturnConnection] [-TenantAdminUrl <String>] [<CommonParameters>]

    Connect-PnPOnline [-Url] <String> [-AzureEnvironment {Production | PPE | China | Germany | USGovernment}] -ClientId <String> [-CreateDrive] [-DriveName <String>]
    -RedirectUri <String> [-ReturnConnection] [-TenantAdminUrl <String>] [<CommonParameters>]

    Connect-PnPOnline [-Url] <String> [-AzureEnvironment {Production | PPE | China | Germany | USGovernment}] [-CertificatePassword <SecureString>] [-CertificatePath
    <String>] -ClientId <String> [-CreateDrive] [-DriveName <String>] [-ReturnConnection] -Tenant <String> [-TenantAdminUrl <String>] [<CommonParameters>]

    Connect-PnPOnline [-Url] <String> [-AzureEnvironment {Production | PPE | China | Germany | USGovernment}] [-CertificatePassword <SecureString>] -ClientId <String>
    [-CreateDrive] [-DriveName <String>] [-ReturnConnection] -Tenant <String> [-TenantAdminUrl <String>] [<CommonParameters>]

    Connect-PnPOnline [-Url] <String> [-AzureEnvironment {Production | PPE | China | Germany | USGovernment}] -ClientId <String> [-CreateDrive] [-DriveName <String>]
    [-ReturnConnection] -Tenant <String> [-TenantAdminUrl <String>] -Thumbprint <String> [<CommonParameters>]

    Connect-PnPOnline [-Url] <String> [-AzureEnvironment {Production | PPE | China | Germany | USGovernment}] -ClientId <String> [-CreateDrive] [-DriveName <String>]
    [-ReturnConnection] -Tenant <String> [-TenantAdminUrl <String>] [<CommonParameters>]

    Connect-PnPOnline [-Url] <String> [-AzureEnvironment {Production | PPE | China | Germany | USGovernment}] [-LaunchBrowser] -PnPManagementShell [-ReturnConnection]
    [<CommonParameters>]

    Connect-PnPOnline [-AzureEnvironment {Production | PPE | China | Germany | USGovernment}] [-Credentials <CredentialPipeBind>] [<CommonParameters>]

    Connect-PnPOnline [-AzureEnvironment {Production | PPE | China | Germany | USGovernment}] [-LaunchBrowser] [<CommonParameters>]

    Connect-PnPOnline [-Url] <String> [-CreateDrive] [-Credentials <CredentialPipeBind>] [-DriveName <String>] [-ReturnConnection] [-TenantAdminUrl <String>]
    [-TransformationOnPrem] [<CommonParameters>]

    Connect-PnPOnline [-Url] <String> [-CreateDrive] [-DriveName <String>] [-ReturnConnection] [-TenantAdminUrl <String>] -UseWebLogin [-ForceAuthentication]
    [<CommonParameters>]

    Connect-PnPOnline [-Url] <String> [-CreateDrive] [-DriveName <String>] [-ReturnConnection] [-TenantAdminUrl <String>] [<CommonParameters>]

    Connect-PnPOnline [-Url] <String> [-CreateDrive] [-Credentials <CredentialPipeBind>] [-DriveName <String>] [-ReturnConnection] [-TenantAdminUrl <String>]
    [<CommonParameters>]

    Connect-PnPOnline [-Url] <String> [-CreateDrive] [-DriveName <String>] [-ReturnConnection] [-TenantAdminUrl <String>] [<CommonParameters>]

    Connect-PnPOnline [[-Url] <String>] [-CreateDrive] [-DriveName <String>] [-ReturnConnection] [<CommonParameters>]

@jansenbe as of 1.2.0, -Interactive isn't an available switch, unless I'm missing something.
ModuleType Version    PreRelease Name                                ExportedCommands
---------- -------    ---------- ----                                ----------------
Manifest   1.2.0                 PnP.Powershell                      {Add-PnPAlert, Add-PnPApp, Add-PnPApplicationCustomizer, Add-PnPContentType…}

    Connect-PnPOnline -AADDomain <String> -ClientId <String> -ClientSecret <String> [-CreateDrive] [-DriveName <String>] [-Realm <String>] [-ReturnConnection]
    [<CommonParameters>]

    Connect-PnPOnline -AADDomain <String> [<CommonParameters>]

    Connect-PnPOnline [-Url] <String> [-AzureEnvironment {Production | PPE | China | Germany | USGovernment}] -ClientSecret <String> [-CreateDrive] [-DriveName
    <String>] [-Realm <String>] [-ReturnConnection] [-TenantAdminUrl <String>] [<CommonParameters>]

    Connect-PnPOnline [-Url] <String> [-AzureEnvironment {Production | PPE | China | Germany | USGovernment}] -ClientId <String> -ClientSecret <String> [-CreateDrive]
    [-DriveName <String>] [-Realm <String>] [-ReturnConnection] [-TenantAdminUrl <String>] [<CommonParameters>]

    Connect-PnPOnline [-Url] <String> [-AzureEnvironment {Production | PPE | China | Germany | USGovernment}] -ClientId <String> [-CreateDrive] [-DriveName <String>]
    -RedirectUri <String> [-ReturnConnection] [-TenantAdminUrl <String>] [<CommonParameters>]

    Connect-PnPOnline [-Url] <String> [-AzureEnvironment {Production | PPE | China | Germany | USGovernment}] [-CertificatePassword <SecureString>] [-CertificatePath
    <String>] -ClientId <String> [-CreateDrive] [-DriveName <String>] [-ReturnConnection] -Tenant <String> [-TenantAdminUrl <String>] [<CommonParameters>]

    Connect-PnPOnline [-Url] <String> [-AzureEnvironment {Production | PPE | China | Germany | USGovernment}] [-CertificatePassword <SecureString>] -ClientId <String>
    [-CreateDrive] [-DriveName <String>] [-ReturnConnection] -Tenant <String> [-TenantAdminUrl <String>] [<CommonParameters>]

    Connect-PnPOnline [-Url] <String> [-AzureEnvironment {Production | PPE | China | Germany | USGovernment}] -ClientId <String> [-CreateDrive] [-DriveName <String>]
    [-ReturnConnection] -Tenant <String> [-TenantAdminUrl <String>] -Thumbprint <String> [<CommonParameters>]

    Connect-PnPOnline [-Url] <String> [-AzureEnvironment {Production | PPE | China | Germany | USGovernment}] -ClientId <String> [-CreateDrive] [-DriveName <String>]
    [-ReturnConnection] -Tenant <String> [-TenantAdminUrl <String>] [<CommonParameters>]

    Connect-PnPOnline [-Url] <String> [-AzureEnvironment {Production | PPE | China | Germany | USGovernment}] [-LaunchBrowser] -PnPManagementShell [-ReturnConnection]
    [<CommonParameters>]

    Connect-PnPOnline [-AzureEnvironment {Production | PPE | China | Germany | USGovernment}] [-Credentials <CredentialPipeBind>] [<CommonParameters>]

    Connect-PnPOnline [-AzureEnvironment {Production | PPE | China | Germany | USGovernment}] [-LaunchBrowser] [<CommonParameters>]

    Connect-PnPOnline [-Url] <String> [-CreateDrive] [-Credentials <CredentialPipeBind>] [-DriveName <String>] [-ReturnConnection] [-TenantAdminUrl <String>]
    [-TransformationOnPrem] [<CommonParameters>]

    Connect-PnPOnline [-Url] <String> [-CreateDrive] [-DriveName <String>] [-ReturnConnection] [-TenantAdminUrl <String>] -UseWebLogin [-ForceAuthentication]
    [<CommonParameters>]

    Connect-PnPOnline [-Url] <String> [-CreateDrive] [-DriveName <String>] [-ReturnConnection] [-TenantAdminUrl <String>] [<CommonParameters>]

    Connect-PnPOnline [-Url] <String> [-CreateDrive] [-Credentials <CredentialPipeBind>] [-DriveName <String>] [-ReturnConnection] [-TenantAdminUrl <String>]
    [<CommonParameters>]

    Connect-PnPOnline [-Url] <String> [-CreateDrive] [-DriveName <String>] [-ReturnConnection] [-TenantAdminUrl <String>] [<CommonParameters>]

    Connect-PnPOnline [[-Url] <String>] [-CreateDrive] [-DriveName <String>] [-ReturnConnection] [<CommonParameters>]

It's not yet in an official release but it's available in the latests nightly drops. You can use it like this:
Connect-PnPOnline -Url https://contoso.sharepoint.com/sites/portal -Interactive

It's not yet in an official release but it's available in the latests nightly drops. You can use it like this:
Connect-PnPOnline -Url https://contoso.sharepoint.com/sites/portal -Interactive

@JustinGrote  : -ForceAuthentication is actually available when using -UseWebLogin in 1.2.0. It will clear the cookies set for authentication.

@JustinGrote  : -ForceAuthentication is actually available when using -UseWebLogin in 1.2.0. It will clear the cookies set for authentication.

@erwinvanhunen

@erwinvanhunen

Right. So this is puzzling. When I built the -ForceAuthentication functionality it worked normally for me. There is one difference between then and now: now I'm using a domain connected computer whereas at the time of development I was not connected to an AD. That seems to be the difference. What we do to force the authentication is that we clear the auth cookies before we show the authentication dialog. If those are present in the Windows cookie storage then you will be automatically authenticated. This behavior is different with AD joined machines it seems. Something to look into.
The null reference exception, is that because you are not specifying an URL to connect to? I'll catch that one a bit nicer in the code, but that's probably the reason you see the exception.

Right. So this is puzzling. When I built the -ForceAuthentication functionality it worked normally for me. There is one difference between then and now: now I'm using a domain connected computer whereas at the time of development I was not connected to an AD. That seems to be the difference. What we do to force the authentication is that we clear the auth cookies before we show the authentication dialog. If those are present in the Windows cookie storage then you will be automatically authenticated. This behavior is different with AD joined machines it seems. Something to look into.
The null reference exception, is that because you are not specifying an URL to connect to? I'll catch that one a bit nicer in the code, but that's probably the reason you see the exception.

I do second @jansenbe's remark though: consider using -Interactive when possible (it does require a Azure AD app or a consent for the PnP Management Shell multi-tenant app). The underlying authentication flow is fully supported by MS (we are using MSAL) and you will acquire a token with that can have access rights to the Graph (so for instance the Teams cmdlets, etc. etc. also work). UseWebLogin is a limited way of authentication given that it's fully cookie based and as a result we cannot access any other resources within the M365 ecosystem.

I do second @jansenbe's remark though: consider using -Interactive when possible (it does require a Azure AD app or a consent for the PnP Management Shell multi-tenant app). The underlying authentication flow is fully supported by MS (we are using MSAL) and you will acquire a token with that can have access rights to the Graph (so for instance the Teams cmdlets, etc. etc. also work). UseWebLogin is a limited way of authentication given that it's fully cookie based and as a result we cannot access any other resources within the M365 ecosystem.

It was -Url that was causing the null exception. Consider making it a mandatory parameter in the parameter sets that it exists if that's not a breaking change.
I grabbed the nightly and -Interactive behaves more like I expect MSAL-style as you say. That resolves my issue so I'll flag this as closed with the resolution "fixed in prerelease"

It was -Url that was causing the null exception. Consider making it a mandatory parameter in the parameter sets that it exists if that's not a breaking change.
I grabbed the nightly and -Interactive behaves more like I expect MSAL-style as you say. That resolves my issue so I'll flag this as closed with the resolution "fixed in prerelease"

@erwinvanhunen you may consider adding a -UseStart or -UseBrowser or something to use the existing browser rather than an "embedded" IE window. This is how the Az and Exchange cmdlets do it for a more consistent "feel"

@erwinvanhunen you may consider adding a -UseStart or -UseBrowser or something to use the existing browser rather than an "embedded" IE window. This is how the Az and Exchange cmdlets do it for a more consistent "feel"

@JustinGrote : exactly with the weblogin method it doesn't work to launch an external browser. However, with -Interactive we do support launching an external browser, just specify -LaunchBrowser' Let me explain what's happening behind the scenes with weblogin:

We open the /_layout/settings.aspx page in the site in a popup browser.
We monitor the navigation events and the moment we have a known set of cookies present we take those cookies out of the browser and store them in a new cookiecontainer
We close the popup browser
We create a new clientcontext behind the scenes and override the webexecute request and inject the cookies in every request we make, thus authenticating the request.

For that we need full control over the brower in order to 'catch' the cookies. If we would launch a browser separately we cannot hook into that browser to retrieve the cookies.
This is exactly one of the reasons we don't necessarily like the UseWebLogin method. It's too error-prone.
However, with the -Interactive login things work a bit different:

We launch (either a popup, or an external browser, as you can specify the -LaunchBrowser option with -Interactive) an interactive OAuth flow
Part of the requirement of that flow is that we specify a redirect URL. That redirect url points to localhost:[randomport].
The moment we launch the browser popup or the external one we start to listen on that random port on localhost to incoming requests
The moment you authenticated in the browser window Azure AD will redirect you to the localhost:[port] url, where we receive the request, extract the accesstoken from the address (it's sent to as a query parameter) and we stop listening on that port. From that moment we have a valid accesstoken that is added to the authorization header of every request we make.

This is what the Az and the Exchange cmdlets also use, as it's a supported MSAL authorization flow.
Given the fact that we get a full accesstoken to Azure resources/audiences this auth method is much more functional when compared to the much more limited cookie auth.

@JustinGrote : exactly with the weblogin method it doesn't work to launch an external browser. However, with -Interactive we do support launching an external browser, just specify -LaunchBrowser' Let me explain what's happening behind the scenes with weblogin:

We open the /_layout/settings.aspx page in the site in a popup browser.
We monitor the navigation events and the moment we have a known set of cookies present we take those cookies out of the browser and store them in a new cookiecontainer
We close the popup browser
We create a new clientcontext behind the scenes and override the webexecute request and inject the cookies in every request we make, thus authenticating the request.

For that we need full control over the brower in order to 'catch' the cookies. If we would launch a browser separately we cannot hook into that browser to retrieve the cookies.
This is exactly one of the reasons we don't necessarily like the UseWebLogin method. It's too error-prone.
However, with the -Interactive login things work a bit different:

We launch (either a popup, or an external browser, as you can specify the -LaunchBrowser option with -Interactive) an interactive OAuth flow
Part of the requirement of that flow is that we specify a redirect URL. That redirect url points to localhost:[randomport].
The moment we launch the browser popup or the external one we start to listen on that random port on localhost to incoming requests
The moment you authenticated in the browser window Azure AD will redirect you to the localhost:[port] url, where we receive the request, extract the accesstoken from the address (it's sent to as a query parameter) and we stop listening on that port. From that moment we have a valid accesstoken that is added to the authorization header of every request we make.

This is what the Az and the Exchange cmdlets also use, as it's a supported MSAL authorization flow.
Given the fact that we get a full accesstoken to Azure resources/audiences this auth method is much more functional when compared to the much more limited cookie auth.

@erwinvanhunen I didn't even look to see if there was a -LaunchBrowser parameter, oops. My bad. Glad you've put a lot of thought into it, it is much appreciated for the detailed answer!

@erwinvanhunen I didn't even look to see if there was a -LaunchBrowser parameter, oops. My bad. Glad you've put a lot of thought into it, it is much appreciated for the detailed answer!


Enhance: Change new chat icon

I had to rebase, but change is the same. once the build is green ill merge


make first column static

Is there any method by which the first column stays fixed ?

+1

-- not maintained


Add base HP profile

What does this PR do?
Adds a base HP profile that can be used for all HP devices
Motivation

Additional Notes

Review checklist (to be filled by reviewers)

[ ] Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
[ ] PR title must be written as a CHANGELOG entry (see why)
[ ] Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
[ ] PR must have changelog/ and integration/ labels attached

@florimondmanca what do you think about naming it _hp_compaq_health.yaml, so that it's clear to users that it has an association with HP devices.