Weather app location permissions

For the location information permission of the weather app, you cannot select Always Allow, so you cannot display the current location weather unless the app is open or refreshed. I would like to be able to choose to always allow.

This can be seen when traveling from one city to another, the temperature remains in the previous city.  It is necessary to enter to the configuration and refresh the widget to change to the new city


Delete toolchains/preconfig directory

Preconfigs are currently used from the TensorFlow repo. Remove this directory to avoid confusion.

#36 removed them


Branch Model Testing

Codecov Report

Merging #334 (e16bbac) into master (b73d39b) will increase coverage by 3.73%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##             master     #334      +/-   ##
============================================
+ Coverage     50.40%   54.13%   +3.73%
- Complexity      509      544      +35
============================================
  Files           114      114
  Lines          2236     2237       +1
  Branches        198      198
============================================
+ Hits           1127     1211      +84
+ Misses         1007      917      -90
- Partials        102      109       +7

Impacted Files
Coverage Δ
Complexity Δ

...rc/main/java/seedu/address/model/ModelManager.java
67.44% <0.00%> (+27.72%)
56.00 <2.00> (+27.00)

...tate/expenditureindex/ExpenditureIndexManager.java
66.66% <0.00%> (+19.99%)
9.00% <0.00%> (+2.00%)

src/main/java/seedu/address/model/Nusave.java
80.00% <0.00%> (+20.00%)
29.00% <0.00%> (+4.00%)

.../address/state/budgetindex/BudgetIndexManager.java
73.33% <0.00%> (+20.00%)
10.00% <0.00%> (+2.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b73d39b...e16bbac. Read the comment docs.


Changed the title to something better!

Changed the title, please review and let me know what you think!

Seems nice, please edit a little bit more!


Adding Colorbox to my ReactJS application creates “jQuery is not defined”

I'm trying to add Colorbox library to my project created with create-react-app. I've installed jquery-colorbox package via npm and added imports in one of my *.js files.
The whole problem description is here:
https://stackoverflow.com/questions/44850631/adding-colorbox-to-my-reactjs-application-creates-jquery-is-not-defined

Sorry, I do not know, but this does not seem specific to Colorbox.  I'm going to close this since I expect you could replace Colorbox with any other jQuery plugin and be in the same situation.

All right. Worth trying ;). Thanks for the response.

If anyone would ask, the solution is on the Stackoverflow in here:
https://stackoverflow.com/questions/44850631/adding-colorbox-to-my-reactjs-application-creates-jquery-is-not-defined
:)


Missing inheritance functionality

Bug description
When running prisma db pull (prisma introspection) on a PostgreSQL database that has tables created with the INHERITS keyword the schema is bad and a warning message is printed:

How to reproduce
Steps to reproduce the behavior:

Create a table using INHERITS
Run prisma db pull
See warning

I also created a repo: https://github.com/yardenshoham/prisma-inheritence-issue
Expected behavior
I'd expect prisma to support inheritance in PostgreSQL seeing as the website says it does

Prisma information
SQL script:
-- https://www.postgresql.org/docs/current/tutorial-inheritance.html
CREATE TABLE cities (
  name       text,
  population real,
  elevation  int     -- (in ft)
);

CREATE TABLE capitals (
  state      char(2) UNIQUE NOT NULL
) INHERITS (cities);

The schema that gets generated:
generator client {
  provider = "prisma-client-js"
}

datasource db {
  provider = "postgresql"
  url      = env("DATABASE_URL")
}

model capitals {
  name       String?
  population Float?  @db.Real
  elevation  Int?
  state      String  @unique @db.Char(2)
}

/// The underlying table does not contain a valid unique identifier and can therefore currently not be handled by the Prisma Client.
model cities {
  name       String?
  population Float?  @db.Real
  elevation  Int?

  @@ignore
}

Environment & setup

OS: Ubuntu 20.04 on WSL2
Database: PostgreSQL 13
Node.js version: v12.20.2
Prisma version:

prisma               : 2.21.2
@prisma/client       : Not found
Current platform     : debian-openssl-1.1.x
Query Engine         : query-engine e421996c87d5f3c8f7eeadd502d4ad402c89464d (at<EMAIL_ADDRESS>Migration Engine     : migration-engine-cli e421996c87d5f3c8f7eeadd502d4ad402c89464d (at<EMAIL_ADDRESS>Introspection Engine : introspection-core e421996c87d5f3c8f7eeadd502d4ad402c89464d (at<EMAIL_ADDRESS>Format Binary        : prisma-fmt e421996c87d5f3c8f7eeadd502d4ad402c89464d (at<EMAIL_ADDRESS>Default Engines Hash : e421996c87d5f3c8f7eeadd502d4ad402c89464d
Studio               : 0.371.0

Since this is a documentation issue, let's track progress in https://github.com/prisma/docs/issues/1783


[BUG] NVTabular: Support for GCS paths: read + write (Dataset, Workflow classes)

Describe the bug
Dataset: Only supports reading from GCS, not writing.
Workflow: Does not support GCS paths for reading and writing.
Steps/Code to reproduce bug
follow
https://github.com/jarokaz/merlin-on-vertex/blob/main/01-dataset-preprocessing.ipynb
Details will be added by Vertex team.
Expected behavior
as description
GCP - n1-highmem-32+4xT4 - nvcr.io/nvidia/merlin/merlin-training:21.09
Driver: NVIDIA-SMI 460.73.01 Driver Version: 460.73.01 CUDA Version: 11.2

In the past (Maybe 6 months ago), I have been able to run an NVTabular workflow reading/writing data from/in cloud(gcs and S3) using this script: https://github.com/NVIDIA-Merlin/NVTabular/blob/main/bench/examples/dask-nvtabular-criteo-benchmark.py
I actually got some perf numbers and was working in how to better configure GCP/AWS VMs storage to get better I/O access.
Not sure if this is exactly the same, but just adding the information.

I have been able to run an NVTabular workflow reading/writing data from/in cloud(gcs and S3) using this script: https://github.com/NVIDIA-Merlin/NVTabular/blob/main/bench/examples/dask-nvtabular-criteo-benchmark.py

@albert17 - Are you saying you were able to run your script with --out-path pointing to a location in both s3 and gcs? I have not spent much time trying to write to remote storage, but I do recall having problems writing to gcs. I believe I was able to write directly to s3, but needed to copy (put) local files to get them into gcs.

@rjzamora Yes, I meant that. I added a PR at that time to add the support to the script and to update several components from NVTabular. #540

@mengdong for writing the dataset, are you using the latest code? There was a fix pushed about a week ago that at least fixed this for writing the dataset to S3: https://github.com/NVIDIA-Merlin/NVTabular/issues/1214

I have a fix for saving the workflow object here https://github.com/NVIDIA-Merlin/NVTabular/pull/1232

Thanks guys,

Should this be closed? Is Dataset.to_parquet working with GCS?

@rjzamora I added some code here that uses fsspec to write out datasets https://github.com/NVIDIA-Merlin/NVTabular/issues/1214 and have verified with S3 that this works. I haven't tested with GCS , and we don't have any unittests for GCS (unlike S3).
This should work though, since we're using fsspec . The one caveat I guess is that we're not passing along storage_options in the to_parquet call, meaning that auth will have to be done via global environment variables

The one caveat I guess is that we're not passing along storage_options in the to_parquet call, meaning that auth will have to be done via global environment variables

Ah - I totally missed this! We should probably add a storage_options kwarg to to_parquet in case this limitation is too restrictive for some use cases.

@bschifferer tested this out and it works


Is there a way to define :onhover properties for Griddle rows?

I took a look at the customisation section of the documentation, and found nothing there. Any tips?

Just do a simple CSS !important;

@DClark5218 would be nice if this was supported by the grid. It's currently very customisable in terms of styles, just needs a little bit more. :)

HI there - sorry for an incredibly late response here but we've added more customization options in Griddle 1.0 -- if the built in properties for interacting are not enough, overrides can be provided to just about anything :)
Please see customization options or plugin options for more on this. :+1:


remove unused getAll with arity 2 from RCT_EXPORT_METHOD

Hello. Currently if I try to call CookieManager.getAll() it will throw exception complaining the arity difference between native and js code.
I am not too familiar with object-c and react bridge code but I belive the function I remove from this PR is not needed anymore and it solve the exception when calling getAll.
Please let me know if there is any problem so I can further imrpove it.

I have forked the repo here: https://github.com/safaiyeh/react-native-cookie-store
We can create issues and PRs there to continue the development of the project.


Overriding path item parameters with operation parameters doesn't work

Hello there,
I've recently started experimenting with the openapi-generator seeing if it could help make some things easier at work. The generator seems to work but leads to compilation errors when having overridden variables, Easily modifying the GreetingService example Apple provides can reproduce this problem. Here is a link to a gist containing the modified example and the Types.swift that is outputted. The error itself is on Lines 58/59 on Types.swift in the gist.
Package.resolved revision: c181ed

Hi @mh-dmclean, you're right, great catch!
From the OpenAPI 3.0.3 specification for the Path Item -> parameters ^1:

A list of parameters that are applicable for all the operations described under this path. These parameters can be overridden at the operation level, but cannot be removed there.

But today, we simply concatenate the parameters from the path item level with those at operation level here: https://github.com/apple/swift-openapi-generator/blob/main/Sources/_OpenAPIGeneratorCore/Translator/Operations/OperationDescription.swift#L150
However, we should instead replace any parameters we find at the path item level with one found for the operation, if they have the same location + name.
A contribution with a fix and a unit test for this would be much appreciated 🙂

Hi @czechboy0! 😄 I'm intreseted in contributing to swift-openapi-generator.  I'll happily look at this issue if not picked up yet! 🙂

Great, welcome, @arthurcro! Hopefully my previous comment has enough information to start on, and you might also want to check out https://swiftpackageindex.com/apple/swift-openapi-generator/0.1.7/documentation/swift-openapi-generator/contributing-to-swift-openapi-generator. Let us know if you need any help! 🙏

I believe I found a first decent fix for the issue. However, I'm struggling finding the right place to write a unit test to confirm it propoerly resolves the issue. 😄
I did not find isolated unit tests testing OperationDescription since it's mostly tested through other tests. Could you maybe help me find the right place to add a great unit test? 🙂

However, we should instead replace any parameters we find

Finally, I'm wondering about performance since allParameters is a computed variables, are there any concerns regarding adding logic to replace some parameters that would be run every time this property is accessed? 🤔

Open the PR without the test and we'll discuss there what the best way to test it is.
Performance won't be an issue, today we recalculate a bunch of things repeatedly to avoid having to worry about cache invalidation, so it's fine. Generator complexity and maintainability is more important to us as the moment.

Here is the draft PR https://github.com/apple/swift-openapi-generator/pull/183/!
Please let me know what you think when you get a chance 🙂


Passing no config to Scheduler leads to runtime error.

The default argument for the config in the Scheduler leads to a runtime error. However, the documentation of the Scheduler class says that the config parameter is optional.
It seems to me that an easy fix could be to change the default argument from None to {}

Thanks, that's a good observation. Unfortunately, your proposed solution would bear dangerous side effects because using a dict as the default argument makes it effectively a global variable, see for example:
>>> def routine_with_opt_arg(arg={}):
...     arg['test'] = arg.get('test', 0) + 1
...     print(arg)
...
>>> routine_with_opt_arg()
{'test': 1}
>>> routine_with_opt_arg()
{'test': 2}
>>> routine_with_opt_arg()
{'test': 3}

The correct pattern for this is instead to add a manual check to the constructor:
if config is None:
    config = {}


supported platforms

List of related issues or pull requests
Refs: #193
Describe the changes made in this pull request
Updated README.rst, --help in README.rst , --help in terminal
Instructions to review the pull request

Thanks Faruk


[SMALLFIX]replace anonymous type with lambda in

fix in AlluxioMasterRestServiceHandler

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/19102/
Test PASSed.

Merged build finished. Test PASSed.


Upgrade Google Java Format 1.20.0 -> 1.21.0

This PR contains the following updates:

Package
Type
Update
Change

Google Java Format
compile
minor
1.20.0 -> 1.21.0

Release Notes

google/google-java-format (Google Java Format)
v1.21.0
Compare Source
Formatting changes:

Adjust indentation of text blocks (ce3cb59)

Bug fixes:

Fix a crash with comments inside string templates (e946e82)
Native image report HEAD-SNAPSHOT instead of the correct version (#1068)
Improve compatibility with older glibc versions (#1072)

Full Changelog: https://github.com/google/google-java-format/compare/v1.20.0...v1.21.0

[ ] If you want to rebase/retry this PR, check this box

Suggested commit message:
Upgrade Google Java Format 1.20.0 -> 1.21.0

See:
- https://github.com/google/google-java-format/releases/tag/v1.21.0
- https://github.com/google/google-java-format/compare/v1.20.0...v1.21.0


dropdown-menu-dark inside a navbar in responsive mode has text invisible

https://jsfiddle.net/caub/qd0ent1z/

bootstrap version: 5.0.1
browser: chrome

Does it show up when you remove translate-middle-x and you should see it? Fixes it for me

Right thanks, I'll try to apply this translate effect only on large screens
Thanks!


User is sometimes not set  downloadCallback

I was ovrride the download callback to restrict what users can download the file (and for a few other specific reasons) and some time ago the userId stopped being set. It ended up being because of a change in meteor
https://github.com/meteor/meteor/commit/79ae1849f5846e207ed4dfa49831ba409252fd03#diff-18cd8c5cbe21efdaf022e77bd5c89a40
Where they switched how Meteor.server.sessions was accessed. So I had to add a line of code

const params = this.request.cookies
      const sessionId = String(params.x_mtok);

      this.userId  = (Meteor.server.sessions.get(sessionId) && Meteor.server.sessions.get(sessionId).userId) ? Meteor.server.sessions.get(sessionId).userId : null;

Just thought i would put this here in case anyone else runs into it, not sure if its the right thing to change the package or not.

@ToyboxLabs can you please look at this pull request: #683
It has been merged already and will be part of the next package release.
Would this fix your issue?

Dear @ToyboxLabs ,
This issue should be fixed in v1.11.0, please update to the latest release.
Feel free to close it in case if the issue is solved on your end.

Closed due to silence at issue owner end.
Feel free to reopen it in case if the issue still persists on your end.


Bower no longer recommended

This is the problem:
Bower is no longer recommended (by Bower maintainers)
This is my solution:

remove bower.json
add keywords to package.json
replace bower with yarn in readme

Also, as of NPM v5 the --save flag is no longer necessary as it saves to dependencies by default

👍 thanks


Elliptic Curve Schnorr Signature Identification

Hi,
Are there any plans to implement Elliptic Curve Schnorr Signature Identification in Bouncy Castle Java??

@peterdettman , any updates please??

As much as it's something we would like to have, we already have far too much on our plate to be able to do this in the short term, so I would have to answer that there are no plans.

Ok thanks for replying.
When I Implement it, I will contribute to BC Csharp and hope someone would backport it to java.
Regards.

@Xor-el Hi, did you implement it in BC CSharp? Where can I find it?

@erikzhang , yes I did implement it according to sipa's specifications found here Schnorr Sipa but unfortunately not in CSharp.
Luckily someone did implement it in CSharp, you can find it here

Thank you very much!

Is there any news about Schnorr support?
I heard Bitcoin Verde created a Java implementation and it would be great if it could be integrated in BC.

Is there any news about this in 2022?

Schnorr support 2024? Please :), I will pay 25 USD for it

Is there any news about this in 2022?

Did you ever find an alternative?


Beautify docs site

Inside the docs folder is a NextJS app for Nautilus' main docs site.
This can be so much more than just a plain old docs site. Feel free to go in and spice things up a bit!
Get creative and have fun, and try to make something totally unique for Nautilus' docs, how-to's, and more.

Shuaaaaa


20NG Training Set Reported Results Question

For your 20NG results reported in your original paper (88.5 ± 0.1), was the model trained on the full public 20NG train set, of size 11314, or were the reported results generated using the code currently in this repo, which appears to exclude the validation set from the data used to train the model? (The latter would use a training set of size 10183).
Also, I notice that in Table 4 you reported a different result (87.9 ± 0.2) for the cited Yao GCN paper than they did themselves (0.8634 ± 0.0009). Do you know why that is the case?
Thanks!

hi @jharrang
sorry for a late reply.
hoestly it has been a while that I don't remember the exact details. But I am sure that the code we used in this repo is the code we used to get the reported results. Historically, the data pipeline is taken from this repo (https://github.com/codeKgu/Text-GCN).
and sorry I am not sure why did we get better results for their method ...


feat: use multiple GPUs for Pippenger's partition algorithm (PROOF-831)

Rationale for this change
Support using multiple GPUs to compute multi-exponentiations with Pippenger's partition algorithm.
What changes are included in this PR?
Modified the multi-exponentiation function to split the problem into smaller chunks and use multiple GPUs if available.
Are these changes tested?
Yes, I added tests for the new code paths by artificially using options that split the multi-exponentiation into smaller chunks.

:tada: This PR is included in version 1.51.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Update performance test and add README

The performance test is still working from last change, but this commit
replaces the configmaps created in the namespaces with roles and
rolebindings because they are default to propagate by HNCConfig.
Add README to provide more info of what's tested and how to run it.

/assign @adrianludwin

/lgtm
/approve
/hold
for @adrianludwin

/hold cancel
/lgtm
/approve


[License Issue] Please update your source codes' license

org.apache.seatunnel.connectors.seatunnel.jdbc.internal.split.JdbcNumericBetweenParametersProvider
I noticed this code, it is exactly the same as Flink(org.apache.flink.connector.jdbc.split.JdbcNumericBetweenParametersProvider). I checked that the author is not the same person, but there is no statement. So, you should update the source codes' LICENSE to indicate you have copied it from another project.
I'm not sure if there are other similar codes. I just came across this by accident.

@ic4y  Please have a look.


iOS 10: Background Session won't inform when downloads have failed

Given there are two AlamofireManager available:
    public static func alamofireManager() -> Alamofire.SessionManager {
        if (Api.alamofireManagerInstance == nil) {
            Api.alamofireManagerInstance = Alamofire.SessionManager(configuration: defaultConfiguration())
        }

        return Api.alamofireManagerInstance!
    }

    public static func backgroundDownloadManager() -> Alamofire.SessionManager {
        if (Api.backgroundDownloadManagerInstance == nil) {
            let identifier = Bundle.main.bundleIdentifier!

            let configuration = URLSessionConfiguration.background(withIdentifier: identifier)
            configuration.sessionSendsLaunchEvents = true

            let manager = Alamofire.SessionManager(configuration: configuration)
            manager.startRequestsImmediately = true

            Api.backgroundDownloadManagerInstance = manager
        }

        return Api.backgroundDownloadManagerInstance!
    }

And I call them like this:
Api.backgroundDownloadManager()
                .download(v.downloadURL(), method: .get, to: { (url, response) -> (destinationURL: URL, options: DownloadRequest.DownloadOptions) in
 // construct URL
})
.downloadProgress(closure: { (p) in
 // update spinner etc
})
.response(completionHandler: { (response) in
  if let e = response.error {
    print ("error detected: \(response.error)")
  }
})

Then, once I disconnect my phone from the source (by unplugging the source device from WiFi), only the first foreground session manager will report the below error. The backgroundDownloadManager will NOT report any error (thus causing spinners to never disappear etc).
It can be fixed by switching to the alamofireManager as shown above. Then the error will be reported correctly:
error detected: Optional(Error Domain=NSURLErrorDomain Code=-1005 "The network connection was lost." UserInfo={NSUnderlyingError=0x17644d6e0 {Error Domain=kCFErrorDomainCFNetwork Code=-1005 "(null)" UserInfo={NSErrorPeerAddressKey=<CFData 0x17048b860 [0x1b509dbb8]>{length = 16, capacity = 16, bytes = 0x10020050c0a801fe0000000000000000}}}, NSErrorFailingURLStringKey=http://large.filesource/video.mov, NSErrorFailingURLKey=http://large.filesource/video.mov, NSLocalizedDescription=The network connection was lost.})

This is on iOS 10.2 (14C92), using Alamofire 4.3.0 (Podfile.lock below):
PODS:
  - Alamofire (4.3.0)
  - AlamofireImage (3.2.0):
    - Alamofire (~> 4.1)
  - Crashlytics (3.8.3):
    - Fabric (~> 1.6.3)
  - Fabric (1.6.11)
  - Fuzi (1.0.1)
  - OHHTTPStubs (5.2.3):
    - OHHTTPStubs/Default (= 5.2.3)
  - OHHTTPStubs/Core (5.2.3)
  - OHHTTPStubs/Default (5.2.3):
    - OHHTTPStubs/Core
    - OHHTTPStubs/JSON
    - OHHTTPStubs/NSURLSession
    - OHHTTPStubs/OHPathHelpers
  - OHHTTPStubs/JSON (5.2.3):
    - OHHTTPStubs/Core
  - OHHTTPStubs/NSURLSession (5.2.3):
    - OHHTTPStubs/Core
  - OHHTTPStubs/OHPathHelpers (5.2.3)
  - OHHTTPStubs/Swift (5.2.3):
    - OHHTTPStubs/Core
  - ReachabilitySwift (3)
  - RxAlamofire (3.0.3):
    - RxAlamofire/Core (= 3.0.3)
  - RxAlamofire/Core (3.0.3):
    - Alamofire (~> 4.0)
    - RxSwift (~> 3.0)
  - RxSwift (3.1.0)
  - SimulatorStatusMagic (1.9.2)
  - SVProgressHUD (2.1.2)
  - SwiftyDropbox (4.1.1):
    - Alamofire (~> 4.3.0)
  - SwiftyJSON (3.1.4)
  - Timberjack (0.0.2)

Thanks for the report. This may or may not be related to the extension issues.

While I see a different in the response of the two session types, both eventually return an error, though the background session took longer. With my internet offline, the foreground session returned:
FAILURE: Error Domain=NSURLErrorDomain Code=-1009 "The Internet connection appears to be offline."
The background session returned:
FAILURE: Error Domain=NSURLErrorDomain Code=-1001 "The request timed out."
I'm not really surprised they respond differently, as background sessions are pretty different.
Here are my communicators:
struct Communicator {

    static let shared = Communicator()

    let manager: SessionManager = {
        let policy: [String : ServerTrustPolicy] = ["httpbin.org" : .pinCertificates(certificates: ServerTrustPolicy.certificates(), validateCertificateChain: true, validateHost: true)]
        let configuration = URLSessionConfiguration.default
        configuration.httpAdditionalHeaders = SessionManager.defaultHTTPHeaders

        return SessionManager(configuration: configuration, serverTrustPolicyManager: ServerTrustPolicyManager(policies: policy))
    }()

}

struct BackgroundCommunicator {

    static let shared = BackgroundCommunicator()

    let manager: SessionManager = {
        let configuration = URLSessionConfiguration.background(withIdentifier: "com.jonshier.AlamofireTest.ShareUpload")
        configuration.httpAdditionalHeaders = SessionManager.defaultHTTPHeaders
        configuration.sharedContainerIdentifier = "group.com.jonshier.AlamofireTest"

        return SessionManager(configuration: configuration)
    }()

}

Hi @ened,
Background sessions have completely different behavior as @jshier eluded to. They have all sorts of internal handling for retrying failed requests over super long periods of time in situations where there are challenges, redirects and especially connectivity errors. What you're seeing right now is that when connectivity is lost, the background session's request won't actually throw an error. It will wait until the timeout specified on the URLRequest is reached before returning the timeout error as @jshier pointed out.
If you MUST use background session downloads and you need to tell the user more abruptly when connectivity is lost, you could use the NetworkReachabilityManager to cancel the background request or you could shorten the timeout. I think I'd recommend shortening the timeout for now and seeing if that can get you where you need to be. But keep in mind that in other parts of the world (especially China) there can be significant connectivity lag that could trigger false / positive failures if you shorten it too much.
Best of luck! 🍻

Hi @jshier and @cnoon , I've also found the issue and did what you said that is giving a short timeout period(10s).
The problem then I had:

If you have Wi-Fi ON with no internet, sometimes the timeout gets calls, but sometimes it doesn't.  It's inconsistent. If the 1st time the timeout works, then somehow the 2nd time definitely won't work. Is there a cache or something? Is there a way to clear it?

if you have Wi-Fi OFF before you making the request, then the error/response(the response closure) is guaranteed to be NEVER called. The timeoutForRequest takes NO effect.

Code:
private lazy var sessionManager: SessionManager = {

    let configuration = URLSessionConfiguration.background(withIdentifier: "abc.background")

    //Default timeout
    configuration.timeoutIntervalForRequest = 10

    var manager = Alamofire.SessionManager(configuration: configuration)

    return manager
}()

  self.sessionManager.download("https://www.abc.com", to: self.destionation(destination)).response { (response) in
          debugPrint("timeout:\(Date())")
          debugPrint(response)
  }.downloadProgress(closure: { (progress) in
          debugPrint("Progress:%\(progress.fractionCompleted)")
  }).resume()

@quhaoran007
If you've seen the WWDC sessions or read the updated documentation for the URLSession changes in the new OS versions you've seen that they introduced the notion of delaying requests while waiting for connectivity. Turns out, background sessions had this functionality all along, and that's what you're seeing here. Unfortunately Apple hasn't really documented all or even any of the other behavioral differences you might see in background sessions, so there's not a lot of help we can provide at the moment. We do hope to improve our background integration some time this year.

Hi @jshier , thanks for your reply.
However, all the problems I've mentioned above were occurred when app running in Foreground. Are you saying that if I set the background identifier, even I run the App in foreground I still won't get a immediate failure when Wi-Fi OFF?
The Wi-Fi failure is not a too big deal to me, because I could always run the connectivity test to manually fail the network process. The biggest thing is that the timeoutIntervalForRequest is not always working once I set the background identifier and even the App runs in foreground. So you create the manager like I've written in above, runs the App in foreground and have the Wi-Fi ON and connected to a network without internet, sometimes you get the timeout failure within the timeInterval you set but sometimes you don't. Once I remove the background identifier, then every functionalities work as normal .

Yes, background sessions are still background even if your app is in the foreground. They don't change behavior. The way Apple explained it when introducing the waitingForConnectivity functionality is that your timeouts only apply once the session has been able to reach the server once, at which time the request timeouts would take effect. If the device is offline when the request starts, the request timer will never start as the background session waits for connectivity.
Unfortunately there's not a lot we can do here, as background sessions are largely a black box. They have a variety of different behavior that isn't documented. I suggest you rethink how you're making requests and consider how you want to be using background sessions, as they're really only designed for downloads or uploads you need to continue even if the app is suspended in the background.

@jshier Thanks for your detailed explanation. That helped me a lot.

Hello @jshier
Not getting Time out / Connection lost error in foreground mode with default URLSession configuration,
static let sharedManager: SessionManager = {
    let configuration = URLSessionConfiguration.default
    configuration.timeoutIntervalForRequest = 10.0
    configuration.timeoutIntervalForResource = 10.0
    return SessionManager(configuration: configuration)
}()

Please help.


feat: add hex underscore fmt rule

Closes #6361
This adds a new fmt option for hex literals: hex_underscore = preserve,bytes,remove
The previous one was remove but I made the default preserve which is also the default for number literals.
since this is breaking, I think the default should actually be remove?
EDIT: made remove the default

Remove wasn't made the default here @mattsse ?


Testing

Testing Completed! Fixed an issue with the app saving the content but not rendering. Problem lies in the get all content in database.js where return result should be return result?.value to make sue that if result exists, reutrn the value, but otherwise don't return anything


fixed typo in git command

There was an extra "s" in the git submodule command

Oooops, thanks! :smile:


Add confirmation dialog v1.2

Request confirmation from user before executing delete, clear and exit commands.

Closes #113


Output the found Python version when restoring from cache

This makes it clearer which Python version is in use (for people who are not pinning via runtime.txt), plus that a cache is being used (for people debugging and wondering why their eg review app has different behaviour from an existing app).
Also:

makes the conditional clearer by inverting to avoid the negation
avoids the duplicated cat .heroku/python-version
uses bash quoting and test [[ best practices
adds a test for the Python version changing (previously untested)

Refs #453.

I'd like to avoid this verbosity.

@kennethreitz, it's one extra line of output - compared to the 6 or so that the nodejs buildpack uses to display versions - and I believe would help users debug issues when comparing environments (eg a new stage environment or review app that ends up using a different version of Python).

I think this deserves more discussion.
I'd love it if the build push experience were more designed and less verbose, but given what we currently have, we should tend to being explicit about what's happening.


Fix CREATE TABLE from csv if there is just a header row

Which issue does this PR close?

Closes #3263
Rationale for this change

What changes are included in this PR?

Are there any user-facing changes?

#3272 is overlapping functionality and has tests.

Thanks @sadilet!


Checking usage at the compile time

I often forget to (and make mistypes on) use environment variables I have added or renamed. It would be useful to let dotenvy warn if the programmer used the variables which are not available in .env.  For example:
.env:
FOO=false
BAR_VERSION=2.27

A Rust program:
env::var("FOO_VERSION") # => warns because FOO_VERSION does not appear in .env
env::var("FOO") # => false
# could warn about BAR_VERSION as unused

While some frameworks prohibit access to the environment variables that are not in .env for security reasons, there will be cases when one wants to use variables on the operating system and we don't know what will be available in each environment (staging, development, production, etc.), so it doesn't have to emit errors I suppose. What do you think? Is it even possible with the build scripts?

I often forget to (and make mistypes on) use environment variables I have added or renamed. It would be useful to let dotenvy warn if the programmer used the variables which are not available in .env. For example:
.env:
FOO=false
BAR_VERSION=2.27

A Rust program:
env::var("FOO_VERSION") # => warns because FOO_VERSION does not appear in .env
env::var("FOO") # => false
# could warn about BAR_VERSION as unused

I don't think this is a good idea. It shouldn't matter how an environment variable is defined, whether it is by a dotenv file or by the shell or system.

While some frameworks prohibit access to the environment variables that are not in .env for security reasons
Could you provide some examples so I can take a look?

For preventing typos, dotenvy::var("foo") returns a Result. You can handle that however you wish.
For checking if an environment variable is unused, you could load all of your environment variables as Rust variables, perhaps in a Config struct. Then, you'll get warnings for your Rust variables.

For checking if an environment variable is unused, you could load all of your environment variables as Rust variables, perhaps in a Config struct. Then, you'll get warnings for your Rust variables.

I remembered that I have written that kind of Config struct, and yes, now I realized it also works as an unused checker. Thanks for your reply. Closing :)


Tracked task panels linger after switching task types

Fill out later.
TLDR: Switch between task types with Tracked Tasks and notice UI bug (specifically from a type with tracked tasks to one without.

Fixed by #31


Fixed example in the readme

If I use import controllers as mentioned in the README I get the following error:
13:15:21 js.1   |   errors: [
13:15:21 js.1   |     {
13:15:21 js.1   |       detail: undefined,
13:15:21 js.1   |       id: '',
13:15:21 js.1   |       location: {
13:15:21 js.1   |         column: 7,
13:15:21 js.1   |         file: 'application.js',
13:15:21 js.1   |         length: 13,
13:15:21 js.1   |         line: 24,
13:15:21 js.1   |         lineText: 'import "controllers";',
13:15:21 js.1   |         namespace: '',
13:15:21 js.1   |         suggestion: '"./controllers"'
13:15:21 js.1   |       },
13:15:21 js.1   |       notes: [
13:15:21 js.1   |         {
13:15:21 js.1   |           location: null,
13:15:21 js.1   |           text: 'Use the relative path "./controllers" to reference the file "controllers/index.js". Without the leading "./", the path "controllers" is being interpreted as a package path instead.'
13:15:21 js.1   |         }
13:15:21 js.1   |       ],
13:15:21 js.1   |       pluginName: '',
13:15:21 js.1   |       text: 'Could not resolve "controllers"'
13:15:21 js.1   |     }
13:15:21 js.1   |   ],
13:15:21 js.1   |   warnings: []
13:15:21 js.1   | }
13:15:21 js.1   | error Command failed with exit code 1.
13:15:21 js.1   | info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
13:15:21 js.1   | exited with code 1

I fixed the error by implementing the suggested "./controllers".
I don't know if the same error occurs with importmap, because I don't use it.

Hey @berti92, thanks for opening this pull request!
Yeah, sadly this is because the different solutions/bundlers are using a different import syntaxes.
Instead of changing it in-place we can maybe say that import "controllers" is for importmaps/webpack(er) and import "./controllers for esbuild.

@marcoroth Thank you, I changed it.

We already have a section for importmaps that use the correct import syntax for that. We should default to ./controllers for that other section. It's an error that it hadn't been.


Allow defining completely custom typography or color scheme class

For example instead of having all displayLarge, displayMedium etc, users might want to define their own Typography class with only the values they will use.

This would be very possible if leaning more towards the strategy of Jolt being setup as a separate package for each project, with the core Jolt being a dependency and some boilerplate being setup by CLI. Ie base theme etc


Add DITA 2.0 include element

Add support for DITA 2.0 <include> element. The implementation is effectively the same as for the old <coderef>, thus CoderefResolver is retrofitted to support <include>.

@infotexture Yes, we'll retain the old coderef as is.

I figured the existing <coderef> extensions would be retained for backwards compatibility, but what I meant is “will the same extensions be available for the new <include> element?”
I imagine line range extraction or similar capabilities would be as welcome in this more generalized context as they are in the existing <coderef> use case:
<include href="file.ext#line-range(5,10)" format="something"/>

Yes, the include with parse=text will have those extensions.

@infotexture Now that this is in, should I generate an issues for the docs, or are you able to pick these up?

As a rule, it would be good to provide docs input with each PR per https://github.com/dita-ot/.github/commit/e76ba8b097e1eb38a275a58b4e10006f59af456b.
In cases where changes require extensive docs updates, a dedicated docs issue might be better.
In this particular case, I'm not sure whether the changes warrant documentation of their own, or whether the <include> support would be better described in the context of evolving support for DITA 2.0 features.


Fixes a typo on NULL checking for sc->assigned structure

Hello,
looking at staple_here function and NULL check as
if (sc->assigned
        && sc->assigned->nelts == 1
...

it seems to me that these two usages of || are typos. I might just not be getting the point though...
mod_md builds and runs O.K. for me with httpd 2.4.x HEAD from yesterday; (Apache/2.4.42-dev, OpenSSL/1.1.1d) although I played just with Boulder locally...
...
MDCertificateAuthority http://localhost:4000/directory
MDCertificateAgreement accepted
MDRequireHttps permanent
MDStapling on
MDStaplingKeepResponse 1d
MDStaplingRenewWindow 99%
MDCAChallenges tls-alpn-01
Protocols h2 http/1.1 acme-tls/1
...

Regardless of the change, the same 4 tests fails for me in the TS: https://gist.github.com/Karm/b260dd339300110d761cd7c4363332b1

Thanks for finding this. Happily merged.
The tests that fail for you do a forward proxy setup on HTTP_PROXY_PORT which by default is 5052. This is to test the case where the Let's Encrypt servers are only reachable via a http proxy due to datacenter security policies. Maybe that helps you track this down.


Getting Issue while adding property to SPFx ACE manifest json

Hi Vesa,
I am following the article https://docs.microsoft.com/en-us/sharepoint/dev/spfx/viva/get-started/advanced-card-view-functionality to add listId to the manifest json as mentioned in the article
"preconfiguredEntries": [{
// ...
"properties": {
"title": "HelloWorld",
"description": "HelloWorld description",
"iconProperty": "", // Default to sharepointlogo
"listId": "My List ID"
}
}]
But I am not sure why below line is not able to pick up the listId mentioned in the json
private async _fetchData(): Promise {
console.log("Into Fetch Data method")
if (this.properties.listId) {
console.log(this.properties.listId)
const response = await this.context.spHttpClient.get(
${this.context.pageContext.web.absoluteUrl} +
/_api/web/lists/GetById(id='${this.properties.listId}')/items,
SPHttpClient.configurations.v1
);
this.properties.listId is undefined when I am running the sample.
I have followed exact same steps mentioned in the article. In fact when I am trying to add any other property to the json, its not recognizing. Can you please help here
Thanks,
Soumya
Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 1df51c42-8625-3ea8-2ec7-e48be7a2c4cf
Version Independent ID: a5cd77bb-c8cc-8251-5480-1bd2da79cfa2
Content: Advanced Card View Functionality
Content Source: docs/spfx/viva/get-started/advanced-card-view-functionality.md
Product: sharepoint
Technology: sharepoint-framework
GitHub Login: @VesaJuvonen
Microsoft Alias: vesaj

Closing the issue as issue got resolved after creating separate solution again


Map issues with Traffic Light IDs in Town04

Describe the bug
Apollo does not recognize the Traffic Light signals sent from the bridge.
I manually inspected the carla_town04/base_map.txt and it seems to be missing most traffic lights from Carla.
https://github.com/guardstrikelab/carla_apollo_bridge/blob/master/carla_bridge/map/carla_town04/base_map.txt
base_map.txt contains 18 signals, while Carla's Town04 contains 43 signals.
The signal IDs published from the bridge matched only 8 signals from Apollo's map.
Steps to Reproduce the Problem

Run any route through Carla Town04. Most Traffic Lights will be ignored, and in some, the traffic light state published from the bridge will not be recognized.

What version of carla_apollo_bridge?
0.3.0

Hi, I thought the traffic lights are only properly set up in TOWN01.
Since you can run apollo in TOWN04, May I ask you a question?
I met a problem that, when I run apollo vehicle in TOWN03,04, the vehicle always freak out, the planning on dreamview, the steering and throttle jumps around, and the vehicle tries to drive on lane marking(I think for some reason, the system sees the lane marking as lane centerline). Did you met problem like this when you run apollo in TOWN04? Thank you very much!

Does it happen on an empty road or when there are vehicles ahead?
There is a lane borrow behavior in Apollo Planning where Ego will drive on opposite traffic to overtake stationary objects. But the threshold does not seem to be correct, so I turned that off. The vehicle should keep driving on its lane.
If it is happening on empty road, that is more likely to be an issue with Control and the Planning is trying to recover from oversteering. More likely to happen at lower speeds, going from stationary to driving.
In both cases, it should not be based on the Map.

Does it happen on an empty road or when there are vehicles ahead? There is a lane borrow behavior in Apollo Planning where Ego will drive on opposite traffic to overtake stationary objects. But the threshold does not seem to be correct, so I turned that off. The vehicle should keep driving on its lane. If it is happening on empty road, that is more likely to be an issue with Control and the Planning is trying to recover from oversteering. More likely to happen at lower speeds, going from stationary to driving. In both cases, it should not be based on the Map.

Hi Howicc, sorry for the late reply and thank you for the suggestions!
The problem has on an empty road and regardless of whether vehicle is on two-way 2 lanes or two-way 4/8 lanes. I also tried completely straight road, so that steering in unnecessary. All showed the same problem. I recorded a video for your review:
https://github.com/guardstrikelab/carla_apollo_bridge/assets/44992571/82ff5c5b-8ccb-4a06-8c69-309d11caf685

I'm having the same issues with the Map. Should we assume that only Town 01 is working?

I'm having the same issues with the Map. Should we assume that only Town 01 is working?

You mean with traffic lights or with planning gone freaking out?

I'm having the same issues with the Map. Should we assume that only Town 01 is working?

You mean with traffic lights or with planning gone freaking out?

The Traffic Lights from the Map. They do not match Carla's Maps.


business process?

Can we add an overall business diagram chart here just like other processes?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: ff2f03a9-638c-0f08-123a-3a790ba3c0d4
Version Independent ID: 48c5f196-d266-92a9-bcd5-388d4ae78ee0
Content: Budgeting home page - Finance & Operations | Dynamics 365 | #MSDyn365FO
Content Source: articles/financials/budgeting/budgeting-overview.md
Service: dynamics-ax-applications
GitHub Login: @ShylaThompson
Microsoft Alias: shylaw

Thanks for the feedback. I have passed this suggestion on to the topic owner.


Fix non-custom build runner name

Summary
I mentioned when native build done by the framework is not a custom one, the runner name is -runner. It doesn't cause issues on Linux (not sure on Windows as it's not part of the PR workflow, probably, but it needs to be fixed anyway). Sorry. New name will be quarkus-runner or quarkus-runner.exe.
Please check the relevant options

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Dependency update
[x] Refactoring
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] This change requires a documentation update
[x] This change requires execution against OCP (use run tests phrase in comment)

Checklist:

[ ] Example scenarios has been updated / added
[ ] Methods and classes used in PR scenarios are meaningful
[x] Commits are well encapsulated and follow the best practices

run tests

I'm not sure whether the failure is related, but it's reproducible. I'll have a look.

@mjurc do you want to check this or rather prefer to delegate?

run tests

I'll debug io.quarkus.qe.OpenShiftContainerIT.customPort, io.quarkus.qe.OpenShiftContainerIT.managed and let you know.

So Docker push does something like this #8 [4/4] COPY --chown=1001:root target/custom-build/*-runner /work/application which means it doesn't care about artifact path we have passed it. I'm on it.

run tests

Thanks for the fix.


Configurable width

I've just discovered this extension, and it's great! One thing that would make it better, is to be able to configure how much of the screen to use. Most of the time I think the default width github uses is too narrow, but often I'm on a huge screen and using the full width of the window is a bit too much. Would be great to set a percentage of the width to use.

Wish I could send you a +1000


[ZP-26] - Remove event if dom's element destroy

Description
This PR change logic of add new event listener on frontend. Now then add new event listener, also added destroy listener. Destroy listener attach to some DOM element and then this element destroyed listener drop event listener.
Since the old listeners were not deleted when changing the size of the paragraph / window, an error occurred. Because of this error, updating the text in the paragraph did not happen until the end.
Info
PR type: Bug Fix |  Jira issue: ZEPPELIN-3616, ZP-23, ZP-26
Screenshots
List of all resize event (after some time of work)
before (77 lis.)

after (16 lis.)

Questions:

Does the licenses files need update? no
Is there breaking changes for older versions? no
Does this needs documentation? no

Залили в apache https://github.com/apache/zeppelin/pull/3113#event-1956705396


The agent autoscaling group should never rebalance availability zones

By default, if the two availability zones in the agent ASG become significantly unbalanced, the ASG will terminate some instances in the larger AZ and start some new ones in the smaller AZ.
That's helpful for an ASG serving web requests, but it's not very helpful for our agent-shared workloads - the instance termination can disrupt running jobs. With the new lambda based scaler, each instance is responsible for terminating itself and the AZs become unbalanced very easily. That's not much of a problem though - the larger AZ is likely to reduce in size relatively soon, and subsequent scale-outs will restore the balance (for a while).
Sadly there's no way to suspend the AZRebalance process via cloudformation, so I held my nose and implemented it using a custom resource. It's not as ugly as I feared, mainly because it's possible to provide the required lambda function inline.
An alternative approach would be to have our buildkite-agent-scaler lambda check the AZRebalance status each time it loops and suspend the process if required. I thought this approach might be good enough for now, and we could try the scaler option down the track if we need to.
Some resources I found useful:

https://www.alexdebrie.com/posts/cloudformation-custom-resources/
https://gist.github.com/atward/9573b9fbd3bfd6c453158c28356bec05
https://docs.aws.amazon.com/autoscaling/ec2/APIReference/API_SuspendProcesses.html
https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/cfn-lambda-function-code-cfnresponsemodule.html

Here's a screenshot of the ASG in a newly created stack, built with this PR:

I've tested stack creation and deletion with the new custom resource, and both worked as expected.

Related: #700

This is great @yob, pleased at actually how brief the custom resource ends up being.

Nice 👍🏼


Error in GetScale method in SteamVR_Utils class

Hi!
I think the method GetScale from SteamVR_Utils class contains Error. Scale components should be calculated via Matrix4x4  as follows:
var x = Mathf.Sqrt(m.m00 * m.m00 + m.m10 * m.m10 + m.m20 * m.m20);
var y = Mathf.Sqrt(m.m01 * m.m01 + m.m11 * m.m11 + m.m21 * m.m21);
var z = Mathf.Sqrt(m.m02 * m.m02 + m.m12 * m.m12 + m.m22 * m.m22);

You're correct, I believe this has been fixed.


java tink library is not scaling with java threads

It seems that java tink library does not scale with java threads. Find attached a small java test program.
Find below test results with one and three threads, running on a unix (redhat) box with 24 vCPUs.
In both cases around 1.000.000 encryption operations are executed every second. The amount of encryption operations is not increasing when using more threads.
java AeadThread encrypt "This is a test" 10000000 1
origtext: This is a test
Thread: 1 for encryption loop: Mon Jun 12 10:49:25 CEST 2023
Thread: 1 after encryption loop: Mon Jun 12 10:49:34 CEST 2023
java AeadThread encrypt "This is a test" 10000000 3
origtext: This is a test
Thread: 2 for encryption loop: Mon Jun 12 11:09:25 CEST 2023
Thread: 3 for encryption loop: Mon Jun 12 11:09:25 CEST 2023
Thread: 1 for encryption loop: Mon Jun 12 11:09:25 CEST 2023
Thread: 1 after encryption loop: Mon Jun 12 11:09:53 CEST 2023
Thread: 2 after encryption loop: Mon Jun 12 11:09:53 CEST 2023
Thread: 3 after encryption loop: Mon Jun 12 11:09:53 CEST 2023
test environment:
java version: openjdk version "1.8.0_362"
java tink library version: 1.9.0
Aead object is shared between threads.
AeadThread.zip

This seems to be a duplicate of https://github.com/google/tink/issues/696. Please reply on my comments there.


Subtle whitepaper link is not internationalized

One of the whitepaper links on the home page does not properly link to languages other than en. The relevant line in the template is here. In order to satisfy this issue, the following criteria should be met:

[ ] The entire phrase "Product Brief and Whitepaper released" should be contained within a single gettext helper so that it gets translated effectively.
[ ] Both the phrase "Product Brief" and word "Whitepaper" should be separately linked to the relevant URL for the CURRENT_LANGUAGE.

@wanderingstan suggests that a possible solution might involve passing url_for as an argument to to gettext.

Some So discussion here on best ways to do var substitution in getext() : https://stackoverflow.com/questions/2901082/best-practice-for-string-substition-with-gettext-using-python


G8 Execution Template to get the latest version of etl-util......

Gets the latest version of etl.util from artifactory while creating template
Parse the source and domain from the project name, which is used in G8 template for creating Execution class and necessary values.

Does it work? :smile:

:+1:
You can merge it after the minor fixes and bumping the minor version number in version.sbt and if you are convinced that it works.

Yes it working. I just found that source and domain got swapped, fixed it as well.
Will bump the minor version and update


Update govultr from v3.11.2 to v3.13.0

Description

Update govultr from v3.11.2 to v3.13.0

Tested and working


Moving is_relocatable to namespace hpx

Fixes compilation problems on master

@isidorostsa please verify that this is ok.

It looks good to me! Should I also change the unit test to look for hpx::traits::is_relocatable<>?

It looks good to me! Should I also change the unit test to look for hpx::traits::is_relocatable<>?

I think we should keep the trait as hpx::is_relocatable for compatibility with the standard.

It looks good to me! Should I also change the unit test to look for hpx::traits::is_relocatable<>?

I think we should keep the trait as hpx::is_relocatable for compatibility with the standard.

I completely agree with that

bors merge


822 add details to event logs

Description
Add more information of the events like tags, title, and description when POST, PUT, DELTE, and PATCH.
Fixes #(add issue number here and remove parentheses)
Review Time Estimate
Please give your idea of how soon this pull request needs to be reviewed by selecting one of the options below. This can be based on the criticality of the issue at hand and/or other relevant factors.

[ ] Immediately
[ ] Within a week
[x] When possible

Type of changes
Please select a relevant option:

[ ] Bug fix (non-breaking change which fixes an issue).
[x] New feature (non-breaking change which adds functionality).
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected).
[ ] Other (any another change that does not fall in one of the above categories.)

Checklist:
Please select all applicable options:

[x] I have signed the Rokwire Contributor License Agreement (CLA). (Any contributor who is not an employee of the University of Illinois whose official duties include contributing to the Rokwire software, or who is not paid by the Rokwire project, needs to sign the CLA before their contribution can be accepted.)
[x] I have updated the CHANGELOG.
[x] I have read the Contributor Guidelines.
[x] I have performed a self-review of my own code.
[x] I have commented my code, particularly in hard-to-understand areas.
[ ] My change requires updating the documentation.
[ ] I have made necessary changes to the documentation.
[ ] I have added tests related to my changes.
[ ] My changes generate no new warnings.
[ ] New and existing unit tests pass locally with my changes.
[ ] Any dependent changes have been merged and published in downstream modules.

@ywkim312, I have left a couple of comments. The rest looks good to me. Thank you!


What is our pypi author policy?

As of today we list Sebastian, Naresh and Wenwen in https://github.com/eclipse/kuksa.val/blob/master/kuksa-client/setup.cfg
This also gets visible in https://pypi.org/project/kuksa-client/.
Naresh and Wenwen however are not that active in the project. From a communication perspective a public address like<EMAIL_ADDRESS>seems more appropriate, and that is also what we use in https://github.com/eclipse/kuksa.val/blob/master/kuksa_certificates/genCerts.sh, but then author better should be "Eclipse KUKSA project" or similar.
I can see three possible policies:

Historical persons that never should change. That is what we have today
Listing persons actively working with the component. if so we should possible replace Naresh and Wenwen with Erik and Lukas
Use a "community name/e-mail", like "Eclipse KUKSA project"

For practical perspectives the second or third option seems reasonable, and the third is easiest to maintain, but require that we have a working common mail address

I would take the third option. Easiest to maintain.


Set August doorbell availability state from online state

Description:
The available state for the August Doorbell is currently set based on the state of the binary ding sensor.  This means that if there is no door bell rings in a while on startup the doorbell is shown as Unavailable . This ties the availability of the doorbell to the  actual online state thats in the device information retrieved from august so that even if there has not been a doorbell ring activity on a while the device shows as online when it is.
Related issue (if applicable): fixes #20421
Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>
Example entry for configuration.yaml (if applicable):
august:
  login_method: email
  username: <some email>
  password: <some password>

Checklist:

[X] The code change is tested and works locally.
[X] Local tests pass with tox. Your PR cannot be merged unless tests pass
[X] There is no commented out code in this PR.

If the code communicates with devices, web services, or third-party tools:

[X] New dependencies have been added to the REQUIREMENTS variable ([example][ex-requir]).
[X] New dependencies are only imported inside functions that use them ([example][ex-import]).
[X] New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
[X] New files were added to .coveragerc.

There is similar logic in AugustDoorBinarySensor and AugustLock too.  Are there changes that can/should be made there too?

The rest call for the Doorbell status is different than the one for the Lock, which provide the AugustDoorBinarySensor and AugustLock states.
The Doorbell one has an explicit state for online and is potentially in a separate online state than the Lock since the Lock can be served by the August Connect or the DoorBell.
That being said, the status check for the Lock does have a "Bridge" section which appears to have an online state for the wifi bridge provider for the Lock.   We could base the availability of the Lock on this Bridge section but I currently have the Lock bridged with the Connect and do not have an example of the Bridge being a DoorBell to make sure the logic and structure are the same.  If we can get a debug log of a Lock bridged with a Doorbell instead of the Connect we should be able to make the availability of the entities based on the Locks Bridges online state in both cases.

If we can get a debug log of a Lock bridged with a Doorbell instead of the Connect we should be able to make the availability of the entities based on the Locks Bridges online state in both cases.

Let's worry about that in another time... Outside the scope of the fix for what was reported. :)


Support for mongo?

Hi, sorry if this already answered here somewhere, but I am curious if support for mongodb and other NoSql databases is on the roadmap or if I should be looking at another tool for doing mongo migrations for my rust micro-services.
Thanks!

We don't have any plans to support NoSQL databases. The name of the crate is SQLx, after all.


caching headers added independently of status code

When we apply the cache_for decorator to a flask_response, the caching header is applied even if we abort the request with the flask abort function or if we answer with a non 200 code (see 400, 500, 504 as example). Or we should configure for which status codes to return the caching headers, or the decorator itself shouldn't add them if the response has an error status code.

Thanks for reporting. @dedominicisfa
PR #4 allows for making the cache control headers status code specific and also does so by default.
These changes have been released in 0.2.0. Please note that py2 support has been dropped with this release.


FR: it would be useful to have a foreground colour in the object

Right now the snackbars all use white as their foreground colour. I had been using my own copy of your tool from v2.1.2. I had customized it to read an "fg" field from the object and use that as the foreground colour for the text.
I decided I would try to upgrade to your lastest version and ditch my customized copy. The background colours I have chosen don't work well with white text. I think I can get around it by using a slot to render my own text, but it would be nice to not have to do that.

I could do a pull request for it if you would accept it.

I was hoping that I could implement this with the current component using the default slot, but I can't because the object isn't passed to the slot, only the message is passed to the slot, so it really does need a PR to get this type of functionality.

Can you show me the excepted render? It would help me visualize what you want to achieve!

Yes I can. Here is what my success snackbar looks like:

and here is what my error snackbar looks like:

The 'x' icon for the close I can already do with the slot for the action, although it will need to get the foreground colour as well.

I took this colour scheme from the Vuetify docs site. You can see the error and warning alert styles on this page:
https://vuetifyjs.com/en/getting-started/installation/

Thanks. I'll have a closer look tomorrow.

I use the object prop and my objects have an fg field that contains the corresponding colour of green or red. If you are going to add this, take your pick of property name. I am not wedded to "fg".

You can already do it with color and content-class:
<v-snackbars
        :messages.sync="messages"
        color="red lighten-5"
        content-class="error--text"
        bottom
        left
      >
        <template v-slot:action="{ close, message }">
          <v-btn text class="error--text" @click="close()">×</v-btn>
        </template>
      </v-snackbars>

That works if I wanted every single snackbar to be red. I have one queue of snackbars for the system. The application either puts a success message (green) or an error message (red) into the queue and then v-snackbars displays them on the screen for an appropriate amount of time (a longer period for an error).
The colour has to come from the message object itself, it can't be hard coded into the v-snackbars component.

In that case you'll have to use objects with content-class. I've just published a new version (v3.2.5) that supports content-class in objects:
<v-snackbars :objects.sync="objects">
  <template v-slot:action="{ close, message, index }">
    <!-- use `class` to inherent and get the same text color -->
    <v-btn text :class="objects[index]['content-class']" @click="close()"
      >X</v-btn
    >
  </template>
</v-snackbars>

this.objects.push({
  message: "the message to display",
  bottom: true,
  left: true,
  color: "red lighten-5",
  "content-class": "red--text",
  timeout: 30000
});
this.objects.push({
  message: "another message",
  bottom: true,
  left: true,
  color: "green lighten-5",
  "content-class": "green--text",
  timeout: 30000
});

(actually I've just found a bug that I'm fixing now… a new version will be released)

Ok, I see you also pull content-class from each message object. Ok. I will just have to create a class with the colour I want for each message type.

Version 3.2.6 is published!

@Aymkdn  I hate to ask, but content-class is not a valid javascript field name. I am using typescript which makes this a really hard object field to name. I can't create a typescript interface to define the shape of the messages object.
Can that be changed to "class". Hmm, class wont work either. That is a reserved keyword. Would you be able to rename it to contentClass? or just about anything without a '-' in it?

content-class is what Vuetify is using…
OK, I renamed content-class to contentClass when using the objects type.
<v-snackbars :objects.sync="objects">
  <template v-slot:action="{ close, index }">
    <!-- use `class` to inherent and get the same text color -->
    <v-btn text :class="objects[index].contentClass" @click="close()">X</v-btn>
  </template>
</v-snackbars>

this.objects.push({
  message: "the message to display",
  bottom: true,
  left: true,
  color: "red lighten-5",
  contentClass: "red--text",
  timeout: 30000
});
this.objects.push({
  message: "another message",
  bottom: true,
  left: true,
  color: "green lighten-5",
  contentClass: "green--text",
  timeout: 30000
});

I see the new release. Thank you very much! I have updated to the new version and it works great.


Fix incorrect VO for selected check-in date

This PR fixes an accessibility bug where VO incorrectly defines a selected check-in date in calendar as unavailable. This is fixed by checking if the day is both blocked and selected, and if this is true the phrase should be dateIsSelected.

Coverage decreased (-0.04%) to 84.973% when pulling f8e36beaffdd00be6fa4d06ab89797015df14f82 on nkinser:nk-fix-incorrect-VO-for-selected-checkin-date into de18afa8019c40464d93944385d73e5175192c14 on airbnb:master.

@majapw Can you take a look at this? Thanks!

@majapw PTAL! Thanks!


use antiword for .doc files instead of catdoc

again, catdoc is troublesome

Trying wv as well: brew install wv, http://wvware.sourceforge.net/
Is used by abiword under the hood.

Note for antiword docs: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=307657

Done with c4c18b13bc55db0590c6b18e488b2d2a8812428c


Add Eth66 as supported version by default

Describe the feature
Currently, we only include eth77
https://github.com/paradigmxyz/reth/blob/c6d38f0f6a652c227df861a2735364b945270433/crates/net/eth-wire/src/builder.rs#L101
eth66 is a superset of eth77: https://github.com/ethereum/devp2p/blob/master/caps/eth.md#eth66-eip-2481-april-2021

Version 67 removed the GetNodeData and NodeData messages.

which should still be fine, even though we don't have handlers implemented yet.
Additional context
No response

eth/66 will work if we return an empty responses for those messages.


Improve deterministic transaction sorting in TxQ

High Level Overview of Change
This is a follow-up to #4022. That PR added functionality to order the transaction queue by fee descending, then by transaction ID ascending. This PR makes the transaction ordering less predictable by XORing the transaction ID with the parent ledger hash. This is similar to the mechanism used in CanonicalTXSet to randomize the order of accounts, so no account has an advantage. This change randomizes the order of transactions paying the same fee, so no transaction has an advantage.
After weighing several options, I decided that the simplest solution was to leave the data structure intact and only change the comparison function - basically the same type of change made to transaction queue ordering in #4022. The trick to making it work is to reorder the queue whenever the parent ledger hash changes, which happens in TxQ::accept. Again, to keep things simple, the queue data structure (byFee_) is emptied and rebuilt. That structure is intrusive - the objects are actually scoped in the byAccount_ structure - so there is zero risk of anything getting dropped. It turns out this method is fast, too.
As validators upgrade to the version with this change, if the network is under high load, such that there are a lot of transactions in the queues, their initial proposals will diverge, but that won't be a problem because the issues around transactions not being properly deferred have been fixed.
No amendment is needed for this change.
Type of Change

[X ] New feature (non-breaking change which adds functionality)

Test Plan

Reproduce the conditions that were tested in #4022 on a test network.
Migrate the test validators one at a time to this version.
Verify that there is no additional congestion, and that validators stay in sync.

Rebased on to 1.8.5 and squashed.


Fungible token - vote

Add vite functionality to MassaLabs Fungible token implementation.

What do you mean by a vote functionnality ?
I know about the Voting Escrow ( Voting power decreasing linearly with time ) but I'm not sure that this is what we mean in that ticket no ?

Currently diving into this project. if you have any time to explain what is needed @gregLibert It would be cool

This is what I have in mind : https://docs.openzeppelin.com/contracts/4.x/api/token/erc20#ERC20Votes
If it doesn't make sens, let's talk about it :-)

The main goal is to implement all of this func

For this we will need an equivalent implementation of all of this

For this we will need an equivalent implementation of all of this

ERC20 functions should be there but ERC20PERMIT is missing.
The need around the "private" functions of EIP712 is to clarify.

The Erc 20 Permit has been build 5days ago and his first release has been release 5 days ago.
Shall we consider this right now ? or maybe it's to fresh to build on it ?

https://eips.ethereum.org/EIPS/eip-2612
5days ago was the launch of EIP2612

From EIP2612

After Discussion we decided, to cut the crap atm, and don't implement eip2612 and eip712.
So my point is to understand clearly how as sdk work
And right now i have to understand and transpile ERC 20 Votes function,  from Solidity to AS .
I think it can take some time and i will proceed by iteration digging on each functions what is really needed and what we actually get done on the sdk

Checkpoints :

Is it relevant to our votes systems ?
In the process of building Massa it is done at the good time ?
And does it fit to our Massa context ( in ETH , Checkpoints are storing values at each block )

Delegate : there is three distinct mecanism ,

delegate(sender, delegatee)
delegateBySig(same as delegate with signer)
_delegate  (change delegator to delegatee)

_delegate will involve moveVotingPower which involve the Checkpoints concepts (Maybe we can bypass This, have to discuss)

Trade Off :

Avoiding EIP 712
Avoiding EIP 2612
Implementation off Checkpoints to grab past data --> Reported to V2
Implementation only Owner Hardcoded --> Dynamic implementation Reported Later

Potential technical implementation : Todo

Lists of implementations :
Governance subjects //

CRUD Proposal
voting Delay , voting Period (Based on date/timestamp not , Period , atm no link between data on chain and sdk )
executeProposal
And lots of events : castVote , ProposalsExecuted, Proposals Created , Proposals canceled

Token Context subject //

Delegate
Mint (Currently implemented by Eugeny still in review) Think to overcharge it to fit with the voting system
Burn (Not implemented atm)
Update Voting power

Voting action//

Vote to a proposal
??

ATM that what i have identified maybe will find something else after some implementation
If you have any concerns feel free to reach me

https://github.com/massalabs/massa-as-sdk/issues/37


Support kafka executables without shell extension?

Hi,
Is it possible to have the kafka-tools support kafka-reassign-partitions instead of kafka-reassign-partitions.sh ? For example, the confluent Kafka images do an apt-get install which go and places the shell scripts directly in the /usr/bin folder, but they don't have the .sh extension.
It'd be great if kafka-tools could support either.
Thoughts on this? I can try to do a PR but it might be messy
Regards,
Stephane

Seems like a good idea. Perhaps we should have an env var for KAFKA_DIST_BIN that points to the prefix for the local installation of Kafka. If that variable isn't set, then it just tries a few common locations before giving up.

@bringhurst have you seen https://github.com/linkedin/kafka-tools/pull/51 ?


ScrollView does not consider bottom padding.

When using ScrollView with the padding prop set, the padding at the bottom will be cut short by the scroll.
    Body {
        ScrollView {
            padding: "96",

            // ...
        }
    }
)

https://github.com/user-attachments/assets/11bb8351-b99c-4c85-bdb3-98de9fe0880e
This seems to be due to a bad height calculation, and can be circumvented by adding a child rect with its own padding.

Probably a bug on Torin if I were to guess


revert recent bytes/str commit: fails for binary data

Dear Hernan,
with the recent commit f7f06d5 I experienced problems with reading binary data. In particular, '.decode('ascii')' in from_string_buffer_raw() fails for binary data containing characters > 127. I think the result from a read command needs to be a bytes, not a string object, for not loosing any data. I propose to simply revert the commit.
This problem was masked by catching and ignoring all exceptions in read_raw()
Gregor

Still having this issue when I read a instrument that returns the '@' character.
I'm using python 2.7.


Timeline for SalesforceIQ API address change?

Noticed that the API documentation has been updated to reference api.salesforceiq.com but the gem is still pointing to api.relateiq.com. I assume this will continue to work for the foreseeable future? Are we in any immediate risk of this breaking? Didn't see any sort of timeline for migration... Thanks!

Definitely no risk of breaking. It'll redirect for a while. The next time we cut a release for the gem, it'll include the updated url and your apps won't notice a service disruption.
I'll close this issue when that change is in.


Integration with Lumen

Issue Summary
how to integrate the lib with the lumen. I tried doing the normal way (mentioned in the documentation but it didn't work).
Steps to Reproduce
Technical details:

sendgrid-php Version: master (latest commit: [commit number])
PHP Version: 7.1 (as of May 17, 2018)

Please see issue #590


Docker crashed even with docker bootscripts enabled

Hi,
As discussed on forums, even if you add docker bootscripts to your VC1 servers, you can't run docker on Alpine.
With docker bootscripts, docker.log says:
time="2016-04-13T17:10:10.821553712Z" level=info msg="[graphdriver] using prior storage driver \"overlay\""
time="2016-04-13T17:10:10.830103873Z" level=info msg="Graph migration to content-addressability took 0.00 seconds"
time="2016-04-13T17:10:10.832772693Z" level=warning msg="Running modprobe nf_nat failed with message: `modprobe: can't change directory to '4.4.6-docker-6': No such file or directory`, error: exit status 1"
time="2016-04-13T17:10:11.081818443Z" level=info msg="Default bridge (docker0) is assigned with an IP address <IP_ADDRESS>/16. Daemon option --bip can be used to set a preferred  IP address"
time="2016-04-13T17:10:11.280982282Z" level=warning msg="Your kernel does not support cgroup memory limit: mountpoint for memory not found"
time="2016-04-13T17:10:11.281151903Z" level=warning msg="mountpoint for cpu not found"
time="2016-04-13T17:10:11.281336051Z" level=warning msg="mountpoint for blkio not found"
time="2016-04-13T17:10:11.281442300Z" level=warning msg="mountpoint for cpuset not found"
time="2016-04-13T17:10:11.281762935Z" level=fatal msg="Error starting daemon: Devices cgroup isn't mounted"
time="2016-04-13T17:10:59.878155992Z" level=info msg="[graphdriver] using prior storage driver \"overlay\""
time="2016-04-13T17:10:59.879129308Z" level=info msg="Graph migration to content-addressability took 0.00   seconds"
time="2016-04-13T17:10:59.883080828Z" level=warning msg="Running modprobe nf_nat failed with message:    `modprobe: module nf_nat not found in modules.dep`, error: exit status 1"
time="2016-04-13T17:11:00.142649835Z" level=info msg="Default bridge (docker0) is assigned with an IP address <IP_ADDRESS>/16. Daemon option --bip can be used to set a preferred IP address"
time="2016-04-13T17:11:00.343152616Z" level=warning msg="Your kernel does not support cgroup memory limit:  mountpoint for memory not found"
time="2016-04-13T17:11:00.343291258Z" level=warning msg="mountpoint for cpu not found"
time="2016-04-13T17:11:00.343392574Z" level=warning msg="mountpoint for blkio not found"
time="2016-04-13T17:11:00.343567979Z" level=warning msg="mountpoint for cpuset not found"
time="2016-04-13T17:11:00.343944562Z" level=fatal msg="Error starting daemon: Devices cgroup isn't mounted"

My kernel is:
cvsq:~# uname -a
Linux cvsq 4.4.6-docker-6 #1 SMP Mon Apr 11 21:20:31 UTC 2016 x86_64 Linux

Let me know if you need more details or if you want me doing some tests.
Thanks,
Nicolas

Hi @nsteinmetz,
Thank you for your feedback, I will try to fix it with a custom bootscript which will contain "cgroup_enable=memory swapaccount=1" as soon as possible 😊

Ok, let me know!

We don't need to use a custom bootscript 👍
To fix your issue, you need to mount /sys/fs/cgroup
ecstatic-poitras:~# vim /etc/apk/repositories  # uncomment community packages

ecstatic-poitras:~# depmod -a                        # load the modules

ecstatic-poitras:~# cat /etc/fstab
/dev/cdrom	/media/cdrom	iso9660	noauto,ro 0 0
/dev/usbdisk	/media/usb	vfat	noauto,ro 0 0
cgroup  /sys/fs/cgroup  cgroup  defaults  0   0               # add this line

ecstatic-poitras:~# mount /sys/fs/cgroup/

ecstatic-poitras:~# apk update
fetch http://nl.alpinelinux.org/alpine/latest-stable/main/x86_64/APKINDEX.tar.gz
fetch http://nl.alpinelinux.org/alpine/edge/community/x86_64/APKINDEX.tar.gz
v3.3.3-22-gbb3e6c5 [http://nl.alpinelinux.org/alpine/latest-stable/main]
v160223-1157-g0945898 [http://nl.alpinelinux.org/alpine/edge/community]
OK: 5943 distinct packages available
ecstatic-poitras:~# apk add docker
(1/7) Installing iptables (1.4.21-r4)
(2/7) Installing expat (2.1.0-r2)
(3/7) Installing pcre (8.38-r0)
(4/7) Installing git (2.6.6-r0)
(5/7) Installing xz-libs (5.2.2-r1)
(6/7) Installing xz (5.2.2-r1)
(7/7) Installing docker (1.10.3-r0)
Executing docker-1.10.3-r0.pre-install
Executing busybox-1.24.1-r7.trigger
OK: 103 MiB in 39 packages
ecstatic-poitras:~# /etc/init.d/docker start
 * Caching service dependencies ...                                                                                [ ok ]
 * /var/log/docker.log: creating file
 * /var/log/docker.log: correcting mode
 * /var/log/docker.log: correcting owner
 * Starting docker ...                                                                                [ ok ]
ecstatic-poitras:~# apk add docker
ecstatic-poitras:~# cat /var/log/docker.log
time="2016-04-14T13:01:16.429789153Z" level=error msg="Failed to built-in GetDriver graph aufs /var/lib/docker"
time="2016-04-14T13:01:16.429956003Z" level=error msg="Failed to built-in GetDriver graph devicemapper /var/lib/docker"
time="2016-04-14T13:01:16.494104928Z" level=info msg="Graph migration to content-addressability took 0.00 seconds"
time="2016-04-14T13:01:16.497778978Z" level=warning msg="Running modprobe nf_nat failed with message: `modprobe: module nf_nat not found in modules.dep`, error: exit status 1"
time="2016-04-14T13:01:16.736555351Z" level=info msg="Default bridge (docker0) is assigned with an IP address <IP_ADDRESS>/16. Daemon option --bip can be used to set a preferred IP address"
time="2016-04-14T13:01:17.230252697Z" level=info msg="Loading containers: start."

time="2016-04-14T13:01:17.230368850Z" level=info msg="Loading containers: done."
time="2016-04-14T13:01:17.230403317Z" level=info msg="Daemon has completed initialization"
time="2016-04-14T13:01:17.230446726Z" level=info msg="Docker daemon" commit=a5815f5 execdriver=native-0.2 graphdriver=overlay version=1.10.3
time="2016-04-14T13:01:17.260612427Z" level=info msg="API listen on /var/run/docker.sock"
ecstatic-poitras:~# docker run hello-wolrd
Unable to find image 'hello-wolrd:latest' locally
^C
ecstatic-poitras:~# docker run hello-world
Unable to find image 'hello-world:latest' locally
latest: Pulling from library/hello-world
03f4658f8b78: Pull complete
a3ed95caeb02: Pull complete
Digest: sha256:8be990ef2aeb16dbcb9271ddfe2610fa6658d13f6dfb8bc72074cc1ca36966a7
Status: Downloaded newer image for hello-world:latest

Hello from Docker.
This message shows that your installation appears to be working correctly.

To generate this message, Docker took the following steps:
 1. The Docker client contacted the Docker daemon.
 2. The Docker daemon pulled the "hello-world" image from the Docker Hub.
 3. The Docker daemon created a new container from that image which runs the
    executable that produces the output you are currently reading.
 4. The Docker daemon streamed that output to the Docker client, which sent it
    to your terminal.

To try something more ambitious, you can run an Ubuntu container with:
 $ docker run -it ubuntu bash

Share images, automate workflows, and more with a free Docker Hub account:
 https://hub.docker.com

For more examples and ideas, visit:
 https://docs.docker.com/userguide/

ecstatic-poitras:~# cat /proc/cmdline
initrd=initrd showopts console=ttyS0,115200 nousb vga=0 root=/dev/vda ip=:::::eth0: boot=local
ecstatic-poitras:~# uname -a
Linux ecstatic-poitras 4.4.6-docker-6 #1 SMP Mon Apr 11 21:20:31 UTC 2016 x86_64 Linux

let me know if you need anything else 😊

Great thanks a lot !

echo "http://nl.alpinelinux.org/alpine/edge/community" >> /etc/apk/repositories
depmod -a
echo "cgroup  /sys/fs/cgroup  cgroup  defaults  0   0" >> /etc/fstab
mount /sys/fs/cgroup/
apk update
apk add docker
/etc/init.d/docker start

ERROR: docker needs service(s) cgroups
But if I am starting
/usr/bin/dockerd then no problem.

Thank you

same here.   ERROR: docker needs service(s) cgroups


vagrant up works but update_VM.sh rebuilds

Running update_VM.sh or ~/devel/SyneRBI_VM/scripts/UPDATE.sh,
rebuilds ITK, hence STIR, hence SIRF. We've seen that one before. It does seem to work ok without it though.
If necessary, after building a new VM, we could do this step manually until we figure out why it happens.

I wouldn't do this one now!


Compression levels?

What gzip compression level does this plugin operate at? I tried checking zlib's page for any information, but I'm not sure I found the right one.
If I'm going to be zipping files only once, I might as well gzip at level 9 for a few extra percentages in savings / decode effort.

Release 0.3  has been pushed to npm. Compression levels can be set via the gzip key in the options object . For example: compress({ gzip: { level: 6 }}).

Sorry about my tardiness.
As you can probably see from the comparision above, this definitely ended up being worth it for larger files. Thank you so much for your patience and time! I'll have to come back after a few months of learning JS better and see if I can help contribute to something else of yours.

Excellent! I am glad that it works. I try to test it, but without others confirming with their own setups, it’s hard to know whether things work fine.
You’re welcome to try again, although I am not sure I have that many projects to contribute to,


Improve the Usage Documentation

It's really common when requesting logs customers send the output of the .sh execution but tho the collect.tgz/collect.tar.gz depending on the version.
Creating this ISSUE to update do the Pull request improving the README.md to have some information on how to collect the logs.

Closing now that #27 is merged.


./bin/console usage flow

It is imposible to use ./bin/console before migration table is created.
https://github.com/shopware/platform/blob/master/src/Core/Kernel.php#L274
In some deployment flows it is impossible to run scripts or use container entrypoint and the only one way is to write and use console command.

Hello @bystro,
thank you for reporting this. A simple kernel boot should be possible without a database connection. I've create an issue in our issue tracker:
https://issues.shopware.com/issues/NEXT-5307
We're still collecting feedback for a production template. This is one of the issues we want to fix. If there are other issues that would make deployment easier, please report them :)
Best regards

We've published the production template a few days ago, that fixes this problem.
https://github.com/shopware/production/


Use global (reverse) package dependency graph to determine which packages need re-analysis

When startin up, the analysis service builds up a dependency graph
consisting of all packages in the database.  We track two different uses
of a package (as a direct or a dev dependency) via a special "dev/"
prefix.
The building of the initial dependency graph takes around 90 seconds
and consumes maybe around 20 MB.  Afterwards the dependency graph is
changed incrementally when new [PackageVersion]s are uploaded and is
used to answer the question of which packages need re-analysis.
Currently the implementation is a conservative estimate: We
say "A" needs re-analysis if a new [PackageVersion] of "B" is uploaded iff

any version of "A"'s pubspec.yaml file has "B" in the
dependencies/dev_dependencies section

any version of "A"'s pubspec.yaml file has "X" in the dependencies
section and "X" needs re-analysis if a new version of "B" is
uploaded

This conservative estimate gives a superset of the actual set of
packages affected.  The current algorithm can be improved by taking
constraints into account.  Namely prevent the fixpoint algorithm to
including packages which have constraint violations.
It would also be possible to add the flutter sdk as another node in the
graph.  This would then also allow re-analysis of packages on new
flutter versions.  (Though currently we pinpoint the flutter version, so
it would make no difference at all).
Together with
Create new Analysis only iff something changed
it should allow us to get rid of re-analyzing all packages every X days
and the GC of analysis datastore entities (though we might still keep it
for other reasons).

@isoos Haven't had enough time to test it out, but that would be a simple in-memory solution of triggering transitively dependent packages.
If we have more than 1 VM running analysis service we might want to find a way to avoid doing the re-analysis on all of them. One solution I was thinking of, is basically doing this computation (i.e. determine the set of packages which need re-analysis) on the VM which handles the upload of the package. Then it can use the "manual-trigger" mechanism to RPC call one analysis instance to handle it.
Let me know what you think about it.

Issue https://github.com/dart-lang/pub-dartlang-dart/issues/317

On a conceptual level this looks OK (I'll look into the code in a few hours), I'm just curious: was there any specific reason not using pana's output for this?

There's no specific reason, it's just much simpler to implement and doesn't need the pana results, so we could do that computation on package uploads (which trigger all transitively dependent packages). If we used pana results, then that might not be an option.

@kevmoo: I've updated the PR with a commit to fix the new Task() creation. Could you please approve/merge this? (I'll do the follow-up on my review comments.)

A bit busy right now, though I'll take another stab at this soon and try to move it to the uploading backend. So we notify the analysis service with the expanded list (this has the benefit of avoiding N different analysis VMs to do the same thing, since the uploading VM is uniq).

Please take another look, Istvan. This is as much as I would implement.

(Not sure what's wrong with the cla checker, all my accounts look good on https://cla.developers.google.com/)

Thanks for reviewing, @isoos !


Removed Controller from filename under folder controller and updated references to the files

Removed Controller inside Filename in controller folder
It was my first time Please tell me Why it is showing checks failed
Closes #280

Hi @K-ash-ish, thank you for making those changes.
Can we add a meaningful title to this PR please? "Required changes done" doesn't give us a good idea of what changes are you referring to>
Also, try to have helpful messages in your commits too. That helps to track down changes in future. Seeing 10 "changes done" doesn't tell you what the changes were.

Hi @K-ash-ish, thank you for making those changes.
Can we add a meaningful title to this PR please? "Required changes done" doesn't give us a good idea of what changes are you referring to>
Also, try to have helpful messages in your commits too. That helps to track down changes in future. Seeing 10 "changes done" doesn't tell you what the changes were.

Sorry for that I'm a beginner just starting my journey in contributing to OS I'll keep these things in mind from next time. Thank  You for your advice

@K-ash-ish It seems most of our tests are failing, indicating that the changes to the code may have some unintentional bugs, which we should investigate

When you changed the filenames, did you update the references to those files elsewhere in the code?

Ohh , I only changed the filenames under controller folder. I forgot that these files will be in use somewhere. I'll try to change them too.

@K-ash-ish Thank you for this PR!
We (Real Dev Squad) are a community of developers consisting on college students and working professionals. We communicate over Discord. You might want to join the community, you'll get A LOT to learn 😄
We have got projects like this repository which use simple HTML, CSS and vanilla JavaScript and also projects based on React, Ember and Vue for frontend and on Node for backend. Since we're open source, you can show your work which you do here to the interviewers as well 🎉
No matter what your expertise level is, we've always got something for everyone! ⚡
Invitation link: https://discord.gg/akgChXXF

@K-ash-ish Thank you for this PR!
We (Real Dev Squad) are a community of developers consisting on college students and working professionals. We communicate over Discord. You might want to join the community, you'll get A LOT to learn 😄
We have got projects like this repository. There are projects which use simple HTML, CSS and vanilla JavaScript and also projects based on React, Ember and Vue for frontend and on Node for backend (this project). Since we're open source, you can show your work which you do here to the interviewers as well 🎉
No matter what your expertise level is, we've always got something for everyone! ⚡
Invitation link: https://discord.gg/exqmZqn4

i'm currently a beginner learning languages trying to contribute to open source projects But will definitely join the channel as i'll be learning these things in future and it will be very helpful for me to be around you peoples  :smiley:

Looks good to me. Thanks for this one!
Congratulations on your first pull request in Real Dev Squad 🥳
THANK YOU this was my first ever commit :smiley: :smiley:


Idea - Scapegoat as a bot?

I continue to be impressed about the concept and execution of @scala-steward. It automates the boring stuff and serves remediations in an undoubtedly convenient way for the project maintainers.
How about we have an opt-in Scapegoat Bot patrolling opensource Scala projects?
The only problem I see is that while upgrading dependencies hardly ever spurs controversies (Scala Steward), some of our inspections might be seen as questionable (Scapegoat).
What we would need as well is some mechanism for fixes (scalafix?), not only for flagging suspicious code as we do now.

This is a great idea.
You could have a file in the repo like .scapegoat which enables specific
rules, and leaves everything disabled by default.
On Sun, 15 Mar 2020 at 12:23, Greg Oledzki<EMAIL_ADDRESS>wrote:

I continue to be impressed about the concept and execution of
@scala-steward https://github.com/scala-steward. It automates the
boring stuff and serves remediations in an undoubtedly convenient way for
the project maintainers.
How about we have an opt-in Scapegoat Bot patrolling opensource Scala
projects?
The only problem I see is that while upgrading dependencies hardly ever
spurs controversies (Scala Steward), some of our inspections might be seen
as questionable (Scapegoat).
What we would need as well is some mechanism for fixes (scalafix?), not
only for flagging suspicious code as we do now.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/sksamuel/scapegoat/issues/312, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAFVSGTDXDUUPSDA4RJ4XQLRHUFHRANCNFSM4LLGI3PA
.

I've been recently planning to implement a Scalastyle Github App which posts code issues back as inline PR comments (similar to the PR decoration feature which I implemented in sonar-scala here, but as a standalone Github App without the need for SonarQube.)
Scalastyle is a bit simpler to do because it doesn't need to compile your code, so it executes fairly quickly and you can easily run it on e.g. lambda on AWS for a fairly low cost even at a large scale. Scapegoat is a compiler plugin so the compilation stage makes it a bit more resource heavy + you need to execute it via sbt for each project, which adds a bit of security risk of potential arbitrary code execution that you need to protect yourself against - but it's definitely a great idea and it's definitely doable.

If we were able to run scapegoat standalone, without the need for the scala compiler, then we could do this. Briefly looking over the ruleset, we don't need access to much that isn't syntactic, only, VarClosure and UnreachableCatch.


Rename session in ConnectConfig (eg: HiveConfig)

Description
For a connector, its config comes from two sources

connector config file (Per connector)
QueryCtx (Per query)

the QueryCtx is the same as session property in presto so some time ago we named it as session, however we don't have concept of "session". Open this issue to brainstorm and decide on a better name for it.
Example functions:
HiveConfig::orcWriterMaxStripeSize(const Config* session)

Followup on https://github.com/facebookincubator/velox/issues/7659


Container Image Layer OS Scanner

What type of PR is this?
/kind feature
What this PR does / why we need it:
This PR adds the new scanner for image layers. This model will replace the previous layer scanner as it does a better job by looking at complete images instead of layer by layer.
Which issue(s) this PR fixes:
None
Special notes for your reviewer:
This PR adds a new package osinfo which houses two new objects: ContainerScanner and ImageScanner. These two check the whole image instead of trying to figure out layer by layer like the previous model did.

New container image layer scanner for checking inside of layers for OS data. The first version supports extracting packages from debian based OSs.

Thanks a lot Sascha! I think I've addressed your comments, PTAL @saschagrunert

/lgtm

Great work! Thank you @puerco!


BUGFIX: Need to have the JSONLogFile set for logs

CloudWatch logs configuration needs to have the JSONLogFile variable set
as it's being used later in the file.

:+1:


Feature request: Install new theme

Hi! Thank you for this tool. I found it very helpful.
I'd like it if base16-manager could use a template's YAML and mustache files to generate any missing themes. This would make new theme installation very easy.

Hi Hugo, thanks for showing interest in base16-manager!
I'm going to have to turn down this feature request as there are tools specifically built for this already. I don't feel like it should be base16-manager's responsibility to build new schemes for templates.


How to use webpack V5+ in yarn start

How to use webpack V5 in yarn start

Did you remove node_modules folder and re installing?

I have the same issue, I tried upgrading to v5.0.0 but I then got a JS out of memory exception. So I removed my package-lock.json and deleted the folder node_modules manually and I ran npm i from scratch. I am also now getting this same error, on npm run start on npm run build and on all CI/CD pipelines. Any ideas?

i have the same error

do you have node_modules out side the project folder?

Nope same level as src, public and where package.json is

What output do you get when running npm why webpack?

yarn why v1.22.17
[1/4] 🤔  Why do we have the module "webpack"...?
[2/4] 🚚  Initialising dependency graph...
[3/4] 🔍  Finding dependency...
[4/4] 🚡  Calculating file sizes...
=> Found<EMAIL_ADDRESS>info Reasons this module exists
   - "react-scripts" depends on it
   - Hoisted from "react-scripts#webpack"
info Disk size without dependencies: "3.57MB"
info Disk size with unique dependencies: "13.64MB"
info Disk size with transitive dependencies: "33.61MB"
info Number of shared dependencies: 140
=> Found<EMAIL_ADDRESS>info Reasons this module exists
   - "frappe-gantt-react#react-scripts" depends on it
   - Hoisted from "frappe-gantt-react#react-scripts#webpack"
info Disk size without dependencies: "10.34MB"
info Disk size with unique dependencies: "20.45MB"
info Disk size with transitive dependencies: "40.43MB"
info Number of shared dependencies: 141
✨  Done in 0.60s.

upgrade react-scripts to fix the issue