extract command

for debugging reaons it is sometimes required to extract the created .phar to see the contents of it.
would be great to have a command doing just that.
$phar = new Phar($pathToPhar);
$phar->extractTo($destPath);

Closed as out of scope as per #88


Git

Issue Type: Bug
After cloning a new git repository or moving to an old one, Source Control can't find a git repository in any of those folders.
VS Code version: Code 1.67.1 (da15b6fd3ef856477bf6f4fb29ba1b7af717770d, 2022-05-06T12:37:03.389Z)
OS version: Windows_NT x64 10.0.19044
Restricted Mode: No

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-9750H CPU @ 2.60GHz (12 x 2592)

GPU Status
2d_canvas: enabledcanvas_oop_rasterization: disabled_offdirect_rendering_display_compositor: disabled_off_okgpu_compositing: enabledmultiple_raster_threads: enabled_onoop_rasterization: enabledopengl: enabled_onrasterization: enabledraw_draw: disabled_off_okskia_renderer: enabled_onvideo_decode: enabledvideo_encode: enabledvulkan: disabled_offwebgl: enabledwebgl2: enabled

Load (avg)
undefined

Memory (System)
31.81GB (19.30GB free)

Process Argv
--crash-reporter-id de7acc89-0a2d-48b2-b20a-8c94f164ecce

Screen Reader
no

VM
0%

Extensions (47)

Extension
Author (truncated)
Version

better-comments
aar
3.0.0

vscode-apollo
apo
1.19.11

intellij-theme
arz
1.11.0

npm-intellisense
chr
1.4.1

path-intellisense
chr
2.8.0

vscode-eslint
dba
2.2.2

emoji-snippets
dev
1.5.3

gitlens
eam
12.0.6

EditorConfig
Edi
0.16.4

vscode-npm-script
eg2
0.3.25

prettier-vscode
esb
9.5.0

copilot
Git
1.20.5902

vscode-graphql
Gra
0.4.4

vscode-peacock
joh
4.0.1

mongodb-vscode
mon
0.9.3

azure-pipelines
ms-
1.205.0

vscode-azurefunctions
ms-
1.6.2

vscode-azureresourcegroups
ms-
0.4.0

vscode-docker
ms-
1.22.0

vscode-language-pack-es
MS-
1.67.3

csharp
ms-
1.24.4

vscode-kubernetes-tools
ms-
1.3.8

remote-containers
ms-
0.234.0

remote-ssh
ms-
0.80.0

remote-ssh-edit
ms-
0.80.0

remote-wsl
ms-
0.66.2

vscode-remote-extensionpack
ms-
0.21.0

azure-account
ms-
0.10.1

azurecli
ms-
0.5.0

powershell
ms-
2022.5.1

vsliveshare
ms-
1.0.5561

vsliveshare-audio
ms-
0.1.91

vsliveshare-pack
ms-
0.4.0

angular-console
nrw
17.16.0

vscode-versionlens
pfl
1.0.9

material-icon-theme
PKi
4.17.0

polacode
pnp
0.3.4

vscode-yaml
red
1.7.0

LiveServer
rit
5.7.5

trailing-spaces
sha
0.3.1

sonarlint-vscode
Son
3.4.1

addDocComments
ste
0.0.8

errorlens
use
3.4.2

highlight-matching-tag
vin
0.10.1

vscodeintellicode
Vis
1.2.21

vscode-todo-highlight
way
1.0.5

bracket-lens
wra
1.5.1

(2 theme extensions excluded)

A/B Experiments
vsliv368cf:30146710
vsreu685:30147344
python383cf:30185419
vspor879:30202332
vspor708:30202333
vspor363:30204092
pythonvspyl392:30443607
pythontb:30283811
pythonptprofiler:30281270
vshan820:30294714
vstes263:30335439
vscorecescf:30445987
pythondataviewer:30285071
vscod805:30301674
pythonvspyt200:30340761
binariesv615:30325510
bridge0708:30335490
bridge0723:30353136
vsaa593:30376534
vsc1dst:30438360
pythonvs932:30410667
wslgetstarted:30449410
pythonvsnew555:30457759
vscscmwlcmt:30465135
cppdebug:30475216
vsclangdf:30486550

After some research, I've found that behavior is probably related to an unsafe repository warning shown by the integrated terminal when I run "git status". Running the same command from the git bash works as expected without raising any exception.
Opening the project from the command line using "code ." works well but not when opening from the GUI.

@TheRivar, very interesting. Let me see if I understand things correctly:

Running git status from git bash returns the status information as expected
Running git status from the VS Code integrated terminal shows the unsafe repository warning
Opening the folder/workspace using code ., VS Code to detect the repository
Opening the folder/workspace from the GUI, VS Code does not detect the repository

Can confirm I am having the same issue, also getting the unsafe repository warning through the integrated Git Bash, unless opening Code from the command line, then Git Bash no longer reports it to be unsafe.
However then the source control tab fills up with infinite copies of the repository, as I scroll down more show up

@lszomoru that's just what's happening. You've described the scenario perfectly.
A folder/workspace opened from bash:

A folder/workspace opened from GUI:

Thank you all for all the information. I will take a look at this today and I will update the issue with my findings.

@TheRivar, @CourtneyAbraham, the latest Insiders release contains some improvements to the git extensions's logging which should help us get closer to the root cause. Could you please use the steps outlined in this wiki to enable Trace logging. After you have enabled logging, open the folder/workspace once from bash and once from the GUI and share the contents of the git output channel. Thank you!

I just launched the latest insiders release from the website and the issue no longer happens


Download section: use key fingerprint

Receive keys via fingerprint (please verify it). Short IDs are only 32-bit can thus be easily forged.

Hi @jodersky,
Thank you for your contribution! We really value the time you've taken to put this together.
Before we proceed with reviewing this pull request, please sign the Typesafe Contributors License Agreement:
http://www.lightbend.com/contribute/cla

LGTM


Moved CCS to use variables and added dark theme and theme toggle.

Created CSS Variables for the default light theme, and added a dark theme color scheme.

Updated most CSS to use new variables.

Added a theme handler JavaScript file to handle theme switching,

Theme selection gets saved in local storage.

Updated index.php to include the theme toggle button.
Added a simple file based register/login system

Uses a json file atm to store users/passwords
Added a rough login/register page
Moved header and footer to reusable partials
Adding a project is only allowed by authenticated users.

Wait, what? this is amazing!


Show/hide/enable/disable menu items based on context

Some menu items in both the context menu and the application menu should only be enabled when certain conditions are met, others should be hidden.
Examples:

Edit -> Copy should only be visible when some text is selected
History -> Back should only be enabled if it's possible to go back
History -> Forward should only be enabled if it's possible to go forward

Wow, thanks for all the contributions to vmd @maxkueng!

Thanks @Flet! I'm doing it because I'm having fun.


workflow.MutableSideEffect not deterministic if called multiple times with the same ID in the same WFT

This workflow
func MutableSideEffectWorkflow(ctx workflow.Context) error {
	i := 0
	encodedValue := workflow.MutableSideEffect(ctx, "id",
		func(ctx workflow.Context) interface{} { return i },
		func(a interface{}, b interface{}) bool {
			return a == b
		},
	)
	var sideEffectValue int
	err := encodedValue.Get(&sideEffectValue)
	if err != nil {
		return err
	}
	var future workflow.Future
	if sideEffectValue == 0 {
		ao := workflow.ActivityOptions{
			ScheduleToStartTimeout: time.Minute,
			StartToCloseTimeout:    time.Minute,
			HeartbeatTimeout:       time.Second * 20,
		}
		ctx = workflow.WithActivityOptions(ctx, ao)
		input := "hello"
		future = workflow.ExecuteActivity(ctx, helloworldActivity, input)
	}
	i += 1

	encodedValue = workflow.MutableSideEffect(ctx, "id",
		func(ctx workflow.Context) interface{} { return i },
		func(a interface{}, b interface{}) bool {
			return a == b
		},
	)
	err = encodedValue.Get(&sideEffectValue)
	if err != nil {
		return err
	}

	var output string
	err = future.Get(ctx, &output)
	if err != nil {
		return err
	}
	return nil
}

Is not deterministic because on the fist run sideEffectValue is equal to one 0 after the first MutableSideEffect and the activity starts. On replay sideEffectValue is equal to 1 and the activity is not launched. We don't document this limitation of mutable side effects and I believe it is a bug.
The problem is the Go SDK always uses the lastest value of a MutableSideEffect up to the current WFT for each ID so if MutableSideEffect returns a different value in the same WFT the last will be used on replay.
I found this while trying to fix workflow versioning in a loop, but @cretz also brought up this issue in his PR https://github.com/temporalio/sdk-go/pull/809

Question: What if two mutable side effects of the same ID are run during the same WFT? We don't differentiate by command, only by user-defined marker ID.

Version: 1.20.0
Platform: Mac M1

Looking at it more I don't believe this can be fixed without writing new information to the history. There is not enough information to distinguish when the MSE changed value on replay because only the nextCommandID is recorded and that if almost useless to tell them apart.
note: the fix in https://github.com/temporalio/sdk-go/pull/809 does not actually generate the commands on the correct MSE so it does not apply. It only makes the history work because we do not check payload.


Remove map origin restriction

Currently, the planner works only if the map origin is at [0,0,0]. Remove this restriction.

Hi there, is this problem fixed? or do you have any ideas how to fix it? I'm trying to use this algorithm as a local planner, so the map origin cannot be set at[0,0,0].

Hi,
unfortunately, this limitation still exists. I will contact the original developer to see if he'd be able to point you in the right direction.

Hi @RickeyLee09, seems that the [0,0,0] assumption is quite deeply rooted in the code. The best workaround at the moment would be to transform all poses before sending them to the planner and then to apply the inverse transform to the planner output.

Got it! Thank you for your advise, I will look into it recently, if it works i will let you know!
Sent from my iPhone

On Nov 25, 2019, at 23:42, Damjan Miklic<EMAIL_ADDRESS>wrote:

Hi @RickeyLee09, seems that the [0,0,0] assumption is quite deeply rooted in the code. The best workaround at the moment would be to transform all poses before sending them to the planner and then to apply the inverse transform to the planner output.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.


Unexpected behaviour in query builder: using where after and

I wrote this code and after it I spend an hour for detect a problem
    private TableQueryBuilder<Binding> getBindingsByTargetQuery(Binding.Type type, String target) {
        return db().BindingTable().query()
                .index(Binding.TYPE_TARGET_INDEX_NAME)
                .and("id.type").eq(type)
                .where("id.target").eq(target);
    }

The problem in where after and. This query will generate a filter WHERE id_target = "$my_target" without using id.type. This bug could be easy to get on copy-pasting.
It looks like this case should be uncompilable, or at least generate an exception.

Making where() and and() do the same thing would be the easiest possible fix. You can then write, e.g.
return db().bindings().query()
    .where("id.type").eq(type)
    .where("id.target").eq(target)
    .index(...)
    .limit(...)
    .find();

@lavrukov Potential easy fix (making where() and and() mean the same thing): https://github.com/ydb-platform/yoj-project/pull/62


Allow Fake ROM to work with production mode

Defines bit 30 in the dbg_manuf_service_reg to enable production mode for fake ROM
Overrides the ROM version to 0xFFFF in fake ROM

This is currently just a proposal. Plan to discuss with other workgroup members this week.

This was discussed in the FW Sync today with the agreement that this should be okay. Input still needed from @mhatrevi though since he wasn't able to join the meeting.

But this means somebody can by mistake use fake RoM in prod tape out?
Get Outlook for iOShttps://aka.ms/o0ukef

From: Vishal Mhatre @.>
Sent: Monday, March 11, 2024 6:23:26 AM
To: chipsalliance/caliptra-sw @.>
Cc: Vishal Soni @.>; Review requested @.>
Subject: Re: [chipsalliance/caliptra-sw] Allow Fake ROM to work with production mode (PR #1386)
@mhatrevi requested changes on this pull request.

In rom/dev/src/main.rshttps://github.com/chipsalliance/caliptra-sw/pull/1386#discussion_r1519710412:

@@ -95,9 +95,10 @@ pub extern "C" fn rom_entry() -> ! {
cprintln!("[state] LifecycleState = {}", _lifecyle);

 if cfg!(feature = "fake-rom")

   && env.soc_ifc.lifecycle() == caliptra_drivers::Lifecycle::Production

   && (env.soc_ifc.lifecycle() == caliptra_drivers::Lifecycle::Production)

What is the motivation for supporting the Production lifecycle mode for the fake ROM?
—
Reply to this email directly, view it on GitHubhttps://github.com/chipsalliance/caliptra-sw/pull/1386#pullrequestreview-1927814694, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AJPQBKZQGARN6B7WACKEKVDYXW455AVCNFSM6AAAAABEFZXQUOVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTSMRXHAYTINRZGQ.
You are receiving this because your review was requested.Message ID: @.***>

The motivation is just that more exhaustive testing in simulation was needed than I think we originally anticipated. This includes several test lines in production mode.
A lot would have to go wrong in someone's testing procedures for fake ROM to get close to a tape-out scenario. This does partially "lower the bar" for this one catch. However, you will still get the same error about using fake ROM in production mode if the bit in the debug register is not set. This way the user has to actually acknowledge what they are doing and explicitly allow it.
Some other things that would have to be skipped in testing to get the the Fake ROM to tape in include:

Never testing with real FMC/FW image (real image cannot boot with the Fake ROM)
Never tested with production fuse recipe (the real fuses would have production key hashes which would not match the fake image)
Never verified Cert contents (All certs up to FMC are canned, RT cert is never generated)
Never attempted certain DICE flows at Caliptra runtime FW (no private keys in key vault in fake ROM and FMC)


feat: auto import react component

Description
Add support for React Component as an option.
Linked Issues
#268
Additional context
No.

I'd prefer to keep this plugin framework-agnostic. I think including tsx and jsx by default sounds reasonable. We might use need the option named defaultExportByFilename to include default exports for your case.

I'd prefer to keep this plugin framework-agnostic. I think including tsx and jsx by default sounds reasonable. We might use need the option named defaultExportByFilename to include default exports for your case.

This sounds good, hope that it will be shipped soon.

You could push changes directly to this branch if you want to work on that

@antfu Hi, I have pushed for a while. Can u review and merge if it is ok?


Fix dynamic background color

Try to fix #14894

I'm not sure what should happen if the background function returns undefined again in the test code, btw.
If you want something like this;
--- test/browser/spec/ol/renderer/canvas/vectortilelayer.test.js
+++ test/browser/spec/ol/renderer/canvas/vectortilelayer.test.js
@@ -334,6 +334,7 @@ describe('ol/renderer/canvas/VectorTileLayer', function () {
           undefined,
           'rgba(255, 0, 0, 0.5)',
           'rgba(0, 0, 255, 0.5)',
+          undefined,
         ];

         expect(resolution).to.be(map.getView().getResolution());
@@ -349,6 +350,8 @@ describe('ol/renderer/canvas/VectorTileLayer', function () {
         expect(layer.getRenderer().container.style.backgroundColor).to.be(
           'rgba(0, 0, 255, 0.5)'
         );
+        map.renderSync();
+        expect(layer.getRenderer().container.style.backgroundColor).to.be('');
         done();
       });
     });

The patch would look like this;
--- src/ol/renderer/canvas/Layer.js
+++ src/ol/renderer/canvas/Layer.js
@@ -195,12 +195,8 @@ class CanvasLayerRenderer extends LayerRenderer {
       this.container = container;
       this.context = context;
     }
-    if (
-      !this.containerReused &&
-      backgroundColor &&
-      !this.container.style.backgroundColor
-    ) {
-      this.container.style.backgroundColor = backgroundColor;
+    if (!this.containerReused && this.container && this.container.style) {
+      this.container.style.backgroundColor = backgroundColor || null;
     }
   }

Thanks for your attempt to fix this, @kikuchan. The solution you chose changes the behavior in the case where multiple layers in the layer stack have a background configured. So I would suggest setting the style to null before the container is passed to the first layer renderer, and leave the rest of the code as it was before your changes.

Thank you for your reply!
How about this?

Thank you for the suggestion.
I had to change a test code because it used dummy container directly, and it failed with the change.

Thank you!


Add preprocessing TransposeExtractConcat pass

https://github.com/nod-ai/SHARK-Turbine/issues/683

Talked with Mahesh yesterday about this. Notes:

Must check that indexing maps are identity (like when there is a affine constant 0)

https://github.com/llvm/torch-mlir/pull/3483


DIR and LS behave differently

Steps to reproduce
Connect to a PS-Drive, like ENV:
Execute DIR
See a list of all the environmental variables.

Run the 'LS' command

Aww, it still shows the root of the drive
Expected behavior
LS and DIR should really do the same thing within PowerShell, as both are traditionally aliases of Get-ChildItem with the PoSH Shell.  However LS still operates in the original mode, which is weird.
Actual behavior
When running LS from a PS Drive like ENV:, it seems that LS is executed outside of PowerShell's directory context.
Checking here...

It seems LS isn't mapped as an alias as it normally is within PowerShell.
Environment data

> $PSVersionTable
![](http://i.imgur.com/RG2Brko.png)

All of the Linux aliases like ls are removed. So you are actually running the ls command and not an alias for Get-Childitem. This is an open issue that Microsoft will be pursuing with community input.

Please see known issues and #929. What we do about the conflicting aliases is a very open question, and we need the community's feedback!

I'm going to close this as a duplicate of #929. It is currently operating as intended; while the intention may or may not be what the community desires, further discussion should take place in that issue (as this is really much broader than just ls vs dir). Thanks for the feedback!


Lack of documentation on .spec.stop custom resource

.spec.stop custom resource is used in docs/chi-examples/99-clickhouseinstallation-max.yaml#11 example but it's not explained in docs: docs/custom_resource_explained.md
It's added in this commit: https://github.com/Altinity/clickhouse-operator/commit/7866c44721d20e651568e0f6f4a9b343f5714c3b
Do this parameter just says kubernetes not to stop pods and they will always be rescheduled even when pods are stopped manually?

This flag reduces number of replicas to 0 in all StatefulSets


TestCase: call _post_teardown always when _pre_setup worked

This is in line with unittest itself calling TearDown when SetUp
succeeded.
Ref/via: https://github.com/pytest-dev/pytest-django/issues/772

@felixxm
Please let me know if I should create a ticket for this.
Maybe a ref to (and comment at) https://code.djangoproject.com/ticket/27391 might be enough.

@blueyed thanks for looking into this. Can you please add more details on what this aims to address, and point us to the place in unittest where tearDown is called after debugged error?
It seems to me that tearDown is only called when no exception is triggered, whether with debug or not. Or, am I missing something?
While I do understand the pain of having a non-rolled-back Django DB after a failing/skipped test, I'm not sure I agree with this change.
Calling super().__call__(result) in a TestCase will enter the testPartExecutor contextmanager which catches SkipTest explicitly and handles other errors, thus muting exceptions. Only when we call super().debug() that we allow the exceptions to propagate; and, unittest itself catches nothing in TestCase.debug() as it aims to allow test runners to be the first to handle an exception (for easier postmortem?).
Shouldn't this be handled in the runner instead? If I understand the design in unittest, it's up to whoever is the user of the debug() function to call any teardown necessary for completing the run.
By the way, I'm not sure that unittest.TestCase implementation is necessarily the best, I guess a good solution would be to catch SkipTest in debug explicitly. Here's a CPython ticket that discusses debug not handling SkipTest: https://bugs.python.org/issue36674
References:

https://github.com/python/cpython/blob/master/Lib/unittest/case.py#L721-L728
https://github.com/python/cpython/blob/master/Lib/unittest/case.py#L662
https://github.com/python/cpython/blob/master/Lib/unittest/case.py#L56-L82

If I understand the design in unittest, it's up to whoever is the user of the debug() function to call any teardown necessary for completing the run.

Yes.
And Django appears to not call it itself, but only helps users calling it if I see this correctly(?).
Therefore it is not really needed/useful indeed, closing for now.
This resulted from when I've looked into issues with pytest-django, which only happen in the first place because pytest itself calls .debug() (if --pdb is used).  I think this should be fixed in pytest instead (https://github.com/pytest-dev/pytest/pull/5996).

Well, OTOH I've tried to mimic the behavior that TearDown gets called after SetUp always (in non-debug mode), which is not the case with _pre_setup and _post_teardown.
It explicitly raises (i.e. does not call it) for debug=True like unittest does.
Therefore re-opening - it was just driven by making Django behave like unittest in this regard.
I.e. the added test would fail, which means that _post_teardown is not called when you skip a test via a SkipTest exception - that certainly sounds wrong, doesn't it?

I.e. the added test would fail, which means that _post_teardown is not called when you skip a test via a SkipTest exception - that certainly sounds wrong, doesn't it?

The new test doesn't use debug mode and works without any changes, we probably want to call
result = _DebugResult()
test_suite.run(result, debug=True)

instead of test_suite.run(self.get_runner()._makeResult()) :thinking:.
It's strictly related with the previous fix, so we can use Refs #27391 -- ....

The new test doesn't use debug mode and works without any changes, we probably want to call

Oh, I must have missed this then - I've pretty sure to have checked that it failed without the patch - or isn't that what you've meant?

Yes, exactly test_suite.run(self.get_runner()._makeResult()) doesn't use debug mode, so it calls _post_teardown() without this patch. Extra tests are fine, but should be added in a separate commit.

Oh.. :confused: - pushed a fixup.

@blueyed Are you going to address these suggestions and questions?
Please add self.isolate_debug_test(test_suite, result) cleanup to your test to avoid isolation issues.

Closing due to inactivity.


Marker xtick position is not correct in twin axis

MWE:
fig = Figure()
ax1 = Axis(fig[1,1])
ax2 = Axis(fig[1,1], yticklabelcolor=:red, yaxisposition=:right)
hidespines!(ax2)
hidexdecorations!(ax2)
Makie.barplot!(ax1, [1,2,3,4,5,6,7,8,9,10], [10,20,30,40,50,50,50,50,50,50])
Makie.scatter!(ax2, [1,3,5,9], [10,20,30,40]; color=:red, marker=:x)

This is completely fine by superimposing the two plots on the same axis.
fig = Figure()
ax1 = Axis(fig[1,1])
Makie.barplot!(ax1, [1,2,3,4,5,6,7,8,9,10], [10,20,30,40,50,50,50,50,50,50])
Makie.scatter!(ax1, [1,3,5,9], [10,20,30,40]; color=:red, marker=:x)

Julia and package versions:
julia> versioninfo()
Julia Version 1.6.1
Commit 6aaedecc44 (2021-04-23 05:59 UTC)
Platform Info:
  OS: Linux (x86_64-pc-linux-gnu)
  CPU: Intel(R) Core(TM) i7-10510U CPU @ 1.80GHz
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-11.0.1 (ORCJIT, skylake)

(jl_SRdiRp) pkg> st
      Status `/tmp/jl_SRdiRp/Project.toml`
  [e9467ef8] GLMakie v0.4.4
  [ee78f7c6] Makie v0.15.0

Your two x axes just have different limits because the plotted data have different extrema. You need to do linkaxes!(ax1, ax2) if you want to layer them like this.


Update README.md

Community Contribution
Link to live project, video, or image:

Sharing

[ ] I would be happy to have my project shared on The Coding Train's social media!

Instagram:
Twitter:

Thanks for the suggestion but I don't think this is a productive change to the readme. If you disagree feel free to reopen the pull request for more discussion. If you're looking for a way to contribute to the site check out the community contributions guide.


Support running linter from CLI separately to build

Is your feature request related to a problem? Please describe.
When I create a CI/CD pipeline to work with my Bicep templates, I want to run linter rules and fail the build if there are any warnings or errors. Currently, the bicep build command executes the linter but shows linter warnings as outputs, and the exit code is 0, so it's not easy to pick up that linter rules failed. Additionally, bicep build emits a JSON template, which I don't need.
Describe the solution you'd like
Please provide a new bicep lint command, which will run the same linter rules as bicep build, but will return a meaningful exit code (perhaps 0 for no linter warnings, 1 for warnings, 2 for errors?) and that doesn't emit a JSON template.

@johndowns - would using bicepsettings.json to set all of the rules to error level meet your needs? The error build-time behavior will throw exit code of 1 and should cause the build to fail. bicepsettings.json can sit in source control alongside your templates and the CLI will automatically pick it up.

@MarcusFelling I don't think so. It's a workaround, but I don't think it's the optimal solution.
The key thing to me is that:

At development time, warnings might be something I ignore because I'm trying to get something done.
At release time (in my CI/CD process), I want to make sure the warnings are treated as errors and fail the build. This is the last chance to catch issues before they potentially hit production.

So to me, it'd be better if I could have a bicep lint command that fails with any linter violations (except those I've disabled). Alternatively, maybe there could be a new bicep build --treat-warnings-as-errors switch that would do the same thing.

@johndowns - does this ask apply purely to linter warnings, or are you looking for any warnings to be treated as errors? For example, the following is a core compiler warning (not a linter warning):

@anthony-c-martin In principle it'd be good to apply it to all warnings, but my concern is that there are still some situations where RPs haven't properly documented their schemas, and so compiler warnings will appear that I have no control over. If the any() function could be used as an escape hatch for all situations, or if there was another way of telling Bicep to ignore a specific warning for a specific line/resource, then I'd be in favour of that. But as of today, I think separating out the linter results would be a better approach.

I came here because I was looking for this exact thing. Having a bicep lint command that potentially could also output the warnings/errors as json would also be beneficial.

Any plans of this feature, thought it would be a handy one.

We agree it would be a useful command to add, but don't have the time to implement it ourselves. It would be great if someone could make an external contribution for this one.


opsgenie: Moved from deprecated, non documented teams to responders field.

Fixes: https://github.com/prometheus/alertmanager/issues/1818
Some decisions I made:

"Teams" config option will fail on unmarshalling the config. I marked it as deprecated. AM is 0.x version it should be fine (?)
I allow the use case for dynamic set of responders from alert's label using templating. Seems like it fits into how others fields are treated.
I allow for full flexibility, so you can use any type you want. There is no validation. I don't think it is worth as Opsgenie changes those things (?). Let me know if it's needed. I think if the type is wrong and create alert will fail it's fine as "validation"

Signed-off-by: Bartek Plotka<EMAIL_ADDRESS>

Will fix tests tomorrow.

Tests should be fixed.

Thanks for initial review @simonpasquier , PTAL

@bwplotka you would need to resolve the conflicts...

done (:

Is this build flake? After changelog rebase suddnely tests are red

Yes, it looks like a flake, I've re-run the workflow.

A question, if you would be so kind. Will the yml configuration file still work with alertmanager 0.18.0  if teams are set up according to https://prometheus.io/docs/alerting/configuration/#opsgenie_config ?
# Comma separated list of team responsible for notifications.
[ teams: <tmpl_string> ]

or should it be changed to something like:
responders:
     name: <tmpl_string>
     type: team

?

@hrancic the documentation should be updated (and fixed) in a few minutes.

Another question. Our current configurations look something like this:
teams: <tmpl_string>
these templates (which have some conditional logic) are creating a comma separated lists of teams. We would like to upgrade our alertmanager version. How do you propose we migrate to the new version?

@hrancic do you mean how to specify multiple teams?
responders:
- name: "teamA"
  type: team
- name: "teamB"
  type: team
- name: "teamC"
  type: team
(...)

yes, but writing them one by one is out of the question. Will responders: <tmpl_string> work? Where this template creates:
- name: "teamA"
  type: team
- name: "teamB"
  type: team
- name: "teamC"
  type: team
(...)

yes, but writing them one by one is out of the question

Why?

Will responders: <tmpl_string> work?

It will not work in current version. (:

We don't know who responders are before the alert is created. We create an alert and then decide its destination while sending it. teams: <tmpl_string> was a model which enabled us to determine the teams after the alert is fired but before sending it to opsgenie. We would like to have something like this:
responders:
 - names : <tmpl_string>
   type: teams

From my side that is a fair request. Do you mind adding an Github issue with those details on AM? We can improve this indeed. (:

@hrancic Was an issue filed?


CLI comamnd for UpdateActivityOptions API

What was changed

Add update-options to the CLI
(note - I closed previous PR for main)
Why?

To support UpdateActivity API
Checklist

Closes

How was this tested:

Add tests.

Any docs updates needed?

Yes, but not in this PR.

I want to move forward, I waited a day, if there is something I will fix in the follow up PR.


link to docker hub image not correct

it seems it should be https://hub.docker.com/r/a5huynh/oauth2_proxy/ instead of the current link

Thanks @Freundschaft! Docker Hub must've changed their URL scheme, I'll push a fix

Thanks!


Use $ctrl in test generator

Closes #117

Current coverage is 96.01% (diff: 100%)

Merging #122 into master will not change coverage

@@             master       #122   diff @@
==========================================
  Files            72         72
  Lines          1029       1029
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
  Hits            988        988
  Misses           41         41
  Partials          0          0

Powered by Codecov. Last update b42901c...2da8572


pyfits deprecated

pyfits is deprectqed, we should at some point move to astropy. A backwards compatible function exists and can be used via:
from astropy.io import fits as pyfits

Resolved in commit 5e062d0795737a35604c41eef97ba5b17d79b4de


Can't open new window on separate desktop (macOS) if there are windows on other desktops

VSCode Version: 1.29.1 and 1.30.0-insider
OS Version: macOS 10.14 (18A391)

Steps to Reproduce:

Open VSCode in Desktop 1
Move to Desktop 2
"New Window (Cmd+Shift+N)" won't work
Right click the icon in the Dock -> "New Window" will instead work

Gif showing the bug: https://duaw26jehqd4r.cloudfront.net/items/1V0c0V0k3w3d313a2b1m/Screen Recording 2018-11-29 at 01.29 AM.gif

Does this issue occur when all extensions are disabled?: Yes

The problem described in #35240 is similar but not the same (in that case it focuses on the existing virtual desktop).

I wonder if this is the same thing as something I've been seeing:

Run VS.code.
Create a window.
Minimise to the dock (with the yellow traffic-light icon in the window).
Press Shift-Cmd-N to create another new window.

EXPECTED: The new window appears.
ACTUAL: Nothing happens.

Yep, can confirm that happens too. Probably related. Thanks!

As a workaround I created an Automator application called "VSCode New Window" that runs a "Shell Script" (one of the available actions in Automator) with the command /usr/bin/local/code -n.

Still an issue on VSCode 1.34.0 / macOS 10.14.4.
Besides "New File", it cannot "Open...", "Open Workspace...", etc. "Open Recent..." opens a window but it will jump to another space, which is not desirable.

Still an issue on VSCode 1.35.1 / macOS 10.14.5

Still an issue on VSCode 1.42.0 / macOS 10.15.3

Still an issue on VSCode 1.43.2 / macOS 10.15

Still an issue on VSCode 1.44 / macOS 10.15.4

Still an issue on
Version: 1.47.0-insider
Commit: 9bf6af04dcb5c2e531cedca83cd188939ca1b0db
Date: 2020-06-26T21:11:02.609Z
Electron: 8.3.3
Chrome: 80.0.3987.165
Node.js: 12.13.0
V8: 8.0.426.27-electron.0
OS: Darwin x64 19.5.0

Why was this closed?  I think people are commenting and replying to this issue (for years) to explicitly let the team that this hasn't been fixed.  Or possibly people have been replying so it doesn't get lost or be assumed to be fixed with Mac updates, library updates or other passive luck.
Is it a wontfix or just too mysterious, related to Electron or some other fundamental technology that it has become cantfix?

I think it's been closed because it's been fixed. This commit was merged to master early today https://github.com/microsoft/vscode/commit/6dc0327c9af20d0dfe7112feed7c4f75d32b0e83 🎉🎉🙏 Thank you team!

The unreleased tag should be updated when the fix ships in insiders in the coming days.

I think it's been closed because it's been fixed. This commit was merged to master early today 6dc0327 🎉🎉🙏 Thank you team!

Oh, I see!  I missed the SHA/commit.  Sorry.  🙂


macOS Mojave

Hi great work with all you've done! I tried out macOs Mojave and I noticed that this doesn't work on that, it would be awesome if you could update the software to fix those kind of bugs. Also Apple came out with screensavers from the ISS will those be included? Thanks!!

Dupcalite of #464


[Bug] Component entry point does not exist

Hi. In a package.json file lib/nuxt-property-decorator.umd is referenced as the main entry point but there is no such file in the repo. When nuxt-property-decorator is used as a dependency it brakes build process with an error:
ERROR Failed to compile with 2 errors12:32:38
This dependency was not found:
nuxt-property-decorator in ./node_modules/ts-loader?{"appendTsSuffixTo":[{}]}!./node_modules/vue-loader/lib/selector.js?type=script&index=0!./components/Card.vue, ./node_modules/ts-loader?{"appendTsSuffixTo":[{}]}!./node_modules/vue-loader/lib/selector.js?type=script&index=0!./pages/index.vue
To install it, you can run: npm install --save nuxt-property-decorator
https://github.com/nuxt-community/typescript-template/issues/44

@AndrewBogdanovTSS I pushed a fix via pull request, hopefully @DavidBernal will merge & publish to npm

Fixed and npm module updated


Fix in-context reporting tests

Description
When checking for a reporting download being triggered, the tests are waiting for a loading screen. This causes test failures if the download happens faster than React renders. In one test run, the test failed when the API returned in 18 ms (whereas a passing test in the same run had a return time of 224 ms). This PR updates the tests to instead check for the success toast.
Issues Resolved
N/A
Check List

[X] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Will also need to forward-port to 2.x and main, starting here since FTR is failing in RC generation.


Discuss Crypto Library Usage

This issue is intended to foster discussion on different crypto libraries used. The pros and cons of working with each one.
Three popular crypto libraries are scrypt, bcrypt, and bcryptjs. bcrypt is a binary blob, compiled and included as a dependency. As a result, it breaks between versions of nodejs because it must be compiled for a specific version. bcryptjs is a javascript native, drop-in replacement for bcrypt.
BITBOX apparently uses scrypt, and this message popped up in the Discord chatroom:
Got this error.The package at "node_modules/scryptsy/lib/scrypt.js" attempted to import the Node standard library module "crypto".It failed because React Native does not include the Node standard library.

We need to polyfill our Crypto class w/ crypto-browserify. I have it working for all the methods other than hash160

BITBOX's Crypto Class has been refactored to use Bitcoincashjs-lib's Crypto class so this isssue is no longer valid.


Operator Hub out of date

Howdy! It looks like the operator bits in Operator Hub are out of date, as attempting to install from there will result in the a Forbidden error when accessing argocds/status. Looks like you just added this and it just hasn't been bubbled up yet?

@RichiCoder1 Thanks for trying the operator. I am working through getting the PR merged to update to the latest operator version. I will update this issue when it is available on Operator Hub.


feat: Support batch data acquisition

:tada: This PR is included in version 1.0.0 :tada:
The release is available on npm package (@latest dist-tag)
Your semantic-release bot :package::rocket:


[Bug] <All ID(or maybe more) ZippyShareScarpingExt>: getting video link failed

PLEASE READ THIS

Device information

Tachiyomi version:  v<IP_ADDRESS>
Android version: 11

Source information

Name: All Zippyshare scraping Extenstion(tested on otakudesu,oploverz,neonime)
Extension version: OD7,OL7,NN2

Steps to reproduce

Use extensions from list above
Try watch something

Expected behavior
Episode link getted from the zippyshare link
Actual behavior
Episode failed to get video link
note : because oploverz have 2 sources, probably only the google that showed
Other details
Sus part
looking at the zippyshare html script tag
    var n = 911786%2;
    var b = 911786%3;
    var z = 911789;
    document.getElementById('dlbutton').href = "/d/jWUcqz5U/"+(n + b + z - 3)+"/Otakudesu.vip_SnNY--11_360p.mp4";
    if (document.getElementById('fimage')) {
        document.getElementById('fimage').href = "/i/jWUcqz5U/"+(n + b + z - 3)+"/Otakudesu.vip_SnNY--11_360p.mp4";
    }

and the code that uses to scrape it,
        val res = client.newCall(GET(element.attr("href"))).execute().asJsoup()
        val scr = res.select("script:containsData(dlbutton)").html()
        var url = element.attr("href").substringBefore("/v/")
        val firstString = scr.substringAfter(" = \"").substringBefore("\" + ")
        val num1 = scr.substringAfter("+ (").substringBefore(" % ").toInt()
        val num2 = scr.substringAfter(" % ").substringBefore(" + ").toInt()
        val num4 = scr.substringAfter(" % ").substringBefore(") + ").substringAfter(" % ").toInt()
        val lastString = scr.substringAfter(") + \"").substringBefore("\";")
        val num = (num1 % num2) + (num1 % num4)
        url += firstString + num.toString() + lastString
        val quality = with(url) {
            when {
                contains("1080p") -> "1080p"
                contains("720p") -> "720p"
                contains("480p") -> "480p"
                contains("360p") -> "360p"
                else -> "Default"
            }
        }

i think the the calculation part is changed to variable ?

another simple way to fix it is just spawn request, wait for like 3 seconds and scrape the dlbutton href 👍

check this

But not only od that use zippyshare though.. i guess im do it, anyways thank you for the snippet

oh yea, fixed in #199 #201


frequency_id -- add '1hr'

Please add a frequncy entry for hourly data. In the data request I am currently using '1hr' for hourly data.

@martinjuckes is there a new table_id 1hr that goes with this? It seems we don't have such an entry in miptable 01.beta.45


Documentation should use self.title= in example

The title= method must have an explicit receiver. The example in the documentation should read:
class SomeScreen def on_load # This sets this instance's title self.title = " Something else " end end

:+1:
We need Austin Seraphin in our list of contributors. :-) Pull request?


Substrait crate fails to build on Windows in dependent project

We have added Substrait support to DataFusion now but cannot add it to the project workspace (see https://github.com/apache/arrow-datafusion/pull/4893) because Windows builds are failing due to a protoc error when building Substrait.
error: failed to run custom build command for `substrait v0.2.0`

Caused by:
  process didn't exit successfully: `D:\a\arrow-datafusion\arrow-datafusion\target\debug\build\substrait-a6509fbb99b47d6b\build-script-build` (exit code: 1)
  --- stdout
  cargo:rerun-if-env-changed=FORCE_REBUILD

  --- stderr
  Error: "protobuf compilation failed: protoc failed: Missing input file.\r\n"

Can you check if it also fails to build with the latest release (0.3.0)?

Can you check if it also fails to build with the latest release (0.3.0)?

Thanks. Yes, upgrading to 0.3 fixed it :tada:


[ZEPPELIN-1359] Commit correctly ordered karma.conf file

What is this PR for?
In the karma-conf.js file, dependencies are usually alphabetically ordered.
On a clean repo build, the file is changed to be alphabetically order those dependencies.
SInce one of those is not in the right order, it creates a modified file in the repository after build.
This PR is simply re-ordering the file so that there is no modifications on build.
What type of PR is it?
Bug Fix
What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-1359
How should this be tested?
Build the source code from a clean repo, there shouldn't be any file changed if you type git status
Questions:

Does the licenses files need update? No
Is there breaking changes for older versions? No
Does this needs documentation? No

LGTM 👍

Merging it fast since it doesn't bring any real code change


errors.errorString groups errors with different messages together

We are using errors.New(string) to generate dynamic errors from an external API. This API returns several errors codes in the body of the response.
Right now sentry groups all these errors into one, even when the messages are different. Is this the expected behavior?. And if it is, what suggestions do you guys have to handle errors in this case?

This is a big deal for me also.


V1.3b modify findfriend

Summary of changes made

Split user input for findfriend into keywords for Name, Tag, and Log Title
Renamed predicate from NameContainsKeywordPredicate to FriendFilterPredicate for better understanding.
Changed the parameters of the predicate constructor so that the checks for Name, Tag, and Log Title can be split
Created a new class FriendFilterPredicateBuilder in testutil for testing purposes.
Added test cases accordingly, and modified some due to the change in parameters for FriendFilterPredicateBuilder

fixes
#159

Codecov Report

Merging #176 (b0130fb) into master (70263b5) will decrease coverage by 0.04%.
The diff coverage is 82.50%.

@@             Coverage Diff              @@
##             master     #176      +/-   ##
============================================
- Coverage     73.40%   73.35%   -0.05%
- Complexity      752      759       +7
============================================
  Files           109      109
  Lines          2557     2586      +29
  Branches        380      388       +8
============================================
+ Hits           1877     1897      +20
- Misses          534      538       +4
- Partials        146      151       +5

Impacted Files
Coverage Δ

.../seedu/address/logic/parser/FindCommandParser.java
75.00% <72.72%> (-25.00%)
:arrow_down:

...du/address/model/person/FriendFilterPredicate.java
81.81% <81.81%> (ø)

...java/seedu/address/logic/commands/FindCommand.java
100.00% <100.00%> (ø)

...in/java/seedu/address/logic/parser/ParserUtil.java
98.63% <100.00%> (+0.12%)
:arrow_up:

src/main/java/seedu/address/ui/CommandBox.java
0.00% <0.00%> (ø)

...a/seedu/address/model/person/UniquePersonList.java
93.33% <0.00%> (+0.65%)
:arrow_up:

...ava/seedu/address/model/event/UniqueEventList.java
62.74% <0.00%> (+3.17%)
:arrow_up:

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more


Allow custom media to reference each other

The final missing piece. :)
Any plan on settling the option name? I plan to submit the extract pr once it's resolved.

looks good.
I will go for "computed-definitions" for the name.

Please remove the unused fixtures and rebase on master so I can merge.

You should be able to merge this PR directly. Let me know if anything conflicts.

PTAL

Nice.

Released as 4.1.0

Thanks. I will send the cssnext PR soon.

This PR fixes #9.


tty,unix: avoid affecting controlling TTY

Since this re-open logic is supposed to be transparent to the parent
program, this flag helps ensure that there are no unintended
side-effects. This flag is already the default (and only possible
option) on FreeBSD. Normally, Linux will also act as if you passed
NOCTTY. However, it appears that mac OS sometimes strips the parent
process of its controlling terminal if you don't pass this flag.
See discussion in https://github.com/libuv/libuv/issues/973
Fixes: https://github.com/JuliaLang/julia/issues/16398

Because I'm more than a little curious as to whether this causes regressions...
libuv CI: https://ci.nodejs.org/job/libuv-test-commit/1703/
libuv+node CI: https://ci.nodejs.org/view/libuv/job/libuv-in-node/119/ (of interest: the pty tests)

The Node CI was green, and the libuv CI seemed fine, so I landed this in https://github.com/libuv/libuv/commit/1399d851b112ad8376ef2a46303e72fd55125439. Thanks!


user-status: Replace "Unavailable" status with "Invisible" mode.

Replaces the current 'unavailable' status with the 'invisible' privacy mode.
Relevant CZO conversation
Fixes #21178.

Changes:

The first 3 commits are preparatory changes with no functional changes.
The 4th through 10th commits do the backend / server updates to make the current client implementations of user status away a deprecated way to access a user's presence_enabled setting.

The 5th commit is a migration that updates users with UserStatus.status=AWAY to have their presence_enabled setting set to False.
The 7th commit is an update to the web app frontend code so that we don't break the current implementation. This is unique to the web app because there is a way to directly update/change the presence_enabled setting.
The 9th commit is a migration to delete the UserStatus.status field from the model.

The 11th and 12th commits are the frontend and documentation changes to replace the 'unavailable' status with 'invisible' mode.

Notes/Questions:

Both migrations were pretty straightforward, so I didn't write a migration test for either of them.
All commits should pass CI individually, though I only directly ran the backend test suite for the backend commits and the frontend test suite for the frontend commits.
The import / export test in the backend code was impacted by these changes. That all made sense because UserPresence and UserStatus models now have some overlap with the deprecated access to the presence_enabled setting updates. But I wasn't sure if there were other concerns I might not be aware of with the impact of these changes on importing and exporting realm or user data.
The API documentation updates definitely need a revision / edit pass.
For coordinating the changes for #M5445, I believe just changing the circle icon used for the 'unavailable' status in the mobile app to what's used for being offline, would be enough to align with the documentation changes in the final commit.

Screenshots and screen captures:

API documentation updates
Changelog

Update status endpoint parameter

Register queue

Get events

Help center updates
Current documentation

Screencast of invisible mode
Screencast from 22-09-22 17:32:58.webm

Self-review checklist

[x] Self-reviewed the changes for clarity and maintainability
(variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

[x] Explains differences from previous plans (e.g., issue description).
[x] Highlights technical choices and bugs encountered.
[x] Calls out remaining decisions and concerns.
[x] Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

[x] Each commit is a coherent idea.
[x] Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

[x] Visual appearance of the changes.
[x] Responsiveness and internationalization.
[x] Strings and tooltips.
[x] End-to-end functionality of buttons, interactions and flows.
[x] Corner cases, error conditions, and easily imagined bugs.

We should add the deprecated: true tag to the away field in the API docs; I think we enforce that the word Deprecated appears in the description when using it.

I believe I've completed a full review of this, and the implementation looks solid; posted a handful of comments on minor details. @alya I think you should be good to do a review including finalization of strings/documentation for the change.

Nice! A few tweaks after playing with the PR:

Let's change the profile menu options "Turn on invisible mode" -> "Go invisible". The option to go back can stay as-is.
Let's change the "Display my availability to other users when online" option to "Display my availability to other users (invisible mode off)", and move it to be the last option in the Privacy section.

I left a bunch of comments on the documentation page, but overall looking close!

Updates:

All comments from @timabbott 's review have been updated / addressed. I don't have screenshots of the new API documentation ready to post here, but will post those when I have a chance.
Most of @alya's notes / updates have been implemented, except for the updates for the instructions on toggling invisible mode (see the screenshots in this comment and this comment).

Replied above -- thanks!

The remaining changes seem small enough that I can just make them during a final review; doing so now.

This is great, made the following changes and then I've marked this to merge once CI finishes:
diff --git a/static/js/settings.js b/static/js/settings.js
index 656c7060ca..fd28ba1ec2 100644
--- a/static/js/settings.js
+++ b/static/js/settings.js
@@ -45,16 +45,16 @@ function setup_settings_label() {
     settings_label = {
         // settings_notification
         presence_enabled: $t({
-            defaultMessage: "Display my availability to other users. (invisible mode off)",
+            defaultMessage: "Display my availability to other users (invisible mode off)",
         }),
         send_stream_typing_notifications: $t({
-            defaultMessage: "Let subscribers see when I'm typing messages in streams.",
+            defaultMessage: "Let subscribers see when I'm typing messages in streams",
         }),
         send_private_typing_notifications: $t({
-            defaultMessage: "Let recipients see when I'm typing private messages.",
+            defaultMessage: "Let recipients see when I'm typing private messages",
         }),
         send_read_receipts: $t({
-            defaultMessage: "Let others see when I've read messages.",
+            defaultMessage: "Let others see when I've read messages",
         }),

         ...settings_config.notification_settings_labels,
diff --git a/static/js/settings_config.ts b/static/js/settings_config.ts
index 6c97bca9a7..e9207679d6 100644
--- a/static/js/settings_config.ts
+++ b/static/js/settings_config.ts
@@ -512,7 +512,7 @@ export const display_settings_labels = {
     display_emoji_reaction_users: new Handlebars.SafeString(
         $t_html({
             defaultMessage:
-                "Display names of reacting users when few users have reacted to a message.",
+                "Display names of reacting users when few users have reacted to a message",
         }),
     ),
     escape_navigates_to_default_view: $t({defaultMessage: "Escape key navigates to default view"}),
@@ -554,7 +554,9 @@ export const realm_user_settings_defaults_labels = {
     }),
     enable_digest_emails: $t({defaultMessage: "Send digest emails when user is away"}),

-    realm_presence_enabled: $t({defaultMessage: "Display availability to other users when online"}),
+    realm_presence_enabled: $t({
+        defaultMessage: "Display availability to other users (invisible mode off)",
+    }),
     realm_enter_sends: $t({defaultMessage: "Enter sends when composing a message"}),
     realm_send_read_receipts: $t({defaultMessage: "Allow other users to view read receipts"}),
 };
diff --git a/templates/zerver/help/status-and-availability.md b/templates/zerver/help/status-and-availability.md
index 8ac1b19f47..422709bc96 100644
--- a/templates/zerver/help/status-and-availability.md
+++ b/templates/zerver/help/status-and-availability.md
@@ -90,9 +90,9 @@ the UI will be frozen as the approximate time you enabled this setting.

 {!self-user-actions-menu.md!}

-1. To enable, you'll see and select **Go invisible**.
+1. To enable, you'll select **Go invisible**.

-1. To disable, you'll see and select **Turn off invisible mode**.
+1. To disable, you'll select **Turn off invisible mode**.

 !!! tip ""

There's one outstanding issue, which is that we'd ideally like the settings label to have (invisible mode off) be (<i>invisible mode off</i>). We did this previously for a read receipts setting in a messy way, by duplicating the settings_checkbox template; maybe it's worth doing the investment to extend settings_checkbox with an option to have a particular element allow using t_html, or some other reasonable approach that would permit doing this without said copying?
@sahil839 can you take care of that follow-up?

Opened #23042.


How to create handler Push notifications

How to create?
Same as https://github.com/mgp25/Instagram-API

No available for not. We need to implement mqtt protocol and we need to reverse it first.

@IvanMMM Is it ready now?


Improve the UX of waiting for a lock to open a session or transaction

Problem to Solve
Currently, if a user (say, a database admin) keeps a schema session open for a few minutes to perform some maintenance, any other client attempting to connect to the database and write some data will just stall indefinitely.
Current Workaround
Complain to the Grakn team asking why the client is stalling
Proposed Solution
Complain to the DB admin asking why they're taking so long.
But seriously- we could improve the UX of the client by adding an acquire-lock timeout - say 10 seconds; if the lock is still not available after 10 seconds, we throw an exception on the server that gets propagated back to the client.
That way the client will know that the server is busy doing something else. We could even be explicit and say that this is most likely caused by an open schema session (or data write transaction).
In the future we'll have an admin interface or maybe even a "force open" option that kills all conflicting sessions/transactions immediately.

This issue will be resolved by implementing both of the following issues:

https://github.com/graknlabs/grakn/issues/6065
https://github.com/graknlabs/client-java/issues/242

This issue will be resolved by implementing both of the following issues:

https://github.com/graknlabs/grakn/issues/6065
https://github.com/graknlabs/client-java/issues/242


Add link to reference docs in README

Hi there!
My name is Leo, a CS student at Brown building an automated platform for editable codebase documentation.
I generated documentation for this repository and placed a link in the README. Please feel free to try it out and let me know what you think!

Hi @Leo-Ryu, thanks for your contribution! I took a look at it and overall, it seems fine, it would be good if you could remove all the references to the test functions

@imwiwiim90, is it possible to have admin permissions over this repo?

@andfoy  Awesome! References to the test functions have been removed


[ZEPPELIN-1874] fix: sparkR doens't render output properly

What is this PR for?
Zeppelin sparkr only shows first element of all outputs due to invalid implementation
// https://github.com/apache/zeppelin/blob/master/spark/src/main/scala/org/apache/zeppelin/spark/ZeppelinRDisplay.scala#L71

private def textDisplay(body: Element): RDisplay = {
  // we are extracting only the first element. it shouldn't
  RDisplay(body.getElementsByTag("p").first().html(), TEXT, SUCCESS)
}

FYI
SparkR interpreter sends message which containing multiple whitespaces, newlines. But zeppelin frontend breaks the space characters. This should be handled by other issue (ZEPPELIN-1914). As you can see the screenshot below, the paragraph result sent from websocket keeps consequent whitespaces and newlines until rendering.

What type of PR is it?
[Bug Fix]
Todos
N/A
What is the Jira issue?
ZEPPELIN-1874
How should this be tested?

Build Zeppelin with Spark 2.0+, R, sparkR
Execute this paragraph

%spark.r
mtcarsDF <- createDataFrame(mtcars)
model <- glm(vs ~ mpg + disp + hp + wt , data = mtcarsDF, family = "binomial")
summary(model)

Check you can get all result.

Deviance Residuals:
(Note: These are approximate quantiles with relative error <= 0.01)
Min 1Q Median 3Q Max
-2.11025 -0.08567 -0.00069 0.13214 1.10483
Coefficients:
Estimate Std. Error t value Pr(>|t|)
(Intercept) -23.623 23.144 -1.0207 0.30739
mpg 0.78475 0.65026 1.2068 0.2275
disp -0.031549 0.027342 -1.1539 0.24854
hp -0.072188 0.045509 -1.5862 0.11269
wt 7.335 5.2336 1.4015 0.16105
(Dispersion parameter for binomial family taken to be 1)
Null deviance: 43.860 on 31 degrees of freedom
Residual deviance: 12.873 on 27 degrees of freedom
AIC: 22.87
Number of Fisher Scoring iterations: 9

Screenshots (if appropriate)
Buggy (doesn't show full result)

Questions:

Does the licenses files need update? - NO
Is there breaking changes for older versions? - NO
Does this needs documentation? - NO

Tested and LGTM

  ZeppelinSparkClusterTest.sparkRTest:186 expected:<[[1] 3]> but was:<[

The above test is failing. I will take a look into.

LGTM

Merge to master if no more comments


Online not working

I set up the thing (even had help from a friend that has done it before) and whenever i try join someones lobby it doesn't let me. When i created my own, it didn't let anybody join me. Please can you fix this issue, i would appreciate it a lot.

yeah,  me too


Add bootloader name tag

This was low-hanging fruit, since the tag has a simple structure and the payload is specified to be valid UTF-8.

Looks great, thanks a lot!


Could not resolve a service of type 'IMyService' for the parameter 'mySvc' of method 'Configure' on type 'Startup'

I am moving my project from asp.net5 beta 4 to beta 5.
Below is an example of ConfigureServices method in Startup.cs
 public void ConfigureServices(IServiceCollection services)
 {
    services.AddTransient<IMyService, MyService>();
 }

And this is Configure method in Startup.cs
 public void Configure(IApplicationBuilder app, IHostingEnvironment env, ILoggerFactory loggerFactory, MyService mySvc)
 {

 }

In beta 4 dependency injection used to work okay and I could use myService in side Configure method.
Now i am getting an error:
 Could not resolve a service of type 'IMyService' for the parameter 'mySvc' of method 'Configure' on type 'Startup

at Microsoft.AspNet.Hosting.Startup.ConfigureBuilder.Invoke(Object instance, IApplicationBuilder builder)
at Microsoft.AspNet.Hosting.Startup.ConfigureBuilder.<>c__DisplayClass4_0.<Build>b__0(IApplicationBuilder builder)
at Microsoft.AspNet.Hosting.Internal.AutoRequestServicesStartupFilter.<>c__DisplayClass0_0.<Configure>b__0(IApplicationBuilder builder)
at Microsoft.AspNet.Loader.IIS.RuntimeHttpApplication.HeliosStartupFilter.<>c__DisplayClass0_0.<Configure>b__0(IApplicationBuilder builder)
at Microsoft.AspNet.Hosting.Internal.HostingEngine.BuildApplication()
at Microsoft.AspNet.Hosting.Internal.HostingEngine.Start()
at Microsoft.AspNet.Loader.IIS.RuntimeHttpApplication.ApplicationStart(IHttpApplication application)
at Microsoft.AspNet.Loader.IIS.HttpApplicationBase.InvokeApplicationStart(IHttpApplication application)

You can get your service from application services, like this
public void Configure(IApplicationBuilder app, IHostingEnvironment env, ILoggerFactory loggerFactory)
{
    IMyService service = app.ApplicationServices.GetService<IMyService>();
}

Your are registering a service as IMyService, but then you are trying to consume it as MyService. If you change your Configure method to take an IMyService it should work.
Please note that this question is not specific to MVC. For general DI questions you can file issues in the Dependency Injection repo.

Yes this isn't a bug

Thank you for your guidance :+1:


Dockerize vitessce

Add Dockerfile for building vitessce image
Add docker image to vitessce_spatial requirements

Super cool! Thanks @alliecreason


Tracks Cargo.lock

Rationale: https://doc.rust-lang.org/cargo/guide/cargo-toml-vs-cargo-lock.html

from cargo help install:
       By default, the Cargo.lock file that is included with the package will be ignored. This means that Cargo will recompute which versions
       of dependencies to use, possibly using newer versions that have been released since the package was published. The --locked flag can
       be used to force Cargo to use the packaged Cargo.lock file if it is available. This may be useful for ensuring reproducible builds, to
       use the exact same set of dependencies that were available when the package was published. It may also be useful if a newer version of
       a dependency is published that no longer builds on your system, or has other problems. The downside to using --locked is that you will
       not receive any fixes or updates to any dependency. Note that Cargo did not start publishing Cargo.lock files until version 1.37,
       which means packages published with prior versions will not have a Cargo.lock file available.

TL;DR: cargo install will ignore Cargo.lock by default unless --locked flags was passed.

from cargo help install:
       By default, the Cargo.lock file that is included with the package will be ignored. This means that Cargo will recompute which versions
       of dependencies to use, possibly using newer versions that have been released since the package was published. The --locked flag can
       be used to force Cargo to use the packaged Cargo.lock file if it is available. This may be useful for ensuring reproducible builds, to
       use the exact same set of dependencies that were available when the package was published. It may also be useful if a newer version of
       a dependency is published that no longer builds on your system, or has other problems. The downside to using --locked is that you will
       not receive any fixes or updates to any dependency. Note that Cargo did not start publishing Cargo.lock files until version 1.37,
       which means packages published with prior versions will not have a Cargo.lock file available.

TL;DR: cargo install will ignore Cargo.lock by default unless --locked flags was passed.

Yep, last rebase already included --locked

close #148


v1 tag should track latest v1.x.x release

v1 should point to v1.1.0 (latest release as of today) instead of v1.0.4
This is what others do: https://github.com/aws-actions/amazon-ecr-login/releases/tag/v1, https://github.com/aws-actions/configure-aws-credentials/releases/tag/v1
BTW v1 (v1.0.4) uses Node.js 12 (v1.1.0 uses Node.js 16) so all users gets these warnings:

Node.js 12 actions are deprecated. For more information see: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/. Please update the following actions to use Node.js 16: aws-actions/aws-cloudformation-github-deploy@v1

The set-output command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

Related issues:

https://github.com/aws-actions/aws-cloudformation-github-deploy/issues/73
https://github.com/aws-actions/aws-cloudformation-github-deploy/issues/79

Hey guys, do we have a date when this will be updated?


Remove obsolete import (removed in Django 1.10)

I've removed an obsolete import to solve issue #334

Coverage remained the same at 86.431% when pulling 0ba063edc4aec690efca5c5ba9faf64042bb7707 on jlesech:develop into 1ad2686c3d6eb43a14463a0676809046937d5aec on dyve:develop.

Pulling this into develop, we'll have to add 1.0 to tests also


[autodiscovery/providers] Fix telemetry gauge with number of errors

What does this PR do?
Fixes an issue introduced by https://github.com/DataDog/datadog-agent/pull/20144
Before the PR, the autodiscovery_errors gauge reported the current number of configs with errors, but only for the file provider.
The PR linked above tried to support the remaining providers, but instead of reporting the current number of configs with errors, it incremented the metric every time there was an error, so it's treating the gauge as if it was a counter.
This PR reverts https://github.com/DataDog/datadog-agent/pull/20144 and adds supports for the providers that already track the current errors (kubernetes_endpoints, kubernetes_services, and kubernetes-container-allinone). The rest require more changes. We can add support for them in the future if necessary.
Describe how to test/QA your changes
Deploy on Kubernetes. Create a Kubernetes service that contains a check in the annotations. Use an invalid JSON and check that autodiscovery_errors{provider="kubernetes-services"} reports 1 (assuming that you only have 1 incorrect config) in the DCA. By default, you can check these metrics in http://localhost:5000/metrics. Make sure that the counter is updated correctly when the service is deleted or fixed.
Do the same with an endpoint check (autodiscovery_errors{provider="kubernetes-endpoints"}).
Also, do the same in a check defined in a container. Check in the node agent the value of autodiscovery_errors{provider="kubernetes-container-allinone"}. By default these metrics are reported in http://localhost:6000/telemetry.
Docs for service and endpoint checks:
https://docs.datadoghq.com/containers/cluster_agent/clusterchecks/?tab=helm
https://docs.datadoghq.com/containers/cluster_agent/endpointschecks/?tab=helm
Reviewer's Checklist

[ ] If known, an appropriate milestone has been selected; otherwise the Triage milestone is set.
[ ] Use the major_change label if your change either has a major impact on the code base, is impacting multiple teams or is changing important well-established internals of the Agent. This label will be use during QA to make sure each team pay extra attention to the changed behavior. For any customer facing change use a releasenote.
[ ] A release note has been added or the changelog/no-changelog label has been applied.
[ ] Changed code has automated tests for its functionality.
[ ] Adequate QA/testing plan information is provided if the qa/skip-qa label is not applied.
[ ] At least one team/.. label has been applied, indicating the team(s) that should QA this change.
[ ] If applicable, docs team has been notified or an issue has been opened on the documentation repo.
[ ] If applicable, the need-change/operator and need-change/helm labels have been applied.
[ ] If applicable, the k8s/<min-version> label, indicating the lowest Kubernetes version compatible with this feature.
[ ] If applicable, the config template has been updated.

I think we can also update the helper as it can be interpreted as the number of errors encountered, like a counter:
// Errors tracks the number of AD errors found by AD providers.
 Errors = telemetry.NewGaugeWithOpts(
 	subsystem,
 	"errors",
 	[]string{"provider"},
 	"Number of Autodiscovery errors by provider.",
 	commonOpts,
 )


Condition 'det==0' is true

Operating system or device - Godot version:
Windows 10 - v2.1.stable.official on Steam
Issue description:
Debug errors with set_transform and scaling to Vector2(0,0). This is most likely a very minor issue, but it won't hurt to still report this issue. I'd also like to include that I crashed once already after debugging the project.
Steps to reproduce:
Create a 2D Sprite node and add a Button child node.
In the _ready() function:
set_transform(Matrix32(get_transform().scaled(Vector2(0,0))))

I have added simple check in viewport. But maybe there should be some checks in nodes, which hides node when its new transform makes it hidden?

Fixed by #6743.


Linux: XDG_CACHE_HOME appears in workspace

VSCode Version: 1.35.1
OS Version: Ubuntu 18.04.2

While in VSCode, occasionally a folder will appear in the workspace named XDG_CACHE_HOME. In this folder the Microsoft Python Language Server files appear. I did not press any buttons or shortcut keys (at least that I'm aware of) to precipitate this.
Using printenv reveals my XDG_CACHE_HOME location to be: XDG_CACHE_HOME=/home/user/snap/code/common/.cache
The occurrence appears random.
Does this issue occur when all extensions are disabled?: Unknown

I started getting this today too. Although when I inspect the env it seems normal
➜ echo $XDG_CACHE_HOME
/home/shawn/.cache

It seems to happen when building the stubs
➜ la XDG_CACHE_HOME/Microsoft/Python\ Language\ Server/stubs.v1/
Permissions Size User  Date Modified Git Name
drwxr-xr-x     - shawn 15 Jun 15:40   -N 6Jdz2MUWOGr4bOZIEZpe3fAFOVX2QH2XXVQox93LDvI=
drwxr-xr-x     - shawn 15 Jun 15:40   -N 7C99n6DBx3TyDkTh_256g-aNza2EnMuyP24gUWgBpTY=
drwxr-xr-x     - shawn 15 Jun 15:40   -N CkOhaAcSRrnAxPPLiPLINXzzISvUoHqfUe2XpFnuIkM=
drwxr-xr-x     - shawn 15 Jun 15:40   -N DgUOPNCe5yUG1BRLIQTFkq7B2Go6gWN9a99nyAoAgt4=
drwxr-xr-x     - shawn 15 Jun 15:40   -N t5KoAFz6U1gUfcJCH_VSnv4Svx8S1w9UsncWaDgap94=
drwxr-xr-x     - shawn 15 Jun 15:40   -N ZvCkTbGIBId18gPSW6oZ8Wrre5OpFha3SOKxWNEYMsE=


How best to handle Coverity false positives?

Yesterday's Coverity Scan report contains three items regarding ossl_cmp_error_new(),
and it turns out that all three are false positives.
So I logged in to the Coverity web interface and marked them as such, with the "Action" field set to "ignore".
Is there anything more/else/better to do,
in particular to avoid that anyone else how has received that email of yesterday (needlessly) has a look at those findings?

I generally make an attempt to stop the warning in the code because this prevents them from ever reappearing -- e.g. when code is moved.  A significant number of the reports over the past few months have been earlier issues that were marked ignore.
If "fixing" them isn't possible, I mark them as False Positive, Minimal impact and Ignore.

I generally make an attempt to stop the warning in the code because this prevents them from ever reappearing -- e.g. when code is moved. A significant number of the reports over the past few months have been earlier issues that were marked ignore.

Good point.  At first I had no idea why Coverity came up with issues 1486533, 1486534, and 1486536
and I knew from tests that the behavior apparently inferred by Coverity does not happen,
though in this case after having a closer look I think an overflow can happen maybe dependent on the architecture,
so to be no the safe side I meanwhile consider it a bug and provided a fix in

If "fixing" them isn't possible, I mark them as False Positive, Minimal impact and Ignore.

I don't think that the "Severity" field (this is how it's called, not "Impact") is relevant for false positives.
After I left its value as "Unspecified", Coverity automatically changed it to "Insignificant" (which I guess is what you meant by "Minimal").


fix: don't remove lines that echo output with hash signs during comment removal step

Best-effort comment removal was removing strings from echo calls that were logging information. This now ignores lines that have echo calls to avoid the issue.
What type of PR is this?

What this PR does / why we need it:
Which issue(s) this PR fixes:

Fixes #
Requirements:

[ ] uses conventional commit messages

[ ] includes documentation
[ ] adds unit tests
[ ] tested upgrade from previous version

Special notes for your reviewer:
Release note:
none

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 4 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.06%) to 79.369%

Totals

Change from base Build<PHONE_NUMBER>:
0.06%

Covered Lines:
2289

Relevant Lines:
2884

💛  - Coveralls


[BIOMAGE-1925] - Shuffle plot data points

Description
Problem
Data points in Vega plots are rendered in sequence. This means later cells. This poses a problem because later cells, which maybe in a group, are rendered over the earlier cells, making this later group to look "over-represented" in the plot.
Solution
Right now, the categorical and continuous plots generates data by iterating through the groups (e.g. samples/cluster) and appending the cell ids. This causes "ordering" of cell ids by sample/cluster . In code:
// sample1 = { cellIds: [1, 10]}
// sample2 = { cellIds: [0, 5 ]}

const cellIds = []
samples.forEach((sample) => { cellIds.push(...sample.cellIds) }

// Result:
cellIds = [
1, // from sample 1
10, // from sample 1
0, // from sample 2
5, // from sample 2
.....
]

The changes in this PR uses the order of cells in the embedding data returned from the pipeline. These cells are shuffled. In code:
// Contains the x,y coordinate of each cell. Null means data is filtered in QC.
// embeddingData = [[1, 2], null, [5, 6]]
const data = []
embeddingData.forEach((coordinates, idx) => {
    if (!coordinates) return

    data.push({
        cellId: idx,
        coordinates
    })
}

// Result
data = [
    {cellId: 0}, // e.g. from sample 2
    {cellId: 2}, // eg.  from sample 1
    ...
]

Therefore, the order of rendering follows the order of the shuffled cells generated in the pipeline.
The Embedding in data-exploration is not affected by this issue because it uses the cell ordering as returned in the embeddingData. Therefore, just shuffing the data as done in pipeline PR #236 is enough without further changes in the UI.
Details
URL to issue
https://biomage.atlassian.net/browse/BIOMAGE-1925
Link to staging deployment URL (or set N/A)
https://ui-agi-squeaky-termite.scp-staging.biomage.net/
Links to any PRs or resources related to this PR
https://github.com/hms-dbmi-cellenics/pipeline/pull/236
Integration test branch
master
Merge checklist
Your changes will be ready for merging after all of the steps below have been completed.
Code updates
Have best practices and ongoing refactors being observed in this PR

[ ] Migrated any selector / reducer used to the new format.

Manual/unit testing

[ ] Tested changes using InfraMock locally or no tests required for change, e.g. Kubernetes chart updates.
[ ] Validated that current unit tests for code work as expected and are sufficient for code coverage or no unit tests required for change, e.g. documentation update.
[ ] Unit tests written or no unit tests required for change, e.g. documentation update.

Integration testing
You must check the box below to run integration tests on the latest commit on your PR branch.
Integration tests have to pass before the PR can be merged. Without checking the box, your PR
will not pass the required status checks for merging.

[ ] Started end-to-end tests on the latest commit.

Documentation updates

[ ] Relevant Github READMEs updated or no GitHub README updates required.
[ ] Relevant Wiki pages created/updated or no Wiki updates required.

Optional

[ ] Staging environment is unstaged before merging.
[ ] Photo of a cute animal attached to this PR.

@alexvpickering the staging link is working, can you please check it out?

Shuffling looks good. Only comment is that a random shuffling (different from what comes from worker) is equally acceptable if performance is an issue for large datasets or it is easier to maintain

Shuffling looks good. Only comment is that a random shuffling (different from what comes from worker) is equally acceptable if performance is an issue for large datasets or it is easier to maintain. I'll leave that to you to choose though :)

I think it's better implemented this way as shuffling is done only once in the pipeline and we don't have to do it again in the UI.


Memory usage issues throughout the build

I had fun this afternoon and monitored a full build of HACL* on my machine to see who were the worst offenders in terms of memory usage... this is a recurring complaint (CI builds severely limited in parallelism because of occasional bursts in memory consumption; students can't run a full build with -j 2 on their medium-end laptops; etc.).
Here's what I did:

ran a build of HACL*
ran a sample every 1s to get the process on my machine that consumes the most memory (highest RSS): rm -rf log; while true; do ps -x -o rss -o command | sort -n | tail -n 1 | tee -a log; sleep 1; done
sort and print: sort -r ~/log -n | sort -s -k 2 | uniq -f 1 | sort -n | awk '{ print $1, $NF }' | sed 's/hints.\(.*\).hints/\1/g'

For the sample: use a custom ps invocation that only prints RSS and the command; sort numerically; keep the highest one; append to the log file.
For the sort and print: sort the samples by highest RSS first; then sort using a stable sort using only the invocation; this means that the entries are now grouped by command, and for each file, the highest RSS comes first; then keep unique entries based only on the command; sort numerically again; keep only first and last fields; trim.
The result -- first column is in byte, I manually edited this to make it more apparent how big the memory usage was.
1,930,092 Hacl.Spec.Bignum.Definitions.fst
2,020,592 Vale.Transformers.InstructionReorder.fst
2,070,856 Vale.AES.X64.AESGCM.fst
2,302,672 Vale.Poly1305.X64.fst
2,704,552 Spec.P256.MontgomeryMultiplication.PointAdd.fst
3,528,656 Vale.Wrapper.X64.GCMdecryptOpt.fst
3,899,972 Vale.AES.X64.GCMencryptOpt.fst
3,916,500 Vale.AES.X64.GCMdecryptOpt.fst
4,043,888 Hacl.Test.ECDSA.fst
4,119,032 Vale.Curve25519.X64.FastHybrid.fst
4,976,700 Hacl.Test.HMAC_DRBG.fst
11,115,828 Hacl.Impl.P256.LowLevel.fst

Some interesting takeaways:

very few invocations of F* actually go beyond 2GB
there are a few offenders in the 5GB ballpark
one single file is clearly an outlier. See #539

This is obviously an approximation; I probably should have used tail -n 5 to be more accurate... I can re-do that at a later point, because this may have missed some files. But this is pretty informative already.

Update: ran with -n 5 as promised, here's a more precise count. This lists all of the files that ended up peaking above 2GB of memory. Surprisingly few of those!
2,263,476 Vale.AES.X64.AESGCM.fst
2,368,652 Vale.Poly1305.X64.fst
2,671,768 Hacl.Impl.SHA2.Core.fst
3,376,952 Vale.Wrapper.X64.GCMdecryptOpt256.fst
3,491,508 Vale.Wrapper.X64.GCMencryptOpt256.fst
3,501,196 Vale.Curve25519.X64.FastUtil.fst
3,508,300 (fstar.exe)
3,516,564 Vale.Wrapper.X64.GCMencryptOpt.fst
3,549,684 Vale.Wrapper.X64.GCMdecryptOpt.fst
3,821,796 Vale.Curve25519.X64.FastHybrid.fst
3,824,408 Vale.AES.X64.GCMencryptOpt.fst
3,897,656 Vale.AES.X64.GCMdecryptOpt.fst
3,938,032 Vale.Curve25519.X64.FastSqr.fst
4,238,168 Hacl.Test.ECDSA.fst
5,198,160 Hacl.Test.HMAC_DRBG.fst
5,784,732 Test.Vectors.fst
11,250,172 Hacl.Impl.P256.LowLevel.fst

2,172,040 Hacl.Impl.P256.LowLevel.fst
2,178,808 Vale.Curve25519.X64.FastMul.fst
2,234,952 Vale.AES.X64.AESGCM.fst
2,411,460 Vale.Poly1305.X64.fst
2,465,716 Spec.P256.MontgomeryMultiplication.PointAdd.fst
2,491,804 Hacl.Impl.SHA2.Core.fst
2,655,512 Hacl.Spec.K256.Field52.Lemmas3.fst
3,424,432 Vale.Wrapper.X64.GCMencryptOpt.fst
3,459,308 Vale.Curve25519.X64.FastUtil.fst
3,524,508 Vale.Wrapper.X64.GCMencryptOpt256.fst
3,678,088 Vale.Wrapper.X64.GCMdecryptOpt.fst
3,730,196 Vale.Wrapper.X64.GCMdecryptOpt256.fst
3,893,544 Vale.AES.X64.GCMdecryptOpt.fst
3,925,760 Vale.AES.X64.GCMencryptOpt.fst
3,936,032 Vale.Curve25519.X64.FastSqr.fst
4,151,604 Vale.Curve25519.X64.FastHybrid.fst
4,398,368 Test.Vectors.fst
5,009,852 Hacl.Test.HMAC_DRBG.fst
5,782,072 Hacl.Test.ECDSA.fst

this is a massive improvement for P256.

I am happy to try re-fixing this proof, but it would be useful to get some guidance on what blows up memory usage here, so that I or others don't re-introduce any "bad" patterns in HACL*. Do you or Aseem have an explanation on what patterns we should not use and what the typical fix would be ? I can then implement it here, and this Issue and PR #556  can serve as a guide on what to do in such cases.

Closing since the file is now gone. @pnmadelaine you might find the commands interesting to monitor memory usage throughout the build; they're for OSX but can be easily adapted for a GNU userland, I'm sure


Imasdk integration

Related:
Based on https://github.com/sampotts/plyr/blob/master/src/js/plugins/ads.js & https://github.com/glomex/vast-ima-player/blob/master/src/vast-ima-player.ts

Description:
A "media-ads" component which enables users to show vast/vmap ads via the google IMA sdk.
Test with https://gist.github.com/ElBouhaliMohamed/87efc074954179824645b767fc0fa80d in sandbox

Ready?
Far from ready

Anything Else?

Review Process:

Yo I appreciate this PR heaps, looks awesome!
There's a lot to review, caught a bunch of bugs on first glance. I can't review it right now because I have to get this next release 0.5 out in the next few but right after that I will.
Only things on my mind when I look at that right now is:

We probably need ad tracking on the main media store to do things like change the time slider.

I'm not familiar with ads libraries so where does this play exactly? How does it work? More my own research to do but if you have anything to share love to hear it.

We probably need some kind of ads integration layer the same we did with providers. I don't think it'd be a main component but rather a plugin of sorts? Could that work? For example, can we just set some stuff on the player like ads-x="..." and load the correct integration? What other integrations are there?

The other reason for ^ is because the component is too big to load by default.

Love the additions/changes, new direction is looking good!
Some thoughts:

We need to remap media requests (see media-request-manager) to be taken on the ad element instead of the current media. For example, if users plays, mutes, or fullscreens it should be redirected to the ad video element. We probably just need to look at at a flag on the media store inside existing request handlers.

We probably should prevent loading this for audio? Not sure.

We currently run all media events through the MediaStateManager (see media-state-manager) so we can centralize logic for updating the store and attaching requests (e.g., media-play-request on to a play event) - this is for analytics work later. In general, it helps identify system and user actions. To avoid additional event bindings we delegate to the state manager via the MediaPlayerDelegate. This would mean we need to call these methods from inside the AdController (e.g., playerDelegate.handle('ad-play')).

Maybe instead of some the new ad props (e.g., adPlaying) we can just update existing state on the store? This way we don't need to remap everything in UI components. All we really need to know if whether an ad is running or not? I guess some things can't be merged like adLoaded, adCanPlay, adCountdown, etc.

Thanks for all your hard work on this, it means a lot. You don't have to respond to all my points above, feel free to process as needed 👍

Awesome!! I'll dig through after as soon as I can. Thanks for the update :)

I think the easiest way for me to test this is going to be if we have a skin first. This way I can get a better feel of how ads look and how the UI adapts when they're playing. We can circle back right after it and review the API too.

Waiting for the IMA SDK

Hello, any updates on this?
I could try to help if needed.

We'll get back to it after the next release since a lot of the core codebase will change.

I appreciate the work in this PR a lot but because of 1.0@next rebuild it's outdated now. I'm more than happy to guide you in a new PR and get this added in. Most of the files have moved around slightly but you should comfortably be able to find them. You can kick off the new PR empty and start with questions if you like and we can go from there.
I'm sorry we broke this PR and all the hard work you put in, the rebuild and why it was needed is explained in the new release notes. I'd love to see this work go through, if you get a chance to start again love to help. Message me on Discord if you need anything too.
Thank you ❤


Add Flutter to Platforms

https://github.com/Solido/awesome-flutter
Flutter is a new mobile app SDK to help developers and designers build modern mobile apps for iOS and Android. It's supported by Google and is gaining a lot of traction.
By submitting this pull request I confirm I've read and complied with the below requirements.
Please read it multiple times. I spent a lot of time on these guidelines and most people miss a lot.

I have read and understood the contribution guidelines and the instructions for creating a list.
This pull request has a descriptive title.For example, Add Name of List, not Update readme.md or Add awesome list.
The entry in the Awesome list should:

Include a short description about the project/theme of the list. It should not describe the list itself.Example: - [Fish](…) - User-friendly shell., not - [Fish](…) - Resources for Fish..
Be added at the bottom of the appropriate category.

The list I'm submitting complies with these requirements:

Has been around for at least 30 days.That means 30 days from either the first real commit or when it was open-sourced. Whatever is most recent.
It's the result of hard work and the best I could possibly produce.
Non-generated Markdown file in a GitHub repo.
Includes a succinct description of the project/theme at the top of the readme. (Example)
The repo should have awesome-list & awesome as GitHub topics. I encourage you to add more relevant topics.
Not a duplicate.
Only has awesome items. Awesome lists are curations of the best, not everything.
Includes a project logo/illustration whenever possible.

Placed at the top-right of the readme. (Example)
The image should link to the project website or any relevant website.
The image should be high-DPI. Set it to maximum half the width of the original image.

Entries have a description, unless the title is descriptive enough by itself. It rarely is though.
Has the Awesome badge on the right side of the list heading,
Has a Table of Contents section.

Should be named Contents, not Table of Contents.
Should be the first section in the list.

Has an appropriate license.

That means something like CC0, not a code licence like MIT, BSD, Apache, etc.
If you use a license badge, it should be SVG, not PNG.

Has contribution guidelines.

The file should be named contributing.md. Casing is up to you.

Has consistent formatting and proper spelling/grammar.

Each link description starts with an uppercase character and ends with a period.Example: - [AVA](…) - JavaScript test runner.
Drop all the A / An prefixes in the descriptions.
Consistent and correct naming. For example, Node.js, not NodeJS or node.js.

Doesn't include a Travis badge.You can still use Travis for list linting, but the badge has no value in the readme.

Go to the top and read it again.

flutter[at]robbieone.com -><EMAIL_ADDRESS>Add events
More descriptive descriptions

[At] You've accepted this model with https://github.com/jondot/awesome-react-native
So I've just align to be consistent and like a wise guy avoid robot spam.
Add events : Last events was Google IO 17. No events currently planned.
I'm not sure I've the right to override how projects describe themself ? what's the official direction on this point ?

Ok. But, you it should say "Have something that belongs under "Events"? Drop me a line at<EMAIL_ADDRESS>Add Google IO 17 under events
Stuff under Auth, Storage, and Monetization. Also, add more to the ones the just say "by "

I'm not sure I've the right to override how projects describe themself ? what's the official direction on this point ? some entries in particular that need review ?

Feel free to edit descriptions. From experience, most project descriptions could be better. For example, with https://github.com/sindresorhus/awesome-nodejs, I've edited/improved pretty much every description.

Includes a project logo/illustration whenever possible. The image should be high-DPI. Set it to maximum half the width of the original image.

:arrow_up:

Awesome Flutter, getting you effective quickly => Awesome Flutter

Remove the unused section Training & tutorials

Each link description starts with an uppercase character and ends with a period.
Example: - [AVA](…) - JavaScript test runner.

:arrow_up:

Drop all the A / An prefixes in the descriptions.

:arrow_up:

Damn ! Have to say this is a lot of work to get the things up properly ;)

Everything should be in place now +1

Includes a project logo/illustration whenever possible. Placed at the top-right of the readme.

:arrow_up:

Each link description starts with an uppercase character and ends with a period.
Example: - AVA - JavaScript test runner.
⬆

Not fixed.

Formatting and general content need more work.
The list contains stuff like:

Lottie - After Effect for Flutter ???

GoogleAdmob supports interstitial

What's happening at 2:38 ? Brandon told me it's the Intellij Plugin.

Closing for lack of response.

Project is still alive and well. I'll candidate again in some time when I got time to conform to all the rules. Thx for your time.


Clicking sha now copies

Closes #3.
Also fixes some bugs with multiple spaces in username, and changes the formatting of the Phantom.

Clicking the highlighted sha would copy 8150742f and close the phantom.


Add new math functions

Thank you very much for releasing this library! As someone who spent endless hours deriving hessian formulas by hand I can say this is clearly a big help :)
I've added some math functions (clamp, log2, log10) that were missing from the library, they are listed as common math functions here: https://en.cppreference.com/w/cpp/numeric/math
I wrote some tests for each function, but unfortunately I didn't find a way to build the tests (there's an error with StackLowerThanAddress function on gtest-1.10.0) so I could not check that the functions pass the tests unfortunately.
Anyways I've used them in a personal project and they seemed to work fine so I hope this helps

Thanks a lot for the contribution! I'm very happy you're finding TinyAD useful :)
I made sure the new tests compile and pass in our internal CI.


host docs

Description

clean up doc building process
push to repo for hosted docs (closes #473)

you can find the docs at https://napari.github.io/dev/
once we get a real website we may choose to change the repo name to docs or something
additionally, before merge, I will overwrite the repo since these docs (for example purposes) came from a PR

@sofroniewn yes, we can either generally turn off documentation for privatized modules or specifically ignore these files

I just noticed that the commit message is not properly capturing the version so I'll fix that before merge as well


[Question] Run recorder inside a Iframe

Question:
Recorder-crx records user interactions from that tab as we attach the tab id to the crx app.
But is it possible to attach iframe as document from the tab and record interactions only from the iframe.

Yes, as long as the iframe belongs to an attached page, it should record actions in that iframe.
Did you have problems with nested iframes not being recorded?

Yes faced problems in this case, where the main web application tab to which the recorder is attached and the iframe content are sourced from different domains or systems.
My end goal
The iframe document (a different domain or website rendered in iframe) is embedded within the web application, and I am specifically interested in recording the user interactions within this iframe only, not the surrounding web application.
The goal is to exclusively capture and generate test scripts for events that occur within the iframe's document.
I would be happy to discuss this use case and contribute to this project.

I understand. I tried it here and did replicate the issue with the following test:
test("should work in cross-domain iframes", async ({ runCrxTest }) => {
  await runCrxTest(async ({ page }) => {
    await page.goto('https://www.srimax.com/cross-domain-iframe-using-html5/');
    await page.frameLocator('iframe[title="Twitter Follow Button"]').getByRole('link', { name: 'Follow' }).click();
    await page.waitForEvent('popup');
  });
});

Let me investigate it and get back to you.

It seems to be some limitation of Page.getFrameTree on chrome.debugger.
In native playwright, the same Page.getFrameTree call returns the full frame tree (cross-domain iframes included), while using chrome.debugger it doesn't return cross-domain frames.
I'll probably open an issue in chromium for that.

upstream bug: https://issues.chromium.org/issues/333981074

Actually, it is not working, because I have to change a few things. Hopefully in the next version this will be working!

@omkarK06 I just released version 0.6.0 which already supports out-of-process iframes, but only for chrome 126+, which is expected to be stable next month.


Connect with Fortmatic won't do anything, is there something required that not has been documented yet?

Hi, we use the following code in order to activate MetaMask, WebConnect, Formatic und Authereum:
 web3Modal = new Web3Modal({
                network: 'matic',
                cacheProvider: false,
                //disableInjectedProvider: true,
                providerOptions: {
                    fortmatic: {
                        package: Fortmatic, // required
                        options: {
                            key: 'pk_live_E166xxxxxxxxxxx',
                            rpcUrl: 'https://rpc-mainnet.maticvigil.com',
                            chainId: 137

                        },
                    },
                    walletconnect: {
                        package: WalletConnectProvider,
                        options: {
                            infuraId: INFURA_ID,
                            rpc: {
                                137: 'https://polygon-rpc.com',
                                4: 'ttps://rinkeby.infura.io/v3/9aa3d95bsdfdfsdfsadfdf',
                            },
                        },
                    },
                    authereum: {
                        package: Authereum, // required
                    },
                },
            });

While MetaMask and WebConnect works fine, Fortmatic and Aurelium will do nothing after click on the appropriate Button in the Dialog.
The only thing, that will happen in Browser-console after clicking on "Connect with Formatic Account" is:
POST http://localhost:8545/ net::ERR_BLOCKED_BY_CLIENT
POST https://api.rollbar.com/api/1/item/ net::ERR_BLOCKED_BY_CLIENT

For me it seems, that this Plugin tries to connect to a local chain run by Truffle or Hardhat.
Is there some other configuration required that has not been documented yet?

Found the solution while looking at the source code:
In the providerOptions, the network options needs to be configured. I will provide PR with documentation for this ASAP.
                providerOptions: {
                    fortmatic: {
                        package: Fortmatic, // required
                        options: {
                            key: 'pk_live_E1662FA53CBCCF8C',
                            network: {
                                rpcUrl: 'https://rpc-mainnet.maticvigil.com',
                                chainId: 137
                            }
                        },
                    },

Found the solution while looking at the source code:
In the providerOptions, the network options needs to be configured. I will provide PR with documentation for this ASAP.
                providerOptions: {
                    fortmatic: {
                        package: Fortmatic, // required
                        options: {
                            key: 'pk_live_E1662Fxxxxxxxxx',
                            network: {
                                rpcUrl: 'https://rpc-mainnet.maticvigil.com',
                                chainId: 137
                            }
                        },
                    },

Issue fixed with documentation, waiting for merging my PR #372  , thanks :)


Add instructions to install wheels from pypi

Hi Mihai, thanks for your great work making this interface.
I got a bit sick of building COLMAP and pycolmap on different machines, so I decided to just make standalone wheels for your library. They should be in pypi now.
I'm adding some instructions to the readme about how to use it. Can you try installing the wheels using these instructions to see if they work for you?

Hi @Skydes, good to hear it's working.
I believe to include the executable functionality in the wheel, we would need to wrap the following commands in Pybind:
int RunAutomaticReconstructor(int argc, char** argv);
int RunBundleAdjuster(int argc, char** argv);
int RunColorExtractor(int argc, char** argv);
int RunMapper(int argc, char** argv);
int RunHierarchicalMapper(int argc, char** argv);
int RunPointFiltering(int argc, char** argv);
int RunPointTriangulator(int argc, char** argv);
int RunRigBundleAdjuster(int argc, char** argv);

Maybe we can use the interface defined from https://github.com/colmap/colmap/blob/dev/src/exe/sfm.cc.

Thanks a lot for your contribution!
I will merge this and create an issue to track the wrapping of colmap exe utilities.

Hi there.
first of all, thanks for the great interface and useful wheel library.
is it possible to run sift feature detection on CUDA enabled device just like colmap?
thanks in advance.