Change error notification level from success to error

Ansible Tower failure notification had wrong level. Changed from success to error so the notification displays red cross instead of green checkmark. Introduced by https://github.com/ManageIQ/manageiq/pull/14625 .
@miq-bot add_label  bug, providers/ansible_tower, fine/yes
@jameswnl Please review. Thanks :)
https://bugzilla.redhat.com/show_bug.cgi?id=1471868

@miq-bot assign @jameswnl

Fine backport details:
$ git log -1
commit c0e90f4a9bf9f445a6d23372360ee521e9031d2b
Author: Jason Frey<EMAIL_ADDRESS>Date:   Wed Sep 20 14:19:38 2017 -0400

    Merge pull request #15998 from ZitaNemeckova/fix_ansible_notification

    Change error notification level from success to error
    (cherry picked from commit 54482634cfaf8ef360a973b205e5a393242ab625)

    https://bugzilla.redhat.com/show_bug.cgi?id=1496908


typo

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. We will now review your pull request.
Thanks,
.NET Foundation Pull Request Bot

Thanks. @github-john-doe If you have more of these coming, would you mind batching them up to larger PR?

Thanks


Update PR template for new charts

What this PR does / why we need it:
Which issue this PR fixes
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

fixes #16665

Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[ ] DCO signed
[ ] Chart Version bumped
[ ] Variables are documented in the README.md
[ ] Title of the PR starts with chart name (e.g. [stable/chart])

cc @prydonius @michelleN


[Feature]: Gitlab container image name references need to be resolved

What operating system are you using?

[X] Linux
[ ] macOS
[ ] Windows

What version of the tool are you using?
gh version 2.20.2 (2022-11-15)
gh actions-importer github/gh-actions-importer v1.0
actions-importer/cli v1.0.14322
What happened?
When importing Gitlab CI configurations container name references are replaced by environment variables, which does not work. Instead they may be resolved and replaced by the resulting string.
Example:
# Gitlab configuration:
variables:
  BUILDER_IMAGE: xxx.com/yyyy:latest
...

build:
  image:
    name: $BUILDER_IMAGE
...

# Resulting GitHub workflow configuration:
jobs:
  build:
    container:
      image: "$BUILDER_IMAGE"
    env:
      BUILDER_IMAGE: xxx.com/yyyy:latest
...

# Desired GitHub workflow configuration:
jobs:
  build:
    container:
      image: "xxx.com/yyyy:latest"
...

Relevant log output
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct

Thanks for raising this! At this time, we have no plans to automatically resolve environment variable values within container references.


FullInspector breaks Polybrush asset

Polybrush: https://www.assetstore.unity3d.com/en/#!/content/53662
By having FullInspector installed in the same project as Polybrush, it causes Polybrush's paint tab to throw an error and fail to load the window, forcing the user to revert to factory settings to close the window.
The error:
InvalidCastException: Cannot cast from source type to destination type. Polybrush.z_BrushModePaint.get_colorPaletteEditor () (at Assets/ProCore/Polybrush/Code/Editor/Brush Modes/z_BrushModePaint.cs:72) Polybrush.z_BrushModePaint.DrawGUI (Polybrush.z_BrushSettings brushSettings) (at Assets/ProCore/Polybrush/Code/Editor/Brush Modes/z_BrushModePaint.cs:132) Polybrush.z_Editor.OnGUI () (at Assets/ProCore/Polybrush/Code/Editor/Interface/z_Editor.cs:307) System.Reflection.MonoMethod.Invoke (System.Object obj, BindingFlags invokeAttr, System.Reflection.Binder binder, System.Object[] parameters, System.Globalization.CultureInfo culture) (at /Users/builduser/buildslave/mono/build/mcs/class/corlib/System.Reflection/MonoMethod.cs:222)
I have sent you a reproing project to your support e-mail that was found on this page: https://www.assetstore.unity3d.com/en/#!/content/14913

To provide a little more context, here is the absolute simplest reproduce-able case.  3 files, TestObject.cs, TestWindow.cs, and TestEditor.cs.
To reproduce, open Window/Test Create Editor Window with Full Inspector installed.  If you remove Full Inspector the editor window behaves as expected.
using UnityEngine;
using UnityEditor;
using System.Collections;

namespace TestNamespace
{
	public class TestWindow : EditorWindow
	{
		[SerializeField] private TestEditor testEditor;
		[SerializeField] TestObject testObject;

		[MenuItem("Window/Test Create Editor Window")]
		static void Init()
		{
			EditorWindow.GetWindow<TestWindow>().Show();
		}

		void OnEnable()
		{
			testObject = ScriptableObject.CreateInstance<TestObject>();

			testEditor = (TestEditor) Editor.CreateEditor(testObject);
		}

		void OnGUI()
		{
			// a null check is added here so that Unity doesn't lock up when
			// testEditor doesn't get initialized due to "InvalidCastException"

			if(testEditor != null)
				testEditor.OnInspectorGUI();
		}
	}
}

using UnityEngine;
using UnityEditor;
using System.Collections;

namespace TestNamespace
{
	[CustomEditor(typeof(TestObject), isFallback = true)]
	public class TestEditor : Editor
	{
		public override void OnInspectorGUI()
		{
			serializedObject.Update();

			GUILayout.Label("Contents of this file don't matter");

			serializedObject.ApplyModifiedProperties();
		}
	}
}

using UnityEngine;

namespace TestNamespace
{
	public class TestObject : ScriptableObject
	{
		public float floatValue;
		public int intValue;
	}
}

Thanks for the easy repro instructions.
This will be fixed in the next upload to Access (likely tomorrow).
To fix it now, edit line 10 of FullInspector2\Core\Editor\fiInspectorOnly_ScriptableObjectEditor.cs  so it also has isFallback=true, ie,
[CustomEditor(typeof(ScriptableObject), editorForChildClasses: true, isFallback = true)]
FYI, @karl-  your code should not be assuming that you'll get a TestEditor instance since you have isFallback = true.


AJ-1119 - Add ability to pull last updated Time for WDS records

This PR adds the following:

a new sys wds table that will keep track of when each data table was last updated (timestamp) in a given instance
adds an API call to get a time stamp of when any of WDS tables were last updated (to be later used by cloning to know if we should or should not trigger a new backup)

Where I would appreciate your feedback:

my overall approach with this
I think I got all the places where data gets updated or deleted to make sure sys wds table acts appropriately but would love another set of eyes to make sure I didnt miss anything
anything else we should add that could be useful as part of this? (one idea I had, we could add a get updated time per table in WDS and use that api to display last updated time per data table in the UI on the data tab)

Reminder:
PRs merged into main will not automatically generate a PR in https://github.com/broadinstitute/terra-helmfile to update the WDS image deployed to kubernetes - this action will need to be triggered manually by running the following github action: https://github.com/DataBiosphere/terra-workspace-data-service/actions/workflows/tag.yml. Dont forget to provide a Jira Id when triggering the manual action, if no Jira ID is provided the action will not fully succeed.
After you manually trigger the github action (and it completes with no errors), you must go to the terra-helmfile repo and verify that this generated a PR that merged successfully.
The terra-helmfile PR merge will then generate a PR in leonardo.  This will automerge if all tests pass, but if jenkins tests fail it will not; be sure to watch it to ensure it merges. To trigger jenkins retest simply comment on PR with "jenkins retest".

A few thoughts for debate:

Do we need to expose a new API for this at all? Knowing that we can always add an API later, isn't the primary use case for tracking a last-updated timestamp to optimize backups? That's an internal optimization, no API needed.
Assuming that optimizing backups is the primary use case, we WILL need to update some timestamp when a record type/table is deleted. If a user deletes a table, any existing backups are no longer up-to-date … but the lastUpdated timestamp in this PR doesn't reflect that. Similarly, we need to bump on deleteInstance and probably createInstance.
I still feel that somehow hooking into the ActivityLogger is worthwhile to consider. We went through pains to ensure that all write operations included a call to the ActivityLogger … seems like you had to redo all that work to ensure that all write operations included a call to bump the last-updated timestamp. Future WDS features will also have to ensure that they include calls to both the ActivityLogger and recordUpdatedTime; do we want that?

Good point - likely makes sense to just take it out if we keep the scope to just back up. I left it in there since I thought showing a "last edited" timestamp in the UI could be useful but that is indeed increasing scope

I thought I was capturing the delete record with this -- (https://github.com/DataBiosphere/terra-workspace-data-service/pull/339/files#diff-6fdffee8355da583e8db9f8b0995789baa890a7fc0b2ba3da10e381f60afee25R456) .

I will take a closer look at attributes - you are correct I do not capture that today.
Great point on instance schema drop - today I clean up everything when an instance is deleted. The way I viewed that is, no timestamp would be returned if that happened, which in the implementation for backup would mean there is no date present so a backup would need to be taken again. I like that implementation better vs trying to preserve a previous timestamp from the previous instance personally.

This is my bad - I was not understanding what you were referring to when you mentioned "activity logger". Going to use it to achieve what is needed here :)

I thought I was capturing the delete record with this …

I realize you said you're revamping to use the activity logger, but for clarity's sake: I am talking about deleting a record type here, not a record … in other words, deleting a whole table.

this has been around long enough with no updates, going to close for now and we can revisit later on.


Publish version with #73 to npm

Would it be possible to publish a version (with #73) to npm?

+1 for version bump

If there is any way to cut a new release that would be 💯


When do you plan to support new RealSense Series?

Hello,
do you plan to support RealSense 400 Series mentioned in news : https://newsroom.intel.com/chip-shots/intel-announces-tools-realsense-technology-development/ and provide an open-source driver?
Thank you,
Natalia

and more importantly when will R 400 be available for preorder? Also looking forward for intel euclid availability

librealsense version supporting RS4xx devices is planned to be published to open-source as soon as the first of RS4xx models becomes available (I don't have concrete information regarding availability of the products themselves).
We are taking the opportunity to revisit some of the design decisions with this release, so it will not be 100% API compatible with existing librealsense code, but will be close.

sounds good! I'm looking forward for the new sensor to be available.
Do you also plan to support ROS wrapper for future sensors?

Yes, ROS wrapper is also planned to be provided.

Great, and thank you!


how can get all user mediaId?

how can get all user mediaId?

please ask a specific question, so it's understandable to anyone.

Use ig.feed.user().


the game completely freeze

my salien completely freeze if i run the script, i've tried to enter the mission first and activated the script after, at first the game run normally and when i activated the script it's completely freeze.

#148


Source control

In the version control panel, sometimes nothing is displayed, although there are modified files, both local and remote. Sometimes only local changes are displayed, with the update button at the bottom left showing that there are remote changes. Even the "Remote Changes" tab is present and shows the number of files changed remotely, but does not show the files themselves.

Same here. Source control shows nothing.. no tabs no text anything..

#82203


React Native Maps still uses the Google API Maps even I use  my own urlTemplate from my server

Bug report

Summary
React Native Maps still uses the Google API Maps even I use  my own urlTemplate from my server.
Environment info

react-native info output:
# react": "17.0.2", "react-native": "0.67.3", "react-native-maps": "^0.30.1"

Steps to reproduce

Build my own tile server using the tips from Switch2OSM
Test from my Internet browser
Follow the guide to use my urlTemplate
Check the number of Google API requests from my Google Cloud Platform

Describe what you expected to happen:

After using the urlTemplate, the API requests should be stopped.

Describe what you actually happens:

Even using the own tiles, the requests increase +1 at each time

Reproducible sample code

render() {
  const {t} = this.props;
  return (
    <View style={styles.container}>
      <MapView
        // provider={PROVIDER_GOOGLE}
        provider={PROVIDER_DEFAULT}
        style={styles.map}
        region={this.state.region}
        mapType={MAP_TYPES.NONE}
          shouldReplaceMapContent={true}
          onRegionChangeComplete={region => {
            this.setState({region});
          }}>
          <UrlTile urlTemplate={urlTemplate} maximumZ={19} flipY={false} />
          <MapView.Marker
            coordinate={{
              latitude: 39.81594,
              longitude: -7.51088,
            }}
            title={'Localização'}
            description={'Descrição'}
          />
        </MapView>
        <View />

Hi, fyi, for me using:
mapType={Platform.select({android: MAP_TYPES.STANDARD})}

resolves the issue.

Hi @JoniVR !
Thanks but it did not solve the counter of the Google Cloud Platform API.
I did 4 requests and I saw them on the GCP.

Oh okay, wasn't aware of this, sorry!

@JoniVR that's OK.
Thanks for helping.
I will use a Web-view or something.
Google maps is very expensive.

Hi! this is still an actual problem is there any way to mitigate this?


Member folders no longer being created

Before whitecube, the util would automatically create a folder called membername (member id) in the root directory when downloading images from that user for the first time (it would also automatically save all new downloaded images to their repsective folders). It's no longer doing this and instead just dumping all the images into the root directory without creating a folder. I've tried creating a list but that doesn't do anything either. Did updating for whitecube support break this or am I doing something wrong?

what is your filename format in config.ini? I tried to download image (option 2, image id=60107053) and the folder is created properly.
Input: 2
Image ids: 60107053
Processing Image Id: 60107053
Title: delicious♥
Tags : オリジナル, ハロウィン, 食べ物, 飲み物
Date : 2016-11-26 00:00:00
Mode : big
Image URL : https://i2.pixiv.net/img-original/img/2016/11/26/00/00/04/60107053_p0.png
Filename  : D:\Temp\Pixiv2\83739 blacklack-21\whitecube 60107053_p0 - delicious♥ - 83739 blacklack-21 オリジナル　ハロウィン　食べ物　飲み物.png
Getting remote filesize...
Using Referer: http://www.pixiv.net/member_illust.php?mode=medium&illust_id=60107053
Start downloading... Using Referer: http://www.pixiv.net/member_illust.php?mode=medium&illust_id=60107053
Creating directory: D:\Temp\Pixiv2\83739 blacklack-21                                                                                2664057 of   2664057 Bytes  Completed in 4.698s (553.77 KiB/s)
 Image verified.

filenameformat = %urlFilename%
filenamemangaformat = %urlFilename%
I guess that might be the issue if your worked fine

yep, you need to use the correct format, e.g. %member_token% (%member_id%)\%urlFilename%.
Check the readme for more details.


Behavioral change to Avro codecs and schema handling

Description
This PR makes a fundamental change to how the Avro-based codecs (Avro and Parquet) handle mapping Events to Avro records.
There are now two cases which are handled differently:

If the pipeline author defines a schema, this takes precedence over the incoming data. Thus, extra fields will be ignored.
If the schema is auto-generated, then future events must match the schema. Thus, extra fields will drop the events.

Issues Resolved
N/A
Check List

[ ] New functionality includes testing.
[ ] New functionality has a documentation issue. Please link to it in this PR.

[ ] New functionality has javadoc added

[ ] Commits are signed with a real name per the DCO

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

It depends on the schema.
If the schema does not allow it to be null, then it will fail to write the Avro record. However, if the schema allows null, it will be saved as null.
This test should cover it: convertEventDataToAvro_skips_non_present_fields.


Roblox-Client-Optimizer Flags

An option to automatically download and apply Roblox-Client-Optimizer client flags would be good, here's the benefits it has:

Unlocks FPS (For most people)
Optimizes Caching
Optimizes Graphics
Optimizes Textures
Increases user privacy
(May change) Disables the V3 ingame menu
Disables Crashpad / Backtrace crash metrics
Disables a large portion of client telemetry
Disables AbuseReportScreenshot
Enables font and texture item preloading
Enables memory prioritization and performance control
Enables FULL graphics quality options (21 instead of 10!)
Enables QuickGameLaunch
Enables ParallelHumanoidManager
Enables BatchAssetApi

I don't think it would be suitable to make these a replacement for rbxfpsunlocker, as rbxfpsunlocker is much more customisable and reliable. I think that a GUI FastFlag editor would be a useful feature, you can extract FastFlags using this command RobloxStudioBeta.exe -startEvent FFlagExtract -showEvent NoSplashScreen with Roblox Studio, which puts the flags into the root of the regular Roblox AppData directory I think.

I was considering using the flag because the idea is that the flag should be more reliable than using an unlocker (done by the actual rendering engine itself vs done externally by editing memory), and it would reduce an additional dependency that has to be checked for updates, etc. There's not really anything rbxfpsunlocker does more than setting the flag does.
Just so I know, are there any cases of the flag not working where rbxfpsunlocker does?

Not sure, but I would say to keep Roblox FPS Unlocker as an option as you can manually specify and cap the FPS.

You can also specify the cap with the flag - it's an FInt flag.

Oh, maybe it would be fine then, but I think that it should be properly tested first as on the repo it says that it might not work for everyone.

off-topic:

I'm thinking about replacing rbxfpsunlocker with the FPS flag

https://github.com/vinegarhq/vinegar/commit/78f57cf0695d97dcae1c100f8ba64d9f2071faf3

Yeah, keeping the code stashed for Roblox FPS Unlocker would be good

Found these a few days ago, I can make an option to easily add these. I'm thinking about replacing rbxfpsunlocker with the FPS flag, but you mentioned that it only works for most people?
Also a bit unrelated, but I'm wondering if a FastFlag editor GUI is worth adding, since just editing the JSON file with a text editor should be sufficient and flexible enough.
Studio like FFlag editor would be neat. Currently I'm usin vscode for editing them.

So I've been taking a look at these and I probably won't add these. Or at least, not fully. I (and others) have expressed concern over many of the rendering-related flags that these configure for the sake of optimization. It modifies a lot of flags (almost 250 of them), and doesn't really explain why it configures what it does. It has good intentions, but because of this it seems to lead to instability (this and this are a few examples).
I mean not fully as I'm planning to add more FastFlag mod presets - some of which are in RCO (like the TaskScheduler FPS cap, 0-21 graphics levels, etc.). See #125 for that. If you want to add a select few flags from RCO that help with making a difference and are stable, feel free to.

I think that not having the full thing, but I agree that extracting certain useful sets of flags (e.g. disabling telemetry, unlocking FPS) would be useful.

Reopening this as while they can potentially be unstable, if the user knows about that then it's mostly fine. Other than that, it makes a good addition to the FastFlag mod preset update.

Honestly, the more I look at this, the worse it gets. @bluepilledgreat and others can definitely see where I'm coming from with this. This probably isn't work official support. The option of just adding the flags to Bloxstrap manually still exists, so if you really want to, which I don't recommend, go ahead and do it that way.

Honestly, the more I look at this, the worse it gets. @bluepilledgreat and others can definitely see where I'm coming from with this. I don't think this is worth officially supporting. The option of just adding the flags to Bloxstrap manually still exists, so if you really want to, which I don't recommend, go ahead and do it that way.

this decision LGTM


NSUUID attributes are not supported

Attributes that are NSUUID type are dropped from display because tableCellViewClassForAttributeType_cde does not handle them.

+1
This would be a great feature to have. Thanks.


how to represent attributes/measures/units in info.json

Design session following the spike to demonstrate/discuss the extensions to info.json and their implications.

https://github.com/GSS-Cogs/family-schemas/blob/main/dataset-schema.json

http://donofden.com/blog/2020/03/15/How-to-Validate-JSON-Schema-using-Python

https://swirrl.github.io/PMD-AP/index.html


Add test and reference image paths to Assertion errors in backplane / gold master tests

Aren't these available by using the --fullpaths option when running gold_master.py?
If not could you please add additional detail to this issue?


https://admin.thegreenwebfoundation.org/green-urls is 404

@mrchrisadams please have a look.

Ah, oops ! sorry @BR0kEN.
I had been updating some of the admin, and forgot that the green url would move.
I'll be pushing a change to make the downloads accessible at the old url tomorrow, as I'm working to decouple this from django admin, but in the mean time, you can download the files at the link below instead.
https://admin.thegreenwebfoundation.org/admin/green-urls

Got it! Thanks for providing a new URL.
https://www.thegreenwebfoundation.org/green-web-datasets/ this page still links the old one.


How do I run it?

Hi, I'm keen to use this but I don't understand how to trigger it.
Can it be / is it, run from the command line as part of the axe run command?

I build this as a utility used by expect-axe-playwright and since I don't have a use case for it standalone with axe.run I did not build it to work that way.  I'd happily accept contributions though.


Compiler unable to optimize keyPath usage inside closures

Describe the bug
In some cases where key paths are involved, the compiler is able to optimize them into direct accesses, rather than the traversal/iteration KeyPath does.
For example, the compiler is able to optimize the following into a direct access:
struct Value {

    let number = 2

}

let getter: (Value) -> Int = { $0[keyPath: \.number] }

getter(Value())

However other instances the compiler is unable to optimize, even when the function is inlineable:
func closure<R, V>(from keyPath: KeyPath<R, V>) -> V {
    { $0[keyPath: keyPath] }
}

let getter = closure(from: \Value.number)

getter(Value())

Steps To Reproduce

Declare a function that returns a closure wrapping a key path access
Observe that access is not flattened into a direct access

Expected behavior
Swift should be able to convert inlineable instances inside closures.
Environment (please fill out the following information)

OS: macOS 12.5
Xcode Version/Tag/Branch: Version 13.4.1 (13F100)

concurrent forum discussion: https://forums.swift.org/t/performance-characteristics-of-keypath/60081/2


luci-app-firewall: add masq6 option for zones

Allow configure Masquerading6 via LuCI interface.

And one final remark; I am not sure if we should expose the masq6 option this prominently. At the very least it should be hidden from the tabular zone overview (by removing o.editable = true;) and maybe it should be even moved into the advanced section.
IPv6 masquerading on a zone should be the exception (as last resort after PD and relay mode) rather than the norm.

And one final remark; I am not sure if we should expose the masq6 option this prominently. At the very least it should be hidden from the tabular zone overview (by removing o.editable = true;) and maybe it should be even moved into the advanced section.

Updated and moved it into the advanced section.

Merged, thanks!


ML's architecture change - Unit Testing and Proxy changes

-Fixed distinctDocumnt RDD[String]. It is being collected in multiple places, added cache() to have same list in same order every time.
-Replacing LDAWrapper output from Map[String, Array[String]] to tuple (Array[String], Array[String])
-Removing unused imports from DNSWordCreationTest
-Changed ml_ops.sh parameters to be more descriptive
-Added LDAWrapperTest
-Added Flow and DNS WordCreationTest
-Merged Proxy and modified ProxyLDA to receive tuple (Array[String], Array[String]) from LDAWrapper instead of Map(String, Array[String])

lookin good to me!!!

LGTM

LGTM


Not sending the Application DLL in Blazor WASM

When using Blazor in WASM - I want to not send any of my business logic (Application) to the client. (I don't want them to reverse engineer it). I want to send only the things it actually needs = the DTOs.
Please can you split out the DTOs to a separate Project - e.g. Application.Dto - and make sure only that goes down the wire to the client?
Open to other ideas!
Thanks!

That makes a lot of sense split application project.
Lightweight simplicity is the original intention, Work with code generation tools, and keep your business code in a single project.

Blazor WASM is client mode. EF core(dbcontext) not support WASM


TreeSAGE ?

Hi,
Do you think is it possible to adapt the SAGE approach using a faster approximation for tree-like models like the TreeSHAP algorithm for shapley values ?

It's not something I've worked on, but I've seen at least one paper on the subject and I've thought about it before. There are a couple ways to approach it that achieve different tradeoffs between approximation quality and speed, and it would take some time to figure out what makes the most sense.
For example, at one end of the spectrum, we could leverage the tree structure when querying the model with each feature subset: the split proportions can help handle unknown feature values. This wouldn't compromise the approximation quality, and I suspect it would provide a modest speedup.
On the other end of the spectrum, you could make a very aggressive approximation and do something like multiply the per-sample TreeSHAP values by the loss gradient at the actual prediction, and then average this across samples. Intuitively, that represents whether eliminating a feature on average moves predictions in a direction that helps or hurts the loss value. This is extremely fast, but it really compromises the approximation quality. (Not so much that it's not useful - I've used it successfully for high-dimensional nonlinear feature selection, but they're hardly SAGE values at this point.)
I'm actually not an expert on TreeSHAP, so I'm not sure if there's another option in the middle that resembles a specialization of the TreeSHAP dynamic programming algorithm for SAGE values.
Is this something that would be very helpful for your use case?

Hi, thanks for the great answer!
The main use I see is that gradient boosting is very very popular and often, when working with millions of rows and undreds of features, SAGE "kernel" is very intensive and long to compute (In this case I prefer to use the global approximation of averaging absolute local Shapley values from treeSHAP for efficiency reason). I was hoping a treeSAGE approach would help to significantly reduce the computing time like it is the case for treeSHAP vs KernelSHAP.

You're right, that would be pretty useful. Let me talk to someone who knows TreeSHAP very well and get back to you.

Alright, I have a solution that actually requires very little effort to try! The idea is that SAGE values are the average of LossSHAP values - in case you're not familiar with that, it's when you use SHAP on a per-prediction basis to explain the loss rather than the raw prediction. (We discuss it a bit in the paper, and also in this blog post.)
Because of that, the simple approach you can do is 1) calculate per-sample LossSHAP values, 2) average those across samples. And voila, you'll have a very fast estimate of the SAGE values.
As for implementing LossSHAP, it's already supported in the shap repo - see the argument that you need to specify here (model_output='log_loss'). It's only supported for feature_dependence='independent' (i.e., the version that's a worse approximation of the conditional distribution), so that's arguably not ideal, but it's definitely good enough to be useful.
Let me know how that sounds and if you're able to give it a try. If it's useful, I could write a wrapper around it so folks could run it from the SAGE package.

Hi Ian!
Here what I did following your advice:
shap_explainer_interv_sage = shap.TreeExplainer(model_catboost,
data=X_test,
model_output='log_loss',
feature_perturbation='interventional',)
shap_val_interv_sage = shap_explainer_interv_sage.shap_values(X_test, y_test, check_additivity=False)
Seems to work! I Observed some small rank differences vs model_ouput = 'raw' soo it does give an alternative answer with the same background data and model.
However, I Also observed big rank differences using SAGE on the same dataset. A major difference is that with SAGE, I was forced to use a small sample for performance reasons.
Based on this small experiment, I would say that model_output='log_loss' vs SAGE are actually not giving the same results (Maybe the "interventional" approach or/and the sampling are the reason why ?).
Also, SAGE gave me some features with negatives shapley values but not the model_output='log_loss' approach.
In conclusion, when SAGE is not possible for performance reasons (big datasets), I would definitly use model_output='log_loss'as an alternative to compute global shapley values instead of the model_ouput = 'raw'.
What do you think ?

What you've described makes sense! I have a couple thoughts on why the output from TreeSHAP and SAGE were different:

Using a different set of samples. But of course you tried addressing this, so it's not the main reason. (On a sidenote, I would have thought SAGE's time to converge wouldn't scale too significantly in the number of samples, or at least not linearly. It sounds like that's not what you observed?)
The way held-out features are removed shouldn't be very different. SAGE would ideally do something "observational", but the MarginalImputer object is actually roughly equivalent to what SHAP is doing here. (It's a little hard to tell from the code, but I think independent is the same as interventional.)
The main reason, I think, is that SHAP uses a cheap approximation of the Shapley values for the model's loss, whereas SAGE calculates this properly. In that sense, I would expect SAGE's output to be more reliable. However, this comes at the expense of more computation, and I suppose the tradeoff isn't always worth it.

How different were the rankings you saw? Were they at least similar for the most important features?
And the final interpretation you gave seems right to me: that when SAGE is too costly to compute, I would probably consider using SHAP's log_loss option over mean absolute values with the raw option. Perhaps there's an easy way to test this... Have you by any chance tried something like retraining a model with the top features (e.g., the top 10), and seeing which version gives the best performance?


Cache latest blog title and link

Login makes one for all users every 6 hours. Manager might not be able to do that exactly but it can do a bit better than just caching in this.state.

Can cache it in localStorage with an expiration time.

It would be weird if it cached it inconsistently with login... something to think about

I'm not particularly concerned about that.

Feature removed.


⚠ Bofrost.lu has degraded performance

In cd5dd28, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 1595 ms

Resolved: Bofrost.lu performance has improved in b80f07d after 311 days, 20 hours, 20 minutes.


Subtitle Track - not hard-subbed

Feature Improvement:
Would it be possible to get the subtitle in a separat subtitle track and not hardcoded? That would allow to increase subtitle text size on some players (got problems with my eyes and it is always to small).
And by the way: Great work! I love your CLI tool! :)

nevermind... "archive" option was what I'm looking for.


Question: How to write unit test for contracts?

I could not find any documentation regrading contracts testing. Is there any counterpart for #[ink(test)] in ask! ? Or a way to mock env() interface?

Now it's not supported. Not very easy to impl it because dealing with pointers in AS is cumbersome.
And also ink! update their code this part very fast.
We need more time to focus on main feature.


.env

@MrManifesting
Your API KEY has been exposed.
Please disable it immediately.
We'll close this PR.


urlSync bug with base attribute

Hello,
There is a bug happening when urlSync: true and the html page has a base attribute which is different from the current URL. It will instantly replace the URL with the base url, to which is appended the instantsearch.js state as a query string
Demo: http://url-syncbug.surge.sh/test
The base attribute is:
<base href="http://url-syncbug.surge.sh">

The page URL is instantly changed to http://url-syncbug.surge.sh/?q=rake&hPP=6&idx=Version_development&p=0&is_v=1
One solution could be to replace the entire URI path instead of just the query params part

Working on this, got a fix (use the full url). The underlying issue is that as soon as you use a base href,  when you push relative things inside pushState or location.href then they are resolved to the base href tag.
Which can either:

result in a full page load (when using #)
result in a security issue (when using pushState)

This is my fix (really really durty)
Be carefull, it's durty.
...
Did I told you it's durty ? Yes ?
        instantsearch.widgets.durtyFixPagination = function() {
            return {
                render: function render(options) {

                    setTimeout(function() {
                        var matches = document.querySelectorAll("#pagination a[href]");
                        var domain = (qpConfig2.WEBAPPMOBILE ? qpConfig2.URLS.MOBILE : qpConfig2.URLS.WWW);
                        var urlBegin = domain + '/?';
                        angular.forEach(matches, function(a) {
                            if (urlBegin === a.href.substr(0, urlBegin.length)) {
                                a.href = domain + qpRoute.getCurrentRoute().translatedUrl + a.href.substr(urlBegin.length - 1);
                            }
                        });
                        console.info('pagination fix done');
                    }, 800);

                }
            };
        };

@GabrielDelepine this should already be fixed in latest version, wonder why did you had to fix it? Are you on latest version?

Hi @vvo
The fix is in the master branch. I am waiting for the release 1.4.3.

@GabrielDelepine The fix was done and is available in 1.4.2, that's why I am wondering. See https://github.com/algolia/instantsearch.js/commit/e58aadcd9aae77165b802b46a7d3de5864569e1e

Please open a new issue if you still have problems with urlSync and base tag


Update usernames.json automatically

Set up cron job to automatically refresh the list of students. Probably could do this once a year, but no harm in refreshing at the same cadence as the rest of the cron tasks.

@JonBriggs will add an endpoint to get the list of usernames.

e.g. https://eastsidepreparatory-my.sharepoint.com/personal/jbriggs_eastsideprep_org/Documents/Microsoft Teams Chat Files/usernames.txt

@JonBriggs did you get a chance to add this endpoint?

Added an endpoint, this will also address #533
I would also like to move all current /epsnet/... to /epschedule/... to segment the four11 API space by project.
The old ones will continue to work until I get the all clear to deprecate.
https://four11.eastsideprep.org/epschedule/people requires the four11 Auth Bearer Token and returns a list of all current fac/staff and students. The gradyear field will either contain the graduation year or the string "fac/staff" in JSON format
Each record will look like the below
   {
                id: 1234,
                firstname: "Joseph",
                preferred_name: "Joe",
                lastname: "Student",
                lunch_id: 20201234,
                email<EMAIL_ADDRESS>
                gradyear: 2020, #Teachers/Staff will show "fac/staff" in this field
                photo_url: "https://four11.eastsideprep.org/system/student/000/001/234/a_non_predictable_filename.jpg"
            }

Other endpoints
/epsnet/schedule_for_date remains the same (as that is used by many systems)
/epsnet/courses/login --> /epschedule/courses/login as that is used exclusively by epschedule


How to use tag arg-file when with agent docker image

I'm using docker run  agent image acapy start --arg-file ./local.yaml  but not able to start acapy

When you're running in Docker you need to either copy your config file into the docker image, or else mount the directory containing your config file so that it's accessible within docker.
There's an example that shows how to do this:  https://github.com/hyperledger/aries-cloudagent-python/blob/main/demo/docker/docker-compose.yml
(This is for a multi-ledger config file, but the principle is the same.  The example uses docker-compose but you can do the same thing running docker from the command line)


Azure API Management - Policy authentication-managed-identity when app registration has custom app id

When the app registration as a custom app id assigned, e.g. https://MyAwesomeApp, then the resource parameter doesn't find the app registration unless the value is exactly the client_id (without api:// as documented).

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 2be8b264-03df-625e-0064-06cb4372c3b7
Version Independent ID: 87333d80-8130-1c1d-523f-1e904d7061d7
Content: Azure API Management authentication policies
Content Source: articles/api-management/api-management-authentication-policies.md
Service: api-management
GitHub Login: @vladvino
Microsoft Alias: apimpm

Thanks for the feedback and bringing this to our notice . At this time we are reviewing the feedback and will update the document as appropriate .

@TobiTh Thanks for reporting this item! I have updated the doc and it will be published soon. We appreciate the feedback!


Confusing tag_all versions overlapping individual item versions

For example https://github.com/gtker/wow_messages/blob/22842fa515be36cc2426d6df8702e611be35c671/wow_message_parser/wowm/world/spell/cmsg_cancel_cast.wowm has #tag_all versions "1 2 3"; and the tests have versions = "1.12";. This is confusing (and undocumented).
from #77

From https://github.com/gtker/wow_messages/issues/77#issuecomment-1742912225 by @gtker

I think I'm currently of the opinion that tests should be marked only with the exact version that they were tested with.

I think having tag_all versions overwritten by versions would be confusing (as adding tags seems additive in general), but not sure how to make it clearer.

Having distinct versions that overlap should probably just be an error, since it's most likely unintended.


Adding TWKB format

TWKB format is a compressed binary format.
It is new and a moving target but is in the PostGIS trunk.
The format is described here:
https://github.com/nicklasaven/TWKB
and a working example can be found here:
http://sandbox.postgisonline.org/oltest/
It is working also in IE9 but I guess the rewrite of the XHRIO part needs to be discussed.
The code is passing all testes, but it is not very well tested yet with different geometry types and so on.
I have tried to follow the style of other code in the project but I am not a JavaScript guy so bare with some ugliness.
I will fix it when you point at it.

If TWKB finds a champion, this can be revisited.


Day472

Resolves #941.

Pull Request Test Coverage Report for Build 1750

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build 1748:
0.0%

Covered Lines:
5

Relevant Lines:
5

💛  - Coveralls


Redo is not working

VSCode Version: Code 1.8.1 (ee428b0eead68bf0fb99ab5fdc4439be227b6281, 2016-12-19T14:42:49.304Z)
OS Version: Darwin x64 16.3.0
Extensions:

Extension
Author
Version

vscode-todo
MattiasPernhult
0.8.0

csharp
ms-vscode
1.6.2

mono-debug
ms-vscode
0.12.0

node-modules-resolve
naumovs
1.0.2

Steps to Reproduce:

@thiagofmleite could you please provide steps on how to reproduce this. Redo works for me.

Closing until steps are provided.


Fuzz insert test failed

What type of bug is this?
Unexpected error
What subsystems are affected?
Storage Engine
Minimal reproduce step

Hard code the FuzzInput to

FuzzInput { seed: 266, columns: 19, rows: 3995 }

Run GreptimeDB
Run

cargo fuzz run --fuzz-dir tests-fuzz -D --sanitizer=none fuzz_insert

What did you expect to see?
Should pass the test
What did you see instead?
...
2024-05-21T06:57:09.5460417Z fuzz test must be succeed: 0: Failed to assert: Expected value: 0.3343737, got: NULL, at /home/runner/work/greptimedb/greptimedb/tests-fuzz/src/validator/row.rs:137:13
...

https://github.com/GreptimeTeam/greptimedb/actions/runs/9170138785/job/25211918959?pr=3998
What operating system did you use?
doesn't matter
What version of GreptimeDB did you use?
main
Relevant log output and stack trace
No response

However, I didn't reproduce the bug in the standalone mode.

And another failure is reported: https://github.com/GreptimeTeam/greptimedb/actions/runs/9171698235/job/25216790287

However, I didn't reproduce the bug in the standalone mode.

I reproduced the bug by:

Hard code the FuzzInput to

FuzzInput { seed: 266, columns: 19, rows: 3995 }

Run GreptimeDB
Run

cargo fuzz run --fuzz-dir tests-fuzz -D --sanitizer=none fuzz_insert

@CookiePieWw Would you have any idea? Maybe we should sort the timestamp column + primary columns

The failure happens when there's the same timestamp and primary keys cannot be same.

Maybe we still need to sort with the timestamp column (i.g., sort with primary keys + timestamp )? For instance:
_ primary _ | ts | _value_
a, b, c, d, e, ts, v1, v2, v3
0, 0, 0, 0, 0, 1, 1, 2, 3
0, 0, 0, 0, 0, 0, 1, 2, 3
0, 0, 0, 0, 0, 3, 1, 2, 3

Ah you're right. The time index and primary keys uniquely define a row, instead of the primary keys only.

Ah you're right. The time index and primary keys uniquely define a row, instead of the primary keys only.

Yes. Would you mind helping us fix this bug👀

Yes. Would you mind helping us fix this bug👀

Sure, already working on it :)

Yes. Would you mind helping us fix this bug👀

Sure, already working on it :)

Thanks!❤


refactor: create comment for prs author

create a comment if the pull request commit is made by the pull request author. it checks if the sender of the prs synchronize event is the same as the pull request author before creating the comment. if they are not the same (e.g., maintainers pushing the commit) no comment is created.

my bad it should have been categorized as a refactor instead of feat

ready to merge


seaweek mk3 module made from mk1

Mod source
PyAE Beta
Which mod are you having an issue with?

[X] pyalienlife
[ ] pyalternativeenergy
[ ] pycoalprocessing
[ ] pyfusionenergy
[ ] pyhightech
[ ] pyindustry
[ ] pypetroleumhandling
[ ] pypostprocessing
[ ] pyrawores

Operating system

=Windows 10

What kind of issue is this?

[ ] Compatibility
[ ] Locale (names, descriptions, unknown keys)
[ ] Graphical
[ ] Crash
[ ] Progression
[X] Balance
[ ] Pypostprocessing failure
[ ] Other

What is the problem?
seaweed mk3 is made from mk1
mk2 cannot be used for anything
Steps to reproduce
No response
Additional context
No response
Log file
No response

Thanks...its fixed.


Update dependencies

As one way to address sfackler/rust-openssl#522

looks like CI is failing?

Silly me, forgot to include changes in playbot.rs. Will update

Updated

Thanks!


Add update node collection

After redefine the requirement at
https://www.pivotaltracker.com/story/show/121049511
@benbp @pscharla
@RackHD/corecommitters

@RackHD/corecommitters please review.

whoops, let me recreate one.

BUILD on-tasks #1602 : UNSTABLE
   - ** BUILD build-config-setup  #98174: SUCCESS
   - ** BUILD unit-tests  #9290: UNSTABLE
   - ** BUILD smoke-test  #3373: SUCCESS

   - ** BUILD on-taskgraph #1514: SUCCESS
      - ** BUILD build-config-setup  #98176: SUCCESS
      - ** BUILD unit-tests  #9291: SUCCESS

   - ** BUILD on-http #2536: SUCCESS
      - ** BUILD build-config-setup  #98178: SUCCESS
      - ** BUILD unit-tests  #9292: SUCCESS

BUILD unit-tests  #9290  Error Logs:

Test Name: update-node-job Should modify node collection via waterline
Error Details: expected updateByIdentifier to have been called with arguments some:test:node, { key1: { ip: "123.456.789.012", key2: { key3: "value" }, port: "12345" } }     updateByIdentifier(some:test:node, {   miscProperties: { key1: { ip: "123.456.789.012", key2: { key3: "value" }, port: "12345" } } }) => [object Promise] at UpdateNode.run [as _run] (/home/jenkins/workspace/on-tasks/build/lib/jobs/update-node-job.js:9:1357)
Stack Trace: AssertionError: expected updateByIdentifier to have been called with arguments some:test:node, { key1: { ip: "123.456.789.012", key2: { key3: "value" }, port: "12345" } }
    updateByIdentifier(some:test:node, {
  miscProperties: { key1: { ip: "123.456.789.012", key2: { key3: "value" }, port: "12345" } }
}) => [object Promise] at UpdateNode.run [as _run] (lib/jobs/update-node-job.js:9:1357)
    at spec/lib/jobs/update-node-job-spec.js:49:27
    at tryCatcher (node_modules/on-core/node_modules/bluebird/js/main/util.js:26:23)
    at Promise._settlePromiseFromHandler (node_modules/on-core/node_modules/bluebird/js/main/promise.js:510:31)
    at Promise._settlePromiseAt (node_modules/on-core/node_modules/bluebird/js/main/promise.js:584:18)
    at Async._drainQueue (node_modules/on-core/node_modules/bluebird/js/main/async.js:128:12)
    at Async._drainQueues (node_modules/on-core/node_modules/bluebird/js/main/async.js:133:10)
    at Async.drainQueues (node_modules/on-core/node_modules/bluebird/js/main/async.js:15:14)

BUILD on-tasks #1602  Error Logs:

Test Name: update-node-job Should modify node collection via waterline
Error Details: expected updateByIdentifier to have been called with arguments some:test:node, { key1: { ip: "123.456.789.012", key2: { key3: "value" }, port: "12345" } }     updateByIdentifier(some:test:node, {   miscProperties: { key1: { ip: "123.456.789.012", key2: { key3: "value" }, port: "12345" } } }) => [object Promise] at UpdateNode.run [as _run] (/home/jenkins/workspace/on-tasks/build/lib/jobs/update-node-job.js:9:1357)
Stack Trace: AssertionError: expected updateByIdentifier to have been called with arguments some:test:node, { key1: { ip: "123.456.789.012", key2: { key3: "value" }, port: "12345" } }
    updateByIdentifier(some:test:node, {
  miscProperties: { key1: { ip: "123.456.789.012", key2: { key3: "value" }, port: "12345" } }
}) => [object Promise] at UpdateNode.run [as _run] (lib/jobs/update-node-job.js:9:1357)
    at spec/lib/jobs/update-node-job-spec.js:49:27
    at tryCatcher (node_modules/on-core/node_modules/bluebird/js/main/util.js:26:23)
    at Promise._settlePromiseFromHandler (node_modules/on-core/node_modules/bluebird/js/main/promise.js:510:31)
    at Promise._settlePromiseAt (node_modules/on-core/node_modules/bluebird/js/main/promise.js:584:18)
    at Async._drainQueue (node_modules/on-core/node_modules/bluebird/js/main/async.js:128:12)
    at Async._drainQueues (node_modules/on-core/node_modules/bluebird/js/main/async.js:133:10)
    at Async.drainQueues (node_modules/on-core/node_modules/bluebird/js/main/async.js:15:14)


[GHSA-8hc4-vh64-cxmj] Server-Side Request Forgery in axios

Updates

Affected products

Comments
Help

Hi @heehaw12345, I'm not accepting this contribution because it appears to make no changes to GHSA-8hc4-vh64-cxmj. If you intended to make a change to GHSA-8hc4-vh64-cxmj but the change didn't appear, you may reopen this pull request or create a new pull request with the changes you wished to make.


Fix for #34

Restore default behavior of reboot on 5g difference and ping.
Script now defaults to reboot on ping or 5g without any .env file. Specifying a 4g band implicitly requests reboot check.
New behavior from original: specifying enbid implicitly requests reboot check (consistent with 4g).

This looks good at first glance.
I do have in my notes that both --skip-reboot and --skip-ping causes no ping to occur, which means that when logging is enabled that you get a log line with an empty string ms for latency

Looks great! Thanks for the quick fix 🙂

I do have in my notes that both --skip-reboot and --skip-ping cause no ping to occur, which means that when logging is enabled that you get a log line with an empty string ms for latency

One extra line that shouldn't have been there. I've removed it with 472469.


Add help info to commands that don't have it

I kinda forgot to do that for a bunch of them lol

will be fixed in #69


Update jsDelivr link

jsDelivr switched to a fully automated system, that can serve files from npm and GitHub. This means all future releases will be available automatically, but will use a new link structure.
I updated the link now so you don't forget to do it when you release a new version.
You can find links for all files at https://www.jsdelivr.com/package/npm/theaterjs.
Feel free to ping me if you have any questions regarding this change.

Thank you very much @LukasDrgon! 👍  The URL was pointing to a CommonJS build, which wouldn't work in the browser. I updated it with the new URL structure to the GitHub release.
Are you ok with those changes? If so, I'll merge the PR 😉

@LukasDrgon please also set dist/theater.min.js as the default file and update the link to use /npm/ instead of /gh/

@Zhouzi Thanks. You can merge the PR now.


Add first Silver sponsor to website

We have our first Silver sponsor - bump.sh ❤
Silver sponsors should also land on our asyncapi.com website
@ChristopheDujarric please provide us with SVG version of bump logo
Link to bump should be this https://bump.sh/asyncapi?utm_source=asyncapi&utm_medium=referral&utm_campaign=sponsor

/gfi js

Thanks @derberg ! Here is the logo :)


about  architecture.py->def backward_d(self)  :  in retargeting

i want to retain the retarget model use my own dataset(eg：cmu dataset).
when i use cmu dataset ,i find split_joint.py cant split the dataset into '***_m'.  so my len(characters)==1 in the retargeting/datasets/init.py
then  when the code run in architecture.py->def backward_d(self)->fake = self.fake_pools[i].query(self.fake_pos[2 - i])： i will have a error:IndexError: list index out of range
so what the mean about  "self.fake_pos[2 - i]"?

The length of self.fake_pose is 4. It stores the retargeting result as the following order: group A -> group A, A->B, B->A, B->B. 2 - i means we only take A->B and B->A for adversarial loss.

thanks a  lot !!!


Tabs don't play nicely with ng-class

Tabs component have issues when you add ng-class on the tab element.
Following chunk:
<tab ng-controller="Ctrl" ng-class="{true: 'valid', false: 'invalid'}[isValid()]"></tab>

results in:
<li ng-class="{true: 'valid', false: 'invalid'}[isValid()] {active: active, disabled: disabled}" ng-controller="Ctrl" class="ng-isolate-scope">
</li>

Have a close look to the ng-class which is improperly combined with tab's own ones.

KamBha, I support this idea. We also want to highlight the tab with invalid class if the form within it is invalid. We're using ui-views to display the form for each tab so I am not sure how to implement the suggested workaround of separate div.

+1

+1

https://github.com/angular/angular.js/issues/5695

+1

I had the same problem
 <tab ng-class="{'hide-tab':($first && $last)}" >
   //...
</tab>

but I solved that with this
 <tab class="{{ ($first && $last) ? 'hide-tab':'' }} " >
   //...
</tab>

Hey all, please see the discussion in #4172.  Using ng-class on a directive that uses replace: true is a very bad idea.  There are numerous issues around replace: true and even talk of deprecating/removing it.  But, unfortunately, it's not going anywhere soon and the caveat released by the core Angular team was that use it, but do so at your peril.  I.e., use it knowing that doing so incorrectly can break your DOM.
I suspect this issue will not be addressed.

Closing as won't support given the resolution in Angular.


Google SMTP

Hi,
I am using google smtp for my email adapter, when i try to reset my password i got some error:
{ Error: self signed certificate in certificate chain
at Error (native)
at TLSSocket. (_tls_wrap.js:1085:38)
at emitNone (events.js:86:13)
at TLSSocket.emit (events.js:185:7)
can you advice me?
Thank you

Hi, can u  edit in  smtp-adapter module  file  index.js
let transporter = nodemailer.createTransport({
...
tls: {
rejectUnauthorized: false //remove parameter and put false
}
});
and test u send mail

Hi, Thank you for your advice, but still mark as spam if i use google smtp. I waiting for approval pull request for this problem. you check compare code from master
https://github.com/lcortess/simple-parse-smtp-adapter/pull/16/commits/b18162daaceb35cf2c29331daccf4df608daa1bf


Add a CSS variable to customize the tooltip's border radius

This makes it easier to adapt the tooltip to the website's existing visual identity.

Bump :slightly_smiling_face:

Nice addition. Thanks!


node-weak issues with Electron and node 5.x

We see native crashes when using node-weak together with latest Electron version (see https://github.com/electron/electron/issues/4299).
Setup VS Code:

checkout ben/electron
git clean -xfd
scripts/npm.sh install
gulp watch
scripts/code.sh
this should start with Electron 0.37.5 just fine

Setup a workspace to reproduce the crash:

git clone https://github.com/Microsoft/TypeScript.git
I can reproduce on https://github.com/Microsoft/TypeScript/commit/94ada07
open the workspace
open lib/dom.generated.d.ts (or any other large d.ts file they have)
hover over some of the interfaces to the top (triggers language service)
open harness/runner.ts
hover over runTests to the top to trigger language service
jump back and forth between these two files (Cmd+Tab) and repeat
eventually you should get the crash (it seems to reproduce more easily after a window reload for some reason)

Things that make it not reproduce:

disabled git (somehow the git-index resources as models cause issues)
disabling node-weak
changing node-weak to always return a fresh weak reference

pushed https://github.com/Microsoft/vscode/commit/6d7880101e2dbcdf823646797fe4533b0dc439bd as an attempt to workaround the issue

I am very eager to figure out what's happening here. Despite that I checked the whys and hows of weak being in our code base and why it's a good feature it not a must. We can get rid of it without breaking API or the need of adding API. Basically, today it's used like this: Periodically we check if virtual documents are still open in any editor, iff not we check if there still usages/references in the extension host, iff not we dispose. IMO this is the nicer and more correct behaviour, but we can employ the same tactics as we do for real-documents and just dispose them as we think it's a good time - ignoring any extension host usage.
fyi @egamma

We decided to take out node-weak for now. We can revisit this by implementing our own version of weak references with officially supported API from V8.


fix for the issue #171

Fix the issue #171 by replacing
throw std::runtime_error(
with
XTENSOR_THROW(std::runtime_error,
for all files.

Thanks a lot for that fix!


GlobalStateService and Reward stale APIs

The implementation of a few API endpoints and the Reward message type has been changed:
https://github.com/spacemeshos/go-spacemesh/commit/697addae233e114e968d9c82348aad54dd873779
So this repo needs an update to represent an actual API:

GlobalStateService.SmesherRewardStream and GlobalStateService.SmesherDataQuery are deprecated: they throws an exception "UNIMPLEMENTED DEPRECATED". So let's remove them from proto files.
Reward type (that returned within GlobalStateService.AccountDataQuery/Stream endpoints) has no more SmesherID field

Changes not released within v0.2.16-beta.0 are out of scope.
@countvonzero am I missing something else?

As discussed in the linked issue/go-spacemesh repo discussion, these changes are not urgent, but it would be good to add new endpoint(s) to stream and/or query rewards from a given smesher, since the node does have this data (but it's not persisted to the mesh, not part of the protocol, and it's ephemeral since it lives in proposals and cannot be reconstructed).


Lab 2 => Step sequencing gets reset

Not sure if the intent was to create continuous sequencing or whether a new Task number is missing and the sequence was intended to restart for that task. Please apply one of these 2 fixes.

Same issue occurs again a few steps down. Please review and fix in all instances in this and other labs.

MOC Labs Review confirms this issue.

This is intended behaviour, the steps 1-15 are the steps to be reproduced whilst the Recorder is enabled, sort of separated from the actual Lab steps. In the Lab Instructions, it renders those steps as 1) 2) etc.

The final steps in the Task are numbered 16, 17 and 18. But Skillable is not picking this numbering up for some reason.

Steps 16, 17 and 18 in this case- appears to be a bug on Skillable side, I've logged a Support ticket about this. Github has 16, 17 and 18 but SKillable resets the numbering to 1, 2, 3 for those Steps.

@ephiax20 It's very confusing to both attendees and MCTs. Can the steps at least be indented correctly in the Markdown? Use different numbering scheme, such as a), b), c) etc., or i) ii) iii)? I think some kind of a separation is appropriate for this scenario.
Plus in platforms like Skillable these extra steps lack checkbox tracking.


Add stats and analysis for using mixins and gzip filesize

Using mixins for this case is usually left out because it compiles repetitive code. However, when compiled and squashed with gzip, mixins produce small file sizes when compared to @extend solutions.
This is particularly relevant because I don't think that basic CSS painting really has much of an impact on the perceived speed of a website as file download times.

Good catch, thank you!

Guess the usefulness of this has passed 😄


Brotli compression

I recently came to know Brotli which is found to compress files to a lesser size when compared to gzip compression.
Do we have Brotli compression in razzle which I can use in a react project hosted on node?
I know the support for it not for all browsers, but I would like to understand if I can compress my binaries using brotli because of its good compression techniques.

hello @gsharath, read this
https://codeburst.io/express-brotli-webpack-a60773e7ec6c
this will help you to do it :)


Showing Team Score on /team/{team-slug}

The overall score of the team should be visible!

Do you want to work on it? :)

yes i would like to try

Go for it :)


Feature/photos sorted include download links

Match signature with getPhotos method
Add method overloading for includeDownloadLinks argument
Add networkBucketId to the Photo item

Codecov Report

Merging #131 (9a6f00a) into master (3c43bb2) will not change coverage.
The diff coverage is 33.33%.

@@           Coverage Diff           @@
##           master     #131   +/-   ##
=======================================
  Coverage   75.17%   75.17%
=======================================
  Files          39       39
  Lines         866      866
  Branches      107      107
=======================================
  Hits          651      651
  Misses        202      202
  Partials       13       13

Impacted Files
Coverage Δ

src/photos/types.ts
100.00% <ø> (ø)

src/photos/photos/index.ts
20.51% <33.33%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Add copyWithin and slice functions to TypedArray

The algorithm's are based on ECMA-262 v6, <IP_ADDRESS> and <IP_ADDRESS>
Co-authored-by: Tibor Dusnoki<EMAIL_ADDRESS>JerryScript-DCO-1.0-Signed-off-by: Adam Szilagyi<EMAIL_ADDRESS>

Did some update, but im currently working on the other requests.

Did the missing changes.


Adding support for RAR 5.0 format

Hey, I really like this projcet and I've studied a bunch of the RAR format lately. I've tried using your package on a rar5 file and realized it didn't work because, well, there's a few main changes in parsing 5.0 files. The spec is https://www.rarlab.com/technote.htm, but honestly reading the unrar source is a little easier.

CRC-32 instead of CRC-16, meaning the CRC parts of headers are 4 bytes, not 2 anymore.
The order is different. They kept the "old" rar4.0 order in the signature aka magic bytes for obvious reasons.
There is not a fixed size for anything except for the CRC signatures - you read seven bits from a byte, and the top one says if to read more or not. Not difficult to implement, just very different.
The signature is one more byte longer (not the fixed string, anymore, there's an extra 0x01)

This is not a feature request, more of an announcement that I'll be adding the support for it. It should be also automatically detectable from the first 7 bytes due to different signatures. As said, kudos to you, really cool projet and good work. I'll try to work on it as much as I can. Not that interested in making it browser-ready, but I've thought about adding stremio support (with a similar system to rar-http).

Cool, thanks for letting me know, should be fairly simple to write a new set of header parsers. I'm afraid I don't have the time at the moment but feel free to submit a PR and I can guide you on the way.
Thanks for the kind words 🤘

bump, we hit this case recently too..

@DoggoKt oh, i just saw you said "but I've thought about adding stremio support (with a similar system to rar-http)", so i guess we are working for the same goal 😅

@jaruba Oh hey. I'm still working on the RAR5 parsing, I have about 20 commits not pushed. Lot of them are also just fixes and little tweaks to the main source code. It should be integrated and of course backwards-compatible so if you're up to adding features, feel free :)
Cheers!

@DoggoKt i am very limited in my understanding of the archive related logic an RAR5, i can tell you where i am at after a very long time:

we can stream a video file from a nntp engine (usenet) with range support (so seeking works with the video)
we can stream RAR files (but not RAR5) and multi-part (through a nntp engine or http)
we can (probably) stream zip files (no multi-part support) and without range support (no video seeking) through nntp or http(s)

i think that my conclusion months ago is that there is a technical limitation to range requests for zip streams, but i am not knowledgeable enough in the field to ever be sure, i have found some cases of zip and multi-part 7z on usenet too
i have also player around a bit with par2 parchive parsing and verification, maybe repairs too
i have implemented multi-server support for usenet, so if a chunk is missing a backbone would be used..
there is a lot of refactoring to be done, but RAR5 which seems pretty common is probably the biggest roadblock for Stremio atm

Oh damn, streaming multi-part files is something I'd absolutely appreciate. Ideally I'd connect with real-debrid since that opens the biggest amount of sources. I'll work on the RAR5 and I'll ping you in the upcoming pull request. Very interested in how this will end up!

Am 4. 12. 2024 um 20:25 schrieb Alexandru Branza @.***>:

@DoggoKt i am very limited in my understanding of the archive related logic an RAR5, i can tell you where i am at after a very long time:
we can stream a video file from a nntp engine (usenet) with range support (so seeking works with the video)
we can stream RAR files (but not RAR5) and multi-part (through a nntp engine or http)
we can (probably) stream zip files (no multi-part support) and without range support (no video seeking) through nntp or http(s)
i think that my conclusion months ago is that there is a technical limitation to range requests for zip streams, but i am not knowledgeable enough in the field to ever be sure, i have found some cases of zip and multi-part 7z on usenet too
i have also player around a bit with par2 parchive parsing and verification, maybe repairs too
i have implemented multi-server support for usenet, so if a chunk is missing a backbone would be used..
there is a lot of refactoring to be done, but RAR5 which seems pretty common is probably the biggest roadblock for Stremio atm
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.


Limiting To/Displaying Set Range of Days

-- using version 7.1.5 ---
Is it possible for me to display a calendar for a range of dates?
My goal is to show a user a 10 day calendar from a given date (i.e. May 2nd - May 12th).
I tried configuring in the configureCalendar method with the start/endDate parameters for the case above, but I'd receive cells for all days within May. I'm also wondering if there'd be any issue for instances like May 29th - June 7th in terms of generating the in/out dates.
Below are my parameters I setup in the configureCalendar method:
let parameters = ConfigurationParameters(startDate: startDate, endDate: endDate, numberOfRows: 2, calendar: nil, generateInDates: .off, generateOutDates: .off, firstDayOfWeek: nil, hasStrictBoundaries: false)

This is the final update to this calendar and is already in the bucket list for an update.

Ah I see...is this update available anytime soon or are there any suggested workarounds?
Any guidance is appreciated!

There is a work around i like to call Boundary-dates
but it works better with single row calendars. Ive never tried double row calendars.
it is mentioned here -> https://github.com/patchthecode/JTAppleCalendar/issues/365

Thanks for the reply, I'm admittedly trying to understand how I'll be able to incorporate #365 as a workaround.
My hope is to be able to show on load an unscrollable 2-week calendar displaying a specified day range (i.e. 4th-18th) and pre-selected cells that can thereafter be manually selected/deselected.
Any guidance/available tutorial would be appreciated, or if there's anything more I can supply I will try to!

If you want your calendar to be unscrollable, then #365 will not be of any help to you.
Maybe if you show me a screen shot of how your unscrollabe calendar with the range should look, then i can help further.

I was able to resolve for my needs.

awesome 🍻


using of the asm feature to improve the performance of basic functions

PR uses rust-lang/compiler-builtins#365 to improve the performance
fix broken CI and build the bootloader on windows correctly

bors r+

bors retry

bors retry

bors retry


Testimonial Section updated.

I have changed the testimonial section.
https://github.com/Anupkjha2601/food-recipes-website/assets/132778037/31b05088-4219-4957-b7e2-43ded5da816c
please , lemme know if you wanna any other changes.

Hello @Pragati-3003 your pull request have some conflict in css/style.css
index.html  so please resolve it.

Hello @Pragati-3003 your pull request have some conflict in css/style.css index.html so please resolve it.

Hey @Anupkjha2601 , I have resolved all the merge conflicts , please check and merge the PR.


xi18n should parse index.html and build should fill in the translated texts in index.html

Versions
Angular CLI: 1.6.0
Node: 8.9.1
OS: darwin x64
Angular: 5.1.0
... animations, common, compiler, compiler-cli, core, forms
... http, platform-browser, platform-browser-dynamic, router
... service-worker

@angular/cdk: 5.0.0
@angular/cli: 1.6.0
@angular/material: 5.0.0
@angular-devkit/build-optimizer: 0.0.35
@angular-devkit/core: 0.0.22
@angular-devkit/schematics: 0.0.41
@ngtools/json-schema: 1.1.0
@ngtools/webpack: 1.9.0
@schematics/angular: 0.1.10
@schematics/schematics: 0.0.10
typescript: 2.4.2
webpack: 3.10.0

Repro steps

in index.html, use the i18n marker like please wait...
run ng xi18n
the 'please wait' does not popup in the gererated .xlf files
run ng build ng build -prod --aot --output-path=dist/de --base-href /de/ --i18n-file=src/i18n/messages.de.xlf --i18n-format=xlf --locale=de;

Observed behavior
<!-- Normally this includes a stack trace and some more information. -->

Desired behavior

ng xi18n operates over components of your Angular application, but index.html is not part of it actually. It's not a component template.
I don't think this is functionality we can provide but @ocombe might know more.

wel, the entry and name index.html are in the .angular-cli.json. Also, the cli can inject the base href using the --base-href switch

it will be possible as part of universal (it's on the roadmap)

If I can't use server rendering, is there a plan to inject translated string in index.html or other static file ?

if parsing the index.html would be possible, we could also set the right language attribute in the HTML-tag.

What's the status on this? I'm trying to set up locale-specific index.html to change some tags specific to the locale, like the title, the HTML lang attribute, canonical link, and others, but can't rely on the i18n translation.
Was trying to make multiple index.html files, 1 per locale, but when I run with --localize flag it ignores the angular.json config about which index.html to use.
Looks like this, building with --configuration=es-CO works, but using --localize to build all locales at once doesn't work, I think I might have to file a bug:

#17684 was closed because including the index.html in the localization process would be a better solution than providing a way to compile multiple configurations at once, or providing the i18n a way to configure the index.html to use for each locale.
For now, working around it by creating a configuration for each locale and building all of them through gulp script in series.

Has there been any updates regarding this issue? It would be a great improvement being able to translate the index.html

Yes, I also have such wish in a project on Angular 11. Is it exists a solving way?

We need this feature to specify i18n og-meta tags in index.html.
Use case would be a customer application where customers must always log in BUT can receive e.g. an invoice link using WhatsApp that goes to the page that displays the invoice for the user. Company would send a link using WhatsApp and user would

click on the link in WhatsApp
log in (if not already)
Web application opens the page and users can see the invoice

A very basic use case in 2022 and we of course need this to be language specific to have a nice description, title and icon in WhatsApp
Angular should have a feature for this use case in 2022:
<meta property="og:description" i18n-content="@@og.description" content="Welcome to the customer application of AweSomeCompany. " />
As others have stated: seems like the Angular CLI could easily process the index.html and put the correct value in there as its a valid uses case using i18n.
Is there an Angular way, an official Angular workaround way of doing this or is this use case not going to be recognised?
Adding @AndrewKushnir as he seems to be in charge of i18n at Angular.
Thanks.

Would also like to see this so we can translate our noscript message.

Can this feature request be re-evaluated?
For us this would be really useful so we can set different script url's for different languages.
Currently there is no proper way of doing this.

I also just stumbled over this and would greatly appreciate a fix.

I think the i18n configuration of the angular.json should be extended. Consider the following use-case:
We're building a website which is targeted for a specific country. It has some features that only make sense for people who can speak the language of that country. So we'd like to drop some functionality (at compile-time!) from the other localized versions of the app. This would be possible with an environment-like setup (with file replacements) and use a compile-time constant to conditionally import that module.
However, as it was discussed before, the current localization process is not designed in a way that it can re-build the app for different locales. (Technically this issue is similar to https://github.com/angular/angular-cli/issues/17684)
We've tried the configuration-way: instead of providing the --localize flag in the CLI, we created multiple configurations that set the appropriate locale. However, when the build starts, the output directory is cleared which makes this approach uncomfortable (the built version for locale A must be copied somewhere else before the build is started for locale B).
Is there any plan to extend the i18n system?


Add time-utc scale, similar to d3.time.scale.utc

Tested locally by modifying src/example/plot/time-chart.js to use time-utc.

Looks good to me.


⚠ Jenkins Plugins Artifactory has degraded performance

In 2fd2c85, Jenkins Plugins Artifactory (https://get.jenkins.io/plugins/artifactory/) experienced degraded performance:

HTTP code: 200
Response time: 1329 ms

Resolved: Jenkins Plugins Artifactory performance has improved in 2e469f4 after 12 minutes.


ruff with --diff exits 0 on errors with no diffs

Using --diff flag with no possible changes seems to result in a 0 exit code and no message (or error), regardless of whether there are errors, formatting changes, and whether or not those are fixable. While these may not be intended to be used together (and while it is noted that --diff implies --fix-only, it wasn't immediately obvious that this behavior would happen since the docs mention reporting, but not exit status), I came across a situation where someone had used --diff and --fix together -- see https://github.com/python-semantic-release/python-semantic-release/pull/961 and https://github.com/python-semantic-release/python-semantic-release/pull/957
To me, the expected behavior would be to have a way for the tool to still exit non-0 if any findings are present. If the flags are not expected to be used together, an error to that effect (and non-0 exit) would also be fine.
Note that --diff on its own does have the expected behavior
I think maybe part of the issue is that ruff --diff is only exiting 1 if there is a diff, which is maybe sensible, just confusing in this case. Maybe we need a --exit-non-zero-on-error as well as the existing --exit-non-zero-on-fix flag and / or a clarification on this point in the docs for --diff?
I'm not sure what the person who set this [the pipeline above] up originally thought / wanted, but presumably they wanted to both print the changes, if any, that would be made by ruff --fix and track whether any findings came up.

List of keywords you searched for before creating this issue. Write them down here so that others can find this issue more easily and help provide feedback.

"diff"
"diff fix"

A minimal code snippet that reproduces the bug.

import os.path as OSPATH

is_path = OSPATH.isdir("/tmp")
print(f"Hello world {is_path}")

The command you invoked (e.g., ruff /path/to/file.py --fix), ideally including the --isolated flag.

$ ruff check test_ruff.py --diff --fix --output-format=full --exit-non-zero-on-fix
$ echo $?
0
$ ruff check test_ruff.py --diff --fix
$ echo $?
0

The current Ruff settings (any relevant sections from your pyproject.toml)
Not sure if it's strictly necessary, but for the above to work, a rule that will trip and won't trigger any diff (e.g., N812) has to be enabled.

[lint]
select = ["N812"]

The current Ruff version (ruff --version).
ruff 0.4.9

Thanks for opening this issue and also creating a PR to improve the documentation.
We share your sentiment that --diff is confusing and we have a few ideas on how to improve the usability but haven't had time to implement it:

Change the default output format to show fixes.
Introduce a new ruff fix command that only applies fixes. Remove the --diff option from ruff --check. I think this should remove the confusion that you're experiencing because it's then more clear that fix should only fail if fixing failed, not if there are any other unfixed violations.

That makes sense, thanks! It took a few passes for me to untangle the layers here, hence all the edits. The behavior wasn’t quite what I originally would have expected, but it all makes sense to me now.
I agree that a separate subcommand could work, though the feature of being able to check and fix in one pass is convenient for things like pre-commit hooks, even if ruff is fast enough that running twice in and of itself shouldn’t normally matter.
Happy to either keep this open or close it as you like.

I agree that a separate subcommand could work, though the feature of being able to check and fix in one pass is convenient for things like pre-commit hooks, even if ruff is fast enough that running twice in and of itself shouldn’t normally matter.

We consider to keep ruff check --fix but without the --diff option and the default output-format would show the fixes (at least for the diagnostics for which no fixes exist)
I'll keep it open because it helps us prioritize (knowing that this is something user actually ran into)


Not compatible with the Agar Extended Chrome extension.

Can you make them be able to work together?

I dont think you can easily run two different scripts at the same time, right?
You would have to manually add into this script the things you want, it shouldnt be too hard to find the different add ons(Im assuming showing mass and different color depending on size?) in different mods elsewhere.

Doing something like that is beyond the scope of the project.


Source sampling executable

Adds an executable called source_generator to allow an initial_source.h5 to be created without having to run a full OpenMC simulation.
This approach utilises the same OpenMC commands that would be run when running within the simulation. In particular:

calculate_work
allocate_banks
initialize_source

It also controls the settings needed to generate the initial source, allowing the user to specify the number of particles to sample, the output path, the verbosity, and the location of the source library (e.g. as built by the parametric plasma source). The run mode is fixed to eigenvalue, as this is the only OpenMC mode that generates the initial source output file, and the write initial source setting is fixed at true so that the output is always generated.
I've also included updates to the README to describe the build and run process.

Sorry @DanShort12 can you rebase, then ill get this merged.

Rebased and cmakified.

Does anyone else get this error when trying python setup.py install
  File "setup.py", line 8, in <module>
    from parametric_plasma_source.build_python import build as build_python
  File "/home/jshim/parametric-plasma-source/parametric_plasma_source/__init__.py", line 2, in <module>
    from .plasma_source import PlasmaSource
ModuleNotFoundError: No module named 'parametric_plasma_source.plasma_source'

That appeared to help somewhat but not quite fully there with the setup.py, latest error ...
running develop
running egg_info
writing parametric_plasma_source.egg-info/PKG-INFO
writing dependency_links to parametric_plasma_source.egg-info/dependency_links.txt
writing top-level names to parametric_plasma_source.egg-info/top_level.txt
reading manifest file 'parametric_plasma_source.egg-info/SOURCES.txt'
writing manifest file 'parametric_plasma_source.egg-info/SOURCES.txt'
running build_ext
CMake Error at CMakeLists.txt:43 (add_subdirectory):
  The source directory

    /home/jshim/parametric-plasma-source/pybind11

  does not contain a CMakeLists.txt file.

CMake Error at CMakeLists.txt:45 (pybind11_add_module):
  Unknown CMake command "pybind11_add_module".

-- Configuring incomplete, errors occurred!
See also "/home/jshim/parametric-plasma-source/build/temp.linux-x86_64-3.7/CMakeFiles/CMakeOutput.log".
Traceback (most recent call last):
  File "setup.py", line 84, in <module>
    "Operating System :: OS Independent",
  File "/home/jshim/anaconda3/lib/python3.7/site-packages/setuptools/__init__.py", line 144, in setup
    return distutils.core.setup(**attrs)
  File "/home/jshim/anaconda3/lib/python3.7/distutils/core.py", line 148, in setup
    dist.run_commands()
  File "/home/jshim/anaconda3/lib/python3.7/distutils/dist.py", line 966, in run_commands
    self.run_command(cmd)
  File "/home/jshim/anaconda3/lib/python3.7/distutils/dist.py", line 985, in run_command
    cmd_obj.run()
  File "/home/jshim/anaconda3/lib/python3.7/site-packages/setuptools/command/develop.py", line 38, in run
    self.install_for_development()
  File "/home/jshim/anaconda3/lib/python3.7/site-packages/setuptools/command/develop.py", line 140, in install_for_development
    self.run_command('build_ext')
  File "/home/jshim/anaconda3/lib/python3.7/distutils/cmd.py", line 313, in run_command
    self.distribution.run_command(command)
  File "/home/jshim/anaconda3/lib/python3.7/distutils/dist.py", line 985, in run_command
    cmd_obj.run()
  File "setup.py", line 26, in run
    self.build_extension(ext)
  File "setup.py", line 56, in build_extension
    env=env
  File "/home/jshim/anaconda3/lib/python3.7/subprocess.py", line 363, in check_call
    raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['cmake', '/home/jshim/parametric-plasma-source', '-DCMAKE_LIBRARY_OUTPUT_DIRECTORY=/home/jshim/parametric-plasma-source/parametric_plasma_source/', '-DPYTHON_EXECUTABLE=/home/jshim/anaconda3/bin/python', '-DCMAKE_BUILD_TYPE=Release']' returned non-zero exit status 1.

Couple of issues with building on a clean environment... all the more reason to get CI working! Thanks for trying it out @Shimwell - can you try again when you get a mo and let me know if it's working now?

oh wow it looks like it works, that is a fancy setup.py it clones  git repos automatically and builds things.

I shall continue to test, I'm not sure if this will need some more changes to get it working on the pypi repo but let me tinker for the day

Pretty sure it is likely to need a bit of tinkering for the PyPI repo but appreciate if you get a bit of time to try it out IRL (my poking has mostly been theoretical). I can rummage to try to find my script to read the initial_source.h5 into matplotlib scatter plots if that might help.

Oh, and the setup.py magic is in the interplay between the build and the CMakeLists.txt file - if you fancy a look through that file. The last bit of tinkering was to add some git commands into that CMake file.
Since the bindings are compiled, we'll need a bit of a think about how to package them for PyPI... they will be compile and Python version dependent.

Perhaps this is just me but the ./source_generator --output is behaving slightly strangely
This command
 ./source_generator -l test.so -o test.h5
prints this to the terminal
 Number of particles: 1000
 Source library: test.so
 Output path: test.h5
 Verbosity: 5

but then makes a .h5 file called test.h5initial_source.h5
So it might be appending initial_source.h5 to every output filename

I've been tinkering and made some plots to show the plasma source with a few parameters chaining. I only tried the 4 shaping parameters (elongation, major_radius, minor_radius, triangularity) at the moment. I got stuck on shafranov_shift which appeared to have no impact on the plasma. But I need to check I'm doing everything correctly to be certain.

Thanks @Shimwell, looks great! Just a suggestion, but the plots might be easier to interpret if they have some text in the corner to show what variable is changing and what the value being used is for a given frame (I know it's possible to deduce the variable from how the plot changes but that requires a little bit of bonus thought).

Hmm shafranov shift should shift the equator radially outwards IIRC. Looking at the code as long as you’re using the sample source function it should work fine, if you short cut it and go some other route that avoids convert_rad_to_rz then you’ll not get the shift.
On 30 Jul 2020, at 17:23, Jonathan Shimwell <notifications<EMAIL_ADDRESS>wrote:
I've been tinkering and made some plots to show the plasma source with a few parameters chaining. I only tried the 4 shaping parameters (elongation, major_radius, minor_radius, triangularity) at the moment. I got stuck on shafranov_shift which appeared to have no impact on the plasma. But I need to check I'm doing everything correctly to be certain.
[minor_radius]https://user-images.githubusercontent.com/8583900/88947809-fa99f380-d288-11ea-876a-735a4036b045.gif
[triangularity]https://user-images.githubusercontent.com/8583900/88947821-038ac500-d289-11ea-8614-7d3ee05f7130.gif
[major_radius]https://user-images.githubusercontent.com/8583900/88947788-f1a92200-d288-11ea-889d-1a1bfe968b65.gif
[elongation]https://user-images.githubusercontent.com/8583900/88947769-ea821400-d288-11ea-84a3-39fb8a98de07.gif
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHubhttps://github.com/makeclean/parametric-plasma-source/pull/3#issuecomment-666504346, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AASTUSXSQDKIPJUEU54R62TR6GNADANCNFSM4OCRWMFQ.

Congrats on the recent OpenMC merge
https://github.com/openmc-dev/openmc/pull/1623

@Shimwell, this PR should now support passing the source parameters into the source_generator executable. Hope that's a useful addition!

Sorry to be a pain is there any chance this PR can be redirect to the new repository
https://github.com/open-radiation-sources/parametric-plasma-source
@DanShort12

Superseded by open-radiation-sources/parametric-plasma-source#2


Draft: multiple import source (e.g. DOI -> Crossref, DataCite)

This is what the University of Bamberg uses (https://fis.uni-bamberg.de) to look up DOIs specified by the user for import in both the Crossref registry and the DataCite registry, in parallel. Other institutions have expressed an interest in it (@pnbecker) so it's probably best put here. No specific tests yet.
This source can be specified just once, replacing the Crossref and DataCite sources by a single entry.
Code mostly by @johannastaudinger.
References
Add references/links to any related issues or PRs. These may include:

Fixes #issue-number (if this fixes an issue ticket)
Related to DSpace/RestContract#pr-number  (if a corresponding REST Contract PR exists)

Description
Adds a new external source which can be configured to query multiple existing sources simultaneously, returning results from either.
Instructions for Reviewers
This is currently in draft state: no specific tests yet.
List of changes in this PR:

the main code: MultipleParallelImportMetadataSourceServiceImpl.java
configuration examples for the DOI use case

Checklist

[x] My PR is small in size (e.g. less than 1,000 lines of code, not including comments & integration tests). Exceptions may be made if previously agreed upon.
[ ] My PR passes Checkstyle validation based on the Code Style Guide.
[ ] My PR includes Javadoc for all new (or modified) public methods and classes. It also includes Javadoc for large or complex private methods.
[ ] My PR passes all tests and includes new/updated Unit or Integration Tests based on the Code Testing Guide.
[ ] If my PR includes new libraries/dependencies (in any pom.xml), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
[ ] If my PR modifies REST API endpoints, I've opened a separate REST Contract PR related to this change.
[ ] If my PR includes new configurations, I've provided basic technical documentation in the PR itself.
[ ] If my PR fixes an issue ticket, I've linked them together.

@philipprumpf : Thanks! Pulling this over to the 8.0 board for more eyes, as it's definitely a new feature.  Could you please add some steps on how to manually verify this is working?  I'm assuming maybe importing via DOI suddenly searches two locations?
If it's easier to show via screenshots, that's good too.  I know it's likely that our testers/reviewers will need more info on how the behavior changes with this PR installed.

@philipprumpf is this related to #8674?

Screenshots from https://github.com/philipprumpf/DSpace/tree/pr-9132 , which is this PR + #9203 .
How this is supposed to work is that a new import source shows up which is currently unlabelled but should probably be labelled "DOI" in practice:

Entering a Crossref DOI yields a result:

Entering a DataCite DOI yields a result:

Nonsense yields no results:

This is in contrast to the individual Crossref / DataCite sources, which return results only for their respective DOIs.

Thanks @philipprumpf for this PR and sorry for my late review (a bit of confusion over two similarly named PRs!)
I am +1 pending the i18n label added. I agree that DOI searches tend to be the most consistent and accurate across all sources (even though some support keywords as noted by @tdonohue ) so giving that hint in the label is a good idea.
Note, searching for a full DOI URL doesn't give very good results compared to just the identifier string -- however, since this contribution does not concern itself with how each provider handles the queries and simply passes the query onto them, I think that is feedback for future improvements to the individual (DataCite, Crossref, etc) providers, not this PR.

Thank you @kshepherd and @tdonohue . I've got a local branch addressing Tim's comments, but had a hard time merging it yesterday. I'll have another go today.


Update readme notes about secret management supported env vars names

Signed-off-by: Salimane Adjao Moustapha<EMAIL_ADDRESS>

Codecov Report

Merging #54 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #54   +/-   ##
=======================================
  Coverage   84.42%   84.42%
=======================================
  Files           9        9
  Lines         854      854
=======================================
  Hits          721      721
  Misses        133      133

Impacted Files
Coverage Δ

src/lighter/secretary.py
93.22% <ø> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 50c7a08...0022732. Read the comment docs.


Incorrect automatic assessment

Describe the bug
When assessing the Analysis Object Model, some parts of the submission are wrongfully awarded points. Also there is some false Feedback that isnt represented by the example Solution.
To Reproduce

Go to H02E02 Bumpers Analysis Object Model
Start Assessing Submissions
Find the following errors:

Expected behavior

If in doubt the system should not be using automatic assessment, when it creates double the work for the user: user has to remove the wrong feedback/points and then he can start assessing.
Screenshots

in contrast to:

Are those maybe coming from the example submissions that you must do before one can start assessing submissions?
Environment

 - OS: [Windows]
 - Browser [chrome]
 - Version [81.0.4044.138 ]

Additional context

Output in Web Console

  [REPLACE THIS WITH YOUR INFORMATION]

Imo the main reason for this issue is wrong input by tutors. It would be beneficial to have a 'clear assessment' button which just removes the whole automatic assessment (in the beginning, when I was the only one assessing, it worked really good - in the end, I was constantly removing the whole 'auto-assessment' stuff).

we are changing how the automatic assessments for modeling exercises work


test(iroh-blobs): comment out ignored test (that is not a flaky test)

Description
There's this test that was introduced in the local_pool PR.
It was ignored via #[ignore = "todo"]. Notably, it's not flaky, it always fails.
Our flaky tests are run with cargo nextest run --run-ignored all [...]. We can't be more specific with the ignored tests. The only options are default, ignored-only and all.
This kind of test is really hard to write. IIUC, #[should_panic] can only test for the panic happening in the thread that the test is initiated in, it doesn't detect panics that are thrown in threads spawned from the test. I assume this is the reason writing this test was abandoned.
Keeping this test with the #[ignore = "todo"] on it means we're always running it in our flaky test suite, which is confusing. We thought this test was flaky, but it's not. IMO it's better to comment it out/remove it than to pollute our flaky test results.
Breaking Changes
None
Notes & open questions
In this PR I'm commenting this test. Should we remove it instead?
Or do people have ideas on how to make this test work?
Do we have an idea what we're expecting of our LocalPool implementation? Should a panic on one of the threads cause a panic in the finish() function?
Change checklist

[X] Self-review.
[ ] Documentation updates following the style guide, if relevant.
[ ] Tests if relevant.
[X] All breaking changes documented.

The irony of a new flaky test keeping this PR from being merged :upside_down_face:


Fix image selection in variants

I want to merge this change because... Resolves #4205

Screenshots

Pull Request Checklist

[ ] Privileged views and APIs are guarded by proper permission checks.
[ ] All visible strings are translated with proper context.
[ ] All data-formatting is locale-aware (dates, numbers, and so on).
[ ] Database queries are optimized and the number of queries is constant.
[ ] Database migration files are up to date.
[ ] The changes are tested.
[ ] The code is documented (docstrings, project documentation).
[ ] GraphQL schema and type definitions are up to date.
[ ] Changes are mentioned in the changelog.

Here is the report for 4df058f71117ffd349a2e31df27fdbe7e29498b6 (mirumee/saleor @ fix-image-selection-in-variants)
Base comparison is 7a94b1790ef6869982708c36186a71590f8e23df.
No differences were found. (click me)

# api.benchmark checkout
  test name                           	left count 	right count
  ------------------------------------	-----------	-----------
  add billing address to checkout     	         41	         41
  add shipping to checkout            	          7	          7
  checkout payment charge             	         16	         16
  complete checkout                   	          6	          6
  create checkout                     	         45	         45

# api.benchmark homepage
  test name                           	left count 	right count
  ------------------------------------	-----------	-----------
  retrieve main menu                  	          5	          5
  retrieve product list               	          4	          4
  retrieve secondary menu             	          5	          5
  retrieve shop                       	          2	          2

# api.benchmark product
  test name                           	left count 	right count
  ------------------------------------	-----------	-----------
  product details                     	         16	         16

# api.benchmark variant
  test name                           	left count 	right count
  ------------------------------------	-----------	-----------
  retrieve variant list               	         13	         13


Syntax highlighting

Add IDE support for RPG with syntax highlighting.

A first version of a VS Code plugin has been made.

b9d791510aa0aaf79d7538abb12578c03723933c

There's a lot of IDE's and I'm not going to do all of them, so if you use a different IDE and want syntax highlighting, feel free to open a pull request!


"/bin/sh: 1: p4: not found"

oot@ubuntu-4gb-ash-1:/home/perforce-commit-discord-bot# python3 app.py
/bin/sh: 1: p4: not found
I'm wondering if you could help me with this?

wrong repo


Validate sync function do nothing

From documentation:

Sync functions return either an error object or null.

The following validation function do nothing.
function messageValidator(values) {
  return new Error('Error message');
}

Promise functions should throw on an error.

Throw on an error or reject with an error object?

The following validation function do nothing.

This is an unfortunate misunderstanding about what 'error object' means. In this case it means a typical set of messages for the UI in the format { name: 'Already used.', age: 'Must be over 18' }.

Throw on an error or reject with an error object?

You can reject with
reject(new errors.BadRequest('Values already taken.', { errors: errs }));

or throw that error.

The 'error object' confusion is clarified in the auk release docs.