Telemetry Fishish

#415 / #456

Pull Request Test Coverage Report for Build 68526e3450070c2c1143f6a1c002a24811fc6457-PR-457

2 of 2 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 87.2%

Totals

Change from base Build e922d4a445542e9d5b86c9208383c2d518ee5858:
0.0%

Covered Lines:
327

Relevant Lines:
375

💛  - Coveralls

Pull Request Test Coverage Report for Build 68526e3450070c2c1143f6a1c002a24811fc6457-PR-457

2 of 2 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 87.2%

Totals

Change from base Build e922d4a445542e9d5b86c9208383c2d518ee5858:
0.0%

Covered Lines:
327

Relevant Lines:
375

💛  - Coveralls


Dashboard does not update on deploy via http request

Current Behavior
The background color (and other theme options) of the dashboard do not update, when the flows are redeployed via a http request.
Expected Behavior
Nodes and flows are updated when I redeploy the flows file via http request. I expect the background color of the dashboard to update as well.
Steps To Reproduce

Create a flow with a dashboard
Deploy the flow
Copy the flows.json file from ~/.node-red/flows.json
Make a modification to the colors of the theme, e.g. change the colors of the light theme (make sure the theme is selected)
Make a post request to upload the flows with the modified file
Find, that the menu on the editor screen did change the color of the theme, the dashboard itself has not. You can restart the Raspberry or restart Node Red without any effect. The correct colors of the dashboard will load, if you edit a node in a flow e.g. move it, and then redeploy via the web editor.

Example flow
[
    {
        "id": "be9d72fa43478ae3",
        "type": "tab",
        "label": "Flow 1",
        "disabled": false,
        "info": "",
        "env": []
    },
    {
        "id": "1682d3b5eb19fa05",
        "type": "ui_button",
        "z": "be9d72fa43478ae3",
        "name": "",
        "group": "1054cccc6d7a0bb4",
        "order": 0,
        "width": 0,
        "height": 0,
        "passthru": false,
        "label": "button",
        "tooltip": "",
        "color": "",
        "bgcolor": "",
        "className": "",
        "icon": "",
        "payload": "",
        "payloadType": "str",
        "topic": "topic",
        "topicType": "msg",
        "x": 470,
        "y": 160,
        "wires": [
            []
        ]
    },
    {
        "id": "1054cccc6d7a0bb4",
        "type": "ui_group",
        "name": "Standard",
        "tab": "a1c60ce5fd3bb81d",
        "order": 1,
        "disp": true,
        "width": "6",
        "collapse": false,
        "className": ""
    },
    {
        "id": "a1c60ce5fd3bb81d",
        "type": "ui_tab",
        "name": "Home",
        "icon": "dashboard",
        "disabled": false,
        "hidden": false
    }
]

Environment

Node-RED version: 3.0.2
Node.js version: v16.17.0
npm version: 8.15.0
Platform/OS: mendel linux on google coral dev board
Browser: firefox on mac os

Hi @MxFxM
I guess you are referring to the node-red-dashboard nodes here? They are not part of the core of node-red, so not something we can fix in this repo.
I'll transfer this over to the node-red-dashboard repo where it can be looked at.


python310Packages.pydantic: fix cross compile

Description of changes
Make the doc build optional, and disable for cross builds.
Doesn't trigger any rebuilds for native platforms.

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 181311 run on x86_64-linux 1

This looks good to me!
Verified with:
nix build github:squalus/nixpkgs/pydantic#pkgsCross.aarch64-multiplatform.python3Packages.pydantic


HeaderValue::from_str does not validate that the string is valid ascii

The documentation of HeaderValue::from_str says that:
https://github.com/hyperium/http/blob/abe651273f4cf19cf9a247f376e9ece85becc722/src/header/value.rs#L101-L104
So I would expect this function to return an error when I pass it a non-ascii utf8 string which contains byte values in the 128-255 range. However the result is success.
Playground link
let x = http::header::HeaderValue::from_str("ñ");
panic!("{:?}", x);

thread 'main' panicked at 'Ok("\xc3\xb1")', src/main.rs:3:5

Good catch, this does seem like a "bug".

I disagree, the documentation should be changed instead. Header values are allowed to contain non-ASCII bytes, it's just control characters (with the exception of HTAB) that are disallowed.
Since every ASCII byte in a UTF-8 string is an ASCII char (multi-byte UTF-8 chars cannot contain bytes that look like ASCII), we should just relax this restriction and say that ASCII control characters with the exception of HTAB are disallowed and everything else is valid. This means the implementation stays the same (as that's what it's already doing).

What's more, I would argue that from_static() should also allow non-ascii chars (and the documentation fixed, right now it says it allows 32-127 but it actually disallows 127 and allows 9), and to_str() should also stop limiting itself like this. I'm going to file a separate issue on the latter, but from_static() seems reasonable to cover here as "make it behave like from_str does".

Filed as #527. So to summarize:

from_str is implemented correctly already and just needs a documentation update.
to_str should be changed as per #527 to be just std::str::from_utf8()
from_static should match from_str (it should test is_valid instead of is_visible_ascii).
Documentation should be vetted to ensure all descriptions of valid bytes are correct, i.e. that they allow 9 (\t) and disallow 127.

At this point the only use left of is_viisble_ascii is in the Debug impl. That's not a big issue as this is just debug, but it would be really nice if that could also detect valid UTF-8–encoded characters and allow those too. Ideally it would work like std::str::escape_debug() except including hex escapes for non-utf-8 bytes. But that's orthogonal to this issue.

There is from_bytes() function that allow you use non-ascii bytes. And the name of from_str is misleading it should be try_from_str actually (but it's documented to be replaced in the future with TryFrom trait).

@xoac There's no reason why HeaderValue::from_bytes(s.as_bytes()) should accept something that HeaderValue::from_str(s) does not (or rather, no reason why from_str() should reject something that from_bytes() allows). Also the documentation on from_bytes() once again forgets that \t is a valid byte.
Also I don't know why from_str() continues to say it will be replaced by TryFrom once the trait is stabilized, as the trait was stabilized back in 1.34 and HeaderValue already implements it. Heck, the TryFrom impl just delegates to FromStr (which has been stable since 1.0), so that just makes it even more confusing as to why HeaderValue::from_str() exists and claims it will be replaced. Also, these traits can't replace HeaderValue::from_static().


Adding API Version parameter

[X] The purpose of this PR is explained in this or a referenced issue.
[X] The PR does not update generated files.

These files are managed by the codegen framework at Azure/autorest.go.

[X] The PR targets the latest branch.
[X] Tests are included and/or updated for code changes.
[X] Updates to CHANGELOG.md are included.
[X] Apache v2 license headers are included in each file.

This PR fixes a bug related to hard coded APIVersion which is a constant that as of now reflects the GO SDK version instead of each specific resource provider version, which is most cases will fail the functions to retrieve resources when using the functions at resources.go. The changes are basically exposing a new parameter called APIVersion and passing it down to other functions (and of course adding it on each function) as needed. In order to get closer to the old behavior a test is made to check if APIVersion is "", if true, it will default to the value that was previosly defined in the constant of the same name.
Changes were applied to the most obvious functions, for the untouched functions (with exception of the ones that this surely doesn't apply), deeper investigation is needed and can be done in the future.
List of functions updated:

CheckExistence
CheckExistenceByID
CreateOrUpdate
CreateOrUpdateByID
Delete
DeleteByID
Get
GetByID
Update
UpdateByID

Note: I could not find the test cases for resources module.

Can one of the admins verify this patch?

The API version constant is the service API version, it is not the Go SDK version.
The majority of the Go SDK is generated from swagger files.  The package being modified in this PR is generated from the following swagger.
https://github.com/Azure/azure-rest-api-specs/blob/master/specification/resources/resource-manager/Microsoft.Resources/stable/2019-05-01/resources.json
As you can see, the service API version for this package is 2019-05-01.
Any changes made to the source code will be lost the next time the package is generated, so if there's a bug it should be fixed in the swagger which is the source of truth.
Are you looking for a different API version?

Hi @jhendrixMSFT, I didn't know this was auto-generated code. The problem is that whatever is adding the api version is adding a version that does not exist for that particular resource provider, I think we may have to work on the auto generation mechanism. This module I need fixed is about generic resources, and it is relaying on the API version for networking which is not 2019-05-01 that is being hard-coded, since I'm querying for a vnet using the general resource module Get method and since it is adding the same version of the SDK itself, I get the error that the API version is not supported for vnets on westus2 for example.

BTW, I can workaround this by using the networks module (https://github.com/Azure/azure-sdk-for-go/blob/master/services/network/mgmt/2019-09-01/network) but I am worried about customers that needs to use generic resources, so if we could work on something that would be great.

Just to confirm, you're calling the following API which is failing?
https://github.com/Azure/azure-sdk-for-go/blob/master/services/resources/mgmt/2019-05-01/resources/resources.go#L567
What are you using for parameters?  I'm not familiar with the working of this API (my team owns SDK generation and release) but I can find out.

Yes, that's correct, but other similar methods will have the same issue. If you look at the code snippet you pointed out, it calls the GetPreparer and on that method, at line 618 there is the resources SDK module version and then the request is built using that api version here. But somehow it looks like it is redirecting to the RP related to Network and that one is checking the API version coming and that does not match, thus the error message I pasted previously.

This is the code snippet I'm working on, of course there is the APIVersion I added there as the last argument.
func GetResourceByID(ctx context.Context, resourceID string, APIVersion string) (resources.GenericResource, error) {

	resourcesClient, err := getResourcesClient()
	if err != nil {
		return resources.GenericResource{}, err
	}

	parentResource := ""
	resourceGroup, _ := uri.GetResourceGroup(resourceID)
	resourceProvider, _ := uri.GetResourceValue(resourceID, "providers")
	resourceName, _ := uri.GetResourceName(resourceID)
	resourceType, _ := uri.GetResourceValue(resourceID, resourceProvider)

	if strings.Contains(resourceID, "/subnets/") {
		parentResource, _ = uri.GetResourceValue(resourceID, resourceType)
		resourceType = "subnets"
	}

	return resourcesClient.Get(
		ctx,
		resourceGroup,
		resourceProvider,
		parentResource,
		resourceType,
		resourceName,
		APIVersion,
	)
}

Thanks for the info, I was able to repro this using a service bus instance in my subscription.  I have no idea what to pass for the parentResourcePath parameter so I left it blank which I'm sure is incorrect.  Wondering if this is simply the case of bad parameters and a misleading error message.

You did it correctly, if you pass the parentResourcePath as blank it will work fine if the API of the service bus matches the API version being hard-coded as the resources module. In my code snippet this is used for child resources like a subnet, custom script extension, etc.

I spoke to the service owner, indeed the Go codegen is incorrect (other languages don't have this problem).  I'll work on getting the codegen fixed up.
CC @ArcturusZhang

This will be fixed via https://github.com/Azure/autorest.go/pull/184.  Once this is merged we can generate updated packages, however since it introduces a breaking change we'll have to wait for the next major release (v38 I believe due the end of this month).


Option to hide file permissions in file explorer

File explorer component should have an option to hide permissions listing

Yup, this is an easy one. Will implement.


NullPointerException from createWithBasicHttpAuthentication(AsynchronousJiraRestClientFactory.java:42) Java

Hi,
I am using java-jira maven dependencies as this example to get some details from the jira tickets. But when creating a JiraRestClient from createWithBasicHttpAuthentication() method, it prompts a NullPointerException. But at the end the details are displayed. My problem is the beginning NullPointerException. Is there anyone who can help with this issue?

@ShanChathusanda93 Can you let me know what article and module you are looking at?

@eric-martin This is the article that I have referred.
https://www.baeldung.com/jira-rest-api

Can you give me some more details about the exception?
Is your URI, username and password all non-null?

Yes, they are all not-null.

Can you post the exception message and full stack trace?


ExpiredTokenException and Token Refresh Method for the API

Ok here is the new PR based on the latest changes.
I need to learn some git stuff ^^

THis looks good, thanks :)


Port librecat person transfer command

Story
As an adminstrator, I'm able to use a "transfer" command-line command which allows me to "transfer" publications between persons:

Transfer the ownership of a record between persons (User field)
Switch out person A for person B for a particular contributor role:

Authors
Editors
Supervisors

Success criteria

[ ] Transfer ownership from person A to person B
[ ] Change person A to B in authors
[ ] Change person A to B in supervisors
[ ] Change person A to B in editors

Additional information
The command needs to be implemented using the non-grpc interface. It should look something like this, with first argument as the origin, and the last as the destination. Additional switches may control which parts of the records are affected.
$ ./biblio transfer <UUID> <UUID>

The command goes back to the Biblio Frontend Person API to fetch the person data based on the destination UUID. The new data is then interspersed in the record in a controlled fashion.

@netsensei best to make it biblio publication transfer

resolved by #885


Activation errors

Hi,
I get errors when I try to activate Office:

Would you know how to fix them?
Many thanks for your help!

As I understood, the wrong licenses for the activation method (Retail vs Volume).
Use second menu to check licenses and key.

See also https://github.com/YerongAI/Office-Tool/wiki/Office-Tool-Plus-Quick-Start#activate-office

Thanks for your answer.
I have followed quick start step by step with no success :(
Both view installation ID and display license information return error:

Thanks for your answer.
I have followed quick start step by step with no success :(
Both view installation ID and display license information return error:

Hi, do you using Windows Insider version?

I'm giving assistance to somebody, how can I check?

I'm afraid...

What should I do?

I'm giving assistance to somebody, how can I check?

If he/she is using Windows Insider, there should be a info in the bottom right corner of the screen.

Nothing on the desktop

Nothing on the desktop

OK, I've had this problem before，, I tried everything on Office Tool Plus but keeping failed.
I have a quicker and safer way, use KMS-VL-ALL instead at this time.
Solving this problem is a bit of a hassle and I don't recommend wasting time with your friend.

Seems activated with KMS-VL-ALL, many thanks!!

If no problems, you can close the issue.


when enabling ip forwarding set the default forward policy to drop

Related to [docker #14041] (https://github.com/docker/docker/issues/14041)
If docker daemon enables ip_forwarding on a host set the policy in the FORWARD chain to DROP. This blocks the vulnerability explained in the above mentioned issue. Setting the policy is done from the bridge driver to keep it consistent with the current handling for ip_forward flag.
Signed-off-by: Santhosh Manohar<EMAIL_ADDRESS>

We will now touch the iptables (changing the default policy) even if daemon was started with --iptables=false.
I guess it is fine, given we are addressing a vulnerability.
We'll need to document this behavior.

We will now touch the iptables (changing the default policy) even if daemon was started with --iptables=false. - On second thought I think its probably better to honor the iptabels=false config. Whoever sets it wants full control of the iptables and its their responsibility to also set the default policies correctly.

@aboch Addressed the comments. PTAL

After some more thinking of this and talk offline, I see the FORWARD chain policy will be set to DROP only if the ip forwarding is being enabled during this running instance.
If the daemon was already running and we upgrade it to the version containing this fix, or if the user has it enabled via other means, the policy will not be set to DROP.
I believe this is for assuring we do not disrupt current behavior on the host.
I would be more on the conservative side and always set the policy to DROP in SetupIPChain() if the ip_forward flag read from OS is 1. Reason is that given we cannot know for sure existing forward flag set to 1 is intentional, I think it is better to always change the policy.
But I understand this is opinable.

@aboch When firewalld is enabled, if firewalld is restarted the default policy has to be set again. Added a function to OnReloaded to handle this.

@sanimej after much discussion, I think this is a reasonable approach considering the backward compatibility. Lets document this clearly in docker/docker.
LGTM


Gallery Download Limited to 30 images from xhamster

Ripme version: v1.7.87
Java version:  1.8.0_162
Operating system:  Windows 8.1

Exact URL you were trying to rip when the problem occurred: https://xhamster.desi/photos/gallery/instagrams-4177418
Please include any additional information about how to reproduce the problem:

Expected Behavior
Download all images of the gallery
Detail the expected behavior here.
Actual Behavior
Downloads 30 images instead of the full Gallery
Detail the actual (incorrect) behavior here. You can post log snippets or attach log files to your issue report.

Sorry I didn't see an issue being raised for the same already.


Import generation from CTRL+Space menu suddenly adds relative imports

Environment data

Language Server version: 2022.8.20
OS and version: linux x64
Python version (and distribution if applicable, e.g. Anaconda):
python.analysis.indexing: true
python.analysis.typeCheckingMode: off

Since the last update (I'm on insiders), generating an import from the CTRL+Space menu creates a relative import instead of an absolute one.
Setting "python.analysis.importFormat": "absolute", does not help.
This is very annoying because my project does not use relative imports and isort etc. cannot automatically fix those...
Using the Ctrl+Period menu still does the correct thing (but it shows a TON of barely related matches, but that's probably something for a separate issue)

fix should be in prerelease released yesterday.


uploadFile() for local file that doesn't exist, transferStatusUpdatedCallback isn't called

When calling uploadFile() for local file that doesn't exist, the sdk never calls transferStatusUpdatedCallback for that transfer.
Setup
Windows 10 x64
VS2017 15.3.3
AWS SDK 1.1.49
Repro
When setting up transferManager and its transferConfig, create a lambda on the config's transferStatusUpdatedCallback. In that lambda, display some simple debug text.
Then with a valid transferManager, do
transferManager->UploadFile("c:\\fileDoesNotExist.txt", "myBucket", "myKey", mimeType, Aws::Map<Aws::String, Aws::String>()));

Result
The debug display you put in the lambda for transferStatusUpdatedCallback is never seen.
Expected
Your debug display. transferStatusUpdatedCallback should be called by the sdk with

transferStatus = FAILED
GetTargetFilePath() = "c:\fileDoesNotExist.txt"
GetBucketName() = "myBucket"
GetKey() = "myKey"
GetTransferDirection() =TransferDirection::UPLOAD
error = not_found
etc.

It's a bug. Currently transferStatusUpdatedCallback is only get called during the actual transfer.

Hello. What is the resolution of this bug? If by code, what was the build? If other, please share with your customers the resolution.
For example, did TransferManager in 1.2 with commit abcdef resolve this by reporting an error on the callback errorCallback?

Ah, it's been fixed in this commit: 55563eeecf809fc45630c67505025ffc4a624696

We call the callback function if failed to read the file (status updated to FAILED)
https://github.com/aws/aws-sdk-cpp/blob/f5921a32c884928f45967b878fbff204a4075534/aws-cpp-sdk-transfer/source/transfer/TransferManager.cpp#L953
And here is the related test in TransferTest.cpp
https://github.com/aws/aws-sdk-cpp/blob/f5921a32c884928f45967b878fbff204a4075534/aws-cpp-sdk-transfer-tests/TransferTests.cpp#L1362
This issue was closed automatically by Github because we referenced it in the commit, sorry for not updating immediately, and thank you for your suggestion again.


Clarify deprecation of iris.FUTURE.strict_grib_load

See : https://github.com/SciTools/iris/issues/1948#issuecomment-237171470

See #2112
Addresses the issue, but is it too much fuss ?

closed by #2112


Error in train_phase0 - config.balanced_cmd

Hi,
After the data collection process using data_phase0, I am trying to run train_phase0. However, I am getting the following error
Traceback (most recent call last):
  File "/home/himangi/anaconda3/envs/world_on_rails/lib/python3.7/runpy.py", line 193, in _run_module_as_main
    "__main__", mod_spec)
  File "/home/himangi/anaconda3/envs/world_on_rails/lib/python3.7/runpy.py", line 85, in _run_code
    exec(code, run_globals)
  File "/home/himangi/carla/WorldOnRails/rails/train_phase0.py", line 53, in <module>
    main(args)
  File "/home/himangi/carla/WorldOnRails/rails/train_phase0.py", line 11, in main
    data = data_loader('ego', args)
  File "/home/himangi/carla/WorldOnRails/rails/datasets/__init__.py", line 17, in data_loader
    if config.balanced_cmd:
AttributeError: 'Namespace' object has no attribute 'balanced_cmd'

At the line 11 of train_phase0, the data loader is called and the init.py file has an if statement of config.balanced_cmd. I am unable to find this argument in the config.yaml file. Can you please let me know whether balanced_cmd has to be set to True or False?
Thanks,
Himangi

Fixed


Is it possible scroll menu items toger with scrolling view controllers ?

I expect when i start to scroll left or right my viewcontrollers that are in PagingController, options that are above should scroll with my finger as welle.
Now its waiting for decelerating of scrollview to change menu item.
Is it possible scroll menu items toger with scrolling view controllers ?
Thanks

Currently no.


No error is thrown when unknown parser is set in .eslintrc

{
    "parser": "foo-bar"
}

Does not thrown any error. Also, it would be useful if output would tell what parser is being used.
It silently ignores error:
Cannot find module 'foo-bar'

PR welcome.

I see lint errors like:
/gulp-eslint/gulpfile.js
  0:0  error  Cannot find module 'foo-bar'

Combined with failOnError or failAfterError, the process will exit with an error code.
Is your experience different or are you expecting something else?

I'm closing this for now. If the issue persists, please provide some additional details.


[NO-ISSUE] RC6 release

Images will be tagged before I merge.

Update, images have been tagged. They're the exact same as RC5 so I just re-tagged them.

Post-merge: tested and it works as expected.
# helm install pure-csi pure-pso-csi/pureStorageDriver --version 6.0.0-rc6 -n pso-6 -f values-ose44.yaml
NAME: pure-csi
LAST DEPLOYED: Mon Aug  3 13:32:58 2020
NAMESPACE: pso-6
STATUS: deployed
REVISION: 1
TEST SUITE: None

# kubectl get pods
NAME                                        READY   STATUS    RESTARTS   AGE
pso-csi-controller-0                        6/6     Running   0          106s
pso-csi-node-4jnrh                          3/3     Running   1          106s
pso-csi-node-5kgn9                          3/3     Running   1          106s
pso-csi-node-vpj84                          3/3     Running   1          106s
pso-db-0-0                                  1/1     Running   0          101s
pso-db-1-0                                  1/1     Running   0          101s
pso-db-2-0                                  1/1     Running   0          101s
pso-db-3-0                                  1/1     Running   0          101s
pso-db-4-0                                  1/1     Running   0          101s
pso-db-cockroach-operator-f8998d9b9-2h5km   1/1     Running   0          106s
pso-db-deployer-6b57d6b5bd-kcxx7            1/1     Running   0          106s

# kubectl get intrusion
NAME     STATUS   READY   RANGES   UNDER-REPLICATED   UNAVAILABLE   AS-OF
pso-db   Live     5/5     79       0                  0             2020-08-03T20:34:54Z


Set DEFAULT_PROBE_INTERVAL_MSEC to 0 to avoid initial connection flapping

Set DEFAULT_PROBE_INTERVAL_MSEC to 0 to avoid initial connection flapping.
Before configured in northd_probe_interval value is actually applied to southbound and northbound database connections, both connections must be fully established, otherwise ovnnb_db_run() will return without retrieving configuration data from northbound DB. In cases when southbound database is big enough, default interval of 5 seconds will kill and retry the connection before it is fully established, no matter what is set in northd_probe_interval. Client reconnect will cause even more load to ovsdb-server and cause cascade effect, so northd can never stabilise. We have more than 2000 ports in our lab, and northd could not start before this patch, holding at 100% CPU utilisation both itself and ovsdb-server.
After connections are established, any value in northd_probe_interval is applied correctly.
Signed-off-by: Renat Nurgaliyev<EMAIL_ADDRESS>

I think you can configure this value by running the command - ovn-nbctl set NB_Global . northd_probe_interval=0
if you want to disable probes or set to higher value.
I don't see a reason to disable probe interval by default.

@numansiddique you are totally right, with this command, indeed, probe interval can be set to any custom value. The problem is though, that before even reading option this from the NB database, connection to both databases must be fully established. Here is a part of code from ovnnb_db_run():
    if (!ctx->ovnsb_txn || !ctx->ovnnb_txn) {
        return;
    }

...

    /* Update the probe interval. */
    northd_probe_interval_nb = get_probe_interval(ovnnb_db, nb);
    northd_probe_interval_sb = get_probe_interval(ovnsb_db, nb);

First conditional will always return from routine, before probe intervals are set. If we run in bigger scale, where SB is relatively big (>2000 ports), it will take more than 5 seconds to connect to SB, and default probe interval of 5 seconds will kill and reestablish connection, restarting things from scratch, causing more stress on ovsdb-server and cascading effect. This causes endless SB connection flapping, and 100% CPU utilisation on both northd and ovsdb-server.
If we set probe interval to 0 during the initial connection, northd can take its time and establish connections properly. After it, probe interval will be set to any value configured.

Thanks for the explanation. I now get it.

I'm still concerned about setting the default to 0. Which means a deployment which doesn't configure northd_probe_interval in NB_Global will have probes disabled by default.
Probably you could add a command line option during startup to pass the probe interval value ?
Also to get better visibility among other reviewers, are you ok submitting this PR as a patch to ovs-dev mailing list ?  If you're not familiar with the patch work process, I can submit the patch on your behalf.
Thanks
Numan

I think I came up with even better approach. Instead of touching default DEFAULT_PROBE_INTERVAL_MSEC, we instead can initialise northd_probe_interval_nb and northd_probe_interval_sb with 0. Initial connection will not be probed, but as soon as we can "reach" configuration in NB, we will set probe interval to whatever is set there, or to default value 5000 if nothing is set explicitly.
So basically instead of doing this:
#define DEFAULT_PROBE_INTERVAL_MSEC 0
static int northd_probe_interval_nb = DEFAULT_PROBE_INTERVAL_MSEC;
static int northd_probe_interval_sb = DEFAULT_PROBE_INTERVAL_MSEC;

We do that:
#define DEFAULT_PROBE_INTERVAL_MSEC 5000
static int northd_probe_interval_nb = 0;
static int northd_probe_interval_sb = 0;

If you like the idea, I will close this PR and will make a proper patch to ovs-dev.
Thanks,
Renat

I think I came up with even better approach. Instead of touching default DEFAULT_PROBE_INTERVAL_MSEC, we instead can initialise northd_probe_interval_nb and northd_probe_interval_sb with 0. Initial connection will not be probed, but as soon as we can "reach" configuration in NB, we will set probe interval to whatever is set there, or to default value 5000 if nothing is set explicitly.
So basically instead of doing this:
#define DEFAULT_PROBE_INTERVAL_MSEC 0
static int northd_probe_interval_nb = DEFAULT_PROBE_INTERVAL_MSEC;
static int northd_probe_interval_sb = DEFAULT_PROBE_INTERVAL_MSEC;

We do that:
#define DEFAULT_PROBE_INTERVAL_MSEC 5000
static int northd_probe_interval_nb = 0;
static int northd_probe_interval_sb = 0;

If you like the idea, I will close this PR and will make a proper patch to ovs-dev.
Thanks,
Renat

Sounds good. Looking forward to the patch. In case any issues with ovs-dev ML, let me know or update this PR itself.
Thanks

I think it will be better to have PR description in the commit message. Can you please update the commit message ?
Thanks

Of course, done.


DeepSpeed should allow to return dictionary or other type from the forward function

Using DeepSpeed: '0.3.16'
output = {'x': tensor(0.8130, device='cuda:1', dtype=torch.float16)}

    def _post_forward_module_hook(module, input, output):
        global FWD_MODULE_STACK
        FWD_MODULE_STACK.pop()

        if not isinstance(output, (list, tuple)):
            if torch.is_tensor(output):
                output = [output]
            else:
                #print(f'got UNKNOWN type {type(output)}')
                outputs = []
>               for name, val in vars(output).items():
E               TypeError: vars() argument must have __dict__ attribute

/opt/conda/lib/python3.8/site-packages/deepspeed/runtime/zero/stage3.py:1425: TypeError

And as expected, it works with nametuple :)

Found this was resolved on master. Closing this issue.


Update Cassandra version to v3.6

Deployed Cassandra with v3.6, currently testing it with my pipeline

Looks good to me! Merging and Thanks!


Security, Vandalism and Review Process

Typically the current homebrew repository is quite light touch on actual review of content.
If we're going to be accepting macros and therefore executed code into this repo I'd like to see a more through verification process to ensure nobody attempts to slip something malicious in through a macro.
There's plenty of opinionated people out there regarding plutonium, and also regarding homebrew content on 5eTools, some of whom might have the bright idea to add "if roll attack, delete entire world" to a macro.
I think this is most easily solved by Giddy being diligent on skim reading any pulls once this project gets going; i.e. reviewing proposed code as code rather than as content? Thoughts?

I'm not about to be on the hook for reviewing every scuffed macro that makes its way through here
Sounds like you're volunteering though 🤔

I think divide and conquer is the way to go, single points of failure will never keep up.

I'm not about to be on the hook for reviewing every scuffed macro

I was thinking more a cursory check for deliberately malicious code rather than actual verification stuff works

Sounds like you're volunteering though 🤔

I'd be happy to if I knew javascript :/

For core data, I have intended and alluded to a 'peer review' process where at least one other person gives it a cursory test before merging. For homebrew data... yeah, I'm more inclined to just flag a huge warning and let them deal with it themselves. I don't want to be on the hook for problems either, and I also certainly don't want to be reviewing every single macro.
I'm fine with giving extremely brief checks (i.e. flick through to make sure the macro isn't suspiciously large and doesn't redirect to any other website), but, yeah, ultimately it's the same as 5eT homebrew containing a <script>bitcoin.miner.startProess()</script> in its entries.

Since the macros are now split out into actual JS files, would it be possible to have some automated script check that, at the very least, no macro is:

Connecting to the internet
Accessing the local filesystem
Really doing anything that isn't either 100% private in scope or via the Foundry API

I'm assuming there's ways around it but perhaps some small protection is better than none at all?

some small protection is better than none at all?

Anything I might write would be laughably incomplete, or an infinite timesink, neither of which is very appealing. So, installing a random antivirus lib and having it run over the folder might be the best route?
e.g.:

https://www.npmjs.com/package/clamscan
https://www.npmjs.com/package/metadefender

It's going to be bulky and horrible, though. Macros should really be small and human-readable enough that a 30-second scrub through by a human reviewer ought to accomplish the same thing?

Macros should really be small and human-readable enough that a 30-second scrub through by a human reviewer ought to accomplish the same thing

I agree completely on the 'small and human-readable' part, it's just that I really don't care for proofreading several thousand lines of JS even if each macro itself is small and human-readable! I think my previous "no guarantee provided" stance honestly still stands regardless.

installing a random antivirus lib and having it run over the folder might be the best route

Didn't consider that, so yes. If you think it's a waste of time, I fall back to the "no guarantee provided" with a minute amount of clicking on the 'Files Changed' on each PR to see if anything screams 'dodgy' 😏

yeah frick AV. Like any open-source project, we will go with "well, the code's right there, you could've read it..."


how can I hide arrow?

  <ReactTooltip  arrowColor="transparent" />
  still can see arrow, arrow bg color is white.

It's ok. I found I set border color


Allow to open two distinct editors side by side in one group

VsCode has the ability to horizonatally split an editor window. When you execute code --diff file1 file2 both files are opened side by side in a single editor window with a single header tab. A similar view is presented when you edit the VsCode settings.
This is splitting. It would be nice to be able to do this for my own files to have multiple views of the same file. What would make it actually usable would be the following three enhancements.

The option to split either horizontally or vertically.
The ability to move focus from one split pane to another.
The ability to unsplit (revert the editor back to a single pane).

What we currently have is a keyboard shortcut "workbench.action.splitEditor" which doesn't actually split an editor at all, instead it just opens the same file in another editor in a different editor group. This is not editor splitting which by definition should occur in the same editor tab.
Calling opening a file in another editor group 'splitting' when there is already nascent functionality to support proper splitting is a pointless ambiguity that serves only to reduce the possibility that the editor will ever support proper splitting any time in the near future.
Proposal:

Rename "workbench.action.splitEditor" to "workbench.action.openInNewEditorGroup"
Make the VsCode diff view usable by adding a keyboard shortcut to permit cycling focus from one editor pane to the other.
Add support to split open editor vertically or horizontally by the addition of the additional keyboard shortcuts "editor.action.splitHorizontal", "editor.action.splitVertical" and "editor.action.unsplit".

I found the discussion about enhancing the editor group functionality here
https://github.com/Microsoft/vscode/issues/5911
...and added some thoughts of my own about how grouping and splitting should be two separate things which it might be useful to reiterate here.

My personal workflow is to open editors horizontally (side by side). Occasionally I may want to view two parts of the same file, which I do by splitting that editor vertically (one pane above the other). Splitting the file in the editor (as opposed to opening another vertical editor group) is a distinct useful feature because splitting one editor vertically does not half the height of all the other horizontally laid out editors you have open.

Suggesting that opening additional horizontal or vertical editor groups performs the same job as editor splitting is to completely misunderstand the problem. Suppose I have 4 editors laid out side by side and I want to split one editor vertically. If to do this open my file in another editor in a group below the existing editor group, then all the other editors in the first group are now halved in height.

This is why editor groups and editor splitting are two different things.

+1
Horizontal splitting is a really frustrating experience in vscode. And apart from git diffing, it ends up being more of an annoyance (misclick) than an actual feature.
Sent from my Samsung SM-A500H using FastHub

+1 This is the only reason why I'm unable to switch from vim to vscode. The idea is that you want to be able to split a tab, not the entire editor.
For example, I want one tab vertically split with index.html and controllers.js, and another tab split between directives.js and somethingelse.whateva.

There are some other (now closed) issues not referenced here that are requesting the same feature: https://github.com/Microsoft/vscode/issues/7418
https://github.com/Microsoft/vscode/issues/49062
https://github.com/Microsoft/vscode/issues/41486

I fully agree the description in this ticket. The current "split" functionality imposes a reduction of edition area to all other editors. This is not an editor split but a layout split.
I vote +1 for a real editor split feature

Vim-style splitting would be awesome! This is the cause of one of the few remaining efficiency decreases I get by switching to VSCode from Vim

+1 for this, also a feature I'd like to see

Trying to migrate from Webstorm, and this sucks.

In SQL Server Management Studio and Textpad, I often like to split a single tab into two views, one on top of the other, so I can see two sections of a file in the same tab.  It's very convenient for keeping the important parts of the code right in front of my eyes.  And just to be clear, when I click to a different tab, the whole of the previous tab (with both views) hides behind the new tab.  I don't want to have two tabs for the same file, where the second tab is still visible even after I click to a different tab.  (Hope that makes sense.)  Would definitely appreciate this.

Any news here?

@bpasero What is the status of this feature request? Has it been added to any roadmaps or backlogs? I think the duplicates and thumbs up indicate a pretty healthy demand.

@Hubro it is on the Backlog:

As for indicating "healthy" demand, this issue is currently at position ~250 in terms of upvotes based on this list:
https://github.com/microsoft/vscode/issues?q=is%3Aissue+is%3Aopen+sort%3Areactions-%2B1-desc
So I would argue, 250 issues have more demand compared to this one. As such, it may stay on the Backlog for a longer period or even forever.

Perhaps it would help to have some color on whether this is a limitation of electron, or if there are other architectural challenges to making this happen. For instance, I noticed in the discussion on custom editors / webviews  there was mention of

Non-goals
...
Embedding of VS Code's text editor in webviews

Is that a possible solution, or am I completely barking up the wrong tree? Would be nice to get a feel for how this might relate to other items on the UI roadmap (e.g. detachable terminals and editors), or maybe some pointers for community solutions (extensions or PR attempts). Thanks.

please check https://stackoverflow.com/questions/43304791/vscode-prevent-split-editor-to-open-same-file-left-right

This is a huge blocker for me to comfortably move from vim to vscode.

I find it very cumbersome to write C++ without this feature. Having a separate vim tab for each pair of .h/.cpp files I'm working on (split vertically) is incredibly useful, as opposed to having a single split and manually swapping out the files in each view every time I want to look at a different class. Even in languages which don't have separate interface/implementation files, having related files (such as code and test) stay open together is very useful. Personally I've found working with splits in VS Code so unmanageable that I just tend to not use them at all.

@bpasero Can you please edit https://github.com/microsoft/vscode/issues/41486 to link to the duplicate issue? It is the top result on Google (for me at least) with no link to the duplicate.

For example, I want one tab vertically split with index.html and controllers.js, and another tab split between directives.js and somethingelse.whateva.

Yes!!!
People that haven't used Vim (or soe other text editor with vim-like splits) just have no idea what great improvement in UX and workflow they are missing.
Having markdown on one side, and a markdown live preview on the other, all inside the same tab, would be very useful. Every tab could, for example, be for a single markdown file, each with their code and their live preview.

By the way, there's a new VS Code extension called Neo Vim that integrates Neovim into VS Code so that all editing commands can be handled by neovim as the backend (or think of it as Neovim with VS Code as a GUI).
This window splitting feature would be super useful for that Neo Vim extension so that it can map the same concept (same key combos) from neovim's equivalent to VS Code's equivalent. It would be GREAT!
I bet we'd see an sudden influx of vim/neovim users into VS Code, beside the introduction of Neo Vim.
For more on Neovim in VS Code (or Neovim with VS Code as a GUI), see
https://www.reddit.com/r/vimporn/comments/ki00pj/neovim_with_official_github_dark_theme/

^ I linked two new issues that would pair very nicely with this one.

People that haven't used Vim (or soe other text editor with vim-like splits) just have no idea what great improvement in UX and workflow they are missing.

1000% this.
I am still struggling to understand how anyone who writes code everyday in VSCode isn't also begging for this feature. Seriously, try the splits in VIM for a single day and you will quickly understand how game-changing and vastly more efficient that workflow is over having splits outside of tabs.
I literally check this issue (and the duplicates that constantly spring up) annually to see if any progress has been made, as this is the only blocker to me transitioning over to VSCode to take advantage of all the other features that VIM doesn't have.

People that haven't used Vim (or soe other text editor with vim-like splits) just have no idea what great improvement in UX and workflow they are missing.

1000% this.
I am still struggling to understand how anyone who writes code everyday in VSCode isn't also begging for this feature. Seriously, try the splits in VIM for a single day and you will quickly understand how game-changing and vastly more efficient that workflow is over having splits outside of tabs.
I literally check this issue (and the duplicates that constantly spring up) annually to see if any progress has been made, as this is the only blocker to me transitioning over to VSCode to take advantage of all the other features that VIM doesn't have.

Not only just splitting the same file.
We often work with related files, like html&js pair, cpp & header pair...
And different files have different related files, currently we have to switch/open them manually every time.
I think a simple implementation is add an option to remember current split layout, and simply show/hide the split-ed tabs in layout when switching to tabs of different "split group". Not perfect, but better.

Not only just splitting the same file.
We often work with related files, like html&js pair, cpp & header pair...
And different files have different related files, currently we have to switch/open them manually every time.
I think a simple implementation is add an option to remember current split layout, and simply show/hide the split-ed tabs in layout when switching to tabs of different "split group". Not perfect, but better.

Another potential solution might be the ability to flip between tabs in all splits simultaneously. I'd be happy keeping a VSCode window dedicated to a single layout that can easily flip between sets of files files. I often do something similar using tmux when editing in Vim.
I'm a VSCode newbie but this seems like something one could accomplish in an extension. If I weren't picking up VSCode as part of a web dev course I'd gladly scratch the itch myself...

Now that the ability to display terminals in the editor has been implemented,I think that the need for "VIM-style tab splitting" will become more and more important.
It would be a great gift for Linux CLI users to be able to use the terminal splitting feature like Hyper, Terminator, and Tilix.
In my case, I use "Remote SSH" to connect to my research server for development.
In order to analyze logs and compile, I need the Linux CLI very much.
I would be very happy if I could do this only with VSCode, without using any other terminal emulator.
I vote +1 for this great feature!

Here is a set of keybinding which changes the behavior from ctrl+tab (it uses the history instead of the opened tab in the current split). It feels close to switching of buffers.
[
  {
    "key": "ctrl+tab",
    "command": "workbench.action.openPreviousEditorFromHistory",
    "when": "!inQuickOpen"
  },
  {
    "key": "ctrl+tab",
    "command": "workbench.action.quickOpenNavigateNextInEditorPicker",
    "when": "inQuickOpen && inFilesPicker"
  },
  {
    "key": "ctrl+shift+tab",
    "command": "workbench.action.quickOpenNavigatePreviousInEditorPicker",
    "when": "inQuickOpen && inFilesPicker"
  }
]

You can also hide the tab bar by using this setting:
    "workbench.editor.showTabs": false,

So I had to switch from VIM to VS Code and got frustrated enough by the lack of this capability that I built an extension to solve it. Give it a shot and let me know if it helps, I use it pretty much every day now.
https://marketplace.visualstudio.com/items?itemName=agquick.workviews
The "workviews" show up in your Explorer tab and are basically "named" tab/file groups that are easy to switch between. It's somewhat limited because for some strange reason VS Code doesn't allow me to directly access all open editors, but it's better than nothing, and feels almost like VIM again.

Pushed a change to enable text based editors to split/join:

Also added commands to move keyboard focus between left and right side.
Commands:

workbench.action.splitEditorInGroup
workbench.action.joinEditorInGroup
workbench.action.toggleSplitEditorInGroup
workbench.action.focusLeftSideEditor
workbench.action.focusRightSideEditor
workbench.action.focusOtherSideEditor

Still investigating whether vertical & horizontal splitting should both be supported or whether that could be a separate feature request to follow up later.

Vertical splitting is more important as monitors are rather wide than high. More monitors mean also more width than height.

For my use-case, horizontal splitting is actually more important.
I commonly split VS Code into two vertical groups, each with a few editor tabs. Then sometimes one of those editor tabs contains a very long file to which I need to make edits in multiple places. I'd like to spit that tab horizontally, while keeping the other tabs within that group tall.

For me, the most important use cases are to review two files side-by-side, but grouped, e.g. for C++, having one tab with foo.h and foo.cpp, and another tab with bar.h and bar.cpp, so I can switch quickly.

For horizontal screen space management folds exist already, for vertical there is nothing at the moment. Which doesn't mean that horizontal splits are not important as well.

To clarify on the changes I pushed: this is limited to the same file as requested by the OP. If you want to see 2 different files in the same editor group, please consider to file a new feature request. It is not impossible to even allow any other file to show to the side (or even something completely different like a live preview of HTML) but I think we should keep the feature that was originally requested as it is.

First of all, thanks for the work and progress!
I might be wrong, but my guess is that the majority of people in this thread were hoping for full "vim-like" tabs, rather than only a split the view same file, which is rather limiting - indeed many of the closed duplicates such as Window splits inside a tab #104483 and  Window splits inside a tab. #41486  did not imply that same-file splitting would be sufficient.
We could open a new issue, but I think that would unfortunately "reset the clock" in both time and upvotes on this long-desired feature.

Understood and it's in the cards, at least for simple scenarios of 2 files (either vertically or horizontally split).
I would think that we would not go down the path of allowing a full grid layout within an editor tab just because of how complex that would become in terms of managing editors.
Since we already have this side-by-side functionality in a way for a long time when you just diff 2 files, expanding it to what I pushed now seems natural and manageable.

both workbench.action.splitEditorInGroup  and workbench.action.toggleSplitEditorInGroup can split
after splite, there is  only workbench.action.toggleSplitEditorInGroup showed， but no use when execute  workbench.action.toggleSplitEditorInGroup
after split, can not use ctrl+w or mouse to close the tab

@heartacker can you report issues you find with the implementation into new issues, then we can discuss there. I am not sure I can follow all the things you mentioned.

Oh nevermind, I see the issue with Ctrl+W not working and fixed it already earlier today. I also added a toggle action to flip vertical/horizontal layout. This is driven by a new setting workbench.editor.splitInGroupLayout:

Will be available in tomorrow's insider build.

@bpasero thanks for your update and there are some purpose about splitEditor.

we should add a shortcut for toggleSplitEditorInGroup, I  tend to use ctrl+alt+\,like ctrl+\

by default, editor is split in horizontal, and we need to use another command to toggle layout, that's not very comfortable. maybe we can use  toggleSplitEditorInGroup to convert for better experience,  no split -->split horizontal-->splite vertical --> no split.  After that we could use one command or shortcut to toggle each state

maybe we could make the split line more visible

may be we could show the Breadcrumbs when in horizontal

as a VS user, I also want this style when using mouse

@heartacker

that keybinding is very frequently used already in other places, the only "free" one I found that I can use is a key-chord of: CtrlCmd+KeyCode.KEY_K, CtrlCmd+Shift+US_BACKSLASH

that is the reason why this is a setting, assuming you only want to configure this once. once you flipped the layout, all other split editors will use it

that color is themeable either when you change editorGroup.border or editorPane.border (the latter I just pushed today and will be available tomorrow)

that seems unrelated to this issue

Reading through the comments and linked issues, it looks like the original intent of just splitting 1 editor into 2 is not what got all the upvotes. Instead, it seems that some are asking for being able to open 2 different editors in the same group and others want to open as many editors as they want side by side in a group ("VIM Style Tabs").
I feel that being able to open any 2 editors side by side in a group is realistic. Being able to have a full grid of editors within a group is imho rather unrealistic for the complexity this brings and given we have full grid support via groups already.
As such I have extracted https://github.com/microsoft/vscode/issues/132651 for the work I am planning to do in September or what is already pushed.

open setting config with split view, then use ctrl+kctrl+shift+\and the split view is closed into one, but trigger that again, we couldn't recover the split setting view,

click setting file will create new-two-tab-view even opened

@heartacker if you see any issues specific to settings, please report as new issues and make sure to try this out in insiders. You can give our preview releases a try from: https://code.visualstudio.com/insiders/

I hope this feature can also be used when we move the terminal to the editor area.

Reading through the comments and linked issues, it looks like the original intent of just splitting 1 editor into 2 is not what got all the upvotes. Instead, it seems that some are asking for being able to open 2 different editors in the same group (also in #22068) and others want to open as many editors as they want side by side in a group ("VIM Style Tabs").
I feel that being able to open any 2 editors side by side in a group is realistic. Being able to have a full grid of editors within a group is imho rather unrealistic for the complexity this brings and given we have full grid support via groups already.
As such I have extracted #132651 for the work I am planning to do in September or what is already pushed with regards to being able to split an editor into 2.

I'm a little confused, is this being dropped? The issue title changed to something different, and I can't find the original ask tracked somewhere else.
But just to recap, because this issue is getting huge and confusing to me:
For most vim users, this is an intrinsic part of the workflow for stuff like having an impl/test side-by-side, and maybe you open a third split for like, an HTML template or stylesheet.
Then, those 3 splits are grouped together in one tab. So when I want to think about "ComponentX", I just navigate to that tab and see everything at once. Maybe even a 4th split for documentation.
I think multiple editors solves all of this, but the missing piece is grouping them into a single tab.
One way to solve this might be to introduce an optional, higher-order tab bar where each tab groups editor splits, and then provide an option to disable the tab bar inside the editors.
But anyway, I understand that's probably a lot of effort. I hope the original feature request is still tracked somewhere, though.

It definitely feels like the Code team prefers this functionality be implemented as an extension, and this is pretty much exactly what my extension "Workviews" (https://marketplace.visualstudio.com/items?itemName=agquick.workviews) does, except the "tabs" are shown in the Explorer pane on the left.
The problem is I can't get access to all the open editors/terminals/etc properly until VS Code decides to open up the extension APIs a bit. But it's the closest feeling to VIM I've been able to achieve thus far.

this is pretty much exactly what my extension "Workviews" (https://marketplace.visualstudio.com/items?itemName=agquick.workviews) does

I think that is slightly different to what is being asked for here. (The post above is a demo of what could be done with the functionality, not what we are asking for explicitly.)
This FR is asking for a way for extensions to control the "Split Editor in Group" functionality and specify what is rendered in the other half of the editor. At the moment it is not possible for extensions to do that.

I think that is slightly different to what is being asked for here. (The post above is a demo of what could be done with the functionality, not what we are asking for explicitly.)

If you gather context from reading the thread, it's likely that most of the support for this FR is from Vim users who have a workflow based on grouping multiple editors within tabs. They've been punted here from other FR's that are closed as duplicates of this FR.
In my opinion, the main issue is that tabs don't group anything. One-to-one correlation between tabs and files, except in some special cases, like the diff view.
Creating another grid inside the existing editor grid seems like the wrong way to solve the problem to me-- especially if the new grid is subject to limitations like only horizontal splitting + showing the same file.
See #143024 for an alternate solution that solves everyone's problem.

Related on Stack Overflow: Is it possible to create split editors inside individual tabs in VS Code?. I'll keep my answer post updated with whatever progress is made here.


[cxx-interop] NFC: update a couple outdated comments

import_as_ref attribute was renamed to import_reference.

@swift-ci please smoke test


ci: add a bunch of useful Flake8 plugins to git commit hooks

Poking through a few other packages I came across these flake8 plugins that I think are useful to add:

bugbear
comprehensions
mutable (somewhat dated though)
simplify
pytest-style

We’d also consider:

scream
Review this list of Awesome Flake8 Plugins

In general I would be careful about the quality, active maintenance, and security posture of these dependencies we pull in. With that in mind, do you still want to add all of these tools?

In general I would be careful about the quality, active maintenance, and security posture of these dependencies we pull in. With that in mind, do you still want to add all of these tools?

I personally will enable these plugins to find out what they find out; they don’t modify any code anyway. Worst case is a lot of dismissible noise.
For this change to the Template Repository we can comment out all plugins and leave a comment for the user. I’m easy.

they don’t modify any code anyway

I thought they might be.
I also find some of the checks interesting, e.g., the comprehensions. Though I also wonder if there would be overlaps with Pylint? In general finding the right checkers that don't add too much noise will be important as the projects grow. Unfortunately this process is manual and not easy.
Developers can comment out and remove the checkers that are not adding value selectively. I'm happy to approve.


No such file or directory: 'asar'

describe the bug
what is the bug - what happens?
When I try to run customiser.py, I get an error. See below:
# python3 customiser.py
=== NOTION ENHANCER CUSTOMISATION LOG ===

 ...unpacking app.asar

### ERROR (report this to dragonwocky#8449 on discord) ###
[Errno 2] No such file or directory: 'asar'

=== END OF LOG ===

I have installed asar and can run it from the command line.
expected behaviour
why is this a bug - what should be happening?
The script should run without error. I haven't run it before. So I am not entirely sure what successful looks like.
screenshots
if applicable, add screenshots of your problem.

platform
I am on an iMac using zsh. OS = 10.5.6.

did you install asar? npm i -g asar

Yes. I can run asar from the command line. But for some reason customiser.py can't find it.

This is just an issue with me not having the node binary path in my PATH. To get past this, I just changed the subprocess line to call asar with the full path. That seemed to have worked. I should make sure that .node/bin is in my path. That would probably fix it.


[BUG] Not receving knowledge base answers from Custom Question Answering with an Orchestration Workflow using SDK

Library name and version
Azure.AI.Language.Conversations 1.0.0-beta.3
Describe the bug
When using the ConversationAnalysisClient to retrieve predictions from an Orchestrator connected to a Custom Question Answering (CQA), and giving a valid question message, the result successfully predicts the CQA intent, however the answers collection is empty when it should contain the expected answer of the question.
Expected behavior
As it is documented in GitHub here, if the given question is valid, the Orchestration should return the answer for the question within the prediction result.
Actual behavior
When using the ConversationAnalysisClient and giving a valid question, the prediction is correct but the answers collection is empty.
Reproduction Steps
var endpoint = new Uri(@"https://<language_studio_name>.cognitiveservices.azure.com");
var credential = new AzureKeyCredential("<primary_key>");
var conversationAnalysisClient = new ConversationAnalysisClient(endpoint, credential);

var input = new TextConversationItem(participantId: "1", id: "1", text: message)
{
    Language = "es"
};

var opt = new AnalyzeConversationOptions(input);

Response<AnalyzeConversationTaskResult> response =
    await _conversationAnalysisClient.AnalyzeConversationAsync(message, _conversationsProject, opt);

var customConversationalTaskResult = response.Value as CustomConversationalTaskResult;
var orchestratorPrediction = customConversationalTaskResult.Results.Prediction as OrchestratorPrediction;
var targetIntentResult = orchestratorPrediction.Intents[orchestratorPrediction.TopIntent];
var questionAnsweringTargetIntentResult = targetIntentResult as QuestionAnsweringTargetIntentResult;

KnowledgeBaseAnswers knowledgeBaseAnswers = questionAnsweringTargetIntentResult.Result;
var answers = knowledgeBaseAnswers.Answers; // THIS IS EMPTY, HOWEVER THERE SHOULD BE ANSWERS!!!

Environment
Windows 10
.NET 6.0
Visual Studio 2022 17.1.5

Label prediction was below confidence level 0.6 for Model:ServiceLabels: 'Storage:0.15427838,KeyVault:0.118872985,Azure.Identity:0.07197583'

A bit more of information in this screenshot:

We really appreciate your help!
Thank you!

A bot more information. When calling the REST API, it looks correct, so We think that the issue might be in the SDK when parsing the response from the service.
For example, for the following request:
POST /language/:analyze-conversations?api-version=2022-03-01-preview HTTP/1.1
Host: <language_studio_name>.cognitiveservices.azure.com
Ocp-Apim-Subscription-Key: <primary_key>
Content-Type: application/json
Content-Length: 398

{
    "analysisInput": {
        "conversationItem": {
            "text": "Hola",
            "participantId": "1",
            "id": "1",
            "language": "es",
            "modality": "text"
        }
    },
    "parameters": {
        "projectName": "Orquestador",
        "deploymentName": "production",
        "verbose": false
    },
    "kind": "CustomConversation"
}

We get a correct response which includes the answer. However, at SDK level with the C# code, the answers collection is empty 🤨
{
    "kind": "CustomConversationResult",
    "results": {
        "query": "Hola",
        "prediction": {
            "topIntent": "KB",
            "projectKind": "workflow",
            "intents": {
                "KB": {
                    "confidenceScore": 0.99789613,
                    "targetKind": "question_answering",
                    "result": {
                        "responseBody": {
                            "answers": [
                                {
                                    "questions": [
                                        "Hey, ¿qué tal?",
                                        "Hi",
                                        "Ey",
                                        "Hey, ¿qué dices?",
                                        "Hola, ¿qué te cuentas?"
                                    ],
                                    "answer": "Hola",
                                    "confidenceScore": 1.0,
                                    "id": 53,
                                    "source": "ChitChat",
                                    "metadata": {
                                        "editorial": "chitchat"
                                    },
                                    "dialog": {
                                        "isContextOnly": false,
                                        "prompts": []
                                    }
                                }
                            ]
                        }
                    }
                },
                "None": {
                    "confidenceScore": 0,
                    "targetKind": "non_linked"
                }
            }
        }
    }
}

We really need help with this, and also really appreciate your support!
Thank you!

BTW, this also happens with the previos version of the SDK -> Azure.AI.Language.Conversations 1.0.0-beta.2

The same is happening to me

I was going crazy, I finally see what is the problem. Hope they fix it soon!

Thank you for your feedback.  Tagging and routing to the team member best able to assist.

Thank you @jsquire. We really need help with this issue. Much appreciated.

Thank you for reporting this issue.
@ChongTang the service is returning an invalid response:
                    "result": {
                        "responseBody": {
                            "answers": [

Per the specification, answer should be nested directly within result, as defined in the target model specification.
/cc @annatisch @ZulaMostafa @mshaban-msft

@heaths , the issue should be fixed. Can you try again?

Hi @ChongTang!
Please allow me to answer you tomorrow. Today is a festive day in Spain, and nobody is working. Tomorrow, first time in the morning, my team will test this and verify everything is working as expected.
Thank you.

Hi @ChongTang!
The issue is fixed. Everything seems to be working as expected. This bug can be closed.
Thank you all for the great support and your help.

Glad to help. @heaths, I don't have permission to close it. Can you help me?

Will do. Thanks, @ChongTang!


Release 0.3.3

Signed-off-by: Hunter L. Allen<EMAIL_ADDRESS>@shr-project / @herb-kuta-lge  I need to generate the changelog, but this is step one... I'll set it up on my laptop and see how it goes.

Closes #283

@herb-kuta-lge okay, updated changelog. PTAL

Travis is basically only available for paying clients now. We have generally switched everything over to GIthub Actions which wer running on Travis.

I see there's both master and main branches. Is the intent that they always be coincident? Currently, they're not.

As repos transition to main from master I've found using this github action to automatically mirror it useful. Example in rocker: https://github.com/osrf/rocker/blob/main/.github/workflows/mirror-main-to-master.yaml

@herb-kuta-lge / @tfoote PTAL
@nuclearsandwich thanks for getting the actions working for us!


[BUG] The Preference "Enable Auto CRLF" should be turned OFF by default

When SourceGit is used on a local Git repository, it enables the following global git setting, which is unwanted by some users:
$HOME/.gitconfig
[core]
	autocrlf = true

This causes several unexpected problems:

Visual diff tools may start showing additional line-ending changes that are not relevant or not important.
Users will become confused, because the additional newline changes (CRLF or LF) only started when SourceGit was being used.
Git will start automatically converting line endings on text files, which the user may not want.
The problem starts affecting all Git clients, not just SourceGit.

Suggestions:

The "Enable Auto CRLF" setting should be switched off by default.

Also SourceGit should not modify the global gitconfig of this setting. Or it should set it to false like this:

$HOME/.gitconfig
[core]
	autocrlf = false

When SourceGit is used on a local Git repository, it enables the following global git setting, which is unwanted by some users

If you read Preference.axaml.cs, you will see that core.autocrlf is read directly from your global settings. The only exception is whe you do not set it, it will be true.

Also SourceGit should not modify the global gitconfig of this setting

This is a GUI tool to help people work with git, and this page is intends to modify global git settings. User can turn off the core.autocrlf from this page just like they do it from command line.

I've push a commit that unchange the global core.autocrlf if user do NOT set it yet.


'Session' object has no attribute 'started'

Hi, im getting the following issue below. I fixed this when i first installed it by updating Chrome. I think the new Chrome update broke it so i tried downgrading to chrome 97 but it didnt work so i tried downgrading and reinstalling python the old and newer builds 3.1 and 3.7 and the same error. This could be a chrome version issue or something else, i used this bot for 3 weeks it just randomly broke today, please help?
Exception ignored in atexit callback: <function Session.init..cleanup at 0x00000286EF862B00>
Traceback (most recent call last):
File "C:\Users\Dean\Documents\Tinder Bot VisualCode\TinderBotz\tinderbotz\session.py", line 68, in cleanup
print("Started session: {}".format(self.started))
AttributeError: 'Session' object has no attribute 'started'
PS C:\Users\Dean\Documents\Tinder Bot VisualCode\TinderBotz>

Can you post the entire error?
The actual error occurs a bit higher in the log.
Probably about the version of Chrome.
In the log you can find your current chrome version or you can look it up it in the settings of your chrome.
In my case, I have version 98.0.1...
Then in line 111 or so in session.py you can set it custom to:
self.browser = uc.Chrome(version_main=98, options=options)

got it

Hi, I have the same problem, my version of chrome is 118 but if I set this version it shows another error in console


Clarify issues to pass all FAPI R/W OP w/ Private Key conformance tests

By re-running the latest FAPI R/W OP w/ Private Key conformance tests against the latest keycloak to clarify issues to pass all FAPI R/W OP w/ Private Key conformance tests.

KEYCLOAK-15448
KEYCLOAK-14195
KEYCLOAK-14204
KEYCLOAK-14205
https://github.com/jsoss-sig/keycloak-fapi/issues/34

The detailed results can be found on FAPI-SIG Activities Update #3 in JPN


Implement a new algorithm to make this crate no_std

This PR resolves #28 by replacing this crate's algorithm with one that is compatible with no_std. I realized that the current algorithm is basically a concurrent queue, so I replaced it with our concurrent_queue crate. The underlying implementation is basically the same, but there is a new std feature that prevents parking primitives from being used. This is a breaking change, since removing the std feature removes the wait_* family of functions.
For now, this is a draft PR because:

I'm waiting for the changes I made to concurrent_queue to be released; right now I'm just using master.
The new implementation pasts the existing tests, but I'd like to check to see if it also passes the tests for async-channel and async-lock when it is patched in. Test suites pass when I patch in this new version of event-listener.
There's a merge conflict I don't feel like resolving right now. Should be fixed by now.
I'd like to benchmark the changes before I merge them. The new algorithm may allocate more often than the older algorithm. Although this allocation will likely be amortized over the program's runtime, I'd like to be sure that it doesn't impact performance significantly. See #31.
I also implemented partial support for loom testing, but I haven't gotten around to writing the tests for that yet.

Future considerations:

Since ConcurrentQueue::bounded() is more efficient than ConcurrentQueue::unbounded(), it may be useful to provide a "with maximum length" method that allocates everything up front.

Now that I can test the benchmarks, it seems that it's regressed to an almost unacceptable degree.

I'm not entirely sure where the extra overhead is coming from, I'll start looking into it.

Seems Miri failure is due to detached threads in doctest: https://github.com/rust-lang/miri/issues/1371
A workaround that I sometimes use is adding sleep to the end of test: https://github.com/crossbeam-rs/crossbeam/pull/891

With the newest commit, I have it down to only 30% slower.

Closing in favor of #33


Non-recoverable error: "Error while running event AbandonedRuins::on_tick (ID 0)

Running into an error when generating new chunks on a fresh save.
Screenshot of error message in-game

log of save after quitting out
factorio-current.log

Most likely the cause is another mod adding a ruin that has random  number expression with the same number for min and max. Please provide a save file that I can sync mods to so I can try to find the mod or debug further if my suspicion is incorrect. If you need to avoid the crash so you can make a save file, just set the map size to something small so no ruins spawn.


src: cleanup apytypes_util.h

This can be closed now? (Most changes seems implemented elsewhere.)

Yes, I'll close it.


Support for creating environment files from conda lock files

A very frequent pattern for the data scientists I manage is using jupyter notebooks for development and the productionalizing with Metaflow.
Right now the Jupyter Notebook -> Metaflow python conda environment transition is a friction point.
Ideally we'd like to solve the environment once, lock it with a conda lock file, and then use that lock file throughout the life of that version of the code. We also cache our python packages with an artifactory so this adds a fairly nice confidence of reproducibility.
@romain-intel I put some work in trying to figure out how to get the conda lock file input working a while ago but got pulled into other projects. I seem to remember you saying it wouldn't be a big lift. Any chance you could consider implementing this feature?
In the short term I don't anticipate having the bandwidth to get the necessary context in this project to add the functionality myself.

I think it would be easily possible to do in some cases. If you always go through conda to create your environment, that would work well (ie: conda would know about everything). If, however, you used conda and then pip, it may be harder to determine. It actually came up a few days ago internally as well. It sounds like your use case would fall more in the first category (ie: conda knows everything). I can't promise any timeline but let me see when I can get this in. You are right that it would be a very cool feature.


 After converting the output of an analysis to BIDS format using aa_export_toBIDS, I ran the validator (http://incf.github.io/bids-validator/) on it and got the following complaint:
 File Path: Repetition time did not match between the scan's header and the associated JSON metadata file.

 Type: Error
 File: sub-PL00016_task-block1_bold.nii.gz
 Location: BIDS/sub-PL00016/func/sub-PL00016_task-block1_bold.nii.gz
 Reason: Repetition time defined in the JSON (3.07 sec.) did not match the one
 defined in the NIFTI header (0 sec.)

Is this a known problem? JP thought it might have something to do with SPM dicom-to-nifti conversion.
Mike

Yes, it is a known issue, and it is, indeed caused by SPM (spm_file_merge).

As you can see here, we should probably split the 4D file using fslsplit, then merge it back again with fslmerge, with the TR flag upon exporting.

Just jumping in here without having much background in the existing code
for these tasks. But Matlab R2017b introduced built in niftiread and
niftiwrite functions which in my brief testing do a very good job with
headers/4D/nii.gz and other things I've found we usually work around a lot
with older solutions. I think aa has mostly avoided forcing matlab version
upgrades, but the new versions have shortened my own code and reduced
headaches recently.
Cheers,
Jacob Matthews
On 1 March 2018 at 14:40, Tibor Auer<EMAIL_ADDRESS>wrote:

As you can see here
https://www.nitrc.org/forum/forum.php?thread_id=6129&forum_id=1144, we
should probably split the 4D file using fslsplit, then merge it back again
with fslmerge, with the TR flag upon exporting.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/rhodricusack/automaticanalysis/issues/144#issuecomment-369706577,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AFhyNao8WtpCYekTPohsJ1Eu2rdSyRXKks5taE6mgaJpZM4SYujO
.

Can't we just modify aamod_convert_epis to use FLS merge?
I played with this last night. I changed lines 508 ff:

if isfield(aap.options, 'NIFTI4D') && aap.options.NIFTI4D
   finalepis = finalepis{1};
   ind = find(finalepis=='-');
   finalepis = [finalepis(1:ind(2)-1) '.nii'];
   spm_file_merge(char({V0(ndummies+1:end).fname}),finalepis,0);
end

to:

if isfield(aap.options, 'NIFTI4D') && aap.options.NIFTI4D
    finalepis = finalepis{1};
    ind = find(finalepis=='-');
    finalepis = [finalepis(1:ind(2)-1) '.nii'];
    TR = DICOMHEADERS{1}.volumeTR;
    filelist = sprintf('%s ',V0.fname);
    cmd = sprintf('fslmerge -tr %s %s %f', finalepis, filelist, TR);
    [ err,~ ] = aas_runfslcommand(aap, cmd);
    if (err)
        aas_log(aap,false,'Warning: Using SPM for 4D file merge. File header will not include TR');
        spm_file_merge(char({V0(ndummies+1:end).fname}), finalepis, 0);
    end
end

Then imported an epi dicom, did some preprocessing on it, and exported the results to BIDS.
The validator no longer complains about the missing TR.
If this is on the right track, I could include the change in my next PR.
Mike

Have you also checked that two two images (FSL and SPM) are identical when reading them in SPM?

They appear to be the same.
Here's a tsdiffana summary for two conversions on the same epi (first used spm_merge, second used FSL):

Looks good to me. Could you, please, also check the difference image (again is SPM using e.g. ImCalc) if it contains only zeros?

I should have though of that! :-)
Here's i1-i2 from imcalc:

Fixed by @tiborauer


[FEATURE] JRTB-12: Implement scheduling for sending notification about new articles

Description
The scheduling process for finding new articles for an active subscription must be followed by this workflow:

Acceptance Criteria:
find new articles workflow implemented as expected


Typed API: Get and document not found

When I try to get a document that doesn't exist, returned values dont't make sense.
Example
res, err := es.Get("index_name", "id_not_exists").Do(context.Background())

Returned values are a nil response and error ElasticsearchError with Status 0
I think returned values should be nil error with Response
Response{
    Index_: "index_name",
    Id_: "id_not_exists",
    Found: false,
}

Or maybe a nil response and ElasticsearchError with Status 404
Is it correct?

Thank you for reporting this.
Your reasoning is correct and it seems the specification is missing this exceptions in the Get response.
I'll add that and update this issue when the API has been regenerated!

Fixed in release release/8.8.2


[misc] Add json processor for exporting questionnaires to importable XMLs

JSON to XML export process:

Grab the form's URL from the admin dashboard:
http://localhost:8080/content.html/admin/Questionnaires/CompactSectionsTest
Remove /content.html, add all the needed export tags to the end (.deep.simple.-identify.nolinks.jsontoxml.json):
http://localhost:8080/Questionnaires/CompactSectionsTest.deep.simple.-identify.nolinks.jsontoxml.json
Save the json (right click -> "Save As" or "Save Page As" depending on what browser you are using)

For simplicity, save the file to cards/Utilities/JSON-to-XML/ with a name of your choice (CompactSectionsTest.json in this case)

In terminal, navigate to cards/Utilities/JSON-to-XML/ and run the converter (editing the file names as appropriate):
python3 json_to_xml.py CompactSectionsTest.json > CompactSectionsTest.xml

The resulting XML will be in cards/Utilities/JSON-to-XML/

This process will not lead to identical XMLs from the original source XMLs:

Any default properties will be included in the newly exported file (eg. paginate will be on all questionnaire nodes as it defaults to False when originally imported)
Ordering may not be the same

Should we restrict this processor to questionnaire resources only? i think applying this to other resources like forms might not be useful and have side effects.

Renamed to .importable and removed the requirement for the .simple and .nolinks processors


Not really an issue - Spanish Version

Hi!
There is some type of collaboration to translate this pages?
Im Learning and i like to help to translate this pages.
Im from Argentina and one of the biggest problems of latam to acces this type of content is the lenguage

Detalles del documento
⚠ No edite esta sección. Se requiere para la vinculación de problemas de docs.microsoft.com ➟ GitHub.

ID: 24c8353f-69e7-9068-9b18-df0198a1b122
Version Independent ID: 823031fe-c8a4-69cd-2b1a-9faacd282aab
Content: Classes and objects  - C# Fundamentals tutorial
Content Source: docs/csharp/fundamentals/tutorials/classes.md
Product: dotnet-csharp
Technology: csharp-fundamentals
GitHub Login: @BillWagner
Microsoft Alias: wiwagn

Hi @NachoLed
I'm adding @khoiph1 and @juricgit to this thread. They work on localization and community contributors, respectively. They can help point you to how to get involved.

@NachoLed Thank you for your offer. We are looking into this missing translation.
FEEDBACK 563566

The page is localized.

Closing as fixed. If you still believe something's missing, please leave a comment!


Unexpected behaviour when using multi key value pair entry points, chunks array and chunksSortMode

Webpack 2, and Plugin Version 2.22.0
If you have an entry point object with key value pairs:
const ENTRY = {
    b: './src/b.js'
    common: './common/src',
    vendor: './some/vendor.js',
    app: './src/app/app.js',
    a: './src/a.js'
}

I would expect the chunks  array in the plugin to define the insertion order in the template, but that isn't the case. The order of the chunk names in the plugin's chunks array has no effect when chunksSortMode none is used.
new HtmlWebpackPlugin({
            template: 'src/index.html',
            filename: 'index.html',
            chunksSortMode: 'none',
            chunks: ['vendor', 'common', 'app']
        }),

This to me seems counterintuitive. I expect the chunk names to define insertion order in this case.

The chunks array is only for exclusive filtering.
Why should sortMode none sort?

@jantimon Thanks for your response.
"The chunks array is only for exclusive filtering" - This wasn't clear to me from reading the docs. I wrongly assumed that chunks array and chunksSortMode were related. So with 'none', I didn't expect any sorting...
I expected:
chunksSortMode: 'none',
chunks: ['vendor', 'common', 'app']

...to result in
<script type="text/javascript" src="/vendor.bundle.js"></script>
<script type="text/javascript" src="/common.bundle.js"></script
<script type="text/javascript" src="/app.bundle.js"></script>

...because that's the order of the chunks names in the chunks array, combined with 'none'.
In my webpack output, these chunks are in a different order, and that's what it's actually working off.
...
chunk    {1} common.bundle.js (common) 219 kB {10} [initial] [rendered]
...
chunk    {4} app.bundle.js (app) 143 kB {7} [initial] [rendered]
...
chunk   {13} vendor.bundle.js (vendor) 7.6 MB [entry] [rendered]

So the chunks listed in the plugin's chunks array are just used the filter the above, but the order of those chunks remains the same as how they were outputted. I my case the entry object is dynamic and key value based. On each new HtmlWebpackPlugin object I'd hoped to be able to control the insertion of a select set of chunks in the order I had them listed in the chunks array.
I've written a very simply custom sort function to get the output I require.
    let chunks = ['vendor', 'common', 'app'],
        htmlPlugin = new HtmlWebpackPlugin({
           ...
            chunksSortMode: (a, b) => {
                let aIndex = chunks.indexOf(a.names[0]),
                    bIndex = chunks.indexOf(b.names[0]);
                return aIndex - bIndex;
            },
            chunks
        });

Cheers.


ci test

Can one of the admins verify this patch?

leapp-ci build

ok to test

leapp-ci build

retest this please

leapp-ci build

leapp-ci build


Add support for new 'pacts for verification' endpoint

See master issue here: https://github.com/pact-foundation/pact_broker/issues/307

Copy paste from slack conversation:

Beth (Pactflow.io) 9:48 AM
Here's the issue, but the details are in the Pact Broker repo, because I need to open one issue in each of the repos, and didn't want to have to copy/paste all that text each time.

I've never worked on pact-jvm, so I'm afraid I can't give you much guidance, but you can ask in the pact-jvm channel.
You'll need to do some Kotlin, I believe.
Having done a poke around to find the place where the pacts are currently being fetched, I believe it's these methods:

https://github.com/DiUS/pact-jvm/blob/master/core/pact-broker/src/main/kotlin/au/com/dius/pact/core/pactbroker/PactBrokerClient.kt#L93
https://github.com/DiUS/pact-jvm/blob/master/core/pact-broker/src/main/kotlin/au/com/dius/pact/core/pactbroker/PactBrokerClient.kt#L70

I'm not sure why the class is called PactBrokerConsumer, when it appears to me to be a Pact object.
You'll need to find where those two methods are called, and turn those two separate calls into one single call to the new API.

data class PactBrokerConsumer @JvmOverloads constructor (
  val name: String,
  val source: String,
  val pactBrokerUrl: String,
  val pactFileAuthentication: List<String> = listOf(),
  val tag: String? = null
)

To me, the above class looks like a Pact, not a Consumer. It may need a refactor.

Hi @bethesque , I started looking/exploring the code but didn't have enough time to actually do anything.
If someone else would like to take it, no problem (nothing will be lost 😉 ).
Said so, If Ron will take this one, is there one that I could be working on as I should have enough time from today onwards?
Thanks

I can see some commits against this card @uglyog , what's outstanding for it to be completed?

The base code is done, it just needs to be tested more

Hi,
@uglyog,  please remember to keep us posted regarding any progress here or expected release. We're looking forward to use this feature since we're facing the very issue it should solve.
Also we understand a proper testing may need time, so we'll wait whatever is needed.

This has been released with version 4.1.0

Closing as done! ❤


无法解析 debugpy 输出

at _.parseConnectInfo (/home/felix/.vscode/extensions/ms-toolsai.jupyter-2021.6.999230701/out/client/extension.js:90:160684)
at _.connectToLocal (/home/felix/.vscode/extensions/ms-toolsai.jupyter-2021.6.999230701/out/client/extension.js:90:161211)
at _.connect (/home/felix/.vscode/extensions/ms-toolsai.jupyter-2021.6.999230701/out/client/extension.js:90:159088)
at _.startDebugSession (/home/felix/.vscode/extensions/ms-toolsai.jupyter-2021.6.999230701/out/client/extension.js:90:158235)
at D.submitCode (/home/felix/.vscode/extensions/ms-toolsai.jupyter-2021.6.999230701/out/client/extension.js:37:636138)
at D.handleRunByLine (/home/felix/.vscode/extensions/ms-toolsai.jupyter-2021.6.999230701/out/client/extension.js:37:624081)

@felix3913 Could you provide more details on the enhancement you'd like to see?

Sorry, no more information.

Thanks for the feedback! However, we don't have enough information to take action here.


ERR_TUNNEL_CONNECTION_FAILED

This site can’t be reached
The webpage at buy dmt online might be temporarily down or it may have moved permanently to a new web address.
ERR_TUNNEL_CONNECTION_FAILED

Closed due to inappropriate content


Option to upload pre-compiled python file to Hub

https://github.com/XenseEducation/xs-hub/issues/9

Cherry picked last commit.


Install docs should always point to latest release, not to master

I guess we should automate this at one point :)

We should also update the deployment yaml.
I'm going to open a PR doing that and increasing the memory limit/request.


What happens with network interruptions (etc.)?

If I'm uploading a file and the lights go out, what happens?

Closed in favor of #131 and #132


sort the methods from the trait when generating methods

This is a one of the possible solutions to solve GROOVY-10704.
see #1752 for an alternative version which always keeps the methods in the original order

I think the other offered solution is preferred in terms of styling with the rest of the Groovy codebase. We don't sort except in very particular circumstances.


CRUD screen exmple will make this complete

CRUD screen exmple will make this complete. May be Employee/Customer/Product/Order

The issue is when multiple users access the app at the same time. they can mess-up each others data and create confusion. I do not intend to provide that feature now.
But checkout checkout https://github.com/mrin9/Modular-Java-Jersey-Vue
This has all the CRUD feature.


calculate-min-fee should estimate the same fee as the ledger

Given a transaction, calculate-min-fee should return the same fee (if possible) as the ledger such that upon transaction submission we do not see the FeeTooSmallUTxO error.

Construct tx body ( --fee can be set to 0)
Use calculate-min-fee to get the correct fee.

Ideally we can re-use the ledger-spec repo fee calculation.
We should check the fee estimation of small, medium and large transactions. Max tx size is currently ~16 kb.

The calculateMinimumFee function is defined here.

From cardano-node code:
runTxCalculateMinFee
: 1

I've definitely been bitten by this.
One problem that seems to occur when setting the fee of a tx, is that setting the fee can actually change the size of the transaction, thereby changing the execution units, thus incurring a different fee.
What I've been doing so far is computing a fixpoint, doing the following:

Set the fee using evaluateTransactionFee
Compute the new execution units and new fee
If they're the same as the old fee and execution units, stop
Otherwise, recurse with the new execution units and fee

This doesn't seem to work in all cases, and I have to add padding to the fee to make sure what I calculate isn't insufficient.
Am I doing something wrong? Is there a more straightforward way of accomplishing this?


fix(filters): new regexp inc/exc way.

Description
The useRuntimeConfig property in the nuxt.config.js file cannot parse a RegExp and transform it into an empty list.
Linked Issues
https://github.com/harlan-zw/nuxt-simple-sitemap/issues/184
Additional context
The new way to add the regular expression is by using an object with the property 'regex' and a string with literal notation.
Example:
sitemap: {
      exclude: [ 'something/to/exclude', { regex: '/.*hide-me.*/g' } ],
},

Ready to be checked 👍

Hey, I made some changes in https://github.com/harlan-zw/nuxt-simple-sitemap/pull/186/commits/79434aec4b622e680385acb2e7b64b510c64cab5, mostly just moving code around and adding a new layer for runtime config transforms.
Let me know if you have any questions on my changes.
I had to make a new PR as I can't push to this branch https://github.com/harlan-zw/nuxt-simple-sitemap/pull/186, will close this one and merge that one.

Good job! Thanks for the explanation 😉


chore(docs): fix typos in readme

Oh format:check, this message does not really help in fixing this quickly:
[warn] README.md
[warn] Code style issues found in the above file(s). Forgot to run Prettier?

:tada: This PR is included in version 1.0.0 :tada:
The release is available on:

npm package (@next-major dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Fix release CI script

What does this PR do?

Updates pythonpublish.yml to use the build package.

Codecov Report

Merging #3039 (d042518) into main (6884e46) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #3039   +/-   ##
=======================================
  Coverage   81.95%   81.95%
=======================================
  Files          55       55
  Lines        6030     6030
=======================================
  Hits         4942     4942
  Misses       1088     1088

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


feature: authorization_code grant with public client usage (do not merge now, but needs cf-uaa-lib)

add PKCE to authorization code
optional allow to omit client_secret

Test
uaac token authcode get -c login --port 7000
Pre-requisit is latest cf-uaa-lib library which supports PKCE and allows to omit secret

@Tallicia @torsten-sap I add you to define who could to ruby review.

https://github.com/cloudfoundry/cf-uaa-lib/pull/90 is merged now. Let's bump cf-uaa-lib so we can test out this feature.

cloudfoundry/cf-uaa-lib#90 is merged now. Let's bump cf-uaa-lib so we can test out this feature.

done

@strehle, thanks!
Question: If as you said here, the PKCE is fully backward compatible (both clients and auth-server have to support it for it to take effect; and the auth request will not fail if one of them does not support it), then what is the purpose of adding the config flag --[no-]pkce from the user perspective? Why not just always try to use PKCE?

@strehle, thanks! Manually tested, working as expected, great!
Question: If as you said here, the PKCE is fully backward compatible (both clients and auth-server have to support it for it to take effect; and the auth request will not fail if one of them does not support it), then what is the purpose of adding the config flag --[no-]pkce from the user perspective? Why not just always try to use PKCE?

ok and yes, removed the options so that it is now only creating the PKCE for authorization_code flow

Is this ready to merge or is there anything else that needs to precede merging this?

Is this ready to merge or is there anything else that needs to precede merging this?

could be merged , FYI: @peterhaochen47


Fix word

Change overwritten with overridden

@mpeyrotc
Can you review the proposed changes?
When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

#sign-off


Search node does not work without a update node defined

Hi,
I was trying to use the module and got into an error using de search node. In a flow that I am using the "search node", if I do not have a "update node" also instantiated, the search node does not work. The update node does not have to be used, just defined. I'm using the oficial docker image of node-red 1.0.3.

Found a missing piece of code in the search node. This has been fixed and version 0.1.2 has been published.


[qtbase] Failed to configure Qt6::syncqt

Operating system
Linux
Compiler
GCC
Steps to reproduce the behavior
Error is occured when configuring qtbase
Issue is only related to linux, on windows or mac there is no such problem
syncqt is located in /vcpkg_installed/x64-linux/tools/Qt6/bin/syncqt
but it is expected to be at  /vcpkg_installed/x64-linux/bin/syncqt
VCPKG_LIBRARY_LINKAGE for qtbase is set to dynamic
Failure logs
CMake Error at /usr/local/src/project/cmake-build-debug/vcpkg_installed/x64-linux/share/Qt6CoreTools/Qt6CoreToolsAdditionalTargetInfo.cmake:16 (message):
Unable to add configure time executable Qt6::syncqt
/usr/local/src/project/cmake-build-debug/vcpkg_installed/x64-linux/share/Qt6CoreTools/../../bin/syncqt
doesn't exists
Call Stack (most recent call first):
/usr/local/src/project/cmake-build-debug/vcpkg_installed/x64-linux/share/Qt6CoreTools/Qt6CoreToolsConfig.cmake:47 (include)
/usr/local/src/project/vcpkg/scripts/buildsystems/vcpkg.cmake:859 (_find_package)
cmake/QtToolHelpers.cmake:642 (find_package)
cmake/QtToolHelpers.cmake:704 (qt_internal_find_tool)
src/tools/syncqt/CMakeLists.txt:57 (qt_internal_add_configure_time_tool)

It seems like this vcpkg_replace_string, does not really replace something

vcpkg_replace_string is looking for "PACKAGE_PREFIX_DIR}/bin/syncqt", But looking inside the Qt6CoreToolsAdditionalTargetInfo.cmake I have:
# Import configure-time executable Qt6::syncqt
if(NOT TARGET Qt6::syncqt)
    set(_qt_imported_build_location "${CMAKE_CURRENT_LIST_DIR}/../../bin/syncqt")
    set(_qt_imported_install_location "${CMAKE_CURRENT_LIST_DIR}/../../bin/syncqt")

@US3RN2ME  QT has been upgraded to 6.8.0. Do you still have your problem on the latest version?

positive
config-x64-linux-out.log