building depends fails building boost on Mac OS 11.6

Describe the issue
I am attempting to build the wallet.  I downloaded raptoreum-<IP_ADDRESS>.tar.gz, uncompressed and followed the doc/build-osx.md and doc/build-generic instructions up to the point of building dependencies.  The build fails at boost.
Can you reliably reproduce the issue?
If so, please list the steps to reproduce below:
cd depends
make -j4
...
Extracting boost...
/Users/paericksen/Downloads/raptoreum-<IP_ADDRESS>/depends/sources/boost_1_64_0.tar.bz2: OK
Preprocessing boost...
Configuring boost...
Building Boost.Build engine with toolset darwin...
Failed to build Boost.Build build engine
Consult 'bootstrap.log' for more details
make: *** [/Users/paericksen/Downloads/raptoreum-<IP_ADDRESS>/depends/work/build/x86_64-apple-darwin20.6.0/boost/1_64_0-412406e1ea9/./.stamp_configured] Error 1
Expected behaviour
The dependencies should compile and the code as a whole should compile without errors.
Actual behaviour
The build fails with an error and the compiler exits at building boost.
Screenshots.
N/A
What version of Raptoreum Core are you using?
raptoreum-<IP_ADDRESS>.tar.gz
Machine specs:

OS: macOS Big Sur - version 11.6
CPU: 2.5GHz Quad-Core Intel Core i7
RAM: 16 GB 1600 MHz DDR3
Disk size: 1TB
Disk Type (HD/SDD): SSD

Any extra information that might be useful in the debugging process.
Here is the bootstrap.log file contents:

Using 'darwin' toolset.

rm -rf bootstrap
mkdir bootstrap
cc -o bootstrap/jam0 command.c compile.c constants.c debug.c execcmd.c frames.c function.c glob.c hash.c hdrmacro.c headers.c jam.c jambase.c jamgram.c lists.c make.c make1.c object.c option.c output.c parse.c pathsys.c regexp.c rules.c scan.c search.c subst.c timestamp.c variable.c modules.c strings.c filesys.c builtins.c class.c cwd.c native.c md5.c w32_getreg.c modules/set.c modules/path.c modules/regex.c modules/property-set.c modules/sequence.c modules/order.c execunix.c fileunix.c pathunix.c
execcmd.c:120:5: error: implicit declaration of function 'out_printf' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
out_printf( "...interrupted\n" );
^
1 error generated.
function.c:32:1: warning: '/' within block comment [-Wcomment]
/ /
^
1 warning generated.
hash.c:29:1: warning: '/' within block comment [-Wcomment]
/* */
^
1 warning generated.
make.c:132:13: error: implicit declaration of function 'out_printf' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
out_printf( "...found %d target%s...\n", counts->targets,
^
make.c:184:17: error: implicit declaration of function 'out_printf' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
out_printf( "fate change  %s from %s to %s (as dependant of %s)\n",
^
make.c:215:17: error: implicit declaration of function 'out_printf' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
out_printf( "fate change  %s from %s to %s (by rebuild)\n",
^
make.c:300:9: error: implicit declaration of function 'out_printf' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
out_printf( "make\t--\t%s%s\n", spaces( depth ), object_str( t->name ) );
^
make.c:300:41: warning: adding 'int' to a string does not append to the string [-Wstring-plus-int]
out_printf( "make\t--\t%s%s\n", spaces( depth ), object_str( t->name ) );
^~~~~~~~~~~~~~~
make.c:85:44: note: expanded from macro 'spaces'
#define spaces(x) ( "                    " + ( x > 20 ? 0 : 20-x ) )
~^
make.c:300:41: note: use array indexing to silence this warning
make.c:85:44: note: expanded from macro 'spaces'
#define spaces(x) ( "                    " + ( x > 20 ? 0 : 20-x ) )
^
make.c:307:41: warning: adding 'int' to a string does not append to the string [-Wstring-plus-int]
out_printf( "make\t--\t%s%s\n", spaces( depth ), object_str( t->name ) );
^~~~~~~~~~~~~~~
make.c:85:44: note: expanded from macro 'spaces'
#define spaces(x) ( "                    " + ( x > 20 ? 0 : 20-x ) )
~^
make.c:307:41: note: use array indexing to silence this warning
make.c:85:44: note: expanded from macro 'spaces'
#define spaces(x) ( "                    " + ( x > 20 ? 0 : 20-x ) )
^
make.c:380:49: warning: adding 'int' to a string does not append to the string [-Wstring-plus-int]
out_printf( "bind\t--\t%s%s: %s\n", spaces( depth ),
^~~~~~~~~~~~~~~
make.c:85:44: note: expanded from macro 'spaces'
#define spaces(x) ( "                    " + ( x > 20 ? 0 : 20-x ) )
~^
make.c:380:49: note: use array indexing to silence this warning
make.c:85:44: note: expanded from macro 'spaces'
#define spaces(x) ( "                    " + ( x > 20 ? 0 : 20-x ) )
^
make.c:388:49: warning: adding 'int' to a string does not append to the string [-Wstring-plus-int]
out_printf( "time\t--\t%s%s: %s\n", spaces( depth ),
^~~~~~~~~~~~~~~
make.c:85:44: note: expanded from macro 'spaces'
#define spaces(x) ( "                    " + ( x > 20 ? 0 : 20-x ) )
~^
make.c:388:49: note: use array indexing to silence this warning
make.c:85:44: note: expanded from macro 'spaces'
#define spaces(x) ( "                    " + ( x > 20 ? 0 : 20-x ) )
^
make.c:393:49: warning: adding 'int' to a string does not append to the string [-Wstring-plus-int]
out_printf( "time\t--\t%s%s: %s\n", spaces( depth ),
^~~~~~~~~~~~~~~
make.c:85:44: note: expanded from macro 'spaces'
#define spaces(x) ( "                    " + ( x > 20 ? 0 : 20-x ) )
~^
make.c:393:49: note: use array indexing to silence this warning
make.c:85:44: note: expanded from macro 'spaces'
#define spaces(x) ( "                    " + ( x > 20 ? 0 : 20-x ) )
^
make.c:735:13: error: implicit declaration of function 'out_flush' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
out_flush();
^
make.c:758:13: warning: adding 'int' to a string does not append to the string [-Wstring-plus-int]
spaces( depth ), object_str( t->name ) );
^~~~~~~~~~~~~~~
make.c:85:44: note: expanded from macro 'spaces'
#define spaces(x) ( "                    " + ( x > 20 ? 0 : 20-x ) )
~^
make.c:758:13: note: use array indexing to silence this warning
make.c:85:44: note: expanded from macro 'spaces'
#define spaces(x) ( "                    " + ( x > 20 ? 0 : 20-x ) )
^
6 warnings and 5 errors generated.
filesys.c:360:10: error: implicit declaration of function 'filelist_empty' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
if ( filelist_empty( archive->members ) )
^
filesys.c:496:10: error: implicit declaration of function 'filelist_empty' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
if ( filelist_empty( list ) )
^
filesys.c:534:10: error: implicit declaration of function 'filelist_empty' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
if ( filelist_empty( list ) )
^
filesys.c:570:10: error: implicit declaration of function 'filelist_empty' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
if ( filelist_empty( list ) ) return list;
^
filesys.c:593:11: error: implicit declaration of function 'filelist_empty' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
if ( !filelist_empty( list ) ) result = list->size;
^
filesys.c:602:10: error: implicit declaration of function 'filelist_empty' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
if ( filelist_empty( list ) ) return;
^
6 errors generated.
modules/path.c:16:12: error: implicit declaration of function 'file_query' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
return file_query( list_front( lol_get( frame->args, 0 ) ) ) ?
^
1 error generated.
fileunix.c:233:10: error: implicit declaration of function 'filelist_empty' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
if ( filelist_empty( archive->members ) )
^
fileunix.c:235:14: error: implicit declaration of function 'file_collect_archive_content_' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
if ( file_collect_archive_content_( archive ) < 0 )
^
fileunix.c:235:14: note: did you mean 'file_collect_dir_content_'?
fileunix.c:110:5: note: 'file_collect_dir_content_' declared here
int file_collect_dir_content_( file_info_t * const d )
^
fileunix.c:294:12: error: implicit declaration of function 'filelist_empty' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
if ( ! filelist_empty( archive->members ) ) filelist_free( archive->members );
^
3 errors generated.

Hi there,
This is  fixed on the development branch and is scheduled to be included in the next mainnet release!

I tried to compile again on the develop branch with similar results.
*side note: two packages failed to download, corrected URLs for both.
paericksen@Andys-MacBook-Pro depends % git status
On branch develop
Your branch is up to date with 'origin/develop'.
Changes not staged for commit:
(use "git add ..." to update what will be committed)
(use "git restore ..." to discard changes in working directory)
modified:   packages/boost.mk
modified:   packages/qt.mk
no changes added to commit (use "git add" and/or "git commit -a")
paericksen@Andys-MacBook-Pro depends %
paericksen@Andys-MacBook-Pro depends % git diff
diff --git a/depends/packages/boost.mk b/depends/packages/boost.mk
index bf773ccd1..92220afd7 100644
--- a/depends/packages/boost.mk
+++ b/depends/packages/boost.mk
@@ -1,6 +1,6 @@
package=boost
$(package)_version=1_64_0
-$(package)_download_path=https://dl.bintray.com/boostorg/release/1.64.0/source/
+$(package)_download_path=https://boostorg.jfrog.io/artifactory/main/release/1.64.0/source/
$(package)file_name=$(package)$($(package)_version).tar.bz2
$(package)_sha256_hash=7bcc5caace97baa948931d712ea5f37038dbb1c5d89b43ad4def4ed7cb683332
diff --git a/depends/packages/qt.mk b/depends/packages/qt.mk
index bcfe88463..9579f605f 100644
--- a/depends/packages/qt.mk
+++ b/depends/packages/qt.mk
@@ -1,6 +1,6 @@
PACKAGE=qt
$(package)_version=5.7.1
-$(package)_download_path=https://download.qt.io/archive/qt/5.7/$($(package)_version)/submodules
+$(package)_download_path=https://download.qt.io/new_archive/qt/5.7/$($(package)_version)/submodules
$(package)_suffix=opensource-src-$($(package)_version).tar.gz
$(package)_file_name=qtbase-$($(package)_suffix)
$(package)_sha256_hash=95f83e532d23b3ddbde7973f380ecae1bac13230340557276f75f2e37984e410
paericksen@Andys-MacBook-Pro depends %
Here's the relevant output from the build:
Extracting boost...
/Users/paericksen/git/raptoreum/depends/sources/boost_1_64_0.tar.bz2: OK
Preprocessing boost...
Configuring boost...
Building Boost.Build engine with toolset darwin...
Failed to build Boost.Build build engine
Consult 'bootstrap.log' for more details
make: *** [/Users/paericksen/git/raptoreum/depends/work/build/x86_64-apple-darwin20.6.0/boost/1_64_0-b7b70e14c65/./.stamp_configured] Error 1
bootstrap.log
the bootstrap.log file is attached.

mkdir bootstrap
cc -o bootstrap/jam0 command.c compile.c constants.c debug.c execcmd.c frames.c function.c glob.c hash.c hdrmacro.c headers.c jam.c jambase.c jamgram.c lists.c make.c make1.c object.c option.c output.c parse.c pathsys.c regexp.c rules.c scan.c search.c subst.c timestamp.c variable.c modules.c strings.c filesys.c builtins.c class.c cwd.c native.c md5.c w32_getreg.c modules/set.c modules/path.c modules/regex.c modules/property-set.c modules/sequence.c modules/order.c execunix.c fileunix.c pathunix.c
execcmd.c:120:5: error: implicit declaration of function 'out_printf' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
    out_printf( "...interrupted\n" );
    ^
1 error generated.
function.c:32:1: warning: '/*' within block comment [-Wcomment]```

Looks to be Gcc related if you are using gcc 11 I would recommend rolling back to 9.3 till we update with Dash 17 code.


Bug 1302069 - Printing canvases at PDF document size.

Trying to make printing code sane -- it attempts to print canvases with sizes that are specified in the PDF document. Problem only appear when automatic/non-100% scale is selected in the browser or paper is smaller than PDF page needs. Pros is scale of the print can be now controlled by the user (https://bugzilla.mozilla.org/show_bug.cgi?id=1302069).

/botio-linux preview

Nice cleanup! It turns out that when I printed to PDF before, the scale was set to 200% by Firefox (I'm not sure if that's a default or it's somehow set that way, but I didn't set that manually). When I set that to 100% as it should be, it prints just fine. We'll need to do more testing of course, but at least this looks good.

/botio-linux preview

/botio-windows preview

Testing on my local computers (Mac and Win) did not discover any regressions (on different browsers). @timvandermeij confirms it work fine on Linux as well. We good to merge.

Nice work!

Awesome, you guys are!
The initial bug of IE only printing half a page seems to be fixed with this new update.
Except, I do not believe this is fully off the table yet (frowns at IE). I am using pdf.js version 1.6.258 and have also tested the above 1.6.218 against a few documents I am trying to get this to work with, and I see the following 2 things happening...

When loading the viewer.html into a tab within IE 11.633.10586.0 the pages we have overflow onto an additional page and leaves blank pages every other page being printed.

When loading the viewer.html into an iframe within IE 11.633.10586.0 the pages we have fit within their expected print pages without overflowing, except they are way smaller. They add a large margin & take up only a quarter of the available print page space.

I realize these are 2 separate issues, just noting them here since all the above issues are what I have been following. Unfortunately the documents in question contain sensitive information and I am unable to just post some links at this time, I will try and re-produce the above with links using a different document and open proper issue reports.
I appreciate all the work you guys are doing to solve IE's unruly issues!
Thanks!

There is nothing can be done about issues above -- browser does not inform about pages it prints. What we can do is detect if browser has top/bottom margins, truncate images from top/bottom or prescale it (Notice that you can scale it in IE during printing). Safari for Mac OSX has the similar issue.

For #1 above, I believe I understand what the issue may be, though pdf.js in any browser but IE handles the page height without issues, I can even set it in the PDF to 350mm and it works in all browsers, but for IE it stops just short or defaults back to the A4 paper size height which is 297mm. I will research more before claiming it to be a pdf.js issue and will report back.
For #2 above, when the viewer is in an iframe, the printed result is a little larger then a quarter of the page (width and height). I have not been able to look further into this, but am able to show it happening even with your default pdf provided with the viewer. When I get a chance to look into this further, I will provide an issue report if its pdf.js' issue.
Either way, thanks again for your hard work guys.

When we try to load the .msg file with landscape from pdf.js using chrome browser the quality of the print is not fine and it becomes blur and unable to read the content is their any solution for this.
Step1 :- We shrinked the  content of the page to set in to the widht of the pdf using c++ dlls and then we are trying to print the shrinked contents in lanscape mode but pdf.js the file content is blur in print prieview.
Same pdf document if we print outside it is working fine is their any solution for this.
Thanks
Madhavan
<EMAIL_ADDRESS>


ignore upcoming warnings

This PR will prevent warnings once https://github.com/flutter/flutter/pull/104231 has landed.

No, these need a version change because they don't meet our exemption criteria.

Done. Thanks for your help.

These are warnings that will show up for clients of the plugin.

I'm not sure to understand what you refer to. Could you give me an example please?

According to the federated_safety task I splitted this PR into #5855 and #5856 .

These are warnings that will show up for clients of the plugin.

I'm not sure to understand what you refer to. Could you give me an example please?

Make a new Flutter app.
Add this lint.
Add a dependency on webview_flutter
Build using a local version of Flutter with https://github.com/flutter/flutter/pull/104231

You will see these warnings; the same would happen for everyone else once that PR has landed.

The client will see (new) warnings in its own code but he will not see warnings inside the webview_flutter plugin he depends on. That's why I didn't thought a Changelog entry was needed (before reading the exemption criteria).
Thanks for your feedback!

The client will see (new) warnings in its own code but he will not see warnings inside the webview_flutter plugin he depends on.

Why wouldn't they see warnings from webview_flutter? I thought all transitive Dart warnings were surfaced.

Why wouldn't they see warnings from webview_flutter? I thought all transitive Dart warnings were surfaced.

I just made a quick test and it looks like the analyzer don't show any warning from the dependency.

Why wouldn't they see warnings from webview_flutter? I thought all transitive Dart warnings were surfaced.

No, in your app or package you will not see warnings that occur inside your dependencies.

Oh, sorry about that. I must have just conflated the Dart behavior with the plugin builds that I'm more used to.
In that case you were correct that these don't need version changes (although should still have changelog changes).


Any full example for using smtp pool

Can we have full code example for smtp pool usage. Current examples only include creation of transport. But how do we send mail?

See Nodemailer examples here.

@andris9 Those are examples for nodemailer but I was more focused on using smpt-pool with nodemailer can I get an example on that?

Take the linked Nodemailer example and replace createTransport block with the code from this README and thats it

See this example: https://gist.github.com/andris9/411857993e8935c77c48


[FAI-133] 05-2020 demo

DO NOT MERGE. This PR is used to run the CI with integration tests on the demo branch

Looks like there's conflicts to be resolved....

I've resolved the conflicts.


Problem with other HoN integrations

If you want to have two different HoN integration installed. Lets say for testing purpose, you have a problem since this integration have the same "name" as other.
Example:
This: https://github.com/gvigroux/hon/
Other: https://github.com/Andre0512/hon/
I installed one first (not remember which one) and then the second to check the difference. Now, everything is mixed mode. In UI they are both showing under HoN, but in other places they are not the same. Then, if you remove one, it still shows as it is installed (no matter which one you remove first.
It would be nice if they are in different name space.

I already tried to change the namespace to avoid the collision with the Andre's integration but I need to change a lot of things.
I close this one because there are already one ticket open: https://github.com/gvigroux/hon/issues/105


update pypi version

update pypi version to include: 1. auto docker push; 2. push python suggested version to pypi
Summary of Changes
Include a summary of changes then remove this line
Tests
What tests did you add or modify and why? If no tests were added or modified, explain why. Remove this line
Documentation
What documentation did you add or modify and why? Add any relevant links then remove this line
CheckList
Make sure you have checked all steps below to ensure a timely review.

[ ] PR title addresses the issue accurately and concisely. Example: "Updates the version of Flask to v1.0.2"

In case you are adding a dependency, check if the license complies with the ASF 3rd Party License Policy.

[ ] PR includes a summary of changes, including screenshots of any UI changes.
[ ] PR adds unit tests, updates existing unit tests, OR documents why no test additions or modifications are needed.
[ ] In case of new functionality, my PR adds documentation that describes how to use it.

All the public python functions and the classes in the PR contain docstrings that explain what it does

[ ] PR passes all tests documented in the developer guide
[ ] I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message"

cc @ttannis

https://img.shields.io/pypi/pyversions/amundsen-frontend.svg is still mising

Codecov Report

Merging #157 into master will increase coverage by 20.8%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #157      +/-   ##
==========================================
+ Coverage   53.13%   73.93%   +20.8%
==========================================
  Files         106       20      -86
  Lines        2650      890    -1760
  Branches      273       76     -197
==========================================
- Hits         1408      658     -750
+ Misses       1213      206    -1007
+ Partials       29       26       -3

Impacted Files
Coverage Δ

...ication/static/js/components/common/Tabs/index.tsx

...ndsen_application/static/js/ducks/search/api/v0.ts

...ication/static/js/components/common/Flag/index.tsx

...ts/common/ResourceListItem/TableListItem/index.tsx

...sen_application/static/js/ducks/allTags/reducer.ts

...tatic/js/components/common/ScrollTracker/index.tsx

...pplication/static/js/ducks/popularTables/api/v0.ts

...js/components/TableDetail/WatermarkLabel/index.tsx

...sen_application/static/js/config/config-default.ts

...n/static/js/components/common/InfoButton/index.tsx

... and 76 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db8a1c4...fe81bec. Read the comment docs.


Fix rst syntax of :filename: example

(Otherwise building the docs tried to execute the example below it, and errored when trying to open script.py)

Good catch!


Material icons from npm

Using npm module of material icons there is no longer a need to include the icons with an import/link, so you can use the datatable also in offline projects.
PS: I used @import('~material..') but I don't know if it's compatible for plain CSS/Webpack and other

@MicroDroid I´m not sure about that - this will increase the size and it could be possible that the users already fetching the font from google, so they will download unnecessary data. Also i'm not sure about the @import statement.
@DaniloPolani For upcoming ideas it could be great if you first could create a issue to tell your idea. We could argue about that and It prevents you from implementing something wich would not necessarily be merged into it. Thanks :)

I'm just thinking, given that the user is already loading Material Icons from some other source, wouldn't this forcefully load it again since it's seemingly coming from a new source? and possibly end up with the font being loaded more than once in the final bundle?
Me thinks it's better to keep the font external so we're sure its loaded once plus loading it from a CDN makes the browser benefit from caching, as it's very likely for the browser to already have a cached copy of such resource. Not entirely sure though myself about it.

I think yes, as an alternative to Google Web Fonts.

Wait we can keep this open 🤔


ec2 list_volumes should accept more filters

ec2 list_volumes should accept more filters
Description
EC2 API requests are throttled which sometimes requires the API requests to be more fine tuned to avoid having to get back large amounts of responses. For more information, see this the AWS API reference.
This change adds the ability to pass more filters to the EC2 DescribeVolumes call, the filter needs to be a dictionary of filter name and value pairs as described here.
I had 2 options here:

Remove the node parameter from this call and ensure that the caller passes in the node ID as part of the filters dict.
Add a new parameter filters and leave the node parameter as it is in order to preserve the original method signature.

I chose the latter only for the reason that it preserves the original method signature.
Status

done, ready for review

Checklist (tick everything that applies)

[x] Code linting (required, can be done after the PR checks)
[x] Documentation
[x] Tests
[x] ICLA (required for bigger changes)

Codecov Report

Merging #1300 into trunk will decrease coverage by <.01%.
The diff coverage is 40%.

@@            Coverage Diff             @@
##            trunk    #1300      +/-   ##
==========================================
- Coverage   85.96%   85.96%   -0.01%
==========================================
  Files         362      362
  Lines       74155    74158       +3
  Branches     6725     6727       +2
==========================================
+ Hits        63748    63749       +1
+ Misses       7715     7714       -1
- Partials     2692     2695       +3

Impacted Files
Coverage Δ

libcloud/compute/drivers/ec2.py
74.22% <40%> (-0.08%)
:arrow_down:

libcloud/test/compute/test_upcloud.py
90.06% <0%> (-1.33%)
:arrow_down:

libcloud/test/compute/test_ec2.py
97.9% <0%> (+0.16%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f9e7f22...6b5932e. Read the comment docs.

Merged, thanks for the contribution.


Necessary mods to port repo to Gridap 0.17

Work in progress, subject to passing tests, among others

Codecov Report

Merging #25 (d4b8876) into master (6892e56) will increase coverage by 0.76%.
The diff coverage is 96.29%.

@@            Coverage Diff             @@
##           master      #25      +/-   ##
==========================================
+ Coverage   58.83%   59.59%   +0.76%
==========================================
  Files          17       17
  Lines         911      896      -15
==========================================
- Hits          536      534       -2
+ Misses        375      362      -13

Impacted Files
Coverage Δ

src/CubedSphereTriangulations.jl
87.50% <87.50%> (+59.72%)
:arrow_up:

src/CubedSphereDiscreteModels.jl
100.00% <100.00%> (+0.99%)
:arrow_up:

src/ShallowWaterIMEX.jl
97.82% <0.00%> (-0.02%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6892e56...d4b8876. Read the comment docs.

Hi @amartinhuertas , thank you for taking the initiative on this. I am happy for you to merge these.
I am currently doing some work on the thermal swes:
https://github.com/gridapapps/GridapGeosciences.jl/tree/tsw_thermogeostrophic
but I don't think this should conflict with your updates. I will pull your changes into my branch once they are merged.

Ahhh ... I forgot to mention something!
This PR also solves https://github.com/gridapapps/GridapGeosciences.jl/issues/13 for the sequential cubed sphere mesh. This is a plus which comes with Gridap 0.17.

Thanks @amartinhuertas . Is this using the P4est or custom 6n^2 mesh?

This PR also solves #13 for the sequential cubed sphere mesh. This is a plus which comes with Gridap 0.17.

After taking a much careful look at the new code, I have realized that this statement is false. Sorry about that! For the sequential CubedSphereDiscreteModel we still generate a volume cartesian mesh of the cube (with the current approach).
I was confused by another scenario in which Gridap 0.17 let us handle a manifold mesh without background volume mesh (e.g., when you read a surface mesh from data files). This does not mean that the issue cannot be solved with the current machinery in Gridap's Geometry module, but it requires some extra work. Anyway, I would not carry out this work because of the following.

Is this using the P4est or custom 6n^2 mesh?

Using P4est, i.e., CubedSphereDistributedDiscreteModel, this issue is solved. It was solved even before Gridap 0.17. We only have this bottleneck for the sequential CubedSphereDiscreteModel. As I said above, it can be solved, but requires work that I would not do.

No worries @amartinhuertas ,  as you say, probably not worth investing in the serial implementation too much. At high resolutions the serial code will have no shortage of performance problems :)


[DT] Next steps for data tiling fusion improvements

Overview
This issue is a tracker for the next steps of enabling the data tiling fusion improvements, which are currently behind the --iree-dispatch-creation-experimental-data-tiling flag. Once the steps here are complete, there should be fairly reasonable support for general grouped quantized matmul operations through data tiling.
The main steps are as follows:

Allow SetEncoding to set encodings on contraction ops that have greater than one batch, M, N, or K dimension.
Support multi batch/M/N/K contractions in MaterializeEncoding.
Make a lowering path for new data tiled multi batch/M/N/K contractions.
Add a new matching pattern for UKernels to lower new data tiled multi batch/M/N/K to UKernel ops.

1. SetEncoding
This change should be very simple. SetEncoding should not behave any differently with multiple batch, M, N, or K dimensions. We just need to remove the restriction in the pass for single batch/M/N/K dimensions.
2. MaterializeEncoding
This is a more involved step, since materializing a multi batch/M/N/K dimension contraction cannot create an MMT4D op. Instead, we need to create a linalg.generic op with the appropriate iterator_types and indexing_maps. There are useful functions for checking if generic ops are contractions, and getting the appropriate dimension mapping to batch, M, N, and K dimensions here:
https://github.com/llvm/llvm-project/blob/030c6da7af826b641db005be925b20f956c3a6bb/mlir/include/mlir/Dialect/Linalg/IR/LinalgInterfaces.h#L50-L71
Here is an example of how this is used to find the narrow M and N sizes of a matmul:
https://github.com/iree-org/iree/blob/febe0edba1ea4b29135d23d64d84417b7a106be8/compiler/src/iree/compiler/DispatchCreation/SetEncoding.cpp#L56-L67
I have written some IR for what I would expect the final transformation to look like below. Note that the only materialization pattern that should be needed is the one for the final contraction operation. The patterns for set_encoding, unset_encoding, and dequant ops should already be supported. I only included them in this example so it is clear where this all comes from.
module {
  func.func @grouped_quantized_matmul(%lhs: tensor<1024x32x128xf32>, %rhs_quant: tensor<11008x32x128xi4>,
                                      %scales: tensor<11008x32xf32>, %zps: tensor<11008x32xf32>) -> tensor<1024x11008xf32> {
    %cst = arith.constant 0.000000e+00 : f32
    %dq_init = tensor.empty() : tensor<11008x32x128xf32>
    %rhs = linalg.generic {
        indexing_maps = [affine_map<(d0, d1, d2) -> (d0, d1, d2)>,
                         affine_map<(d0, d1, d2) -> (d0, d1)>,
                         affine_map<(d0, d1, d2) -> (d0, d1)>,
                         affine_map<(d0, d1, d2) -> (d0, d1, d2)>],
        iterator_types = ["parallel", "parallel", "parallel"]}
        ins(%rhs_quant, %scales, %zps : tensor<11008x32x128xi4>, tensor<11008x32xf32>, tensor<11008x32xf32>) outs(%dq_init : tensor<11008x32x128xf32>) {
    ^bb0(%in: i4, %in_0: f32, %in_1: f32, %out: f32):
      %5 = arith.extui %in : i4 to i32
      %6 = arith.uitofp %5 : i32 to f32
      %7 = arith.subf %6, %in_1 : f32
      %8 = arith.mulf %7, %in_0 : f32
      linalg.yield %8 : f32
    } -> tensor<11008x32x128xf32>
    %empty = tensor.empty() : tensor<1024x11008xf32>
    %mm_init = linalg.fill ins(%cst : f32) outs(%empty : tensor<1024x11008xf32>) -> tensor<1024x11008xf32>
    %mm = linalg.generic {
        indexing_maps = [affine_map<(d0, d1, d2, d3) -> (d0, d2, d3)>,
                         affine_map<(d0, d1, d2, d3) -> (d1, d2, d3)>,
                         affine_map<(d0, d1, d2, d3) -> (d0, d1)>],
        iterator_types = ["parallel", "parallel", "reduction", "reduction"]}
        ins(%lhs, %rhs : tensor<1024x32x128xf32>, tensor<11008x32x128xf32>) outs(%mm_init : tensor<1024x11008xf32>) {
    ^bb0(%in: f32, %in_0: f32, %out: f32):
      %5 = arith.mulf %in, %in_0 : f32
      %6 = arith.addf %5, %out : f32
      linalg.yield %6 : f32
    } -> tensor<1024x11008xf32>
    return %mm : tensor<1024x11008xf32>
  }

  // ======================================================================== //
  // ======= @grouped_quantized_matmul after materializing encodings: ======= //
  // ======================================================================== //

  func.func @packed_grouped_quantized_matmul(%lhs: tensor<1024x32x128xf32>, %rhs_quant: tensor<11008x32x128xi4>,
                                      %scales: tensor<11008x32xf32>, %zps: tensor<11008x32xf32>) -> tensor<1024x11008xf32> {
    %cst = arith.constant 0.000000e+00 : f32
    %cst_i4 = arith.constant 0 : i4
    // LHS pack ( [M x K0 x K1] -> [M x K0 x K1 x m x k1] )
    %pack_lhs_init = tensor.empty() : tensor<256x32x8x4x16xf32>
    %pack_lhs = tensor.pack %lhs padding_value(%cst : f32)
                                 outer_dims_perm = [0, 1, 2]
                                 inner_dims_pos = [0, 2]
                                 inner_tiles = [4, 16] into %pack_lhs_init
        : tensor<1024x32x128xf32> -> tensor<256x32x8x4x16xf32>
    // Scales pack ( [N x K0] -> [N x K0 x n] )
    %pack_scales_init = tensor.empty() : tensor<1376x32x8xf32>
    %pack_scales = tensor.pack %scales padding_value(%cst : f32)
                                 outer_dims_perm = [0, 1]
                                 inner_dims_pos = [0]
                                 inner_tiles = [8] into %pack_scales_init
        : tensor<11008x32xf32> -> tensor<1376x32x8xf32>
    // Zero points pack ( [N x K0] -> [N x K0 x n] )
    %pack_zps_init = tensor.empty() : tensor<1376x32x8xf32>
    %pack_zps = tensor.pack %zps padding_value(%cst : f32)
                                 outer_dims_perm = [0, 1]
                                 inner_dims_pos = [0]
                                 inner_tiles = [8] into %pack_zps_init
        : tensor<11008x32xf32> -> tensor<1376x32x8xf32>
    // RHS quant pack ( [N x K0 x K1] -> [N x K0 x K1 x n x k1] )
    %pack_rhs_init = tensor.empty() : tensor<1376x32x8x8x16xi4>
    %pack_rhs_quant = tensor.pack %rhs_quant padding_value(%cst_i4 : i4)
                                 outer_dims_perm = [0, 1, 2]
                                 inner_dims_pos = [0, 2]
                                 inner_tiles = [8, 16] into %pack_rhs_init
        : tensor<11008x32x128xi4> -> tensor<1376x32x8x8x16xi4>
    %dq_init = tensor.empty() : tensor<1376x32x8x8x16xf32>
    %pack_rhs = linalg.generic {
        indexing_maps = [affine_map<(d0, d1, d2, d3, d4) -> (d0, d1, d2, d3, d4)>,
                         affine_map<(d0, d1, d2, d3, d4) -> (d0, d1, d3)>,
                         affine_map<(d0, d1, d2, d3, d4) -> (d0, d1, d3)>,
                         affine_map<(d0, d1, d2, d3, d4) -> (d0, d1, d2, d3, d4)>],
        iterator_types = ["parallel", "parallel", "parallel", "parallel", "parallel"]}
        ins(%pack_rhs_quant, %pack_scales, %pack_zps : tensor<1376x32x8x8x16xi4>, tensor<1376x32x8xf32>, tensor<1376x32x8xf32>)
        outs(%dq_init : tensor<1376x32x8x8x16xf32>) {
    ^bb0(%in: i4, %in_0: f32, %in_1: f32, %out: f32):
      %5 = arith.extui %in : i4 to i32
      %6 = arith.uitofp %5 : i32 to f32
      %7 = arith.subf %6, %in_1 : f32
      %8 = arith.mulf %7, %in_0 : f32
      linalg.yield %8 : f32
    } -> tensor<1376x32x8x8x16xf32>
    // Matmul init ( [M x N x m x n] )
    %empty = tensor.empty() : tensor<256x1376x4x8xf32>
    %mm_init = linalg.fill ins(%cst : f32) outs(%empty : tensor<256x1376x4x8xf32>) -> tensor<256x1376x4x8xf32>
    %mm = linalg.generic {
        indexing_maps = [affine_map<(M, N, K0, K1, m, n, k1) -> (M, K0, K1, m, k1)>,
                         affine_map<(M, N, K0, K1, m, n, k1) -> (N, K0, K1, n, k1)>,
                         affine_map<(M, N, K0, K1, m, n, k1) -> (M, N, m, n)>],
        iterator_types = ["parallel", "parallel", "reduction", "reduction", "parallel", "parallel", "reduction"]}
        ins(%pack_lhs, %pack_rhs : tensor<256x32x8x4x16xf32>, tensor<1376x32x8x8x16xf32>) outs(%mm_init : tensor<256x1376x4x8xf32>) {
    ^bb0(%in: f32, %in_0: f32, %out: f32):
      %5 = arith.mulf %in, %in_0 : f32
      %6 = arith.addf %5, %out : f32
      linalg.yield %6 : f32
    } -> tensor<256x1376x4x8xf32>
    %unpack_init = tensor.empty() : tensor<1024x11008xf32>
    %unpack = tensor.unpack %mm outer_dims_perm = [0, 1]
                                inner_dims_pos = [0, 1]
                                inner_tiles = [4, 8] into %unpack_init
        : tensor<256x1376x4x8xf32> -> tensor<1024x11008xf32>
    return %unpack : tensor<1024x11008xf32>
  }
}

3. Lowering Path
The next thing we need is a lowering path for the resulting data tiled matmul:
%mm = linalg.generic {
    indexing_maps = [affine_map<(M, N, K0, K1, m, n, k1) -> (M, K0, K1, m, k1)>,
                     affine_map<(M, N, K0, K1, m, n, k1) -> (N, K0, K1, n, k1)>,
                     affine_map<(M, N, K0, K1, m, n, k1) -> (M, N, m, n)>],
    iterator_types = ["parallel", "parallel", "reduction", "reduction", "parallel", "parallel", "reduction"]}
    ins(%pack_lhs, %pack_rhs : tensor<256x32x8x4x16xf32>, tensor<1376x32x8x8x16xf32>) outs(%mm_init : tensor<256x1376x4x8xf32>) {
^bb0(%in: f32, %in_0: f32, %out: f32):
  %5 = arith.mulf %in, %in_0 : f32
  %6 = arith.addf %5, %out : f32
  linalg.yield %6 : f32
} -> tensor<256x1376x4x8xf32>

This primarily means setting an appropriate lowering configuration for the op, but there will likely be issues to solve in whatever lowering pipeline this goes down. There are a few changes to be made for lowering configurations:

Right now, generic op contractions will get a default GenericOp configuration:
https://github.com/iree-org/iree/blob/febe0edba1ea4b29135d23d64d84417b7a106be8/compiler/src/iree/compiler/Codegen/LLVMCPU/KernelDispatch.cpp#L2245-L2250
Even when the contraction is a generic op, it should be handled as a contraction op. This means we need some new logic to handle linalg ops for which linalg::isaContractionOpInterface returns true. There is something similar done in GPU configurations:
https://github.com/iree-org/iree/blob/febe0edba1ea4b29135d23d64d84417b7a106be8/compiler/src/iree/compiler/Codegen/LLVMGPU/KernelConfig.cpp#L854-L864
In general, I think contraction ops with multiple M, N or K dimensions should have all outer M/N/K dimensions tiled to 1 as an initial strategy.
Once there is some logic in place to set configurations based on contraction dimensions, we should refactor the existing matmul-like op config logic to use the new logic. This is more of a code clean-up task, so everything is in one place.
The pipeline to use will be the new TileRootFuseConsumerProducer pipeline. There may be some issues along the way to solve as more dispatches are tested on the new pipeline.

Lower to UKernels
UKernels are rooted on MMT4D ops right now, and we don't want to lose the benefits of ukernels when we materialized generic ops instead of mmt4d. The CPULowerToUKernels pass converts a set of named operations into UKernel ops based on some matching patterns called here:
https://github.com/iree-org/iree/blob/febe0edba1ea4b29135d23d64d84417b7a106be8/compiler/src/iree/compiler/Codegen/Common/CPU/CPULowerToUKernels.cpp#L584-L585
A new matchDAGForUKernel matcher will be needed for linalg.generic ops. The new matcher will need to check the shapes of the generic op inputs against the supported ukernel shapes, since it is not guaranteed that an arbitrary generic op will match the shape of a ukernel. Would be good to get @bjacob's input on this, since matching against all possible ukernel shapes seems a little cumbersome.
Another detail is that we will most likely want to do some unit dim folding after tiling to get rid of outer unit dimensions on the contractions. This will make matching ukernels much more simple.
Final Comments
The sequence of steps in the overview are listed in some order, but that is not a strict dependency order. Particularly, steps 2. and 3. could be done in either order, since I have provided some example IR after materialization. Doing 3. first could provide some lessons for the particular form we want as a result of 2. in general. Although 3. is dependent on 2. for e2e enablement, they could be worked on in parallel.

Regarding matching generic to mmt4d ukernels:
This can be viewed as 2 separate steps:

Match linalg.generic to linalg.mmt4d. This is the new code that needs to be written. It can be a separate pass or pattern, independent of ukernels.
From there, the existing CPULowerToUkernels pass can run, unmodified.

So all you need to do here is that step 1.
There is a caveat about what "support" means. The mmt4d ukernel supports arbitrary linalg.mmt4d ops shapes, for the supported combinations of element types, in the sense that the lowering always succeeds and there is always an actual ukernel to handle any case. The caveat is about performance: that wide support is achieved thanks to a slow fallback (which is slower than any generic codegen), so there is a performance cliff here, that one can silently fall off of.
The worst-case scenario then is that implementing the linalg.generic to linalg.mmt4d rewrite causes a workload to hit the slow ukernel path. However, that problem preexists with workloads that use linalg.mmt4d ops. The reason why we haven't prioritized solving it is a combination of: it's not been such a big deal (because we have added ukernel fast paths as needed) and it's not trivial to fix because this requires enlarging the contact surface between ukernels and the compiler. However, if we are willing to do that, then the solution is a simple enough PR: https://github.com/iree-org/iree/pull/16880 . It is simple, because we have already structured the ukernels code to have a declarative table enumerating fast code paths, so that PR is a simple matter of exposing that to the compiler.

There is a caveat about what "support" means. The mmt4d ukernel supports arbitrary linalg.mmt4d ops shapes, for the supported combinations of element types, in the sense that the lowering always succeeds and there is always an actual ukernel to handle any case. The caveat is about performance: that wide support is achieved thanks to a slow fallback (which is slower than any generic codegen), so there is a performance cliff here, that one can silently fall off of.

I see, thanks for the context. I think it makes sense to start by unconditionally converting linalg.generic to mmt4d. It would be best to complicate the current next steps as little as we can. We can leave it as a potential TODO in case we hit any future performance pitfalls in the wild.


cart::update

my data
9b0b392f6b8b664a43e68bea428d303e: {
rowId: "9b0b392f6b8b664a43e68bea428d303e",
id: 8,
name: "name",
qty: 1,
price: 70,
options: {
size: "",
color: "",
img: "product08.jpg",
url: "/"
},
tax: 12.6,
subtotal: 70
}
Cart::update($rowId, [
'qty' => $qty,
'options' => [
'size' => $size,
'color => $color
]
]);
problem: don't update

Hi,
Could you give us some more information please?
Such as your Laravel version, code in your controller, etc.
Thanks.
Op do 10 mei 2018 om 16:24 schreef arge01<EMAIL_ADDRESS>
my data
9b0b392f6b8b664a43e68bea428d303e: {
rowId: "9b0b392f6b8b664a43e68bea428d303e",
id: 8,
name: "name",
qty: 1,
price: 70,
options: {
size: "",
color: "",
img: "product08.jpg",
url: "/"
},
tax: 12.6,
subtotal: 70
}
Cart::update($rowId, [
'qty' => $adet,
'options' => [
'size' => $size,
'color => $color
]
]);
problem: don't update
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/Crinsane/LaravelShoppingcart/issues/458, or mute the
thread
https://github.com/notifications/unsubscribe-auth/AUM9kJFqSrMkIruf_Ajnt60ptQIiHeTkks5txE2jgaJpZM4T5-dg
.

--
Met vriendelijke groeten,
Siemen Rotensen


'TemplateProxy' object has no attribute 'get_exception_info'

Happens when I used a model that wasn't migrated yet, so there was probably some underlaying database error.
The line that threw the error was the partial template tag.

OK, yes, that's for the debug template. (At least the bottom part of the traceback would be helpful.)
TemplateProxy should likely implement something here, so as not to error.
Fancy doing that?

Yes, was already looking at what was needed.

Great. Thanks. For first pass, something minimal would be enough. (I don't know we need to copy too much from Django...)


The following module(s) are unknown: "bowtie"

Thanks for developing the software, I think it will be of great help for the research.
I have a problem, when installing miRge3.0 through conda I get the following error and I don't know how to solve it: Bowtie is as a command in the environment created for miRge3.0.
Lmod has detected the following error: The following module (s) are unknown:
"bowtie"
Please check the spelling or version number. Also try "module spider ..."
It is also possible your cache file is out-of-date; it may help to try:
$ module --ignore-cache load "bowtie"
Also make sure that all modulefiles written in TCL start with the string
#% Module
Lmod has detected the following error: The following module (s) are unknown:
"bowtie"
Please check the spelling or version number. Also try "module spider ..."
It is also possible your cache file is out-of-date; it may help to try:
$ module --ignore-cache load "bowtie"
Also make sure that all modulefiles written in TCL start with the string
#% Module
Greetings

Hi @ramostapiai,
Thank you. Installation with Conda is the ideal way to go. I believe that you are installing miRge3.0 on the base environment on your cluster (which is interfering with other modules). Can you try creating an environment and install miRge3.0 as shown below:
conda create --name myenv
conda activate myenv
conda install -c bioconda mirge3

To come out of the virtual enviroment myenv, type the following command
conda deactivate

Please let me know if this solution works. If the bowtie is already installed on your server (you can check by module spider bowtie), installation of bowtie with conda on the base environment might throw such an error. It is ideal to use virtual environments as shown above.
Thank you,
Arun.

Hi @arunhpatil,
Thanks for the reply. In fact it is in an exclusive environment of mirge3, anyway I have done it again and the problem persists.
bowtie error !: bowtie, command not found
Use argument -pbwt
By typing bowtie -h inside the environment bowtie is there:
bowtie -h
usage: bowtie [-h] [-b | -i] [--verbose] [--debug] [--large-index]
[--index INDEX]
optional arguments:
-h, --help show this help message and exit
-b, --build
-i, --inspect
--verbose
--debug
--large-index
--index INDEX
How other option i have?
Thanks again
Ignacio

Thanks for the help.
I tell you, which bowtie works, but locate bowtie doesn't. I have given the path from bowtie to mirge3 and it has not worked again:
bowtie error !: bowtie, command not found
Use argument -pbwt
Check if conda is not in the path and add it to the bash_profile of the cluster user,

Hi, can you share the command you are using (with and without -pbwt)? That will help me to rule out what could be wrong. (You may keep synonym for file name -s file_name.fastq.gz)
Thank you,
Arun.

Yes of course I can, I have previously defined the input and output directories and made an array for my 694 samples.
Maybe I am performing many actions perhaps, but I could not find the simplest base command of mirge3.
i=$(sed -n "$SLURM_ARRAY_TASK_ID"p /home/sample_list.txt)
source activate /GWSPH/home/ecastron/miniconda3/envs/mirge3
#directories
fastq="/home/raw_data/sequences"
output="home/output_mirge3"
miRge3.0
-s $fastq/${i}_R1_trimmed.fastq.gz
-lib miRge3_Lib
-on human
-db /home/miRge3_Lib
-o $output
-gff
-bam
-nmir
-trf
-ai
-cpu 16
-pbwt /home/ecastron/miniconda3/envs/mirge3/bin/bowtie

Ok. small correction, please provide this -pbwt /home/miniconda3/envs/mirge3/bin instead of -pbwt /home/miniconda3/envs/mirge3/bin/bowtie.  Also, -db should be either miRBase or miRGeneDB.
This should fix the problem. However, I recommend you to test 2 samples at first as shown below:
example: miRge3.0 -s infile1.fastq.gz,infile2.fastq.gz -lib miRge3_Lib -on human -db miRGeneDB -o output_dir -gff -nmir -trf -ai -cpu 16 -pbwt  /home/miniconda3/envs/mirge3/bin
Please let me know if this works.
Thanks,
Arun.

Ok, I have made the corrections but it is still the same error: bowtie error !: bowtie, command not found. I have tried with only one sample but the problem persists.

Hi @ramostapiai,
I want to try one last thing. Can you check the version of the bowtie using the complete path as shown below?  If this doesn't work out, is it possible to have a zoom meeting so I can quickly check the issue?
/home/miniconda3/envs/mirge3/bin/bowtie --version
Thank you,
Arun.

Oops !, I think my conda is not working well or there is something else.
With regard to zoom there is no problem another day, I apologize if my English is not the best in the world. I try to improve it
~/miniconda3/envs/mirge3/bin/bowtie --version
~/home/miniconda3/envs/mirge3/bin/bowtie-align-s: error while loading shared libraries: libtbb.so.2: cannot open shared object file: No such file or directory

Hi @ramostapiai,
Great, now I know the error. You need to call this library (tbb) prior to calling bowtie. If you are using a cluster with support to slurm/module you can look for tbb by module spider tbb. You could install/load  tbb/4.1 which I think is the latest version. If you can load this library, this issue will be resolved.  See if this works, I will tell you how to make this a permanent set up on the cluster.
Thank you,
Arun.

@ramostapiai, Awesome. I am glad it worked.


Set package main property to src/index.js

Hi !
First of all, thanks for the quick plugin.
The lib/index.js file is missing from the npm package, so it can't be imported by doing require('postcss-parcel-css'), require('postcss-parcel-css/src/index') must be used.
Here I'm setting the main property on package.jsonto ./src/index.js so that it can be imported directly (except if you want to build it with parcel).

ouch, thanks for the PR
I published version 0.3.0 with the fix


fix syntax in documentation comments

Documentation comments (those starting with /**) are interpreted as Markdown by modern IDEs.
This PR is escaping the method names with underscores for proper display support.

Sorry, it was for the upstream repo, not for Transmission


API Parity: cpu-shares

cpuShares is an integer in the docker API and float in ours

@pranavs18 please create an issue for this

Submitted the PR for this - https://github.com/rancherio/cattle/pull/81


Add Visual C++ mangling for cent/ucent.

The type __int128 is not yet supported by Visual C++ but the mangling
is defined. This can be checked with the undname.exe tool.

Auto-merge toggled on


docs: add docs link to org profile

📬 Changes

docs: add docs link to org profile

Will look like this:

🗒 Checklist

[x] Read the contribution guide and accept the
code of conduct
[ ] Readme and docs (updated or not needed)
[ ] Tests (added, updated or not needed)

ty!


MSVC fixes and warnings cleanup

Fix for another MSVC compiler bug and cleanup of warnings. With this PR the MSVC build works again, at least using the latest preview version of Visual Studio.
One more warning remains due to the use long instead of size_t in system_context (here), but I'm not sure if there's a reason for using long instead of size_t.

/ok to test

/ok to test


feat: dynamically render nav links based on content availibility

Summary
This PR closes #8 by conditionally rendering the Blog and Learnings links in the navigation menu based on content availability.
Changes Made

Updated the navigation component to check for the length of blog posts and learnings before rendering the corresponding links.

@NitanJana this would handle the visual part. But the blog and learning page would still generate no content, right? If yes, can we do something about it?
Even these routes should not generate in that case /blog and /learnings

I am still stuck on the

Even these routes should not generate in that case /blog and /learnings

part. I tried tweaking getStaticPaths for this to prevent generating the route at build time if no content is available.
Alternative, sending null response with 404 status code will show not found page but the route will still generate at build time.

@NitanJana you are right. There seems to be no way to not generate a static page from within the page file.
The user had to delete the entire blog or learnings folder so as not to generate the page. I think we can solve this with documentation in the README to tell the user the same. Let me create a new issue for this!
Thanks


How to evaluate custom pretrained LLMs using multiple GPUs and huggingface accelerate?

I am trying to evaluate the OPT model using the framework in the following way:
model = OPTForCausalLM.from_pretrained(model_name)
model = accelerator.prepare(model)

... # doing something with the model to prepare for evaluation

results = evaluator.simple_evaluate(
    model=model,
    no_cache=True,
    limit=limit,
    tasks=tasks,
    device=self.device,
)

However, I did not manage to run it on multiple GPUs, the code ends up running the evaluation only on one GPU. I cannot use the framework via ./lm_eval script, I need to prepare the model before running the evaluation. Could you tell me what I might be missing here?

Hi @JungleTryne ,
there are two things I see here:

Are you using the master branch or v0.3.0 ? I see you're passing no_cache=True , which is from those versions. If so, that was prior to supporting data-parallel evaluation.
Are you wanting to split the model across GPUs, or to run data-parallel evaluation? if the former, you can pass a device_map to the from_pretrained() call. If the latter, you'd need to launch your script on multiple processes in parallel using accelerate launch, and prepare your model then. However, there might be some incompatibilities that arise when passing in an already-initialized model while using accelerate launch, which I'd be happy to assist with (we've typically assumed people needing this will instead subclass HFLM for this--is there any reason you are unable to shift the custom model preparation you need into HFLM.__init__()?

Hi @haileyschoelkopf ,
indeed, I was using an old version, now I switched to the master branch, thank you for the advice!
I want to split the model across multiple GPUs because it doesn't fit in one. Before evaluating the model I want to initialize it, work with it, and only then launch the benchmark, as I showed in my initial question. But now with the new version of lm-eval, I cannot simply do this:
model = OPTForCausalLM.from_pretrained(model_name, ..., device_map="auto")
model = accelerator.prepare(model)

evaluator.simple_evaluate(
    model=model
    ...
)

because it gives me this error:
Traceback (most recent call last):
   ...
    _ = evaluator.simple_evaluate(
  File "/mnt/sdc/home/jungletryne/transformers/external/lm-evaluation-harness/lm_eval/utils.py", line 415, in _wrapper
    return fn(*args, **kwargs)
  File "/mnt/sdc/home/jungletryne/transformers/external/lm-evaluation-harness/lm_eval/evaluator.py", line 121, in simple_evaluate
    assert isinstance(model, lm_eval.api.model.LM)
AssertionError

How can I convert this model to lm_eval.api.model.LM, if I have an already pretrained one? And won't I lose the ability to perform inference on multiple GPUs? Because I checked the code of HFLM and I saw this
if not isinstance(pretrained, str):
    ...
    assert not parallelize, "`parallelize=True` is not compatible with passing pre-initialized model to `pretrained`"

regarding the assertionerror you can do this by first passing in
lm = HFLM(pretrained=model) and then passing that object to simple_evaluate!

if not isinstance(pretrained, str):
...
assert not parallelize, "parallelize=True is not compatible with passing pre-initialized model to pretrained"

regarding this part of HFLM: yes, we don’t allow one to pass parallelize=True in this case because when you send a pre-initialized model into HFLM, we won’t move that model onto a new device.
However, if you have already parallelized your model using device_map, and then pass that model into HFLM for initialization—this should be respected and allow for you to run across multiple GPUs.
Let me know if this makes sense or helps!

Yes, it helps! Thank you very much :)

Hi @haileyschoelkopf . I am trying to do data-parallel by passing an already initialized model. Can you help me with setting this up? How should I go about subclassing the HFLM?


feat: accommodate custom functionality

Access to certain celestia-node services, such as header.Store, is needed by custom data availability light clients. Ideally, developers of custom data availability light clients shouldn't have to fork this repo when they need to add additional services to a celestia-node.
One way to do this is to make the cli more portable, along with implementing some sort of Plugin interface so that custom celestia-nodes can easily be created.

https://github.com/celestiaorg/celestia-node/pull/414

should we close this?

should we close this?

We have groomed and decided to leave it open to post-mainnet phase


[Pager] pagerTabIndicatorOffset unresolved

Description
Cannot find pagerTabIndicatorOffset method
Steps to reproduce
compose_version = '1.2.0'
accompanist_version = '0.25.0'

hey. it wasn't moved or renamed - https://github.com/google/accompanist/blob/f619020174239f49e1ae7c2907a0a8f4f1eb986d/pager-indicators/src/main/java/com/google/accompanist/pager/PagerTab.kt#L34.
The dependency you need is described on the page of the module: https://github.com/google/accompanist/tree/main/pager-indicators


Isolation levels: Fix error and update order of isolation levels

Based on community feedback:

Fix note about supported isolation level for SQLite. We fixed one place during the review, but missed the second one
Re-arranged isolation levels based on strength

Thanks @SevInf for the PR

Sorry @ObamaTheLlama114  - I just saw that you already merged this!


add SD county vaccine scrapers

scrapes total_vaccine_initated and total_doses_administered for South Dakota counties from https://doh.sd.gov/COVID/Dashboard.aspx

This is the data that I was trying to collect in #199. The query posted there returns the data from that table for about 1/3 of the counties.


bower install angular-paging (fails)

bower angular#1.5+        ENORESTARGET Tag/branch 1.5+ does not exist

This fix in last commit. (#557f3bfa71fe95adc55318a33c160800f8e80a4c)

Thanks again guys - I'll tag this change into version 2.2.1 today - sorry for the delay!

Alrighty, v2.2.1 published with the angular 1.5 version fix - closing out this issue


chore(userspace/falco): watch all configs files.

What type of PR is this?
/kind cleanup
Any specific area of the project related to this PR?
/area engine

What this PR does / why we need it:
Followup to #3024: properly watch all configs files.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:

NONE

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: FedeDP
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [FedeDP]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

/milestone 0.38.0

/cc @Andreagit97 that first asked for this :) (thanks!)

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: Andreagit97, FedeDP
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [Andreagit97,FedeDP]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: Andreagit97, FedeDP, leogr
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [Andreagit97,FedeDP,leogr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Lagging Scroll on Surface Book Touchpad

VSCode Version: Code 1.6.1 (9e4e44c19e393803e2b05fe2323cf4ed7e36880e, 2016-10-13T16:21:53.542Z)
OS Version: Windows_NT ia32 10.0.14393
Extensions: donjayamanne.python-0.3.23, ms-vscode.cpptools-0.9.2

Steps to Reproduce:

Open any file
Using the touchpad of my surface book, the scrolling is lagging to the point of unusable

I have the same problem on a yoga 910 laptop. Add "--disable-gpu" seems to hep.

@zhengbli, please, try to use latest Insiders. As far as I know, this should be fixed.

It appears to be an upstream issue with Chromium (we recently updated to Electron 1.3.8 that comes with Chromium 52). Apparently Chromium 54 has fixed the issue already. Let's track in #13612


Automated cherry pick of #5214

Cherry pick of #5214 on release-1.41.
/cc  @enahum

The file .circleci/config.yml is in the blocklist for external contributors. Hence, these changes are not tested by the CI pipeline active until the build is re-triggered by a core committer or the PR is merged. Please be careful when reviewing it.
/cc @mattermost/core-security @mattermost/core-build-engineers


battery face

I'd like the fancy-battery face to use different colors than the default (I'm using the solarized color theme). The following worked for my old spaceline cofig:
 (use-package fancy-battery
    :init
    (fancy-battery-mode)
    :config
    (setq-default battery-update-interval 10)
    (set-face-attribute 'fancy-battery-charging nil
    :foreground "dark blue" :weight 'bold)
    (set-face-attribute 'fancy-battery-discharging nil
    :foreground "dark magenta" :weight 'bold)
    (set-face-attribute 'fancy-battery-critical nil
    :foreground "dark red" :weight 'bold))

But this doesn't seem to be working with spaceline-all-the-icons. Any ideas?

Hey! I didn't realise that fancy-battery exposed it's own faces, makes complete sense 🙂
By default, the just inherit from the faces I chose to use anyway! So I've refactored this to inherit from these faces instead. Once this gets built, this should hopefully fix it for you.
If you could try out the new version and report back, that would be great! Thanks

Great - that works. Thanks for the package and the quick response!


Release num-rational 0.2 to crates.io

Recently a number of great changes including the update to Serde 1.0, no_std support, and the implementation of Sum and Product have been completed. It would be great to have num-rational 0.2 released to crates.io so that these changes could be used without git dependencies (see https://github.com/iliekturtles/uom/issues/57).
What is involved in making this happen?

Published!

Awesome! Thanks so much for all the effort on the num crates.


Convenient initialisers from ByteBuffer

Added simple initialisers to various types that consume a ByteBuffer.
Motivation:
Common operations to read a ByteBuffer as some different type T were a little too verbose.
Modifications:
New initialisers for:

Data
String
[UInt8]

Result:
var buffer = ...
let string = String(from: &buffer)
let data = Data(from: &buffer)
let array = Array<UInt8>(from: &buffer)

Whoop, missed review here -- sorry fixed my email settings / filters a bit recently :-)
LGTM, really nice to see this one


just: 0.10.0 -> 0.10.1

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/casey/just/releases.
meta.description for just is: "A handy way to save and run project-specific commands"
meta.homepage for just is: "https://github.com/casey/just"
meta.changelog for just is: "https://github.com/casey/just/blob/0.10.1/CHANGELOG.md"
Updates performed

Rust version update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS

The tests defined in passthru.tests, if any, passed

/nix/store/35x66jv2jsaf3bzrx06jffrgk1l10x4p-just-0.10.1/bin/just passed the binary check.

1 of 1 passed binary check by having a zero exit code.

1 of 1 passed binary check by having the new version present in output.

found 0.10.1 with grep in /nix/store/35x66jv2jsaf3bzrx06jffrgk1l10x4p-just-0.10.1

found 0.10.1 in filename of file in /nix/store/35x66jv2jsaf3bzrx06jffrgk1l10x4p-just-0.10.1

directory tree listing: https://gist.github.com/5ccafd92385d1b3cd4b5904c4ebf441b

du listing: https://gist.github.com/7b66f32b169e4df3c499c047e3ed6be2

Rebuild report (if merged into master) (click to expand)

4 total rebuild path(s)

1 package rebuild(s)

1 x86_64-linux rebuild(s)
1 i686-linux rebuild(s)
1 x86_64-darwin rebuild(s)
1 aarch64-linux rebuild(s)

First fifty rebuilds by attrpath
just

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/35x66jv2jsaf3bzrx06jffrgk1l10x4p-just-0.10.1 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A just https://github.com/r-ryantm/nixpkgs/archive/169acb3808740476bdbb614c38f540aec616213f.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/35x66jv2jsaf3bzrx06jffrgk1l10x4p-just-0.10.1
ls -la /nix/store/35x66jv2jsaf3bzrx06jffrgk1l10x4p-just-0.10.1/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

just

Maintainer pings
cc @xrelkd @06kellyjac for testing.

works on my machine.


blas: fix build on darwin

Motivation for this change
Fix build on Darwin
See https://hydra.nixos.org/job/nixpkgs/trunk/blas.x86_64-darwin
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ ] NixOS
[x] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

cc @matthewbauer

Thanks!


Prevent broken outbox processor due to db connection issues

This was reported via https://github.com/tomorrow-one/transactional-outbox/discussions/135
The issue could be reproduced with a test, simulating db connection issues. The problem was, that the exception thrown by lockService.runWithLock wasn't caught so that the schedule got broken, i.e. processing wasn't scheduled again. In consequence, after such an error, the outbox was no longer processed.

@hnrkdmsk @ChulioZet just wondering: is a new release sufficient (it's already spring 6 here), or do you need a backport to a spring 5 compatible version? What are your going to do, and where/how could I support further?

Hi @magro, thanks for asking -- a backport to a Spring 5 compatible version would indeed be necessary as we haven't yet brought the Spring 6 update live.

@ChulioZet This took a while, now version 1.1.7 is released with the backported fix.


Update log generation to not reference nil variable

Q
A

Bug fix?
yes

New feature?
no

API breaks?
no

Deprecations?
no

Related tickets
-

License
Apache 2.0

What's in this PR?

Fix to nil pointer exception on logs.
Why?

To prevent the operator from crashing.
Checklist

[x] Implementation tested
[x] Error handling code meets the guideline
[x] Logging code meets the guideline
[x] User guide and development docs updated (if needed)
[x] Append changelog with changes

I just noticed this today and was working on a PR! Thanks for correcting :)


[1.19.2] Crashing server

Hi
I can't really give reproduction steps here but I noticed in my servers crash reports that advanced reborn machine caused a crash. This is in my modpack, another quality modpack 2, would like to see if we can possibly get this patched up to eliminate any future crashes for players, if possible.
https://mclo.gs/EK82EG5

https://www.curseforge.com/minecraft/mc-mods/advancedreborn/files/4390040
1.1.3 was for 1.19/1.19.1.
This is my mistake, released 1.1.6 for 1.19.2.

Thanks for your reporting!


Update changelog and version

Codecov Report

Merging #74 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master      #74   +/-   ##
=======================================
  Coverage   87.83%   87.83%
=======================================
  Files           5        5
  Lines         189      189
=======================================
  Hits          166      166
  Misses         23       23

Impacted Files
Coverage Δ

server.py
65.07% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 701da25...9de8fed. Read the comment docs.


Error message "Disconnected from server" and unable to click reload after opening a link

After clicking on a source link in the policy recommendation section and going back to the Atlas page, the page shows error message. The reload button and the rest of the page are unclickable. Occurs at random, easier to open links on a new page.

Thank you, I have redirected those links to open in a new tab :)


Error 400113 (What does this mean, and how do I fix it)?

The below code is throwing the following error: Reddit_ChatBot_Python._utils.exceptions.APIException: {"message":"Platform API Error","code":400113,"error":true}
@chatbot.event.on_ready
def report_channels(_):
    channels = chatbot.get_channels()
    for channel in channels:
        # Messages come in reverse chronological order (oldest last)
        messages = chatbot.get_older_messages(channel_url=channel.channel_url,
                                              prev_limit=1000)

What does this error mean? How do I fix it?

The limit seems to be the issue. When I change the limit from 1000 to 100, the error goes away.

Just like in most other places in the reddit's api (comments, posts), elements that are returned are limited within 100 elements. if you want to get more than 100 messages you will need to make multiple requests. you can have a look at the example in the readme.


Change font size (Switches, Checkboxes and Radios) in Style Guide

More information when adjusted in Figma.

double, closed.


Stream.pipe event 'end' triggers only once

I have a server and a client set up with nodejs. The server is sending a file to the client with socket.io-stream. When the file is transfered I want to start working with it on the client side. For that I am listening to the 'end' event of the stream. My code works but only once. On the first file I send the event is triggered, but not on the next ones. After the first file, the next ones are corrupted and are 0 Bytes, I guess that's why the event is never triggered again.
server.js
 socketObj.emit('order', orderData);

 ss(socketObj).on('file', function(stream) {
            fs.createReadStream('./uploads/'+ orderData.file.name +'').pipe(stream);
 });

client.js
socket.on('order', function(data) {

    var stream = ss.createStream();

    ss(socket).emit('file', stream);

    stream.pipe(fs.createWriteStream(data.file.name));

    stream.on('end', function(){
        doSomeStuff(data); //This function is called only once
    });

});

I've tried using 'end' and 'finish' events, setting autoClose as true and false, using stream.close() and stream.end(), but nothing works. For me is like something is not resetting properly.

I am in the same issue. How did you reset your connection properly?

I couldn't solve it. Instead of using websockets for the stream, I just sent a string message via websocket to the client saying that the file was ready to download.
After that the client makes a get request and downloads the file via https.


Linear Potential with Airy function

This linear potential V=a|x|, may be interesting. This is similar to the Harmonic potential V=bx^2.
In hadron physics, the confinement is usually described by a linear potential.

https://bingweb.binghamton.edu/~suzuki/QuantumMechanicsFiles/13-6 Airy function for triangular potential.pdf
this is one reference.

SpecialFunctions.jl is supporting $\mathrm{Ai}(x)$ function.
https://specialfunctions.juliamath.org/stable/functions_list/#SpecialFunctions.airyai


oci: Add a EnvVar slice conversion API

This converts an OCI Process.Env slice into a vc.EnvVar one.
This is needed by https://github.com/clearcontainers/runtime/pull/53
Signed-off-by: Samuel Ortiz<EMAIL_ADDRESS>

Coverage decreased (-0.2%) to 66.783% when pulling 7a45fc75a7e1da5bb5434c0b8cc2221dfae58267 on sameo/topic/oci into 9bf70660fd26c992a4a0e210ac5d8fb2b367a9d6 on master.

Coverage decreased (-0.2%) to 66.783% when pulling 7a45fc75a7e1da5bb5434c0b8cc2221dfae58267 on sameo/topic/oci into 9bf70660fd26c992a4a0e210ac5d8fb2b367a9d6 on master.

Coverage increased (+0.2%) to 67.037% when pulling 794e77051643b316d7eb81ccc61eff1371a44000 on sameo/topic/oci into 35239bc44ce1797a68119278d5b268962cc818f5 on master.

Coverage increased (+0.3%) to 67.108% when pulling 07c61efaeda0a44c1027e97f938b486639f6f53e on sameo/topic/oci into 35239bc44ce1797a68119278d5b268962cc818f5 on master.

LGTM

lgtm


Fix #7768 - Update and organize versions

Describe your changes :

Fix #7768

Type of change :

[x] Bug fix
[x] Improvement
[x] New feature
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation

Frontend Preview (Screenshots) :
For frontend related change, please link screenshots of your changes preview! Optional for backend related changes.

Checklist:

[x] I have read the CONTRIBUTING document.
[ ] I have commented on my code, particularly in hard-to-understand areas.
[ ] I have added tests that prove my fix is effective or that my feature works.
[x] All new and existing tests passed.

Reviewers

revisiting some version functions. Also, I'll check on newer pydantic versions


Issue with launching tool

I am on the free tier of open ai,  I think has access to gpt 3.5 turbo but it just doesn't launch for me: more details on the error below

In the 'my-new-project' folder, do you have a 'main_prompt' file containing the instructions for what you want to build?
And I am not sure trial (free) tier will work, because it has limit of 3 requests per minute.

I am having the same error, and i have a main_prompt file inside my projects subdirectory

on the creation of the project folder, the main_prompt is not copied across to new project folder which contains the memory and workspace sub directories

Work around / suggestion
create project folers in root directory / copy main_prompt to project folder in root directory

I have a projects folder in the root, inside there is an example folder, that has the main prompt, i also tried copying the main_prompt to the projects folder (outside of the example, still got nothing)

I got this working by moving my project folder (with main prompt file) to the root directory of gpt-engineer
I had it working in from projects and know that is what documentation says but someone has changed something (might change back!)

really? for me I just got it working by moving the main_prompt to the projects projects/my-new-project directory, however now the problem is i have exceeded my API quota limit

If you wish to reopen the issue please do following the new issue template.


Made JWT input be string for make-user-data

[squashed version of #329]

In #321, I switched the '--jwt' input to make-user-data be  a filename instead of a string.  But other commands use JWTs as strings, so make-user-data should follow that convention.

👍


tint2 configuration issues

I've tried using both of the tint2 configurations in the config folder but neither of them give me anything similar to what is shown in the screenshots. Are those configs valid or am I doing something wrong?

The tint2 is just the system tray, the panel is not tint2 it's eww.

That makes perfect sense, thanks!


2020 style

Initial front end work for the 2020 style

Codecov Report

Merging #663 into master will increase coverage by 0.06%.
The diff coverage is 89.7%.

@@            Coverage Diff             @@
##           master     #663      +/-   ##
==========================================
+ Coverage   73.62%   73.69%   +0.06%
==========================================
  Files          72       72
  Lines        2673     2672       -1
==========================================
+ Hits         1968     1969       +1
+ Misses        705      703       -2

Impacted Files
Coverage Δ

src/users/urls.py
100% <ø> (ø)
:arrow_up:

src/pycontw2016/urls.py
85.71% <ø> (ø)
:arrow_up:

src/remotedb/triggers.py
52.08% <0%> (ø)
:arrow_up:

src/reviews/views.py
33.61% <100%> (ø)
:arrow_up:

src/events/renderers.py
89.18% <100%> (ø)
:arrow_up:

src/proposals/views/speakers.py
100% <100%> (ø)
:arrow_up:

src/sponsors/models.py
87.87% <100%> (ø)
:arrow_up:

src/users/admin.py
100% <100%> (ø)
:arrow_up:

src/core/context_processors.py
90% <100%> (ø)
:arrow_up:

src/proposals/forms/speakers.py
97.18% <100%> (ø)
:arrow_up:

... and 24 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fcf8e32...c8b45a8. Read the comment docs.


CORS issue with WDC basic tutorial

Hello All !
I downloaded WDC SDK today and was going through the basic tutorial for getting earthquakeUSGS data. while do so during Fetch Data phase, the API call fails with CORS error. This is happening for the existing app in "http://tableau.github.io/webdataconnector/Simulator/".
Can anyone let me know if i am doing anything wrong from my end?
Thanks,
Jude

Hi Jude,
I just came to the same conclusion.  Perhaps this is a recent change on the USGS server that restricts this.
If you go to the page at https://tableau.github.io/webdataconnector/docs/wdc_cors and follow the instructions in step 2 for your javascript code, then it should work.
I hope they update the tutorial instructions and related code.  This would have saved me a couple of days of messing around.

...and my link didn't work.
Let's try this again:
https://tableau.github.io/webdataconnector/docs/wdc_cors

Thank you for reporting this! Looks like this is caused by a recent change to the API we are hitting in that sample.   We will investigate and get the samples fixed up shortly.

Thanks Brendan and laurier !
I am very new to WDC and scripting and was wondering if it was an issue from my end.

Sorry Closed it by mistake!!!

Hey @judexavier, @laurier-l,
This should be fixed now, please verify it's working for you then close the issue if so.  Let me know if it's not working for you.
Thanks!

Thanks Brendan,
I am able to run the WDC examples now from my local simulator.


Update about-windows-filtering-platform.md

Remove redundant and confusing header, since this isn't a table. Also, make the component name bold.

@xiaoyinl : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@stevewhims : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Safe for you to delete your working branch now.


Rules for scoped packages with local definitions differs from @types definitions.

TypeScript Version:  3.4.0-dev.20190326

Search Terms:
scoped package local definition
Code
tsconfig.json
{
	"compilerOptions": {
		"moduleResolution": "node",
		"noEmit": true,
		"typeRoots": [ "./node_modules/@types", "./types" ]
	}
}

source/index.ts
import Foo from '@scope/scoped'
new Foo()

types/scope__scoped/index.d.ts
declare class Foo { }
export default Foo;

npm install typescript@next
npx tsc
--> Notice error:source/index.ts:1:17 - error TS2307: Cannot find module '@scope/scoped'.
1 import Foo from '@scope/scoped'
                  ~~~~~~~~~~~~~~~
Found 1 error.

move types/scope__scoped/index.d.ts to<EMAIL_ADDRESS>npx tsc
--> Notice no error.
move<EMAIL_ADDRESS>to<EMAIL_ADDRESS>--> Notice different error:error TS2688: Cannot find type definition file for '@scope'.
error TS2688: Cannot find type definition file for 'scope__scoped'.
Found 2 errors.

Expected behavior:
A module located in any directory referenced by typeRoots compiler option behaves the same, whether it is in node_modules/@types or some other type root.
Actual behavior:
When the module is in node_modules/@types it can be resolved via the magic rename of scope__scoped to @scope/scoped.  When the module is in any other typeRoot directory, it cannot be located.
Playground Link:
Related Issues:
Directly related to #15204 (but that is locked).
Related to #23999 as well.

I am aware that I can resolve this specific issue by wrapping my definition file in a declare module "@scope/scoped" { ... }.  This issue is more for tracking the fact that there is a discrepancy that is unexpected from a user's point of view.  I was writing this definition in preparation for uploading to DefinitelyTyped, and to get started I copied an existing scoped module from DefinitelyTyped into my project and ran into this problem (which took me quite a while to troubleshoot/isolate since I didn't expect node_modules/@types to be special/magic).

typeRoots does not impact the resolution of modules - it only changes which type definitions are automatically brought into the program (if types is unspecified), or provides additional places to look up type libraries specified from types or reference directives.
There is special logic when resolving modules that node_modules/@types is a fallback location if the normal logic doesn't work. There isn't currently a way to customize that fallback location or add additional places.
You might be able to make something with path mapping happen, but I haven't tried.

Would it be a reasonable feature request to have all typeRoots be eligible as a fallback for missing module resolution?
As a user, my expectation is that node_modules/@types is just a default location for type definitions and anything that works there would work in any typeRoot.  Is there something that would break if this expectation held?
I often learn how to create type definitions by looking at DefinitelyTyped, and when something that works there doesn't work in my local project I'm left in a situation where I need to find another source of example to work from.

In the meantime, is there any workaround that would allow me to define a scoped package locally other than via the declare module "..." {} mechanic?

We can always have more options, but typeRoots already means something and the thing it means is not something to do with module resolution. Making it conflate with other things would increase confusion and complexity.
Path mapping is generally the right way to specify a different file location for a non-relative module name.

Something that is tickling my brain about your explanation is that if the module is not scope (and thus I can name the folder exactly), the definition works when I copy it into any typeRoots folder.
I think ultimately that is why this feuls like a bug, because everything works fine right up until I scope the package, then it all breaks.
Why is it that module resolution works in typeRoots when the name is an exact match, but it doesn't work when the module is scoped (and thus has to go through the name transformation during lookup)?

Just ran into this issue, and yes it does feel like a bug.
The above declared workaround declare module '@scope/scoped' does not work for me for some reason.
Now I don't know what to do.... Will look into manual type mapping.

May be it's folly, but my problem was in package.json. Yarn doesn't add scoped(! only scoped) packages automatically in dependencies block...
In included package:
tsconfig.json:
{
  "compilerOptions": {
    ...
    "declaration": true
    ...
  }
}

package.json:
{
  ...
  "types": "dist/index.d.ts"
  ...
}

So this was my solution that worked:
tsconfig.json:
{
  "compilerOptions": {
    "baseUrl": "./",

    // add all extra @types declarations here (including non-scoped now)
    "paths": {
      "@abandonware/noble": <EMAIL_ADDRESS>      "json-diff"<EMAIL_ADDRESS>      ...
    },
    ...
}

I tried<EMAIL_ADDRESS>and<EMAIL_ADDRESS>without any extra custom tsconfig.json options, but that did not work<EMAIL_ADDRESS>worked without any extra config, but since adding custom compilerOptions I have to add that as well.
TS Version: 3.7.4

I also tried<EMAIL_ADDRESS>but not working.

This is so broken. I've spent the last hour trying to get this to work with a scoped package. Why can't we create one file with all the extra typedefs and module declarations and just specify that?

Did my solution in https://github.com/microsoft/TypeScript/issues/30599#issuecomment-590246047 work  @TrueWill?

@johanlunds No, but thank you for posting that and for following up.
I tried:

typings/scope__package/index.d.ts (with adjusted typeRoots)
"paths": { "@scope/package": ["typings/scope__package/index.d.ts"] }
/// <reference types="typings/scope__package/index.d.ts" />
Various permutations of relative paths (such as including ./ or not)

All without success. I finally gave up and just require'd the module.
To be clear, I was running into this with ts-node, so it may be specific to that tool. I'll delete my earlier comment.


Module augmentation seems to break when namespace and class have same name

Bug Report
🔎 Search Terms
Module Augmentation
Namespace
Class
Same name
Jupyterlab
🕗 Version & Regression Information

This is the behavior in every version I tried, and I reviewed the FAQ for entries

⏯ Playground Link
Doesn't work because it's about module augmentation.
💻 Code
// index.ts
    import {CodeMirrorEditor} from '@jupyterlab/codemirror';
    const newEditor = new CodeMirrorEditor({
      config: {
        myExtraOption: true,
      },
      host: {} as any,
      model: {} as any,
    });

The above fails because myExtraOption is an option not officially in @jupyterlab/codemirror.
However, when I add
// jupyterlab-codemirror.d.ts
import '@jupterlab/codemirror';

declare module '@jupyterlab/codemirror' {
  declare namespace CodeMirrorEditor {
    interface IConfig {
      myExtraOption: boolean;
    }
  }
}

it starts failing instead with
typescript: Cannot use namespace 'CodeMirrorEditor' as a value. [2708]

it seems that the declaration file somehow starts shadowing the class CodeMirrorEditor which is also in @jupyterlab/codemirror
🙁 Actual behavior
Declaration merging is hiding the class
🙂 Expected behavior
The namespace is extended while the class is still visible

@entropitor , I can't reproduce this issue. Could you clone this repo and see if you still get the issue? It's a react app that includes @ jupyterlab/codemirror (I took a guess at how your code is structured). The code matches your code above (see here for example).
I also created a simpler version that doesn't include codemirror or react. I have a module animals here, which exports a class and a namespace, both with the same name. The namespace includes an interface. I then augment the interface in that namespace here. Here I use the augmented interface, and it works fine.
My guess is you are somehow importing CodeMirrorEditor the namespace instead of CodeMirrorEditor the class.
As a side note, I didn't see a test covering this specific type of declaration merging. Should I add a mergedDeclarations8 similar to this test?

@egonSchiele Is it possible the repo is still private?

Yeah, it seems that on the latest version, it's not reproducible. Sorry for bothering you 😭


Stats: Implement MetricProducer in Stats.

Blocked by https://github.com/census-instrumentation/opencensus-java/pull/1347.

Codecov Report

Merging #1348 into master will decrease coverage by 1.03%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##             master    #1348      +/-   ##
============================================
- Coverage     83.15%   82.11%   -1.04%
+ Complexity     1369     1350      -19
============================================
  Files           219      222       +3
  Lines          6594     6608      +14
  Branches        601      601
============================================
- Hits           5483     5426      -57
- Misses          947     1021      +74
+ Partials        164      161       -3

Impacted Files
Coverage Δ
Complexity Δ

...in/java/io/opencensus/metrics/TimeSeriesGauge.java
100% <ø> (ø)
2 <0> (?)

...rc/main/java/io/opencensus/metrics/TimeSeries.java
100% <ø> (ø)
1 <0> (?)

...pi/src/main/java/io/opencensus/metrics/Metric.java
91.66% <ø> (ø)
4 <0> (?)

...a/io/opencensus/metrics/export/MetricProducer.java
0% <ø> (ø)
0 <0> (?)

...n/java/io/opencensus/metrics/MetricsComponent.java
100% <ø> (ø)
2 <0> (?)

api/src/main/java/io/opencensus/metrics/Value.java
100% <ø> (ø)
4 <0> (?)

...n/java/io/opencensus/metrics/MetricDescriptor.java
100% <ø> (ø)
2 <0> (?)

.../src/main/java/io/opencensus/metrics/LabelKey.java
100% <ø> (ø)
2 <0> (?)

...ain/java/io/opencensus/metrics/TimeSeriesList.java
100% <ø> (ø)
1 <0> (?)

...rc/main/java/io/opencensus/metrics/LabelValue.java
100% <ø> (ø)
2 <0> (?)

... and 23 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update efc4f90...3ea0c70. Read the comment docs.

Please resync.

Rebased, PTAL.

Let's not expose the MetricProducer publicly. I would propose the following approach:

In implcore we have a StatsMetricProducer that uses the ViewManager to get all views and all ViewData and produces from them Metrics.
Register the StatsMetricProducer to the global MetricProducerManager (during the initialization of the Stats in the implcore).
Then we can change the Stats exporters to use metrics.

This way for the moment we do not expose any API in stats. What do you think?

If the MetricProducer in Stats is intended to be only used by exporters/zpages (not in users' applications), I agree that it should be hidden from APIs.

In implcore we have a StatsMetricProducer that uses the ViewManager to get all views and all ViewData and produces from them Metrics.

This is already done in https://github.com/census-instrumentation/opencensus-java/pull/1338. Whenever there's a record event, it will be turned into a Point in a Metric (or several Metrics, if the Measure maps to multiple Metrics).

Register the StatsMetricProducer to the global MetricProducerManager (during the initialization of the Stats in the implcore).
Then we can change the Stats exporters to use metrics.

Make sense to me.


Memory maybe leak

Expected behavior
Memory should be decrease  after client received all message completely
Actual behavior
But Memory not be decrease until I closed client.
Steps to reproduce

unzip the attachment
run BankingServer class
run BankingClient class
look into os memory

Minimal yet complete reproducer code (or URL to code)
Netty version
4.0.45.Final
JVM version (e.g. java -version)
1.8
OS version (e.g. uname -a)
win10
Uploading nettyinaction.zip…

@zld406504302 Looks like the link to a zip archive you've attached is malformed. It would be much convenient to have a GitHub repository with code that reproduces the problem.

@zld406504302 please reopen with more details


Added licences to modules and fixed a couple of things

Sorry for the wait. I just got a new Pi 3 after my last one burnt out. I'll take a look at this shortly.

Ah, it's all right. By the way, I saw on your twitter account that you got a job at Ubisoft Montreal. That's awesome. :)

Sorry for the wait on this. Thanks for your patience and pull requests.


add resize_token_embeddings

This may not be the best modification, but the previous code couldn't run directly. The following code needs to be added for it to work, otherwise, the following error would occur:
`
Traceback (most recent call last):
File "/workspace/wubing/titan/scripts/leaderboard/lora/merge_loras_peft_example.py", line 13, in
model = PeftModel.from_pretrained(model, "smangrul/tinyllama_lora_norobots", adapter_name="norobots")
File "/workspace/wubing/anaconda3/envs/titan/lib/python3.10/site-packages/peft/peft_model.py", line 581, in from_pretrained
load_result = model.load_adapter(
File "/workspace/wubing/anaconda3/envs/titan/lib/python3.10/site-packages/peft/peft_model.py", line 1239, in load_adapter
load_result = set_peft_model_state_dict(
File "/workspace/wubing/anaconda3/envs/titan/lib/python3.10/site-packages/peft/utils/save_and_load.py", line 451, in set_peft_model_state_dict
load_result = model.load_state_dict(peft_model_state_dict, strict=False)
File "/workspace/wubing/anaconda3/envs/titan/lib/python3.10/site-packages/torch/nn/modules/module.py", line 2584, in load_state_dict
raise RuntimeError(
RuntimeError: Error(s) in loading state_dict for PeftModelForCausalLM:
size mismatch for base_model.model.model.embed_tokens.base_layer.weight: copying a param with shape torch.Size([32005, 2048]) from checkpoint, the shape in current model is torch.Size([32000, 2048]).
size mismatch for base_model.model.model.embed_tokens.lora_embedding_A.norobots: copying a param with shape torch.Size([8, 32005]) from checkpoint, the shape in current model is torch.Size([8, 32000]).
size mismatch for base_model.model.lm_head.base_layer.weight: copying a param with shape torch.Size([32005, 2048]) from checkpoint, the shape in current model is torch.Size([32000, 2048]).
size mismatch for base_model.model.lm_head.lora_B.norobots.weight: copying a param with shape torch.Size([32005, 8]) from checkpoint, the shape in current model is torch.Size([32000, 8]).
`

Thank you for this PR. I just want to let you know that we're currently on vacation and will review this next year.


Improve stack traces on collection create/open in the ingestor.

To avoid unnecessary "during the handling of exception A, exception B was raised" messages (since "collection doesn't exist yet" isn't really an error condition), this pulls the "create" step out of the exception handler for the "open" step, breaking the exception causation chain. (The other does-not-exist blocks should probably be changed similarly, but those would require more work than this minor fix.)

Codecov Report
Patch coverage: 80.00% and project coverage change: +27.63 :tada:

Comparison is base (e338562) 63.76% compared to head (df09b6c) 91.39%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1438       +/-   ##
===========================================
+ Coverage   63.76%   91.39%   +27.63%
===========================================
  Files         103       30       -73
  Lines        8188     2487     -5701
===========================================
- Hits         5221     2273     -2948
+ Misses       2967      214     -2753

Flag
Coverage Δ

python
91.39% <80.00%> (-0.04%)
:arrow_down:

r
?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

apis/python/src/tiledbsoma/io/ingest.py
85.97% <80.00%> (-0.18%)
:arrow_down:

... and 73 files with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Nette Tester with TeamCity output format not detected

I've installed it via

    "require-dev": {
        "nette/tester": "dev-feature/teamcity-output"
    },
    "repositories": [
        {
            "type": "vcs",
            "url": "https://github.com/jiripudil/tester"
        }
    ]

and composer update --prefer-dist
composer downloaded your forked version, but plugin still shows this error. Restart didn't help. I'm running PS v10.0.3 on Windows 10

I have the same problem. I also installed it via composer. W10 - PS v. 10.0.3.

I have the same problem. Version: 1.0-alpha2, W10 - PS v. 2016.1.2

Any progress? The same problem on Mac OS X 10.11.5, PhpStorm 2016.1.2, Nette Tester 1.0-alpha2.

I upgraded PhpStorm to 2016.2 and plugin started  to work. It is able to detect Nette Tester with TeamCity now.

Composer does funny things to vendor binaries on Windows, so you need to point the Tester executable to the actual PHP script (vendor/nette/tester/src/tester). I've updated the README with a notice for Windows users


Support Disqus？

This theme can support Disqus & DisqusJS by myself？

Yes, it can
https://github.com/hexojs/hexo-theme-landscape/blob/a129596458b3d6295fd47ee86197a5aefec811c8/layout/_partial/article.ejs#L44
It's not in the readme, but it's available. Just fill the variable disqus_shortname with your disques id, and it'll works