Create policy for disallow empty ingress host

Signed-off-by: Anita-ihuman<EMAIL_ADDRESS>

@Anita-ihuman - I updated the results in test.yaml and verified with the latest build, It works:
Here's my test.yaml, and I just realized for a deny rule, the result expects the actual result of the resource creation. So the first result is pass which means the resource is allowed to be created.
results:
  - policy: disallow-empty-ingress-host
    rule: disallow-empty-ingress-host
    resource: ingress-wildcard-host
    result: pass
  - policy: disallow-empty-ingress-host
    rule: disallow-empty-ingress-host
    resource: minimal-ingress
    result: fail

✗ ./cmd/cli/kubectl-kyverno/kyverno test ./test-cli

Executing disallow_empty_ingress_host...
applying 1 policy to 2 resources...
│───│─────────────────────────────│─────────────────────────────│───────────────────────│────────│
│ # │ POLICY                      │ RULE                        │ RESOURCE              │ RESULT │
│───│─────────────────────────────│─────────────────────────────│───────────────────────│────────│
│ 1 │ disallow-empty-ingress-host │ disallow-empty-ingress-host │ ingress-wildcard-host │ Pass   │
│ 2 │ disallow-empty-ingress-host │ disallow-empty-ingress-host │ minimal-ingress       │ Pass   │
│───│─────────────────────────────│─────────────────────────────│───────────────────────│────────│

And here's an example of how you can define the request.operation variable for a particular rule:
https://github.com/kyverno/policies/blob/c61d92dddcfbb016a2ed4cd2c439f3b437436e74/other/block_updates_deletes/values.yaml

@vyankyGH - can you help review this PR? We need to test with the latest CLI from kyverno/kyverno.

Works for me too.


Documentation does not match screen shot snippets, nor does it match current experience.

Under the section for "Explore the navigation pane", it first shows a tall, narrow snippet of a navigation pane. Below that, the last sentence of the paragraph states, "It can be collapsed by selecting this icon."
But that icon does NOT show up in the tall narrow screenshot above, and it does not show up on my page.
Mostly, I'm looking for how I can CUSTOMIZE my nav panel. I see that I can "Unpin" any one particular item, like, say, Monitoring Hub. But once I do, how might I get it back? I would like to get rid of half the icons on my nav panel but am nervous about doing so in fear that I won't be able to navigate to that particular item should I need it later.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 744f5d32-18ed-9018-3003-c5f9bcb3d1ff
Version Independent ID: e2123a9f-edef-5170-05c6-98d42bc9fd35
Content: Find content from Power BI service Home - Power BI
Content Source: powerbi-docs/consumer/end-user-home.md
Service: powerbi
Sub-service: pbi-explore
GitHub Login: @mihart
Microsoft Alias: mihart

Thanks for your comment, @ToddChitt. This issue has been assigned to the doc author for review.

Hi @ToddChitt ,
Thank you for your suggestions.  I've updated the article and submitted it for publish.
Take care,
the DOCS team


handleImageAdded() not trigger again after image is deleted in editor

Hi @davidroyer,
I am having problem that user to replace image but hit problems as describe above.

yes me too. How to handle delete image event ?


Ideanote Connector (update to v1.1.0)

When submitting a connector, please make sure that you follow the requirements below, otherwise your PR might be rejected. We want to make you have a well-built connector, a smooth certification experience, and your users are happy :)

[x] I attest that the connector works and I verified by deploying and testing all the operations.
[x] I attest that I have added detailed descriptions for all operations and parameters in the swagger file.
[x] I attest that I have added response schemas to my actions, unless the response schema is dynamic.
[x] I validated the swagger file, apiDefinition.swagger.json, by running paconn validate command.
[x] If this is a certified connector, I confirm that apiProperties.json has a valid brand color and doesn't use an invalid brand color, #007ee5 or #ffffff. If this is an independent publisher connector, I confirm that I am not submitting a connector icon.

Hi @runem! Our certification engineer, Srikanth, is currently on emergency leave. Please expect a delay with your PR. He will return January 31st, 2022. We apologize for any inconveniences.

@natalie-pienkowska Any updates on the progress of this PR? :-)

@runem Thank you very much for your contribution with us. Apologies for the delay in process. Our Primary Engineer will review your pull request soon.


2022.01a Iteration Plan

SAP teams don't plan to address any specific issue in our next iteration.
We plan to provide a SAP Note that enables ABAP file formats in release 2021 (SAP_BASIS 7.56) for ATC checks (CHKO), ATC check variants and ATC check categories.
The iteration lasts 2 weeks and ends on January 31, 2022.

Iteration Results
We are still working on the SAP Note to enables ABAP file formats in release 2021 (SAP_BASIS 7.56) for ATC checks (CHKO), ATC check variants (CHKV) and ATC check categories (CHKC).


Add unfriend button for delete contacts inside contact page on NextCloud

Contact delete is not functional.
It needs an endpoint on Reva side for delete contact user action.

@parhamin2010 unfriend is not showing up in nextcloud-dev.

@MahdiBaghbani fixed


Small improvement in ol.interaction.DragAndDrop

for (let i = 0, ii = formats.length; i < ii; ++i) {
  const format = formats[i];
  let input = result;
  if (this.readAsBuffer_ && format.getType() !== 'arraybuffer') {
    if (text === undefined) {
      text = new TextDecoder().decode(result);
    }
    input = text;
  }
  const features = this.tryReadFeatures_(format, input, {
    featureProjection: projection,
  });
  if (features && features.length > 0) {
    if (this.source_) {
      this.source_.clear();
      this.source_.addFeatures(features);
    }
    this.dispatchEvent(
      new DragAndDropEvent(
        DragAndDropEventType.ADD_FEATURES,
        file,
        features,
        projection,
      ),
    );
    break;
  }
}

When an event "addfeatures" is sent, I would like to get information about what format did work..   to pass format info in event (like from what format features are parsed)

Sounds reasonable. Would you be able to provide a pull request?


Link to component list is broken (Entity Behavior Introduction)

The link to the list of all components in the entity behavior introduction is broken.
The page you get forwarded to is missing.
This might be frutstrating for beginners who want to get started with bedrock addon development.
I assume this is the page the link is supposed to redirect to?
https://learn.microsoft.com/en-us/minecraft/creator/reference/content/entityreference/examples/componentlist

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 4a6ceb93-44e6-516d-1a1a-ca150749cf51
Version Independent ID: 26800567-5bb0-e626-c958-0705b1321e04
Content: Entity Behavior Introduction
Content Source: creator/Documents/EntityBehaviorIntroduction.md
Product: gaming
GitHub Login: @mammerla
Microsoft Alias: v-jillheaden

I've fixed this on our internal repo. It should be fixed on the live docs in our next push.


Fix migration of API configurations

plus an issue with authorization, which leads to 404 messages in some cases

Why do we need raw sql here?

because some fields are removed from models.py I assume

Did you try the official way to access models, i.e. Test= apps.get_model('dojo', 'Test')? This should take into account the version of the Test model present at the point where 0131 is run. I think running raw sql may be a risk of its own that it breaks in some unforeseen scenario's where people are using obscure database like oracle or sqlite or whatever.

That brings a different error message but still doesn't work. The fields are not there anymore in the model Test class, where would the information about the missing fields come from?
I can't see how to avoid the SQL statement. It is completely SQL standard, so I think it should be safe.

Django builds a complete model/tree/history of all migrations. The field would come from the migration files 0001-0131.

This is what I tried:
    sq_products = Sonarqube_Product.objects.filter(sonarqube_tool_config__isnull=False)
    for sq_product in sq_products:
        api_scan_configuration = Product_API_Scan_Configuration()
        api_scan_configuration.product = sq_product.product
        api_scan_configuration.tool_configuration = sq_product.sonarqube_tool_config
        api_scan_configuration.service_key_1 = sq_product.sonarqube_project_key
        api_scan_configuration.save()

        Test = apps.get_model('dojo', 'Test')
        tests = Test.objects.filter(sonarqube_config=sq_product)
        for test in tests:
            test.api_scan_configuration = api_scan_configuration
            test.sonarqube_config = None
            test.save()

        sq_product.delete()

This raised:
...
django-defectdojo_migration-initializer-1   |   File "/app/dojo/db_migrations/0131_migrate_sonarcube_cobalt.py", line 18, in migrate_sonarqube
django-defectdojo_migration-initializer-1   |     tests = Test.objects.filter(sonarqube_config=sq_product)
...
django-defectdojo_migration-initializer-1   | ValueError: Cannot query "MW SonarQube | mwplatobackend": Must be "Sonarqube_Product" instance.

Any ideas?

You should use get_model for all Model classes in the migration

Here's an example: https://github.com/valentijnscholten/django-DefectDojo/blob/495b5c810f9cfc748ca10e2b2699f7542d53b30f/dojo/db_migrations/0120_sonarqube_test_and_clean.py

Don't know why, but this version works. Thanks @valentijnscholten

Changed the base from master to a dedicated hotfix branch to avoid releasing things from dev that were introduced since 2.4.0


Reworded/fixed grammatical error

Relevant Issues
Closes #708
Description
Fixed the grammatical error in the commented part of exceptions.py
Did you:

[x] Join the Python Discord Community?
[x] Read all the comments in this template?
[x] Ensure there is an issue open, or link relevant discord discussions?
[x] Read the contributing guidelines?

@jb3 Please check

New version reads good to me. Nice change :)

@ChrisLovering Thanks a lot :)


update verb could create a patch release

In case a regular dependency can be easily updated, we could:

Update the changelog with an robot-like description :yum:
Trigger a version("patch")
Release the new version (and commit the updated files (changelog and package [-lock])

@zFernand0 Do we still want this for updating Imperative in Zowe CLI or plugin repos? Or does the npmUpdate script suffice for updating dependencies?

Yeah, the npmUpdate script should be fine.


GWorkspace: remap time fields in parser

Proposed Changes

Map "TimeGenerated" field to "TimeIndexed" in the parser
Map original "id_time" to "TimeGenerated" in the parser

@averbn - Can you please resolve the conflicts? If the conflicts are resolved, this can be merged, changes looks good, thanks.


Add terra 0.23.2 QPY updates

Summary
Credit to https://github.com/Qiskit/qiskit-terra/pull/9525 @jakelishman
Details and comments
Fixes #

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

20 of 24 (83.33%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.007%) to 66.748%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

qiskit_ibm_runtime/qpy/binary_io/circuits.py
20
24
83.33%

Totals

Change from base Build<PHONE_NUMBER>:
0.007%

Covered Lines:
3294

Relevant Lines:
4935

💛  - Coveralls


Extend EthereumFlow to support tx chunking

Problem
There is case where an EthereumTx is over 6kb and we submit it for a consensus, a TRANSACTION_OVERSIZE error is returned because of exceeding the mentioned limit
Solution
Add transaction chunking supportability for EthereumFlow and expect it to behave like ContractCreateFlow, FileAppendTransaction and TopicMessageSubmitTransaction as the functionality is already present for these
Alternatives
No response

https://github.com/hashgraph/hedera-sdk-js/releases/tag/v2.20.0


usbhs: implement USBHS USB device driver

Implement the Embassy USB driver for the USBHS peripheral. The
implementation largely mirrors the OTG_FS driver and has similar
limitation such as non-configurable endpoint buffer sizes, in/out on the
same endpoint index, lack of iso transfer, and untested bulk transfer.
This change requires the latest fixes in ch32-metapac due to incorrect
striding of the endpoint control registers.
Tested on CH32V305 with the following applications:

USB HID device, for testing non-control endpoints interrupt transfer.
USB DFU, for testing the control endpoint.

Co-authored-by: Harry Brooke<EMAIL_ADDRESS>Co-authored-by: Codetector<EMAIL_ADDRESS>Co-authored-by: Dummyc0m<EMAIL_ADDRESS>

@ExplodingWaffle I didn't include your usb serial example because I was lazy and didn't want to polish it up. Feel free to add it as a follow-up.


[ptlaunch] writeJSON truncating patterns causing load failures

Apologies, I've double posted the issue - the correct issue here #3346 if someone could delete this!

Closed as duplicate


In code mode, it is adding  tag, removing  and

Device: MacOS Big Sur
Browser:  Chrome Versão 105.0.5195.102
Before:

Compile:

After:

You should use iframe mode and https://xdsoft.net/jodit/docs/classes/config.Config.html#editHTMLDocumentMode

@xdan  This solves the problem, thanks.


unexpected rendered more than one code block

Greetings,
I'm trying to figure out this plugin. when I set more than one theme, the plugin will render two code blocks like the following:

here is my code
import type { Root } from 'mdast'
import { highlightersFromSettings, remarkVisitor } from 'remark-shiki-twoslash'
import type { Plugin } from 'unified'
import { visit } from 'unist-util-visit'

export const remarkShikiTwoSlash: Plugin<[], Root> = () => async (ast: any) => {
  const settings = {
    themes: ['github-light', 'github-dark']
  }
  const highlighters = await highlightersFromSettings(settings)

  visit(ast, 'code', remarkVisitor(highlighters, settings))
}

Any help will be appreciated!
Jellli

my mistake, solution is here


fix: Improve code structure

Summary by CodeRabbit

New Features

Introduced a new command module to enhance command processing capabilities.

Bug Fixes

Standardized naming conventions for versioning and build information.

Documentation

Simplified build command for easier access and improved usability.
Updated build configuration to include new command library dependencies.

Refactor

Improved organization of include paths for better modularity and clarity.
Enhanced readability of method definitions in the command module.

文一 后面跟进


"valid characters to begin a JSON number" should include decimal point "." (0x002e)

If only to ensure that HOCON can parse Javascript natively defined objects, e.g.:
JSON.stringify(
    {number: .75, number2: .1E2}
) ===
   '{"number":0.75,"number2":10}'

json proper doesn't allow this of course - http://www.json.org/
If it's an error now, it probably won't be backward incompatible to allow it. If it has a different interpretation now then it could be an incompatible change.
We shouldn't accept it in json syntax mode.

I believe the phrase I saw recently in rapidjson was "relaxed syntax."  Anyway, I just thought I'd point it out, because one day I got really bored and decided to see exactly how badly one could obfuscate a number in JavaScript, and HOCON is so very very close to being compatible with JavaScripts very relaxed syntax.
And yeah, it's not valid JSON *duh* although I have stopped referring to json.org since I have discovered there are actually evolving JSON RFCs.  That and the json.org specs really leave a bit of ambiguity.


What makes it faster than the native runtime fetch api?

I dont get it how you were able to create something that is faster than the native runtime api.

What makes it faster than the native runtime fetch api?

The main source: Keep-alive by default.
And rock-req is light-enough to be almost as fast as the native http.request of NodeJS if an http agent is used with HTTP keep-alive.
Since Node19, NodeJS has decided to define a default keep-alive: https://github.com/nodejs/node/issues/37184
But many NodeJS projects still use Node 16 and 18.


browse-repository@1 useless with forks

The browse-repository@1 is broken when you're trying to navigate to a forked repo. It just shows the name of the repo twice, with no indication of which repo is the origin and which the upstream.

By comparison, RepoZ used to show the links:

As a temporary fix, I created a manual menu that shows the info more clear, but I think this should be default behaviour (ideally with an option to show/hide the origin and upstream bits)
Also a repository.short_remotes variable that only shows the author\repo-name would be ideal as I don't really need to know the full link.
- type: separator@1

- type: just-text@1
  name: 'Warning: No GitHub remotes to browse to'
  active: array.size(repository.remotes) == 0

# single remote, create url menu item
- type: url@1
  name: '🔗 GitHub: {{ get_remote_name() }}'
  url: '{{ repository.remotes[0].url }}'
  active: array.size(repository.remotes) == 1

# Multiple remotes, create folder with multiple menu items
- type: folder@1
  name: 🔗 GitHub remote repositories
  active: array.size(repository.remotes) > 1
  actions:
  - type: foreach@1
    enumerable: repository.remotes
    variable: remote
    actions:
    - type: url@1
      name: '[{{ remote.key}}] {{ shorten_github_link(remote.url) }}'
      url: '{{ remote.url }}'

- type: separator@1

and the following functions:
    func shorten_github_link(github_url)
      ret github_url | string.replace "https://github.com/" "" | string.replace ".git" "" | string.strip
    end

    func get_remote_name()
      if is_null(repository.remotes) || array.size(repository.remotes) == 0
        ret repository.name
      end
      ret shorten_github_link(repository.remotes[0].url)
    end

Nice work how you fixed it using the action menu.
Note that not all repositories are stored in Github. You can also store git repositories on GitLab, or Azure DevOps etc. where the url might be completely different.

Yeah, that should be easy to change to also modify those urls.
Is there a variable indicating what type of remote it is?


Calls to InitializeMasterFields without passing (Self)

The project fails to compile because of two calls to InitializeMasterFields without the parameter.

InitializeMasterFields does NOT take any parameters. What version of Delphi are you using? What parameters does it say it is expecting?

Ok David, thanks for the pointer. I had an implementation of InitializeMasterFields without a parameter, however, at some point this method was also an inherited member of the TncDBCnt, that, depending on the Delphi version, it either required or not a Self parameter. This has been fixed. Thank you.

I didn't read your previous email, but I tried the solution before raising
the issue. Everything works now under Delphi 10.2 and 10.3.
Thanks!
On Mon, Apr 20, 2020 at 2:28 AM DelphiBuilder<EMAIL_ADDRESS>wrote:

Ok David, thanks for the pointer. I had an implementation of
InitializeMasterFields without a parameter, however, at some point this
method was also an inherited member of the TncDBCnt, that, depending on the
Delphi version, it either required or not a Self parameter. This has been
fixed. Thank you.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/DelphiBuilder/NetCom7/issues/3#issuecomment-616338360,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AB5XPI3RUMED4O4P56UWCM3RNPTPVANCNFSM4MKDQZUQ
.


Would all the stuff in .cogs/ fit into a SQLite database?

Almost everything in .cogs/ is a table. The main exception is formats.json but I think that could fit into a table with two columns: format ID and the format JSON.
Would a cogs.db file be better than a .cogs/ directory? I'm finding myself using multiple Google Sheets for a given project, so I make various subdirectories each with their own COGS setup: foo/.cogs/ and bar/.cogs/. Maybe multiple .db files would be better? cogs foo.db add baz.tsv, cogs foo.db push
Changing over would be a pain, so we'd want a big win, and this doesn't seem big enough.

What would be the advantage of that? Do you have a lot of duplicate information or performance issue?
If not maybe we could just namespace the google sheets and cogs would handle that itself with directories?
For backward compatibility it could still read directly in the .cogs but newly added sheets could be in
.cogs/sheets//…


Image automatically resized when sent over to back end

Hi ,
Whenever I upload an image to my backend, I realise the image had been resized to a smaller size.
Is there anyway to upload to the backend at the original size?
RNFetchBlob.fetch(    'POST',     'http://<IP_ADDRESS>:80/scanning/detect/',     {    'Content-Type' : 'multipart/form-data',    'Content-Length' : '219153'    },     [     {  	name : 'image', 	filename : 'image.jpg', 	 	data: RNFetchBlob.wrap(uploadUri) 	}     ])

From my understanding, this library does not compress the data, you may need to check the backend implementation.

I'll close this, feel free to reopen if still necessary.

I am also facing the same issue. When I upload 5mb image to server, then it gets compressed. Can you please tell me how can upload the actual size of image.
Thanks in advance :-)


Login folder missing?

I’m stuck shortly after the installation process. I can see the login page but cannot go any further. I get a ‘Not Found’ error: The requested URL /app/login/validate was not found on this server. I played with it for a while but I’m stuck and I’m thinking that maybe it’s simply that the ‘login’ folder is gone and the validate script has been moved somewhere else or been renamed in the latest distribution? Is it the case or am I missing something? Thanks!
PS: I’ve installed the database (through phpMyAdmin) and edited database.php and config.php to match my environment (local server on a OS X 10.10, Apache 2.4.9, php 4.3.12, mysql 5.6.23).

Looks like a problem with the url thats coded in to the login view. If you add in index.php?/ before the rest of the link this will work as a hack.
Looks like a problem with removing the index.php? that needs mod_rewrite enabled (it should be as its in the .htcaccess file) and works on my system. Not sure where the issue is at the moment

Tried a bunch of things but still stuck so it's probably because of my limited knowledge on server tricks. Thanks anyway!

The problem is a missing .htaccess in the app directory.  In both the downloaded zip and the Git repo itself, the file doesn't exist.  If you create a new file named '.htaccess' (no quotes) and place the contents below, it will function as expected:
RewriteEngine On
RewriteBase /app/
RewriteCond %{REQUEST_FILENAME} !-f
RewriteCond %{REQUEST_FILENAME} !-d
RewriteRule ^(.*)$ index.php?/$1 [L]

Thanks stew for the update. I've made the suggested addition of the .htaccess file but still no luck. I always get the same 404: The requested URL /app/index.php was not found on this server.
I've checked the config.php and database.php files and everything seems ok. They do contain the relevant path and credentials.
I'm not sure what I can try next but thank you for your help in any case, much appreciated.

Thanks st0w for the fix. I've got it to work locally.


ASR performence when using character, subword and grapheme tokenization in Korean

❓ Questions & Help
Do you have any benchmark results regarding performance between character, subword and grapheme tokenization strategy?

It's an experiment I really want to try, but I haven't tried it yet. 😂

@sooftware
Thank you for your answer!


Transloco prefixes "en" scope when using external library

Is there an existing issue for this?

[X] I have searched the existing issues

Which Transloco package(s) are the source of the bug?
Transloco, Scoped Libs
Is this a regression?
No
Current behavior
Hi,
I'm using Transloco in both the main app and an external library. When I use the external library inside the main app, the main app prefixes the library scope core with en. Therefore the app can't find the correct translation.
Output debug console:

Here is the used app and library.
App: https://github.com/iprins/transloco-main
Library: https://github.com/iprins/transloco-lib
Building the library:
npm install
ng build my-lib
npm link

Building the main app:
npm install
npm install @ngneat/transloco-scoped-libs --save-dev
npm link my-workspace
npm run transloco:extract-scoped-libs
ng serve -o

Output: npm run transloco:extract-scoped-libs

Expected behavior
I expected the following behavior:
en.core.library

replaced with the correct translation:
Hello Library!

Please provide a link to a minimal reproduction of the bug
https://github.com/iprins/transloco-main
Transloco Config
module.exports = {
  rootTranslationsPath: 'src/assets/i18n/',
  langs: ['en', 'es'],
  keysManager: {},
  scopedLibs: ['my-workspace/dist/my-lib']
};

Please provide the environment you discovered this bug in
Transloco: 3.0.7
Angular: 12.1.2
Node: 16.13.0
Package Manager: 8.1.0 (npm)
OS: Windows 10

Browser
Firefox 94.0.1
Chrome  95.0.4638.69
Edge 95.0.1020.40

Additional context
I linked the library locally. I haven't tested it with a published library yet.
I would like to make a pull request for this bug
No

@iprins hey, I think I'm having the same issue, have you solved this?

No I haven't been able to solve this


I want to communicate with you

What is the way to communicate with you?

Simple write.whats going on?

Simple write.whats going on?

I want a simple Modify

feel free and enjoy but how can i help to modify

I want to make settings inside the app and to work the project it on iOSOpenDev ... thanks

the tweak himself was tiny&cute,if you handle and update the primary WA changes  that was perfekt.for other little changes and cosmetics create a branch"Beta" and collect importent nice to have BetterW

the tweak himself was tiny&cute,if you handle and update the primary WA changes that was perfekt.for other little changes and cosmetics create a branch"Beta" and collect importent nice to have BetterW

Thanks for help


[feat] Add support for LSF and lrun

This adds basic support for LSF and lrun. LSF is a scheduler and lrun is a launcher used on the Lawrence Livermore National Laboratory Sierra Systems. I have used this implementation to run tests on the Lassen cluster successfully.
I followed the sge scheduler implementation that worked off the pbs implementation as an example.
Closes #1055

Hello @rngoodner, Thank you for submitting the Pull Request!

In the file reframe/core/schedulers/lsf.py:

Line 34:1: W293 blank line contains whitespace

In the file reframe/core/schedulers/registry.py:

Line 43:1: E402 module level import not at top of file

In the file unittests/test_schedulers.py:

Line 29:80: E501 line too long (83 > 79 characters)
Line 134:1: E302 expected 2 blank lines, found 1

Do see the ReFrame Coding Style Guide

Can I test this patch?

Ok to test

Codecov Report

Merging #2133 (a109a5c) into master (bb779ce) will decrease coverage by 0.30%.
The diff coverage is 52.32%.

@@            Coverage Diff             @@
##           master    #2133      +/-   ##
==========================================
- Coverage   85.96%   85.65%   -0.31%
==========================================
  Files          53       54       +1
  Lines        9355     9441      +86
==========================================
+ Hits         8042     8087      +45
- Misses       1313     1354      +41

Impacted Files
Coverage Δ

reframe/core/backends.py
90.00% <ø> (ø)

reframe/core/schedulers/lsf.py
43.05% <43.05%> (ø)

reframe/core/launchers/mpi.py
98.94% <100.00%> (+0.18%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb779ce...a109a5c. Read the comment docs.

@AnibalMG could you test if this LSF backend works for your case?

@vkarak I have addressed all of your comments and also updated the docs. I have also re-tested on the LLNL Lassen cluster and everything is still working for my needs.


508: Duplicate Table Names

Issue: Multiple tables on the same page are named the same
Select Configurations is used for the aria label of the sub-tables. Suggest they be changed to  Configurations
For Select Configurations:

For Facilities: (Update aria-label to 'Select Facility')
For the Configurations under the Facility, add the aria-label 'Select Configuration under the Facility Name'

Requirements were completed in Ticket 2265

Just took a look, yes the data tables have unique names now


Pareto Chart

Can we do it? How about an example!
posted to mailing list.

Has this been implemented?


omnibus: integrations-py3: re-enable aerospike

What does this PR do?
This PR re-enables aerospike build for SUSE

Motivation
It builds fine, and is most likely an old leftover.
There doesn't seem to be any reason not to build it anymore

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

Reviewer's Checklist

[ ] If known, an appropriate milestone has been selected; otherwise the Triage milestone is set.
[ ] Use the major_change label if your change either has a major impact on the code base, is impacting multiple teams or is changing important well-established internals of the Agent. This label will be use during QA to make sure each team pay extra attention to the changed behavior. For any customer facing change use a releasenote.
[ ] A release note has been added or the changelog/no-changelog label has been applied.
[ ] Changed code has automated tests for its functionality.
[ ] Adequate QA/testing plan information is provided if the qa/skip-qa label is not applied.
[ ] At least one team/.. label has been applied, indicating the team(s) that should QA this change.
[ ] If applicable, docs team has been notified or an issue has been opened on the documentation repo.
[ ] If applicable, the need-change/operator and need-change/helm labels have been applied.
[ ] If applicable, the k8s/<min-version> label, indicating the lowest Kubernetes version compatible with this feature.
[ ] If applicable, the config template has been updated.

full pipeline: https://gitlab.ddbuild.io/DataDog/datadog-agent/-/pipelines/24538250


Add QoS configuration to RosNodeParams

I really like this pkg and the way it was created. Bravo to the authors!
The only thing missing is the ability to set QoS for topics.
By the way, I also added the ability to change the qos_profile for services.
I found other solutions with similar themes, which may be updated if this PR passes:

https://github.com/BehaviorTree/BehaviorTree.ROS2/issues/14
https://github.com/BehaviorTree/BehaviorTree.ROS2/pull/95

Hello @tony-p @facontidavide,
Can I ask one of u guys for review?

I'm not a maintainer so can't push this further. My first thought was why not define the qos in the node implementation as it will typically be constant for a particular message type, but on reflection I think adding to the params probably does make more sense.


Fix error message

Codecov Report
Base: 65.87% // Head: 65.94% // Increases project coverage by +0.07% :tada:

Coverage data is based on head (7bb4ee8) compared to base (8c96b41).
Patch has no changes to coverable lines.

Additional details and impacted files
@@             Coverage Diff              @@
##             master      #93      +/-   ##
============================================
+ Coverage     65.87%   65.94%   +0.07%
  Complexity      524      524
============================================
  Files            90       90
  Lines          1720     1718       -2
  Branches        199      199
============================================
  Hits           1133     1133
+ Misses          543      541       -2
  Partials         44       44

Impacted Files
Coverage Δ

...main/java/seedu/address/commons/core/Messages.java
0.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Don't emit an empty template head literal if there's a template span with a non-empty literal.

Fixes #1570

Great work @Arnavion! I'm going to sign off :+1:.
@mhegazy should make the final call on this.

:+1:

Thanks!
@DanielRosenwasser @mhegazy Any chance of getting this and #1577 in 1.4 too?

Unfortunately not, we're almost converged on 1.4, but I expect 1.5 to be released soon after anyway.

@DanielRosenwasser Seems this was force-pushed out of master?

This is bad. Let me try to resolve the issue.

@Arnavion should be fixed now.

@DanielRosenwasser Just noticed release-1.4 was also force-pushed back from ead4625 to ae0caed Every other branch is fine AFAICT

Thanks so much for catching that! I'll take care of that immediately.


Realm 0.97 throws if notification block is added on thread without runloop

RBQRealmNotificationManager, should be refactored to use a singleton worker thread that will receive the Realm notifications and pass along changes to RBQFetchedResultsController so that the dev never has to worry about passing changes to RBQRealmNotificationManager on a background queue/thread that doesn't have a runloop.

Just faced this problem. Really w8 for fix. =)

Yeah sorry about this probably will be a day or two before I can implement my solution.


Camera button does not work when the layout changes

In Chrome, I start with democratic view and there is Me and 2 guests. The 3 windows are arranged horizontally next to each other.

Then I change the browser size (because I want Notepad next to Chrome).  Now, there is Me and 1st Guest in the top row and 2nd Guest in the second row.

When I try to click on the camera button in Me window, nothing happens. And, there is no tool tip display either. Mute and Share buttons work fine.

@havfo @so010 me-ptt element is hiding it. What is your suggestion?

I think, that the old way, when me-ptt was displayed only on the ME screen was better. Now it disturbs, when watching other videos and having background noise.

I agree with @Astagor it was better on the only ME screen.
For a quick fix until it will be fixed more properly I hide the element..

Please check my quick fix..

Wondering if there is beta or test version of letsmeet.no where all the fixes are pushed immediately?
I don't have a test system and my pulls into prod are on a weekly basis.


tzdata: Use hard- instead of symbol-linking

Motivation for this change
Upstream software parses ${tzdata}/share/zoneinfo files.
Because of the symbolic posix link pointing to the local dir, the upstream software parses the contents of the zoneinfo directory multiple times because it follows symlinks and an error occurs because of this.
This PR changes the posix symlink to a hardlink to have a normal directory for posix like Fedora does.
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
Built on platform(s)

[X] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

I notice that 1f2228cdc10807ed3b7ee0888b5cc8b6800e87b3 changed from hard to soft links citing NAR issues. Is that relevant here?

Because of the symbolic posix link pointing to the local dir, the upstream software parses the contents of the zoneinfo directory multiple times because it follows symlinks and an error occurs because of this.

What software? What error?

What software? What error?

The standard library of the D programming language called Phobos.
I already patched it to not follow symlinks (see https://github.com/ThomasMader/nixpkgs/commit/6e15600b065dfae9c30d6a946ed84b2ba7a334a4#diff-9da5b94b5c73489302d04c387fbbf0c9R91) but wanted to make sure that tzdata has a standard layout before going upstream.
In Commit https://github.com/NixOS/nixpkgs/commit/1f2228cdc10807ed3b7ee0888b5cc8b6800e87b3 is mentioned though that other distributions are using symlinking too.
If that is true this PR can be closed.

Ubuntu is using symlinking, but without loops. This is better: https://github.com/NixOS/nixpkgs/pull/31560/commits/e75d458f38fc31837aa4141dca314f27db9ee41d

I've pushed my fix to staging. GitHub should close this issue when it reaches master.

@FRidh Thank you, I was considering doing this myself.

@orivej that was github; I merged staging into master.

@FRidh My bad, I did not expect staging to be merged to master so soon. But please, configure git with git config --global merge.ff false (and git config --global pull.rebase true), or at least use git merge --no-ff when merging staging into master, or it messes up the first-parent history and the history tree of the repository. (This effect was described here and here.) I have almost recovered the proper history in fbbda41e05d89325baaefef6fd0a420a1c365d7e.


Different sign between Final Parameter and log2-fold change in coda

Report
Hi @Zethson @johannesostner ,
Unfortunately, I've run again with the same problem after exploring the results when using different cell types as reference. Here is a reproducible example:
import pandas as pd
import numpy as np
from anndata import AnnData
import pertpy as pt

# Create adata
X = np.array([[1336., 1044.,  113.,  127.],
              [2422., 1290.,    0.,  364.],
              [1291.,  205.,  712.,  126.],
              [ 494.,  853.,  755.,  246.],
              [1738.,  733., 1250.,  191.],
              [1782.,  463., 1254.,  211.],
              [1195., 1100.,  282.,  214.],
              [ 459., 1042.,  653.,  158.],
              [2520.,  830.,  860.,  281.],
              [2133.,  387., 1788.,  389.],
              [1052.,  353.,  856.,   60.],
              [ 965.,  582.,  687.,  217.]])
obs = pd.DataFrame(
    index=['S' + str(i + 1) for i in range(12)]
)
obs['condition'] = (['Cond A'] * 8) + (['Cond B'] * 4)
obs['sample_id'] = obs.index
obs.index.name = 'scCODA_sample_id'
var = pd.DataFrame(
    index=['C1', 'C2', 'C3', 'C4']
)
var['n_cells'] = np.sum(X, axis=0)
adata = AnnData(X=X, obs=obs, var=var, dtype=float)

# Run model
sccoda_model = pt.tl.Sccoda()
sccoda_data = sccoda_model.prepare(
        adata,
        formula="condition",
        reference_cell_type='C2'
    )
sccoda_model.run_nuts(sccoda_data, rng_key=42)
sccoda_model.set_fdr(sccoda_data, est_fdr=0.25)

# Get results
sccoda_model.get_effect_df(sccoda_data).reset_index()

When using C2 as reference, C3 has a positive Final Parameter but a negative log2-fold change. What would be the interpretation here?
 Thanks for trying out scCODA and pertpy! This example (as opposed to the one in the scCODA repository earlier) immediately strikes me as a numerical/convergence error, since the expected sample only consists of cell type C4. This may happen in very rare cases due to the MCMC sampling algorithm not converging.
I'll have a look into this - could you just give me the MCMC acceptance rate of the sampling run? You'll find it at the top of the sccoda_model.summary_extended(sccoda_data) printout.
Thank you!

Hi @johannesostner
Thanks for taking a look, here's the printout (seems to be low):
┌───────────────────────────────────────┬─────────────────────────────────────────────────────────────────────────┐
│ Name                                  │ Value                                                                   │
├───────────────────────────────────────┼─────────────────────────────────────────────────────────────────────────┤
│ Data                                  │ Data: 12 samples, 4 cell types                                          │
│ Reference cell type                   │ C2                                                                      │
│ Formula                               │ condition                                                               │
│ Reference index                       │ 1                                                                       │
│ Spike-and-slab threshold              │ 0.681                                                                   │
│ Spike-and-slab threshold              │ 0.681                                                                   │
│ MCMC Sampling                         │ Sampled 10000 chain states (1000 burnin samples)                        │
│ Acceptance rate                       │ 32.5%                                                                   │
└───────────────────────────────────────┴─────────────────────────────────────────────────────────────────────────┘

┌─────────────────────────────────────────────────────────────────────────────────────────────────────────────────┐
│ Intercepts                                                                                │
├─────────────────────────────────────────────────────────────────────────────────────────────────────────────────┤
│            Final Parameter  HDI 3%  HDI 97%   SD   Expected Sample                                              │
│ Cell Type                                                                                │
│ C1             7.256         0.531  12.474  5.321     1945.313                                                  │
│ C2             6.789         0.509  12.715  5.354     1219.478                                                  │
│ C3             0.297        -0.250   0.730  0.229        1.848                                                  │
│ C4             1.354        -0.387   2.680  1.277        5.318                                                  │
└─────────────────────────────────────────────────────────────────────────────────────────────────────────────────┘

┌─────────────────────────────────────────────────────────────────────────────────────────────────────────────────┐
│ Effects                                                                                │
├─────────────────────────────────────────────────────────────────────────────────────────────────────────────────┤
│                              Final Parameter  Expected Sample  log2-fold change                                 │
│ Covariate         Cell Type                                                                                │
│ conditionT.Cond B C1              0.000             0.000          -103.608                                     │
│                   C2              0.000             0.000          -103.608                                     │
│                   C3             47.660             0.000           -34.849                                     │
│                   C4             78.206          3171.958             9.220                                     │
└─────────────────────────────────────────────────────────────────────────────────────────────────────────────────┘

┌─────────────────────────────────────────────────────────────────────────────────────────────────────────────────┐
│ Effects Extended                                                                                │
├─────────────────────────────────────────────────────────────────────────────────────────────────────────────────┤
│                              HDI 3%  HDI 97%   SD    Inclusion probability                                      │
│ Covariate         Cell Type                                                                                │
│ conditionT.Cond B C1         -0.289   1.173   0.299         0.256                                               │
│                   C2          0.000   0.000   0.000         0.000                                               │
│                   C3          0.166 108.585  45.483         0.938                                               │
│                   C4         -0.124 182.202  71.870         0.682                                               │
└─────────────────────────────────────────────────────────────────────────────────────────────────────────────────┘

Let me know if you need anything else

I tested out the provided example today. In rare cases (4 times in 100 runs with different rng_key), the MCMC sampler can be initialized badly and therefore does not converge. I've added some warning messages now if we suspect that this might have happened (very low or high acceptance probability), prompting users to retry with a different rng_key.
Unfortunately, I think that there is no better fix to this, since this problem is highly dependent on the data at hand.

I tested out the provided example today. In rare cases (4 times in 100 runs with different rng_key), the MCMC sampler can be initialized badly and therefore does not converge. I've added some warning messages now if we suspect that this might have happened (very low or high acceptance probability), prompting users to retry with a different rng_key.
Unfortunately, I think that there is no better fix to this, since this problem is highly dependent on the data at hand.

Hi @johannesostner ,
I have encountered this too, and as you said, I think this is probably due to the kind of data I'm working with. I have a lot of cells, and it seems that multiple cell types are giving me this phenomenon. Please may I ask a few questions to understand how to interpret / use my data?
My first question is this: Would it be reasonable for me to filter away all the rows with opposite signs in Final Parameter and log2FC? For example, if I'm only interested in cell types which are enriched in a particular condition, can I just look at Final Parameter > 0 and log2FC > 0, ignoring all log2FC <0? Would there be any implications on the interpretation of the results?
The next question is somewhat related. I'm trying different rng_keys (cell types) to see if it improves the problem, and using the relative abundance dispersion plot to prioritize the top few clusters by Total Dispersion. However, I don't fully understand how to interpret Total Dispersion vs Presence. Can I understand presence to mean that the cell type is present in all samples / conditions, and dispersion to mean how equally it is distributed in all conditions? What does a value of 0.1 for eg mean for Total Dispersion?
Thank you so much!
Best Regards,
Samuel

Hi @SamuelCWJ!
Do you actually see a low acceptance probability (<80%) in your sccoda_model.summary_extended(sccoda_data)? This would indicate a non-converged sampling run, and you should re-run scCODA with a different random seed. This was the main point in this issue.
Due to the compositional nature of scCODA, a different sign in the final parameter and the Log2FC can also occur in well-converged cases. The final parameter gives you the significant (non-zero) effects in the compositional space, where each change in abundance of one feature implies that all other features compensate for it by slightly shifting into the other direction (since their relative abundances have to sum up to 1 in the end).
The Log2FC shows the changes in the data in the non-compositional space. Therefore, these compensations have to be considered as well.
In extreme cases, where the compensation from another effect outweighs a second effect on the feature, the signs of the final parameter and the Log2FC could thus differ. For visualization, picture a dataset with 3 cell types. From condition 1 to condition 2, the abundance of cell type A increases by a huge factor and cell type B increases by a little. The final parameter for both cell types would be positive, while the Log2FC for cell type B would be negative (as both B and C have to compensate for the change in A).
For interpretation, you should look at the final parameter first. The nonzero parameters here are the ones that scCODA found to be significant changes. The Log2FC is only there to give you an idea about the magnitude of the changes, as the final parameter cannot be interpreted quantitatively.

For your second question:
The presence-dispersion plot can be used to find suitable reference cell types. A good reference should have a non-zero count in most samples (presence measures the percentage of samples, in which the ct was found) and a low dispersion (variance over mean - https://en.wikipedia.org/wiki/Index_of_dispersion).

I'm trying different rng_keys (cell types) to see if it improves the problem
I don't quite understand what you mean by this. The reference cell type is not the same as the rng key! Apart from numerical instabilities (which were originally discussed in this issue), different rng keys should give you almost the same result. On the other hand, a different reference will change your result, as you use a different cell type as the baseline.

Thank you so much @johannesostner for your replies!
Oh dear, I have evidently not understood the parameters like rng_key at all...so sorry, I still struggle with statistical parameters. This clarifies things! Thank you! I will run my data through a few more times..
Just to make sure I'm getting this right...

rng_key is the random seed for a run. (I don't quite get how it affects the run, but for now that's fine)
Between two cell types with good presence (eg. 0.98), the one with the lower dispersion (eg. 0.04 compared to 0.1) would be considered more suitable.

sccoda_model.summary_extended(sccoda_data)

Thank you so much once again @johannesostner !

No problem! Let me try to clarify:

scCODA uses Markov Chain Monte Carlo (MCMC) sampling to find the optimal solution. Essentially, this means that we explore the space of possible solutions by a very educated guessing procedure. To make sure that this is reproducible, we have to make sure that the guesses are the same every time, which we do by setting a seed for the random number generator. If we are very unlucky, the MCMC sampler will not find the optimal solution for a certain initialization and we need to retry with a different seed.
Your interpretation of the presence-dispersion selection is spot on. Of all cell types above a certain presence threshold, we select the one with the lowest dispersion.

Thank you so much once again!


Support Ubuntu 18.04.5

ROCm should support Ubuntu 18.04.5 since it is the next point release of this long-term support (LTS) version of this Linux distribution, following the currently-supported 18.04.4. The point release of Ubuntu 18.04.5 is set to be released on August 13th, so now is a good time to start testing with that version, before it gets released:
https://wiki.ubuntu.com/BionicBeaver/ReleaseSchedule

2020-08-03
I found my ubuntu-18.04.4 already using linux-5.4.0-42, And rocm seems run ok.
# hostnamectl
   Static hostname: x-MS-7816
         Icon name: computer-desktop
           Chassis: desktop
        Machine ID: 885ec2c7c1974347b0e372349a9b92f5
           Boot ID: b11888222673424eae46e414a2df8826
  Operating System: Ubuntu 18.04.4 LTS
            Kernel: Linux 5.4.0-42-generic
      Architecture: x86-64

$ python test.py
2020-08-03 09:56:12.686197: I tensorflow/stream_executor/platform/default/dso_loader.cc:44] Successfully opened dynamic library libhip_hcc.so
2020-08-03 09:56:13.377395: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1579] Found device 0 with properties:
pciBusID: 0000:02:00.0 name: Ellesmere [Radeon RX 470/480/570/570X/580/580X]     ROCm AMD GPU ISA: gfx803
coreClock: 1.34GHz coreCount: 36 deviceMemorySize: 8.00GiB deviceMemoryBandwidth: -1B/s
2020-08-03 09:56:13.604802: I tensorflow/stream_executor/platform/default/dso_loader.cc:44] Successfully opened dynamic library librocblas.so
2020-08-03 09:56:13.606448: I tensorflow/stream_executor/platform/default/dso_loader.cc:44] Successfully opened dynamic library libMIOpen.so
2020-08-03 09:56:13.901224: I tensorflow/stream_executor/platform/default/dso_loader.cc:44] Successfully opened dynamic library librocfft.so
2020-08-03 09:56:13.902955: I tensorflow/stream_executor/platform/default/dso_loader.cc:44] Successfully opened dynamic library librocrand.so
2020-08-03 09:56:13.903170: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1703] Adding visible gpu devices: 0
2020-08-03 09:56:13.903819: I tensorflow/core/platform/cpu_feature_guard.cc:143] Your CPU supports instructions that this TensorFlow binary was not compiled to use: SSE3 SSE4.1 SSE4.2 AVX AVX2 FMA
2020-08-03 09:56:13.928568: I tensorflow/core/platform/profile_utils/cpu_utils.cc:102] CPU Frequency:<PHONE_NUMBER> Hz
2020-08-03 09:56:13.929708: I tensorflow/compiler/xla/service/service.cc:168] XLA service 0x563409d498a0 initialized for platform Host (this does not guarantee that XLA will be used). Devices:
2020-08-03 09:56:13.929736: I tensorflow/compiler/xla/service/service.cc:176]   StreamExecutor device (0): Host, Default Version
2020-08-03 09:56:13.931722: I tensorflow/compiler/xla/service/service.cc:168] XLA service 0x56340e1a6d90 initialized for platform ROCM (this does not guarantee that XLA will be used). Devices:
2020-08-03 09:56:13.931755: I tensorflow/compiler/xla/service/service.cc:176]   StreamExecutor device (0): Ellesmere [Radeon RX 470/480/570/570X/580/580X], AMDGPU ISA version: gfx803
2020-08-03 09:56:13.931952: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1579] Found device 0 with properties:
pciBusID: 0000:02:00.0 name: Ellesmere [Radeon RX 470/480/570/570X/580/580X]     ROCm AMD GPU ISA: gfx803
coreClock: 1.34GHz coreCount: 36 deviceMemorySize: 8.00GiB deviceMemoryBandwidth: -1B/s
2020-08-03 09:56:13.932016: I tensorflow/stream_executor/platform/default/dso_loader.cc:44] Successfully opened dynamic library librocblas.so
2020-08-03 09:56:13.932040: I tensorflow/stream_executor/platform/default/dso_loader.cc:44] Successfully opened dynamic library libMIOpen.so
2020-08-03 09:56:13.932061: I tensorflow/stream_executor/platform/default/dso_loader.cc:44] Successfully opened dynamic library librocfft.so
2020-08-03 09:56:13.932082: I tensorflow/stream_executor/platform/default/dso_loader.cc:44] Successfully opened dynamic library librocrand.so
2020-08-03 09:56:13.932235: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1703] Adding visible gpu devices: 0
2020-08-03 09:56:13.932266: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1102] Device interconnect StreamExecutor with strength 1 edge matrix:
2020-08-03 09:56:13.932280: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1108]      0
2020-08-03 09:56:13.932290: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1121] 0:   N
2020-08-03 09:56:13.932513: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1247] Created TensorFlow device (/job:localhost/replica:0/task:0/device:GPU:0 with 7399 MB memory) -> physical GPU (device: 0, name: Ellesmere [Radeon RX 470/480/570/570X/580/580X], pci bus id: 0000:02:00.0)
Epoch 1/5
2020-08-03 09:56:15.443621: I tensorflow/stream_executor/platform/default/dso_loader.cc:44] Successfully opened dynamic library librocblas.so
1875/1875 [==============================] - 5s 2ms/step - loss: 0.2977 - accuracy: 0.9131
Epoch 2/5
1875/1875 [==============================] - 5s 2ms/step - loss: 0.1419 - accuracy: 0.9580
Epoch 3/5
1875/1875 [==============================] - 5s 2ms/step - loss: 0.1074 - accuracy: 0.9678
Epoch 4/5
1875/1875 [==============================] - 5s 3ms/step - loss: 0.0882 - accuracy: 0.9727
Epoch 5/5
1875/1875 [==============================] - 5s 3ms/step - loss: 0.0755 - accuracy: 0.9762
313/313 - 1s - loss: 0.0803 - accuracy: 0.9756

This should work on current ROCm versions. Thanks!


migration: "instances" entry already exists

Hi; unsure if this is expected behavior or something that slipped through the integration tests.
Im trying to migrate instances within a cluster, precisely akin to lxc mv "$instance" --target="$target_node".  Im getting:
...
  File "/home/nhensel/.local/lib/python3.10/site-packages/pylxd/models/instance.py", line 601, in migrate
    res = getattr(new_client, self._endpoint).create(
  File "/home/nhensel/.local/lib/python3.10/site-packages/pylxd/models/instance.py", line 323, in create
    response = client.api[cls._endpoint].post(json=config, target=target)
  File "/home/nhensel/.local/lib/python3.10/site-packages/pylxd/client.py", line 216, in post
    self._assert_response(response, allowed_status_codes=(200, 201, 202))
  File "/home/nhensel/.local/lib/python3.10/site-packages/pylxd/client.py", line 145, in _assert_response
    raise exceptions.LXDAPIException(response)
pylxd.exceptions.LXDAPIException: Failed creating instance record: Add instance info to the database: This "instances" entry already exists

I'm reminded of how the lxc client creates a temporary instance like 'mv-uuid...' during a migration; this behavior must have already been worked around over there.
I see how this could have been missed;  i don't see any sort of ad-hoc cluster construction ( like in lxd proper ) going on in the integration tests here.  I see migration/run_migration_integration_tests-18-04 but it doesnt appear to be consumed by anything.
So my questions are..  Is this expected behavior? Am I the consumer expected to work around this in my own code?
Or, if this is not expected behavior, what input would you have on an integration test and fix for this?  Im interested in taking a stab at it.. I figure migration/run_migration_integration_tests-18-04 needs taught to build a cluster of two, and migrate() needs taught to juggle instance names like lxc does.
Or perhaps im missing something?  Any better ideas?  Thanks.

oh, looks like lxd itself does know how to handle intra-cluster migrations correctly, pylxd just needs to know how to do it:
heres what lxc does:
https://github.com/lxc/lxd/blob/master/lxc/move.go#L258
heres what lxd knows:
https://github.com/lxc/lxd/blob/master/lxd/instance_post.go#L102
meanwhile pylxd is just doing a naive create():
https://github.com/lxc/pylxd/blob/master/pylxd/models/instance.py#L592


Explicitly pass character offset encoding to apply_workspace_edit

this fixes the MetalsOrganizeImport command in neovim nightly.
Here is the corresponding breaking change announcement: https://github.com/neovim/neovim/issues/14090#issuecomment-1012005684

Thanks for the pr @suliatis! There is actually one more needed one here: https://github.com/scalameta/nvim-metals/blob/d5864d9395152d4820bcb8a66f1235c5970e46a5/lua/metals/handlers.lua#L47 Can you also update that one?

Sure. Unfortunately I'm not sure about the impact of this other change, though should not break anything.


fix(ghost_text): ephemeral causes inline virt-text support check to fail

I'm on neovim nightly and inline ghost_text was not working for me. TL;DR: ephemeral option seems to somehow cause the check for inline virt-text support to fail, while it's actually supported.
I noticed you check for inline virt-text support here:
https://github.com/hrsh7th/nvim-cmp/blob/2743dd989e9b932e1b4813a4927d7b84272a14e2/lua/cmp/view/ghost_text_view.lua#L12-L22
So, I ran it to see whether it reports if I have inline support or not and I got an error back:
local ns = vim.api.nvim_create_namespace('thing')
local id = vim.api.nvim_buf_set_extmark(0, ns, 0, 0,{
  virt_text = { { ' ', 'Comment' } },
  virt_text_pos = 'inline',
  hl_mode = 'combine',
  ephemeral = true
})
vim.api.nvim_buf_del_extmark(0, ns, id)

E5108: Error executing lua [string ":lua"]:1: not yet implemented
stack traceback:
        [C]: in function 'nvim_buf_set_extmark'
        [string ":lua"]:1: in main chunk

I tracked it down to this snippet from neovim's source code:
  if (ephemeral && decor_state.win && decor_state.win->w_buffer == buf) {
    decor_add_ephemeral((int)line, (int)col, line2, col2, &decor, (uint64_t)ns_id, id);
  } else {
    if (ephemeral) {
      api_set_error(err, kErrorTypeException, "not yet implemented");
      goto error;
    }

    extmark_set(buf, (uint32_t)ns_id, &id, (int)line, (colnr_T)col, line2, col2,
                has_decor ? &decor : NULL, right_gravity, end_right_gravity,
                kExtmarkNoUndo, err);
    if (ERROR_SET(err)) {
      goto error;
    }
  }

Which suggested it had something to do with the ephemeral option, so I set it to false and that fixed it. I am not really sure why ephemeral is needed during the check if you delete the virt-text afterwards anyway. Feel free to correct me.

lgtm!

@PlankCipher @hrsh7th this is actually breaking ghost_text functionality on nightly for me, using 969c5affa55111f8af95a0696316a0775c2af2c7 on master  correctly shows ghost text.  I'm not sure if there has been some changes in neovim, but I'm using latest commit on it.

Can you create new issue?

It worked well for sometime after I opened this PR, but a commit on neovim's side broke it. I opened an issue about it.


support human ttl values like 10m

instead of only supporting integers like 600 it would be nice to also support human friendly values alike 10m using the same semantics as Golang time.ParseDuration.

/assign


Expose new tracing port in our docker images

          Will need to remember to expose this new port in our docker images

Originally posted by @cmwaters in https://github.com/celestiaorg/celestia-core/pull/1279#discussion_r1551279432

This has been closed by https://github.com/celestiaorg/celestia-app/pull/3334


Allow to configure settings per file type

VSCode Version: 1.5.1
OS Version: OS-X 10.11.6

Currently, the configuration switches that control indentation (editor.tabSize, editor.insertSpaces) can be configured globally or per-workspace.  But it's not unusual to work on different types of files within the same workspace that need different indentation styles.  For example, Go source files always use tabSize=8, insertSpaces=false (it's a language standard), but the same workspaces very often contain other types of files (e.g. Markdown, HTML, JavaScript, etc.) where those are not the desired settings.  It is irritating to have to set the indentation style manually whenever creating a new file.  Instead, the indentation settings should be language-specific, rather like snippets.

This is a similar issue to #2765 where the response was for the Go extension to explicitly set the indent settings. I have to do the same for Dart but I think it's a bit naff and would be a good feature for Code to support natively.

Well, there's two problems with that.  First, I raised that request with the Go extension author. @lukehoban , (see here), and he indicated that he didn't think it was possible — or advisable — for an extension to override core customization settings in this way.  So if the vscode maintainers think that's the right answer, it would be nice if they could connect with him and make sure he knows that and knows how.
More importantly, that might be a reasonable answer for Go where the language dictates the indentation style, but it's less desirable for other, more flexible languages.  Suppose that I want to have my Python sources with four-space indent but by YAML sources with two-space indent.  Does the author of every language extension need to provide ways to override the core settings for their language?  Wouldn't it make more sense to centralize that — especially since the core already has a way to do language-specific things (e.g. snippets)?

Like I said, I completely agree. I think both users and extension authors should be able to set it (the current mechanism is absolutely a hack)!

This is also essential when trying to edit Makefiles since they MUST use tabs, regardless of the user's preference.

Another concrete example: I like the files.trimTrailingWhitespace option for most source files, but for some file types (e.g. patch files) stripping out whitespace introduces errors.

I am using .editorconfig for this and it works great. Also compatible across different editors and IDEs.
Extension: https://github.com/editorconfig/editorconfig-vscode
Spec: http://editorconfig.org/

I'm also running into this editing Javascript (2-space tabs), HTML (4-space tabs), and README.md (word-wrap on)…  Sadly, editorconfig doesn't support wrapping yet, although it looks like it does most of the other stuff I want.

It also could be helpful with disabling IntelliSense for the plain text files, like .txt and .md, it was mentioned here:
https://github.com/Microsoft/vscode/issues/10819
Or disable similar matches to the selection for the same files.
Plain text files aren't really semantically the same as source code files, there has to be a way to override settings specifically for them.

This would be useful in order to take advantage of the vertical rulers set to
{
    "editor.rulers": [72, 79]
}

which applies to anyone who are working with Python files and wish to follow PEP8 guidelines.

And another example: disable quickSuggestions for specific file types.

I am using https://github.com/tzvetkoff/sublime_stupid_indent in sublime, which can force html,js ,css, scss , json  in size 2, others in 4 by config,  maybe vscode can take a similar way like that.
PS: though it can't not recognise current file is plain javascript or es6(babel), I hope vscode can do this too.

I find vscode have a similar extention:
https://marketplace.visualstudio.com/items?itemName=EditorConfig.EditorConfig
But it isn't global settings, need generate editorconfig for each project.

Will be implemented by #1587.


allow reading X-TypeScript-Types reponse header in browser

Custom headers in browser cross origin requests are omitted unless explicitly whitelisted by the response header 'Access-Control-Expose-Headers'
after this change browser fetch response.headers should contain the X-TypeScript-Types response header and its value

lgtm，thanks @asafamr


feat(core): 12130 & 12146 - Folding panels with new header design

we still use icons for mobile viewports

><EMAIL_ADDRESS>lint:css
> stylelint ./src/**/*.css

src/features/events_list/components/EventsListPanel/EventsListPanel.module.css
 74:1  ✖  Unexpected duplicate selector ".panelBody", first used at line 1  no-duplicate-selectors

is that expected?

position: absolute for controls it always bad idea

Sorry, i edited comment above ⬆  while wanted to reply to it. I'll fix analytics height

something bad with legend paddings


Updating HW information

What does this PR do?

Fixes #104  (issue)
We had some dated information in the table
Who can review?
Feel free to tag members/contributors who may be interested in your PR.
@stevhliu

@datavistics would you like to update the table instead? I actually liked it

They have changed it a couple times. I was a bit worried it could go out of date again. Happy to add it if you think its worth it though. What do you think?

Maybe we can have just a few GPUs in the table as an example of what is offered and then tell users to follow the link for a more complete list? This way, you don't have to maintain this table in two places (Cookbook/Inference Endpoint docs) but users still get an idea of what is offered.

I added most of them

I agree with Steven's comments, once addressed we can merge IMO

@stevhliu , I updated it, but Im not sure how to check if the tip formatting worked or not?

I usually check through the doc-builder bot's live preview. The Tip formatting looks good, thanks again for the update!


Ui fix fields list double space and more

made a card for it: https://trello.com/c/MShvpksd/508-frontend-fixes


How to set API_URI in windows

when I install the saleor-dashboard2.0 in windows10,How can I set API_URI and APP_MOUNT_URI.And the dashboard2.0 is as a app in the saleor? How can I connection with my local saleor?thanks

when I install the saleor-dashboard2.0 in windows10,How can I set API_URI and APP_MOUNT_URI.And the dashboard2.0 is as a app in the saleor? How can I connection with my local saleor?thanks

So could you maybe elucidate us on which files we need to alter because I am also stuck at this stage of implementation


Option for cycling through anc options

It would be nice if pbpctrl set anc could have an option that allows you to cycle through ANC modes instead of only allowing you to set it. This would make it easy to create a keyboard shortcut to cycle through the ANC modes, following the order configured on the device.

Implemented in 05a2f8886f33da9b3282e135356488659c0c992b.
A note: The order is fixed and can't be changed as far as I know. I believe it's only possible to enable/disable certain states in the ANC cycle. pbpctrl set anc cycle-next / pbpctrl set anc cycle-prev can now be used similar to how the ANC gesture works, following the (fixed) cycle in the app, skipping disabled states.


Inconsistant Role rendering in Tables

Environment

Nautobot version (Docker tag too if applicable): 2.3.10
Python version: 3.11
Database platform, version: Postgres 11
Middleware(s):

Steps to Reproduce

Create a Role, set color and add DCIM:Device and DCIM:Controller Content types.
Create a Device and assign the above role
Create a Controller and assign the above role
Look at the Table and Detail view for Device, then Controller

Expected Behavior
The Roles are rendered the same and with the chosen color.

Observed Behavior
The Roles are not consistently rendered.

This is due to not all the tables using RoleTableMixin or the templates not using hyperlinked_object_with_color.  Interestingly, the VLANTable has custom templating for this Role field.


Fix: airflow db initialization

Description of your changes

Fixes: Use init container to create database if not exist
Fixes: Use mysql context setting/secret to get connection informations
Fixes: change docker registry

How has this code been tested

@xingcan-ltc this should be cherry-picked to main.


Update travis build to support Rails 6

added a maintenance policy
indicated intention to drop support for Rails 4.2 when Ruby 2.4 is EOL

Pull Request Test Coverage Report for Build 480

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 95.823%

Totals

Change from base Build 478:
0.0%

Covered Lines:
1193

Relevant Lines:
1245

💛  - Coveralls


Corrected : Reduced the loading time

Gsoc Screen projects are visible and the loding time is reduced
Problem / Issue No.

Clearly describe the Problem or provide reference to Issue Number
BUG: Excessive Loading Time for Google Summer of Code Screen #179

Describe Problem / Root Cause

Briefly tell the cause of the problem and provide relevant information
The api is not working and it is not properly connected to the screen

Solution proposed

Explain your code changes and how it fixes the issue.
Loaded all the projects correctly

Additional Information

Relevant information regarding the solution.

Screenshots

Original Screenshot (Problem/Issue)
Updated Screenshot (Fixes/Solution)

https://github.com/andoriyaprashant/OpSo/assets/115913159/4556d796-62fd-4587-bdb0-1e6c90a390f2

@vijaymehrotra Please remove unnecessary files from the pull request. Additionally, use 'git pull' before creating a new branch, then make your changes and push them. Your pull request currently includes changes from another pull request that are unnecessary, so please fix this.


5 sec lag when consuming from multiple topics in multi-broker cluster

Describe the bug
I've observed https://github.com/tulios/kafkajs/issues/370-like behaviour when subscribing to multiple topics from a single Consumer
To Reproduce

A 3-broker cluster
Create topic1 and topic2 - 1 partition, 3 replicas
Run a consumer that subscribes to both topics

Note Fetching from 2 partitions for 2 out of 2 topics (from here) every 5 seconds (requires logLevel.DEBUG)

Publish a message to one of these topics every 1 second (I used kafkacat)

Expected behavior
The consumer's eachMessage "callback" is executed every second (mills after a message is published)
Observed behavior
The consumer's eachMessage "callback" is executed every 5 seconds (the default maxWaitTimeInMs value)
Environment:

OS: Ubuntu Ubuntu 18.04.5 LTS (GNU/Linux 4.15.0-128-generic x86_64)
KafkaJS version: 1.15.0
Kafka version: confluentinc/cp-kafka:5.0.1 (docker)
NodeJS version: v10.19.0

Additional Info
If we only subscribe to the topic we're publishing to then it works as expected

Here are some relevant logs from one of my test runs.  The consumer is connected to 2 of the 3 brokers in the cluster (<host>:9092 and <host>:9093)
Here's a 5 second polling cycle where nothing is going on (i.e., no messages published)...
{"t":"2021-01-02T14:45:14.264Z","m":"Request Heartbeat(key: 12, version: 2)","args":{"namespace":"Connection","broker":"<host>:9093","correlationId":72,"expectResponse":true,"size":98}}
{"t":"2021-01-02T14:45:14.265Z","m":"Response Heartbeat(key: 12, version: 2)","args":{"namespace":"Connection","broker":"<host>:9093","correlationId":72,"size":10,"data":{"throttleTime":0,"errorCode":0,"clientSideThrottleTime":0}}}
{"t":"2021-01-02T14:45:14.265Z","m":"Fetching from 2 partitions for 2 out of 2 topics","args":{"namespace":"ConsumerGroup","topics":["topic2","topic1"],"activeTopicPartitions":[{"topic":"topic2","partitions":[0]},{"topic":"topic1","partitions":[0]}],"pausedTopicPartitions":[]}}
{"t":"2021-01-02T14:45:14.266Z","m":"Request Fetch(key: 1, version: 8)","args":{"namespace":"Connection","broker":"<host>:9092","correlationId":37,"expectResponse":true,"size":104}}
{"t":"2021-01-02T14:45:14.266Z","m":"Request Fetch(key: 1, version: 8)","args":{"namespace":"Connection","broker":"<host>:9093","correlationId":73,"expectResponse":true,"size":102}}
{"t":"2021-01-02T14:45:19.267Z","m":"Response Fetch(key: 1, version: 8)","args":{"namespace":"Connection","broker":"<host>:9092","correlationId":37,"size":80,"data":"[filtered]"}}
{"t":"2021-01-02T14:45:19.268Z","m":"Response Fetch(key: 1, version: 8)","args":{"namespace":"Connection","broker":"<host>:9093","correlationId":73,"size":78,"data":"[filtered]"}}

~1 second after the next cycle started (at 14:45:20.269) I published 3 messages using kafkacat.  I also had a kafkacat consumer running - it immediately showed displayed the 3 messages
Note that the first message is received almost immediately from <host>:9093, but the next fetch request isn't sent until <host>:9092's request times out.
{"t":"2021-01-02T14:45:19.269Z","m":"Request Heartbeat(key: 12, version: 2)","args":{"namespace":"Connection","broker":"<host>:9093","correlationId":74,"expectResponse":true,"size":98}}
{"t":"2021-01-02T14:45:19.270Z","m":"Response Heartbeat(key: 12, version: 2)","args":{"namespace":"Connection","broker":"<host>:9093","correlationId":74,"size":10,"data":{"throttleTime":0,"errorCode":0,"clientSideThrottleTime":0}}}
{"t":"2021-01-02T14:45:19.270Z","m":"Fetching from 2 partitions for 2 out of 2 topics","args":{"namespace":"ConsumerGroup","topics":["topic2","topic1"],"activeTopicPartitions":[{"topic":"topic2","partitions":[0]},{"topic":"topic1","partitions":[0]}],"pausedTopicPartitions":[]}}
{"t":"2021-01-02T14:45:19.271Z","m":"Request Fetch(key: 1, version: 8)","args":{"namespace":"Connection","broker":"<host>:9092","correlationId":38,"expectResponse":true,"size":104}}
{"t":"2021-01-02T14:45:19.272Z","m":"Request Fetch(key: 1, version: 8)","args":{"namespace":"Connection","broker":"<host>:9093","correlationId":75,"expectResponse":true,"size":102}}
{"t":"2021-01-02T14:45:20.269Z","m":"Response Fetch(key: 1, version: 8)","args":{"namespace":"Connection","broker":"<host>:9093","correlationId":75,"size":656,"data":"[filtered]"}}
{"t":"2021-01-02T14:45:20.269Z","m":"Consumed","args":{"messageId":"a9a2600f-6366-4c2c-88d0-18f1f109fa7b","messageType":"MESSAGE","topics":["topic1","topic2"]}}
{"t":"2021-01-02T14:45:20.270Z","m":"Request OffsetCommit(key: 8, version: 4)","args":{"namespace":"Connection","broker":"<host>:9093","correlationId":76,"expectResponse":true,"size":146}}
{"t":"2021-01-02T14:45:20.273Z","m":"Response OffsetCommit(key:8, version: 4)","args":{"namespace":"Connection","broker":"<host>:9093","correlationId":76,"size":40,"data":{"throttleTime":0,"responses":[{"topic":"topic1","partitions":[{"partition":0,"errorCode":0}]}],"clientSideThrottleTime":0}}}
{"t":"2021-01-02T14:45:24.273Z","m":"Response Fetch(key: 1, version: 8)","args":{"namespace":"Connection","broker":"<host>:9092","correlationId":38,"size":80,"data":"[filtered]"}}

The remaining two messages are received in the next cycle.
{"t":"2021-01-02T14:45:24.274Z","m":"Request Heartbeat(key: 12, version: 2)","args":{"namespace":"Connection","broker":"<host>:9093","correlationId":77,"expectResponse":true,"size":98}}
{"t":"2021-01-02T14:45:24.275Z","m":"Response Heartbeat(key: 12, version: 2)","args":{"namespace":"Connection","broker":"<host>:9093","correlationId":77,"size":10,"data":{"throttleTime":0,"errorCode":0,"clientSideThrottleTime":0}}}
{"t":"2021-01-02T14:45:24.275Z","m":"Fetching from 2 partitions for 2 out of 2 topics","args":{"namespace":"ConsumerGroup","topics":["topic2","topic1"],"activeTopicPartitions":[{"topic":"topic2","partitions":[0]},{"topic":"topic1","partitions":[0]}],"pausedTopicPartitions":[]}}
{"t":"2021-01-02T14:45:24.276Z","m":"Request Fetch(key: 1, version: 8)","args":{"namespace":"Connection","broker":"<host>:9092","correlationId":39,"expectResponse":true,"size":104}}
{"t":"2021-01-02T14:45:24.276Z","m":"Request Fetch(key: 1, version: 8)","args":{"namespace":"Connection","broker":"<host>:9093","correlationId":78,"expectResponse":true,"size":102}}
{"t":"2021-01-02T14:45:24.278Z","m":"Response Fetch(key: 1, version: 8)","args":{"namespace":"Connection","broker":"<host>:9093","correlationId":78,"size":1234,"data":"[filtered]"}}
{"t":"2021-01-02T14:45:24.278Z","m":"Consumed","args":{"messageId":"39425c99-4976-45a8-a2b8-8a4abb5fed69","messageType":"MESSAGE","topics":["topic1","topic2"]}}
{"t":"2021-01-02T14:45:24.279Z","m":"Consumed","args":{"messageId":"3f3a5ad4-3ceb-4d47-8342-21fccf11982c","messageType":"MESSAGE","topics":["topic1","topic2"]}}
{"t":"2021-01-02T14:45:29.277Z","m":"Response Fetch(key: 1, version: 8)","args":{"namespace":"Connection","broker":"<host>:9092","correlationId":39,"size":80,"data":"[filtered]"}}
{"t":"2021-01-02T14:45:29.277Z","m":"Request OffsetCommit(key: 8, version: 4)","args":{"namespace":"Connection","broker":"<host>:9093","correlationId":79,"expectResponse":true,"size":146}}
{"t":"2021-01-02T14:45:29.280Z","m":"Response OffsetCommit(key:8, version: 4)","args":{"namespace":"Connection","broker":"<host>:9093","correlationId":79,"size":40,"data":{"throttleTime":0,"responses":[{"topic":"topic1","partitions":[{"partition":0,"errorCode":0}]}],"clientSideThrottleTime":0}}}

Here are some relevant logs from one of my test runs.  The consumer is connected to 2 of the 3 brokers in the cluster (<host>:9092 and <host>:9093)
Here's a 5 second polling cycle where nothing is going on (i.e., no messages published)...
{"t":"2021-01-02T14:45:14.264Z","m":"Request Heartbeat(key: 12, version: 2)","args":{"namespace":"Connection","broker":"<host>:9093","correlationId":72,"expectResponse":true,"size":98}}
{"t":"2021-01-02T14:45:14.265Z","m":"Response Heartbeat(key: 12, version: 2)","args":{"namespace":"Connection","broker":"<host>:9093","correlationId":72,"size":10,"data":{"throttleTime":0,"errorCode":0,"clientSideThrottleTime":0}}}
{"t":"2021-01-02T14:45:14.265Z","m":"Fetching from 2 partitions for 2 out of 2 topics","args":{"namespace":"ConsumerGroup","topics":["topic2","topic1"],"activeTopicPartitions":[{"topic":"topic2","partitions":[0]},{"topic":"topic1","partitions":[0]}],"pausedTopicPartitions":[]}}
{"t":"2021-01-02T14:45:14.266Z","m":"Request Fetch(key: 1, version: 8)","args":{"namespace":"Connection","broker":"<host>:9092","correlationId":37,"expectResponse":true,"size":104}}
{"t":"2021-01-02T14:45:14.266Z","m":"Request Fetch(key: 1, version: 8)","args":{"namespace":"Connection","broker":"<host>:9093","correlationId":73,"expectResponse":true,"size":102}}
{"t":"2021-01-02T14:45:19.267Z","m":"Response Fetch(key: 1, version: 8)","args":{"namespace":"Connection","broker":"<host>:9092","correlationId":37,"size":80,"data":"[filtered]"}}
{"t":"2021-01-02T14:45:19.268Z","m":"Response Fetch(key: 1, version: 8)","args":{"namespace":"Connection","broker":"<host>:9093","correlationId":73,"size":78,"data":"[filtered]"}}

~1 second after the next cycle started (at 14:45:20.269) I published 3 messages using kafkacat.  I also had a kafkacat consumer running - it immediately showed displayed the 3 messages
Note that the first message is received almost immediately from <host>:9093, but the next fetch request isn't sent until <host>:9092's request times out.
{"t":"2021-01-02T14:45:19.269Z","m":"Request Heartbeat(key: 12, version: 2)","args":{"namespace":"Connection","broker":"<host>:9093","correlationId":74,"expectResponse":true,"size":98}}
{"t":"2021-01-02T14:45:19.270Z","m":"Response Heartbeat(key: 12, version: 2)","args":{"namespace":"Connection","broker":"<host>:9093","correlationId":74,"size":10,"data":{"throttleTime":0,"errorCode":0,"clientSideThrottleTime":0}}}
{"t":"2021-01-02T14:45:19.270Z","m":"Fetching from 2 partitions for 2 out of 2 topics","args":{"namespace":"ConsumerGroup","topics":["topic2","topic1"],"activeTopicPartitions":[{"topic":"topic2","partitions":[0]},{"topic":"topic1","partitions":[0]}],"pausedTopicPartitions":[]}}
{"t":"2021-01-02T14:45:19.271Z","m":"Request Fetch(key: 1, version: 8)","args":{"namespace":"Connection","broker":"<host>:9092","correlationId":38,"expectResponse":true,"size":104}}
{"t":"2021-01-02T14:45:19.272Z","m":"Request Fetch(key: 1, version: 8)","args":{"namespace":"Connection","broker":"<host>:9093","correlationId":75,"expectResponse":true,"size":102}}
{"t":"2021-01-02T14:45:20.269Z","m":"Response Fetch(key: 1, version: 8)","args":{"namespace":"Connection","broker":"<host>:9093","correlationId":75,"size":656,"data":"[filtered]"}}
{"t":"2021-01-02T14:45:20.269Z","m":"Consumed","args":{"messageId":"a9a2600f-6366-4c2c-88d0-18f1f109fa7b","messageType":"MESSAGE","topics":["topic1","topic2"]}}
{"t":"2021-01-02T14:45:20.270Z","m":"Request OffsetCommit(key: 8, version: 4)","args":{"namespace":"Connection","broker":"<host>:9093","correlationId":76,"expectResponse":true,"size":146}}
{"t":"2021-01-02T14:45:20.273Z","m":"Response OffsetCommit(key:8, version: 4)","args":{"namespace":"Connection","broker":"<host>:9093","correlationId":76,"size":40,"data":{"throttleTime":0,"responses":[{"topic":"topic1","partitions":[{"partition":0,"errorCode":0}]}],"clientSideThrottleTime":0}}}
{"t":"2021-01-02T14:45:24.273Z","m":"Response Fetch(key: 1, version: 8)","args":{"namespace":"Connection","broker":"<host>:9092","correlationId":38,"size":80,"data":"[filtered]"}}

The remaining two messages are received in the next cycle.
{"t":"2021-01-02T14:45:24.274Z","m":"Request Heartbeat(key: 12, version: 2)","args":{"namespace":"Connection","broker":"<host>:9093","correlationId":77,"expectResponse":true,"size":98}}
{"t":"2021-01-02T14:45:24.275Z","m":"Response Heartbeat(key: 12, version: 2)","args":{"namespace":"Connection","broker":"<host>:9093","correlationId":77,"size":10,"data":{"throttleTime":0,"errorCode":0,"clientSideThrottleTime":0}}}
{"t":"2021-01-02T14:45:24.275Z","m":"Fetching from 2 partitions for 2 out of 2 topics","args":{"namespace":"ConsumerGroup","topics":["topic2","topic1"],"activeTopicPartitions":[{"topic":"topic2","partitions":[0]},{"topic":"topic1","partitions":[0]}],"pausedTopicPartitions":[]}}
{"t":"2021-01-02T14:45:24.276Z","m":"Request Fetch(key: 1, version: 8)","args":{"namespace":"Connection","broker":"<host>:9092","correlationId":39,"expectResponse":true,"size":104}}
{"t":"2021-01-02T14:45:24.276Z","m":"Request Fetch(key: 1, version: 8)","args":{"namespace":"Connection","broker":"<host>:9093","correlationId":78,"expectResponse":true,"size":102}}
{"t":"2021-01-02T14:45:24.278Z","m":"Response Fetch(key: 1, version: 8)","args":{"namespace":"Connection","broker":"<host>:9093","correlationId":78,"size":1234,"data":"[filtered]"}}
{"t":"2021-01-02T14:45:24.278Z","m":"Consumed","args":{"messageId":"39425c99-4976-45a8-a2b8-8a4abb5fed69","messageType":"MESSAGE","topics":["topic1","topic2"]}}
{"t":"2021-01-02T14:45:24.279Z","m":"Consumed","args":{"messageId":"3f3a5ad4-3ceb-4d47-8342-21fccf11982c","messageType":"MESSAGE","topics":["topic1","topic2"]}}
{"t":"2021-01-02T14:45:29.277Z","m":"Response Fetch(key: 1, version: 8)","args":{"namespace":"Connection","broker":"<host>:9092","correlationId":39,"size":80,"data":"[filtered]"}}
{"t":"2021-01-02T14:45:29.277Z","m":"Request OffsetCommit(key: 8, version: 4)","args":{"namespace":"Connection","broker":"<host>:9093","correlationId":79,"expectResponse":true,"size":146}}
{"t":"2021-01-02T14:45:29.280Z","m":"Response OffsetCommit(key:8, version: 4)","args":{"namespace":"Connection","broker":"<host>:9093","correlationId":79,"size":40,"data":{"throttleTime":0,"responses":[{"topic":"topic1","partitions":[{"partition":0,"errorCode":0}]}],"clientSideThrottleTime":0}}}

I've just discovered https://github.com/tulios/kafkajs/issues/683... so closing this issue as a duplicate

I've just discovered https://github.com/tulios/kafkajs/issues/683... so closing this issue as a duplicate


Add parser ref in Regsitry to addon iterate sub-nodes possibility + A…

This fix makes it possible to access configure sub-views of the NesteView view, this will be possible with this new feature implemented in the addons.

Addons feature to support other Views (NesteViews, WorkflowPepilineVIew, others...) #7

Demo using other views ( using this commit and addons  #7 commits )

Thank you for contributing to openstack-infra/jenkins-job-builder!
openstack-infra/jenkins-job-builder uses Gerrit for code review.
If you have never contributed to OpenStack before make sure you have read the
getting started documentation:
http://docs.openstack.org/infra/manual/developers.html#getting-started
Otherwise please visit
http://docs.openstack.org/infra/manual/developers.html#development-workflow
and follow the instructions there to upload your change to Gerrit.


enable memcached extensions

Hi guys,
I would like store my datas on a remote server.
Do I have to install memcache on all my webservers ? composers says so ... :(

You install the client (php5-memcache) on all webservers (as suggested). Where you install the server (memcached) is up to you.

It is not a bad idea to run memcached locally on your webservers, because it will be very low latency that way, but it is not mandatory.
Shall I close the issue?

Yes all good,  thank you very much for this very clear explonation !


Question about camera-16.pkl

Thanks for your work!
I came across the meaning of the arrays in the .pkl file, could you please tell me the meaning of the arrays respectively？

They are defined here. https://github.com/liuyuan-pal/SyncDreamer/blob/bcad0f11b72c027cc4d0464918a7f6bb07ac26e5/blender_script.py#L279


Multiple Generation Similar to Huggingface num_return_sequences

I want to generate multiple output from single prompt. is there any way i can have multiple generation from fine-tuned llama3.1 model similar to what num_return_sequences do in huggingface?
Hugginface Code
beam_outputs = model.generate(
**model_inputs,
max_new_tokens=40,
num_beams=5,
no_repeat_ngram_size=2,
num_return_sequences=5,
early_stopping=True
)
print("Output:\n" + 100 * '-')
for i, beam_output in enumerate(beam_outputs):
print("{}: {}".format(i, tokenizer.decode(beam_output, skip_special_tokens=True)))

I'll need to get back to you - I think multi sequence gens might still be bugged, but unsure yet - let me get back to you

Hi, about this I have something.
When using Llama based models (ex. llama-3.1, codellama) it works both for chat and completion as in the example below:
match model_type:
case "chat":
    messages_batch = []
    for input_text in input_texts:
        messages = [
            {"role": "user", "content": CHAT_PROMPT.format(input_text)},
        ]
        messages_batch.append(messages)
    inputs = tokenizer.apply_chat_template(
        messages_batch,
        tokenize=True,
        padding=True,
        add_generation_prompt=True,
        return_tensors="pt",
    ).to("cuda")
    outputs = model.generate(
        inputs,
        max_new_tokens=max_new_tokens,
        use_cache=True,
        temperature=temperature,
        return_dict_in_generate=True,
        output_scores=True,
        top_k=50,
        do_sample=True,
        num_return_sequences=num_return_sequences,
        eos_token_id=tokenizer.encode(stop_token)[-1],
    )
    input_length = inputs.size(1)
    generated_tokens = outputs.sequences[:, input_length:]
case "completion":
    inputs = tokenizer([COMMAND_PROMPT.format(text) for text in input_texts], return_tensors="pt",
                       padding=True).to("cuda")
    outputs = model.generate(
        **inputs,
        max_new_tokens=max_new_tokens,
        use_cache=True,
        temperature=temperature,
        return_dict_in_generate=True,
        output_scores=True,
        top_k=50,
        do_sample=True,
        num_return_sequences=num_return_sequences,
        eos_token_id=tokenizer.encode(stop_token)[-1],
    )
    generated_tokens = outputs.sequences[:, inputs['input_ids'].size(-1):]

With gemma however it doesn't work at all (same code as above):
E0828 21:39:05.623000<PHONE_NUMBER>71616 torch/_subclasses/fake_tensor.py:1761] [1/102] RuntimeError: Attempting to broadcast a dimension of length s10 at -4! Mismatching argument at index 1 had torch.Size([s10, 1, s12, s10]); but expected shape should be broadcastable to [s4, s2*s3, s12, s10]
Seems that is due to a bug in the transformers library, that SHOULD have been fixed 15 days ago. I don't know if you need to reflect that change or not, I'll refer here the thread I found: https://huggingface.co/google/gemma-2-27b-it/discussions/28
Hope this helps!


Use prefix for the haproxy app config file

OCD build https://ocd.appscale.com:8080/job/Daily Build/4744/


chore: cjxd10-go-http to 0.0.1

chore: Promote cjxd10-go-http to version 0.0.1

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please assign
You can assign the PR to them by writing /assign  in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


add new strategy delete_all_using_limit_in_batches

add order for with tenant_id_field case as it force DB using needed DB index

@Azdaroth , could you please review?

@Azdaroth , could you please review?

@Azdaroth , could you please review again?

@Azdaroth , could you please review again?

@LeoMo42 0.3.0 is released 🎉

@LeoMo42 0.3.0 is released 🎉


Make the SDF filled

Hey, great example :)
I'm trying to use this for realtime collision detection for a SkinneMesh. The SDF being hollow thing is making that a bit tricky. Is there any way to make the SDF filled so the distance goes from 1 to -1?
Cheers Daniel

Hey, I'd also love to find a way to make the SDF solid. Any pointers about how to solve the problem would be appreciated. Thanks!

So currently the way the algorithm works is by writing a binary mask + coordinate where each triangle intersects with our grid, and then flood-filling this to get the distance field. To make it "solid", this could be extended in a few ways, with various tradeoffs and problems for different geometries. Also note that you'll have to ensure the geometry is manifold to get any meaningful result, otherwise it'll be like using a paintbucket tool without making sure the lines are joined...

Instead of writing binary mask write a trinary one, having each triangle write inside for the grid cells on the frontface and outside for the grid cells on the backface. The floodfill will then fill the inside with the label written by the backfaces. The problems with this is that projecting the coords of the triangle "forward"/"backward" when you have non-ideal geometry could cause the inside to end up outside. You will also have to modify the mask writing to ensure that the voxel shell represented by the mask is fully closed
Compute mask as normal. Write a single point that you a-priory know is on the inside (or outside). Then run one floodfill floodfilling this point into the inside. This has the problem of first getting a point you know is inside or outside (but for skinned models, this could be fine). The larger problem is ensuring you don't have paintbucket-tool-without-closed-lines effect happening due to the voxel shell having holes. Perhaps that can be fixed by a pass that dilates  or erodes it

This reminded me, this blog post about JFA says:
"He (Demofox) also has a post on doing SDF with a bit more detail. The only thing I would add to his description is that you do not need to run the JFA twice in order to generate the signed aspect. When computing the final distance you just check the original mask again and multiply the distance by -1 when inside the mask before you bias scale into the 0 to 1 range. I never saw any problem doing that."
I've been meaning to try this with MeshToSDF but haven't gotten around to it. Does it make sense to you @aman-tiwari ? Is it worth investigating?
Thanks.


gc doesn't know about by-sha256

Running gc in the presence of by-sha256 splitstreams gives:

Error: category directory contains non-symlink

Which is probably for the best, because it doesn't know about them and would probably decide to delete them if it could find them.
We should do something sensible there.  I wonder if we should take a more generic approach to symlink handling: all symlinks reachable from anything under */refs/** get to live.  We can better do the checking about if the structure is correct from fsck.

by-sha256 got axed, but we still need to update the GC code to understand that the symlinks directly in streams/ are now body sha256.


📈assertRevert with message checking.

Provide assertRevert with the ability to check the revert message (added in solidity 0.4.22).

Not 100% sure on what you have in mind with this, do you want to provide an expected error message, and have the assert fail on a mismatch?

Bingo, that is exactly what I meant.

With #326 on the horizon, it makes sense to add the capability to the helpers, but I don't know if we want to commit to error messages in OZ itself yet. @frangio WDYT?

There's #888 for discussing revert reasons (error messages) in OpenZeppelin itself.
It makes sense to move forward with this helper though even before we introduce reasons in OpenZeppelin.

Hi @MoMannn , I was looking into this issue and wanted to extend assertRevert as per your suggestion to check for revert() error messages. Now I realize, that I actually don't know how to access the error message in a Truffle test. Do you have any pointers on how to approach this?

@justuswilhelm Sorry I have never went into the details of truffle so I can't really help you here it is just a feature I would like to have. @shrugs will probably be a better person to address this.

Sadly, it looks like this isn't yet possible in web3: https://github.com/ethereum/web3.js/issues/1707.

web3.js is not the culprit. There is actually no way to retrieve the revert reason from a node. EIP 758 is a proposal to solve that, and there's Geth (https://github.com/ethereum/go-ethereum/pull/16424) and Ganache (https://github.com/trufflesuite/ganache-core/issues/116) issues to implement it.
I guess we'll have to wait and see how that plays out.

Looks like truffle 5.0 will allow for this to be possible: see the relevant beta release notes.

It is worth noting that checking revert reason is currently possible with Ganache CLI, as demoed in this repo https://github.com/remon-nashid/assertRevert.

@remon-nashid Nice! Are you interested in incorporating your code into the OpenZeppelin helper?

IMO this issue can be closed as 'assertRevert' is superseded by shouldFail.withMessage.

@remon-nashid agreed. Closing.


The whole architecture is not clean

The whole kubeflow/training-operator relies on kubeflow/common heavily. But the kubeflow/common was designed for old Controller architecture like the k8s's Job/Deployment Controller. Now we are using controller-runtime as our architecture to implement Controller, so the mixed using kubeflow/common and controller-runtime makes plenty of redundant codes. It goes without saying that this architecture brings many disadvantages.
Some direct evidences: the following codes come JobController in kubeflow/common.
https://github.com/kubeflow/common/blob/21910a93c4ed8d8338d9d7414067f888801dd0bc/pkg/controller.v1/common/job_controller.go#L104-L119
PodLister corelisters.PodLister

ServiceLister corelisters.ServiceLister

PriorityClassLister schedulinglisters.PriorityClassLister

PodInformerSynced cache.InformerSynced

ServiceInformerSynced cache.InformerSynced

PriorityClassInformerSynced cache.InformerSynced

WorkQueue workqueue.RateLimitingInterface

And following codes are NewReconciler of MPIJobReconciler.
https://github.com/kubeflow/training-operator/blob/e13d262fe4fabd548ded944e5356c99f30a33b00/pkg/controller.v1/mpi/mpijob_controller.go#L87-L99
In MPIJobReconciler struct:
The WorkQueue is useless, it is set by &util.FakeWorkQueue{}.
The PodInformerSynced and ServiceInformerSynced are useless, they are not initialized at all. The PriorityClassInformerSynced is also useless, but it has been initialized.
What I demonstrated here is just a part of this problem.
Referring to point2 of https://github.com/kubeflow/training-operator/issues/1703

cc @kuizhiqing  @tenzen-y @johnugeorge

Yes, introducing the controller-runtime pattern to the common codes would be better.
Actually, I mentioned about that: https://github.com/kubeflow/training-operator/issues/1816#issuecomment-1663721566
/lifecycle frozen


Build currently fails due to invalid smoltcp branch

The pull request https://github.com/m-labs/smoltcp/pull/186 was forced-pushed, so the commit referenced in the Cargo.lock does no longer exist. Updating the Cargo.lock is not possible at the moment because the new branch contains an invalid Cargo.toml: https://github.com/m-labs/smoltcp/pull/186#discussion_r254349551.
I think the best solution is to wait a bit and hope that the pull request gets merged soon. If it takes to long, we can use an own fork the branch to ensure that no force-pushes occur.

How can I help with getting this to build? I would really like to be able to use it for an upcoming project!

I think just running cargo update should do the trick

On the latest nightly the build still fails due to the updates to the futures/task API in https://github.com/rust-lang/rust/pull/57992. I tried to rebase our futures-rs fork for these changes: https://github.com/embed-rs/futures-rs/tree/alloc-rebase (I used a separate branch because I didn't test it yet). We also need to update our core wrapper and the future_mutex and task_runtime modules.

I'm gonna finish the rebases and updates