Tracking issue for search autocomplete API (RFC 27)

This issue is to track progress on implementing the new autocomplete API in Wagtail.
See: RFC 27
Phase 1: Groundwork:

[x] Implement AutocompleteField
[x] Implement .autocomplete() method on search backends and BackendAutocompleteQueryCompiler class

Phase 2: Elasticsearch:

[x] Implement indexing support for AutocompleteField
[x] Implement ElasticsearchAutocompleteQueryCompiler

Phase 2: PostgreSQL search:

[x] Implement indexing support for AutocompleteField (#5960)
[x] Implement PostgresAutocompleteQueryCompiler

Phase 3: Launch (preferably all three in one PR)

[x] Document autocomplete API (#4938)
[x] Advertise new API in release notes
[x] Deprecate partial_match (following the Deprecation Path)

@kaedroho I see you assigned me. Was it for “Implement indexing support for AutocompleteField”? It’s already done and merged :slightly_smiling_face: (checked the list item)

Oh, I couldn't find any mention of it in the code. Thanks!

@BertrandBordage Are you sure about that? I'm looking at the indexing code and can't see it: https://github.com/wagtail/wagtail/blob/master/wagtail/contrib/postgres_search/backend.py#L94-L96

Aaaaah, sorry, you’re right. Brain fart.

PR for finishing PostgreSQL implementation: https://github.com/wagtail/wagtail/pull/5960

Rest of the implementation of this is in now. Just docs and deprecation left to do!

@kaedroho  not sure if we wanted to be louder about this but I have added 02d6d27a9c687c8d5e24ddba6d59b98a96e4d04d to the release notes.
Feel free to update if you think that is not sufficient

Hey everyone,
I was thinking where to put this and I guessed, that it would be easiest if I just comment here - even though this thread is a little old, but I am not sure if this is worth an own issue.
Getting to the point:
I was wondering why it seems that there is no work intended to support the autocomplete search using the Wagtail Rest Api. For example by extending the PagesAPIViewSet or something like this.
Is in planned somehow somewhere and I just didn't find it?
Thank you so much :)

I see the last un-checked item here was Deprecate partial_match (following the Deprecation Path). This is done as of Wagtail 6.0 removals, so I’ll close this issue now.


Created Greenhouse blockout and added some materials

Created blockout for greenhouse area with population, and adjusted it based on feedback. Added some new color materials too.

I forgot to save the scene when I finished haha


What do I need to set the http proxy to?

Hi, I'm a little confused on what I need to set my proxy to. Further, I was wondering if there was a way that configuring your proxy, uid, and gid could be sidestepped such that the container would work for all computers right off of the git pull. Containers, after all, are intended to be OS and user agnostic, so finding a solution to that problem would be great!

hi, http_proxy is only set up to speed up development cycle of image (download dependencies), because my internet connection is not the fastest, and build and destroy cycle takes some time. You can build image of docker-vmd without proxy - it should work fine.

Hardcoding uid, and gid is required to connect to Xserver and display GUI of VMD. Without proper right the permissions it won't be working. For more info see this post:

http://fabiorehm.com/blog/2014/09/11/running-gui-apps-with-docker/

Probably in 2018 you can skip UID and GID part using technique described here: https://medium.com/@SaravSun/running-gui-applications-inside-docker-containers-83d65c0db110 ;
But I didn't tried it.


fix(Analytics): Fixing issues when calling flushEvents

Description of changes:
Fixing some issues when calling Amplify.Analytics.flushEvents() so they match what we do in v2:

AWSPinpointAnalyticsClient.submitEvents() returns an error when there are no events to submit, which we are then dispatching to the Hub. This is problematic with Amplify's automatic flush of events, as it would spam the Hub with errors that are not really errors. So whenever we get a "No events to submit." error, I'm dispatching an empty array instead.
Dispatching a customized error for connectivity issues, for better readability in logs.

Check points: (check or cross out if not relevant)

[X] Added new tests to cover change, if needed
[X] Build succeeds with all target using Swift Package Manager
[X] All unit tests pass
[X] All integration tests pass
[X] Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)
[ ] ~Documentation update for the change if required~
[X] PR title conforms to conventional commit style
[ ] ~If breaking change, documentation/changelog update with migration instructions~

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Codecov Report

Merging #2518 (9c72d2c) into v1 (618d6ce) will increase coverage by 0.00%.
The diff coverage is 71.42%.

@@           Coverage Diff           @@
##               v1    #2518   +/-   ##
=======================================
  Coverage   64.10%   64.10%
=======================================
  Files         720      720
  Lines       22644    22654   +10
=======================================
+ Hits        14516    14523    +7
- Misses       8128     8131    +3

Flag
Coverage Δ

API_plugin_unit_test
66.66% <ø> (ø)

AWSPluginsCore
73.30% <ø> (ø)

Amplify
51.32% <ø> (ø)

Analytics_plugin_unit_test
72.43% <71.42%> (-0.29%)
:arrow_down:

Auth_plugin_unit_test
81.94% <ø> (ø)

DataStore_plugin_unit_test
81.94% <ø> (+0.01%)
:arrow_up:

Geo_plugin_unit_test
57.87% <ø> (ø)

Predictions_plugin_unit_test
33.53% <ø> (ø)

Storage_plugin_unit_test
59.25% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...Configuration/AmplifyAWSServiceConfiguration.swift
73.91% <ø> (ø)

...icsPlugin/Support/Utils/AnalyticsErrorHelper.swift
75.00% <50.00%> (-25.00%)
:arrow_down:

...in/AWSPinpointAnalyticsPlugin+ClientBehavior.swift
97.43% <100.00%> (+0.10%)
:arrow_up:

...gin/Sync/InitialSync/ModelSyncedEventEmitter.swift
94.84% <0.00%> (-1.04%)
:arrow_down:

...eCategoryPlugin/Sync/RemoteSyncEngine+Action.swift
58.82% <0.00%> (ø)

...oreCategoryPlugin/Sync/Support/Model+Compare.swift
84.37% <0.00%> (+2.08%)
:arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Support MultiplicativeGroup, AdditiveSemigroup and friends

Describe the solution you'd like
For the purposes of coulomb I would integrate with iron using certain constraints, primarily restrictions that preserve algebraic behavior.  An example is that positive numbers are a multiplicative group.  MultiplicativeGroup[IronType[V, Positive]]
Describe alternatives you've considered
The alternative would be to provide them in coulomb myself, as I did for refined
Note: Before posting your issue, check if it doesn't exists in the latest version.

The particular algebras I defined for refined are here:
https://github.com/erikerlandson/coulomb/tree/v0.9.0-RC1/refined/src/main/scala/coulomb/integrations/refined/algebra
I would define the same algebras for iron.  some of these might make sense to define directly in iron

Hello.
I read the refined version you sent and I'm not sure about AdditiveSemigroup. AFAIK, addition can give a negative number if it overflows.
scala> Int.MaxValue + 1
val res0: Int = -2147483648

but MultiplicativeGroup should be ok.

It is possible to underflow multiplication (it's one of my unit tests).  Like machine epsilon * machine epsilon.  It might be a problem for your library since IronType[V] <: V

This might also be a "non-issue" aswell. Maybe the overflow/underflow case is too marginal to justify not adding AdditiveSemiroup and others in cats module.

I don't think there is a right or wrong answer.  My own philosophy is that the benefits of defining these algebras on native types outweighs the downside of overflows or underflows breaking lawfulness. If total soundness is important, then there is always BigDecimal, BigInt, spire Rational, etc.  However, type soundness is a core value of Scala and I respect the school of thought that one should avoid types that can be subverted by even rare cases.

My own philosophy is that the benefits of defining these algebras on native types outweighs the downside of overflows or underflows breaking lawfulness. If total soundness is important, then there is always BigDecimal, BigInt, spire Rational, etc.

Looks legit to me and I actually did not think about BigDecimal/BigInt :+1:

Does refined's Positive includes 0?

No, refined distinguishes between Positive and NonNegative


Fancy zone layout as Single alt-tab group

Description of the new feature / enhancement
Like in the windows 11 alt tab menu, It will be useful if the whole fancy zone layout was given as a single group.

The whole fancy zone layout could be a single group.
Scenario when this would be used?
I mostly use fancy zone when developing and I frequently alt tab to see documentation and then comeback to the development layout. But it is not convenient if each window in the fancy zone is separate and I have to alt tab multiple times to get back to the layout with every window showing. This is be vey useful for people with a single monitor like myself.
Supporting information
No response

I agree, would be a killer feature! For large groups of windows (e.g., I have a 3x3 setup) it is tedious to bring them to the foreground.

Bump. Is this implemented yet? It's the sole reason I downloaded FancyZones.

bump. i badly need this too

Bump.
To anyone waiting, here's a possible work around: remapping the shortcut for a new virtual desktop to Win + D and the shortcuts for going to the previous/next virtual desktop to Win + Left arrow and Win + Right arrow respectively made it possible to keep multiple window layouts. I just alternate between them instead of Alt + Tabbing. It's a bit of a learning curve tho.

I started doing that too. I usually have 3 virtual desktops, each with different layout for the different projects i am working on. (i work on 2 projects in my job, in case anyone is wondering) and have to juggle between them.
This is not perfect and sometime switching between desktops is not fast. Alt+Tab to a fancyzone group would be a absolutely great.

Hello I really wanted this feature I hope this gets implemented!
I want to layout my tabs differently and just use shortcut key to access them:
WIN + 1:

WIN + 2:

I want something like this, I hope someone read this.

Vote for this feature.

I would like to see this as a feature, would be very useful. My use case is to put multiple monitor terminals and tools in fancy zones, I want to see them all or none, and bring N windows one-by-one is a real mess as of now

Sadly this issue is moved to "Icebox" which is "We don't expect to get to these, but they're welcome community contribution ideas!"

Not sure why this would be put on ice box, it's such an essential feature that even Windows 11 got it natively. Or maybe this is the reason? Forcing people to upgrade?

Well I guess I need to upgrade to win 11 then
On Mon, 14 Oct 2024 at 18:04, Arthur Cuesta @.***>
wrote:

Not sure why this would be put on ice box, it's such an essential feature
that even Windows 11 got it natively. Or maybe this is the reason? Forcing
people to upgrade?
—
Reply to this email directly, view it on GitHub
https://github.com/microsoft/PowerToys/issues/21192#issuecomment-2410675112,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AME67AKYBZRDAH7KPRYNNRLZ3OJLJAVCNFSM6AAAAAARDCV4VGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMJQGY3TKMJRGI
.
You are receiving this because you commented.Message ID:
@.***>


Add feet and days, and resulting combinations.

Nice, I'm on phone and the diff is a bit big. Reviewing later tonight or tomorrow. Looks like a couple of tests are failing but it can just be the UI-tests. They are a bit fragile on AppVeyor. I'll check that also.


How to convert health icon back to old version 1.6

I want to change the health icon of version 1.7 back to version 1.6 where do I need to edit?
i mean want to use iconGrid.png on version 1.7
Thank you very much.

Do you want me to help? You might have to rename the files to the character names, though,


prerelease.keybase.io https certificate just expired and since it uses HSTS it's inaccessible

The certificate for prerelease.keybase.io is valid through Dec 27 23:59:59 2021 GMT and just expired. It's an Amazon certificate.
Ubuntu / Debian releases are inaccessible

Thanks for the report, we've renewed the certificate.


Smoothquant support ipex.optimize_transformers feature

Type of Change
ipex_opt_llm_supported = ["gptj", "gpt_neox", "opt", "llama", "falcon"] but only has validated "gptj", "llama", "opt".
quantization_config.ipex_opt_llm default is False, if unset the parameter in script,  when the model_type in supported list, quantization_config.ipex_opt_llm will be automatically set to True.
Description
detail description
JIRA ticket: xxx
Expected Behavior & Potential Risk
the expected behavior that triggered by this PR
How has this PR been tested?
how to reproduce the test (including hardware information)
Dependency Change?
any library dependency introduced or removed

coverage decrease about 1% due to add calib_func and get_example_inputs func for chatglm(before in the example scripts) but chatglm doesn't have small model to support ut test.


part5.R time_num at line 656

Vincent:
An error encountered with Part 5.  It is the line at 656-658 of part5.R.   This seems to be introduced in the release 1.5.9.  Any insight where could cause this?  Your advice is greatly appreciated.
(I have no sleep diary, 15 days of data, used the sample script from https://cran.r-project.org/web/packages/GGIR/vignettes/GGIR.html with minor changes)
Part 2
1

Part 3
1

Part 4
1

Part 5
1
Error in if (time_num < 12) time_num = time_num + 24 :
missing value where TRUE/FALSE needed

================
g.shell.GGIR(#=======================================
mode=mode,
datadir=datadir,
outputdir=outputdir,
f0=f0, f1=f1,
         #-------------------------------
         # Part 1:
         #-------------------------------
         # Key functions: reading file, auto-calibration, and extracting features
         do.enmo = TRUE,             do.anglez=TRUE,
         chunksize=1,                printsummary=TRUE,
         #-------------------------------
         # Part 2:
         #-------------------------------
         strategy = 2,               ndayswindow=14,
         hrs.del.start = 0,          hrs.del.end = 0,
         maxdur = 15,                 includedaycrit = 16,
         winhr = c(5,10),
         qlevels = c(c(1380/1440),c(1410/1440)),
         qwindow=c(0,24),
         ilevels = c(seq(0,400,by=50),8000),
         mvpathreshold =c(100,120),
         bout.metric = 4,
         closedbout=FALSE,
         #-------------------------------
         # Part 3:
         #-------------------------------
         # Key functions: Sleep detection
         timethreshold= c(5),        anglethreshold=5,
         ignorenonwear = TRUE,
         #-------------------------------
         # Part 4:
         #-------------------------------
         # Key functions: Integrating sleep log (if available) with sleep detection
         # storing day and person specific summaries of sleep
         excludefirstlast = FALSE,
         includenightcrit = 6,
         def.noc.sleep = c(),
         #loglocation= "C:/mydata/sleeplog.csv",
         outliers.only = TRUE,
         criterror = 4,
         relyonsleeplog = FALSE,
         sleeplogidnum = TRUE,
         colid=1,
         coln1=2,
         do.visual = TRUE,
         nnights = 14,
         #-------------------------------
         # Part 5:
         # Key functions: Merging physical activity with sleep analyses
         #-------------------------------
         threshold.lig = c(30), threshold.mod = c(100),  threshold.vig = c(400),
         boutcriter = 0.8,      boutcriter.in = 0.9,     boutcriter.lig = 0.8,
         boutcriter.mvpa = 0.8, boutdur.in = c(1,10,30), boutdur.lig = c(1,10),
         boutdur.mvpa = c(1),   timewindow = c("WW"),
         #-----------------------------------
         # Report generation
         #-------------------------------
         # Key functions: Generating reports based on meta-data
         do.report=c(2,4,5),
         visualreport=TRUE,     dofirstpage = TRUE,
         viewingwindow=1)

Dear all,  Just want to follow up on this issue.  It continues in the release of 1.5.17.  Any insight is greatly appreciated.

I may have fixed this now, and will include this in the next release version of GGIR on CRAN in the upcoming days. Let me know if the problem persists.


[ZEPPELIN-5372]. Fix the problem of Ldap connection leak in LdapGroupRealm

What is this PR for?

Fix the problem of Ldap connection leak in LdapGroupRealm

What type of PR is it?
[Bug Fix]
What is the Jira issue?

https://issues.apache.org/jira/browse/ZEPPELIN-5372

How should this be tested?

Ci pass

Questions:

Does the licenses files need update? no
Is there breaking changes for older versions? no
Does this needs documentation? no

Not sure whether this is the root cause. According the javadoc of Context#close, it looks like even close is not called, it would be released.
    /**
     * Closes this context.
     * This method releases this context's resources immediately, instead of
     * waiting for them to be released automatically by the garbage collector.
     *
     * <p> This method is idempotent:  invoking it on a context that has
     * already been closed has no effect.  Invoking any other method
     * on a closed context is not allowed, and results in undefined behaviour.
     *
     * @throws  NamingException if a naming exception is encountered
     */
    public void close() throws NamingException;

Not sure whether this is the root cause. According the javadoc of Context#close, it looks like even close is not called, it would be released.
    /**
     * Closes this context.
     * This method releases this context's resources immediately, instead of
     * waiting for them to be released automatically by the garbage collector.
     *
     * <p> This method is idempotent:  invoking it on a context that has
     * already been closed has no effect.  Invoking any other method
     * on a closed context is not allowed, and results in undefined behaviour.
     *
     * @throws  NamingException if a naming exception is encountered
     */
    public void close() throws NamingException;

@zjffdu
The close method of LdapCtx will call the close method of LdapClient to return the connection to the connection pool. If we rely on the GC mechanism, although the Context object can be cleared,  the connection will not be returned normally. And a new connection will be created the next time we try to obtain a connection, which will cause connection leakage.

Thanks for the clarification. PR LGTM.
BTW, do you know whether there's some connection pool library that we can use to manage the lifecycle of LDAP connection ? Let user to manage the connection lifecycle doesn't seem a proper solution.

Thanks for the clarification. PR LGTM.
BTW, do you know whether there's some connection pool library that we can use to manage the lifecycle of LDAP connection ? Let user to manage the connection lifecycle doesn't seem a proper solution.

I think even if we can manage the LDAP connection through a third-party connection pool library, we need to manually return the connection to the pool after using up the connection, which is the same as the current solution, or do you have any more detailed suggestions?

The close method of LdapCtx will call the close method of LdapClient to return the connection to the connection pool. If we rely on the GC mechanism, although the Context object can be cleared, the connection will not be returned normally. And a new connection will be created the next time we try to obtain a connection, which will cause connection leakage.

As bellow code of  LdapCtx::finalize(), LdapCtx::close() called also when it be released by GC.
    protected void finalize() {
        try {
            this.close();
        } catch (NamingException var2) {
        }

    }

In both cases, the same function(LdapCtx::close()) is called, but I don't understand that connection leaks occur only when released by the GC.

The close method of LdapCtx will call the close method of LdapClient to return the connection to the connection pool. If we rely on the GC mechanism, although the Context object can be cleared, the connection will not be returned normally. And a new connection will be created the next time we try to obtain a connection, which will cause connection leakage.

As bellow code of LdapCtx::finalize(), LdapCtx::close() called also when it be released by GC.
    protected void finalize() {
        try {
            this.close();
        } catch (NamingException var2) {
        }

    }

In both cases, the same function(LdapCtx::close()) is called, but I don't understand that connection leaks occur only when released by the GC.

@cuspymd  Thx, I re-tracked the source code according to your prompts. This is indeed not the root cause of the connection leak. I will close this PR and investigate other reasons for the connection leak.

@xiejiajun Thanks for your checking too.


[Create pricing card] Field 'City(s)' is not cleared after changing data in the field 'Область' on the pop-up window "Створити картку"

Environment:
Windows 10 Home (Version 22H2)
Chrome version 108.0.5359.71
MacOS version 12.6.1 (21G217)
Chromе version 107.0.5304.110
Reproducible: always
Build found: 17/12/2022
Preconditions

Go to https://www.testgreencity.ga/GreenCityClient/#/ubs
Sign in as Super admin
Go to page "Тарифи" and click on "gear" pictogram
Tap on “Створити картку”

Steps to reproduce

Choose “Кур’єр”, “Станція приймання”, “Область” and “Місто” (e.g. "Саша", "Саперна-сурта","Львівська область", " Стрий")
Change the previously chosen item in the field “Область” (e.g. "Івано-Франківська область")
Pay attention to the content of the field “Місто”

Actual result
Field 'City(s)' is not cleared after changing data in the field 'Область' on the pop-up window "Створити картку"
Expected result
After the region changing list of cities should be cleared and proposed that cities which are correspond chosen region
User story and test case links
E.g.: "User story #4202
Test case"
Labels to be added
"Bug", Priority ("pri:low "), Severity ("severity: minor"), Type ("UI, "Functional")
https://user-images.githubusercontent.com/110603507/208248748-70cd356d-49ab-4d7d-b263-ac77f331d428.mp4

Done


Python sample for speech_recognition_with_push_stream giving weird results.

Describe the bug
I am trying the python console app (speech_sample > speech_recognition_with_push_stream) with the default audio file and don't get any transcription. The connection is canceled right after the sessions starts (see log below).
To Reproduce

From cognitive-services-speech-sdk/samples/python/console, run:

python3 main.py

Expected behavior
Speech is transcribed and some recognition results is displayed.
Version of the Cognitive Services Speech SDK
1.23.0
Platform, Operating System, and Programming Language

OS: Ubuntu 22.04
Hardware - x64
Programming language: Python

Additional context

Output log:

You selected: <function speech_recognition_with_push_stream at 0x7f90b68257e0>
read 3200 bytes
SESSION STARTED: SessionEventArgs(session_id=524177f4ec994e499fa6329eccdb55f1)
CANCELED SpeechRecognitionCanceledEventArgs(session_id=524177f4ec994e499fa6329eccdb55f1, result=SpeechRecognitionResult(result_id=c6d464e275184b2ba04c4ff8af79f87f, text="", reason=ResultReason.Canceled))
SESSION STOPPED: SessionEventArgs(session_id=524177f4ec994e499fa6329eccdb55f1)
read 3200 bytes
read 3200 bytes
read 3200 bytes
read 3200 bytes
read 3200 bytes
read 3200 bytes
read 3200 bytes
read 3200 bytes
read 3200 bytes
read 3200 bytes
read 3200 bytes
read 3200 bytes
read 3200 bytes
read 3200 bytes
read 3200 bytes
read 3200 bytes
read 3200 bytes
read 3200 bytes
read 3200 bytes
read 960 bytes
read 0 bytes

select sample module, Ctrl-D to abort

Full Speech SDK log: log.txt

Hi @bhigy, thanks for using the SDK!
In your log I see an error loading libssl. What version of OpenSSL do you have installed? (You mentioned running Ubuntu 22.04, did you see the notes here for prerequisite setup)
On Ubuntu 22.04, install libssl1.1 either as a binary package such as libssl1.1_1.1.1l-1ubuntu1.3_amd64.deb,
or by compiling it from sources. The Speech SDK does not support OpenSSL 3.0,
which is the default in Ubuntu 22.04.


An attempt to fix issue with navigation links on mobile

Fixes #2547
I'm opening this PR for initial review of the solution.
The idea was to move the navigation links to the same place as the sidebar links on mobile devices.
I have added the navigation links to the sidebar links.
I have removed the toolbar links on mobile using css.
I have changed the css so that navigation links are not displayed in the sidebar when not on mobile device.
I have tested by coping the resulting build to my project's node_modules.
Before:

After:

Very nice, thank you!


[ML] Add support for model sweeping and hyperparameter tuning for AutoML NLP

Description
Add client support for model sweeping and hyperparameter tuning for AutoML NLP. This closely mirrors what AutoML Images has for their jobs.
All SDK Contribution checklist:

[X] The pull request does not introduce [breaking changes]
[X] CHANGELOG is updated for new features, bug fixes or other significant changes.
[X] I have read the contribution guidelines.

General Guidelines and Best Practices

[X] Title of the pull request is clear and informative.
[X] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

[X] Pull request includes test coverage for the included changes.

@harneetvirk Yes it is. I thought this had to be merged first in order to create the ASK mode request?

Yes, the change needs to be made in Main first and then release branch can have this change in it.


Unable To Reproduce Results in the Paper

Hi,
Thanks for releasing the code.
I ran the code for all of the arithmetic modules and was unable to get the testing performance reported in the paper (Figure 2).  For example, below is the training log for the arithmetic__add_sub_multiple module. The final testing accuracy is about 0.01, while the accuracy is very high in Figure 2. I was running python main.py --model_name tp-transformer --module_name arithmetic__add_sub_multiple. Maybe there is something wrong with the hyperparameters I was using?
Taking scripts from /n/fs/pvl-mathqa/deepmind-mathematics/TP-Transformer
... and saving them in log/arithmetic__add_sub_multiple/tp-transformer/lr=0.0001_bs=256_h=512_f=2048_nl=6_nh=8_d=0.0_Adam_/195932581/source
Arguments:
	seed=195932581
	model_name='tp-transformer'
	module_name='arithmetic__add_sub_multiple'
	load_model=''
	eval_mode=False
	n_steps=10000
	max_strikes=1000
	log_every=50
	eval_every=200
	full_loader=False
	force_remove=False
	force_reload=False
	no_train=False
	log_folder='log/arithmetic__add_sub_multiple/tp-transformer/lr=0.0001_bs=256_h=512_f=2048_nl=6_nh=8_d=0.0_Adam_/195932581'
	log_suffix=''
	optimizer='Adam'
	learning_rate=0.0001
	beta1=0.9
	beta2=0.995
	batch_size=256
	max_abs_grad_norm=0.1
	grad_accum_steps=1
	dropout=0.0
	hidden=512
	n_layers=6
	n_heads=8
	filter=2048
	d_r=0
	device=device(type='cuda')
using JIT loader
Loading JIT datasets ...
Creating iterators ...
Loading JIT datasets ...
Creating iterators ...
Building model ...
done. 49178624 trainable parameters.

eval: loss=6.1017 acc=0.0000 b/sec=0.16 time=0.1 min
run:  log/arithmetic__add_sub_multiple/tp-transformer/lr=0.0001_bs=256_h=512_f=2048_nl=6_nh=8_d=0.0_Adam_/195932581
best: loss=6.1017 acc=0.0000 best since 0 steps and 0.0 min

training for 10000 steps ...
  50: loss=1.3392 acc=0.0706 steps/sec=2.34
 100: loss=1.1730 acc=0.0740 steps/sec=2.49
 150: loss=1.1631 acc=0.0755 steps/sec=2.51
 200: loss=1.1598 acc=0.0728 steps/sec=2.50

eval: loss=3.8948 acc=0.0094 b/sec=0.15 time=1.5 min
run:  log/arithmetic__add_sub_multiple/tp-transformer/lr=0.0001_bs=256_h=512_f=2048_nl=6_nh=8_d=0.0_Adam_/195932581
best: loss=3.8948 acc=0.0094 best since 0 steps and 0.5 min

 250: loss=1.1530 acc=0.0729 steps/sec=0.94
 300: loss=1.1450 acc=0.0758 steps/sec=2.56
 350: loss=1.1446 acc=0.0745 steps/sec=2.44
 400: loss=1.1416 acc=0.0771 steps/sec=2.54

eval: loss=4.2658 acc=0.0116 b/sec=0.16 time=3.4 min
run:  log/arithmetic__add_sub_multiple/tp-transformer/lr=0.0001_bs=256_h=512_f=2048_nl=6_nh=8_d=0.0_Adam_/195932581
best: loss=3.8948 acc=0.0094 best since 200 steps and 1.9 min

 450: loss=1.1411 acc=0.0737 steps/sec=1.83
 500: loss=1.1396 acc=0.0781 steps/sec=2.51
 550: loss=1.1378 acc=0.0734 steps/sec=2.49
 600: loss=1.1372 acc=0.0767 steps/sec=2.53

eval: loss=4.3701 acc=0.0120 b/sec=0.15 time=4.8 min
run:  log/arithmetic__add_sub_multiple/tp-transformer/lr=0.0001_bs=256_h=512_f=2048_nl=6_nh=8_d=0.0_Adam_/195932581
best: loss=3.8948 acc=0.0094 best since 400 steps and 3.3 min

 650: loss=1.1337 acc=0.0725 steps/sec=1.92
 700: loss=1.1340 acc=0.0753 steps/sec=2.46
 750: loss=1.1346 acc=0.0789 steps/sec=2.53
 800: loss=1.1344 acc=0.0780 steps/sec=2.51

eval: loss=4.3407 acc=0.0112 b/sec=0.15 time=6.2 min
run:  log/arithmetic__add_sub_multiple/tp-transformer/lr=0.0001_bs=256_h=512_f=2048_nl=6_nh=8_d=0.0_Adam_/195932581
best: loss=3.8948 acc=0.0094 best since 600 steps and 4.8 min

 850: loss=1.1386 acc=0.0759 steps/sec=1.93
 900: loss=1.1298 acc=0.0775 steps/sec=2.51
 950: loss=1.1329 acc=0.0785 steps/sec=2.51
1000: loss=1.1335 acc=0.0754 steps/sec=2.51

eval: loss=4.2900 acc=0.0119 b/sec=0.15 time=7.7 min
run:  log/arithmetic__add_sub_multiple/tp-transformer/lr=0.0001_bs=256_h=512_f=2048_nl=6_nh=8_d=0.0_Adam_/195932581
best: loss=3.8948 acc=0.0094 best since 800 steps and 6.2 min

1050: loss=1.1347 acc=0.0786 steps/sec=1.92
1100: loss=1.1278 acc=0.0791 steps/sec=2.51
1150: loss=1.1296 acc=0.0782 steps/sec=2.53
1200: loss=1.1326 acc=0.0767 steps/sec=2.52

eval: loss=4.9544 acc=0.0104 b/sec=0.15 time=9.1 min
run:  log/arithmetic__add_sub_multiple/tp-transformer/lr=0.0001_bs=256_h=512_f=2048_nl=6_nh=8_d=0.0_Adam_/195932581
best: loss=3.8948 acc=0.0094 best since 1000 steps and 7.6 min

1000 steps without improvement. Exiting.

Hi yangky11,
Note the train.sh file with the hyper-parameters used during training. Especially the --full_loader argument is important. We have done all experiments with the full_loader argument. The dynamic loader was added at a later stage for convenience but since then we noticed an issue with it, i.e. the dynamic loader seems to be not working quite as expected. Unfortunately, I'm currently busy with other projects and don't have time to debug the dynamic loader. For now, please just use the full loader as we did.  Same for arithmetic__add_or_sub.
If you could use the command in the train.sh file and change the module name to the one of your interest then training should work just fine. If I recall correctly, the module "numbers__place_value" is fairly simple should achieve 100% accuracy very quickly.
And finally, I'd like to point out that we trained on all modules simultaneously. This can be achieved if you train on the module "all_modules". However, this will require a lot of RAM memory to load the dataset at the beginning (this took about 20min). If you are only interested in individual tasks or a subset of tasks, then you can likely profit from a smaller model. For this, I'd recommend trying a smaller h and/or fewer layers.
Imanol

I'll try it out. Thanks!
Also, should I use the same hyperparameters for the transformer baseline (not tp-transformer)?

Yes, absolutely.


Step 3 stops running and audio not working

I'm trying to produce a collection of hi-res mp4s which requires me to use batching. Two issues:

After the DNA is created for all editions in Step2, Step3 is started and suddenly quits. I received the following error:
     make[1]: Leaving directory '.../animated-art-engine-main'
     Starting step 3: Converting sprite sheets to mp4
     Starting 0 with should_generate_output flag False
     multiprocessing.pool.RemoteTraceback:
     """
       File "...\AppData\Local\Programs\Python\Python310\lib\multiprocessing\pool.py", line 125, in worker
         result = (True, func(*args, **kwds))
       File "...\AppData\Local\Programs\Python\Python310\lib\multiprocessing\pool.py", line 51, in starmapstar
         return list(itertools.starmap(args[0], args[1]))
     TypeError: generate_output() missing 1 required positional argument: 'temp_img_folder'
     """

     The above exception was the direct cause of the following exception:

     Traceback (most recent call last):
       File "...\animated-art-engine-main\batch.py", line 65, in <module>
         main()
       File "...\animated-art-engine-main\batch.py", line 58, in main
         step3_main(
       File "...\animated-art-engine-main\step3_generative_sheet_to_output\build.py", line 384, in main
         pool.starmap(
       File "...\AppData\Local\Programs\Python\Python310\lib\multiprocessing\pool.py", line 375, in starmap
         return self._map_async(func, iterable, starmapstar, chunksize).get()
       File "...\AppData\Local\Programs\Python\Python310\lib\multiprocessing\pool.py", line 774, in get
         raise self._value
     TypeError: generate_output() missing 1 required positional argument: 'temp_img_folder'
     make: *** [Makefile:40: all_batch] Error 1

I tried adding a different wav file in each of my background folders. I even changed the folder in the global config to the layers_audio folder and did not hear any audio played from the exported file. I wonder if this has anything to do with batching.

Appreciate all the hard work that goes into this. Cheers

Hi @punchingpandas thank you for calling this out! Super weird, are you on the latest version of the code? Can you copy and paste what the code is on line 349 in step3/build.py
It should say:
                generate_output(
                    filename,
                    batch_number,
                    should_generate_output,
                    output_directory,
                    is_resize,
                    output_width,
                    output_height,
                    get_temp_directory(filename),
                )
                ```

This is what shows up at 349:
   if use_batches:
          print(
              f"Starting {batch_number} with should_generate_output flag {should_generate_output}"
          )

What does your global_json look like @punchingpandas ? Also can you add a print statement right above line 391
and print out get_temp_directory(filename), right above line generate_output?

Here's my global config:
  {
    "totalSupply": 500,
    "height": 1280,
    "width": 1280,
    "framesPerSecond": 100,
    "numberOfFrames": 100,
    "saveIndividualFrames": true,
    "description": "Your description here",
    "baseUri": "ipfs://NewUriToReplace",
    "startIndex": 0,
    "quality": 100,
    "layersFolder": "layers",
    "gifTool": "gifski",
    "mp4Tool": "ffmpeg",
    "outputType": "mp4",
    "loopGif": true,
    "numLoopMP4": 0,
    "debug": false,
    "useBatches": true,
    "numFramesPerBatch": 25,
    "useMultiprocessing": true,
    "processorCount": 6,
    "useFileNumbering": true,
    "enableAudio": false,
    "generateThumbnail": false,
    "thumbnailHeight": 350,
    "thumbnailWidth": 350,
    "thumbnailUri": "ipfs://ThumbnailUriToReplace"

}
I ran the file again with the print command, but only received this on the output:
Traceback (most recent call last):
  File "...\AppData\Local\Programs\Python\Python310\lib\multiprocessing\pool.py", line 125, in worker
    result = (True, func(*args, **kwds))
  File "...\AppData\Local\Programs\Python\Python310\lib\multiprocessing\pool.py", line 51, in starmapstar
    return list(itertools.starmap(args[0], args[1]))
TypeError: generate_output() missing 1 required positional argument: 'temp_img_folder'

I had the same issue. I SOLVED it by switching "useMultiprocessing" to FALSE.
Hope it works out for you.

Hi @punchingpandas @jehuty27 looks like there's a bug with multiprocessing true, let me investigate

@punchingpandas @jehuty27 this is now fixed on main please get latest code

https://github.com/jalagar/animated-art-engine/commit/4de6e5cf8737335e721ef249668430f6f71332d2 here's the commit

Thanks for working on the fix.
Ran several sets and they finished; but only 13 were exported. I ended up turning off multiprocessing and it ran fine. Also, it didn't look like the batching was compiled correctly as there are jumps in the animation. I'll try to run a debug=true and post my results later.

Hmm did you download the latest code? Multiprocessing should work

I just click on the green "Code" dropdown and download the zip. I'm new to programming, so this probably isn't the best way to update the files? I did check the commit, and it seems like the files had been updated.

Hmm very strange, multiprocessing is working for me now. Maybe take a look at the youtube video again, see if you're missing anything. lmk what debug set to true does too


Average multiple samples and keep ADC at highest possible speed to keep same total rate

Could use the CircularBuffer library to store the raw values, then calculate an average at set intervals. Let's see how many raw values we need to store. Running the ADC at max speed:
CPU clock = 84 MHz
ADC clock divider = 2
-> ADC clock = 84/2 = 42 MHz
ADC resolution: 10 bit
ADC readout cycles: 3
-> ADC sampling rate: 42 / (10+3) = 3.23 MHz
The max data rate of 4.6 Mbps corresponds to 287 KHz at 16b / sensor value and 8 sensors. We would then need to average ceil(3.23 MHz / 287 KHz) = 12 samples.
To always keep the same per-sensor readout speed, we could average more samples if fewer sensors are active. The minimum is 2 active sensors, for which we then need to average 46 samples.

Simply making an array of 6 samples and doing the average does result in the expected rate of 4.3 Mbps, but only when not actually sending the data. With sending enabled, it drops to 2.1 Mbps. Perhaps it would work better to continuously accumulate data and run a timer connected to an interrupt to calculate the average and send the data. Then we wouldn't lose any samples to the overhead of sending data.


Fix: Persistence layer creates zero-length initial shards file

I was running into an issue when running hermit in several different environments (docker on Win10, docker on Ubuntu, Ubuntu, PyCharm on Ubuntu): hermit was not initializing the shards_file properly (with empty bson) and the UI was choking on it.  Turns out that the persistence layer command was resulting in an empty initial file being created, and the existing code didn't catch it because it was only checking for the existence of the file.

Codecov Report

Merging #32 into master will not change coverage by %.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##           master      #32   +/-   ##
=======================================
  Coverage   57.83%   57.83%
=======================================
  Files          25       25
  Lines        1238     1238
  Branches      168      168
=======================================
  Hits          716      716
  Misses        504      504
  Partials       18       18

Impacted Files
Coverage Δ

hermit/shards/shard_set.py
58.53% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e02011c...ae7ed73. Read the comment docs.


Prefix is too long

Describe the bug
After finding out that you created your Skada Revisited for Cata as well, I immediately downloaded it and everything ran fine as far as I could see. I saw minor LUA errors which I decided to ignore, because nothing seemed to be broken. Though after some time I realized that some of my WeakAuras stopped working (correctly).
I deactivated all AddOns despite BugSack: No Errors
I activated only Skada + BugSack: Same LUA Errors as pasted below
Skada + BugSack + WeakAuras: Same LUA Errors
Error Log

4x Prefix is too long
<in C code>
<in C code>
Libraries\Ace3\16AceComm-3.0-12\ChatThrottleLib-24.nil.lua:310: in function "Despool"
Libraries\Ace3\16AceComm-3.0-12\ChatThrottleLib-24.nil.lua:378: in function <Libraries\Ace3\AceComm-3.0\ChatThrottleLib.lua:335>

Locals:
(*temporary) = "LibGroupTalents-1.0"
(*temporary) = "HELLO 65"
(*temporary) = "PARTY"
 = <func> =[C]:-1
 = <func> @BugSack\Libs\AceComm-3.0\ChatThrottleLib.lua:216

Hello @Aemrodd .. Try without BugSack and with Skada only, the issue appears to be caused by ChatThrottleLib-v24, also, the error is vague and doesn't help.

@bkader,
https://wowwiki-archive.fandom.com/wiki/API_SendAddonMessage
prefix
    String - Message prefix, can be used as your addon identifier. (16 Character Limit)

https://github.com/bkader/Skada-Cata/blob/main/Skada/Libs/LibCompat-1.0/Libs/LibGroupTalents-1.0/LibGroupTalents-1.0.lua#L1341
This line is causing an error. When calling SendAddonMessage, the prefix is the second argument - MAJOR.
MAJOR is declared at the beginning of the library and it has the value LibGroupTalents-1.0:
https://github.com/bkader/Skada-Cata/blob/main/Skada/Libs/LibCompat-1.0/Libs/LibGroupTalents-1.0/LibGroupTalents-1.0.lua#L69
The number of characters is clearly more than 16. To fix the error, you need to change the prefix. For example, set it as LibGroupTalents


Question: Mon persistence

I have ceph up and running in kubernetes ( THANK YOU ).
I see the warning says: "This example does not survive Kubernetes cluster restart! The Monitors need persistent storage. This is not covered here."
I have set the osd's using durable storage on each's host machine ( daemonset ). Do I also need to set the mon's (also daemonset) to use host machine mount point? If so what directory(s).
Are those the only 2 services that require data to persist restarts?
Thanks again for your hard work on this project. Cheers!

Yes this is the only 2 services that need persistent storage to survive restart. Have you looked at our k8s examples?

@leseb But there is an issue with the mon persistence when all mon pods are deleted at the same time.
The data is gone as the data is saved in a directory named $CLUSTER_NAME-$MON_NAME and the MON_NAME (/hostname) changes on every pod "recreation" when the hostname changes and you can't use the same MON_NAME for all the mons in the cluster.
I personally think that this is related to this questions as it is an issue/question for/about the persistence.
Is there a workaround for the Ceph mon data "loss" on recreate issue?

@leseb Yes, I used the kubernetes example to get my cluster up and running. However,
The Mon dp/ds does not have a volume mount:

https://github.com/ceph/ceph-docker/blob/master/examples/kubernetes/ceph-mon-v1-ds.yaml

The Osd does have a volume mount, which I changed to be a host mount:

https://github.com/ceph/ceph-docker/blob/master/examples/kubernetes/ceph-osd-v1-ds.yaml#L39

So if the Mon dp/ds needs to write to a directory, it's not clear where to mount the host directory.

@galexrt If you lose everything at once then you have a big problem. I don't think we have any workaround if you loose all the monitors. What we could do is to connect k8s to an external storage entity, maybe another Ceph cluster that can provide PVC to the containers.

@leseb The fix for that maybe to use a fixed data directory and not a data directory named after $CLUSTER_NAME-$HOSTNAME, as seen in my submitted PR #492

@leseb I put the monitors on specified hosts, so I just need to know the root directory to mount and it should be there on any reboots.

@galexrt Your PR makes a lot of sense and would fix this issue.

LGTM, let's wait for the CI, even if I guess it's broken for now..

For documentation:
To persist the OSD data mount /var/lib/ceph/osd to your host.
For persistent Mon data mount /var/lib/ceph/mon to your host.
@qrpike

@leseb When will the docker image contain these changes?
Thanks,

Although specifying a specific directory as done in #492 is a workaround, the best thing would probably be to use a Kubernetes StatefulSet. That way the monitor hostnames are predictable and do not change while having persistent storage attached to it.

@qrpike I'll push the new images today.

@leseb you da man!

@qrpike New images available!


Execute Brave Chain if the cards required are there.

Preparation

[X] No one has asked for this feature before in other issues (even the closed ones)

Describe the feature
Is it possible to add a "Brave Chain if possible" checkbox in the card priority menu? For example,
my servant priority Ibuki Summer > Castoria > Tamano
If any of the servants have 3 or 4 of their cards in the 5 card deck, initiate their brave chain even if other priority servant cards are present. Of course, if possible this should follow the WB, WQ and WA order.
Servant Priority doesn't work here, I'm pretty sure

i decided to forget about this enhancement


Changing the benchmarkRepoRemoteUrl requires a restart of the Runner

At least I think that is what I was observing. I got strange setup errors:
#############
## General ##
#############
Runner name:     i44pc31
Hash:            4f55f2c49316d7f318a42dea0c24fc6eb32fe13e
System:          Linux amd64 4.15.0-117-generic
CPU:             Intel(R) Core(TM) i5-8500 CPU @ 3.00GHz (6 threads)
Memory:          15785 MiB total, 14906 MiB available
Java version:    11.0.11 by Ubuntu
User:            velcom
Bench repo hash: 658df3afff5833772e2d52deea2b9cc592635be5

#################
## Setup error ##
#################
`bench` script not found or not readable

I monitored the what the runner did and realised that it never saved a bench_repo. Quite strange.
I haven't taken the time yet to determine whether the issue really is reproducible.

If I remember correctly, the runner stores the current bench repo hash but not its remote url. However, changing the repo should also change the hash (unless it has the same contents), so I don't know what's happening here.
I assume you checked whether the bench repo has an executable bench script at hash 658df3afff5833772e2d52deea2b9cc592635be5.

Just to clarify some more: After changing the backend config file, the backend always needs to be restarted. The "Refetch all repos" button on the queue page is not enough in this case.

I assume you checked whether the bench repo has an executable bench script at hash 658df3afff5833772e2d52deea2b9cc592635be5.

Yes, I checked it. Indeed it was the same as e.g. the has from http://speedcenter.informatik.kit.edu/velcom/run-detail/87215517-c461-4baf-92c1-30d0010cb890, which checks out (I tried using the same bench repo for testing reasons).
Meanwhile I've switched and updated the bench repo multiple times without restarting the runner, so it appears it was a fluke. Closing as invalid.
Thanks for holding my hand, though!


chore(synapse): version upgrade from 0.3.28-SNAPSHOT to 0.3.29-SNAPSHOT.

Description
Synapse version upgrade
Change made in this pull request
Version upgrade to 0.3.29-SNAPSHOT

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.ffgutt seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


Add tests for pyodbc

Overview
Add tests for pyodbc.
Related Github Issue
Implement testing for pyodbc

Codecov Report

Merging #796 (7496f1d) into main (4d644c6) will decrease coverage by 2.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #796      +/-   ##
==========================================
- Coverage   64.40%   62.38%   -2.03%
==========================================
  Files         256      256
  Lines       26368    26368
  Branches     4492     4492
==========================================
- Hits        16983    16449     -534
- Misses       8222     8742     +520
- Partials     1163     1177      +14

see 28 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Added columns for AdventureWorks

Hi, I added some new column types used in AdventureWorks.

Thank you for your contribution.


Add narrowing by is:unread

I think one reasonable way of reading through zulip messages could be to narrow to various topics (e.g. the topic your cursor is currently on), reading the messages of the topic or otherwise marking the whole topic as read, and then going back to a home view where you see only unread messages. This especially makes sense if a large fraction of your messages are from bots (e.g. git commit messages), or high traffic social lists.
Currently we don't have a way to narrow to unread messages; adding is:unread functionality to search and a keyboard shortcut (maybe u?) would be great.

@zulipbot claim


Finish/test Implementation of new Thought Harvester

https://ptr.wowhead.com/spell=288343/thought-harvester
Vampiric Touch damage is increased by 0, and each time Vampiric Touch deals damage you have a chance to increase the damage of your next Mind Sear within 20 sec by 300%.
ACs:

[ ] Module work complete
[ ] Add Mind Sear to APL with X traits

might need to fix this: https://github.com/simulationcraft/simc/blob/bfa-dev/engine/class_modules/priest/sc_priest_shadow.cpp#L1739

PR does most of this work https://github.com/simulationcraft/simc/pull/4605#partial-pull-merging

Need to remove the modifications for chain=1 from the apl now that the bug is fixed


Babel incorrectly names dependencies that have a trailing !

When a resource is loaded via trailing ! plugin syntax, the module uses a mapped name, and dependencies use the name as is. Trailing ! syntax is the only way to get the systemjs-hot-reloader to detect changes in files imported with plugins.

Can you clarify the exact issue here a little? Are you saying that you are using resource.x! plugin syntax through systemjs-hot-reloader to get plugin hot reloading support, but then Babel will incorrectly name them in bundles breaking the build?
What name is Babel outputting? Adjusting the normalization is unfortunately not the fix though as the name should remain unnormalized as-is for normal (non normalizing) bundling.

If you bundle 2 files [a.js, b.txt!], and a references b, the register statements look like:
System.register('a.js', ['b.txt!'] ... )
System.register("b.txt!text.js" ... )

so when you load a, it tries to find b externally

The reason for this is that bundles don't include normalization. It's badly documented yes, but bundles are supposed to be added after including the original configuration. Bundles are only a file-level multiplexing and do not build in linking information.

That makes sense, buildStatic covers what I actually needed for this use case.


Why is not a three-dimensional image generated?

After the configuration of the environment is completed, after the input of a two-dimensional image, the generation is not a three-dimensional image. Why?

The output is a .raw file. uint8, 192x192x200, ordered row, column, depth. It is a 3D image.


Factor pi missing in compute_cheby_coeff

It looks like a factor of pi is missing in the numerical integration in https://github.com/epfl-lts2/pygsp/blob/d78095438a14a74d2195d4600fc00f8f1115005f/pygsp/filters/approximations.py#L52 compared Eq 8 https://arxiv.org/pdf/1105.1891.pdf throwing off the Chebyshev coefficients by a factor of pi.

Hi thanks for reporting that.
@mdeff , do you know if this is intentional or a mistake. I have the feeling we knew about that... If it is intentional, we should document it.

Indeed, we use 2/n as a factor instead of 2/pi. As for #74, the definition of the coefficients came from the matlab implementation. I believe that is intentional and correct, as the integration over pi is approximated by a summation over n evaluation points. Do you agree @nperraud?
In my overhaul of the Chebyshev approximation (in the polynomial-approximations branch), I used 2/n and documented the definition. I could add that the summation is an approximation of the integral.


listLoadingWidget not working

Hi there, listloadingwidget is not showing up, even though the value of loading is true. please help.
 FlatList(
        loading: true,
        data: users.value,
        listLoadingWidget: const Center(child: CircularProgressIndicator()),
        buildItem: (item, index) {
          return Text(item['name'].toString());
        },
);

@sudheersuri Could you kindly check examples like https://github.com/hyochan/flat_list/blob/main/example/lib/screens/flat_list_ex1.dart and see the differences?
Below is current working example.


Query will fail when set calcite.debug=true

Query will failed when set calcite.debug=true

@Smallhi Hi, would you like submit a pr to fix?

@nichunen  I'm doing it.


Omit the string 'SUCCESS' from exceptions

For example:
>>> mc.set("key with spaces", "value")
Traceback (most recent call last):
  File "<console>", line 1, in <module>
SocketCreateError: error 11 from memcached_set: SUCCESS

Including the word "success" in an exception is a bit counter-intuitive. I'm presuming the string SUCCESS comes from the memcached response, in that the request to the server was successful, but had an error code attached.
Ideally this would read:
SocketCreateError: error 11 from memcached_set

Or:
SocketCreateError: error 11 from memcached_set: <something useful>

Similarly, when I was trying to repro another issues, with:
mc.set("key with spaces", "value", 300)
mc.flush_all()
mc.set("key1", "foo", -1)
mc.get("key1")
mc.set("key2", "bar", -1)
mc.flush_all()

I get:
SocketCreateError: error 11 from memcached_set: SUCCESS
SomeErrors: error 19 from flush_all: SUCCESS
Error: error 21 from memcached_set: SUCCESS

All of these cases should omit "SUCCESS" too, and if possible also have more specific exception types.

Many thanks :-)


ci(test workflow): replaced github secrets with github variables

:tada: This PR is included in version 3.5.6 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Link supplier login to /suppliers

Before
After

Click log in
Click log in

Enter credentials
Enter credentials

See dashboard
See dashboard

Go back to homepage
Go back to homepage

Click log in
Click log in

Reenter credentials
See dashboard

See dashboard
:+1:

Nice spot.


Create bus data frame from HIFLD line and substation data

:rocket:

[x] Is your feature request essential for your project?

Describe the workflow you want to enable
Using data frames of lines and substations, create a table of known buses.
Describe your proposed implementation

Inputs: data frame of lines and substations, where each line is mapped to two substations (arbitrarily designated 'start' and 'end' substations).
Determine a voltage for each line:

Preferred option: use the VOLTAGE attribute of the lines data frame, which covers ~82% of lines (11,856 missing out of 67,389 total, when starting with the filtering from #203. This set is used in all other calculations in this post, and it's assumed that the results are broadly similar as without largest-island filtering).
Alternate options in no particular order (may use one or several in series/combination):

Use the VOLT_CLASS attribute of the lines data frame. E.g. of the missing voltages, 3,431 are in the "UNDER 100" class, of which almost 90% of labelled voltages are 69 kV, and another 7% or so are 60 or 66 kV, so we can probably use 69 kV as a reasonable guess for these. The next biggest chunk of voltage classes are "100-161", which is more evenly split between 115 kV, 138 kV, and 161 kV.
Use substation information of endpoint(s). E.g. 22% of substations are explicitly labelled as MIN_VOLT == MAX_VOLT == 69 kV, 19% are explicitly 115 kV only, 10% are 138 kV only, 4.8% are 161 kV only, 3.6% are 230 kV only, etc. Some of these have ranges, but those ranges could help narrow down the range of voltage classes of connected lines (e.g. a range of 69-138 kV can tell us that the connected 100-161 line isn't 161 kV, etc.)
Use regional information (e.g. within the 100-161 range, 161 kV is most common in IA/MO/AR/KY/TN/MS, 138 kV is most common in ERCOT and the Great Lakes region, most other areas are 115 kV)
Use information about neighboring lines.
Etc.

For each line voltage connected to a substation, create a bus.
Output: bus data frame (containing at minimum an index and a baseKV column) and bus2sub mapping (each bus is mapped to a substation from the inputs).

Closed via #210.


add ContainerResource source type for ehpa prediction

What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:

@qmhu PTAL, thanks


Create a more diverse and representative set of sample data for tests

We're using duplicate names and URLs for certain objects.

[ ] Conform the formats of the sample data to real-world data we're receiving from various sources
[ ] Create any types of data that aren't currently available for testing
[ ] Make the sample data more diverse (every project has a different name and a different url, etc.)

Pull request #176 helps a lot with this one.

This is lower priority since #176, so I moved it to backlog for the time being.


&rest arguments in prerequisites

It would be useful to say "I don't care about the rest of the arguments."  Perhaps this:
(fact
  (f 1) => 2
  (provided
    (bar 1 (as-checker even?) anything...) => 8))

I'm also thinking that it'd be nice to have some sort of argument-checker that would apply to the &rest of the arguments. Like:
(fact (bar 3) => 8
  (provided
    (foo (rest-match #(map even? %&))) => 3))

My hunch, though, is that the latter isn't worth much effort. (However, it might easily fall out of the anything... case.)

Or...?
(fact (bar 3) => 8
  (provided
    (foo (something... #(map even? %&))) => 3))

And it probably makes more sense for the function that something... takes to take a single sequence arg (instead of a &rest arg).

I think something like this is a great idea, but before I comment too deeply I need to think about it more (I have been mostly thinking about formulas these days)


[WIP] options: use new Path class for path option

Add a Path class for use with user options. (closes #2198)
Signed-off-by: Nikos Filippakis<EMAIL_ADDRESS>

Hi @nikofil - thanks for working on this. Let's ponder the approach here a bit. I would prefer not to have a fat Path object of our own - if we can get away with something lighter weight, we should.
I see @mhils suggests we use pathlib.Path. It's slightly more than a simple type, in the sense that it instantiates different concrete types depending on the platform we're on. We need to do some analysis to see if there are hidden traps, but if there aren't, this might be a good option.
Another possibility is to simply declare Path as an alias for str with the typing module. That means we can keep the semantics almost identical to what they are now, just with a narrower type spec that will let us treat things specially in the UIs.

Thank you for the feedback.
pathlib.Path can indeed be used nicely in the place of str for paths, I managed to get mitmproxy running with it rather quickly. However there is a lot of searching and replacing involved and I am a bit worried about changing that many lines, so hopefully the tests will catch any errors that I don't.
I will continue in this direction then and ask you again if I get stuck somewhere.

I do like @cortesi's aliasing proposal as well. Please go for whatever you feel is more appropriate! 😃


Faster check for zero-tensors

The current code loops through the whole tensor and counts all non-zero values. Looping and counting is slow.
We can instead call any() which returns True as soon as it finds the first non-zero value, it's much faster, saving some initialization time.
https://pytorch.org/docs/stable/generated/torch.any.html#torch.any
I have validated its behavior with Torch's CUDA backend (on "2.3.1+cu118"):
>>> import torch
>>> x = torch.tensor([0.0, -0.5, 1.2, 50.3])
>>> y = torch.tensor([0.0, 0.0, 0.0, 0.0])
>>> z = torch.tensor([999.0, -0.5, 1.2, 50.3])
>>> x.any()
tensor(True)
>>> y.any()
tensor(False)
>>> z.any()
tensor(True)
>>> nearzero = torch.tensor([-0.1, 0.05, 0.3])
>>> nearzero.any()
tensor(True)
>>> practicallyzero = torch.tensor([0.00000000000001, 0.0, 0.0])
>>> practicallyzero.any()
tensor(True)

So any() immediately returns True if any of the tensor values are non-zero/non-False. It only returns False if all values are zero/False. That's what we want. A fast check for non-zero tensors. We have no reason to count every value. :)
Edit: Have also verified in real LoRA training now. This check accurately and quickly detects the empty tensors. So it's safe to merge.

Thanks for submitting the PR! The change makes perfect sense to me, though I'm not sure how much faster .any() would be in practice. Did you see a noticable difference in performance in some setting?


Fix jupyter notebook

"As you can see from the result, the clean and dirty auxiliary tests are failed because they are outside of the DAG path.\n",

this needs changing

ohh i didn't get pushed. now it is done


Nexylan namespace move (used by slack-bundle)

FYI, we move a copy of this abandoned library under the Nexylan namespace: https://github.com/nexylan/slack
The 1.x branch is not touched, with same code and release so the migration will be smooth.
The unreleased change of this library plus other ones are under the v2.0.0.
The nexylan/slack-bundle now require this package and the v2.0 release support is in progress.
Ref: https://twitter.com/soullivaneuh/status/953671333279354880
@maknz I let you update the README to add the reference if you want to.
Regards.

@Soullivaneuh in your fork you've removed the original license. Please re-read LICENSE.md in this project to understand your obligations by reproducing. Thanks.

Hi @maknz,
The LICENCE was changed on a new major version as it was done on other project like swiftmailer. The older one was untouched.
What is missing to permit us to use our license and complain with the old one?
Thanks.

Yeah, even though you've got a new major version, that doesn't excuse you from the license which governs the code you forked (even if it's modified). You'll need to change the license back to the one from this repo.

@Gummibeer https://github.com/swiftmailer/swiftmailer/blob/5adaf8247f6fc219378fa2df1e6d9e4eee2d221d/CHANGES#L192-L195
As you can see, it's not the same appliance fore everyone. Here, this was changed without this kind of issue and the new major was especially for it. It's the model I did follow.
Still, I understand your PoV and no, I'm not a licence changing expert.
But what is the limit @Gummibeer? What about new php file for example, or even complete rewrite of the main logic of the code? If I don't want to release the changes under this licence, what are my options?
So I would like to open an issue on my repo to ask contributors about the licence change if I don't get a consensus, I'll revert the change OFC. But before that, @maknz would ou accept the MIT change? If no, I assume I don't have to loose time making an issue of this kind.

The current license clearly says:

Redistributions of source code must retain the above copyright notice, this list of conditions and the following disclaimer.

So @maknz has to allow a license change at all. After this: every line of code has a Copyright owner (contributor) and a license under it was pushed.
To change the license for existing code you need the allowance of the package maintainer, in this case, and the contributors.
There is one limitation: you don't need the allowance of a contributor who just changed a typo or added a "no other way"/"this is the way how to do" feature. Code itself isn't protected if there is no unique idea behind it. This is a pretty not lawyer conclusion
And even after everyone allowed you to change it you have to link to this repo and that you've used it as the base.

@Soullivaneuh I'm personally not averse to MIT and I don't want to discourage people from improving on the original work. However, getting permission from contributors to change the license is probably in the too-hard basket.
Is there a particular reason you want MIT over BSD-2? According to Github's license helpers, there are only "minute differences" between MIT and BSD-2. The easiest solution here would be to re-instate the original license and copyright notice from this repository, and then add your own for your new work as maintainer.

Is there a particular reason you want MIT over BSD-2?

Nothing expect the ease of maintenance. I have a plan to make common file update and dispatch easier, including the licence file.
If you are not against, I'll open an issue on my project. There is not so many contributors, maybe I'll be able to have a quite quick return.

@maknz Sorry for the delay, but the issue is here: https://github.com/nexylan/slack/issues/41
Thanks for your patience.

@maknz I still need your agreement. :-)
Also, the other not responding people seems to not be active anymore. What should I do about this?

@maknz Since the new licence is accepted, would you consider README.md update?
Thanks!


Update Session#writeAndFlushHeaders to also be able to give an HTTP response code.

Instead of only being able to give an object with headers, the Session#writeAndFlushHeaders method should also take an HTTP response code to send so as to let the implementation send an HTTP 204 No Content response to indicate to the client that they should stop reconnecting, as per the spec.

Hey, I have worked out a possible solution to this but I am unable to get my code running with an express application. How exactly do I do that?

Hey, I have worked out a possible solution to this but I am unable to get my code running with an express application. How exactly do I do that?

Thanks so much for wanting to contirbute!

Hey, I have worked out a possible solution to this but I am unable to get my code running with an express application. How exactly do I do that?

I have now added an examples/ directory that has an example of a basic setup using the package (essentially a full demo of the 'Getting Started' section from the docs).
To run, you can simply enter the directory (examples/getting-started/), install the dependencies (yarn) and start in development mode (yarn run dev).
If you want to work on the module itself whilst using the demo, do following from the project root:

yarn - Install dependencies.
yarn run typedefs && yarn run dev - Output type declarations and start in development mode to watch for changes and automatically rebuild.
cd examples/getting-started - (In another terminal) Move into the example project directory.
yarn - Install demo dependencies.
yarn run dev - Run in development mode to also watch for changes and re-run.
import sse from "better-sse"; -> import sse from "../.."; in server.ts to use your local module instead of the one up on npm.

I think the implementation of this feature should mimic that of the Express/HTTP API as that's what most users would be used to:
Session#writeAndFlushHeaders(statusCode, headers)

Thanks so much for wanting to contirbute!

Hey, I have worked out a possible solution to this but I am unable to get my code running with an express application. How exactly do I do that?

I have now added an examples/ directory that has an example of a basic setup using the package (essentially a full demo of the 'Getting Started' section from the docs).
To run, you can simply enter the directory (examples/getting-started/), install the dependencies (yarn) and start in development mode (yarn run dev).
If you want to work on the module itself whilst using the demo, do following from the project root:

yarn - Install dependencies.
yarn run typedefs && yarn run dev - Output type declarations and start in development mode to watch for changes and automatically rebuild.
cd examples/getting-started - (In another terminal) Move into the example project directory.
yarn - Install demo dependencies.
yarn run dev - Run in development mode to also watch for changes and re-run.
import sse from "better-sse"; -> import sse from "../.."; in server.ts to use your local module instead of the one up on npm.

I think the implementation of this feature should mimic that of the Express/HTTP API as that's what most users would be used to:
Session#writeAndFlushHeaders(statusCode, headers)

Thank you for the detailed explanation. I'll get it working and raise a PR.
I've also implemented the streaming functionality. Will test that as well.

Thank you for the detailed explanation. I'll get it working and raise a PR.
I've also implemented the streaming functionality. Will test that as well.


Giving Screen control  while screen share

Please provide us with the following information:

This issue is for a: (mark with an x)
- [ ] bug report -> please search issues before submitting
- [x] feature request
- [ ] documentation issue or request
- [ ] regression (a behavior that used to work and stopped in a new release)

Minimal steps to reproduce

Any log messages given by the failure

Expected/desired behavior

OS and Version?

Windows 7, 8 or 10. Linux (which distribution). macOS (Yosemite? El Capitan? Sierra?)

Versions

Mention any other details that might be useful

Thanks! We'll be in touch soon.

Hi @TapanKumarBarik thanks for the feature request! Unfortunately the ACS SDK does not support this feature today so we cannot bring it to the sample apps. I do encourage you however to file the feature request under Azure/Communication for best visibility and traction: https://github.com/Azure/Communication/issues/new/choose

Hi @TapanKumarBarik thanks for the feature request! Unfortunately the ACS SDK does not support this feature today so we cannot bring it to the sample apps. I do encourage you however to file the feature request under Azure/Communication for best visibility and traction: https://github.com/Azure/Communication/issues/new/choose


report saucelabs status correctly

Right now if a test completes saucelabs thinks it succeeded even if the image comparison fail.
It's not an issue because if anything fails CI would fail but it is not ideal

we are a step better but still not showing errors. Current behavior shows failures as unknown status ? instead of green


fix: battery designed capacity on windows

Hi @sebhildebrandt!
I noticed at some point a wrong key name was introduced. API provides designedCapacity and windows fn was adding a designCapacity key. Quite an important fix :)
(I also moved a helper function out of the loop for optimization purposes - we don't need to create it on each iteration.)

@plakak Version 5.7.8 just released. Thank you!


Clean up old timing code

As mentioned in #179 there is some old timing code in various places that has not been replaced by the Snakemake benchmarking option including:

The timing field in the config file
The -t option to the integration scripts
References to -t in Snakefile
Code in the integration scripts that does profiling
(there may be others)

It would be nice if this could be cleaned up to make it clearer what is being used.

@danielStrobl this shouldn't be too hard, right? Maybe something for after revisions though.

Adressing this issue in scib-pipeline https://github.com/theislab/scib-pipeline/pull/36


Allowing FPS to take numpy array of ints as initialize parameter

Hello!
This pull request is my attempt to address issue #145. With these changes, FPS should be able to accept a numpy array of ints as an input. I wrote a few tests as well to ensure the updated code is functioning properly. I'd love to hear any feedback you may have!
Contributor (creator of PR) checklist

[x] Tests updated (for new features and bugfixes)?
[x] Documentation updated (for new features)?
[x] Issue referenced (for PRs that solve an issue)?

For Reviewer

[ ] CHANGELOG updated if important change?

📚 Documentation preview 📚: https://scikit-matter--225.org.readthedocs.build/en/225/

Updated the changelog!


Add latest version of SSH Sampler

This makes the current version of the SSH Sampler plugin available via the Plugins Manager.
Note: I'm not the author of that plugin.

Thanks for helping to maintain this up-to-date!


Create a gh-pages branch

So everyone can see your work on the internet!

closing, hope all is well buddy. :)


atk: clean up

Motivation for this change
Closes: #32296
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

Mikutter fails to build:

Build log
WARNING:  You build with buildroot.
  Build root: /
  Bin dir: /nix/store/84mhf8b2qfmqlvq2ahj9acjpjmr9mkkj-ruby2.3.5-gio2-3.1.9/lib/ruby/gems/2.3.0/bin
  Gem home: /nix/store/84mhf8b2qfmqlvq2ahj9acjpjmr9mkkj-ruby2.3.5-gio2-3.1.9/lib/ruby/gems/2.3.0
Building native extensions.  This could take a while...
WARNING:  You build with buildroot.
  Build root: /
  Bin dir: /nix/store/rlbz8x089s4yrgfrfw60nxwcnb7g33sd-ruby2.3.5-pango-3.1.9/lib/ruby/gems/2.3.0/bin
  Gem home: /nix/store/rlbz8x089s4yrgfrfw60nxwcnb7g33sd-ruby2.3.5-pango-3.1.9/lib/ruby/gems/2.3.0
Building native extensions.  This could take a while...
ERROR:  Error installing /nix/store/h3zk0ldid1acka8wd5abxxa3ppi24pys-gio2-3.1.9.gem:
	ERROR: Failed to build gem native extension.

    current directory: /nix/store/84mhf8b2qfmqlvq2ahj9acjpjmr9mkkj-ruby2.3.5-gio2-3.1.9/lib/ruby/gems/2.3.0/gems/gio2-3.1.9/ext/gio2
/nix/store/fh53an3sv5ra1kb9vp10fy01xjjfx00l-ruby-2.3.5/bin/ruby -r ./siteconf20171213-1104-1hqvzbo.rb extconf.rb
checking for --enable-debug-build option... no
checking for -Wall option to compiler... yes
checking for -Waggregate-return option to compiler... yes
checking for -Wcast-align option to compiler... yes
checking for -Wextra option to compiler... yes
checking for -Wformat=2 option to compiler... yes
checking for -Winit-self option to compiler... yes
checking for -Wlarger-than-65500 option to compiler... yes
checking for -Wmissing-declarations option to compiler... yes
checking for -Wmissing-format-attribute option to compiler... yes
checking for -Wmissing-include-dirs option to compiler... yes
checking for -Wmissing-noreturn option to compiler... yes
checking for -Wmissing-prototypes option to compiler... yes
checking for -Wnested-externs option to compiler... yes
checking for -Wold-style-definition option to compiler... yes
checking for -Wpacked option to compiler... yes
checking for -Wp,-D_FORTIFY_SOURCE=2 option to compiler... yes
checking for -Wpointer-arith option to compiler... yes
checking for -Wswitch-default option to compiler... yes
checking for -Wswitch-enum option to compiler... yes
checking for -Wundef option to compiler... yes
checking for -Wout-of-line-declaration option to compiler... no
checking for -Wunsafe-loop-optimizations option to compiler... yes
checking for -Wwrite-strings option to compiler... yes
checking for Windows... no
checking for gio-2.0... yes
checking for gobject-introspection-1.0... no
*** extconf.rb failed ***
Could not create Makefile due to some reason, probably lack of necessary
libraries and/or headers.  Check the mkmf.log file for more details.  You may
need configuration options.

Provided configuration options:
	--with-opt-dir
	--without-opt-dir
	--with-opt-include
	--without-opt-include=${opt-dir}/include
	--with-opt-lib
	--without-opt-lib=${opt-dir}/lib
	--with-make-prog
	--without-make-prog
	--srcdir=.
	--curdir
	--ruby=/nix/store/fh53an3sv5ra1kb9vp10fy01xjjfx00l-ruby-2.3.5/bin/$(RUBY_BASE_NAME)
	--enable-debug-build
	--disable-debug-build
	--with-pkg-config
	--without-pkg-config
	--with-override-variables
	--without-override-variables

To see why this extension failed to compile, please check the mkmf.log which can be found here:

  /nix/store/84mhf8b2qfmqlvq2ahj9acjpjmr9mkkj-ruby2.3.5-gio2-3.1.9/lib/ruby/gems/2.3.0/extensions/x86_64-linux/2.3.0/gio2-3.1.9/mkmf.log

extconf failed, exit code 1

Gem files will remain installed in /nix/store/84mhf8b2qfmqlvq2ahj9acjpjmr9mkkj-ruby2.3.5-gio2-3.1.9/lib/ruby/gems/2.3.0/gems/gio2-3.1.9 for inspection.
Results logged to /nix/store/84mhf8b2qfmqlvq2ahj9acjpjmr9mkkj-ruby2.3.5-gio2-3.1.9/lib/ruby/gems/2.3.0/extensions/x86_64-linux/2.3.0/gio2-3.1.9/gem_make.out
builder for ‘/nix/store/633imb0w5kc82ls5rvrvvnbz6fwnzpsl-ruby2.3.5-gio2-3.1.9.drv’ failed with exit code 1

Adding gobjectIntrospection to buildInputs is not enough.

For some reason, totem fails to build on hydra, even though it builds fine on my computer.
https://hydra.nixos.org/build/65987618

cc @midchildan for mikutter faiilure https://hydra.nixos.org/build/65972646

@jtojnar I'm going to check, but it might take a few days.

Okay, managed to fix mikutter.

What do you think about enabling it by default?

Here: https://github.com/NixOS/nixpkgs/blob/3366ce99df61132b82e385617c1744dc352a83c2/pkgs/build-support/setup-hooks/multiple-outputs.sh#L150-L159

They are actually for make_gobject_introspection_find_gir_files.

@GrahamcOfBorg eval


Docs - Copy link buttons don't work

Bug Report
Docs - Copy link buttons don't work
Steps
When I click on a link button the tooltip says 'Copied link!'
Expected Result
Link address to be in clipboard
Actual Result
Clipboard remains the same

Thanks for finding this!


Remove misleading type definition

Goal
The type definition for client.notify method implies that several types are acceptable. Which isn't exactly true. When using an Error type client.notify works as expected. When using a string type, the error reported is notify() received a non-error. See "notify()" tab for more detail. while the error details are on the notify tab. This is confusing and does not work as expected.
Design
I removed the NotifiableError type in favor of Error. This is purely a type definition change with no change in functionality.
Changeset
The NotifiableError type was removed in favor of Error.
Testing
I'm having issues building/testing the repo as is. I was able to run the typescript check command with 400+ errors. After my changes, the typescript check did not register any new errors.

Hey @adkenyon, I do agree, an Error object should always be the preference for making a call to Bugsnag.notify(), especially in Promises so that we have a known object getting sent in (https://eslint.org/docs/rules/prefer-promise-reject-errors). However, I don't think this is a PR we'd be looking to accept as in some cases where an Error is not thrown, we still want a notification to be sent, e.g. legacy browsers, packages & code, or even just mistakes where a non-Error is tolerable, even if it's not perfect.
When notify is called, an Event is created:
https://github.com/bugsnag/bugsnag-js/blob/58c0ade57fa1ada78ce3dd912022f3e15b326fc7/packages/core/client.js#L286
When creating the event we make a call to normalize the "error":
https://github.com/bugsnag/bugsnag-js/blob/8bae662a32f939de7371ce542989d2dbed84f03b/packages/core/event.js#L163
https://github.com/bugsnag/bugsnag-js/blob/8bae662a32f939de7371ce542989d2dbed84f03b/packages/core/event.js#L193-L265
If we made the change you're suggesting wouldn't break, but it would limit functionality for anyone using TS.
In your case, where you're seeing notify() received a non-error. See "notify()" tab for more detail., this sounds like a situation where you needed to specify an Error but did not, i.e. this specific message you saw was context specific.

@xander-jones thanks for the quick response!
One point I'd like to convey is the frustration this type definition continues to cause us. Passing an Error type compared to a non-Error type results in two very different results on BugSnag. This last week we shipped an app release that passed a String type to .notify() and the data in BugSnag isn't useful or actionable. We've having to update the code and create another app release. We've effectively wasted our time and lost a week of data. By passing an Error type, the data is much more useful in Bugsnag and actionable. This is something also comes up every few months, a dev thinks that a String type will work as expected when in actuality it doesn't.
I see your point on that this may limit functionality, but I'm not sure the functionality is desired? We've never found it useful or actionable

Hey – thanks for the added context! This has struck up a bit of a discussion internally. Some more thought is needed on how we'd like to proceed on this, so at the moment we won't be accepting the PR directly, but I'll leave this open for future updates on this area.

@xljones no worries! Thanks for considering it and happy to spur some discussion. This is all purely my team's experience and perspective. Understand ya'll have many more customers, perspectives, and tasks.

Hi @adkenyon.  Could you confirm that you simply passed called Bugsnag.notify('some string') and got notify() received a non-error. See "notify()" tab for more detail. as the message?
I've tried to reproduce this and can't.  You should only get that message under certain circumstances like unhandled rejections.


fix: Updated UserResponseDto mapping to include organizations

Description
Change Response signup Login
Changes proposed
What were you told to do?
Tofixtheresponsebodyoftheauthcontroller
What did you do?

Added mapping for Organization to OrganizationDto in UserMappingProfile.
Mapped the list of organizations in UserResponseDto.
Fixed the response body for the signup feature to ensure proper data structure and mappings.

You need to format your code properly. Run
dotnet format Hng.Csharp.Web.sln --no-restore


Could not save new password

I'm using the Postfix version of the password change plugin but getting this error. Anyone run into this and have a fix? I assume some permissions aren't set somewhere. Any help would be appreciated.

DirectAdmin password change also does not work...


Cannot call remove service method when id field name is custom

I'm having some issues with the remove service method.
I've specified a custom id in my model, e.g.,
  app.use('/tags', service({
    id: 'uuid',
    Model: tags
  }));

But when I call the remove method, this is the SQL that runs:
Executing (default): DELETE FROM `tags` WHERE `id` = '9e098ec7-fc13-4478-ab22-68bd4c416637'

And the API returns error message:
ER_BAD_FIELD_ERROR: Unknown column 'id' in 'where clause'

The line looks suspect: https://github.com/feathersjs/feathers-sequelize/blob/master/src/index.js#L143
I think the intended value is this.id, not just id.

You are absolutely correct. Can you submit a PR with the change?
We really need to add custom ids to the service tests.


Multi scene bug in HEADLESS mode

Version

Phaser Version: 3.16.2
Operating system: Windows 8

Description

When running phaser in headless mode and having more than one scene, Phaser throws the error "Cannot read property 'gl' of null" in the prerendering function. It seems to be calling the wrong functions in headless mode when there is more than one scene.
Headless mode is great for running multiplayer games on the server, and I love to split up the game in multiple scenes, so fixing this bug would be greatly appreciated.
Example Test Code

https://codesandbox.io/s/llj8y70l0z
Additional Information

I think it’s not multiple scenes per se but scene destroy, which is calling camera destroy.

I have the same problem right now. FeelsBadMan

Thank you for submitting this issue. We have fixed this and the fix has been pushed to the master branch. It will be part of the next release. If you get time to build and test it for yourself we would appreciate that.


Display lured pokemon

Additional block in updateMap to display lured pokemon. Uses pokestops checkbox to control visibility.

so this will show pokemon from lured pokestops?

can you see any errors in the js console log?

@szeco also the setting isn't remembered by the client so on refresh it unticks itself

Seems to work for me.

just tried this, doesn't work

Works here, keep in mind, lured pokemon only exist for 2 minutes or so then pop back out of existence.

@drsnooker i've scanned multiple locations with 20+ going on at once, i get nothing from this script

@djv2 not sure how to help. Took me awhile to get it working. Something to do with pasting from the raw window... Just hit files changed, view, and raw than save as from your browser. That got it working first (but using an older version of the map.html and map.js (just to see how it works) put a 100 m circle on a lured pokestop and enable all pokemon. Some will show "Lured XXXXXX" with less then 2 minutes remaining.
The newer version of the map.html and map.js have moved things around so make sure you copy the lines from the mod over to the correct location (not what's labelled in this file)

you must add a new button, you cant replace display pokestops with display lured pokemons, cause i need display pokestops button.

Thank you for this, @szeco! I combined your changes with those from #317 this morning in an attempt to get notifications about lured pokemon. At first I wasn't sure it was working -- I didn't see any lured pokemon show up after checking the box. But an hour or so later they started showing up! Awesome.
I hit a snag, though -- the IDs for the lured pokemon appear to be different so while I'm notified that a "Dratini" is near, I receive no notification for a "luredDratini", though it does show up on my map. Do you know what the proper IDs would be for lured pokemon? If Bulbasaur is "1", luredBulbasaur should be..?
Also, would it be possible to get the "View Lured Pokemon" checkbox to remember the choice? When I load up my map I have to ensure it's checked every time, unlike "View Gyms" and "View Pokemon."

Also just to follow up-- it appears that lured Pokemon show up on my map on my android phone, but not on my desktop pc, even after ensuring that the "show lured Pokemon" option is enabled.
Might explain why some people aren't able to see it working. I didn't believe it worked until I checked from my phone. What would cause this issue for the desktop map?

Hi @adamblaine - it's a bit more complicated to merge with #317 as it's a model.py based notification rather than a map.js one. Since lured pokemon data is stored in the pokestops item you could probably replicate the entire pushbullet code block around line 205 using active_pokemon_id.
Another method I've had success with is moving the entire notification piece into map.js by using this: https://github.com/alexschneider/pushbullet-js
Unfortunately I'm not using pogom as my main map any more since most of my smurfs have been banned :(  only have one account now running PokemonGo-Map with spawnpoint scanning in a small area..

Ah okay. I tried messing around  with it but couldn't get anything that would work. I don't have any working knowledge of python or js so I'm just stumbling through trying to get this to work.


fix(resource-resolver): Add pacman support for resource resolver, closes #188

Add support for Pacman Packages in the Resource Resolver.

closes #188

Now, resource resolver can detect Paman format and also load resources for it.

This is a VERY long run on macOS:

Most probably because cache time got expired, so had to rebuild everything. But it is still too much :thinking:


How can I set response header using Route Handlers?

I want to be able to set response headers using the Route Handler integration.
I the example I try to access the response object from the context function second argument, but the value is simply undefined,
Here is the example:
const server = new ApolloServer({
  schema: makeExecutableSchema({
    typeDefs,
    resolvers: getAllResolvers(),
  }),
});

const handler = startServerAndCreateNextHandler<NextRequest>(
  server,
  {
    context: async (req, res) => {
      console.log(`Response: `, res)
      return {
        req,
        res,
      };
    },
  }
);

export async function POST(request: NextRequest) {
  return handler(request);
}

The console output is:

Response:  undefined

Unfortunately due to the way Route Handlers work it's not possible to pass the response object to Apollo Server's context function. What you can do is await the response object from your handler and then modify the response object's headers in the Route Handler like this:
export async function POST(request: NextRequest) {
  const response = await handler(request);

  response.headers.append('name', 'value');

  return response;
}

Thank you @martinnabhan for your reply.
That is unfortunate though. There are scenarios where it could be nice to have access to the response inside GQL resolvers the same way we could have access to the request via context.
In my case, I would like to be able to set the Set-Cookie header whereby adding a session token to cookies.

Hope you got it working! I think I would to the same workaround.


fix(website): Fix graphics and adjust elevator image size

Fix conditions graphic and adjust elevator image size

@Patticatti I think there might be a minor sizing issue between the md and lg breakpoints:


Certificate not printed

The README states:

You can enable TLS and authentication by setting the environment variable ENABLE_TLS_AUTH=true. MailCrab will generate a key-pair and print the self-signed certificate.

With the latest version, though, the certificate is no longer printed. All I see in the logs is this:
2024-02-08T08:14:04.442398Z  INFO mailcrab_backend::smtp::tls: Generating self-signed certificate...
2024-02-08T08:14:04.443203Z  INFO mailcrab_backend::smtp::tls: TLS configuration loaded

It would be great to get this behaviour back as it made standing MailCrab up for quick tests much simpler.

Sorry about that - the log statement got lost during a rewrite. I've added it again en will release it with version 1.1 in a few minutes.
On a side note, the certificate is also written to disk, so you can find it there, but I guess that might be ergonomic in some cases.


[PROF.1] As a user, I want to delete my account

Action: Next version1.4 As an authenticated user, I want to be able to delete my account.
Acceptance Criteria:

All the ongoing requests have to be cancelled.

All the ongoing offers have to be cancelled.

The request attached to the cancelled offer has to be erased from the database.

The closed requests and closed offers that the user was part of are not erased but the user's information is no longer visible and replaced by "Unknown User".

All the user's information is erased from the database

ZenHub Information
This information is updated automatically. To modify it, please use ZenHub.

I'd suggest not putting this off for a future version. AFAIK this is already developed (correct me if I'm wrong @ashwinkjosepk) and is important to comply with data privacy laws.

I'd suggest not putting this off for a future version. AFAIK this is already developed (correct me if I'm wrong @ashwinkjosepk) and is important to comply with data privacy laws.

Yes, this is already implemented and is also available in the version that is live right now.


WIP: Proper order in search results

Fixes #30
Changed the underlying itunes api used for search, so the results order matches what's seen in the store. This method is about twice as slow as the current one (I wonder if we should leave both available in case someone prefers speed over accuracy).
Still need to update readme and add a pagination parameter (right now any number of results can be fetched, haven't tested at what point it breaks).
@icaroponce @anater @cloforce I would appreciate if you checkout this branch and confirm the results are what you expect according to the discussion in #30.

Hey @facundoolano, thanks for working on this. I've been really busy these weeks and couldn't give you more details about that, I'm sorry. I asked some friends of mine - who are still working in a company, whose projects use this module - to check the branch and give you some feedbacks about it. As soon as they test it, I'll let you know.


TikTok Events API (Official) not showing up in Google Tag Manager Search Gallery

I've tried searching multiple times but the TikTok Events API (Official) not showing up in Google Tag Manager Search Gallery.

UP, same problem here. Did anyone has a solution?

@EASGP @cherubon
The EventsAPI template is only available in server container (you are searching in web container template gallery so will not be able to see it).

Uploading ملفات المنتجات.csv…


Blocked window : we are sorry !???

wow what is this bug guys ?
from my side , it happen when i use batch renaming search and a app nwjs debug run from crash.
I am was batch renaming variables...

that not good

Now a lost all my change clipboard, and i can not use ctrl+Z because vscode reset !!

i have only this debug setup

am lucky , i just made a commit , so am able to get Back , but this is not good!

I have no clue what you are saying, sorry.
Please file a new issue with nice reproducable steps. Here's some guidelines on how to file issue https://github.com/Microsoft/vscode/wiki/Submitting-Bugs-and-Suggestions


Write out dataset schema from NVT workflow

Aha! Link: https://nvaiinfra.aha.io/features/MERLIN-503

@karlhigley Be aware of the #1093 , where it is being created a start_index for the Categorify().
We should take that into account when we define the 'categ_feature.int_domain.max' in the schema, as it should be probably shifted by the start_index

Hi, I'm new to NVTabular. Is it possible to create a schema from NVT workflow? Many thanks and congrats on the library. It's truly amazing!

@IamGianluca hello.  Thanks for your interest. Yes you can easily create schema from NVT. Please see the example script below:
cat_features = ['movieId] >> nvt.ops.Categorify()
feats_item = cat_features['movieId'] >> ops.AddMetadata(tags=["item_id", "item"])
feats_user = cat_features['userId'] >> ops.AddMetadata(tags=[ "user_id", "user"])
feats_genres = cat_features['genres'] >> ops.AddMetadata(tags=["item"])

feats_target = (nvt.ColumnSelector(["rating"]) >>
           ops.LambdaOp(lambda col: (col > 3).astype("int32")) >>
           ops.AddMetadata(tags=["binary_classification", "target"]) >>
           nvt.ops.Rename(name ='rating_binary')
          )
target_orig = ['rating'] >> ops.AddMetadata(tags=["regression", "target"])

workflow = nvt.Workflow(cat_features + feats_item + feats_user + feats_genres  + target_orig + feats_target )
train_dataset = nvt.Dataset([os.path.join(INPUT_DATA_DIR, "train.parquet")])
workflow.fit(train_dataset)

workflow.transform(train_dataset).to_parquet(
    output_path=os.path.join(INPUT_DATA_DIR, "train"),
    out_files_per_proc=1,
    shuffle=False,
)

Then go to os.path.join(INPUT_DATA_DIR, "train") folder, you will see the schema.pbtxt file.
Hope that helps.

Thank you @rnyak, it worked!


ENTESB-17917: Fix AWS Lambda failing itest (bringing over commit by aldettinger)

We rebranched 2.2.1-product, need to bring over the change from https://github.com/jboss-fuse/camel-quarkus/pull/115

@cunningt I was able to re-assess this commit and it's working in jvm/native against localstack/real AWS api => So let's merge.
The failing check is unrelated. Thanks for preparing this patch.


fn signatures don't include qualifiers

Currently, signatures for functions do not include qualifiers like unsafe, const, async... More info here about which qualifiers are allowed: https://doc.rust-lang.org/reference/items/functions.html
It would be helpful to also include this (mainly for hover and completion), as it is currently not possible to tell if a function is async or unsafe without a go-to definition - or seeing rustc compilation errors at call site.

Related: unsafe is also not shown in signatures for unsafe traits:

Yep, this would be good to fix! The relevant code is here:
https://github.com/rust-analyzer/rust-analyzer/blob/c5b322e3df0f3c9d81676bece76bcb76eac6e1ba/crates/ra_ide/src/call_info.rs
Specifically, extending CallInfo::with_fn should do the trick here. However, this bit of code might want some bigger refactoring. Specifically, as_callable_def doesn't handle closures at the moment, and is in general at the wrong level of abstraction. Ideally, we should extract the call info directly from the callable type (don't have a solid design for this in my head yet).


Migrate tests to Node.js test runner

Replace jest with the Node.js test runner (and tsmatchers for assertions if needed).

Closed via 22ec95cb6449e583e330c04a26632e9988904613