Short issue title

Describe the bug
IMPRT FROM ULR does not work anymore ?
To Reproduce
Steps to reproduce the behavior:

Go to '...'
Click on '....'
Scroll down to '....'
See error

Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):

OS: win 10 x64
Installation Method: standard
App Version 2020.5.1

Additional context
Add any other context about the problem here.

Closing in favor of #2937


List of (small) bugs and issues (letsencrypt-win-simple v1.9.0)

Now that the certificate chain problems have been solved, I have a few more small issues with letsencrypt-win-simple v1.9.0

the certificate is created with a timestamp in the name. For times where the minutes are single digit no leading 0 is used so time looks strange, samething for seconds.

I get an error every time I create a certificate for the first time

"a specified logon session does not exist. It may already have been terminiated"

I get an error every time I create a certificate afterwards.

"error removing certificate: Index was outside the bounds of the array"

The certificate is created but I have to bind id manually from IIS manager.
Hope this is something we can solve too!

That's a setting you can change, this is the current format that was agreed on.

We haven't figured out the root cause for that yet. From what we have seen, it can happen if there are IIS changes made outside the app while the app is running. The current workaround is to rerun the application. Nobody else has reported getting it every time, I haven't seen it more than once a day.

That means you have extra certificates in your WebHosting store. You can use --keepexisting  to have it not try to remove certificates.
You can change the log level to Debug and it should let you know what the problem certificate is in the event log.

If you would like to have any of these added as enhancements, please submit them as separate issues so they can be voted on and worked on separately.

Thank you for your very quick responses! much appreciated!

sure, if it's by design I'm absolutely fine with it.
i'm tempted to say it happens every time I generate a certificate for a host that does not yet have a certificate. I agree that the workaround works.
ok, so what is the intended behavior? Should the tool remove the extra certificates by default and does it fail in this case? Or is this error expected behavior if I've run the tool before for this host (e.g. see previour point!).
I have changed to debug but cannot seem to find any info on what certificate is the problem.
I find this error, but it does not show more then the CLI does

<Event xmlns="http://schemas.microsoft.com/win/2004/08/events/event">
<System>
<Provider Name="letsencrypt_win_simple" />
<EventID Qualifiers="0">4</EventID>
<Level>2</Level>
<Task>0</Task>
<Keywords>0x80000000000000</Keywords>
<TimeCreated SystemTime="2016-04-14T14:40:28.000000000Z" />
<EventRecordID>56016</EventRecordID>
<Channel>Application</Channel>
<Computer>HomeServer</Computer>
<Security />
</System>
<EventData>
<Data>04/14/2016 16:40:28 +02:00 [Error] Error removing certificate IndexOutOfRangeException { Data: [], Message: "Index was outside the bounds of the array.", InnerException: null, TargetSite: Void UninstallCertificate(System.String, System.Security.Cryptography.X509Certificates.X509Store ByRef, System.Security.Cryptography.X509Certificates.X509Certificate2), StackTrace: " at LetsEncrypt.ACME.Simple.Program.UninstallCertificate(String host, X509Store& store, X509Certificate2 certificate)", HelpLink: null, Source: "letsencrypt", HResult: -2146233080 }</Data>
</EventData>
</Event>

It tries to uninstall any certs for the same hostname you are running it for. If it can't it shows the error message and continues on, since you can manually remove the old cert if you so desire.
I can add in some more debugging so it tells you what cert it is trying to access sooner than it currently does.

#224 resolves your third item.


nixos/borgbackup: Document wrapper script and show excludes file path

Motivation for this change
I wrote my own borg wrapper scripts before realising that they are provided by the NixOS module.
This adds documentation of the wrapper scripts.
It also adds the path to the excludes file as a variable, because that is useful to know when testing filters.
Things done

Built on platform(s)

[x] NixOS

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[x] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Hi @dotlambda, @yorickvP, @ngiger, would you please be able to review this?

Thanks for the feedback @dotlambda.
The wrapper script was a good addition because it provides a convenient way for users to test their backups.
As you know, a backup can't be trusted unless it's regularly tested.
If there is a better way of testing backups made by the borgbackup module, please let us know and we can document it.

Thanks for the review @dotlambda - I have applied your suggestions.

@yorickvP didn't we merge the restore unit and env file we generate off our borg stuff?

Yeah, this PR documents the generated wrappers.

I must say I'm not a big fan of the wrapper script and wouldn't have merged the PR adding it.

Please revert it if you don't want it here. I stopped caring about contributing to nixpkgs a long time ago.

I must say I'm not a big fan of the wrapper script and wouldn't have merged the PR adding it.

Please revert it if you don't want it here. I stopped caring about contributing to nixpkgs a long time ago.
In case you wonder why, well, dude took time out of his day to document a thing and contribute said documentation for everyone else here, and your response is "wouldn't have merged this in the first place". What an attitude to have.

I just mentioned my opinion, asked a valid question at the same time, and gave (hopefully) valuable feedback later. It's normal that people criticise but -- that's how I know Nixpkgs -- a more or less democratic compromise is found eventually. This is how every open source project should work and we would appreciate your input just as much as anyone else's.

And again, feel free to file a PR reverting everything about this script if you don't like it.

I have no intention to do so, since multiple people seem to find this wrapper script useful.

The only reason it's even here is that we had some misguided and deluded attempt to upstream all our nixpkgs modifications some time ago. Don't worry, it won't happen again.

I'm sure it would make your life easier if you did upstream at least some of them. And it makes the reviewers' lives easier if you do so in little bits. As I bet other people would profit from these changes, I would love to see you change your mind. If you do, make sure to ping me in those PRs and I'll be happy to drop a review!

@mkaito @yorickvP Your efforts are appreciated by me, at least.

Worth making clear that I don't speak for Yorick, given that I've probably upset a few people.

Ready to merge - @Ma27 - thanks.

@rvl WOuld you be okay with removing the $excludeFile hack? I think we should first add such an environment variable upstream.

No @dotlambda, that's not reasonable - I'm not going to ask upstream to start making environment variables for every CLI option.
We can and should fix it in our NixOS service scripts.

Okay, fine. But at least squash the last two commits into one.

For what it's worth, I don't think having environment variables for every option is unreasonable. Perhaps upstream has strong opinions on the subject, but it's not a fundamentally wrong course of action, especially for things meant to run automatically on a server. Environment for configuration is one of the tenets of 12-factor apps, after all.

OK thanks @dotlambda - rebased and squashed.
It's not unreasonable to have environment variables for every CLI option, and sometimes it's quite helpful. But most of the software we package does not work like this. Borgbackup has a handful of settings which can be controlled by env var - generally things that apply to every borg subcommand. Our purpose is to package the software and make it easy to configure and use, not to fix every upstream package.

Hello @dotlambda or @SuperSandro2000, I just rebased this on the latest nixos-unstable. Could we please merge it? :pray:
Also in related borgbackup news, I have recently been using the borgbackup create --patterns-from=patterns.lst option, which seems like a much more sane way of specifying files to backup. I could add an option to the nixos module for this - if someone is willing to merge it.

This PR was recently brought to my attention again, and I would like to help to get it merged. If @dotlambda doesn't have the time, I can poke a few others and see if they would like to help.

I have recently been using the borgbackup create --patterns-from=patterns.lst option

That's a good idea, but perhaps you should put that in a separate PR (please ping me).

Since I have zero knowledge about borgbackup someone else needs to verify the changes.


optimize: Add more configuration tips in additional-spring-configuration-metadata.json

Ⅰ. Describe what this PR did
optimize: Add more configuration tips in additional-spring-configuration-metadata.json.
优化：添加更多配置提示信息到additional-spring-configuration-metadata.json中。
注：此PR是从 #2964 中拆分出来的。
Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews

Codecov Report

Merging #3118 into develop will decrease coverage by 0.08%.
The diff coverage is 33.33%.

@@              Coverage Diff              @@
##             develop    #3118      +/-   ##
=============================================
- Coverage      50.57%   50.48%   -0.09%
  Complexity      3105     3105
=============================================
  Files            599      598       -1
  Lines          19510    19501       -9
  Branches        2406     2374      -32
=============================================
- Hits            9868     9846      -22
+ Misses          8650     8645       -5
- Partials         992     1010      +18

Impacted Files
Coverage Δ
Complexity Δ

...n/src/main/java/io/seata/common/DefaultValues.java
0.00% <0.00%> (ø)
0.00 <0.00> (ø)

...ava/io/seata/core/constants/ConfigurationKeys.java
0.00% <0.00%> (ø)
0.00 <0.00> (ø)

.../java/io/seata/core/rpc/netty/NettyBaseConfig.java
40.29% <50.00%> (+4.18%)
2.00 <0.00> (ø)

...obuf/convertor/BranchRegisterRequestConvertor.java
90.47% <0.00%> (-9.53%)
3.00% <0.00%> (ø%)

...otobuf/convertor/GlobalBeginResponseConvertor.java
92.59% <0.00%> (-7.41%)
3.00% <0.00%> (ø%)

...otobuf/convertor/GlobalCommitRequestConvertor.java
93.75% <0.00%> (-6.25%)
3.00% <0.00%> (ø%)

...otobuf/convertor/GlobalStatusRequestConvertor.java
93.75% <0.00%> (-6.25%)
3.00% <0.00%> (ø%)

...obuf/convertor/GlobalRollbackRequestConvertor.java
93.75% <0.00%> (-6.25%)
3.00% <0.00%> (ø%)

...protobuf/convertor/RegisterTMRequestConvertor.java
94.73% <0.00%> (-5.27%)
3.00% <0.00%> (ø%)

...protobuf/convertor/RegisterRMRequestConvertor.java
90.47% <0.00%> (-4.77%)
3.00% <0.00%> (ø%)

... and 18 more

LGTM


Update package building scripts and images to use Conan

High Level Overview of Change
Lots of changes needed to update the docker containers we use to build DEB and RPM packages.
Context of Change
rippled's dependencies are handled by Conan now so the package building process needs to be updated.
bump version to rc3
test on Fedora 37
rm docker user mapping  on container builds (doesn't work with conan)
rm dpkg dev pkg (was broken anyway)
rm dependency builds (dependencies are handled by Conan now)

Type of Change

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Refactor (non-breaking change that only restructures code)
[ ] Tests (You added tests for code that already exists, or your new feature included in this PR)
[ ] Documentation Updates
[ ] Release

@thejohnfreeman I'm still unsure about the removal from RippledRelease.cmake of
# Early return if the `containers` directory is missing,
# e.g. when we are building a Conan package.
if(NOT EXISTS containers)
  return()
endif()

I guess this might be a flaky test. I kicked it off again.
1> ripple.app.LedgerData
0> #299 failed: apply: Got temINVALID (The transaction is ill-formed.); Expected tesSUCCESS (The transaction was applied. Only final in a validated ledger.)
0> {
   "Account" : "rHb9CJAWyB4rj91VRWn96DkukG4bwdtyTh",
   "Amount" : "1000000010",
   "Destination" : "rJP5kd48NUvKuEMUUNdByiQCauJVYURBz8",
   "Fee" : "10",
   "Flags" :<PHONE_NUMBER>,
   "Sequence" : 51,
   "SigningPubKey" : "0330E7FC9D56BB25D6893BA3F317AE5BCF33B3291BD63DB32654A313222F7FD020",
   "TransactionType" : "Payment",
   "TxnSignature" : "304502210092D9DA00AAE0404640A8697028B3E36BA45FCA7[500](https://github.com/XRPLF/rippled/actions/runs/4266933705/jobs/7428013711#step:19:501)D475FAC8F6B97B01B1D80902206B51127825AD3AE0ED3F7CE16CC665533571BAF49B852B4B1E69DBD552BFA4E0"
}

0> #300 failed: unhandled exception: unexpected missing account root
0> ripple.app.LedgerReplayer ProofPath

@legleux to confirm this is ready to merge, you can put the Passed label on it (or comment saying it's ready)

How about that, I can add labels?
Let's merge it.


Facebook Live "DVR" videos don't download

Checklist

[x ] I'm reporting a broken site support issue
[x ] I've verified that I'm running youtube-dl version 2021.04.17
[x ] I've checked that all provided URLs are alive and playable in a browser
[x ] I've checked that all URLs and arguments with special characters are properly quoted or escaped
[x ] I've searched the bugtracker for similar bug reports including closed ones
[x ] I've read bugs section in FAQ

Verbose log

[gtaxl@jetstream:youtube]./youtube-dl -v --username<EMAIL_ADDRESS>-F https://www.facebook.com/watch/?v=803064316999820
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: [u'-v', u'--username', u'PRIVATE', u'-F', u'https://www.facebook.com/watch/?v=803064316999820']
Type account password and press [Return]:
[debug] Encodings: locale UTF-8, fs UTF-8, out UTF-8, pref UTF-8
[debug] youtube-dl version 2021.04.17
[debug] Python version 2.7.16 (CPython) - Linux-4.19.0-8-amd64-x86_64-with-debian-10.8
[debug] exe versions: ffmpeg 4.1.6-1, ffprobe 4.1.6-1
[debug] Proxy map: {}
[facebook] Downloading login page
[facebook] Logging in
[facebook]<PHONE_NUMBER>99820: Downloading webpage
ERROR: This video is only available for registered users. Use --username and --password or --netrc to provide account credentials.
Traceback (most recent call last):
  File "./youtube-dl/youtube_dl/YoutubeDL.py", line 806, in wrapper
    return func(self, *args, **kwargs)
  File "./youtube-dl/youtube_dl/YoutubeDL.py", line 827, in __extract_info
    ie_result = ie.extract(url)
  File "./youtube-dl/youtube_dl/extractor/common.py", line 534, in extract
    ie_result = self._real_extract(url)
  File "./youtube-dl/youtube_dl/extractor/facebook.py", line 677, in _real_extract
    return self._extract_from_url(real_url, video_id)
  File "./youtube-dl/youtube_dl/extractor/facebook.py", line 525, in _extract_from_url
    self.raise_login_required()
  File "./youtube-dl/youtube_dl/extractor/common.py", line 943, in raise_login_required
    expected=True)
ExtractorError: This video is only available for registered users. Use --username and --password or --netrc to provide account credentials.

[gtaxl@jetstream:youtube]

Description

Hello, I'm trying to download a "recorded live" video from Facebook. It requires me to login, which I do, but yet still says the video is only available to registered users. I can fully view the video just fine from the same account on the web browser. Also your facebook downloader needs to support the url "fb.watch" otherwise it will use the generic downloader at first.

Pass cookies.

use caution when using cookies with facebook, as they can
lock your account for suspicious activity.

Yes that worked, I used "Get cookies.txt" and passed the --cookies file and it worked. The original cookies.txt Chrome plugin was removed from the Chrome store. Wonder why the login method doesn't work?


Monterey workflow

This wizard page shown below:

is the smallest possible implementation of Monterey workflow feature I mentioned sometime earlier. It appears after the project was created and presents the "shortcut" to the case where these two checkboxes are not selected and are later invoked in a "step by step" fashion

Yes I remember. Is there a specific reason for creating this issue? if your intention was to name this the "monterey workflow" then I am all for it, as it makes sense

I am raising it to introduce that name - and to indicate that at some point this may be the "location" where we could host a simple workflow engine like https://github.com/joyent/node-workflow.
The issue is not to automate a few consecutive activities from the Task manager - I am seeing a point in the future, where Monterey is used to deploy multiple applications to multiple hosting PaaS (like Engine Yard with Docker and or Deis

I am seeing a point in the future, where Monterey is used to deploy multiple applications to multiple hosting PaaS (like Engine Yard with Docker and or Deis

Step for step Nikolaj :)
First step is: https://github.com/monterey-framework/monterey/issues/284

So, if we are planning to ascent Mount Everest - you would like to be told that we need to make a trip to Kathmandu and that would be it?
Not my way of doing business :smirk_cat: )


Read logs from stdin

We are running Wildfly (or JBoss) server in a docker container. We want to see the outputs of the Wildfly process in log-viewer. Unfortunately, we can't output the server logs to a file (because the underlying pods has a very limited disc space). So, the idea is to show the stdout of the Wildfly process on log-viewer, like:
./start-wildfly | logviewer.sh
There is a node based implementation called frontail that allow this.
Is there a way to do this with log-viewer. We tried using /dev/stdin without success.

It's impossible. LogViewer can work with files only.


Senza cli does not filter stacks by version

Senza cli does not filter stacks by version. It needs to be done by the API.

Coverage increased (+0.04%) to 90.271% when pulling c91151ed68baacab9f22b9e7c8b6bb9b7e2c2fac on rafaelcaricio:fix-stack-weights into b2e93f805d2e95193e0b809fa0b67013ef5f4b48 on zalando:release2.0.

:+1:


Toolbox and designer view

Love the updates. When I create a new app with the template now though, the designer view will not update with my xaml files. Also the toolbox is empty.
Intense Version 0.2.0
Microsoft Visual Studio Community 2015
Version 14.0.24720.00 Update 1

Target version was set to Windows 10 build 10586. When I change it to build 10240 The designer and toolbox come back.


⚠ Bofrost.fr has degraded performance

In 9f1904b, Bofrost.fr (https://www.bofrost.fr) experienced degraded performance:

HTTP code: 200
Response time: 1227 ms

Resolved: Bofrost.fr performance has improved in b549906.


Add i18n to the frontend

Merged 2 pull request #2149 #2242, complete the missing translation part and add traditional chinese.

This is so awesome @skipandsnow
I can't thank you enough.
Should we go through defining a way to set it up on the settings page ?
@anovazzi1 what do you think?

I think this is a good idea, maybe a language dropdown in the settings page?

I think this is a good idea, maybe a language dropdown in the settings page?

I would like to help with it :)

Hey @skipandsnow
We are going to prioritize the #2149 since it was created first. Do you mind merging this one into it? Or we can merge it first, then we merge yours. What do you think?


vue3-select2-component modal issue

I am working with vue3-select2-component, it works fine on any page but when things come to bootstrap modal vue3-select2-component does not work fine for it like, no searching, no select option nothing
can you guys help me out how to fix this.
I am struggling on this issue from last couple of days but couldn't found any solution yet
will be waiting some good response from you guys.
Thanks

Hi @yasirmehmood123 I resolved this issue with after reading this :
https://select2.org/troubleshooting/common-problems
So now what you have to do is to define a modal variable in your component like :
`
let modal = ref();
onMounted(() => {
modal.value = document.getElementById('my_modal_html_id');
});
return {
modal
};
`
Then use it in settings bind such as :
`
<Select2  :settings="{ dropdownParent: modal }"
....

`
Works fine for me, hope for you too :)


fix: reject promise if deserializeMessage throws

if deserializeMessage throws for any reason (such as a BSONError), the pendingMessage promise will never resolve. this PR changes this behavior so that the promise will reject if there's an error thrown

Is this testable? Would be nice to have one bad path test where it gets rejected 😅
Thanks anyway and if you don't find the time i can merge it

Is this testable? Would be nice to have one bad path test where it gets rejected 😅
Thanks anyway and if you don't find the time i can merge it

I could try to take a look at this later today but in theory it shouldn't be too difficult (get some bad BSON data to cause an issue)

@lucsoft it doesn't seem like there's an easy way to force MongoDB to return invalid bson so unless you know of a way to do that, I don't really know how I'd write a test for this

@williamhorning well the only way would be to edit the raw bson like flipping a bit or something

@lucsoft i don't really see a way of reliably doing that with the current CI setup. additionally, most people will probably never run into bson errors unless they're doing something weird or if there's a bug with mongodb

@williamhorning okay then I just merge it

Just fix CI and then I merge it

@lucsoft i fixed CI


Pycharm fails to offer autocomplete.

Just want to say i dont really like ToDo Comments because the normaly communicate to me a "dont do".
Now a Problem arosed when trying to work with your code. Because everything is dynamic now Pycharm fails to offer autocomplete. Is there a way to solve this. Most people using this lib are python beginners and will get frustrating by triying to write programms and the IDE fails to tell them if they made an spelling error.
print(empire.supply(empire.planet_ids()[0]).deuterium_storage.in_constructions)

this code start up fine until it gets to it.
Originally posted by @PiecePaperCode in https://github.com/alaingilbert/pyogame/issues/92#issuecomment-782356234

@prior-l


Readonly support for jsdoc

Add @readonly to jsdoc; works the same way readonly does in TS.
Fixes #17233

@typescript-bot user test this

@weswigham Looks like the bot doesn't pay attention to sign off comments.

Results are the same as yesterday's @private results.


fixed typos in readme

fixed typos in readme.
changed a sentence formation for better understandability.

Thank you for your contribution. This change should be made here.


266: drop all records instead of collections

Pull Request
Brief Summary

Refactored script "npm run drop" command to delete all records from collections without dropping the entire collection itself
Note that deleteMany is used to delete all records from a collection instead of remove() since the latter is deprecated.
Source: https://www.mongodb.com/docs/manual/tutorial/remove-documents/

Questions / Considerations for the Future

Should I be renaming the script as well? instead of drop, should it be renamed to empty/delete?

New Tests

NA (manually tested using compass)

Closes #266

Should I be renaming the script as well? instead of drop, should it be renamed to empty/delete?

Yes Dao, good call. I would name it so its npm run clear. That's just my opinion though, maybe other reviewers will have another. I think npm run empty sounds a little strange because empty might have other connotations, same with delete. Maybe we should rename these so they are clear they're database-specific. For the future though. This PR looks good.


Add Brasil API

https://brasilapi.com.br/

@rodfersou you can add the API yourself by opening a pull request.


timescaledb service end point

i have tried this helm chart two three times, but it is not exposing 5432 port properly, even with default configuration, loadbalancer remain down, i am checking with digitalocean
is there way i can connect it directly ?

Could you elaborate a bit? This may be an issue with Digital Ocean, these Helm Charts, or something very different.

So, clearly I'm running into a Digital Ocean limit here.
For troubleshooting, could you provide the output of:
kubectl get service/$RELEASE

thanks for replying, i am attaching screenshot of nodebalancer as well as sharing output of service, timescale db is running, i have checked via port forward of pod, but not able to connect to DB remotely

Looks good, you may be running into a firewall or something similar; that's hard to establish from here.
From inside the kubernetes cluster (from another timescale pod for example) what does the following do:
pg_isready -h <IP_ADDRESS> -p 5432
pg_isready -h timescale-16 -p 5432

Also, to address your actual question, however it would only be a debugging/troubleshooting step IMHO:
kubectl port-forward $(kubectl get pod -l cluster-name=timescale-16,role=master -o name) 15432:5432

In a separate console, you should be able to connect:
psql -h localhost -p 15432 [...]

I have checked the port forwarding method and it's working, for other method I will share update

pg_isready -h timescale-16 -p 5432
is fine, but not with IP

Ok, that means the Service is working, but you cannot connect to the public IP.
That seems like a firewall to me, I'd advise you to take that up with Digital Ocean, either their support documentation or their support channels.

ok thanks for your time, nodebalancer always say down, I logged in server, port is listening but only ipv6

i can access other services but connection timeout on the timescale service, and even can not connect pod direct address from other non timescale pod

build new cluster and from this github repo, and it worked now, thanks for your time


Features/backup db

@godgunman  Please move to rumors-deploy, thanks!

moved to https://github.com/cofacts/rumors-deploy/pull/14


Remove source dependencies to released packages

Some packages such as ur_msgs are already released for most ROS2 distributions.

That has been done by now.


Swap math/rand with crypto/rand

The current implementation with math/rand is deterministic. Run https://play.golang.org/p/CuKGup7fJR locally (playground seems to cache it), and switch the import back to math/rand.
See output here: https://gist.github.com/kennwhite/ba04a924e3ac279dc73e418fe2bbab98

How terrifying! This is what comes of using goimports in a save hook.
For anyone watching, the issue is that math/rand now also implements the io.Reader interface and goimports confuses it with crypto/rand.


tests: fixes various python code issues found by pyflakes

[approve ci freebsd]

Looks great.
Should we consider a pre-commit hook for this as well? I have in mind something similar to our clang-format hook. That would be a separate PR, naturally.

@bneradt a hook/script/profile for running the lint would be good. These imports are only a fraction of lint issues found by pycodestyle

Cherry-picked to v9.0.x branch.


feat: add template command.

feat: store Chart.yaml in memory

add command ksbuilder template
remove Chart.yaml. generate it in memory when use ksbuilder template or ksbuilder lint

fixed: https://github.com/kubesphere/ksbuilder/issues/76 https://github.com/kubesphere/ksbuilder/issues/77
feat: add template command, and store Chart.yaml in memory.

/lgtm
/approve


glfwGetWindowFrameSize returns incorrect value on Windows 10.

glfwGetWindowFrameSize returns incorrect sizes on windows 10 (larger than they should be).
For a resizable (default) window I get:
Left: 8
Top: 31
Right: 8
Bottom: 8
Windows 10's style has window borders that are only 1 pixel in width/height (excluding the title bar).
I am guessing this is because it may be hard-coded and not updated for Win10 yet?
The Win32 function GetWindowRect can be used for calculating correct sizes of the window border at runtime no matter the windows OS. My D3D11 backend uses this and it works fine on Win10.

The border size is not hard-coded and border sizes could vary before Windows 10. It is calculated with AdjustWindowRectEx, as you can verify from the source.
This bug is likely a result Microsoft's belief that programs can't handle the truth unless it winks to the OS via yet another back channel.

That's odd, my D3D backend also uses AdjustWindowRectEx for correctly sized window creation, will investigate further...

Yeah, this is not a problem with GLFW :+1:


Rhea reactions, small tweaks

Change the text to
"Click to  view term details, annotations and larger Rhea reaction diagram)
Also I was confused by the
"From the GO molecular function ontology" because I thought that test referred to the reaction diagram. I now realise is is on every pop-up.
Maybe move the ontology aspect  to the top of the popup above the term like:
"~From the~ GO molecular function ~ontology~

How's this?:

great! bed!


HDDS-5205. Make admin check work for SCM HA cluster

What changes were proposed in this pull request?
Make admin commands like safe mode etc., work on SCM HA cluster.
Note: When working this identified for two of the calls getContainerWithPipeline and getContainerWithPipelineBatch checkAdmin is called with null, not sure why it is called if we do not do any checks. For now, left as it is.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-5205
How was this patch tested?
Added a smoke test.

Thank You @adoroszlai for the review. I have addressed review comments.

Thank You @adoroszlai for the review.


Implement Timelock

Resolves #13

We should make sure we document the fact that this particular preset is the most common usage and that direct library usage should be done with caution given the lack of auth implementation.

Superseded by #359

Superseded by #359


On premise install steps using Ansible : Update pre-requisites section with min system requirements for VM host

BUG REPORT
In setting up OpenEBS in ansible mention the minimum disk size required for kubemaster and nodes.
What happened:
In setting up OpenEBS using ansible, mention the minimum disk size required for kubemaster and nodes .
What you expected to happen:
In setting up OpenEBS using ansible, mention the minimum disk size required for kubemaster and nodes in  documentation prerequisites.
How to reproduce it (as minimally and precisely as possible):
Anything else we need to know?:

The Vagrant VMs (ubuntu-xenial) that are used in the on-premise installation need a min of 10GB hard-disk space each (3 VMs are recommended for a hyperconverged deployment) and 1GB operating memory
A recommended configuration for the VM host would be to have at least the following specs :

40GB Hard Disk
4GB RAM
At least 2 CPU cores / vCPUs (if host is a VMware/other guest box)


Plugins located in lib/plugins will be auto-loaded

Based on the feedback from @josephfrazier in https://github.com/OctoLinker/browser-extension/issues/86, this PR adds an auto-loader which loads all plugins located in lib/plugins. By that, a plugin developer doesn't have to think about import the plugin manually.

Nifty! I had heard that webpack can do dynamic requires like this, but I don't think I'd seen it used until now.


Fails with lines-tables-only

This option is documented here.
./src/lib.rs:
pub fn foo() {}

./Cargo.toml:
[package]
name = "a"
version = "0.1.0"
edition = "2021"

[dependencies]

[profile.release]
debug = "line-tables-only"

cargo asm fails with "Error: No artifact found" when this option is set. It works when it is set to 0, 1, 2.

Managed to reproduce it, but had to update to 1.71
So I'm asking rustc to produce .s files and json output, then I'm parsing that json with cargo-metadata to find out what was generated. json contains this bit of info which supposed to parse into ArtifactProfile
"profile":{"opt_level":"3","debuginfo":"line-tables-only","debug_assertions":false,"overflow_checks":false,"test":false},

https://docs.rs/cargo_metadata/latest/cargo_metadata/struct.ArtifactProfile.html
And debuginfo field is described as Option<u32>...
I think once cargo-metadata gets updated - cargo-show-asm will magically start working again...

Made a ticket, we'll see what they reply.

https://rust-lang.zulipchat.com/#narrow/stream/246057-t-cargo/topic/Breaking.20JSON.20change.20in.201.2E71

I released 0.2.20 with a workaround for this problem. Will close the ticket with a proper fix once cargo-metadata updates.


OrientDB doesn't compile with JDK11

OrientDB Version: 3.2.x
Java Version: 11
OS: MacOSX
Expected behavior
Successful compilation.
Actual behavior
Classes from the "Signal" package are not found.

Fixed a while ago, current CI build run on JDK 8, 11, 17


Compatibility termlist support for ChooseRowSpec, ChooseDataSource, ChooseColSpec

DSZ sometimes uses settings for termlists without .termlist word.
E.g.
targetProperty="Series Clinical Notes Audit"
and
targetProperty="Series Clinical Notes Audit.termlist"
means the same.
Can you support it please?

Example

This is crazy.
Turned out that there is a 3rd supported form with .term. E.g:
"MEXX Patient Bill Rows.term"
or
"MEXX Patient Bill Cols.term"
Please, support this too!

Works! issue is solved in 3.1.56.


Bugfix: don't grep through working dir in ZSH

In ZSH I got a bunch of
grep: database: Is a directory
grep: gems: Is a directory
grep: log: Is a directory

messages, as soon as I used a $confdir/$domain file.

thanks @aars ! :)

No prob! I really like this tool. How is the refactor going? Can I help? I'd like to add some features like a default command-to-pipe to, jq for example to always format/color json. Maybe even set output-command by content-type header. Also displaying the status-code on an empty response body would be nice.

Is the refactor branch currently useable?

Refactor has been sleeping for some time, and I start reviving few days ago.
What's hindering now Is the test transition. I'm waiting this to complete refactor and ensure we don't have regression.
I was thinking going to use cucumber and aruba, so have to use this https://github.com/cucumber/aruba/pull/323

Is the refactor branch currently useable?

No Idea. I don't remember in which state I left it.
JQ is a killer feature, I add it in mind

Your more than welcome to collaborate ! :)

Hello @aars. :)
I just saw you forked form my repo.
I have been uquite busy at work and OSS lately,
But now that aruba is updated, the test can now be reworked.
feel free to contact me on my [gitter](http://gitter.im/AdrieanKhisbe- ;)

Will do!

Hey @aars,
I restarted working on resty, and refresh my refactor.
you can see the state there on the #50 PR
Your input is more than welcome!

Cool! I'll have a look asap (tonight or tomorrow).


Remember table sort order after refresh

Storage Explorer Version: 1.1.0
Platform: Windows
Architecture: ia32
Build Number: 20180507.1
Commit: bcc8990d
Regression From: N/A
Steps to Reproduce:

Open a table from a storage account
Click on the RowKey column to change sort order to RowKey ascending
Refresh

Expected Experience:
After refresh, the sort order is still RowKey ascending.
Actual Experience:
The sort order is reset to PartitionKey ascending.

This issue will be fixed in the 1.25.0 release.


Hardlocked editor in latest version of Unity (2018.3)

Latest version of Unity, latest version of this plugin.
Importing any GLB-file (dropping it in Project-folder) causes Unity to hardlock.
Some info:
Removed uap-plugin folder because it didn't compile properly.

Thanks for letting us know. We'll try to take a look soon.

Did some investigation.
First off, it hardlockes even in Unity 2017.4.20f2 (LTS).
I stepped through the code and the problem occurs in the method
private async Task _LoadNode(int nodeIndex) in GLTFSceneImporter.cs
When isMultithreading is set to always be false, the editor doesn't hardlock for me.

Would be great to create a PR which fixes this

Sure, I have a branch ready, but I don't seem to have premission to push a branch.

Sure, I have a branch ready, but I don't seem to have premission to push a branch.

You should be able to fork the repo and create a branch that will allow you to submit a PR (see https://guides.github.com/activities/forking/)

Good info, I did this. My PR got some weird warning/issue that isn't related to the work I have done. The code is there anyways.

Please update to the latest version and open a new issue if the problem persists. Thanks!


ParallelCluster cloudformation deployment fails with a timeout

Hello,
I am trying to deploy ParallelCluster and the cloudformation template fails with the following error:
WaitCondition timed out. Received 0 conditions when expecting 1
The following resource(s) failed to create: [HeadNodeWaitCondition20211021154453].
It does work when I scale the compute resources down to 0.  I also switched from spot to ondemand instance type thinking it might be an issue with getting spot resources but that did not help and it fails with the same error message.  In the chef-client.log file I see these messsages:
[2021-10-21T16:27:43+00:00] INFO: Waiting for static fleet capacity provisioning
[2021-10-21T16:27:58+00:00] INFO: Waiting for static fleet capacity provisioning
[2021-10-21T16:28:13+00:00] INFO: Waiting for static fleet capacity provisioning
[2021-10-21T16:28:28+00:00] INFO: Waiting for static fleet capacity provisioning
[2021-10-21T16:28:43+00:00] INFO: Waiting for static fleet capacity provisioning
I am using v3.0 for parallel cluster:
$ pcluster version
{
"version": "3.0.0"
}
Here is my cluster config:
$ cat cluster-config.yaml| grep -v '#'
Region: us-west-2
Image:
Os: ubuntu2004
CustomAmi: ami-xxx
HeadNode:
InstanceType: t3.medium
Networking:
SubnetId: subnet-xxx
DisableSimultaneousMultithreading: false
Ssh:
KeyName: testkeypair
AllowedIps: <IP_ADDRESS>/8
LocalStorage:
RootVolume:
Size: 50
Encrypted: true
VolumeType: gp2
DeleteOnTermination: true
EphemeralVolume:
MountDir: /test
Dcv:
Enabled: true
Port: 8443
AllowedIps: <IP_ADDRESS>/8
CustomActions:
OnNodeConfigured:
Script: s3://xxx/master-onnodeconfig.sh
Iam:
AdditionalIamPolicies:
- Policy: arn:aws:iam::xxxx:policy/ParallelCluster-S3KMS-script-policy
Imds:
Secured: True
Image:
CustomAmi: ami-xxxx
Scheduling:
Scheduler: slurm
SlurmSettings:
ScaledownIdletime: 10
Dns:
DisableManagedDns: false
SlurmQueues:
- Name: queue1
CapacityType: ONDEMAND
Networking:
SubnetIds:
- subnet-xxxx
AssignPublicIp: false
ComputeResources:
- Name: compute-resource-1
InstanceType: c5.xlarge
MinCount: 1
MaxCount: 5
CustomActions:
OnNodeConfigured:
Script: s3://xxxx/compute-onnodeconfig.sh
Iam:
AdditionalIamPolicies:
- Policy: arn:aws:iam::xxxx:policy/ParallelCluster-S3KMS-script-policy
Image:
CustomAmi: ami-xxxx
SharedStorage:

MountDir: /home
Name: pcluster-home
StorageType: Efs
EfsSettings:
ProvisionedThroughput: 1024
Encrypted: true
KmsKeyId: xxxx
Monitoring:
Logs:
CloudWatch:
DeletionPolicy: Retain
Dashboards:
CloudWatch:
AdditionalPackages:
IntelSoftware:
IntelHpcPlatform: false
Tags:
Key: Name
Value: Parallelcluster-sim

Any help would be greatly appreciated.
Thanks,
-Simran

Hi @hsimran13,
The HeadNodeWaitCondition timeout is due to compute node failed to launch during bootstrapping. The potential error cloud be post install script execution failure or something else. Could you check /var/log/cloud-init-output.log on compute node? To retrieve logs you can follow the instruction in troubleshooting page.
Thanks,
Yulei

In case people land here. I had a similar error and was due to the size of the volume. Fixed with increasing the root volume size:
HeadNode:
  LocalStorage:
    RootVolume:
      Size: 70

Scheduling:
  Scheduler: slurm
  SlurmQueues:
    - Name: spot
      ComputeSettings:
        LocalStorage:
          RootVolume:
            Size: 70


replaced NImageFetchViewDelegate with closures. Closes #7

removed NImageFetchViewDelegate and replaced by NImageFetchViewCompletion block
added Swift Concurrency APIs to requestImage

I am having 2nd thoughts about concurrency APIs, probably using two threads and kind of a waste... I have to take a look

removed Swift Concurrency @albertocsouto

Thanks! Great contribution, this closes #7. I added a simple test for the new feature, if you are ok with that we can merge

As it is part of a UIView I didn't consider to do unit testing but better to have it, thanks @albertocsouto

@albertocsouto I am used to squash when merging features, if you prefer another strategy comment please :)

Thanks! Squash is he prefered way


Add sample dump files

Add pg_dump and mysqldump sample files.

A tip: you can put #24 in your PR description and this PR will be auto-linked to the issue.


Detect "fake" stats-like objects that aren't instances of fs.Stats

This uses the etag package's implementation of isStats. The problem is caused by older versions of the ubiquitous graceful-fs package, which causes the return value of fs.stat to fail an instanceof check for fs.Stats. See #177 for more information.

Looks great!. Published as 2.2.2


VM creation script should be incorporated into a role.

Presently, in the case of testing via test-bifrost.yaml, we directly invoke the user script.  We should convert this to a role while leaving the script as something a user could use.

Completed in 565d3d6f0cfe5e59b866b72c37c09364750c4eb8.


Dropdown: support disabled items

A SUI Dropdown item can be disabled individually.

http://semantic-ui.com/modules/dropdown.html#disabled
Currently, the Dropdown.Item does not support the disabled prop/className.  The prop is passed directly to the underlying div as an HTML attribute instead.

Fixed in #482


Design: determine if it makes sense to allow developing extensions against production files only

As an extension developer, I want to develop my extensions and run against production Paranext so I don't have to worry about cloning or building paranext-core and dealing with its problems.
We have a debug version of Paranext that you have to build specifically in order to run debug mode in production. Let's compare and contrast the pros and cons of making this the regular production build so people don't have to clone paranext-core and build at all in order to develop extensions. For one, it is possibly less secure in some ways for people to be able to see and debug the code.

This issue is a follow-up from #299


boot splash: 'jarsigner' returned with error #1

Godot version:
stable
OS/device including version:
debian stable
Issue description:
When I change the boot splash image I'm not able to compile my code for android. I got this error:
'jarsigner' returned with error #1
Steps to reproduce:
Project - Project setting - Application - Boot Splash - Image- res://art/fire.png

are you using fire.png as app icon also?
check this issue #16421 to see if it's same issue.

Thank you, that was my problem, I change my icon an I'm nore able to build my apk.


iOS display image

iOS Documentation needs update or explanation.
I want to display image but get error.
Code official doc says:

import FilestackSDK
let filelink = transformable(handle: "g8fLXNCRT4K3TJSUFrRW")

Github gives nothing on this, only about displaying picker/upload
https://filestack.github.io/filestack-ios/

@neo0x0 Could you explain in more detail what are you trying to achieve?

I believe that this is the same issue that I am encountering. Without a transformation the image displays fine
let fileLink = fsClient!.sdkClient.fileLink(for: handle);
However when using a transformation I get an error
let transformable = fsClient!.sdkClient.transformable(handle: handle);
The error I receive when trying to display the image is "conv20 provider error: Failed to identify the file, probably corrupted image provided (idx 0)"

@emajewicz Could you please provide some more context?
Specifically, it would be helpful to know:

Format (png, jpg, etc.) and dimensions of the image file referenced by handle
Transformation chain used (including all their associated parameters).

Thanks!

I know this is old, but just today we have encountered this again. Typically we see this issue when the file is a BMP file, and we're trying to render it as a JPG or PNG. For some reason, Filestack is unable to convert it and claims it's corrupted, but I'm able to view the underlying file just fine. I've emailed<EMAIL_ADDRESS>just now with details and a specific example, which I can't reveal here publicly for privacy reasons. (Ticket # 60857)


Remove Hardcoded URLs

If possible, remove any instance of a hardcoded url and replace it with the named counterpart passed into django.core.urlresolvers.reverse

We are going to leave this open until the URLs in the Javascript are sorted out.

Resolved in #47

Closed via #47


The desktop view is too "zoomed in"

After the latest updates, the default desktop view has been changed to display less adventurers on screen.
I understand that the number of icons besides adventurers portraits has increased significantly, which has taken a lot of screen space, but I would prefer to have a more compact view that showed more units at a time for easier comparison between close units. Maybe a setting could be added to toggle between view modes?

I don't know what a compact view would look like and you can just zoom out, but feel free to send any UI related pull req to https://github.com/dl-stuff/dlsim-vue


Update homepage layout.

Load 7 featured sessions.
Remove first text card.
Remove quote card.
Fixes #996.

LGTM


Checking app behavior against app descriptions

paper link:http://dl.acm.org/ft_gateway.cfm?id=2568276&ftid=1467964&dwn=1&CFID=609851752&CFTOKEN=92241930
dataset: use the data in reference http://www.csc.ncsu.edu/faculty/jiang/pubs/OAKLAND12.pdf

Paper Title: Checking App Behavior Against App Descriptions
Authors:
-Alessandra Gorla
-Ilaria Tavecchia∗
-Florian Gross
-Andreas Zeller

Emails: {gorla, tavecchia, fgross<EMAIL_ADDRESS>Objective: Knowing when a program does what it claims to do.
Contribution: Proposition of CHABADA prototype that clusters apps by description topics, and identifys outliers by API usage within each cluster.
Findings: Our CHABADA approach effectively identifies applications whose behavior would be unexpected given their description. Experiments were applied on a set of 22,500+ Android applications, our CHABADA prototype identified several anomalies; additionally, it flagged 56% of novel malware as such, without requiring any known malware patterns.
@WeiFoo  we can access data directly using this link.
Dataset: https://www.st.cs.uni-saarland.de/appmining/chabada/
Data Description: we have prepared a 50 MB dataset with the exact data that goes into our CHABADA prototype.

Added as chabada.


Implement Id SearchParameter for InMemoryRepository

The InMemoryRepository located here indexes resources by Id, but does not take advantage of that when an _id parameter is passed. Instead, it scans through the list of resources and uses the ResourceMatcher to do the matching.
https://github.com/cqframework/clinical-reasoning/blob/master/cqf-fhir-utility/src/main/java/org/opencds/cqf/fhir/utility/repository/InMemoryFhirRepository.java
We should change this to first look-up by Id if requested, and then apply any additional filters.
Sample CQL:
[Condition : id in {`123`}]

Acceptance criteria:

_id parameter support is added to InMemoryRepository
Tests added to validate that behavior

Resolved by #353


Selecting child connection on block with text field opens text field editor

Fixed by adding a check for "STACK" connection type


Review and update documentation pages

### Sections needing updating
- [ ] Installation
- [ ] User guide
- [ ] Contributing
- [ ] Administration

Closing in favour of #397


[1.7.10] [Mekanism 9.1.0] WorldEdit Issue

Issue description: When using world edit to do any sort of editing in a chunk, or copying and pasting or use schematics, any sort of conduits, whether it is Mechanical, Pressurized, Universal, or Thermal just simply disappear.
Steps to reproduce:

Make a WE selection including Mekanism conduits.
Copy the selection.
Paste the selection, and watch it reappear without conduits.

Version (make sure you are on the latest version before reporting):
**Forge: 1614 (Thermos)
**Mekanism: 9.1.0 (1.7.10 Unabridged R.14)
**WorldEdit: 6.1
When placing a block where the conduit(s) should have been placed, the following error is logged: https://hastebin.com/juyifezeja.pl
Below is a sample schematic file.
https://drive.google.com/file/d/1SMUdZcJiLE9bqhMNq0s5mMFhTyVkwiFE/view?usp=sharing
This issue has also been recreated with schematica.
I have also recreated the issue using just Mekanism 9.1.1 and Schematica. I am in the process of installing the absolute latest version, and retesting.
The mod(s) in question function properly using the development version on 1.12.2. I sincerely hope there is a way to fix this functionality. Like the previous poster, I am a proponent for one last update to 1.7.10, but I completely understand if this isn't possible due to API changes or other reasons.

When using world edit to do any sort of editing in a chunk, or copying and pasting or use schematics

This is not a Mekanism issue as I do not see how we would have control over this.

When placing a block where the conduit(s) should have been placed, the following error is logged: https://hastebin.com/juyifezeja.pl

That's to do with the multipart lib, not us.

The mod(s) in question function properly using the development version on 1.12.2. I sincerely hope there is a way to fix this functionality. Like the previous poster, I am a proponent for one last update to 1.7.10, but I completely understand if this isn't possible due to API changes or other reasons.

Nope, its just 100% EOL.


Add more tests

Great framework! Here's some more tests
This also sets the project indentation to use spaces, to match how the code is.

tests are passing over here, merging!


New Franz - How to start?

sorry about such a trivial question but i was a Franz 4 user and i updated to the new beta.
as soon as i open Franz i get this screen:

i was not able to add a new Hangouts service, for instance, or at least change the type of service i'm adding.
am i now forced to have a Franz account before i add any other services?
if so, Franz lost a user.
thank you.

This has already been discussed in #71
I you want to reach out to me you can contact me via email or on Twitter but Github is not a place to vent!


Update README.md

What changes does this PR do?
Added my name in readme.md

@schmelto and merge it

We need two maintainers to approve a pr before merging it

What about now @schmelto ?

@Panquesito7 can you check the pr?


Resolver is missing slot preDataLoad

Which Category is your question related to?
GraphQL
Amplify CLI Version
7.6.11
What AWS Services are you utilizing?
Provide additional details e.g. code snippets
I'm trying to intercept the record creation process and add a custom logic that would verify if this record can be created by checking the status of corresponding record in another table.
I added preDataLoad slot to /resolvers folder naming it following the recommended naming convention:
Mutation.createXXX.preDataLoad.1.req.vtl
-- but I get the following error  when I try to push or compile locally:
Resolver is missing slot preDataLoad

I'm not sure why, but slots like: preAuth, preDataLoad, postDataLoad, finish are not generated at all...

for mutation resolvers, you need to use the pre/postUpdate slot instead of preDataLoad. pre/postDataLoad only exist for query resolvers.

Thanks. Is there a place in documentation where this is explained?

@edwardfoyle  can you point me to some documentation that explains the usage of pre/postUpdate slots? Not a word about its existence in amplify documentation:
https://docs.amplify.aws/cli/graphql/custom-business-logic/#create-a-custom-query-or-mutation
https://docs.amplify.aws/cli/migration/transformer-migration/#what-are-the-breaking-changes-and-how-do-i-migrate

@josefaidt @marcvberg @renebrandel
Can we please get some documentation on custom VTL resolvers?


MAXO:0035060	Central motor conduction time  study

MAXO:0035060	Central motor conduction time  study
This should be placed under electrophysiology study (new term), defined as a test that measures electrical activity in an organ to assess physiological parameters
also nerve conduction study could be placed here

added in April 2023. closing.


Background Color is not applied to whole font size

Description
Background color is not applied to whole font size.
Steps:

Clear editor
Type two or three words in small font size
change font size to 48px.
Type three or four words
Now apply background color.
Try typing any word

Actual Behavior:
Background color is not applied to full font size
Expected Behavior
Background Color need to be shown for current font size.
Suggestion
<span style:"background-color #xxx; display:'inline-block'" >
PFA

Background Color Issue.zip

The 2.33.0 version has been updated.
If this issue has not been resolved, please reopen this issue.
Thank you.


Problems with bulk removal of certificate owner

Bulk removal of the owner of selected certificates in the web UI certificate inventory is not working.

Workaround would be doing that through REST API, just wanted to report the bug though.


Cannot Find Path ?

I have this issue running the Program on Window 7 Premium, 64 Bits. Even after manually typing in "PATH"

Not sure what else I can do to run this

You need to run the "git bash" program.

it's not ptc-acc-gen that you need in your path, but git itself.
You could use git bash or use one of the GUI listed here :
https://git-scm.com/downloads/guis

Thanks for that, and now there is something else ?

When I tried to create Acc, this is the new error

basically, stop double clicking things, and open git bash and do everything from the command line.

PEBKAC.


It would be nice to have a sample project

I tried the library, but unfortunately I couldn't get it to work with what was described in readme. It would be nice to have a simple sample project on Repostiyory. Thank you.

https://github.com/jbowmanp1107/ImageCropper.Maui/tree/main/ImageCropperDemo

Somehow I didn't see it. Thank you.

When I included the project from nuget, the libraries were not included, I downloaded the source code and compiled it locally and was able to use it by adding it as a reference.
(.net 7 maui app)

V<IP_ADDRESS> has been released and updated to .NET 8. NuGet package should work as expected. If it doesn't work (if using windows Visual Studio to restore). Try running 'dotnet restore --no-cache --force' in the CLI. There is an issue with this package on Visual Studio on windows due to limitation in file lengths.


UUIDs are not handled

BulkSerializerMixin uses get_value() to get the id of an object, but doesn't use to_internal_value() to convert the id to the proper internal value. This works fine for integer ids, but it breaks for UUIDs because the all_validated_data_by_id in BulkListSerializer.update constructs a dict by string id and then tries to get values for instance ids (which are UUIDs and thus not in the dictionary.)

Workaround / solution is to copy BulkSerializerMixin into your app and replace this line:
id_value = id_field.get_value(data)

with this one:
id_value = id_field.to_internal_value(id_field.get_value(data))

Thank you, solved my problem!

Thank you, solved my problem!

This also solved my problem bulk_update & bulk_partial_update fail, but others work fine:
python3.8/site-packages/rest_framework/serializers.py", line 986, in update
for attr, value in validated_data.items():
AttributeError: 'NoneType' object has no attribute 'items'
[17/Mar/2021 22:17:04] "PUT /api/ruleset/ HTTP/1.1" 500 29444


Upgrade to Quarkus 1.13

Quarkus 1.13 changed some classes on how to register. Submitting a PR following how MyFaces did it.

@rmpestano any chance of getting this merged and a a new version on Maven Central?

Hi @melloware, I'll try to do this weekend, we need to release from gh-actions now because bintray is gone

quarkus-omnifaces 1.4.0 should be on maven central in soon

Many thanks I just updated my Quarkus Faces showcase and everything is working with your new JAR and Quarkus 1.13.7


Native module cannot be null

I got this error:

I just installed it with this command: yarn add react-native-nfc-manager
And put this line on my js file: import NfcManager, {Ndef, NdefParser} from 'react-native-nfc-manager'

Hi, when using expo (or create-react-native-app) with this library (or any library with native dependency), you will have to:

first eject, to restore correct project structure with native support
react-native link react-native-nfc-manager to link the native dependency

Thanks!

So i cannot use this with Expo?
I ejected it and than linked it, but it doesnt work, got the same error.

Hi, it should work with Expo. Please check #38 , which is also using Expo and reported to work.
I am personally not using Expo, but I will try that with this lib when I'm available.
Thanks!


Auto-prefixing breaks server-side rendering with "checksum mismatch".

When material-ui is used in isomorphic websites, the following warning is found in the browser console:
Warning: React attempted to reuse markup in a container but the checksum was invalid. This generally means that you are using server rendering and the markup generated on the server was not what the client was expecting. React injected new markup to compensate which works but you have lost many of the benefits of server rendering. Instead, figure out why the markup being generated is different on the client or server:
 (client) ght:24px;width:24px;-webkit-user-select:
 (server) ght:24px;width:24px;user-select:none;fil

It seems that the auto-prefixing module breaks server-side rendering because browser prefix is only prepended in the browser and not on the server.
A plausible way to fix this, mentioned in https://github.com/FormidableLabs/radium/pull/128#issuecomment-98135482, is to provide autoprefixer with user-agent data of the request. Not sure if this is suitable for material-ui though.

Oops, didn't notice #748 . Closing this.


How can I use JSON path as a feature file parameter>

Im not sure this is right place to rise this question, but I feel like this is imported or useful feature and ther should be something about this in readme.
How can I use JSON path as a feature file parameter?
This is my example:
Feature  file:
When I scroll to element "HomePage.section_3_H2"
import HomePage from './../../fixtures/HomePage.json'
When('I scroll to element {string}', (element) => {
cy.get(HomePage[element]).scrollIntoView()
})
Test is failing because we are scrolling to string not value.
Thanks a lot.

Hey @dawidappnovation I think you need to use variable expansion:
Assuming your HomePage.json is something like
{
   "element": ".title-bar"
}

Then this:
cy.get(HomePage[`${element}`]).scrollIntoView()

Should run:
cy.get(".title-bar").scrollIntoView()

@dawidappnovation
You can get the URL of the current page using cy.url(), so something like
cy.url().then((returnedUrl) => {
  cy.log(returnedUrl)
// returns something like http://localhost:3000/admin/users

})

Note, you might need to tinker a little with split I'm not sure if I've escaped the forward slash correctly.

But aliases are super handy for setting context. They stay active during each scenario, letting you pass values between steps:
Given I click "Homepage"
And I fill "Forename" with the text "John"

Given(`I click "{}"`, (linkName) => {
//wrap the name of the link we're clicking for later
cy.wrap(linkName).as('contextPageName')

//click the link
cy.get('.nav-links').contains(linkName).click()

})

And(`I fill "{}" with the text "{}"`, (field, text) => {

      //fetch the alias we created
      cy.get('@contextPageName').then((linkName) => {
        cy.get(linkName[field])
            .type(text,{force: true})
      })

})

If you use that approach, you can build your json out to match the strings you're using:

"Homepage" : {
  "Forename": "#onboarding-forename",
  "Surname": "#onboarding-surname"
}

I really recommend getting a good Udemy course and binge-watching it, there are so many awesome little tricks you'll find.  I personally used this one but there's no shortage of fantastic out there!

This answer is great, I will just set context base on first step
       Given I open the url "/"
This solution will avoid hundreds unnecessary if statements

Getting value from multiple demential JSON => JavaScript Object.
I was trying to figure it out in different ways and this is my solution,
JSON file:
{
    "home": {
        "demo_F": "#demo_form",

Getting value using alias as a parameter.
import prod from './../../fixtures/prod.json'

When('I scroll to element {string}', (element) => {
  //fetch the alias we created in given step
  cy.get('@pageName').then((page) => {
    cy.get(prod[page][element])
      .scrollIntoView()
  })
})

Thank you for helping me with this issue and yes I have right now more then one Udemy course about Cypress.

Happy to help! Enjoy your learning!!


Update user profile on Donation Made

When a user makes a donation on Giveth we should track that user and add them to Ortto - since it not only sends emails but acts as a CDP, allowing us to make future campaigns or communications with them.
However as part of #1239  we no longer send emails to the users for every donation they make. So we will need to use another type of API call to add them into our CDP on Ortto.
To do this we need to call this API when a user makes a donation:
https://help.ortto.com/a-257-create-or-update-one-or-more-people-merge
This needs to get the following info of the donor

Email
First Name
Last Name
totalDonated
userId
donationsCount
date of donation
donation chain
GIVbacks round donated in (if donation was eligible)
QF round donated in (if donation was eligible)

From there we should set the following in the API call:
add these value to the person fields:  (I've included their associated ID)

Email str::email
First Name str::first
Last Name str::last
User ID
totalDonated  int:cm:total-donations-value
donationsCount int:cm:number-of-donations
lastDonationDate dtz:cm:lastdonationdate

add these tags to the person in the same call:

GIVbacks <roundNumber>
QF Donor <roundName>
Donated on <chainName>

merge and find strategy can be left as default and don't need to be defined I think

How can I test this issue? @RamRamez

We don't have a separate environment for staging on Ortto so if we test it on staging, the real users on Ortto will be affected.

How can I test this issue? @RamRamez

We don't have a separate environment for staging on Ortto so if we test it on staging, the real users on Ortto will be affected.

We'll make the fix as we suggested Ramin - so we won't send the userId on staging. it will fallback to using email and should be testable then - please update here when its been changed and can be tested.

How can I test this issue? @RamRamez

We don't have a separate environment for staging on Ortto so if we test it on staging, the real users on Ortto will be affected.

We'll make the fix as we suggested Ramin - so we won't send the userId on staging. it will fallback to using email and should be testable then - please update here when its been changed and can be tested.

Done! @maryjaf You can start testing.
@divine-comedian can you please create an Ortto account for Maryam to test these issues.

@maryjaf pls close the issue once you have tested

@divine-comedian can you please create an Ortto account for Maryam to test these issues?

Please let me know whenever Ortto account will be create.

@divine-comedian can you please create an Ortto account for Maryam to test these issues?

Please let me know whenever Ortto account will be create.

Sent - will follow up with you in DMs

If a user has more than 1 project, the last project that has been created by user is shownin this field
is this a expected result?

I couldn't see these fiels in below link :
-donation chain
-GIVbacks round donated in (if donation was eligible)
-QF round donated in (if donation was eligible)
https://ortto.app/ap2-giveth/cdp/people/0065d6435dd6b39392339500/activities?from=cdp-filter&key=people-all-
and User ID would be set only on production?
@RamRamez

recurring donation also should be shown in this list? @RamRamez @divine-comedian

If a user has more than 1 project, the last project that has been created by user is shownin this field is this a expected result?

I don't know how ProjectTitle is being updated. Maybe @divine-comedian has an idea. However "ProjectTitle" is not related to this issue.

However "ProjectTitle" is not related to this issue.

Yeah but i didn't find an issue related to this field
on  user profile  issue also there isn't this field

4- recurring donation also should be shown in this list? @RamRamez @divine-comedian

I talked with @mohammadranjbarz and when we develop verifying recurring donations, we'll update Ortto too (only those three fields).

2- I couldn't see these fiels in below link : -donation chain -GIVbacks round donated in (if donation was eligible) -QF round donated in (if donation was eligible)
https://ortto.app/ap2-giveth/cdp/people/0065d6435dd6b39392339500/activities?from=cdp-filter&key=people-all-
3- and User ID would be set only on production? because for this user, user ID hasn't been set https://ortto.app/ap2-giveth/cdp/people/0065d6435dd6b39392339500/activities?from=cdp-filter&key=people-all-nela
@RamRamez

Donation chain and Givbacks round are updated in the Tags section. I think there's a bug with QFRound, I'll take a look.

User ID is not updated. On Staging Ortto users may not have User ID assigned but in production all users must have.

Donation chain and Givbacks round are updated in the Tags section. I think there's a bug with QFRound, I'll take a look.

The problem related to QF round has been resolved


Comparators don't compare anything

The following comparator classes don't compare anything:

IncomingProtocolMessageComparator.java
InternalProxyMessageComparator.java
OutgoingProtocolMessageComparitor.java

I understand this is meant to create a FIFO queue from a PriorityBlockingQueue, but this is highly unconventional.  The docs at the Oracle link explains exactly how to implement a FIFO queue:
 class FIFOEntry<E extends Comparable<? super E>>
     implements Comparable<FIFOEntry<E>> {
   static final AtomicLong seq = new AtomicLong(0);
   final long seqNum;
   final E entry;
   public FIFOEntry(E entry) {
     seqNum = seq.getAndIncrement();
     this.entry = entry;
   }
   public E getEntry() { return entry; }
   public int compareTo(FIFOEntry<E> other) {
     int res = entry.compareTo(other.entry);
     if (res == 0 && other.entry != this.entry)
       res = (seqNum < other.seqNum ? -1 : 1);
     return res;
   }
 }

I ran a quick test to see if the current approach actually creates a FIFO queue and it does not.
Here's my quick test code:
import java.util.Comparator;
import java.util.concurrent.PriorityBlockingQueue;

public class Main{

    private static PriorityBlockingQueue<String> theQueue;
    private static String[] queueItems = new String[]{
        "Item 1",
        "Item 2",
        "Item 3",
        "Item 4",
        "Item 5"
    };

    public static class EmptyComparator implements Comparator<String>{
        @Override
        public int compare(String arg0, String arg1){
            return 0;
        }
    }

    public static void main(String[] args) throws InterruptedException{
        theQueue = new PriorityBlockingQueue<String>(5, new EmptyComparator());
        for(int i=0; i<queueItems.length; i++){
            theQueue.put(queueItems[i]);
        }

        while(theQueue.size() > 0){
            System.out.println(theQueue.take());
        }
    }
}

And here is the output of the program:
Item 1
Item 5
Item 4
Item 3
Item 2

This implementation is definitely not operating as a FIFO queue.

If a FIFO queue with no priority of entries is desired, a simple LinkedList should be sufficient.


Add acr_values flag to pass to /authorize call

Currently it's not possible to pass arbitrary acr_values as a query parameter to the /authorize call. Can a -- acr_values flag be added?
cc @piotrek-janus

Hi @timsearle
thanks for reporting this. I've opened a PR.

@timsearle FYI this change as been released as https://github.com/cloudentity/oauth2c/releases/tag/v1.11.0

Thanks a lot!


Disabling editable children reverts to default

Godot version:
3.1 custom c487cce6
Issue description:
I don't understand what is the benefit of reverting parameters changes when editable children is disabled.
My problem is that i have scenes that contain nodes, let's call them objectives. For each objective i might want to tweak the areas(trigger areas). In a scene i might also have collision bounds with the environment.
What i expect is to be able to edit the objective's children (in particular some shapes) and then remove the ability to edit them in order to have less clutter in the 3D scene. If editable children is not ticked for an objective, i can't select the triggers of that objective, which is good if i want ot be able to select something in the 3D scene (some objectives have very big trigger areas that overlap a lot)
#22009 explains why i experienced some data loss during development :(
Proposal
Keep the changes in editable children even if they are folded back.
There are multiple solution to this issue, i think the best one would be to decouple editable children and the editability of the property of a scene (#22263 for reference?)
Could also work with having the ability to say "editable" and "selectable".

This feature is already present for 2D but not for 3D (since Godot 2.1 even).

Maybe I misunder, but I think the main issue is:

What i expect is to be able to edit the objective's children (in particular some shapes) and then remove the ability to edit them in order to have less clutter in the 3D scene.

@asheraryam there was an implicit [without losing my modifications]

@QbieShay The "unselectable children" option was added for 3D in 3.2. Does it resolve the issue?

Given the presence of a dialog box indicating that the reversion is intended behavior, I assume that disabling "Editable Children"i is intended to revert them to default. Hence, I would advocate closing this issue as out of date or "works as intended".

Further, some commenters mis-read the issue as a request for "selectable children". This feature was also already implemented in 3.2
If there are still unresolved problems, they should be re-opened as other issues.
Issue #45915 which I filed is about deselecting "Editable Children" not having an immediate effect until the scene is re-opened. Such issues, in which a feature appears to work one way in memory and differently on disk, can cause confusion because it is difficult for anyone to correlate an action with different effects at an arbitrary later time when the scene is next re-opened.
As exhibited by the widely varying responses to this type of issue, it's hard to improve usability if the editor exhibits inconsistency in its behavior, so I would label any issue in which the in-memory state of a resource differs from the on-disk state as being a usability problem.

Closing as this conflicts with #45915
You can open a proposal if it's still desired: https://github.com/godotengine/godot-proposals
Nodes don't keep track whether property was changed by the user or from some other action like tool script or AnimationPlayer. Implementing this proposal means that either we should keep track whether the property was changed during it was editable or the users would end up with properties that shouldn't be saved in their scene.


customHeaders function

Allow options headers to be a function to retrieve dynamic headers.  Could extend to pass in some context that's useful for understanding headers required for the given request..  Fixes auth header issue as per #301

published in<EMAIL_ADDRESS>


Upgraded to xeus 0.20.0

xeus 0.20.0 is not available on all mirrors yet. I will retrigger the build later


Fixed problem in gcovr where unity.c and cmock.c are reported as part…

… of the coverage metrics
Currently using:
$ ceedling utils:gcov

is including unity.c and cmock.c as part of the coverage statistics. The -e is ill-formed as it is using
-e "'^vendor.*|^build.*|^test.*|^lib.*'"

but needs to be
-e "^vendor.*|^build.*|^test.*|^lib.*"

for the directory exclude to work correctly.
Tested on OSX and Linux.

For me it still include some other files in coverage report...
It seems that gcovr skips the first part of the expression:
tried with
 -e "impossibletofind|^vendor.*|^build.*|^test.*|^lib.*"

and the result is as expected;
testd on the fork here: e45750c369d7ebcd4edfd2ed56fb994d3ed264a6

@nscooling and @afacotti -- is the problem cited a reason to not merge this at this time or is it an additional issue that should also be solved?

I think that the solution in this PR form @nscooling is formally correct and that can be merged: if the problem needs more investigation we'll open an additional issue; probably this will be the next starting point.

Awesome. Thanks for the feedback, @afacotti !


MacOS MoltenVK native libraries should be updated  to 1.1.0

MoltenVK 1.1.0 has been released on Oct 2 that adds Vulkan 1.1 Support and Vulkan SDK 1.2.154.
I'm assuming that the update would be just a bump of libraries in the -natives-macos artifact as lwjgl already supports VK11 on other platforms.

Hey @jessegit, LWJGL 3.3.0 snapshot 8 is now available. It includes Vulkan 1.2.172 and MoltenVK 1.1.2.


Fixed build metadata from tags being discarded.

If a direct tag's version contains a build metadata part, it should be used, and if --build-metadata
or VerliteBuildMetadata has been set too, then they should be concatenated together instead of discarding one
or the other.
New tests have been added to formalize this behavior, and prevent future regressions.

[x] Unit tests or integration tests added
[x] Linked issue if exists
[x] Updated documentation

lgtm!


Can't provide user as target for send_messages

robot.send_message(user, "This should be a private message.")

fails, where user is response.user.
According to the Lita API, this should work: http://www.rubydoc.info/gems/lita/Lita/Robot#send_messages-instance_method
The error it fails with is:
ERROR:  crashed. The exception was:
undefined method `private_message?' for #<Lita::User:0x00562d8bf1abd0>
Full backtrace:
/usr/local/bundle/gems/lita-slack-1.7.2/lib/lita/adapters/slack.rb:50:in `channel_for'
/usr/local/bundle/gems/lita-slack-1.7.2/lib/lita/adapters/slack.rb:29:in `send_messages'
/usr/local/bundle/gems/lita-4.6.1/lib/lita/robot.rb:129:in `send_messages'

I tried to work around it by using Room.find_by_id(user.id) instead, but I received the same error.

I'm using the following workaround for now:
target = OpenStruct.new('private_message?': true, user: user)
      robot.send_message(target, "Here's a private message.")

If no-one else has gotten around to it when I've finished this, I'll try contributing the fix.

The first argument to Robot#send_messages is a Lita::Source object. Just wrap the User in a Source and pass the Source in and it will work.
http://www.rubydoc.info/gems/lita/Lita/Robot#send_messages-instance_method

Thanks, I'm surprised this isn't a little clearer in the Lita docs.

I'd happily accept a PR to https://github.com/litaio/docs.lita.io to make it more clear. Especially if there was a particular section or phrase that mislead you.


Reinforced mapping tests & simplified mapping restore logic.

Tests now check that local-buffer mappings are restored in the correct buffers.
Mapping restoring at termdebug shutdown logic simplified.

EDIT; I am thinking that an even leaner approach would be to move some logic inside the Init function to clean up a bit InstallCommands() and DeleteCommands() (think for example to the logic to set the variable map inside InstallCommands()). It needs more thinking....

thanks!

man, as said #15032 (comment) and many similar tickets on this termdebug topic someone else complained in recent weeks, you donot have to burn on this topic over and over, it actually didnot benefit anything.

IMHO, getting the code as clean as possible helps maintainability. Of course you need good tests/testing to back it up.

ok, i am the one fixed buf local K mapping bug of termdebug, and corrected the recent unmap K err;
as for the tuning the code be beautiful as you guys felt, i left it to you guys, as long as no err/broken. :sweat_smile:
--
shane.xb.qian


enhanced pod eviction capabilities

Description
What problem are you trying to solve?
For Strimzi's Kafka Operator, to achieve HA, it's important to let its operator drain pods based on its internal readiness. To do this, Strimzi recommends using their Drain Cleaner (Strimzi blog post announcement) , which essentially creates a ValidatingWebhook for pod evictions and adds an annotation to the pods (kafka and zookeeper) that it manages. This then means that to make use of the Drain Cleaner that a PDB with maxUnavailable of 0 needs to be set, and, so, this does not allow for karpenter to consolidate any node with kafka or zookeeper pods running on them. Karpenter creates a DeprovisioningBlocked Event for this: "Cannot deprovision node due to pdb -<cluster_name>-zookeeper prevents pod evictions"
Some potential features that could address this: provide a capability for the Provisioner to set a pod annotation to mark a pod for eviction for specific workloads which then may not require the Strimzi Drain Cleaner. I imagine that this would need an accompanying timeout for successful eviction on cordoned nodes. Or, a Provisioner setting to ignore/override PDBs and drain the node anyway, but seems like that would break the PDB contract.
How important is this feature to you?
The workaround for this is to have dedicated hardware sized for the workloads along with a dedicated provisioner that set node taints, but zookeeper, for example, may not require a lot of CPU/memory so this can be considered idle waste.
Ideally, it would be better to have a choice on whether these workloads can run on nodes capable of handling other workloads.

Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
If you are interested in working on this issue or have submitted a pull request, please leave a comment

Just to make sure that I understand correctly, this is effectively an ask to ignore certain PDBs when evaluating nodes for eviction because this PDB is in place so that Strimzi can handle the eviction process when a node eviction is requested and not the standard eviction manager?

This definitely seems like an interesting use-case but I'm curious how common this use-case is in the ecosystem.

does not necessarily correspond to the replicas being in sync

It seems odd to me that Kafka readiness wouldn't be based on the pod actually being fully replicated and being in-sync. Is this something that is being considered upstream in Kafka so that this node drain cleaner component doesn't have to be built on top of the existing eviction manager to handle this case?

Just to make sure that I understand correctly, this is effectively an ask to ignore certain PDBs when evaluating nodes for eviction because this PDB is in place so that Strimzi can handle the eviction process when a node eviction is requested and not the standard eviction manager?

yes.  I am not speaking for their project or anything.

This definitely seems like an interesting use-case but I'm curious how common this use-case is in the ecosystem.

I can think of another possible use. ElasticSearch has an option in its shutdown API for removing/replacing nodes versus an in-place restart, which is more of a consideration for local HostPath volumes vs EBS.
https://www.elastic.co/guide/en/elasticsearch/reference/current/put-shutdown.html
If karpenter deprovisioning was configured with ttlSecondsUntilExpired, a 'replace' would be appropriate instead of the 'restart' default, but currently, it appears that ECK only allows for one setting via an env var on the running container:
https://www.elastic.co/guide/en/cloud-on-k8s/2.8/k8s-prestop.html
There may be other HA data storage services that handle their own orchestration. I had a thought that PodSpec could be enhanced with something like a "disruptableness" to indicate whether an application is not able to handle a disruption while still be ready to service requests. Or, including the Elastic case, now, "drainableness". For Kafka , I could see a pod marking itself as "drainable" once all the replicas are rebalanced off.


doc(MeasureSpace): document notation eventually/frequently

And add a section ae grouping material related to the a.e. filter.

Thanks, both of you, for the quick review!
bors r+


Don't try to include JS no longer present in pywb

This matches all .js files currently present on pywb/static
Currently broken after merging: https://github.com/hypothesis/viahtml/pull/228
Testing notes

make build
'tis broken

Merging this PR as it is. Following with one to dynamically include all the js files.


Presidio should be scanned using a static code analysis tool

Is your feature request related to a problem? Please describe.
code should be scanned using SAST for code security vulnerabilities.
Describe the solution you'd like
A SAST tool is used during PR review pipelines.
Describe alternatives you've considered
sonar, codeQL, other
Additional context
https://bestpractices.coreinfrastructure.org/en/criteria/0

closed by PR #871


VW: Add 3C for Passat in Australia

For 340ebc76c286aedc. Looks like the previous gen platform code (2005), but Australia is using it in their VINs. https://www.service.transport.qld.gov.au/checkrego claims it's a 2018 VOLKSWAGEN PASSAT WAGON.

@jyoung8607 what happens if real 3C cars would fingerprint with this, a CAN error?

At a glance it looks like the 3G platform code never made it into the VIN for 7th and 8th generation, stayed on the prior 3C chassis code. 6th and 7th gen are very very similar, 7th is almost a 6th gen facelift. Not sure why they didn't change with the 8th.
A PQ platform 6th/7th gen Passat will definitely CAN error if identified as a MQB 8th gen. We can live with that for now because PQ is in dashcam, but must be fixed before it can exit dashcam.


Test cleanup

Description
Test clean and CI test run
Test Plan
It's a test

If your changes are not user-facing and not a breaking change, you can skip the following section. Otherwise, please indicate what changed, and then add to the Release Notes section as highlighted during the release process.
Type of Change (Check all that apply)

[ ] user-visible impact
[ ] breaking change for a client SDKs
[ ] breaking change for FNs (FN binary must upgrade)
[ ] breaking change for validators or node operators (must upgrade binaries)
[ ] breaking change for on-chain data layout
[ ] necessitate either a data wipe or data migration

Release notes

@tnowacki forgot to do this cleanup before I committed gas smashing


error while converting *.pb file to *.tflite with toco

I used the following example to create tensorflow model: http://cv-tricks.com/tensorflow-tutorial/training-convolutional-neural-network-for-image-classification/
You can download the code from here: https://github.com/sankit1/cv-tricks.com/tree/master/Tensorflow-tutorials/tutorial-2-image-classifier
Also I used "2. Freezing the graph" section from http://cv-tricks.com/how-to/freeze-tensorflow-models/
to create a *.pb file of my model.
I have Ubuntu 16.04 and tensorflow cpu version 1.8.0 from binary. python version is 3.5.2 and bazel 0.13.0.
I'm tried to convert *.pb file with toco command line tool, as describe on "Convert a TensorFlow SavedModel to TensorFlow Lite" at https://github.com/tensorflow/tensorflow/blob/master/tensorflow/contrib/lite/toco/g3doc/cmdline_examples.md#savedmodel
and got he following error:
(venv) user@user-desktop:~/PycharmProjects/tensorflow_tutorial/tensorflow$ bazel run -c opt   tensorflow/contrib/lite/toco:toco --   --savedmodel_directory=/home/user/PycharmProjects/tensorflow_tutorial/tutorial-2-image-classifier   --output_file=/home/user/PycharmProjects/tensorflow_tutorial/tutorial-2-image-classifier/dogs-cats-model.tflite
WARNING: /home/user/.cache/bazel/_bazel_user/e21a56d90e65395c94952f8aa3d0c4bc/external/protobuf_archive/WORKSPACE:1: Workspace name in /home/user/.cache/bazel/_bazel_user/e21a56d90e65395c94952f8aa3d0c4bc/external/protobuf_archive/WORKSPACE (@com_google_protobuf) does not match the name given in the repository's definition (@protobuf_archive); this will cause a build error in future versions
INFO: Analysed target //tensorflow/contrib/lite/toco:toco (0 packages loaded).
INFO: Found 1 target...
WARNING: failed to create one or more convenience symlinks for prefix 'bazel-':
cannot create symbolic link bazel-out -> /home/user/.cache/bazel/_bazel_user/e21a56d90e65395c94952f8aa3d0c4bc/execroot/org_tensorflow/bazel-out:  /home/user/PycharmProjects/tensorflow_tutorial/tensorflow/bazel-out (File exists)
cannot create symbolic link bazel-out -> /home/user/.cache/bazel/_bazel_user/e21a56d90e65395c94952f8aa3d0c4bc/execroot/org_tensorflow/bazel-out:  /home/user/PycharmProjects/tensorflow_tutorial/tensorflow/bazel-out (File exists)
cannot create symbolic link bazel-tensorflow -> /home/user/.cache/bazel/_bazel_user/e21a56d90e65395c94952f8aa3d0c4bc/execroot/org_tensorflow:  /home/user/PycharmProjects/tensorflow_tutorial/tensorflow/bazel-tensorflow (File exists)
cannot create symbolic link bazel-bin -> /home/user/.cache/bazel/_bazel_user/e21a56d90e65395c94952f8aa3d0c4bc/execroot/org_tensorflow/bazel-out/k8-opt/bin:  /home/user/PycharmProjects/tensorflow_tutorial/tensorflow/bazel-bin (File exists)
cannot create symbolic link bazel-testlogs -> /home/user/.cache/bazel/_bazel_user/e21a56d90e65395c94952f8aa3d0c4bc/execroot/org_tensorflow/bazel-out/k8-opt/testlogs:  /home/user/PycharmProjects/tensorflow_tutorial/tensorflow/bazel-testlogs (File exists)
cannot create symbolic link bazel-genfiles -> /home/user/.cache/bazel/_bazel_user/e21a56d90e65395c94952f8aa3d0c4bc/execroot/org_tensorflow/bazel-out/k8-opt/genfiles:  /home/user/PycharmProjects/tensorflow_tutorial/tensorflow/bazel-genfiles (File exists)
Target //tensorflow/contrib/lite/toco:toco up-to-date:
/home/user/.cache/bazel/_bazel_user/e21a56d90e65395c94952f8aa3d0c4bc/execroot/org_tensorflow/bazel-out/k8-opt/bin/tensorflow/contrib/lite/toco/toco
INFO: Elapsed time: 0.271s, Critical Path: 0.00s
INFO: 0 processes.
INFO: Build completed successfully, 1 total action
INFO: Running command line: /home/user/.cache/bazel/_bazel_user/e21a56d90e65395c94952f8aa3d0c4bc/execroot/org_tensorflow/bazel-out/k8-opt/bin/tensorflow/contrib/lite/toco/toco '--savedmodel_directory=/home/user/PycharmProjects/tensorflow_tutorial/tutorial-2-image-classifier' '--output_file=/home/user/PycharmProjects/tensorflow_tutorial/tutorial-2-image-classifier/dogs-cats-model.tflite'
2018-05-07 01:33:13.776954: F tensorflow/contrib/lite/toco/toco_saved_model.cc:34] Check failed: tensorflow::MaybeSavedModelDirectory(model_path) Model is not saved in the supported SavedModel format.
The function which throw this error is MaybeSavedModelDirectory at
https://github.com/tensorflow/tensorflow/blob/master/tensorflow/contrib/lite/toco/toco_saved_model.cc
I took a look at the implementation of it on
https://github.com/tensorflow/tensorflow/blob/master/tensorflow/cc/saved_model/loader.cc
Actually it looking for *.pb or *.pbtxt file on the model directory. I got this file at this location so why I get this error?

Thank you for your post. We noticed you have not filled out the following field in the issue template. Could you update them if they are relevant in your case, or leave them as N/A? Thanks.
Have I written custom code
OS Platform and Distribution
TensorFlow installed from
TensorFlow version
Bazel version
CUDA/cuDNN version
GPU model and memory
Exact command to reproduce

Lets do it again:
OS Platform and Distribution - ubuntu x64
TensorFlow installed from - pip
TensorFlow version - cpu version 1.8.0
Bazel version - 0.13.0
CUDA/cuDNN version - no cuda
GPU model and memory - no gpu
Exact command to reproduce - no need
I solved it. I should save the pb file as saved_model.pb exactly. it works now. thanks!

Lovely. Thanks for the update.

hello. im having different error but the same implementation of the code. i used:
bazel run -c opt tensorflow/contrib/lite/toco:toco -- --savedmodel_directory=C:\Users\LENOVO-PC\DIZIZIT\saved_model -- output_file=C:\Users\LENOVO-PC\DIZIZIT\saved_model\maonani.tflite since im using windows 10 and run it on cmd at C:\Users\LENOVO-PC\tensorflow> directory. my error is
`ERROR: C:/users/lenovo-pc/_bazel_lenovo-pc/buizwhxs/external/protobuf_archive/BUILD:278:1: C++ compilation of rule '@protobuf_archive//:protoc_lib' failed (Exit -1)
The target you are compiling requires Visual C++ build tools.
Bazel couldn't find a valid Visual C++ build tools installation on your machine.`
BUT I already installed Visual Studio Build Tools 2017 (2)