stack.env does not work

Bug description
Following along with the tutorial here: https://www.portainer.io/blog/using-env-files-in-stacks-with-portainer I get stack.env: no such file or directory
Expected behavior
stack.env should work as per the above blog post.
Portainer Logs
level=info msg="2022/03/28 12:47:58 http error: Unable to start stack (err=open /data/compose/51/stack.env: no such file or directory"
level=info msg="2022/03/28 12:47:57 http error: Unable to start stack (err=open /data/compose/51/stack.env: no such file or directory"
level=info msg="2022/03/28 12:52:49 http error: open /data/compose/57/stack.env: no such file or directory"
level=info msg=" (err=open /data/compose/57/stack.env: no such file or directory"
level=info msg=") (code=500)"
level=info msg=" (err=open /data/compose/51/stack.env: no such file or directory"
level=info msg="2022/03/28 12:49:46 http error: open /data/compose/51/stack.env: no such file or directory"
level=info msg="2022/03/28 12:53:58 http error: open /data/compose/58/stack.env: no such file or directory"
level=info msg=" (err=open /data/compose/58/stack.env: no such file or directory"
level=info msg="2022/03/28 12:49:31 http error: open /data/compose/51/stack.env: no such file or directory"
level=info msg="2022/03/28 12:48:45 http error: Unable to start stack (err=open /data/compose/51/stack.env: no such file or directory"
level=info msg="2022/03/28 12:48:25 http error: Unable to start stack (err=open /data/compose/51/stack.env: no such file or directory"

Steps to reproduce the issue:
Be running in swarm mode.
Create a new stack with the content.
version: "3.8"

services:
  test:
    env_file:
      - stack.env

Add at least one environment variable to the environment variables section.
Try to deploy.
Technical details:

Portainer version: Portainer CE 2.11.0
Docker version (managed by Portainer): API version 1.41
Platform (windows/linux): linux
Command used to start Portainer (docker run -p 9443:9443 portainer/portainer): Uhh, it's been running for a while as a stack...
Browser: Firefox
Use Case (delete as appropriate): Using Portainer at Home
Have you reviewed our technical documentation and knowledge base? Yes

Additional context
Assessing the possibility of running a dockerized mail server through portainer for my employer.

same issue here

Seeing the same behavior on EE 2.12.1

Ditto on EE 2.12.1, running on a swarm
When I go into the portainer vol, the compose folder that it's looking for doesn't exist. If I create the stack and then add env_file to the compose, it's never created in the compose folder created for the id.
If I create an empty file in that folder the stack is able to be updated with the env_file definition, but the file isn't updated with the env set in the gui.

Only way I have been able to get this to work is by passing
-v /opt/data/env.json:/opt/data/env.json to the portainer server container. That hack doesn't work with portainer-agent though, seems like the server tries to get the file from it's local fs instead of the agent fs.

Same issue for 2.13.1 on EE. I had to revert to specifying environment variables manually... If anyone needs to quickly generate required YAML, you can use the following.
Switch to "Advanced Mode" copy everything into a file somewhere (i.e. /tmp/z).
EXAMPLE
$ cat /tmp/z
VAR1="TEST"
VAR2="TEST"

awk -F= 'BEGIN{print "    environment: "}{print "      "$1": \"${"$1"}\""}' /tmp/z

Which should output
    environment:
      VAR1: "${VAR1}"
      VAR2: "${VAR2}"

to me,  the error reason was the path of docker-compose.yml(using git repository), seted on Compose path field
Compose path: /some-project/docker-compose.yml
Before:
version: '3.4'
services:
  some-project:
    env_file:
      -  stack.env
    build:
      context: .
    image: some-project
    restart: always
    ports:
      - '8080:80'

After(Working):
returning to the root directory with ../stack.env
version: '3.4'
services:
  some-project:
    env_file:
      - ../stack.env
    build:
      context: .
    image: some-project
    restart: always
    ports:
      - '8080:80'

Obs: I know it doesn't answer your question, but it could be related.

My problem is that when you specify env_file: myvars.env
The server works fine, but the agent uses the same env instead of its local one. :-S

Obs: I know it doesn't answer your question, but it could be related.

Unfortunately, correct, I'm not specifying a local directory/project. Just letting Portainer manage everything (using its own volume) when I enter in the environment fields.
Another solution was to manually add the "stack.env" file into Portainer's volume... which defeats the purpose of managing stacks through Portainer IMO.

I am also experiencing the same issue, referencing 'stack.env' as per the blog post results in an error:
open /data/compose/89/stack.env: no such file or directory

Blogpost has been updated to reflect that this currently only works for Docker Standalone and not for Docker Swarm.

@samdulam It also doesnt work for portainer agents, only the server.

@gaby
I wanted to follow up on this request.  I created a New Environment >> Docker Standalone >> Agent >> Create Stack >> Docker Compose >> Load stack.env >> without issue.  If you are using the Docker Swarm >> Agent >> the stack.env will not work.
Thanks!

Tried using local (docker.sock) environment and Portainer agent environment. Both give errors saying stack.env can't be found.
With portainer agent, it worked after trying the suggestion from JuniorC07. changing the path of stack.env to ../stack.env

Hello, just a couple more, hopefully useful, use cases :)
Using "stack.env" does not currently work when:

Using Portainer CE 2.16.1
Using a Docker Standalone environment
Trying to deploy a stack through a git repository.

It does work, however, by using "../stack.env" as path instead.

Using "stack.env" on the other hand, works just fine when:

Using Portainer CE 2.16.1
Using a Docker Standalone environment
Trying to deploy a stack directly with Web editor.

@Klionheart
Thank you for the additional information.  I am going to further investigate the stack.env with Git.  Updates to follow.
Thanks!

@Klionheart
Is this what you are trying to do here:

Thanks!

Hey, just wanted to say that I have the same problem. I'm deploying a docker-compose.yml file that sits in a subdirectory of a git repo. Trying to use stack.env doesn't work but ../stack.env does

@Klionheart
Is this what you are trying to do here:

Thanks!

@tamarahenson the idea is to do:

where the docker-compose.yaml referenced is:
`version: "3"
volumes:
db-data:
services:
db:
image: postgres:12
volumes:
- db-data:/var/lib/postgresql/data
environment:
- POSTGRES_DB=$DB_NAME
- POSTGRES_PASSWORD=$DB_PASSWORD
web:
image: healthchecks:v2.4.1
env_file:
- stack.env
[...]
`
which should work according to https://www.portainer.io/blog/using-env-files-in-stacks-with-portainer
but results in error:
error: open /data/compose/51/stack.env: no such file or directory
If I put "- ../stack.env" as the env_file in the compose.yaml, instead, it works, I guess because the stack.env file is generated as /data/compose/stack.env.
Interestingly, if I just use the same docker-compose.yaml directly in portainer (with Web Editor) it instead works with "- stack.env" as expected.

Hi again @tamarahenson,
I think I see the misunderstanding here.
I'm not trying to reference an existing "stack.env" inside the git repository. In fact I absolutely do not want an .env file in the git repository since it contains secrets.
The idea is to do as documented in https://www.portainer.io/blog/using-env-files-in-stacks-with-portainer
where it is explained that you can add Environment variables to the local Portainer stack, and then reference them en masse by using "stack.env" as an env_file, instead of manually referencing them one by one, in the docker-compose.yaml.
This indeed works with Web editor in Docker Standalone, but not in "Repository" mode where you need to use "../stack.env" instead.
Hopefully this is more clear, thank you for your time :)

@Klionheart
Thank you for the additional information.  I figured out how to reproduce this.
[1] I changed the name of my stack.env to stack.env.bak in  my repo
[2] Create Stack with wordpress.yml in my repo using - stack.env
[3] Upload my local stack.env
[4] Received error
[5] Updated my wordpress.yml to - ../stack.env
[6] Deployed without error
TODO:  Update our Blog with further instructions for Git Repositories
Thanks!

Tried using local (docker.sock) environment and Portainer agent environment. Both give errors saying stack.env can't be found.
With portainer agent, it worked after trying the suggestion from JuniorC07. changing the path of stack.env to ../stack.env

I am experiencing the exact opposite on Portainer 2.16.2, Docker Standalone environment connected through portainer/agent:latest:

env_file: stack.env works
env_file: ../stack.env -> file not found

This thread and the documentation could really use some clarification on this.

My workaround is manually insert stack.env file inside portainer's docker volume then i updated related docker stack and now it works.

@fcaspani01 nice that it works but extremely bodgy and non-portable workaround.

hi, I've also got the portainer/portainer-ee:latest container with a local docker environment controlled via /var/run/docker.sock on my Synology NAS and also encountered the problem with the stack.env parameter. If it is just stack.env it will fail, but ../stack.env will work just fine.
Stacks are also deployed via Git reference.

There currently is a difference on using  env_file: stack.yml between Portainer on Docker Standalone and Portainer on Docker Swarm, see also #6814.
According to this other issue it is "due to a lack of env file support in docker stack deploy".
But I think there are some big misunderstandings between using a .env file to substitute/insert values into a docker-compose.yml and using an env_file for directly inserting environment variable into a container.
It's perfectly valid and possible to to the latter. Assume a stack.yml (or docker-compose.yml, the file name does not matter) contains:
version: '3.8'

services:
  test:
    image: ubuntu
    command: env
    env_file: stack.env

And there is a stack.env file containing e.g.:
MYVAR1=something
FOO=bar

Running docker stack deploy -c stack.yml test succeeds and prints in the log:
<EMAIL_ADDRESS>  | PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin
<EMAIL_ADDRESS>  | HOSTNAME=9194cb8346cc
<EMAIL_ADDRESS>  | FOO=bar
<EMAIL_ADDRESS>  | MYVAR1=something
<EMAIL_ADDRESS>  | HOME=/root

I guess i have the same issue on a standalone portainer.
I want to deploy invoiceninja, which intents you to have all configuration made outside of the docker-compose.yml-file.
I have a special path-system to manage my volumes and compose-files:
/mnt/docker/compose/XYZ/docker-compose.yml, config and stuff
/mnt/docker/volume/XYZ/data / sql / app
As i insert the docker-compose.yml into the webUI, i changed "env_file: env" to "env_file: /mnt/docker/compose/invoiceninja/env" but i get the error "File not found".

I tripple checked the path and used copy and paste, but it seems portainer wont find the env-file.

I guess i have the same issue on a standalone portainer. I want to deploy invoiceninja, which intents you to have all configuration made outside of the docker-compose.yml-file. I have a special path-system to manage my volumes and compose-files:
/mnt/docker/compose/XYZ/docker-compose.yml, config and stuff /mnt/docker/volume/XYZ/data / sql / app
As i insert the docker-compose.yml into the webUI, i changed "env_file: env" to "env_file: /mnt/docker/compose/invoiceninja/env" but i get the error "File not found".

I tripple checked the path and used copy and paste, but it seems portainer wont find the env-file.

As far as i now, the referenec path should be relative to the compose-File, so in your example  "env_file: .env" should work.

For some reason I have no luck using stack.env or ../stack.env. Both result in file not found. I tried the web editor and also uploading my own compose file. Any ideas?
Portainer 2.16.1, Docker Standalone environment.

Could anyone from Portainer reproduce this behaviour and let us know if this is a bug while searching for the "env"-file with absolute Path?
Would like to know if i need to reconstruct my environment or if i have to stick with my workaround.
Thanks!

We are also seeing this issue and we are very certain this feature has worked before.

Hello, trying to deploy Authentik I encountered this problem as well. I have tried to copy the .env file outside /root folder, chmod g-wx .env and load it from there, but I keep getting the same error. Tried to recycle the variables using Advance mode, but still no-go.

Pretty much if any of the Host->Setup Docker Security settings are enabled, this feature won't work. It works ootb for me on docker.sock

Any updates on this? It is reproducible for me in Portainer Business Edition 2.18.3

What fixed it for me is in the compose web editor in Portainer, I changed:
env_file:       - .env
to
env_file:       - stack.env
I am using Portainer Community Edition 2.18.3.

It seems Portainer itself is checking the existence of env_file entries. Since Portainer is running as a container, it can't find the files unless you add a volume to the host file.
Example solution:
Your stack:
version: '3.9'

services:
  foo:
    image: foo:latest
    env_file:
      - /opt/portainer-config/my-stack-config/foo.env

Portainer stack:
# ...

  portainer:
    image: portainer/portainer-ce:2.18.4
    command: -H tcp://tasks.agent:9001 --tlsskipverify
    ports:
      - "9443:9443"
      - "9000:9000"
      - "8000:8000"
    volumes:
      - /var/run/docker.sock:/var/run/docker.sock:ro
      - portainer_data:/data
      - /opt/portainer-config:/opt/portainer-config:ro # Paths must match!
# ...

Important:

The path inside portainer MUST equal the path on the host.
The .env file:s must exist on every single node on which the stack may run. Think about an cifs volume or something similar.

This bug just randomly started affecting us. We are using Docker standalone. After some quick testing, it seems that using stack.env is no longer compatible with "Enable relative path volumes" when deploying from a repository. If I disable relative path volumes, it deploys. This combination worked before without issue, but I can't even clone the stack that originally worked on now. I simply get the error that stack.env could not be found.
None of the workarounds here work for me. I tried ../stack.env, didn't work. I originally had the host filesystem mounted into /host but I tried removing that and mounting the relative path location (just /mnt) into Portainer, didn't work. I even tried manually creating the file as a dirty fix, but Portainer just deletes it and then complains it doesn't exist.

None of the workarounds here work for me. I tried ../stack.env, didn't work. I originally had the host filesystem mounted into /host but I tried removing that and mounting the relative path location (just /mnt) into Portainer, didn't work. I even tried manually creating the file as a dirty fix, but Portainer just deletes it and then complains it doesn't exist.

Have you tried to mount the path identically as in my example above? It's important that the path inside the portainer service matches the path on the host machine.

Hello,
Using docker swarm on the latest BE.
Got the same issue about stack.env not being found in /data/compose/[...]
I took a look into portainer volume, but it looks like the stack.env is not generated. I can only found the docker-compose.yml file.

This bug just randomly started affecting us. We are using Docker standalone. After some quick testing, it seems that using stack.env is no longer compatible with "Enable relative path volumes" when deploying from a repository. If I disable relative path volumes, it deploys. This combination worked before without issue, but I can't even clone the stack that originally worked on now. I simply get the error that stack.env could not be found.
None of the workarounds here work for me. I tried ../stack.env, didn't work. I originally had the host filesystem mounted into /host but I tried removing that and mounting the relative path location (just /mnt) into Portainer, didn't work. I even tried manually creating the file as a dirty fix, but Portainer just deletes it and then complains it doesn't exist.

I just encountered the exact same conditions here. The stack won't deployed (the stack.env not found) when I enabled the relative path volumes.

It's a bit disappointing to see this issue still being open. I am happy to provide a reproduction if needed but this is a long-term dealbreaker for us.

Can you give details of the stack? Include screenshots of the repo folder structure along with Stack config screen in Portainer.
I'll try and look into all the different examples and come back to you with an update.
Also don't forget to mention the platform details: Docker Standalone / Swarm, OS and CPU Architecture.
If you are using relative paths then details of that too.. whether that path is local disk or a NFS/CIFS mount

On my end this is easily reproduced using the following:
Docker Standalone, using a server & a couple agents
CPU Arch: x86_64
Relative path: /mnt/portainer on local filesystem
Brand new repo with only example.yml: https://github.com/portainer/portainer/assets/81395386/c988aa42-3a7f-4823-8bf1-1d165102f630
Full portainer config screen: https://github.com/portainer/portainer/assets/81395386/8dc12d24-f044-4a28-972f-103194877433
example.yml itself contains only the following:
services:
  hello_world:
    image: hello-world
    env_file:
      - stack.env

The error: https://github.com/portainer/portainer/assets/81395386/10d641c4-414a-47f1-8554-d667eba3e2e9
Either removing the env_file entry or disabling relative paths results in a successful deployment. Combining the two results in an error. This worked previously, as I had a stack configured that way which broke not too long ago. I could no longer pull and redeploy that stack, or create a new stack with the same config.
I tried rolling back the versions to test but it resulted in some instability. I haven't had time to spin up fresh environments to play with and see if I can figure out when it broke.

When was the relative paths feature introduced?
For us it seems like this

Our original stack was created before this feature was released
After the feature was introduced (and old stacks taking a default I guess?) things broke
Deleting and recreating the stack under same name (with relative paths off) seems to have fixed the problem.

@UrsaSolar
When you don't have a stack.env file in the repo, why are you referencing it in the compose YAML?
Are you using EXAMPLE_VAR in the compose for variable substitution?

@darioackermann
Relative paths support was introduced in 2.17 and it does not get turned on by default.
Do you also reference stack.env in the compose file but not have it in the repo? If so, why?

@UrsaSolar When you don't have a stack.env file in the repo, why are you referencing it in the compose YAML? Are you using EXAMPLE_VAR in the compose for variable substitution?

Maybe because the documentation states that this file is generated by portainer when deploying a stack ?

@Geekimo
Can you send me a link to that document please?

@samdulam https://docs.portainer.io/user/docker/stacks/add#:~:text=Alternatively%2C on Docker Standalone environments you can add stack.env as an env_file definition to add all the environment variables that you have defined individually as well as those included in an uploaded .env file%3A
@UrsaSolar is using Docker standalone, so it should work in his case nope ? In my case it looks like there is an issue regarding docker stack support of env_file, but if it is not supported, why am I having an error with docker trying to load the file ?

I can see the problem.
When deploying a stack using web editor you can define Env Vars in Portainer UI and refer to a stack.env file. Portainer then creates a stack.env file along with the compose file and writes all the vars to that.
This is not the case when deploying from Git, if you refer to stack.env it is expected to be in the repo. We clone the repo but do not add any files to that location as it will get overridden at next update.
We should however clarify this in the documentation.

@darioackermann Relative paths support was introduced in 2.17 and it does not get turned on by default.
Do you also reference stack.env in the compose file but not have it in the repo? If so, why?

We had an empty stack.env in our repo, containing a comment stating it is a placeholder.  The point of it being empty is that we do not want to expose credentials (in our case AWS Credentials) in our git repo, but rather add it through the portainer GUI. This seems to have worked before.

This is not the case when deploying from Git, if you refer to stack.env it is expected to be in the repo. We clone the repo but do not add any files to that location as it will get overridden at next update.

I see the point and I generally agree it makes sense, but I'd consider it an awesome feature to enable this for git-deployed stacks as well - such that exposing credentials on git is not necessary.

@darioackermann
You should not see any error as long as  stack.env exists even if its empty.
If you are adding AWS creds as ENV vars in Portainer UI, how are they then referred in the compose YAML?

Hi guys,
I am having the same issue. But I am not deploying from repository.
Am I right that I should be able to :

Create a stack using Portainer
Use "advanced env vars" editor bellow stack, to add all my environment variables
I then should be able to use env_file: stack.env in my docker-compose, so my env vars added in Portainer UI are used in one or more containers.

Am I doing something wrong ?
I see everyone talk about repositories and "relative path", but I think this usage is supported too, right ?
Thanks a lot

Hi guys,
I am having the same issue. But I am not deploying from repository.
Am I right that I should be able to :

Create a stack using Portainer
Use "advanced env vars" editor bellow stack, to add all my environment variables
I then should be able to use env_file: stack.env in my docker-compose, so my env vars added in Portainer UI are used in one or more containers.

Am I doing something wrong ? I see everyone talk about repositories and "relative path", but I think this usage is supported too, right ?
Thanks a lot

should work for docker but won't work for docker swarm.

Hi guys,
I am having the same issue. But I am not deploying from repository.
Am I right that I should be able to :

Create a stack using Portainer
Use "advanced env vars" editor bellow stack, to add all my environment variables
I then should be able to use env_file: stack.env in my docker-compose, so my env vars added in Portainer UI are used in one or more containers.

Am I doing something wrong ? I see everyone talk about repositories and "relative path", but I think this usage is supported too, right ?
Thanks a lot

should work for docker but won't work for docker swarm.

Oh right, so that is my problem. Don't think it's well documented.
So with Docker Swarm, the only way to use environment variable editor from Portainer, is to add all env vars to editor, and then use them in docker-compose.yaml with $ ?
Thanks, it seems it is clear in comments : https://www.portainer.io/blog/using-env-files-in-stacks-with-portainer

@darioackermann You should not see any error as long as stack.env exists even if its empty. If you are adding AWS creds as ENV vars in Portainer UI, how are they then referred in the compose YAML?

We add env_file to the service
  service-that-needs-aws-creds:
    image: xyz.dkr.ecr.eu-central-1.amazonaws.com/xyz
    build: ./services/xyz/                              # for docker-compose build
    environment:
      - CUSTOM_ON_404=index.html
      - ....
    env_file:
      # Secrets in Portainer
      - stack.env
    restart: unless-stopped

This seems to be working with relative paths off and after recreating the stack from scratch.
So our issue seems resolved.

The solution I'm using is to consume the portainer API directly from the pipeline of a git repository. So to create a stack I place the environment variables as secrets variables (Gitlab>Conf>CI/CD>secrets) in the repository, this allows me to obfuscate their call during execution. And then I add them as complementary variables via payload using the parameters below.
"env": [
{
"name": "test_CI_gitdefined",
"value": "value_test_CI_gitdefined"
}
https://app.swaggerhub.com/apis/portainer/portainer-ce/2.19.1#/stacks/StackCreateDockerSwarmRepository
And then in docker-compose.yml:
environment:
MY_ENVIRONMENT_VARIABLE: ${test_CI_gitdefined}
This was the only way to do GitOps using Git+Portainer+Swarm.
To make this work well, I also wrote extra code to consume this API and make the pipeline magic work.
I think that the passage of variables could be better adapted by the portainer team. this is an important feature

volumes:
  - /opt/portainer-config:/opt/portainer-config:ro # Paths must match!

...

The path inside portainer MUST equal the path on the host.

Thank you! I didn't even think about the fact that portainer itself is a container and the fact that by default it might assume the pathing provided in env_file is a portainer container path and not a host path.
I added /nfs/configs:/nfs/configs:ro as one of my portainer bind mounts and then immediately all of my .env files starting with /nfs/configs pathing were found.

It seems the issue is caused by the env file not being generated (or accessible) across nodes in a swarm. I ended up manually putting the stack.env onto the portainer data volume, into the appropriate compose folder.

Seems like a bug. Trying to deploy on CE v2.19.4, and the Stack YAML editor says To reference the .env file in your compose file, use ‘stack.env’., but doing just that causes open /data/compose/3/stack.env: no such file or directory and it is not possible to update/deploy the stack.

Same issue...

Same issue, had to manually put the .env file under the folder it is complaining about.

@christianstrauch, @ecker00 and @voslucas : Did you tried this? https://github.com/portainer/portainer/issues/6701#issuecomment-1704036982
Portainer itself is running as a docker service, which means that you need to add volumes that matches the host path. Otherwise portainer can not "see" the files 🙂

Seems like a bug. Trying to deploy on CE v2.19.4, and the Stack YAML editor says To reference the .env file in your compose file, use ‘stack.env’., but doing just that causes open /data/compose/3/stack.env: no such file or directory and it is not possible to update/deploy the stack.

Same issue with me. I spend the whole day yesterday trying to fix this. Issue remains with no proper solution

"you can also take note of the missing file error, and recreate the path adding +1 to the path in the portainer container files"
what do you mean add +1, can you give an example?

"you can also take note of the missing file error, and recreate the path adding +1 to the path in the portainer container files"
what do you mean add +1, can you give an example?

Yes and sorry for not including it originally.
When a new stack is deployed, it gives a number to the path:
/data/compose/3/stack.env: no such file or directory
So I noticed that if you wish to redeploy it with the env file on the server, you need to place the env file under the next one:
/data/compose/4/stack.env: no such file or directory
I hope this helps

I just got hit with this.  The weird thing was the /data/compose/X/v1/stack.env (or v2, v3, etc) exists, but if I copy it to /data/compose/X/stack.env then I can deploy the stack.
I've been using portainer for ages and this just happened to me today.

I just got hit with this. The weird thing was the /data/compose/X/v1/stack.env (or v2, v3, etc) exists, but if I copy it to /data/compose/X/stack.env then I can deploy the stack.
I've been using portainer for ages and this just happened to me today.

Same here :(

I just got hit with this. The weird thing was the /data/compose/X/v1/stack.env (or v2, v3, etc) exists, but if I copy it to /data/compose/X/stack.env then I can deploy the stack.
I've been using portainer for ages and this just happened to me today.

Same here :-(
My local /data/compose directory contains no single stack.env file. I am using the web editor which states "stack.env is created automatically". This is obviously a lie.

Hello guys,
This issue happens because you are indicating there is a .env file to include in your composer code.
It is not needed at all to indicate you have a ".env" file, if you click on the option to import variables from env file, all the variables in the file will be included so you don't need to include the env file on the code, I'm posting this from my phone, but let me know if you need a video example

I think there is very much confusion in this thread as there are many different constellations available:

Docker Standalone vs. Docker Swarm (and maybe even Kubernetes)
Deployment using Web editor/Upload/Custom template vs. Deployment via Repository

I'll try to explain some things (and in turn also make it clearer for myself).
Docker Standalone
Deployment using Web editor
Defining environment variables:

You can either specify as many environment variables as you'd like manually using the Add an environment variable button.
OR

Use the Load variables from .env file button to upload an existing env file from your local computer. Portainer then reads this and puts all the values in the web form.

In both cases the result is the same (expand to view screenshot).

Using the environment variables:
You can now choose between using them separately or as a whole stack.env.

Using them separately:
Specify the environment variables like in this example compose file:
services:
  test-service:
    image: ubuntu
    command: bash
    stdin_open: true
    tty: true
    environment:
      - FOO=${FOO}
  service-with-user-and-password:
    image: ubuntu
    command: bash
    stdin_open: true
    tty: true
    environment:
      - USERNAME=${USERNAME}
      - PASSWORD=${PASSWORD}

(command, stdin_open and tty are only needed to prevent the container to automatically exit when using the ubuntu image)
If you inspect the containers you will see that test-service only knows about FOO=bar and  service-with-user-and-password will only know about USERNAME=itsame and PASSWORD=mario.

Inspection results:
$ docker inspect <stackname>-test-service-1 | jq '.[].Config.Env'
[
  "FOO=bar",
  "PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin"
]
$ docker inspect <stackname>-service-with-user-and-password-1 | jq '.[].Config.Env'
[
  "USERNAME=itsame",
  "PASSWORD=mario",
  "PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin"
]

Using them as a whole stack.env:
services:
  service-with-all-env-variables:
    image: ubuntu
    env_file: stack.env

If you inspect the container you will see that it knows about all three variables.

Inspection results:
$ docker inspect <stackname>-service-with-all-env-variables-1 | jq '.[].Config.Env'
[
  "PASSWORD=mario",
  "FOO=bar",
  "USERNAME=itsame",
  "PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin"
]

Deployment using Repository
As stated in the Environment variables section, a file named stack.env must be present in your repository. Consider the following Git repository structure (for file contents see the example repo):
$ ls -l
total 8
-rw-rw-r-- 1 kevin kevin 115 Sep  6 14:44 docker-compose.yml
-rw-rw-r-- 1 kevin kevin  39 Sep  6 14:45 stack.env

In this case you can only use the variables as a whole stack.env. Using them separately as with the Web editor example seems not to be possible.

Inspection results:
$ docker inspect <stackname>-all-together-1 | jq '.[].Config.Env'
[
  "USERNAME=itsame",
  "PASSWORD=mario",
  "FOO=bar",
  "PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin"
]
$ docker inspect <stackname>-single-not-working-1 | jq '.[].Config.Env'
[
  "FOO=",
  "PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin"
]

Docker Swarm
This one is special. As far as I understood the documentation and according to my testing, this is only possible if you are deploying via Repository.

Example Repository deployment:

Inspection results:
$ docker inspect test_all-together.1.<uniqueid> | jq '.[].Config.Env'
[
  "FOO=bar",
  "PASSWORD=mario",
  "USERNAME=itsame",
  "PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin"
]
$ docker inspect test_single-not-working.1.<uniqueid> | jq '.[].Config.Env'
[
  "FOO=notbar",
  "PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin"
]

The results show that defining new environment variable values in the web editor doesn't alter the in-repo stack.env file. That's why all-together still has the original values.
And single-not-working doesn't use the stack.env file at all (see also the "Deploy using Web editor > Using whole stack.env" above). It is using the variables defined in the web interface, which in this case has FOO=otherfoo.
When instead trying to use stack.env in a deployment via Web editor, we get the famous error:

To me, using stack.env in Swarm mode doesn't seem feasible or to bring any benefit. I would rather stay at defining the environment variables separately in the services.

Ah, I just saw, that the documentation clearly states, that using stack.env in Swarm mode is not possible:

Note: Using env_file to define a file does not work in Docker Swarm due to the lack of env_file support in docker stack deploy (used on Swarm environments to deploy your stack). On Docker Swarm, you will need to define each environment variable manually.

It's just not very visible, as it is not highlighted like the other Notes. Additionally it's only mentioned in the "Option 1: Web editor" section (the other Note is repeated in every section).

@koelle25 that's all already known, and discussed in comments prior, and in fact in the issue summary it's clearly stated that it only happens in swarm mode.
The point of this issue is to get it working in swarm mode.
It is technically feasible, but it's not implemented.

@fidelix You are right. I just tried to summarize the main things I found here, in the docs and in my testing.
I believe this issue is a bit too convoluted by now and (maybe also due to this) doesn't seem to get much attraction by Portainer development team.
Maybe this issue should be converted into a discussion and a new clean issue should be opened, with only relevant information.

Can't believe this bug is more than 2 years old. Also it's not an issue on CE, only on EE.
Given that portainer is launced as per manual: sudo docker run -d -p 8000:8000 -p 9443:9443 --name=portainer --restart=always -v /var/run/docker.sock:/var/run/docker.sock -v portainer_data:/data portainer/portainer-ee:2.21.1
It keeps Portainer's data in portainer_data. It's a named volume so it's easy to find it. /var/lib/docker/volumes/portainer_data/ in my case.
Then, the error message claims there is no stack.env in /data/compose/8/. 8 is a stack number in this case.
Indeed, ls /var/lib/docker/volumes/portainer_data/_data/compose/2 shows only deployment versions: v1  v2  v3  v4  v5  v6  v7. And each of them does contain both docker-compose.yml and stack.env.
Relative paths mentioned above would help, but it's the other way around: EE expects stack.env to be in the deployment dir (/data/compose/8/, 2 is a stack number). But the expected behavior is to look for it in  /var/lib/docker/volumes/portainer_data/_data/compose/8/v7/
Workaround:
cp /var/lib/docker/volumes/portainer_data/_data/compose/X/vY/stack.env /var/lib/docker/volumes/portainer_data/_data/compose/X

Strange it's working in one stack for me but not on another - exact same process.  But it's annoying.

Still not working with Portainer Business Edition 2.21.4


[DNM] kv-server: add FastCommit (1PC)

@ngaut @siddontang @morefreeze

Not able to find a simple solution for the isolation problem https://github.com/pingcap/tidb/pull/1261 . Close it for now.


Refactoring Extensions

Templates are still looking for things like extension_schema.Name which you've removed. Where do they get this now?

@jimmyaxod Okay, everything is passing.
My solution to the naming problem was simple - now all the functions use the hash of the schema for their names! This way everything should work across the board!

Bigger issue is that this contains a lot of stuff that is not connected to extensions, which breaks scale-cli eg removing scale.Parse, removing scale.Schema etc etc
So it's not even simple to check this still works e2e any more because it breaks scale-cli.

The integration tests and the CLI both interface with this library via the “compile” package.
So, as long as the integration tests are running (which write a function, compile it, import it into the runtime, and run it), we can be confident that this works.
Yes, the CLI is broken, PR is incoming for that as well though.

The int tests don't currently include extensions, so we can't be sure that one of the 8000 changes in this refactoring has broken extensions. The extension test in scale-cli can't be run until scale-cli is fixed.
I don't understand why we want to do large scale general refactoring work like removing scale.Parse scale.Schema etc in the middle of a new feature - extensions. But am happy to discuss later :)


Python: add buildPythonPackage.overridePythonPackage method.

This allows one to always override the call to buildPythonPackage.
The following example renamed pandas to foo:
with import <nixpkgs> {};

(let
python = let
    packageOverrides = self: super: {
      pandas = super.pandas.overridePythonPackage(old: {name="foo";});
    };
in pkgs.python35.override {inherit packageOverrides;};

in python.withPackages(ps: [ps.pandas])).env

Motivation for this change
Things done

[x] Tested using sandboxing
(nix.useSandbox on NixOS,
or option build-use-sandbox in nix.conf
on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] Linux

[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

Closes https://github.com/NixOS/nixpkgs/issues/24154.

This doesn't function. I'll have a look at it later.


⚠ Bofrost.fr has degraded performance

In a367ca9, Bofrost.fr (https://www.bofrost.fr) experienced degraded performance:

HTTP code: 200
Response time: 1038 ms

Resolved: Bofrost.fr performance has improved in 28912aa after 10 minutes.


add job for deploying fabric8 ui

Update ci index to add job for deploying changes committed to fabricu-ui's master branch.

Duplicate of #34


能支持AndroidX吗

Look at here

→ Did you conform to the Rules?
→ Did you read the Wiki Carefully?
→ Did you search in Google?
→ Did you search in openned&closed Issues?
→ Receive only bugs and suggestions

Environment

[x] MVPArms Version:
[x] AndroidStudio Version:
[x] Gradle Plugin Version:
[x] Target Android Version:
[x] Device Model:

Bug Description:

Related Code:

Bug Log:

Others:

现在，还不能支持，在之前的 issues 回答过。
升级 AndroidX 没有这么简单

会影响大量老项目
MVPArms 依赖了大量三方库，升级 AndroidX 之前，必须保证依赖的所有三方库都支持 AndroidX

光是第 2 点就不是这么容易解决的，有些库都很久没更新了

https://mp.weixin.qq.com/s/XeJQrwbxKk6JbBn8C3fqKg


Video could not be loaded error

These videos were working a few weeks ago, but for some reason today I am seeing the below error when tying to play any video within the well-architected framework documentation:

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 953cd3b7-f664-44f5-04bb-046a0f1079fe
Version Independent ID: 953cd3b7-f664-44f5-04bb-046a0f1079fe
Content: Microsoft Azure Well-Architected Framework - Azure Architecture Center
Content Source: well-architected/index.md
Service: architecture-center
Sub-service: well-architected
GitHub Login: @martinekuan
Microsoft Alias: martinek

@robm82 it appears this may have just been a transient error, the videos seem to be working now.  If you are still having issues, feel free to comment with more details. #please-close


It doesn't work after I installed hosting bundle 8.0.1, the application show error: Could not find dotnet.exe at 'c:\inetpub\wwwroot\api\dotnet' or using the system PATH environment variable.

It doesn't work after I installed hosting bundle 8.0.1, the application show error: Could not find dotnet.exe at 'c:\inetpub\wwwroot\api\dotnet' or using the system PATH environment variable.
BTW, it work good for hosting bundle 6.
My dockerfile is as bellow:
    FROM mcr.microsoft.com/windows/servercore/iis AS final
    SHELL ["powershell"]
    EXPOSE 80 443

    RUN Invoke-WebRequest http://download.microsoft.com/download/D/D/E/DDE57C26-C62C-4C59-A1BB-31D58B36ADA2/rewrite_amd64_en-US.msi -OutFile "c:/rewrite_amd64_en-US.msi"
    RUN Start-Process -FilePath "c:/rewrite_amd64_en-US.msi" -ArgumentList "/qn" -Wait

    RUN Invoke-WebRequest 'https://download.visualstudio.microsoft.com/download/pr/016c6447-764a-4210-a260-bf7a2880d5c0/a5746437a3862d7803284ae8c2290200/dotnet-hosting-8.0.1-win.exe' -UserAgent '' -OutFile "C:/dotnet-hosting.exe"
    RUN Start-Process -FilePath "c:/dotnet-hosting.exe" -ArgumentList @('/install', '/q', '/norestart', 'OPT_NO_RUNTIME=1', 'OPT_NO_SHAREDFX=1') -Wait -PassThru

    # Copy the build artifacts
    ADD aaa /inetpub/wwwroot
    ADD bbb/s /inetpub/wwwroot/api/Rules

    # Create the Web Applications, use different application pool for each, mix hosting mode is not supported
    RUN New-WebAppPool -Name "AppPoolAPI"
    RUN New-WebApplication -Name api -Site 'Default Web Site' -PhysicalPath "c:\inetpub\wwwroot\api" -ApplicationPool AppPoolAPI

    RUN New-WebAppPool -Name "AppPoolSSO"
    RUN New-WebApplication -Name SSO -Site 'Default Web Site' -PhysicalPath "c:\inetpub\wwwroot\sso" -ApplicationPool AppPoolSSO

I recommend opening an issue with dotnet:  https://github.com/microsoft/dotnet-framework-docker/issues/new/choose

Thanks for your suggestion. We have changed our containers into Linux based now.


SVG export doesn't honor bounding box (layer mask)

Compare the screenshots of the equivalent PNG and SVG exports:

And here's a screenshot of the layer group I'm exporting:

(It's worth noting that this example also illustrates https://github.com/adobe-photoshop/generator-assets/issues/180, which is why the lens of the magnifying glass icon looks bigger in the SVG export.)

I think the issue is because SVG export doesn't support masks, watson 3860058

3860058 closed as a dupe of 3909740 which deals with smart object scaling and says nothing about masks or svg.  They don't seem directly related from what I can tell.

sorry, wrong bug number. 3852251 and 3853040 (masks are not supported in SVG)

both of those are closed/deferred, should they actually be closed if they are going to be fixed?


Use same devDependencies as setup-python

Fix #116.
This eliminates two errors in the "npm run build" step on Windows. It does not attempt to cause the build to fail when npm run * commands fail; this appears to be an intractable issue with powershell: see https://github.com/jurplel/install-qt-action/issues/116#issuecomment-933384134.
Successful run of this PR: https://github.com/ddalcino/install-qt-action/actions/runs/1373216276

Thank you for your excellent work @ddalcino.


Missing messages(Softpal)

When extracting all the messages to a .json file I see that the first couple of dialog lines are not getting picked up so it's not possible to translate them at the moment.
The lines not picked up are the following:

Attached the SCRIPT.SRC file and TEXT.DAT
data.zip

Can you also send the game's point.dat?
(As an aside, the English translation in the text.dat is somehow even more nonsensical than a machine translation, so you may want to consider getting a different translator)

Here is the original data.pac with everything inside including the point.dat :)
data.zip
(No wories about the translation, we haven't  actually started yet. Ran the messages thourgh an MTL to check for crashes or untranslated text like it happened here)

(No wories about the translation, we haven't actually started yet. Run the messages through an MTL to check for crashes or untranslated text like it happened here)

Good to hear that's not the actual TL! And yes, testing beforehand is a good idea - I've seen projects that translated everything first and then started figuring out how they could put it into the game...
Anyway, the missing strings are now extracted.

I'm getting another issue now that updated to your latest version.

It's trying to extract point.dat, which isn't going to work. Try pointing it specifically to script.src rather than the folder containing it.

When I do that this happens:

Well, does point.dat exist at the file path it complains about?

Try using: vntextpatch.exe extractlocal input/script.src script.xlsx

Try using: vntextpatch.exe extractlocal input/script.src script.xlsx

Big thanks, this solved my issue.
Also I really appreciate the great support ^^

It's trying to extract point.dat, which isn't going to work. Try pointing it specifically to script.src rather than the folder containing it.

Sorry to bother you again but now there is another issue. Game crashes. Even without translating any of the lines, just extracting and then inserting without touching anything. The result (text.dat and script.src) make the game crash after opening it, but the original ones don't. No error it's shown, the game just closes.

I tried it out and it works for me. Make sure to:

Run the insertion as follows: VNTextPatch input\script.src script.xlsx data\script.src. (This will create a new script.src and text.dat in the game's "data" folder. Copying the original text.dat will result in a crash when the first line of text is displayed ingame.)
Make sure the "data" folder does not contain point.dat. VNTextPatch doesn't modify this file, and having the original point.dat in the "data" folder will result in a crash on startup.

I tried it out and it works for me. Make sure to:

Run the insertion as follows: VNTextPatch insertlocal input\script.src script.xlsx data\script.src. (This will create a new script.src and text.dat in the game's "data" folder. Using the original text.dat will result in a crash when the first line of text is displayed ingame.)
Make sure the "data" folder does not contain point.dat. VNTextPatch doesn't modify this file, and having the original point.dat in the "data" folder will result in a crash on startup.

That worked! ^^


karma jsdom launcher hangs

Bug Report
- [x] bug report -> please search issues before submitting

Area
- [x] `npm run test`   or  `ng test`

Versions
Angular CLI: 6.0.8
Node: 10.6.0
OS: linux x64 (Linux Mint)
Angular: 6.0.9
Npm: 6.1.0 and 6.2.0
Reproduction steps

ng new appWithJsdom
cd appWithJsdom
npm install
npm install karma-jsdom-launcher jsdom --save-dev
modify src/karma.conf.js

diff --git a/src/karma.conf.js b/src/karma.conf.js
index b6e0042..c9f81b7 100644
--- a/src/karma.conf.js
+++ b/src/karma.conf.js
@@ -8,6 +8,7 @@ module.exports = function (config) {
     plugins: [
       require('karma-jasmine'),
       require('karma-chrome-launcher'),
+      require('karma-jsdom-launcher'),
       require('karma-jasmine-html-reporter'),
       require('karma-coverage-istanbul-reporter'),
       require('@angular-devkit/build-angular/plugins/karma')
@@ -24,8 +25,8 @@ module.exports = function (config) {
     port: 9876,
     colors: true,
     logLevel: config.LOG_INFO,
-    autoWatch: true,
-    browsers: ['Chrome'],
-    singleRun: false
+    autoWatch: false,
+    browsers: ['jsdom'],
+    singleRun: true
   });
 };

The log given by the failure
Then ng test displays build statements in CLI:
16 07 2018 13:06:35.821:WARN [karma]: Port 9876 in use
16 07 2018 13:06:35.823:INFO [karma]: Karma v1.7.1 server started at http://<IP_ADDRESS>:9878/
16 07 2018 13:06:35.823:INFO [launcher]: Launching browsers jsdom with unlimited concurrency
16 07 2018 13:06:35.842:INFO [launcher]: Starting browser jsdom
16 07 2018 13:06:40.252:INFO [Mozilla/5.0 (linux) AppleWebKit/537.36 (KHTML, like Gecko) jsdom/11.11.0]: Connected on socket p6lvGGcG6uRr_zm5AAAB with id 26520884

The the console is cleared, nothings happens.
Ctrl-c eventually leads me back to the console.
This is repeatable.
No other user is connected to the desktop, no other node instances are running concurrently.
Can't really run too many processes on it anyway.
When I use 'Chrome' or 'ChromeHeadless', the browser pops up etc, runs the tests all green.
Eveidently, I have the Chrome browser installed locally.
Desired functionality
I need a way to run the UI tests in a build process.
Tried PhantomJS - no luck.
Would like to use jsdom as test browser for builds - as it does headless mode with minimal effort.
Can't install a browser on the build server.
Though puppeteer and ChromeHeadless, the karma launcher fails with not finding libX11.so ...

Two and a half months later, I revisit this defect.
I am not able to reproduce it.
The same project configuration now runs and terminates nicely, returning to the command prompt.
Closing this issue.

Verified with
Angular CLI: 6.2.4
Node: 10.11.0
OS: Linux x64 (Linux Mint 19.1 - based on Ubuntu 18.4)
Angular: 6.1.9
Yarn: 1.10.1

I am facing this issue.
I confirmed that this can be easily reproduced with a fresh Angular project.
$ ng new karma-jsdom-demo
? Would you like to add Angular routing? No
? Which stylesheet format would you like to use? CSS
$ cd karma-jsdom-demo
$ yarn add jsdom karma-jsdom-launcher -D
$ vi src/karma.conf.js
// edit karma.conf.js as shown below

@@ -7,7 +7,7 @@ module.exports = function (config) {
     frameworks: ['jasmine', '@angular-devkit/build-angular'],
     plugins: [
       require('karma-jasmine'),
-      require('karma-chrome-launcher'),
+      require('karma-jsdom-launcher'),
       require('karma-jasmine-html-reporter'),
       require('karma-coverage-istanbul-reporter'),
       require('@angular-devkit/build-angular/plugins/karma')
@@ -25,7 +25,7 @@ module.exports = function (config) {
     colors: true,
     logLevel: config.LOG_INFO,
     autoWatch: true,
-    browsers: ['Chrome'],
+    browsers: ['jsdom'],
     singleRun: false
   });

$ yarn test

My environment:
$ ng version

     _                      _                 ____ _     ___
    / \   _ __   __ _ _   _| | __ _ _ __     / ___| |   |_ _|
   / △ \ | '_ \ / _` | | | | |/ _` | '__|   | |   | |    | |
  / ___ \| | | | (_| | |_| | | (_| | |      | |___| |___ | |
 /_/   \_\_| |_|\__, |\__,_|_|\__,_|_|       \____|_____|___|
                |___/

Angular CLI: 7.1.4
Node: 10.12.0
OS: darwin x64
Angular: 7.1.4
... animations, cli, common, compiler, compiler-cli, core, forms
... language-service, platform-browser, platform-browser-dynamic
... router

Package                           Version
-----------------------------------------------------------
@angular-devkit/architect         0.11.4
@angular-devkit/build-angular     0.11.4
@angular-devkit/build-optimizer   0.11.4
@angular-devkit/build-webpack     0.11.4
@angular-devkit/core              7.1.4
@angular-devkit/schematics        7.1.4
@ngtools/webpack                  7.1.4
@schematics/angular               7.1.4
@schematics/update                0.11.4
rxjs                              6.3.3
typescript                        3.1.6
webpack                           4.23.1

Have moved on w/ using Jest as my headless browser test runner.

@catull I would appreciate if you reopen this issue for those who are still using Karma.

@kimamula Sure, do not expect assistance from me though.  I found a more suitable solution with Jest.

Thanks!
I am also considering moving to Jest.
I would like to hear from Angular team whether they could support karma-jsdom-launcher for making the decision.

@kimamula

I have two points.  Jest uses jsdom internally.
That alone motivated me.

I cannot imagine why karma-jsdom-launcher would be supported.
They support karma-chrome-launcher and karma-firefox-launcher, head-full and head-less.

Don't know if they also support Edge on Windows.

@kimamula

Jest uses jsdom internally.
That alone motivated me.

I cannot imagine why karma-jsdom-launcher would be supported.
They support karma-chrome-launcher and karma-firefox-launcher, head-full and head-less.

Don't know if they also support Edge on Windows.

Heya just wanted to mention that @badeball investigated this further in https://github.com/angular/angular-cli/issues/13580 and provides a way to use them together after https://github.com/angular/angular-cli/pull/13584 is merged.


1.3.0 introduces a breaking change

By changing the exports so that it must be imported directly rather than with import {cookie} from 'cookie_js';, this breaks existing code.  If you were going to introduce a breaking change that prevents the previous way it was imported from working, it should have been a major version change.

Ugh, I'm sorry, that shouldn't have happened.
Do you think the best course of action is to unpublished 1.3.0 and republish as 2.0.0?

Well this is a little awkward because in #41 I complained that in version 1.2.1 you’ve introduced a breaking change by modifing the "export signature" (for the lack of a better name) of your package. So technically this is a bug fix and not a breaking change as the import syntax for the package is now the same as in version 1.2.0. But given the time frame of approximately two years between the release of version 1.2.1 and 1.3.0 this realistically should be a major release, because… here I am again with a broken import 😀.
Whatever you do please don’t unpublish versions from npm. The ideal solution would be to release 1.3.1 and add a named export next to the default export. This way both import { cookie } from 'cookie_js' and import cookie from 'cookie_js' should work and everybody is happy. I’m not entirely sure how this would affect cjs/amd/umd modules though, so this would require some testing.
An alternative is to publish version 1.3.1 with the old export and republish version 1.3.0 as version 2.0.0 and add a note to the readme. You may also want to add a deprecation notice to version 1.3.0 in this case. You arguably could do it the other way around, I guess it’s messy either way.

same issue here~


New - Included CIFuzz

included cifuzz
removed the make fuzz func which was running fuzz tests.

Codecov Report

Merging #1212 (91b0466) into main (fc13b61) will decrease coverage by 22.26%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             main    #1212       +/-   ##
===========================================
- Coverage   64.23%   41.97%   -22.27%
===========================================
  Files          82       74        -8
  Lines        7628     7209      -419
===========================================
- Hits         4900     3026     -1874
- Misses       2100     3874     +1774
+ Partials      628      309      -319

Flag
Coverage Δ

e2etests
?

unittests
41.97% <ø> (-0.05%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

 Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Be aware that the fuzzers currently fail at runtime which will be fixed when this lands: https://github.com/google/oss-fuzz/pull/8937
It might make sense to hold CIFuzz until then. The PR should land early next week.

Be aware that the fuzzers currently fail at runtime which will be fixed when this lands: google/oss-fuzz#8937
It might make sense to hold CIFuzz until then. The PR should land early next week.

👍

Be aware that the fuzzers currently fail at runtime which will be fixed when this lands: google/oss-fuzz#8937
It might make sense to hold CIFuzz until then. The PR should land early next week.

This has now been merged.

we have good coverage with oss-fuzz and no need to add these as a CI check at this time.


The "path" argument must be of type string. Received undefined

ERROR in   Error: Child compilation failed:
Module build failed (from ./node_modules/simple-pug-loader/index.js):
TypeError [ERR_INVALID_ARG_TYPE]: The "path" argument must be of type string. Received undefined
at new NodeError (internal/errors.js:322:7)
at validateString (internal/validators.js:124:11)
at Object.normalize (path.js:1104:5)
at Object.module.exports ({project-path}/node_modules/simple-pug-loader/index.js:104:38)
ModuleBuildError: Module build failed (from ./node_modules/simple-pug-loader/index.js):

ERROR in Error: Child compilation failed: Module build failed (from ./node_modules/simple-pug-loader/index.js): TypeError [ERR_INVALID_ARG_TYPE]: The "path" argument must be of type string. Received undefined at new NodeError (internal/errors.js:322:7) at validateString (internal/validators.js:124:11) at Object.normalize (path.js:1104:5) at Object.module.exports ({project-path}/node_modules/simple-pug-loader/index.js:104:38) ModuleBuildError: Module build failed (from ./node_modules/simple-pug-loader/index.js):

Path inside index.pug is worng


updating googlefonts profile codetests

@simoncozens, I think fontspector still does not support check overrides, right?

For now I'll split-out these tests to a file dedicated to testing check overrides:  tests/test_checks_googlefonts_overrides.py

Very nice, thank you!

Corresponding changes made at https://github.com/fonttools/fontbakery/pull/4888/commits/7852a669736a060514b1bcd56615473e8ed949cf


Unable to mock 'vue-meta'

Describe the bug
I was trying to upgrade Vitest from version 0.12.9 to 0.19.0 and now tests that are asserting a specific function from a module to have been called started failing.
That module is an npm package called vue-meta. (Link)
I have components that import { useMeta } from 'vue-meta'.
That useMeta function is called when some components are mounted or created.
All I want to do is to spy useMeta and assert it, expecting that it gets called. Should be easy, right?
But for some reason this stopped working after the upgrade and I'm clueless in understanding why.
I was able to create StackBlitz reproducing this. Just open the link and the test will run automatically.
Reproduction
https://stackblitz.com/edit/vue-vitest-demo
System Info
System:
    OS: macOS 12.4
    CPU: (12) x64 Intel(R) Core(TM) i7-8750H CPU @ 2.20GHz
    Memory: 819.89 MB / 16.00 GB
    Shell: 5.8.1 - /bin/zsh
  Binaries:
    Node: 14.20.0 - ~/.nvm/versions/node/v14.20.0/bin/node
    npm: 8.3.2 - ~/Projects/clearancejobs/node_modules/.bin/npm
  Browsers:
    Chrome: 103.0.5060.134
    Firefox: 100.0
    Safari: 15.5
  npmPackages:
    @vitejs/plugin-vue: 2.1.0 => 2.1.0
    vite: 2.9.9 => 2.9.9
    vitest: 0.19.0 => 0.19.0

Used Package Manager
npm
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
[X] The provided reproduction is a minimal reproducible example of the bug.

Note: This started happening in<EMAIL_ADDRESS>

It's mention in #1740 that #1726 fixed it, can you confirm? If so, you can close the issue.

By my test, it's ok in v0.20.1.

@sheremet-va, @ChpShy. Just tested it in both v.0.20.1 and v.0.20.2 and the issue is fixed.
Thanks to everyone involved, that was a super quick fix!
I'm closing the issue as its been resolved.


中文汉化

Chinese localization

@Zacharia2, thanks for the translation.

@Zacharia2, does https://btheado.github.io/tiddlystow/TiddlyStow-ZH.html look ok to you? When I view it in my browser, instead of Chinese characters, it looks garbled.
����򵥵�ҳ���Ǽ�� instead of 这个简单的页面是加载
When I load the file via a file:/// url, it looks fine.
This command shows the file is ISO-8859 text:
$ file TiddlyStow-ZH.html
TiddlyStow-ZH.html: HTML document, ISO-8859 text, with CRLF line terminators

However, github.io is returning content-type: text/html; charset=utf-8 in its HTTP headers. I suspect the issue is that utf-8 does not match ISO-8859.
I tried locally converting the file to utf-8, but still it didn't help (iconv -t UTF-8 TiddlyStow-ZH.html).
If it looks fine to you, then I'll ignore the issue since I don't need to see the Chinese version.
Does it look fine to you?


Integrate aXe library for accessibility coverage

Integrate aXe library, so that we increase the accessibility coverage.

Build is failing due some accessibility issues
logs:
Violation of "aria-roles" with 3 occurrences!
Ensures all elements with a role attribute use a valid value. Correct invalid elements at:
- .nhsuk-care-card--primary > .nhsuk-care-card__heading-container > .nhsuk-care-card__heading > span[role="text"]
- .nhsuk-care-card--urgent > .nhsuk-care-card__heading-container > .nhsuk-care-card__heading > span[role="text"]
- .nhsuk-care-card--emergency > .nhsuk-care-card__heading-container > .nhsuk-care-card__heading > span[role="text"]
For details, see: https://dequeuniversity.com/rules/axe/3.1/aria-roles
Violation of "empty-heading" with 3 occurrences!
Ensures headings have discernible text. Correct invalid elements at:
- .nhsuk-care-card--primary > .nhsuk-care-card__heading-container > .nhsuk-care-card__heading
- .nhsuk-care-card--urgent > .nhsuk-care-card__heading-container > .nhsuk-care-card__heading
- .nhsuk-care-card--emergency > .nhsuk-care-card__heading-container > .nhsuk-care-card__heading
For details, see: https://dequeuniversity.com/rules/axe/3.1/empty-heading
Violation of "label" with 1 occurrences!
Ensures every form element has a label. Correct invalid elements at:
- #search-field
For details, see: https://dequeuniversity.com/rules/axe/3.1/label
Violation of "skip-link" with 22 occurrences!
Ensure all skip links have a focusable target. Correct invalid elements at:
- a[href="#E"]
- a[href="#F"]
- a[href="#G"]
- a[href="#H"]
- a[href="#I"]
- a[href="#J"]
- a[href="#K"]
- a[href="#L"]
- a[href="#M"]
- a[href="#N"]
- a[href="#O"]
- a[href="#P"]
- a[href="#Q"]
- a[href="#R"]
- a[href="#S"]
- a[href="#T"]
- a[href="#U"]
- a[href="#V"]
- a[href="#W"]
- a[href="#X"]
- a[href="#Y"]
- a[href="#Z"]
For details, see: https://dequeuniversity.com/rules/axe/3.1/skip-link
29 Accessibility issues detected.


Fixing parsing of diffs with empty neutral lines and diffs without co…

…ntext.
Here, I tried to improve parsing of diffs:
-which have an empty neutral line. This sends the parser into a search which should determine if the line is a separator between diffs or a neutral line, and the parser often incorrectly decides it is a separator, which then leads to missing parts of the diff in the parsed data. The search is now improved so that if a new hunk or a from line or to line are found, then the empty line is interpreted as a neutral line. Empty neutral lines at the end of a file diff may still be ignored/considered separators, but that seems like a much smaller problems
-which don't have context - the end of diff detection failed to detect the start of the next diff; fixed by separating matchesEndPattern from the header detection, and properly handling the header immediately following a diff line.

@thombergs Hi, are you accepting any PRs on this repo?  There seems to be some bugs but the issues or PRs are not being addressed. If you are not willing to maintain, may I request you to add a notice so that people will not vendor this in their dependency. If you would like to still keep this repo, if you are busy, I can give a hand.


Company Page -  When we change size of rows to 50,75 or 100 its is only showing 25 rows per page

Describe the bug

when we change size of rows like 50, 75 or 100 it always pass 25 pagesize in api in company page

Recorded by Avinash
https://www.berrycast.com/conversations/77c24da6-b1a9-51e8-adc8-4438a77d5d15
Recorded by Vinod sir
https://www.berrycast.com/conversations/8df486f2-0392-50ab-94b1-fe7b92ff7c94

https://www.berrycast.com/conversations/fb86361d-6b9b-51b9-873a-182857b43519


Luke/suspense fixes

Add missing import in suspense tests, add test and fix bug where queries with enabled: false triggered suspense. Same number of tests pass with the change. The new test fails without the change and passes with the change.

Good catch thanks!


Add radio buttons control

We don't have radio buttons in our library. Check the material 3 spec - https://m3.material.io/components/radio-button/overview
and use our toggle control as the example - fields/Toggle.ts. This control should work correctly with our Record and support field props.

From Razin: "about radio buttons , I wanted to change a little bit , so now it works with string|array-of-strings|array-of-objects
but I want to let the final component work only with objects and make these objects from string and array of strings , and provide it to component"


Windows Terminal appears in the wrong language

Windows Terminal version
Version: 1.11.3471.0
Windows build number
22000.376
Other Software
No response
Steps to reproduce
On an English language system set the region to a non regional format for instance German (Switzerland)
Expected Behavior
Windows Terminal follows the system language
Actual Behavior
Windows Terminal appears in German. All other OS-relevant UI (Start menu, Settings etc.) is still in English.
See this: Get operating system language in c#

Thanks, but system default would be English in my case, wouldn't it?.

Thanks, but system default would be English in my case, wouldn't it?.

In my case:
Installed Culture Info: en-US
Current UI Culture Info: en-US
Current Culture Info: de-CH
To be in sync with the rest of the OS it would make most sense to choose Current UI Culture.

In my case:
Installed Culture Info: en-US
Current UI Culture Info: en-US
Current Culture Info: de-CH
To be in sync with the rest of the OS it would make most sense to choose Current UI Culture.

There is the list to choose UI-language.

There is the list to choose UI-language.

Sure. I should rephrase: "System language" is not correctly establish. It used Current Culture where Current UI culture would be more appropriate.

"System language" is not correctly establish.

I think it depends on the version of Windows, more precisely on the language of the system that was chosen at the stage of downloading the image file. For example, I installed the English version, but then I chose my native culture (datetime format, currency, numbers). Not because I like English, but the UI is better displayed than translated one, this is my personal opinion.

Part of this is the fact that the Termnial isn't translated to de-CH. I believe we do have a de-DE translation, which I would have assumed that the OS would have picked before falling back to en-US, but I might be wrong there. Lemme pull up the mail thread from a few months back.
See also #10667

Oh actually, this might just be a /duplicate of #9466

This is a weird and specific issue with language fallback that I don't totally understand.
The resource loader takes a set intersection of the user's preferred languages and the application's supported languages. When it does that, it is very specific and will only choose languages with a matching country code.
There's no automatic fallback from en_GB to en_US. I also don't know if it would fall back from en_GB to just en. :|

Presumably, same deal for de_CH not falling back to de_DE 😕


Recommendation Zones and recursor

Hi guys
Again thanks for this proejct.
I would like to ask you about your recommendation with pdns + DNS-admin, Do you prefer master and slave or use mysql replication (I'm using mariadb)?
Second thing is how are you using recursor ? Maybe this question should no be here.
Im not pretty sure about the config in the new version.
Thank you!!

Probably not a universal answer, because circumstances differ. But native mode with mysql replication is awesome for a number of reasons:

No need to maintain domain names in multiple places.
Zones can be transferred securely with ssl
Fast
Zones stay in sync no matter what you do (even if for some reason the soa serial is screwed up)

On the other hand, it's perhaps a bit more complicated to configure properly.

By the way, recursor has nothing to do with this. PowerDNS-Admin helps administer the authoritative end of the DNS chain.


Getting more done in GitHub with ZenHub

Hola! @mcpride has created a ZenHub account for the jonschlinkert organization. ZenHub is the only project management tool integrated natively in GitHub – created specifically for fast-moving, software-driven teams.

How do I use ZenHub?
To get set up with ZenHub, all you have to do is download the browser extension and log in with your GitHub account. Once you do, you’ll get access to ZenHub’s complete feature-set immediately.
What can ZenHub do?
ZenHub adds a series of enhancements directly inside the GitHub UI:

Real-time, customizable task boards for GitHub issues;
Multi-Repository burndown charts, estimates, and velocity tracking based on GitHub Milestones;
Personal to-do lists and task prioritization;
Time-saving shortcuts – like a quick repo switcher, a “Move issue” button, and much more.

Add ZenHub to GitHub
Still curious? See more ZenHub features or read user reviews. This issue was written by your friendly ZenHub bot, posted by request from @mcpride.


'module' does not name a type (ERROR)

When I put the particle ID and the particle access token in the script below, I get the following error: "'module' does not name a type. How can I fix this issue?

config.sample.js - local storage for keys and identifiers

Copyright 2017 Google Inc.

Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at

http://www.apache.org/licenses/LICENSE-2.0

Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
*/

// Put your keys and identifiers here.
module.exports = {
particleDeviceID: '',
particleAccessToken: ''
};

We chatted about this over Twitter, so closing this issue here.


Fix bug where types argument is positional for strawberry.union

Description
Fix mypy plugin to handle bug where the types argument to strawberry.union is passed in as a keyword argument instead of a position one.
Types of Changes

[ ] Core
[x] Bugfix
[ ] New feature
[ ] Enhancement/optimization
[ ] Documentation

Issues Fixed or Closed by This PR

Checklist

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[x] I have added tests to cover my changes.
[x] I have tested the changes and verified that they work and don't break anything (as well as I can manage).

Thanks for adding the RELEASE.md file!

Here's a preview of the changelog:

Fix mypy plugin to handle bug where the types argument to strawberry.union is passed in as a keyword argument instead of a position one.
MyUnion = strawberry.union(types=(TypeA, TypeB), name="MyUnion")


Wrong preview when using nested components

I have 2 components:

HeaderComponent
Header::MenuComponent

The previews are correct when accessing them with the standard ViewComponent URLs:

http://localhost:3000/rails/view_components/header_component/default
http://localhost:3000/rails/view_components/header/menu_component/default

But in lookbook (0.4.0.beta.1), I always get the HeaderComponent preview:

Do you need a failing test?

Great! I can confirm that the fix works!
About tests, if you describe what you expect to add in some issues, I'd be happy to try to tackle that!


bug: DgsGraphQLMetricsInstrumentation variables parsing error

There is a logic computing query complexity in DgsGraphQLMetricsInstrumentation. To do so, it creates a QueryTraverser with some parameters (see QueryUtils.newQueryTraverser). Among those builder parameters are variables, where raw (that means not yet parsed) query variables are expected, according to graphql-java doc. However, already parsed variables are used instead. That is a problem with scalars for example, where the raw value differs from the parsed one. It leads to an error being logged and query complexity not being computed for the instrumentation.
Expected behaviour
The expected raw query variables should be passed into the QueryTraverser builder. Or the logic should change to avoid the redundant second variables parsing altogether.
Actual behaviour
Already parsed query variables are passed to the QueryTraverser builder. That leads to an error, if parsed variable differs from the raw one.
Steps to reproduce
Create a custom GraphQL scalar (e.g. a Value(value: String) data class) with the relevant coercing class implementing e. g. Coercing<Value, String>. Implement the required methods (only 'parseValue' should be required to implement properly the deserialisation). Then call a GraphQL query with a variable of the scalar type and see, that the parseValue is called twice - once with a raw value and then (through the Metrics Instrumentation) with an already parsed value.

Thanks for the detailed description. We will look into fixing this in a future release. We are currently tied up with other priorities, but will get this fixed this quarter.

I attempted recreating this issue in this PR, but could not. @Jarda8 I recreated the scenario you described, but I did not get the error. I linked my PR above so it's evident what I tried to do. The test case I set up successfully parsed a custom scalar that I implemented, and there are no errors in the logs.

This was fixed in a1a6cd3, since we switched to passing in coercedVariables to the QueryTraverser builder. I can't reproduce the issue now, but I can if I revert that change from a1a6cd3.


Fix dependencies

move radium and lodash from archetype to project
Remove d3-scale as dependency; update docs
Add React as peerDependency

Part of https://github.com/FormidableLabs/victory/issues/176

thanks @coopy I forgot about the docs! LGTM


Keeping agents in osm map during episode

Feature Description
I'm currently using flow to train a MAS system with MADDPG algorithm (here). During the sampling I get this error which is due to the RL agents being removed during the episode.
Since I'm using an imported OSM map neither the MinicityRouter nor the _reroute_if_final_edge are working to prevent the Agents to be deleted from the map.
It would be nice to have a method for doing this  on OSM maps too.

Hi @nicofirst1, in terms of a quick fix, would it work to have an inflow of vehicles in your system or do you need there to be a fixed number of vehicles in your system at all times? If the latter, we can push a fix to add such an option to OSM maps.

Unfortunately I need to have a fixed number of RL vehicles during the episode.

I see. Would it be sufficient to just check if the edge is the final edge in your list of routes and return it to the first element in the route?

Yes, as long as I have a constant number of agents during the episode.

Any update on this?

Yep! It'll take a bit longer to get it merged in (need to write unit tests for it) but I've opened a PR #759 that gives an example of how you might do this. Hope that helps!

Hi, I'm closing this for now. Hoping your project got finished up alright!


Cyr osb slayer mahoji m3

Description:

Changes:

Other checks:

[ ] I have tested all my changes thoroughly.

going to reopen this


Add themes

Solarized Light:
bg: FDF6E3 text: 93A1A1
Solarized Dark:
sd bg: 002B36 text: 586E75

Check here.


Allow multiple File transports for a logger

Makes it possible to use several File transports for one logger:
var logger = new (winston.Logger)({
    transports: [
        new (winston.transports.File) ({
            level: 'info',
            filename: 'log/access.log',
            json: true
        }),
        new (winston.transports.File) ({
            level: 'error',
            filename: 'log/error.log',
            json: true
        })
    ]
});

would be great to see this finally arriving in the master :/

@greenify this has been in master for a long time. Please take the time to read the documentation before commenting on issues :smiling_imp:
https://github.com/winstonjs/winston#multiple-transports-of-the-same-type


Convert Resorts Columns To Use JSON datatype instead of String

Currently for the Arapahoe Basin Column, I am converting all of my data into JSON and then converting that to a string to be stored. PostgreSQL actually can handle storing JSON natively, so I would like to see if Slick has a way of updating the table and making that column store JSON instead.

I believe that using this library is probably going to be the way to do this.
Here is a stack overflow that describes what to do when using the above library.


Fix incorrect S2ID Calculation

What this PR does / why we need it:

S2ID calculation is incorrect
Which issue(s) this PR fixes:

Fixes #
Does this PR introduce a user-facing change?:

Checklist

[x] Added unit test, integration, and/or e2e tests
[x] Tested locally
[ ] Updated documentation
[ ] Update Swagger spec if the PR introduce API changes
[ ] Regenerated Golang and Python client if the PR introduce API changes

LGTM


If levels start expanded, then we don't get to see a spinner when we expand it.

This is a problem in case it takes a while to calculate the number of members.

Problem is in renderLevelTreeNode. The loadChildren method of the rendered treenode immediately calls the callback. It should pass the callback to loadLevelTreeNodeChildren instead and let that handle the callback. (And, that guy needs to delegate the callback to whichever async processes it calls, too)


Feature request/ problem automations based on state

I'm trying to make automations based on state of the alarm
When the alarm is ringing , the music has to play
When the alarm is snoozed or turned off, the morning routine should start
However, i'm having troubles making this, cause of the integration is polling every 180 seconds.
I now i can make it faster but as you said, it becomes unreliable, so i dont want too
Is there a way that polling happens when state changes?
Or can i have a workaround for this?

Unfortunately, there is no way to do this before we figure out why local API starts timing out after more frequent requests or before Google just fixes this issue on their side.

Hi thx for replying.
Damn thats a pity.
I google aware of this?

Maybe its better to make automations then that starts as soon as the time from the alarm has reached + ... seconds

Is google aware of this?

Probably not. This local API is not documented and only intended to use for Google Home app.

@skank01, as @KapJI has mentioned unfortunately this is Google limitation. But we still encourage you to playing with pooling frequency. Some of us had good reliable results even with as small pooling results as 1 second. However when you do it, give the devices a few hours in between the changes cause this is about the time you start noticing devices timing out. Perhaps you can try cutting the frequency half to 90sec first, leaving it for 24h to make sure nothing broke and devices are not timing out (keep an eye on logs) and if everything is still fine - cut the frequency half again and check etc :)


Uncaught Error: Class 'ZipArchive' not found?

Hi @MilesChou,
I've been using the 'MilesChou/composer-action' successfully this year and was able to generate a zip file from by github build.
Recently I pushed an update and the build failed with this error claiming that the the ZipArchive was not present.
    ReleaseBuilder: bhaa-wordpress-plugin.zip      > BHAA\utils\ReleaseBuilder::createZip     Fatal error: Uncaught Error: Class 'ZipArchive' not found in /github/workspace/src/utils/ReleaseBuilder.php:18     Stack trace:
From investigate it suggests that the php library for zip is not installed, but i believe it is. I appreciate that the composer-action image is not at issue but might there be a combination of changes to the github ubuntu:latest version which might have caused this issue to start?
Kind Regards,
emeraldjava

Hi @emeraldjava,
I use unzip command for extract zip file which composer downloaded. Composer Action image just do composer command.
I suggest build custom image for using zip ext.
FROM mileschou/composer:7.4

# or GitHub Container Registry
# FROM ghcr.io/mileschou/composer:7.4

RUN set -xe && \
    apk add --no-cache \
        libzip \
    && \
    apk add --no-cache --virtual .build-deps \
        libzip-dev \
        zlib-dev \
    && \
    docker-php-ext-install -j "$(getconf _NPROCESSORS_ONLN)" \
        zip \
    && \
    apk del --no-cache .build-deps \
    && \
    php -m

Thanks for the reply. I understand the image only needs unzip to extract the composer download, but zip was part of the original image and isn't any longer. I'll investigate creating a new docker image for my github-action. I suspect switching to something like https://github.com/marketplace/actions/setup-php-action will be an easier path.


Migration notes from v0.4 to v0.5?

Hello everyone
We are about to upgrade RactiveJS from 0.4.x to 0.5.x for our big project. Are there any migration notes what to do? Would be great because after reading the changelog on https://github.com/ractivejs/ractive/blob/dev/CHANGELOG.md we still do not know where to start.
Thanks!

Closing this issue as http://docs.ractivejs.org/latest/migrating exists, and will soon have notes for 0.6.x -> 0.7.x...


Use <url> for links in python docs

Fixes warning in https://github.com/rerun-io/rerun/actions/runs/10662695291/job/29550372867?pr=7319

WARNING -  mkdocs_autorefs: common/blueprint_apis.md: Could not find cross-reference target ’https://github.com/rerun-io/rerun/issues/6673'

Checklist

[x] I have read and agree to Contributor Guide and the Code of Conduct
[x] I've included a screenshot or gif (if applicable)
[x] I have tested the web demo (if applicable):

Using examples from latest main build: rerun.io/viewer
Using full set of examples from nightly build: rerun.io/viewer

[x] The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
[x] If applicable, add a new check to the release checklist!
[x] If have noted any breaking changes to the log API in CHANGELOG.md and the migration guide

PR Build Summary
Recent benchmark results
Wasm size tracking

To run all checks from main, comment on the PR with @rerun-bot full-check.

Shouldn't the link in tensor_data.fbs be fixed as well?

All links in all python docs should be on the <…> form, but only those using the wrong […][] syntax will actually produce warnings.


Ignore target nets when checking for ACL matching

When external ACLs are processed, if the targets match the target networks then we always require authorization.
So, if a SynAck arrives from a network that matches a target network and the SynAck does not have authorization information, then it is dropped. We consider that target networks take priority over <IP_ADDRESS>/0 type of ACLs.

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0
[
  {
    "project": "",
    "component": "enforcerd",
    "pr-id": "1149",
    "commit-sha": "f0b200c4fa424b1ab088811d4feeb56d0ede9d2b"
  },
  {
    "project": "",
    "component": "trireme-lib",
    "pr-id": "785",
    "commit-sha": "4db509da86705ed28959e24b5f3c7a5b4996c710"
  }
]

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0
[
  {
    "project": "",
    "component": "trireme-lib",
    "pr-id": "785",
    "commit-sha": "4db509da86705ed28959e24b5f3c7a5b4996c710"
  },
  {
    "project": "",
    "component": "apotests",
    "pr-id": "2025",
    "commit-sha": "b022aa480b19f5f93b3cce8c9b80104738bc89bd"
  },
  {
    "project": "",
    "component": "enforcerd",
    "pr-id": "1149",
    "commit-sha": "f0b200c4fa424b1ab088811d4feeb56d0ede9d2b"
  }
]

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0
[
  {
    "project": "target-networks",
    "component": "apotests",
    "pr-id": "2025",
    "commit-sha": "0e77a66cfb732a74bba569c94b5613a27d91eb66"
  },
  {
    "project": "target-networks",
    "component": "trireme-lib",
    "pr-id": "785",
    "commit-sha": "4db509da86705ed28959e24b5f3c7a5b4996c710"
  },
  {
    "project": "target-networks",
    "component": "enforcerd",
    "pr-id": "1149",
    "commit-sha": "f0b200c4fa424b1ab088811d4feeb56d0ede9d2b"
  }
]

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0
[
  {
    "project": "target-networks",
    "component": "apotests",
    "pr-id": "2025",
    "commit-sha": "05c4f48b379f0a547ceb9672f310c6fe31fcb7bc"
  },
  {
    "project": "target-networks",
    "component": "trireme-lib",
    "pr-id": "785",
    "commit-sha": "4db509da86705ed28959e24b5f3c7a5b4996c710"
  },
  {
    "project": "target-networks",
    "component": "enforcerd",
    "pr-id": "1149",
    "commit-sha": "f0b200c4fa424b1ab088811d4feeb56d0ede9d2b"
  }
]

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0
[
  {
    "project": "target-networks",
    "component": "apotests",
    "pr-id": "2025",
    "commit-sha": "7f353ad2fd367950acabcf8678387d41681f02fb"
  },
  {
    "project": "target-networks",
    "component": "trireme-lib",
    "pr-id": "785",
    "commit-sha": "4db509da86705ed28959e24b5f3c7a5b4996c710"
  },
  {
    "project": "target-networks",
    "component": "enforcerd",
    "pr-id": "1149",
    "commit-sha": "f0b200c4fa424b1ab088811d4feeb56d0ede9d2b"
  }
]


Add support for len(range(...))

This will allow user to use len function on range objects.

Codecov Report

Merging #2367 into master will increase coverage by <.01%.
The diff coverage is 89.58%.

@@            Coverage Diff             @@
##           master    #2367      +/-   ##
==========================================
+ Coverage   86.21%   86.21%   +<.01%
==========================================
  Files         313      313
  Lines       59199    59247      +48
  Branches     6384     6394      +10
==========================================
+ Hits        51038    51081      +43
- Misses       7124     7128       +4
- Partials     1037     1038       +1

The CI failure looks like Travis related. Is there a way to restart it?

I just kicked it.

It looks like test discovery is failing.  We'll need to look more closely on those platforms to see what's happening.

My bad, it was actually the incompatible use of argument unpacking, which is tricky stuff. I've just fixed it in 7638333b8b317b7b039b6643943f6d587525d597. @seibert

Thanks!


Ps issue tracker

Coverage decreased (-0.1%) to 15.385% when pulling d3d39e9c50ec27308f49e02d6ac631a5f89b9f27 on ps_issue_tracker into 62ec15f88b88e618fa75f833ea200449f64fee2e on master.

Coverage decreased (-0.005%) to 15.506% when pulling e5757115ca8e5a4e348c79e56f76654559fd19c5 on ps_issue_tracker into 62ec15f88b88e618fa75f833ea200449f64fee2e on master.


disableWAL option

Search before asking

[X] I had searched in the issues and found no similar issues.

Motivation
We are using kvrocks with client sharding, also we can lose data. So, WAL is useless for us and it just makes additional write pressure.
Solution
I made some changes to ensure about this: https://github.com/apache/incubator-kvrocks/commit/bb1ba2eb0e2897b17e73ec3af8320d82d4872a07
I can replace rocksdb::WriteOptions() to global WriteOptions with optional disabledWAL, what do you think about it?
Are you willing to submit a PR?

[X] I'm willing to submit a PR!

Thanks for @tufitko feedback. So you don't need the replication, right?
I thinks we can add a new config option to let users to disable the WAL, and also need to forbid the slaveof command when the WAL is disabled since the replication can't work without it. How do you think?

@git-hulk yeah, we don't need replicas. About slaveof sounds good, so I'm gonna make PR at the weekends

Cool, thanks. Can just reply error in the slaveof command if the WAL is disabled.

What is the benefits from disabling WAL? This mechanism, as I remember, used for parallels writers, thats can work without blocking too. And, of course, data safety are poor. This only reduce a disk I/O, but in sequential mode (like WAL) I think, its no a lot of problem. maybe you want to reduce storage - you can disable wal history (in archive directory inside). Maybe this can help you quickly?

@aleksraiden It's exactly for reducing a disk I/O. We have a lot of data to write, so any reduction of IO helps us.

@tufitko, ok, interested to me too. I have a medium-load system (streams, ~20K rps, 100M+ msg in history, but 7.2.2 rocksdb) based on kvrocks, I will interest to test this patch too.


@conda-forge-admin, please add bot automerge

Additional comment:
v2.0.1

@conda-forge-admin,please add bot automerge

This is the wrong way to update conda-forge by bot.


Update code_hierarchy.py adding php support

Description
a very simple change adding support for php functions/classes/methods in code hierarchy
Fixes # (issue)
Did I bump the version in the pyproject.toml file of the package I am updating? (Except for the llama-index-core package)

[ ] Yes
[x] No

Type of Change
Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

[ ] Added new unit/integration tests
[ ] Added new notebook (that tests end-to-end)
[x] I stared at the code and made sure it makes sense

Suggested Checklist:

[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] I have added Google Colab support for the newly added notebooks.
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] I ran make format; make lint to appease the lint gods

@detain I can't push to your PR for some reason, but can you run linting: make lint  and also bump the version of the package in llama-index-packs/llama-index-packs-code-hierarchy/pyproject.toml


Try to fix autocomplete tests

This does something, but it definitely doesn't make the tests more likely to pass.


chore(core): Remove random key from render

Using the random key has been keeping me up at night, this is a much more explicit approach...
ReactDOM.unmountComponentAtNode(MOUNT_NODE)

😄

[Current coverage][cc-pull] is 70.58%

Merging [#941][cc-pull] into [master][cc-base-branch] will not change coverage

@@             master       #941   diff @@
==========================================
  Files            15         15
  Lines            85         85
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
  Hits             60         60
  Misses           25         25
  Partials          0          0

Powered by Codecov. Last updated by [02e872b...6288c2e][cc-compare]
[cc-base-branch]: https://codecov.io/gh/davezuko/react-redux-starter-kit/branch/master?src=pr
[cc-compare]: https://codecov.io/gh/davezuko/react-redux-starter-kit/compare/02e872b6ec8245038da4e3c13a9a598dd5c56b38...6288c2e47ca4a7c176e1581191b09c067e8d5a51?src=pr
[cc-pull]: https://codecov.io/gh/davezuko/react-redux-starter-kit/pull/941?src=pr

Hey there! Thanks for the fix, I've been pretty distant from this project lately so this is much appreciated. I cherry picked your commit into master because of the duplicate commit history in the PR, but we should be good to go: https://github.com/davezuko/react-redux-starter-kit/commit/a602625b20ade172c829b583882ae44c150e738c.


.jar execution on Win 32-bit Question

If no JRE installed on the system is there any way that .jar file can be executed ?
I tr

@AlexMilotin
If no java is installed on windows, It is safe.
However if you want to run scanner anyway, you should install JRE on windows.

Most of the applications in our environment seems that built-in java. Our remote people want to scan their old systems also, so i doubt that they have JRE installed.
That's why i looking for a portable java version


TCP remote logger issue

I run the collector in another machine that the LB.
But when collector receive a frame the error message is logged
INFO: 2021/11/08 18:06:55.225441 collector dnstap - ip:34116 - new connection
INFO: 2021/11/08 18:06:55.225563 dnstap processor - initialization...
INFO: 2021/11/08 18:06:55.225727 processor dnstap parser - running... waiting incoming dns message
ERROR: 2021/11/08 18:06:56.225753 collector dnstap - error stream receiver initialization: frame too large error

could you share your config.yml ?

config.txt

thanks and also your config in dns server side for the dnstap part ?

--DnsTap
fstl = newRemoteLogger("ip:6000")
addAction(AllRule(), DnstapLogAction("dnsdist03", fstl))
addResponseAction(AllRule(), DnstapLogResponseAction("dnsdist03", fstl))
-- Cache Hits
addCacheHitResponseAction(AllRule(), DnstapLogResponseAction("dnsdist03", fstl))

I suspect TLS is enabled in the collector (tls-support: true), is it not?

I have false for all tls-support fields.
Line 25:     tls-support: false
Line 149:     tls-support: false
Line 197:     tls-support: false
Line 215:     tls-support: false
Line 256:     tls-support: false

We are missing something because your case (dnsdist to collector) is used in github actions and it works fine.

Can you provide all the dependencies for dnscollector which must be installed on centos machine?

You can follow the guide here, you just need to download the binary from github and push it in your centos machine.

I follow the guide but install the collector in another machine that the dnsdist.
In your example you have installed dnsdist and collector on the same machine.

I don't succeed to reproduce on my side, it works well in all cases.
can you take a network trace ?

My collector and dnsdist is on the same subnet

and have you try on the same machine ?
by the way what is the version of your dnsdist ?

I don't have working dnsdist configuration with enabled newFrameStreamTcpLogger field. Every time service is failed with this error
dnsdist[3157]: Fatal Lua error: [string "chunk"]:24: Caught exception: fstrm with TCP support is required to build an AF_INET FrameStreamLogger
stack traceback:
[C]: in function 'newFrameStreamTcpLogger'
[string "chunk"]:24: in main chunk
dnsdist version is:
dnsdist 1.6.0 (Lua 5.1.4 [LuaJIT 2.0.4])
Enabled features: cdb dns-over-tls(gnutls openssl) dns-over-https(DOH) dnscrypt fstrm ipcipher libsodium lmdb protobuf re2 recvmmsg/sendmmsg snmp systemd

It's clear now, you must use the newFrameStreamTcpLogger to sent dnstap messages to the collector, I missed this point.
If your fstrm library does not support TCP and update is not possible, you can use newFrameStreamUnixLogger and follow this post

dnsdist will write dnstap to the unixsocket
stunnel read the unix socket and send dnstap messages to the collector with encrypted tunnel
TLS is activated in the collector.

when I  write dnstap to the unixsocket, is there any way to send dnstap message through a udp connection to dnscollector installed on another machine?

only tcp+tls

I have unstable stunnel on dnscollector side
Every five second TLS session is going reset or rejected from dnscollector side
I'm attached the stunnel log from both dnsdist server
dnsdist01_stunnel.txt
dnsdist02_stunnel.txt

could you try to add the following lines to your stunnel config ?
sslVersion = all
options = NO_SSLv2
options = NO_SSLv3

I was try it, but result is the same

on the dnsdist02, you have a network issue "connect_blocking: connect <IP_ADDRESS>:6000: Connection refused (111)", perhaps firewall is enabled on your collector?
can you retry with ?
ciphers=EECDH+AESGCM:EDH+AESGCM
sslVersion = TLSv1.2
options = NO_SSLv2
options = NO_SSLv3

I tried that too, the result is  the same
dnsdist01_stunnel_01.txt

Could you share the complete config of your stunnel and logs in dns collector side ?

Yes sure.
chroot = /var/run/stunnel
setuid = dnsdist
setgid = dnsdist
pid = /stunnel.pid
debug = 7
; Some performance tunings
socket = l:TCP_NODELAY=1
socket = r:TCP_NODELAY=1
ciphers=EECDH+AESGCM:EDH+AESGCM
sslVersion = TLSv1.2
options = NO_SSLv2
options = NO_SSLv3
[dnsdist-dnstaptls]
client=yes
accept=/var/run/stunnel/dnstap.sock
connect=<IP_ADDRESS>:6001
dnstap_collector.txt

Could you take a network dump between your dnsdist and the collector ?

Yes sure,
Pcap file size is 260MB, link to download it
https://wormhole.app/J3Kyx#RxBWODsnompUJkJ6i18OSA

Thanks, finally can you also share the config of your dnscollector ?
Can you try to remove the following options on your stunnel ?
socket = l:TCP_NODELAY=1
socket = r:TCP_NODELAY=1

config.txt

thanks; same behaviour with the TCP_NODELAY option ?

No, the result is the same

If you want, can you try to use the dns-collector instead of stunnel ?
Deploy the dns collector in your dnsdist lb, configure-it to read the dnstap unix socket and forward to your remote dns collector
Below a config example:
collectors:
  dnstap:
    enable: true
    sock-path: <replace_me_socket_path>
loggers:
  dnstap:
    enable: false
    remote-address: <replace_me_your_collector_ip>
    emote-port:  <replace_me_your_collector_port>

@anetrjuns  A new release 0.14.0 is available, please to re-test with this version and apply my previous post.
Feel free to re-open the issue.


Transaction list - add mosaic supply revocation transaction

Current behavior
The desktop wallet currently doesn't show revocation transactions on the transaction list.
Expected behavior
The desktop wallet should present revocation transactions on the transaction list. It should be:

icon same as for the mosaic definition transaction
"From" - address from which tokens were reclaimed
"To - address to which tokens are reclaimed
"Mosaics" - mosaic and amount reclaimed

Fixed in #1967


Fix README

it's just copy and pasted from my old overworld extension.

I removed overworld usage description from the readme, and made sure it fit the new structure.


Links to Colab need "right-click, open in a new tab"

See: GitHub Jupyter viewer blocking links to Google Colab at Stack Overflow.
If you know an answer, let me know!

target="_parent" solves it.