Added np.ndarray functionality & removed the input "stratify."

Outline of changes:
There are two changes that I have made.

I have altered the functions estimate_nbins() and scsplit() to be able to take both pandas dataframes and numpy arrays as inputs.

I have removed the input "stratify" from scsplit() and, additionally, have made the inputs "X" and "y" required. The reason I have done this is to make the function behave more like scikit-learn's train_test_split(X, y). I believe that this should provide a more seamless integration of the function into other people's projects.

Additionally, I have updated the readme to account for my changes. However, I have not changed the version info.

Hi Rhys,
Thank you for the contribution!
I really like your first point - the ability to receive arrays. This is great stuff!
However the second point contradicts sklearn convention.
Both options that you have disabled are available in sklearn.model_selection.train_test_split.
User can input one object without dividing it into X, y and indicate the specific column for straftification. E.g. train_test_split(data, stratify = data['y']).
I have specifically tested this when implementing the scsplit() method in order to follow the widespread practice.
You can check out the 'stratify' parameter here: https://scikit-learn.org/stable/modules/generated/sklearn.model_selection.train_test_split.html

Hi Danil,
On your second point. That is an approach to the stratify option in train_test_split() I haven't come across before. However, it does make sense in the case where the user would like to use a single input without dividing it into X, y and indicate the specific column for stratification. Thanks for pointing it out! 👍
I do however, think that making stratify a required variable is unnecessary in the case where you do use both X, y as inputs. With this in mind I've reverted the code back to having stratify as an input, but an optional one. I have also kept the numpy array functionality I initially added and will submit a Pull request shortly.
Let me know what you think when, and if still works as intended on your end. It works on mine, but of course there may be additional use cases you intend for the package that I have overlooked.


Look at errbit

Is the Errbit link up to date? Does someone has the login credentials and is it in use? And should we link it there?
see #690

IMHO we should remove Errbit references for now. I don't think anyone ever really used it anyways 😄

I think the earliest it makes sense to use it again would be in the final deployment, or at least any other kind of monitoring


Problem with Internationalization (I18N)

I don't understand why but I can't get the i18n to work.
my .env
I18N_SUPPORTED_LOCALES=en-US,es-ES
in locale there are 2 folders:
en_US -> LC_MESSAGES
es_ES -> LC_MESSAGES

I purged the cache and rebuild the templates
$ sudo -u www-data php ./index.php clear-template-cache
$ sudo -u www-data php ./index.php precompile-templates

I extracted all translatable strings
$ bash ./i18n.sh en-US
Extracting and updating translations
 * Creating PO (Portable Object) file for “en-US”
Created locale/en-US/LC_MESSAGES/messages.po.
 * Creating MO (Machine Object) file for “en-US”
Done

$ bash ./i18n.sh es-ES
Extracting and updating translations
 * Creating PO (Portable Object) file for “es-ES”
Created locale/es-ES/LC_MESSAGES/messages.po.
 * Creating MO (Machine Object) file for “es-ES”
Done

NOTE -> After this operations in locale created me other 2 folders
en-US -> LC_MESSAGES -> messages.mo, messages.po
es-ES -> LC_MESSAGES -> messages.mo, messages.po

1 QUESTION: Why we have to create folder in locale en_US instead en-US maybe the documentation is wrong ?
https://github.com/delight-im/PHP-I18N#directory-and-file-names-for-translation-files
en-US messages.po
#
msgid ""
msgstr ""
"Language: en-US\n"
"MIME-Version: 1.0\n"
"Content-Type: text/plain; charset=UTF-8\n"
"Content-Transfer-Encoding: 8bit\n"

msgid "Add"
msgstr ""

es-ES messages.po
#
msgid ""
msgstr ""
"Language: es-ES\n"
"MIME-Version: 1.0\n"
"Content-Type: text/plain; charset=UTF-8\n"
"Content-Transfer-Encoding: 8bit\n"

msgid "Add"
msgstr ""

I translated es-ES po
#
msgid ""
msgstr ""
"Language: es-ES\n"
"MIME-Version: 1.0\n"
"Content-Type: text/plain; charset=UTF-8\n"
"Content-Transfer-Encoding: 8bit\n"

msgid "Add"
msgstr "Añadir"

I updated the translations
$ bash ./i18n.sh es-ES
Extracting and updating translations
 * Creating PO (Portable Object) file for “es-ES”
......................................................................................................................................................... done.
 * Creating MO (Machine Object) file for “es-ES”
Done

Now in a file I tested
$app->i18n()->setLocaleManually('es-ES');

echo ('LANG: '. $app->i18n()->getLocale() .'
');

echo(_('Add'));

RESULT
LANG: es-ES
Add -> INSTEAD -> Añadir
Hope that my process is clear and find the solution.
Thanks.

Ok,
I decided to make a new installation and just write this:
index.php
<?php

$i18n = new \Delight\I18n\I18n([
    \Delight\I18n\Codes::EN,
    \Delight\I18n\Codes::ES,
    \Delight\I18n\Codes::IT
]);

$app->i18n()->setLocaleManually('en');

$app->get('/', [ '\App\HomeController', 'getIndex' ]);

Controller
<?php

namespace App;

use Delight\Foundation\App;

class HomeController {

	public static function getIndex(App $app) {

		$name = _('Hallo');

		\var_dump($app->i18n()->getLocale());
		\var_dump($app->i18n()->getSystemLocale());
		\var_dump($app->i18n()->getLocaleName());
		\var_dump($app->i18n()->getLanguageName());
		\var_dump($app->i18n()->getLocaleName('fr-BE'));
		\var_dump($app->i18n()->getLanguageName('fr-BE'));

		// and return a view
		echo $app->view('welcome.html.twig', [
			'users' => $name
		]);
	}

}

template
{% include 'includes/header.html.twig' %}

{{_('Hello world')}}

{{users}}
{% include 'includes/footer.html.twig' %}

If I change in italian clean the cache and restart the web server work. BUT
If I change again in en clean the cache and restart the web server doesn't work and this is the result
Z:\wamp\www\phpfoundation\app\HomeController.php:13:string 'en' (length=2)
Z:\wamp\www\phpfoundation\app\HomeController.php:14:string 'en.utf8' (length=7)
Z:\wamp\www\phpfoundation\app\HomeController.php:15:string 'inglese' (length=7)
Z:\wamp\www\phpfoundation\app\HomeController.php:16:string 'inglese' (length=7)
Z:\wamp\www\phpfoundation\app\HomeController.php:17:string 'francese (Belgio)' (length=17)
Z:\wamp\www\phpfoundation\app\HomeController.php:18:string 'francese' (length=8)
Ciao Mondo
Ciao
For let come back in english I need to delete in "it" folder the 2 file .mo and .po clear the cache and restart the web server.
I am frustrated :(

Thanks for doing the additional testing!
Don’t worry, I think we’re almost there, and after these initial setup problems on Windows, Gettext is an excellent system.

Don’t throw away and restart your projects anymore, please. The code and setup you have looks fine. This should be suitable for testing, and the problem is probably somewhere else, not in your code or setup.

Since you’re on Windows, can you please double check that you’re using the “Non Thread Safe (NTS)” version of PHP, and not the other one? Could you check your detailed PHP version? Since your version was probably bundled with WAMP, it’s highly likely that it’s the wrong one. This answer might help to install the correct one, which must use FastCGI instead of mod_php.

Please replace setLocaleManually('en') in your code with setLocaleAutomatically() and pass the language you want via GET parameters, e.g. lang=en or lang=it, which is easier during testing and avoids potential caching issues.

Are you using the I18N component in that test setup with or without the framework? If using without the framework, using that constructor is fine. If using with the framework, you should define the supported languages in the configuration in I18N_SUPPORTED_LOCALES instead.

If using it with the framework, please make sure that both I18N_SESSION_FIELD and I18N_COOKIE_NAME are empty. For easier testing, the language should only depend on your supplied GET parameter.

As soon as a language has shown up successfully once (especially with its strings in the templates), there’s no need to clear and re-generate the template cache anymore.

In WSL, where you also extract the strings from code and templates, can you run
$ sudo locale-gen xx_XX
$ sudo locale-gen xx_XX.UTF-8
$ sudo update-locale

once for every language (xx_XX, e.g. it_IT) that you intend to support?


add test script for "udp in" node

Before you hit that Submit button....
Please read our contribution guidelines
before submitting a pull-request.
Types of changes
What types of changes does your code introduce?
Put an x in the boxes that apply

[x] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)

If you want to raise a pull-request with a new feature, or a refactoring
of existing code, it may well get rejected if it hasn't been discussed on
the mailing list or
slack team first.
Proposed changes
Describe the nature of this change. What problem does it address?
There is no test script for udp in node.

add test script for udp in node.

Checklist
Put an x in the boxes that apply

[x] I have read the contribution guidelines
[ ] For non-bugfix PRs, I have discussed this change on the mailing list/slack team.
[x] I have run grunt to verify the unit tests pass
[x] I have added suitable unit tests to cover the new/changed functionality

Coverage decreased (-1.0%) to 86.603% when pulling 89043168b685a661ab620c2b79be07b445e910fc on HiroyasuNishiyama:feature/test-for-udpin-node into f57a0d4d6b3cea2fa782cf8fe2d12a887869c79d on node-red:master.

Coverage decreased (-0.9%) to 86.679% when pulling 3ba16dc98a57b79d2a80ddda5e90190f53bedfc2 on HiroyasuNishiyama:feature/test-for-udpin-node into f57a0d4d6b3cea2fa782cf8fe2d12a887869c79d on node-red:master.


[IMPROVEMENT] - Fix the responsiveness of website on mobile

Description
The website's pages aren't mobile responsive and the footer component is causing a screen overflow( see screenshots ).
The most likely causes are:

Different paddings for different breakpoints aren't specified in the styles.
The footer's input uses a fixed width and doesn't have the flex-wrap property

How to recreate

Visit zerominds.netlify.app on a mobile browser

How to fix

Adjust paddings according to screen breakpoints
Ensure that the footer doesn't have any element with a fixed width and has a flex-wrap property in the appropriate places

This could be broken down into different issues/pull requests or left as one pull request depending on the maintainer
Screenshots
Landing page

Landing page-2

Footer component

How it works page

How it works-2

Marketplace

Gallery

Additional information
No response

Thanks for creating this issues 🔥 . Would you be interested in working on the responsiveness of the footer? If yes, simply create a new issue explicitly for footer responsiveness and tag this one to it. If you cannot assign yourself, just tag me and I will assign you to it. You can start working on it.

@YuriDevAT Mam and @Nathanael-R Sir would you like to me assign this issue?

Thanks for creating this issues 🔥 . Would you be interested in working on the responsiveness of the footer? If yes, simply create a new issue explicitly for footer responsiveness and tag this one to it. If you cannot assign yourself, just tag me and I will assign you to it. You can start working on it.

Alright, I'm on it

I'm confused, what does staff only mean?


[Event Request] Table 458 "Overdue Approval Entry" - Function ShowRecord - OnBeforeShowRecord

Can you please add an event OnBeforeShowRecord to function ShowRecord in table "Overdue Approval Entry"?
The function could be a copy from table "Approval Entry", (requested earlier https://github.com/microsoft/ALAppExtensions/issues/9669)
    procedure ShowRecord()
    var
        RecRef: RecordRef;
        IsHandled: Boolean;
    begin
        IsHandled := false;
        OnBeforeShowRecord(Rec, IsHandled);
        if IsHandled then
            exit;

        if not RecRef.Get("Record ID to Approve") then
            exit;
        RecRef.SetRecFilter;
        PageManagement.PageRun(RecRef);
    end;

Please add the line RecRef.SetRecFilter as well. Just the same as in table Approval Entry.

Version to implement >= 18.1

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.


Update Antora UI styles

Description
This PR is meant to be first iteration of boost doc styling update, giving it a previous look-and-feel ui
Notes

Removes Cairo font
Adds modern sans-serif font fallback stack
Standard font size across elements and components
Fixes https://github.com/boostorg/website-v2-docs/issues/161

Where's the preview?

@alandefreitas how do you know that the preview is showing exactly how it will look on the live server? It already looks different... the preview has Lunr and Search box but those are not present on live.

how do you know that the preview is showing exactly how it will look on the live server?

I don't. website-v2 is an independent project and I have no idea of what transformations they've implemented there. For all I know, they could even be using another UI bundle.

Well we better figure this out then, shouldn't we?

@joaquintides Who understands the process in website-v2 that's patching the documentation with that boost.io header?
@vinniefalco It's a good idea to figure this out because we will need it. Since this PR is about the fonts, I think the header issue is independent of and shouldn't block this PR and @julioest.

@joaquintides Who understands the process in website-v2 that's patching the documentation with that boost.io header?

@julioest has been doing changes to this header laterly, so I guess he's the person you're looking for.

RevSys understands it. (Frank Wiles)

@julioest (...) 's the person you're looking for.

Well, that would be ironic 😆


Update community-hub-release-parent POM to 1.3.1

For folks using the community-hub-release-parent POM, an update is required because we recently moved from Nexus to Artifactory (learn more here). Please make sure you are using version 1.3.1 to avoid failed deployments.

Done by #225


Disable GenAI disclaimer

can you please review it.

Related to #326

is it correct now?

Since the i18n strings are gone I think it would make more sense to remove the component instead of commenting it out

sure

seems the checks are failing, please follow the formatting instructions in the readme :)


wasAssociatedWith and wasGeneratedBy replaced by associatedWith and generatedWith

According to the issue 12, the keys wasGeneratedBy and wasAssociatedWith have been replaced by associatedWith and generatedBy respectively. The context.json file has been modified to make this possible.

Thanks @thomasbtnfr! Looks great! I only have a tiny comment (see above) and then this is good to merge.

The problem with spm_load_config is fixed in PR #87.


Morning session issue 1/5/2023

Morning session issue 1/5/2023 on readme file

[x] It would be preferable to provide screenshots for the desktop and mobile versions as they are absent from your readme file.
[x] It would be perfect to  remove double quote from image array values

@zewdu444 . Thank you for the feedback 👍 . All issues have been sorted cheers 😃


services/cli: expose --json flag as regular variable [phab:D1639]

Created by schroederc at 2017-05-12 21:16:32:

fromberger accepted this revision at 2017-05-12 21:18:24

schroederc closed via commit b6831edbc7891d96855ec411aa30e9c459d3f330 at 2017-05-12 21:19:28


App Hanging when received new notification

After install shake and implemented initial of it, App Hanging when received new notification from Firebase in active App state.
In background and inactive states is working fine, but when app is in active state, App hanging!
My XCODE return this from debug:
EXC_BAD_ACCESS
__52-[FIRMessagingRmqManager querySyncMessageWithRmqID:]_block_invoke
#app_hanging
#firebase
#crash

+1 same issue

Please add a code snippet of how you included Shake in your app and enabled notifications.
Here's our documentation - you can check if your setup it correct. Note that we support notifications for iOS using APNs and Firebase for Android.
https://docs.shakebugs.com/docs/react/users/chat/#ios-notifications


Allow customizations of JsonSerializerOptions

Description

Added ability to customize serialization options for client-side Actor Proxies via static property on ActorProxy class
Added ability to customize serialization options for Actor Runtime via ConfigureJsonSerializationOptions in the IWebHostBuilder.UseActors extension

Issue reference
https://github.com/dapr/dotnet-sdk/issues/362
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list:

[ x ] Code compiles correctly
[ x ] Created/updated tests
[ x ] Extended the documentation

@rynowak & @vinayada1 - I have updated the code to the latest master and removed the static instances of the serialization. When you get a chance could you review again please?

Apologies for the messiness of this PR - this is my first PR to an open source project and I'm used to rearranging my own feature branch commits. I guess I shouldn't have done a force push as it has broken where the comments were pointing to...
Regardless - I have made the requested changes. Please review and let me know if there are any changes you'd like to see.

@LukePammant - it would be great to see this updated and try to get it merged within the next week. If you don't think that's doable one option is for me to take it over and finish. Let me know how you want to proceed, I want to make sure this is included in the next release.

@LukePammant - it would be great to see this updated and try to get it merged within the next week. If you don't think that's doable one option is for me to take it over and finish. Let me know how you want to proceed, I want to make sure this is included in the next release.

Awesome, thanks @rynowak! I just saw your change to master to move the initialization to startup.cs. The routing has been causing me massive headaches w/ trying to use the Spa middleware/default fallback route + Dapr Actors.
I'll rebase off of the latest master and address the topics you brought up. If we can keep this tight feedback loop going I can definitely try to own it through to completion.

Awesome, thanks @rynowak! I just saw your change to master to move the initialization to startup.cs. The routing has been causing me massive headaches w/ trying to use the Spa middleware/default fallback route + Dapr Actors.
I'll rebase off of the latest master and address the topics you brought up. If we can keep this tight feedback loop going I can definitely try to own it through to completion.

The routing has been causing me massive headaches w/ trying to use the Spa middleware/default fallback route + Dapr Actors.

It's good to get the confirmation that folks are trying this! I ran into the same problem using actors + blazor server in the same project.

The routing has been causing me massive headaches w/ trying to use the Spa middleware/default fallback route + Dapr Actors.

It's good to get the confirmation that folks are trying this! I ran into the same problem using actors + blazor server in the same project.

@rynowak - I'm done with the rebase and refactor. I have updated the code to be a little more clear about where to set the JsonSerializer options for the runtime and the proxies.
For the runtime you can set it via the ActorRuntimeOptions.JsonSerializerOptions via:
 services.AddActors(options =>
 {
     options.JsonSerializerOptions.AllowTrailingCommas = false;
     options.Actors.RegisterActor<DemoActor>();
 });

For the actor proxies/client:

You can set it per instance ActorProxy.Create via:

ActorProxy.Create<IMyActor>(actorID, actorType, proxyOptionsWithCustomSerializerOptions);

Or set it for all proxies by default via:

((ActorProxyFactory)ActorProxy.DefaultProxyFactory).DefaultActorProxyOptions.JsonSerializerOptions.Converters.Add(new JsonFSharpConverter());

Or

ActorProxy.DefaultProxyFactory = new ActorProxyFactory(proxyOptionsWithCustomSerializerOptions);

I haven't started on the unit tests yet. Once we are in agreement on the code I'll start on that. I will need a little time to wrap my head around the unit testing but I should be able to get it done :)

@rynowak - I'm done with the rebase and refactor. I have updated the code to be a little more clear about where to set the JsonSerializer options for the runtime and the proxies.
For the runtime you can set it via the ActorRuntimeOptions.JsonSerializerOptions via:
 services.AddActors(options =>
 {
     options.JsonSerializerOptions.AllowTrailingCommas = false;
     options.Actors.RegisterActor<DemoActor>();
 });

For the actor proxies/client:

You can set it per instance ActorProxy.Create via:

ActorProxy.Create<IMyActor>(actorID, actorType, proxyOptionsWithCustomSerializerOptions);

Or set it for all proxies by default via:

((ActorProxyFactory)ActorProxy.DefaultProxyFactory).DefaultActorProxyOptions.JsonSerializerOptions.Converters.Add(new JsonFSharpConverter());

Or

ActorProxy.DefaultProxyFactory = new ActorProxyFactory(proxyOptionsWithCustomSerializerOptions);

I haven't started on the unit tests yet. Once we are in agreement on the code I'll start on that. I will need a little time to wrap my head around the unit testing but I should be able to get it done :)

I added a simple set of unit tests. I didn't see a standard naming convention for the unit tests so I just copied from an arbitrary set of tests.

I added a simple set of unit tests. I didn't see a standard naming convention for the unit tests so I just copied from an arbitrary set of tests.


Pin Sphinx on Python 3.8.

This PR fixes #33 by pinning Sphinx on Python 3.8 to the last version that supported Python 3.8. It uses environment markers to avoid changing the Sphinx version on more recent Python versions.
PR Checklist:

[ ] All new features have been tested
[ ] All new features have been documented
[x] I have read the CONTRIBUTING.md file
[x] I will abide by the code of conduct

If successful, this might prove helpful to anyone preparing PRs for beeware/beeware#249, beeware/rubicon-objc#351, and beeware/briefcase#1411 while I'm at lunch.

Can I fix that build problem by adding a line to changes/32.misc.rst @freakboy3742?

The 3.12 failure isn't of your doing - there's a separate issue tracking that problem (#34). It's not a blocker for merging because 3.12 isn't finalised yet, so there's no guarantee that it works.

Live re-enactment:
https://github.com/beeware/toga-chart/assets/15906/c31c0bab-eeeb-4f1c-93fb-6067c75eed25


Test: Test CancelMPPTask in UT

What problem does this PR solve?
Issue Number: ref #4609
Problem Summary:
What is changed and how it works?

Start multiple compute services using different Context in UT.
Run tasks and compare result. In this condition, the root node should create multiple ExchangeReceiver to fetch result from different tasks, the merge the result.
Run tasks, then cancel all tasks of one query, and ensure all tasks of the query is aborted.

Check List
Tests

[ ] Unit test
[ ] Integration test
[ ] Manual test (add detailed scripts or steps below)
[ ] No code

Side effects

[ ] Performance regression: Consumes more CPU
[ ] Performance regression: Consumes more Memory
[ ] Breaking backward compatibility

Documentation

[ ] Affects user behaviors
[ ] Contains syntax changes
[ ] Contains variable changes
[ ] Contains experimental features
[ ] Changes MySQL compatibility

Release note

None

/run-all-tests

/run-all-tests

/run-unit-tests

/run-unit-tests

/run-unit-tests

/hold

/run-unit-tests

/run-unit-tests

/run-unit-tests

/run-unit-tests

/run-unit-tests

/run-integration-test

/run-all-tests

/run-integration-tests

/run-integration-tests

I know that, gtest will defaultly start many background threads for stroage usage. Do the PR suffer from this also?

I know that, gtest will defaultly start many background threads for stroage usage. Do the PR suffer from this also? And are these threads really needed?

Yes, I didn't change anything related to storage UT. But in this pr, we don't need to use storage components. Maybe I can simply disable storage related threads in every UT in compute engine UT.

I know that, gtest will defaultly start many background threads for stroage usage. Do the PR suffer from this also? And are these threads really needed?

Yes, I didn't change anything related to storage UT. But in this pr, we don't need to use storage components. Maybe I can simply disable storage related threads in every UT in compute engine UT.

Tracked this issue in #5782

/rebuild

/build

/merge

/run-all-tests


XRootD: The number of 'read ahead' elements requested in a readv call can exceed the server's limit

Uproot 4.0.2rc1
I'm sorry that I can't provide a root file / xrd server to reproduce this.
In
https://github.com/scikit-hep/uproot4/blob/3e53f480475883397a3a4e2dea199cdc00fd6477/uproot/source/xrootd.py#L326-L341
if the request_ranges list length exceeds readv_iov_max, the server will report the error "Read vector is too long" i.e.
   if (rdVecNum > XrdProto::maxRvecsz)
      return Response.Send(kXR_ArgTooLong, "Read vector is too long");

where rdVecNum = rdVecLen / sizeof(readahead_list);,  which corresponds to the number of elements in the request_ranges list sent to the server.
I think that the code at https://github.com/scikit-hep/uproot4/blob/3e53f480475883397a3a4e2dea199cdc00fd6477/uproot/source/xrootd.py#L294-L298
may be the cause, since it does the max element size check. Changing
     if len(all_request_ranges[-1]) > self._max_num_elements:

to
     if len(all_request_ranges[-1]) >= self._max_num_elements:

seems to fix the issue in my test. Will open a PR.

The PR #254 just changes the check slightly to make sure the length of any sublist in all_request_ranges never exceeds the limit.

The PR #254 just changes the check slightly to make sure the length of any sublist in all_request_ranges never exceeds the limit.


make API contract call functions return event_types

lib/agent0/agent0/hyperdrive/interactive/event_types.py  should live closer to the API and be imported from ethpy by the interface. The api trade functions (e.g. acync_open_long) should return the same event type dataclasses.

We'd really rather this all be done in pypechain; moved the issue there

nvm; not doing this bc it's too opinionated


Too high cognitive complexity for SettingsActivity.java

The cognitive complexity of SettingsActivity.java is too high which makes the control flow hard to understand.
File: /Settings/SettingsActivity.java


Publish latest Trust Wallet Core Java library to maven repository

Can you publish latest Trust Wallet Core Java library to maven repository so that we can use it , particularly latest version has AnySigner which is available in the latest iOS cocoa pod.

Automating published in maven:
api 'com.trustwallet:wallet-core:2.0.2'

Thanks @madcake , I think I was looking at a deprecated trust wallet maven entry.
I tried implementation 'com.trustwallet:wallet-core:2.0.2' in my Android project, and wonder how can I get access to class AnySigner(it is available in Trust Walelt CocoaPod).

can you check the tests? import wallet.core.java.AnySigner

@hewigovens
Yes AnySigner is available in tests as source code, but when I import com.trustwallet:wallet-core:2.0.2 as a dependency, AnySigner is not accessible.


Python syntax error on run

I get the following error when running the script on my environment:
>git issues
  File "C:\Program Files (x86)\Git/libexec/git-core\git-issues", line 335
    print [key for key in self.shelf.iterkeys()]
                 ^
SyntaxError: invalid syntax

I'm running Python 3.4.0 on Windows 8.

It's still a bug just for a presently untargeted platform. How hard will this be to fix?

How hard will this be to fix?

Pull request welcome, of course.


spot_cloudspace data resource does not output a working kubeconfig.

Problem
Kubeconfig output by the terraform provider does not result in a validly formatted or working kubeconfig.
How to Reproduce
terraform {
    backend "s3" {
        region = "us-east-2"
        bucket = "bucket-name"
        key = "rackspace-spot/argocd/terraform.tfstate"
    }

    required_providers {
        onepassword = {
            source = "1Password/onepassword"
            version = "1.4.3"
        }

        spot = {
            source = "rackerlabs/spot"
            version = "0.0.3"
        }
    }
}

provider "onepassword" {
}

# data "onepassword_item" "spot_credentials" {
#   vault = "Home_Lab"
#   title = "Rackspace-SPOT"
# }

provider "spot" {}

resource "spot_cloudspace" "cloudspace" {
  cloudspace_name    = "example"
  region             = "us-central-dfw-1"
  hacontrol_plane    = false
}

resource "spot_spotnodepool" "example" {
  cloudspace_name = "example"
  server_class    = "mh.vs1.2xlarge-dfw"
  bid_price       = 0.03
  autoscaling = {
    min_nodes = 2
    max_nodes = 4
  }
}

data "spot_cloudspace" "cloudspace" {
  id = spot_cloudspace.cloudspace.id
}

resource "local_sensitive_file" "home_kubeconfig" {
  content  = data.spot_cloudspace.cloudspace.kubeconfig
  filename = pathexpand("~/.kube/${data.spot_cloudspace.cloudspace.id}-kubeconfig.yaml")
}

Example redacted output of ~/.kube/org-id-redacted/example-kubeconfig.yaml from the kubeconfig on a first run, before the cloudspace has completed its provisioning.
apiVersion: v1
clusters:
- cluster:
        insecure-skip-tls-verify: true
        server: >-
        https:///
name: example
contexts:
- context:
        cluster: example
        namespace: default
        user: ngpc-user
name: rxtspot-example
current-context: rxtspot-example
kind: Config
preferences: {}
users:
- name: ngpc-user
user:
        token: >-
        ey..........MySuperLongTokenStringIRedacted............zg

Example redacted output of ~/.kube/org-id-redacted/example-kubeconfig.yaml from the kubeconfig on a first run, 45 minutes later, after the cloudspace had finished provisioning.
apiVersion: v1
clusters:
- cluster:
        insecure-skip-tls-verify: true
        server: >-
        https://vcp-REDACTED.cloud-REDACTED.spot.rackspace.com/
name: example
contexts:
- context:
        cluster: example
        namespace: default
        user: ngpc-user
name: rxtspot-example
current-context: rxtspot-example
kind: Config
preferences: {}
users:
- name: ngpc-user
user:
        token: >-
        ey..........MySuperLongTokenStringIRedacted............zg

Note that the kubeconfig does not output the server information, and does not properly indent the multiline text fields.
Expected Behavior

kubeconfig should be functional with all required data to connect to a cloudspace.
kubeconfig should be correctly formatted.

In my case it did output the server information with the valid server URL:
apiVersion: v1
clusters:
- cluster:
	insecure-skip-tls-verify: true
	server: >-
	https://REDACTED.spot.rackspace.com/
name: us-central-ord-1
contexts:
- context:
	cluster: us-central-ord-1
	namespace: default
	user: ngpc-user
name: rxtspot-us-central-ord-1
current-context: rxtspot-us-central-ord-1
kind: Config
preferences: {}
users:
- name: ngpc-user
user:
	token: >-
	REDACTED

It didn't output the OIDC config, but I only care about programmatic access.

ran my terraform a second time and got the server name.

Thanks @estenrye for raising this issue.

kubeconfig should be functional with all required data to connect to a cloudspace. i.e, kubeconfig does not output server information

We are working to improve this so that we can have a functional kubeconfig as soon as the control plane becomes ready.

kubeconfig should be correctly formatted.

@MarcPerezPro 's PR resolves the indentation issues. I have released a new version, v0.0.4, which includes this fix.

the spot_cloudspace data resource should allow the user to optionally toggle the resource to wait until the cloudspace is provisioned before moving on.

Would it be beneficial to include a boolean attribute wait_until_ready to the data source that allows users to output the kubeconfig only when it is operational?

I think it would be useful to have the wait parameter on both the cloudspace resource and the data source.
On the cloudspace resource to make sure that the cluster has been successfully created.
And on the cloudspace data source so we can get the kubeconfig for a cloudspace that has been created outside of terraform, without importing the cloudspace resource into the state.
But the priority is to have the wait parameter on the spot_cloudspace resource.


remove lib and move functionality to src/mimir_coordinator.py

This PR fixes #19

couple of minor nits (of which one is probably my past self's own fault) but looks good. Assuming there've been no code changes to the mimir-cluster lib code itself?

No, there were no code changes, just moved the code need by the coordinator.
In another PR we have to move the code needed byt the worker to the worker charm.
Besides we need to move the scenario test to the charm-relation-interface, since in that test we are testing the cluster interface.


Request: more modifiers

Would it be possible to add more modifier keys? For example caps lock, § or fn?

I think this should be added in this file /AeroSpace/Sources/AppBundle/config/keysMap.swift

Allowing to individually target left/right shift/alt/cmd would also be helpful imo.

Allowing to individually target left/right shift/alt/cmd would also be helpful imo.

Exactly! I'm from poland so i have to use alt for letters like ą ć ś etc. Possibility of set for example only left alt for mod key will be great.

Allowing to individually target left/right shift/alt/cmd would also be helpful imo.

This would be #VERY# important: In Germany eg. "@" is alt-L so the window-navigation fails. I could do right-alt-L to @ and left-alt-L to navigate.

A common workaround for non US keyboards is to use a software like https://hyperkey.app/ to map alt-ctrl-cmd to the capslock key.
I'm using alt-ctrl-cmd and alt-ctrl-cmd-shift as my primary modifier-prefix for all shortcuts in aerospace.

Allowing to individually target left/right shift/alt/cmd would also be helpful imo.

This would be #VERY# important: In Germany eg. "@" is alt-L so the window-navigation fails. I could do right-alt-L to @ and left-alt-L to navigate.

It isn't only the alt-L key. It's also alt-5 = [ , alt-8 = { etc. that are blocked due to the absence an alternative availability of "fn" which would work perfectly on a German keyboard layout.

we have the same exact need for french keyboard where alt is needed for special chars like [ { } ] or | (alt+shift+L)
I already use karabiner to map Caps Lock to Esc and Ctrl, so I cannot use @bcremer proposal :/

Is there a way to alias a combination of modifiers?
Such that I could write something like
mod1 ~ cmd-option-command
mod1 = workspace 1
mod1-shift = move-to-workspace 1
?

This is definitely a blocker for me, would love to try this out but having no support for differentiating right option from left option does not work with my setup.
I have tried implementing this and got the detection between right & left for the modifiers working, but got stuck because I ended up having to listen to both variants anyway.
The current limitation seems to be that HotKey does not support that distinction.


Update location of php common protos

Some time back the common protos were moved out of gax.

Can you do this in internal source control and let it propagate here?

Sure thing 👍


frame_number exceeding video length

Hi authors,
I am currently trying to set up the ego4d dataset for HOI-ref. But I find that some entries in the dataset have frame number higher than the length of the video. I have attached the code I am using to extract frames.
`
def save_ref_frame(frame_path=None, ego4d_root="/data/"):
video_id = frame_path.split("/")[-2]
frame_str = frame_path.split("/")[-1].rstrip(".jpg")
frame_number = int(frame_str.split("_")[-1])
video_path = f'{ego4d_root}/Ego4D/v2/clips/{video_id}.mp4'
target_frame_path = f'{ego4d_root}/{frame_path}'
frame_count = frame_number
video = cv2.VideoCapture(video_path)
if not video.isOpened():
print("Error: Could not open video.", video_path)
exit()
video.set(cv2.CAP_PROP_POS_FRAMES, frame_count)
success, frame = video.read()
print(f"video id: {video_id}, frame: {frame_str}")
print(f"video len : {int(video.get(cv2.CAP_PROP_FRAME_COUNT))}")
assert success == True
parent_path = Path(target_frame_path).parent
Path(parent_path).mkdir(parents=True, exist_ok=True)
cv2.imwrite(target_frame_path, frame)
def process(meta_file="hoiqa_dataset/ego4d-train.json"):
failed_metas = []
with open(meta_file, 'r') as file:
metas = json.load(file)
success = 0
for i, meta in tqdm(enumerate(metas[700000:]), total=len(metas)):
save_ref_frame(meta["image_path"])
success = success + 1
if name == "main":
process()
`
I get the following error and the video len is less than the frame number

I used the ego4d cli tool as follows to download the videos.
  ego4d --output_directory="/data/Ego4D/" \     --datasets clips \     --version v2 \     --video_uid_file ego4d-clip-ids.txt \     --aws_profile_name ego4d
Can you please let me know if I am doing something wrong or can you please provide scripts to extract frames from ego4d videos ?
Thank you,
Varun

Hello @vbelagali,
You'll have to use the videos from clip folder in Ego4D/v2 and account for the offset of the video by using this video['parent_start_frame']. Let me know if there is any confusion.
Regards,
Siddhant Bansal

Hi Siddhant,
Thanks for the guidance. Can you please confirm if folder name is clip or clips ?
I can locate the parent_start_frame in manifest.csv file

Do I need to subtract the parent_start_frame from the frame_number to get the correct offset ?


Add legacy browser warning, fixes #32

Simple, similar to what we did on System76's site.

Well, IE10 ?
IE9 supports most of the HTML5 and CSS3 features, we can support it and diaplay this message for IE<=8.

{ should have a preceding space.

@KeitIG good call I'll update it.
@lewisgoddard ah I didn't realize that was our style. Update incoming.

Oh, I think you had two < before the closing tag. Didn't notice, my bad.

Or is that how IE tags look? Damnit, closed my VM.

@lewisgoddard naw you're right, fixing.


Focus Main Window via KEY is Broken

From<EMAIL_ADDRESS>on February 06, 2014 17:45:17
subj
SWS Focus Main main window or Focus Main window (close others) doesn't work when i bind it on keyboard key. If i RUN it via Actions button "RUN" all works good.
Original issue: http://code.google.com/p/sws-extension/issues/detail?id=624

It works if I use Command key in my macro


Use a "local" LLM to avoid communication outside of the user company

Is there are risk of "leaking" information to the external LLM that is used (e.g. from OpenAI) ?
For that reason (valid or not), I presume large corporations (and small ones) will have policies and firewall rules that will block or audit access to external LLM services at some point.
Adding the option of a locally running LLM under management of the user company will be valuable for corporate customers.
Willing to contribute, e.g. Alpaca or LLaMa may offer a solution ? Untested, but curious to try ...

Hi Peter,
Yes, that is indeed a risk and one of my concerns. Currently, this issue is on the roadmap, but I haven't designed the integration yet.
If you want to contribute, that would be more than welcome. My idea so far is to have a module similar to the llms from LangChain, but we don't need to support all those LLMs. All models inside the llms module will need the same interface, so we can plug it into the CLI. There is still one thing missing in this design: "how to make it possible for the user to select which LLM to use?". It could be done via environment variables or a configuration file.

have a look at lightllm.ai , a library, proxy, router, cache, etc.
it's often used and very relyable.


Using container element the right way

VirutalList attempts to directly add the needed event listeners directly to the DOM element. I have found this can cause the error Cannot read property addEventListener of null in certain cases, because componentDidMount on the virtual list is being called before the parent has rendered.
Is there any obvious work-around for this or is there something wrong with our lifecycle management?

Hmm, nothing obvious comes to mind.  Would you be able to post the relevant code, and also your exact version of React?  I'd love to take a closer look.

@CAYdenberg Do you happen to have any more info around this?

We've worked around and aren't using refs. I will close this for now and let you know if I come across it again.

Thanks @CAYdenberg - I'm going to come up with another demo implementation just to be sure things are working properly.

Hey @CAYdenberg - may I ask how did you solve this issue?
@developerdizzle - will you have time to add another demo with a default container (on load)?

Like we aren't using refs currently. IIRC, we needed it to set the scrollbar, but we worked around by just using window scroll and reworking some other element positioning.
If I circle back to this at some point I'll be sure to update this.

+1 to this issue, even it's closed

I spent a lot of time to get this working correctly but I couldn't unfortunately
the only thing I could think of (couldn't get it to work though) is to use a closure to only initialize the list once and call it from the render method (after the refs has been updated)
and everytime you call the this method again it will return a reference to the initalized list

I slept on it and found a solution,
I initialized the list in ComponentDidMount where you have access to the refs
And saved the list in the state
  componentDidMount() {
    this.setState({
      VList: VirtualList({
        container: this.refs.usersContainerRef,
      })(this.listOptions),
    });
  }

and in the render method I used the initialized component:
<this.state.VList items={} itemHeight={} />
and it worked!


Updates to support XamlBuildTask

This PR is to fix an issue with VS "15" being unable to build workflow projects. Workflow projects use a custom MSBuild task called XamlBuildTask. XamlBuildTask creates a new AppDomain that attempts and fails to load the GAC version of MSBuild assemblies rather than the applocal ones in VS "15".
Microsoft.Xaml.targets in this version of MSBuild is a shim to load the .NET Framework version. The XamlBuildTaskPath MSBuild property is used as the ApplicationBase for the new AppDomains by XamlBuildTask. This PR sets this property to the applocal folder. In concert, we are placing XamlBuildTask.dll in the applocal folder of VS "15".
The other change is to apply an assembly binding redirect from the framework version (<IP_ADDRESS>) of XamlBuildTask to the VS "15" version (<IP_ADDRESS>). This is to ensure we are not loading the framework version.

Overall I think it looks ok to unblock, but I think it's worth doing something else with the "shim" target. Since it's pretty much guaranteed not to work, perhaps even removing the file entirely might be appropriate? That will cause builds to fail in a more obvious way when in this scenario. At minimum it should not try to import itself though, even if it's just left alone.
Also, can you please update the commit message? This is very odd and not at all obvious what's going on without more context, I don't want someone else to be completely confused in 6 months. It would be worth noting that this is in place so that VS can place the target/DLL in the correct location at setup time and the scenario is currently only supported from VS. And come to think of it I do think it's worth touching the "shim" file so it gets included in the commit for the message, even if you just add a comment that the file is now replaced.
Thanks!

Why is the binding redirect necessary? Doesn't the version in the UsingTask cause MSBuild to load the right version?

Is the suggestion to replace the shim targets file with a copy of the original? We could do that but it's not necessary. It boils down to the same change to the XamlBuildTaskPath property. I like the shim because it's clearer what the delta is between the framework version and the VS 15 version when we're doing maintenance in the future.

@dmetzgar I still don't understand the need for the binding redirects. Can you explain? It's a high burden for people that ship apps that do programmatic builds to add your version redirects, so it'd be nice to avoid it. And as long as the task is getting loaded from a .targets file you control, you shouldn't need to redirect a task assembly.

@rainersigwald What we're seeing is that without the binding redirect both the local version and the GAC version get loaded into memory. @erikcai8, can you add more detail?

@rainersigwald We did not take control of Microsoft.Xaml.targets in this change yet. It still redirects to the on released by NetFx. That's probably next step since we don't have enough time to fully test it in this VS Preview 4 release.
The reason why MSBuild would load 2 XamlBuildTask.dll in MSBuild without binary redirections is because "Microsoft.Xaml.targets" specifies to load the first XamlBuildTask.dll in GAC, and in the loaded XamlBuildTask.dll, it creates new app domains which would load the 2nd XamlBuildTask.dll in app-local.

@erikcai8 So the redirect is a temporary measure until you can update the targets file to load the new version of the DLL? That would be fine with me.

@rainersigwald Yes, that's the plan if the binary redirection is not preferred.

@AndyGerlicher @rainersigwald please have a look. We're hoping to get this in through shiproom today so there's one day to test before the end of escrow.

LGTM.  @AndyGerlicher ?


API enhancements

Can we have a package to maintain the WebSocket subscriptions , and fetching data made simpler with web sockets  for multiple securities and similar for rest api's ,
I've been trying to do the same using async and using multiprocessing to make it faster on my end but cannot come up with a scaleable general utility for my use case.

Assume my usecase for 20000 conids.

Hi @dikshantctin thanks for sharing your request.
I'm sorry but I'm not entirely sure what are you trying to describe here. Are you making a feature request? Or asking for advice? If you could expand on your example use case in more detail I'd appreciate it. Outline what is the bottleneck or pain point in the current API that you're experiencing and how you'd imagine it improved.

import os
import signal
import sys
import time
import redis
import json
from multiprocessing import Process
from ibind import IbkrWsKey, IbkrWsClient, ibind_logs_initialize
from utils import DBUtils, Logger
logger = Logger.getLogger(name)
Initialize logs (no need to log to a file)
ibind_logs_initialize(log_to_file=True)
fetching conids from a list of 30000 symbols
conids = [list of securities
]
Function to split conids into batches
def batch_conids(conids, num_batches):
batch_size = len(conids) // num_batches
return [conids[i * batch_size: (i + 1) * batch_size] for i in range(num_batches)]
Split the conids into batches
conid_batches = batch_conids(conids, 10)
Fields to request market data for
market_data_fields = ['55', '71', '84', '86', '88', '85', '87', '7295', '7296', '70']
Function to process each batch of conids and subscribe to market data
def websocket_subscription_for_batch(conids_batch, redis_key):
ws_client = IbkrWsClient(cacert=os.getenv('IBIND_CACERT', False))  # Each process initializes its own client
ws_client.start()
redis_client = redis.Redis(host='localhost', port=6379, db=0)  # Initialize Redis in each process
market_queue_accessors = ws_client.new_queue_accessor(IbkrWsKey.MARKET_DATA)

# Create subscription requests for each conid in the batch
requests = [{'channel': f'md+{conid}', 'data': {"fields": market_data_fields}} for conid in conids_batch]

def stop(_, _1):
    for request in requests:
        ws_client.unsubscribe(**request)
    ws_client.shutdown()

signal.signal(signal.SIGINT, stop)
signal.signal(signal.SIGTERM, stop)

for request in requests:
    while not ws_client.subscribe(**request):
        time.sleep(1)

# Process market data as long as the WebSocket client is running
while ws_client.running:
    try:
        while not market_queue_accessors.empty():
            data = market_queue_accessors.get()

            # Serialize the market data as JSON and push it to Redis
            json_data = json.dumps(data)
            redis_client.rpush(redis_key, json_data)
    except KeyboardInterrupt:
        logger.info(f"Shutting down market data processing for batch: {redis_key}")
        break

if name == "main":
# Create processes, each processing a batch of conids
processes = []
for i, conids_batch in enumerate(conid_batches):
redis_key = f'market_data_batch_{i + 1}'  # Unique Redis key for each batch
process = Process(target=websocket_subscription_for_batch, args=(conids_batch, redis_key))
processes.append(process)
# Start all processes
for process in processes:
    process.start()

# Wait for all processes to complete
for process in processes:
    process.join()

Let meknow if you need help understanding what i am trying to achieve

I see that in you usage examples you have are trying to make requests for a few con id's . How should i move forward if i have to use your package to build a scalable solution to work with a universe of securities.
For example: consider i am building a portfolio,
Now that i have the portfolio, I want to fetch latest prices for it.
I can't understand how i can use Ibind to give me live prices for that, and use it within my pandas dataframe of portfolio.
Also, If you see, i have to make a call-in loop to subscribe to market data for security, or when using the rest client as IB API endpoints only allows us to do that. Will it be possible that we can pass a list of accounts, symbols to do such operations, (adding the functionalities of ib_async package here) If yes How?

@dikshantctin thanks for expanding with a description.

How should i move forward if i have to use your package to build a scalable solution to work with a universe of securities.

This heavily depends on what you're trying to do precisely. If you can ask direct questions regarding the areas you'd need help with it we could see if there's anything that can be shared that would aid you.

I can't understand how i can use Ibind to give me live prices for that

You can query them from the REST API:
https://github.com/Voyz/ibind/wiki/API-Reference-‐-IbkrClient#client.ibkr_client_mixins.marketdata_mixin.MarketdataMixin.marketdata_history_by_symbols
https://github.com/Voyz/ibind/blob/master/examples/rest_05_marketdata_history.py
Or get a stream from the WS API:
https://github.com/Voyz/ibind/blob/master/examples/ws_03_market_history.py

Will it be possible that we can pass a list of accounts, symbols to do such operations,

Accounts no, you can only work with one account at a time. This is a limitation imposed by the fact that only one session can be authenticated at a time. If you have a gateway with an authenticated session deployed for each account and you can wrangle where the requests are going out to, then you could do it, but it sounds complex.
Symbols yes, IBind supports querying multiple symbols at a time.

adding the functionalities of ib_async package here

Which functionalities in particular? Please be specific and outline them in detail.

I'm going to close this issue due to inactivity. Thanks for your contribution and please feel free to request a reopen if you'd like to continue the discussion 👍


Unchecking SHOW_ON_START results in blank graph

In the latest version of the plugin, the fix for the panel persisting breaks the graph. Now with the SHOW_ON_START unchecked, the graph is blank:

I cannot reproduce this.
Can you confirm it is still an issue and if so
check Help > Toggle development tools and copy any error message that pops up?
Also does this happen at startup or after exiting the settings?

For me it happens if SHOW_ON_START is unchecked and then upon restarting Joplin the graph is blank.
This is the only error message I saw that mentioned this plugin directly:

It seems that Joplin is trying to update its layout and fails to do so.
The user preferences for the layout may be corrupted.
I would guess that uninstalling and reinstalling the graph plugin should fix the problem, as it will probably re-register.
Failing code from  Joplin :
		case 'MAIN_LAYOUT_SET_ITEM_PROP':

			{
				let newLayout = produce(state.mainLayout, (draftLayout: LayoutItem) => {
					iterateItems(draftLayout, (_itemIndex: number, item: LayoutItem, _parent: LayoutItem) => {
						if (item.key === action.itemKey) {
							(item as any)[action.propName] = action.propValue;
							return false;
						}
						return true;
					});
				});

Uninstalling and reinstalling the plugin fixed it! I'll close this issue.


Roadmap: Voting count doesn't work

NSErrorFailingURLStringKey=https://api.countapi.xyz/hit/dev.simonberner.GitHubFollowMe/feature3, NSErrorFailingURLKey=https://api.countapi.xyz/hit/dev.simonberner.GitHubFollowMe/feature3, _kCFStreamErrorDomainKey=4}
Voting failed: La requête a expiré.

⚠ The countAPI which we use in Roadmap to let users vote has been down for two weeks or so. They're looking into it, but currently roadmap is unfortunately not working.
see announcement on https://github.com/AvdLee/Roadmap


avoid_returning_widgets lint showing up for all the methods that return a widget

Is there an existing issue for this bug?

[X] I have searched the existing issues.

Bug Description
avoid_returning_widgets lint showing up for all the methods that return a widget. It should be restricted to the methods only in the StatelessWidgets and State classes. We can also hide it for methods that are overridden.
Following are the examples of the false lint warning in a InhertedWidget class and a PageTransitionBuilder class.

Steps to Reproduce
Just declare any method that returns a widget.
Additional Information
No response

Thanks for the bug report.
I agree methods with override annotation should be ignored by the lint. But do we want to restrict the lint for the widget classes only? I do think the lint should check for top level functions.
For the InheritedWidget case, would it be enough if the lint ignores method with name of?
We could also add options for the lint and let users to configure what method names and annotations should the lint ignore.

We can go either way, restrict the lint for only widget classes and top-level functions or handle method name cases. In the latter, we need to handle of, maybeOf method names or we can handle the static method case directly.

Hello! The lint now ignores static and overridden methods.
I have also added ignored_method_names options.
You could try the latest version with
pyramid_lint:
  git:
    url: https://github.com/charlescyt/pyramid_lint.git
    ref: 023526a

I think we should ignore it for extensions as well.

I have updated the lint to ignore extension methods. Feel free to reopen the issue if there are any problems.


Handle sys_open with mode != 0

A follow-up on #473
https://github.com/obhq/obliteration/blob/332b70cf100552aba085710870a973b5a30a62b2/src/kernel/src/fs/mod.rs#L257

Normally this argument must be ignored if O_CREAT is not supplied. Need to check how PS4 handled this case.

@ultimaweapon Tons of games crash on this unwrap, by the way. I thought I put it in this issue, but it turns out I didn't.
https://github.com/obhq/obliteration/blob/b5722ffe50df3cc3028c5c500f8efa4d722e043c/src/kernel/src/fs/mod.rs#L234
The PS4 seems to treat this as a dword pointer, ignoring the upper dword. Do we do the same?

The PS4 seems to treat this as a dword pointer, ignoring the upper dword. Do we do the same?

Where is this on the PS4?

when sys_open passes the arg to kern_openat.

The PS4 seems to treat this as a dword pointer, ignoring the upper dword. Do we do the same?

That is not a correct place to fix this. This argument will contains a garbage if the caller did not supplied to the kernel. What we should do is checking how the PS4 use this argument in the kern_openat.

I think I understand. Thanks


updater: enable fetching of RHEL 5 vulnerabilities

The RHEL updater currently ignores vulnerabilities for CentOS <= 5.
s the naming of the constant firstConsideredRHEL suggests it, it
should actually considers CentOS 5 and ignores CentOS < 5.
Fixes #215

As soon as LGTM, this should be backported to release-1.1 and release-1.2.

LGTM

We should cherrypick this commit into the stable branch, too.

this is still cousing problems for me. after the fix im getting this error when adding/updating vulns to DB:
2016-09-06 11:57:16.941243 E | pgsql: insertVulnerabilityFixedInFeature: pq: duplicate key value violates unique constraint "vulnerability_fixedin_feature_vulnerability_id_feature_id_key"

database.Vulnerability{Model:database.Model{ID:0}, Name:"RHSA-2009:0382", Namespace:database.Namespace{Model:database.Model{ID:0}, Name:"centos:5"}, Description:"libvirt is a C API for managing and interacting with the virtualization capabilities of Linux and other operating systems. libvirt also provides tools for remotely managing virtualized systems. The libvirtd daemon was discovered to not properly check user connection permissions before performing certain privileged actions, such as requesting migration of an unprivileged guest domain to another system. A local user able to establish a read-only connection to libvirtd could use this flaw to perform actions that should be restricted to read-write connections. (CVE-2008-5086) libvirt_proxy, a setuid helper application allowing non-privileged users to communicate with the hypervisor, was discovered to not properly validate user requests. Local users could use this flaw to cause a stack-based buffer overflow in libvirt_proxy, possibly allowing them to run arbitrary code with root privileges. (CVE-2009-0036) All users are advised to upgrade to these updated packages, which contain backported patches which resolve these issues. After installing the update, libvirtd must be restarted manually (for example, by issuing a \"service libvirtd restart\" command), and guest systems rebooted, for this change to take effect.", Link:"https://rhn.redhat.com/errata/RHSA-2009-0382.html", Severity:"Medium", Metadata:database.MetadataMap(nil), FixedIn:[]database.FeatureVersion{database.FeatureVersion{Model:database.Model{ID:0}, Feature:database.Feature{Model:database.Model{ID:0}, Name:"libvirt-python", Namespace:database.Namespace{Model:database.Model{ID:0}, Name:"centos:5"}}, Version:types.Version{epoch:0, version:"0.3.3", revision:"14.el5_3.1"}, AffectedBy:[]database.Vulnerability(nil), AddedBy:database.Layer{Model:database.Model{ID:0}, Name:"", EngineVersion:0, Parent:(*database.Layer)(nil), Namespace:(*database.Namespace)(nil), Features:[]database.FeatureVersion(nil)}}, database.FeatureVersion{Model:database.Model{ID:0}, Feature:database.Feature{Model:database.Model{ID:0}, Name:"libvirt-devel", Namespace:database.Namespace{Model:database.Model{ID:0}, Name:"centos:5"}}, Version:types.Version{epoch:0, version:"0.3.3", revision:"14.el5_3.1"}, AffectedBy:[]database.Vulnerability(nil), AddedBy:database.Layer{Model:database.Model{ID:0}, Name:"", EngineVersion:0, Parent:(*database.Layer)(nil), Namespace:(*database.Namespace)(nil), Features:[]database.FeatureVersion(nil)}}, database.FeatureVersion{Model:database.Model{ID:0}, Feature:database.Feature{Model:database.Model{ID:0}, Name:"libvirt", Namespace:database.Namespace{Model:database.Model{ID:0}, Name:"centos:5"}}, Version:types.Version{epoch:0, version:"0.3.3", revision:"14.el5_3.1"}, AffectedBy:[]database.Vulnerability(nil), AddedBy:database.Layer{Model:database.Model{ID:0}, Name:"", EngineVersion:0, Parent:(*database.Layer)(nil), Namespace:(*database.Namespace)(nil), Features:[]database.FeatureVersion(nil)}}, database.FeatureVersion{Model:database.Model{ID:0}, Feature:database.Feature{Model:database.Model{ID:0}, Name:"libvirt-python", Namespace:database.Namespace{Model:database.Model{ID:0}, Name:"centos:5"}}, Version:types.Version{epoch:0, version:"0.3.3", revision:"14.el5_3.1"}, AffectedBy:[]database.Vulnerability(nil), AddedBy:database.Layer{Model:database.Model{ID:0}, Name:"", EngineVersion:0, Parent:(*database.Layer)(nil), Namespace:(*database.Namespace)(nil), Features:[]database.FeatureVersion(nil)}}, database.FeatureVersion{Model:database.Model{ID:0}, Feature:database.Feature{Model:database.Model{ID:0}, Name:"libvirt-devel", Namespace:database.Namespace{Model:database.Model{ID:0}, Name:"centos:5"}}, Version:types.Version{epoch:0, version:"0.3.3", revision:"14.el5_3.1"}, AffectedBy:[]database.Vulnerability(nil), AddedBy:database.Layer{Model:database.Model{ID:0}, Name:"", EngineVersion:0, Parent:(*database.Layer)(nil), Namespace:(*database.Namespace)(nil), Features:[]database.FeatureVersion(nil)}}, database.FeatureVersion{Model:database.Model{ID:0}, Feature:database.Feature{Model:database.Model{ID:0}, Name:"libvirt", Namespace:database.Namespace{Model:database.Model{ID:0}, Name:"centos:5"}}, Version:types.Version{epoch:0, version:"0.3.3", revision:"14.el5_3.1"}, AffectedBy:[]database.Vulnerability(nil), AddedBy:database.Layer{Model:database.Model{ID:0}, Name:"", EngineVersion:0, Parent:(*database.Layer)(nil), Namespace:(*database.Namespace)(nil), Features:[]database.FeatureVersion(nil)}}}, LayersIntroducingVulnerability:[]database.Layer(nil), FixedBy:types.Version{epoch:0, version:"", revision:""}}

note the problematic vulnerability is assosiated with centos 5.
also when removing = from the fix:
if osVersion > firstConsideredRHEL {

and stop suporting centos 5 conflict is solved
any idea?


Are game event timestamps really distinct

The current event handling code will do wrong things if two events have precisely the same timestamp. It might be unlikely, but who knows what kind of discretization the browser applies. Or what happens when one clicks the mouse while moving.
And it looks bad when describing the algorithm we use.
So maybe something should be done here. Not sure yet what.

The paper algorithm has this fixed. Just needs to be deployed.


build_ext --inplace argument doesn't work when directory has init.py

setuptools version
62.3.2
Python version
3.10.0
OS
macOS Monterey 12.2
Additional environment information
MacBook Pro (13-inch, M1, 2020)
Description
When I use the --inplace argument to build a .pyx file, such as python setup.py build_ext --inplace the .so file gets copied to the correct directory only if __init__.py doesn't exist.
File Structure:
engine
├── __init__.py
├── render.pyx

Terminal Output:
engine ✗ python setup.py build_ext --inplace
...
copying build/lib.macosx-11.1-arm64-3.10/engine/render.cpython-310-darwin.so -> engine
error: could not create 'engine/render.cpython-310-darwin.so': No such file or directory

It seems like having __init__.py makes build_ext point to the directory 'root_directory/engine', even though it doesn't exist.
WIth  __init__.py removed, the last line of the terminal output becomes
copying build/lib.macosx-11.1-arm64-3.10/render.cpython-310-darwin.so ->

which solves the issue.
Expected behavior
The terminal should be running
"copying build/lib.macosx-11.1-arm64-3.10/engine/render.cpython-310-darwin.so ->"
instead of
"copying build/lib.macosx-11.1-arm64-3.10/engine/render.cpython-310-darwin.so -> engine"
How to Reproduce

pip install Cython in your python environment.
Create setup.py and cython file (test.pyx) the same directory.

# setup.py
from setuptools import setup
from Cython.Build import cythonize

setup(
    ext_modules=cythonize(["test.pyx"]),
)

# test.pyx
def test():
    print('test')

Create __init__.py file in the same directory
Run terminal command python setup.py build_ext --inplace

Output
test ✗ python setup.py build_ext --inplace
Compiling test.pyx because it changed.
[1/1] Cythonizing test.pyx
/opt/homebrew/Caskroom/miniforge/base/envs/pygame/lib/python3.10/site-packages/Cython/Compiler/Main.py:369: FutureWarning: Cython directive 'language_level' not set, using 2 for now (Py2). This will change in a later release! File: /Users/williamhou/Desktop/test/test.pyx
  tree = Parsing.p_module(s, pxd, full_module_name)
running build_ext
building 'test.test' extension
creating build
creating build/temp.macosx-11.1-arm64-3.10
clang -Wno-unused-result -Wsign-compare -Wunreachable-code -DNDEBUG -g -fwrapv -O2 -Wall -fPIC -O2 -isystem /opt/homebrew/Caskroom/miniforge/base/envs/pygame/include -arch arm64 -fPIC -O2 -isystem /opt/homebrew/Caskroom/miniforge/base/envs/pygame/include -arch arm64 -I/opt/homebrew/Caskroom/miniforge/base/envs/pygame/include/python3.10 -c test.c -o build/temp.macosx-11.1-arm64-3.10/test.o
creating build/lib.macosx-11.1-arm64-3.10
creating build/lib.macosx-11.1-arm64-3.10/test
clang -bundle -undefined dynamic_lookup -Wl,-rpath,/opt/homebrew/Caskroom/miniforge/base/envs/pygame/lib -L/opt/homebrew/Caskroom/miniforge/base/envs/pygame/lib -Wl,-rpath,/opt/homebrew/Caskroom/miniforge/base/envs/pygame/lib -L/opt/homebrew/Caskroom/miniforge/base/envs/pygame/lib build/temp.macosx-11.1-arm64-3.10/test.o -o build/lib.macosx-11.1-arm64-3.10/test/test.cpython-310-darwin.so
copying build/lib.macosx-11.1-arm64-3.10/test/test.cpython-310-darwin.so -> test
error: could not create 'test/test.cpython-310-darwin.so': No such file or directory

https://stackoverflow.com/questions/71983019/why-does-adding-an-init-py-change-cython-build-ext-inplace-behavior
Here is one that I found. I remember seeing more when I was trying to solve this myself, but there are a lot hidden out there on the internet. I guess it's really easy to stumble across this isue.


Issue with function signatures

I have some php files. I am able to run SAMI with no issue. The html output outputs the class hierarchy etc. correctly. Function comments are also generated correctly, however function variables (signature) is not correctly documented. As an example, I have the following piece of code with the comments:
/**
* Downloads a file.
*
* @param string $file         is the name of the object to be downloaded
* @param string $saveLocation is the location that the dowloaded object will be stored locally
*
* @return string[]|null
*/
public function downloadFile($file, $saveLocation, $s3 = null){
...//some code hhere
}
The comment: "Downloads here" and the return value show up correctly on the html output, however I can't get the comments of the params along with their type to show up. I am trying to mimic examples from symphony:
https://github.com/symfony/symfony/blob/master/src/Symfony/Component/Asset/PathPackage.php
Any help would be appreciated!

What is the problem, I'm not getting. Do you miss $s3 parameter in generated doc?

No what I'm trying to say is that the comments I put for the variables don't show up on the generated document, as in comments for $file should say:
$file is the name of the object to be downloaded
etc.
In my composer, due to ubuntu version issues, I'm using version 3.3.0 (under require-dev in composer)

@Param should be lowercase, and the documentation should be immediately before the method (no blank line in between).

Valid point @xelan . That really can confuse DocBlock parser.

Closing as this is not a bug as explained by @xelan


os-base/scripts/download should be proxy configurable

I'm attempting to build my own base os and unfortunately I am behind a corporate proxy.
The curl attempts fail with out some hackery to inject http_proxy/https_proxy env settings.
It would be great if it respected your local env settings, or if there was a way to pass the configuration into the container.
Thanks

Yes we really should respect and propagate the HTTP proxy env variables.  That seems quite doable.

and the same for the certs? https://forums.rancher.com/t/how-to-add-custom-ca-certificate-for-system-docker-use/3924

+1 ... I'm also now in a build env where i have to deal with SSL inspection certs.


Issues with chunk preloading

https://github.com/fusionjs/fusion-cli/issues/314 surfaced some issues that may still exist with chunk preloading. It appears that in some cases this can still be incorrect (e.g. the main chunk being preloaded twice instead of main+critical async chunk). More investigation needed.

@rtsao Please reopen if there's an actual error with chunk preloading.


NULL devices?

Issue description
[   21.729762] shpchp: Standard Hot Plug PCI Controller Driver version: 0.4
[   21.743078] (NULL device *): hwmon_device_register() is deprecated. Please convert the driver to use hwmon_device_register_with_info().

Also, https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1666653.
Yes, it's "just a warning", but I think we can all agree that we do not want to see such things.
Steps to reproduce
Unknown
Technical details

system: "x86_64-linux"
host os: Linux 4.15.18, NixOS, 18.03.git.45cd609 (Impala)
multi-user?: yes
sandbox: no
version: nix-env (Nix) 2.0.1
channels(root): "nixos-17.09.2182.7f6f0c49f0"
channels(coretemp): "nixos-18.03.132192.ce0d9d638de"
nixpkgs: /nix/var/nix/profiles/per-user/root/channels/nixos/nixpkgs

This is a warning generated by the kernel because a deprecated interface is still used - it is actually used in many places in the kernel: https://github.com/torvalds/linux/search?q=hwmon_device_register&unscoped_q=hwmon_device_register
It is apparently harmless, and nothing that we can (or want to) fix in nixpkgs. Please feel free to discuss this issue with the linux kernel project.

Who is this "we" that you are talking about?


REQUEST: Extensions to be enabled before load

Would need Windows 10 Accounts extension.

You can plug in the browser you use daily, like Chrome or Firefox, where you already have the extension installed. See here for details

I tried, but it loads into chromium instead,
changed:
executablePath: getPuppeteerChromiumPath(),
to
executablePath: 'C:\Program Files\Google\Chrome\Application\chrome.exe'
but loads into a new profile of chrome not the default profile, which does not have the "Windows 10 Accounts" Extension,
I could not install the extension
Thanks
David

Also I've changed that executablePath:  'C:\Windows\SystemApps\Microsoft.MicrosoftEdge_8wekyb3d8bbwe\MicrosoftEdge.exe'
it still opens as a new chromium browser with no extensions or profile associated.

[WARNING] .token_cache not found.
Launching headless Chrome to perform the OpenID Connect dance...
[ERROR] Error: Failed to launch the browser process! spawn C:Program FilesGoogleChromeApplicationchrome.exe ENOENT
TROUBLESHOOTING: https://github.com/puppeteer/puppeteer/blob/main/docs/troubleshooting.md
at onClose (C:\Users\David Lay\destreamer\node_modules\puppeteer\lib\cjs\puppeteer\node\BrowserRunner.js:193:20)
at ChildProcess.<anonymous> (C:\Users\David Lay\destreamer\node_modules\puppeteer\lib\cjs\puppeteer\node\BrowserRunner.js:185:85)
at ChildProcess.emit (node:events:376:20)
at Process.ChildProcess._handle.onexit (node:internal/child_process:282:12)
at onErrorNT (node:internal/child_process:476:16)
at processTicksAndRejections (node:internal/process/task_queues:80:21)

Added
ignoreDefaultArgs: true ,
under executablePath: getPuppeteerChromiumPath(),

Ok, sorry if I wasn't able to help, happy that you solved :D


Fix regexp handing logic in router. Closes #4204

It closes #4204. When regexp matches path not from the beginning, trim_prefx validates if path breaks on a path separator in a wrong way.
Here is a small illustration of the problem:
path:       /test/api/123
layerPath:  /api/123
c:                  ^

after the fix:
path:       /test/api/123
startIndex:      ^
layerPath:       /api/123
c:                       ^

This PR fixes his behaviors by testing matched layerPath not from the begging of the path but from the start of the match.
I have also added a unit test to cover this case.
Existing logic should not be affected, because in case of a match from the beginning of the path, the startIndex variable will be 0 and we will end up an old logic.

Thank you for the pull request! I'm not sure if this is a valid use case for the prefix matching function of app.use, though, as it is only supposed to match based on prefix.
What your change here, what is the value of req.url within your app.use? I assume it is also a mangled value now?

Yes, req.url in mangled now. OK, if app.use should only match based on prefix, the proper fix would be to add ^ to the regexp if the user didn't specify it (I think the same logic is already implemented somewhere in the code, because if I specify app.use('/api'... internally it will be replaced with a regexp /^\/api\/?(?=\/|$)/i

To add a bit more content to it, we faced this bug in prod in our app. We have defined two layers:
app.use(/(\/foo|\/api)/, handlerA)
and
app.use(/\/proxy/, handlerB)
and when we were making a request to /proxy/api/12345 it was processed by handlerA instead of habdlerB but only in case we have 5 characters after the last / symbol. In all other cases, it was processed by hanlderB as expected.

I have updated this PR (reverted the change and added a unit test to showcase the problem)

Hi @drussilla , sorry for the delay due to current world events 😕 . I just committed a fix (https://github.com/pillarjs/router/commit/16ff25e050243477b44c0e54d01f839d6d018064) to the upstream router repo that should fix your issue. The fix will be ported here and does pass the test you provided, and adds the check that really should have always been there. LMK what you think.

@dougwilson Look good to me, thanks for the fix!

@dougwilson Looks good to me, thanks for the fix and I hope you stay safe and healthy in this crazy time!

Awesome, @drussilla thanks for confirming :) I'll port that change into your PR here (so don't close it unless you really want to) and then we'll get it merged into the upcoming 4.x release (4.18).

Alright, apologies for the delay on that. I have ported the router change into the PR here.


[WIP] Support Profiling(#199)

What type of PR is this?
feature

What this PR does / why we need it:
Support profiling in kmesh-daemon. Still WIP.
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?:

Codecov Report
Attention: Patch coverage is 0% with 15 lines in your changes are missing coverage. Please review.
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Flag
Coverage Δ

unittests
31.08% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files
Coverage Δ

pkg/controller/controller.go
0.00% <0.00%> (ø)

pkg/controller/profile/profile.go
0.00% <0.00%> (ø)

Are you able to create an issue stating what you intend to achieve with this PR?

And register the below handler
HandleFunc("/debug/pprof/cmdline", pprof.Cmdline)
HandleFunc("/debug/pprof/profile", pprof.Profile)
HandleFunc("/debug/pprof/profile", pprof.Profile)
HandleFunc("/debug/pprof/trace", pprof.Trace)

I got it, thanks


[Refactor] Remove useless config cumulative_compaction_skip_window_seconds

TabletReader can acquire version from _stale_rs_version_map after cumulative compaction, no need to skip compaction
What type of PR is this：

[ ] BugFix
[ ] Feature
[ ] Enhancement
[x] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Which issues of this PR fixes ：

Fixes #
Problem Summary(Required) ：

cumulative_compaction_skip_window_seconds  introduced by https://github.com/apache/doris/pull/3271. At that time, it can not acquire rowset version after compaction, but now we can acquire from _stale_rs_version_map.
so that this config is useless now.
Checklist:

[ ] I have added test cases for my bug fix or my new feature
[ ] I have added user document for my new feature or new function

run starrocks_admit_test

@mergify backport branch-2.4 branch-2.3 branch-2.2


Feature: Tasks

Refactored commands so not to depend on cobra
Added Tasks property to project and parsed from yaml
Generate tmp shell file with task contents and run
Show project tasks on help screen

USAGE
  loon <command>

COMMANDS
  cd        Switches directories to project root
  clone     Clones a Git repository into the working directory
  down      Stops the current project's infrastructure
  shell     Starts a shell inheriting the current project's environment
  up        Starts the current project's infrastructure
  versions  Prints the versions of supported services and languages

PROJECT COMMANDS
  build     Builds Loon
  test      Runs go tests
  generate  Generates bindata files from catalog

VERSION
  1dff078 (go1.14.3)


Going to Lodash 4

as far as I can tell... :shipit: this will help other RL21 projects successfully build.


COG rendered incorrectly

I'm trying to render https://raw.githubusercontent.com/cholmes/pdd-stac/beta2/disasters/hurricane-harvey/hurricane-harvey-0831/20170831_172754_101c/20170831_172754_101c.json, but it seems there is some distortion taking place:

By the way, this was working flawlessly for quite some time, but I think after one of the georaster-layer-for-leaflet releases this got broken...

I'm wondering if this is an issue related to https://github.com/GeoTIFF/georaster-layer-for-leaflet/issues/75 and https://github.com/GeoTIFF/georaster-layer-for-leaflet/issues/74, which were both fixed by the newest release of georaster-layer-for-leaflet.  Would you be able to uninstall and reinstall stac-layer and see if that fixes the problem?

It seems to be fixed in at least v0.4.2 as far as I can tell. Thanks!


Remove claims and classes

Description of your changes
This PR also removes the compute/v1alpha3 EKSCluster, which we have been keeping around because the v1beta1 EKSCluster is compatible only with composition and not resource claims.
See https://github.com/crossplane/crossplane/issues/1670 for context.

Checklist

I have:

[x] Run make reviewable to ensure this PR is ready for review.
[ ] Ensured this PR contains a neat, self documenting set of commits.
[ ] Updated any relevant documentation, examples, or release notes.
[ ] Updated the dependencies in app.yaml to include any new role permissions.

Updated with master branches and manually tested.


Switch to Debian

@cbeier, @boedy.... Thoughts?

Looks good :)

Tested. Works for me :+1:

We have the Alpine images in there, feel free to create a -slim on Debian if needed.


Add port forward for pods

Is is possible to add support for forwarding to pods?
In my usecase I have a statefulset with 2 replicas, and I need to port forward to both pods in addition to services.

@wazowsk1 1.17.0 will forward the individual pods names as well as the service if you have a headless service.
apiVersion: v1
kind: Service
metadata:
  name: ok-ss-headless
  namespace: kf-a
spec:
  selector:
    app: ok-ss
    component: ss
  ports:
    - name: http-web
      protocol: "TCP"
      port: 8080
      targetPort: http-web
    - name: http-web2
      protocol: "TCP"
      port: 8081
      targetPort: http-web2
  type: ClusterIP
  clusterIP: None


Allows using various attributes as a category path

1. Why is this change necessary?
Many integration systems require a unique category path identifier.  In this case, is "id"
At the moment, we can only use the category name, but the name is not always unique, and it is not flexible.
An example of a system requiring a unique category path:  http://docs.relateddigital.com/display/KB/Uploading+Your+Product+Data
2. What does this change do, exactly?
This change allows you to use the following constructs in the feed configuration:
<item>
    <category_name>{$sArticle.articleID|category:" > "}</category_name>
    <category_ids>{$sArticle.articleID|category:";":"":"id"}</category_ids>
    <category_links>{$sArticle.articleID|category:";":"":"link"}</category_links>
</item>

<item>
    <category_name>SALE > Sub Sale</category_name>
    <category_ids>93;275</category_ids>
    <category_links>https://example.com/sale/;http://example.com/sale/sub-sale/</category_links>
</item>

3. Describe each step to reproduce the issue or behaviour.
none
4. Please link to the relevant issues (if any).
none
5. Which documentation changes (if any) need to be made because of this PR?
none
6. Checklist

[ ] I have written tests and verified that they fail without my change
[ ] I have squashed any insignificant commits
[x] This change has comments for package types, values, functions, and non-obvious lines of code
[x] I have read the contribution requirements and fulfil them.

Hello,
thank you for creating this pull request.
I have opened an issue on our Issue Tracker for you. See the issue link: https://issues.shopware.com/issues/SW-23881
Please use this issue to track the state of your pull request.

Thanks for your Contribution! :blue_heart:


error-reporting: Fix README typos showing usage

Changes Unknown when pulling 54ad09e65b16e16c1b547d373962c0569b23a6b5 on DominicKramer:docs/update-README-usage-typo into ** on GoogleCloudPlatform:master**.

Changes Unknown when pulling a738e57b5671db2cf2db29705084de62a8dfd1e5 on DominicKramer:docs/update-README-usage-typo into ** on GoogleCloudPlatform:master**.

LGTM -- do you want to ping anyone else for a review?

@stephenplusplus I've sent another review out.

@stephenplusplus The test failures look unrelated to this PR.  Other than the test failures, this PR is ready to land.

Could you paste the errors from Circle? Mobile and Circle log outputs do not get along.

@stephenplusplus Below are sections of the test output that I think are relevant.
. scripts/circle/test.sh
...
> google-cloud-node@ postinstall /home/ubuntu/google-cloud-node
> node ./scripts/install.js
...
Installing dependencies for dns
Installing dependencies for error-reporting
Installing dependencies for google-cloud
Installing dependencies for language
...
> google-cloud-node@ lint /home/ubuntu/google-cloud-node
> jshint scripts/ packages/ system-test/ test/ && jscs packages/ system-test/ test/

git remote add temp https://github.com/GoogleCloudPlatform/google-cloud-node.git
git fetch -q temp
Warning: Permanently added the RSA host key for IP address '<IP_ADDRESS>' to the list of known hosts.

git diff HEAD temp/master --name-only
.jscsrc
.jshintignore
docs/manifest.json
packages/error-reporting/README.md
packages/error-reporting/doc/images/errors-overview.png
packages/error-reporting/src/interfaces/hapi.js
packages/error-reporting/test/unit/interfaces/hapi.js
packages/logging/package.json
packages/logging/src/log.js
packages/logging/src/metadata.js
packages/logging/system-test/logging.js
packages/logging/test/log.js
packages/logging/test/metadata.js
packages/video-intelligence/package.json
packages/video-intelligence/src/index.js
packages/video-intelligence/src/v1beta1/index.js
packages/video-intelligence/src/v1beta1/video_intelligence_service_client.js
packages/video-intelligence/src/v1beta1/video_intelligence_service_client_config.json
packages/video-intelligence/test/gapic-v1beta1.js
scripts/docs/config.js
scripts/helpers.js

module.js:327
    throw err;
    ^

Error: Cannot find module '/home/ubuntu/google-cloud-node/packages/video-intelligence/package.json'
    at Function.Module._resolveFilename (module.js:325:15)
    at Function.Module._load (module.js:276:25)
    at Module.require (module.js:353:17)
    at require (internal/module.js:12:17)
    at new Module (/home/ubuntu/google-cloud-node/scripts/helpers.js:63:17)
    at Module (/home/ubuntu/google-cloud-node/scripts/helpers.js:57:12)
    at Array.map (native)
    at Function.Module.getUpdated (/home/ubuntu/google-cloud-node/scripts/helpers.js:142:24)
    at Object.<anonymous> (/home/ubuntu/google-cloud-node/scripts/build.js:50:22)
    at Module._compile (module.js:409:26)

. scripts/circle/test.sh returned exit code 1

Thanks!


fix: follow label width when fullWidth prop is true

This PR solves https://github.com/viclafouch/mui-file-input/issues/9 .
It seems that the TextField component's InputLabelProps prop etc. cannot control the style of the label element, so I'm using the sx prop.
If the quality is unsatisfactory, please close.

Fixed in next release


cloudfox: 1.13.4 -> 1.14.0

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/BishopFox/cloudfox/releases.
meta.description for cloudfox is: Tool for situational awareness of cloud penetration tests
meta.homepage for cloudfox is: https://github.com/BishopFox/cloudfox
meta.changelog for cloudfox is: https://github.com/BishopFox/cloudfox/releases/tag/v1.14.0
Updates performed

Golang update

To inspect upstream changes
Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 1.14.0 with grep in /nix/store/l75v2qb3y5qiq9wvqsbvfqa23c1z87lf-cloudfox-1.14.0
found 1.14.0 in filename of file in /nix/store/l75v2qb3y5qiq9wvqsbvfqa23c1z87lf-cloudfox-1.14.0

Rebuild report (if merged into master) (click to expand)

1 total rebuild path(s)

1 package rebuild(s)

First fifty rebuilds by attrpath
cloudfox

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/l75v2qb3y5qiq9wvqsbvfqa23c1z87lf-cloudfox-1.14.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A cloudfox https://github.com/r-ryantm/nixpkgs/archive/f21fc56f267d073300dfeecb722f2dd803acbaf8.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/f21fc56f267d073300dfeecb722f2dd803acbaf8#cloudfox

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/l75v2qb3y5qiq9wvqsbvfqa23c1z87lf-cloudfox-1.14.0
ls -la /nix/store/l75v2qb3y5qiq9wvqsbvfqa23c1z87lf-cloudfox-1.14.0/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review --extra-nixpkgs-config '{ allowInsecurePredicate = x: true; }' run on x86_64-linux 1

1 package built:

cloudfox

Maintainer pings
cc @fabaff for testing.

Result of nixpkgs-review pr 304674 run on x86_64-linux 1

1 package built:

cloudfox


Updated Capacity Planning to use new OR1 instances

Description

Swapped out data node instance types (r6g.12xlarge.search -> or1.8xlarge.search), as the new instance type offered some cost savings.

Tasks

https://github.com/arkime/aws-aio/issues/137

Testing

Updated the unit tests; they still pass locally

License
I confirm that this contribution is made under an Apache 2.0 license and that I have the authority necessary to make this contribution on behalf of its copyright owner.

Hmm, looks like our testing GitHub Actions are broken.  Will investigate.

you need to update ./manage_arkime/core/price_report.py also


0019 Propose New Numbering Scheme

Description
Move away from the numbering scheme currently used (based on Oxide Computer Co, not public) in favor of letting GitHub choose it for us.

View rendered proposals/0019/README.md

o.O how did I merge this?

Maybe you were confused with #27?

We can revert and open up a new PR. Hmm also I set branch protections for this repo... :thinking: so how did you merge this?

I clicked the button because I didn't see Mergify label!


send data to an SD card

I wanted to save the fused imu data to an SD card?
what would be the proper command to get this data to a String:
"Pose: roll:-4.23 pitch:-0.75 yaw:74.22, pressure: 1477.74, temperature: 26.50"
I couldn't figure out which part of this command from the ArduinoIMU10 program would be useful:
RTMath::displayRollPitchYaw("Pose:", (RTVector3&)fusion.getFusionPose());
Thanks

You could do something like this:
RTVector3 pose = fusion.getFusionPose();
fd.println(pose.x());    // roll
fd.println(pose.y());    // pitch
fd.println(pose.z());    // yaw
Of course the print can be anything you want.

that section of code seems to print values which are not scaled right. Am i missing a step?
Original code:Pose: roll:-3.69 pitch:-0.85 yaw:63.30
Modified code: roll:-0.06 pitch:	-0.01 yaw:1.10

Ah yes. The display routine converts radians to degrees whereas the pose.x(), y() and z() values are in radians. You can multiply by RTMATH_RAD_TO_DEGREE to convert radians to degrees. There's also RTMATH_DEGREE_TO_RAD that goes the other way.


Set bitsPerComponent 8 instead of CGImageGetBitsPerComponent

Specified 8 as bitsPerComponent because the new image's color space is CGColorSpaceCreateDeviceRGB()
Without this, it fails to create CGContextRef when CGImageGetBitsPerComponent(self.image) has less value than 8.

Does it fail in general or on a specific version? By new image's color space you mean the color space of an image on iOS9?

This problem depends on the kind of self.image, not the iOS version. What I meant by "new image" is the newly creating one at the line 271 whose color space is defined by line 270. But self.image's color space is not always the same. There is maybe no problem if the image was given through camera, but it can be a generated monochrome image passed from a photo album.

Check, thanks for pointing that out. I had to dive a bit deeper into that before merging.

Thanks!

On Oct 7, 2015, at 6:55 AM, Ben John<EMAIL_ADDRESS>wrote:
Check, thanks for pointing that out. I had to dive a bit deeper into that before merging.
―
Reply to this email directly or view it on GitHub.


Pass parameters to crawler

Add the ability to call the crawler like rails crawl --complete to ignore the isNight condition

implemented in 9211632a1ba6c92405494666833b7d397a77d07c.
you can now call rake "crawl[true]" to have a complete crawl


Support : Upload file from window alert pop up for MyWebApp solution

[Support] :
Hi Team,
I created one “MyWebApp” project.I tried uploading files for project from window pop up by using switch window action and file operations (file explorer is opening with title “Google chrome” as icon and “Open” as text) but failed in uploading.There are no help files on this clearly.Please could you help me on this.

For handling, do not open the file browser.

Find the XPath of file input web element using life spy
In Ginger directly use set value or send keys and specify file path in the value

Marking this issue as closed. Please reopen if you still have more queries regarding this.


Bad links

Hello!
On the initial "Important" note, the link for the "Remote Desktop client for Windows" throws a 404.
Searching online it seems that this page does exist, but the link here doesn't work.
The end portion of the link includes a ".md" that throws the error.
Removing it sends us to the "Connect to Azure Virtual Desktop(...)".
Should this be addressed or is it working as intended?
Hope this helps.
Cheers!

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 67b7b5a4-647e-fee3-6533-6ed88ae45bfa
Version Independent ID: d9102859-0147-346f-8268-6e2a75c8b0b7
Content: What's new in the Remote Desktop Microsoft Store client - Remote Desktop Services
Content Source: WindowsServerDocs/remote/remote-desktop-services/clients/windows-whatsnew.md
Product: windows-server
Technology: remote-desktop-services
GitHub Login: @Heidilohr
Microsoft Alias: helohr

Hey @v-pcarvalho,
Thanks again for contacting Microsoft. We value your feedback.
A documentation change has been made correcting the link in question and will be live after the next business day. We will now be closing this thread.
Thank you and have a most pleasant day.
#please-close


Refine the CRD defaulting and forbid multiple backends

Description

Forbid the multiple eventing backends for now.
In the eventing CRD the []Backend field is an array. This makes the validation and defaulting rules for the CRD more complicated. Currently, the solution is a little lacking. The defaulting rules for []Backend adds an empty type to fulfil the requirement that the type is a list. The validation rule only checks the first element in the list for a non-empty eventMeshSecret. Adding a validation rule to check that the []Backend list is currently only allowed to have one element, is not possible due to the buggy defaulting rule.

Note
Follow up to #17
Tasks

[ ] Fix the defaulting rule, so that upon deletion of fields the defaults still adhere to the CRD proposal
[ ] If multiple backends are specified return validation error, e.g. "multiple backends are forbidden"
[ ] Improve the eventMeshSecret by using existing DNS Regex

Should we change Eventing CRD to only one backend?


7.18.6 runs both nginx roles when ssl enabled.

Is this a request for help?:

Is this a BUG REPORT or FEATURE REQUEST? (choose one): BUR REPORT

Which installer: 7.18.6
Which product and version (eg: ansible & collection version - 1.1.2): 7.18.6
Which operating system and version(eg: ubuntu & version - 20.4): ubuntu 18.04
What happened:
Both artifactory_nginx and artifactory_nginx_ssl roles run, but it should be just one of them.
according to the defaults:
# Set this to true when SSL is enabled (to use artifactory_nginx_ssl role), default to false (implies artifactory uses artifactory_nginx role )
artifactory_nginx_ssl_enabled: false

# Set this to false when ngnix is disabled, defaults to true (implies artifactory uses artifactory_nginx role )
artifactory_nginx_enabled: true

What you expected to happen:
I expect only artifactory_nginx_ssl to run when
artifactory_nginx_ssl_enabled: true
How to reproduce it (as minimally and precisely as possible):
Set:
artifactory_nginx_ssl_enabled: true
then run installation.
Anything else we need to know:
artifactory_nginx_enabled should be used to enable/disable nginx completely, even if artifactory_nginx_ssl_enabled is true.
artifactory_nginx_ssl_enabled should be used to default to standard nginx or ssl version if true.

@woyteck1 Thanks for reporting , will be fixed in next release

I can confirm that as of 7.19.8, this role is now idempotent in my scenario. Thanks!


Replace mutable structs using Adapt

Mutable structs cannot be compiled to bits type on GPU. Using Adapt to translate the mutable structs to an immutable struct can be a good way to address this.

An alternative would be to use Adapt to translate the mutable structs to an immutable struct that works on the GPU.
Might require introducing a new abstract type in the type hierarchy so that the dispatch still works out.

Not sure whether doing this on my repo or here would be better - let me try both ways and compare.

Not sure whether doing this on my repo or here would be better - let me try both ways and compare.

You can also continue with your previous approach and make the semidiscretization mutable. Maybe it's worth comparing all three approaches to see what works best in terms of code complexity and performance.

@ranocha Sure

Temporary fix by #2052 - we will see whether that solution can be permanent.


Review IActionResult classes and add facades as necessary

We still have some IActionResult classes like ViewComponentResult that have a lot of implementation code in their execute method, including calls to GetRequiredService. We should review these and change them to be more like ViewResult.

@javiercn have we made much progress on this? This is going to be a strong candidate to move out of v1.0.0...

I've gone through all the action results and I've examined what to do on each individual action result. My criteria for adding facades has been the following. The ActionResult is part of a "Result Hierarchy" like file related results (and one or more of them require more than one dependency from DI). There is a reasonable amount of code in the action result Execute* method.
In general I've left untouched the action results that just resolve a logger factory and do small work on the execute* method.

BadRequestObjectResult -> No changes required
BadRequestResult -> No changes required
ChallengeResult -> Not adding a facade for this, it just uses context.HttpContext.Authentication
ContentResult -> Not adding a facade for this, we might want to remove the buffering feature related code.
CreatedAtRouteResult -> Does an extra call to GetRequiredService, but they are hard to change due to the current layering, we can leave them as they are right now.
CreatedResult -> Does an extra call to GetRequiredService, but they are hard to change due to the current layering, we can leave them as they are right now.
EmptyResult -> No changes required
FileContentResult -> Added a facade for it
FileStreamResult -> Added a facade for it.
ForbidResult -> Not adding a facade for this, it just uses context.HttpContext.Authentication.
LocalRedirectResult -> Added a facade for it.
NoContentResult -> No changes required
NotFoundObjectResult -> No changes required
NotFoundResult -> No changes required
ObjectResult -> Already has a facade
OkObjectResult -> No changes required
OkResult -> No changes required
PhysicalFileResult -> Added a facade for it, removed the extensibility points on the result as they were meant for code reuse (which is now on the executor) and for unit testing.
RedirectResult -> Added a facade for it.
RedirectToActionResult -> Added a facade for it.
RedirectToRouteResult -> Added a facade for it.
SignInResult -> No changes required
SignOutResult -> No changes required
StatusCodeResult -> No changes required
UnauthorizedResult -> No changes required
UnsupportedMediaTypeResult -> No changes required
VirtualFileResult -> Added a facade for it
JsonResult -> Already has a facade
PartialViewResult -> Already has a facade
ViewComponentResult -> Added a facade for it
ViewResult -> Already has a facade

Results on the WebApiCompatShim

Not doing anything here.


Add the missing websockets package to requirements

websockets is used by the package but isn't in the requirements, causing an error if it's not installed manually.

Added! Thanks