TypeError: Cannot read property 'transform' of undefined

I followed the directions on the babejs.io page to the T, but I'm getting a problem here that 'default' on _babelCore2 is not defined.
This is my transpiled code:
  1 'use strict';
  2
  3 var _babylon = require('babylon');
  4
  5 var babylon = _interopRequireWildcard(_babylon);
  6
  7 var _fs = require('fs');
  8
  9 var _fs2 = _interopRequireDefault(_fs);
 10
 11 var _babelCore = require('babel-core');
 12
 13 var _babelCore2 = _interopRequireDefault(_babelCore);
 14
 15 var _visitor = require('./visitor');
 16
 17 var _visitor2 = _interopRequireDefault(_visitor);
 18
 19 function _interopRequireDefault(obj) { return obj && obj.__esModule ? obj :     { default: obj }; }
 20
 21 function _interopRequireWildcard(obj) { if (obj && obj.__esModule) { return     obj; } else { var newObj = {}; if (obj != null) { for (var key in obj) { if     (Object.prototype.hasOwnProperty.call(obj, key)) newObj[key] = obj[key]; } }     newObj.default = obj; return newObj; } }
 22
 23 _fs2.default.readFile(process.argv[2], function (err, data) {
 24   var src = data.toString();
 25   var out = _babelCore2.default.transform(src, {
 26     plugins: [_visitor2.default]
 27   });
 28   // console.log(out.code)
 29 });

I have the 'env' preset activated in my .babelrc. What's up with that?

It's possible the docs are out of date. Which instructions are you following?
It looks like you're doing
import babel from "babel-core";
babel.transform()

instead of
import {transform} from "babel-core";
transform();

It looks like __esModule is true, and therefore it isn't cast into an object under the default key.
Yes, hmmm, when I manually set _babelCore.__esModule to false, it works.

Well don't do that :P We just don't export the interface such that import babel from "babel-core"; works, if you want to use babel.transform, you should do import * as babel from "babel-core";.

Hmm - I'm a little confused, I didn't write any of that code; that code is the transpiled code.

You showed your compiled code, but what does your original uncompiled code look like? It's an issue with that.

I know! sorry I am eating my shoe here

Let's rewind to your second comment

Looks like your suggestion works. I wonder why - now it's not making a _babelCore2

Thanks :)


"+clicked_branch_link":false all the time

Manifest:
 <activity
        android:name=".activity.LoginScreen"
        android:label="@string/app_name"
        android:windowSoftInputMode="adjustResize"
        android:launchMode="singleTask">
        <intent-filter>
            <action android:name="android.intent.action.MAIN"/>

            <category android:name="android.intent.category.LAUNCHER"/>
        </intent-filter>

        <intent-filter>
            <data android:scheme="myscheme" android:host="open" />
            <action android:name="android.intent.action.VIEW" />
            <category android:name="android.intent.category.DEFAULT" />
            <category android:name="android.intent.category.BROWSABLE" />
        </intent-filter>
    </activity>
    <meta-data android:name="io.branch.sdk.TestMode" android:value="true" />
    <meta-data android:name="io.branch.sdk.BranchKey" android:value="key_live_my_key" />
    <meta-data android:name="io.branch.sdk.BranchKey.test" android:value="key_test_my_key" />

Custom Application class:
  public class MyApplication extends MultiDexApplication {
       @Override
       public void onCreate() {
       super.onCreate();

       Branch.getAutoInstance(this);
 }

And login screen:
@Override
protected void onStart() {
    super.onStart();

    Branch branch = null;
    try {
        branch = Branch.getInstance();
    } catch (BranchException e) {
        e.printStackTrace();
    }
    final Branch finalBranch = branch;
    branch.initSession(new Branch.BranchReferralInitListener() {
        @Override
        public void onInitFinished(final JSONObject jsonObject, final BranchError branchError) {
            Log.v("params", jsonObject.toString());
        }
    }, this.getIntent().getData(), this);
}

@Override
public void onNewIntent(Intent intent) {
    this.setIntent(intent);
}

And here is the issue, case is next:

App is closed
User click on branch link
App opening, Login screen starts
in onInitFinished callback I always got next params:
{"+is_first_session":false,"+clicked_branch_link":false}

Why clicked branch_link = false ? I'm clicking on link...What I missed ?
Thanks,
Dmytro

@dbystVF Thanks for reaching out and really sorry for the issue you are facing. We are trying to recreate and fix the issue. Could you please help us with the following to debug the issue
1.Force close the app from your setting
2.Launch the app by clicking  a Branch link

@sojanpr  Thanks for response. Just did your steps. Result the same

@dbystVF Thanks for trying it. We  are working on it and update you soon.

@dbystVF can you send an email to<EMAIL_ADDRESS>with your Branch Key and a link to this issue? We want to dig into our logs to see if we can discover the issue.

@derrickstaten Sure, in a minute. Thx

Closing this issue since issue is not reproducible with latest versions

@sojanpr The issue is sometimes reproduced for me as well, but unfortunately there are no specific steps. Sometimes after clicking on the link I also get:
{"+is_first_session":false,"+clicked_branch_link":false}

@yuliya-tarasenko  Sorry that you hit this issue. We will check and update you. Mean time could you please check if the link you are clicking is created by a different Branch key than your app is using. ( For example links created with TestMode = true in manifest and app is installed with TestMode = false)

@yuliya-tarasenko It would be very helpful if you can share us a link that is having this issue


WIP prefix in contrib file

Should this

Create Work In Progress [WIP] pull requests only if you need clarification or an explicit review before you can continue your work item.

be more like this

Add a [WIP] prefix on your pull request name if you need clarification or an explicit review before you can continue your work item.

see PR #26

done by #26


feat: recolor google sign in btn

closes #427

create the method to create provide style
modify the color with Google sign-in button

Create the method createProviderStyles  to deal with provider style
https://github.com/cofacts/rumors-site/blob/41d555a07c10483bff8cf70a4b1fad240e36ce81/components/AppLayout/LoginModal.js#L65C44-L84

coverage: 76.218%. remained the same when pulling 032d17ac9a60bb4fe4b0dfefcad6bf735f71c7a6 on fufuShih:feat-recolor-google-sign-in-btn into 802dc59209c5c97a38840af60e66dfde994cf47a on cofacts:master.


UITableViews set via IBOutlets from xib, with tableHeaderView disappear after refresh

If a UITableView is set in a xib file and hooked unto the view controller via an IBOutlet, and it includes a tableHeaderView, it disappears after a pull to refresh.
This will be because the IBOutlet only has a weak reference to the UITableView and it is removed from the view heirachy temporarily
This is where is occurs:
public extension UIScrollView {
    func dg_stopScrollingAnimation() {
        if let superview = self.superview, let index = superview.subviews.indexOf({ $0 == self }) as Int! {
            let strongSelf = self
            //removeFromSuperview() // commenting out this line fixes the issue, but Im not sure if its needed for something else (changing the index?)
            superview.insertSubview(strongSelf, atIndex: index)
        }
    }
}

Hi there. I am aware of this issue, have a look at: #1

Ah I see, I scanned the issue titles, but didn't think it'd been raised

On 12/12/2015, at 3:00 AM, Danil Gontovnik<EMAIL_ADDRESS>wrote:
Hi there. I am aware of this issue, have a look at: #1
—
Reply to this email directly or view it on GitHub.


pythonPackages.sfepy: 2019.2 -> 2019.4

Bump the version number to fix incompatibility with Numpy 1.18.1

Motivation for this change

Bump the version number to fix incompatibility with Numpy 1.18.1
Remove broken test to fix incompatibility with Numpy 1.18.1

This change was mistakenly merged into release-20.03 first with https://github.com/NixOS/nixpkgs/pull/81043. The changes should have gone to master first and then been cherry picked to release-20.03.
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ ] NixOS
[ ] macOS
[x] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[x] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Result of nix-review pr 81323 1

3 package were build:

python27Packages.sfepy
python37Packages.sfepy
python38Packages.sfepy

@GrahamcOfBorg eval

@grahamcofborg build python3Packages.sfepy


Several improvements

Separate config paths for nagios main directory (/etc/nagios) and nrpe.d additional checks.
Comment sample checks into nrpe.cfg
Rewrite nrpe_ansible.cfg.j2 template to be able to add new additional checks from an array

I can't merge this as is. You've removed some Arch comparability for some reason and changed the README.md to be your own.
I do agree with a lot of the commit though. The role needs to move away from editing templates like it is now to variables.
If you're able to clean this commit up and remove the changes to README.MD (apart from the typo and any changes to how the role actually works) we can have a look again.

Don't worry about that. I will delete the fork.
Good luck with the new version!
Cheers.
El dom., 7 feb. 2016 a las 19:47, James<EMAIL_ADDRESS>escribió:

I can't merge this as is. You've removed some Arch comparability for some
reason and changed the README.md to be your own.
I do agree with a lot of the commit though. The role needs to move away
from editing templates like it is now to variables.
If you're able to clean this commit up and remove the changes to README.MD
(apart from the typo and any changes to how the role actually works) we can
have a look again.
—
Reply to this email directly or view it on GitHub
https://github.com/Mooash/nagios-nrpe-server/pull/14#issuecomment-181077817
.


⚠ Fortnite has degraded performance

In b028b57, Fortnite (https://fortnite.com) experienced degraded performance:

HTTP code: 200
Response time: 1413 ms

Resolved: Fortnite performance has improved in 1a71ea3.


finish-args: Cover more redundant home and host permission variants.

Following are disallowed:

host, host-{os, etc}, home with :create. :create makes no sense here.

host or host-{os, etc} is writeable but home/foo or ~/some/path is again writeable. Writeable host variant means any home variant is also writeable. Some apps may require :create if they expect the folder to be present already. These will have to go through exceptions.

host or host-{os, etc} ends with :ro and again home/foo or ~/some/path ends in :ro. Read only host variant implies read-only home variants. (wrong explanation, code is correct)

home is writeable but home/foo or ~/some/path is again writeable. Writeable home implies writeable subpath of home. Some apps may require :create if they expect the folder to be present already. These will have to go through exceptions.

when home:ro is present and again home/foo:ro or ~/some/path:ro is present. Read-only home implies read-only subpath of home. (wrong explanation, code is correct)

any combination of host-{os, etc} and home where both are writeable or both are read-only

any combination of host or host-{os, etc} and home, where host variant is writeable but home is read-only. Writeable host variant takes precedence over read-only home.

host or host-{os, etc} ends with :ro and again home/foo or ~/some/path ends in :ro. Read only host variant implies read-only home variants.

when home:ro is present and again home/foo:ro or ~/some/path:ro is present. Read-only home implies read-only subpath of home.

This doesn't appear to be correct. ro overrides write permissions for paths.

I think those two are fine? host:ro should imply ~/path:ro?
What you mean is host:ro and ~/somepath:rw which is not blocked?

What you mean is host:ro and ~/somepath:rw which is not blocked?

This variant is correct and covered by https://github.com/flathub-infra/flatpak-builder-lint/pull/362/files#diff-67e3430053d7a019a58874f821f60eac91d2970b94288593c06fb6715f2f57b2 and https://github.com/flathub-infra/flatpak-builder-lint/pull/362/files#diff-ccb6365857d305a97e21049ea26e7b4002f71facb4d1d4b2835a298abcaa23cb files to not raise the error.

Ok I see where I made the error, I borked the explanation in the post by adding the "implies" part. I'll change it.
What I meant is that it matches host:ro, host-etc:ro, host-os:ro with anything starting with ~  or home and ending with :ro.
Same for home:ro and anything starting with home and ~ and ending with :ro.

To be clear, how I interpreted it.
If the permissions are home:ro ~/foo, then foo is writable. So ~/foo:ro is correct.

home is writeable but home/foo or ~/some/path is again writeable. Writeable home implies writeable subpath of home. Some apps may require :create if they expect the folder to be present already. These will have to go through exceptions.

Some apps may intentionally have redundant permissions to support disabling home/host which is optional for them. I think it's better to focus on things that may cause issues rather than things that just look too verbose.

The redundancy is more often a mistake than intentionally added.
If it is optional then it doesn't belong permanently in static permissions and if people are overriding it anyway they are in their own territory and can add the specific permissions needed.

The redundancy is more often a mistake than intentionally added.

Whether it's mistake or not it hurts no one.

If it is optional then it doesn't belong permanently in static permissions

Flatpak doesn't have concept of optional permissions like snap does and maintainers try to please everyone.

if people are overriding it anyway they are in their own territory and can add the specific permissions needed.

Even for tech users it's not obvious which permissions are really needed when they're overshadowed by home/host

We already had checks for redundancy, this only expands it.

Please reconsider if this is right direction then. There was really a lot of breakage in flathub in past months and breaking the builds again for such non-issue is hardly what we need right now.

Whether it's mistake or not it hurts no one.

That argument doesn't work. You can argue the same way about everything the linter currently blocks. A mistake is a mistake.
Anyway as I initially said in the second post here, I won't deploy this without adapting existing apps to the change.

Not interested in working on this anymore.


Spelling of  License spxd_license_id parameter is confusing, should probably be spdx_license_id

class License(builtins.object)
|  License(spxd_license_id: Optional[str] = None
The parameter is prefixed by 'spxd' but the license page referenced is called "SPDX" (https://spdx.dev/)
Might be API breaking to change it.
Found in cyclonedx-python-lib 1.3.0

Could you elaborate, @schlenk ?
What seams to be the issue? What is an acceptable solution? how would you suggest to solve the situation?
An addition you could open a pull request to show a possible mitigation.
If you do so,

please read https://github.com/CycloneDX/cyclonedx-python-lib/blob/main/CONTRIBUTING.md
be aware that a breaking change is already in the making - so no problem if you intend to introduce breaking changes.

see https://github.com/CycloneDX/cyclonedx-python-lib/pull/148
you could branch out from feat/add-bom-services
and pull request into that branch.

The referenced standard is called "SPDX", so the license_id referenced in the id property and set by the constructor is a "spdx_license_id". But the constructor named parameter is called "spxd_license_id".
Calling the parameter "spxd_license_id" is confusing due to the typo (xd instead of dx) in the identifier.
If the API is broken with 2.0.0 anyway, i would simply rename the parameter to the better fitting one.

@madpah  as we are planning to have most parameters forced to be keys, this typo should be addressed.
in fact, i see it was fixed already, in https://github.com/CycloneDX/cyclonedx-python-lib/blob/0d82c019afce3e4aefe56bff9607cfd60186c6b0/cyclonedx/model/init.py#L481
via #160
therefore i marked the relevant PRs to close this very PR, after the fact.


Long - term caching support

Hi,
Any chance you are planning to add support to cache events to localStorage or similar so there is no delay re-fetching events on page refresh?

added in v2. explained in readme.

@sepehr-safari nice work on v2! looking forward to trying it out :sunglasses:

@sepehr-safari nice work on v2! looking forward to trying it out 😎

thank you! would love to hear your feedback. btw, it's still just the foundation with just a few basic hooks. I will add more useful hooks as well.


Add labels from service discovery to proxy metrics reports

PR #654 adds pod-based metric labels to the Destination API responses for cluster-local services.
This PR modifies the proxy to actually add these labels to reported Prometheus metrics for outbound requests to local services.
It enhances the proxy's control::discovery module to track these labels and add a LabelRequest middleware to the service stack built in Bind for labeled services. Requests transiting LabelRequest are given an Extension which contains these labels, which are then added to events produced by the Sensors for these requests. When these events are aggregated to Prometheus metrics, the labels are added.
I've also added some tests in test/telemetry.rs ensuring that these metrics are added correctly when the Destination service provides labels.

This should be merged after #654.
Closes #660

Are the changes here everything in this PR? It sounds like this expects another PR to land. It kind of makes reviewing here difficult, as I don't know what has been reviewed before, and what changes are proposed in this PR.
Is it possible to change the base so that we can just review the changes this PR is making?

@seanmonstar that's correct, this branch is based on phil/429-lookup-ips (PR #654). I've changed the base to that branch so we can review only the proxy changes added in this branch.

Note the red X on this branch is due to a failing DCO check on one of the commits from master rebased into this branch.

Holding off on reviewing until the diff is a bit less noisy (i.e. once master is merged into #654 and the updates are merged here -- or once #654 merges and this merges master).

Whoops, sorry @hawkw -- looks like this pull request closed automatically when I removed the base branch. Can you reopen and set the base branch to master?

Updated this branch to use the cache metadata added in PR #688 instead of Labeled<T> for storing labels on discovery entries. Deref and Borrow impls are gone. Ready for review.

@olix0r and @briansmith, I've rebased this branch on top of master and I believe I've made all the requested changes. I do have some additional refactoring and tests I'm planning on trying to land in subsequent PRs. I'd like to get your final approval before going ahead and merging this.

CI failure is due to a test added in #684 which appears to be flaky --- I've opened #732 to track that.

I left a lot of comments just now. The most substantial issue I see is the lack of a test for the
ChangeMetadata case. I can't say that works correctly without seeing a test. I'm not sure how practical it is to write a test, though. Other things are either really simple or if not really simple could be deferred. If the test is very difficult then describe how metadata changes were verified to work in a GitHub comment, at least.

@briansmith thanks for your comments on the tests, they were written fairly early in the implementation of this branch and should probably have been updated sooner. In particular, I'm going to ensure there's a test for labels changing.


Error message format method trying to JSON parse an HTML string

When executing a request to /tags/:tag-name endpoint with the tag-name being "insta:gram" (without the quotes), a 404 response is returned with the body of the response being an HTML string.  The FaradayMiddleware::RaiseHttpException.error_body method, which is called by the error_message_400 method that returns a formatted error message, appears to expect the string to be valid JSON, however again the string is HTML.
if not body.nil? and not body.empty? and body.kind_of?(String)
removed multi_json thanks to wesnolte's commit
body = ::JSON.parse(body)
end
Using v 1.0.0 of this library.
Example:
client = ::Instagram.client(:access_token => "...")
client.tag("insta:gram")
=> raises a JSON::ParserError

Thank you for reporting this issue and appreciate your patience. We've  notified the core team for an update on this issue. We're looking for a response within the next 30 days or the issue may be closed.


How to run PyTorch agent on GPU?

Hi,
We have been trying to get the PyTorch agents provided by OpenSpiel on our GPU.
Normally you can do this with .to("cuda:0") on an nn.Module. However, the agents are a subclass of rl_agent.AbstractAgentwhich does not provide such a method.

I have not done this myself. @Asugawara, @ssokota, @MJ10: any ideas?

Apologies for the slow response. I think this would require some changes in the agent class:

Add a device parameter to the constructor.

Within the agent class move the networks to the specified device.
for example, in DQN after Line 229 move the self._q_network and self._target_q_network to the specified device (using .to(device))

Before a forward pass on some input tensors, move them to the device.
continuing the DQN example, before Line 341 move the info_state using info_state.to(self.device). Similar changes would be needed on L380 and L381.

This would need to be added for all the agents.
Although, I did try something like this a while back, on the games I tested it was much slower, possibly since the networks aren't that big and moving the data to the GPU so many times itself takes more time. But I might be missing something.

Ok, thanks for the answer! Is it then possible to run the models on GPU with TensorFlow?

Thanks @MJ10 ! That sounds like a minimal change.. @ThierryDeruyttere why don't you make the change locally for the agent you want to use and run that?
We have not spent any time supporting GPUs generally, it would make a nice contribution. If it works for the one agent as @MJ10 suggests, we can start there and maybe make a general solution?


Support git aliases

https://github.com/shockone/black-screen/issues/428#issuecomment-223263882

Fixed by https://github.com/shockone/black-screen/pull/607


feat(be+fe): export data catalog

**What is the current behavior?
Please describe the current behavior of the code that you are trying to modify. This could include any issues or limitations that you are addressing.
**What is the updated behavior?
Please describe the changes you are making to the code's behavior. This could include new features or enhancements that you are adding, as well as how they differ from the current behavior.
**Checklist
Please check off the following items before submitting your pull request:

[x] I have tested my changes.
[x] No sensitive information is included.
[x] I've reviewed my changes to ensure they won't cause any new issues that could affect the stability or performance of the codebase.

Please check off the following items if this changes include API modefications:

[x] I confirm this changes has been test with authorization validation steps, it won't break the authorization token verification mechanism.
[x] I confirm this changes won't cause security issues.

due to new commit, close this pr.


interaction with GP AI is VERY SLOW!

Hi
just tested few operations and looks like managing GP is running very slowly where image operations on GP level are typical quite fast.
commands are sent to GP with huge pauses between steps.
any idea ?
GP AI 6.3.3.
Python 3.9.10 (main, Jan 25 2022, 17:58:23)  [GCC 11.2.0 64 bit (AMD64)] on win32

i can confirm that it sometimes works much slower as it could be to load the image, set the settings and start processing (~1 Minute), but sometimes it even gets much worse, then it takes minutes easily to complete each step and sometimes it even throws a timeout error. In the last two days it had this behaviour, today without any change it works again with normal slow performance.
Changing to win32 backend speeds up the application performance heavily but then it doesn't find the buttons. So one way to solve this might be to change to win32 backend

Will try to optimize in near future. Thanks for feedback.

Read #17 to learn how optimizations. 60% faster now.


When working with WSL2 autocomplete doesn't work with relative imports

Environment data

VS Code version: 1.48.0
Extension version (available under the Extensions sidebar): 1.48.0
OS and version: Windows 10 / Ubuntu 20.04 / WSL2
Python version (& distribution if applicable, e.g. Anaconda): 3.7.8
Type of virtual environment used: pipenv (venv I guess?)
Value of the python.languageServer setting: Jedi (tested with Microsoft too)

Behaviour
from .reports import bla
bla.xxx # doesn't auto complete

But if I were to do
from some_module.reports import bla
bla.xxx # it auto completes

Thanks for your feedback! We have recently released a new and more performant language server called Pylance which likely solves these issues you are reporting.  You can download Pylance from the marketplace and install it alongside the core Python extension. Because our team's development efforts have shifted to support the new language server, we'd encourage you to try it out. If you try out Pylance and this issue persists, you can open an issue on the pylance-release repo.

Hi @hcoura,
Is this issue still happening if you use Pylance?

Hi @kimadeline I forgot to report back on this one. Yeah it is fine with Pylance.

No problem! Closing since it works with Pylance.


Implement store_content command for receiving and sending content to the storage adapter interface

https://github.com/Revolution-Populi/revpop-js/pull/8


Suggestion: option to remove and/or disable Adobe Flash Player

Title says it all. I can't understand Microsoft's decision to include this software in LTSC (N) as well. Even more so because Adobe is planning EOL on Flash by the end of 2020: https://theblog.adobe.com/adobe-flash-update/
If you could build in an option in your script for removing and/or disabling Adobe Flash Player, that would be awesome.

I will look into this a bit further today on a VM and modify the script accordingly.


Close/ignore update popup using system back action

Describe the solution you'd like
Allow the system back action to close the update pop-up, like it did with hockeyapp. This would ignore the update until the next time the app gains focus (foreground) or reopened.
Describe alternatives you've considered
The only alternative I found is to download the update and not install it by using the back action when prompted to install by android package installer. This is far from ideal and since the update apk is not stored in sdcard, app center needs to redownload again after each 'ignore'.
Additional context
Currently whenever the update pop-up shows up it renders the app unusable and prevents the user from closing the app using the system back action

Any updates on this ?


[Fix] jsx-indent: Does not check indents for JSXText

Fixes #2467, Fixes #2484, Fixes #1136
This PR fixes the problem of does not check jsx-indent for JSXText.
JSXText Node is different from other formats.
e.g. The following code.  JSXText's node.value returns \n    text\n    text\n    .
const f = () => (
    <div>
        text
        text
    </div>
);

changes

add handler for JSXText Node
https://github.com/yannickcr/eslint-plugin-react/blob/0076cb09abfed7a3777102359efb5f39dee2e01e/lib/rules/jsx-indent.js#L406-L412

check JSXText Indent
https://github.com/yannickcr/eslint-plugin-react/blob/0076cb09abfed7a3777102359efb5f39dee2e01e/lib/rules/jsx-indent.js#L304-L341

add the fix for JSXText
https://github.com/yannickcr/eslint-plugin-react/blob/0076cb09abfed7a3777102359efb5f39dee2e01e/lib/rules/jsx-indent.js#L100-L104

add test cases
tests/lib/rules/jsx-indent.js

@ljharb
I fixed to work for older eslint. and fixed some tests.
Now, CI is failing in Node v4...

This caused #2561, which was fixed in 3da6eb36327f77adfdd856296c3d663bffe288ee - namely, the issue was that the literal check assumed strings.


[Feature Request] Langfuse Integration

Describe the solution you'd like
We propose integrating self-hosted Langfuse, an open-source observability and analytics platform for LLM applications, into our project. This integration would provide:

Tracing: Automatic tracking of LLM calls, prompts, and responses.
Metrics: Real-time monitoring of latency, token usage, and costs.
Scoring: Ability to score model outputs for quality assessment.
Prompt Management: Version control and A/B testing for prompts.
User Feedback: Collection and analysis of user feedback on AI responses.

The integration should be modular and configurable by cdk.json, allowing users to enable/disable specific Langfuse features as needed.
Why the solution needed
Integrating Langfuse would significantly enhance our project's capabilities:

Improved Debugging: Tracing would make it easier to identify and resolve issues in complex AI workflows.
Usage/Cost Visualization: Metrics would help users visualize their LLM usage and associated costs.
Quality Assurance: Scoring and user feedback features would enable continuous improvement of AI outputs.
Experimentation: Prompt management would facilitate rapid iteration and optimization of AI interactions.
Transparency: Comprehensive logging would provide insights into AI decision-making processes.

These benefits would make this project more attractive to developers and organizations looking for robust, production-grade AI solutions.
Additional context
About designing policy
We already have done sample implementation in our company with self-hosted langfuse, using ALB, ECS(Fargate), , SecretsManager, .
However, for this project, we had difficulty integrating LangChain with Langfuse because we did not use LangChain in its general form, whether intentionally or not.
For example, AnthropicStreamHandler.
If there is any design reason or policy not to strongly use LangChain, I would like to hear about it.
I assume one reason is that LangChain functions are becoming deprecated so fast that maintenance cannot keep up.
HTTPS with ALB
We are aware that since the hosting will be via ALB, the user will need to acquire and configure a custom domain to connect via HTTPS.
Implementation feasibility
Are you willing to discuss the solution with us, decide on the approach, and assist with the implementation?

[x] Yes
[ ] No

Thank you for the detailed issue and the request for integrating Langfuse into this project. I appreciate you providing the context and background information.

If there is any design reason or policy not to strongly use LangChain, I would like to hear about it.

As you mentioned, the rapid pace of updates and the presence of deprecated functions throughout LangChain can make it challenging to maintain and keep up with the changes. Additionally, the excessive abstraction can indeed cause delays in adapting to updates from AWS, such as the Converse API.
I agree that having the ability to configure Langfuse features through cdk.json would be beneficial in many cases, as it would provide users with more administrative features.
Regarding the existing sample implementation of Langfuse within your company, I'm curious if it was implemented using CDK. If so, do you have plans to open-source the implementation or make it publicly available? I think make the implementation public is valuable itself in another repository.
As for the integration between Langfuse and Bedrock Claude Chat, it would be helpful to understand which areas would primarily require modifications or additional work.

@statefb Thank you for your reply! I appreciate your valuable insights and feedback.
As you pointed out, given the nature of an AWS sample repository, fast adoption to AWS's latest features (lile 3.5 Sonnet) is undoubtedly one of the most important priorities.
I completely agree with you on this point.
Based on that policy, we need to proceed the implementation that it does not depend on LangChain as much as possible.

Regarding the existing sample implementation of Langfuse within your company, I'm curious if it was implemented using CDK. If so, do you have plans to open-source the implementation or make it publicly available? I think make the implementation public is valuable itself in another repository.

Our sample implemetation of Langfuse is in CDK.
We will need to refactor the implementation to remove our organization-specific parts, which will take some time, but it is ready to make it public.
Would another repository be better than another branch of this repository?

@tak-kam I'm interested in the archtecture you implemented, how you integrated with this sample and how utilize this function in the real usecase. Why don't we have a discussion on a meeting? It'd be easier than text communication. I'd be appreciated if you could contact with me via linkedin.


Get-GivenName using WMI returns the last name when using 'Last, First' formatting

My organization uses 'Last, First' for our display names, so when the Get-GivenName function runs and has to retrieve the information from WMI the last name is returned instead of the first name. The specific command is on line 262:
$GivenName = $DisplayName.Split()[0].Trim()
I can easily remedy that by changing the split to 1:
$GivenName = $DisplayName.Split()[1].Trim()
Not sure if you want to document this somewhere, or find a way to account for differences in formatting between organizations.

Right. I haven't thought about that. I'll see what I can do to cater for that situation. Thanks for making me aware. Much appreciated! :-)

Maybe implementing it to be used from custom XMLs? :)


Terminal left padding is missing in latest insiders

Does this issue occur when all extensions are disabled?: Yes

VS Code Version: 1.63.0-insider
OS Version: Windows 11

Steps to Reproduce:

Open terminal, left padding for content is gone, terminal contents are flush against the panel

Compare to stable:

/duplicate of #136514
Should be fixed in next Insiders build with #136522 merged few hours ago.


Add replyTo field to PFI Callbacks

What type of PR is this? (check all applicable)

[ ] ♻ Refactor
[ ] ✨ New Feature
[ ] 🐛 Bug Fix
[ ] 📝 Documentation Update
[ ] 👷 Example Application
[ ] 🧑💻 Code Snippet
[ ] 🎨 Design
[ ] 📖 Content
[ ] 🧪 Tests
[ ] 🔖 Release
[ ] 🚩 Other

Description

This PR [adds/removes/fixes/replaces] this [feature/bug/etc].
Related Tickets & Documents

Resolves #
Mobile & Desktop Screenshots/Recordings

Added code snippets?

[ ] 👍 yes
[ ] 🙅 no, because they aren't needed

Added tests?

[ ] 👍 yes
[ ] 🙅 no, because they aren't needed
[ ] 🙋 no, because I need help

No tests? Add a note

Added to documentation?

[ ] 📜 readme
[ ] 📜 contributing.md
[ ] 📓 general documentation
[ ] 🙅 no documentation needed

No docs? Add a note

[optional] Are there any post-deployment tasks we need to perform?
[optional] What gif best describes this PR or how it makes you feel?

replyTo is not a property of message
await TbdexHttpClient.sendMessage({
    message: rfq,
    replyTo: 'https://example.com/callback'
  });

Updated


bug: the actor information has not been broadcasted to the affected CNs

Describe the bug
ERROR:  Failed to run the query

Caused by these errors (recent errors listed first):
1: gRPC request to meta service failed: Internal error
2: gRPC request to stream service failed: Internal error
3: actor 105 not found in info table

Reported in one of our customer and discovered by @shanicky , this is a corner for creating streaming jobs. It only appears under the following three situations:

the streaming job is create sink into table.
the sink is performing temporary joins on multiple tables.
The set of CNs that all joined tables distributed on is a subset of the set of CNs that the target table distributed on. In other words, some actors in the target table are distributed on CNs that are not present in the join tables.

Currently we only broadcast the info of new actors and all upstream actors to compute nodes that only have some building actors during creation of streaming job.
https://github.com/risingwavelabs/risingwave/blob/e05015a605fdecf542c142351caf5b7d3b43bfca/src/meta/src/stream/stream_manager.rs#L400-L409
It works for streaming jobs except for sink into table, because we broadcast actor infos of the sink and new target table jobs separately. Under the situation mentioned above, Some actors of the sink on some CNs do not know the information of the upstream sink actors when building.
https://github.com/risingwavelabs/risingwave/blob/e05015a605fdecf542c142351caf5b7d3b43bfca/src/meta/src/stream/stream_manager.rs#L493-L505
Error message/log
No response
To Reproduce
No response
Expected behavior
No response
How did you deploy RisingWave?
No response
The version of RisingWave
No response
Additional context
No response

Fixed by #18270 .


LP Rerouting via Block number

Refactored Price.ts - now Bond and Protocol Metric projects are using Price.ts from lib/utils folder
Added uniform getUniV2Rate() within lib/utils/Price.ts which is a "backbone" method for getting price for token
When checking for Market/USD price for Token, LP is determined via current block number
Currently, KLIMA, BCT and MCO2 token implementations are using different LP routing based on block number

Does this need to be updated to reflect the last-minute NCT addition?


Use Env:ChocolateyToolsLocation

https://github.com/mandiant/VM-Packages/blob/60e3edf97ee45faa12b380cf0ac17274aad4606b/packages/cygwin.vm/tools/chocolateyinstall.ps1#L31
When users update the default ${Env:RAW_TOOLS_DIR} location it also modifies the ${Env:ChocolateyToolsLocation} location and this is the location where Chocolatey defaults to install tools. For tools / dependencies that install to the default location, we need to use ${Env:ChocolateyToolsLocation}.

@mr-tz https://github.com/mandiant/VM-Packages/pull/138 closes this

sweet!


Change data input file yeast_codon_pos_i200.RData to alternative file format

This was discussed as part of the pull request #184 on the way to close issue #32, so I'm opening this as a ticket since it probably needs a bit of investigation anyway, regardless of how I navigate this in closing #184
The file: yeast_codon_pos_i200.RData
Initial issue details here: https://github.com/riboviz/riboviz/pull/184#issuecomment-652469274
It'd be handy to change this from a specific R data file to something easier to interrogate.

This file encodes a list of character matrices, that could easily be recast into a tidy data frame (flat text file). There are also problems with specific choices hard-coded into the script, that could easily be removed.
The information is, what is the codon at each position of every coding sequence (CDS) for the transcripts in the annotation? Thus my suggested data format would be a tidy data frame:
Gene    Pos_aa codon
YAL001C      1   ATG
YAL001C      2   GTA
YAL001C      3   CTG
YAL001C      4   ACG
YAL001C      5   ATT
...

Note, these column names should be consistent with other names for genes and amino acid position (not nucleotide position) as used in generate_stats_figs.R and so on.
However, currently:
> load("~/Repos/riboviz/riboviz/data/yeast_codon_pos_i200.RData")
> str(codon_pos)
List of 61
 $ TTT: chr [1:48833, 1:2] "YAL001C" "YAL001C" "YAL001C" "YAL001C" ...
 $ TTC: chr [1:32873, 1:2] "YAL001C" "YAL001C" "YAL001C" "YAL001C" ...
 ...
> View(codon_pos$ATA)
> head(codon_pos$AAA)
     [,1]      [,2]
[1,] "YAL001C" "14"
[2,] "YAL001C" "17"
[3,] "YAL001C" "19"
[4,] "YAL001C" "23"
[5,] "YAL001C" "40"
[6,] "YAL001C" "52"

This object was created by code in script_for_transcript_annotation.Rmd.
Problems:

bespoke undocumented data shape requires special accession.
codon position stored as character, not as integer.
data stored as binary file not text.
the choice to ignore the first 200 codon positions, and genes shorter than 200nt, is hard-coded in both the data-creation and data-analysis code. This should be a parameter.

All these can be solved by making a tidy data text format starting at the first position of the ORF. We can save it .gzipped to reduce footprint. Then there should be a new parameter, called codon_ramp_length or something, that controls how many initial codons to ignore, with default value 200. Then we write code to pass regression tests with that, and drop the .RData.
Writing code to address this harks back to issue #35.

I already wrote a function to decompose a sequence in to codons, in a pull request to stringr that was refused. Boohoo.
#' Dice a character vector into pieces of fixed length.
#'
#' Wraps stri_sub for situations where completely decomposing a string
#' into fixed-length substrings is appropriate. The last
#'
#' This is useful for example for breaking a coding sequence of DNA
#' into codon-sized triplets.
#'
#'
#' @param string input character vector.
#' @param width integer giving the width in letters of each piece to return.
#'
#' @return A character vector of substrings each of length `width`, except
#'   the last will be shorter if `length(string)` is not a multiple of `width`.
#'
#' @seealso The underlying implementation in [stringi::stri_sub()]
#' @export
#' @examples
#' hw <- "Hadley Wickham"
#' CDS <- "ATGTTTGGGTAG"
#'
#' str_dice(hw, width=1L)
#' str_dice(hw, width=2L)
#' str_dice(hw, width=4L)
#' str_dice(CDS, width=3L)
str_dice <- function(string, width=1L) {
     starts <- seq(1, nchar(string), width)
     stri_sub(string, from = starts, to = starts+width-1)
}

Given a sequence, we can chop it into codons using str_dice(CDS,width=3L).
Similarly, riboviz needs a function like this:
seq_to_codon_df <- function(seq, width=3L) {
     aa_pos <- seq(1, nchar(string), width)
     codons <- stringi::stri_sub(string, from = aa_pos, to = aa_pos+width-1)
    tibble(aa_pos=aa_pos, codon = codons)
}

Then we could automatically calculate the codons for each gene by:

get relevant coding sequences / ORFs from the annotation gff and fasta.
calculate the codon table as shown.
then join together across genes.

This is related to, but much simpler than, #105.
Lastly, the relevant chunk of generate_stats_figs.R or successor can then join this matrix to the RPF count matrix per A-site (I think) codon, and then calculate codon-specific occupancy in windows around those. To be discussed.

@mikej888 is writing code to create this data frame as part of #74.
We (probably @FlicAnderson in consultation with @mikej888) will then need to rewrite the R code so that it allows the code chunk (I think CalculateCodonSpecificRibosomeDensity) to exclude a user-defined number of initial codons. We can set this number to 200 initially to pass the regression test.

For testing this and #74 and other, related, work, I wrote a short R script rscripts/yeast_codon_pos_rdata_tsv.R which converts data/yeast_codon_pos_i200.RData to data/yeast_codon_pos_i200.tsv. The usage was:
$ Rscript rscripts/yeast_codon_pos_rdata_tsv.R  --offset 200

The TSV file is in the same TSV file format (header Gene Codon Pos) as output by python -m riboviz.tools.get_cds_codons_file (see #74).
An offset of 200 is added to each codon position to reflect the fact that the original .RData file had the first 200 codons removed. This also means that the file will be consistent going forward to test the proposed functionality in previous comments that the number of codons to exclude be a parameter to generate_stats_figs.R (or its successor) so inputs to this refactored/new script will assume all codons in the TSV file are 1-based.

Used for pausing analysis; @john-s-f you brought this up on 02 Sept.

After chat with @mikej888 earlier, this is my plan to make progress on this issue:
I need to work on this function in stats_figs_block_functions.R which gets used here in generate_stats_figs.R, to add the ability to process data/yeast_codon_pos_i200.tsv which Mike's created from the .RData file version which generate_stats_figs.R currently uses as codon_positions_file.
Step 0: make branch from gff-spec-74 since this contains the .tsv file and relevant code
Step 1: test creation (objects A, P, E, cod_dens_tRNA_data to be written out as .tsv files, then check their equality)
Step 2: edit CalculateCodonSpecificRibosomeDensity() function to be able to load in the .tsv instead of just:
load(codon_positions_file) # Position of codons in each gene (numbering ignores first 200 codons)
  # Reads in an object named "codon_pos""

Step 3: start editing the function CalculateCodonSpecificRibosomeDensity() and contents to accept an argument of how many codons to skip. Default: 200
Step 4: check that the test gives same result between objects created when running with codon_positions_file as yeast_codon_pos_i200.RData and yeast_codon_pos_i200.tsv.

Update: I haven't made any progress on this yet since chatting about what the next steps are last week with Mike.

Still to do!

@shahpr is working on this as of the hackathon; @ewallace volunteers to test the changes.

@shahpr is working on this as of the hackathon; @ewallace volunteers to test the changes.

After chat with @mikej888 earlier, this is my plan to make progress on this issue:
I need to work on this function in stats_figs_block_functions.R which gets used here in generate_stats_figs.R, to add the ability to process data/yeast_codon_pos_i200.tsv which Mike's created from the .RData file version which generate_stats_figs.R currently uses as codon_positions_file.
Step 0: make branch from gff-spec-74 since this contains the .tsv file and relevant code
Step 1: test creation (objects A, P, E, cod_dens_tRNA_data to be written out as .tsv files, then check their equality)
Step 2: edit CalculateCodonSpecificRibosomeDensity() function to be able to load in the .tsv instead of just:
load(codon_positions_file) # Position of codons in each gene (numbering ignores first 200 codons)
  # Reads in an object named "codon_pos""

Step 3: start editing the function CalculateCodonSpecificRibosomeDensity() and contents to accept an argument of how many codons to skip. Default: 200
Step 4: check that the test gives same result between objects created when running with codon_positions_file as yeast_codon_pos_i200.RData and yeast_codon_pos_i200.tsv.

As an update, the yeast_codon_pos_i200.tsv file can be found in branch develop at data/yeast_codon_pos_i200.tsv after the branch gff-spec-74 was merged into develop ~6 months ago.  This will be useful for @swinterbourne


Move "Slick" events binding before initialization.

Based on this: https://github.com/kenwheeler/slick/issues/1005.
You should move all events binding before initializing "Slick" plugin it-self. Specially "onInit" event.

I think angular-slick has gone inactive, judging by the huge backlog of PRs. But you can fix this problem by simply making a copy of the library, and moving the two event-handlers. Inside of the 'intializeSlick' function, find slider.on('init', ... and slider.on('afterChange', ..., and move them up above the call to slider.slick({...}).

That worked for me. +1
I've sent @vasyabigi 24 days ago; asking him if he is not interested in maintaining the repo, maybe he can assign it to somebody who is welling. He did not respond, I hope that he is doing well.

There's a second bug in the on-init handler, too - the first "if" statement needs to check scope.onInit.
And +1 for moving the handler above the slick initialization to get on-init working.


BUG: fix CORS by adding vercel.conf

Vercel deployment environment does not seem to pick up nextjs.conf.js, so trying an alternative through vercel.conf
Continues the work started in #49

This PR has been removed by rewriting history on main branch. This was really not needed. There was a bug in the Vercel integration with GitHub which was the result of the branch renaming from master to main that was unrelated to this


[mempool] restart VM when VM publishing option changes

Motivation
Mempool should restart VM validator when VM publishing options change, since this changes how mempool decides which submitted txns to accept
Test Plan
Updated the smoke test test_e2e_modify_publishing_option to remove the hard-coded forced node restart to simulate vm restart, and test passes without restarting node

:umbrella: The latest upstream changes (presumably 3b0107a8640c7c0956a16da1696692bb55945b2b) made this pull request unmergeable. Please resolve the merge conflicts.

:umbrella: The latest upstream changes (presumably b31d0123c34755d622008c01c605d0e750e1575a) made this pull request unmergeable. Please resolve the merge conflicts.

@bors-libra r=runtian-zhou

:pushpin: Commit a97f9a0 has been approved by runtian-zhou

:hourglass: Testing commit a97f9a0a8da05c932c3dc93830227fdd25880b6b with merge c08e7e7100bf4dbfb37cdeb7905bb2dcfba741cd...

:broken_heart: Test failed - checks-circle_commit_workflow

@bors-libra retry

:hourglass: Testing commit a97f9a0a8da05c932c3dc93830227fdd25880b6b with merge 868367a31508382c9a01cc669753e5f98f1c31e9...

:sunny: Test successful - checks-actions_land_blocking_test, checks-circle_commit_workflow
Approved by: runtian-zhou
Pushing 868367a31508382c9a01cc669753e5f98f1c31e9 to master...


Newsletter subscription doesn't work

Hey, I'd be very interested in the weekly newsletter with your thoughts on complexity, hacking and entrepreneurship! Unfortunately, the subscribe button on kerkour.com doesn't seem to work.

Thank you for the report!
The newsletter is temporarily paused.
In the mean time I can manually add you to the list, so feel free to send me your email in the red chatbox at the bottom right of the https://kerkour.com/about page :)

Thank you for the report!
The newsletter is temporarily paused.
In the mean time I can manually add you to the list, so feel free to send me your email in the red chatbox at the bottom right of the https://kerkour.com/about page :)


Endless dependency checking during installation

Expected Behavior
gimme-aws-creds installs within a few minutes
Current Behavior
I've cancelled the installation after 1 hour. The installation just keeps cehcking these versions
....
Collecting botocore<1.21.0,>=1.20.89
  Using cached botocore-1.20.89-py2.py3-none-any.whl (7.6 MB)
Collecting boto3<2.0.0,>=1.7.70
  Using cached boto3-1.17.88-py2.py3-none-any.whl (131 kB)
Collecting botocore<1.21.0,>=1.20.88
  Using cached botocore-1.20.88-py2.py3-none-any.whl (7.6 MB)
Collecting boto3<2.0.0,>=1.7.70
  Using cached boto3-1.17.87-py2.py3-none-any.whl (131 kB)
Collecting botocore<1.21.0,>=1.20.87
  Using cached botocore-1.20.87-py2.py3-none-any.whl (7.6 MB)
Collecting boto3<2.0.0,>=1.7.70
  Using cached boto3-1.17.86-py2.py3-none-any.whl (131 kB)
Collecting botocore<1.21.0,>=1.20.86
  Using cached botocore-1.20.86-py2.py3-none-any.whl (7.6 MB)
Collecting boto3<2.0.0,>=1.7.70
  Using cached boto3-1.17.85-py2.py3-none-any.whl (131 kB)
Collecting botocore<1.21.0,>=1.20.85
  Using cached botocore-1.20.85-py2.py3-none-any.whl (7.6 MB)
Collecting boto3<2.0.0,>=1.7.70
  Using cached boto3-1.17.84-py2.py3-none-any.whl (131 kB)
Collecting botocore<1.21.0,>=1.20.84
  Using cached botocore-1.20.84-py2.py3-none-any.whl (7.6 MB)
Collecting boto3<2.0.0,>=1.7.70
  Using cached boto3-1.17.83-py2.py3-none-any.whl (131 kB)
Collecting botocore<1.21.0,>=1.20.83
  Using cached botocore-1.20.83-py2.py3-none-any.whl (7.6 MB)
Collecting boto3<2.0.0,>=1.7.70
  Using cached boto3-1.17.82-py2.py3-none-any.whl (131 kB)

Possible Solution
N/A
Workaround -- use python 3.9
Steps to Reproduce (for bugs)

Run pip3 install --upgrade gimme-aws-creds as an admin

Context
Python was upgraded to v3.10 and gimme-aws-creds stopped working. Installing again didn't work -- the same endless dependency checking. I've removed everything and tried a fresh installation, however still the same.
Your Environment
Windows 10 (the latest)
Python 3.10.0 (via Choco)
pip 21.2.4 from C:\Python310\lib\site-packages\pip (python 3.10)
Installing as an admin

I got the same issue in a fresh virtual environment with python 3.10.0 and pip 21.2.3 on Windows 10.

I hit this same issue, and was able to resolve by upgrading pip (from 21.2.3 to 21.3.1). After the pip upgrade I didn't have the issue of endless dependency checking.

Python 3.10.1
pip 21.3.1
Allows me to install gimme-aws-creds 2.4.0, but not the latest.  The error is:

ERROR: Could not find a version that satisfies the requirement winrt>=1.0.20330.1; platform_system == "Windows" and python_version >= "3.7" (from ctap-keyring-device) (from versions: none)
ERROR: No matching distribution found for winrt>=1.0.20330.1; platform_system == "Windows" and python_version >= "3.7"

Same issue here, python 3.10.0 and pip 21.2.3

Go the same issue, anyone know of a workaround?

@ignas-sakalauskas-cko mentioned downgrading python as a possible workaround.  This did not work for me on python 3.9.10/


PROMIS/3-month QOL Survey Submission Report

Please generate data tables for PROMIS/QOL survey submission following the first, second, and third email and SMS notifications; the overall structure and formatting should be similar to the baseline survey completion report.
The cadence for each notification is as follows:
1st (email and SMS): set to be triggered 90 days post verification
2nd (email and SMS): 93 days post verification
3rd (email and SMS): 99 days post verification
Note that the three PROMIS/QOL survey reminders are currently programmed to be sent to participants who were verified on or after 12/2/23, excluding backlogged participants.

Kelsey also confirmed that all 167 participants in Table 2 completed the PROMIS survey the same day as the notification (not before)

All 167 in Table 2 and all 162 in table 3

Correction: new pts verified on or after 12/1/23
Also as a friendly reminder, the PROMIS/QOL survey only gets triggered to people upon getting the first notification so the expected number of completed should be based on the number of people who received the first contact.

@HanaShiho  Here's the update with the verification date pushed back.  As the data is pulled for only those with PROMIS notifications, there's no issues with the denominator
PROMIS-Completion-vs-Notifications.pdf

@KELSEYDOWLING7 and @HanaShiho Since the emails and texts go to the same people at the same time, please rethink how to reconfigure this to represent this. One table would be best, rather than separate tables for email and SMS.
Then a separate table to indicate how many people got sent email only vs sms only vs both at each contact attempt, just based on a notifications table would be good.
There are a few footnotes that aren't accurate, please work together to fix those.
Thanks.

@brotzmanmj, so Kelsey and I took another look at the report, and it looks like she already had a)verified on or after 12/1/23 and b) verified for 90 days incorporated in the code, considering PROMIS is different from any other surveys in its prospective nature. So the number of people who were eligible for the 2nd reminder correctly excluded people who met any of the exclusion criteria along with the aforementioned timing conditions.
Also, regarding your comment about some of the footnotes being inaccurate, Kelsey will update the footnotes to reflect the following :1) eligible participants will receive both emails and texts unless they opted out of receiving text messages; 2) those who refused the BL survey should still receive the PROMIS reminder; and 3) in addition to the exclusion requirements outlined for the 1st contact, the 2nd and subsequent contacts should further exclude anyone who submitted the PROMIS survey or who refused the 3-month PROMIS survey.

@KELSEYDOWLING7  and @HanaShiho  The eligibility for the 2nd reminder needs to exclude people who are 91 or 92 days post verification because they will not be eligible for it until 93 days post verification. The eligiblity for the 3rd reminder meeds to exclude people who are 94 - 98 days post verification because they will not be eligible for it until 99 days post verification.

small correction to what I just posted... The eligiblity for the 3rd reminder meeds to exclude people who are 90 - 98 days post verification because they will not be eligible for it until 99 days post verification.

@brotzmanmj  For that last update, we do already have "4 ’ Email reminder schedule: Contact 1 is sent 90 days after verification; Contact 2 on day 93 post verification; Contact 3 on day 99 post verification." that implies eligibility or lackthereof based on how long ago verification occurred. Did you want to reemphasize that in the eligibility footnote?

@KELSEYDOWLING7 I'm actually referring to the programming rather than the footnote.  What I'm saying is, the people who are eligible for the 2nd contact attempt should not equal the number of people who were sent contact 1 minus the number of people who completed the PROMIS survey after contact 1 and before contact 2. It has to be the number of people who were sent contact 1, minus the number of people who complete the PROMIS survey after contact 1 and before contact 2 MINUS the number of people who are less than 93 days post verification. Does that make sense? This is different than the BL survey or KP biospecimen analysis we did in a similar manner before, because those were entirely from a retrospective period of time.

Oh! Yes ok that makes sense, and why we're seeing different numbers than expected. I'll work to fix that.
Then when I looked at all the participants there's no one that ONLY had emails or ONLY had sms. Everyone that had sms texts received emails and everyone that received emails got at least one text. But that seems to make sense as well based on the timing of the notification.
And lastly many people did PROMIS the day OF contact 1. So I adjusted that to be 'Survey Completed On Date of Contact 1',  'Survey Completed after Contact 1, before Contact 2' ect. Please let me know if that works.

@brotzmanmj  Please let me know how this looks.
PROMIS-Completion-vs-Notifications.pdf

@HanaShiho please take the first review and provide feedback

@KELSEYDOWLING7, thank you for the updated report! Looks good to me, I just have minor suggestions. Can you please add a line after each contact attempt indicating how many people are ineligible and thus excluded from the denominator for the next contact attempt? (Basically, those who had not reached the necessary post-verification date.) I know you've already incorporated this into your code, but if you can list that attrition in the table, that would be great. Also, I think we can avoid separating those who completed the survey on vs. after Contact 1, but that's just my preference.

I agree with Hana. And I see there is still a small gap (albeit much smaller now!) between the number eligible and the number sent. My best guess is that this is due to the verification before 3pm vs after 3pm distinction. Are we taking that into account?

Kelsey asked this question also about daylight saving and I told her that we wound't need to. @KELSEYDOWLING7, can you please rerun the report incorporating the verification time (before 3 PM vs. after 3PM)? Thank you!

Hi @KELSEYDOWLING7 and @HanaShiho  This is not about daylight savings time. This is about the fact that if verification occurs before 3pm, it counts that day as Day 0, and if verification occurs after 3pm (and up until 2:59pm) the next day, it counts the day after verification as Day 0. @KELSEYDOWLING7  this is the same way you coded the expectation in our other analysis as expected to go out on day 3, 6, 12 vs day 4, 7, 13, etc. The same coding you did then applies here as to what is 'day 90, 93, 99' for a participant. You also captured the times correctly in UTC so there was no need to worry about daylight savings. Do you recall this? Let's use the same coding here.

Thanks, @KELSEYDOWLING7! For Eligible for Contact 2, shouldn't it be smaller than 1262 (i.e. 1928-584-82)? From there, more pts could have been excluded if they further met the exclusion criteria for the 2nd reminder. To your other point, it doesn't make sense to me the percentage would go over 100%, but I'm not sure about applying the eligibility criteria to Reminder 2 and Reminder 3 separately. The way I see it, the denominators (whoever is eligible for the next reminder) should get sequentially smaller, but I'll defer to @brotzmanmj.

@HanaShiho  Thank you, you're right it should be exactly 1,262 for 'Eligible for Contact 2'. I had forgotten to apply the verification time adjustment to those rows as well.
And a percentage over 100% would mean more were sent then were eligible, which has happened in the past. If I use the original definition of 'Eligible for reminder Contact 3' as 'Sent reminder Contact 2'-'Survey Completed after Contact 2, before Contact 3' - 'Not verified long enough for Contact 3'  with the corrections we still get above 100%, though very small.

HI @KELSEYDOWLING7 can you update this now that we have Contact 4 in prod? Thanks

@brotzmanmj  Sure thing. How many days after verification is contact 4 sent? @HanaShiho

@KELSEYDOWLING7 135 days post verification

@brotzmanmj @HanaShiho Similar to the original BL Survey Reminders, while most people verified after 3pm had their notifications delayed 1 day post verification and most people had their notifications as expected if verified before 3pm, that somehow did not apply to everyone. 24 people verified after 3pm still got their first email and/or text notification 90 days after verif instead of 91; about 6 got their second notification at day 93 instead of 94.  Of those verified before 3pm, 14 received their first notif on day 91 instead of 90; 7 received their 2nd notif on day 94 instead of 93. This may account for the discrepancy between some of the eligible vs sent counts.
PROMIS-Completion-vs-Notifications.pdf

Hi @KELSEYDOWLING7  that is interesting. Can you remind me what UTC time you're using for 3pm?

@KELSEYDOWLING7  Would it be possible to use the day they got their 1st contact attempt as the basis for when to expect their future contact attempts? Meaning, if they got their first contact attempt on day 90 then the next one is expected on day 93, etc. If they got their first contact attempt on day 91, then the next one is expected on day 24, etc. That would take the guesswork out of it. What do you think?

@KELSEYDOWLING7  Thanks for pointing that out. I have no explanation for what is happening. My suggestion would be then to use the first notification to predict the timing of the second notification, but use the 'on time' expected days for messages 3 and 4

@brotzmanmj  This helped, but we still have a slight overage.
PROMIS-Completion-vs-Notifications.pdf

Hi @KELSEYDOWLING7  this is close enough and probably as good as we are going to get. We would like to have this run on a weekly basis going forward. What would be the best place to put this? Do we have a Communications Weekly Report that is internal to the CCC?

Hi @brotzmanmj  Great. Yes, we have this folder for CCC weekly reports and I can add an additional folder for 'Weekly Notifications Reports'. Do you want this run every Monday?

Yes that would be great thanks

@brotzmanmj  All set! This week's report is now in there


Hello World | leftover博客

https://leftover.cn/2022/04/19/hello-world/#more
Welcome to Hexo! This is your very first post. Check documentation for more info. If you get any problems when using Hexo, you can find the answer in troubleshooting or you can ask me on GitHub.

1100

大家好


Error when custom step folder in integration tests

First of all thanks for this great library.
I have an error when I set a custom folder for the generated steps using integration tests (I'm using the last version 1.3.0):
This is my build.yaml:
targets:   $default:     sources:       - integration_test/**   # By default, build runner will not generate code in the integration folder       - test/**               # so we override paths for code generation here       - lib/**       - $package$     builders:       bdd_widget_test|featureBuilder:         options:           include: package:bdd_widget_test/bdd_options.yaml           stepFolderName: ../../my_steps
And this is the output when I lunch the test:
org-dartlang-app:/survey_login_test.dart:12:8: Error: Error when reading 'org-dartlang-app:/my_steps/i_see_complex_text.dart': File not found import './../../my_steps/i_see_complex_text.dart';
If I remove the stepFolderName the test is working like a charm.
Thanks in advance

Hey @jamontes79  👋
What is the folder structure looks like?
I assume that there is a survery_login.feature file somewhere inside the test folder, right? Is ../../my_steps/i_see_complex_text.dart is a correct path for this file?

Hi @olexale
Thanks for your quickly answer.
Yes, the folder is under test folder and the path is correct, here is a screenshot from the project

:
It's seems to be something related with integration tests and relative path, but I'm not sure

Unfortunately, I don't see an error on this screenshot. Is it possible for you to prepare a very basic project that illustrates the problem (just remove everything related to your app from this project, and keep only things that are absolutely required for tests to run) and share it with me?

Sure... I'll try to prepare it during today.
Thanks a lot! :)

I've just found the problem.
It seems that integration tests (executing in web) can't find ancestors folders.
So the solution in my case it's to have a main entry point with all generated tests, and now they can find the folders.
Thanks and again, great job with this library.


fix(middle slider): initial range value uselessly rounded

Proposed Changes
The value was rounded to an integer so it was loosing the required precision to convert a big range (like 0 to 30 000) to the slider range (0 to 100) and get the correct range again.
Potential Breaking Changes
none
Acceptance Criteria

[ ] The proposed changes are covered by unit tests
[x] The potential breaking changes are clearly identified
[ ] README.md is adjusted to reflect the proposed changes (if relevant)

https://github.com/coveo/react-vapor/pull/1601


T-gate constexpr function definition is incorrect

Issue description
The definition of the T-gate in Gates.hpp currently mirrors the S gate. This should be rectified. The gate definitions are not currently used in gate applications, and so does not affect program correctness.

Expected behavior: T-gate definition should be correct.

Actual behavior: (What actually happens)

Reproduces how often: (What percentage of the time does it reproduce?)

System information: (post the output of import pennylane as qml; qml.about())

Close the issue as it is fixed in #212.
https://github.com/PennyLaneAI/pennylane-lightning/blob/2cb27272c7882c5cf63a0ef047dc37884c113cac/pennylane_lightning/src/gates/Gates.hpp#L88-L92


Create Weight Maintenance Guide.md

Publishing Weights Maintenance Guide as part of MRC31 deliverables. This guide documents the process by which weights that have been distributed can be revoked from a contributor when they fail to keep up with their duties of maintaining the effort.

This is great. Thanks.


Add /api/sampling endpoint in collector

Which problem is this PR solving?

According to #1971, expose the /sampling endpoint in collector.

Short description of the changes

Added /api/sampling endpoint in collector APIHandler and created a new file testserver_utils.go which holds test utility functions shared by the agent and collector.

@yurishkuro Do I update the content/docs/next-release/faq in the documentation repo?

Do I update the content/docs/next-release/faq in the documentation repo?

yes

@yurishkuro How would an import from the same repo resolve if it is pointing to the remote master that does not contain the branch's changes?

Sorry, I don't follow.

@yurishkuro For example, when I import "github.com/jaegertracing/jaeger/cmd/agent/app/httpserver" the import points to the remote repo that has been downloaded in /vendor, which causes compilation errors. So my question is, how would I properly import the local package from my branch.

There's something wrong with your Go setup then. Maybe you cloned this repo in the wrong location, it should be under $GOPATH/src/github.com/jaegertracing/jaeger/

@yurishkuro it appears cross-dock is failing and it is not clear from the logs as to why. Could this be related to #1455?

This PR now creates a lot of new public APIs. I don't think it's necessary. What we need is to pull the HTTP handler from the agent into a shared location, e.g. /pkg/clientcfg/http where there's only a single public type HTTPHandler that has RegisterHander(mux) function. The actual HTTPServer should remain in the agent, and the collector has its own HTTPService (used for /api/traces endpoint). This will also mean the test infrastructure that you made public can remain private in that package.

@yurishkuro if RegisterHandler(mux) will go in /pkg/clientcfg/http/http_handler.go, for example, then does that mean you want all the handler functions such as serveSamplingHTTP and serveBaggageHTTP to go there as well?

Yes, since they are part of the implementation. And they can remain private

I did the refactoring as a separate PR #1996, please rebase. It should limit the scope of this change to only registering the endpoints from collector.

So APIHandler in cmd/collector/app/http_handler.go should contain a clientcfghttp.HTTPHandler?


Info: Rewrite document to table-style

It's part of my #3 proposal. Please tell me what you think, then I will improve formatting before merging. Some table cells would love some line breaks!
If it's alright, I will continue with the other documents.
I've also noted that the old description seemed to be actually wrong in a few places around the middle of the spec. I had implemented a parser around Hodor's description earlier so I'm pretty confident it is correct. Not that I explored any advnced features like item tables...
I've included other links (all that I know of) to cross-check, if anyone's interested.

It is mostly a translation of Hodor's description (it seemed pretty
close to current document in wording).
Sources used:

Main: https://xgm.guru/p/wc3/w3-file-format
https://www.wc3maps.com/InsideTheW3M.html
https://github.com/stijnherfst/HiveWE/wiki/war3map.w3i---Map-Info

Potential sources:

Not available there: https://github.com/inwc3/wc3libs/tree/master/wc3libs_doc/src/specs/bin
https://www.hiveworkshop.com/threads/parsing-metadata-from-w3m-w3x-w3n.322007/
https://www.hiveworkshop.com/threads/list-of-official-patches-for-warcraft-3.322919/

Here're the CSV files I've worked with and then converted to Markdown tables with https://www.tablesgenerator.com/markdown_tables After this gets merged, the master copy will become the .md document here.
wc3i.csv
wc3i-flags.csv
wc3i-playerdata.csv
wc3i-teamdata.csv
wc3i-team-flags.csv
wc3i-custom-upgrades.csv
wc3i-custom-tech.csv
wc3i-randomunittables.csv
wc3i-randomitemtables.csv

@ChiefOfGxBxL hey do you have time to review and accept the PR? If not, I will continue with changes in my fork.

@Luashine My apologies for the delay. I've reviewed the changes and approved them! Great job and thank you!


REST API docs for finalising a DataModel use incorrect body parameter names

https://maurodatamapper.github.io/rest-api/resources/data-model/#finalise-a-data-model states that the body parameters for dataModel/XXX/finalise are versionChange and version. This is incorrect - they are versionChangeType and version.

Thanks for this, @spco - much appreciated.  We're working on a new version of the API docs here - https://documenter.getpostman.com/view/9840589/UVC8BkkA  (it helps if you switch "Environment" to "No Environment" to see all the parameters).  I'll make the change to the Docs here for now though :)


How to add a shadow under the buttons?

By adding a BoxDecoration property with a BoxShadow property, the shadow stays inside the button block and does not go outside of it. Is it possible to add a property like the elevation property to material objects?
ButtonsTabBar(               decoration: BoxDecoration(                 color: EtalogColors.primary,                 borderRadius: BorderRadius.circular(50),                 boxShadow:[                   BoxShadow(                     color: Colors.grey.withOpacity(0.5),                     spreadRadius: 1,                     blurRadius: 10,                     offset: Offset(0, 15),                   ),                   //you can set more BoxShadow() here                 ],               ),             radius: 0,             tabs: [               Tab(text: 'Все'),               Tab(text: 'В пути'),               Tab(text: 'Под разгрузкой'),             ],           ),

Hello, thank your for bringing this up. Would the option elevation fix your problem?

Hello, thanks for your response. If the buttons had an elevation property that works the same as the Material widgets, then this would solve my problem. Now the problem is that the container around the button limits the shadow of the button itself (this can be seen on the "Все" button).
So the elevation property is just a handy tool, but it won't work while there is a container constraint.
BoxShadow doesn't work for the same reason.

I added a new parameter for the elevation.
Let me know if it fixes your problem or not.
Nevertheless, feel free to reopen this issue :)

PS: use version 1.3.3

Thanks for the quick solution.
The elevation property completely solved my problem.
Now another problem has appeared - before, the entire button block was aligned using the alignment: Alignment.topCenter property (the first screenshot in this thread), but now it ignores this property and is always pressed to the left edge of the screen.

The center: true property of ButtonsTabBar centers the first button, not the entire block of buttons.

Perhaps I don’t imagine the solution to this problem correctly, I didn’t try hard to figure it out, but I think other users will also change this behavior after upgrading to version 1.3.3 and they won’t find how to quickly fix it either.

This behavior was expected, but I changed the source code (version 1.3.4), so you can obtain the effect you desire.
If you wrap the ButtonsTabBar widget with a Center widget, you can get the desired effect (without using the center: true parameter).
Let me know if it worked!

Good afternoon thanks! Everything is working great now!👍

Great! Thank you

why Everything is not working for me!


Wrong number of reactions

From the browser, this dataset is shown to have 2839 reactions.

If I download the dataset (pb.gz) from here, there are only 1728 reactions.
Also, typing anything into the search bar on https://open-reaction-database.org/browse gives me a blank page.

Ah that's actually the dataset ID in the postgres, not the dataset size. We should remove that field I think. I'll send a PR.

Actually we should probably fetch the correct dataset ID and have it link to the search for that.

Actually we should probably fetch the correct dataset ID and have it link to the search for that.

Moved to #97


Hackage url compatibility

To maximise hackage compatibility we should produce the same urls. Here's a list of what Hackage provides (extracted from https://hackage.haskell.org/api).

/package/<pkg-id>/<pkg-id>.tar.gz

This is confusing, and indeed this note on hacakge-security starts with:

The situation with paths in cabal/hackage is a bit of a mess.

Reading that note and comparing with the code, I gather that:

The "official" hackage path is /package/<pkg-id>/<pkg-id>.tar.gz
Hackage provides a redirect from /package/<pkg-id>.tar.gz to /package/<pkg-id>/<pkg-id>.tar.gz
cabal-install still uses /package/<pkg-id>.tar.gz

We have been using package/{pkg-id}.tar.gz and everything has been working fine, I guess we need to keep it like that. Note that a static website cannot serve a redirect (at least not in a general way).

/package/{pkg-id}/{pkg-name}.cabal

This is the most recent cabal file. So far we expose this at index/{pkg-name}/{pkg-version}/{pkg-name}.cabal. Note: When first writing foliage, I used hackage-repo-tool as a blue print. hackage-repo-tool does create the /index paths, although they are not provided by Hackage, likely this is for compatibility with local indicies.

/package/{pkg-id}/revision/{rev-number}.cabal

This is for all revisions. We don't have anything like this at the moment.

I had a second look, it's hackage-security that defines the layout for hackage, and it uses  /package/<pkg-id>.tar.gz.
https://github.com/haskell/hackage-security/blob/482bc5a8c0215142e3ec224498453d2b5a25203c/hackage-security/src/Hackage/Security/TUF/Layout/Repo.hs#L52
I guess at this point it's irrelevant what hackage-server calls official :shrug:


jcabi-github inefficiency

jcabi-github seems to, in general, extract IDs from nested JSON objects and issue redundant API requests to fetch those objects, rather that loading those objects from a nested portion of the already-returned JSON.

Indirectly related: https://github.com/jcabi/jcabi-github/issues/1092

Also, I'm unsure whether jsn or .json() results in a re-fetch every time.

Very tangential: jcabi-github returns most URLs as Strings instead of URLs

Superseded by https://github.com/cvrebert/typed-github/issues/7 and https://github.com/cvrebert/typed-github/issues/10


Push Binary

          Unfortunately, I do not understand and you are not telling me why this is being done. Feel free to open an issue instead, I will be happy to help.

Originally posted by @shilangyu in https://github.com/shilangyu/scoop-search/issues/60#issuecomment-2214253497

Re-open #60

@skanda890 please tell me why this is needed. Releases of scoop-search include binaries. https://github.com/shilangyu/scoop-search/releases/tag/v1.5.0

First, when I wanted to merge branches I went to skanda890/scoop-search found two branches named  , merged them into the default branch, and created #57 then you closed it saying that the base branch has been updated, etc, and I created #60 and since Debug Logging was already fixed we remain with only Pushing Binary, and that is why I wanted to merge #60.

I am creating one more pull request, as you saw my explanation please allow to merge that pull request.

But why is the binary being pushed?

Closing due to no direct response to my question. Feel free to comment with an answer and I will be happy to help.

In the commit shown above, we see that you have called it Push


dummy commit to make pull request

No merge issues

Flake8 linting errors:
./oscillating-oysters/twentytwentymud/MUD/consumers.py:161:120: E501 line too long (180 > 119 characters)
./oscillating-oysters/twentytwentymud/MUD/consumers.py:167:53: E226 missing whitespace around arithmetic operator
./oscillating-oysters/twentytwentymud/MUD/consumers.py:173:120: E501 line too long (128 > 119 characters)
./oscillating-oysters/twentytwentymud/MUD/consumers.py:198:120: E501 line too long (145 > 119 characters)
./oscillating-oysters/twentytwentymud/MUD/consumers.py:232:13: E123 closing bracket does not match indentation of opening bracket's line
./oscillating-oysters/twentytwentymud/MUD/consumers.py:240:18: E126 continuation line over-indented for hanging indent
./oscillating-oysters/twentytwentymud/MUD/consumers.py:240:91: W504 line break after binary operator
./oscillating-oysters/twentytwentymud/MUD/consumers.py:241:85: W504 line break after binary operator
./oscillating-oysters/twentytwentymud/MUD/consumers.py:242:77: W504 line break after binary operator
./oscillating-oysters/twentytwentymud/MUD/consumers.py:243:85: W504 line break after binary operator
./oscillating-oysters/twentytwentymud/MUD/consumers.py:244:46: W504 line break after binary operator
./oscillating-oysters/twentytwentymud/MUD/consumers.py:246:18: E123 closing bracket does not match indentation of opening bracket's line


Feign does not support @PathVariable for path at @FeignClient

Base interface:
public interface SomeEndpoint {
    @RequestMapping(method = RequestMethod.GET, value = "/check")
    void check(@PathVariable("resource") String resource);
}

Feign client:
@FeignClient(value = "some-service", path = "/api/{resource}")
public interface SomeClient extends SomeEndpoint {
}

Usage example:
public class SomeTest {
    private final SomeClient someClient;

    @Autowired
    public SomeTest(SomeClient client) {
        this.someClient = someClient;
    }

    public void test() {
        someClient.check("hello");
    }
}

Output:
Exception in thread "main" java.lang.IllegalArgumentException: Illegal character in path at index 24: http://some-service/api/{resource}/check
 at java.net.URI.create(URI.java:852)
  at org.springframework.cloud.netflix.feign.ribbon.LoadBalancerFeignClient.execute(LoadBalancerFeignClient.java:56)
  at feign.SynchronousMethodHandler.executeAndDecode(SynchronousMethodHandler.java:97)
  at feign.SynchronousMethodHandler.invoke(SynchronousMethodHandler.java:76)
  at feign.ReflectiveFeign$FeignInvocationHandler.invoke(ReflectiveFeign.java:103)
  at com.sun.proxy.$Proxy74.upload(Unknown Source)
  at SomeTest.test()
  ...
Caused by: java.net.URISyntaxException: Illegal character in path at index 24: http://some-service/api/{resourse}/check
  at java.net.URI$Parser.fail(URI.java:2848)
  at java.net.URI$Parser.checkChars(URI.java:3021)
  at java.net.URI$Parser.parseHierarchical(URI.java:3105)
  at java.net.URI$Parser.parse(URI.java:3053)
  at java.net.URI.<init>(URI.java:588)
  at java.net.URI.create(URI.java:850)
  ... 7 more

Curious to know if this only occurs when using a sub interface?

I'm facing a similar issue as well. However I sub-classed the controller instead of the feign client.
Example code but should be similar.
@FeignClient("SomeService")
public interface FeignClient {
  @RequestMapping(path = "/{id}", method = RequestMethod.GET)
  getId(@PathVariable("id") long id)
}

public class BaseController {
  @Autowired
  FeignClient client;

  @RequestMapping(path = "/{id}", method = RequestMethod.GET)
  public String getId(@PathVariable("id") long id) {
    client.getId(id);
  }
}

@RequestController
@RequestMapping("/api")
public class Controller extends BaseController {
  @Override
  public String getId(@PathVariable("id") long id) {
    super.get(id);
  }
}

Error is
Caused by: java.lang.IllegalArgumentException: Illegal character in path at index 19: http://SomeService/{id}
 at java.net.URI.create(URI.java:852)
 at org.springframework.cloud.netflix.feign.ribbon.LoadBalancerFeignClient.execute(LoadBalancerFeignClient.java:56)
 at feign.SynchronousMethodHandler.executeAndDecode(SynchronousMethodHandler.java:97)
 at feign.SynchronousMethodHandler.invoke(SynchronousMethodHandler.java:76)
 at feign.hystrix.HystrixInvocationHandler$1.run(HystrixInvocationHandler.java:108)
 at com.netflix.hystrix.HystrixCommand$2.call(HystrixCommand.java:301)
 at com.netflix.hystrix.HystrixCommand$2.call(HystrixCommand.java:297)
 at rx.internal.operators.OnSubscribeDefer.call(OnSubscribeDefer.java:46)
 ... 28 common frames omitted

I've traced the error to this method in SynchronousMethodHandler where argv no longer contains the actual id anymore. Hence, the URI in downstream became http://SomeService/{id} instead of http://SomeService/1 as it should be.
@Override
  public Object invoke(Object[] argv) throws Throwable {
    RequestTemplate template = buildTemplateFromArgs.create(argv);

I guess I dont see the point in doing that.  Why wouldnt Controller just use FeignClient directly?

The use case here is that we're in the midst of transitioning our v1 APIs to v2 APIs. The above code lies in our gateway. Extending the old controller would allow us to retain all our v1 APIs while selectively route certain routes to the v2 APIs. In Controller, we would call super, then call FeignClientV2, and compare the results. This is to ensure that the v2 APIs are backward compatible with the old responses and that we don't break anything.
The fuller code probably looks like this.
@RequestController
@RequestMapping("/api")
public class Controller extends BaseController {
  @Autowired
  FeignClientV2 clientV2;

  @Override
  public String getId(@PathVariable("id") long id) {
    String oldResponse = super.get(id); // exception is thrown here
    String newResponse = clientV2.get(id);
    if (!oldResponse.equals(newResponse)) {
      // do some logging
    }
    return oldResponse;
  }
}

Sorry for not giving the full use case previously because it seems irrelevant to the issue at hand.
Is this supposed to happen when sub-classing the controller?
off-topic: Is there a better way to achieve what I want?

Doesn't seem relevant to the feign issue

Hello Folks,
Today i faced the same issue and i found the solution.
The problem with my code snippet was,have passed null value for ID attribute.
public String getId(@PathVariable("id") long id)
so while making the feign request, url path variable attribute is not getting replaced with pathVariable(ID) rather then replacing the actual id value.
When id as null ->  http://SomeService/{id}
When id as proper value  -> id = 123 ->http://SomeService/123.
Correct me, if am wrong.
Thanks


Hi

Thnx for sharing

It's not clear what this pull request is attempting to do, given that there's no description and it includes hundreds of unrelated commits. If you are attempting to provide a fix/feature/etc. please submit a PR containing only the relevant changes and a description of what the changes do. Thanks!


No sure if my S3 blobstore is working

When I ran
flynn -a blobstore run /bin/flynn-blobstore migrate --delete

it hangs on
2016/09/29 19:07:29 Configured additional backend: s3main (s3)
2016/09/29 19:07:29 Blobstore serving files on :

and my bucket is empty so I'm assuming it hasn't worked

Did you run flynn -a blobstore env set DEFAULT_BACKEND=s3main?

yes

Oh, the docs are wrong. Change flynn-blobstore migrate to flynn-blobstore-migrate.

That command syntax is for a recent flynn version. Which version do you
have?
On Thu, 29 Sep 2016 at 20:23, Jonathan Rudenberg<EMAIL_ADDRESS>wrote:

Did you run flynn -a blobstore env set DEFAULT_BACKEND=s3main?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/flynn/flynn/issues/3444#issuecomment-250565640, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AC8i3FvDPHPi_sf7YnXnIqtGA4_fbzt5ks5qvBAhgaJpZM4KKXv9
.

That's processing now.

@titanous they are in sync with master. The blobstore commands were merged
into a single binary.
On Thu, 29 Sep 2016 at 20:25, Jorge Ferreira<EMAIL_ADDRESS>wrote:

That command syntax is for a recent flynn version. Which version do you
have?
On Thu, 29 Sep 2016 at 20:23, Jonathan Rudenberg<EMAIL_ADDRESS>wrote:

Did you run flynn -a blobstore env set DEFAULT_BACKEND=s3main?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/flynn/flynn/issues/3444#issuecomment-250565640, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AC8i3FvDPHPi_sf7YnXnIqtGA4_fbzt5ks5qvBAhgaJpZM4KKXv9
.

And, on the version you are using it is probably -delete and not --delete.
If that is true you may nees to run flynn-blobstore-cleanup afterwards to
remove blobs from postgres+(maybe)vacuum.
On Thu, 29 Sep 2016 at 20:27, Marcus Williams<EMAIL_ADDRESS>wrote:

That's processing now.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/flynn/flynn/issues/3444#issuecomment-250566532, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AC8i3OQHzIa39sg33S8WiZPI6eBwZ_niks5qvBEEgaJpZM4KKXv9
.

i'm using v20160811.0
How do I do the vacuum thing?

VACUUM requires double the disk space, so about ~12GB of free space max. Once that is free on all hosts:
flynn -a blobstore pg psql

VACUUM FULL;

what's the full flynn-blobstore-cleanup command

These are my zfs lists so will it be ok to vacuum as it won't let me delete all the volumes
NAME                                                 USED  AVAIL  REFER  MOUNTPOINT
flynn-default                                       23.4G  15.1G    19K  /flynn-default
flynn-default/5025e2ad-f8c9-4a63-982f-febdb7bdd606  6.78M  15.1G  6.78M  /var/lib/flynn/volumes/zfs/mnt/5025e2ad-f8c9-4a63-982f-febdb7bdd606
flynn-default/9350cdbc-2ef8-4a32-9ac0-535ce15e11ba    20K  15.1G    20K  /var/lib/flynn/volumes/zfs/mnt/9350cdbc-2ef8-4a32-9ac0-535ce15e11ba
flynn-default/baa99605-36b9-41a6-8b24-aac41ee36689  23.4G  15.1G  12.9G  /var/lib/flynn/volumes/zfs/mnt/baa99605-36b9-41a6-8b24-aac41ee36689
flynn-default/e93dce10-841f-4a0a-b3cf-431c86739502    20K  15.1G    20K  /var/lib/flynn/volumes/zfs/mnt/e93dce10-841f-4a0a-b3cf-431c86739502
flynn-default/pg-restore                             280K  15.1G  10.5G  /var/lib/flynn/volumes/zfs/mnt/pg-restore

flynn-default                                       25.4G  13.1G    19K  /flynn-default
flynn-default/111cc540-8349-4646-8461-cf0492a40ac9  12.6G  13.1G  12.6G  /var/lib/flynn/volumes/zfs/mnt/111cc540-8349-4646-8461-cf0492a40ac9
flynn-default/31dcf0a7-0eb7-43f7-b28f-75fad1e8fbb0  12.8G  13.1G  12.8G  /var/lib/flynn/volumes/zfs/mnt/31dcf0a7-0eb7-43f7-b28f-75fad1e8fbb0
flynn-default/d0f49986-9817-4dca-8430-0cebd444fa35  6.78M  13.1G  6.78M  /var/lib/flynn/volumes/zfs/mnt/d0f49986-9817-4dca-8430-0cebd444fa35

NAME                                                 USED  AVAIL  REFER  MOUNTPOINT
flynn-default                                       26.4G  12.1G    19K  /flynn-default
flynn-default/0de857d0-ce2b-437e-a44a-30ee90976dec  6.53M  12.1G  6.53M  /var/lib/flynn/volumes/zfs/mnt/0de857d0-ce2b-437e-a44a-30ee90976dec
flynn-default/597a3da4-38ad-49fa-9fa1-74bb102ed993  13.5G  12.1G  13.5G  /var/lib/flynn/volumes/zfs/mnt/597a3da4-38ad-49fa-9fa1-74bb102ed993
flynn-default/6ded61a1-9bbf-460f-b455-6f0300dd419c    20K  12.1G    20K  /var/lib/flynn/volumes/zfs/mnt/6ded61a1-9bbf-460f-b455-6f0300dd419c
flynn-default/bc5a7299-6b84-4a78-a352-6a19e15ab57d  12.9G  12.1G  12.9G  /var/lib/flynn/volumes/zfs/mnt/bc5a7299-6b84-4a78-a352-6a19e15ab57d

flynn -a blobstore run /bin/flynn-blobstore-migrate -delete

That will probably be fine, though the third one might be tight.

@titanous we should do something to make clear what Flynn version the docs are targeting, to avoid future confusion like this. Granted that, if it had originally used docopt it would caught the "invalid syntax".

Either way, could be new commands/syntax and the user may be confused why it is not working either.

So it's ok for me to run
flynn -a blobstore run /bin/flynn-blobstore-migrate -delete

even though I've already run
flynn -a blobstore run /bin/flynn-blobstore-migrate --delete

It won't do anything. Try:
flynn -a blobstore run /bin/flynn-blobstore-cleanup

@dottodot also. These are the relevant docs for your Flynn version

flynn -a blobstore run /bin/flynn-blobstore-cleanup gives the error
exec: "/bin/flynn-blobstore-cleanup": stat /bin/flynn-blobstore-cleanup: no such file or directory

This will accomplish the same thing:
flynn -a blobstore pg psql -- -c "UPDATE files SET file_oid = NULL WHERE external_id IS NOT NULL"

One last thing, when I ran VACUUM FULL; the result was
WARNING:  skipping "pg_authid" --- only superuser can vacuum it
WARNING:  skipping "pg_database" --- only superuser can vacuum it
WARNING:  skipping "pg_db_role_setting" --- only superuser can vacuum it
WARNING:  skipping "pg_tablespace" --- only superuser can vacuum it
WARNING:  skipping "pg_pltemplate" --- only superuser can vacuum it
WARNING:  skipping "pg_auth_members" --- only superuser can vacuum it
WARNING:  skipping "pg_shdepend" --- only superuser can vacuum it
WARNING:  skipping "pg_shdescription" --- only superuser can vacuum it
WARNING:  skipping "pg_replication_origin" --- only superuser can vacuum it
WARNING:  skipping "pg_shseclabel" --- only superuser can vacuum it

so not sure if it was completely successful

I think it should be fine to run from the blobstore user, if not you can re-execute it as the flynn user with flynn -a postgres pg psql -- -c "VACUUM FULL"


Rescaling Attention values experiments/different implementations

Would be good to experiment with rescaling attention values, say with full attention as well to see if you can prove something about how the attention values may be what causes training instability (the current theory is that large language models can easily be pushed into local minima that are hard to break out of when the attention values get too big before being softmax-ed). Like maybe the experiment would be, use large dimensions, and to save on memory, only use a single head and only a single layer of multihead attention (with feed forward layers after it) with comically small sequence lengths (of like 4) and small batch sizes (also use no dropout to stop regularization). Consider also only using a subset of wikitext-2. Show how larger dimensions make effect worse. Measure the pre-softmax values and see if they get larger over time.
Would also be good to see if you can try a different implementation of rescaling for LEAP could work better since it's still oddly unstable for how strongly scaled it should be.

The current rescaling seems to be good now after figuring out that there need to be normalization terms in the denominator. Only currently need to work on experiments that validate the rescaling

Closing this issues as the rescaling implementation makes sense and now only experiments/measurements are needed which is addressed in #17


Permit use of random seeds

one very important thing we need on the simulator is the possibility of running EXACTLY the same run again.  This means we have to have some way of storing the random number generator seed.  And of inserting it to make the program run a particular way.
So you run the program with random settings.  You get a very nice run that illustrates some point (that you want to use during a class, for example).  You click: "Save seed for this run" and it saves it to some file.
Next time you run the program you can either just run it normally or call the file with the saved seed in it.  That is how I do it in all of my code.

This site has some useful discussion of this issue
http://davidbau.com/archives/2010/01/30/random_seeds_coded_hints_and_quintillions.html


About us

Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after):
Fix #102
Test URLs:

Before: https://main--moleculardevices--hlxsites.hlx.page/about-us
After: https://about-us--moleculardevices--hlxsites.hlx.page/about-us

@dev-rajneeshkumar I have some first observation from a first look at code changes and comparing with original

hero adjustments https://github.com/hlxsites/moleculardevices/pull/196
original doesn't have H1, can it be removed from the content?
who we are: is list of images already used in other content? is list required or can it be just images one after the other?
why is class background green? is it used?
who we are: the vidyard changes are breaking existing vidyard content
-- https://about-us--moleculardevices--hlxsites.hlx.page/en/assets/tutorials-videos/how-to-update-user-preferences-for-email-communications-in-spectranet
-- https://videoplayer--moleculardevices--hlxsites.hlx.page/en/assets/tutorials-videos/how-to-update-user-preferences-for-- email-communications-in-spectranet
the cards gallery grid: gap is smaller than original
last section: fortune 500 image is smaller than original
last section: brand logos are larger than original and more distant one another

@dev-rajneeshkumar in small screen the free content heading look bigger in franklin than original see screenshots


Kotlin: Update all HTTPUrl.parse -> get (no bang bang required)

Closing. Stale, and missing detail.


fix: Re-raise deposit error outside of refund try block.

What was changed

Two changes:

Where the deposit error is raised
Showing the refund error being raised from the deposit error

Why?

Currently, the deposit error gets raised within the try block of the refund attempt such that even though we end up with a successful refund (you can confirm by viewing INFO level logs), we get a log message showing that the refund failed even though it didn't, it was just the deposit that failed.
Checklist

Closes
N/A
How was this tested:

Tested manually by running the deposit activity calling self.bank.deposit_that_fails and observing that we no longer get a  log message showing Refund failed...
Existing unit tests still pass

Any docs updates needed?
N/A

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.