Mapillary images don't load with Firefox extension "Facebook Container"

URL
Any edit URL. For the screenshots below, I'm using this: https://www.openstreetmap.org/edit?node=249204043#map=19/16.67432/-22.93507
How to reproduce the issue?

Open iD using Firefox with the Facebook Container add-on installed
Enable the Mapillary photo overlay
Click on one of the images

Screenshot(s) or anything else?
Without the Facebook Container add-on:

With the Facebook Container add-on activated:

Console output (screenshot):

Console output (text):
Cross-Origin Request Blocked: The Same Origin Policy disallows reading the remote resource at https://scontent.fopo3-2.fna.fbcdn.net/m1/v/t6/An-U86xHpUOP3dRXoMUlYUuH7AwL8bUOW2gwzVapBXhmfA0Jf8rjkBLeBarjxNKISQ6SBnCjK-3_qsoqWoshT4Fjv-4wa3Ro4x4HZib2jrAccEj0T0Re0NZaeWqWFnjWZFAOys2mHWFnIPOXQ-1wb10?stp=s1024x576&ccb=10-5&oh=00_AT_S83TVp067ib6CIEhRMt9NVHo-FVT1KTEOw50qhjEqSw&oe=62E0E78C&_nc_sid=122ab1. (Reason: CORS request did not succeed). Status code: (null).

Failed to cache image<PHONE_NUMBER>83807). MapillaryError: Request error: https://scontent.fopo3-2.fna.fbcdn.net/m1/v/t6/An-U86xHpUOP3…b6CIEhRMt9NVHo-FVT1KTEOw50qhjEqSw&oe=62E0E78C&_nc_sid=122ab1
    Fm             https://www.openstreetmap.org/assets/iD/mapillary-js/mapillary-1851af74bdd0596f9d1648cf72b9bd18d8a97d492b91c9c82dfb22f589dee90f.js:38
    onerror        https://www.openstreetmap.org/assets/iD/mapillary-js/mapillary-1851af74bdd0596f9d1648cf72b9bd18d8a97d492b91c9c82dfb22f589dee90f.js:21
    o              https://www.openstreetmap.org/assets/iD/mapillary-js/mapillary-1851af74bdd0596f9d1648cf72b9bd18d8a97d492b91c9c82dfb22f589dee90f.js:21
    oo             https://www.openstreetmap.org/assets/iD/mapillary-js/mapillary-1851af74bdd0596f9d1648cf72b9bd18d8a97d492b91c9c82dfb22f589dee90f.js:21
    ao             https://www.openstreetmap.org/assets/iD/mapillary-js/mapillary-1851af74bdd0596f9d1648cf72b9bd18d8a97d492b91c9c82dfb22f589dee90f.js:21
    getImageBuffer https://www.openstreetmap.org/assets/iD/mapillary-js/mapillary-1851af74bdd0596f9d1648cf72b9bd18d8a97d492b91c9c82dfb22f589dee90f.js:57
https://www.openstreetmap.org/assets/iD/mapillary-js/mapillary-1851af74bdd0596f9d1648cf72b9bd18d8a97d492b91c9c82dfb22f589dee90f.js:59:9232

mly3 MapillaryError: Request error: https://scontent.fopo3-2.fna.fbcdn.net/m1/v/t6/An-U86xHpUOP3…b6CIEhRMt9NVHo-FVT1KTEOw50qhjEqSw&oe=62E0E78C&_nc_sid=122ab1
    Fm             https://www.openstreetmap.org/assets/iD/mapillary-js/mapillary-1851af74bdd0596f9d1648cf72b9bd18d8a97d492b91c9c82dfb22f589dee90f.js:38
    onerror        https://www.openstreetmap.org/assets/iD/mapillary-js/mapillary-1851af74bdd0596f9d1648cf72b9bd18d8a97d492b91c9c82dfb22f589dee90f.js:21
    o              https://www.openstreetmap.org/assets/iD/mapillary-js/mapillary-1851af74bdd0596f9d1648cf72b9bd18d8a97d492b91c9c82dfb22f589dee90f.js:21
    oo             https://www.openstreetmap.org/assets/iD/mapillary-js/mapillary-1851af74bdd0596f9d1648cf72b9bd18d8a97d492b91c9c82dfb22f589dee90f.js:21
    ao             https://www.openstreetmap.org/assets/iD/mapillary-js/mapillary-1851af74bdd0596f9d1648cf72b9bd18d8a97d492b91c9c82dfb22f589dee90f.js:21
    getImageBuffer https://www.openstreetmap.org/assets/iD/mapillary-js/mapillary-1851af74bdd0596f9d1648cf72b9bd18d8a97d492b91c9c82dfb22f589dee90f.js:57
https://www.openstreetmap.org/assets/iD/mapillary-js/id-0ac2d4ce47c510bb7126ddaaff5ce431b29900dd9c2a7c83badd8a7be7e7d453.js:61:27062

MapillaryError: Request error: https://scontent.fopo3-2.fna.fbcdn.net/m1/v/t0.40361-6/An9Kj…F0qm70jYAjMkG347v65xa9K19887xYqXQ&oe=62E07E43&_nc_sid=d122da
    Fm             https://www.openstreetmap.org/assets/iD/mapillary-js/mapillary-1851af74bdd0596f9d1648cf72b9bd18d8a97d492b91c9c82dfb22f589dee90f.js:38
    onerror        https://www.openstreetmap.org/assets/iD/mapillary-js/mapillary-1851af74bdd0596f9d1648cf72b9bd18d8a97d492b91c9c82dfb22f589dee90f.js:21
    o              https://www.openstreetmap.org/assets/iD/mapillary-js/mapillary-1851af74bdd0596f9d1648cf72b9bd18d8a97d492b91c9c82dfb22f589dee90f.js:21
    oo             https://www.openstreetmap.org/assets/iD/mapillary-js/mapillary-1851af74bdd0596f9d1648cf72b9bd18d8a97d492b91c9c82dfb22f589dee90f.js:21
    ao             https://www.openstreetmap.org/assets/iD/mapillary-js/mapillary-1851af74bdd0596f9d1648cf72b9bd18d8a97d492b91c9c82dfb22f589dee90f.js:21
    getMesh        https://www.openstreetmap.org/assets/iD/mapillary-js/mapillary-1851af74bdd0596f9d1648cf72b9bd18d8a97d492b91c9c82dfb22f589dee90f.js:57
https://www.openstreetmap.org/assets/iD/mapillary-js/mapillary-1851af74bdd0596f9d1648cf72b9bd18d8a97d492b91c9c82dfb22f589dee90f.js:38:18468

Cross-Origin Request Blocked: The Same Origin Policy disallows reading the remote resource at https://scontent.fopo3-2.fna.fbcdn.net/m1/v/t0.40361-6/An9KjyDnlwxnx_08Z8s_pITqsht29Pa8i7dh2HFkLEWvFLPsoqip9_5c--dIP2seH60eDp13izil3k-l_oNADgfwXvo78h2OYAF6c83ybKyJUoISSZtHNtnCpI8fowzEBFU?ccb=10-5&oh=00_AT_QZneIfA94ZF0qm70jYAjMkG347v65xa9K19887xYqXQ&oe=62E07E43&_nc_sid=d122da. (Reason: CORS request did not succeed). Status code: (null).

Cross-Origin Request Blocked: The Same Origin Policy disallows reading the remote resource at https://scontent.fopo3-2.fna.fbcdn.net/m1/v/t6/An-U86xHpUOP3dRXoMUlYUuH7AwL8bUOW2gwzVapBXhmfA0Jf8rjkBLeBarjxNKISQ6SBnCjK-3_qsoqWoshT4Fjv-4wa3Ro4x4HZib2jrAccEj0T0Re0NZaeWqWFnjWZFAOys2mHWFnIPOXQ-1wb10?stp=s1024x576&ccb=10-5&oh=00_AT_S83TVp067ib6CIEhRMt9NVHo-FVT1KTEOw50qhjEqSw&oe=62E0E78C&_nc_sid=122ab1. (Reason: CORS request did not succeed). Status code: (null).

Failed to cache image<PHONE_NUMBER>83807). MapillaryError: Request error: https://scontent.fopo3-2.fna.fbcdn.net/m1/v/t6/An-U86xHpUOP3…b6CIEhRMt9NVHo-FVT1KTEOw50qhjEqSw&oe=62E0E78C&_nc_sid=122ab1
    Fm             https://www.openstreetmap.org/assets/iD/mapillary-js/mapillary-1851af74bdd0596f9d1648cf72b9bd18d8a97d492b91c9c82dfb22f589dee90f.js:38
    onerror        https://www.openstreetmap.org/assets/iD/mapillary-js/mapillary-1851af74bdd0596f9d1648cf72b9bd18d8a97d492b91c9c82dfb22f589dee90f.js:21
    o              https://www.openstreetmap.org/assets/iD/mapillary-js/mapillary-1851af74bdd0596f9d1648cf72b9bd18d8a97d492b91c9c82dfb22f589dee90f.js:21
    oo             https://www.openstreetmap.org/assets/iD/mapillary-js/mapillary-1851af74bdd0596f9d1648cf72b9bd18d8a97d492b91c9c82dfb22f589dee90f.js:21
    ao             https://www.openstreetmap.org/assets/iD/mapillary-js/mapillary-1851af74bdd0596f9d1648cf72b9bd18d8a97d492b91c9c82dfb22f589dee90f.js:21
    getImageBuffer https://www.openstreetmap.org/assets/iD/mapillary-js/mapillary-1851af74bdd0596f9d1648cf72b9bd18d8a97d492b91c9c82dfb22f589dee90f.js:57
https://www.openstreetmap.org/assets/iD/mapillary-js/mapillary-1851af74bdd0596f9d1648cf72b9bd18d8a97d492b91c9c82dfb22f589dee90f.js:59:9232

MapillaryError: Request error: https://scontent.fopo3-2.fna.fbcdn.net/m1/v/t0.40361-6/An9Kj…F0qm70jYAjMkG347v65xa9K19887xYqXQ&oe=62E07E43&_nc_sid=d122da
    Fm             https://www.openstreetmap.org/assets/iD/mapillary-js/mapillary-1851af74bdd0596f9d1648cf72b9bd18d8a97d492b91c9c82dfb22f589dee90f.js:38
    onerror        https://www.openstreetmap.org/assets/iD/mapillary-js/mapillary-1851af74bdd0596f9d1648cf72b9bd18d8a97d492b91c9c82dfb22f589dee90f.js:21
    o              https://www.openstreetmap.org/assets/iD/mapillary-js/mapillary-1851af74bdd0596f9d1648cf72b9bd18d8a97d492b91c9c82dfb22f589dee90f.js:21
    oo             https://www.openstreetmap.org/assets/iD/mapillary-js/mapillary-1851af74bdd0596f9d1648cf72b9bd18d8a97d492b91c9c82dfb22f589dee90f.js:21
    ao             https://www.openstreetmap.org/assets/iD/mapillary-js/mapillary-1851af74bdd0596f9d1648cf72b9bd18d8a97d492b91c9c82dfb22f589dee90f.js:21
    getMesh        https://www.openstreetmap.org/assets/iD/mapillary-js/mapillary-1851af74bdd0596f9d1648cf72b9bd18d8a97d492b91c9c82dfb22f589dee90f.js:57
https://www.openstreetmap.org/assets/iD/mapillary-js/mapillary-1851af74bdd0596f9d1648cf72b9bd18d8a97d492b91c9c82dfb22f589dee90f.js:38:18468

Cross-Origin Request Blocked: The Same Origin Policy disallows reading the remote resource at https://scontent.fopo3-2.fna.fbcdn.net/m1/v/t0.40361-6/An9KjyDnlwxnx_08Z8s_pITqsht29Pa8i7dh2HFkLEWvFLPsoqip9_5c--dIP2seH60eDp13izil3k-l_oNADgfwXvo78h2OYAF6c83ybKyJUoISSZtHNtnCpI8fowzEBFU?ccb=10-5&oh=00_AT_QZneIfA94ZF0qm70jYAjMkG347v65xa9K19887xYqXQ&oe=62E07E43&_nc_sid=d122da. (Reason: CORS request did not succeed). Status code: (null).

Uncaught (in promise) MapillaryError: Request error: https://scontent.fopo3-2.fna.fbcdn.net/m1/v/t6/An-U86xHpUOP3…b6CIEhRMt9NVHo-FVT1KTEOw50qhjEqSw&oe=62E0E78C&_nc_sid=122ab1
    Fm             https://www.openstreetmap.org/assets/iD/mapillary-js/mapillary-1851af74bdd0596f9d1648cf72b9bd18d8a97d492b91c9c82dfb22f589dee90f.js:38
    onerror        https://www.openstreetmap.org/assets/iD/mapillary-js/mapillary-1851af74bdd0596f9d1648cf72b9bd18d8a97d492b91c9c82dfb22f589dee90f.js:21
    o              https://www.openstreetmap.org/assets/iD/mapillary-js/mapillary-1851af74bdd0596f9d1648cf72b9bd18d8a97d492b91c9c82dfb22f589dee90f.js:21
    oo             https://www.openstreetmap.org/assets/iD/mapillary-js/mapillary-1851af74bdd0596f9d1648cf72b9bd18d8a97d492b91c9c82dfb22f589dee90f.js:21
    ao             https://www.openstreetmap.org/assets/iD/mapillary-js/mapillary-1851af74bdd0596f9d1648cf72b9bd18d8a97d492b91c9c82dfb22f589dee90f.js:21
    getImageBuffer https://www.openstreetmap.org/assets/iD/mapillary-js/mapillary-1851af74bdd0596f9d1648cf72b9bd18d8a97d492b91c9c82dfb22f589dee90f.js:57
https://www.openstreetmap.org/assets/iD/mapillary-js/mapillary-1851af74bdd0596f9d1648cf72b9bd18d8a97d492b91c9c82dfb22f589dee90f.js:38:22440

Which deployed environments do you see the issue in?
Released version at openstreetmap.org/edit
What version numbers does this issue effect?
2.21.1
Which browsers are you seeing this problem on?
Firefox

For now, I've disabled the extension, as it seems it may not be needed anymore (although the fact that this bug doesn't occur without the extension shows that it's doing more than the default protections).

This is not a bug, is it?
I think it can be closed and keep it as a FYI for others that may search for that issue.

Yeah, this is not iD's fault. That said, I was wondering whether iD would want to implement the Mapillary functionality in a way that wouldn't be affected by this browser extension (assuming that's even technically possible), or at least guard for this case in the code and provide a more legible error in the browser console (or even better, in the interface) so that people with this issue can know how to resolve it.


Get X11 support working on AMI

Migrated from rnabio.org proposed improvements page
For R and other applications it would be nice if X11 worked. Note the install instructions for R would need to change as well.

This is arguably deprecated by better approaches.  RStudio on the AWS instance would work.  Apache Guacamole would also work.

It's fairly easy to run RStudio on AWS now - see here: https://towardsdatascience.com/how-to-run-rstudio-on-aws-in-under-3-minutes-for-free-65f8d0b6ccda. Closing this issue for now.


Fail to get cluster from orchestrator: [orc]: status: 500 msg: at error, json unmarshal error:

HI @AMecea Please find below a snippet form de operator log:
E1116 10:17:45.075107       1 orc_reconciliation.go:57] Fail to get cluster from orchestrator: [orc]: status: 500 msg: at error, json unmarshal error: unexpected end of JSON input, details: <nil>. Now tries to register nodes.
I1116 10:17:48.713580       1 orc_reconciliation.go:40] Orchestrator reconciliation for cluster 'ain-production-cluster' started...
W1116 10:17:48.842026       1 orc_reconciliation.go:318] [getRecoveriesToAck]: Cluster is not ready for ack.
I1116 10:17:48.874770       1 utils.go:173] Endpoints for service 'ain-production-cluster-mysql' were up-to-date.
I1116 10:17:50.084302       1 orc_reconciliation.go:40] Orchestrator reconciliation for cluster 'dev-cluster' started...
E1116 10:17:50.093512       1 orc_reconciliation.go:57] Fail to get cluster from orchestrator: [orc]: status: 500 msg: at error, json unmarshal error: unexpected end of JSON input, details: <nil>. Now tries to register nodes.
I1116 10:17:53.882722       1 orc_reconciliation.go:40] Orchestrator reconciliation for cluster 'ain-production-cluster' started...
W1116 10:17:54.029847       1 orc_reconciliation.go:318] [getRecoveriesToAck]: Cluster is not ready for ack.

This message is repeating over and over
Any idea's
thx

Hi @HBO2 , what version of Kubernetes do you use?

Hi @AMecea
Azure AKS 11.3

The version 0.1.13 of the operator does not work ok kubernetes 1.11.3, we are almost ready with releasing v0.2.0 which will work on k8s 1.11.x and will solve this issue.
The problem with k8s 1.11 is because of the subresources that are enabled by default and the cluster status is marked as subresource so it won't get updates. If the status is not updated the nodes does not register into orchestrator.

:smile: Hopefully the version 0.2.0 will be released this week.

fixed by #102


testadd new pg case from other source

Proposed changes
Issue Number: close #xxx
Problem summary
Describe your changes.
Checklist(Required)

Does it affect the original behavior:

[ ] Yes
[x] No
[ ] I don't know

Has unit tests been added:

[y] Yes
[ ] No
[ ] No Need

Has document been added or modified:

[ ] Yes
[x] No
[ ] No Need

Does it need to update dependencies:

[ ] Yes
[x] No

Are there any changes that cannot be rolled back:

[ ] Yes (If Yes, please explain WHY)
[x] No

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 35.34 seconds
load time: 433 seconds
storage size:<PHONE_NUMBER>6 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20221122063139_clickbench_pr_50464.html


refactor: change the arguments of "set_rotation" in sensor and transform

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

18 of 18 (100.0%)  changed or added relevant lines in 4 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.02%) to 82.926%

Totals

Change from base Build<PHONE_NUMBER>:
0.02%

Covered Lines:
5289

Relevant Lines:
6378

💛  - Coveralls


subs auto select/start

hello, how can i make subs auto start here is my code but not working, its working only if i choose manual the subs.
`

will i  get answer?

Please check documentation https://github.com/webtor-io/embed-sdk-js#subtitle-configuration


Unable to reference built-in constants with bundler 1.14.5

My app is using a gem http-exceptions
It's referencing some built-in constants like SocketError or Net
I test by running bundle exec rspec inside that project.
1.14.5 failed, 1.14.4 works.

Please follow ISSUES.md so that we can better help diagnose your problem.

Sorry I forgot read
Maybe it's good to have github issue template too
Anyway updated description following ISSUES.md

Did you ever require anything that defines SocketError?

I solved by requiring those standard libraries.
Just don't quite understand why it works before


Split Consume Endpoints and Webhook Subscriptions

#399  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @acco and the rest of your teammates on  Graphite


task 827-828 : copa

task 827-828 using copa

One minor suggestion; otherwise, looks good! Leaving it for @swarooprm to review.


Clarify "unbound" generic types

With C# adding nameof support for unbound generic types, it'd be good to explain what unbound means in this doc.
cc @CyrusNajmabadi

Link to proposal if you want it: https://github.com/dotnet/csharplang/blob/main/proposals/unbound-generic-types-in-nameof.md


Mod names case change

Describe the bug
previously had mods/chunk.lua
now have mods/Chunk/init.lua
same with other mods except indent
need to update readme to reflect new casing (s/chunk/Chunk) in setup options:
require('hlchunk').setup({ Blank = { enable = true }, Chunk = {...} })

yes, readme should be updated, but previous config should work properly, uppercase is not needed (for me at least...)

it would probably be filesystem dependent, whatever your harddrive is formatted to use

typical mac filesystems support HFS and applefs case-sensitive AND case-insensitive
typical windows is ntfs which is case-insensitive
most linux users would be on case sensitive filesystem

very thanks for your reminder!!! I can't imagine how many user has been affected. I will update the document as soon as possible.

To go along with @davidosomething previous comment, the plugin crash on my case-sensitive file system:
Error detected while processing ColorScheme Autocommands for "*"..ColorScheme Autocommands for "*":
Error executing lua callback: .../nvim/lazy/hlchunk.nvim/lua/hlchunk/mods/indent/init.lua:2: module 'hlchunk.mods.Indent.IndentConf' not found

Resolved with:
diff --git a/lua/hlchunk/mods/indent/init.lua b/lua/hlchunk/mods/indent/init.lua
index 0bf83cc..319942e 100644
--- a/lua/hlchunk/mods/indent/init.lua
+++ b/lua/hlchunk/mods/indent/init.lua
@@ -1,5 +1,5 @@
 local BaseMod = require("hlchunk.mods.BaseMod")
-local IndentConf = require("hlchunk.mods.Indent.IndentConf")
+local IndentConf = require("hlchunk.mods.indent.IndentConf")
 local class = require("hlchunk.utils.class")
 local utils = require("hlchunk.utils.utils")
 local indentHelper = require("hlchunk.utils.indentHelper")

IMO, dealing with uppercase for file/folder structure is error prone...

@davidosomething @soifou Thank you very much for suggestions. I have temporarily resolved this issue by changing the directory name (and file name).
It has been more than a year since I started writing this plugin. It was originally created for learning Neovim plugin development, and the code quality was very poor at the beginning, and it is still so now, I have made many bad design decisions. Thank you for being able to tolerate and point out the mistakes I have made 🙏.
There are still many problems with this plugin, now working hard to solve them~

Thanks for addressing this quick @shellRaining
I can confirm the plugin was broken on my Linux machine since yesterday.
Pulling latest patch fixed it https://github.com/shellRaining/hlchunk.nvim/commit/8aef948eeb0d2a4b32f911e93c7c33e04057cc20


Re-export unsafeHTML from lit-html

Is there any particular reason unsafeHTML isn't re-exported? When using lit-elem, I shouldn't have to worry about how to import something from lit-html, because as far as I'm concerned I'm only using a single package.
What I'd like to work:
import { unsafeHTML } from '@polymer/lit-element;
Expected Results
A successful import.
Actual Results
Import is not found, and must be manually imported via a lit-html.
Versions

lit-element: v0.6.3

Directives from lit-html aren't exported from lit-element.js or lit-html.js itself. They're supposed to be imported if you use them, to keep bundle/network bytes size down.

How to do that? I'm confused.

There's an example import in the docs: https://lit.dev/docs/templates/directives/#unsafehtml
import {unsafeHTML} from 'lit/directives/unsafe-html.js';

Also, we should be using the issue tracker here: https://github.com/lit/lit/issues This repo is deprecated.

In my case, the issue was that I needed to leave out the file ending. Could be related to the default eslint bundler or something.
import {unsafeHTML} from 'lit/directives/unsafe-html.js'; ==> import {unsafeHTML} from 'lit/directives/unsafe-html';
Something like this, I can't remember exactlyt. Was in a TS project.


[TEST] Use Rocky Linux 8 and vcpkg to build RPM packages

ERROR: failed to solve: dockerfile parse error on line 45: unknown instruction: dnf (did you mean env?)

TODO: Dockerfile does not support dnf command

Verified the binaries here in redhat/ubi-8 image.
[root@b4275a81134a ~]# gcc --version
gcc (GCC) 8.5.0 20210514 (Red Hat 8.5.0-22)
Copyright (C) 2018 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

[root@b4275a81134a ~]# cat /etc/redhat-release
Red Hat Enterprise Linux release 8.10 (Ootpa)
[root@b4275a81134a ~]# g++ helloworld.cpp /usr/lib/libpulsarwithdeps.a -ldl -pthread
[root@b4275a81134a ~]# g++ helloworld.cpp -lpulsar


merge from arlac77/npm-package-template

package.json

chore(scripts): cover@#overwrite c8 -x 'tests/**/*' --temp-directory build/tmp ava && c8 report -r lcov -o build/coverage --temp-directory build/tmp
chore(package): add main from template
chore(package): set $.ava.require='esm' as in template
chore(package): set $.ava.files='tests/*-test.mjs' as in template
chore(package): set $.ava.extensions='mjs' as in template
chore(package): remove unknown value for main ({{main}})

Pull Request Test Coverage Report for Build 2252

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 96.509%

Totals

Change from base Build 2249:
0.0%

Covered Lines:
361

Relevant Lines:
375

💛  - Coveralls


Code Cleanup

Lots of code could probably be cleaned up. Mainly in the StatBoostMgr.cpp file.

The return statements within each case already cause execution to exit the switch and return the corresponding value. Therefore, no additional break statements are needed in this case. Cleaned up the code a bit.
StatBoostMgr::StatType StatBoostMgr::GetStatTypeFromSubClass(Item* item)
{
const ItemTemplate* itemTemplate = item->GetTemplate();
if (itemTemplate->Class == ITEM_CLASS_WEAPON)
{
switch (itemTemplate->SubClass)
{
case ITEM_SUBCLASS_WEAPON_MACE2:
case ITEM_SUBCLASS_WEAPON_POLEARM:
case ITEM_SUBCLASS_WEAPON_SPEAR:
case ITEM_SUBCLASS_WEAPON_GUN:
case ITEM_SUBCLASS_WEAPON_BOW:
case ITEM_SUBCLASS_WEAPON_CROSSBOW:
{
int random = urand(0, 2);
return (random == 0) ? STAT_TYPE_TANK :
(random == 1) ? STAT_TYPE_PHYS :
STAT_TYPE_HYBRID;
}
case ITEM_SUBCLASS_WEAPON_THROWN:
return STAT_TYPE_PHYS;
case ITEM_SUBCLASS_WEAPON_DAGGER:
{
int random = urand(0, 2);
return (random == 0) ? STAT_TYPE_PHYS :
(random == 1) ? STAT_TYPE_HYBRID :
STAT_TYPE_SPELL;
}
case ITEM_SUBCLASS_WEAPON_STAFF:
{
int random = urand(0, 3);
return (random == 0) ? STAT_TYPE_TANK :
(random == 1) ? STAT_TYPE_PHYS :
(random == 2) ? STAT_TYPE_HYBRID :
STAT_TYPE_SPELL;
}
case ITEM_SUBCLASS_WEAPON_AXE:
case ITEM_SUBCLASS_WEAPON_AXE2:
case ITEM_SUBCLASS_WEAPON_MACE:
case ITEM_SUBCLASS_WEAPON_SWORD:
case ITEM_SUBCLASS_WEAPON_SWORD2:
case ITEM_SUBCLASS_WEAPON_FIST:
{
int random = urand(0, 1);
return (random == 0) ? STAT_TYPE_TANK :
STAT_TYPE_PHYS;
}
case ITEM_SUBCLASS_WEAPON_WAND:
return STAT_TYPE_SPELL;
}
}
else if (itemTemplate->Class == ITEM_CLASS_ARMOR)
{
switch (itemTemplate->SubClass)
{
case ITEM_SUBCLASS_ARMOR_CLOTH:
{
switch (itemTemplate->InventoryType)
{
case INVTYPE_CLOAK:
{
int random = urand(0, 3);
return (random == 0) ? STAT_TYPE_TANK :
(random == 1) ? STAT_TYPE_PHYS :
(random == 2) ? STAT_TYPE_HYBRID :
STAT_TYPE_SPELL;
}
default:
return STAT_TYPE_SPELL;
}
}
case ITEM_SUBCLASS_ARMOR_LEATHER:
case ITEM_SUBCLASS_ARMOR_MAIL:
case ITEM_SUBCLASS_ARMOR_PLATE:
{
int random = urand(0, 3);
return (random == 0) ? STAT_TYPE_TANK :
(random == 1) ? STAT_TYPE_PHYS :
(random == 2) ? STAT_TYPE_HYBRID :
STAT_TYPE_SPELL;
}
case ITEM_SUBCLASS_ARMOR_BUCKLER:
case ITEM_SUBCLASS_ARMOR_SHIELD:
{
int random = urand(0, 1);
return (random == 0) ? STAT_TYPE_TANK :
STAT_TYPE_SPELL;
}
}
}
return STAT_TYPE_NONE;
}

You can open a PR and reference this issue if there are no logic errors.

Without the break statement, the flow of execution would continue through the subsequent cases without doing any additional checking. This is known as fall-through, and can lead to unexpected behavior and logic errors in your code. Then it would be necessary to add the break after each switch. Sorry for the mistake, I'm learning :S

Without the break statement, the flow of execution would continue through the subsequent cases without doing any additional checking. This is known as fall-through, and can lead to unexpected behavior and logic errors in your code. Then it would be necessary to add the break after each switch. Sorry for the mistake, I'm learning :S

Just getting back to this but it's not problem. We are all learning and I bet you know a lot more now than you did when this was posted. :smile:

I am going to close this issue as it's not really an issue and will come naturally as I commit changes.


Translated into Ukrainian

I translated all the words that were available for translation into Ukrainian. But I still need to see how it will look in the application itself in order to finally approve the translation.

Thank you for the translations! I can merge this and submit an update to internal beta with your changes. You're part of the internal beta right? If so, you'd be able to test the changes before the broader public sees it.
How does that sound? If that's good to you, we can merge this and I can deploy the update

Thank you for the translations! I can merge this and submit an update to internal beta with your changes. You're part of the internal beta right? If so, you'd be able to test the changes before the broader public sees it.
How does that sound? If that's good to you, we can merge this and I can deploy the update

I don't know how it would be better, I translated it according to the context, but firstly, editing a raw file is different, I would like to see how it would look in the application, since the incorrect tense or case may appear there. Apparently, if we merge it, it will only be for the internal version for now, today I literally filled out the application + at the same time I think I will go over the grammar, I tried according to all the rules, but I still want to talk to other people how it would be better for them.

@Starik1500 I'm going to merge this and deploy an internal update. You can test the UI in ukrainian and then you can make additional updates after you do some testing.

The update is available to test. Please head to the Microsoft Store and get the latest internal beta update for beeskie, which is v0.6.16

Hi, I updated to 0.6.16, but I don't see interface language different from English, I have a pc with Ukrainian language and region, but English in Beesky. You can tell how to change, or it would be synchronization with language setting on pc?

Let me test it out myself.

@Starik1500 it's working for me

Here are my windows settings. Notice that UK is on the top for me and then I relaunched beeskie.

@Starik1500 if it's still not working for you, try uninstalling beeskie and reinstalling

Thank you, I didn't see that English set up first))

Great! If you want to make further improvements to your translations, feel free to create a new pull request to edit the file!
By the way, if you'd like to also provide translations to the Ukrainian Store page for Beeskie, just send me your translations here and I will update the store page. Here's how the page currently looks in Ukrainian: https://apps.microsoft.com/detail/9pcgnr7qhqgp?hl=uk-uk&gl=Uk

Yes, I have already tested and added a little editing. Translation of the text to the store, send it to your email?

Yep email sounds good


Progress Status Bar

Partly because of how Qt is implemented and partly because of how we use Qt, this code commits several atrocities. The consequences are then mitigated by more atrocities. In the end, however, it converges into something that seems to work.
The main issue is that the only way to get this to work is to manually processes Qt's event loop recursively. I later discovered that Qt does this itself on a few occasions (the Qt popup progress bar in the other PR works this way) however it has Band-Aid code in its backend implementation that prevents issues.
If it ends up being problematic it can all be disabled with one line of code. There is a way to do this without hacks, however the amount of refactoring required would warrant Vapor 4.
With regards to performance, it limits the number of updates to either 100 per calculation or a maximum of 10 progress updates per second, whichever is lower. In my testing, showing the progress bar adds about 5-10% overhead to the computation time when doing a simple calculation with many updates. This would be lower for a heavier calculation with a higher ratio of calculation to progress updates of course. Also, the progress bar is only updated when the user is actively using the application. When rendering a sequence of timesteps, it is disabled.
This PR implements progress bars for the Wireframe, Flow, and Volume renderers.
Some pitfalls:
It sometimes breaks the Fidelity radio buttons but those were always somewhat glitchy (they disappear and reappear on updates) and they are being replaced soon (from my understanding) so I didn't look into fixing it.
I almost had this working for everything, i.e. it would show progress for loading data from disk, populating histograms, etc. however I could not get Qt to behave consistently when doing this and this project was already taking way too long. It would sometimes correctly process the updates and sometimes it would claim to process them but not do anything. Therefore the progress bar is limited to code within the visualizer rendering which works consistently for some reason.

@stasj this is a really nice usability feature, but I have a couple of questions before starting a review:

You've submitted two PRs with alternate implementations of a progress bar; this one and #2316. What is the intent here?

You've made numerous caveats in the comments above concerning the robustness of this implementation. How confident are you in this code? Is it going to impact the reliability of the application?

@clyne

I just included the other PR for comparison. It uses Qt's built in functionality to show a progress bar without running the GUI on a separate thread. It does not require as many hacks as this code to work but it also does not work as well.
I tested many potential use cases to make sure everything worked reliably before submitting the PR, however, I cannot guarantee it won't cause any issues since it does so many unorthodox things. If it ends up causing issues, there is a single flag that will disable all the code this PR introduces. I also added a checkbox to Vapor's developer menu that allows you to enable/disable it on the fly.

@StasJ please verify that this compiles and runs on windows before we proceed further with a review. Thanks.

@clyne I verified that this works on Windows 8.

@sgpearse I built on Windows 10. You need to update your VisualC++ compiler.
Great, I'll take a look at that warning, thanks.

@sgpearse I received email stating:
"Unfortunately we can't merge this PR until we've upgraded our windows compiler. This involves updating our CI system, and rebuilding our third party libraries."
However, the comment above states only:
"Unfortunately we can't merge this PR until we've upgraded our windows compiler."
Would we need to rebuild out 3rd party libs or not? If so, how much effort is this?
Alternatively, @StasJ can we simply not use the problematic language feature?

@clyne We shouldn't have to rebuild our third party libraries. It is possible to reimplement the offending code however it is already using pretty old features (C++11). The windows compiler Circle is using is 5 years old so we probably want to upgrade it anyway.

@clyne We shouldn't have to rebuild our third party libraries. It is possible to reimplement the offending code however it is already using pretty old features (C++11). The windows compiler Circle is using is 5 years old so we probably want to upgrade it anyway.

@sgpearse what kind of effort is it going to take to upgrade the windows compilers?

@clyne I am uncertain about library compatibility.  I originally thought we would need to re-built the libraries, but I retracted this statement.  This article talks about different schemes for mangling symbol names, so we might be ok, but there's a lot of uncertainty.  If we go down this route, I'd personally hedge on being safe and rebuilding the libraries.
When the libraries were rebuilt last year, Windows was the most effort by far.  That was partly due to the build process being undocumented.  However there are still inconveniences in the procedure.  Several build systems were used, including the use of pre-built binaries that were built with compilers currently unknown to us.

@sgpearse my experience with libraries compiled under older compilers is that either they link or they don't. Have you tried to see if they'll link? It doesn't seem like it should be terribly difficult to test this. Thanks.

Scott wrapping up testing with VS19. Will notify team when know outcome of using VS19 with extant 3rd party library builds

Building on VS19 works when building on local hardware.  CircleCI's windows build system is currently broken, but the problem does not seem to be the compiler version being used.


attribution added to layer and marker width fix AND moduleId removed for webpack

Add attribution option
remove moduleId for webpack support
fix icon width, height for marker

the module.id is necessary for SystemJs to resolve relative paths. I replaced module.id, with module.id.toString() so webpack won't have a problem. Supporting both webpack and systemJs is not always an easy task. Nevertheless, I will commit your marker.ts change. But never into master. All PR should be on develop branch.

I will modify the attribution control to work for the layer component as well, no need to add it there

nice idea, but it renders quite badly, so ill go with your solution


timestamp for utterance or sentence?

curious if current output format of distil-whisper has timestamp for utterance or sentence. If no, will be considered in the future?

You can enable segment-level timestamps with:
output = pipe(inputs, return_timestamps=True, batch_size=4)
You can add word-level timestamps with the align function from WhisperX, but keep in mind sometimes Whisper sometimes will return None if the segment ends in the middle of a word. In that case just estimate the average duration per character and guess the ending timestamp.
avg_duration_per_char = total_duration / total_characters # for None timestamp cases

Thanks so much!

Indeed, Distil-Whisper was trained with sentence level timestamps (same training task as Whisper), which you can enable as follows:
import torch
from transformers import AutoModelForSpeechSeq2Seq, AutoProcessor, pipeline
from datasets import load_dataset

device = "cuda:0" if torch.cuda.is_available() else "cpu"
torch_dtype = torch.float16 if torch.cuda.is_available() else torch.float32

model_id = "distil-whisper/distil-large-v2"

model = AutoModelForSpeechSeq2Seq.from_pretrained(
    model_id, torch_dtype=torch_dtype, low_cpu_mem_usage=True, use_safetensors=True
)
model.to(device)

processor = AutoProcessor.from_pretrained(model_id)

pipe = pipeline(
    "automatic-speech-recognition",
    model=model,
    tokenizer=processor.tokenizer,
    feature_extractor=processor.feature_extractor,
    max_new_tokens=128,
    torch_dtype=torch_dtype,
    device=device,
)

dataset = load_dataset("hf-internal-testing/librispeech_asr_dummy", "clean", split="validation")
sample = dataset[0]["audio"]

# result with no timestamps
result = pipe(sample)
print("No timestamps: ", result["text"])

# result with timestamps
result = pipe(sample, return_timestamps=True)
print("With timestamps: ", result["chunks"])

We also support word-level timestamps in 🤗 Transformers using the same dynamic time-warping algorithm as OpenAI's repository. Currently, this only works with batch-size of 1 using the pre-trained Whisper models:
import torch
from transformers import AutoModelForSpeechSeq2Seq, AutoProcessor, pipeline
from datasets import load_dataset

device = "cuda:0" if torch.cuda.is_available() else "cpu"
torch_dtype = torch.float16 if torch.cuda.is_available() else torch.float32

model_id = "openai/whisper-large-v2"

model = AutoModelForSpeechSeq2Seq.from_pretrained(
    model_id, torch_dtype=torch_dtype, low_cpu_mem_usage=True, use_safetensors=True
)
model.to(device)

processor = AutoProcessor.from_pretrained(model_id)

pipe = pipeline(
    "automatic-speech-recognition",
    model=model,
    tokenizer=processor.tokenizer,
    feature_extractor=processor.feature_extractor,
    max_new_tokens=128,
    torch_dtype=torch_dtype,
    device=device,
)

dataset = load_dataset("hf-internal-testing/librispeech_asr_dummy", "clean", split="validation")
sample = dataset[0]["audio"]

result = pipe(sample, return_timestamps="word")
print(result["chunks"])

Note that we haven't found the optimal alignment heads for word-level timestamps for distil-large-v2, so these word-level timestamps aren't available yet. I'll do some analysis to see what the best configuration is and update the model config accordingly!

Hi @sanchit-gandhi can I check if you've found the optimal alignment heads yet for word-level timestamps? Much appreciated!

^^same q


ceph-mon: docker fix run on atomic host

fix template issues.
Signed-off-by: Sébastien Han<EMAIL_ADDRESS>

test this please

We're testing and trying to get 2.0 running from the puddles. Do you have
any tips?
On Thu, Mar 31, 2016 at 3:36 PM, Leseb<EMAIL_ADDRESS>wrote:

Merged #669 https://github.com/ceph/ceph-ansible/pull/669.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
https://github.com/ceph/ceph-ansible/pull/669#event-610531503

--
John Wilkins
Red Hat
<EMAIL_ADDRESS>(415) 425-9599
http://redhat.com

I'm sorry from the puddles?
There is a permission issue that I need to fix and 2.0 should run perfectly. Just trying to find an elegant way to fix it for all the Ceph versions. Will likely fix this tomorrow.

Yeah, I was just chowning in the entrypoint scripts.

@johnwilkins it works now on 2.0 thanks to: https://github.com/ceph/ceph-ansible/pull/673 and https://github.com/ceph/ceph-ansible/pull/669


Build is broken

$ go build -v ./pkg/...

package github.com/jetstack/cert-manager/pkg/controller/acmechallenges
	pkg/controller/acmechallenges/controller.go:41:2: use of internal package github.com/jetstack/cert-manager/pkg/issuer/acme/http/internal/istio not allowed

/kind bug

cc: @inteon  @wallrj
The offending pr seems to be https://github.com/jetstack/cert-manager/pull/3724

Thanks for spotting the issue!
It does not break Bazel builds (bazel build //... ) so shouldn't affect our own workflows/CI as such except for cases where someone uses go build directly.
It would break anyone importing pkg/controller/acmechallenges and cmd/controller/app without Bazel as those seem to be the two places where there are the imports that the compiler complains about.

https://github.com/inteon/cert-manager/blob/2d7dfcb4623c24f6eaafd2f7d3d7b1832668e05d/pkg/issuer/acme/http/internal/istio/BUILD.bazel#L10
This line fixes the bazel build. And also persists throughout ./hack/update-all.sh. I was not aware this causes issues when using the go tools directly.

/priority critical-urgent


this Keyword

We need to add support for the this keyword. It should be set to the identifier or variable that was used in its closest containing block.
make {
    valid: this matches @filled; // this = make
}

This will be most useful when we implement #45 as it will apply to each element in the block header.
make, model, year {
    // valid tag applied to make / model / year with `this` set appropriately
    valid: this matches @filled;
}

Implemented this keyword as specified. this is bound to the parent Identifier block. So in the case above this would resolve to be equivalent to make. A couple notes on the changes.
this is not all that beneficial right now, since you can simply type the name of the identifier. It will primarily be useful when we add multiple owners to a block (#45).
Currently this resolves to the value of make not the make identifier itself. As a result, you cannot use the dot operator. this.valid will fail, which I'm ok with at the moment, since there isn't really a good reason to do so at this time. Such a feature would allow you to do something like:
make {
    enabled: hasCar;
    valid: this.enabled and this matches @filled;
}

which wouldn't really be a great idea anyways. The tags we have now don't work well in such situations so I'm not supporting it at this time. Later we will probably need it though. If we add support for a value tag, that would play well with others and make a lot of sense to use in other tags (#14), and once we scope variables within identifiers we might use this.@myVar to access them (#3) since they will be specific to each instance.
I also did not support this at the root level or within a BlockVariable. Both of these could make sense when we want to support the dot operator, but there is no clear value to assign to this when used without a dot, and since that is the only case we currently allow there's no sense in allowing them at this time.
If you use this in the wrong place it currently throws a ParsingError, though I'm wondering if we should have some other error for this kind of occurrence. This is really a semantic checking error, but there's no clear error type we can use for it.


Cannot use external component on Heroku production

I was using "vue-switches" on my nuxt project
I can run on my PC without any problem. "npm run build" also working fine.
But when I push to Heroku, it cannot be built.

When remove "vue-switches" from package.json and push to Heroku, then it works.
any solution?

You followed this guide: https://nuxtjs.org/faq/heroku-deployment ?

Yes, normally I can deploy
But just add by "vue-switches" to package.json, without doing anything, it cannot deploy

is it in devDependencies or dependencies in your package.json?

I put it in dependencies

do a npm install --save-dev vue-switches too and try to redeploy

devDependencies also cannot deploy

Can you try to create a minimal reproduction repo?

Well, I found the problem, it was in my code.
It's about case sensitive
I had import component like this:
import Modal from<EMAIL_ADDRESS>
export default {
  components: {
    modal: Modal
  },
}

and using like
<modal></modal>
So I change all of it to Modal, then it works.
Thank you


test: integration test

Fixes #31

@chingor13 build failed because of projects/gcloud-devel  dosen't have setup of Stackdriver workspace.


Scalar arrays

Hi,
Is there any support for scalar arrays? For example, how to access char *argv[] of the execve(2)?
Thanks.

There's not currently any nice way of getting those values, but it's definitely something that can be worked on


Import missing ApplicationException class

When attempting to add database columns when the table does not exist, an ApplicationException is thrown but the class is not imported. This quick fix resolves the issue.

Thanks @LarryBarker!


Add market creator fees filter dropdown

Coverage increased (+0.04%) to 55.425% when pulling 5c5cc202d1130006e3cbfd027e28562d10a9a2ee on justinbarry/ch18177/allow-filtering-of-markets-by-estimated-fee into dcecf6a76fa1bfd320297f48c90744af8ec71ac7 on master.

needs some mobile styling. can be in separate pr


⚠ Bofrost.lu has degraded performance

In 09f5ccc, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 896 ms

Resolved: Bofrost.lu performance has improved in 6a75bf2 after 13 minutes.


docs: adds decision record for HashiCorp Vault auth refactor

What this PR changes/adds
This PR adds a decision record that outlines a refactor of the authentication inside the vault-hashicorp extension.
Why it does that
Currently, the only possible authentication method for HashiCorp Vault is token authentication which is hardcoded into the extension.
To pave the way for additonal authentication methods, the authentication of vault-hashicorp extension needs to be extensible.
This PR outlines the changes needed to achieve interchangeable authentication.
Further notes
List other areas of code that have changed but are not necessarily linked to the main feature. This could be method
signature changes, package declarations, bugs that were encountered and were fixed inline, etc.
Linked Issue(s)
Closes #4672
Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.

please respect the process, which is: raise an issue, wait until it is triaged and ready for development, and then provide a PR.


Is Ammonite right for me?

I want to use Ammonite in a dynamic scripting environment for a game. I'm already using the Scala JSR-223 ScriptEngine implementation but I find it to be quite inadequate for what I need. If I were to replace it with Ammonite (assuming that's possible) in order to inherit its features (most notably magic imports and predefs) would it be able to function similarly to how it was before?

Good question! Try asking in the gitter channel


Bug when using function create_frequency_sweep in solver Q3D

Before submitting the issue

[X] I have searched among the existing issues
[X] I am using a Python virtual environment

Description of the bug
When adding a sweep frequency to our setup in the Q3D solver, using the function create_frequency_sweep , the sweep is created but the values and type of sweep is wrong
Steps To Reproduce
import pyaedt
import pyvista
pyvista.set_jupyter_backend("trame")
import matplotlib.pyplot as plt
"""Launch HFSS and save project"""
non_graphical = False
project_name = pyaedt.generate_unique_project_name(project_name="Spiral_inductor")
app_q3d = pyaedt.Q3d(projectname = project_name,
specified_version="2024.1",
non_graphical=non_graphical,
new_desktop_session=True
)
app_q3d.design_settings() #checking we have the right settings
app_q3d.change_material_override()
app_q3d.design_settings() #checking we have the right settings
"""Create spiral inductor"""
my_modeler = app_q3d.modeler
my_modeler.model_units = "mm" #set to milimeter
my_udmPairs = []
mypair = ["ILD Thickness (ILD)", "0.006mm"]
my_udmPairs.append(mypair)
mypair = ["Line Spacing (LS)", "0.004mm"]
my_udmPairs.append(mypair)
mypair = ["Line Thickness (LT)", "0.005mm"]
my_udmPairs.append(mypair)
mypair = ["Line Width (LW)", "0.004mm"]
my_udmPairs.append(mypair)
mypair = ["No. of Turns (N)", 2]
my_udmPairs.append(mypair)
mypair = ["Outer Diameter (OD)", "0.15mm"]
my_udmPairs.append(mypair)
mypair = ["Substrate Thickness", "0.2mm"]
my_udmPairs.append(mypair)
mypair = ["Inductor Type","Octagonal,"]
my_udmPairs.append(mypair)
mypair = ["Underpass Thickness (UT)", "0.001mm"]
my_udmPairs.append(mypair)
mypair = ["Via Thickness (VT)", "0.001mm"]
my_udmPairs.append(mypair)
obj_udm = my_modeler.create_udm(udmfullname="Q3DExtractor/OnDieSpiralInductor.py", udm_params_list=my_udmPairs)
""" Automatically creates model geometry
Geometry is parametrized
"""
"""Assign nets/ sources/ sink """
nets = app_q3d.auto_identify_nets()
face_source = my_modeler.get_object_faces("Inductor")[45]
face_sink = my_modeler.get_object_faces("Inductor")[41]
source = app_q3d.assign_source_to_objectface(face_source, source_name="Source1", net_name = "Inductor")
sink = app_q3d.assign_sink_to_objectface(face_sink, sink_name="Sink1", net_name = "Inductor")
Defining setup
setup1 = app_q3d.create_setup(setupname="Setup1")
setup1.props["SaveFields"] = True
assert setup1.props["AdaptiveFreq"] == "1GHz"
#create the sweep as following in the picture attached

Which Operating System are you using?
Windows
Which Python version are you using?
3.10
Installed packages
python -m pip freeze
aiohttp==3.9.3
aiosignal==1.3.1
ansys-pythonnet==3.1.0rc3
asttokens==2.4.1
attrs==23.2.0
certifi==2024.2.2
cffi==1.16.0
charset-normalizer==3.3.2
clr-loader==0.2.6
colorama==0.4.6
comm==0.2.1
contourpy==1.2.0
cycler==0.12.1
decorator==5.1.1
defusedxml==0.7.1
executing==2.0.1
fonttools==4.47.2
fpdf2==2.7.7
frozenlist==1.4.1
idna==3.6
ipython==8.21.0
ipywidgets==8.1.1
jedi==0.19.1
jsonschema==4.21.1
jsonschema-specifications==2023.12.1
jupyterlab-widgets==3.0.9
kiwisolver==1.4.5
matplotlib==3.8.2
matplotlib-inline==0.1.6
more-itertools==10.2.0
multidict==6.0.5
numpy==1.26.3
packaging==23.2
parso==0.8.3
pillow==10.2.0
platformdirs==4.2.0
plumbum==1.8.2
pooch==1.8.0
prompt-toolkit==3.0.43
psutil==5.9.8
pure-eval==0.2.2
pyaedt==0.7.10
pycparser==2.21
Pygments==2.17.2
pyparsing==3.1.1
PyQt5==5.15.10
PyQt5-Qt5==5.15.2
PyQt5-sip==12.13.0
PySide6==6.6.1
PySide6-Addons==6.6.1
PySide6-Essentials==6.6.1
python-dateutil==2.8.2
pyvista==0.43.2
pywin32==306
referencing==0.33.0
requests==2.31.0
rpds-py==0.17.1
rpyc==5.3.1
scooby==0.9.2
shiboken6==6.6.1
six==1.16.0
stack-data==0.6.3
traitlets==5.14.1
trame==3.5.2
trame-client==2.15.0
trame-server==2.16.0
trame-vtk==2.8.0
urllib3==2.2.0
vtk==9.3.0
wcwidth==0.2.13
widgetsnbextension==4.0.9
wslink==1.12.4
yarl==1.9.4

Hi @Nanaaaaaaa19,
I'm sorry but I couldn't reproduce your issue.
Please try the snippet below:
`import pyaedt
app_q3d = pyaedt.Q3d(specified_version="2024.1")
setup1 = app_q3d.create_setup(setupname="Setup1")
setup1.props["SaveFields"] = True
sweep1 = app_q3d.create_frequency_sweep(setupname=setup1.name, units="GHz", freqstart=0.5, freqstop=1.5, sweepname="Sweep1")
app_q3d.release_desktop(False, False)`
Hope this helps,
Giulia

Hi @gmalinve ! Yes it does work this way but then the distribution will be in linear step and not linear count but if you put:
sweep1 = app_q3d.create_frequency_sweep(setupname=setup1.name, units="GHz", freqstart=0.5, freqstop=1.5, freqstep=401, sweepname="Sweep1") it creates the sweep with wrong values, since it works in HFSS solver and not in Q3D I think it can be a bug no ? Keep me posted maybe there's a mistake/something on my side I may have overlooked

Hi @Nanaaaaaaa19,
Could you please try to create a frequency weep through the setup object? like that:
sweep1_1 = setup1.create_frequency_sweep(unit="GHz", freqstart=0.5, freqstop=1.5, sweepname="Sweep1_1")
and specify here your sweep type.
Thanks
Giulia

Here are the results of this code line

@Nanaaaaaaa19 ok so it seems it works, right?

sweep1_2 = setup1.create_frequency_sweep(unit="GHz", freqstart=0.5, freqstop=1.5, sweep_type='Interpolating', sweepname="Sweep1_2") However if i try it like that the count set automatically to 401 points so it works with this line but if you want to choose the num_of_freq_points parameter then a bug appear

@Nanaaaaaaa19 what bug?

Try the function with num_of_freq_points' inside like that: sweep1_2 = setup1.create_frequency_sweep(unit="GHz", freqstart=0.5, freqstop=1.5, num_of_freq_points=401, sweep_type='Interpolating', sweepname="Sweep1_2")
`

Try the function with num_of_freq_points' inside like that: sweep1_2 = setup1.create_frequency_sweep(unit="GHz", freqstart=0.5, freqstop=1.5, num_of_freq_points=401, sweep_type='Interpolating', sweepname="Sweep1_2")`

sweep1_2 = setup1.create_frequency_sweep(unit="GHz", freqstart=0.5, freqstop=1.5, num_of_freq_points=401, sweep_type='Interpolating', sweepname="Sweep1_2")

@Nanaaaaaaa19 for the moment, if possible, use the default value of 401 when sweep_type is interpolating. Someone fill fix this.
Thanks!

Yes thanks !


Reset stream

Unclear how to effectively test, Tested manually via starting at Integer.MAX_VALUE - 4
Three successive requests, showing the 3rd silently retrying.

relates to https://github.com/square/okhttp/issues/3670

I'm suspecting this isn't a full fix, but as I think it will tear down the connection in RetryAndFollowUpInterceptor

@swankjesse It seems better if StreamAllocation doesn't become aware of stream id logic.  Assuming this part stays in Http2Connection this seems exactly what shutdown is meant to achieve.
  /**
   * Degrades this connection such that new streams can neither be created locally, nor accepted
   * from the remote peer. Existing streams are not impacted. This is intended to permit an endpoint
   * to gracefully stop accepting new requests without harming previously established streams.
   */
  public void shutdown(ErrorCode statusCode) throws IOException {


Not specified what happens when server doesn't support include request parameter

The specification mentions that an endpoint MAY support custom inclusion, but doesn't specify what happens when a client issues a request with an include request parameter and the server doesn't support it. Proposal: server MUST return a 400 Bad Request, the same as for the sorting.

@dgeb Are you in favor of this proposal? If so, I'd be happy to submit a PR before 1.0. It makes support for the include parameter much more visible than requiring the client to look for "included" in the payload.

@ethanresnick yes, a PR would be appreciated. Thanks!

@dgeb This can be closed now :)


PiecewiseLinearComplexDomain: gmsh to tetgen conversion

This PR is for conversion of 3D gmsh mesh to tetgen mesh with relevant flags using the use_gmsh switch on PiecewiseLinearComplexDomain.

The test fails for the mesh in 3D because the gmsh version is different on the Travis build and my working computer (this affects the number of vertices and elements in the 3D mesh).
The tests are currently comparing the number of entities in the tetgen files (.ele, .node, .face, .edge) to the known (hardcoded) number of entities given by gmsh for a specific geometry. There might be a better way to test it so it works regardless of the version. Otherwise, we can skip those tests for now, or settle down on the gmsh version to use.

@tridelat Waiting to fix this one to release v1.3.2

Thanks for fixing the test @cekees ! The relative 2% difference should make it work with most versions. Is it ready to be merged?

@cekees @tridelat I am merging this one for v1.3.2


bug: Add correct error handling for eth_ methods

Bug Report
Beerus version:

Current behavior:

The eth_ methods have the correct BeerusRpc error handling scheme but are all returning a "ContractError" message.
Expected behavior:

Each method should return errors specific to their functionality.
Steps to reproduce:

Related code:

insert short code snippets here

Other information:

Ethereum rpc specs:
https://ethereum.github.io/execution-apis/api-documentation/
Helios RPC implementation:
https://github.com/a16z/helios/blob/ef5a6a216f0662d1a9486c8a5260216c61bac80b/client/src/rpc.rs

eth_ methods exposure could be deprecated soon

Close if #439 passes


Remote access using browser

Hi
Thank you for the great script it worked for me.
I have two issues;
I have only one issue it works as long as I am within the network(i.e. <IP_ADDRESS>/rutorrent). As soon as I am trying to access(i.e. <IP_ADDRESS>/rutorrent). it outside my network rutorrent does not let me access it. I am not sure if it caused by installation.
And
Lastly; Since I have installed it on a laptop sometimes I take it to work or friends place if lets say the router ip(<IP_ADDRESS>) is not same as mine(i.e. <IP_ADDRESS>) I can't access it using browser although if I access it using terminal it works. It just Rutorrent isn't communicating with rtorrent for some unknown reason.
I hope I  am making sense.
thank you

You can't access your network unless you give access to it. Do some research concerning how to access your local network anywhere. I do recommend using a DNS as your IPv4 might not be static. The most secure way is through a VPN and you have to setup a VPN server to accomplish that. There won't be given any further support here as this is beyond the script rtinst. There are plenty of guides and how-tos on how to accomplish this, so do some research and enjoy learning in the process 👍


Support google app engine

Google appengine's support for requests is sketchy at best. So this PR adds support for urlfetch.

Current coverage is 88.81%

Merging #9 into master will decrease coverage by -0.86% as of fd8adeb

@@            master      #9   diff @@
======================================
  Files            1       1
  Stmts          155     161     +6
  Branches        37      38     +1
  Methods          0       0
======================================
+ Hit            139     143     +4
- Partial          8       9     +1
- Missed           8       9     +1

Review entire Coverage Diff as of fd8adeb

Powered by Codecov. Updated on successful CI builds.

Would it make sense to always use urlfetch if it can be imported?

It would actually.

How about define _request in except and else clauses of the try/import?

I took a look at how the try/except/else worked but I can't really see how it would be useful in this case.
try:
    from google.appengine.api import urlfetch
    USE_URLFETCH = True
except ImportError:
    USE_URLFETCH = False

And then check whether value is true or false to determine if we can execute urlfetch.

Perhaps you thought about doing something like this:
def _request(data, extra_headers):
    try:
        return urlfetch.fetch(url=TRACKING_URI, payload=data, method=urlfetch.POST,
                              headers=extra_headers)
    except NameError:
        return requests.post(TRACKING_URI, data=data, headers=extra_headers,
                             timeout=5.0)

Seems preferable to the former suggestion I had. So let's go for that one?

I was thinking something like:
try:
    from google.appengine.api import urlfetch
except ImportError:
    def _request(data, extra_headers):
        return requests.post(TRACKING_URI, data=data, headers=extra_headers,
                             timeout=5.0)
else:
    def _request(data, extra_headers):
        return urlfetch.fetch(url=TRACKING_URI, payload=data, method=urlfetch.POST,
                              headers=extra_headers)

Thanks for telling me. Though personally I find it less readable than the latest commit. But if you prefer it that way I'll make another commit that reflects that :)

It is a bit less readable but it only determines the method to use once.
By the way, there is also sigmavirus24/requests-toolbelt#114 so in the long run this may become obsolete.


Lodash vs Sift.js

Hi guys,
Lodash return an element but Sift.js return an empty Array, check please here
Thanks in advance, Nicholls

I wasn't able to reproduce this with a test: https://github.com/crcn/sift.js/blob/master/test/basic-test.js#L123. Could it be a sift version mismatch?

@jdnichollsc I reviewed your sift query and it's working correctly. Both start dates are 1/13/2017 which is > period.startDate. Hard to compare your custom lodash filter fn with the sift example tbh.

Thanks for checking this out @swordfish444. I'm closing this ticket since it's months old and cannot be reproduced.


update packages

:white_check_mark: Build TheIdServer 4.2.1-fix-dependencies1-0229 completed (commit https://github.com/Aguafrommars/TheIdServer/commit/2e7a97f9e3 by @)


Creating a new chart for the controller-manager

This PR has two major changes:

Adds a deploy/wip-catalog chart for installing @pmorie's new controller-manager
Stores api server certs/secret keys in a secret and mounts them into the API server container

These are or development use only. They allow for developers to paste these certs into their kubeconfig once while they iterate on the API server. Note that if the API server doesn't find these certs in place, it will auto-generate new ones every time it starts up.

Given my experience writing charts, I'd like to call dibs on one of the three LGTMs for this PR. Please and thank you. 😄

@arschles if this PR is to add a new chart for the new controller-manager, why does it make changes to the existing deploy/catalog chart?

LGTM


bug: import rules crash code when de-duplicate dependencies

Recently, I enabled two rustfmt rules:
imports_granularity = "Module"
group_imports = "StdExternalCrate"

After I re-fmt, the code failed to be compiled. And thus I found an unexpected rustfmt behaviour:
before fmt:
use risingwave_pb::data::DataType;
use risingwave_pb::data::DataType as DataTypeProst;

after fmt:
use risingwave_pb::data::DataType as DataTypeProst;

But the codes that use "DataType" are not changed.
I don't think that rustfmt should turn the correct code into incorrect in any condition.

Can you provide a reproducible example?

Can you provide a reproducible example?

Ok, will do it soon.

Can you provide a reproducible example?

I created a repo to reproduce this bug: https://github.com/Sunt-ing/rustfmt_bug_example

Can you provide a reproducible example?

I created a repo to reproduce this bug: https://github.com/Sunt-ing/rustfmt_bug_example

Consider creating a single file for this issue, which is easier to test and reproduce. e.g.,
https://github.com/rust-lang/rustfmt/blob/master/tests/target/imports_granularity_crate.rs

@skyzh Good advice. I will try to do that.

@skyzh Since the bug occurs when imports_granularity = "Module", I think it's hard to reproduce it within a single file. I'd like to leave it to the one who wants to fix it after the bug is verified. He or she could create such a file as a test.

@skyzh Since the bug occurs when imports_granularity = "Module", I think it's hard to reproduce it within a single file. I'd like to leave it to the one who wants to fix it after the bug is verified. He or she could create such a file as a test.

In fact, rustfmt always accept a single file as input, and cargo fmt call rustfmt on all files. So it should always reproduce on a single file.

OK, I created one. This code snippet will crash after you format the following code with any one of the following options:

imports_granularity = "Module"
imports_granularity = "One"
imports_granularity = "Crate"

#![allow(dead_code)]
mod a {
    pub mod b {
        pub struct Data {
            pub a: i32,
        }
    }

    use crate::a::b::Data;
    use crate::a::b::Data as Data2;

    pub fn data(a: i32) -> Data {
        Data { a }
    }

    pub fn data2(a: i32) -> Data2 {
        Data2 { a }
    }

    #[cfg(test)]
    mod tests {
        use super::*;

        #[test]
        pub fn test() {
            data(1);
            data2(1);
        }
    }
}


Code example for useExpanded is broken

https://codesandbox.io/s/github/tannerlinsley/react-table/tree/master/examples/expanding
Currently shows an error message. The stack trace isn't useful to me; I can't figure out exactly what's wrong.
A cross-origin error was thrown. React doesn't have access to the actual error object in development. See https://fb.me/react-crossorigin-error for more information.
▶ 12 stack frames were collapsed.
evaluate
/src/index.js:6:9

  3 | import './index.css'
  4 | import App from './App'
  5 |
> 6 | ReactDOM.render(<App />, document.getElementById('root'))
    |         ^
  7 |

View compiled
▶ 10 stack frames were collapsed.

Also experiencing this on another codesandbox example.

@tremby @patwalls All (or most) examples are broken. They work if you change the dependency version of react-table from "latest" to "7.0.0.rc3" under "Dependencies" in the sidebar

Indeed. This issue should be fixed with the next release (in a few hours)


When the input filter finishes, check whether we returned data

during the last read and if not, delegate to the remaining filter
chain.
Without that, ProcessPartial for the request body breaks forwarding
of uploaded files using mod_proxy_ajp and mod_wl.
See issue #2091.

Related to:

#1600 and #1471 - @tomsommer (1)
#1827 - @markblackman (2)

Merge! Thank you.


Fix bug with uncontrolled inputs.

Description
This fixes a bug caused by a previous bug fix #3084.
The previous fix broke all uncontrolled inputs (you can no longer type in them).
This reverts the previous change, so now inputs can be both controlled and uncontrolled again.
It fixes the original bug in a different way, by making sure the empty-string is passed in by the caller of the Input.
Tests

Verified that broken inputs (heatmap metadata) now work.
Verified that the original bug is still fixed. (by going through the Sample Upload process).

Hey Greg, that's a really good point.
I took a deeper look at your changes, and I think that PhyloTreeCreation.jsx change might be a bit risky. The reason is that you are now controlling the input based on this.state.treeName, but that variable actually gets changed in a couple of places (for example, it gets sanitized). So it's possible for the user to be typing stuff, and for the value of the input to suddenly change to a sanitized version of a past value.
I think it's best to at least revert the PhyloTreeCreation change. I'll do that and will verify that it still works with my change. Let me know if that sounds good.

I think it's best to at least revert the PhyloTreeCreation change. I'll do that and will verify that it still works with my change. Let me know if that sounds good.

Sounds good to me.

@gregdingle, I verified that the phylo tree still works.


Changing ToC indents

The docs.mbed can't see your indents, so the ToC is 27 flat items. It should be able to see these indents and given properly nested bullets.

Thanks


concatenation blows up memory and perhaps takes forever

Concatenating 4 pol files together got an out of memory error on enteprise (128). Paul confirms that polarization does take a lot of memory.
James reports it took ~46 minutes to concat a night of data along the time axis. Used 46G of ram and the time did not increase as each file is added.  Danny reports time to concat files increasing with the number of files added.
Need some concatenation profiling for at least polarization and time.

Is this really required for the next version (that we're targeting for next week)? And if so, who's going to do it?

I didn't separately time how long the read of each new file took.  But the combined time for read + concatenate increased linearly with the number of files.  I think that's consistent with the checking that's done for overlap, etc.
At least along the time axis, I'm not sure this is a problem: if you build the big file once, you can access it again fairly quickly (and it doesn't take more space on disk than the original data).  The polarization is weird, though.

I have a branch that addresses the super-linear complexity in concatenating many UVData objects. When concatenating, say, 5 files, it builds one big UVData objects and inserts data from all 5 into it at once--rather than do ((((1+2)+3)+4)+5)--which is a lot of duplicated computations.
However, I found that, as James said, this doesn't actually speed up the read-in of multiple data files, b/c the total time is bottlenecked by IO rather than data concatenation, so I never submitted the PR, but I can push the branch up if people are interested in looking at it anyways..

Its the combine_uvdata_func branch, and the function is uvdata.combine_uvdata

I did profile it, though, and in just the data concatenation step, I get typically an order of magnitude speed-up with this function over the default 1 + 2 + 3 + 4... behavior (depending on object size etc.)

Could this be related to what was seen in issue #227?

@dannyjacobs what progress to we need on this for the next milestone?

This is a factor 3.7 bloat but doesn't require >128G of ram as reported by @adampbeardsley .

I'm happy to close this issue, leaving open the issue of miriad taking up too much ram. #227


mountpoint-s3: 1.10.0 -> 1.12.0

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/awslabs/mountpoint-s3/releases.
meta.description for mountpoint-s3 is: Simple, high-throughput file client for mounting an Amazon S3 bucket as a local file system
meta.homepage for mountpoint-s3 is: https://github.com/awslabs/mountpoint-s3
Updates performed

Rust version update

To inspect upstream changes
Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 1.12.0 with grep in /nix/store/17lq90j9nld53k07nm0ljhj0jq711yns-mountpoint-s3-1.12.0
found 1.12.0 in filename of file in /nix/store/17lq90j9nld53k07nm0ljhj0jq711yns-mountpoint-s3-1.12.0

Rebuild report (if merged into master) (click to expand)

2 total rebuild path(s)

2 package rebuild(s)

First fifty rebuilds by attrpath

mountpoint-s3

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/17lq90j9nld53k07nm0ljhj0jq711yns-mountpoint-s3-1.12.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A mountpoint-s3 https://github.com/r-ryantm/nixpkgs/archive/fb52a9d657a443dee8e7fe87a91cdeeec17747ba.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/fb52a9d657a443dee8e7fe87a91cdeeec17747ba#mountpoint-s3

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/17lq90j9nld53k07nm0ljhj0jq711yns-mountpoint-s3-1.12.0
ls -la /nix/store/17lq90j9nld53k07nm0ljhj0jq711yns-mountpoint-s3-1.12.0/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review

x86_64-linux

:white_check_mark: 1 package built:

mountpoint-s3

Maintainer pings
cc @lblasc for testing.

[!TIP]
As a maintainer, if your package is located under pkgs/by-name/*, you can comment @NixOS/nixpkgs-merge-bot merge to automatically merge this update using the nixpkgs-merge-bot.

Add a :+1: reaction to pull requests you find important.

@NixOS/nixpkgs-merge-bot merge


Use a stronger set of ciphers for SSL/TLS

This change is

Upon further investigation it seems the python version is the main thing that makes a difference in the set of ciphers. Debian stable uses python 2.7.3 and that seems to have obsolete ciphers enabled. But newer python versions seem to have that fixed. So anyway, this isn’t needed if a reasonably current python version is used.


3.97 RPS ?

ab -c 20 -n 10000 http://<IP_ADDRESS>:8080/
const service = require('restana')()
service.get('/', (req, res) => res.send('Hello World!'))

service.start(3000)

const gateway = require('fast-gateway')
const server = gateway({
  routes: [{
    prefix: '/',
    target: 'http://<IP_ADDRESS>:3000'
  }]
})

server.start(8080)

Hi @zuohuadong , I guess you are missing some details and explanations here.
Can you please use https://github.com/giltene/wrk2 instead of ab, as the last does not support HTTP 1.1, neither high concurrency levels.
You can consider the following test scripts: https://github.com/jkyberneees/fast-gateway/tree/master/benchmark
Thanks.


Field hidden with hideExpression unaccessible after being shown

I've got a field which must be hidden until a REST response says otherwise.
That's the code I use:
id: "nameInput",
hideExpression: function () {
  return !vm.model.nameRequired
}

On recieving certain REST response,  (1.) the field must be shown, (2.) set to required and (3.) required validation ng-message must be displayed.
Here's my code:
In field description:
expressionProperties: {
    "templateOptions.required": function () {
        return vm.model.nameRequired
    }
}

After REST promise is resolved:
vm.model.nameRequired = true;
vm.form.nameInput.$setTouched();

The problem is that vm.form.nameInput is undefined at this point.
How can I invoke $setTouched() after the field is instantiated and it's object accessible?
EDIT:
It works when I wrap it with $timeout:
vm.model.nameRequired = true;
$timeout(function () {
    vm.form.nameInput.$setTouched();
});

But that's pretty ugly hack and doesn't work well with Protractor E2E tests.

Do you mind creating an example of what you're trying to accomplish? Please follow the instructions here: http://help.angular-formly.com
This will make it easier for you to get help. Because the github issues are reserved for bug reports and feature requests, I'm going to go ahead and close this issue. See you on chat! Thanks!


[SPARK-42991][SQL] Disable string type +/- interval in ANSI mode

What changes were proposed in this pull request?

Moved ResolveBinaryArithmetic from Analyzer to TypeCoercion and AnsiTypeCoercion.
Update ResolveBinaryArithmetic in AnsiTypeCoercion to only support datetime and interval types +/- intervals.

Why are the changes needed?
For string type  +/- internal, the string value can be date, timestamp and interval. We don't know what type of string should be casted to. For example:
spark-sql (default)> select "2023-01-08" - interval '7' day;
2023-01-01 00:00:00
spark-sql (default)> select "INTERVAL '7' DAY" - interval '7' day; -- "INTERVAL '7' DAY" should be cased to interval type.
NULL
spark-sql (default)> select interval '7' day - interval '6' day;
1 00:00:00.000000000

Does this PR introduce any user-facing change?
Disable string +/- interval in ANSI mode.
How was this patch tested?
Update existing test.

cc @cloud-fan @gengliangwang

@gengliangwang Has updated the description.


Setup up IaSQL-on-IaSQL to be multiregion

Needs #1027

aws_account would have the region column removed and there would be a region table that is relied on by the availability_zone table. Cloud resources that can be created in specific region/az would have a fk relation to the region table which is most resources except a few like ECR public repos, r53 and IAM.


Keycloak 24

Problem Statement
Keycloak 24 is not currently supported
Proposed Solution

Add support for Keycloak 24

Environment

Keycloak Version: 24.0.1
keycloak-config-cli Version: 5.10.0-23.0.1

Additional information
2024-03-05 12:36:03.181 ERROR 1 --- [           main] d.a.k.config.KeycloakConfigRunner        : jakarta.ws.rs.ProcessingException: com.fasterxml.jackson.databind.exc.UnrecognizedPropertyException: Unrecognized field "maxTemporaryLockouts" (class org.keycloak.representations.idm.RealmRepresentation), not marked as ignorable (139 known properties: "userFederationMappers", "rememberMe", "duplicateEmailsAllowed", "adminEventsDetailsEnabled", "users", "clientOfflineSessionMaxLifespan", "webAuthnPolicyRequireResidentKey", "webAuthnPolicyPasswordlessAvoidSameAuthenticatorRegister", "components", "otpPolicyType", "accessCodeLifespanUserAction", "id", "webAuthnPolicyAttestationConveyancePreference", "enabledEventTypes", "applications", "webAuthnPolicyPasswordlessSignatureAlgorithms", "eventsListeners", "ssoSessionMaxLifespanRememberMe", "defaultDefaultClientScopes", "webAuthnPolicyPasswordlessCreateTimeout", "clientOfflineSessionIdleTimeout", "notBefore", "publicKey", "smtpServer", "clientPolicies", "resetPasswordAllowed", "webAuthnPolicyAvoidSameAuthenticatorRegister", "accessTokenLifespanForImplicitFlow", "webAuthnPolicyPasswordlessUserVerificationRequirement", "clientScopes", "internationalizationEnabled", "defaultRole", "accessTokenLifespan", "passwordCredentialGrantAllowed", "federatedUsers", "applicationScopeMappings" [truncated]])
 at [Source: (org.jboss.resteasy.specimpl.AbstractBuiltResponse$InputStreamWrapper); line: 1, column: 1281] (through reference chain: org.keycloak.representations.idm.RealmRepresentation["maxTemporaryLockouts"])

Acceptance Criteria
No response

This issue should be fixed when merging this one: https://github.com/adorsys/keycloak-config-cli/pull/998

I think this can be closed now with the release of 5.11.1.

That it is, thank you @jonasvoelcker!


Added error message when running dcos task <unexisting-task-ID>.

Previously when running dcos task foo-bar, it would exit without any
output and error code. Now it exits with a proper error message and
an exit code of 1.
https://jira.mesosphere.com/browse/DCOS_OSS-2117

@mesosphere-ci run all integration tests


FR: Notify on newer version of node.

Say the current default version in the users machine is v5.1.0 and the remote latest is v5.2.0, it would be nice have a notification system in place which would indicate the user that a greater version is available.
We could indicate this when the user invokes nvm or node -v.
//cc @ljharb

nvm's primary purpose isn't to keep users on the latest node, it's for being able to test in multiple versions of node at once.
I'd be fine adding an nvm command that prints all the available remote versions of node/io.js that are greater than the current one, but doing that every time nvm is invoked is way too expensive, and wrapping node is a non-starter.

nvm's primary purpose isn't to keep users on the latest node, it's for being able to test in multiple versions of node at once.
I'd be fine adding an nvm command that prints all the available remote versions of node/io.js that are greater than the current one, but doing that every time nvm is invoked is way too expensive, and wrapping node is a non-starter.

Cool, say we decide upon a flag for this, all we need to do is list all the versions that are greater that nvm_ls_current from nvm_ls_remote, using semver diff, does that makes sense?

it wouldn't be a flag, it'd be an nvm subcommand, but sure.

The following seems to work, but it is ugly...
nvm ls-remote | awk 'BEGIN{x=0}{if($2==""){v[x]=$0;x++}else{x=0}}END{if(x>0){for(i=0;i<x;i++){print v[i]}}else{print "No Newer Found"}}'

@arrowrowe I'm not sure how that works at all, since it's not using nvm ls or nvm current anywhere

re @ljharb: thanks to nvm ls-remote outputting a -> for installed versions. That's what $2=="" checks.

ah, interesting. what if i'm on iojs and want to know if there's a newer one of those? or what if i want a newer in the same line? ie, i'm > 1.0 and i want to know if it's a newer minor, or < 1.0 and want to know if there's a newer patch.
In other words, I think that by default it should indicate ^, and optionally should indicate *

My mistake. btw I just realized -> is not for installed but current version, which is another mistake :cry:

@ljharb well this should work.
$ alias nln='awk '"'"'BEGIN{x=0}{if($2==""){v[x]=$0;x++}else{x=0}}END{if(x>0){for(i=0;i<x;i++){print v[i]}}else{print "No Newer Found"}}'"'"''

# Suppose iojs-v2.3.2 is installed, want newer major / minor / patch
$ nvm ls-remote iojs | nln
    iojs-v2.3.3
    iojs-v2.3.4
    iojs-v2.4.0
    iojs-v2.5.0
    iojs-v3.0.0
    iojs-v3.1.0
    iojs-v3.2.0
    iojs-v3.3.0
    iojs-v3.3.1

# Only newer minor
$ nvm ls-remote iojs v2 | nln
    iojs-v2.3.3
    iojs-v2.3.4
    iojs-v2.4.0
    iojs-v2.5.0

# Only newer patch
$ nvm ls-remote iojs v2.3 | nln
    iojs-v2.3.3
    iojs-v2.3.4

And similar for node cases.

I'm even thinking (ignore the naming) nvm newer-version ^ and nvm newer-version * which pivots on current - and if there's no current or it's system, then it would just grab the latest installed local version as "current". Perhaps also nvm newer-version ^ 4 etc to override.


Adding asset listing function

This function returns a Vector of available asset filename strings
with a static lifetime and is available from the generated asset file.
Additionally added a function for generating asset names from
their filepaths.

LGTM! Thanks for the list func. But may I ask what use cases you have in mind for it.

Mostly for exposing available assets to end-users.  For example, I'm writing a rust implementation of cowsay that includes the normal set of cowfiles into the binary.  Listing the available cows is normally a filesystem directory list operation, this is just making the equivalent for binary assets.


There is an error when initializing a dummy vault.

Hi sorry to bother you , one  issue I want to report:
When initializing a dummy vault, sometimes an error is reported. The error is

my code is
from dte.honey_vault import HoneyVault
import os
def test():
    for index in range(10000):
        vault = "./hxxtest/vault_"+str(index)+".db"
        if os.path.exists(vault):
            os.remove(vault)
        hv=HoneyVault(vault,"123456")
test()

I have tried for many times,the error is still reported.It is worth noting that the error is randomly reported，most of the time, the initialization is correct.
vault_730.zip is the dummy vault which generates the error.
Thanks.

Yeah, this is a long-standing bug. I have seen that. I am not maintaining this code actively for a long time, so not sure how quickly I will be able to resolve this. Any help will be greatly appreciated.

Thank you!


.markdownlintignore use causing error

I have a pretty simple thing I'm trying to get working with using .markdownlint.json for configuration settings and  .markdownlintignore files. All I want to do is get markdownlint to ignore CHANGELOG.md as we autogenerate the contents there for each release which flags MD025/single-title/single-h1 Multiple top-level headings in the same document
$ cat .markdownlint.json
{
  "default": true,
  "MD013": false,
  "MD033": false
}

$ cat .markdownlintignore
CHANGELOG.md

$ markdownlint -V
0.31.1

The command line just prompts the help output so doesn't like something but I can't work out what??
$ markdownlint  CHANGELOG.md
Usage: markdownlint [options] <files|directories|globs>

MarkdownLint Command Line Interface

Options:
  -V, --version                               output the version number
  -c, --config [configFile]                   configuration file (JSON, JSONC, JS, or YAML)
  -d, --dot                                   include files/folders with a dot (for example `.github`)
  -f, --fix                                   fix basic errors (does not work with STDIN)
  -i, --ignore [file|directory|glob]          file(s) to ignore/exclude (default: [])
  -j, --json                                  write issues in json format
  -o, --output [outputFile]                   write issues to file (no console)
  -p, --ignore-path [file]                    path to file with ignore pattern(s)
  -q, --quiet                                 do not write issues to STDOUT
  -r, --rules  [file|directory|glob|package]  include custom rule files (default: [])
  -s, --stdin                                 read from STDIN (does not work with files)
  --enable [rules...]                                                 Disable certain rules, e.g. --disable MD013 MD041
  -h, --help                                  display help for command

Are there any debug flags that I can apply to workout what is wrong? Thanks!

This is an issue for: https://github.com/igorshubovych/markdownlint-cli
That program will display its help text if there are no files to process. In your example, you are passing it just one file to process and also passing that file in the ignore list, so there is nothing left to do and so it displays the help text.

ah cool, that makes sense. It threw me off a little as I'd assume I was facing a syntax error. Thanks


Add TOC to README

Do a quick review of the readme and add a TOC to it that includes links to Beginner's Guide and FAQ which currently reference the original repo's wiki (and we should consider porting those here and possibly just putting them in the README - it's usually easier to scroll than go read a wiki).

You should be all set. I sent you a template via Discord you can probably use with a GitHub action.


Getting Player Count

I have now used i think 4 or so variables to try get the player count of the bungee server, i tried individual proxy/server player counts and then also global ones.
It returns nothing, just blank. I have no idea why it happens and i am like 99% sure my configs are set alright as other commands i have work already.

If this issue is still present, please make another bug report with the updated Skungee versions and providing more information. We need to be able to figure things out, tell us how you managed to replicate the issue etc within it.


[Request for External] Codeunit 905 - "Assembly Line Management"

Hi,
could you please switch the following functions in codeunit "Assembly Line Management" to local = no and external?

InsertAsmLine
UpdateAssemblyLines

This is done, closing


Reuse PartialCount inside QuantityIterator

source.Take(limit).Count() execute the following operations:

call MoveNext on source limit times inside Take - complexity O(limit),
**Take creates a lazy sequence in heap memory, Garbage Collector will have job here**
allocate a int variable in stack memory to store the quantity of elements, on Count
call MoveNext limit times inside Count on the lazy sequence created by Take - complexity O(limit),
return the int variable

PartialCount(source, limit) execute the following operations:

call MoveNext on source limit times inside PartialCount - complexity O(limit),
allocate a int variable in stack memory to store the quantity of elements, on PartialCount
return the int variable

The difference is that PartialCount has complexity O(limit) instead of O(limit) + O(limit) (therefore do less operations, therefore is faster) and does not allocate nothing is stack memory. This is to reduce allocations, as well f00f5ca.
In fact, the Take + Count approach was how I saw the implementation of AtLeast at first time, the I said about its disadvantages my first comment in morelinq and refactored it in counting methods PR.

Thanks for the explanation. I was just wondering if there was a logical difference; looks like not. I understand the benefits of hand-rolling some LINQ.

I see. There's no logical difference... In fact, this PR is about DRY principle.

Ok. If i try do these improviments tonight

@atifaziz all improviments are done. I just wonder if CountUpTo is a better name than PartialCount.
PartialCount is pretty fine to me. If you don't like it, maybe CountUntil is another option too.

@atifaziz  Adjusts done!

If max is allowed to be 0 then this method will produce an incorrect result

Good catch!

Because “Max” is not a proper word in English.

I meant "Max (parameter) cannot be negative."


issue#1-changed syntax- else if to elif and added author search function

changes

Fixed syntax error: else if ---> else
Added function author_search to take an author and display the author's books and ratings

Looks good! Thank you for contributing :)


Don't include -aarch64 suffix for composes

@thrix mentioned in the chat, it should not be needed anymore to include  -aarch64 suffix when submitting the TF request, it is sufficient to pass the arch only directly in the payload.

I can see this is a duplicate of #2028, closing.


Hand doesn't reappear if holding something that is force detached

When a held object is disabled and force detached, the hand stays inactive if Make Controller Invisible on Interaction is set. It should instantly reappear I think.
it reappears if you let go of the grip buttons and then functions normally.

Thanks again @SmartCarrion. I believe this was fixed in 0.9. Let me know if you're still seeing the issue.


Fix hot loader compatibility with Java8 Nashorn

The way that the hot loader is included in a bundle breaks in Java 8's
Nashorn engine, because of a missing semicolon. This change introduces
a placeholder value that can be correctly substituted when building
a bundle, but is otherwise inert.
Note that I don't particularly like this change, so if there's a better
fix, I'd like to hear about it.

Thanks

You're welcome, webpack is a great tool.


Exception in friendly-traceback when repr return non-string objects.

A tricky one, but given repro.py as:
class Foo:
    def __repr__(self):
        pass

def main():
    f = Foo()
    f.bar

main()

$ python -m friendly_traceback repro.py
Error in sys.excepthook:
Traceback (most recent call last):
  File "/home/mdk/clones/hkis/hkis-exercises/.venv/lib/python3.10/site-packages/friendly_traceback/config.py", line 280, in get_traceback_info
    self.friendly_info[-1].compile_info()
  File "/home/mdk/clones/hkis/hkis-exercises/.venv/lib/python3.10/site-packages/friendly_traceback/core.py", line 419, in compile_info
    self.assign_location()
  File "/home/mdk/clones/hkis/hkis-exercises/.venv/lib/python3.10/site-packages/friendly_traceback/core.py", line 551, in assign_location
    self.locate_exception_raised(records[-1])
  File "/home/mdk/clones/hkis/hkis-exercises/.venv/lib/python3.10/site-packages/friendly_traceback/core.py", line 609, in locate_exception_raised
    var_info = info_variables.get_var_info(line, record.frame)
  File "/home/mdk/clones/hkis/hkis-exercises/.venv/lib/python3.10/site-packages/friendly_traceback/info_variables.py", line 237, in get_var_info
    objects = get_all_objects(line.strip(), frame)
  File "/home/mdk/clones/hkis/hkis-exercises/.venv/lib/python3.10/site-packages/friendly_traceback/info_variables.py", line 96, in get_all_objects
    repr_obj = repr(obj)
TypeError: __repr__ returned non-string (type NoneType)

Original exception was:
Traceback (most recent call last):
  File "/home/mdk/clones/hkis/hkis-exercises/.venv/lib/python3.10/site-packages/friendly_traceback/__main__.py", line 175, in main
    module_dict = runpy.run_path(args.source, run_name="__main__")
  File "/home/mdk/.local/lib/python3.10/runpy.py", line 289, in run_path
    return _run_module_code(code, init_globals, run_name,
  File "/home/mdk/.local/lib/python3.10/runpy.py", line 96, in _run_module_code
    _run_code(code, mod_globals, init_globals,
  File "/home/mdk/.local/lib/python3.10/runpy.py", line 86, in _run_code
    exec(code, run_globals)
  File "repro.py", line 11, in <module>
    main()
  File "repro.py", line 8, in main
    f.bar
AttributeError: 'Foo' object has no attribute 'bar'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/home/mdk/.local/lib/python3.10/runpy.py", line 196, in _run_module_as_main
    return _run_code(code, main_globals, None,
  File "/home/mdk/.local/lib/python3.10/runpy.py", line 86, in _run_code
    exec(code, run_globals)
  File "/home/mdk/clones/hkis/hkis-exercises/.venv/lib/python3.10/site-packages/friendly_traceback/__main__.py", line 196, in <module>
    main()
  File "/home/mdk/clones/hkis/hkis-exercises/.venv/lib/python3.10/site-packages/friendly_traceback/__main__.py", line 178, in main
    explain_traceback()
  File "/home/mdk/clones/hkis/hkis-exercises/.venv/lib/python3.10/site-packages/friendly_traceback/__init__.py", line 88, in explain_traceback
    session.explain_traceback(redirect=redirect)
  File "/home/mdk/clones/hkis/hkis-exercises/.venv/lib/python3.10/site-packages/friendly_traceback/config.py", line 204, in explain_traceback
    self.exception_hook(etype, value, tb, redirect=redirect)
  File "/home/mdk/clones/hkis/hkis-exercises/.venv/lib/python3.10/site-packages/friendly_traceback/config.py", line 233, in exception_hook
    info = self.get_traceback_info(etype, value, tb)
  File "/home/mdk/clones/hkis/hkis-exercises/.venv/lib/python3.10/site-packages/friendly_traceback/config.py", line 280, in get_traceback_info
    self.friendly_info[-1].compile_info()
  File "/home/mdk/clones/hkis/hkis-exercises/.venv/lib/python3.10/site-packages/friendly_traceback/core.py", line 419, in compile_info
    self.assign_location()
  File "/home/mdk/clones/hkis/hkis-exercises/.venv/lib/python3.10/site-packages/friendly_traceback/core.py", line 551, in assign_location
    self.locate_exception_raised(records[-1])
  File "/home/mdk/clones/hkis/hkis-exercises/.venv/lib/python3.10/site-packages/friendly_traceback/core.py", line 609, in locate_exception_raised
    var_info = info_variables.get_var_info(line, record.frame)
  File "/home/mdk/clones/hkis/hkis-exercises/.venv/lib/python3.10/site-packages/friendly_traceback/info_variables.py", line 237, in get_var_info
    objects = get_all_objects(line.strip(), frame)
  File "/home/mdk/clones/hkis/hkis-exercises/.venv/lib/python3.10/site-packages/friendly_traceback/info_variables.py", line 96, in get_all_objects
    repr_obj = repr(obj)
TypeError: __repr__ returned non-string (type NoneType)

Thanks,
This should be easy to fix.  I thought I had fixed this before.

Fixed.
C:\Users\Andre.Roberge>python -m friendly_traceback repro.py

Traceback (most recent call last):
  File "HOME:\repro.py", line 12, in <module>
    main()
  File "HOME:\repro.py", line 9, in main
    f.bar
AttributeError: 'Foo' object has no attribute 'bar'

    An `AttributeError` occurs when the code contains something like
        `object.x`
    and `x` is not a method or attribute (variable) belonging to `object`.

    The object `f` has no attribute named `bar`.

    Execution stopped on line 12 of file HOME:\repro.py.

        6| def main():
        7|     f = Foo()
        8|
        9|     f.bar
        :
    -->12| main()
           ^^^^^^

            main:  <function main>

    Exception raised on line 9 of file HOME:\repro.py.

       6| def main():
       7|     f = Foo()
       8|
    -->9|     f.bar
              ^^^^^

            f:  <class Foo>


Document GuestAndHybridManagement service tag

GuestAndHybridManagement service tag represents the required outbound connectivity for machines using Update Management. Please add this to the document under "Network planning" as the recommended way to allow communication for machines. The service tag should be allowed in the outbound rules in the NSG.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: db47901d-1664-058d-9407-47e932dc9661
Version Independent ID: e90ec9ee-e7da-4f19-248f-4c825aaa8b9f
Content: Azure Automation Update Management overview
Content Source: articles/automation/automation-update-management.md
Service: automation
Sub-service: update-management
GitHub Login: @MGoedtel
Microsoft Alias: magoedte

@dcbrown16 - Thanks for brining this to our attention. We will investigate it further and update you shortly.

@MGoedtel Can you please provide your insights and update the document if required?

@dcbrown16  - Thanks for bringing this to my attention, I knew I forgot to reference that particular detail in the UM content. :)  I'll get that addressed this week.  #please-close


Compose properties

Starting small on property based testing.  Adds a couple property tests for compose based on recent conversations in the gitter.  One just ensures that it's actually performing function, while the other tests for the associative property.
Hopefully this can serve as a starting point for additional property tests in the future.

❤ this
:100:

Nice. Could you clean the commit history?

:fireworks: :balloon: :star2:
Very nice!


lock up with truncated files

Hello, thank you for this nice lib.
(I opened this issue on the sourceforge tracker before realizing that this one seems to be where the activity is. Sorry for the extra work.)
This loop will run endlessly if fread() returns zero (no more bytes in file), since it's not checking feof() or ferror():
https://github.com/tbeu/matio/blob/master/src/inflate.c#L646
To reproduce:
wget https://github.com/libvips/libvips/raw/master/test/test-suite/images/sample.mat
head -c 10000 sample.mat > truncated.mat

Now try to load truncated.mat. Tested with 1.5.17 and 1.5.11 on Windows and Linux. Credit to @kleisauke for finding this.

Confirmed. Need to think about correct error handling.

Hopefully closed by v1.5.18. Please reopen if it is not good enough.

Thank you for doing all this work, @tbeu !
I'll add matio back to the fuzzer and see what happens.


Update binarySearch.js

Speed increase using bitwise shift for array length shorter than 32bit threshold (avoiding function overhead from Math.floor)

Hm, the tests take basically the same amount of time. Should we benchmark this at all maybe? Do you have any? Thanks for the input though! :)
(the tests still pass, it just doesn't seem faster)

The only testing I did for this was with your gulp-bench test suite which showed a speed improvement of around 2-2.5 times on an old Dell laptop earlier today.  I'll set up a jsperf test case if I get time over the weekend but using a direct bitwise shift in place of the division and Math.floor call will be significantly quicker, for example:
https://jsperf.com/jsfvsbitnot/2
https://jsperf.com/floor-performance/2
The bitwise test is a fallback to deal with arrays over 2^31-1 in length as bitwise operands are all 32-bit signed integers in JS.
Hope it helps.

Test cases here for this change: http://jsperf.com/bitwise-shift-vs-division-and-floor-in-binary-search
The improvement appears to be marginal but consistent on JSPerf.

Oh that's excellent! Great job on the test, the difference is huge for me (Intel i7, Linux, Firefox and Chrome), I'm happy to merge this since all of the generative tests pass and the benchmark looks excellent.

No problem, happy to help.


API Changed Again .....

Hi,
is somebody still using this lib (or the branch of "fleinze") ?? --> No longer works since 6.Nov.24
The URL for "verbrauch" so far was like:
_https://api.wstw.at/gateway/WN_SMART_METER_PORTAL_API_B2C/1.0/messdaten/12007xxxx/AT0010000000000000001000006xxxxxx/verbrauch?dateFrom=2024-11-07T00%3A00%3A00.000Z&dateTo=2024-11-11T16%3A20%3A37.853Z&period=DAY&accumulate=False&offset=0&dayViewResolution=QUARTER-HOUR_
Now it should be something like:
_https://service.wienernetze.at/sm/api/user/messwerte/bewegungsdaten?geschaeftspartner=12007xxxx&zaehlpunktnummer=AT0010000000000000001000006xxxxxx&rolle=V002&zeitpunktVon=2024-11-09T23%3A00%3A00.000Z&zeitpunktBis=2024-11-10T22%3A59%3A59.999Z&aggregat=NONE_
The response ("values") is different as well
Does anyone have/work on a fix ??
regards
Gerhard
PS: ... still analyzing .....

i confirm API changed since 2024-11-06. I tried, but can't fix the code myself.
@platysma Is it possible to fix the library for the changed API?

I modified "vienna_smartmeter.py" to work for my purposes (testing is ongoing)
viennasmart_meter_GH.py.txt
modifications are only in
def verbrauch_raw(self, date_from, date_to=None, zaehlpunkt=None, rolle=None)
def verbrauch(self, date_from, date_to=None, zaehlpunkt=None, rolle=None)
old code is left in but commented out
modifications are:

base_url ="https://service.wienernetze.at/sm/api"
endpoint = "/user/messwerte/bewegungsdaten"
query = {
"geschaeftspartner": customerid,
"zaehlpunktnummer": zaehlpunkt,
"rolle": rolle,
"zeitpunktVon": self._dt_string(date_from),
"zeitpunktBis": self._dt_string(date_to),
"aggregat": "SUM_PER_DAY",
}

rest is unchanged --> and untested (e.g. methods for reading profile, zaehlpunkte work - but I did not use/test e.g. "consumptions", "pmaxReadings" .... and so on)
FYI: "rolle" is supplied only when I want to read my PV-Einspeisung data on a 2nd Zaehlpunkt
usage will be then:    sm_einspeisung = api.verbrauch(a, zaehlpunkt=zp_einspeisung, rolle="E002")
please note: response json changed as well -> now "values" is:
"values": [
{
"wert": 7.233,
"zeitpunktVon": "2024-11-03T23:00:00Z",
"zeitpunktBis": "2024-11-04T23:00:00Z",
"geschaetzt": false
},
...
Please see some analysis in the following text file
viennasmartmeter analysis req-response.txt
or use "developer extensions" e.g. in Chrome
Please use the modifications as you like ....
best regards
Gerhard

https://github.com/user-attachments/files/17718424/viennasmart_meter_GH.py.txt

Works! Thanks!