Full SDXL Model

This PR contains the full implementation of Stable Diffusion XL (SDXL). SDXL uses two text encoders/tokenizers and also takes crop & size parameters from the dataloader as conditioning - a majority of the changes here are for supporting that.
A high-level description of the changes for each file:
diffusion/datasets/image_caption.py

Added rand_crop flag to choose between LargestCenterSquare & RandomCropSquare - previously only center cropping was supported. This is relevant to SD2 if one might want to train with random cropping, but doesn't apply to SDXL
Infer whether or not we're doing SDXL training by the tokenizer_name_or_path
Use RandomCropSquareReturnTransform for SDXL, which returns the cropping parameters used as well as original image size (for training SDXL with micro-conditioning) and return micro-conditioning as part of the training batch
Add option to do micro-conditioning dropout (by setting microcond_drop_prob flag). This is not discussed in the SDXL paper but is reflected in Stability AI's implementation
Small changes necessary for using SDXLTokenizer

diffusion/datasets/laion/transforms.py

Implementation of random cropping
RandomCropSquare (does random crop only) and RandomCropSquareReturnTransform (does random crop and returns crop params)

diffusion/models/layers.py

Contains attention processor classes for QKV clipping
Contains zero_module function used in SDXL init

diffusion/models/models.py

Add option to do QKV clipping for both SD2 and SDXL (clip_qkv argument)
For SDXL, instantiate SDXLTokenizer and SDXLTextEncoder which contain the two tokenizers/text encoders but mostly can be used as if they are one tokenizer/text encoder
For SDXL, do zero init trick

diffusion/models/stable_diffusion.py

Pass sdxl flag to StableDiffusion to indicate if we are training an SDXL model
Set appropriate latent_scale for SD2 vs. SDXL
Extract pooled_conditioning from SDXL text encoder, which is used in micro-conditioning
Construct micro-conditioning dict and pass it to the UNet forward call
In StableDiffusion.generate(...), allow user to pass crop_params and size_params for SDXL micro-conditioning, otherwise set them to reasonable default values
In StableDiffusion.generate(...), new flag called zero_out_negative_prompt that zero's out the negative prompt if it is empty (rather than tokenizing and encoding the empty string). This was added to match the behavior of the diffusers StableDiffusionXLPipeline and in general this just seems like a good thing to do. Note: I set the default value to be True, so this means previously made generations (e.g. with SD2) will look different despite using the same prompt/seed. Obviously can set it to False to match previous results.

diffusion/callbacks/log_diffusion_images.py

Edits to support multiple tokenizers

setup.py

Pin diffusers version to 0.21.0 - this is necessary because attention processor implementations are tied to this version

There are a few remaining things I'd like to add, but this is already a big enough PR. I will add the following once this one is merged in:

Zero-ing out dropped captions rather than tokenizing/encoding the empty string during training (this can apply to SD2 training as well)
Adding a CenterCropSquareReturnTransform transformation that can be used for COCO eval. Currently with SDXL training we do random crop for the eval dataset as well
Allow user to pass different prompts to the different text encoders in SDXL inference

why we need to clip qkv


backports from master (part 2)

#2678 - fd4df0f
#3926 - eaa9b78
#3627 - a21fb63
#3563 - 7a5aa06
#3357 - 044de41
#2939 - aad95c7
#2337 - 901d499
own fix - d9b7b30:
fixxed qt opengl example in 2.4 with 83c3363 see discussion http://stackoverflow.com/questions/4981583/problems-with-setting-up-opengl-and-visual-studio-2010

@StevenPuttemans maybe you can look over this aswell :)

@Dikay900 I would love too, but I am drowning in work, hobbies, house building, writing OpenCV books, ... I am sure that you will make it work. I will have a look from time to time. If you have questions, do ask them and I will jump in!

Checked them all, seem all legit fixes :)

If you got no time, i do not want to force anything. Thank you. :)

:+1:


swa deploy fails in Bazel

Describe the bug
I am trying to move the swa deploy command to Bazel. But I consistently get an unknown error.
Everything works without Bazel.
I suppose it could be related to the strict path to binary folders. But I am not fully sure about it.
It looks like the issue happens during creating a child process.
To Reproduce

Setup calling swa cli as binary in Bazel config. Like this:

swa_bin.swa_binary(
    name = "release",
    args = ["deploy"],
    data = ["/.out"],
    env = {
        "SWA_CLI_OUTPUT_LOCATION": "./out",
        "SWA_CLI_DEPLOY_ENV": "production",
    },
    chdir = native.package_name(),
)

Call bazel run release

Screenshots
With Bazel:

Without:

Desktop (please complete the following information):

OS: MacOS
Version 14.5

I investigated it. This issue happened in a binary. If I understood correctly, binaries are not in open source - I can't exactly understand what happened. Probably it could be related to writing from the subprocess to output folder.

Is it possible to show some additional logs from the binary?


Remove separate FullPackages and Hotfix directories

Directories are now removed in Init script. New directory called TelligentPackages.

Removed hotfix support in main install function. Left function to apply hotfix intact.

Fixed by #17


Refactor per-pkg into high-level Module

Module takes in whatever params it needs and spits out an API for that Module (with methods defined by this ADR https://github.com/celestiaorg/celestia-node/pull/506)
One PR for every package

#997 closed this


Recognizers not working when update dependencies

When update dependencies, recognizers not return any results:
List of dependencies to update:
Microsoft.Extensions.Caching.Abstractions v3.1.6 (installed 2.2.0)
Microsoft.Extensions.Caching.Memory v3.1.6 (installed 2.2.0)
Microsoft.Extensions.DependencyInjection.Abstractions v3.16 (installed 2.2.0)
Microsoft.Extensions.Options v3.16 (installed 2.2.0)
Microsoft.Extensions.Primitives v3.16 (installed 2.2.0)
System.ComponentModel.Annotations v4.70 (installed 4.5)
System.Runtime.CompilerServices.Unsafe v4.71 (installed 4.5.3)
If don't update dependencies, recognizers work ok.

Platform: [.NET]
Environment: [nuget package]
Version of package [v1.4.0]
IDE: [Visual Studio 2017]

Do you see any errors? Unfortunately this update is not currently planned in the main repo as it introduces downstream breaking changes. So we won't be able to look into it.


The deployment is failing for what appears to be no reason

Does this occur consistently?
Repro steps:

Action: appService.Deploy
Error type: Error
Error Message: Failed to get status of deployment.
Version: 0.18.0
OS: darwin
OS Release: 19.4.0
Product: Visual Studio Code
Product Version: 1.46.1
Language: en

Call Stack
Object.<anonymous> extension.bundle.js:164:515775
rejected extension.bundle.js:164:515202
processTicksAndRejections task_queues.js:85:5

Please provide repro steps.

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.
Happy Coding!


Green job when kaniko fails

When kaniko fails (e.g. bad creds) the job is marked green after around 10 minutes.
Expected to never go green and keep retrying.

Was fixed as part of #18


added datetime try/catch

@grendel513 temporary solution until I can trace down the inconsistency

https://travis-ci.org/devGregA/django-DefectDojo


Exception OnRestoreInstanceState (sometimes)

Hi,
From some users I get the attached error message.

It seems as a problem in the control?
(Android).

@magtimmermans where is sample project and steps to reproduce the issue?

Hi,
Well that's the problem, I cannot reproduce it but it happens to a number of users. I have talked with a few the users and it seems not consistent. It happens when entering the activity with the slider control on it. But not always. I have tested for memory issues, different os versions, rotation of the device. I had only one time this exception. It is only on Android.

@magtimmermans are you sure you pass correct IParcellable into the method? You should only use value received from the control's OnSaveInstanceState method.

Should be fixed in 0.8.1


ModuleNotFoundError: No module named 'core'

Hi,
Was trying to test your package but I keep getting the error ModuleNotFoundError: No module named 'core' when I try to import the extractor.
Any ideas?

I am also receiving the same error!

Hey all, thanks for reporting this issue. I assume this you installed the package via pip. Can you confirm?
I'll issue a fix soon this week when I find time. Thanks again!

Yes, I installed it using pip

Hey all, thanks for reporting this issue. I assume you installed the package via pip. Can you confirm?
I'll issue a fix soon this week when I find time. Thanks again!

Hey all, thanks for reporting this issue. I assume you installed the package via pip. Can you confirm?
I'll issue a fix soon this week when I find time. Thanks again!

yes, I also installed via pip.

Hey all, thanks for reporting this issue. I assume you installed the package via pip. Can you confirm?
I'll issue a fix soon this week when I find time. Thanks again!

Hey Jake, thanks again for looking into this! Also just wanted to say this is a very cool package and I'm excited to try it out :)
I'm just wondering whether this issue could be resolved by removing the imports within the init.py file? The Extractor could then be imported with
from wordwise.core import Extractor

which is slightly less pretty, but might work more simply when the package is installed from PyPI. (I am not sure if this will resolve the issue btw - just a suggestion!)
I would be happy to submit a PR with these suggestions if that is OK with you?

Thank you everyone for filing this issue and even suggesting fixes! It's been a while since I last touched this repository, so I thought I'd come back to it and take the time to figure out what is going on with the imports.
The issue, as @xesaad suggested, was trivial. So when I cloned the repository from scratch and tried importing the module, everything worked as expected. This told me that there was a mismatch between the master branch and the pip release. All I had to do was issue another pip release with the current master (I also shipped some minor refinements along the way).
If you run
pip install wordwise==0.0.4

the package should now work as expected. But please do let me know again if you find anything funky.

Thank you everyone for filing this issue and even suggesting fixes! It's been a while since I last touched this repository, so I thought I'd come back to it and take the time to figure out what is going on with the imports.
The issue, as @xesaad suggested, was trivial. So when I cloned the repository from scratch and tried importing the module, everything worked as expected. This told me that there was a mismatch between the master branch and the pip release. All I had to do was issue another pip release with the current master (I also shipped some minor refinements along the way).
If you run
pip install wordwise==0.0.4

the package should now work as expected. But please do let me know again if you find anything funky.

Thanks @jaketae for the explanation of what was going wrong, and for issuing a new release! Looking forward to trying out this package :)


Michael dratch/712 error message if map fails to load

This PR is for this task: Show error message if map fails to load #712
https://github.com/CodeForPhilly/clean-and-green-philly/issues/712
To view the error state go to the find properties page, open dev tools, and block the URL from google storage to simulate a failed API call.

On page reload, this error message will be displayed on the property details panel.

I think the automatic prettier formatting makes it seem like a lot of lines of code have been changed. But most of these lines are minor changes in formatting. If it would be better for the PR I can redo do these changes with out any of the formatting changes and resubmit.

Hi @CodeWritingCow, thanks for the feedback. I just made those requested updates and pushed the changes.


Add favourites api endpoint

Hey, this adds the endpoint in the API to fetch favourites.
I'm still trying to get the workflow of takahe's model/service/view so if I misplaced something just let me know :slightly_smiling_face:

Another thing was that I named it as favourites to match the expected mastodon API, but we can rename internal functions the way it works best

Also tested it with both Megalodon and Tusky apps :slightly_smiling_face:

Thanks for this!


Fix production image compilation

Remove Circle CI cache as it’s causing NIF to fail to load.
Simplify .circleci/config.yml by using short form for run:
Simplify .circleci/config.yml by splitting long scripts into an actual script file.
Use make docker in CI so we have consistent way to build Docker image.
Improve conditional CI steps using ENV var detection instead of CIRCLE_PROJECT_USERNAME.

Note that removing cache cause the build to take longer, but it should result in a more predictable builds (due to no more randomly failed NIFs loading). Some timing statistics:
With cache:

without E2E: ~6m
with E2E: ~18m

Without cache:

without E2E: ~8m
with E2E: ~20m

I’ll cherry-pick this to 1.2


[FEATURE] Raise errors for HTTP error codes in the generic client

Is your feature request related to a problem?
Coming from https://github.com/opensearch-project/opensearch-java/pull/910#issuecomment-2043122739 I propose we raise errors on non-2xx error codes from the server for the generic client just like in the rest of the java client.
What solution would you like?
Currently:
// compare with what the low level client outputs
try (Response response = javaClient().generic().execute(...)) {
   if (response.getStatus() != 200) {
      // Request was not successful
   }
}

Proposed:
// compare with what the low level client outputs
try (Response response = javaClient().generic().execute(...)) {
   // response.getStatus() is always 2xx
} catch(GenericException e) {
  // e.response is a Response
  // e.getStatus() != 2xx
}

What alternatives have you considered?
// compare with what the low level client outputs
try (Response response = javaClient().generic().execute(...)) {
   response.checkErrors() // raises when not 2xx
}

Do you have any additional context?
Let's discuss/implement/close/reject this issue before https://github.com/opensearch-project/opensearch-java/issues/926

@reta

@dblock I would really want to understand why we should do that, in particular what would be the reason to use generic HTTP client vs typed client - if both would do the same thing? (at least with respect to exception handling). We should not forget that, if we decided to pursue this path, the exception should include the response body + status (at least), otherwise we are missing important details.

Users have asked for a generic client because they can invoke APIs that don't have higher level client support yet, not for more control of error handling.
It's less code (easier) to use a client that handles errors for the users.
Users will be surprised by the fact that the generic client doesn't behave the same way as the non-generic client.
Users that want to handle errors in specific ways will be fewer than users that don't, and those who do can catch and handle errors the way they want.
As is one cannot easily mix code that uses a generic and a non-generic client because the generic client requires special error handling.
All other generic clients in opensearch-py, etc., behave the same way as the non-generic versions of those clients as far as error handling is concerned.

the exception should include the response body + status (at least), otherwise we are missing important details.

I think the exception should include the entire .response the same as the response currently returned.

Fair points, thanks @dblock,  I think we could accommodate both favours while building the client, very roughly something like that:
javaClient().generic(Options.throwOnHttpErrors())

Fair points, thanks @dblock, I think we could accommodate both favours while building the client, very roughly something like that:
javaClient().generic(Options.throwOnHttpErrors())

Yes, it's certainly acceptable! That's my alternate option. It's still not my preferred, but I would be ok with it. Want to try to PR it?

I fully admit I may be in the minority here.

We are :D  But it is good to provide options ....


Fix in_tx_dbver

Looks like we had in_tx_dbver since 2021 but never really used it. The added test demonstrates an issue where we cached a query under the wrong dbver in a transaction, and caused ISE in later calls.

@fantix, I'm not able to backport this.
In the test, the last query fails with missing column too. See back-ported commit 7dc2b35a9.
I've tried first backporting #6819, but it's test is failing too.
Is this fixable, or do we just don't backport it?


Update start.sh

Added riscv64 support here as well.

Type of Change

[X] New feature
[ ] Bug fix
[ ] Documentation update
[ ] Refactoring
[ ] Hotfix
[ ] Security patch
[ ] UI/UX improvement

Description
In order for the utility to work on all cpu's we need to add support for riscv64.
Testing
No testing has been done since this is a WIP.
Impact
No known impacts that I know of.
Issues / other PRs related
No issues.
Additional Information
No additional information.
Checklist

[X] My code adheres to the coding and style guidelines of the project.
[X] I have performed a self-review of my own code.
[ ] I have commented my code, particularly in hard-to-understand areas.
[ ] I have made corresponding changes to the documentation.
[ ] My changes generate no errors/warnings/merge conflicts.

This doesn't work that way. You need to set up cross compilation workflows and dependencies and test it of course.

This doesn't work that way. You need to set up cross compilation workflows and dependencies and test it of course.

I would test it if I had that cpu architecture, but lets leave it as is for now and someone can make the proper changes to it.

Close the PRs then and open an issue.


FR + crystal ball = crash

The miniature crystal ball wants to go to FantasyRealm, and can't.

Executing Keys/Fantasy [Route]
Putting Sue Perdue, plicator goo the Grey Goose back into terrarium...
You have no familiar with you.
Possible mafia desync detected; refreshing...

This should be fixed now, but please reopen if this is still happening.


Notes:

missing hover, focus, and active styles

i believe this was fixed when we downgraded the sass version


Please set master to swift 3 :D

Any reason why we master in still in swift 2.3?

Hi @gperdomor,
I suppose that you are talking about the Carthage configuration?
The rationale behind the current setup can be found in the comments of #192
Moving to swift 3 would require to keep a swift 2.3 compatibility anyway as the swift version is not enforced "yet". It should be soon when Xcode will drop the support for it.
Because of that, maybe it is better to keep things as-is for now and drop support of 2.3 altogether once Xcode stops supporting it.
Are you having a specific issue with this current setup? 😊

Hello @Liquidsoul,
Yes, there is an issue here when you integrate this library using Carthage, since Carthage will use the project's xcodeproj to create a framework, and currently the project is set to compile with Swift 2.3 check it here.
In order to get this working with Carthage you'd have to fork it and change this value to 3.0which is less than ideal.
Since Swift 2.3 is closer and closer to deprecation (Xcode 8.3 release could be less than a month away) I think it's safe to set Swift 3 as the default for this project.
Thanks!

Hi @piercifani,
We made things so you should not need to fork the repository to use Carthage and Swift 3.0.
As stated in the carthage part of this section, all you need to do is specify the swift-3.0 branch in your Cartfile and you should be good to go 😃
As Xcode 8.3 is coming soon, maybe it is a good time to work on the Swift 2.3 to Swift 3.0 migration of the project.

I forgot that you can also use dedicated releases for the library which have the -swift3 suffix like here for the latest one, and previous ones are available too!

oops... sorry, I didn't catch that! Thanks a lot!

Note that I think in a near future we will indeed make Swift3 the default (and keep Swift2.3 releases for people having legacy projects), as Swift3 is indeed now the default for most people and 2.3 is dropped with Xcode 8.3 anyway.
I just won't do a release just for that, but will wait until there's something to release to do that for the next version.

Today is the day! 🥁🎉

I think we can finally close this 🍾🎉


Make destructive actions opt-in

The default behavior of map/reduce/filter is replacing files in-line. I don't want someone accidentally destroying their data.

make destructive actions opt-in (not sure how to handle this yet)
check that output is not the same prefix as the context

Yeah... I'm really glad I read the documentation first.

ok this has been addressed / published in 5.1.0

This should probably be published as 6.0.0, given that it's an API change.

@schmod Yeah I see now in npm's documentation that you should major release for breaking backwards compatibility. That's my bad, but I already released it. Should I go ahead and release 6 you think?


Add guidance on how to write Accessibility Acceptance criteria

We would like to add guidance to GOV.UK Frontend on how to write Accessibility Acceptance criteria for components.
The criteria for Accessible Autocomplete could provide a basis for this.

Reopening as this wasn't done as part of alphagov/govuk-design-system#677

Closing this issue as it's been superseded by #1781.


run: add --cap-retain and --cap-remove

This adds the isolators os/linux/capabilities-retain-set or
os/linux/capabilities-remove-set respectively.
Examples of usage:
sudo rkt run docker://ubuntu --cap-retain=CAP_KILL,CAP_NET_ADMIN --exec sh  -- -c 'capsh --print'
sudo rkt run docker://ubuntu --cap-remove=CAP_MKNOD,CAP_SYS_CHROOT --exec sh  -- -c 'capsh --print'

It is not allowed to specify both --cap-retain and --cap-remove on the
same image.
Both flags will override any existing capability isolator from the ACI.
The override also happens on a capability isolator of a different type.
For example, if the image had os/linux/capabilities-retain-set, using
cap-remove will remove it even if --cap-remove refers to
os/linux/capabilities-remove-set.

@lucab  PTAL
TODO:

[ ] add the flags in the documentation
[ ] update Capabilities Isolators Guide
[x] tests

@alban this seems to allow stacking caps-isolators, but I think we'd like to have an overriding behavior here instead.

this seems to allow stacking caps-isolators, but I think we'd like to have an overriding behavior here instead.

@lucab You're right. I fixed this. I'll add tests now.

UX/design question: we will probably need something similar to opt-out multiple security defaults that we are putting in (caps, procfs, seccomp, no-new-privs). Should we maybe decide a generic approach here? Do we have to expose CLI knobs to tune each of those (ie, custom caps list, custom seccomp list, etc) or just some generic opt-out options (--insecure-options no-secomp, allow-new-privs, no-protect-procfs, unbounded-caps)?
/cc @coreos/rkt-maintainers for UX design directions

--insecure-options is a global option, so using --insecure-options would not allow a pod with multiple apps to have different parameters for each app.
Another UI question: actool patch-manifest already has --capability= and --revoke-capability=. And this patch introduces --cap-retain and --cap-remove for the same isolators. How should the rkt flags be named? Should I take the same naming as in actool patch-manifest, or should we make the retain/remove more explicit?
/cc @robszumski

--insecure-options is a global option, so using --insecure-options would not allow a pod with multiple apps to have different parameters for each app.

I still have to ponder on this a bit more, but for a generic opt-out I think it is ok (allows for quick debugging when pinpointing issues, is a global override, is easy to spot during operational audits).
Caps are borderline here, as I can imagine some cases where one may want to fine tune them on the command line, but I guess other cases like seccomp are better handled via manifest patching. Maybe we can met in the middle and pass (JSON?) files here instead of plain values?

Should I take the same naming as in actool patch-manifest, or should we make the retain/remove more explicit?

I also find this confusing when working on seccomp. It looks like so far we have mixed: revoke, remove, remain, retain and no-verb. I'd suggest to stick to the retain/remove dicotomy and get rid of everything else (via CLI aliases where needed).

I'd suggest to stick to the retain/remove dicotomy and get rid of everything else (via CLI aliases where needed).

This seems ok to me, but I didn't give it a ton of thought

What's the status of this one?

From my side, this is blocked on revoke/remove/remain/retain unification. Also, some inputs regarding the UX discussion are welcome. One question directly related to this PR is: should caps (later seccomp and more, perhaps) list be provided on the command-line, or within some JSON file?

I would prefer if caps, seccomp, etc. could be provided both in the ACI and on the command line: that makes it easier for users to try different things without rebuilding the image.

I switched the messages and comments to retain & remove.
But I kept using the flags actool patch-manifest --capability=/--revoke-capability= since that comes from the appc/spec's actool. I also kept types.LinuxCapabilitiesRevokeSet because that also comes from appc/spec.

Looks fine now. Test failure on debian seems to be unrelated. Some aspects here will also need some clarification in specs, see https://github.com/appc/spec/issues/625. I see that in the end consensus is for the whole arguments list on the command-line.

Thanks!


Dataframe display

This is less a feature request than a question:

I cannot reproduce the dataframe display shown in README (and below) - which is the same as in python-polars. Is it still possible ? else why not ?

the display of a dataframe in a deno-kernel jupyter notebook is fine and similar to that of a python-kernel notebook except (by default):

the first and last rowns are displayed (for large df)
the shape is displayed on top

But for nodejs-polars only the 50 first rows are shown without indication of df shape.
Is it on purpose or a shortcut ?
Suggestion: If would help users if the py/js displays both in print/console.log and jupyter would match.

It does look like repr_html on the python side has quite a bit more logic than the JS side.
It should be pretty easy to copy over the python html logic.

I cannot reproduce the dataframe display shown in README (and below) - which is the same as in python-polars. Is it still possible ? else why not ?

It works fine for me using nodejs-polars v. 0.14.0, can please show your code and the output?
deno-kernel jupyter notebook shows the first 50 rows in order to not crash the browser with large output, but it's configurable using: process.env.POLARS_FMT_MAX_ROWS, this was discussed during the PR review.

I cannot reproduce the dataframe display shown in README (and below) - which is the same as in python-polars. Is it still possible ? else why not ?

It works fine for me using nodejs-polars v. 0.14.0, can please show your code and the output?

Here is the output from notebook, jupyter console and terminal.
1/ notebook

2/ jupyter console

3/ terminal

In neither of these cases I can reproduce the nice display shown in the README, which happens to be smilar to that of the python version print(df).
What should I do to have it ?

I am not using Deno but using bun command line it works fine.

Ok, here is what i get with bun repl:

So the output contains what is shown in the README nice display but it is not quite the same.
I find it a bit disconcerting that such basic use is not reproducible on either deno or bun repl.

Can you please use: console.log(df); in bun repl? It works fine for me. I do re-call being an issue with bun implementation for [Symbol.for("nodejs.util.inspect.custom")]().
> console.log(df);
shape: (5, 4)
┌─────┬────────┬─────┬────────┐
│ A   ┆ fruits ┆ B   ┆ cars   │
│ --- ┆ ---    ┆ --- ┆ ---    │
│ f64 ┆ str    ┆ f64 ┆ str    │
╞═════╪════════╪═════╪════════╡
│ 1.0 ┆ banana ┆ 5.0 ┆ beetle │
│ 2.0 ┆ banana ┆ 4.0 ┆ audi   │
│ 3.0 ┆ apple  ┆ 3.0 ┆ beetle │
│ 4.0 ┆ apple  ┆ 2.0 ┆ beetle │
│ 5.0 ┆ banana ┆ 1.0 ┆ beetle │
└─────┴────────┴─────┴────────┘

Can you please use: console.log(df); in bun repl? It works fine for me. I do re-call being an issue with bun implementation for Symbol.for("nodejs.util.inspect.custom").

I get the same output!
It would be good that nodejs:polars be explicit about what runtimes should implement to output the proper display (as in README). Maybe this is already the case ? If so where ?

Can you please use: console.log(df); in bun repl? It works fine for me. I do re-call being an issue with bun implementation for Symbol.for("nodejs.util.inspect.custom").

I get the same output!
It would be good that nodejs:polars be explicit about what runtimes should implement to output the proper display (as in README). Maybe this is already the case ? If so where ?

@oscar6echo The formatting discrepancy is because we need to use a Proxy object to support some syntaxes such as df['column'] and df['column'] = df['column2'].
console.log should always print the correct output as most runtimes have standardized on using Symbol.for("nodejs.util.inspect.custom"), but unfortunately, there is no way to forward the inspect symbol to the dataframe class when wrapping it in a proxy. So it's either drop support for the functionality that the proxy provides, or use console.log.

@universalmind303 thx for the insight.
So the working syntax with deno is console.log(df.toString()).
Maybe a bit verbose but output identical to python version. This is useful info !
Examples:
1/ small df

2/ larger df

so we need to use a Proxy object to support some syntaxes such as bracket notation: df['column']

Ok this is your decision - who am I to debate it - but the .select() syntax achieves the same, is central is polars-py, and more IDE friendly with completion etc. The df['mycol'] syntax seems mostly a contrived way to mimick pandas legacy API - I was a heavy pandas user and now an intensive polars-py one. One may argue this legacy API may not be worth keeping, in particular if it hinders basic user experience. :thinking:
But this is only a side remark.
The main point is: Congrats and thank you for putting together and maintaining nodejs-polars :+1:

Ok this is your decision - who am I to debate it - but the .select() syntax achieves the same, is central is polars-py, and more IDE friendly with completion etc. The df['mycol'] syntax seems mostly a contrived way to mimick pandas legacy API - I was a heavy pandas user and now an intensive polars-py one. One may argue this legacy API may not be worth keeping, in particular if it hinders basic user experience. 🤔

I have thought about deprecating the syntax as I too find the Proxy stuff a bit annoying. I know py-polars discourages the usage of it anyways.


User Search API

Need an API for searching users:

Search by username
Search bu studentId
Search by email (optional, useful for normal use cases)
limit result to 5, do not support pagination

We can add some filters in find domain users

We added two endpoints in #61:

GET /api/v1/users for site admin to view all users. This API do not have any restriction on search query and pagination
GET /api/v1/domains/{domain}/candidates for domain admin to search candidates. This API have a hard pagination limit that only the first 10 results are shown, the length search query must also be at least 2.


Integrate streams from redis 5 as a adapter

Intro to redis streams: https://redis.io/topics/streams-intro

Found that streams is complicated concept for our project. That's why we will change nothing


Docker hub

Can you add to docker hub for fast setup?

I'm not sure why that would be needed.  Storrent is just a single binary, how is it simpler to deploy using Docker than just launching a binary?

I could add a docker file, so that you can then do what you want from there to build any docker image to and docker container hub.

I do not use docker, sorry.


t.comment with a multiline string only comments the first line

Seems bad...

And it trims away any leading whitespace, also bad.

That seems intentional, given the regex + call to a (possibly polyfilled) String.prototype.trim.

Would be nice if leading whitespace wasn't trimmed; since the TAP spec ignores comments inline YAML could easily become a thing.

@impinball I know that's the current behavior. I think it's bad behavior.

I agree. That's what I was saying. It's surprising.
On Mon, Oct 5, 2015, 12:51 Domenic Denicola<EMAIL_ADDRESS>wrote:

@impinball https://github.com/impinball I know that's the current
behavior. I think it's bad behavior.
—
Reply to this email directly or view it on GitHub
https://github.com/substack/tape/issues/196#issuecomment-145596600.

This bothers me too... wouldn't something like the following snippet be enough to fix this? https://gist.github.com/idrarig/0671a2bde238120214c5

Not sure what the correct behaviour should be or how to make this change without breaking back compat.
If anyone wants to suggest a fix or reference the TAP spec that would be helpful.

the new line split seems reasonable to me. Someone can throw it up as a PR if they want.

I agree - I think anything passed into t.comment should be commented out - ie, the new line split, prior to trimming each line, seems like reasonable behavior.

I'd be happy to make a PR then! I was looking for the right place to add a test case, and found no tests for the comment method, I'm just wondering if there a reason for that?/whether I should in fact include test code in the PR.

@idrarig yes please do include test code :-) if there's no existing tests for t.comment, also please feel free to create them. thanks!

Okay, I took a stab at it :).
BTW, I also agree with @domenic that it's not okay to trim whitespace, especially, but not only, when printing a multiline comment, such as pretty printed JSON...

This appears to be fixed. Should this issue be closed?

Hi, I also think that it would be good if t.comment(...) does not trim the message (useful for pretty printed JSON as @idrarig said). If it is not against the spec of course.


Java binary fails to deploy as Snap with current base + template

With this snap Gradle config:
      snap {
            active.set(Active.RELEASE)
            // Redundant downloadUrl temporarily required. See https://github.com/jreleaser/jreleaser/issues/699
            downloadUrl.set("https://{{repoHost}}/{{repoOwner}}/{{repoName}}/releases/download/{{tagName}}/{{artifactFile}}")
            remoteBuild.set(true)
            localPlugs.add("network")
            architecture {
                buildOn.add("amd64")
            }
        }

snapcraft.io failed to build:
...
+ snapcraftctl pull
Downloading 'kobweb-0.9.2.tar'   0%
Downloading 'kobweb-0.9.2.tar' 100%
[26/Jan/2022:02:10:05 +0000] "CONNECT github.com:443 HTTP/1.0" 200 6329 "-" "-"
[26/Jan/2022:02:10:05 +0000] "CONNECT objects.githubusercontent.com:443 HTTP/1.0"<PHONE_NUMBER>7 "-" "-"

Running build phase...
Skipping pull kobweb (already ran)
'usr/lib/jvm/java-11-openjdk-amd64/lib/security/cacerts' will be a dangling symlink
Building kobweb
+ snapcraftctl build
+ cp --archive --link --no-dereference . /build/kobweb/parts/kobweb/install
Staging kobweb
+ snapcraftctl stage
Priming kobweb
+ snapcraftctl prime
Failed to generate snap metadata: The specified command '$SNAP/bin/kobweb' defined in the app 'kobweb' does not exist.
Ensure that '$SNAP/bin/kobweb' is installed with the correct path.

When I set the base to "core18" however, it worked and released:
+ snapcraftctl pull
Downloading 'kobweb-0.9.2.tar'   0%
Downloading 'kobweb-0.9.2.tar' 100%
[26/Jan/2022:02:24:03 +0000] "CONNECT github.com:443 HTTP/1.0" 200 6330 "-" "-"
[26/Jan/2022:02:24:03 +0000] "CONNECT objects.githubusercontent.com:443 HTTP/1.0"<PHONE_NUMBER>9 "-" "-"

Running build phase...
Skipping pull kobweb (already ran)
'usr/lib/jvm/java-11-openjdk-amd64/lib/security/cacerts' will be a dangling symlink
Building kobweb
+ snapcraftctl build
Staging kobweb
+ snapcraftctl stage
Priming kobweb
+ snapcraftctl prime
Found unneeded '$SNAP/' in command '$SNAP/bin/kobweb'.
The command '$SNAP/bin/kobweb' has been changed to 'bin/kobweb'.
Snapping...
Snapped kobweb_0.9.2_amd64.snap
Revoking proxy token...
RUN: /usr/share/launchpad-buildd/bin/in-target scan-for-processes --backend=lxd --series=bionic --arch=amd64 SNAPBUILD-1654311
Scanning for processes to kill in build SNAPBUILD-1654311

Expected behavior:
Whatever default the base value is, the template should work with it.

Also, when I run kobweb on Linux, I'm getting this error:
 $ kobweb

ERROR: JAVA_HOME is set to an invalid directory: /snap/kobweb/1/usr/lib/jvm/java/jre/

Please set the JAVA_HOME variable in your environment to match the
location of your Java installation.

It's not just kobweb, though. jreleaser is doing it too:
$ jreleaser

ERROR: JAVA_HOME is set to an invalid directory: /snap/jreleaser/73/usr/lib/jvm/java/jre/

Please set the JAVA_HOME variable in your environment to match the
location of your Java installation.

When I go to /snap/kobweb/1/usr/lib/jvm and do an ls, I see this:
/snap/kobweb/1/usr/lib/jvm
 $ ls
java-1.11.0-openjdk-amd64@  java-11-openjdk-amd64/

It seems like there should be a symlink in there, java, pointing at java-11-openjdk-amd64

I've run into issues at this point with strict mode, which is not jreleaser's fault, so I'm not done yet with snap, but at least my template changes seem to be working with core18:
...
apps:
  {{distributionExecutable}}:
    command: bin/{{distributionExecutable}}
    environment:
      JAVA_HOME: "$SNAP/usr/lib/jvm/java-{{distributionJavaVersion}}-openjdk-${SNAP_ARCH}/"
      PATH: "$SNAP/bin:$PATH:${JAVA_HOME}/bin"
    {{#snapHasLocalPlugs}}
    plugs:
      {{#snapLocalPlugs}}
      - {{.}}
      {{/snapLocalPlugs}}
    {{/snapHasLocalPlugs}}
    {{#snapHasLocalSlots}}
    slots:
...

Removed "$SNAP" from front of command
Changed JAVA_HOME path
Changed PATH to reference JAVA_HOME to avoid the duplication

I see that the template for SINGLE_JAR distributions does make use of the organize: instruction to rename the Java path. I think this is missing form the other templates
https://github.com/jreleaser/jreleaser/blob/0b02f263a3a711a6b0dbd135c2a997456f417c85/core/jreleaser-templates/src/main/resources/META-INF/jreleaser/templates/single-jar/snap/snap/snapcraft.yaml.tpl#L81-L82


Generalised anyM, allM, orM, andM, findM, firstJustM to Foldables whi…

Writing allM f (S.toList s) gets old after a while :)
The short-circuiting behaviour is preserved in findM, so it's preserved in the functions that have been rewritten to use it.
findM could've been rewritten to use firstJustM, but then we'd have the overhead of comparing boxed up Just Bools instead of Bools - there was already some duplication in the code so I figured it's probably not worth it.

Okay, Travis caught some versioning bugs. I don't mind the #if pragmas around type signatures, but opinions differ and I'm happy to rewrite it.

FWIW, I'm in favor of the generalisation.

Generalisation sounds good to me!

Now that Data.Foldable.Extra has been merged, this seems like a great place for these functions.

@mel-brown - that sounds like the perfect answer. In general happy to take additions to the Foldable.Extra module that match things in List.Extra


move hcloud-controller-manager to addon, improve installation

This is a double PR which
1. moves hcloud-controller-manager to the addons section
So it is not installed by default anymore! This is in favor of #33 and #40. If you are going to use hcloud only nodes, run hetzner-cloud cluster addon install hcloud-controller-manager -n ... to install the manager. Note, that adding external workers won't work then.
2. moves package install routine from the script into code
This gives the progress bars a better experience and of course, mainly solves problems mentioned in #104 and #89

the failing stuff looks like a temporary travis isse, merging then


Added quadratic calculator

Fixes Issue🛠

Closes #109
Description👨💻

Added a quadratic calculator that calculates the roots of a quadratic equation
Type of change📄

[x] New feature (non-breaking change which adds functionality)

This has been tested✅

Checklist✅

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have added demonstration in the form of GIF/video file
[x] I am an Open Source Contributor

Screenshots/GIF📷
https://github.com/Rakesh9100/CalcDiverse/assets/125905089/0dac0e60-5e70-4ef0-ae56-fc71ce0d126d

Pls resolve the conflicts @saurav2208

Pls resolve the conflicts and add a README file in your calculator folder @saurav2208

Pls resolve the conflicts and add a README file in your calculator folder @saurav2208

I have done all the required changes

Add some good background the the entire screen and enhance UI @saurav2208

@saurav2208 Are you working

@saurav2208 Are you working

Yes yes I am working on it. Will be done by tomorrow.

@Rakesh9100 I have improved the UI of the page.

Good, Merged!! ✨ @saurav2208


python310Packages.ssdp: update build requirements

Description of changes
Fix build (https://hydra.nixos.org/build/215636957)

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 227774 run on x86_64-linux 1

4 packages built:

python310Packages.ssdp
python310Packages.ssdp.dist
python311Packages.ssdp
python311Packages.ssdp.dist


[Bug]: outline-dropdown has hard-coded colors

Describe the bug
The outline-dropdown component doesn't define its own color cssvars and instead is using gray and black colors:
  border-color: var(--outline-gray-400);
  background-color: var(--outline-gray-200);
  color: var(--outline-black);

Expected behavior
Sites using outline-dropdown should be able to set their own cssvars for these colors without overriding the gray and black base colors.
Ran into this when using outline-dropdown for the main menu items.
Actually, there might need to be variants to handle different color schemes.  I could see outline-dropdown being used for a simple Select list of items, which is different than using it for the menu dropdown elements.  Probably can't have a single color variable for both situations.  So similar to buttons, might need to have variants like menu or select dropdowns?

Related to this, the outline-dropdown has a hardcoded min-width of 350px that makes it difficult to use with menus that might have wider menu items.  See the IDB for an older outline-dropdown that doesn't have these issues.  Probably need some sort of width property or variant as mentioned above.


Problem using microphone in xfreerdp

Releated pull request for master:
Problem using microphone in xfreerdp
The microphone works in the client (Puppy fossapup64-9.5)!
No microphone works in the xfreerdp session. Sound (alsa) works in the xfreerdp session.
A microphone test via https://de.mictests.com/ detects the remote audio but reports during the test "The audio track is
stopped ".
The same error occurs with both variants.
/microphone
/microphone: sys: alsa
FreeRDP version 2.2.0
How do I achieve stable microphone usage in the xfreerdp session?

solved. Microphone now works in xfreerdp.
/ microphone: sys: alsa, format: 1, rate: 44100
It only works in this variant.
Can now use the microphone in video conferencing and VoIP clients.

this sounds like your version of freerdp has a compilation problem, can you add the /buildconfig output?

You have no software image scaling compiled in (required for newer RDP servers)
There is no H264 support compiled in (limits functionality quite a lot)
You have no proper audio encoder/decoder backend compiled in (FFMPEG or the different audio codecs like GSM, FAAD, FAAC, ...)

Why you need to use ALSA in your case I have no idea (using pulse myself here).
Closing as compilation issue.


Loading MAM adapters to fusion layer

Hi,
I would like to ask how exactly should be adapters loaded via "add_adapter_fusion()" method with MAM config? When i pass inside Fuse("adapter1_name", "adapter2_name") i get error "not enough values to unpack (expected 2, got 1)". As far as i understand the "add_adapter_fusion" requires two elements which refers to prefixTuning and Parallel  config. But how exactly pass It correctly?

Hi @ujo142, unfortunately, MAM adapters currently don't support adapter compositions such as AdapterFusion. Currently, you can only use AdapterFusion with bottleneck adapters such as PfeifferConfig() or HoulsbyConfig(). We're considering to expand the support for composition blocks in the future.

This issue was closed because it was stale for 14 days without any activity.


Possible to change expansion key?

I use Ultisnips in nvim and had my ultisnips expand trigger set to "ht" when typed consecutively (using dvorak). Is it possible to change the trigger rather then using TAB?
i.e.
let g:UltiSnipsJumpForwardTrigger		= 'ht'	" use ht to jump forward a trigger
let g:UltiSnipsExpandTrigger			= 'ht'	" use ht to expand snippets
let g:UltiSnipsJumpBackwardTrigger	= 'th'	" use th to jump backward a trigger

Sure, this can be considered for a future release. Any PRs are also welcome.

Awesome plugin, extremely useful for math/cs students so thank you very much :)
The option to change the expand trigger key from the hotkeys menu would be the icing on the cake.
I don't know js but how possible is it to have a default expand key and have the option to override it per snippet?
({trigger: ..., replacement: ..., options: ..., key: ...})


nested exception is java.lang.NoSuchMethodError: org.apache.dubbo.config.spring.beans.factory.annotation.ReferenceAnnotationBeanPostProcessor.setClassValuesAsString(Z)V

Exception encountered during context initialization - cancelling refresh attempt: org.springframework.beans.factory.BeanCreationException: Error creating bean with name 'referenceAnnotationBeanPostProcessor': Instantiation of bean failed; nested exception is org.springframework.beans.BeanInstantiationException: Failed to instantiate [org.apache.dubbo.config.spring.beans.factory.annotation.ReferenceAnnotationBeanPostProcessor]: Constructor threw exception; nested exception is java.lang.NoSuchMethodError: org.apache.dubbo.config.spring.beans.factory.annotation.ReferenceAnnotationBeanPostProcessor.setClassValuesAsString(Z)V

Please check the dependency named "com.alibaba.spring:spring-context-support" whose version should be 1.0.11 and above.
<dependency> <groupId>com.alibaba.spring</groupId> <artifactId>spring-context-support</artifactId> <version>1.0.11</version> </dependency>

useful

Please check the dependency named "com.alibaba.spring:spring-context-support" whose version should be 1.0.11 and above.
<dependency> <groupId>com.alibaba.spring</groupId> <artifactId>spring-context-support</artifactId> <version>1.0.11</version> </dependency>

Why not post an PR to fix it?  It seems that this project is no longer actively maintained. This problem still happened today.

已经有PR修复了 https://github.com/seata/seata-samples/pull/481


black background display when app rotate

New Issue Checklist

I have read the guidelines for contributing and I understand:

[x] My issue is happening in the latest version of SideMenu.
[ ] My issue was not solved in the README.
[ ] My issue can not be answered on stackoverflow.com.
[ ] My issue is not a request for new functionality that I am unwilling to build and contribute with a pull request.
[ ] My issue is reproducible in the demo project.

Issue Description

Are you going to fix it?

nop


Install failure due to patch command not being found

brew config output
HOMEBREW_VERSION: 3.2.11-43-gb047358
ORIGIN: https://github.com/Homebrew/brew
HEAD: b047358d72c3aab060ae2aab101a1ad88c7fb132
Last commit: 8 hours ago
Core tap ORIGIN: https://github.com/Homebrew/linuxbrew-core
Core tap HEAD: 479d5fdaaa7093b030507aa2c9e3f6b21ef24a99
Core tap last commit: 9 hours ago
Core tap branch: master
HOMEBREW_PREFIX: /home/username/.linuxbrew
HOMEBREW_REPOSITORY: /home/username/.linuxbrew/Homebrew
HOMEBREW_CELLAR: /home/username/.linuxbrew/Cellar
HOMEBREW_CASK_OPTS: []
HOMEBREW_FORCE_BREWED_CURL: set
HOMEBREW_MAKE_JOBS: 88
Homebrew Ruby: 2.6.3 => /home/username/.linuxbrew/Homebrew/Library/Homebrew/vendor/portable-ruby/2.6.3_2/bin/ruby
CPU: 88-core 64-bit skylake
Clang: N/A
Git: 2.20.1 => /usr/bin/git
Curl: 7.78.0 => /home/username/.linuxbrew/opt/curl/bin/curl
Kernel: Linux 4.9.0-8-amd64 x86_64 GNU/Linux
OS: Devuan GNU/Linux 3 (beowulf) (beowulf)
Host glibc: 2.28
/usr/bin/gcc: 8.3.0
/usr/bin/ruby: 2.5.5
glibc: N/A
gcc@5: N/A
xorg: N/A

brew doctor output
Please note that these warnings are just used to help the Homebrew maintainers
with debugging if you file an issue. If everything you use Homebrew for is
working fine: please don't worry or file an issue; just ignore this. Thanks!

Warning: "config" scripts exist outside your system or Homebrew directories.
`./configure` scripts often look for *-config scripts to determine if
software packages are installed, and which additional flags to use when
compiling and linking.

Having additional scripts in your path can confuse software installed via
Homebrew if the config script overrides a system or Homebrew-provided
script of the same name. We found the following "config" scripts:
  /home/username/.local/bin/curl-config

Warning: You have uncommitted modifications to Homebrew/brew.
If this is a surprise to you, then you should stash these modifications.
Stashing returns Homebrew to a pristine state but can be undone
should you later need to do so for some reason.
  cd /home/username/.linuxbrew/Homebrew && git stash && git clean -d -f

Uncommitted files:
  ?? Library/Homebrew/shims/linux/super/patch

Warning: Your Homebrew's prefix is not /home/linuxbrew/.linuxbrew.
Some of Homebrew's bottles (binary packages) can only be used with the default
prefix (/home/linuxbrew/.linuxbrew).
You will encounter build failures with some formulae.
Please create pull requests instead of asking for help on Homebrew's GitHub,
Twitter or any other official channels. You are responsible for resolving
any issues you experience while you are running this
unsupported configuration.

[X] I ran brew update and am still able to reproduce my issue.
[X] I have resolved all warnings from brew doctor and that did not fix my problem.

What were you trying to do (and why)?
I was trying to install nghttp2 formula in order to install curl formula.
What happened (include all command output)?
The command failed due to patch command not being found.
$ brew install --verbose --debug nghttp2
Warning: HOMEBREW_NO_ENV_FILTERING is undocumented, deprecated and will be removed in a future Homebrew release (because it breaks many things)!
Warning: HOMEBREW_NO_ENV_FILTERING is undocumented, deprecated and will be removed in a future Homebrew release (because it breaks many things)!
  As a workaround, I had to symlink ~/.linuxbrew/bin/patch under ~/.linuxbrew/Homebrew/Library/Homebrew/shims/linux/super/.  I asked this in the discussion and @carlocab asked me to file this as an issue.
What did you expect to happen?
The patch command during installation should succeed.
Step-by-step reproduction instructions (by running brew commands)
`brew install nghttp2`

https://docs.brew.sh/Homebrew-on-Linux#debian-or-ubuntu
Installation instructions list build-essential as a required package on Debian-based distros. This package depends on dpkg-dev which depends on patch.

I see.  So it is my failure because patch command is not in my system.  Sorry.

Allowing brewed patch would be a reasonable feature request, given that we allow brewed gcc, curl, git and even glibc.

Yes, I was thinking patch should be part of build-essential, but I was also hoping for a better error message here.

I'm not an expert of brew and not sure if I should reopen this issue or not, so I'll leave it to you!  @Bo98 @carlocab


ART-1192: Fix RHSA creation when no severity set on the tracking bug

According to ART-1192, if a tracking bug has unspecified severity,
we need to check the severity of the flaw bugs. If all flaw bugs have unspecified severity, we will default the impact to Low (ProdSec can correct it later).
For reviewers
You can test this PR by creating an RHSA using a tracking bug with unspecified severity. For example, bug 1757044:

Without this PR:

$ elliott -g openshift-4.2 create -k image --impetus cve -t RHSA --date 2019-Nov-05 --assigned-to<EMAIL_ADDRESS>--manager<EMAIL_ADDRESS>--package-owner<EMAIL_ADDRESS>--bugs 1757044

$ elliott -g openshift-4.2 create -k image --impetus cve -t RHSA --date 2019-Nov-05 --assigned-to<EMAIL_ADDRESS>--manager<EMAIL_ADDRESS>--package-owner lmeyer@redha
t.com --bugs 1757044
User provided release date: 2019-Nov-05 - Validated
2019-10-28 09:23:59,991 INFO Data clone directory already exists, checking commit sha
2019-10-28 09:24:00,008 INFO Cloning config data from https://gitlab.cee.redhat.com/openshift-art/ocp-build-data
2019-10-28 09:24:00,836 INFO Using branch from group.yml: rhaos-4.2-rhel-7
elliott requires cached login credentials for bugzilla.redhat.com
Traceback (most recent call last):
  File "/usr/bin/elliott", line 1275, in <module>
    main()
  File "/usr/bin/elliott", line 1265, in main
    cli(obj={})
  File "/usr/lib64/python2.7/site-packages/click/core.py", line 764, in __call__
    return self.main(*args, **kwargs)
  File "/usr/lib64/python2.7/site-packages/click/core.py", line 717, in main
    rv = self.invoke(ctx)
  File "/usr/lib64/python2.7/site-packages/click/core.py", line 1137, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/usr/lib64/python2.7/site-packages/click/core.py", line 956, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/usr/lib64/python2.7/site-packages/click/core.py", line 555, in invoke
    return callback(*args, **kwargs)
  File "/usr/lib64/python2.7/site-packages/click/decorators.py", line 64, in new_func
    return ctx.invoke(f, obj, *args, **kwargs)
  File "/usr/lib64/python2.7/site-packages/click/core.py", line 555, in invoke
    return callback(*args, **kwargs)
  File "/usr/lib64/python2.7/site-packages/click/decorators.py", line 17, in new_func
    return f(get_current_context(), *args, **kwargs)
  File "/usr/bin/elliott", line 286, in create
    flaw_cve_map, impact = elliottlib.bzutil.get_flaws(bz_data, unique_bugs)
  File "/usr/lib/python2.7/site-packages/elliottlib/bzutil.py", line 42, in get_flaws
    trackers = get_tracker_bugs(bzapi, bugs)
  File "/usr/lib/python2.7/site-packages/elliottlib/bzutil.py", line 73, in get_tracker_bugs
    raise exceptions.BugzillaFatalError("Couldn't find bug with list of ids provided")
elliottlib.exceptions.BugzillaFatalError: Couldn't find bug with list of ids provided

With this PR:

elliott -g openshift-4.2 create -k image --impetus cve -t RHSA --date 2019-Nov-05 --assigned-to<EMAIL_ADDRESS>--manager<EMAIL_ADDRESS>--package-owner<EMAIL_ADDRESS>--bugs 1757044
User provided release date: 2019-Nov-05 - Validated
2019-10-28 13:24:11,176 INFO Data clone directory already exists, checking commit sha
2019-10-28 13:24:11,204 INFO Cloning config data from https://gitlab.cee.redhat.com/openshift-art/ocp-build-data.git
2019-10-28 13:24:14,023 INFO Using branch from group.yml: rhaos-4.2-rhel-7
2019-10-28 13:24:18,418 INFO Fetching bugs 1757044 from Bugzilla...
2019-10-28 13:24:20,268 INFO Fetching flaw bugs for trackers 1757044...
2019-10-28 13:24:22,231 WARNING Bug 1694935 is not a flaw bug.
Would have created advisory:
(unassigned): OpenShift Container Platform 4.2 images update
  package owner<EMAIL_ADDRESS>qe<EMAIL_ADDRESS>qe_group: OpenShift QE
  url:   https://errata.devel.redhat.com/advisory/0
  state: NEW_FILES
  created:     None
  ship target: 2019-Nov-05
  ship date:   None
  age:         0 days
  bugs:        []
  CVEs:        CVE-2019-3889
  builds:

Note that Impact field doesn't show in the above preview output.
(Hint: You can test advisory creation with stage Errata with --yes by changing elliottlib.constants.errata_url to errata.stage.engineering.redhat.com).

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@a058d2f). Click here to learn what that means.
The diff coverage is 66.66%.

@@            Coverage Diff            @@
##             master      #73   +/-   ##
=========================================
  Coverage          ?   29.52%
=========================================
  Files             ?       27
  Lines             ?     2391
  Branches          ?      414
=========================================
  Hits              ?      706
  Misses            ?     1655
  Partials          ?       30

Impacted Files
Coverage Δ

elliottlib/cli/create_cli.py
0% <0%> (ø)

elliottlib/constants.py
100% <100%> (ø)

elliottlib/errata.py
24.77% <100%> (ø)

elliottlib/bzutil.py
49.28% <78.72%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a058d2f...9cabd90. Read the comment docs.


operator: Fix enabling of API discovery

After the switch to using the k8s-client cell, the operator had the enabling of the API discovery happening too late as the populating of the configurations happens in hive.New() and initEnv() was called after it. This is evident in the logs:
level=info msg="Support for coordination.k8s.io/v1 not present, fallback to non HA mode" subsys=cilium-operator

This moves the setting just prior to call to hive.New(). Verified manually that now the lease support is correctly detected:
level=info msg="attempting to acquire leader lease default/cilium-operator-resource-lock..." subsys=klog level=info msg="successfully acquired lease default/cilium-operator-resource-lock" subsys=klog level=info msg="Leading the operator HA deployment" subsys=cilium-operator

Fixes: af61d36f5f ("operator: Use hive and the k8s-client")

Could you add the Fixes: ... section to the commit / PR?

Thanks added.

/test

Hitting some flakes, but these can't be due to this change so marking ready to merge.


feat(apache): Add a way to put a proxy for the underlying http client

Closes #461

Coverage decreased (-0.2%) to 77.289% when pulling dbc74065aef4144f57755a57e23ca89d24e55502 on feat/proxy_apache into d52dbef1972f21b0adde616ec8e75f02c9ec2c3d on master.


KAFKA-12253: Add tests that cover all of the cases for ReplicatedLog's validateOffsetAndEpoch

jira:  https://issues.apache.org/jira/browse/KAFKA-12253
Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

@jsancio

@jsancio

Thanks. I'll take a look this week.

@jsancio made changes as per review.

@jsancio thanks for the review. Made changes as per review comments.

thanks @jsancio. will you be merging the pr?

thanks @jsancio. will you be merging the pr?

You need a green checkmark from a committer. I am not a committer. :smile:
cc @mumrah @hachikuji


updates mobile modal so that it scrolls to top when bottom button is …

Updates mobile modal so that it scrolls to top when bottom button is clicked.

Looks good! My stuff has already gone in, so you may need to fix any merge conflicts. if not, 👍


Remove social links from outgame template

The outgame template contains icons with links to social media (Google+, Facebook) that should be removed. The icons can stay but the links should removed or set to #.

#351 its a tiny commit but needed :)

Fixed by #351.


Path of Building SSL connection  error

Well i have the ssl connection problem with the pastebin links. iv tried everything redownloaded the program 4 times i dont own any anti virus problem so thats not the issue i had no problems when i played the game last month im not sure what can be the cause of it if anyone knows something about it ill appreciate it
Thank you

I also have this problem but you can always open the pastebin and copy the whole code in the textbox next to the import button.

same, started recently doe. worked just fine last league

Same.. happening to 3 computers in my house.  Interestingly, it happened about the same time that we all updated to Win10 1903 (the large windows update) - not sure if related, but a thought.

For me, the reason this fails with HTTPS and not HTTP is that, for some reason, PoB needs LSASS.EXE to have Internet access. This really shouldn't be necessary.

I have this problem since some days ago. I can't import my character from poe. I tried to disable antivirus and the firewall. Tried with 2 machines with w7 and different ISP. I still got the same error (SSL connect error). I only could import in another machine with w10.

For me, the reason this fails with HTTPS and not HTTP is that, for some reason, PoB needs LSASS.EXE to have Internet access. This really shouldn't be necessary.

Allowing LSASS.EXE in my firewall fixed this issue for me, too. Thanks!

whats LSASS.EXE? i dont even have this thing

@xerance
LSASS is a Windows System Service (Local Security Authority Subsystem Service) it's used for managing various security related policies on Windows. It shouldn't be used here for SSL connections.
For me and  goldaryn  it wasn't allowed through the firewall, so the connection failed. It really doesn't need Internet access and should be fixed.

LSASS seems to be the target of viruses and malware. I am uncomfortable just giving it a free ride through my firewall.

I resolved my issue with LSASS too, i forgot to refresh my firewall rules before. I always leave this application blocked. PoB shound't rely on that to make connections.

I have the same problem and I agree that LSASS shouldn't require internet access. In the meantime just change https to http in the pastebin link as a temporary solution.
Of course this doesn't fix the same problem occurring when importing your own characters.

Has there been a fix for the SSL issue people have been having with PoB if so could someone drop me a link thank you

Here's a workaround for the issue where you can't import characters from poe.com:

go to the releases page - https://github.com/Openarl/PathOfBuilding/releases
download and extract the .zip version. you must use this version for the workaround.
edit \Classes\ImportTab.lua
search for all references to https://www.pathofexile.com and change to http://www.pathofexile.com

Obvs. https is better than http and this is at our own risk, but it seems to work. Same should also work for pastebin links.

If you have Kaspersky enabled, deactivate it just to import, then reactivate it

It's work , Kaspersky disable accsess to LSASS.EXE from Path of Building , because it dangerous. Just pause protection for 1 min and enter the pastbin code or make your code of your build.

I just added Path of Building as a Trusted Application in Kaspersky. Checked the 1st four boxes.
I couldn't get the URL exceptions to fix the issue. I tried every combination for the Web Filter. The instructions Tetuev explained may not work as the Program has changed.

To get pob to work with pastebin you need to add pob to trusted application AND pastebin to trusted domain.
https://puu.sh/IGNT8/34820bcc2c.mp4
works for both the community fork and this original version.


Validate extraArgs field in kind:EtcdCluster

We should validate extraArgs field and prevent usage of args generated by operator itself.
Follow up for #72 #69

Should we check that etcd supports such flags or just reject collisions for flags used by operator?

The initial request was just to reject collisions. I guess it will be enough for now

Which of 3 behavior  we want:

Validation web hook
status error
skip the unwanted argument

I guess validation webhook error


bug(Profile): HEIC images do not work

Issue:
Like the title says most heic images are not working when you try to upload them as a profile picture. This might be important down the road as we plan to release on mobile and most of the US are iPhone users
Screen recording:
https://github.com/Satellite-im/UplinkWeb/assets/93608357/c335a914-e0e1-43cf-99a2-2085ca26e2ac

In this case, it might be best to convert the image to jpg or png before passing it over to warp. The library used to for processing the image doesnt support heic so this would probably need to be converted on the frontend to something that is supported (which commonly is jpg or png).


Add Optimade Querier and replace current OQMD through optimade

This pull request is a working in progress for  #2
It implements the following:

Implement the OptimadeQuery structure that allows to query any optimade structure provider
Replaces the current OQMD Querier (using their own API) to an optimade querier
Partially supports COD through Optimade. Few issues still are present (how to handle large crystal structure files?)
Allows to provide provider based special filters as a dict (ie. {"_oqmd_stability": "<0.01"})

Current  issues
Currently there is an inconsistency between the return schema of OQMD/COD regarding to next_query_url: One returns directly the URL (OQMD), while COD is returning a dict.

Current issues Currently there is an inconsistency between the return schema of OQMD/COD regarding to next_query_url: One returns directly the URL (OQMD), while COD is returning a dict.

This is allowed within the OPTIMADE specification as all links can either be a single string or a JSON:API links object (that allows you to add extra metadata to the link), so I guess it should be handled.

I see! Thats makes a lot of sense. I guess in this way should be working for both so I will merge this pr


feat: Codeowners generation

Description
This implements an experimental, proof of concept command:
$ pizza generate codeowners path/to/local/repository [flags]

This expects a path to a valid git repository where it will iterate the commits (by default, over the last 90 days) and generate a OWNERS file (or a github style CODEOWNERS file if the --github-codeowners flag is provided).
This file relys on a configuration file in the user's home directory called ~/.sauced.yaml which carries attributions of user keys to emails (generally, these are GitHub users or teams but could be simple names). For example:
Individual user attribution:
attribution:
  jpmcb:
    -<EMAIL_ADDRESS>
Team attribution:
attribution:
  open-sauced/engineering:
    -<EMAIL_ADDRESS>
Agnostic name attribution:
attribution:
  John McBride:
    -<EMAIL_ADDRESS>
Related Tickets & Documents
Closes: https://github.com/open-sauced/pizza-cli/issues/85
Steps to QA

Build via just build
Run the codeowners command on some local git repo via ./build/pizza generate codeowners . (make sure you have a valid yaml config in ~/.sauced.yaml

Tier (staff will fill in)

[ ] Tier 1
[ ] Tier 2
[ ] Tier 3
[x] Tier 4

I'm partial, but I think the GitHub style should be the default, as there may be more GitHub style repos than Google/Kubernetes style repos in terms of owners.

I think the GitHub style should be the default

Sure thing: easy enough to flip that bool flag around 👍🏼 I think this is what I was doing originally, but this was feedback we got from our stakeholder (but their probably partial to the Google style OWNERS file anyways). Let's go with the GitHub style as default since that's more what we'll be targeting for this as it goes out.

This now generates a CODEOWNERS by default:
❯ ./build/pizza generate codeowners .
Finished processing commits for: /Users/jpmcb/workspace/opensauced/pizza-cli
Finished generating file: /Users/jpmcb/workspace/opensauced/pizza-cli/CODEOWNERS

and the documentation reflects using the latest for the Go module install method and the docker run method.
Ready to roll!


Display current prices of items in Grand Exchange

I am curious if this is possible? So in theory, we would look up abyssal whip in the grand exchange menu and it would show: how many abyssal whips are currently selling in the ge and/or show what price the whips are selling for (not the average price, but the actual price the whip is sitting in the ge for).
This feature would be awesome for deadmanmode because prices vary so largely, but in the main game as well. -feature!

Duplicate of #733

Thanks deathbeam, I will read up on what that post talked about!


Honor context timeout in the client

Honor the context timeout in the client, if no request timeout is set.

@biglittlebigben I think it should already work as-is, since context is passed down to bus.Publish.


Add new framework Page and cutie as a base for this framework

@yegor256/z please, pay attention to this pull request

@Guseyn this pull request is too small, just 4 lines changed (less than 10), there will be no formal code review, see §53 and §28; in the future, try to make sure your pull requests are not too small; @yegor256/z please review this and merge or reject

@Guseyn there are merge conflicts, please rebase

@yegor256 Done.

@Guseyn thanks!

This job is not in scope

Job gh:yegor256/elegantobjects.github.io#74 is not assigned, can't get performer


Fix - single file files are str only, cast it to list to count properly

Validate Frames didn't count single file properly. Old implementation expected [], string is provided for single frame.
How to test it:

try to publish single image file
see error mesage of Validate Frames

I think single file in list of 'files' will crash during integration... As it's expected it must be a sequence but can't find out what thre frame ranges are. So it should not continue in validation or raise exception that can't publish single file...


Improved the handling of some corner cases

Add a sleep to avoid ConnectionError in urlFunctions.py
Add checking if Top critical reviews exist.
Change pageSpanText find from the checking rating to checking reviews.
Amazon only displays reviews in the first 500 pages, use this info to accelerate fetch.

@zhanghao00925 Some checks were not successful!


In the case of auto_forwarding_= true, an error of "socket is already in use, race happened on connection to " appears for the append_entries of the follower

Hi,
In the case of auto_forwarding_= true, can the append_entries of the follower only forward messages to the leader one by one?

hi @greensky00
I suggest auto_forwarding_=true should be provided,  Adding a service in the outer layer of NuRaft to increase the complexity.
Is it possible to add serial and parallel modes in "asio_rpc_client" and "asio_rpc_listener", Serial in operations such as append entry and parallel in foward request to leader.

Thanks, @nicelulu @marising for suggesting this.
We will consider supporting multiple in-flight messages. But please note that auto-forwarding has endless edge-cases that may cause potential problems, and that's why we don't recommend it (also we don't internally use it). For example, a follower forwards a message to the leader, and the leader succeeds to replicate it, but the response of the "forwarding" is lost. There is no way for this follower to know whether it should retry or not. There are a number of such complicated issues and we will not cover them. It should be handled at your own risk.

Thanks @greensky00 for your reply.
In our system,  Exactly-once is not required, only At-least-once is required, which means that the log entry can be repeated but cannot be lost. In addition, we have relatively high performance requirements, In the case of a log of 1KB, append log requires >= 30,000 TPS,  so support multi-threaded auto-forward is very important for us, and we look forward to it.

@greensky00 Thank you for solving this problem. I met some error logs during the test : session 1 failed to read rpc header from socket ::ffff:<IP_ADDRESS>:53410 due to error 2. What could be the reason for this?

Hi @nicelulu
error 2 means the destination endpoint is unavailable (disconnected). It is not a critical one.


Package request: btrfs-assistant

Project description
 BTRFS Assistant aims to be a utility to make managing BTRFS partitions easier, with tools such as balancing and managing backups through snapper.
Metadata

homepage URL: https://gitlab.com/btrfs-assistant/btrfs-assistant (They don't have a typical website or homepage)
source URL: https://gitlab.com/btrfs-assistant/btrfs-assistant
license: gpl3-or-later
platforms: linux

Duplicate of https://github.com/NixOS/nixpkgs/issues/232444

Apologies. I searched for surfshark and no results but I forgot to do the same for btrfs assistant. Will close this issue now


[Feature Request] Multilingual support Malay

Existing Component
否
Component Name
Pagination
Description
support Malay，please!Thanks you !

As mentioned in the documentation:

If your target language is not included, you are more than welcome to contribute: just add another language config here and create a pull request.

No one in our team speaks Malay, so we have to rely on the community.


Effect overlay exception

Description
afaict this happened when i was hitting some stuff with the captains sabre
Screenshots

oops forgot effects are robust


[google_maps_flutter_web] Support for Holes in Polygons

Description
@sanekyy added support for Holes in Polygons in google_maps_flutter_platform_interface in #3135 and is adding the support for iOS and Android to google_maps_flutter with #1721
Pre-launch Checklist

[x] The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] I read the Tree Hygiene wiki page, which explains my responsibilities.
[x] I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
[x] I listed at least one issue that this PR fixes in the description above.
[x] I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test exempt.
[x] I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
[x] I updated CHANGELOG.md to add a description of the change.
[x] I updated/added relevant documentation (doc comments with ///).
[x] I signed the CLA.
[x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@ABausG thanks for the PR, whats the purpose of this PR? since we have already had one similar open.

@ABausG thanks for the PR, whats the purpose of this PR? since we have already had one similar open.

I guess you are talking about #1721 ?
This is mostly the same but for the web version of Google maps to also add that new functionality to that platform

I guess you are talking about #1721 ?
This is mostly the same but for the web version of Google maps to also add that new functionality to that platform

@ABausG Oh, sorry, i didn't see this is for web! Thanks for the PR!
CC @ditman

@ABausG Oh, sorry, i didn't see this is for web! Thanks for the PR!
CC @ditman

Also, and maybe more important than my previous remark: can you please add a "hole" to the "initial geometry" test here:
https://github.com/flutter/plugins/blob/master/packages/google_maps_flutter/google_maps_flutter_web/test/test_driver/google_maps_controller_integration.dart#L145
That test ensures that the holes can be passed directly when creating the Map too (and not only by adding a polygon after the map has been created).

Also, and maybe more important than my previous remark: can you please add a "hole" to the "initial geometry" test here:
https://github.com/flutter/plugins/blob/master/packages/google_maps_flutter/google_maps_flutter_web/test/test_driver/google_maps_controller_integration.dart#L145
That test ensures that the holes can be passed directly when creating the Map too (and not only by adding a polygon after the map has been created).

Added both tests. Had to add some more imports to shape_integration.dart as I thought the test for poly.containsLocation would be best placed there

Added both tests. Had to add some more imports to shape_integration.dart as I thought the test for poly.containsLocation would be best placed there

I found a very small quirk on the web implementation of this feature on the web: https://github.com/flutter/flutter/issues/74096 :)

I found a very small quirk on the web implementation of this feature on the web: https://github.com/flutter/flutter/issues/74096 :)


Remove unused ClusterName from NodeController

You can get rid of it in the NodeController, but #8164 depends on the flag being there in the controller-manager.

@cjcullen - Why do you need ClusterName there? IIUC you just need it to generate "more readable" route names, as node UIDs assure uniqueness, am I right? Maybe you can use project name for this, or something else, as using something that's not used anywhere else isn't probably the best idea.
To be clear - I'm OK with keeping this flag there for you, I'm just not sure that it's the best thing to do.

I use the cluster name to know whether a route belongs to a cluster on clean-up/reconciliation. It is a bit redundant, as I also check that the route is inside the cluster CIDR range.
You can rip it out here and leave the burden of proof on me to show that I need it in #8164 :).

We can always reintroduce this flag if it turn out that sth like it is necessary.

LGTM

I'll ping you when I have e2e results.

e2e is green


Safer _NP_VERSION

Tiny PR to make iris friends with numpy 1.10.0 (actually '1.10.0.post2' for some reason) .

for some reason

See PEP440.

See PEP440.

Thanks for the pointer, but I was being ironic :wink:
I disagree entirely with anything beyond MAJOR.MINOR.MICRO.  To me post is just a micro release bump.

Just for fun:
https://mail.scipy.org/pipermail/numpy-discussion/2015-October/073971.html


Improve listener

Move all declarations to the method start because this speeds up execution.
Store RawUrl before starting comparing routes because sometimes the request hasn't been completely processed on the first pass and it causes an exception when the request starts to be re-processed on the second pass of the foreach below.

Thanks for those proposed changes. I will not take them now because I've been working on making this part already part of a separated thread and those variables can't be declared outside of this potential thread as it won't work in this case. I'm keeping them in a warm place if it happens that the modification I4m working on are not working correctly.

OK understood.
One thing that I strongly suggest that you take into your new code is the rawUrl = context.Request.RawUrl;.
On scenarios of repeated requests (or fast incoming requests) that's mandatory for the reasons explained. Otherwise there a high likelihood that exceptions are thrown.
For the rest it's OK either way. The impact exists on creating the vars over and over, but it's minimal.

One thing that I strongly suggest that you take into your new code is the rawUrl = context.Request.RawUrl;.

yes, will do. I was even thinking in adding to the webargument parameters and split over context.Response and context.Request to be in a more "flat" pattern and avoid what you mention

I think I implemented all in the new server commit. I will close it then.


Add runtime warning when EventSource is missing

See also #11 and https://github.com/rackt/redux/issues/808

Fixed by 82da7cf and released in v2.2.1


missing eventdetection events when calling on raw reads (uploaded folder)

Hi, The issue might be that I dont understand the correct usage of the program and I would gladly accept your guidance.
Anyway, when I try to use nanocall on the uploaded folder (which contains .fast5 files with only raw signal) I get empty fasta files from nanocall output. The error output shows this:
= main.2 nanocall.cpp:270 init_reads summary: [base_file_name=MinION_PC_20160907_FNFAD12322_MN19084_mux_scan_Lambda_Burn_In_Library1_51105_ch227_read31_strand valid=1 num_ed_events=0]
= Fast5_Summary.2 Fast5_Summary.hpp:176 summarize /genomicslab/nobackup/volume2/artemd/minion/third_lambda_run/reads/uploaded/MinION_PC_20160907_FNFAD12322_MN19084_mux_scan_Lambda_Burn_In_Library1_51105_ch303_read66_strand.fast5: missing eventdetection events

This is shown for every read which is processed.
I was able to run nanocall on reads from both the fail and pass folder, but those reads were processed by metrichore which contradicts the aim of this software to be an alternative basecaller. I'm almost certain that some crucial information went over my head and I would be happy if you could explain me what is I'm missing.
ps: another small question, as I understand the only available output format is fasta? which means the quality of bases/reads is "thrown away"?

I've added an explanation in the main README about the role of Nanocall with respect to R7.3/R9, and the various levels of ONT sequencing data.
In short:

Make sure you really need Nanocall on recent R9 data.
If you do, Nanocall needs events, not raw samples. On R9, either MinKNOW or Metrichor must be used to generate them.

The apparent contradiction is due to the changes in ONT software. On R7.3, event detection was performed locally and reliably by MinKNOW, so we never tried to redo it as part of Nanocall.
Regarding qvs, ONT data in general is way too noisy (compared to Illumina) for qvs to be useful. Even with Metrichor, the error rate is ~10%, which means most qvs would be 1.


Fix: GPR curation for acyl-CoA hydrolysis and nicotinate and nicotinamide metabolism

Main improvements in this PR:
As proposed in #890

Remove ENSG00000112304 from MAR00242;
Replace ENSG00000205669 with ENSG00000159445 from MAR00324;
Replace ENSG00000205669 with ENSG00000159445 from MAR00332;
Add ENSG00000159445 for MAR00354;
Replace ENSG00000177465 and ENSG00000101473 with ENSG00000172497 and ENSG00000159445 from MAR03009;
Remove ENSG00000112304 from MAR00210;
Replace ENSG00000205669 with ENSG00000159445 from MAR00426;
Replace ENSG00000205669 with ENSG00000159445 from MAR00438;
Remove ENSG00000205309, ENSG00000076685 from MAR04252;
Remove ENSG00000205309, ENSG00000076685 from MAR04264;
Remove ENSG00000162836 from MAR04270;
Remove ENSG00000198805 from MAR04662;
Remove ENSG00000109743 from MAR08788.

I hereby confirm that I have:

[X] Tested my code on my own computer for running the model
[X] Selected develop as a target branch
[ ] Any removed reactions and metabolites have been moved to the corresponding deprecated identifier lists

I'm sorry I didn't check carefully enough before. I am now realizing that the modification I proposed for MAR03009 may have a problem.
What we could know here is that ENSG00000172497 and ENSG00000159445 have a hydrolyzing function for most acyl-CoAs in the cytosol. However, MAR03009 is located in peroxisomal rather than cytosol. This is the root cause of the problem.
The original GPR of MAR03009 is ENSG00000101473 or ENSG00000177465. Both of them have the hydrolyzing function for acyl-CoAs and located in peroxisomal. So, I think MAR03009 should keep the original GPR. What do you think? @Devlin-Moyer

ACOT4 (ENSG00000177465) should still be removed, because, while it is capable of hydrolyzing acyl-CoAs in peroxisomes, it is not active towards propanoyl-CoA (see figure 4A of this paper)

The human ACOT4(ENSG00000177465) possesses activity with medium- to long chain acyl-CoAs in addition to the activity with succinyl-CoA and glutaryl-CoA. But the corresponding C4-monocarboxy-lyl-CoA (butyryl-CoA) was not a substrate, and in contrast the C12 dicarboxylyl-CoA was not a substrate(even though the corresponding C12 monocarboxylyl-CoA was a good substrate). Therefore, I believe that ACOT4 is also inactive towards propanoyl-CoA (similar to butyryl-CoA) in MAR03009. Agree to remove ACOT4 (ENSG00000177465) for MAR03009.
As for ACOT12(ENSG00000172497), I think we should not add it to the GPR of MAR03009 for the time being. We will make a judgment after finding stronger evidence.


Q: Why does operator.watchNamespace need to exist for cf-operator to deploy successfully?

Deploying cf-operator using a separate target namespace as described in https://github.com/SUSE/scf/blob/7178d32d95fa83efa60cffba99346abb4f14dbd1/INSTALL.md#install-cf-operator with namespace scf, I found that the operator deployment fails with
cf-operator command failed. Failed to create new manager.: failed to setup hooks: setting the operator namespace label: getting the namespace object: namespaces "scf" not found

Is this intentional or would it be ok to let the operator deployment pass successfully and do the rest of the initialization once the namespace exists?

The namespace needs to exist, before running helm.

@manno: Wow, that was quick! I guess the PR would also work in cases the namespace was created before (e.g. in helm upgrade cases)?

I guess the PR would also work in cases the namespace was created before (e.g. in helm upgrade cases)?

Seems like it doesn't... I am now getting
Error: release cf-operator failed: namespaces "scf" already exists

if the namespace exists. Not sure what would happen during an update scenario of the operator.


Adds Write Scope Middleware to all create/update/delete endpoints

What's this PR do?

Adds write scope middleware to all create/update/delete endpoints
Updates tests to incorporate write scope
Adds new tests to test write scope is working

How should this be reviewed?

All tests should pass!

Relevant Tickets
This Pivotal Card.
Checklist

[x] Documentation added for changed endpoints.
[x] Tests added for new features/bug fixes.
[ ] Post a message in #api if this includes something that causes a rebuild!

As with the user and activity scope changes, let's make sure to communicate these in #prod-eng-data so we make sure we don't cause any unexpected issues for folks!

ah yes - sorry I didn't see those comments from yesterday! Just cleaned up based on those @DFurnes and @sbsmith86 :) I'll give everyone the heads up now and maybe we can merge/test/deploy on Monday?

I'll give everyone the heads up now and maybe we can merge/test/deploy on Monday?

👍 on waiting to Monday to deploy!


Controller Often doesn't work when used on UNIX based systems

Currently on Ubuntu 20.04, using an Xbox controller, works fine if i restore to pre-modded, and works fine in other games...

Edit:
If you replace the 2 Assembly C-Sharp files with the ones found here: https://github.com/HollowKnight-Modding/HollowKnight.Modding/releases/tag/<IP_ADDRESS>-60
It fixes it!


how know activity user for collection?

if i have user collection
$followers = User::whatEver();

how can know user activity like
$activityFollowers = $followers->activity();

This package isn't meant to be used like a twitter feed. It's just to show who is currently online. :/

I'm closing this because of the lack of response.


Can't select it from the list of policies, to activate it for a team project

Hi, I installed your policies from Visual Studio Marketplace, for VS2017, from this link:
https://marketplace.visualstudio.com/items?itemName=ColinD.ColinsALMCheckinPoliciesVS2017
However, I can't see it in the list of check-in policies. Here's the path I went:
Team Explorer => Home => (from the top, click on the dropdown) => Settings => (under Team Project) Source Control => Check-in policy tab => Add => your policy name is not there.
My Visual Studio version is Community Edition, version 15.1.
Should I activate it in another way? If so, please add a little documentation for that.
thank you so much

Closing since there has been no update.


Random color

Added random generator for colors
hex, rgb, rgba, hsl and hsla options

Hello @Aleksalje,
First of all, great job!
Next, there are a few small issues - while you were working on the code for this PR, I've added ESLint to codebase; you should pull latest changes from develop branch and run lint command locally (and fix all potential issues).
There is a merge conflict with package-lock.json file - it's because of the linter. I suggest for you to delete both node_modules and package-lock.json, after which you can run npm i and it will create new, proper file without conflicts.
Other stuff I've noticed will be comments on the code itself, just for simplicity.


add test for ListDevices.

This found a bug in the existing code, just submitted a fix.

Yes, thank you very much! I was confused that the old version was working on my PC.


Support optimistic caching

Optimistic caching: serve response from the cache even though the TTL may have expired, return a very short TTL to the client (e.g. 10s) and refresh the cache entry async.

Could be useful


Code Update ( BMC + PNOR)

Place holder epic for code update automation for BMC and PNOR

GA1 delivered. Closing


More aggressive edits

What would it take to get more aggressive edits? I am thinking gofmt here, which slices and dices my file to it's liking, reshuffling imports and re-arranging things as it pleases.
Consider what tsfmt does to this:
export
default
class
Provider
{
constructor (

) {}
}

becomes:
export
  default
  class
  Provider {
  constructor (

  ) { }
}

but ideally, would be:
export default class Provider {
  constructor() {
  }
}

To be honest I don't know how feasible this would end up being with a language like typescript, but seems like something worth exploring. So instead of making edits as such to a document, you read the entire document into it's canonical AST, and then generate the source code for the AST. That's what's so great about gofmt - you don't worry about editing text as much, you worry about shaping the AST. Another example is paredit for emacs for editing lisp code. I found both experiences extremely great to work with.
Is this something that can be done in this project or would it be more of a typescript repo level issue? I see in the sources most of the code is concerned with the wrapping for formatting.formatDocument.
Thanks for your time

@felixSchl - I'll leave @vvakame to answer on behalf of the project but here are my thoughts. I too come from a Go background so have a similar starting point with gofmt. Things like re-ordering imports etc could, as far as I understand things, be achieved by extending this project, tsfmt.
The one important distinction here with gofmt is that (unfortunately, in my opinion) one can supply formatting options. The superset of these formatting options is defined in the TypeScript services 'layer' (part of the core TypeScript project).
As it stands this project simply acts as a simple formatter with the key distinction being that it first computes a 'union' of formatting options from:

tsfmt.json
.editorconfig
tslint.json (equivalent to go vet in many respects)
tsconfig.json (the compiler options)

Hence once this tool has computed the 'union' of required options it then simply delegates to the TypeScript services layer to format the AST.
There is nothing to my knowledge that would fundamentally prevent this tool being adapted to the following flow:

Parse document to AST
Reorder, munge etc AST (e.g. adjusting imports)
Compute formatting options (status quo)
Format AST based on formatting options
Output to stdout (again, status quo on various output options)

We already rely on tsfmt to enforce that all of our code is automatically formatted in a consistent way (much like Go projects do with gofmt). If tsfmt were extended in much the same way that goimports extends gofmt then we would certainly find a use for this.

thank you for your request.
tsfmt glue the TypeScript's formatter to users. that is all.
But I think your opinion is very useful. :+1:
You should open issue to TypeScript repo.


Support worktrees

Hi,
It’d be nice if Gitu supported worktrees.
Currently, running it in one yield the following error:
$ gitu
Error: Os { code: 20, kind: NotADirectory, message: "Not a directory" }

In a worktree, .git is a file that contains the path to the parent repository.

@frank-lenormand Which version are you on? Thought I fixed this crash with 0.5.5.
Ah didn't realize it contains a path, that means rebase/merge status would be broken even after 0.5.5.

I installed the latest at the time, which is v0.6.3.
In the worktree directory in which I noticed the issue, the .git file contains:
gitdir: /the/full/path/to/parent/repository

I actually can't reproduce this with v0.9.0, I wonder what steps did you make to get the error?
I've run the following commands:

git worktree add ../gitu_wt/fix-worktrees
cd ../gitu_wt/fix-worktree
gitu
And no errors after that, I also successfully made a commit to test things out

The bug was reported for v0.6.3.
It seems to be working as expected, now, with v0.9.1.
I couldn’t find which specific commit addressed the issue.


Correct Napi::TypeError to others

https://github.com/loliot/node-lot-gpio/blob/d4690b4a13cf586622adc9d807837eaaa64bdc24/src/gpio.cpp#L79-L83

closed this in c87e1d074182443ef73eb6c4dab76b969171ddbc


Minor update - README.md

Remove period for consistency.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Reduce cache on Travis

Fixes that Travis jobs are terminated

It seems fine, what about? @weiznich

Attempt to reduce more following https://levans.fr/rust_travis_cache.html

This might also be interesting: https://github.com/rust-analyzer/rust-analyzer/blob/04c2961d0c5493962e948dc8101445cc76f1d460/.travis.yml#L2-L5

@killercup Good point! It seems reasonable. If we don't drop Travis right away, we can go for reducing cache for now.


Added code and initial documentation

@simona might want to do a reading through / verifying that we got all the docs pushed into this branch before merging.

@heraldfianbakken, can you resolve the build error, so we can merge the code?

@BrianBlanchard , the job is failing as we didn't add the Github secrets required as described here. This is intentional in order to remove any information regarding our testing environment and avoid deployments in our subscriptions.


Permission denied when benchmarking on Android using ADB

Hi, I tried the benchmark tool for Android using ADB, and I couldn't run the tool because of the permission denied error.

The solution was to make the benchmark tool executable using the ADB shell like this:

After this, the tool runs fine and prints out the evaluation results.

I just want to put this out here to help others facing the same problem.
An update to the docs here (https://docs.larq.dev/compute-engine/benchmark/) will be the permanent fix.

Thanks for catching this. I wasn't aware that the permissions might get lost on some phones or adb servers when pushing the benchmarking binary.
@rameshKrSah Do you want to sent a PR to add this to the docs here?

I wasn't aware that the permissions might get lost on some phones or adb servers when pushing the benchmarking binary.

Actually this might be due to Windows. I think we only tested the docs on Linux and macOS. Either way we should update the docs to change the permissions on the phone instead 👍

Thanks for catching this. I wasn't aware that the permissions might get lost on some phones or adb servers when pushing the benchmarking binary.
@rameshKrSah Do you want to sent a PR to add this to the docs here?

Sure, I can do that. Will send the PR soon. :)

The pull request was merged


Update Inkjet to bring support for Vimscript

Hi!
I recently requested Vimscript from the Inkjet author and they published a new version 0.10.2 (Issue: https://github.com/Colonial-Dev/inkjet/issues/11)
It would be great to update Inkjet in MDEx so that I can pull it into my project.
I would submit a PR, but I am not very experienced in Rust and have not worked with Rustler before 😅.
Thank you for this library! It is great to have a markdown library in elixir that support CM and GFM as well as highlights with treesitter. I was very excited when i came across it.
No rush, cheers! 🍻

Done https://hex.pm/packages/mdex/0.1.12 🍻

Thank you so much!


baseUrl deployment issues

Environment
Digitalocean

Operating System: Linux
Node Version:     v16.14.2
Nuxt Version:     3.2.3
Nitro Version:    2.2.3
Package Manager<EMAIL_ADDRESS>Builder:          vite
User Config:      -
Runtime Modules:  -
Build Modules:    -

Reproduction
https://github.com/warflash/do-path-repro
Deployed example: https://walrus-app-sc3we.ondigitalocean.app/path/path
Describe the bug
I’m trying to deploy my Nuxt 3 apps to DO App Platform.
I’ve set the baseUrl in the nuxt.config.js to /path/ while also setting
routes:
- path: /path/

in my .do/app.yaml.
The issue I’m seeing is that calling /path now throws a nuxt 404 and in order to get back a 200 I need to go to /path/path which is not what's expected at all.
Also things like static assets don't really seem to work as you can see when opening the deployed example

Additional context
I'm not 100% sure how much of this could be on digital ocean but as there have been quite a few issues opened on nuxt from people having trouble with the baseUrl prop + DO being a "official" preset I figured I'd report this.
Logs
No response

For future readers, after extensive back and forth with DO support it just seems like their routing was not designed to host multiple frontend applications at once. Had to go the nginx route