HADOOP-18254. Disable prefetching by default.

Description of PR
Disables prefetching by default and updates documentation.
How was this patch tested?
Not required

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
13m 56s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
markdownlint
0m  0s

markdownlint was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ feature-HADOOP-18028-s3a-prefetch Compile Tests _

+1 :green_heart:
mvninstall
37m 17s

feature-HADOOP-18028-s3a-prefetch passed

+1 :green_heart:
compile
1m  2s

feature-HADOOP-18028-s3a-prefetch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>

+1 :green_heart:
compile
0m 58s

feature-HADOOP-18028-s3a-prefetch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
checkstyle
0m 53s

feature-HADOOP-18028-s3a-prefetch passed

+1 :green_heart:
mvnsite
0m 55s

feature-HADOOP-18028-s3a-prefetch passed

+1 :green_heart:
javadoc
0m 47s

feature-HADOOP-18028-s3a-prefetch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>

+1 :green_heart:
javadoc
0m 53s

feature-HADOOP-18028-s3a-prefetch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
1m 39s

feature-HADOOP-18028-s3a-prefetch passed

+1 :green_heart:
shadedclient
20m 53s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 42s

the patch passed

+1 :green_heart:
compile
0m 45s

the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>

+1 :green_heart:
javac
0m 45s

the patch passed

+1 :green_heart:
compile
0m 39s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
javac
0m 39s

the patch passed

-1 :x:
blanks
0m  0s
/blanks-eol.txt
The patch has 2 line(s) that end in blanks. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply

+1 :green_heart:
checkstyle
0m 28s

the patch passed

+1 :green_heart:
mvnsite
0m 43s

the patch passed

+1 :green_heart:
javadoc
0m 26s

the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>

+1 :green_heart:
javadoc
0m 35s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
1m 16s

the patch passed

+1 :green_heart:
shadedclient
20m 24s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
2m 43s
/patch-unit-hadoop-tools_hadoop-aws.txt
hadoop-aws in the patch passed.

+1 :green_heart:
asflicense
0m 52s

The patch does not generate ASF License warnings.

109m 49s

Reason
Tests

Failed junit tests
hadoop.fs.s3a.read.TestS3InputStream

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4469/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/4469

Optional Tests
dupname asflicense mvnsite codespell markdownlint compile javac javadoc mvninstall unit shadedclient spotbugs checkstyle

uname
Linux 47457071a8cc 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
feature-HADOOP-18028-s3a-prefetch / e0c53f2543813b941436238f5dab1877ece7574c

Default Java
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS> /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4469/1/testReport/

Max. process+thread count
698 (vs. ulimit of 5500)

modules
C: hadoop-tools/hadoop-aws U: hadoop-tools/hadoop-aws

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4469/1/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 43s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
markdownlint
0m  1s

markdownlint was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ feature-HADOOP-18028-s3a-prefetch Compile Tests _

+1 :green_heart:
mvninstall
37m 48s

feature-HADOOP-18028-s3a-prefetch passed

+1 :green_heart:
compile
1m  4s

feature-HADOOP-18028-s3a-prefetch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>

+1 :green_heart:
compile
0m 55s

feature-HADOOP-18028-s3a-prefetch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
checkstyle
0m 52s

feature-HADOOP-18028-s3a-prefetch passed

+1 :green_heart:
mvnsite
0m 59s

feature-HADOOP-18028-s3a-prefetch passed

+1 :green_heart:
javadoc
0m 43s

feature-HADOOP-18028-s3a-prefetch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>

+1 :green_heart:
javadoc
0m 52s

feature-HADOOP-18028-s3a-prefetch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
1m 38s

feature-HADOOP-18028-s3a-prefetch passed

+1 :green_heart:
shadedclient
21m 32s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 41s

the patch passed

+1 :green_heart:
compile
0m 42s

the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>

+1 :green_heart:
javac
0m 42s

the patch passed

+1 :green_heart:
compile
0m 35s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
javac
0m 35s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 23s

the patch passed

+1 :green_heart:
mvnsite
0m 40s

the patch passed

+1 :green_heart:
javadoc
0m 23s

the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>

+1 :green_heart:
javadoc
0m 29s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
1m 17s

the patch passed

+1 :green_heart:
shadedclient
20m 57s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
2m 45s
/patch-unit-hadoop-tools_hadoop-aws.txt
hadoop-aws in the patch passed.

+1 :green_heart:
asflicense
0m 44s

The patch does not generate ASF License warnings.

97m 25s

Reason
Tests

Failed junit tests
hadoop.fs.s3a.read.TestS3InputStream

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4469/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/4469

Optional Tests
dupname asflicense mvnsite codespell markdownlint compile javac javadoc mvninstall unit shadedclient spotbugs checkstyle

uname
Linux 4f56c106b395 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
feature-HADOOP-18028-s3a-prefetch / cc3674d9952b2c2fbe63ff1a7a69e29728dc54da

Default Java
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS> /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4469/2/testReport/

Max. process+thread count
546 (vs. ulimit of 5500)

modules
C: hadoop-tools/hadoop-aws U: hadoop-tools/hadoop-aws

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4469/2/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

failing unit tests are fixed in: https://github.com/apache/hadoop/pull/4386

@ahmarsuhail why is this hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/read/README.md removed?

re: removing the readme in src/main/java: Looking at the contents, that file and the prefetching website documentation are very similar. I think we already have all the info there captured, so that seems fine to me.

LGTM +1(non-binding)


Rewrite Sample Upload Page with new design.

Modify axios api to automatically unwrap errors (by doing error.response.data).
Add new Radio Button component.
Also add ProjectCreationForm and ProjectSelect common components.
Prioritize prefix matches when searching in Dropdown.
Move host genome selection into metadata upload.
Update validate endpoint to handle host genome inside metadata.
Refactor validate_sample_names to handle multiple names.
Add more validation errors to validate_metadata_csv_for_samples,
including duplicate sample rows, missing sample rows, and missing/invalid
host genomes.
Consolidate handling of remote and local samples in SampleUploadFlow, so we just
pass around samples instead of localSampleNameToFiles and remoteSamples.

Basic View:

Project Select:

Create Project Form:

Upload from S3 Option:

Local File Upload Table:

Remote File Upload Table:

Some new validation errors:

Testing strategy:
Verified that new sample upload flow works.
Verified that existing single and bulk upload flows still work.
Verified that upload metadata to project still works.
All Rails test pass.

Cool! Please make sure the following are thoroughly tested:

project creation still works
uploads work for both admin and non-admin users
uploads through the CLI still work, especially where they create a new project (since there's a change to projects_controller)

Also, please test both local uploads and S3 uploads for each flow :)


move phantomjs-built to devDependencies

Currently phantomjs-built is as a dependency rather than devDependencies, this will get pulled for nothing when depending on this library which is redundant

Coverage remained the same at 79.51% when pulling 31b47ad93da8a43f5d53071239ba2bf7f4259ec7 on stephenlautier:patch-1 into 4db3f3e34835907318d38eb3acd2d38427c511d4 on jkphl:master.

@stephenlautier Please read https://github.com/jkphl/svg-sprite/issues/100 for details why moving PhantomJS to devDependencies is not an option right now. Thanks for your understanding.

Ahh oki sorry for not searching, i thought it was just a mistake. Thanks

@stephenlautier No problem. I have this on my roadmap towards v2 though — please feel free to add wishes there! :)


Unlocking sound can fail if document body isn't loaded yet

Phaser Version: 3.24.1
Operating system: MacOS
Browser: Safari 14

Description
Call new Phaser.Game(…) via script in document <head>. Click on game canvas. Web audio context is still suspended and sounds play silently.
Example Test Code
https://codepen.io/samme/project/editor/ArGPWY
Click on the game canvas. Sound is still locked, context state is suspended, and unlocked doesn't appear in console.
Additional Information
WebAudioSoundManager.html#unlock is called immediately during game instantiation and aborts if document.body is missing. I don't think it's ever called again, so its handlers are never added.
Maybe unlock() should be called again during game boot. Or only during game boot.

I added code example.

I think unlocked only during boot makes more sense.
Thank you for submitting this issue. We have fixed this and the fix has been pushed to the master branch. It will be part of the next release. If you get time to build and test it for yourself we would appreciate that.


Game Data available through the API

Hey Nexure!
Stumbled on your API this afternoon and I really like it! I was curious to see if you have any plans to add game data to any of the endpoints?
For example:

/api/killers to get a list of the killers with related information/specific perks
/api/survivors to get a list of the survivors with related information/specific perks
/api/perks to get a list of all of the perks available in the game (maybe this should be divided into two separate endpoints, one for killer perks and one for survivor perks)
/api/items
/api/offerrings

Hello!
Yes, I can implement those into the API, which I do have mostly planned todo, to help the perk names. But this requires me downloading the PAK file from steam, and extracting it (which is what hold all of such information). Though there are open source tools to do so, I've just gotta go ahead and implement them.

Just FYI, actual data & numbers are serialized in ue4 binary format, so extracting PAK's won't help too much.

Progress is being made in this repo to be able to read some perk info, etc and make it available through the API. Also implement a downloader from the API to automatically download the PAK files from steam.

If You want I could hit You up with newer version of the library (part of why I abandoned that project for now, expanded it a lot, it's in almost release ready state) in about a week ;)

Yeah sure! :) That'd be great been having an issue or two with the current one.


Does the library support Multi-table queries, across navigation properties?

Summary of the issue
Does the library support querying across EF navigation properties, such that table joins for multiple entities are supported?
Full disclosure - I own a Nuget package for EFCache.Redis (https://github.com/silentbobbert/EFCache.Redis , which extends EFCache (https://github.com/moozzyk/EFCache) so I am reasonably familiar with second level caching within EF.
In the packages I mention, the SQL query string, for example (not a real example):
SELECT t1.Id, t1.Name, t2.OrderId
FROM dbo.Customer t1
INNER JOIN dbo.Orders t2 ON t1.Id = t2.CustomerId
WHERE t1.CustomerId = @p1 and t2.OrderDate > @p2

Is used (either directly for short strings, or a hash for longer ones) - and the entity sets from Customer and Orders tables are cached in the cache provider. If a second query came in for a Customer or Order, it could be satisfied by these cached objects.
If the same SQL query string is generated and p1 and p2 have the same values, and the results are still within their sliding and absolute expiry windows, the objects are deserialised from cache and returned as entities. If individual entities from within this result sets are invalidated by updates, it would invalidate the results of this query, plus a query directly requesting just this entity.
I was hoping to use your package as a more direct drop in replacement for the two I mentioned, as they only support EF6+, and not EF Core, but after initial setup I ran into this issue immediately.
Environment
.NET (Core) SDK version: net5.0 (5.0.301)
Microsoft.EntityFrameworkCore version:  5.0.6
EFCoreSecondLevelCacheInterceptor version: 3.1.1
Database: (e.g. SQL Server, SQLite, etc.) MS SQL Server (docker compose)
Cache provider: (e.g. in-memory, redis, etc.) Redis (docker compose)

Example code/Steps to reproduce:
var indices = await
   _dbContext.Indices
   .Include(i => i.User.ApplicationRoles)
       .ThenInclude(ar => ar.Role)
          .ThenInclude(r => r.Permissions)
   .AsNoTracking()
   .Where(i => i.ApplicationId == applicationId && i.CustomerId == customerId && i.UserId == userId)
   .Cacheable(CacheExpirationMode.Sliding, TimeSpan.FromMinutes(5))
   .ToArrayAsync()
   .ConfigureAwait(false);

Output:
This code works on the first invocation, while the results are not cached. On immediate 2nd invocation, I get an exception
The underlying reader doesn't have as many fields as expected. Expected: 17, actual: 0.
   at Microsoft.EntityFrameworkCore.Query.Internal.BufferedDataReader.BufferedDataRecord.InitializeFields()
   at Microsoft.EntityFrameworkCore.Query.Internal.BufferedDataReader.BufferedDataRecord.InitializeAsync(DbDataReader reader, IReadOnlyList`1 columns, CancellationToken cancellationToken)
   at Microsoft.EntityFrameworkCore.Query.Internal.BufferedDataReader.InitializeAsync(IReadOnlyList`1 columns, CancellationToken cancellationToken)
   at Microsoft.EntityFrameworkCore.Query.Internal.BufferedDataReader.InitializeAsync(IReadOnlyList`1 columns, CancellationToken cancellationToken)
   at Microsoft.EntityFrameworkCore.Storage.RelationalCommand.ExecuteReaderAsync(RelationalCommandParameterObject parameterObject, CancellationToken cancellationToken)
   at Microsoft.EntityFrameworkCore.Storage.RelationalCommand.ExecuteReaderAsync(RelationalCommandParameterObject parameterObject, CancellationToken cancellationToken)
   at Microsoft.EntityFrameworkCore.Query.Internal.SingleQueryingEnumerable`1.AsyncEnumerator.InitializeReaderAsync(DbContext _, Boolean result, CancellationToken cancellationToken)
   at Microsoft.EntityFrameworkCore.Storage.ExecutionStrategy.ExecuteImplementationAsync[TState,TResult](Func`4 operation, Func`4 verifySucceeded, TState state, CancellationToken cancellationToken)
   at Microsoft.EntityFrameworkCore.Storage.ExecutionStrategy.ExecuteImplementationAsync[TState,TResult](Func`4 operation, Func`4 verifySucceeded, TState state, CancellationToken cancellationToken)
   at Microsoft.EntityFrameworkCore.Query.Internal.SingleQueryingEnumerable`1.AsyncEnumerator.MoveNextAsync()
   at Microsoft.EntityFrameworkCore.EntityFrameworkQueryableExtensions.ToListAsync[TSource](IQueryable`1 source, CancellationToken cancellationToken)
   at Microsoft.EntityFrameworkCore.EntityFrameworkQueryableExtensions.ToListAsync[TSource](IQueryable`1 source, CancellationToken cancellationToken)
   at Microsoft.EntityFrameworkCore.EntityFrameworkQueryableExtensions.ToArrayAsync[TSource](IQueryable`1 source, CancellationToken cancellationToken)
   at ICT.AuthZ.InformationService.Api.Services.InformationDataService.GetPermsFromIndex(Guid applicationId, Guid customerId, Guid userId) in C:\Source\Repos\New_AuthZ\src\ICT.AuthZ.InformationService.Api\Services\InformationDataService.cs:line 27

I have some tests about this subject here and it works with Includes and Then Includes. If it doesn't work for you, first try the in-memory cache, if it worked, it means your Redis cache settings are wrong.

Thanks, I tried it with the in-memory cache like you suggested, and it works.
            var providerName = "Redis";
            services.AddEFSecondLevelCache(options =>
            {
                options.UseEasyCachingCoreProvider(providerName, isHybridCache: false)
                    .DisableLogging(true)
                    .UseCacheKeyPrefix("EF_");

                options.CacheAllQueries(CacheExpirationMode.Absolute, TimeSpan.FromMinutes(30));
            });

            services.AddEasyCaching(options =>
            {
                options
                    .WithProtobuf("proto")
                    .UseRedis(config =>
                    {
                        config.SerializerName = "proto";
                        config.DBConfig.AllowAdmin = true;
                        config.DBConfig.SyncTimeout = 10000;
                        config.DBConfig.AsyncTimeout = 10000;
                        config.DBConfig.Endpoints.Add(new ServerEndPoint("ict.bsp.redis", 6379));
                    }, providerName);
            });

I had setup Redis to use Protobuf as the serializer, after getting exceptions from the SDK about using the Binary serializer not being supported by default any longer.
So you think switching to message-pack might be the way to go? I will try that and let you know.

Thanks @VahidN! The link you provided gave me working config. My queries are now being cached and deserialised as expected.

Thanks @VahidN for the messagepack solution. Just one suggestion here, will that be possible to also bundle that class in future release so that others would able to find that instantly?
Anyway thank you for your effort. It is a great package =] cheers =]


student attempt at implementing termination of step function execution

It seemed like there was an open issue with regards to the lack of implementation of the termination of a step function and I made an attempt to implement it. Would love feedback / help in getting this implemented!! Im still learning so I appreciate any and all feedback :)

Closing since https://github.com/Netflix/metaflow/pull/1695 was merged.


FileStream always locks a file

I am writing a Log Analyzer with C# on Mac.
The log file is writing by another software and I am trying to use my Log Analyzer to read the same file at the mean time.
The file could be opened by VS Code, and I can also open it by C++ code.
But I cannot open it by C# code,
            using FileStream fileStream = new FileStream(path, FileMode.Open, FileAccess.Read, FileShare.ReadWrite);

I tried FileShare.ReadWrite, FileShare.Delete, FileShare.Read, FileShare.None, they all doesn't work.
Finnally I find out the reason:
// in FileStream.Unix.cs
        private void Init(FileMode mode, FileShare share, string originalPath)
        {
            _fileHandle.IsAsync = _useAsyncIO;

            // Lock the file if requested via FileShare.  This is only advisory locking. FileShare.None implies an exclusive
            // lock on the file and all other modes use a shared lock.  While this is not as granular as Windows, not mandatory,
            // and not atomic with file opening, it's better than nothing.
            Interop.Sys.LockOperations lockOperation = (share == FileShare.None) ? Interop.Sys.LockOperations.LOCK_EX : Interop.Sys.LockOperations.LOCK_SH;
            if (Interop.Sys.FLock(_fileHandle, lockOperation | Interop.Sys.LockOperations.LOCK_NB) < 0)
            {
                // The only error we care about is EWOULDBLOCK, which indicates that the file is currently locked by someone
                // else and we would block trying to access it.  Other errors, such as ENOTSUP (locking isn't supported) or
                // EACCES (the file system doesn't allow us to lock), will only hamper FileStream's usage without providing value,
                // given again that this is only advisory / best-effort.
                Interop.ErrorInfo errorInfo = Interop.Sys.GetLastErrorInfo();
                if (errorInfo.Error == Interop.Error.EWOULDBLOCK)
                {
                    throw Interop.GetExceptionForIoErrno(errorInfo, _path, isDirectory: false);
                }
            }

A lock is always there, no matter what FileShare is.
The only difference is a exclusive lock or a shared one.
But I don't really need the lock.
This blocks me a lot.
I cannot even write a log file tracker on Mac by C# using dot.net
I cannot even tail -f a file by C#....
This could be done easily by C++ or even by js code...
I cannot even believe that...

This repo is no longer actively monitored. Closing up old issues that have not had activity in while. If this is still an issue, please open a new issue in an appropriate repo listed in microsoft/dotnet#1275

This repo is no longer actively monitored. Closing up old issues that have not had activity in while. If this is still an issue, please open a new issue in an appropriate repo listed in microsoft/dotnet#1275


Sensor goes unavailable

Sensor goes unavailable if there no more events for on the end of the year. (hypothesis)
Example: Last week was last time restavfall was emptied for this year in this area. Sensor.restavfall goes unavailable the day after.
Same applies for sensor.glass_metallemballasje
December 20 is last event for sensor.papir this year, so if my hypothesis is right it should go unavailable the day after.
Will update issue.

Same here, sensor.glass went unavailable in Desember, papir now in january for me


s3 URL is wrong in sorry-cypress dashboard

Before opening, please confirm:

[X] I have searched for duplicate or closed issues and discussions.
[X] I have done my best to include a minimal, self-contained set of instructions for consistently reproducing the issue.
[X] I have read the documentation and found no answer to my problem

Environment information

  - sorry-cypress version: `latest`
  - cypress version: `latest`
  - cy2 version: `latest`
  - platform: `k8s`
  - service: `dashboard`

Describe the bug
It seems like the url for viewing screenshots is hard-coded in sorry-cypress dashboard. We are uploading to an s3 bucket in gov cloud and the url is incorrect for viewing the screenshots.
This is the correct bucket url:  https://company-cypress-tests.s3-us-gov-east-1.amazonaws.com
This is the url in the dashboard: https://company-cypress-tests.s3.amazonaws.com
Maybe its an issue with the s3 driver?
Expected behavior
Screenshots are viewable in the dashboard.
Reproduction steps
Set region: us-gov-east-1 in the sorry-cypress helm chart.
Full log and debug output

// Put your logs below this line

From testing, changing the readUrlPrefix will not be reflected in previous builds. If it pointed to the wrong resource, it will won't change after proper configurations.


http_get example uses outdated protocol

I started playing around with the http_get example and tried hooking it up to a nodejs server I threw together.  I can't figure out why the socket is returning response headers from my nodejs server and not when I serve the same page with Apache. The following files are logs of the response with SOCKETS_DEBUG LWIP_DBG_ON defined for extra info.  It didn't help me much, but perhaps it will help you help me!
apache_response.txt
node_response.txt
request-response_headers.txt

I believe the reason for this is twofold:

The http_get example actually uses the (very old) HTTP/0.9 protocol to talk to the remote server
Your nodejs server is not technically fully HTTP compliant, because it does not properly support HTTP/0.9 requests.

The original HTTP protocol (which later became "version 0.9") actually had no concept of headers.  The client simply sent a "GET path" command, and the server returned the content, with no metadata or headers of any kind.  Later, folks realized this was really not flexible enough for a lot of things, they added the concept of client and server headers as part of HTTP/1.0.  To make a HTTP/1.0 request, the client would change the GET (or POST, etc) request to have the form "GET path HTTP/1.0" instead.  In order to support backwards compatibility, however, if a server received a request without the "HTTP/1.0" on the end, it would still return the response (with no headers) the old HTTP/0.9 way.
I just looked at the http_get example code, and it's just sending "GET path" to the server, which means it's sending an old-style HTTP/0.9 request.  Apache is fully backwards-compatible, so it actually still supports this, and returns a response with no headers as it should.  It appears your node.js server, on the other hand, does not actually know how to send back a HTTP/0.9 response, so it sends back a HTTP/1.x response, even though the client asked for a HTTP/0.9 one (this is arguably wrong, but nowadays HTTP/0.9 is so old it probably doesn't matter much to most people).
Arguably, I think we really should change the http_get example to use a HTTP version from this century (which would also fix your issue), so I think it's valid to have this as an open bug against esp-open-rtos..  If you'd be interested in fixing it up we'd welcome a submission, otherwise I'll see if I can look into it sometime soon..

I've updated the title of this issue to better reflect the actual problem..  I also just realized when looking at the code again that the GET request that http_get sends is not only using HTTP/0.9, but is actually technically an invalid HTTP/0.9 request (it sends a "User-Agent" header, but headers aren't allowed in HTTP/0.9 requests), so this definitely needs a little work..

Yea I've already done some reworking on the http_get example so I'll get it up to date and submit a PR for it.  Thanks for the insight, I was really banging my head against the wall on this one :)

@jsuiker I was running into the same problem--couldn't get an expressjs server to process a POST request. I eventually came up with https://github.com/RLuckom/esp-open-rtos/blob/dht11/examples/dht11/dht11.c#L88 . It's very ugly (I started out just trying to read a DHT11 sensor and then just kept globbing more stuff into that file), but it works.

I think we'll just continue conversation over on issue #133


Allow optional secondary header fields based on secondary header flag

This tends to not happen very often in practice, but it's part of the spec and we should support it. PacketField's should have a keyword argument secondary_header=True (defaults False). When this keyword argument is true, they are only included parsed into the packet body when the secondary header flag is 1.
The array in the return dictionary should be made a MaskedArray in this case. It only makes sense to do this for VariableLength, because the FixedLength decoder relies on fixed spacing between the packets.

This is solved by the more general solution proposed in #72


Model wrapping behavior with scaling=True

At the moment, when GPflow models are passed to an acquisition function they are wrapped. If scaled=True is also passed to BayesianOptimizer the underlying models are retrained on scaled data.
This means the references the user has to his models will suddenly refer to scaled models. This is important to know for plotting and analyzing the modeling. Either:

we document this properly in the code
we make a copy of the model before wrapping it. This means the references the user has become useless. He could still reach the trained (wrapped!) models through acquistion.models (he has a reference to the acquisition) or via BayesianOptimizer.acquisition.models.

I think the best solution is to document this properly at the moment. A similar caveat to be documented is that data given to the GPflow models are best copies (X.copy(), Y.copy()) to avoid strange behavior.


Assert in Compact IDs optimization pass

This was originally found in dxc and filed as https://github.com/google/DirectXShaderCompiler/issues/264 . Since I've confirmed it's entirely constrained to SPIRV-Tools, I'm opening this issue and closing that one. I'll copy an edited version of the explanation from there.
a1f9e1342e77e47251e2f001d95f8af8a523745a recently altered which Analyses were preserved for the compact IDs pass. Instead of preserving nothing, it preserved a list of things including ir::IRContext::kAnalysisCFG . This last is a problem because as potentially changes the result IDs, it can change the basic block ID predecessors. IRContext::CheckCFG() uses a stale basic block ID to index predecessors and fires an assert. This function is only called inside an assert itself, so this is entirely a debug issue as manifest here. Though I wouldn't say for certain it doesn't have other effects.
The way to observe this issue is to build spirv-opt with debug symbols and run it on the .spv file included in the attached zip since github won't let me upload mysterious file extensions, but zipped mysterious files are a-okay. Any unoptimized spir-v file will probably work.
ppass.zip
Simply running spirv-opt  --compact-ids ppass.mO.spv -o ppass.spv is insufficient because the CFG has to be valid at the start of the compact IDs pass or it will get validated as soon as cfg() is called in CheckCFG() anyway. So you have to do some other optimization pass first. I did: spirv-opt  --redundancy-elimination --compact-ids ppass.mO.spv -o ppass.spv
I have a fix for the problem. I hoped to have a test to prevent regressions, but I was looking over the existing compact_ids_test and I'm unsure that the issue can be reproduced unless I can be sure that another pass is run before it. Maybe I can work it into the pass_manager_test. I'm open to suggestions though.

Here is a snippet you can use when writing a test:
  BuildModule(SPV_ENV_UNIVERSAL_1_1, nullptr, test, SPV_TEXT_TO_BINARY_OPTION_PRESERVE_NUMERIC_IDS);
  ASSERT_NE(nullptr, context);
  auto pass = CreateCompactIdsPass();

  opt::CompactIdsPass compact_id_pass;
  context->BuildInvalidAnalyses(compact_id_pass.GetPreservedAnalyses());
  compact_id_pass.Run(context.get());
  EXPECT_TRUE(context->IsConsistent());


chore: Migrate firestore synth.py to bazel

The changes in grpc stubs are caused by the gRPC upgrade from 1.10 (more than a year old) to 1.27 (same version which is used as runtime dependency)

@chingor13 PTAL

@BenWhitehead PTAL

@BenWhitehead The binary compatibility works now, but java 7 and 11 fail for some reason. PTAL


updated VPN link in README.md

I updated link to Neapolitan pizza association VPN as previous link was invalid and changed the description of link content. The VPN states sourdough as a viable "yeast" in the linked document.

Thank you for the contribution!


Charge to 100% doesn't work

I have my charge limit set to 90% and it holds charging till 90% even if i enable charge to 100% option. Even if I turn off automatically manage charging, it doesn't go above 90%. Worst part, even if i completely uninstall the app, the charging still holds up to 90%, it never goes above the charge limit i set in the app. I think something is conflicting, the app has changed the system settings so it follows the charge limit set in the app even after i uninstall the app completely.

@rurza please look into this, its like theres no possible way to charge to 100% if i dont reinstall the OS

And it doesn't charge even if you quit the app?

And it doesn't charge even if you quit the app?

it doesnt charge even if i uninstall the app, it has changed the internal settings

This clearly proves that BatFi isn’t the cause. You’ve installed something that interferes with power management.

This clearly proves that BatFi isn’t the cause. You’ve installed something that interferes with power management.

never installed anything other than batfi for battery related stuff, as soon as i installed batfi, im getting this problem though

And it persists even after restarting Mac?

And it persists even after restarting Mac?

yes, no way to fix it, tried everything, moreover the automatically manage charging also doesnt work, even if i turn it off, the battery is stuck at 80, optimized charging is turned off always so thats not the one causing problem is my guess

BatFi doesn’t set the limit; it pauses charging. The exception is the 80% system charging limit set during sleep and turned off when awake. Additionally, upon quitting, it resets all settings, and after a reboot, macOS resets all settings.

BatFi doesn’t set the limit; it pauses charging. The exception is the 80% system charging limit set during sleep and turned off when awake. Additionally, upon quitting, it resets all settings, and after a reboot, macOS resets all settings.

understandable, though seems weird why this happened only after batfi was installed. do u have any suggestions on what can i do to redo this?


Support for circular dependencies? No mention in documentation

There seems to be support for circular dependencies based on following issue: #2, #15 , #64 but I can't seem to find any mention of this in the documentation.
How do I do this? The following code causes a StackOverflowError
public static void main(String[] args) {

	Person parent = new Person();
	parent.setId(1);
	parent.setName("Richard");

	Child child1 = new Child();
	parent.setId(1);
	child1.setName("Chad");
	child1.setParent(parent);

	Child child2 = new Child();
	parent.setId(2);
	child2.setName("Rich");
	child2.setParent(parent);

	Child child3 = new Child();
	parent.setId(3);
	child3.setName("Kevin");
	child3.setParent(parent);

	parent.setChildren(Arrays.asList(child1, child2, child3));

	ModelMapper mapper = new ModelMapper();
	PersonResource personResource = mapper.map(parent, PersonResource.class);
	System.out.println(personResource);
}

Seems the circular reference issue was caused by a different issue.


Rewrite function to calculate flux

After a conversation in early March, John and I decided to look into rewriting the function that calculates the fluxes for the project.
The main components of this calculation are:

[x] Converting temperature and pressure to Kelvin and Pa, respectively
[x] Quantify the density of air given temp and pressure
[x] Multiply the ppmw by the density of air to return the new concentration (kg mol-1)
[x] Reduce concentration to mg / m-3 CH4 and g / m-3 for CO2
[x] Export results to ChamON_data

A new function should be created: src/matlab/MATLAB-functions/gas_unit_prep.mlx

Commit 6cecbb8 closes this issue


.btn inside .form-group does not respect margin-bottom

input, select and such inside a .form-group are defined with a margin-bottom of 15px. But a btn has a margin-bottom of 0. There is no definition of .form-group .btn to override the margin to align the button with all other elements.

@victoriafrench Please post a JS Bin or JS Fiddle that demonstrates the problem.

http://stackoverflow.com/questions/34934156/bootstrap-input-button-not-aligning-with-other-fields

user in post presented this fiddle.

Hi @victoriafrench!
You appear to have posted a live example (https://fiddle.jshell.net/yzw8q28q/5/show/light/), which is always a good first step. However, according to the HTML5 validator, your example has some validation errors, which might potentially be causing your issue:

line 60, column 5 thru column 129: Attribute placeholder not allowed on element select at this point.
line 76, column 7 thru column 131: Duplicate ID filter_discipline_id.
line 76, column 7 thru column 131: Attribute placeholder not allowed on element select at this point.

You'll need to fix these errors and post a revised example before we can proceed further.
Thanks!
(Please note that this is a fully automated comment.)

ignoring not my example

If you're posting it, then it's your example for our purposes.

After fixing the invalid HTML for you: https://jsfiddle.net/cvrebert/ebyak0jc/1/

Hi @cvrebert!
You appear to have posted a live example (https://fiddle.jshell.net/cvrebert/ebyak0jc/1/show/light/), which is always a good first step. However, according to Bootlint, your example has some Bootstrap usage errors, which might potentially be causing your issue:

line 76, column 7: E006: .input-group contains a <select>; this should be avoided as <select>s cannot be fully styled in WebKit browsers
line 73, column 1: E010: Input groups cannot contain multiple .form-controls
line 67, column 5: E042: .form-control cannot be used on non-textual <input>s, such as those whose type is: file, checkbox, radio, range, button
line 83, column 7: E042: .form-control cannot be used on non-textual <input>s, such as those whose type is: file, checkbox, radio, range, button
line 73, column 1: E044: .input-group must have a .form-control and either an .input-group-addon or an .input-group-btn.

You'll need to fix these errors and post a revised example before we can proceed further.
Thanks!
(Please note that this is a fully automated comment.)

@victoriafrench Could you please post a new, different example? The StackOverflow one has several unrelated errors and seems overly complicated given your original simple description.

Closing issue. Just discovered that the css the person is using does not match the released version. It has been modified. Also verified in less files that classes that appear in the css do not exist in github.


Peerflix NPAPI

How about making a browser NPAPI plugin based on Peerflix and Firebreath (not sure if it supports node.js)? There aren't any working / stable solutions out there for a plugin that simply plays torrents (except Ace Stream, but they are closed source and do black hat marketing on your PC).
As long as the plugin will be open source and reliable, I can really see this having a place in the online world. I remember Ninja Video (website) that made their own streaming plugin and they had more then 1 million unique visitors daily, so visitors installing a plugin for something like this seems ok to me.
It could come bundled with WebChimera Plugin (which is highly customizable) for video format support and I could make a fork of WebChimera Player to also fetch subtitles from the OpenSubtitles API. It would practically be a "Popcorn Time" plugin for websites, and I'm sure a lot of web developers would have fun playing with something like this.
I know this is what Feross plans on doing without plugins and that should be the proper course of things knowing that NPAPI support will be ended in late 2015 by Chrome (and maybe FireFox).
But bringing Peerflix to websites with a browser plugin might be the best way to also start seeding through WebRTC and help WebTorrent grow into the future pluginless implementation of this concept. :)

napapi is not supported any longer on new version of chrome so this can't be useful even as a stopgap idea
i've never heard of ninja video before could u describe how they worked ?
was it a vlc webplugin streaming http stream from different sources or did they have the vlcwebplugin act a player to a torrent client that starts a webserver to stream the data to a player like acestreams ?

I have the chrome installed on both laptop and PC and NPAPIs work without problems. Only Chrome Canary doesn't support NPAPIs, but Chrome Canary is not the official Chrome release, it's the bleeding edge experimental version of Chrome.
I'm unsure of what exactly the website plugin did, but I know it was NPAPI based, they used Divx Web Player and it started a local server that was streaming to the website page.
In about a week or so, maybe sooner, I'll release the plugin I was asking about (as msi and github repo), learned some C++ and started it myself in the meanwhile, made it work, just have to clean up the code and fix some minor bugs.

Ninja Video on NY Times: http://www.nytimes.com/video/technology/100000003133960/ninja-queen-criminal.html

Also, this doesn't need to be an NPAPI in the future when support is stopped, it could simply be a local application that could be called from the web with a registered anchor (like magnet links open the torrent application), only it opens WebChimera in a window with node-webkit.

that was quick thanks for the info

@yipperr Here it is: Powder NPAPI Plugin, keep in mind this is highly experimental atm.
It's a very simple plugin that sends (on request) a JSON Object with data to the browser page. The data in the JSON Object is simply the parsed output that Peerflix normally prints to the command line.

@jaruba  have you considered making it support the linux os the node linux binary and probably include the webchimeraplayer to play from the torrent-stream server also think about using the torrert-stream engine i din't have a look at the api

The plugin is made in C++, as I'm a novice with C++, I wouldn't know if it is possible to embed node.js in it directly. I used Peerflix because it outputs the data from torrent-stream to the command line.
The plugin launches a cmd.exe with Peerflix, parses the output of the command line and sends it to the browser page that requested it.
As of Linux / Mac OS versions, I guess the only difference would be to get the correct paths to the plugin folder and use the correct library to launch and kill terminal processes, as the parsing should be done the same. But I don't have the time to install other OS's and make versions to support them. The code should be easy enough to understand though, everything is in src\PowderNPAPIAPI.cpp and src\PowderNPAPIAPI.h.
I can make a simple example of it working with WebChimera Player as I've already done tests with it. (I'll try to do this today, shouldn't take long)

Also, a person that knows C++ well and has access to Linux and Mac OS might be able to make versions for them in 1 day. As the plugin itself is very simplistic, Peerflix is doing all the hard lifting.

sure i just wanted to let you there definitely is interest in npapi plugins so it a worthwhile project like you said because peerflix is awesome making it accessible is a good project but you already know this presume on a side note on the asm.js there is a compiled version of lib265.js in javascript
http://www.libde265.org/blog/2014/04/10/libde265-js-javascript-hevch-265-bitstream-decoder/
its runs a 47 fps on my laptop which is i7  i was searching for something like this

Glad to know you find it useful. :)
Does this demo work for you?
http://jaruba.github.io/PowderNPAPI/webchimera-demo/
This demo is streaming torrents directly on GitHub, that's funny in so many ways! :)))
I added some design elements too, getting bored of the simplistic white page demos.

The link you gave is indeed interesting, but I'm unsure of what video formats it supports. As the last comment implies it did not work for him with .mkv. Also, I guess .avi is out of the question.
For it to work with Peerflix and all torrent sources, it would need to support .mkv and .avi, as .mp4 is supported natively by the browser.
Also, it seems quite a bit slower then a plugin, on my laptop, which, I have to admit is full of 1000 chrome tabs, photoshop opened, and a lot of other crazy stuff atm, I get about 21 fps, and I can see the frame rendering, while WebChimera (and VLC Web Plugin by association) works great even with full hd sources. So on a performance scale, it clearly slower.
For a wide audience, this might not be the best choice. But if the website visitors need to install Powder Plugin anyway, i guess WebChimera (or any other web player plugin) could be bundled with the package.

@jaruba  it only play hevc bitstream files, the  library cannot parse any containers plugins run c++ code this is javasciprt over the v8 with ahead of time optimizations
unfortunately my university blocks torrents all through layer3 by blocking udp and by blocking all ports except 80 and 443 where they allow tcp only  only way out a ssl tunnel

Sounds like your university is a great place to hold a hacking marathon. :)
If the Lord of Time is generous to me, I'll try reserving some of it to making Linux and Mac OS versions too. But atm, I'm up to my neck in projects for the next few months.

not really all mostly idiots here lol. , the typical study for getting a job bunch they still byheart code to pass by so really not the place you described
if your interested i was in the process of stripping the hevc bitstream from this hevc file http://psarips.com/wp-content/uploads/2015/03/Transformers.Age_.of_.Extinction.Sample.mkv?_=0
with ffmpeg and play with the library just for fun :)

Sorry, have a lot of work to do today. :)


Add details to configuration instructions

Add more details to how to configure this.  Inexperienced users (like me) would not know the all-too-important hit "shift-reload" step and get frustrated.

Thanks!


added cypress tests to cover field requirements and validation

/test images

/lgtm

/cherry-pick release-4.13


Update Stable SOPS Version

Environment variables to add/change
What does this pull request do?

Changes the latest stable SOPS version from v3.7.2 to v3.7.3

How should this pull request be tested?
Questions or comments:
Ideally, the getstableSopsVersion function should be getting this value using toolCache.downloadTool, however that seems to be throwing a 403. Not entirely sure what the recommended solution is for that - there is an open issue for it - so in the meantime this will update the fallback to the latest SOPS version.

Hi @namack , I'm gonna continue looking into this issue tomorrow. Thanks for raising it and for suggesting a fix.
ℹ Another workaround until I can get a proper fix in place would be to specify a version; 3.7.3 instead of latest.

@mdgreenwald Sure thing - I didn't realize the rate limit was a problem until after I opened the PR. I didn't had time to investigate solutions for the root cause so I can close this.


Expose some library-wide functionalities

Expose:

Set/get shutdown options
Report live objects
Force shutdown

/azp run


Roll to v0.7.3-hotfix.1 engine

This contains a minor change to the engine. This is a test of the
emergency patch process for releases.

cc @tvolkert

Looks like the engine bots didn't build the artifacts.

Looks like the bots build 3930b7c0d6451994ede745e03fddd6d63400da99.


Do I need to annotate if cells are healthy or malignant?

Dear Maria,
When I annotate the cell type I’ll have both healthy and malignant B cells in the samples. Do I need to specify that or simply indicate B-cells?
Thanks!
Verena

Hi Verena,
You don't have to annotate the malignant B cells in any special way, you can put them as the B cell category even if there is a mixture of malignant B cells and a small rest of the healthy B cells in your tumor samples, the algorithm will "notice" that there are two populations by checking the "active fraction" component.
Best,
Maria


Wrong data type for resource 5701 in models

In leshan-server-demo/src/main/resources/models, the reusable resource 5701 (Sensor Unit) is defined as a Float instead of a String in xml files:

3300.xml
3316.xml to 3330.xml
3346.xml

(You can use the command git grep -A 5 5701 to check.)

We used this URL to update our models : http://www.openmobilealliance.org/wp/OMNA/LwM2M/DDF.xml
And it points to :
http://www.openmobilealliance.org/tech/profiles/lwm2m/3300.xml
http://www.openmobilealliance.org/tech/profiles/lwm2m/3330.xml
http://www.openmobilealliance.org/tech/profiles/lwm2m/3316.xml
http://www.openmobilealliance.org/tech/profiles/lwm2m/3346.xml
where Sensor Unit is a float.
I will fix this in Leshan demo because a sensor unit typed as float doesn't make sense. but we should also report that to OMA (else next time we will update models we risk to introduce this bugs again)

@dnav did you notify OMA about that ?

https://github.com/OpenMobileAlliance/OMA_LwM2M_for_Developers/issues/212 looks like to our issue here.


Chips with onDeleted callback should show the delete button in the disabled state

Is there an existing issue for this?

[X] I have searched the existing issues
[X] I have read the guide to filing a bug

Steps to reproduce
At the moments chips with onDeleted don't show the delete button icon when disabled. This matches the Flutter documentation https://master-api.flutter.dev/flutter/material/DeletableChipAttributes/onDeleted.html
However when looking the specs, I can see chips show the delete button icon in the disabled state

But this is what we see in Flutter

Expected results
Chips show the delete icon button when disabled
Actual results
Chips don't show the delete icon button when disabled
Code sample
Code sample
import 'package:flutter/material.dart';

void main() => runApp(const MyApp());

class MyApp extends StatelessWidget {
  const MyApp({super.key});

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      debugShowCheckedModeBanner: false,
      theme: ThemeData(
        colorScheme: ColorScheme.fromSeed(seedColor: Colors.green).copyWith(
          onSurfaceVariant: const Color(0xffff0000),
          onSecondaryContainer: const Color(0xff0000ff),
        ),
      ),
      home: const Example(),
    );
  }
}

class Example extends StatefulWidget {
  const Example({super.key});

  @override
  State<Example> createState() => _ExampleState();
}

class _ExampleState extends State<Example> {
  @override
  Widget build(BuildContext context) {
    return Scaffold(
      body: Center(
        child: Column(
              mainAxisAlignment: MainAxisAlignment.spaceEvenly,
              children: <Widget>[
                RawChip(
                  avatar: const Icon(Icons.favorite_rounded),
                  label: const Text('RawChip'),
                  onSelected: null,
                  isEnabled: false,
                  onDeleted: () {},
                ),

                InputChip(
                  avatar: const Icon(Icons.favorite_rounded),
                  label: const Text('InputChip'),
                  isEnabled: false,
                  onPressed: null,
                  onDeleted: () {},
                ),

              ],
            ),
      ),
    );
  }
}

Screenshots or Video

Screenshots / Video demonstration
[Upload media here]

Logs
Logs
[Paste your logs here]

Flutter Doctor output
Doctor output
[✓] Flutter (Channel master, 3.16.0-11.0.pre.69, on macOS 14.0 23A344 darwin-arm64, locale en-US)
    • Flutter version 3.16.0-11.0.pre.69 on channel master at /Users/tahatesser/Code/flutter
    • Upstream repository git@github.com:TahaTesser/flutter.git
    • FLUTTER_GIT_URL = git@github.com:TahaTesser/flutter.git
    • Framework revision b66ab70c09 (4 hours ago), 2023-10-16 02:37:09 -0400
    • Engine revision 539ad5b232
    • Dart version 3.3.0 (build 3.3.0-27.0.dev)
    • DevTools version 2.28.1

[✓] Android toolchain - develop for Android devices (Android SDK version 34.0.0)
    • Android SDK at /Users/tahatesser/Code/android-sdk
    • Platform android-34, build-tools 34.0.0
    • ANDROID_SDK_ROOT = /Users/tahatesser/Code/android-sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jbr/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 17.0.6+0-17.0.6b829.9-10027231)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 15.0)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 15A240d
    • CocoaPods version 1.13.0

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2022.3)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 17.0.6+0-17.0.6b829.9-10027231)

[✓] VS Code (version 1.83.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.74.0

[✓] Connected device (2 available)
    • macOS (desktop) • macos  • darwin-arm64   • macOS 14.0 23A344 darwin-arm64
    • Chrome (web)    • chrome • web-javascript • Google Chrome 117.0.5938.149

[✓] Network resources
    • All expected network resources are available.

• No issues found

It is also mentioned in the in this description that the disabled chip should show the deleteButton,  and it is even made room for in the layout: See picture.

The fix for this is blocked by https://github.com/flutter/flutter/issues/138009


Make bucket_name configurable

Enhancement Proposal
Our current coordinator charm assumes a pre-defined name of the loki s3 bucket:
https://github.com/canonical/loki-coordinator-k8s-operator/blob/main/src/charm.py#L66
We should make it configurable, with a reasonable default (probably the current value).

This is now possible via cos-lib :)


Allow plugin control via deep links

Adds ability to install/configure plugins via the following deep links:
kap://install-plugin/{plugin name}
Pops up preferences on the discover tab scrolls to the plugin, and triggers an installation. If it's already installed, it just scrolls to it.
kap://configure-plugin/{plugin name}
Pops up preferences, scrolls to the plugin and opens the config window
Also fixed some small issues, including a circular dependency I introduced a few PRs ago which was causing the built app not to run
To test this build, after you've downloaded and installed it, click here:

And then to configure:
kap://configure-plugin/kap-record-time
EDIT:
seems like GH doesn't support links with custom schemes, so copy-paste the links underneath for now. We can probably create a small lamda to re-route to the deep link
~These badges are some examples I generated with shield.io, but we can make our own custom images, host them under https://getkap.co/buttons/{install|configure} so we can add buttons like that to the plugin readmes~
https://github.com/wulkano/getkap.co/pull/36

Pops up preferences on the discover tab scrolls to the plugin, and triggers an installation.

Is it safe to trigger to installation automatically? I'm honestly not sure. Just wanted to bring it up.

seems like GH doesn't support links with custom schemes, so copy-paste the links underneath for now. We can probably create a small lamda to re-route to the deep link

That's a good workaround, yes. Or a Vercel function.

Is it safe to trigger to installation automatically? I'm honestly not sure. Just wanted to bring it up.

I had the same thought initially but I don’t see how it would not be. Another option I thought of would be to open, scroll into view and have a yes/cancel modal saying ‘would you like to install x’
So you’re sure that the plugin linked is what you think you’re installing

It now shows a dialog like this to confirm before installing:

Tried it out and works great. I really like how it even scroll down and shows the plugin.


Can't access the same resource in concurrent way

Hello, it's seems the server doesn't support the client access the same resource in concurrent before the previous operation is not returned ?
For example here has the resource: http://<IP_ADDRESS>/match/123, I use the Chrome to access it, the server takes a few seconds say 10 seconds to find the process this request likes query database. During that if I use firefox to access http://<IP_ADDRESS>/match/123, seems the resource handle function didn't called until the first operation returned.

This is typical when the thread pool gets busy, however, you can use Response::flush to temporarily release the resource from the thread pool so that other threads can perform their tasks.

It's not help to me, the second request doesn't goes to here before the sleep end.
server.resource["^/match/([0-9]+)$"]["GET"] = [](SimpleWeb::Server<socket_type>::Response& response, shared_ptr<SimpleWeb::Server<socket_type>::Request> request) {
	string number = request->path_match[1];

	response.flush();
	Sleep(1000 * 20);

response << "HTTP/1.1 200 OK\r\nContent-Length: " << number.length() << "\r\n\r\n" << number;
};

The only way to work around this, that is having one thread per resource request, is to increase the thread pool size (see the Server-constructor).

See the heavy work example


Missing dependency(?)

I wanted to built stellar myself with the built via Docker option (because there are no armhf binaries) and got this
-> building daemon e70a943-dev
../../vendor/github.com/mholt/caddy/caddytls/client.go:30:2: cannot find package "github.com/xenolf/lego/acme" in any of:
        /go/src/github.com/ehazlett/stellar/vendor/github.com/xenolf/lego/acme (vendor tree)
        /usr/local/go/src/github.com/xenolf/lego/acme (from $GOROOT)
        /go/src/github.com/xenolf/lego/acme (from $GOPATH)
make: *** [Makefile:50: daemon] Error 1
 -> Built dev version e70a943 (linux/amd64)

I now manually added a go get ... but now I get
# github.com/ehazlett/stellar/vendor/github.com/mholt/caddy/caddytls
../../vendor/github.com/mholt/caddy/caddytls/config.go:122:10: undefined: acme.KeyType
make: *** [Makefile:50: daemon] Error 2

I ran into this a lot with some of the caddy dependencies.  Let me take a look to see if I can reproduce.

Ok I was able to reproduce and just pushed a quick fix to the docker build dockerfile.  It's not the greatest as the COPY busts the go module vendor but once buildkit integration is fully complete we can leverage that for some better caching.  It should be building now (I tested both x86 and arm compiles).  Thanks for reporting!

ugh I'm getting random failures now as well.  I'm going to re-think the vendoring and see if I can find why go mod vendor isn't placing all the needed deps in the local vendor.

OK so some how vendor/github.com/xenolf/acme was added as a submodule.  I've fixed it (as well as removed the Go module vendoring for now) so all dependencies should reside in vendor.  I also checked on a completely fresh aws instance just to be sure.  Thanks for reporting and sorry for the issues!

Now it works perfectly! Thanks!
What's the reason for using the vendor dir anyway? Why don't you use go modules only?

@Hades32 the vendor dir is for backwards compat (pre-Go module versions) and to be able to build locally in the event of a network failure.  There is also the issue if someone removes a branch or rebases (I've ran into this as well with Go modules).


Change pages to the proper ID from prod (DF-1669)

We're pulling content from pages by their ID.  Previously, we were pulling them from build, but now we need to be pulling them from prod.  Since they don't have the same auto-assigned IDs, this PR simply switches the IDs to match the new ones on prod.
@sebworks @anselmbradford @jimmynotjim @willbarton @kurtw this will break your local install for the following pages, until you re-index from www.cf.gov:
http://localhost:7000/budget/financial-report/
http://localhost:7000/budget/performance-plan-report/
http://localhost:7000/budget/strategic-plan/interactive/
http://localhost:7000/doing-business-with-us/future-requests/
http://localhost:7000/doing-business-with-us/past-awards/
http://localhost:7000/doing-business-with-us/small-businesses/
http://localhost:7000/budget/funding-request/
You can fix that with this one-liner:
WORDPRESS=http://www.consumerfinance.gov sheer index --processors pages --reindex
This also means we'll have to index pages from prod on flapjack for the time being, until we find a more elegant solution.

LGTM :+1:

This also means we'll have to index pages from prod on flapjack for the time being, until we find a more elegant solution.

Do you have an idea of how long it might be this way? We may want to update
[GHE]/flapjack/Getting-started-with-Flapjack/wiki/Server-access-and-settings#local-environment-variables if it isn't within a few sprints out.

I'd like to talk through that a bit more with some of you guys.  Right now I'm thinking it might simplify things if we index everything consistently from prod, with the exception of one-off items that we test locally via build.  That last part would require adding a new feature to sheer index that allows for indexing a single item.

:+1:


Bump brick and vty versions

This allows building hledger-iadd on windows.
The supported terminal emulators do not cover the full spectrum, but that's a start. This article has https://github.com/chhackett/vty-windows/wiki/TerminalSupport some more info.

I don't have a windows system to test this, but the change seems reasonable anyway. Thank you for the patch!


Implement a module loader that dynamically finds IBaristaModules in assemblies

Would look at, say, a barista_modules folder and using unity or ninject — or possibly Microsoft.Extensions.DI — finds all implementations and makes them available to scripts

See https://shazwazza.com/post/custom-assembly-loading-with-aspnet-core/


⚠ Bofrost.fr has degraded performance

In 0fc134a, Bofrost.fr (https://www.bofrost.fr) experienced degraded performance:

HTTP code: 200
Response time: 950 ms

Resolved: Bofrost.fr performance has improved in 497c9e4.


Anomalous data for AB 19-05-2020

Since cumulative numbers shouldn't be able to go down, I assume this was a typo. 5584 fits...
Needs research.

It is 5574 according to awkward graph provided by the AB gov't.

Thanks! Seems there was a typo in the original data release:

Thanks for spotting this! Seems there was a typo in the original data release:
https://github.com/johanley/covid-19-canada/blob/master/data/screenshots/2020-05-19_21h15mADT/ab.png
We'll fix this on our internal sheets and deploy a data update momentarily.

Happy to help, and thanks to all of you maintaining this data!
I've been merging the recoveries data with the JHU data to update my covid19 site:
https://esklarski.github.io/canada.covid19/
Recoveries data isn't widely available for Canada but really helps to viualize what's going on.

Happy to help, and thanks to all of you maintaining this data!
I've been merging the recoveries data with the JHU data to update my covid19 site:
https://esklarski.github.io/canada.covid19/
Recoveries data isn't widely available for Canada but really helps to viualize what's going on.


Activate and use graphQL typegen

This PR adds the freshly introduced graphQL typegen feature. This makes our own types for the query data obsolete.
Closes #76

Note: we also need to add src/templates, src/types and possible future directories to tailwind.config.js, if we want to use tailwind classes in these.


Use one Messanger object for multiple pages

Hi,
We're working on an app that works with multiple pages (Wix.com).
We really like this library, however, it's limited to only one page.
We would like to pass the pageAccessToken parameter per req and not when creating the Messanger object ('Messanger.create')
Few suggestions to solve this problem-

MessageResponse send(@NonNull Payload payload) will have an optional parameter pageAccessToken and if it present it'll override the one from creation.

Create another Messanger class that will work differenetly and support this functionality. There will be a common Messanger that stores the heavy objects (httpclient, jsonparser...) and the old Messanger and also the new one will both use it.

We can implement this. What do you think?

Messenger object is not heavy and does not have runtime background tasks.
So just 2 options for you:

Create Messenger ad hoc right at required space with known pageAccessToken
Use caches to store all Messengers for all required pages.

@PhantomYdn what do you think? Isn't creating Gson&JsonParser objects every time expensive? Can we do anything to make it happen?

Another option is to extract the code from com.github.messenger4j.Messenger#onReceiveEvents to another class and let me handle the HTTP and Parsing and just use the logic of the library.

Why don’t you just link your messenger apolication to all your pages? Why would you need more than one pageAccessToken?
You can subscribe to more than one fb page in your application.

Hi, my application let my users to connect their page's messanger to my application.
So the user can answer to messages coming to his facebook page from my app.
I have millions of users ;-)

Hi Maxim, I was off in the last weeks and month but now I'm back. I will get back to you today or tomorrow ✌

@maximn - I still don’t get it because you said you only have one application or do you have more than one applications for different business needs? Then you would require more than one token

I have one application. It's a SAAS that let my users connect their facebook pages to my app.
Then these users can use my app to chat on facebook. And I have a lot of users.
Hope this makes it more clear.


Request : Enemy expension

Hi there !
Are you open to requests by chance ? =}
If yes, I wonder if the debug "show-enemy-expension-candidate-chunks" could be added ? Useful debug !
In any case, thanks for the mod ! Useful too !

Hello,
As far as I know expansion chunks overlay is not exposed in the API to be toggled by mods.

Ah too bad =(
( Well it's not like it is just three clicks away after all lol I feel like a lazy fk now I think of it xD )
Thanks for your quick answer ! =)


Tauri Drag and Drop Events Not Firing on Windows [bug]

Describe the bug
The following Tauri events do not fire on Windows:
tauri://file-drop-hover
tauri://file-drop-cancelled
tauri://file-drop

I also set dragDropEnabled to true but still it does not fire.
Here is a demo project : https://github.com/selastingeorge/Tauri-File-Drop
Reproduction
Create a new tauri app and set dragDropEnabled  to true in tauri.config.json.
add following code to the script file:
    import { listen } from '@tauri-apps/api/event'
    listen('tauri://file-drop', event => {
      console.log(event)
    })
    listen('tauri://file-drop-hover', event => {
      console.log(event)
    })
    listen('tauri://file-drop-cancelled', event => {
      console.log(event)
    })

Expected behavior
The console should print the event object.
Full tauri info output
[✔] Environment
    - OS: Windows 10.0.22631 X64
    ✔ WebView2: 123.0.2420.65
    ✔ MSVC: Visual Studio Community 2022
    ✔ rustc: 1.77.0 (aedd173a2 2024-03-17)
    ✔ cargo: 1.77.0 (3fe68eabf 2024-02-29)
    ✔ rustup: 1.27.0 (bbb9276d2 2024-03-08)
    ✔ Rust toolchain: stable-x86_64-pc-windows-msvc (default)
    - node: 20.11.0
    - npm: 10.2.4

[-] Packages
    - tauri [RUST]: 2.0.0-beta.14
    - tauri-build [RUST]: 2.0.0-beta.11
    - wry [RUST]: 0.39.0
    - tao [RUST]: 0.27.0
    - tauri-cli [RUST]: 2.0.0-beta.12
    - @tauri-apps/api [NPM]: 2.0.0-beta.7
    - @tauri-apps/cli [NPM]: 2.0.0-beta.12

[-] App
    - build-type: bundle
    - CSP: unset
    - frontendDist: ../dist/filedrop/browser
    - devUrl: http://localhost:1420/
    - framework: Angular
    - bundler: Webpack

Stack trace
No response
Additional context
No response

The events were renamed to
tauri://drag
tauri://drop
tauri://drop-over
tauri://drag-cancelled

Please bear with us while we're working on the docs...

Just a heads up, it appears the names have changed again in 2.0.0-rc.0.


Fix a broken link in concepts/extend-kubernetes/compute-storage-net/device-plugins.md

This PR just fixes a broken link in concepts/extend-kubernetes/compute-storage-net/device-plugins/.

Preview page:
https://deploy-preview-22147--kubernetes-io-master-staging.netlify.app/docs/concepts/extend-kubernetes/compute-storage-net/device-plugins/#what-s-next
Look at the last link in the "What's next" section.

/assign @steveperry-53

/lgtm
/approve


Data API

Hi,
Is there a way to enable the Data API for a Aurora Serverless? Enabling it manually is not too much work, but it would be great if it could be done through code.
Thanks!

This would be great, I agree its quite easy to do manually but would love to see this in soon.

Would like this to, follow.

This would be nice! +1

Also looking forward to this!

+1

FYI there is a PR now: https://github.com/terraform-providers/terraform-provider-aws/pull/11048

FYI: I have put together a PoC for managing aurora serverless DB using the DataAPI. Please take a look and let me know what you think :)
[terraform-provider-postgresql] (https://github.com/awsiv/terraform-provider-rdsdataservice)


importlib.metadata.PackageNotFoundError: No package metadata was found for gnss-lib-py

Describe the bug
"poetry run pytest" reports package metadata not found
To Reproduce
Steps to reproduce the behavior:

git clones the gnss_lib_py repository;
run poetry run pytest

Expected behavior
Could execute the test scripts
Screenshots
[mikehuang@localhost gnss_lib_py-1.0.2]$ poetry run pytest
Creating virtualenv gnss-lib-py-7gV7y9ay-py3.11 in /home/mikehuang/.cache/pypoetry/virtualenvs
ImportError while loading conftest '/home/mikehuang/Downloads/gnss_lib_py-1.0.2/tests/conftest.py'.
tests/conftest.py:14: in
from gnss_lib_py.navdata.navdata import NavData
gnss_lib_py/init.py:39: in
version = metadata.version("gnss-lib-py")
E   importlib.metadata.PackageNotFoundError: No package metadata was found for gnss-lib-py
[mikehuang@localhost gnss_lib_py-1.0.2]$
System Information (please complete the following information):

OS: Fedora
OS Version: 39
Python Version: 3.11

Additional context

Were you following the "Developer Installation" instructions here? https://gnss-lib-py.readthedocs.io/en/latest/install.html
Did you have any errors when installing gnss_lib_py with poetry install after you cloned the repository ?
When you run the poetry install command you should see a print statement that says gnss_lib_py was installed.

poetry install -r requirements.txt reports following errors at the end.
ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts.
google-auth 2.22.0 requires urllib3<2.0, but you have urllib3 2.1.0 which is incompatible.
Successfully installed anyio-4.2.0 argon2-cffi-23.1.0 argon2-cffi-bindings-21.2.0 arrow-1.3.0 asttokens-2.4.1 async-lru-2.0.4 babel-2.14.0 beautifulsoup4-4.12.3 certifi-2023.11.17 cffi-1.16.0 comm-0.2.1 contourpy-1.1.1 cycler-0.12.1 debugpy-1.8.0 defusedxml-0.7.1 executing-2.0.1 fastjsonschema-2.19.1 fonttools-4.47.2 fqdn-1.5.1 georinex-1.16.1 importlib-resources-6.1.1 ipykernel-6.29.0 ipython-8.12.3 ipywidgets-8.1.1 isoduration-20.11.0 jedi-0.19.1 json5-0.9.14 jsonpointer-2.4 jsonschema-4.21.1 jsonschema-specifications-2023.12.1 jupyter-1.0.0 jupyter-client-8.6.0 jupyter-console-6.6.3 jupyter-core-5.7.1 jupyter-events-0.9.0 jupyter-lsp-2.2.2 jupyter-server-2.12.5 jupyter-server-terminals-0.5.1 jupyterlab-4.0.11 jupyterlab-pygments-0.3.0 jupyterlab-server-2.25.2 jupyterlab-widgets-3.0.9 kaleido-0.2.1 markupsafe-2.1.3 matplotlib-3.7.4 mistune-3.0.2 nbclient-0.9.0 nbconvert-7.14.2 nbformat-5.9.2 ncompress-1.0.1 nest-asyncio-1.5.9 notebook-7.0.7 notebook-shim-0.2.3 numpy-1.24.4 overrides-7.4.0 packaging-23.2 pandas-2.0.3 pandocfilters-1.5.1 pillow-10.2.0 platformdirs-4.1.0 plotly-5.18.0 pluggy-1.3.0 prometheus-client-0.19.0 prompt-toolkit-3.0.43 pycparser-2.21 pygments-2.17.2 pyparsing-3.1.1 pytest-7.4.4 python-dateutil-2.8.2 python-json-logger-2.0.7 pytz-2023.3.post1 pyzmq-25.1.2 qtconsole-5.5.1 qtpy-2.4.1 referencing-0.32.1 rfc3339-validator-0.1.4 rfc3986-validator-0.1.1 rpds-py-0.17.1 scipy-1.10.1 send2trash-1.8.2 sniffio-1.3.0 soupsieve-2.5 stack-data-0.6.3 terminado-0.18.0 tinycss2-1.2.1 tornado-6.4 traitlets-5.14.1 types-python-dateutil-<IP_ADDRESS>40106 tzdata-2023.4 uri-template-1.3.0 urllib3-2.1.0 wcwidth-0.2.13 webcolors-1.13 websocket-client-1.7.0 widgetsnbextension-4.0.9 xarray-2023.1.0

After commenting the last line of gnss_lib_py/init.py, poetry run pytest works for me,
# single location of version exists in pyproject.toml
# __version__ = metadata.version("gnss-lib-py")

Hi again, @mikehb I'll need some additional information to be able to help you.
It sounds like you may be interchanging installing with pip vs. poetry and switching between the "Standard Installation" and "Developer Installation" on our Installation page guide.
In the latest poetry, poetry install -r requirements.txt is not valid command. Were you running pip install -r requirements.txt? For the developer installation, the correct installation command is simply running poetry install in the gnss_lib_py directory as shown in the image below:

The error you sent indicates an incompatibility between the version of urllib3 that gnss-lib-py requires and that google-auth 2.22.0 requires. gnss-lib-py has no dependency on google-auth so I'm guessing you're trying to install both packages into the same environment which is causing the problems.
You could try to remedy the issue by either

following our developer instructions which use pyenv to isolate gnss-lib-py in its own virtual environment
google-auth may have happend to update their dependencies which you could check by upgrading google-auth with pip install --upgrade google-auth then removing gnss-lib-py with pip uninstall gnss_lib_py and starting the installation process again

I was able to install the latest versions of both google-auth and gnss_lib_py without any issues on my computer, so I don't know how else to replicate your problem.
I hope this helps.


Missed something in the last commit

You forgot to change to change the value for the state exists check inside of stateLoadFunc.
https://github.com/Steveice10/GameYob/commit/322c1a8bc35b81692853b98e52334cf438fee2a2#diff-7a35500e651bb8cb2ea0eb181ab63b7aL176

Just fixed.


Update ark restore to not open every single file open during extracti…

…on of the data
Original error was:
ark -n <redacted> restore logs <redacted>
time="2019-03-06T18:31:06Z" level=info msg="Not including resource" groupResource=nodes logSource="pkg/restore/restore.go:124"
time="2019-03-06T18:31:06Z" level=info msg="Not including resource" groupResource=events logSource="pkg/restore/restore.go:124"
time="2019-03-06T18:31:06Z" level=info msg="Not including resource" groupResource=events.events.k8s.io logSource="pkg/restore/restore.go:124"
time="2019-03-06T18:31:06Z" level=info msg="Not including resource" groupResource=backups.ark.heptio.com logSource="pkg/restore/restore.go:124"
time="2019-03-06T18:31:06Z" level=info msg="Not including resource" groupResource=restores.ark.heptio.com logSource="pkg/restore/restore.go:124"
time="2019-03-06T18:31:06Z" level=info msg="Starting restore of backup backup/<redacted>" logSource="pkg/restore/restore.go:342"
time="2019-03-06T18:31:06Z" level=info msg="error unzipping and extracting: open /tmp/604421455/resources/rolebindings.rbac.authorization.k8s.io/namespaces/<redacted>/<redacted>: too many open files" logSource="pkg/restore/restore.go:346"

Downloading the directory from s3 and untarring it I found 1036 files. The ulimit -n output says 1024. This is our team's best guess at a root cause. But the code fixed in the PR definitely is holding all the files open until the method closes: https://blog.learngoprogramming.com/gotchas-of-defer-in-go-1-8d070894cb01
Please note my go code abilities are not great and I did not test this. I just edited the file in github. All I did was remove the defer and put fileClose after the copy is done. Theoretically this should only hold one file open at a time now. Let me know if you want me to do any further steps.
Thank you,
-Asaf

cc @timmycarr Hi Tim, this is Asaf from Groupon. We noticed the above issue after using ark for some time now. Can you please notify whoever can look at this when it's possible?
Thank you,
-Asaf

@asaf-erlich thanks for the issue report + fix! I'll take a look this afternoon.

Thank you @skriss . A teammate pointed out the sign-off is required - I'll try to get to that: https://github.com/heptio/velero/blob/master/CONTRIBUTING.md

yep -- git commit --amend --signoff followed by git push -f should do the trick

@skriss ok thanks I'll do that

Done it's signed

@skriss thankfully @alaimo helped me out and wrote the function for me. I'll address your other feedback and squash all of them to a single commit.

# github.com/heptio/velero/pkg/restore
pkg/restore/backup_extractor.go:54:12: file.close undefined (type io.WriteCloser has no field or method close, but does have Close)

I'll see to this.

@nrb or @carlisia please review and merge, thanks!


Markdown doesn't support HTML elements

In CommonMark syntax, it is allowed to have HTML elements. And following the discussion here, we can use <div> to escape the text which we don't want to be rendered as markdown.
However, it looks like the Markdown component doesn't support HTML elements. If I use the code below,
const {whisper} = require('@oliveai/ldk');
await whisper.create({
  label: 'test',
  components: [
    {
      type: whisper.WhisperComponentType.Markdown,
      body: `<div>\n- 123<br>\n- 456<br>\n</div>`,
    },
  ],
  onClose: () => {},
});

I see

And if I use the same text in https://spec.commonmark.org/dingus/ , I see

Is the Markdown implementation of LDK based on an older version of the spec?

Hi Hans,
I did some digging around in the code this morning. The library that we use for rendering Markdown escapes HTML in Markdown by default for security reasons.
Based on discussion with the team, we do not currently plan to support HTML in Markdown, so at this time, this is the expected behavior.
Is your team looking at this as a solution primarily for the purposes of escaping special characters?

Hi Hans,
I did some digging around in the code this morning. The library that we use for rendering Markdown escapes HTML in Markdown by default for security reasons.
Based on discussion with the team, we do not currently plan to support HTML in Markdown, so at this time, this is the expected behavior.
Is your team looking at this as a solution primarily for the purposes of escaping special characters?

Yes. We want to use it to escape characters that may be accidentally rendered as Markdown. I understand you may want to disable HTML for security. For our current use case, it's not a strong requirement for escaping. Therefore, let me close this issue. Thank you for checking the code for us. :)


Omni for Terminal.app

Add a new theme to the organization
If you have already created a theme, make sure you check the following requirements:

[X] The theme follows the template;
[X] The theme follows the Omni Color Palette;
[X] The branch name is main (we will keep this name pattern from now on);
[X] The theme has correct instructions on how to install it;
[X] The repository name is lowercase and contains just the application name. E.g. visual-studio-code.

Application: Terminal.app
Application URL: https://en.wikipedia.org/wiki/Terminal_(macOS)
GitHub URL: https://github.com/demartini/terminal

Wow, another awesome theme. Thanks @demartini 💜
We can include the theme in the organization. 🎉
Since you already are a member of the org, you can transfer your repository!
Just make sure to open a PR and include the theme on the main repository 👊🏻
Also, after the transfer, make sure to change all URLs to match the new repository link.
If you want, open a PR with all the new themes (you don't need to create 3 separate PR's).

Hey @jpedroschmitz we need to create the Terminal.app team so I can finish the transfer.

Sorry, I forgot to do so :/
I created the team!

No problem! :laughing:
I just finished the transfer and PR #27 opened.

Please leave the actions enabled so that we can release the new versions when the source code is changed.

Thanks for creating all these themes @demartini! 🚀


Note In Support For Output Variables Is Out Of Date And Incorrect

The note in Support for output variables states:
You cannot consume output variables in different stages. To share variables between stages, output an artifact in one stage and then consume it in a subsequent stage.

This is old and directly conflicts with  Use outputs in a different stage
To use the output from a different stage at the job level, you use the stageDependencies syntax

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 5aeeaace-1c5b-a51b-e41f-f25b806155b8
Version Independent ID: fd7ff690-b2e4-41c7-a342-e528b911c6e1
Content: Deployment jobs - Azure Pipelines
Content Source: docs/pipelines/process/deployment-jobs.md
Product: devops
Technology: devops-cicd-process
GitHub Login: @juliakm
Microsoft Alias: jukullam

@vanderby  Thank you for the feedback, please consider becoming a contributor.
The documentation has been updated and is pending review.


Update definition structure

Description
Updated the plugin definition of rest_api to use the up to date definition structures.
Linked Items:
Closes/Fixes/Resolves #4
Added
Updated definition structure implemented.
Changed

Describe any changes in existing functionality.

Deprecated

Describe any deprecated features.

Removed

Describe any removed features.

Fixed

Describe any bug fixes.

Security

Describe any security-related changes.

Checklist:

[ ] I updated project documentation to reflect my changes.
[ ] My changes generate no new warnings.
[ ] I updated new and existing unit tests to account for my changes.
[ ] I linked the associated item(s) to be closed.
[ ] I bumped the version.
[ ] I added the labels corresponding to my changes.

Don't forget to bump your version.


Merge bitcoin#10762: [wallet] Remove Wallet dependencies from init.cpp

This is a dependency for https://github.com/bitcoin/bitcoin/pull/10740 which I am planning on backporting into 0.16 as it seems to be one of the more requested features

rebased on develop

Done, left two comments on your commit


is_colliding() not working properly

Godot version:
3.2.3-mono
OS/device including version:
Windows 10, laptop with NVIDIA GeForce GTX 1050, Intel Core i5-8300H
Issue description:
RayCast is_colliding() isn't working properly
Steps to reproduce:
I was following this tutorial and got to the part where I have to make a chest and have it interact with the player. Instead of using an Area2D node I'm using a StaticBody2D.
So I have a chest (StaticBody2D) with a CollisionShape2D and a sprite. The chest has this script:
extends StaticBody2D

var gold = 5

func on_interact(player):
	print('interacted with chest')
	player.give_gold(gold)
	queue_free()

The player has this (partial):
func _process(delta):
	if Input.is_action_just_pressed("interact"):
		try_interact()
		try_interact()

func try_interact():
	rayCast.force_raycast_update()
	rayCast.cast_to = facingDir * interactDist
	print("try interact: " + str(rayCast.cast_to.x) + " " + str(rayCast.cast_to.y) + " " + str(interactDist))

	if rayCast.is_colliding():
		print("rayCast colliding")
		if rayCast.get_collider() is KinematicBody2D:
			rayCast.get_collider().take_damage(damage)
		elif rayCast.get_collider().has_method("on_interact"):
			rayCast.get_collider().on_interact(self)

You can see that I call try_interact two times, because the first time it just doesn't work, and the second time it does.

But if I approach the chest from the upper side, it works, and try_interact is called two times:

and I don't even think it should, because the second time the object should be destroyed already.

If I remove rayCast.force_raycast_update() it fails also at the second call:

but it will succeed at the second call if I call try_interact once:

Minimal reproduction project:
tutorial-2d-rpg.zip

Have you tried calling try_interact() in _physics_process() over _process()? Any physics interactions should be done in _physics_process() (also previously called _fixed_process()) to make those operations safe. _process() is called as fast as possible (every frame), so it's not recommended to use in a physics context.

Yes I tried too, the only difference is that rayCast.force_raycast_update() is not needed. But I still need to press the activation key 2 times from any direction that isn't the upper one (north).

Use force_raycast_update() AFTER changing cast_to.

Use force_raycast_update() AFTER changing cast_to.

Ok that worked thanks. I still think that there's a bug somewhere because it defies every logic thar RayCast2D fails for some directions and not for others. In this situation basically you're forced to do force_raycast_update and I don't think it can be considered normal.

You can enable visibility of collision shapes in Debug menu to see the raycasts. I didn't check the project, but I guess the initial position of your RayCast just accidentally aligned for colliding or it's due to some offset or something.
btw for this specific case it would be more suited directly query the physics space:
get_world_2d().direct_space_state.intersect_ray(from, to, [], 1)

RayCasts aren't really intended to be changed dynamically, especially if you want to check the collision right after change.

just accidentally aligned for colliding

I set the raycast to enabled and it is pointing down. If I disable it, it becomes gray but it's still pointing down. Since the only direction that worked was from the upper side, maybe it's not a coincidence. Anyway I don't understand much of these things and I don't feel like investigating what to me is still a very strange behaviour.

Btw, by enabling visibility of colliders, I can see what happened. The raycast was active and pointing down, when I interact the first time the facing changes, but apparently the is_colliding function ignores the change unless you force update. From the upper side, this has no effect because the raycast was already colliding.

apparently the is_colliding function ignores the change unless you force update.

The collision is updated on the next physics frame, changing the raycast doesn't do it automatically. force_raycast_update just provides an option to update the collision if you really need it.

Thanks for the help.
Eventually I moved rayCast.cast_to in the _input() function and I don't need force_raycast_update.


How to use Intern-VL 2-1B model for VQA classification task ?

I am solving a VQA task in the form of classification task. How Intern-VL 2-1B  can be used for such task. I want to it use it for a simple inference as well as for finetuning on a custom dataset

Hello, it seems that classification tasks can be constructed as multiple-choice questions and then have the model answer the options.


BPF-masq unexpectedly SNATs replies to outside

Follow up from https://github.com/cilium/cilium/pull/12482.
See https://github.com/cilium/cilium/pull/12482#discussion_r454691162.

The test which caught the bug is doing the following:

Add a route from outside to podCIDR via node.
Sends request to a podIP from outside.
A reply (SYN-ACK) gets masqueraded by BPF-masq.
The client @ outside drops the reply.

The problem is that the BPF-masq doesn't check whether a packet (podIP -> outside) is a reply, and does SNAT regardless. One possible fix is to consult CT to see whether a packet is a reply.

@brb Any idea on why this only occurs on net-next kernels?

@christarazi This is because we don't enable the BPF-masq feature on other CI builds (except for 4.19) due to the kernel version constraint.

Had another thought that fixing this by adding the CT lookup would introduce the perf penalty for each packet from a local endpoint to outside. To make the test to work with BPF-based MASQ, we could add the outside IP addr to the ip-masq-agent.

Wondering with this issue, how can nodeport work? The first node snat to node ip and the pod on the 2nd node is returning traffic to node IP. Will the return traffic get masqueraded?

Wondering with this issue, how can nodeport work? The first node snat to node ip and the pod on the 2nd node is returning traffic to node IP. Will the return traffic get masqueraded?

@liuyuan10 No, it won't be masqueraded because of https://github.com/cilium/cilium/blob/master/bpf/lib/nodeport.h#L1193 (the 1st node IP addr is going to be in the IPCache of the 2nd node)


Consider adding EvaluationMessageEventArgs : MessageEventArgs

Consider adding EvaluationMessageEventArgs : MessageEventArgs and use it instead of simple Message event args during evaluation. The evaluation Id is specified in the Context, but it is per project, and all evaluation messages are in a flat list under that project.
It would be nice to store the File that's currently being evaluation in the EvaluationMessageEventArgs, so that we can hierarchically organize the evaluation messages in a tree per file. Ideally also include the Parent file (that caused the current file to be imported), which is null for the root project file.

cc @cdmihai

This has been fixed by adding evaluation Ids.


Markdown example needs fixing

In second code block of markdown file, should be Need & symbol for session.reminders.first(3).map(&:title).

Can you also please add an example on how to add a reminder to a specific list. New to ruby here and having trouble.

@nbar1: This gem is basically unmaintained. You're on your own.

Happy to review pull requests, but as @troy said, this gem isn't really maintained. Sorry about that.

@adammck or @troy, is there an official iCloud Reminders API that is documented somewhere? How was this ruby gem created?

Not to my knowledge, no. This was originally implemented using the internal/undocumented API which the reminders web app on iCloud.com uses. It works, but it would almost certainly be better to use the EventKit framework (via ObjC or Swift), like keith/reminders-cli does.

@shurcooL I can confirm what @adammck said. There's no official API at all, let alone docs for it. Use this at your own risk and expect it to break subtly and with zero notice.

I see, that's very helpful, thank you!


[INTERNAL] Add verbose logging to component preload

Coverage increased (+0.009%) to 91.396% when pulling ac6e4fb1b91dd801672bc59c0af49f18fa6dd4ba on component-preload-logging into b92bd28bffe97aa62ed271173222db6367aee156 on master.


Note for tech/civic progress - one turn away from maximum inspiration bonus, CQUI and other mods

Besides CQUI I use also other 13 mods without altering the rules of game and I was confused because I missed note for tech/civic about one turn away from maximum inspiration bonus (for current version <IP_ADDRESS> and one before, <IP_ADDRESS>, I couldn't say if it was such behavior in versions before). All mods are up-to-date.
So I tried with only two mods at the time, CQUI and another one and I can report my conclusions:
Note for tech/civic progress IS visible when using CQUI +:

Infixo's Better Civilopedia,
Infixo's Better Climate Screen,
Infixo's Better Leader Icon,
Infixo's Better Loading Screen,
Infixo's Better Religion Window,
Infixo's Better Report Screen,
Infixo's Better World Rankings,
Infixo's Real Era Tracker,
Infixo's Real Great People,
Infixo's Real Governor Inspector,
Sukritact's Global Relations Panel.

Note for tech/civic progress IS NOT visible when using CQUI + one of those two:

Infixo's Better Tech Tree,
Sukritact's Simple UI Adjustment.

Another small thing, there is typo in note for tech/civic progress, there is unwanted space between tech/civic name and comma:

To easier find right moment when should notes appear here is game save, just end turn and notes should appear.
BASIL II 163 170 BC-Note Test.zip

The issue is caused by Better Tech Tree and I am aware of it.
Basically, BTT was designed and implemented to work with a full replacement of Tech and Civic Trees, and it was ok as long as CQUI was replacing both. But some time ago (a month or two), the CQUI started using extensions, so now BTT needs to account for that fact, It is fairly easy, I just don't have time to do it properly.
And I am aware of all of this because I did the "extension" change in CQUI myself with the goal of eventually changing BTT as well :)

If you are willing to try the quick workaround, then go to TechTree_BTT_Base.lua and CivicsTree_BTT_Base.lua in BTT and find these lines at the top:
include("TechTree");
include("CivicsTree");
Then change them to
include("TechTree_CQUI");
include("CivicsTree_CQUI");
respectively.
This will cause BTT to load a proper extension from CQUI instead of vanilla base files.

I tried with your workaround, modified TechTree_BTT_Base.lua and CivicsTree_BTT_Base.lua in BTT as you instructed:

... and I have to report that it didn't solved this problem, game with CQUI + Better Tech Tree still doesn't show note about tech/civic progress.

Correct, with newer version of BTT (v.3.2) is issue with CQUI and BTT (one turn away note) solved.


chore(deps): upgrade configuration

Upgrades project dependencies. See details in workflow run.

Automatically created by projen via the "upgrade-configuration-k8s-31-main" workflow

⚪ Backport skipped
The pull request was not backported as there were no branches to backport to. If this is a mistake, please apply the desired version labels or run the backport tool manually.
Manual backport
To create the backport manually run:
backport --pr 4680

Questions ?
Please refer to the Backport tool documentation


SAK-29120 Cannot enter numbers using the keypad

Tested on http://sakai-trunk.atica.um.es by Rosa María Silveira Puertas

LGTM.


Removing category schema

Also had to update some tests.

Coverage remained the same at 91.748% when pulling 558a1ebbb32f2c13405806ad9ca4fe491587f23f on category-schema into 25fb30bb0a1f5e81560e0da11b3745497143e3ef on master.


NSException *	"Could not load NIB in bundle: 'NSBundle  (loaded)' with name 'LaunchScreen'"

Please provide all the information requested. Issues that do not follow this format are likely to stall.
Description
My app is building from running react-native android just fine, however iOS is building, but crashing on the launchscreen with the following error
Exception	NSException *	"Could not load NIB in bundle: 'NSBundle <path to app> (loaded)' with name 'LaunchScreen"
I just upgraded from 0.62.2 to 0.63.4, using the upgrade helper tool, since the automatic tool didn't work.
React Native version:
System:
OS: macOS 11.1
CPU: (16) x64 Intel(R) Core(TM) i9-9880H CPU @ 2.30GHz
Memory: 132.11 MB / 16.00 GB
Shell: 3.0.0 - /usr/local/bin/fish
Binaries:
Node: 14.15.1 - ~/.nvm/versions/node/v14.15.1/bin/node
Yarn: 1.12.3 - /usr/local/bin/yarn
npm: 6.14.8 - ~/.nvm/versions/node/v14.15.1/bin/npm
Watchman: 4.9.0 - /usr/local/bin/watchman
Managers:
CocoaPods: 1.10.1 - /usr/local/bin/pod
SDKs:
iOS SDK:
Platforms: iOS 14.3, DriverKit 20.2, macOS 11.1, tvOS 14.3, watchOS 7.2
Android SDK:
API Levels: 23, 25, 26, 27, 28, 29
Build Tools: 26.0.3, 28.0.3, 29.0.2
System Images: android-23 | Google APIs Intel x86 Atom_64, android-24 | Google Play Intel x86 Atom, android-26 | Google APIs Intel x86 Atom_64, android-28 | Google APIs Intel x86 Atom, android-28 | Google Play Intel x86 Atom
Android NDK: Not Found
IDEs:
Android Studio: 3.2 AI-181.55<IP_ADDRESS>56338
Xcode: 12.3/12C33 - /usr/bin/xcodebuild
Languages:
Java: 1.8.0_191 - /usr/bin/javac
Python: 2.7.16 - /usr/bin/python
npmPackages:
@react-native-community/cli: Not Found
react: 16.13.1 => 16.13.1
react-native: 0.63.4 => 0.63.4
react-native-macos: Not Found
npmGlobalPackages:
react-native: Not Found
Steps To Reproduce
Provide a detailed list of steps that reproduce the issue.

upgrade from 0.62.2 to 0.62.4 (must not automatically upgrade using npx react-native upgrade)
use react native upgrade tool helper to manually copy merge code.

Expected Results
The app should start up, as it works fine on android.
Snack, code example, screenshot, or link to a repository:

Hi @ThinkSalat thanks for filing the issue. For upgrade related issues head over to https://github.com/react-native-community/upgrade-support!
A quick check there seems to be a solution there as well: https://github.com/react-native-community/upgrade-support/issues/115

Hi @ThinkSalat thanks for filing the issue. For upgrade related issues head over to https://github.com/react-native-community/upgrade-support!
A quick check there seems to be a solution there as well: https://github.com/react-native-community/upgrade-support/issues/115


p2p: fix ResourceManager configuration

Motivation
go-libp2p ResourceManager was being configured only when metrics were enabled in the config, causing unwanted limits on connections / streams and warnings like this:
WARN    p2p-config      config/config.go:304    rcmgr limit conflicts with connmgr limit: conn manager high watermark limit: 20, exceeds the system connection limit of: 1      {"node_id": "...", "module": "p2p"}

Changes
Always configure ResourceManager. Set the limits to infinte when "disable-resource-manager": true is used.
Test Plan
Need to check how well p2p connectivity works with this change, with true and false values for disable-resource-manager
TODO

[ ] Verify the impact on the p2p connectivity
[ ] Update changelog as needed

bors merge

bors merge


[KD-Tree kNN] homogen table usage improvement

Description
Perf degradations comparing to DAAL interfaces have been fixed.
Row-major table:

Column-major table:

Changes proposed in this pull request:

/intelci: run

/intelci: run