Custom certs not found

I'm trying to add my certificates to a new installation. My entry in .env is:
TLS=/home/ubuntu/certs/fullchain.pem /home/ubuntu/certs/privkey.pem
and I added the two following lines to the default volumes in docker-compose.yml:
  - /home/ubuntu/certs/fullchain.pem:/home/ubuntu/certs/fullchain.pem
  - /home/ubuntu/certs/privkey.pem:/home/ubuntu/certs/privkey.pem

When I bring everything up the caddy container keeps restarting with the following message in the logs:
Error: loading initial config: loading new config: loading http app module: provision http: getting tls app: loading tls app module: provision tls: loading certificates: open /home/ubuntu/certs/fullchain.pem: no such file or directory

What am I missing? Cheers, Dave
I'm also trying to add a Keycloak user but:
/opt/jboss/keycloak/bin/add-user-keycloak.sh

is not found and there's no jboss directory in the container.

Hi,
These volumes need to be added to the Caddy container:
  # HTTP Router
  caddy-router:
    container_name: caddy
    image: '${DOCKER_REGISTRY_PREFIX}library/caddy:2'
    ports:
      - '${WALDUR_HTTP_PORT:-80}:80'
      - '${WALDUR_HTTPS_PORT:-443}:443'
    environment:
      - VIRTUAL_HOST=${WALDUR_DOMAIN:-localhost}
      -<EMAIL_ADDRESS>    volumes:
      - ./Caddyfile:/etc/caddy/Caddyfile
      - ./config/caddy-includes/:/etc/caddy-includes
      - caddy_data:/data
      - caddy_config:/config
      - /home/ubuntu/certs/fullchain.pem:/home/ubuntu/certs/fullchain.pem
      - /home/ubuntu/certs/privkey.pem:/home/ubuntu/certs/privkey.pem
    depends_on:
      waldur-homeport:
        condition: service_healthy
    restart: always

About adding the keycloak user - you don't need that command any more. It was valid for Keycloak 15, but we now migrated to Keycloak 19 and it should be provisioned automatically with admin password taken from KEYCLOAK_ADMIN_PASSWORD environment variable.

Ah cool, thanks for the info. Everything works now. Great app btw.

Update: I was able to login to Keycloak Master realm with https:///auth/ and I noticed there's no user admin in the waldur realm.

How do I add my letsencrypt certs to waldur docker compose? I have a domain and I'd like to go to: https://mydomain.com from outside. I ran Waldur docker compose on a Hetzner vps.


Bundle products are imported without variant options, and with wrong price

Problem:
Bundle product pricing and variants inconsistent between Shopify and Magento.
Steps to Reproduce:

Create a bundle product in Magento, with complex variant options (see screenshot)
Import said product using the extract + convert + import process
Observe the newly created product has no variants, and has the price of one random child product

Side note: I understand that Shopify doesn't natively support complex bundling like Magento does, so I know this isn't an easy problem to solve, and might be outside the scope of what this tool is designed to do.

@willcodeforfood thank you for reporting this!
You're correct - the extraction script in their current state don't support bundled products right now.
The code that extracts and maps simple and configurable products is here: https://github.com/Shopify/shopify_transporter/blob/master/lib/shopify_transporter/exporters/magento/product_exporter.rb#L85 - it might be a straightforward change to support bundled products.

Closing this issue.  Please create a PR to add support for bundled products and we'd be happy to take a look.


Add decimal

Hi Mikhail,
and thank for sharing your code.
do you thing it's possible to add decimal at the end ? for example :
5 000 000,45
i made this custom delimiterRegExp : "/[\s]/g"
but it's not displaying very well :
54 546 546 546 .44
and i want this display
54 546 546 546,44 with only 2 decimals at the end.
thanks you ! :+1:

Hi, i made this plugin long time ago and now i have no idea how it can be improved, sorry :)

Hello, ok not problem :) i found another solution :)


Project done/dead?

Is this project dead? The website is gone and this repository hasn't seen any activity in over two years ☹

The website isn't active right now and there's nothing that's really needed changing. You can host the website very easily with the instructions in build.md.

The website isn't active right now and there's nothing that's really needed changing. You can host the website very easily with the instructions in build.md.

I apologize for if this a dumb question to ask, and I know there hasn't been much going on recently with this repo (because no further work is really needed).
But I was wondering if you might be able to provide me with some further guidance, in regards on how to host this on my end?
I have a Domain, Web Hosting, Etc... and I'd like to host a version of this on my end.   I'm just not necessarily all that wise n knowledgeable I'm regards to how to go about this.
I looked at the build.md file, but again, I'm just not too sure about what steps Id need to take, if I wanted to host this on my site.
Thank You very much, if you do get around to this.


Moving stokes spectralcube to be compatible with astropy stokes WCS.

The goal here is move the special types and checks we have in place and instead use the astropy based stokes values. The will work for the polarization cases that are defined in astropy stokes WCS. The remaining cases we can define using the custom declaration for stokes that is built into astropy.
I am working on this and want to have it ready so we can code review in person @keflavich

That is the plan. Else before we cross paths in CV
Get Outlook for Androidhttps://aka.ms/AAb9ysg

From: Adam Ginsburg @.>
Sent: Tuesday, April 23, 2024 6:01:23 AM
To: radio-astro-tools/spectral-cube @.>
Cc: Preshanth Jagannathan @.>; Author @.>
Subject: Re: [radio-astro-tools/spectral-cube] Moving stokes spectralcube to be compatible with astropy stokes WCS. (Issue #905) {External}
could you get the PR submitted before I'm out there?
—
Reply to this email directly, view it on GitHubhttps://github.com/radio-astro-tools/spectral-cube/issues/905#issuecomment-2072120662, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AARIMUMEXLGNCJ5KOEMXLS3Y6ZERHAVCNFSM6AAAAABGT56O36VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANZSGEZDANRWGI.
You are receiving this because you authored the thread.Message ID: @.***>
[ { @.": "http://schema.org", @.": "EmailMessage", "potentialAction": { @.": "ViewAction", "target": "https://github.com/radio-astro-tools/spectral-cube/issues/905#issuecomment-2072120662", "url": "https://github.com/radio-astro-tools/spectral-cube/issues/905#issuecomment-2072120662", "name": "View Issue" }, "description": "View this Issue on GitHub", "publisher": { @.": "Organization", "name": "GitHub", "url": "https://github.com" } } ]


RFC2136 provider sending wrong domain to DNS server

Describe the bug:
I have struck what I believe is the exact same issue as previously reported in #5650.
In my case details are as follows:
cert-manager was attempting to renew a certificate for example.com.au and www.example.com.au.
It had stalled for a couple of days due to bug #5917 so I restarted the cert-manager Pod as this sometimes fixes that problem.
However this time cert-manager started logging the following errors (repeated many times):
{"ts":1715752316870.572,"caller":"dns/dns.go:88","msg":"cert-manager/challenges/Present: presenting DNS01 challenge for domain","v":2,"resource_name":"example-com-au-1-2457021599-1243604751","resource_namespace":"example-namespace","resource_kind":"Challenge","resource_version":"v1","dnsName":"www.example.com.au","type":"DNS-01","resource_name":"example-com-au-1-2457021599-1243604751","resource_namespace":"example-namespace","resource_kind":"Challenge","resource_version":"v1","domain":"www.example.com.au"}
{"ts":1715752316878.8406,"caller":"controller/controller.go:167","msg":"cert-manager/challenges: re-queuing item due to error processing","key":"example-namespace/example-com-au-1-2457021599-1243604751","err":"DNS update failed: dns: bad authentication"}
{"ts":1715752336737.8887,"caller":"dns/dns.go:88","msg":"cert-manager/challenges/Present: presenting DNS01 challenge for domain","v":2,"resource_name":"example-com-au-1-2457021599-875669868","resource_namespace":"example-namespace","resource_kind":"Challenge","resource_version":"v1","dnsName":"example.com.au","type":"DNS-01","resource_name":"example-com-au-1-2457021599-875669868","resource_namespace":"example-namespace","resource_kind":"Challenge","resource_version":"v1","domain":"example.com.au"}
{"ts":1715752336742.7222,"caller":"controller/controller.go:167","msg":"cert-manager/challenges: re-queuing item due to error processing","key":"example-namespace/example-com-au-1-2457021599-875669868","err":"DNS update failed: dns: bad authentication"}

And on my DNS server running PowerDNS I see the following log entries (repeated many times):
May 15 16:02:16 pdns-hostname pdns_server[2813604]: UPDATE (51511) from <IP_ADDRESS> for com.au: TSIG is provided, but domain is not secured with TSIG. Processing continues
May 15 16:02:16 pdns-hostname pdns_server[2813604]: UPDATE (51511) from <IP_ADDRESS> for com.au: Can't determine backend for domain 'com.au' (or backend does not support DNS update operation)

Sure enough if I create a domain in the server called com.au then cert-manager promptly sets the ACME Challenge TXT record there rather than under the expected domain example.com.au.
I've tried deleting the Challenges, Order, Certificate Request, Certificate, all individually and at the same time, but the issue comes back again.
I've tried deleting those objects and restarting cert-manager whilst they are deleted, still the same problem.
I've verified the CSR in the Certificate Request and Order objects has the correct domain names, and that the spec.dnsName property in the Challenges are also correct.
Expected behaviour:
The DNS record is created in the correct DNS zone!
Steps to reproduce the bug:
Sorry I have no idea how to duplicate this at this time.
What is really confusing is that even after deleting the Certificate and restarting cert-manager this comes back.
Is there some data stored/cached somewhere else?
Anything else we need to know?:
Environment details::

Kubernetes version: v1.23.7
Cloud-provider/provisioner: Bare metal
cert-manager version: v1.13.0
Install method: helm

/kind bug

Not a bug!
Turns out the domain registration had not been renewed (and obviously this had not been communicated to everyone who should know this) and somehow this has resulted in cert-manager thinking the domain it needed to update the DNS challenge records in was com.au and not example.com.au.
That might be considered a separate bug in of itself, or at least something that should log a more meaningful error, but given this is a client side configuration issue I'm going to close this and update my clients domain decommissioning procedure!


Update Windows Getting Started Guide

The Windows Getting Started Guide can be updated. It currently states Windows support is limited.

[ ] Using a windows machine setup and test the Windows nightly
[ ] Test out examples
[ ] Update the Getting Started Guide to reflect current state

Windows builds are tested in CI so programs should compile and run. There are likely issues with tooling like using expect and dbg.

This is blocked on PR #5072.
I had one more segfaulting cli test that I wanted to look at.


restrict only third party auth for access

restrict only third party auth for access
Add ENABLE_REQUIRE_THIRD_PARTY_AUTH: true
https://github.com/mitodl/mitxonline-theme/issues/26

:+1:

It looks like this is blocking account creation from the mitxonline app. Here is the relevant code:
https://github.com/edx/edx-platform/blob/fa7ef8661b34b361e4ea6f34f8119b3e90d456a4/openedx/core/djangoapps/user_authn/views/login.py#L533-L536

(corrected URL in last comment: https://github.com/edx/edx-platform/blob/fa7ef8661b34b361e4ea6f34f8119b3e90d456a4/openedx/core/djangoapps/user_authn/views/register.py#L563-L567 )


⚠ Bofrost.de has degraded performance

In 7a80ea6, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 1179 ms

Resolved: Bofrost.de performance has improved in 19dd6c4.


Indy: Ansible role to get EIP metadata from AWS

Prepare an Ansible role which retrieves the EIP allocation IDs for all steward public IPs found in the network.yaml and stores them in an Ansible fact / variable to be used later. The role should also check that the same public IP is specified for all stewards within one organization.

Closed by #143


fix logo on map display page

@studenton -- i just there are still some pages where we see the old logo. could you pls take it out when you get a chance? http://www.nepalmap.org/data/map/?table=HOMEOWNERSHIP&geo_ids=country-NP,district|country-NP&primary_geo_id=country-NP#column|OWNED%2Csumlev|district

Fixed @ravinepal

Thanks, @studenton!


GEOMESA-1332 Update TubeSelectProcess to retrieve indexed data correc…

…tly.

Added otherwise failing unit test.
Removed TubeBuilder's extractDtgField function.

Signed-off-by: Jim Hughes<EMAIL_ADDRESS>

looks good to me

wow someone looked at this? looks good.mergin.


Default http.server configuration prevents Docker deployment

Hi,
first of all I would like to say that I really like working with Fuego. It is a nice experience so far.
However, I recently wanted to deploy my Fuego application to the Cloud (Google Cloud Run) and there are some problems with the default behavior imho.
The fuego.NewServer() function automatically calls the withPort() function, which itself sets the Addr field of the underlying http/server to localhost:port. Unfortunately, this has a side effect. When running the application inside a Docker container, you have to add the --net=host argument to make it accessible from the outside. This is different from the default bahavior of the http/server  where the Addr field is just set to :port.
I would have expected that withPort only sets the port and not the host. In the end the only solution for Cloud Run was to use withAddr(":"+port). Then it can be accessed via the browser on localhost:8080, however the log says Server running ✅ on http://:8080, which is a bit confusing.
Therefore, I would suggest to make the behavior equal to the one in the standard library to avoid confusion when making a deployment.
That being said, I am still new to Go, so maybe there is a deeper reason I don´t know yet :smile:)
To Reproduce
Steps to reproduce the behavior:

Create a new fuego server
fuego.NewServer()
Dockerize the application (example Dockerfile: https://github.com/GoogleCloudPlatform/cloud-run-hello/blob/master/Dockerfile)
Run the Docker container with the default bridge network
(optional) Run the Docker container in the cloud (e.g. on Google Cloud Run)
Try to access the application.

Expected behavior
Application is accessible without further configuration like when using the standard library http/server.
Framework version (please check if it happens with the last Fuego version before posting):
0.13
Go version (please check if it happens with the last Go version before posting):
1.22

I think using fuego.WithAddr("<IP_ADDRESS>:8080") when creating a new server should work.
https://go-fuego.github.io/fuego/docs/guides/options#address
Could you give it a try?

I will fix the behaviour of WithAddr in next version.
Don't forget that in the meantime you can always access server.Addr as it is a public field and not used before server.Run()

@EwenQuim not sure I understand? What seems to be the problem with WithAddr?

@oerni74 was you issue resolved? If so please close.


fix Match foreign branch shallow clone issue

Checklist

[x] I've run bundle exec rspec from the root directory to see all new and existing tests pass
[x] I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
[x] I've read the Contribution Guidelines
[x] I've updated the documentation if necessary.

Description
Fixes issues when try to use Match to shallow clone not default branch (when work with different teams).
More here #6806

Fine for me!
To confirm, @xNekOIx you ran that code in production? :)

@lacostej yeap. checked. worked for my project.

Could you provide a little more context on what the --no-single-branch flag does and why this should be part of match?

@KrauseFx when you do a shallow clone with git clone --depth 1 git truncates history only to the current branch default branch (master). Therefore when you do git branch --list origin/#{branch.shellescape} --no-color -r for your other team branch it returns nothing and you got the error described in the initial issue.
There is an option --no-single-branch which can only be used with --depth which solves this issue.
from the git docs:
--depth
Create a shallow clone with a history truncated to the specified number of commits. Implies --single-branch unless --no-single-branch is given to fetch the histories near the tips of all branches.
This way we will still do a shallow clone and will have an information about remote branches.

Thanks for the contribution 🚀


dreamhost.com not vulnerable

So it saves someone else some $$, I signed up to Dreamhost today to attempt a domain takeover (target had: "site not found dreamhost") and received the following:
You can't add that domain: parent domain xxxxx.com is already in our system

Sounds like something similar to Fastly, where takeover is only possible when the FQDN is not registered and some subdomain is pointing to one of their services. I would not label this 'Not vulnerable' immediately.
Perhaps it's an idea to point your subdomain to subdomain.dreamhost.com  without registering the FQDN. I'm assuming then it will be possible.

Hi,
I confirmed this behavior as well. If the FQDN is already registered under another account, you'll receive the same error: You can't add that domain: parent domain xxxxx.com is already in our system.


issue with float type

using basic float type is causing undefined behavior.
int i = 2;
float f 3.3;

//causing UB
f += i;

no longer an issue with new cxvm


Experimental Python analyzers incorrectly identify vulnerabilities for a package (python-gitlab)

Describe the bug
When using the Python experimental analyzers, the python package python-gitlab is incorrectly identified as the Gitlab platform.
From the report

Dependency
Vulnerability IDs
Package
Highest Severity
CVE Count
Confidence
Evidence Count

gitlab:5.0.0
cpe:2.3:a:gitlab:gitlab:5.0.0:*:*:*:*:*:*:*
pkg:pypi/gitlab<EMAIL_ADDRESS>CRITICAL
209
Medium
4

pip:24.2

<EMAIL_ADDRESS>HIGH
1

3

pip:24.2

<EMAIL_ADDRESS>HIGH
1

2

python-gitlab:5.0.0
cpe:2.3:a:gitlab:gitlab:5.0.0:*:*:*:*:*:*:*
<EMAIL_ADDRESS>CRITICAL
209
Highest
3

python-gitlab:5.0.0
cpe:2.3:a:gitlab:gitlab:5.0.0:*:*:*:*:*:*:*
<EMAIL_ADDRESS>CRITICAL
209
Highest
3

urllib3:1.26.18

pkg:pypi/urllib3<EMAIL_ADDRESS>MEDIUM
1

3

Version of dependency-check used
The problem occurs using version 11.1.0 of the cli
Log file
If required, I can upload this from a different machine because the log from my work machine has sensitive information.
To Reproduce
Steps to reproduce the behavior:

Create requirements.txt with content python-gitlab==5.0.0
python -m venv env && source /env/bin/activate
pip install -r requirements.txt
dependency-check --scan . --enableExperimental

Expected behavior
python-gitlab should not display vulnerabilities for the Gitlab platform.
Additional context
I'm not sure if this would be more appropriate as a False Positive report, however I think this is more of an issue with how the analyzers identify the vulnerability IDS

Your finding is simply a false positive (in short the application logic is: find traces of information (evidences) on the dependencies and then do a best-match correlation to the CPEs).
The CPE (Common Platform Enumeration) is the unique key for an application that is used in the NVD database to link known CVEs  to the software products that are affected by the vulnerability.

Thank you for the explanation
In the False Positive report template, it specifies only adding a single CVE. I'm happy to re-open this issue as a false positive report, but I'm hesitant to open ~200 issues for each entry. Is there a preferable way for me to raise these?

Quoting fromthat template:

If filing a CPE report you do not need to add the CVEs. Note that most reports should be for incorrectly matched CPEs.

Your report would be a CPE report as the python-gitlab package is the the gitlab software, so the false positive is about an incorrectly linked CPE.

Perfect, thank you for your time
I'll close this issue and open the correct type


🌱 Configurable wait time on VirtualCluster Controller for control plane bring up

What this PR does / why we need it:
Today the manager will timeout after 180seconds and stop trying to deploy the control plane. This causes problems if someone is trying to create a cluster when there is super cluster issues happening.
The  PR allows to configure timeout with --provisioner-timeout flag for manager.

/lgtm


Refactor of metadata operations.

Adds typing for metadataOperation and a enumeration of metadataAction. No functionality changes as a result of this, but the code is easier to read and support.

ping @dcantah @anmaxvl


⚠ Processors has degraded performance

In cee4465, Processors ($STATUS_URL) experienced degraded performance:

HTTP code: 200
Response time: 45 ms

Resolved: Processors performance has improved in 3a62bab.


Situations permanently denying superficial losses (registered accounts) or transferring the loss (spouses, etc.) are not handled

This is going to be coupled with issue #7
Right now, if someone has had registered account transactions, any superficial loss will not be properly accounted for.
This is also noted in https://github.com/tsiemens/acb/wiki/Superficial-Losses

Fixed in 37f2a9910a64e2e2745ca8e5044faa6514e9605d


Adding PHIVE to the PHP image

This PR adds the PHIVE binary to the PHP image used by ddev
Fixes #2990

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

I think given this is getting installed, it should then be used for the various phar installs that get done in the container build?

You mean that installing the tools for the images should also take place using Phive? That sounds plausible, but I'd have to check how to do that...

For testing, this will require an update of pkg/version/version.go and a push of the requisite version.

Yeah, I'm already reading the tutorial about how to test this using Gitpod - that's pretty slow, so I might check this on my own machine

Yes, I just mean that the phive could go in first, then the parts of the build that download phars could use it.
Building and testing is fine on your own machine, but gitpod is usually lots faster.
Thanks!
But then you deleted it!

Shucks, branch naming is not that important.


yandex yaotp request

Could you add the Yandex authentication method "yaotp"?

I actually don't know what it is. Does it conform RFC 6238 TOTP or RFC 4226 HOTP?

neither totp, nor hotp. this is a Yandex thing. But there is probably a plugin for keepass. https://github.com/norblik/KeeYaOtp

Unfortunately I don't think I am able to support an specific authentication method that requires significant amount of work. I will only evaluate if it is a variant of TOTP or HOTP.


Add validation rules which aggregates a keyed collection of validators

This ticket is to create a new property valuation rule which would be used upon enumerable collections of objects.
This validation rule would iterate through that collection and validate each item in the collection, one by one. It would then aggregate those results and return them as a single validation result.
This rule will fail if any item in the collection fails validation (thus, to pass, all must be valid). This means it should be given a name such as ValidateAllRule.

Blocked by #35 and provides


Dashboard active view toggle button

The relevant button wasnt active when the view type changed in containers dashboard
Before:

After:

@epwinchell @martinpovolny Please review
cc @simon3z

@miq-bot add_label bug, ui, providers/containers

LGTM :+1: (but I believe the code of the relevant method should be refactored).
cc @dclarizio @h-kataria can you review/merge? Thanks.

Looks good

Appears on darga
@miq-bot add_label darga/yes

@miq-bot assign chessbyte
Ready for merge.


fix double space

🙈

Thanks for the contribution, I am assigning this PR to the next milestone 0.19.0


Cypress external HTML report generation

Generate external HTML reports with screenshots in Cypress.
Trying to use Mochawesome Reporter for reporting purpose in Cypress so that we can share the test results in a convenient and understandable way.

@mengweieric @anirudha

Since we have not received any input on the issue, closing it for now and will pick it again whenever required.


[master]Fix NIC not coupled issue when default_nic_dev contains a lower-case …

…letter
When default_nic_dev is set to a nic device number that contains a lower-case letter, such as 1e00, the NIC in guest is not coupled correctly, due to the code has bug in handling lower-case letter.
This commit fix the bug.
Signed-off-by: Shu Juan Zhang<EMAIL_ADDRESS>

@jichenjc @SeanHQF @bjhuangr Can you help review? Thank you.


Implement a Profile set

Impl a ProfileSet that allows fetching program samples of different types in continuous way.
Fixes #268

To avoid conflicts on https://github.com/dusk-network/dusk-blockchain/pull/286 merging, this PR should be considered ready for merge only after https://github.com/dusk-network/dusk-blockchain/pull/286 is merged to master.

Codecov Report

Merging #273 into master will not change coverage by %.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #273   +/-   ##
=======================================
  Coverage   53.16%   53.16%
=======================================
  Files         122      122
  Lines        6939     6939
=======================================
  Hits         3689     3689
  Misses       2756     2756
  Partials      494      494

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a664fe2...f89bef0. Read the comment docs.

Codecov Report

Merging #273 into master will decrease coverage by 0.01%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master     #273      +/-   ##
==========================================
- Coverage   53.17%   53.16%   -0.02%
==========================================
  Files         122      122
  Lines        6937     6939       +2
==========================================
  Hits         3689     3689
- Misses       2755     2756       +1
- Partials      493      494       +1

Impacted Files
Coverage Δ

pkg/config/loader.go
61.03% <ø> (ø)
:arrow_up:

pkg/p2p/peer/processing/chainsync/sync.go
76.31% <0%> (-2.07%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dccd03e...f89bef0. Read the comment docs.

@ggoranov After pulling the branch and fixing the conflicts with master, I see mempool_test.TestRemoveAccepted failing due to a wrong typecasting to bytes.Buffer. Once fixed that, it is good for merging IMO

turns out that the failing test was due to errors in merging. I will merge this with master and open a new pull request to actually implement monitoring through grpc


i am unable to find downloaded videos.

Hi, the app you listed in github for downloading youtube music audio is not working.  i am unable to find downloaded files. Please respond as soon as possible.

Please try to describe the problem you're having better. What does "not working" mean? is it just one video or all of them? did you try running as administrator? what settings are you using?

I have the same issue. So I pasted the link and it told me it has downloaded all the files, however I don't know where the files are saved.

I have the same issue. So I pasted the link and it told me it has downloaded all the files, however I don't know where the files are saved.

Did you try running as administrator?

i have the same issue . the videos are not showing in the folder where i download them

How come all of you are reading the title of the issue but not the big, bold text on the front page of the repository, and also in a comment here?
Run as administrator


no ActiveModel::Dirty support?

Is there a good strategy for getting ActiveModel::Dirty support like checking if the attr has changed?
I was looking through the code just to check if there were any monkey patches I could throw in, but with the attribute method being completely replaced, it looks like it's sort of impossible.

lol, ignore all of this, I was trying the completely wrong thing.


Numeric overflow when handling large TIMESTAMP WITH TIME ZONE values

presto> SELECT TIMESTAMP '123001-01-01 01:59:59.999 UTC';
             _col0
-------------------------------
 -19713-08-11 09:30:29.503 UTC

The problem is not limited to literals only.


[FEATURE] Detection creation button on attributes page so don't need to switch back

Could use a detection/track creation on the attributes panel so you don't need to switch back to the track list panel when making full frame labels with attributes

Also ability to switch the main "type" of the track to avoid switching, similarly

I just realized that this issue is going to be nullified if we move the attributes page into its own panel like the threshold sliders.
Can we de-prioritize this issue and kick it to the next sprint for discussion?

@subdavis can you give an update on this? Otherwise we can definitely discuss at our next planning meeting.

I don't know if this should still be an issue.  This seems like it might be bad UX.
New detection button will change the selection context.  The attributes panel depends on the selection context.   There are just a lot of UX issues with the viewer, and this feels like a hack that might make things more confusing rather than a solution.

I'll leave the issue open so we can discuss what the right UX for this is, but it seems reasonable to look for ways to accelerate an oft-used workflow.


Support LUT1 and LUT2

This PR adds support for LUT1 and LUT2 in Cava which take higher order arguments to define their behaviour e.g.
  lut2 (andb) i0i1 (* An AND gate *)
  lut1 (negb) x (* An invertor *)

The generated SystemVerilog can't be simulated by Verilator so I've added a tcl simulation script to drive the Vivado tools:
set outputDir ./vivado_genfiles/output
create_project -force lutNAND lutNAND -part xc7A200tsbg484-1
add_files -fileset sim_1 -norecurse lutNAND_tb.sv lutNAND.sv
set_property top lutNAND_tb  [get_filesets sim_1]
import_files -force -norecurse
launch_simulation
add_force {/lutNAND_tb/clk} {0 0ns} {1 50ns} -repeat_every 100ns
run 400ns
exit

Which does a batch-mode simulation and test:
INFO: [USF-XSim-96] XSim completed. Design snapshot 'lutNAND_tb_behav' loaded.
INFO: [USF-XSim-97] XSim simulation ran for 1000ns
launch_simulation: Time (s): cpu = 00:00:04 ; elapsed = 00:00:17 . Memory (MB): peak = 1414.375 ; gain = 62.555 ; free physical = 5068 ; free virtual = 114101
# add_force {/lutNAND_tb/clk} {0 0ns} {1 50ns} -repeat_every 100ns
# run 400ns
             1050000: tick = 0, a = 0, b = 0, c = 1
             1150000: tick = 1, a = 0, b = 1, c = 1
             1250000: tick = 2, a = 1, b = 0, c = 1
             1350000: tick = 3, a = 1, b = 1, c = 0
PASSED
# exit
INFO: [Common 17-206] Exiting Vivado at Wed May  6 16:34:23 2020...

The script also generates a VCD waveform file.

Sadly this can't work with Verilator: it does not support primitives in the way we need to use them. We could reconsider reverting to iverilog for these cases or just stick with xsim.


Password in File Browser

Please verify that you have read and understood the guidelines.
yes
A clear and concise description of the issue.
Hello. When installing File Browser I noticed that there is an error on the page regarding the first password after installing the application. On the page it says "changeme" and in the script itself "helper-scripts.com"
What settings are you currently utilizing?
Default Settings
Which Linux distribution are you employing?
Debian 12
If relevant, including screenshots or a code block can be helpful in clarifying the issue.

Please provide detailed steps to reproduce the issue.
study the script.

Thank you, this has been fixed.


[Feature] Is There anyway to add subscript,superscript and line height features to quill?

My issue is about [Text Editing Features] like [Subscript] ,[Script] and [Line Height].
I have tried adding custom rules but didn't succeeed.
Please let me know if any one tried it already.
Thanks.

My issue is about [Text Editing Features] like [Subscript] ,[Script] and [Line Height].
I have tried adding custom rules but didn't succeeed. Please let me know if any one tried it already.
Thanks.

Hi, can you explain what you mean by line-height features?

My issue is about [Text Editing Features] like [Subscript] ,[Script] and [Line Height].
I have tried adding custom rules but didn't succeeed. Please let me know if any one tried it already.
Thanks.

It's already there in the latest versions, if you have any questions feel free to ask us at any time.


ant: modernize, make apacheAnt an alias

These are small things that I encountered while doing other work, like #357162, #359451, and #359137. I'm submitting this as a separate PR so that this can make its way into all branches independently; I have PRs that target both staging and master. The nonstandard formatting was bothering me, for example.
If this PR causes any rebuilds, I have done something horribly wrong. This PR will cause conflicts with my other Ant PRs; merge conflicts with my PRs are okay and intended.
This is easiest to review commit by commit.

Things done

Built on platform(s)

[ ] x86_64-linux
[x] aarch64-linux (no rebuilds)
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 360019 run on aarch64-linux 1
empty


vsphere support

Fixes #277
vSphere support

My local vars was:
cluster_name = "artiom42"
datastore_name = "exsi-nas"
network_name = "VM Network"
template_name = "machine-controller-e2e-ubuntu"

You cannot really do OS customization through vsphere API for the templates we use. We don't even do that in machine-controller, we use metadata or an ISO depending on the OS.
After removing the customize { ... } section it is working fine for me. @kron4eg
See also:

https://github.com/terraform-providers/terraform-provider-vsphere/issues/388#issuecomment-427357809
https://github.com/vmware/open-vm-tools/issues/299

OH... That'd explain it. I'll try another time, thanks!

/retest

/lgtm
/approve
:tada: :100:

Woohooo great job guys! @thetechnick is now ready for your setup 🥰


Provide report of pieces (records) added to the database for use by Chris Mahoney in reporting progress to volunteers

Chris Mahoney wrote:
I have not received notification from anyone about any uploads that have taken place to FreeCEN2.  A reminder that it is up to you co-ordinators to let me know when a piece has been uploaded as I do not have any other way of knowing what has happened at this time
Solution
A FC2 report is needed for management and reporting purposes of all pieces Incorporated into FC2 in say the last 2 months. This should not be filtered by County. It may well be able to be generated from the current FreeCEN report with a date filter. It should include all pieces incorporated by everyone.
It can be quite simple - Chapman Code, Year, Piece number, date incorporated, number of entries as a starting point.
As well as being useful for the newsletter it would be useful for Pat, the Executive etc to monitor progress.
Geoff
Maybe to go in "Site statistics" button?
E4 U6 S8 C5 (may need to revise once begun)

@Captainkirkdawson and @AnneV-Learn to discuss before proceeding.

Likely should include both incorporated and vld loaded files with ability to display either or both

Best solution is likely a csv download report

@geoffj-FUG
Just getting to look at this now and I need some clarification on the requirements please.
The number of VLD and CSV files recently incorporated (ie previous 30 days) are reported for the whole database  on the Site Statistics page  and for each County on the County Statistics page (both accessed via Your Actions). Also the newly deployed Records pages report on new pieces (ie incorporated in the previous 30 days) and you can drill down through county and place to see the status of pieces. and both have Recent Additions buttons.
Is this an additional requirement for a csv file download perhaps that lists Pieces incorporated across the whole database in the previous xx days (xx range from 0 - 99) or between a date range or something else?

Chris
You compile the newsletter and statistics.
What are your specific requirements, please?
Geoff
From: Anne Vandervord @.>
Sent: Tuesday, 18 January 2022 8:45 AM
To: FreeUKGen/FreeCENMigration @.>
Cc: geoffj-FUG @.>; Mention @.>
Subject: Re: [FreeUKGen/FreeCENMigration] Report of pieces added in past month (#1211)
@geoffj-FUG https://github.com/geoffj-FUG
Just getting to look at this now and I need some clarification on the requirements please.
The number of VLD and CSV files recently incorporated (ie previous 30 days) are reported for the whole database on the Site Statistics page  https://camo.githubusercontent.com/f0fd7cf65f1a58c5ae3dffed8f5ab170b60ef0a6f63551a55b5d39a4d3f4aa6a/68747470733a2f2f696d616765732e7a656e68756275736572636f6e74656e742e636f6d2f3630303961656363643630343239636237303038653564332f39396263303933372d653935362d343165392d393732322d336239353537346536613661 and for each County on the County Statistics page  https://camo.githubusercontent.com/53cb20c6ac169478a77d34d7c9f312bca5695a45a48cb85d747e94d45c111561/68747470733a2f2f696d616765732e7a656e68756275736572636f6e74656e742e636f6d2f3630303961656363643630343239636237303038653564332f38633165623866342d613238312d346366312d386631392d306437383263643765613731 (both accessed via Your Actions). Also the newly deployed Records pages report on new pieces (ie incorporated in the previous 30 days)  https://camo.githubusercontent.com/b3d61a6075db3816103f471673c8baf33085ccc67522a8b24992e1c8cd476e51/68747470733a2f2f696d616765732e7a656e68756275736572636f6e74656e742e636f6d2f3630303961656363643630343239636237303038653564332f37346131386631332d646664322d343264382d396232342d383238663961383464636464 and you can drill down through county and place to see the status of pieces. https://camo.githubusercontent.com/7657dab47b65249aed6d52838bc6f018d24b82fcb93e20bad885d6ef054d3671/68747470733a2f2f696d616765732e7a656e68756275736572636f6e74656e742e636f6d2f3630303961656363643630343239636237303038653564332f62316136623861622d646164362d343830382d393863352d303034323938326536313566  and both have Recent Additions buttons.
Is this an additional requirement for a csv file download perhaps that lists Pieces incorporated across the whole database in the previous xx days (xx range from 0 - 99) or between a date range or something else?
—
Reply to this email directly,  https://github.com/FreeUKGen/FreeCENMigration/issues/1211#issuecomment-1014933822 view it on GitHub, or  https://github.com/notifications/unsubscribe-auth/AKCPIFK7NOJUEOGIYMQN2YDUWSLVFANCNFSM43C5SYIQ unsubscribe.
Triage notifications on the go with GitHub Mobile for  https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 iOS or  https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub Android.
You are receiving this because you were mentioned.  https://github.com/notifications/beacon/AKCPIFNPTQHZ55I3EGCRDTDUWSLVFA5CNFSM43C5SYI2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOHR7KSPQ.gif Message ID: < @.> @.>

Chris Mahoney replied:
For any given piece, the newsletters report the following facts about it (refer to newsletter for sample):
County
Year
Piece Number
Place
Locations
Number of Entries
Have asked people what stats they would like me to report on, but beyond the above, have had no particular requests as to what they want to see.
I did discuss with Denise (I think it was Denise, but it could have been Pat) some sort of notification system for whenever a new piece is incorporated, and was told that it was on the list of things to do.  One of my suggestions to her on this was that, when the website emailed a co-ordinator that a piece had been incorporated, others such as myself would be CC'd in on that email.
Have seen Kirk's email on the new look Records Displayed on the website, and responded to it, with three points covered:

While I can obtain the requested stats from the website, some email notification system as discussed with Denise still preferred as it will be quicker and easier to obtain the required information than browsing though the website for it
Request that we still have the ability for any given county/year to view the overall pieces for that county/year see which pieces have been uploaded, what has yet to be done etc  (do know that general users of the website are interested in this info)
Request that a review of how it works out how many pieces there are for any given county/year, and gave him two samples in different counties of where the numbers were incorrect, thus misleading people as to the actual progress of the transcription in that county/year

Anne
I concur with Chris' comments but would add that the 'previous 30 days' could present a problem in 31 day months or when the stats are reported on on the 2nd or 3rd of the month.
I would like to see an option to select a date range or an option to select either the last 30 days or the last 45 days. That will overcome this issue.
The report images suggest that the report is County by County. With over 70 Counties Chris would need to look at every one of them to compile his report. For other FreeCEN actions a Coordinator has an option to select a County if they Coordinate more than one County. This information is a report and is published to everybody. So could all Coordinators have an option to select either a County or 'All'. This would allow Coordinators to manage their County(ies) and allow Chris and other management level people to view the whole results for the period.
The report formats look good subject to Chris' comments above.
Geoff.

Chris Mahoney has commented on my last comment:
Viewing a selected date range would an answer to ensure that no uploads on any given day have been missed, but a quicker, and easier way of getting the stats would still be preferable.
While the "Recent Additions for All Counties" page will let me view all additions for all counties over the past 30 days in one go, there were 122 locations on it when I looked just now, and getting the requested information would require me to go through each of them one at a time.  Although the page will give me the requested stats for a given location when I click on the "View Pieces" action button, what is really needed is a way to get all the stats for a given time-frame in one go instead of going through each place one at a time.
Not sure if Kirk has been filling you in on my response to his email to the list about the new look records section on the website, but he has replied to my email, and I have since responded to it.  To my three points raised to him:

Website stats (refer above), but still cannot recall exactly what it is that Denise had decided about this, Kirk did not know anything about it
Refer to attached scans that he sent me - have agreed with him on his suggestion for this
Where the website lists a piece as being split into separate parts (HO_368 from 1841 the sample we used) some options here are needed as the piece has been completed, and uploaded as one single file, but the website thinks the piece is split into two parts, second of which has not been done, and never will be unless I split the original upload into two, and upload again.  My suggestion to him on this is to leave the pieces split as they are, but give someone the ability to combine them where a piece has actually been uploaded in one single part instead of several smaller ones.

Geoff

@geoffj-FUG This story has become too confused and cluttered with other matters. Others are being written
Have written story Add display of pieces per year per county#1353 for the work Ability for Researchers and Members to view Piece Status by County. This requirement could be met by your suggestion for RECORDS County view to be enhanced to include 'View Pieces' button etc.

@geoffj-FUG Recent additions shows totals of all piece for a place#1352 raised in response to comment by coordinator

Have narrowed focus of this story

@Captainkirkdawson Just need final clarification as to where this functionality should sit. The first comment states : Maybe to go in "Site statistics" button? (not sure who said that) but I think you would prefer it to be on the Records page. I am slightly more in favour of Site Statistics which is where a CSV File download facility already exists and this is a type of statistic too as it is counts of pieces and records that Chris needs I believe.

@AnneV-Learn site statistics is fine; but means we will need to open that up to coordinators

Download of report requested by Chris has been added and deployed to test3. Date range is selectable. Available through the Site Statistics Action. Action has been opened up to county coordinators.

Believe to be deployed now, so closing


AppVeyor node_module caches get corrupted, let's just disable them for now

This PR removes the node_module caches so builds will complete, even if they're slower

Did you try installing a 4.x version of npm instead? @5 is super buggy atm and could cause the corruption.

Good point.  Why do we npm install -g npm?

@iolsen are you sure this was a good idea?

It's certainly not a long-term fix but we've been manually clearing the cache multiple times a day recently. Hopefully this relieves that pain short-term until we figure out the root cause.


encodeURIComponent where necessary

e.g. query params

@teohhanhui I will fix that in path-parser.

Fixed and released with<EMAIL_ADDRESS>

@teohhanhui is that you who raised an issue somewhere about a route callback invoked twice on start? Can't find it anymore.

@troch I don't think that's an actual issue. It was my own code that was at fault.

@teohhanhui no twas an issue, listeners registered prior to the router starting were invoked twice when defaulting to the default route. I has now be fixed in 1.2.1.

Mine was a different problem :)

OK :)


Don't decompress responses by default

Use case
When an HTTP Response is received, it is always decompressed before storing it in the 'responseData'. This is a waste of cpu and memory resources in the majority of the cases when the responseData is never used. Especially for heavy javascript and stylesheets, it can be a waste when the response isn't used for an extractor or assertion.
Imagine how much memory can be saved if we store the compressed content and don't decompress by default, and only decompress when the responseData is accessed. We could even safe more memory if we never store the response headers and body if the result isn't used.
Possible solution
Best solution:
Check if a sampler has extractor or assertion, only then decompress and store response data (header and body)
Improved solution
In case it is hard to detect whether the result will be accessed by code (jsr223, preprocessor of subsequent sampler etc), we can store the response data as is without decompressing upfront. In case the response data is accessed, then it should be decompressed.
We can even consider not storing the response data by default and use a flag on the sampler if we need to store it because future code need to access the data.
Possible workarounds
No response
JMeter Version
5.6.3
Java Version

OS Version

This is an interesting idea indeed.

The idea of not doing anything with the response data (not decompressing it, not storing it), is actually pretty tough to do. To detect an assertion or postprocessor is actually easy. It it a lot harder to detect if the next sampler needs the previous result. It is also hard to detect which attached listeners actually might need the responseData.
Easiest implementation would be to not decompress in the HTTPHC4Impl.java sampler, but return the raw body + content encoding, and do the decompression in getResponseData(). This will save a lot of bulk memory (heavy javascripts being added) and some cpu time for decompression.

Easiest implementation would be to not decompress in the HTTPHC4Impl.java sampler, but return the raw body + content encoding, and do the decompression in getResponseData(). This will save a lot of bulk memory (heavy javascripts being added) and some cpu time for decompression.

Frankly, I thought it was the best way to go as well.

My opinion:

not decompress in the HTTPHC4Impl.java sampler, but return the raw body + content encoding, and do the decompression in getResponseData().
Add a checkbox in http sampler to allow saving response (header + body) set to true by default (to don't change default behaviour)

It will allow advanced users don't waste memory + cpu if the user knows it will not be used (Gatling do this and Neoload don't save by default if I have well understood)


binance error

Hello,
When i run the bot in WSL i have this errors.
-- Binance Edition --
? Please select trade configuration?  market-trade-one
Traceback (most recent call last):
File "bot-binance.py", line 249, in
balance = acct_balance()
File "bot-binance.py", line 88, in acct_balance
acct_balance = client.get_asset_balance(asset=config['trade_configs']
File "/usr/local/lib/python3.8/dist-packages/binance/client.py", line 1979, in get_asset_balance
res = self.get_account(**params)
File "/usr/local/lib/python3.8/dist-packages/binance/client.py", line 1954, in get_account
return self._get('account', True, data=params)
File "/usr/local/lib/python3.8/dist-packages/binance/client.py", line 365, in _get
return self._request_api('get', path, signed, version, **kwargs)
File "/usr/local/lib/python3.8/dist-packages/binance/client.py", line 328, in _request_api
return self._request(method, uri, signed, **kwargs)
File "/usr/local/lib/python3.8/dist-packages/binance/client.py", line 309, in _request
return self._handle_response(self.response)
File "/usr/local/lib/python3.8/dist-packages/binance/client.py", line 318, in _handle_response
raise BinanceAPIException(response, response.status_code, response.text)
binance.exceptions.BinanceAPIException: APIError(code=-1021): Timestamp for this request was 1000ms ahead of the server's time.
I check everything and i cannot understand why, i have secrets and a valid api but cannot put the bot running.
Thanks.

Hey, see this issue thread
https://github.com/sammchardy/python-binance/issues/249

Thanks, problem solved!


Renders swaps as crossing lines in qcircuit

Could you say more about your "bucket of features" point? The essence of the PR is the following:

Introduction of `TextDiagramDrawer.horizontal_occlusions'.
Introduction of CircuitDiagramInfo.hconnected.
The optimization pass to pad after swaps.
line_macro.
swap_qcircuit_diagram_info.

Only (1) and (2) change the main code base in any way, and they seem like relatively minor additions.

This PR isn't a bucket of features by itself, it's one feature in a growing bucket.

@Strilanc @bryano Where does this stand since we are planning on getting rid of qcircuit?  https://github.com/quantumlib/Cirq/issues/1492.

Are we dropping support for qcircuit or just adding support for qpic?

Someone has to actually do the qpic work before we can drop anything related to qcircuit, but the issue seems to be languishing. Get this PR synced with master and I can give it another look.

Could you revert changes to files that were only formatted due to the old format script comparing to master instead of the merge base? It's creating a ton of noise making it hard to review.

Sorry about that. The formatting changes got comingled with real changes, so I checked out from master any file that differed only in whitespace, which I think is either the same as undoing the formatting changes or at least close thereto.

There are still a ton of format-only changes.
I'm not sure of a simple automated way to get rid of the format-only files. Look at the diff's original-file ranges, do incremental formatting on master vs those diffs, and see what matches up? Tricky to write.

I went back in manually and got rid of most of the formatting-only changes. LMK if there's still too much.

@Strilanc The only failing test is the formatting.

This seems to have grown stale.  I'm closing.  If it can be salvaged, please open a new PR.

@Strilanc I know you had some trepidation about this one.

Closed as stale.


Feature add editor config and align coding style

Basic information

nrich version:
1.1.1
Module:
Project

Additional information

Description
Summary

Add editorconfig and align coding style
Details

Added editorconfig, reformatted source code according to it, removed final modifier from variables and method parameters, aligned other differences in coding style.
Related issue

https://github.com/croz-ltd/nrich/issues/13
Types of changes

Refactoring

Checklist

[x] I have read the project's CONTRIBUTING document
[x] I have checked my code with the project's static analysis tooling
[x] I have formatted my code with the project's IDEA code-style configuration
[x] I have checked my code for misspellings
[x] I have organized my changes in easy-to-follow commits
[x] My change requires a change to the documentation
[x] I have updated the documentation accordingly
I have added tests to cover my changes (tests already exist)
[x] All new and existing tests pass.

It would be nice if all commit messages can start with a capital letter.

It would be nice if all commit messages can start with a capital letter.

Changed the commit messages and forced pushed them.


Vm.getCode can't find the artifact file: No matching artifact found

Ever since upgrading foundry today, all of my scripts that depended on vm.getCode are now failing.
foundryup Output

.xOx.xOx.xOx.xOx.xOx.xOx.xOx.xOx.xOx.xOx.xOx.xOx.xOx.xOx.xOx.xOx.xOx.xOx

 ╔═╗ ╔═╗ ╦ ╦ ╔╗╔ ╔╦╗ ╦═╗ ╦ ╦         Portable and modular toolkit
 ╠╣  ║ ║ ║ ║ ║║║  ║║ ╠╦╝ ╚╦╝    for Ethereum Application Development
 ╚   ╚═╝ ╚═╝ ╝╚╝ ═╩╝ ╩╚═  ╩                 written in Rust.

.xOx.xOx.xOx.xOx.xOx.xOx.xOx.xOx.xOx.xOx.xOx.xOx.xOx.xOx.xOx.xOx.xOx.xOx

Repo       : https://github.com/foundry-rs/
Book       : https://book.getfoundry.sh/
Chat       : https://t.me/foundry_rs/
Support    : https://t.me/foundry_support/
Contribute : https://github.com/orgs/foundry-rs/projects/2/

.xOx.xOx.xOx.xOx.xOx.xOx.xOx.xOx.xOx.xOx.xOx.xOx.xOx.xOx.xOx.xOx.xOx.xOx

foundryup: installing foundry (version nightly, tag nightly)
foundryup: downloading latest forge, cast, anvil, and chisel
############################################################################################################ 100.0%
foundryup: downloading manpages
############################################################################################################ 100.0%
foundryup: installed - forge 0.2.0 (844caa8 2024-04-20T00:16:40.844544000Z)
foundryup: installed - cast 0.2.0 (844caa8 2024-04-20T00:16:40.855337000Z)
foundryup: installed - anvil 0.2.0 (844caa8 2024-04-20T00:16:40.869255000Z)
foundryup: installed - chisel 0.2.0 (844caa8 2024-04-20T00:16:40.915894000Z)
foundryup: done!

Old foundry version
I can't tell what my older version was unfortunately.

relative path to artifact works, but inputs of format SolidityFile.sol:ContractName don't work.

cc @klkvr

Likely resolved by #7738, @arshan-ritual could you please try running foundryup tomorrow and check if issue persists? or foundryup -b master now

Yes, will do.

@arshan-ritual does it work for you on latest nightly?

Assuming this works now. Please feel free to re-open if that's not the case.

still having issues with this

@0xMySt1c are you using getCode for contracts under src/?

@klkvr using a custom dir set in foundry.toml

what are the differences between profiles?
No matching artifact means that it is not found in the artifacts which were recompiled. when running script, foundry only compiles everything under src/ and the script itself, so if your contract is not in this set, you might get this error

using a custom dir set in foundry.toml

you mean something like src = "contracts" in foundry.toml and vm.getCode("contracts/...") is failing?

i could read the profile and change the path. let me check to see if that works

using a custom dir set in foundry.toml

you mean something like src = "contracts" in foundry.toml and vm.getCode("contracts/...") is failing?

no using the format "Contract.sol:Contract"

confirming that a path works. my current workaround will be to determine the path using the profile

sorry what do you mean by "path" here? are two profiles operating on different src dirs?

getCode("out/artifacts/Contract.sol/Contract.json") works
getCode("Contract.sol:Contract") fails

can you confirm that getCode("Contract.sol:Contract") works on one profile, but fails on another? If so, could you please share what are the differenceses between profiles?


Prototype Pollution in JSON5 via Parse Method

Ref: https://github.com/advisories/GHSA-9c47-m6qq-7p4h
Context: Some of our repositories are using this library as a sub-dependency.
Action: Check if we need to patch the repos and coordinate the patching priority

@UlisesGascon
I'm not aware of a way to patch a transitive dependencies. Updating package-lock is useless for modules since it is excluded from the bundle published to npm. The only benefit is that it ensures everyone checking out the module has the same set of dependencies, but will not benefit anyone installing the module from npm.

I Agree @cressie176. I believe in most cases we get rid of the warning once we do the dependencies upgrade as part of the project lifecycle. @inigomarquinez is checking in case that we use it directly in any project and can affect us in a real scenario


0.3 Bug Fix Mega Thread

Bug fixes:

[x] Handle crate-on-crate collision
[x] Either revisit collision or adjust room 26 so springs don't launch cat into blocks just above their head

Tile fixes:

[x] Upper wall between room 1 & 2
[x] Reduce jump width from switch block to coin platform (room 10)
[x] Door walls in room 13
[x] Make half-blocks flush in room 19
[x] Room 10 has a rounded block below the key cage, but square above. Make consistent.

Balance fixes:

[x] Change switch blocks in room 2 to regular walls
[x] Adjust difficulty down in room 26
[x] Ensure room 19's puzzle needs the crate to reach each door

I've changed player jump acceleration from -1.8 to -1.6 (slightly smaller jump) and reduced the short blocks to 3 pixels high, instead of 4. This is done mainly to ensure room 19 works as intended; however, lots of testing needed to ensure these changes don't drastically change difficulty or make levels altogether impossible.

After some feedback on the Discord server, may be appropriate to adjust the opportunity cost for missing the coin in room 25. This makes the player re-attempt the 17 > 25 > 26 > 18 loop again. Since 26 is a non-trivial level, it can be quite frustrating to have to do it twice (or more). Consider saving 26's difficulty for a dead-end room, and instead, make 26 significantly easier to reduce the cost of making a mistake.


Fix uninitialized wfClientset in the Lint command

This PR resolves #1547
It adds a missing call to InitWorkflowClient() which initializes the wfClientset object used for validation.

LGTM


Use the tsconfig.json if present.

This is an enhancement that would be useful to have, particularly since most editors/IDEs want you to have the tsconfig.json file anyway. It should be a matter of reading in the config and passing the compilerOptions object to the transpileModule API.

I agree with you. This feature can be develop to propose a best integration.


Avoid Boost.Nowide by using std::filesystem::path?

If C++ 17 is ok, maybe Boost.Nowide can be avoided if std::filesystem::path can be used to read/write files with non-ascii names, e.g. on Windows? I believe std::filesystem::path::value_type is wchar_t on Windows.

I like the idea. I already use std::filesystem in branches.


usage: added handler for user id list

Closing this in favor of https://github.com/livepeer/livepeer-data/pull/173


Request for Publishing Project Architecture

I've faced frustration trying to comprehend the project's architecture and locating specific features. Recently, I encountered difficulties understanding the auth module while attempting to create a custom authentication flow. The Serverpod contains methods like 'updateStreamingConnectionAuthenticationKey,' which I found challenging to navigate, as well as the objective of creating a "Caller" to manage the client endpoint.
I would like the project team to publish an overview of the project's architecture inlc (Modules). This could include descriptions, or any other relevant information that would help users/contributors understand the project's layout.
I've thought about reaching out individually to team members for explanations, but having a centralized architecture document would benefit all users/contributors.
It would be beneficial for new users and my team members to have a clear understanding of the project's structure. This will help reduce confusion, improve onboarding, and make it easier to locate specific features within the project.

I would like to add a request for "fully fledged readmes" in all packages to that list - the current placeholders can be a bit frustrating when trying to understand how everything fits together (the pubspec.yaml's description often tells more about a package than the README :/ )

Hey @SurMesure237 👋
I completely understand your frustration. This is a really good suggestion that would greatly improve the possibility for the community to contribute to Serverpod.

A contribution that would be appreciated @SurMesure237 is if you could gather some good examples of architecture overviews.
This would help us narrow down what we should focus on to achieve.

this a good example from the Appwrite Team, here is the link to documentation : https://github.com/appwrite/appwrite


Please make ReadMe more detailed and include examples.

Include examples on how to use your package please, it is not easy to follow.

@danilozano Coming soon :)

Updated, sorry I'm really late. I'm planning a complete rewrite of this script for version 2 with more helpful methods.


Job pipelines are neither pause not resumed.

On MacBook i7 16GB
Workers: 2
Broker: AMQP
I tried to stress run a job by command: ab -c 100 -n 5000 http://localhost:8080/
In the middle, I paused the consumption by command: ./spiral jobs:pause local
In ideal scenario, The jobs should be paused and should not be released.
But the jobs are executing without any pause.
https://storyxpress.co/video/k9d272h6sjy6fhske

Jobs for the RR1 are almost deprecated. The new plugin is coming. Feel free to reopen this issue in the RR2.


Redirect IPv6 inbound traffic to specified port

Please provide a description for what this PR is for.
Redirect ipv6 inbound traffic to target ISTIO_IN_REDIRECT
And to help us figure out who should review this PR, please
put an X in all the areas that this PR affects.
[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[ x ] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure

Hi @ChangyuWang. Thanks for your PR.
I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

/ok-to-test

@ChangyuWang: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-mixer-k8s-tests_istio
769f40356e3bc9381cde11721e33a7ce58faaaa7
link
/test integ-mixer-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ChangyuWang: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-mixer-k8s-tests_istio
769f40356e3bc9381cde11721e33a7ce58faaaa7
link
/test integ-mixer-k8s-tests_istio

integ-telemetry-k8s-tests_istio
769f40356e3bc9381cde11721e33a7ce58faaaa7
link
/test integ-telemetry-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn OK, I will

@ChangyuWang: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-mixer-k8s-tests_istio
769f40356e3bc9381cde11721e33a7ce58faaaa7
link
/test integ-mixer-k8s-tests_istio

integ-telemetry-k8s-tests_istio
769f40356e3bc9381cde11721e33a7ce58faaaa7
link
/test integ-telemetry-k8s-tests_istio

integ-security-k8s-tests_istio
d20efe36c7434eb6b9978abcc1f4a462e415980b
link
/test integ-security-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ChangyuWang: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-mixer-k8s-tests_istio
769f40356e3bc9381cde11721e33a7ce58faaaa7
link
/test integ-mixer-k8s-tests_istio

integ-security-k8s-tests_istio
d20efe36c7434eb6b9978abcc1f4a462e415980b
link
/test integ-security-k8s-tests_istio

integ-new-install-k8s-tests_istio
d20efe36c7434eb6b9978abcc1f4a462e415980b
link
/test integ-new-install-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn done

@ChangyuWang: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-security-k8s-tests_istio
d20efe36c7434eb6b9978abcc1f4a462e415980b
link
/test integ-security-k8s-tests_istio

integ-new-install-k8s-tests_istio
07dbdd0d002898b1a80b2f9c92d74ed208edc687
link
/test integ-new-install-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

Can someone familiar with this code review? @sbezverk @rlenglet @lambdai

@howardjohn looks good to me

@howardjohn do you still have concerns blocking this PR?

Once this is merged, I will integrate it into istio/cni as well.

@ChangyuWang: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-galley-k8s-tests_istio
07dbdd0d002898b1a80b2f9c92d74ed208edc687
link
/test integ-galley-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ChangyuWang: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-galley-k8s-tests_istio
07dbdd0d002898b1a80b2f9c92d74ed208edc687
link
/test integ-galley-k8s-tests_istio

e2e-dashboard_istio
07dbdd0d002898b1a80b2f9c92d74ed208edc687
link
/test e2e-dashboard_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

@ChangyuWang: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

e2e-dashboard_istio
07dbdd0d002898b1a80b2f9c92d74ed208edc687
link
/test e2e-dashboard_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest


⚠ Bofrost.de has degraded performance

In 517b84d, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 1442 ms

Resolved: Bofrost.de performance has improved in 4110d44.


Tensorflow import error

Issue type
Build/Install
Have you reproduced the bug with TensorFlow Nightly?
Yes
Source
source
TensorFlow version
tf 2.13.0
Custom code
Yes
OS platform and distribution
Win 11
Mobile device
No response
Python version
3.9.7
Bazel version
No response
GCC/compiler version
No response
CUDA/cuDNN version
No response
GPU model and memory
No response
Current behavior?
I intalled tensorflow, but it gives an error when I try to import it.
Standalone code to reproduce the issue
import tensorflow as tf

Relevant log output
runfile('X:/Nano-Photonics and Quantum Optics Lab!/ML Project/Tkinter learning/Tkinter Git - GitLab/Inverse_Design_Periodic_GUI_CustomModern.py', wdir='X:/Nano-Photonics and Quantum Optics Lab!/ML Project/Tkinter learning/Tkinter Git - GitLab')
Traceback (most recent call last):

  File "X:\Nano-Photonics and Quantum Optics Lab!\ML Project\Tkinter learning\Tkinter Git - GitLab\Inverse_Design_Periodic_GUI_CustomModern.py", line 20, in <module>
    import tensorflow as tf  #print(tf.__version__)

  File "C:\Users\athen\anaconda3\lib\site-packages\tensorflow\__init__.py", line 469, in <module>
    _keras._load()

  File "C:\Users\athen\anaconda3\lib\site-packages\tensorflow\python\util\lazy_loader.py", line 41, in _load
    module = importlib.import_module(self.__name__)

  File "C:\Users\athen\anaconda3\lib\importlib\__init__.py", line 127, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)

  File "C:\Users\athen\anaconda3\lib\site-packages\keras\__init__.py", line 20, in <module>
    from keras import distribute

  File "C:\Users\athen\anaconda3\lib\site-packages\keras\distribute\__init__.py", line 18, in <module>
    from keras.distribute import sidecar_evaluator

  File "C:\Users\athen\anaconda3\lib\site-packages\keras\distribute\sidecar_evaluator.py", line 22, in <module>
    from keras.optimizers.optimizer_experimental import (

  File "C:\Users\athen\anaconda3\lib\site-packages\keras\optimizers\__init__.py", line 25, in <module>
    from keras import backend

  File "C:\Users\athen\anaconda3\lib\site-packages\keras\backend\__init__.py", line 3, in <module>
    from keras.backend import experimental

  File "C:\Users\athen\anaconda3\lib\site-packages\keras\backend\experimental\__init__.py", line 3, in <module>
    from keras.src.backend import disable_tf_random_generator

  File "C:\Users\athen\anaconda3\lib\site-packages\keras\src\__init__.py", line 21, in <module>
    from keras.src import applications

  File "C:\Users\athen\anaconda3\lib\site-packages\keras\src\applications\__init__.py", line 18, in <module>
    from keras.src.applications.convnext import ConvNeXtBase

  File "C:\Users\athen\anaconda3\lib\site-packages\keras\src\applications\convnext.py", line 28, in <module>
    from keras.src import backend

  File "C:\Users\athen\anaconda3\lib\site-packages\keras\src\backend.py", line 35, in <module>
    from keras.src.engine import keras_tensor

  File "C:\Users\athen\anaconda3\lib\site-packages\keras\src\engine\keras_tensor.py", line 19, in <module>
    from keras.src.utils import object_identity

  File "C:\Users\athen\anaconda3\lib\site-packages\keras\src\utils\__init__.py", line 20, in <module>
    from keras.src.saving.serialization_lib import deserialize_keras_object

  File "C:\Users\athen\anaconda3\lib\site-packages\keras\src\saving\serialization_lib.py", line 28, in <module>
    from keras.src.saving.legacy.saved_model.utils import in_tf_saved_model_scope

  File "C:\Users\athen\anaconda3\lib\site-packages\keras\src\saving\legacy\saved_model\utils.py", line 30, in <module>
    from keras.src.utils.layer_utils import CallFunctionSpec

  File "C:\Users\athen\anaconda3\lib\site-packages\keras\src\utils\layer_utils.py", line 26, in <module>
    from keras.src import initializers

  File "C:\Users\athen\anaconda3\lib\site-packages\keras\src\initializers\__init__.py", line 23, in <module>
    from keras.src.initializers import initializers_v1

  File "C:\Users\athen\anaconda3\lib\site-packages\keras\src\initializers\initializers_v1.py", line 32, in <module>
    keras_export(v1=["keras.initializers.Zeros", "keras.initializers.zeros"])(

  File "C:\Users\athen\anaconda3\lib\site-packages\tensorflow\python\util\tf_export.py", line 348, in __call__
    self.set_attr(undecorated_func, api_names_attr, self._names)

  File "C:\Users\athen\anaconda3\lib\site-packages\tensorflow\python\util\tf_export.py", line 363, in set_attr
    raise SymbolAlreadyExposedError(

SymbolAlreadyExposedError: Symbol Zeros is already exposed as ().

if you have a function or variable named Zeros in your code and you also import tensorflow, which also defines a symbol named Zeros, it can lead to this conflict.

@athenax246,
Could you please provide the steps you followed to install the tensorflow on the Windows machine. With the error I assume that the tensorflow was not properly installed and also while installation the compatible tested build configurations have to follow for the smooth installation.
https://www.tensorflow.org/install/source_windows
Thank you!

Thanks for you reply, I am using tensorflow in the Anaconda environment.
For installation, I used:
conda create --name tf_cpu
conda activate tf_cpu

@athenax246,
I tried to install the tensorflow v2.13 on Windows 11 using conda and it was installed without any issue/error and also I am able to import the tensorflow. Kindly find the screenshot for the reference.

Thank you!

Problem solved, thanks so much!

@athenax246,
Glad the issue is resolved for you, Could you please feel free to move this to closed status. Thank you!


SSL Certificate expired

Seems like the SSL certificate of the website to download the data has been expired. It is possible to use --no-check-certificate but is a riskier option.

Hi, I also encounter this problem. Did you find a way to solve the downloading problem? Thanks!

Seems like the SSL certificate of the website to download the data has been expired. It is possible to use --no-check-certificate but is a riskier option.

Hi, I also encounter this problem. Did you find a way to solve the downloading problem? Thanks!


Have Brimcap use new endpoint for posting data

As of brimdata/brim#1708, zapi load hits the newer API endpoint that ultimately causes Brim to notify the user that new data has arrived in the Pool and offers them a Refresh button so they can immediately see it. However, brimcap load is currently still hitting the old endpoint. We've discussed having brimcap load start using the new endpoint so users will have a consistent experience regardless of their choice of CLI tooling.

The change specific to brimcap load as described in the linked PR is no longer relevant. Instead, per #113, brimcap load has phased out, such that as of Brimcap release tagged v0.0.6, the README now exclusively describes the "a la carte" combination of brimcap analyze and brimcap index and nods toward zapi as the way to create Pools and load Brimcap-produced output if the intent is to work with it in the Brim app. zapi hits the new endpoint.


Can't zoom in if keyboard layout is set to German

It is not possible to use [CTRL-SHIFT] +  to Zoom in if the keyboard Layout is set to German. Other keyboard layouts might also be affected.
Tested on: Ubuntu Linux (Gnome) 16.10
Binary Ninja version: 1.1.922 (Build ID 4d40ebb7)

Tracking is now in #92 instead of 481.


It is possible to bypass banned words, by using exec function and special characters

Thank you, @gabrielesilinic for pointing this out. I am creating this issue on Github, for future reference.
This issue has been currently resolved by banning exec #4

user:
exec("\x66\x72\x6f\x6d\x20\x74\x69\x6d\x65\x20\x69\x6d\x70\x6f\x72\x74\x20\x74\x69\x6d\x65")
print(time())

bot replied:
1605013849.2719617

now exec is banned


Recv: avoid sleep calls

Reactive API clients should avoid using blocking calls. Current receiver implementation is using sleep calls (utils.sleep4next) that should be removed. Equivalent functionality shall be implemented based on consumer credit. Use of scheduler may be desired. Get rid of all the utils.sleep4next calls in Recv class.

Use of scheduler may be desired

Should we use the module schedule?

Should we use the module schedule?

Yes, please use schedule module.


Trident v22.10 - mount.nfs: access denied by server while mounting

Describe the bug
As the latest Trident releases auto export the subnet to the export policy for the target volume, we are still seeing access denied errors randomly on some of the nodes in our Kubernetes 1.22 cluster. The issue goes away when we restart the trident pod on the particular node where the issue is seen.
Environment
Kubernetes 1.22 cluster, os on the nodes: ubuntu 20.04

Trident version: 22.10
Container runtime: contained v1.6.4
Kubernetes version: v1.22.8
Kubernetes orchestrator: kubespray
Kubernetes enabled feature gates: [e.g. CSINodeInfo]
OS: Ubuntu 20.04
NetApp backend types: ontap-nas

To Reproduce
The problem appears randomly on some nodes in the cluster and goes away after the restart of the trident pod.
Expected behavior
No issues seen with mount access when using trident v22.10 version

Closing. Please re-open if you notice this issue with newer versions of Trident.


create separate options files for network plugins

In addition to https://github.com/kubernetes-incubator/kubespray/pull/3210
Split the settings of network plug-ins into separate files.
remove plugin options from common files

ci check this

/lgtm
/approve


What if i need use different programming language on another microservice node?

Any idea
@icebob

The transport protocol is quite simple, you can implement it in any programming language.

@kevinries
just via transport protocol? okay, thank you.


Add exclusive-lock and journaling image features for RBD image

Describe what this PR does
Add exclusive-lock and journaling image features for rbd image
Current rbd plugin only supports the layering feature
for rbd image. Add exclusive-lock and journaling image
features for the rbd plugin.

Is there anything that requires special attention
If we enable the journaling feature, krbd doesn't work for the mount. We need to force mapping by rbd-nbd.
Related issues
closes: #676
Future concerns
NONE

Hi, I'm glad to join ceph-csi. If I have wrong code or concept, please let me know. I will fix up immediately. Thanks!

@dillaman PTAL

@Madhu-1
Thanks for your reply. I will add E2E test to cover this.
but i didn't understand other two suggestion. could you please explain more?

passing exlusive-lock and journaling from storageclass
I'm testing by creating storage class parameter with 'imageFeatures: layering,journaling,exclusive-lock' and check the image has these features. is there any other to do? (except e2e tests)

Testing with krbd and rbd-nbd
If we enable image journaling option, we can't mount with krbd. because It is not supported that mounting the journaling volume in krbd. we need to use rbd-nbd.

@Madhu-1
Thanks for your reply. I will add E2E test to cover this.
but i didn't understand other two suggestion. could you please explain more?

passing exlusive-lock and journaling from storageclass

okay I missed adding more information we need to update documentation and storageclass  examples for these features https://github.com/ceph/ceph-csi/blob/master/examples/rbd/storageclass.yaml#L24-L26 and  https://github.com/ceph/ceph-csi/blob/master/docs/deploy-rbd.md

I'm testing by creating storage class parameter with 'imageFeatures: layering,journaling,exclusive-lock' and check the image has these features. is there any other to do? (except e2e tests)

Testing with krbd and rbd-nbd
If we enable image journaling option, we can't mount with krbd. because It is not supported that mounting the journaling volume in krbd. we need to use rbd-nbd.

i that case we need to error out  in the node stage request if the mounter is krbd

@Madhu-1 I apply your suggestion. Could you please check the commit? Thanks.

How about object-map feature? Any reason to not enable it?

@dimm0 Yes, there's no reason to not enable the object-map feature. But the pr stale for now, If pr is processed, I will add the feature. Thanks!! :)

Is this still pending in the new version?

@Madhu-1 did you get a chance to review this PR? Thank you.

@Madhu-1 I made some code changes to make it easy to add image features in the future. For example, if we want to add a fast-diff image feature, we need to specify it needs an object map in the future. Could you please review the code again?

@Madhu-1 I am looking at how to change this PR and trying to change the ImageFeature field from string to librbd.FeatureSet in rbdVolume struct. Can this makes another impact? Why is there a JSON tag in the rbdVolume type? The implementation of FeatureSet is here: https://github.com/ceph/go-ceph/blob/master/rbd/features.go#L106
current rbdVolume
type rbdVolume struct {
	RbdImageName       string
// ...
	ImageFeatures      string `json:"imageFeatures"`
// ...
}

changed rbdVolume
type rbdVolume struct {
	RbdImageName       string
// ...
	ImageFeatures      librbd.FeatureSet
// ...
}

@Madhu-1 I am looking at how to change this PR and trying to change the ImageFeature field from string to librbd.FeatureSet in rbdVolume struct. Can this makes another impact? Why is there a JSON tag in the rbdVolume type? The implementation of FeatureSet is here: https://github.com/ceph/go-ceph/blob/master/rbd/features.go#L106
current rbdVolume
type rbdVolume struct {
	RbdImageName       string
// ...
	ImageFeatures      string `json:"imageFeatures"`
// ...
}

changed rbdVolume
type rbdVolume struct {
	RbdImageName       string
// ...
	ImageFeatures      librbd.FeatureSet
// ...
}

we have json tag to support backward compatibility for v1.0.0 volumes, removing/changing the fields may result in breakage

we have json tag to support backward compatibility for v1.0.0 volumes, removing/changing the fields may result in breakage

Ok, I will proceed without changing the field.

@Madhu-1 I added a new commit, and it seems to work fine. Can you please review again?

@woohhan did you make go mod vendor? as grpc is having a minor update, the go modules will get auto-updated, we cannot control it how we controller it in dep

@Madhu-1 @nixpanic
I think I found the cause. Ran the go mod verify command on the master branch, the go.mod file was changed in the GRPC version from 1.26.0 to 1.27.0. I think we need to update the master branch with go mod verify command.
We're checking go mod verify in the CI pipeline: link however, this doesn't seem enough. (It always return 0)
I think the reason there is no modification in /vendor is because we have the line below in go.mod. When I deleted that line and ran go mod vendor, the modification was applied to the vendor directory.
replace (
    google.golang.org/grpc => google.golang.org/grpc v1.26.0
// ...
)

I think it would be ok if I add the third commit for updating the GRPC version.

The commit was updated.

Looks good to me, but maybe you want to correct the subject of the 3rd commit, it has a typo in "journlaing"

Oh, Thanks. Fixed typo!

@Madhu-1 Hi, Could you please check the PR? Thanks!

updating grpc does not seem to be expected, it needs to stay at v1.26
Ok, I Removed unnecessary commits. @nixpanic @Madhu-1

hi, @phlogistonjohn. Thanks for your review! I will check the review and may apply the suggestion soon.

I wonder how testing succeeds... we should probably add a check that nothing makes uncommitted changes to vendor/.

I wonder how testing succeeds... we should probably add a check that nothing makes uncommitted changes to vendor/.

testify is already part for vendor directory as this is required by some dependency. we need to set it
explicitly to some specific version in  go.mod

I wonder how testing succeeds... we should probably add a check that nothing makes uncommitted changes to vendor/.

testify is already part for vendor directory as this is required by some dependency. we need to set it
explicitly to some specific version in go.mod

@nixpanic When I ran the go mod vendor command, there's nothing changed, so I checked the vendor directory and found that it already exists as @Madhu-1 said.
Do we need to set the version of the testify? If we specify a verison that is the same as in the vendor directory, there will be no changes.

I wonder how testing succeeds... we should probably add a check that nothing makes uncommitted changes to vendor/.

testify is already part for vendor directory as this is required by some dependency. we need to set it
explicitly to some specific version in go.mod

@nixpanic When I ran the go mod vendor command, there's nothing changed, so I checked the vendor directory and found that it already exists as @Madhu-1 said.
Do we need to set the version of the testify? If we specify a version that is the same as in the vendor directory, there will be no changes. (except go.mod and go.sum)

@woohhan can you make all ?

I wonder how testing succeeds... we should probably add a check that nothing makes uncommitted changes to vendor/.

testify is already part for vendor directory as this is required by some dependency. we need to set it
explicitly to some specific version in go.mod

@nixpanic When I ran the go mod vendor command, there's nothing changed, so I checked the vendor directory and found that it already exists as @Madhu-1 said.
Do we need to set the version of the testify? If we specify a version that is the same as in the vendor directory, there will be no changes. (except go.mod and go.sum)

@woohhan can you make all ?

I did make all but nothing changed!

Semantic Pull Request not restart?

@woohhan can you force push once again?

I think the CI failed because of this problem:
May 11 12:21:12.848: INFO: At 2020-05-11 12:11:12 +0000 UTC - event for csi-rbd-demo-pod: {attachdetach-controller } SuccessfulAttachVolume: AttachVolume.Attach succeeded for volume "pvc-806abbbd-9380-11ea-9312-42010a140134"
May 11 12:21:12.848: INFO: At 2020-05-11 12:11:29 +0000 UTC - event for csi-rbd-demo-pod: {kubelet minikube} FailedMount: MountVolume.MountDevice failed for volume "pvc-806abbbd-9380-11ea-9312-42010a140134" : rpc error: code = Internal desc = rbd: map failed exit status 6, rbd output: rbd: sysfs write failed
RBD image feature set mismatch. You can disable features unsupported by the kernel with "rbd feature disable replicapool/csi-vol-80a56ad0-9380-11ea-9c69-0242ac110010 journaling".

In case the attacher/rbd-plugin needs to write to /sys/..., it may need additional configuration in the deployment spec.
(note that the Semantic Pull Request bot is not enforced, failing is accepted - and we don't understand yet why it fails)

I think the CI failed because of this problem:
May 11 12:21:12.848: INFO: At 2020-05-11 12:11:12 +0000 UTC - event for csi-rbd-demo-pod: {attachdetach-controller } SuccessfulAttachVolume: AttachVolume.Attach succeeded for volume "pvc-806abbbd-9380-11ea-9312-42010a140134"
May 11 12:21:12.848: INFO: At 2020-05-11 12:11:29 +0000 UTC - event for csi-rbd-demo-pod: {kubelet minikube} FailedMount: MountVolume.MountDevice failed for volume "pvc-806abbbd-9380-11ea-9312-42010a140134" : rpc error: code = Internal desc = rbd: map failed exit status 6, rbd output: rbd: sysfs write failed
RBD image feature set mismatch. You can disable features unsupported by the kernel with "rbd feature disable replicapool/csi-vol-80a56ad0-9380-11ea-9c69-0242ac110010 journaling".

In case the attacher/rbd-plugin needs to write to /sys/..., it may need additional configuration in the deployment spec.
(note that the Semantic Pull Request bot is not enforced, failing is accepted - and we don't understand yet why it fails)

looks deploy mounts /sys here? But it's strange, I haven't changed the code. I think I need to build a test environment again and fix it...

I0511 12:16:37.634510    2911 rbd_util.go:606] ID: 72 Req-ID: 0001-0024-b7b15817-390a-4571-b21f-ca6e7f7a502b-0000000000000001-1758ca5c-9380-11ea-90d0-0242ac110011 setting rbd image features: layering,journaling,exclusive-lock, mounter: rbd

the issue here is its  using rbd mounted for image features layering,journaling,exclusive-lock is it something supported?

moved this out of release-v3.0.0 milestone

moved this out of release-v3.0.0 milestone

Why!?

moved this out of release-v3.0.0 milestone

Why!?

As this PR is stale for at least last 2 months moved it to next release -v3.1.0

@woohhan do you have free time to work on this one? or shall I take it over and mention your name as a co-author?

@Madhu-1 Could you please take it over? unfortunately i have no time to proceed... thanks

@Madhu-1 Could you please take it over? unfortunately i have no time to proceed... thanks

@woohhan Thanks for the confirmation :+1:

closing this one in favor of https://github.com/ceph/ceph-csi/pull/1325


usefullness check

Hello,
Very useful script, but does line 40 should exist?
I guess it says to return nothing when offset is 0, but CSS expects some value and fails when there isn't any.
I got it working by deleting 'usefullness check'...

Hi @vhs-kid,
in fact if you follow “progressive enhancement” philosophy, you should have a pure CSS fallback.
So the JS code follow this thing: if it isn't needed, it just lets CSS to handle the regular behaviour.
I should add it to the doc :)


[docs] Simplify selection control demos

Following the lead of the checkbox demos, now the radio button demos show how to show an error.

That reminds me, I have a branch where I started a demo simplification effort. I plan to do more, but I should submit it before it gets too out of date!

I added a new demo for showing errors and removed the error demos I added to the other demos.

If this pr is good can you recommend some other demos to update?

For the Radio Group demo, I wonder if we need the "labelPlacement start" version? There is already a separate Label Placement demo.
For the Label Placement demo, you could perhaps make the first radio selected by default. This will give us a regression test for color="primary" to replace that lost from the above change, as well as following best practice.
I would also suggest reordering them to put "End" first, and removing the labelPlacement prop, since it is the default.

I'm not convinced by the error demo. If selecting an available option is an error, then that suggest there is a bug in the application, and that that option should have been disabled instead.

I'll make those changes tomorrow.
Showing errors was hard for me to understand at first, so I believe it should stay. A common use case for this would be to highlight an incorrect answer on a quiz.
If you want me to build that out I can add a button, and when that button is pressed it checks if the right answer is pressed, if not it will show the error.

Interesting. Thanks for the real-world use case. (It's also one of those rare instances where not having a default makes sense.)
We need to balance the simplicity of the demos with practical examples. In this case I think it's worth the trade-off of showing a more completely worked example. @oliviertassinari what do you think?

I think that a small validation demo wouldn't harm. Bootstrap includes it: https://getbootstrap.com/docs/4.4/components/forms/#supported-elements.

@mbrookes is something wrong with Argos?

Yep

@mbrookes Is there a way to trigger a re-run of the test so this PR can get approved?

@theswerd I believe we're still waiting for https://github.com/mui-org/material-ui/pull/19599#issuecomment-583809111, so when you push that, it'll be run again. (If it still fails we can merge anyway.)

@mbrookes it looks like its still not working


Page transition rerendering component when _app state changes

Hello,
I am using this component for transitioning routed component in nextjs.
Problem comes when you change something in state in _app.js file, which manages applications wrapper, render will fire, which is expected behavior. But along with it, children of <PageTransition> component will re-render. Now, this will unmount and mount everything inside.
There should be some kind of custom shouldComponentUpdate implementation that if children don't change, you don't re-render them. Since the point of transition is to animate only if children of <PageTransition> change.
I suppose this can be solved if you replace React.Component with React.PureComponent, i guess that shallow comparison of React will do the job.
Thanks,
Mario

Did you check out the "Handling Context/Store changes that update props on the Component" section on the Readme?

Sorry but I could not find such section in Readme.

+1, can't find this in the readme


Add CSV importer widget - WIP

This PR introduces a CSV importer for bulk update of IP addresses

We shipped this in another issue. Closing


coordgenlibs: 3.0.1 -> 3.0.2

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/schrodinger/coordgenlibs/releases.
meta.description for coordgenlibs is: Schrodinger-developed 2D Coordinate Generation
Updates performed

Version update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
found 3.0.2 with grep in /nix/store/y2jvyf6igjnk3qlgmfj0hwlgrw1a0fiv-coordgenlibs-3.0.2
found 3.0.2 in filename of file in /nix/store/y2jvyf6igjnk3qlgmfj0hwlgrw1a0fiv-coordgenlibs-3.0.2

Rebuild report (if merged into master) (click to expand)

3 total rebuild path(s)

3 package rebuild(s)

First fifty rebuilds by attrpath
coordgenlibs
python310Packages.rdkit
python311Packages.rdkit

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/y2jvyf6igjnk3qlgmfj0hwlgrw1a0fiv-coordgenlibs-3.0.2 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A coordgenlibs https://github.com/r-ryantm/nixpkgs/archive/b9d22bb38e89dbb962967df2e7a7ca34d87db2ec.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/y2jvyf6igjnk3qlgmfj0hwlgrw1a0fiv-coordgenlibs-3.0.2
ls -la /nix/store/y2jvyf6igjnk3qlgmfj0hwlgrw1a0fiv-coordgenlibs-3.0.2/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package failed to build:

python311Packages.rdkit

2 packages built:

coordgenlibs
python310Packages.rdkit

Maintainer pings
cc @rmcgibbo for testing.

@ofborg build python311Packages.rdkit

@ofborg build python310Packages.rdkit


DateTime format (Property_DateTime)

I think the date format should be changed to% Y-% m-% dT% H:% M:% S.% f (with "T") as suggested in the discussion https://github.com/homieiot/convention/issues/160. It's according to ISO8601

Agree, again, was hoping that the Homie maintainers would make a formal change to the spec. Do you want to do a PR and change it?

fix merged