feature request: ask gm what dc is needed for sickened condition

i would like someway as a gm to store the sickened dc to the sickened condition. alot of the time when a sickened condition is applied to overcome it it requires the dc from the creature that gave the pc the sickened condition.
the solution i propose is if the gm drags the sickened condition onto a pc that it asks for a dc value or none if not applicable.
we could add this saved DC to the effects hud and as a link for them to save in the chat. this would save trying to find which monster is responsible for the sickened dc.

This should probably be implemented with the same coding as afflictions will have and not be bespoke. It would be bad UX design

thanks i hope it does. going back to look at what your dc is on a sheet you arnt using anymore wastes precious time. so i thought if it were to store the dc somehow it would help for players to roll against it.


Habroxia [PCSB01365]

App summary

App name: Habroxia
App serial: PCSB01365
App version: 1.00

Vita3K summary

Version: v0.1.8
Build number: 3237
Commit hash: https://github.com/vita3k/vita3k/commit/eb521c25
CPU backend: Dynarmic
GPU backend: Vulkan

Test environment summary
Tested by: space1
OS: Windows 11
CPU: AMD Ryzen 5 3600
GPU: Nvidia 3070
RAM: 32 GB
Issues
Screenshots

Log
vita3k_save.log
Recommended labels
Playable

Vita3K summary

Version: v0.2.0
Build number: 3703
Commit hash: https://github.com/vita3k/vita3k/commit/0a3ba020
CPU backend: Dynarmic
GPU backend: Vulkan

Test environment summary

Tested by: Slade
OS: Microsoft Windows 10 Professional (build 19045)
CPU: Intel(R) Core(TM) i7-3770K CPU @ 3.50GHz
GPU: NVIDIA GeForce GTX 1060 6GB
RAM: 16 GB

Issues

The game plays well, with some slow downs noted. This is likely my aging hardware.
The game does not save any data, despite the log suggesting the game does save. Restarting the game resets the game back to the beginning.

Screenshots

Log
PCSB01365 - [Habroxia].log
Recommended labels

Ingame +
Savedata bug

Issue of save is fixed on pr https://github.com/Vita3K/Vita3K/pull/3483

Thanks again.
As all the others, I'll update the report once this fix goes live to the general public.

Thanks again. As all the others, I'll update the report once this fix goes live to the general public.

Is already now merged

Vita3K summary

Version: v0.2.0
Build number: 3706
Commit hash: https://github.com/vita3k/vita3k/commit/baecccb0
CPU backend: Dynarmic
GPU backend: Vulkan

Test environment summary

Tested by: Slade
OS: Microsoft Windows 10 Professional (build 19045)
CPU: Intel(R) Core(TM) i7-3770K CPU @ 3.50GHz
GPU: NVIDIA GeForce GTX 1060 6GB
RAM: 16 GB

Issues

The game plays well, with some slow downs noted. This is likely my aging hardware. Slowdowns below 40fps are noticeable.

Screenshots

Log
PCSB01365 - [Habroxia].log
Recommended labels

Playable


Add humbold.BinaryComparator for using with Hadoop's BinaryPartitioner

This replaces Humboldt::BinaryPrefixPartitioner and friends, if you can live with having to write a more cryptic job configuration. The idea is that Hadoop's BinaryPartitioner is both more efficient and more versatile than what's currently in Humboldt, but Hadoop is missing a comparator that works with the same offset configuration.
For secondary sort instead of
partitioner(MyPartitionerBasedOnBinaryPrefixPartitioner)
grouping_comparator(MyComparatorBasedOnBinaryPrefixComparator)

you'll have to do (assuming the classes in the example above are configured to look at the first 12 bytes)
raw do |job|
  job.set_partitioner_class(Hadoop::Mapreduce::Lib::Partition::BinaryPartitioner)
  Hadoop::Mapreduce::Lib::Partition::BinaryPartitioner.set_offsets(job.configuration, 0, 11)
  job.set_grouping_comparator_class(Humboldt::JavaLib::BinaryComparator)
  Humboldt::JavaLib::BinaryComparator.set_offsets(job.configuration, 0, 11)
end

if you want to do secondary sort on a 12 byte suffix you can use -12 and -1 as the left and right offset for both the partitioner and comparator. The offsets are somehow based on Python string slicing, which I guess is more or less how Ruby's range slicing works too (it's just that you usually don't use ranges for slicing strings in Ruby). This means that if you want the first 12 bytes that's 0, 11 and not 0, 12 as you might expect if you're like me and assume the second argument is the length.

For anyone horrified by the configuration to use this for secondary sort, maybe I should add a macro to the DSL to do it:
job 'foobar' do
  mapper FooMapper
  reducer BarReducer
  secondary_sort 2..34
end

What do you think?

:+1: on the macro! I think the other way is too low-level.

I also prefer the macro version.

Turns out that Hadoop calls #compareBytes(byte[],int,int,byte[],int,int) directly, and not through #compare(WritableComparable,WritableComparable) as I thought. This means that the implementation must know about the type of the objects compared, otherwise it won't take things like size prefix into account.

The implementation now takes size prefixes of Text and BytesWritable into account, and I've added a secondary_sort macro to the DSL.
The unit tests have been updated to test both #compare(WritableComparable,WritableComparable) and #compare(byte[],int,int,byte[],int,int), and there is an integration tests for secondary_sort.

The tests fail in Travis because the integration test doesn't find the secondary_sort macro. I don't understand how it could not, since it finds the other Rubydoop extensions that Humboldt adds.


Add repository to MR-Hub

https://ismrm.github.io/mrhub/

Hello dear, as i am going through it, I want to know exactly what are we looking for? If you'll give me overview then i can work on this.

Hi @ayudixit, this issue will have to be addressed outside of this GitHub repo and is just reminder for the task force. No changes to the code are needed for this.


issue template: use input boxes

Motivations
https://github.com/babel/babel/issues/new/choose (bug report and feature request) are really cool!
If you use the input box, you don't have to deal with markdown comments.
Solution
Can we bring the input boxes in our https://github.com/rust-github/template/tree/main/.github/ISSUE_TEMPLATE ?

The "syntax for issue" is still in beta today according to the official website, so I think it's better to wait until they are stable.


optimize capabilities

这个 PR 实现什么功能/修复什么问题:
office响应大概在1s左右
/cc @swordqiu @ioito
/area region

是否需要 backport 到之前的 release 分支:

Codecov Report

Merging #5731 into master will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #5731      +/-   ##
==========================================
- Coverage    6.95%    6.95%   -0.01%
==========================================
  Files         635      635
  Lines      107812   107842      +30
==========================================
  Hits         7497     7497
- Misses      99737    99767      +30
  Partials      578      578

Flag
Coverage Δ

#aFlag
6.95% <0.00%> (-0.01%)
:arrow_down:

Impacted Files
Coverage Δ

pkg/compute/models/capabilities.go
0.00% <0.00%> (ø)

pkg/compute/models/scaling_group.go
2.27% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b9688a...d80f0ba. Read the comment docs.

/lgtm


ci: Increase test timeout from 5 to 15 seconds

The 5 seconds timeout is appropriate if the tests run on baremetal,
but according to recent changes on QEMU parameters if running in a
nested environment, the tests have been slowed down by disabling fast
MMIO access previously performed by virtio 1.0.
And given the fact that our CI runs on a VMM, we cannot afford this
timeout of 5 seconds. Moving this timeout to 15 seconds makes the
tests passing even when run inside a VM.
Fixes #412

This makes sense to me.
afaik, the timeout is only for the (hopefully very rare) error case, so we don't really care how big it is, as 99% of the time the tests should work and not hit the timeout. As long as the timeout catches the hung up cases, that should be fine.
I've added @chavafg to the review list for his thoughts.
lgtm

Thanks @grahamwhaley.
@chavafg if you think the change is fine, go ahead and merge it.

lgtm, anyway PnP will notice if our times got too much higher, right @grahamwhaley?

heh, right @chavafg  Yes, I don't see this timeout being used to capture 'you made it all very slow' really :-)

@chavafg can you merge this please ?


charts: helm v3 charts for agent and analyzer

in this PR I provide a:

two independent charts skydive-analyzer and skydive-agent to enable more flexible deployments
upgrade to helm3

note that I want to propose using the main repo skydive rather than auxiliary repos as this will provide for easier integration, faster development, and better CI coverage (later I would propose EOL of the skydive-helm and skydive-operator). some examples of other projects which use this approach:

Fleet: https://github.com/rancher/fleet/tree/master/charts
Istio: https://github.com/istio/istio/tree/master/manifests/charts/base

no CI tests currently - so attaching the status output:
$ make status
make -C skydive-analyzer status
make[1]: Entering directory '/home/aidan/projects/skydive-project/skydive/charts/skydive-analyzer'
kubectl get all -l app=skydive-analyzer-skydive-analyzer
NAME                                                              READY   STATUS    RESTARTS   AGE
pod/skydive-analyzer-skydive-analyzer-analyzer-54cb487d8d-drwld   2/2     Running   0          55m

NAME                                                         TYPE        CLUSTER-IP      EXTERNAL-IP   PORT(S)                         AGE
service/skydive-analyzer-skydive-analyzer-internal-service   ClusterIP   <IP_ADDRESS>    <none>        12379/TCP,9200/TCP              55m
service/skydive-analyzer-skydive-analyzer-service            NodePort    <IP_ADDRESS>   <none>        8082:31996/TCP,8080:30595/TCP   55m

NAME                                                         READY   UP-TO-DATE   AVAILABLE   AGE
deployment.apps/skydive-analyzer-skydive-analyzer-analyzer   1/1     1            1           55m

NAME                                                                    DESIRED   CURRENT   READY   AGE
replicaset.apps/skydive-analyzer-skydive-analyzer-analyzer-54cb487d8d   1         1         1       55m
make[1]: Leaving directory '/home/aidan/projects/skydive-project/skydive/charts/skydive-analyzer'
make -C skydive-agent status
make[1]: Entering directory '/home/aidan/projects/skydive-project/skydive/charts/skydive-agent'
kubectl get all -l app=skydive-agent-skydive-agent
NAME                                          READY   STATUS    RESTARTS   AGE
pod/skydive-agent-skydive-agent-agent-mqt4v   1/1     Running   0          37m

NAME                                               DESIRED   CURRENT   READY   UP-TO-DATE   AVAILABLE   NODE SELECTOR   AGE
daemonset.apps/skydive-agent-skydive-agent-agent   1         1         1       1            1           <none>          37m
make[1]: Leaving directory '/home/aidan/projects/skydive-project/skydive/charts/skydive-agent'

run skydive-functional-tests-backend-orientdb

run skydive-functional-tests-backend-orientdb

run skydive-functional-tests-backend-orientdb

run skydive-functional-tests-backend-orientdb

@hunchback Thanks for it ! The helm charts were moved to a dedicated repository https://github.com/skydive-project/skydive-helm Do you mind posting the PR there ?

@hunchback Thanks for it ! The helm charts were moved to a dedicated repository https://github.com/skydive-project/skydive-helm Do you mind posting the PR there ?

@hunchback Thanks for it ! The helm charts were moved to a dedicated repository https://github.com/skydive-project/skydive-helm Do you mind posting the PR there ?

my proposal is that we move the charts to the main repo (archiving skydive-helm), this way I can push current skydive image (generated in the PR prior to merge) to a local registry (say on localhost:5000) on the CI and then try the full integration with helm prior to someone committing a breaking change. by using modern local k8s clusters (either kind or k3s) I can provide a test which will run fast.
and during a release of skydive we will publish our updated helms to list of helm registries (actually modern docker registries support helm)

@hunchback Thanks for it ! The helm charts were moved to a dedicated repository https://github.com/skydive-project/skydive-helm Do you mind posting the PR there ?

my proposal is that we move the charts to the main repo (archiving skydive-helm), this way I can push current skydive image (generated in the PR prior to merge) to a local registry (say on localhost:5000) on the CI and then try the full integration with helm prior to someone committing a breaking change. by using modern local k8s clusters (either kind or k3s) I can provide a test which will run fast.
and during a release of skydive we will publish our updated helms to list of helm registries (actually modern docker registries support helm)

run skydive-functional-tests-backend-elasticsearch

run skydive-functional-tests-backend-elasticsearch

run skydive-functional-tests-backend-orientdb

run skydive-functional-tests-backend-orientdb

run skydive-functional-tests-backend-elasticsearch

run skydive-functional-tests-backend-elasticsearch

run skydive-k8s-tests

run skydive-k8s-tests

run skydive-k8s-tests

run skydive-k8s-tests

run skydive-functional-tests-backend-orientdb

run skydive-functional-tests-backend-orientdb

run skydive-functional-tests-backend-elasticsearch

run skydive-functional-tests-backend-elasticsearch

run skydive-cdd-overview-tests
run skydive-functional-tests-backend-elasticsearch
run skydive-scale-tests

run skydive-functional-tests-backend-elasticsearch

run skydive-functional-tests-backend-elasticsearch


Application name is not set. Call Builder#setApplicationName.

I see this warning in the log when using Cloud SQL starter.
Filed issue: https://github.com/GoogleCloudPlatform/google-cloud-java/issues/2371

Re-filed the issue in the correct repo: https://github.com/google/google-api-java-client/issues/1062

@joaoandremartins It appears to be passed in the User-Agent header. Perhaps, we should set it to spring, or something. We might be able to get some usage metrics out of it as well.


Add condition for numbering show. Add region to styling.

Numbering show condition: add this to follow the setting of the content itself. An example is when I use bib, the template forcely shows numbering for reference page. See also: https://github.com/typst/typst/discussions/1055
Add region to support better Chinese stylings.

I have confirmed that the issue exists when showing the bibliography. I will add the bibliography to the examples. Thank you for your Pull Request!


Stable build fails

I'm unable to build on stable due to the following error:
error[E0554]: `#![feature]` may not be used on the stable release channel
   --> /home/<user>/.cargo/registry/src/github.com-1ecc6299db9ec823/thiserror-1.0.37/src/lib.rs:238:34
    |
238 | #![cfg_attr(provide_any, feature(provide_any))]
    |                                  ^^^^^^^^^^^

rustc version: rustc 1.65.0 (897e37553 2022-11-02)

cargo clean solved this for me, this also seems to be https://github.com/dtolnay/thiserror/issues/192

Thanks a lot! I thought this was a new issue with rustc 1.65 so I didn't scroll down far enough. Closing as cargo clean also fixes it for me.


Syntax highlighting for first code snippet under 'Describing the Snap' in '3. Building a snap is easy' is incorrect

In Gedit:

Thanks for opening this bug!
Yeah, there is no custom syntax hilighting yet in codelabs. This needs to be developed but takes time. Any help welcome! :)


Add support for offset and flags

I was using your library, but then I wanted to do long reads and writes and realized that the offset param and flagswere not passed though.
You need flags at least for write_cb to support prepared writes.
I did a quick hack like this
diff --git a/include/ble_utils/ble_utils.hpp b/include/ble_utils/ble_utils.hpp
index 37b5669..335fc55 100644
--- a/include/ble_utils/ble_utils.hpp
+++ b/include/ble_utils/ble_utils.hpp
@@ -62,10 +62,11 @@ public:
      * @return Number of bytes read, or in case of an error
      *          BT_GATT_ERR() with a specific BT_ATT_ERR_* error code.
      */
-    virtual ssize_t read_cb(void *buf, uint16_t len)
+    virtual ssize_t read_cb(void *buf, uint16_t len, uint16_t offset)
     {
         ARG_UNUSED(buf);
         ARG_UNUSED(len);
+        ARG_UNUSED(offset);
         return 0;
     };

@@ -78,10 +79,12 @@ public:
     *  @return Number of bytes written, or in case of an error
     *          BT_GATT_ERR() with a specific BT_ATT_ERR_* error code.
     */
-    virtual ssize_t write_cb(const void *buf,uint16_t len)
+    virtual ssize_t write_cb(const void *buf,uint16_t len, uint16_t offset, uint8_t flags)
     {
         ARG_UNUSED(buf);
         ARG_UNUSED(len);
+        ARG_UNUSED(offset);
+        ARG_UNUSED(flags);
         return 0;
     }

diff --git a/src/ble_utils.cpp b/src/ble_utils.cpp
index cba26fa..4a6eb8d 100644
--- a/src/ble_utils.cpp
+++ b/src/ble_utils.cpp
@@ -60,7 +60,7 @@ ssize_t Characteristic::_read_cb(struct bt_conn *conn,
     ARG_UNUSED(conn);
     ARG_UNUSED(offset);
     auto instance = static_cast<Characteristic *>(attr->user_data);
-    return instance->read_cb(buf, len);
+    return instance->read_cb(buf, len, offset);
 }
 ssize_t Characteristic::_write_cb(struct bt_conn *conn,
                             const struct bt_gatt_attr *attr,
@@ -70,10 +70,8 @@ ssize_t Characteristic::_write_cb(struct bt_conn *conn,
                             uint8_t flags)
 {
     ARG_UNUSED(conn);
-    ARG_UNUSED(offset);
-    ARG_UNUSED(flags);
     auto instance = static_cast<Characteristic *>(attr->user_data);
-    return instance->write_cb(buf, len);
+    return instance->write_cb(buf, len, offset, flags);
 }

 Service::Service(const bt_uuid *uuid):

and it worked, but I wonder if some of the work could be done in the base characteristic class itself instead, so I didn't attempt to make this PR worthy yet.

I think that should be the correct approach. The internal callbacks  (_write_cb, _read_cb) are passed directly to the zephyr api. So the parameters could then be passed to the user callback.
Feel free to open a PR.
Just be sure to update the sample so it still works with the new parameters and some comments regarding the new parameters which can be taken from https://github.com/zephyrproject-rtos/zephyr/blob/2765d23775146c58b91c5602664308f777fb0346/include/zephyr/bluetooth/gatt.h#L145

solved in #1


KeyError in yield_plot and occupancy

I think there may be a problem with these options for fail reads.  I get KeyError: 'template'  when I attempt these options for fail reads (MAP007,  minKnow version <IP_ADDRESS>, poretools version 0.5.1)  I get the following error.  I do not get this error for pass reads
Command:   poretools_main.py  yield_plot CNV_022516/reads/downloads/fail/
Error:
File "/seq/sara/poretools-master/poretools/poretools_main.py", line 519, in
main()
File "/seq/sara/poretools-master/poretools/poretools_main.py", line 513, in main
args.func(parser, args)
File "/seq/sara/poretools-master/poretools/poretools_main.py", line 53, in run_subtool
submodule.run(parser, args)
File "/isilon/seq/sara/poretools-master/poretools/yield_plot.py", line 72, in run
start_time = fast5.get_start_time()
File "/isilon/seq/sara/poretools-master/poretools/Fast5File.py", line 469, in get_start_time
node = self.find_event_timing_block()
File "/isilon/seq/sara/poretools-master/poretools/Fast5File.py", line 439, in find_event_timing_block
path = fastq_paths[self.version]['template'] % (self.group)
KeyError: 'template'
Thank for your help

Yep we have seen this as well. I will look into a fix asap

I've noticed this as well. It's because some of the failed files do not have any template data. A simple try, except should work in this regard. I'm working on a couple of scripts that split failed reads into folders explaining why they failed.

I too am having this problem using poretools 0.6.0

Im using poretools 0.6.0 in a MacOs sierra 10.12.1 and having the same issue when files do not have template data.


support json.dumps

SharedMemoryDict cannot be serialized by json.dumps.
I have to use  ._read_memory() to do so.
It seems strange.
Maybe we should add a .dict() method to convert it to ordinary dict?

This would be solved by https://github.com/luizalabs/shared-memory-dict/pull/42 which allows giving a JSONEncoder subclass.
A example usage is something like this: https://github.com/spaceone/shared-memory-dict/blob/json-nested-dictionary-serializer/shared_memory_dict/nested_json_serializer.py#L15-L32


Updated platform support statement

The platforms included in the commit include RackSpace now as an
OpenStack supported driver.

Coverage remained the same at 91.846% when pulling 54d92f03e81790eed611b5c1345787584841139c on clintonskitson:feature/docs_readme_platforms into 509b5bebd5b99175e9f51b4248886c56bb5ac3c3 on emccode:master.


create a Device object need a not None attribute "device_profile_id"

When I want to use rest_client.save_device() method to register a new device, I need to new a Device object. But the init method need a attribute "device_profile_id". What should I provide?

Hi @AWSDJIKL ,
You should use device profile id that you want to use with this device (Device profile name is equal to your device type).

@AWSDJIKL, any updates? Can we close the issue?


resolve: load statements now create local bindings

Previously, load statements created global bindings.
As an often-unwanted consequence, names loaded by one module
would leak into its module dictionary and be visible to others.
This change to the resolver makes load define file-local variables
using a similar approach to Go: a new lexical block (the file block)
between function/comprehension blocks and the globals.
The set of names in the file block and the globals must be disjoint.
This incompatible change is guarded by the LoadBindsGlobally flag,
which is false by default. Users who want the old behavior may set
it to true, but they should prepare for it to go away entirely.
After that point, the old behavior may be simulated thus:
- load("...", "x")
+ load("...", _x="x"); x = _x # re-export

@laurentlb -- this is the Go implementation of https://github.com/bazelbuild/starlark/issues/37

Thank you


VScode dosen't show ESP hardware

Issue Type: Bug
Newbie trys to setup VS code to support ESP's in arduinos IDE. VSc doesn't find the #include <ESP8266WiFiMulti.h>  file and no ESP hardware can be selected just AVR's.
setting.jsons contain: "arduino.additionalUrls":  "http://arduino.esp8266.com/stable/package_esp8266com_index.json",
What is wrong, what is missig in my settings?
Thank-you
VS Code version: Code 1.22.2 (3aeede733d9a3098f7b4bdc1f66b63b0f48c1ef9, 2018-04-12T16:38:45.278Z)
OS version: Windows_NT x64 10.0.16299

System Info

Item
Value

CPUs
Intel(R) Core(TM) i5-7260U CPU @ 2.20GHz (4 x 2208)

Memory (System)
7.89GB (4.06GB free)

Process Argv
C:\Program Files\Microsoft VS Code\Code.exe

Screen Reader
no

VM
0%

Extensions (2)

Extension
Author (truncated)
Version

cpptools
ms-
0.16.1

vscode-arduino
vsc
0.2.12

Reading your description it seems that the issue originates from an extension and not VS Code itself. Thereby I will close this issue and kindly ask you to report this issue against the extension repository.
Most extensions are on GitHub as well so it should be easy to file it against the extension. If you open an extension on the market place, click on the Support link to find out more.

Thanks again for your feedback!


Makefile build does not create contrib ops

System information

OS Platform and Distribution: MacOS
TensorFlow installed from (source or binary): Source
TensorFlow version: c6352706d6280d7ed34964969503b104471a9335
Bazel version (if compiling from source): not used
GCC/Compiler version (if compiling from source):

Configured with: --prefix=/Applications/Xcode.app/Contents/Developer/usr --with-gxx-include-dir=/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.14.sdk/usr/include/c++/4.2.1
Apple LLVM version 10.0.1 (clang-1<IP_ADDRESS>)
Target: x86_64-apple-darwin18.6.0
Thread model: posix
InstalledDir: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin

Describe the problem
When compiling with tensorflow/contrib/makefile/build_all_linux.sh, the following inclusion does not work:
#include <tensorflow/cc/ops/standard_ops.h>

because the header #includes something that's not there:
<tfdir>/tensorflow/tensorflow/cc/ops/standard_ops.h:19:10: fatal error: 'tensorflow/cc/ops/array_ops.h' file not found
#include "tensorflow/cc/ops/array_ops.h"
         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.

Searching for array_ops in the repository e.g. reveals a CMake macro named GENERATE_CONTRIB_OP_LIBRARY defined in in tensorflow/contrib/cmake/tf_core_ops.cmake.
https://github.com/tensorflow/tensorflow/blob/6c7c3bb0f3563e8a147935597617cf3d052c7852/tensorflow/contrib/cmake/tf_core_ops.cmake#L76
Obviously, the Makefile does not use this. Is it intentional that these ops are not being built with the makefile? Even if I remove the header, a program does not work at runtime due to missing ops.
I can provide a minimal C++ file and build scripts if desired, but would like to know first if it's supposed to be like this.

The same problem occurs with the CMake build (which I have fixed many problems in, but running into this as well).

May I know the reason why you don't use bazel?

Because it's generally a pain to install the correct version, and none of my knowledge transfers to it. I find it lamentable that such an important project does not have a build process which works easily on all systems.

Hi, this issue seems not to be Intel specific, but about compiling of TF. I would suggest other experts to share ideas.

This came now to my eyes.
Two things: makefile build is no longer supported (since at least months ago). Also, recently we removed contrib as it won't be available in 2.0.
I think it would be best to try using Bazel. ./configure.py has the versioning information at the top:
https://github.com/tensorflow/tensorflow/blob/250a5d47828aa229857266d59b32314bda79bcb3/configure.py#L52-L53
Once you start using it, makefile knowledge will transfer in time. I'm saying this from experience, I was using makefile's everywhere but then I switch to Bazel for TF and I like this model slightly better for extremely large cross-platform codebases.

@themightyoarfish Is this still an issue? Please close the issue if this was resolved already. Thanks!

I have no idea to be honest, i have not touched Tensorflow since raising this issue. I suppose it can be closed for now.


Remove config model confused log info, and fix some bugs in bootstrap

What this PR does / why we need it:
Remove config model confused log info, and fix some bugs in bootstrap
Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #
#256
Special notes for your reviewer:
Release note:

Coverage decreased (-0.008%) to 60.25% when pulling b425b7f4dd5c51a888a510ea3e6b841af7301b1d on xxwjj:bugs into 57bd0c33e406a547df5b2eba1bd4594b3c84d7a8 on opensds:development.


Create implementation WITHOUT any package references, NFX v5 should be inlined in /lib/nfx subfolder

done


Reference an enum in a imported package

Describe the bug
A clear and concise description of what the bug is.
What's the correct way to refer to an enum in a imported package?
Ex.
pub type Format enum {
  Raw,
  PNG,
  JPEG
}

import ( image )
...
image::Format::PNG -> image:fmt  // causes panic
...

invalid memory address or nil pointer dereference: goroutine 1 [running]:
runtime/debug.Stack()
        /usr/local/go/src/runtime/debug/stack.go:24 +0x5e
github.com/nevalang/neva/internal/compiler/parser.Parser.parseFile.func1()
        /home/$USER/src/github.com/Catya3/neva/internal/compiler/parser/parser.go:112 +0xe5
panic({0xad8900?, 0x11d7bd0?})
        /usr/local/go/src/runtime/panic.go:914 +0x21f
github.com/nevalang/neva/internal/compiler/parser.parseNormConn({0xcd9708, 0xc0004a7600}, {{0xc0001c4a60, 0xf}, {0xf, 0x7}, {0xf, 0x14}})
        /home/$USER/src/github.com/Catya3/neva/internal/compiler/parser/net.go:133 +0x576

Neither other obvious way to qualify the enum works (image.Format::, or image.Format.)
To Reproduce
Steps to reproduce the behavior:

Make an enum in stdlib for instance, or another package
Import the package
Try to qualify  the enum alternative

Expected behavior
There is a way to use enums in another package.

Sorry for that. Will fix

import { x }

component Main(start) (stop) {
    nodes { Println }
    net { :start -> (x.Format::Png -> println) }
}

This is my code and this is what I got
tmp/main.neva:5:21 can't get type def from scope by ref: entity not found: 'Format'

I mean it's not panic. But errors must be fixed tho

@Catya3 couldn't repro, here's my code, output is 0
import { x }

component Main(start) (stop) {
    nodes { Println }
    net { :start -> (x.Format::Raw -> println -> :stop) }
}

I've defined Format in x like this
pub type Format enum {
  Raw,
  PNG,
  JPEG
}

However I've found another issue #562
Also please note that now you have to rm -rf ~/neva after any change in std (so compiler can write new std to disk, it won't do that if there's std already). I'm thinking about how to optimize this DX right now.

Confirmed the issue was due to unclean Neva std directory. My bad!

Done!


Feature/bidding improvements

Added the auctioneer

Model and textures
Animations
Audio/voice
Behaviour triggered by bidding events

Added new auction hall

Model and textures
New animations for items
New camera angles

Added new prefab for bidding players

Holds a sign with chip amount
Waves sign when bidding

Auctions updated

Weighted auctions #204
Auctions are now: 1: Bodies only, 2: Barrels only, 3: Extensions only, 4++: the usual (1 body, 1 barrel, 1 extension)

What will NOT be implemented in this PR (it's already way, WAY larger than it ever should have been), and rather be done in separate issues:

Proper "non-debug mode" weapon presentation by the auctioneer

Saloon gates are opened as camera flies through
Curtains start closed and are pulled to the side on entry
Auctioneer greeting the player, saying which augment type is for sale, and then throwing items to podiums

Bidding platforms should get a visual overhaul where they are colored way more after leading bid player than now
Curtains should use "fancy" materials to fake their curled depth
Music in weapon presentations can be the old bidding and fade into the new when presentation is over

This feature is postponed due to the merge conflicts it would cause at the moment

Very nice new bidding scene! Love the little touch of sand at the corner. This is definitely an improvement!

Very nice new bidding scene! Love the little touch of sand at the corner. This is definitely an improvement!

Huh, I didn't parse that as sand 😅
Thought it was light shining in


get rid of error from AT+CMGF=1

When calling init() the first time the AT+CMGF=1 command always returns an ERROR. The second attempt is working. I'm using SIM800L.
1 Does anyone else experience this?
2 It seems like this command works only after the module put these lines on the serial:
+CPIN: READY
Call Ready
SMS Ready
So I thought of waiting for "SMS Ready" to arrive before issuing the AT+CMGF=1 command. As the manual does not say anything about "SMS Ready", I'm not sure if this is reliable. What do you think?
Edit: I just tried using AT+CFUN?, but this does not work since this command always returns 1 after setting AT+CFUN=1.

Just a reminder for myself:
Try running AT+CMGF=1 in a loop until it's successful.


When T2GPA = 1, report true ATS translation even for MSI pages in MRIF mode

Section 2.6, "PCIe ATS translation request handling", says

If the translation request has an address determined to be an MSI address using the rules defined by the Section <IP_ADDRESS> but the MSI PTE is configured in MRIF mode then a Success response is generated with R, W, and U bit set to 1.

An "Untranslated access only" response (U = 1) is necessary only when the the device context has T2GPA = 0.  When T2GPA = 1, a translation can be returned with the GPA address, if first-stage translation succeeds and execute permission wasn't requested (not allowed for MSI pages).

if first-stage translation succeeds and execute permission wasn't requested (not allowed for MSI pages).

... and the MSI PTE is valid, not misconfigured, etc.

We debated this case previously and had decided to not specially treat this case special since in MRIF mode besides translation there is an update to the MRIF. One implementation option for MRIF was for the MRIF update to be performed by the IOMMU itself similar to how it may perform A and/or D bit updates. For such an implementation treating Translation Requests with T2GPA enable would require it to have a mode to do the MRIF PTE update conditionally. The U=1 response has similar behavior as providing a translation to a GPA.

For such an implementation treating Translation Requests with T2GPA enable would require it to have a mode to do the MRIF update conditionally.

You mean, one extra bit of information to be communicated to the IOMMU for suppressing the MRIF updates?  That seems pretty trivial to me.  Besides an extra flip-flop or two, is it even 10 extra logic gates?

The R=W=U=1 response has similar behavior as providing a translation to a GPA. The device is allowed to cache such translations. So supporting this mode has no additional benefits.

You say there are no benefits, but I see two potential ones.
First, you've reported before that the PCI SIG may remove from the PCIe standard responses with U = 1.  How will a response with U = 1 be an adequate way to handle this case if such responses aren't permitted in the future?
Second, when a DC has T2GPA = 1, inbound memory transactions that are "translated" require at most a single stage of page-table lookups, whereas "untranslated" ones obviously can require many more page-table lookups for the two-stage address translation.  It's true that some of those lookups may be cached, but that depends on the IOMMU implementation, and may put more pressure on the IOMMU's ATC.  Probabilistically, it's more likely that inbound untranslated MSIs will on average be more costly time-wise than inbound translated MSIs.
As I see it, the costs of implementing the "suppress MRIF update" mode are smaller than these potential benefits.  So FWIW, I'm not convinced the TG is making the best decision here.

On the other hand, I'd easily reverse my position if we could confirm that it's rare, bordering on nonexistent, for real PCIe devices to request translations for MSI addresses.
(To hedge our bets, part of me wants the RISC-V IOMMU spec to allow either kind of response to such ATS requests.  But I suppose the downside would then be the extra work this creates for testing.)

ATS is typically employed by high performance devices. It is typically
expected that such devices used with low end IOMMU will lead to suboptimal
results. Further, MSI/MSI-X capabilities do not have a associated PASID
configuartion. They are not virtual addresses.
MSI PTEs in MRIF mode impose significant additional burden on IOMMU ATC as it
requires significant additional storage. It is unlikely an implementation
will design IOMMU ATC to cache MRIF mode translations. This is also the
recommendation from the AIA specification to not attempt to do that. For high
performance usages the MRIF is likely going to be used transiently during for
example vCPU migration. A guest that has been parked is likely not programming
devices to generate active IO. There might be some outstanding requests or an
incoming request that the guest needs to wake up from MRIF mode to handle but
there is a significant overhead associated with this transition as well for
the hypervisor to be interrupted, reload the MRIF to a physical interrupt
file, update MSI PTEs, perform IOTLB invalidations. The MRIFs are expected to
be used for idle or nearly idle virtual harts and the consequence of a
interrupt landing in a MRIF is to cause that MRIF to be loaded into a physical
interrupt file.  So likely the MSIs handled in MRIF moded are few before the
PTE transitions out of MRIF mode.
T2GPA support needs a well engineered IOMMU. Using T2GPA will negate the benefits
of ATS completely if the IOMMU implementation is not designed to be optimal.
MSI are a small number of transactions and T2GPA is not specific to MSI
transactions but applicable to all transactions that such devices originate.
Without a well engineered IOMMU, there will be significant bandwidth
overheads and latency overheads when T2GPA is used. For example, a 512B DMA
read which may be a typical transfer size a root complex supports when used
in T2GPA mode mode may result in a 4 level G-stage walk. In a typical system
with 64 byte cache lines that walk leads to 256 bytes of memory reads by the
IOMMU to complete a 512B read - a huge bandwidth overhead and even bigger increase
in latency. So it is unlikely that an IOMMU that desires to provide high
performance will support T2GPA but not be engineered to do that. MSI follow
the same as they are just a fraction of the transactions.
I do not want to speculate on what changes may happen downstream to
specifications that we do not control. We will need to reach to that when
that happens. Trying to engineer for something that may happen in future is
not a good idea because at least I dont have a crystal ball that good.
However, usually specifications do not change in a manner that in one fell
swoop removes compatibility with millions of deployed devices and hosts.


perf(Response): Optimize response body processing

Please review carefully before merging. This is a significant change to the way the framework processes the response body.

Remove overhead from response body processing in API and Response.
BREAKING CHANGE: Response.body_encoded has been removed. The property was only intended to be used by the framework itself, so there should not be many apps using it.
To migrate the code, follow the example below:
Before:
    body = resp.body_encoded

After:
    if resp.body:
        body = resp.body.encode('utf-8')
    else:
        body = b''

LGTM

@painterjd Nice catch! In fact, I can just return the value of resp.stream_len directly.

I amended the commit, let me know what you think.

:+1:


Unknown option watch

hey,
if I try to make caddy watch on changes in the directory with
hugo {
    watch
}

caddy tells me
Unknown option watch
I am aware that changes via the gui trigger a rebuild but what about local changes during development?
I would like to use this as a replacement for hugo serve with all the caddy-awsomeness.
Am I doing something wrong or is caddy-hugo simply not meant to be used for this?

Sorry!!!! I've updated the syntax in the last version but the docs weren't updated. Try flag watch.
Pinging @mholt

Ok, that worked. Hot reloading seems to be a whole different topic so I might still have to rely on 'hugo serve' for some time.

Yup. Glad it worked :smiley:

Sorry, docs will be updated before too long. :sweat:


Dependency resolution warning on build

When using Microsoft.AspNetCore.Authorization in .NET 8 the following warnings are logged.
14>Microsoft.Common.CurrentVersion.targets(2401,5): Warning MSB3245 : Could not resolve this reference. Could not locate the assembly "Microsoft.AspNetCore.Authentication". Check to make sure the assembly exists on disk. If this reference is required by your code, you may get compilation errors.
14>Microsoft.Common.CurrentVersion.targets(2401,5): Warning MSB3243 : No way to resolve conflict between "Microsoft.AspNetCore.Authentication, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=adb9793829ddae60" and "Microsoft.AspNetCore.Authentication". Choosing "Microsoft.AspNetCore.Authentication, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=adb9793829ddae60" arbitrarily.

Is there any way to resolve this?

any chance you can provide a minimal repro? i'm not able to so far. also fwiw, the error is calling out Microsoft.AspNetCore.Authentication not Microsoft.AspNetCore.Authorization

That's because Microsoft.AspNetCore.Authentication 2.2.0 was deprecated when ASP.Net Core 3.0 released.
In my haste I incorrectly assumed Microsoft had replaced it with Microsoft.AspNetCore.Authorization.
See the deprecation notices and details:

https://www.nuget.org/packages/Microsoft.AspNetCore.Authentication
https://github.com/dotnet/announcements/issues/217
https://github.com/dotnet/core/blob/main/release-notes/net-package-deprecation.md

My .NET 8 project is using Microsoft.AspNetCore.Authentication.JwtBearer 8.0.7 for authentication.
It looks like Microsoft.AspNetCore.Authentication, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=adb9793829ddae60 is "built-in" to .NET 8 "Microsoft.AspNetCore.App" reference (found in C:\Program Files\dotnet\packs\Microsoft.AspNetCore.App.Ref\8.0.7\ref\net8.0\Microsoft.AspNetCore.Authentication.dll on my system)
HeimGuard is a great package and I'd hate to see it get left behind when MS inevitably updates this built-in assembly to no longer be compatible with 2.2.0.

Not sure exactly what you mean by getting left behind? This should just be because heimguard uses 8.0.0 directly and I can just do a release to bump it

I think this warning stems from your .NET 8 build referencing Microsoft.AspNetCore.Authorization.Policy 2.2.0 which is also deprecated and references Microsoft.AspNetCore.Authorization 2.2.0 itself.
Microsoft.AspNetCore.Authorization 2.2.0 references Microsoft.AspNetCore.Authentication.Abstractions 2.2.0 and I think this is where the namespace reference to Microsoft.AspNetCore.Authentication is coming from that's causing the warning.
As a side note, Microsoft.AspNetCore.Http 2.2.2 is also deprecated.

Ah, yeah I see, good call. I'll take a look! Open to a PR if you can beat me to it

just pushed a patch with all the packages bumped and i just flat our removed the dated dependency -- honestly must have snuck in from dev as it literally wasn't used anywhere. thanks for the callout!
let me know if you have any issues


Lyrics not working for Single Song plays

Version
Description
while audio list changes lyrics doesnt change
Steps
herre are my audio lists
`const audioList1 = [{
key:1,
name:'Linkin Park - In The End from audio list 1',
singer:"Linkin Park",
cover:DummyImage,
lyric:'[00:05.00]linkin park from audiolist 1',
musicSrc:'https://songs-nepal-api-prod.s3.amazonaws.com/uploads/songs/song_files/2020/08/Coldplay_-Paradise__Official_Video.mp3',
},]
const audioList2 = [{
key:2,
name:'Linkin Park - In The End from audio list 2',
singer:"Linkin Park",
cover:DummyImage,
lyric:'[00:03.00] from audio list 2',
musicSrc:'https://songs-nepal-api-prod.s3.amazonaws.com/uploads/songs/song_files/2020/08/Coldplay_-Paradise__Official_Video.mp3',
},]
const [testAudioList,setTestAudioList] = useState(audioList1) // current state for audio list
const changeDemoAudioList = ()=>{  //function to change audio list
setTestAudioList(audioList2)
}
export default {
defaultPlayIndex: 0,
theme: 'light',
bounds: 'body',
quietUpdate: false,
clearPriorAudioLists: true,
autoPlayInitLoadPlayList: true,
preload: true,
glassBg: false,
remember: false,
remove: true,
defaultPosition: {
right: 100,
bottom: 120,
},
mode: 'full',
once: false,
autoPlay: true,
toggleMode: true,
showMiniModeCover: true,
showMiniProcessBar: false,
drag: true,
seeked: true,
showMediaSession: true,
showProgressLoadBar: true,
showPlay: true,
showReload: true,
showDownload: false,
showPlayMode: true,
showThemeSwitch: false,
showLyric: true,
showDestroy: false,
extendsContent: null,
defaultVolume: 1,
playModeShowTime: 600,
loadAudioErrorPlayNext: true,
autoHiddenCover: false,
spaceBar: true,
responsive: true,
getContainer() {
return document.body
},
onBeforeDestroy(currentPlayId, audioLists, audioInfo) {
return new Promise((resolve, reject) => {
if (window.confirm('Are you confirm destroy the player?')) {
resolve()
} else {
reject()
}
})
},
onDestroyed(currentPlayId, audioLists, audioInfo) {
},
onCoverClick(mode, audioLists, audioInfo) {
},
// button that changes audiolist//
<button onClick={changeDemoAudioList} style={{zIndex:"99999",position:"relative"}}>test audio change
<ReactJinkeMusicPlayer
audioLists={testAudioList}
{...options}
onAudioListsChange={onAudioListsChange}
/>

### Reproduce Link

### Steps to Reproduce

### Expected Behavior
while audiolist changes song lyrics should change according to the song

### Current Behavior
while playing single songs the lyrics of the current song is shown while audiolist chages everything except the lyric doesnt change(clear priority queue is set true )
This wont occurr when the songs are in bulk (more than one) or when (clear priority queue is set false)

Please provide me a suggestion .. thank you
<!-- browner console log -->

### System information
![image](https://user-images.githubusercontent.com/49373020/103607604-6e7bae80-4f41-11eb-8406-ae2999210046.png)
![image](https://user-images.githubusercontent.com/49373020/103607642-87845f80-4f41-11eb-8f11-4ae0305d1a08.png)

### Comments

Can you give a reproduce link ?

Can you give a reproduce link ?

Can you give a reproduce link ?

Dear Sir/Mam , i have updated my issue.. kindly please provide me a suggeestion .. Thank you :)

Can you give a reproduce link ?

Dear Sir/Mam , i have updated my issue.. kindly please provide me a suggeestion .. Thank you :)


bug(dmt): we get a nginx bad gateway error after running reset dmt script. (see issue notes fro solution)

To fix, expose ports for the dmss service in docker-compose.yml. Use
ports:
- "8000:5000"

outdated


Device Tracking

WIP
This PR addresses location and battery being sent back to HA.
#8 and #53
Things remaining:

[ ] Validation on older android models
[ ] Unit Tests

Are you planning to add geofencing for the zones defined in HA too instead of just continuous location updates?

+1 for geofencing as an option

Geofencing should work based on the zones already set in homeassistant I believe. The app just needs to report the position.
Unless your referring to editing and creating zones, in witch case I believe it's a different feature.

@Knoxie I think the Geofencing they are referencing this (https://developers.google.com/location-context/geofencing).  I hope to keep this PR small and expand on it in the future.  At some point I plan to add geofencing based on zones.  Need more hours in the day!

I think duplication of zones in app for Android specific and then zones
already in Hass is a confusing implementation. But I think that's a design
choice for higher powers.
On Tue, Nov 26, 2019, 7:08 AM Justin Bassett<EMAIL_ADDRESS>wrote:

@Knoxie https://github.com/Knoxie I think the Geofencing they are
referencing this (
https://developers.google.com/location-context/geofencing). I hope to
keep this PR small and expand on it in the future. At some point I plan to
add geofencing based on zones. Need more hours in the day!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/home-assistant/home-assistant-android/pull/74?email_source=notifications&email_token=AAICE7EQPCXJBT3DEV5WUZTQVUGSLA5CNFSM4JRTSWL2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFFZABQ#issuecomment-558600198,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAICE7AZJTUMM2NG3JOA4X3QVUGSLANCNFSM4JRTSWLQ
.

I don't think we would ever implement any custom zones in app.  We would only ever consume the zones that are setup in HA and add geofences around them to get faster updates when the fence is broken.

@JBassett is correct. You shouldn’t be able to define custom zones in the app. The app should only consume existing zones. This is the same behavior as iOS.

Yes, basically just fetch zones from HA, set up geofences, submit location to HA on geofence broadcast.

I know I'm missing tests on LocationBroadcastReceiver.  I ran into a lot of trouble unit testing it because of how differently it was behaving when testing.  For example when the Intent is create it isn't valid and causes exceptions to be thrown.

In a product point of view, this feature will drain the battery of the user.
I think the good way to go is what @quthla say (fetch HA zone and register geofences on that zone).
BTW if we go on that solution, we should probably add a switch in the settings to turn this feature on/off (and do no rely on the permissions granted).

I agree that the zones are needed.  However I think we should have more than just a toggle.  I would say 3 settings, off, zone only, zone + background.  This was just too get the foundations of that.  The whole point of using the fused client is to preserve the battery.  It will batch the requests, and only give us a location when the phone already has a new location and is awoken.  I've been running this on my phone since I started working on this and it doesn't even register on the battery stats.  As far as the UI for the settings I wasn't sure what kind of style we wanted to go with and thought it would really make this PR huge.  The next PR I planned to work on was the zone based.

@JBassett what you see suggesting is the ideal setup in my opinion.
One thought to consider if you want to make a simple solution is make the device tracking, and "trigger" allow/disallow location of the app.
(The setting in Android -  apps - location permission)

Can the "battery monitor" be not related to the gps location? For gps I mean the gps module on the devices.
I already noted this in issue https://github.com/home-assistant/home-assistant-android/issues/53 . Tablets that do not have the gps module (amazon fire hd 7) have a bad time sending the location with the battery status in it - meaning that it does not work.
I've been using GPSLogger for a while on my phone and battery tracking is great. On the Fire hd 7 it doesn't work.
I'm so thankful this issue is being processed, I just wish it won't just be a "clone" of GPSLogger
Thanks guys.

I was wondering if the app could detect the HA server on the same network?
This way you could pause location tracking when the app could 'see' the HA server when you were definitely home.

@Nihvel The reason the battery is included with location is because it's how the integration on home assistant is setup.  We can add a completely separate sensor for battery only tracking, but it's outside of the scope of this PR I think.  I would create a new issue/feature request for this.
@selinium If you would like that feature I would say to add that as another issue/feature request.

I like the idea of the three options. That way it's up to the user to balance accuracy vs battery impact.

@balloob I would rather do those changes incrementally rather than in one giant PR, but if you want I can add them all here.

Oh yes small PRs all around please. I was mainly agreeing with the idea, not pushing to have it in 1 PR .

Device tracking and data seems to be working properly 🙏
I don't know if I was too inpatient (and went in manually and activated) but there was no pop-up asking for permission to track location. (update from v27➡v28

No pop - up for me as well. Also the device was added twice. I'm apologizing if this isn't the place to share this.
I'm sure these will be sorted out as time goes by.
Thanks for the awesome work!

Because we don't have a UI for this yet we don't prompt for permission except on initial onboarding.  If you give permission to location at all times and force close the app and restart it, you should start getting updates.


Add argument count mismatch diagnostic

Closes https://github.com/rust-analyzer/rust-analyzer/issues/4025.
This currently has one false positive on this line, where max is resolved to Iterator::max instead of Ord::max:
https://github.com/rust-analyzer/rust-analyzer/blob/8aa10c00a4c5b957d459fac5a103cd9688e8dcdd/crates/expect/src/lib.rs#L263
(I have no idea why it thinks that usize is an Iterator)
TODO:

[ ] Tests
[ ] Improve diagnostic text for method calls

This currently has one false positive on this line, where max is resolved to Iterator::max instead of Ord::max:

goto def goes to Ord though

(I have no idea why it thinks that usize is an Iterator)

Without having looked into it, I'll guess:

at that point it's an integer variable
resolving the Ord impl may require some of the missing integer variable handling
for the method to be resolved, we don't need to positively prove that the type implements Iterator, but just be unable to prove that it doesn't. With the many impls that exist for Iterator, that can often happen.

As for the PR, I wonder whether the diagnostic should just be produced during inference, but I think it's fine to have it separate for now as well.

@flodiebold Ah, okay, that's surprising. I thought that methods only get resolved in r-a when the obligation is actually proven. Kind of makes sense for an IDE though.

@jonas-schievink it's how rustc works as well, as far as I understand -- method selection just checks whether the obligation may hold (i.e. it's at least ambiguous). At the time of method selection, there's often not enough information to conclusively decide whether the obligation holds.

Hmm, yeah, that's true. rustc will prove the obligation and report an error if it doesn't hold though. Is there any way I can tell that this happened in r-a?

We currently don't keep track of which obligations failed (that would happen here), and even if we did, we'd also need to keep track of where the obligation came from to connect this back to the method.
I wonder whether the false positive is acceptable here in a sense though, because this situation also means that goto def will go to the wrong function, and the return value will potentially be wrong, so we're already noticeably wrong anyway... Or if we're worried about false positives, we could just do the diagnostic for non-trait methods and function calls, which should be less likely to be wrong. But I am in favour of starting to have more diagnostics based on inference. I think it'd be great to have an option for more experimental, more-likely-to-be-false-positive diagnostics.

bors r+


ENH: Add RMS framewise displacement following Jenkinson et al. (2002)

Changes proposed in this pull request

This is a step toward resolving #1970 .

Rather than using fsl_motion_outliers, we directly use mcflirt to estimate the root mean square displacement. We keep the Power FD computed as before. This is more efficient, results in a cleaner workflow, and allows us to use the same reference that we use for computing the realignment parameters.
The column is called rmsd following the BIDS derivatives specification.

Future work should consider adding the option to flag outliers on the basis of RMS (Jenkinson) FD.

Documentation that should be reviewed

Brief descriptions have been added to the confounds documentation and to the boilerplate.

@mgxd anything jumping out into your eye?


chore: renovate lmdb-rs for bazelization

This change updates the library to simplify migrating the build to Bazel:

Do not generate code to source tree in the build script, use OUT_DIR
instead.

If LMDB_H_PATH env variable is defined, use it find lmdb.h header
for bindgen.

If LMDB_NO_BUILD env variable is defined, do not try to build
liblmdb.a. We can fetch and build liblmdb.a with Bazel.

Fix deprecation warnings (e.g., Error::description) and replace obsolete crates
(tempdir -> tempfile).

@ninegua could you please take a look?

Fix deprecation warnings (e.g., Error::description) and replace obsolete crates (tempdir -> tempfile).

Not sure if it has been fixed upstream. Have you tried merge upstream first?


Updated 'web' package to the stable one.

@incrediblezayed  , please merge this

@incrediblezayed  , please merge this   🙏🏻

Hey guys I'm sorry but there is still some issue with WASM, I'll check the PR and do it asap


Kotlin | Configurable Android device

TestRunner.kt#L54-L59
val androidMatrix = GcAndroidMatrix.build(
         "NexusLowRes",
         "26",
         "en",
         "portrait")

Users should be able to specify the device to use in the Yaml Config.
requires: https://github.com/TestArmada/flank/issues/187
the format should follow the gcloud CLI style for device specification
--device=DIMENSION=VALUE,[…]
https://cloud.google.com/sdk/gcloud/reference/firebase/test/android/run
# gcloud cli example
 --device model=NexusLowRes,orientation=landscape
 --device model=shamu,version=21,locale=fr

# yaml example
devices:
  - shamu:
      version: 21
      locale: fr

We can support this using a Yaml list of objects.
Will need to provide the same info as the --device option on the gcloud CLI
https://cloud.google.com/sdk/gcloud/reference/firebase/test/android/run
Both of these syntaxes should work:
devices:
  - { model: Nexus6 }
  - { version: 23, orientation: landscape }
  - { model: shamu, version: 22, locale: zh_CN, orientation: default }

devices:
  - model: Nexus6
  - version: 23
    orientation: landscape
  - model: shamu
    version: 22
    locale: zh_CN
    orientation: default

Fixed in https://github.com/TestArmada/flank/pull/214


[bug] Aeotec Z-Stick Gen5+ has no configuration options

Version
Build/Run method

[X] Docker
[ ] PKG
[ ] Manually built (git clone - npm install - npm run build )

zwavejs2mqtt version: I'm not sure how to get this. I'm using zwavejs/zwavejs2mqtt:dev pulled on 12th Dec
Describe the bug
Newest Aeotec Z-Stick Gen5+ (https://aeotec.com/z-wave-usb-stick/) has no configuration options at zwavejs2mqtt GUI

While they are available using OpenZwave stack:

Device information
Which device(s) is/are affected?  Aeotec Z-Stick Gen5+
What are the node IDs? 1
Logfile:
Despite I have selected "Log Level=Debug and Log to file is enabled, I'm not able to find the log file but I attach .json, .values.jsonl files: json_files.zip
Expected behavior
Device information/settins are expected to be shown into zwavejs2mqtt GUI both for information sake and for tunning it too.

This is basically https://github.com/zwave-js/node-zwave-js/issues/1032
zwave-js does not perform a normal interview for the Controller node (mainly because I didn't know there are any devices where this would be necessary back then).
@katiuskt could you provide a log from OZW where you refresh that node's info? I would like to see how OZW communicates with it.

@katiuskt could you provide a log from OZW where you refresh that node's info? I would like to see how OZW communicates with it.

Please, find it attached (or at least, I think so... I'm afraid no expert here):
refresh_node1_info_from_ozw.log

@katiuskt Are you using openzwave?


fix: Revised non-standard crossbow bolt ranged strength bonus

Per discussion in discord sources channel (username is teagan) revised non-standard crossbow bolts to give a +18/+9 each tier /half-tier, as there is some indirect evidence that this schema pre-dates the crossbow rework in 2006. Consolidated comments to one longer comment, which explains the change.

https://github.com/user-attachments/assets/3a9bb610-ceee-4baa-b4d4-a0618180a42e


DSD-845: Hooks Storybook documentation & more exposed design tokens

Fixes JIRA ticket DSD-845 and DSD-722
This PR does the following:

Adds Storybook documentation pages for the useCarouselStyles, useNYPLTheme, and useWindowSize custom hooks.
Exports the useCarouselStyles and useWindowSize hooks.
Moves useNYPLTheme documentation  from the "Chakra UI" page to its own page.
Then worked on DSD-722 to include new typography design tokens into the useNYPLTheme hook and its returned style object.

How has this been tested?
Storybook, including testing the new fontSizes and fontWeights design tokens in Charka components and HTML elements.
Accessibility concerns or updates

N/A

Checklist:

[ ] I have updated the Storybook documentation accordingly.
[ ] I have added relevant accessibility documentation for this pull request.
[ ] All new and existing tests passed.

Front End Review:

[ ] View the example in Storybook

Tugboat has finished building the preview for this pull request!
Link:

https://pr931-3od93hyodw8qs9q2l0dybamfmejo87qn.tugboat.qa

Dashboard:

https://dashboard.tugboat.qa/62472fb3b1a46a5aa1c461fd

Tugboat has finished building the preview for this pull request!
Link:

https://pr931-3od93hyodw8qs9q2l0dybamfmejo87qn.tugboat.qa

Dashboard:

https://dashboard.tugboat.qa/62472fb3b1a46a5aa1c461fd

Tugboat has finished building the preview for this pull request!
Link:

https://pr931-3od93hyodw8qs9q2l0dybamfmejo87qn.tugboat.qa

Dashboard:

https://dashboard.tugboat.qa/62472fb3b1a46a5aa1c461fd

Tugboat has finished building the preview for this pull request!
Link:

https://pr931-3od93hyodw8qs9q2l0dybamfmejo87qn.tugboat.qa

Dashboard:

https://dashboard.tugboat.qa/62472fb3b1a46a5aa1c461fd


feat(select): support disabling

This PR adds support for disabling the select and its options.  Needs to be rebased once #1657 and #1655 go in.
r: @jelbourn

@jelbourn Comments addressed!

LGTM


test: refactor and fix tests

This PR makes some more minor adjustments to avoid errors when checking for type and null safety.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 90.341%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
1078

Relevant Lines:
1163

💛  - Coveralls


Openflight Data has changed

Hi!
I just used a good 2+ hours debugging my project and i ended up to debug this package. Openflight has changed their data, there is now one extra column, mostly saying "OurAirports". I don't have the purpose of this data, but to fix this issue, you need to change the headers in data.js, row 84, new row with for example "ExtraData" as the new input. Sorry i don't time to do you a pr for you, but go ahead and test this.
To produce the error, please make a fresh install of the package, loadData().then((res)=>{console.log(res.iata)}) and boom, there you have an empty object of airport by iata.
--
Joonas

v1.0.3 is published at npm. Have fun with it and thanks.


HTTP ERROR 403 when User-Agent=Mozilla in request header

Steps to reproduce:
Send any POST request to AEM Stubs. The request has to contain the following header:
User-Agent=Mozilla
Actual results:
403 Forbidden

<meta http-equiv="Content-Type" content="text/html;charset=ISO-8859-1"/>
<title>Error 403 </title>

HTTP ERROR: 403

Problem accessing /stubs/update-interaction. Reason:

    Forbidden

Powered by Jetty://

Expected results:
It should be forwarded to Wiremock engine.

it is because the empty referrer
for example, enable empty via OSGi config or whitelist user-agent to bypass it:

also implemented a bypass which effectively disables all possible request filters registered on AEM that could make stubs not working https://github.com/Cognifide/aem-stubs/pull/29
@aprii @marcinkp so probably no additional configuration will be required
TODO only test regression of that fix on AEM 6.3 & 6.4

Thanks @pun-ky for quick response

fixed by #29 ; released in 1.0.4


enum order gets changed on selection

export interface Something {
  just_a_number?: 1|2|3|4|5;
}

when selecting a value it gets moved to the top

getting worse when changing again

This is really weird behavior, we'll into the reason and work on a fix.

This is fixed now. As well as the other issue you opened.
cheers


Inc systest timeouts

Motivation
Our system tests are flaky due to slow Elasticsearch indexing and slow Kubernetes deployment.
Changes
Increase genesis delta, deployment timeout and a specific test's wait time.
Test Plan
bors try

bors try

bors merge


Loading svg animation for post image load

Summary

Loading svg animation on image load

Ticket Link

Fixes https://github.com/mattermost/mattermost-server/issues/11998

Creating a new SpinWick test server using Mattermost Cloud.

To test use /giphy plugin and try command:
/giphy hello

Mattermost test server created! :tada:
Access here: https://mattermost-webapp-pr-3683.test.mattermost.cloud

Account Type
Username
Password

Admin
sysadmin
Sys@dmin123

User
user-1
User-1@123

Giphy plugin is failed to start on test server. Can anyone check logs.

@niklabh You can access the logs from the System Console in the Reporting > Server Logs tab. Here is the log message being printed:
Unrecognized remote plugin message:
This usually means that the plugin is either invalid or simply needs to be recompiled to support the latest protocol.

I recompiled and reuploaded the plugin, it's working now.

This issue has been automatically labelled "stale" because it hasn't had recent activity.
A core team member will check in on the status of the PR to help with questions.
Thank you for your contribution!
/cc @jasonblais @hanzei

@esethna Gentle reminder to review this

This issue has been automatically labelled "stale" because it hasn't had recent activity.
A core team member will check in on the status of the PR to help with questions.
Thank you for your contribution!
/cc @jasonblais @hanzei

Something to note: Running /giphy (search) shows the svg while loading the gif, but pressing "Shuffle" continues to show the old gif until the new one has been fetched.

Hi @niklabh, thanks for your contribution! Would you have any questions about the feedback from hmhealey above? We'd be happy to help clarify if needed

Test server destroyed


Dist folder not created

Hi,
I'm sure this is just a documenatation issue but I'm trying out astro-shopify and with the existing config when I run npm run build, a dist folder is not created. I can see it has an adapter for vercel. I am testing this with Github pages and the build fails because it does not find dist folder. Can you please update docs or advise what I need to do?
Thank you!

Have you tried to follow this guide?

Yes I have. That’s where I copied the Yaml file from.

You also need to update your astro config to generate a static build:
export default defineConfig({
  output: "static",
  // adapter: vercel(),
  integrations: [
    tailwind({
      config: {
        applyBaseStyles: false,
      },
    }),
    svelte(),
  ],
});

And then you will have to update the src/pages/products/[...handle].astro page to add the getStaticPaths() function.

Sorry for the late response. What is the quickest way to get this up and running in a test prod env? I just need to test out the speed improvements with my website.  So if I use netlify for the build, would I still have to change the settings to create a static build? I tried it already and it also throws an error because it cannot find the dist folder.

Also, i changed the settings locally, just the ones in config file without adding the getStaticPaths function and I got the following error, is it because I need to add the function?
15:42:25 [WARN] `Astro.request.headers` is unavailable in "static" output mode, and in prerendered pages within "hybrid" and "server" output modes. If you need access to request headers, make sure that `output` is configured as either `"server"` or `output:
"hybrid"` in your config file, and that the page accessing the headers is rendered on-demand.
15:42:25 [ERROR] [StaticClientAddressNotAvailable] `Astro.clientAddress` is only available when using `output: 'server'` or `output: 'hybrid'`. Update your Astro config if you need SSR features.

Well I was able to get this deployed and running with netlify and the adapter so dist is not the issue anymore. Only thing now is that it is missing CSS so all styles are broken. Trying to figure out what I need to do to fix that.

sorry for all the messages, finally got it working. CSS issue was because while troubleshooting I had added a value for base in the config file which I did not need. So it was creating a path for the assets that did not exist.


Allow WCS equality checks to be configured

This will allow small errors in WCS precision to be ignored so that cubes on
the same grid to within some tolerance can be compared.
WIP
cc @astrofrog

This looks good to me

@e-koch would be helpful to get an independent review from you on the docs

:+1:  Only found the one typo.


add typescript type definitions

Hi @is343 ,
Thank you for this on-going contribution. :)
Please add me as a reviewer once the changes are done, with some instructions on how to test it.

I used one of the samples from the nodejs-mobile-samples repo and added typescript as a dev dependency and made an App.tsx file from the App.js here.
You can just npm install to get typescript and my branch's nodejs-mobile-react-native ready, then just check out App.tsx to see the typings.

@jaimecbernardo I don't think I have the permissions necessary to add reviewers, but I am ready for you to check this PR out.
Let me know if you need me to change anything!

Hi @is343,
Thank you for the contribution.
I've added myself as a reviewer and will give some feedback once I've been able to give it a test, but it looks good so far.


Trying to get Reporting ---- retrofitting cucumber-protractor-framework issue (im using "cucumber": "1.3.2")

basically the same issue as in this issue.
followed the guide found on http://serenity-js.org/overview/retrofitting.html
I have the following inside package.json
{
  "license": "COMMERCIAL",
  "name": "app",
  "version": "0.0.0",
  "scripts": {
    "ng": "ng",
    "start": "npm run arc-merge-languages && ng serve",
    "build": "npm run arc-merge-languages && ng build",
    "lint": "ng lint",
    "e2e": "ng e2e",
    "arc-merge-languages": "node -e \"require('./node_modules/@arc/arc-frontend-utils/src/index').mergeLanguageFiles()\"",
    "packagr": "ng-packagr -p ./arc-seed-frontend/ng-package.json",
    "packonly": "ng-packagr -p arc-seed-frontend/ng-package.json",
    "preprotractor": "webdriver-manager update --standalone --versions.standalone 3.0.1",
    "protractor": "protractor ./protractor.conf.js",
    "test": "npm run protractor --silent",
    "pretest": "serenity update",
    "report": "serenity run"
  },
  "keywords": [
    "serenity-js",
    "protractor",
    "cucumber"
  ],
  "private": false,
  "dependencies": {
    "@angular/animations": "^5.2.0",
    "@angular/cdk": "^5.0.4",
    "@angular/common": "^5.2.0",
    "@angular/compiler": "^5.2.0",
    "@angular/core": "^5.2.0",
    "@angular/forms": "^5.2.0",
    "@angular/http": "^5.2.0",
    "@angular/platform-browser": "^5.0.0",
    "@angular/platform-browser-dynamic": "^5.0.0",
    "@angular/router": "^5.0.0",
    "@ngrx/effects": "^5.0.1",
    "@ngrx/entity": "^5.0.1",
    "@ngrx/router-store": "^5.0.0",
    "@ngrx/store": "^5.0.0",
    "@ngrx/store-devtools": "^5.0.0",
    "@ngx-translate/core": "^9.1.1",
    "@ngx-translate/http-loader": "^2.0.1",
    "web-animations-js": "^2.3.1",
    "browser-sync": "^2.23.5",
    "chart.js": "^2.7.1",
    "core-js": "^2.5.3",
    "font-awesome": "^4.7.0",
    "fullcalendar": "^3.8.0",
    "jquery": "^3.2.1",
    "moment": "^2.17.1",
    "primeng": "^5.2.0",
    "quill": "^1.3.4",
    "rxjs": "^5.5.6",
    "zone.js": "^0.8.20",
    "intl": "^1.2.5",
    "serenity-js": "^1.10.6"
  },
  "devDependencies": {
    "@angular/cli": "^1.6.4",
    "@angular/compiler-cli": "^5.2.0",
    "@angular/language-service": "^5.2.0",
    "@types/chai": "4.0.0",
    "@types/chai-as-promised": "0.0.31",
    "@types/cucumber": "1.3.1",
    "@types/jasmine": "~2.8.4",
    "@types/jasminewd2": "~2.0.3",
    "@types/node": "~9.3.0",
    "angular4-swagger-client-generator": "~0.1.12",
    "chai": "4.0.2",
    "chai-as-promised": "7.0.0",
    "chai-smoothie": "^0.3.2",
    "chrome-headless-launcher": "^0.1.5",
    "codelyzer": "4.0.2",
    "cpx": "^1.5.0",
    "cucumber": "1.3.2",
    "glob": "7.1.2",
    "jasmine-core": "^2.8.0",
    "jasmine-marbles": "^0.2.0",
    "jasmine-spec-reporter": "^4.2.1",
    "karma": "^2.0.0",
    "karma-chrome-launcher": "^2.2.0",
    "karma-cli": "^1.0.1",
    "karma-coverage-istanbul-reporter": "^1.3.3",
    "karma-jasmine": "^1.1.1",
    "karma-jasmine-html-reporter": "^0.2.2",
    "ng-packagr": "^2.0.0",
    "ng-swagger-gen": "^0.10.0",
    "ngc": "^1.0.0",
    "protractor": "^5.2.2",
    "protractor-cucumber-framework": "3.1.2",
    "serenity-cli": "^0.8.0",
    "source-map-explorer": "^1.5.0",
    "ts-node": "^4.1.0",
    "tsickle": "^0.27.2",
    "tslint": "^5.9.1",
    "typescript": "^2.6.2"
  }
}

i have the following in my protractor.conf.js
const
    glob         = require('glob'),
    protractor   = require.resolve('protractor'),
    node_modules = protractor.substring(0, protractor.lastIndexOf('node_modules') + 'node_modules'.length),
    seleniumJar  = glob.sync(`${node_modules}/protractor/**/selenium-server-standalone-*.jar`).pop();

exports.config = {

    baseUrl: 'https://url/login',

    seleniumServerJar: seleniumJar,

    // https://github.com/angular/protractor/blob/master/docs/timeouts.md
    allScriptsTimeout: 110000,

    disableChecks: true,
    restartBrowserBetweenTests: true,
    // https://github.com/protractor-cucumber-framework/protractor-cucumber-framework#uncaught-exceptions
    ignoreUncaughtExceptions: true,

    framework: 'custom',
    frameworkPath: require.resolve('serenity-js'),
    specs: [ 'e2e/features/**/*.feature' ],

    cucumberOpts: {
        require:    [ 'e2e/features/**/*.ts' ],
        format:     'pretty',
        compiler:   'ts:ts-node/register'
    },

    capabilities: {
        browserName: 'chrome',
        chromeOptions: {
            args: [
                'disable-infobars'
                // 'incognito',
                // 'disable-extensions',
                // 'show-fps-counter=true'
            ]
        }
    }
};

when i run npm test i get the following:
[10:15:25] E/launcher - Error: TypeError: _.chain(...).toPairs is not a function
    at CucumberTestFramework.argumentsFrom (C:\dev\account-service-frontend_test\node_modules\serenity-js\src\serenity-cucumber\cucumber_test_framework.ts:53:40)
    at new CucumberTestFramework (C:\dev\account-service-frontend_test\node_modules\serenity-js\src\serenity-cucumber\cucumber_test_framework.ts:16:25)
    at TestFrameworkDetector.tryToInstantiate (C:\dev\account-service-frontend_test\node_modules\serenity-js\src\serenity-protractor\framework\test_framework_detector.ts:45:37)
    at TestFrameworkDetector.frameworkFor (C:\dev\account-service-frontend_test\node_modules\serenity-js\src\serenity-protractor\framework\test_framework_detector.ts:14:25)
    at new SerenityProtractorFramework (C:\dev\account-service-frontend_test\node_modules\serenity-js\src\serenity-protractor\framework\serenity_protractor_framework.ts:36:38)
    at Object.run (C:\dev\account-service-frontend_test\node_modules\serenity-js\src\serenity-protractor\framework\serenity_protractor_framework.ts:21:12)
    at q.then.then.then.then (C:\dev\account-service-frontend_test\node_modules\protractor\built\runner.js:405:43)
    at _fulfilled (C:\dev\account-service-frontend_test\node_modules\q\q.js:834:54)
    at self.promiseDispatch.done (C:\dev\account-service-frontend_test\node_modules\q\q.js:863:30)
    at Promise.promise.promiseDispatch (C:\dev\account-service-frontend_test\node_modules\q\q.js:796:13)
[10:15:25] E/launcher - Process exited with error code 100
npm ERR! Test failed.  See above for more details.

Any advice is appreciated

Hi there! It looks like issue #184 fixed in version 1.10.7 of serenity-js. Could you please pull in the latest version and check if that solves the problem?
I need to improve how those changelogs are published so that the fixes are easier to find.

npm doesn't see the 1.10.7 version.

I'll close this ticket for now, but if the issue is still there please let me know and we can reopen it.


CI: Fix conda [skip azp] [skip circle]

No idea why but on our 3.9-conda builds we get a deficient OpenGL version:
pyvista:             0.34.0 {OpenGL 3.1 Mesa 21.2.6 via llvmpipe (LLVM 12.0.0, 256 bits)}

Compared to the one we get from 3.10 pip:
pyvista:             0.35.dev0 {OpenGL 4.5 (Core Profile) Mesa 21.2.6 via llvmpipe (LLVM 12.0.0, 256 bits)}

This PR bumps to 3.10 and sets MESA_GL_VERSION_OVERRIDE

Okay I give up, just going to set environment.yml to avoid 5.15.4 as well now. Locally on Linux I can't reproduce the issue using xvfb :shrug:


Update "multiple schedulers" examples

This is a Bug Report
Problem:
The page for configuring multiple schedulers (https://kubernetes.io/docs/tasks/extend-kubernetes/configure-multiple-schedulers/#define-a-kubernetes-deployment-for-the-scheduler) includes references to the --scheduler-name flag, which is removed, and so the examples do not work.
Proposed Solution:
Scheduler name needs to be set via profiles now, so this page should be updated to show passing a KubeSchedulerConfiguration to the custom scheduler deployment via ConfigMap
Page to Update:
https://kubernetes.io/docs/tasks/extend-kubernetes/configure-multiple-schedulers/#define-a-kubernetes-deployment-for-the-scheduler
Kubernetes Version:
1.22+
Additional Information:
/sig scheduling
xref: https://github.com/kubernetes/kubernetes/pull/102805#issuecomment-897663042

@alculquicondor good catch thanks, description updated

/triage accepted
/priority backlog
/language en

@sftim I would like to work on this but TBH when I tried to get this to work, I experienced failures.
The discussion I had in Slack with regard to this ended abruptly with no responses for a few days (see https://kubernetes.slack.com/archives/C09TP78DV/p1633633243117000 in SIG Scheduling).
I would love to have some basic support for this so that I can try this out and I would be happy to update the doc.

Let's use this issue to track the original report - https://github.com/kubernetes/website/issues/29342#issue-968938470
@chirangaalwis I recommend that you request support by some other means - GitHub isn't the best place for that kind of request.

@alculquicondor

But my-scheduler is not recognised although the workload is running fine.

Can you please be more explicit? What do you mean it's not recognized?

The Pods we schedule with the .spec.schedulerName set to my-scheduler do not get scheduled. They stay in Pending state. That is what I have meant by not recognised in the above case.

The scheduler starts or not? Which workload is running fine? The scheduler or a pod that has the schedulerName set to my-scheduler?

@alculquicondor the scheduler starts. What I meant here was that the Deployment workload used to deploy the my-scheduler works fine.

@sftim @alculquicondor @damemi please find the details of the issue and the requested logs uploaded to SIG for Scheduling Slack channel thread.

@damemi @alculquicondor we should be able to close this can't we?
This was covered some time back.

/close

Thanks!

@alculquicondor

But my-scheduler is not recognised although the workload is running fine.

Can you please be more explicit? What do you mean it's not recognized?

The Pods we schedule with the .spec.schedulerName set to my-scheduler do not get scheduled. They stay in Pending state. That is what I have meant by not recognised in the above case.

The scheduler starts or not? Which workload is running fine? The scheduler or a pod that has the schedulerName set to my-scheduler?

@alculquicondor the scheduler starts. What I meant here was that the Deployment workload used to deploy the my-scheduler works fine.

@chirangaalwis hi,  I also encountered  the problem now. The Deployment workload used to deploy the my-scheduler works fine. However, the Pods I schedule with the .spec.schedulerName set to my-scheduler do not get scheduled. They stay in Pending state.  Could you give me some advice? Thanks.


Adds logging

Trying to debug some emails not being verified, this adds debug logging to the lib.

@getconversio/developers ping :)


feat: enable download sources

this is to have jbang idea intellij plugin give hint to jbang that it should download sources.
does it by setting JBANG_DOWNLOAD_SOURCES=true when invoking jbang info commands.
Works with not yet released jbang but it will be out soon and this flag does not hurt older jbang versions thus might as well get it added so the plugin is ready.

@linux-china got feedback on this?

@maxandersen that's good, and I will attach the source files for module library when syncing dependencies.
        // add jbang dependencies
        if (newDependencies.isNotEmpty()) {
            ModuleRootModificationUtil.addModuleLibrary(module, libName, newDependencies.map { "jar://${it}!/" }.toList(), listOf())
        }


Use DEVICE_DT_GET to obtain chosen entropy device

A reference to the CHOSEN entropy device can be obtained at compile time, so
avoid using device_get_binding(). As a result of the changes, DT_CHOSEN_ZEPHYR_ENTROPY_LABEL is no longer needed and so has been dropped.
Resolves https://github.com/zephyrproject-rtos/zephyr/issues/43230

@mbolivar-nordic ping


Allow inline json instead of file

I would like to use configure head as inline json, form same config instead of using external file

@justgook Hi, yes you can for example
require('posthtml-head-elements')({headElements: {/* you inline json */}})

or are you talking about something else?

im about using it over CLI / config json..
https://github.com/posthtml/posthtml-head-elements/blob/master/index.js#L127  - based on that line - it will try to load file..

if i run via posthtml-cli - that config will fail..
module.exports = {
    posthtml: {
        plugins: {
            'posthtml-head-elements': {
                headElements:
                    {
                        "meta": [
                            {
                                "charset": "utf-8"
                            },
                        ]
                    }
            }
        }
    }
}```

@justgook can you create a repository with an example of playing back an error?

in progress.. now ill create that PR - and later evening will push updates to repo.

now ill create that PR - and later evening will push updates to repo.
Thank you very cool 👍


[5.3] [proposal] New object syntax for the rule in

I've found myself doing 'in:'.implode(',', $values) because I have the $values var and it's an array already (located in the config, etc.) and then having to add a similar helper to my project. So I think this rule will be useful as well.

@sileence: While you're at it, could you add the not_in rule as well?

@sileence Thanks. It's what I was going to propose too.


[WIP] Support ContextNet

This PR implement ContextNet. Reference: https://arxiv.org/pdf/2005.03191.pdf
The best results by now:
[test-clean] %WER 9.26% [4867 / 52576, 599 ins, 441 del, 3827 sub ]
[test-other] %WER 26.04% [13632 / 52343, 1382 ins, 1488 del, 10762 sub ]

Conformer results (for reference):
[test-clean] %WER 6.79% [3572 / 52576, 494 ins, 289 del, 2789 sub ]
[test-other] %WER 17.80% [9319 / 52343, 1079 ins, 827 del, 7413 sub ]

On the basis of this 12 blocks model (denoted as standard), I tried three kinds of smaller models: Shallower (with 6 blocks, and output channels is halved), Thinner (with 12 blocks, and output channels is halved), Shallower-and -Thinner (with 6 blocks, and output channels is halved). After tuning the lr-factor the best results of each model are:

Model
test-clean
test-other

Standard (num_block=12, alpha=1)
8.3
22.6

Shallower (num_block=6, alpha=1)
8.49
22.98

Thinner (num_block=12, alpha=0.5)
9.36
25.88

Shallower-and-Thinner (num_block=6, alpha=0.5)
9.49
25.81

Thanks!!
Perhaps you could try a bit deeper, like 15 blocks?

Trying it! Based on the current results, maybe a wider model could be better. Will report the results soon.

I tried the following models: Deeper (num_block=15, alpha=1), Wider(num_block=12, alpha=1.5), Shallower and Wider (num_block=6, alpha=1.5/2). The results are as listed below. I also added the Transformer and Conformer results for comparison.

Model
Params
test-clean
test-other

Transformer
17649383
7.99
20.85

Conformer
33543399
6.79
17.8

Standard (num_block=12, alpha=1)
14262679
8.3
22.6

Deeper (num_block=15, alpha=1)
19091031
8.83
24.29

Wider (num_block=12, alpha=1.5)
31862479
8.03
21.88

Shallower and Wider (num_block=6,   alpha=1.5)
15653407
8.03
22.14

Shallower and Wider (num_block=6,   alpha=2)
27704775
8.17
22.59

The wider model (alpha=1.5) works better. But when I increase the width further (alpha=2), it can't provide more improvement.
If we compare Transformer and the Shallower and Wider model with num_block=6 and alpha=1.5 (the lines in bold), with similar number of paramethers, the performance gap on test-clean is very small (7.99% vs 8.03%).

Cool!
I think we should merge this as a modeling option, even though for this size of data it's not quite as good as Transformer.

I think this PR is ready.

Thanks!!  Merging.

BTW, someone should have a close look at SpeechBrain to see whether we might be able to use it with Lhotse and k2 as the base for Icefall (in that case we might not use the name Icefall).


app 'd87bcc39-1750-4ca0-ad54-f8d0efbb2735' are expired

Describe the bug
Step 3/3: Get access and refresh tokens
粘贴 localhost://开头的地址后，提示
AADSTS7000222: The provided client secret keys for app 'd87bcc39-1750-4ca0-ad54-f8d0efbb2735' are expired.
Visit the Azure portal to create new keys for your app: https://aka.ms/NewClientSecret, or consider using certificate credentials for added security: https://aka.ms/certCreds.

To Reproduce
Steps to reproduce the behavior:

Step 1/3: Preparations
Step 2/3: Get authorisation code ,  open auth url and patse code
See error : Whoops, looks like we got a problem: invalid_client.

Expected behavior
N/A

作者的clientId和clientSceret过期了

使用自己的clientId，就是完成教程中可选的那一步，亲测可行。


Library of Alexandria not showing sharpness enchant for axes

The sharpness enchant doesn't show up with the "item filter" with axes

See here it is applicable
I haven't tested with anything else yet as no other enchants stand out in my mind in the same way.

Just to note*** sharpness DOES show up with swords so it seems to be isolated to axes perhaps?

That check is here https://github.com/Shadows-of-Fire/Apotheosis/blob/1.19/src/main/java/shadows/apotheosis/ench/library/EnchLibraryScreen.java#L238
Seems it may need to be loosened to canApply or whatever it is the anvil checks instead.


Unit testing PowerBI.com (Power BI Service)

Can we write unit tests testing individual DAX queries of the PowerBI .com dataset.  Can we influence the data in the dataset (to set the preconditions of the test)?

Has someone managed to connect to a PBI online dataset? If I take the connectionstring used to connect Excel it uses a ClaimsToken authorization that is not working in NBi

It's not supported by NBi and AFAIK, it's not possible.

Update on this:
XMLA endpoints allow you to use a variety of third party tools against datasets that are in a powerbi workspace associated to a premium capacity. See here for more information and how to enable: https://docs.microsoft.com/en-us/power-bi/admin/service-premium-connect-tools
A few of us have been able to get NBI v1.22.0 working with XMLA endpoints by:

Installing latest MSOLAP (<IP_ADDRESS> at time of writing) from here: https://docs.microsoft.com/en-us/analysis-services/client-libraries?view=asallproducts-allversions
Using the following connection string in the .nbits file Provider=MSOLAP.8;Data Source=powerbi://api.powerbi.com/v1.0/myorg/<workspace_name>;Initial Catalog=<dataset_name>;User ID=<user.name@domain.com>;Password=<password>


wac plug error: "error: encoding produced a component that failed validation"

Repro
https://github.com/estk/hotswap-example
The error
wac plug --plug types.wasm salutation.wasm -o tysal.wasm
error: encoding produced a component that failed validation

Caused by:
    instance not valid to be used as export (at offset 0x36d3bf)

Why this is surprising to me
Since the user-interface interface is local to the hotswap::salutation package and the plugged world types exports the user-interface interface, I would have thought that the imports were satisfied and that the underlying types in user-interface would be automatically re-exported.
WIT at a glance
In the salutation package we have the following:
package<EMAIL_ADDRESS>
interface salutation {
    use user-interface.{user};

    variant formal-honorific {
        sir,
        maam,
        sir-maam,
        custom(string)
    }
    get-formal-honorific: func(u: user) -> formal-honorific;
    greet: func(u: user) -> string;
}

world app {
    import user-interface;
    export salutation;
}

...

interface salutation {
    use user-interface.{user};

    variant formal-honorific {
        sir,
        maam,
        sir-maam,
        custom(string)
    }
    get-formal-honorific: func(u: user) -> formal-honorific;
    greet: func(u: user) -> string;
}

world app {
    import user-interface;
    export salutation;
}

Based on this issue: https://github.com/bytecodealliance/wasm-tools/issues/1798
I tried changing:
world app {
    import user-interface;
    export user-interface;
    export salutation;
}

Which results in the following with cargo component build -p salutation
The problem resolving this is that we now have a number of different Users all of which should actually be resolved to the same User. I'm not really sure how to tell wit-bindgen about this and my attempts to use the bindgen macro have been a dead end so far as well.
error[E0053]: method `greet` has an incompatible type for trait
   --> crates/salutation/src/lib.rs:13:17
    |
13  |     fn greet(u: User) -> String {
    |                 ^^^^ expected `User`, found a different `User`
    |
note: type in trait
   --> crates/salutation/src/bindings.rs:406:33
    |
406 |                     fn greet(u: User) -> _rt::String;
    |                                 ^^^^
    = note: expected signature `fn(exports::hotswap::salutation::user_interface::User) -> String`
               found signature `fn(bindings::hotswap::salutation::user_interface::User) -> String`
help: change the parameter type to match the trait
    |
13  |     fn greet(u: exports::hotswap::salutation::user_interface::User) -> String {
    |                 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

error[E0053]: method `get_formal_honorific` has an incompatible type for trait
   --> crates/salutation/src/lib.rs:24:32
    |
24  |     fn get_formal_honorific(u: User) -> FormalHonorific {
    |                                ^^^^ expected `User`, found a different `User`
    |
note: type in trait
   --> crates/salutation/src/bindings.rs:405:48
    |
405 |                     fn get_formal_honorific(u: User) -> FormalHonorific;
    |                                                ^^^^
    = note: expected signature `fn(exports::hotswap::salutation::user_interface::User) -> FormalHonorific`
               found signature `fn(bindings::hotswap::salutation::user_interface::User) -> FormalHonorific`
help: change the parameter type to match the trait
    |
24  |     fn get_formal_honorific(u: exports::hotswap::salutation::user_interface::User) -> FormalHonorific {

To possibly expand on this from the context of https://github.com/bytecodealliance/wasm-tools/issues/1798 given this input in types.wit:
package a:b;

interface api {
    record foo {
        x: string,
    }

    record bar {
        x: foo,
    }

    f1: func() -> bar;
}

interface use-api {
  use api.{bar};

  f2: func() -> bar;
}

world a {
  export api;
}

world b {
  export use-api;
}

the error can be reproduced with:
$ wasm-tools component embed --dummy ./types.wit --world a | \
  wasm-tools component new -o a.wasm
$ wasm-tools component embed --dummy ./types.wit --world b | \
  wasm-tools component new -o b.wasm
$ wac plug b.wasm --plug a.wasm -o foo.wasm
error: encoding produced a component that failed validation

Caused by:
    instance not valid to be used as export (at offset 0x634)

the problem being that use-api is referring to a type that was provided in an interface from api, but the import into the world b was satisfied from the first component. That means that there's no actual interface to write down in the final component corresponding to the api interface.
How best to solve this I'm not sure, it's a bit tricky. One option is to have a first-class error for this situation and just not support it. Another would possible be to synthesize an import api in the final component with just the types. That only works if resources aren't present, though, so I'm not sure if there's a general-purpose solution.

The example you gave above was super helpful in exploring a bit more what is a valid composition, glad to know those tools exist!
I spent a little more time with this running thru your example with some future use cases. For me, the workaround of extracting the types into a separate interface is totally workable.
If its easy, adding a first class error and a note in the docs would definitely be helpful. After that, given unlimited time and resources I suppose it would be nice to avoid somewhat arbitrarily splitting types and functions into separate interfaces.
Thanks so much for your time and attention resolving this issue. 😄

I made another types-only component as here, triggering the similar errors as
error: encoding produced a component that failed validation

Caused by:
    instance not valid to be used as export (at offset 0x19310)
make: *** [Makefile:25: /github.com/sammyne/wasm-component-broken-compose/_out/calculator-composed.wasm] Error 1

Glimpse of WIT
adder.wit
package<EMAIL_ADDRESS>
interface api {
    use api-types.{wallet};

    incr: func(self: wallet, value: u64) -> result<wallet, string>;
}

interface api-types {
    use types.{balance};

    variant wallet {
        btc(balance),
        eth(balance),
    }
}

interface types {
    record balance {
        value: u64,
    }
}

world docs-adder {
    export api;
    export api-types;
    export types;
}

calculator.wit
package<EMAIL_ADDRESS>
interface hi {
  use types.{btc-or-eth-wallet};

  variant player {
    alice(btc-or-eth-wallet),
    bob(btc-or-eth-wallet),
  }
}

interface types {
  use<EMAIL_ADDRESS>
  record btc-or-eth-wallet {
    w: wallet,
  }
}

world xml-hello {
  export hi;
  export types;
}

Removing the line export types in world xml-hello would fix it.
Really appreciate if this could be explained also~

@sammyne maybe you need to remove api-types from the docs-adder

@alexcrichton , @sammyne 's comment brought up another question for me, would (and how would) the workaround also work if api-types was located in a separate package?

I believe so yeah, the package part is mostly an organization in WIT as opposed to the component model, so the important bit is having the types in an extra interface rather than which package it's in.


SendFromAliasEnabled

Is the "SendFromAliasEnabled" section still accurate about this feature is still in preview? I see in the roadmap it is in "rolling out" status and I can find no up-to-date information on if this feature is now safe to use as it has a pretty stern warning about degraded performance.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 23add0a6-bb9c-15d2-a6eb-351ae0564522
Version Independent ID: 8056b3ee-4fab-3a5c-935b-a9d0e9ad82a4
Content: Set-OrganizationConfig (ExchangePowerShell)
Content Source: exchange/exchange-ps/exchange/Set-OrganizationConfig.md
Service: exchange-powershell
GitHub Login: @chrisda
Microsoft Alias: chrisda

@maxlittleton  If you see a documentation update is required, please feel free to open an issue for the same. We proceed here to close it. Thanks for taking out some time to open the issue. Appreciate and encourage you to do the same in future also.


Add link to third platform to the footer section. (Twitter, Stackoverflow, etc)

I only have two links at the moment.

Done


IllegalStateException: Not in multipart mode

When running this code:
sendMail {
	async true
	from "Chris<EMAIL_ADDRESS>	bcc<EMAIL_ADDRESS>	to<EMAIL_ADDRESS>	subject "subject"
	html "<!doctype html>Hello Customer,..."
	text "Hello Customer,..."
}

I get this exception:
java.lang.IllegalStateException: Not in multipart mode - create an appropriate MimeMessageHelper via a constructor that takes a 'multipart' flag if you need to set alternative texts or add inline elements or attachments.
        at org.springframework.mail.javamail.MimeMessageHelper.checkMultipart(MimeMessageHelper.java:383)
        at org.springframework.mail.javamail.MimeMessageHelper.getMimeMultipart(MimeMessageHelper.java:415)
        at org.springframework.mail.javamail.MimeMessageHelper.getMainPart(MimeMessageHelper.java:827)
        at org.springframework.mail.javamail.MimeMessageHelper.setText(MimeMessageHelper.java:813)
        at grails.plugins.mail.MailMessageBuilder.finishMessage(MailMessageBuilder.groovy:426)
        at grails.plugins.mail.MailMessageBuilder.sendMessage(MailMessageBuilder.groovy:105)
        at grails.plugins.mail.MailService.sendMail(MailService.groovy:53)
        at grails.plugins.mail.MailService.sendMail(MailService.groovy:57)
        at grails.plugins.mail.SendMail$Trait$Helper.sendMail(SendMail.groovy:31)
        at my.app.send(MyMailSender.groovy:123)

I tried setting multipart true, but that didn't seem to help.
I'm on the latest version, v2.0.0.RC6.

Same issue on v2.0.0. Any ideas?

Figured it out. Looks like I needed to add multipart true to the top of my parameters list. This is because from, bcc, to, subject, html, and text will all construct the message object. You need to enable multipart before you construct the message.
sendMail {
	async true
	multipart true
	from "Chris<EMAIL_ADDRESS>	bcc<EMAIL_ADDRESS>	to<EMAIL_ADDRESS>	subject "subject"
	html "<!doctype html>Hello Customer,..."
	text "Hello Customer,..."
}