Environment values not overriding

Something has broken in the last release around env values. I use to be able to do this:
environments:
  default:
    missingFileHandler: Error
    values:
    - values-file-1.yaml
    - values-file-2.yaml

Where values-file-2.yaml had some values that would override values in values-file-1.yaml. This is no longer working. It appears values-file-2.yaml  is ignored (although I am not sure). It only has a single value override.
Also missingFileHandler: Error no longer works. It will not error on missing files.
Sorry if I missed a post about a breaking change. But I'm going to downgrade until this is resolved or I understand the issue.

@michaelajr Hey! I couldn't reproduce your issue with the following example:
$ tail *
==> helmfile.yaml <==
  default:
    missingFileHandler: Error
    values:
    - values.1.yaml
    - values.2.yaml

releases:
- name: example
  values:
  - {{ .Values | toYaml | nindent 4 }}

==> values.1.yaml <==
foo: FOO

==> values.2.yaml <==
bar: BAR

$ helmfile build
---
#  Source: helmfile.yaml

filepath: helmfile.yaml
helmBinary: helm
environments:
  default:
    values:
    - values.1.yaml
    - values.2.yaml
    missingFileHandler: Error
releases:
- name: example
  values:
  - bar: BAR
    foo: FOO
templates: {}

Could you clarify a bit more?
We did fix a bug that you couldn't override a value if it was nil as per #1153 and #1162.
Would it affect your use-case?

Hi. Thanks for the quick response. Here's our real world example.

We keep a list of charts to install in addons.yaml
Each cluster brings overrides - addons2.yaml in this example

$ tail -20 *
==> addons.yaml <==
addons:
  mychart:
    skip: true
    name: mychart
    namespace: kube-system
    chart: stable/mychart
    version: 1.0.0

==> addons2.yaml <==
addons:
  mychart:
    skip: false

==> helmfile.yaml <==
environments:
  default:
    missingFileHandler: Error
    values:
    - addons.yaml
    - addons2.yaml
releases:
{{- range .Values.addons }}
{{- if not .skip }}
- name: {{ .name }}
  namespace: {{ .namespace }}
  chart: {{ .chart }}
  version: {{ .version }}
{{- end }}
{{- end }}

In this example addons2.yaml is changing the skip to false.  So it should show up in releases when I build - and prior to 0.106.2 it did.
$ helmfile build
---
#  Source: helmfile.yaml

filepath: helmfile.yaml
helmBinary: helm
environments:
  default:
    values:
    - addons.yaml
    - addons2.yaml
    missingFileHandler: Error
templates: {}
err: no releases found that matches specified selector() and environment(default), in any helmfile

Now, let's NOT skip the chart in addons.yaml.
==> addons.yaml <==
addons:
  mychart:
    skip: false
    name: mychart
    namespace: kube-system
    chart: stable/mychart
    version: 1.0.0

And build
$ helmfile build
---
#  Source: helmfile.yaml

filepath: helmfile.yaml
helmBinary: helm
environments:
  default:
    values:
    - addons.yaml
    - addons2.yaml
    missingFileHandler: Error
releases:
- chart: stable/mychart
  version: 1.0.0
  name: mychart
  namespace: kube-system

There it is. So addons2.yaml is not doing what it use to - overriding the skip value.
Also, if a file does not exist, I no longer get
$ tail -20 helmfile.yaml
environments:
  default:
    missingFileHandler: Error
    values:
    - does-not-exist.yaml
    - addons.yaml
    - addons2.yaml
releases:
{{- range .Values.addons }}
{{- if not .skip }}
- name: {{ .name }}
  namespace: {{ .namespace }}
  chart: {{ .chart }}
  version: {{ .version }}
{{- end }}
{{- end }}

Build.
$ helmfile build
in ./helmfile.yaml: error during helmfile.yaml.part.0 parsing: template: stringTemplate:9:17: executing "stringTemplate" at <.Values.addons>: map has no entry for key "addons

It looks like it fails internally but continues with no values , so it fails later. Pretty sure I use to get a missing file error immediately, but will confirm later in comments.
Btw, thanks for your work on this. Been following the repo, and you put in a lot of time. Great in depth comments - quick responses and turn arounds. So thank you. Really appreciate it.
M

Looks like other non-boolean values do override. Changing versions in this example, and it does work.
$ tail -20 *
==> addons.yaml <==
addons:
  mychart:
    skip: false
    name: mychart
    namespace: kube-system
    chart: stable/mychart
    version: 1.0.0

==> addons2.yaml <==
addons:
  mychart:
    version: 2.0.0

==> helmfile.yaml <==
environments:
  default:
    missingFileHandler: Error
    values:
    - addons.yaml
    - addons2.yaml
releases:
{{- range .Values.addons }}
{{- if not .skip }}
- name: {{ .name }}
  namespace: {{ .namespace }}
  chart: {{ .chart }}
  version: {{ .version }}
{{- end }}
{{- end }}
88e9fe8687ae:foo sga872$ helmfile build
---
#  Source: helmfile.yaml

filepath: helmfile.yaml
helmBinary: helm
environments:
  default:
    values:
    - addons.yaml
    - addons2.yaml
    missingFileHandler: Error
releases:
- chart: stable/mychart
  version: 2.0.0
  name: mychart
  namespace: kube-system
templates: {}

Also, can confirm missingFileHandler: Error in 0.104.0 behaves the same. I really thought it failed fast but I guess I was wrong. So disregard. Although it might be nice to make it fail fast - so if you think it should I can open a separate issue.

Also here is confirmation that the boolean merge worked in 0.104.0.
$ brew switch helmfile 0.104.0
Cleaning /usr/local/Cellar/helmfile/0.104.0
Cleaning /usr/local/Cellar/helmfile/0.106.3
1 links created for /usr/local/Cellar/helmfile/0.104.0

$ tail -20 *
==> addons.yaml <==
addons:
  mychart:
    skip: true
    name: mychart
    namespace: kube-system
    chart: stable/mychart
    version: 1.0.0

==> addons2.yaml <==
addons:
  mychart:
    skip: false

==> helmfile.yaml <==
environments:
  default:
    missingFileHandler: Error
    values:
    - addons.yaml
    - addons2.yaml
releases:
{{- range .Values.addons }}
{{- if not .skip }}
- name: {{ .name }}
  namespace: {{ .namespace }}
  chart: {{ .chart }}
  version: {{ .version }}
{{- end }}
{{- end }}

$ helmfile build
---
#  Source: helmfile.yaml

filepath: helmfile.yaml
environments:
  default:
    values:
    - addons.yaml
    - addons2.yaml
    missingFileHandler: Error
releases:
- chart: stable/mychart
  version: 1.0.0
  name: mychart
  namespace: kube-system
templates: {}

Thanks a lot for your detailed report!
It does seem like a regression - So in nutshell it seems like an override with a zero values(like false for boolean) started to not work in 0.106.x, right?
Probably we need to revert a change or two regarding mergo, which we use under the hood for merging values.

It does seem something in the mergo upgrade caused the behavior change. Could my use case be accomplished a different way? Is there a helmfile way to skip? I was just rolling my own.

@michaelajr I managed to reproduce and fix this thanks to you and @elodani, in #1169.
Could you please confirm if it works for you now with Helmfile v1.106.4?

Also - I've added a few tests to make this never happen again :) See #1170

The same problem exists with mergeOverwrite:
helmfile.yaml:
{{- $v1 := dict "bool" true  "int" 2 "str" "v1" "str2" "v1" -}}
{{- $v2 := dict "bool" false "int" 0 "str" "v2" "str2" "" -}}
{{- $mo1 := mergeOverwrite (dict) $v1 $v2 }}
{{- $mo2 := mergeOverwrite (dict) $v2 $v1 }}{{/* just for sanity checking the order of merge args */}}
releases:
  - name: mo1
    chart: mo1
    values:
      - {{- $mo1 | toYaml | nindent 8}}
  - name: mo2
    chart: mo2
    values:
      - {{- $mo2 | toYaml | nindent 8 }}

build output (helmfile version v0.126.0)
---
#  Source: helmfile.yaml

filepath: helmfile.yaml
helmBinary: helm
releases:
- chart: mo1
  name: mo1
  values:
  - bool: true
    int: 2
    str: v2
    str2: v1
- chart: mo2
  name: mo2
  values:
  - bool: true
    int: 2
    str: v1
    str2: v1
templates: {}
missingFileHandler: ""

in mo1 only str gets overwritten  and the "falsy" values are ignored
Have been looking for helmfile  v1.106.4

Have been looking for helmfile v1.106.4 - where is that?

I meant v0.106.4

@jalkjaer FWIW it seems a sprig issue.
Sprig's mergeOverwrite seems to be missing mergo.WithOverwriteWithEmptyValue.
func mergeOverwrite(dst map[string]interface{}, srcs ...map[string]interface{}) interface{} {
	for _, src := range srcs {
		if err := mergo.MergeWithOverwrite(&dst, src); err != nil {
			// Swallow errors inside of a template.
			return ""
		}
	}
	return dst
}

MergeWithOverwrite is basically Merge(dst, src, mergo.WithOverride) where it MUST be , Merge(dst, src, mergo.WithOverride, mergo.WithOverwriteWithEmptyValue)` to enable override with falsey values.

Latest version (v3.10) of sprig does the expected. (see https://play.golang.org/p/r_IgI3Tqb1A )
If I bump sprig to v3.1.0 and explicitly add mergo v0.3.11 then mergeOverwrite works in Helmfile as documented in sprig
But then is now a test failing
--- FAIL: TestVisitDesiredStatesWithReleasesFiltered_EnvironmentValueOverrides (0.00s)
panic: reflect: reflect.flag.mustBeAssignable using value obtained using unexported field [recovered]
	panic: reflect: reflect.flag.mustBeAssignable using value obtained using unexported field

goroutine 13 [running]:
testing.tRunner.func1.1(0x13567e0, 0xc0002a5ce0)
	/home/jalkjaer/sdk/go1.14.4/src/testing/testing.go:940 +0x2f5
testing.tRunner.func1(0xc000457440)
	/home/jalkjaer/sdk/go1.14.4/src/testing/testing.go:943 +0x3f9
panic(0x13567e0, 0xc0002a5ce0)
	/home/jalkjaer/sdk/go1.14.4/src/runtime/panic.go:969 +0x166
reflect.flag.mustBeAssignableSlow(0x1b9)
	/home/jalkjaer/sdk/go1.14.4/src/reflect/value.go:244 +0x1b9
reflect.flag.mustBeAssignable(...)
	/home/jalkjaer/sdk/go1.14.4/src/reflect/value.go:234
reflect.Value.Set(0x1455e60, 0xc000010018, 0x1b9, 0x1455e60, 0xc000010018, 0x1b9)
	/home/jalkjaer/sdk/go1.14.4/src/reflect/value.go:1526 +0x3b
github.com/imdario/mergo.deepMerge(0x1455e60, 0xc000010018, 0x1b9, 0x1455e60, 0xc000010018, 0x1b9, 0xc0000a28c8, 0x2, 0xc000555dc0, 0x0, ...)
	/home/jalkjaer/git/roboll/helmfile/vendor/github.com/imdario/mergo/merge.go:99 +0x308c
github.com/imdario/mergo.deepMerge(0x15cdd60, 0xc00037db10, 0x1b6, 0x15cdd60, 0xc000487610, 0x1b6, 0xc0000a28c8, 0x1, 0xc000555dc0, 0x0, ...)
	/home/jalkjaer/git/roboll/helmfile/vendor/github.com/imdario/mergo/merge.go:246 +0x206e
github.com/imdario/mergo.deepMerge(0x15e31a0, 0xc00037d900, 0x199, 0x15e31a0, 0xc000487400, 0x199, 0xc0000a28c8, 0x0, 0xc000555dc0, 0x199, ...)
	/home/jalkjaer/git/roboll/helmfile/vendor/github.com/imdario/mergo/merge.go:93 +0x2f82
github.com/imdario/mergo.merge(0x15f1240, 0xc00037d900, 0x15f1240, 0xc000487400, 0xc0000a2aa8, 0x1, 0x1, 0xd, 0x201)
	/home/jalkjaer/git/roboll/helmfile/vendor/github.com/imdario/mergo/merge.go:361 +0x32a
github.com/imdario/mergo.Merge(...)
	/home/jalkjaer/git/roboll/helmfile/vendor/github.com/imdario/mergo/merge.go:291
github.com/roboll/helmfile/pkg/app.(*desiredStateLoader).renderAndLoad(0xc0002f3050, 0x0, 0xc00074c7a0, 0x15fb2f5, 0x1, 0xc0003a0f00, 0xd, 0xc0001c1800, 0x384, 0x400, ...)
	/home/jalkjaer/git/roboll/helmfile/pkg/app/desired_state_file_loader.go:225 +0x58c
github.com/roboll/helmfile/pkg/app.(*desiredStateLoader).loadFileWithOverrides(0xc0002f3050, 0x0, 0xc00074c7a0, 0x15fb2f5, 0x1, 0x16074ea, 0xd, 0x1, 0x199, 0x203000, ...)
	/home/jalkjaer/git/roboll/helmfile/pkg/app/desired_state_file_loader.go:117 +0x1ec
github.com/roboll/helmfile/pkg/app.(*desiredStateLoader).Load(0xc0002f3050, 0x16074ea, 0xd, 0x25e24e8, 0x0, 0x0, 0xc00074c3a0, 0x2, 0x2, 0x0, ...)
	/home/jalkjaer/git/roboll/helmfile/pkg/app/desired_state_file_loader.go:65 +0x2f2
github.com/roboll/helmfile/pkg/app.(*App).loadDesiredStateFromYaml(0xc0004578c0, 0x16074ea, 0xd, 0xc0000a36b8, 0x1, 0x1, 0x0, 0x0, 0x0)
	/home/jalkjaer/git/roboll/helmfile/pkg/app/app.go:575 +0x26d
github.com/roboll/helmfile/pkg/app.(*App).visitStates.func1(0x16074ea, 0xd, 0xc0003a09b0, 0x8, 0x0, 0x0)
	/home/jalkjaer/git/roboll/helmfile/pkg/app/app.go:627 +0x176
github.com/roboll/helmfile/pkg/app.(*App).visitStateFiles.func1(0x0, 0x7fae4c245108)
	/home/jalkjaer/git/roboll/helmfile/pkg/app/app.go:542 +0x9d
github.com/roboll/helmfile/pkg/app.(*App).within(0xc0004578c0, 0x15fb2f5, 0x1, 0xc000017ad0, 0xc00007ba90, 0x2)
	/home/jalkjaer/git/roboll/helmfile/pkg/app/app.go:484 +0x602
github.com/roboll/helmfile/pkg/app.(*App).visitStateFiles(0xc0004578c0, 0x16074ea, 0xd, 0x25e24e8, 0x0, 0x0, 0xc00074c1c0, 0x2, 0x2, 0x0, ...)
	/home/jalkjaer/git/roboll/helmfile/pkg/app/app.go:536 +0x2f2
github.com/roboll/helmfile/pkg/app.(*App).visitStates(0xc0004578c0, 0x16074ea, 0xd, 0x25e24e8, 0x0, 0x0, 0xc00074c1c0, 0x2, 0x2, 0x0, ...)
	/home/jalkjaer/git/roboll/helmfile/pkg/app/app.go:620 +0x10b
github.com/roboll/helmfile/pkg/app.(*App).visitStatesWithSelectorsAndRemoteSupport(0xc0004578c0, 0x16074ea, 0xd, 0xc00007bdf0, 0xc00007be70, 0x1, 0x1, 0xc00007be01, 0xc0003a09a0)
	/home/jalkjaer/git/roboll/helmfile/pkg/app/app.go:875 +0x4c1
github.com/roboll/helmfile/pkg/app.(*App).ForEachState(0xc0004578c0, 0xc00007bec8, 0xc00007be70, 0x1, 0x1, 0xc0001c0800, 0x384)
	/home/jalkjaer/git/roboll/helmfile/pkg/app/app.go:756 +0xb2
github.com/roboll/helmfile/pkg/app.TestVisitDesiredStatesWithReleasesFiltered_StateValueOverrides.func1(0xc000457440)
	/home/jalkjaer/git/roboll/helmfile/pkg/app/app_test.go:1155 +0x703
testing.tRunner(0xc000457440, 0xc00074e4c0)
	/home/jalkjaer/sdk/go1.14.4/src/testing/testing.go:991 +0xdc
created by testing.(*T).Run
	/home/jalkjaer/sdk/go1.14.4/src/testing/testing.go:1042 +0x357

That test is rather daunting (for a go / Helmfile noob like me)  so this is as far I was able to get.
If you want, I can create a PR

@jalkjaer Thanks for trying. Would u mind submitting the PR so that I can review and see what's going on?

PR #1456 created


pylintrc configuration file added

Customizes the way pylint checks the code style. Also added a few more files in gitignore

This makes sense as a way to implement a style guide.  I'll need to mess with this a little though.  If we are going to formalize the style guide, then I think we'll want to make sure the pylintrc contains everything we want, and that we agree on its contents.


Foundry setup

We're also moving towards having Security review PRs on FX-Portal (and POS-Portal and v1 contracts), so I'll also be opening a ticket with them to take a look.

As I think about this more, I think instead of going to main, it should merge in to a new branch like dev/forge or something like that, and then once it's done (or far enough along), we'll merge it into main.


Stats

Coverage increased (+0.5%) to 92.76% when pulling bfa14ff40cb7372773cdeca24d34b8fb73df8fd0 on stats into e58165619c063a5208fa7e48cda23ff093d696b9 on master.


Example-Settings.json

Hello
The Example-Settings.json appears to not work in the current version of the tool when migrating an OPM Interview project to a Flow. It appears that a reference for a basic text control is missing. The error when using the example file is
Error in settings: "$settings.flowControls.input.text.text" should be a string
Looking at the sample file the text input section looks like this
 "text":
            {
		"text-area": "text-textarea",
                "password": "text-password",
                "masked": "text-masked"
            },

Adding a basic map to a text control removes the error :
 "text":
            {
                 "text": "text",
		 "text-area": "text-textarea",
                "password": "text-password",
                "masked": "text-masked"
            },

Not sure if that is all that is required, but wanted to flag the error anyway. Thanks!

We will make mapping to a text control optional.  Tracking as OZ-20374


can the camera remove in the website using the luma-webgl library？

I find that in the example of the offical luma website I can remove the camera by clicking somewhere, can I achieve this using the webgl library?

Hi @TaiyakiOffical, this isn't yet supported but it's planned
Closing this issue in favor of an existing one #8


Deepsat: SAT-4/SAT-6 airborne 2.4GB

Scene Classification

Deepsat: SAT-4/SAT-6 airborne datasets (Louisiana State University, 2015)
6 land cover categories, 400k 28x28 pixel chips, 4-band RGBNIR aerial imagery (1m res.) extracted from the 2009 National Agriculture Imagery Program (NAIP), Paper: Basu et al. 2015

@gilangarisptr take a look at this


Consider using yarn instead of npm

There are touted performance and security gains.

Creating a branch to test switching over.


Can we set sequence to seed collections?

For example  we have 2 collections  medias and campaigns.  In CampaignSchema we have medias field
medias: [{ type: ObjectId, ref: 'Media' }],
For population medias in campaigns, we need in campaigns.js file set medias documents _ids,
but your seed invoke at first campaigns.js, after it medias.js file, so we cant use any media's _id.

So you're asking for a way to specify the order of the files to be seeded?

Yeah, something like that

Can you provide an example of some way you'd anticipate doing this?

for example we can set file name starting with 1., 2., 3.,  and so on. You should slice file name after dote. In my case I will set
1.media
2.campaign
then seed will create media collection, then campaign. So I will able to use media's _id in campaign collection

In this example would you seed media, then manually copy and paste the _id's into campaign and then seed just that file?

Bro suppose that I have 100 medias. So I need to set their all 100 _id manually? I think it's not the dynamic solution of our problem.

That's what i'm trying to get out of you. How exactly you'd expect to use this feature. So far you haven't given me a very concrete example.


Adding Pocono Mountain School District

The School: https://www.pmsd.org/
9-12 School that includes STEM and AP Computer Science programs.

@lucasstarsz Pull request merged. Thank you!


Added common.feature.group to cc profile

Thanks @hsbhathiya for the fix! I have now merged this to master branch.


25 | Reverse Nodes in k-group | C++

Title -
What will change -
Type of Issue -
Please add/delete options that are not relevant.

[x] Adding New Code
[x] Improving Code

Programming Language
Please add/delete options that are not relevant.

[x] C++

Self Check

Ask for issue assignment and wait to get assigned to it before making Pull Request.
Add your file in the proper folder
Clean Code and Documentation for better readability
Add Title and Description of the program in the file

:star2: Star it :fork_and_knife:Fork it :handshake: Contribute to it!
Discord server ✉ - https://discord.gg/CXksGdn
Happy Coding,

Hey, is this issue still open? Can you assign it to me?

@SaimantikaBasu This code has already been made


Move Enrollment API out of urls.py

The enrollment api shouldn't be in urls.py
We can define the API endpoint there (see the bottom of urls.py) - but it should be in api.py

Mhm. Not sure if I'm missing something, but what needs to be removed? There isn't an EnrollmentAPI defined in the file or in the project.
register_api(api.AssignmentAPI, 'assignment_api', 'assignment')
register_api(api.SubmissionAPI, 'submission_api', 'submission')
register_api(api.SearchAPI, 'search_api', 'search')
register_api(api.VersionAPI, 'version_api', 'version')
register_api(api.CourseAPI, 'course_api', 'course')
register_api(api.GroupAPI, 'group_api', 'group')
register_api(api.UserAPI, 'user_api', 'user')
register_api(api.QueueAPI, 'queue_api', 'queue')
register_api(api.FinalSubmissionAPI, 'final_submission_api', 'final_submission')
register_api(api.AnalyticsAPI, 'analytics_api', 'analytics')

Sumukh is saying that the "/enrollment" route shouldn't be there and should be part of some API in the section you quoted. Specifically, this function should be gone: https://github.com/Cal-CS-61A-Staff/ok/blob/master/server/app/urls.py#L64.

Ohh. Thanks. Working on it.


Starting pigpiod without sudo?

Hi,
trying a special router distro for the RaspberryPi 3 from LEDE the latest 17.01.3,
https://lede-project.org/docs/instructionset/arm_cortex-a53_neon-vfpv4
Compiled like
 CFLAGS=-mfloat-abi=hard make and installed.
Trying to run gives me:
root@lede:~/pigpio# /lib/ld-musl-armhf.so.1 ./pigpiod
root@lede:~/pigpio# 2017-10-15 08:00:27 initCheckPermitted:
+---------------------------------------------------------+
|Sorry, you don't have permission to run this program.    |
|Try running as root, e.g. precede the command with sudo. |
+---------------------------------------------------------+

Can't initialise pigpio library

Traditionally a router os has no sudo on board, but there was an add. package "sudo" that I have installed but it makes no difference. Is there any chance to startup the daemon?
root@lede:~/pigpio# uname -a
Linux lede 4.4.89 #0 SMP Sat Sep 30 18:37:33 2017 armv7l GNU/Linux
root@lede:~/pigpio# cat /etc/os-release
NAME="LEDE"
VERSION="17.01.3, Reboot"
ID="lede"
ID_LIKE="lede openwrt"
PRETTY_NAME="LEDE Reboot 17.01.3"
VERSION_ID="17.01.3"
HOME_URL="http://lede-project.org/"
BUG_URL="http://bugs.lede-project.org/"
SUPPORT_URL="http://forum.lede-project.org/"
BUILD_ID="r3533-d0bf257c46"
LEDE_BOARD="brcm2708/bcm2710"
LEDE_ARCH="arm_cortex-a53_neon-vfpv4"
LEDE_TAINTS="no-all"
LEDE_DEVICE_MANUFACTURER="LEDE"
LEDE_DEVICE_MANUFACTURER_URL="http://lede-project.org/"
LEDE_DEVICE_PRODUCT="Generic"
LEDE_DEVICE_REVISION="v0"
LEDE_RELEASE="LEDE Reboot 17.01.3 r3533-d0bf257c46"

Any idea would be appreciated.
Best regards,
Nic

Hi @Nic2012 ,
Pigpio uses direct memory access that needs the root privileges.
First, you can check if direct memory access is available : is /dev/mem present ?
Then the user that runs the application needs to have access to /dev/mem.

Answered by @MaitreDede


[PR] The proj files have been updated to enable SourceLink

CSProj files have been updated to enable SourceLink in your nuget
[This pull request was created with an automated workflow]
I noticed that your repository and Nuget package are important for our .NET community, but you still haven't enabled SourceLink.
We have to take 2 steps:

Please approve this pull request and make .NET a better place for .NET developers and their debugging.
Then just upload the .snupkg file to https://www.nuget.org/ (now you can find the snupkg file along with the .nuget file)

You can find more information about SourceLine at the following links
https://github.com/dotnet/sourcelink
https://www.hanselman.com/blog/ExploringNETCoresSourceLinkSteppingIntoTheSourceCodeOfNuGetPackagesYouDontOwn.aspx
If you are interesting about this automated workflow and how it works
https://github.com/JTOne123/GitHubMassUpdater
If you notice any flaws, please comment and I will try to make fixes manually

Thanks for the pull request. How can I create a .snupkg file?
I'm currently using the nuget.exe pack command and I guess that way SourceLink won't work. Do I need to use dotnet pack instead?
https://github.com/shimat/opencvsharp/blob/master/appveyor.yml#L105
My nuget pack command above already outputs snupkg, what is the difference between that and SourceLink?

I think it would be easier to add the following line to my nuspec.
<repository type="git" url="https://github.com/shimat/opencvsharp.git" commit="xxxxx" />

https://www.hanselman.com/blog/ExploringNETCoresSourceLinkSteppingIntoTheSourceCodeOfNuGetPackagesYouDontOwn.aspx

yes, you can
about nuget pack
https://www.meziantou.net/how-to-debug-nuget-packages-using-sourcelink.htm

thank you for your contribution :+1:


Refactor how processors are injected to plugin handlers/lambdas

This is required because we need to inject asset store to lambda in
order to support asset signing when we support returning assets.

Merged via 7173ebe


Model to architecture mapping

Hello HF team,
how can I identify which specific architecture, according to config.json, is supported by a specific implementation e.g., of Bert? I try to find a way to map between the RUST implementation and the HF Hub model.
Thanks in advance

For bert for example, you can check if the fields that you care about appear in the rust version of the config here. This wouldn't give you full insurance that it's properly supported but at least if it doesn't appear you can be sure that it's not supported :) (lately we've tried to fail on parameter that have values which are not fully handled but that wasn't the case when adding bert etc)

Thanks got it.


Usage telemetry tracking

To enhance the quality of Bacalhau and gain insights into network usage, we need to implement a telemetry system. This will help us prioritize features and bug fixes based on actual usage data. Our approach will focus on collecting non-personally identifiable information (non-PII) while respecting user privacy by providing an opt-out mechanism.
### Tasks
- [ ] https://github.com/bacalhau-project/bacalhau/issues/4317
- [ ] https://github.com/bacalhau-project/bacalhau/issues/4318
- [ ] https://github.com/bacalhau-project/bacalhau/issues/4319
- [ ] https://github.com/bacalhau-project/bacalhau/issues/4322
- [ ] https://github.com/bacalhau-project/bacalhau/issues/4320
- [ ] https://github.com/bacalhau-project/bacalhau/issues/4321
- [ ] https://github.com/bacalhau-project/bacalhau/issues/4354
- [ ] https://github.com/bacalhau-project/bacalhau/issues/4415
- [ ] https://github.com/bacalhau-project/bacalhau/issues/4489

Considerations

Ensure all collected data is anonymized and non-PII
Design the opt-out mechanism to be user-friendly and easily accessible
Comply with relevant data protection regulations
Balance the detail of collected data with user privacy concerns

By completing this epic, we aim to create a more robust, user-centric Bacalhau network while maintaining our commitment to user privacy and transparency.

@frrist can you please update the tasks here? I understand exporting to S3 is not complete, but I am not sure about the other items and whether there are other pending tasks or not


Switch to three threads per cq for unconstrained benchmarks

Best mixed with #11758 to give the biggest speedup, but this looks to be the optimal operating point for these benchmarks right now.

CC @a11r @vjpai @sreecha

[trickle] No significant performance differences

[microbenchmarks] No significant performance differences

[trickle] No significant performance differences

[microbenchmarks] No significant performance differences

Jenkins test this please


Unable to access some proto generated code

For example:
pe.resources.iter().find(|resource| {
    resource.type_() == yara_x::modules::protos::pe::ResourceType::RESOURCE_TYPE_MANIFEST
});

I can get the ResourceType from resource.type_() but I can't check which type it is because yara_x::modules is private.

I'm also confused because the code in lib/src/modules/pe is very different to what's accessible from the library on crates.io. I've only been able to parse a PE file by doing yara_x::mods::invoke_mod::<yara_x::mods::PE>(data), but pe/mod.rs#L33 shows it as being just PE::parse. They also return different structs.

I've exposed all data structures and enums defined by modules in https://github.com/VirusTotal/yara-x/commit/91795a50cf58a6b0439f290f2aac3c7972cb5803. They are now accessible from outside this crate.
Let me clarify your question about the code being exposed. The intention with the yara_x::mods::invoke_mod function is allowing any user to obtain the same data structure that a YARA module produces and exposes to YARA rules. The intention is not exporting the internal code that parses the file and populate such structures.
The confusion may arise because of the use of the word "module" both in the Rust and YARA worlds. But we are talking about different things when we talk about the YARA pe module, and the Rust pe module in lib/src/modules/pe. The Rust pe module is not part of the public API, it contains the code for parsing a PE file and producing the protobuf structure that you can obtain via yara_x::mods::invoke_mod, but this Rust module is private.
The code in lib/src/modules/pe is modular enough, and it could be moved to a separate crate that could be used outside of YARA-X for parsing PE files, but that's not the intention yet. I can consider publishing it as a standalone crate in the future, if enough people find it useful.

Thank you for clarifying @plusvic! I personally am considering using this for parsing and analysing PE files, and perhaps extending that to other files if I lean more into Yara rules. Even in its current state, the module for parsing PE files feels very powerful compared to other libraries I've used (and more resilient to slightly incorrect files), or at least requires much less boilerplate.


Connection Error: Can't initialize character set unknown

In the particular case, when connecting from a local computer (Windows 10; 0.3.7-R2; latest version of plugin) to a remote database (Debian 9, mysql version 8.0.12), an error occurs:
[ERROR] CConnection::CConnection - establishing connection to MySQL database failed: #2019 'Can't initialize character set unknown (path: compiled_in)'
Function "mysql_set_charset("cp1251", g_SQL);" - called with the argument cp1251 and lower in code (it does not reach execution)
The most interesting thing is that the server starts up and correctly connects to the database, if you start it from the VDS where the database is located

I have the same problem. Version mysql 8.0.13.
mysql server and samp server stand on windows 10.
I think the problem is that your plugin is not designed for this version of mysql.
[11:37:57] [INFO] changed log level from 'warning, error' to 'debug, info, warning, error'
[11:37:57] [DEBUG] mysql_connect("localhost", "root", "*****", "dm", 0) (C:\Users\pilip\Desktop\DeathMatch Server\gamemodes\new.pwn:74)
[11:37:57] [DEBUG] CHandleManager::Create(this=0x62a280, host='localhost', user='root', pass='****', db='dm', options=0x61ee20)
[11:37:57] [INFO] Creating new connection handle...
[11:37:57] [DEBUG] CConnection::CConnection(this=0x62a440, host='localhost', user='root', passw='****', db='dm', options=0x61ee20)
[11:37:57] [ERROR] CConnection::CConnection - establishing connection to MySQL database failed: #2019 'Can't initialize character set unknown (path: compiled_in)'
[11:37:57] [DEBUG] CConnection::CConnection(this=0x38a8020, host='localhost', user='root', passw='****', db='dm', options=0x61ee20)
[11:37:57] [ERROR] CConnection::CConnection - establishing connection to MySQL database failed: #2019 'Can't initialize character set unknown (path: compiled_in)'
[11:37:57] [DEBUG] CThreadedConnection::CThreadedConnection(this=0x38a8020, connection=0x38a8020)
[11:37:57] [DEBUG] CConnectionPool::CConnectionPool(size=2, this=0x62a480)
[11:37:57] [DEBUG] CConnection::CConnection(this=0x3a7d020, host='localhost', user='root', passw='****', db='dm', options=0x61ee20)
[11:37:57] [DEBUG] CThreadedConnection::WorkerFunc(this=0x38a8020, connection=0x38a8020)
[11:37:57] [ERROR] CConnection::CConnection - establishing connection to MySQL database failed: #2019 'Can't initialize character set unknown (path: compiled_in)'
[11:37:57] [DEBUG] CThreadedConnection::WorkerFunc(this=0x3a7d020, connection=0x3a7d020)
[11:37:57] [DEBUG] CThreadedConnection::CThreadedConnection(this=0x3a7d020, connection=0x3a7d020)
[11:37:57] [DEBUG] CConnection::CConnection(this=0x3c48020, host='localhost', user='root', passw='****', db='dm', options=0x61ee20)
[11:37:57] [ERROR] CConnection::CConnection - establishing connection to MySQL database failed: #2019 'Can't initialize character set unknown (path: compiled_in)'
[11:37:57] [DEBUG] CThreadedConnection::CThreadedConnection(this=0x3c48020, connection=0x3c48020)
[11:37:57] [INFO] Connection handle with id '1' successfully created.
[11:37:57] [DEBUG] CHandleManager::Create - new handle = 0x614d58
[11:37:57] [DEBUG] mysql_connect: return value: '1' (C:\Users\pilip\Desktop\DeathMatch Server\gamemodes\new.pwn:74)
[11:37:57] [DEBUG] CThreadedConnection::WorkerFunc(this=0x3c48020, connection=0x3c48020)
[11:37:57] [DEBUG] mysql_errno(1) (C:\Users\pilip\Desktop\DeathMatch Server\gamemodes\new.pwn:76)
[11:37:57] [DEBUG] CHandle::GetErrorId(this=0x614d58)
[11:37:57] [DEBUG] CConnection::GetError(this=0x62a440, connection=0x638928)
[11:37:57] [DEBUG] CHandle::GetErrorId - return value: true, error id: '2019', error msg: 'Can't initialize character set unknown (path: compiled_in)'
[11:37:57] [DEBUG] mysql_errno: return value: '2019' (C:\Users\pilip\Desktop\DeathMatch Server\gamemodes\new.pwn:76)

I think the problem is that your plugin is not designed for this version of mysql.

It works with MySQL 8.0.12 that I have installed. Open my.ini and set character-set for mysql server and client:
[client]
default-character-set = utf8mb4

[mysql]
default-character-set = utf8mb4

[mysqld]
character-set-client-handshake = FALSE
character-set-server = utf8mb4
collation-server = utf8mb4_unicode_ci

Restart mysql service and try to connect.

I think the problem is that your plugin is not designed for this version of mysql.

It works with MySQL 8.0.12 that I have installed. Open my.ini and set character-set for mysql server and client:
[client]
default-character-set = utf8mb4

[mysql]
default-character-set = utf8mb4

[mysqld]
character-set-client-handshake = FALSE
character-set-server = utf8mb4
collation-server = utf8mb4_unicode_ci

Restart mysql service and try to connect.

Thank you. After going through another problem, the connection was successful.

Try using an older version of MySQL, for example 5.6

I think the problem is that your plugin is not designed for this version of mysql.

It works with MySQL 8.0.12 that I have installed. Open my.ini and set character-set for mysql server and client:
[client]
default-character-set = utf8mb4

[mysql]
default-character-set = utf8mb4

[mysqld]
character-set-client-handshake = FALSE
character-set-server = utf8mb4
collation-server = utf8mb4_unicode_ci

Restart mysql service and try to connect.

If you encounter this error on a Linux machine, locate the "my.cnf" configuration file. In my case, I found it at "/etc/my.cnf." You can use the "find / -name my.cnf" command to search for it. Append the statements mentioned above, save the file, and then restart MySQL .


Running Prettier in build workflow; triggering eslint & test after build

#528  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @CatChen and the rest of your teammates on  Graphite


Search workspace folder for config files

Fixes #195
If we are using the file wizard from al-code-outline and we are working with a workspace the settings inside the .vscode/settings.json are not taken into account.
PS: I would have expected vscode.workspace.getConfiguration(this.WORKSPACEKEY, null); to retrieve all merged configurations by default, not just the default values.

Thanks so much!


cairo: Don't leak user data if setting it failed

Fixes https://github.com/gtk-rs/gtk-rs-core/issues/740

You're calling an unsafe function outside an unsafe block apparently.


[Feature Request] Enable description tag for tests

Is your feature request related to a problem? Please describe.
dbt expectations are often more specific and complex than dbt generic tests. While dbt generic tests allow a description field for tests, dbt expectations tests don't allow this tag.
Describe the solution you'd like
A dbt expectations test should support a test tag. This would allow the text to be populated in the description section of dbt explore and the docs generate artifacts.
Describe alternatives you've considered
Enriching the model descriptions is not ideal, custom tags or meta flags are not as visible in dbt explore.
Additional context
Test descriptions help easier debugging and evaluating test failures across the entire teams with much more context.

Hi @ChrisGutknecht, thanks for pointing this out. I'm not familiar with the test tag feature. How would we implement this for our tests?

Thanks @clausherther.
Generic tests can be enhanced like this:
columns:
      - name: order_id_awin
        description: the order id generated by Awin, not the ishop identifier. Used to directly amend the order
        meta:
          primary-key: true
        tests:
          - not_null:
              description: >
                Every Awin order should have a Awin-based identifier.
                If not, it is a rare edge case or might be a manual import.

Currently we can only enhance dbt expectation tests like this with comments:
    - name: sale_amount_awin
      description: the net amount after return adjustments or cancellations
      tests:
        - not_null
        # alert sale amount values below 1
        - dbt_expectations.expect_column_values_to_be_between:
            min_value: 1
            row_condition: "awin_date between date_sub(current_date(), interval 7 day) and date_sub(current_date(), interval 1 day)" # (Optional)
            config:
              severity: warn
              warn_if: ">5"
        # alert very high sale amount values, which might indicate fraud
        - dbt_expectations.expect_column_values_to_be_between:
            max_value: 5000 # (Optional)
            row_condition: "awin_date between date_sub(current_date(), interval 3 day) and date_sub(current_date(), interval 1 day)" # (Optional)
            config:
              severity: warn

Currently, the important "why" context is added in comments, but these comments can not be surfaced beyond the code layer such as dbt explore. Ideally we could do:
    - name: sale_amount_awin
      description: the net amount after return adjustments or cancellations
      tests:
        - not_null
        - dbt_expectations.expect_column_values_to_be_between:
            description: alert sale amount values below 1
            min_value: 1
            row_condition: "awin_date between date_sub(current_date(), interval 7 day) and date_sub(current_date(), interval 1 day)" # (Optional)
            config:
              severity: warn
              warn_if: ">5"

        - dbt_expectations.expect_column_values_to_be_between:
            description: alert very high sale amount values, which might indicate fraud
            max_value: 5000 # (Optional)
            row_condition: "awin_date between date_sub(current_date(), interval 3 day) and date_sub(current_date(), interval 1 day)" # (Optional)
            config:
              severity: warn

Does that make it more clear?

That makes sense re: usage, but I'm not sure how that would be implemented in each test. Does that mean each test has to take a description param and somehow pass that to dbt?

e.g. I don't see dbt_utils implementing anything like that?
https://github.com/dbt-labs/dbt-utils/blob/main/macros/generic_tests/unique_combination_of_columns.sql

Yes, that's true. Unfortunately, as I just realized, dbt generic tests allow a description field in the compile stage, but it throws an error in the dbt test stage. My bad. I will have to check if there's a dbt core issue for this. The weird thing is that the dbt explore section in Cloud has a very visible description field for every test, but does not actually support it.
At least for us, an optional description flag would be helpful to add more business context.
We currently forward these test tables to microsoft teams for daily test resolution, but the long names are hard to read.


[stress testing][s] Invert -Login and -PushImages parameters

For the most common use case of the stress test deployment script (which is to log in and push images), we should make this the default behavior when invoked with no parameters.
For example, -SkipLogin and -SkipPushImages instead.

Closing.  At this point if we haven't done this, we're not going to.  Small request, but we're pretty sure people have gotten used to how this script works and changing it's behavior might cause problems.


Error: @prisma/client did not initialize yet

Bug description
01.08 18:37:26 [Bot] 01/08/23 19:37:26  [[ERROR]] Error: @prisma/client did not initialize yet. Please run "prisma generate" and try to import it again.
01.08 18:37:26 [Bot] In case this error is unexpected for you, please report it in https://github.com/prisma/prisma/issues
01.08 18:37:26 [Bot] at new PrismaClient (/node_modules/.prisma/client/index.js:5:11)
01.08 18:37:26 [Bot] at Client.login (/src/client.js:59:17)
01.08 18:37:26 [Bot] at Object.<anonymous> (/src/index.js:73:8)
01.08 18:37:26 [Bot] at Module._compile (node:internal/modules/cjs/loader:1267:14)
01.08 18:37:26 [Bot] at Module._extensions..js (node:internal/modules/cjs/loader:1321:10)
01.08 18:37:26 [Bot] at Module.load (node:internal/modules/cjs/loader:1125:32)
01.08 18:37:26 [Bot] at Module._load (node:internal/modules/cjs/loader:965:12)
01.08 18:37:26 [Bot] at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:83:12)
01.08 18:37:26 [Bot] at node:internal/main/run_main_module:23:47

How to reproduce

Expected behavior
No response
Prisma information

// Add your schema.prisma

// Add your code using Prisma Client

Environment & setup

OS:
Database:
Node.js version:

Prisma Version

Did you run prisma generate before this happened?
What version of Prisma are you running?
Can you please fill in the issue template with the information it asks for? Thanks.

i have run prisma generate but got this error even though i have fully installed prisma/prisma client
`PS C:\Users\Juno\Desktop\pebblehost-547279-jvycah\MineTNT Ticket> prisma generate
prisma : The term 'prisma' is not recognized as the name of a cmdlet, function, script file, or operable program. Check the spelling of the name, or if a path was included, verify that the path is
correct and try again.
At line:1 char:1

prisma generate

  + CategoryInfo          : ObjectNotFound: (prisma:String) [], CommandNotFoundException
  + FullyQualifiedErrorId : CommandNotFoundException`

That looks like you do not have a global installation, so you probably need to use npx prisma generate to run this command (or whatever equivalent tool to npx your pacakge manager uses, if you do not use npm).
What version of PRisma are you using? npx prisma -v should output that (or you can look it up in your package.json).

Hey @Jun0vn  ,
Did you get a chance to have a look at @janpio's last comment? It'd be helpful for us to move your issue forward.
Without further information, we'll have to close this issue. Thank you 🙏

Hey @Jun0vn, could you please reply to the comments above? Thank you.

Hi, i ran into the same issue version 5. This info might provide insight:
I was getting this upgrading from 4.16.2 to 5.2.0. When running npx prisma generate, i got the same error:
Error: @prisma/client did not initialize yet. Please run "prisma generate" and try to import it again.
In case this error is unexpected for you, please report it in https://github.com/prisma/prisma/issues
    at new PrismaClient (/xyz/node_modules/.prisma/client/index.js:5:11)
    at new PrismaService (/xyz/fr-platform/node_modules/nestjs-prisma/lib/prisma.service.ts:26:5)
    at Injector.instantiateClass (/xyz/node_modules/@nestjs/core/injector/[inje](injector.js:365:19)

Turns out when i ran npm list @prisma/client that the dependency i used to wrap the client<EMAIL_ADDRESS>) was still using 4.16.2. Dropping the node modules and package lock and reinstalling fixed the issue.
So in short; this was probably caused by the @prisma/client and prisma not having the same version. ( in this case 5.2.0 )

@Erikdegroot89 provided a potential explanation and fix to the problem subject of this issue in https://github.com/prisma/prisma/issues/20484#issuecomment-1697738713
Given the lack of response from the original report we are closing this.


gmx select, append new generated group to input ndx

gmx_select has an optional input named input_ndx_path. The functionality of this bb is exactly the one of the GROMACS select tool: it produces a new index file (ndx) with (only) the newly generated group. It would be really good if the output ndx file could contain not only the new group, but all the groups defined in the input ndx file + the new group (append).

Testing


LinkBuilder can be chained.

Hi Luke,
since LinkBuilder is a fairly simple class, maybe this was intentionally skipped, but I thought I’d mention it anyway:
I personally would expect to be able to chain a builder instance (just like in the Effective Java 2nd Edition, Item 2). With a simple change that shouldn’t break any existing functionality, we could now do
new LinkBuilder(demoText)
    .addLinks(getExampleLinks())
    .addLink(someOtherLink)
    .addLink(andMaybeAnotherLink)
    .build();

It’s more of a syntactical sugar than anything else. Let me know what you think.
Cheers,
Tadej

Done, thanks for the help! I see no reason why something like this shouldn't be done.


onnx not working

The example I'm using is BallChase
Training with just gdrl works well. Though when I try to use the onnx that came with the project it doesn't work.
I tried the following file paths:

res://BallChase.onnx
BallChase.onnx
res://BallChase
BallChase
~/Desktop/BallChase/BallChase.onnx
~/Desktop/BallChase/BallChase

I tried it with JumperHard and it doesn't work there too.
This is a macOS m2 though I tried this in Windows and it still doesn't work.
dotnet --version 6.0.410
godot: 4.1.beta2.mono (tried 4.0.3.mono)
Is there any additional dependencies that I have to download to make it working?
Here's the video of the error.
https://github.com/edbeeching/godot_rl_agents/assets/132185397/b0bbda8f-1b08-468d-8bd9-9b6373973099
(Also I couldn't ask help in the discord server because I couldn't find the invite link. (Is there even one?))

Hi, here is the link for the discord
The path should just be BallChase.onnx, but it seems you have tried that.
The issue may be due to you GPU type, is it an AMD GPU? Perhaps this PR on the plugin will resolve the issue?

The Windows laptop has an RTX 3060 though I couldn't test it with the PR yet.
I used the BallChase example from the PR with macOS m2, and it says "OS not supported" but it works! Well, after a few seconds the ball stops going for the goal and moves back and forth repeatedly but I guess that's my problem.
Thanks a lot for the help, I really appreciate it!

Hello,
I've just made another commit to the repo: https://github.com/edbeeching/godot_rl_agents_examples/pull/6/commits/c25275ca38bf2e30498d588cdeb7d7b65dd6aa91 where I changed the "OSX" part to also check for the new enum instead of the integer value.
Now in case of the system being detected as "OSX" it will try to use "CoreML". The code mentions that this needs testing, so it may or may not work now. If possible please re-test to check if the newest commit still works. If it doesn't work yet, perhaps it can be changed to use the CPU.

Sorry, my bad, I didn't provide any extra information of the error. Here's the video testing BallChase with macOS.
https://github.com/edbeeching/godot_rl_agents/assets/132185397/57e71d34-3bcf-43c9-9848-bc36b478cc65
Also somehow testing the same thing in Windows (RTX 3060) doesn't work at all, though it's probably just my computer being weird.
So I guess we can close the issue!

I am glad you got it running.
As for the agent's behavior, I have seen this before. Where it gets stuck behind a wall and bobs back and forth, essentially a local minima. Perhaps more training would resolve this, or a memory-based agent.
I will close the issue for now, but let me know if you resolve the problem with running the onnx model on your Windows machine, as I am sure other will face the same problem in the future.


Document Linux dependencies

While using the GitHub CI, I found out that some Linux dependencies have to be installed:

libpango1.0-dev
libatk1.0-dev
libgtk-3-dev

Please put this info somewhere in the README.

In our CI it only installs GTK, as GTK depends on ATK and Pango.

Good to know. I'm not so familiar with these details.

Done, thanks for the report!


As a developer, I need to implement node status rpc required for frontend

Implemented status rpc. Only thing missing is:

[ ] peer bandwidth usage.


Add build to avoid using regexpu-core in runtime

This PR moves regexpu-core to be a dev dependency to save 380k when creating a web bundle by transpiling the usages in build time.
Also might have a minor speed up at initialization time.
Fixes #22

Codecov Report

Merging #23 into master will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master       #23   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            5         7    +2
  Lines          187       195    +8
=========================================
+ Hits           187       195    +8

Impacted Files
Coverage Δ

lib/parse.js
100.00% <100.00%> (ø)

lib/stringify.js
100.00% <100.00%> (ø)

lib/uni-regexp.js
100.00% <100.00%> (ø)

scripts/build-regexpu.js
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a6cb09...5f438f9. Read the comment docs.

heya @evilebottnawi, any chance you could check this optimization out?
It makes css-selector-tokenizer much smaller when bundled for browser usage, and with less transitive runtime dependencies.

@geelen we'd really appreciate it if someone can review and merge or comment on this PR.

@sokra @evilebottnawi I would appreciate if someone could take a look on this PR. We are currently using a work around to avoid the huge size increase.

@barak007 Where we use this module? Wi migrate on postcss and postcss-selector-parser

@evilebottnawi we are using it in several places in https://github.com/wix/stylable
This PR solves a size regression that affects anyone who bundles css-selector-tokenizer and runs it inside the browser. It probably also improves the evaluation time of the package.

Yes, it can be a patch release. :+1:

Done, 0.7.3 is released


permissions-manager

Hi,
sorry for my late response here, thanks for merging in the secret part for the permissions manager chart ( https://github.com/devopstales/helm-charts/pull/12 ). I've finally had the time to start testing the chart but it seems it hasnt been published properly?
❯ helm repo add devopstales https://devopstales.github.io/helm-charts
"devopstales" has been added to your repositories
❯ helm repo update
Hang tight while we grab the latest from your chart repositories...
[output of other repos removed]
...Successfully got an update from the "devopstales" chart repository
❯ helm pull devopstales/permission-manager --untar
Error: chart "permission-manager" matching  not found in devopstales index. (try 'helm repo update'): no chart version found for permission-manager-
❯ helm search repo devopstales
NAME                             	CHART VERSION	APP VERSION	DESCRIPTION
devopstales/kube-openid-connect  	1            	1.16.0     	A Helm chart for Kubernetes
devopstales/kuberos              	0.2.1        	2018-07-03 	An OIDC authentication helper for Kubernetes
devopstales/pushprox             	0.1.4        	0.1.0      	Sets up a deployment of the PushProx proxy and ...
devopstales/trivy-image-validator	1.0.2        	1.16.0     	A Helm chart for trivy-image-validator Admissio...
devopstales/trivy-operator       	2.3.2        	1.16.0     	A Helm chart for trivy-operator
devopstales/trivy-scanner        	1.0.2        	1.16.0     	A Helm chart for trivy-scanner

it doesnt seem to show up for me (the artifacthub page also doesnt show the version with the changes i sent via the PR.
any advice?

@loeken There was a problem with my CI/CD pipeline so the package did not published. Now its working fine:
helm search repo devopstales
NAME                             	CHART VERSION	APP VERSION	DESCRIPTION
devopstales/kube-openid-connect  	1.1.0        	1.0.0      	A Helm chart for Kubernetes
devopstales/kuberos              	0.2.1        	2018-07-03 	An OIDC authentication helper for Kubernetes
devopstales/permission-manager   	1.8.0        	1.7.1-rc1  	Web UI for ServiceAccount RBAC manager
devopstales/pushprox             	0.1.4        	0.1.0      	Sets up a deployment of the PushProx proxy and ...
devopstales/trivy-image-validator	1.0.2        	1.16.0     	A Helm chart for trivy-image-validator Admissio...
devopstales/trivy-operator       	2.3.2        	1.16.0     	A Helm chart for trivy-operator
devopstales/trivy-scanner        	1.0.2        	1.16.0     	A Helm chart for trivy-scanner


[Feature Request] Use Oracle JDK instead of Open JDK

Is there is an explicit reason to use Open JDK instead of Oracle JDK?
Oracle JDK is showing much better performance now, it's might be a good idea to use an Oracle version.

Hi @abilun
By saying Oracle JDK, did you mean using oracle/openjdk as the base image? The original reason I use OpenJDK instead of Oracle JDK might because there wasn't an oracle JDK image for me when I started this project. However, I have a look at the oracle/openjdk since you mentioned it. I found the size of the image is bigger because java-1.8.0-openjdk-devel is used and it's based on oraclelinux which means I have to use yum to install extra packages. I'm not a big fun of the yum. And I don't want to install jre in my own image because I have no time to deal with the upgrade of java.
About the better performance of Oracle JDK, would you please give me some references because I really don't know that.


Improved the styling for bot editing modals

PR for issue#21410: Improve styling for bot editing modals

In this PR the font style and appearance are made consistent through edit bot(personal) and manage bot(org) settings.
First, commit :

Font style is made consistent.
added consistent spacing between components.

Second commit :

Spacing to avatar component(because it was left out in the previous commit).

Screenshots and screen captures:

Self-review checklist

[x] Self-reviewed the changes for clarity and maintainability
(variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

[ ] Explains differences from previous plans (e.g., issue description).
[ ] Highlights technical choices and bugs encountered.
[ ] Calls out remaining decisions and concerns.
[ ] Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

[x] Each commit is a coherent idea.
[x] Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

[x] Visual appearance of the changes.
[ ] Responsiveness and internationalization.
[ ] Strings and tooltips.
[ ] End-to-end functionality of buttons, interactions and flows.
[ ] Corner cases, error conditions, and easily imagined bugs.

Tested this PR on current Firefox on Linux - works as expected and claimed. In both modals the style is now unified according to expectations.

Great, thanks! @ganpa3 would you be up for reviewing this one as well?

@ganpa3 I made the necessary changes.
let me know if there are any other changes.

@om2137 You need to create a new branch when creating a pull request instead of pushing the main branch.

@om2137 You need to create a new branch when creating a pull request instead of pushing the main branch. Otherwise, LGTM.

ok so I should switch from om2137/main to some other branch and open new PR right?

opened a new pr #22581


cannot output specific layer

When I am trying to plot a single layer, using the exact same line of code as provided by the author, it is somehow showing only a red picture. I typed the coding in Visual Studio Code as below:
import os
os.system('py gcode_reader.py -t 1 octo.gcode -l 1')
However, the output is as below:

It is the same no matter which layer I specified. The output is the same as above even if I changed to the 40th layer.
What may be wrong? I would appreciate any help.

I might add that when plotting the example octo.gcode in 3D, it is showing the same result as the example.
However when using animation, it is showing the below error:
gcode_reader.py: error: argument -a/--animation: expected one argument
Only the plot 3D is working for me. Should there be anything that I need to tune in the code before using it? I am grateful for any help!


Switch from bincode to json

Bincode is a schemaful format. However, our Value depends on the format itself to provide type info. We may migrate to json. And we may use serde_json::Value instead of our hand-made format.

@George-Miao What's your thought? Should we migrate to json and replace our Value with serde_json::Value?

@George-Miao What's your thought? Should we migrate to json and replace our Value with serde_json::Value?

If that is possible, always consider using a mature crate first.

Closed by #23 .


Internalize structs and methods meant for being exposed through codegen

or that interface with core and are only for internal use
Cherry pick #11572.

[trickle] No significant performance differences

[microbenchmarks] No significant performance differences

Resolved in #13107


coregestration on data subsets

Currently coregistration only works only on global data (the toolbox reports about it). Can we also get coregistration for subsets?

This is indeed a very hard constraint, also because it is unefficient to force users to first coregister global data and then do the subsetting.


VK_KHR_descriptor_update_template: The truth is out there

It's hard to properly describe problem I had faced, but in general some prefixes stopped working after this feature was introduced.
For example I tested custom build w/ wine 3.4 and vulkan from staging 2.21 and than different builds from nightly https://haagch.frickel.club/files/dxvk/ also changing default vulkan loaders:

I have cube.exe as etalon test so I believe both implementations are working
I have working superposition.exe benchmark with latest nightly dll and wine 3.4
The Witcher 3 fails with latest commits, only working ones is pre  0f800c6c51bec73da301ba83097ef3491b3cc602 for both 2.21 and 3.4
Vulkan from 2.21 have no *DescriptorUpdateTemplate* stubs or omplementation, so I understand it CAN fail, but not sure it should
#ifdefs from src/dxvk/vulkan/dxvk_vulkan_loader.h have no desired (?) effect, cause you use ./include/vulkan/ where those defined but e.g. NOT implemented in NVIDIA drivers <=378.xx (http://vulkan.gpuinfo.org/listreports.php?extension=VK_KHR_descriptor_update_template&option=not) and I believe it's ok
I'm still not sure exactly this commit changed everything, cause I tried to revert this and tw3 still fails

So I have only working setup for both  superposition.exe and witcher3.exe is $ git reset ebd46e41098dff8f25bb930fe07c867e71327307 and using vulkan from staging 2.21.
Logs:
tw3, nightly and wine 3.4 :
err:   ExtensionSet::addInstanceExtensions: Failed to query instance extensions
002f:err:dbghelp:pe_load_msc_debug_info -Debug info stripped, but no .DBG file in module L"d3d11"
002f:err:dbghelp:pe_load_msc_debug_info -Debug info stripped, but no .DBG file in module L"dxgi"
...
err:   ExtensionSet::addInstanceExtensions: Failed to query instance extensions

tw3, custom,  wine 3.4 and vulkan from staging 2.21:
002f:fixme:vulkan:vkGetDeviceProcAddr missing function "vkCreateDescriptorUpdateTemplateKHR"
002f:fixme:vulkan:vkGetDeviceProcAddr missing function "vkDestroyDescriptorUpdateTemplateKHR"
002f:fixme:vulkan:vkGetDeviceProcAddr missing function "vkUpdateDescriptorSetWithTemplateKHR"
002f:fixme:vulkan:vkGetDeviceProcAddr missing function "vkCmdPushDescriptorSetWithTemplateKHR"
...
warn:  DxgiFactory::MakeWindowAssociation: Ignoring flags

p.s. superposition.exe and  witcher3.exe (and cube.exe) the only 64bit apps I have due to non working 32bit setup for custom build, so tests are often based on those ones.
p.s.2. please stop me from implementing *DescriptorUpdateTemplate* for outdated vulkan from staging 2.21, current vulkan implementation in wine 3.4 seems still not working good in some cases.

That commit did indeed break compatibility with 2.21-staging, didn't know that people were still using that. The issue here is that the old 2.21-staging implementation does not filter out unsupported extensions, if it did, you'd be getting an error message.
I'd recommend moving on to 3.4-staging if 3.4-mainline doesn't work. That's what I'm currently using for development as well.

I am on 3.4-staging, but using switcher for old implementation for testing purposes.
I even adjusted staging winecfg for quick change this like:

Both are working via DllRedirect feature (vulkan*-st.dll and d*-vk.dll).

https://github.com/pchome/wine-playground/tree/master/patches - here the patches I used for 3.4-staging.
DXVK I compiled have dll-redirect support (maybe cause I linked to dxgi-vk.dll and paired with dxgi.dll redirect ... not completely sure about this).

Current release v0.40 + wine-staging-3.4 patched w/ pending upstream vulkan-1 patches works for both superposition and TW3, so closing.


Xadrian C++ Conversion

This not much of an issue as it is more of an interest.  I have been doing a personal project in C++ revolving around your software and I am attempting to reconstruct it in a completely different language. I am aware you have given the software for free and anything can be modified just as long as there were conditions. Though the conditions do not say anything about modifying it to another language with its on data structure. What is your policy for that? Thanks in advance.

I don't have a real policy for that. Feel free to do what you want. Translate the Java Code you need to C++, use the XML files or convert them to whatever you need. I'm fine with that. Just don't use the name "Xadrian" in your project name. And it would be nice to get some credits in an About dialog for example. "Inspired by Xadrian", "Based on Xadrian" or something like that. With a link back to the Xadrian website.
Good luck for your project, looking forward to see the results. Hoping it is platform-independent and works on my Linux ;)

I am using Qt, a cross-platform. I am sure Linux should be able to run it just fine. One thing I did find curious is that I found no database in the build. Did you completely build the database with XML/Java properties only?

Yes, all data is held in XML files. They are read once on application start and then I have everything in Java objects in memory. No need for SQL queries or stuff like that.

Do you have a proper control flow chart for your design or did you just do everything on the fly? If so, I'd like to see the chart for a reference. The sector map was quite clever. Did you do that with user interface grid layout and hover over labels?

There is no flow chart, sorry.  And the sector map is rendered completely manual with Graphics2D.

Ah, java based graphics. Hm, I don't think C++ can do that same them but perhaps I could find a proper graphics library.

When you are already using Qt then QPainter is pretty much what Graphics2D is for Java.

I never used that in Qt. I will take a gander at it then. Thanks for the tip.


Support Resource Packs

Description:

Fix template error when only passing a single Spigot Resource
Add chart support for Vanilla Tweaks
Add chart support for server resource pack

Updated!


Electron header and window changes

Added minHeight and minWidth to stop people from resizing it so small it's unusable
Changed the height of the windows minimize icon to prevent it being blurry

also @BronzW your branch is super outdated, please update it

in gonna close this pr in favor of #2518

In favor of my own pr?

In favor of my own pr?

oh lol i meant #2520

And why is that in favor?

If you can't see the difference on these two you are going to need to go to an eye doctor

And why is that in favor?

Your branch is super old, when i tried testing it locally it broke
Few checks were failing
The other pr makes it exactly on the break point of mobile view
There is very little difference between the pictures you have shown

And why is that in favor?

Your branch is super old, when i tried testing it locally it broke
Few checks were failing
The other pr makes it exactly on the break point of mobile view
There is very little difference between the pictures you have shown

I was going to update it, but then you fucking closed it before I was able to.
It was vercel that was ratelimiting it.
I can change it
"Very little difference" doesn't matter, it's polishment and looks nicer.

And why is that in favor?

Your branch is super old, when i tried testing it locally it broke
Few checks were failing
The other pr makes it exactly on the break point of mobile view
There is very little difference between the pictures you have shown

1.

2. It was vercel that was ratelimiting it.

3. I can change it

4. "Very little difference" doesn't matter, it's polishment and looks nicer.

i don't like this tone of yours but anyway keeping that aside, if you can fix the issues then ok ill open this pr but what do i say to the author of #2520?

i don't like this tone of yours but anyway keeping that aside

chill, he is just trying to help

i don't like this tone of yours but anyway keeping that aside

chill, he is just trying to help

did you read what he said?

i don't like this tone of yours but anyway keeping that aside

chill, he is just trying to help

did you read what he said?

yeah i was being rude and i'm sorry


consumer ack: Negative integers are only supported with GMP or BC (64bit) intextensions.

failed to do
$consumer->ack($message);
with error Negative integers are only supported with GMP or BC (64bit) intextensions.
What should I do, what's wrong in the message (or consumer) ? thanks

Hi,
Thanks for your feedback on the Pulsar Client for PHP library. To better understand and address the issue you're experiencing, could you please provide us with the following information:

Sample code that reproduces the issue you're encountering.
The version of Pulsar that you're using.
Details about your runtime environment, including the operating system and PHP version.

@djdance
Based on the error message you provided, it appears to be an error thrown from protobuf-php/protobuf. The error file can be found at: https://github.com/protobuf-php/protobuf/blob/master/src/Binary/Platform/InvalidNegativeEncoder.php.
You may try installing the GMP extension to see if the issue persists. Alternatively, please provide us with your sample code and environment information. Your feedback will help us improve the library.
Thank you for your cooperation!

Thank you, @ikilobyte , but most of all I am interesting in, what's wrong in the message received?
In other words, imagine that I can not install GMP/BC.
How could I change something on my side or in Pulsar to fix this crash?
Change any negative ID in data of a message?
Why do I need this Negative integers for ack? may I turn it off without extra libraries and php reinstalling ?
thanks again

@djdance
Sorry, based on my initial assessment, it appears to be an issue with the protobuf library. In order for me to reproduce the issue, I would need you to provide sample code and Pulsar message IDs. Without this information, I am unable to determine the root cause based solely on the error message.

I understand, no problem.
Let the message contains the following negative values
partition: -1 batch_index: "-1"
Could it be the reason?
How can I get rid of any field from the message before ack?
I didn't find any function to operate message content..


Support for same host duplicated across ingress objects

Hi,
For various reasons I need to have the different paths for a host spread across different ingress objects (mainly to enable http basic-auth on some paths only, since there's no way to set this at the "rule" level and it can only be done using ingress-level annotations)
I couldn't find a way to make kube-lego play nice with this. I do want to share the same certificate/secret for the same host across these different ingress objects, but it complains with :
the secret xxxxxx/default is used multiple times. These linked TLS ingress elements where ignored:
And it then ignores all TLS ingress elements, not just additional duplicates but even the first definition it encounters.
Is there a workaround I'm missing ? Could kube-lego handle duplicates more gracefully maybe (gather the list of hosts/secrets needed across all ingresses, de-duplicate if needed, and request) ?

I was just scared by the complexity of implementing this. It should not be that hard after all, as we are assessing the host information as aggregated information once a change happens

Does it also skip certificates renewal? I am having the same problem :(

Any update on this? Or any place I can help implement it?

I'm running with https://github.com/jetstack/kube-lego/pull/142 in production, for the same use case (multiple ingress objects, each contributing parts of the whole).

Can someone merge #142 ?

Just ran into this today. GKE requires running two separate Ingresses for handling IPv4 and IPv6 traffic, so there are valid scenarios that this overzealous protection is breaking. Guess I'll try cert-manager or #142.

I've just hit this when the certificate expired. I've set the newer ingress to use a different secret and kube-lego seems to have sorted this out (they are the same host). Are there any risks doing this?


Some entries disappear and show up with edited note

It seems some entries appear edited and lose the text in them on their own.
Say we made an entry. The text suddenly disappears and get marked as edited. I can still add comments or edit and add new text. But the original text is missing.

should be closed by #291


include original classification (with feature selection)

To produce the paper results, automatic feature selection was applied. This was removed here, as it is not necessary to draw the same conclusions.
For the sake of reproducibility we might nevertheless add this optionally to this repo.

This is nonsense, I confused the results. Closing therefore.


feat: upstream String.count

I have some files that only depend on Mathlib through this definition... Time to upstream!


Unable to download API page

Checklist

[x] I'm reporting a broken site support issue
[x] I've verified that I'm running youtube-dl version 2021.12.17
[x] I've checked that all provided URLs are alive and playable in a browser
[x] I've checked that all URLs and arguments with special characters are properly quoted or escaped
[x] I've searched the bugtracker for similar bug reports including closed ones
[x] I've read bugs section in FAQ

Verbose log

youtube-dl -v "https://www.youtube.com/watch?v=guznx0W3Y-o"

[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: ['-v', 'https://www.youtube.com/watch?v=guznx0W3Y-o']
[debug] Encodings: locale UTF-8, fs utf-8, out utf-8, pref UTF-8
[debug] youtube-dl version 2021.12.17
[debug] Python version 3.11.2 (CPython) - macOS-14.2.1-arm64-arm-64bit
[debug] exe versions: none
[debug] Proxy map: {}
[youtube] guznx0W3Y-o: Downloading webpage
WARNING: Unable to download webpage: <urlopen error [SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed: unable to get local issuer certificate (_ssl.c:992)>
[youtube] guznx0W3Y-o: Downloading API JSON
ERROR: Unable to download API page: <urlopen error [SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed: unable to get local issuer certificate (_ssl.c:992)> (caused by URLError(SSLCertVerificationError(1, '[SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed: unable to get local issuer certificate (_ssl.c:992)')))
  File "/Library/Frameworks/Python.framework/Versions/3.11/lib/python3.11/site-packages/youtube_dl/extractor/common.py", line 634, in _request_webpage
    return self._downloader.urlopen(url_or_request)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Library/Frameworks/Python.framework/Versions/3.11/lib/python3.11/site-packages/youtube_dl/YoutubeDL.py", line 2288, in urlopen
    return self._opener.open(req, timeout=self._socket_timeout)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Library/Frameworks/Python.framework/Versions/3.11/lib/python3.11/urllib/request.py", line 519, in open
    response = self._open(req, data)
               ^^^^^^^^^^^^^^^^^^^^^
  File "/Library/Frameworks/Python.framework/Versions/3.11/lib/python3.11/urllib/request.py", line 536, in _open
    result = self._call_chain(self.handle_open, protocol, protocol +
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Library/Frameworks/Python.framework/Versions/3.11/lib/python3.11/urllib/request.py", line 496, in _call_chain
    result = func(*args)
             ^^^^^^^^^^^
  File "/Library/Frameworks/Python.framework/Versions/3.11/lib/python3.11/site-packages/youtube_dl/utils.py", line 2735, in https_open
    return self.do_open(functools.partial(
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Library/Frameworks/Python.framework/Versions/3.11/lib/python3.11/urllib/request.py", line 1351, in do_open
    raise URLError(err)

Description

I followed the instruction and tried to download the video above, but it failed.

Normally this is a problem with your system configuration.  To solve the certificate problem on your macOS, use appropriate OS support channels.
Also, for a satisfactory YT download experience when using the work-around or a fixed OS, use the nightly build: review #30839.

@Ericzhihao ?


New Failure: json_run_localhost:cpp_generic_async_streaming_qps_unconstrained_1mps_secure

Test: json_run_localhost:cpp_generic_async_streaming_qps_unconstrained_1mps_secure
Poll Strategy: epollex
URL: https://kokoro2.corp.google.com/job/grpc/job/ubuntu/job/master/job/grpc_basictests_c_cpp_dbg/747

Not seen since 2018-01-02


Don't PING unless nothing has been sent

According to the IRC specification, a PING is only required if nothing has been sent to the server for an unspecified amount of time. In my tests, one minute and 30 seconds has been found to be a good time window for every PING (this might be a server option, though). However, ping() is called even though messages has been sent to the server, which is superfluous.
The ping() function should be changed so that the client only PINGs when it is required: when nothing has been sent to the server for one minute and 30 seconds.

Some kind of clock can easily be implemented with time.hpp from bookwyrm.


[update-checkout] Always update llvm/clang/llbuild

Get rid of the --all flag, since having an out-of-date llvm or clang
can cause build failures, and it's not immediately obvious that
swift/utils/update-checkout isn't updating those repos.

/cc @gottesmm, I can't assign PRs myself.

Thank you! This has tripped me up on more than one occasion.


Fix issues with reading lookahead

Fixes #1036 where encoder would hang at end of video if --limit not
used
Fixes issue where encoder would read too many frames, causing high
memory usage

Coverage increased (+0.7%) to 82.539% when pulling 502e95d6c944bf16de9e7db50c439d5694c90c87 on shssoichiro:lookahead-fixes into 49c4a369cc8ba695c923f6c1b19163984d4bab0b on xiph:master.

Going to merge this for now, to unbreak master. We will follow up on this PR with a better solution.


dubbo2.7.8  broadcast and injvm

Environment

Dubbo version: 2.7.8
Operating System version: windows10 centos7
Java version: 8

Steps to reproduce this issue

i use cluster = broadcast to evict my cache, and i found broadcast was not working
in my case, @DubboService and @DubboReference are in the same application, and this application are running in 3 servers.
dubbo only call which @DubboService in the same java process
i guess it cause by injvm, so i set injvm to false, like @DubboReference(cluster = "broadcast", injvm = false). and it worked. dubbo call services at both local and remote.

and in dubbo 2.7.5, i dont need to set injvm to false, when i want to use broadcast
it happend after upgraded to dubbo 2.7.8

my fault, dubbo 2.7.5 also has this problem

let me have a look.


feat(es/lint): no-restricted-syntax rule implementation

Description:
no-restricted-syntax rule implementation.
This implementation has basic support for airbnb styles compatibility https://github.com/airbnb/javascript/blob/master/packages/eslint-config-airbnb-base/rules/style.js#L333
BREAKING CHANGE:
No

Can you run UPDATE=1 cargo test on the swc crate?

Hmm... I checkout this PR locally using gh and it fails.

Ok. I'll receck it more attentive

Oh, build is failing.
Can you fix it?

Yes. Checking now


AnchorLayout child resizing.

Evaluate if AnchorLayout should resize children, based on left/right & top/lbottom properties.

Take top, right, bottom, left values into consideration when resizing.
Should this also affect internalSize?


UX polishing

Feedback given about poor use of existing styling integrating with XF;

Several places having dark black color used, it should be same grey which XF uses on threads and forum listings. Currently its too bright (and further more if content is read and mismatches with forum UI. You can use the default theme color classes instead of specific color code to provide better compatibility for premium themes.

On forum view it should be short and less distracting, may be a Fa-eye with view counts?

Commas (,) placements are grammatically wrong for username views.

Currently they provide extra space before each comma, it should be only after each comma.
Current format:
User 1 , User 2
How it should be:
User 1, User 2
Take example of user online list of XF index.

On click behaviour

It opens full profile page altogether, it should open member cards just like any XF area.
I am aware on PC it shows last read in a tooltip but that is not the same behaviour on small touch devices. Can at least be the user cards come there?

Counts sizes

It is been multiple times reported to me that the fonts should be little smaller at all parts as they are very distracting from content due to the size and font weight.

What's new page

What's new page having lots of active topics makes the look messy because of the design, just like forum view an fa-eye with view count beside it could suffice.
On hovering over font awesome icon you can provide text: Currently browsing/reading (suitable word according to forum/thread view)

forum view/What's new page and the 'eye' symbol probably should be styleable

@Xon

Several places having dark black color used, it should be same grey which XF uses on threads and forum listings. Currently its too bright (and further more if content is read and mismatches with forum UI. You can use the default theme color classes instead of specific color code to provide better compatibility for premium themes.

Example of the expected header or which others find suitable?

Commas (,) placements are grammatically wrong for username views.

Might need to make use of <xf:trim /> and .listInline.listInline--comma.listInline--selfInline class similar to conversation listing here.

It opens full profile page altogether, it should open member cards just like any XF area.

From quick look it looks notooltip is based on svUserActivityLastSeen style property. Maybe they just need to change that style property?

I am aware on PC it shows last read in a tooltip but that is not the same behaviour on small touch devices. Can at least be the user cards come there?

Wut?

It is been multiple times reported to me that the fonts should be little smaller at all parts as they are very distracting from content due to the size and font weight.

Would would the preferred size be? Or make use of existing font size presets from XF?

On hovering over font awesome icon you can provide text: Currently browsing/reading (suitable word according to forum/thread view)

We are talking about data-xf-init="tooltip" and not the preview overlay right?


Doesn't display value if it is already set when component is mounted.

If the bound value has a default value when the highlightable-input component is created, then nothing gets rendered until the value is changed.
I think you just need to call processHighlights() in mounted()
A workaround is to set the default value in the "mounted()" of the parent component.

I think a cleaner workaround would be to change this watcher:
highlight() {
  this.processHighlights()
}

into
highlight: {
  immediate: true,
  handler() {
    this.processHighlight()
  }
}

Please provide a pull request and I can review/merge.

@natemartinsf I see the commits in your fork. Please feel free to make a PR.

Thanks!


Make results pages

There should be a series (or maybe just a single?) of pages that show previous results for a given season.

The crosstable page (and linked match result pages) fulfill this.


Checking for null value from MSBuild xpath method before accessing it

Checking for null value from xpath method in MSBuild project analysis before accessing its result so we don't get a NullPointerException in case of missing version element or attribute. Also added package references without version to test-project to test for this case in the future.
Fixes Issue
Fixed issue #4770
Description of Change
Concerning MSBuild project analysis:
Added check if version attribute or element was found before trying to access its value (because otherwise this may result in a NullPointerException). This bug was introduced with PR https://github.com/jeremylong/DependencyCheck/pull/4678
Will no longer throw a NullPointerException on missing version element/attribute or if version was written in lower case.
Will however not interpret in any version element or attribute that was written in lower-case.
Note: This is the same behaviour as was observed before version 7.1.2, in the future it would probably be wise to check the MSBuild project file for all the elements and attributes case insensitive. But that would go beyond this bugfix.
Have test cases been added to cover the new functionality?
Yes, PackageReferences without any version have been added to the test-project so test will fail in future if this happenes again.

whoops, sorry, clicked on the wrong button so now I've re-requested an approval? Oo

Thanks for the PR!


[UPDATED] Clarify check of $JS.ACK token count by the libraries

Signed-off-by: Ivan Kozlovic<EMAIL_ADDRESS>

LGTM


Refactor2

[81c97ee]
//as the second for loop only changes the value of map_factor_b and img_out_f,
//to prove that the refactored code is correct, we only need to feed the two parts
//the same input, and check its computed output. For read-only input we can use the same
//address, but for changed varaible, we create a copy of them, img_out_f_copy and map_factor_b_copy
//[Result: the img_out_f(input for original code) is the same as
//img_out_f_copy(input for refactored code) before and after computation.]
//But map_factor_b is different from map_factor_b_copy after computation.


Remove the unused GVRContextProxy class

GearVRf-DCO-1.0-Signed-off-by: Mihail Marinov<EMAIL_ADDRESS>

Was added because of Lua; since Lua has been removed.

Have to update the ScriptManager

Planning to merge on Friday


BDI: When Donation Matching Rules total character limit of 255 is exceeded you can't create batch

If joined characters for all fields set for matching rules add up to more than 255 an error is displayed.
The "Donation Matching Rule" field is currently limited to a length of 255 characters due to its data type being “Text”.
This limits the user when creating batches that use an amount of fields that surpasses the established 255 length character limit.
Steps to reproduce:
1- Open the Wizard from the Batch Gift Entry page.
2- Enter the mandatory and click next.
3- Click next.
4- Click next.
5- Add all available fields under “Donation Matching Rule”.
6- Save.
Expected results:
The site allows the user to save their progress and create the batch.
Actual results:
Save button becomes unresponsive and no error is displayed. The user cant finish creating the batch.
Additional details in WI
Edited by CCE - CO

**lurch: attach W-029955

**lurch: attach W-029955

Tracking W-029955

Salesforce has determined that this issue will not be explored further.


Fix for GROOVY-5247

Fixes issue introduced by GROOVY-5162 (commit c5456c808f0af5a) that causes a NPE when checking for null keys on certain Map implementations (i.e., TreeMap, Hashtable).

Thanks for the fix!


feat(button-roles): rolesets

Members may only have 1 role within a set, this is a very old feature from Skyra that's being removed in v7. However, one major difference falls here that Teryl cannot ensure this rule for users who get the roles through external means (other bots or manually).
This system would be used exclusively for Teryl's button roles, and must work across different messages, so they can be applied for +25 roles.
#235 in #suggestions (linked with #19 and #20).

Closing because upon further evaluation, Discord's Onboarding seems like a very good replacement.


Question about batching dissimilar requests

How does TGI incorporate these 3 types of batching issues? Following is an excerpt from the ORCA paper (copying verbatim here):
There are three cases for a pair of requests where the next iteration cannot
be batched together: (1) both requests are in the initiation
phase and each has different number of input tokens (e.g.,
x3 and x4 in Figure 4); (2) both are in the increment phase
and each is processing a token at different index from each
other (x1 and x2); or (3) each request is in the different phase:
initiation or increment (x1 and x3). Recall that in order to
batch the execution of multiple requests, the execution of each
request must consist of identical operations, each consuming
identically-shaped input tensors. In the first case, the two
requests cannot be processed in a batch because the “length”
dimension of their input tensors, which is the number of input
tokens, are not equal. The requests in the second case have
difference in the tensor shape of Attention keys and values
because each processes token at different index, as shown in
Figure 1c. For the third case, we cannot batch the iterations of
different phases because they take different number of tokens
as input; an iteration of the initiation phase processes all input
tokens in parallel for efficiency, while in the increment phase
each iteration takes a single token as its input.

This should answer your question : https://github.com/huggingface/text-generation-inference/tree/main/router#continuous-batching
If it doesn't please answer here, we'll reopen and make this doc clearer.

We interleave  prefill (first pass) and decode (with past key values). That + continuously adding and removing requests on the fly.

Ah, so the kernels support ragged batching (requests in a batch with different dimensions). Did you have to write a custom kernel to do so?

No, we took flash-attention. Those a re not real ragged tensors, they are real tensors from torch's standpoint. The kernels uses an extra offset tensor to make the correct matmul intra batch.


docs: add size/nfiles fields

You may disregard these recommendations if you used the Edit on GitHub button from dvc.org to improve a doc in place.

❗ Please read the guidelines in the Contributing to the Documentation list if you make any substantial changes to the documentation or JS engine.
🐛 Please make sure to mention Fix #issue (if applicable) in the description of the PR. This causes GitHub to close it automatically when the PR is merged.
Please choose to allow us to edit your branch when creating the PR.
Thank you for the contribution - we'll try to review it as soon as possible. 🙏
Per https://github.com/iterative/dvc/pull/4836

@shcheklein Need to adjust the merge-conflicts guide and that should be about it, i think. Don't see a reason to edit every other doc that has dvc file contents, as that seems not scalable and maybe will even hurt the readablity of those docs.

Don't see a reason to edit every other doc that has dvc file contents, as that seems not scalable and maybe will even hurt the readablity of those docs.

yep, agreed, let's not touch them unless you see some very specific and relevant places (like merge conflicts).

Still WIP? Looks like some really minor things left?

Still WIP? Looks like some really minor things left?

Yes, didn't forget about it. Just didn't get to it yet, will do.

OK but we should at least make an issue for 2.0 updates and add this as a checkbox (to review all .dvc file examples and add these fields where it makes sense).

There is no need to add them everywhere, that would be counter-productive. Adjusted the merge-conficts doc, that should be enough.

p.s. this is a 2.0 change right?

Nope, this is current.

Ok, keeping as-is for now. desc PR will follow shortly.

Oh, force-pushed and overwrote the commited suggestions :man_facepalming: Will adjust inline.


Use couldContainTypeVariables to short-circuit instantiateType

This is particularly impactful for large unions of string literals.

The check could be lifted out to instantiateType to short-circuit the whole call to instantiateTypeWorker, but that was about 1% slower when I ran the material-ui benchmark.  Of course, 1% might be worth it for clearer code.  Thoughts?

Not running the perf test since only unions and intersections are affected.

I intentionally made this a very narrow change.  If we wanted to go broader, we could have instantiateType and couldContainTypeVariable share their tree walks (probably by having instantiateType also return whether it encountered a type variable).  If we wanted to go really nuts, it could also indicate whether the instantiated type contains type variables.  Thoughts?

@weswigham I was surprised that the value didn't seem to be cached in that case.  I think it will be as of https://github.com/microsoft/TypeScript/pull/36947.