Exclude label/unlabel events in GitHub integration (at least optionally)

The GitHub integration sends a message when an issue (or PR, presumably) gets a label added, or a label removed.
This can get extremely spammy. For example see today's messages it sent about the zulip-flutter repo, starting here and running for most of the next 100 messages. (But not all of them! As usual, one consequence of spam is that it becomes easy to miss the other, more interesting stuff.)

I think it's probable that nobody ever actually wants this behavior. One piece of evidence for that: as is, these messages are completely useless.

They repeat the entire issue description.
They don't specify what label it was that was added or removed.

So truly zero people are relying on these messages today; and the lack of clamor to fix them is evidence that nobody is excited about having even an improved version of them.
In principle we could make it configurable whether to include these events. But given that it's probable that nobody actually wants them, I think it'd make sense instead to keep things simple and just skip them entirely.

BTW these events are also spammy even when nobody's going and labeling things en masse. For example, whenever someone opens an issue there's also an event for any labels they add, like here. (That was a label I added before even hitting submit to create the issue — so it's not avoidable by doing that.)

@sbansal1999 making sure you see this issue and https://github.com/zulip/zulip/issues/25793.

This one probably comes up more often. The argument for these events being useless makes sense to me.

Thanks for tagging me on this one! I will add this to my todo list for the week.

So I investigated the webhooks that are sent when labels are added/removed from an issue (or PR). Every time when a label is assigned / unassigned one event is fired. So suppose if in an issue 2 labels were added and 1 other label was removed then we would receive a total of 3 events.

They repeat the entire issue description.
They don't specify what label it was that was added or removed.

I think it's possible to fix both of the above-mentioned problems. So I am not sure if excluding those events at all is really required.
So something like this can be sent when a label is added to an issue:

Issue #9 was labeled bug by sbansal1999.

Let me know what you guys think about this one.

I think a short message like that which doesn't repeat the entire issue description and has the label that changed would likely be worth trying.

Certainly we should do that if we're going to keep sending messages for these events at all. But it wouldn't make them all that much less spammy than they are now — in particular it'd still be the same number of messages on the same occasions. For example:

This can get extremely spammy. For example see today's messages it sent about the zulip-flutter repo, starting here and running for most of the next 100 messages. (But not all of them! As usual, one consequence of spam is that it becomes easy to miss the other, more interesting stuff.)

So I expect that they'd still feel pretty spammy and it'd be better to leave them out entirely.
The fact that these messages are currently as broken as they are is informative because it's evidence that there is literally nobody who is currently relying on them and might be sad if we just removed them.

You are right, the number of messages will still be the same. So some spam would still be there. I will get on and add this to my to-do list.

@zulipbot claim


Phonegap build won't build on 1.6.4

So a build that worked yesterday, same source code, does not work today.
Could not find com.android.support:support-v4:23.4.0
Build Date: 2016-05-25 01:46:57 +0000
FAILURE: Build failed with an exception.
What went wrong:
A problem occurred configuring root project 'project'.

    Could not resolve all dependencies for configuration ':_debugCompile'.
    Could not find com.android.support:support-v4:23.4.0.
    Searched in the following locations:
    https://repo1.maven.org/maven2/com/android/support/support-v4/23.4.0/support-v4-23.4.0.pom
    https://repo1.maven.org/maven2/com/android/support/support-v4/23.4.0/support-v4-23.4.0.jar
    file:/android-sdk/extras/android/m2repository/com/android/support/support-v4/23.4.0/support-v4-23.4.0.pom
    file:/android-sdk/extras/android/m2repository/com/android/support/support-v4/23.4.0/support-v4-23.4.0.jar
    file:/android-sdk/extras/google/m2repository/com/android/support/support-v4/23.4.0/support-v4-23.4.0.pom
    file:/android-sdk/extras/google/m2repository/com/android/support/support-v4/23.4.0/support-v4-23.4.0.jar
    Required by:
    :project:unspecified
    Could not find com.android.support:support-v4:23.4.0.
    Searched in the following locations:
    https://repo1.maven.org/maven2/com/android/support/support-v4/23.4.0/support-v4-23.4.0.pom
    https://repo1.maven.org/maven2/com/android/support/support-v4/23.4.0/support-v4-23.4.0.jar
    file:/android-sdk/extras/android/m2repository/com/android/support/support-v4/23.4.0/support-v4-23.4.0.pom
    file:/android-sdk/extras/android/m2repository/com/android/support/support-v4/23.4.0/support-v4-23.4.0.jar
    file:/android-sdk/extras/google/m2repository/com/android/support/support-v4/23.4.0/support-v4-23.4.0.pom
    file:/android-sdk/extras/google/m2repository/com/android/support/support-v4/23.4.0/support-v4-23.4.0.jar
    Required by:
    :project:unspecified > com.android.support:support-v13:23.2.1
    Could not find com.android.support:support-v4:23.4.0.
    Searched in the following locations:
    https://repo1.maven.org/maven2/com/android/support/support-v4/23.4.0/support-v4-23.4.0.pom
    https://repo1.maven.org/maven2/com/android/support/support-v4/23.4.0/support-v4-23.4.0.jar
    file:/android-sdk/extras/android/m2repository/com/android/support/support-v4/23.4.0/support-v4-23.4.0.pom
    file:/android-sdk/extras/android/m2repository/com/android/support/support-v4/23.4.0/support-v4-23.4.0.jar
    file:/android-sdk/extras/google/m2repository/com/android/support/support-v4/23.4.0/support-v4-23.4.0.pom
    file:/android-sdk/extras/google/m2repository/com/android/support/support-v4/23.4.0/support-v4-23.4.0.jar
    Required by:
    :project:unspecified > com.google.android.gms:play-services-analytics:8.4.0 > com.google.android.gms:play-services-basement:8.4.0

Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.

BUILD FAILED
Version 1.6.3 builds just fine.

@chrisschaub I will ask the PGB team to install 23.4.0 on the build services.

@chrisschaub build guys are going to put 23 onto servers today.

Thanks
On Wednesday, May 25, 2016, Simon MacDonald<EMAIL_ADDRESS>wrote:

@chrisschaub https://github.com/chrisschaub build guys are going to put
23 onto servers today.
—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
https://github.com/phonegap/phonegap-plugin-push/issues/928#issuecomment-221579194

--
Christopher Schaub
http://chris.schaub.com

Same problem for me... I'll wait patiently :-)

use spec="1.6.3" in your plugin line in config.xml
On Thursday, May 26, 2016, stileinverso<EMAIL_ADDRESS>wrote:

Same problem for me... I'll wait patiently :-)
—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
https://github.com/phonegap/phonegap-plugin-push/issues/928#issuecomment-221784947

--
Christopher Schaub
http://chris.schaub.com

Perfect... it works!
Thanks!

@chrisschaub PGB was updated please try rebuilding with 1.6.4.

Now form me it works properly also with 1.6.4


Documentation: File control is missing from side navigation

Describe the bug
File control no longer shows up in the side navigation of the Clarity Code website, but can be accessed through the direct URL.

How to reproduce
Steps to reproduce the behavior:

Go to https://core.clarity.design/core-components/
Observe the sidebar, File Input is no longer present in the list
Visit https://core.clarity.design/core-components/file/ to see the page

Expected behavior
File Input should show up in side navigation
Versions

Clarity Core v6.x

@Jinnie @kevinbuhmann
Looking into the code I don't see any issues with the function that goes through the folders finding the necessary files in order to list the nav item here. Worth checking the netlify build and deploy logs.
Before there were issues with the generator and the fix was rebuild and redeploy.


CT-MR

Hello author, can I use your dataset for experiments now?

Hello author, can I use your dataset for experiments now?

Have you solved this problem? Look forward to your reply. Good luck


TCP support clarification

Type: Feature Request
First, you all have been very busy adding features!!! Thanks. This is me wanting some clarification. I see that you now have TCP port support but the release notes (changelog) indicate that SWO decoding is also supported. I am hoping that

SWO decoding is an option on top of TCP. Technically, SWO can also come through a Serial/tty port for some gdb-servers.
Above means that TCP port can be also be viewed RAW. This can be used for SEGGER RTT via JLink or OpenOCD
I am assuming the TCP port is bi-directional
If the TCP port is closed, will there be any retry attempts? Sometimes, it is an issue of timing and sometimes it is because the debug session ended and a new session started which will close the TCP port for a while

If all of the above is already taken care of then great. If not please consider them as feature requests.

@haneefdm Thanks for the feedback! Answers to your points are below.
First, SWO decoding is in fact an option on top of TCP. You can find the SWO toggle button in the "Additional Settings" (Gear icon). This ties in to your second bullet point, and yes, the tcp port can be viewed raw. (I'd be curious to chat with your about the use case for SEGGER RTT and how that works).
Third bullet point: Yes, the TCP port is bi-directional in the sense that the "Send message" text box works for TCP port as well, so you should be able to send data to the port.
4th bullet point: Currently there is no implementation for retry attempts. However, we are in the midst of implementing this for Serial Ports, and it seems doable to implement a similar feature for TCP ports.
I hope that I sufficiently answered all of your questions! We'd love for you to try out the features and let us know how it goes.
Thanks

Thanks for the response. RTT is like SWO on steroids and very popular. It is free to use both in FW and host tools.
https://www.segger.com/products/debug-probes/j-link/technology/about-real-time-transfer/

To give you a brief summary.
SWO requires you to waste a pin whereas RTT runs on top of the regular SWD pins used for Debug. Advantage of SWO is that it can run independently of an SWD connection as at a pin level, it is just TX UART.
SEGGER provides its own set of GUI tools to connect/view RTT as well but people like to be tied into the VSCode debug experience instead of multiple windows floating around.
The SEGGER Gdb Server and OpenOCD have mechanisms to open one or more TCP ports. There can be up to 16 RTT channels (I think) and with OpenOCD, you can each channel gets to bind to a TCP port. It will look like any other TCP connection. With SEGGER gdb server, you are limited to one channel. There is no need for any decoding. We can treat them as just a console and people used as their preferred STDIN/STDOUT. I sometimes just use netcat to interact.

@haneefdm Great! This is useful information. It sounds like in the context of VSCode (gdbserver and openocd), the tcp support already supports RTT!

Thanks. I am closing this issue since there is nothing outstanding here. Cleanup your queue :-)


[feature request] Support annotated_types.Predicate

I'd like to request that pydantic V2 & pydantic-core add support for annotated_types.Predicate. Though the functionality can be achieved with the @validator decorator, the motivation for including it is the same as supporting the length, and value-comparison annotations -- it lets the developer see the validations that they need to know about for a field without going through the whole model class' implementation.
i.e. A model like the following should be possible:
import sys
from pydantic import BaseModel
from annotated_types import Predicate

if sys.version_info < (3,9):
    from typing_extensions import Annotated
else:
    from typing import Annotated

def lookup_dynamic_length_constraint():
    return 20

func = lambda s: len(s) < lookup_dynamic_length_constraint()

class ErrorModel(BaseModel):
    attr: Annotated[str, Predicate(func)]

It currently raises an error:
# pydantic-2.0.0.dev0 - hash: ef3cc495a9c86553b62a95a6052fd9b6ebc045e9

pydantic_core._pydantic_core.SchemaError: Invalid Schema:
typed-dict -> fields -> attr -> schema -> str -> func
  Extra inputs are not permitted [type=extra_forbidden, input_value=<function <lambda> at 0x7fda9156aee0>, input_type=function]

Ideally, it would support multiple Predicates in an annotation:
class ErrorModel(BaseModel):
    attr: Annotated[str, Predicate(lambda x: ...), Predicate(lambda x: ...), ... etc]

It looks like this support would need to be added in pydantic-core, hence the ticket in this tracker rather than the main pydantic one.
A pydantic-core reproducer for the exception above follows:
from pydantic_core import SchemaValidator

func = lambda s: True
inner_schema = {'type': 'typed-dict', 'fields': {'attr': {'schema': {'type': 'str', 'func': func}, 'required': True}}, 'return_fields_set': True, 'ref': '__main__.ErrorModel'}
core_config = {'title': 'ErrorModel', 'typed_dict_extra_behavior': 'ignore', 'allow_inf_nan': True, 'populate_by_name': False, 'str_strip_whitespace': False, 'str_to_lower': False, 'str_to_upper': False, 'strict': False, 'ser_json_timedelta': 'iso8601', 'ser_json_bytes': 'utf8'}

SchemaValidator(inner_schema, core_config)

# pydantic-core-0.8.2

# Traceback (most recent call last):
#   File "testannotation.py", line 36, in <module>
#     SchemaValidator(inner_schema, core_config)
# pydantic_core._pydantic_core.SchemaError: Invalid Schema:
# typed-dict -> fields -> attr -> schema -> str -> func
#   Extra inputs are not permitted [type=extra_forbidden, input_value=<function <lambda> at 0x7fda9156aee0>, input_type=function]

Moving this to pydantic as I don't think it relates to pydantic-core particularly.

Is Predicate equivalent to pydantic.functional_validators.PlainValidator? If so, it should be straightforward to support by doing something analogous to pydantic.functional_validators.PlainValidator.__get_pydantic_core_schema__.

Support was added in https://github.com/pydantic/pydantic/commit/4985c179d8b9e6488310c77ce71b13cffc942cf7#diff-86a65771e6ad3cc8717cf45416efa0a988c12ddf9224afc222e5317e3a287291. I somewhat arbitrarily made it an AfterValidator, I guess it could have just as easily been a Plain validator. I don't think Before makes much sense and Wrap straight up would not work. I'm open to changing it to Plain if anyone feels strongly about it.


Spyder editor very slow and "laggy"

From<EMAIL_ADDRESS>on 2013-10-28T09:31:56Z
Spyder Version:  2.2.4
Python Version:  2.7.5
Qt Version    :  4.7.4, PySide 1.1.2 on Darwin
pyflakes >=0.5.0:  0.7.3 (OK)
pep8 >=0.6      :  1.4.6 (OK)
IPython >=0.13  :  1.0.0 (OK)
rope >=0.9.2    :  0.9.4 (OK)
sphinx >=0.6.6  :  1.1.3 (OK)
matplotlib >=1.0:  1.3.0 (OK)
sympy >=0.7.0   :  0.7.3 (OK)
pylint >=0.25   :  None (NOK)
What steps will reproduce the problem?

Run up Spyder and type into an existing program 2. 3. What is the expected output? What do you see instead?

Please provide any additional information below
. It seems to slow down in that the editor does not keep up with the normal rate of key presses on the keyboard as you type. There are times when this makes spyder unusable, which is a real shame as spyder is excellent!
Original issue: http://code.google.com/p/spyderlib/issues/detail?id=1622

From<EMAIL_ADDRESS>on 2013-10-28T09:29:44Z
What platform are you on? I have a similar issue from updating mac to mavericks; see issue #1623 .

From<EMAIL_ADDRESS>on 2013-10-28T09:35:09Z
Yes, this is after I updated to Mavericks! :-(

From ccordoba12 on 2013-11-03T06:12:15Z
Status: Duplicate
Mergedinto: 1623


Support infernalis for rh storage

WIP
Signed-off-by: Sébastien Han<EMAIL_ADDRESS>

Wating for #449 to get merged and then I'll rework this piece a little bit.

Struggling with the handlers at the moment...


dmd fails to compile on nixpkgs master

Describe the bug
I have never used d in any way, but when running nixpkgs-review I found its tests are broken.
To Reproduce
Steps to reproduce the behavior:

nix-build -I nixpkgs_overlays=/ -A dmd

Expected behavior
It builds
Screenshots
 ... runnable/gdb1.d                -g -fPIC ()                                                                                [11/6207]
Test runnable/gdb1.d failed.  The logged output:
/build/dmd/generated/linux/release/64/dmd -conf= -m64 -Irunnable -g -fPIC  -odtest_results/runnable -oftest_results/runnable/gdb1_0  runnable/gdb1.d
gdb test_results/runnable/gdb1_0 --batch -x test_results/runnable/gdb1_0.gdb
Breakpoint 1 at 0x401147: file ../../druntime/import/core/internal/entrypoint.d, line 29.
[Thread debugging using libthread_db enabled]
Using host libthread_db library "/nix/store/9l06v7fc38c1x3r2iydl15ksgz0ysb82-glibc-2.32/lib/libthread_db.so.1".

Breakpoint 1, main (argc=3, argv=0x7fffffffbba8) at ../../druntime/import/core/internal/entrypoint.d:29
29                  return _d_run_main(argc, argv, &_Dmain);
RESULT=test_results/runnable/gdb1_0.gdb:5: Error in sourced command file:
No symbol "args" in current context.

==============================
Test runnable/gdb1.d failed: expected rc == 0, exited with rc == 1

make[1]: *** [Makefile:156: test_results/runnable/gdb1.d.out] Error 1
make[1]: *** Waiting for unfinished jobs....
 ... runnable/gdb14225.d            -g -fPIC ()
Test runnable/gdb14225.d failed.  The logged output:
/build/dmd/generated/linux/release/64/dmd -conf= -m64 -Irunnable -g -fPIC  -odtest_results/runnable -oftest_results/runnable/gdb14225_0  runnable/gdb14225.d
gdb test_results/runnable/gdb14225_0 --batch -x test_results/runnable/gdb14225_0.gdb
Breakpoint 1 at 0x4011b4: file ../../druntime/import/object.d, line 2944.
[Thread debugging using libthread_db enabled]
Using host libthread_db library "/nix/store/9l06v7fc38c1x3r2iydl15ksgz0ysb82-glibc-2.32/lib/libthread_db.so.1".

Breakpoint 1, object.dup!(char).dup(const(char)[]) (a=...) at ../../druntime/import/object.d:2944
2944            return _trustedDup!(const(T), T)(a);
RESULT=test_results/runnable/gdb14225_0.gdb:5: Error in sourced command file:
No symbol "lok" in current context.

==============================
Test runnable/gdb14225.d failed: expected rc == 0, exited with rc == 1

make[1]: *** [Makefile:156: test_results/runnable/gdb14225.d.out] Error 1
 ... runnable/gdb10311.d            -g -fPIC ()
Test runnable/gdb10311.d failed.  The logged output:
/build/dmd/generated/linux/release/64/dmd -conf= -m64 -Irunnable -g -fPIC  -odtest_results/runnable -oftest_results/runnable/gdb10311_0  runnable/gdb10311.d
gdb test_results/runnable/gdb10311_0 --batch -x test_results/runnable/gdb10311_0.gdb
Breakpoint 1 at 0x4011bb: file ../../druntime/import/core/internal/entrypoint.d, line 29.
[Thread debugging using libthread_db enabled]
Using host libthread_db library "/nix/store/9l06v7fc38c1x3r2iydl15ksgz0ysb82-glibc-2.32/lib/libthread_db.so.1".

Breakpoint 1, main (argc=1, argv=0x7fffffffbbb8) at ../../druntime/import/core/internal/entrypoint.d:29
29                  return _d_run_main(argc, argv, &_Dmain);
RESULT=test_results/runnable/gdb10311_0.gdb:5: Error in sourced command file:
No symbol "x" in current context.

==============================
Test runnable/gdb10311.d failed: expected rc == 0, exited with rc == 1

make[1]: *** [Makefile:156: test_results/runnable/gdb10311.d.out] Error 1
 ... runnable/foreach3.d            -fPIC (-inline -release -g -O)
 ... runnable/functype.d            -fPIC (-inline -release -g -O)
 ... runnable/foreach5.d            -fPIC (-inline -release -g -O)
 ... runnable/funclit.d             -fPIC (-inline -release -g -O)
 ... runnable/foreach4.d            -fPIC (-inline -release -g -O)
make: *** [Makefile:188: start_runnable_tests] Error 2
make: Leaving directory '/build/dmd/test'

Notify maintainers
@ThomasMader @lionello

Duplicate of #103829


Branch avishkar

Description
I created a script that can encrypt and decrypt text files. It is a CLI tool.
Dependencies - cryptography, argparse
Fixes (#1476)

Type of change

[x] New feature (non-breaking change which adds functionality)

Checklist:

My code follows the style guidelines(Clean Code) of this project
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have created a helpful and easy to understand README.md
My documentation follows Template for README.md
I have added the project meta data in the PR template.
I have created the requirements.txt file if needed.

Project Metadata
none
Example: If no requirements.txt needed/present, then type none in Requirments.
Category:

[ ] Cryptography

Title: \script.py
Folder: \File-Encrypter
Requirements: \requirements.txt
Script: \script.py
Arguments: \ -file_name -encrypt or -decrypt
Contributor: \ avishkararjan
Description: \This is a command-line interface (CLI) tool that provides secure file encryption and decryption functionalities. The tool allows users to encrypt sensitive files using a strong encryption algorithm, making the contents unreadable to unauthorized individuals. Use it like this -
python script.py <file_name> encrypt

Hi could you please give an update as to when can this request be merged? Thnx


Enable the unawaited Futures lint under dev/devicelab

See the discussion on https://github.com/flutter/flutter/pull/82762.
We should also consider enabling the lint for other non-framework code in flutter/flutter just as we already do for flutter_tools.
/cc @jonahwilliams @gaaclarke @dnfield

I can do this quick.  I'm invested to the point where it irritates me.

We may want to enable it for all of dev, but dev/devicelab should be a little easier to manage and cover the cases that are likely to cause problems.


Please add a official plugin for for a good gtk designer

I would like to see a plugin which adds a GTK designer to vs code.

haha no thats gtk themes for vs code not a gtk designer for vs code

I thought vs code extensions couldn't write new GUI?
Also there isn't one on the market place


Add smcFanControl

Fixed issue 397
NOTE: A similar PR may already be submitted! Please search among the Pull request before creating one.
Types of Changes
What types of changes does your PR introduce? Put an x in all boxes that apply

[x] New addition to list
[ ] Fixing bug in existing item in list
[ ] Removing item from list
[ ] Changing structure (organization) of list

Proposed Changes
smcFanControl lets the user set a minimum speed for built-in fans. It allows you to increase your minimum fan speed to make your Intel Mac run cooler. In order to not damage your machine, smcFanControl does not let you set a minimum speed to a value below Apple's defaults.

If you're adding something to the list, be sure to explain why it should be added.
If you're fixing a bug or resolving a feature request, be sure to link to that issue.

PR Checklist
Put an x in the boxes once you've completed each step. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

[x] I have read the CONTRIBUTING guide
[x] I have explained why this PR is important
[x] I have added necessary documentation (if appropriate)

Further Comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

Closing, post discussion in #397


Some people, when confronted with a problem, think "I know, I'll use regular expressions." Now they have two problems.

Yeah. I'll use just the provided Atoi. Now if I look at it, regex is just introducing another unnecessary step

You have the missing parameter error twice in the code, that seems not necessary.

Thats for when the input is only whitespaces, will return an empty array

Thats for when the input is only whitespaces, will return an empty array

Yeah, but you can catch that first, so the else is not needed...


Cannot open a text file, after trying to open a binary file

Repro steps

Build XiEditor.app locally, start it.
Open a binary file thru the open menu. Nothing happens (assume it's not supported)
Try to open any text file.

Expected
You should be able to open text file.
Actually
Nothing happens when you try to open a text file.

This is probably a panic caused by failing utf-8 validation. Grabbing log output would say for sure. In any case, the fix is no doubt to improve error handling, and maybe do something useful - opening the file in a hex mode would be a particularly developer-friendly action.
In any case, this is almost certainly a xi-editor issue rather than xi-mac.

Tried reproducing, got a window without a gutter like I had at some point earlier. Nothing useful in the log file though...

I'm not able to reproduce? When I open a binary I see an error in the console about "failed to load file"  (which doesn't seem to be getting handled correctly) and I get a new blank window that isn't attached to core, but I can still open other windows.
We should definitely be surfacing the error the the user and closing the window, on the xi-mac side. On the core side we should make sure that we're sending the error correctly?

In any case in xi-mac we weren't handling error results at all; I've addressed this in #196. @vors I'd be curious to know what happens when you try that patch?

Hm, indeed I cannot repro it on master anymore: it loads the text file after the failure to load a binary one.
@cmyr thank you, yes, your patch works great

@vors yep definitely room for improvement there, opened an issue in core to track. 😄.


Only read from the context if a reference is prepended with a $

Fixes The Scenic Route. It compares a value against a string literal in its $eq, but that string happens to be the name of some of its (unused) context fields, so the value of that field was read for comparison instead.
Alternatively we can also just delete the unused Context.

This new code that checks for $ is nice, but reading from context vars in an action should also require a $.
So I'd say rename the forAction parameter to something like forWriting, and only pass true to it when referencing a context var that is written to. For example, in addOrDec, the call for variableValue should pass true, but the call for incrementBy should pass false.

Changed as requested.


Design - blue/white checked graphics

Don't much like the blue / white checked graphics for the optional properties panel / tree when they are minimised
By Julian

New design


Image attributes extension is not expected to alter unrelated text nodes

A small fix to prevent the following rendering issue when using ImageAttributesExtension:
{NN} text -> {NN text}

LGTM! @dohertyfjatl please have a look too.

LGTM too! Thanks for fixing!

Released in 0.15.2 (should show up on Maven Central in the next few hours)

Wow, that was fast.
Thanks a ton for merging and releasing it.


Almost 2000 of empty rows in iterator parsing

Description

Steps to reproduce the issue:

Run the code from the https://github.com/renta/excelize_empty_rows

Describe the results you received:
A row with a header information, 20 lines with content and 1980 empty lines.
Describe the results you expected:
Only header and filled rows.
Output of go version:
go version go1.17.11 linux/amd64
I saw a strange behavior on parsing a file: with an iterator a got 21 line with content (header and rows)
and 1980 empty rows. There were no such troubles without the iterator  with `GetRows` method,
but I do not want to use it because of unpredictable size of files that my service could get.

My questions are:
 - what is a limit for empty content after which iterator will stop?
 - are there any workaround to reduce this limit in a client code (like "stop after the 3-rd empty line")?
 - why there are no such problems with `GetRows` method?

I understand that I can easily create this behavior by counting the empty rows and breaking the iteration
after the second empty line (for ex.) but maybe there are Excelize way to do it?

Excelize version or commit ID:
v2.6.0

Environment details (OS, Microsoft Excel™ version, physical, etc.):
Linux, Libre Office Version: <IP_ADDRESS>

Thanks for your issue. The Rows function fetches the worksheet data as a stream and returns each row as is. If you want to skip empty rows in the tail of the worksheet, please use the GetRows function.

@xuri The problem with GetRows and huge files that this method will put all the data in the memory which is very dangerous for unlimited size uploads. I suppose that the approach with counting empty rows and stopping the iterator on some limit will solve the problem.

Could you define a variable to flag the latest no-empty row's number, and check the length of the row before assigning it to this variable. After iteration of all of the rows in a worksheet, you will get it.

I have updated documentation of the Columns function and added a notice about this behavior. I'll close this issue, if you have any questions, please let me know to reopen this anytime.


Conf: add Sepolia addresses

See for the reference:

https://docs.lido.fi/deployed-contracts/sepolia/
https://github.com/lidofinance/lido-dao/pull/820

LGTM


elixir using latin1 locale instead of utf8 even with glibcLocales

Describe the bug
In a fresh project with only pkgs.glibcLocales and elixir enabled , running iex warns about using latin1 instead of utf8:
$ iex --version
Erlang/OTP 25 [erts-13.1.4] [source] [64-bit] [smp:12:12] [ds:12:12:10] [async-threads:1] [jit:ns]

warning: the VM is running with native name encoding of latin1 which may cause Elixir to malfunction as it expects utf8. Please ensure your locale is set to UTF-8 (which can be verified by running "locale" in your shell)
IEx 1.14.3 (compiled with Erlang/OTP 25)

This works in an older project I have though, so I'll attach two gists only differing by the devenv.lock.
Guessing something changed between nixos-22.05 and nixos-22.11?
Not sure how to fix on my end other than modifying the devenv.lock, though.
To Reproduce
Broken:  https://gist.github.com/pikdum/93a1df7ca19392d7c0dc3092064e5883
Working: https://gist.github.com/pikdum/2e1d311de30f8ce5879dc5989dc917c6
Version
$ devenv version
devenv: 0.5.1

@pikdum, what does locale output when you run it in your shell?

$ locale
LANG=en_US.UTF-8
LANGUAGE=
LC_CTYPE="en_US.UTF-8"
LC_NUMERIC="en_US.UTF-8"
LC_TIME="en_US.UTF-8"
LC_COLLATE="en_US.UTF-8"
LC_MONETARY="en_US.UTF-8"
LC_MESSAGES="en_US.UTF-8"
LC_PAPER="en_US.UTF-8"
LC_NAME="en_US.UTF-8"
LC_ADDRESS="en_US.UTF-8"
LC_TELEPHONE="en_US.UTF-8"
LC_MEASUREMENT="en_US.UTF-8"
LC_IDENTIFICATION="en_US.UTF-8"
LC_ALL=

Weird! Your "broken" gist works fine on my machine. And your locales don't look out of the ordinary either.
What does echo $LOCALE_ARCHIVE say?

Looks unset.
$ echo $LOCALE_ARCHIVE

Interesting! Last idea: what if you set LOCALE_ARCHIVE to the archive provided by glibcLocales?
{ pkgs, ... }:
{
  packages = [ pkgs.glibcLocales ];
  languages.elixir.enable = true;

  env = {
    LOCALE_ARCHIVE = "${pkgs.glibcLocales}/lib/locale/locale-archive";
  };
}

Neat, looks like that fixes it:
$ iex --version
Erlang/OTP 25 [erts-13.1.4] [source] [64-bit] [smp:12:12] [ds:12:12:10] [async-threads:1] [jit:ns]

IEx 1.14.3 (compiled with Erlang/OTP 25)

What distro are you using by the way?

Pop!_OS 22.04

@domenkozar, should we check $LOCALE_ARCHIVE and friends when launching the shell? NixOS sets this by default, but we might see weirdness like this in other distros.
I imagine glibcLocalesUtf8 is a smaller closure:
export LOCALE_ARCHIVE="${pkgs.glibcLocalesUtf8}/lib/locale/locale-archive"

3MB, let's just add those by default!

glibc and locales
Source: https://nixos.org/manual/nixpkgs/stable/#locales

To allow simultaneous use of packages linked against different versions of glibc with different locale archive formats, Nixpkgs patches glibc to rely on LOCALE_ARCHIVE environment variable.
On non-NixOS distributions, this variable is obviously not set. This can cause regressions in language support or even crashes in some Nixpkgs-provided programs. The simplest way to mitigate this problem is exporting the LOCALE_ARCHIVE variable pointing to ${glibcLocales}/lib/locale/locale-archive. The drawback (and the reason this is not the default) is the relatively large (a hundred MiB) size of the full set of locales. It is possible to build a custom set of locales by overriding parameters allLocales and locales of the package.

Locales on non-NixOS hosts
Source: https://nixos.wiki/wiki/Locales

You may need to set the environmental variable LOCALE_ARCHIVE to point to your system's locale-achive. The following can be added to your .zshenv (zsh) or .profile (bash) and applies to Debian, Red Hat, and Arch derivatives:
export LOCALE_ARCHIVE=/usr/lib/locale/locale-archive


This page should call out why we should use the UPN instead of domain\name format

https://docs.microsoft.com/en-us/powershell/exchange/exchange-server/connect-to-exchange-servers-using-remote-powershell?view=exchange-ps#connect-to-a-remote-exchange-server
In this page it says to use UPN format when providing a credential, which is uncommon.  It shoudl explain why we need to do this.

@officedocsbot assign @yogkumgit

@1RedOne, my guess is it has something to do with Kerberos authentication, but that's just a guess. Also unusual is requiring http, not https in the second step, which is also called out, but not explained.
I'm not sure I agree that the 'why' is terribly important; it just adds more text to the topic. The fact that it is called out that you must use the UPN value is what's important. But, I'm open to comment/criticism on this point.

Thank you for your reply @chrisda!

@chrisda  and @dariomws306  Thank you very much for the contribution and sharing this explanation. @1RedOne Hope this comment is helpful for you. Thanks for taking out some time to open the issue. Appreciate and encourage you to do the same in future also.

@officedocsbot close


Error: [$injector:unpr] Unknown provider: $cordovaToastProvider

I cant get this to work. I get the following error:
Error: [$injector:unpr] Unknown provider: $cordovaToastProvider <- $cordovaToast <- createNewCtrl
http://errors.angularjs.org/1.4.3/$injector/unpr?p0=ordovaToastProvider <- %24cordovaToast <-%createNewCtrl
I have injected $cordovaToast into my controller.
angular.module('myApp', [])
.controller('MyController', ['$cordovaToast', function ($cordovaToast) {
// Do something with $cordovaToast
}]);
Any ideas how to fix this?

That's not an error related to this plugin, rather an indication you're not loading ngCordova.


create classification module

Reference Issues/PRs

Addresses #150
What does this implement/fix? Explain your changes.
Create a folder structure for the new classification module to add future network classification code.
Any other comments?

Codecov Report

Merging #266 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #266      +/-   ##
==========================================
+ Coverage   87.48%   87.49%   +<.01%
==========================================
  Files          33       33
  Lines        1950     1951       +1
==========================================
+ Hits         1706     1707       +1
  Misses        244      244

Impacted Files
Coverage Δ

graspy/__init__.py
100% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d474f7f...0e20e80. Read the comment docs.

Going to close, can add when the classification code is done.
Also think graspy.classify is more consistent with the naming scheme


Fine tune VirtualService mutation

Remove mirror
Remove weight
Remove non targeted Destinations from route
Remove Redirect
Add headers to each existing match

Requires changes to #71 (target subset)


use platform.python_implementation() instead of platform.system()

The platform.system() function uses os.popen() to call "uname" system command. It could mislead upstart to find the real daemon process since the unexpected forking.

This seems good to me, thanks for the change. :+1: Once CI turns green I'll merge it.

Why close this Pull Request?

I thought it would be merged by closing.

I've got to merge it first then you can close :) it'll turn purple and say Merged.

Thanks! :tada:


docs: Fix Firecrawl v0 version in the docs

Firecrawl integration is currently on v0 - which is supported until version 0.0.36.
@rafaelsideguide is working on a pr for v1 but meanwhile we should fix the docs.

Thanks!


hover message option doesn't need how can i remove it .

@Ariful491 2 props below will hide on desktop and touch devices
show-message = false
show-message-touch = false

it's not working.

@Ariful491 will sort it very soon :)

@Ariful491 just tested this, it does work, make sure you put the colon on the prop like below
:show-message="false"
:show-message-touch="false"


Closes #12

Adding Bahian Guitar

Could you please remove the conflicting files from this PR? I accepted a PR from another dev, so you need to pull master from the upstream repo.


[test] Vertically test explicit EC params API patterns

This commit adds a new test (run on all the built-in curves) to create EC_GROUP with unknown explicit parameters: from a built-in group we create an alternative group from scratch that differs in the generator used.
At the EC_GROUP layer we perform a basic math check to ensure that the math on the alternative group still makes sense, using comparable results from the origin group.
We then create two EC_KEY objects on top of this alternative group and run key generation from the EC_KEY layer.
Finally we promote these two EC_KEYs to EVP_PKEY objects and try to run the derive operation at the highest abstraction layer, comparing results in both directions.
Checklist

[x] tests are added or updated

@mattcaswell : this is the extra test discussed this morning to make sure we detect breaks in the programmatic use of EC with explicit parameter curves and their promotion to EVP_PKEYs.

The squash! commit is adding one final extra step:
it creates provider-native EVP_PKEYs in the original built-in group using EVP_PKEY_fromdata() with data derived from the previous steps.
These are then used to compute EVP_PKEY_derive(), math tells us that the shared secret obtained this way should match the one obtained through the legacy EVP_PKEY objects.

So far it seems we haven't broken the API! :partying_face: :tada: :balloon:

"provider-native", I like!  Maybe that should be part of our nomenclature instead of "provider side"...
(BTW, we might again want to consider openssl-glossary(7))

Side note: what's "vertical" in this context?  How are the rest horizontal?

Side note: what's "vertical" in this context? How are the rest horizontal?

With "vertical" I meant across APIs at different level of abstraction, similar to this kind of diagrams where higher level of abstraction is at top and lower level of abstraction is at bottom:

In this perspective, these tests are working at EC, EC_KEY and EVP_PKEY (from bottom to top) and moving objects/comparing results across these boundaries.

This is in contrast with other tests in our suit that usually test several calls within a single API layer (e.g. the other tests in ectest.c only use EC calls, EVP_PKEY tests are handled with evptest that only uses the EVP functionality, etc.).
I wouldn't necessarily call those tests horizontal though, as usually I would use that to mean I am crossing some semantic/logic API boundary at the same level of abstraction.

Thanks for the feedback @mattcaswell and @paulidale
I just pushed fixup commits to address your comments, please re-review at your convenience.
I kept the capital letters for point variables, as I believe in this case it improves readability and it is quite familiar for anyone who is reviewing EC code and tests that points are named with capital letters, while scalars with lowercase letters.
I can of course change it if you insist, but for now I would like to recommend against it.

All travis failures are due to the issue fixed by #12549 and are unrelated to this PR.

@mattcaswell
I just force pushed after rebasing on top of

#12549
#12508
#12550

Let's see how Travis reacts.
Local tests seems promising!

24 hours has passed since 'approval: done' was set, but as this PR has been updated in that time the label 'approval: ready to merge' is not being automatically set.  Please review the updates and set the label manually.

Merged to master as:

f5384f064e [test] Vertically test explicit EC params API patterns
cfae32c69a [test][ectest] Minor touches to custom_generator_test

Thanks!


sanitize user input to prevent fake logs attack

Although the real solution is probably replacing our logs with go-bits/logg

Coverage: 59.47% (+0.01%) from 59.456% when pulling f26c4aa0ee9fd409456c4084933b7fdd8abe4711 on log-injection into f3c28815c3149d791a5bca441c1ef63ec2aac124 on master.


Nothing happens when trying to update device firmware

Checklist

[X]  I am not using Home Assistant. Or: a developer has told me to come here.
[X] I have checked the troubleshooting section and my problem is not described there.
[X] I have read the changelog and my problem is not mentioned there.

Deploy method
Docker
Z-Wave JS UI version
8.11.0
ZwaveJS version
10.12.0
Describe the bug
I have a firmware file for a device.  I then go to the device in ZUI, click "Advanced", "Firmware update", "Begin", select the firmware file and target 0, and hit "Ok".
Then... nothing.
Subsequent attempts give error: Error while calling updateFirmware: Failed to start the update: A firmware upgrade is already in progress! (ZW1500)
To Reproduce
Go to the device in ZUI, click "Advanced", "Firmware update", "Begin", select the firmware file and target 0, and hit "Ok".
Expected behavior
The firmware update starts and runs.
Additional context
2023-03-22 19:39:35.711 INFO Z-WAVE: Calling api updateFirmware with args: [
  90,
  [
    {
      name: 'VZW31-2In1 V0.11 Inovelli Firmware ID 15 01_ST=0X01.gbl',
      data: <Buffer eb 17 a6 03 08 00 00 00 00 00 00 03 01 01 00 00 fa 06 06 fa 10 00 00 00 ac 79 02 00 51 d0 ef a3 a1 77 1c de c0 67 1e 6d f9 07 07 f9 24 00 00 00 93 c0 ... 162310 more bytes>,
      target: 0
    },
    [length]: 1
  ],
  [length]: 2
]
2023-03-23T00:39:35.731Z SERIAL » 0x011500135a0e9f0325006e03c68b2680af72d8bf25828f                    (23 bytes)
2023-03-23T00:39:35.733Z DRIVER » [Node 090] [REQ] [SendData]
                                  │ transmit options: 0x25
                                  │ callback id:      130
                                  └─[Security2CCMessageEncapsulation]
                                    │ sequence number: 37
                                    └─[FirmwareUpdateMetaDataCCMetaDataGet]
2023-03-23T00:39:35.738Z SERIAL « [ACK]                                                                   (0x06)
2023-03-23T00:39:35.741Z SERIAL « 0x0104011301e8                                                       (6 bytes)
2023-03-23T00:39:35.743Z SERIAL » [ACK]                                                                   (0x06)
2023-03-23T00:39:35.745Z DRIVER « [RES] [SendData]
                                    was sent: true
2023-03-23T00:39:35.756Z SERIAL « 0x011800138200000100bb7f7f7f7f0000030000000003010000cd              (26 bytes)
2023-03-23T00:39:35.758Z SERIAL » [ACK]                                                                   (0x06)
2023-03-23T00:39:35.760Z DRIVER « [REQ] [SendData]
                                    callback id:            130
                                    transmit status:        OK, took 10 ms
                                    routing attempts:       1
                                    protocol & route speed: Z-Wave, 100 kbit/s
                                    ACK RSSI:               -69 dBm
                                    ACK channel no.:        0
                                    TX channel no.:         0
2023-03-23T00:39:35.774Z SERIAL « 0x01210004005a199f03120090d619171bb780ee51c10c66f3fb1ff18ec80615a7b (35 bytes)
                                  b00c8
2023-03-23T00:39:35.779Z SERIAL » [ACK]                                                                   (0x06)
2023-03-23T00:39:35.781Z CNTRLR   [Node 090] [~] [Firmware Update Meta Data] firmwareUpg [Endpoint 0] [internal]
                                  radable: true => true
2023-03-23T00:39:35.783Z CNTRLR   [Node 090] [~] [Firmware Update Meta Data] additionalF [Endpoint 0] [internal]
                                  irmwareIDs:  =>
2023-03-23T00:39:35.784Z CNTRLR   [Node 090] [~] [Firmware Update Meta Data] continuesTo [Endpoint 0] [internal]
                                  Function: "unknown" => "unknown"
2023-03-23T00:39:35.785Z CNTRLR   [Node 090] [~] [Firmware Update Meta Data] supportsAct [Endpoint 0] [internal]
                                        firmware upgradable:     true
                                        max fragment size:       28
                                        additional firmware IDs: []
                                        hardware version:        1
                                        continues to function:   unknown
                                        supports activation:     unknown
2023-03-23T00:39:35.793Z CNTRLR   [Node 090] Updating firmware (part 1 / 1)...
2023-03-23T00:39:35.794Z CNTRLR » [Node 090] Starting firmware update...
2023-03-23T00:39:35.886Z SERIAL » 0x011f00135a189f0326000f29b139eed0f3f6c8c69546aa604802e6f65acc2583e (33 bytes)
                                  3
2023-03-23T00:39:35.889Z DRIVER » [Node 090] [REQ] [SendData]
                                  │ transmit options: 0x25
                                  │ callback id:      131
                                  └─[Security2CCMessageEncapsulation]
                                    │ sequence number: 38
                                    └─[FirmwareUpdateMetaDataCCRequestGet]
                                        manufacturer id: 0x031e
                                        firmware id:     0x1501
                                        checksum:        0xffbc
                                        firmware target: 0
                                        fragment size:   28
                                        activation:      false
2023-03-23T00:39:35.895Z SERIAL « [ACK]                                                                   (0x06)
2023-03-23T00:39:35.899Z SERIAL « 0x0104011301e8                                                       (6 bytes)
2023-03-23T00:39:35.901Z SERIAL » [ACK]                                                                   (0x06)
2023-03-23T00:39:35.904Z DRIVER « [RES] [SendData]
                                    was sent: true
2023-03-23T00:39:35.915Z SERIAL « 0x011800138300000200bb7f7f7f7f0000030000000003010000cf              (26 bytes)
2023-03-23T00:39:35.917Z SERIAL » [ACK]                                                                   (0x06)
2023-03-23T00:39:35.924Z DRIVER « [REQ] [SendData]
                                    callback id:            131
                                    transmit status:        OK, took 20 ms
                                    routing attempts:       1
                                    protocol & route speed: Z-Wave, 100 kbit/s
                                    ACK RSSI:               -69 dBm
                                    ACK channel no.:        0
                                    TX channel no.:         0
2023-03-23T00:39:36.207Z SERIAL « 0x01170004005a0f9f031300165abd03e47613d7b4c078bb0025                (25 bytes)
2023-03-23T00:39:36.219Z SERIAL » [ACK]                                                                   (0x06)
2023-03-23T00:39:36.224Z DRIVER « [Node 090] [REQ] [ApplicationCommand]
                                  └─[Security2CCMessageEncapsulation]
                                    │ sequence number: 19
                                    └─[FirmwareUpdateMetaDataCCRequestReport]
                                        status: OK
2023-03-23T00:39:36.230Z SERIAL « 0x01190004005a119f031400d9068c326fa6a059e1605151e8bb00a2            (27 bytes)
2023-03-23T00:39:36.233Z SERIAL » [ACK]                                                                   (0x06)
2023-03-23T00:39:36.236Z DRIVER « [Node 090] [REQ] [ApplicationCommand]
                                  └─[Security2CCMessageEncapsulation]
                                    │ sequence number: 20
                                    └─[FirmwareUpdateMetaDataCCGet]
                                        total # of reports: 1
                                        report number:      1
2023-03-23T00:39:46.766Z SERIAL « 0x01190004005a119f03150076c979ce44c2e1462df756c0b5bb004b            (27 bytes)
2023-03-23T00:39:46.772Z SERIAL » [ACK]                                                                   (0x06)
2023-03-23T00:39:46.776Z DRIVER « [Node 090] [REQ] [ApplicationCommand]
                                  └─[Security2CCMessageEncapsulation]
                                    │ sequence number: 21
                                    └─[FirmwareUpdateMetaDataCCGet]
                                        total # of reports: 1
                                        report number:      1
2023-03-23T00:39:57.664Z SERIAL » 0x0103003bc7                                                         (5 bytes)
2023-03-23T00:39:57.666Z DRIVER » [REQ] [GetBackgroundRSSI]
2023-03-23T00:39:57.670Z SERIAL « [ACK]                                                                   (0x06)
2023-03-23T00:39:57.673Z SERIAL « 0x0105013b7d7dc0                                                     (7 bytes)
2023-03-23T00:39:57.674Z SERIAL » [ACK]                                                                   (0x06)
2023-03-23T00:39:57.677Z DRIVER « [RES] [GetBackgroundRSSI]
                                    channel 0: No signal detected
                                    channel 1: No signal detected
2023-03-23T00:39:58.812Z SERIAL « 0x01190004005a119f0316005dd0a90cf0f4ec97884407520ebb0058            (27 bytes)
2023-03-23T00:39:58.822Z SERIAL » [ACK]                                                                   (0x06)
2023-03-23T00:39:58.828Z DRIVER « [Node 090] [REQ] [ApplicationCommand]
                                  └─[Security2CCMessageEncapsulation]
                                    │ sequence number: 22
                                    └─[FirmwareUpdateMetaDataCCGet]
                                        total # of reports: 1
                                        report number:      1
2023-03-23T00:40:12.361Z SERIAL « 0x01190004005a119f03170028ce7dd98c3c04af1d9ce2f838bb0063            (27 bytes)
2023-03-23T00:40:12.365Z SERIAL » [ACK]                                                                   (0x06)
2023-03-23T00:40:12.370Z DRIVER « [Node 090] [REQ] [ApplicationCommand]
                                  └─[Security2CCMessageEncapsulation]
                                    │ sequence number: 23
                                    └─[FirmwareUpdateMetaDataCCGet]
                                        total # of reports: 1
                                        report number:      1
2023-03-23T00:40:27.415Z SERIAL « 0x01190004005a119f031800fafdf642ce14bc16288e4d8e45bb0075            (27 bytes)
2023-03-23T00:40:27.427Z SERIAL » [ACK]                                                                   (0x06)
2023-03-23T00:40:27.436Z DRIVER « [Node 090] [REQ] [ApplicationCommand]
                                  └─[Security2CCMessageEncapsulation]
                                    │ sequence number: 24
                                    └─[FirmwareUpdateMetaDataCCGet]
                                        total # of reports: 1
                                        report number:      1
2023-03-23T00:40:27.673Z SERIAL » 0x0103003bc7                                                         (5 bytes)
2023-03-23T00:40:27.676Z DRIVER » [REQ] [GetBackgroundRSSI]
2023-03-23T00:40:27.680Z SERIAL « [ACK]                                                                   (0x06)
2023-03-23T00:40:27.683Z SERIAL « 0x0105013b7d7dc0                                                     (7 bytes)
2023-03-23T00:40:27.685Z SERIAL » [ACK]                                                                   (0x06)
2023-03-23T00:40:27.689Z DRIVER « [RES] [GetBackgroundRSSI]
                                    channel 0: No signal detected
                                    channel 1: No signal detected
2023-03-22 19:40:36.440 INFO Z-WAVE: Received no matching command within the provided timeout! (ZW0201) updateFirmware undefined

Looks like the driver is waiting for a specific command that doesn't come. I'll check it when I'm back to work in 2 weeks

I am getting the same error trying to upgrade a MCOHome A8-9.

Same error here trying to update a Zooz ZEN51 (in Home Assistant). I have been able to update these in the past.

Thanks - no need for further confirmation. I'll check it when I'm back to work next week.

I just stepped through a few older versions of ZUI to figure out where the process broke.  ZUI 8.9.0 works, and 8.10.0 is the first version to stop working.  It looks like that corresponds to the jump from zwave-js 10.10.0 to 10.11.0.

Thanks - no need for further confirmation. I'll check it when I'm back to work next week.

Same issue with a zen51, sorry to pile on.

not sure if it’s related, but the one device I have that has this issue is connecting using S2 security. I can try repairing it without s2 and trying to update it if that helps you.

Might be S2-related. I cannot reproduce without security nor with S0. Will try S2 next.

I can confirm that the devices I am trying to upgrade (a Zooz ZEN51) will take the upgrade if I exclude it and add it with no security, but will not work under S2. I had successfully upgraded several of these devices on earlier releases of ZWave-JS with S2 security enabled.

Found the issue. This also broke S2 inclusion for a short time. Same problem, same fix.


Vernam CIpher- Winter of Code

💥 Proposal- Vernam Cipher
(A clear and concise description of what the proposal is.)
Add Vernam Cipher algorithm in the cryptographic section. Vernam Cipher is a symmetric key cryptographic algorithm and is one of the transposition technique that converts plain text into ciphertext.
Tasks-
Encrypt the plain text to cipher text using vernam cipher in C++.
Decrypt the cipher text obtained back to plain text using vernam in C++.
Have you read the [Contributing Guidelines on Pull Requests]
Yes, I have read.

I would like to do this in python please assign me this @shraddhavp


Add two flash-attn extensions as multi-outputs

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[x] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

Fixes #18

This is not quite working yet, but want to make sure I'm on the right track.
cc @jakirkham

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

Please make sure to add this to the extra section at the bottom
extra:
  feedstock_name: flash-attn
  ...

Hi! This is the friendly automated conda-forge-linting service.
I wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found some lint.
Here's what I've got...
For recipe/meta.yaml:

The extra section contained an unexpected subsection name. feedstock_name is not a valid subsection name.

Ok, this is more or less structured as we've discussed, but I'm getting some errors when it tries to package the extensions, any ideas?
Packaging flash-attn-fused-dense-lib
number of files: 1
Warning: rpath /home/conda/feedstock_root/build_artifacts/flash-attn-split_1729553591356/_build_env/lib is outside prefix /home/conda/feedstock_root/build_artifacts/flash-attn-split_1729553591356/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_plac (removing it)
  ERROR (flash-attn-fused-dense-lib,lib/python3.12/site-packages/fused_dense_lib.cpython-312-x86_64-linux-gnu.so): $RPATH/libc10.so not found in packages, sysroot(s) nor the missing_dso_whitelist.
.. is this binary repackaging?
  ERROR (flash-attn-fused-dense-lib,lib/python3.12/site-packages/fused_dense_lib.cpython-312-x86_64-linux-gnu.so): $RPATH/libtorch_cpu.so not found in packages, sysroot(s) nor the missing_dso_whitelist.
.. is this binary repackaging?
  ERROR (flash-attn-fused-dense-lib,lib/python3.12/site-packages/fused_dense_lib.cpython-312-x86_64-linux-gnu.so): $RPATH/libtorch_python.so not found in packages, sysroot(s) nor the missing_dso_whitelist.
.. is this binary repackaging?
  ERROR (flash-attn-fused-dense-lib,lib/python3.12/site-packages/fused_dense_lib.cpython-312-x86_64-linux-gnu.so): $RPATH/libcudart.so.12 not found in packages, sysroot(s) nor the missing_dso_whitelist.
.. is this binary repackaging?
  ERROR (flash-attn-fused-dense-lib,lib/python3.12/site-packages/fused_dense_lib.cpython-312-x86_64-linux-gnu.so): $RPATH/libc10_cuda.so not found in packages, sysroot(s) nor the missing_dso_whitelist.
.. is this binary repackaging?
  ERROR (flash-attn-fused-dense-lib,lib/python3.12/site-packages/fused_dense_lib.cpython-312-x86_64-linux-gnu.so): $RPATH/libtorch_cuda.so not found in packages, sysroot(s) nor the missing_dso_whitelist.
.. is this binary repackaging?
  ERROR (flash-attn-fused-dense-lib,lib/python3.12/site-packages/fused_dense_lib.cpython-312-x86_64-linux-gnu.so): /lib64/libstdc++.so.6 not found in packages, sysroot(s) nor the missing_dso_whitelist.
.. is this binary repackaging?
  ERROR (flash-attn-fused-dense-lib,lib/python3.12/site-packages/fused_dense_lib.cpython-312-x86_64-linux-gnu.so): /lib64/libgcc_s.so.1 not found in packages, sysroot(s) nor the missing_dso_whitelist.
.. is this binary repackaging?
  ERROR (flash-attn-fused-dense-lib,lib/python3.12/site-packages/fused_dense_lib.cpython-312-x86_64-linux-gnu.so): /lib64/libc.so.6 not found in packages, sysroot(s) nor the missing_dso_whitelist.
.. is this binary repackaging?

Thanks Rong! 🙏
Think there is more to do on this point: https://github.com/conda-forge/flash-attn-feedstock/pull/19#discussion_r1807119731
Would start by copying that into the flash-attn output
The other outputs like need python in requirements/host and requirements/run

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

For recipe/meta.yaml:

The extra section contained an unexpected subsection name. feedstock_name is not a valid subsection name.

The linter didn't like it.

Ah that's because it should be feedstock-name instead of feedstock_name 🤦♂ Sorry about that 😞
ref: https://conda-forge.org/docs/maintainer/adding_pkgs/#feedstock-name

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.
I do have some suggestions for making it better though...
For recipe/meta.yaml:

libgcc-ng has been superseded by libgcc. Note however, that except in truly exceptional cases, you should not have to add this manually; you can rely on the fact that {{ compiler("c") }} and {{ compiler("cxx") }} will always create the correct run-export for this. If you need to ignore the run-export for whatever reason, the best way to do it is:build:
  ignore_run_exports_from:
    - {{ compiler("c") }}    # depending on which...
    - {{ compiler("cxx") }}  # ... compilers you use

libstdcxx-ng has been superseded by libstdcxx. Note however, that except in truly exceptional cases, you should not have to add this manually; you can rely on the fact that {{ compiler("cxx") }} will always create the correct run-export for this. If you need to ignore the run-export for whatever reason, the best way to do it is:build:
  ignore_run_exports_from:
    - {{ compiler("cxx") }}

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

@weiji14 @carterbox @jakirkham I think this is ready. How do I get Cirun to kick off? I've already added myself to open-gpu-server: https://github.com/Quansight/open-gpu-server/pull/46

Hmm...perhaps a current feedstock maintainer needs to push a commit. @carterbox could you please try?

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.
I do have some suggestions for making it better though...
For recipe/meta.yaml:

PyPI default URL is now pypi.org, and not pypi.io. You may want to update the default source url.

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

Thanks Rong! 🙏
Daniel, when you have a moment, could you please push another commit here to start CI?

I'm currently building with -Wl,--no-undefined to check which libraries are missing links for symbols.

Waiting on  https://github.com/conda-forge/admin-requests/pull/1158
The CUDA 12 builds complete, but the CUDA 11 builds need more time.

Testing to see if 18 hours is enought for CUDA 11 builds.

Woohoo! 🥳
Thanks everyone! 🙏
Glad to see this one in 😄


Update script to support buildFeature block

This adds support for converting the buildFeatures block!
I'm bad at regex so instead of updating addEquals to better filter out false positives I created a new convertBuildFeatures function at the end that will look for all the buildFeatures and what they're set to and then update them to include the equals.
Let me know if this is okay or if you'd preview something a little smarter 😅

That looks great! Should I merge? You opened as a draft.

Sorry I wasn't expecting such a quick response I was going to add a TODO 😅
Currently this supports all buildFeatures except compose and just adding it to buildFeatures property will break a bunch of other things in the file, I'm going to work on this more later this week when I have more time!

@bernaferrari this is now ready for review whenever you get a chance 👍

Perfect, thanks!


Password can not be nullptr here, so don't check

[approve ci clang-analyzer]

[approve ci clang-analyzer]

[approve ci clang-analyzer]

Cherry picked to the 8.1.x branch for the 8.1.0 release.


Implement dCBOR

See https://www.ietf.org/archive/id/draft-mcnally-deterministic-cbor-03.html
This also adds the expected prohibitions against Simple.  Wait to merge until we hear back from Wolf on that.

Codecov Report

Merging #19 (2cd30e1) into main (3f5115c) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##              main       #19    +/-   ##
==========================================
  Coverage   100.00%   100.00%
==========================================
  Files           14        14
  Lines         2198      2421   +223
  Branches       354       392    +38
==========================================
+ Hits          2198      2421   +223

Files Changed
Coverage Δ

src/container.ts
100.00% <100.00%> (ø)

src/decodeStream.ts
100.00% <100.00%> (ø)

src/decoder.ts
100.00% <100.00%> (ø)

src/diagnostic.ts
100.00% <100.00%> (ø)

src/encoder.ts
100.00% <100.00%> (ø)

src/index.ts
100.00% <100.00%> (ø)

src/simple.ts
100.00% <100.00%> (ø)

src/types.ts
100.00% <100.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


NavigationMap - Android: When there is a route with many destinations and each destination has a marker on the map, the first marker will not fire the onMarkerClick event.

Description
When there is a route with many destinations and each destination has a marker on the map, the first marker will not fire the onMarkerClick event.
Environment details
Library version and other environment information:

react-native-navigation-sdk version: 0.6.1

OS type and version

iOS: 18.1, 18.0
Android: 35

Steps to reproduce

Pull down this branch.
Install the dependencies.
Run yarn start
Run yarn ios or yarn android
Click on navigate button
When the map, route and markers are load click on each of the markers. You should see a log in the console firing onMarkerClick. On iOS this works as expected and the onMarkerClick will fire.
On Android, click on the first marker or marker.id of "m0" and the onMarkerClick will not fire, however all the other markers will fire the onMarkerClick.

Code example
Link to Code example
Images / Media

Thanks for reporting this issue!

I was able to trigger the m0 marker for Android clicking around/within the gray dot.

@jokerttu  Can you please take a look?

Hi,
I was able to reproduce this issue,
The problem is that when marker that is over the currently active route leg is clicked, the event is captured by the SDK (for route leg click handling) and is not propagated to the marker click listener.
As this package is just a wrapper for Navigation SDK for Android and iOS platforms, only features available on the SDK can and should be implemented to the plugin itself.
I will continue investigating if there is possiblity to control how route click events are handled, but this might not be possible with current Navigation SDK version for Android.


Update README.md

another typo in the docs

Coverage remained the same at 94.503% when pulling b2873708060b533eb589cc1f445a7a5c69e75836 on AndyOGo:patch-2 into 41ef9a3e73e4474abd554bc38f6ce01c8137a917 on kristerkari:master.

Thanks! could you rebase against current master?

Coverage remained the same at 94.503% when pulling c3c2671ed714111f0845917f7b86ad3c43ea31d7 on AndyOGo:patch-2 into 97d10d747233beefda721ff98493cf070cb36aa7 on kristerkari:master.

@kristerkari
Sure I just fetched from your master, merged into mine and rebased patch-2 onto master 😃


Optimization: Filesize for main preview image

What does this PR do
Updates the main preview image to be a PNG of the logos instead of the full gif (~500kb -> 40kb)
How should this be manually tested
You can preview the image here: https://www.sanity.io/create?template=brob/sanity-template-commercelayer
Any background context you want to add
Hey team, just wanting to optimize a little around the sanity.io/create page for the starter. The GIF was super nice looking, but a bit on the heavier side. This is a version with just a still for the logos to lighten it a bit. Let me know what you think!

Absolutely!
Since these files are only used in a couple small spots on the page, I reduced the image size of that (and reduced the studio preview, too).


Linkerd 2.10

TODO:

[x] Changelog entry

Lots of changes. Do we need to provide an upgrade path for the customers? Is our linkerd-app already used in production somewhere?

Do we need to provide an upgrade path for the customers? Is our linkerd-app already used in production somewhere?

I think this is not the case, so no upgrade path required.


docs: add disclaimer to remove kmod-nvidia and akmod-nvidia

On my own machine, I've found that having kmod-nvidia or akmod-nvidia installed to provide nvidia drivers often breaks any installed driver and the OS will either default to nouveau or be unable to provide any graphics card output.
This PR provides a warning on the readme page for nvidia images for this behavior.

I'm confused, how did the bad package end up on your system?

The Nvidia akmod is the driver. Removing it removes the driver.

Following the instructions on the Fedora documentation on installing nvidia drivers, on top of the drivers provided by silverblue-nvidia. Hence why the bad packages ended up as some of my LayeredPackages.

You must have these packages installed to have nvidia drivers.

I suppose they shouldn't be layered packages. Should I update the warning to disclose this? Or is it a lost cause?

The Nvidia akmod is the driver. Removing it removes the driver. It's possible your card isn't supported by the version of the driver you had installed

I'm fairly certain the 2060 is supported, but I'll check the version of the driver and let you know.

The driver is provided directly from RPM Fusion. The idea is you shouldn't have to worry about installing it or anything like that because it's just there, unlike in normal Silverblue. That's the selling point of these images. There's no hoops you need to go through or anything. It should just work after installing an Nvidia image. Your 2060 should definitely be supported. If the image isn't working for you, it would be absolutely awesome if you could open an issue detailing exactly what goes wrong after installing an image and provide any logs. Closing as this isn't the issue and undoes everything this image provides OOTB

I just tested installing akmod-nvidia as a layered package just now. It certainly does break things - my system had to default to nouveau, but I agree that this is not something a user should worry about OOTB and the docs already cover wiping out all layered packages before migrating to a nvidia image.
:wave:


Close file only, if file could be openend

It prevents the server crash

Thanks for catching this, agree 100%


feat(query): support of Terraform modules for "Auto Scaling Group Wit…

…h No Associated ELB"
Check why this is failing in unit tests
I submit this contribution under the Apache-2.0 license.

@tiagocruz20 this query was reverted and reopened as PR due to failing checks.
Please add a new OR check in the policy, verifying if the aws_autoscaling_group has load_balancers > 0:
count(resource.load_balancers) > 0


Mismatching Text on Request Help Page

Subject of the issue
A browser test I had written had failed because the text for one of the links had been modified.  I don't understand Malayalam, so I'm uncertain if the former or latter translation is correct, incorrect, more(?) correct.
Home Page

Request for Help Page

Steps to reproduce

Visit the homepage, and observer the Malayalam text in the Requst for Help link
Click on Request for Help link
Observe the Malayalam header text.

Expected behaviour
I'm uncertain as I'm not a native speaker.
Actual behaviour
The text on both pages should match.

Ok, please confirm whether this is still an issue or not.

As a non-native speaker, I don't know which one is more appropriate.


[Event Request] Codeunit 12 "Gen. Jnl.-Post Line" OnAfterPostDtldCustVATAdjustment

Dear ALAppExtensions team,
On behalf of 4PS I would like to request integration event 'OnAfterPostDtldCustVATAdjustment' to be added to procedure 'PostDtldCustVATAdjustment' in codeunit 12 "Gen. Jnl.-Post Line".
    local procedure PostDtldCustVATAdjustment(GenJnlLine: Record "Gen. Journal Line"; DtldCVLedgEntryBuf: Record "Detailed CV Ledg. Entry Buffer"; OriginalTransactionNo: Integer)
    var
        VATPostingSetup: Record "VAT Posting Setup";
        TaxJurisdiction: Record "Tax Jurisdiction";
    begin
        with DtldCVLedgEntryBuf do begin
            FindVATEntry(VATEntry, OriginalTransactionNo);

            case VATPostingSetup."VAT Calculation Type" of
                VATPostingSetup."VAT Calculation Type"::"Normal VAT",
                VATPostingSetup."VAT Calculation Type"::"Full VAT":
                    begin
                        VATPostingSetup.Get("VAT Bus. Posting Group", "VAT Prod. Posting Group");
                        VATPostingSetup.TestField("VAT Calculation Type", VATEntry."VAT Calculation Type");
                        CreateGLEntry(
                          GenJnlLine, VATPostingSetup.GetSalesAccount(false), -"Amount (LCY)", -"Additional-Currency Amount", false);
                    end;
                VATPostingSetup."VAT Calculation Type"::"Reverse Charge VAT":
                    ;
                VATPostingSetup."VAT Calculation Type"::"Sales Tax":
                    begin
                        TestField("Tax Jurisdiction Code");
                        TaxJurisdiction.Get("Tax Jurisdiction Code");
                        CreateGLEntry(
                          GenJnlLine, TaxJurisdiction.GetPurchAccount(false), -"Amount (LCY)", -"Additional-Currency Amount", false);
                    end;
            end;
        end;
        OnAfterPostDtldCustVATAdjustment(GenJnlLine, DtldCVLedgEntryBuf); //new
    end;

    [IntegrationEvent(false, false)]
    local procedure OnAfterPostDtldCustVATAdjustment(GenJnlLine: Record "Gen. Journal Line"; DtldCVLedgEntryBuf: Record "Detailed CV Ledg. Entry Buffer")
    begin
    end;

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.
Build ID: 51064.


EDS tests and refactoring

added a unit/integration local test checking the grpc streaming directly
refactored the testing code to allow better starting pilot and envoy for the local tests
refactored the grpc server initialization, now part of pilot/pkg/bootstrap
moved edsv2 code in the v2 directory.
fixed the streaming of endpoints

This PR uses EDSv2 by default, depending on testing results we may chose a different
value.

Note that while testing this I found that EDSv1 was not working well with the envoy in front of pilot - by default the TCP cluster has max 1024 connections, and the sidecars make one TCP connection per cluster, resulting in cases where EDS1 was failing ( I test on a cluster with ~500 services, to make sure we don't break the memory fixes ).
So temporarily I've moved back the 'insecure' pilot to 8080 - and will try to have better settings for the
grpc port, which doesn't yet have certificates.

@costinm: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-presubmit.sh
a57692cd89923d517393618e3b14ebd61aa51e55
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-presubmit.sh
a57692cd89923d517393618e3b14ebd61aa51e55
link
/test istio-presubmit

prow/istio-unit-tests.sh
c9ca4fbd7649d104624c0c9cbeb3f5f38130cf9b
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
c9ca4fbd7649d104624c0c9cbeb3f5f38130cf9b
link
/test istio-unit-tests

prow/istio-presubmit.sh
c9ca4fbd7649d104624c0c9cbeb3f5f38130cf9b
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-presubmit.sh
c9ca4fbd7649d104624c0c9cbeb3f5f38130cf9b
link
/test istio-presubmit

prow/istio-unit-tests.sh
a942c3e96a331a06a2a9ff9f6449cf70e54079fd
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
a942c3e96a331a06a2a9ff9f6449cf70e54079fd
link
/test istio-unit-tests

prow/istio-presubmit.sh
a942c3e96a331a06a2a9ff9f6449cf70e54079fd
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-presubmit.sh
a942c3e96a331a06a2a9ff9f6449cf70e54079fd
link
/test istio-presubmit

prow/istio-unit-tests.sh
53f91de41a24d16636b9576a370bf8293f7976d4
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
53f91de41a24d16636b9576a370bf8293f7976d4
link
/test istio-unit-tests

prow/istio-presubmit.sh
53f91de41a24d16636b9576a370bf8293f7976d4
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-presubmit.sh
0614599ffe16604eb4f742a25c5c3f95e291cd98
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Can you file a bug for the Envoy in front of pilot thing ? Assign to Krishna since he implemented the istio on istio. IMO we should do tls directly from pilot instead of adding yet another Envoy.

@costinm: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-presubmit.sh
0614599ffe16604eb4f742a25c5c3f95e291cd98
link
/test istio-presubmit

prow/istio-unit-tests.sh
69255625c782c5a94e7b77565c32dcbb53bc1b45
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Yes, I generally agree on doing mtls in pilot in future. There are many problems around this...
For envoy fixes - I'll probably do this work in a separate PR for the grpc port and switching to v2 bootstrap.

@costinm: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-presubmit.sh
0614599ffe16604eb4f742a25c5c3f95e291cd98
link
/test istio-presubmit

prow/istio-unit-tests.sh
72b42579fdc6b886f15ed0ace4f359ddbe663d08
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
72b42579fdc6b886f15ed0ace4f359ddbe663d08
link
/test istio-unit-tests

prow/e2e-simpleTests.sh
72b42579fdc6b886f15ed0ace4f359ddbe663d08
link
/test e2e-simple

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
72b42579fdc6b886f15ed0ace4f359ddbe663d08
link
/test istio-unit-tests

prow/e2e-simpleTests.sh
72b42579fdc6b886f15ed0ace4f359ddbe663d08
link
/test e2e-simple

prow/e2e-bookInfoTests.sh
72b42579fdc6b886f15ed0ace4f359ddbe663d08
link
/test e2e-bookInfo

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-simpleTests.sh
72b42579fdc6b886f15ed0ace4f359ddbe663d08
link
/test e2e-simple

prow/e2e-bookInfoTests.sh
72b42579fdc6b886f15ed0ace4f359ddbe663d08
link
/test e2e-bookInfo

prow/istio-unit-tests.sh
ac118649734ed9a59107de59c92e4f053059e17e
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-simpleTests.sh
72b42579fdc6b886f15ed0ace4f359ddbe663d08
link
/test e2e-simple

prow/istio-unit-tests.sh
ac118649734ed9a59107de59c92e4f053059e17e
link
/test istio-unit-tests

prow/e2e-bookInfoTests.sh
ac118649734ed9a59107de59c92e4f053059e17e
link
/test e2e-bookInfo

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
ac118649734ed9a59107de59c92e4f053059e17e
link
/test istio-unit-tests

prow/e2e-bookInfoTests.sh
ac118649734ed9a59107de59c92e4f053059e17e
link
/test e2e-bookInfo

prow/e2e-simpleTests.sh
ac118649734ed9a59107de59c92e4f053059e17e
link
/test e2e-simple

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests.sh
ac118649734ed9a59107de59c92e4f053059e17e
link
/test e2e-bookInfo

prow/e2e-simpleTests.sh
ac118649734ed9a59107de59c92e4f053059e17e
link
/test e2e-simple

prow/istio-unit-tests.sh
5895f09b53ebca7d769cee06b6f3efe1e64cbac8
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests.sh
ac118649734ed9a59107de59c92e4f053059e17e
link
/test e2e-bookInfo

prow/istio-unit-tests.sh
5895f09b53ebca7d769cee06b6f3efe1e64cbac8
link
/test istio-unit-tests

prow/e2e-simpleTests.sh
5895f09b53ebca7d769cee06b6f3efe1e64cbac8
link
/test e2e-simple

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
5895f09b53ebca7d769cee06b6f3efe1e64cbac8
link
/test istio-unit-tests

prow/e2e-simpleTests.sh
5895f09b53ebca7d769cee06b6f3efe1e64cbac8
link
/test e2e-simple

prow/e2e-bookInfoTests.sh
5895f09b53ebca7d769cee06b6f3efe1e64cbac8
link
/test e2e-bookInfo

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

PTAL - tests are passing ! There are few more improvements to make before deciding if we leave it
enabled by default, one of the main reasons to move ahead is that it reduces the load on pilot, this
has been a big problem with v1.

@costinm: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests.sh
5895f09b53ebca7d769cee06b6f3efe1e64cbac8
link
/test e2e-bookInfo

prow/e2e-simpleTests.sh
b2110c7c325948e3e07cefadf4bf838a63fed3a6
link
/test e2e-simple

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-simpleTests.sh
b2110c7c325948e3e07cefadf4bf838a63fed3a6
link
/test e2e-simple

prow/e2e-bookInfoTests.sh
b2110c7c325948e3e07cefadf4bf838a63fed3a6
link
/test e2e-bookInfo

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-simpleTests.sh
b2110c7c325948e3e07cefadf4bf838a63fed3a6
link
/test e2e-simple

prow/e2e-bookInfoTests.sh
b2110c7c325948e3e07cefadf4bf838a63fed3a6
link
/test e2e-bookInfo

prow/istio-pilot-e2e.sh
b2110c7c325948e3e07cefadf4bf838a63fed3a6
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests.sh
b2110c7c325948e3e07cefadf4bf838a63fed3a6
link
/test e2e-bookInfo

prow/istio-pilot-e2e.sh
b2110c7c325948e3e07cefadf4bf838a63fed3a6
link
/test istio-pilot-e2e

prow/e2e-simpleTests.sh
419f5302b68a196d56c270e067babc10ebe3c7ee
link
/test e2e-simple

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
b2110c7c325948e3e07cefadf4bf838a63fed3a6
link
/test istio-pilot-e2e

prow/e2e-simpleTests.sh
419f5302b68a196d56c270e067babc10ebe3c7ee
link
/test e2e-simple

prow/e2e-bookInfoTests.sh
419f5302b68a196d56c270e067babc10ebe3c7ee
link
/test e2e-bookInfo

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-simpleTests.sh
419f5302b68a196d56c270e067babc10ebe3c7ee
link
/test e2e-simple

prow/e2e-bookInfoTests.sh
419f5302b68a196d56c270e067babc10ebe3c7ee
link
/test e2e-bookInfo

prow/istio-pilot-e2e.sh
419f5302b68a196d56c270e067babc10ebe3c7ee
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

this basically prevent the code package check. There is a codecov.skip where you can put the thing that are do not want to be covered instead of disabling the check for all packages.


HDFS-15941.Solve the problem that the inspection period of HeartbeatManager#Monitor can be configured.

2851

 Quality gate: Failed
3 Issues

 2 Code issues
 1 Anti-patterns

Details


Incompatible with the QuickRestart mod

https://thunderstore.io/package/AceOfShades/QuickRestart/
After the console says "Accepting vote from PlayerName" usually it'd just start but with this mod for some reason it just spews error messages:
"NullReferenceException: Object reference not set to an instance of an object"
"Instance not found when handling Command message [netId=(randomnumber]"
No idea how these 2 mods interfere with each other

I feel like this has something to do with QuickRestart destroying the Run instance: https://github.com/Maceris/quick-restart/blob/v1.3.1/BoothUtil.cs#L145
But QuickRestart is a client side (only) mod, and PlayerRespawnSystem is tagged as server-side, would both be installed for single player?

I just use r2modman and play and host ingame normally. I'm not sure why the Respawn mod would be loaded in Singlerplayer but the Restart mod already does not work in multiplayer

Outdated


Typo. Using Request in place of Response.

Logical typo. The word "request" is used where the word "response" is expected.

Hello @it3xl ... Thanks, but we define these features broadly from a 'processing requests' viewpoint. The whole topic is written from that perspective.


FEATURE Option placeholder for upload folder id

To be merged with https://github.com/silverstripe/silverstripe-asset-admin/pull/1009

Any chance of being able to pass a string, like we can to ->setFolderName() for UploadFields? Appreciate that may mean some more logic somewhere in this class, but it’d be a nicer dev experience 😄

I think so; At the JS level it needs to pass the ID, but we could translate the path to id within TinyMCEConfig right?

@kinglozzer done.

I think I've implemented what you asked @unclecheese :)

Code is now selfish.

And can we type the param, too? string $folderName?
Sorry to nitpick, but we're just trying to be consistent with all new APIs.

Nvm, I've done it.

Thanks @unclecheese . I didn't mean to string you out :)


Architecture discussion - Part 1

Notes: https://hackmd.io/KJ2bgG9_RRCY3jr8jCRlsw

Please define actionable item here - how do we know if it is done? Related to agpipeline/drone-pipeline/environment#40?

5 points seems like a lot
How do we know if it is done?
Is this related to related to...

Exactly. I don't know. That's why I wanted you to set boundaries on time and scope as I mentioned in the Slack thread. The points are a reflection of my uncertainty around time and scope.


Why not compare disabled loggers?

If I understand correctly, the benchmark configures output to the console and redirects the console to /dev/null.
Why not disable logging at level INFO (the level the benchmark invokes logger printing methods)? That way the cost involved in printing to /dev/null via the console will be removed from the results.

Do you mean setting logging level to WARN?
If it is so, than there will be nothing to benchmark actually, cause there always be instant return:
if(isInfoLoggingPossible) {
              // actual logic never executed
} else {
  return;     // always executed
}

The idea behind redirecting output to /dev/null is to eliminate costs of IO of the machine, cause IO is the most heavy part and now a lot of logic is testing not the loggers implementations but the IO of the device bench is executed
So the trick with redirect actually allows to isolate real logic and all methods of loggers to be invoked like it is real application and benchmark all of than while eliminating the effects of IO costs, cause this is not what bench is testing

Yes, setting the root logging level to WARN was what I had in mind.
By the way, thank you for the feedback. I think we are in agreement.
Access to the console (System.out or System.err) is synchronized. So even writing to /dev/null will incur some processing which you might want exclude from your measurements. On the other hand, the benchmark takes into account the cost of creating a logging event and looping through appenders which is a very good idea.
Perhaps sending output to a NoOperationAppender would be the ideal approach?

This is actually the idea also, I know that is synchronized and this access to IO should be measured, cause as you see from data some loggers have really different implementations, and such huge performance gaps actually occur due to some loggers accessing IO More frequently than the others, thats why they perform poorly when compared to others, cause IO is the most costly operation, so measuring access to System.out / System.err is intended by me
And this behavior also reflects the real usage logger will have, in real application it will also access IO (System.out / System.err / etc) and will have all those penalties by poorly managing IO access, so that's what you can see from the results of all loggers.
Some accessing IO keeping in mind that it costs a lot, some accessing it More frequently and thus having poor performance compared to others.
This is all intended behavior and what benchmark intends to uncover


PrefixPrinter and HybridPrinter missing

Hey there :) I don't know if i missed somthing but unfortunately the PrefixPrinter and the HybridPrinter are note available if you download logger Version 0.9.1. Too bad, because I really like the logger 😄

Failing: PrefixPrinter and HybridPrinter are not available
Steps to reproduce: Add following to your pubspec. yaml: logger: ^0.9.1
What should happen?: The PrefixPrinter and HybridPrinter should be available for usage.
Thank you very much!

I'll get on it once I get back from my holiday. I don't think these loggers
are released yet.
On Fri, Jul 24, 2020, 09:13 Kiesman<EMAIL_ADDRESS>wrote:

Hey there :) I don't know if i missed somthing but unfortunately the
PrefixPrinter and the HybridPrinter are note available if you download
logger Version 0.9.1. Too bad, because I really like the logger 😄
[image: image]
https://user-images.githubusercontent.com/17956096/88368124-b04adb00-cd8d-11ea-8e57-699aae758c96.png
Failing: PrefixPrinter and HybridPrinter are not available
Steps to reproduce: Add following to your pubspec. yaml: logger: ^0.9.1
What should happen?: The PrefixPrinter and HybridPrinter should be
available for usage.
Thank you very much!
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/leisim/logger/issues/56, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAACTJEH27BI6JOAJO73PWLR5EYBLANCNFSM4PGOHCEA
.

I've just release version 0.9.2 which includes these printers!

@haarts Thank you very much!


Extract prefix sum computations

This PR introduces a new prefix_sum kernel that is used instead of manually computing prefix sums in different places. This also fixes two bugs:

In CUDA/HIP ParILU, the wrong num_blocks is used for launching the prefix sum kernels
In Reference ParILU, the handling of non-existent diagonals is incorrect.

Finally, it removes a few unnecessary calls to Array::clear since they would be cleaned up via RAII anyways.

@pratikvn No, you are probably right. So would something like */component/prefix_sum.* make more sense? Also I should at least add 1-2 tests for this kernel.

@upsj , Yes, that sounds good to me.

Do you want to solve the par_ilu here? or another PR.

No, that would involve having to add another kernel, I will have to do that in another PR.


Anastasia's attempt at completing the Beginning Git video course

Hi,
This PR represents all the work I've done to complete the video course. It was fun and useful, thank you so much.
Anastasia

Hey @AnastasiaGolts—congrats on submitting a PR at the end of the git course. I hope that you enjoyed the course and that you learnt a lot in doing it.
If you weren't already using git for your code, hopefully this has inspired you to do so. I hope that you enjoy the "Mastering Git" video course as well—you'll soon be able to get git to bend to your will :)
You can now wear this #GitWarrior badge with pride—and Tweet your historic victory!

sam


Refs #27236 -- Split index_together and unique_together autodetector tests.

https://code.djangoproject.com/ticket/27236
Completes https://github.com/django/django/pull/15703 to split autodetector foo_together unit tests to unique_together+index_together.

@David-Wobrock Thanks :+1: I merged a3a1290d47326c3f87824b3cf7ca969cb0d364aa. Please rebase from the main branch and remove the 1st commit.

@David-Wobrock Thanks 👍 I merged a3a1290. Please rebase from the main branch and remove the 1st commit.

Of course!
I don't know why I thought that we wanted first to merge https://github.com/django/django/pull/15703 and then https://github.com/django/django/pull/15755 and https://github.com/django/django/pull/15754
But it actually makes more sense to first prepare the tests and then deprecate the index_together 👍 Thanks!