[Create New Issue]:  Rename the File Names Causing "Invalid Path " Error

Description
For Windows Users , Error is coming due to Invalid  File Names as (:) semicolon cannot be used in File Name for Windows .
It is causing Error while Cloning  or Checkout DSA branch . So Correct It .
Domain
DSA
Type of Contribution
Others
Code of Conduct

[X] I follow Contributing Guidelines & Code of conduct of this project.

/assign

Leave This


feat: enter support open file

Thanks for the PR!
The behavior of enter not being able to open the file, but just enter to the directory is the expected behavior. Since the ability to enter an archive as a directory will be added later, and the files inside can be manipulated directly -- it's a file, but enterable!
You seem to be looking for a command with both open and enter functionality, and I think adding enter to open seems like a good option -- enter the selected file when it's a directory, not open.

你的意思我添加的这个功能会和一个未完成的功能的行为有冲突 ( 将压缩文件作为一个目录，然后 enter )
所以我应该把这个功能添加到 open 中， 让 open 具有 enter 的功能 ？

是的，如果 make sense 我会加上它。

Yes, if make sense I will add it.

@sxyazi cc

先合并，我再来改进下。默认 <Right> 映射改为 open 会丢失进入 archive 的功能，如果您不需要它可以在您的配置文件中覆盖它为 open。

Merge it first and I'll improve it. Changing the default <Right> mapping to open will lose the functionality of archive, if you don't need it you can override it in your config file.

这么说确实有点冲突

We've supported it now, see this tip https://yazi-rs.github.io/docs/tips/#smart-enter-enter-for-directory-open-for-file.
Note that Yazi main branch is currently required.

We've supported it now, see this tip yazi-rs.github.io/docs/tips/#smart-enter-enter-for-directory-open-for-file.
Note that Yazi main branch is currently required.

It's pretty cool ! Plugin system. ❤


Sprite2D added through script isn't added to the Scenetree

Godot version
4.0.alpha2
System information
Windows 11, Nvidia 1050 Ti, Vulkan, Android 10, Huawei Nova 5T
Issue description
Creating an scene with a root node of type Sprite2D, then instantiating as a child node from another scene, doesn't add it to the scenetree on Android
In this example I added a node directly from the editor and other through code. This is how the scenetree look while running on Windows, both nodes appear under Node:

However this is how it looks while running on Android:

the code is the same in both cases, and these are the results:
Windows:

Android:

This works on version 3.4.2:

Steps to reproduce
1 - Create an scene with a sprite
2 - Instantiate the scene from another scene through code, something like this:
extends Node

var sprite_scene = load("res://Sprite.tscn")

func _ready():
    var sprite = sprite_scene.instantiate()
    sprite.position = Vector2(100, 100)
    add_child(sprite)

3 - Run on Android
Minimal reproduction project
AndroidTestG4.zip

This is due to case sensitivity, but the editor doesn't warn about it.
The instanced scene is saved as sprite.tscn, but you're using load("res://Sprite.tscn) in the script.

@Calinou sorry I didn't see my mistake, the 3.4.2 has the scene name written correctly in the script, here is the project:
AndroidTest.zip


Regression in rplidar_ros package.

Version 2.1.2 of rplidar_ros was merged recently (#37606). This release came from https://github.com/Slamtec/rplidar_ros/tree/ros2, while previous releases were from this fork https://github.com/allenh1/rplidar_ros. The new release has some breaking changes such as node name changes and missing features.

@deyouslamtec This looks like a regression as well as you're taking over maintinership(from @allenh1 ) of the package w/o a notice to the ROS community in your PR (#37606 ) it would be much better to mention that instead of just considering it a point release.
@audrow I would suggest a rollback of this in the immediate term as it's only in testing right now and significantly breaks active humble users including the TurtleBot 4 community. https://github.com/turtlebot/turtlebot4/issues/194 Then a migration plan can be determined for how to do this update without breaking existing users.

Thanks for the ping @tfoote, I had no knowledge of this.
This puts things in a rather awkward spot, because it clearly breaks compatibility with existing uses of the driver, and also silently swaps the codebase to a completely different one.
I'm happy to surrender maintainership to SLAMTEC (it is their product, after all), but perhaps we should transfer my repository to slamtec and make changes to that codebase? It seems like it will get confusing to have two repos lingering around.

Yes this does change things. I had assumed that there had been coordination with the existing maintainer and the handover had not been smooth.  I've opened the PR to revert the breaking change and usurpation of the package.
@deyouslamtec Can you please explain why you did not reach out to the existing maintainer or mention that in your pull request here: https://github.com/ros2-gbp/ros2-gbp-github-org/issues/261

I've opened the PR to revert the breaking change and usurpation of the package.

@tfoote thanks for doing that.
I'm a little confused... Has this been released as part of a sync? If so, will installed binaries with this version update to the new one, or should I release a new version in the interim?

@audrow I would suggest a rollback of this in the immediate term as it's only in testing right now and significantly breaks active humble users including the TurtleBot 4 community. turtlebot/turtlebot4#194

@tfoote, I merged in your revert. Thanks for moving fast on this.

I'm a little confused... Has this been released as part of a sync? If so, will installed binaries with this version update to the new one, or should I release a new version in the interim?

@allenh1, it doesn't look like this was included in the last sync. The last version synced was 2.1.0. Otherwise, I'd have to make another sync.
https://repo.ros2.org/status_page/ros_humble_default.html?q=rplidar_ros

@audrow ok, that's good. Very glad this was caught quickly!

Yes this does change things. I had assumed that there had been coordination with the existing maintainer and the handover had not been smooth. I've opened the PR to revert the breaking change and usurpation of the package.
@deyouslamtec Can you please explain why you did not reach out to the existing maintainer or mention that in your pull request here: ros2-gbp/ros2-gbp-github-org#261

sorry，my misstake。It was because I didn't have a clear understanding of the contribution rules that I didn't notify the existing maintainer.
@allenh1 I'm very sorry for not communicating with you in advance. Please don't mind. Actually, I am preparing to contact you soon.
What do I need to do now to solve the current problem?

Yes this does change things. I had assumed that there had been coordination with the existing maintainer and the handover had not been smooth. I've opened the PR to revert the breaking change and usurpation of the package.
@deyouslamtec Can you please explain why you did not reach out to the existing maintainer or mention that in your pull request here: ros2-gbp/ros2-gbp-github-org#261

sorry，my misstake。It was because I didn't have a clear understanding of the contribution rules that I didn't notify the existing maintainer.
@allenh1 I'm very sorry for not communicating with you in advance. Please don't mind. Actually, I am preparing to contact you soon.
What do I need to do now to solve the current problem?

Thank you for the quick fix.
@deyouslamtec I will just request that if the code base is changing to the Slamtec github, try to merge in some of the new features that are available in https://github.com/allenh1/rplidar_ros beforehand. For TurtleBot 4 specifically, we are using the start/stop services as well as the auto standby mode.

@deyouslamtec I will just request that if the code base is changing to the Slamtec github, try to merge in some of the new features that are available in https://github.com/allenh1/rplidar_ros beforehand.

In an effort to preserve existing code, maybe the ownership of my repository should simply be transferred to @deyouslamtec, and they can operate on that codebase.
I think we could make the migration a bit less painful for everyone by just having one repo instead of two.

@tfoote So, to be clear, the suggestion is that the branch on my repository will overwrite the one on Slamtech's repo, and I will change the maintainer in the package.xml to @deyouslamtec? Then, at that point, I will update the readme in my repository to point to the slamtech repo, then archive my repo.
I think this is a very good approach, and it will smoothe the transition considerably. @deyouslamtec does this plan work for you? Could you rename your ros2 branch and allow me to push my branch to your repository?

@allenh1 I agree. I have renamed my ros2 branch to ros2-devel，you can push your ros2 branch to my repository now.

@allenh1 OK。I have clone your ros2 branch to my repo

@deyouslamtec great! I will update mine and archive it later today.

@allenh1 I have already changed the maintainer to myself.
@tfoote  I have been removed from the rplidar_ros team.here(https://github.com/ros2-gbp/ros2-gbp-github-org/pull/285). Should I update the rplidar_ros team members myself or should it be done by @allenh1 ?

I believe that all the necessary steps have happened here and we can close this out.


Prevent comment-less Developer News forum threads

It is currently possible to create a forum comment thread for a Developer News article without leaving a comment.
For example, this thread has not actual comments in it, and merely represents noise when browsing News comments.

Currently these threads have to be suppressed due to all the noise these comment-less threads produce. Once we fix this, we will be able to start showing comments in the latest view and they will be more widely read.

Hi Quincy, I do not think this is possible at the minute, we use a script that is provided by discourse itself (just like a GA script).
We do not control the code for the same.


[Feature Request] Uninstall charts by regexp / by time

An example use case is to cleanup long-lived preview env deployments.
For some reasons, a PR might get deployed but didn't cleanup the deployment after PR closed. If we can schedule to run this action periodically to uninstall charts that matches a specific regexp and have lived for a specific duration, it should help GC those unused deployments.
Expected usage:
name: GC Outdated Preview Deployments
on:
  workflow_dispatch:
  schedule:
    - cron: '0 16 * * 0-4'

jobs:
  cleanup:
    name: Cleanup
    runs-on: ubuntu-latest
    env:
      YARN_ENABLE_IMMUTABLE_INSTALLS: false
    steps:
      - name: Uninstall charts
        uses<EMAIL_ADDRESS>        with:
          name: '/^brickdoc-preview-pr\d+/'
          task: 'remove'
          olderThan: '2d'

---
name: PR Preview Environment Garbage Collection
on:
  workflow_dispatch:
  schedule:
    - cron: '0 16 * * *'

jobs:
  app_engine_gc:
    name: Garbage Collection of Unused Container
    runs-on: ubuntu-latest
    steps:
    - name: Checkout
      uses: actions/checkout@v2
    - name: Configure AWS Credentials
      uses: aws-actions/configure-aws-credentials@v1
      with:
        aws-access-key-id: ${{ secrets.XXX_AK }}
        aws-secret-access-key: ${{ secrets.XXX_SECRET }}
        aws-region: xxxxxxx
    - name: Update EKS configure
      run: aws eks update-kubeconfig --name xxx
    - name: get helm deployments
      env:
          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
          APPS_PREFIX: xxxx-preview-pr
      run: |
        OPENED_PR=$(gh pr list -s open --json number | jq 'map(.number)|join(",")')
        echo "Opened PRs: $OPENED_PR"
        OPENED_HELM=$(helm list -n cicd -f "$APPS_PREFIX.+" -o json  | jq "map(.name|sub(\"$APPS_PREFIX\";\"\"))|join(\",\")")
        echo "Opened Helm releases: $OPENED_HELM"
        jq -n -r "{gh:$OPENED_PR|split(\",\"),helm:$OPENED_HELM|split(\",\")}|.helm-.gh|map(\"$APPS_PREFIX\(.)\") |.[]" | while read i; do
          echo "uninstall $i...."
          helm uninstall $i -n cicd
        done


Fix package

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (92c425c) to head (da0c0d7).

Additional details and impacted files
@@            Coverage Diff            @@
##            master        #2   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files           45        45
  Lines         1037      1121   +84
  Branches       152       152
=========================================
+ Hits          1037      1121   +84

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Add table headers in ddoc function tables

This is beautification. Not sure if I should include the std.range documentation, especially since #3003 is still open.

Looks good, thanks for the good work!

Auto-merge toggled on


Can't type question mark in RegExp matching group

I'm running the latest version on master and found I can't press the question mark after opening a matching group in a regular expression. For example:
/(

Typing that should be enough to show that the next character won't accept a question mark. It's only directly after the bracket, I can type a question mark elsewhere.

This is likely due to my code to treat this as a trigger for argument help.  I can take a look at fixing this.

Fixed with 38f74ce14456448ff


Unity package format

@BananaHemic Would you accept a PR that makes the necessary conversation to this format? Folder hierarchy, package.json file, etc. ...

Probably yes, I would accept that PR


[Backport v2.7-branch] spi: nrfx_spi*: only run uninit if configured

Manual copy of #42348 that contains the fix from #42579

@JordanYates - is there an existing issue for the backport?

@JordanYates - is there an existing issue for the backport?

The original issue was #42299

LGTM - @tbursztyka - can you ack as SPI maintainer?

@tbursztyka - please ack


StandardHubService cannot be loaded without snakeyaml and logs lines even though hub is disabled

Environment
Liquibase Version: 4.6.1
Liquibase Integration & Version: Using as lib
Liquibase Extension(s) & Version: n/a
Database Vendor & Version: n/a
Operating System Type & Version: n/a
Description
Whenever I start up the application, there is an INFO log line saying "Cannot load service: liquibase.hub.HubService: Provider liquibase.hub.core.StandardHubService could not be instantiated" followed by a DEBUG log line showing the exception.
The exception is, that snake yaml is not found which is true, as it is just an optional dependency and I don't want to use Liquibase Hub.
I tried to work-around this problem by setting liquibase.hub.mode to off, but this is in effect too late.
Liquibase#update unconditionally instantiates the HubUpdater which tries to get the HubService from the HubServiceFactory and  that causes all HupService classes to be loaded, but the StandardHubService cannot be instantiated as it instantiates the HttpClient iun its constructor which needs snakeyaml.
Please fix this, so that either StandardHubService does not instantiate the HttpClient in its constructor or even better don't even try to instantiate the HubUpdater if hub mode is off.

The same problem exists for YamlChangeLogParser and interestingly JsonChangeLogParser which extends YamlChangeLogParser.
I ended up for now with this workaround:
diff --git a/src/main/java/net/kautler/liquibase/LiquibaseServiceLocator.java b/src/main/java/net/kautler/liquibase/LiquibaseServiceLocator.java
new file mode 100644
index 0000000..a061ca5
--- /dev/null
+++ b/src/main/java/net/kautler/liquibase/LiquibaseServiceLocator.java
@@ -0,0 +1,35 @@
+package net.kautler.liquibase;
+
+import liquibase.exception.ServiceNotFoundException;
+import liquibase.hub.HubService;
+import liquibase.parser.ChangeLogParser;
+import liquibase.parser.core.xml.XMLChangeLogSAXParser;
+import liquibase.servicelocator.StandardServiceLocator;
+import org.apache.logging.log4j.LogManager;
+
+import java.util.List;
+
+import static java.util.Collections.emptyList;
+import static java.util.Collections.singletonList;
+
+// work-around for https://github.com/liquibase/liquibase/issues/2206
+public class LiquibaseServiceLocator extends StandardServiceLocator {
+    @SuppressWarnings("unchecked")
+    @Override
+    public <T> List<T> findInstances(Class<T> interfaceType) throws ServiceNotFoundException {
+        if (interfaceType == HubService.class) {
+            LogManager.getLogger().debug("Suppressing Liquibase '{}' services", interfaceType.getName());
+            return emptyList();
+        }
+        if (interfaceType == ChangeLogParser.class) {
+            LogManager.getLogger().debug("Suppressing Liquibase '{}' services except for '{}'", interfaceType.getName(), XMLChangeLogSAXParser.class.getName());
+            return singletonList((T) new XMLChangeLogSAXParser());
+        }
+        return super.findInstances(interfaceType);
+    }
+
+    @Override
+    public int getPriority() {
+        return super.getPriority() + 1;
+    }
+}
diff --git a/src/main/resources/META-INF/services/liquibase.servicelocator.ServiceLocator b/src/main/resources/META-INF/services/liquibase.servicelocator.ServiceLocator
new file mode 100644
index 0000000..2958c07
--- /dev/null
+++ b/src/main/resources/META-INF/services/liquibase.servicelocator.ServiceLocator
@@ -0,0 +1 @@
+net.kautler.liquibase.LiquibaseServiceLocator

Hi @Vampire Thanks for this enhancement request.  We will add it to the list of issues to process.


[debug][NDTensors] In-place contraction bug

Description
When computing C = \alpha AB + \beta C, with \beta != 0 there was a bug found that sometimes the tensor C would be evaluated incorrectly. This bug was found to occur when the output labels of C were permuted from the output labels of AB. I.e. C(5,2,4,3) = A(-1, 2,3,4) * B(-1,5) + C(5,2,4,3).  A(-1,2,3,4) * B(-1,5) => R(5,2,3,4) and was matricized to R(5,234) and added to the matricized C(5,243). The addition R(5,234) + C(5,243) has no runtime errors because the size (234) = (243) however numerical errors occurred. This was fixed by permuting C when \beta != 0
Fixes #(issue)
This bug was discovered in this thread https://itensor.discourse.group/t/inplace-multiplication-of-tensors-with-the-same-shape-but-different-indicies/900/16

Could you add a test?

@mtfishman a test has been added to base/test_contract

Codecov Report

Merging #1152 (7507112) into main (708220f) will decrease coverage by 31.03%.
The diff coverage is 71.42%.

:exclamation: Current head 7507112 differs from pull request most recent head 6d57dce. Consider uploading reports for the commit 6d57dce to get more accurate results

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
@@             Coverage Diff             @@
##             main    #1152       +/-   ##
===========================================
- Coverage   85.29%   54.26%   -31.03%
===========================================
  Files          87       86        -1
  Lines        8363     8314       -49
===========================================
- Hits         7133     4512     -2621
- Misses       1230     3802     +2572

Impacted Files
Coverage Δ

src/itensor.jl
80.33% <63.63%> (-1.88%)
:arrow_down:

src/tensor_operations/matrix_decomposition.jl
90.00% <100.00%> (-2.86%)
:arrow_down:

... and 35 files with indirect coverage changes


Timetable File Processing

Describe the task that needs to be done.
Work out how to take in timetable file (only .ics)  and process it to get specific courses (and any other information).
Need to look into the file format and options for upload.
Describe how a solution to your proposed task might look like (and any alternatives considered).
.ics file can be read and relevant information stored in database seperately
Notes
Dependent on database solution being decided and framework implemented - #13

Any update on this issue, since issue 13 was resolved with us moving ahead with H2 for now

Been working on this issue, using an external library (iCal4j) to parse .ics file and get the courses from them.


What's the plan for self-published advisories?

I've just built a tool that natively parses a bunch of different lockfiles and wraps around this repo to determine if there are vulnerable packages.
I've found that GHSA-fq42-c5rg-92c2 is not included in this repo which I'm assuming is because it's a self-published advisory.
I was wondering what the plan is for that situation, as it seems like it's going against the whole point of having this repo if it's not included as e.g. if open source maintainers suddenly got a tool to help them identify issues and so started self-publishing a bunch of advisories, they'd not be included in here.

I see that GHSA-2rr5-8q37-2w7h is in this repo - so I'm assuming it's just a slow process thing? I wonder if it would be possible to speed it up somehow since it's already been three days which seems like a very slow turn around for a security vulnerability.

Hi @G-Rath!
Thanks so much for chiming in. We are most definitely including self-published advisories in the repository!
Let me check into why this one is missing and I'll circle back.

Hi @G-Rath,
Turns out this was a one-off error on our end, thank you for alerting us to it! it's now fixed and you can see this advisory listed in the repository here: https://github.com/github/advisory-database/blob/34b579edf408ba78a02797c4b2430df7068e6253/advisories/github-reviewed/2022/02/GHSA-fq42-c5rg-92c2/GHSA-fq42-c5rg-92c2.json
Cheers,
Kate

@KateCatlin is it possible this has happened again? GHSA-q7rv-6hp3-vh96 was published yesterday but hasn't shown up in the database (both here and in the general advisory search, which I assume searches your private database).


Fix context-carrier issue

When will you publish this version to npm? My trace stucks here, and found this question.


[Bug] php73 - OpenSSL not Detected

Bug Report
Current Behavior
I am running a Laravel app locally and it throws the error
Call to undefined function Illuminate\Encryption\openssl_cipher_iv_length()
Expected Behavior
I haven't had this issue until I reformatted my PC and reinstalled my usual apps under scoop. As indicated, extension=openssl is not commented out in the php.ini file
Additional context/output
php.ini
;;;;;;;;;;;;;;;;;;;;;;
; Dynamic Extensions ;
;;;;;;;;;;;;;;;;;;;;;;
extension=bz2
extension=curl
extension=fileinfo
extension=gd2
extension=gettext
extension=gmp
extension=intl
extension=imap
;extension=interbase
extension=ldap
extension=mbstring
extension=exif      ; Must be after mbstring as it depends on it
extension=mysqli
;extension=oci8_12c  ; Use with Oracle Database 12c Instant Client
;extension=odbc
extension=openssl
;extension=pdo_firebird
extension=pdo_mysql
;extension=pdo_oci
;extension=pdo_odbc
extension=pdo_pgsql
extension=pdo_sqlite
extension=pgsql
extension=shmop

phpinfo():
openssl

OpenSSL support => enabled
OpenSSL Library Version => OpenSSL 1.1.1l  24 Aug 2021
OpenSSL Header Version => OpenSSL 1.1.1l  24 Aug 2021
Openssl default config => C:\usr\local\ssl/openssl.cnf

Directive => Local Value => Master Value
openssl.cafile => no value => no value
openssl.capath => no value => no value

php --ini:
Configuration File (php.ini) Path:
Loaded Configuration File:         (none)
Scan for additional .ini files in: C:\Users\spind\scoop\apps\php73\current\cli;C:\Users\spind\scoop\apps\php73\current\cli\conf.d;
Additional .ini files parsed:      C:\Users\spind\scoop\apps\php73\current\cli\php.ini

System details
Windows version: 11
OS architecture: 64bit
PowerShell version: 5.1.22621.169
Scoop Configuration
{
    "lastUpdate":  "2022-10-01T09:03:49.7239161+08:00",
    "SCOOP_REPO":  "https://github.com/ScoopInstaller/Scoop",
    "SCOOP_BRANCH":  "master"
}

UPDATE:
I just tried using XAMPP's php.exe and all valet test sites loaded. I failed to mention earlier that each local site also loads when served via php artisan serve.


IMU Gravity Vector Test

Hello everyone,
first of all, thank you for the great work and the great repository!
After I ran the ICL dataset successfully, I asked myself if you also included some code to test your method with the IMU gravity vector instead of RGBD. I personally did not find any code on the IMU part in the repository, did I oversee it or is there no demo code for that part of the method provided?
Thank you already for your help!

Hi xlDownxl,
You are right! There is no demo code for the IMU gravity vector case.
But it is super easy to extend from the RGB-D case to the IMU gravity vector case.
All you have to do is just to update the variable "planeNormalVector" not from RGBD, but from IMU gravity vector data.
FYI, you can easily obtain the gravity direction vector using iOS or Android API.
https://developer.apple.com/documentation/coremotion/getting_processed_device-motion_data
Thanks,
Pyojin Kim.

Hey Pyojin,
Thank for you quick reply!
I recorded a dataset containing of RGBD images as well as Gravity Vectors with an iPhone as detailed in the link you posted.
Then, I replaced the variable "planeNormalVector" with the gravity vector as you suggested.
The issue I am facing now is that after some frames are processed successfully, the script crashes because it can not find the corresponding vanishing points between the previous and current frame. I observed the value of  R_cM_new changing from:
-0.9944    0.0989    0.0380
0.0723    0.3715    0.9256
0.0774    0.9232   -0.3765
to:
-0.3495    0.9361    0.0398
0.3634    0.0963    0.9266
0.8636    0.3384   -0.3739
within one frame. The last column shows the gravity vector which, as one can see, did not change much (the camera movement is very small).
I already tried a few things, but I have not been able to fix this problem myself. I forked your repository here and added my gravity vector dataset to it: https://github.com/xlDownxl/MWMS.
It would mean a lot to me if you could take a quick look at it and suggest some future steps for me.
Again, thanks for the great work and code!
Best Regards
Niclas


Add an nRF Timer driver

Resolves #189
This is a fairly low-level driver, just providing a safe wrapper over the peripheral with the addition of waiting for a CC register's COMPARE event to be fired.

The one bit I'm not sure about is new_irqless constructing a Timer instance that won't fully work. We should have some way to enforce wait is only called on timers with irq. Either two different drivers, or a generic param with marker types Irq, NoIrq.

new_irqless isn't actually public, it was just a hack to avoid BufferedUarte and co taking a timer interrupt when they don't really need it. I could just remove it and change those back to using the PAC directly.

Alternatively: What's your use case for awaiting a timer CC? To me it seems most of the "waiting" is already covered by the Clock implementation with the RTC. Given this, maybe this raw Timer driver is useful for PPI stuff only, and it can simply not have async wait support? Not every driver in embassy needs to be async :)
(The only drawback of Clock is it has max 32khz precision, but that could be solved by making another Clock impl that uses a Timer instead of the RTC.)

I was just using it as a higher-precision alternative to Clock. Timer couldn't actually implement Clock, though, since their counters cap out at 32 bits and would overflow within a few days even at their lowest frequency.
I think it could also be useful if you're using it for PPI and want to wait for something.

new_irqless isn't actually public,

Ooh, I hadn't noticed that. If the footgun is not public then I'm OK with it :)

Timer couldn't actually implement Clock, though, since their counters cap out at 32 bits and would overflow within a few days even at their lowest frequency

RTC is 24bit, at 32khz it overflows in 500 seconds. The driver sets a compare event "halfway" to count overflows, so it can "extend" it to 64 bits which never overflows. Same trick could be done for a Timer impl.

I think it could also be useful if you're using it for PPI and want to wait for something.

True... Like, waiting for a stopped channel that's later started by PPI and then wakes the CPU after timing out.


Pull requirement comments from Valispace

What has to be done
There are comments on requirements in Valispace that should be reviewed and migrated as appropriate.  Some are rationale for requirements. Others are questions or change requests that should probably be PRs against the requirement.
Subtasks:

[-] Add subtasks or sections of content if applicable
[-] Identify documentation that should be updated upon completion

How do you know it has to be done
We don't want to loose this information
Starting points
Go to Valispace and review the comments. Disposition according to their content.
Don't forget

[x] Put the issue in a milestone
[x] Assign it to one of the projects
[x] Add appropriate labels
[x] Mention dependent/blocked issues if any

Relates to issue #803

Done


PICO_BOARD=pico --> lwip/tcp.h: No such file or directory

Hi,
if I compile it with PICO_BOARD=pico, I'm getting the following error:
Fatal error: lwip/tcp.h: No such file or directory
The code should be compatible with the Pico too, not only with the Pico W.
Can you change it?
I can also change it and put a merge request.
Thank you
Kr
pingu

It works on the pico with defining the pico_w :). Anyways, it's a nice 2 have.


Feature request: Add PWA support

I like your project very much, but having an additional tab always open (or opening it every time) is (from the lack of a better word) tedious.
PWA support would allow for easier access and from what I have seen it shouldn't be hard to add (though I have no experience so it's a bit hard to say)

+1 on PWA. Its currently hard to track media watched having to go to a browser and update vs being able to open an app that is much easier to access


Update to PhantomJS 2.1.1

Hello, phantomjs 2.1.1 has been released, can you update the repo to download it ? The binaries are here: https://bitbucket.org/ariya/phantomjs/downloads/

@ocombe  Thanks. I'll tried to update link soon!

\o/
Thanks !

@ocombe Ohhh, sorry.
Now I'm fully focused on contributing to the WebKit, and quite hard to me find some time to fix issues in this project.


speed up reverse iteration, add more illustrious benchmark modes to I…

I observed a good speed up replacing the call to Long.reverse with Long.numberOfLeadingZeroes. I took the liberty of adding SampleTime and Throughput benchmark modes to IteratorsBenchmark, and changed the timeunit to milliseconds since most benchmarks were taking at least thousands of microseconds.
Before:
Benchmark                                                                   Mode   Cnt     Score      Error   Units
IteratorsBenchmark.testReverseStandard_a                                   thrpt     5     1.414 ±    0.284  ops/ms
IteratorsBenchmark.testReverseStandard_b                                   thrpt     5     0.008 ±    0.001  ops/ms
IteratorsBenchmark.testReverseStandard_c                                   thrpt     5     0.001 ±    0.001  ops/ms
IteratorsBenchmark.testReverseStandard_a                                    avgt     5     0.730 ±    0.195   ms/op
IteratorsBenchmark.testReverseStandard_b                                    avgt     5   138.611 ±   33.262   ms/op
IteratorsBenchmark.testReverseStandard_c                                    avgt     5  1903.108 ±  987.489   ms/op
IteratorsBenchmark.testReverseStandard_a                                  sample  4215     1.189 ±    0.022   ms/op
IteratorsBenchmark.testReverseStandard_a:testReverseStandard_a·p0.00      sample           0.611              ms/op
IteratorsBenchmark.testReverseStandard_a:testReverseStandard_a·p0.50      sample           1.288              ms/op
IteratorsBenchmark.testReverseStandard_a:testReverseStandard_a·p0.90      sample           1.788              ms/op
IteratorsBenchmark.testReverseStandard_a:testReverseStandard_a·p0.95      sample           1.849              ms/op
IteratorsBenchmark.testReverseStandard_a:testReverseStandard_a·p0.99      sample           2.241              ms/op
IteratorsBenchmark.testReverseStandard_a:testReverseStandard_a·p0.999     sample           3.438              ms/op
IteratorsBenchmark.testReverseStandard_a:testReverseStandard_a·p0.9999    sample           5.554              ms/op
IteratorsBenchmark.testReverseStandard_a:testReverseStandard_a·p1.00      sample           5.554              ms/op
IteratorsBenchmark.testReverseStandard_b                                  sample    28   201.547 ±   25.650   ms/op
IteratorsBenchmark.testReverseStandard_b:testReverseStandard_b·p0.00      sample         111.411              ms/op
IteratorsBenchmark.testReverseStandard_b:testReverseStandard_b·p0.50      sample         214.434              ms/op
IteratorsBenchmark.testReverseStandard_b:testReverseStandard_b·p0.90      sample         217.396              ms/op
IteratorsBenchmark.testReverseStandard_b:testReverseStandard_b·p0.95      sample         255.879              ms/op
IteratorsBenchmark.testReverseStandard_b:testReverseStandard_b·p0.99      sample         286.786              ms/op
IteratorsBenchmark.testReverseStandard_b:testReverseStandard_b·p0.999     sample         286.786              ms/op
IteratorsBenchmark.testReverseStandard_b:testReverseStandard_b·p0.9999    sample         286.786              ms/op
IteratorsBenchmark.testReverseStandard_b:testReverseStandard_b·p1.00      sample         286.786              ms/op
IteratorsBenchmark.testReverseStandard_c                                  sample     5  2223.401 ± 1005.708   ms/op
IteratorsBenchmark.testReverseStandard_c:testReverseStandard_c·p0.00      sample        1772.093              ms/op
IteratorsBenchmark.testReverseStandard_c:testReverseStandard_c·p0.50      sample        2319.450              ms/op
IteratorsBenchmark.testReverseStandard_c:testReverseStandard_c·p0.90      sample        2432.696              ms/op
IteratorsBenchmark.testReverseStandard_c:testReverseStandard_c·p0.95      sample        2432.696              ms/op
IteratorsBenchmark.testReverseStandard_c:testReverseStandard_c·p0.99      sample        2432.696              ms/op
IteratorsBenchmark.testReverseStandard_c:testReverseStandard_c·p0.999     sample        2432.696              ms/op
IteratorsBenchmark.testReverseStandard_c:testReverseStandard_c·p0.9999    sample        2432.696              ms/op
IteratorsBenchmark.testReverseStandard_c:testReverseStandard_c·p1.00      sample        2432.696              ms/op

After:
Benchmark                                                                   Mode   Cnt     Score     Error   Units

IteratorsBenchmark.testReverseStandard_a                                   thrpt     5     1.380 ±   0.231  ops/ms
IteratorsBenchmark.testReverseStandard_b                                   thrpt     5     0.008 ±   0.002  ops/ms
IteratorsBenchmark.testReverseStandard_c                                   thrpt     5     0.001 ±   0.001  ops/ms
IteratorsBenchmark.testReverseStandard_a                                    avgt     5     0.705 ±   0.151   ms/op
IteratorsBenchmark.testReverseStandard_b                                    avgt     5   131.287 ±  39.452   ms/op
IteratorsBenchmark.testReverseStandard_c                                    avgt     5  1493.856 ± 147.338   ms/op
IteratorsBenchmark.testReverseStandard_a                                  sample  5682     0.886 ±   0.017   ms/op
IteratorsBenchmark.testReverseStandard_a:testReverseStandard_a·p0.00      sample           0.613             ms/op
IteratorsBenchmark.testReverseStandard_a:testReverseStandard_a·p0.50      sample           0.671             ms/op
IteratorsBenchmark.testReverseStandard_a:testReverseStandard_a·p0.90      sample           1.489             ms/op
IteratorsBenchmark.testReverseStandard_a:testReverseStandard_a·p0.95      sample           1.589             ms/op
IteratorsBenchmark.testReverseStandard_a:testReverseStandard_a·p0.99      sample           1.913             ms/op
IteratorsBenchmark.testReverseStandard_a:testReverseStandard_a·p0.999     sample           3.509             ms/op
IteratorsBenchmark.testReverseStandard_a:testReverseStandard_a·p0.9999    sample           8.585             ms/op
IteratorsBenchmark.testReverseStandard_a:testReverseStandard_a·p1.00      sample           8.585             ms/op
IteratorsBenchmark.testReverseStandard_b                                  sample    40   133.038 ±  14.202   ms/op
IteratorsBenchmark.testReverseStandard_b:testReverseStandard_b·p0.00      sample         111.018             ms/op
IteratorsBenchmark.testReverseStandard_b:testReverseStandard_b·p0.50      sample         125.829             ms/op
IteratorsBenchmark.testReverseStandard_b:testReverseStandard_b·p0.90      sample         179.149             ms/op
IteratorsBenchmark.testReverseStandard_b:testReverseStandard_b·p0.95      sample         187.092             ms/op
IteratorsBenchmark.testReverseStandard_b:testReverseStandard_b·p0.99      sample         201.064             ms/op
IteratorsBenchmark.testReverseStandard_b:testReverseStandard_b·p0.999     sample         201.064             ms/op
IteratorsBenchmark.testReverseStandard_b:testReverseStandard_b·p0.9999    sample         201.064             ms/op
IteratorsBenchmark.testReverseStandard_b:testReverseStandard_b·p1.00      sample         201.064             ms/op
IteratorsBenchmark.testReverseStandard_c                                  sample     5  1469.684 ± 318.615   ms/op
IteratorsBenchmark.testReverseStandard_c:testReverseStandard_c·p0.00      sample        1379.926             ms/op
IteratorsBenchmark.testReverseStandard_c:testReverseStandard_c·p0.50      sample        1442.841             ms/op
IteratorsBenchmark.testReverseStandard_c:testReverseStandard_c·p0.90      sample        1591.738             ms/op
IteratorsBenchmark.testReverseStandard_c:testReverseStandard_c·p0.95      sample        1591.738             ms/op
IteratorsBenchmark.testReverseStandard_c:testReverseStandard_c·p0.99      sample        1591.738             ms/op
IteratorsBenchmark.testReverseStandard_c:testReverseStandard_c·p0.999     sample        1591.738             ms/op
IteratorsBenchmark.testReverseStandard_c:testReverseStandard_c·p0.9999    sample        1591.738             ms/op
IteratorsBenchmark.testReverseStandard_c:testReverseStandard_c·p1.00      sample        1591.738             ms/op

Coverage decreased (-0.007%) to 89.899% when pulling 2f5a16c4f01252b1227fc04b4c7ef31253130915 on richardstartin:reverse-iterator into ab8676842a58a34b15edd7a01965665e249d10ac on RoaringBitmap:master.

Addressing  #139

Looking good to me.

@richardstartin
I think that this is good.
I left a tiny comment. I don't think it is worth doing anything about it, so I will merge your code.
Thanks @Kineolyan


Development

Merge all the recent master changes into development.

@BusseChristian Sorry Christian, I should have explained this better. This is just what I call an "auto-merge". There are a bunch of changes on the master branch which do not exist on the development branch, this situation really shouldn't occur and needs to be fixed, as it will cause conflicts down the road when trying to merge development into master. How this happened is that changes were committed onto master after the development branch was created. Generally this should be avoided except in special circumstances.
I left it as pull request for you to review because if you are working on development, you will see a bunch of changes come in, and I didn't want to surprise you. So you should accept this request "as-is", this will bring master and development into sync, then any "clean up" work (e.g. get rid of files, etc.) is done on development, and it will avoid conflicts down the road.

@schristley Sorry, if I got confused, but on the top it says "... wants to merge 12 commits into master from development", with is the opposite direction than the one you were describing. What is it that I'm not getting?

@BusseChristian Good catch! yes, you are right, the merge is the wrong way. I created a new pull request which should go the right way.


test: added test for PHP constraint

Description
Added test for php constraint
Related Issue
fix: #1668

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.01%) to 92.307%

Totals

Change from base Build<PHONE_NUMBER>:
0.01%

Covered Lines:
5865

Relevant Lines:
6192

💛  - Coveralls

@jonaslagoni can you review it?

@Ferror do you have time to take a look at this?

/rtm


Revert "ci: add build attest"

Reverts Enter-tainer/typstyle#204

We should only enable it for releases. But currently I don't have time to maintain it.


Images don't scale to mobile resolution

Images show up too wide on mobile. They should scale dependent on the viewport width (vw unit in CSS).

Not happening.


Kubernetes icons don't appear in the diagram

Hi @dcasati I was trying to get started with generating K8s plantuml diagram for sample example kuberentes.puml however kubernetes icons seems missing in the generated diagram (preview). Can you suggest if I am missing something here. Thanks!

hey @vishal-yadav! It's to say from the text, could you please paste your config here ? I can try to check on my machine :)

By config if you mean puml file then it's exactly the same sample/kubernetes.puml in repo.
@startuml kubernetes

footer Kubernetes Plant-UML
scale max 1024 width

skinparam nodesep 10
skinparam ranksep 10

' Kubernetes
!includeurl https://raw.githubusercontent.com/dcasati/kubernetes-PlantUML/master/dist/kubernetes_Context.puml

!define KubernetesPuml https://raw.githubusercontent.com/dcasati/kubernetes-PlantUML/master/dist

!includeurl KubernetesPuml/kubernetes_Context.puml
!includeurl KubernetesPuml/kubernetes_Simplified.puml

!includeurl KubernetesPuml/OSS/KubernetesApi.puml
!includeurl KubernetesPuml/OSS/KubernetesSvc.puml
!includeurl KubernetesPuml/OSS/KubernetesIng.puml
!includeurl KubernetesPuml/OSS/KubernetesPod.puml
!includeurl KubernetesPuml/OSS/KubernetesRs.puml
!includeurl KubernetesPuml/OSS/KubernetesDeploy.puml
!includeurl KubernetesPuml/OSS/KubernetesHpa.puml

actor "User" as userAlias
left to right direction

' Kubernetes Components
Cluster_Boundary(cluster, "Kubernetes Cluster") {
    Namespace_Boundary(ns, "Back End") {
        KubernetesIng(ingress, "your.domain.com", "")
        KubernetesSvc(svc, "service", "")
        KubernetesPod(pod1, "pod1", "")
        KubernetesPod(pod2, "pod2", "")
        KubernetesPod(pod3, "pod3", "")

        KubernetesRs(rs,"","")
        KubernetesDeploy(deploy,"deployment","")
        KubernetesHpa(hpa, "HPA", "")
    }
}

Rel(userAlias,ingress," ")
Rel(ingress,svc," ")

Rel(svc,pod1," ")
Rel(svc,pod2," ")
Rel(svc,pod3," ")

Rel_U(rs,pod1," ")
Rel_U(rs,pod2," ")
Rel_U(rs,pod3," ")

Rel_U(deploy,rs, " ")
Rel_U(hpa,deploy, " ")

@enduml

Looks like I may be missing some package/dependency (in addition to pre-requisite graphviz) on my CentOS VM. The sample example works with VS code on my Windows machine.


I can't seem to precache a 404.html page

I can precache all other files, I'm using firebase for hosting and use a 404.html page. service worker error 404 (Not Found) for the 404.html file. I know it exists and the path is correct. any suggestions?

How is your web server configured to respond to direct GET requests for 404.html? It sounds like it's responding with a status code of 404, which tells sw-precache that the request resulted in an error, and that the response is therefore not valid.
You'd want to configure your web server so that if there's a direct GET requests for 404.html, it should respond with the HTML contents of 404.html, along with an HTTP status code of 200.
Your web server can still be configured to respond to requests for invalid URLs, like GET does_not_exist.html, with the HTML contents of 404.html and the HTTP status code of 404.
Your choice of web server determines what the actual configuration to get that behavior would look like, and I'm not sure that I'd be of help there.


TS-4329 Off-by-one error in NULL terminator for aname in hostdb

:+1: ink_strlcpy will deal with the null terminator, looks good.


Added LIGHTIFY LED adjustable color RT 5/6

Added support for Sylvania OSRAM LIGHTIFY LED adjustable full-color RT 5/6
https://www.amazon.com/SYLVANIA-Recessed-Lighting-Changing-Dimmable/dp/B0196M601A

Could you remove the formatting changes?

Yep, sorry--forgot my editor auto-formats.

Thanks!


Sort challenges by Popularity (number of stars)

Filter inspired by Kaggle.

[ ] Update OpenAPI description (@tschaffter )
[ ] Implement backend (@tschaffter )
[ ] Implement frontend (@rrchai )

Depends on #1113

Closed as all tasks are completed.


Create descriptions file

Missing pattern titles

Just confirmed and seems like the only patterns that don't have a proper title are prefixed.
Seems like we have two types of prefixes: ps and DSC.
Can we move the code to files? It is getting pretty messy and since we are already doing multi-layer builds why not make this less bad with all those escapes.


net/mail: wrong error message for ParseAddress(John "Doe<EMAIL_ADDRESS>

Please answer these questions before submitting your issue. Thanks!
What did you do?
If possible, provide a recipe for reproducing the error.
A complete runnable program is good.
A link on play.golang.org is best.
package main

import (
	"fmt"
	"net/mail"
)

func main() {
	fmt.Println(mail.ParseAddress(`John "Doe  <john@example.com>`))
}

What did you expect to see?
 mail: unclosed quoted-string
What did you see instead?
 mail: no angle-addr
Does this issue reproduce with the latest release (go1.8)?
I think so
System details
go version devel +192b57c Tue Mar 7 23:55:22 2017 +0900 darwin/amd64
GOARCH="amd64"
GOBIN=""
GOEXE=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GOOS="darwin"
GOPATH="/Users/hiro/.go"
GORACE=""
GOROOT="/Users/hiro/go"
GOTOOLDIR="/Users/hiro/go/pkg/tool/darwin_amd64"
GCCGO="gccgo"
CC="clang"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/wq/dwn8hs0x7njbzty9f68y61700000gn/T/go-build363637865=/tmp/go-build -gno-record-gcc-switches -fno-common"
CXX="clang++"
CGO_ENABLED="1"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOROOT/bin/go version: go version devel +192b57c Tue Mar 7 23:55:22 2017 +0900 darwin/amd64
GOROOT/bin/go tool compile -V: compile version devel +192b57c Tue Mar 7 23:55:22 2017 +0900 X:framepointer
uname -v: Darwin Kernel Version 16.4.0: Thu Dec 22 22:53:21 PST 2016; root:xnu-3789.41.3~3/RELEASE_X86_64
ProductName:	Mac OS X
ProductVersion:	10.12.3
BuildVersion:	16D32
lldb --version: lldb-360.1.70
gdb --version: GNU gdb (GDB) 7.12.1

Closed by the discussion on the CL 37910


Crash on pRemoteCharacteristic->getDescriptor(BLEUUID("0x2902"))->writeValue((uint8_t*)notificationOn, 2, true);

Get guaranteed processor reset on line
pRemoteCharacteristic->getDescriptor(BLEUUID("0x2902"))->writeValue((uint8_t*)notificationOn, 2, true);

Guru Meditation Error: Core  1 panic'ed (LoadProhibited). Exception was unhandled.
Core 1 register dump:
PC      : 0x400d52b2  PS      : 0x00060530  A0      : 0x800d17cc  A1      : 0x3ffc7130
A2      : 0x00000000  A3      : 0x3f4003fc  A4      : 0x00000002  A5      : 0x00000001
A6      : 0x3ffc425c  A7      : 0x0000fc72  A8      : 0x800d4761  A9      : 0x3ffc7110
A10     : 0x3ffc715c  A11     : 0xf8acc258  A12     : 0x3ffc425c  A13     : 0xf8acc258
A14     : 0x00ff0000  A15     : 0xff000000  SAR     : 0x00000010  EXCCAUSE: 0x0000001c
EXCVADDR: 0x00000030  LBEG    : 0x4000c2e0  LEND    : 0x4000c2f6  LCOUNT  : 0xffffffff

The characteristic is:

Blood Pressure (0x1810)

Blood Pressure Measurement [I] (0x2A35)
 Client Characteristic Configuration (0x2902)
Blood Pressure Feature [R] (0x2A49)
Date Time [R W] (0x2A08)

Code is:
    if(pRemoteCharacteristic->canRead())                                                //pRemoteCharacteristic->canRead() ВОЗВРАЩАЕТ 0
    {
      std::string value = pRemoteCharacteristic->readValue();
      Serial.print("The characteristic value was: ");
      Serial.println(value.c_str());
    }
    else
      {
        Serial.println("pRemoteCharacteristic->canRead() = 0");
      }
    if(pRemoteCharacteristic->canIndicate())                                            //pRemoteCharacteristic->canNotify() ВОЗВРАЩАЕТ 0
      {
          pRemoteCharacteristic->registerForNotify(notifyCallback, false);              //pRemoteCharacteristic->canIndicate() ВОЗВРАЩАЕТ 1
      }                                                                                //false for listen indications and true for listen notifications
    else
      {
        Serial.println("pRemoteCharacteristic->canIndicate() = 0");
      }
    pRemoteCharacteristic->getDescriptor(BLEUUID("0x2902"))->writeValue((uint8_t*)notificationOn, 2, true);

Last line give the reset.
Log:

Starting Arduino BLE Client application...
BLE Advertised Device found: Name: A&D_UA-651BLE_8FCFAC, Address: 34:14:b5:8f:cf:ac, serviceUUID: 00001810-0000-1000-8000-00805f9b34fb, txPower: 0
Forming a connection to 34:14:b5:8f:cf:ac

Connected to server
Found our service
Found our characteristic

// The remote service we wish to connect to.
static BLEUUID serviceUUID("00001810-0000-1000-8000-00805f9b34fb");
// The characteristic of the remote service we are interested in.
static BLEUUID    charUUID("00002a35-0000-1000-8000-00805f9b34fb");

Please, help me. Thank you.

Is there any reason you want this characteristic notifications?
As far as i remember it is used only to inform about service change on peer device and almost never is used.

Perhaps I do not understand something. I need to read the pressure from the tonometer. As shows nRFConnect, the characteristic 2A35 has no value

, but has the property of notification. How then can I read the pressure value?

Sorry, my bad. I didnt work with BLE for some time and mixed 0x1810 with 0x1801 service UUIDs and 0x2A35 and 0x2A05 char UUIDs.

My suggestion is to do it this way:
BLE2902 p2902 = pRemoteCharacteristic->getDescriptor(BLEUUID("0x2902"));
if(p2902 != nullptr) p2902->writeValue((uint8_t*)indicationOn, 2, true);

I may be wrong, but enable indicate should be 0x01, not 0x02;

Thank you are for code. Now processor is not reset, but indicate still does not work yet. I corrected your code a little. BLE2902 p2902 =... does not compile. Error is:

'BLE2902' was not declared in this scope

I change this to:

BLERemoteDescriptor* p2902 =...

And second as explained here :
https://github.com/nkolban/esp32-snippets/issues/618#issuecomment-423824201
BLEUUID("0x2902") is not working. The correct way is:
getDescriptor(BLEUUID((uint16_t)0x2902));
So the code:

const uint8_t indicationOn[] =  {0x1, 0x0};

const uint8_t indicationOff[] = {0x0, 0x0};

BLERemoteDescriptor* p2902 = pRemoteCharacteristic->getDescriptor(BLEUUID((uint16_t)0x2902));
if(p2902 != nullptr)
{
  p2902->writeValue((uint8_t*)indicationOn, 2, true);
  Serial.println("p2902!!!");
}

At least finds the handle and does not reset the processor. I have moved forward a bit. Many thanks.

Yes. Like i said, i did not work with BLE for some time, thus so many little bugs, but im glad you fixed them.
What i can suggest is:

after connecting with esp32 you can try to connect with nRF connect and check if indications are enabled on 0x2902 (i am guessing it is disabled when you connect just with nRF connect)
try to add custom callbacks, which has been added to library for better debugging, you can find more info in few issues here
https://github.com/nkolban/esp32-snippets/blob/master/cpp_utils/BLEDevice.h#L27-L29
https://github.com/nkolban/esp32-snippets/blob/master/cpp_utils/BLEDevice.h#L60-L62

Thanks for the answer.  Perhaps I did something wrong.

I wanted to say that the code
    BLERemoteDescriptor* p2902 = pRemoteCharacteristic->getDescriptor(BLEUUID((uint16_t)0x2902));     if(p2902 != nullptr)      {       pRemoteCharacteristic->getDescriptor(BLEUUID((uint16_t)0x2902))->writeValue((uint8_t*)indicationOn, 2, true);       //p2902->writeValue((uint8_t*)indicationOn, 2, true);        Serial.println("p2902!!!");     }
Works too. The processor was reset when I connected witn  charUUID not equal charUUID("00002a35");. Where there is no charUUID ("00002902") ;. If you do not check for the presence of charUUID ("00002902"), we will get a reset.

Hello,
I am also stuck on the same problem . Were you able to pull BP data from the unit?

.


[Issues] The VFX point desapears if don't have the correct rotation

Seems that the VFX graph using the point cloud doen't render if don't have the "correct" point of view.
In my case, seems that if the z axis of the point cloud it's not aligned with the camera, this vfx it's not rendered. Even in the editor "scene".

Use the orientation block with the FaceCameraPlane/FaceCameraPosition options.
<EMAIL_ADDRESS>

I'm closing this issue as irrelevant (this is not a question about Pcx but general use of VFX Graph). Please feel free to reopen it for further problems.

I resolved the problem.
This is the solution in the case you are using planes as output: Use the orientation block with the FaceCameraPlane/FaceCameraPosition options.
But I was using "Lit Cubes" as output. So, the problem was in the point cloud pivot. When it goes out of the camera fustrum, the particle system disapears.
So, in the case you are using Sketchfab point clouds and the pivot is not in the center, you can edit it with a blender plugin.
I followed this tutorial to do that: Point cloud visualizer
Anyway, as Kejiro said, this issue is irrelevand for the project.

In that case,  you can extend the bounding box to avoid being culled. Use the Bounds property in the Initialize context.
<EMAIL_ADDRESS>


Update and use token in database when creating a session

This change updates the user's token each time they sign in. The token used to be saved once, when the token in the database was null, and never updated again.
This change also requires a token be saved in the database and will redirect to the landing page if token is null. We used to allow users to sign in without saving a token to prevent currently authenticated users from going back through the auth flow.
This also sets us up for having two levels of access in Hound since we are updating the token during auth flow.

Looks great!


Error: Cannot find module 'xmlbuilder'

Hi @mkaag
Thanks for the ionic docker.
I have run docker build command successfully at my local.
When I run docker run at my ubuntu machine, I ran into below error
➜  StudyProjects sudo docker run -ti -p 8100:8100 -p 35729:35729 mkaag/ionic

Error: Cannot find module 'xmlbuilder'
    at Function.Module._resolveFilename (module.js:338:15)
    at Function.Module._load (module.js:280:25)
    at Module.require (module.js:364:17)
    at require (module.js:380:17)
    at Object.<anonymous> (/usr/local/lib/node_modules/ionic/node_modules/xml2js/lib/xml2js.js:12:13)
    at Object.<anonymous> (/usr/local/lib/node_modules/ionic/node_modules/xml2js/lib/xml2js.js:436:4)
    at Module._compile (module.js:456:26)
    at Object.Module._extensions..js (module.js:474:10)
    at Module.load (module.js:356:32)
    at Function.Module._load (module.js:312:12)
```

Can you please help me to solve this?

Hello @ketan-ghumatkar,
the image has no ionic sources to run from. I would suggest to initiate a ionic project (i.e.: ionic start myApp sidemenu), then run npm install. From there you will be able to run any ionic command.
Also pay attention to the file and folder ownership.
Have a try and let me know.
Regards,
Maurice

Even I am facing the same issue. @mkaag any idea why this may be happening? I tried running it with a sample ionic project.
P.S. Thanks for the docker image though :)


Relax Rails version constraint

I think this is only relevant for tests and development, anyway? This should help to ensure that it still works with the latest versions of Rails.

Hmm, from the test failures, it looks like there are some incompatibilities with Rails 8.0, which I don't feel like fixing right now. Closing.


4B4F07D7 - Fatal Inertia

Marketplace
Tested on (https://github.com/xenia-canary/xenia-canary/commit/5d39e520e32a42af18e56b8b6af642a70f3a4716) canary
Log:
xenia.zip
Screenshot(s):

Labels:
state-playable tech-engine-unrealengine

hi do u know why is crashing on new build?

I'm using April 10 2021 master build an it crash on boot.

I'm using April 10 2021 master build an it crash on boot.

Regression confirmed, will need to track down builds that started it


Clean up code formatting with lint rules

This PR applies fixes for ESLint formatting rules that will be part of the default lint config (see #9976). These are formatting only rules, so they only change whitespace, semicolons, commas and the like. This PR represents no functional changes.
Most of the fixes were auto-fixes, with the exception of some function spacing issues that spanned lines.
Notes
The @fluid-experimental/tree project uses a different formatting style. I didn't make changes to it in this PR, but I'll follow up with another PR, a tracking issue, or a comment in the project README explaining why the formatting differs.
Rules applied
The rules applied are:
// Enforce consistent brace style for blocks.
"@typescript-eslint/brace-style": [
    "warn",
    "1tbs",
    {
        "allowSingleLine": true,
    },
],

// Use dangling commas where possible.
"@typescript-eslint/comma-dangle": [
    "error",
    "always-multiline",
],

// Enforces consistent spacing before and after commas.
"@typescript-eslint/comma-spacing": "error",

// Enforces no space between functions and their invocation.
"@typescript-eslint/func-call-spacing": "error",

// Enforces keyword spacing.
"@typescript-eslint/keyword-spacing": "error",

// Standardize using semicolons to delimit members for interfaces and type literals.
"@typescript-eslint/member-delimiter-style": "error",

// Enforces spacing in curly brackets.
"@typescript-eslint/object-curly-spacing": [
    "error",
    "always",
],

// Enforce the consistent use of double quotes.
"@typescript-eslint/quotes": [
    "error",
    "double",
    {
        "allowTemplateLiterals": true,
        "avoidEscape": true
    }
],

// Enforces consistent use of semicolons after statements.
"@typescript-eslint/semi": [
    "error",
    "always"
],

// Enforces consistent spacing before function parentheses.
"@typescript-eslint/space-before-function-paren": [
    "error",
    {
        "anonymous": "never",
        "asyncArrow": "always",
        "named": "never"
    }
],

// This rule is aimed at ensuring there are spaces around infix operators.
"@typescript-eslint/space-infix-ops": "error",

// Require consistent spacing around type annotations.
"@typescript-eslint/type-annotation-spacing": "error",

// Disallows spaces inside of brackets.
"array-bracket-spacing": "error",

// Requires consistent usage of linebreaks between array elements.
"array-element-newline": [
    "error",
    "consistent"
],

// Require parens around arrow function arguments.
"arrow-parens": [
    "error",
    "always"
    ],

// Requires space before and after arrow function's arrow.
"arrow-spacing": "error",

// Enforces spaces inside of blocks after opening blocks and before closing blocks.
"block-spacing": "error",

// Disallows spaces between the brackets and the values inside of them.
"computed-property-spacing": "error",

// Requires following curly brace conventions.
"curly": "error",

// Prevents the use of mixed newlines around the dot in a member expression.
"dot-location": [
    "error",
    "property",
],

// Enforce a consistent location for an arrow function containing an implicit return.
"implicit-arrow-linebreak": "error",

// Enforces consistent quotes in JSX attributes.
"jsx-quotes": "error",

// Enforces consistent spacing between keys and values in object literal properties.
"key-spacing": "error",

// Requires parentheses when invoking a constructor with no arguments.
"new-parens": "error",

// Disallows multiple consecutive spaces.
"no-multi-spaces": [
    "error",
    {
        "ignoreEOLComments": true
    }
],

// Prevent multiple empty lines.
"no-multiple-empty-lines": [
    "error",
    {
        "max": 1,
        "maxBOF": 0,
        "maxEOF": 0,
    }
],

// Disallows whitespace before properties.
"no-whitespace-before-property": "error",

// Disallows use of the void operator.
"no-void": "error",

// Enforces consistent line breaks after opening and before closing braces.
"object-curly-newline": "error",

// Disallows empty lines at the beginning and ending of block statements, function bodies, class static blocks,
// classes, and switch statements.
"padded-blocks": [
    "error",
    "never"
],

// Require quotes around object literal property names.
"quote-props": [
    "error",
    "consistent-as-needed"
],

// Enforce spaces after, but not before, semicolons.
"semi-spacing": "error",

// Enforce consistent spacing before blocks.
"space-before-blocks": "error",

// Enforce consistent spacing inside parentheses.
"space-in-parens": [
    "error",
    "never"
],

// Enforces consistency regarding the spaces after/before unary operators.
"space-unary-ops": "error",

// Enforces consistent spacing after the // or /* in a comment.
"spaced-comment": [
    "error",
    "always",
    {
        "block": {
            "markers": ["!"],
            "balanced": true
        }
    }
],

// Enforces spacing around colons of switch statements.
"switch-colon-spacing": "error",

// Enforces usage of spacing in template strings.
"template-curly-spacing": "error",

Replaced by #10056. Closing.


Rename Heading from additional-material to include the work git/workflow

The current heading for additional material on the README is a little misleading.
🐞 Problem
The links at this heading https://github.com/Roshanjossey/first-contributions#-additional-material-
is giving us more information about the Git/Github workflow. But the title of the heading Additional Material does not convey this, unless one clicks on it and then discovers it.
Renaming this heading to make the hyper-linked content more explicit would help :)
🎯 Goal
Make the title of the heading more consistent with the content it points to.
💡 Possible solutions
Rename the title to Addition Git Information, Advanced Git Workflow, Good to Know Git Scenarios, Advanced Git Techniques
Probable Lables: enhancement, suggestion, doc

Fixed in #2791


Migrate to TypeScript project

Migrate to TypeScript project to resolve https://github.com/knocknote/pixi-after-effects/issues/13
Changed Summary

replace *.js to *.ts
remove Babel
migrate from eslint to typescript-eslint
generate .d.ts files at yarn build
introduce prettier and do format by it
Of course, supports PIXI.js v4 and v5

What's the blocker now?

Maybe I can do this in a better way, so I can open a new PR if necessary.

@imbsky
Thank you for the reaction !!
I will act again for the merge this PR .

Great.


Add proxy server support

Add proxy argument to instaloader.Instaloader class
Add proxy option to __main__.py

why not insert the possibility ti use also username and password proxy authentication ?
thanks

if you will add proxy please atention sock and http such as tor

I close this pull request due to its long inactivity despite its pending issues. Please reopen when there are any updates.

It would be awesome if proxy support is added on the next release.

This doesn not seem to work for me , still getting:
    raise LoginRequiredException("Redirected to login page. Use --login.") instaloader.exceptions.LoginRequiredException: Redirected to login page. Use --login.


Fixed #25 : Layout Fixing

Updated the main section to be responsive and have a grid layout for a better look overall. Now the output is next to the selector, and a user can directly compare without scrolling everytime. Suggestions and improvements are welcome for further revisions.

hi @AlphaGaurav7 you did a great job
can you plz fixing the card like this

having a separate would make it perfect i think. because in same card it looks weird.

Hey @HridoyHazard ! I've made the required changes, and am making a PR for the same.


config.json: proxyType has no effect

PhantomJS 2.0
Trying to include proxy type option in config.json, e.g.
	"proxy": "localhost:1234",
	"proxyType": "socks5"
}```
this won't work (`phantomjs --config=config.json test.js`),
but `phantomjs --proxy=localhost:1234 --proxy-type=socks5 test.js` works OK.

The keys you use in config.json are the same as the command line options, not camelcased versions of them.  This should work:
{ "proxy": "localhost:1234", "proxy-type": "socks5" }

Sorry, no, proxy-type doesn't work either. Using command line arguments I can load a page via Tor, and using a config file I can't.

Yeah let's continue this in #13840.


Typo Chapter 15.4.3 Page 587 Bayesian inference

$m_0$ shall be $w_0$
$$
w_n = V_N (V_{0}^{-1}w_0 + X^{T} z)
$$

Fixed!
BTW thanks for adding the screenshot, it makes it much easier for me to find the error.


{tcomb-form} vs {formsy-react}

Just curious: why both in this kickstarter? When to choose one over the other?

I brought in tcomb on board because formsy-react has been unmaintained for some time now, tcomb-form also seems to be following better patterns

On 17 Mar 2016, at 10:16, Sander van Hooft<EMAIL_ADDRESS>wrote:
Just curious: why both in this kickstarter? When to choose one over the other?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub https://github.com/mantrajs/meteor-mantra-kickstarter/issues/34

Ok, that's great! Do you know by any chance if there's a way to use Astronomy for tcomb's schema input?


Mod will not initialize OpenVR

<IP_ADDRESS>3, from the epic games store
0.71
0.53.0
Valve Index

I cannot get the mod to work it fails to initaialize SteamVR. Here is a snippit of console output
Game files copied.	OWML
Found mods:	OWML
* Alek.EnableDebugMode v0.2	OWML
* Raicuparta.NomaiVR v0.53.0	OWML
Warning - Made for old version of OWML: v0.6.1	OWML
PermanentManager.Awake is already patched.	OWML
Raicuparta.NomaiVR requires VR.	OWML
Successfully patched globalgamemanagers.	OWML
Starting game...	OWML
Client disconnected from console	Mod Manager
Client connected to console	Mod Manager
Mod loader has been initialized.	OWML
For detailed log, see Logs/OWML.Log.03-08-2020-23.36.12.txt	OWML
Game version: <IP_ADDRESS>3	OWML
Start NomaiVR	NomaiVR
NullReferenceException: Object reference not set to an instance of an object. Stack trace: NomaiVR.NomaiVR.InitSteamVR () NomaiVR.NomaiVR.Start ()	Unity
In EnableDebugMode!

After the error the game launches as it normally would. The "Mods" menu shows the "nomai-vr" section but nothing is in VR. SteamVR is working well on my machine and I tried it without SteamVR running as per the instructions, and also with it already running but it didn't work.

Hi @villain749
I just released version 0.54.0. Can you check if the problem still happens?

Just tried it, unfortunatly I got the same result. Its the same error with the same stack trace. I did see it logged something about the toolbelt height.
thanks for looking into this so quickly

Not sure what could be wrong. Usually the Epic store version is easier to deal with... Some people have had luck adding Epic's executable to Steam's library, then right clicking -> properties -> show in VR library. Maybe that helps?

Not a bug, it's because you have Home Theater enabled for non-vr supported games. I had the same error as you but a friend pointed that out to me.

@SirXen0 thanks for the help. The only reason I didn't suggest this is because I thought this only affected users who own the game on Steam. Do you own it on Steam or Epic?
@villain749 I guess if have the Epic version but have Steam running, this might be the cause of the error? In which case please let me know, so I can add this info to the readme.

@Raicuparta On Steam, it kept having the issue and launched into theatre mode, but when I unchecked it in Steam settings, it launched into VR (and oh my goodness it's amazing in VR).

I appriciate all the suggestions, unforturnatly I could not get it to work. I tried adding the EpicLauncher, mod manager, owml, and the game to steam and adding it to the VR library. I tried unchecking the Desktop theater mode.  I tried older versions. I reinstalled SteamVR, I moved the installation drive.  I set everything up on a completly different computer but nothing seems to work. That same error.
NullReferenceException: Object reference not set to an instance of an object. Stack trace: NomaiVR.NomaiVR.InitSteamVR () NomaiVR.NomaiVR.Start () . So I decided to buy it on steam... It booted right up no problem. I am going to try to get a refund for the epic version. I did notice that the game version is <IP_ADDRESS>3 on the epic version, and <IP_ADDRESS>1 on steam.  Thanks again for taking the time to troubleshoot this with me. I'm off to to explore the galaxy.

I appriciate all the suggestions, unforturnatly I could not get it to work. I tried adding the EpicLauncher, mod manager, owml, and the game to steam and adding it to the VR library. I tried unchecking the Desktop theater mode. I tried older versions. I reinstalled SteamVR, I moved the installation drive. I set everything up on a completly different computer but nothing seems to work. That same error.
NullReferenceException: Object reference not set to an instance of an object. Stack trace: NomaiVR.NomaiVR.InitSteamVR () NomaiVR.NomaiVR.Start () . So I decided to buy it on steam... It booted right up no problem. I am going to try to get a refund for the epic version. I did notice that the game version is <IP_ADDRESS>3 on the epic version, and <IP_ADDRESS>1 on steam. Thanks again for taking the time to troubleshoot this with me. I'm off to to explore the galaxy.

Damn, you must be the first person I see who has less problems with Steam version than Epic. Glad you could make it work. I'm gonna leave this issue open for now, in case someone else finds it, and I'll look into what could cause this problem. Doubt I can do much about it though. Have fun!

Since it doesn't seem like I'm gonna be finding a solution to this any time soon, my "fix" is to crash the game with a warning and suggest a list of possible fixes, including disabling game theater and buying the game in another store 🤷♀


Feedback for “Using secrets”

A typo on the page https://docs.usebruno.com/secrets-management/hashicorp-vault/using-secrets:
seperated > sepArated

Implemented in #82

PR Merged. Thanks @sikorka !


Models for D1-D7

Does anybody know where to find pretrained models for D1-D7 versions?

https://github.com/lukemelas/EfficientNet-PyTorch/releases

checkout my repo.
The pytorch re-implement of the official efficientdet with SOTA performance in real time and pretrained weights.
https://github.com/zylo117/Yet-Another-EfficientDet-Pytorch/

Great. Well done. Please confirm you achieved exactly same results as claimed in the paper?
Thanks,
Muhammad Ajmal Siddiqui

Great. Well done. Please confirm you achieved exactly same results as claimed in the paper?
Thanks,
Muhammad Ajmal Siddiqui

the result is in the readme of the repo, it's almost the same as the one in the paper

Great. Awesome.


[Usage] how to load the trained lora?

Describe the issue
Question:
I've trained a lora with scripts/v1_5/finetune_task_lora.sh. How to load the trained lora (as well as the original LLaVA model) for inference?
What I've done:
I've trained a lora with scripts/v1_5/finetune_task_lora.sh, and got a folder like this:

I tried to modify the quickstart inference code into:
model_base = "liuhaotian/llava-v1.5-7b"
model_path = "/mnt/workspace/pyprojects/LLaVA-custom/work_dir/llava-v1.5-7b-task-lora/checkpoint-20"
prompt = "What are the things I should be cautious about when I visit here?"
image_file = "https://llava-vl.github.io/static/images/view.jpg"

args = type('Args', (), {
    "model_path": model_path,
    "model_base": model_base,
    "model_name": get_model_name_from_path(model_path),
    "query": prompt,
    "conv_mode": None,
    "image_file": image_file,
    "sep": ",",
    "temperature": 0,
    "top_p": None,
    "num_beams": 1,
    "max_new_tokens": 512
})()

eval_model(args)

(I just set model_path to the trained lora dir and model_base to original LLaVA model repo)
but I got error like this:
Traceback (most recent call last):
  File "/mnt/workspace/pyprojects/LLaVA-custom/_test_lora.py", line 29, in <module>
    eval_model(args)
  File "/mnt/workspace/pyprojects/LLaVA-custom/llava/eval/run_llava.py", line 55, in eval_model
    tokenizer, model, image_processor, context_len = load_pretrained_model(
  File "/mnt/workspace/pyprojects/LLaVA-custom/llava/model/builder.py", line 54, in load_pretrained_model
    lora_cfg_pretrained = LlavaConfig.from_pretrained(model_path)
  File "/mnt/workspace/conda_envs/llava/lib/python3.10/site-packages/transformers/configuration_utils.py", line 605, in from_pretrained
    config_dict, kwargs = cls.get_config_dict(pretrained_model_name_or_path, **kwargs)
  File "/mnt/workspace/conda_envs/llava/lib/python3.10/site-packages/transformers/configuration_utils.py", line 634, in get_config_dict
    config_dict, kwargs = cls._get_config_dict(pretrained_model_name_or_path, **kwargs)
  File "/mnt/workspace/conda_envs/llava/lib/python3.10/site-packages/transformers/configuration_utils.py", line 689, in _get_config_dict
    resolved_config_file = cached_file(
  File "/mnt/workspace/conda_envs/llava/lib/python3.10/site-packages/transformers/utils/hub.py", line 356, in cached_file
    raise EnvironmentError(
OSError: /mnt/workspace/pyprojects/LLaVA-custom/work_dir/llava-v1.5-7b-task-lora/checkpoint-20 does not appear to have a file named config.json. Checkout 'https://huggingface.co//mnt/bn/sunyi-dev/mlx/users/suofeiyang/pyprojects/LLaVA-custom/work_dir/llava-v1.5-7b-task-lora/checkpoint-20/main' for available files.

(Alse checked repo liuhaotian/llava-v1-0719-336px-lora-vicuna-13b-v1.3, and found that the dir structure is different from the trained lora's dir.)

Hi @feiyangsuo, I have the same issue. Were you able to figure this out?

Hi @feiyangsuo, I have the same issue. Were you able to figure this out?

still investigating

I guess it's not feasible (or some extra coding required) since my directory only contains tmp lora weights @kumudlakara-bbc
https://github.com/haotian-liu/LLaVA/issues/1245

Something to be mindful about is the model_name parameter. If you don't specify that, the script generates it based on the model path and it might cause some issues. Trace the model_name in the script and make sure it's what you need.


Liquid backing corrections

This should be the last round of corrections to assets and token supply (famous last words) before Cooler Loans:
Arbitrum:

Apply write-off of JonesDAO token, since it cannot be sold.
Going forward, dynamically determine the OHM supply minted into Silo Finance and Sentiment Finance

Ethereum:

OHM supply: Fix the incorrect multiplication of sOHM balance by OHM index
OHM supply: Going forward, dynamically determine the OHM supply minted into Silo Finance
Liquid backing: Write down the value of cvxCRV that is bricked/inaccessible in the Convex allocator contract
Liquid backing: Add missing withdrawal from Myso pool

The cross-branch consistency checks are expected to fail, due to the changes with assets and token supply.

Deployed


Package specs can't use external packages

Prerequisites
Not applicable.

[ ] Put an X between the brackets on this line if you have done all of the following:

Reproduced the problem in Safe Mode: https://flight-manual.atom.io/hacking-atom/sections/debugging/#using-safe-mode
Followed all applicable steps in the debugging guide: https://flight-manual.atom.io/hacking-atom/sections/debugging/
Checked the FAQs on the message board for common solutions: https://discuss.atom.io/c/faq
Checked that your issue isn't already filed: https://github.com/issues?utf8=✓&q=is%3Aissue+user%3Aatom
Checked that there is not already an Atom package that provides the described functionality: https://atom.io/packages

Description
https://github.com/atom/atom/pull/18801 changed how the Atom profile for spec runs works, making it use an entirely new profile folder. This had the unintended side-effect of breaking the specs of packages that rely on loading other packages in while testing, since the external packages can no longer be loaded.
Steps to Reproduce
In general

Run apm install <external package>
Run atom --test spec on a different package, that calls atom.packages.activatePackage('<external package>');

Exact steps

Start a container with docker run --rm -it arcanemagus/atom-docker-ci:v1.36.0-beta1 bash

All subsequent steps are run within the container

git clone https://github.com/AtomLinter/linter-bailey.git && cd linter-bailey
git checkout c502b71
${APM_SCRIPT_PATH} install "language-bailey"
${APM_SCRIPT_PATH} install
${ATOM_SCRIPT_PATH} --test spec

Compare with running the same steps in a container started with:
docker run --rm -it arcanemagus/atom-docker-ci:v1.35.1 bash
Expected behavior:
External packages that were installed before the specs were ran are able to be resolved and loaded in the specs.
Actual behavior:
The external packages can no longer be resolved.
Reproduces how often:
100% of the time.
Example failure: https://circleci.com/workflow-run/18b1cb01-c82e-4e7f-8a5b-861bdacf5936
Versions
Atom    : 1.36.0-beta1
Electron: 2.0.18
Chrome  : 61.0.3163.100
Node    : 8.9.3
apm  2.1.3
npm  6.2.0
node 8.9.3 x64
atom 1.36.0-beta1
python 2.7.15rc1
git 2.17.1

OS: Tested in Linux containers and locally on Windows.
Additional Information
Potential solutions outlined in chats with @smashwilson:

If ATOM_TEST_PACKAGES is set in the environment, symlink all of those into the temporary profile folder

This will work for most configurations that have followed the example of atom/ci, but doesn't account for manual configurations that are just running the commands directly

Create some API to mark packages for including in the temporary profile explicit

This won't work for existing setups, but is a nice solution for the future

Disable using a temporary profile in CI environments

This brings us back to the risk of corruption/non-reproducibility that the original PR was meant to solve

I verified locally that #18801 was the culprit by running a build that exhibited the issue at first, running git revert 8e6d833, and checking that the issue was gone.

I have problem using atom.packages.activatePackage("XXX") in my spec.
It always throws Error: Failed to load package 'XXX', is it related to this issue?

That depends on whether XXX is the pacakge you are testing, or a different package that your package that you are testing requires in order to run. If it's a separate package you can work around this issue by adding it to the APM_TEST_PACKAGES environment variable (added in #18984).

Sorry, after changing a different test-runner, my problem is gone.
Now I can see XXX in atom.packages.getLoadedPackages() after atom.packages.loadPackages() again!

Good to now the issue was resolved. Closing this issue based on https://github.com/atom/atom/issues/18983#issuecomment-510313141


LOG4J2-2791 - Correct JsonLayout timestamp sorting issue

Travis build issue appears to be general, and not specific to this pull request.


Add Hadoop counters for detecting schema mismatch

Description
This PR adds Hadoop counters for detecting schema mismatch (AVRO only).
The counters include:

data types don't match (int <-> long)
single value vs multi value
multi-value column uses non-array structure

Why is this specific to Hadoop. This could be part of segment creator and used across all recordreader right?

That makes sense. I've moved the counters to SegmentCreationJob from HadoopSegmentCreationJob.

Most of these are already tracked in transformers. Invalid columns etc

Most of these are already tracked in transformers. Invalid columns etc

Most of these are already tracked in transformers. Invalid columns etc

Correct, but it's encapsulated in RecordRecorder and it will dirty the RecordRecorder interface if such statistics require more method in the interface. Added a class called SchemaValidator to track this.

Most of these are already tracked in transformers. Invalid columns etc

Plus, the transformers are applied on each of the records. We don't have to do the schema validation at every record. All we need to do is to validate the schemas only once when a segment is about to be built.
@kishoreg let me know if you have any other concern.


E2E tests github action is using e2e-test Makefile target rather than e2e-test-v2

What happened:
What you expected to happen:
E2E tests github action is using e2e-test Makefile target rather than e2e-test-v2. This causes some of pre-provisioning tests that call CreateVolume to fail, because corresponding AzVolume is not being created:
2021-05-17T15:42:21.1788107Z I0517 15:33:57.342759       1 cloudprovisioner.go:358] Attach operation is successful. volume "/subscriptions/***/resourceGroups/k8s-e2etest-97fe3170-b705-11eb-98d7-4de1c5f96c53-rg/providers/Microsoft.Compute/disks/pre-provisioned-read-only" is already attached to node "k8s-agentpool1-35551174-1" at lun 0.
2021-05-17T15:42:21.1790930Z E0517 15:33:57.342801       1 azvolumeattachment.go:542] failed to get AzVolume (pre-provisioned-read-only): AzVolume.disk.csi.azure.com "pre-provisioned-read-only" not found
2021-05-17T15:42:21.1794060Z E0517 15:33:57.342810       1 azvolumeattachment.go:135] failed to attach AzVolumeAttachment (pre-provisioned-read-only-k8s-agentpool1-35551174-1-attachment): AzVolume.disk.csi.azure.com "pre-provisioned-read-only" not found

How to reproduce it:
Anything else we need to know?:
Environment:

CSI Driver version:
Kubernetes version (use kubectl version):
OS (e.g. from /etc/os-release):
Kernel (e.g. uname -a):
Install tools:
Others:

Fixed by #54


CLOUDP-221979: Added Atlas Search Index CRD

All Submissions:

[x] Have you opened an Issue before filing this PR?
[x] Have you signed our CLA?
[x] Have you checked to ensure there aren't other open Pull Requests for the same update/change?
[ ] Put closes #XXXX in your comment to auto-close the issue that your PR fixes (if such).

LGTM


Update error message in dict_has_fields()

It should not reference the manifest because it is now in the general utils.
ModLoaderLog.fatal("Mod manifest is missing required fields: %s" % missing_fields, LOG_NAME)
https://github.com/GodotModding/godot-mod-loader/blob/49464dbcca4fc3d21286654dd4e62c13d9387274/addons/mod_loader/internal/mod_loader_utils.gd#L37-L50

closed by https://github.com/GodotModding/godot-mod-loader/pull/259


Python3 Port of find_shard Script

Summarizing the changes:

Wrapped the code under a class

Other than refactoring related to python3 coding conventions, there is only couple of changes of interest:

a. Since integer division behaviour has changed in python3, changed the following line in get_buckets method:
interval = max_bucket // num_bucket
instead of
interval = max_bucket / num_bucket
b. as_int method has changed:
@staticmethod
   def __as_int(h):
       return h[0] | numpy.int32(h[1] << 8) | numpy.int32(h[2] << 16) | numpy.int32(h[3] << 24)

instead of
def asInt(h):
    return ord(h[0]) |  numpy.int32(ord(h[1]) << 8) |   numpy.int32(ord(h[2]) << 16) |  numpy.int32(ord(h[3]) << 24)


Timescale support

Are there any plans to support  Timescale db - https://www.timescale.com/ ?

No plans but no objections to doing it.
Von meinem iPhone gesendet

Am 17.06.2019 um 18:07 schrieb sandeep-eroad<EMAIL_ADDRESS>Are there any plans to support Timescale db - https://www.timescale.com/ ?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

It looks like Timescale utilizes partitioned tables, so #59 is a requirement here. What else would this entail? Do you know if Timescale defines custom types on its own?

@sandeep-eroad, if you have access to a database using Timescale, please try the lastest Nuget package and let me know if there's anything that does not work.

Trying to use with timescaledb. I am getting the following error
  Program.fs(28, 27): [FS3033] The type provider 'FSharp.Data.Npgsql.NpgsqlProviders' reported an error: Unable to cast object of type 'System.DBNull' to type 'System.UInt32'.

 type SuburbDatabase = NpgsqlConnection<Connection=TPConnStr>

    [<RequireQualifiedAccess>]
    module RegionDetail =
        type SelectAll = NpgsqlCommand<"""
            SELECT * FROM evets
        """, TPConnStr, ResultType.DataReader>

I think I might know what the issue is. I tested this on an empty timescale database with the same error. During schema inspection some rows are returning null for table_oid.
This is the SQL query result of an empty timescale database from https://github.com/demetrixbio/FSharp.Data.Npgsql/blob/c1828923d145d37014f30f1b3664ec80dd989759/src/DesignTime/InformationSchema.fs#L388-L428
timescaledb.empty.txt


Missing argument for hooking up the relationship between elements and its wrapper collection

Manually creating a collection using restangularizeCollection() was not passing the newly created collection to all its children elements, therefore not having the relation between the elements to its parent collection.
All the code was already there, just missing the argument to pass to restangularizeElem()

This seems to be a good PR. Can you rebase and I'll take a look at it?


Performance issue

hi,
Seeing performance issues when running with JOT library.

Created Helloworld program. Total time taken to execute the program: 345250 nano seconds or 0.3 milli seconds
Ran the same Helloworld program with JOT intrumentation. Now the total time taken is: 30822000 or 30milli second.
Now i ran the same helloworld program in for loop for 10 times the timings vary from: 42844792 nano sec --> 514166 nano sec (42ms -->  0.5ms ; which is still significant performance issue
The same exercise with out JOT ranges from: 17208 ns to 1750 ns (0.02 ms --> 0.002 ms )

This seems to be a huge performance issue. Any thoughts?
I see that most of the time is being spent in Sensors.enterMethodScope and Sensors.LeaveMethodscope ofthe JOT library.
Helloworld program:
package com;

public class Helloworld {
    static long start = System.nanoTime();
    public static void main(String... s){
        System.out.println("**** hello world ** ");
        for (int i=0;i<10; i++) {
            start = System.nanoTime();
            new Helloworld().hi(i);
        }
    }

    public void hi(int i){
        System.out.println("hi , i:: "+i+" time in nanos: " + (System.nanoTime()-start));
    }
}

jot file
---
# Java Observability Toolkit (JOT)
# https://openo11y.org

sensors:
 - name: "get-ciphers"
   description: "Identifies encryption ciphers"
   methods:
   - "com.Helloworld.hi"
   captures:
   - "#P0"
   debug: true

reports:
 - name: "Encryption Usage"
   type: "list"
   cols: "get-ciphers"

From standalone helloworld
hi , i:: 0 time in nanos: 17208
hi , i:: 1 time in nanos: 3250
hi , i:: 2 time in nanos: 2291
hi , i:: 3 time in nanos: 2167
hi , i:: 4 time in nanos: 2166
hi , i:: 5 time in nanos: 2042
hi , i:: 6 time in nanos: 1709
hi , i:: 7 time in nanos: 2250
hi , i:: 8 time in nanos: 1750
hi , i:: 9 time in nanos: 1958

From standalone helloworld with JOT instrumentation etc
 hi , i:: 0 time in nanos: 42844792
   35  Apr 04, 2022 11:18:06 AM org.openolly.Sensor leaveMethodScope
   36  INFO: [JOT get-ciphers] METHOD SCOPE [0] - 1 >> get-ciphers 0 time-nanos:42818583
   ..
  124    hashCode()
  125  [SENSOR] Defaulting to toString() - {class java.lang.Integer:1}
  126: hi , i:: 1 time in nanos: 1660542
  127  [SENSOR] Defaulting to toString() - {class java.lang.Integer:2}
  128: hi , i:: 2 time in nanos: 1521750
  129  [SENSOR] Defaulting to toString() - {class java.lang.Integer:3}
  130: hi , i:: 3 time in nanos: 1024750
  131  [SENSOR] Defaulting to toString() - {class java.lang.Integer:4}
  132: hi , i:: 4 time in nanos: 450084
  133  [SENSOR] Defaulting to toString() - {class java.lang.Integer:5}
  134: hi , i:: 5 time in nanos: 499333
  135  [SENSOR] Defaulting to toString() - {class java.lang.Integer:6}
  136: hi , i:: 6 time in nanos: 2153333
  137    registerNatives()
  138    notify()
  ...
  282  INFO: [JOT get-ciphers] METHOD SCOPE [0] - 1 >> get-ciphers 0 time-nanos:522875
  283  [SENSOR] Defaulting to toString() - {class java.lang.Integer:7}
  284: hi , i:: 7 time in nanos: 840917
  285  [SENSOR] Defaulting to toString() - {class java.lang.Integer:8}
  286: hi , i:: 8 time in nanos: 1561125
  287  [SENSOR] Defaulting to toString() - {class java.lang.Integer:9}
  288: hi , i:: 9 time in nanos: 514166

If i disable debugging , i see 0.1 milli second as additional time added to the original method. But the question that remains is, if the bytecode is being manipulated why should the time increase for all the api calls? With debug disabled below are the stats
with JOT instrumentation (nano seconds)
hi , i:: 0 time in nanos:22294542
hi , i:: 1 time in nanos:515791
hi , i:: 2 time in nanos:28375
hi , i:: 3 time in nanos:23709
hi , i:: 4 time in nanos:19541
hi , i:: 5 time in nanos:16250
hi , i:: 6 time in nanos:18500
hi , i:: 7 time in nanos:16333
hi , i:: 8 time in nanos:16000
hi , i:: 9 time in nanos:15958
hi , i:: 10 time in nanos:22500

Without JOT instrumentation
hi , i:: 0 time in nanos:13959
hi , i:: 1 time in nanos:2917
hi , i:: 2 time in nanos:2125
hi , i:: 3 time in nanos:1875
hi , i:: 4 time in nanos:1792
hi , i:: 5 time in nanos:1834
hi , i:: 6 time in nanos:1667
hi , i:: 7 time in nanos:2125
hi , i:: 8 time in nanos:1792
hi , i:: 9 time in nanos:2042
hi , i:: 10 time in nanos:2791

Some performance impact is expected because JOT is doing stuff.  Looks like most of the impact Is due to ‘debug’ being enabled.  I’ll keep this issue open because maybe We can optimize scope usage.
JOT is primarily to help you understand more complex software in dev/test environment where performance isn’t critical.  I might not use it during my perf test.
Your test isn’t very realistic (and doesn’t warm up the JIT or other best practices).  All the code does is call the one function you instrumented.  So the code JOT inserts is a significant percentage of the overall code in the app.  Try it on a decent sized web application and see the impact of JOT is really insignificant.

hey! i want to use this for realtime metrics in production. While i like the concept of instrumenting the bytecode --nothing can be more optimized than this, i dont like the idea that we cant use it in perf test. My intent here is to use this in prod and generate observability graphs via grafana
Can you tell why u worry if we use this in real prod usecase/ in perf test?
btw, can u add a prop file to control logging. nothing gets printed with .fine() in logger

Sure - use it in your performance test.  JOT will have a tiny performance impact.  Closing.


Extendability of the compiler

Is your feature request related to a problem? Please describe.
As a library-developer i would like to have the possibility to interop with javascript, to enable all kinds of features for application-developers
Describe the solution you'd like
Giving the compiler cli-flags with paths to lua scripts
Describe alternatives you've considered
Another option would have been to do extendability through haskell, but that would have meant that the application-developer needs to compile the compiler themselfes
Additional context
Interop to browser functionality is needed for giving application developers the option to have routers, localization, intersection-observer, ...
All of the mentioned usecases(and many more) shouldn't be covered by the compiler itself but through plugins.

To enable extend ability, streaming api needs to be implemented https://github.com/strictly-lang/compiler/pull/91


Add a "sentTime" property as it is done on Android SDK

Feature proposal

Firebase Component: Messaging

Hello !
I am a Flutter developer so i am sorry in advance for the naming conventions / objects that i will describe below, that are probably different from the ones in the native SDKs.
Problem :
I have spoken to a FlutterFire developer in this issue about a sentTime property of the RemoteMessage object when receiving a notification on an iOS device.
In Android, when receiving a notification, we receive a timestamp that is the time when the notification was sent.
In the iOS SDK, it seems that such property does not exist.
I have contacted Firebase support but they told me that i should see directly with the iOS SDK team as well.
So far as a workaround, we can pass a timestamp in the payload to do so, but it would much better if it could work like on Android SDK.
The sentTime property of the notification is passed in the Android SDK and the FlutterFire developers are able to pass it in the firebase_messaging plugin for Flutter.
Request :
Please add an equivalent property as this sentTime (the actual name of this property on Android is probably different but you see the meaning and i know it exists) on the iOS SDK.
If this property already exists on the iOS SDK, please accept my apologies and i would be glad to know which one it is.
Thanks in advance !

Thanks for your feedback. We will bring the request to the FM team.
In the meantime, there's a workaround since all the info is passed within the payload. You can access the "sentTime" through the "google.c.a.ts" key in the Message payload.

Thanks for the quick reply.
The developer said this regarding this issue.
It seems that this property is also unavailable in newer iOS versions.
Can you confirm that this property is still available ?

I just tested and it should be available. Are you using console or sender API to send notifications?

I am using the sender API and i guess the firebase team for flutter as well :)

@Tom3652 I'm able to reproduce that HTTP v1 Sender API does not provide "google.c.a.ts" send time. I will check with our team and get back to you.

Hello, is there any news regarding this issue ?
Thanks !

I don't believe this issue is still exists in new version of iOS. many values are null. iOS version 14.8.1 and firebase_messaging version is 12.0.1.

.

We are already in the year 2023 and until today we do not have a simple solution for an issue created in 2021 :man_facepalming:

We are already in the year 2023 and until today we do not have a simple solution for an issue created in 2021 🤦♂

agree. i still cant find solution for ios.