E2E torchbench regression

Torchbench e2e tests fail with the following error:
ImportError: /opt/hostedtoolcache/Python/3.10.13/x64/lib/python3.10/site-packages/intel_extension_for_pytorch/lib/libintel-ext-pt-gpu.so: undefined symbol: _ZNK5torch8autograd4Node4nameB5cxx11Ev

Steps to reproduce

Build and install torch, ipex, torchvision, torchtext, torchaudio from sources (see "Environment" for the details").

Verify that both torch and ipex can be imported.
python -c "import torch;print(torch.__version__)"
python -c "import torch;import intel_extension_for_pytorch as ipex;print(ipex.__version__)"

Clone  weishi-deng/benchmark.git @ main, run
python install.py
pip install -e .

Execute
inductor_xpu_test.sh torchbench amp_bf16 inference accuracy xpu 0

Stack trace:
File "/cache/pytorch-3.10-2c5c507e3df4a117e88d3cb29ffb9a87a599dc42-3/benchmarks/dynamo/torchbench.py", line 481, in <module>
    torchbench_main()
  File "/cache/pytorch-3.10-2c5c507e3df4a117e88d3cb29ffb9a87a599dc42-3/benchmarks/dynamo/torchbench.py", line [47](https://github.com/intel/intel-xpu-backend-for-triton/actions/runs/8308622188/job/22739067150#step:37:48)7, in torchbench_main
    main(TorchBenchmarkRunner(), original_dir)
  File "/cache/pytorch-3.10-2c5c[50](https://github.com/intel/intel-xpu-backend-for-triton/actions/runs/8308622188/job/22739067150#step:37:51)7e3df4a117e88d3cb29ffb9a87a[59](https://github.com/intel/intel-xpu-backend-for-triton/actions/runs/8308622188/job/22739067150#step:37:60)9dc42-3/benchmarks/dynamo/common.py", line 3040, in main
    process_entry(0, runner, original_dir, args)
  File "/cache/pytorch-3.10-2c5c507e3df4a117e88d3cb29ffb9a87a599dc42-3/benchmarks/dynamo/common.py", line 2997, in process_entry
    return maybe_fresh_cache(
  File "/cache/pytorch-3.10-2c5c507e3df4a117e88d3cb29ffb9a87a599dc42-3/benchmarks/dynamo/common.py", line 16[60](https://github.com/intel/intel-xpu-backend-for-triton/actions/runs/8308622188/job/22739067150#step:37:61), in inner
    return fn(*args, **kwargs)
  File "/cache/pytorch-3.10-2c5c507e3df4a117e88d3cb29ffb9a87a599dc42-3/benchmarks/dynamo/common.py", line 3108, in run
    import intel_extension_for_pytorch as ipex
  File "/opt/hostedtoolcache/Python/3.10.13/x64/lib/python3.10/site-packages/intel_extension_for_pytorch/__init__.py", line 94, in <module>
    from .utils._proxy_module import *
  File "/opt/hostedtoolcache/Python/3.10.13/x64/lib/python3.10/site-packages/intel_extension_for_pytorch/utils/_proxy_module.py", line 2, in <module>
    import intel_extension_for_pytorch._C
ImportError: /opt/hostedtoolcache/Python/3.10.13/x64/lib/python3.10/site-packages/intel_extension_for_pytorch/lib/libintel-ext-pt-gpu.so: undefined symbol: _ZNK5torch8autograd4Node4nameB5cxx11Ev

Workflow run (worked before):
https://github.com/intel/intel-xpu-backend-for-triton/actions/runs/8308622188/job/22739067150
Environment
PYTHON_VERSION=3.10
PYTORCH_REPO=Stonepia/pytorch
PYTORCH_COMMIT_ID=2c5c507e3df4a117e88d3cb29ffb9a87a599dc42
IPEX_REPO=intel/intel-extension-for-pytorch
IPEX_COMMIT_ID=4df9e1feeedcc312402b20f6c7fa4637be16bea2
LLVM_REPO=intel/llvm.git
LLVM_COMMIT_ID=e65cd965a8f661e2e4af4407876d96b0e2458a76
BENCHMARK_REPO=weishi-deng/benchmark.git
BENCHMARK_COMMIT_ID=1eb816925dc2bf9b5b2ec4537b353c1e4ddcfc35
TRITON_REPO=intel/intel-xpu-backend-for-triton
TRITON_COMMIT_ID=76626004e6f195e1e29d2692496346cda8f295b0
TORCHVISION_COMMIT_ID=47cd5ea8e21d7596a24907710411d6b4a43f628d
TORCHTEXT_COMMIT_ID=b0ebddc648d279826089db91775375221777a2db
TORCHAUDIO_COMMIT_ID=a8f4e97bd5356a7a77510cdf6a3a62e25a5dc602
TRANSFORMERS_VERSION=4.27.4
TIMM_COMMIT_ID=b9d43c7dcac1fe05e851dd7be7187b108af593d2

Simple reproduction:
After installing torchbench with
cd benchmark
python install.py
pip install -e .

Importing ipex no longer works (worked before installing benchmark):
$ python -c "import torch;import intel_extension_for_pytorch as ipex;print(ipex.__version__)"
Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "/opt/hostedtoolcache/Python/3.10.13/x64/lib/python3.10/site-packages/intel_extension_for_pytorch/__init__.py", line 94, in <module>
    from .utils._proxy_module import *
  File "/opt/hostedtoolcache/Python/3.10.13/x64/lib/python3.10/site-packages/intel_extension_for_pytorch/utils/_proxy_module.py", line 2, in <module>
    import intel_extension_for_pytorch._C
ImportError: /opt/hostedtoolcache/Python/3.10.13/x64/lib/python3.10/site-packages/intel_extension_for_pytorch/lib/libintel-ext-pt-gpu.so: undefined symbol: _ZNK5torch8autograd4Node4nameB5cxx11Ev

The root cause for the issue is the recent changes to https://github.com/weishi-deng/benchmark. The install/setup code for benchmark re-install torch:

Before installing benchmark: torch 2.1.0a0+git2c5c507
After installing benchmark: torch 2.2.1

Also benchmark re-installs pinned transformers:

Before installing benchmark: transformers 4.27.4
After installing benchmark: transformers 4.38.1

Hi, this issue is root caused by the sync of Pytorch/benchmark which includes a new model 'sam_fast' that requires  'torch>=2.2.0'. This workaround is added to our branch to avoid reinstalling the torch while installing the torchbench. As a side effect, this new model will be supported later when IPEX satisfies the requirements.

@pbchekin could please confirm that the issue is resolved

It is resolved, thanks.


Add all

Closes #112

ImportError: cannot import name 'contextfunction' from 'jinja2'
Seems that dependency needs to be bumped


Update network-protection.md

@JohanFreelancer9 - kindly do the copy editor review for this PR. Thanks

@Oludele0315, we aim to use bias-free communication in all docs, hence it is acceptable to use a plural pronoun (their, in this instance) in generic references to a single person. I would suggest closing this PR without the change being merged. Many thanks.

Thanks for the clarification


Support pull_request.commit(hash) interface.

[ ] support pull_request.commit(hash)
[ ] share Tinybucket::Api::CommitsApi with Tinybucket::Model::Repository and Tinybucket::Model::PullRequest.

There is no api on Bitbucket Cloud REST API...


[editor] scrolling speed

Compare with VSCode, seems like slower

note that set-scroll-via-copy of editor-canvas could somewhat improve scrolling speed, especially on Mac, but it would also complicate handling of bitmap cache.
files-viewer used to face similar slow scrolling problem: https://github.com/MatrixForChange/files-viewer/commit/5a1016894db4795c25684c817326f28fa788d196

Depends on DrRacket now

Depends on DrRacket now


Bug 1978578: [release-4.6] fixed cephTools update when spec is changed

Signed-off-by: Santosh Pillai<EMAIL_ADDRESS>(cherry picked from commit e524fc1ce339429ed4263796ea4a858e81678b0b)

/hold
Bug is not acked

Why is there only a backport for 4.6 and not for 4.7 and 4.8? @agarwal-mudit

Its already there in 4.7 and above

Why is there only a backport for 4.6 and not for 4.7 and 4.8? @agarwal-mudit

Its already there in 4.7 and above

Oh, I missed that the original PR #766 is that old... 😄

/hold cancel

/bugzilla refresh


Validate inputs to JSON RPC interface

The JSON RPC server used for exposing an instance of the Aztec RPC Server over HTTP does not validate inputs. Any error in or incompatibility with the client will cause unexpected errors. We should enforce strict validations on the API level.
As an example, an improperly encoded PrivateKey object sent from the CLI resulted in Unknown complete address for address when creating an account, since the generation of the address based off the private key was broken (more details in this Slack thread).

Superseded by https://github.com/AztecProtocol/aztec-packages/issues/9455


Added IronMQ v4 support. Updated IronMQ package and namespaces.

The current stable package of IronMQ is v4.0.1. It's namespace has changed from IronMQ to IronMQ\IronMQ.
This solves the following issue:
A PHP Error was encountered

Severity: 4096

Message: Argument 1 passed to Bernard\Driver\IronMqDriver::__construct() must be an instance of IronMQ, instance of IronMQ\IronMQ given, called in /var/www/localhost/CommandBus/Middlewares/BernardMiddleware.php on line 49 and defined

Filename: Driver/IronMqDriver.php

Line Number: 21

Great, thanks!

Thanks :)


Add doc for countdown

Countdown is actually a native prop in iOS and can be used.

Thanks for your first contribution @harveyconnor!


fix(cd): remove build cache and repository cache on release workflow

From https://github.com/Kong/kong/pull/13622 as it's currently broken https://github.com/Kong/kong/actions/runs/10809455768

merged as part of https://github.com/Kong/kong/pull/13603


Fix integration tests

Summary
Details and comments

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 50.38%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
2982

Relevant Lines:
5919

💛  - Coveralls

@kt474 - I added skip to all those tests which I think are currently not supported.  I didn't really understand the purpose of the tests: test_websocket_integration, in particular the _job_final_status_polling which no longer exists.
The tests in test_proxies seem to all have errors of the type error=('Cannot connect to proxy.' I didn't know what to do with these either.

@merav-aharoni did you mean to close this PR? The changes here look good to me

Strange, I seem to have closed this unintentionally.

@kt474 - I am still trying to understand how to handle test_websocket_integration and test_proxies. We can leave this for another PR.


Move all example pallets under examples folder.

This should be a pretty trivial update.

I don't have right to merge the pull request and will need one of you to merge this PR @bkchr @apopiak @TriplEight . Thanks.

bot merge

Like it! Although @jimmychu0807 you broke doc links FYI - we should be aware that moving things around might do this in docs - the devhub CI will quickly spot it, but as a nice-to-have please consider this in future PRs.

dumb q: are these pallets tested in CI at this level of the directory structure?

dumb q: are these pallets tested in CI at this level of the directory structure?

Yes: https://github.com/paritytech/substrate/pull/10215/files#diff-037ea159eb0a7cb0ac23b851e66bee30fb838ee8d0d99fa331a1ba65283d37f7L485


Resolve issues with RHEL9 support in integration tests

Description
Fix the integration test scripts to test as many apps as possible on rocky linux 9 for rocky/rhel/centos support.
Followed the pattern from https://github.com/GoogleCloudPlatform/ops-agent/pull/1044 for running the tests, will need to revert those change before this can be merged but leaving them in temporarily in case the changes need to be iterated upon. The rocky-linux-9 tests are showing as 'bullseye' for the purposes of this PR, due to said pattern.
How has this been tested?
Manually tested a few apps along the way, but the focus was to get things working properly in kokoro.
Checklist:

Unit tests

[X] Unit tests do not apply.
[ ] Unit tests have been added/modified and passed for this PR.

Integration tests

[ ] Integration tests do not apply.
[X] Integration tests have been added/modified and passed for this PR.

Documentation

[X] This PR introduces no user visible changes.
[ ] This PR introduces user visible changes and the corresponding documentation change has been made.

Minor version bump

[X This PR introduces no new features.
[ ] This PR introduces new features, and there is a separate PR to bump the minor version since the last release already.
[ ] This PR bumps the version.

Since there's a few things going on as I'm trying to get the tests running under the correct things in kokoro, successful build was on 393496e https://source.cloud.google.com/results/invocations/15a470ec-254e-4b03-8dc1-ca255ddc2833/targets


Allow specifying existing secret

It's a common pattern to allow configuration of an existing secret.
This would allow the daemonset (https://github.com/IBM/core-dump-handler/blob/main/charts/templates/daemonset.yaml#L36) to use a secret of the users choosing, in my case I prefill them from Vault or use Rook Ceph to set them and won't specify them via the values.yaml.

That’s resolved then :)


Fix static typing

Fixed the following files:
pycardano/plutus.py
pycardano/serialization.py
pycardano/transaction.py
pycardano/txbuilder.py
pycardano/witness.py

Codecov Report

Merging #139 (aac21cc) into main (5e37db1) will decrease coverage by 0.00%.
The diff coverage is 91.66%.

@@            Coverage Diff             @@
##             main     #139      +/-   ##
==========================================
- Coverage   86.43%   86.42%   -0.01%
==========================================
  Files          26       26
  Lines        2734     2748      +14
  Branches      649      650       +1
==========================================
+ Hits         2363     2375      +12
- Misses        279      281       +2
  Partials       92       92

Impacted Files
Coverage Δ

pycardano/txbuilder.py
91.55% <80.55%> (-0.30%)
:arrow_down:

pycardano/plutus.py
92.57% <100.00%> (+0.07%)
:arrow_up:

pycardano/serialization.py
88.84% <100.00%> (ø)

pycardano/transaction.py
94.40% <100.00%> (+0.11%)
:arrow_up:

pycardano/witness.py
91.30% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


dns_config: should probably look for dns instead

I'm trying to get Headplane to work with the new beta2, but I'm getting this error:
2024-08-21T07:06:07.204Z (ERRO) [CFGX] Recieved invalid configuration file
2024-08-21T07:06:07.205Z (ERRO) [CFGX] The following schema issues were found:
2024-08-21T07:06:07.205Z (ERRO) [CFGX]   'dns_config': Required
It looks like Headplane is expecting dns_config to still be in the config, but it's now called dns:
As a sidenote, I believe that acl_policy_path might also need to be updated to work with later versions, the new format is:
policy:
mode: file
path: "/etc/headscale/acl.json"

I saw a post on the discord with a bit of a fix/workaround for now, thought it would be worth sharing here whilst waiting for a fix.
Add this to your headscale config.yaml
dns_config: {}
and set HEADSCALE_CONFIG_UNSTRICT to true
Also, I added an environment variable “ACL_FILE” so that I could still view/make changes to my ACL file from Headplane, as you say above, they fixed the issues with policy.path mapping now and removed acl_policy_path
This of course means no DNS functionality from within Headplane, but nice to have the UI back!

I'll update the config ASAP.

Fixed in 0.2.3. The minimum requirement for Headscale is now 0.23.0-beta2 or else Headplane will start with errors.


Example code tests are not passing.

Chapter 2 example code tests are not passing. Not sure what the problem is but fetch always returns 200. When testing from the browser, the response is as expected 404

Problem was with my environment for some reason SSO was messing up my localhost:3000.


Check GPG keys

Can we add a field that only accepts the CLA if the user uses a certain GPG key to verify the commit?

@JamesGreen31 sounds like this could be a separate action/check, unrelated to CLA


Recipe for Node, Docker, Nodemon and Babel

Hi, I'm trying to modify Docker's with Node and typescript in order to adapt into Javascript with Babel.
My package.json scripts
  "scripts": {
    "debug": "nodemon --watch dist/ --inspect=<IP_ADDRESS> --nolazy -L dist/index.js",
    "docker-debug": "docker-compose up",
    "start": "node dist/index.js",
    "postinstall": "babel src/ --out-dir dist/ --source-maps",
    "watch": "babel src/ --watch --out-dir dist/ --source-maps",
  },

My launch.json
{
    // Use IntelliSense to learn about possible attributes.
    // Hover to view descriptions of existing attributes.
    // For more information, visit: https://go.microsoft.com/fwlink/?linkid=830387
    "version": "0.2.0",
    "configurations": [
      {
        "type": "node",
        "request": "launch",
        "name": "Launch in Docker",
        "preLaunchTask": "watch",
        "runtimeExecutable": "npm",
        "runtimeArgs": [ "run", "docker-debug" ],
        "port": 9229,
        "restart": true,
        "timeout": 60000,
        "localRoot": "${workspaceFolder}",
        "remoteRoot": "/app",
        "outFiles": [
          "${workspaceFolder}/dist/**/*.js"
        ],
        "console": "integratedTerminal",
        "internalConsoleOptions": "neverOpen"
      }
    ]
  }

My tasks.json
{
  "version": "0.1.0",
  "tasks": [{
    "taskName": "watch",
    "command": "npm",
    "args": ["run", "watch"],
    "isShellCommand": true,
    "isBackground": true,
    "isBuildCommand": true,
    "problemMatcher": [],
    "showOutput": "always"
  }]
}

My dockerfile
FROM node:8.11

RUN apt-get update && apt-get install -y \
  rubygems \
  ruby2.1-dev

RUN gem install -N mailcatcher

WORKDIR /app

COPY . /app
RUN npm install

EXPOSE 3001 1080 9229
CMD [ "npm", "start" ]

My docker-compose.json
version: "2"
services:
  api:
    build: .
    ports:
      - "3001:3001"
      - "1080:1080"
      - "9229:9229"
    command: npm run debug
    volumes:
      - ./dist:/app/dist
    depends_on:
      - mongo
    env_file: .env

  mongo:
    image: mongo
    volumes:
      - /data/db
    ports:
      - "27017:27017"
    command: --smallfiles --logpath=/dev/null # --quiet

But when I try to run the debugger, it begins to create a lot of terminals in loop
https://prnt.sc/knmfb2
If I set "restart": true to false, then it doesn't loop but debugger doesn't get attached.
Any tips? Thanks

I see that there's a 2.0 version of the tasks.json format, I have applied this changes, but the problem is the same.
Is this file properly done?
{     // See https://go.microsoft.com/fwlink/?LinkId=733558     // for the documentation about the tasks.json format     "version": "2.0.0",     "tasks": [         {             "label": "watch",             "type": "shell",             "command": "run watch",             "isBackground": true,             "group": "build",             "problemMatcher": [],             "presentation": {                 "echo": true,                 "reveal": "always",                 "focus": false,                 "panel": "shared",                 "showReuseMessage": true             }         }     ] }

Similar problem here.
When trying to debug with vscode, debugger gets attached, breakpoint gets added(showing proper red dot). but, the control won't stop at breakpoint.
But, in chrome inspect, everything works fine.
The app is running inside docker.
command(notice babel-node here):
nodemon --delay 5 --inspect=<IP_ADDRESS>:9229 -w src --exec \"babel-node src\"
launch.json
{
    "version": "0.2.0",
    "configurations": [
        {
            "type": "node",
            "request": "attach",
            "name": "Attach to crazy app",
            "port": 9229,
            "address": "localhost",
            "sourceMaps": true,
            "remoteRoot": "/root/app/",
            "localRoot": "${workspaceRoot}",
            "smartStep": true,
            "restart": true
        }
    ]
}

Any solution?

Oh, for me the trick doesn't work, I'm using babel-node with nodemon.
I have also raised issue here - https://github.com/Microsoft/vscode-recipes/issues/127
Hope someone can help, thanks 👍

@ganapativs actually that trick worked for me with babel-node and nodemon, but with a different setup not the same as here showing.

@imsergiobernal can you share your setup?

We no longer have a Docker-TypeScript recipe as it has been supplanted by Remote-Containers functionality.


OSError: ./exp/test-esc50-f10-t10-impTrue-aspTrue-b48-lr1e-5/fold1/result.csv not found.(ESC-50 Recipe)

Gongyuan先生您好， 首先多谢谢你的工作。但是在我运行 bash run_esc.sh 文件的时候有一点儿问题所以想向您请教。
run_esc.sh 的最后一行是 python ./get_esc_result.py --exp_path ${base_exp_dir}
当程序运行到最后一行的时候, 程序21行告诉我没有发现fold1/result.csv这个文件。所以我想请教一下这个文件是需要自己创建一下么还是用您上传的文件(ast-master/egs/esc50/exp/test-esc50-f10-t10-pTrue-b48-lr1e-5/result.csv).
我上传的图片是错误的blog描述。

Hi there,
The function of get_esc_result.py is to summarize the results of each fold of the 5-fold cross-validation. So the actual error is not here, it is likely due to an error in data downloading or training.
According to your error message, can you change the base_exp_dir in run_esc.sh (as in the screenshot, it says there's a dir already exists) and re-run it? If there's an error again, please paste the entire error message.
I would also suggest checking if https://github.com/YuanGongND/ast/blob/7b2fe7084b622e540643b0d7d7ab736b5eb7683b/egs/esc50/run_esc.sh#L37 has been properly executed by checking if the audio files are downloaded.
-Yuan

You don't need to create result.csv or anything else, the recipe is self-contained.

Hello Mr Gong, because I followed your suggestion, I have figured out this problem already. The bug is from training.
Actually, my GPU is RTX 3060(Memory Size:12 G),  I got this error (the image is below)when I run "run.py" from  "run_esc.sh"
.
So I have to add this command at torch.cuda.empty_cache() at line 178  from "ast_models.py" for alleviating this "Congenital deficiency". But still has the same issue, I have to reduce bath_size from 48 to 2. Finally, the scripts can be working properly.
But I still have a small request, do you know another way to mitigate this issue? Because I greatly reduce the batch_size arbitrarily, I think my way is little dummy.

To lower the computational overhead, the simplest way is to change fstride and tstride at
https://github.com/YuanGongND/ast/blob/7b2fe7084b622e540643b0d7d7ab736b5eb7683b/egs/esc50/run_esc.sh#L33-L34
to larger values (e.g., 16), it is not recommended to set it as values larger than 16 as it will be larger than the patch size. AST is O(n^2) where n is the sequence length, so smaller fstride and tstride can lower the complexity significantly with minor performance drop.
Other solutions include turn of audioset_pretrain and set model_size=tiny224 at                                   audioset_pretrain=args.audioset_pretrain, model_size='base384').
-Yuan

I am super appreciate it, thank you so much Mr Gong.

HELLO Mr Gong, sorry to bother you again. For the "ESC-50 Recipe", in script of "run_esc.sh" could I only run fold 4 individually.
`
fold=4
echo 'now process fold'${fold}
exp_dir=${base_exp_dir}/fold${fold}
tr_data=./data/datafiles/esc_train_data_${fold}.json
te_data=./data/datafiles/esc_eval_data_${fold}.json
CUDA_CACHE_DISABLE=1 python -W ignore ../../src/run.py --model ${model} --dataset ${dataset}
--data-train ${tr_data} --data-val ${te_data} --exp-dir $exp_dir
--label-csv ./data/esc_class_labels_indices.csv --n_class 50
--lr $lr --n-epochs ${epoch} --batch-size $batch_size --save_model False
--freqm $freqm --timem $timem --mixup ${mixup} --bal ${bal}
--tstride $tstride --fstride $fstride --imagenet_pretrain $imagenetpretrain --audioset_pretrain $audiosetpretrain`
Does it have any effect on result? In other word, Can we train each layer separately?

Hi there,
I don't see a reason to do so, 5-fold cross-validation is the standard way to report the results on ESC-50, ESC-50 has some harder folds and some easier folds, so I'd recommend using the standard 5-fold CV. Nevertheless, I am not the author of ESC-50, you can consult the authors to see what's their idea.
-Yuan

Thanks for your reply, I think I can fix it. Thank you.


Gravity

I want to make the LoopBar Item gravity as center,For now its working for START and END.
Please help me how to achieve this?

Hi @bhavna935! Thank you for your feedback. Do you mean the gravity of selector item? If yes, we definitely make this improvement in our future releases of LoopBar. There are some cases where we need to resolve to make this improvement. We need to understand what way for not infinite scrolling mode is best for center gravity selector and provide it. Also there can be problems with header and holder in recyclerView, so we need time to check it and fix. Unfortunately, I can say you exact date of next release, so if you want you can fork library and try to make this improvements by yourself.
If you mean the gravity in viewHolders in example, make free to write your own adapter and viewHolder with gravity you want.
With best regards,
Cleveroad team


Reorder alphabetically - ide, images, keyboard, mail

Reordering alphabetically.

          1 Warning

:warning:
Too many changes (when adding, please keep it to one project per Pull Request)

  Generated by :no_entry_sign: Danger


Multiline with pipe separators

Hi,
Is is possible to split keyword in multiple lines with pipe separator?
Here is my attempt:
| TU
|      | ${msg}= | Run Keyword And Expect Error | *
| ...  | Modbus.Open Connection | ${DUT_ERR} | "DUT_ERR" | 1503

And I obtain following error:
Keyword 'BuiltIn.Run Keyword And Expect Error' expected at least 2 arguments, got 1.

Note that same test with 4-space separator works fine in multiline.

The problem is that ... becomes a test case name when it's in the first column. This variation works:
| TU
|      | ${msg}= | Run Keyword And Expect Error | *
|      | ... | Modbus.Open Connection | ${DUT_ERR} | "DUT_ERR" | 1503

Notice that without pipes
TU
    ${msg}=    Run Keyword And Expect Error    *
...    Modbus.Open Connection    ${DUT_ERR}    "DUT_ERR"    1503

wouldn't work either and you needed to use
TU
    ${msg}=    Run Keyword And Expect Error    *
    ...    Modbus.Open Connection    ${DUT_ERR}    "DUT_ERR"    1503

Notice also that the new test data parser in RF 3.2 (#3076) may actually change this because ... is probably going to be handled so early that it's context isn't known. Anyway, the syntax that currently works will definitely also work in the future.


Feature/esp graph filters

A starting PR for the ESP filters. This adds the filters that are currently possible from the API, and filters the data a necessary:

Add a models and indicators dropdown to view
Filter data correctly based on selector choice
Set defaults for locations, models, and indicators (indicators i currently disabled so that at least some data is visible).
Add support for .env urls in the development environment
Update providers to use .env variable

###ATTENTION: please add the 'ESP_API' key to you .env and give it a url (local or staging or whatever. I don't discriminate when it comes to APIs).
BONUS: Finally fix an annoying bug with 100% width and CSS grid on the dropdown selectors. Add fix for anchor links absolute positioning when scrolling.
NOTE: it seems that the data from the API is not what is expected by design. Year values are only until 2013 (or similar), there is very little data for most cases, and indicators very rarely match a model. It is possible that when applying an association between Models and Locations this will reduce the options more => leading to better data views, but I am skeptical. Please review with caution. We are still missing categories filtering also, which will only refine the empty data more.

If it looks good, could it be merged?


[DON'T MERGE]Update L1 LP addresses

Update L1 LP addresses

Codecov Report

Merging #132 (5750a4a) into develop (59f8de9) will increase coverage by 17.79%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##           develop     #132       +/-   ##
============================================
+ Coverage    71.73%   89.52%   +17.79%
============================================
  Files           68       33       -35
  Lines         2257     1079     -1178
  Branches       335      150      -185
============================================
- Hits          1619      966      -653
+ Misses         638      113      -525

Flag
Coverage Δ

batch-submitter
?

contracts
89.52% <ø> (ø)

core-utils
?

data-transport-layer
?

message-relayer
?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

packages/core-utils/src/common/test-utils.ts

packages/core-utils/src/coders/index.ts

...ices/l1-ingestion/handlers/transaction-enqueued.ts

...kages/batch-submitter/src/batch-submitter/index.ts

packages/data-transport-layer/src/utils/index.ts

...ubmitter/src/batch-submitter/tx-batch-submitter.ts

packages/data-transport-layer/src/utils/eth-tx.ts

packages/core-utils/src/common/index.ts

.../src/services/l2-ingestion/handlers/transaction.ts

packages/data-transport-layer/src/utils/common.ts

... and 25 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 59f8de9...5750a4a. Read the comment docs.


Fix curation image for 901

The curation image file
manual-fixes\BIOMD0000000901\curation_image.jpeg
was actually a text file that said 'format is not supported'.  I removed the file, but presumably it should be replaced by a better image.  (Also, nothing should ever create .jpeg files that are actually text.)

Fixed by #132.


Revert "MWPW-159560"

Reverts adobecom/dc#840

Codecov Report
Attention: Patch coverage is 0% with 61 lines in your changes missing coverage. Please review.

Project coverage is 88.72%. Comparing base (bfcb73f) to head (d77486e).
Report is 6 commits behind head on stage.

Files with missing lines
Patch %
Lines

acrobat/scripts/alloy/verb-widget.js
0.00%
61 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##            stage     #841      +/-   ##
==========================================
- Coverage   88.75%   88.72%   -0.04%
==========================================
  Files          51       51
  Lines        7802     7805       +3
==========================================
  Hits         6925     6925
- Misses        877      880       +3

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Black screen after login on ubuntu 18.04.3 with xrdp version 0.9.11

sesman.log
[20190902-11:50:07] [DEBUG] libscp initialized
[20190902-11:50:07] [INFO ] starting xrdp-sesman with pid 9176
[20190902-11:50:07] [INFO ] IPv6 not supported, falling back to IPv4
[20190902-11:50:07] [DEBUG] Testing if xrdp-sesman can listen on <IP_ADDRESS> port 3350.
[20190902-11:50:07] [DEBUG] Closed socket 5 (AF_INET <IP_ADDRESS>:3350)
[20190902-11:50:07] [INFO ] IPv6 not supported, falling back to IPv4
[20190902-11:50:07] [INFO ] listening to port 3350 on <IP_ADDRESS>
[20190902-11:50:58] [INFO ] A connection received from <IP_ADDRESS> port 41884
[20190902-11:50:59] [INFO ] ++ created session (access granted): username small, ip <IP_ADDRESS>:55546 - socket: 12
[20190902-11:50:59] [INFO ] starting Xorg session...
[20190902-11:50:59] [INFO ] IPv6 not supported, falling back to IPv4
[20190902-11:50:59] [DEBUG] Closed socket 9 (AF_INET <IP_ADDRESS>:5910)
[20190902-11:50:59] [INFO ] IPv6 not supported, falling back to IPv4
[20190902-11:50:59] [ERROR] g_tcp_bind(9, 6010) failed bind IPv6 (errno=97) and IPv4 (errno=98).
[20190902-11:50:59] [DEBUG] Closed socket 9 (AF_INET <IP_ADDRESS>:0)
[20190902-11:50:59] [INFO ] IPv6 not supported, falling back to IPv4
[20190902-11:50:59] [DEBUG] Closed socket 9 (AF_INET <IP_ADDRESS>:5911)
[20190902-11:50:59] [INFO ] IPv6 not supported, falling back to IPv4
[20190902-11:50:59] [DEBUG] Closed socket 9 (AF_INET <IP_ADDRESS>:6011)
[20190902-11:50:59] [INFO ] IPv6 not supported, falling back to IPv4
[20190902-11:50:59] [DEBUG] Closed socket 9 (AF_INET <IP_ADDRESS>:6211)
[20190902-11:50:59] [DEBUG] Closed socket 8 (AF_INET <IP_ADDRESS>:3350)
[20190902-11:50:59] [INFO ] calling auth_start_session from pid 9799
[20190902-11:50:59] [DEBUG] Closed socket 7 (AF_INET <IP_ADDRESS>:3350)
[20190902-11:50:59] [DEBUG] Closed socket 8 (AF_INET <IP_ADDRESS>:3350)
[20190902-11:50:59] [INFO ] /usr/lib/xorg/Xorg :11 -auth .Xauthority -config xrdp/xorg.conf -noreset -nolisten tcp -logfile .xorgxrdp.%s.log
[20190902-11:50:59] [CORE ] waiting for window manager (pid 9800) to exit
[20190902-11:51:27] [CORE ] window manager (pid 9800) did exit, cleaning up session
[20190902-11:51:27] [INFO ] calling auth_stop_session and auth_end from pid 9799
[20190902-11:51:27] [DEBUG] cleanup_sockets:
[20190902-11:51:27] [DEBUG] cleanup_sockets: deleting /var/run/xrdp/sockdir/xrdp_chansrv_audio_out_socket_11
[20190902-11:51:27] [DEBUG] cleanup_sockets: deleting /var/run/xrdp/sockdir/xrdp_chansrv_audio_in_socket_11
[20190902-11:51:27] [DEBUG] cleanup_sockets: deleting /var/run/xrdp/sockdir/xrdpapi_11
[20190902-11:51:27] [INFO ] ++ terminated session:  username xxxx, display :11.0, session_pid 9799, ip <IP_ADDRESS>:55546 - socket: 12

one error line from .xorgxrdp.10.log:
[   193.389] (EE) systemd-logind: failed to take device /dev/dri/card0: Operation not permitted

Hi,
The "failed to take device" error in .xorgxrdp.10.log is not fatal. Please check if you have following fata error in the log file.  If true, please use the fix-method I used.
Fatal server error:
[   279.214] (EE) parse_vt_settings: Cannot open /dev/tty0 (Permission denied)
[   279.214] (EE)
[   279.214] (EE)
Please consult the The X.Org Foundation support
         at http://wiki.x.org
 for help.
[   279.214] (EE) Please also check the log file at ".xorgxrdp.10.log" for additional information.
[   279.214] (EE)
[   279.214] (WW) xf86CloseConsole: KDSETMODE failed: Bad file descriptor
[   279.214] (WW) xf86CloseConsole: VT_GETMODE failed: Bad file descriptor
[   279.215] (EE) Server terminated with error (1). Closing log file.

I searched aound and followed this post http://c-nergy.be/blog/?p=13390 to fix it.
Here is a brief summary: the issue may be related to the missing dependency packages.
and the solution is to install these packages. Following are the commands I used.
sudo apt remove xrdp
sudo apt-get install xserver-xorg-core
sudo apt-get -y install xserver-xorg-input-all
sudo apt-get install xrdp

Hi,
The "failed to take device" error in .xorgxrdp.10.log is not fatal. Please check if you have following fata error in the log file. If true, please use the fix-method I used. ( oh, fogot to mention that I am using ununtu 18.04.1. but i think the issue should be the same.)
Fatal server error:
[   279.214] (EE) parse_vt_settings: Cannot open /dev/tty0 (Permission denied)
[   279.214] (EE)
[   279.214] (EE)
Please consult the The X.Org Foundation support
         at http://wiki.x.org
 for help.
[   279.214] (EE) Please also check the log file at ".xorgxrdp.10.log" for additional information.
[   279.214] (EE)
[   279.214] (WW) xf86CloseConsole: KDSETMODE failed: Bad file descriptor
[   279.214] (WW) xf86CloseConsole: VT_GETMODE failed: Bad file descriptor
[   279.215] (EE) Server terminated with error (1). Closing log file.

I searched aound and followed this post http://c-nergy.be/blog/?p=13390 to fix it.
Here is a brief summary: the issue may be related to the missing dependency packages.
and the solution is to install these packages. Following are the commands I used.
sudo apt remove xrdp
sudo apt-get install xserver-xorg-core
sudo apt-get -y install xserver-xorg-input-all
sudo apt-get install xrdp

Thanks for your reply. There's no other error in the log file. But I followed your suggested command anyway, and get the same result. I was using the install script from http://c-nergy.be. From the webpage, the version I used, 0.5.2, should not have dependency issues.
If the error in .xorgxrdp.10.log doesn't matter, the error in the sesman.log may be the cause? " [ERROR] g_tcp_bind(9, 6010) failed bind IPv6 (errno=97) and IPv4 (errno=98)."

Hi,
Does following log indicate "address/port is already in used"?  (errno=98)
 " [ERROR] g_tcp_bind(9, 6010) failed bind IPv6 (errno=97) and IPv4 (errno=98)."

please check if the port (3389 or 3350) is already used by other program or "dead" xrdp?
If i were you , I would reboot ..

Hi,
After restart xrdp, the errno=98 error is gone. But still unable to login. The log looks alike:
[20190903-23:02:36] [INFO ] A connection received from <IP_ADDRESS> port 50464 [20190903-23:02:36] [INFO ] ++ created session (access granted): username small, ip <IP_ADDRESS>:52023 - socket: 12 [20190903-23:02:36] [INFO ] starting Xorg session... [20190903-23:02:36] [INFO ] IPv6 not supported, falling back to IPv4 [20190903-23:02:36] [DEBUG] Closed socket 9 (AF_INET <IP_ADDRESS>:5910) [20190903-23:02:36] [INFO ] IPv6 not supported, falling back to IPv4 [20190903-23:02:36] [DEBUG] Closed socket 9 (AF_INET <IP_ADDRESS>:6010) [20190903-23:02:36] [INFO ] IPv6 not supported, falling back to IPv4 [20190903-23:02:36] [DEBUG] Closed socket 9 (AF_INET <IP_ADDRESS>:6210) [20190903-23:02:36] [DEBUG] Closed socket 8 (AF_INET <IP_ADDRESS>:3350) [20190903-23:02:36] [INFO ] calling auth_start_session from pid 11747 [20190903-23:02:36] [DEBUG] Closed socket 7 (AF_INET <IP_ADDRESS>:3350) [20190903-23:02:36] [DEBUG] Closed socket 8 (AF_INET <IP_ADDRESS>:3350) [20190903-23:02:36] [INFO ] /usr/lib/xorg/Xorg :10 -auth .Xauthority -config xrdp/xorg.conf -noreset -nolisten tcp -logfile .xorgxrdp.%s.log [20190903-23:02:37] [CORE ] waiting for window manager (pid 11748) to exit [20190903-23:02:47] [CORE ] window manager (pid 11748) did exit, cleaning up session [20190903-23:02:47] [INFO ] calling auth_stop_session and auth_end from pid 11747 [20190903-23:02:47] [DEBUG] cleanup_sockets: [20190903-23:02:47] [DEBUG] cleanup_sockets: deleting /var/run/xrdp/sockdir/xrdp_chansrv_audio_out_socket_10 [20190903-23:02:47] [DEBUG] cleanup_sockets: deleting /var/run/xrdp/sockdir/xrdp_chansrv_audio_in_socket_10 [20190903-23:02:47] [DEBUG] cleanup_sockets: deleting /var/run/xrdp/sockdir/xrdpapi_10 [20190903-23:02:47] [INFO ] ++ terminated session:  username small, display :10.0, session_pid 11747, ip <IP_ADDRESS>:52023 - socket: 12

log .xorgxrdp.10.log should be checked also.

log .xorgxrdp.10.log should be checked also.

The error messages of .xorgxrdp.10.log :
(EE) systemd-logind: failed to take device /dev/dri/card0: Operation not permitted

Closing troubleshooting issues with no update.


mjml getting flagged by npm audit due to vulnerabilities in lodash

Hi,
Our CI pipeline has started flagging up issues from npm audit due to a security vulnerability in one of the dependencies of the various mjml packages - namely lodash <4.17.21 (see here).
It would be great if these could be updated sometime soon.
Thanks.

Hi,
Not really a big priority for us as template is not used within our codebase.

@kmcb777 did we update lodash in 4.10.1 ? If not can we do this for a .2 to close this


calling 'message' on email object returns 'wrong number of arguments (1 for 0 )

Any idea why?
Here is the block:
gmail.inbox.emails(:unread, from: sent_email.to_email).each do |inbox_email|        puts "INBOX EMAIL: #{inbox_email.message}"   end
which throws this error:
ArgumentError: wrong number of arguments (1 for 0)
from /Users/.../.rvm/gems/ruby-2.1.2/gems/gmail-0.4.2/lib/gmail/client/imap_extensions.rb:7:in msg_att' 	from /Users/.../.rvm/rubies/ruby-2.1.2/lib/ruby/2.1.0/net/imap.rb:2210:in numeric_response'
from /Users/.../.rvm/rubies/ruby-2.1.2/lib/ruby/2.1.0/net/imap.rb:2152:in response_untagged' 	from /Users/.../.rvm/rubies/ruby-2.1.2/lib/ruby/2.1.0/net/imap.rb:2132:in response'
from /Users/.../.rvm/rubies/ruby-2.1.2/lib/ruby/2.1.0/net/imap.rb:2058:in parse' 	from /Users/.../.rvm/rubies/ruby-2.1.2/lib/ruby/2.1.0/net/imap.rb:1181:in get_response'
from /Users/.../.rvm/rubies/ruby-2.1.2/lib/ruby/2.1.0/net/imap.rb:1089:in receive_responses' 	from /Users/.../.rvm/rubies/ruby-2.1.2/lib/ruby/2.1.0/net/imap.rb:1075:in block in initialize'

This issue was moved to gmailgem/gmail#125


[update-checkout] Update the cmake that we build on Linux on main to cmake 3.20.2 (latest).

I am not changing the minimum cmake requirements anywhere. I am just changing
this to get ahead of bumpings of minimum cmake requirements in various places.

@swift-ci test

Is the plan to increase the minimum to 3.20 for the next 5.6/6.0 release? Because just by increasing this for trunk, you will likely see CMake config changes that don't work for older CMake get introduced, which will effectively push the minimum up for the next release.
My understanding is that older CMake versions are still supported because the system packages in Ubuntu are these old versions. I'm fine with making those people use a newer CMake, as I only use Linux distros that keep CMake current, but just pointing out that you will be increasing the minimum CMake version too with this change (well, to whatever the minimum of the CMake version used on the macOS/Windows CI and this is).

I am actually going to do a lower one, 3.19. something.


Import type should have type arguments rather than type params

Just found another occurrence of this. Similar to #548.

I'm currently going through all the types right now so you might want to hold off on merging this or doing a breaking change release until I finish that.

I prefer reducing # of commits of master. I'll just wait. Please ping me when you are done.

@dsherret Can you rebase it? I added some github actions to verify that code works.

bors r+


Add Support for Waveshare ESP32-S3-LCD-1.47 board

Hi! Thank you for your hard work on this awesome project.
This PR adds support for the Waveshare ESP32-S3-LCD-1.47, a board very similar to the LILYGO Dongle.
Additionally, it changes the platformio.ini configuration to use extends = common, rather than redundantly listing the ${common.<whatever>} options for each board.
Finally, it moves the definition of the TFT panel type to the platformio.ini file
These changes have been tested on the aforementioned Waveshare board. Thanks again!

Wow thanks! I got my own Waveshare board last night and starting working on a similar port! I've got a few other changes I've added which i'll base on this PR.

Will merge this if it builds and add PSRAM support later

Wow thanks! I got my own Waveshare board last night and starting working on a similar port! I've got a few other changes I've added which i'll base on this PR.

Very cool! I'm going to look into adding support for the Waveshare ESP32-S3-GEEK next.


fix(httpClient): set default content type in header

Description

Set the default content type to application/json according to Notion API.
Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

PR checklist

[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING.md document.
[ ] I have added tests to cover my changes.

Codecov Report

Merging #7 (cf3c1f9) into main (3aca4cd) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main       #7   +/-   ##
=========================================
  Coverage     48.17%   48.17%
  Complexity      985      985
=========================================
  Files           215      215
  Lines          2628     2628
=========================================
  Hits           1266     1266
  Misses         1362     1362

Impacted Files
Coverage Δ

src/HttpClient/HttpClientFactory.php
65.78% <ø> (ø)


fix: Hide very long ENS names

Related to https://github.com/snapshot-labs/snapshot-sequencer/pull/321
Before

After

We should not hide but disable and show an error, like @wa0x6e did with addresses of deleted spaces

@ChaituVR Should be an easy, by moving the condition here instead
https://github.com/snapshot-labs/snapshot/blob/2637914d98be2a797d2df46102ddcc81a4e2f778/src/components/SetupDomain.vue#L64-L71


Support for Azure AD B2C

Is it possible to use this package it with the Azure AD B2C?

Haven't tested, so I don't know unfortunately. B2C has a bit different tokens and parameters, and those are atleast not configurable atm.

For the sake of posterity, did you test it @rogerfn?
Either way, this seems like it can be closed - hope you agree :slightly_smiling_face: Let us know otherwise

It is not really compatible, however it is possible to extend the library. I had to write my own authenticator. If you want I can create a PR with this new feature.

Happy to add that, for sure! So please do. 😊


Introducing Metadata Support for Vectors Collection

This PR introduces metadata for the VectorsCollection, allowing each component of the vector saved by the logger to have a specific label. This enhancement simplifies data analysis, as it enables the display of associated labels in the robot-log-visualizer, as shown in the following image:

To ensure metadata consistency, I've implemented it using the client-server paradigm in YARP. I declared the VectorsCollectionMetadataService in VectorsCollection.thrift (commit: cf151be70ad143f39113fea93ee851a79c84dff7). This change enables asynchronous metadata requests for a specific VectorsCollection, following the same paradigm used in multipleananolgsensorserver and multipleananolgsensorclient.
In this context, the YarpRobotLoggerDevice functions as a client, while the server must be implemented in the application sending the data. The application must expose two ports: a buffered port for streaming data and an rpc port for requesting metadata. The buffered port name should end with the string \measures:o, while the RPC port should end with \rpc:o.
Here's an example of how to use this feature in your code:
#include <BipedalLocomotion/YarpUtilities/VectorsCollection.h>
#include <BipedalLocomotion/YarpUtilities/VectorsCollectionMetadataService.h>
#include <BipedalLocomotion/YarpUtilities/VectorsCollectionMetadata.h>

class Module : public BipedalLocomotion::YarpUtilities::VectorsCollectionMetadataService
{
    yarp::os::BufferedPort<BipedalLocomotion::YarpUtilities::VectorsCollection> m_loggerPort; /**< Logger port. */
    yarp::os::Port m_loggerMetadataPort; /**< Logger metadata port. */
    BipedalLocomotion::YarpUtilities::VectorsCollectionMetadata m_loggerMetadata;

   /**
    * @brief Populate the metadata structure.
    */
    void populateMetadata();

public:
    /**
     * Get the metadata of the logged signals.
     * @return The metadata of the logged signals.
     */
    virtual BipedalLocomotion::YarpUtilities::VectorsCollectionMetadata getMetadata() override;
};

The populateMetadata() function is optional but can be useful for populating the metadata struct. The getMetadata() function is required to enable the YarpRobotLoggerDevice to retrieve the metadata.
In the source file, you should implement Module::populateMetadata() and Module::getMetadata():
void Module::populateMetadata()
{
    auto populateData = [this](const std::string& signal, const std::vector<std::string>& labels)
    {
        this->m_loggerMetadata.vectors[signal] = labels;
    };

    std::vector<std::string> signal3D{"x", "y", "z"};

    populateData("dcm::position::measured", signal3D);
    populateData("dcm::position::desired", signal3D);
};

BipedalLocomotion::YarpUtilities::VectorsCollectionMetadata
Module::getMetadata()
{
    return m_loggerMetadata;
}

To use this functionality, call populateMetadata() during the configuration phase. In this phase, open the loggerPort and the loggerMetadataPort. The connection is established automatically by the YarpRobotLoggerDevice:
//This code should go into the configuration phase

this->populateMetadata();
std::string portPrefix = "module";

//Open the logger port
m_loggerPort.open("/" + portPrefix + "/measures:o");

// open the metadata rpc port
m_loggerMetadataPort.open("/" + portPrefix + "/rpc:o");
if (!BipedalLocomotion::YarpUtilities::VectorsCollectionMetadataService::yarp().attachAsServer(this->m_loggerMetadataPort))
{
    yError() << "[Module::configure] Unable to attach the logger metadata port.";
    return false;
}

In the main loop, add the following code to prepare and populate the data:
BipedalLocomotion::YarpUtilities::VectorsCollection& data = m_loggerPort.prepare();
data.vectors.clear();

auto populateData = [&](const std::string& name, const auto& signal)
{
    data.vectors[name].assign(signal.data(), signal.data() + signal.size());
};

// DCM
populateData("dcm::position::measured", <signal>);
populateData("dcm::position::desired", <signal>);

Probably part of the comment written in https://github.com/ami-iit/bipedal-locomotion-framework/pull/732#issue-1913718811 should be copied in the readme of the device

As a general comment, forcing the port names to a given convention could be risky. It would be useful to have a sort of NWS/NWC approach, but this might be a bit too much for now

You are right converting it in nws/nwc it would be nice. Still, I think we should modify the code a lot. We can have a meeting to decide how to proceed

It is definitely something we can consider for future iterations :wink:

Output of the discussion with @GiulioRomualdi and @traversaro of today

Closed in favour of https://github.com/ami-iit/bipedal-locomotion-framework/pull/767


gotTo => goTo correction

Updating documentation to reflect the correct method name

Hello @rfultz,
Good catch!
Cheers, and have a nice day! :)


api/zip URI should include a trailing '/' in the end

In the Kudu REST API documentation, we have a section about the api/zip/{path}. However, if the trailing / is missed, then any call will result to an HTTP 307 Redirect error.
For example, this request will fail https://<yoursite>.scm.azurewebsites.net/api/zip/site/wwwroot whereas this will succeed https://cmtestfunction.scm.azurewebsites.net/api/zip/site/wwwroot/.
The difference may be subtle but the resulting error is extremely confusing. I'll be happy to send a PR with a fix

I clarified the doc.

Great resolution @davidebbo . Thanks for all your help today!


curated packages full cluster lifecycle adaptations

Issue #, if available:
Description of changes:
Testing (if applicable):
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/hold

Related to https://github.com/aws/eks-anywhere-packages/issues/807

/unhold

I would recommend having someone from the CLI also reviewing this PR.

I would recommend having someone from the CLI also reviewing this PR.

No recommendations?
I've posted the PR for everyone, no one from the CLI side has stepped up (yet).


cmake manages config.h

put config.h under cmake control :)
this way the user can use the UI of cmake to configure all variables without changing files under source control.
As cmake might contain all sorts of variable prefixes I think it wouldn't be good to simply prefix the values with "LE_" like in config.h (I think in the code it is totally ok) and so I used its full form (LE3D_) to make it super obvious that this is about the engine.
If we would use LE_ in cmake configuring the config.h would be much simpler but again I think it might be not obvious enough at that place.
Here is a screenshot what the cmake UI looks like now :D:

I have marked many options as advanced (so they only pop up when hitting the "Advanced" toggle in the UI. It is obviously debatable what is advanced and what is not. first draft :)

Looks very good to me. I merge and test!


Loosen bounds on primitive-unlifted

It would be great if that could be made into a small release.
By the way, I would also like to be the Stackage maintainer of this package, taking care of the bounds and so on. Does this sound right to you?

Sorry for missing. It's already on stackage now. I'm maintaining it. No worries


chore: replace traverse for neotraverse

Description
Please provide the following information:

What changes you made:

Replaces traverse for neotraverse

Why you made them, and:

Replaces traverse for neotraverse to avoid unnecessary extra deps from you-know-who, uses the "legacy" import to avoid having to rewrite any code.

Any other useful context:

(I'm not the author) https://puruvj.dev/blog/forking-and-fixing-traverse

Make sure to follow the PR preparation steps in CONTRIBUTING.md before submitting your PR:

[x] format the codebase: from the root, run yarn fmt:prettier.
[x] update all snapshots (in core & CLI): from the root, run yarn test:update
[x] add Changeset entry: from the root, run yarn g:changeset and follow the CLI instructions. Alternatively, use the Changeset Github Bot to create the file.

Hi, creator of neotraverse here. I wanna ask whether there were any issues with neotraverse such that it couldn't be merged? 😄

Hi, creator of neotraverse here. I wanna ask whether there were any issues with neotraverse such that it couldn't be merged? 😄

Hey, ended up running into some issues with tests. Didn't look much into it, but since Im not a maintainer pushing for a dependency update (and most likely fixing some tests) felt like something it doesnt need now.
Appreciate the effort of neotraverse though, it was plug and play

@max-arias I was actually curious to try this out when I saw @PuruVJ's announcement about neotraverse!
You have my blessing and encouragement to get this PR over the edge 🙏🏽
We have highly extensive snapshot test coverage, so if everything is ✅  we can merge this PR

@max-arias I was actually curious to try this out when I saw @PuruVJ's announcement about neotraverse!
You have my blessing and encouragement to get this PR over the edge 🙏🏽
We have highly extensive snapshot test coverage, so if everything is ✅ we can merge this PR

I'll revisit this then, thanks!

Thanks for reopening!
Might I suggest importing directly from neotraverse? It's the same all but for node it 18+, so should work ideally

Will do 👍  I was following: https://puruvj.dev/blog/forking-and-fixing-traverse#Legacy-mode that suggests using legacy if there are many instances of traverse in the codebase, I figured it was a backwards compatible version.

Even the legacy version doesn’t support node 0.4 though 😅, so it’s still
not 100% backward compatible
Beside that, default build should work as is for modern projects without
having to change how it’s used. Based on what I see, even using
neotraverse/modern will be a pretty small change overall, so that would
work as well
On Tue, 16 Jul 2024 at 3:57 AM, Maximiliano Arias @.***>
wrote:

Thanks for reopening!
Might I suggest importing directly from neotraverse? It's the same all but
for node it 18+, so should work ideally
Will do 👍 I was following:
https://puruvj.dev/blog/forking-and-fixing-traverse#Legacy-mode that
suggests using legacy if there are many instances of traverse in the
codebase, I figured it was a backwards compatible version.
—
Reply to this email directly, view it on GitHub
https://github.com/BuilderIO/mitosis/pull/1498#issuecomment-2229541368,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ALMH4F6TI2Z3M642B2KKTADZMREF3AVCNFSM6AAAAABKZX47AKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMRZGU2DCMZWHA
.
You are receiving this because you were mentioned.Message ID:
@.***>

The errors you're hitting are all TS type errors because you removed @types/traverse, but neotraverse/legacy does not provide types.
I think you'll want to use the regular non-legacy import to be able to get types again.

Webpack strikes again. Seems you will have to use neotraverse/legacy only. I have got a fix for types in legacy, will publish in a few minutes

@max-arias could run npm i https://pkg.pr.new/PuruVJ/neotraverse@4 and see if everything builds? If it does, I'll cut a 0.6.10 release which can then be installed as final

@max-arias could you run yarn add https://pkg.pr.new/PuruVJ/neotraverse@4 and see if everything builds? If it does, I'll cut a 0.6.10 release which can then be installed as final

Bit late and my brain ain't brainin, but no luck with from 'neotraverse':

No luck with neotraverse/legacy:

yarn.lock:

Just published 0.6.10, could you try that? Maybe yarn doesn't play well with pkg.pr.new yet

Uhh I figured it out, its related to tsconfig

Just published 0.6.10, could you try that? Maybe yarn doesn't play well with pkg.pr.new yet

No luck, same errors.
I don't think wsl is the issue, but just in case:

This is a deep can of worms. It can be fixed by changing module: ESNext in tsconfig, but that causes more type errors, namely with svelte/types/interfaces/compiler, as those types dont exist anymore.
Other option is to not type the options object at all for neotraverse. if that's fine we're good to go

What do you think @samijaber ?

I opened #1500 fixing the different issues


"undefined symbol" upon launch on Centos6 32bit

In reference to #649. I have built libvips from the tarball with some of the dependencies, but on runtime of the app i get:
Error: /root/app/build/node_modules/sharp/build/Release/sharp.node: undefined s$
mbol: _ZN2v816FunctionTemplate3NewEPNS_7IsolateEPFvRKNS_20FunctionCallbackInfoI$
S_5ValueEEEENS_5LocalIS4_EENSA_INS_9SignatureEEEiNS_19ConstructorBehaviorE
   at Error (native)
   at Object.Module._extensions..node (module.js:434:18)
   at Module.load (module.js:343:32)
   at Function.Module._load (module.js:300:12)
   at Module.require (module.js:353:17)
   at require (internal/module.js:12:17)
   at Object.<anonymous> (/root/app/build/node_modules/sharp/lib/constructor.j$
:9:15)
   at Module._compile (module.js:409:26)
   at Object.Module._extensions..js (module.js:416:10)
   at Module.load (module.js:343:32)

Output of ldd ./app/build/node_modules/sharp/build/Release/sharp.node:
linux-gate.so.1 =>  (0xb77d4000)
libvips-cpp.so.42 => /usr/local/lib/libvips-cpp.so.42 (0xb7761000)
libvips.so.42 => /usr/local/lib/libvips.so.42 (0xb73dc000)
libgobject-2.0.so.0 => /lib/libgobject-2.0.so.0 (0xb738f000)
libgthread-2.0.so.0 => /lib/libgthread-2.0.so.0 (0xb738a000)
librt.so.1 => /lib/librt.so.1 (0xb7380000)
libglib-2.0.so.0 => /lib/libglib-2.0.so.0 (0xb7263000)          [4/1991]
libstdc++.so.6 => /usr/lib/libstdc++.so.6 (0xb7178000)
libm.so.6 => /lib/libm.so.6 (0xb714e000)
libgcc_s.so.1 => /lib/libgcc_s.so.1 (0xb7130000)
libpthread.so.0 => /lib/libpthread.so.0 (0xb7115000)
libc.so.6 => /lib/libc.so.6 (0xb6f7d000)
libz.so.1 => /lib/libz.so.1 (0xb6f69000)
libpng12.so.0 => /usr/lib/libpng12.so.0 (0xb6f41000)
libtiff.so.3 => /usr/lib/libtiff.so.3 (0xb6edf000)
libjpeg.so.62 => /usr/lib/libjpeg.so.62 (0xb6e88000)
libgmodule-2.0.so.0 => /lib/libgmodule-2.0.so.0 (0xb6e84000)
libexpat.so.1 => /lib/libexpat.so.1 (0xb6e5b000)
liblcms.so.1 => /usr/lib/liblcms.so.1 (0xb6e21000)
libgif.so.4 => /usr/lib/libgif.so.4 (0xb6e18000)
libexif.so.12 => /usr/lib/libexif.so.12 (0xb6ddf000)
/lib/ld-linux.so.2 (0xb77d5000)
libdl.so.2 => /lib/libdl.so.2 (0xb6dd9000)
libSM.so.6 => /usr/lib/libSM.so.6 (0xb6dd1000)
libICE.so.6 => /usr/lib/libICE.so.6 (0xb6db7000)
libX11.so.6 => /usr/lib/libX11.so.6 (0xb6c7d000)
libuuid.so.1 => /lib/libuuid.so.1 (0xb6c78000)
libxcb.so.1 => /usr/lib/libxcb.so.1 (0xb6c4f000)
libXau.so.6 => /usr/lib/libXau.so.6 (0xb6c4c000)

I'm running on node 8. Wiping and reinstalling node_modules doesn't help. Changing versions of node doesn't either. It works okay on my dev environment with the pre built binaries, but fails on production.
Any guesses? Maybe I need the python binding stuff for libvips?

It looks like build/Release/sharp.node has been compiled at npm install time against one version of V8 but is being used at run time with another V8 version.
Is your production system using the same major version of Node as the system on which npm install is being run?

Yes, both are running node 8.6.0, the only difference is that the app is compilled on a 64bit machine. But that shouldn't make a diferrence as the npm install is made on the server itself. I can even see in the output that sharp is building there.

What does "the app is compilled on a 64bit machine" mean?
Could the contents of node_modules generated on a 64-bit machine get copied to a 32-bit machine (even if "npm install is ran on the server itself")?
Are there any environment variables that could be altering compiler behaviour, e.g. LDFLAGS?

"Compile" isn't the right word i guess... Webpack building the application is what i meant ;)
node_modules aren't sent over the wire at all, only package.json and after it is complete it runs npm install there. I checked it out many times, after your first suggestion - I'm quite sure that different node version isn't the case here. Although you seem to be very confident that this is the case, which makes the case very wierd :O No other things come to your mind? node-gyp is throwing a warning about some deprecated constant - this is the one thing that looked odd for me.
LDFLAGS is only modified inside some other modules - fibers and node-sass, the app build mechanism itself doesn't tocuh it, at least I'm not aware of it.

Thank you, definitely a weird one. Are you able to see if this occurs with another major Node (and therefore V8) version, perhaps the latest v6.11.5?

@unski11ed Is this problem still occurring?

Sorry, forgot about this. I can't really tell at the moment. I had to switch for now for a pure JS solution which is slow as he'll. I'll be mangling with the production server in January so I will be able to investigate it more. I can't touch it at the moment. I'll post an update when I'll be able to look at it ok?

Closing for now but please feel free to re-open with more information if available in the future.


Flutter 2.8.1 crashed on iOS because of EXC_BAD_ACCESS KERN_INVALID_ADDRESS

Steps to Reproduce

5% of this crash happens in foreground.
The crash got reported to Firebase console.
I havn't found a way to reproduce it.

Expected results:
Actual results:

Code sample

crashed: com.apple.main-thread
EXC_BAD_ACCESS KERN_INVALID_ADDRESS 0x00000000000006a8
Crashed: com.apple.main-thread
0  Flutter                        0x3b8404 (missing)
1  Flutter                        0x3e464 (missing)
2  Flutter                        0x3c1f0 (missing)
3  Flutter                        0x3c67ac (missing)
4  Flutter                        0x3c6150 (missing)
5  Flutter                        0x12b2c (missing)
6  Flutter                        0xf1cc (missing)
7  CoreFoundation                 0x84d70 __CFNOTIFICATIONCENTER_IS_CALLING_OUT_TO_AN_OBSERVER__ + 28
8  CoreFoundation                 0x84d10 ___CFXRegistrationPost_block_invoke + 52
9  CoreFoundation                 0x8427c _CFXRegistrationPost + 456
10 CoreFoundation                 0x83c2c _CFXNotificationPost + 716
11 Foundation                     0x745c -[NSNotificationCenter postNotificationName:object:userInfo:] + 64
12 UIKitCore                      0xbd6224 -[UIApplication _terminateWithStatus:] + 300
13 UIKitCore                      0x2228d4 -[_UISceneLifecycleMultiplexer _evalTransitionToSettings:fromSettings:forceExit:withTransitionStore:] + 128
14 UIKitCore                      0x222504 -[_UISceneLifecycleMultiplexer forceExitWithTransitionContext:scene:] + 220
15 UIKitCore                      0xbcbdc0 -[UIApplication workspaceShouldExit:withTransitionContext:] + 212
16 FrontBoardServices             0x69a8 <redacted> + 88
17 FrontBoardServices             0x353d4 <redacted> + 80
18 FrontBoardServices             0x196a4 <redacted> + 240
19 FrontBoardServices             0x3536c <redacted> + 132
20 libdispatch.dylib              0x481c _dispatch_client_callout + 20
21 libdispatch.dylib              0x830c _dispatch_block_invoke_direct + 268
22 FrontBoardServices             0x5dfa0 <redacted> + 48
23 FrontBoardServices             0x5dc30 <redacted> + 448
24 FrontBoardServices             0x5e184 <redacted> + 32
25 CoreFoundation                 0xa407c __CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE0_PERFORM_FUNCTION__ + 28
26 CoreFoundation                 0xa3f78 __CFRunLoopDoSource0 + 208
27 CoreFoundation                 0xa327c __CFRunLoopDoSources0 + 268
28 CoreFoundation                 0x9d25c __CFRunLoopRun + 820
29 CoreFoundation                 0x9c9f4 CFRunLoopRunSpecific + 600
30 GraphicsServices               0x3734 GSEventRunModal + 164
31 UIKitCore                      0xbca75c -[UIApplication _run] + 1072
32 UIKitCore                      0xbcffcc UIApplicationMain + 168
33 Runner                         0x5e9c main + 10 (main.swift:10)
34 libdyld.dylib                  0x1cf8 start + 4

Logs

crashed: com.apple.main-thread
EXC_BAD_ACCESS KERN_INVALID_ADDRESS 0x00000000000006a8
Crashed: com.apple.main-thread
0  Flutter                        0x3b8404 (missing)
1  Flutter                        0x3e464 (missing)
2  Flutter                        0x3c1f0 (missing)
3  Flutter                        0x3c67ac (missing)
4  Flutter                        0x3c6150 (missing)
5  Flutter                        0x12b2c (missing)
6  Flutter                        0xf1cc (missing)
7  CoreFoundation                 0x84d70 __CFNOTIFICATIONCENTER_IS_CALLING_OUT_TO_AN_OBSERVER__ + 28
8  CoreFoundation                 0x84d10 ___CFXRegistrationPost_block_invoke + 52
9  CoreFoundation                 0x8427c _CFXRegistrationPost + 456
10 CoreFoundation                 0x83c2c _CFXNotificationPost + 716
11 Foundation                     0x745c -[NSNotificationCenter postNotificationName:object:userInfo:] + 64
12 UIKitCore                      0xbd6224 -[UIApplication _terminateWithStatus:] + 300
13 UIKitCore                      0x2228d4 -[_UISceneLifecycleMultiplexer _evalTransitionToSettings:fromSettings:forceExit:withTransitionStore:] + 128
14 UIKitCore                      0x222504 -[_UISceneLifecycleMultiplexer forceExitWithTransitionContext:scene:] + 220
15 UIKitCore                      0xbcbdc0 -[UIApplication workspaceShouldExit:withTransitionContext:] + 212
16 FrontBoardServices             0x69a8 <redacted> + 88
17 FrontBoardServices             0x353d4 <redacted> + 80
18 FrontBoardServices             0x196a4 <redacted> + 240
19 FrontBoardServices             0x3536c <redacted> + 132
20 libdispatch.dylib              0x481c _dispatch_client_callout + 20
21 libdispatch.dylib              0x830c _dispatch_block_invoke_direct + 268
22 FrontBoardServices             0x5dfa0 <redacted> + 48
23 FrontBoardServices             0x5dc30 <redacted> + 448
24 FrontBoardServices             0x5e184 <redacted> + 32
25 CoreFoundation                 0xa407c __CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE0_PERFORM_FUNCTION__ + 28
26 CoreFoundation                 0xa3f78 __CFRunLoopDoSource0 + 208
27 CoreFoundation                 0xa327c __CFRunLoopDoSources0 + 268
28 CoreFoundation                 0x9d25c __CFRunLoopRun + 820
29 CoreFoundation                 0x9c9f4 CFRunLoopRunSpecific + 600
30 GraphicsServices               0x3734 GSEventRunModal + 164
31 UIKitCore                      0xbca75c -[UIApplication _run] + 1072
32 UIKitCore                      0xbcffcc UIApplicationMain + 168
33 Runner                         0x5e9c main + 10 (main.swift:10)
34 libdyld.dylib                  0x1cf8 start + 4

[✓] Flutter (Channel stable, 2.8.1, on macOS 11.6 20G165 darwin-arm, locale zh-Hans-CN)
    • Flutter version 2.8.1 at /Users/blake/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 77d935af4d (5 weeks ago), 2021-12-16 08:37:33 -0800
    • Engine revision 890a5fca2e
    • Dart version 2.15.1

[✓] Android toolchain - develop for Android devices (Android SDK version 32.0.0)
    • Android SDK at /Users/blake/Library/Android/sdk
    • Platform android-32, build-tools 32.0.0
    • ANDROID_HOME = /Users/blake/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jre/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.10+0-b96-7249189)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 13.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • CocoaPods version 1.11.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2020.3)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.10+0-b96-7249189)

[✓] VS Code (version 1.63.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.32.0

[✓] Connected device (1 available)
    • Chrome (web) • chrome • web-javascript • Google Chrome 97.0.4692.71

• No issues found!

@flutter-symbolizer-bot #96851 (comment) flutter#v2.8.1 force ios release arm64

@flutter-symbolizer-bot #96207 (comment) flutter#v2.8.1 force ios release arm64

duplicate of https://github.com/flutter/flutter/issues/96612 which is likely fixed on master channel. Please follow up on the linked issue.

Is this issue related to the other issue issue 96854 ?

Leaving this issue open for further insights from the team.

cc: @jason-simmons

@maheshmnj I seriously wonder why you're keeping this issue open...
It's clearly the same issue as:
https://github.com/flutter/flutter/issues/96424
https://github.com/flutter/flutter/issues/95844
https://github.com/flutter/flutter/issues/96768
Which was fixed with https://github.com/flutter/engine/pull/30835, and was pushed to master.
Now only needs to be released to beta and stable.

@mkay-42069 This issue was reported in production from the firebase console, The ones you pointed out are reproducible locally when closing the app.  Also, the logs don't look similar to this issue.
So I think it's better to wait for the teams input.

The symbolized stack trace in https://github.com/flutter/flutter/issues/96851#issuecomment-1016409516 includes a crash in flutter::Shell::OnPlatformViewSetSemanticsEnabled during destruction of the flutter::Shell.  So this is a duplicate of https://github.com/flutter/flutter/issues/95844

Thanks @jason-simmons, closing as duplicate of #95844 then.


add init_number initialization for dyups

after updating upstream by dyups restful api, the servers' weight incline

@FengXingYuXin Please resolve the conflict because we recently updated the core code.
THX

@wangfakang Thanks for your remind and  I have resolved it.

All tests successful.     ACK
$ TEST_NGINX_BINARY=/home/fakang.wfk/work/github/tengine/objs/nginx  prove -v -I tests/nginx-tests/nginx-tests/lib/  ./tests/nginx-tests/cases/dyups.t
./tests/nginx-tests/cases/dyups.t ..
1..78
your test dir is /tmp/nginx-test-J3VLSL0QuT at ./tests/nginx-tests/cases/dyups.t line 85.
ok 1 - 2013-02-26 16:51:46
ok 2 - 2013-02-26 17:30:07
ok 3 - 2013-02-26 17:35:19
ok 4 - 2013-02-26 16:51:51
ok 5 - 2013-02-26 16:51:54
ok 6 - 2013-02-26 17:36:42
ok 7 - 2013-02-26 17:36:46
ok 8 - 2013-02-26 17:02:13
ok 9 - 2013-02-26 17:36:59
ok 10 - 2013-02-26 17:40:24
ok 11 - 2013-02-26 17:40:28
ok 12 - 2013-02-26 17:40:32
ok 13 - 2013-02-26 17:40:36
ok 14 - 2013-02-26 17:40:39
ok 15 - 2013-02-26 17:41:09
ok 16 - 2013-02-26 16:51:57
ok 17 - 2013-02-26 16:52:00
ok 18 - 2013-02-26 17:00:54
ok 19 - 2013-02-26 17:42:27
ok 20 - 2013-02-26 17:44:34
ok 21 - 2013-02-26 17:08:00
ok 22 - 2013-02-26 17:08:04
ok 23 - 2013-02-26 17:45:03
ok 24 - 2013-02-26 17:05:20
ok 25 - 2013-02-26 17:05:30
ok 26 - 2013-06-20 17:46:03
ok 27 - 2013-02-28 16:27:45
ok 28 - 2013-02-28 16:27:49
ok 29 - 2013-02-28 16:27:52
ok 30 - 2013-02-28 16:28:44
ok 31 - 2013-02-28 16:23:41
ok 32 - 2013-02-28 16:23:48
ok 33 - 2013-02-28 16:25:32
ok 34 - 2013-02-28 16:25:35
ok 35 - 2013-03-04 15:53:41
ok 36 - 2013-03-04 15:53:44
ok 37 - 2013-03-04 15:53:46
ok 38 - 2013-03-04 15:53:49
ok 39 - 2013-03-05 15:36:40
ok 40 - 2013-03-05 15:37:25
ok 41 - 2013-03-05 16:13:11
ok 42 - 2013-03-05 16:13:23
ok 43 - 2013-03-25 10:29:48
ok 44 - 2013-03-25 10:39:02
ok 45 - 2013-03-25 10:39:28
ok 46 - 2013-03-25 10:49:44
ok 47 - 2013-03-25 10:49:47
ok 48 - 2013-03-25 10:50:41
ok 49 - 2013-03-25 10:49:51
ok 50 - 2014-06-15 07:45:30
ok 51 - 2014-06-15 07:45:33
ok 52 - 2014-06-15 07:45:40
ok 53 - 2014-06-15 07:45:43
nginx: [alert] detected a LuaJIT version which is not OpenResty's; many optimizations will be disabled and performance will be compromised (see https://github.com/openresty/luajit2 for OpenResty's LuaJIT or, even better, consider using the OpenResty releases from https://openresty.org/en/download.html)
ok 54 - 2013-02-26 16:51:46
ok 55 - 2013-02-26 17:30:07
ok 56 - 2013-02-26 17:35:19
ok 57 - 2013-02-26 16:51:51
ok 58 - 2013-02-26 17:02:13
ok 59 - 2013-02-26 17:36:59
ok 60 - 2013-02-26 17:40:24
ok 61 - 2013-02-26 17:41:09
ok 62 - 2013-02-26 17:00:54
ok 63 - 2013-02-26 17:42:27
ok 64 - 2013-02-26 17:45:03
ok 65 - 2013-02-26 17:05:20
ok 66 - 2013-02-26 17:46:03
ok 67 - 2013-02-28 16:27:45
ok 68 - 2013-02-28 16:23:41
ok 69 - 2013-03-04 15:53:41
ok 70 - 2013-03-05 15:36:40
ok 71 - 2013-03-05 15:37:25
ok 72 - 2013-03-05 16:13:11
nginx: [alert] detected a LuaJIT version which is not OpenResty's; many optimizations will be disabled and performance will be compromised (see https://github.com/openresty/luajit2 for OpenResty's LuaJIT or, even better, consider using the OpenResty releases from https://openresty.org/en/download.html)
ok 73 - 5/ 5 11:04:49 2014
ok 74 - 5/ 5 11:04:42 2014
ok 75 - 5/ 5 11:08:08 2014
ok 76 - 5/ 5 11:08:16 2014
ok 77 - no alerts
ok 78 - no sanitizer errors
ok
All tests successful.
Files=1, Tests=78,  8 wallclock secs ( 0.05 usr  0.02 sys +  0.22 cusr  0.12 csys =  0.41 CPU)
Result: PASS

ACK


CockroachDB Operator needs to be removed or replaced

Hi - the cockroachdb operator listed here is not supported and is based on the old Helm2 chart which is EOL.  What can we do to replace this?  The supported CockroachDB operator is available here: https://github.com/cockroachdb/cockroach-operator

Hi @keith-mcclellan - this is a pet project we had for some time when there was no CockroachDB Operator. Feel free to open a PR to add yours. I see that the new CockroachDB operator is written with the Operator SDK Happy to rename the current one to CockroachDB Helm Operator and mark it as deprecated.
We can also put your version in next to the older versions of this, this gives existing users a chance to notice but I guess the current Helm-based Operator isn't in use a lot.

Let's go ahead and rename it as you suggested @dmesser and mark as deprecated.  We're getting close to making our replacement generally available on a number of different channels, happy to discuss publishing it here but it won't be compatible for customers to upgrade directly from the helm operator so it might better to make a fresh listing at that point.  Thoughts?

@keith-mcclellan sounds good. I'll rename the display name now and later mark it as deprecated as soon as your version is published. Does that sound good?

If you could mark it as deprecated now we'd appreciate it - we've been getting support tickets for this from people thinking it's a supported installer.  Thanks!

Also, if you have instructions on how we could publish github.com/cockroachdb/cockroach-operator to the community repo that you could point me at I'd appreciate it. Thanks!

@dmesser can you please give me an idea of how we can replace this listing with our replacement?  Thanks!


Feature/#66 ux improvements, part 2 (fix build)

original PR already merged. fix merged as a separate PR.


AttributeError: type object 'object' has no attribute 'dtype'

Hi,
When I ran staramr search for AMR and plasmid detection for my contigs, I received the following error message:
Input command: staramr search -o /OUTPUT-PATH/staramr/ /INPUT-PATH/contigs.fa
2024-01-09 10:56:37,924 INFO: No --pointfinder-organism specified. Will not search the PointFinder databases
2024-01-09 10:56:37,924 INFO: No --plasmidfinder-database-type specified. Will search the entire PlasmidFinder database
2024-01-09 10:56:37,925 INFO: --output-dir set. All files will be output to [/OUTPUT-PATH/staramr/]
2024-01-09 10:56:37,925 INFO: Will exclude ResFinder/PointFinder genes listed in [/home/User/anaconda3/envs/staramr/lib/python3.7/site-packages/staramr/databases/exclude/data/genes_to_exclude.tsv]. Use --no-exclude-genes to disable
2024-01-09 10:56:38,041 INFO: Making BLAST databases for input files
2024-01-09 10:58:08,675 INFO: Scheduling blasts for contigs.fa
2024-01-09 10:59:39,424 INFO: Note: NumExpr detected 64 cores but "NUMEXPR_MAX_THREADS" not set, so enforcing safe limit of 8.
2024-01-09 10:59:39,425 INFO: NumExpr defaulting to 8 threads.
2024-01-09 10:59:39,833 ERROR: type object 'object' has no attribute 'dtype'
Traceback (most recent call last):
File "/home/User/anaconda3/envs/staramr/bin/staramr", line 68, in
args.run_command(args)
File "/home/User/anaconda3/envs/staramr/lib/python3.7/site-packages/staramr/subcommand/Search.py", line 426, in run
ignore_invalid_files=args.ignore_valid_files)
File "/home/User/anaconda3/envs/staramr/lib/python3.7/site-packages/staramr/subcommand/Search.py", line 256, in _generate_results
report_all_blast, ignore_invalid_files)
File "/home/User/anaconda3/envs/staramr/lib/python3.7/site-packages/staramr/detection/AMRDetection.py", line 131, in run_amr_detection
self._pointfinder_dataframe, self._plasmidfinder_dataframe)
File "/home/User/anaconda3/envs/staramr/lib/python3.7/site-packages/staramr/detection/AMRDetectionResistance.py", line 70, in _create_amr_summary
return amr_detection_summary.create_summary(self._include_negative_results)
File "/home/User/anaconda3/envs/staramr/lib/python3.7/site-packages/staramr/results/AMRDetectionSummary.py", line 135, in create_summary
resistance_frame = self._include_negatives(resistance_frame)
File "/home/User/anaconda3/envs/staramr/lib/python3.7/site-packages/staramr/results/AMRDetectionSummary.py", line 58, in _include_negatives
columns=('Isolate ID', 'Gene')).set_index('Isolate ID')
File "/home/User/anaconda3/envs/staramr/lib/python3.7/site-packages/pandas/core/frame.py", line 466, in init
mgr = init_dict({}, index, columns, dtype=dtype)
File "/home/User/anaconda3/envs/staramr/lib/python3.7/site-packages/pandas/core/internals/construction.py", line 242, in init_dict
val = construct_1d_arraylike_from_scalar(np.nan, len(index), nan_dtype)
File "/home/User/anaconda3/envs/staramr/lib/python3.7/site-packages/pandas/core/dtypes/cast.py", line 1221, in construct_1d_arraylike_from_scalar
dtype = dtype.dtype
AttributeError: type object 'object' has no attribute 'dtype'
I installed pandas == 0.25.3. I successfully generated the set of ndb, nhr ......ntf, and nto files with the command: makeblastdb -in /INPUT-PATH/contigs.fa -dbtype nucl -parse_seqids. Did I miss anything? Thank you for your help in advance.

Hello @siupenyau. Is there a reason why you are using pandas 0.25.3? I think the issue is you are using too old of a version of pandas.

Hi @apetkau ,
Thank you for the reply. I installed Staramr in conda. During the trial run, I received an error message: KeyError: 'Predicted Phenotype. Then I following the suggestion: https://github.com/phac-nml/irida/issues/686#issuecomment-625844117.
Finally, I got this error message during the re-run.

Ah, okay. Thanks for the additional details.
What is the full stack trace of the original error? Which version of staramr are you using (run staramr --version)?
The suggestion in that issue is for a very old version of staramr and no longer works. There may be another issue you've encountered that is unrelated.
As for time taken to build blast databases and schedule blasts, this is variable depending on how large the files are and how many files you are processing.

Sorry for the late reply. The installed version is 0.5.1.
It was installed by default.


Development 2

Pull request overview
Give a general description of why a change is being made, include issue number(s) being fixed if relevant
Pull request checklist
Please check if your PR fulfils the following:

[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been reviewed and added / updated if needed (for bug fixes / features)
[ ] Tests have been run locally and are passing (run_tests_locally())
[ ] Code is styled according to tidyverse styling (checked locally with tidy_code())

What is the current behaviour?
Please describe the current behaviour that you are modifying, or link to a relevant issue. Include screenshots for UI changes where possible.
What is the new behaviour?
Please describe the behaviour or changes that are being added by this PR. Include screenshots for UI changes where possible.
Anything else
Add any notes for people reviewing and testing your code that are appropriate. Tag a @person to review if someone in particular needs to see this.

Adds Employment Rate over time line chart and Employment by Occupation data table to Local Landscape tab
Plus some formatting and additional filters on side panel


Add button to run simmilar simulation

The simulation view page can have a button to preload all of the information into the form to submit a new run. This will make it easier to make minor changes to repeated runs (ie change version of the tool)

Yes, this requires a few changes

Modify the create archive form to support modification
Create an endpoint to extract models/ SED specifications out of archives
Ideally, expand the create archive form to support more of the features of SED-ML, at the very least multiple tasks. This is relatively easy. The form elements for each task could be displayed within tabs or an accordion.

I was actually thinking much simpler. The omex file would be identical, but
give the use the option to swap it out entirely. Introspection of the
actual simulation is definitely a more complicated usecase. I ran into this
when trying to run the same simulation file with different versions of
simulators.
On Tue, Apr 20, 2021 at 3:14 PM Jonathan Karr @.***>
wrote:

Yes, this requires a few changes

Modify the create archive form to support modification
Create an endpoint to extract models/ SED specifications out of
archives
Ideally, expand the create archive form to support more of the
features of SED-ML, at the very least multiple tasks. This is relatively
easy. The form elements for each task could be displayed within tabs or an
accordion.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/biosimulations/Biosimulations/issues/2502#issuecomment-823534601,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AHX4FIA63F7P2CSWH5SP63DTJXG75ANCNFSM43I3DHTQ
.

That's this. Just add a route to /run with query arguments.


Change RPC JSON format from camelCase to snake_case

I notice that the JSON format in the RPC is camelCase, and I propose we change it to snake_case.
Most of JSON in the Stellar ecosystem is snake case.
For example:

All SEPs that provide APIs are snake case.
stellar.expert API is snake case (ref)
Horizon is snake case.
Block Daemon API is snake case (ref)
Lobstr Vault is snake case (ref)

The only API in the Stellar ecosystem I could find that wasn't snake case was the stellarbeat.io API (ref).
Uniformity doesn't really matter, but if folks are consistently pick one over the other I don't think there's much advantage to picking something else.
In regards to jsonrpc and whether there is a preferred naming format, there doesn't appear to be, although examples on jsonrpc.org show snake_case: https://www.jsonrpc.org/specification.

This is a breaking change and is something we can't change at this point because the RPC has been released in a stable release. cc @mollykarcher


feat: factor out backtracking code from solve_by_elim

Following up from discussion on zulip.
No change in functionality, this is just a refactor.

bors merge

bors merge


Partial cleanup of golint warnings: added/fixed comments, made context first parameter, and added defer cancel() to context.WithTimeout and context.WithCancel calls

Thanks for the PR! Merged.


Integrate ovary and testis organ anatomogram

This is a draft PR until curators and data production would make ovary&testis ontology IDs searchable ready from database. As disscussed with @silvie, we are not sure if the zooma mapping are ready for ovary and testis yet, due to the ontology IDs changed from UBRON to FBbt, so the values in variable supportedOrgans are left empty.

[x] Publish a new npm package version of organ-anatomogram

[x] Install the new package in single-cell js bundles

[x] Add tesis and ovary into the new organ list

[ ] Add related ontology ids into the anatomogram router page

Hi @lingyun1010, I reviewed this PR in the draft status as you were waiting for the curator's update. I understood the code flow for integrating new SVGS in the SCXA. I left a review comment, please see if that is feasible to fix as we are waiting for the other team.


Not working correctly for past few days?

I have been using it fine for a week or two. But now I dont seem to get notifications correctly.
I always have the red bar when I first open the page.  Also testing merchant spawn seems to work for me but not test item found.
I have done all the help steps and still am having problems.
Windows 10/Chrome

Which red bar? The one that tells you to click the page? That one is due to the browser and is normal, you always have to click once after the page loads in order for the site to be able to play sound.
As far as the tests it's strange if only one of the two tests is working. The only real differences between them are the text they display. It's more likely something related Windows (and the focus-assist settings), though normally even that should affect both in the same way.

I have been having problems too - Testing notifications on both items and merchant spawns, but only merchant spawns produce sounds. However the popup appears for both.

Yeah, I'm having the same problem. No more notifications happening.
I'm not able to even fire off test notifications nor for cards not for reports.
IM getting some errors in the console. @Xeio

Hmmm, so that last red message is my fault, forgot to check that there is a valid Push Subscription before checking if it needs to be updated. Going to deploy a fix for that tonight, though it won't have any other effect than removing the logged error.
You have something odd going on that you don't even have checkboxes though. There should be a check box next to each of "Play sound when matching..." and "Use In-Browser Notifications", so that they are completely blank/missing is... uh... odd.
Somewhat related, it seems like there may be a bug with the "Test Item" button, that it doesn't play the sound and only sends the Notification, whereas the "Test Spawn" button does both sound and notification. This only affects the test button though and as long as "Play sound when matching item found" is checked the sound will still play when a matching item is on the site.

Hmmm, so that last red message is my fault, forgot to check that there is a valid Push Subscription before checking if it needs to be updated. Going to deploy a fix for that tonight, though it won't have any other effect than removing the logged error.
You have something odd going on that you don't even have checkboxes though. There should be a check box next to each of "Play sound when matching..." and "Use In-Browser Notifications", so that they are completely blank/missing is... uh... odd.
Somewhat related, it seems like there may be a bug with the "Test Item" button, that it doesn't play the sound and only sends the Notification, whereas the "Test Spawn" button does both sound and notification. This only affects the test button though and as long as "Play sound when matching item found" is checked the sound will still play when a matching item is on the site.

Oh, man, MY bad. I completely missed the checkbox "Use in-browser notifications". I checked this and it works again!
Thanks for great tool!

Can you help me with Firebase config? I tried to build your app but it gave my a critical message on debug "Firebase not configured, skipping message sending. Need 'FirebaseSecretFile' config setting for private key."
Do you have discord or add me via Seijin#8216

You should probably create a separate issue for that, rather than add it to this discussion.


Polygon issues on IE11

Seeing a couple of issues with IE11 and the polygon feature.  Release 0.4.1 / Leaflet 1.0
Firstly - intersections are constantly warned about (incorrectly) - can be seen in github example.
Secondly - you can never click the first point to complete the shape.

Notes:

Something is not binding?
Related to a touch handler

I'll look into this, thanks

Draw Polygon fails on Edge too.
It's hard to click on the first point to close to polygon,
The node-icon displays in Edge is in 2020 px size, while by default it should be 88.

L.Browser.touch
is a ugly fix

I agree this is an issue with touch. Ugly fix too, but this is severely browser dependent.

Yes, setting L.Browser.touch to false only under IE works for me - thanks.  Happy for you to close this.

Setting L.Browser.touch = false; gives normal sized node icon but closing the polygon is still nearly impossible. Same for ending a polyline by clicking on the last node.
I'm using leaflet 1.0.2 and draw 0.4.7.
Having this issue in IE11 and Edge, also with Safari on iPad.
With Chrome on Android it closes the polygon, but also adds an extra node close the starting node, so that seems to do both adding a node and closing the polygon.

Are you targeting touch devices or both?

We have users with ipads, android tablets, all desktop browsers and all desktop browsers with touchscreens, so pretty much everything. We might get away with disabling draw capabilities for touchscreens on desktop browsers, forcing them to use the mouse.

Forcing them to use the mouse might not fix the issue.
Back in 4.3 we had users with touch screen laptops that only used mouse and
they still had the issue and also users that didn't have touch screens and
still had the issue in IE.
On Thu, Dec 8, 2016 at 7:56 AM, Richard Hinkamp<EMAIL_ADDRESS>wrote:

We have users with ipads, android tablets, all desktop browsers and all
desktop browsers with touchscreens, so pretty much everything. We might get
away with disabling draw capabilities for touchscreens on desktop browsers,
forcing them to use the mouse.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/Leaflet/Leaflet.draw/issues/618#issuecomment-265676346,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABN9VCZ1YtxXTybWY5qx3xu1ElniNFGUks5rF7g3gaJpZM4Kd-TW
.

Well since L.Browser.touch is always true in IE, even with no touchscreen, that makes sense.

I've been doing a little digging. When enabling a L.Draw.Polygon on the first click 2 touch events and 1 mouse up event occur. So it adds 3 markers to the map at the same location. Clicking on that marker will click the one at the top, which is the 3rd and so you can never click the first marker. This is in IE11 which behaves as pointer AND touch. Will need to check what happens on ipad, maybe just 2 touch events which results in the same problem.
So there is a bug in the event handling, but maybe draw can get smarter too. When drawing a polyline or polygon, multiple consecutive markers at the same location make no sense and could be filtered?

That's basically what my PR addressed. I checked to see if the event was
handled and then didn't handle it more than once.
On Thu, Dec 8, 2016 at 10:56 AM, Richard Hinkamp<EMAIL_ADDRESS>wrote:

I've been doing a little digging. When enabling a L.Draw.Polygon on the
first click 2 touch events and 1 mouse up event occur. So it adds 3 markers
to the map at the same location. Clicking on that marker will click the one
at the top, which is the 3rd and so you can never click the first marker.
This is in IE11 which behaves as pointer AND touch. Will need to check what
happens on ipad, maybe just 2 touch events which results in the same
problem.
So there is a bug in the event handling, but maybe draw can get smarter
too. When drawing a polyline or polygon, multiple consecutive markers at
the same location make no sense and could be filtered?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/Leaflet/Leaflet.draw/issues/618#issuecomment-265712660,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABN9VPRDMl1M5-5RL5ikGU29r_qQzEcmks5rF-JXgaJpZM4Kd-TW
.

@Richard Hinklamp - I'm honestly surprised that the code that checks for
poly self-intersections doesn't prevent multiple consecutive markers
already.
On Thu, Dec 8, 2016 at 2:56 AM, Richard Hinkamp<EMAIL_ADDRESS>wrote:

I've been doing a little digging. When enabling a L.Draw.Polygon on the
first click 2 touch events and 1 mouse up event occur. So it adds 3 markers
to the map at the same location. Clicking on that marker will click the one
at the top, which is the 3rd and so you can never click the first marker.
This is in IE11 which behaves as pointer AND touch. Will need to check what
happens on ipad, maybe just 2 touch events which results in the same
problem.
So there is a bug in the event handling, but maybe draw can get smarter
too. When drawing a polyline or polygon, multiple consecutive markers at
the same location make no sense and could be filtered?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/Leaflet/Leaflet.draw/issues/618#issuecomment-265712660,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAzNEv02GOKsZeI3i4CY3zsg3gHS65Jtks5rF-JXgaJpZM4Kd-TW
.

Oh, interesting, it seems that the poly intersection check only happens
when editing a polygon/polyline, not when drawing a new one. That shouldn't
be too hard to fix, lemme see if I can do that right now.
On Thu, Dec 8, 2016 at 1:43 PM, Joseph Ryan<EMAIL_ADDRESS>wrote:

@Richard Hinklamp - I'm honestly surprised that the code that checks for
poly self-intersections doesn't prevent multiple consecutive markers
already.
On Thu, Dec 8, 2016 at 2:56 AM, Richard Hinkamp<EMAIL_ADDRESS>wrote:

I've been doing a little digging. When enabling a L.Draw.Polygon on the
first click 2 touch events and 1 mouse up event occur. So it adds 3 markers
to the map at the same location. Clicking on that marker will click the one
at the top, which is the 3rd and so you can never click the first marker.
This is in IE11 which behaves as pointer AND touch. Will need to check what
happens on ipad, maybe just 2 touch events which results in the same
problem.
So there is a bug in the event handling, but maybe draw can get smarter
too. When drawing a polyline or polygon, multiple consecutive markers at
the same location make no sense and could be filtered?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/Leaflet/Leaflet.draw/issues/618#issuecomment-265712660,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAzNEv02GOKsZeI3i4CY3zsg3gHS65Jtks5rF-JXgaJpZM4Kd-TW
.

What does this comment mean? I could perhaps fix this but I need to know
what "degenerate cases" means.
// @method newLatLngIntersects(): boolean
// Check for intersection if new latlng was added to this polyline.
// NOTE: does not support detecting intersection for degenerate cases.
// @method newPointIntersects(): boolean

// Check for intersection if new point was added to this polyline.
// newPoint must be a layer point.
// NOTE: does not support detecting intersection for degenerate cases.
On Thu, Dec 8, 2016 at 4:19 PM, Joseph Ryan<EMAIL_ADDRESS>wrote:

Oh, interesting, it seems that the poly intersection check only happens
when editing a polygon/polyline, not when drawing a new one. That shouldn't
be too hard to fix, lemme see if I can do that right now.
On Thu, Dec 8, 2016 at 1:43 PM, Joseph Ryan<EMAIL_ADDRESS>wrote:

@Richard Hinklamp - I'm honestly surprised that the code that checks for
poly self-intersections doesn't prevent multiple consecutive markers
already.
On Thu, Dec 8, 2016 at 2:56 AM, Richard Hinkamp<EMAIL_ADDRESS>
wrote:

I've been doing a little digging. When enabling a L.Draw.Polygon on the
first click 2 touch events and 1 mouse up event occur. So it adds 3 markers
to the map at the same location. Clicking on that marker will click the one
at the top, which is the 3rd and so you can never click the first marker.
This is in IE11 which behaves as pointer AND touch. Will need to check what
happens on ipad, maybe just 2 touch events which results in the same
problem.
So there is a bug in the event handling, but maybe draw can get smarter
too. When drawing a polyline or polygon, multiple consecutive markers at
the same location make no sense and could be filtered?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/Leaflet/Leaflet.draw/issues/618#issuecomment-265712660,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAzNEv02GOKsZeI3i4CY3zsg3gHS65Jtks5rF-JXgaJpZM4Kd-TW
.

So, this is legacy... old... detection code. Apparently the algorithm used doesn't detect some complex cases - which I can only imagine as spirals?

I got a simple fix for not adding double markers, which fixes some issues. iPad works, IE has still some issues because mouse+touch events. I noticed some more weird event stuff, 1 mousedown followed by a double mouseup, double touch events. I guess broken events should be fixed first. I'll see if I can find anything.

Double events seem to be a leaflet problem with PointerEvent, being worked on: https://github.com/Leaflet/Leaflet/issues/5180 This occurs in IE11 and Chrome 55+. When that's fixed, this issue can (hopefully) be properly fixed.

I have a fix for the "difficulty closing the polyline/polygon" issue in my PR: https://github.com/Leaflet/Leaflet.draw/pull/654
Unfortunately, the duplicated pointerevent/clicks/touches issue persists. I have a fork of the 0.4.3 version of Leaflet-draw where this does not occur that we've been using in production, so it must be some changed in Leaflet/Leaflet-draw that has occurred since then (possibly in conjunction with chrome updates) which causes these issues.

Any updates regarding the oversized square node icons?
I am aware that setting L.Browser.touch = false; might fix it but we have users with touch devices so this is not really desired...

Some of these got resolved in #661, right?


WIP: Sidecar and pyinstaller

Using pyinstaller to create executable for python code so we no longer need a venv.
Instructions
To create the executable navigate into src-tauri/src. The spec file for the py file is in there.
Make sure you have pyinstaller installed. (pip3 install pyinstaller)
Then run the following command:
pyinstaller audio_analyzer.spec
This will create your operating systems version of the executable in dist inside src-tauri/src
Create a dist folder inside src-tauri and place the executable inside there.
in src-tauri/sidecar/main.rs
change the following line
let py_executable_path = "dist/audio_analyzer.exe";
to match your file type that was generated.
Run: cargo build
The output will generate an error informing you what to rename your executable to.
On windows it looks like:
audio_analyzer-x86_64-pc-windows-msvc.exe
Then cargo build should work and you can run the app to test functionality.

Closed in favor of PR #33.

Re opening in case this works over embedded python.

closing to make new branch to not have to deal with merge conflicts