Errors while reading archives from java.util.zip via ZipInputStream

There is an error while reading zip archive from standard java.util.zip archiver. Zip4j ZipInputStream successfully read only first header in archive, next it can not find any.
Here is a full code example (with zip generating, and reading via zip4j stream) and reasoning below:

    @Test
    public void test() throws IOException {
        // Arrange
        String archivePath = "C:/Users/Public/test.zipByJavaUtilZip";
        File zipArchive = new File(archivePath);

        File folderToZip = new File("C:/Users/Public/FolderToZip");
        int expectedNumberOfEntries;
        try (java.util.zip.ZipOutputStream zos = new ZipOutputStream(new FileOutputStream(zipArchive))) {
            expectedNumberOfEntries = zipByJavaUtilZip(zos, folderToZip, folderToZip.listFiles());
            zos.flush();
        }

        // Act
        List<String> elements = new ArrayList<>();
        try(InputStream is = new FileInputStream(zipArchive);
                net.lingala.zip4j.io.inputstream.ZipInputStream zis = new ZipInputStream(is)) {

            LocalFileHeader fh;
            while((fh = zis.getNextEntry()) != null)
                elements.add(fh.getFileName());
        }

        // Act-assert
        // Lets prove that there are five elements in archive
        net.lingala.zip4j.ZipFile zf = new net.lingala.zip4j.ZipFile(zipArchive);
        Assertions.assertEquals(expectedNumberOfEntries, zf.getFileHeaders().size());
        Assertions.assertEquals(5, zf.getFileHeaders().size());

        // Assert
        // Check for mistakes in zip4j streams
        Assertions.assertEquals(expectedNumberOfEntries, elements.size()); // (elements.size() == 1) = true
    }

    private static int zipByJavaUtilZip(ZipOutputStream zos, File rootFolder, File[] files) throws IOException {
        int entriesNumber = 0;
        for (File f : files) {
            if (f.isDirectory())
                entriesNumber += zipByJavaUtilZip(zos, rootFolder, f.listFiles());
            else {
                entriesNumber++;
                String path = rootFolder.toPath().relativize(f.toPath()).toString().replaceAll("\\\\", "/");
                ZipEntry entry = new ZipEntry(path);
                zos.putNextEntry(entry);
                try (InputStream fis = new FileInputStream(f)) {
                    IOUtils.copy(fis, zos);
                }
                zos.closeEntry();
            }
        }
        return entriesNumber;
    }

However, comparing archives from zip4j and java.util.zip in hex viewer, I found, that there are not many differences between them. One of them is the general purpose flag, but the 3rd bit of it have been set in both archives. That means, that in LFH compression size is 0, and the actual size is written in the data descriptor (they are identical). So it is normal to dont know the actual size while reading LFH. But the problem is, then I call  zis.getNextEntry() second time the result will be null, because in zis.getNextEntry() there is call of readUntilEndOfEntry(), in it I can see this code:
    if (localFileHeader.isDirectory() || localFileHeader.getCompressedSize() == 0) {
      return;
    }
.....

In this condition there is a leaving from function, because localFileHeader.getCompressedSize() is equal to zero. But after creating archive with the same content via zip4j ZipFile or ZipOutputStream, the test above will pass. So I found this as a strange behaviour.
Moreover, if I fix it in my code with the problems will appear in reading directories-lfh:
if (!lfh.isDirectory())
   zis.readAllBytes();

I don’t know exactly why this is happening and how to fix it (maybe it doesn't need to be fixed at all).
The test archive in attach. Thank you!
test.zip

A quick fix is reading content of any element (no matter file or directory) after each call ZipInputStream.getNextEntry(), even if no one is going to use the data, like:
zis.getNextEntry();
zis.readAllBytes();

The reason for it:
3d bit of general purpose flag is set to 1, so compressedSize in LFH is set to zero,  and after calling getNextEntry() second time readUntilEndOfEntry() doesn't do anything, because of compressedSize = 0. That's why zip4j try to read second LFH from first element content. So quick fix in library code is:
private void readUntilEndOfEntry() throws IOException {
    if (localFileHeader.isDirectory() || (localFileHeader.getCompressedSize() == 0 && !localFileHeader.isDataDescriptorExists())) {
      return;
    }
....

But, I think this only solve consequence but not cause

A quick fix is reading content of any element (no matter file or directory) after each call ZipInputStream.getNextEntry(), even if no one is going to use the data, like:
zis.getNextEntry();
zis.readAllBytes();

The reason for it:
3d bit of general purpose flag is set to 1, so compressedSize in LFH is set to zero,  and after calling getNextEntry() second time readUntilEndOfEntry() doesn't do anything, because of compressedSize = 0. That's why zip4j try to read second LFH from first element content. So quick fix in library code is:
private void readUntilEndOfEntry() throws IOException {
    if (localFileHeader.isDirectory() || (localFileHeader.getCompressedSize() == 0 && !localFileHeader.isDataDescriptorExists())) {
      return;
    }
....

But, I think this only solve consequence but not cause

Thanks for the detailed explanation and your analysis. Appreciate it. I have fixed the issue and will include the fix in the next release.

Thanks for the detailed explanation and your analysis. Appreciate it. I have fixed the issue and will include the fix in the next release.

Issue fixed in v2.7.0 which was released today.


MacApp: Use clean environment for python version and module checks

Description of Changes
Use a clean shell environment when obtaining python interpreter version or installed module version.

[x] Wrote at least one-line docstrings (for any new functions)
[x] Added unit test(s) covering the changes (if testable)

[x] Included a screenshot or animation (if affecting the UI, see Licecap)

Currently, when checking for python version or installed module versions in subprocesses in preparation for launching a spyder_kernel, the subprocess inherits Spyder's environment variables, which can lead to incorrect results if Spyder's environment is not a conda environment (such as in a standalone Mac application). By using a clean subprocess environment, the python version and installed module versions are correctly checked.
Currently, installed module versions are checked by writing a new script to a temporary script file and running it in a python subprocess, possibly several times, depending on the version requirements. This is replaced with a much simpler, single python subprocess call to obtain the installed module version, which can be compared to the requirement(s).
Issue(s) Resolved

This allows the stand-alone Mac application to function properly.
Affirmation
By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct:
@mrclary

Hello @mrclary! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file spyder/utils/programs.py:

Line 855:9: E722 do not use bare 'except'

is envsomething that works on windows?

I think this is ready


expected float as value got "" on smartmon_avg_write_erase_count_raw_value

Hi there,
first of all, thank you very much for this great script and the work you put into this. I just deployed the script and setup my NodeExporter to scape it (I am running Microshift on RHEL9 if that helps). The script runs on the OS and the NodeExporter scrapes it from within its container, as it has a mount of the filesystem. This seems to work.
The error I can see in the logs is the following:
ts=2024-12-14T10:14:30.208Z caller=textfile.go:245 level=error collector=textfile msg="failed to collect textfile data" file=smart_metrics.prom err="failed to parse textfile data from \"/host/root/var/lib/node_ex │
│ porter/textfile_collector/smart_metrics.prom\": text format parsing error in line 12: expected float as value, got \"\""

And indeed if checking the file, line 12 shows an empty value:
smartmon_avg_write_erase_count_raw_value{disk="/dev/sdc",type="sat",smart_id="173"}
I did try to enable the special seagate flag, eventhough I do have WD drives but figured I should try every combination. Unfortunately this did not change things:
smartmon_device_info{disk="/dev/sda",type="sat",model_family="Western Digital Red",model_name="WDC WD40EFRX-68WT0N0",device_model="",serial_number="WD-XXX",firmware_version="82.00A82",vendor="",product="",revision="",lun_id=""} 1
Could you point me in any directions? Thanks a lot!
Marcel

So I did a bit more digging and it seems the issue is with one my disks. For some reason /dev/sdc is reporting no threshold figures. Now I am not expert enough with S.M.A.R.T. values to know what this means or where this might come up. I just reverse engineered the script to come to this conclusion. I suppose though that this value is kind of important or?
I thought about assigning a default value, if you think that makes sense? I am happy to contribute the code for that?
Background info
Here is an extract of what is returned from the smartctl -A -j -d sat /dev/sdc command analysed in the function parse_smartctl_attributes_json. The thres value is clear missing:
{
        "id": 173,
        "name": "Avg_Write/Erase_Count",
        "value": 100,
        "worst": 100,
        "flags": {
          "value": 50,
          "string": "-O--CK ",
          "prefailure": false,
          "updated_online": true,
          "performance": false,
          "error_rate": false,
          "event_count": true,
          "auto_keep": true
        },
        "raw": {
          "value": 3,
          "string": "3"
        }
      }

Which leads to the tsv table created in the same function looking like this. The raw value (which is reported back) falls over into the threshold column (which also is probably not intended) and the raw_value column remains empty as a result (which ultimately results in the behaviour I described originally):
5	Reallocated_Sector_Ct	100	100		0
9	Power_On_Hours	100	100		7191
12	Power_Cycle_Count	100	100		258
165	Total_Write/Erase_Count	100	100<PHONE_NUMBER>
166	Min_W/E_Cycle	100	100		3
167	Min_Bad_Block/Die	100	100		146
168	Maximum_Erase_Cycle	100	100		5
169	Total_Bad_Block	100	100		1245
170	Unknown_Marvell_Attr	100	100		0
171	Program_Fail_Count	100	100		0
172	Erase_Fail_Count	100	100		0
173	Avg_Write/Erase_Count	100	100		3
174	Unexpect_Power_Loss_Ct	100	100		41
184	End_to_End_Error	100	100		0
187	Reported_Uncorrect	100	100		0
188	Command_Timeout	100	100		0
194	Temperature_Celsius	67	43		33
199	SATA_CRC_Error	100	100		0
230	Perc_Write/Erase_Count	1	1		95
232	Perc_Avail_Resrvd_Space	100	100	4	100
233	Total_NAND_Writes_GiB	100	100		6268
234	Perc_Write/Erase_Ct_BC	100	100		10590
241	Total_Writes_GiB	253	253		9783
242	Total_Reads_GiB	253	253		6584
244	Thermal_Throttle	0	100		0

More details about this disk (I mixed them up earlier, its my sandisk flash cache disk and not my WD HDDs):
smartctl -i -j /dev/sdc
{
  "json_format_version": [
    1,
    0
  ],
  "smartctl": {
    "version": [
      7,
      2
    ],
    "svn_revision": "5155",
    "platform_info": "x86_64-linux-5.14.0-427.33.1.el9_4.x86_64",
    "build_info": "(local build)",
    "argv": [
      "smartctl",
      "-i",
      "-j",
      "/dev/sdc"
    ],
    "exit_status": 0
  },
  "device": {
    "name": "/dev/sdc",
    "info_name": "/dev/sdc [SAT]",
    "type": "sat",
    "protocol": "ATA"
  },
  "model_family": "Marvell based SanDisk SSDs",
  "model_name": "SanDisk SDSSDH3 2T00",
  "serial_number": "XXX",
  "wwn": {
    "naa": 5,
    "oui": 6980,
    "id":<PHONE_NUMBER>4
  },
  "firmware_version": "415020RL",
  "user_capacity": {
    "blocks":<PHONE_NUMBER>,
    "bytes":<PHONE_NUMBER>016
  },
  "logical_block_size": 512,
  "physical_block_size": 512,
  "rotation_rate": 0,
  "form_factor": {
    "ata_value": 3,
    "name": "2.5 inches"
  },
  "trim": {
    "supported": true,
    "deterministic": true,
    "zeroed": true
  },
  "in_smartctl_database": true,
  "ata_version": {
    "string": "ACS-4 T13/BSR INCITS 529 revision 5",
    "major_value": 4080,
    "minor_value": 94
  },
  "sata_version": {
    "string": "SATA 3.3",
    "value": 511
  },
  "interface_speed": {
    "max": {
      "sata_value": 14,
      "string": "6.0 Gb/s",
      "units_per_second": 60,
      "bits_per_unit": 100000000
    },
    "current": {
      "sata_value": 3,
      "string": "6.0 Gb/s",
      "units_per_second": 60,
      "bits_per_unit": 100000000
    }
  },
  "local_time": {
    "time_t":<PHONE_NUMBER>,
    "asctime": "Sat Dec 14 14:27:48 2024 CET"
  }
}


Use UNIX Attributes instead of AD UID/GID

Is there a way to use the UID/GID from UNIX Attributes in my linux machine, connected to the ActiveDirectory via PBIS?
Currently now I am testing with PBIS-OPEN <IP_ADDRESS>7.
id USERNAME is giving me back the UID/GID from the AD:
uid=2115504596(tma) gid=2115502593(domain^users) groups=2115502593(domain^users),2115503216(it),2115503091(others)
But I need the UID/GID from the Unix Attributes:
uid=60620(tma)
Is there any way to configure this?

PBIS open generates uid and gid for each user and group. This allows users to work without the Active Directory setup. Using the Active Directory POSIX Attributes is not possible with open.
If you would like to use the Active Directory Attributes instead you can try PBIS Entreprise with a Default Cell setup.

And with PBIS Enterprise it is possible to have the POSIX groups?

Yes both users and groups provisioned to the default cell store their information in the POSIX attributes. More information in the Installation and Administration  guides under the wiki.


[New Feature] Better Mouse Screen Transitions

Description of the new feature / enhancement
The cursor should always come out at the same relative height/width of the first screen.
Scenario when this would be used?
When you have multiple monitors with different dpi and you want to move something between monitors.
Supporting information
Maybe you could get inspiration by the programm LittleBigMouse: https://github.com/mgth/LittleBigMouse/wiki

this is built into windows 11 22h2 now. :)  /dup #1226

Windows 11 22h2's "Ease cursor movement between displays" is not a resolution FYI https://github.com/microsoft/PowerToys/issues/1226#issuecomment-1636700423
I had created a ticket in Windows Feedback Hub https://aka.ms/AAlk7nr for upvoting, @crutkas please help send it to someone that can in charge of it.


Make all vuer examples more accessible with revised instructions

Make code in .py files for generating .md files for readthedocs runable
Revise instructions and test all examples to be runable on a fresh conda env (CI should be done in the future)

Thanks for the hard work! I am checking the updated README.


It's not very clear where to get Debian package with the CML2 software

My download section only have these 4 files available:

refplat_p-20230117-fcs.iso.zip
cml2_p_2.6.0-5_amd64-6.iso.zip
cml2_p_2.6.0-5_amd64-6.ova
cml2_p_2.6.0-5_amd64-6.pkg.zip

Example from config.yaml
deb: cml2_2.5.1-10_amd64.deb

thanks for raising this issue, @audacious-lab . The Debian package is included in the .pkg.zip file which, when you unzip it, is basically a tar file.
you can put the .pkg file (not the .zip) into the directory where the upload tool runs and it will pick it up. however, I need to update the documentation to make this clearer.

Thanks, I was able to unpack this .deb file from .pkg

I'll leave this open until I have pushed the documentation update.


oasis-node log show error

SUMMARY
oasis log show error, but the node is up and running and can be signed
goroutine 472033114 [sleep]:
time.Sleep(0x77359400)
	runtime/time.go:188 +0xba
github.com/tendermint/tendermint/consensus.(*Reactor).queryMaj23Routine(0xc009ae9180, 0x1d54ea0, 0xc00c38d2c0, 0xc045755040)
	github.com/tendermint/tendermint@v0.33.6/consensus/reactor.go:820 +0x107
created by github.com/tendermint/tendermint/consensus.(*Reactor).AddPeer
	github.com/tendermint/tendermint@v0.33.6/consensus/reactor.go:186 +0x14b
^C
root@hz-oasis-bitcat:/mnt/vol# tail -100f oasis.log
internal/poll.(*pollDesc).waitRead(...)
	internal/poll/fd_poll_runtime.go:92
internal/poll.(*FD).Read(0xc04c1d1500, 0xc05a92f000, 0x414, 0x800, 0x0, 0x0, 0x0)
	internal/poll/fd_unix.go:169 +0x19b
net.(*netFD).Read(0xc04c1d1500, 0xc05a92f000, 0x414, 0x800, 0x0, 0xc00017c738, 0xc01ae23100)
	net/fd_unix.go:202 +0x4f
net.(*conn).Read(0xc06157ebd8, 0xc05a92f000, 0x414, 0x800, 0x0, 0x0, 0x0)
	net/net.go:184 +0x8e
io.ReadAtLeast(0x1cff840, 0xc06157ebd8, 0xc05a92f000, 0x414, 0x800, 0x414, 0x1, 0x1, 0xc000fe6380)
	io/io.go:310 +0x87
io.ReadFull(...)
	io/io.go:329
github.com/tendermint/tendermint/p2p/conn.(*SecretConnection).Read(0xc04c2e1c80, 0xc04c480800, 0x400, 0x400, 0x0, 0x0, 0x0)
	github.com/tendermint/tendermint@v0.33.6/p2p/conn/secret_connection.go:238 +0x275
bufio.(*Reader).Read(0xc05f423f20, 0xc047ef6460, 0x1, 0xa, 0xed6a29919, 0xc02cb6fe60, 0x41c876)
	bufio/bufio.go:226 +0x24f
github.com/tendermint/go-amino.(*Codec).UnmarshalBinaryLengthPrefixedReader(0xc00003e1c0, 0x1cfc4a0, 0xc05f423f20, 0x15fe4c0, 0xc0301da500, 0x417, 0x17e, 0x2710, 0x0)
	github.com/tendermint/go-amino@v0.15.0/amino.go:268 +0xfe
github.com/tendermint/tendermint/p2p/conn.(*MConnection).recvRoutine(0xc066eb51e0)
	github.com/tendermint/tendermint@v0.33.6/p2p/conn/connection.go:579 +0x101
created by github.com/tendermint/tendermint/p2p/conn.(*MConnection).OnStart
	github.com/tendermint/tendermint@v0.33.6/p2p/conn/connection.go:231 +0x1d9

goroutine 418108698 [sleep]:
time.Sleep(0x5f5e100)
	runtime/time.go:188 +0xba
github.com/tendermint/tendermint/consensus.(*Reactor).gossipVotesRoutine(0xc009ae9180, 0x1d54ea0, 0xc04c4b1bc0, 0xc04bfb7ba0)
	github.com/tendermint/tendermint@v0.33.6/consensus/reactor.go:672 +0x1f0
created by github.com/tendermint/tendermint/consensus.(*Reactor).AddPeer
	github.com/tendermint/tendermint@v0.33.6/consensus/reactor.go:185 +0x10b

goroutine 417822371 [sleep]:
time.Sleep(0x5f5e100)
	runtime/time.go:188 +0xba
github.com/tendermint/tendermint/consensus.(*Reactor).gossipDataRoutine(0xc009ae9180, 0x1d54ea0, 0xc02a312e40, 0xc029fcda00)
	github.com/tendermint/tendermint@v0.33.6/consensus/reactor.go:558 +0x221
created by github.com/tendermint/tendermint/consensus.(*Reactor).AddPeer
	github.com/tendermint/tendermint@v0.33.6/consensus/reactor.go:184 +0xcb

goroutine 628985514 [runnable]:
github.com/dgraph-io/badger/v2/table.(*Builder).handleBlock(0xc0213bcd80)
	github.com/dgraph-io/badger/v2@v2.0.3/table/builder.go:131 +0xaa
created by github.com/dgraph-io/badger/v2/table.NewTableBuilder
	github.com/dgraph-io/badger/v2@v2.0.3/table/builder.go:116 +0x205

goroutine 601744461 [sleep]:
time.Sleep(0x5f5e100)
	runtime/time.go:188 +0xba
github.com/tendermint/tendermint/consensus.(*Reactor).gossipDataRoutine(0xc009ae9180, 0x1d54ea0, 0xc018f90300, 0xc039f94c30)
	github.com/tendermint/tendermint@v0.33.6/consensus/reactor.go:558 +0x221
created by github.com/tendermint/tendermint/consensus.(*Reactor).AddPeer
	github.com/tendermint/tendermint@v0.33.6/consensus/reactor.go:184 +0xcb

goroutine 608961883 [select]:
github.com/tendermint/tendermint/p2p.(*peer).metricsReporter(0xc04c7f0600)
	github.com/tendermint/tendermint@v0.33.6/p2p/peer.go:347 +0x223
created by github.com/tendermint/tendermint/p2p.(*peer).OnStart
	github.com/tendermint/tendermint@v0.33.6/p2p/peer.go:184 +0x76

goroutine 472581003 [IO wait]:
internal/poll.runtime_pollWait(0x7fd831c691f8, 0x72, 0xffffffffffffffff)
	runtime/netpoll.go:203 +0x55
internal/poll.(*pollDesc).wait(0xc01133b798, 0x72, 0x400, 0x800, 0xffffffffffffffff)
	internal/poll/fd_poll_runtime.go:87 +0x45
internal/poll.(*pollDesc).waitRead(...)
	internal/poll/fd_poll_runtime.go:92
internal/poll.(*FD).Read(0xc01133b780, 0xc03261a800, 0x414, 0x800, 0x0, 0x0, 0x0)
	internal/poll/fd_unix.go:169 +0x19b
net.(*netFD).Read(0xc01133b780, 0xc03261a800, 0x414, 0x800, 0x0, 0xc00017c738, 0xc01ae23100)
	net/fd_unix.go:202 +0x4f
net.(*conn).Read(0xc05e4ba960, 0xc03261a800, 0x414, 0x800, 0x0, 0x0, 0x0)
	net/net.go:184 +0x8e
io.ReadAtLeast(0x1cff840, 0xc05e4ba960, 0xc03261a800, 0x414, 0x800, 0x414, 0x1, 0x1, 0xc000fe6380)
	io/io.go:310 +0x87
io.ReadFull(...)
	io/io.go:329
github.com/tendermint/tendermint/p2p/conn.(*SecretConnection).Read(0xc0113dde00, 0xc01149cc00, 0x400, 0x400, 0x0, 0x0, 0x0)
	github.com/tendermint/tendermint@v0.33.6/p2p/conn/secret_connection.go:238 +0x275
bufio.(*Reader).Read(0xc01e31c4e0, 0xc01c726370, 0x1, 0xa, 0xed6a29919, 0xc0299f1e60, 0x41c876)
	bufio/bufio.go:226 +0x24f
github.com/tendermint/go-amino.(*Codec).UnmarshalBinaryLengthPrefixedReader(0xc00003e1c0, 0x1cfc4a0, 0xc01e31c4e0, 0x15fe4c0, 0xc02a3796d0, 0x417, 0x17e, 0x2710, 0x0)
	github.com/tendermint/go-amino@v0.15.0/amino.go:268 +0xfe
github.com/tendermint/tendermint/p2p/conn.(*MConnection).recvRoutine(0xc06847b8c0)
	github.com/tendermint/tendermint@v0.33.6/p2p/conn/connection.go:579 +0x101
created by github.com/tendermint/tendermint/p2p/conn.(*MConnection).OnStart
	github.com/tendermint/tendermint@v0.33.6/p2p/conn/connection.go:231 +0x1d9

goroutine 601744459 [select]:
github.com/tendermint/tendermint/p2p.(*peer).metricsReporter(0xc018f90300)
	github.com/tendermint/tendermint@v0.33.6/p2p/peer.go:347 +0x223
created by github.com/tendermint/tendermint/p2p.(*peer).OnStart
	github.com/tendermint/tendermint@v0.33.6/p2p/peer.go:184 +0x76

goroutine 472033114 [sleep]:
time.Sleep(0x77359400)
	runtime/time.go:188 +0xba
github.com/tendermint/tendermint/consensus.(*Reactor).queryMaj23Routine(0xc009ae9180, 0x1d54ea0, 0xc00c38d2c0, 0xc045755040)
	github.com/tendermint/tendermint@v0.33.6/consensus/reactor.go:820 +0x107
created by github.com/tendermint/tendermint/consensus.(*Reactor).AddPeer
	github.com/tendermint/tendermint@v0.33.6/consensus/reactor.go:186 +0x14b

ISSUE TYPE

Bug Report

COMPONENT NAME

oasis-node
OASIS NODE VERSION

Software version: 20.8.2
Runtime protocol version: 0.14.0
Consensus protocol version: 0.25.0
Committee protocol version: 0.9.0
Tendermint core version: 0.33.6
ABCI library version: 0.16.2
Go toolchain version: 1.14.4

OS / ENVIRONMENT

Ubuntu 18.04

Unfortunately this doesn't show the actual error, can you include some more lines from your log?

I have deleted the log, this is the second time I have encountered this problem, I will completion next time.

`{"caller":"state.go:1788","level":"info","module":"tendermint:consensus","msg":"Added to lastPrecommits: VoteSet{H:412446 R:0 T:2 +2/3:AA28A527E07A628A640DCADA87236FB2550EC8E3EA1DB96DCC3F803DB732A02D:1:AF{"caller":"state.go:1788","level":"info","module":"tendermint:consensus","msg":"Added to lastPrecommits: VoteSet{H:412446 R:0 T:2 +2/3:AA28A527E07A628A640DCADA87236FB2550EC8E3EA1DB96DCC3F803DB732A02D:1:AFEB33B99902(0.9376142746437831) BA{70:x_xxxxx_xxxxxxxxx_xxxxxx_x_x_xx_x_xxxxxxxxx_xxxxxxxxxxxxx_xxxxxx__xxxx} map[]}","ts":"2020-07-16T18:53:10.45554886Z"}
{"caller":"state.go:1788","level":"info","module":"tendermint:consensus","msg":"Added to lastPrecommits: VoteSet{H:412446 R:0 T:2 +2/3:AA28A527E07A628A640DCADA87236FB2550EC8E3EA1DB96DCC3F803DB732A02D:1:AFEB33B99902(0.9516029745897732) BA{70:x_xxxxx_xxxxxxxxxxxxxxxx_x_x_xx_x_xxxxxxxxx_xxxxxxxxxxxxx_xxxxxx__xxxx} map[]}","ts":"2020-07-16T18:53:11.227766711Z"}
{"caller":"state.go:1788","level":"info","module":"tendermint:consensus","msg":"Added to lastPrecommits: VoteSet{H:412446 R:0 T:2 +2/3:AA28A527E07A628A640DCADA87236FB2550EC8E3EA1DB96DCC3F803DB732A02D:1:AFEB33B99902(0.954994140664999) BA{70:x_xxxxx_xxxxxxxxxxxxxxxx_x_x_xx_xxxxxxxxxxx_xxxxxxxxxxxxx_xxxxxx__xxxx} map[]}","ts":"2020-07-16T18:53:12.428217295Z"}
{"caller":"state.go:1788","level":"info","module":"tendermint:consensus","msg":"Added to lastPrecommits: VoteSet{H:412446 R:0 T:2 +2/3:AA28A527E07A628A640DCADA87236FB2550EC8E3EA1DB96DCC3F803DB732A02D:1:AFEB33B99902(0.9567678611133135) BA{70:x_xxxxx_xxxxxxxxxxxxxxxx_x_x_xx_xxxxxxxxxxx_xxxxxxxxxxxxx_xxxxxx_xxxxx} map[]}","ts":"2020-07-16T18:53:13.116591032Z"}
fatal error: runtime: out of memory
runtime stack:
runtime.throw(0x19499a4, 0x16)
runtime/panic.go:1116 +0x72
runtime.sysMap(0xc0e4000000, 0x8000000, 0x2cdaad8)
runtime/mem_linux.go:169 +0xc5
runtime.(*mheap).sysAlloc(0x2cc3c60, 0x4800000, 0x2cc3c68, 0x2280)
runtime/malloc.go:715 +0x1cd
runtime.(*mheap).grow(0x2cc3c60, 0x2280, 0x0)
runtime/mheap.go:1286 +0x11c
runtime.(*mheap).allocSpan(0x2cc3c60, 0x2280, 0x2570100, 0x2cdaae8, 0x2573540)
runtime/mheap.go:1124 +0x6a0
runtime.(*mheap).alloc.func1()
runtime/mheap.go:871 +0x64
runtime.(*mheap).alloc(0x2cc3c60, 0x2280, 0x244620101, 0xc01bd70180)
runtime/mheap.go:865 +0x81
runtime.largeAlloc(0x4500000, 0xc029c30101, 0x479825)
runtime/malloc.go:1152 +0x92
runtime.mallocgc.func1()
runtime/malloc.go:1047 +0x46
runtime.systemstack(0x0)
runtime/asm_amd64.s:370 +0x66
runtime.mstart()
runtime/proc.go:1041
goroutine 84 [running]:
runtime.systemstack_switch()
runtime/asm_amd64.s:330 fp=0xc029c3ef60 sp=0xc029c3ef58 pc=0x475980
runtime.mallocgc(0x4500000, 0x1651500, 0xa001, 0xc076ea7f80)
runtime/malloc.go:1046 +0x895 fp=0xc029c3f000 sp=0xc029c3ef60 pc=0x41cdf5
runtime.makeslice(0x1651500, 0x4500000, 0x4500000, 0x316ab395)
runtime/slice.go:49 +0x6c fp=0xc029c3f030 sp=0xc029c3f000 pc=0x45cb2c
github.com/dgraph-io/badger/v2/table.NewTableBuilder(0x4000000, 0x0, 0x2, 0x3f847ae147ae147b, 0x1000, 0x0, 0x1, 0xc00116ea80, 0x0, 0x1, ...)
github.com/dgraph-io/badger/v2@v2.0.3/table/builder.go:99 +0x95 fp=0xc029c3f098 sp=0xc029c3f030 pc=0xec74d5
github.com/dgraph-io/badger/v2.(*levelsController).compactBuildTables(0xc00011f180, 0x0, 0x1d3fae0, 0xc016bb3520, 0xc00116eba0, 0xc00116ec00, 0xc05ca1e840, 0x5, 0x5, 0xc05ca20440, ...)
github.com/dgraph-io/badger/v2@v2.0.3/levels.go:535 +0x11a5 fp=0xc029c3f798 sp=0xc029c3f098 pc=0xef16b5
github.com/dgraph-io/badger/v2.(*levelsController).runCompactDef(0xc00011f180, 0x0, 0x1d3fae0, 0xc016bb3520, 0xc00116eba0, 0xc00116ec00, 0xc05ca1e840, 0x5, 0x5, 0xc05ca20440, ...)
github.com/dgraph-io/badger/v2@v2.0.3/levels.go:837 +0xe1 fp=0xc029c3f9a0 sp=0xc029c3f798 pc=0xef3d51
github.com/dgraph-io/badger/v2.(*levelsController).doCompact(0xc00011f180, 0x0, 0x3ff0000000000000, 0x0, 0x0, 0x0, 0x0, 0x0)
github.com/dgraph-io/badger/v2@v2.0.3/levels.go:906 +0x49d fp=0xc029c3fe10 sp=0xc029c3f9a0 pc=0xef47bd
github.com/dgraph-io/badger/v2.(*levelsController).runWorker(0xc00011f180, 0xc00000efa0)`
It's looks like a OOM problem. but oasis-node still runing and signed.  I checked the our monitor system, and there was always an excess of memory on the host.
host config: 2c4G


Few context menus

Hello,
Is some possibility to add few context menus?
I have a case when one menu I should add to the page and another one to "ng-bootstrap" modal dialog. I have tried to implement few context menus, but it doesn't work.
Thanks!

Which part doesn't work?  There are directions on the readme and the demo
shows multiple context menus.
On Jun 26, 2017 3:00 AM, "Tarwos"<EMAIL_ADDRESS>wrote:

Hello,
Is some possibility to add few context menus?
I have a case when one menu I should add to the page and another one to
"ng-bootstrap" modal dialog. I have tried to implement few context menus,
but it doesn't work.
Thanks!
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/isaacplmann/ngx-contextmenu/issues/32, or mute the
thread
https://github.com/notifications/unsubscribe-auth/AA0lQB2-sNS0CETISIiA3cHqdgNLDKQsks5sH1cOgaJpZM4OE78M
.

Context menu (dynamic) in modal dialog template doesn't work. I have one context menu on the page(feature module) and another inside ng-bootstrap modal dialog(share module) which opened from this page. When I try to open dialog's context menu context service open page's context menu. ContextMenuModule.forRoot imports in app.module.

Do both the dialog context menu and the page context menu open?  Or just the page context menu?
Are you passing a contextmenu option to contextMenuService.show.next?  Please paste in all the relevant templates and typescript code, so that I can help diagnose what's happening.

Do both the dialog context menu and the page context menu open? - No. Or just the page context menu? - Yes.
Here is a part of component's codes https://ibb.co/bCBwTQ the similar has ng-bootstrap modal dialog, which is opened from component. And when I triggering contextMenuService.show from dialog, this event works with component's contextmenu, but not with dialog.
It will be great if you have plunker project with ngx-contextmenu and I can modify related my case, for better understanding.

Can you show me the code that triggers the dialog context menu?
You can always clone the repo and modify the demo code to reproduce your issue.

the similar, in modal component I have:
...
onModalContextMenu(rowEvent: MouseEvent, rowType: string, rowData: Test): void {
this.contextMenuService.show.next({
contextMenu: this.modalContextMenu, // difference is here only
event: rowEvent,
item: rowData,
});
rowEvent.preventDefault();
rowEvent.stopPropagation();
}

Can you put this line inside onModalContextMenu?
console.log(this.modalContextMenu);

Let me know if it is defined.

Yes, it is defined. Maybe this screenshot will be more helpful

Regardless of which <context-menu> is opened, I'll still create a <context-menu-content> inside the <app-root>.  The screenshot doesn't actually show a problem.
Are you able to create a small demo repo that I can take a look at?  Or show me more of your code.  I'm not sure why it isn't working.

I'm going to prepare small project, don't want to waste your time

Not a waste - I want it to work.  Thanks for making a repo.

Reopen if you have a repo for this.


Inputs are removed from HTML popovers

In Bootstrap 4.3.x input fields are removed from HTML popovers.
Here is a working example. (CodePen)
This is the defined popover content:

Before the input

<input type="text" name="test_input" value="Test value" />

After the input

The input field isn't even in the popover HTML:

Before the input

After the input

Yes a sanitizer has been added :
You could whitelist what you need so if you need to whitelist those elements you're free to do it using: https://getbootstrap.com/docs/4/3/javascript/#js-sanitizer

Thank you!


Significant slow down inside Git repositories

When visiting a directory with a Git repository, the terminal slows down quite a bit when executing commands, i.e. when executing time ls is fast but I get the prompt back after almost 5 seconds. The output of time ls is:
...
real   0m0.001s
user  0m0.001s
sys    0m0.001s

This is too much time for bash-it to be useful. I have made sure to disable all plugins when trying this. I pulled the latest changes, and they have the same problem.
Any hints on how to solve this? Is this something only on my side? Is there a way to trace what is being execute to pinpoint the problem?
Thanks.

I've figure out why it's taking so long to return the prompt... the larger the Git repository, the more it takes to load. Specifically, when there are many changes in the repo (i.e. git status reports lots of changes), then it significantly slows down.
Is there any way to prevent this?

This can happen with large Git repos. The Bash-it themes show a lot of information, and collecting that information takes a lot of time. There are some flags that can be set to disable some of the info.
Check out the Misc section of the readme: https://github.com/Bash-it/bash-it
Some variables you could try are:

export SCM_CHECK=false - this will disable all SCM information in the prompt
export SCM_GIT_SHOW_DETAILS=false - this will disable showing untracked, unstaged and staged file counts in the prompt
export SCM_GIT_IGNORE_UNTRACKED=true - don't show info on untracked files

Please give these a try and then report back.

There are another option, not currently documented in README, sorry, to disable checking the repo status in Bash it:
$ git config --add bash-it.hide-status 1

You can use set this flag globally for all repos (same effect as SCM_CHECK=false setting) or locally, you choose.
Hope this helps!

Now fixed, I added a short explanation of that feature to the README.

Thank you. The information both of you provided was useful. Best.


Add flowId to avoid unstable teamcity output

The teamcity output was sometimes unstable if the karma test were running in parallel with other tests.
Teamcity Docu:
"The flowId is a unique identifier of the messages flow in a build. Flow tracking is necessary, for example, to distinguish separate processes running in parallel. The identifier is a string that should be unique in the scope of individual build."

I signed it!

I signed it!

Normally the CLA license should be fine now. I used different mail-adresses for CLA and GitHub, but corrected it. If you are interested in the fix use it. I have no time to fight now with not matching mail-adresses.

Thanks can you please ensure that linting passes?

Linting passes now!

cool, looks like the tests don't pass though

No news about corrections for this pull request?
Perhaps flowId can be added with less complex value?

I've managed to provide completion for correction of unit-tests and for the definition of TEST_END.

@dbaies The flowId is dynamically generated so I think it isn't sufficient to hard code it in the test

@Franziskus1988 Yes, but I've faked the clock so the  value should always be the same. Locally the tests passes, regardless of when you execute them.

@dbaies But in travis they are still failing

@Franziskus1988 Yes. I saw.

@dignifiedquire It seems that you can merge now. Thanks to @dbaies the tests are finally fixed.

Thank you :octocat:

Any luck in releasing a new version with this enhancement?

@dignifiedquire Perhaps you guys can release a new version?


Request to close 233 - iRecist vignette initial draft

Please add "Closes #" to the title of the pull request. Then the
issue is closed automatically once it is merged to main.
Thank you for your Pull Request! We have developed this task checklist from the Development Process Guide to help with the final steps of the process. Completing the below tasks helps to ensure our reviewers can maximize their time on your code as well as making sure the admiral codebase remains robust and consistent.
Please check off each taskbox as an acknowledgment that you completed the task or check off that it is not relevant to your Pull Request. This checklist is part of the Github Action workflows and the Pull Request will not be merged into the devel branch until you have checked off each task.

[ ] Code is formatted according to the tidyverse style guide. Run styler::style_file() to style R and Rmd files
[ ] Updated relevant unit tests or have written new unit tests - See Unit Test Guide
[ ] If you removed/replaced any function and/or function parameters, did you fully follow the deprecation guidance?
[ ] Update to all relevant roxygen headers and examples
[ ] Run devtools::document() so all .Rd files in the man folder and the NAMESPACE file in the project root are updated appropriately
[ ] Address any updates needed for vignettes and/or templates
[ ] Update NEWS.md
[ ] Build admiral site pkgdown::build_site() and check that all affected examples are displayed correctly and that all new functions occur on the "Reference" page.
[ ] Address or fix all lintr warnings and errors - lintr::lint_package()
[ ] Run R CMD check locally and address all errors and warnings - devtools::check()
[ ] Link the issue so that it closes after successful merging.
[ ] Address all merge conflicts and resolve appropriately
[ ] Pat yourself on the back for a job well done!  Much love to your accomplishment!

The following line requests to update the man pages by the "Man Pages" workflow.
/roxygenize

For a rendered version of the vignette see https://bundfussr.github.io/admiral/233_iRECIST_vignette/articles/irecist.html.

I have updated the iRECIST test data and added a section regarding mixing RECIST and iRECIST response values. The latest rendered version is available at https://bundfussr.github.io/admiral/233_iRECIST_vignette/articles/irecist.html.

I am going to merge the iRECIST test data this evening because it is planned to submit the new pharmaversesdtm version to CRAN tomorrow.
If you spot anything what should be changed, please comment on https://github.com/pharmaverse/pharmaversesdtm/pull/41.


fix: change ACS175 current formula

:tada: This issue has been resolved in version 1.14.5 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


[youku] the video URLs in API data is not complete

It seems Youku returned only a few minutes of video data.
some broken URLs:

http://v.youku.com/v_show/id_XMzQ2NjUyNjYwNA==.html

ccode related? https://github.com/iawia002/annie/blob/master/extractors/youku.go#L43

Current API comes from m.youku.com, but the mobile site can only watch the first few minutes

I found a new API:
http://pl-ali.youku.com/playlist/m3u8?vid=XMTg2MDkwMjU2OA==&type=hd2&ups_client_netip=abdd9642&utid=IC/oDozKWD8CAd4Sfz3MRXRW&ccode=0502&psid=5fa8f90cc1f373cbdee150b2946a2e29&duration=6679&expire=18000&ups_ts=1522465409&onOff=0&encr=0&ups_key=d738b83dc04932dc77f3d84efa7c0f3f

But I don't know how to construct each parameter


disable notification center on mac due to high cpu usage

There are instances were it seems notification center widgets are taking a lot of CPU, see #95582 . Look at disabling notification center to reduce errant cpu use.
Note:
launchctl unload -w /System/Library/LaunchAgents/com.apple.notificationcenterui.plist
seems to disable notification center, even across reboots.

cc @christopherfujino is this something we should do across the fleet (i.e. the high cpu usage isn't more a one time anomaly)?

cc @christopherfujino is this something we should do across the fleet (i.e. the high cpu usage isn't more a one time anomaly)?

If it's not too difficult, I don't see any reason not to, as it just removes another possible flake vector.

@yusuf-goog is this completed?

@jmagman IDK if this in particular is something affecting our current slow builds, but it seems like something generally good to do.
This seems to me like something we should do from device doctor, as the swarming user, on every mac build, rather than from the SALT server (because I'm worried about something toggling this state in between the SALT states being refreshed). Do you know how launchctl works, and if the swarming user should be able to execute this?


One of endEvent's overloaded methods has a problem

The last two parameters of 'Countly#endEvent(String, String, Map, int, double)' are never used! See below.

Thank you for noticing this.

Fixed in 19.02.1


Add to stackage?

Hi @christian-marie,
I'm hoping to upload a package which depends on this to stackage. If I just add my package, this will be added implicitly, but it's better to be explicit. Would you add it, or if not would you object to me adding it explicitly?

I use nix so have no motive to add it, I'm happy for you to do so.
Let me know if there's anything you need.

Oh and thanks, if you do.

This is in progress — thanks, @christian-marie. I'll ping you if I get a message about relaxing version bounds, etc.


feat: scarb fmt a single file

Allows formatting a single file. Useful for integration with external tools.
Closes #1534

Pushed a commit to avoid emitting the file path in emit mode. Behvaior is similar to foundry.
However I have an issue: it seems that in emit mode, the output has an extra empty line at the end. I can't find where this originates from?

However I have an issue: it seems that in emit mode, the output has an extra empty line at the end. I can't find where this originates from?

I think it's just that get_formatted_file auto-inserts an empty line at EOF ?

Pushed a version that works fine when integrated with Trunk :)


Stash commands failing with trailing whitespace in ref

Instead of using 'stash@{0}' it will in some cases use 'stash@{0}   ' which will result in an invalid reference

Fixed in #138


Corrupted files?

Scan like any other, but I can't pass step_1 (v.0.60) (edit: same issue with 0.62)
I can't move even with this few starting filles.  Step_1 just shuts down and no comments left.
Is this dataset corrupted somehow? If so, then why? what did I do wrong during survey?
TEST.zip

Please check v0.63 and follow instructions. If it is not sufficient please add new issue.


Fix mounting EBS to /NONE

Fixed shared_dir logic. The complete logic: if ebs_settings is not specified or if only using 1 volume and shared_dir is not specified under EBS section, use shared_dir from cluster section. Otherwise always use shared_dir specified under EBS section(s)
Added validator to check limits on maximum number of EBS volumes, and to check that shared_dir is specified under each EBS section when using more than 1 EBS volume
Added test cases in test_section_cluster to test the above mentioned cases

Signed-off-by: Rex<EMAIL_ADDRESS>By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

I'd also add an improvement to the cookbook, to avoid to mount when the shared dir is NONE or /NONE.


(promote) release: build v5.5.160

Test plan: automated release PR, CI will perform additional checks

:green_circle: Release has been promoted, see tag: https://github.com/sourcegraph/deploy-sourcegraph-k8s/tree/v5.5.160.
:no_entry: Do not under any circumstance delete the branch holding the tagged commit (i.e. release-v5.5.160).
:arrow_right: You can safely close that PR and delete its a associated branch.


Fix typo

Coverage remained the same at 100.0% when pulling f8260d561c8f75b5b92e67c70c428fc964eed5c8 on kmiyake:fix_typo into 4ac949e0e0258355883ba6a80f4d0fbcbb8d65c7 on alfa-jpn:master.

Sorry for very late reply.
Thank you for a good PR!!


delegate to GPU not working?

Hello
Wondering, should the { delegate: 'GPU' }  option be working for BlurBackground and VirtualBackground?
I am using it, but the backgrounds are still vastly increasing my CPU usage
Thanks!

the option shifts some workload to the GPU (namely internal mediapipe workload), but due to the fact that not all computation is done on the GPU (#44 ) it still uses quite a bit of CPU. Will close this issue as the underlying issue is the same as #44

@lukasIO got it, thanks
Out of curiosity, have you attempted to incorporate a WebGL pipeline like in https://github.com/livekit/track-processors-js/issues/44?
I'm thinking about forking and incorporating myself because my use case is already pretty CPU intensive, so it'd be good to be able to offload as much as we can. Have you tried before / run into any roadblocks?

No, I haven't attempted it yet.
If you succeed we would of course welcome a PR and incorporate the webGL mode into the official one


Update free-courses-hi.md

What does this PR do?
Add resource(s)
For resources
Description
Hello Sir,
I have added a course of redux in the Hindi courses section
Why is this valuable (or not)?
It is a valuable course
How do we know it's really free?
It is totally free
For book lists, is it a book? For course lists, is it a course? etc.
It is a course
Checklist:

[x] Read our contributing guidelines.
[x] Search for duplicates.
[x] Include author(s) and platform where appropriate.
[x] Put lists in alphabetical order, correct spacing.
[x] Add needed indications (PDF, access notes, under construction).
[x] Used an informative name for this pull request.

Follow-up

Check the status of GitHub Actions and resolve any reported warnings!

ok


Create the generic IM write API in JAVA/JNI layer

@yunhanw-google is there a way we can write path/attributePath without creating Cluster instance?
in chip device controller we have read/subscribe APIs but no write API.

we have merged this generic write api in java matter controller now. @jagadeesh-ayla
thanks

https://github.com/project-chip/connectedhomeip/pull/25445


AttributeError: 'NoneType' object has no attribute 'startswith'

Hello,
I get this error when I try to run python pdcalc.py:
Traceback (most recent call last):
  File "pdcalc.py", line 45, in <module>
    if args.instance.startswith("http"):
AttributeError: 'NoneType' object has no attribute 'startswith'

The -i argument is missing.  I ran into this myself.
Try running it like this: pdcalc -c germany -f rdf -l bnf -i inputfile.xml


How to use multi-gpu training?

Hello, thanks for the detailed repo of BoQ and https://github.com/amaralibey/OpenVPRLab/tree/main
I have 24 gb 2 GPUs and batch size of 120 can't fit in one GPU memory. So i was thinking to use both, i was trying  by adding "devices=[0, 1],  strategy='ddp'," in run.py of open vpr lab but got error.
I trained by keeping batch size of 80 on one GPU and accordingly change warmup step but the BOQ result can't reach near to what you got in paper.

Hello @sumitmishra209
Thank you for your interest,
I didn't try multi-gpu training as I don't have that kind of setup, sorry.
However, 24GB of memory should be enough to train a DinoV2-BoQ model. You can use batchez of size 160x4, and resize images to 224x224 during training and 322x322 during test. I'm getting ~93.5 R@1 on MSLS-val. You can use OpenVPRLab to track and manage your training (https://github.com/amaralibey/OpenVPRLab).


Implicit translations for implicit validation!

ASP.NET MVC has a great feature: Implicit translations for default error messages and/or implicit validation!
Let's take this model:
public class MyModel {
    public int Id { get; set; }
    public int MyInt { get; set; }
    public DateTime MyDateTime { get; set; }
    [Required] public string MyString { get; set; }
}

All I have to do is changing the CurrentUICulture:

Please tell me where's the feature gone in ASP MVC Core?

Please keep in mind

The official documentation "Globalization and localization in ASP.NET Core" (https://docs.microsoft.com/en-us/aspnet/core/fundamentals/localization) ignores this question. Following those instructions would end up in adding thousands of validation attributes (implicit validation becomes explicit validation). Even worse: Each validation attribute must have the ErrorMessage specified. Even worse, part 2: Each ErrorMessage must get the translated string provided by a resource file (*.resx), one per model. Since I cannot use placeholder (e.g. "The {0} field is required.") I have to do that for each property in each model. That's insane!
I know there are proposals out there to add explicit validation with the help of an IValidationMetadataProvider, e.g. https://blogs.msdn.microsoft.com/mvpawardprogram/2017/05/09/aspnetcore-mvc-error-message/. But I won't accept these ones as an answer. There are too error-prone. Even worse: The example spoils the complete concept of localization by pinning the error message to a single resource class.

Please tell me that I don't have to write hundreds of lines just to get the status quo!

Hi @aureole82.
Sorry for our late response.
Is this ask still relevant or should this issue be closed? Thanks!

Yes, @ryanbrandenburg's issue dotnet/corefx/issues/25128 has addressed the right audience. Thanks alot, guys!
Maybe you could mark my issue as duplicate...

Yeah, I'll close as duplicate.


Fix SIL function side effects to handle unapplied escaping captures.

Before this fix, the "new" function side effect implementation returns no side effects for a partial apply that is not applied in the same function. This resulted in DeadStoreElimination incorrectly eliminating the initialization of the closure context. Partial applies that are not on-stack do need to read the captured values in order to move them into the context. The captured value not only needs to be valid at the time it is captured, but the initialization of the closure context is also necsesary to model the fact that the contents of the captured value escape, and may be accessed at an unknown future point.
Fixes rdar://113339972 DeadStoreElimination causes uninitialized closure context

@swift-ci test

@swift-ci benchmark

@swift-ci test

@swift-ci benchmark

No benchmark changes.


Add iOS benchmarks for sksl warmup

Related https://github.com/flutter/flutter/issues/86457.
Am I doing this right? Is there anything else I have to do, @CaseyHillers?
@chinmaygarde

@CaseyHillers https://flutter-review.googlesource.com/c/infra/+/15600

@CaseyHillers Which do I land first? This one or the flutter/infra change?

@CaseyHillers Which do I land first? This one or the flutter/infra change?

Preferably flutter/infra, and wait 15 minutes. However, the order doesn't matter for a non-blocking postsubmit target.

Can we add the test ownership in https://github.com/flutter/flutter/blob/master/TESTOWNERS?


Predefined set of levels for vertical regridding

For some applications, it is necessary to have all models on the same vertical coordinates.
In the current implementation (@bjlittle and @valeriupredoi please correct me if I'm wrong), it is possible to specify in the namelist one or more target levels for the regridding.
It might be useful, however, to implement some sets of predefined levels, that the user can refer to using a tag in select_level. One example could be the CMIP5 standard levels as defined in the CMOR tables (100000. 92500. 85000. 70000. 60000. 50000. 40000. 30000. 25000. 20000. 15000. 10000. 7000. 5000. 3000. 2000. 1000. Pa).
Those predefined levels shall be coded somewhere in the backend code (e.g. in regrid.py) and could be referred to in the namelist in this way:
PREPROCESS:
    - {id: pp1, select_level: {levels: CMIP5_levels, scheme: linear}, ...}
Suggestions are welcome!

Hi Mattia,
Yes, as it is now, one can select a set of vertical levels by initializing
a list in levels: [list] populated with however many levels one needs --
the only problem with this is that if there are too many levels the name of
the intermediary file after select level (if any at all, depending on
config option) will be huge. I will wait until people have decided on this
proposal and code it up, it's an easy-peasy code change.
Cheers,
V
On Fri, Nov 17, 2017 at 10:43 AM, Mattia Righi<EMAIL_ADDRESS>wrote:

For some applications, it is necessary to have all models on the same
vertical coordinates.
In the current implementation (@bjlittle https://github.com/bjlittle
and @valeriupredoi https://github.com/valeriupredoi please correct me
if I'm wrong), it is possible to specify in the namelist one or more target
levels for the regridding.
It might be useful, however, to implement some sets of predefined levels,
that the user can refer to using a tag in select_level. One example could
be the CMIP5 standard levels as defined in the CMOR tables (100000. 92500.
85000. 70000. 60000. 50000. 40000. 30000. 25000. 20000. 15000. 10000. 7000.
5000. 3000. 2000. 1000. Pa).
Those predefined levels shall be coded somewhere in the backend code (e.g.
in regrid.py) and could be referred to in the namelist in this way:
PREPROCESS:

{id: pp1, select_level: {levels: CMIP5_levels, scheme: linear}, ...}

Suggestions are welcome!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/ESMValGroup/ESMValTool/issues/157, or mute the thread
https://github.com/notifications/unsubscribe-auth/AbpCo-ljTLyN7XILUMCPU48GrSgNS45pks5s3WM_gaJpZM4Qh2pU
.

--
Dr. Valeriu Predoi
Computational Scientist for UKESM Core Team
Department of Meteorology, University of Reading
Earley Gate, Office 1U08
READING, RG6 6BB
United Kingdom
Mobile number:<PHONE_NUMBER>2
"If one day you be questioning your ability to come up with professional
results, think of this: Noah's ark was built by farmers whereas the Titanic
was crafted by skilled engineers"

@jvegasbsc @bouweandela @nielsdrost @axel-lauer Any suggestion on where to put the definition of these predefined sets in the code?
In the old version we had a file containing all such constants.
Is there anything similar in the current version (see also #31

There are some predefined sets in the cmor tables. You can see some examples in plevs axis entry in esmvaltool/interface_scripts/cmip5-cmor-tables/Tables/CMIP5_Amon and multiple plev?? entries in esmvaltool/interface_scripts/cmip6-cmor-tables/Tables/CMIP6_coordinate.json
I think we should support them by reading their definitions directly. We can refer to them in the namelist  in the way CMIP5_Amon_plevs or CMIP6_plev7 (I would omit the coordinate table in the naming convention just to make it shorter). This will also make easier to support levels defined by other projects: we will just need the tables in a format we can read.
See

If we can stick to the CMOR definitions that would be a great solution.

@jvegasbsc is this implemented?

Using models not, I forgot about this feature. I am starting to do it

I have added the functionality to read the levels from a MODEL_VAR_COORDINATE reference. It is in branch REFACTORING_vertical_levels_from_reference. The only thing missing is that branch is the code to get the reference file, that I think should be easier for you or @bouweandela.
Can you take a look?

@jvegasbsc I've updated the branch so this works. I've restored namelist_MyVar.yml to the previous pressure level though, because the NCL diagnostic script in it expect a single pressure level to be selected, not multiple. You can test the new pressure level selection features with namelist_preprocessor_test.yml.
The resulting data still does not pass the CMOR check though, see my comment of January 26.

I have an automatic fix pending for axis that are not going in the correct direction, preferably in a way that do not implies loading the data. Do not worry to much about this. In fact, I think we should merge this and open a specific issue for this check

The checks are indeed running with automatic_fixes=False, because we've already done the fix with the function fix_data.

Ok. Thanks for pointing that out, I had completely overlooked that alt40 are not pressure levels, so using them with pressure level data is meaningless anyway. I've changed the test namelist so it uses a set of pressure levels instead.
I guess we can address the issue with the stored_direction later then, when we actually have namelists that use something other than pressure levels.


Cut a New Version?

Basic Version Info
Faraday Version: 2.5.2
Ruby Version: 3.2.1
Issue description
A code fix was issued for custom retry headers which is not in the latest 2.0.0 gem. Need to have a new version released when possible. Thank you!
Actual behavior
NoMethodError:
         undefined method `rate_limit_retry_header=' for #<Faraday::Retry::Middleware::Options max=2, interval=0.1, max_interval=1.7976931348623157e+308, interval_randomness=0.0, backoff_factor=1.0, exceptions=[Errno::ETIMEDOUT, "Timeout::Error", Faraday::TimeoutError, Faraday::RetriableResponse], methods=[:delete, :get, :head, :options, :put], retry_if=#<Proc:0x000000011212cda8 /Users/johnhebron/.rvm/gems/ruby-3.2.1/gems/faraday-retry-2.0.0/lib/faraday/retry/middleware.rb:31 (lambda)>, retry_block=#<Proc:0x0000000112c17088 /Users/johnhebron/.rvm/gems/ruby-3.2.1/gems/faraday-retry-2.0.0/lib/faraday/retry/middleware.rb:74>, retry_statuses=[429]>

Expected behavior
Has code from subsequent commit that fixes the missing attributes.
Steps to reproduce
#!/usr/bin/env ruby
# frozen_string_literal: true

require "bundler/inline"

gemfile do
  source "https://rubygems.org"

  gem "faraday"
  gem "faraday-retry"
end

count = 0
expected = 5
retry_options = {
  max: 2,
  interval: 0.1,
  retry_statuses: [429],
  rate_limit_retry_header: 'x-retry-after',
  rate_limit_reset_header: 'x-rate-limit-time-reset-ms'
}

faraday = Faraday.new do |conn|
  conn.request :retry, retry_options
end

faraday.get("https://httpbin.org/status/429")

exit 1

v2.1.1 now contains the latest!


Discuss future of Notifications

https://pages.github.ibm.com/cdai-design/pal/patterns/notifications/usage/
Considering:

move panel to core
scrub docs of the full page?

### Tasks
- [x] Get Telemetry numbers on notification panel usage
- [ ] Is this specific to Cloud Pak?
- [x] Sync with core on if Notification panel goes into notifications and UI shell workstream
- [ ] Determine next steps based on Core

Figma usage
Gray 10

1,057 instances
38 teams
84 files

Gray 100

828 instances
21 teams
71 files

Telemetry

1,280 instances
528 repos

Discussion with Lauren

Yes it is a good candidate to bring Notifications panel into core
Leaning towards bringing it into the UI shell umbrella

Would likely reference the panel in the Notifications components/pattern

No date set for the work to start

Next steps
Things to consider:

Rename the page

Is there something that encompasses both the panel and the full page?

Utilize tree nav

Notification panel
Notification page
would this require an overview page?

Remove panel docs when it moves to core


Fix FewShotPromptTemplate validation is not working

Fix unexecuted validation in FewShotPromptTemplate

@uehara1414 Please run standardrb --fix and commit changes.

@alchaplinsky I have run standardrb --fix and committed the changes. Please check. Thank you!

@uehara1414 Thank you for your contribution! 🚀


Add nginx metrics crawler plugin

This PR supports to gather nginx provided metrics.
The detail design is described at issue #196.

Current coverage is 90.94% (diff: 100%)

Merging #207 into master will increase coverage by 0.33%

@@             master       #207   diff @@
==========================================
  Files            76         80     +4
  Lines          3332       3412    +80
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
+ Hits           3019       3103    +84
+ Misses          313        309     -4
  Partials          0          0

Powered by Codecov. Last update 335896d...364773f


Add full member chain when using Endpoint.AddError(Expression, ...)

#505

Possible path generation alternatives:
ExpressionHelper.GetExpressionText
ModelExpressionProvider.GetExpressionText<TModel,TValue>

Finding a suitable key for caching the compiled expressions seems to be difficult.
I ended up optimising getting the index value by trying to avoid compiling. Now compiling is only used when expression is eg. i + 1

we can also remove compilation as an option. Compilation will not be used in most cases, and there are workarounds.
eg.
AddError(r => r.type[1+1], "...."); - not allowed
var i = 1+1; AddError(r => r.type[i], "...."); - allowed

this should be good enough for now. we'll just add a note to the docs to be careful about a potential perf impact when using non-constant indexers.
thanks a lot for this contribution. good stuff!!!


won't work with Django 1.8

Environment:
Request Method: POST
Request URL: http://localhost:8020/en/customer/signup/
Django Version: 1.8
Python Version: 2.7.6
Installed Applications:
('django.contrib.admin',
'django.contrib.auth',
'django.contrib.contenttypes',
'django.contrib.sessions',
'django.contrib.messages',
'django.contrib.staticfiles',
'crispy_forms',
'landing',
'customer',
'exchangeclients',
'accountant')
Installed Middleware:
('django.contrib.sessions.middleware.SessionMiddleware',
'django.middleware.common.CommonMiddleware',
'django.middleware.csrf.CsrfViewMiddleware',
'django.contrib.auth.middleware.AuthenticationMiddleware',
'django.contrib.auth.middleware.SessionAuthenticationMiddleware',
'django.contrib.messages.middleware.MessageMiddleware',
'django.middleware.clickjacking.XFrameOptionsMiddleware',
'django.middleware.security.SecurityMiddleware')
Traceback:
File "/home/denis/envs/cbroker/local/lib/python2.7/site-packages/django/core/handlers/base.py" in get_response
132.                     response = wrapped_callback(request, *callback_args, **callback_kwargs)
File "/home/denis/envs/cbroker/local/lib/python2.7/site-packages/django/views/generic/base.py" in view
71.             return self.dispatch(request, *args, **kwargs)
File "/home/denis/envs/cbroker/local/lib/python2.7/site-packages/django/views/generic/base.py" in dispatch
89.         return handler(request, *args, **kwargs)
File "/home/denis/workz/cbroker/customer/views.py" in post
38.                     context={'verification_url': verification_url})
File "/home/denis/envs/cbroker/local/lib/python2.7/site-packages/templated_email/init.py" in send_templated_mail
74.                            headers=headers, **kwargs)
File "/home/denis/envs/cbroker/local/lib/python2.7/site-packages/templated_email/backends/vanilla_django.py" in send
179.                                    file_extension=file_extension)
File "/home/denis/envs/cbroker/local/lib/python2.7/site-packages/templated_email/backends/vanilla_django.py" in get_email_message
112.                                    template_suffix or file_extension)
File "/home/denis/envs/cbroker/local/lib/python2.7/site-packages/templated_email/backends/vanilla_django.py" in _render_email
76.                     response[part] = _get_node(multi_part, render_context, name=part)
File "/home/denis/envs/cbroker/local/lib/python2.7/site-packages/templated_email/utils.py" in _get_node
12.     for node in template:
Exception Type: TypeError at /en/customer/signup/
Exception Value: 'Template' object is not iterable

It looks to me like this project is abandoned, so I created a fork and fixed the problems myself. You can check it out here:
https://github.com/denaje/django-templated-email
Let me know if this doesn't work for you!

Hey, if you open a pull request, I'll have a look and reintegrate it.
Brad Whittington
--
Follow me: @darb http://twitter.com/darb | bradwhittington on Github
https://github.com/bradwhittington/
Call me: +27 82 847 9961 | Skype: bradwhittington
Web: http://toolbelt.co.za
On Tue, Apr 7, 2015 at 3:39 PM, Jesse Denardo<EMAIL_ADDRESS>wrote:

It looks to me like this project is abandoned, so I created a fork and
fixed the problems myself. You can check it out here:
https://github.com/denaje/django-templated-email
Let me know if this doesn't work for you!
—
Reply to this email directly or view it on GitHub
https://github.com/BradWhittington/django-templated-email/issues/41#issuecomment-90557113
.

Opened #42

Denaje plz help Bread this is a very important project. I'll write backends fit to mailgun, sendgrid and etc


Firebase connection

Hello,
I just discovered your application which is really very interesting.
But the problem is, when I try to run it, I get this error: "FIREBASE FATAL ERROR: Can not parse Firebase url Please use https: //  .firebaseio.com".
I have however edited the .env with my information...
could you help me?
Thank you so much !

Salut Anthoni!
This app uses Firebase for storing all pins and polluter-related data. In order to run the app, you'll need to setup a Firebase Project yourself. Please, follow the instructions below:

Create a Firebase project in the Firebase Console.
From the project overview page in the Firebase console, click "Add Firebase to your web app".
Rename ./.env.example to ./.env (should be at the root of the project).
Copy and paste your project's config to the .env file.

After having exactly filled everything as you indicated to me, I always have the same error that occurs ... However, I was careful to fill everything and especially be careful to rename the .env and make sure that it either at the root ...
What do you think of that?
Screenshot of my .env file:
https://pic.anthoni-marie.fr/y/2019/HxE-MyMUV.png
Screenshot of the app:
https://pic.anthoni-marie.fr/y/2019/kg6g7z87ee.png
Thank you :)

Your .env file looks good. Make sure it is at the root of your project, i.e. in the same location as package.json.
I've just tried a fresh $ git clone and everything seems to work correctly on my device. My guess is that your machine ignores the .env file when building the app, and thus the Firebase config is wrong.
Try to put the following piece of code in src/store/configureFirebase.js at line 12 and check the output in your terminal when you launch the app:
console.log({
  apiKey: API_KEY,
  authDomain: AUTH_DOMAIN,
  databaseURL: DATABASE_URL,
  projectId: PROJECT_ID,
  storageBucket: STORAGE_BUCKET,
  messagingSenderId: MESSAGING_SENDER_ID
});

If the logged object is empty, there might be something wrong with the installed dependencies, perhaps try to delete ./node_modules and run $ npm install again.

Forgot to mention – if you change/create a .env file, you'll need to restart the Expo server. Maybe running $ npm start (which is an alias for $ expo start) again will fix the issue. 😄


[leveldb] Disable tests and benchmarks

Describe the pull request

What does your PR fix?
Fixes #27457
The issue occurred in a file that is needed for benchmarking. This PR fixes the issue by not building tests and benchmarks.

Thank you!


08/08/2018 05:51 : Create Pull Request for branch master -> prTesting1_2018080805

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

split/updateTestCon1.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Read only permissions for user organisations

[[[OCTClient        signInToServerUsingWebBrowser:OCTServer.dotComServer scopes:OCTClientAuthorizationScopesRepository ] deliverOnMainThread]      subscribeNext:^(OCTClient *client) {              }];
Will result in :

Which is quite scary, i'm looking for permission to readOnly user organisations and repositories for those organisations. If i remove the scope i got this :

You need at least read:org scope or user scope to list your organizations.

Any help is greatly appreciated 👍

Solved in #300


Add another properties file to set things such as container registry namespace

Registry namespace and other build/deploy variables are being set when we initially configure the pipeline in the Bluemix UI. We do not need really need a separate file for those.

Sounds good.


feat: ignore extension

resolve #57
~compare-folders-0.19.0.vsix.zip~
compare-folders-0.19.2.vsix.zip

@gliviu what do you think?
https://github.com/moshfeu/vscode-compare-folders/pull/58/commits/ee3b2a9a091a013f27b97e0f9d4e6a1417be4441#diff-2a8e25e98543d9d6718152d94c3ae02db3439ba2358285b236979ad6465564d1R12-R27

Looks good

Thanks @gliviu it was pleasure developing with you :)

same on my side :)


Idle support

It would be nice to have elcord stop or change text when the user is idle.
it could be configured via an option: (setq elcord-idletimer 360).

Going to close this since your PR was merged... :P

not quite e.e

Going to close this since your PR was merged... :P

Hm no it is not @Mstrodl
https://github.com/Mstrodl/elcord/pull/34

This should be closed as #66 was merged.


Initial setup for Umbraco AuthorizedServices v14

Draft PR containing the updates to Authorized Services with support for Umbraco 14.
Currently I am experiencing issues rendering the tree items under the Authorized Services menu item, and passing the alias as parameter for the workspace.

Noting here breaking changes for release notes:

JsonSerializer configuration option was removed, as we'll now just use the CMS default based on System.Text.Json only.

I've made a few minor changes - nothing functional, mainly aligning with other packages:

added auth filter for Swagger
added paths in tsconfig for cleaner imports
fixed missing tree icon (wasn't mapped from server model)
template strings for notification messages
closed hanging HTML attributes

I did make a UI change to remove the uui-card-node element (was wrapping the content inside each box in the workspace view) as this shrunk the font size for entire box, and added a nested border. Instead, I've shifted the authorized badge into the status box header, and removed the service name from each box in the view, since it was the same for each and already displayed in the workspace header. If it needs to stay, no worries, I can put it back.

All looks good to me, thanks @nathanwoulfe.


[feat]curveadm: add export cmd for export the yaml that tools-v2 used

Fixed: https://github.com/opencurve/curveadm/issues/315
add export cmd for export the yaml that tools-v2 used

BTW, please push it to develop branch again.


puppeteer: Allow reruns in interactive mode when tests succeed.

We already allowed reruns for failing tests, and this adds the ability to rerun tests that succeeded as well, which is helpful for debugging flaky tests.
Tested manually.

Yeah that does seem like a good idea, merged, thanks @evykassirer!


RenderObject exceptions in performLayout should also include information about what the child(ren) are

Would help debug bugs like #1210 .

done


can not install paper machine with latest Zotero <IP_ADDRESS> on Mac OS X EI Capitan 10.11

Excuse me.
I tried many times, but it still does not work. I went to http://papermachines.org/install/    and  downloaded the latest version of Paper Machines 0.4.9.
But it can not be installed. Could you help me to solve this problem?
Thanks a lot!

Apologies; the version on that page is actually outdated. Please see issue #69 for the updated version.

Thanks Cora. I have added papermachine under your help.
Best regards.
2016-05-14 10:53 GMT-04:00 Cora Johnson-Roberson<EMAIL_ADDRESS>
Apologies; the version on that page is actually outdated. Please see issue
#69 https://github.com/papermachines/papermachines/issues/69 for the
updated version.
—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
https://github.com/papermachines/papermachines/issues/68#issuecomment-219224515

--
Jintong Li
Ph.D.
Department of International Relations
Zhou Enlai School of Government
Nankai University,Tianjin,China


Use rest API for TeamCity 9.0.x

A while ago, Team City on build.palaso.org was upgraded from 7.x to 9.0.2.  BuildUpdate needs to be updated accordingly so that it finds the correct dependencies.
For example, the 7.0 API (which you can execute from a browser and look at the returned XML)
http://build.palaso.org/guestAuth/app/rest/7.0/buildTypes/id:bt440
If you do a search for icu.net.dll, you will find the incorrect bt470 dependencies:
<artifact-dependency id="4" type="artifact_dependency">
    <properties>
        <property name="cleanDestinationDirectory" value="false"/>
        <property name="pathRules" value="icu.net.dll=>lib/Debug icu.net.dll.config=>lib/Debug"/>
        <property name="revisionName" value="lastSuccessful"/>
        <property name="revisionValue" value="latest.lastSuccessful"/>
        <property name="source_buildTypeId" value="bt470"/>
    </properties>
</artifact-dependency>
<artifact-dependency id="5" type="artifact_dependency">
    <properties>
        <property name="cleanDestinationDirectory" value="false"/>
        <property name="pathRules" value="icu.net.dll=>lib/Release icu.net.dll.config=>lib/Release"/>
        <property name="revisionName" value="lastSuccessful"/>
        <property name="revisionValue" value="latest.lastSuccessful"/>
        <property name="source_buildTypeId" value="bt470"/>
    </properties>
</artifact-dependency>

If you update the version number in the rest API:
http://build.palaso.org/guestAuth/app/rest/9.0/buildTypes/id:bt440
You get the correct bt469 dependencies...
<artifact-dependency id="4" type="artifact_dependency">
    <properties count="4">
        <property name="cleanDestinationDirectory" value="false"/>
        <property name="pathRules" value="icu.net.dll=>lib/Debug icu.net.dll.config=>lib/Debug"/>
        <property name="revisionName" value="lastSuccessful"/>
        <property name="revisionValue" value="latest.lastSuccessful"/>
    </properties>
    <source-buildType id="bt469" name="icucil-win32-SILWritingSystems Continuous" description="build for icu54" projectName="Libraries" projectId="Libraries" href="/guestAuth/app/rest/9.0/buildTypes/id:bt469"webUrl="http://build.palaso.org/viewType.html?buildTypeId=bt469"/>
</artifact-dependency>
<artifact-dependency id="5" type="artifact_dependency">
    <properties count="4">
        <property name="cleanDestinationDirectory" value="false"/>
        <property name="pathRules" value="icu.net.dll=>lib/Release icu.net.dll.config=>lib/Release"/>
        <property name="revisionName" value="lastSuccessful"/>
        <property name="revisionValue" value="latest.lastSuccessful"/>
    </properties>
    <source-buildType id="bt469" name="icucil-win32-SILWritingSystems Continuous" description="build for icu54" projectName="Libraries" projectId="Libraries" href="/guestAuth/app/rest/9.0/buildTypes/id:bt469"webUrl="http://build.palaso.org/viewType.html?buildTypeId=bt469"/>
</artifact-dependency>

There is an interim fix (9a2cd9ee49719e389d59c219a7318833b8319241).  I will work on the full update later.

Files issue: https://youtrack.jetbrains.com/issue/TW-40587

Ran into minor issue when upgrading to 9.0 API:
https://youtrack.jetbrains.com/issue/TW-40586.

This has been fixed.  I had to remove reporting on the VCS locations, but that doesn't affect the functionality of the script.


drop dead letter queues

We'll still have cloudwatch metrics to track lambda errors.  DLQs capture the input events for those failures.  Input events for our launch/terminate lambdas are always the same (a fixed launch template/a fixed compute environment), so they're not worth keeping around.

also lets us drop sqs:* permissions from the cloudfront-deployment-role


Documentation:  ADSL Vignette and template script updates

Please select a category the issue is focused on?
User Guides
Let us know where something needs a refresh or put your idea here!
ADSL vignette needs updated to replace function derive_agegrp_fda with derive_var_agegrp_fda.
Also make use of new function derive_var_merged_exist_flag() for population flags.
Review anywhere else the new derive_var_merged_xxxxx functions may be used.

@rossfarrugia - just noticed also that the argument filter in  derive_var_disposition_xxx()  should be replaced by filter_ds

thanks @kabis-ops - hoping to get to this one this week so will make that update too

Also i noticed ADSL template needs updating for deprecated lstalvdt function as per #753 - will update this too (the ADSL vignette was updated already in devel)


How I can put the renderRightComponent at the end of the ModalDropdown

When I add the renderRightComponent for the icon, it shows like this:

But, I need it to show like this:

Checking the code of the ModalDropdown.js I found that I need to modify the "styles.button" to add "justifyContent: 'space-between'".
Can you add one option to modify the view style "View style={styles.button}"?
One solution I found was to add 90% width to the textStyle, but I think it would be more helpful if I could modify the view style.
Thanks.

You saved my life with this solution :D Never tought about it!!!

I had the same issue, I added a patch in my library.
I am going to make a PR for future references

When I add the renderRightComponent for the icon, it shows like this:

But, I need it to show like this:

Checking the code of the ModalDropdown.js I found that I need to modify the "styles.button" to add "justifyContent: 'space-between'". Can you add one option to modify the view style "View style={styles.button}"?
One solution I found was to add 90% width to the textStyle, but I think it would be more helpful if I could modify the view style.
Thanks.

flex: 1 to text styles works too. Thanks


RFC: Repos should contain HACKS.md document

Proposal:
Repos should contain a HACKS.md document that details hack-like changes to a codebase.
Reasoning
This was spawned by Eigen's good example and @pvinis's initial idea, but the gist of it is: long-lived repos often contain quick-fixes and other changes that don't live within normal chains of command. These fixes are often made in the moment and are highly dependent on developer context, which is often lost when staff moves on.
Patches created via patch-package are a great example of a hack:

https://github.com/artsy/metaphysics/blob/master/patches/graphql-tools%2B4.0.5.patch
https://github.com/artsy/force/tree/master/patches

While a dev can trace their creation back to a PR this often doesn't provide enough context to understand why a patch was created in the first place. And because of these patch changes, library upgrades can become dramatically more complicated ("why was this library change made in the first place? Can it be safely removed?"). By documenting things like this in a HACKS.md file, context is preserved.
This RFC is mostly pointing at repos that already use patch-package (most of our JS repos) but can be extended to any codebase.
Exceptions:
None.
Additional Context:
This RFC was prompted by a discussion in slack around updating MP schema stitching to latest, with the added caveat that there was a non-trivial patch involved. Undocumented patches like this bring fear to every lib update -- especially critical infrastructural ones like schema stitching.
How is this RFC resolved?
A HACKS.md file is added to our common repos and awareness of this new pattern is spread about the team.

Interesting! I'm wondering about the file name though - why not just call it what it is, something like patch-package-reasons.md or something, haha. Are there examples of items in the HACKS.md file that are not patch package-related?

Are there examples of items in the HACKS.md file that are not patch package-related?

Nope, no other examplels, but I'm certain there are too many to count! The only reason we even know about patch package hacks is because it outputs a git patch file. Having a pattern like this in place is meant to centralize this category of technical decision making.

I love this idea! Two things I'd like to suggest/clarify:

What exactly belongs in the HACKS.md file? As Jon asked above, is it only patch-packages? In the Eigen example, I also see an entry for EchoNew.json, which makes me think it's broader than that. If we implement this, I'd suggest we have clear examples.
Are there ways to structure this file (while keeping it fast and simple)? Especially if this file ends up getting used for a broader variety of things than just patch-packages, and it's being actively updated by many engineers, I could see it getting very big! Not to over-optimize though; I'd still be in favor of just trying it and seeing if we like it

I listed the Eigen example as a way of showing the wide variety of things that can be in there, but will update the RFC to make clearer 👍

I'm so happy my suggestion inspired an rfc 😍.
I'll offer my ideas behind that file, and of course, do with them what you want :).
if you check the raw file here https://raw.githubusercontent.com/artsy/eigen/master/HACKS.md there is a comment on top that doesn't render on gh.
the goal with this file is to make it empty, right? but probably it will never be. we had and have things like a resolution in package.json of a dep of a dep hardcore's. that's cool, but after a year or so, do we need it? what should we check if it breaks when we remove it? when is it a good time to remove it?
so this file and comment is like: tell the rest of the team, what you did, when can we remove it, and why you did it. that way, every now and then we can check the file and try to remove things.
if you see the eigen file it had things like "we can remove once we remove enzyme" or "when that PR is merged" or "now". there are also not only patch-package, but things like EchoNew which was a Jacky but necessary way to fix a problem.
so yea, that was the idea behind it. basically what Chris says, I'm just adding a bit more background behind its introduction to eigen. :)

I like the idea but find the eigen file confusing. For some it looks like there is a future fix for a current hack being described, but it's not explained what the hack is. For others it seems like a troubleshooting guide. Maybe we could have more standard fields like what/why/how/future resolution, and a separate section if necessary for troubleshooting?

To take this to completion, I think for now we can keep things simple and more free-form, as Eigen does it. If we start adding many hacks and need to formalize some more, I suspect that might be indicative of a larger problem!

Copying the new formatting in Eigen, I've added a HACKS.md file to force here https://github.com/artsy/force/pull/7767 and updated README.md with a new Hacks meta section. If anyone has any feedback please respond over there!

Alright closing this with a status of general support 👍
Follow-up steps:

Ping code owners of our main repos with a link to Force / Eigen HACKS doc and file a ticket for a PR.

@damassi When you have a moment, it might be nice to update this thread with our RFC resolution template.

Resolution
Decided to try this out.
Level of Support
2: Positive feedback.
Next Steps
Ping primary repo owners with link to thread and template and ask to open PR with new file.
Exceptions
None


Expand functionality with machine learning

Hello, following up our previous discussion with @Min-Ho-Kim,
We have a tool for predicting bugs in software written in C/C++ with machine learning algorithms using metrics of source code. Our approach uses function-level and class-level metrics such as LoC, Halstead measures, Cyclomatic complexity, Measure of aggregation, etc. Decision trees, Logistic regression, SVM, Neural networks are used for defect prediction.
You already have a module for getting metrics [1], and we propose to expand it with our functionality.
If you are interested in it we can create a pull request.
Thank you.
[1] https://github.com/Samsung/Dexter/tree/master/project/dexter-metrics
cc: @arogozhnikov; @lucenticus

Welcome to Dexter! And thank you for your interest.
After reviewing your pull-request, we will decide whether merge or not.
Plus, I've read your document that explains the idea of 'Software Defect Prediction".
That was very similar our vision of Dexter.
Thanks again.


Ceasar Cipher

Decrypt function not working because it can't find the inverse_mod() function.  This will be fixed in v0.3.3

Added import math so that it could find the functions needed. ** will be added in v0.3.7**

the inverse_mod() function also needed to be fixed, this has been taken care of.


Weird assignment of furniture

It's a wooden stool.
Might be an incompatibility with [LTS]Furnishing as this was happening in a room with double doors that it adds and upon removing those doors while the texture stayed the same, I was able to unassign from room and move the stool.
There's no real error but this is the log for it:
https://gist.github.com/861cc5deae0b16252ae27eb74269c1fd

Actually the texture bug is completely unrelated to this mod. But I suppose the issue with LTS is still there.

Can you perhaps explain it in more detail? I dont really understand what the issue with LTS Furnishing is?

I'll test it again later today but basically LTS adds double doors in their own way (no Jecs) and this is a bench in the kitchen area that was linking to some natural rock wall on the other side of the map (I guess it ignores the door and since there was also no other doors or wall it linked to whatever) and clicking the buttons and even reassigning the stool to that room didn't let anyone move it.
When I replaced the double doors it worked as expected.

I see, well the mod just queries the vanilla room-method so there may be something needed on the LTS side to make the vanilla game recognoise the doors as room dividers.

It might actually just be this mod alone, because everything except the bed just point in the same direction.

I suppose it's the issue this person talked about couple years ago.


add verification function for invoice signatures

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#120  👈
#111
develop

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @matthappens and the rest of your teammates on  Graphite


[python] Update the python package to support python 3.13

What

Resolves: https://github.com/rerun-io/rerun/issues/6224

Also bumps our pixi arrow version to 18 since this is required for python 3.13 and I want it to get tested.
Bump our C++ arrow library to match.
Checklist

[x] I have read and agree to Contributor Guide and the Code of Conduct
[x] I've included a screenshot or gif (if applicable)
[ ] I have tested the web demo (if applicable):

Using examples from latest main build: rerun.io/viewer
Using full set of examples from nightly build: rerun.io/viewer

[x] The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
[x] If applicable, add a new check to the release checklist!
[x] If have noted any breaking changes to the log API in CHANGELOG.md and the migration guide

PR Build Summary
Recent benchmark results
Wasm size tracking

To run all checks from main, comment on the PR with @rerun-bot full-check.

@rerun-bot full-check


Add Detailed Metrics on Results

Those could include:

ContentLength ( in Bytes)
NumberOfSolutions ( = number of rows in result table)
NumberOfBindings ( = number of non-empty cells in result table )
NumberOfVariables ( = number of columns/column heads )

Example

x
y

1

2
1

3
1

NOV = 2
NOB = 5
NOS = 3

see SaxSparqlJsonResultCountingParser class


Request: support backreferences in relabel_config regex's

Proposal
In a relabel_config, the regex field supports any valid RE2 regular expression (docs). RE2 regexp's don't support backreferences:

RE2 disallows PCRE features that cannot be implemented efficiently using automata. (The most notable such feature is backreferences.) In return for giving up these difficult to implement (and often incorrectly used) features, RE2 can provably analyze the regular expressions or the automata.
https://swtch.com/~rsc/regexp/regexp3.html

Because these are not supported, my prometheus.yml is currently very verbose. I would like to request that prometheus use a different regexp library for parsing these regexes which supports backreferences, possibly behind a build-time or run-time flag to opt-in to using this alternate library. Would you be willing to look at such a PR?
Here is my use-case. I am using snmp-exporter to monitor a PDU with multiple outlets. Each outlet may be used to power a different server. In my http_sd_config (which I've simplified to a static_config in the example below for legibility), I know which port goes to which host, so I would like to provide a host label. Currently, this is the best way I've found to do that:
  - job_name: pdu-exporter
    metrics_path: /snmp
    static_configs:
      - targets: [ pdu01 ]
        labels:
          host_for_o8: compute0001
          host_for_o16: compute0002
          host_for_o24: compute0003
    relabel_configs:
      - source_labels: [__address__]
        target_label: instance
      - source_labels: [__address__]
        target_label: __param_target
      - target_label: __param_module
        replacement: mymodule
      - target_label: __address__
        replacement: 'snmp-exporter:9116'
    metric_relabel_configs:
      - { source_labels: [ outletId, host_for_o1 ], regex: "1;(.+)", target_label: host }
      - { source_labels: [ outletId, host_for_o2 ], regex: "2;(.+)", target_label: host }
...
      - { source_labels: [ outletId, host_for_o48 ], regex: "48;(.+)", target_label: host }
      - action: labeldrop
        regex: "host_for_o\\d+"

If backreferences were supported, here is one way I could collapse those 48 relabel_configs into a single one instead:
...
    static_configs:
      - targets: [ pdu01 ]
        labels: { outlets_to_ports: "8=compute0001,16=compute0002,24=compute0003" }
...
    metric_relabel_configs:
      - source_labels: [ outletId, outlet_to_ports ]
        regex: "(?P<outlet>\\d+);.*\\b(?P=outlet)=([a-z0-9]+)\\b.*"
        replacement: "$3"
        target_label: host
      - action: labeldrop
        regex: "outlet_to_ports"

This particular example is not terrifically painful since my workaround only requires 48 lines of generated code. But it is one real-world, concrete case where backreferences would be convenient. Perhaps others will chime in with their own use-cases for how PCRE features would be helpful.

Use case: SNMP exporter scraping interfaces: by using backreference, we would be able to use metrics_relabel functions that match ifname against a string listing all interfaces to monitor. Simpel regex to create (.+);.*\1+ for the source labels ifname and __interfaces_to_monitor.

I was also thinking something along the lines of...
# If prometheus.io/keep-regex is specified, use it to keep metrics
- source_labels: [__meta_kubernetes_pod_annotation_prometheus_io_keep_regex, __name__]
  separator: ";"
  regex: "(.*);\\1"
  action: keep

...although, I'm not sure if I'm thinking this right or if there is already an alternative for this.

Tried it but unfortunately no luck.  The (escaped) backreference is not accepted.
But indeed  the idea is to use a label (through a service discovery routine - in your case delivered by an annotation) that provides the filtering regex expression

I also need regex: "(.*);\\1" to filter endpoints.

I also need regex: "(.*);\\1" to filter endpoints.

I have the same usecase. Did you manage to find any alternatives for this

Hello from the bug scrub!
There are no plans to deviate from the Go regexp package. We are afraid you have to revert to work-arounds if you need regexp features that are not supported by the Go regexp library. You can discuss those via our community channels.


ipam pool leak fix

Reason for Change:
This is to address the potential for IPAM to leak IP's and have the pool be stuck in a 'in use ' state.
Issue Fixed:
https://github.com/Azure/azure-container-networking/issues/633
This also reintroduces some tests that were last in previous commits.
Requirements:

[x] uses conventional commit messages

[x] includes documentation
[x] adds unit tests

Notes:

I didnt see in releaseaddress id is reset to empty? how is it handled?

Discussed offline, it is already handled in the releaseaddress

Hi,
see the change for "ipam pool leak fix" has been merged for CNI issues.
Can you please confirm which aks version will include this fix? thanks
Ed


Remove interior mutability in the ConcurrentSlab

Currently the ConcurrentSlab has an RwLock. As we don't do any concurrent processing in the compiler we should remove interior mutability. When profiling, the compiler seems to be spending ~80% of it's time on atomic operations around this type. Removing this should lead to a significant performance boost.
pub(crate) struct ConcurrentSlab<T> {
    pub inner: RwLock<Inner<T>>,
}

pub fn insert(&self, value: T) -> usize {
    self.insert_arc(Arc::new(value))
}

This should be changed to remove the RwLock and methods that mutate state should take &mut self.
pub(crate) struct ConcurrentSlab<T> {
    pub inner: Inner<T>,
}

// change these methods to take &mut self
pub fn insert(&mut self, value: T) -> usize {
    self.insert_arc(Arc::new(value))
}

Awesome, I don't think we will have the scope to work on this anymore from toolings side. It seems like we should try and not store a reference to engines in the Type check context so we can pass around &mut Engines when things needs mutating.


Server hangs waiting on eula

I am using a docker-compose file with the current contents:
version: '3'

services:
  minecraft:
    build: .
    environment:
      MEMORY: 16G
      EULA: "TRUE"
      TYPE: CURSEFORGE
      CF_SERVER_MOD: ATM3R-1.4.9_Server-Full.zip
    ports:
      - my_ip:25595:25565
    volumes:
      - ./data:/data

Here are the output logs:
https://pastebin.com/MC6wtyL0
My /data folder contains these current files:
/home/minecraft/modded# ls data/
ATM3R-1.4.9_Server-Full.zip  config  eula.txt  FeedTheBeast  mods  plugins

Whenever I cat the eula.txt within /data/FeedTheBeast it always says eula=false which makes me think something is overriding the eula being created based off the env var.
Any guidance would be appreciated, cheers.

Very strange. It should copy it from the data/eula.txt copy of the file, so can you cat that file's content? Speaking of which, what should probably solve it is deleting data/eula.txt and letting the next container startup recreate the eula file from the environment variable
...however, I'm now wondering if FTB needs that to be literally eula=true or if it will allow eula=TRUE.

...however, I'm now wondering if FTB needs that to be literally eula=true or if it will allow eula=TRUE.
fwiw I have tried true too and the same occurs.

OK, I think a recent change (https://github.com/itzg/docker-minecraft-server/commit/34d4ae0b59cdc50660e4e980b565d3f8d2ad2d8b) may have caused this particular issue since it normalizes the EULA value to uppercase. I'll revert a small part of that or have it normalize to lowercase since that seems to be what both vanilla and forge agree on.

The fix to make EULA be lowercase is now on Docker Hub. Along with pulling that latest image you'll need to delete the eula.txt one more time to let it write the new value.

The fix to make EULA be lowercase is now on Docker Hub. Along with pulling that latest image you'll need to delete the eula.txt one more time to let it write the new value.

The fix worked! Thanks a lot :)

I think I may be experiencing this same issue - I've tried deleting the eula.txt file with no luck.
When I check the eula.txt file it shows that it's being set by Docker and is set to true.
Compose file:
services:
     mc:
       container_name: atm7
       image: itzg/minecraft-server:java8
       volumes:
         - ./modded-minecraft-data:/data
         - ./modpacks:/modpacks:ro
      environment:
       MEMORY: 8G
       EULA: "TRUE"
       MOTD: "Welcome to ByrdCraft!"
       SEED: "seed"
       tty: "true"
       stdin_open: "true"
       restart: unless-stopped
       ENABLE_ROLLING_LOGS: "true"
       TYPE: CURSEFORGE
       CF_SERVER_MOD: https://media.forgecdn.net/files/3614/956/SIMPLE-SERVER-FILES-0.2.34.zip
     ports:
       - "25565:25565"
  volumes:
    minecraft-data: {}

atm7  | [20:35:20] [INFO] Done installing loader, deleting installer!
atm7  | [20:35:20] [INFO] You have not accepted the eula yet.
atm7  | [20:35:20] [INFO] By typing TRUE you are indicating your agreement to the EULA of Mojang.
atm7  | [20:35:20] [INFO] Read it at https://account.mojang.com/documents/minecraft_eula before accepting it.

These are not log lines from my image's scripts, so the modpack is causing this

atm7  | [20:35:20] [INFO] Done installing loader, deleting installer!
atm7  | [20:35:20] [INFO] You have not accepted the eula yet.
atm7  | [20:35:20] [INFO] By typing TRUE you are indicating your agreement to the EULA of Mojang.
atm7  | [20:35:20] [INFO] Read it at https://account.mojang.com/documents/minecraft_eula before accepting it.

Try https://github.com/itzg/docker-minecraft-server#buggy-start-scripts


Configuring the list "catalogueEndpoints"

Hi,
is it possible to manually modify the list of "catalogueEndpoints" with a method provided in JavaScript (apart from src code) ?
Thanks.

Yes, you can modify YASGUI.defaults.catalogueEndpoints before initializing YASGUI . Or were you looking for something else?

No it's what I was looking for :+1:
So writing in JS "YASGUI.defaults.catalogueEndpoints = [....]" overides the yasgui.min.js" defaults right ?
And also I would like to disable the Edit state of the listbox (from Js / CSS) so it shows only one Endpoint that cannot be modified, is it ok to do so ?
Thanks.

I needed more info but you closed it before me :/
So my questions are in previous post...
Thanks.

Finally found, after some searching, your FULL doc API and so on :
https://gist.github.com/LaurensRietveld/3b490a52700628d16dfc0964518223aa
Why is it missing from Github, maybe adding it on the github wiki tab would be efficient...

Is there still support of YASGUI.defaults.catalogueEndpoints in the current version of Yasgui?


#2113 fix time zome handling incompatibility between Windows and Linux

Fixes several web app error pages and broken unit tests on Linux.
This will presumably fix the same issues for OS X but I'm unable to confirm.

Just pulled & tested this locally on Windows, good to go.
Thanks @nathanchere!


Add NHS-R logo to README

Don't worry about the CI fail - forgot to remove this after enabliing on all repos. Turned out I didn't need it after starting to use Github Actions.


⚠ Processors has degraded performance

In b17e7ff, Processors ($STATUS_URL) experienced degraded performance:

HTTP code: 200
Response time: 107 ms

Resolved: Processors performance has improved in e6c5c2d.


feat: update occt to 7.8.1

Checklist

[x] Used a personal fork of the feedstock to propose changes
[ ] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[ ] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[ ] Ensured the license file is being packaged.

@conda-forge-admin, please rerender

Anything blocking this?

Thanks @Michsior14


Gap on the "Add field" dropdown

When running iD embedded on Tasking Manager, there is a gap between the add field select position and the dropdown contents. it happens even without scrolling the page.

It also happens on other dropdowns

Looks like the vertical positioning code uses the client bounding rect, so it's offset by the height of your top toolbar. We should make it relative instead.


Add Python versions to setup.py classifiers.

This should let caniusepython3 detect that it’s Python-3-ready.

Coverage remained the same at 86.59% when pulling 38d44967eb412acfabb9ff8ca2d1a9ad40ce2f3d on kengruven:master into 8caf2d7c3fb3eba756322bd01def2c9f4ee37644 on un33k:master.


Register a new Schema

As a user I want to create a new schema.
Check in on #27 for schema + message format, but not blocking
Acceptance Criteria

[x] I should be able to call register_schema to register a [Thrift|Avro|TBD] schema
[x] The schema should be assigned unique schema_id (sequential, u16)
[ ] An active node should receive the event SchemaRegistered
[ ] Tests
[ ] Basic Benchmarks

Extrinsic: register_schema
Cost: MRC Token, one time fee
Parameters:

serialized_schema: The serialized thrift schema

Emits: SchemaRegistered: block_number, schema_id, serialized_schema
Assumptions

Zero length schemas are malformed and handled by future validation stories (#29 )
Maximum schema is determined by the maximum size of a block + it just costs more for larger schemas (byte length pricing on extrinsic parameters)

References

https://github.com/Liberty30/mrc/pull/17

seialized_schema is of type Vec and will be avro serialized type


Issue/2495 api helper resolve (#2855)

Pull request opened by the merge tool on behalf of #2855

Merged in 75d695d717a29a1f7136f8684380c7a858c7f9e1