Licensing issue with included library

Installing gaze installs a bunch of other packages, at least one of which has no license.
Here's an example:
gaze 0.5.1 requires globule ~0.1.0
globule ~0.1.0 requires glob ~3.1.21
glob 3.1.21 requires inherits 1
inherits 1.0.0 has just a README.md with no license specified, neither in the inherits.js file, nor in the README.md, nor in the package.json file.  The repo itself on github.com has no tag for 1.0.0 either.
This is a problem with an organization that's perhaps concerned about making sure everything is licensed properly.
In tracing this back, it seems that if glob-watcher were to require gaze 0.6.4, it may fix the problem.  At least inherits 2 would be required.

We won't be able to switch this in the 3.x branch of gulp, as it will be a breaking change.  If you are just looking for a library that watches glob, I highly suggest chokidar (which gulp will be switching to in 4.0)

Ok - unfortunately that makes glob-watcher (and it's ultimate dependent, gulp 3.x) off limits for me for a certain project I'm working on.  Maybe after the 4.0 release.
Thanks for the reply,
Matt

@mmucklo Why not open an issue on the inherits module or the glob module that depends on inherits? Not sure why we got brought into this. This can all be rectified by either glob or inherits publishing a patch release that corrects it, then gulp 3.x will get it

So inherits has a version 2 with a license.
glob 3.2.7 uses inherits 2
globule 0.2.0 uses glob 3.2.7
gaze 0.6.4 uses globule 0.2.0
Everyone else in the chain below glob-watcher has already upgraded.
glob-watcher has not.
This issue then makes gulp 3.x and it's dependency chain out of date as well since it (ultimately) depends on glob-watcher.

@mmucklo like @contra said, just have inherits publish a 1.0.1, which will automatically get picked up by our modules due to semver.  There's absolutely no reason we have to adopt breaking changes (major semver bump) to get a license update.

Okay just did, but, BTW gaze 0.6.4 vs 0.5.1 is only a minor semver bump.
I'm not sure if you directly use the inherits 1 pulled in by glob 3.1.x.
If you do I understand, but if not, then consider that the other packages are only minor semver bumps, not major ones.  Nevertheless if https://github.com/isaacs/inherits/issues/18 gets resolved, it's a moot issue.

@mmucklo gaze 0.6.x is horribly broken so we can't and won't update to that

So instead of fixing your dependency as initially requested, which probably would have been wiser for all of us involved, you asked me to contact the owner of inherits.
I did as I was asked, and per the request he published a 1.0.1.
However, you may want to have a look at https://github.com/isaacs/inherits/issues/18 to see how it was done.

@mmucklo Please enlighten me since we are all so dumb and you are so smart: which dependency should we have updated to correct this problem?

As much as I hate dealing with licensing issues, I'm however charged to have to deal with these things.  I'm sorry and I apologize for troubling you.
I'm probably at least as annoyed at having to deal with this as you all are in having to waste your time dealing with such an absurd issue as someone filing an issue over a lack of a license file included by a bundle that you seem to have no control over other than upgrade to a "horribly broken" version of gaze.
Therefore my last comment was in haste (not fully understanding the gaze issue), and presumed that something could be done, when in fact, as @contra's previous comment correctly points out, it's a real catch-22.  For that I also do apologize.
The only other possible solutions I see are to cut ties with gaze, push gaze to fix the 0.6.x branch, or assume gaze plus it's dependencies into your own code base and patch them yourself, all of which probably seem to be sub-optimal compared to a simple update of inherits 1.
That I troubled you at all was solely through tracing the dependency chain and finding all other bundles deeper than glob-watcher had updated, it just seemed to be glob-watcher that was holding inherits at 1, again not knowing that gaze 0.6.x was broken, which you have so enlightened me to the problem.
Anyway I will try to plead with the owner of inherits to see if a more workable solution to inherits 1 can be made.

@mmucklo We are already moving away from gaze in gulp 4.0 in favor of chokidar, but this is a breaking change and won't land in 3.x so it won't solve your problem.

According to my tests and notes https://github.com/isaacs/inherits/issues/18 - this is now resolved


notebook script for plotting

Shawn,
I add a ipynb script to plot ELM output for any variable. When open it in notebook, user can customize what variable to chose, its unit and scalor for plotting, and year range. If need to know variable name, user can print all variable names.
But I don't know if you'd like this way or not.
Fengming

Looks good. I think I will do a little more cleanup too.
I would like to come up with a few example analyses we can provide as illustrations.  e.g. how would you look over ELM output to diagnose a simulation and understand what you are seeing?
I also plan to come up with an initial example showing a data comparison.  I was exploring the portal but need to find a very simple dataset to start with

I would leave this fork for a while until you pull what you think good enough.
AND, I just write wiki on how to run the notebook in docker, see the link: https://github.com/fmyuan/fasst_simulation_tools/wiki
For this to work, I temporarily built a docker image and upload to my hub repository - after you put the final into yours, I will have tests with yours.

I had already created this: https://github.com/FASSt-simulation/fasst_simulation_tools/wiki. We can add to this set of instructions
Specifically was plannign to have several ddifferent examples starting from this page.  The point was to give folks exampels of different ways to create plots, running python scripts or running Jupyter etc https://github.com/FASSt-simulation/fasst_simulation_tools/wiki/Analyzing-ELM-Output-in-Jupyter-Lab

So looks like you're OK for me to put those instructions onto your wiki page, I will move all from the forked repo.

Perhaps - I am wondering if we should first create a single finished example then create the instructions for that one first so we have a template?  or maybe thats what you already have?

I am also trying to reduce the image size for the jupyter stack now and re-test

Yes, those instructions are based on what I have finished. More is coming by the other notebook script.

Already moved and updated wiki page,


ImGui Support

There are some Sokol examples to be ported that use ImGui.
Since only build.zig is available, zig-pkg will be used to download D packages.
https://github.com/kassane/sokol-d/blob/43d371b48e0a2ca951aa44234be8a9cbe9179e6b/build.zig.zon#L4-L10
D binding

https://github.com/BindBC/bindbc-imgui
https://github.com/BindBC/bindbc-imgui/issues/2

References

https://github.com/floooh/sokol-zig/issues/29
https://github.com/floooh/sokol-rust/issues/19
https://github.com/floooh/sokol/blob/master/util/sokol_imgui.h

Imgui support in the bindings is currently a bit messy. sokol_imgui.h currently isn't included in the "original" bindings (Zig, Nim, Odin), but was only added by the contributed Rust bindings (but went stale there).
One reason (which tbh doesn't make a lot of sense) was that I didn't want to have any sort of external dependency in the bindings, e.g. there couldn't be an imgui example (such an example would need to live in a separate repo). But this also means that any problems in the sokol_imgui.h bindings wouldn't be caught by running the tests (since those just compile the included samples).
I guess it does make sense to include sokol_imgui.h in all bindings, even without an integrated sample.
Just some sort of braindump from my side ;)

After rebasing the project with wasm support and some fixes.
The ImGui library built by zig gives an error about not having found 'assert.h' which is only needed by ImGui.
I also tried to use IM_ASSERT macro define to replace C assert, but it gives several errors in the API.
I don't know how this custom assert works since I haven't seen it in any examples.
install
+- emcc
   +- mrt
      +- zig build-lib sokol ReleaseSmall wasm32-emscripten
         +- zig build-lib cimgui ReleaseSmall wasm32-emscripten 6 errors
/home/runner/.cache/zig/p/12202af0db41b79a4c7904950269b5e33b7d48f50aae042e334cb8d717a5a2caf48d/imgui.h:84:10: error: 'assert.h' file not found
/home/runner/.cache/zig/p/1220e6183fb9559dbfafe58d7fab20f1c330bee32342205815aa10553134ff9f9302/cimgui.cpp:13:10: note: in file included from /home/runner/.cache/zig/p/1220e6183fb9559dbfafe58d7fab20f1c330bee32342205815aa10553134ff9f9302/cimgui.cpp:13:
/home/runner/.cache/zig/p/12202af0db41b79a4c7904950269b5e33b7d48f50aae042e334cb8d717a5a2caf48d/imgui.h:84:10: error: 'assert.h' file not found
/home/runner/.cache/zig/p/12202af0db41b79a4c7904950269b5e33b7d48f50aae042e334cb8d717a5a2caf48d/imgui_demo.cpp:96:10: note: in file included from /home/runner/.cache/zig/p/12202af0db41b79a4c7904950269b5e33b7d48f50aae042e334cb8d717a5a2caf48d/imgui_demo.cpp:96:
/home/runner/.cache/zig/p/12202af0db41b79a4c7904950269b5e33b7d48f50aae042e334cb8d717a5a2caf48d/imgui.h:84:10: error: 'assert.h' file not found
/home/runner/.cache/zig/p/12202af0db41b79a4c7904950269b5e33b7d48f50aae042e334cb8d717a5a2caf48d/imgui_draw.cpp:33:10: note: in file included from /home/runner/.cache/zig/p/12202af0db41b79a4c7904950269b5e33b7d48f50aae042e334cb8d717a5a2caf48d/imgui_draw.cpp:33:
[...]

updated branch e new issue detected on imgui:
 zig build run-imgui
/home/kassane/sokol-d/src/examples/imgui.d(25,14): `state` is thread local
imgui: /home/kassane/.cache/zig/p/12202af0db41b79a4c7904950269b5e33b7d48f50aae042e334cb8d717a5a2caf48d/imgui.cpp:9526: void ImGui::ErrorCheckNewFrameSanityChecks(): Assertion `(g.FrameCount == 0 || g.FrameCountEnded == g.FrameCount) && "Forgot to call Render() or EndFrame() at the end of the previous frame?"' failed.
run-imgui
└─ run /home/kassane/sokol-d/zig-out/bin/imgui failure

Btw, I tinkered a bit with imgui-support in the Rust bindings:
https://github.com/floooh/sokol/commit/b728ee66d1d8a83247bdde75aacb299aee294475
Note how I'm adding the sokol_imgui.h header only to the Rust bindings generation.
I ignored the simgui_add_key_event function because the function signature is not yet supported by the bindings generator and it's a fairly esoteric function.
I also had to remove the sokol_gfx_imgui.h bindings, because this has a union in the public API, which isn't supported either.
Ultimately I didn't get it working, because the Rust imgui bindings (imgui_sys) are stuck on an older ImGui version than the sokol_imgui.h header doesn't support anymore.
I'm now also slowly seeing the light at the end of the rabbit hole I'm currently in (https://github.com/floooh/sokol/pull/985) after that hopefully have a bit of time for looking into the bindings before the next 'big thing' (storage buffers).

Btw 2: I have removed the imgui-stuff in the Rust bindings for now. There was a cimgui git submodule in the examples which caused trouble in the GH Actions jobs (artifacts with git submodules included fail to download in a Windows job). I didn't feel like investigating this and delay the render-pass-cleanup merge. If we add sokol_imgui.h bindings and examples we should do it in a way that works for all bindings.

WiP - some fixes

The ImGui library built by zig gives an error about not having found 'assert.h' which is only needed by ImGui.

Which cflag/cdefine solves assert.h in wasm?

new commit: https://github.com/kassane/sokol-d/commit/9198de3ea7ad7cb35f1674619eac9708e11be6dd broken imgui branch

see:

https://github.com/floooh/sokol-zig/pull/69

Btw the tricky part is to inject a cimgui header search path into the sokol C libary build (without adding a dependency to cimgui/Dear ImGui to the sokol-zig package. So the other important half is here in the example project:
https://github.com/floooh/sokol-zig-imgui-sample/blob/main/build.zig

Btw the tricky part is to inject a cimgui header search path into the sokol C libary build without adding a dependency to cimgui/Dear ImGui to the sokol-zig package. So the other important half is here in the example project:
https://github.com/floooh/sokol-zig-imgui-sample/blob/main/build.zig

I see. However, the writefiles stepwait breaks my build.
I tried adapting buildimgui and later copying its configuration and still got the same step error.

How to skip IMGUI assert on wasm target?
/home/kassane/.cache/zig/p/122072b125179c7cbdbbee8fa81d22a1050a950ad61cfeefee8dc0dca5423b5d05b9/imgui.h:88:10: error: 'assert.h' file not found
#include <assert.h>
         ^~~~~~~~~~~
/home/kassane/.cache/zig/p/122072b125179c7cbdbbee8fa81d22a1050a950ad61cfeefee8dc0dca5423b5d05b9/imgui_tables.cpp:198:10: note: in file included from /home/kassane/.cache/zig/p/122072b125179c7cbdbbee8fa81d22a1050a950ad61cfeefee8dc0dca5423b5d05b9/imgui_tables.cpp:198:
#include "imgui.h"


No output when request body is invalid

Hey there, this is a great library and I'm excited to use it.  I created a PUT route, and when I tested with invalid data, I didn't get any output from my curl command.  It gives a 400, but I would expect to receive validation error information along with it.
Indeed, the validation error comes up in the console, but I need it to be part of the response.  Validation error:
[
  {
    code: 'invalid_type',
    expected: 'string',
    received: 'undefined',
    path: [ 'name' ],
    message: 'Required'
  }
]

Simplified example:
import defineRoute from "@omer-x/next-openapi-route-handler";
import z from "zod";

export const { PUT } = defineRoute({
  operationId: "putThing",
  method: "PUT",
  summary: "Create a new thing",
  description: "Create a new thing with the given details",
  tags: ["Things"],
  requestBody: z.object({
    name: z.string(),
  }),
  action: async () => {
    return Response.json({ id: "123" });
  },
  responses: {
    200: {
      description: "Thing retrieved successfully",
      content: z.object({
        id: z.string(),
      }),
    },
  },
});

Also, when the route fails, I get a 500 but the error is not displayed in the console.  If I use a vanilla nextjs route, the error shows up.

Hey! Thanks for feedback. I'll look into it today.

I made some changes in #5 but I'm not sure if it's a good starting point. I didn't need something like this before, because HTTP error codes were enough for me. Could you give more feedback about how can we improve this?

Hey Omer, thanks for replying and for putting in that effort.  You are awesome.
I took a deeper look at the code and have a better idea how it works now.  A few suggestions:

I don't think you should wrap the user code in a try/catch.  I suggest pulling this line out of that try/catch.  That should solve the issue with 500 errors not showing up in the console.
In the end, it looks like you are using zod's safeParse, which doesn't throw.  But that itself has been wrapped in a function that does throw.  Then that error gets handled in definer.ts.  It makes it a little hard to follow.  Maybe instead, have parsePathParams, parseSearchParams, and parseBody use safeParse directly and if it fails, return a 400.  Also consider 422, which I've generally used for invalid request bodies.
Consider adding custom functions to RouteOptions for overriding parsePathParams, parseSearchParams, parseBody.  This way you can have a sensible default but people can customize it to their liking.

Happy to help with implementation if you'd like

Thanks for your kind words, Steve.
As it is a known issue that error handling (especially with try-catch) in JavaScript has always been a bit problematic. But the reason of why I decided to wrap the route handler with a try-catch and return some generic responses (400, 404, 500) was because I wanted to keep the code as simple as possible in action part of the definer.
I believe 500 (Internal Server Error) means the code doesn't work as expected, probably because of some untested code or database problems which is not the FE dev's concern IMO. In action function, the BE dev can wrap the code with their own try-catch to see what is wrong before it's caught by the library's error handler and can fix it. That's what I do.
But I agree that there should be some customization options with error handling. There might be some edge cases where my solution isn't sufficient. So I’ll look into how can I implement custom error handling within this week.
Thanks for sparing your valuable time.

Hello again @StevePotter,
As you mentioned in #5 it would be confusing to see something called zodIssues for a non-JS developer. So today, I tried to give more detail about zodIssues in the generated openapi specs. However, I noticed it would make 6 kB addition to the generated specs per each defined route in the app when I reflected the ZodIssues type to the specs. I could fix that with json-generator but I doubted if it would be worth the effort. So I decided to ditch that idea and started focusing on custom error handler feature. I'm satisfied with the result for myself and would like to hear your opinion too. Let me know if you think this is enough to close this issue.

Nice work.  Good luck with this project.  I wish nextjs didn't require so much effort to enable this type of thing.  Those of us not looking to immediately set up both a frontend and backend server would really benefit from native support.  Grateful for your effort and doing something about it


NaN error false positive when attempting to set a persistent variable to any string that starts with the letter e

Put the following code into a layer (and include the gameState variable in the layer return object):
const gameState = persistent<string>("");

globalBus.on("onLoad", () => {
    gameState.value = "ended" // or any string that starts with the letter "e"
})

Expected behavior: The gameState.value is correctly set to the string "ended"
Actual behavior: The game falsely throws an Error: Attempted to save NaN value to gameState or something similar

That's working as intended. Persistent has a second param for whether it should nan check or not


printf family functions don't format System.Decimal precision correctly

printfn "%.3f %.3f %.3M" 1.2345678 1.2345678f 1.2345678M

Expected: 1.235 1.235 1.235
Actual: 1.235 1.235 1.2345678

...but, possibly surprisingly, "f" also type-checks for Decimal, so
printfn "%.3f %.3f %.3f" 1.2345678 1.2345678f 1.2345678M

works "as expected" (kinda)

Looks fixable than

// %M ignores precision
On the culprit line, It appears that this is intended behavior.

AFAIR this was the behavior in original printf implementation and I've preserved it during rewrite.

I'm closing this as by design - it's always been this way and the behavior should just be documented.


github_webhook: Fix a typo to handle issues event properly

issue ->
issues

Automated message from Dropbox CLA bot
@okkez, it looks like you've already signed the Dropbox CLA. Thanks!

Yes, I've signed Dropbox CLA.

@eeshangarg can you review this one?
Also, @okkez do you know why the tests are failing?

@timabbott I've pushed a change to fix test. But I'm not familiar with Python and Zulip, so I could not run tests on my local machine.

could you maybe squash the two commits?

Squashed commits.
I will try set up development environment next time.
Thank you!

@okkez: Thanks a lot! @timabbott: I think we should merge this now! :)

Merged, thanks @okkez!!


Sign Up doesnt work properly

The Sign up looks broken. I'm unable to sign in after signing up.

@varun-mach  this issue is fixed.Please refer #186


Add AWS Secret manager integration to Container Definition

This PR enables a Elastic Profile agent configuration to integrate with the AWS Secrets Manager by adding three new fields to the profile template:

Secret name:  The environment variable where the Secret value will be assigned to and accesible from the ECS task
Secret value (valueFrom): The secret to expose to the container. The supported values are either the full ARN of the AWS Secrets Manager secret or the full ARN of the parameter in the AWS Systems Manager Parameter Store.
Execution Role  ARN: The Amazon Resource Name (ARN) of the task execution role that grants the Amazon ECS container agent permission to make AWS API calls on your behalf.

If all these variables are set and not blank, the following JSON key is added to the ContainerDefinition:
{   "containerDefinitions": [{     "secrets": [{       "name": "environment_variable_name",       "valueFrom": "arn:aws:secretsmanager:region:aws_account_id:secret:secret_name-AbCdEf"     }]   }] }
So far only the "referencing a full secret" use case is implemented as described in https://docs.aws.amazon.com/AmazonECS/latest/developerguide/specifying-sensitive-data-secrets.html. Some work still needed to support other use cases such as referencing a specific key within a secret.
Tested successfully on a real production GoCD environment.

Any plans to merge this PR or is that already supported on most recent versions?

Unfortunately there are few folks in a position to review PRs right now, or in a position to test/validate them and make a call on whether they make sense for the plugins.
Personally, I'm not quite sure what the role of this is, compared to https://github.com/gocd/gocd-aws-based-secrets-plugin - what does this allow you to achieve which you can't do by allowing the GoCD server to retrieve secrets and distribute them to relevant build jobs running on an agent on your behalf? Is it just an alternative which doesn't involve the server needing direct access to secrets?


try using default config as well

The current version only tries to open config.sh, resulting in an error message when started with the default config. My patch keeps looking for config.sh first, but if it doesn't exist, it tries default-config.sh as well.

I force pushed because of the commit message change. I also corrected the indentation, I'll deal with the overriding thing in a separate commit.

Thanks. Force pushing on PR branches is expected and really the only way to manage them properly (at least according to me).
This looks good to me now. Do you want to add the overriding to this PR or shall I merge it?

I'll do the overriding later in a separate PR, this change preserves past behaviour when there is a config, and fixes things well enough for newcomers so that it works with the default config.


CNDB-9974: Fix tests for CASSANDRA-18252 - removal of scripted UDFs

The ticket also fixes STAR-1886. Backporting CASSANDRA-17190 required also CASSANDRA-17383.
DRAFT as it needs manual submit of CI  tests pre-commit, working on that (PR gate CI run will fail as it will run CI with ds-trunk)
This patch needs to be committed together with the corresponding datastax/cassandra fix for CNDB-9974.
The order of commit needs to be (so CI can run without failing many tests):

DTest patch
cassandra patch

Failures already exist on main, mostly about fail() and skip() method not using the msg anymore. Probably an easy fix for another issue. Not a regression here.
https://jenkins-stargazer.aws.dsinternal.org/view/cc-builds/job/ds-cassandra-build/lastSuccessfulBuild/#showFailuresLink

The PR was approved, but I noticed that a bunch of Python DTests consistently fail for a low-hanging fruit reason, which can be quickly solved, so it does not cover real problems from tests - more in CNDB-10152.
Testing this one with the fix from CNDB-10152 here:
https://jenkins-stargazer.aws.dsinternal.org/view/cc-builds/job/ds-cassandra-build/729/

After applying the fix from CNDB-10152 and the fixes here for datastax/cassandra and datastax/cassandra-dtest, nothing related to scripted UDFs or new failures popped up. Committing this one and then datastax/cassandra


Build with custom certificate bundle fails due to missing parameter for gen_crt_bundle.py

Using IDF 5.0 and esp-idf-sys v0.32.1
I'm trying to connect to AWS IoT. AWS is using mutual TLS authentication. I don't want the full certificate bundle as it increases the size of my already large image - need only the Amazon CA. I'm attaching the Amazon Root CA as custom certificate bundle. I've verified that this approach works for C based IDF projects.
sdkconfig.defaults:
# Certificate Bundle
CONFIG_MBEDTLS_CERTIFICATE_BUNDLE=y
CONFIG_MBEDTLS_CERTIFICATE_BUNDLE_DEFAULT_NONE=y
CONFIG_MBEDTLS_CUSTOM_CERTIFICATE_BUNDLE=y
CONFIG_MBEDTLS_CUSTOM_CERTIFICATE_BUNDLE_PATH="../esp-aws-iot/cert"
Unfortunately it looks like that this build step fails as the specified path parameter is not provided to gen_crt_[bundle.py](http://bundle.py/)

Building the solution creates the following error. The build process doesn't provide the path to the cert directory to the gen_crt_bundle.py tool.
  [1/197] Generating x509_crt_bundle
  FAILED: esp-idf/mbedtls/x509_crt_bundle
  cd /home/michael/src/embedded-rust/esp-aws-iot/target/riscv32imc-esp-espidf/debug/build/esp-idf-sys-f9a37df0dfb0796b/out/build/esp-idf/mbedtls && /home/michael/.espressif/python_env/idf5.0_py3.10_env/bin/python /home/michael/.espressif/esp-idf-ae062fbba3ded0aa/release-v5.0/components/mbedtls/esp_crt_bundle/gen_crt_bundle.py --input -q
  usage: gen_crt_bundle.py [-h] [--quiet] --input INPUT [INPUT ...]
                           [--filter FILTER]
  gen_crt_bundle.py: error: argument --input/-i: expected at least one argument
  [2/197] Performing build step for 'bootloader'
  [0/1] Re-running CMake...

Paths in the sdkconfig/sdkconfig.defaults are a bit special, since the esp-idf is built as a dummy project in a separate folder. It should be relative to the target/<target-triple>/<build profile>/build/esp-idf-sys-<hash>/out folder because all settings from the sdkconfig/sdkconfig.defaults are merged into the target/<target-triple>/<build profile>/build/esp-idf-sys-<hash>/out/sdkconfig file.

Thanks, but I don't think so - the error message doesn't list an invalid path / file not found, but it complains that no argument is given for --input/-i

That is probably because of
        get_filename_component(custom_bundle_path
                        ${CONFIG_MBEDTLS_CUSTOM_CERTIFICATE_BUNDLE_PATH} ABSOLUTE BASE_DIR "${project_dir}")
        list(APPEND crt_paths ${custom_bundle_path})

        ...

        list(APPEND args --input ${crt_paths} -q)

custom_bundle_path ends up empty because the path doesn't exist, so crt_paths is also empty, and the script is called with just the --input argument.
I do agree that this looks like a file-not-found error, although sorry about the bad diagnostics in this case!

okay that makes sense - thanks @igrr and @N3xed. I will as soon as I'm able to build esp-idf-sys which is currently broken for esp-idf v5 due to a branch name change in esp-idf ...

Thanks that was the solution - path relative to target/...


Symfony 5.2.8

Coverage remained the same at 96.273% when pulling 15cac046c4df8fb3d68eb601f507404bb0c1fcc5 on symfony-5.2.8 into 690e06f23e0d5d76915e006507097a0b52da0626 on master.


incorrect generated code for local shadowing parameter

From @jmesserly on January 11, 2016 22:11
This doesn't work in Chrome 47:
foo(a) {
  var a = 123;
  return a;
}
main() {
  print(foo(42));
}

Generates as:
  // ... module boilerplate ...
  'use strict';
  let dartx = dart.dartx;
  function foo(a) {
    let a = 123;
    return a;
  }
  dart.fn(foo);
  function main() {
    core.print(foo(42));
  }
  dart.fn(main);

Error will be something like:
> (function() { 'use strict'; return (a) => { let a = 123; return a; }; })()
VM399:2 Uncaught SyntaxError: Identifier 'a' has already been declared(…)

Seems to be same error with function or =>
I'll have to see what our compiler thinks is happening, but possibly this is just a fix in the JS renamer, to understand that JS treats locals and parameters as the same scope. (But Dart does not, therefore they should be two distinct JS temp variables in the JS AST we construct. The renamer should understand that renaming is necessary in this case to preserve semantics.)
Thanks to @jacob314 for catching this in Angular2.
Copied from original issue: dart-archive/dev_compiler#409

It looks like our Dart->JS transpile generates:
  JS.Expression visitSimpleIdentifier(SimpleIdentifier node) {
    // <snip lots of cases that don't apply>
    return new JS.Identifier(name);
  }

The renamer isn't allowed to rename a JS.Identifier even if it wanted to.
Usually this is fine because ES6 block scope is pretty close to Dart's, but we'll have to do something about that difference between parameters and the top level of the function body.

probably the fix here is to add a new scope to reflect the Dart scope structure (rather than rename the variables)

i just hit that bug and it prevented me to use ddc althought dartium and dart2js worked fine

https://codereview.chromium.org/2961863003


Update autopilot-reset.md

Changed the Windows key logo to text, the logo doesn't show up in search previews causing CTRL++R to show up there
ex. search for 'Trigger local Windows Autopilot Reset' on Bing

(By the way, the same issue is true for translated pages, like German: STRG + + R


Determine and Setup Packaging Org

Talking about having this be a Managed Package versus unmanaged. Managed package would still have code accessible on Github, so it would still be Open.  Managed would be mindful of Education space should users have limited licenses and managed packaged don't count again those limits.
Need to lock down the Options section that control the front end registration page.  These are all Picklist Values.  Don't want to give the user the thought that they can change the values and functionality will still work.

Packing Org created and setup.  Currently Thad Dahlberg has the only login.
Will need to adjust User for multiple user access, but this is complete.


        S:/goProject/cimgui-go/type_accessor.go:98 +0x34
github.com/AllenDang/cimgui-go.FontGlyphRangesBuilder.BuildRanges({{0x2a958c4df90?, 0x7ff682e44a0a?, 0x2a958d52eb0?}}, 0xc0000afed0?)
        S:/goProject/cimgui-go/type_accessor.go:98 +0x48
poehelper/fonts.AppendDefaultFont(0x2a958d4a9a8?)
        S:/goProject/PoEHelper/fonts/Font.go:44 +0x8e
main.main()
        S:/goProject/PoEHelper/main.go:79 +0x21f
exit status 2
make: *** [Makefile:9: run] Error 1

related to #184 as well as with #90. Need to wait for GO PR to fix this.

Just to explain: mentioned code comes from utils.go so it isn't auto-generated, ergo #198 didn't apply to them

well, It looks like something else...
Its about Vector[*uint32] need to investigate

After looking at dlv output I still suppose that it is caused by lack of runtime.Pinner in our code. Need to wait for GO PR.

@Wolf65 patch #208 should fix this, however I need to do something around go version so gonna merge it tomorrow

on go 1.21.1
Exception 0xc0000005 0x0 0xc0001c8000 0x7ff7fcc4ec10
PC=0x7ff7fcc4ec10
signal arrived during external code execution

runtime.cgocall(0x7ff7fcb915b0, 0xc000139db8)
        C:/Program Files/Go/src/runtime/cgocall.go:157 +0x3e fp=0xc000139d90 sp=0xc000139d58 pc=0x7ff7fc8c545e
github.com/AllenDang/cimgui-go._Cfunc_ImFontGlyphRangesBuilder_BuildRanges(0xc00010a760, 0x23c4601f9b0)
        _cgo_gotypes.go:5430 +0x4d fp=0xc000139db8 sp=0xc000139d90 pc=0x7ff7fc9aa06d
github.com/AllenDang/cimgui-go.FontGlyphRangesBuilder.BuildRanges.func1(0x7ff7fc9aed46?, 0x7ff7fd2d6d00?)
        S:/goProject/cimgui-go/type_accessor.go:98 +0x5d fp=0xc000139df8 sp=0xc000139db8 pc=0x7ff7fc9b3d5d
github.com/AllenDang/cimgui-go.FontGlyphRangesBuilder.BuildRanges({{0x23c4601f9b0?, 0x7ff7fc8c545e?, 0x23c7158adb0?, 0xc00010c110?}}, 0x7ff7fc8c5505?)
        S:/goProject/cimgui-go/type_accessor.go:98 +0x45 fp=0xc000139e40 sp=0xc000139df8 pc=0x7ff7fc9b3c85
poehelper/fonts.AppendDefaultFont(0x23c71582658?)
        S:/goProject/PoEHelper/fonts/Font.go:44 +0xb0 fp=0xc000139ec8 sp=0xc000139e40 pc=0x7ff7fca17e10
main.main()
        S:/goProject/PoEHelper/main.go:80 +0x23f fp=0xc000139f40 sp=0xc000139ec8 pc=0x7ff7fcb546bf
runtime.main()
        C:/Program Files/Go/src/runtime/proc.go:267 +0x2b2 fp=0xc000139fe0 sp=0xc000139f40 pc=0x7ff7fc8fbbd2
runtime.goexit()
        C:/Program Files/Go/src/runtime/asm_amd64.s:1650 +0x1 fp=0xc000139fe8 sp=0xc000139fe0 pc=0x7ff7fc928e61

goroutine 2 [force gc (idle)]:
runtime.gopark(0x0?, 0x0?, 0x0?, 0x0?, 0x0?)
        C:/Program Files/Go/src/runtime/proc.go:398 +0xce fp=0xc00006bfa8 sp=0xc00006bf88 pc=0x7ff7fc8fbfee
runtime.goparkunlock(...)
        C:/Program Files/Go/src/runtime/proc.go:404
runtime.forcegchelper()
        C:/Program Files/Go/src/runtime/proc.go:322 +0xb8 fp=0xc00006bfe0 sp=0xc00006bfa8 pc=0x7ff7fc8fbe78
runtime.goexit()
        C:/Program Files/Go/src/runtime/asm_amd64.s:1650 +0x1 fp=0xc00006bfe8 sp=0xc00006bfe0 pc=0x7ff7fc928e61
created by runtime.init.6 in goroutine 1
        C:/Program Files/Go/src/runtime/proc.go:310 +0x1a

goroutine 3 [GC sweep wait]:
runtime.gopark(0x0?, 0x0?, 0x0?, 0x0?, 0x0?)
        C:/Program Files/Go/src/runtime/proc.go:398 +0xce fp=0xc00006df78 sp=0xc00006df58 pc=0x7ff7fc8fbfee
runtime.goparkunlock(...)
        C:/Program Files/Go/src/runtime/proc.go:404
runtime.bgsweep(0x0?)
        C:/Program Files/Go/src/runtime/mgcsweep.go:280 +0x94 fp=0xc00006dfc8 sp=0xc00006df78 pc=0x7ff7fc8e5934
runtime.gcenable.func1()
        C:/Program Files/Go/src/runtime/mgc.go:200 +0x25 fp=0xc00006dfe0 sp=0xc00006dfc8 pc=0x7ff7fc8daca5
runtime.goexit()
        C:/Program Files/Go/src/runtime/asm_amd64.s:1650 +0x1 fp=0xc00006dfe8 sp=0xc00006dfe0 pc=0x7ff7fc928e61
created by runtime.gcenable in goroutine 1
        C:/Program Files/Go/src/runtime/mgc.go:200 +0x66

goroutine 4 [GC scavenge wait]:
runtime.gopark(0xc000012150?, 0x7ff7fd07d238?, 0x1?, 0x0?, 0xc000068b60?)
        C:/Program Files/Go/src/runtime/proc.go:398 +0xce fp=0xc00007df70 sp=0xc00007df50 pc=0x7ff7fc8fbfee
runtime.goparkunlock(...)
        C:/Program Files/Go/src/runtime/proc.go:404
runtime.(*scavengerState).park(0x7ff7fd2d6540)
        C:/Program Files/Go/src/runtime/mgcscavenge.go:425 +0x49 fp=0xc00007dfa0 sp=0xc00007df70 pc=0x7ff7fc8e31e9
runtime.bgscavenge(0x0?)
        C:/Program Files/Go/src/runtime/mgcscavenge.go:653 +0x3c fp=0xc00007dfc8 sp=0xc00007dfa0 pc=0x7ff7fc8e377c
runtime.gcenable.func2()
        C:/Program Files/Go/src/runtime/mgc.go:201 +0x25 fp=0xc00007dfe0 sp=0xc00007dfc8 pc=0x7ff7fc8dac45
runtime.goexit()
        C:/Program Files/Go/src/runtime/asm_amd64.s:1650 +0x1 fp=0xc00007dfe8 sp=0xc00007dfe0 pc=0x7ff7fc928e61
created by runtime.gcenable in goroutine 1
        C:/Program Files/Go/src/runtime/mgc.go:201 +0xa5

goroutine 18 [finalizer wait]:
runtime.gopark(0x7ff7fcfef260?, 0x1fc8fcf01?, 0x0?, 0x0?, 0x7ff7fc904365?)
         It's strange...

@Wolf65 could you post some testing code? I checked on current giu migration pr and it worked

https://github.com/Wolf65/Bug
While I was building the example, another commit was released and the error changed and another one appeared. I hope I explained it clearly in the main comments.

I hope I explained it clearly in the main comments.

I was to lazy to construct my own code if I know that you have one for sure :smile: Sorry ;-)
In case of your bug...
I dont know why it doesn't work on windows... On linux I'm getting (instead of your panic) the following, clear output:
File: /home/runner/work/cimgui-go/cimgui-go/cimgui/imgui/imgui_draw.cpp, Line: 2208

so
        IM_ASSERT_USER_ERROR(0, "Could not load font file!");

so the following makes it working for me
diff --git a/main.go b/main.go
index 91d760b..61f00a5 100644
--- a/main.go
+++ b/main.go
@@ -25,13 +25,13 @@ func main() {
 	baseBuilder.AddRanges(io.Fonts().GlyphRangesCyrillic())
 	baseBuilder.BuildRanges(baseRange)

-	io.Fonts().AddFontFromFileTTFV("fonts/ttf/JetBrainsMono-Medium.ttf",
+	io.Fonts().AddFontFromFileTTFV("JetBrainsMono-Medium.ttf",
 		baseFontSize,
 		&baseConfig,
 		baseRange.Data())

About the path to the font. since it's a piece of code from the main project, I forgot to fix the path to the font. Sorry.
About the fall with panic. It may have fixed itself. I couldn't get it to repeat itself.
What about the code that's commented out below?
Which crashes with
main.go:49:3: cannot use imgui.SliceToPtr(IconRange) (value of type *uint16) as *imgui.Wchar value in argument to io.Fonts().AddFontFromFileTTFV

        //IconRange := []uint16{uint16(IconsFontAwesome6.Min), uint16(IconsFontAwesome6.Max16), 0}
This should be list of Wchars (which is uint32 probably)

@Wolf65
diff --git a/main.go b/main.go
index 91d760b..f44f95c 100644
--- a/main.go
+++ b/main.go
@@ -1,6 +1,8 @@
 package main

 import (
+	"fmt"
+
 	imgui "github.com/AllenDang/cimgui-go"
 )

@@ -25,13 +27,13 @@ func main() {
 	baseBuilder.AddRanges(io.Fonts().GlyphRangesCyrillic())
 	baseBuilder.BuildRanges(baseRange)

-	io.Fonts().AddFontFromFileTTFV("fonts/ttf/JetBrainsMono-Medium.ttf",
+	io.Fonts().AddFontFromFileTTFV("JetBrainsMono-Medium.ttf",
 		baseFontSize,
 		&baseConfig,
 		baseRange.Data())

-	//File: D:/a/cimgui-go/cimgui-go/cimgui/imgui/imgui_draw.cpp, Line: 2208
-	//exit status 1
+	// File: D:/a/cimgui-go/cimgui-go/cimgui/imgui/imgui_draw.cpp, Line: 2208
+	// exit status 1

 	// FontAwesome
 	fontAwesomeConfig := *imgui.NewFontConfig()
@@ -42,12 +44,12 @@ func main() {
 	fontAwesomeConfig.SetGlyphOffset(imgui.Vec2{X: 0, Y: 2})

 	////Whoa, I caught a bug while I was doing the test. If you uncomment the code below
-	//IconRange := []uint16{uint16(IconsFontAwesome6.Min), uint16(IconsFontAwesome6.Max16), 0}
-	//io.Fonts().AddFontFromFileTTFV(fmt.Sprintf("fonts/ttf/%s",
-	//	IconsFontAwesome6.Filenames[1][1]),
-	//	fontAwesomeFontSize,
-	//	&fontAwesomeConfig,
-	//	imgui.SliceToPtr(IconRange))
+	IconRange := []imgui.Wchar{imgui.Wchar(IconsFontAwesome6.Min), imgui.Wchar(IconsFontAwesome6.Max16), 0}
+	io.Fonts().AddFontFromFileTTFV(fmt.Sprintf("%s",
+		IconsFontAwesome6.Filenames[1][1]),
+		fontAwesomeFontSize,
+		&fontAwesomeConfig,
+		imgui.SliceToPtr(IconRange))
 	////.\main.go:49:3: cannot use imgui.SliceToPtr(IconRange) (value of type *uint16) as *imgui.Wchar value in argument to io.Fonts().AddFontFromFileTTFV

 	backend.Run(loop)

I don't know how to comment on that.
https://github.com/AllenDang/cimgui-go/assets/9079150/e6e64b5e-5aee-429d-83e5-1a73ab6c23c5

@Wolf65 I need to run this code on my machine since it seems that my debugger is broken on windows.
Could you give some reproduction code? I managed to make Bug code working with the diff mentioned above

It's a major project
https://github.com/Wolf65/PoEHelper
And in go.mod delete replace
Run "make"

@Wolf65 it works for me???

 Does this panic appear randomly????

Uh, no. Like in the video ~3 starts up ~3 times then ~6 panics.

could you try gdb on it? (you need specificly gdb, because dlv couldn't talk with C (or I can't make it talk with c))

(gdb) run
Starting program: /s/goProject/PoEHelper/_out/PoEHelperDebug.exe
[New Thread 15092.0x17a8]
[New Thread 15092.0x37bc]
[New Thread 15092.0x928]
[New Thread 15092.0x4c78]
[New Thread 15092.0x24a4]
[New Thread 15092.0x60c0]
[New Thread 15092.0x30cc]
[New Thread 15092.0x5168]
DEBUG  [2023-09-15 18:30:00] init map lab
DEBUG  [2023-09-15 18:30:00] register map lab pages
DEBUG  [2023-09-15 18:30:00] init settings
DEBUG  [2023-09-15 18:30:00] register setting pages
DEBUG  [2023-09-15 18:30:00] init trade
DEBUG  [2023-09-15 18:30:00] register trade pages
DEBUG  [2023-09-15 18:30:00] .exe path: S:\goProject\PoEHelper\_out
DEBUG  [2023-09-15 18:30:00] Font folder exists
DEBUG  [2023-09-15 18:30:00] JetBrainsMono-Medium.ttf exists
DEBUG  [2023-09-15 18:30:00] fa-solid-900.ttf exists
DEBUG  [2023-09-15 18:30:00] fa-brands-400.ttf exists
DEBUG  [2023-09-15 18:30:00] Lab folder exists
[New Thread 15092.0x34b0]
[New Thread 15092.0x4fe0]
[New Thread 15092.0x5ad4]
[New Thread 15092.0x3c14]
[New Thread 15092.0x3bc8]
[New Thread 15092.0x3bf0]
[Thread 15092.0x3bc8 exited with code 0]
[Thread 15092.0x3bf0 exited with code 0]
[New Thread 15092.0x5864]
[Thread 15092.0x3c14 exited with code 0]
[New Thread 15092.0x383c]
[New Thread 15092.0x3490]

Thread 1 received signal SIGSEGV, Segmentation fault.
0x00007ff6200bb5f0 in ImFontGlyphRangesBuilder::BuildRanges(ImVector<unsigned int>*) ()

meh, Can't see anyghing useful unfortunately.
My guss is that, because this file isn't auto-generated in fact, we should try to autogenerate it

on one of the restarts, instead of symbols.

expected

I'm hitting this problem too. Did some git bisect testing and found that the bug was introduced in #204

I did a little more research  and found the change that breaks:
diff --git a/cimgui_structs.go b/cimgui_structs.go
index 1b69681a..a53d5778 100644
--- a/cimgui_structs.go
+++ b/cimgui_structs.go
@@ -522,24 +522,13 @@ func newFontGlyphFromC(cvalue *C.ImFontGlyph) *FontGlyph {
 // Helper to build glyph ranges from text/string data. Feed your application strings/characters to it then call BuildRanges().
 // This is essentially a tightly packed of vector of 64k booleans = 8KB storage.
 type FontGlyphRangesBuilder struct {
-       FieldUsedChars Vector[*uint32] // Store 1-bit per Unicode code point (0=unused, 1=used)
+       // TODO: contains unsupported fields
+       data unsafe.Pointer
 }

 func (self FontGlyphRangesBuilder) handle() (result *C.ImFontGlyphRangesBuilder, releaseFn func()) {
-       result = new(C.ImFontGlyphRangesBuilder)
-       FieldUsedChars := self.FieldUsedChars
-       FieldUsedCharsData := FieldUsedChars.Data
-       FieldUsedCharsDataArg, FieldUsedCharsDataFin := WrapNumberPtr[C.ImU32, uint32](FieldUsedCharsData)
-       FieldUsedCharsVecArg := new(C.ImVector_ImU32)
-       FieldUsedCharsVecArg.Size = C.int(FieldUsedChars.Size)
-       FieldUsedCharsVecArg.Capacity = C.int(FieldUsedChars.Capacity)
-       FieldUsedCharsVecArg.Data = FieldUsedCharsDataArg
-
-       result.UsedChars = *FieldUsedCharsVecArg
-       releaseFn = func() {
-               FieldUsedCharsDataFin()
-       }
-       return result, releaseFn
+       result = (*C.ImFontGlyphRangesBuilder)(self.data)
+       return result, func() {}
 }

 func (self FontGlyphRangesBuilder) c() (result C.ImFontGlyphRangesBuilder, fin func()) {
@@ -549,7 +538,7 @@ func (self FontGlyphRangesBuilder) c() (result C.ImFontGlyphRangesBuilder, fin f

 func newFontGlyphRangesBuilderFromC(cvalue *C.ImFontGlyphRangesBuilder) *FontGlyphRangesBuilder {
        result := new(FontGlyphRangesBuilder)
-       result.FieldUsedChars = newVectorFromC(cvalue.UsedChars.Size, cvalue.UsedChars.Capacity, (*uint32)(cvalue.UsedChars.Data))
+       result.data = unsafe.Pointer(cvalue)
        return result
 }

Clearly the old Glyph builder did a lot more than just call cimgui. It doesn't look like something that can be easily generated, so I suggest putting it back to some manually written code for now

I did a little more research and found the change that cause the issue:
diff --git a/cimgui_structs.go b/cimgui_structs.go
index a53d5778..1b69681a 100644
--- a/cimgui_structs.go
+++ b/cimgui_structs.go
@@ -522,13 +522,24 @@ func newFontGlyphFromC(cvalue *C.ImFontGlyph) *FontGlyph {
 // Helper to build glyph ranges from text/string data. Feed your application strings/characters to it then call BuildRanges().
 // This is essentially a tightly packed of vector of 64k booleans = 8KB storage.
 type FontGlyphRangesBuilder struct {
-	// TODO: contains unsupported fields
-	data unsafe.Pointer
+	FieldUsedChars Vector[*uint32] // Store 1-bit per Unicode code point (0=unused, 1=used)
 }

 func (self FontGlyphRangesBuilder) handle() (result *C.ImFontGlyphRangesBuilder, releaseFn func()) {
-	result = (*C.ImFontGlyphRangesBuilder)(self.data)
-	return result, func() {}
+	result = new(C.ImFontGlyphRangesBuilder)
+	FieldUsedChars := self.FieldUsedChars
+	FieldUsedCharsData := FieldUsedChars.Data
+	FieldUsedCharsDataArg, FieldUsedCharsDataFin := WrapNumberPtr[C.ImU32, uint32](FieldUsedCharsData)
+	FieldUsedCharsVecArg := new(C.ImVector_ImU32)
+	FieldUsedCharsVecArg.Size = C.int(FieldUsedChars.Size)
+	FieldUsedCharsVecArg.Capacity = C.int(FieldUsedChars.Capacity)
+	FieldUsedCharsVecArg.Data = FieldUsedCharsDataArg
+
+	result.UsedChars = *FieldUsedCharsVecArg
+	releaseFn = func() {
+		FieldUsedCharsDataFin()
+	}
+	return result, releaseFn
 }

 func (self FontGlyphRangesBuilder) c() (result C.ImFontGlyphRangesBuilder, fin func()) {
@@ -538,7 +549,7 @@ func (self FontGlyphRangesBuilder) c() (result C.ImFontGlyphRangesBuilder, fin f

 func newFontGlyphRangesBuilderFromC(cvalue *C.ImFontGlyphRangesBuilder) *FontGlyphRangesBuilder {
 	result := new(FontGlyphRangesBuilder)
-	result.data = unsafe.Pointer(cvalue)
+	result.FieldUsedChars = newVectorFromC(cvalue.UsedChars.Size, cvalue.UsedChars.Capacity, (*uint32)(cvalue.UsedChars.Data))
 	return result
 }

IDK what happens here. I'll think about it but can't promise any other actionn on my side as I have no fast enough laptop here and this one is a bit too slow to effectively recompile cimgui-go so I can't do any tests now.

I have a suspicion that the glyph range is not supposed to be deallocated...
Here's a sample of how it's used to load a font sith a specific set of glyphs:
	bld := cimgui.NewFontGlyphRangesBuilder()
	bld.AddRanges(atlas.GlyphRangesDefault())
	bld.AddChar(cimgui.Wchar('⌘'))

	rng := cimgui.NewGlyphRange()
	bld.BuildRanges(rng)

	atlas.AddFontFromMemoryTTFV(ptr, int32(len(data)), pixelSize, cfg, rng.Data())

I think rng.Data() just gives a pointer to the first entry in the glyph array and imgui doesn't copy it.
So when the range builder is released, so is the array imgui is using

maybe... could you try to Pin result of rng.Data()
ALso its not a pointer to first index. Its a pointer to ImVector (in go code Vector[Wchar]) but yes, it is possible that something is released by GC

I diff above was a bit outdated... on the latest main the data is actually pinned
diff --git a/cimgui_structs.go b/cimgui_structs.go
index 36b723f1..f59703ad 100644
--- a/cimgui_structs.go
+++ b/cimgui_structs.go
@@ -530,13 +530,26 @@ func newFontGlyphFromC(cvalue *C.ImFontGlyph) *FontGlyph {
 // Helper to build glyph ranges from text/string data. Feed your application strings/characters to it then call BuildRanges().
 // This is essentially a tightly packed of vector of 64k booleans = 8KB storage.
 type FontGlyphRangesBuilder struct {
-	// TODO: contains unsupported fields
-	data unsafe.Pointer
+	FieldUsedChars Vector[*uint32] // Store 1-bit per Unicode code point (0=unused, 1=used)
 }

 func (self FontGlyphRangesBuilder) handle() (result *C.ImFontGlyphRangesBuilder, releaseFn func()) {
-	result = (*C.ImFontGlyphRangesBuilder)(self.data)
-	return result, func() {}
+	result = new(C.ImFontGlyphRangesBuilder)
+	FieldUsedChars := self.FieldUsedChars
+	FieldUsedCharsData := FieldUsedChars.Data
+	FieldUsedCharsDataArg, FieldUsedCharsDataFin := WrapNumberPtr[C.ImU32, uint32](FieldUsedCharsData)
+	FieldUsedCharsVecArg := new(C.ImVector_ImU32)
+	FieldUsedCharsVecArg.Size = C.int(FieldUsedChars.Size)
+	FieldUsedCharsVecArg.Capacity = C.int(FieldUsedChars.Capacity)
+	FieldUsedCharsVecArg.Data = FieldUsedCharsDataArg
+	FieldUsedChars.pinner.Pin(FieldUsedCharsVecArg.Data)
+
+	result.UsedChars = *FieldUsedCharsVecArg
+	releaseFn = func() {
+		FieldUsedCharsDataFin()
+		FieldUsedChars.pinner.Unpin()
+	}
+	return result, releaseFn
 }

 func (self FontGlyphRangesBuilder) c() (result C.ImFontGlyphRangesBuilder, fin func()) {
@@ -546,7 +559,7 @@ func (self FontGlyphRangesBuilder) c() (result C.ImFontGlyphRangesBuilder, fin f

 func newFontGlyphRangesBuilderFromC(cvalue *C.ImFontGlyphRangesBuilder) *FontGlyphRangesBuilder {
 	result := new(FontGlyphRangesBuilder)
-	result.data = unsafe.Pointer(cvalue)
+	result.FieldUsedChars = newVectorFromC(cvalue.UsedChars.Size, cvalue.UsedChars.Capacity, (*uint32)(cvalue.UsedChars.Data))
 	return result
 }

Unfortuantely that's didn't change anything

meh I see. I suppose this whole BuildRanges is broken because in current code it is not auto-generated. It used to work before my changes to struct generation and beffore implementing Vector type.
I think we codegen needs to implement Vector pointer so that we could get rid of this uintptr in GlyphRanges.

It's been a while since I've worked with this repo, so I don't have enough insight to comment on that - But I'll be happy to test any changes 😄

I'll try to fix this but can't say when could it happen...

No worries, I've just hacked it my apply the patch above
If any one else is having this problem, a temporary solution is to use my branch which patches this: https://github.com/ptxmac/cimgui-go/tree/ptx_fixes
Right now it's up to date with main

@ptxmac It should work #229

@ptxmac It should work #229

This fixed the font issues, there are some other things about the change that breaks other stuff, but I'll add that as comments on the PR

This works for me now! 🎊


Error while calling sphttpclient SPFX extension

Just following the SP starter kit code for adding the footer menu. This error is occurring in SPTaxonomyService and SPUserProfileService.
Category

[x] Question
[ ] Typo
[x] Bug
[ ] Additional article idea

Observed Behavior
[21:27:31] Error - typescript - src\services\SPTaxonomyService.ts(46,13): error TS2349: Cannot invoke an expression whose type lacks a call signature. Type '((url: string, configuration: SPHttpClientConfiguration, options: ISPHttpClientOptions) => Promis...' has no compatible call signatures.
Package.json
{
"name": "footer",
"version": "0.0.1",
"private": true,
"engines": {
"node": ">=0.10.0"
},
"scripts": {
"build": "gulp bundle",
"build:dev": "gulp clean && gulp bundle && gulp package-solution",
"build:prod": "gulp clean && gulp bundle --ship && gulp package-solution --ship",
"clean": "gulp clean",
"test": "gulp test"
},
"dependencies": {
"@microsoft/decorators": "1.5.0",
"@microsoft/sp-application-base": "1.5.0",
"@microsoft/sp-core-library": "1.5.0",
"@microsoft/sp-dialog": "1.5.0",
"@microsoft/sp-office-ui-fabric-core": "^1.5.1",
"@microsoft/sp-webpart-base": "~1.4.1",
"@pnp/common": "^1.0.4-4",
"@pnp/logging": "^1.0.4-4",
"@pnp/odata": "^1.0.4-4",
"@pnp/sp": "^1.1.4",
"@pnp/spfx-controls-react": "1.4.0",
"@pnp/spfx-property-controls": "1.7.0",
"@types/react": "15.6.6",
"@types/react-dom": "15.5.6",
"@types/es6-promise": "0.0.33",
"@types/webpack-env": "1.13.1",
"office-ui-fabric-core": "^9.6.0",
"react": "15.6.2",
"react-dom": "15.6.2",
"@microsoft/sp-listview-extensibility": "~1.4.1"
},
"devDependencies": {
"@microsoft/sp-build-web": "1.5.0",
"@microsoft/sp-module-interfaces": "1.5.0",
"@microsoft/sp-webpart-workbench": "1.5.0",
"gulp": "~3.9.1",
"@types/chai": "3.4.34",
"@types/mocha": "2.2.38",
"ajv": "~5.2.2"
}
}

First, ensure that all your @microsoft/sp-??? dependencies are on the same version. You have a mix of 1.4.1, 1.5.0 and 1.5.1. Then remove the node_modules folder and package-lock.json and run npm install.

Wictor,
Will do the changes and let you know
On Fri 24 Aug, 2018, 1:10 AM Wictor Wilén<EMAIL_ADDRESS>wrote:

First, ensure that all your @microsoft/sp-??? dependencies are on the
same version. You have a mix of 1.4.1, 1.5.0 and 1.5.1. Then remove the
node_modules folder and package-lock.json and run npm install.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/SharePoint/sp-dev-docs/issues/2408#issuecomment-415545913,
or mute the thread
https://github.com/notifications/unsubscribe-auth/Ae2rzTxVJwC19PqRWaQG-MYjZPILnJGFks5uTwUcgaJpZM4WJ1Pg
.

I have updated the to correct versions now I am getting a different error.
here is my package.json
{
"name": "share-point-portal-showcase",
"version": "0.0.1",
"private": true,
"engines": {
"node": ">=0.10.0"
},
"scripts": {
"build": "gulp bundle",
"build:dev": "gulp clean && gulp bundle && gulp package-solution",
"build:prod": "gulp clean && gulp bundle --ship && gulp package-solution --ship",
"clean": "gulp clean",
"test": "gulp test"
},
"dependencies": {
"@microsoft/decorators": "~1.4.1",
"@microsoft/sp-application-base": "~1.4.1",
"@microsoft/sp-core-library": "~1.4.1",
"@microsoft/sp-dialog": "~1.4.1",
"@microsoft/sp-lodash-subset": "~1.4.1",
"@microsoft/sp-office-ui-fabric-core": "~1.4.1",
"@microsoft/sp-webpart-base": "~1.4.1",
"@pnp/common": "^1.0.4-4",
"@pnp/logging": "^1.0.4-4",
"@pnp/odata": "^1.0.4-4",
"@pnp/sp": "^1.0.4-4",
"@pnp/spfx-controls-react": "1.4.0",
"@pnp/spfx-property-controls": "1.7.0",
"@types/react": "15.6.6",
"@types/react-dom": "15.5.6",
"@types/webpack-env": ">=1.12.1 <1.14.0",
"react": "15.6.2",
"react-dom": "15.6.2",
"@microsoft/sp-listview-extensibility": "~1.4.1"
},
"devDependencies": {
"@microsoft/sp-build-web": "~1.4.1",
"@microsoft/sp-module-interfaces": "~1.4.1",
"@microsoft/sp-webpart-workbench": "~1.4.1",
"@types/chai": ">=3.4.34 <3.6.0",
"@types/mocha": ">=2.2.33 <2.6.0",
"ajv": "~5.2.2",
"gulp": "~3.9.1"
}
}
tsconfig.json
{
"compilerOptions": {
"target": "es5",
"forceConsistentCasingInFileNames": true,
"module": "commonjs",
"jsx": "react",
"declaration": true,
"sourceMap": true,
"experimentalDecorators": true,
"skipLibCheck": true,
"typeRoots": [
"./node_modules/@types",
"./node_modules/@microsoft"
],
"types": [
"es6-promise",
"webpack-env"
],
"lib": [
"es5",
"dom",
"es2015.collection"
]
}
}

Yes I did.
On Sat 25 Aug, 2018, 4:52 PM Waldek Mastykarz<EMAIL_ADDRESS>wrote:

After updating your dependency versions in package.json, have you deleted
the node_modules folder and re-run npm install?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/SharePoint/sp-dev-docs/issues/2408#issuecomment-415962627,
or mute the thread
https://github.com/notifications/unsubscribe-auth/Ae2rzUEQMcqqv1AvDTeirg2vsR6uL6TXks5uUTOCgaJpZM4WJ1Pg
.

If you create a new project and move your code there, can you reproduce the error?

Just to provide some feedback as I got this error yesterday and resolved it using the same steps as suggested on this thread.
@Shamrh  did you try the steps above to update your dependencies and re-install the entire node_modules folder?

What also helps is to run npm dedupe which prevents you from having to remove the node_modules folder and the lock file.

Added labels to prompt for follow up, or to close stale issue.


Bracket highlighting does not work properly

Issue Type: Bug
Bracket highlighting does not work properly when inside Nesting templates for Template literals
VS Code version: Code 1.68.1 (30d9c6cd9483b2cc586687151bcbcd635f373630, 2022-06-14T12:48:58.283Z)
OS version: Windows_NT x64 10.0.19044
Restricted Mode: No

Should move report to https://github.com/microsoft/TypeScript-TmLanguage/issues
Can easily be fixed by adding embedded. to the scope name under template-substitution-element
https://github.com/microsoft/TypeScript-TmLanguage/blob/0dfae8cc4807fecfbf8f1add095d9817df824c95/TypeScriptReact.tmLanguage#L8155

Also fixes ${, } bracket highlighting

应将报告移至https://github.com/microsoft/TypeScript-TmLanguage/issues
可以通过添加到https://github.com/microsoft/TypeScript-TmLanguage/blob/0dfae8cc4807fecfbf8f1add095d9817df824c95/TypeScriptReact.tmLanguage#L8155下embedded.的范围轻松修复name``template-substitution-element
还修复${了}括号突出显示

@RedCMD Thank you for your reply. In fact, I mean the highlighting of the curly braces is currently working but the highlighting of the curly braces is not working because the expected result is that it has different colors to distinguish it

Sorry. Had Bracket Pair Colorization disabled


Getting the error dlopen(myo, 6): no suitable image found

Hi, i am getting this error. Could you please help me with this.

OSError: dlopen(myo, 6): no suitable image found.  Did find:
myo: not a file

@rranjanjanacare did you follow the installation instructions? Please check closed issues before posting.
My DYLD_LIBRARY_PATH for MacOS which I've just spammed with all the possible directories because why not:
export DYLD_LIBRARY_PATH="/Applications/Myo:/Developer/myo_sdk/myo.framework:/Developer/myo_sdk/myo.framework:/Applications/Myo Mapper.app/Contents/Frameworks/myo.framework"

I'll close this due to the lack of response. As @Lythimus alredy mentioned, the installation instructions show how to resolve this problem.


[begin-functions-app] Server on localhost crashes on requests

Expected behavior
The local “server” should return a response, and not crash.
Description of bug
~/Sites/begin-functions-app master*
❯ npm start

><EMAIL_ADDRESS>start /Users/knutmelvaer/Sites/begin-functions-app
> NODE_ENV=testing npx sandbox

        ARC_APP_NAME test-app
          AWS_REGION us-west-2
         AWS_PROFILE xxx

                Node 9.11.1
                 npm 6.0.1
                .arc 3.2.18

✓ @tables created in local database
✓ src/shared copied to lambda node_modules/@architect/shared
✓ .arc copied to lambda<EMAIL_ADDRESS>✓ @events pub/sub ready on local event bus

 @html
 get / ................................. get-index

 ✓ Started HTTP "server" @  http://localhost:3333
{ ResourceNotFoundException: Requested resource not found
    at Request.extractError (/Users/knutmelvaer/Sites/begin-functions-app/node_modules/aws-sdk/lib/protocol/json.js:48:27)
    at Request.callListeners (/Users/knutmelvaer/Sites/begin-functions-app/node_modules/aws-sdk/lib/sequential_executor.js:105:20)
    at Request.emit (/Users/knutmelvaer/Sites/begin-functions-app/node_modules/aws-sdk/lib/sequential_executor.js:77:10)
    at Request.emit (/Users/knutmelvaer/Sites/begin-functions-app/node_modules/aws-sdk/lib/request.js:683:14)
    at Request.transition (/Users/knutmelvaer/Sites/begin-functions-app/node_modules/aws-sdk/lib/request.js:22:10)
    at AcceptorStateMachine.runTo (/Users/knutmelvaer/Sites/begin-functions-app/node_modules/aws-sdk/lib/state_machine.js:14:12)
    at /Users/knutmelvaer/Sites/begin-functions-app/node_modules/aws-sdk/lib/state_machine.js:26:10
    at Request.<anonymous> (/Users/knutmelvaer/Sites/begin-functions-app/node_modules/aws-sdk/lib/request.js:38:9)
    at Request.<anonymous> (/Users/knutmelvaer/Sites/begin-functions-app/node_modules/aws-sdk/lib/request.js:685:12)
    at Request.callListeners (/Users/knutmelvaer/Sites/begin-functions-app/node_modules/aws-sdk/lib/sequential_executor.js:115:18)
  message: 'Requested resource not found',
  code: 'ResourceNotFoundException',
  time: 2018-08-10T04:41:14.014Z,
  requestId: '<redacted>',
  statusCode: 400,
  retryable: false,
  retryDelay: 32.464603033333404 }
/Users/knutmelvaer/Sites/begin-functions-app/node_modules/aws-sdk/lib/request.js:31
            throw err;
            ^

ResourceNotFoundException: Requested resource not found
    at Request.extractError (/Users/knutmelvaer/Sites/begin-functions-app/node_modules/aws-sdk/lib/protocol/json.js:48:27)
    at Request.callListeners (/Users/knutmelvaer/Sites/begin-functions-app/node_modules/aws-sdk/lib/sequential_executor.js:105:20)
    at Request.emit (/Users/knutmelvaer/Sites/begin-functions-app/node_modules/aws-sdk/lib/sequential_executor.js:77:10)
    at Request.emit (/Users/knutmelvaer/Sites/begin-functions-app/node_modules/aws-sdk/lib/request.js:683:14)
    at Request.transition (/Users/knutmelvaer/Sites/begin-functions-app/node_modules/aws-sdk/lib/request.js:22:10)
    at AcceptorStateMachine.runTo (/Users/knutmelvaer/Sites/begin-functions-app/node_modules/aws-sdk/lib/state_machine.js:14:12)
    at /Users/knutmelvaer/Sites/begin-functions-app/node_modules/aws-sdk/lib/state_machine.js:26:10
    at Request.<anonymous> (/Users/knutmelvaer/Sites/begin-functions-app/node_modules/aws-sdk/lib/request.js:38:9)
    at Request.<anonymous> (/Users/knutmelvaer/Sites/begin-functions-app/node_modules/aws-sdk/lib/request.js:685:12)
    at Request.callListeners (/Users/knutmelvaer/Sites/begin-functions-app/node_modules/aws-sdk/lib/sequential_executor.js:115:18)
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR<EMAIL_ADDRESS>start: `NODE_ENV=testing npx sandbox`

Steps to reproduce

Deleted node_modules
Updated all dependencies to the latest version
Run npx hydrate
Run npm start
Make a GET request to localhost:3333

Desktop

OS: macOS[e.g. macOS]
node/npm: v9.11.1 / 6.0.1

Hmm, @brianleroux may know more immediately what's up here – I'll have to troubleshoot a bit.
Did this randomly start happening? Did something change? (If so, any idea as to what?)
What happens if you change that to node 8.11? That is the runtime in Lambdaland, so you'd probably want that to match anyway.

Oh, and quick thing to try: looking at your package.json in your repo, you may want to do an npm update (specifically to freshen up arc-workflows, jic).

Before the updates to the arc-dependencies, I didn't get it running at all, so this is in fact one step further 😄. But I've never got the server to return a response.
{
  "name": "begin-functions-app",
  "version": "1.0.0",
  "description": "Begin app",
  "scripts": {
    "lint": "eslint src --ignore-pattern node_modules --fix",
    "test": "NODE_ENV=testing tape test/*-test.js | tap-spec",
    "start": "NODE_ENV=testing npx sandbox"
  },
  "dependencies": {
    "@architect/workflows": "^3.2.18",
    "@begin-functions/data": "^1.0.4",
    "eslint": "^5.3.0",
    "tap-spec": "^5.0.0",
    "tape": "^4.9.1",
    "tiny-json-http": "^7.0.0"
  },
  "devDependencies": {
    "aws-sdk": "^2.290.0"
  }
}

All dependencies should be up to date.
I tried to run npm start on node 8.11. Same result. If I try to run npx hydrate on node 8/npm 5.6, I get this
~/Sites/begin-functions-app master*
❯ nvm use 8
Now using node v8.11.3 (npm v5.6.0)

~/Sites/begin-functions-app master*
❯ npm i
npm WARN<EMAIL_ADDRESS>No repository field.
npm WARN<EMAIL_ADDRESS>No license field.

up to date in 1.265s

~/Sites/begin-functions-app master*
❯ npx hydrate
Error invalid npm version; must be 6 or higher

Used nvm to switch to node 8 (which comes with npm 5.6 out of the box)
Upgraded npm to 6.3.0 with npm i -g npm
npx hydrate run successfully
Run npm install in /get-index just to make sure
Run npm start and curled localhost:3333 with the same result

(Thinking you should have a section on how to work with multiple node-environment in the docs?)

Hmm, very sorry about that. Very frustrating, haven't seen this before.
Try one more thing, if you'd please?  In package.json, try changing start to "NODE_ENV=testing ARC_LOCAL=1 npx sandbox"
Removing ARC_LOCAL didn't replicate the problem on my side, so I'm shooting in the dark here, but 🤞🏻

(I thought ARC_LOCAL=1 was something I did the last time we troubleshot this, but putting it in again didn't help either)
Hey, making dev software that should run on all the weird environments isn't easy. Just give me a ping when you're ready to look at this again 🙌

Super weird! Just woke up and taking a look rn.

@kmelve can you delete node_modules and run:
npm i
npx hydrate
unset AWS_PROFILE
npm start

And lmk if it still happens?

Same error 🙃

oh! I have another theory! can you try AWS_REGION=us-west-1 npm start

Success!
~/Sites/begin-functions-app master* 12s
❯ AWS_REGION=us-west-1 npm start

><EMAIL_ADDRESS>start /Users/knutmelvaer/Sites/begin-functions-app
> NODE_ENV=testing ARC_LOCAL=1 npx sandbox

        ARC_APP_NAME test-app
          AWS_REGION us-west-1
         AWS_PROFILE xxx

                Node 9.11.1
                 npm 6.0.1
                .arc 3.2.18

✓ @tables created in local database
✓ src/shared copied to lambda node_modules/@architect/shared
✓ .arc copied to lambda<EMAIL_ADDRESS>✓ @events pub/sub ready on local event bus

 @html
 get / ................................. get-index

 ✓ Started HTTP "server" @  http://localhost:3333
{
  "method": "get",
  "path": "/",
  "headers": {
    "host": "localhost:3333",
    "user-agent": "curl/7.54.0",
    "accept": "*/*"
  },
  "query": {},
  "body": {},
  "params": {},
  "_idx": "<redacted>",
  "_secret": "<redacted>",
  "csrf": "<redacted>",
  "session": {}
}

Do you only operate in the us-west region? That can potentially be an issue with regards to GDPR and so on.

These values are just stubs to get the local environment working; afaik they don't necessarily correspond to reality for Begin users.

omg that was it! I'll def get a patch in for this case. we should have a default.
@kmelve thx so much for helping us find/triage/fix this 🙏
As Ryan said this is only local to your machine in memory fake-out. Begin pro tier accounts will support all the same regions AWS does and for now the free tier apps are from an end user perspective edge optimized CDN distributions (but I can see us allowing region selection in the future).

I'll keep this issue open while I patch arc-repos/arc-functions for this case!

This should be fixed using the latest versions of architect/functions (in your lambda functions) and architect/workflows (in the project root). Thx again for helping us w this!


swarm now supports docker import, remove this part in swarm-api.md

swarm now supports docker import, remove this part in swarm-api.md
Signed-off-by: Sun Hongliang<EMAIL_ADDRESS>

I'd rather not delete the whole section. Instead replace with some other endpoints that are missing. In general, we've not updated that part very well in the past.

@nishanttotla
Great, Reasonable.
Maybe I can help to do the comparison soon.

docs LGTM

ping @sfsmithcha, any update?

Remove same as https://github.com/docker/swarm/pull/2040

@allencloud , need to clarify from which point/version Swarm supports the API. Please see my comment.

@sfsmithcha @SvenDowideit @jimmyxian
I did more change. Updated the PR topic name name and PR description.

@allencloud , thanks for all your work on this. however, these changes introduce some editorial issues for the doc set. i think rather than asking you to make the changes, I probably need to take an editorial pass.
For usability purposes, I think I will want to keep only information for the latest version(s) in this doc and add a link to a separate doc that details the versioning issues.
I'm fairly swamped with another project right now. Feel free to ping me in a week or so.

ping @sfsmithcha updated the PR to update docs about API. PTAL
ping @nishanttotla @vieux @abronan @dongluochen
In the part of Endpoints which behave differently, may be we should check PR #2299 #2297 #2295 #2275 #2261

PTAL @SvenDowideit @sfsmithcha

Hey @allencloud, do you want to still get this PR in? If so, could you make sure if it needs updating?

Is this PR worth keeping open? If so, I can review it and try to help.

Ping @allencloud

Thanks a lot @mstanleyjones welcome your review.
And PR updated @nishanttotla

Oh boy, looks like this wasn't merged before the docs were moved; can you reopen this against the central docs repository https://github.com/docker/docker.github.io/ if it's still something that has to be addressed?


chore: Replaced node info text with rich format

Changes

Made " pod" bold font
Added numaproj icon inline. will replace it with another asset when it's ready
Ensure separation of logic (in react) and ui (in css)

Signed-off-by: Qianbo Huai<EMAIL_ADDRESS>

looks good


MsBot: Fix undefined storage info error

Fixes #554

Pull Request Test Coverage Report for Build 1271

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 68.799%

Totals

Change from base Build 1268:
0.0%

Covered Lines:
3867

Relevant Lines:
5390

💛  - Coveralls


0.12 Updates

Should I move the namespace to Effect.Aff?

What's happening with the Aff version of AVar if we're dropping it from here?

I just thought it would be weird to export Aff from Effect.Async. I can also just export it under Aff, without a prefix.

I'm going to move Aff bindings to purescript-avar.


fix: shim require for ESM

Sorry, #18 wasn't working because require doesn't work in ESM.
This PR shim require for ESM.

Can we directly create the require function in place? I am not sure the shim is needed

I forgot that tsup will shim import.meta.url. (I had to add esbuildOptions.supported though)
I updated the PR.

import-meta not supported error was happening because the target was ES2017.
Because vite-plugin-vue-markdown depends on Vite 2+ that supports Node 12+, I changed the target to node12. node12 is ES2019 + some features according to https://node.green/


Windows Support

Add windows support :P

No. This is mac only.
r/MacOs
for mac
Anyways Xcode isn't for windows.


Properly validate translations

The existing validate-translations tox environment (introduced in #5939) doesn't properly validate translations, because it tests the wrong path.
The tox config tries to test files under cfgov/locale, but it was using a changedir setting that changed the working directory to cfgov. So in practice it wasn't actually testing any files. Currently master does generate some changes in translation files, but these were being missed because of this misconfiguration.
This change modifies the tested path from cfgov/locale to just locale, so that the right files are tested.
Notes and todos
There are some outstanding changes to the translation files that need to be fixed before tox will pass, mostly seeming to do with the wellbeing app. @higs4281 is this somehow related to #5950?
Checklist

[x] PR has an informative and human-readable title

PR titles are used to generate the change log in releases; good ones make that easier to scan.
Consider prefixing, e.g., "Mega Menu: fix layout bug", or "Docs: Update Docker installation instructions".

[x] Changes are limited to a single goal (no scope creep)
[x] Code follows the standards laid out in the CFPB development guidelines
[x] Future todos are captured in comments and/or tickets

The validate-translations failure is expected, due to the outstanding translations changes, but this demonstrates the necessity of this PR to test the right file:
validate-translations run-test: commands[0] | python manage.py makemessages
processing locale es
validate-translations run-test: commands[1] | python manage.py compilemessages
processing file django.po in /home/runner/work/consumerfinance.gov/consumerfinance.gov/cfgov/locale/es/LC_MESSAGES
validate-translations run-test: commands[2] | git diff-index --quiet HEAD -- 'locale/*/LC_MESSAGES/django.mo'
ERROR: InvocationError for command /usr/bin/git diff-index --quiet HEAD -- 'locale/*/LC_MESSAGES/django.mo' (exited with code 1)

is this somehow related to #5950?

No doubt. I'll check it out.

#5939 Took translations out of the view to stop sever errors and allow the Spanish results page to render.
The immediate problem was that some view-based translations were generating a KeyError.
I didn't realize the translation test was not running correctly. Unfortunately, if we fix the translation test, the wellbeing results page would break again, because the fixed translation test will overwrite the translations created for the generated values that reach the template.

Doh!

@chosak I think we're going to have a problem with the date stamp being updated in the .po file — even if there are no other changes, a makemessages run will update that.

@willbarton happily, edits to the timestamp in the .po file doesn't affect the .mo file, which is what we diff in the check.

Ah! Yes, sorry. I had a moment.

Can't merge this until #5965 is in.

I think I've gotten this PR back into committable shape.
For the record, if developers make changes without regenerating the .mo file, doing these things will fail translation validation:

Manually editing translated text in a .po file
Removing all translations of a string from code (will cause entry in .po file to be commented out and moved to bottom of file)

These will NOT fail translation validation, as they don't affect the .mo file:

Making unrelated edits to source code in such a way that affects line numbers in the .po file
Adding new uses of translation (_('something new')) in code (default is translation works as a no-op)

The fact that adding a new use of _() doesn't require manually dealing with translations while removing a use of _() potentially does feels unbalanced and potentially annoying to developers, but hopefully the benefit of keeping our .po files tidy is worth it.


Draggable div does not follow mouse position after parent div is zoomed

My project required the parent div to be scalable, but after zooming in or out, plain-draggable children div will not follow the mouse position when dragging. In my case, all draggable children stay within the scalable parent div. Is there any solution to this?
Zoom by using CSS transform scale, zoom by scrolling.
draggable.onDrag = (newPosition) => {
      const boundingRect = drawArea.current.getBoundingClientRect(); // parent div
      newPosition.left = (boundingRect.left + (newPosition.left - boundingRect.left)) / currentScale; //e.g currentScale = 1 or 1.1 or 2
      newPosition.top = (boundingRect.top + (newPosition.top - boundingRect.top)) / currentScale;
}

It works well when scale value = 1
Tried dividing the scale value, but it does not work.

Hi @weiyuanC, thank you for the comment.
This may help you: https://github.com/anseki/plain-draggable/issues/13

Hi @weiyuanC, thank you for the comment.
This may help you: https://github.com/anseki/plain-draggable/issues/13

I have seen that post, but I still don't get it.
In this example: https://jsfiddle.net/5rzkxpaf/
the example will not work when I change the JS SCALE value and the transform value in CSS to the same value.
So, the issue is I shouldn't use transform scale?

I have seen that post, but I still don't get it.
In this example: https://jsfiddle.net/5rzkxpaf/
the example will not work when I change the JS SCALE value and the transform value in CSS to the same value.
So, the issue is I shouldn't use transform scale?

I see.
Does this help you?
https://github.com/anseki/plain-draggable/issues/54

I see.
Does this help you?
https://github.com/anseki/plain-draggable/issues/54

Yes! This example does help.
In this example: https://jsfiddle.net/ue9khnyz/
What is line 21 and 22 doing? I tried removing them and it is still working.

Yes! This example does help.
In this example: https://jsfiddle.net/ue9khnyz/
What is line 21 and 22 doing? I tried removing them and it is still working.

Those lines fix the position of the element when the moving the draggable element started (before onDrag function is called).

Those lines fix the position of the element when the moving the draggable element started (before onDrag function is called).

Thank you so much for the quick response and patience! It works perfectly now!
I have one more question, how do I disable the whole draggable?
Tried doing:
draggable.disabled = true
but it doesn't work

Thank you so much for the quick response and patience! It works perfectly now!
I have one more question, how do I disable the whole draggable?
Tried doing:
draggable.disabled = true
but it doesn't work

I'm glad if I could help you. :smile:
Could you close this issue and make new issue for another topic?

I'm glad if I could help you. :smile:
Could you close this issue and make new issue for another topic?


Adds filename and arbitrary query options to fetchHistory

dataTable.fetchHistory and cell.fetchHistory now by default return the host file name of the change, and will send arbitrary query options in the request.

Looks good to me.


Python wheels for Python bindings

All Python bindings (Windows, Linux and OSX) should be distributed as Python wheels and made available through PIP for easier adoption of lib3mf.

Thanks @vijaiaeroastro
This works for me (Windows 11, python 3.11.8).
Can we call the library lib3mf in most places? After to many inconsistencies we decided to call the library lib3mf (over lib3MF, Lib3mf, Lib3MF) as often as possible (namespaces in C++ are still Lib3MF, though).

What are the next steps to releasing this on Pip with every lib3mf release?
I held off posting to https://github.com/Ghostkeeper/Blender3mfFormat
Let’s have more interesting Python examples in place before posting there. They will want those examples anyway.
Thanks!


Upgrade to<EMAIL_ADDRESS>

Fixes issue with Chrome Canary: https://github.com/yahoo/intl-format-cache/issues/9

Thanks for the PR :)


simpleini: init at 4.22

One of the dependencies of suyu
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

This is a duplicate of #346958

Can you merge the diffs on your PR, since it is older?

Can you merge the diffs on your PR, since it is older?

Sure, may I ask why is name necessary in src? Should I add you as a maintainer too?

Sure, may I ask why is name necessary in src?

fetchFromGitHub sets src.name = "source";. When running nix-build the log will look like
these 2 derivations will be built:
  /nix/store/jid6rh7s5vgzj0namdlmyigif053w7xf-source-4.22.drv
  /nix/store/kgdsdmh6z6vlk1fm357lf1ix8gbhdawq-simpleini-4.22.drv

If we set src.name = "some-useful-string";:
these 2 derivations will be built:
  /nix/store/jid6rh7s5vgzj0namdlmyigif053w7xf-some-useful-string-4.22.drv
  /nix/store/kgdsdmh6z6vlk1fm357lf1ix8gbhdawq-simpleini-4.22.drv

This is useful because it helps to locate the sources when reading the logs.
Especially when fetching many sources at once - e. g. patches, extra files from another repository etc.

Should I add you as a maintainer too?

Yes, please.

Thanks for the explanation!

Replaced by #346958


rpi partitioning: create dual and media partitions

creates dual rootfs partitions of approx 1.5 GB each taking into
account the overhead factor of 1.3. The dual partitioning is done
to facilitate swupdate feature which use A/B partitioning scheme.

creates media partition of size 1 GB.

Signed-off-by: Tariq Ansari<EMAIL_ADDRESS>

The IMAGE_CMD_rpi-sdimg() function from sdcard_image-rpi.bbclass is overidden in dualpart_image-rpi.bbclass. Bulk of the code in this function is same as in the base class. Some code is added and updated to create dual rootfs partitions and media partition. Also the variable ROOTFS_SIZE is overridden with fixed rootfs size.

The image has been moved from rpi-sdimg to wic with #334. The media partition was added there as well.


feat: github app get access token for an installation given org

rest api doc: https://docs.github.com/en/rest/apps/apps?apiVersion=2022-11-28#get-an-organization-installation-for-the-authenticated-app
required by https://github.com/abcxyz/team-link/issues/24

Hi @sqin2019 - can you link to the GitHub documentation for this? I'm not sure I like overloading the githubAccessToken function like this.

Do you mean this link?
Let me clarify a little bit more:

Goal - To be able to get an access token for a GitHub app installation that is installed on an different org.
Step added in the githubAccessToken - get the app installation ID for that org (instead of the one in the *App object) and then use that ID to generate the access token.

Here are what I tried:

get the installation ID outside of this package - some of the code (AppToken) overlaps with this package.
make githubAccessToken generic and can get any response given different GitHub request - essentially the same as this PR.

Do you have any suggestions?

Goal - To be able to get an access token for a GitHub app installation that is installed on an different org.

The installation ID is a globally unique string. As long as you have the installation ID, everything should just work. Are you seeing something different?

Goal - To be able to get an access token for a GitHub app installation that is installed on an different org.

The installation ID is a globally unique string. As long as you have the installation ID, everything should just work. Are you seeing something different?

ah, I thought we can install the same private github app in different organizations if under the same enterprise, but it seems that a private github app is restricted to it's own org? I wonder what teamsync did as I don't see them using a github app per org.

Update - seems can easily share the same github app across orgs by making it public in the github enterprise cloud account, or by https://docs.github.com/en/apps/sharing-github-apps/making-your-github-app-available-for-github-enterprise-server if it is a enterprise server account.

Ah yes - annoyingly GitHub Apps are either "private" (only available in your org) or "public" (visible to the entire Internet); there is no option to selectively expose. So yes, we'd have to make the GitHub App public to use it outside of our organization.

Update - seems can easily share the same github app across orgs by making it public in the github enterprise cloud account, or by https://docs.github.com/en/apps/sharing-github-apps/making-your-github-app-available-for-github-enterprise-server if it is a enterprise server account.

Ah yes - annoyingly GitHub Apps are either "private" (only available in your org) or "public" (visible to the entire Internet); there is no option to selectively expose. So yes, we'd have to make the GitHub App public to use it outside of our organization.

This githubauth package is designed for a single github app installation, should we make it support other installations too?

I'm not sure what you mean?

see https://github.com/abcxyz/pkg/pull/330


[DO NOT MERGE] Demo https://bugs.swift.org/browse/SR-4328

Demonstrates SR-4328 failing on the bots with presumably a different tool/SDK configuration than the one I'm using

@swift-ci Please test

preset=buildbot,tools=RA,stdlib=DA
@swift-ci Please test macOS with preset

preset=dave
@swift-ci Please test macOS with preset

preset=dave
@swift-ci Please test macOS with preset

@swift-ci Please smoke test OS X platform

@swift-ci Please smoke test macOS

preset=dave
@swift-ci Please test macOS with preset

preset=dave
@swift-ci Please test macOS with preset

@dabrahams Please re-open if you are still seeing the issue with preset testing.


Re-ordering basis functions introduces mismatch

#1620 introduced ordering basis functions if they are not ordered correctly. When using molden.load to load molecules from molden files, the MO coefficients are not ordered accordingly, which leads to a mismatch and therefore wrong results.
One example would be the minimally augmented basis sets (like ma-def2-SVP) from ORCA, which have some s-type AOs appended after the p-type AOs from the standard def2-SVP.
The code has changed significantly since #1620, which makes fixing the problem a bit harder.

I tested an example with aug-cc-pvtz using pyscf 2.2.0, which is released before 1620, and it shows that the basis is still re-ordered. So I guess this re-ordering is not a feature introduced in recent versions but much earlier?

Hi @kevfocke , thanks! Has it been fixed now and can this issue be closed?

@verena-neufeld Yes, sure, thank you!


Location Groups July 2024

Checklist

[ ] Appropriate branch selected (all PRs must first be merged to dev before they can be merged to master)
[ ] Any modified or new methods or classes have helpful JSDoc and code is thoroughly commented
[ ] The description lists all applicable issues this PR seeks to resolve
[ ] The description lists any configuration setting(s) that differ from the default settings
[ ] All tests and CI builds passing
[ ] The description lists all relevant PRs included in this release (remove this if not merging to master)
[ ] e2e tests are all passing (remove this if not merging to master)

Description
Please explain the changes you made here and, if not immediately obvious from the code, how they resolve any referenced issues (and PRs if merging to master). Be sure to include all issues being resolved and any special configuration settings that are need for the software to run properly with these changes.

Excited for this update!


Update to latest administrate + remove other asset gems

@enviable @enviable @enviable

YAAAAAY
On Thu, Feb 24, 2022 at 12:20 PM Joshua Smith @.***>
wrote:

Merged #1 https://github.com/enviable/administrate/pull/1 into
remove-sprockets.
—
Reply to this email directly, view it on GitHub
https://github.com/enviable/administrate/pull/1#event-6134805678, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAACDEWQZKKMNUHCV3HMXZTU42HJVANCNFSM5OS6BTXQ
.
You are receiving this because you authored the thread.Message ID:
@.***>


Merge Focus changes in from upstream template

This PR merges the work done in the template to remove unnecessary keyboard focus and add focus where necessary.
It also adds some JavaScript functions to toggle menu visibility in order to ensure menu doesn't prevent keyboard nav when offscreen.
This needs to be carefully tested before merging.

This fixes #60


support type conversion between fp8 formats and bf16/fp32 with HW instructions on MI300

Upstream Triton provides type conversion between fp8 and fp32 without using intermediate fp16 types. MI300 provides HW instructions exactly for such conversion. Also provided are the conversion between fp8 and bf16, so this PR provides data type conversions between the following types on MI300.

fp8/bf8 <--> fp32 without using fp16 as the intermediate data types, which can improve type conversion performance in some scenarios.
fp8/bf8 <--> bf16. This is implemented as fp8/bf8 <--> fp32 <--> bf16.

Again, the test script test_fp8_vecadd.py will be removed before merging this PR.

Hi Shucai, could you revise those related to conversion between bf16 and fp32?

Hi Wen, thanks for the comments, please check the update.


Render OAS info as first doc

I'm interested in rendering the info section of a spec file as the first doc displayed. This would allow for displaying the title, version, description and other metadata to help describe the API to the end user. Is there any way to accomplish this with the plugin today? Thanks!

Not really, but I would be happy to merge a pull request adding the feature


Add helix-5 support for blog

Description
Support both .hlx. and .aem.
Test instructions
No regressions on https://hlx-5--blog--adobecom.hlx.page/ AND https://hlx-5--blog--adobecom.aem.page/ (and .live)
Test links
Before: https://main--blog--adobecom.hlx.page/
After: https://hlx-5--blog--adobecom.hlx.page/
After-2: https://hlx-5--blog--adobecom.aem.page/

@vhargrave we can still rely on .hlx. pages for now, but I agree that we need to fix those loc issues.
We could https://github.com/adobecom/blog/pull/52/files#diff-2ebcaa4571e24bd4339a27cf7084528912146feebf4eec067300c69d66d96107R4-R5 remove the sidekick configs so authors still go to hlx for now

@vhargrave we can still rely on .hlx. pages for now, but I agree that we need to fix those loc issues. We could https://github.com/adobecom/blog/pull/52/files#diff-2ebcaa4571e24bd4339a27cf7084528912146feebf4eec067300c69d66d96107R4-R5 remove the sidekick configs so authors still go to hlx for now

@mokimo sounds like a decent approach. 👍
I think it makes sense to give this a bit of a deeper dive test to ensure these changes don't break anything though.


boxen module exists twice in module paths

It appears the boxen module appears twice in the module search path. The below output shows that the custom facter facts are being picked up twice, resulting in an error about a constant and the facts.d dir being parsed twice.
$ boxen
--> Preparing to auto-update...
--> Complete! Nothing new from upstream.
Fact file /opt/boxen/repo/facts.d/example.yaml was parsed but returned an empty data set
/opt/boxen/repo/shared/boxen/lib/facter/boxen_facts_d.rb:11: warning: already initialized constant BoxenFactsDirectoryLoader::EXTERNAL_FACT_WEIGHT
/opt/boxen/repo/modules/boxen/lib/facter/boxen_facts_d.rb:11: warning: previous definition of EXTERNAL_FACT_WEIGHT was here
Fact file /opt/boxen/repo/facts.d/example.yaml was parsed but returned an empty data set
Notice: Compiled catalog for [REDACTED] in environment production in 1.98 seconds

Is this intentional?

/opt/boxen/repo/modules/boxen/ shouldn't exist; it certainly doesn't in this repo: https://github.com/boxen/our-boxen/tree/master/modules
You can safely remove that directory, which will fix the warning.

I think it got pulled in in one of the librarian-puppet runs. I'll rebuild from scratch and verify.

@eugeneius looks like it gets pulled in as part of the librarian-puppet run when trying to update to current our-boxen per the FAQ*. This seems like either the Puppetfile should not include boxen and the module should just be part of shared or it shouldn't be in shared.

https://github.com/boxen/our-boxen/blob/master/docs/faq.md#q-how-do-you-upgrade-your-boxen-from-the-public-our-boxen

It looks like that FAQ entry is wrong.
When you run the boxen command, it tells librarian-puppet to install modules into the shared/ directory:
https://github.com/boxen/boxen/blob/2.8.0/lib/boxen/puppeteer.rb#L105
The FAQ entry is telling you to run librarian-puppet without passing the --path option, which means it will use the default path for modules - which is modules/:
https://github.com/rodjek/librarian-puppet/blob/v1.0.9/lib/librarian/puppet/environment.rb#L20
I've never run into this problem because I always run boxen, whether I'm integrating upstream changes or making them myself.
Do you want to submit a pull request adding that flag to the command in the FAQ?

@eugeneius That would be great if you could! :tada:

I was suggesting that @jarrettone could do it... but okay :grin: https://github.com/boxen/our-boxen/pull/811

ah, my apologies! thanks.

Apologies gents, been away for a while. Toddlers are time thieves.
I was about to say that I'll gladly update the faq, but @eugeneius beat me to it. @jacobbednarz any chance on getting that merged in the not-too-distant? Is there more that needs to be done here to get it merged?

Consider it done. Thanks! :)


feat(search): Add word gram analyzer for name fields

Checklist

[ ] The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
[ ] Links to related issues (if applicable)
[ ] Tests for the changes have been added/updated (if applicable)
[ ] Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
[ ] For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

Failing cypress test passes locally, so I am landing this


spawn agents

a road with two lane, self._ds_min, self._ds_max = 7, 12
for left lane, self._s_min, self._s_max = 3, 44
for other one, self._s_min, self._s_max = 3, 26
there should are only 8 agents generated in observation of the world, but it is learned from the simplified output printed that 9 agents were generated.
{0: bark.agent.Agent, 1: bark.agent.Agent, 2: bark.agent.Agent, 3: bark.agent.Agent, 4: bark.agent.Agent, 6: bark.agent.Agent, 7: bark.agent.Agent}
{0: bark.agent.Agent, 1: bark.agent.Agent, 2: bark.agent.Agent, 3: bark.agent.Agent, 4: bark.agent.Agent, 5: bark.agent.Agent, 7: bark.agent.Agent, 8: bark.agent.Agent, 9: bark.agent.Agent}
Traceback (most recent call last):
  File "/home/tinmode/.cache/bazel/_bazel_tinmode/0534ffbce5f0177dc35c2eb30e06c204/execroot/bark_ml/bazel-out/k8-fastbuild/bin/examples/tfa_gnn.runfiles/bark_ml/examples/tfa_gnn.py", line 88, in <module>

...

  File "/home/tinmode/.cache/bazel/_bazel_tinmode/0534ffbce5f0177dc35c2eb30e06c204/execroot/bark_ml/bazel-out/k8-fastbuild/bin/examples/tfa_gnn.runfiles/bark_ml/bark_ml/environments/single_agent_runtime.py", line 56, in reset
    return self._observer.Observe(observed_world)
  File "/home/tinmode/.cache/bazel/_bazel_tinmode/0534ffbce5f0177dc35c2eb30e06c204/execroot/bark_ml/bazel-out/k8-fastbuild/bin/examples/tfa_gnn.runfiles/bark_ml/bark_ml/observers/graph_observer.py", line 122, in Observe
    edge_features[index, target_index, :] = self._extract_edge_features(agent, nearby_agent)
IndexError: index 8 is out of bounds for axis 1 with size 8

I have been confused about it after checked out the config_with_ease.pyto generate agents several times.
I'll appreciate it if you could make it clear.

The agents are sampled in the distance, have a look at the ConfigWithEase scenario generation.
In these two spots sampling is being applied:

https://github.com/bark-simulator/bark/blob/1d5f788fa1a58d3d74c0b935b89a3764d5b5c837/bark/runtime/scenario/scenario_generation/config_with_ease.py#L133

https://github.com/bark-simulator/bark/blob/1d5f788fa1a58d3d74c0b935b89a3764d5b5c837/bark/runtime/scenario/scenario_generation/config_with_ease.py#L92

If you want a deterministic scenario, I would recommend you to overwrite the def position(self, world): function that does not make use of sampling and a call to self.ds(). However, in terms of training varying scenarios are hugely beneficial to no overfit on a single problem.

I have already checked the scenario generation quite many times, the maximum number of agents generated shoule be 8 by calculating instead of 9

how did you calculate this? I think only the rear point of the vehicle is used in the simple scenario generation (config with ease).
For more elaborate uses I would recommend using the ConfigurableScenarioGeneration.

the function position() of the LaneCorridorConfigclass define calculation of the number of agents to generate.
for left lane, self._s_min, self._s_max = 3, 44, with the minimum spacing self._ds_min=7, the number of agents which can be generated in the range (3, 44) is 5.
for right lane, self._s_min, self._s_max = 3, 26, with the minimum spacing self._ds_min=7, the number of agents which can be generated in the range (3, 26) is 5.

I assume you are talking about https://github.com/bark-simulator/bark-ml/blob/b9b42ab8124ab31781573b6a804e762271ca4ce6/bark_ml/environments/blueprints/merging/merging.py#L65
Have a look at the values in the blueprint. The ranges have been slightly changed in the latest push to make the traffic more realitistic.

Yeap, the value of sef._ds_minabove is from ds_min in densemode

here starting positions is at self._s_min, namely three, this is reason why the subtracter is 3 in the expression (26-3)//7=3 instead of zero

I cannot follow your calculation exactly. However, does it really matter if there are 8 or 9 vehicles generated?
Traffic also varies in reality by number and order. To trace the number during training and evaluation you could implement a vehicle count evaluator.
Will close this for now.


Mondrian problem when installing datachile thru pip

I keep getting this error when trying to install:
Could not find a version that satisfies the requirement mondrian_rest==0.1 (from datachile) (from versions: )
No matching distribution found for mondrian_rest==0.1 (from datachile)
can anyone help?

@kailkuhn  Are you using 0.0.6 version?

Yes we are, Carlos, and it still doesn't work. Full output:
pip install datachile

Collecting datachile
Using cached https://files.pythonhosted.org/packages/97/bb/67aeaab4fa0812813444194a84549a271136a1df9d8c4280e279f186937d/datachile-0.0.6.tar.gz
Collecting mondrian_rest==0.1 (from datachile)
Could not find a version that satisfies the requirement mondrian_rest==0.1 (from datachile) (from versions: )
No matching distribution found for mondrian_rest==0.1 (from datachile)

it seems that tests on the developers' machines, if they exist, are passing but datachile does NOT install on our machines.

Now should be ok @sergiolucero @kailkuhn
I uploaded mondrian-rest to pip and datachile v0.0.7 uses mondrian-rest

Installing mondrian-rest and then datachile 0.0.6 works but importing ChileCube from datachile shows ModuleNotFoundError: No module named 'mondrian_rest'
Installing datachile 0.0.7 instead shows   File "/Users/sebacea/anaconda3/lib/python3.6/site-packages/datachile/__init__.py", line 1     from mondrian-rest import Cube, MondrianClient                  ^ SyntaxError: invalid syntax
Finally, datachile 0.0.8 shows the same error as version 0.0.6`

Bumping this, I'm getting an error saying urllib does not exist, so it cannot install mondrian-rest.

I tried just now, pip tries to retrieve version 0.0.8 and fails on account of urlparse.

https://github.com/datachile/datachile-python-client/blob/master/datachile/chilecube.py
I fixed that in v.0.0.9. I hope that you can use datachile without problems @sergiolucero @tomcastro @sebacea .
Tell me more about if this error is persistent in new version. Thanks!

Have you pushed to pypi? I'm getting version 0.0.8
El lun., 28 may. 2018 17:28, Carlos Navarrete<EMAIL_ADDRESS>escribió:

https://github.com/datachile/datachile-python-client/blob/master/datachile/chilecube.py
I fixed that in v.0.0.9. I hope that you can use datachile without
problems @sergiolucero https://github.com/sergiolucero @tomcastro
https://github.com/tomcastro @sebacea https://github.com/sebacea .
Tell me more about if this error is persistent in new version. Thanks!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/datachile/datachile-python-client/issues/4#issuecomment-392605936,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AGzduZMwx4Z2iCt9iU36HXIs6Kfc758cks5t3Gv5gaJpZM4TvRR0
.

Same question as @sergiolucero, i'm not able to retrieve version 0.0.9
Collecting datachile==0.0.9
Could not find a version that satisfies the requirement datachile==0.0.9 (from versions: 0.0.1, 0.0.2, 0.0.3, 0.0.4, 0.0.5, 0.0.6, 0.0.7, 0.0.8)
No matching distribution found for datachile==0.0.9

Tested and working!


Override path

This PR adds the possibility to override the request path via $path parameter, similar to existing $domain parameter.
The path can be overridden by a simple string or by callback (the latter is not possible for $domain).

@sbusch merged and published as 1.6.0


Feature/40 establish system tests

Performs work towards #40 by establishing the capability to add and run system specs. This PR also includes a very simple, example spec (SomethingSpec) that should be removed at some point.

We will want to add SELENIUM_REMOTE_HOST=localhost to the CircleCI config. https://github.com/OfficeMomsandDads/scheduler/blob/08e8979774e60d52bebea538e608ed25be912a27/.circleci/config.yml#L7-L15
We will also want to add the Selenium image to the CircleCI config as well. - image: selenium/standalone-chrome after the Postgres image and config.
https://github.com/OfficeMomsandDads/scheduler/blob/08e8979774e60d52bebea538e608ed25be912a27/.circleci/config.yml#L16-L20

@benjaminwood when you have a chance we would appreciate you taking a look at this PR.