Feature Idea: Enable shell scripts to be pre-processed into orb commands

Just an idea here...
I HATE writing significant shell commands in yaml.  I always make typos, and the lack of syntax highlighting is a drag.
So here's an idea: what if we could write some of our commands in a .sh file, then pre-process them into our orb's commands, with args mapped to the command's parameters?
That way, we could even use something like shellcheck to validate our scripts before processing.

Hard to give an exact timeline but I am going to try to get to this soon.

@jrnail23
Simultaneously beginning to explore your original idea more in-depth. Do you have any vision of how you would expect that to look like?
So given we have a current structure such as:

/
-- src/
-- -- @orb.yml
-- -- commands/
-- -- -- myCommand.yml
-- -- jobs/
-- -- executors/

Where would be the best place to reference scripts from and how would you like that to look when writing your orb?
My initial thought is to go simple, with something like this:
We might theoretically have a special orb pack command which would intelligently pack our orb for us.

/
-- src/
-- -- @orb.yml
-- -- commands/
-- -- -- myCommand.yml
-- -- jobs/
-- -- executors/
-- -- scripts/
-- -- -- myScript.bash

Within an orb command's source, I imagine this could look like:
description: "This command was built with orb packing"

parameters:
  ...
steps:
  - run:
      name: "Long complex task"
      command: << scripts.myScript >>

Which after packing would expand to include the bash source directly within the command.
Another major benefit I see here is the ability to remove what we have previously called "internal" commands or "plumbing" commands. There are some orbs which have commands which are not truly meant to be used by the end-user but are created so they could be used within multiple other commands or jobs. With this addition, the user could reference the same script twice.
That would result in the code being "duplicated" in the processed result but I think it is still a better outcome.
CC @felicianotech (we were just talking about this)

@KyleTryon, what you're saying here about the special packing behavior is just what I had in mind.
I think one thing you didn't yet touch on is mapping parameters from the command to the script.
With a decent declarative way to do that (I really hate positional params -- it's so easy to screw them up when you're refactoring), I think this would be a killer feature.

@jrnail23 We're nearing completion of a command within the CLI do to exactly this, I would be more than happy to grab a compiled binary for you to test. Otherwise you can build it yourself from this branch :) https://github.com/CircleCI-Public/circleci-cli/tree/orb-pack

@gmemstr, this is great news. Thanks!

@gmemstr, I think I'd like to take you up on your offer of a compiled binary... I figured I'd do it myself, but then I remembered how lost I am in GoLang world!

@jrnail23 I'm working on getting built binaries for an open beta, I'll be sure to ping you when they're ready!

@jrnail23 You can find more information here :) https://discuss.circleci.com/t/circleci-cli-orb-pack-beta/36598

@gmemstr, is the expectation that we'd pass in params like this?
- run: << include(scripts/hello-world.sh) >> "<<parameters.param0>>" "<<parameters.param1>>"

Just some maintenance, closing this up as we do have this now 👍
Read more here:

https://circleci.com/docs/2.0/orb-concepts/?section=configuration#file-include-syntax
https://circleci.com/docs/2.0/orb-author/


VSCode incredibly slow, 100% CPU usage, coming from electron_node tsserver.js CPU usage

VSCode Version: 1.48.0
OS Version: iOS Catalina 10.15.5

Steps Attempted to Resolve issue:

Disable all extensions except typescript/javascript features
Install JS and TS Nightly extension as recommended
Downgrading to previous version of VSCode (1.32.0)
Installing latest VSCode Insiders
Increased max memory allowed by typescript server
Check to make sure no extension takes more than 100ms to load

Additional Info
The project is 200k lines and smaller projects do not have the issue. Its primarily related to typescript because if I disable the built-in javascript/typescript features then the tsserver doesn't spin up, so no problem.

The hovering types are almost always at "loading..." state.
Cmd Clicking into types to see what they are is also insanely slow and practically unusable
Autocomplete is incredibly slow, and often nonexistent, even for basic commands like 'clo' for console.logs
Red error lines from intellisense are 2-5min lagging behind my actual changes. its like vscode is hung up

If I open the project freshly, find an object, and change a variable to gibberish, then it will take several minutes for VSCode to complain to me with intellisense. Simply saving, and running the app in the browser with auto-reload is faster because chrome will show me compile errors
Below is the result of running ps aux | grep [number]:
jfarris          90151 100.8  1.6  7160436 550880   ??  R     9:30AM   9:16.20 /Applications/Visual Studio Code.app/Contents/Frameworks/Code Helper (Renderer).app/Contents/MacOS/Code Helper (Renderer) --max-old-space-size=8072 /Users/jfarris/Documents/amaro-ui/node_modules/typescript/lib/tsserver.js --useInferredProjectPerProjectRoot --disableAutomaticTypingAcquisition --enableTelemetry --cancellationPipeName /var/folders/mg/97w2bx6d1fqdkyd9bmyh6sd00000gp/T/vscode-typescript502/31ba41063dba52b8428d/tscancellation-0b463b00b389646856b1.tmp* --globalPlugins typescript-vscode-sh-plugin --pluginProbeLocations /Applications/Visual Studio Code.app/Contents/Resources/app/extensions/typescript-language-features --locale en --noGetErrOnBackgroundUpdate --validateDefaultNpmLocation

jfarris          92342   0.0  0.0  4408572    816 s002  S+    9:40AM   0:00.00 grep --color=auto --exclude-dir=.bzr --exclude-dir=CVS --exclude-dir=.git --exclude-dir=.hg --exclude-dir=.svn --exclude-dir=.idea --exclude-dir=.tox 90151

Below is the process explorer - notice the tsserver.js using more than 100%. This happens when  turning on VSCode > it then slows down to normal number > then i start editing in VSCode and it jumps back up > it stays up for 2-3min AFTER I've stopped editing > then finally slows down. But sometimes it just stays at 100 even 5+ min after I've finished editing

Below is the CPU usage from the activity monitor

Does this issue occur when all extensions are disabled?: Yes/No

@sheetalkamat It looks like there are a few long running calls to updateOpen that may explain this:
Info 517  [12:40:1.211] Open files:
Info 517  [12:40:1.211] 	FileName: /Users/jfarris/Documents/amaro-ui/src/pages/DCT/NodeDiagram/NodeHeaderMenu/NodeHeaderMenu.tsx ProjectRootPath: /Users/jfarris/Documents/amaro-ui
Info 517  [12:40:1.211] 		Projects: /Users/jfarris/Documents/amaro-ui/tsconfig.json
Perf 517  [12:40:1.211] 2::updateOpen: elapsed time (in milliseconds) 88175.9739

Looks like there's around 1060 files but shouldn't cause an 80-second load time.
@jfarris587 that log looks like 3.9.7 though. Does that mean you're seeing the same issue regardless of the nightly extension?

Looks like there's around 1060 files but shouldn't cause an 80-second load time.
@jfarris587 that log looks like 3.9.7 though. Does that mean you're seeing the same issue regardless of the nightly extension?

Yes, with or without the nightly extension it produces the problem

This happened to me right after I ran yarn add antd @ant-design/icons react-copy-to-clipboard and tsserver.log was filled with messages like this:
Info 56630[14:32:44.20] Elapsed:: 33ms DirectoryWatcher:: Triggered with<EMAIL_ADDRESS>:: WatchInfo: /Users/davidmcnamee/dev/aritzia-notifier/node_modules 1 undefined Project: /Users/davidmcnamee/dev/aritzia-notifier/chrome/tsconfig.json WatchType: Failed Lookup Locations
Info 56631[14:32:44.20] DirectoryWatcher:: Triggered with<EMAIL_ADDRESS>:: WatchInfo: /Users/davidmcnamee/dev/aritzia-notifier/node_modules 1 undefined Project: /Users/davidmcnamee/dev/aritzia-notifier/chrome/tsconfig.json WatchType: Failed Lookup Locations
Info 56632[14:32:44.60] Elapsed:: 40ms DirectoryWatcher:: Triggered with<EMAIL_ADDRESS>:: WatchInfo: /Users/davidmcnamee/dev/aritzia-notifier/node_modules 1 undefined Project: /Users/davidmcnamee/dev/aritzia-notifier/chrome/tsconfig.json WatchType: Failed Lookup Locations

Installed  1.47 (https://code.visualstudio.com/updates/v1_47) and problem went away.
Running
VSCode Version: 1.48.1 (before downgrade)
OS Version: iOS Catalina 10.15.6

@DanielRosenwasser @mjbvz any progress?

I guess my issue may be related, in the process explorer I can see multiple electron_node package.js processes consuming a lot of CPU and vscode runs ultra slow. It happens only when I am typing and so far on a specific javascript project. Should I open a new issue or post log here?
Version: 1.48.2 (user setup)
Commit: a0479759d6e9ea56afa657e454193f72aef85bd0
Date: 2020-08-25T10:13:11.295Z
Electron: 7.3.2
Chrome: 78.0.3904.130
Node.js: 12.8.1
V8: 7.8.279.23-electron.0
OS: Windows_NT x64 10.0.19041

I have used the newest version for the whole day:
Version: 1.49.0
Commit: e790b931385d72cf5669fcefc51cdf65990efa5d
Date: 2020-09-10T17:39:53.251Z
Electron: 9.2.1
Chrome: 83.0.4103.122
Node.js: 12.14.1
V8: <IP_ADDRESS>-electron.0
OS: Darwin x64 19.6.0
And I haven't noticed the behaviour yet

Hi there. I can share a file on which issue reproduces stable for me: https://github.com/aleksei-berezkin/fluent-streams/blob/master/src/impl/indexImpl.str.test.ts
Observed behavior: whenever I edit a file in VSCode, a process running tsserver.js starts a work consuming 100% of CPU, and it takes about 12–14 seconds on my machine to complete. (MacBook Pro with 16 GB RAM and i7). This reproduces on each edit.
I made a small research and found out that it's likely type inference triggered by getSemanticDiagnostics. I can take additional profile or dump if you wish.

CocServer for vim also use 100% CPU

@aleksei-berezkin do you still see this with typescript@next . If yes can you please share the tsserver log and time around which you see the issue so i can see whats happening in the log and repro it with your code base.
@jfarris587 is this reproing still witg typescript@next. If yes tsserver log would be useful. Thank you.

@aleksei-berezkin do you still see this with typescript@next . If yes can you please share the tsserver log and time around which you see the issue so i can see whats happening in the log and repro it with your code base.
@jfarris587 is this reproing still witg typescript@next. If yes tsserver log would be useful. Thank you.

There are a number of community packages that seem to commonly cause sluggishness and high CPU usage from TS. For me this is mobx-state-tree. In my project I have consistently very high CPU usage from TS and slow (5-10 second) autocomplete, go-to, and error highlighting. Other common culprits seem to be rxjs, MUI, ramda, xstate, and styled-components. Are those of you having problems using any of these dependencies?

There are a number of community packages that seem to commonly cause sluggishness and high CPU usage from TS. For me this is mobx-state-tree. In my project I have consistently very high CPU usage from TS and slow (5-10 second) autocomplete, go-to, and error highlighting. Other common culprits seem to be rxjs, MUI, ramda, xstate, and styled-components. Are those of you having problems using any of these dependencies?

This has been solved.
My tsconfig.json had includes which contained file paths that did not exist in the particular repo, causing an infinite loop of trying to open files in that directory that didn't exist I suppose

if you know what you are doing, just disable all Windows Defender

use a firewall gui like GlassWire in order to always know how to manage your outgoing connections by application

and adjust your indexing options :

then there are the pros of viral signing, the middlemen, and those who think it's pointless. It all depends on how much attention you pay to your system. If in doubt, sandbox, vm.

I have solve my case, take a look: https://stackoverflow.com/questions/71516186/vs-code-uses-100-cpu-even-if-it-is-closed/72518926#72518926

Couple of things:

use auto-cpufreq
use multiple workspace during developments (E.g: keep vscode and browser in separate workspace)
use zram
schedule restart system-udevd after 1 min and make it a service


Setting to disable GLTF previewer

Some users are reporting that they can't use other GLTF related extensions, and the only way to use them is disabling the whole DCL Editor extension. Having a setting to just disable that part would allow users to keep using the DCL editor with a different GLTF previewer/tooling.

Closing this issue since this can be workarounded by right clicking on the GLTF in the "Open Editors" section and selecting "Reopen Editor With..." and then selecting the editor that the user wants to use (ie. Text Editor, so glTF tools can be used from there).
https://user-images.githubusercontent.com/2781777/212339763-08b5b342-b22c-4d34-b7dd-be4b09437e04.mp4


[BEAM-2807] Fixes NPE exception on CoderTypeSerializerConfigSnapshot serialization

Follow this checklist to help us incorporate your contribution quickly and easily:

[x] Make sure there is a JIRA issue filed for the change (usually before you start working on it).  Trivial changes like typos do not require a JIRA issue.  Your pull request should address just this issue, without pulling in other changes.
[x] Each commit in the pull request should have a meaningful subject line and body.
[x] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue.
[x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[x] Run mvn clean verify to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

https://issues.apache.org/jira/browse/BEAM-2807
When a Coder is created as an anonymous class, passing it to CoderTypeSerializer will cause a NullPointerException when the write call is called on CoderTypeSerializerConfigSnapshot
This is because the coderName field is being set by calling getCanonicalName, which will always return null for anonymous classes.
Note: I am not sure if this change is destructive or not, but it appears to me the coderName is just metadata that is written to the stream, and is not used for anything else?

Coverage decreased (-0.007%) to 69.67% when pulling 9e337da5b89aadf32f4f85925b597d72995dd551 on djhworld:BEAM-2807 into e9d3a4a799a43a3a9d73527d83ead143b7a66fda on apache:master.

CC @aljoscha

Coverage decreased (-0.003%) to 69.673% when pulling 1a6457afc7479a7f8a7daec7f4efe5c896c62f4b on djhworld:BEAM-2807 into e9d3a4a799a43a3a9d73527d83ead143b7a66fda on apache:master.

@aljoscha thanks for the input 😄
I think the beam-codestyle.xml config is causing the annotations to do that in IntelliJ when you hit reformat code, have put the annotations on newlines now though
I've refactored the test to include writing+reading the snapshot as well, which works.

Run Flink ValidatesRunner

Thanks for updating, I'm currently at https://berlin.flink-forward.org so my responses are a bit slow. Sorry for that.

Thanks again for debugging and fixing this! 😃 I just merged.


bqsr small tweaks

small tweaks to a few bqsr classes. It was intended to solve #189 but I don't know what the answer is. @droazen please review. Unless someone else figures out the LEFT_TAIL mystery, I'll assume it's a stale comment and let's delete it.

Coverage decreased (-0.02%) to 70.35% when pulling 06121ab32a06c772bfc3f465d199b3d7c0599e85 on ak_left_tail_bqsr into eff7d0f596502c4425366fad1985e6a1d5ad0542 on master.

One minor javadoc issue then good to merge

Coverage decreased (-0.02%) to 71.56% when pulling 0a56a60a5fcb98c5f5aec9c1569102e4b0578696 on ak_left_tail_bqsr into a9108a615a8a87bd6e13b847508f9fb2b8115f85 on master.


Minimizing API surface area by removing some methods

I've watched a great talk by @sebmarkbage http://www.youtube.com/watch?v=4anAwXYqLG8 lately, and also work on a React+Flux project with relatively large amount of boilerplate code. And after thinking about it for some time I'm convinced that boilerplate code is not a problem at all, as far as it stays simple.
Kefir has some methods that are basically short hands for two lines of boilerplate code, and I now think it was a mistake to introduce them. It doesn't worth it to maintain docs/tests for them, and also library users will only benefit from not having them.
For example we have .tap which can be easily replaced by .map. Compare this two code snippet:
stream.tap(function(x) {
  sideEffect(x);
});

stream.map(function(x) {
  sideEffect(x);
  return x;
});

First of all, do we need .tap when .map works just fine for this use case? But also, which snippet is easier to understand if you didn't read docs for neither .map nor .tap? To me it pretty clear what happening in .map version, but for .tap I'd better check the docs.
So I think we should remove some methods from the API, here is the list:

repeatedly (alternative Kefir.repeat(function() {return Kefir.sequentially(/*...*/)}))
mapTo
pluck
invoke
not
timestamp
tap
and
or

Of course the removing won't be fast to not break existing code, I think we'll only deprecate them now, but remove only in v3.0.0 or later.

I love the idea behind http://moutjs.com/:
every piece of code or simple functions are own modules, so you need to include them, if you use them. the resulting bundle.js (if you are using browserfy) is minimal, based on used features.
why not use this pattern?
want only use streams, just require('kefir/streams')
ahh need tap? just require('kefir/utils/tap') oder just require('kefir/utils')

The file size isn't my concern here. For short answer we just don't need these methods, for long re-read my original comment :)

Haven't watched the video, skimmed the transcript, just barely starting with Kefir.
One of the things I really like is how these convenience methods (tap, or, and, etc.) provide built-in documentation for code written using them.
I checked out Kefir a while ago and back then I did feel like the library had a high api surface area.  However, coming back to it more recently helped me cement my understanding of streams, particularly because the api provides a good translation between English and the impact of each method on the streams. The excellent documentation helps with this too.
If you decide to ditch the convenience methods, please consider maintaining a separate library that will add them back in when included.

Deprecated methods now warn in console when called.
Docs on deprecated methods moved to separate file https://github.com/pozadi/kefir/blob/master/deprecated-api-docs.md

I'll release a minor version with this changes a bit later.

I think keeping the API small and simple is the way to go. Anything needed can be plugged into a map function. I personally like to use Ramda in combination with Kefir. With Ramda it's easy to move the deprecated functionality into the map function itself, where it belongs. Instead of observable.pluck('x') it would become observable.map(R.pluck('x'))

Just a 2c, I like how much quicker this parses
x.pluck('y')

than
x.map(R.pluck('y'))

There's something fluid about dropping in a .log() or .tap() anywhere in the plumbing for quick tests. Since FRP is meant to be temporally aware, timestamp() also feels pretty much a shared idiom.
However I also agree that it's nice to separate fundamental FRP-like concerns from, on one hand, shorthands, and on the other hand, other FP features such as transducers and generic FP like Ramda (a lot of FRP functions can be built up with a basic FRP plus transducers).
So maybe we can have the cake and eat it too, if the user of the Kefir library can say, e.g.,
Kefir.Observable.prototype.tap = function(fun) {
    return this.map(function(x) {
        fun(x);
        return x;
    };
};

which is how it's implemented now, and Kefir.Observable is exported, so it's legal.
By the way, one of the things I like in Ramda, Highland etc. too is that they have large vocabularies, and so do Underscore, d3.js and most popular JS libraries.

I think we should proceed and remove Kefir.fromSubUnsub()

remove Kefir.fromSubUnsub()
done in v2 branch

Some deprecated methods were quite nice for me, since for me they make code readable indeed.
Like .mapTo, yes—it's the shortcut for just a two-liner, but when you re-use a code, you find yourself in desire to wrap some repeating lines in a function, consider:
streamOfTwo.map(function(x) { return 2; });
streamOfThree.map(function(x) { return 3; });
streamOfFour.map(function(x) { return 4; });

and:
streamOfTwo.mapTo(2);
streamOfThree.mapTo(3);
streamOfFour.mapTo(4);

and:
function toValue(value) { return ( function() { return value; } ) }
streamOfTwo.map(toValue(2));
streamOfThree.map(toValue(3));
streamOfFour.map(toValue(4));

Which one is nicer?

This will look nicer with arrow functions stream.map(() => 2), and before that you can either use deprecated method or define your own helpers.

Yeah, with arrows its the nicest way!

Babel ftw :metal:

👎 for removing tap
It's a great debugging tool.
Now instead of x.tap(x => console.log(x)) we have to x.map(x => console.log(x); return x)
spy solves it partially but is not customizable (for example, I want to do next and it's only possible with map now)`
console.log(even.target)
console.log(even.target.attributes)
console.log(even.target.attributes.href)

You can write x.map(x => console.log(x); return x) as x.map(x => console.log(x), x) :)

Alternatively, you can bring it back yourself by writing your own helper function and using thru:
const tap = fn => obs => obs.map(x => (fn(x), x)).setName(obs, 'tap')

Usage:
obs.thru(tap(x => { /* do whatever */ }))

Yep. I just think those few bytes of tap was pretty worth it. It wasn't the best candidate to remove IMO.

This is not really about bytes. IMO, making API as small as possible is beneficial for learning (see the video in original comment). Also tap encourages to add side effects into transformation chains, which is a bad practice. Side effects should live in observers.

Also tap encourages to add side effects into transformation chains, which is a bad practice. Side effects should live in observers.

Yes, but it's not true in ALL scenarios. I'm aware of couple of cases where it's really better to make side effects in tap. Debugging is just one of them. Anyway, it's not the biggest issue for me and I respect your right to have a different opinion.


Looping over files with spaces.

Hi, I've been looking through #216 and related information, including the use of IFS in BASH. Unfortunately, after countless attempts, I can't seem to get it to work with this action. I'm not sure if it's an issue with this action, a behavior of GitHub actions, or an error in my implementation.
I'm opening this issue because I tried the same script on my Ubuntu server and it worked like a charm.
Attempt
name: pdf render

on:
  push:
    paths:
      - '**/**.md'

jobs:
  render:

    runs-on: ubuntu-latest

    steps:
      - name: Checkout repository code
        uses: actions/checkout@v3
        with:
          fetch-depth: 0

      - name: Get changed files
        id: changed-files
        uses<EMAIL_ADDRESS>        with:
          files: "**/**.md"
          separator: ","

      - name: List all changed files
        run: |
          echo ${{ steps.changed-files.outputs.all_changed_files }}
          IFS=","
          echo ".$IFS."
          for file in ${{ steps.changed-files.outputs.all_changed_files }}
          do echo $file was changed
          done
          unset IFS

Response
Folder/Sub Folder/First Markdown File.md,Folder/Other Subfolder/Another Markdown File.md
.,.
Folder/Sub was changed
Folder/First was changed
Markdown was changed
File.md was changed
Folder/Other was changed
Subfolder/Another was changed
Markdown was changed
File.md was changed

Expected
Folder/Sub Folder/First Markdown File.md,Folder/Other Subfolder/Another Markdown File.md
.,.
Folder/Sub Folder/First Markdown File.md was changed
Folder/Other Subfolder/Another Markdown File.md was changed

It seems the IFS is being changed because when I echo ".$IFS." after setting IFS=",", the shell prints .,. as expected. But when I loop, no change.
As I mentioned earlier, I tried this on my own Ubuntu server and it worked
output="Folder/Sub Folder/First Markdown File.md,Folder/Other Subfolder/Another Markdown File.md"
IFS=","
for file in $output
do echo $file
done
unset IFS

Which outputted...
Folder/Sub Folder/First Markdown File.md was changed
Folder/Other Subfolder/Another Markdown File.md was changed

Here is a shell recording of this working on WSL Ubuntu.

I apologize if I missed something basic and opened an issue when unnecessary. That said, I've tried countless variations of the script and looked through pretty much every mention of "space" and "IFS" in this repo and codebase, and haven't been able to resolve the issue. When the same script worked on my Ubuntu server, I decided it best to open this "issue." Thanks sincerely for any help.

@preritdas Can you try using IFS=$',' instead ?

Didn't work, sadly. Same code but IFS=$',' instead of IFS=",".
Output:
Folder Space/Sub Folder/File With Spaces.md
.,.
Folder was changed
Space/Sub was changed
Folder/File was changed
With was changed
Spaces.md was changed

Can you also put quotes around the output
…
      - name: Get changed files
        id: changed-files
        uses<EMAIL_ADDRESS>        with:
          files: "**/**.md"
          separator: ","

      - name: List all changed files
        run: |
          echo ‘${{ steps.changed-files.outputs.all_changed_files }}‘
          IFS=$','
          for file in “${{ steps.changed-files.outputs.all_changed_files }}“
          do echo “$file was changed”
          done
          unset IFS

No cigar unfortunately. When wrapping the output in quotes, the entire output is treated as one file. Output below.
Folder Space/Sub Folder/Markdown File.md Another Folder/Another Sub/Another Markdown.md Folder Three/More Stuff/Important File.md Nothing To/See Here/Nuclear Codes.md
.,.
Folder Space/Sub Folder/Markdown File.md Another Folder/Another Sub/Another Markdown.md Folder Three/More Stuff/Important File.md Nothing To/See Here/Nuclear Codes.md was changed

@preritdas Seems you'll need to tweak the code you have to resolve the error
For example, you'll need to use
...
      - name: List all modified files
         run: |
           IFS=$',' read -a MODIFIED_FILES_ARRAY <<< "${{ steps.changed-files-comma.outputs.modified_files }}"
           for file in "${MODIFIED_FILES_ARRAY[@]}"; do
             echo $file
           done
           unset IFS
         shell:
           bash

See this PR for more information.

Yep, that does the trick. I appreciate the help.


404 code?

I am getting a 404 after "Ask GPT" and setting the API key successfully. Any ideas?

Are you using the davinci model?
This model has been depreciated by OpenAI. Updating the plugin now to no longer support it.

No, GPT4 and GPT4o.

The only things I can think of that would cause a 404 are if the model does not exist (which the newest version should've just fixed) or if the API key is broken.
I'll keep investigating but for now I would make sure the plugin is up to date and ensure that the API key works.

same problem.
I followed the instructions and setup successfully but it shows 404 error after "Ask GPT".

Thanks for reporting this issue, I'll try my best to get to the bottom of this.
Do you know which version of VSCode you are using (Can go to Help > About to check)? And what version of the extension, as well as, the configuration (output mode, model, etc)?

Vscode:
Version: 1.90.1 (user setup)
Commit: 611f9bfce64f25108829dd295f54a6894e87339d
Date: 2024-06-11T21:01:24.262Z
Electron: 29.4.0
ElectronBuildId: 9593362
Chromium: 122.0.6261.156
Node.js: 20.9.0
V8: 12.2.281.27-electron.0
OS: Windows_NT x64 10.0.17763
Extension:
GPT
v0.4.4
Set API Key-> showed set API key successfully
Change Model -> GPT-4o(default)
Change Token Limit->1000000
If there is any other information you need to know or you want me to execute something to identify the problem, please let me know.
Thank you.

I'm guessing

Change Token Limit->1000000

is just a typo, since it caps at 128_000.
Just updated the extension. Now it uses axios (HTTPS requests) instead of the OpenAI library and has some slightly better error handling. Please update the extension and lmk if AskGPT now works or if not what it's returning.

just uninstall and reinstall the extension.
it is now GPT v0.4.6
And did the setting below again:
Set API Key-> showed set API key successfully
Change Model -> GPT-4o(default)
Change Token Limit->128000
below is the result after AskGPT

I just added a debug mode, so please update the extension again (should be v0.4.7). Then before using AskGPT, turn on Debug mode (using GPT: Change Debug Mode), open the output panel (View > Output or Ctrl+Shift+U), click on the drop down menu in the upper right corner of the output panel and select the GPT Debug channel. Now when you run AskGPT you should see the debug logs, please paste them in here (p.s. remove the API key from the logs)

Thank you for your patience. Very strange. Everything looks correct in the request, 404 means "Not found", but the url and headers all look right.
Can you try running: curl https://api.openai.com/v1/models -H "Authorization: Bearer YOUR_API_KEY" in the terminal/Command Prompt. Here you should see the gpt-4o model:
    {
      "id": "gpt-4o",
      "object": "model",
      "created":<PHONE_NUMBER>,
      "owned_by": "system"
    },

hmm... didn't see the gpt-4o model somehow.
So in order to use gpt-4o model, I have to activate the paid  gpt-4o model API first? I thought there are some daily free limited messages to use though.
{
"object": "list",
"data": [
{
"id": "whisper-1",
"object": "model",
"created":<PHONE_NUMBER>,
"owned_by": "openai-internal"
},
{
"id": "dall-e-2",
"object": "model",
"created":<PHONE_NUMBER>,
"owned_by": "system"
},
{
"id": "gpt-3.5-turbo-16k",
"object": "model",
"created":<PHONE_NUMBER>,
"owned_by": "openai-internal"
},
{
"id": "tts-1-hd-1106",
"object": "model",
"created":<PHONE_NUMBER>,
"owned_by": "system"
},
{
"id": "tts-1-hd",
"object": "model",
"created":<PHONE_NUMBER>,
"owned_by": "system"
},
{
"id": "gpt-3.5-turbo-instruct-0914",
"object": "model",
"created":<PHONE_NUMBER>,
"owned_by": "system"
},
{
"id": "gpt-3.5-turbo-instruct",
"object": "model",
"created":<PHONE_NUMBER>,
"owned_by": "system"
},
{
"id": "text-embedding-3-small",
"object": "model",
"created":<PHONE_NUMBER>,
"owned_by": "system"
},
{
"id": "tts-1",
"object": "model",
"created":<PHONE_NUMBER>,
"owned_by": "openai-internal"
},
{
"id": "text-embedding-3-large",
"object": "model",
"created":<PHONE_NUMBER>,
"owned_by": "system"
},
{
"id": "babbage-002",
"object": "model",
"created":<PHONE_NUMBER>,
"owned_by": "system"
},
{
"id": "gpt-3.5-turbo-0125",
"object": "model",
"created":<PHONE_NUMBER>,
"owned_by": "system"
},
{
"id": "tts-1-1106",
"object": "model",
"created":<PHONE_NUMBER>,
"owned_by": "system"
},
{
"id": "gpt-3.5-turbo",
"object": "model",
"created":<PHONE_NUMBER>,
"owned_by": "openai"
},
{
"id": "dall-e-3",
"object": "model",
"created":<PHONE_NUMBER>,
"owned_by": "system"
},
{
"id": "text-embedding-ada-002",
"object": "model",
"created":<PHONE_NUMBER>,
"owned_by": "openai-internal"
},
{
"id": "davinci-002",
"object": "model",
"created":<PHONE_NUMBER>,
"owned_by": "system"
},
{
"id": "gpt-3.5-turbo-1106",
"object": "model",
"created":<PHONE_NUMBER>,
"owned_by": "system"
}
]
}

Huh, I thought GPT-4o was also free with limits through the API but I guess not:
"After you have made a successful payment of $5 or more (usage tier 1), you'll be able to access the GPT-4, GPT-4 Turbo, and GPT-4o models via the OpenAI API." Link
I'll add something later to error messages to make that clearer, sorry. But if you use GPT-3.5-Turbo it works?

I changed to 3.5 turbo but it says I reached the limits...
is there any limit with 3.5 turbo?

Yes, that error message means you received a 429 error code, which means "Rate limit reached for requests" (can read more about the errors here), but that's very weird if you haven't made a single request. I believe every model has usage limits and you can your usage/limits here here

I just registered this new account on open.ai today and didn't even ask anything on open.ai too so it's impossible to have any request.

Is it that I made too many 404 bad requests so the api blocked my requests for a while...?

I wanna say I highly doubt it but ig it could be the case. You could find out for sure by creating an entirely new account and trying.

very weird. I changed another api key (from other account) but it still says I reached the limits.
idk if it blocked my IP temporarily or what, but I guess I will try it later or tomorrow then.

well...just tried and it is still the same somehow :(

That is very weird. The only way you can get that message though is if you reached a rate limit for requests.
You can try
curl https://api.openai.com/v1/chat/completions \
  -H "Content-Type: application/json" \
  -H "Authorization: Bearer YOUR_API_KEY" \
  -d '{
    "model": "gpt-3.5-turbo",
    "messages": [{"role": "user", "content": "Test"}]
  }'

in the terminal/Command Prompt and see if you get the same error. So error code should be 429 with "Rate limit reached for requests" message if you reached a rate limit.

It seems that the only free version is ChatGPT, the APIs aren’t (unless you have credits in your account)
The extension seems fine and I will get some credits to try it out later then.
Thank you so much for your help!

No problem! Thank you for making me aware of this problem and for your patience! Hope it works out :)


Move defaults to options package

Closes #31

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

38 of 42 (90.48%)  changed or added relevant lines in 6 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.5%) to 92.804%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

options/options.go
13
17
76.47%

Totals

Change from base Build<PHONE_NUMBER>:
-0.5%

Covered Lines:
619

Relevant Lines:
667

💛  - Coveralls


fix(dashboard): onLayoutChange needs allLayouts param

Summary

small fix to the onLayoutChange callback to pass back all the updated layouts

Change List (commits, features, bugs, etc)

Just pass the additional parameter

Acceptance Test (how to verify the PR)

You can verify that as you resize the main Dashboard story, if it's in the Editable state it calls out to onLayoutChange

:tada: This PR is included in version 1.68.2 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 2.0.0-beta.9 :tada:
The release is available on:

npm package (@beta dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Remove nested card in Status component

There's a nested card within the status component - if we could remove that so it's just one card, that would be rad! 🙏
http://storybook.backstage.io/?path=/story/status--default
Currently

Ideally

Done and Merged ✅

Closed via #832


lpushx with string array

Expected behavior
jedis.lpushx("key", "ok", "hello");
ERR wrong number of arguments for 'lpushx' command
Redis / Jedis Configuration
Jedis version: 2.9
Redis version: 3.0
Java version: 7

:D

redis supports only one parameter, but jedis client using variable length parameter

@JBearded that's not what the redis doc say http://redis.io/commands/lpush

@JBearded you're right. Mind opening a PR to fix it?


Error not compatible with @openzeppelin/contracts v4

Hi,
I use @openzeppelin/contracts (4.3.3) in my own contract which depend on solidity ^0.8.0.
Meanwhile this contract has a dependency on it too, but doesn't list it as a dep in package.json so it uses my project's version. It seems since 1.1.0 of this codebase you are using a vendor folder perhaps to mitigate this issue?
In the mean time would you advise maybe that I:
a) Change @openzeppelin/contracts to whatever older version used solidity 0.6
b) Install 1.2.0-alpha from GitHub (is it stable enough?). EDIT: Looks like this way isn't possible since openzep contracts are install as a git submodule
Thanks

I fixed this by forking 1.1.0 and using a local copy of openzeppeling 3.4.0 (had issues with node_modules one being picked up):
"@chainlink/token": "git+https://github.com/DominicTobias/LinkToken.git#1.1.0-fixed",


WebGL shader compilation errors are not logged

This would be helpful in general, and go a ways to help debug #65696
          > Perhaps we are still blocked on needing better instrumentation? Is there a bug open for that?

There's no specific issue open for it; I suggest opening a separate issue to track this.
It looks like there are two components to this:

GLSL errors are reported by the GLSL shader compiler (which itself is driver-specific), but WebGL fails to report any (look at the above screenshots, it tries to output an empty string below Vertex shader compilation failed:).

It looks like we can call glGetShaderInfoLog() in WebGL, like in desktop OpenGL. However, this doesn't work currently (this is what Emscripten does for us) so there is likely another issue at hand. In theory, there should be no need to add web-specific code here.

Logging format is inconsistent with RenderingDevice-based rendering methods (Forward+/Mobile). To resolve this, https://github.com/godotengine/godot/pull/37579 and https://github.com/godotengine/godot/pull/50537 need to be redone for the Compatibility rendering method. (I just checked and this particular issue occurs on desktop too when using Compatibility.)

Does the Godot steering committee plan to support Web as a first class compilation target for 4.x?

There's no steering committee to speak of. :slightly_smiling_face:
In open source, people work on what they want to work on, so there's no ETA for resolving this issue. We intend to keep supporting the web export, but we have relatively few contributors available to work on it. The web platform is also prone to a lot of third-party issues that contributors generally struggle dealing with, because they require specific hardware/software configurations (namely, macOS/iOS-only issues).
Originally posted by @Calinou in https://github.com/godotengine/godot/issues/65696#issuecomment-1793064506

I'll take a try at this and report back if I'm able to make progress or not.

I forgot to mention this in the other issue, but we need to make sure this doesn't occur only on macOS (which could hint at an issue with ANGLE on macOS, or macOS' own OpenGL -> Metal translation layer).
Since https://github.com/godotengine/godot/issues/65696#issuecomment-1793064506 doesn't occur on platforms other than macOS, this requires intentionally creating a shader error (e.g. by inserting invalid syntax here), compile an HTML5 export template, use it to export a project then open that project.

It appears to be more subtle that the experiment @Calinou proposes above.
My experiment:

inject error into shader code, as recommended
build godot from source at e38686f85b768a451dc06324fe2471adc8665448
install emscripten and build the web export template from source
export the repro game https://github.com/moribellamy/platonic-game/commit/fb72372b585cb56b61ef509b06bec555028b366e.
serve the repro game with platform/web/serve.py

The game loads fine in chrome. It does indeed emit the shader error you expect:

But when you go to slash the slime baddie, the game crashes in the usual way, as reported in https://github.com/godotengine/godot/issues/65696

the build i have cobbled together does at least emit the problematic code per the call _display_error_with_code(err_string, builder_string);. i'll see if i cant pull an actual compiler error out of this web

subscribe !84741

I've found nothing. The code which ought to give us a helpful error is here:
https://github.com/godotengine/godot/blob/64150060f89677eaf11229813ae6c5cf8a873802/drivers/gles3/shader_gles3.cpp#L332
Based on my reading and local experimentation, it is a correct query of the OpenGL runtime. I suspect whatever version of WebGL this gets compiled to (by emscripten) is omitting any helpful information about why the vertex is failing to compile.


Inconsistent string name and translation in strings.xml

The string name and translation comment seems not to match.
Please confirm whether it is correct or not, so that I can go on with Korean translation.
Kore/app/src/main/res/values/strings.xml at 285 line
<string name="confirm_artist_download">Are you sure you want to download all albums?\nThe albums will be downloaded in the background, but it can take a while to finish.</string>

It's correct - it refers to all albums of the artist.


1.14 'val' - behavioral change with numeric values

We have a number of selects where the values are numbers, e.g.,
<select>
<option value="0">None</option>
<option value="1">Foo</option>
<option value="8">Bar</option>
<option value="2">Baz</option>
</select>

Up to and including 1.13.18, we could call the 'val' method using a number, and it'd work; e.g.,
const value = 8;
$foo.selectpicker('val', value);

And Bar would be selected. With 1.14, we've got to call .toString() on the number for 'val' to recognize it as being a member of the set of valid values:
$foo.selectpicker('val', value.toString());

Unsure if this is really a bug or just how it should have worked in the first place, but the behavior has changed; can't seem to find any documentation speaking to it, so if it's the latter, a mention of it is probably worthwhile.

It's actually broken with anything that's not a string, e.g., boolean values. The issue arose in this commit(https://github.com/snapappointments/bootstrap-select/commit/fb5e1145521ef0bf6f4e3aae3e58cfbac43f4353), about 2 years ago, and the problem is this line, which is performing String conversion and then unfortunately just throwing away the result.
https://github.com/snapappointments/bootstrap-select/blob/939e94b14a34759e193f616b753e0a33081cc0c5/js/bootstrap-select.js#L3044
I believe a simple correction is just to change that line to:
value = value.map(String)


This repo name is same for conceptdev and xamarin

Github for windows won't download the other when already one is downloaded :)

You just need to clone it to a different directory on your local machine.


Test: Wait until all pods are ready

Fix #4612
Signed-off-by: Eloy Coto<EMAIL_ADDRESS>

This change is

test-me-please


docs: update guides for installing client and supernode

Codecov Report

Merging #85 into master will decrease coverage by 5.4%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master      #85      +/-   ##
==========================================
- Coverage   56.75%   51.35%   -5.41%
==========================================
  Files           4        4
  Lines          74       74
==========================================
- Hits           42       38       -4
- Misses         27       33       +6
+ Partials        5        3       -2

Impacted Files
Coverage Δ

dfdaemon/util/netutil.go
8.1% <0%> (-10.82%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3bb3aea...1680282. Read the comment docs.


[FLINK-9707] Support concurrent directory creations in LocalFileSystem

What is the purpose of the change
Support concurrent directory creations by accepting directories which have been
created by a different thread/process in LocalFileSystem#mkdirs.
Verifying this change

Added LocalFileSystemTest#testConcurrentMkdirs

Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
The serializers: (no)
The runtime per-record code paths (performance sensitive): (no)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
The S3 file system connector: (no)

Documentation

Does this pull request introduce a new feature? (no)
If yes, how is the feature documented? (not applicable)

+1

Thanks for the review @zentol. Merging this PR into master and release-1.5.


Add PauseOnStart Recording Option

Contributing to the Azure SDK
Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.
For specific information about pull request etiquette and best practices, see this section.
This change adds the pauseOnStart option for recordings in the call automation API. It is a small change

API change check
APIView has identified API level changes in this PR and created following API reviews.
Azure.Communication.CallAutomation


RL code disable

I am curious about the work in your paper, but I found that it is unavailable to the DQN implementation. Could you share the code about server.dqn and server.train?

We will release the DQN code soon.


Tiny typo in xaml code: views -> Views

Type of issue
Code doesn't work
Description
At the almost bottom of this
ContentTemplate="{DataTemplate views:AllNotesPage}"

should have been
ContentTemplate="{DataTemplate Views:AllNotesPage}"

With a capital V.
Page URL
https://learn.microsoft.com/en-us/dotnet/maui/tutorials/notes-app/?view=net-maui-8.0
Content source URL
https://github.com/dotnet/docs-maui/blob/main/docs/tutorials/notes-app/index.yml
Document Version Independent Id
720bf7f0-db92-f738-b864-ee149a02377b
Article author
@adegeo
Metadata

ID: 720bf7f0-db92-f738-b864-ee149a02377b
Service: dotnet-mobile
Sub-service: dotnet-maui

@EskeRahn I just went through these tutorials and made sure everything was up-to-date with .NET 8. The code works fine with a lowercase v. My guess is that you accidentally put an uppercase V in the xmlns import name of the .NET namespace:
<Shell
    x:Class="Notes.AppShell"
    xmlns="http://schemas.microsoft.com/dotnet/2021/maui"
    xmlns:x="http://schemas.microsoft.com/winfx/2009/xaml"
    xmlns:views="clr-namespace:Notes.Views"
    Shell.FlyoutBehavior="Disabled">


Add marker and sample counts to allelematrices

A data list item in the allelematrices response is currently defined as follows:
{            "name":"testDs1",          "matrixDbId":"27",          "description":"a test dataset",          "lastUpdated":"2017-06-12",          "studyDbId":"abc123"       }
GOBII and JHI propose adding two new keys: markerCount and sampleCount.
The use case occasioning this proposal is the extraction of datasets from GOBII in FlapJack. In FlapJack, it would be useful to assess the size of the matrix, based on the marker and sample counts, so as to warn the user if a particular extract is at risk of taking a long time.

+1

Fixed in V2.0
07017629ea717cb2fc80958a65774ccaffe1335d
AlleleMatrices becomes VariantSets in V2.0


Rename this

ampersand-filtered-subcollection is current front-runner

Update links in the readme whenever this is done too.

published as<EMAIL_ADDRESS>


RR-112 Remove goal title from Add Step screen

The goal's title is no longer displayed on the "Add Step" page.

LGTM


What's the difference between the relased models?

There are many models under relase_v0.1.3, what is the difference between them?
I thought the 512 in the name refers to the image resolution. But when I use v0.1.3 code to export 512 models via command
python export.py --img_size 512 --extractor_type superpoint --lightglue_path weights/superpoint_lightglue_512_end2end_my.onnx --dynamic --end2end.
The performance of the exported onnx model is different from the relased superpoint_512_lightglue_end2end.onnx.
I didn't find optimize.py so I assume it has nothing to do with model optimization? But then it's not clear what causes the different models obtained and what makes these models different? Thanks!

Hi @JingruiYu
The numbers in the name (512, 1024, 2048) correspond to the --max_num_keypoints argument, not --img_size. The models under v0.1.3 take any input resolution as they were exported with --dynamic.


build fails for latest xcode on macos

/Users/jwiens/Downloads/binexport/third_party/boost_parts/boost/container_hash/hash.hpp:130:33: error: no template named 'unary_function' in namespace 'std'; did you mean '__unary_function'?
        struct hash_base : std::unary_function<T, std::size_t> {};
                           ~~~~~^~~~~~~~~~~~~~
                                __unary_function
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX14.0.sdk/usr/include/c++/v1/__functional/unary_function.h:46:1: note: '__unary_function' declared here
using __unary_function = __unary_function_keep_layout_base<_Arg, _Result>;
^
1 error generated.

I assume there's a newer boost that fixes it or just running the update boost script would, but in the meantime, simply following the suggestion works.
diff --git a/third_party/boost_parts/boost/container_hash/hash.hpp b/third_party/boost_parts/boost/container_hash/hash.hpp
index 76de793..32f0559 100644
--- a/third_party/boost_parts/boost/container_hash/hash.hpp
+++ b/third_party/boost_parts/boost/container_hash/hash.hpp
@@ -127,7 +127,7 @@ namespace boost
         };
 #else
         template <typename T>
-        struct hash_base : std::unary_function<T, std::size_t> {};
+        struct hash_base : std::__unary_function<T, std::size_t> {};
 #endif

         struct enable_hash_value { typedef std::size_t type; };

@withzombies points out you can also just build with:
-DCMAKE_CXX_FLAGS="-D_LIBCPP_ENABLE_CXX17_REMOVED_UNARY_BINARY_FUNCTION"

Is this still a problem? I upgraded Boost to 1.83 in 840ddeec017a4ca85985a9b7919079d2f79f5d38


Autodetect executable path & use pythonic tool names.

This PR does the following:

Autodetect availability of whitebox_tools in path and set exe_path automatically
Use pythonic tool names (i.e. snake_case) in all the python functions. i.e.  wbt.tool_help('rescale_value_range') instead of  wbt.tool_help('RescaleValueRange')
wbt.list_tools() returns a dictionary of {tool_name: description} instead of a string.
Associated fixes to keep wb_runner.py working.

These changes ease usage from python and allow for installation of whitebox_tools as a python package that can be imported by other packages. I am also build conda packages (see https://github.com/conda-forge/whitebox_tools-feedstock/pull/1) which will allow for installation of whitebox-tools easily in python. I'm just repackaging the zip files available from your website and adding a setup.py and putting the executable in the correct location. This will allow us to install whitebox_tools within a conda python environment using:
conda install -c conda-forge whitebox_tools

@dharhas I worry that there may be breaking changes in here because it appears that you are working from a far older version of the code base. I haven't had a chance to fully review your commits yet, but at least two ('specify vars correctly' and 'rm debug print statements') do not appear to reflect the current state of the code base. Are you working from a fork of a fork perhaps?

Aah that might be the case. I may have forgotten to do a 'git pull upstream'. I will rebase on the current master and push a new version of the pr.

@jblindsay actually the network graph (https://github.com/jblindsay/whitebox-tools/network) shows that I'm working from your latest master. Some of those intermediate commits you mentioned are bugfixs for errors I introduced into the codebase while modifying it. Looking at 'files changes' might be the best way for you to review the changes.

@dharhas Yes, I think I'm just coming to realize that myself now. I'll keep reviewing the changes. One that I do worry about is the return of a dict. I think this might introduce a breaking change for the QGIS WhiteboxTools plugin, but I'll look into it. Thanks again for this contribution.

@jblindsay
that could be changed to return a list by default and either have a different method or a kwarg
(say as_dict=True) to return a dict.

@dharhas I'm also not sure that the to_camelcase and to_snakecase functions are needed. Internally WhiteboxTools converts all toolnames to lowercase and removes all underscores. So you can specify tool names to any of the functions in snakecase and they'll work just fine. There's no need to use CamelCase in the Python script at all.

So wbt.tool_help('aspect_ratio') already works? I guess I did not check that.
I still find the to_snakecase useful in the list_tools because otherwise the names in the tool_list and the python methods don't match.
i.e. wbt.listtools() returns AspectRatio but calling the tool in python would be wbt.aspect_ratio

@dharhas That's a good point. And I can certainly see your argument. However, the AbsoluteValue returned by wbt.listtools() is a reference to the actual WhiteboxTools AbsoluteValue tool (as in, that's what the actual code file is named) and wbt.Absolute_value refers to a Python function used to call the AbsoluteValue tool. Remember, WhiteboxTools is actually a 100k line Rust program. The Python script (whitebox_tools) is just a thin veneer overtop.

I forgot to mention as well that, yes, wbt.tool_help('aspect_ratio') already works. If there is anywhere in the User Manual or the WhiteboxTools webpage that uses the CamelCase version, let me know and I'll update them to use the Pythonic snake_case convention. (I thought I already changed them all but may have missed some).

@jblindsay My perspective is if I'm using the tool from python, I want to know what it is called from python. The fact that it is a reference to the slightly differently named rust program is worth referencing in the documentation for that function but isn't directly relevant.
Part of the issue is we are planning to use whitebox_tools inside https://github.com/erdc/quest and need a way to get a list of available tools. We can always parse the output on our end but it would be nicer to contribute it back upstream.

@dharhas The listtools() function in whitebox_tools.py is merely calling the WhiteboxTools.exe with the --listtools flag. Naturally it will return the names of the tools in Rust format...it's not returning the Python functions that are available in whitebox_tools.py. That is, the tools and functions are two different things. I've designed the WhiteboxTools library to be accessible from any scripting language (or command line), not just Python. It strikes me that this is not unlike certain nationalities that are noted for their insistence that the people of other countries speak to them in a certain language when they are travelling abroad.

@dharhas Okay, I think I'm convinced on this. You're probably right that the whitebox_tools.py listtools() function should probably return snake_case function names. I'm just not sure where to draw the lines between the WhiteboxTools executable and the Python API for it. For example, the tool_help() function...currently it returns the tool help (as in what you'd do at the command line) and not the tool function, the parameters of which are different (e.g. each of the tool functions have a callback and default parameters). I'll have to figure this out.

@jblindsay :) aah you made my long comment unnecessary.
Anyway taking a step back, my main desire is to improve the python wrapper for whitebox_tools. I do not want to effect the ability of the tools to be used in other contexts.
I'm interested in helping build this out if you are interested.
Some possible improvements:

Packaging: Make the python wrapper an installable python module. This involved using a setup.py file and putting the correct executable in an appropriate location. I'm currently handling this on the 'conda' packaging side but if you are interested we could add the setup.py to the repo so other folks have access to this. This makes whitebox_tools available from anywhere without needing to worry about the where the source and executable are. To do the above cleanly there are some advantages to splitting out the python wrapper into a separate git repo and having this repo be just the rust/cli version. It can also be done directly in this repo.

list_tools() maybe a new method say available_tools() when called from python returns snake_case

tool_help() etc should describe the python usage. This is easy to do manually but doesn't scale well. An automated approach to generate the python help would be better.

I just realized your build script is not python 3 compatible (i.e. it uses the old print). Do you care about python 2 compatibility or are you ok with python 3 only.

My main concern is actually 1). The others are minor.

@dharhas While I am on board for adding the setup.py file to the repo to help with Python packaging, I'm not keen on splitting the Python scripting component and the executable code into separate repos. At this point there are too many pieces in place that are invested in the current structure.

As for Python 2/3 used for the build.py script, I must admit that I completely forgot that the script existed. It was contributed to the project by a student and I actually don't use it myself to build the project. It's just so easy to type cargo build --release, especially with the built-in terminal window in VS Code, that I've never found that I need the script. I'll look into updating it to Python 3 like everything else.

If the python build script isn't doing anything useful, I think it would be better to remove it and add the cargo command to the instructions. I was only using the build script because I assumed that was how it needed to be built

When I package with setup.py or conda packaging it, I put it in the path. Without including setup.py there is no way to do this reliably.

Using the same directory as the script makes this very difficult to use from within other python modules.

Also, this should still work if its in the same directory as the script but now should also work if its anywhere in the path. If that is not working, then its a bug and I can fix it.

All I know is that when I pulled your commits, I was no longer able to launch wb_runner on my system. I don't want to have to rely on conda. It's fine to support it, but there has to be the option not to.

That I can fix. Especially, if you are open to including setup.py.

Perhaps you could email me to open a more in depth discussion of the advantages of a conda based installation procedure. However, there must always be the option to just download the zip file and run it without installation. Honestly, I don't fully appreciate the advantages of having an installation package dependency. For users that are not familiar with Python (or even Conda), this will be a serious roadblock.

I'll send you an email. Short version is that the conda package is more useful for using this tool within the context of a wider ecosystem of scientific python libraries that are difficult to install correctly without using a dependency manager like conda. For folks, who only want use whitebox_tools standalone, it doesn't provide much of an advantage.
I am going to open a new PR that does does a couple of things. Clean up the autodetect so it will also recursively look in the current directory and also add a setup.py that can be ignored by folks who don't want to use it.


Node version

Hi,
Node is outdated, can you update ?
The engine "node" is incompatible with this module. Expected version "^10.0.0". Got "12.*"

I made a small change to the package.json that should allow versions of Node higher than 10.0. Have in mind this package hasn't seen a lot of work in a while and has quite a few outstanding work items. We just haven't had the time to focus on it.


Remove reliance on additional network.

Rethinking if we really need eth1. If not THIS is the time to change it.
Originally posted by @fredrikhgrelland in https://github.com/fredrikhgrelland/vagrant-hashistack/issues/84#issuecomment-648736966
The reasons for doing this was to have a stable ip address to reference, but it is a pain you need to change networking to get basic services up and running. Removing eth1 outright, and we may use static ip in vagrant file if needed.

Not worth it. will keep eth1 and document requirements.


Prepare a new release

It has been a while since the last release, so we should prepare a new one. I suggest to do this after #7586 and #7588 land to ensure that the new release contains improved text selection enhancement code.

#7407 is another quite small PR (with a reduced test-case), that would be really nice to get landed and included in the release.

The pull requests have been merged, so we are ready to create the release.

This has been completed yesterday, so I'm closing this as resolved.


Create a working Mainframe system

It might be a bit of a tall order, making basically the whole core library logic at once, but some libraries are just that small.

Created a working system and a working demo.
The demo works twice as hard, because it not only works works, but also it does background processing which is extra work.


Run kubevirt lane with KUBEVIRT_PSA=true

What this PR does / why we need it:
To be able to run VMs on a namespace with restricted PSA policy, KubevirtSeccompProfile feature gate should be enabled and a new configuration needs to be enabled under
.spec.configuration.seccompConfiguration
virtualMachineInstanceProfile:
   customProfile:
       localhostProfile: kubevirt/kubevirt.json

Reference: https://github.com/kubevirt/kubevirt/pull/8917
Special notes for your reviewer:

The previous run failed, are the latest changes fixed it, or it can be a flake ?
Thanks

It failed to communicate with the webhook. IDK why it happened.

The previous run failed, are the latest changes fixed it, or it can be a flake ?
Thanks

It failed to communicate with the webhook. IDK why it happened.

sounds like unrelated flake, saw in the past here and there, unless we see it more frequent

/approve


Fix misleading documentation for clipboard command

'P' can also be used on the request screen!

I've been puzzled today by this for 10 minutes or something...

Thanks! Apologies for the 10 minutes of frustration. :)

Please don't apologize, man! mitmproxy has already saved me some hours... I'm having a huge profit here! ;-p


Using Application Insights with Service Fabric V1 remoting causes request tracking failure

Version: 2.1.0-beta1
Stack Trace:
System.NullReferenceException:

   at Microsoft.ApplicationInsights.ServiceFabric.Module.RequestTrackingUtils.GetBaggageFromActivity (Microsoft.AI.ServiceFabric.Native, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=31bf3856ad364e35)

   at Microsoft.ApplicationInsights.ServiceFabric.Remoting.Activities.CorrelatingServiceRemotingClient+<SendAndTrackRequestAsync>d__19.MoveNext (Microsoft.AI.ServiceFabric.Native, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=31bf3856ad364e35)

Repeatability: Every time, consistently when using V1 remoting with instructions provided in readme.md with Full Framework Stateless service.

@alexmarshall132 I just tried and can't repro the issue you had. Could you share a simple project that repros?

Hi Yanming,
I'll work on getting you a sample ASAP, it's been a busy week
On Tue, Apr 24, 2018 at 1:14 PM, Yanming Tang<EMAIL_ADDRESS>wrote:

@alexmarshall132 https://github.com/alexmarshall132 I just tried and
can't repro the issue you had. Could you share a simple project that repros?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/Microsoft/ApplicationInsights-ServiceFabric/issues/62#issuecomment-384047598,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABt6JnvqffEWAMQz7i8s4HJtwWku8w7Nks5tr3mNgaJpZM4Teu4B
.

--
Alex

Hi Alex,
Which version of Application Insights SDK are you running? Is it 2.3 or 2.4+?

@alexmarshall132 I reproduced the bug. And it's fixed in PR https://github.com/Microsoft/ApplicationInsights-ServiceFabric/pull/72.
Before the nuget is released, you can manually upgrade Microsoft.ApplicationInsights nuget to 2.4+ and the problem should go away.

Thank you very much Yanming. I appreciate it.
On Thu, 31 May 2018, 12:46 PM Yanming Tang<EMAIL_ADDRESS>wrote:

Closed #62
https://github.com/Microsoft/ApplicationInsights-ServiceFabric/issues/62
.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/Microsoft/ApplicationInsights-ServiceFabric/issues/62#event-1656704936,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABt6JmETk-rNQA1OmKJofaniz1l3Bn13ks5t4DqIgaJpZM4Teu4B
.


cifs server validation should say "server name instead of "username"

https://github.com/Azure/Avere/blob/main/src/terraform/providers/terraform-provider-avere/cifs.go#L269 - needs to be fixed to say "server name"

fixed with #934


Migrate Universe workbench to new Lab Workbench model - Part 2

Part 2 - The original issue was not feasible because we were still using Roassal2.
This new issue will migrate things to Roassal3.


Doesn't Work. Click "OK"... Nothing Happens

Don't really understand how this issue hasn't been fixed. Click "OK"... absolutely nothing happens. YES I am requiring cookies_eu in the application.js... It just isn't doing anything.
No errors in the console. No errors in the logs.

Same problem...

I simply gave up and used a different program.
On Thu, Feb 4, 2021, 9:22 AM Matias<EMAIL_ADDRESS>wrote:

Same problem...
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/infinum/cookies_eu/issues/87#issuecomment-773123645,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AA2KI52XH5BSHUOCZ3GPYE3S5JKNZANCNFSM4T3H55WA
.

I'm also having this issue. Has anyone figured it out?

Yup: Use something else.
On Sat, Mar 13, 2021, 5:29 PM johnhanlon86 @.***> wrote:

I'm also having this issue. Has anyone figured it out?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/infinum/cookies_eu/issues/87#issuecomment-798592310,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AA2KI55KT4PUTTGXIJYTRLTTDOHGVANCNFSM4T3H55WA
.

I tried a couple of cookie gems and I also had this problem. What I finally figured out is that I had a chrome extension installed called "I don't care about cookies" which was simply hiding/deleting everything that looked like a cookie banner. Maybe that's the case for some of you as well.

I doubt it... That's an EXTREMELY specific thing.
On Tue, Mar 16, 2021, 7:51 PM Maciej Dobosz @.***>
wrote:

I tried a couple of cookie gems and I also had this problem. What I
finally figured out is that I had a chrome extension installed called "I
don't care about cookies" which was simply hiding/deleting everything that
looked like a cookie banner. Maybe that's the case for some of you as well.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/infinum/cookies_eu/issues/87#issuecomment-800520296,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AA2KI56UB7HG3IB4NDX4NCDTD6SDVANCNFSM4T3H55WA
.

Same here.

If useful, we've recently narrowed it down to that it works on the homepage but not on any sub pages. No idea why! We are likely going to move away to our own thing soon.

What was the other solution you ended up going with? I'm specifically looking for something that'll work for the adsense consent so I can get rid of the super ugly google consent form

Cookiebot I believe... ( https://cookiebot.com ) Glad you reminded me... I
need to update the version of cookiebot I'm using.
On Wed, Jun 19, 2024 at 12:08 AM Kevin Watt @.***>
wrote:

What was the other solution you ended up going with? I'm specifically
looking for something that'll work for the adsense consent so I can get rid
of the super ugly google consent form
—
Reply to this email directly, view it on GitHub
https://github.com/infinum/cookies_eu/issues/87#issuecomment-2177160259,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AA2KI54D6EUVGFZCCS3QHN3ZICVWHAVCNFSM6AAAAABJQ3YVACVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNZXGE3DAMRVHE
.
You are receiving this because you authored the thread.Message ID:
@.***>


JCenter shutdown

Hello,
On February 3 2021, JFrog announced that they will be shutting down Bintray and JCenter. I have tested removing jcenter() from the project, to see what SDKs depend on JCenter, and one of the SDKs that failed was Leonids. I was wondering if there was a plan for the SDK when JCenter is no longer available.
Thanks!

@plattysoft @magneticflux- Could you please help here getting the latest version to Maven Central?

I haven't been actively supporting this repo for a few years, but at the very least I should make it available.

@plattysoft yes please. That would be really helpful. Thanks in advance.

ditto, esp given the jcenter outage yesterday.

Hey @plattysoft
Any updates on bringing it to the MavenCentral or other non jCenter repo?


Readability of remote connection status on hover

Operating system/version: Windows 10 Pro 19042.630
Extension version: 6.3.4
VSCode version:

Version: 1.51.1 (user setup)
Commit: e5a624b788d92b8d34d1392e4c4d9789406efe8f
Date: 2020-11-10T23:34:32.027Z
Electron: 9.3.3
Chrome: 83.0.4103.122
Node.js: 12.14.1
V8: <IP_ADDRESS>-electron.0
OS: Windows_NT x64 10.0.19042

Settings

"workbench.colorTheme": "Gruvbox Material Dark",

Steps to reproduce this bug
Hover over the remote connection box in the bottom left.
Actual behaviour
On hover, the fg text stays dark when the bg inverts to dark.

Expected behaviour
On hover, the fg text should invert to light when the bg goes dark.

Thanks for your feedback, I will fix it soon

@tdy I'm so sorry, got sudden troubles, so I am a bit busy now, but will fix this issue as soon as possible

@Z4RX no problem, take your time

Since vscode does not provide something like statusBarItem.remoteHoverBackground, I can't change the behavior when hover it.
So I simply use the black as the background color of this extension icon. IMO, this should be the preferred solution, because this can help you more focus on code.


Upgrade dependencies

Huge upgrade, get all deps to their latest version :ok_hand:
Fixes #2993

hello
am failing CI on a project due to an nsp warning which would be fixed by this PR
let me know if you want any help testing prior to this being merged 😀

@michael-ar if you want to test it against your project that'd be great! Thanks ❤

tested against my project locally and all working correctly
thanks for all the work on next!

Since all tests pass I'm going to merge this in 👍

@michael-ar thanks for checking against your project ❤ Much appreciated!

Feel free to join zeit.chat btw 👌


Make @aws-skd/client-eventbridge a dependency of @swarmion/serverless-contracts

Fix suggestion to issue #330.
pnpm run deploy fails on newly created projects due to a missing @aws-sdk/client-eventbridge dependency in @swarmion/serverless-contracts
This MR moves @aws-sdk/client-eventbridge from devDependencies to dependencies in @swarmion/serverless-contracts

@allcontributors please add @PChol22 for code


Add validation to Contact field

This is a quick fix, and it may be a good idea to follow up with a more long-term solution to validation.

The above message appears as the user is typing. If the user chooses to submit despite the warning, the input box regains focus (thus scrolling them so that the input box is on screen), the security.txt file is not generated, and an additional red box appears at the top.

The red box does not disappear until the user submits the form again, even after they have corrected all the issues.
Note: the validation only checks that the input begins with https://, mailto: or tel:. It does not validate the content afterwards (such as whether there is an @ if mailto: is used) but this can potentially be added in a follow-up PR.

IMHO a god usability would be, if I enter<EMAIL_ADDRESS>and press Tab or so, that it "autocompletes" the field to<EMAIL_ADDRESS>and thus "auto-corrects" the error.
After all, the advantage of this website is to simplify things, and I as a user should not worry about the exact syntax…

IMHO a god usability would be, if I enter<EMAIL_ADDRESS>and press Tab or so, that it "autocompletes" the field to<EMAIL_ADDRESS>and thus "auto-corrects" the error.
After all, the advantage of this website is to simplify things, and I as a user should not worry about the exact syntax…

@joker314 can you take a look?


Edited code disappeared!

Issue Type: Bug
I edited the code and now I am unable to see the changes.
VS Code version: Code 1.22.2 (3aeede733d9a3098f7b4bdc1f66b63b0f48c1ef9, 2018-04-12T16:38:45.278Z)
OS version: Windows_NT x64 10.0.16299

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-6700HQ CPU @ 2.60GHz (8 x 2592)

Memory (System)
15.90GB (10.97GB free)

Process Argv
C:\Program Files\Microsoft VS Code\Code.exe C:\Users\Darkness_Creator\AppData\Roaming\Code\Backups\workspaces.json

Screen Reader
no

VM
0%

Extensions: none

Could you please provide more detailed info to help troubleshoot? A gif can help.


sidebar offset for neo-tree in stabline

Hello is there a way to achieve sidebar offset for neo-tree or nvim-tree like that in bufferline https://github.com/akinsho/bufferline.nvim#sidebar-offsets ?

Heyyo @abhilash26 , there isnt a direct way builtin in stabline (It was meant to be really minimal 😅 )
But there are stab_start and stab_end options as mentioned in the readme.
I just pushed some changes that will allow them to take functions so we could do something like this for now:
require("stabline").setup {
    stab_start = function()
        if #vim.tbl_filter(function(b) return vim.bo[b].ft == "NvimTree" end, vim.api.nvim_list_bufs()) > 0 then
            return (" "):rep(require("nvim-tree").config.view.width)
        end
    end
}

@tamton-aquib ,
I am very grateful for the speedy response and delivery.
For anyone using neo-tree use below code
        stab_start = function()
          if #vim.tbl_filter(function(b) return vim.bo[b].ft == "neo-tree" end, vim.api.nvim_list_bufs()) > 0 then
            return (" "):rep(require("neo-tree").config.window.width)
          end
        end

Issue resoved. Lets close this.


Automated Package Upgrade

:tada: This PR is included in version 13.0.90 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


doc: Add uv to quick start

What type of PR is this? (check all applicable)

[ ] 💾 Refactor
[ ] ✨ Feature
[ ] 🐛 Bug Fix
[ ] 🔧 Optimization
[x] 📝 Documentation
[ ] ✅ Test
[ ] 🐳 Other

Related issues

Related issue #
Closes #1065

Checklist

[ ] Code follows style guide (ruff)
[ ] Tests added
[ ] Documented the changes

If you have comments or can explain your changes, please do so below.

Ok no objections so far! Let's ship this 🚀


Adding leisure=sports_centre preset to a building removes building tag

As it currently is, if the leisure=sports_centre preset is added to a building it removes the building tag from the area. I noticed that in issue #4682 that the building tag was removed from being part of the preset, but the building tag shouldn't also be removed from areas that already contain it when the preset is added to them. As sports centers can be in buildings.

Yes, that's ok.. #4682 removes it because sports centers probably aren't buildings.  But there is still a building field in the sidebar, so that the user can put it back if they want to.

"sports centers probably aren't buildings"
Is the building tag removed by default if it is already there because of the assumption that the sports centers tagged as buildings are miss tagged or something? As it currently stands, 61,044 sports centers out of 169,427 have the building tag. Which is roughly 36 percent, or 1 out of 3. That's not enough for the building tag to not get removed by default if its already there huh? I can understand a tag not being part of the preset when its added, but having a preset remove preexisting tags seems like influencing tagging practices. Plus, it might cause people to not notice the building tag has been striped and then to save their work without it. Since it was already there originally and there's no logical reason it should be removed by adding another tag.

OK. It makes more sense now. Thanks for the extra explanation.


is this support monorepo?

Im coding npm addon with lerna, like an monorepo.
I tried create typedoc.json and runtypedoc;
// typedoc.json
{
    "entryPoints": [
        "packages/lua-cli/src/index.ts",
        "packages/panorama-cli/src/index.ts",
        "packages/panorama-dom/src/index.ts",
        "packages/panorama-type/index.ts"
    ],
    "out": "doc",
    "includeVersion": true
}

but I got

so I tried
{
    "entryPoints": [
        "packages/lua-cli/src/index.ts",
        "packages/panorama-cli/src/index.ts",
        "packages/panorama-dom/src/index.ts",
        "packages/panorama-type/index.ts"
    ],
    "out": "doc",
    "includeVersion": true,
    "tsconfig": [
        "packages/lua-cli/tsconfig.json",
        "packages/panorama-cli/tsconfig.json",
        "packages/panorama-dom/tsconfig.json",
        "packages/panorama-type/tsconfig.json"
    ]
}

then I got error The tsconfig file

You want packages mode, see: https://typedoc.org/guides/monorepo/


darktable, wireshark: Fix documentation installation directory

Fixes documentation directory. Before the documentation files for these packages would end up directly inside /share/doc and now they are placed in /share/doc/${pname}.

looks like the better version of  #72160

https://cmake.org/cmake/help/v3.16/module/GNUInstallDirs.html says CMAKE_INSTALL_DOCDIR defaults to DATAROOTDIR/doc/PROJECT_NAME. Don't these projects set project(NAME) in their CMakeLists.txt files? Ping upstream?

Ah, this is a workaround for https://github.com/NixOS/nixpkgs/issues/82304.

I used nix-review pr 83248
I could verify the crossed out packages (which are in results). The other ones I never used.

[ ] compactor
[x] darktable
[ ] haka
[ ] ostinato
[x] termshark
[ ] wifite2
[x] wireshark
[x] wireshark-cli


Update Reactor and Netty Dependencies

This PR updates our Reactor dependency from 3.3.x to 3.4.x, Reactor Netty from 0.9.x to 1.0.x, and upgrades Spring usage to 2.4.x. The Reactor and Reactor Netty version upgrades contain backwards compatibility breaking changes for the libraries.

Reset the Spring changes as it didn't resolve any issues and caused more.

@alzimmermsft
(cc @kushagraThapar )
To make sure our customer can use latest feature of azure-spring-data-cosmos in spring-boot 2.2 and 2.3,
Please don't merge this PR before release a version for azure-spring-data-cosmos and azure-spring-boot -starter-xxx.

Given we are doing some major version bumps here, is it a good time to get some performance baselines (/cc @mikeharder )

Given we are doing some major version bumps here, is it a good time to get some performance baselines (/cc @mikeharder )

@g2vinay: Can you run a few perf tests before and after this change?  Storage upload, download, and list blobs would be a good start.

Given we are doing some major version bumps here, is it a good time to get some performance baselines (/cc @mikeharder )

@g2vinay: Can you run a few perf tests before and after this change?  Storage upload, download, and list blobs would be a good start.

Hi, @alzimmermsft ,
FYI:
We already released azure-spring-boot-starter-xxx for spring-boot-2.2.x and 2.3.x, so you can merge this PR now.

Hi, @alzimmermsft ,
FYI:
We already released azure-spring-boot-starter-xxx for spring-boot-2.2.x and 2.3.x, so you can merge this PR now.

Hi, @alzimmermsft ,
FYI: I added 3 commits, you can check the commit message for more information.

Hi, @alzimmermsft ,
FYI: I added 3 commits, you can check the commit message for more information.

@alzimmermsft .
We still use spring-boot-2.4.0 even though there is already have 2.4.1.
Because we need to let our sdk support all spring-boot versions of 2.4.x.
If we use 2.4.1, and in 2.4.1, there is some api that does not exist in 2.4.0, our sdk may not support 2.4.0 well.
If we use 2.4.0, and we can think that our customer can use 2.4.1 with no problem.

@alzimmermsft .
We still use spring-boot-2.4.0 even though there is already have 2.4.1.
Because we need to let our sdk support all spring-boot versions of 2.4.x.
If we use 2.4.1, and in 2.4.1, there is some api that does not exist in 2.4.0, our sdk may not support 2.4.0 well.
If we use 2.4.0, and we can think that our customer can use 2.4.1 with no problem.

@alzimmermsft ,
Sorry that there is a mistake in the commit message Checkout 3 files from this PR: ...
I pushed force to fix it. Now it's fixed.

@alzimmermsft ,
Sorry that there is a mistake in the commit message Checkout 3 files from this PR: ...
I pushed force to fix it. Now it's fixed.

Hi, @alzimmermsft .
According to the January Release Kickoff, we should merge this PR as soon as possible.
Shiproom: Thursday 1/7 @ 11am
Code complete: Friday 1/8
Package Ship: Tuesday 1/12

Hi, @alzimmermsft .
According to the January Release Kickoff, we should merge this PR as soon as possible.
Shiproom: Thursday 1/7 @ 11am
Code complete: Friday 1/8
Package Ship: Tuesday 1/12

Looking to get the PR merged ASAP, fixing test failures that are happening due to the upgrade.

@chenrujun from my investigation into a test failure in azure-spring-boot it appear that RepositoryFactoryBeanSupport changed setMappingContext from using Optional.ofNullable to Optional.of resulting in a NullPointerException being thrown by the test testDefaultRepositoryConfiguration. Do you know what should be done about this?

@chenrujun from my investigation into a test failure in azure-spring-boot it appear that RepositoryFactoryBeanSupport changed setMappingContext from using Optional.ofNullable to Optional.of resulting in a NullPointerException being thrown by the test testDefaultRepositoryConfiguration.


ABIs don't generate properly if wasm output isn't in current directory

Steps to reproduce:
git clone git@github.com:EOSIO/eosio.contracts.git
mkdir -p build
eosio-cpp eosio.contracts/eosio.token/src/eosio.token.cpp -I eosio.contracts/eosio.token/include/ -o build/eosio.token.wasm --abigen
This is the empty ABI generated
{
    "____comment": "This file was generated with eosio-abigen. DO NOT EDIT Thu Nov 15 13:51:58 2018",
    "version": "eosio::abi/1.1",
    "structs": [],
    "types": [],
    "actions": [],
    "tables": [],
    "ricardian_clauses": [],
    "variants": [],
    "abi_extensions": []
}

The issue seems be because the wasm file isn't in the current directory. When it is, the issue is resolved.

when you buid a contract outside the contract folder,you must add -contract option to figure out the contract name
for you , the right command is
eosio-cpp eosio.contracts/eosio.token/src/eosio.token.cpp -I eosio.contracts/eosio.token/include/ -o build/eosio.token.wasm --abigen -contract=eosio.token

Ah I wasn't aware of that requirement. Thank you for the follow up @ijoywan.


[CUR-370] fix: update curriculum sitemap

Description
Music year: 2004

Fixed typo: changed lastmid to lastmod in sitemap

How to test

Go to https://deploy-preview-2162--oak-web-application.netlify.thenational.academy/teachers/curriculum/sitemap.xml
View the XML as source
You should see several items with the format: <url><loc>...</loc><lastmod>...</lastmod></url>

:tada: This PR is included in version 1.319.3 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Two more methods in EventPool

We should add next_priority and next_priority_and_delete
We should also add filters to make distinction from UI queries and GridManager queries.

Done. Closing the issue on PR

Merged


Provide user-visible feedback when benchmark times out

Inform the user if a benchmark was terminated due to a timeout, by appending a message in the error stream. This should make debugging things easier (currently, timeout is signalled only by a failed text, with no indication for the reason).

:+1:


jetson nx --- utils.cpp::checkMemLimit::380] Error Code 2: Internal Error (Assertion upperBound != 0 failed. Unknown embedded device

Jetson NX (jetpack 4.6.2)
TensorRT ：<IP_ADDRESS>
CUDA ：10.2
CUDNN ：8.2.1
Same error when running official onnx model: /usr/src/tensorrt/bin/trtexec --onnx=./data/resnet50/ResNet50.onnx
[utils.cpp::checkMemLimit::380] Error Code 2: Internal Error (Assertion upperBound != 0 failed. Unknown embedded device detected. Please update the table with the entry: {{1794, 6, 16}, 12660},)

Hi @whaosoft, what variant of Jetson Xavier NX are you running?   Is it Jetson Xavier NX 16GB?   If so, I think you need to upgrade your version of JetPack / TensorRT

Hi @whaosoft, what variant of Jetson Xavier NX are you running? Is it Jetson Xavier NX 16GB? If so, I think you need to upgrade your version of JetPack / TensorRT

My version is Jetson Xavier NX emmc 16GB + ssd / china dev kit
Are you sure upgrade to Jetpack 5.0 version?
I've tried to run many many times, it drive me mad...
I've heard that jetpack 4.6.0 is okay , only 4.6.2 hava bug? Do you think so?

@dusty-nv

Hi @whaosoft, what variant of Jetson Xavier NX are you running? Is it Jetson Xavier NX 16GB? If so, I think you need to upgrade your version of JetPack / TensorRT

My version is Jetson Xavier NX emmc 16GB + ssd / china dev kit
Are you sure upgrade to Jetpack 5.0 version?
I've tried to run many many times, it drive me mad...
I've heard that jetpack 4.6.0 is okay , only 4.6.2 hava bug? Do you think so?


How do I ignore a object field to be a column in table?

Hi you can add the @Transient annotation to ignore the field/method.

Hi, I had a similar problem and @Transient is working for fields within the current class. But when the class has a super class which has non private fields, requery is generating columns for these fields. In this case @Transient isn't working and it seems that every other annotation is ignored either. Am I doing something wrong?

Ah ok so you have a super class not marked as an entity, but the fields in your super class are generated as columns? If so that is a bug and will provide a fix

Yes, exactly. But it would be nice to be able to define columns in a super class. I have tables which have some columns in common and for them I'm currently forced to define each column in each class instead of putting them into a super class.

Maybe the support for the "@Embedded" annotation could satisfy these needs.

Yup embedded is one way but that will be a while as there are some complexities to solve there. Both inheriting and not inheriting the members from the superclass is useful so will make this configurable. thanks for the feedback

In the updated version you'll have to make inheriting from a base class explicit by using @Superclass, (this is similar to JPA which has @MappedSuperclass which is also now supported). This also resolves the issue @a-merkle reported where the annotations from the base class weren't being processed.

Thank you very much for the quick fix and feature. It works like a charm! :+1:

Great!


Adds link to privacy policy

Adds link to RAC privacy policy. Fixes #100 . Keeping it extremely simple right now. Just adds it over the theme's footer text.

Yeah, nice!


When the first bit of the CRC is 0, 0 is not acquired, only 7 bits.

Steps to reproduce
When the first bit of the CRC is 0, 0 is not acquired, only 7 bits.
....
  while ((theEntry = s.GetNextEntry()) != null) {
                if (fileName.Equals(theEntry.Name)) {

                    string crcInfo = **theEntry.Crc.**ToString("X");
...

Expected behavior
I do not know
Actual behavior
When getting CRC
Version of SharpZipLib
<IP_ADDRESS>8
Obtained from (place an x between the brackets for all that apply)

[ ] Compiled from source
branch: _______
commit: _______
[x] Downloaded DLL from GitHub
[ ] Downloaded DLL from SourceForge
[ ] Downloaded DLL from _______
[ ] DLL included as part of
Package installed using:
[ ] NuGet
[ ] MyGet
[ ] Chocolatey

I think your issue is about formatting the CRC of a zip file entry to a string, correct?
You expect it to output 8 hex characters, but if the CRC is lower than 268435456 (decimal) the .ToString("X") call will only output 7 characters.
In that case you can just use .ToString("X8") and it will add padding 0's to the beginning of the string, so
268435456.ToString("X8") outputs 0FFFFFFF

Thank you very much for your answer. The original formatting will have this problem.@piksel


Add support for S3 region endpoints

This PR adds support for using a S3 region endpoint to the docker-registry chart. This enables the docker registry to be used with any service that supports a S3 interface.

Please put [stable/docker-registry] in the PR title so people know what the PR is for.

This is also implemented in #6710.
Please close this.

Dup of #6710


[BugFix] Fix scheduler problem of colocate and multi-partition cases

What type of PR is this：

[x] BugFix
[ ] Feature
[ ] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Which issues of this PR fixes ：

Fixes #11834
Fixes #11851
Problem Summary(Required) ：

For all local agg, lable it with colocate, then ColocatedBackendSelector rather than NormalBackendSelector will be used to select the backends.
Checklist:

[x] I have added test cases for my bug fix or my new feature
[x] I have added user document for my new feature or new function

run starrocks_fe_unittest

run starrocks_fe_unittest

[FE PR Coverage Check]
:heart_eyes: pass : 2 / 2 (100.00%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/sql/plan/PlanFragmentBuilder.java
2
2
100.00%
[]

[FE PR Coverage Check]
:heart_eyes: pass : 3 / 3 (100.00%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/sql/plan/PlanFragmentBuilder.java
3
3
100.00%
[]

[FE PR Coverage Check]
:heart_eyes: pass : 2 / 2 (100.00%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/sql/plan/PlanFragmentBuilder.java
2
2
100.00%
[]

[FE PR Coverage Check]
:disappointed: fail : 3 / 4 (75.00%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/sql/plan/PlanFragmentBuilder.java
3
4
75.00%
[2123]

run starrocks_admit_test

run starrocks_fe_unittest

run starrocks_admit_test

run starrocks_fe_unittest

run starrocks_fe_unittest

[FE PR Coverage Check]
:disappointed: fail : 3 / 4 (75.00%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/sql/plan/PlanFragmentBuilder.java
3
4
75.00%
[2123]

@Mergifyio backport branch-2.2 branch-2.3 branch-2.4

This pr will induce another problem, which is solved by #12218

At least version 2.2.9 is required


erlang: fix build

Building Erlang (at nixpkgs master) fails for x86_64-linux with:
ln: failed to create symbolic link '/nix/store/f766s9cfzi89wf1wwly2qs1yjg592nmr-erlang-<IP_ADDRESS>/bin/escript': File exists

Logs: erlang.log
By removing: https://github.com/NixOS/nixpkgs/blob/master/pkgs/development/interpreters/erlang/generic-builder.nix#L140-L142
Just works.
I lack context on why this line is there. So I'm just proposing this change to know what you guys think. (And to fix Erlang build for master.)
Thanks in advance for the review.

#205084

#204954

ping @dmarcoux

#204781

Hmmm then we will have to check why escript is not available by default in the bin section


Can't validate my Ycombinator Profile...

Can't validate my Ycombinator Profile...
now have 2 points... but seams anything else happends
ideas ?
thanks....

Seams I need 2 points.... this was the reason.


[BEAM-9545] Dataframe transforms

Still a bit rough, but it works.
CC: @TheNeuralBit Follow-up to https://github.com/apache/beam/pull/10757

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Choose reviewer(s) and mention them in a comment (R: @username).
[ ] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

R: @TheNeuralBit this is ready for review.

Ping.

Run Python2_PVR_Flink PreCommit


RFC: versioning strategy

view rendered
Please leave comments on the PR. The render link will update as new commits get pushed.

:+1:

For the purposes of this versioning strategy, we consider removing a Rails or Ruby version to be a breaking change.

It's worth calling out that we're discussing changing this for RSpec (see rspec/rspec#25).  Not sure what affect (if any) that should have on rspec-rails, though.

I entirely support this, my only comment is how will rspec-rails handle major releases of RSpec going forward, and what affect if any RSpec dropping ruby version support (as discussing in rspec/rspec#25) have on this? (I think none as Rails only supports in life Ruby?)

I think we can consider this accepted. Merging.


adjust README (JDK 8 and correct RC version)

Coverage remained the same at 82.705% when pulling 18ae3a14690790ee6c306ad445f79ce4b560967f on java8 into 4c89139b6b6e602cd467764d15e628ffcf131b6c on 2.0.0-RC.


Adding leaky prefix

Per #982, a list of domains that have at least one A answers from Google
Public DNS has been added to the list.
I made a tool in Go for this task. (mys721tx/lpc). It still needs some work but it can automate most part of the check.

Some duplicates were removed, some domains that no longer exist are marked with comments.

Hi @mys721tx, thank you for this.
Unfortunately, you've made changes to a generated file.
I think the way this repo works is clear in the readme.
Our hosts come from a variety of well curated sources, which we amalgamate, de-duplicate, and package in various ways.
The changes you suggest need to happen within curator's repos, not here.
So I must decline this pull request.  But thank you for your efforts!

The README states that this file is the Steven Black's ad-hoc list, which is not a generated file.

My mistake @mys721tx — you're right!  I misread the file path on the Files changed page.
Reopening.  Thanks for the clarification.

Yishen @mys721tx please tell me, what's with the suffix comments?  What do those mean?  How did you establish these, why are they named this way, and why do we want them?

Those are the errors returned during DNS query. NXDOMAIN means the domain in question no longer exist. SERVFAIL means that the name server of that domain has failed during query. I am not sure whether those should be removed out right and defer it to you to make that decision.

Yishen @mys721tx then I would say, delete the NXDOMAIN domain lines, remove the SERVFAIL comments, and we're good.

@StevenBlack removed as requested.

Yishen @mys721tx this is all-good.  Thanks!
Merging.


ctrl/cmd+. doesn't show the action widget menu in the terminal

no when clauses are matched

actionWidgetVisible is false in the above scenario

where the editor does this
https://github.com/microsoft/vscode/blob/9dba5385c7aefebe3756ed413da7fedf1868a71c/src/vs/editor/contrib/codeAction/browser/codeActionCommands.ts#L174-L195


uncaught else in translation_multi task

Before submitting

[ ] Was this discussed/approved via a Github issue? (no need for typos, doc improvements)
[x] Did you read the contributor guideline?
[x] Did you make sure to update the docs?
[x] Did you write any new necessary tests?

What does this PR do?
Fixes #3847.
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃

bump