SimpleHealthKit Onboarding – Testing in Staging and Prod

Acceptance Criteria

[ ] Sender has tested in staging and production
[ ] RS engineer has determined the data is good enough and graduates Sender to send Prod data to receiver

To Do

[ ] RS engineer: update this ticket with comments with every interaction with sender
[ ] RS team member who originates this ticket: add dependencies:

[ ] [name of company] Onboarding – Create Org and Sender Settings
[ ] [name of company] Onboarding - Validate Test Files

[ ] RS team member who originates this ticket: complete the following when creating this Issue.

[ ] Pipelines: Onboarding & Operations (New)
[ ] Labels: "Onboarding-ops," "Sender"
[ ] Epics: [select the epic for this API onboarding sender]

Public Keys received. Waiting for staging environment to be available to upload.

update from sender:
Hello James,
I am in the process of sending data to staging following the Programmers guide. What is Simple HealthKit's client ID? I do not know if that was ever given to us after searching through some of our emails. That would be greatly appreciated.
If possible, could we also schedule a tentative meeting this upcoming week just to make sure that we are connected properly and securely?
Best,
Abdul Ahmed @ Simple HealthKit

Update:
Hi Abdul,
I've sent an invite, feel free to forward to whomever on your side should be included.
Thanks,
James
James Gilmore (Agile Six)
Subject: Re: ReportStream - simplehealthkit validation
Hello James,
Thanks so much for the client id. I will use this to get the bearer token. Can we schedule a call on Thursday 2/2 at 9am PST to 10am PST?
Best,
Abdul @ Simple HealthKit
On Mon, Jan 30, 2023 at 11:41 AM Gilmore, James (CDC/DDPHSS/OD/HITSSU<EMAIL_ADDRESS>wrote:
Hi Abdul,
Your client id is "simplehealthkit" so an example command to get a bearer token would be:
curl -X POST -H "Content-Type: application/x-www-form-urlencoded" -d "scope=simplehealthkit.*.report&grant_type=client_credentials&client_assertion_type=urn:ietf:params:oauth:client-assertion-type:jwt-bearer&client_assertion=" "https://staging.prime.cdc.gov/api/token"
We can schedule a meeting later this week if that works for you. I have availability on Thursday 2/2 from 8:30-10:00 AM PST and Friday anytime between 8AM-5PM PST except for between 11-11:30.
Thanks,
James
James Gilmore (Agile Six)
Senior HL7 Data Analyst
Pandemic-Ready Interoperability Modernization Effort (PRIME)

Hello James,
Thanks so much for the client id. I will use this to get the bearer token. Can we schedule a call on Thursday 2/2 at 9am PST to 10am PST?
Best,
Abdul @ Simple HealthKit

Hi Abdul,
I've sent an invite, feel free to forward to whomever on your side should be included.
Thanks,
James

Hi Abdul,
The files look good so we can move on to testing in Prod. Please send a few real patient examples to our production endpoint that we can use to validate. Please ensure that you do not send any real patient data to the staging environment. We will forward the examples on to the relevant public health jurisdictions for approval and once we receive that can move you to full production.
To get the detailed submission history send a GET request to https://staging.prime.cdc.gov/api/waters/report/{id}/history where {id} is either the submission id or UUID returned in the JSON response to your POST. For production you would send to https://prime.cdc.gov/api/waters/report/{id}/history.  in the request you client id and bearer token as you would in a POST submission.
Let me know if you have trouble getting the submission history to return.
Thanks,
James
James Gilmore (Agile Six)
Senior HL7 Data Analyst
Pandemic-Ready Interoperability Modernization Effort (PRIME)

Update from Sender:
Hello James,
I was having some trouble using my script to send data to production. I think my production URLs may be incorrect since my staging configuration is giving me a 200 response. I am using my production .pem file for this script.

Best,
Abdul Ahmed @ Simple HealthKit

Good Afternoon,
ReportStream has a new sender that would like to send to California.
SimpleHealth Kit - CLIA 5D2201580
They are sending CSV to ReportStream so I have used CLIA CDPH000085. I have sent some messages for validation to the test environment at saphiresftpstage.cdph.ca.gov
The filename is:
covid-19-4a441115-d85e-4d56-a9cb-e6d64597409a-20230208150740.hl7
The message id's are:
397403+1+20230208
397404+2+20230208
397405+3+20230208
397406+4+20230208
397407+5+20230208
Please let me know if there are any changes that need to be made and I will work with the sender.
Thanks,
James

CA has validated the messages andsimplehealthkit is now in full production mode.


Changed the incorrect links on the contribute page (Italian and Portuguese).

Checklist:

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)
[x] My pull request targets the main branch of freeCodeCamp.
[x] I have tested these changes either locally on my machine, or GitPod.

Closes #44808

Hey @kalashjain23
This PR seems to make similar changes as the existing PR #44809. As such, we are going to close this as duplicate.
If you feel you have additional changes to expand upon this PR, please feel free to push your commits and request this PR be reopened.
Thanks again! 😊

If you have any questions, feel free to ask questions on the 'Contributors' category on our forum or the contributors chat room.


Add a lot of commands to get wholesome, dank, anime

send wholesome
send hot wholesome
send dank
send hot dank
send anime
send hot anime
send kemonomimi
send hot kemonomimi
issue to link #2

It's not much bunch ctrl c and ctrl v

You're supposed to say resolve #2

Oh me is dummy

@Huy-Ngo I have changed cmds by request


Incomplete data for Salt Spring Sailings

I am working on a way for salt springers to monitor the relevant ferries easier, but I am missing a bunch of data.
Here's some examples, the only route information I can find for Tsawwassen to Long Harbour is here:
https://www.bcferriesapi.ca/api/TSA/SGI/
This is good data for that route, but there is no inverse, I cannot get any data from SGI to TSA (Long Harbour to Tsawwassen) which is actually the more relevant information for salt springers.
When it comes to Fulford Harbour there's varying data so v2/capacity/ I can get good data including status for sailings from SWB to FUL in addition to the actual times the boats left and arrived which is very nice. But then for the inverse https://www.bcferriesapi.ca/api/FUL/SWB/ is all I have, and its decent because it does have an isCancelled bool, but there's no information on when the ferry actually left.
Lastly, Crofton to Vesuvius all that's available is the non-capacity api which produces the generic schedule. So I cannot tell if anything has been cancelled or running late or anything.
Am I missing something? Is this data available elsewhere? If not, is there any way to extend to have this data?
Thanks!

Hi @dennislbc,
This API scrapes the https://bcferries.com web pages for its data, and so its limited to what BC Ferries put on the web site.
I can't find any realtime data pages for Fulford Harbour anywhere on https://bcferries.com (unless you can share the link here). If that is the case, then we're out of luck until BC Ferries decide to publish that data.

Hi @dennislbc,
This API scrapes the https://bcferries.com web pages for its data, and so its limited to what BC Ferries put on the web site.
I can't find any realtime data pages for Fulford Harbour anywhere on https://bcferries.com (unless you can share the link here). If that is the case, then we're out of luck until BC Ferries decide to publish that data.

Hey boss, thanks for the reply. The V2 capacity api shows departure and arrival time data for Swartz Bay to Fulford but not the inverse. Not sure where its scraping it from.
Overview of salt spring data:

Vesuvius to Crofton, no realtime data.
Crofton to Vesuvius, no realtime data.
Swartz Bay to Fulford, realtime data available.
Fulford to Swartz Bay, no realtime data, but cancellation data is available.
Long Harbour to TSA, no realtime data.
TSA to Long Harbour, realtime data available include fill rates.

Only half of the pertinent routes are available for any additional data, almost doesn't seem worth really implementing, especially cause none of the data is for leaving salt spring just coming to. Still has value, but much less than leaving.


I would like to contribute in python. I want make a multiplication table.

Is your feature request related to a problem? Please describe.
I want to make a simple multiplication table using python.
Describe the solution you'd like
It asks a user for a number, then it will show the multiplication table of the user input number.
Languages

[x] Python

can you make this a GUI application otherwise it's way too naive


Console XHR requests show empty response (even with log request and..) in e10s

Use FF Nighly to have e10s.
Go to www.google.com
Enable xor logging (this should come enabled by default)
write something in the google search input
look for the ajax call, open it, look in the response tab, its empty.

If you run the tab in non-e10s mode it works.
additional: json responses that are long (non objects, plain text) gets cropped with "..." and no way to see it completly (it was possible on firebug 2).

I been digging a bit (keep in mind i have ZERO experience developing/debugging firefox addons).
What i could find so far is:
console/xhr/json-viewer.js handles the init when the XHR log is open,
[code]
initTabBody: makeInfallible(function({netInfoBody, file}) {
Trace.sysout("jsonviewer.initTabBody", arguments);
file.requestData("getResponseContent").then(response => {
file.content = response.content;
[...]
[/code]
Now in response.content we should have the content of the XHR response, but in the e10s windows, this content.TEXT has garbage characters, for ex, the google example sets the var with:
""
when in the non e10s window, the var has:
"["gdd",[["gdd\u003cb\u003er5\u003c/b\u003e",0],["gdd\u003cb\u003er5 vs ddr3\u003c/b\u003e",0],["gdd",0],["gdd\u003cb\u003ekia\u003c/b\u003e",0],["gdd\u003cb\u003er3 vs gddr5\u003c/b\u003e",0],["gdd\u003cb\u003er6\u003c/b\u003e",0],["gdd\u003cb\u003er5 vs ddr5\u003c/b\u003e",0],["gdd\u003cb\u003er\u003c/b\u003e",0],["\u003cb\u003eddrescue\u003c/b\u003e",0,[10],{"za":"\u003csc\u003eddrescue\u003c/sc\u003e","zb":"\u003cse\u003egddrescue\u003c/se\u003e"}],["gdd\u003cb\u003er3\u003c/b\u003e",0]],{"j":"4n","q":"FbPfJb6tXJgxPHLb_Fx3gItdzEs"}]"
So thats the issue right there, the content.TEXT comes with corrupted data, now we have to find WHY does it throw corrupted data

is anyone working on this issues?

I can't reproduce that using the Nightly of the 2015-05-10. Here is a screencast:
https://drive.google.com/file/d/0B5NqEPwxS4QwZXpyN0hmUDNDeGM/view?usp=sharing
Do I have other steps to include in the scenario?
Otherwise, have you tried using a fresh Firefox profile to test whether it works?
Thanks in advance,
Florent

okay, updated ff to the one of 05-10, it seems to work now, seems like they fixed it, thanks for your reply!

You're welcome. Thanks for the report and the feedback!
Florent


Add max-file-line-count rule

Adds the rule max-file-line-count to enforce the length of a file
If a file exceeds the default / user specified line count the following message will be provided:
This file has 301 lines, which exceeds the maximum of 300 lines allowed.
closes #841
<DCO 1.1 Signed-off-by: Dan Purdy<EMAIL_ADDRESS>

Coverage increased (+0.02%) to 97.268% when pulling 8bc0aa7df336587c61978b2c8178683674e225fd on DanPurdy:feature/max-file-line-count into 54c25a93b96574e8e21a6c6312aaba8f558ab246 on sasstools:develop.

Coverage increased (+0.02%) to 97.268% when pulling 8bc0aa7df336587c61978b2c8178683674e225fd on DanPurdy:feature/max-file-line-count into 54c25a93b96574e8e21a6c6312aaba8f558ab246 on sasstools:develop.

Coverage increased (+0.02%) to 97.268% when pulling 8bc0aa7df336587c61978b2c8178683674e225fd on DanPurdy:feature/max-file-line-count into 54c25a93b96574e8e21a6c6312aaba8f558ab246 on sasstools:develop.

Coverage increased (+0.007%) to 97.57% when pulling 8167edec570644d1a28f34da8a0d1912fc85fa44 on DanPurdy:feature/max-file-line-count into 1a1f695921ea72d9edb2f6e270690d18c3fb52d0 on sasstools:develop.

Coverage increased (+0.007%) to 97.579% when pulling bb321cee36754eed37d94ef4f8397a2fc32a7c56 on DanPurdy:feature/max-file-line-count into d2c4ce466feb2a0927e2001ae8da50cc7d111080 on sasstools:develop.


iOS VoiceOver (text-to-voice) doesn't work correctly with the date filter

Description of issue
When VoiceOver is enabled on iOS, attempting to interact with the date filter calendar doesn't go well. Tapping anywhere in the filter UI results in it reading off the entire contents - the Title label (either 'select dates' or ' - '), "Clear", " ", "Sun Mon Tue, Wed, Thu, Fri, Sat", followed by every number in the calendar, then "No events".
You end up being trapped in the filter as you can't tap the CTA button as this just re-triggers the read out of the filter :/
Expected behaviour
It should be possible to tap the "Clear" and CTA (show x events) buttons, the change month arrows, and individual days and have them read out individually. It should then be possible to interact with them by double-tapping on them.
Additionally it should be possible to tap on the selected date range and have that read out.
Steps to reproduce

Enable VoiceOver (Settings > General > Accessibility > VoiceOver)
Go to the events page in the Pride App
Open the date filter
Try to interact with it

You will find yourself in voiceover hell

The only way to get out of the filter at this point (that I found) was to disable VoiceOver.
OS / Browser / Device model
iPhone 7+ iOS 11.0

This issue has been resolved with the latest round of Date filter work


Can't load the checkpoint.pth

Hello, I can't load the checkpoint.pth while testing some images.
Does the pretrained model work?
Thanks a million.

It is OK for me to load the pretrained model. Do you run test.py in the rootdir of the project. Maybe you can show me the specific outputs of the error when you ran the test code and I can find out the problem.

Thanks for replying.
The weird thing is that it doesn't output any error.
The unet is successfully built but the next command which is loading pretrained run infinitely, and can't even use ctrl+z to terminate.
FYI, I'm using Windows' anaconda to run this project.

I may see the problem. What version of Pytorch is used by you? I met the problem when I used Pytorch with latest version. You may try an older version and see if it can help.

It finally works!!!
I'm now using wsl2 under windows 11 with torch==1.5.0 and cuda=10.2.
Thank you for your hard work and reply.


refactor c++ replay

[x]  cache route files
[x]  skip invalid/missing segments.
[x]  read frames from all cameras.(fall back to qcamera)
[x]  thread safe merging segments in correct order
[x] cancel downloading & remove segments in time
[x] merged #22239

resolve #22221 :

fallback to qcams, ideally we don't require video either
stop replay while waiting for video to load (the time is still progressing)
work with only 1 segment routes
show error when route is not found
sometimes replay starts in the second segment
add optional argument for start time
segfaults randomly

the remain issues related with camera will be resolved in #22195

@adeebshihadeh I suggest that this PR can be merged first If possible. Route is needed for  subsequent works, e.g. reliable merging, fall back to qcamera,  test cases.
we can continue to improve class Route later

too complicate,need refactor again

ready for reivew

@adeebshihadeh there is no modelV2 message in DEMO ROUTE

work for this PR is done from my side. It's ready for review and merge.

@adeebshihadeh  work for this PR is done from my side. It's ready for review

work for this PR is done from my side. It's ready for review and merge


⚠ Bofrost.at has degraded performance

In 50e0f9b, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1129 ms

Resolved: Bofrost.at performance has improved in 9b0ea2c.


can't able to tag users or user groups in alerts

Describe the bug
We want to tag users and user groups in every git-hub action failure alert , but couldn't able to do it , even tried with custom flags , not working ,
Please help on this .
To Reproduce
Steps to reproduce the behavior:

create yml file under workflow ex- test.yml
Use below sample code for failure alert
Push changes to git

name: Test
on:
push:
branches:
- test-branch
jobs:
Test:
runs-on: ubuntu-latest
steps:
- name: Set up Go 1.18
uses: actions/setup-go@v2
with:
go-version: 1.181
  - name: Notify slack in case of failure
    if: failure()
    env:
      SLACK_WEBHOOK_URL: ${{ secrets.SLACK_WEBHOOK_URL }}
    uses: act10ns/slack@v1
    with:
      channel: '#test-slack'
      status: ${{ job.status }}
      steps: ${{ toJson(steps) }}
      color: danger

Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):

OS: [e.g. iOS]
Browser [e.g. chrome, safari]
Version [e.g. 22]

Smartphone (please complete the following information):

Device: [e.g. iPhone6]
OS: [e.g. iOS8.1]
Browser [e.g. stock browser, safari]
Version [e.g. 22]

Additional context
Add any other context about the problem here.

Any update on this ?

I'm interested in this as well.
For example I would like to add (not override) a message. Leaving the default message I would like to add @opsteams please review this.
There is no text, field or message I want to replace.

Have a look at this syntax shown here: https://api.slack.com/reference/surfaces/formatting#mentioning-users
You can change the slack.yml template and passed in the ID.

I was hoping for a way to add to the default message and not have to override the whole message.


Master

Coverage remained the same at 37.466% when pulling 4e433293b38c438e5b84400d33587fce972c7ee3 on master into 2c7b4df51a50c7516ac9fbd98acd80739e7b8463 on develop.


利用sf库自定义算法报错

Issue Type
Bug
Source
binary
Secretflow Version
secretflow1.9.0b2
OS Platform and Distribution
ubantu 18.04
Python version
3.10.13
Bazel version
No response
GCC/Compiler version
No response
What happend and What you expected to happen.
参考https://www.secretflow.org.cn/zh-CN/docs/secretflow/v1.9.0b2/tutorial/Split_Learning_for_bank_marketing#%E6%95%B0%E6%8D%AE%E5%87%86%E5%A4%87   利用sf库添加自定义算子时 会报错找不到自定义的结构INFO:root:SL Train Params: {'self': <secretflow.ml.nn.sl.sl_model.SLModel object at 0x7fd8a60e2740>, 'x': VDataFrame(partitions={PYURuntime(alice): <secretflow.data.core.partition.Partition object at 0x7fd8a65fb5e0>, PYURuntime(bob): <secretflow.data.core.partition.Partition object at 0x7fd8a6389870>}, aligned=True), 'y': VDataFrame(partitions={PYURuntime(alice): <secretflow.data.core.partition.Partition object at 0x7fd8a63893f0>}, aligned=True), 'batch_size': 128, 'epochs': 10, 'verbose': 1, 'callbacks': None, 'validation_data': (VDataFrame(partitions={PYURuntime(alice): <secretflow.data.core.partition.Partition object at 0x7fd8a6389180>, PYURuntime(bob): <secretflow.data.core.partition.Partition object at 0x7fd8a638ad10>}, aligned=True), VDataFrame(partitions={PYURuntime(alice): <secretflow.data.core.partition.Partition object at 0x7fd8a638a8f0>}, aligned=True)), 'shuffle': True, 'sample_weight': None, 'validation_freq': 1, 'dp_spent_step_freq': 10, 'dataset_builder': None, 'audit_log_params': {}, 'early_stopping_batch_step': 0, 'early_stopping_warmup_step': 0, 'random_seed': 25846, 'audit_log_dir': None}
(pid=9050) 2024-10-25 16:54:41.393455: W tensorflow/compiler/tf2tensorrt/utils/py_utils.cc:38] TF-TRT Warning: Could not find TensorRT
(ActorPartitionAgent pid=8849) /root/miniconda3/lib/python3.10/site-packages/sklearn/base.py:458: UserWarning: X has feature names, but MinMaxScaler was fitted without feature names
(ActorPartitionAgent pid=8849)   warnings.warn(
(ActorPYUSLTFModel pid=9050) Unknown layer: 'residual_block'. Please ensure you are using a `keras.utils.custom_object_scope` and that this object is included in the scope. See https://www.tensorflow.org/guide/keras/save_and_serialize#registering_the_custom_object for details.
(ActorPYUSLTFModel pid=9050) Traceback (most recent call last):
(ActorPYUSLTFModel pid=9050)   File "/root/miniconda3/lib/python3.10/site-packages/ray/_private/serialization.py", line 404, in deserialize_objects
(ActorPYUSLTFModel pid=9050)     obj = self._deserialize_object(data, metadata, object_ref)
(ActorPYUSLTFModel pid=9050)   File "/root/miniconda3/lib/python3.10/site-packages/ray/_private/serialization.py", line 270, in _deserialize_object
(ActorPYUSLTFModel pid=9050)     return self._deserialize_msgpack_data(data, metadata_fields)
(ActorPYUSLTFModel pid=9050)   File "/root/miniconda3/lib/python3.10/site-packages/ray/_private/serialization.py", line 225, in _deserialize_msgpack_data
(ActorPYUSLTFModel pid=9050)     python_objects = self._deserialize_pickle5_data(pickle5_data)
(ActorPYUSLTFModel pid=9050)   File "/root/miniconda3/lib/python3.10/site-packages/ray/_private/serialization.py", line 215, in _deserialize_pickle5_data
(ActorPYUSLTFModel pid=9050)     obj = pickle.loads(in_band)
(ActorPYUSLTFModel pid=9050)   File "/root/miniconda3/lib/python3.10/site-packages/keras/saving/pickle_utils.py", line 48, in deserialize_model_from_bytecode
(ActorPYUSLTFModel pid=9050)     raise e
(ActorPYUSLTFModel pid=9050)   File "/root/miniconda3/lib/python3.10/site-packages/keras/saving/pickle_utils.py", line 46, in deserialize_model_from_bytecode
(ActorPYUSLTFModel pid=9050)     model = saving_lib.load_model(filepath, safe_mode=False)
(ActorPYUSLTFModel pid=9050)   File "/root/miniconda3/lib/python3.10/site-packages/keras/saving/saving_lib.py", line 277, in load_model
(ActorPYUSLTFModel pid=9050)     raise e
(ActorPYUSLTFModel pid=9050)   File "/root/miniconda3/lib/python3.10/site-packages/keras/saving/saving_lib.py", line 242, in load_model
(ActorPYUSLTFModel pid=9050)     model = deserialize_keras_object(
(ActorPYUSLTFModel pid=9050)   File "/root/miniconda3/lib/python3.10/site-packages/keras/saving/serialization_lib.py", line 502, in deserialize_keras_object
(ActorPYUSLTFModel pid=9050)     instance = cls.from_config(inner_config)
(ActorPYUSLTFModel pid=9050)   File "/root/miniconda3/lib/python3.10/site-packages/keras/engine/training.py", line 3053, in from_config
(ActorPYUSLTFModel pid=9050)     inputs, outputs, layers = functional.reconstruct_from_config(
(ActorPYUSLTFModel pid=9050)   File "/root/miniconda3/lib/python3.10/site-packages/keras/engine/functional.py", line 1483, in reconstruct_from_config
(ActorPYUSLTFModel pid=9050)     process_layer(layer_data)
(ActorPYUSLTFModel pid=9050)   File "/root/miniconda3/lib/python3.10/site-packages/keras/engine/functional.py", line 1464, in process_layer
(ActorPYUSLTFModel pid=9050)     layer = deserialize_layer(layer_data, custom_objects=custom_objects)
(ActorPYUSLTFModel pid=9050)   File "/root/miniconda3/lib/python3.10/site-packages/keras/layers/serialization.py", line 265, in deserialize
(ActorPYUSLTFModel pid=9050)     return legacy_serialization.deserialize_keras_object(
(ActorPYUSLTFModel pid=9050)   File "/root/miniconda3/lib/python3.10/site-packages/keras/saving/legacy/serialization.py", line 486, in deserialize_keras_object
(ActorPYUSLTFModel pid=9050)     (cls, cls_config) = class_and_config_for_serialized_keras_object(
(ActorPYUSLTFModel pid=9050)   File "/root/miniconda3/lib/python3.10/site-packages/keras/saving/legacy/serialization.py", line 368, in class_and_config_for_serialized_keras_object
(ActorPYUSLTFModel pid=9050)     raise ValueError(
(ActorPYUSLTFModel pid=9050) ValueError: Unknown layer: 'residual_block'. Please ensure you are using a `keras.utils.custom_object_scope` and that this object is included in the scope. See https://www.tensorflow.org/guide/keras/save_and_serialize#registering_the_custom_object for details.
(ActorPYUSLTFModel pid=9054) Exception raised in creation task: The actor died because of an error raised in its creation task, ray::ActorPYUSLTFModel.__init__() (pid=9054, ip=<IP_ADDRESS>, actor_id=4a5d72347491a6d147dab66c01000000, repr=<abc.ActorPYUSLTFModel object at 0x7f868c037d90>)
(ActorPYUSLTFModel pid=9054)   At least one of the input arguments for this task could not be computed:
(ActorPYUSLTFModel pid=9054) ray.exceptions.RaySystemError: System error: Unknown layer: 'residual_block'. Please ensure you are using a `keras.utils.custom_object_scope` and that this object is included in the scope. See https://www.tensorflow.org/guide/keras/save_and_serialize#registering_the_custom_object for details.
(ActorPYUSLTFModel pid=9054) traceback: Traceback (most recent call last):
Traceback (most recent call last):
  File "/root/secretflow_dsj/secretflow/vfl_resnet_simple_test.py", line 214, in <module>
    history = sl_model.fit(
  File "/root/secretflow_dsj/secretflow/ml/nn/sl/sl_model.py", line 385, in fit
    self.basenet_output_num = {
  File "/root/secretflow_dsj/secretflow/ml/nn/sl/sl_model.py", line 386, in <dictcomp>
    device: reveal(worker.get_basenet_output_num())
  File "/root/secretflow_dsj/secretflow/device/driver.py", line 162, in reveal
    all_object = sfd.get(all_object_refs)
  File "/root/secretflow_dsj/secretflow/distributed/primitive.py", line 158, in get
    return ray.get(object_refs)
  File "/root/miniconda3/lib/python3.10/site-packages/ray/_private/auto_init_hook.py", line 22, in auto_init_wrapper
    return fn(*args, **kwargs)
  File "/root/miniconda3/lib/python3.10/site-packages/ray/_private/client_mode_hook.py", line 103, in wrapper
    return func(*args, **kwargs)
  File "/root/miniconda3/lib/python3.10/site-packages/ray/_private/worker.py", line 2626, in get
    raise value
ray.exceptions.RayActorError: The actor died because of an error raised in its creation task, ray::ActorPYUSLTFModel.__init__() (pid=9050, ip=<IP_ADDRESS>, actor_id=fad19472ad3ee9e291d4d0a201000000, repr=<abc.ActorPYUSLTFModel object at 0x7f3a18f27dc0>)
  At least one of the input arguments for this task could not be computed:
ray.exceptions.RaySystemError: System error: Unknown layer: 'residual_block'. Please ensure you are using a `keras.utils.custom_object_scope` and that this object is included in the scope. See https://www.tensorflow.org/guide/keras/save_and_serialize#registering_the_custom_object for details.
traceback: Traceback (most recent call last):
  File "/root/miniconda3/lib/python3.10/site-packages/keras/saving/pickle_utils.py", line 48, in deserialize_model_from_bytecode
    raise e
  File "/root/miniconda3/lib/python3.10/site-packages/keras/saving/pickle_utils.py", line 46, in deserialize_model_from_bytecode
    model = saving_lib.load_model(filepath, safe_mode=False)
  File "/root/miniconda3/lib/python3.10/site-packages/keras/saving/saving_lib.py", line 277, in load_model
    raise e
  File "/root/miniconda3/lib/python3.10/site-packages/keras/saving/saving_lib.py", line 242, in load_model
    model = deserialize_keras_object(
  File "/root/miniconda3/lib/python3.10/site-packages/keras/saving/serialization_lib.py", line 502, in deserialize_keras_object
    instance = cls.from_config(inner_config)
  File "/root/miniconda3/lib/python3.10/site-packages/keras/engine/training.py", line 3053, in from_config
    inputs, outputs, layers = functional.reconstruct_from_config(
  File "/root/miniconda3/lib/python3.10/site-packages/keras/engine/functional.py", line 1483, in reconstruct_from_config
    process_layer(layer_data)
  File "/root/miniconda3/lib/python3.10/site-packages/keras/engine/functional.py", line 1464, in process_layer
    layer = deserialize_layer(layer_data, custom_objects=custom_objects)
  File "/root/miniconda3/lib/python3.10/site-packages/keras/layers/serialization.py", line 265, in deserialize
    return legacy_serialization.deserialize_keras_object(
  File "/root/miniconda3/lib/python3.10/site-packages/keras/saving/legacy/serialization.py", line 486, in deserialize_keras_object
    (cls, cls_config) = class_and_config_for_serialized_keras_object(
  File "/root/miniconda3/lib/python3.10/site-packages/keras/saving/legacy/serialization.py", line 368, in class_and_config_for_serialized_keras_object
    raise ValueError(
ValueError: Unknown layer: 'residual_block'. Please ensure you are using a `keras.utils.custom_object_scope` and that this object is included in the scope. See https://www.tensorflow.org/guide/keras/save_and_serialize#registering_the_custom_object for details.
(ActorPYUSLTFModel pid=9050) WARNING:absl:Skipping variable loading for optimizer 'Adam', because it has 9 variables whereas the saved optimizer has 1 variables.
(pid=9054) 2024-10-25 16:54:41.430614: W tensorflow/compiler/tf2tensorrt/utils/py_utils.cc:38] TF-TRT Warning: Could not find TensorRT
(ActorPYUSLTFModel pid=9054) Unknown layer: 'residual_block'. Please ensure you are using a `keras.utils.custom_object_scope` and that this object is included in the scope. See https://www.tensorflow.org/guide/keras/save_and_serialize#registering_the_custom_object for details.
(ActorPYUSLTFModel pid=9054) Traceback (most recent call last):
(ActorPYUSLTFModel pid=9054)   File "/root/miniconda3/lib/python3.10/site-packages/ray/_private/serialization.py", line 404, in deserialize_objects
(ActorPYUSLTFModel pid=9054)     obj = self._deserialize_object(data, metadata, object_ref)
(ActorPYUSLTFModel pid=9054)   File "/root/miniconda3/lib/python3.10/site-packages/ray/_private/serialization.py", line 270, in _deserialize_object
(ActorPYUSLTFModel pid=9054)     return self._deserialize_msgpack_data(data, metadata_fields)
(ActorPYUSLTFModel pid=9054)   File "/root/miniconda3/lib/python3.10/site-packages/ray/_private/serialization.py", line 225, in _deserialize_msgpack_data
(ActorPYUSLTFModel pid=9054)     python_objects = self._deserialize_pickle5_data(pickle5_data)
(ActorPYUSLTFModel pid=9054)   File "/root/miniconda3/lib/python3.10/site-packages/ray/_private/serialization.py", line 215, in _deserialize_pickle5_data
(ActorPYUSLTFModel pid=9054)     obj = pickle.loads(in_band)
(ActorPYUSLTFModel pid=9050)   File "/root/miniconda3/lib/python3.10/site-packages/keras/saving/pickle_utils.py", line 46, in deserialize_model_from_bytecode [repeated 6x across cluster] (Ray deduplicates logs by default. Set RAY_DEDUP_LOGS=0 to disable log deduplication, or see https://docs.ray.io/en/master/ray-observability/ray-logging.html#log-deduplication for more options.)
(ActorPYUSLTFModel pid=9050)     raise e [repeated 6x across cluster]
(ActorPYUSLTFModel pid=9050)     model = saving_lib.load_model(filepath, safe_mode=False) [repeated 3x across cluster]
(ActorPYUSLTFModel pid=9050)   File "/root/miniconda3/lib/python3.10/site-packages/keras/saving/saving_lib.py", line 242, in load_model [repeated 6x across cluster]
(ActorPYUSLTFModel pid=9050)     model = deserialize_keras_object( [repeated 3x across cluster]
(ActorPYUSLTFModel pid=9050)   File "/root/miniconda3/lib/python3.10/site-packages/keras/saving/legacy/serialization.py", line 486, in deserialize_keras_object [repeated 6x across cluster]
(ActorPYUSLTFModel pid=9050)     instance = cls.from_config(inner_config) [repeated 3x across cluster]
(ActorPYUSLTFModel pid=9050)   File "/root/miniconda3/lib/python3.10/site-packages/keras/engine/training.py", line 3053, in from_config [repeated 3x across cluster]
(ActorPYUSLTFModel pid=9050)     inputs, outputs, layers = functional.reconstruct_from_config( [repeated 3x across cluster]
(ActorPYUSLTFModel pid=9050)   File "/root/miniconda3/lib/python3.10/site-packages/keras/engine/functional.py", line 1483, in reconstruct_from_config [repeated 3x across cluster]
(ActorPYUSLTFModel pid=9050)     process_layer(layer_data) [repeated 3x across cluster]
(ActorPYUSLTFModel pid=9050)   File "/root/miniconda3/lib/python3.10/site-packages/keras/engine/functional.py", line 1464, in process_layer [repeated 3x across cluster]
(ActorPYUSLTFModel pid=9050)     layer = deserialize_layer(layer_data, custom_objects=custom_objects) [repeated 3x across cluster]
(ActorPYUSLTFModel pid=9050)   File "/root/miniconda3/lib/python3.10/site-packages/keras/layers/serialization.py", line 265, in deserialize [repeated 3x across cluster]
(ActorPYUSLTFModel pid=9050)     return legacy_serialization.deserialize_keras_object( [repeated 3x across cluster]
(ActorPYUSLTFModel pid=9050)     (cls, cls_config) = class_and_config_for_serialized_keras_object( [repeated 3x across cluster]
(ActorPYUSLTFModel pid=9050)   File "/root/miniconda3/lib/python3.10/site-packages/keras/saving/legacy/serialization.py", line 368, in class_and_config_for_serialized_keras_object [repeated 3x across cluster]
(ActorPYUSLTFModel pid=9050)     raise ValueError( [repeated 3x across cluster]
(ActorPYUSLTFModel pid=9050) ValueError: Unknown layer: 'residual_block'. Please ensure you are using a `keras.utils.custom_object_scope` and that this object is included in the scope. See https://www.tensorflow.org/guide/keras/save_and_serialize#registering_the_custom_object for details. [repeated 3x across cluster]
(ActorPYUSLTFModel pid=9050) Exception raised in creation task: The actor died because of an error raised in its creation task, ray::ActorPYUSLTFModel.__init__() (pid=9050, ip=<IP_ADDRESS>, actor_id=fad19472ad3ee9e291d4d0a201000000, repr=<abc.ActorPYUSLTFModel object at 0x7f3a18f27dc0>)
(ActorPYUSLTFModel pid=9050)   At least one of the input arguments for this task could not be computed:
(ActorPYUSLTFModel pid=9050) ray.exceptions.RaySystemError: System error: Unknown layer: 'residual_block'. Please ensure you are using a `keras.utils.custom_object_scope` and that this object is included in the scope. See https://www.tensorflow.org/guide/keras/save_and_serialize#registering_the_custom_object for details.
(ActorPYUSLTFModel pid=9050) traceback: Traceback (most recent call last):

Reproduction code to reproduce the issue.
/

麻烦发一下您自定义的算子和注册算子相关的代码。

vfl_resnet.txt
是想在在本地进行测试

麻烦发一下您自定义的算子和注册算子相关的代码。

参考的;https://www.secretflow.org.cn/zh-CN/docs/secretflow/v1.9.0b2/tutorial/Split_Learning_for_bank_marketing#数据准备

可以参照官网上的示例代码进行修改，比如：base_model和fuse_model的定义方法。https://www.secretflow.org.cn/zh-CN/docs/secretflow/v1.9.0b2/tutorial/Split_Learning_for_bank_marketing#定义模型


⚠ File access has degraded performance

In f348ac6, File access (https://fyle.uk/file/fish) experienced degraded performance:

HTTP code: 200
Response time: 7059 ms

Resolved: File access performance has improved in fe57c11 after 8 minutes.


photoprism nixos module: cannot use /var/lib/photoprism/photoprism-manage

Describe the bug
Cannot use script /var/lib/photoprism/photoprism-manage created by the photoprism nixos module.
Steps To Reproduce
Example config:
    services = {
      photoprism = {
        enable = true;
        port = 2342;
        originalsPath = "/var/lib/private/photoprism/originals";
        # importPath = "/home/pablo/Android/Camera";
        address = "<IP_ADDRESS>";
        settings = {
          PHOTOPRISM_ADMIN_USER = "admin";
          PHOTOPRISM_ADMIN_PASSWORD = "admin";
          PHOTOPRISM_DEFAULT_LOCALE = "en";
          PHOTOPRISM_DATABASE_DRIVER = "mariadb";
          PHOTOPRISM_DATABASE_NAME = "photoprism";
          PHOTOPRISM_DATABASE_SERVER = "/run/mysqld/mysqld.sock";
          PHOTOPRISM_DATABASE_USER = "photoprism";
          # PHOTOPRISM_SITE_URL = "http://sub.domain.tld:2342";
          PHOTOPRISM_SITE_TITLE = "My PhotoPrism";
        };
      };
      mysql = {
        enable = true;
        # dataDir = "/data/mysql";
        package = pkgs.mariadb;
        ensureDatabases = [ "photoprism" ];
        ensureUsers = [
          {
            name = "root";
            ensurePermissions = {
              "*.*" = "ALL PRIVILEGES";
            };
          }
          {
            name = "pablo";
            ensurePermissions = {
              "*.*" = "ALL PRIVILEGES";
            };
          }
          {
            name = "photoprism";
            ensurePermissions = {
              "photoprism.*" = "ALL PRIVILEGES";
            };
          }
        ];
      };
    };

And then with the instance up and running:
root@nixos ~
❯ /var/lib/photoprism/photoprism-manage users ls
ERRO[2024-01-26T18:58:06Z] Error 1698: Access denied for user 'photoprism'@'localhost'

root@nixos ~ 1m 2s
❯ mysql -u photoprism photoprism
ERROR 1698 (28000): Access denied for user 'photoprism'@'localhost'

root@nixos ~
❯ sudo -u photoprism /var/lib/photoprism/photoprism-manage users ls
sudo: unable to execute /var/lib/photoprism/photoprism-manage: Permission denied

root@nixos ~
❯ ls -la $(realpath /var/lib/photoprism/photoprism-manage)
-r-xr-xr-x 1 root root 759 Jan  1  1970 /nix/store/1ip8qpa0625qc4lgzmq0hpc3g5nkvb78-manage

Expected behavior
The photoprism-manage script should work and list the users.
Additional context
Seems that the systemd service running photoprism runs as user photoprism, which mariadb's unix socket auth works correctly. And the photoprism-manage uses the same user photoprism, but do not let root user to access the database as user photoprism. Maybe this can be fix by changing the database user to root but that implies changing that in the systemd service user as well.
Notify maintainers

@Stunkymonkey
Metadata
Please run nix-shell -p nix-info --run "nix-info -m" and paste the result.
[user@system:~]$ nix-shell -p nix-info --run "nix-info -m"
 - system: `"x86_64-linux"`
 - host os: `Linux 6.1.62, NixOS, 23.11 (Tapir), 23.11pre-git`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.18.1`
 - nixpkgs: `/nix/store/mrckm9b3v6wg2fljdp3z4pja1sz07g3z-source`

Add a :+1: reaction to issues you find important.

have a look at https://github.com/NixOS/nixpkgs/pull/207567#issuecomment-1799985107
PRs are welcome.

have a look at #207567 (comment)
PRs are welcome.

Here is the original comment he's referring.
So basically we could change the photoprism-manage script to grab the UID of the photoprism user and the PID of the systemd service and then execute the photoprism binary?


Save/Skip should return user to Review page

As a candidate
I want to be able to quickly change my answer to a question before submitting my test
So that I can make last minute changes

Expected
When a user has reached the Review page for a test then if they follow a link to a question upon clicking Save or Skip they should return to the Review page.
Actual
When a user has reached the Review page for a test then if they follow a link to a question upon clicking Save or Skip they are taken to the next question.
This means user has to cycle through all the remaining questions before they can finish Review and submit their test.

Check if the previous router page is REVIEW - if so, go back to review, otherwise go to the next question.


Feature Request: Local SharedStorage

When using a CustomAMI with a software repository installed it would be great to be able to share that without putting it into a dedicated EBS Volume.
Something along the lines of:
SharedStorage:
  - Name: Spack Software
    MountDir: /spack
    StorageType: Local
    LocalSettings:
      SourcePath: /opt/spack

The above would export /opt/spack as /spack on all nodes (head node and compute node).

Thank you for the feature request! I marked it as a feature request and shared it with our product manager.

As a general practice, it would be recommended to mount the extra volume through EFS or FSx instead. In the case of using large amount of compute nodes, mounting with EFS and FSx can avoid too much traffic between headnode and computes and get better performance.
Thanks!

The context is that I would like to make use of a CustomAMI as headnode with a pre-installed software stack using Spack.
Using external storage makes populating the software share cumbersome. I'd need to sync it with S3 or something similar.
With the propose solution I could just export the path to all compute nodes as well and off I go.

Thanks for sharing the use case! The request is shared with the PM.

@ChristianKniep can you please confirm that the use case is that you want to modify the installation of the pre-installed software stack (e.g. install other packages) after cluster creation and that the share is needed to keep these changes in sync among all the cluster nodes?


fix: Make all task titles/descriptions read-only to all but the author/assignee.

Explanation of Change

Fixed Issues
$ https://github.com/Expensify/App/issues/52979
PROPOSAL: https://github.com/Expensify/App/issues/52979#issuecomment-2510171819
Tests

[Account A]: Create a new account > complete onboarding and open Concierge chat.
[Account A]: Try to complete the assigned tasks from the preview (should not open the task before doing this step)
[Account A]: Verify task can be completed/incomplete from the task preview checkbox
[Account A]: Open any task > Verify you cannot open task title, description and assignee page.
[Account A]: Verify you can still complete the task using the checkbox
[Account B]: Create a new task (without assignee) in the chat of Account A.
[Account A]: Verify you cannot edit task title, description and assignee page and task status (complete/incomplete)
[Account B]: Assign the task to Account A
[Account A]: Verify you can now edit task title, description and assignee page and task status (complete/incomplete)

[x] Verify that no errors appear in the JS console

Offline tests

[Account A]: Create a new account > complete onboarding and open Concierge chat.
[Account A]: Try to complete the assigned tasks from the preview (should not open the task before doing this step)
[Account A]: Verify task can be completed/incomplete from the task preview checkbox
[Account A]: Open any task > Verify you cannot open task title, description and assignee page.
[Account A]: Verify you can still complete the task using the checkbox
[Account B]: Create a new task (without assignee) in the chat of Account A.
[Account A]: Verify you cannot edit task title, description and assignee page and task status (complete/incomplete)
[Account B]: Assign the task to Account A
[Account A]: Verify you can now edit task title, description and assignee page and task status (complete/incomplete)

QA Steps

[Account A]: Create a new account > complete onboarding and open Concierge chat.
[Account A]: Try to complete the assigned tasks from the preview (should not open the task before doing this step)
[Account A]: Verify task can be completed/incomplete from the task preview checkbox
[Account A]: Open any task > Verify you cannot open task title, description and assignee page.
[Account A]: Verify you can still complete the task using the checkbox
[Account B]: Create a new task (without assignee) in the chat of Account A.
[Account A]: Verify you cannot edit task title, description and assignee page and task status (complete/incomplete)
[Account B]: Assign the task to Account A
[Account A]: Verify you can now edit task title, description and assignee page and task status (complete/incomplete)

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[ ] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

We don't need to use the not-allowed cursor. Just not having the right caret and not being able to click in to edit is enough.
Check out this screenshot from an expense. I can no longer change the merchant or date, but I can still change the description, category, and tag. My cursor is totally normal when I hover over the merchant and date rows, they just don't do anything.

Just realized a video would probably be more clear:
https://github.com/user-attachments/assets/1dd15ce1-9c00-4105-a513-a1bc23db5ad2

Just not having the right caret and not being able to click in to edit is enough.

Totally agree with that. Your video is exactly what we want to happen with tasks.

Agree with the designers 👍

Looks right to me 👍

Yeah that looks right to me too tu

I thought the goal was to make the title and description non-editable, but why would we make it so that you can't interact with the checkbox to complete the task?

Yeah agree with this being unexpected.

@suneox, I think I'm a bit lost on this one. Could you please verify if my understanding of the new behavior is correct?

If a task author is Concierge, the assignee cannot edit the task title or description. However, the assignee can still mark the task as complete or incomplete.

@Krishna2323 Correct, based on this confirmation

For all other tasks (author is not Concierge), both the author and the assignee can update the task title, description, and completion status.

For other tasks, we should maintain the current logic for canModifyTask and canActionTask function, we're only adding new logic to ensure it returns false for Concierge tasks to prevent regression.
Then we'll introduce a new parameter to skip check the concierge task specifically for the checkbox.

Hmm that's not what we intended as far as I know. The goal here is to make this change for all tasks, regardless of user.
Cc @Expensify/design @puneetlath can you please confirm?

The goal here is to make this change for all tasks, regardless of user.
Cc @Expensify/design @puneetlath can you please confirm?

To be honest I'm not sure where we landed. I'm personally for making it a global change, but I think some people in Slack wanted to just do it with Concierge tasks. But with certain onboarding tasks moving to the #admins room and coming from a set up specialist, I think it makes much more sense to apply this globally.

Let's make the change globally please @Krishna2323 - I am fairly certain that was the original intention. @quinthar and @puneetlath can confirm.

@shawnborton is this going to be an option setting like you mocked up below, or are we just going to start with it being how tasks work more generally?

The idea is to just change the edibility for all tasks globally so that only the task author can edit the task title and description - no need for a toggle or anything like that.

Ok cool, thanks for confirming!

Let's make the change globally please @Krishna2323 - I am fairly certain that was the original intention. @quinthar and @puneetlath can confirm.

I agree. Let's make all tasks behave the same way, not just for Concierge.

That looks right to me. Gut check from @Expensify/design

Yup, looks good to me too!

Just so I'm totally understanding: have we updated the tasks so that only the author or the person assigned can complete/uncomplete the task? Just wanted to double-check that behavior, other than that, it looks good to me too.

Just looking at this part of the video (around 1:28) and seeing the checkbox and mark as complete button disabled. So I'm trying to figure out under what conditions those things would be disabled.

Ah, great catch on that - @Krishna2323 what are your thoughts there?

Okay cool, as long as we aren't changing anything about that behavior then we're all good 👍

@suneox, you can start reviewing again, I will update the test steps and recording today.

Sure I'll review pr again within a few hours

@suneox, you can start reviewing again, I will update the test steps and recording today.

@Krishna2323 The changes look good; please proceed to update ESLint.

Reviewer Checklist

[x] I have verified the author checklist is complete (all boxes are checked off).
[x] I verified the correct issue is linked in the ### Fixed Issues section above
[x] I verified testing steps are clear and they cover the changes made in this PR

[x] I verified the steps for local testing are in the Tests section
[x] I verified the steps for Staging and/or Production testing are in the QA steps section
[x] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[x] I checked that screenshots or videos are included for tests on all platforms
[x] I included screenshots or videos for tests on all platforms
[x] I verified tests pass on all platforms & I tested again on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[x] I verified proper code patterns were followed (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I verified that this PR follows the guidelines as stated in the Review Guidelines
[x] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

MacOS: Chrome / Safari
https://github.com/user-attachments/assets/e856f90e-43fd-40c1-9c66-6ec379d5063c

MacOS: Desktop
https://github.com/user-attachments/assets/0bf79258-b2c8-4823-bc3d-9b54184ac8de

Android: Native
https://github.com/user-attachments/assets/5ad84c3b-87f0-49fc-ba1e-cc800d072f65

Android: mWeb Chrome
https://github.com/user-attachments/assets/2dffdf6c-4d6d-4279-b7d4-d491fad6d747

iOS: Native
https://github.com/user-attachments/assets/1554232d-406e-49f3-af95-2ae3438be640

iOS: mWeb Safari
https://github.com/user-attachments/assets/e50b5025-431e-444b-9d11-1809947ca2fb

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.


fix(@angular/build): prevent errors with parameterized routes when getPrerenderParams is undefined

Ensure that parameterized routes do not cause errors when the getPrerenderParams function is undefined, specifically in cases where the routing API is not utilized.
Closes #28948

The changes were merged into the following branches: main, 19.0.x


[Feature] request smoothquant (int8, W8A8) quantization on 40G A100

Checklist

[ ] 1. If the issue you raised is not a feature but a question, please raise a discussion at https://github.com/sgl-project/sglang/discussions/new/choose Otherwise, it will be closed.
[ ] 2. Please use English, otherwise it will be closed.

Motivation
We have been using smoothquant (int8, W8A8) quantization on A100 GPU with TensorRT-LLM and recently tested with vLLM as well. The performance is good: speed, memory, and accuracy all are advantageous compared to fp16 or other quantizations.
Can SGLang also support such quantization for A100 machine? My team is very eager to see it coming.
Thanks
Related resources
No response

AWQ and GPTQ both are W8A16; we need W8A8

AWQ and GPTQ are W4A16.
@HandH1998 and @ispobock are collaborating on the W8A8.

AWQ and GPTQ are W4A16.
@HandH1998 and @ispobock are collaborating on the W8A8.

thank you so much for your reply. Is this W8A8 feature going to be smoothquant? If so, when do you expect to have it available? @zhyncs @HandH1998 @ispobock

AWQ and GPTQ are W4A16.
@HandH1998 and @ispobock are collaborating on the W8A8.

thank you so much for your reply. Is this W8A8 feature going to be smoothquant? If so, when do you expect to have it available? @zhyncs @HandH1998 @ispobock

Yes, it's smoothquant.
Maybe next two weeks.


[BUG]: Tag color not change in the first time when edit color

Describe the bug
When clicking change tag color in the assignment. Color won't change in the first time. But it change in the second time that I edit.
Step To Reproduce the bug:

Go to home page and login
Click on the assignment
Click on edit button
Change color
Tag not change color (Bug here)
Click on edit button again
Change color
Tag change their  color

Expected behavior
The color tag should change in the first time that I edit
Screenshots

Hardware Spec (please complete the following information):

Device: Computer
OS: window10
Browser: Google Chrome
Version: 96.0.4664.45 (Official Build) (64-bit)

Thank you for reporting this to me. I can definitely reproduce the bug now. It seems that it is the problem with our color picker tools. This will be fixed soon.

This has been fixed in #49 and has been deployed to the production environment. Thank you again for reporting this to us.


Edit Data: On edit data the table name isn't shown anywhere

Azure Data Studio Version:

Steps to Reproduce:

Open any table and right click to launch edit data.

Expected:
It should open table in edit mode and show the table name on the title-header.
Current behavior:
It opens the table in edit mode but doesn't show the table name info anywhere. It shows the query instead of the table-name now.

I see this issue again.

This looks like the same underlying issue as https://github.com/microsoft/azuredatastudio/issues/9058.  And should be fixed in today's release/1.16 build.

Closing as duplicate of #9058 which is fixed in today's build


Use of Semi-Supervised Learning

I am very interested semi-supervised learning part of your work. So I want to know how to run the semi-supervised training? Thanks for your great work.

First, create your 1% or 10% ImageNet subsets using preprocess_datasets.py.
Then you can use the same scripts like scripts/fusion.sh or scripts/feedback.sh. But you need to update the following flags:

--data_dir and --val_data_dir to the newly created subset paths.
--mode=finetune instead of --mode=freeze
--lr may need to be tuned and --batch_size needs to be updated to whatever fits on your GPU. Here are our settings:

1% DifFormer: --lr=1e-2 --batch_size=2
10% DifFeed: --lr=1e-2 --batch_size=2
1% DifFeed: --lr=1e-2 --batch_size=4
10% DifFeed: --lr=1e-2 --batch_size=4


TextureComputeColor misses some settings

mburk
The Address Mode on the TextureMaterial isn't doing anything. And I'd also need to set the border color.
mburk
The SamplerState seems to be hidden away in the ComputeTextureColor

now included new input nodes


Add chatgpt-shroud to AI Tools List

This PR adds the chatgpt-shroud project to the list of AI tools.
chatgpt-shroud is a Chrome extension that enhances user privacy on OpenAI's ChatGPT by allowing easy hiding and unhiding of chat history, making it ideal for maintaining privacy during screen shares.

Thanks for contribution!


modifyQueryUsing in default table query gives incorrect record in table Action

Package
filament/filament
Package Version
3.2.55
Laravel Version
10
Livewire Version
No response
PHP Version
8.3.0
Problem description
In the filament resource, when the original table query is modified by using modifyQueryUsing and multiple whereIn() and OrWhereIn() conditions, the actions per row uses the same record instead of referring to unique records.
public static function table(Table $table): Table
{
    return $table
          ->modifyQueryUsing(function (Builder $query) {
              $query
                  ->whereIn('id',[1,2,3,4,5])
                  ->OrWhereIn('id',[1,2,3,4,5]);
          })
          ->columns([
              TextColumn::make('id'),
              TextColumn::make('name'),
          ])
          ->actions([
              Action::make('action')
              ->label('Take Action')
              ->modalHeading(function(User $user){
                  return 'Taking Action on user '.$user->id.' ('.$user->name.')';
                  })
                  ->button()
    ]);
}

Expected behavior
Clicking on the "Take Action" button should have given the heading specific to the row selected as

Taking Action on user 1 (Test User)
Taking Action on user 2 (Dr. Jaiden Satterfield)
Taking Action on user 3 (Dr. Lia Gaylord)
Taking Action on user 4 (Murray Flatley)
Taking Action on user 5 (Lavada Grady)

However, it is showing

Taking Action on user 1 (Test User)
Taking Action on user 1 (Test User)
Taking Action on user 1 (Test User)
Taking Action on user 1 (Test User)
Taking Action on user 1 (Test User)

regardless of whichever "Take Action" button is clicked.
Steps to reproduce
The simplest code fragment below is enough to replicate the issue. I have modified the original table query to only show rows which have the id as 1,2,3,4,5. The problem occurs when multiple OrWhereIn conditions are used.
return $table
  ->modifyQueryUsing(function (Builder $query) {
      $query
          ->whereIn('id',[1,2,3,4,5])
          ->OrWhereIn('id',[1,2,3,4,5]);
  })

Because of the above, clicking on any "Take Action" button gives the same output

Reproduction repository
https://github.com/yashdesai87/filament-modifyqueryusing-issue
Relevant log output
No response

Wrap the clauses in a single ->where() group https://laravel.com/docs/11.x/queries#logical-grouping

Thank you. This worked.

Thank you. This worked.

Merci. Cela a fonctionné.


go.mod: create a new module for the api package

This commit adds the go.mod and go.sum files for the api package to make it an independent module. The go.mod file at the top dir now references this new module with a replace directive.
In the next PR, we will remove the replace line and add the dependency using the latest commit.

The e2e workflow is supposed to fail here due to the use of a local dir path in the replace directive.


Error when trying to start tray-item from a spawned thread in linux

I'm trying to combine tray-item and druid so that I can show a window from a tray-item event (e.g. clicking a menu entry).
I'm using druid to create a window (which will be initially hidden), and give trayitem the handler to send commands to so the window can react to menu events from system tray.
My code is as follows:
pub fn create_window() -> Result<(), PlatformError> {
    let main_window = WindowDesc::new(build_root_widget)
        .title("Some window")
        .window_size((400.0, 400.0));

    let initial_state: HelloState = HelloState { name: "World".into() };

    let launcher = AppLauncher::with_window(main_window);
    let event_sink = launcher.get_external_handle();
    thread::spawn(move || create_tray_icon(event_sink));
    // ...
}

fn create_tray_icon(event_sink: ExtEventSink) {
    gtk::init().unwrap();
    let mut tray = TrayItem::new("Some Example", "accessories-calculator").unwrap();
    // ... other code as per linux.rs example.
}

// ... other functions to build the UI, etc.

So I'm using thread::spawn to create the tray item.
However, I'm getting the following error when the gtk::init() is run:
Gdk-ERROR **: 12:57:41.458: The program 'jack-testing' received an X Window System error.
This probably reflects a bug in the program.
The error was 'BadImplementation (server does not implement operation)'.
  (Details: serial 162 error_code 17 request_code 20 (core protocol) minor_code 0)
  (Note to programmers: normally, X errors are reported asynchronously;
   that is, you will receive the error a while after causing it.
   To debug your program, run it with the GDK_SYNCHRONIZE environment
   variable to change this behavior. You can then get a meaningful
   backtrace from your debugger if you break on the gdk_x_error() function.)

Is it possible to create the tray in a separate thread in linux?
Cheers,
Mark

Unfortunately not. GTK requires that the gtk_main thread is the main thread in your program


Turtlebot4 Navigation Example Error "frame 'rplidar_link' at time<PHONE_NUMBER>.141 for reason 'the timestamp on the message is earlier than all the data in the transform cache'"

Robot Model
Turtlebot4 Standard
ROS distro
Humble
Networking Configuration
Simple Discovery
OS
Ubuntu 22.04
Built from source or installed?
Installed
Package version
Package: ros-humble-turtlebot4-navigation
Status: install ok installed
Priority: optional
Section: misc
Installed-Size: 2470
Maintainer: rkreinin<EMAIL_ADDRESS>Architecture: amd64
Version: 1.0.4-1jammy.20240217.111144
Depends: ros-humble-nav2-bringup, ros-humble-nav2-simple-commander, ros-humble-slam-toolbox, ros-humble-ros-workspace
Description: Turtlebot4 Navigation
Type of issue
Navigation (SLAM, Nav2 etc.)
Expected behaviour
The navigation tutorial to produce a map with lidar scan points overlay and a functional navigation path.
Actual behaviour
When following the navigation tutorial https://turtlebot.github.io/turtlebot4-user-manual/tutorials/navigation.html the first command that is ask you to run ros2 launch turtlebot4_navigation localization.launch.py map:=office.yaml runs but produced the following error that seems to be causing failure in subsequent steps.
Error:
[amcl-2] [INFO] [1709940494.277377550] [amcl]: Message Filter dropping message: frame 'rplidar_link' at time<PHONE_NUMBER>.141 for reason 'the timestamp on the message is earlier than all the data in the transform cache'
Error messages
[amcl-2] [INFO] [1709940494.277377550] [amcl]: Message Filter dropping message: frame 'rplidar_link' at time<PHONE_NUMBER>.141 for reason 'the timestamp on the message is earlier than all the data in the transform cache'

To Reproduce
ros2 launch turtlebot4_navigation localization.launch.py map:=office.yaml
Other notes
I have looked and this seems to be a common error in recent months. I attempted all solutions recommended which include updating the turtlebot and my system, moving to cyclonedds, and attempting to sync the Create3 NTP server.
Any help would be appreciated as this is a complete blocker and renders our turtlebot useless.

Hello @Christian-Prather,
Thank you for reaching out on the official Turtlebot 4 Github page. I am very sorry to hear that you are encountering an issue. Out of curiosity, when you attempted to sync the Create3's NTP server, were you successful? Was there an error output?
Are using an internet enable network for the Raspberry Pi to be able to sync it's time? Is your computer connected to the same network and syncing its time using the network?
Would it be possible to try and use timesyncd to sync the time between the Raspberry Pi and your computer (https://ubuntu.com/server/docs/use-timedatectl-and-timesyncd).
Looking forward to hearing from you soon.
Best Regards,
Saif

Hello @smatarCPR
To try and answer your questions the pi is attached to internet enabled wifi and the NTP I thought did not have errors however I have attached the latest logs and latest ntp config. There error is very persistent.

create3-logs.txt

Its also worth noting that since I saw no improvement with cyclone I rolled back to default fast_dds

I have a similar timestamp issue. Using the 1.0.4 version ros-humble-turtlebot4-navigation package.

I am also having an issue similar to this. I get the same error that the lidar message time is earlier than all the data in the transform cache.

Additional update I have changed over the system and my laptop to use the discovery server and while the topics seem to show up more reliably on my laptop the same error reported occurs when running the example localization node.

Since this seems to be a hot topic right now I am going to try and drop a bunch of general information here that I am hoping will be helpful to a number of you.
If you are running simulation then stop here, none of the below applies and your issue is likely on how you are launching the nodes (sim time vs real time). If you are using a physical robot then continue:
Both the Raspberry Pi and the Create3 drive base will sync their time with the internet by default. So there are a few different configurations and what could be causing your issues:

Simple Discovery - As long as your network is connected to the internet then all you should need to do is to make sure that your laptop is also syncing time with the internet and these should all match (for default ubuntu you can check using timedatectl status - this also works on the raspberry pi). If you still seem to be seeing issues then it could be helpful to reboot the robot and your PC and potentially restart the ntpd from the create3 webserver. Similarly try forcing a time sync on your laptop. (More details on how to check last time sync etc on ubuntu here -> it isn't sufficient to visually check and say that the time on your laptop looks right, they need to be the same )

Discovery Server - As long as your network is connected to the internet then all you should need to do is to make sure that your laptop is also syncing time with the internet (see the command to check this in option 1) AND redirect the create3 drive base to sync time with the raspberry pi (instructions here)

If your system is not connected to the internet then you will need to modify the timesyncing on both the create3 and raspberry pi. If you are using discovery server then still point the create3 at the raspberry pi (instructions here) and then point the raspberry pi at an NTP server on your PC. If it is simple discovery you can still do that or point both at your own NTP server.

A final note: If you look at what node and what topic are shown in the error then that will point you towards which devices are out of sync. For example, if you are running navigation on your laptop and that is where you are seeing the error pop up (the amcl node is part of the nav packages) then that tells you that your laptop is one of the pieces that is not in sync. Then you can look at the topic that it is not in sync with, and which device published that topic. In the case of the lidar, it is published by the Raspberry Pi. So as much as it is good to make sure that the create3 is in sync, that is not causing the particular issue being presented.

Hello,
This issue is being closed due to inactivity. If you are still experiencing the issue, feel free to reopen this ticket when you are ready to continue the troubleshooting process.
Best Regards,
Saif


Fix breaking changes in FastBoot 1.0

The current ember-cli-fastboot releases (1.0.0-rc.1 and above) introduce breaking changes. These will most likely break your current FastBoot implementation.
See https://github.com/ember-fastboot/ember-cli-fastboot/issues/387 for more information and a guide on how to fix your addon. Also you may want to visit the -fastboot Slack channel to get help from other users.
Note: this issue has been created automatically, by searching for certain patterns in your code. If you think this has been falsely created, feel free to close!

Fixed by https://github.com/altrim/ember-cli-tooltipster/pull/42


PPF-324: deprecate v1

Codecov Report
Base: 100.00% // Head: 100.00% // No change to project coverage :thumbsup:

Coverage data is based on head (04a7c96) compared to base (e1a35b4).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##            master      #325    +/-   ##
==========================================
  Coverage   100.00%   100.00%
==========================================
  Files           19        14     -5
  Lines          901       522   -379
==========================================
- Hits           901       522   -379

Impacted Files
Coverage Δ

PyPDFForm/core/constants.py
100.00% <ø> (ø)

PyPDFForm/core/font.py
100.00% <ø> (ø)

PyPDFForm/core/image.py
100.00% <ø> (ø)

PyPDFForm/middleware/element.py
100.00% <ø> (ø)

PyPDFForm/__init__.py
100.00% <100.00%> (ø)

PyPDFForm/core/filler.py
100.00% <100.00%> (ø)

PyPDFForm/core/template.py
100.00% <100.00%> (ø)

PyPDFForm/core/utils.py
100.00% <100.00%> (ø)

PyPDFForm/middleware/adapter.py
100.00% <100.00%> (ø)

PyPDFForm/middleware/template.py
100.00% <100.00%> (ø)

... and 1 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


ggml-alpaca-7b-q4.bin: invalid model file (bad magic [got 0x67676d66 want 0x67676a74])

When loading the converted ggml-alpaca-7b-q4.bin model, I met the error:
>>> llm = LlamaCpp(model_path="ggml-alpaca-7b-q4.bin")
llama_model_load: loading model from 'ggml-alpaca-7b-q4.bin' - please wait ...
ggml-alpaca-7b-q4.bin: invalid model file (bad magic [got 0x67676d66 want 0x67676a74])
        you most likely need to regenerate your ggml files
        the benefit is you'll get 10-100x faster load times
        see https://github.com/ggerganov/llama.cpp/issues/91
        use convert-pth-to-ggml.py to regenerate from original pth
        use migrate-ggml-2023-03-30-pr613.py if you deleted originals
llama_init_from_file: failed to load model

Hi @abetlen
Thanks for your help.  I believe https://github.com/hwchase17/langchain/pull/2393 could help.

migrate-ggml-2023-03-30-pr613.py does not seem to exist on this repo: https://github.com/ggerganov/llama.cpp.git

I also can't find it

doest start converting
> PS C:\Users\dex\Desktop\gpt4free\voice_chatbot\migrate_models\llama.cpp> python3 convert.py ggml-vic7b-uncensored-q5_1.bin ggml-vic7b-uncensored-q5_1_new.bin

Python

python convert x.bin --outfile x_new.bin
or
python3 convert x.bin --outfile x_new.bin

doest start converting
> PS C:\Users\dex\Desktop\gpt4free\voice_chatbot\migrate_models\llama.cpp> python3 convert.py ggml-vic7b-uncensored-q5_1.bin ggml-vic7b-uncensored-q5_1_new.bin

Python

I'm having the same issue. Converting did not help.
./main -m models/7B/ggml-model-q4_0_new.bin
main: seed =<PHONE_NUMBER>
llama_model_load: loading model from 'models/7B/ggml-model-q4_0_new.bin' - please wait ...
llama_model_load: invalid model file 'models/7B/ggml-model-q4_0_new.bin' (bad magic)
main: failed to load model from 'models/7B/ggml-model-q4_0_new.bin'

i met the same bug like @AlekzNet , anyone has solution ? i've run convert.py successfully then i run ./main -m models/7B/ggml-model-q4_0_new.bin but it show bad magic


add folded lightcurves to the 'group' page

We need to be able to see the folded lightcurve on the 'group' page, instead of clicking on the objects and having to open a new window. This needs to be done in skyportal.

@janvanroestel Do you mean the source table page?

I see that the phased light curves are now seen on the group page. Thats is great (and very helpful).
I noticed that not all sources have the phased light curves though. Any idea why? I have attached a picture. (what is the "0" following the "No spectra exist"?)
Also, can we add the period itself - may be on the x-label, or the top-label?
(Is what is called DR8 the DR8 of SDSS or ZTF? That should be clarified in that figure's caption).

@AshishMahabal Not all objects have a period annotation, they need annotations well to appear.

It looks like this issue has been mostly addressed in Skyportal, since I can view folded light curves in the source dropdown. The default period (= 1 d) for sources without an uploaded period will ensure this panel is always displayed if photometry is available. Period annotations are also shown in the dropdown. Ashish's question about DR8 (SDSS or ZTF?) remains, though.

@bfhealy I think we should either rename the issue or close this one and open another. It is challenging of course if one issue has multiple different things reported.

I agree, I think it's best to close this one and open another. Should the new one be posted to Skyportal instead of here?

@bfhealy agreed.


Fix 3d map plotting - saving and return values.

Fixed plot saving functionality for 3D maps and correct return types. Also added default dpi value and related argument. Started listing/implementing unit test for plot function, but not sure how necessary this is?!

cool, very much appreciated! Happy to merge this, or is it still work in progress?

cool, very much appreciated! Happy to merge this, or is it still work in progress?

Only the (commented) part in the test_Map function is unfinished. I could remove those or actually implement some basic tests (if wanted?), but I don't see myself finding time before the collaboration meeting, unfortunately.

There is a conflict that prevents me from merging. @LeanderFischer could you fix that one and then we'll merge


[BEAM-14051] Add a warning to gradle.properties that many Beam modules override the project version value defined there.

Suggest to also update the version in BeamModulePlugin.groovy if you
need to customize it.
R:@robertwb

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[x] Choose reviewer(s) and mention them in a comment (R: @username).
[ ] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

Run CommunityMetrics PreCommit

Run Python_PVR_Flink PreCommit

CommunityMetrics PreCommit is broken: BEAM-14017


Reduce Scope of IAM User policy during Installation

AWS best practices dictates that IAM Users and Roles should have the most restrictive policies possible for their function. The installation guide recommends creating a user with Administrator access to the AWS account. The scope of the IAM User jaws_user should be revised.

I understand the security concern here.  This will be difficult since we are moving to make the CLI tool automate more of the user's workflow, sparing them from the AWS Web Console, and we need lots of permissions to perform all of the tasks we have in mind.
Also, if we limit the scope of jaws_user then as we introduce new features/automations in the CLI, the user will run into errors (if they do not update their User policies), which may result in bad ux.

Your concern makes sense, and I agree with the notion of minimizing work in the AWS console. But I have a few counter-arguments:

If a developer were working on a company AWS account and had to request users and policies from the sysadmins, they'll never be able to get that level of access. I'm trying to look down the road at using JAWS in a production environment.

Wouldn't this be a big security flaw when installing / using third-party JAWS applications or modules? Maybe I'm being paranoid, but I would be reluctant to run any code on my AWS account that has complete control.

Here's what I propose:

Making the Installation-level policy permissions as narrow as possible.

At runtime (or via test command), using the AWS SDK to evaluate the permissions that the user has against a list of permissions that it needs. This list would be updated with each new release that introduces a change in the policy requirements.

Throwing errors on the command-line when the policy needs to be adjusted.

For users that are comfortable giving the IAM User permission to manage policies on its own, make the application automatically generate new permissions.

This would cover both use-cases - where the developer is sandboxing in a free account, or where the developer is working in a production environment.
If this seems reasonable, I'd be happy to work on this.

+1000  This is a great solution with great user experience.
I just added it as a comment to the JAWS V1 Specifications
I'll get it in the spec tomorrow.  I would really appreciate your help on this :)

:+1:  Looking forward to seeing it in the spec so I can get started!

@ashack293 I'll write it in there today and start a JAWS V1 branch tomorrow.  Thanks again :beers:

@ashack293 In the V1 spec, on the jaws new command, the jaws-cli automatically creates AWS IAM Roles for each stage the user specifies in a prompt.
Excuse my ignorance about IAM here, but if the jaws-cli has a permission to create an IAM Role, then isn't there no point in limiting the permissions scope of the jaws-cli IAM User because it could potentially create and utilize an IAM Role that could access any resource?

@ac360 Yeah, that basically moves the problem partially to Roles. The User is still too powerful because they can create roles and adjust the policies for them, and the Role is too powerful because we're letting the software dictate what its constraints are. You also need the User to have the same level of permissions, or else it's going to make local development more of a nuisance. I think there are two ways we could go with this, and maybe we do both:
A. Allow the developer to give JAWS extensive powers and automatically create the roles and policies. At least this will be a better security practice by provisioning with more granularity. jaws new would just report in the console as it configures the IAM User and Role for use in the application.
B. Evaluate the policies assigned to the User and Role, and generate errors accordingly. This will prompt the developer to modify their IAM policies as needed to run the application. In this scenario, the application does not have the power to assign any IAM Policies, it can only read them.
I think we definitely need B, and we might want A. Something to consider in either case: it's relatively simple to copy a policy template into IAM. So we could either provide the template with instructions, or upload it to AWS programmatically when the application is created. Either way, it removes the need for giving full admin access. We could make things easier by including sample policies in the project, or generating them on the command-line.
At some point, we're going to need to go a step further and support even more granular permissions, so the application can only read/write one specific database or S3 bucket, etc. The spec mentions generating roles for different environments. The question is, why would any of them be any different from each other? The main reason would be if you were configuring the roles with maximum granularity: the Dev Role has write permission in S3Bucket 1, Staging Role has write permission in S3Bucket 2, etc.
To add this sort of granularity, we may want to use prompts on the command-line to accept ARNs as inputs and generate policies programmatically.
Lastly, since we're taking a more modular approach, it raises the question of whether we should require that you actively provide AWS credentials to each module instead of making them globally accessible. I do not think this is necessary, but I thought I would mention it for the sake of discussion.

@ashack293 Sorry for the slow response.  I've been deferring digging into this issue because JAWS V1 is changing rapidly.  All of JAWS V1's details haven't been figured out yet.  Without those details, I feel I'm lacking the necessary information needed to best solve this issue.  Your suggestions are great as always.  I am going to keep this issue open, as a reminder and reference.  Right now, I'm focused exclusively on making the server-less workflow easy.  If we can make that, then it will be worth making secure.

We're currently working on the next iteration of Serveless that will deploy all resources through Cloudformation. We're thinking of ways to make it possible to use existing roles and users so we don't have to create them and user/role management can be handled externally from the serverless service.


Sound doesn't play/Counter doesn't update

I'll take a look into it, This issue is also happening on my account.

Fixed!


Utilize Passive Event Listeners to improve performance

Description
Listening for events on scroll tends to result in poor scroll performance.
Recommended Changes
https://github.com/showpad/angular-in-viewport/blob/master/src/directives/viewport.directive.js#L200
// ...
// JQuery's 'on' doesn't let you pass passive to addEventListener :(
$window.addEventListener('scroll', $ctrl.updateDelayed, {
  passive: true
});
// ...

https://github.com/showpad/angular-in-viewport/blob/master/src/directives/viewport.directive.js#L205
// ...
// JQuery's 'on' doesn't let you pass passive to addEventListener :(
iElement[0].addEventListener('scroll', $ctrl.updateDelayed, {
  passive: true
});
// ...

Resources

MDN's Improving scrolling performance with passive listeners

Thanks for pointing this out. I'll have a look at it asap


gh-594 Update bulk editor item selection

Resolves #594
Resolves #582
Resolves #583
Resolves #584

Add child domain type selection to pick more than Data Elements
Change child item selection UI to use detailed selection list
Move breadcrumb component out of catalogue search and into shared module
Restyle the select form
Change buttons in spreadsheet view to make more sense
Clear context when going back to item selection
Support correct root item when bulk editing Data Classes

Also resolves gh-582, gh-583 and gh-584 to allow bulk editor to work with more domain types:

Terminologies
Code Sets
Data Classes

Note: the selection of profiles is still inside the "selection list" area of the bulk editor. Issue #595 will move that to the tabbed spreadsheet view.
Screenshots
Select different child domain types:

Updated item selection list UI:

Example of Data Classes being bulk edited:

This looks good and I found the bulk editing workflow much faster to use 👍
A few usability comments:

When bulk editing terms of a terminology (e.g. using the bootstrapped Complex Test Terminology) only the first 10 terms can be selected. I think this is because the endpoint http://localhost:8080/api/terminologies/{terminologyId}/terms?all=true&sort=label intentionally does not actually return all terms. So some pagination might be required so that a user can select more than just the first 10 terms.
The left column of the bulk editing table is headed 'Elements', which makes me think of data elements. Possibly this could be headed 'Items' instead, given that the column can be for data elements, classes, terms etc....
After successfully saving some edits, when I clicked on the 'Close' button there is a confirmation saying that any unsaved changes will be lost. In future this could be enhanced to check for any unsaved changes; if there are none then close without the confirmation modal.
It took me ages to find the save button. Elsewhere save is done using a button labelled 'Save' or by pressing a green checkmark. It might be good to use one of these rather than using the floppy disk icon.
The 'Domain type' select could display the domain types capitalised e.g. 'Data Type' rather than 'Data type' for consistency with other parts of the UI
In the default profile I haven't been able to save classifiers or aliases. I don't know whether this is due to the bulk editing change, or the default profile change.

Thanks for the feedback @aaronforshaw . Some of this was simple to change, very minor. The terms list I need to look into, I might be able to implement virtual scrolling in the selection list to act as pagination. I wasn't aware of that limitation for term lists.
Your other points I will investigate but may push out into separate issues:

Aliases/classifiers might need some custom cell editors. Classifiers at least I would imagine needs to update with IDs of classifiers rather than a string
Only seeing the "do you want to leave" confirmation would definitely make sense only if you haven't saved, it would just need t be tracked correctly. Each tab now saves it's own profile now.

@aaronforshaw I've completed all the feedback I can for now. I've created these separate issues to work on later:

#623
#624
#625

@aaronforshaw There is actually one case when we validate the default profile, it checks if the multiplicity value you entered is in the correct format e.g. "0..1" and not some random numbers/characters. To adjust that properly that would probably also require a custom cell editor, which I think would be another issue to raise.


Remove unnecessary static state

Make DisableParallelism an instance variable
Remove static state in StartStopActivityComputer for an unused field

Codecov Report

Merging #264 into master will increase coverage by <.01%.
The diff coverage is 75%.

@@            Coverage Diff             @@
##           master     #264      +/-   ##
==========================================
+ Coverage   24.32%   24.32%   +<.01%
==========================================
  Files         197      197
  Lines      112379   112378       -1
  Branches    11208    11208
==========================================
  Hits        27331    27331
+ Misses      85021    85020       -1
  Partials       27       27

Flag
Coverage Δ

#2015
24.31% <75%> (ø)
:arrow_up:

#2017
24.32% <75%> (ø)
:arrow_up:

#Debug
15.78% <50%> (ø)
:arrow_up:

#Release
14.86% <50%> (-0.01%)
:arrow_down:

Impacted Files
Coverage Δ

.../TraceEvent/Computers/StartStopActivityComputer.cs
12.31% <ø> (-0.07%)
:arrow_down:

src/TraceEvent/Stacks/CallTree.cs
55% <75%> (+0.08%)
:arrow_up:

src/PerfView/StackViewer/StackWindow.xaml.cs
34.39% <0%> (-0.04%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update da21a66...04925a1. Read the comment docs.


Create flash messages in admin page

@PadawanTony my bad on this. I have not touched the the admin page.
Sorry!

Haha yeah. I guessed so. I'll reopen it.