关于webUI突然打不开了，一直显示loading？（The webUI won't open, it keeps showing loading.）

正常成功运行了1周左右，一直能正常使用（成功训练+成功推理），但1个小时前突然webUI打不开了，一直显示loading，中间换了很多浏览器，关闭了所有浏览器插件，关闭了所有电脑软件以及杀毒软件，然后重启了好多次电脑都没有用。
I've been running it normally and successfully for about 1 week, and it's been working fine (successful training + successful reasoning), but 1 hour ago suddenly the webUI wouldn't open, it kept showing loading, and in between I switched browsers a lot, turned off all the browser plugins, turned off all the computer software as well as the antivirus software, and then restarted the computer many times to no avail.

正常成功运行了1周左右，一直能正常使用（成功训练+成功推理），但1个小时前突然webUI打不开了，一直显示loading，中间换了很多浏览器，关闭了所有浏览器插件，关闭了所有电脑软件以及杀毒软件，然后重启了好多次电脑都没有用。
I've been running it normally and successfully for about 1 week, and it's been working fine (successful training + successful reasoning), but 1 hour ago suddenly the webUI wouldn't open, it kept showing loading, and in between I switched browsers a lot, turned off all the browser plugins, turned off all the computer software as well as the antivirus software, and then restarted the computer many times to no avail.

清除浏览器缓存，不要开梯子什么的，正常来说就可以了，如果实在连不上也不是不可以用cmd
#预处理
./pythonenv/python.exe preprocess.py -c ./configs/xxx.yaml
#DDSP
./pythonenv/python.exe train.py -c ./configs/xxx.yaml
#Diff
./pythonenv/python.exe train_diff.py -c ./configs/xxx/yaml


editors - Redundant conditions specified for keyboard shortcuts (#97381)

This PR fixes #
editors - Redundant conditions specified for keyboard shortcuts (#97381)

Fix #97381

Not a big fan of the approach but letting @alexdima decide. For format we can just find the (static registrations and fix them there)

Thank you. What is the format and static fix?:open_mouth:

https://github.com/microsoft/vscode/blob/846aec810ede01f4c262cbffe59a7ac7e33c5b4b/src/vs/editor/contrib/format/formatActions.ts#L217 and further down is where format defines (statically) its conditions. Things that are listed in the precondition don't need to go into keybinding/menu item conditions

https://github.com/microsoft/vscode/pull/99085
Hi, I found some duplication in these places. Is it better to delete these?:smiley:

Use the code to find all the commands, All duplicate registration locations were found.:metal:
I added these to this PR：#99085
{
  "key": "shift+alt+f",
  "command": "editor.action.formatDocument",
  "when": "editorHasDocumentFormattingProvider && editorHasDocumentFormattingProvider && editorTextFocus && !editorReadonly"
}
{
  "key": "shift+alt+f",
  "command": "editor.action.formatDocument.none",
  "when": "editorTextFocus && !editorHasDocumentFormattingProvider && !editorHasDocumentFormattingProvider && !editorReadonly"
}
{
  "key": "ctrl+k ctrl+f",
  "command": "editor.action.formatSelection",
  "when": "editorHasDocumentSelectionFormattingProvider && editorHasDocumentSelectionFormattingProvider && editorTextFocus && !editorReadonly"
}
{
  "key": "shift+tab",
  "command": "acceptAlternativeSelectedSuggestion",
  "when": "suggestWidgetVisible && textInputFocus && textInputFocus"
}
{
  "key": "shift+enter",
  "command": "acceptAlternativeSelectedSuggestion",
  "when": "suggestWidgetVisible && textInputFocus && textInputFocus"
}
{
  "key": "tab",
  "command": "insertNextSuggestion",
  "when": "hasOtherSuggestions && textInputFocus && textInputFocus && !inSnippetMode && !suggestWidgetVisible && config.editor.tabCompletion == 'on'"
}
{
  "key": "shift+tab",
  "command": "insertPrevSuggestion",
  "when": "hasOtherSuggestions && textInputFocus && textInputFocus && !inSnippetMode && !suggestWidgetVisible && config.editor.tabCompletion == 'on'"
}
{
  "key": "ctrl+f2",
  "command": "editor.action.changeAll",
  "when": "editorTextFocus && editorTextFocus && !editorReadonly"
}

ok, closing this PR then


Only use given markup provider for markdown format

After struggling with getting GFM to work and looking at issues like #404, it seems --markup-provider will set the provider for all formats and completely bypass YARD's format detection. This means you cannot have RDoc formatted code comments and specify the markdown formatter for the README.md (See also this comment: https://github.com/lsegal/yard/issues/404#issuecomment-2879937).
Since markdown is the only format that has different providers (see https://github.com/lsegal/yard/blob/295a15a23e6c9341d3425246c9efd7680d2131b5/lib/yard/templates/helpers/markup_helper.rb#L23), I think the markup provider loading should only use the provider set by --markup-provider if the format is markdown.
Ideally, once several formats have more than one provider, it should be possible to set a different provider for each such format.

After struggling with getting GFM to work

To quickly short-circuit this, note that GFM is supported out of the box in YARD. #404 is a very old issue and is no longer applicable. If you have rdiscount installed, YARD will prefer that library over others and work correctly.
The solution here is simply to install a GFM supported library like rdiscount and do not use --markup-provider option. This option is only necessary if you want to override YARD's default-- in this case you do not.

If you have rdiscount installed, YARD will prefer that library over others and work correctly.

Right. It turns out I had neither rdiscount nor redcarpet installed. Thanks!


fix yaml when install chart vault with .Values.rbac.psp.enabled=true

Q
A

Bug fix?
yes

New feature?
no

API breaks?
no

Deprecations?
no

License
Apache 2.0

What's in this PR?
fix error wheb psp enabled
Error: YAML parse error on vault/templates/role.yaml: error unmarshaling JSON: while decoding JSON: json: cannot unmarshal array into Go value of type releaseutil.SimpleHead
helm.go:84: [debug] error unmarshaling JSON: while decoding JSON: json: cannot unmarshal array into Go value of type releaseutil.SimpleHead
YAML parse error on vault/templates/role.yaml

Checklist

[x] Code meets the Developer Guide

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


feat: added arm64 build

What this PR does: Added linux/arm64 build to all docker images.
Why we need it: To support linux/arm64
Which issue(s) this PR fixes:
Fixes https://github.com/pipe-cd/pipecd/issues/4896
Does this PR introduce a user-facing change?: No

@ponkio-o
Sorry, I checked the behavior after I approved this, and I realized that the git command is absent in the builder container.


addToMany() does not trigger realtime update

I am using the default notification feed. When I add the activity to 2 users separately via feed.addActivity(act) I get the updates in my browser. When I do client.addToMany(feeds) I do not. Is this expected behavior? I do not see it documented.

@mikestaub this is expected behavior, activities added via addToMany are not propagated to followers


Unable to receive acknowledgement of CoAP CON message in NCP firmware.

I am trying to sending CoAP CON message (resource dfu/) from NCP and FTD firmware to CoAP server running on RPi.
When I send CON message from FTD to CoAP server, the acknowledgement is received but not when sending CON message from NCP to CoAP server.
The address of NCP is feef:ee::87b1:5246:674d:326e, of FTD is feef:ee::f639:87f2:2f77:b48d and of CoAP server is 2001:db8:1:ffff::a00:1.
I tried debugging using tcpdump logs and discovered that CoAP server is sending acknowledgement message (which can be seen in nat.pcap) but there is no trace of that acknowledgement message at wpan0 in interface (which can be seen in wpan.pcap).
Can anyone help why is that so?
PFA for tcpdump logs.
tcpdump.zip

@tarunsmalviya , this traffic pattern is not supported. The challenge is that the NCP and wpan0 interface on host side are both part of the same IPv6 interface. When the CoAP response is sent from the RPi host, the destination will match an IPv6 address assigned to its wpan0 interface. As a result, the Linux kernel will attempt to service the packet directly rather than passing it to the NCP.

@jwhui Is there any other approach to achieve this because resolving is problem will enable us to perform DFU in NCP.

@tarunsmalviya , as for other alternatives, how about utilizing a bootloader that supports DFU in the NCP?

@jwhui We are using Nordic's OTA DFU example, in which we first add mbr file, then bootloader and then application on NRF52840 chip. In application, we enable the DFU when new firmware version is available at the server.
But in this case CoAP response are not being received.

Closing stale issue.


Fix bug for no ns for path on uploads

Added a return which fixes not getting 404 no namespace found for path for uploads when trying to upload to an unregistered namespace.

Keeping as draft for now as there might need to be more debugging added for this very long error message from condor:

012 (6671.000.000) 2024-04-18 10:46:57 Job was held.
Transfer output files failure at execution point<EMAIL_ADDRESS>while sending files to access point submit4. Details: Error from<EMAIL_ADDRESS>STARTER at <IP_ADDRESS> failed to send file(s) to <<IP_ADDRESS>:9618>: : FILETRANSFER:1:Multi-file plugin at stash_plugin did not produce valid response; missing TransferUrl|FILETRANSFER:1:Multi-file plugin at stash_plugin did not produce valid response; missing TransferFileName|FILETRANSFER:1:non-zero exit (1) from stash_plugin. |Error: Failed to create new transfer job: failed to get namespace information for remote URL osdf:///cht/staging/jrreuss/uploadedtest.txt: 404: No namespace found for path. Either it doesn't exist, or the Director is experiencing problems\n ( URL file =  )|; SHADOW failed to receive file(s) from <<IP_ADDRESS>:35245>
Code 12 Subcode 1
...

Fixed in #1138


[No changes?] api review - window

See GH-2140 for master plan.

I took a look and made no changes. The reviewer could check if he would make a change and reply to this comment.

I took a look and made no changes. The reviewer could check if he would make a change and reply to this comment.

Since it's just a few browser methods, I would say it's fine to leave it as is 👍


undefined value on onRangeSelect callback

On datetimerangepicker allways return undefined (v2.0.6) on onRangeSelect callback
Check this plunkr: http://plnkr.co/edit/HGnecL5uVO8oWk3RvzRV?p=preview
Also, Is not possible set initial ngModel range value.

I see this problem is solved on last commits. But, it is possible change strings data on callback to moment objects?
For example, we need send data to BackEnd on an especial format, and I think is not a good solution convert again to moment object the received data from callback().
Also, with moment date object on callback  we can do another thinks on views, for example.
What do you think?

Yes it is possible to change to Moment Object on call back, Just pass selected date object before formatting and assigning to setNgModelCtrl.

I think Date Object is better, because Angular Material use the same method. On this way, smDateTimeRangePicker will be like an angular-material extension.

problem with date object is we need to change entire module to accept this. Other problem is i developed this module because material-angular was not working with moment.

problem with date object is we need to change entire module to accept this

I see all project work with external ecosystem with string (callbacks and ngModels). Interally, it work with moment(). Rigth?

Other problem is i developed this module because material-angular was not working with moment.

I see this library like a better and powerfull <md-datepicker />. Also, user position don't see any Date or Moment object. Rigth?
Please, tell me if I wrong. The idea of this question is determine a final way for give to the users a solution with formats, models and callbacks.  Maybe @oscar09 can help us...
I vote for Date Object for ngModel (or objects on daterangepicker). Another reason of this is a more agnostic solution. But, if you say Moment is better, I don't have problem, I try to collaborate building a better library.

only difference between Date and moment object is later provide pre build api while former does not.
we need to build api and test it before integrating with this.

I also like momentJS more. I believe it is more powerful. If the moment objects are needed, I believe they can be added as additional properties of the "range" object that is passed on the callback function. Currently we have "startDate" and "endDate" as string, maybe we can add "startDateMoment" and "endDateMoment" that way the change will provide backward compatibility.
I think that the model as a moment object is not a big change; you can take either a string or a moment object to provide backward compatibility as well. However, the "range" will be tricky because you will need to provide an object with the "startDate" / "endDate" properties initialized with a date string or moment object. Right now, you can (sort of) initialize the component with a range:
self.datemodel = moment().startOf('month').format('YYYY-MM-DD') + '  :  ' + moment().format('YYYY-MM-DD');
It does not initialize the internal values of the component, but at least it tricks the user that the component has already a value.

@pablorsk I am closing this issue, the main problem (undefined value) was fixed on latest commits. I have created issue #100 for the moment objects on the rangeSelect callback.


Fix 3.0 use triple can not return real exception

What is the purpose of the change
fix dubbo 3.0 use triple can not return real exception #8363
Brief changelog

use hessian2 wrapper java exception
add common exception structure for multi-language

Verifying this change

Checklist

[x] Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
[ ] Each commit in the pull request should have a meaningful subject line and body.
[ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[ ] Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
[ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
[ ] Add some description to dubbo-website project if you are requesting to add a feature.
[ ] GitHub Actions works fine on your own branch.
[ ] If this contribution is large, please follow the Software Donation Guide.

please fix compile error

Codecov Report

Merging #8458 (cdc2c29) into 3.0 (4149543) will decrease coverage by 0.51%.
The diff coverage is 5.67%.

@@             Coverage Diff              @@
##                3.0    #8458      +/-   ##
============================================
- Coverage     63.20%   62.69%   -0.52%
+ Complexity      311      309       -2
============================================
  Files          1099     1112      +13
  Lines         46054    46633     +579
  Branches       6956     6995      +39
============================================
+ Hits          29109    29235     +126
- Misses        13692    14121     +429
- Partials       3253     3277      +24

Impacted Files
Coverage Δ

...e/dubbo/rpc/protocol/tri/AbstractServerStream.java
57.73% <0.00%> (ø)

...rg/apache/dubbo/rpc/protocol/tri/ClientStream.java
0.00% <0.00%> (ø)

...apache/dubbo/rpc/protocol/tri/DefaultMetadata.java
58.33% <0.00%> (-11.67%)
:arrow_down:

.../apache/dubbo/rpc/protocol/tri/ExceptionUtils.java
0.00% <0.00%> (ø)

.../org/apache/dubbo/rpc/protocol/tri/GrpcStatus.java
44.15% <0.00%> (-4.42%)
:arrow_down:

...apache/dubbo/rpc/protocol/tri/Http2HeaderMeta.java
55.55% <0.00%> (-19.45%)
:arrow_down:

...va/org/apache/dubbo/rpc/protocol/tri/Metadata.java
33.33% <ø> (ø)

...he/dubbo/rpc/protocol/tri/TripleClientHandler.java
54.54% <0.00%> (ø)

...che/dubbo/rpc/protocol/tri/TripleRpcException.java
0.00% <0.00%> (ø)

.../org/apache/dubbo/rpc/protocol/tri/TripleUtil.java
35.33% <0.00%> (-10.36%)
:arrow_down:

... and 111 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4149543...cdc2c29. Read the comment docs.


[BUG] (v0.0.0): Prelude_No._1_BWV_846_in_C_Major.mxl

Expected behavior
Render correctly.

Actual behavior
Exception and wrong rendering.
Screenshot

Hints
The more you provide, the faster we can fix it.

[x] Attach the MusicXML file used to produce the bug.
[x] Attach the error messages.
[x] Include any vexml code references where the bug may be.

Prelude_No._1_BWV_846_in_C_Major.zip

@jaredjj3 @ronyeh I am moving to another city. Once I settle I will be more active. :)

@rvilarl thanks for the bug report and good luck with your move!

Looking at this now.

To troubleshoot, I colored the stave notes being used for the start and end notes.
  render(): PedalRendering {
    const vfStaveNotes = this.getVfStaveNotes();
    const vfPedalMarkingType = this.getVfPedalMarkingType();
    const vfPedalMarking = new vexflow.PedalMarking(vfStaveNotes).setType(vfPedalMarkingType);

    vfStaveNotes[0].setStyle({ fillStyle: 'green' }); // Change the color to green
    vfStaveNotes[1].setStyle({ fillStyle: 'red' }); // Change the color to red

    return {
      type: 'pedal',
      vexflow: {
        pedalMarking: vfPedalMarking,
      },
    };
  }

It looks like the second note of the second pedal marking is not being associated correctly. Even if the same note was being used as a start and end, I expect it to show as the end color.
When I implemented <direction> support, I always attached it to a note, since that's what vexflow needs. However, I think I might need to conditionally create TextNote to avoid issues like this.
I'm going to spend some time figuring out a better strategy for <direction> elements, especially before I try to do lilypond31a (Directions).

I thought I could make vexflow.TextNote objects that have no ticks, but that seems to be a special case for vexflow.BarNote objects (code). I'm skeptical that even if there was a supported way to render vexflow.TextNote as such, it would probably interfere with formatting. I'm going to study the problem a bit more.
@rvilarl, @infojunkie, and @sschmidTU, do you have any advice for handling <direction> elements? They're inherently not attached to a specific <note>, but vexflow typically requires a vexflow.Tickable to render them. It seems like I might have to handle each direction on a case-by-case basis — there doesn't seem to be a universal strategy I can apply to them like <technical> or <articulations>.

For now, this is what I'm planning to do when iterating through a <measure>:

When handling a <note>, attach all consecutive <direction> elements after it.
When handling a <direction> without a preceding <note> in scope, attach it to the next <note> within that measure.
If there is no <note> within the <measure>, create a vexflow.GhostNote and attach the <directions> to it. If this doesn't work, hack an empty TextNote with duration '256' instead.

Looks like a complex specification indeed. And of course, it is complex because of all the cases of annotations that exist in real-word scores.
My reading of the <direction> specification tells me the following factors would affect the positioning algorithm:

The optional sub-element <offset> indicates where the direction will appear relative to the current musical location (in unit of score divisions).
The optional attribute directive changes the default-x position of a direction.
By default, a series of <direction-type> elements and a series of child elements of a <direction-type> within a single <direction> element follow one another in sequence visually.
For applications where a specific direction is indeed attached to a specific note, the <direction> element can be associated with the first <note> element that follows it in score order that is not in a different voice.
Child elements of <direction-type> include attributes default-x, default-y, relative-x, relative-y that affect their individual positioning.

At this moment, I don't fully understand which direction types need to be associated with notes, versus which aren't. Maybe it's just a function of where they occur in the bar, but that would need clarification. Maybe you can ask a question in the musicxml discussion forum although the new maintainer of the format has not been very responsive. You may have better luck at StackExchange Music.
Happy to continue digging if you feel this is useful to you.

@jaredjj3 I also do not see like @infojunkie why we have to associate directions to notes. Probably the abstraction can be improved in VexFlow, for example, Coda & Segno are StaveModifiers but pedal is not.

@infojunkie, thank you, this is an excellent summarization (even better than ChatGPT).

For applications where a specific direction is indeed attached to a specific note, the  element can be associated with the first  element that follows it in score order that is not in a different voice.

Ah, of course! This is where I went wrong — the current vexml algorithm associates a <direction> with the first succeeding <note> regardless of <voice>.
Here's the snippet I was dealing with (the full score is in https://github.com/stringsync/vexml/issues/207#issuecomment-1913191681):
<note>
  <voice>5</voice>
</note>
<direction placement="below">
  <direction-type>
    <pedal type="stop" line="yes"/>
    </direction-type>
  <staff>2</staff>
  </direction>
<backup>
  <duration>16</duration>
</backup>
<note>
  <voice>6</voice>
</note>

The <direction> actually needs to be associated with the previous <note>, because the next <note> of the same <voice> appears in the next measure. The MusicXML <measure> spec also permits a <direction> to be specified without any <note>.

@jaredjj3 I also do not see like @infojunkie why we have to associate directions to notes. Probably the abstraction can be improved in VexFlow, for example, Coda & Segno are StaveModifiers but pedal is not.

I think this is a shortcoming of the MusicXML spec. It's very confusing to have directives that maybe associate <direction> and <note> elements. Hopefully it'll be improved in mnx.
Ultimately, yes I agree if vexflow had a way to add StaveModifier objects inline within a Voice, it would make this a lot easier. I'm going to see how hard the implementation is before submitting an FR to vexflow. Thanks for calling that out!

The more I work with vexflow, I think this project would've been significantly easier if I was able to attach non-tickables to the stave in a matrix-like fashion. I'm not asking for this to be put in vexflow since it's really invasive, but I would like to share my thoughts.
const stave1 = Stave({
  label: Text('part1', { offset: Vector.fromOrigin(-5, 0) }),
  entries: [
    // A StaveEntry is like a vertical stack of elements.
    StaveEntry([Barline({ label: Text('1') })]),
    StaveEntry([KeySignature('C')]),
    StaveEntry([Clef('G')]),
    StaveEntry([TimeSignature('4/4')]),
    StaveEntry([Note('C', { duration: 'h' })]),
    StaveEntry([Chord([Note('C'), Note('D')])]),
  ]
});
const stave2 = Stave(); // empty for now
const system = System({ staves: [stave1, stave2] });
system.format().draw();

or maybe you have helpful instance methods:
const stave = Stave();

// This would merge into the internal structures of the stave.
stave.insert(StaveEntry([Note('C', duration: 'q')]), { at: Fraction(3, 4) });

This would be a different goal than EasyScore. This API is not optimizing for user writability — it's optimizing for programability.
I'm not sure how adaptable this is to vexml and if the benefits are worth the effort. I'll just keep this in the back of my mind next time I get blocked.

@infojunkie, thank you, this is an excellent summarization (even better than ChatGPT).

You have a low opinion of humans and a high opinion of technology 😱

I'm waiting on https://github.com/0xfe/vexflow/issues/1611 before I resume this.


Added on-drag-end callback

Looks good man! I was thinking about if also a dragStart event might be useful, but i think simply drag and dragEnd should be enough

Hmmmm I'll add it sometime if it's needed ^^

just wanted to mention that we should call the option drag-sync-key similar to tooltip-sync-key


Fix issue #188

Description
Added missing error check.
Fixes #188
Type of change

Bug fix (non-breaking change which fixes an issue)

Codecov Report

Merging #231 into master will increase coverage by 0.04%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #231      +/-   ##
==========================================
+ Coverage   40.08%   40.13%   +0.04%
==========================================
  Files          11       11
  Lines        1367     1368       +1
==========================================
+ Hits          548      549       +1
  Misses        803      803
  Partials       16       16

Impacted Files
Coverage Δ

server/profile.go
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c55174f...244a6f1. Read the comment docs.


[WIP] Update json gem.

I was using the Ruby 2.3.1, and tried to bundle install, met with json extension compilation issues, and find that is not the older json is not compatible with latest version, so I bundle update json.
Ref: http://stackoverflow.com/questions/29578142/how-to-install-json-gem-failed-to-build-gem-native-extensionmac-10-10
Attached failure log:
Installing json 1.8.0 with native extensions

Gem::Ext::BuildError: ERROR: Failed to build gem native extension.

    current directory: /Users/BX/.rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/gems/json-1.8.0/ext/json/ext/generator
/Users/BX/.rbenv/versions/2.3.1/bin/ruby -r ./siteconf20160604-30772-1jcbopc.rb extconf.rb
creating Makefile

current directory: /Users/BX/.rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/gems/json-1.8.0/ext/json/ext/generator
make "DESTDIR=" clean

current directory: /Users/BX/.rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/gems/json-1.8.0/ext/json/ext/generator
make "DESTDIR="
compiling generator.c
In file included from generator.c:1:
./../fbuffer/fbuffer.h:175:47: error: too few arguments provided to function-like macro invocation
    VALUE result = rb_str_new(FBUFFER_PAIR(fb));
                                              ^
/Users/BX/.rbenv/versions/2.3.1/include/ruby-2.3.0/ruby/intern.h:797:9: note: macro 'rb_str_new' defined here
#define rb_str_new(str, len) __extension__ (    \
        ^
In file included from generator.c:1:
./../fbuffer/fbuffer.h:175:11: warning: incompatible pointer to integer conversion initializing 'VALUE' (aka 'unsigned long') with an expression of type 'VALUE (const char *, long)' (aka 'unsigned long (const char *, long)') [-Wint-conversion]
    VALUE result = rb_str_new(FBUFFER_PAIR(fb));
          ^        ~~~~~~~~~~
1 warning and 1 error generated.
make: *** [generator.o] Error 1

make failed, exit code 2

@piotrmurach Sorry that I was busy with the new project of my work last week and just have time now to look at the repo.
I placed the WIP flag to the PR for that I want to make this as the starting point to check with you what's the best work flow to before we commit to make sure of the quality of the repo. I am sure that there might be some actionable items like:

[ ] bundle ci and make sure all tests passed
[ ] bundle build
[ ] other tasks...

You could just simply give some high level actions, I would go through that and try to detail them into some doc like contributing.md

The CI failed, I will fix this.

Hi @zhenglaizhang, I switched to use the same Ruby version as yourself and updated/changed the dependencies, removed Gemfile.lock from repo to ensure we don't have dependencies issues in the future. I've also updated readme to include development section to explain testing setup. Please feel free to add to docs anytime you feel anything is missing. Hope this helps you get started.
If you going to work, for instance, on search commands, you can just run bundle exec cucumber features/search.feature to save yourself some development time.
Let me know how this works for you.

@piotrmurach So nice of you 👍 , your update works great for me!


✨ Added slug & id matching to {{#has}} helper

This is the last piece of #8901. First commit is a refactor as the code had gotten a bit ridic!
closes #8901

Adds support for

{{#has any="twitter, facebook, website"}}
{{#has any="author.facebook, author.twitter,author.website"}}
{{#has<EMAIL_ADDRESS>@blog.twitter, @labs.subscribers"}}
{{#has all="<EMAIL_ADDRESS>

Note: there's definitely a TODO here to change author and tag to work differently - the weird lowercase no-special char matching can be improved, but that could introduce backwards incompatible changes, so need to add a bunch more tests first.

@ErisDS I'm guessing by the naming these should be rebased and merged as separate commits?

@kevinansfield I am happy either way - I like to keep refactors separate in commits so that you can more easily review what I've changed.
I am using the no-emoji on refactors.
The PR message and 2nd commit message are the same (I copy and pasted them from the slug PR and they were wrong, I just updated them haha).
Therefore, it doesn't matter if you squash and merge or rebase and merge, the changelog should look the same? Merely a matter of taste as to whether it's useful to keep the refactor in history.


Link to known 3.2.3+ issue from the release notes?

The Godot C# setup doc now points at https://github.com/godotengine/godot-csharp-visualstudio/releases directly from the VS installation steps: https://docs.godotengine.org/en/stable/getting_started/scripting/c_sharp/c_sharp_basics.html#visual-studio-windows-only, as of https://github.com/godotengine/godot-docs/pull/4808.
Maybe the latest release should have a "known issue" section that links to the workaround in https://github.com/godotengine/godot-csharp-visualstudio/issues/10? (Or maybe the docs shouldn't point to the release page directly?)

@31  It was clear from yesterday Godot Q&A, there is need to sort out Visual Studio Tools for godot so we can reliably debug from Visual Studio 2019
GodotXUnit has provided a few issues that are positive to further refinement of VS2019 Godot extension.
(a) Run specific scene and access nodes of the scene for unit testing
=> what we still missing is IDE integration, so we can step through each step while we access these node attributes from Visual Studio.
(b) Eventually, we hope to support multiple VS csproj projects (another challenges we learn from GodotXunit project

@31  Just check! this repository  makes it easy to do "Play in Editor"


Features/iphone x support

Adopting all the screens for iphoneX layout using safe areas.

@idokleinman this is now complete. Sorry for such big PR. CI is not working, but really short on time to fix this right now. Hope I have a spare day next sprint to do this (spent few hours on SDK repo today and it still doesn't work the way it should).


OSX 10.11.6 "Command Not Found" Error after Install

Installed and Attempted to Run

$ pip install rainbowstream
Collecting `rainbowstream
Requirement already satisfied: python-dateutil in /Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/site-packages (from rainbowstream)
Requirement already satisfied: twitter in /Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/site-packages (from rainbowstream)
Requirement already satisfied: requests==2.5.3 in /Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/site-packages (from rainbowstream)
Requirement already satisfied: pyfiglet in /Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/site-packages (from rainbowstream)
Requirement already satisfied: arrow in /Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/site-packages (from rainbowstream)
Requirement already satisfied: Pillow in /Library/Python/2.7/site-packages (from rainbowstream)
Requirement already satisfied: PySocks in /Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/site-packages (from rainbowstream)
Requirement already satisfied: pocket in /Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/site-packages (from rainbowstream)
Requirement already satisfied: six>=1.5 in /Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/site-packages (from python-dateutil->rainbowstream)
Installing collected packages: rainbowstream
Successfully installed rainbowstream-1.3.6
$ rainbowstream
zsh: command not found: rainbowstream

Looks like this was filed against the wrong project.


problems when using required rule in nested field that parent is not required

Situation
I'm coding a wrapper to validate some group of fields (like address) that appears in more than one place in the system (to avoid repeated rules) but I am having problem with fields that are required but only when the parent is present.
Example:
let data = {
  item: {
    value: 123,
    name: "sample"
  }
}

let rule = {
  item: {
    value: "required|integer",
    name: "required|string"
  }
}

The problem is the item is optional, but if try to pass an empty object as data, the validator throw this errors:
"The item.value field is required."
"The item.name field is required."

The way I've found to solve this, is using the required_with rule passing the path of the parent item, but it is impractical as the depth of the field increase.
// three level depth
let data = {
  foo: {
    bar: {
      item: {
        value: 1,
        name: 'sample'
      }
    }
  }
}

let rule = {
  foo: {
    bar: {
      item: {
        value: "required_with:foo.bar.item|integer",
        name: "required_with:foo.bar.item|string"
      }
    }
  }
}

I think the validator should check if the parent is required before execute the child's  required rule, so this will simplify the way to validate children properties.
There are any possibility to this be implemented?

The problem is the item is optional, but if try to pass an empty object as data, the validator throw this errors:
"The item.value field is required."
"The item.name field is required."

If you are not supply item, then the validation is correctly failing? Under what circumstances are you expecting this to pass with the provided rule?

If you are not supply item, then the validation is correctly failing? Under what circumstances are you expecting this to pass with the provided rule?

Yes, if item is not present in the input the validation fail, that's correct.
But I'm think required rule (or a new rule) could be improved to internally check if it's inside in a field that is optional, then only fails the validation if its parent is present.
For example, an endpoint to add product to database expect to receive this schema:
{
    product: {
        name: 'required|string',
        value: 'required|numeric',
        reference?: { // this is optional field
            id: 'required|string',
            type: 'string'
        }
    }
}

We have some fields that are required: name and value; but reference is an optional field, and in this way the user cannot insert because the validation fails in "product.reference.id" required rule. So, this is a circumstance that I think the required (or a new rule) should pass. But if reference field be present, then the validation should fails.


Simplify Giskard

Add classes User and Message.
Rewrite navigation.rb
Fix few bugs

Looks great, thanks ! My few remarks:

You removed the API and bot_upgrade related functions. Even if they are useful, they were not essential and we will be able to add them back easily later on so it's ok for me.
Regarding your comment on db.init() that could harm performances. It is true that open db connection at every request is expensive, this is why we highly recommend connecting to a local db connection pool (like pgbouncer for example) in order to make this call inexpensive performance wise.
what IDE are you using and with which configuration (tabs vs spaces etc...). We should make sure we use the same settings.


Can't navigate from terminal compilation error output to code editor.

Issue Type: Bug
Possibly related to and old finalized issue: https://github.com/microsoft/vscode/issues/58256
Also tested on insiders (no extensions): 1.38.0-insider
Using typescript version 3.5.3

Open an empty folder.
Create a test.ts file with the following code:

export class test {
    private data;

    public constructor(){

    }
}

In the integrated terminal (powershell v5.1.18362.145) run:

tsc -init
tsc -p tsconfig.json

Try to navigate to compilation error using Ctrl+Click on the output:

test.ts:2:13 - error TS7008: Member 'data' implicitly has an 'any' type.

2     private data;
              ~~~~

Found 1 error.

Expected to have the file highlighted on Ctrl (like when this was working) and on Ctrl+Click open it in the code editor.
 If your files will be in e.g. src folder it would work just fine because path will be like serc/test.ts:2:13 which can be detected as path and converted to link.

Yes, that's exactly the case. Unfortunately in my case (although not reflected in the example) it is a little bit more complex than simply moving everything to a new subfolder, but at least I know why.
@IllusionMH The issue you refer is quite old. Is there any chance this has any plans on being addressed in near future?

This is indeed a duplicate of https://github.com/microsoft/vscode/issues/22772, I've been contemplating removing the link verification all together for a long time due to cases like this and https://github.com/microsoft/vscode/issues/79547 but haven't pulled the trigger as it would result in a degraded experience though as so many things could be a file.

Maybe a setting that defaults to true? performLinkVerification: false


doesn't work on Windows with a Broadcom USB dongle

I have a "Broadcom BCM20702 Bluetooth 4.0 USB Device" (says the device manager in Windows 10) and I get this error message when running the example:
 INFO  server > Service Added
 ERROR server > Error starting advertising: **BlePeripheralRust Windows Error**

        windows::core::Error: HRESULT(0x8007013C):
                Error { code: HRESULT(0x8007013C), message: "The device does not support the command feature." }

The same USB dongle works fine with Debian Linux with the example.

In general, the device works, e.g. I can list BLE devices and pair to them:

With which BLE adapter did you test it on Windows? I think the Broadcom chipset is pretty common, and the driver was integrated in Windows.

if possible try to find which line causing this issue for you here

When I comment the SetIsConnectable call, then there is no error, but I can't connect to it. Maybe it is a Windows problem, looks like there are problems with some USB dongles with peripheral mode:
https://stackoverflow.com/questions/56958687/bluetooth-le-peripheral-role-on-windows-10
But in this case probably a driver problem, because works fine in Linux. I guess not many manufacturers care about peripheral mode for Windows.
Do you have a working USB BLE dongle for connectable BLE peripherals, and what is the name in device manager, and the name for buying it?

@Frank-Buss am using a Windows Laptop with Inbuilt bluetooth, and never faced this issue, never tried an external bluetooth dongle, if you ever found one, please share link, might be helpful for others as well


Move magic numbers into constants in Breakout example

Objective

The Breakout example has a lot of configurable constant values for setup, but these are buried in the source code.
Magic numbers scattered in the source code are hard to follow.
Providing constants up front makes tweaking examples very approachable.

Solution

Move magic numbers into constants

Context
Part of the changes made in #2094; split out for easier review.

bors r+


Integers in JFXTreeTableView

Is there any way to use Integer data in the tree table view?

sure same as javafx tree table view

Hello. It happens to me that I have a class called Client that has a phone number, I intend to assign it to the column of the table but it tells me that it is not possible. Can you tell me how to solve it?
Method setTableView()
JFXTreeTableColumn<Client, Integer> numberPhoneColumn = new JFXTreeTableColumn("Phone Number"); numberPhoneColumn.setPrefWidth(100);
numberPhoneColumn.setCellValueFactory(                 (TreeTableColumn.CellDataFeatures<Client, Integer> param)                 -> param.getValue().getValue().phone_numberProperty() );

I use jfoenix_8.0.7.jar library

Solution:
numberPhoneColumn.setCellValueFactory( (TreeTableColumn.CellDataFeatures<Client, Integer> param) -> param.getValue().getValue().phone_numberProperty().asObject() );


adds informative references for some acronyms

resolves #119

PR withdrawn impactful pending changes forthcoming. May reissue when merged in the future.


Version Bump from build number 128

Pull request created by https://jenkins.tdr-management.nationalarchives.gov.uk/job/TDR Database Migrations Publish/128/

@MancunianSam Is this OK to merge?


envoy: add additional metadata for the proxy's kind

Description:
Adds additional metadata in the proxy's XDS cert
to identify the proxy's kind.
Currently, osm-controller only supports programming proxies
that run as a sidecar on app pods. As a part of the effort
to implement a proxy gateway, osm-controller will also
require to identify and program a proxy gateway. The
config for a gateway proxy will be completely different
compared to that of a sidecar proxy, and this change will
allow identifying the kind of the proxy to do so.
Existing code and tests have been updated to set the
proxy's kind to sidecar.
Part of #3501
Signed-off-by: Shashank Ram<EMAIL_ADDRESS>
Affected area:

Functional Area

Control Plane
[X]

Please answer the following questions with yes/no.

Does this change contain code from or inspired by another project? no

Did you notify the maintainers and provide attribution?

Is this a breaking change? no

Codecov Report

Merging #3514 (69bf33d) into main (63b3165) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #3514      +/-   ##
==========================================
+ Coverage   66.31%   66.34%   +0.02%
==========================================
  Files         169      169
  Lines        8071     8072       +1
==========================================
+ Hits         5352     5355       +3
+ Misses       2689     2687       -2
  Partials       30       30

Flag
Coverage Δ

unittests
66.34% <100.00%> (+0.02%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

pkg/envoy/types.go
50.00% <ø> (ø)

pkg/envoy/proxy.go
89.23% <100.00%> (ø)

pkg/envoy/xdsutil.go
89.30% <100.00%> (+0.05%)
:arrow_up:

pkg/injector/patch.go
76.78% <100.00%> (ø)

pkg/envoy/ads/stream.go
5.69% <0.00%> (+1.26%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 63b3165...69bf33d. Read the comment docs.


DOC: adding the MIT License badge to the licenses section of readme and adding some text

What's wrong with the existing documentation
The licenses section can be made more professional by adding some text and The MIT License badge instead of a link.
Add ScreenShots

Record

[X] I agree to follow this project's Code of Conduct
[X] I'm a GSSOC'23 contributor
[X] I want to work on this issue

Please assign me this issue under GSSoC'23


Feature Request / Issue : Build process for support with HTTP2.0

Please provide us with the following information:
Feature Request / Issue : Build process for support with HTTP2.0. Currently the build process is concatenation of all files into a single bundle. Provide option for HTTP 2.0 build process with multiple smaller files (with minification option) which will support faster download in HTTP 2.0.

OS?

Windows 7, 8 or 10. Linux (which distribution). Mac OSX (Yosemite? El Capitan?)
Win 10 / Linux Server (Prod)

Versions.

Please run ng --version. If there's nothing outputted, please run in a Terminal: node --version and paste the result here:
@angular/cli: 1.0.0-beta.32.3
node: 6.9.4
os: win32 x64

Repro steps.

Was this an app that wasn't created using the CLI? What change did you do on your code? etc.
NA

The log given by the failure.

Normally this include a stack trace and some more information.
NA

Mention any other details that might be useful.

Thanks! We'll be in touch soon.

I am also interested in this. Looks like Webpack has AggressiveSplittingPlugin and browser coverage for HTTP/2.0 is close to 80% according to caniuse.
I am experimenting outside of CLI to get a angular HTTP/2 setup with this AggressiveSplittingPlugin plug in for webpack.

Hi, @josephliccini! Did you make any progress on this? If so, would you mind sharing your findings? Thanks!


Build Is Broken

sbt compile test package fails with:
[warn]
[warn]  Note: Some unresolved dependencies have extra attributes.  Check that these dependencies exist with the requested attributes.
[warn]          com.github.joprice:sbt-jni:0.2.2-SNAPSHOT (sbtVersion=1.0, scalaVersion=2.12)
[warn]
[warn]  Note: Unresolved dependencies path:
[error] sbt.librarymanagement.ResolveException: Error downloading com.github.joprice:sbt-jni;sbtVersion=1.0;scalaVersion=2.12:0.2.2-SNAPSHOT
[error]   Not found
[error]   Not found

This seems like a recent change after migrating from binray as https://repo1.maven.org/maven2/com/github/joprice/sbt-jni_2.12_1.0/0.2.2-SNAPSHOT/sbt-jni-0.2.2-SNAPSHOT.pom is not reachable.

Yes, you have first to do:
$ cd sbt-jni
$ ./sbt publishLocal

I hope this is temporary situation until sbt-jni is republished. Worth documenting it though

Updated the instructions in the README

@luben which version of java are you using?
I'm using java 8 and getting this error, is it a supported version for building ?

java.lang.IllegalArgumentException: invalid flag: --release
[error]         at com.sun.tools.javac.api.JavacTool.processOptions(JavacTool.java:206)

I have switched to jvm11 for the build. I think the --release flag was added after 8.

BTW, the sbt-jni plugin was released on maven-central and the build step is not necessary anymore.


[Theme] customised theme is reset while loading a component from (yarn-workspace) packages

When a react-js application using customised theme loads another component (using material-ui components) from a (yarn-workspaces) package, the customised theme is RESET.

[ x] The issue is present in the latest release.
[ x] I have searched the issues of this repository and believe that this is not a duplicate.
I had raised a previous one which got closed stating its a support request. Referring to Issue #26471

Current Behavior 😯
The application resets the theme of currently rendered component (e.g. background-colour becomes transparent)
Expected Behavior 🤔
The application and the loaded component should retain the theme provided using ThemeProvider.
Steps to Reproduce 🕹

Create a yarn workspace with

a react-js application using create-react-app, call it main-app
react-js library using create-react-library, call it library-components
add a theme to main-app with different primary colour
load a component from library-components in main-app
the background-colour will reset

attaching an application which has same structure, and demonstrates the issue
reactjs-mui-theme-repo.zip

Instead of link, have attached a working application with instructions in readme file. The same cannot be reproduced via sand-box since it requires yarn workspaces / mono-repo kind of structure.
Context 🔦

I am trying to build a react-js application with pluggable functionality i.e. depending on which functions the user prefers, I will load the library dynamically. This solves two problems

provides micro-service kind of architecture to UI components as the library-components are now specific to a business service and developed and maintained by specific team
deployment wise, only components that are required will be downloaded to client application (without bloating the deployment)

Your Environment 🌎

`npx @material-ui/envinfo`
  Chrome used for testing
  System:
    OS: macOS 11.2.3
  Binaries:
    Node: 14.16.1 - ~/.nvm/versions/node/v14.16.1/bin/node
    Yarn: 1.22.10 - ~/.nvm/versions/node/v14.16.1/bin/yarn
    npm: 6.14.12 - ~/.nvm/versions/node/v14.16.1/bin/npm
  Browsers:
    Chrome: 90.0.4430.212
    Edge: Not Found
    Firefox: Not Found
    Safari: 14.0.3

You have multiple instances of @material-ui/core in your page. I would suggest adding dependency on it only in library-components and export there whatever the other modules need. I've checked locally it fixes the issue.
Next time, do not just open new duplicate issues, we will take a look on the problem as soon as we can.

Thanks for the prompt answer.
It does not work with the suggested solution. I updated the sample code as per suggestion

yarn list @material-ui/core output

10:51:51:~/%yarn list --pattern @material-ui/core
yarn list v1.22.10
└─<EMAIL_ADDRESS>✨  Done in 0.90s.

@matrial-ui/core is now reflecting in package.json of single project i.e. library-utils (in the attached case). @material-ui/core is also exported from it
All components now use material-ui components from this project library-utils. Yet the problem remains
Attached updated code showing the same issue (THEME being reset on load of library component).
reactjs-mui-theme-repo-main.zip

@mnajdova the suggested solution does not work and the issue is marked closed; Please comment on previous message

I believe it fails for the reason stated from start - multiple copies of @material-ui/core. However, the way to eliminate the same is to mark peer dependency in libraries and dependency in main app and then it works fine.
Hope that helps any other stuck on same.


tuning 3d cartographer for my data

hello, I am tuning 3d cartographer for my vel-16 data,but there is a big jump during trajectory build, I can't solve it,can you help me?
the configuration files , launch file, urdf file and result png files is here ,and the bag file is here.

@sunmk2006 We looked at your data and were somewhat able to reproduce your results.
The IMU data frequency is quite low (20Hz) and the data looks extremely noisy. We were able to cope with this somehow by telling Ceres to have really low confidence in the IMU data, but this is definitely a problem. It is also quite surprising that your bag contains exactly as many point cloud messages as it does IMU messages. How did you generate this data? Do you only query the IMU state when you receive a point cloud? In general it makes sense to sample the IMU much more frequently than that to allow Cartographer.

Closing for now since we believe the IMU data explains the poor performance. Please re-open if you have further questions and good luck tuning :)

I uploaded a new bag file，The IMU data frequency is 125HZ,but the jump still exists.

udp_jump.bag.zip
udp_jump_synchronization.bag.zip
In these two bag files, the laser data exists in the form of UDP packets, the difference is that the second files used the synchronization method mentioned earlier, and then cartographer will not have any warning information.

We further investigated the bag 2017-09-01-06-59-59.bag. Our rosbag_validate tool gave the following output:
$ rosrun cartographer_ros cartographer_rosbag_validate -bag_filename ~/Downloads/2017-09-01-06-59-59.bag
I1013 17:11:03.875735 87882 rosbag_validate_main.cc:110] Time delta histogram for consecutive messages on topic "/imu" (frame_id: "imu"):
Count: 43977  Min: 0.007915  Max: 0.008078  Mean: 0.007997
[0.007915, 0.007931)                            Count: 3 (0.006822%)    Total: 3 (0.006822%)
[0.007931, 0.007948)                            Count: 1 (0.002274%)    Total: 4 (0.009096%)
[0.007948, 0.007964)                            Count: 0 (0.000000%)    Total: 4 (0.009096%)
[0.007964, 0.007980)                            Count: 0 (0.000000%)    Total: 4 (0.009096%)
[0.007980, 0.007996)                            Count: 28 (0.063670%)   Total: 32 (0.072765%)
[0.007996, 0.008013)    ####################    Count: 43934 (99.902222%)       Total: 43966 (99.974983%)
[0.008013, 0.008029)                            Count: 4 (0.009096%)    Total: 43970 (99.984085%)
[0.008029, 0.008045)                            Count: 4 (0.009096%)    Total: 43974 (99.993179%)
[0.008045, 0.008062)                            Count: 1 (0.002274%)    Total: 43975 (99.995453%)
[0.008062, 0.008078]                            Count: 2 (0.004548%)    Total: 43977 (100.000000%)
I1013 17:11:03.876127 87882 rosbag_validate_main.cc:110] Time delta histogram for consecutive messages on topic "/velodyne_points" (frame_id: "velodyne"):
Count: 5985  Min: 0.048640  Max: 1.489060  Mean: 0.052874
[0.048640, 0.192682)    ####################    Count: 5969 (99.732666%)        Total: 5969 (99.732666%)
[0.192682, 0.336724)                            Count: 2 (0.033417%)    Total: 5971 (99.766083%)
[0.336724, 0.480766)                            Count: 2 (0.033417%)    Total: 5973 (99.799500%)
[0.480766, 0.624808)                            Count: 1 (0.016708%)    Total: 5974 (99.816208%)
[0.624808, 0.768850)                            Count: 1 (0.016708%)    Total: 5975 (99.832916%)
[0.768850, 0.912892)                            Count: 1 (0.016708%)    Total: 5976 (99.849625%)
[0.912892, 1.056934)                            Count: 2 (0.033417%)    Total: 5978 (99.883041%)
[1.056934, 1.200976)                            Count: 0 (0.000000%)    Total: 5978 (99.883041%)
[1.200976, 1.345018)                            Count: 3 (0.050125%)    Total: 5981 (99.933167%)
[1.345018, 1.489060]                            Count: 4 (0.066834%)    Total: 5985 (100.000000%)

The IMU timing looks decent, the velodyne timing though shows that you have ~10 gaps > 0.5 seconds, i.e. there are 10 instances were you do not receive Velodyne data for more than half a second. That fully explains the jumps.
However, we further looked into your bag data and created the following plot:

The x-axis is the index of the packet in the rosbag, the y axis is the difference between the timestamp of the first sensor packet and the current packet, i.e. t - t0. I provided this data in https://gist.github.com/SirVer/337ea5cea8550a219a9fdf47d59ad2bb.
There are a few interesting things to note here:

Initially, your IMU and laser have a timing offset of 25 seconds. Over time, the difference in timestamp becomes smaller.
Your velodyne not only has gaps in timing, but it also sometimes delivers the same timestamp for a few packets in a row.

This indicates that your IMU and your Velodyne are timed from different clocks that run with different speeds. It also shows that the clock for your Velodyne is not consistent. All of this explains the poor performance of Cartographer on your data.
What exactly is your capture setup?
I will close all of your open bugs now since your data is broken. Feel free to reopen a new bug report as soon as your timing is great.

I will recollect data and analyze it,Thank you for your kind help.

@sunmk2006
Hello, I am using a 16-lines LIDAR and IMU to build 3D map by cartographer.
I tun the parameters and run it with no error, the results are as follows:

There is a big gap with the real environment. I think the map is messy. What is the problem of this result? How can I solve it?
This is the validate result of my bag:

E0227 22:30:57.092067 19056 rosbag_validate_main.cc:365] Average IMU linear acceleration is 10.6084 m/s^2, expected is [9.5, 10.5] m/s^2. Linear acceleration data should include gravity and be given in m/s^2.
I0227 22:30:57.093359 19056 rosbag_validate_main.cc:398] Time delta histogram for consecutive messages on topic "/IMU" (frame_id: "imu"):
Count: 37968  Min: 0.004133  Max: 0.016211  Mean: 0.010000
[0.004133, 0.005340)	                    	Count: 2 (0.005268%)	Total: 2 (0.005268%)
[0.005340, 0.006548)	                    	Count: 3 (0.007901%)	Total: 5 (0.013169%)
[0.006548, 0.007756)	                    	Count: 8 (0.021070%)	Total: 13 (0.034239%)
[0.007756, 0.008964)	                    	Count: 828 (2.180784%)	Total: 841 (2.215023%)
[0.008964, 0.010172)	 ###################	Count: 35958 (94.706070%)	Total: 36799 (96.921089%)
[0.010172, 0.011380)	                    	Count: 345 (0.908660%)	Total: 37144 (97.829750%)
[0.011380, 0.012588)	                    	Count: 820 (2.159714%)	Total: 37964 (99.989464%)
[0.012588, 0.013796)	                    	Count: 1 (0.002634%)	Total: 37965 (99.992096%)
[0.013796, 0.015004)	                    	Count: 0 (0.000000%)	Total: 37965 (99.992096%)
[0.015004, 0.016211]	                    	Count: 3 (0.007901%)	Total: 37968 (100.000000%)
E0227 22:30:57.094650 19056 rosbag_validate_main.cc:382] Point data (frame_id: "rslidar") has a large gap, largest is 0.101409 s, recommended is [0.0005, 0.05] s with no jitter.
I0227 22:30:57.094745 19056 rosbag_validate_main.cc:398] Time delta histogram for consecutive messages on topic "/rslidar_points" (frame_id: "rslidar"):
Count: 3766  Min: 0.100213  Max: 0.101409  Mean: 0.100801
[0.100213, 0.100333)	                    	Count: 1 (0.026553%)	Total: 1 (0.026553%)
[0.100333, 0.100452)	                    	Count: 1 (0.026553%)	Total: 2 (0.053107%)
[0.100452, 0.100572)	                    	Count: 9 (0.238980%)	Total: 11 (0.292087%)
[0.100572, 0.100691)	                    	Count: 33 (0.876261%)	Total: 44 (1.168348%)
[0.100691, 0.100811)	      ##############	Count: 2717 (72.145515%)	Total: 2761 (73.313858%)
[0.100811, 0.100931)	               #####	Count: 972 (25.809877%)	Total: 3733 (99.123741%)
[0.100931, 0.101050)	                    	Count: 25 (0.663834%)	Total: 3758 (99.787575%)
[0.101050, 0.101170)	                    	Count: 6 (0.159320%)	Total: 3764 (99.946892%)
[0.101170, 0.101289)	                    	Count: 1 (0.026553%)	Total: 3765 (99.973450%)
[0.101289, 0.101409]	                    	Count: 1 (0.026553%)	Total: 3766 (100.000000%)

Here are my files:
demo_rsldiar_3d.launch
rslidar_3d.launch
mydemo_3d.rviz
rslidar_2d.urdf
rslidar_scan_3d.lua
my data bag
Do you know the problem?


Merge master

Merge with the origin branch
Added annotation_guide
Enabled auto-save to prevent Ctrl - S issue
Touched up dockerfile to ensure that permission is not a concern

Merge with the origin branch
Added annotation_guide
Enabled auto-save to prevent Ctrl - S issue
Touched up dockerfile to ensure that permission is not a concern


Add Configurable Delay for "Trigger when unavailable" Feature

Proposal
It would be very useful to add an option to configure a delay before triggering the "Trigger when unavailable" feature in Alarmo. Currently, the sensor triggers immediately when it becomes unavailable, which can cause issues if the unavailability is momentary, such as during a brief network disruption or integration restart. The requested feature would allow users to set a customizable delay (e.g., in seconds or minutes) after which the "unavailable" trigger is activated if the sensor remains unavailable for that duration.
Additional Info
The new functionality could be implemented as an additional setting in the Alarmo options, where users can specify the delay time. For example:

Trigger when unavailable (Checkbox)
Delay before triggering (Input box for time in seconds or minutes)

This feature would prevent false alarms or unnecessary triggers due to temporary and brief sensor unavailability, improving the reliability of the system.
Version Information

Alarmo Version: 1.10.4
Home Assistant Version: 2024.8.1

I'd still like to see this implemented.
@nielsfaber could you please reopen this?


Remove outdated scripts

These scripts are not only useless, but wrong.

Can one of the admins verify this patch?

Can one of the admins verify this patch?


Attached account not properly loading when attaching account without checking Remember account key Check box

Environment:
OS - Windows
Plugin Version - 0.1.226
IDE - Intellij Idea Ultimate 14.1.3 , JRE 1.8
Authentication - Publish Settings file
Steps:
Expand Azure.
Right click on Storage.
Click 'Attach External storage account'.
Attach an external storage account by providing account name and account key.
Uncheck the check box for Remember Account Key , while attaching account .
Click Ok , Storage account will be attached to the plugin .
But the Attached Storage account will not be able to load Blobs container , queues or table .
and will again prompt for storage Account keys .

This issue is fixed now.


allow positioning relative to previous step

This makes it easier to start at origin of canvas and move at each step relative to the previous step. Use data-x="+=1000" instead of absolute value, for example.

Hi @nchauvat, in an effort to clear up older issues/PRs we are pinging back to know if you are still tracking this request.
To give a little bit of context, recently a decision was made in the project to make the development more active and the first task is to clear up older issues like this one to see if the OP is still interested in keep it going.

The lack of response from the original maintainer made me look at other projects. I do not have time for impress.js nowadays. Please feel free to take over this PR or reject it. I think the feature is needed and the implementation was simple, someone else will surely take care of it.

I do not have time for impress.js nowadays.

Closing due to the lack of feedback from the OP. If you want to work in the PR again, feel free to comment here to open up the discussion again.
In the meantime we will try to follow other requests such as #485 and #425. Thanks for the PR!


Store beacons from registration in AsyncStore

@tedsf Please review and merge (or send comments).  Thank you!

great job @chrisotto !


arelle: enable only on python 3.4 DON'T MERGE

Motivation for this change
Python 3.4 is the version suggested by arelle.org
On other versions, the build fails, so this PR disables those.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] Linux

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

This needs to be reworked because of #29435

TLDR: merge this if the root cause of the problem on py36 is not solved before release 17.09.
Ok, the current situation is arelle on python3.6 works on the master branch, but for some reason, it does not build on the release branch. The cause of the problem seems to be outside the arelle build definition, considering that the arelle directory is the same in both branches.
If the problem causing the failure persists until the release, please merge this PR. Arelle is a 'niche' package that I have introduced into nixpkgs only recently. Normal users will use it on 3.4 ('official' version) anyway, because that's the definition of pkgs.arelle. Python 3.6 support is only relevant for developers who must use the latest Python for some reason. I don't expect this group of people to exist. If they do exist, they can use nixpkgs master instead. Very hypothetical. Please worry about relevant nixpkgs issues instead.


Improve compatibility on PlatformIO

GCC is more strict on some other platforms other then Arduino.
On PlatformIO, it will complain and throw error if the order of the variable declared does not match the order of the initialization.
So the order of declaration is changed to match the order on the initialization.

Oh, thank you for the contribution! I didn't know this platform, so I never thought about it.


CAPM3 references old BMH spec missing network-data

What steps did you take and what happened:
The BMO referenced in go.mod github.com/metal3-io/baremetal-operator v0.0.0-20200225121200-8161ce57c5af references an old BMH spec which is missing network-data, merged in here: https://github.com/metal3-io/baremetal-operator/pull/348
When you then go to provision a cluster, CAPM3 will edit the BMH object and not keep the network-data originally defined in the BMH object as it's pointing at an older spec which does not contain it.
What did you expect to happen:
The network-data defined in the BMH CR does not get wiped during cluster creation, and persists through cluster creation.
Anything else you would like to add:
Keep up the great work on this awesome project :)
Environment:

Cluster-api version:
CAPBM version: current
Minikube version: N/A
environment (metal3-dev-env or other):
Kubernetes version: (use kubectl version): v1.17.3

/kind bug

Thank you for reporting, We'll fix it asap!


fix: Google's 'translate.google.cn' address is no longer maintained,s…

fix: Google's 'translate.google.cn' address is no longer maintained,so needs to be replaced by 'translate.google.com'
Limited ability, make it better~

Codecov Report
Base: 65.35% // Head: 65.35% // No change to project coverage :thumbsup:

Coverage data is based on head (e92979b) compared to base (b987bdf).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #33   +/-   ##
=======================================
  Coverage   65.35%   65.35%
=======================================
  Files           1        1
  Lines         153      153
  Branches       32       32
=======================================
  Hits          100      100
  Misses         53       53

Impacted Files
Coverage Δ

src/packages/src/index.vue
65.35% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

I'm sorry to reply to you so late. translate.google.cn is not work, but i can't merge your pr, repo:master will be discard. Beacuse we are working on rewriting the new version of the library, the code in repo:next.


Rewrite getters for TzKT methods that support pagination

 Large bigmap + skip_history = OOM

 Replace offset with cursor pagination in fetchers


Setting outboundTrafficPolicy = REGISTRY_ONLY blocks traffic to meshed services in the same namespace

We wanted to restrict the traffic to external services, so we have set outboundTrafficPolicy to REGISTRY_ONLY in the configmap "istio" of "istio-system" namespace
mesh: |-
    outboundTrafficPolicy:
        mode: ALLOW_ANY

But after doing this change, even the communication between the meshed services in the same namespace is blocked.
As per the documentation https://istio.io/latest/docs/tasks/traffic-management/egress/egress-control/, meshConfig.outboundTrafficPolicy.mode, configures the sidecar handling of external services, that is, those services that are not defined in Istio’s internal service registry.
After making the change, comminication to External services like RDS and MQ were blocked as expected. We created the ServiceEntry to allow communication to external services and meshed services were able to send the traffic to those external services.
But communication between the meshed services are also blocked within the same namespace which is not expected since Istio should send the traffic to the meshed services as they will be part of the Istio's internal service registry already
Expected behavior:
meshConfig.outboundTrafficPolicy.mode set to REGISTRY_ONLY blocks traffic to only external services if they are not defined through ServiceEntry and should not affect communication to the meshed services within same namespace

The issue was that meshed services were talking to some external services for which service entry was not created. So it was failing


Still maintained?

The last update was in 2019. Is it still maintained?

No, it's essentially abandoned. This was just an experimental project when I was still at Baidu Inc.


Include e2e crate in workspace default members

Draft while testing.
Advantages:

No rebuilding needed when running e2e tests (good for CI).
cargo check now includes the e2e crate so it now catches
compilation errors where before you needed to run with --workspace

Disadvantages:

Slightly higher compilation time by default because e2e crate is
included. When I tested this was minor: always < 0.5 seconds after
touch shared/src/lib.rs and rebuilding.

Test Plan
CI

Only concern is cargo test now runs e2e tests as well right?

Like the Postgres tests I made them #ignored.

Codecov Report

Merging #1368 (c2e1f2d) into main (de0ca42) will decrease coverage by 0.45%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1368      +/-   ##
==========================================
- Coverage   66.71%   66.25%   -0.46%
==========================================
  Files         141      146       +5
  Lines       29757    29967     +210
==========================================
+ Hits        19853    19856       +3
- Misses       9904    10111     +207


Update sbd RA interval and timeout to sane values

The existing stonith:external/sbd monitor interval causes unnecessary stonith-sbd resource failure logging in multi-SBD configurations if only one SBD node fails.  The stonith-sbd monitor timeout is also set below the default of 20, which could lead to SBD monitor operation being more failure-prone on a busy cluster.
After running tests, I found this failure is only cosmetic, as fencing via "crm node fence " still works when the stonith-sbd RA is Stopped or in "FAILED" state after one sbd node goes offline, but failures in the logs have led to unnecessary Support Requests to the Azure CSS team.  This scenario could realistically happen to a customer if the HyperV host node on which the SBD VM runs fails and the VM needs to be reallocated on a different host or if one of the SBD nodes experiences a kernel panic and is not set up for kdump which will cause it to hang indefinitely.  To clear these errors, one must make sure the SBD node is back online and run "crm resource cleanup stonith-sbd".
Putting in PR to adjust the fence agent params back to stonith:external/sbd defaults (interval 3600 timeout 20) to help mitigate unnecessary SRs about these failures.  I can attach a video showing the RA monitor timeout and start failure after migration roughly 2 minutes into one SBD node going down if that helps with the POC here.  With default RA values, clusters are only at risk of these logs/failures once per hour whereas current values make that 240 times per hour.

@susegrant : Thanks for your contribution! The author(s) have been notified to review your proposed change.

TID addressing this configuration defect:
https://www.suse.com/support/kb/doc/?id=000020383

Thank you for contributing. The issue that's addressed in the pull request appears to be addressed in master. We'll close this pull request. If there are outstanding issues or questions, please add a comment or create a new pull request.


Server rendering in production

Hey there!
I'm having this issue for a couple of days now and don't know how to fix it.
I'm getting the following error on production:
No such file or directory @ rb_sysopen - public/js/server_rendering-7930ba59728fe68ecc97.js

This error is correct since no .js file is present with that name.
The actual path name is:
packs/js/server_rendering-7930ba59728fe68ecc97.js
Any idea where this problem is coming from? This code works perfectly in development but it seems wrong paths get assigned when deploying.
Any help in the right direction would be extremely helpful.
Kind regards
Jens

Sounds like there's a difference between the public_root_path and public_output_path of your webpacker.yml for the development and production environments
Your config/initializers/react_on_rails.rb might also be involved.

This is kind of embarrassing. I'm using react-rails on my app so this is completely in the wrong issue tracker.
Sorry for the inconvenience.


KI-HS50-H

Hi - I noticed you added the KI-HS70 which is great. I have the KI-HS50 and it seems to mostly work.  The power reporting doesn't quite work right, and the air flow setting doesn't seem to do anything.  Would it be possible to see if you can add support for this device?
Thanks!

Airflow settings unfortunately are trial and error; have you tried every permutation in the select option?
Are you able to clarify what you mean by “power reporting doesn’t quite work right?”
can you please run a debug and post the log output as well as any relevant screenshots?

Hi - thanks for getting back so quickly. Is there a better way to get debug other than 'logger' in the config file?
Are you able to clarify what you mean by “power reporting doesn’t quite work right?”  --> Example: Turning it 'off' works, but the switch changes back to 'on' after about 2 seconds. The device is still off though.

Are talking about the switch in the fan entity or are you talking about a switch entity?
Get Outlook for iOShttps://aka.ms/o0ukef

From: Cullingsong @.>
Sent: Thursday, August 11, 2022 4:20:32 PM
To: scottyphillips/echonetlite_homeassistant @.>
Cc: Scott Phillips @.>; Comment @.>
Subject: Re: [scottyphillips/echonetlite_homeassistant] KI-HS50-H (Issue #108)
Hi - thanks for getting back so quickly. Is there a better way to get debug other than 'logger' in the config file?
Are you able to clarify what you mean by “power reporting doesn’t quite work right?” --> Example: Turning it 'off' works, but the switch changes back to 'on' after about 2 seconds. The device is still off though.
—
Reply to this email directly, view it on GitHubhttps://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fscottyphillips%2Fechonetlite_homeassistant%2Fissues%2F108%23issuecomment-1211591571&data=05|01||cee5ae9318f5436a170708da7b619901|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637957956380776737|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=fRvj5zbF9zd11mb%2B7ffx5sd%2BsyJOIxotU6o6EtXuToo%3D&reserved=0, or unsubscribehttps://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAGHQNDH3ADCHZJBBYCEIE4LVYSLTBANCNFSM56GTORTQ&data=05|01||cee5ae9318f5436a170708da7b619901|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637957956380776737|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=PpD9wFVxy1Bkh4BKcC%2Fi7T2ljT4chpVsUkhY6S82f4M%3D&reserved=0.
You are receiving this because you commented.Message ID: @.***>

Switch in the fan entity

Would changing the following change the result?
HA must be restarted after the change.
fan.py L.98 -
    async def async_turn_on(
        self,
        speed: str = None,
        percentage: int = None,
        preset_mode: str = None,
        **kwargs,
    ):
        """Turn on."""
        if await self._connector._instance.on():
            self.async_write_ha_state()

    async def async_turn_off(self):
        """Turn off."""
        if await self._connector._instance.off():
            self.async_write_ha_state()

Hi nao-pon,
I just changed it but it's still acting the same. I'm just about to head out of town for a week. I'll troubleshoot it a bit more when I get back.
Thanks

Are you using the current HACS release or direct from GitHub? I’ve still got the most up to date code with all of the @nao-pon updates tagged as prerelease..
Get Outlook for iOShttps://aka.ms/o0ukef

From: Cullingsong @.>
Sent: Saturday, August 13, 2022 10:16:27 AM
To: scottyphillips/echonetlite_homeassistant @.>
Cc: Scott Phillips @.>; Comment @.>
Subject: Re: [scottyphillips/echonetlite_homeassistant] KI-HS50-H (Issue #108)
Hi nao-pon,
I just changed it but it's still acting the same. I'm just about to head out of town for a week. I'll troubleshoot it a bit more when I get back.
Thanks
—
Reply to this email directly, view it on GitHubhttps://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fscottyphillips%2Fechonetlite_homeassistant%2Fissues%2F108%23issuecomment-1213606661&data=05|01||e4fa899637254a6700cc08da7cc110b3|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637959465913064111|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=7ESfyfV9nZhFYZaGa0Vw9JAj1RXmCDj1kOkGrF2HQcc%3D&reserved=0, or unsubscribehttps://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAGHQNDFLCOHQBSM4MXH5LHTVY3SNXANCNFSM56GTORTQ&data=05|01||e4fa899637254a6700cc08da7cc110b3|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637959465913064111|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=fRuXQ2LzzbRoAPqfGwSyYhHeK3RUi0FglTqmicGQ%2Fuo%3D&reserved=0.
You are receiving this because you commented.Message ID: @.***>

Hi - sorry I'm back now.  I'm using the HACs version.  I'll give the git-hub version a try shortly

This issue may have been resolved in version 3.6.1. Please try 3.6.1.

@Cullingsong Version 3.6.2 has been released. It contains a modification that provides a more stable response.


DRAFT: Adding workflows for in-vehicle stack container images

This is a draft PR for adding workflows to push the in-vehicle stack images to the blueprint package registry. Please do not review just yet

This was created on an incorrect branch


Print packet id in hex instead of decimal

Whenever a packet is unimplemented, the packet id is printed out in decimal. This makes it difficult to find the respective packet to implement (when needed to) on the protocol documentation so instead of printing in decimal, it is printed in hex now. It should be easier to find packets on the protocol documentation now.
Also I understand really small changes are annoying in repositories, but I feel like this change can make development easier down the road.

Hey, Yeah makes sense. Thank you @neeleshpoli


Suffix '_protocol' onto circuit diagram info and approximate equality protocol file names

Avoids module/method name ambiguity that confuses mypy

Automerge cancelled: A status check is failing.

Automerge cancelled: A status check is failing.


Non-editable options for proposals.

Hi!
I need to create some proposals and so i need to specify options with the correct "nonce", but these options are skipped here.
https://github.com/safe-global/safe-core-sdk/blob/53a21d693467a3c1e47fe30fa4db28b4374af1b5/packages/safe-core-sdk/src/Safe.ts#L345-L347
My goal is to create proposals, which will be approved one by one.
And one more important point, txs shouldn't be packaged in MultiTx, bcs each of them can exceed the gas limit.
Maybe this code is more correct?
newTransaction = isMetaTransactionArray(safeTransactionData)
       ? { ...options, ...safeTransactionData[0] }
       : { ...options, ...safeTransactionData }

@VKapicyn thank you for your report.
When using safeTransactionData can accept an array or an object. You had two options there to do what you were trying to do:

When used as an object could optionally get the same properties used in options so you could already set the nonce inside the object.
You could pass an array with only 1 transaction and use the options field as normal.

As this "flexibility" is causing confusion we are going to change the function to accept an array only, that will be enough to cover all cases.


No longer works in Puppet 3.8

Compatability for this module states: Puppet >= 3.0.0 < 6.0.0
However, that doesn't seem to fit with this section of agent.pp:
      case $facts['os']['architecture'] {
        "x86_64": { $arch = 'amd64' }
        "i386": { $arch = '386' }
        default: { $arch = facts['os']['architecture'] }
      }

I believe, as per https://puppet.com/docs/facter/3.9/core_facts.html, that ['os']['architecture'] isn't supported before facter 3.9.  Prior to that it's just ['architecture'].
I'm entirely prepared to be wrong as I'm reasonably new to Puppet, but this fails for me in Puppet 3.8 with:
Info: Loading facts
Error: Could not retrieve catalog from remote server: Error 400 on SERVER: Syntax error at '['; expected ']' at /etc/puppet/environments/newrelic_infra2/modules/newrelic_infra/manifests/agent.pp:190 on node ***..com

Hi @StuWhitby, thank you for reporting the issue. I have create a ticket to be internally handled by the engineering team.

Hi @StuWhitby  We've just released a backcompat version that works in puppet => 3.4 in Ubuntu => 14.05 <= 16.04
https://github.com/newrelic/infrastructure-agent-puppet/releases/tag/0.10.0-legacy
Install with : puppet module install newrelic-newrelic_infra --version 0.10.0-legacy
We'll release a fixed version with the proper requirements later on.
Please let us know if this works for you

Just wanted to leave a thank you!!!! this legacy post is perfect!. If anyone is struggling with error:
Syntax error at '['; expected ']'

@StuWhitby  advice was spot on. The legacy agent file provided in the link above resolved my issue.The os[arch] indeed was the issue. This works with puppetNG confirmed 3.2/3.3
legacy agent repo: [https://github.com/newrelic/infrastructure-agent-puppet/releases/tag/0.10.0-legacy]
Thanks again for the post.

Just wanted to leave a thank you!!!! this legacy post is perfect!. If anyone is struggling with error:
Syntax error at '['; expected ']'

@StuWhitby  advice was spot on. The legacy agent file provided in the link above resolved my issue.The os[arch] indeed was the issue. This works with puppetNG confirmed 3.2/3.3
legacy agent repo: [https://github.com/newrelic/infrastructure-agent-puppet/releases/tag/0.10.0-legacy]
Thanks again for the post.


Luckperms Sponge-Forge API8 with SQL cannot unset permissions

Description
When using SQL unsetting permissions from both groups and players seems to give feedback but not remove from the database or sync
Reproduction Steps
Setup Luckperms with SQL on spongeforge 1.16
Set a group or player permission
Try to unset said permission
Expected Behaviour
Permission is removed from player/group
Server Details
SpongeAPI 8.0.0 - SpongeForge 1.16.5-36.2.5-8.0.0-CustomBuild
LuckPerms Version
v5.3.103
Logs and Configs
Permission being set removed from group (With editor)
https://gyazo.com/01112dbce634141c03e824b51717e090
Permissions still existing in the group after removal
https://gyazo.com/b38354e437c0bdf05e1218de5018e301
[Server thread/INFO] [/]: [08-28 16:58:43] [Server thread] [INFO] CommandLoggerModule » Jirachi tried to run "lp group default permission unset test.perm"
[Server thread/INFO] [/]: [08-28 16:58:43] [Server thread] [INFO] CommandLoggerModule » Jirachi ran "lp group default permission unset test.perm"
[28Aug2022 16:58:43.072] [luckperms-command-executor/INFO] [net.minecraft.server.dedicated.DedicatedServer/]: [LP] LOG > (Jirachi@violet) [G] (default)
[28Aug2022 16:58:43.072] [Sponge-AsyncScheduler-1700/INFO] [luckperms/]: [Messaging] Sending log with id: 54732b99-f799-4d23-a0cd-2d70c4871d6a
[28Aug2022 16:58:43.072] [luckperms-command-executor/INFO] [net.minecraft.server.dedicated.DedicatedServer/]: [LP] LOG > permission unset test.perm

Extra Details
No response

try updating luckperms and see if the issue still persists

Same issue on latest

Slight update seems like the database has thousands of null id entries from the old remove might be related

https://gyazo.com/8849f98b49857fcd56ec0ac5c0fa8cdf
Very much still an issue

Edit solution found turns out our schema (used sql on mariadb) did not create primarykeys or autoincrement on any of the permission tables
https://gyazo.com/88d8e9b6961687ee70c8488873b7492d
added PK and AI to expected spots and everything functions unsure if this is an issue with table creation using SQL on MARIA but seems like a pretty glaring issue for that that will not autocorrect itself currently
Would be nice to have an automatic check that updates tables to have PK/AI on startup before load to ensure that issue does not happen but all seems good now!


Telemetry for traffic for cluster with no endpoints i.e. traffic which will be dropped

Telemetry for dropped traffic via the black hole cluster
Description:
Istio has a concept of wildcard listeners which are configured with SO_ORIG_DST flag set and have a default cluster called BlackHoleCluster which is a static cluster with no endpoints configured:
    {
        "name": "virtual",
        "address": {
            "socketAddress": {
                "address": "<IP_ADDRESS>",
                "portValue": 15001
            }
        },
        "filterChains": [
            {
                "filters": [
                    {
                        "name": "envoy.tcp_proxy",
                        "config": {
                            "cluster": "BlackHoleCluster",
                            "stat_prefix": "BlackHoleCluster"
                        }
                    }
                ]
            }
        ],
        "useOriginalDst": true
    }

where the BlackHoleCluster is configured like this:
  {
        "name": "BlackHoleCluster",
        "type": "STATIC",
        "connectTimeout": "10s"
    }

I updated this filter chain recently to add another filter which will invoke the custom Istio Mixer to generate telemetry for the cases when BlackHoleCluster is hit, the new filter chain looks like this:
   {
        "name": "virtual",
        "address": {
            "socketAddress": {
                "address": "<IP_ADDRESS>",
                "portValue": 15001
            }
        },
        "filterChains": [
            {
                "filters": [
                    {
                        "name": "mixer",
                        "config": {
                            "disable_check_calls": true,
                            "mixer_attributes": {
                                "attributes": {
                                    "context.reporter.kind": {
                                        "string_value": "outbound"
                                    },
                                    "context.reporter.uid": {
                                        "string_value": "kubernetes://productpage-v1-5cb458d74f-tpb4v.default"
                                    },
                                    "destination.service.host": {
                                        "string_value": "BlackHoleCluster"
                                    },
                                    "source.namespace": {
                                        "string_value": "default"
                                    },
                                    "source.uid": {
                                        "string_value": "kubernetes://productpage-v1-5cb458d74f-tpb4v.default"
                                    }
                                }
                            },
                            "transport": {
                                "check_cluster": "outbound|9091||istio-policy.istio-system.svc.cluster.local",
                                "network_fail_policy": {
                                    "base_retry_wait": "0.080s",
                                    "max_retry_wait": "1s",
                                    "policy": "FAIL_CLOSE"
                                },
                                "report_cluster": "outbound|9091||istio-telemetry.istio-system.svc.cluster.local"
                            }
                        }
                    },
                    {
                        "name": "envoy.tcp_proxy",
                        "config": {
                            "cluster": "BlackHoleCluster",
                            "stat_prefix": "BlackHoleCluster"
                        }
                    }
                ]
            }
        ],
        "useOriginalDst": true
    }

The issue is that in this configuration mode, the Mixer filter never gets invoked and hence we can never get any telemetry for the BlackHoleCluster
My question is what's the correct way to achieve this functionality where we have a SO_ORIG_DST listener which is a TCP proxy filter that will drop traffic by default and still invoke custom filters in the chain?
Relevant Links
https://github.com/istio/istio/pull/15512

@mattklein123 any pointers you can give would be very helpful.

I'm not sure why that config would not work, if the tcp_proxy filter is being hit. I would discuss with the Istio people for debugging help.

Won't the Mixer filter only get invoked on events related to TCP lifecycle and in this case since there's no TCP connection that is created (BlackHole cluster has no endpoints) I'm assuming filter will not get invoked?

There could be some optimization to avoid invoking filters when upstream cluster is empty... I guess the request is to opt-out from this optimization.

There could be some optimization to avoid invoking filters when upstream cluster is empty... I guess the request is to opt-out from this optimization.

Exactly, I feel like that's what happening here.

There is no such optimization. What is most likely happening is tcp_proxy is failing the request in the connect callback, and mixer is doing things elsewhere, and not taking into account that case.

Yeah, the mixer filter seems to wait until onData is invoked: https://github.com/istio/proxy/blob/master/src/envoy/tcp/mixer/filter.cc#L138
Thanks for the help!

Closing as this issue is on Istio's end as to how we are setting up the Mixer filters.


Added pprint function to parameterized.py

This PR adds something I've long wished for in param: sensible, short reprs that actually work. :-)
Although I started implementing this in __repr__,  I saw the note about repr needing to be fast and then decided against implementing it there once I realized what was required.
Instead of changing __repr__, I've ended up making a more robust pprint function that can be used as follows:
class Foo(param.Parameterized):

    a = param.Number(4, precedence=6)

    b = param.String('B', precedence=-9)

    c = param.Number(4, precedence=0)

    z = param.Number(4, precedence=0)

    def __init__(self, a, b, c=4, d=99, **kwargs):
        self.d = d
        super(Foo, self).__init__(a=a, b=b, c=c, **kwargs)

    def __repr__(self):
        return param.parameterized.pprint(self, {'d':self.d})

First the positional arguments are shown as their appropriate values. Then modified keyword arguments are shown in the order they are declared in. Then the varargs (e.g *varargs) is shown (if present). Then if a keyword dictionary (i.e. **kwargs) is present, it is assumed that the modified parameters can then be listed in order of their precedence.
Here are some examples:
>>> Foo(1,'C')
Foo(1, 'C')

# Positional arguments always shown even if at default values
>>> Foo(4,'B')
Foo(4,'B')

# Keyword not shown if supplied at default value
>>> Foo(4,'B', c=4)
Foo(4,'B')

>>> Foo(4, 'B', c=5)
Foo(4, 'B', c=5)

# 'd' is not a parameter (supplied at the default value)
>>> Foo(4,'B', c=5, d=99)
Foo(4, 'B', c=5)

>>> Foo(4,'B', c=5, d=100)
 Foo(4,'B', c=5, d=100)

>>>  Foo(4,'B', z=44, d=100)
 Foo(4,'B', z=44, d=100)

>>>  Foo(4,'B', z=4, d=100)
Foo(4, 'B', d=100)

For comparison, here is an example of the default repr:
>>>Foo(4,'B')
Foo(a=4, b='B', c=4, name='Foo00456', z=4)

My main concern with pprint is performance. It might be nice to cache some of the results of the introspection for performance reasons.
EDIT: If you are happy with the addition of this function, I'll make sure to write a good number of unit tests for it.

Coverage decreased (-1.29%) to 67.21% when pulling 93cce8d2a63d37968792ceeb4182b1ee0d4eec24 on improved_reprs into e4a7720417b9f6efb51888b7bb0de0e3db7a6aeb on master.

Although I started implementing this in repr, I saw the note about repr needing to be fast and
then decided against implementing it there once I realized what was required.

The comment is  # CB: __repr__ is called often; methods it uses should not be too slow. That comment's misleading, unfortunately (and is one of the ones listed to deal with during my 'comments cleanup' task...not that that will make you any happier :( ). It definitely used to be true that Parameterized's __repr__ was called often by code outside param (e.g. Topographica), so for short-term practical reasons we might have kept __repr__ fast, but the real fix is to stop calling __repr__ so often.
The big issue we had in the past was not calling logging (Parameterized.debug, .verbose, etc) methods correctly:
# CEBALERT: designed to avoid any processing unless the print
# level is high enough (e.g. to avoid expensive str(Parameterized
# instance) calls). Not all callers are taking advantage of this
# (either calling str() themselves, resulting in potentially
# expensive operations for things that might never be printed, or
# redundantly using lambda functions to avoid the
# processing. Should fix that.
#
# Note that Python's logging module would simplify print
# statements still further (see "topographica's debug printing"
# emails between CB&JB).
def __db_print(self,level=INFO,*args):

I'm sure at one point we found a debug statement called so often that it slowed simulations down, or something like that. We fixed that (probably it happened several times...), but I don't know how much incorrect calling of the logging methods is left across ioam code.

Oh dear, param itself is not setting a good example. For instance, a quick search reveals how we're calling __repr__ multiple times every time we create a Parameterized instance:
    def _setup_params(self,**params):
        [...]
        for name,val in params.items():
            desc = self.__class__.get_param_descriptor(name)[0] # pylint: disable-msg=E1101
            if desc:
                self.debug("Setting param %s=%s"% (name, val))
            else:
                self.warning("Setting non-parameter attribute %s=%s using a mechanism intended only for parameters" % (name, val))
            # i.e. if not desc it's setting an attribute in __dict__, not a Parameter
            setattr(self,name,val)

(https://github.com/ioam/param/blob/master/param/parameterized.py#L1288)

Ok. Thanks for the background!
I've discussed this PR with Jim and I'm now working on integrating this new functionality with script_repr. That avoids introducing a new concept while leaving the existing __repr__ alone.

I agree about not introducing the extra concept of pretty print. But if we weren't calling __repr__ so often, wouldn't we want to improve it? Apart from speed, wouldn't it be nice to merge this code into __repr__? Or is there something everyone prefers about the existing __repr__ (e.g. how it prints all parameters, not just ones that have been overridden from the default)?

I'd rather the existing repr change to only print overridden parameters; I think that's much more useful and better from the command line and seems like an easy change to make.  But Jean-Luc's changes require the inspect module, which seems like overkill for repr() but is fine for script_repr.

Fixing the bad example from param above seems like an excellent idea; no reason to be slowing things down...

Coverage decreased (-1.12%) to 67.38% when pulling<PHONE_NUMBER>e028ef3204793e016e4fcab0975377 on improved_reprs into e4a7720417b9f6efb51888b7bb0de0e3db7a6aeb on master.

I would also like this functionality for __repr__. That said, it definitely makes sense for script_repr and now it is implemented switching __repr__ as well would be as simple as:
def __repr__(self):
    return self.script_repr()

My biggest objection now is that I would really like script_repr to be renamed to pprint: even if you are printing everything, script_repr is always pretty printing due to nice indentation it introduces. I think pretty printing is a concept people will immediately understand as opposed to 'script repr' which will mean nothing to most people.

I'm fine with pprint, but don't personally want to deal with the headache of changing it.  repr() can be script_repr without the indentation, but probably best not to have indentation on for repr() by default...

Coverage decreased (-1.02%) to 67.48% when pulling 3f642d1814c5c4bbc59963f537f117c447e9d289 on improved_reprs into e4a7720417b9f6efb51888b7bb0de0e3db7a6aeb on master.

Coverage increased (+1.73%) to 70.23% when pulling 41f30853da478c8831f443ab22a8a650282735ee on improved_reprs into e4a7720417b9f6efb51888b7bb0de0e3db7a6aeb on master.

Coverage increased (+1.73%) to 70.23% when pulling<PHONE_NUMBER>85aed96123d4291e5bc8f353faa81c on improved_reprs into e4a7720417b9f6efb51888b7bb0de0e3db7a6aeb on master.

Ok, to summarize (tell me if I'm wrong):

This PR could be merged as it is now to give us better script_repr.
We'd like to rename script_repr to pprint but that will be a pain (although isn't it possible to do everything as pprint and also leave the script_repr name around pointing at pprint for a couple of releases?).
We'd like __repr__ to be like the script_repr of this PR, but (a) Jim objects that using inspect is overkill for __repr__ (but Jean-Luc and I don't see the problem) and (b) __repr__ shouldn't have the indentation that script_repr has.

If that's right, what should we do? Merge this PR to get a better script_repr for the upcoming release and decide what to do about the other things afterwards? Or should we be more conservative (leave this PR for after the release), or more ambitious (make __repr__ better for the upcoming release)?

Here are my responses to each of your bullet points:

Yes, I think this could be merged now. In some ways, the earlier we merge the better as that gives us more time to find potential issues before release.
I really would like pprint as a name. Aliasing script_repr to pprint for now does makes sense to me; it doesn't look like the public API is going to be cleaned up for this release so it isn't a terrible thing to do.
a) My worry about using inspect (and the full pprint functionality) in __repr__ is essentially down to how much that might affect performance b) I am happy leaving a script_repr function that has suitable indentation (and other options) for representing large objects.

I do want to see this merged before the next release and think adding pprint and aliasing script_repr to it would be ok. I probably wouldn't replace the existing __repr__ before this release though...

I'm fine with you merging (and hence having more chance to find potential issues), and doing the script_repr aliasing if you have time. We can then improve __repr__ later - and hopefully by then the performance of __repr__ won't matter (because we'll have checked for and fixed any bad calls of debug, verbose etc from other ioam code).

Ok..please merge this now, otherwise I'll click the button myself later!