Add Kiron Roy to Contributors list

I'm quite elated about your pull request. I wanna evolve this project to addresses various problems faced by first-time contributors. I'd love to learn about your journey in open source community, the problems, pain points you had etc.
Could you explain how you felt when you went through the tutorial, made a pull request and learned that I merged it?
We’ve recently added Facebook share and tweet feature to our web app. Could you please go to https://roshanjossey.github.io/first-contributions/#social-share and share your first contribution to open source?
Also, check out projects with easy issues while you’re there.

This is the first time I did a pull request and make a separate branch.  The tutorial was clear and I  learned a valuable skill.
Mostly I use github to expand my GitHub wiki: kiron roy wiki as well host my site: kiron roy

I’d urge you to continue contributing to other open source projects.
We also have a slack team to help/mentor people trying to contribute to open source projects.
You can join the team by going to https://goo.gl/PM1Jdh


Update tutorialAngular2.step_04.html

Remove semi-colon to improve consistency with the following code section

Another typo. Thank you again. @Urigo please accept.


Migrate layout stage to plugins

Summary
This commit updates the preset pass manager construction to only use plugins for the layout stage. To accomplish this the previously hard coded built-in layout methods, trivial, dense, noise adaptive, and sabre are migrated to be exposed as built-in plugins. Additionally, the special case of layout_method=None has been centralized into a standard default method plugin, as the pass construction in this case involved extra steps for each optimization level. This simplifies the preset pass manager construction as now the layout stage is solely built via plugins.
Details and comments
Fixes #9455

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

123 of 130 (94.62%)  changed or added relevant lines in 5 files are covered.
25 unchanged lines in 2 files lost coverage.
Overall coverage decreased (-0.03%) to 87.244%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

qiskit/transpiler/preset_passmanagers/builtin_plugins.py
115
122
94.26%

Files with Coverage Reduction
New Missed Lines
%

crates/qasm2/src/lex.rs
7
90.63%

crates/qasm2/src/parse.rs
18
96.67%

Totals

Change from base Build<PHONE_NUMBER>:
-0.03%

Covered Lines:
74250

Relevant Lines:
85106

💛  - Coveralls


formatting and context for non Go developers

This PR focused on giving more context to first time users, especially non Go users. As part of my experience, the surprise was the fact that it looked like things didn't work when really, setup.sh was taking a while and I didn't ssh into it right away to tail the logs.
Some markdown cleanup was also done due to the tooling I use locally, let me know if that's an issue.

Extracted as 54108723f6c1c5.


just a few typos

Dr. Sarami,
Just fixed a few typos and added a statement for clarification concerning the .git extension.

Thank you for the corrections, Julio.

No problem Dr. Sarami!  GitHub rocks, I don't use it enough :-)
—
Sent from Mailbox
On Thu, Oct 22, 2015 at 9:27 PM, Chekad Sarami<EMAIL_ADDRESS>wrote:

Thank you for the corrections, Julio.
Reply to this email directly or view it on GitHub:
https://github.com/FSTATEU/cooperative-learning-in-CS/pull/1#issuecomment-150401545

If you have a project in mind and you think I can contribute let me know.

Sure thing, likewise.
—
Sent from Mailbox
On Thu, Oct 22, 2015 at 9:56 PM, Chekad Sarami<EMAIL_ADDRESS>wrote:

If you have a project in mind and you think I can contribute let me know.
Reply to this email directly or view it on GitHub:
https://github.com/FSTATEU/cooperative-learning-in-CS/pull/1#issuecomment-150410024

Ok! You do programming in C++?

I've done some C++.  It's been a while.  The most recent C-like programming I've done has been fixing public exploits for a cyber security certification I'm working on.
What C++ project are you working on?
—
Sent from Mailbox
On Fri, Oct 23, 2015 at 7:03 AM, Chekad Sarami<EMAIL_ADDRESS>wrote:

Ok! You do programming in C++?
Reply to this email directly or view it on GitHub:
https://github.com/FSTATEU/cooperative-learning-in-CS/pull/1#issuecomment-150544244


Create entity table extractor to populate KG fields

Added a simple heuristic to ETK to detect entity tables and use glossaries to extract from entity tables.


[VS Code] The SSL connection could not be established, see inner exception.

Error:
The SSL connection could not be established, see inner exception.
Steps to Reproduce:

Version Data

extensionName
VSLS

extensionVersion
0.3.535

protocolVersion
2.2

applicationName
VSCode

applicationVersion
1.24.1

platformName
Linux

platformVersion
4.17.2-200.fc28.x86_64

This is a dupe of https://github.com/MicrosoftDocs/live-share/issues/764. Please try the workaround mentioned in that issue and let us know if that doesn't work for you.


feat: read words sequentially

Hi there,
I want to practice over existing (non-randomized) texts. I'm toying with this. Maybe eventually, we can do something like cat sample.txt | toipe.
What do you think of this idea?

This change will read words in a text file in sequence. No piping support yet. (Apologies in advance for bad Rust. I'm new to it).
The -s (sequential) flag must be provided in combination with -f.
Limitations:

-n must be provided for long texts (over default 30)
files with too many lines will not fit the screen
there's no scrolling yet
word/character filtering may need to be tweaked

Oops. I didn't realize that a similar work, #57, is already underway 🤦


Fallback to linewise ctype when no right comment string

This resolves #275.

No, this is unexpected behaviour IMO. You just don't fallback to a completely different thing. Blockwise and linewise are separated for a reason. If you want this behaviour, I would suggest you to make a custom keybindings.

While I agree that the suggested behaviour may be surprising at first, I consider the current behaviour to be a bug; the user expects the specified lines to be un(commented) but only the first line is affected. This is never what the user wanted unless only one line, or part thereof, is specified - in which case it will behave in the same way as my suggestion. The suggested behaviour of falling back to linewise comments for languages that don't support comment blocks would be well-documented and could be toggled with a config flag.
If you're still not convinced, I could make another pull request that changes the current behaviour to do nothing and display a warning stating that block comments are not supported in the current language. I would consider this preferable to attempting to make a blockwise comment with a linewise comment string and failing.

You just don't fallback to a completely different thing. Blockwise and linewise are separated for a reason.

Linewise comments on subsets of a line use blockwise comment strings. For example, gcw and gbw are equivalent.

You just don't fallback to a completely different thing. Blockwise and linewise are separated for a reason.

Linewise comments on subsets of a line use blockwise comment strings. For example, gcw and gbw are equivalent.

Yes, I admit that's one intersection b/w blockwise and linewise, and that's because of https://github.com/tomtom/tcomment_vim, from which i ported the behaviour.

display a warning stating that block comments are not supported in the current language.

💯. I am in complete favour of this.

If you want this behaviour, I would suggest you to make a custom keybindings.

Could you help me in making this keybinding? Currently what i have is:
vim.keymap.set("v", "<leader>/", function()
	vim.api.nvim_feedkeys(vim.api.nvim_replace_termcodes("<esc>", false, true, true), "nx", false)

	local blockwise = require("Comment.api").toggle.blockwise(vim.fn.visualmode())
	local ok = pcall(blockwise)
	if not ok then
	 	require("Comment.api").toggle.linewise(vim.fn.visualmode())
	end
end, noremap)

but the current behaviour is that what's inside the if block always runs, since aparently either if i get the error
[Comment.nvim] python doesn't support block comments! or not, error attempt to call a nil value always returns from the pcall.

@renxzen did you find a solution to catch those errors and fallback too linewise?

@renxzen I found a way to fallback on errors
    vim.keymap.set({ 'x', 'n' }, '<leader>c', function()
      vim.api.nvim_feedkeys(esc, 'nx', false)
      -- If the blockwise toggle fails fallback to linewise (e.g. for python which has no blockwise comments)
      local err = vim.fn.execute 'lua require("Comment.api").toggle.blockwise(vim.fn.visualmode())'
      if err:find 'Comment.nvim' then
        -- Try to toggle linewise instead
        api.toggle.linewise(vim.fn.visualmode())
      end
    end, { desc = 'Toggle [C]omment', silent = true })


Service Discovery Page rework

Based on the work done in #10103, I applied the same logic for the service discovery page.
this PR should be merged after #10103

@Nexucis With the first PR merged, could you rebase this one?

@juliusv it's done, hopefully it's easier to review now :)

:+1:


Logan/dense x retrieval

Description
Adds a llamapack with an initial implementation of the paper Dense X Retrieval: What Retreival Granularity Should We Use?.

In general, my conclusion on this paper/method is that
a) it's very similar to retrieving based on KG triplets (just like our KG index)
b) its quite slow, expensive, using the LLM to generate propositions (similar to the KG index lol)

wait @logan-markewich can you change the name of the notebook

it says "fuzzy citation query engine"


However, I think it would be much nicer to turn the x86 QEMU bootimage runner thingy into a cargo runner binary, as I discussed in https://github.com/tosc-rs/mnemos/pull/326#issue-2459700790.


support vpc configuration of multiple external network segments through label and crd

[ ] Make sure you have followed Kube-OVN Code Style.

What type of this PR
Examples of user facing changes:

Features

Which issue(s) this PR fixes:
Fixes #(issue-number)
WHAT

🤖 Generated by Copilot at 6ac6836
This pull request adds support for multiple external subnets for a VPC in the kubeovn API and controller. It modifies the VpcSpec and VpcStatus structs, the vpc.go and subnet.go files, and comments out the BFD and custom VPC static route features, which are incompatible with the new feature.

🤖 Generated by Copilot at 6ac6836

No more static routes, no more BFD
We unleash the power of multiple subnets
We reconcile the VPCs with a new spec
We handle the gateways with a new logic

HOW

🤖 Generated by Copilot at 6ac6836

Add support for multiple external subnets for a VPC (link, link, link, link, link, link, link, link, link, link, link)
Add a new field ExternalSubnets to the VpcSpec and VpcStatus structs in types.go to store the desired and actual external subnets for a VPC (link, link)
Import the sort package in vpc.go to sort the external subnets in the handleAddOrUpdateVpc function (link)
Modify the handleDelVpc function in vpc.go to loop over the external subnets in the VPC spec and call handleDelVpcExternalSubnets for each subnet (link)
Modify the handleAddOrUpdateVpc function in vpc.go to check the external subnets in the VPC spec and status, and call handleAddVpcExternalSubnets or handleDelVpcExternalSubnets for each subnet that is added or removed (link)
Rename the handleAddVpcExternal function in vpc.go to handleAddVpcExternalSubnets and add a parameter subnet to specify the external subnet to connect (link)
Change the references to the c.config.ExternalGatewaySwitch to the subnet parameter in the handleAddVpcExternalSubnets function in vpc.go, and replace the logic to get the gateway chassis from the config map to the node labels (link)
Change the call to c.acquireIPAddress and c.createOrUpdateCrdOvnEip in the handleAddVpcExternalSubnets function in vpc.go to use the subnet parameter instead of the c.config.ExternalGatewaySwitch (link)
Change the call to c.OVNNbClient.CreateLogicalPatchPort in the handleAddVpcExternalSubnets function in vpc.go to use the subnet parameter instead of the c.config.ExternalGatewaySwitch, and the lspName and lrpName variables to use the subnet parameter instead of the c.config.ExternalGatewaySwitch (link)
Append the external subnet to the vpc.Status.ExternalSubnets slice in the handleAddVpcExternalSubnets function in vpc.go if it is not already in the slice (link)
Rename the handleDelVpcExternal function in vpc.go to handleDelVpcExternalSubnets and add a parameter subnet to specify the external subnet to disconnect (link)
Change the references to the c.config.ExternalGatewaySwitch to the subnet parameter in the handleDelVpcExternalSubnets function in vpc.go, and the lspName and lrpName variables to use the subnet parameter instead of the c.config.ExternalGatewaySwitch (link)
Remove the external subnet from the vpc.Status.ExternalSubnets slice in the handleDelVpcExternalSubnets function in vpc.go if it is in the slice (link)
Comment out the call to reconcileCustomVpcStaticRoute in the reconcileSubnet function in subnet.go, which is used to reconcile the static routes for a custom VPC (link)
Comment out the code related to the BFD feature in the handleAddOrUpdateVpc function in vpc.go, which is not compatible with the multiple external subnets feature (link)

@zcq98 this is a really cool feature! i'm waiting for merging this pr =)

hi @oilbeater ,  could you help review this ?


maintainers/scripts/update.nix: exit with nonzero exit code when script fails

Description of changes
This allows tools/scripts like @r-ryantm to properly detect when updates fail, avoiding broken/partial PRs like #190648.
Not sure how I can make the commit message shorter than 50 characters, suggestions welcome.
Also, does the brach name read like I'm talking about a package named signal? I think it could be unclear in the merge commit message, though I guess it really doesn't matter...
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[x] aarch64-darwin

[x] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

We can do a rebase merge if you feel the merge commit could be a problem. I usually ignore those.

How's this instead?


There are no tags

Hi. I want to use geolocator via rails-assets. But when I tried to create new component at https://rails-assets.org/components/new , i got an error.
geolocator has no versions defined. Please create an issue in component's repository.

Can you please tag it?

Hi there. Created release v1.2.8. This should work for rails-assets.

@onury Thanks!


Several minor fixes & enhancements to GoSNS

Use the configured account ID instead of<PHONE_NUMBER>00 in topic ARNs
Add support for RawMessageDelivery & FilterPolicy to the Subscribe action
Add more attributes to GetSubscriptionAttributes response to bring in line with the AWS response

If you'd prefer these split out into separate atomic PRs, let me know and I'll resubmit.

I don't know where the errors on travis on this or my other PR are coming from – they're in the test setup, not the tests themselves.

Ya I am aware I will investigate over the weekend -
do all the unit tests pass in your local?
On Fri, Sep 27, 2019 at 1:45 PM Michael B. Klein<EMAIL_ADDRESS>wrote:

I don't know where the errors on travis on this or my other PR are coming
from – they're in the test setup, not the tests themselves.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/p4tin/goaws/pull/202?email_source=notifications&email_token=ABW5I3BNJ4YALLVMFGNHLJDQLZBDDA5CNFSM4I3I7TPKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD7ZT5SI#issuecomment-536035017,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABW5I3ELYHT53WTVADNEOP3QLZBDDANCNFSM4I3I7TPA
.

Yes


How to disable this for tests

I want to disable it in tests because it fails in different places for different reasons:

missing kubeconfig which cannot be provided to build enb
not valid certificate for kube client
requirement for connection between k8s and build env

I tried to disable it during test phase but without luck:
spring:
  cloud:
    kubernetes:
      discovery:
        enabled: false
      enabled: false

the discovery.enabled: false has no effect at all -- Config is still being created and throws exception.
When I added kubernetes.enabled: false then I have exception:
Parameter 0 of method discoveryClient in org.springframework.cloud.kubernetes.discovery.KubernetesDiscoveryClientAutoConfiguration required a bean of type 'io.fabric8.kubernetes.client.KubernetesClient' that could not be found.
	- Bean method 'kubernetesClient' not loaded because @ConditionalOnProperty (spring.cloud.kubernetes.enabled) found different value in property 'spring.cloud.kubernetes.enabled'

Probably you are missing
@ConditionalOnProperty(value = "spring.cloud.kubernetes.enabled", matchIfMissing = true)
@ConditionalOnBean(KubernetesClient.class)

on whole KubernetesDiscoveryClientAutoConfiguration.class
and @ConditionalOnMissingBean(DiscoveryClient.class) on method discoveryClient

@sta-szek you are totally right.. I will work to fix this one

@salaboy Have you started work on this? If not, I can pick up the issue

This does indeed seem like a duplicate of #183

Any progress with this one? Seems to be nice and easy fix but makes it impossible to disable kubernetes discovery client for tests in a clean way - we need to mock kubernetesClient bean.

@geoand @piotr-napadlek I haven't started on this one yet. I am just catching up with stuff after @s1p
@piotr-napadlek you are right.. it will complicate the testing. but I think that we need to change the tests as well. I am not happy with the way that we are testing stuff.

@salaboy We can talk about this as well I guess when you are done catching up after s1p and you have some time to talk :)

Closing duplicates #183


Allow opts to flow to the backend snapshotter during snapshot creation.

Signed-off-by: Eric Hotinger<EMAIL_ADDRESS>

@abwah - FYI you will need to rebase on this.

@abwah - FYI you will need to rebase on this.

Thanks, are you also planning to backport the hcsshim revender change that you made in containerd?

@abwah - This should be what you need.


[5850] Change "Site Tools" to "Project Tools"

https://github.com/craftercms/craftercms/issues/5850

Closing this due to a wrong upstream merge


Insert timeout

Hey,
I'm having this error after few minutes running it:
[12/19/14 00:22:39] [EROR] insert error (read tcp <IP_ADDRESS>:27017: i/o timeout)
[12/19/14 00:22:39] [CRIT] Failed: failed insert on collection archived: read tcp <IP_ADDRESS>:27017: i/o timeout

And so the script stops.
Any idea?
Thanks

yeap, i think i fixed that, check this: https://github.com/MongoHQ/seed/pull/5


ORC-1463: Support brotli compression codec

This has been resolved by https://github.com/apache/orc/pull/1714

Thanks for updating, @deshanxiao .


feat: support mutli manager addrs

Description

Support mutli manager addrs.

Related Issue

Motivation and Context

Screenshots (if appropriate):
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Documentation Update (if none of the other choices apply)

Checklist:

[x] Code compiles correctly.
[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[x] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[x] I have added tests to cover my changes.
[x] All new and existing tests passed.

Codecov Report

Merging #846 (0b34093) into main (ee68e97) will not change coverage.
The diff coverage is 77.77%.

:exclamation: Current head 0b34093 differs from pull request most recent head 3302f27. Consider uploading reports for the commit 3302f27 to get more accurate results

@@           Coverage Diff           @@
##             main     #846   +/-   ##
=======================================
  Coverage   41.15%   41.15%
=======================================
  Files         102      102
  Lines        8070     8070
=======================================
  Hits         3321     3321
  Misses       4339     4339
  Partials      410      410

Flag
Coverage Δ

Object-compatibility-e2etests
?

e2etests
?

unittests
41.15% <77.77%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

client/config/peerhost.go
35.29% <0.00%> (ø)

client/daemon/daemon.go
5.66% <0.00%> (ø)

manager/searcher/searcher.go
66.66% <100.00%> (ø)

client/daemon/peer/peertask_base.go
46.66% <0.00%> (ø)


Go code doesn't compile on OSX

Due to some platform dependent weirdness in the x509 system library (which we forked):
src/github.com/google/certificate-transparency/go/x509/root.go:15: undefined: initSystemRoots
src/github.com/google/certificate-transparency/go/x509/verify.go:213: c.systemVerify undefined (type *Certificate has no field or method systemVerify)
src/github.com/google/certificate-transparency/go/x509/verify.go:213: not enough arguments to return

This should be fixed by #1006


Refine structure of weekly notes

Instead of using bullet points using numeric lists would be beneficial for advisor to state specific points.

I am closing this one due to inactivity.


Unused mapping in FraxferryV2/FerryOnL1.sol

I found an unused mapping here:
https://github.com/FraxFinance/frax-solidity/blob/fc9810d72c520d256965b81b6c9cc6aa95d07d9d/src/hardhat/contracts/FraxferryV2/FerryOnL1.sol#L32.  Is this residual code or intended to be used?

The 'fee_exempt_addrs' mapping allows captains to specify addresses that should not be charged fees when using the ferry service.
uint fee;
if (fee_exempt_addrs[_captain][msg.sender]) {
fee = 0;
} else {
// Fee calculation logic based on captain's fee parameters
}

Your issue have been solved right?!

Yes @GauravPatil7050 .


Slightly change rules warning messages

This commit comes with an improvement of warning messages by:

Fix typos in excessive length rules by changing to many to
too many.
Change 'configured' to 'allowed', removing the implicit meaning
of a framework configured limit values for rules.
Make Cyclomatic Complexity case removing the inconsistency
with NPath Complexity which was already case.

Current coverage is 94.38%

Merging #23 into master will not affect coverage as of aa47c20

@@            master     #23   diff @@
======================================
  Files           57      57
  Stmts         1603    1603
  Branches         0       0
  Methods          0       0
======================================
  Hit           1513    1513
  Partial          0       0
  Missed          90      90

Review entire Coverage Diff as of aa47c20

Powered by Codecov. Updated on successful CI builds.

Thank you for your contribution! :beer:


GEODE-6054: Build with Visual Studio 2017 runtime.

The only build error was a warning-as-error failure due to a gtest header.  Well-known problem, fixed with a cmake variable in the gtest CMakeLists.txt

FWIW, This is fixed in a gtest version newer than 1.8, but 1.8 is what we're currently on:  https://github.com/google/googletest/issues/1111
Co-authored-by: Ernest Burghardt<EMAIL_ADDRESS>

Gonna close this for a bit - we still have quite a bit of work to do, it seems...


Updated import statements in the tutorial

Simple PR correcting the tutorial.
Maybe we could consider to make a test that run doctest on it to ensure that it actually works.

Codecov Report
Base: 73.57% // Head: 73.57% // No change to project coverage :thumbsup:

Coverage data is based on head (22685ca) compared to base (1d66e7d).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #40   +/-   ##
=======================================
  Coverage   73.57%   73.57%
=======================================
  Files          10       10
  Lines         598      598
=======================================
  Hits          440      440
  Misses        158      158

Impacted Files
Coverage Δ

tripper/triplestore.py
79.70% <0.00%> (ø)

tripper/backends/rdflib.py
96.55% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

Does doctest run the Python code? What is doctest?

doctest runs Python code in docstrings. Good for ensuring that the documentation is up-to-date and that examples actually works.

It seems to only work for Python shell doc strings (starting with >>>). Perhaps this one will be better: https://github.com/tmarktaylor/phmdoctest ?

Squash+merge at will.


Problem while creating app release with v 0.2.7 and flutter v1.12.13+hotfix.8

Describe the bug
Hello
I have a problem with version 0.2.7 and flutter version v1.12.13+hotfix.8
I create de apk and when I install it it launches and then closes (crashes)
To Reproduce
flutter build apk --release, install and run
Expected behavior
The app should work
Platform information

Flutter version: v1.12.13+hotfix.8
Plugin version:0.2.7

https://github.com/cloudwebrtc/flutter-webrtc/issues/205#issuecomment-601541102
this answer helped me to resolve the issue

@ac130kz I have already added proguard to my project and I the apps that I generate still crash when I install and run them :(

I really need help with this, I have added proguard and this stills crashes, Is it possible that the problem is with the new R8 proguard for flutter?

@ZatacaSystems, do you have this issue so far?
I just commit to the master branch library level ProGuard configuration file (#243). Could you please try to rebuild you app with git version of flutter-webrtc?

@ycherniavskyi yes, sorry I forgot to close this. I was miswriting the name of the proguard file ^^' it works like a charm when you do the proguard steps the right way 👍


proposal: text/template: make "eq" support all comparable types

The current eq function is limited only to "basic types",  and it does not support other Go types that are comparable, like pointers or structs.
Also, it's not possible to decorate it, because it's private. Setting "eq": reflect.DeepEqual won't provide the same functionally, because cases like this:
package main

import (
	"log"
	"os"
	"reflect"
	"text/template"
)

func main() {
	tmpl, err := template.New("titleTest").
		Funcs(template.FuncMap{
			"goeq": reflect.DeepEqual,
		}).
		Parse(`{{ eq .A 1 }} != {{ goeq .A 1 }}`)
	if err != nil {
		log.Fatalf("parsing: %s", err)
	}
	err = tmpl.Execute(os.Stdout, struct{ A int64 }{1})
	if err != nil {
		log.Fatalf("execution: %s", err)
	}
	// Output: true != false
}

https://play.golang.org/p/zTg33Lggq0f
My current solution is just copying the current code from text/template/funcs.go, and adding the support by myself.
I would like to hear what others think about this, because it feels like a basic functionality that is missing when working with Go types.
If this proposal will be accepted, I will be more than happy to contribute my changes.

I'm not sure I get what you're proposing; the title seems to suggest Go's == for pointers and structs as per the spec, but your example uses reflect.DeepEqual, which is quite a bit more complex than Go's equality operator.
See https://golang.org/pkg/reflect/#DeepEqual and https://golang.org/ref/spec#Comparison_operators.

Hey @mvdan, sorry for not being clear.
My proposal is about adding support for all comparable types in the builtin eq function (or at least pointers).
About the example I've added above (with reflect.DeepEqual) -
I tried to demonstrate that as a user of this package, it's not possible for me to decorate (or extend) the existing eq function and add support for other comparable types. The current solution is just to override it.
The quickest way that came to my head was to override it with reflect.DeepEqual, but that was wrong, because the 2 functions don't provide the same functionally as I showed above (eq has this "loose comparison" for numeric types).
So I ended up with copying the eq function from funcs.go and added the support in my code.
Is there any objection about adding this support? or, at least part of it (pointers only)? If not, I would like to contribute my changes.

CC @robpike

It's too bad that comparison of interface values panic if the types aren't comparable, and there is no way to avoid that bar catching the panic. If we were willing to catch the panic, which would be expensive but probably very rare in practice, we could just do return v1 == v2 in teh default clause of the switch k1 case in the eq function.
That might be the right solution.

No comments, so proposal accepted.


Add back outpatient care setting

@rdahlman3 did you see these merge conflicts?

Oops, no I didn't. Looks like the necessary changes were made at some point anyway, so closing this PR


update context and tf .14 support

what
fixes and updates for tf 0.14 compatibility

/test all

/rebuild-readme


Ignoring native build directories not working during packaging

Please describe your issue:
I m not able to ignore some directories when packaging the app. I m using sqlite3 module and it'll generate intermediate build directory in node_modules\sqlite3\build path, it is be around 25MB which I don't want to part of the app. Can shave ~25MB of the total app size.
I m ignoring using electronPackagerConfig.ignore, like below:
"electronPackagerConfig" : {
    "ignore": [
        ".vscode",
        "node_modules/sqlite3/build"
    ]
}

But it seems, the electron-package is running before the native build and thus above ignore is of no use. I've seen this behavior by checking the %temp%\electron-package\ directory where the packaging is happening.
To prove the above, .vscode directory is not included in the app.asar as I've it in the ignore list. And similarly, if I use node_modules/sqlite3, then the complete sqlite3 directory is not getting bundled and then I m getting native build failed error which is expected.
Is this the expected order (first package, then build)? If this is the expected order, how to ignore directories which will be created during the native builds?

config.forge data in package.json:
"forge": {
    "make_targets": {
        "win32": ["squirrel"],
        "darwin": ["zip"],
        "linux": ["deb","rpm"]
    },
    "electronPackagerConfig": {
        "ignore": [
            ".vscode",
            "node_modules/sqlite3/build"
        ]
    },
    "electronWinstallerConfig": {
        "name": "electron_forge_demo"
    },
    "electronInstallerDebian": {},
    "electronInstallerRedhat": {}
}

Repro repo: https://github.com/manikantag/electron-forge-native-binaries-issue
Generate package: npm run package
Verify if sqlite3/build is present or not: asar l app.asar | grep build
OS details: Windows 8.1 x64

But it seems, the electron-package is running before the native build and thus above ignore is of no use.

This is accurate, you need to use an afterCopy hook to delete the artifacts you don't want from the native module build process.
/cc @malept I don't think we should do this ^^ by default as some people may want the debug artifacts. What do you think?

@MarshallOfSound can you tell me how to ignore some dir/files using afterCopy?

@manikantag Not ignore really, more like delete.
Use a combination of fs.unlinkSync and the glob module.

Excuse me for asking questions in this issue.
I m writing some console logs, but Forge cli output is only seen, no console logs. Where do I see them? Thanks.

@MarshallOfSound I m not sure how to use afterCopy.
config.forge in package.json:
"forge": {
         "afterCopy": [
                  "./forge-hooks.js"
         ]
}

forge-hooks.js:
const fs = require('fs');
function afterCopy() {
    fs.unlinkSync('d:/test.txt');
}
module.exports = afterCopy

The afterCopy hook is not working as d:\test.txt file is not getting deleted. I m trying to go through the source (https://github.com/electron-userland/electron-forge/blob/master/src/api/package.js#L84), but no clue so far.
What is the correct way of using afterCopy and what are the arguments.

fs.unlinkSync('d:/test.txt');

That path looks wrong (for windows).  Try this.
fs.unlinkSync('d:\\test.txt');

You can also try adding some console.log calls to ensure that JS file is being resolved correctly.

Okay, I figured it out. I need use config.forge.electronPackagerConfig.afterCopy, but not config.forge.afterCopy.
But the require is failing.
"electronPackagerConfig": {
        "afterCopy": [
                    "./forge-hooks.js"
         ]
}

If I give absolute path, it is working.

fs.unlinkSync('d:/test.txt');
That path looks wrong (for windows). Try this.

Node fs module will take care of it even when using /.

You can also try adding some console.log calls to ensure that JS file is being resolved correctly.

As I mentioned in earlier, I m not seeing any console.logs when I m using forge start or forge package or any forge command. Where can I see console.logs?

Okay, I figured it out. I need use config.forge.electronPackagerConfig.afterCopy, but not config.forge.afterCopy.
But now, the require is failing.
"electronPackagerConfig": {
    "afterCopy": [
        "./forge-hooks"
     ]
}

If I give absolute path, it is working.
DEBUG log:
An unhandled rejection has occurred inside Forge:
Cannot find module './forge-hooks'
Error: Cannot find module './forge-hooks'
    at Function.Module._resolveFilename (module.js:469:15)
    at Function.Module._load (module.js:417:25)
    at Module.require (module.js:497:17)
    at require (internal/module.js:20:19)
    at C:\eapp\node_modules\electron-forge\dist\api\package.js:297:51
    at Array.map (native)
    at _callee4$ (C:\eapp\node_modules\electron-forge\dist\api\package.js:296:119)
    at tryCatch (C:\eapp\node_modules\regenerator-runtime\runtime.js:64:40)
    at GeneratorFunctionPrototype.invoke [as _invoke] (C:\eapp\node_modules\regenerator-runtime\runtime.js:355:22)
    at GeneratorFunctionPrototype.prototype.(anonymous function) [as next] (C:\eapp\node_modules\regenerator-runtime\runtime.js:116:21)
    at GeneratorFunctionPrototype.tryCatcher (C:\eapp\node_modules\bluebird\js\release\util.js:16:23)
    at PromiseSpawn._promiseFulfilled (C:\eapp\node_modules\bluebird\js\release\generators.js:97:49)
    at Promise._settlePromise (C:\eapp\node_modules\bluebird\js\release\promise.js:572:26)
    at Promise._settlePromise0 (C:\eapp\node_modules\bluebird\js\release\promise.js:612:10)
    at Promise._settlePromises (C:\eapp\node_modules\bluebird\js\release\promise.js:691:18)
    at Async._drainQueue (C:\eapp\node_modules\bluebird\js\release\async.js:133:16)

Got the arguments: buildPath, electronVersion, pPlatform, pArch, done.
I got these from https://github.com/electron-userland/electron-forge/blob/master/src/api/package.js#L64

@manikantag The afterCopy hooks are documented over at electron-packager.
https://github.com/electron-userland/electron-packager/blob/master/docs/api.md
I'm looking into the relative path issue now

I m using https://www.npmjs.com/package/rimraf to delete build dirctory as I need to dir with files in it.

<EMAIL_ADDRESS>should fix the path resolution issue, gonna close this out as the recommended solution is to use an afterCopy hook to clean up.

Would say that if someone can make a super generic afterCopy hook to clean up a node_modules directory as a separate module that would be pretty cool.
electron-packager-cleanup-hook

With 2.7.3, it is working with relative paths. Pretty quick fix! Thanks.


LOG:  checkpoints are occurring too frequently (15 seconds apart)

Frequent warning during initial import from planet-latest.osm.pbf:
20:42:24.644 UTC [28] LOG:  checkpoints are occurring too frequently (17 seconds apart)
2019-07-19 20:42:24.644 UTC [28] HINT:  Consider increasing the configuration parameter "max_wal_size".

Any suggestions?

@davidmegginson  I am also facing the same issue .
I would like to know did you fix the issue ..?
if yes ,Please share here
any help from anyone will be much appreciated..!

Those lines can be ignored. During initial import the database is put under a lot of stress, ideally all CPU cores and disk IO are at (almost) maximum usage. The installation will finish and not be slowed down by the infrequent checkpoints.
The Nominatim project has a rough guide on Postgresql setting http://nominatim.org/release-docs/latest/admin/Installation/#postgresql-tuning Those are from Postgresql 9.3 times and work alright. They're heavy dependent on what hardware is used so with a docker setup there won't be single perfect setting.

I've just run into this problem as well.  How long should I wait before giving up?  It appears to have started about 12 hours ago.

2022-07-25 02:03:43.550 UTC [31871] LOG:  checkpoints are occurring too frequently (27 seconds apart)
2022-07-25 02:03:43.550 UTC [31871] HINT:  Consider increasing the configuration parameter "max_wal_size".

As mtmail already indicated, this is expected during import.
So you should wait as long as the import is running.

Thank you @Stefanic for the quick response.
I'm concerned, simply because there doesn't appear to be a lot of activity right now.  The CPU's (all 32) are pretty quiet.  Wondering if there is a way to make sure that the process is not hanging?

You should see progress in the 'Done 1140 in 2 @ 556.124 per second - rank 30 ETA (seconds): 1.88' lines

I believe it locked up.  There has been no updates on the screen for over 24 hours.

...  Never mind!  It's running!  Thank you for all that answered my questions and everyone for all your hard work.


Check that query redactor is constructed before accessing it's attribute

Description
Check that query redactor is constructed before accessing it's attribute
The (possible) error message will be more specific and easier to find cause
Type of change

[ ] Refactor
[ ] New feature
[ ] Bug fix
[ ] CVE fix
[ ] Optimization
[ ] Documentation Update
[ ] Configuration Update
[ ] Bump-up dependent library
[x] Test update

/retest

/retest

/retest

/retest

/lgtm

/approve


Fabric support for 1.16.4

Is your feature request related to a problem? Please describe.
The Problem is the Mod isn't on Fabric Yet!
Describe the solution you'd like
Support for Fabric (Yes I knew it's a big leap from Forge, but it's worth it)
Describe alternatives you've considered
Inventory Hud+ was the only semi-decent mod I could find.
Additional context
Really I'm more wanting it added to the newest version 1.16.4 and don't think people will demand other versions yet so, 1.16.4 should be fine

Yessss !!!

There is a partial 1.16.5 version, maybe someone could finish it (please)?
https://github.com/mccreery/better-hud/tree/1.16.5


FirebaseAnimatedList won't update if app goes in background

FirebaseAnimatedList won't update if app goes in background , when you navigate it gets updated.

@PrimeNexes
The issue at https://github.com/flutter/flutter/issues/15611 has been closed and moved here. Future collaboration on this issue will be done here.


PickerColumn not exported anymore (Ionic 2, beta 11)

Short description of the problem:
Since I updated to Ionic 2 Beta 11 I can't import PickerColumn from ionic-angular anymore. That means I can't create my custom picker anymore.
What behavior are you expecting?
I expect PickerColumn to be importable from ionic-angular, just like Picker, PickerController and PickerOptions are.
The code (excerpt) below can't work, but did with beta 10:
    private pickerColumn: PickerColumn;

    ...

    someFunction(): void {
        this.pickerColumn = { name: 'col1', options: [] };
        this.picker = this.pickerCtrl.create();

        ...

        this.picker.addColumn(this.pickerColumn);
        this.picker.present();
    }

Which Ionic Version? 1.x or 2.x
Ionic 2 Beta 11
ionic info :
Your system information:
Cordova CLI: 6.1.1
Gulp version:  CLI version 1.2.1
Gulp local:   Local version 3.9.1
Ionic Framework Version: 2.0.0-beta.11
Ionic CLI Version: 2.0.0-beta.32
Ionic App Lib Version: 2.0.0-beta.18
OS: Windows 10 x64
Node Version: v5.12.0
Edit:
I know this feature is not documented yet, but I'd still like to keep using it  ;)

These need to be added back: https://github.com/driftyco/ionic/commit/215c6d846c6eb157b4510e63d863d2fdcf13b9af#diff-4c662dc4cf4f974e0f27891faea175b0L35


README.md android/setting.gradle  should be android/settings.gradle

believe android/setting.gradle should be android/settings.gradle with an s

Thanks for noticing, @ScandyMark


Add Turkish translated docs files

For the documents, I translated a total of 14 files from English to Turkish.

Thank you very much @mertingen! That's so cool that we're getting translations in many languages.
I made the linters happy and fixed some tiny issues (some markup needs to stay in English to be understood by the GitHub parser).
The last step is to add a new tr.yaml file here to translate the extra strings needed for the website: https://github.com/dunglas/frankenphp-website/tree/main/i18n
Can you open a PR in this repo too?

Thank you very much @mertingen! That's so cool that we're getting translations in many languages.
I made the linters happy and fixed some tiny issues (some markup needs to stay in English to be understood by the GitHub parser).
The last step is to add a new tr.yaml file here to translate the extra strings needed for the website: https://github.com/dunglas/frankenphp-website/tree/main/i18n Can you open a PR in this repo too?

Thanks @dunglas ,
I closed this PR by mistake, sorry. By the way, I created the file you mentioned.
https://github.com/dunglas/frankenphp-website/pull/16

Thank you very much!


update worker nodes upgrade flow

Currently, worker nodes are updated independently of etcd/controlplane nodes. They also get updated independent of each other. This also implies that once cluster shows up as "active" after control/etcd nodes are upgraded, there's no cluster state that indicates worker nodes' state. We should make the following changes:

Worker nodes shouldn't get updated before etcd/controlplane nodes
Worker nodes also respect some kind of upgrade strategy such that not all of them are updated simultaneously
Introduce logic for upgrade strategy and state transitions so that this information is easily available to be displayed in UI

https://github.com/rancher/rancher/issues/23038

created individual issues for these, closing this issue

Hi @deniseschannon @kinarashah I see alot of these roadmap issues including these 3, slated for 2.4 but they appear to not be in the 2.4-Alpha release. At least not yet. Does that mean they will still be or will more likely be in a later release? Or did I miss them in the alpha commits? Any expected timeframe for this release to be GA?


Source Code

Can u update the source code to 4.1? Thanks

I do not want to update the code for 2 reasons:

It's absolutely awful
I'm pretty sure someone from quizizz checks GitHub for the hacks once or twice a day, and that would make their lives a lot easier.

The code has been updated to the latest version of the binaries so enjoy!


0.99.5 micrometer-core-1.3.8.jar error

When I updated to 0.99.5, the following error occurred.
The problem was solved by replacing micrometer-core-1.3.8.jar with micormeter-core-1.3.9.jar.
--------error-----------------------------------------------------------------
java.lang.NoSuchMethodError: io.micrometer.core.instrument.binder.jvm.ExecutorServiceMetrics.monitor(Lio/micrometer/core/instrument/MeterRegistry;Ljava/util/concurrent/ScheduledExecutorService;Ljava/lang/String;Ljava/lang/String;[Lio/micrometer/core/instrument/Tag;)Ljava/util/concurrent/ScheduledExecutorService;
at com.linecorp.armeria.server.ServerConfig.(ServerConfig.java:159) ~[armeria-0.99.5.jar:na]

Micrometer version of Armeria is updated to 1.5.1 in 0.99.5.
There is a Micrometer backward incompatibility issue.
https://github.com/micrometer-metrics/micrometer/issues/2002
I think our workaround is right approach.

Please feel free to reopen if you need further assistance.


Labelled optics migration

See the new records/optics sections in the standards.
Goals:

Drop uses of OverloadedRecordDot. It should be outright banned after this feature is complete.
Add optics-core and optics-th dependencies. These are actually already transitively available.
Create all the required instances using makeFieldLabelsNoPrefix.
Fix any errors that arise. Without using any fancy combinators besides (%) and (%%).

Moved to notion
https://www.notion.so/liqwid/Labeled-optics-migration-a7a1a65b1c2b43e8baba7df030ab16d9


new API - trying again

I have some examples should work:
function f(x) {
    var i = x.p();
    var o = process(i);
    x.q(o);
}

function f(x, y, z) {
    var i = x.p(),
        j = y.p();
    var o = process(i, j);
    z.q(o);
}

function g() {
    var r;
    // ...
    function f() {
        for (var x of arguments)
            r.q(x.p());
    }
}

function g() {
    var r;
    // ...
    function f() {
        var a = toArray(arguments).map(function (x) {
            return x.p();
        });
        r.q.apply(r, a);
    }
}

Let's talk about these examples. f is a function, x = [x,y,z,r] are objects with p,q methods. The p method is for receiving data the q method is for sending data to the x. Sending data to the x can probably trigger another f call.

Be aware that this is more than anything else before, since we are not talking about flow, port, socket, etc... just playing with javascript. So we have only language boundaries.

What rules should x follow? Why is it in the arguments and why r isn't? They are probably created the same way, so why? We need to register x somewhere, so the f caller will know that it should pass x.
function fCaller() {
    var registry = [x, y, z];
    f.apply(null, registry);
}

When does fCaller call f?

when p/q was called on some of the registered xs
when it was invoked from outside, so completely independently from the xs

// push

(a + b).on("push", function f(a, b, c, d) {
    var i = (a + b).read();
    var o = process(i);
    (c + d).push(o);
});

// pull

(a + b).on("pull", function f(a, b, c, d) {
    (c + d).pull(function g(a, b, c, d) {
        var o = (c + d).read();
        (a + b).write(o);
    });
});

(a + b).on("pull", function f(a, b, c, d) {
    (c + d).pull(function g(o) {
        (a + b).write(o);
    });
});

(a + b).on("pull", function f(a, b, c, d) {
    var o = await((c + d).pull());
    (a + b).write(o);
});

When do we call the pull cb? do we need only a single write, or can we have multiple write and a write-end signal should call the cb?
c.on("pull", function (c){
    c.write(1);
    c.write(2);
    c.write(3);
    c.writeEnd();
});

or just
c.on("pull", function (c){
    c.write(1, 2, 3);
});

Do we really need the pull and push methods?
// push

a.on("write", function (a, b) {
    b.write(a.read());
});

a.on("push", function f(a, b) {
    b.push(a.read());
});

// pull

a.on("read", function f(a, b) {
    b.read(function g(a, b) {
        a.write(b.read());
    });
});

a.on("pull", function f(a, b) {
    b.pull(function g(a,b){
        a.write(b.read());
    });
});

a.on("pull", function f(a, b) {
    a.write(await b.pull());
});

The 2 method approach is ambiguous.... read(cb) means pull, while read() means simple read. So if somebody forgets to add a cb, then the data won't be pulled. Note that in the background of b.pull(cb) we have a b.on("write", cb) that we don't have by a simple read(). Another problem, that a single b.read() would need to trigger the b.on("read", l) unless the API is not consistent. So I think we should stick with the 4 method approach.

What about:
// read, write, pull, push

a.on("pull", function f(a, b) {
    b.pull(function g(a,b){
        a.write(b.read());
        a.write(b.read());
        a.write(b.read());
        a.push();
    });
});

a.on("push", function f(a, b) {
    b.write(a.read());
    b.write(a.read());
    b.write(a.read());
    b.push();
});

What about
// read, write, pull, push

a.on("pull", function f(a, b) {
    b.pull(function g(a,b){
        a.write(b.read());
        a.write(b.read());
        a.write(b.read());
    });
});

a.on("push", function f(a, b) {
    b.push(a.read());
    b.push(a.read());
    b.push(a.read());
});

Is it really mandatory, that only a single write() should trigger a pull cb, or a single push cannot contain multiple messages?
What if I do
b.write(1);
b.write(2);
b.write(3);
b.pull(function (){
    a.push(b.read());
    a.push(b.read());
    a.push(b.read());
});

Can a write exist without a pull?
By a pull, should we notify only the puller, or should we notify everybody, that a new message is available? If the latter one is true, should we notify the puller on the same channel than the others?

I managed to clarify this:
.pull() = .read() + .notify("pulled")		# reads the already written data and notifies about waiting receivers
.pull(cb) = .await(cb) + .notify("pulled")	# awaits the data and notifies about waiting receivers
.push(d) = .write(d) + .notify("pushed") 	# writes the data and notifies about data arrival
.write(d) 									# writes the data
d = .read() 								# reads the already written data
.await(cb(d)) 								# waits the data to be written, and then reads it

So it is possible to push data for a pull or pull data after a push.
Just to mention the notification should be built into the api and should be handled by the actual whatever object. I don't want to call it as a stream, since it isn't...

What should I call this? Is it even possible to push data to it and wait for a response? Actually that would be a loop in its current form...
a.await(function (data)(){
    console.log(data);
});
a.push(data);

How to do request / response?
In order to do that we need a pair:
a.await(function (data)(){
    console.log(data);
});
b.await(function (data){
    a.push(data);
});
b.push(data);

What about multiple arguments???
a.write(1,2,3);
while(data = a.read())
    console.log(data); // 1 -> 2 -> 3

I am not sure about this, I'll move this to a brainstorming issue later.


doc: implement semaphoreKeyPts

📝 Summary
implement SemaphoreVerifierKeyPts contract to Soroban #1
✅ Self-Check for Contribution Requirements
Mark with an x all the checkboxes that apply (like [x]).

[x] Forked the repository and created a new branch with a meaningful name.
[x] Ensured that the content is clear and free of grammatical errors.
[x] Maintained consistency in tone and formatting throughout the document.
[x] Verified that all links work correctly and checked for typos before submitting the changes.

[x] Thoroughly tested changes, including unit tests if applicable.

💬 Comments
Any additional context, questions, or considerations for the reviewers.

hello @evgongora kindly review :)

hello @evgongora kindly review :)

@evgongora removed requested changes

@martinvibes Could you please remove excessive comments for basic Rust or Soroban concepts? (e.g., what #![no_std] means, how #[contract] works)
Let's focus on the key concepts for the migration of the contract.

@evgongora kindly review :)


Throw nameof(cluster) in argument instead of nameof(parser) in ParsedMetaDataEntry

Found this little typing error in a utility class, while browsing the repository :)
Cool project!

Thanks


Fix movement directions to make to move with camera properly

Possible solutions?
https://stackoverflow.com/questions/39560851/handling-proper-rotation-of-cannon-body-based-on-quaternion
https://stackoverflow.com/questions/15867811/how-to-rotate-a-cannonjs-rigidbody

Polished player movements


When i set the path_static in constructor, html doesnt work well!

To resolve that i should change/add the new path for css routing because css and html files are in the statics and py files could be somewhere else

it solved in 0.0.12 ✅


Webapp React Boilerplate

Hey!
For the front-end I'm using react and will be adding the basic webapp
Like the sidebar as in the inspiration image of the UI

Hello @Bisht13 , thank you for showing interest in this project.
We are open to use any technology. But there should be a proper reason to use any particular technology. Can you justify why we should use React over vanilla JS in this project?


Possibility to 'collect' posts by theme

https://bsky.app/profile/johnlechner.bsky.social/post/3kd4xtgxfls22
"I wish users could curate their own favorites to stay accessible, kind of like a pinned post, but with categories"
Not my own idea, but I'd use this if it existed.
Could be called 'Collections', and I'd like the option to decide per collection if I want it to be only visible for myself or for everybody.

Glad to see this with an "on the roadmap" tag. Artists in particular have been making use of feed generators to collect their own art posts for this explicit purpose.
I recently buckled and made my own "Art & Projects" feed, where every single post included in the feed has been hand-picked and ordered — the only outliers are a couple posts that appear as a result of being replied to by the posts that I did select. (This was undesired behavior, I ended up having to reorder select posts to account for this.)
In this instance, I've used an external feed generator the same way I would want to use a Collection feature: as a manually-curated group of posts. It's one of my most missed features from Twitter, and I'd love to see it implemented natively in Bluesky.

Additional thoughts:
On visibility: I'd love an "Unlisted" option as well. Visible to everyone, but it doesn't appear in my list of Collections - people can only view it if they have a direct link.
I'd also like the ability to Subscribe to a Collection, and to set whether or not my own Collections can be subscribed to. Give me a notification when a Collection that I've subscribed to has been updated, like an RSS feed dropping new posts in my inbox. It'd definitely make it easier to keep up with artists and projects.


Merge Testing branch back into master

Description: After some talk with @raysarinas , I think we agreed that having a branch dedicated to just testing would lead to issues down the road when considering multiple different testing issues. The new and final plan for testing is to just stick to the current process of making issues for writing tests. If people are okay with this, I'll get started on testing!

thank u sir


Filter cards depending of the deck's features

To hide non relevant cards to the player it is necessary to filter the displayed cards with the colors and the game mode used for the deck.
Filter with color and game mode selected for the deck:

available cards in the search interface
recommended cards in the interface of a card's recommendations
Generate a json of text recommendations by colors and modes (currently generated for all the cards at once)
-If needed, gzipped the json or split the json by colors and game mode to avoid loading a too big Json if not necessary

Done. Zip was not necessary


Replace React.PropTypes with Flow types

(forked off of #267)
I'd like to use Flow types to document my React Component's props. If it were possible to do this, then React.PropTypes would be entirely superfluous—it's a less precise way of documenting the types, and the checks are performed at runtime instead of compile time.
This would allow lots of duplicated type definitions to be removed. You can see this in the Flow example code. Looking at just the Message type, for example, its definition is duplicated four times in the six components:
(as Flow type)
https://github.com/facebook/flow/blob/master/examples/flux-chat/js/components/ThreadSection.react.js
https://github.com/facebook/flow/blob/master/examples/flux-chat/js/components/MessageSection.react.js
(as React type)
https://github.com/facebook/flow/blob/master/examples/flux-chat/js/components/ThreadListItem.react.js
https://github.com/facebook/flow/blob/master/examples/flux-chat/js/components/MessageListItem.react.js
Ideally you'd be able to write something like:
/* @flow */
type Message = {
  authorName: string;
  date: Date;
  text: string;
};

var MessageListItem = React.createClass({
  propTypes: {
    message: Message
  },
  render: function() {}
});

Flow could use the type information for type checking, then strip it out completely for production, i.e. translate this to:
var MessageListItem = React.createClass({
  render: function() {}
});

This is supposed to become easier with the introduction of ES6 classes. An alternate class-based syntax:
type Props = { /*... */ }
type State = { /* ... */ }
class MyComponent extends ReactComponent<Props, State> {
  render() {
    /* typeof this.props is Props */
    /* typeof this.state is State */
  }
}

My understanding is that this is also blocked by the lack of bounded generics, so the the types of getDefaultProps, getDefaultState, setState, and setProps can be specified.

The plan is to be able to annotate the props type using Flow. It is made easier by ES6 classes since we have a nicer syntactic space for it.
class MyComponent extends React.Component {
  props : Props;
  state : State = { initial: 'value' };
  render() {
    /* typeof this.props is Props */
    /* typeof this.state is State */
  }
}

The syntactic solution for React.createClass is kind of messy.
var MessageListItem = React.createClass({
  props: (null : ?Props),
  render: function() {
    if (this.props !== null) { // guard for safety
      /* this.props is Props */
    }
  }
});

Perhaps Flow could build some special support that allows annotating props in this way but it seems like more work than it is worth, since the world is moving on to ES6 classes.
The goal is to provide a "React Modern" package which doesn't include runtime features for React.createClass/PropTypes/createElement and instead relies on language features like ES6 Classes/Flow/JSX. The other stuff will be continued to be supported in "React Classic".
If your entire codebase is Flowified, you don't need dynamic type checks.
However, PropTypes still serve the dynamic type checking scenario in the boundary to un-Flowified code. E.g. if you publish it online, others might want your type annotations for runtime type checking. However, I think that would be better handled by a generic Flow Safe or Flow Dynamic Boundaries solution rather than something React specific. Once we have that, there is no need for React PropTypes anymore.

I'll note that it's currently not possible to use React.Component classes in JSX with flow because React.createClass is currently special cased as a CustomClassT, and the only way to generate that type is with React.createClass.

@danvk, you should be able to use flow type syntax with React.Component subclasses now. If that is posing any issues for you, please reopen this. Thanks for the report!

@samwgoldman can you point to an example of this? Would be much appreciated!

@yanivtal There are a bunch of examples in the tests for the new React API. Note that many of the examples are designed to fail in an expected way, but that should give you an idea.

Was the hope to be able to do away with prop types and do type annotations with flow? All the examples use React.createClass. I'm hoping to be able to use ES6 classes, specify prop types with flow and then get autocomplete through https://atom.io/packages/ide-flow. Is something like that possible today?

Ahh, I found classes.js. Looks clean.

I don't seem to be able to make it work (running Flow 0.14.0). Here's my test case:
/* @flow */
type P = { width: number; };

class Label extends React.Component {
  props: P;
  render() {
    return
Label
;
  }
};

var f = ;

I expect this to produce 2 errors in the last line: that width is expected to be a number, and that height is not supported. Instead I get "No errors!" message. Am I doing anything wrong? I also tried extending React.Component<any,P,any> -- with the same result.

@pasha-mf You need to specify the type of defaultProps as well (ref #398).
Also, passing too many props is not an error, so Flow won't complain about it.
/* @flow */
var React = require("react");

type P = { width: number; };

class Label extends React.Component {
  props: P;
  static defaultProps: {}; // this part is important
  render() {
    return
Label
;
  }
};

var f = ;

Ok, but even after adding the declaration for defaultProps it still doesn't complain about width being a string...

Are you sure? I just tried and got this:
test.js|14 col 9 error|  React element: Label
|| Error:
test.js|14 col 22 error|  string
|| This type is incompatible with
test.js|4 col 19 error|  number
||

Yes... I've added a line var z : number = "one"; just to check that flow inspects the file, and that line did produce an error. It has a slightly different format though -- maybe you have a more recent version of Flow? mine is 0.14.0
js/test.js:15:18,22: string
This type is incompatible with
js/test.js:15:9,14: number

Does this work with ES6 import? I have
/* @flow */
import React from 'react';

type P = { width: number; };

class Label extends React.Component {
  props: P;
  static defaultProps: {}; // this part is important
  render() {
    return
Label
;
  }
}

let f = ;

Using Flow 0.17.0 and I get No Errors.

@pasha-mf Could you shed some light on anything you did differently to get it working? I pasted your code verbatim but I get zero errors. I also had a quick discussion with @samwgoldman with my own test case (pasted below) that I just tried on an empty folder which he could also get to display the correct errors whereas I still get 0. (I'm testing with 0.18.1 but just in case I tried the last few versions as well and couldn't get anything)
My own simple case:
/* @flow */

import React from 'react';

type P = {
	prop1: string;
	prop2: number;
};

class Test extends React.Component {
	static defaultProps: {};
	props: P;

	render() {
		return

			{this.props.prop1 * this.props.prop2} // get expected error for incompatible types

;
	}
}

class ParentTest extends React.Component {
	render() {
		return <Test prop1={1} />; // hoping to get error for wrong type and missing prop
	}
}

@frankychung @samwgoldman I'm also using 0.18.1 and do not get any flow warnings/errors with the example code.
However after a bit of experimentation I was able to get the correct flow error if I extend ReactComponent instead of React.Component
ie
class Label extends ReactComponent { ... }

While this type checks correctly it does not run in the browser as ReactComponent is a declaration and not a real class

@frankychung @cloudkite Isn't this bizarre?  I just tested Franky's piece: create a new directory, do flow init in that directory, create file test.js (has to have extension .js) and paste the code into that file, and finally run flow. It gives me 3 errors, as expected (1 error in line 16 and 2 in line 23).
My Flow version is also 0.18.1 (more specifically, revision d3f6f17e07cff4afef9b48eb0b21f3557ff3cdce). I did a clean make after the pull, could this be the reason?
I really have no idea... When I wrote the comment 2 months ago I believe what made the difference was to switch from React.Component to ReactComponent. But right now both versions work fine for me, so it could have been just a coincidence.
Sorry I can't be of much help here...

Great, using ReactComponent gives me the expected errors! @pasha-mf: Thanks for checking! I tried building from latest master but no errors as well. As @cloudkite mentioned, using ReactComponent doesn't work in the browser. Could you share how you were able to switch to it?

@frankychung @samwgoldman did a bit more digging and managed to get it working if I explicitly cast
class Label extends (React.Component : typeof ReactComponent) { ... }

Which seemed strange since given
https://github.com/facebook/flow/blob/master/lib/react.js#L177
This got me thinking that maybe flow isn't picking up the builtin declaration of react properly.
so I changed my .flowconfig to
[ignore]
.*/node_modules/react/.*

Which now works :+1: :fireworks:
I thought declarations took preference over node_modules?

Ah, glad you figured out the solution (adding an ignore where a declaration exists). This issue is tracked in #676.

@cloudkite Thanks for looking into it! That solved my problem too. Even in my simple test cases I had installed react into my node_modules which explains why some of us were seeing different things. :+1:

My favorite thing about types is that they reduce cognitive load for developers. Runtime reflection is really nice for developers because the objects can literally explain themselves to you.
But another great thing about runtime type reflection is that you can build tools into the application itself that help developers extend the application. The code is data that is used by the app as data at runtime.
See existing systems like Unreal Engine in-game blueprint editing for an example, and read my Sitepoint article, The Future of Programming.
PropTypes provides a pretty nice interface that would allow those features to be developed. As it is today, Flow doesn't. Of course, we may be able to fix that with the future development of the JS Reflect API, but that's a long way off.
These are the reasons we're working on rtype & rfx.
I'd be happy to support flow-style annotations in rfx if anybody else is interested in using it.
rfx already supports PropTypes style predicate functions, so it could be a viable solution for React users in a very short time with a little TLC.

@frankychung thanks for sharing that snippet above. I hadn't realized you could declare props and state properties on your React.Components to get type checking. This is fantastic!

How do ReactElement and ReactComponent get on scope for type_aliases.js in the tests?
type _ReactElement<D,P,S,C:ReactComponent<D,P,S>> = ReactElement<D,P,S>;
type $jsx<C> = _ReactElement<*,*,*,C>;

@ericelliott In terms of design space, both PropTypes (by virtue of being development only checks) and Flow types have very intentionally left type annotations out of the semantic space due to what leaving it out buys us. They're not just lacking semantic runtime meaning as a missing feature but as an intentional added feature. Unlike say, Angular with their use of annotations for dependency injection purposes.
It would make your case better if you explain why you don't need the features you get from leaving runtime semantics out (e.g. perf and ability to freely iterate on the inferred type system without risking runtime bugs). Rather than explaining why having them would buy you new features. Those are kind of obvious. The trade-off is less obvious.

both PropTypes (by virtue of being development only checks) and Flow types have very intentionally left type annotations out of the semantic space

Isn't this true only in the production compile? AFAIK, Flow provides no runtime analysis or reflection at all, whereas, PropTypes do in development.
I agree that it's great to be able to turn off type checking in production mode, but I maintain that the ability to opt into runtime reflection and type checking is an important feature, and I wouldn't want to see that feature abandoned.

Note that we've had many requests to strip out PropTypes from production code since they add significant start up time and file weight for no little use since type checks are disabled. That might be something React could/would do.

Note that we've had many requests to strip out PropTypes from production code since they add significant start up time and file weight for no little use since type checks are disabled. That might be something React could/would do.

Absolutely agreed on that point, but couldn't that also be done with a compiler option?

The way I see it, type checking and React are two different things, each with their own sets of concerns. Is type checking useful for React components? Absolutely -- as it is for every other kind of code.
Should React marry itself to any particular kind of type checking? Probably not. Not all React users want to be Flow users. Some React users may prefer TypeScript, or rtype, or JSDoc + closure compiler.
Maybe PropTypes is just one of many available options. Right now it has baked in support. Maybe if you decide you want to move away from that, there should be documentation about how to roll your own support for it. Perhaps the existing support could be extracted as a separate module that's easy for the community to use, or not use, as they like.
I'm all for type systems with compiler support to strip them out, or include them for runtime capabilities, at the option of the user.

Re: stripping PropTypes in production, there's babel-plugin-transform-react-remove-prop-types.
As for using Flow annotations as runtime information (and vice-versa), I've built json-to-flow to handle converting JSON schemata into Flow types, and @seanhess's runtime-types handles converting Flow types back into JSON.
You can't currently round-trim them due to output differences but if there is demand I'll bring them in line.

Go
On Fri, Feb 12, 2016 at 1:05 PM Samuel Reed<EMAIL_ADDRESS>wrote:

Re: stripping PropTypes in production, there's
babel-plugin-transform-react-remove-prop-types
https://github.com/oliviertassinari/babel-plugin-transform-react-remove-prop-types
.
As for using Flow annotations as runtime information (and vice-versa),
I've built json-to-flow https://github.com/STRML/json-to-flow to handle
converting JSON schemata into Flow types, and @seanhess
https://github.com/seanhess's runtime-types
https://github.com/seanhess/runtime-types handles converting Flow types
back into JSON.
You can't currently round-trim them due to output differences but if there
is demand I'll bring them in line.
—
Reply to this email directly or view it on GitHub
https://github.com/facebook/flow/issues/277#issuecomment-183488060.

I wonder if something like traits would solve this. https://github.com/facebook/flow/issues/2135

@STRML there's also this for runtime flow checking: https://github.com/gcanti/babel-plugin-tcomb

Awesome link @jedwards1211!

I still have some errors with flow. I'm currently using functional-component and type checking does not effect prop uses. In the component, i get error but when i try to use my component and pass wrong types, it doesn't give me any error. How can i fix it?

I still have some errors with flow. I'm currently using functional-component and type checking does not effect prop uses. In the component, i get error but when i try to use my component and pass wrong types, it doesn't give me any error. How can i fix it?

Make a new issue with a reproduction of your issue on https://flow.org/try/


Instagram API changes

Is it planned to keep this project up to date with the announced changes (deprecated functions starting in July 2018, see https://www.instagram.com/developer/) to the Instagram API?

Instagram-php-scraper does not use Endpoint (https://www.instagram.com/developer/) and Graph API. So "up to date" for this library means, it will works untill next change in undocumented web API. So no one know, when and how changes will come.


command line script should exit non-zero for problems

The script must call process.exit(1); with some number between 1 and 255 to enable script and continuous integration systems to understand that problems were found. It currently exits 0 (meaning "success") even when problems are detected.
https://en.wikipedia.org/wiki/Exit_status

+1

https://github.com/yaniswang/HTMLHint/blob/master/bin/htmlhint#L123
It's allready done.

:cake:

Hello @yaniswang -
This code no longer works with node version: v0.12.2. process.stdout.flush().
This line: if ((!process.stdout.flush || !process.stdout.flush()) && (parseFloat(process.versions.node) < 0.5)) { is always true but the drain event is never emitted. process.stdout.flush() is undefined.
The process exits with a zero exit code regardless of failures.


chore: add mobile menu close, rename navLinks

I made the mobile nav menu close when a link was selected for issue #26. The fix was simple by creating a function that sets the state that can be passed down to the child component (main-nav -> mobile-nav). By creating a new prop it made sense to make the items more descriptive to what they really are.
This still leaves the issue of not being able to apply a close animation. The tailwindcss-animate requires a transition component to handle this as shown in their issues. I would do this easily with headlessUI, but it seems like shadcn would prefer to stick with radix. The Radix documentation suggests useTransistion from 'react-spring'. If we're going to do that, then we should probably just use Radix's Navigation Menu primitive.
Let me know which direction you want to go.
This is my first ever pull request and I didn't know if I should name the commit chore or feat. Hopefully you can give me some feedback to improve future pull requests.

@mikecebul Thanks for the PR. This is looking good. Man I wish my first PR was as good as this :)
I tried to deploy this but seeing a type error.
Type error: Type '{ items: NavItem[]; }' is not assignable to type 'IntrinsicAttributes & MainNavProps'.

Does this build for you locally?

I updated the naming convention in docs and dashboard to remove the errors. I now realize this is more of an opinionated change and I probably should of just left the naming convention alone.
I can't do a full build because it fails with
Error: Failed to collect page data for /dashboard/settings

I'm guessing because I don't have the env variables.

I was digging into the RadixUI docs last night. I'm pretty sure I can get the Navigation Menu Primitive implemented in here too.. That will be the next think I'll work on.

I found it impossible to pass a function to the docs navigation with the component passed as {children}. I decided to make the docs mobile navigation component a conditional in the Main Nav based on the path segment using useSelectedLayoutSegment(). Here's the code section.
{showMobileMenu && (
        <MobileNav items={items} handleShowMobileMenu={handleShowMobileMenu}>
          {segment === "docs" ? (
            <DocsSidebarNav
              items={docsConfig.sidebarNav}
              handleShowMobileMenu={handleShowMobileMenu}
            />
          ) : (
            children
          )}
        </MobileNav>
      )}

Also I revert the naming convention change of the props "Items" (I changed my mind).
This seems to allow 'close on click' with the least change in the code and without useContext or other providers.


[usb_testutils] Queue of larger buffers required

Description
usb_testutils needs to be capable of returning multiple data packets (each of up to 64 bytes) from Endpoint Zero, eg. the configuration descriptor needs to be 252 bytes or thereabouts, in order to describe a single interface with all endpoints deployed.
It would seem sensible to have a single mechanism implementing the specification/queueing of buffers larger than 64 bytes within usb_testutils, such that it can then be employed by both the control point software (usb_testutils_controlep.c) and the other types of endpoint.
usb_testutils may then increase the performance of IN traffic for larger transfers by completing and supplying the next data packet immediately, rather than having to replicate this functionality in all 'tx_done' callback handlers.

estimate 8
remaining 2023-03-23 0

#17436 addresses this, supporting larger configuration descriptors as well as providing higher IN performance for larger data transfers by employing double-buffering. A modified implementation of usb_testutils is able to present a new packet buffer that has already been filled, reducing the inter-packet gap.

@alees24 happy for this to be closed?

Sure. There's still a little perfective tidying that I'd like to see in the handling of the control endpoint, but that's a lesser concern.


Description in YAML is incorrectly escaped

Project links currently don't link to anything.

The cause of this is that submitted descriptions with , and ' symbols are not correctly escaped:
name: caster.link
description: Web-based live streaming for mobile devices. Compatible with Chrome and Firefox. Site/streaming may be down, we're trying to get our server fixed.
url: http://caster.link
github_url: https://github.com/jawerty/caster.link
authors:
  - Bogdan Vitoc
  - Jared Wright
  - Evan Klein

Ah, gotcha.
Would putting the values in quotes fix this?
--
Zach Latta
http://zachlatta.com
https://github.com/zachlatta
https://twitter.com/zachlatta
On Tue, Jan 27, 2015, at 07:06 PM, Max Wofford wrote:

The cause of this is that submitted descriptions with , and ' symbols are not correctly escaped:

name: caster.link description: Web-based live streaming for mobile devices. Compatible with Chrome and Firefox. Site/streaming may be down, we're trying to get our server fixed. url: http://caster.link github_url: https://github.com/jawerty/caster.link authors: - Bogdan Vitoc - Jared Wright - Evan Klein
—
Reply to this email directly or view it on GitHub[https://github.com/hackedu/shipped/issues/54#issuecomment-71773652].

Probably. Is there a way to move this issue to hackedu/shipit ?

if you could close this and create an issue in hackedu/shipit
referencing this, that'd be best
--
Zach Latta
http://zachlatta.com
https://github.com/zachlatta
https://twitter.com/zachlatta
On Wed, Jan 28, 2015, at 03:09 PM, Max Wofford wrote:

Probably. Is there a way to move this issue to hackedu/shipit ?

—
Reply to this email directly or view it on GitHub[https://github.com/hackedu/shipped/issues/54#issuecomment-71936441].

Can someone else confirm this? I tested in chromium, but most links worked in firefox.

Closing this until it is replicated.


[KBM] Fix shortcut remap scenarios that should/should not open start menu

Summary of the Pull Request
What is this about?
PR Checklist

[x] Applies to #7165
[x] CLA signed. If not, go over here and sign the CLA
[x] Tests added/passed
[ ] Requires documentation to be updated
[ ] I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

Info on Pull Request
What does this include?
Tests

TODO: Add tests for new logic
TODO: Add tests for dummy key usage

Validation Steps Performed
How does someone test & validate?

/azp run


Update manage-vnet-security-roles.md

Removed the "and Power BI dataflows" part of the phrase from the "Connection roles" section, because Power BI dataflows are not supported for VNET GWs as mentioned in the Limitations section on this doc https://learn.microsoft.com/en-us/data-integration/vnet/overview#limitations

#sign-off


Yahoo mail shows "unsupported browser"

Bug description:
I use Ferdi Version 5.5.1-nightly.16 (5.5.1-nightly.16.2298). And have configured yahoo mail on it as a service. With the latest nightly of Ferdi, yahoo reports an "unsupported browser" and goes back to the old mail (old ui). Whatever was changed (maybe user-agent?) - please revert back.
Steps to reproduce:

Add a service to ferdi for yahoo mail.
login into your yahoo account
See the old ui - and in the browser address bar, it will report "unsupported browser"

Expected behavior
Correct (modern?) ui is shown when using yahoo mail via Ferdi.
Screenshots

Environment:

Operating System: macOS Catalina 10.15.5

Ferdi Version: Version 5.5.1-nightly.16 (5.5.1-nightly.16.2298)

Server: Franz

Debug information:

Can we get a new nightly that will fix this issue please?

Its been almost 2 months since a fix was committed - but, there hasn't been a release of either a nightly or a stable release. Can we please get a new nightly at least?


confidence intervals in KM survival analysis

Is there any way to calculate CI for the S(t) given a specific t in KM fitter？

Hi @Siji-chl, there is:
kmf.confidence_interval_.loc[t]

Is this what you are looking for?

Thanks a lot @CamDavidsonPilon ! kmf.confidence_interval_ returns a dataframe that contains CIs at many time points, but it is possible that the CI at a specific time that I want is not in the dataframe. What should I do in this situation?

I see. You'll have to do some Pandas queries:
t = 10.5
kmf.confidence_interval_.iloc[kmf.confidence_interval_.index.get_loc(t, 'pad')]

Thank you @CamDavidsonPilon very much! This solved my problem. 🙏


Performace Problems On i5 6 GB Notebook

Hello,
I have a I5 and 6GB Linux system that runs Atom with php-debug. While I am debuging executing one line code gets 1 seconds. So, I'm pressing "step over" and waiting 1 seconds.
Max Children : 16
Max Depth : 3
Those values are less than the default values, but still I have performance issues.

I have just imagined that, delay is is not 1 seconds. It is allways more than 2 seconds.

I have just imagined that, delay is is not 1 seconds. It is allways more than 2 seconds.

Are you still imagining this performance issue?
If your not just imagining but experiencing, could be due to a poor connection to the server. Where is the server location? Remote or local (virtualized or localhost)?

Hah, My poor English :) I didn't imagined it I have experienced it.
I have gave up using Atom, because the most important point is debugging for me, and it is not possible to debug with Atom.
Answeer : I was trying to debugging in a local computer, it was not remote.
Thank you!


fix|compiler warnings

They were back...
They wanted revenge...
They lost...

Compiler warnings are out again ;)

Lol! Nice short poem. Not sure if your coding or artistic skills impress me more 🤔


Integer printed as float

While looking at fixed-widths branch for #24, I noticed that integer values seemed to get marked as float instead of int as intended. Since it's a simple fix, I didn't think it needed a full PR, but I can make one if you'd like.
diff --git a/anybadge.py b/anybadge.py
index 5cc9f04..5dd00b3 100755
--- a/anybadge.py
+++ b/anybadge.py
@@ -307,12 +307,11 @@ class Badge(object):

         Returns: type
         """
+        if self.value_is_int:
+            return int
         if self.value_is_float:
             return float
-        elif self.value_is_int:
-            return int
-        else:
-            return str
+        return str

     @property
     def label_width(self):

Test:
python ./anybadge.py -l "test" -v "1234" -f ./test.svg -o

Before:

After fix:

@ahogen Thanks for raising this issue, and the detail included.  I added a unit test to ensure that the value_is_int and value_is_float functions are working, but actually the value_is_float function returns True for an integer string, which is technically wrong (or at least wrong for the purposes that we want to use the function for).  I opted for updating the value_is_float function instead so that it returns False unless the value should be presented as a float on the badge value.

I only recently learned how many string-like things look like a float to Python. Among the values listed here, I found these rather interesting....
Command to parse                        Is it a float?  Comment
--------------------------------------  --------------- ------------
print(isfloat("NaN"))                   True            nan is also float
print(isfloat("6e777777"))              True            This is same as Inf
print(isfloat("-iNF"))                  True
print(isfloat("infinity"))              True
print(isfloat(True))                    True            Boolean is a float

I haven't tried, but I don't think any of these things will create any weird badge output currently. But it was something I thought about briefly when I found this issue.
Cheers :slightly_smiling_face:


Pass context to custom_head.html and custom_footer.html

I wanted to add
{{ with .OutputFormats.Get "rss" -}}
  {{ printf `<link rel=%q type=%q href=%q title=%q>` .Rel .MediaType.Type .Permalink site.Title | safeHTML }}
{{ end }}

To custom_head as documented here, but it wasn't working as the context wasn't passed to custom_head.

Good point. BTW, could you help to add such context parameter to custom_footer?
The code is https://github.com/tomowang/hugo-theme-tailwind/blob/main/layouts/partials/extended_footer.html#L28
And adjust the PR to add context to both, which will make the feature align.

Done!


HoverFly vs WireMock

I'm evaluating whether to use HoverFly or WireMock for testing mobile applications in a large corporation. To do so I've written a comparison of the two.  If anyone is able to provide critical feedback on it (particularly if they are contributors to HoverFly), that would be appreciated. We will need to make a decision in the next few weeks.

@Osipion Thanks for the writeup, I'll have a chance to read through properly tomorrow. One thing I noticed whilst skimming over, is that it doesn't mention Hoverfly as a reverse proxy. You can set it to webserver mode which will do this, meaning you don't have to worry about proxy configuration.

Hey @Osipion,
That is a very nice review of different techniques for stubbing, mocking and service virtualization.
The only issue I can see with it regarding the Hoverfly parts is what @mogronalol pointed out, Hoverfly can act as a reverse proxy and be used in either use case B or C.

Hi @Osipion, I can think of a few advantages of Hoverfly compared to Wiremock as well:

Hoverfly can be run as a standalone binary and provide a handy CLI tool hoverctl, while Wiremock requires JRE to run on.
Can be used as forward or reverse proxy as mentioned by @mogronalol
Hoverfly provides several native language bindings including Java, python and .net
Hoverfly-java provides JUnit rule to switch transparently between simulate or capture mode without leaving the IDE. Wiremock would require different configs for capture or simulate.

Thanks for the quick feedback - much appreciated. @mogronalol & @benjih I'd managed to miss the start webserver command when I was experimenting - got it confused with 'simulate' mode, and found that I still needed to treat HoverFly as a forward proxy. This is very interesting to know, and makes HoverFly a more plausible choice. I'll have a play with it. @tommysitu these are interesting points - having both a REST API, non-JVM client libraries as well as a *ctl tool certainly seems to offer enhanced opportunities for automation. I'll update the piece and see if I can persuade any of the WireMock guys to give their view on it.
Other thing I noticed is that the json schema for simulation files isn't actually a JSON schema . I'll be doing much of my testing before some apis exist, so having a really robust JSON schema to reference when creating response files (without recording them) would be great.
I actually heard of both HoverFly and WireMock at TestWorks last year - remember @benjih from the workshop. Was a good talk, and thanks again for the help.

I guess the other thing I missed for WireMock would be the stateful behaviour it offers for simulations. Without needing to write complex middleware, can this be achieved with HoverFly?

Not currently, it is on the roadmap though.
On 20 Feb 2017 7:38 pm, "Osipion"<EMAIL_ADDRESS>wrote:

I guess the other thing I missed for WireMock would be the stateful
behaviour http://wiremock.org/docs/stateful-behaviour/ it offers for
simulations. Without needing to write complex middleware, can this be
achieved with HoverFly?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/SpectoLabs/hoverfly/issues/417#issuecomment-281165211,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABRVrS9tTxHDpPKSEaEepFiQEcLFlCp9ks5reeuZgaJpZM4MFg-8
.

Hi, there may be a simple answer to this that Tommy left off his list of
unique Hoverfly advantages: middleware! Anything is possible in Hoverfly
middleware!
The longer and more truthful answer is that whilst we aren't sure of the
best solution we are also more importantly unsure what problems we're
hoping to fix. What legitimate tests cannot easily be produced with
stateful behaviour? We lack good use-cases to progress.
Coming up with potential solutions is easier. Tom Akehurst has developed a
technique that appeals to CS grads. A similar product I helped develop for
a major corporate detected where identical requests resulted in different
responses in capture and simply reproduced the order in playback. That
worked, but it seemed so simplistic is has left me with the suspicion that
we don't really understood the problem.
What this might suggest is that if we look at the needs of unit,
integration and end-to-end tests there may be a need for more than one
solution. One simply default scheme when in capture and another in the DSL
that applies to mocking use-cases.
That brings me to another point. In comparing Hoverfly to other open-source
tools we sometimes only look at the problems those tools address. Its a
sort of selection bias akin to how commercial vendors compare their tools
based on contrived tick lists. I don't think it is fully appreciated yet
that Hoverfly has potential across most of the test lifecycle. Our
particular focus is how to give a high degree of confidence to a developer
in the shortest time. To fit with CD we say it should be 5 minutes.
Traditionally the open source tools have addressed unit testing (mocks and
stubs). They haven't addressed issues of integration testing (multiple
services in combination), end-to-end testing (co-ordination of test data
across the end-to-end flow) and high-volume performance testing (we think
Hoverfly will scale to thousands of TPS and it won't be difficult to setup)
quite as much. Ultimately we don't think its helps to give developers
feedback in 5 minutes but then expect projects to take business risks
because integration, end-to-end and performance tests haven't been run.
This touchs on the larger problems we think SPECTO addresses.
Just returning to middleware. I think a middleware solution is likely to be
clumsy or may be inadequate in other ways. For instance, we had a very
large US bank that wanted to use Hoverfly for performance testing of a
mobile app, and most importantly they want to measure the effect of latency
on the user experience. They started with middleware and found their
solution didn't scale so we added delays to Hoverfly.
I hope this helps.
John Davenport
Director of Strategy
SpectoLabs
Phone: 07450 747132
Twitter: @tropnevadj / @spectolabs
http://specto.io/
On Mon, Feb 20, 2017 at 9:47 PM, Benji Hooper<EMAIL_ADDRESS>wrote:

Not currently, it is on the roadmap though.
On 20 Feb 2017 7:38 pm, "Osipion"<EMAIL_ADDRESS>wrote:

I guess the other thing I missed for WireMock would be the stateful
behaviour http://wiremock.org/docs/stateful-behaviour/ it offers for
simulations. Without needing to write complex middleware, can this be
achieved with HoverFly?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<https://github.com/SpectoLabs/hoverfly/issues/
417#issuecomment-281165211>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/
ABRVrS9tTxHDpPKSEaEepFiQEcLFlCp9ks5reeuZgaJpZM4MFg-8>

.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/SpectoLabs/hoverfly/issues/417#issuecomment-281189469,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACRHfPKEJTnc8TaGnlIZ2dxcHAMuKea4ks5regoLgaJpZM4MFg-8
.

--
SpectoLabs Ltd.
Registered office: Europoint House, Lavington Street, London SE1 0NZ, UK
Company No: 09984238
This email and any attachments to it may be confidential and are intended
solely for the use of the individual to whom it is addressed. Any views or
opinions expressed are solely those of the author and do not necessarily
represent those of Specto Labs Ltd. If you are not the intended recipient
of this email, you must neither take any action based upon its contents,
nor copy or show it to anyone. Please contact the sender if you believe you
have received this email in error.

@JohnFDavenport great detail, and clarifies why SpectoLabs felt the distinction between mocking and service virtualization was an important one to stress. It's precisely because we are looking to expand automated testing into integration and end-to-end testing scenarios that I'm looking beyond simple fakes like Canned and MockTail to more flexible and scalable solutions. Definitely helps.

Thanks for your valuable article @Osipion I am going to close this issue now. Feel free to reopen if you want to continue the discussion or reach out in any other way you see fit (email, twitter, gitter, etc). Please raise anything, such as stateful services, that is missing from Hoverfly as a separate issue.


Error: stern reached the maximum number of log requests (50)

Hi!
I have deployment with 30 pods and 3 containers.
When i try to read logs i get this error:
stern deployment/api --color auto --namespace default --since 1s
➜  ~ stern deployment/api --color auto --namespacedefault --since 1s
...
CUT: <list of pods and container>
...
Error: stern reached the maximum number of log requests (50), use --max-log-requests to increase the limit

how can i pass this parameter?

Hi @HattabbI4, I have just released a new version (v0.3.4) which includes a new preference to set the --max-log-requests parameter.
You can see below a screeenshot of the new preference:


Invalid tech-preview kiali image tag

The Kiali image tag in the examples and docs for tech-preview are incorrect and include an extra "v":
https://github.com/Maistra/openshift-ansible/blob/maistra-0.3/istio/cr-kiali.yaml#L10
https://docs.openshift.com/container-platform/3.11/servicemesh-install/servicemesh-install.html#creating-custom-resource
The default version is stated as 'v0.7.2' which is correct for community images but incorrect for tech-preview images. The tags in the Red Hat registry is '0.7.2', while in docker hub 'v0.7.2':
https://access.redhat.com/containers/?tab=tags#/registry.access.redhat.com/openshift-istio-tech-preview/kiali
https://hub.docker.com/r/kiali/kiali/tags/

@siamaksade The prefix and version in that example are for the community images so should now be kiali/ and v0.8.1, I'll update it.

The version has now been updated to match the community version used in maistra 0.3.0

Super. The docs also needs an update:
https://docs.openshift.com/container-platform/3.11/servicemesh-install/servicemesh-install.html#creating-custom-resource

The PR to make that change was submitted a few days ago, we're still waiting for it to be merged.


: luisKey Missing LUIS key

Describe the bug

Version

Browser

[ ] Electron distribution
[ ] Chrome
[ ] Safari
[ ] Firefox
[ ] Edge

OS

[ ] macOS
[ ] Windows
[ ] Ubuntu

To Reproduce
Steps to reproduce the behavior:

Go to '...'
Click on '....'
Scroll down to '....'
See error

Expected behavior

Screenshots

Additional context

@shanbhuds
What recognizer are you using? I've hit this issue when I've switched between recognizer types and just a quick re-selection will often fix it.

Closing due to lack of response.


Use miniforge, update pins

Comes from https://github.com/conda-forge/miniforge/issues/602#issuecomment-2248188930
We were mixing Mambaforge and Miniforge, and they should be equivalent.
Also updated the version comments for some GHA hash pins.

This PR needs to be on an upstream branch, but we can likely merge as is.


helm secrets requires tiller?

# helm plugin list
NAME   	VERSION 	DESCRIPTION
diff   	2.11.0+2	Preview helm upgrade changes as a diff
secrets	2.0.0   	This plugin provides secrets values encryption for Helm charts secure storing

helm secrets fails for me with:
Error: Get http://localhost:8080/api/v1/namespaces/kube-system/pods?labelSelector=app%3Dhelm%2Cname%3Dtiller: dial tcp <IP_ADDRESS>:8080: connect: connection refused
I do not have tiller connection - but why is it needed for secrets?

you can install the tillerless helm plugin as an alternative
https://github.com/rimusz/helm-tiller

  stage('Decrypt secrets') {
      when {
        anyOf {
          branch 'PR-*'
          branch 'master'
        }
      }
      steps {
        container('nodejs') {
          sh "npm install -g @alexlafroscia/yaml-merge"
          sh "pip install aws"
          sh "mkdir -p ~/.helm/plugins"
          sh "mkdir -p ~/.aws"
          sh "helm plugin install https://github.com/rimusz/helm-tiller"
          sh "helm plugin install https://github.com/futuresimple/helm-secrets"
          withCredentials([
            string(credentialsId: 'helm-secrets-aws-profile', variable: 'AWS_PROFILE'),
            file(credentialsId: 'helm-secrets-aws-config', variable: 'AWS_CONFIG'),
            file(credentialsId: 'helm-secrets-aws-credentials', variable: 'AWS_CREDENTIALS')
          ]) {
            sh "cp $AWS_CONFIG ~/.aws/config"
            sh "cp $AWS_CREDENTIALS ~/.aws/credentials"
            dir('./charts/gainbridge-server') {
              sh "helm tiller start-ci"
              withEnv([
                "HELM_HOST=<IP_ADDRESS>:44134"
              ]) {
                sh "helm secrets dec secrets.yaml"
                sh "helm tiller stop"
              }
            }
          }
        }
      }
    }


How to use it in other bigger Projects?

I include linssh2 and this pri  in my project,but i don't know how to set up.How can i launch a sftp connnect and upload files?Any example?

Hello,
My lib was not very up to date..
I push a cmake change, and an example to use sftp to send a file:
https://github.com/condo4/QtSshExample
This example works well with Qt6 / cmake and libssh2 provide by the system.
It should also work with Qt5 / CMake, and probably also with QMake and the .pri, but CMake is more recommended now with Qt.
Tell me if you need more information, clearly, I have to write the documentation..


Fixes crash on orientation change in DashboardActivity.

Fixes TAVERNA-1022

@m-murad
Thanks for the fix

@sagar15795
happy to help.


Help the user bring the right things 2

Following weather conditions, I've added all types of weather to always help the user bring the right things with him.
This is the solution for issue #20

Resolve the conflicts to merge

@Deadreyo
I've revert the commit then applied the changes again. I hope it works now