UI Enhancement and handle NaN values in Statistics Calculator

Display an alert to enter some numbers when clicked on Calculate without entering any number in Statistics Calculator!!
Also, enhance the UI of this calculator.

I can work on this issue, please assign it to me under SWOC.

Proceed @yashi-15


Ensure we properly close HASS instances.

Add a small test check to ensure that HASS instances are getting properly closed at the end of a test.
We test against < 2 because hass.stop() cannot wait till the coroutine is done.

Idea is that we can start adding more checks to this. For example that the recorder has been cleaned up properly.


Adds test that we don't actually expand mount files until an app is run

This is correct and it's the current behavior, but in order to do some larger refactors of mounts in a safe way we should add this test to ensure we don't regress.
What would be bad is if mounts are loaded at module import time, since they can potentially inspect a large amount of files in the file system which can take a significant amount of time, making imports themselves slow.
Describe your changes

Provide Linear issue reference (e.g. MOD-1234) if available.

Backward/forward compatibility checks
Check these boxes or delete any item (or this section) if not relevant for this PR.

[ ] Client+Server: this change is compatible with old servers
[ ] Client forward compatibility: this change ensures client can accept data intended for later versions of itself

Note on protobuf: protobuf message changes in one place may have impact to
multiple entities (client, server, worker, database). See points above.
Changelog

@prbot approve


Error when i import TypesenseInstantSearchAdapter

Description

i had install npm
npm install algoliasearch@3 angular-instantsearch@beta instantsearch.js@3 instantsearch.css
npm install --save-dev @types/algoliasearch
and add module NgAisModule
Steps to reproduce

Expected Behavior

Actual Behavior

Metadata
Typsense Version:

@hoanam2k2 That's just a warning that says Typescript types are not available for this library. It's safe to ignore.
Typescript types are being added as part of #36.


Proposal for restructure to support CI tests, pyspec, and better test generation flow.

Proposal to have clean CI integration, with testing, test-generation, and pythonized-spec.
It would look a little bit like a mono-repo, but well-structured, and enabling us to:

write pytests for CI info during PR, mostly sanity tests, based on pythonized spec.
have generators use the pythonized spec easily (ramp up amount of yaml tests)
easily write generators (thanks to base generator from PR 31)
make yaml test repo builds directly hooked to spec releases, as it should when they are based on the spec. (i.e. BLS/SSZ/state-transition generators can all use existing spec/util code, and do not duplicate it to a generators repo)
Clean up current CI. It is great to have, but I hate seeing a requirements.txt in the root of a project that is meant to be a specification. Separating into directories and preserving the specs directory to be markdown-only feels like the best I can do to both support "specification", and strong CI + tests generation.

├── LICENSE
├── Makefile   <--- see description below.
├── README.md
├── scripts
│   ├── requirements.txt
│   └── phase0
│       ├── build_spec.py
│       ├── function_puller.py
│       └── __init__.py
├── specs
│   ├── bls_signature.md
│   ├── core
│   │   ├── 0_beacon-chain.md
│   │   └── 1_shard-data-chains.md
│   ├── light_client
│   │   ├── merkle_proofs.md
│   │   └── sync_protocol.md
│   ├── simple-serialize.md
│   ├── test-format.md
│   └── validator
│       └── 0_beacon-chain-validator.md
├── test_generators
│   ├── bls
│   ├── ... more ...
│   ├── shuffling
│   └── ssz
├── test_libs
│   ├── gen_helpers
│   │   ├── gen_base <-- package that generators use as base (test gen PR 31)
│   │   │   └── ....
│   │   ├── README.md
│   │   ├── requirements.txt
│   │   └── setup.py
│   └── pyspec
│       ├── requirements.txt
│       ├── README.md
│       ├── setup.py <--- defines the pyspec module. To local-require in generators
│       ├── phase0 <--- package, generated using spec builder script, by makefile
│       ├── phase1,2,etc. <--- later phase packages
│       └── utils <--- shared between phase packages.
│           ├── __init__.py
│           └── phase0 <--- utilities for phase 0,
│                           we may want to generalize utils between phases as well.
├── py_tests  <--- existing py-tests, but not confused with yaml tests
│   ├── requirements.txt
│   ├── README.md
│   └── phase0
│       ├── __init__.py
│       ├── block_processing
│       │   ├── test_process_block_header.py
│       │   ├── test_process_deposit.py
│       │   ├── test_process_proposer_slashing.py
│       │   └── test_voluntary_exit.py
│       ├── conftest.py
│       ├── helpers.py
│       └── test_sanity.py
└── yaml_tests <---- NOT included in git, build output from test generators.
    │                 Output by CI to eth2.0-tests repo.
    ├── bls
    ├── ... more ...
    ├── shuffling
    └── ssz

Makefile:

defines a target for ./test_libs/pyspec/phase0/. The ./scripts/phase0/build_spec.py should be called.
defines a target for ./test_libs/pyspec/. This calls all pyspec targets.
defines yaml_test make targets, i.e. test-gen runners. Use new makefile code from test-gen PR 31. This automatically creates targets for each generator. These targets should have ./test_libs/pyspec/ as dependency.
defines a test target to build and run py_tests. This target should define ./test_libs/pyspec/ as dependency.

My gut is that this is cleaner and going to provide a simpler experience writing and testing the spec. The more repos we have with inter-dependencies, the more complex doing any one of these tasks is going to be.
The separate test generator repo made more sense when we did not yet have an executable spec and were pulling in dependencies from various repos. At this point the executable spec as the entire spec functionality, the shuffling alg, and a minimal ssz/hash-tree-root. We can also use the internal fork choice function with a test_case to BeaconBlock converter to generate fork choice tests. The only external dependency required for testing at this point is bls.
I am in favor of this. Curious to hear the thoughts of some of the other people that have been working on testing. cc: @jannikluhn @ChihChengLiang @mratsim @paulhauner

One downside is the test generator related issues and PRs are coming to this repo too, not sure how these affect the spec contributors. Otherwise, with the executable spec, the restructure looks beautiful.

I'm a bit hesitant on this. It would tie releases of test generators to releases of the spec even though we'll probably want to have them independent (hopefully more frequent test releases than spec releases in the future). Right now we build the tests on every release of the generators (which I quite like, it's simple, quick, and transparent), so we would need to find another way for this, in the worst case clicking some button hidden in the CircleCI UI.
I don't really see an advantage of the proposed approach compared to putting the state test generators in the generators repo. We can configure CI in such a way that it pulls the latest spec release whenever building the tests. Then generator could use any spec code they like as well and we're sure that newly generated tests are always up to date.

I don't really see an advantage of the proposed approach compared to putting the state test generators in the generators repo.

That main benefit is to have the py-tests live alongside the spec to be able to run CI testing on the spec when writing and updating. If the test generators live in a separate repo, then it is much more complex to get the py-tests we are using on the spec to be cleanly integrated into the generators.  The more we separate the two, the more complex the link, dependencies, and general dev flow has to be, or the py-tests just remain independent of test generation and we have to duplicate testing work to test these common flows.
Attaching a t0 to spec releases (v0.5.0-t0) and incrementing the t appendage upon testing updates (with no substantive spec updates) is one way we can hang onto the same release build option.

One downside is the test generator related issues and PRs are coming to this repo too, not sure how these affect the spec contributors.

We could have testing related issues live in eth2.0-tests to keep a clean separation.

We're going to move forward with this proposal

I'll start implementing this proposal tomorrow, can't wait to see the spec function as a direct base for test suites

closed via #851


Employer profiles

This would allow us to have:

Company specific templates
Company descriptions
Save a filled-out job description as a template

Would require user login/user profiles. This goes towards making PostingPro fit into the workflow better. If we work on this, each item above should be separate stories.

@skcain and I were thinking that we'd either do employer profiles OR #118, #116, and #115.


Add a Gitter chat badge to README.md

PowerShell/PSScriptAnalyzer now has a Chat Room on Gitter
@kapilmb has just created a chat room. You can visit it here: https://gitter.im/PowerShell/PSScriptAnalyzer.
This pull-request adds this badge to your README.md:

If my aim is a little off, please let me know.
Happy chatting.
PS: Click here if you would prefer not to receive automatic pull-requests from Gitter in future.

This change is

Hi @gitter-badger, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. Real humans will now evaluate your PR.

TTYL, MSBOT;


fix centraldashboard params

These parameters are out of date. See: https://github.com/kubeflow/kubeflow/pull/6339

cc @shannonbradshaw

@kimwnasptd can I get a very quick tech review?

Closing in favour of https://github.com/kubeflow/website/pull/3023


Owner selectors sometimes display full name, other times username

The Edit Dashboard and Edit Chart modals display the user's full name when selecting an owner from the dropdown, but display the username when simply displaying the existing owners.
The cause of this is that the /dashboard/related/owners api endpoint returns full name, while the /dashboard/:id endpoint returns only the username, so the modal is just using the information that it has available. Both endpoints return the user id, so this doesn't lead to real bugs, just visual confusion. I think the best solution would be for the endpoints to return more information, but I'm unsure how to accomplish that within FAB. Open to other suggestions as well.
Pinging @dpgaspar for FAB expertise.
Expected results
Should use the owner's name
Actual results
Mixed results
Screenshots
If applicable, add screenshots to help explain your problem.
How to reproduce the bug

Go to a chart or a dashboard
Click on "edit properties" to open the edit modal
Set some owners
Reload the modal, owners are now displayed by username instead of name

Checklist
Make sure these boxes are checked before submitting your issue - thank you!

[x] I have checked the superset logs for python stacktraces and included it here as text if there are any.
[x] I have reproduced the issue with at least the latest released version of superset.
[x] I have checked the issue tracker for the same issue and I haven't found one similar.

@suddjian These are the fields for the /dashboard/:id endpoint https://github.com/apache/incubator-superset/blob/master/superset/views/dashboard/api.py#L144
This is the /related/:col_name endpoint https://github.com/apache/incubator-superset/blob/master/superset/views/base_api.py#L132

Seems like the related endpoint is just using str(col) which is configured in FAB, I believe.

@nytai The related will use whatever you configure on the model magic method __repr__(self). On this case, Model USer is on FAB

This was fixed a while ago


XMonad.Prompt.Pass: Missing generic search feature

Problem Description
This is more a feature request than a problem.
Current problem: when opening the prompt in XMonad.Prompt.Pass, one must type the very first characters of an existing first level folder in $HOME/.password-store to show/match entries.
Pass utility has the find argument that can search based on a keyword and match any folder or any GPG file that contains the keyword, which is much more easier to find a password entry.
Steps to Reproduce
Assuming you have this $HOME/.password-store example entries:
$HOME/.password-store/www/github/email.gpg
$HOME/.password-store/www/github/password.gpg
$HOME/.password-store/other/mybestwebsite/password.gpg
Using XMonad.Prompt.Pass:

Type the keybinding to show up the Xmonad pass prompt
Type a keyword for example password
It will not find anything, except if you type www or other

Using pass:

Type pass find password, then ENTER
It will find below entries:
-> $HOME/.password-store/www/github/password.gpg
-> $HOME/.password-store/other/mybestwebsite/password.gpg
And without knowing the first full path folders.

That is a much better behavior and expected to have the same when using XMonad.Prompt.Pass
Checklist

[x] I've read CONTRIBUTING.md

I tested my configuration

[x] With xmonad version 0.17.0-20
[x] With xmonad-contrib version 0.17.0-20

What you're probably looking for is X.P.FuzzyMatch

Only if you can integrate it with pass(1) somehow. I suspect that's what the find subcommand to it does.

fuzzyMatch is indeed very close to what pass find does, except that it matches others too:

Example: "spr" matches FastSPR but also SuccinctParallelTrees because it's a subsequence of the latter: "S.......P.r..........".

Because of fuzzySort good relevance sorting (e.g., making "spr" matches first), I am adopting fuzzyMatch as a good solution.

Besides, that should be included by default for Prompt.pass, or highly recommended in the Prompt.pass documentation.

You're probably right; I can't imagine people wanting to type out the whole path to their password every time.  We should probably document this default though, in case users do want that.  Fancy opening a PR?

You mean pull request by changing $usage in Pass.hs to add a note about that?

I mean changing mkPassPrompt to automatically apply the fuzzy matcher and sorter, as well as document this in the module so that users who do not wish to use these features (or use other search predicates and sorters) know to turn them off.
(This would of course break backwards compatibility, but I think it's a worthwhile trade off to having yet another mkPassPrompt')

I am afraid that is out of my skills :disappointed:

No worries, I'll (try to, time permitting) prepare something tomorrow then


Xit Cypress XSS Test in CI that makes it unresponsive

Description
xited the test spec that was opening an XSS dialog box resulting in the cypress window becoming unresponsive and causing the CI to fail. This should hopefully fix things up!
Affirmation

[x] My code follows the CONTRIBUTING.md guidelines

Aaaand everything passes yay!


[Bug] Error When Disabling Schema Registry or Event Cache

Describe the bug
MongoDB Connection Live When Schema Registry or Event Cache Disabled
Expected behavior
If Schema Registry or Event Cache Disabled, then no connection should be made to MondoDB
To Reproduce
Turn off MongoDB.
Disable Schema Registry or Event Cache
An exception occurs about the db connection timing out
Make My Life Easier
If possible, create a pull request that contains a failing unit test to reproduce the bug.
Screenshots
If applicable, add screenshots to help explain your problem.
Additional context
Add any other context about the problem here.
Additional resources
Please refer to the Contributing Guidelines.

Used SimplePubSub sample project to reproduce the error condition and validate fix.

Update Program in Publisher project to disable schema registry.

services.AddDaprEventBus(eventBusOptions.PubSubName, options =>
    options.UseSchemaRegistry = false);

Update Startup in Subscriber project to disable event cache.

services.AddMongoEventCache(null, options =>
    options.EnableEventCache = false);

This new version worked for me!


Release v0.2.2

Build:

Bump packages

Codecov Report

Merging #4 (c339666) into main (1ffcc02) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main       #4   +/-   ##
=======================================
  Coverage   89.02%   89.02%
=======================================
  Files           6        6
  Lines          82       82
  Branches        6        6
=======================================
  Hits           73       73
  Misses          9        9

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ffcc02...c339666. Read the comment docs.


Main feature: database

We need a database module to store things persistently, such as thread state.
Things that need storing:

Thread metadata (originating message, thread ID, user )
Thread message data (who wrote, was internal, highest role, message content, reactions? Attachments? )
Config data (should just be a string/string KVS for now because that's how db config works)

These things should be server-keyed so in the future we can support multiserver if we want.

From ARU:
stuff needed in the database for threads:
Ticket
id, created at, who created it (eg a member, or themselves),

Messages:
author
server_message_id
dm_message_id
attachments
embeds
contents

All of thread messages, and attachments links and stuff too, including a ticket and author (user) object

user table: all users who've interacted with modmail
id, default avatar number, name, dm channel id

So, schema:
Ticket:

id (INTERNAL)
server_id
thread_id
creator_id (user ID)
user_id (target user ID)

Messages:

id (from discord, dm id)
ticket_id
mirrored_id (in server message id)
author_id
content
internal

Attachments:

internal id
message id
link

Embeds:

internal id
message id
json content as a bytes field

Emoji: (Later feature)

id
url
animated

emoji_messages:

emoji_id
message_id

Configuration:

config key name
config value


Updated Assignment 3 with my answers

What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)
I updated Assignment 3 with my answers
What did you learn from the changes you have made?
I learned how to apply the K-means clustering algorithm to a dataset and how to visualize the resulting clusters. Additionally, I gained insights into bootstrapping techniques for estimating population parameters and constructing confidence intervals.
Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?
no
Were there any challenges? If so, what issue(s) did you face? How did you overcome it?
no
How were these changes tested?
I tested the changes by running the entire script and verifying that the clustering results were correctly visualized and that the bootstrapping method produced the expected mean and confidence intervals. I ensured that all functions executed without errors and that the outputs made sense contextually.
A reference to a related issue in your repository (if applicable)
Checklist

[x] I can confirm that my changes are working as intended

A3 complete


[DO NOT MERGE] Updated document for host endpoint policy on forward traffic.

Description
Document for host endpoint policy on forward traffic.

Another overall comment: our renderer has no problem if we break the lines at 70-80 characters, the text flows fine, so we have been breaking the lines around there for readability of the source markdown. So it might be nice if you could insert those breaks, as well.

Just noticed a few more minor items @song-jiang ... Thanks!

Looking good @song-jiang I just had one more comment...not sure if I mentioned this in my previous review...my bad if I omitted this feedback earlier. Overall, it's looking great! Thanks... 👍

LGTM thanks @song-jiang ! We need to hold off on merging this though...until after 2.6 gets released. cc @ozdanborne

Thanks @song-jiang - I'm happy with the changes for my last comments.  If you just address @emanic's last comments, I'll be happy to approve and merge this!

Hi @song-jiang  @neiljerram I only got partway through my review yesterday. However, we do not want to merge this until AFTER 2.6 gets released. That's because this feature will not be included in 2.6. Thanks!

Really starting to look pretty good @song-jiang !! thanks for all of your work on this! 💯

Related PRs for this feature.
https://github.com/projectcalico/calico/pull/1100
https://github.com/projectcalico/libcalico-go/pull/512
https://github.com/projectcalico/felix/pull/1542
https://github.com/projectcalico/calicoctl/pull/1705
https://github.com/projectcalico/typha/pull/47

All related PRs has been merged.


.macos - 'Tap to click' checked but not enabled in 10.12

System:

OS X 10.12.5
Macbook Pro (tb) 2016

Process:

Quit System Preferences
Run:

# Enable tap to click (Trackpad) for this user and for the login screen defaults write com.apple.driver.AppleBluetoothMultitouch.trackpad Clicking -bool true defaults -currentHost write NSGlobalDomain com.apple.mouse.tapBehavior -int 1 defaults write NSGlobalDomain com.apple.mouse.tapBehavior -int 1

Logout
Login
Tap to click not functioning
Check System Preferences - Tap to Click is enabled, but only actually works after un-checking and re-checking using System Preferences.

Is it just me? Or does this not work in 10.12 / Sierra?
For slightly less useful reference, it didn't work in High Sierra either.
If it's me - any tips would be appreciated!

I'm getting the same behaviour. Did you ever find a solution?

@luispedrofonseca No solution yet I'm afraid...

I had the same behaviour, but I fixed it by adding:
defaults write com.apple.AppleMultitouchTrackpad Clicking -bool true

@roadmanict Great - thanks! That worked for me (after a log out - log in cycle). Weirdly the checkbox in System Preferences was still unchecked even though it worked, but maybe a restart would sort that?? Still - it seems to work at least!

Ah - I just realised I'm testing this on a laptop, I'll have to try with an external trackpad later. I guess that's why both com.apple.AppleMultitouchTrackpad and com.apple.driver.AppleBluetoothMultitouch.trackpad need doing if you use both.

Thank you @roadmanict, that seems to do the trick for the current user! 👍
Unfortunately, it still won't work for the login screen. This feature seems to be removed completely I guess...

Running this on Mojave works for me:
defaults write com.apple.AppleMultitouchTrackpad Clicking -bool true
defaults write com.apple.driver.AppleBluetoothMultitouch.trackpad Clicking -bool true
defaults -currentHost write 'Apple Global Domain' com.apple.mouse.tapBehavior 1

that also works for me on mojave

actually it gets reverted upon restart

This did the trick for the current session and if I log off and log back in, it also works. But when I shut down my Macbook, it just loses the configuration. Am I missing something? Running version 10.14.5 here. Thanks!

defaults write com.apple.AppleMultitouchTrackpad Clicking -bool true
defaults write com.apple.driver.AppleBluetoothMultitouch.trackpad Clicking -bool true
defaults -currentHost write Apple Global Domain com.apple.mouse.tapBehavior 1
#
defaults write com.apple.driver.AppleBluetoothMultitouch.trackpad TrackpadThreeFingerDrag -bool true
defaults write com.apple.AppleMultitouchTrackpad TrackpadThreeFingerDrag -bool true
defaults write NSGlobalDomain com.apple.swipescrolldirection -bool true

this is working for me
10.14.5

This commands don't work for me on Catalina. Anyone knows how to solve it? Thank you!

Anyone found a solution to this for Big Sur and Monterey?

Combination of those lines seem to do the trick for me on Monterey 12.5, at least for the built-in trackpad in Macbook Air M1 2020:
defaults write com.apple.AppleMultitouchTrackpad Clicking -bool true
defaults write com.apple.driver.AppleBluetoothMultitouch.trackpad Clicking -bool true
defaults -currentHost write 'Apple Global Domain' com.apple.mouse.tapBehavior 1
defaults write NSGlobalDomain com.apple.mouse.tapBehavior -int 1


grafana_dashboard lib raises when processing dashboards exported by Grafana 9

Bug Description
Prior to grafana 9, the datasource key was a plain string, e.g. "datasource": "${prometheusds}".
In grafana 9, the datasource key is a dict:
          "datasource": {
            "type": "prometheus",
            "uid": "${prometheusds}"
          },

To Reproduce
Relate cos-config to grafana and
juju config cos-configuration-k8s \
  git_repo=https://github.com/canonical/cos-configuration-k8s-operator.git \
  git_branch=feature/reinit_grafana_after_startup \
  grafana_dashboards_path=tests/samples/grafana_dashboards

Environment
Model                         Controller  Cloud/Region        Version  SLA          Timestamp
test-grafana-dashboards-k30t  chdv2934    microk8s/localhost  2.9.34   unsupported  12:40:32-05:00

App                    Version  Status   Scale  Charm                  Channel  Rev  Address        Exposed  Message
cos-configuration-k8s           active       1  cos-configuration-k8s             0  <IP_ADDRESS>  no
grafana                9.2.1    waiting      1  grafana-k8s            edge      52  <IP_ADDRESS>  no       waiting for units to settle down

Relevant log output
File "/var/lib/juju/agents/unit-grafana-0/charm/lib/charms/grafana_k8s/v0/grafana_dashboard.py", line 1272, in _on_grafana_dashboard_relation_changed
    changes = self._render_dashboards_and_signal_changed(event.relation)
  File "/var/lib/juju/agents/unit-grafana-0/charm/lib/charms/grafana_k8s/v0/grafana_dashboard.py", line 1369, in _render_dashboards_and_signal_changed
    content = _convert_dashboard_fields(content, inject_dropdowns)
  File "/var/lib/juju/agents/unit-grafana-0/charm/lib/charms/grafana_k8s/v0/grafana_dashboard.py", line 599, in _convert_dashboard_fields
    dict_content = _replace_template_fields(dict_content, datasources, existing_templates)
  File "/var/lib/juju/agents/unit-grafana-0/charm/lib/charms/grafana_k8s/v0/grafana_dashboard.py", line 633, in _replace_template_fields
    if panel["datasource"].lower() in replacements.values():
AttributeError: 'dict' object has no attribute 'lower'

Additional context
No response

As an experiment, I re-exported two dashboards using grafana 8.2:

single panel, expr: up, without any varialbes
single panel, expr: up, with $prometheusds

This generated another error:
  File "./src/charm.py", line 356, in _on_upgrade_charm
    self.dashboard_consumer.update_dashboards()
  File "/var/lib/juju/agents/unit-graf-0/charm/lib/charms/grafana_k8s/v0/grafana_dashboard.py", line 1300, in update_dashboards
    self._render_dashboards_and_signal_changed(relation)
  File "/var/lib/juju/agents/unit-graf-0/charm/lib/charms/grafana_k8s/v0/grafana_dashboard.py", line 1369, in _render_dashboards_and_signal_changed
    content = _convert_dashboard_fields(content, inject_dropdowns)
  File "/var/lib/juju/agents/unit-graf-0/charm/lib/charms/grafana_k8s/v0/grafana_dashboard.py", line 599, in _convert_dashboard_fields
    dict_content = _replace_template_fields(dict_content, datasources, existing_templates)
  File "/var/lib/juju/agents/unit-graf-0/charm/lib/charms/grafana_k8s/v0/grafana_dashboard.py", line 638, in _replace_template_fields
    replacement = replacements.get(datasources[ds], "")
KeyError: 'juju_test-grafana-dashboards-k30t_83821afa-f7ad-447c-8c19-1a8b69109229_prom_0'


Make site responsive for mobile

Currently, on any touch devices, when you navigate to the editor it just shows a message saying that this site is optimized for desktop.

Hi @katherinepeterson, I would like to work on this issue. Is there a basic mobile responsive layout designed ? or can i suggest/submit design idea.

@Rishabh-Rathod feel free to submit an idea!

Hi @katherinepeterson I would love to work on this issue too! Ive got some basic mobile designs (from my other projects) which could apply to this project to (with some tweaking)

Hi @michaelnji,
Can you share your idea screenshots,
what i have thought was

Toggleable Side drawer for sections.
Horizontal Tabs for Editor and Previewer.

If your idea is similar we can divide tasks and contribute.

@katherinepeterson

Toggleable Side drawer for sections.
Horizontal Tabs for Editor and Previewer.

i have modified css to showcase below design idea, real implementation will have drawer icon and better UI.

Opening sections in side drawer -

Horizontal tabs for editor, preview and raw (same header as above)

@katherinepeterson
let me know your feedback on the idea and then i would proceed to implement it.

Disclaimer - i have modified css to showcase below design idea, real implementation will have drawer icon and better UI.

Opening sections in side drawer -

Horizontal tabs for editor, preview and raw (same header as above)

I think that looks pretty good. On screenshot 2 I might right align the Preview and Raw so they are visually separate from the Editor. (the editor only shows the currently selected section whereas the others show the whole readme. might be unclear.

On screenshot 2 I might right align the Preview and Raw so they are visually separate from the Editor. (the editor only shows the currently selected section whereas the others show the whole readme. might be unclear.

Got it. Will take care of that while coding it.

i am noting down changes to be done and also status of my development.

[x] Toggle Drawer containing sections.
[ ] Fix section item's drag and drop functionality for mobile.
[ ] Implement Tabs to show column selection. ( screenshot 2 for reference )

[ ] separation of header UI from EditorColumn and PreviewColumn component to reuse code for tabs.

[ ] limit maxWidth of PreviewColumn to avoid its overflow outside the viewport.

@Rishabh-Rathod thanks for working on this, it's been a highly requested feature!
I wanted to let you know if you didn't already that the monaco editor doesn't work on mobile, so you'll have to replace it with a normal text editor on mobile

@Rishabh-Rathod thanks for working on this, it's been a highly requested feature!
I wanted to let you know if you didn't already that the monaco editor doesn't work on mobile, so you'll have to replace it with a normal text editor on mobile

hey @katherinepeterson, thanks for reminding me, i totally forgot about that.
Also, i had a small query.
for making a common Navigation Bar for EditorColumn and PreviewColumn in mobile i will need to bring the state of those component to parent component.
for that I am creating another component to wrap EditorColumn and PreviewColumn where i maintain state.
This will lead to propDrilling from editor.js -> EditPreviewContainer.js -> ( EditorColumn.js / PreviewColumn.js )
Is 2 layer propDrilling fine ? or shall i maintain state in context to avoid propDrilling?

@Rishabh-Rathod im okay with the two level prop drilling here


Create pull_request_template.md

Signed-off-by: Daxin Wang<EMAIL_ADDRESS>

To be honest, I don't see much difference. What we want contributors to do is that link the PR with an issue. I have modified some words to express it more clearly.
## Related Issue
<!--- If suggesting a new feature or change, please discuss it in an issue first -->
<!--- If fixing a bug, there should be an issue describing it with details -->
<!--- Please link to the issue here: -->


Server 2022 Support

The list of Operating Systems does not include Server 2022. Is this a deliberate omission (indicating the extension does not work on Server 2022 VMs) ?
[Enter feedback here]

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 40aaccb8-19ba-168f-f5bf-65f1f5331541
Version Independent ID: 6cdfd166-633a-50a3-2b45-cde0e991e540
Content: Azure Custom Script Extension for Windows - Azure Virtual Machines
Content Source: articles/virtual-machines/extensions/custom-script-windows.md
Service: virtual-machines
Sub-service: extensions
GitHub Login: @amjads1
Microsoft Alias: amjads

@davelobban Thank you for your feedback . We will investigate and update the thread.

Hello @davelobban , yes correct, since windows server 2022 is not mentioned under the supported operating systems for custom script extension, that means it's not yet supported as of now.
Hi @amjads1 , could you please review this and add your comments.

Thanks for the update.
However it's very disappointing to hear that a key part of automating the set up of a new VM is not possible under the latest version of the flagship OS some six months after release. Is there an alternative method of running a Powershell script on a new Server 2022 VM that I have missed?

@davelobban , Let me check with the internal team and I shall update the thread once I hear back from them.

#reassign @MsGabsta Is there support for 2022 yet?

@cynthn no official support yet, this is currently work in progress.

#please-close Support is in progress. The article will be updated when support for 2022 is confirmed. In the meantime, I'm going to close out this issue. Thank you!


add mac command for creating salt hash

Adjusted code from issue #4

I find that I must set LC_ALL=C in order for this to work on my system; LC_CTYPE is neither necessary nor sufficient. Perhaps this varies with platform / OS version? Should we recommend setting both?

I'll be honest, the current example didn't work for me so I went searching the issues and found #4, this example worked. I only updated the length to be 75 as the current example uses. So i'm out of my element a bit. That being said though, LC_ALL=C works for me as well so I'm ok with changing that.

Looks good -- thanks.


Query: Fixes exceptions in query cancellation path and restore a setter

Pull Request Template
Description
This PR contains changes made internally to reduce exceptions that occur when a query is cancelled while prefetching.
Type of change
Please delete options that are not relevant.

[x] Bug fix (non-breaking change which fixes an issue)
[] New feature (non-breaking change which adds functionality)
[] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[] This change requires a documentation update

Closing issues
To automatically close an issue: closes #IssueNumber

ComparableTaskScheduler no longer exists in the code base, so this PR might no longer be relevant.

ComparableTaskScheduler no longer exists in the code base, so this PR might no longer be relevant.

Closing based on previous comments that the change is no longer relevant.


Ccache fallthrough with clang + -fcolor-diagnostics

Steps to reproduce:

Compile arrow_objlib with ccache, clang and CCACHE_DEBUG=1 CCACHE_LOGFILE=./ccache.log
Find in ./ccache.log:

Failed; falling back to running the real compiler
Result: unsupported compiler option

Dropping -fcolor-diagnostics fixes the issue.
I suggest either opting into color diagnostics with WITH_COLOR_DIAGNOSTICS or adding a way to disable it via DISABLE_COLOR_DIAGNOSTICS.
It would be good if this wouldn't be tied to ARROW_USE_CCACHE since its also relevant for:
-DARROW_USE_CCACHE=OFF -DCMAKE_CXX_COMPILER_LAUNCHER=emscripten_ccache.
I can open a PR if you tell me which way you prefer.

https://github.com/apache/arrow/blob/9814605c25ab0e8736bae9ccad89c334647da660/cpp/cmake_modules/SetupCxxFlags.cmake#L235


Arrow up in menus fix

This fix changes main menu binding to M, to get rid of the bug when any arrow up press in any menu opens the main menu or jumps to the latter's first position if it's already open. M is also the default button for user menu in GTA V Online, which is only convinient.

You can now config the controls in cfg/client.lua.

You do realise that this alone doesn't fix default up arrow behaviour?

Checking if the (main)menu is open is not so easy and can lead to bad behaviors, will probably be added in the future, but right now it's better to just use another key, if players don't change their own up key.


Apply rouge highlighting to inline code

I've updated the stylesheet to apply highlighting to inline code. Like block-level codeblocks, you must specify the syntax for inline code as well.
This is done in kramdown with an inline attribute list ("IAL"):
`example code here`{:.language-python}

With this IAL in place, inline code will now pick up any applicable syntax highlighting from the updated stylesheet.

Thanks @denzel-morris. Does this mean the previous formatting of ``````yaml...``` no longer work? If so can you update the existing codeblocks to this new styling format?

@mirons, all multiline codeblocks with the triple-quote language format work as expected and intended.
This only relates to single-quote inline code tags.
Just to confirm, it's the single-quote inline tags you would like for me to update to specify the language?

On Apr 24, 2018, at 11:07, mirons<EMAIL_ADDRESS>wrote:
Thanks @denzel-morris. Does this mean the previous formatting of ``````yaml...``` no longer work? If so can you update the existing codeblocks to this new styling format?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

Please, but let's do it in a follow-up PR. This works for now, thanks.


Recipients not syncing after secret expired

Hi, I'm running the latest master version v5.31. Recently our secrets have expired, and what we did is that we generated new ones, and update them in key vault. Currently I'm receiving below error when trying to send a test message using a CSV file:

Failed to prepare the message for sending:The orchestrator function 'SyncRecipientsOrchestrator' failed: "The activity function 'SyncCSVActivity' failed: "Specified argument was out of the range of valid values. (Parameter 'partitionCount') Actual value was .". See the function execution logs for additional details.". See the function execution logs for additional details.
So I would need help with resolving this, and checking if I did not miss any secret update anywhere in the configuration.

Hi @ostromecko, could you please share the function execution logs?
The Log Stream is a feature in Azure that allows you to view the live logging information directly in the Azure portal. Here’s how you can use it:

Navigate to your function app in the Azure portal.
Select the Monitoring section.
Click on Log Stream.

Once you’re in the Log Stream, you should start seeing logs as your functions execute. If you don’t see any logs, make sure your function app is running and executing functions.

Hi @luishdemetrio, which function from the three functions I should open and check if there are logs? Data-Function, Function or Prep-function?
And what you mean by "make sure your function app is running and executing functions."? Company communicator is an app which is used ad-hoc.

Hi @ostromecko, could you please share the function execution logs?
The Log Stream is a feature in Azure that allows you to view the live logging information directly in the Azure portal. Here’s how you can use it:

Navigate to your function app in the Azure portal.
Select the Monitoring section.
Click on Log Stream.

Once you’re in the Log Stream, you should start seeing logs as your functions execute. If you don’t see any logs, make sure your function app is running and executing functions.

@luishdemetrio I have opened Log stream, but it's constantly loading and not showing anything. Can you please support on this?

@cristianoag could you help me with this issue?

Currently I'm facing this issue:
Failed to prepare the message for sending:The orchestrator function 'SyncRecipientsOrchestrator' failed: "The activity function 'SyncCSVActivity' failed: "Specified argument was out of the range of valid values. (Parameter 'partitionCount') Actual value was .". See the function execution logs for additional details.". See the function execution logs for additional details.

Are you using a standard CSV file as input? Can you post it so I can check the format?
Get Outlook for iOShttps://aka.ms/o0ukef

From: ostromecko @.>
Sent: Friday, March 22, 2024 10:21:24 AM
To: cristianoag/microsoft-teams-apps-company-communicator @.>
Cc: Cristiano Goncalves @.>; Mention @.>
Subject: Re: [cristianoag/microsoft-teams-apps-company-communicator] Recipients not syncing after secret expired (Issue #76)
Currently I'm facing this issue:
Failed to prepare the message for sending:The orchestrator function 'SyncRecipientsOrchestrator' failed: "The activity function 'SyncCSVActivity' failed: "Specified argument was out of the range of valid values. (Parameter 'partitionCount') Actual value was .". See the function execution logs for additional details.". See the function execution logs for additional details.
—
Reply to this email directly, view it on GitHubhttps://github.com/cristianoag/microsoft-teams-apps-company-communicator/issues/76#issuecomment-2015088972, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ALSAPKVY4IRC2UKCLUZSWN3YZQV5JAVCNFSM6AAAAABDIIG4FGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMJVGA4DQOJXGI.
You are receiving this because you were mentioned.Message ID: @.***>

of course. I'm attaching file which I'm using.
companycomm.csv

I have checked all three functions and app service. All four instances are pointing to the same commit ID 9d9ce88.

Do you have email addresses different than upns?
Get Outlook for iOShttps://aka.ms/o0ukef

From: ostromecko @.>
Sent: Friday, March 22, 2024 12:10:11 PM
To: cristianoag/microsoft-teams-apps-company-communicator @.>
Cc: Cristiano Goncalves @.>; Mention @.>
Subject: Re: [cristianoag/microsoft-teams-apps-company-communicator] Recipients not syncing after secret expired (Issue #76)
I have checked all three functions and app service. All four instances are pointing to the same commit ID 9d9ce88https://github.com/cristianoag/microsoft-teams-apps-company-communicator/commit/9d9ce881db2fcd5a01b407e90d438b6b25010b80.
—
Reply to this email directly, view it on GitHubhttps://github.com/cristianoag/microsoft-teams-apps-company-communicator/issues/76#issuecomment-2015308572, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ALSAPKVHVCN3I4UVZURZ5ZDYZRCVHAVCNFSM6AAAAABDIIG4FGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMJVGMYDQNJXGI.
You are receiving this because you were mentioned.Message ID: @.***>

No. I was even testing this with a file which was containing only two email address (mine, and my colleague) and still it was not working

Email address or UPN? Very important, the file needs to have upns, not emails.
Get Outlook for iOShttps://aka.ms/o0ukef

From: ostromecko @.>
Sent: Friday, March 22, 2024 12:22:53 PM
To: cristianoag/microsoft-teams-apps-company-communicator @.>
Cc: Cristiano Goncalves @.>; Mention @.>
Subject: Re: [cristianoag/microsoft-teams-apps-company-communicator] Recipients not syncing after secret expired (Issue #76)
No. I was even testing this with a file which was containing only two email address (mine, and my colleague) and still it was not working
—
Reply to this email directly, view it on GitHubhttps://github.com/cristianoag/microsoft-teams-apps-company-communicator/issues/76#issuecomment-2015334039, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ALSAPKUBSP2HJKLGUFVARW3YZREE3AVCNFSM6AAAAABDIIG4FGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMJVGMZTIMBTHE.
You are receiving this because you were mentioned.Message ID: @.***>

UPN matches e-mail address in our case.

Collect and upload the function log files. So we can check what is going on. Need more detailed error mess
Get Outlook for iOShttps://aka.ms/o0ukef

From: ostromecko @.>
Sent: Friday, March 22, 2024 12:32:54 PM
To: cristianoag/microsoft-teams-apps-company-communicator @.>
Cc: Cristiano Goncalves @.>; Mention @.>
Subject: Re: [cristianoag/microsoft-teams-apps-company-communicator] Recipients not syncing after secret expired (Issue #76)
UPN matches e-mail address in our case.
—
Reply to this email directly, view it on GitHubhttps://github.com/cristianoag/microsoft-teams-apps-company-communicator/issues/76#issuecomment-2015352231, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ALSAPKUAOYGS2QNWZBIRZ43YZRFKNAVCNFSM6AAAAABDIIG4FGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMJVGM2TEMRTGE.
You are receiving this because you were mentioned.Message ID: @.***>

Unfortunatly the log stream for me is constantly loading, and it doesn't provide any logs

Or I can collect them in different way?

@cristianoag Im facing the same problem, all my secrets has expired, you have any script to do the secrets update to the keyvault?
or can you tell me what to do exacly to update?, im using versing 5.31

The problem is this, when I try to select the users to send the message, Im reciving this messagem:

"Permissions required. Ask your IT administrator to enable this option for you"
Im assuming this message is becouse of the expired secredts that don allow access to groups/users of m365


Utilize provisioned concurrency

The pricing doesn't look great, but it should at least be an option.

@tj do you have ETA on this?

I remember looking into it but I forget what the result was now, I think it was more expensive, but it would be nice to have it as an option either way. No ETA at the moment, I'm going to try and get the HTTP API stuff in next

Apologies if this is a noob question but I couldn't find an answer elsewhere. Is provisioned concurrency and Apex Up warm starts essentially achieving the same thing? And would there be a price comparison?


Add RemoteProperty to Comm

Add a RemoteProperty to Comm, for both the server and client.
Possible API:
Server:

RemoteProperty.new(defaultValue: any)
rp:SetAll(value: any)
rp:Get(player: Player?): any
rp:Set(player: Player, value: any)
rp:Clear(player: Player)
rp:ClearAll()

Client:

ClientRemoteProperty.new()
rp:Get(): any
rp.Changed: Signal<any>

It would be nice if, for tables, rather than just sending the entire table over the network, it instead detects table changes and sends that instead. Just a thought!


Memory reads at high freq causing server lag

Should look into a way to lessen this, or limit the default max freq to a safer number than 2.1MHz.
Right now, I've tested a few different devices for the speed that they can reach before I start to lag, using the code
//MOV R0,1024 // for internal ram test
CPUGET R0,43 //for external ram test
x:
MOV ESI,R0
MOV EDI,R0
INC R1
MCOPY 8192 // MCOPY is limited to 8192 bytes, so use multiple to copy more than 8192
// the "Bytes" measurement was obtained by summing the operand of all of the MCOPY instructions in the CPU code
// for the test, when it was determined to reduce my FPS to between 60 and 90 FPS while the CPU freq was set to 2100000
JMP x

Address bus: 5120 bytes
128kb ram gate: 12288 bytes
CPU's own internal ram 122880 bytes
Lag being defined as dropping my FPS by more than 30 in singleplayer, these numbers are me trying to get as close to 60fps from 120fps
Initial suggestion was to check how many external accesses we've had this tick and raise the "external mem access" cycle penalty by a very small amount each time, to put a "soft cap" on the number of external accesses that can be made per VM , but since it turns out the internal ram can also run into this issue, this may need another solution.
See here for how the readcell function applies the "memory access" penalty to TMR, and here for how the CPU handles the TMR variable during execution.

Seems like E2 actually faces a similar issue, I think it might be more akin to just... device read/write being too slow.
4 unlimited ops E2's at 346830 BPS on an address bus drops my FPS as much as

1 CPU at max freq copying 5120 bytes per run at 337920BPS on an address bus.


[iOS] specify minimum os version for native asset frameworks

Fixes https://github.com/flutter/flutter/issues/148501
Pre-launch Checklist

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] I read the Tree Hygiene wiki page, which explains my responsibilities.
[x] I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
[x] I signed the CLA.
[x] I listed at least one issue that this PR fixes in the description above.
[x] I updated/added relevant documentation (doc comments with ///).
[x] I added new tests to check the change I am making, or this PR is test-exempt.
[x] I followed the breaking change policy and added Data Driven Fixes where supported.
[ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@dcharkes is the plist file tested anywhere? Also the approach here is a bit ugly, the issue is that the plist key is different for macOS and iOS, and also as far as I can tell it is not mandatory.

Do we have the minimum iOS version that the app we're building is targeting somewhere? See the code that does the same for minimum android version: https://github.com/flutter/flutter/issues/148044#issuecomment-2102326283

@dcharkes is the plist file tested anywhere?

No. You could add it here:
https://github.com/flutter/flutter/blob/6b383615c655fe4e58643992a46df31b1f91da52/packages/flutter_tools/test/integration.shard/isolated/native_assets_test.dart#L314-L348

Do we have the minimum iOS version that the app we're building is targeting somewhere? See the code that does the same for minimum android version: #148044 (comment)

I think this is right now hardcoded to 12.0 for App.framework inside AppFrameworkInfo.plist. There is also IPHONEOS_DEPLOYMENT_TARGET set by xcode during build that contains project deployment target. But I think the plugin should be able to specify own deployment target, that seems like the cleanest way.

What is the interplay between XCode and a Flutter app on the minimal iOS version?

The target version is the minimum support by latest Xcode.  https://flutter.dev/go/match-xcode-deployment-range

This document proposes that Flutter’s supported deployment platform versions be updated when Xcode is released annually to match its deployment versions.  Versions lower than the Xcode range will become unsupported.

Right now it's set in the tool in a bunch of places, see https://github.com/flutter/flutter/pull/140823 for the last time we had to bump it (note the changes in dev and example weren't manually updated, those are automatically migrated example/test apps).
@vashworth filed https://github.com/flutter/flutter/issues/145104 to make this settable in fewer places.

Thanks @jmagman!
Then I'm fine landing as is once we added a test. And maybe leave a comment on https://github.com/flutter/flutter/issues/145104 so that it doesn't get forgotten.

@dcharkes, I added test and a TODO to wire things once hook can specify deployment target. There is another issue - the bundle identifier must not contain underscores, we should replace them by - probably. Should that be part of this PR or should I make separate PR for it?

Escaping the bundle identifier seems like a tiny change, I added it to this PR.


Save V8 compiled script

Research the V8 APIs for saving already compiled scripts to files. This will increase performance drastically for subsequent application loads.

Research: (used stored precompiled script data)
-The best reached result is  2-3% improvement when we load about 3 - 3.2 mb of javascript libraries.
-This does not include the check if javascript code is library or user code which has to be done.
-for smaller applications this caching is slowing down loading time
Conclusion:
With the current public APIs that V8 provides for caching and precompiling scripts, it would be better to leave implementation with a simple compilation of script every time.


CONTRIBUTING.md: Clarify template string usage

Based on discussion in the Development room

I may have to write more template string code so people have a better idea of what I mean :/

I wouldn't make it a blanket thing like this.

I wouldn't make it a blanket thing like this.

Most things in CONTRIBUTING.md are kind of a blanket; it's supposed to be a guide when contributing.

Then don't put it in there. The thing about multiline strings is fine, but "serious string processing like ternary operators" is both wrong and vague

Then don't put it in there. The thing about multiline strings is fine, but "serious string processing like ternary operators" is both wrong and vague
Do you suggest a better way of phrasing it?


How to use variable outside the macro

Hey there,
I was just wondering, whether there was a way to declare a static ref based on a variable outside the macro. More specifically, something along the lines of
let sample = "something";

lazy_static! {
    pub static ref: MyStruct = MyStruct::new(sample);
}

Thanks in advance!

I just ran into this problem as well. I would like to do the following:
fn initialize(options: Options, window: Window) {
    lazy_static! {
        static ref STATE: State = State::new(options, window);
    }

    ...
}

However I get this error:
error[E0434]: can't capture dynamic environment in a fn item
    --> src\bin\sidebar\main.rs:1386:46
     |
1386 |         static ref STATE: State = State::new(options, window);
     |                                              ^^^^^^^
     |
     = help: use the `|| { ... }` closure form instead

There are some complex reasons for why I need to use lazy_static (I can't just use a state local variable).

I tried to implement this, and as far as I can tell it's currently impossible, due to static restrictions in Rust.

I wouldn't say this is static restrictions -- you will first need to figure out what stops someone from writing code like the following. After you conceptually understand what the behavior should be in such cases, it will be clearer how to proceed in implementing that behavior.
#[macro_use]
extern crate lazy_static;

fn initialize(options: Options, window: Window) -> &'static impl Deref<Target = State> {
    lazy_static! {
        static ref STATE: State = State::new(options, window);
    }

    &STATE
}

fn main() {
    let state = initialize(...);

    // Dereference STATE for the very first time, lazily initializing
    // it. But oops, by now `options` and `window` have been destroyed
    // so this is a use-after-free.
    println!("{:?}", **state);
}

@dtolnay That particular issue isn't a problem, since the implementation would use a move closure to capture the outer variables.
The real issue is that it's not possible to put closures into static (which is why I said that the current static restrictions prevent this).

It's possible but unstable:
#![feature(existential_type, untagged_unions)]

#[macro_use]
extern crate lazy_static;

#[derive(Debug)]
struct Options(i32);
#[derive(Debug)]
struct Window(i32);
#[derive(Debug)]
struct State(Options, Window);

impl State {
    fn new(options: Options, window: Window) -> Self {
        State(options, window)
    }
}

existential type Init: FnOnce() -> State;

fn initialize(options: Options, window: Window) {
    #[allow(unions_with_drop_fields)]
    union BrieflyUninit {
        uninit: (),
        value: Init,
    }

    static mut INIT: BrieflyUninit = BrieflyUninit { uninit: () };
    let init = move || -> Init { move || State::new(options, window) };
    unsafe {
        INIT.value = init();
    }

    lazy_static! {
        static ref STATE: State = unsafe { std::ptr::read(&INIT.value)() };
    }

    println!("{:?}", *STATE);
}

fn main() {
    initialize(Options(1), Window(2));
}


bug: Unauthorized user can click on 3 dots in question

An unauthorized user can see and click on the 3-dot action menu in a question that they did not post. The delete option appears in the menu, but only the buttons for these actions are being handled in the backend, not the display of the options themselves.
To Reproduce
Steps to reproduce the behavior:

Log in as a user who did not post the question.
Navigate to a question posted by someone else.
Click on the 3 dots next to the question.
Observe that the "option" is visible even though the user is not authorized to delete the question.

Expected behavior
The delete option (or any other unauthorized actions) should not be visible to users who are not the owner of the question.
Additional context
The issue is related to frontend handling of the visibility of options in the 3-dot menu. Although we handle the backend actions for these options correctly, unauthorized users can still see the option, which creates confusion.

I am not able to reproduce the error, for me only authenticated user can only delete.

Read description 🤦🏻♂


Module not found: Error: Can't resolve 'clsx'

I think the new version does not work, you could check it, I also tried to manually apply the changes regarding the problem of not being able to click on the sides of the modal but it is not a valid solution either, it did not change nothing, the solution I initially offered could be applied to the component Dialog and also fix it

Thanks for the report, I will fix it 🚀.

🎉 Fixed in v0.2.2.

✅ Module not found: Error: Can't resolve 'clsx' when building to production:

Using Next.js 13 + /pages:
> next build

info  - Linting and checking validity of types
info  - Creating an optimized production build
info  - Compiled successfully
info  - Collecting page data
info  - Generating static pages (3/3)
info  - Finalizing page optimization

Route (pages)                              Size     First Load JS
┌ ○ /                                      20.4 kB        93.5 kB
├   └ css/77e878d72d98d937.css             1.86 kB
├   /_app                                  0 B            73.1 kB
├ ○ /404                                   181 B          73.3 kB
└ λ /api/hello                             0 B            73.1 kB
+ First Load JS shared by all              75.9 kB
  ├ chunks/framework-2c79e2a64abdb08b.js   45.2 kB
  ├ chunks/main-f11614d8aa7ee555.js        26.8 kB
  ├ chunks/pages/_app-2cd5058a061812ad.js  307 B
  ├ chunks/webpack-8fa1640cc84ba8fe.js     750 B
  └ css/41d6bc5ddf0de1e4.css               2.77 kB

λ  (Server)  server-side renders at runtime (uses getInitialProps or getServerSideProps)
○  (Static)  automatically rendered as static HTML (uses no initial props)

✅ Fixed the problem of closing the CommandPalette by clicking on the sides - Check.

Thanks for the report 🚀🚀


[Bug]: Reset Currency doesn't work

Is there an existing issue for this?

[X] I have searched the existing issues

Current Behavior
Currency fields are not reset.
Steps To Reproduce

I try also this:
export default {
	ada: () => {
		AddRevenueAmount.run(
			() => showAlert('Amount has been committed'),
			() => showAlert('An error was detected'));
		resetWidget('RevenueForm', true);
	}
}

It doesn't work. After more Tests with Currency/Number Fields my feeling is
that there are more Problems.
Environment
Deploy Preview
Version
Self-Hosted

related to #8506

@inaxium it seems to work for me. What is the value of the default text of the input you are setting?
Can you share the exact steps to reproduce this?

The problem was, in fact, that there was no Default Text (Currency) => 0.
You should include it in the doc for numeric fields
a default must be given.

@inaxium can you try with a new input widget? We used to have this issue in older widgets

How can I achieve this. I use your Docker Image on my Local Notebook.
It should be the newest one. Isn't it?
Am Do., 2. Dez. 2021 um 05:34 Uhr schrieb Nikhil Nandagopal <
@.***>:

@inaxium https://github.com/inaxium can you try with a new input
widget? We used to have this issue in older widgets
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/appsmithorg/appsmith/issues/9417#issuecomment-984308455,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AMHXEMLVLAREFTSJ2LSJHNDUO4AOXANCNFSM5I5SKKRQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

@inaxium if you are running with docker-compose it should auto update. If not, you need to simply run a docker pull command. Post that, deleting and re-adding the input widget should solve this


Update documentation.tsx

Typo that is reflected in the title of all doc pages

haha, well that's an easy merge!


Add repair action macro

For the Repair basic action, add action implementation to the system and expose it on the pf2e namespace of the game object, add an action macro to call that system implementation, and also add a link to execute the action implementation from the action item description.

Rebase to kick on CI


publishtools flatten does not work correctly

Error : because threefold shortname is used in a wiki and a site, so this check can not be accurate please change
V panic: should not load on same name 2x: 'threefold'

@despiegk please confirm https://github.com/crystaluniverse/crystallib/commit/41719960037e6912dc72289bbfb9d6b50bbb5d16#diff-ac92a68cea9286f6832e2f4665275a5283366f9ffc525566640768b5e64aa060L33

@despiegk reverted back


[SPARK-32908][SQL] Fix target error calculation in percentile_approx()

What changes were proposed in this pull request?

Change the target error calculation according to the paper Space-Efficient Online Computation of Quantile Summaries. It says that the error e = max(gi, deltai)/2 (see the page 59). Also this has clear explanation ε-approximate quantiles.
Added a test to check different accuracies.
Added an input CSV file percentile_approx-input.csv.bz2 to the resource folder sql/catalyst/src/main/resources for the test.

Why are the changes needed?
To fix incorrect percentile calculation, see an example in SPARK-32908.
Does this PR introduce any user-facing change?
Yes
How was this patch tested?

By running existing tests in QuantileSummariesSuite and in ApproximatePercentileQuerySuite.
Added new test SPARK-32908: maximum target error in percentile_approx to ApproximatePercentileQuerySuite.

Test build #128818 has started for PR 29784 at commit 690db25.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/33441/
Test PASSed.

Test build #128826 has started for PR 29784 at commit 47091a9.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/33449/
Test PASSed.

The changes can be merged to branch-3.0 without any conflicts but this PR has conflicts in 2.4. Here is the PR for branch-2.4: https://github.com/apache/spark/pull/29786

Hm! yes looks like a good fix according to the paper. I'm surprised it manifests as a bug like that.

Test build #128818 has finished for PR 29784 at commit 690db25.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/128818/
Test FAILed.

Test build #128826 has finished for PR 29784 at commit 47091a9.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/128826/
Test PASSed.

Merged to master and branch-3.0.


Spreading object types produces odd resultant types

type Foo = { +foo: 'foo' }
type Bar = { +bar: 'bar' }
type FooBar = { ...Foo, ...Bar }

declare var foobar: FooBar;
(foobar.foo: string); // No error expected, got one anyways
foobar.bar = 'bar'; // Expected error, none produced

The type-at-pos for the foobar variable is (Try Flow):
{bar?: mixed | 'bar', foo?: mixed | 'foo'}

So not only did spreading the objects cause the properties to lose their variance, but it also changed the types of those properties to become nullable unions with mixed. However, if I change both Foo and Bar to be exact object types, then flow gets the correct types of the properties, but still loses their variance:
type Foo = {| +foo: 'foo' |}
type Bar = {| +bar: 'bar' |}
type FooBar = { ...Foo, ...Bar }

declare var foobar: FooBar;
(foobar.foo: string); // No error
foobar.bar = 'bar'; // Expected error, none produced

The type-at-pos for the foobar variable is (Try Flow):
{bar: 'bar', foo: 'foo'}

I think the first problem is expected: type spread is supposed to model object spread behavior. If the type is not exact then flow cannot guarantee that spreading Bar won't overwrite properties from Foo. Hence, any property that's defined in Foo but not in Bar will get the type mixed | <type in Foo>.

I don't understand why foobar.bar = 'bar'; // Expected error, none produced should produce an error if the Bar type clearly states that the bar property should be assigned only the value 'bar'. Sure you didn't mean foobar.foo = 'bar' should produce an error?

Bar.bar is covariant, so it can't be assigned to. The covariance property is apparently dropped when spreading.

If the type is not exact then flow cannot guarantee that spreading Bar won't overwrite properties from Foo

@TiddoLangerak we're talking about spreading the types here, not spreading an actual javascript object which would satisfy the types. While the type { foo: 'foo } can be satisfied by javascript objects which contain more properties than just foo, the type itself doesn't. So spreading { ...Foo, ...Bar } should produce the type {foo: 'foo', bar: 'bar'}. That type can be satisfied by javascript objects which contain properties other than foo or bar.
It also doesn't even make sense as an argument because spreading actual javascript objects actually produces the type I was expecting while spreading the object types:
const foo = { foo: ('foo': 'foo') }
const bar = { bar: ('bar': 'bar') }
const foobar = { ...foo, ...bar }

The type-at-pos for the foobar constant is (Try Flow)
{bar: 'bar', foo: 'foo'}

See explanation here: https://github.com/facebook/flow/issues/3534#issuecomment-287580240

@vkurchatkin so then to produce the object type I actually want (sans variance) I should do something like this?
export type Foo = { foo: 'foo' }
export type Bar = { bar: 'bar' }
/*::
declare var foo: Foo
declare var bar: Bar
const DesiredType = { ...foo, ...bar }
*/
export type FooBar = typeof DesiredType

No, you can just do this:
type FooBar = { ...$Exact<Foo>, ...$Exact<Bar> }

@vkurchatkin ahh, perfect. Is there any way to preserve the variance of the properties?

@jcready no, there is nothing you can do.

That's too bad, is it not possible to do (soundly or otherwise) or is it just something that hasn't been worked on yet?


Illegal invocation when resolving a promise in nw.js (node-webkit)

I use the following code in nw.js:
(new BPromise(function (resolve) {
    resolve('test');
}))
    .then(console.log);

Or even simpler:
BPromise.resolve('test')
    .then(console.log);

Both snippets throw:
Unhandled rejection Error: TypeError: Illegal invocation
    at Object.ensureErrorObject (.../node_modules/bluebird/js/main/util.js:228:20)
    at Promise._rejectCallback (.../node_modules/bluebird/js/main/promise.js:416:22)
    at Promise._settlePromiseFromHandler (.../node_modules/bluebird/js/main/promise.js:460:17)
    at Promise._settlePromiseAt (.../node_modules/bluebird/js/main/promise.js:530:18)
    at Promise._settlePromiseAtPostResolution (.../node_modules/bluebird/js/main/promise.js:224:10)
    at Async._drainQueue (.../node_modules/bluebird/js/main/async.js:182:12)
    at Async._drainQueues (.../node_modules/bluebird/js/main/async.js:187:10)
    at Immediate.Async.drainQueues [as _onImmediate] (.../node_modules/bluebird/js/main/async.js:15:14)
    at processImmediate [as _immediateCallback] (timers.js:321:17)

I use Bluebird v2.9.25 and nw.js v0.12.1.
Any ideas?

You'll have to bind the method to your object:
Promise.resolve('test').then(console.log.bind(console))

See also https://stackoverflow.com/questions/25098385/why-does-passing-console-log-directly-to-promises-then-not-work

Oh indeed! Thanks @bergus !


Update components to work with the new Variants API

The new Variants API has been recently published which allows developers to define variants for components where the components are defined or used instead of in a global theme file. Documentation for the Variants API
Currently only the Button component has been updated to utilize the new variants API. The following components will need to be updated. The primitive components will be updated first and then we will start adding support for the new variants API to the complex components.

[ ] Avatar
[ ] Badge
[ ] Box
[x] Button
[ ] Flex
[ ] Grid
[ ] Iframe
[ ] Image
[ ] Label
[ ] Link
[ ] Loading
[ ] Nav
[ ] Svg
[ ] Tag
[ ] Text

The kodiak-ui package will provide the appropriate getVariants method to get the CSS associated with the variant key passed in. The first object is the variants prop passed to the component and the second is the theme that exists on all components since we are wrapping the application with our Provider.
getVariants(variants)(theme)

To keep backwards compatibility, we need to leave the _variant method as the fallback if the variants prop is not passed to the component.
export const componentVariant = ({
  variant: variantProp,
  variantKey = 'buttons',
  variants,
  theme,
}) => {
  if (variants) {
    return getVariants(variants)(theme)
  }

  return _variant({ variant: variantProp, theme, variantKey, variants })
}

export const Component = styled('div', {
  shouldForwardProp,
})(
  {
    boxSizing: 'border-box',
  },
  componentVariant,
)

Please comment with the component that you would like to tackle to ensure that we are not stepping on each other's toes.

I'll take the following:

[ ] Avatar
[ ] Badge
[ ] Box

@simonporter007 can you take the following?

[ ] Nav and NavItem
[ ] Svg
[ ] Text

You should be able to follow a very similar pattern to what I did in my PRs above.

@all-contributors add @wesleycole for code, design, and maintenance

@all-contributors add @wesleycole for code, design, and maintenance

@all-contributors add @wesleycole for code, design, and maintenance

@all-contributors add @wesleycole for code, design, maintenance, and review


use RRect to draw avatar check on chip

Fixes https://github.com/flutter/flutter/issues/24773

Making this configurable is a bit of a head scratcher


Update to Avalonia 11.0.0-rc2.1

Just starting to update ready for the next version whilst I've got a spare minute.
Some functions were removed from ItemsControl is https://github.com/AvaloniaUI/Avalonia/pull/11752, and I noticed that the same properties also exist on StackPanel and didn't have bindings, so I added them at the same time

This seems to work for me locally when I build with dotnet build or in VSCode, but in VS 2022 I get https://github.com/AvaloniaUI/Avalonia/issues/11913

Updated to 11.0.0-rc2.2

LGTM


[DRAFT] [DEMO] [SPARK] Use explicit Rowset time formatters for improving RowSet generation

:mag: Description
Issue References 🔗

Subtask of #5808.
Describe Your Solution 🔧
Types of changes :bookmark:

[ ] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Test Plan 🧪
Behavior Without This Pull Request :coffin:
Behavior With This Pull Request :tada:
Related Unit Tests

Checklists
📝 Author Self Checklist

[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] This patch was not authored or co-authored using Generative Tooling

📝 Committer Pre-Merge Checklist

[ ] Pull request title is okay.
[ ] No license issues.
[ ] Milestone correctly set?
[ ] Test coverage is ok
[ ] Assignees are selected.
[ ] Minimum number of approvals
[ ] No changes are requested

Be nice. Be informative.

It seems that the performance of (with-skip jump) primitive data types (shown in red rectangle) is lowered, while of the fall-though data types(shown in the green rectangle of Decimials, Date, and etc.) is improved.
cc @wForget
WDYT?

@bowenliang123 I guess the overhead may come from the always construction of HiveResult.getTimeFormatters

@bowenliang123 I guess the overhead may come from the always construction of HiveResult.getTimeFormatters

Yes. For most cases, shown from evidence. But the overhead for primitive types should not comes from the data types, the time formatters are reused in the whole stage of TRowSet generation.
Still have to see more evidence for repeated tests. Please consider merge #5809 to introduce benchmark with warmups and repeating rounds, for the reference of further investigation.


Coxeter shapes are now compatible with Signac statepoints.

Prior to this PR, coxeter.shapes classes were not json serializable. Because of this, they could not be used directly as a parameter in a signac state point. This PR enables the following:
import signac
from coxeter.families import PlatonicFamily

cube = PlatonicFamily.get_shape("Cube")

project = signac.init_project()

statepoint = dict(N=64, seed=1, vf=0.60, types=["cube"], poly=cube)

job = project.open_job(statepoint)

Once loaded into the statepoint, many shape attributes are accessible from the dict:
job.statepoint.poly.vertices
>>>[[-0.5, -0.5, -0.5],
    [-0.5, -0.5,  0.5],
    [-0.5,  0.5, -0.5],
    [-0.5,  0.5,  0.5],
    [ 0.5, -0.5, -0.5],
    [ 0.5, -0.5,  0.5],
    [ 0.5,  0.5, -0.5],
    [ 0.5,  0.5,  0.5]]

job.statepoint.poly.centroid
>>>[0.0, 0.0, 0.0]

job.statepoint.poly.gsd_shape_spec
>>>{'type': 'ConvexPolyhedron', 'vertices': [[-0.5, -0.5, -0.5], [-0.5, -0.5, 0.5], [-0.5, 0.5, -0.5], [-0.5, 0.5, 0.5], [0.5, -0.5, -0.5], [0.5, -0.5, 0.5], [0.5, 0.5, -0.5], [0.5, 0.5, 0.5]]}

All coxeter.shapes store their defining attributes (for example, radius for a Sphere and vertices for a ConvexPolyhedron). All shapes also store their centroid in the new dict, as well as a few other useful properties.
Description

Added dict special method
Added _data method (where Signac loads data from)
Added __getitem__, __iter__, keys, and items methods required for proper Signac function
Added pytests

Motivation and Context
Signac scripts using this new structure can better interface with molecular dynamics software, especially HOOMD. For example, gsd-formatted type_shapes can be added to a logger directly from the statepoint via job.statepoint.poly.gsd_type_shapes. Similarly, hoomd.hpmc integrators can be initialized from data stored within the poly object and a shape's inertia_tensor can be directly added to particles.moment_inertia.
Types of Changes

[ ] Documentation update
[ ] Bug fix
[x] New feature
[x] Breaking change1

1The change has the potential to break existing functionality. Users who rely on the default-generated dict method may find keys have different names after this change.
Checklist:

[x] I am familiar with the Contributing Guidelines.
[x] I agree with the terms of the Contributor Agreement.
[x] The changes introduced by this pull request are covered by existing or newly introduced tests.
[ ] I have updated the changelog and the credits.

The GSD shape specification is almost exactly what I would recommend as a serialization format. Can you use the gsd_shape_spec attribute to serialize the shape as a dict, save that in the statepoint, and use coxeter.from_gsd_type_shapes to deserialize the dict into a shape for further computation? If there are shapes this doesn’t handle, we might be able to expand the GSD shape spec, but last I knew this should be sufficient.

This PR requires some thought into the best manner to approach this problem, and I do not believe it is particularly high priority right now. I have marked it as a draft to direct focus toward more important tasks.

I will reopen this issue as a new PR with significant changes to the internal implementation


Zio 2 support

Description
PR to update ZIO version to 2.0.0 and and do all the necessary code changes to reflect that.
Checklist
Pull Request

[ X] PR description is meaningful
[ X] There are no more than a few commits to merge
[ -] There are no more than a few lines of code to review

Code style

[ -] Maximum line length does not require horizontal scrolling in Github
[ -] Compliant to FMT, ScalaStyle and ScalaFix

Testing

[ X] Unit tests for the added/modified code
[ X] Overall unit test coverage good
[ X] Unit tests are passing

Dependencies

[ X] The safety plugin is happy
[ X] New dependencies do not have vulnerabilities

Security

[ X] There is no known vulnerability being added to this project

ScalaFmt needs to run


Terratest: identify ImagePullBackOff and exit ASAP with proper message

Terratest often uses functions like k8s.WaitUntil..., e.g.: WaitUntilNumPodsCreatedE(...). If POD cannot be started because of ImagePullBackOff, terratest waits unnecessarily until a certain number of retries have elapsed. Apart from the fact that terratest runs unnecessarily even though the error is clear, the developer then has to spend time looking for the error etc..

Consider:

if an optimization would be appropriate, exit immediately and provide an understandable errorMessage
if it makes sense to do the same for CrashLoopBackOff.
This behavior may be configurable.

stale, closing


npm ERR! missing script: dev

[root@centos8 sharedrop]# npm run dev
npm ERR! missing script: dev
npm ERR! A complete log of this run can be found in:
npm ERR!     /root/.npm/_logs/2020-03-18T20_55_42_031Z-debug.log
I install use README. For step pm run dev I have this error

Try npm run develop and let me know if it works. If it does, I'll update the README.

npm run develop - working

Now I see only this message on load website.  Maybe problem connect to firebase? Where I can check logs? Thanks

Please provide error messages from Dev Tools console.

I've updated the README file, so now it correctly describes available commands. If you're getting some JS error, please open a new issue.


vrc-get: 1.8.1 -> 1.8.2

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/vrc-get/vrc-get/releases.
meta.description for vrc-get is: Command line client of VRChat Package Manager, the main feature of VRChat Creator Companion (VCC)
meta.homepage for vrc-get is: https://github.com/vrc-get/vrc-get
Updates performed

Rust version update

To inspect upstream changes
Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 1.8.2 with grep in /nix/store/l2sr348fg756sbyb81ph4paa6kqs799a-vrc-get-1.8.2
found 1.8.2 in filename of file in /nix/store/l2sr348fg756sbyb81ph4paa6kqs799a-vrc-get-1.8.2

Rebuild report (if merged into master) (click to expand)

2 total rebuild path(s)

2 package rebuild(s)

First fifty rebuilds by attrpath

vrc-get

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/l2sr348fg756sbyb81ph4paa6kqs799a-vrc-get-1.8.2 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A vrc-get https://github.com/r-ryantm/nixpkgs/archive/cbdb8ee3e0f838f8f0a2b63c24f69b4a4848103e.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/cbdb8ee3e0f838f8f0a2b63c24f69b4a4848103e#vrc-get

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/l2sr348fg756sbyb81ph4paa6kqs799a-vrc-get-1.8.2
ls -la /nix/store/l2sr348fg756sbyb81ph4paa6kqs799a-vrc-get-1.8.2/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review

x86_64-linux

:white_check_mark: 1 package built:

vrc-get

Maintainer pings
cc @bddvlpr for testing.

[!TIP]
As a maintainer, if your package is located under pkgs/by-name/*, you can comment @NixOS/nixpkgs-merge-bot merge to automatically merge this update using the nixpkgs-merge-bot.

Add a :+1: reaction to pull requests you find important.

@NixOS/nixpkgs-merge-bot merge

Oops, manually it is...


Implement Azure store

Related issue #401
This store uses only Block Blobs. Therefore supports files up to 190.7TiB.
Uses the latest version of https://github.com/Azure/azure-storage-blob-go and supports Microsoft Service Version 2019-12-12
Includes automated test for the store, but not the service. As I have not been able to use gock to mock the HTTP responses, I think this is because azure-storage-blob-go has used their own http.Client through azure-pipeline-go.
But uploads have been tested with uppy, tusc and tuspy. With chunk sizes above 4MiB
Additional features allows you to specify the access type of the container upon creating (if it does not already exist, limited by the storage account support).
https://docs.microsoft.com/en-us/azure/storage/blobs/anonymous-read-access-configure
And the blob access tier; inferred (inherited from container default), hot, cool and archive.
https://docs.microsoft.com/en-us/azure/storage/common/storage-account-overview#access-tiers-for-block-blob-data

I just realised the tests uses Go v1.12.x and v1.13.x. Which causes some trouble.
By downgrading azure-storage-blob-go to v0.11.0, it would pass in go v1.13.x
But

@Acconut I did a test in our repo, by changing the test targets to match your https://github.com/tus/tusd/blob/master/docs/installation.md, i.e. v1.14 and v1.15, tests are passing fine.
https://github.com/arkivverket/tusd/actions/runs/530638133
The branch I tested on is based on this branch, only change I did was the testing matrix, and I removed the build stage, as it would never run in my test branch.
https://github.com/arkivverket/tusd/commit/fa264a35565f2366cd5052384081b1f1cb118250
Please let me know if you have any questions, or need some changes done.
As stated earlier, we have assigned resources to be able to resolve this implementation.

First of all, thank you for this amazing PR and apologies for my late reply!

But uploads have been tested with uppy, tusc and tuspy. With chunk sizes above 4MiB

Have you also tested this without specifying any chunk size at all? For example, in Uppy the chunkSize option is not mandatory and rarely necessary.

Which means 1.14 and 1.15 should be the test targets?

Yes, feel free to adjust the Go versions in your branch!

Please let me know if you have any questions, or need some changes done.

I wanted to have a look at this today but noticed that @Benehiko also updated their PR https://github.com/tus/tusd/pull/407 in the meantime. Maybe you can head over there quickly and see which PR is better and on which we should move our focus :)

But uploads have been tested with uppy, tusc and tuspy. With chunk sizes above 4MiB

Have you also tested this without specifying any chunk size at all? For example, in Uppy the chunkSize option is not mandatory and rarely necessary.

Yes, I have tried without specifying any chunksize, it it too, works nicely.

Which means 1.14 and 1.15 should be the test targets?

Yes, feel free to adjust the Go versions in your branch!

I have adjusted the go versions in the workflow to be 1.15 and 1.16, as they're the latest versions now.
And I changed the test strategy to not fail fast, so it allows all tests to run, even if other fails. That way, in my opinion, it is easier to trace any testing issues related specifically to an OS version or go version being tested. But that commit can be reverted, let me know what you think.

Please let me know if you have any questions, or need some changes done.

I wanted to have a look at this today but noticed that @Benehiko also updated their PR #407 in the meantime. Maybe you can head over there quickly and see which PR is better and on which we should move our focus :)

I might be biased and prefer my PR.
But I have implemented the possibility to change the blob tier. E.g. you only upload for long term archiving, you don't need it to be in the hot tier, but perhaps cool or archive tier.
Same goes with the container (bucket) access type.

@Acconut In the future, it might be nice to look at adding concurrent support for this implementation.

Really nice work here! Any updates on getting this or #407 merged? I have a use case requiring gcp, s3, and azure blob backends, so I would really like to use this feature.

@Acconut I see there's an upcoming v2 release, I've tested my PR against the latest v2 branch, and so far, it is working fine. Although the tests are failing on s3store, but I see they're doing the same here (https://github.com/tus/tusd/actions/runs/885415253)

Thank you very much for the hard work and the patience with us! Since the other PR has been closed by its maintainer, I am going to merge this beast and so how it holds up! :tada:


Attach video to specified tag

It seems the webcam feed is hard coded to append to the body of the webpage. Is there any means of rather appending to other than thee body? e.g a specific div?

In this case the easiest is to use an iframe . I hope this helps
On Fri, Nov 3, 2017, 11:17 AM Anesu Fitz Muzenda<EMAIL_ADDRESS>wrote:

It seems the webcam feed is hard coded to append to the body of the
webpage. Is there any means of rather appending to other than thee body?
e.g a specific div?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/jeromeetienne/AR.js/issues/239, or mute the thread
https://github.com/notifications/unsubscribe-auth/AAPcIpI47PlyFCP8QOICE_6zCAmOSVV4ks5syvZCgaJpZM4QQ8fo
.

Ok thanks..I'm looking at using AR.js with Ionic so having the video in body overflows all other UI. Any particular reason to appenddl to body and not a target element? Would like to chime in and  contribute toallow for targeting an element

No specific reason. Just the most common case
On Fri, Nov 3, 2017, 1:06 PM Anesu Fitz Muzenda<EMAIL_ADDRESS>wrote:

Ok thanks..I'm looking at using AR.js with Ionic so having the video in
body overflows all other UI. Any particular reason to appenddl to body and
not a target element? Would like to chime in and contribute toallow for
targeting an element
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/jeromeetienne/AR.js/issues/239#issuecomment-341697870,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAPcImrktbiGQ3aUwpFqT13TJoJMQl_Dks5syw_EgaJpZM4QQ8fo
.


Feature: add Order class

Add Order class for future feature implementation
Note:
PR-ing the Order class skeleton alone for teammates to see the draft skeleton of the class (esp the attributes part). I think this will be best merged after the other classes have been implemented as otherwise there will be a lot of red lines for missing classes and errors 🤣
The most significant part should be the attribute, where it is currently implemented to use a Customer object, a Driver object, and some Dish objects.
This is because initially, I thought that since we can only pass in strings to the command line, we can only handle string-based attributes in Order (such as customer name, customer phone, all in string representation). However that means there will be no connection between Order and the other classes, which is not good for future features (where for eg we need to go from Order to its related Customer). Therefore, my current vision of the implementation is to have CustomerList#getCustomerByPhone(), and DriverList#getNextFreeDriver(), as well as Menu#getDishByName(), and use them when an order is created by command line string, so we can pass in the input string, get the relevant objects as output, and then create an Order based on the objects.

As I have implemented all order features based on this implementation (i.e. all order features already contains this PR), there is no need to merge this PR since merging any other Order PR merges this too, and it is solely for viewing the Order class implementation. This PR will therefore be closed.


[WIP] New layer with more control over opacity and color

First of all, thanks for the great software!
While loading GPX tracks I wanted to have more control over color and opacity for each track so I implemented this:

It's the layers pane reimplemented so that loaded tracks have inputs for controlling color and opacity. For the uneditable overlays only opacity is shown.
To be clear: this is not finished and I would like to further improve the UI and code (or any feedback you have) but I wanted to submit this PR to know if you're interested in such a feature?
Thanks for your time.
Cheers,
Kim

Yes, this would be welcome.
I would prefer to include the Control.Appearance plugin as an external lib in our package.json.

Ok, thanks for the feedback. I'll pick this back up in a couple of weeks when work gets a bit less busy.

Closing as stalled for too long - feel thanks for the PR @KimGressens, feel free to reopen if this is ready to be merged I'll be happy to do so :).


python3Packages.pint-pandas: unstable-2022-11-24 -> 0.4

Description of changes
https://github.com/hgrecco/pint-pandas/compare/0.3...0.4 ( picked 0.3 as it roughly matches time of unstable version )
also unmark as broken on aarch64-linux
Things done

Built on platform(s)

[x] x86_64-linux
[x] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

@ofborg build python3Packages.pint-pandas python3Packages.pint-pandas.passthru.tests

Result of nixpkgs-review pr 239121 run on aarch64-darwin 1

4 packages marked as broken and skipped:

python310Packages.pint-pandas
python310Packages.pint-pandas.dist
python311Packages.pint-pandas
python311Packages.pint-pandas.dist


enha: add metric for event creation

PR Type
Enhancement

Description

Implemented a new metric to measure the time taken for Kafka event creation
Added conditional compilation for metrics feature in the importer
Updated metrics definitions to include the new kafka_create_events histogram
Enhances observability of the Kafka event creation process

Changes walkthrough 📝
Relevant filesEnhancement

importer.rsAdd metrics for Kafka event creation time

src/eth/follower/importer/importer.rs
Added metrics for event creation time measurement  Wrapped new code in #[cfg(feature = "metrics")] to conditionally compile  Implemented timing for event creation process in Kafka connection

+6/-0

metrics_definitions.rsAdd Kafka event creation time metric definition

src/infra/metrics/metrics_definitions.rs
Added new histogram duration metric kafka_create_events  Metric measures time to create events

+4/-1

💡 PR-Agent usage: Comment /help "your question" on any pull request to receive relevant information

Final benchmark:
RPS Stats: Max: 914.00, Min: 772.00, Avg: 821.88, StdDev: 23.16
TPS Stats: Max: 888.00, Min: 772.00, Avg: 821.55, StdDev: 22.18
Plot: View Plot

Final benchmark:
RPS Stats: Max: 1006.00, Min: 543.00, Avg: 887.02, StdDev: 49.20
TPS Stats: Max: 1011.00, Min: 760.00, Avg: 795.44, StdDev: 102.59
Plot: View Plot

Final benchmark:
Run ID: bench-3840946928
Git Info:

Branch: main
Commit: 4553269
PR: #1866

Configuration:

Target Account Strategy: Default (Random)

RPS Stats: Max: 1042.00, Min: 577.00, Avg: 867.94, StdDev: 57.78
TPS Stats: Max: 1003.00, Min: 695.00, Avg: 841.69, StdDev: 66.49
Plot: View Plot


Release to NPM? (pngjs2)

I reverted back to pngjs (https://github.com/lukeapage/pngjs). It seems to me to be the most maintained and developed png package.
This also fix some rare non-determinic behaviour I was in results.
I released it in v. 0.0.5


Update submodule + exclude new example folder.

Hi, I updated the submodule (to latest) and excluded a newly introduced example to fix compilation.

Btw, we added an ofxImGuizmo example to ofxImGui, to demonstrate addon usage (and creation). ;)

Thank you so much!


Implement ALTER COLUMN DROP DEFAULT

This PR implements ALTER COLUMN column_name DROP DEFAULT.
Also it introduces ColumnAlteration interface to simplify ALTER COLUMN actions.
fix #92

IMO, we could remove pos_test.go. I'm not sure why only a test for AlterColumnSet positions exists.

Yeah, I'm happy to remove it.


Added DenizenScript Language Support

I added a TextMate grammar file for a language called DenizenScript!
Description
DenizenScript is a scripting language for Minecraft servers. As the language's syntax can easily become very hard to read without syntax highlighting (stuff within stuff that contain stuff that can also contain other stuff!), I decided it would be a good idea to contribute a grammar file that I wrote to Linguist!
note:
On the checkbox that says: The extension of the new language is used in hundreds of repositories on GitHub.com, I checked it off, even when there are not hundreds of repositories because of the announcement on issue #5756 and because DenizenScript is a language to program things like games and special items for Minecraft servers, most repos that use DenizenScript will most likely be private (due to Minecraft servers being monetizable). There could be more instances of DenizenScript in the wild, but there is something else that uses the same extension so I had to add some of the most common syntax in a few different search queries that DenizenScript has to filter it out. Just wanted to clear that up :).
Checklist:

[x] I am adding a new language.

[x] The extension of the new language is used in hundreds of repositories on GitHub.com.

Search results for each extension:

https://github.com/search?q=extension%3Adsc+type+script+events+NOT+nothack&type=Code&l=&l=
https://github.com/search?q=extension%3Adsc+type+script+flag+NOT+nothack&type=Code

[x] I have included a real-world usage sample for all extensions added in this PR:

Sample source(s):

https://github.com/BreadcrumbIsTaken/BreadVibesMC/blob/main/Factions - 25567/plugins/Denizen/scripts/Factions Core.dsc
https://github.com/BreadcrumbIsTaken/BreadVibesMC/blob/main/Factions - 25567/plugins/Denizen/scripts/Faction Actions/Transfer Ownership/Tranfer Event.dsc
(Note: I removed some comments in the sample scripts that aren't relevant for the samples. I wrote the samples myself so I think that's alright)

Sample license(s):

https://github.com/BreadcrumbIsTaken/BreadVibesMC/blob/main/LICENSE

[x] I have included a syntax highlighting grammar: https://github-lightshow.herokuapp.com/?utf8=✓&scope=from-url&grammar_format=auto&grammar_url=https%3A%2F%2Fgithub.com%2FBreadcrumbIsTaken%2Fdenizenscript-grammar%2Fblob%2Fmain%2Fgrammars%2Fdenizenscript.cson&grammar_text=&code_source=from-url&code_url=https%3A%2F%2Fgithub.com%2FBreadcrumbIsTaken%2FBreadVibesMC%2Fblob%2Fmain%2FFactions%2520-%252025567%2Fplugins%2FDenizen%2Fscripts%2FFactions%2520Core.dsc&code=
[ ] I have updated the heuristics to distinguish my language from others using the same extension.

The heuristics does not apply to me. Also, I got the color in the languages.yml from the logo.

Hey @lildude, I was wondering if I can get an update on my PR? I hope you don’t mind the ping. I’m just excited about being able to contribute to something related to GitHub and would really like some feedback!
Thanks :)

So I just pushed the Debian .dsc file grammar.
Here are the sample sources:

https://github.com/OneIdentity/bldr/blob/master/test/asset/test-reindex-data/nonstandard-dir/libdependable_2.3-4.dsc
https://github.com/OneIdentity/bldr/blob/master/test/asset/example/debian/control
Here is the license for the samples:
https://github.com/OneIdentity/bldr/blob/master/LICENSE
Here is the syntax highlighting:
https://github-lightshow.herokuapp.com/?utf8=✓&scope=from-url&grammar_format=auto&grammar_url=https%3A%2F%2Fgithub.com%2Ftsbarnes%2Flanguage-debian%2Fblob%2Fmaster%2Fgrammars%2Fdebian%2520package%2520control%2520file.cson&grammar_text=&code_source=from-url&code_url=https%3A%2F%2Fgithub.com%2FOneIdentity%2Fbldr%2Fblob%2Fmaster%2Ftest%2Fasset%2Ftest-reindex-data%2Fnonstandard-dir%2Flibdependable_2.3-4.dsc&code=

Thanks @BreadcrumbIsTaken. I've tweaked your changes slightly as we don't need all the other extensions right now for this PR. They can be added later if peeps want them.


[BUG] Fixed problems with generation parquet files

Some tests were skipped by me, because I did not think that I needed to separately generate data.
Besides I think that unit tests should be run without additional run of the data generation script.

I like the idea of generating data on the fly.
Could you explain in more detail why you disabled tests?

Specifically, I mistakenly turned off these tests, because I tested it locally on a machine and (which was not very obvious to me) missed the data generation phase (python hpat/tests/gen_test_data.py), which runs when testing occurs in the Trave CI.
For example, a comment below says that data is generated only for test_io.py which isn't True.
(file - hpat/buildscripts/test.sh)
# generate test data for test_io
python hpat/tests/gen_test_data.py


Add missing virtuals

Enable unit test verifying methods are virtual
Fixes https://github.com/aspnet/Identity/issues/349
cc @divega @suhasj

:shipit: