Move gain selection from CameraCalibrator to EventSource

#1166 highlighted some issues with the current order for gain selection
The first option in #1166 (perform the gain selection in the SimtelEventSource) made most sense to me as:

R1 waveforms are supposed to be single channel (as the correct gain channel is decided at the camera server, before data volume reduction is performed and the resulting DL0 waveforms are stored).
EventSources are meant to provide the single-channel DL0 (R1 for the moment, during prototyping), however the waveforms provided by the simtel EventSources have both gain channels.

This is accomplished by passing a GainSelector to the SimtelEventSource when initialising. By default, a SimtelEventSource will use a ThresholdGainSelector (which has a default threshold of 1000).
R1 waveforms are consequently now single channel (2 dimensions: n_pixels, n_samples) as is intended in the data model.
R0 waveforms are still available from the SimtelEventSource and contain both gain channels.

I think it would also make sense to set the default threshold to 4095 (or at least something like 4000), which is closer to the correct dynamic range for all current cameras, that have 12-bit ADCs (and presumably linear gains in that range).   Even if we should really tailor each to the specific camera, the default is what most people will naively use and should be as close to correct as possible.

Also, i think it's better to use a ThresholdGainSelector by default in the EventSource.  That way for a quick example event loop, we don't have to pass in a GainSelector, just stick with the default that gives you what you should expect.

I think it would also make sense to set the default threshold to 4095 (or at least something like 4000), which is closer to the correct dynamic range for all current cameras, that have 12-bit ADCs (and presumably linear gains in that range). Even if we should really tailor each to the specific camera, the default is what most people will naively use and should be as close to correct as possible.

Are there any linearity effects which mean you would want to switch gain way before hitting the saturation (and therefore have a threshold a bit lower than 4095)?

Also, i think it's better to use a ThresholdGainSelector by default in the EventSource. That way for a quick example event loop, we don't have to pass in a GainSelector, just stick with the default that gives you what you should expect.

This is what I do in this PR, isn't it?

This is what I do in this PR, isn't it?

Sorry, I misread it - yes this is good.


Creating an administrator when importing fake data.

Add management command create_superuser.
Adding line to Makefile to invoke it.

See https://docs.djangoproject.com/en/1.7/howto/custom-management-commands/ for details.

On Sun, Feb 08, 2015 at 03:24:59PM -0800, Greg Wilson wrote:

Add management command create_superuser.
Adding line to Makefile to invoke it.

Ah, I hadn't gotten far enough down in my inbox ;).  As I just
mentioned in #182 1, I think creating superusers, especially one
with hardcoded credentials, is not a particularly useful task, and
doesn't deserve automation.  Running:
$ python manage.py createsuperuser
for each deploy isn't a difficult task, and is more flexible than the
create_superuser proposed here.

As I just mentioned in #182 [1], I think creating superusers, especially one with hardcoded credentials, is not a particularly useful task, and doesn't deserve automation.

While it not useful for production, for development it's really important. It would drive me nuts if I had to re-create super user every time I change branches to review some PRs (and I do that often).
My understanding is that make database is used only for development process, is that right? If so then I really like Greg's solution (except for the command's name, it should be something like "create default superuser").

On Mon, Feb 09, 2015 at 12:37:09AM -0800, Piotr Banaszkiewicz wrote:

As I just mentioned in #182 [1], I think creating superusers,
especially one with hardcoded credentials, is not a particularly
useful task, and doesn't deserve automation.

While it not useful for production, for development it's really
important. It would drive me nuts if I had to re-create super user
every time I change branches to review some PRs (and I do that
often).

You can create a local superuser once and then migrate into or out of
branches that add migrations (which I expect will be few and far
between).  When you don't have migrations in a branch, there's no need
to touch the database at all, just run the new code on the old
database.

My understanding is that make database is used only for
development process, is that right?

That's what I'd been using it for, but in the post-1.0 world, I don't
see a point to having anonymized seed data at all.  Folks interested
in local testing can just seed with:
$ python manage.py migrate
$ python manage.py createsuperuser --username admin --personal admin
>   --family admin --email<EMAIL_ADDRESS>and away they go.  Typing out a password once per developer is not
going to be a great hardship.
That said, the new code is fairly isolated, so if my push-back isn't
convincing, don't worry about it ;).

Okay, I have a few thoughts on the subject here.
Production
Creating superuser automatically on production is a bad idea. We all agree on that.
Fixtures

My understanding is that make database is used only for development process, is that right?

That's what I'd been using it for, but in the post-1.0 world, I don't see a point to having anonymized seed data at all.

How do you see that working? Can we for example provide some fixtures that are used for development process?
Forgotten command
I simply forgot that we can use ./manage.py syncdb to create database, apply migrations and create superuser all at once:
(amy3k) ~/workspace/amy   master  ./manage.py syncdb
Operations to perform:
  Apply all migrations: workshops, auth, contenttypes, admin, sessions
Running migrations:
  Applying contenttypes.0001_initial... OK
  Applying auth.0001_initial... OK
  Applying workshops.0001_initial... OK
  Applying admin.0001_initial... OK
  Applying sessions.0001_initial... OK

You have installed Django's auth system, and don't have any superusers defined.
Would you like to create one now? (yes/no): yes
Username: piotr
Personal: Piotr
Family: Banaszkiewicz
Email<EMAIL_ADDRESS>Password:
Password (again):
Superuser created successfully.

Summary
If we combine fixtures and syncdb command I think we can have a decent starting point for development process.
Therefore I'm closing this PR as unmerged. I'll open an issue regarding updates to Makefile in post-1.0 era where we can discuss changes to make database and development fixtures.
If we change our minds we can reopen this PR after all.

On Mon, Feb 09, 2015 at 12:06:34PM -0800, Piotr Banaszkiewicz wrote:

I simply forgot that we can use ./manage.py syncdb to create
database, apply migrations and create superuser all at once:

With Django 1.7, ‘syncdb’ is deprecated in favor of just ‘migrate’ [1,2].

With Django 1.7, ‘syncdb’ is deprecated in favor of just ‘migrate’ [1,2].

Thanks Trevor, I did not know that. Unfortunately migrate doesn't run createsuperuser on it's own, so yeah…

On Mon, Feb 09, 2015 at 02:54:29PM -0800, Piotr Banaszkiewicz wrote:

With Django 1.7, ‘syncdb’ is deprecated in favor of just ‘migrate’ [1,2].

Thanks Trevor, I did not know that. Unfortunately migrate doesn't
run createsuperuser on it's own, so yeah…

… so if you need a superuser, you'll have to call ‘createsuperuser’ by
hand.  It's not hard ;).
I'd like to reopen #70 and move towards my initial proposal of
allowing everyone to log in and edit their own metadata (where
appropriate), have event leads manage their own events, etc., which
would make having a local superuser less important for local testing.


examples: remove redundant directories

Description of your changes

Same as https://github.com/crossplaneio/stack-gcp/pull/105/files
Checklist

I have:

[x] Run make reviewable to ensure this PR is ready for review.
[x] Ensured this PR contains a neat, self documenting set of commits.
[x] Updated any relevant documentation, examples, or release notes.
[x] Updated the dependencies in app.yaml to include any new role permissions.

LGTM!

@hasheddan could you update the title of this PR to match the GCP/AWS ones? the current "remove redundant directories" I don't think captures the real intent of this change.
The other ones used something like "examples: move examples from crossplane repo"

@jbw976 yep! thanks for catching that :)


add --enable_socket flag to allow for disabling the unix socket

We have some teams that would prefer to run this service without the unix socket, due to possible interaction issues with XFS filesystem overlays.
To preserve backward compatibility, the default value of this flag is true.

Removing the named pipe didn't resolve the core issue, so no urgency on this feature

Removing the named pipe didn't resolve the core issue, so no urgency on this feature


Installing plug-in results in error message

Describe the bug
I can't install the plug-in, the following error message is shown:
Failed to install add-on The command /bin/ash -o pipefail -c apk add --no-cache python3 bash py3-pip' returned a non-zero code: 3
Version info:
I'm using Home Assistant 2024.2.5 in a VM on a Synology NAS.

The error says nothing..
Please send me the supervisor log from HA.

Hello Dielee,
I'm also trying to install Volvo2mqtt on my Raspberry Pi 4B with HomeAssisant OS. I'm getting the same error (but code:2 instead of code:3)
Failed to install add-on
The command '/bin/ash -o pipefail -c apk add --no-cache python3 bash py3-pip' returned a non-zero code: 2.
The Supervisor log says:
_024-07-25 10:17:26.296 INFO (MainThread) [supervisor.host.apparmor] Adding/updating AppArmor profile: 982ee2c4_volvo2mqtt
2024-07-25 10:17:26.405 INFO (MainThread) [supervisor.docker.addon] Starting build for 982ee2c4/aarch64-addon-volvo2mqtt:1.9.4
2024-07-25 10:17:27.892 INFO (MainThread) [supervisor.updater] Fetching update data from https://version.home-assistant.io/stable.json
2024-07-25 10:17:38.250 ERROR (MainThread) [supervisor.docker.addon] Can't build 982ee2c4/aarch64-addon-volvo2mqtt:1.9.4: The command '/bin/ash -o pipefail -c apk add --no-cache python3 bash py3-pip' returned a non-zero code: 2
2024-07-25 10:17:38.251 ERROR (MainThread) [supervisor.docker.addon] Build log:
Step 1/15 : ARG BUILD_FROM
Step 2/15 : FROM $BUILD_FROM
---> bbaa6c3a3c1b
Step 3/15 : RUN apk add --no-cache python3 bash py3-pip
---> Running in acc4252a8fc5
fetch https://dl-cdn.alpinelinux.org/alpine/v3.20/main/aarch64/APKINDEX.tar.gz
fetch https://dl-cdn.alpinelinux.org/alpine/v3.20/community/aarch64/APKINDEX.tar.gz
WARNING: fetching https://dl-cdn.alpinelinux.org/alpine/v3.20/main: temporary error (try again later)
WARNING: fetching https://dl-cdn.alpinelinux.org/alpine/v3.20/community: temporary error (try again later)
ERROR: unable to select packages:
py3-pip (no such package):
required by: world[py3-pip]
python3 (no such package):
required by: world[python3]
---> Removed intermediate container acc4252a8fc5_
Can you help me how to solve this issue. I also have install the Volvo2mqtt on my Virtual Machine on my QNAP. That installation went oke and without any problem.
With kind regards,
Maurice


Decouple from zipkin2.Endpoint

One thing that hurt us updating from zipkin v1 library to zipkin v2 was the Endpoint type. It caused a fair amount of library dancing and a difficult to remove dependency. For example, assigning a remoteEndpoint caused an overload on a close, but still 3rd party type. Moreover, we know people want to change only specific pieces of the endpoint. For example, just the port for services. Sometimes, like in camel or sidecars, folks want to change the local service name. It can be tricky to do this without accidentally messing up the IP information. Finally, whenever this occurs, there's some overhead due to re-allocating Endpoint objects.
The idea here is to decouple the tracing apis from zipkin2.Endpoint types, instead using a brave cover type, which in the case of NoOp does nothing. Underneath a "MutableEndpoint" type would be used in recording which is only conditionally present when overriding defaults. We'd deprecate the existing apis which ask for zipkin2.Endpoint for removal in Brave 6.

Here is a summary of rationale from chat:
Summary:

the context is MutableSpan, the new customizable thing should it be decoupled from the types in io.zipkin.zipkin2. not wrapped really, replicated, then only when reported to zipkin (ex not to micrometer or similar) only then we convert so you could imagine something like...
mutableSpan.localServiceName("foo") which doesn't re-create or in any way reference zipkin2.Endpoint.serviceName

On validation:

otoh we have a choice to make :P Consider mutableSpan.ip("1.3.armadillo.4") Right now, due to some nice code in zipkin2.Endpoint, we can cheaply validate on this call and return false. This allows you to do conditional stuff (ex if (!endpoint.ip(forwardedFor)) endpoint.ip(remoteIp))
so the cost is either not having validation, or making validation utilities, or embed the same validation code into MutableEndpoint.
it is 375 lines of code.. the ip validation stuff I don't think I've had to change it recently.. so anyway this is the source of my tension.. whether to copy/paste this stuff (and the tests) from zipkin2 in order to decouple the libraries for the MutableSpan type.

Less dependency exposure to "non-zipkin" integrations:

If we do this now then, in brave 5.2 we have a way to not have sneaky deps on zipkin2 library, and those who make metrics handlers.. they won't break if we make a zipkin3 (bound to eventually occur). Plus, we are increasingly sending data to places not zipkin as well xray, stackdriver, datadog, etc. .. metrics being even the more odd recipient

This is all related to firehose mode: https://github.com/openzipkin/brave/issues/557
It is also related to Camel which currently manages multiple instances just to override the local service name they are proxying for. https://github.com/apache/camel/blob/master/components/camel-zipkin/src/main/java/org/apache/camel/zipkin/ZipkinTracer.java#L440
Also this has been reported numerous times sleuth Ex:
https://github.com/spring-cloud/spring-cloud-sleuth/issues/1039
https://github.com/spring-cloud/spring-cloud-sleuth/issues/1041

https://github.com/openzipkin/brave/pull/747 should fix this


Reload config on change

#525
You mean something like this?

@margaale this seems like a fine approach to me, and I guess people who dont want it to reload just have to pass false when they setup. Is it possible to add some tests for this? Probably at acceptance test level?

I've undone the consul change. Tomorrow i'll try adding the tests...

Awesome! Thanks for this.

No problem. It's useful for both of us. Sorry for the consul things. I actually did it for the sake of completeness. I don't know what is really... :-D

Haha all good!

Hi, i'm gonna need your help. I'm having trouble figuring out how should i write the test. Right now i have:
`   [Fact]
public void should_reload_config_on_change()
{
var initialConfig = new FileConfiguration
{
GlobalConfiguration = new FileGlobalConfiguration
{
RequestIdKey = "initialKey"
}
};
        var anotherConfig = new FileConfiguration
        {
            GlobalConfiguration = new FileGlobalConfiguration
            {
                RequestIdKey = "someOtherKey"
            }
        };

        this.Given(x => _steps.GivenThereIsAConfiguration(initialConfig))
            .And(x => _steps.GivenOcelotIsRunningReloadingConfig(true))
            .And(x => _steps.GivenThereIsAConfiguration(anotherConfig))
            .And(x => )
            .BDDfy();
    }`

That last and should check that the config has changed, but i don't know how to check for that without mocking some component. How would you do it?

I rebased my branch because i didn't like the way it was. Please, review it again, sorry. Also added a test. Probably  i should have added one for admin api and consul too.


Something that i am writing, would like to contribute ???

Hey there,
I am going to write something awesome but need some contribution, so I thought to share it with you :)
What I am planning to build is a Dashboard for graphql-flutter client :)
The idea is to give user flexibility from writing a single code to using this dashboard to create QUERY, MUTATION and SUBSCRIPTION without even touching a single file or writing a code.
Workflow is to generate a builder which will dynamically create json/yaml file and from that file we can generate .dart file which can be importable in flutter
Dashboard will have Two sections :

Schema
Builder

inside schema user can specify schema identifier, fields and condition
example .yaml
  identifier:
       - GET_USERS_QUERY
  fileds:
      - id
      - email
      - profile
           - name
           - mobile
  conditions:
     - user
         - where:
            - mobile ${mobile}

the above yaml generation is for our workflow, the user will have dashboard interface, with input box to fill. from that input a yaml reference like above will be generated and from that yaml a dart file in user lib folder will be generated.. yaml for our reference and dart for user, from that dart file he import
this will generate get_users_query.dart
String getUsersQuery = """
  query(\$mobile: String!) {
    user(where: { mobile: \$mobile }) {
      id
      email
      profile {
        name
        mobile
      }
    }
  }
  """
    .replaceAll('\n', ' ');

Part 2) Builder
now user has created his first Schema to grab data from graphql server. let's add a query to actually fetching that data.
User can now to go Builder section,
there will be 3 buttons called "create query", "create mutation", "create subscription"
when clicking on "create query", a form will be opened which will have schema dropdown, where user can select predefined schame, in our case GET_USERS_QUERY_SCHHEMA,

finally trigger query or mutation like,
import 'packages:dashy/dashy.dart' as dashy;

class HomePage extends StatefulWidget {
  @override
  _HomePageState createState() => _HomePageState();
}

class _HomePageState extends State<HomePage> {
  String mobile; // this mobile <state> will be availbe in dashboard

 @override
  Widget build(BuildContext context) {
    return Center(
          RaisedButton(
              onPressed: () async {
                 dashy.query(GET_USERS_QUERY, { // optional custom variables })
              }
          )
    );
  }
}

This sounds really useful.
Are there existing schemas you can use though. Like igraphql dashboard etc ?
On Sun, 5 Aug 2018, 06:32 kunal dodiya<EMAIL_ADDRESS>wrote:

finally trigger query or mutation like,
import 'packages:dashy/dashy.dart' as dashy;
class HomePage extends StatefulWidget {
@override
_HomePageState createState() => _HomePageState();
}
class _HomePageState extends State {
String mobile; // this mobile  will be availbe in dashboard
@override
Widget build(BuildContext context) {
return Center(
RaisedButton(
onPressed: () async {
dashy.query(GET_USERS_QUERY, { // optional custom variables })
}
)
);
}
}
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/zino-app/graphql-flutter/issues/50#issuecomment-410495108,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ATuCwm8OqbOx9ATpQExzmUFBEVJm4ZzRks5uNnVEgaJpZM4VvOxo
.

Not yet.. I am currently implemented though, I will be updating asap with the package link


[Suggestion] Make hardcoded strings translatable (broader i18n)

Currently, several strings (like the toast Data has been synced!, and the banner's name in auto importer loading screen, also the cannot load dynamically loaded modules?) are hardcoded and therefore not translatable. I suggest them be translatable so that the website can be more accessible to non-English speakers.

I have added the string for drive error, but for the error page I need to check it first if the translation can go there (because its an error page, I don't know if the locale script can run there)


Compile error in Opencv

platform : ubuntu18.04
When compiling whole project you may find that
libhkust_pl_smm.so：对‘cv::fillPoly(cv::InputOutputArray const&, cv::InputArray const&, cv::Scalar const&, int, int, cv::Point)’未定义的引用

A feasible solution :
Add opencv dependency in package "semantic_map_manager"
find_package(OpenCV REQUIRED)
include_directories(
...
${OpenCV_INCLUDE_DIRS}
)
target_link_libraries(
...
${OpenCV_LIBS}
)

A feasible solution : Add opencv dependency in package "semantic_map_manager"
find_package(OpenCV REQUIRED) include_directories( ... ${OpenCV_INCLUDE_DIRS} ) target_link_libraries( ... ${OpenCV_LIBS} )

Helpful!

@zmwhit Thx. This issue has been fixed.


Kotlin doc

Codecov Report
Attention: Patch coverage is 59.29204% with 46 lines in your changes are missing coverage. Please review.

Project coverage is 59.03%. Comparing base (de221a8) to head (6c2e192).

Files
Patch %
Lines

...n/org/skellig/teststep/processor/rmq/RmqChannel.kt
0.00%
11 Missing :warning:

...tstep/processor/tcp/model/TcpConsumableTestStep.kt
0.00%
11 Missing :warning:

...eststep/runner/registry/CachedTestStepsRegistry.kt
0.00%
6 Missing :warning:

...n/org/skellig/teststep/processor/tcp/TcpChannel.kt
81.25%
2 Missing and 1 partial :warning:

...llig/teststep/runner/context/SkelligTestContext.kt
62.50%
1 Missing and 2 partials :warning:

...lig/teststep/processor/jdbc/JdbcRequestExecutor.kt
0.00%
2 Missing :warning:

...cessor/performance/PerformanceTestStepProcessor.kt
0.00%
2 Missing :warning:

...tstep/processor/rmq/model/RmqConsumableTestStep.kt
0.00%
2 Missing :warning:

...tstep/processor/unix/model/UnixShellHostDetails.kt
80.00%
0 Missing and 2 partials :warning:

...processor/performance/model/PerformanceTestStep.kt
0.00%
1 Missing :warning:

... and 3 more

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@             Coverage Diff              @@
##             master      #69      +/-   ##
============================================
+ Coverage     58.96%   59.03%   +0.06%
- Complexity     1566     1570       +4
============================================
  Files           266      266
  Lines          8866     8853      -13
  Branches       1158     1161       +3
============================================
- Hits           5228     5226       -2
+ Misses         3127     3117      -10
+ Partials        511      510       -1

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


To Do list: add & remove

Hello 😊 ,
I have been able to add new features on the to-do-list project based on the following requirements:

Removed all hardcoded items from the tasks array. ✅
Create a new JavaScript file (Methods.js) for the new functionality.✅
Implemented a function for adding a new task (add a new element to the array).✅
Implemented a function for deleting a task (remove an element from the array).✅
Implement a function for editing task descriptions.✅
New tasks has the property completed set to false and the property index set to the value of the new array length + 1✅
Deleting a task updates all remaining items' indexes, so they represent the current list order and are unique.✅
All changes to the To Do List saved in local storage.✅

Thank you for reviewing my code 😄

Thank you for reviewing my project!!


relativeTimeToString() incorrect output

NSDate().relativeTimeToString() will return a date, not a relative time measure if the date in question is over 7 days in the past

Apparently this is by design.
You could tweak the code in AFDateExtension.swif, around line 856:
if days < 7 {

This is by design. Similar to how time ago works.


Add Async _acall and _astream to Bedrock

Feature request
Currently Bedrock and BedrockChat models do not sypport async calls and streaming.
it would be very useful to have working ChatOpenAI methods like _acall and _astream in Bedrock llms too so that we can use Claude2 and other Bedrock Models in production easily
Motivation
without async functionalities it is hard to build production level chatbots using Bedrock models, including claude2 which is one of the most desired models
Your contribution
I am trying myself, but I am having difficulties. If someone can help, it would be very appreciated by many,

not a useful answer

added in https://github.com/langchain-ai/langchain/pull/12477


Delete old Eclipse tutorial

Maintenance of UI5 Eclipse Tooling ended 3 years ago.

@nicoschoenteich Are you sure that you want to retire this tutorial? Did you check if it is referenced in other places, especially other tutorials? These references will also have to be removed. Is this tutorial part of a group/mission that has to be updated?

Hi @MichaelCzcz,
Yes I am sure I want to retire this tutorial. There are no references to this tutorial in other groups, missions or tutorials.
Best, Nico


[Hotfix] Resolve PHP warning at logger

#510

@anvmn should we merge this, is it on live?

@AronNovak
This is not on live. Seemed not reasonable to perform a deploy just for this.
I'll merge it once we have enough content to deploy.


pull request for e2e test at 11/13/2016 06:15:08

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

optest/docs/updated_at.md
:white_check_mark:Succeeded

Details

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Change custom file markup

Please see https://github.com/twbs/bootstrap/pull/28511#issuecomment-474381351.
By changing the markup of custom file, remove the way of translating button labels by CSS, and support a long file name. Now, you can change the button label by HTML.
And for fix #28389, move the border to the each children of the .custom-file-label. Another way by overflow: hidden is suddested (https://github.com/twbs/bootstrap/pull/28388#issuecomment-468898020), but it does not round the inside of the corner.

I also added the transition to .custom-file-text and .custom-file-button for focused border color animation.
Closes #25497
Closes #26933
Closes #28388
Closes #28389
Preview: https://deploy-preview-28696--twbs-bootstrap.netlify.com/docs/4.3/components/forms/#file-browser

Maybe we should also include an example wit a longer placeholder to demonstrate the truncation?

I checked the SCSS again and confirmed that there are no problem, I updated the PR comment and remove the WIP.
@MartijnCuppens Could you add the example? if you are okay with that 🙏

Wouldn't make more sense to use the grid in this and the previous example? That way we won't have those long forms.

I think I’m good with this, but does it come at the cost of a screen reader announcing the button text since it’s in the label?

@mdo had a super-cursory check with NVDA and Jaws on Win (Chrome/Firefox/IE), and it seems to behave no different from the current implementation, unless i'm missing something?

Hadn’t compared to current behavior, so just wanted to ask the question to see if this a regression or area for improvement for us. If you’re good with it @patrickhlauke, I’m good here.

it seems appropriate to me (not extensively tested/compared to native clean unaltered file input, but these are notoriously icky - particularly in Firefox/NVDA - and just checking the above seemed good for me)

Thanks. I suggest small improvements. Set line-height/font-weight on the .custom-file-label element instead of both spans inside. And use .custom-file-label > * selector to assign some common styles like display, padding, border and transition.

Set line-height/font-weight on the .custom-file-label element instead of both spans inside.

Might indeed be a nice improvement.

And use .custom-file-label > * selector to assign some common styles like display, padding, border and transition.

I don't mind using the universal selector in case we gain a lot of improvement by it. Since we know what the classes of the children will be (.custom-file-text & .custom-file-button) I don't think it's worth adding another selector to add common styles here.


Feature: hotkey to add track to library

Being able to have a hotkey to upvote the track AND add it automatically to the users library would be great.
This is an awesome project!

I would be happy to take this issue when I have time, BTW.

I'm not sure how this would be done, but if @MarshallOfSound has any pointers I'd love to take a look at it!

add track to library

This is not currently possible due to the way google handles context menus, it's been discussed and looked into before.
There is already a hotkey through for upvoting the track 👍


The OracleJDK docker image will be bigger because mv operation

The two OracleJDK Dockerfile has the following directive
RUN mv $(ls -1 -d /usr/java/*) $JAVA_HOME
The mv operation will increase the docker image size. There is no such problem when using "ln -s" command.

There was a problem when using symlink, which I cannot remember exactly, but it would fail on inherited images. Which is why we went with mv instead of ln. See commit 8b8b4904

Found the actual commit, with much better explanation :-)
See e234ae65f.


Duplicate sentence on "What is risk?" page

Hello,
The following sentence is duplicated in the page under the section "User-linked detections"

These risks are calculated offline using Microsoft's internal and external threat intelligence sources including security researchers, law enforcement professionals, security teams at Microsoft, and other trusted sources.

Cheers,

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 81a1385f-b90a-e7b4-8cbd-f25aeb8b3c49
Version Independent ID: d468eb75-88a9-b1aa-7fb3-19ebb4faa179
Content: What is risk? Azure AD Identity Protection
Content Source: articles/active-directory/identity-protection/concept-identity-protection-risks.md
Service: active-directory
Sub-service: identity-protection
GitHub Login: @MicrosoftGuyJFlo
Microsoft Alias: joflore

@ghiffti Thanks for the feedback. We will engage the content development team for further investigation, they will verify and perform necessary changes in the document as needed.

Good catch!


OneCodex -> One Codex (I know, I know...)

Yes, this is a tiny bit neurotic, but I've just been (internally) fighting for this space, and so hope a quick PR is OK... Promise I haven't broken any tests!

Oh – and I don't believe one can PR the repo "tagline", but I'd appreciate a quick edit there should you choose to accept this PR. :)

Sure thing @boydgreenfield, thanks for your contribution!

Unfortunately, I cannot change the tagline, let's hope @Phelimb remembers :)

Haha, well thanks @LuRsT – and I'll try to make a more meaningful contribution next time! ;)


Minor improvement for openmath

use logv replace print
fix latex2png build fail
remove warning

???

It seems I have the same modification for this improvement but not pushed, waiting for me to confirm.

Are all the codes pushed?

???

???

Sorry for the late response, merged now 😄

thanks


Add Hub installation

According to https://github.com/actions/virtual-environments/issues/36 Hub CLI installation has been added to Windows\Linux image generation scripts.
Builds from branch [v-andmis/36_Add_Hub] have been created successfully:
https://github.visualstudio.com/virtual-environments/_build/results?buildId=61647&view=results
https://github.visualstudio.com/virtual-environments/_build/results?buildId=61692&view=results
https://github.visualstudio.com/virtual-environments/_build/results?buildId=61690&view=results
https://github.visualstudio.com/virtual-environments/_build/results?buildId=61691&view=results
VMs have been created, and Hub has been tested there through next steps:

Windows and Linux VMs were enabled
PATH environment variable was checked for correct path to Git and Hub CLI directory
according to https://hub.github.com/hub.1.html some Hub CLI commands have been executed in VM serial console (hub, hub help, etc)

VMs have been created, and Hub has been tested there.
Could you please provide testing steps?

/azp run

Should we document this installed tool in readme for Windows and Ubuntu?

VMs have been created, and Hub has been tested there.
Could you please provide testing steps?

Done

/azp run win2019

/azp run windows2019


Moved Greengrass container default into the fallback config

This update moves the Greengrass container default into the fallback configuration so it can be overridden.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Integration tests passed.


Minor grammar fixes noticed while following getting-started-guide

What's changed in the PR?

Updated tense of "ran" to "run"
Updated grammar on pull request template

Rationale
Improve the quality of the getting started experience.
How'd to test?
These are text changes only. They were largely done with find/replace of is ran to is run. I verified there were no tests expecting the word ran anywhere, but did not run the tests.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

the unit test ran fine, the functional test are known to not run because the PR is from external. This PR is unlikely impact the func test and the merge commit will trigger a run for us.


Some features doesn't work

Mastodon, Twitter, Weibo Did not working when i'm clicking on th'm the app Exit
NHentai E-Hentai Working but i can't Download Read or Open in the browser .

Ooooh nice, I'll check that project 👍


Enable Llama2 70B to run with hqt on single card (#50)

Add disk_offload flag that controls device_map=auto. Setting this flag enbales weights offload to disk when cpu memory runs OOM.
Add const serialization path flag that gets a path for where to serialize const sections, so if there is no space on device to save all const sections they will be offloaded to disk.
What does this PR do?

Fixes # (issue)
Before submitting

[ ] This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
[ ] Did you make sure to update the documentation with your changes?
[ ] Did you write any new necessary tests?

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.


I'm not sure what the dot colours represent

👋🏻
In the below screenshot you can see that some dots have been coloured (e.g. at the top some are green, a little bit below that there are some orange and blue dots) and I'm not sure why?

In other files this can be a bit more distracting...

I don't know if this is an mistake on the part of the plugin? (e.g. it's using highlight groups set by my current colour scheme) or if the colours are supposed to represent something? (e.g. it's some kind of treesitter parsing and it's trying to use the same syntax colours as the buffer content).
I'm guessing the dots are using some kind of diagnostic 'sign' symbol maybe.
Is this the case? How can I get rid of these additional colours if they are indeed meaningless in relation to what minimap is displaying (don't want to break any diagnostic stuff that my current buffer's LSP might be using for example).
Thanks!

I mean, the whole raison d' etre of this plugin was that it integrates into lsp and treesitter and shows all kinds of stuff on it. You can turn the treesitter coloring off by using putting use_treesitter = false into your config. It's explained in detail in the readme


Content review feedback

[ ] The use of words, ie, "this guide" and "that guide" can be reworded. ie, "The starting point of this guide will be the finished application..." and "Please first go through that guide if you are not familiar..."

[ ] I think generally "Note that.." in "Note that Java 8 is required to run this project." is not ID standard. Also not sure mentioning Java 8 requirement is needed in the intro.

[ ] Note that this guide will not cover migration of test cases, and the starting project does not include test code or dependencies. => I think this can be mention in the test section of the guide instead of in the intro.

[ ] Within "What you'll learn", may be good to add what's the benefit of using Open Liberty or explain why using OL.

[ ] The repo to be name same as the projectid, or vice versa.

[ ] "You’ll see from the page output that the GreetingController handled the name request parameter:" => is it possible not to refer to "GreetingController" directly here? It's the first time it's being mentioned in the guide, if you have to mention it, may be good to add some explanation about it.  Can't expect all users actually go through the spring guide to learn about the controller.

[ ] Running the starting application in embedded Tomcat => I think the word "starting" is not needed.

[ ] Navigate to the start/pom.xml file to modify the starter POM. => Since there's a mention of the changes are to be done within the start folder, there's no need to refer to the pom.xml with the start\ directory anymore.

[ ] Under "Migrating the application", in general, we don't ask user to insert line of code in a file anymore. Refer to this wiki for structuring and styling the guide: https://github.com/OpenLiberty/draft-guides-template/wiki/Guidelines-for-Structure-and-Styles. You can also check out this guide as an example: https://github.com/OpenLiberty/guide-cdi-intro. In short, the instruction should ask user to create the pom.xml file, and then refer to the line(s) of code that you would like to talk about.

[ ] The intro describes 4 steps to do the migration, but looks like there're 3.

[ ] "Change the packaging type", "Add POM properties", "Add and modify dependencies" and "Add the Liberty Maven Plugin" sub headings may not be needed. Can be replaced with a sentence. ie, perhaps "First, you need to change the package to <packaging>liberty-assembly</packaging>."

[ ] The related guide section is linked to an empty guide.

Generally speaking, we won't use "please".  For point 1 and 2 and changes there, we can consult @sishida where and if necessary.

It's best not to use self-referential language, such as "this guide," at all if we can avoid it. It's better if we could say, "Start with the finished application..." or "If you're not familiar with , complete ..."
The issue with words like "Note that" and "please" is that they're just not really necessary. The "pleases" would overrun the doc if we included them in front of every command we gave. :)

The use of words, ie, "this guide" and "that guide" can be reworded. ie, "The starting point of this guide will be the finished application..." and "Please first go through that guide if you are not familiar..."

It's best not to use self-referential language, such as "this guide," at all if we can avoid it. It's better if we could say, "Start with the finished application..." or "If you're not familiar with , complete ..."

@sishida Can you explain the benefit of doing this? From the examples that you gave, it just comes off as sounding intentionally vague. The second example you gave isn't grammatically accurate; what are you not familiar with? I don't see the problem with referencing the guide in the third person (the same way you would reference a person's name as "he" or "she").

@chyt Hi! I edited the original comment so that you can now see the whole statement as intended. It had been hidden before because the words that are now in italics were originally in angled brackets. Sorry about that--I forgot about GitHub's way of automatically formatting content!
Self-referential language is sort of redundant/unnecessary because the user should assume that the contents of the guide they're reading apply to that guide. For example, I wouldn't say, "This book is a story about..." or "In this story...". Rather, I'd just start writing about what happens in the story. The reader should already know it's a story (about something). Same thing with instructions. You can just jump right in and start telling the user what to do instead of first telling them that they're looking at a guide and that these particular instructions concern this particular guide. Hope that helps! :)

I think generally "Note that.." in "Note that Java 8 is required to run this project." is not ID standard. Also not sure mentioning Java 8 requirement is needed in the intro.

What does ID standard mean? Also why would you not mention this in the intro? If the user is running an older version they are told upfront that the guide will not work for them. If they cannot or aren't willing to upgrade to a later version, then they aren't wasting any more time reading additional content that won't be useful to them.

Note that this guide will not cover migration of test cases, and the starting project does not include test code or dependencies. => I think this can be mention in the test section of the guide instead of in the intro.

Again, I think that you want to be upfront with the reader. After I state that the migration is taking place on an existing Spring Boot application, and to go through the guide for that application first, they will naturally expect that the entirety of that application is migrated. I think it is important that the What you'll learn section also addresses what the reader will not learn, if they expect to learn that based on the context.
Also, what is the alternative? It doesn't make sense to create a test section in the guide just to tell them that we won't be covering test migration. That's why I deleted the section to begin with.

"You’ll see from the page output that the GreetingController handled the name request parameter:" => is it possible not to refer to "GreetingController" directly here? It's the first time it's being mentioned in the guide, if you have to mention it, may be good to add some explanation about it. Can't expect all users actually go through the spring guide to learn about the controller.

I could say something like a controller (specifically GreetingController). However, I'm not sure how useful this is as the class name is self-explanatory. The reader will either be already familiar with the MVC paradigm (in which case they would not be surprised that some controller class is handling the request), or they are not (in which case they should have gone through the Spring guide). But why would they be interested in migrating a Spring MVC application if they are not familiar with Spring MVC to begin with?

Navigate to the start/pom.xml file to modify the starter POM. => Since there's a mention of the changes are to be done within the start folder, there's no need to refer to the pom.xml with the start\ directory anymore.

I agree. However I was given feedback in #3 that it was to be added. I think that the entire sentence is unnecessary. The reader already knows that we are modifying files in the start folder, and the title of the section is Modifying the pom. There is reasonably only one file that I could be referring to. Please clarify.

Under "Migrating the application", in general, we don't ask user to insert line of code in a file anymore. Refer to this wiki for structuring and styling the guide: https://github.com/OpenLiberty/draft-guides-template/wiki/Guidelines-for-Structure-and-Styles. You can also check out this guide as an example: https://github.com/OpenLiberty/guide-cdi-intro. In short, the instruction should ask user to create the pom.xml file, and then refer to the line(s) of code that you would like to talk about.

While this may be the general format, I disagree that doing this is the best way to present an application migration. Presenting the whole file as a new one might be fine when most/all of the initial code is just boilerplate. However, for an application migration the majority of code is already written, and the user is more interested in the specific changes that are necessary for migration. These are the ones that they will be applying in their own migrations and the rest of the code is application-specific. Telling them to create a new file doesn't sound like they're performing a migration anymore.
For the multi-pane format, I think it is appropriate to just display the entirety of the finished file on the right, but still keep the code snippets and reference the corresponding line numbers in the finished file.

The intro describes 4 steps to do the migration, but looks like there're 3.

I agree that the steps presented in the intro don't align perfectly with what is presented in the guide. There are a lot of smaller changes that are necessary. However, it was intended to be a general outline which highlights the key steps that are required in the migration process.
They do sort of align though. Removing Tomcat and adding Liberty are both performed in the POM. The section about changing the application startup process is teaching how to run from a traditional WAR deployment. Finally, package and deploy is covered by the mvnbuild and mvncompile template documents. Perhaps I should talk more explicitly about packaging, as this is done automatically by the build.

"Change the packaging type", "Add POM properties", "Add and modify dependencies" and "Add the Liberty Maven Plugin" sub headings may not be needed. Can be replaced with a sentence. ie, perhaps "First, you need to change the package to liberty-assembly."

If you feel strongly about this, then I remove them. However I feel like it is good for the structure of the guide. Otherwise you would just get Modifying the POM followed by a wall of text.

The related guide section is linked to an empty guide.

Any suggestions for related guides? I am not aware of any other guide like this that we have. I also would have thought that we have an algorithm that produces them - this is what most websites do, and it eliminates the need to update old guides to point to new guides that are related.

Self-referential language is sort of redundant/unnecessary because the user should assume that the contents of the guide they're reading apply to that guide. For example, I wouldn't say, "This book is a story about..." or "In this story...". Rather, I'd just start writing about what happens in the story. The reader should already know it's a story (about something). Same thing with instructions. You can just jump right in and start telling the user what to do instead of first telling them that they're looking at a guide and that these particular instructions concern this particular guide. Hope that helps! :)

@sishida I agree in general with what you are saying. I have changed the intro to only reference the Spring Boot guide once in the third person (saying that guide). I think it would also be redundant so refer to the guide by name, as I just did so in the previous sentence.
Please see the changes at 77e3cd919c2e62ea73b5ea6f6703ab420d9e0ff2 and let me know if it is sufficient.

@chyt Thanks for making edits! I have assigned this issue to Karen, who is the new Open Liberty ID focal.
@chirp1 Hi, Karen, Could you please take a look at the updates for this issue or assign it to another WAS ID writer? Thank you!

@chirp1 FYI, this guide is not ready for formal ID review yet. Feel free to comment on the questions. Thank you.

Had a chat with @chyt yesterday to sort out all of the issues raised above. Here're the new observations after the latest changes:

[ ] There are 2 mentions of the Java 8 requirement statement. One is in "What you'll learn" and the other under "Running the application in embedded Tomcat". I think we agreed that the first is not needed.

[ ] Finally, you will package and deploy the application to Open Liberty. => as we agreed to make change for the word "finally" here.

[ ] Make these changes in the start folder. Navigate to the pom.xml file to modify the starter POM. => can be change to: Navigate to the start directory. You will modify the pom.xml file in several steps.

[ ] All subheadings need to start with a gerund. The subheadings would be really good to match with the steps described in the "What you'll learn".

No change for the following:

[ ] Within "What you'll learn", may be good to add what's the benefit of using Open Liberty or explain why using OL.

Need to discuss these points further:

[ ] Java 8 requirement

[ ] Instruction for inserting code, ie, No packaging type is specified in the starting project, so you’ll need to add <packaging>liberty-assembly</packaging> near the top of the POM.

Follow up issues:

[ ] The "include::finish/pom.xml" did not show up on the website. Perhaps the link is not correct.

[ ] The following code snippet should be formatted the same way as in the "Adding POM properties" subsection. For example, show the code snippet to be added, and then show the finished code. Also remove the comment "".

<dependency>
    <groupId>org.springframework.boot</groupId>
    <artifactId>spring-boot-starter-thymeleaf</artifactId>
    <!-- Add this -->
    <exclusions>
        <exclusion>
            <groupId>org.springframework.boot</groupId>
            <artifactId>spring-boot-starter-tomcat</artifactId>
        </exclusion>
    </exclusions>
</dependency>

[ ] Finally, replace the spring-boot-maven-plugin configuration with the liberty-maven-plugin configuration as shown below. => I think the words "as shown below" is not needed here.

Looks good. Thanks


Re-deploy all Socially live demos to Galaxy

The completed version is linked here: http://socially-step22.meteor.com/ and doesn't work!

I tried downloading the project and deploying it on localhost, got the following errors:
Compiling HTML template: client/imports/party-details/party-details.html
Compiling HTML template: client/app.html

Unable to resolve some modules:

  "reflect-metadata" in /home/faiz/Downloads/meteor-angular2.0-socially-master/client/imports/pipes/pipes.js (web.browser)
  "zone.js/dist/zone" in /home/faiz/Downloads/meteor-angular2.0-socially-master/client/app.js (web.browser)
  "ng2-material" in /home/faiz/Downloads/meteor-angular2.0-socially-master/client/imports/auth/login.js (web.browser)
  "@angular2-material/toolbar" in /home/faiz/Downloads/meteor-angular2.0-socially-master/client/imports/auth/login.js (web.browser)
  "angular2-meteor" in /home/faiz/Downloads/meteor-angular2.0-socially-master/client/imports/auth/login.js (web.browser)
  "@angular/core" in /home/faiz/Downloads/meteor-angular2.0-socially-master/client/imports/auth/login.js (web.browser)
  "angular2-meteor-auto-bootstrap" in /home/faiz/Downloads/meteor-angular2.0-socially-master/client/app.js (web.browser)
  "@angular/router-deprecated" in /home/faiz/Downloads/meteor-angular2.0-socially-master/client/imports/auth/login.js (web.browser)
  "@angular/common" in /home/faiz/Downloads/meteor-angular2.0-socially-master/client/imports/auth/login.js (web.browser)
  "@angular2-material/checkbox" in /home/faiz/Downloads/meteor-angular2.0-socially-master/client/imports/party-details/party-details.js (web.browser)
  "@angular2-material/input" in /home/faiz/Downloads/meteor-angular2.0-socially-master/client/imports/auth/login.js (web.browser)
  "angular2-meteor-accounts-ui" in /home/faiz/Downloads/meteor-angular2.0-socially-master/client/app.js (web.browser)
  "angular2-pagination" in /home/faiz/Downloads/meteor-angular2.0-socially-master/client/imports/parties-list/parties-list.js (web.browser)
  "angular2-google-maps/core" in /home/faiz/Downloads/meteor-angular2.0-socially-master/client/app.js (web.browser)
<EMAIL_ADDRESS>in /home/faiz/Downloads/meteor-angular2.0-socially-master/client/app.js (web.browser)

If you notice problems related to these missing modules, consider running:

  meteor npm install --save reflect-metadata zone.js ng2-material @angular2-material angular2-meteor @angular angular2-meteor-auto-bootstrap angular2-meteor-accounts-ui
angular2-pagination angular2-google-maps

=> Errors prevented startup:

   While processing files with fourseven:scss (for target web.browser):
   /client/css/main.scss: Scss compiler error: File to import: {}/node_modules/angular2-meteor-accounts-ui/build/login-buttons.scss not found in file:
   /home/faiz/Downloads/meteor-angular2.0-socially-master/{}/client/css/main.scss

=> Your application has errors. Waiting for file change

Please check out this comment
@Faiz7412 the tutorial was updated and deployed.
Please open another issue if it doesn't work for you


Add mesos metrics to telegraf

High-level description
This adds a mesos input plugin to Telegraf to ensure that it has parity with mesos_exporter. Framework offers and allocator metrics were added. With these changes, there will be no need to run mesos_exporter on a DC/OS cluster.
Corresponding DC/OS tickets (obligatory)
These DC/OS JIRA ticket(s) must be updated (ideally closed) in the moment this PR lands:

DCOS_OSS-3815 Update the Telegraf Mesos input plugin to parity with mesos_exporter

Checklist for all PRs

[x] Added a comprehensible changelog entry to CHANGES.md or explain why this is not a user-facing change:
[x] Included a test which will fail if code is reverted but test is not. If there is no test please explain here:
[x] Read the DC/OS contributing guidelines
[x] Followed relevant code rules Rules for Packages and Systemd

Checklist for component/package updates:
If you are changing components or packages in DC/OS (e.g. you are bumping the sha or ref of anything underneath packages), then in addition to the above please also include:

[ ] Change log from the last version integrated (this should be a link to commits for easy verification and review): example
[ ] Test Results: [link to CI job test results for component]
[ ] Code Coverage (if available): [link to code coverage report]

@mesosphere-mergebot bump-ee

@mesosphere-mergebot bump-ee

@mesosphere-mergebot bump-ee

@mesosphere-mergebot bump-ee

@mesosphere-mergebot label Ready For Review

@mesosphere-mergebot label Work In Progress

@mesosphere-mergebot bump-ee

@mesosphere-mergebot label Ready For Review

@philipnrmn @branden @janisz could you guys please review this when you have time? thanks!

@mesosphere-mergebot label ship it


rosella on multiple samples

Hi, Newell,
I like rosella, not only because I am a rust fan, but also because of the excellent performance of this tool.
In the documentation, you mentioned that rosella supports multi-sample binning, I know two cases:

co-assembly, and map multi samples to the co-assembly, then we got co-abundance, then binning;
combined single-assembly, and map multi samples to it, like vamb multisplit-binning mode.

Maybe you are one of the people who know the principle of binning best in the world, so I would like to ask you: suppose sample A is used to assemble metagenome A, then sample A, sample B, and sample C are compared to metagenome A, and then binning metagenome A, is this method advisable?
Thanks~
Jie

Hi Jie,
Thanks for your interest in Rosella! Rust is great, and you'll hopefully be able to get even better performance with the latest updates thanks to using some better FASTX sequence parsing libraries.
So, just so I make sure I understand you are talking about mapping reads from samples to a metagenome even if those samples weren't used to create the assembly for metagenome A? This seems a little risky as I would think that the coverage profiles for samples B and C would be kind of inconsistent and you might just be adding noise to your analysis making it difficult for any binner to make sense of it.
On the other hand, if you were to somehow make sure that the samples you were using to compare were taxonomically very similar to sample A then maybe it would be okay? I would suggest using a tool like singleM to get OTU profiles, and then just make sure that sample A, B, and C are all fairly similar. I would not use sample B or C if they were completely distinct from sample A.
Cheers,
Rhys

Hi, Newell,
Thank you for your explanation and suggestions.
I also think that comparing samples B and C back to genome A will cause interference.
VAMB's approach is to merge different assembly results together so that co-assembly can be avoided, but the corresponding calculation of co-abundance will be more expensive.


[AIRFLOW-1289] Removes restriction on number of scheduler threads

This removes the restriction that the number of threads can be at most
the number of CPU cores. There's no reason to have this restriction.
Dear Airflow maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
@aoen @bolkedebruin
JIRA

[x] My PR addresses the following Airflow JIRA issues and references them in the PR title. For example, "[AIRFLOW-XXX] My Airflow PR"

https://issues.apache.org/jira/browse/AIRFLOW-1289

Description

[x] Here are some details about my PR, including screenshots of any UI changes: Removes restriction on num threads

Tests

[x] My PR adds the following unit tests OR does not need testing for this extremely good reason: Tests test existing behavior.

Commits

[x] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":

Subject is separated from body by a blank line
Subject is limited to 50 characters
Subject does not end with a period
Subject uses the imperative mood ("add", not "adding")
Body wraps at 72 characters
Body explains "what" and "why", not "how"

Makes sense to me though I do wonder why this was set in the first place.
LGTM

Codecov Report

Merging #2353 into master will decrease coverage by 0.04%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #2353      +/-   ##
==========================================
- Coverage    69.5%   69.45%   -0.05%
==========================================
  Files         145      145
  Lines       11066    11066
==========================================
- Hits         7691     7686       -5
- Misses       3375     3380       +5

Impacted Files
Coverage Δ

airflow/jobs.py
74.74% <100%> (-0.41%)
:arrow_down:

airflow/models.py
87.08% <0%> (-0.05%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b13cd6d...e15af46. Read the comment docs.

It was there as it used to be that you would use "N+1" in make files (where N is the amount of cores). So that your would not over commit the cpu while still keeping it busy. With the type of loads airflow generates, often waiting for other remote processes to finish, it indeed might not make sense.


Feature request: Support $mdThemingProvider

Why don't you use amazing theming functionality? It is much better then hard coded styles.

please do it !

Created a PR to resolve this: https://github.com/daniel-nagy/md-data-table/pull/607


Registry patches rebased

I am getting compilation errors?
---> Making bundle: dynbinary (in bundles/1.7.0-dev/dynbinary)
Created binary: /home/dwalsh/docker/src/github.com/docker/docker/bundles/1.7.0-dev/dynbinary/dockerinit-1.7.0-dev
github.com/docker/docker/graph
.gopath/src/github.com/docker/docker/graph/push.go:555: undefined: localRepo
.gopath/src/github.com/docker/docker/graph/push.go:559: undefined: localRepo
.gopath/src/github.com/docker/docker/graph/push.go:564: undefined: localRepo
.gopath/src/github.com/docker/docker/graph/push.go:575: undefined: localRepo

This should fix it:
https://github.com/rhatdan/docker/pull/53
On 13.5.2015 15:26, Daniel J Walsh wrote:

I am getting compilation errors?
---> Making bundle: dynbinary (in bundles/1.7.0-dev/dynbinary)
Created binary: /home/dwalsh/docker/src/github.com/docker/docker/bundles/1.7.0-dev/dynbinary/dockerinit-1.7.0-dev
github.com/docker/docker/graph
.gopath/src/github.com/docker/docker/graph/push.go:555: undefined: localRepo
.gopath/src/github.com/docker/docker/graph/push.go:559: undefined: localRepo
.gopath/src/github.com/docker/docker/graph/push.go:564: undefined: localRepo
.gopath/src/github.com/docker/docker/graph/push.go:575: undefined: localRepo
—
Reply to this email directly or view it on GitHub https://github.com/rhatdan/docker/pull/52#issuecomment-101663135.

You were faster :-)


Add new 'paginationWithControls' prop

This PR adds a new paginationWithControls prop to DataTable.
The new paginationWithControls is a boolean which controls mantine's Pagination withControls prop.

Thanks, @ValentinJS! Your PR will go to the next release in a couple of days.
In the future please fork/PR against the next branch.


[Mobile] Incorrect items on copy/paste popup when field is empty

After version flutter_quill [6.3.0], where Flutter 3.7 began to be supported, there was a problem with selecting a document without text and displaying a pop-up dialog with the ability to cut and copy what is not there.
I thought after updating the i18n_extension dependency to version 8.0.0 in version [7.0.1], the problem would go away, but it didn't.

for editor:
contextMenuBuilder: showSelectionToolbar ? RawEditor.defaultContextMenuBuilder : null
final showSelectionToolbar = widget.enableInteractiveSelection && widget.enableSelectionToolbar;

in  raw_editor.dart:

in editable_text.dart:

adaptive_text_selection_toolbar.dart
In current [7.0.3] the same bug. In version [6.2.2] all works correct (display only 'paste' and 'select all')
My issue is about [Mobile].
maybe also
My issue is about [Web]
My issue is about [Desktop]
flutter doctor

really need a check for a non-empty string with display in one case 'paste' and 'select all', in the other - current realisation

https://github.com/singerdmx/flutter-quill/pull/1320


Error using default versions

Hi!
I've tried to run this basic bootstrap skeleton given the default values but I get an error when doing sbt command:
[error] (Compile / compileIncremental) java.io.IOError: java.lang.RuntimeException: /packages cannot be represented as URI

Used entries:
sbt_version 1.2.6
scala_version 2.12.7
name Scala bootstrap
version 1.0
organization tv.codely
package tv.codely.scala_bootstrap

If I replace scala and sbt versions with latest ones it works properly:
sbt_version 1.3.8
scala_version 2.13.1

Hi @gpalomar!
Thanks for reporting the issue, and sorry for the inconveniences.
Your proposed solution seems totally fine. Feel free to open a PR and we'll merge it ASAP 😊


Error: Error("expected ident", line: 1, column: 2) when running from command line

cargo install jsonschema
jsonschema -i ./specs/android/adb_root_emulator.yaml ./schemas/workflow.json, where:

adb_root_emulator.yaml is defined here
workflow.json is defined here

get error Error: Error("expected ident", line: 1, column: 2)

So sorry for the delay! JSON Schema CLI does not support YAML, hence the error. I'll update the docs


ignore kubefile comments

Describe what this PR does / why we need it
Ignore kubefile comments,
Comment lines do not require warning
Does this pull request fix one issue?

Fixes #76
Describe how you did it
If the line starts with #,ignore
Describe how to verify it
Special notes for reviews

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@chaunceyjiang my dingtalk account is fangnux, I will invite you into our developer group~


Does not seem to work in EE4 entry preview

I like the looks of this plugin, and it works great for most of what I would need. But I noticed when I tried to view an entry in the new EE4 Preview feature in the Edit Entry screen that the plugin didn't seem to fire, leaving the preview without any CSS or JS applied.
I'm looking forward to checking out the other add-ons you've recently released. Thanks for offering them up to the community!

Not ignoring you, but I'm having trouble getting Live Preview working in any of our EE4 installs. Still waiting on Structure support at the moment...

I didn't quite understand what you meant when you posted that, but boy do I understand now. I'm struggling with Live Preview with both Structure and WYGWAM at the moment. It's gotten to the point where I figured out how to do a pull request so I could add some functionality to your CSS Tweaks add-on. :)


Update build_tag from dev to .dev (#2779)

Pull request opened by the merge tool on behalf of #2779

Merged into branches iso4 in e8b9f70912cb865332dd1810070b565250b745b9


log only con.peerAddr to prevent flooding useless info

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: hzxuzhonghu
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: ayj
If they are not already assigned, you can assign the PR to them by writing /assign @ayj in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

pkg/mcp/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hzxuzhonghu: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-simpleTests-minProfile.sh
f33974d1a6f6462b1a35f4c2f92f28512bba7f1c
link
/test e2e-simpleTestsMinProfile

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-simpleTests-minProfile.sh
c2db399f365f840f7f9e00b12b9d5ac605dfe045
link
/test e2e-simpleTestsMinProfile

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-simpleTests-minProfile.sh
c2db399f365f840f7f9e00b12b9d5ac605dfe045
link
/test e2e-simpleTestsMinProfile

prow/istio-pilot-multicluster-e2e.sh
c2db399f365f840f7f9e00b12b9d5ac605dfe045
link
/test istio-pilot-multicluster-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-multicluster-e2e.sh
080210d79b06a556c32426195d4f003deb2f2d92
link
/test istio-pilot-multicluster-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Is this PR still applicable?

I think it can be closed now


idk what to fill in the builder

i dont know what it wants me to fill out
what is a registry and what name do i need
what folder? he one i saved the download? a new one?
and the name ?????


Move updating stats to separate endpoint

Probably should also be documented in the readme, as it mentions the old update endpoint.


Added Button Component - 3D Black and White

Fixes Issue
Closes #1195

Changes proposed
The Button Component - 3D Black and White is a visually appealing and modern button style designed to provide a sleek and minimalist look in your web projects. With its three-dimensional design and black and white color scheme, this button adds depth and dimensionality to your user interface.
Features

3D Design: The button has a three-dimensional appearance, giving it depth and a visually striking effect.
Black and White Style: The button is designed in a black and white color scheme, providing a sleek and minimalist look.
Hover Effect: When the user hovers over the button, a subtle animation or shadow effect can be applied to enhance the interactive nature of the buttons.

Screenshots

Checklist

[x] You've linked this PR to the correct issue.
[x] You have checked that the code is working correctly.
[x] You ⭐ the repository!

Note to reviewers
The Button Component - 3D Black and White is a versatile and visually appealing button style that can enhance the design of your web projects. Its 3D design, black and white color scheme, and customizable features make it a great choice for creating modern and sleek user interfaces.
We hope you find the Button Component - 3D Black and White useful in your projects.

Looks Good, Fix the Merge Conflicts

Thank you, sir, for your guidance. I am diligently working to address the merge conflicts. It came to my attention that these conflicts arose during my initial attempt to merge the changes with the remote repository. I am now exerting my utmost effort to resolve them by employing various Git commands and exploring different strategies. I am determined to find a suitable resolution and ensure the smooth integration of the changes. Thank you for your understanding and support.

Please check #1346


Making character icons disappear via Lua

Describe your problem here.
Heyo, all! I'm starting out simple with LUA by trying this script, which should've basically hid both the BF/Enemy icons.
function onCreate()
	precacheImage('icons/icon-blank')

	setProperty('iconP1', 'icons/icon-blank')
	setProperty('iconP2', 'icons/icon-blank')
end

Will that work?
Are you modding a build from source or with Lua?
Lua
What is your build target?
Windows x64
Did you edit anything in this build? If so, mention or summarize your changes.
No response

That will probably crash your game
function onCreatePost()
     setProperty('iconP1.visible', false)
end

That will probably crash your game
function onCreatePost()
     setProperty('iconP1.visible', false)
end

Yeah, it did actually. Heh.

Before I close this, is there actually a list of variables that people can use? It seems to be a common question.

Wiki has a bunch of shortcuts, there is a pretty extensive haxe wiki online and you can find game specific variables in source

Alright.


Search bar does not work

when I search for something in the searchbar at https://dhcr.clarin-dariah.eu/, nothing is happening, even if I press enter;
inspection shows that a file/script is not available: Error 404, unable to reach server
(https://dhcr.clarin-dariah.eu/search_list.json)

@PixlTracer Thank you for reporting this. Indeed the required file is not generated. For now I've done this manually, so the search bar does work again ;)
The bug is not fixed. I'll keep you updated when there is news.

For some reason I can't reproduce this problem :-P
After redeploying the container (with the same code) it works fine. Both in test and production.
Although I noticed some jobs which should update items didn't work. (generate search list, generate sitemap and send course reminders).
I did run the course reminders manually. The next automatic run should be at the 19th.
I've implemented a fix in production (since the cron jobs only work in production).
Within 1 hours from now you can check if it works, by login -> Category Lists -> Log Entries. That should show a "generated search list" every hour. Than we can be sure the search bar is not only working, but also always up-to-date ;)
Feel free to check the issue within 1 hours from now and change to Done if it works ;)

No need to check...yet ;)  Now it fails because of another error (intl extension not enabled in container for cron job).
So the current status is: the search bar does work, but doesn't get updated. (As well generate sitemap and course reminders should be checked).

Status:
broken cron jobs since migration to Heroku 22

Related commits:
9861d76165a3d27ce9af73193bb25faf15a796a3
c9634b7586c3c9929bf614f6db9959f0f77670c9
d6f6aecdfb05392574fe8a43c620902994bcdba4
6cc564265a6554235f1d712086b2b8ac1cca23af
944469654ff1a6afafc0764be6e202001d01fdbf
55a3b32a69fe7a2b2f0cca28b36283dc4c0142ba

@PixlTracer @IvdL22
The searchbar was already fixed. Now all the cron jobs also work as they are supported to. You can check that in production only: Dashboard / Category Lists / Log Entries.

Generating search list runs every hour. Since the recent problems at ACDH which are sometimes also affecting the searchbar, today I've changed this to every 30 mins. So in case of some strange container restart at ACDH it should recover within 30 mins. If problems still exists, we could also make this more often, for example every 5 mins.
Generating sitemap runs every day
Course reminders runs evert 4th and 19th of the month.
Logs are available as specified above.

Can you change the label to Done if satisfied?

great job Patrick, thank you


fix(plugin/swc_js_minimizer): remove parens before optimizing

Summary
The function paren_remover is required for swc_ecma_minifier::optimize.

Fix: #5656

Require Documentation?

[x] No
[ ] Yes, the corresponding rspack-website PR is __

have tried this change - rspack-lottie-1.0.0.tgz works well with it


haproxy.service: Failed to reset devices.list: Operation not permitted

I have HAproxy installed in an LXD 3.0 container.   While monitoring syslog and restarting haproxy, I am seeing this in syslog.  Should I be concerned?
May 19 15:06:31 haproxy systemd[1]: Stopping HAProxy Load Balancer...
May 19 15:06:31 haproxy systemd[1]: Stopped HAProxy Load Balancer.
May 19 15:06:31 haproxy systemd[1]: haproxy.service: Failed to reset devices.list: Operation not permitted
May 19 15:06:31 haproxy systemd[1]: Starting HAProxy Load Balancer...
May 19 15:06:31 haproxy systemd[1]: Started HAProxy Load Balancer.

And here's the haproxy status:
root@HAProxy:~# service haproxy status
● haproxy.service - HAProxy Load Balancer
Loaded: loaded (/lib/systemd/system/haproxy.service; enabled; vendor preset: enabled)
Active: active (running) since Tue 2020-05-19 15:06:31 UTC; 7min ago
Docs: man:haproxy(1)
file:/usr/share/doc/haproxy/configuration.txt.gz
Process: 2217 ExecStartPre=/usr/sbin/haproxy -f $CONFIG -c -q $EXTRAOPTS (code=exited, status=0/S
Main PID: 2218 (haproxy)
Tasks: 2 (limit: 4659)
CGroup: /system.slice/haproxy.service
├─2218 /usr/sbin/haproxy -Ws -f /etc/haproxy/haproxy.cfg -p /run/haproxy.pid
└─2219 /usr/sbin/haproxy -Ws -f /etc/haproxy/haproxy.cfg -p /run/haproxy.pid
May 19 15:06:31 HAProxy systemd[1]: Starting HAProxy Load Balancer...
May 19 15:06:31 HAProxy systemd[1]: Started HAProxy Load Balancer.

No, that's normal, systemd always logs those when run in a container, it's been this way for years and is harmless.


(PUP-8665) Remove anything mcollective from acceptance and unit tests

mcollective is being deprecated for Platform 6. Thus, we no longer need
to worry about it in our acceptance and unit tests. This commit removes
all mentions/references/uses of mcollective from both the acceptance and
unit tests.

https://jenkins-master-prod-1.delivery.puppetlabs.net/view/__experimental/job/experimental_puppet-agent-extra_puppet-agent-integration-suite_adhoc-ad_hoc/8/ shows an ad-hoc run with this PR and puppet-agent with mcollective removed.
The failures fail on one test: the dependency cycle test (https://jenkins-master-prod-1.delivery.puppetlabs.net/view/__experimental/job/experimental_puppet-agent-extra_puppet-agent-integration-suite_adhoc-ad_hoc/8/testReport/) [I also checked the slave labels that were not shown there, such as OSX 10.13, and the failure was the same dependency cycle test]. That test was not touched at all by this PR and is not related to mcollective. The fix for that was merged into 5.5.x but not yet merged-up to master. Once our public suites do that merge-up, I'll rebase this PR on master and re-run my ad-hoc pipeline.
Just wanted to note that it seems like the modifications in this PR are OK.

I think acceptance/tests/ensure_puppet-agent_paths.rb should be in the puppet-agent repo, b/c that just seems to validate that the right files are installed and that the right paths are created?
Not planning on doing that w/ this PR, but more for future work.

CLA signed by all contributors.

@ekinanp agreed, the service and path tests should be in agent. We can do that work separately

jenkins please test this

Looks ok/good to me.

@branan Updated the PR to add back the PE-mcollective stuff.

jenkins please test this

Yup, the binary catalog failure (1) and the dep. cycle graph failure (2). Those two failures are unrelated to this PR.
(1) can be fixed by using the release stream or server version parameter, which PR testing does not have. (2) relies on this PR rebasing on puppet#master, after puppet#5.5.x is merged to puppet#master (since puppet#5.5.x contains the fix for the dep. cycle graph failure).

jenkins please test this

jenkins please test this

jenkins please test this

jenkins please test this

jenkins please test this

jenkins please test this

jenkins please test this

jenkins please test this

https://jenkins-master-prod-1.delivery.puppetlabs.net/view/__experimental/job/experimental_puppet-agent-extra_puppet-agent-integration-suite_adhoc-ad_hoc/ shows a passing ad-hoc run.
The puppet-agent failures are the resource api gem failures we're seeing in the master suite pipeline right now, so they are unrelated to the work done in this PR.


Auto Skipping of Errors

Hi,
I suggest you add an option to automatically skip all files that cannot be downloaded for a smooth downloading experience. It gives an error every-so-often and I'd have to skip it manually which is rather annoying.
Thank you.
Best regards,

Yeah, I second that opinion. I have that problem with zerochan files.

+1, some custom sources I added can be problematic with some larger files, for example. Would be cool if those just got auto-skipped instead of me having to mash the skip button.

So from what I understand, if an image download never completes for some reason, it should be skipped and marked as failed automatically? (for example if no progress on a download for more than 30s or something)
How would it be differentiated from a normal network issue? (wi-fi lost or similar)

Yes, just automatically marked as failed, or maybe pushed to the end of the queue for redownload once or twice.
I'd imagine figuring out if it's a failure to download or a network issue would be nontrivial, so I'd say just let the images keep failing if network is lost. The user can always retry them.


api: make storageClassClaim immutable

add kubebuilder validations to make storageClassClaim spec immutable

depends on: https://github.com/red-hat-storage/ocs-client-operator/pull/72

rebased the branch against main after https://github.com/red-hat-storage/ocs-client-operator/pull/72 merged


ci: optimize build

PR Checklist
Please check if your PR fulfills the following requirements:

[x] The commit message follows Conventional Commits
[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

PR Type
What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Refactoring
[ ] Code style update
[x] Build or CI related changes
[ ] Documentation content changes

What is the current behavior?

Build time: 130 sec
What is the new behavior?

Decompose 2.29Mb into 2 files
Build time: 97 sec
Does this PR introduce a breaking change?

[ ] Yes
[x] No

@vladimirpotekhin @nsbarsukov hello, please review me


view transcript dropdown

Fix to include the text of the transcript. Just shows the link to the transcript text right now.

consider waiting until post migration since we are not implementing transcripts until then


Responsiveness of Home Page

Is your feature request related to a problem? Please describe.

Home Page is not responsive. I want to make home page responsive using HTML,CSS,JS.

Describe the solution you'd like

I will make table of Skills from 3x3 to 1x9
Will also enhance footer
Also make About us responsive

Can I work on this issue?

@harikesh409 @anubhavitis @parthpandyappp
If you think it is valid issue
Please assign me

in about us what you change?? please share your changes @vedant-jain03

in about us what you change?? please share your changes @vedant-jain03

Sorry for late reply,
I want to make responsive to whole homepage but If you are asking for About us only I will definitely make wrap to the fonts and also make size that suits in responsiveness.
@ravikr126 If you want any more changes I will provide you with that also

Please come to discord server

Please come to discord server

Sure I have messaged you. Ravi

Any progress @vedant-jain03 ?

@harikesh409 assign it to me please

@harikesh409 I have messaged ravikr in discord but I didnt get reply and I was not even get assigned

Ok @vedant-jain03 you can work now and make some relevant changes for website

Ok @vedant-jain03 you can work now and make some relevant changes for website

Sure @ravikr126 thanks for assigning


Enhanced the UI of  Privacy Policy page

This pull request introduces significant enhancements to the user interface of the Privacy Policy page to improve its visual appeal and user experience.

Issue No: #312

Before:

After:
https://github.com/user-attachments/assets/5fc339d1-b924-471d-befe-bb037c83266a

@param-code Please review and merge my code with appropriate lables.

Good Job @T-Fathima .

Could you pls think of assigning it with level 2 if it's appropriate.
Thank you.


Binder launch is taking a long time

Currently 6 minutes.
Most of these is really around setting up the conda environment, both the OSX and the binder runs take around the same time.
Let's see if we can optimize this.

Starting with the typical first step, stop using conda-forge.
We use conda-forge in binder because binder installs miniforge from conda-forge
++ dirname /tmp/install-miniforge.bash
+ cd /tmp
+ MINIFORGE_VERSION=4.9.2-2
+ MAMBA_VERSION=0.7.4
+ SHA256SUM=7a7bfaff87680298304a97ba69bcf92f66c810995a7155a2918b99fafb8ca1dc
+ URL=https://github.com/conda-forge/miniforge/releases/download/4.9.2-2/Mambaforge-4.9.2-2-Linux-x86_64.sh
+ INSTALLER_PATH=/tmp/miniforge-installer.sh
+ unset HOME
+ wget --quiet https://github.com/conda-forge/miniforge/releases/download/4.9.2-2/Mambaforge-4.9.2-2-Linux-x86_64.sh -O /tmp/miniforge-installer.sh
time: 0.616
+ chmod +x /tmp/miniforge-installer.sh
+ echo '7a7bfaff87680298304a97ba69bcf92f66c810995a7155a2918b99fafb8ca1dc  /tmp/miniforge-installer.sh'
+ sha256sum --quiet -c -
+ bash /tmp/miniforge-installer.sh -b -p /srv/conda

 _libgcc_mutex      conda-forge/linux-64::_libgcc_mutex-0.1-conda_forge
  _openmp_mutex      conda-forge/linux-64::_openmp_mutex-4.5-1_gnu
  brotlipy           conda-forge/linux-64::brotlipy-0.7.0-py38h8df0ef7_1001
  bzip2              conda-forge/linux-64::bzip2-1.0.8-h7f98852_4
  c-ares             conda-forge/linux-64::c-ares-1.17.1-h36c2ea0_0
  ca-certificates    conda-forge/linux-64::ca-certificates-2020.12.5-ha878542_0
  certifi            conda-forge/linux-64::certifi-2020.12.5-py38h578d9bd_0
  cffi               conda-forge/linux-64::cffi-1.14.4-py38ha65f79e_1
  chardet            conda-forge/linux-64::chardet-3.0.4-py38h924ce5b_1008
  conda              conda-forge/linux-64::conda-4.9.2-py38h578d9bd_0
  conda-package-han~ conda-forge/linux-64::conda-package-handling-1.7.2-py38h8df0ef7_0
  cryptography       conda-forge/linux-64::cryptography-3.2.1-py38h7699a38_0
  icu                conda-forge/linux-64::icu-67.1-he1b5a44_0
  idna               conda-forge/noarch::idna-2.10-pyh9f0ad1d_0
  krb5               conda-forge/linux-64::krb5-1.17.2-h926e7f8_0

This doesn't happen in the OSX install, all the installs are from main, but it still takes 6 minutes for the install.
  ca-certificates    pkgs/main/osx-64::ca-certificates-2020.1.1-0
  certifi            pkgs/main/osx-64::certifi-2<IP_ADDRESS>-py38_0
  cffi               pkgs/main/osx-64::cffi-1.14.0-py38hc512035_1
  chardet            pkgs/main/osx-64::chardet-3.0.4-py38_1003
  conda              pkgs/main/osx-64::conda-4.8.3-py38_0
  conda-package-han~ pkgs/main/osx-64::conda-package-handling-1.6.1-py38h1de35cc_0
  cryptography       pkgs/main/osx-64::cryptography-2.9.2-py38ha12b0ac_0
  idna               pkgs/main/noarch::idna-2.9-py_1
  libcxx             pkgs/main/osx-64::libcxx-10.0.0-1

The dependencies here are pretty simple and straightforward, so let's try to use pip to install instead.

using pip to install runs into multiple issues while installing scipy and pandas. There's a reason that conda is so popular..
(aces_metrics) human-metrics-explore$ pip install -r requirements.txt
Collecting ipywidgets==7.5.1
  Using cached ipywidgets-7.5.1-py2.py3-none-any.whl (121 kB)
Collecting matplotlib==3.2.2
  Using cached matplotlib-3.2.2.tar.gz (40.3 MB)
Collecting pandas==1.1.1
  Using cached pandas-1.1.1.tar.gz (5.2 MB)
  Installing build dependencies ... -
...
    error: Command "/opt/concourse/worker/volumes/live/c1a1a6ef-e724-4ad9-52a7-d6d68451dacb/volume/python-split_1631807121927/_build_env/bin/llvm-ar rcs build/temp.macosx-10.9-x86_64-3.9/libnpymath.a build/temp.macosx-10.9-x86_64-3.9/numpy/core/src/npymath/npy_math.o build/temp.macosx-10.9-x86_64-3.9/build/src.macosx-10.9-x86_64-3.9/numpy/core/src/npymath/ieee754.o build/temp.macosx-10.9-x86_64-3.9/build/src.macosx-10.9-x86_64-3.9/numpy/core/src/npymath/npy_math_complex.o build/temp.macosx-10.9-x86_64-3.9/numpy/core/src/npymath/halffloat.o" failed with exit status 127
    ----------------------------------------
    ERROR: Failed building wheel for numpy
    Running setup.py clean for numpy

Let's try to keep conda for OSX and try pip for binder...

Switching to pip does seem to help; the binder version is now 4 minutes vs. the OSX version at 7 minutes.
But the binder version is still installing conda..
Step 32/51 : RUN TIMEFORMAT='time: %3R' bash -c 'time /tmp/install-miniforge.bash' && rm -rf /tmp/install-miniforge.bash /tmp/env
..
+ mamba create -p /srv/conda/envs/notebook --file /tmp/env/environment.lock
...
done
time: 55.131
+ [[ ! -z '' ]]
+ echo ''
+ [[ ! -z '' ]]
+ mamba clean --all -f -y
.....
# packages in environment at /srv/conda/envs/notebook:
#
# Name                    Version                   Build  Channel
_libgcc_mutex             0.1                 conda_forge    conda-forge
_openmp_mutex             4.5                       1_gnu    conda-forge

We are using the conda buildpack. How do we use the pip buildpack instead given that pip seems to work?
https://github.com/jupyterhub/repo2docker/tree/00769c0fb2624558d600c6a24f14b4ba4154f4ce/repo2docker/buildpacks/conda
https://github.com/jupyterhub/repo2docker/blob/00769c0fb2624558d600c6a24f14b4ba4154f4ce/repo2docker/buildpacks/python/__init__.py

As far as I can make out, it is using the python buildpack.
Debugging further will lead into the weeds of repo2docker and I've already spent too much time on this.
Using PythonBuildPack builder

closed by https://github.com/NREL/human-metrics-explore/pull/6

As a follow-on, we can experiment with building and pushing images on every merge to master. It looks like the most recent repo2docker action supports that. In that case, we don't have to worry so much about conda vs. no conda. But that is beyond the scope of the time I have right now.
https://github.com/jupyterhub/repo2docker-action#push-repo2docker-image-to-other-registries
I really want to do this because it is cool. But I also have a ton of pending tasks.
Maybe the next time I come back to this...

Actually, the code to build and push the images is not that bad. I am confirm that once the image is cached, binder launches a lot more quickly. Seems like it would be trivial to add a new action to cache the image in binder every week. Let's try this every day and see when the build is removed from the cache so we can decide how to progress.

For the record, our options are:

cache on mybinder.org (easiest)

cache on external docker (probably GitHub packages). Needs more testing.

should we use

      BINDER_CACHE: true
      PUBLIC_REGISTRY_CHECK: true

seems like using GitHub packages is as simple as

      registry: ${{ env.REGISTRY }}
      username: ${{ github.actor }}
      password: ${{ secrets.GITHUB_TOKEN }}

in
    DOCKER_USERNAME: ${{ secrets.DOCKER_USERNAME }}
    DOCKER_PASSWORD: ${{ secrets.DOCKER_PASSWORD }}
    DOCKER_REGISTRY: "gcr.io"

Cache checking:

12 Jan: build in cache


All intents processed by same flow

I currently have three intents defined for my skill. Trouble is, whichever intent I invoke, either via voice or using the test page for the skill (by which latter means I know that the correct intent is named in the incoming .json), the same one intent is always invoked in node-red, and the other two are ignored.
Any thoughts?

Hi
I think that you will need to have a different url for each intent – unless you can extract the intent from the object passed to Node Red by Amazon.
Pete and I actually only use one intent and trap it with https:///echohttps://<myserver>/echo
We have up to 15 words trapped by the skill on Amazon which then just recognises the words and passes them across to our Node Red for processing in javascript. Personally, I prefer this as it means that I can do whatever I want with it in Node Red and not touch the Alexa skill on Amazon.
My skill is called ‘house’, so I can say
“alexa, tell the house to turn on the office light and the outside light”
This will extract the phrase “turn on the office light and the outside light” and pass it to node red where I can then strip it apart with a javascript node
This is the code that I use to process the intent before I do anything – it strips out a lot of padding words such as “please”, “the”, “you” etc.
So, something like “alexa tell the house to turn the office light on please” will actually only pass “ turn office light on” to my next node so that I can process the command.
I hope that this helps a bit
Regards
Aidan
var doStuff = {payload: msg.payload.length};
switch (msg.payload.request.type)
{
case "IntentRequest":
if (msg.payload.request.intent.name   === "inputIntent")
{
var word = [];
    word[0] = msg.payload.request.intent.slots.wa.value;
    word[1] = msg.payload.request.intent.slots.wb.value;
    word[2] = msg.payload.request.intent.slots.wc.value;
    word[3] = msg.payload.request.intent.slots.wd.value;
    word[4] = msg.payload.request.intent.slots.we.value;
    word[5] = msg.payload.request.intent.slots.wf.value;
    word[6] = msg.payload.request.intent.slots.wg.value;
    word[7] = msg.payload.request.intent.slots.wh.value;
    word[8] = msg.payload.request.intent.slots.wi.value;
    word[9] = msg.payload.request.intent.slots.wj.value;
    word[10] = msg.payload.request.intent.slots.wk.value;
    word[11] = msg.payload.request.intent.slots.wl.value;
    word[12] = msg.payload.request.intent.slots.wm.value;
    word[13] = msg.payload.request.intent.slots.wn.value;
    word[14] = msg.payload.request.intent.slots.wo.value;

    var thisone = 0, processed = 0, total = word.length;

    for (;;)
        {
        var nxt = "";

        switch (word[thisone])
            {
            case undefined:
            case "the":
            case "to":
            case "thanks":
            case "thank":
            case "please":
            case "you":
            case "er":
            case "erm":
            case "a":
            case "turn":
            case "what's":
            case "what":
            case "is":
            word.splice(thisone,1);
            break;

            default:
            ++thisone;
            break;
            }

        if (++processed >= total)
            break;
        }

    msg.topic = "";
    msg.payload = "OK";
    doStuff.word = word;
    msg.word = word;

    }
return [msg, null];

case "LaunchRequest":
msg.payload = "You need help";
return [null, msg];

case "SessionEndedRequest":
msg.payload = "Session Ended";
return [null, msg];

default:
msg.payload = "Unrecognised Intent";
return [null, msg];
}

From: Alistair Young<EMAIL_ADDRESS>Sent: 18 February 2017 23:55
To: mattotodd/node-red-contrib-alexa<EMAIL_ADDRESS>Cc: Subscribed<EMAIL_ADDRESS>Subject: [mattotodd/node-red-contrib-alexa] All intents processed by same flow (#14)
I currently have three intents defined for my skill. Trouble is, whichever intent I invoke, either via voice or using the test page for the skill (by which latter means I know that the correct intent is named in the incoming .json), the same one intent is always invoked in node-red, and the other two are ignored.
Any thoughts?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHubhttps://github.com/mattotodd/node-red-contrib-alexa/issues/14, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AFA04120lzEqbxgpEdWbM4IuC4GTHe1Kks5rd4TmgaJpZM4MFTRk.

Scanned by MailDefender Plus, powered by Symantec Email Security.cloud

Scanned by MailDefender Plus, powered by Symantec Email Security.cloud


Tests\Integration\MSFT_xDSCWebService.Integration.tests.ps1: Create self signed certificate if missing

Pull Request (PR) description
Fixes issue where tests fail if a self signed certificate for DSC does not already exist.
This Pull Request (PR) fixes the following issues

Fixes #581

Task list

[x] Added an entry under the Unreleased section of the change log in
CHANGELOG.md. Entry should say what was changed, and how that affects
users (if applicable).
[ ] Resource documentation added/updated in README.md.
[ ] Resource parameter descriptions added/updated in README.md, schema.mof
and comment-based help.
[ ] Comment-based help added/updated.
[ ] Localization strings added/updated in all localization files as
appropriate.
[ ] Examples appropriately added/updated.
[ ] Unit tests added/updated. See
DSC Resource Testing Guidelines.
[x] Integration tests added/updated (where possible). See
DSC Resource Testing Guidelines.
[x] New/changed code adheres to
DSC Resource Style Guidelines and Best Practices

This change is

Codecov Report

Merging #601 into dev will not change coverage.
The diff coverage is n/a.

@@         Coverage Diff         @@
##            dev   #601   +/-   ##
===================================
  Coverage    74%    74%
===================================
  Files        27     27
  Lines      4078   4078
  Branches      4      4
===================================
  Hits       3038   3038
  Misses     1036   1036
  Partials      4      4

Would someone mind giving this one a code review? Thanks!


Better Error Messages

I am not sure if we are the only ones that run into this, but we have multiple projects in our solution and when large change are made we almost always get the following type of error, which is a pain to track down without digging up more information.
Server Error in '/WebUI' Application.
Unable to load one or more of the requested types. Retrieve the LoaderExceptions property for more information.
Description: An unhandled exception occurred during the execution of the current web request. Please review the stack trace for more information about the error and where it originated in the code.
Exception Details: System.Reflection.ReflectionTypeLoadException: Unable to load one or more of the requested types. Retrieve the LoaderExceptions property for more information.
Source Error:
An unhandled exception was generated during the execution of the current web request. Information regarding the origin and location of the exception can be identified using the exception stack trace below.
Stack Trace:
[ReflectionTypeLoadException: Unable to load one or more of the requested types. Retrieve the LoaderExceptions property for more information.]
System.Reflection.RuntimeModule.GetTypes(RuntimeModule module) +0
System.Reflection.Assembly.GetTypes() +159
System.ComponentModel.Composition.Hosting.AssemblyCatalog.get_InnerCatalog() +126
System.ComponentModel.Composition.Hosting.AssemblyCatalog.get_Parts() +9
lambda_method(Closure , ComposablePartCatalog ) +20
System.Linq.d__142.MoveNext() +267    System.Linq.<SelectManyIterator>d__142.MoveNext() +507
System.Collections.Generic.List1..ctor(IEnumerable1 collection) +472
MefContrib.Hosting.Interception.InterceptingCatalog.GetParts() +132
System.ComponentModel.Composition.Primitives.ComposablePartCatalog.GetExports(ImportDefinition definition) +139
MefContrib.Hosting.Interception.InterceptingCatalog.GetExports(ImportDefinition definition) +51
System.ComponentModel.Composition.Hosting.CatalogExportProvider.GetExportsCore(ImportDefinition definition, AtomicComposition atomicComposition) +188
System.ComponentModel.Composition.Hosting.ExportProvider.GetExports(ImportDefinition definition, AtomicComposition atomicComposition) +78
System.ComponentModel.Composition.Hosting.AggregateExportProvider.GetExportsCore(ImportDefinition definition, AtomicComposition atomicComposition) +212
System.ComponentModel.Composition.Hosting.ExportProvider.TryGetExportsCore(ImportDefinition definition, AtomicComposition atomicComposition, IEnumerable`1& exports) +47
System.ComponentModel.Composition.Hosting.CompositionContainer.GetExportsCore(ImportDefinition definition, AtomicComposition atomicComposition) +100
System.ComponentModel.Composition.Hosting.ExportProvider.GetExports(ImportDefinition definition, AtomicComposition atomicComposition) +78
System.ComponentModel.Composition.Hosting.ExportProvider.GetExports(Type type, Type metadataViewType, String contractName) +52
MefContrib.Web.Mvc.CompositionDependencyResolver.GetService(Type serviceType) +33

This is pretty rough but something like.
///
/// Resolves singly registered services that support arbitrary object creation.
///
/// The type of the requested service or object.
/// The requested service or object.
public object GetService(Type serviceType)
{
try
{
var exports = this.Container.GetExports(serviceType, null, null);
if (exports.Any())
{
return exports.First().Value;
}
}
catch (System.Reflection.ReflectionTypeLoadException ex)
{
string[] errors = ex.LoaderExceptions.Select(e => e.Message).ToArray();
string error = string.Join(Environment.NewLine, errors);
throw new Exception("Issue with loading type: " + error, ex);
}
return null;
}
@ line 82  in MefContrib.Web.Mvc\CompositionDependencyResolver.cs

Definitely would like to see this added...pain trying to find out which dll is missing/not loading