bug: Errors out when emptying search bar

I found these 2 "bugs" when testing some regex search.
If I press / to start searching, it works. I can keep searching and inputting normal words or Regular expressions and it parses them. The problem comes when I erase the text on the searchbox and go to completely empty again. Step by step:

I press / to start searching (I have Noice on for UI stuff):

I type what I want to search:

But when I erase to change my current search, this happens:

It does allow me to write again my search prompt, but it errors out. It is not a breaking bug, but it's inconvenient to get this error when I change my mind about the search I am doing.
I also did notice that my Neovim instance (NVIM v0.10.0-dev-642+gc44d819ae) freezes when the plugin is enabled and I try to search for (, [, {, and their closing brackets. If that is a WIP feature, do let me know

The hypersonic.lua in my Neovim config, for context:

return {
  "tomiis4/hypersonic.nvim",
  event = "CmdlineEnter",
  cmd = "Hypersonic",
  config = function()
    require("hypersonic").setup({
      -- config
    })
  end,
}

Thank you so much for spotting this. I'll fix this soon.

Cmdline searching error should be fixed in newest commit.
I made new issue for searching for () #14 because it will maybe take some time.


Pin pad scroll on iOS

Expected Behavior
Pin pad should not be scrollable.
Current Behavior

the pin pad on iOS is scrollable. When tapping my pin, i often end up scrolling by mistake and the input is not captured (video attached). Can we remove the scroll gesture capture on this screen?

Thread: https://celo-org.slack.com/archives/C018VLA3YAK/p1609877824085600

Hey @tarikbellamine   , We have verified this issue using latest Test flight build V 1.19.0 and Android internal build V1.19.0 & updated status in Gsuite.
GSuite Link: https://docs.google.com/spreadsheets/d/1bWi6smdTMClreG96sGjYxb2lee9Ja6eT4-Lm7eXm1gM/edit#gid=1462650076
Verified On Devices: OnePlus 7t (11.0) , iPhone 6+ (12.5.4), Redmi note 8 (10.0), iPhone 12 (14.7.1)
Observation:

Scroll bar is not seen where ever PIN pages are applicable
Attachment : Scrollbarnotseen.mp4
Verified on Devices : iPhone 6+ (12.5.4), iPhone 12 (14.7.1)

https://valora.testquality.com requirement R85.

Hey @MuckT We have verified this issue using latest Test flight build V 1.19.0 & updated status in Test Quality Tool
Test Quality Tool link:
iOS (13.0):

https://valora.testquality.com/project/12128/plan/21816/run/150277/result/2485054

Verified On Devices: iPhone SE (13.6.1)


database.positionsHistoryDays doesn't delete positions from database

Hello!
I can't seem to get database.positionsHistoryDays configuration option to work. It doesn't seem to delete anything from my database even though I have set the days to 3, and at least 4 days have already passed. See these pictures: http://imgur.com/a/dM7rN
I'm using XAMPP, these are my database details:
mysql  Ver 15.1 Distrib 10.1.21-MariaDB, for Win32 (AMD64)
libmysql - mysqlnd 5.0.11-dev - 20120503
Traccar version is 3.11 and below is my current traccar.xml
<?xml version='1.0' encoding='UTF-8'?>

<!DOCTYPE properties SYSTEM 'http://java.sun.com/dtd/properties.dtd'>

<properties>

    <entry key="config.default">./conf/default.xml</entry>

    <entry key='database.driver'>com.mysql.jdbc.Driver</entry>
    <entry key='database.url'>jdbc:mysql://<IP_ADDRESS>:3306/traccar?allowMultiQueries=true&autoReconnect=true&useUnicode=yes&characterEncoding=UTF-8&sessionVariables=sql_mode=''</entry>
    <entry key='database.user'>root</entry>
    <entry key='database.password'>password123</entry>
    <entry key='database.positionsHistoryDays'>3</entry>

</properties>

Thanks in advance!

Are you sure you didn't restart server during those 4 days?

I did actually, yes. But I've had this problem earlier also with the setting set to 1 and had the server running for several days, it still wouldn't clear the position history. Only way I seem to be able to clear it is to stop Traccar server and truncate the table manually, and then restart the server.

I have added a log message, so we can track database clear events.


[$500] iOS - Unable to scroll task description when adding a line break

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 1.3.91-6
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
Action Performed:

Open the app
Navigate to any conversation
Tap "+" icon and select "Assign task"
Enter a title
Enter a long description > 7 or copy a text with a line break
Add a line break

Expected Result:
User is able to scroll down and view all entered text with a line break, the cursor is in focus
Actual Result:
User is unable to scroll until a new line of text is entered, the cursor is out of focus. With copied text with a line break user is unable to view the text after a line break
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android: Native
[ ] Android: mWeb Chrome
[x] iOS: Native
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos

iOS: Native

https://github.com/Expensify/App/assets/78819774/b560b0ab-3778-48fa-85ad-5067920bde34

View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01b2f4496c506e6196
Upwork Job ID:<PHONE_NUMBER>746229248
Last Price Increase: 2023-11-16

Previously investigated in #20836
This bug on iOS is already mentioned in the code:
https://github.com/Expensify/App/blob/8c76d2aff5ebbaa11a951e4cdf85d1cadb6d6548/src/libs/UpdateMultilineInputRange/index.ios.js#L7-L8

Contributor details
Your Expensify account email<EMAIL_ADDRESS>Upwork Profile Link: https://www.upwork.com/freelancers/~01846a9cb226f097f4

@cubuspl42 what do you think of @Krishna2323's proposal?

@Krishna2323 While I get the general idea to use updateMultilineInputRange, I'm not sure how should I read your code snippet. Do you have a Git branch at hand?

@Krishna2323 bump on the question for you above.

I'm OOO all next week, going to assign another BZ member to manage while I'm out.

@Krishna2323 bump

Waiting for an updated proposal.
@Krishna2323, did you make progress on yours? Thanks!

@isabelastisser Could we hold on https://github.com/Expensify/App/issues/30707? We'll be working with precisely the mentioned code part there, and I wouldn't like to go in two different directions here.

@cubuspl42 we can hold for that issue. Just to make sure I understand, do you think the fix for that issue will fix this as well, or are the changes there a prerequisite to any changes we make here?

Depending on the specific proposal (as we don't have an acceptable one, for now), it can be either

Added the hold and changed the priority to weekly to match the hold issue.

I see that https://github.com/Expensify/App/issues/30707 (the issue we were holding this for) was closed yesterday as not reproduceable. @cubuspl42 @lanitochka17 do you mind checking if this one is still reproduceable? Switching back to daily.

Okay thanks, let's close.


Unable to download model weights

I can't find the weights after opening the webpage. Could you please provide a new download link? Thank you very much.

Hello, We moved to another university so all the old content on the Google Drive has been gone.
I can't find all the weight of comparative models in a short amount of time. However, I updated our MSBP models.
Thank you for your interest in our work. Cheers.
Model weights obtained from training MSBP here:
Colon checkpoint
Prostate checkpoint

Good job, thanks very much!

Updated links.


Improve Key Rollover management

[x] Be able to register future SP x509cert on the settings and publish it on SP metadata
[x] Be able to register more than 1 Identity Provider x509cert, linked with an specific use (signing or encryption
[x] Allow metadata to be retrieved from source containing data of multiple entities
[ ] Adapt IdP XML metadata parser to take care of multiple IdP certtificates and be able to inject the data obtained on the settings.

Coverage decreased (-0.07%) to 95.602% when pulling 728d51f5ef07b8f8e6ec16c1eaeb878739c5f44b on key_rollover_mngmt into f7a9652aced9a24666452f458302835bae12b62b on master.

Coverage decreased (-0.9%) to 94.805% when pulling 701d65ec467465b89db490fd602850cbf56401a3 on key_rollover_mngmt into f7a9652aced9a24666452f458302835bae12b62b on master.

Coverage decreased (-0.9%) to 94.812% when pulling 701d65ec467465b89db490fd602850cbf56401a3 on key_rollover_mngmt into f7a9652aced9a24666452f458302835bae12b62b on master.

Coverage decreased (-0.9%) to 94.752% when pulling 650d2b9efa1b8b6d6b155d420e46fb607803ec60 on key_rollover_mngmt into f7a9652aced9a24666452f458302835bae12b62b on master.


Add checking scanner errors

There is no error check on the scanner for the file.
 Codecov will compare coverage reports and display results in all future pull requests.
:information_source: You can also turn on project coverage checks and project coverage reporting on Pull Request comment
Thanks for integrating Codecov - We've got you covered :open_umbrella:


Carousel: No listeners for mobile carousels with data-bs-ride=boolean

Prerequisites

[X] I have searched for duplicate or closed issues
[X] I have validated any HTML to avoid common problems
[X] I have read the contributing guidelines

Describe the issue
Seems to be there for quite a long time.
The main issue is that if data-bs-ride is set to anything but carousel, the constructor() isn't called (whereas there's a check inside to avoid launch cycle()). This leads to unset (at least) touch listeners which, in mobile views, is kinda weird IMO.

I don't have the time to test it atm, but I think there's only a change on the selector would do the trick ?
Reduced test cases
Go on https://twbs-bootstrap.netlify.app/docs/5.2/components/carousel/#with-controls (which works well with mobile listeners)
Go on https://twbs-bootstrap.netlify.app/docs/5.2/components/carousel/#with-indicators (which is broken with mobile listeners until we click one button)
What operating system(s) are you seeing the problem on?
Windows
What browser(s) are you seeing the problem on?
Chrome, Firefox
What version of Bootstrap are you using?
5.2.2 (current_main_branch)

I am not sure if this is a bug 😕
http://localhost:9001/docs/5.2/components/carousel/#via-data-attributes

The data-bs-ride="carousel" attribute is used to mark a carousel as animating starting at page load. If you don’t use data-bs-ride="carousel" to initialize your carousel, you have to initialize it yourself. It cannot be used in combination with (redundant and unnecessary) explicit JavaScript initialization of the same carousel.

However, it can change behavior, auto-initializing itself, with one change on
https://github.com/twbs/bootstrap/blob/3377ca49a11bdfcf521803a391dcc3ddab86c655/js/src/carousel.js#L64
to const SELECTOR_DATA_RIDE = '[data-bs-ride]'

Oh, haven't seen it before you highlighted it! Thanks a lot for that!
Instead of a bug, could it be an enhancement for v5.3 or v6 ? or should it stay as-is ?

/cc @patrickhlauke please give us your opinion on this

Hi! I am new to the open source, I want to contribute and fix this issue.

so is the issue that currently the carousel is only auto-initialised when data-bs-ride="carousel" and otherwise it requires manual initialisation?
I'm guessing that auto-initialisation is not done for performance reasons (similar to why we don't auto-initialise popovers). and if performance is still a valid reason, it does make sense to me that it's opt-in except for ones that are set to automatically animated right away.
maybe we should make the need for manual initialisation (unless using data-bs-ride="carousel") more apparent/explicit in the docs?
also, don't the docs manually initialise all carousels? is that what's also missing?
alternatively, we could just have all carousels auto-initialise, or is that too much of a perf hit these days?

so is the issue that currently the carousel is only auto-initialised when data-bs-ride="carousel" and otherwise it requires manual initialisation?

Yes, IMO the carousels should be auto-initialized, but it might brings some breaking changes since people that were using it already initialize it.

I'm guessing that auto-initialisation is not done for performance reasons (similar to why we don't auto-initialise popovers). and if performance is still a valid reason, it does make sense to me that it's opt-in except for ones that are set to automatically animated right away.

I might be wrong but I feel like the constructor only brings listeners so I think it might be fine on perf issues (moreover, the listeners are set once there was a interaction with the carousel).

alternatively, we could just have all carousels auto-initialise, or is that too much of a perf hit these days?

Agree on this part modulo the breaking changes again 😄

As it seems a possible breaking change (these that initialize Carousel through constructor), maybe is better to postpone it for v6.
However, @louismaximepiton pointed something here. The carousel touch listeners are registered after the initialization, in contradiction with click event listeners that are registered on document

However, @louismaximepiton pointed something here. The carousel touch listeners are registered after the initialization, in contradiction with click event listeners that are registered on document

ah yes, event listeners should all register at the same time at initialisation, not just after first interaction

I had a hard time understanding why my carousel would not allow me to swipe unless I frist click on an indicator / control. To me this is a bug. At least there is nothing in the documentation that depicts this behavior.

yes, it's clearly a bug as far as i'm concerned. we just need somebody to tackle this now...

The solution is real simple if we are sure we want this attitude :)
https://github.com/twbs/bootstrap/issues/37295#issuecomment-1276830684

The solution is real simple if we are sure we want this attitude :) #37295 (comment)

i think it's even simpler than that: no need to check if there's a data-ride attribute at all, just attach the touch listeners on initialisation, all the time, just like with mouse listeners

So you propose to initialize carousels by default? (maybe it will break existing js implementations)
Note: The alternative, to listen globally for swipes, seems a bit eager, and at this point I cannot assure you if it will work easily.
For sure, if anyone wants to try, I will be glad to help him

The solution is real simple if we are sure we want this attitude :) #37295 (comment)

i think it's even simpler than that: no need to check if there's a data-bs-ride attribute at all, just attach the touch listeners on initialisation, all the time, just like with mouse listeners. touch functionality is not dependent on whether it autoscrolls or scrolls after first interaction.

it seems that the problem is in fact that our docs page does not explicitly initialise the carousels (apart from the auto-advancing ones which take care of themselves). so we don't actually do what we tell devs they need to do.
so i think we can either go for full-on auto-initialisation (which yes, may have a slight performance hit and possibly break existing sites that did actually read the docs and did their manual initialisation, so it'd be a breaking change), OR we modify our docs page to actually do the manual initialisation, and make it far more prominent in our docs page that authors MUST do this themselves (as currently that factoid is a bit hidden away)


Demo client usage

I'm a little confused about how to use the demo program quicrq_app.
Following the README, I first run quicrq_app in server mode,
./quicrq_app -q qlog -c ./ca/ca-cert.pem -k ./ca/server-key.pem -p 4433 -w ./tests server

The tests folder contains video1_source.bin.
And run quicrq_app in client mode,
./quicrq_app client localhost d 4433 get:video1_source.bin:./tmp

and the client only shows
QUICRQ Version 0.22, Picoquic Version 1.04a
Waiting for packets.

In this case, I try to connect the client directly to the server and no relay node was set up. Is this the right syntax for scenarios? I'm confused by *{{'get'|'post'}':'<url>':'<path>[':'<log_path>]';'}.
Update: I also tried to add a relay like this:
./quicrq_app -c ./ca/ca-cert.pem -k ./ca/server-key.pem -p 4434 -w ./tests relay localhost s 4433

and let the client to connect to the relay:
./quicrq_app client localhost s 4434 get:video1_source.bin:./tmp

Hi,
I also have the same problem. I can run a server like this:
./quicrq_app -p 3000 -c certs/cert.pem -k certs/key.pem server
QUICRQ Version 0.30, Picoquic Version <IP_ADDRESS>
Waiting for packets.

And the client:
./quicrq_app client <IP_ADDRESS> d 3000 get:tests/video1_source.bin:./tmp
QUICRQ Version 0.30, Picoquic Version <IP_ADDRESS>
Waiting for packets.

What am I doing wrong?

@VidarHUN You can check https://github.com/Quicr/quicrq/issues/104#issuecomment-1360082364

Thanks for the quick response. I somehow missed that issue...


Use setuptools, add some metadata

Among others, this allows creating and uploading wheels, which I recommend doing even for pure python packages.

:+1:  for all this !


[Bug]: Adding number-field creates error 500 'Window not defined' after refresh

Reproduction
add number-field component -> refresh page -> error 500 Window
Describe the bug
after adding the number-field with the code example from the site, it initially works. But once i refresh the page i receive a error 500: Window not defined.
After removing the compontent and import its fine again and can refresh my page successfully.
Here is the log i get (actual directory removed for privacy):
at ReactiveEffect.fn (path\node_modules\@vue\reactivity\dist\reactivity.cjs.js:1002:13) at ReactiveEffect.run (path\node_modules\@vue\reactivity\dist\reactivity.cjs.js:172:19) at get value [as value] (path\node_modules\@vue\reactivity\dist\reactivity.cjs.js:1014:109) at unref (path\node_modules\@vue\reactivity\dist\reactivity.cjs.js:1138:29) at Ne (/path/node_modules/radix-vue/dist/index.js:373:41) at Be (/path/node_modules/radix-vue/dist/index.js:579:13) at /path/node_modules/radix-vue/dist/index.js:591:12 at callWithErrorHandling (path\node_modules\@vue\runtime-core\dist\runtime-core.cjs.js:203:33) at getter (path\node_modules\@vue\runtime-core\dist\runtime-core.cjs.js:5848:22)
System Info
System:
    OS: Windows 10 10.0.19045
    CPU: (8) x64 Intel(R) Core(TM) i7-8565U CPU @ 1.80GHz
    Memory: 1.31 GB / 7.79 GB
  Binaries:
    Node: 21.1.0 - C:\Program Files\nodejs\node.EXE
    npm: 10.0.0 - ~\AppData\Roaming\npm\npm.CMD
  Browsers:
    Chrome: 127.0.6533.89
    Edge: Spartan (44.19041.1266.0), Chromium (127.0.2651.74)
    Internet Explorer: 11.0.19041.1566

Contributes

[ ] I am willing to submit a PR to fix this issue
[ ] I am willing to submit a PR with failing tests

https://stackblitz.com/edit/github-pnxbg5?file=app.vue


[test] @objc optional should always use a dynamic dispatch

Right now we're not being careful about 'optional' in witness tables for parseable interfaces; we're listing the requirement as the implementation even if the requirement is optional. As long as we don't optimize based on that information, though, we should be okay.

@swift-ci Please test

Build failed
Swift Test Linux Platform
Git Sha - 316d55736f6fb0d8c2523ea4ed461c696f80d733

@swift-ci Please test

Build failed
Swift Test Linux Platform
Git Sha - 316d55736f6fb0d8c2523ea4ed461c696f80d733

Build failed
Swift Test OS X Platform
Git Sha - 316d55736f6fb0d8c2523ea4ed461c696f80d733


Why not provide a Projection.dll for Native AOT?

Description of the new feature / enhancement
Why not provide a Projection.dll for Native AOT?
--------------
为什么不提供适配 Native AOT 的 Projection.dll 呢？

At present, we find that CsWinRT 2.1.X has been officially released, however, WinGet's winmd counterpart projection.dll is still stuck in older versions of CsWinRT, which is not compatible with the latest Native AOT. It's been almost a month now, and the Windows App SDK and Microsoft.webview2 have provided Projection.dll for CsWinRT version 2.1.X, WinGet's publicly available Nuget packages are still missing. So I would like to ask why it hasn't been updated yet?
--------------------------
目前，我们发现 CsWinRT 2.1.X 已经正式发布了，然而 WinGet 的 winmd 对应的 projection.dll 仍然停留在旧版本的 CsWinRT 中，这与最新的 Native AOT 不兼容。现在已经经过了将近一个月，Windows App SDK 和 Microsoft.Web.WebView2 已经提供了适用于 CsWinRT 2.1.X 版本的 Projection.dll，WinGet 已经公开的 Nuget 包到现在都没有任何下落。所以我想问一下为什么到现在都不更新？

especially Microsoft.WindowsPackageManager.ComInterop . This package includes the Microsoft. Deployment.Management.Winmd, this winmd was used by many open source projects, yet until now did not correspond to the Projection.dll
--------------------------
尤其是 Microsoft.WindowsPackageManager.ComInterop，这个包包含 Microsoft.Deployment.Management.winmd，这个 winmd 被很多开源项目所使用，然而到现在都没有对应的 Projection.dll

Proposed technical implementation details
No response

I believe that this new preview version has the projection you are requesting, including AOT support:
https://www.nuget.org/packages/Microsoft.WindowsPackageManager.ComInterop/1.10.90-preview

I believe that this new preview version has the projection you are requesting, including AOT support: https://www.nuget.org/packages/Microsoft.WindowsPackageManager.ComInterop/1.10.90-preview

Thank you very much, I noticed that the new version of nuget package has been shipped with Projection.dll, this issue can be closed at an appropriate time (such as the official release with projection.dll?)
非常感谢，我注意到新版本的 nuget 包中已经附带了 Projection.dll，这个 issue 可以在适当的时候关闭掉了（比如正式版附带 projection.dll 发布的时候？）


MIS Review: Text after Headings

Headings of Sections 6, 7, and 8 are followed immediately by subsection headings. Text that explain their general purposes would be helpful.

Updated by commit e436ce1


Extension list not showing all extensions

Hi -
The Bazaar admin page is only showing the first 5 rows of extensions.
(It seems like they are sorted alphabetically, and the last one I see is Beeta Emos UOL)
Search also only finds extensions from within these 5 lines.
Steps to reproduce

Installed Flarum using pockethold
Enable Bazaar
Click the Bazaar Tab

Expected behaviour
See a list of all available extensions
Actual behaviour
Only showing the first 5 rows of extensions
Version of Bazaar: 0.2.4

Woops no pagination buttons. You can still search though 😁
Thanks for reporting!

Search only shows results from the extensions shown...i.e, extensions whose names start from A to "Beeta". Can't get search to show anything else.
(I might have a different problem, though, since I can't install any of them. I get a "Your requirements could not be resolved to an installable set of packages" error. Perhaps once I get that solved it'll all work...)

@clarkwinkelmann can you do something about this on a short notice?

Just confirmed the issue. It's actually a flagrow.io issue, not Bazaar. I'm on it

Fix is ready, just waiting for our ops to push it to production :smile_cat:

@hamalrad should be fixed now. Don't hesitate to report any new issue.
Thanks again for your report !

Thanks!
All extensions showing now :-)


Explicitly add visionOS availability to tests that check availability.

Since https://github.com/apple/swift/pull/72834, the Swift compiler supports visionOS availability annotations. For completeness, add this platform to existing tests which declare Apple platform availability.

@swift-ci please test

Merging on Brian's behalf.


Remove legacy directory

This PR removes the legacy directory that was unused. Version tag can allow to find this piece of code if necessary.

@miguelglezb pinging you here. This is a relatively simple change, but you'll need to rebase main in case you have an active branch.

Solves #441


Incorrect values shown in Qt GUI for large, complex transaction

Describe the issue
I'm experiencing what I assume is a UI problem in Dash Core 18.2.1. I am trying to clean up a lot of mining outputs and consolidate it on the faucet, which requires sending a large transaction with a custom change address, in this case 4000 tDASH in an 80kb transaction. The values displayed in the confirmation dialog are completely incorrect if I select "Subtract fee from amount". It works fine if I don't select that checkbox.
Can you reliably reproduce the issue?
If so, please list the steps to reproduce below:

Have the testnet mining target wallet loaded (contains a single address, so must pay change to custom address)
Attempt to send 4000 tDASH to an address with/without Subtract fee from amount checkout checked
Observe different values displayed in GUI, incorrect when Subtract fee from amount is checked

Expected behaviour
The GUI should show the correct values
Actual behaviour
The GUI shows incorrect values when Subtract fee from amount is checked
Screenshots.

What version of Dash Core are you using?
v18.2.1 dash-qt
Machine specs:

OS: Fedora 37
CPU: AMD Ryzen 7 PRO 6850H
RAM: 32GB LPDDR5
Disk size: 2TB
Disk Type (HD/SDD): SSD

For the GUI-related issue on Linux provide names and versions of a distro, a desktop environment and a graphical shell (if relevant).
Fedora 37
Kernel 6.1.9
Gnome 43.2 (Wayland)

It may be some integer overflow or using unsigned int somewhere instead CAmount.
I read code around, but I can't spot a bug yet :disappointed:
Btw, I'd like to see 2 things.
if the cause related to integer signed overflow, sanitizer can help.
Need to build code like that:
make clean && ./autogen.sh && ./configure --prefix=$(pwd)/depends/x86_64-pc-linux-gnu  --with-sanitizers=signed-integer-overflow

After configure you should see this line:
sanitizers         = signed-integer-overflow

If the signed integer overflow will happen, sanitizer will spot an exact line in code where it happened.

There are also some logs included in build, that can be useful to localize issue such as
    WalletLogPrintf("Fee Calculation: Fee:%d Bytes:%u Tgt:%d (requested %d) Reason:\"%s\" Decay %.5f: Estimation: (%g - %g) %.2f%% %.1f/(%.1f %d mem %.1f out) Fail: (%g - %g) %.2f%% %.1f/(%.1f %d mem %.1f out)\n",

May be there's something useful appears in logs? Can you attach to issue the related logs also?


⚠ AtmoVantage Homepage has degraded performance

In 4f7a8a4, AtmoVantage Homepage (https://atmovantage.com) experienced degraded performance:

HTTP code: 200
Response time: 9913 ms

Resolved: AtmoVantage Homepage performance has improved in d477148.


Setup automated CI runner for pull requests

(per discussion in #31)
Though I'm not a big fan of Travis-CI, I can't deny that it has a killer free usage tier for open source projects. Either way, it would be loads better if we could have ANY CI system to run automated tests for the following:

[ ] pip install works without error
[ ] Automated tests are passing
[ ] Changelog has changed in at least one commit of the current pull request

I have a fair amount of experience getting TravisCI working (and actually have interacted with their engineering a few times) so this is something I can work on.

In that case, I may need your help on another open source project and some issues I've had with reading from PTY streams on Travis.

https://circleci.com/pricing/#build-linux
I've used CircleCI before, and it seems the free tier might work pretty well for us?

I personally would rather stick with TravisCI because I actually already have a dev box set up that mirrors their infrastructure, which makes debugging builds way faster. Also, TravisCI's limitations for build time seem more sane than CircleCI's -- for Travis, builds terminate automatically after 120 minutes, which is completely understandable. Circle just allows 1500 minutes of build time, which means if a job gets stuck, we don't notice, and it runs for 25 hours, we can't do testing for the rest of the month.

Seconded about CircleCI. I like it a lot better, if only for how it uses containers for test environments. From what I've found, the free usage tier isn't as nice as other solutions. More specifically, it seems usage time limits are scoped to the user account, not the project.
I'm less worried about a test hanging (because we should be testing locally too, right?) and more about us limiting other projects from using CircleCI that might not work with Travis, especially if we hook this up to run incoming pull requests through CI. And that's the dream here, right?
If we'd like to spend the time eventually, I'd love to figure out how to hook up Gitlab-CI runners to github, or otherwise take advantage of gitlab's pipelines here. It's pretty non-trivial though and we would be better served with an immediate, mostly-okay solution than a perfect one.

(TravisCI has the option to run everything in containers :P )
I'm doing some more research on this today. CircleCI seems valid -- most of my gripes come from not wanting to spread my projects out across different platforms that all do the same thing (since I'm already using TravisCI), but I also realize that this isn't really my project anymore ^_^

If Travis can handle containers (and I'd be very interested to see that) I'd highly recommend sticking with it. Free usage tier is much nicer and it's far more ubiquitous among projects on GitHub.

https://docs.travis-ci.com/user/ci-environment/#Virtualization-environments TravisCI runs containers by default unless you add sudo: required, which we might need for Tesseract; not sure yet. There is also built-in docker support: https://docs.travis-ci.com/user/docker/

I see some decisions only appeared in private conversations. To mirror here, I'm in favor of Travis CI since it appears to have comparable container support. What I'm most in favor of is running tests inside of a container like what gitlab-ci does. I could go on about what I like about gitlab, but for the sake of this issue, it appears too difficult to replicate on Travis or Circle CI.
Due to free usage tier limits and no significant benefit to Circle CI over Travis, that I can see, I'm voting for using Travis.


How about add the emoji support ?

Emoji like this http://www.emoji-cheat-sheet.com/.
Also list all internal support icons ?
When export, also export support icons ?
I think this will make text more colorful.

I am also missing them. Count it as vote up :+1: on this enhancement/feature

I would second this request.

Aren't GitHub emoji on some CDN already? Would be nice to have them rendered in StackEdit.

Any update?

Support for :+1: and others has been added in v5. To support shortcuts like :-) you have to add this to your files properties:
extensions:
  emoji:
    shortcuts: true

I've added it in Settings > Custom settings. But it didn't work. Any extra seetings need to be added?

That would be in Menu > File properties > YAML properties, or you can add default file properties for all new files in the settings:
newFileProperties: |
  extensions:
    emoji:
      shortcuts: true

Sorry to bother you
I'm using https://stackedit.io/app# on chrome browser. And usin the settings that you've shared. But it's not working

This will add properties to newly created files, so I guess it will work if you create a new file.

I've tried it in new file as well. Unfortunately it is not working.


btCommunityStoreProductListGroup needs a Primary Key

An exception occurred while executing 'DELETE FROM btCommunityStoreProductListGroups where bID = ?' with params ["426"]: SQLSTATE[HY000]: General error: 1105 Percona-XtraDB-Cluster prohibits use of DML command on a table (xxx.btCommunityStoreProductListGroups) without an explicit primary key with pxc_strict_mode = ENFORCING or MASTER

Whilst the lack of a primary key on a table may not cause any issues on standard hosting platforms, it is a show-stopper on a PXC cluster in strict mode. There may be other similar tables, I haven't checked. You might want to consider making this project strict-mode compliant as you go, to save problems in the future.
Rightly or wrongly, I have worked around this by adding an extra column as follows:
ALTER TABLE btCommunityStoreProductListGroups ADD pkey INT UNSIGNED NOT NULL AUTO_INCREMENT FIRST, ADD PRIMARY KEY (pkey);
I'm loving what Mesuva and the team are doing with this project and I'm just trying to help :)
EDIT: I've just taken a quick look at all the project db tables and everything else looks like it has a PK, so it's just this one that needs a tweak :)

I've added in a key for this table, via https://github.com/concrete5-community-store/community_store/commit/b949894fba4738a161c62ff67ebccfa2f9887b7d
I'm assuming that with PXC, a primary key can use multiple fields, which I've done instead of adding another column just for that purpose.

I've tried your suggested schema and it seems fine thanks :)


buildGoPackage: support go modules

set moduleDir to enable new behaviour, empty string for root module,
so it's backward compatible. When new behaviour enabled, it will:

omit submodules (subdirectoires which contains go.mod)
able to fetch specific submodules in a repo

make shellHook work with multiple major versions

Motivation for this change
To make vgo2nix work with go modules better, we find buildGoPackage need to handle some go modules rules:

omit submodules
fetch a specific submodule in a repo
change nix-shell to work with submodules or major versions.

Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ ] NixOS
[x] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[x] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

https://gist.github.com/yihuang/7e9e3cfb5ab3f126f077c1e5b66002ad
the test case that don't work before but works now.

support multiple major versions of same module
support different minor versions of different modules in same repo

Closing this, since gomod2nix is better.


Support access control on FBP protocol

Right now anyone who can find the address/port of the service can connect. Which is obviously unsafe, especially once supporting adding components, as these may execute arbitrary code.
When access control is enabled, we must check and enforce the secret which is passed on each message of the protocol.
Should be able to set a default access level (when there is no secret provided).
For instance all access, no access, read-only access.

Also have to make sure that we don't accidentially leak the secret, especially when doing acknowledgements with sendAll.

Changing/adding component source should probably be its own level, as this essentially allows arbitrary code execution on the host.


Initial work on unstable-trait feature for stm32

Implements async traits for exti for now.

:rocket: !!!!
It seems you accidentally commited some stm32-metapac changes though

bors r+


Building shaders (.glsl)

🚀 Feature request
Command (mark with an x)

[ ] new
[X] build
[ ] serve
[ ] test
[ ] e2e
[ ] generate
[ ] add
[ ] update
[ ] lint
[ ] extract-i18n
[ ] run
[ ] config
[ ] help
[ ] version
[ ] doc

Description
It is not possible to build shaders for webGL. I tried to use @angular-builders/custom-webpack to add rule for importing .glsl files to ts files but it doesnt work because of .
Describe the solution you'd like
I would be great to add ability to import shaders (import vertex from './my-vertex-shader.glsl'). It's a plain text actualy so it wont be a problem I think.
Describe alternatives you've considered
A lot of angular developers have to put shaders to assets and download them via http-client. But what if I dont want to make a request. It can be bad for users and it's not comfortable for developers. It's much easier to import it.

Hi @RCnowak,
Thanks for this request.
Angular CLI doesn't support Webpack specific features, importing a non JS module (ie: import vertex from './my-vertex-shader.glsl') is non standard JavaScript behavior and only works because of tools like Webpack.
Hence, using a 3rd party solutions that extends the Angular CLI is the recommended approach if you don't wish to fetch the assets via HTTP.  I suggest you file an issue with the author of @angular-builders/custom-webpack for support.


IDVA6-2033: Updated parent-pom

Short description outlining key changes/additions
Updated parent-pom
JIRA Ticket Number
IDVA6-2033
Type of change

[ ] Bug fix
[x] New feature
[ ] Breaking change
[x] Infrastructure change

Pull request checklist

[x] I have added unit tests for new code that I have added
[x] I have added/updated functional tests where appropriate
[x] The code follows our coding standards

An exhaustive list of peer review checks can be read here

CI: No security warnings found


fix(curriculum): simplify challenge "Access Props Using this.props"

Checklist:

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)
[x] My pull request targets the main branch of freeCodeCamp.
[x] I have tested these changes either locally on my machine, or GitPod.

Closes #42574

do I need to rebase it to avoid the lint test failing?


[Enhancement] Add options to disable nameplate on nonhostile mobs and mob name display

An option to only display nameplate on hostile mobs would be great, cuz nameplates are usually not desirable in the circumstances of animal farms or pets.
For named mobs, the nameplate will overlap with Vanilla nametag displays.
Though it may be weird to have Nameplate not displaying mobs' names, adding an option to disable mob name display can make Nameplate more visually compatible with Orderly, a mob health bar mod.

Added hostile only config with https://github.com/Globox1997/Nameplate/commit/9d13379cf7785eed974a2a3413e418f744f37de2
The second one is at least with only this mod working
The third option already exists, check the config :)


Path-based source pypi distributions

Checks

[X] I have checked that this issue has not already been reported.

[X] I have confirmed this bug exists on the latest version of pixi, using pixi --version.

Reproducible example
https://github.com/kcheng1021/GaussianPro
wanted to try out the most recent pixi import from a conda environment from a the recently released GaussianPro model and get the following error from this environment.yml
pixi init --import environment.yml

environment.yml file
name: gaussianpro
channels:
  - pytorch
  - conda-forge
  - defaults
dependencies:
  - cudatoolkit=11.6
  - plyfile=0.8.1
  - python=3.7.13
  - pip=22.3.1
  - pytorch=1.12.1
  - torchaudio=0.12.1
  - torchvision=0.13.1
  - tqdm
  - pip:
    - submodules/diff-gaussian-rasterization
    - submodules/simple-knn

error
pixi init --import environment.yml
  × Expected one of `@`, `(`, `<`, `=`, `>`, `~`, `!`, `;`, found `/`
  │ submodules/diff-gaussian-rasterization
  │           ^

Issue description
Looks to be an issue with Path-based source pypi distributions
Expected behavior
Should install each pypi package

We currently don't support path based distributions. This will be coming soon!

Closing this in favor of #879


Saner error handling

Some of the functions to query status returned booleans indicating error. I think it's better to return Result. Also, this makes it easier to implement a wrapper for the WireguardAdapterGetState function.

Commit merged in #17


Disclaimer regarding exported file format

Details on issue #9147
Better write some disclaimer that the exported audio file has a little difference from the support audio files by call queues.
You can not use the content on import-csonlineaudiofile as is and needs to be converted by the MS supported audio formats

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 9628a1c2-c7d3-cff5-4049-30ecd65e02dc
Version Independent ID: c6c34c02-4e8b-ea0c-c0d3-e767063af0a5
Content: Export-CsOnlineAudioFile (SkypeForBusiness)
Content Source: skype/skype-ps/skype/export-csonlineaudiofile.md
Service: skypeforbusiness-powershell
GitHub Login: @JensTrier
Microsoft Alias: jenstr

@TheITguy666 Please provide the Microsoft support case/reference number, so I can follow-up on this

[Case #:30310338]

I'll investigate and update as necessary

@JensTrier
Final answer from MS support case:
"Having consulted with the internal Team confirm the below answer to your queries.

What is the export-csonlineaudiofile useful for?:
-------- The Export-CsOnlineAudioFile cmdlet downloads an existing Auto Attendant (AA), Call Queue (CQ) service or Music on Hold audio file
Was supposed to be like this?: Yes
Is it planned to work in the future?:
------Not for now
Is there a chance to use powershell to convert it to a supported audio to be used by import-csonlineaudiofile?:
 -----No such plan for now

Please if you need any clarification, do not hesitate to revert, we will be glad to assist.

I asked to close the ticket. The command has little use for my case as I wanted to use to generate a new call queue from an existing one :(

@JensTrier Please update and help us in resolving this issue. Thanks

We do support importing exported audio files. The catch is that an exported audio file is always in WAV format, so should be saved as such. I have a PR out to update the documentation to reflect this

@TheITguy666 Hope this comment is helpful for you. If you see a documentation update is required, please feel free to open an issue for the same. We proceed here to close it. Thanks for taking out some time to open the issue. Appreciate and encourage you to do the same in future also.

@yogkumgit
I have open an incident at MS  Ticket #30310338 that was closed with the opposite statement:
"Hello Luis,
Thank you for the response.
The cmdlet import-csonlineaudiofile is not designed to be reused. I sincerely apologize for the inconveniences you must have experienced, and I understand it would have eased the business process if you are able to reuse the cmdlet import-csonlineaudiofile
As you requested for the ticket to be archived, I will proceed to close the ticket.  Please feel free to revert, in the future if you experience any technical issues, we will be glad to assist.
Here is a summary of the issue:
Issue Description:
Export-CsOnlineAudioFile is not usable for uploading?
You were informed that the cmdlet import-csonlineaudiofile is not reusable to import file that have already been exported form the system, as these will alter the file format and properties.
Please do have a great day
Best Regards,
Uthman
Support Engineer Microsoft 365
For Microsoft Customer Service & Support "

But you are right.
It was a bit misleading since the file is stored with the original name (example: music.wma or music.mp3) I assumed that the export-csonline audiofile would get the same.
It works if you define the filename as .wav when uploading
Thanks for clarifying. It was more efficient than the 3 weeks with MS Support
Maybe a statement informing that the exported content is always WAV could help since the import-csonlineaudiofile supports 3 formats (but at the end it converts to wav ?)

Yes, that statement is in this PR https://github.com/MicrosoftDocs/office-docs-powershell/pull/9243


Add a test for swift split debug-info

Re-upload of https://github.com/apple/swift-lldb/pull/289 onto upstream-with-swift, rebasing past buildbot failures (at least the macOS ones, looks like linux may still be failing).

Looks like master (or whatever the README links to) is still red. @dcci - Not sure how to proceed here. I have this patch, #288, plus another bug fix in preparation locally.

@fjricci we finally got our stuffs together and we agreed that the flow is that of pushing to stable and then up porting to upstream-with-swift. Feel free to rebase/change the branch to which this PR points to, and run test & merge again. (hopefully all the outstanding issues should be sorted out, crossing fingers).
Thanks!

will re-open against stable


ENG-7825 - Capture CREATE_SESSION and METADATA event on new flow

Anyone reason to not use the createSession convenience method here instead?

We don't want to clear out the sessionID because its all one session, we just need these events as markers for DS


1321 add dropdown button variant

Summary of the changes
Add dropdown option to button, add cypress tests. Also add icPopoverClosed event to help users using the dropdown with popover menu.
Related issue
#1321
Checklist

[x] Relevant unit tests and visual regression tests added.
[x] Visual testing against Figma component specification completed.
[x] All acceptance criteria reviewed and met.
[x] Accessibility Insights FastPass performed.
[x] A11y unit test added and yields no issues.
[x] A11y plug-in on Storybook yields no issues.
[x] Manual screen reader testing performed using NVDA and VoiceOver.
[x] Page can be zoomed to 400% with no loss of content.
[x] Screen magnifier used with no issues.
[x] Text resized to 200% with no loss of content.
[x] Text spacing increased as per the WCAG 1.4.12 success criterion with no loss of content.
[x] Browser setting 'prefers reduced motion' tested. No animations or motion visible whilst this setting is on.
[x] Windows High Contrast mode tested with no loss of content.
[x] System light and dark mode tested with no loss of content.
[x] Manual keyboard testing for keyboard controls and logical focus order.
[x] Min/max content examples tested with no loss of content or overflow.
[x] Browser support tested (Chrome, Safari, Firefox and Edge).
[x] Correct roles used and ARIA attributes used correctly where required.
[x] Logical heading structure is maintained, and the HTML elements used for headings can be changed to fit within the wider page structure.
[x] All prop combinations work without issue.
[x] Changes to docs package checked and committed.

There seems to be extra padding on the right... does this match the designs? Worth having @DBD324 looking into this also.

I noticed that as well. It does seem to match the designs though. @DBD324 did mention this yesterday saying that they were worried that if there was no left icon it might look too big but they left it as is.

There seems to be extra padding on the right... does this match the designs? Worth having @DBD324 looking into this also.

I noticed that as well. It does seem to match the designs though. @DBD324 mentioned this yesterday while having a look at it, saying that they were worried that if there was no left icon it might look too big but they left it as is.

Nice! I still believe that the padding looks off. After some research and looking at others already available online they do not have this extra padding. For instance:

Flowbite
Core UI
React

and so on...
This would be a question to @DBD324... has this been taken in consideration. Have you looked at the other sources out there? Why is there extra space and padding? Is this necessary as it looks out of place and should be symmetrical to the left side?

There seems to be extra padding on the right... does this match the designs? Worth having @DBD324 looking into this also.

I noticed that as well. It does seem to match the designs though. @DBD324 mentioned this yesterday while having a look at it, saying that they were worried that if there was no left icon it might look too big but they left it as is.

Nice! I still believe that the padding looks off. After some research and looking at others already available online they do not have this extra padding. For instance:

Flowbite
Core UI
React

and so on...
This would be a question to @DBD324... has this been taken in consideration. Have you looked at the other sources out there? Why is there extra space and padding? Is this necessary as it looks out of place and should be symmetrical to the left side?

Apologies for delayed response. Originally this padding was intentional to simplify the button development and keen it consistent. The right hand padding doesn't look too imbalanced when you use a decorative icon on the button at the same time.
However, I have played around with it and tested a few different icon options and I agree we should reduce the right padding to 8px from 16px to account for the visual alignment issue caused by the small glyph within the dropdown icon. The left padding should remain at 16px though.


add:create new branch with updated files

This PR introduces an automated workflow to streamline the process of updating Microsoft Go versions for Azure Linux. Whenever a new Microsoft Go release is published, the following actions are automatically triggered:
Updating the specfile with changelog,
Updating the download URL and version in cgmanifest.json,
Updating the signature hash and download URL link in signatures.json.

@mertakman the tests are failing now

@mertakman the tests are failing now

Fixed


How do we want to handle database schema migrations

I am not sure what the best or standard way to do this is and how it would interact with high availability etc. Since we probably will have a migration eventually it would be good to plan this.
We probably would have migration postgres scripts and we could store a schema version in the db. But not sure if we would run those scripts automatically or manually or how to test them. For testing once we have a prod setup we could probably clone the database to staging and the test the migration and new code using the new schema there.

I was thinking if for now we could run a "migration" script before our service starts up. This way, once we implement the "ready" route, a previous pod would not shut down until the migration and new version is ready to be used. This would however only work for backwards compatible upgrades.
For more complex upgrades, likely need to complementary copies of the data and some job to replicate new entries between schemas until it's fully deprecated (e.g. until staging reaches prod as you pointed out).

Anxo linked us https://flywaydb.org/ (haven't looked into it yet).

We started using flyway and so far it has been quite good.


Create Instance modal spuriously erase the Instance Name input

Using the Playwright E2E tests we found and edge case where in the Kafka Creation modal:

the Instance name gets filled by Playwright
the instance name field gets blanked
the Create Instance gets clicked by Playwright

We are under the impression that something async in background is cleaning up the input field before the button is clicked.
Those are the traces trace.zip.

We observed the same happening in the Kafka Delete modal where the name of the instance gets erased.

We attempted to workaround the issue by "typing" the name, but this trace shows that the problem still occurs:
trace.zip
As you can notice the async action of cleaning the input happens > 200 ms after the first character has been typed.


Question: [t<N] Decryption Following Public Key Generation?

I am running into some issues decrypting after a public key generation protocol using Lattigo. I am wondering if I am doing something wrong, and was hoping the devs could correct any misunderstandings I have.
My understanding of the generation protocol from a high level is this:

Each party i generates a secret s_i'
Each party generates a random polynomial f_i(x) such that f_i(0) => s_i'
Each party sends every other party j (including themselves) f_i(j)
Each party i sums every share they received from j to create a new secret sum(f_j(i) for all j) => s_i
Each party posts publicly a public key generated from a common public A and secret error e_i: A*s_i+e_i => pk_i
Each party sums the public pk_i's to generate a final public key for the scheme: sum(pk_i for all i) => pk

This is all fine and it seems to match well the implementation provided by Lattigo. However, I'm a bit confused by Lattigo's implementation of the decryption steps. Generally, I would expect decryption to work roughly as follows:

Given a public ciphertext encrypted for pk: encrypt(plaintext, pk) => ct
Each party i performs a decrypt operation using their private key, adding a small amount of error: decrypt(ct, s_i) + e_i =>  pt_i
Each party sends partial plaintext pt_i to the receiving party
The receiving party performs lagrange interpolation on the received pt_i shares sum(pt_i * lagrange(i) for i) => pt
The result, pt, is the original plaintext

However, Lattigo seems to do decryption differently. When following the MHE readme and natural flow of the code, the lagrange coeffecient is multiplied by the secret keys prior to partially decrypting, rather than after. So, step 8 actually looks like decrypt(ct, s_i * lagrange(i)) => pt_i and step 10 is simply sum(pt_i). This feels odd, as decryption generally involves addition/subtraction and it is unclear to me how multiplying by the lagrange coeff prior to that would affect the final result. In addition, assuming this works, it requires each party to know ahead of time which shares will be aggregated, which may not always be the case.
Alas, when I tried to implement this, the code runs successfully but I cannot seem to actually reconstitute the plaintext:
	params, err := rlwe.NewParametersFromLiteral(rlwe.ExampleParametersLogN14LogQP438)
	if err != nil {
		panic(err)
	}
	fmt.Println(params)

	crs, err := sampling.NewPRNG()
	if err != nil {
		panic(err)
	}
	fmt.Println(crs)

	kgen := rlwe.NewKeyGenerator(params)
	// each party generates a key
	sk1 := kgen.GenSecretKeyNew()
	sk2 := kgen.GenSecretKeyNew()
	sk3 := kgen.GenSecretKeyNew()

	// each party generates a polynomial
	thr := mhe.NewThresholdizer(params)
	poly1, err := thr.GenShamirPolynomial(2, sk1)
	if err != nil {
		panic(err)
	}
	poly2, err := thr.GenShamirPolynomial(2, sk2)
	if err != nil {
		panic(err)
	}
	poly3, err := thr.GenShamirPolynomial(2, sk3)
	if err != nil {
		panic(err)
	}

	// each party generates shares for each party
	poly1_1 := thr.AllocateThresholdSecretShare()
	poly1_2 := thr.AllocateThresholdSecretShare()
	poly1_3 := thr.AllocateThresholdSecretShare()
	poly2_1 := thr.AllocateThresholdSecretShare()
	poly2_2 := thr.AllocateThresholdSecretShare()
	poly2_3 := thr.AllocateThresholdSecretShare()
	poly3_1 := thr.AllocateThresholdSecretShare()
	poly3_2 := thr.AllocateThresholdSecretShare()
	poly3_3 := thr.AllocateThresholdSecretShare()
	thr.GenShamirSecretShare(1, poly1, &poly1_1)
	thr.GenShamirSecretShare(2, poly1, &poly1_2)
	thr.GenShamirSecretShare(3, poly1, &poly1_3)
	thr.GenShamirSecretShare(1, poly2, &poly2_1)
	thr.GenShamirSecretShare(2, poly2, &poly2_2)
	thr.GenShamirSecretShare(3, poly2, &poly2_3)
	thr.GenShamirSecretShare(1, poly3, &poly3_1)
	thr.GenShamirSecretShare(2, poly3, &poly3_2)
	thr.GenShamirSecretShare(3, poly3, &poly3_3)

	// those shares are distributed accordingly and each party sums to create a new secret
	tmp := thr.AllocateThresholdSecretShare()
	t_sk1 := thr.AllocateThresholdSecretShare()
	t_sk2 := thr.AllocateThresholdSecretShare()
	t_sk3 := thr.AllocateThresholdSecretShare()
	thr.AggregateShares(poly1_1, poly2_1, &tmp)
	thr.AggregateShares(tmp, poly3_1, &t_sk1)
	thr.AggregateShares(poly1_2, poly2_2, &tmp)
	thr.AggregateShares(tmp, poly3_2, &t_sk2)
	thr.AggregateShares(poly1_3, poly2_3, &tmp)
	thr.AggregateShares(tmp, poly3_3, &t_sk3)

	ckg := mhe.NewPublicKeyGenProtocol(params)
	pp1_3 := []mhe.ShamirPublicPoint{1, 3}
	pp2_3 := []mhe.ShamirPublicPoint{2, 3}
	pp1_2 := []mhe.ShamirPublicPoint{1, 2}
	pp1_2_3 := []mhe.ShamirPublicPoint{1, 2, 3}

	// Just a type conversion from a shamir point into an actual secret key
	com1 := mhe.NewCombiner(*params.GetRLWEParameters(), 1, pp2_3, 2)
	com2 := mhe.NewCombiner(*params.GetRLWEParameters(), 2, pp1_3, 2)
	com3 := mhe.NewCombiner(*params.GetRLWEParameters(), 3, pp1_2, 2)
	com1.GenAdditiveShare(pp1_2_3, 1, t_sk1, sk1)
	com2.GenAdditiveShare(pp1_2_3, 2, t_sk2, sk2)
	com3.GenAdditiveShare(pp1_2_3, 3, t_sk3, sk3)

	// Generate public shared 'A'
	crp := ckg.SampleCRP(crs)

	// Generate public key from each private key
	pk1 := ckg.AllocateShare()
	pk2 := ckg.AllocateShare()
	pk3 := ckg.AllocateShare()
	ckg.GenShare(sk1, crp, &pk1)
	ckg.GenShare(sk2, crp, &pk2)
	ckg.GenShare(sk3, crp, &pk3)

	// sum up the public keys to generate a master public key
	pk_sum := ckg.AllocateShare()
	tmp2 := ckg.AllocateShare()
	ckg.AggregateShares(pk1, pk2, &tmp2)
	ckg.AggregateShares(tmp2, pk3, &pk_sum)

	// type conversion to create actual pk
	pk := rlwe.NewPublicKey(params)
	ckg.GenPublicKey(pk_sum, crp, pk)

	// encrypt something with our new pk! Just use a plaintext of all zeros
	pt := rlwe.NewPlaintext(params, params.MaxLevel())
	encr := rlwe.NewEncryptor(params, pk)
	ct, err := encr.EncryptNew(pt)
	if err != nil {
		panic(err)
	}

	// Each party partially decrypts the ciphertext by doing a keyswitch to a secret key of '0'
	sk0 := rlwe.NewSecretKey(params)
        // for testing only, zero the noise flooding parameters to remove this as a factor that could be causing issues
	ksw, err := mhe.NewKeySwitchProtocol(params, ring.DiscreteGaussian{Sigma: 0 * rlwe.DefaultNoise, Bound: 0 * 8 * rlwe.DefaultNoise})
	if err != nil {
		panic(err)
	}
	sh1 := ksw.AllocateShare(params.MaxLevel())
	sh2 := ksw.AllocateShare(params.MaxLevel())
	sh3 := ksw.AllocateShare(params.MaxLevel())
	ksw.GenShare(sk1, sk0, ct, &sh1)
	ksw.GenShare(sk2, sk0, ct, &sh2)
	ksw.GenShare(sk3, sk0, ct, &sh3)

	// Shares are aggregated
	sh := ksw.AllocateShare(params.MaxLevel())
	sh_tmp := ksw.AllocateShare(params.MaxLevel())
	ct_new := ct.CopyNew()
	ksw.AggregateShares(sh1, sh2, &sh_tmp)
	ksw.AggregateShares(sh_tmp, sh3, &sh)
	ksw.KeySwitch(ct, sh, ct_new)

	// actually decrypt
	dec := rlwe.NewDecryptor(params, sk0)
	pt_new := dec.DecryptNew(ct_new)

	// should be zeros, but fails and produces a seemingly random output
	fmt.Println(pt_new)

Ultimately I have two questions:

What do I need to do differently in the above code to make [t<N] secret sharing work?
Why multiply lagrange(i) by s_i ahead of partial decryption?

Thanks!!
Andrew

Hi @aklitzke,
Your observation that Lattigo's implementation of T-out-of-N-threshold decryption is different from the "usual" ones is correct. It is based on the scheme of this paper, for which it is a  requirement to know the group of >=T parties participating to the decryption before generating the decryption shares.
Here is the flow of this scheme:

Given a public ciphertext encrypted for pk: encrypt(plaintext, pk) => ct and a decryption group P' subset of P (the set of all parties) of size T.
Each party compute the Lagrange coefficient for its own share s_i in the reconstruction among group P', and pre-multiply it to their s_i  => s_{i, P'}
The parties execute the usual decryption protocol, yet with s_{i,P'} (their additive T-out-of-T share) instead of s'_i (their additive N-out-of-N share).

In the above, step 2 is implemented with the drlwe.Combiner type, the use of which is not exactly correct in your code. The NewCombiner method takes all ShamirPublicPoint public points (pp1_2_3 in your code) as its other parameter. Then, the GenAdditiveShare method lets you compute the  s_{i, P'} of step 2.
Note: The reason for implementing a more restricted scheme is that there isn't yet (to the best of our knowledge) any scheme that implements the "traditional" T-out-of-N-decryption flow. In a nutshell, the problem is that you cannot simply multiply your decryption shares by the Lagrange coefficient, because this would make the noise blow up. The above scheme circumvent this limitation as pre-multiplying the coefficient to the secret does not affect the noise.

Thanks for the reply! The approach you describe makes sense: to control the error from growing when multiplying by Lagrange coefficients you multiply the secret key by them ahead of partial decryption. Got it, makes a lot of sense and I like the approach. It's smart.
However, I still can't get the library to work. I did what you suggested and passed pp1_2_3 into NewCombiner:
	com1 := mhe.NewCombiner(*params.GetRLWEParameters(), 1, pp1_2_3, 2)
	com2 := mhe.NewCombiner(*params.GetRLWEParameters(), 2, pp1_2_3, 2)
	com3 := mhe.NewCombiner(*params.GetRLWEParameters(), 3, pp1_2_3, 2)
	com1.GenAdditiveShare(pp1_2_3, 1, t_sk1, sk1)
	com2.GenAdditiveShare(pp1_2_3, 2, t_sk2, sk2)
	com3.GenAdditiveShare(pp1_2_3, 3, t_sk3, sk3)

However, decryption still produced seemingly random output. I'm not sure I understand your suggestion. It's important that all parties keys are passed into GenAdditiveShare. However, when taking a look at the NewCombiner(...) source in threshold.go:
	// precomputes lagrange coefficient factors
	cmb.lagrangeCoeffs = make(map[ShamirPublicPoint]ring.RNSScalar)
	for _, spk := range others {
		if spk != own {

because of the spk != own check, NewCombiner will produce the same output whether or not a parties 'own' point is passed into others. Maybe I'm misunderstanding your suggestion?

Hi,
I believe the problems in your code are the following:

the GenAdditiveShare is supposed to be called to obtain t-out-of-t shares for each new group of size >= t among which you want to perform a protocol.
the GenShare method of the protocol needs to use the generated t-out-of-t share.
When using the rlwe package directly (and not BFV/BGV/CKKS), you must specify if the plaintext pt is not NTT.  This shouldn't change anything for pt=0 so there's maybe some thing we can improve on the library side to make it smoother.
The final decryption will not be zero because of the noise (because you aren't using any encoding/decoding when using the rlwe package directly).

Here is an updated main to illustrate the above (look for // EDIT: comments).
package main

import (
	"fmt"

	"github.com/tuneinsight/lattigo/v5/core/rlwe"
	"github.com/tuneinsight/lattigo/v5/mhe"
	"github.com/tuneinsight/lattigo/v5/ring"
	"github.com/tuneinsight/lattigo/v5/utils/sampling"
)

func main() {
	params, err := rlwe.NewParametersFromLiteral(rlwe.ExampleParametersLogN14LogQP438)
	if err != nil {
		panic(err)
	}
	fmt.Println(params)

	crs, err := sampling.NewPRNG()
	if err != nil {
		panic(err)
	}
	fmt.Println(crs)

	kgen := rlwe.NewKeyGenerator(params)
	// each party generates a key
	sk1 := kgen.GenSecretKeyNew()
	sk2 := kgen.GenSecretKeyNew()
	sk3 := kgen.GenSecretKeyNew()

	// each party generates a polynomial
	thr := mhe.NewThresholdizer(params)
	poly1, err := thr.GenShamirPolynomial(2, sk1)
	if err != nil {
		panic(err)
	}
	poly2, err := thr.GenShamirPolynomial(2, sk2)
	if err != nil {
		panic(err)
	}
	poly3, err := thr.GenShamirPolynomial(2, sk3)
	if err != nil {
		panic(err)
	}

	// each party generates shares for each party
	poly1_1 := thr.AllocateThresholdSecretShare()
	poly1_2 := thr.AllocateThresholdSecretShare()
	poly1_3 := thr.AllocateThresholdSecretShare()
	poly2_1 := thr.AllocateThresholdSecretShare()
	poly2_2 := thr.AllocateThresholdSecretShare()
	poly2_3 := thr.AllocateThresholdSecretShare()
	poly3_1 := thr.AllocateThresholdSecretShare()
	poly3_2 := thr.AllocateThresholdSecretShare()
	poly3_3 := thr.AllocateThresholdSecretShare()
	thr.GenShamirSecretShare(1, poly1, &poly1_1)
	thr.GenShamirSecretShare(2, poly1, &poly1_2)
	thr.GenShamirSecretShare(3, poly1, &poly1_3)
	thr.GenShamirSecretShare(1, poly2, &poly2_1)
	thr.GenShamirSecretShare(2, poly2, &poly2_2)
	thr.GenShamirSecretShare(3, poly2, &poly2_3)
	thr.GenShamirSecretShare(1, poly3, &poly3_1)
	thr.GenShamirSecretShare(2, poly3, &poly3_2)
	thr.GenShamirSecretShare(3, poly3, &poly3_3)

	// those shares are distributed accordingly and each party sums to create a new secret
	tmp := thr.AllocateThresholdSecretShare()
	t_sk1 := thr.AllocateThresholdSecretShare()
	t_sk2 := thr.AllocateThresholdSecretShare()
	t_sk3 := thr.AllocateThresholdSecretShare()
	thr.AggregateShares(poly1_1, poly2_1, &tmp)
	thr.AggregateShares(tmp, poly3_1, &t_sk1)
	thr.AggregateShares(poly1_2, poly2_2, &tmp)
	thr.AggregateShares(tmp, poly3_2, &t_sk2)
	thr.AggregateShares(poly1_3, poly2_3, &tmp)
	thr.AggregateShares(tmp, poly3_3, &t_sk3)

	ckg := mhe.NewPublicKeyGenProtocol(params)
	pp1_3 := []mhe.ShamirPublicPoint{1, 3}
	pp1_2 := []mhe.ShamirPublicPoint{1, 2}
	pp1_2_3 := []mhe.ShamirPublicPoint{1, 2, 3}

	// EDIT: create the parties' Combiners
	com1 := mhe.NewCombiner(*params.GetRLWEParameters(), 1, pp1_2_3, 2)
	com2 := mhe.NewCombiner(*params.GetRLWEParameters(), 2, pp1_2_3, 2)
	com3 := mhe.NewCombiner(*params.GetRLWEParameters(), 3, pp1_2_3, 2)

	// Generate public shared 'A'
	crp := ckg.SampleCRP(crs)

	// Generate public key from each private key

	// EDIT: step 1, obtain the parties' 2-out-of-2 additive shares
	sk12_1, sk12_2 := rlwe.NewSecretKey(params), rlwe.NewSecretKey(params)
	com1.GenAdditiveShare(pp1_2, 1, t_sk1, sk12_1)
	com2.GenAdditiveShare(pp1_2, 2, t_sk2, sk12_2)

	// step 2: run the CKG protocol among 2 parties, **with the 2-out-of-2 keys**
	pk1 := ckg.AllocateShare()
	pk2 := ckg.AllocateShare()
	ckg.GenShare(sk12_1, crp, &pk1)
	ckg.GenShare(sk12_2, crp, &pk2)

	// sum up the public keys to generate a master public key
	pk_sum := ckg.AllocateShare()
	ckg.AggregateShares(pk1, pk2, &pk_sum)

	// type conversion to create actual pk
	pk := rlwe.NewPublicKey(params)
	ckg.GenPublicKey(pk_sum, crp, pk)

	// encrypt something with our new pk! Just use a plaintext of all zeros
	pt := rlwe.NewPlaintext(params, params.MaxLevel())
	pt.IsNTT = false // EDIT: little technicality, using the rlwe package directly without encoding requires specifying if the message is in NTT or not
	encr := rlwe.NewEncryptor(params, pk)
	ct, err := encr.EncryptNew(pt)
	if err != nil {
		panic(err)
	}

	// Each party partially decrypts the ciphertext by doing a keyswitch to a secret key of '0'
	sk0 := rlwe.NewSecretKey(params)
	// for testing only, zero the noise flooding parameters to remove this as a factor that could be causing issues
	ksw, err := mhe.NewKeySwitchProtocol(params, ring.DiscreteGaussian{Sigma: 0 * rlwe.DefaultNoise, Bound: 0 * 8 * rlwe.DefaultNoise})
	if err != nil {
		panic(err)
	}

	// EDIT: now performing the decryption among another set of 2 parties
	// Step 1: obtaining the 2-out-of-2 shares
	sk13_1, sk13_3 := rlwe.NewSecretKey(params), rlwe.NewSecretKey(params)
	com1.GenAdditiveShare(pp1_3, 1, t_sk1, sk13_1)
	com3.GenAdditiveShare(pp1_3, 3, t_sk3, sk13_3)

	// Step 2: run the decryption among 2 parties
	sh1 := ksw.AllocateShare(params.MaxLevel())
	sh3 := ksw.AllocateShare(params.MaxLevel())
	ksw.GenShare(sk13_1, sk0, ct, &sh1)
	ksw.GenShare(sk13_3, sk0, ct, &sh3)

	// Shares are aggregated
	sh := ksw.AllocateShare(params.MaxLevel())
	ct_new := ct.CopyNew()
	ksw.AggregateShares(sh1, sh3, &sh)
	ksw.KeySwitch(ct, sh, ct_new)

	// actually decrypt
	dec := rlwe.NewDecryptor(params, sk0)
	pt_new := dec.DecryptNew(ct_new)

	// EDIT: now the output doesn't look random anymore (but is not zero because of noise)
	fmt.Println(pt_new)

	// EDIT: you can print the norm of the vector and see that it is small (ie would be decoded to zero in schemes like BGV/BFV/CKKS)
	fmt.Println("pt_new norm = ", params.RingQ().Log2OfStandardDeviation(pt_new.Value))
}


Ramp up Madhu on cloud.gov team

In order to get NewPerson productively contributing to the cloud.gov team, Buddy should help NewPerson complete a prescribed set of tasks that will bring them up to speed.
Directions:
NewPerson and Buddy: Try to go through your checklists in order.
Buddy: If you can’t complete any of the items on your checklist personally, you are responsible for ensuring that an appropriate person does it.
New Person checklist

[ ] Take judicious notes on what about this onboarding process or cloud.gov is confusing or frustrating. If you notice a problem (especially with things like documentation), you are more than welcome to fix it! At the very least, please share this information with your buddy (or someone) at some point so we can make the team/platform better.
[ ] Figure out who your onboarding buddy is (they should reach out to you) and make sure this issue should be assigned to them)
[ ] Read the team onboarding document for more context about cloud.gov
[ ] Read the "What is it?" presentation for a rundown of what cloud.gov is and does
[ ] Read through the Introduction section of docs.cloud.gov for a broader understanding of cloud.gov, especially as we present it to potential customers/users
[ ] Read the January 2016 cloud.gov "Executive Business Case" document for greater context about cloud.gov's potential impact in government
[ ] Try to deploy a sample application to cloud.gov to get familiar with the basics of the PaaS from a user's perspective
[ ] Check out the roadmap to get a high-level view of recently-completed, in-progress, and upcoming features
[ ] Install the ZenHub browser extension to enable you to see kanban boards, hierarchical issues, and burndown charts in GitHub
[ ] Read the Delivery Process document to learn about how we work
[ ] Subscribe to the cloud.gov team calendar (click the + in the bottom right) so you know when assorted team meetings are happening in the various streams
[ ] Join the cloud.gov support Google Group, so you can see how we handle non-18F support and get visibility of technical discussions happening with outside groups
[ ] Figure out what streams you're likely to work in, and complete the checklist below that relates to it
[ ] Once you've finished the remaining checklists below, make suggestions for steps that would have improved your onboarding experience as pull-requests on the onboarding checklist template used to make this issue

Atlas-specific items

[ ] Bookmark the Atlas kanban board view
[ ] Make sure you join the #cloud-gov-atlas channel on Slack
[ ] Watch Build Your Own Private Cloud Foundry to learn about running Cloud Foundry
[ ] Set up Cloud Foundry locally and push an app to it
[ ] Learn about BOSH: Watch this video and see our manifests (and read this for levity)
[ ] Get to know how UAA is deployed/integrated (TODO: We need a link here)
[ ] Learn about Concourse and try a tutorial
[ ] Check out our staging and production Concourse instances, and take a look at some of our pipelines
[ ] Join the Cloud Foundry Slack
[ ] Get familiar with AWS in general if you're not already (TODO: We need some pointers here)

Agent Q-specific items

[ ] Bookmark the Agent Q kanban board view
[ ] Make sure you join the #cloud-gov-agent-q channel on Slack
[ ] Read about Cloud Foundry services from a user perspective
[ ] Read about implementing services
[ ] Take a look at some of our existing brokers
[ ] Learn about Concourse: Check out our staging and production instances, and take a look at some of our pipelines
[ ] Join the Cloud Foundry Slack

Liberator-specific items

[ ] See the Liberator Onboarding Checklist (Does that belong here?)

HighBar-specific items

[ ] Make sure you join the #cloud-gov-highbar channel on Slack
[ ] Watch Handling FISMA Faster and Better for important context and background on the federal regulatory context in which cloud.gov operates.

Buddy checklist

[ ] Introduce yourself to the new team member and give them some of your background so they know who you are
[ ] Make sure they're listed in the list of people working on the project
[ ] Add them to the @cloud-gov-team in Slack’s Team Directory (which also adds them to the right channels)
[ ] Add them to the recurring cloud.gov meetings that are relevant for them in the team calendar
[ ] Setup a cloud.gov user account for them via the “send an invite” page
[ ] Identify a straightforward, well-groomed story in progress that involves their skills domain, schedule a meeting with the owner for an introduction (if it's not you), and setup pairing sessions several times in the first week on the project.
[ ] Identify a straightforward, well-groomed first story, ideally something they could conceivably complete in their first two/three weeks using their existing skills. Discuss the context with them, then make them the assignee for the card.
[ ] Make suggestions for how your onboarding experience could have been improved as comments on the onboarding template card.
[ ] Ask #admins-github to have them added to the @18F/cloud.gov team on GitHub

Atlas-specific items

[ ] Ask #admins-github to have them added to the @18F/devops-staff team on GitHub
[ ] If the new person is a contractor, ask #admins-github to have them added to the @18F/devops-staff team on GitHub
[ ] Grant them access to the following (where applicable): AWS, New Relic, PagerDuty, StatusPage
[ ] Take them through AWS onboarding (if applicable)
[ ] Give them a walkthrough of cloud.gov from an architecture perspective

@madhujoshi you can be progressing down much of this list on your own... Is there any reason we shouldn't get this In Progress?

No need to complete this.


Is phpbrew totally broken on OS X 10.11.2 Xcode 7.2.1 Homebrew full updated?

Attempt to install 5.6.14 or 5.6.15 and I get:
configure: error: Cannot find OpenSSL's <evp.h>
hint: it's installed. specifying its location doesn't help
cd to:
~/.phpbrew/build/php-5.6.15
...and run:
./configure --with-openssl
...works.
Attempt to install 5.6.19 and get:
configure: error: Cannot find enchant
hint: it's installed.
No amount of searching generates a fix for either problem.
I can't believe I'm the only PHP developer with a current OS X installation.
I've spent three evenings on this with no love. What should my expectations be? Should this just work or must I start submitting pull requests.

See here https://github.com/phpbrew/phpbrew/wiki/Trouble-Shooting:-Can't-build-PHP-on-OS-X-El-Capitan

And this one https://github.com/phpbrew/phpbrew/issues/607

Yeah, none of that works.
So again. Is the intention to support OS X & Homebrew? If it is, I'll help.

I think so. There are some isssues for looking up include paths with
homebrew.
I don't know homebrew, but phpbrew works pretty well with Macports.
bhaines<EMAIL_ADDRESS>於 2016年3月12日 星期六寫道：

Yeah, none of that works.
So again. Is the intention to support OS X & Homebrew? If it is, I'll help.
—
Reply to this email directly or view it on GitHub
https://github.com/phpbrew/phpbrew/issues/688#issuecomment-195653210.

I re-visited this issue again, and I still don't encounter this issue. that's weird. maybe you can try the latest release.

My evp.h was located in /opt/local/include/openssl/evp.h, and I think the configure didn't find your evp.h because it doesn't know how to find it (because homebrew install openssl in different location)
Maybe --with-openssl={prefix} would help


SentenceTokenizer omits the portion of a sentence preceding a quotation

Using SentenceTokenizer on the string
This is a sentence. And another where ‘Someone says something.’
returns
['This is a sentence.', '‘Someone says something.’']

Issue #552 about compatibility with Safari and issues #549 and #550 made me think about another direction for solving this. Also because I could hardly read and process the regular expression with lookbehinds and lookaheads. I though a more careful and elaborate solution based on parsing was needed. So I build a PEGJS grammar and generated a sentence parser. Pull request is here #558

Your example is a bit problematic because the . and quote ' are in reverse order. So you are asking for some robustness wrt incorrect syntax. The output of the new parser-based solution would be:
[
   "This is a sentence.",
   "And another where ‘Someone says something.",
   "’"
]

This solved in the new grammar-based sentence tokenizer.


Add Grafana 2.5 support

Update configuration template + defaults values with the new Grafana 2.5 directives. Also modifies some switch from yes/no to true/false for consistency. Feel free to ignore if this is not relevant to you !

Looks awesome. Thank you!


Chapter 1 (Trainstation) bug

In said chapter:

Citizens missing their pre-defined dialog when try to interact with them (Not talking) also they already recognized the player as Gordon Freeman.
Some citizen also not executing their scripted sequence, for example "Waiting in line to get food" sequence

Thanks for the report. I'm aware of those bugs however I wasn't able to pinpoint yet why they do that. However the only game breaking thing are those in the queue which "sometimes" don't move forward if they get interrupted by whatever.

Console log can help perhaps

I think the issue is somewhere hidden in the player code as Garry's Mod implements its own player class and it might have something to do with that and how AI is treated in multiplayer.

Well I found the root cause for this, Garry's Mod has a slightly different scripts/talker/npc_citizen.txt script where the criteria "IsGordonCriminal" was removed.

Oh, can you add them? I mean pack it together after do slight modification to the file?

I can not, apparently Willox made sure scripts can not be overridden. However he promised to look into this specific case.

Ah great. Oh I forget to tell another bug. Did you notice that in the Interrogation Room where Barney show to Doctor Kleiner that Gordon Freeman come, Barney go inside the small storage room with the player and the door isn't close after Barney tell Player to escape?

Yea its left open on purpose so players wont be locked out.

I've already implemented point_viewcontrol and yea I noticed pods being wonky but I think thats a Garry's Mod thing lately.

So impossible to fix for the Pods?

The pods are fixed. I just published it to the workshop.

Awesome :D

I think I know what's the cause of those citizen missing their pre-defined dialog also they not run the scripted sequence properly. I got this kind of message generated on console:
CSceneEntity lcs_sewercops_converse unable to find actor named "!target1"
CSceneEntity lcs_sewercops_converse unable to find actor named "!target2"
CSceneEntity lcs_sewercops_startle unable to find actor named "!target1"
CSceneEntity lcs_sewercops_startle unable to find actor named "!target2"
This is the sample where 2 Metro-Police doing conversation (sequence isn't executed) while I'm below them in map d1_canals_01a

I was able to fix the part in d1_canals_01a that was due to the NPC's literally missing. The one "mark_boxcar_human_opendoor" is same as in Half-Life 2, its just a missing "move to" script, nothing game breaking. Also I would appreciate if you could open new issues in the future to better track them.

Alright, I'll do it by moving my comment above to the new issue


process not clear

[Enter feedback here]
We do not have info on how to import easily into our documentation. That or perhaps I have not found the right page. But other people have done this better of what we could find.
We had a customer trying to import a workbook from github and couldn't figure out the process that easily.
https://www.cloudsma.com/2020/11/import-azure-monitor-workbooks/ <- instructions i got for the customer.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: bfb4585f-69fa-36ae-9a7f-ce33725d8baa
Version Independent ID: e3ffe6a3-e0c7-2784-d8e3-13296a3f08e9
Content: Visualize your data using Azure Monitor Workbooks in Azure Sentinel
Content Source: articles/sentinel/tutorial-monitor-your-data.md
Service: azure-sentinel
Sub-service: azure-sentinel
GitHub Login: @yelevin
Microsoft Alias: yelevin

Thanks for the feedback! I have assigned the issue to the doc author to update appropriately.

Thanks for the feedback! We will have a look at this and update as appropriate.

hi @ran-ten21, thanks for your comment on Microsoft docs!
We do have plans to enhance our documentation with details about how to add resources from GitHub, and we'll add this detail to this list.
I'm going to close this issue for now, but feel free to continue commenting as needed.
We appreciate your contribution!
#please-close


Add Config Feature

Can you guys add a feature to add .cfg files to modpacks? Some mods I use (like HQM or Better Title Screen) require the .json or .cfg files in the /config/ directory. Currently there is no way to do this.
Example (in repository):

/config/

mod-name.cfg

Or something like that.

You can add any file you want in mods, with any structure (/mods,
/config,...). Zip file is extracted at root of the modpack,so if you call
call a folder config, it is extracted at /modpack-slug/config


Issue112 rqmultipart tests

Please review this pull request for the 112 issue
https://github.com/yegor256/takes/issues/112

Let me find a reviewer for this pull request, thanks for submitting it

@ggajos review this one, please

@davvd please include some brief PR description, how/why you're solving issue

@davvd please fix qulice issues

@ekondrashev your PR is very big, please try to submit smaller ones in future

@ekondrashev you're creating similar requests over and over, maybe it would be good to extract method that will help you with creation of requests?

@ekondrashev one comment is gone but regarding naming you can say satisfiesEqualsContract instead of equalsReturnsTrue. It's more abstract, but your current changes are ok.

@ekondrashev few minor comments above

@rultor merge please

@rultor merge please

@ggajos Thanks for your request. @yegor256 Please confirm this.

@rultor merge

@rultor merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

@rultor merge

@yegor256 Done! FYI, the full log is here (took me 18min)

@elenavolokhova please, review this task for compliance with our quality rules

@rultor deploy now pls

@rultor deploy now pls

@davvd OK, I'll try to deploy now. You can check the progress here

@rultor deploy now pls

@davvd Done! FYI, the full log is here (took me 12min)

@ggajos One comment regarding addressing the comments in the ticket:

davvd commented 12 days ago
Let me find a reviewer for this pull request, thanks for submitting it

Could you ask to fix them in future tickets?

@davvd please address you're comments directly

@elenavolokhova sure, will do, thank you for feedback

@davvd Quality is acceptable.

@davvd Quality is acceptable.

@elenavolokhova thanks for the review, we'll try better next time

@ggajos just added 10 mins to @elenavolokhova (for QA), payment ID is 55563732; paid, thanks, added 24 mins to your account, payment AP-2SB34765BR049391P, 143 hours and 48 mins was spent; you're getting extra minutes here (c=9); +24 added to your rating, at the moment it is: +3724


[REVIEW] DGKSK8LIFE

GitHub Profile Link
https://github.com/DGKSK8LIFE

Nice profile! I would only recommend adding something about yourself. 🙂

Thanks.

Reviewed on live stream https://www.youtube.com/watch?v=YVJyz7DZMQo
Looks great as minimalistic and clean profile

Suggest customising your GitHub profile
Use bio and link
Try to have more code reviews, issues and pull requests


Allow using mirrors while testing

Steps to Reproduce
test/game/rtmp.dart:
import 'package:socket_io/socket_io.dart';
import 'package:socket_io_client/socket_io_client.dart' as client;
import 'package:test/test.dart';

void main() {
  group("MultiPlayer", _tests);
}

void _tests() {
  Server server;

  List<client.Socket> clients;
  setUp(() {
    server = new Server();
    server.listen(3000);

    clients = List.generate(
      4,
      (int i) => client.io("https://localhost:3000"),
    );
  });

  tearDown(() {
    server.close();
    clients.forEach((v) => v.close());
  });

  test("works", () async {});
}

flutter test ./test/game/rtmp_test.dart

Logs
Shell: [ERROR:flutter/shell/common/shell.cc(178)] Dart Error: error: import of dart:mirrors with --enable-mirrors=false
Shell: [ERROR:flutter/shell/common/engine.cc(176)] Could not prepare to run the isolate.
Shell: [ERROR:flutter/shell/common/engine.cc(123)] Engine not prepare and launch isolate.
Shell: [ERROR:flutter/shell/testing/tester_main.cc(199)] Could not launch the engine with configuration.

[✓] Flutter (Channel beta, v1.3.8, on Mac OS X 10.14.3 18D109, locale ko-KR)
    • Flutter version 1.3.8 at /Users/kdy1/flutter
    • Framework revision e5b1ed7a7f (2주 전), 2019-03-06 14:23:37 -0800
    • Engine revision f4951df193
    • Dart version 2.2.1 (build 2.2.1-dev.0.0 571ea80e11)

[✓] Android toolchain - develop for Android devices (Android SDK version 28.0.3)
    • Android SDK at /Users/kdy1/Library/Android/sdk
    • Android NDK location not configured (optional; useful for native profiling support)
    • Platform android-28, build-tools 28.0.3
    • Java binary at: /Users/kdy1/Library/Application Support/JetBrains/Toolbox/apps/AndroidStudio/ch-0/182.5314842/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1248-b01)
    • All Android licenses accepted.

[!] iOS toolchain - develop for iOS devices (Xcode 10.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 10.1, Build version 10B61
    ✗ Verify that all connected devices have been paired with this computer in Xcode.
      If all devices have been paired, libimobiledevice and ideviceinstaller may require updating.
      To update with Brew, run:
        brew update
        brew uninstall --ignore-dependencies libimobiledevice
        brew uninstall --ignore-dependencies usbmuxd
        brew install --HEAD usbmuxd
        brew unlink usbmuxd
        brew link usbmuxd
        brew install --HEAD libimobiledevice
        brew install ideviceinstaller
    • ios-deploy 2.0.0
    • CocoaPods version 1.5.3

[!] Android Studio (version 3.3)
    • Android Studio at /Users/kdy1/Library/Application Support/JetBrains/Toolbox/apps/AndroidStudio/ch-0/182.5314842/Android Studio.app/Contents
    ✗ Flutter plugin not installed; this adds Flutter specific functionality.
    ✗ Dart plugin not installed; this adds Dart specific functionality.
    • Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1248-b01)

[✓] IntelliJ IDEA Ultimate Edition (version 2018.3.5)
    • IntelliJ at /Users/kdy1/Applications/JetBrains Toolbox/IntelliJ IDEA Ultimate.app
    • Flutter plugin version 33.4.2
    • Dart plugin version 183.5912.23

[!] VS Code (version 1.32.3)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    ✗ Flutter extension not installed; install from
      https://marketplace.visualstudio.com/items?itemName=Dart-Code.flutter

[✓] Connected device (1 available)
    • iPhone XR • 01668E55-3AEE-4D2D-AE53-24A40A2F286E • ios • iOS 12.1 (simulator)

Note that test works with flutter packages pub run ./test/game/rtmp_test.dart

flutter test runs tests via a headless flutter device, the flutter_tester, which doesn't support mirrors. If you have tests that use mirrors and not dart:ui, then running them via flutter packages pub run test_name is supported, since this runs in the dart vm.


Notes: Pressing 4 when not in "OpenStreetMap notes" mode give no visual information

If I don't have enabled the "OpenStreetMap notes" mode and use the keyboard shortcut 4, the 'Add note' mode is activated, but you don't get any visual information what is going on.
Normally when you go in to a add mode, the Point/Line/Area button is marked to indicate what you are doing. The same when you are in "OpenStreetMap notes" mode and adding a note. But if you have not enabled the "OpenStreetMap notes" mode and accidentally hit 4, you don't know what mode you are in.
Suggested solutions:

Don't allow 4 when "OpenStreetMap notes" are disabled
Automatic enable "OpenStreetMap notes" when hitting 4 (I prefer this)

Thanks for reporting @magol .. I went with this: "Don't allow 4 when "OpenStreetMap notes" are disabled"
I chose this solution because it's probably easy for users to hit 4 without thinking about it, and if they don't know about the notes layer, they would be confused to have it enabled and put into Add Note mode.  For now, we'll continue to make enabling the notes layer be a thing they need to purposely opt in to.


Implement Autoconceal for other collection type

Fixes #91
It was a good first issue but it was dangling for a few months now, and I thought it can be useful.

On the contrary, I found iter_mut for Vec, BtreeMap and HashMap.

The CI failure should gone with your next push (I merged fixing PR)

Updated as per comments, some remains. Added a small change in assignment test to check for autoconceal return value.

And CI seems to require one more rebase to include just merged CI PR

Updated and rebased.


[WIP]FINERACT-1021 - Update to JUnit 5

FINERACT-1021

@vorburger @awasum good for you?

Wait a second - this disabled all tests!!!!! :sob:
Both ./gradlew test and ./gradlew integrationTest don't do anything, anymore after I merge this.
We therefore either have to revert this ASAP, or fix it today... sorry & thanks for understanding.
The Revert is non-trivial because I've meanwhile merged other PRs.
@xurror @percyashu @thesmallstar @awasum @ptuomola would one of you like to look into how to make tests run? I'm guessing the Gradle needs some sort of configuration change to run JUnit 5...
This is now blocking #943 ... :disappointed:

==> #1054


[ENH] metrics rework part IV - hierarchical metrics

This PR continues rework of the current metrics interface.
This PR uses the tests in https://github.com/alan-turing-institute/sktime/pull/2496 and builds upon #2500 and #2502
The following changes are made relative to #2502:

extending BaseForecastingErrorMetricFunc to accept hierarchical input
enable averaging options via the multilevel parameter

mac failures unrelated


Update AboutView.js

Add a reload button in the about screen. This can be used to reload the page on iOS when the app is set to full screen. In that case there is no way to reload the page and due to caching changes will not always be visible.

I second this - on Android you can pull the page down for reload, not on iOS

According to http://stackoverflow.com/questions/8792255/how-do-you-force-an-ipad-home-screen-bookmarked-web-app-to-refresh this can also be done using cache.manifest, but this seems to be easier ;)

Nice, thanks!


Added usage of pytorch.randomCrop instead of splitting clips.

Speed up of learning.

Similar solution, but on clips have been implemented in #25. So I close this PR.


CheckReturnValue Rule

Given a method that is annotated with CheckReturnValue or CheckResult and you call it without storing the value it should be flagged. We don't even need to resolve the imports, simply checking for the annotation name is sufficient.
Positive case:
interface Something {
  @CheckReturnValue fun foo(): Int
}

fun something(something: Something) {
  something.foo()
}

Negative case:
interface Something {
  @CheckReturnValue fun foo(): Int
}

fun something(something: Something): Int {
  val foo = something.foo()
  return foo + foo
}

I do not think such a rule should be in the default rule set. Who provides this annotation? Should the user create one? Sounds like a custom rule set to me :)

@CheckResult comes from Android and they also have that rule built into lint (that should work with AS 3.0 and forward). @CheckReturnValue can be defined, for instance RxJava 2 has it. Also it's part of the JSR 305 annotations.
I'd argue that this rule is pretty common and should be in the main rule set. ErrorProne has it as well as Findbugs (they also provide their own annotation).

Ok, sounds important, never used that :). So it tells you that the return value is unused? Like intellij does?

Exactly yeah. I heavily rely on it when using RxJava (to not forget to call subscribe() and handle the returned Disposable) or custom builders (not calling build). It's just a sanity check.

Can you point me to the right visit method that I should be using for this?

We cannot implement this rule right now. My idea would be to visit a KtNamedFunction, get the annotation and search for usages of this method. This is the part where resolving must be implemented ^^

Maybe add a label to the issue and to the other ones where resolving must be implemented first?

I'm closing this since we'll get this with lint in AGP 3.1.0. Also with 3.1.0 there's a lint plugin that can be used in kotlin code to get the checks. Does not make sense to duplicate the checks and also this is still blocked by type and symbol resolution.


Indicator for price trend

Adding an indicator if the price is trending up or down would be nice. Maybe an arrow, or change the color of the bitcoin symbol green or red depending on direction.

@y: Thanks for the feedback! This requires time series data to be useful, so I've had this sketched out for awhile for a major revision of btcbar that also shows graphs of recent trends. I think it's going to have to log data locally though since not many of the APIs offer historical data for free.


install requirements

while pip3 install -r requirements.txt
unable to install requirements from 26 line and below
I'm on Debian 10. What should I do? Please advise.

They have solved a similar issue here.

They have solved a similar issue here.

Hm, thanks, I would try.


[Combined Documentation] Targets are missing some dependencies

Creating this issue that was brought to my attention by @nmggithub:
The new experimental combined documentation support doesn't provide targets with all of their dependencies' documentation.
Checklist

[x] If possible, I've reproduced the issue using the main branch of this package.
[x] This issue hasn't been addressed in an existing GitHub issue.

Expected behavior
A target with multiple dependencies should be able to link against all of those dependencies
Actual behavior
A target with multiple dependencies is only able to link against one of its dependencies
Steps to Reproduce
Build combined documentation for a package where one of the targets depends on two or more other targets in that package, passing the --verbose flag.
In the docc convert call for the target with two or more dependencies there should be as many --dependency arguments.
Swift-DocC Plugin Version Information
Swift-DocC plugin version: 1.4.2 for example, or a commit hash.
Swift Compiler version: swiftlang-<IP_ADDRESS>.10 clang-16<IP_ADDRESS> (but it's not relevant to this bug)

This bug is fixed in the 1.4.3 release.
cc @nmggithub


Selecting a list element from a list of bit-vectors returns an int

Hi @mballance
First up I'd like to say that pyvsc is amazing. Having tried python-based verification before, the main blocker that has stopped me moving away from systemverilog has always been decent constrained random generation, which pyvsc has totally solved.
However, I'm having an issue with lists of bit-vectors. Essentially, if I have a variable of type vsc.bit_t(x), I can pick out arbitrary bits or bit-ranges from that vector, just like I can in systemverilog. But if I create a list of elements of type vsc.bit_t(x), then select one of those elements, I get an int back instead, meaning I can no longer select indvidual bits any more.
list_of_blocks = vsc.list_t(vsc.bit_t(64), 16)
block          = vsc_bit_t(64)

type(block)             # - returns <class 'vsc.model.value_scalar.ValueInt'>
type(list_of_blocks[0]) # - returns <class 'int'>

block[3]             # returns bit 3 of the 64b vector
list_of_blocks[0][3] # fails with: TypeError: 'int' object is not subscriptable

Looking through the code it seems the is_scalar flag is causing this behaviour, which I appreciate may be useful in some circumstances, but without a way to override it, is quite limiting in others.
Thanks,
Graham

Hi @grahamcx, Thanks for raising this issue, and very happy to hear that you're finding value in PyVSC.
Unfortunately, this example may be running into limits (or, at least, corner cases) of Python's operator overloading capabilities. When you index list_of_blocks to read an element, PyVSC currently returns the value of the element which, most of the time, we want to see as a Python int value. In this case, we want to be able to further slice it to get a specific bit or bits.
Let me play with this a bit. There still may be a way to get this to work as-is. If not, I should be better informed as to the options.
Best Regards,
Matthew

Hi @grahamcx, good news! This issue did end up being an operator-overloading issue. The subscript of the array returned the array element as an 'int' value. It should have returned a ValueInt object in order to allow the value to subsequently be subscripted. I made the change, and now an expanded version of your testcase runs:
https://github.com/fvutils/pyvsc/blob/743b6d3c3376dfa15feab91bfe454f5ee5a53eac/ve/unit/test_partselect.py#L61-L77
The 0.8.2 release contains the fix, and should be available on PyPi within a few minutes. Thanks again for the issue report!

Thanks for the speedy fix @mballance, that's great news. I'll give that a try.
Graham


[Diagnostics]: Trace rate limiter always/never trace.

Fixes #5213
Each commit contains a possible solution. I like the second commit better because it's more general, but I'm fine with the first one as well.
I'll deal with tests after we've chosen one of the alternatives.

Fixed the typo and added tests.
This is now ready for review.
Integrations tests are running on local.

Will review tomorrow - meetings for the rest of the day :(


Initialization bundle

What is this pull request?
This pr provide reworking of initialization: all internal dependencies may be changed with inherited classes.
Why do you implement it? Why do we need this pull request?
This pr very useful in tests, because current implementation not support testing: all dependencies initialize in one function and can not be changes for test purposes.
How to use the features provided in the pull request?
Inherit from application and change dependencies for your purposes.

Codecov Report

Merging #573 into develop will increase coverage by 32.31%.
The diff coverage is 0%.

@@             Coverage Diff              @@
##           develop     #573       +/-   ##
============================================
+ Coverage    47.52%   79.84%   +32.31%
============================================
  Files          264      310       +46
  Lines        10230    12323     +2093
  Branches      5126        0     -5126
============================================
+ Hits          4862     9839     +4977
- Misses         717     2484     +1767
+ Partials      4651        0     -4651

Impacted Files
Coverage Δ

irohad/model/peer.hpp
88.88% <ø> (+11.11%)
:arrow_up:

irohad/main/application.cpp
0% <0%> (ø)

irohad/consensus/yac/messages.hpp
73.68% <0%> (-10.94%)
:arrow_down:

libs/crypto/hash.cpp
68.42% <0%> (-3.01%)
:arrow_down:

irohad/model/commands/create_asset.hpp
50% <0%> (ø)
:arrow_up:

irohad/model/commands/set_quorum.hpp
50% <0%> (ø)
:arrow_up:

irohad/model/commands/create_account.hpp
50% <0%> (ø)
:arrow_up:

irohad/model/commands/transfer_asset.hpp
50% <0%> (ø)
:arrow_up:

libs/crypto/ed25519/sign.c
100% <0%> (ø)
:arrow_up:

libs/crypto/ed25519/add_scalar.c
0% <0%> (ø)
:arrow_up:

... and 280 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 58e8f7f...6a9bb69. Read the comment docs.