Exit config-init script on error

We ran into a problem where config-init exited cleanly after running octez-node config init... and failed with (/usr/local/bin/octez-node) Exit: exit because of uncaught exception: Failure("resolution failed: name resolution failed").
teztnets.xyz as part of the --network flag failed to resolve. The container then moved on to config-generator which failed bec it couldn't find the config.json file as it didn't get written.
The config-init script should exit on error so that k8s retries the container. In the case where the network url didn't resolve at first, it may on a subsequent try.

Did you try on a local container? I don't see why set -e would fix things, because previously, if the network was not downloaded, it would fail to write a config so the cat command would exit in error, and therefore the init container itself would error out? See this error you pasted on slack:
│ Writing custom configuration for public node                                                                         │
│ Warning                                                                                │
│   The executable with name tezos-node has been renamed to octez-node. The name tezos-node is now                     │
│   deprecated, and it will be removed in a future release. Please update                                              │
│   your scripts to use the new name.                                                                                │
│                                                                                │
│ (/usr/local/bin/octez-node) Exit: exit because of uncaught exception: Failure("TLS to non-TCP currently unsupported: │
│                                                                                │
│ cat: can't open '/etc/tezos/data/config.json': No such file or directory

Do we understand why the container succeeds with the code on master?

I tested locally. It will fail the script for any cmd that exists with a non 0 error code. In this case the config init cmd exits with 126 which is an error code indicating a failure internally inside an application.


Bitwarden: Migrate to PostgreSQL

Fix for commit fb8ae34a9be942c2404bfa71111e71febae0a660

I have a production configuration ready if you want me to submit a pull for it let me know.

Fixed with 1eeb092


in the future, could it work on a WASM Python instead of a Cloud Python ?

If it could work on a WASM Python instead of a Cloud Python, all things being equal:

we may be twice slower
but it may be less a stress on Datacenters, or a stress of unknown timing on users wanting to run something very cpu intensive

That's available!
And it is called Anaconda Code.
And with my anacondacode module running arbritrary length code is possible as well!

Yes, you can use Anaconda code for it. We are always evaluating WASM, but do not yet have any plans to support it at this time.


RowBatcher - First Draft.

So we can incorporate your pull request, please share the following:

What issue are you addressing with this pull request?
Are you modifying the correct branch? (See CONTRIBUTING.md)
Have you run unit tests? (See CONTRIBUTING.md)
Version of MarkLogic Java Client API (see Readme.txt)
Version of MarkLogic Server (see admin gui on port 8001)
Java version (java -version)
OS and version
What Changed: What happened before this change? What happens without this change?

Closing this request for now. Will be opening a new one with unit tests.


running nbdev_preview gives a KeyError: 'state'

This issue is from #1127 .
@hamelsmu I think I am now able to reproduce the error. Here is a minimal repo for that. https://github.com/deven-gqc/test-key-state-error.
The weird thing is it passes the CI in GitHub Actions, but I keep getting the error locally.
(base) devengqc@17-CN0065CL-1:~/git/public/test-key-state-error$ nbdev_preview
concurrent.futures.process._RemoteTraceback:
"""
Traceback (most recent call last):
  File "/home/devengqc/mambaforge/lib/python3.9/concurrent/futures/process.py", line 246, in _process_worker
    r = call_item.fn(*call_item.args, **call_item.kwargs)
  File "/home/devengqc/mambaforge/lib/python3.9/concurrent/futures/process.py", line 205, in _process_chunk
    return [fn(*args) for args in chunk]
  File "/home/devengqc/mambaforge/lib/python3.9/concurrent/futures/process.py", line 205, in <listcomp>
    return [fn(*args) for args in chunk]
  File "/home/devengqc/mambaforge/lib/python3.9/site-packages/fastcore/parallel.py", line 46, in _call
    return g(item)
  File "/home/devengqc/mambaforge/lib/python3.9/site-packages/nbdev/serve_drv.py", line 22, in main
    if src.suffix=='.ipynb': exec_nb(src, dst, x)
  File "/home/devengqc/mambaforge/lib/python3.9/site-packages/nbdev/serve_drv.py", line 16, in exec_nb
    cb()(nb)
  File "/home/devengqc/mambaforge/lib/python3.9/site-packages/nbdev/processors.py", line 231, in __call__
    def __call__(self, nb): return self.nb_proc(nb).process()
  File "/home/devengqc/mambaforge/lib/python3.9/site-packages/nbdev/process.py", line 126, in process
    for proc in self.procs: self._proc(proc)
  File "/home/devengqc/mambaforge/lib/python3.9/site-packages/nbdev/process.py", line 120, in _proc
    if hasattr(proc,'end'): proc.end()
  File "/home/devengqc/mambaforge/lib/python3.9/site-packages/nbdev/processors.py", line 210, in end
    widgets = {**old, **new, 'state': {**old['state'], **new['state']}}
KeyError: 'state'
"""

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "/home/devengqc/mambaforge/bin/nbdev_preview", line 8, in <module>
    sys.exit(nbdev_preview())
  File "/home/devengqc/mambaforge/lib/python3.9/site-packages/fastcore/script.py", line 119, in _f
    return tfunc(**merge(args, args_from_prog(func, xtra)))
  File "/home/devengqc/mambaforge/lib/python3.9/site-packages/nbdev/quarto.py", line 270, in nbdev_preview
    cache,cfg,path = _pre_docs(path, n_workers=n_workers, **kwargs)
  File "/home/devengqc/mambaforge/lib/python3.9/site-packages/nbdev/quarto.py", line 174, in _pre_docs
    cache = proc_nbs(path, n_workers=n_workers, **kwargs)
  File "/home/devengqc/mambaforge/lib/python3.9/site-packages/nbdev/serve.py", line 76, in proc_nbs
    parallel(nbdev.serve_drv.main, files, n_workers=n_workers, pause=0.01, **kw)
  File "/home/devengqc/mambaforge/lib/python3.9/site-packages/fastcore/parallel.py", line 117, in parallel
    return L(r)
  File "/home/devengqc/mambaforge/lib/python3.9/site-packages/fastcore/foundation.py", line 98, in __call__
    return super().__call__(x, *args, **kwargs)
  File "/home/devengqc/mambaforge/lib/python3.9/site-packages/fastcore/foundation.py", line 106, in __init__
    items = listify(items, *rest, use_list=use_list, match=match)
  File "/home/devengqc/mambaforge/lib/python3.9/site-packages/fastcore/basics.py", line 66, in listify
    elif is_iter(o): res = list(o)
  File "/home/devengqc/mambaforge/lib/python3.9/concurrent/futures/process.py", line 562, in _chain_from_iterable_of_lists
    for element in iterable:
  File "/home/devengqc/mambaforge/lib/python3.9/concurrent/futures/_base.py", line 609, in result_iterator
    yield fs.pop().result()
  File "/home/devengqc/mambaforge/lib/python3.9/concurrent/futures/_base.py", line 446, in result
    return self.__get_result()
  File "/home/devengqc/mambaforge/lib/python3.9/concurrent/futures/_base.py", line 391, in __get_result
    raise self._exception
KeyError: 'state'

Could it be that you’re on an older version of some dependency locally vs in GitHub Actions? Perhaps execnb?

@seeM
I am running the latest versions locally
fastcore: 1.5.27
execnb: 0.1.4
nbdev: 2.3.8

You are one version behind, you should install the latest version from GitHub

@hamelsmu The issue still persists after downloading the latest version from GitHub.

@seeM @hamelsmu I have figured out the issue. The issue came into picture because of the widgets key inside the note. I'm not sure if there is a mechanism currently to handle that key. Getting rid of the widgets key inside the notebook fixes the issue.

@deven-gqc @seeM @hamelsmu

@seeM @hamelsmu I have figured out the issue. The issue came into picture because of the widgets key inside the note. I'm not sure if there is a mechanism currently to handle that key. Getting rid of the widgets key inside the notebook fixes the issue.

How do you get rid of the widget key?
I figured out that creating a new empty notebook, and copying the cells from the existing notebook solved this issue.
The weird thing was that even if you delete all cells in the existing notebook, it'll still raise this issue.
So, it's not because of the cells but because of the widget state which exists in the notebook regardless of the cells.

I figured out that creating a new empty notebook, and copying the cells from the existing notebook solved this issue.

@udaylunawat I did that as well.

How do you get rid of the widget key?

I had opened the notebook with a text editor and deleted that key.


Thank you for your sponsorship and your great project! 💖

Hey, I saw that you sponsored me! While checking out your profile, I came across your project and wanted to say that it looks great! I really like your prompt template feature.
Your idea of having an icon in the text input to switch between AI clients is brilliant, and I may borrow it for my own web client.
Thanks for the sponsor, and keep up the good work!

Thank you so much! Really, this project would not be possible without your hard work so it's the least I can do. I never touch the official site anymore. Use what you like and code on :)

I'm also planning on setting up a personal web client so I don't need to use chat.openai.com anymore either :D

Good luck with the rest of your projects!


Improve SSR support

As for now, the actual DOM manipulation is always performed client-side as the current implementation of the directive requires the document context. While loading, a data-lettering="loading" attribute is added to the elements to hide it before the directive is bound.
A future implementation may use VNode manipulation natively to remove the document dependency.

I'm getting a Cannot add property data-lettering, object is not extensible error while using this with the occasional Nuxt project I do, so this would be greatly appreciated! 👍


Rabin-Karp checksum is not working

Although the blackbox tests seem to show that the rabinkarp32 is a valid rolling checksum, it is apparently not an valid instance of the real Rabin-Karp fingerprint. We need a real implementation.
The program restic https://github.com/restic/chunker/blob/master/chunker.go seems to have a working thing.
Original paper: http://www.xmailserver.org/rabin.pdf
Implementation details: http://citeseer.ist.psu.edu/viewdoc/download?doi=<IP_ADDRESS>.6172&rep=rep1&type=pdf

Fixed by b1e9088


@root_install should be @system_install

I believe this fixes a typo in the rvmrc.erb template, judging by the code in chef_rvm_recipe_helpers.rb:
t = template rvmrc_file do
          source      "rvmrc.erb"
          owner       opts[:user] || "root"
          mode        "0644"
          variables   :system_install   => system_install,
          ...

Closing due to inactivity.
If this is still an issue please reopen or open another PR.
Alternatively drop by the #sous-chefs channel on the Chef Community Slack and we'll be happy to help!
Thanks,
Sous-Chefs


Docker-ig: Enrich containers with container image name

Docker-ig: Enrich containers with container image name
Partly implements: #1310
ContainerImageName is retrieved from the Docker API. When image name is not provided, then ContainerImageName will contain the imageID.
In json output the image ID is displayed in long form, while for listing containers it is truncated.
Image filed provided by Docker API may looks like e.g.

gcr.io/k8s-minikube/kicbase:v0.0.37@sha256:8bf7a0e8a062bc5e2b71d28b35bfa9cc862d9220e234e86176b3785f685d8b15

OR

busybox@sha256:3fbc632167424a6d997e74f52b878d7cc478225cffac6bc977eedfe51c7f4e79

These two provide both image name and digest separated by '@'.

docker.io/library/busybox:latest or simply busybox

Just image name is provided.

sha256:aebe758cef4cd05b9f8cee39758227714d02f42ef3088023c1e3cd454f927a2b

This fourth option provides the imageID and, following Docker example, we'll use the imageID.
Tests examples
ig list-containers on host (Docker version 23.0.4):

ig list-containers in minikube-docker (Docker version 20.10.23):

ig list-containers -o json in minikube-docker (Docker version 20.10.23):

ig list-containers -w in minikube-docker (Docker version 20.10.23):

ig trace exec -o json in minikube-docker (Docker version 20.10.23):

These two provide both image name and digest separated by '@'.
sha256:aebe758cef4cd05b9f8cee39758227714d02f42ef3088023c1e3cd454f927a2b

Just for understanding, is it only happening for older docker version? or this is about untagged images?

These two provide both image name and digest separated by '@'.
sha256:aebe758cef4cd05b9f8cee39758227714d02f42ef3088023c1e3cd454f927a2b

Just for understanding, is it only happening for older docker version? or this is about untagged images?

At first I thought it is a problem for older docker version, but then I realized that it depends on the image metadata somehow. Running a new test now, I just found that image  field can be populated by only image name too:

In the above screenshot I started a busybox container on the host (Docker version 23.0.4) and then run ig list-containers -w. In logs the image name is provided, but has a different structure than the three ones I considered so far. It is just correctly containing the image name.
Need to update with this case too.

At first I thought it is a problem for older docker version, but then I realized that it depends on the image metadata somehow. It is not yet clear for me.

I think we should keep the imageID of the form sha256:... perphas in the truncated form? This will be similar to how docker handles it:
$ echo "FROM busybox" > Dockerfile
$ echo "LABEL foo=bar" >> Dockerfile
$ echo "RUN echo 'hello, world'" >> Dockerfile
$ docker build -f Dockerfile .
$ docker run --rm -it -d  $(docker images --filter 'label=foo' -q) sleep 300
$ docker ps
CONTAINER ID   IMAGE                                 COMMAND                  CREATED         STATUS         PORTS                                                                                NAMES
97594d43eda5   7a520f527e1d                          "sleep 300"              2 seconds ago   Up 2 seconds

Like if name isn't available (e.g someone pushed the image with same tag) docker shows the truncated imageID. What do you think?

Note that Docker shows the truncated imageID but it does not truncate the image digest:
$ docker images --digests
REPOSITORY                   TAG     DIGEST                                                                    IMAGE ID       CREATED         SIZE
ghcr.io/inspektor-gadget/ig  latest  sha256:a9a1d80a1691727ce7bc73380881c042076f1e290500e633c7a963a6aa13e189   c98e2504acb5   2 weeks ago     105MB

Nonetheless, I think it looks better to truncate the digest too. I like the --no-trunc option in Docker to allow users to get the long form if needed but default on the concise form; I don't know why Docker does not use --no-trunc for the digest too.
If we do truncate fields, it should be done in the columns display (cols.MustSetExtractor) but the json/yaml output should still display the fields without truncation.

If we do truncate fields, it should be done in the columns display (cols.MustSetExtractor) but the json/yaml output should still display the fields without truncation.

:100:

I don't know why Docker does not use --no-trunc for the digest too.

Yeah, that would have been nice for consistency!

Nonetheless, I think it looks better to truncate the digest too. I like the --no-trunc option in Docker to allow users to get the long form if needed but default on the concise form; I don't know why Docker does not use --no-trunc for the digest too.

We had the --no-trunc flag in ig to not truncate the container ID, but it got lost in the refactoring 🙁 .

@alban @mqasimsarfraz @claudiamarcubina, what about providing the digest in another field? ContainerImageName and ContainerImageDigest? IIRC, the Digest is also provided in another field by most of the runtimes and, in the cases Docker provides sha256:aebe758cef4cd05b9f8cee39758227714d02f42ef3088023c1e3cd454f927a2b, we leave the ContainerImageName empty and fill the ContainerImageDigest with such a sha.

what about providing the digest in another field? ContainerImageName and ContainerImageDigest?

I think it might be confusing like I would expect ContainerImageDigest to be the repo digest and not imageID. For example:
$ docker images --digests --no-trunc --format "{{.ID}} {{.Digest}}"
sha256:a416a98b71e224a31ee99cff8e16063554498227d2b696152a9c3e0aa65e5824 sha256:3fbc632167424a6d997e74f52b878d7cc478225cffac6bc977eedfe51c7f4e79
sha256:c6cc01e6091959400f260dc442708e7c71630b58dab1f7c344cb00926bd84950 sha256:8cadf23777709e43eca447c47a45f5a4635615129267ce025193040ec92a1631

Maybe move ahead with this PR and keep returning non-truncated imageID for now and decide on truncating later on. What do you say?

what about providing the digest in another field? ContainerImageName and ContainerImageDigest?

I think it might be confusing like I would expect ContainerImageDigest to be the repo digest and not imageID. For example:
$ docker images --digests --no-trunc --format "{{.ID}} {{.Digest}}"
sha256:a416a98b71e224a31ee99cff8e16063554498227d2b696152a9c3e0aa65e5824 sha256:3fbc632167424a6d997e74f52b878d7cc478225cffac6bc977eedfe51c7f4e79
sha256:c6cc01e6091959400f260dc442708e7c71630b58dab1f7c344cb00926bd84950 sha256:8cadf23777709e43eca447c47a45f5a4635615129267ce025193040ec92a1631

Maybe move ahead with this PR and keep returning non-truncated imageID for now and decide on truncating later on. What do you say?

I am a bit confused now.
ContainerImageDigest to be the repo digest

ContainerImageDigest will be the repo digest and will come in a different PR.
In this PR we have ContainerImageName that is populated with the image name as:

docker.io/library/busybox:latest
OR
busybox
OR
sha256:6e38f40d628db3002f5617342c8872c935de530d867d0f709a2fbda1a302a562  > in json output, this being the image ID
OR
6e38f40d628d > truncated for ig list-containers and ig list-containers -w, this being the image ID truncated

I am planning to tackle the last two cases and retrieve the proper image name based on that ID. I want to do this in a next PR.
WDYT?

I am planning to tackle the last two cases and retrieve the proper image name based on that ID. I want to do this in a next PR.

Agreed. Lets handle the ContainerImageDigest in a follow up PR!

Oh, I'm sorry, I confused the id with the digest. Never mind.


feat: support for mapping single to multiple

Is this same like https://github.com/pasztorpisti/qs

Is this same like https://github.com/pasztorpisti/qs

yes! Solves the problem of getting multiple values of the same key from a query parameters.


Exposes the is_loaded bool and adds a way to add fallbacks.

Signed-off-by: Hal Gentz<EMAIL_ADDRESS>

Let's make CI happy, shall we? :)

Does that mean that the user can do function.is_loaded = false; or function.is_loaded = true;. Is that something we want?

Can't one call the .is_loaded() methods? That's why I added them! 😅

Fixed. Sorry for not testing (or waiting for the CI to finish).


Manifest editor

Are there any tools to edit these manifests? In older VSTO addins, there were visual editors to generate ribbons, etc, but now we're expected to hand-edit XML (it doesn't even seem to have an editor that uses the schema definition like package.json in vscode). Are there better tools to do this rather than just hand-editing files? This new process is super cumbersome and way more error-prone compared to the old architecture.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: fd911611-3a2c-8ec2-5213-38369071fb30
Version Independent ID: 5e83d015-e912-2c6f-1a21-69aeaa398923
Content: Outlook add-in manifests - Outlook Developer
Content Source: docs/add-ins/manifests.md
Product: outlook
Technology: add-ins
GitHub Login: @o365devx
Microsoft Alias: o365devx

@xstos Thanks for asking about this. @exextoc Do you have any suggestions?
While this is not what you're looking for, there are several manifest validation options that may help resolve errors.
Thanks.

@xstos It seems we don't have a visual editor at this point. I'll see if we can add this to our backlog.
Thanks.

Ah I see. I posted it here, thinking the docs people would know since they would've documented it somewhere when creating tutorials. All addins pre-cloud (i.e. VSTO) had manifest editors and this isn't so much a feature request as a feature omission, which is probably deliberate given the tech stack has changed so dramatically. They don't need to be reminded of something that obvious... Thanks for your help though :)


Dockerless version?

Hey, would like to use the tool, but I have a love-hate relationship with Docker.
If I am the only one who'd like a standalone version, then ignore me, but I would really like to be able to run dca without needing docker ;).
Wonder what you think.

Hey @AbelLykens
You can, it's a PHP application based on PHP 7.4. You can clone the repository, install all the dependencies with composer install (see: https://getcomposer.org/).
After that, you should be able to add configuration to an .env file in the project directory and run ./bin/bitcoin-dca to fire off the tool. The rest of the steps should be pretty self explanatory.
If you need any more help, let me know.
Happy DCA'ing! :-)


Add support for code standards in root of repository for PHP_CodeSniffer 3.x

Problem/Motivation
PHP_CodeSniffer requires the coding standards to be in a directory, this behaviour changed in 3.x.
"The installed_paths config setting can now point directly to a standard. Previously, it had to always point to the directory in which the standard lives"
See the release notes:
https://github.com/squizlabs/PHP_CodeSniffer/releases/tag/3.0.0a1
This plugin does not support this yet.
Expected behaviour
Allowing a repository with a coding standard in the root of is project to work, when PHP_CodeSniffer 3.x or newer is used.
Actual behaviour
The coding standard won't be installed by this plugin.
Proposed changes
Change the coding standards search depth based on the PHP_CodeSniffer version used.

Added in #30, closing issue.


EPIC: Formalize ingestion process

Related to #37
This includes (in order to complexity to implement):

Update guidelines/documentation for scientists to verify that their COG's are well formated/contain a nodata value
Implement an S3 trigger that validates the COG formatting/nodata value

Implement a notification when the validation process fails

[IN PROGRESS]
Some thoughts on the ingestion pipeline:
Current process:
Contributing new datasets:
Scientists contact the developers to determine correct display options for the dataset (eg: color swatches, legend stops, rescaling factor, etc). A dataset metadata json file gets added to the API's codebase and the API gets deployed. Every 24hrs, the dataset metadata generator lambda reads through all the dataset metadata json files, and searches the S3 bucket for available dates for each dataset, and writes them to a json file in S3. The API then reads from this JSON file to display the datasets.
Contributing new data for existing datasets:
Most datasets are not regularly updated at this point (eg: xo2-* , pzd-anomaly, OMNO2d_*). For some datasets scientists contact either @olafveerman or myself directly by email and we take care of processing (if needed) and uploading the data to s3 (eg: agriculture-cropmonitor just needs to be uploaded to S3, nightlights-viirs is delivered as web-mercator tiles that need to be "stitched" together into COGs before being uploaded. This processing is done from my laptop, using a custom script).
Goal:
The goal of this ingest pipeline is to minimize as much as possible the manual steps needed when ingesting data during initial and recurring deliveries.
Unknowns:

Do scientists know how to use the AWS CLI/S3?
Do scientists know how to perform uploads using the command line (cURL)?
Do scientists know how to use github (eg: create a feature branch, open a PR)?
How much custom code are we willing to write for each data provider?
Do we have to notify data providers when their data fails upload?

Components:
Delivering the data:

Scientists can use the AWS CLI to copy data to an S3 bucket
An endpoint can be added to the API that generates a pre-signed S3 upload URL that can then be used with either:

A PUT request from the command line (using cURL for example)
A file upload widget in the front end

Triggering the ingest:

S3 Lambda trigger
EventBridge Rule

Ingest:
The steps the pipeline needs to perform (items in italics are to be discussed and confirmed):

Unzip files (if zipped)
Validate wether or not tiles are valid COGs, using rasterio's rio_cogeo.cogeo.cog_validate()
If the file is not a valid COG attempt to convert it to a COG using rasterio's rio_cogeo.cogeo.cog_translate()
If the COG generation fails abort the ingestion
4.1. Notify the scientist(s)
Gather all files with a same date and generate either a .vrt file or mosaicJSON mosaic, depending on which implementation we choose (see issue #139)
Move the files out of the ingestion folder and into their final location.

Some options for achieving this result include:
[TO BE UPDATED ONCE WE HAVE A BETTER IDEA OF CONSTRAINTS]

Lambda function
Stepfunction
ECS task
AWS Batch
Github Actions


Make editor's shortcut names translated on-site

When it's necessary to translate the name of a shortcut, the in-game solution is to automatically translate it when it's displayed (e.g. when the shortcut's name is displayed in a button's tooltip).
The editor code takes advantage of the fact that changing the editor language requires a restart. It translates the name once when the shortcut object is created.
Doing so leads to possible redundant double translations in the editor. It also creates inconsistencies in the way translations are done in the editor and in the game, which is not conducive to improving the translation system.
In this PR:

Use TTRC() instead of TTR() to mark a shortcut's name. TTRC() is just a marker and does not translate.
Modified the Shortcuts tab in the Editor Settings dialog so that the names of shortcuts are translated when displayed.

Note that the disadvantage of changing to TTRC() is that it does not support translation contexts. In theory, you still need to manually translate and change the name in NOTIFICATION_TRANSLATION_CHANGED in such case.
In editor codebase, the only place this happens is the tiles editor where we added context for Line. The shortcut is for drawing straight lines and needs to be distinguished from representing a line of text.
https://github.com/godotengine/godot/blob/cb411fa960f0b7fdbd97dcdb4c90f9346360ee0e/editor/plugins/tiles/tiles_editor_plugin.cpp#L313-L316
The translation context here could actually be eliminated if the name itself was more precise. Therefore, I took the liberty of suffixing these shortcuts' names with "Tool".
https://github.com/godotengine/godot/blob/4d20b21acd8387abfcbc01e50b6de293bc259479/editor/plugins/tiles/tiles_editor_plugin.cpp#L313-L316

Looks like it doesn't work well with Shortcut tooltips:

Expected:

The tooltip text uses TTR, so the text does not match.

The tooltip text uses TTR, so it does not match with shortcut name. The tooltip seems to be important in case the button has no shortcut assigned.

Updated the PR to change related tooltip texts to use TTRC.
Technically most button's tooltip text can be changed to use TTRC, which also has the benefit of avoiding redundant double translations. But here I've only touched those related to shortcuts, let's keep the PR small :stuck_out_tongue:

You missed this one (and possibly more?):
https://github.com/godotengine/godot/blob/38775731e8494a28deddc3febda895679f49fd6e/editor/plugins/node_3d_editor_plugin.cpp#L8895
Which exposed another problem, though not directly related. When you search for a shortcut in settings dialog, it will only match original English name. Before this PR the dialog only matched the translated name. I think it should match both. We can improve it later.


JSON property for the id of the user

The doc says this in various places:-
    "beneficiary": {
      "emailId"<EMAIL_ADDRESS>      "objectId": "<guid>",
      "tenantId": "<guid>",
      "pid": "<ID of the user>"
    },
    "purchaser": {
      "emailId"<EMAIL_ADDRESS>      "objectId": "<guid>",
      "tenantId": "<guid>",
      "pid": "<ID of the user>"
    },

but in actual responses I'm getting property puid instead of pid.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: f9463e77-5a47-08e3-56b5-fe215ec7893c
Version Independent ID: 9a60bc80-4bf0-0ed2-56e1-55ae88adfff5
Content: SaaS fulfillment Subscription APIs v2 in Microsoft commercial marketplace
Content Source: articles/marketplace/partner-center-portal/pc-saas-fulfillment-subscription-api.md
Service: marketplace
Sub-service: partnercenter-marketplace-publisher
GitHub Login: @arifgani
Microsoft Alias: argani

Thanks for bringing this to our attention. We will investigate it further and update you shortly.

@Bellarmine-Head Thanks for your feedback.
Assigning to content author @arifgani  for review.

The doc says this in various places:-
    "beneficiary": {
      "emailId"<EMAIL_ADDRESS>      "objectId": "<guid>",
      "tenantId": "<guid>",
      "pid": "<ID of the user>"
    },
    "purchaser": {
      "emailId"<EMAIL_ADDRESS>      "objectId": "<guid>",
      "tenantId": "<guid>",
      "pid": "<ID of the user>"
    },

but in actual responses I'm getting property puid instead of pid.
Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: f9463e77-5a47-08e3-56b5-fe215ec7893c
Version Independent ID: 9a60bc80-4bf0-0ed2-56e1-55ae88adfff5
Content: SaaS fulfillment Subscription APIs v2 in Microsoft commercial marketplace
Content Source: articles/marketplace/partner-center-portal/pc-saas-fulfillment-subscription-api.md
Service: marketplace
Sub-service: partnercenter-marketplace-publisher
GitHub Login: @arifgani
Microsoft Alias: argani

#please-close


Classes that represent Callable interfaces are not being rendered

Ex input
class TagCallable(Protocol):  # Should this be exported from htmltools?
    """
    Callable definition for a defined :class:`~htmltools.Tag` method.

    This is used to define the `container` argument in :func:`~shiny.experimental.ui.card_title`,
    :func:`~shiny.experimental.ui.card_header`, and :func:`~shiny.experimental.ui.card_footer`.

    See Also
    --------
    * :class:`~htmltools.Tag`
    """

    def __call__(
        self,
        *args: TagChild | TagAttrs,
        _add_ws: bool = True,
        **kwargs: TagAttrValue,
    ) -> Tagifiable:
        """
        A tag method.

        Parameters
        ----------
        *args
            Contents to the tag method. Or tag attributes that are supplied to the
            resolved `Tag` object.
        _add_ws
            Whether or not to add whitespace to the returned `Tag` object.
        **kwargs
            Additional HTML attributes for the returned Tag.

        Returns
        -------
        :
            A :class:`~htmltools.Tag` object.
        """
        ...

Rendered qmd content:
# experimental.ui.TagCallable { #shiny.experimental.ui.TagCallable }

`experimental.ui.TagCallable()`

## See Also

* [](:class:`~htmltools.Tag`)

Solution: Using custom renderer methods:
Custom renderer methods:
    @dispatch
    def render(self, el: dc.Alias):
        # If `el` is a protocol class that only has a `__call__` method,
        # then we want to display information about the method, not the class.
        if len(el.members) == 1 and "__call__" in el.members.keys():
            return self.render(el.members["__call__"])

        # Not a __call__ Alias, so render as normal.
        return super().render(el)

    @dispatch
    def signature(self, el: dc.Function, source: Optional[dc.Alias] = None):
        if el.name == "__call__":
            # Ex: experimental.ui._card.ImgContainer.__call__(self, *args: Tag) -> Tagifiable
            sig = super().signature(el, source)

            # Remove leading function name (before `__call__`) and `self` parameter
            # Ex: __call__(*args: Tag) -> Tagifiable
            sig = re.sub(r"[^`\s]*__call__\(self, ", "__call__(", sig, count=1)

            return sig

        # Not a __call__ Function, so render as normal.
        return super().signature(el, source)

Gives output like:

I did not submit a PR as this is not typically how classes are used and there isn't a clear cut solution. ... more of a preference.

Ah, thanks for documenting, and glad you found a solution! I think you can also use the .bases property to see if it inherited from protocol...
from quartodoc import get_object

obj = get_object("shiny.experimental.ui.TagCallable")

# may need to check obj.is_class first
obj.bases


Breakpoints not working

VSCode Version: Code 1.11.2 (6eaebe3b9c70406d67c97779468c324a7a95db0e, 2017-04-13T08:03:11.395Z)
OS Version: Windows_NT ia32 10.0.15063
Extensions:

Extension
Author
Version

html-snippets
abusaidm
0.1.0

vue-snippets
hollowtree
0.1.1

vue
jcbuisson
0.1.5

vue
liuji-jim
0.1.5

vue-beautify
peakchen90
2.0.4

Steps to Reproduce:

Please give reproducable steps and I will reopen.
What language are you debugging? What to do in order to get the same behavior on my machine to try to investigate?


Crash in Connecting Signal Window when clicking in empty space inside the Connect To Node area

Godot version:
Godot 3.0 Beta 1 mono win64
OS/device including version:
Windows 7 Professional SP1 64 bit
Issue description:
When connecting Signals the Window which opens leads to a crash when clicking anywhere in the empty area in the "Connect To Node" area.
Steps to reproduce:

Create new Project
Create Area2D Node
Select Node, and under Node tab add any Signal
In "Connecting Signal" window, click in "Connect To Node" area anywhere other than the Area2D item

I can't reproduce this on 3068ccc8e69aad68c860ce8688bdc6d41107be1b on Linux/x86_64 would it be possible for you to create a video or gif of exactly what you're doing?
Could you also try with the freshly released beta 2?
Thanks!

Problem is solved in Beta 2

Closing as solved then.


Remove unused var and redundant raise in Vernier::Output::Firefox

I ran into this failure when trying this tool out using Ruby 3.2.2.

/Users/[redacted]/.rbenv/versions/3.2.2/lib/ruby/gems/3.2.0/gems/warning-1.3.0/lib/warning.rb:260:in `warn': /Users/[redacted]/.rbenv/versions/3.2.2/lib/ruby/gems/3.2.0/gems/vernier-0.3.0/lib/vernier/output/firefox.rb:240: warning: assigned but unused variable - size (RuntimeError)
        from /Users/[redacted]/.rbenv/versions/3.2.2/lib/ruby/gems/3.2.0/gems/vernier-0.3.0/lib/vernier.rb:7:in `require_relative'
        from /Users/[redacted]/.rbenv/versions/3.2.2/lib/ruby/gems/3.2.0/gems/vernier-0.3.0/lib/vernier.rb:7:in `<top (required)>'
        from <internal:/Users/[redacted]/.rbenv/versions/3.2.2/lib/ruby/3.2.0/rubygems/core_ext/kernel_require.rb>:37:in `require'
        from <internal:/Users/[redacted]/.rbenv/versions/3.2.2/lib/ruby/3.2.0/rubygems/core_ext/kernel_require.rb>:37:in `require'
        ...
rake aborted!
Command failed with status (1)
/Users/[redacted]/.rbenv/versions/3.2.2/bin/bundle:25:in `load'
/Users/[redacted]/.rbenv/versions/3.2.2/bin/bundle:25:in `<main>'
Tasks: TOP => default => test
(See full trace by running task with --trace)

This PR removes the unused var and also removes a redundant raise I noticed.

Thanks!


response status

tell me how this module can I get a response code?

I don't understand the question. Please add more detail, including an example of some code that works in web browsers but does not work in jsdom.

Yes, now delete committees

simple ... eg if code
var jsdom = require("jsdom");

jsdom.env({
  url: "http://news.ycombinator.com/",
  scripts: ["http://code.jquery.com/jquery.js"],
  done: function (err, window) {
    var $ = window.$;
    console.log("HN Links");
    $("td.title:not(:last) a").each(function() {
      console.log(" -", $(this).text());
    });
  }
});

I need to in addition to html I could get a response status (for example: 200, 301, 404, etc.)

Again, you can give an example of code that works in web browsers but does not work in jsdom?

I'm using this code is not in the browser, and in iojs

Right. The purpose of jsdom is to provide an emulation of browser APIs. If the browser does not contain an API for something, then jsdom will not implement it.
So although I still cannot tell exactly what you are asking for, I get the feeling that it is out of scope for jsdom.

The bottom line is that the browser response to the request contained in the headlines, but how to get it in jsdom I do not know

OK. Well, since there is no code you can write that does this in a browser, there is no code you can write in jsdom that does it either, and there never will be.

what you will want to do is: Use whatever library you like to make the http request, this gives you status codes, headers, content etc. Then pass the html to jsdom.

another question ...
Can using jsdom determine whether the connected js library (eg jquery) or not

You may be able to access window.$ or window.jQuery to determine if they're used.

I have a slightly different time meant ... I asked to ensure that it was possible to know in advance, to connect the same jquery or not
I'm interested in the participation of the code
var jsdom = require("jsdom");
jsdom.env({
url: "http://news.ycombinator.com/",
scripts: ["http://code.jquery.com/jquery.js"],
done: function (err, window) {
var $ = window.$;
console.log("HN Links");
$("td.title:not(:last) a").each(function() {
console.log(" -", $(this).text());
});
}
});


Allow the use of several external layers

Is this feature request related to a new or existing Amplify category?
function
Is this related to another service?
Lambda
Describe the feature you'd like to request
Via amplify cli, we are not able to add several external layers to a lambda function.
We can only add 1 external layer.
We need to manually update the cloudformation file if we need more layers.
Describe the solution you'd like
update amplify cli to allow us to add several layer.
Describe alternatives you've considered
update manually cf file to link the layer
Additional context
No response
Is this something that you'd be interested in working on?

[ ] 👋 I may be able to implement this feature request

Would this feature include a breaking change?

[ ] ⚠ This feature might incur a breaking change

Hey @kouz75, thank you for reaching out. Amplify CLI does allow Lambda function to add multiple layers upto 5 layers.

We can use amplify update function or amplify add function to add the layers external arn's. The input requires users to add layers using a comma separated input.


resolveOptions method may only be the string "string" rather an any string

https://github.com/cmorten/opine-http-proxy/blob/03f79cb2cf535529be7a3638048ef5481add104b/src/resolveOptions.ts#L170
Mandates the optional key to have the value "string", it should either be string or "GET"|"POST"|....

Hey @retog :wave:
Thanks for raising this, I have released a fix in 3.0.1 (https://deno.land/x/opineHttpProxy@3.0.1).


IAM Server Certificate Resource

As a Chef user, I would like to be able to upload SSL certificates to IAM. See http://docs.aws.amazon.com/IAM/latest/UserGuide/InstallCert.html

Let's see if we can make this happen next week.

:+1:

We'll have to get to this after 1.3.0, but it would be good to do since we are tackling


Call to undefined function RenokiCo\PhpK8s\yaml_parse()

When calling fromYamlFile() it raises
Call to undefined function RenokiCo\PhpK8s\yaml_parse()
I could fix it by changing yaml_parse($yaml, -1) to \yaml_parse($yaml, -1) in line 30 in K8s.php but I don't know if this will break something else...

Install the PHP YAML extension.


Update the lockfile version

Otherwise, every run of npm starts with:
npm WARN old lockfile The package-lock.json file was created with an old version of npm,
npm WARN old lockfile so supplemental metadata must be fetched from the registry.

#597


Increase the registry's group attribute description.

What is the purpose of the change
Optimize the document. #144
Brief changelog
Increase the registry's group attribute description.
Follow this checklist to help us incorporate your contribution quickly and easily:

[x] Make sure there is a GITHUB_issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
[ ] Format the pull request title like Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
[x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[ ] Test your code locally by running docsite start, and make sure it works as expected.
[ ] Make sure no files under build directory is added.
[ ] If this contribution is large, please follow the Software Donation Guide.

LGTM


Fix stack level too deep error if target directory contains **

RuboCop exits with SystemStackError because "stack level too deep" if the target directory has the "**" directory.
foo
└── **
    └── bar.rb

Traceback (most recent call last):
        9197: from exe/rubocop:12:in `<main>'
        9196: from /Users/unasuke/.rbenv/versions/2.7.1/lib/ruby/2.7.0/benchmark.rb:308:in `realtime'
        9195: from exe/rubocop:13:in `block in <main>'
        9194: from /Users/unasuke/src/github.com/rubocop-hq/rubocop/lib/rubocop/cli.rb:41:in `run'
        9193: from /Users/unasuke/src/github.com/rubocop-hq/rubocop/lib/rubocop/cli.rb:72:in `execute_runners'
        9192: from /Users/unasuke/src/github.com/rubocop-hq/rubocop/lib/rubocop/cli.rb:65:in `run_command'
        9191: from /Users/unasuke/src/github.com/rubocop-hq/rubocop/lib/rubocop/cli/environment.rb:18:in `run'
        9190: from /Users/unasuke/src/github.com/rubocop-hq/rubocop/lib/rubocop/cli/command.rb:11:in `run'
         ... 9185 levels...
           4: from /Users/unasuke/src/github.com/rubocop-hq/rubocop/lib/rubocop/target_finder.rb:101:in `wanted_dir_patterns'
           3: from /Users/unasuke/src/github.com/rubocop-hq/rubocop/lib/rubocop/target_finder.rb:101:in `flat_map'
           2: from /Users/unasuke/src/github.com/rubocop-hq/rubocop/lib/rubocop/target_finder.rb:101:in `each'
           1: from /Users/unasuke/src/github.com/rubocop-hq/rubocop/lib/rubocop/target_finder.rb:101:in `block in wanted_dir_patterns'
/Users/unasuke/src/github.com/rubocop-hq/rubocop/lib/rubocop/target_finder.rb:97:in `wanted_dir_patterns': stack level too deep (SystemStackError)

If directory name end with /**/, escape dir name to /\**\ to inspect files under the **/ directory.

Before submitting the PR make sure the following are checked:

[x] Wrote good commit messages.
[x] Commit message starts with [Fix #issue-number] (if the related issue exists).
[x] Feature branch is up-to-date with master (if not - rebase it).
[x] Squashed related commits together.
[x] Added tests.
[x] Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.
[x] The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
[x] Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.

I need advice on what to do windows environment...

Cannot create a directory with containing * charactor on Windows.
https://docs.microsoft.com/en-us/windows/win32/fileio/naming-a-file#naming-conventions
So I disabled the test case in Windows...

The changes look good, but your branch has to be rebased on top of the current master branch due to merge conflicts.

The changes look good, but your branch has to be rebased on top of the current master branch due to merge conflicts.

In the future, you can use the new way to handle changelog entries (rake changelog:..., see CONTRIBUTING) to avoid these

Thank you. I rebased this.

Thanks!


path info according to __file__

Hi,
Above all, thank you for sharing this great package.
I have a setting according to the __file__, but the file location is not based on the file itself, but the include calling file. For example, when I have setting files as:
settings.__init__.py
settings/components/__init__.py
settings/components/common.py
settings/components/others.py

and if assume that include is calling components/common.py that contains the __file__ based setting. I expected the __file__ == settings/components/common.py but the actual value is settings.__init__.py.
if I have another setting in components/others.py and need to import from settings.components.common import VARS where the VARS is the setting based on __file__, then the value of the VARS becomes different.
Can I have any hint to solve this conflict? Thank you!

Sorry, I don't understand your problem 😞
Can you please post a reproduction?

I have no public github so let me explain a little bit more detail here:
dirs/files structure:

settings/__init__.py
settings/components/__init__.py
settings/components/common.py
settings/components/apps.py
settings/environments/__init__.py
settings/environments/development.py

settings/__init__.py:

from split_settings.tools import include, optional

# Include settings:
base_settings = [
    'components/common.py',
    'components/apps.py',
    'environments/developement.py',
]

include(*base_settings)

settings/components/apps.py:
...
from pathlib import Path
...
VAR1 = Path(__file__).parent.joinpath('components', 'app_list.txt')
print(VAR1)
VAR2 = 'something'
...

settings/environments/__init__.py:

from settings.components.apps import VAR2

# doing with VAR2 here

In this configuration, the components/apps.py will be imported twice; from settings/__init__.py and from settings.environments/__init__.py. When I run using this configs, I've got the VAR1 printouts like:
.../settings/components/app_list.txt
.../settings/components/components/app_list.txt

I hope this will be sufficient to explain my issue. Thank you!

I'm experiencing the same issue. Here's the problem as I understand it:
Let's I have project/settings/components/module_one.py which contains
my_path = Path(__file__).parent

And I also have project/settings/components/module_two.py with
from project.settings.components.module_one import my_path

my_other_path = my_path

Now, when include() is executed inside project/settings/__init__.py:

we execute the contents of module_one.py in the context of the project/settings/__init__.py, so the value of my_path becomes project/settings

we execute the contents of module_two.py, also in the context of the project/settings/__init__.py. However, since we import module_one from its original location, __file__ now evaluates to project/settings/components/module_one.py, so the value of my_other_path becomes project/settings/components

For now I work around the problem by fixing all paths that are calculated relative to __file__ in project/settings/__init__.py after include() is executed.

I just came across this issue and I noticed that the variables that are processed by the include function of the library are included in the global variables. So:
settings/environments/__init__.py:

from settings.components.apps import VAR2

# doing another thing with VAR2 here

Would just be:
settings/environments/__init__.py:

# doing another thing with VAR2 here

Without the import, and you'll have VAR2 available even if you do not import it. And no double import.
However bear in mind that if you have an IDE or mypy in place it's gonna complain, so that's not too clean either.


PairwiseSetOperations.aNotB throws ArrayOutOfBoundsException

Reproduced with:
        UpdateSketch one = new UpdateSketchBuilder().setNominalEntries(4096).build();
        UpdateSketch two = new UpdateSketchBuilder().setNominalEntries(4096).build();
        UpdateSketch three = new UpdateSketchBuilder().setNominalEntries(4096).build();
        for (int i = 0; i < 1_000_000; i++) {
            one.update(i);
            two.update(1_000_000 + i);
            three.update(2_000_000 + i);
        }
        PairwiseSetOperations.aNotB(PairwiseSetOperations.intersect(one.compact(), two.compact()), three.compact());

The bug itself doesn't seem to be in the implementation of aNotB, but rather that CompactSketch.isEmpty() (which aNotB checks) is deceiving, and may return false despite the internal array being length 0.  When aNotB checks to see if the sketch is empty, it sees it is not, and then proceeds to attempt the set difference which fails to the zero length array.  If you attempt the same thing, but replace one.compact() with a newly constructed empty sketch, aNotB works as expected.

The problem is this line of PairwiseSetOperations
    return HeapCompactOrderedSketch
        .compact(Arrays.copyOf(outCache, outCount), emptyRule, seedHash, outCount, thetaLong);

In the case of the intersection above outCache is the size of the min of the two inner caches (non-zero) and filled with 0's (since the two sets dont overlap).  outCount is 0.  Arrays.copyOf(outCache, outCount) then will produce a 0 len array.  The empty param is set based on whether either of the input sketches was empty instead of whether the result of the intersection is empty.

False alarm, I was using the 0.12.0 version.  This issue seems to be fixed in the latest distribution


#9681: Add name attribute for ttnn.Operation

Ticket
#9681
Problem description
ttnn operations have no __name__ attribute. See ticket for more info.
What's changed

Assign the python_fully_qualified_name to the __name__ attribute for ttnn operations when fast_runtime_mode is enabled.
When fast_runtime_mode is disabled: https://github.com/tenstorrent/tt-metal/pull/9730

Checklist

[ ] Post commit CI passes
[ ] Model regression CI testing passes (if applicable)
[ ] New/Existing tests provide coverage for changes

Closing this since Akhmed has an improved version here: https://github.com/tenstorrent/tt-metal/commit/c3042ac99e8cb1ad45b09f6bec1eda3c5b6656d9


Untar directory with archive perms as default

This PR modifies the default behavior for extracting a directory. Previously the extracted dir would have the system default perms. Now, the directory will have the same permissions as the tar file.
Resolves #134

Thanks! Could a test be added for this?

Could a test be added for this?

@alexcrichton test added 😄

Thanks!


Cherry pick https://github.com/istio/istio/pull/24818

Manual cherry-pick of https://github.com/istio/istio/pull/24818
[ ] Configuration Infrastructure
[ ] Docs
[X] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure

Hi @S-Chan. Thanks for your PR.
I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

/ok-to-test

@S-Chan: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-test_istio_release-1.6
643fd0daf54abd7ed53b46c2ab03afa4ba168415
link
/test release-test_istio_release-1.6

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

@S-Chan: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-test_istio_release-1.6
643fd0daf54abd7ed53b46c2ab03afa4ba168415
link
/test release-test_istio_release-1.6

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test release-test_istio_release-1.6

@S-Chan: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-test_istio_release-1.6
643fd0daf54abd7ed53b46c2ab03afa4ba168415
link
/test release-test_istio_release-1.6

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

@S-Chan: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-test_istio_release-1.6
643fd0daf54abd7ed53b46c2ab03afa4ba168415
link
/test release-test_istio_release-1.6

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

@S-Chan: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-test_istio_release-1.6
643fd0daf54abd7ed53b46c2ab03afa4ba168415
link
/test release-test_istio_release-1.6

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest


Help Sciety know about changes to PREreviews

I've created a branch in the Sciety repo that makes it easier to test ingestion for a group on localhost.
https://github.com/sciety/sciety/compare/easier-localhost-ingestion-dev
On it you can use:
make ingestion-dev

# in another terminal:
make ingest-evaluations INGEST_ONLY=prereview INGEST_DEBUG=true

Thanks @erkannt, looks to be working.


Add support for timeParserPolicy=LEGACY

Closes #2860
This PR adds support for parsing strings to date/timestamp when spark.sql.legacy.timeParserPolicy=LEGACY for the following formats:

dd-MM-yyyy
dd/MM/yyyy
yyyy/MM/dd
yyyy-MM-dd
yyyy/MM/dd HH:mm:ss
yyyy-MM-dd HH:mm:ss

We are not 100% compatible with Spark on CPU in all cases so this support is only enabled when spark.rapids.sql.incompatibleDateFormats.enabled is also set to true. We have the following limitations when running on the GPU:

Only 4-digit years are supported
The proleptic Gregorian calendar is used instead of the hybrid Julian+Gregorian calendar that Spark uses in legacy mode, so we produce different results for dates prior to the Gregorian calendar starting.

During manual performance testing, I ran into some behavior that I don't understand yet, so I am changing this to a draft / WIP for now.

During manual performance testing, I ran into some behavior that I don't understand yet, so I am changing this to a draft / WIP for now.

The issue was that I had ANSI mode enabled when manually testing, and hadn't implemented ANSI support as part of this PR. It is now updated to fall back to CPU if LEGACY + ANSI are both enabled. If we do want to support LEGACY + ANSI together then we can do that as a follow-on issue.

build

build


[Relay/TOPI][Op] Add erf intrinsic and op

Need to add whitelist for vectorization

Would you mind also adding this to the TensorFlow frontend? The op name is Erf.

@soiferj Sure, will add it.

@icemelon9 , is there a timeline to get this PR ready for review? This would be really nice to unblock running BERT-based models!

@soiferj Sorry about the delay. I was working on the dynamic shape function support for Any. I'll start updating this PR this week.

@tqchen Could you help check if the vectorizable intrinsic list is complete?

Thanks @icemelon9 @yongwww


unresolved external symbol error

All include and lib directory is added, but seam like linker can find the Bullet lib, I don't know is the issue of build Bullet or the config issue in DeepMimic, I'm kind new to C++ frankly, always use the python, so, please help : )

It's not that problem, but I Inexplicable solved some how, anyway thank you, did you know the DeepMotion? look like they did the same thing but they sell the software for game Developer end of this year so they can taring the Character and use them in UE4 or unity, will you continue research on this area or you will build some free software do same things for game Developer or ...?

Yeah, interesting won't it?you are Chinese and His too, and so am I :) I actually want to solve this few week ago, and then I saw you research, then I want bring it to UE4 game engine, and then I see the DeepMotion...so now I can focus on the game I want build. by the way I'm Chinese two but not like you guys, I'm born and live in China, witch is so suck, because there is no environment for AI research or any interesting Scientific research, only boring company and stupid job.


Missing county data in snapshot  for VT and NH on 04/02

https://coronadatascraper.com/#data.csv
Expected values for counties in VT and NH
https://coronadatascraper.com/#data.cs

I see the data in the map:

Is the JSON file more reliable for data?

Can you recheck this tomorrow? It might have been already fixed with the fips: migration with @lazd.

checking now but it appears there is a bigger issue, I don't see any data in time series or snapshot for the US:
which is coincidentally issue 666, https://github.com/covidatlas/coronadatascraper/issues/666

@caticoa3 please check again, I think we got it this time! Close this issue if so please!

@lazd sure thing, the data are there now. Although I was a bit thrown off at first because I searched with state abbreviation and now the full state is listed. Closing this. Thanks.


add typings and update docs

Context

[x] Add typings
[x] Updates documentation to provide typing and tailwind integration examples

Closing in favor of https://github.com/mattvalleycodes/variant-classnames/pull/10


fix(v2): do not escape html and body attributes

Motivation
The attributes of html element and body element are escaped during SSR.

Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
Open the rendered HTML document.

thanks. can you update https://github.com/facebook/docusaurus/blob/master/CHANGELOG-2.x.md too ?

okay!


Fix nav menu at top of window

Long pages scroll the nav menu off the top of the page. Sometimes it is preferred to fix the menu at the top of page and let content scroll past/underneath it. The following additions to the "nav" entry will enable this:
  position: fixed;
  top: 0;
  z-index: 30;

It could be left as a comment in the css rather than imposing on all naive users. The "margin-bottom : 7rem" might be revised if the menu is fixed. Other page content must start below the height of the menu or the first line(s) will be hidden.

Thanks! I think I'll leave it out for the time being as I could go down the rabbit hole of commented out styling variations, but thanks for posting the code here for anyone that wants to implement it.


feat: implement soft reset, use it on startup

This PR adds support for the SoftReset command that can be used to restart a hanging controller. We now also use it during the startup procedure as recommended by the specs. Hopefully this fixes the problem where the controller seems stuck after a container reboot.
Note: USB modules will reconnect when this is called, meaning that they might get a new address. This shouldn't be a problem when using the /dev/serial-by-id/ approach on Unix.

Is the driver going to 'wait' for this re-connect, and pick up where left off, assuming it isn't going to throw, due to the sick looking like it was pulled?.
any disconnects after this of course, should throw right?

I've only tested on Windows so far where this isn't a problem. On unix, the address might change from /dev/tty0 to /dev/tty1, which will probably cause the driver to fail.

On the basis the port name will remain.
When the stick becomes 'disconnected' due to it restating - in normal circumstance. this will throw the driver  => ZWaveErrorCodes.Driver_Failed
Assuming the driver wont throw during this reset routine, unless the port name has changed of course

Both I'm not sure about. Ideally the driver shouldn't throw when restarting the stick. If it does, I need to handle it.

Here.
https://github.com/zwave-js/node-zwave-js/blob/97049155c017b4267a60d54c963fcb493716dc08/packages/serial/src/ZWaveSerialPort.ts#L35
This reset may trigger close due to the USB device being 'disconnected' - whilst brief, is still being momentarily disconnected.
if this is going to trigger - maybe 'turn a blind eye' when we know we are resetting, to stop the exception from bubbling up.

Error in driver ZWaveError: The serial port closed unexpectedly!
    at SerialPort.<anonymous> (/app/node_modules/@zwave-js/serial/src/ZWaveSerialPort.ts:39:10)
    at SerialPort.emit (events.js:400:28)
    at SerialPort.emit (domain.js:470:12)
    at binding.close.then.closing (/app/node_modules/@serialport/stream/lib/index.js:435:12) {
  code: 5,
  context: undefined,
  transactionSource: undefined
}
2021-09-01T16:20:39.323Z DRIVER   destroying driver instance...

 Now I need to figure out how to test this 😅

Maybe add a flag to the serial class, before calling the soft reset.
isSoftResetActive
then set it back to false after?
and on the 'closed' event, ignore it if isSoftResetActive is true

I'm talking about a reproduction, not how to solve it ;)

The feature flag works as expected in Docker, however the timeout of 1.5 seconds is too quick on my test system.
2021-09-01T22:00:22.437Z DRIVER » [REQ] [SoftReset]
2021-09-01T22:00:22.447Z SERIAL « [ACK]                                                                   (0x06)
2021-09-01T22:00:23.956Z DRIVER   Serial port errored: Error: No such file or directory, cannot open /dev/serial
                                  /by-id/usb-0658_0200_E2061B02-4A02-0114-3A06-FD1871291660-if00
Error in driver [Error: Error: No such file or directory, cannot open /dev/serial/by-id/usb-0658_0200_E2061B02-4A02-0114-3A06-FD1871291660-if00]

The syslog timestamp is not very precise, but the reset occurs after the ACK by at least half a second:
Sep  1 15:00:23 koro kernel: [3255188.206135] usb 1-3: USB disconnect, device number 26
Sep  1 15:00:23 koro kernel: [3255188.511293] usb 1-3: new full-speed USB device number 27 using xhci_hcd
Sep  1 15:00:23 koro kernel: [3255188.660210] usb 1-3: New USB device found, idVendor=0658, idProduct=0200, bcdDevice= 0.00
Sep  1 15:00:23 koro kernel: [3255188.660213] usb 1-3: New USB device strings: Mfr=0, Product=0, SerialNumber=1
Sep  1 15:00:23 koro kernel: [3255188.660215] usb 1-3: SerialNumber: E2061B02-4A02-0114-3A06-FD1871291660
Sep  1 15:00:23 koro kernel: [3255188.662363] cdc_acm 1-3:1.0: ttyACM0: USB ACM device

stat shows the device creation time in detail, and it looks like it was created after zwave-js gave up:
# stat /dev/ttyACM0
  File: /dev/ttyACM0
  Size: 0               Blocks: 0          IO Block: 4096   character special file
Device: 6h/6d   Inode: 246705006   Links: 1     Device type: a6,0
Access: (0660/crw-rw----)  Uid: (    0/    root)   Gid: (   20/ dialout)
Access: 2021-09-01 15:00:23.998486168 -0700
Modify: 2021-09-01 15:00:23.998486168 -0700
Change: 2021-09-01 15:00:23.998486168 -0700
 Birth: -

Maybe a more reasonable timeout would be around 5 seconds (configurable?), or instead perform some kind of polling (or use inotify) to detect when the device path is available again?

I'll play with that tomorrow - thanks for testing

@kpine The driver now tries up to 10 times (with a pause of 1s inbetween) to open the serial port. Could you test again?

@kpine The driver now tries up to 10 times (with a pause of 1s inbetween) to open the serial port. Could you test again?

Sure. Could you publish a test package?

@zwave-js-bot pack this

LGTM
2021-09-05T23:23:00.028Z DRIVER   version 8.2.4-0-pr-3262-aaea250
2021-09-05T23:23:00.029Z DRIVER
2021-09-05T23:23:00.029Z DRIVER   starting driver...
2021-09-05T23:23:00.041Z DRIVER   opening serial port /dev/ttyACM0
2021-09-05T23:23:00.049Z DRIVER   serial port opened
2021-09-05T23:23:00.050Z SERIAL » [NAK]                                                                   (0x15)
2021-09-05T23:23:00.052Z CNTRLR   performing soft reset...
2021-09-05T23:23:00.118Z SERIAL » 0x01030008f4                                                         (5 bytes)
2021-09-05T23:23:00.121Z DRIVER » [REQ] [SoftReset]
2021-09-05T23:23:00.131Z SERIAL « [ACK]                                                                   (0x06)
2021-09-05T23:23:02.649Z DRIVER   loading configuration...
2021-09-05T23:23:02.749Z CONFIG   Synchronizing external config dir /cache/db...
2021-09-05T23:23:02.949Z SERIAL « 0x010a000a0300010201015ea1                                          (12 bytes)
2021-09-05T23:23:02.950Z SERIAL » [ACK]                                                                   (0x06)
2021-09-05T23:23:02.979Z DRIVER « [REQ] [UNKNOWN_FUNC_UNKNOWN_0x0a]
                                    payload: 0x0300010201015e
2021-09-05T23:23:02.982Z DRIVER   handling request UNKNOWN_FUNC_UNKNOWN_0x0a (10)
2021-09-05T23:23:02.982Z DRIVER     no handlers registered!
2021-09-05T23:23:07.522Z CONFIG   Using external configuration dir /cache/db
2021-09-05T23:23:07.522Z CONFIG   version 8.2.4-0-pr-3262-aaea250
2021-09-05T23:23:12.043Z CONFIG   Device index regenerated
2021-09-05T23:23:12.043Z CONFIG   Priority device configuration directory /cache/config not found
2021-09-05T23:23:12.060Z DRIVER   beginning interview...
2021-09-05T23:23:12.061Z DRIVER   added request handler for AddNodeToNetwork (0x4a)...
                                  1 registered
2021-09-05T23:23:12.061Z DRIVER   added request handler for RemoveNodeFromNetwork (0x4b)...
                                  1 registered
2021-09-05T23:23:12.062Z DRIVER   added request handler for ReplaceFailedNode (0x63)...
                                  1 registered
2021-09-05T23:23:12.063Z CNTRLR   beginning interview...
2021-09-05T23:23:12.063Z CNTRLR   querying version info...
2021-09-05T23:23:12.137Z SERIAL » 0x01030015e9                                                         (5 bytes)
2021-09-05T23:23:12.137Z DRIVER » [REQ] [GetControllerVersion]
2021-09-05T23:23:12.139Z SERIAL « [ACK]                                                                   (0x06)
2021-09-05T23:23:12.140Z SERIAL « 0x011001155a2d5761766520362e3130000797                              (18 bytes)
2021-09-05T23:23:12.141Z SERIAL » [ACK]                                                                   (0x06)
2021-09-05T23:23:12.142Z DRIVER « [RES] [GetControllerVersion]
                                    payload: 0x5a2d5761766520362e31300007
2021-09-05T23:23:12.145Z CNTRLR   received version info:
                                    controller type: Bridge Controller
                                    library version: Z-Wave 6.10

@zwave-js-bot pack this

@zwave-js-bot pack this

@zwave-js-bot pack this

This will be included in https://github.com/zwave-js/node-zwave-js/pull/3525


Loadmore option not working

Loadmore option for single day and daily posts are not working in mozilla

It is seen that Crunch Hunt site also has this problem in Firefox. Whicle clicking on 'Load More' an error comes as below
ReferenceError: event is not defined
...Limit.get(),loadMoreHandler:function(e){event.preventDefault();var a=e.postsLimi...
4cb54fb...1c35.js (line 261, col 7343)

Load more also causes an Aw Snap! crash in the tab on Chrome 43.0.2357.81 (64-bit) for OS X.
Load more also crashes Safari on iOS 7.1.2 after a few taps, and causes A problem occurred with this webpage so it was reloaded dialog in Safari on iOS 8.3 after 4-5 taps.

I thought i was doing something. Good i found this ticket! Following...

Not sure why this is browser-specific, but commenting out event.preventDefault() in the loadMoreHandler restores functionality in my FF case.

Same here; Load More works in Firefox with event.preventDefault() commented out, and Chrome on OS X seems to load many pages without the tab crashing anymore. However, Safari on iOS still crashes after 4-5 taps of Load More.

This still hasn't been fixed yet.

Seems to work for me on http://meta.telescopeapp.org/ (Firefox Mac OS). Do you still see the problem there?

@SachaG http://meta.telescopeapp.org/ is working fine for me. I am using Firefox.
However my local, clean Telescope installation doesn't work.

@SachaG I saw you removed that line. Any idea how to update Telescope to the master version via Meteor? I would like to test it out. Thanks.

@SachaG Oh you just released a new version. It fixs the problem. Thanks :+1:

:) Seems to be working fine now. Thanks!

Awesome, thanks to @kayue for identifying the problem :)


fix: fixed runCallbacksOnInit bugs

fixed #2807

Thanks!

ver. 4.5.0
runCallbacksOnInit set to false, swiper sitll fires TransitionStart TransitionEnd events when initialSlide is nonzero value, with fade effect


Better documentation on how to write gulp-sourcemaps plugin

I'm trying to integrate gulp-sourcemaps to my project but the documentation is somewhat limited. From the doucmentation , the below lines:
    // apply source map to the chain
    if (file.sourceMap) {
      applySourceMap(file, result.map);
    }

have the undescribed result.map  there is no hint on how to implement the line or where to get documentation from.

How to generate a source map highly depends on your plugin. If your plugin uses another library for manipulating source code, changes are good that it can also generate a source map. Otherwise you need to generate a source map corresponding to the changes your plugin does to the sources. For more information see e.g.:

http://www.html5rocks.com/en/tutorials/developertools/sourcemaps/?redirect_from_locale=it
https://docs.google.com/document/d/1U1RGAehQwRypUTovF1KRlpiOFze0b-_2gc6fAH0KY0k/edit


Subdomain for LoginPath

How can you make identity use a subdomain as the LoginPath?
When authenticating on app1.mysite.com, app2.mysite.com, etc... I want my account management, sign on, etc... to be on account.mysite.com.
Thanks!

You don't. Identity isn't meant for this type of federation. Login paths are limited to being relative URLs.


{http_resp_Location_1} not working on Request

Using the placeholder as specified {http_resp_Location_1} does not work when matching or setting on the Request.  This used to work - I believe this is an issue with the app gateway.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: aedb5a9b-70bd-506d-41c7-2ede4e12e116
Version Independent ID: b55a0075-80ff-a967-3d9d-8429e7663b8c
Content: Rewrite HTTP headers with Azure Application Gateway
Content Source: articles/application-gateway/rewrite-http-headers.md
Service: application-gateway
GitHub Login: @vhorne
Microsoft Alias: absha

@lonevvolf This should be working as outlined in the docs. If you are seeing different behavior, your best bet is to create a support request to troubleshoot this further. If you do not have a support plan / cannot create a support request, please let me know.

@lonevvolf We will now proceed to close this thread. If there are further questions regarding this matter, please tag me in your reply. We will gladly continue the discussion and we will reopen the issue.


Ensure sorting imports in a modified file picks up the proper configuration

Fixes #4891.

[x] Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
[x] Title summarizes what is changing
[x] Has a news entry file (remember to thank yourself!)
[x] Appropriate comments and documentation strings in the code
[x] Has sufficient logging.
[x] ~Has telemetry for enhancements.~
[ ] Unit tests & system/integration tests are added/updated
I've updated the existing functional tests, though I'm not sure how best to regression test this. Are there some isort integration tests somewhere I can extend?
[ ] Test plan is updated as appropriate
[x] ~package-lock.json has been regenerated by running npm install (if dependencies have changed)~
[ ] The wiki is updated with any design decisions/details.

Codecov Report

Merging #9128 into master will decrease coverage by 0.7%.
The diff coverage is 57.14%.

@@            Coverage Diff             @@
##           master    #9128      +/-   ##
==========================================
- Coverage   57.07%   56.37%   -0.71%
==========================================
  Files         551      551
  Lines       29168    28796     -372
  Branches     4411     4409       -2
==========================================
- Hits        16647    16233     -414
- Misses      11613    11658      +45
+ Partials      908      905       -3

Impacted Files
Coverage Δ

src/client/common/process/types.ts
100% <ø> (ø)
:arrow_up:

src/client/common/process/proc.ts
14.18% <0%> (-1.38%)
:arrow_down:

src/client/providers/importSortProvider.ts
78.26% <100%> (+2.93%)
:arrow_up:

...nt/datascience/jupyter/invalidNotebookFileError.ts
0% <0%> (-60%)
:arrow_down:

src/client/formatters/serviceRegistry.ts
50% <0%> (-50%)
:arrow_down:

src/datascience-ui/native-editor/redux/store.ts
50% <0%> (-50%)
:arrow_down:

src/datascience-ui/history-react/redux/store.ts
50% <0%> (-50%)
:arrow_down:

src/datascience-ui/react-common/logger.ts
0% <0%> (-40%)
:arrow_down:

...cience/jupyter/jupyterDebuggerNotInstalledError.ts
33.33% <0%> (-33.34%)
:arrow_down:

src/datascience-ui/react-common/locReactSide.ts
16.66% <0%> (-33.34%)
:arrow_down:

... and 46 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c1e863...5a97a63. Read the comment docs.

@PeterJCLaw Thank you for the PR. Can you look at the merge conflicts?

@karthiknadig /cc

@DonJayamanne thanks for the feedback.
The change to execObservable here was in order to keep the same interface between it in exec, though I agree it's a little contrived. I'd be happy to drop part of these changes and/or consider an alternative interface for exec.
Currently the isort provider uses exec and I'd hoped for a minimally invasive change by using the SpawnOptions to pass the input.
I had hoped that it would be generally useful to be able to pass arbitrary input to an exec and as that's the method used by the isort provider currently I think it would make keep that being the case.
An alternative change I had considered (but decided against) would be to have exec accept another (optional) parameter of input: string. Would that (and undoing the change to execObservable) be preferable? (This would allow the isort provide to keep using exec, which is simpler, while providing a generally useful enhancement)

(meta) @karrtikr thanks for your help so far, I'll pick up any other changes tomorrow evening (I'm in GMT).

@PeterJCLaw we need to discus this with the team. Based on the decision we will let you know if we want to take this or go with @DonJayamanne 's suggestions.

Ok, I've updated this PR to move the process handling out into the provider. Unfortunately due to https://github.com/zeromq/zeromq.js/issues/386 I'm not actually able to test that this works as desired, though I have updated the tests.
My main uncertainty here is whether the provider layer (i.e: the code in provideDocumentSortImportsEdits) should be doing more explicit error handling and tidy-up of the process which is returned by execObservable. I think from a read of execObservable that it doesn't need to, though I don't feel I understand the JavaScript/TypeScript patterns around this well enough to say for sure.
@karthiknadig would you be able to have a quick look at the code and let me know if there's more error handling/process cleanup which the code needs to do? (If there is, then pointers or examples towards doing that would also be much appreciated!)

Unfortunately due to zeromq/zeromq.js#386 I'm not actually able to test that this works as desired, though I have updated the tests.

Downgrading zeromq to 6.0.0-beta.5 seems to let me work around that (and doesn't appear to cause any issues in the extension), so I've now checked that this works (and fixed some issues I'd missed).
@karthiknadig I think this is ready for review again now (please also see my comment above about whether this code needs to do more to tidyup the launched process).

@karthiknadig do you know if you're likely to have time to look at this soon?
I realise there's a test failure here, though it's limited to a single platform and I'm not sure either what could be causing it nor how to go about fixing it -- advice on either would be welcome.

@PeterJCLaw I will take a look at this sometime this week.

@karthiknadig I updated this for master recently, but it looks like it's still failing in the same way (that I don't really understand).
Any chance you'll be able to look at this soon?

@PeterJCLaw We are fixing some flaky tests. We will get to this will. I will take care of addressing this.

@PeterJCLaw Looks like isort does not pick up .isort.cfg when using stdin on windows.
C:\GIT\issues\s p\vscode-python\src\test\pythonFiles\sorting\withconfig>type "C:\GIT\issues\s p\vscode-python\src\test\pythonFiles\sorting\withconfig\original.py" | "C:\GIT\issues\s p\vscode-python\pythonFiles\lib\python\bin\isort" - --diff

If I pass the full path it seems to work as expected.
C:\GIT\issues\s p\vscode-python\src\test\pythonFiles\sorting\withconfig>"C:\GIT\issues\s p\vscode-python\pythonFiles\lib\python\bin\isort" original.py --diff
--- C:\GIT\issues\s p\vscode-python\src\test\pythonFiles\sorting\withconfig\original.py:before  2019-07-25 18:23:40.425993
+++ C:\GIT\issues\s p\vscode-python\src\test\pythonFiles\sorting\withconfig\original.py:after   2020-05-04 22:34:59.942799
@@ -1,3 +1,9 @@
-from third_party import (lib1, lib2, lib3,
-                         lib4, lib5, lib6,
-                         lib7, lib8, lib9)+from third_party import lib1
+from third_party import lib2
+from third_party import lib3
+from third_party import lib4
+from third_party import lib5
+from third_party import lib6
+from third_party import lib7
+from third_party import lib8
+from third_party import lib9

This is causing the test to fail. This should probably be filed as a bug on isort. This is a blocker to accept this change.

Thanks for getting back to me.

@PeterJCLaw Looks like isort does not pick up .isort.cfg when using stdin.
https://github.com/timothycrosley/isort/blob/5de8d50075f1dbe33a7e74172a6b6c27795a0c8d/isort/main.py#L596

Hrm, that's rather odd. What version of isort were you testing with? (And what version is the CI picking up?)
I can reproduce that issue (on Linux too) when using the latest development version of isort from GitHub, however using latest published version on PyPI (a fresh pip install isort on Python 3.6 on windows 10 gets version 4.3.21) I'm unable to reproduce this.
The logs do seem to indicate that CI is picking up 4.3.21 though, so I'm not sure that this is the issue.

This should probably be filed as a bug on isort.

There are actually a couple of issues with the latest isort development branch which look like they'll affect us -- I've raised them as https://github.com/timothycrosley/isort/issues/1188 and https://github.com/timothycrosley/isort/issues/1189.

Note that isort appears to now be developing a 5.x branch, rather than the current 4.3.x branch. That has dropped support for running on Python versions before 3.6 (though claims to still be able to parse & fix older versions) so I'm guessing there could be some more complications in the near future with that branch,

On windows 10 in am using  4.3.21. CI is using the same version, since it uses requirements.txt that is pinned to that version.

Ah, I figured out why I couldn't reproduce this. I'm not sure what this means yet though.
For me, this works:
>isort - --diff < demo.py
--- :before     2020-05-06 00:09:28.178022
+++ :after      2020-05-06 00:09:28.178022
@@ -1 +1,3 @@
-import os, sys, collections
+import os
+import sys
+import collections

>

But this doesn't:
>type demo.py | isort - --diff

>

I get a different diff if I change the config, so I think the config is a red herring here. I think the issue is going to be something around how pipes are handled.
I can also reproduce this on both Python 3.6.8 and 3.8.2 (on Windows 10). When I'm back at my other machine I'll try the pipe spelling on Linux, I wonder if it breaks there too? (I've only ever tried the < spelling there)

The test is failing on CI because it is not picking up .isort.cfg. The diff comes back empty, when it should be applying force_single_line=True. I see that the cwd  when spawning the process is set to the directory where the file is present. I don't see anything wrong there. I wonder why isort does not see the the config file.

@PeterJCLaw If we are always using diff and we are going to send file content over stdin in all cases, then may be we should update sortImports.py to use isort.SortImports instead of going through main. That API seems to do the right thing.

Ok, after some more digging, I don't think this relates to the configuration file at all. If I debug through isort in the failing case, it finds the configuration file just fine, but fails to read in the content of the python file after determining the encoding to use.
I think there are a couple of issues here:

isort tries to seek within the incoming file, yet seeking within stdin isn't always possible in general and in Python doesn't seem to be as buffered might be assumed
I think there might be a Python bug where if you read of the end of a buffered stream and then try to .seek(0) you don't get back to the start, so even adding our own buffering wrapping (via io.BufferedReader(...)) doesn't solve this for short files, such as the one in this test

Notably, adding a few comment lines to the test file makes isort work for me.
I've reproduced these outside isort while being specific to Windows and small files being sent to Python via stdin. I think there might be a Python bug here, which I've reported as https://bugs.python.org/issue40540.
Switching to using isort.SortImports directly can mitigate this as long as we pass io.BufferedReader(sys.stdin.buffer) as the file, though my testing shows that even that may not be sufficient for small files.
This might also have other impacts as the reader would then be an IO[str] rather than an IO[bytes], which we would need to be sure didn't have any adverse effects.

For isort.SortImports we can pass the file contents directly using file_contents or dump the entire stdin into a stringIO and pass that as the file.
isort.SortImports(file_contents=text, show_diff=True)

For isort.SortImports we can pass the file contents directly using file_contents or dump the entire stdin into a stringIO and pass that as the file.
isort.SortImports(file_contents=text, show_diff=True)

Yup, that sounds reasonable. I'll look at making that change this evening or tomorrow.

For isort.SortImports we can pass the file contents directly using file_contents or dump the entire stdin into a stringIO and pass that as the file.
isort.SortImports(file_contents=text, show_diff=True)

Yup, that sounds reasonable. I'll look at making that change this evening or tomorrow.

It's occurred to me that this would actually mean we'd either lose support for isort command line arguments or need to parse them (albeit using the isort functions) ourselves.
I'm currently exploring replacing sys.stdin with an io.BytesIO, which I think will also work but avoid that issue.


Update Deprecated Function

stringByAddingPercentEscapesUsingEncoding(NSUTF8StringEncoding)

The above is deprecated as of Xcode 7/Swift 2.0
This is Apple's recommended replacement:
stringByAddingPercentEncodingWithAllowedCharacters(NSCharacterSet.alphanumericCharacterSet())

That being said, using NSCharacterSet.alphanumericCharacterSet() could lead to some issues, so perhaps someone could review what the desired character set should be.


Error opening jupyter notebook

Issue Type: Bug
Trying to open any jupyter notebook I get this message:
"Cannot open resource with notebook editor type 'jupyter-notebook', please check if you have the right extension installed or enabled.
Reopen file with VS Code standard text editor". (when I click it runs ok).
I have check than I have the Microsoft Python extension (I have uninstalled and reinstall it) but the message is going on. S.O.S
VS Code version: Code 1.49.2 (e5e9e69aed6e1984f7499b7af85b3d05f9a6883a, 2020-09-24T16:29:41.983Z)
OS version: Windows_NT x64 10.0.18362

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-10510U CPU @ 1.80GHz (8 x 2304)

GPU Status
2d_canvas: enabledflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onoop_rasterization: disabled_offopengl: enabled_onprotected_video_decode: enabledrasterization: enabledskia_renderer: disabled_off_okvideo_decode: enabledvulkan: disabled_offwebgl: enabledwebgl2: enabled

Load (avg)
undefined

Memory (System)
7.72GB (2.56GB free)

Process Argv
C:\Users\crist\Documents\BOOTCAMP\GitPersonal\DataScience\week12\day1\exercises\regression_tensorflow.ipynb --crash-reporter-id 1d400811-efb2-4af4-9cf7-a2c56c2aa61c

Screen Reader
no

VM
0%

Extensions (3)

Extension
Author (truncated)
Version

python
ms-
2020.9.111407

geo-data-viewer
Ran
2.3.0

vscode-data-preview
Ran
2.2.0

Seconding this error

@DonJayamanne we renamed onNotebookEditor activation event to onNotebook as mentioned in https://github.com/microsoft/vscode/issues/93265#issuecomment-682034107, please update it otherwise users can't open the notebook with Python extension if it's not activated.

/extPython

I still get the error when opening Jupyter Notebook.


Encoding error but table registered

From https://github.com/CartoDB/cartodb/issues/2778 (dataset in common data gets imported empty) I saw first an error with wkb_geometry and replicated the table.
After that, the table is still being imported empty but the log says:
2015-03-16 14:10:36 UTC: Error creating the_geom: empty column wkb_geometry.
and after the error:
2015-03-16 14:10:37 UTC: Table 'twitter_t3chfest_t3chfest_techfest_t3c' registered
2015-03-16 14:10:37 UTC: After importer run
2015-03-16 14:10:37 UTC: After dispatch
2015-03-16 14:10:37 UTC: Import finished

Sample import id: 2ce56b8e-73cc-4337-9cbf-117cfccd5437
I'm fixing the common-data table to avoid the encoding error so that it works again, but I won't delete the previous tables in case they're needed to debug this.
Low priority for the moment. I'll try to fix the table directly from the source and I haven't experienced any other similar case.
@juanignaciosl @rafatower @Kartones

There has been no activity on this issue for more several months. We are closing it. If you think this still needs to be addressed please open a new issue.


🌱 improve hack/verify-release.sh draft release note handling

Github API does not allow fetching draft release notes by tag, only by release id. Add the required code to fetch that, and also do not bail out if it fails, just skip the tests that require the data.
Also fix osv-scanner exiting the script before printing the vulnerabilities. It returns failure when vulns are found.
/hold
until https://github.com/metal3-io/ip-address-manager/pull/381 merges
/cherry-pick release-1.5
/cherry-pick release-1.4

/override test-centos-e2e-integration-main
/override test-ubuntu-integration-main
Save the trees, they do not test this.

/assign @kashifest

/cherry-pick release-1.5

/cherry-pick release-1.4

/unhold
/assign @kashifest

/approve


openTelemetry - prometheus metrics not visible in Splunk Enterprise

Please provide more information: steps to reproduce, versions of Splunk and the collector, actual vs expected results.

@atoulme thanks !
These are config I am using -
Docker-compose.yml
version: "3"
services:
Sample Go application producing counter metrics.
prometheus:
image:  prom/prometheus:v2.29.2
ports:
- 9090:9090
volumes:
   - ./config:/etc

hostname: prometheus
container_name: prometheus

OpenTelemetry Collector
otelcollector:
image: quay.io/signalfx/splunk-otel-collector:0.29.0
container_name: otelcollector
command: [ "--config=/etc/otel-collector-config.yml","--log-level=INFO" ]
volumes:
  - ./config:/etc
depends_on:
  - prometheus

Prometheus.yml
scrape_configs:

job_name: Confluent Cloud
scrape_interval: 60s
honor_labels: true
honor_timestamps: true
static_configs:

targets:

api.telemetry.confluent.cloud

scheme: https
basic_auth:
username: username
password: password
metrics_path: /v2/metrics/cloud/export
params:
resource.kafka.id:
- kafka_id
resource.schema_registry.id:
- schema_id
tls_config:
insecure_skip_verify: true

Otel-collector-config.yml
receivers:
prometheus_simple:
collection_interval: 60s
endpoint: prometheus:9090
   metrics_path: /federate

   params:
    match[]:
      - '{job="ccloud_metrics"}'
      - '{__name__=~"job:.*"}'

otlp:
    protocols:
        grpc:
          endpoint: <IP_ADDRESS>:4317
        http:
          endpoint: <IP_ADDRESS>:4318

exporters:
splunk_hec/metrics:
# Splunk HTTP Event Collector token.
token: "*******************************"
    # URL to a Splunk instance to send data to.

    #endpoint: "https://*********splunkcloud.com/services/collector"

    # Optional Splunk source: https://docs.splunk.com/Splexicon:Source
    source: "app:metrics"
    #Optional Splunk source type: https://docs.splunk.com/Splexicon:Sourcetype
    sourcetype: "Kafka"
    # Splunk index, optional name of the Splunk index targeted.
    index: "main"

    # Maximum HTTP connections to use simultaneously when sending data. Defaults to 100.
    max_connections: 20

    # Whether to disable gzip compression over HTTP. Defaults to false.
    disable_compression: false
    # HTTP timeout when sending data. Defaults to 10s.
    timeout: 10s
    # Whether to skip checking the certificate of the HEC endpoint when sending data over HTTPS. Defaults to false.
    # For this demo, we use a self-signed certificate on the Splunk docker instance, so this flag is set to true.
    insecure_skip_verify: true

processors:
batch:
extensions:
health_check:
endpoint: <IP_ADDRESS>:13133
pprof:
endpoint: :1888
zpages:
endpoint: :55679
service:
extensions: [pprof, zpages, health_check]
pipelines:
metrics:
receivers: [prometheus_simple]
processors: [batch]
exporters: [splunk_hec/metrics]

I can see metrics visible in prometheus-

but not in splunk-

Metrics are not events. You are sending metrics to an event index. You should use a metrics index instead. Further, you should use the metrics workspace to navigate metrics in Splunk Enterprise. Please read more here: https://docs.splunk.com/Documentation/SMW/1.1.9/Use/Navigate
Closing as this is not a bug with the collector, please reopen if more work is needed.

@atoulme I changed index,but only getting default metrics in splunk

It seems like you have connectivity issues to your endpoint. Please debug that the endpoint is available and accessible from your collector.


correct Device Name to System Name

conflicted with Device Name further down in the list

this can be closed now


Rename netcdftime to cftime

Per https://github.com/Unidata/cftime/issues/36, we are renaming an existing repository. netcdftime is being renamed cftime.
My understanding is that the best way to request an admin's help for renaming a package is via this issue tracker. If that is not the case, feel free to close and direct me to a more appropriate venue.

@jhamman Renaming an existing package isn't really advisable. Consider that anyone installing cftime==1.0.0a2 would still need to import netcdftime, this would probably be confusing for your users. Also, anything currently depending on the netcdftime project would suddenly have their dependencies broken.
Considering that netcdftime is relatively new and only has two alpha releases, perhaps it would be better to just register the cftime project and publish future releases there, and either deprecate or deleting the netcdftime project?

We don't really have existing users as such. I am fine creating a new package though so I have done that. Thanks for the input.


Add Dart SDK

Tool information

Tool name: Dart SDK
Add or update? Add
Desired version: Latest stable (currently 2.6)
Approximate size: ~160MB
If this is an add request:

Brief description of tool: Dart is a modern programming language from Google
URL for tool's homepage: https://dart.dev

Virtual environments affected

[x] macOS 10.15
[x] Ubuntu 16.04 LTS
[x] Ubuntu 18.04 LTS
[x] Windows Server 2016 R2
[x] Windows Server 2019

Can this tool be installed during the build?
Yes, using Google's own docker container: ~36s
Using DanTup/gh-actions/setup-dart: ~11s
Are you willing to submit a PR?
Yes

@cachapa thanks for the suggestion but considering that this can be done with existing setup-dart Actions and keeping multiple versions of Dart is a maintenance concern, we're not going to install it on the environment by default.


Fix/ios safari 9 sidebar toggle fix

Hey!
I've found that on iOS 9 on Safari browser toggle function is not fully supported. It can correctly remove class but addition doesn't work. Proposing change to provide wider support for this core component.

hi @Tubek thanks for this PR
afaik the second parameter for the toggle method is supported starting from iOS 7 and up
see: https://caniuse.com/#feat=classlist
nevertheless, we will try to verify the issue

Hi @xidedix,
Yes I know, but unfortunately it doesn't work as expected. Please try running it on iOS 9.x, sidebar on safari just doesn't work which is quite important feature for coreui.
Thanks,

hi @Tubek
please update to<EMAIL_ADDRESS>and let us know if this helps

Can confirm that all working as expected on ver<EMAIL_ADDRESS>Thanks!


Implement deploy tests

https://github.com/UnitedIncome/serverless-python-requirements/pull/180#issuecomment-384750832

Hey 👋 I'm closing this ticket as it looks like it's heavily outdated, we can of course reopen it if needed 👍


typo: succesfully -> successfully

@nschonni : Thanks for your contribution! The author, @MikeRayMSFT, has been notified to review your proposed change.

@Jak-MS : Thanks for your contribution! The author, @MikeRayMSFT, has been notified to review your proposed change.


Update bip39 implementation to @metamask/scure-bip39

We are updating all instances of bip39 across our packages to use the @metamask/scure-bip39 (our fork of @scure/bip39) - which allows us to pass around SRP's as Uint8Arrays rather than plain strings for security purposes.
Currently this change may also be blocking: https://github.com/MetaMask/metamask-extension/pull/17056

Could you elaborate on why this might be blocking that extension PR? I'm having trouble finding a connection.

Not going to merge this yet @Gudahtt, @FrederikBolding has indicated that there may be some other adaptations required to make sure this is not breaking. I'm meeting with @Mrtenz tomorrow to discuss.

Could you elaborate on why this might be blocking that extension PR? I'm having trouble finding a connection.

I'm not sure if this is going to unblock that but it may be related. The error thrown here in the bip32 test-snap e2e test, is throw here in key-tree. This is happening because the changed bip39 implementation being pulled in in the latest eth-keyring-controller changes are causing the seedphrase to be passed as a Uint8Array rather than a plain text string as is expected in validatePathSegment.


Banned or not banned? thats the question

Describe the bug
Hours ago I was banned from the chat of "Coders/Devs" room after some admin gave moderator to a bunch of people. After that I tried many times to get unblocked but it seems that for every other mod/admin I'm not banned from chat. Even when I try to chat it doesn't send anything (doesn't show me any pop up saying I'm banned from chat tho). I'm currently a Mod and still banned, doesn't make sense.

Screenshots
Idk if this helps, this is a screenshot of my browser.

What device are you on?
Linux Mint 20.1, Firefox.
Additional context
I'm sad, the audio doesn't work and I can't use the chat :(

lol, yeah Will banned me for calling Rust a "Haskell ass language" and I had the same issue -- unbanned, but couldn't use the chat.  I could still join a speaker and use voice chat though.  Kinda funny, but yeah this could actually use fixing.  I'll take a look, but I can't read elixir, so fingers crossed the ban controller is in Kofta.

duplicate #528