Fix regression from Skeleton3D Inspector redesign

It can be reproduced by reimporting many FBX files with a skeleton.
A change in commit f7fdc87 [Merged on May 27] mistakenly changed the Skeleton3D "pose" property from PROPERTY_USAGE_EDITOR to PROPERTY_USAGE_NOEDITOR.
Oddly, I cannot find a bug report documenting the breakage. Up to now, I had assumed that FBX support in Godot was incomplete, but upon finding out that the files were working in 3.2, I decided to bisect, landed upon this commit, and then bisected the individual lines until I stumbled upon this line causing the problem.
@fire The bugs about FBX support that I would expect to be relevant are filed against 3.2; and a patchset with FBX improvements (issue 39418) is also targeting the 3.2 branch, so I really have no data if anyone aside from me has encountered this problem on the master branch.
The relevant part of the original change is this:
diff --git a/scene/3d/skeleton_3d.cpp b/scene/3d/skeleton_3d.cpp
index 7516cf95b0..a09424fa17 100644
--- a/scene/3d/skeleton_3d.cpp
+++ b/scene/3d/skeleton_3d.cpp
@@ -158,12 +158,12 @@ bool Skeleton3D::_get(const StringName &p_path, Variant &r_ret) const {
 void Skeleton3D::_get_property_list(List<PropertyInfo> *p_list) const {
        for (int i = 0; i < bones.size(); i++) {
                String prep = "bones/" + itos(i) + "/";
-               p_list->push_back(PropertyInfo(Variant::STRING, prep + "name"));
-               p_list->push_back(PropertyInfo(Variant::INT, prep + "parent", PROPERTY_HINT_RANGE, "-1," + itos(bones.size() - 1) + ",1"));
-               p_list->push_back(PropertyInfo(Variant::TRANSFORM, prep + "rest"));
-               p_list->push_back(PropertyInfo(Variant::BOOL, prep + "enabled"));
-               p_list->push_back(PropertyInfo(Variant::TRANSFORM, prep + "pose", PROPERTY_HINT_NONE, "", PROPERTY_USAGE_EDITOR));
-               p_list->push_back(PropertyInfo(Variant::ARRAY, prep + "bound_children"));
+               p_list->push_back(PropertyInfo(Variant::STRING, prep + "name", PROPERTY_HINT_NONE, "", PROPERTY_USAGE_NOEDITOR));
+               p_list->push_back(PropertyInfo(Variant::INT, prep + "parent", PROPERTY_HINT_RANGE, "-1," + itos(bones.size() - 1) + ",1", PROPERTY_USAGE_NOEDITOR));
+               p_list->push_back(PropertyInfo(Variant::TRANSFORM, prep + "rest", PROPERTY_HINT_NONE, "", PROPERTY_USAGE_NOEDITOR));
+               p_list->push_back(PropertyInfo(Variant::BOOL, prep + "enabled", PROPERTY_HINT_NONE, "", PROPERTY_USAGE_NOEDITOR));
+               p_list->push_back(PropertyInfo(Variant::TRANSFORM, prep + "pose", PROPERTY_HINT_NONE, "", PROPERTY_USAGE_NOEDITOR));
+               p_list->push_back(PropertyInfo(Variant::ARRAY, prep + "bound_children", PROPERTY_HINT_NONE, "", PROPERTY_USAGE_NOEDITOR));
        }
 }

Here I was able to ascertain the intent of the change was to change the unspecified p_usage (PROPERTY_USAGE_DEFAULT) to be PROPERTY_USAGE_NOEDITOR. However, the pose property was actually not default but was set to PROPERTY_USAGE_EDITOR, yet it was still changed to PROPERTY_USAGE_NOEDITOR.
Another thing I have not explained is why the issue only appears on clicking Reimport, and why it only affects FBX models and not glTF, despite the change being in core engine code.
Here are screenshots of the mesh I was testing with, though the model I happened to use is not redistributable, so here are screenshots:
Current master branch:

After this patch (looks the same as 3.2):

CC @TwistedTwigleg

@lyuma I know it's hard but can you upload a minimal bug reproducing project? I didn't want to spend time finding models from sketchfab.

I can reproduce the issue with the following model from Sketchfab: https://sketchfab.com/3d-models/soldier-final-animations-fbx-ad2450c22d664317b36ccfd2e81016ea

The other thing is this already solved in Revolu's FBX branch? Actually, it doesn't matter since if it conflicts, we'll have a git merge error.
I'm in the middle of something.

I've done some debugging and found something: Commenting out the addition of pose in the property list fixes the issue and doesn't seem to have any adverse effects that I've noticed in my limited testing. I need to do more testing to be sure, but it looks like we could just remove/comment-out the property list for pose (and maybe the others?) and the issue should be fixed, assuming the poses are not needed to be in the property list for another node/use.

The skeleton pose property is how the animations are played in Godot Engine. Removing that means no animations play..

Yeah, so no good then. I tried some more tests, and I cannot quite find out why the pose property being exposed to the editor causes the issue for FBX, but not GLTF. I'm wondering if the issue is that the getter/setter being called for the pose property fixes something or vise versa, but I haven't been able to deduce if that is the case.

Please can we merge #39418 before we merge fixes like this, it's uncertain if this is still a problem, or if we will have the inverse effect when we merge the new importer.

I saw the comments about finding the root cause, and asking why the FBX importer depends on the pose. I found both places in editor_scene_importer_assimp.cpp: one is setting bone_rest and bone_pose to the same value, which I think does not make sense; and the other is multiplying inverse(bone_pose) against a transform when calculating animation tracks. I have made a change which addresses this root cause by avoiding set and get on the bone_pose.
Therefore, I am closing this PR and I will direct interested parties to #41497
@RevoluPowered about your concerns, I believe this issue is still relevant with your rewrite when applied to the master branch. I will address your comments and test that branch in more detail in the replacement PR #41497


Fix lost commits (2)

All of @zpao's changes (#89) + c082692.
Still has the two test failures mentioned in the other pull request:
/*
*/]: Expected
    {"index":6,"lineNumber":2,"column":4,"message":"Error: Line 2: Unexpected token ]","description":"Unexpected token ]"}
to match
    {"index":6,"lineNumber":3,"column":3,"message":"Error: Line 3: Unexpected token ]","description":"Unexpected token ]"}
Diff:
 {
-  lineNumber: 2
+  lineNumber: 3
-  column: 4
+  column: 3
-  message: "Error: Line 2: Unexpected token ]"
+  message: "Error: Line 3: Unexpected token ]"
 }

 *
*/]: Expected
    {"index":7,"lineNumber":2,"column":3,"message":"Error: Line 2: Unexpected token ]","description":"Unexpected token ]"}
to match
    {"index":7,"lineNumber":3,"column":3,"message":"Error: Line 3: Unexpected token ]","description":"Unexpected token ]"}
Diff:
 {
-  lineNumber: 2
+  lineNumber: 3
-  message: "Error: Line 2: Unexpected token ]"
+  message: "Error: Line 3: Unexpected token ]"
 }

Superceded again by the original PR :) Those tests just needed to be updated to the actual state they report - the expected result is correct.

:+1:


Bug: Provider configuration in module throws terraform error

Summary
When using a count, for_each, or depends_on statement with the module, terraform will throw an error message to the user and prevent using the module. In general with modules the configuration of a provider is generally avoided unless specific use case needs are required in order for the module to function properly. The following Hashicorp documentation discusses the topic and the implications and limitations imposed by configuring a provider inside a module.
https://developer.hashicorp.com/terraform/language/modules/develop/providers#providers-within-modules
Reproduction
Use a count, for_each, or depends_on with the module
Error Message
Initializing modules...
╷
│ Error: Module is incompatible with count, for_each, and depends_on
│
│   on ***.tf line 3, in module "vwan":
│    3:   count = var.****== "***" ? 1 : 0
│
│ The module at module.vwan.module.avm-ptn-virtualwan is a legacy module which contains its own local provider configurations, and so calls to it may not use the count, for_each, or depends_on arguments.
│
│ If you also control the module "registry.terraform.io/Azure/avm-ptn-virtualwan/azurerm", consider updating this module to instead expect provider configurations to be passed by its caller.

Remediation
Remove the following lines from the terraform.tf file
provider "azurerm" {
  features {
    resource_group {
      prevent_deletion_if_contains_resources = false
    }
  }
}

WIP

@OmnipotentOwl Code changes have been pushed. Thanks for the feedback.


docs: update logging config

Fixes #N/A
Description
Removes reference to config map for logging config.
How was this change tested?
Docs change.
Does this change impact docs?

[ ] Yes, PR includes docs updates
[ ] Yes, issue opened: #
[x] No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>3
Warning: This coverage report may be inaccurate.
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 82.76%

Totals

Change from base Build<PHONE_NUMBER>2:
0.0%

Covered Lines:
5583

Relevant Lines:
6746

💛  - Coveralls

May want to include the kubectl example like below?
kubectl -n karpenter set env deploy/karpenter LOG_LEVEL=debug
kubectl -n karpenter rollout restart deploy/karpenter


A small fix to Readme

The wp-cli part isn't nessesary.

It is if you're not using the -p version

I checked it -p instals as package but the plugin edition installs as 'mu-plugin' so it's always activated - https://screenshots.firefox.com/YmeLLaT5BYHybNVx/localhost
I've also fixed composer require versions

I've merged this.
It appears, according to Packagist, that models is used equally as a bedrock dep, and sage dep. I would be open to a better versioning scheme if users feel one exists.

@darrenjacoby maybe it would be better to seperate them to separate repos - models-plugin and models-package. This repo would stay for backward compatibility. What do you think?


Fixes #35 : Update AddProject.js with correct link of plus.svg

Fixed the link from /plus.svg to /commit-status/plus.svg

Thanks @varadpoddar for looking at this. However, this would break for when running locally. I've moved it use the relative path instead https://github.com/sitture/commit-status/commit/d6ecc55e1cd76f4bd6a8c0a078949bc6bbdb6189


packet scope packet size histogram is broken

somethings gone wrong with packet size histogram, its completely broken

add regression to verify this functionality

internal histogram is correct, but javascript side assumed the array started at 64 (instead of 0)
fixed svn:2322

resolved FW: 20160510_2353


Update doc with renamed OperatorSource example yml

In tandem with https://github.com/operator-framework/operator-marketplace/pull/112

Merge only after operator-framework/operator-marketplace#112 merges

@SamiSousa https://github.com/operator-framework/operator-marketplace/pull/112 has been merged


bump curator version to 2.8.0

Should fix the issue we are seeing in #620
@stevenschlansker @wsorenson

:+1:

Probably want to bump it here, trying to keep all of our open-source stuff on the same versions to reduce conflicts

Going to bump this in the basepom as suggested by @jhaber, next build of Singularity should then have the new version. Closing this pr

https://github.com/HubSpot/basepom/pull/1

also https://github.com/HubSpot/Singularity/pull/652


Rename to adapter

This PR renames adaptor to adapter to satisy 'muricans and match other similar OSS projects and deployment providers.

lgtm!

lgtm!


usePipeTransformInterfaceRule failure on valid pipe

The simple below pipe fails the validation, I'm unable to figure out the root cause
@Pipe({name: 'capitalize'})
export class CapitalizePipe implements PipeTransform  {

    transform(input: string): string {
        if (input !== null) {
            input = input.toLowerCase();
        }
        return input.substring(0, 1).toUpperCase() + input.substring(1);
    }
}

WARNING in ./src/main/webapp/app/shared/language/language.pipe.ts
[3, 1]: The FindLanguageFromKeyPipe class has the Pipe decorator, so it should implement the PipeTransform interface
[40, 1]: The CapitalizePipe class has the Pipe decorator, so it should implement the PipeTransform interface

 @ ./src/main/webapp/app/shared/index.ts 17:9-44
 @ ./src/main/webapp/app/app.module.ts
 @ ./src/main/webapp/app/app.main.ts

looks like there is a closed issue https://github.com/mgechev/codelyzer/issues/145 for the same.
 Would you try the same and let me know if you get an error?

I couldnt reproduce on the site but on the project it gives this warning. we are using this in JHipster. So i think it has something to do with typescript or some other dependency version

Could be related to TypeScript version mismatch. Can you verify which one are you using in your project?

I'm getting the same bug on atom-tslint and also not able to reproduce on the codelyzer website.
project
"tslint": "^4.4.2",
"codelyzer": "~2.0.0-beta.4",

atom linter-tslint v0.13.1

this silences it. I think there's an issue with tslint Pipe and the Pipe class name? Atom seems to think Pipe is a keyword like class or number.
import { Pipe as NgPipe, PipeTransform } from '@angular/core';
@NgPipe({ name: 'matchMode' })
export class MatchModePipe implements PipeTransform {
  transform(value: any) {
    if (!value) {
      return '';
    }
    return getMode(value);
  }
}

@scttcper unfortunately this doesn't work at this point. Probably it'll be fixed in future releases when we reuse the language service in our front-end.

@scttcper I meant that codelyzer doesn't know that NgPipe refers to Pipe. The lint rule should not fail.


15 | 3Sum | C++

Title - 3Sum
What will change - A C++ solution for the problem will be added
Type of Issue -
Please add/delete options that are not relevant.

[x] Adding New Code

Programming Language
Please add/delete options that are not relevant.

[x] C++

Self Check

Ask for issue assignment and wait to get assigned to it before making Pull Request.
Add your file in the proper folder
Clean Code and Documentation for better readability
Add Title and Description of the program in the file

:star2: Star it :fork_and_knife:Fork it :handshake: Contribute to it!
Discord server ✉ - https://discord.gg/CXksGdn
Happy Coding,

Please assign this issue to me.

Please assign this issue to me, I m interested to work on it


Windows: doesn't work also with ext-ssh2

Q
A

Issue Type
Bug

Deployer Version
3.3.0

Local Machine OS
Windows 10 x64 LTSB 2016

Remote Machine OS
N/A

Description
I've installed ext-ssh2 in my PHP environment but deployer still doesn't work, this is the error when I try to deploy my Laravel app (generated recipe).
Steps to reproduce
Run dep deploy -vvv, nothing else.
Content of deploy.php
<?php
/*
 * This file has been generated automatically.
 * Please change the configuration for correct use deploy.
 */

require 'recipe/laravel.php';

// Set configurations
set('repository', 'git@bitbucket.org:fede91it/thejuicesqueezer-laravel.git');
set('shared_files', ['.env']);
set('shared_dirs', [
    'storage/app',
    'storage/framework/cache',
    'storage/framework/sessions',
    'storage/framework/views',
    'storage/logs',
]);
set('writable_dirs', ['bootstrap/cache', 'storage']);
set('ssh_type', 'ext-ssh2');

server('production', '<IP_ADDRESS>', 18765)
	->env('deploy_path', '/public_html/_beta')
	->user('thejuice')
    ->forwardAgent();

Output log
λ dep deploy beta --verbose
Ô×ñ Executing task deploy:prepare
Ôå│ on [beta]
PHP Fatal error:  Uncaught Error: Class 'Ssh\Configuration' not found in C:\Users\Federico\AppData\Roaming\Composer\vendor\deployer\deployer\src\Server\Remote\SshExtension.php:47
Stack trace:
#0 C:\Users\Federico\AppData\Roaming\Composer\vendor\deployer\deployer\recipe\common.php(105): Deployer\Server\Remote\SshExtension->connect()
#1 [internal function]: {closure}()
#2 C:\Users\Federico\AppData\Roaming\Composer\vendor\deployer\deployer\src\Task\Task.php(79): call_user_func(Object(Closure))
#3 C:\Users\Federico\AppData\Roaming\Composer\vendor\deployer\deployer\src\Executor\SeriesExecutor.php(43): Deployer\Task\Task->run(Object(Deployer\Task\Context))
#4 C:\Users\Federico\AppData\Roaming\Composer\vendor\deployer\deployer\src\Console\TaskCommand.php(82): Deployer\Executor\SeriesExecutor->run(Array, Array, Array, Object(Symfony\Component\Console\Input\ArgvInput), Object(Deployer\Console\Output\OutputWatcher))
#5 C:\Users\Federico\AppData\Roaming\Composer\vendor\symfony\console\Command\Command.php(256): Deployer\Console\TaskComman in C:\Users\Federico\AppData\Roaming\Composer\vendor\deployer\deployer\src\Server\Remote\SshExtension.php on line 47

Fatal error: Uncaught Error: Class 'Ssh\Configuration' not found in C:\Users\Federico\AppData\Roaming\Composer\vendor\deployer\deployer\src\Server\Remote\SshExtension.php:47
Stack trace:
#0 C:\Users\Federico\AppData\Roaming\Composer\vendor\deployer\deployer\recipe\common.php(105): Deployer\Server\Remote\SshExtension->connect()
#1 [internal function]: {closure}()
#2 C:\Users\Federico\AppData\Roaming\Composer\vendor\deployer\deployer\src\Task\Task.php(79): call_user_func(Object(Closure))
#3 C:\Users\Federico\AppData\Roaming\Composer\vendor\deployer\deployer\src\Executor\SeriesExecutor.php(43): Deployer\Task\Task->run(Object(Deployer\Task\Context))
#4 C:\Users\Federico\AppData\Roaming\Composer\vendor\deployer\deployer\src\Console\TaskCommand.php(82): Deployer\Executor\SeriesExecutor->run(Array, Array, Array, Object(Symfony\Component\Console\Input\ArgvInput), Object(Deployer\Console\Output\OutputWatcher))
#5 C:\Users\Federico\AppData\Roaming\Composer\vendor\symfony\console\Command\Command.php(256): Deployer\Console\TaskComman in C:\Users\Federico\AppData\Roaming\Composer\vendor\deployer\deployer\src\Server\Remote\SshExtension.php on line 47

Anyone could help here?

Did you installed herzult/php-ssh?

Thank you, it worked!
I open a new issue for another thing.


Fix globals reference to allow underlying Dictionary to change

In my tiny image a lot of code is (i.e. classes are) installed dynamically. The Smalltalk globals Dictionary needs to grow to accommodate these extra classes. The interpreter kept a reference to the globals by using the (pointers to the) Array elements which are part of the SystemDictionary. When a Dictionary needs to grow it will however replace this internal Array with a bigger one. The globals kept referencing the old elements (collection). This fix replaces the globals reference with a getGlobals() getter function which dynamically references the globals (but without having to do the whole search for the actual Dictionary which is needed for the different Smalltalk variants).

Curious about how you ran into this? The globals "magic" is only supposed to happen during debugging, not during regular execution.

@codefrau my plugins need to access some standard classes like Dictionary and also some internal classes. I like to use the same access method to retrieve those classes. Therefore I use this global magic at start of the plugin. It worked up till recently, because the order of loading changed a bit. More classes were created before the plugin got loaded and therefore I hit this issue. Thx for merging it. Have a nice day!


Can't remove time filters when exploring datasource

Make sure these boxes are checked before submitting your issue - thank you!

[x] I have checked the superset logs for python stacktraces and included it here as text if any
[x] I have reproduced the issue with at least the latest released version of superset
[x] I have checked the issue tracker for the same issue and I haven't found one similar

Superset version
6b15592d (building from source)
Expected results
Have the ability to remove the time range when exploring a datasource.
Actual results
Can't remove a time filter when exploring datasource. Not sure if I'm missing something, but my only option is to set a time filter that will include all of my rows. Even after unchecking "Is temporal" on all columns for my datasource, the query is choosing and applying the TIME_STAMP column in the explorer:

Steps to reproduce

Add any datasource with a temporal column.
Explore the datasource, and note the time range is automatically applied as "Last week"
Edit datasource and uncheck all "Is temporal" columns.
Explore datasource again. Note the time range is still there, and displaying the query shows this.

Apparently I'm blind, because I am now seeing a "No filter" option in the Time range dialog. I think the steps to reproduce are still valid, though I can work around the issue now.

The way I've found to work around this is to create a data set where the first column is not a date time.

I encountered a similar issue with my version 3.0.1. When there is a time column in the dataset you selected, one of the columns that are not the desired time column will automatically be set as a filter parameter. This can affect applying Jinja time parameters to the intended time column.
Now, i used another bug solve this bug.
step 1: in database, i add anther time column, and  add this column to filter.
step 2: then back to database, and delete this time column.
step 3:   update chart and save, though the time column still show in filter, but it not work in future.


Ark shaders

@eddyb Tagged you as a reviewer for visibility.

uh was this supposed to be merged 😂


Problems installing

I'm following the instructions  to install this on my Mac (using Option 2 for use with github pages), but I get the following error:
  Liquid Exception: cannot load such file -- rouge in pages/mydoc/mydoc_help_api.md
bundler: failed to load command: jekyll (/usr/local/bin/jekyll)
LoadError: cannot load such file -- rouge
  /usr/local/lib/ruby/gems/2.3.0/gems/jekyll-2.4.0/lib/jekyll/tags/highlight.rb:102:in `require'
  /usr/local/lib/ruby/gems/2.3.0/gems/jekyll-2.4.0/lib/jekyll/tags/highlight.rb:102:in `render_rouge'
  /usr/local/lib/ruby/gems/2.3.0/gems/jekyll-2.4.0/lib/jekyll/tags/highlight.rb:53:in `render'
  /usr/local/lib/ruby/gems/2.3.0/gems/liquid-2.6.1/lib/liquid/block.rb:109:in `block in render_all'
  /usr/local/lib/ruby/gems/2.3.0/gems/liquid-2.6.1/lib/liquid/block.rb:96:in `each'
  /usr/local/lib/ruby/gems/2.3.0/gems/liquid-2.6.1/lib/liquid/block.rb:96:in `render_all'
  /usr/local/lib/ruby/gems/2.3.0/gems/liquid-2.6.1/lib/liquid/block.rb:82:in `render'
  /usr/local/lib/ruby/gems/2.3.0/gems/liquid-2.6.1/lib/liquid/template.rb:128:in `render'
  /usr/local/lib/ruby/gems/2.3.0/gems/liquid-2.6.1/lib/liquid/template.rb:138:in `render!'
  /usr/local/lib/ruby/gems/2.3.0/gems/jekyll-2.4.0/lib/jekyll/convertible.rb:106:in `render_liquid'
  /usr/local/lib/ruby/gems/2.3.0/gems/jekyll-2.4.0/lib/jekyll/convertible.rb:233:in `do_layout'
  /usr/local/lib/ruby/gems/2.3.0/gems/jekyll-2.4.0/lib/jekyll/page.rb:122:in `render'
  /usr/local/lib/ruby/gems/2.3.0/gems/jekyll-2.4.0/lib/jekyll/site.rb:269:in `block in render'
  /usr/local/lib/ruby/gems/2.3.0/gems/jekyll-2.4.0/lib/jekyll/site.rb:268:in `each'
  /usr/local/lib/ruby/gems/2.3.0/gems/jekyll-2.4.0/lib/jekyll/site.rb:268:in `render'
  /usr/local/lib/ruby/gems/2.3.0/gems/jekyll-2.4.0/lib/jekyll/site.rb:46:in `process'
  /usr/local/lib/ruby/gems/2.3.0/gems/jekyll-2.4.0/lib/jekyll/command.rb:28:in `process_site'
  /usr/local/lib/ruby/gems/2.3.0/gems/jekyll-2.4.0/lib/jekyll/commands/build.rb:55:in `build'
  /usr/local/lib/ruby/gems/2.3.0/gems/jekyll-2.4.0/lib/jekyll/commands/build.rb:33:in `process'
  /usr/local/lib/ruby/gems/2.3.0/gems/jekyll-2.4.0/lib/jekyll/commands/serve.rb:25:in `block (2 levels) in init_with_program'
  /usr/local/lib/ruby/gems/2.3.0/gems/mercenary-0.3.6/lib/mercenary/command.rb:220:in `block in execute'
  /usr/local/lib/ruby/gems/2.3.0/gems/mercenary-0.3.6/lib/mercenary/command.rb:220:in `each'
  /usr/local/lib/ruby/gems/2.3.0/gems/mercenary-0.3.6/lib/mercenary/command.rb:220:in `execute'
  /usr/local/lib/ruby/gems/2.3.0/gems/mercenary-0.3.6/lib/mercenary/program.rb:42:in `go'
  /usr/local/lib/ruby/gems/2.3.0/gems/mercenary-0.3.6/lib/mercenary.rb:19:in `program'
  /usr/local/lib/ruby/gems/2.3.0/gems/jekyll-2.4.0/bin/jekyll:18:in `<top (required)>'
  /usr/local/bin/jekyll:22:in `load'
  /usr/local/bin/jekyll:22:in `<top (required)>'

I tried "gem install rouge", "bundle update", etc. but nothing seemed to help. What should I do?

I got this issue as well

This should be fixed now. For some reason, the github-pages gem isn't allowing me to use the highlight tag. I removed the highlight tag on the problematic pages (mydoc_syntax_highlighting and mydoc_help_api), and updated the Gemfiles. This seemed to fix the issue. Can you let me know if this fixed the issue for you?

Seems to be fixed. Thanks!


Krishiv Mahendru

Objective
The purpose of this sprint is to work toward creating a working leaderboard system through the backend and integration. Currently the backend has the class code data for each  person in the stock game who joins a class, from this we will setup a way to rate people score based on the price that is sold and price that bought for by giving them a rating, then we will create a sort algorithm, and implement a leaderboard globally (all people that have played the game) and one for each class (leaderboard for everyone in the class), I will also be working closely with Emaad as a peer check up on this feature in order to keep this lined u with everything.
TO DO

[ ] create a way to give rating in users class
[ ] add accurate stats testing
[ ] create database for leaderboard
[ ] sort the data of the rating
[ ] work into creating the leaderboard
[ ] organize the leaderboard and data base structure
[ ] get data from backend and work with James in front-end

Schedule

Monday: Create Plans and Visuals, Talk with Emaad to discuss peer checks and collaborate
Tuesday: Create column in users data base to get scoring to work
Wed: Setup Global leaderboard database
Thursday: Debug database and implement sorting
Friday: Work toward creating a full leaderboard and collaborate to place finishing touches and push to deployed backend and frontend.

What we will show

We will show a working leaderboard that's implemented with the prediction models, and class codes, and stats.

Here is A link of all things completed from the plan such as the leaderboard using sort and an iterator within the backend me and Emaad worked together on both ends with communication with other team members to stay aligned on features.


React Native Android builds fail with new Android convenience images

I have been previously using circleci/android:api-30-node image for my React Native Android builds. But I've been getting a warning on CircleCi that I'm using deprecated docker images. So, I decided to upgrade to the new Android cimg convenience images, but my builds now keep failing. I tried cimg/android:2022.03.1, cimg/android:2022.03.1-node, and even cimg/android:2022.03.1-ndk.
Here's the error I'm getting when trying to download Android dependencies on cimg/android:2022.03.1 and cimg/android:2022.03.1-ndk:
#!/bin/bash -eo pipefail
./gradlew androidDependencies
Starting a Gradle Daemon, 1 incompatible Daemon could not be reused, use --status for details
:ReactNative:Running '[node, -e, console.log(require('react-native/cli').bin);]' command failed.

FAILURE: Build failed with an exception.

* Where:
Script<EMAIL_ADDRESS>line: 197

* What went wrong:
A problem occurred evaluating script.
> Cannot run program "node" (in directory "/home/circleci/project/android"): error=2, No such file or directory

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.

* Get more help at https://help.gradle.org

BUILD FAILED in 3s

Exited with code exit status 1
CircleCI received exit code 1

And the builds won't event start when using cimg/android:2022.03.1-node, which I think is the one that I actually should be using, as I was using the node-prefixed image before. This is the error that I'm getting during checkout code step (on the 5th second of the build running):
#!/bin/sh
set -e
# Workaround old docker images with incorrect $HOME
# check https://github.com/docker/docker/issues/2968 for details
if [ "${HOME}" = "/" ]
then
  export HOME=$(getent passwd $(id -un) | cut -d: -f6)
fi

echo "Using SSH Config Dir '$SSH_CONFIG_DIR'"
git --version

mkdir -p "$SSH_CONFIG_DIR"
chmod 0700 "$SSH_CONFIG_DIR"

printf "%s" 'github.com ssh-rsa <ssh-rsa removed here>
' >> "$SSH_CONFIG_DIR/known_hosts"
chmod 0600 "$SSH_CONFIG_DIR/known_hosts"

rm -f "$SSH_CONFIG_DIR/id_rsa"
printf "%s" "$CHECKOUT_KEY" > "$SSH_CONFIG_DIR/id_rsa"
chmod 0600 "$SSH_CONFIG_DIR/id_rsa"
if (: "${CHECKOUT_KEY_PUBLIC?}") 2>/dev/null; then
  rm -f "$SSH_CONFIG_DIR/id_rsa.pub"
  printf "%s" "$CHECKOUT_KEY_PUBLIC" > "$SSH_CONFIG_DIR/id_rsa.pub"
fi

export GIT_SSH_COMMAND='ssh -i "$SSH_CONFIG_DIR/id_rsa" -o UserKnownHostsFile="$SSH_CONFIG_DIR/known_hosts"'

# use git+ssh instead of https
git config --global<EMAIL_ADDRESS>"https://github.com" || true
git config --global gc.auto 0 || true

if [ -e '/home/circleci/project/.git' ] ; then
  echo 'Fetching into existing repository'
  existing_repo='true'
  cd '/home/circleci/project'
  git remote set-url origin "$CIRCLE_REPOSITORY_URL" || true
else
  echo 'Cloning git repository'
  existing_repo='false'
  mkdir -p '/home/circleci/project'
  cd '/home/circleci/project'
  git clone --no-checkout "$CIRCLE_REPOSITORY_URL" .
fi

if [ "$existing_repo" = 'true' ] || [ 'false' = 'true' ]; then
  echo 'Fetching from remote repository'
  if [ -n "$CIRCLE_TAG" ]; then
    git fetch --force --tags origin
  else
    git fetch --force origin +refs/heads/main:refs/remotes/origin/main
  fi
fi

if [ -n "$CIRCLE_TAG" ]; then
  echo 'Checking out tag'
  git checkout --force "$CIRCLE_TAG"
  git reset --hard "$CIRCLE_SHA1"
else
  echo 'Checking out branch'
  git checkout --force -B "$CIRCLE_BRANCH" "$CIRCLE_SHA1"
  git --no-pager log --no-color -n 1 --format='HEAD is now at %h %s'
fi

Using SSH Config Dir '/home/circleci/.ssh'
git version 2.34.1
Cloning git repository
Cloning into '.'...
kex_exchange_identification: Connection closed by remote host
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.

exit status 128
CircleCI received exit code 128

All builds that are run using the deprecated circleci/android:api-30-node go through without any issues.
I need help with this, as I am afraid the deprecated images will be discontinued, and I wont' be able to run my builds. Thank you!

hi @PunainenAurinko, could you please provide a link to the builds you are referencing here?

@JalexChen Here:

https://app.circleci.com/pipelines/github/pslightningbolt/lightningbolt-mobile/2426/workflows/4759ecaf-86d2-45ed-9724-00b0f01f33a7/jobs/4630
https://app.circleci.com/pipelines/github/pslightningbolt/lightningbolt-mobile/2427/workflows/1b3b2f01-1f00-41bc-b817-7f1b4e69599d/jobs/4634
https://app.circleci.com/pipelines/github/pslightningbolt/lightningbolt-mobile/2428/workflows/0735e5d4-e328-4582-aacd-163dc18069ab/jobs/4637

Thank you!

@JalexChen Are there any news on this? I'm not sure if the links are helpful. These are private repos and private workflows.

hi @PunainenAurinko - you are correct that the basic 2022.03.1 tag should not be what is used if you have node running. you should use the image with the -node suffix; if you would like to use the -ndk variant, using the node orb to install it onto the container might also be an option for you.
Unfortunately, I'm not entirely sure why the build is failing to execute when using the -node variant. As it stands, it looks like it might be a connection issue on your end, which is odd considering the other images are passing that step. Have you since tried running this again and has it at least gotten past that step so we have a bit more to work with?

@JalexChen Hey there, I just tried the new April image and it worked for me right away. I am now using cimg/android:2022.04-node for my React Native Android builds and it works perfectly. I didn't need to modify the config at all to use it, I just swapped it with the legacy image and the build went through. I don't know what was wrong with the March Android -node image, but the April one works without issues. Thanks for looking into this though, and you can close this issue now. Thank you!


Add option to control the computer account creation of domainjoin

PBIS creates a disabled computer account when domain join and move the computer
account and enable it when domain join successed. However it violate some
restrictions of some domain, so it will fail a domain join progress.
This patch add an option --no-pre-account to switch off the creation of the
disabled computer account when domain join.
Signed-off-by: Yang Qian<EMAIL_ADDRESS>

This is a fix for #51 and #248

This change has been accepted by the team. It has not been tested by our internal team and a build will not be provided that contains this change. pbis-open will no longer receive updates and will be archived


The Twig Filter "spaceless" is deprecated Since twig/twig 3.12

We should find a way to remove it.
IMHO the removal itself is not so urgent (twig 4 is not out yet, nor has a release date for now)
Fixing the deprecation in the tests is urgent though

Sorry, It was already opened in #395


Fix name of con terra

Just fix the the name of con terra, since it is not linked to Esri Germany anymore. Thanks for fixing.

Thank you!


Standardize on processor

Deploy preview ready!
Built with commit 4be02f5e5ee5e9550bed3c780d3a97d05b3f5b9b
https://deploy-preview-9--markdown-guide.netlify.com


Build System(s) are a Mess

Looking at ditching the Boost dependency, and the code part is easy, but changing the various build systems we have is a real PITA.
Theoretically, we just use the bake file, but that it out of date, both in format (current Bakefile uses a different file format, legacy doesn't support recent IDEs) and content (the flamerobin.bkl file is missing some recent source files)
So, rather than trying to repair that, does anyone want to look at my CMakeLists.txt file?
I've tested it on Windows (VS2019) and Linux (Slackware 14.2). It calls the update-revision-info script, builds, and sets up the *-templates directories ready for debugging. All that's missing is the install commands (for Linux, i.e. make install)
Special feature, for Windows devs, is you can directly specify the wxWidgets root (WXDIR) which makes it easier to try different wx versions on the same machine (it should check the WXDIR environment var too, but untested)
Quick guide for Win/Visual Studio use:

Grab CMake from https://cmake.org/download/ (I recommend adding it to PATH)
Place the CMakeLists.txt in the root of the FlameRobin  (where all the other project file currently exist)
Create a sub-dir 'build' (can be any name, like 'build-wx302-64bit', but 'build' for now)
Run the CMake GUI
Point 'Where is the source code' to the FlameRobin root
Point 'Where to build the binaries' to the 'build' sub-dir
Click 'Add Entry' (button to the right of window)

Give it the name WXDIR
Set Type to PATH
Select the root of your wxWidgets library

Now click 'Generate'
Select your Visual Studio version, and platform type (x86)
If that all worked without issue, you can click 'Open Project' and you're into Visual Studio ready to build

I'm not the biggest fan of CMake, but it does seem to be the standard. Should we switch?

I agree that cmake is the way to go , then we can add vcpkg depdendency for wxwidgets

Are people doing okay with the CMake system?

I still couldn't test it, I had a busy week

Before I forget what I did, PR #129 changes the workflow test to use the new CMake system and drop the Boost requirements.
It's working, so we can look at the final step in all this, removing the old build files.

It's been a while (work), would everybody be okay if we get rid of the old build files now?


Potential security issues in GitHub Actions workflows

Potential security issues in GitHub Actions workflows
Hi! We are a research team from Radboud University in the Netherlands, currently working on security vulnerability analysis on GitHub Actions workflows. During our study, we found some potential issues in the workflow files of your repository and would like to bring them to your attention to help enhance security.
If you are interested, how would you like us to report it？
If you have any questions, please feel free to reach out!
Thank you!

Hi @jiangnanpro, my apologies, we missed this earlier! Thank you for studying our repo. If you have changes to suggest, please open PRs with improvements or create new issues in the repository.


PubSub accross cluster using helm/k8s not working after scale-down than scale-up

Environment

VerneMQ Version: 1.11.0
OS: alpine
Deployed on k8s using helm: helm install vernemq vernemq/vernemq -f values.yaml
VerneMQ configuration, values.yaml:

replicaCount: 2
service:
  type: LoadBalancer
  loadBalancerIP: ...............
additionalEnv:
  - name: DOCKER_VERNEMQ_ACCEPT_EULA
    value: "yes"
  - name: DOCKER_VERNEMQ_ALLOW_ANONYMOUS
    value: "on"
  - name: DOCKER_VERNEMQ_LISTENER__TCP__ALLOWED_PROTOCOL_VERSIONS
    value: "3,4,5"

Client: Eclipse Paho (org.eclipse.paho.mqttv5.client, version 1.2.5) using the async API

Expected behaviour

I'm running a test where multiple publishers and multiple subscribers are connecting to the cluster using the load-balancer
when I scale down to 1 pod than back to 2 pods than restart my test, many of the published messages aren't delivered to the subscribers

Actual behaviour

I suspect that if the publisher is connected to a different pod than the one used by the subscriber, the message isn't sent across the cluster
Its a bit similar to #586

Anyways, I assume its a configuration I miss (maybe persistent volume?), however kudos for the great helm chart - very nice!

Thanks, do you see the same logs as mentioned in https://github.com/vernemq/vernemq/issues/586?
Can you check with the HTTP status page whether you see the expected number of subscriptions on both nodes before the scale down?

Hi and thank you for the very quick response.
I've repeated the test, this time taking note of the logs and watching the HTTP status page.

after cluster creation (helm install vernemq vernemq/vernemq -f values.yaml) - test is running and all is good

HTTP status:

Cluster Overview
Cluster Size 	Clients online 	Clients offline 	Connect Rate 	Publish In Rate 	Publish Out Rate 	Msg Drop Rate 	Msg Queued
2 	32 	0 	0 sec 	4637 sec 	0 sec 	0 sec 	0
Node Status
Node 	Clients 	Connect Rate 	Publish In Rate 	Publish Out Rate 	Msg Drop Rate 	Msg Queued 	Subscriptions 	Retained
<EMAIL_ADDRESS>1.11.0
Protocols: MQTTWS MQTT
Reachable peers: 2 of 2
Routing score: 53 / 46 	15 online
0 offline 	0 sec 	2187 sec 	0 sec 	0 sec 	0 	32 	0
<EMAIL_ADDRESS>1.11.0
Protocols: MQTTWS MQTT
Reachable peers: 2 of 2
Routing score: 58 / 41 	17 online
0 offline 	0 sec 	2450 sec 	0 sec 	0 sec 	0 	32 	0

After scaling down to 1 pod (k scale statefulset vernemq --replicas 1):

HTTP status:

Cluster Overview
Cluster Size 	Clients online 	Clients offline 	Connect Rate 	Publish In Rate 	Publish Out Rate 	Msg Drop Rate 	Msg Queued
1 	32 	0 	0 sec 	4594 sec 	0 sec 	0 sec 	0
Node Status
Node 	Clients 	Connect Rate 	Publish In Rate 	Publish Out Rate 	Msg Drop Rate 	Msg Queued 	Subscriptions 	Retained
<EMAIL_ADDRESS>1.11.0
Protocols: MQTTWS MQTT
Reachable peers: 1 of 1
Routing score: 100 / 0 	32 online
0 offline 	0 sec 	4594 sec 	0 sec 	0 sec 	0 	32 	0

Dying pod's (vernemq-1) log added:

14:06:09.244 [info] all queues offline: 0 draining, 0 offline, 0 msgs
14:06:09.246 [info] writing state {[{[{actor,<<98,86,253,86,44,44,32,80,38,204,9,53,246,253,175,65,24,24,169,206>>}],1},{[{actor,<<105,0,139,112,183,5,84,254,157,54,186,254,74,70,213,209,65,1,244,211>>}],1}],{dict,1,16,16,8,80,48,{[],[],[],[],[],[],[],[],[],[],[],[],[],[],[],[]},{{[],[],[],[],[],[],[],[],[],[],[],[],[['VerneMQ@vernemq-0.vernemq-headless.iotp-vernemq.svc.cluster.local',{[{actor,<<105,0,139,112,183,5,84,254,157,54,186,254,74,70,213,209,65,1,244,211>>}],1}]],[],[],[]}}},{dict,0,16,16,8,80,48,{[],[],[],[],[],[],[],[],[],[],[],[],[],[],[],[]},{{[],[],[],[],[],[],[],[],[],[],[],[],[],[],[],[]}}}} to disk <<75,2,131,80,0,0,1,84,120,1,203,96,206,97,96,96,96,202,96,2,81,140,25,76,41,12,172,137,201,37,249,69,185,64,174,72,82,216,223,48,29,29,133,0,181,51,156,166,223,254,174,119,148,144,88,121,46,43,17,168,10,155,226,76,134,238,130,237,172,33,255,230,154,237,250,231,229,118,245,162,35,227,151,203,64,197,89,25,156,41,12,44,41,153,201,37,137,140,137,2,64,200,145,24,144,104,144,33,144,133,6,50,24,81,197,192,86,128,221,150,194,224,24,150,90,148,151,234,27,232,80,6,162,115,11,117,13,244,96,172,140,212,196,148,156,212,226,98,189,204,252,146,2,93,168,168,94,113,89,178,94,114,78,105,113,73,106,145,94,78,126,114,98,14,105,78,6,57,13,225,108,6,82,156,13,210,10,0,4,134,112,63>>
14:06:09.249 [warning] connection to node<EMAIL_ADDRESS>has been closed, reconnect in 1000ms
14:06:09.250 [warning] remove supervision for node<EMAIL_ADDRESS>14:06:09.253 [info] Leaving cluster, removed cluster_state
[os_mon] memory supervisor port (memsup): Erlang has closed
[os_mon] cpu supervisor port (cpu_sup): Erlang has closed
RPC to<EMAIL_ADDRESS>failed: {'EXIT',
{badarg,
[{ets,
lookup,
[clique_commands,
["vmq-admin",
"node",
"stop"]],
[]},
{clique_command,
match_lookup,
1,
[{file,
"/opt/vernemq/_build/default/lib/clique/src/clique_command.erl"},
{line,
124}]},
{clique_command,
match,
1,
[{file,
"/opt/vernemq/_build/default/lib/clique/src/clique_command.erl"},
{line,
111}]},
{clique,
run,
1,
[{file,
"/opt/vernemq/_build/default/lib/clique/src/clique.erl"},
{line,
126}]},
{rpc,
'-handle_call_call/6-fun-0-',
5,
[{file,
"rpc.erl"},
{line,
197}]}]}}
rpc error: code = Unknown desc = Error: No such container: 72ee9c313a22fe44a04672c07b4c68fee825524bad52af182cb4259c637b82f4%

Surviving pod's (vernemq-0) log added:

14:06:09.237 [info] writing state {[{[{actor,<<98,86,253,86,44,44,32,80,38,204,9,53,246,253,175,65,24,24,169,206>>}],1},{[{actor,<<105,0,139,112,183,5,84,254,157,54,186,254,74,70,213,209,65,1,244,211>>}],1}],{dict,1,16,16,8,80,48,{[],[],[],[],[],[],[],[],[],[],[],[],[],[],[],[]},{{[],[],[],[],[],[],[],[],[],[],[],[],[['VerneMQ@vernemq-0.vernemq-headless.iotp-vernemq.svc.cluster.local',{[{actor,<<105,0,139,112,183,5,84,254,157,54,186,254,74,70,213,209,65,1,244,211>>}],1}]],[],[],[]}}},{dict,0,16,16,8,80,48,{[],[],[],[],[],[],[],[],[],[],[],[],[],[],[],[]},{{[],[],[],[],[],[],[],[],[],[],[],[],[],[],[],[]}}}} to disk <<75,2,131,80,0,0,1,84,120,1,203,96,206,97,96,96,96,202,96,2,81,140,25,76,41,12,172,137,201,37,249,69,185,64,174,72,82,216,223,48,29,29,133,0,181,51,156,166,223,254,174,119,148,144,88,121,46,43,17,168,10,155,226,76,134,238,130,237,172,33,255,230,154,237,250,231,229,118,245,162,35,227,151,203,64,197,89,25,156,41,12,44,41,153,201,37,137,140,137,2,64,200,145,24,144,104,144,33,144,133,6,50,24,81,197,192,86,128,221,150,194,224,24,150,90,148,151,234,27,232,80,6,162,115,11,117,13,244,96,172,140,212,196,148,156,212,226,98,189,204,252,146,2,93,168,168,94,113,89,178,94,114,78,105,113,73,106,145,94,78,126,114,98,14,105,78,6,57,13,225,108,6,82,156,13,210,10,0,4,134,112,63>>
14:06:09.240 [warning] remove supervision for node<EMAIL_ADDRESS>14:06:10.035 [warning] cluster node<EMAIL_ADDRESS>DOWN

Stopping my test, scaling up to 2 pods again (k scale statefulset vernemq --replicas 2)

pod from before (survivor, vernemq-0) added the following logs:

14:09:32.846 [info] cluster node<EMAIL_ADDRESS>UP
14:09:32.848 [info] writing state {[{[{actor,<<98,86,253,86,44,44,32,80,38,204,9,53,246,253,175,65,24,24,169,206>>}],1},{[{actor,<<105,0,139,112,183,5,84,254,157,54,186,254,74,70,213,209,65,1,244,211>>}],1},{[{actor,<<132,239,58,181,90,208,128,214,0,34,191,181,2,147,16,81,254,41,46,185>>}],1}],{dict,2,16,16,8,80,48,{[],[],[],[],[],[],[],[],[],[],[],[],[],[],[],[]},{{[],[],[],[],[],[],[],[],[],[],[],[],[['VerneMQ@vernemq-0.vernemq-headless.iotp-vernemq.svc.cluster.local',{[{actor,<<105,0,139,112,183,5,84,254,157,54,186,254,74,70,213,209,65,1,244,211>>}],1}],['VerneMQ@vernemq-1.vernemq-headless.iotp-vernemq.svc.cluster.local',{[{actor,<<132,239,58,181,90,208,128,214,0,34,191,181,2,147,16,81,254,41,46,185>>}],1}]],[],[],[]}}},{dict,0,16,16,8,80,48,{[],[],[],[],[],[],[],[],[],[],[],[],[],[],[],[]},{{[],[],[],[],[],[],[],[],[],[],[],[],[],[],[],[]}}}} to disk <<75,2,131,80,0,0,1,248,120,1,203,96,206,97,96,96,96,206,96,2,81,140,25,76,41,12,172,137,201,37,249,69,185,64,174,72,82,216,223,48,29,29,133,0,181,51,156,166,223,254,174,119,148,144,88,121,46,43,17,168,10,155,226,76,134,238,130,237,172,33,255,230,154,237,250,231,229,118,245,162,35,227,151,203,56,21,183,188,183,218,26,117,161,225,26,131,210,254,173,76,147,5,2,255,105,234,237,4,42,206,202,224,76,97,96,73,201,76,46,73,100,74,20,0,66,142,196,128,68,131,12,129,44,52,144,193,136,42,6,114,15,216,81,64,247,59,134,165,22,229,165,250,6,58,148,129,232,220,66,93,3,61,24,43,35,53,49,37,39,181,184,88,47,51,191,164,64,23,42,170,87,92,150,172,151,156,83,90,92,146,90,164,151,147,159,156,152,67,146,255,178,192,118,99,177,214,144,58,214,226,10,41,80,136,32,66,139,129,148,208,2,105,5,0,101,69,167,171>>
14:09:33.852 [info] successfully connected to cluster node<EMAIL_ADDRESS>14:09:37.052 [info] completed metadata exchange with<EMAIL_ADDRESS>repaired 0 missing local prefixes, 1 missing remote prefixes, and 0 keys

new pod's (vernemq-1) log (only tail):

14:09:31.822 [info] Try to start vmq_generic_msg_store: ok
14:09:31.961 [info] loaded 0 subscriptions into vmq_reg_trie
14:09:31.966 [info] cluster event handler 'vmq_cluster' registered
14:09:32.845 [info] Sent join request to<EMAIL_ADDRESS>14:09:32.854 [info] cluster node<EMAIL_ADDRESS>UP
14:09:32.856 [info] writing state {[{[{actor,<<98,86,253,86,44,44,32,80,38,204,9,53,246,253,175,65,24,24,169,206>>}],1},{[{actor,<<105,0,139,112,183,5,84,254,157,54,186,254,74,70,213,209,65,1,244,211>>}],1},{[{actor,<<132,239,58,181,90,208,128,214,0,34,191,181,2,147,16,81,254,41,46,185>>}],1}],{dict,2,16,16,8,80,48,{[],[],[],[],[],[],[],[],[],[],[],[],[],[],[],[]},{{[],[],[],[],[],[],[],[],[],[],[],[],[['VerneMQ@vernemq-0.vernemq-headless.iotp-vernemq.svc.cluster.local',{[{actor,<<105,0,139,112,183,5,84,254,157,54,186,254,74,70,213,209,65,1,244,211>>}],1}],['VerneMQ@vernemq-1.vernemq-headless.iotp-vernemq.svc.cluster.local',{[{actor,<<132,239,58,181,90,208,128,214,0,34,191,181,2,147,16,81,254,41,46,185>>}],1}]],[],[],[]}}},{dict,0,16,16,8,80,48,{[],[],[],[],[],[],[],[],[],[],[],[],[],[],[],[]},{{[],[],[],[],[],[],[],[],[],[],[],[],[],[],[],[]}}}} to disk <<75,2,131,80,0,0,1,248,120,1,203,96,206,97,96,96,96,206,96,2,81,140,25,76,41,12,172,137,201,37,249,69,185,64,174,72,82,216,223,48,29,29,133,0,181,51,156,166,223,254,174,119,148,144,88,121,46,43,17,168,10,155,226,76,134,238,130,237,172,33,255,230,154,237,250,231,229,118,245,162,35,227,151,203,56,21,183,188,183,218,26,117,161,225,26,131,210,254,173,76,147,5,2,255,105,234,237,4,42,206,202,224,76,97,96,73,201,76,46,73,100,74,20,0,66,142,196,128,68,131,12,129,44,52,144,193,136,42,6,114,15,216,81,64,247,59,134,165,22,229,165,250,6,58,148,129,232,220,66,93,3,61,24,43,35,53,49,37,39,181,184,88,47,51,191,164,64,23,42,170,87,92,150,172,151,156,83,90,92,146,90,164,151,147,159,156,152,67,146,255,178,192,118,99,177,214,144,58,214,226,10,41,80,136,32,66,139,129,148,208,2,105,5,0,101,69,167,171>>
14:09:33.863 [info] successfully connected to cluster node<EMAIL_ADDRESS>

HTTP status:

Cluster Overview
Cluster Size 	Clients online 	Clients offline 	Connect Rate 	Publish In Rate 	Publish Out Rate 	Msg Drop Rate 	Msg Queued
2 	0 	0 	0 sec 	0 sec 	0 sec 	0 sec 	0
Node Status
Node 	Clients 	Connect Rate 	Publish In Rate 	Publish Out Rate 	Msg Drop Rate 	Msg Queued 	Subscriptions 	Retained
<EMAIL_ADDRESS>1.11.0
Protocols: MQTTWS MQTT
Reachable peers: 2 of 2
Routing score: 0 / 0 	0 online
0 offline 	0 sec 	0 sec 	0 sec 	0 sec 	0 	0 	0
<EMAIL_ADDRESS>1.11.0
Protocols: MQTTWS MQTT
Reachable peers: 2 of 2
Routing score: 0 / 0 	0 online
0 offline 	0 sec 	0 sec 	0 sec 	0 sec 	0 	0 	0

Now I started my test again which fails

log of vernemq-0 added:

14:12:36.626 [info] completed metadata exchange with<EMAIL_ADDRESS>repaired 0 missing local prefixes, 0 missing remote prefixes, and 6 keys
14:13:26.629 [info] completed metadata exchange with<EMAIL_ADDRESS>repaired 0 missing local prefixes, 0 missing remote prefixes, and 6 keys

log of vernemq-1 added:

14:12:41.572 [info] completed metadata exchange with<EMAIL_ADDRESS>repaired 0 missing local prefixes, 0 missing remote prefixes, and 5 keys
14:13:21.575 [info] completed metadata exchange with<EMAIL_ADDRESS>repaired 0 missing local prefixes, 0 missing remote prefixes, and 5 keys

HTTP status:

Cluster Overview
Cluster Size 	Clients online 	Clients offline 	Connect Rate 	Publish In Rate 	Publish Out Rate 	Msg Drop Rate 	Msg Queued
2 	32 	0 	0 sec 	0 sec 	0 sec 	0 sec 	0
Node Status
Node 	Clients 	Connect Rate 	Publish In Rate 	Publish Out Rate 	Msg Drop Rate 	Msg Queued 	Subscriptions 	Retained
<EMAIL_ADDRESS>1.11.0
Protocols: MQTTWS MQTT
Reachable peers: 2 of 2
Routing score: 0 / 0 	11 online
0 offline 	0 sec 	0 sec 	0 sec 	0 sec 	0 	32 	0
<EMAIL_ADDRESS>1.11.0
Protocols: MQTTWS MQTT
Reachable peers: 2 of 2
Routing score: 0 / 0 	21 online
0 offline 	0 sec 	0 sec 	0 sec 	0 sec 	0 	32 	0

Also, I verified that the nodes can reach each (curl vernemq-0.vernemq-headless.iotp-vernemq.svc.cluster.local:8080/status from vernemq-1 and vice versa)

Can you find out/show number of "Subscriptions" before and after test on the HTTP status page? or using sudo vmq-admin metrics show | grep subscriptions for both nodes.

After cluster is created and the test is running ok, there are 32 subscriptions (with 18 clients on one pod and another 14 in the other pod) - this is expected.
After I scale down, there are still 32 subscriptions 32 online clients connected to the surviving pod - also expected.
After I restart the test, there are only 25 subscriptions with 19 online clients on one pod and another 13 in the other.

Note that the test doesn't report on any error at all and that the behavior is consistent 100% of the times I repeated this procedure.
BTW, I've noticed that when I vmq-admin cluster show after scaling up, it shows two rows with running=true even though when I  k get pods the new pod is still showing ready=0/1

What does it mean that the "routing score" is 0/0 - sounds like a routing issue...

Routing score is a proportion of how many message were delivered locally vs to a cluster node, in the last 10 seconds, I think.
Ok, so from above stats the situation seems clear: we have all the clients online, but we miss 7 subscriptions.
Can you somehow check any SUBACK response codes when your are subscribing?
Can you add a separate step, after you rescale up to 2 nodes.  What happens, how many subscriptions do you see at this stage?

Not sure what do you mean by a separate test - after I re-scale up, I wait for k8s to show the two pods as ready and for the HTTP status to show that there are two nodes with 0 clients and 0 subscriptions.
Only than I run my test.
I've changed the code to log the response code of the subscribe request (using paho, v5, async's IMqttToken.getReasonCodes()) and it's always 0 (before and after rescaling).

I tried again after re-scaling up, this time I changed my test's topics, so the subscriptions will not overlap anything from before the scaling and the issue is reproduced, however looking at the HTTP status page, this time its showing 32 subscriptions.

Ok, adding a 1m sleep between the time the test finishes subscribing (32 clients, 32 subscribers) and the time it starts publishing.
This seems to solve the issue.

Yeah, state in a VerneMQ cluster is eventually consistent, although a minute in that case seems quite "eventually" :)
Maybe this is missing the first sync for some reason, and then this is actually anti-entropy kicking in here.

Makes sense (I can probably find a shorter time than a minute for this...).
Are there any "tunables" I can try that may affect this?

WIll dig for tunables sometime later, thanks for the help.
Closing this.

Sorry to reply on this already closed issue but we're facing very similar problems that seem related to this one.
Our Environment consists of:

VerneMQ Version: <IP_ADDRESS>
OS: Docker image built from sources and deployed on Kubernetes with official Helm chart.
Cluster size/standalone: cluster with 3 nodes, but issue appears even with only 2 nodes.

We tested with different clients that use paho.mqtt.golang and MQTT.js libraries or directely with mosquitto software.
One broker client (we called "authenticator") keeps a connection active with a subscrition on a wildcard topic and reply to incoming messages on topics specific to the device which sent the original message.
After a scale down/scale up of the cluster, done with Kubernetes statefulset scale command or manually destroying a VerneMQ pod of the cluster some of these incoming mesagges are not more delivered to the "authenticator" client.
We checked that all devices reconnect properly after a cluster node replacement but the number of subscriptions shown on HTTP status page differ from the 2 nodes of the cluster.
What we should expect about the number of subscription on a cluster? Always the same on each node?
Troubleshooting with vmq-admin session show command all seems OK (devices connected, subscriptions registered) but some newly generated messages are lost and never delivered to properly registered subscribers.
It seems to us that after a scale down/up the "state" of the cluster is not properly replicated on the new node just spawned.
All messages have QoS 0.
We also tried switch to swc as medata plugin and add persistance using external storage (AWS EBS volumes) but the issue still persists.
Any suggestion will be very appreciated as this is blocking us to going into production with a VerneMQ cluster (up&running instead on other standalone instances).

@pandvan a couple of things to be aware of:

A node cannot leave the cluster, and then re-join with pre-existing state. It has to re-join with empty state. Please make sure to test this, I'd be interested to know whether your issue happens with re-joining on empty state. This is a current problem with K8s deployments, because a node termination always makes the VerneMQ node leave the cluster.
Note that while a node is booting up, subscribers connecting might get a SUBACK code of 128, saying that the subscription failed. (this is to protect against race conditions in loading subscriptions from disk). If those clients do not handle the status code, they'll stay happily connected but without any subscription. To be clear, this is most likely not what's happening in your case, but keep an eye on it.
State is replicated in a eventually consistent fashion, but as a rule, yes, subscription count should be the same on each node.

@ioolkos thanks for your quickly answer, very appreciated.
I try to reply here below, then make some other tests and report outcomes.

A node cannot leave the cluster, and then re-join with pre-existing state. It has to re-join with empty state. Please make sure to test this, I'd be interested to know whether your issue happens with re-joining on empty state. This is a current problem with K8s deployments, because a node termination always makes the VerneMQ node leave the cluster.

We have already tested this as the same happens also without enabling persistence, i.e. using the default EmptyDir configuration for data volume.
I suppose that deploying the k8s statefulset using EmptyDir volumes equals to startup a new node with an empty state. Am I right?

Note that while a node is booting up, subscribers connecting might get a SUBACK code of 128, saying that the subscription failed. (this is to protect against race conditions in loading subscriptions from disk). If those clients do not handle the status code, they'll stay happily connected but without any subscription. To be clear, this is most likely not what's happening in your case, but keep an eye on it.

We need to investigate more on this, it was not considered.
Hope we can use vmq-admin trace client command so view such ACK messages.
I'll get back on this to you soon.

State is replicated in a eventually consistent fashion, but as a rule, yes, subscription count should be the same on each node.

This doesn't seem to happen always even with a simple scale up of the cluster from 1 node to 2.
We fetch the value from HTTP status page and also Prometheus formatted metrics (on router_subscriptions gauge).
Does the nature of subscribed topic matter? Is this counter supposed to increase even if 2 or more clients subscribe to the same topic (e.g. a wildcard one)?
Glad to give you more details or perform other tests if needed to better understand the root cause of this issue.


[Bluetooth][Mesh]: How to make sure the whole procedure completely while sending the ext adv?

Is your enhancement proposal related to a problem? Please describe.
Q: While sending the mesh packets with using ext adv, it must need to check the "ADV_FLAG_ACTIVE" status.
If the previous advertising termination is not reported or "BT_HCI_EVT_LE_ADV_SET_TERMINATED" packet lost, it will stuck the whole procedure, and cannot send any mesh packets over one advertising instance.
(Actually, it is important to fix the lost packet over HCI. But if the HCI transport is based on socket or uart etc, we cannot be sure the packet can be passed completely with 100%)
Describe the solution you'd like
Once we lost the important packets for mesh stack, is it possible to correct the procedure or fix the advertising?
Describe alternatives you've considered
1, Try to add timeout callback for one advertising.
2, Before start a new instance of advertising, check the previous advertise or check the expired time?
Additional context
Subsys: sys/bluetooth/mesh/adv_ext.c
Related function:  send_pending_adv/adv_sent

This should not be something that Mesh needs to consider. AFAIK the entire Host does not consider this issue, for example:https://github.com/zephyrproject-rtos/zephyr/blob/main/subsys/bluetooth/host/hci_core.c#L331

This should not be something that Mesh needs to consider. AFAIK the entire Host does not consider this issue, for example:https://github.com/zephyrproject-rtos/zephyr/blob/main/subsys/bluetooth/host/hci_core.c#L331

Once it happened, it may be a disaster, and Mesh cannot recover it. As you see within hci_core.c, it only cause one error command , not entire Host.

Hi @TimChengMJ, thanks for the report! Were you able to reproduce this issue or is this hypothetical situation?

Hi @TimChengMJ, thanks for the report! Were you able to reproduce this issue or is this hypothetical situation?

You can try to mark down "BT_HCI_EVT_LE_ADV_SET_TERMINATED" report.(or lost once per 100times, and then the mesh stack will stuck, and cannot send any message.)
I can see this issue while packet lost with using hci-socket/hci-uart. i cannot be sure the packet can be passed completely with 100% for my real project.

I think I understood what you mean. I've tried running hci_uart sample on nRF52840 and zephyr app with ble host built as native_posix, but couldn't reproduce this issue so far. But I think I agree that this can happen. What is your setup/hw?

In any case, we will see how we can fix this.


Upgrade ShellScriptV2 to Node JS 16

Task name: ShellScriptV2
Description: Task upgraded to NodeJS 16
Documentation changes required: N
Added unit tests: N
Attached related issue: https://github.com/microsoft/build-task-team/issues/3580
Checklist:

[x] Task version was bumped - please check instruction how to do it
[x] Checked that applied changes work as expected

/azp run


fix: correct Python modulo emulation for negative denominator

Thanks for your translation of this nice algorithm into Go.
However, I discovered that it did not work for more complex cases, while the original Python code did.
fix: replace absmod with pyMod that does correct emulation of Python modulo operator.
The code as it was did not work for more complex cases as the last test case added, while the original Python code did.
Removed unnecessary code including a (mod %2) that was converted to a boolean and back again.

Thank you!


[Feature Request] Link multiple characters to a single account

Courtesy of @eingang
Suggestion
Instead of a person creating essentially a new account for every single pilot they have (commonly requested when vetting recruits), they should be able to create a single account for their "main" and associate their other pilots with it. With the current UI design and terms like "Dashboard," it's already suggestive that this was perhaps an expectation.
Advantages
It puts all their pilots in one place so they don't have to remember whether or not they added a particular pilot. It should make it easier for them to grant/remove permissions or see tokens all in one place too.
For recruiters, they'd be able to see all the pilots associated with a given person and not have to remember "Oh, these seven pilots are this person; this one is that person." Recruiters are often dealing with multiple people in the same time period, so it's quite common that you end up with a big stack of pilots.
Disadvantages
The grant mechanism becomes more complicated. Should view grants then be:

all pilots associated with a given 'main'?
per individual pilot?

The first is simple, but possibly precludes the possibility of a given person, for whatever reason, wanting to share all pilots with RecruiterA but only a subset of pilots with RecruiterB. That could be worked around by allowing someone to add pilots as mains even if the pilot is already known to the system, i.e., already associated with a 'main' but not already as a main itself. There'd logically only be one copy of the pulled pilot data and however many places need to access it could just point to the one copy.
For the second, the UI becomes a bit messy on the pilot side for seeing/manipulating the grants, but it could probably be done.

You are 100% correct. All my projects have/will have the ability to add multiple characters. This is why I have the "Dashboard" as you pointed out. However, my dumbass did not take this into consideration when writing the grant code, so this will need to be revisited. The way I am thinking this will work is from the recruiters side, the grant system will remain the same. Maybe a checkbox to requests access to all characters on the profile instead of just one, however from the users side ("recruitee"), the UI would change to include a list of characters with checkboxes next to each. If the character is to be included, then they check, otherwise leave it unchecked.

Resolved with https://github.com/ddavaham/esiknife/commit/08e5a3a2b051dd412b1878f42339601858b8f72a


Add test case for CloseAllDocuments

Test that CloseAllDocuments yields until all documents are closed.
Including when there are documents that are:

Open and session locked
Open and not session locked
Closed and session locked
Closed and not session locked

Need to test with the mockdatastore yield request method before closing, and write a Roblox test due to the different behaviour of the task scheduler in Lune


ensure default_tenant exists in tests

Tests were failing because the views now assume there exists a tenant
The tenant is loaded from the default tenant.

/cc @jrafanie This seems to resolve issues introduced by #3901
Issue: more and more pages are depending upon a current_tenant (and therefore default tenant) being set.

@kbrock I rebased on master, didn't have a tenant seeded, and after logging in was met with error screens because as you said, the views assume a tenant exists. I migrated after I rebased, did I miss a step somewhere? After running Tenant.seed everything is working now, so do we think this PR should be extended to ensure a default tenant exists not only in the tests but just overall?

@kbrock I ran into the same problem as @eclarizio, rake evm:db:reset, EvmDatabase.seed_primordial, bin/rails s, login, I get this error:

If we need a default tenant everywhere, we need to add it to the primordial classes although I don't know why we need default tenant everywhere.


add chat and run functional tests only on master

Coverage remained the same at 89.126% when pulling 85ae7346c5257a33aa8027332524d276908c999f on misc-improvements into 6892799fef3c3d1d58aacba04cdf61e1555c9e6f on master.


HighResMIP start date incorrect

This issue seems to be related to experiment_id.json file.
https://github.com/PCMDI/cmip6-cmor-tables/issues/43

@dnadeau4 why do you say it's incorrect? What is the info source?

I am not saying it is incorrect @jonseddon is saying so.

we should check with the co-chairs before changing

The details are now correct in this repository for HighResMIP, the changes just haven't been pulled through to https://github.com/PCMDI/cmip6-cmor-tables yet. They should appear in the next version of PCMDI/cmip6-cmor-tables. We're happy that everything's good and just need to be more patient.

@jonseddon I just updated CMIP6_CV.json in the https://github.com/PCMDI/cmip6-cmor-tables repository.  I need to add this to my check list when I update the tables... Thanks for letting us know.

@dnadeau4 @jonseddon @taylor13 ok it seems everything is ok here, so closing this issue


Ultimore a world divided for U3

Support with and without upgrade patch

Done. https://github.com/Fenyx4/UltimaPatcher/pull/5


Delete values for missing attributes/relationships

Hi,
First of all thanks for this framework! Before I was using RestKit but this Sync has much cleaner approach. I was wondering about one thing though: if the server doesn't an attribute it seems Sync doesn't set the value to null. So for example, first the server responds with:
[
  {
    "id": 6,
    "name": "Shawn Merrill",
    "email"<EMAIL_ADDRESS>    "note": {
      "id": 2,
      "text": "Shawn Merril's diary, episode 1"
    }
  }
]

Then later on, when I removed the note on the server, the server sends:
[
  {
    "id": 6,
    "name": "Shawn Merrill",
    "email"<EMAIL_ADDRESS>  }
]

As you see, instead of sending note: null it's not sending note at all. In this case Sync doesn't remove the relationship. Is this something that maybe can be configured somewhere or do you have any tips how to handle this situation?

I just noticed that even when the server is sending null, still the relationship isn't removed. I tried the following 2 cases:
[
  {
    "id": 6,
    "name": "Shawn Merrill",
    "email"<EMAIL_ADDRESS>    "note": {}
  }
]

[
  {
    "id": 6,
    "name": "Shawn Merrill",
    "email"<EMAIL_ADDRESS>    "note": null
  }
]

Hi @risp, you need null to clear the relationship. Your second example should work. I'll have a look.
Thanks for reporting this!

Hi @3lvis any idea when you have time to look at this?

Fixed here https://github.com/SyncDB/Sync/pull/324/commits/f6a32e97403530036e53a51e1a0370a9fb451fe8
I'm sorry this took that long. It usually doesn't take much before things are fixed, it's just that things at work have been quite chaotic. Let me know if you have any other issues.
Have a great weekend :)

@3lvis Thanks a lot!


feat(gax): add protobuf version tracking to headers

Update the Java client libraries to report the runtime version of Protobuf as part of the existing x-goog-api-client request header.
Tested: java-cloud-library api (billing) and hand written api (storage)

LGTM w/ addition of Showcase tests showing gRPC + httpjson clients are both providing the new headers.
Looking for approval from @blakeli0

Adding Do Not Merge for now since we plan to release this together with the protobuf runtime upgrade.


[Feature]: Change README.rst to Markdown format

Reason or Problem to Solve:
Change the README. file from rst to md format.  This is a personal choice.
Proposed Solution:
Change the file extension and adapt the content.

I reconsidered the change and decided against it for the following reasons:
Both Markdown (.md) and reStructuredText (.rst) are lightweight markup languages that are commonly used for documentation, especially in the Python community. Here are a few considerations that might help you choose between them:
Complexity and Features: Markdown is simpler and easier to write and read, but it has fewer features. reStructuredText is more complex and has a steeper learning curve, but it supports more advanced features like footnotes, citations, and automatic generation of tables of contents.
Tooling: If you're planning on using a documentation generator like Sphinx, you might want to choose reStructuredText, since Sphinx natively supports reStructuredText and some of its more advanced features might not be available with Markdown. On the other hand, if your documentation will primarily be read on GitHub or a similar platform, Markdown might be the better choice since it's widely supported and well-rendered on these platforms.
Community and Precedents: If your project is part of a larger ecosystem, you might want to follow the conventions of that ecosystem. For example, many Python projects use reStructuredText and Sphinx for documentation, while many JavaScript projects use Markdown.
In general, if you're writing a README file for a small to medium-sized project and you don't need advanced features, Markdown is a perfectly good choice. It's simple, widely supported, and sufficient for most READMEs. But if you're planning a larger documentation project with more complex needs, you might want to consider reStructuredText.


[Event Request] Codeunit::"Whse. Jnl.-Register Line" - Function DeleteFromBinContent - OnAfterClearFilterFromBinContent

We like to request the following Event:
Object: Codeunit::"Whse. Jnl.-Register Line"
Function: DeleteFromBinContent
Publisher Event: OnAfterClearFilterFromBinContent
Reason: To implement custom business logic
Where is the event placed:
FromBinContent.ClearTrackingFilters();
OnAfterClearFilterFromBinContent(WhseEntry2, FromBinContent, WhseEntry);
FromBinContent.CalcFields("Quantity (Base)");
Event Code:
[IntegrationEvent(false, false)]
local procedure OnAfterClearFilterFromBinContent(var WarehouseEntry2: Record "Warehouse Entry"; var BinContent: Record "Bin Content"; WarehouseEntry: Record "Warehouse Entry")
begin
end;

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. We will update this issue with information about availability. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.


add missing env and steps to pipeline docs

List pipelines will return env and steps like other pipeline API responses.

Sweet, thanks again @intuxicated! 👌🏻


onLoadEnd() not called on iOS

On iOS onLoadEnd() is never called.
To Reproduce:
import React from 'react'
import {
  Platform
} from 'react-native'
import { WebView as ReactWebView } from 'react-native-webview'

const meta = `
  <meta name="viewport" content="width=device-width;
  initial-scale=1.0; maximum-scale=1.0; user-scalable=0;" />
`
const script = "window.ReactNativeWebView.postMessage(document.documentElement.scrollHeight)"

export default class WevView extends React.Component {
  constructor (props) {
    super(props)

    this.onLoadEnd =
      this.onLoadEnd.bind(this)
    this.onShouldStartLoadWithRequest =
      this.onShouldStartLoadWithRequest.bind(this)
  }

  onLoadEnd () {
    /* Once the page has loaded inject
      the js script to retrieve the height
      of the content.
    */
    this.webview.injectJavaScript(script)
  }

  onShouldStartLoadWithRequest (event) {
    if (event.url && event.url !== 'about:blank') {
      // Handle clicks on links to open the
      // mobile default app
      this.webview.stopLoading()
    }
  }

  render() {
    const {
      style,
      html,
      ...otherProps
    } = this.props

    return (
      <ReactWebView
        source={{ html: `<!DOCTYPE html><html><head> ${meta} </head><body> ${this.props.html} </body></html>`}}
        onLoadEnd={this.onLoadEnd}
        originWhitelist={['*']}
        scalesPageToFit={Platform.OS === 'ios' ? undefined : false}
        scrollEnabled={false}
        onError={(err) => {console.log(err)}}
        javaScriptEnabled={true}
        showsVerticalScrollIndicator={false}
        onShouldStartLoadWithRequest={this.onShouldStartLoadWithRequest}
        {...otherProps}
      />
    )
  }
}

Expected behavior:
onLoadEnd() should be called when the webpage finished loading. It doesn't. onError() doesn't trigger errors. The result is a blank window. On Android everything works fine.
Environment:

OS: iOS
react-native version: 34
react-native-webview version: 5.12.1

I found the problem, it was in the onShouldStartLoadWithRequest(). Indeed from the documentation, it must return true to continue the loading or false to stop it. My function was not returning anything. The strange part is, on Android not returning anything worked, the webview loaded; while on ios, it doesn't.
Here is my fixed function:
  onShouldStartLoadWithRequest (event) {
    if (event.url && event.url !== 'about:blank') {
      // Handle clicks on links to open the
      // mobile default app
      this.webview.stopLoading()
      return false
    }

    return true
  }


Weird Path.arc results

I noticed that the arc breaks or gets drawn wrong with specific angles.
Some examples are:
Path.arc([20, 40], 10, 0.3217505543966421, -2.819842099193151)
Path.arc([40, 40], 10, -1.82, 1.33)

Thank you for reporting the issue. I'll see what's wrong with the library and refactor it then;)

Pull request #2 should fix the main bug.
In case of ([40, 40], 10, -1.82, 1.33).
It seems like while loop adds a second A path, which adds up to 2 Arcs [M A A].
Not sure if this is intended, but doesn't seem to affect the rendering.


[FEATURE REQUEST] Audio control

Describe the solution you'd like
The ability to control the volume of the current/default audio device. Volume up/down and toggle mute.
Describe alternatives you've considered
No other alternatives AFAIK.
Additional context
Unsure where to source these controls on Linux at least. Likely will need to resort to command-line utilities.

Volume control is now available as of v9.0.0 when MQTT is enabled.


Several transparent colours are confusing

It's rarely useful to have several fully-transparent colours with opacity of 0. Yet, R48 makes creating them by accident very easy: when you create a new colour, the transparency of the previous colour is preset as the default, so if you're not careful enough, you'll end up with many transparent colours.
What is worse, when exporting an image with several transparent colours to 8-bit PNG, they are saved in a way that is incompatible with EasyRPG, RPG Maker 2000 and 2003:

This would display as follows:

I suggest this: when adding a new colour, and the existing colour has Alpha of 0, then pre-set alpha to 255. (This means people who know what they are doing would still be able to enter 0 manually, but the rest of us won't get confused by several transparent colours.)

...ah. ...Yeah, the way multiple transparent colours are saved is setup in a way that... should be valid PNG-wise but won't play well with the way they're treated by RPG Maker engines.
I should probably setup a warning for saving with the invalid setups...

Assuming closed for now given I've implemented a slightly modified version of your suggestion in master.


Add NameBuilder Utility

According to #750, a nameBuilder utility is now added under include/catalog/postgres/nameBuilder.h, and it follows Postgres' convention. constraint names for foreign key and unique are changed, and more names will be changed to use this utility.

This is ready to merge once the build passes.

I keep rerunning it and network_test or filter_manager_test fails every time. The random failures have spiked lately.

I agree and it's really annoying.  I'm going to look into it.  Sorry for the hassle...

@crd477 Can we retain the gtest/junit XML output files? Not sure if Jenkins supports the same test being executed multiple times.

If you mean retaining them systematically as part of the pipeline, yes, that's easy.  See lines 282-284 in Jenkinsfile for example.
If you mean retain them only the purpose of debugging these failures, that's not really necessary since I can customize and replay the Jenkins pipeline from the web interface and then look at the logs in the worker.


fix: remove unsupported user manuals

the commit log and PR subject use "docs: xxx" would be more appropriate for document change but that's fine.


Using Symfony\Component\Validator\Context\LegacyExecutionContext

Quick fix so voting works in Symfony 2.5.

Has anyone provided a fix for this issue? Thanks.


test-branch/execute-job/quoted-authorization/8713e125-bdce-4169-b298-9cfd47599be7

PR for testing 1818fb863c36b35ab599e7709ddd08978aebce89

/canonical/self-hosted-runners/run-workflows 1818fb863c36b35ab599e7709ddd08978aebce89


method not allowed while trying to get /metrics

Hi, I have a fresh installation of Kong (backed with Postgres) and after enabling the Prometheus plugin globally I am unable to retrieve any metrics using the Kong Admin API.
I'm getting a "method not allowed" (code 405) error from Kong:
$ http GET http://kong:8001/metrics
HTTP/1.1 405 Not Allowed
Access-Control-Allow-Origin: *
Connection: keep-alive
Content-Length: 32
Content-Type: application/json; charset=utf-8
Date: Tue, 10 Dec 2019 17:42:49 GMT
Server: kong/1.4.1
X-Kong-Admin-Latency: 0

{
    "message": "Method not allowed"
}

I am also seeing the following error in Kong's logs:
2019/12/10 17:42:49 [error] 31#0: *21344 lua coroutine: runtime error: don't know how to respond to GET
stack traceback:
coroutine 0:
        [C]: ?
coroutine 1:
        [C]: in function 'resume'
        /usr/local/share/lua/5.1/lapis/application.lua:397: in function 'handler'
        /usr/local/share/lua/5.1/lapis/application.lua:130: in function 'resolve'
        /usr/local/share/lua/5.1/lapis/application.lua:167: in function </usr/local/share/lua/5.1/lapis/application.lua:165>
        [C]: in function 'xpcall'
        /usr/local/share/lua/5.1/lapis/application.lua:173: in function 'dispatch'
        /usr/local/share/lua/5.1/lapis/nginx.lua:230: in function 'serve'
        /usr/local/share/lua/5.1/kong/init.lua:1122: in function 'admin_content'
        content_by_lua(nginx-kong.conf:195):2: in main chunk, client: <IP_ADDRESS>, server: kong_admin, request: "GET /metrics HTTP/1.1", host: "kong:8001"
<IP_ADDRESS> - - [10/Dec/2019:17:42:49 +0000] "GET /metrics HTTP/1.1" 405 32 "-" "HTTPie/1.0.3"

I am running Kong in a Docker container from the official Kong image and I defined a simple service with a single route to it for testing. What can be wrong? Thanks in advance for any help.

You are running into https://github.com/Kong/kong/issues/5291.
Kong 1.4.2 is being released as I write this comment. Expect a Docker image to be up soon.

Oh! It didn't occur to me to search on the Kong issue tracker itself as other plugins seem to be working for me. Glad to know the problem was identified and fixed already!
Will close this issue as soon as I confirm the new version being okay. Thanks!

I updated Kong to version 1.4.2 today and I can confirm now that the prometheus plugin is working under the Admin API. In the meantime I also discovered the Status API which I believe is better suited for this plugin so I've been using that API instead of exposing /metrics from the Admin API.
Anyway, closing this as resolved! Thanks!

@hhromic  Hi buddy ,did you mean  it can be solved  by  upgrading to 1.4.2  and change status_listen to  <IP_ADDRESS>:8001?