Canifis overhaul

Overhauls the Canifis region and Frankenstrain's Castle:

Replaces hd_wooden_planks_1 with hd_wooden_planks_2; updated license
Replace all Canifis floors floor with wooden planks instead of dirt
Replaced Frankenstrain's Castle floor with jagged stone tile instead of varied dirt
Add missing doors, chairs, and tables
Assigned metal to the fences
Added missing grass

Known issues:

Doube Doors in Frankenstrain's Castle have no textures as they are door and walls as a single object and needs a proper UV to support it.

Frankenstrain's Castle:

I still think the plank texture could do with a replacement, but it's not worth delaying this PR over, especially considering the texture is already in use elsewhere.


Vue TSC & computed-refs

I do not understand why this have an error with transpiling with vue-tsc :
import { computed, ComputedRef, UnwrapNestedRefs } from "vue";

interface ConcreteTest {
    val: ComputedRef<string>;
}

interface Store {
    registers: ConcreteTest[];
}

class StoreManager {
    public store: UnwrapNestedRefs<Store> = {
        registers: []
    };

    addRegisters(){
        const val = computed(() => { return "0xaa" });
        this.store.registers.push({ val }); // => The expected type comes from property 'val' which is declared here on type '{ val: string; }'
    }
}

You can check it here : https://github.com/louis49/demo-vue-ts-computed-refs.git with npm build

This is likely a vue core issue

Попробуй убрать UnwrapNestedRefs. Или { val: val.value}

Hey there, as there have been many fixes in the last 2.x versions: Please let us know if you're still encountering this issue. Otherwise kindly close this one, thanks!

This is expected. As said in https://github.com/vuejs/language-tools/issues/4350#issuecomment-2109275407, you can use { val: val.value }, or remove UnwrapNestedRefs. In real-world cases, you may need to use shallowRef instead of ref


HTML formatting issues after updating sphinx

Problem
I'm hosting the documentation for my python project on readthedocs, there are 2 formatting problems in the following section:
https://dpowers.readthedocs.io/en/latest/reference/power.html#Dpowers.KeyboardAdaptor.key
1st problem: The right margin is not respected (in this section of the documentation only).
2nd problem:  (for all sections) The font color of class and method names/arguments is entirely blue, although it should be black (with blue background). Other documentations on readthedocs look fine in my browser. --- similar to #1212
They occured after updating sphinx version to 4.1.2 from 3.4.3 - I can reproduce this locally on my computer.
Reproducible Project
The source folder for the documentation is here:
https://github.com/dp0s/Dpowers/tree/master/docs
Error Logs/Results
Local build on my computer with sphinx 4.1.2

Expected Results
Local build on my computer with sphinx 3.4.3

Environment Info

Python Version: 3.7
Sphinx Version: 4.1.2 / 3.4.3
RTD Theme Version: 0.5.2

Note
I recently introduced the sphinx hoverxref extension, which is still in beta mode. So I rebuilt the docs for an old version of my repository (v0.1.2) without hoverxref extension and the problem is the same.

Just noticed that the 2nd problem was already reported today in #1212.  So it should probably be discussed there.
That leaves the 1st problem concerning the right margin, which seems to be a bug.

For completeness: I tested building the documentation using the python_docs_theme  instead, still in sphinx 4.1.2.  There is no margin problem.  So it seems specific to sphinx_rtd_theme in combination with the sphinx version.

Can you test if these problems go away with the version from master? You can also try our pre-release form pypi https://pypi.org/project/sphinx-rtd-theme/1.0.0rc1/

Thanks for the suggestion, I tried 1.0.0rc1 with sphinx 4.1.2. locally:

As you can see the color problem is fixed :)  the right margin problem is still there.
I narrowed down the margin problem and found that
.. autodata:: Dpowers.KeyboardAdaptor.key
is displayed properly (i.e. the right margin is respected).
The problem occurs only for the key property's documentation when using
.. autoclass:: Dpowers.KeyboardAdaptor

Regarding the margin problem, I narrowed it down. It is an issue of how the autoclass directive handles the documentation of property objects with long code examples. For demonstration, I added the following example in my project:
class MyTestClass:

    @property
    def a_property_with_long_code_example(self):
        """
        This is a property with long code example::

            print("Some kind of long line to exceed the right margin ---------------------------------------------------------------------------------------------------")
        """
        pass

    def a_function_with_long_code_example(self):
        """
        This is a function with long code example::

            print("Some kind of long line to exceed the right margin ---------------------------------------------------------------------------------------------------")
        """
        pass

Now if I build the documentation of the following lines:
.. autoclass:: Dpowers.MyTestClass

.. autodata:: Dpowers.MyTestClass.a_property_with_long_code_example

the result is:


[WIP] Caching of tensors for decode (flash-attn)

This PR introduces TensorCache to cache tensors between successive iterations of the scheduler/prepare_inputs. This is similar to the effect of multi-step scheduler, however, this approach maintains a single-step behavior on expense of performance hit.
TODO:

Generalize caching to more complicated cases than simple +1
More benchmarks (Looks like it needs to be combined with e2e overheads reductions to see more speedup. In particular it works better when combined with this PR: https://github.com/vllm-project/vllm/pull/7162)

@njhill @comaniac @robertgshaw2-neuralmagic

I did a first benchmarks, and I can only see speedups when this PR is combined with https://github.com/vllm-project/vllm/pull/7162. Will investigate this more. It seems like we need to reduce the python bottlenecks first to actually see speedups from tensor caching.

Does that mean the speedup of this optimization is pretty marginal? I'm still debating between code simplicity and efficiency, so if we can't see a stable speedup (even it's just 2-3%), we should consider whether to introduce this.

@comaniac you right, I still need sometime to work on this to understand what's going on. It looks like we first need to finish https://github.com/vllm-project/vllm/pull/7162 and then I can investigate this more.

Converted to draft to indicate WIP


[BEAM-6959] add beam_PostCommit_Go_VR_Flink job

Note that I pretty much used "validates runner" and "integration" as consistently as I could within the existing naming scheme, but the distinction is pretty much meaningless as it's the same few tests anyway.

 We even got a shiny badge

\o/ Woot!

We can also update following get more of those fancy badges

Done, although I'm not sure why these manually maintained lists are still around. Shouldn't the process be automated?

Probably! I agree. @jasonkuster might have ideas around Generating the test grid README's properly based on something more canonical. However, it certainly shouldn't block this from going in.

@angoenka  Is there anything blocking this being merged that must be in this PR? I think there's the one question on the Flink runner versioning that should be answered, but that's it.


Snyk Review - August 2024

Use as https://github.com/CDCgov/prime-simplereport/pull/7702 for how to complete PR

PR merged today https://github.com/CDCgov/prime-simplereport/pull/8057


Fixed Windows terminal flashing on startup

Attempts to close the terminal on windows as fast as possible if --boot flag is set.

:warning: Please install the  to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Files with missing lines
Coverage Δ

src/main.rs
23.96% <ø> (ø)


Import error with update 3.6.2

I have the following error with version 3.6.2
When I run
import malaya
ModuleNotFoundError: No module named 'malaya.text.keyword'
I have testing with 3.6.0, this issue didn't occur.

I added new module in 3.6.2, this should be quick to solve, will bump version.

tested, bumped to 3.6.3, thanks!


34: Fix class equipment groups - [merged]

In GitLab by @Asacolips on Dec 19, 2020, 18:05
Merges 34-equipment-groups -> beta

Fixed a bug on new Class items that made creating equipment groups
cumbersome.

Closes #34

In GitLab by @Asacolips on Dec 19, 2020, 18:05
mentioned in commit c12327dd257f353e3e6b32b70d6f5710d0584b00


userGet Groups Misleading Schema

Hey
The changes brought forward in this pull provision non-superusers to access the userGet endpoint. After giving this a shot, it was evident that the schema inaccurately depicts the response from the API.
The schema depicts the groups property as an array of groups. Rather, the API returns a dictionary with the key being the group id and the value being the userGroupMembership-read item.
Although the API docs are inaccurate, The API itself should be updated to conform to the defined schema as it is more in line with other endpoints and works better with strictly typed languages.

API docs stipulate campus[].days to be an integer. A string is returned instead. @tallzeebaa

Resolved, turns out this was intended behaviour and docs have been updated to reflect that.


Update msvm-virtualsystemreferencepoint.md application consistent and crash consistent descriptions

Application consistent and crash consistent descriptions are swapped. Aligned the two in this edit.

@cpuck : Thanks for your contribution! The author(s) have been notified to review your proposed change.


Support additional context for presets

Based on https://github.com/nhoizey/images-responsiver/issues/21

For example, the same content with images can be included in the main area of the content's individual page, in a thinner column in another page, etc.
Presets could be specialized with a context:

preset-name for default behaviour of the image
preset-name:context-name for specific behaviour of the same image in a specific context

preset-name is attached to the image as usual, but context-name is an additional parameter of the computing function.

images-responsiver could be exposed as an Eleventy filter, so that developers can pass the context as additional parameter in different templates.

Now a duplicate of #21


Why FPS down when I get byte[] from Image?

I want to get every preview frame from camera to do some cv algrithm.But when i just got bytes from image(which I get from the imageReader.onImageAccessable),FPS become lower than camera api1 under the same resolution.

This sample has been migrated to a new location where we can accept Pull Requests (check README for more information).
As recommended by GitHub, we are closing all issues and pull requests now that this older repo will be archived.
If you still see this issue in the updated repo, please reopen the issue/PR there. Thank you!


HDDS-6806. EC: Implement the EC Reconstruction coordinator.

What changes were proposed in this pull request?
This patch implements the EC REconstruction coordinator functionality. With this patch, DN would be capable of reconstructing given missing indexes to given targets.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-6806
How was this patch tested?
Added tests.

Hi Uma, by reading through the main flow, I think the implementation is good, I'll go through the details later, Thanks~

HI @guihecheng thanks a lot for review and questions. 1 : Yes, for now we just treat everything as same. Local or remote. We can do local optimizations later. 2 : I think we can do that separately. Cleanup is not gauranteed always. So, we need some leasing kind of mechanism for avoiding collisions with new one. We can implement DN self cleaning after some long timeout. 3 : Yes, we will do that. In the initial cut, for stability purposes, we can just do sequential. When we do parallel, we need to consider other factors like CPU etc. May be we should do with small thread pool size. But I feel we will investigate that in next patches. The main goal here is get the initial working version.

Thanks for the replies, I agrees with the points.

LGTM+1

Thanks @umamaheswararao for updating the patch.  There are two minor items left, but otherwise LGTM.

Thanks @adoroszlai for taking a look. I have just corrected them. Thanks

I forgot to add @guihecheng as co-author in the commit message, sorry about that.


Multiple header

It doesn't support multiple header row.

I am trying to create a table with 2 fixed headers. The column widths in the top row are different to the lower ( 2nd header) row. Does the plugin support that ?

@Andykum The plugin does not support that. The code iterates over each TD/TH to match width/style.

Thank you.
----Original message----
From<EMAIL_ADDRESS>Date : 04/08/2016 - 16:12 (BST)
To<EMAIL_ADDRESS>Cc<EMAIL_ADDRESS><EMAIL_ADDRESS>Subject : Re: [meetselva/fixed-table-rows-cols] Multiple header (#8)
@Andykum The plugin does not support that. The code iterates over each TD/TH to match width/style.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/meetselva/fixed-table-rows-cols","title":"meetselva/fixed-table-rows-cols","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/modules/aws/aws-bg.jpg","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/meetselva/fixed-table-rows-cols"}},"updates":{"snippets":[{"icon":"PERSON","message":"@meetselva in #8: @Andykum The plugin does not support that. The code iterates over each TD/TH to match width/style.  "}],"action":{"name":"View Issue","url":"https://github.com/meetselva/fixed-table-rows-cols/issues/8#issuecomment-237583946"}}}


only local extensions are synced in wsl2

🐛 Describe the bug
extensions are not all synced in wsl2, does any body meet this?
below picture  shows the extensions i installed,but turn to github, i find that only local extensions
are synced..

https://gist.github.com/lubocheng/ea4f9b1dcabd5e60edea334aeb9984c3/revisions
from this link of config revisions we can see that, remote extensions are missing..

🌴 Visual Studio Code Version : [ v1.44.0]
🌴 Code Settings Sync Version : [ v3.4.3]
🌴 Standard or Insiders : [ Standard ]
🌴 Portable or Installed : [ Installed ]
🌴 OSS or Official Build : [ Official Build]
🌴 Operating System : [ Win10 2004]
🌴 Occurs On: [Upload]
🌴 Proxy Enabled: [ No ]
🌴 Gist Id: [ ea4f9b1dcabd5e60edea334aeb9984c3]
💪 Expected behavior
sync all extensions correctly

may be i could close this..
it's strange that when i update vs code to version that support wsl2,my extensions are split to local and
remote, which cause sync unexpectedly
i could reinstall extensions to fix it

This is still a valid issue. The extensions in the "wsl:ubuntu" are not synced to the gist. In fact, they are removed since they are no longer in the "local"


Cannot commit a change to a certain model

Code sample or context
It may not be an IXMP issue, in which case please let me know where to move this.
I was trying to add or remove time series from a specific model (REMIND) through IXMP API. from/to NGFS-internal DB.
mp = ixmp.Platform(name='ngfs-internal')
mm = 'REMIND-MAgPIE 1.7-3.0'
ss = 'CD-LINKS_NPi'
vv = 'Diagnostics|Investment|Energy Supply|Electricity|Transmission and Distribution'

scen = ixmp.Scenario(mp, mm, ss)
df = scen.timeseries(variable=vv)
scen.check_out()
scen.remove_timeseries(df)
scen.commit('Test: Remove an REMIND investment variable')

Expected result
I expect it just removes the df and commits to the scenario. I do the same for other models on the DB (GCAM & MESSAGE) without any problems.
Problem description
I get the following error:
RuntimeError                              Traceback (most recent call last)
<ipython-input-252-9dba29eb9447> in <module>
     18                 print('Remove variable: ' + vv)
     19                 scen.remove_timeseries(df)
---> 20             scen.commit('Remove an investment variable')
     21 #         data.to_csv('REMIND_'+ss+'.csv')
     22

h:\mydocuments\message\ixmp\ixmp\core.py in commit(self, comment)
    478         return False
    479
--> 480     def check_out(self, timeseries_only=False):
    481         """Check out the TimeSeries.
    482

h:\mydocuments\message\ixmp\ixmp\core.py in _backend(self, method, *args, **kwargs)
    442         # Set attributes
    443         self.model = model
--> 444         self.scenario = scenario
    445
    446         # Store a weak reference to the Platform object. This reference is not

h:\mydocuments\message\ixmp\ixmp\backend\base.py in __call__(self, obj, method, *args, **kwargs)
     20         for the method name, e.g. 'ts_{method}'.
     21         """
---> 22         return getattr(self, method)(obj, *args, **kwargs)
     23
     24     def close_db(self):

h:\mydocuments\message\ixmp\ixmp\backend\jdbc.py in commit(self, ts, comment)
    511             # Load a TimeSeries of specific version
    512             args.append(ts.version)
--> 513
    514         # either getTimeSeries or getScenario
    515         method = getattr(self.jobj, 'get' + ts.__class__.__name__)

h:\mydocuments\message\ixmp\ixmp\backend\jdbc.py in _raise_jexception(exc, msg)
    120             properties[match.group(1)] = match.group(2)
    121     return properties
--> 122
    123
    124 def _raise_jexception(exc, msg='unhandled Java exception: '):

RuntimeError: unhandled Java exception: There was a problem writing data to the IXMP database - no changes were saved!
Cannot write change log!

Versions
Output of ixmp show-versions
C:\ProgramData\Anaconda3\lib\site-packages\statsmodels\tools\_testing.py:19: FutureWarning: pandas.util.testing is deprecated. Use the functions in the public API at pandas.testing instead.
  import pandas.util.testing as tm

ixmp:        2.0.0.post.dev328
     8c247a5 (HEAD -> origin/master, origin/master, origin/HEAD) Merge pull request #298 from iiasa/jdbc-memory-mgmt
message_ix:  2.0.0
     adcf0e7 (HEAD -> hackathon-reporting) Fix the bug in the previous commit
message_data: installed
     0fb9acd (HEAD -> add_generic_baseline_and_runscripts, Jihoon/fertilizer) Merge remote-tracking branch 'Jihoon/add_generic_baseline_and_runscripts' into add_generic_baseline_and_runscripts

click:       7.0
dask:        2.14.0
graphviz:    0.12
jpype:       0.7.0
pandas:      1.0.3
pint:        0.11
xarray:      0.15.1
xlrd:        1.2.0
xlsxwriter:  1.2.7
yaml:        5.2

iam_units:   installed
jupyter:     installed
matplotlib:  3.0.2
plotnine:    None
pyam:        0.2.0+16.gdd7ae0c

python:      3.7.4 (default, Aug  9 2019, 18:34:13) [MSC v.1915 64 bit (AMD64)]
python-bits: 64
OS:          Windows
OS-release:  10
machine:     AMD64
processor:   Intel64 Family 6 Model 94 Stepping 3, GenuineIntel
byteorder:   little
LC_ALL:      None
LANG:        None
LOCALE:      None.None

I find the same code runs fine with vv = 'Diagnostics|Investment|Energy Supply|Electricity|Transmission and Distribution'.

running with debug log level:
java.sql.BatchUpdateException: ORA-12899: value too large for column "IXMP_NGFS_INTERNAL"."CHANGE_LOG"."ITEM" (actual: 261, maximum: 256)

so this means the variable name is just too long?

so this means the variable name is just too long?

That was one of my suspicions, but even longer names for MESSAGE didn't cause problems..

No, it was bug in ixmp java code. Strange that it was not detected earlier. There was wrong value written instead of timeseries variable name - a combination of variable, region, unit etc

One more PR https://github.com/iiasa/ixmp_source/pull/304

PR was merged. Could you please install ixmp from master, test and close the issue?


clicking view on campaign edit without prefix, causes redirect loop

if an editor navigates from the backend directly to a node/edit link, when clicking view on the node they are taken to the global english url and in a redirect loop.
this happens when you have a translation, are using torguard, and you are and editor of that county with user language set to match
when I clicked view from /node/2259/edit/pt-br I get taken to the english url with a redirect loop

cant reproduce locally, ill try again on Thor

on thor I got this one

@deadlybutter right, do it on a node that has a translation in the language you're looking at

made the global translation for it
went to https://thor.dosomething.org/node/843/edit
clicked view
got brought too https://thor.dosomething.org/campaigns/pregnancy-text-gl

@deadlybutter I was seeing it for BR admins/translations, not sure why/how it would be specific to them

I was doing it as a US editor, I can try doing it as a BR admin as well

went to http://dev.dosomething.org:8888/br/node/1485/edit/pt-br as BR admin, clicked view, worked fine
this is so weird

I created MX translation on space jam

and new MX editor with correct lang

I set my mod header to MX
I went to space jam with the following link as new MX admin http://dev.dosomething.org:8888/mx/node/1631
clicked the edit button, worked fine
i can try on thor + torguard once the login issue is resolved over there

just did the exact same this time, but used Torgaurd and Treat Yo Friends.
No redirect loop, no error.
Here is the URL I went too: https://thor.dosomething.org/mx/node/5646
Here is the URL I got brought to by clicking edit: https://thor.dosomething.org/mx/node/5646/edit/es-mx
Here is the User: https://thor.dosomething.org/mx/user/2632038/edit

@deadlybutter the error is when you go from the edit page to view page

yeah im a doof

so i was right yesterday, this is the line of code causing the bug
https://github.com/DoSomething/phoenix/blob/dev/lib/modules/dosomething/dosomething_global/dosomething_global.module#L610
the problem is that this is technically intentional functionality now. I can change the permission so it only applies to US admins & editors maybe?

maybe an easier solution would be to edit those view links in the content search to have the county code pre-appeneded?
so you always go to /mx/node/231/edit/es-mx


Quick Commit should use -am

Hi,
So an issue with the quick commit that almost makes it useless is that I have to go into the terminal and do a git add . before I use the git quick commit function in sublime.  If you change it from just using -m to -am it will work perfectly by adding the files then committing them :)
Many thanks,
CJ

there is now an "add all files" option at the top of the add list. is this issue ok to close now?

@sheldon this works great, thank you :)


Test gitian build: Windows OS (v3.1.0-rc7.2)

PreRelease v3.1.00-rc7.2:

Downloads Installer/Setup for Windows:

Downloads binaries for Windows:

Logs (Windows)
build.log, install.log
Gitian signatures

@gitianuser   3.1.00-rc7.2-win-unsigned

Community is not active, I dont use windows binaries and with that issue closed. If somebody tests and has any issues, feel free to reopne or create new issue.


Uncaught TypeError: Cannot read property 'config' of undefined

[Enter steps to reproduce:]

...
...

Atom: 1.42.0 x64
Electron: 4.2.7
OS: Mac OS X 10.15.1
Thrown From: remote-ftp package 2.2.3
Stack Trace
Uncaught TypeError: Cannot read property 'config' of undefined
At /Users/otaki/.atom/packages/remote-ftp/lib/client.js:264

TypeError: Cannot read property 'config' of undefined
    at /packages/remote-ftp/lib/client.js:264:23
    at /packages/remote-ftp/lib/client.js:270:18
    at FSReqWrap.readFileAfterClose [as oncomplete] (internal/fs/read_file_context.js:53:3)

Commands
  2x -9:33.5.0 core:close (input.hidden-input)
     -7:30.3.0 settings-view:open (input.hidden-input)
     -3:49.3.0 remote-ftp:navigate-to (div.package-detail)
  6x -3:45.8.0 core:cancel (div.package-detail)
     -0:44 remote-ftp:connect (div.package-readme.native-key-bindings)
  4x -0:40.3.0 remote-ftp:toggle (div.package-detail)
     -0:20 remote-ftp:connect (div.package-readme.native-key-bindings)

Non-Core Packages
autocomplete-latex-cite 0.3.5
autocomplete-paths 2.12.2
japanese-menu 1.15.0
language-fortran 2.1.9
language-latex 1.2.0
latex 0.50.2
latexer 0.3.0
markdown-preview-plus 3.11.5
minimap 4.29.9
minimap-autohide 0.10.1
pdf-view 0.72.0
pigments 0.40.2
remote-ftp 2.2.3
split-diff 1.6.1
Sublime-Style-Column-Selection 1.7.5

I published new released. Theoretically solves the problem.

Thank you for your prompt response.


Toolbar: Define AOI for cuts

Define regions of interest to cut and export

Allow one to draw a bounding box for selecting the region to cut
Allow one to adjust the cut box by redrawing
Add a “Create Geopackage” button to execute the cut defined

!story G1.3
!component Client UI

Added two new toolbars over the maps, and moved the 'Manage Layer' dropdown to the Tile Map toolbar.  Also added a place holder for an 'Auto-refresh map' toggle to the 'Tools' dropdown on the Tile Map toolbar.


Add people to gci15 website

To add a mentor or student profile to the gci15 website of FOSSASIA one has to make a commit. We can make this commit from the companion app.

Give users a form to add name, credentials and bio.
Add some method to give the photo. Drag and drop would be best.
make the commit.

For the moment you can hardcode the repository path. onese #2 is fixed we can allow the users to give it.
Once #3 is fixed we can actually make the PR from the app.

I'd like to work on this one !

But I think I'll wait till #2 and #3 are done. Cause you'll be changing the file structure too I guess. I could help you with that too, if you'd like.

You don't have to wait for #2 #3 and I am much more eager to get this done than changing the file structure :)

@anshuman73 Let me know if you still want to work on this. Its totally fine if you don't want to do this at the moment. Please comment here, so someone else can pick this up.

well, I'm still facing troubles in even installing electron on my windows. I think I'll release this work, so that I don't stop the important workflow. I'll start contributing again as soon as I can. Sorry. I hope you understand :(

@anshuman73 of course. no problem what so ever. thanks for letting us know.


fix(form): update horizontal margin between action buttons

fixes https://github.com/patternfly/patternfly-next/issues/1364

Deploy preview for pf-next ready!
Built with commit 3ee06c0bf31d89ed44a2bb71dc2d04eda14bd17a
https://deploy-preview-1365--pf-next.netlify.com

LGTM 👍

:tada: This PR is included in version 1.0.179 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Update CLI extensions available doc

Update CLI extensions available doc.
Triggered by Azure/azure-cli-extensions - TRAVIS_BUILD_ID=581379908
https://github.com/Azure/azure-cli-extensions/commit/6e528e957246e84ace97cea1a870e6e172474fa5

Docs Build status updates of commit d01c95f:
:clock10: Full build: the average full build time is 6 min(s) 42 sec(s), this is based on the last 186 build(s) for this repository.

Docs Build status updates of commit d01c95f:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs-ref-conceptual/azure-cli-extensions-list.md
:white_check_mark:Succeeded
View (azure-cli-latest) View (azure-cli-2017-03-09-profile) View (azure-cli-2018-03-01-hybrid)

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


multi: update to protogen package and signal support for optional types

This PR:

removes the use of the deprecated "google.golang.org/protobuf/compiler/protogen" package and instead uses "github.com/golang/protobuf/protoc-gen-go/generator"
signals support of proto2 optional types
Add AdditionalImports & derive the additional imports. This can replace the need for ManualImports. We, however, leave ManualImports for backwards compatibility.
update's the falafel version

(i'll open an LND PR to point to this)

hmm ok something wrong with the _generated.go files... Will fix and ping once fixed

Thanks @guggero 🙏  updated.
The LND PR's RPC & mobile comp test now passes 🚀


fix PROXY protocol support for IPv6

I'm trying to deploy dual stack to darwin.network. I ran into some compatibility issues with stunnel4. Specifically, stunnel4's method of doing dual stack is to listen on :: (i.e., all IPv6 addresses); the Linux default is that this also listens on all IPv4 addresses, then uses the v6 mapping scheme to represent v4 clients as having v6 addresses. This broke PROXY handling for two reasons, both of which are fixed here:

Handle PROXY lines with IPv6 addresses starting with :: (similar to WEBIRC in issue #211)
Strip v6 mapping from v4 addresses (i.e., turn ::ffff:<IP_ADDRESS> back into <IP_ADDRESS>) when handling proxied IPs.

Noice, thanks for the changes!


[Discussion] Desired features

This looks like a great start and has good features for basic binary extensions, but when I opened cli/cli#4264 I was hoping to see more low-level implementations either ported or refactored out into a shared library both the CLI and binary extension developers could use. For example,

[x] Support for -R command line switch, or at least the APIs to make adding one work. I do see that environment variables that gh uses are parsed, but it would be great to provide the same command line switches (even if you don't force a dependency on Cobra Command).
[x] Expose some of the formatting like the templating APIs already there and ones I've helped improve. Binary extensions could just shell out to gh but this seems otherwise unnecessary if more of the formatting code was expose from cli/cli/pkg.

As a specific example, it seems there's no way to specify the repo org and name to commands, nor get these from environment variables like $GH_REPO. Ideally, extensions can be used in the same contexts as CLI commands by either supplying their own -R values (parsing could be an extension problem, but being able to pass these values should be supported here) or getting it from $GH_REPO or any other related environment variables you support.

@heaths Thanks for writing in, looks like I prematurely closed out cli/cli#4264 and I will reopen it. I think both issues are relevant to keep open. This one can be targeted at what features/code we want to extract from the cli code base and move to go-gh and cli/cli#4264 can be targeted at general extracting of modules from the cli code base into their own repositories. For example I think that output formatting code you referenced could easily be generalized and extracted into its own go module but it doesn't need to be tied to go-gh and could just be used in tandem with it.
Regarding the -R command line switch, my position on it is that go-gh should not bundle in large dependencies like Cobra and that parsing of command line arguments and flags should be left up to the extension author. There are many options it to do that and I think go-gh should not prescribe or require a specific approach. How I envision this working is that the extension will parse the command line args and if -R is not specified then the gh.CurrentRepository() function can be used to determine the repository context for the command. It does look like we are missing support for the GH_REPO environment variable in gh.CurrentRepository() though so that is something we should probably add. Does that address your concerns?

I agree go-gh shouldn't depend on Cobra, but what about providing a function to parse [domain/]org/repo into a gh/Repository so there's at least consistent parsing across binary extensions? However extensions want to support and parse -R (or whatever) would be completely up to them, but at least end users can get a consistent experience. This would also apply for parsing env vars like $GH_REPO which can use the same format.

Great idea, I added the task to https://github.com/cli/go-gh/issues/8 since it has a lot of overlap.

@samcoe thanks for adding repository support - both getting the current or parsing a [host/]owner/repo string. As for the other ask, any problem with a PR (after gh label clone) exposing a few things (perhaps with some abstractions) like the table printer and related functions for truncating, coloring, etc?

@heaths Rather than adding that functionality to go-gh what are your thoughts on extracting the table printer and related functions into their own repo, and go package, that can be imported by gh, go gh extensions, along with other go projects? They seem are already fairly self contained and could provide more value to the larger go community that way. Something like go-term-table-printer?

I like that idea, a package that is a collection of terminal utilities that are useful and can be used together or stand alone. I would like to see a proposal of exactly what packages we would want to extract from gh and what it would look like. Right now, in gh many of the packages are not designed to be used outside of gh. Many have complex dependency trees and others have interfaces that were not designed to be exposed as public packages.

Similarly, what about extracting your very nice HTTP mocking functionality? Though, perhaps that makes more sense in this module because that does seem inextricably tied to your HTTP abstractions. After using it for several PRs to the CLI now, I love it!

As for a cli/go-terminal (or whatever), here's a few things that would be nice:

TablePrinter
Pluralize and FuzzyAgo (and friends) from utils
Terminal functions from utils
ColorScheme, which has functions useful for TablePrinter
iostreams, which also facilitates a lot of functionality and testing. Though, quite a bit is specific to cli/cli so I wonder if it could be simplified without a ton of work in cli/cli. Is the goal for cli/cli to also use this hypothetical cli/go-terminal? Seems less maintenance long-term.

Maybe it's outside the realm of something terminal-focused - perhaps not - but you also have a lot of great Cobra Command extensions like the one I ended up copying here: https://github.com/heaths/gh-projects/blob/fad0aedddce5a5f1a49616fb694fc8c230cdd9d2/internal/cmd/flags.go

@heaths Appreciate the proposal. Just wanted to circle back and let you know that this work made it into our roadmap https://github.com/orgs/cli/projects/3/views/1 and it is being tracked in https://github.com/cli/cli/issues/5544. Also, that @mislav will be the one picking up this work.

FWIW, I've been cribbing / rewriting some of the table printing functionality and would love to help out with this work (and then use it) if possible. /cc @mislav

Kind of hard to parse through this thread but I believe we have added or decided not to add everything that was mentioned here. Going to close this out for now. I think anything that is left over can get its own dedicated issue for easier tracking.


Any date on releasing the training script for the model?

this is amazing work! I'm working in the same direction but on a smaller level.
Are you planning to release any paper or a training script? If not, can you just explain how did you train the model. I know some overview is given on the HF model page but I want to know the steps in doing so of how that was achieved.
Thanks in advance :)

I updated the HuggingFace repo with code on how to train the model - https://huggingface.co/vectara/hallucination_evaluation_model.

Training is as simple as training a binary classifier on a large set of labelled data. The dataset includes a source document, and a summary (usually generated by an LLM but some human curated ones also). And then labels from human raters or (only for training data only but not for eval) from synthetic sources such as other large models. Note if you call an LLM for getting training data you may violate their terms of service. Look up the SummaC and True datasets for the training data on factual consistency (we used these amongst others, and their test datasets as evaluation). The training regime is explained well here - https://arxiv.org/pdf/2204.04991.pdf


Update check-broken-links.sh

Signed-off-by: tpmccallum<EMAIL_ADDRESS>Tests are failing on URL that is actually resolving.

Closing this and instead updating the URL to what seems to be the current URL for this endpoint.
See: https://github.com/fermyon/developer/pull/809


Lowercase emails during IS lookup calls

Cloned from https://github.com/vector-im/riot-web/issues/10754
As described in MSC2265, we should lowercase emails as part of lookup requests to avoid confusion because of casing.
This is particularly important for the new hashing based lookup style, since the IS can't see the plaintext version to adjust the case.

Already done by bmarty in sdk f507dd56afaca15165882ce068bb9e0d845b135b


[GPoS] Align ErasValidatorPref with Polkadot

Now pref is used to calculate the total value of guarantors, which is not align with polkdot.

If we do this, subscan won't change anymore.

Remove from M2

Don't do it in chain. Need to change subscan and app.

Don't do it in chain. Need to change subscan and app.

So we close it.


Update Hub Cloudformation Template to support Disabling External Principals for Resource Share

Currently when a Resource Share is created for the Transit Gateway it is configured with the Default Configuration of AllowExternalPrincipals: True
This can be a security issue and a good enhancement (which we have done ourselves by amending the Cfn) is to allow users to disable External principals by a parameter in the Hub Cloudformation and then using a condition set the AllowExternalPrincipals to false so that only AWS accounts within an Organisation can be shared access to the Transit Gateway
An example configuration to support this (I set No for default for our needs but for public generic requirements yes may still be OK)
Add to Parameters:
    "AllowExternalPrincipals": {
        "Type": "String",
        "AllowedValues": [
            "Yes",
            "No"
        ],
        "Default": "No"
    },

Add to Conditions:
"NoExternalPrincipals": {
"Fn::Equals": [
{
"Ref": "AllowExternalPrincipals"
},
"No"
]
},
Add Property to TGW Resource Share:
"AllowExternalPrincipals": {
"Fn::If": [
"NoExternalPrincipals",false,true ]
},

Thanks for opening the issue. We have added this to our back log items and will look into this with next release.

We will ship this feature request in the next release.


Log Variables

Debug logging on logs the query at the moment, it should also log variables.

In 1.3,


Vulnerability roundup 39 (release-17.09)

Scanned nixos/release-combined.nix @ e984f9e. Filtered out previously reported CVEs. May contain false positives.
bazaar-2.7.0 (search, files)

[x] CVE-2017-14176

cyrus-sasl-2.1.26 (search, files)

[x] CVE-2013-4122

jquery-ui-1.11.4 (search, files)

[ ] CVE-2016-7103

libXfixes-5.0.2 (search, files)

[ ] CVE-2016-7944

libjpeg-turbo-1.5.2 (search, files)

[ ] CVE-2017-15232

libmad-0.15.1b (search, files)

[ ] CVE-2018-7263

libtiff-4.0.9 (search, files)

[ ] CVE-2017-17095
[ ] CVE-2018-5784
[ ] CVE-2018-7456
[ ] CVE-2018-8905

net-snmp-5.7.3 (search, files)

[ ] CVE-2014-2285

openjpeg-2.3.0 (search, files)

[ ] CVE-2017-17479
[ ] CVE-2017-17480
[ ] CVE-2018-5727
[ ] CVE-2018-5785
[ ] CVE-2018-6616
[ ] CVE-2018-7648

python-2.7.14 (search, files)

[ ] CVE-2018-1000030

shadow-4.5 (search, files)

[ ] CVE-2018-7169

sharutils-4.15.2 (search, files)

[ ] CVE-2018-1000097

zziplib-0.13.68 (search, files)

[ ] CVE-2018-6869
[ ] CVE-2018-7725
[ ] CVE-2018-7726
[ ] CVE-2018-7727

Cc: @joepie91, @phanimahesh, @the-kenny, @7c6f434c, @k0001, @peterhoeg, @nh2, @LnL7, @grahamc, @adisbladis, @fpletz
Contact @ckauhaus for any questions.

Master is #38993

bazaar (CVE-2017-14176): fad125262b7763969d15a8a076fb6f0ac3f3ca9d

cyrus-sasl (CVE-2013-4122) was already fixed. I've now included the CVE tag in the patch name.

libXfixes (CVE-2016-7944): bca2ee28db44bc2d2d1b5e97866ca4052d88e94f

having a look at libjpeg-turbo

libjpeg-turbo submitted in PR #39406

EOL


[5.3] Fix blade parent keyword escaping

This PR is fix for issue https://github.com/laravel/framework/issues/10068 and it's trying to properly handle @parent keywords in Blade sections and ensure proper section extending. The solution is hardly based on previously reverted commit https://github.com/laravel/framework/pull/10122 with a few tweaks.
TODO list:

[x] Fix original issue https://github.com/laravel/framework/issues/10068.
[x] Add test to ensure @parent keyword is properly handled.
[x] Edit test for multiple section extending to ensure we will not introduce bugs like https://github.com/laravel/framework/issues/10156.
[x] Fix @append behaviour to properly handle parent marks.
[x] Add tests for section appending.
[x] Add tests for section overwriting.
[x] Confirmation from @abhimanyusharma003 @parent keyword is properly escaped.
[ ] Confirmation form @atmediauk this fix is working as expected and has no side effects for him.

Thank you guys. Special thanks to @mspiderv for helping me with figuring out how to fix it and @dmgawel for previous try to fix this issue.

What is the difference between $parentMarks and $parentMarksLast?

Closing pending lack of activity.


[KFNBC]: Migrate OdhDashboardConfig.status into Notebook.

Feature description
We should probably move our existing config logic that is status.notebookControllerState in the DashboardConfig:
export type NotebookControllerUserState = {
  user: string;
  lastSelectedImage: string;
  lastSelectedSize: string;
  lastActivity: number;
};

To annotations on the Notebook resource:
 export type Notebook = K8sResourceCommon & {
+  metadata: {
+    annotations: Partial<{
       ...
+      'notebooks.kubeflow.org/last-activity': string; // datestamp of last use
+      'notebooks.opendatahub.io/last-image-selection': string; // the last image they selected
+      'notebooks.opendatahub.io/last-size-selection': string; // the last notebook size they selected
+      'opendatahub.io/username': string; // the untranslated username behind the notebook
+    }>;
+  };
   spec: {

notebooks.kubeflow.org/last-activity is a pre-existing annotation that I think can double down as the last usage on the Notebook Controller Admin list.
Describe alternatives you've considered
We could move it to another config -- but I do not see that being much better. Notebooks and what they do with them is definitely a good spot to store this info.
Only concern I can think of is, if we want user-specific storage of this information. Multiple Notebooks could make it hard to tell "which is right" if the data is present does not align on multiple Notebooks.
Maybe a config for each user? Because users will be able to eventually manage their own namespaces 🤔
Anything else?
Coding effort...
The effort behind this will be non-trival. We were using a global source of users & their desired data, and we will be moving to individual storage of data. So this is not likely to be a smooth architectural change from my first passes over what we would need to do.
Likely we'll need a new state / manager for the NotebookControllerContext to keep up with impersonating a user and the current logged in user. Might make things interesting.

@cfchase @samuelvl Any concerns with us adding the following annotations (with this work) to the Notebooks?

'notebooks.opendatahub.io/last-image-selection' -- the last image they selected
'notebooks.opendatahub.io/last-size-selection' -- the last notebook size they selected
'opendatahub.io/username' -- the untranslated username behind the notebook; this is due to us mangling the username to make it kube friendly in labels & the resource name... we'll need some way to track what the original one was so we can present it back to the user -- at least on the Admin table in KFNBC (only place I can think of off the top of my head)

This effort is on hold I think for now until we figure out the architectural structure behind this. I started a thread in the Open Data Hub Slack to try and work out the particulars and edge cases.

Verdict from Slack.

Use notebooks to store all the data, no other config map needed -- we should have no status in the ODH Dashboard Config when we are done
Attempt to use existing data inside the Notebook. If we can't cleanly pull that information out for previous selections for size and image, then we should look to using annotations (the ones listed in a previous comment / description are fine)
For #303 -- live tracking of data, we'll just focus on local storage to store that while they are actively on the page. We can clear the local storage when we post the notebook update. We should probably make a hook for this so we don't need to worry where the source of data comes from -- Logic something like: <take from notebook> || <take from localStorage> || <use defaults> -- and don't use localStorage for Admin impersonations as they obv want targeted user's selections and not theirs

After talking with Chris, this really can't wait. the more uses that try to update the config the more likely we hit a patching issue and it goes awry. Going to need to move to Notebooks as much as we can for ODH 2.1 (RHODS 1.16)

Won't actually change the CRD -- just will stop using it for now.


Possible Emulator Bug?

While working on PR-5870, I think I stumbled across a possible Emulator bug. See the following snippet of SLEIGH:
        # A 176
	# op1 153

	#                  (176 & 15) + (153 & 15) + 1 = 10
	local tmp:4 = zext((A & 0x0F) + (op1 & 0x0F) + $(C_FLAG)); # 10 verified

	local add_tmp_6 = (tmp > 0x09); # verified add_tmp_6 is 1

	tmp = tmp + zext(add_tmp_6 * 0x6); # should be 16
	X = zext(add_tmp_6 * 0x6);
	Y = tmp:1; # Y is 24!!!! Should be 16

Everything is sane until I get to the tmp = tmp + zext(add_tmp_6 * 0x6) line. I have verified the values along the way and at this point add_tmp_6 = 1, and tmp = 10. This means tmp = tmp + zext(add_tmp_6 * 0x6) should be tmp = 10 + zext(1 * 0x6) which is tmp = 10 + 6 or tmp = 16. However I am getting tmp to be 24.
I am using the patch from https://github.com/NationalSecurityAgency/ghidra/pull/5262 on Ghidra 11.0.2. Thanks in advance.
@ryanmkurtz  @GhidorahRex

I'm not certain about what bug might be occurring, but I did find a minor issue with your sleigh.
You should have add_tmp_6 be size 4. Otherwise the multiplication in add_tmp_6 * 0x6 can overflow a size 1 variable. I would do either:
local add_tmp_6:4 = zext(tmp > 0x09);
tmp = tmp + (add_tmp_6 * 0x6);

or
local add_tmp_6 = (tmp > 0x09);
tmp = tmp + zext(add_tmp_6) * 0x6;

Thank you for the fast response. I made the requested changes. As predicted it did not affect my issue. I believe I have additional information to add:
	tmp = tmp + (add_tmp_6 * 6); # should be 16
	Y = tmp:1;

is incorrect with Y being 26 (I swear it was 24 yesterday....). This however is correct:
	local tmp2:4 = tmp + (add_tmp_6 * 6); # should be 16
	Y = tmp2:1;

with Y being 16 as expected.
So likely an issue with storing back to itself? Thanks again.

6502.zip
I am attaching a 6502 slaspec and sla that repro the issue. It is in the macro for adc on line 98.

The issue happens to be fixed in our development branch (wishful thinking, I suspect.)

This is Ghidra 11.0.2, I will test in Ghidra 11.0.3.

The sleigh compiler is emitting different code than I got here. This could be a difference in version, or a discrepancy between the Java and C++ versions of the Sleigh compiler. Which are you using?

I am using the C++ version of the Sleigh compiler on Ghidra 11.0.2.

The C++ emulator is interpreting the p-code incorrectly. Given context from your original post, I assume this is what you using? Is this also the one you used to verify your values?

I am using the C++ emulator.

11.0.3 has the same behavior as 11.0.2. The compiled .sla files are identical (built with /support/sleigh from both 11.0.2 and 11.03). I also rebuilt libsla.a and recompiled my verifier program.

Here's the Pcode for ADC in 11.0.3:

f63e 61 e4           ADC        (0xe4,X)
$U8180:1 = INT_ADD 0xe4:1, X
$U8280:1 = INT_ADD $U8180:1, 1:1
$U8380:2 = INT_ZEXT $U8180:1
$U8480:2 = INT_ZEXT $U8280:1
$U8500:1 = LOAD RAM($U8480:2)
$U8580:2 = INT_ZEXT $U8500:1
$U8600:2 = INT_LEFT $U8580:2, 8:4
$U8680:1 = LOAD RAM($U8380:2)
$U8700:2 = INT_ZEXT $U8680:1
$U8800:2 = INT_OR $U8600:2, $U8700:2
$U3280:1 = INT_RIGHT P, 3:4
$U3300:1 = INT_AND $U3280:1, 1:1
$U3380:1 = INT_EQUAL $U3300:1, 0:1
CBRANCH <0>, $U3380:1
$U3400:1 = INT_AND A, 15:1
$U8880:1 = LOAD RAM($U8800:2)
$U3480:1 = INT_AND $U8880:1, 15:1
$U3500:1 = INT_ADD $U3400:1, $U3480:1
$U3580:1 = INT_AND P, 1:1
$U3600:1 = INT_ADD $U3500:1, $U3580:1
$U3700:4 = INT_ZEXT $U3600:1
$U3800:1 = INT_LESS 9:4, $U3700:4
$U3880:1 = INT_MULT $U3800:1, 6:1
$U3900:4 = INT_ZEXT $U3880:1
$U3700:4 = INT_ADD $U3700:4, $U3900:4
X = INT_MULT $U3800:1, 6:1
Y = SUBPIECE $U3700:4, 0:4
BRANCH <1>
<0>
$U3b80:2 = INT_ZEXT A
test.zip

I'm also attaching a test.bin I made.

I'm fumbling my way through the Emulator. But it looks like Y is being set correctly to 0x10:

So the issue is in the C++ emulator?

I'm unable to reproduce the issue in the C++ emulator.  If I emulate the following instructions using the provided 6502.slaspec
        f634 a2 00           LDX          #0x0
        f636 a9 99           LDA          #0x99
        f638 81 e4           STA          (0xe4,X)
        f63a a9 b0           LDA          #0xb0
        f63c f8              SED
        f63d 38              SEC
        f63e 61 e4           ADC          (0xe4,X)
        f640 60              RTS

It executes the following p-code for the ADC macro:
(unique,0x3400,1) = INT_AND (register,0x0,1) (const,0xf,1)             # 0 = 176 & 15
(unique,0x8880,1) = LOAD (const,0x5555556831f0,8) (unique,0x8800,2)    # 153 = load
(unique,0x3480,1) = INT_AND (unique,0x8880,1) (const,0xf,1)            # 9 = 153 & 15
(unique,0x3500,1) = INT_ADD (unique,0x3400,1) (unique,0x3480,1)        # 9 = 0 + 9
(unique,0x3580,1) = INT_AND (register,0x3,1) (const,0x1,1)             # 1 = 137 & 1
(unique,0x3600,1) = INT_ADD (unique,0x3500,1) (unique,0x3580,1)        # 10 = 9 + 1
(unique,0x3700,4) = INT_ZEXT (unique,0x3600,1)                         # 10 = zext(10)
(unique,0x3800,1) = INT_LESS (const,0x9,4) (unique,0x3700,4)           # 1 = 9 < 10
(unique,0x3880,1) = INT_MULT (unique,0x3800,1) (const,0x6,1)           # 6 = 1 * 6
(unique,0x3900,4) = INT_ZEXT (unique,0x3880,1)                         # 6 = zext(6)
(unique,0x3700,4) = INT_ADD (unique,0x3700,4) (unique,0x3900,4)        # 16 = 10 + 6
(register,0x1,1) = INT_MULT (unique,0x3800,1) (const,0x6,1)            # 6 = 1 * 6
(register,0x2,1) = SUBPIECE (unique,0x3700,4) (const,0x0,4)            # 16 = subpiece(16,0)

all of which seems correct and puts the value of 16 in Y as expected.

@caheckman, thank you for the fast response. How are you testing? I would like to replicate your testing setup. Currently I am seeing the issue using my Verifier tool (https://github.com/oberoisecurity/ghidra-processor-module-verifier).
Does your .slaspec compile to an identical version of my .sla? Here is the exact state I am using:
./verifier -p PC -t 1 --max-failures 1 --register-map map.txt -s ~/ghidra-6502-fixes/Ghidra/Processors/6502/data/languages/6502.sla -j ~/ProcessorTests/6502/v1/61.json --start-test 16
Ghidra Processor Module Verifier (Verifier)
[*] Settings:
	[*] Compiled SLA file: /home/poberoi/ghidra-6502-fixes/Ghidra/Processors/6502/data/languages/6502.sla
	[*] JSON Test file: /home/poberoi/ProcessorTests/6502/v1/61.json
	[*] Program counter register: PC
	[*] Word size: 2
	[*] Register Mapping Count: 6
	[*] Max allowed failures: 1
	[*] Start test: 16
	[*] Register Mapping Count: 6
[*] /home/poberoi/ProcessorTests/6502/v1/61.json: Loaded 10000 test cases
[*] Test Range: 16-10000
!! REGISTER ERROR: X 8 6
!! REGISTER ERROR: Y 24 26
[-] 16) FAIL
Initial State:
	Registers:
		A: 176
		P: 105
		PC: 63038
		S: 217
		X: 8
		Y: 24
	RAM:
		228: 98
		236: 96
		237: 87
		22368: 153
		63038: 97
		63039: 228
		63040: 9

Final (Expected) State:
	Registers:
		A: 176
		P: 105
		PC: 63040
		S: 217
		X: 8
		Y: 24
	RAM:
		228: 98
		236: 96
		237: 87
		22368: 153
		63038: 97
		63039: 228
		63040: 9

Emulator:
	Registers:
		A: 176
		P: 105
		PC: 63040
		S: 217
		X: 6
		Y: 26
	RAM:
		228: 98
		236: 96
		237: 87
		22368: 153
		63038: 97
		63039: 228
		63040: 9

Here's some fun:
setValue: 0x7fd1e80052c0 3700 4 10
getValue: 0x7fd1e80052c0 3800 1 1
getValue: 0x7fd1e8005000 6 1 6
setValue: 0x7fd1e8005530 1 1 6
getValue: 0x7fd1e80052c0 3700 4 1a
getValue: 0x7fd1e8005000 0 4 0
setValue: 0x7fd1e8005530 2 1 1a

I threw in some printfs() in memstate.hh setValue() and getValue(). You see that at 0x3700 I write 4 bytes of 0x10. However a few instructions later when I get it, it's 0x1a (26).

Are you testing on Windows? Would you mind testing on Linux x64? I want to rule out this being platform specific. I'm testing on Linux.

Swapping the shifts seems to have fixed my issue:
  else {
    if (size2 == 0) {
      val1 &= ~(calc_mask(size1)<<skip);
      val1 |= val << skip;
      insert(ind,val1);
    }
    else {
       val1 &= (~((uintb)0)) << 8*size1;
        val1 |= val << skip;
       insert(ind,val1);
        val2 &= (~((uintb)0)) >> 8*size2;
       val2 |= val >> 8*size1;
       insert(ind+wordsize,val2);
    }

That being said I don't understand this code at all to be making changes to it.

@caheckman , checking in. Anything I can do to help you debug this issue? Thanks in advance.

It looks like the memory state objects are misconfigured.  From your sla_emulator.cpp
    MemoryImage loadmemory(trans.getDefaultCodeSpace(), test_params.word_size, 4096, &loader);
    MemoryPageOverlay ramstate(trans.getDefaultCodeSpace(), test_params.word_size, 4096, &loadmemory);
    MemoryHashOverlay registerstate(trans.getSpaceByName("register"), test_params.word_size, 4096, 4096, (MemoryBank *)0);
    MemoryHashOverlay tmpstate(trans.getUniqueSpace(), test_params.word_size, 4096, 4096, (MemoryBank *)0);

The test_params.word_size is being initialized from the address space "wordsize" in the sla file, but word size in the context of MemoryBank objects is unrelated to address space "wordsize" and refers to the internal structure of the memory object.  The MemoryBank word size should be initialized to 8 (regardless of the sleigh language) to match the number of bytes in the uintb typedef.


fix(nodebuilder/tests): Add dummy trusted peers to satisfy fx

Fx requires trusted peers now so this fix is needed in the meantime to satisfy that.
Don't worry, these tests will be THOROUGHLY cleanussied in follow up PRs.

My bad I didn't fix them on the go-header update PR


How to set the imbalance factor for CIFAR100

How can toy set the imbalance factor for CIFAR100?

For CIFAR-100. You can set the imbalance factor by changing the value of imb_factor in demo1_first-stage-training.py line 81. For example, for imbalance factor 100, we set imb_factor to be equal to 1/100=0.01.


rnn optimize fail

Epoch 1/10
2019-12-17 10:30:10.047658: W tensorflow/core/grappler/optimizers/implementation_selector.cc:310] Skipping optimization due to error while loading function libraries: Invalid argument: Functions '__inference___backward_standard_gru_5820_6196_specialized_for_StatefulPartitionedCall_at___inference_distributed_function_6314' and '__inference___backward_standard_gru_5820_6196' both implement 'gru_95095eff-9898-4b33-9f85-d96fe50ea8a6' but their signatures do not match.
what's wrong?

@1096125073,
Kindly provide the code being used to replicate the issue reported, also provide the TF version and complete error trace.Thanks!

@1096125073 ,
Any update on the issue?Thanks!

Automatically closing due to lack of recent activity. Please update the issue when new information becomes available, and we will reopen the issue. Thanks!


Can this support custom ramdisk for ssh access?

it theoretically could, but i don't think I'd implement booting an SSH ramdisk with Inferius. might make a tool to do so, I dunno.


Missing stake information, delete the data folder and re-download the chain

Seeing this too often to be a rare problem, it stops the startup of the daemon. It does not repair itself on second startup either.
[2018-10-08 23:31:36.8139 11] INFO: Stratis.Bitcoin.Utilities.AsyncLoop+<>c__DisplayClass16_0+<<StartAsync>b__0>d.MoveNext Periodic peer flush starting in 300 seconds.
[2018-10-08 23:31:37.0342 1] ERROR: Stratis.Bitcoin.Builder.FullNodeFeatureExecutor.Execute An error occurred: 'Stratis.Bitcoin.Configuration.ConfigurationException: Missing stake information, delete the data folder and re-download the chain
   at Stratis.Bitcoin.Features.Consensus.StakeChainStore.LoadAsync()
   at Stratis.Bitcoin.Features.Consensus.Rules.PosConsensusRuleEngine.Initialize() in D:\a\1\s\src\Stratis.Bitcoin.Features.Consensus\Rules\PosConsensusRuleEngine.cs:line 52
   at Stratis.Bitcoin.Base.BaseFeature.InitializeAsync() in D:\a\1\s\src\Stratis.Bitcoin\Base\BaseFeature.cs:line 203
   at Stratis.Bitcoin.Builder.FullNodeFeatureExecutor.<>c.<Initialize>b__3_1(IFullNodeFeature service) in D:\a\1\s\src\Stratis.Bitcoin\Builder\FullNodeFeatureExecutor.cs:line 52
   at Stratis.Bitcoin.Builder.FullNodeFeatureExecutor.Execute(Action`1 callback, Boolean reverseOrder) in D:\a\1\s\src\Stratis.Bitcoin\Builder\FullNodeFeatureExecutor.cs:line 102'
[2018-10-08 23:31:37.0533 1] ERROR: Stratis.Bitcoin.Builder.FullNodeFeatureExecutor.Execute An error occurred: 'System.ArgumentNullException: Value cannot be null.
Parameter name: block
   at Stratis.Bitcoin.Utilities.Guard.NotNull[T](T value, String parameterName) in D:\a\1\s\src\Stratis.Bitcoin\Utilities\Guard.cs:line 46
   at Stratis.Bitcoin.Base.Deployments.NodeDeployments.GetFlags(ChainedHeader block) in D:\a\1\s\src\Stratis.Bitcoin\Base\Deployments\NodeDeployments.cs:line 28
   at Stratis.Bitcoin.Features.Consensus.ConsensusFeature.InitializeAsync() in D:\a\1\s\src\Stratis.Bitcoin.Features.Consensus\ConsensusFeature.cs:line 59
   at Stratis.Bitcoin.Builder.FullNodeFeatureExecutor.<>c.<Initialize>b__3_1(IFullNodeFeature service) in D:\a\1\s\src\Stratis.Bitcoin\Builder\FullNodeFeatureExecutor.cs:line 52
   at Stratis.Bitcoin.Builder.FullNodeFeatureExecutor.Execute(Action`1 callback, Boolean reverseOrder) in D:\a\1\s\src\Stratis.Bitcoin\Builder\FullNodeFeatureExecutor.cs:line 102'
[2018-10-08 23:31:37.0533 1] INFO: Stratis.Bitcoin.Features.MemoryPool.MempoolManager+<LoadPoolAsync>d__25.MoveNext Loading Memory Pool.

Not sure if this is related to #426 in any way?

I assume you have the latest version of the code.
There was a big change about a month ago that included changes in the db so that requires a delete of the data folder.
Have you tried to delete the folder and this error keeps appearing?

Re-posting my findings here: https://github.com/stratisproject/StratisBitcoinFullNode/issues/2166#issuecomment-428139829

I believe this bug means the stake store and the coin view db are out of sync, mainly because stake store is behind and does not have the blocks it needs to come to the height of coinview.
The solution is to rewind coinview (or find the blocks in block store), the odd thing is this should not happen as we always flush stake store before we flush coin view.
@sondreb if you have any usefull way to reproduce this it will help.
I believe @majikandy also gets this often.

I have code from 7 days ago and have experienced this 4 times.
this can reasonably reliably br recreated by staking (possibly staking on another node) and then killing the Daemon in TaskManager

Ok I know what the bug is, or at least one of the bugs.
This component relays on the tip hash of coinview be present in chain (ConcurrentChain) If a node crashes and chain is not persisted correctly (chain height is lower then coinview tip) we get this bug.
I will try to submit a fix today where we do the same as in ConsensusManager (and rewind coinview so the node can also recover)


Event Listener had an uncaught exception that should already be caught in a try catch.

General Troubleshooting

[x] I have checked for similar issues.
[x] I have updated to the latest JDA version.
[x] I have checked the branches or the maintainers' PRs for upcoming bug fixes.

Bug Report

When sending an Embed build with a StringBuilder as description an Exception is thrown that is already caught in a try/catch.
The embed that is send to the channel works like it should.
Removing the part of actually sending the message works fine. (Embed is build there)
Expected Behavior
The try/catch catches the Exception and now errors are logged to the console.
Code Example or Reproduction Steps
Build an Embed with the StringBuilder from Java.
Code is here.
I already tried putting everything related to the Embed in a try catch but the catch (sysout) never gets called and the exception shows up in the console every time
Code for JDABuilder or DefaultShardManagerBuilder Used
static {
        try {
            //start bot with token
            jda = JDABuilder.createDefault(Config.getConf("token", false))
                    .setActivity(Activity.playing("https://github.com/Lulonaut/Hypixel-VerifyJDA"))
                    .build();
        } catch (LoginException e) {
            System.out.println("The Token is invalid! Please check your config.");
            System.exit(1);
        } catch (Exception e) {
            System.out.println("There was an error while logging in, please try again and check your config!");
            System.exit(1);
        }
    }

Exception or Error
[JDA MainWS-ReadThread] ERROR net.dv8tion.jda.api.JDA - One of the EventListeners had an uncaught exception
java.lang.StringIndexOutOfBoundsException: String index out of range: -1
	at java.lang.String.substring(String.java:1931)
	at de.lulonaut.Bot.commands.MessageLeaderboard.onGuildMessageReceived(MessageLeaderboard.java:23)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at net.dv8tion.jda.api.hooks.ListenerAdapter.onEvent(ListenerAdapter.java:405)
	at net.dv8tion.jda.api.hooks.InterfacedEventManager.handle(InterfacedEventManager.java:96)
	at net.dv8tion.jda.internal.hooks.EventManagerProxy.handleInternally(EventManagerProxy.java:88)
	at net.dv8tion.jda.internal.hooks.EventManagerProxy.handle(EventManagerProxy.java:70)
	at net.dv8tion.jda.internal.JDAImpl.handleEvent(JDAImpl.java:149)
	at net.dv8tion.jda.internal.handle.MessageCreateHandler.handleInternally(MessageCreateHandler.java:97)
	at net.dv8tion.jda.internal.handle.SocketHandler.handle(SocketHandler.java:36)
	at net.dv8tion.jda.internal.requests.WebSocketClient.onDispatch(WebSocketClient.java:952)
	at net.dv8tion.jda.internal.requests.WebSocketClient.onEvent(WebSocketClient.java:839)
	at net.dv8tion.jda.internal.requests.WebSocketClient.handleEvent(WebSocketClient.java:817)
	at net.dv8tion.jda.internal.requests.WebSocketClient.onBinaryMessage(WebSocketClient.java:990)
	at com.neovisionaries.ws.client.ListenerManager.callOnBinaryMessage(ListenerManager.java:385)
	at com.neovisionaries.ws.client.ReadingThread.callOnBinaryMessage(ReadingThread.java:276)
	at com.neovisionaries.ws.client.ReadingThread.handleBinaryFrame(ReadingThread.java:996)
	at com.neovisionaries.ws.client.ReadingThread.handleFrame(ReadingThread.java:755)
	at com.neovisionaries.ws.client.ReadingThread.main(ReadingThread.java:108)
	at com.neovisionaries.ws.client.ReadingThread.runMain(ReadingThread.java:64)
	at com.neovisionaries.ws.client.WebSocketThread.run(WebSocketThread.java:45)

Did you read the stacktrace?
It points to line 23 of your MessageLeaderboard and not the try-catch one
https://github.com/Lulonaut/Hypixel-VerifyJDA/blob/55c3becb9d3628d79f20f29255ad8db89832d705/src/main/java/de/lulonaut/Bot/commands/MessageLeaderboard.java#L23

Did you read the stacktrace?
It points to line 23 of your MessageLeaderboard and not the try-catch one
https://github.com/Lulonaut/Hypixel-VerifyJDA/blob/55c3becb9d3628d79f20f29255ad8db89832d705/src/main/java/de/lulonaut/Bot/commands/MessageLeaderboard.java#L23

Oof, I used to be the one telling people to read the stack trace properly. I actually saw the Line but looking at the code i thought this was the method declaration and not something in the method.

Oof, I used to be the one telling people to read the stack trace properly. I actually saw the Line but looking at the code i thought this was the method declaration and not something in the method.


Country request: Russia

I would like to request Russia  ##be added to your queue, thanks!

Added to the country list, thank you.

@Godnik from geoalert.io has also requested russian road data.

Thanks Ben for adding our request

Russia is now available.
Happy mapping!


Automatically include stylecop.json

For legacy projects and older MSBuild, simply add the item as hidden and it will show up as a None item but still be passed as an AdditionalFiles item
For newer MSBuild, remove stylecop.json from None and add it to AdditionalFiles unless its already been done by the user.
Fixes #2698

I tested with legacy projects with MSBuild 15.0 and MSBuild 4.0 as well as new SDK-style projects and MSBuild 15.0.
If you've already manually moved stylecop.json to AdditionalFiles, it is left alone, otherwise it is removed from None and added to AdditionalFiles.
The logic also walks up the directory structure for a stylecop.json so you can simply create one at the root of your repo and it will automatically be picked up.
I'm pretty sure this makes the enabling stylecop.json documentation obsolete.  Should I update it?

I'm pretty sure this makes the enabling stylecop.json documentation obsolete. Should I update it?

Yep 👍

:bulb: You can probably remove the following text:
https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/065af6a475b335722b7f693626c2d7f3b40290e5/StyleCop.Analyzers/StyleCop.Analyzers.CodeFixes/Settings/SettingsFileCodeFixProvider.cs#L27-L31

I did some more testing and found a few snags.  I'm investigating how to make this work for all scenarios...

@jeffkl I'm going to get the 1.1.0-beta008 out the door and then we can try again for beta009 for this change 😄

Okay I might just close this PR.  There are a few complications:

Legacy projects don't show linked files in Solution Explorer.  If you have something like this in an import:

<ItemGroup>
  <AdditionalFiles Include="..\..\stylecop.json">
    <Link>stylecop.json</Link>
  </AdditionalFiles>
</ItemGroup>

It doesn't show up in Solution Explorer.  It still gets passed to the compiler and the stylecop config is read but its really hard to tell in Visual Studio where the configuration is coming from unless you manually add stylecop.json as a Solution Item.  It feels like a bad user experience.

New SDK-style projects don't need explicit items by default.  The auto-fix logic in StyleCop place an item directly in the project:

<ItemGroup>
  <None Include="stylecop.json" />
</ItemGroup>

But out-of-the-box SDK-style projects include most files in None items unless you've set EnableDefaultItems to false.  I ran the fix logic under the debugger to try and come up with a way to make it work but the Roslyn Workspace object just doesn't have enough flexibility to read evaluated MSBuild properties or to add the file to disk but not add an item to the project.
So for SDK-style projects you end up with an item in the project and the import removes it and adds back one from a parent directory and again, it feels like a bad user experience.
There does not appear to be a way to tell from a RoslynWorkspace if the project is legacy or SDK-style so its hard to have more advanced logic.  Perhaps you know if there is a way to get MSBuild properties?  Or to not add an explicit item to the project and just create the file?


User can follow/unfollow magazine

@omarelhariry @mayarali @AndrewMagdy

Please Use Rubocop

@AndrewMagdy

@bassemmagdy
magazine.isfollowed takes magazine as an argument and not an article
remove the user.unfollow its not necessary

@omaressameldin check the fixed things

@MohammedAnsary

@bassemmagdy Tests reviewed but code reopened due to style violations in the test file indicated by rubocop + typo in documentation: Authou instead of Author. Please fix and resolve conflicts with master.

@MohammedAnsary

@MohammedAnsary


(atom:1820): Gtk-WARNING **: 09:13:49.285: cannot open display:

Steps to Reproduce

install virtual box 6 stable
install debian 10 under virtualbox
download package https://atom.io/
dpkg -i atom-amd64.deb
atom

Expected behavior:
atom will start
Actual behavior:

(atom:1820): Gtk-WARNING **: 09:13:49.285: cannot open display:

Versions
atom 1.39.1

Rebooting Virtual Box helped...


BreadcrumbWithOverflow release review (internal, required for PageHeader release)

Component reviews for readiness
Reviews will be carried out by one or more members of the core contribution team. They will include as a minimum the following checks, which establish the "definition of done" for a component.
Paste the following checklist into the epic or issue under which the component is being made ready, then check where criteria passed, and add notes to clarify how an item is complete or what remains to be done: for anything more than minor/simple items, open issues to track them.
Tip You should be able to copy and paste the section below directly into a GitHub comment, then check where criteria passed, strike out where not applicable, and add notes to each item where applicable.
Once one or more components have been reviewed for readiness, the following steps are needed:
the flags for the components in package-settings.js should be changed to true.
the component SCSS should be included in /src/components/_index-released-only.scss.
run the tests, recreating snapshots (using -u), and check in the updated public CSS snapshot. NB it is sufficient to run yarn jest styles -u to complete the snapshot updates.
Review for release
Readiness

[x] One or more scenarios for a design pattern have been identified as a useful unit of functionality to publish.
[x] A functioning component or components delivering those scenarios have been delivered and merged to master.
[x] Design maintainer has approved the implementation for those scenarios (via a comment on the relevant issue/epic).

Engineering review

[x] Breaking changes have only been introduced with prior approval, discussion and documented in release notes. Ideally deprecation notices in the prior major version must have been added in a timely fashion.
[x] The implementation takes into account, and does not impair, remaining and anticipated design scenarios.
[ ] Public component features (names, props, etc) are consistent with Carbon-defined conventions and are consistent internally. Where there isn't an existing convention to apply, ensure robust precedents are being established.
[x] The UI produced is accessible, responsive, translatable, cross-browser, and responds to the currently set Carbon theme.
[x] Components are functional components using hooks.
[x] Public components which produce DOM structures support className.
[ ] Public components support a ref (via React.forwardRef).
[x] All significant DOM elements have meaningful classes.
[x] Additional attributes that are not identified as props (such as title, aria-*, etc) are passed through to an appropriate DOM node of the component as HTML attributes.
[x] No warnings, errors or log messages in the console.
[ ] Each public component JS is exported in /src/components/index.js, each public component SCSS is included in /src/components/_index.scss, and each public component has a flag in package-settings.js.

Standards

[x] No linter warnings or errors are produced.
[ ] Carbon tokens (theme, layout, motion) are used unless the design specifies otherwise.
[x] Code is formatted according to prettier rules (no use of //prettier-ignore).
[x] Code is clear, maintainable and follows standard React practices and the code guidelines.
[ ] Copyright header in every source file (js, css, scss etc.) with the appropriate years.

Testing

[x] There is a set of test cases for the components.
[ ] The tests exercise all inputs (props, slots, etc) and verify appropriate outputs.
[x] The tests validate the behaviors and interactions defined in the design where practical.
[ ] The tests achieve 100% coverage.
[x] No warnings, errors or log messages in the test output.

Documentation

[x] Source code is satisfactorily commented and provides DocGen comments for all public components and their props.
[x] There is a story for each design scenario. The stories expose all relevant props and actions, and additional usage documentation and code samples are available on the 'Docs' tab along with the props table.
[x] There is a sandbox (or multiple sandboxes if appropriate) on CodeSandbox for the components.

[ ] Remove default prop for overflowAriaLabel and make this a required prop.
[ ] Lines 93 and 96 have comments about a dependency on a Carbon PR that has been merged, this may need to be updated now.
[ ] Line 168 has a $ at the beginning of the key, is this intentional?
[ ] Line 315, class name should be className={${blockClass}__breadcrumb-back-button} (replacing -- with __
[ ] Line 92, should ariaLabel use overflowAriaLabel instead of being set to null?
[ ] Component needs forwardRef
[ ] BreadcrumbWithOverflow is not exported in index.scss, index.js, package-settings.js, is that simply because this is an internal component?
[ ] Line 72 in _breadcrumb-with-overflow.scss uses 18px, is this intentional?

@matthewgallo see #986

Release review completed -- ready for PageHeader release.


Connector app sometimes can miss card removal and also subsequent card insertions/removals

PC/SC-Lite bundled inside the Connector app may sometimes miss card removal/insertion events.
Seems that it's due to a recent bug in chrome.usb API implementation in Chrome: http://crbug.com/640725.
This bug will track this fix and, if required, any other necessary fixes.
/cc @dskaram

The problem in Chrome implementation of chrome.usb was fixed starting from Chrome versions 53.0.2786.


Update to v1.16.0 of Azure Terraform Provider

Fixes #134.
Fixes #128.
The steps used to produce this update using the govendor-override tool are available at https://github.com/pulumi/home/blob/master/tools/govendor-override/README.md.

I didn’t run it to test for additional unmapped resources.

As of the latest commit I added - the only warning we see now is this - which is a resource we (temporarily) added just to our mapping and so is expected to not have docs:
warning: Could not find docs for resource azurerm_storage_zipblob; consider overriding doc source location

hey luke, since this went in, we're now seeing failures in pulumi-cloud like so: https://travis-ci.com/pulumi/pulumi-cloud/builds/88927816

[ umi-cloud/azure/examples/topic ]  +  pulumi:pulumi:Stack topic-p-it-travis-job-topic-c90eebdc creating 1 info message. info: panic: interface conversion: interface {} is schema.schemaMap, not *schema.schemaMap

This looks related to https://github.com/pulumi/pulumi-terraform/issues/229 where updating azure deps led to similar breaks.   I have no idea what we should do here.


Implement typography

It turns out that I was working on the exact same library. Even the coding and syntax conventions were almost identical. If you want to have a look, here is my implementation of mdc-typography.
import React, { Component, PropTypes } from 'react';
import classnames from 'classnames';

class Typography extends Component {
  static propTypes = {
    className: PropTypes.string,
    tag: PropTypes.string,
    display4: PropTypes.bool,
    display3: PropTypes.bool,
    display2: PropTypes.bool,
    display1: PropTypes.bool,
    headline: PropTypes.bool,
    subheading2: PropTypes.bool,
    subheading1: PropTypes.bool,
    body2: PropTypes.bool,
    body1: PropTypes.bool,
    caption: PropTypes.bool
  }

  static defaultProps = {
    tag: 'h1'
  }

  get className() {
    const propClassNames = ['display4', 'display3', 'display2', 'display1', 'headline', 'subheading2', 'subheading1', 'body2', 'body1', 'caption'];
    return propClassNames
      .map(className => ({
        ['mdc-typography--'+className]: this.props[className]
      }))
      .reduce((prev, curr) => ({...prev, ...curr}), {});
  }

  render() {
    const {tag, className, ...otherProps} = this.props;
    return (
      <this.props.tag
        className={classnames(this.className, className)}
        {...otherProps}
      >
      </this.props.tag>
    );
  }
}

export default Typography;

I was going to submit this as a PR, but I couldn't manage to get it working. Probably due to the fact that I am currently using a windows desktop and the scripts are designed to run on MacOS / linux.

Hi @foreggs , thank you for contribution.
Looks that problem on Windows was with rm -rf. I have changed it to cross platform rimraf
And also i can't understand how adjustMargin works. I've tried sth like this:
  get className() {
    const propClassNames = [
      'adjust-margin',
      'body1',
      'body2',

And then
<Typography display2 adjust-margin>Display2</Typography>


Fix: avoid redeclaring attributes

Close #4749.

Jenkins, test this please

Jenkins CI test (for commit aa108f6bd92dc2b797c3fa7d93ad9e574c8c37af, target branch master) succeeded!

The issue is not present in v8.


F5 Networks External Helm Chart Fails Answer File

Rancher versions:
rancher/rancher:v2.0.6
Steps to Reproduce:

Add the F5 Networks Helm Chart Repo to the Global Catalog
https://github.com/F5Networks/charts

Deploy the f5-bigip-ctlr chart

Summary:
Helm template --notes failed. Error: render error in "f5-bigip-ctlr/templates/f5-bigip-ctlr-deploy.yaml":
template: f5-bigip-ctlr/templates/f5-bigip-ctlr-deploy.yaml:5:4: executing "f5-bigip-ctlr/templates/f5
bigip-ctlr-deploy.yaml" at <required "BIG-IP url...>: error calling required: BIG-IP url not specified - add
to Values or pass with `--set` : exit status 1

I believe the issue is with how this chart implements values

Note: Helm value names cannot include the character - which is commonly used in the names of parameters passed to the controller. To accomodate Helm, the parameter names in values.yaml use _ and then replace them with - when rendering. e.g. args.bigip_url is rendered as bigip-url as required by the Controler."

https://github.com/F5Networks/charts/blob/master/src/stable/f5-bigip-ctlr/README.md
The customer would like to use this chart without using a work around. Can we maybe add this chart to the Rancher Catalog library?  Also I think the mechanism for the answer file is not robust?
Answer file from external repo:
{"args.bigip_url":"<IP_ADDRESS>"}

Answer file from Rancher Catalog:
args.bigip_url : <IP_ADDRESS>

Not sure if that even matters but what if we add the option to edit the answer.yaml and other files from the chart such as values.yaml and etc. The customer is frustrated with Helm integration in Rancher. We need to do something about this.

Scratch that, I will create a new issue that talks about in general Helm integration with Rancher. The issue is not with the catalog but the actual integration of Helm with Rancher.


Adaptive Muts per codon per year graph of GII.4

Hello,
I would like to inquire about the graph titled Adaptive Mutations per Codon per Year (x10^-3) for GII.4. Could you please clarify the method used for this calculation? Thank you.
Best regards,
Kritchakorn S.

Hello, I would like to ask you about the calculation I reproduced from the script in rate_of_adaptation_bhatt.ipynb. I found that some of the estimated data points are outside the confidence interval (CI). Have you ever encountered this issue?


Error when executing: python train.py --logtostderr --train_dir=training/ --pipeline_config_path=training/faster_rcnn_inception_v2_pets.config

Hello, I am now in the training part, but it shows the error below. Can you guys help me fix it?
(tensorflow1) C:\Tensorflow1\models\research\object_detection>python train.py --logtostderr --train_dir=training/ --pipeline_config_path=training/faster_rcnn_inception_v2_pets.config
2021-03-20 17:10:03.043083: I tensorflow/stream_executor/platform/default/dso_loader.cc:44] Successfully opened dynamic library cudart64_100.dll
Traceback (most recent call last):
File "train.py", line 53, in
from object_detection.builders import model_builder
File "C:\Users\Brian\Anaconda3\envs\tensorflow1\lib\site-packages\object_detection-0.1-py3.6.egg\object_detection\builders\model_builder.py", line 33, in
from object_detection.meta_architectures import context_rcnn_meta_arch
File "C:\Users\Brian\Anaconda3\envs\tensorflow1\lib\site-packages\object_detection-0.1-py3.6.egg\object_detection\meta_architectures\context_rcnn_meta_arch.py", line 42, in
class ContextRCNNMetaArch(faster_rcnn_meta_arch.FasterRCNNMetaArch):
File "C:\Users\Brian\Anaconda3\envs\tensorflow1\lib\site-packages\object_detection-0.1-py3.6.egg\object_detection\meta_architectures\context_rcnn_meta_arch.py", line 95, in ContextRCNNMetaArch
faster_rcnn_pb2.AttentionPosition.POST_BOX_CLASSIFIER)
AttributeError: module 'object_detection.protos.faster_rcnn_pb2' has no attribute 'AttentionPosition'

Helloo i have similar errors while running model_main_tf2.py.
" python model_main_tf2.py --alsologtostderr --model_dir=training/ --pipeline_config_path=training/faster_rcnn_inception_v2_pets.config "
Did you find a solution ?
I dont have any custom steps i did everything from here
But my tensorflow version is 2.5 and i did all setups according to 2.5
So the errors are =
File "C:\tensorflow1\models\research\object_detection\model_main_tf2.py", line 116, in
tf.compat.v1.app.run()
File "C:\Users\pelin\anaconda3\envs\tensorflow1\lib\site-packages\tensorflow\python\platform\app.py", line 40, in run
_run(main=main, argv=argv, flags_parser=_parse_flags_tolerate_undef)
File "C:\Users\pelin\anaconda3\envs\tensorflow1\lib\site-packages\absl\app.py", line 303, in run
_run_main(main, args)
File "C:\Users\pelin\anaconda3\envs\tensorflow1\lib\site-packages\absl\app.py", line 251, in _run_main
sys.exit(main(argv))
File "C:\tensorflow1\models\research\object_detection\model_main_tf2.py", line 106, in main
model_lib_v2.train_loop(
File "C:\tensorflow1\models\research\object_detection\model_lib_v2.py", line 524, in train_loop
raise ValueError('train_pb2.load_all_detection_checkpoint_vars '
ValueError: train_pb2.load_all_detection_checkpoint_vars unsupported in TF2
I searched for 6 days to find a solution. Im so new to this topic and couldnt solve the problems. I would be so appreciate if you help me.
these are my config and other files that i use here


Recognize Baja (segregated from Cheilanthes) [PASSED]

Author(s) of proposal
No response
Name of taxon
Baja
Rank of taxon
Genus
Approximate number of species affected
1
Description of change
Transfer the species long known as Cheilanthes brandegeei D.C. Eaton to the (monotypic) genus Baja.
Reason for change
Endemic to Baja California, Mexico, is an enigmatic cheilanthoid long treated as Cheilanthes brandegeei D.C. Eaton. Phylogenetic analyses (George et al. 2019) however, demonstrate that this species, together with its sister lineage, Bommeria, constitutes a deeply isolated lineage within cheilanthoids, far from the hemionitid clade that contains the type of Cheilanthes (Windham et al. 2009). However, Bommeria is quite different, morphologically, from the brandegeei taxon (most conspicuously brandegeei has pinnately divided leaves vs the entire leaves of Bommeria, and a well-developed false indusium whereas the sori in Bommeria are acrostichoid), and thus George et al. created a new genus for it: Baja.
The only alternatives, in terms of recognizing ony monophyletic taxa, would be to treat brandegeei in Bommeria, where it is morphologically anomalous (and thus reducing the cohesiveness and diagnosability of Bommeria) or to extend the circumscription of Cheilanthes to encompass both the generic type and brandegeei. However, this enlarged "Cheilanthes" clade would include nearly all cheilanthoids (only Calciphilopteris would remain unaltered) and would need to be treated as Hemionitis rather than Cheilanthes (Hemionitis is the older name so has priority).
George et al. - 2019 - Baja  A New Monospecific Genus Segregated .pdf
Windham et al. - 2009 - Using plastid and nuclear DNA sequences to redraw .pdf
Reference(s) for publication of the name
George et al. - 2019 - Baja  A New Monospecific Genus Segregated .pdf
List the numbers of any related issues
No response
Code of Conduct

[X] I agree to follow the PPG Code of Conduct

This proposal was voted on during PPG Ballot 6 (voting period December 2023). A total of 60 votes were cast. There were 54 'Yes' votes (90%) and 6 'No' votes (10%). The proposal passes.


Feature: Append 'Start' script for package.json after everything is done generating

https://stackoverflow.com/questions/22159044/how-to-append-a-string-at-end-of-a-specific-line-in-a-file-in-bash


Editor: keyboard shortcuts in the tile Tile Set Polygon Editor don't work anymore

Godot version
4.2 beta 4
System information
Windows 11
Issue description
In the editor, the keyboard shortcuts in the tile Tile Set Polygon Editor don't work anymore.
Steps to reproduce

Make sure you have a project that has a tile map with a physics layer and a tile set
Open the tile set
Select or create a Tiles item
Activate Select tiles mode
Select a tile
Expand Physics
Expand the physics layer
Press C if the layer already has a polygon or press F if it hasn't
Observe that the polygon didn't get cleared or respectively set to default.

Minimal reproduction project
N/A

Can you try following the same steps on 4.2 previous dev beta builds? You can download them here.

Can you try following the same steps on previous 4.2 dev/beta builds? You can download them here.

I just tried it again on beta 4 and the problem is gone. Perhaps the program got into an erroneous state somehow.
When the keys didn't work, I did smash all of my modifier keys on my keyboard to make sure none of them were stuck but that didn't help.

I just experience the same issue with 4.2 beta 4 again. Clicking the "Reset to default tile shape" option worked but pressing F didn't.

Okay, I figured it out: there are multiple layers in my case and the editor was updating a different layer than the one I was viewing.


Add hooks to restrict allowed parameters

Currently there's just the length (min/max/range/exact) restriction. Commands like operator have a fixed number of allowed inputs and so should be allowed to restrict on them.

Remaining in this is allowing specific parameters, such as in privacy enums.


chore: bump cc to 1.0.94

Problem
Close #173
They merged the workaround finally 🎉  (https://www.github.com/rust-lang/cc-rs/commit/f83109b3a3553d4d19c7bfdf371eb36e608ba8f1)
Let's give it a try!

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 81.8%. Comparing base (fb465b3) to head (5e69124).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #876   +/-   ##
=======================================
  Coverage    81.8%    81.8%
=======================================
  Files         851      851
  Lines      231552   231552
=======================================
+ Hits       189576   189635   +59
+ Misses      41976    41917   -59


[Feature]: Transform client instance creations which use AsExpressions

Self-service

[ ] I'd be willing to implement this feature

Problem
Codemod does not transform when type assertion is used on imports
Example input:
import AWS from "aws-sdk";
const client = new (AWS as any).DynamoDB();

Expected output:
import { DynamoDB } from "aws-sdk";
const client = new DynamoDB();

Solution
Detect usages through Type Assertions, and replace them.
Alternatives
Request users to remove Type Assertions.
Additional context
Example code in CDK: https://github.com/trivikr/aws-cdk/blob/722b581c8a23b92166cc6d4d81b6b558dcd4c937/packages/aws-cdk/lib/api/hotswap/ecs-services.ts#L155

An easiest fix would be for utilities which return names for client creation to check for AnyExpression in addition to identifiers
https://github.com/awslabs/aws-sdk-js-codemod/blob/72a3e55160e619488e34686619bfd5864e70c3d1/src/transforms/v2-to-v3/apis/getClientIdNamesFromNewExpr.ts#L12-L36

Marking as no plans to fix, as this is a rare case.
We'll request users to remove the AsExpression, and run codemod.


Support running a script as an alert type

When an alert is triggered for a service, the script at SCRIPT_PATH is
run with information about the service (including passing and failing
checks), the host, and the scheme encoded in JSON format.
Intended for issue #47.

@andrewbaxter sorry for the long delay on this, not enough hours in the day etc. Now that there is a proper alert plugin system it would be best if this was reimplemented as e.g. a fork of https://github.com/arachnys/cabot-alert-hipchat - send me a PR if you'd like this to be installed by default... For the moment I will close this


maintainers: add BenChand

Description of changes
Add BenChand as a maintainer
Add a :+1: reaction to pull requests you find important.

You're just adding yourself as a maintainer but not actually maintaining anything?

You're just adding yourself as a maintainer but not actually maintaining anything?

I was going to add myself as a maintainer to this PR, thought they maybe needed to be separate:
https://github.com/NixOS/nixpkgs/pull/336558

It's fine to add the maintainer commit to that PR. It'll simplify review.


pre commit file is missing (on windows)

File "\apps\python\3.8.0\lib\site-packages\pocr\controller.py", line 117, in create
shutil.copy(pkg_resources.resource_stream(name, Paths.PACKAGE_GIT_HOOK_PATH)
...
No such file or directory: '\apps\python\3.8.0\lib\site-packages\pocr\utils\pre-commit

I will check that later this afternoon


Fix typo in the readme

So, should I send another PR targeting the 2.0 branch?

So, should I send another PR targeting the 2.0 branch?

@jdreesen  That's quite alright, thanks :)
The documentation for version 2 is a complete rewrite. I've been working on it for weeks, but because a large part refers to unwritten parts, I've not created a commit for it.
If you'd like to help out, I'd really appreciate it if you could check out the migration guide I'm adding to the documentation, to see if it's incomplete, incorrect or could be improved. I'm expecting that to go up later this week.

@jdreesen I've given it some more thought and I appreciate contributions too much, so this will get merged into master and I'll rebase 2.0 later on. That's a problem for future me.
Again, thanks for the contribution! I hope you like the library and especially the degree of agency you'll get from version 2

So far, I really like it. But I fear that I'll have to stay on v1 for some time as we're stuck to PHP 7.4 in our current project.