i get that somthing is negative.

I am on part 3 of your tutorial.
32:48 in the video you compile but my thing does not compile.
i get this error:
src/bootloader/boot.asm:363: error: TIMES value -13 is negative
make: *** [Makefile:30: build/bootloader.bin] Error 1

here is my boot.asm file:
org 0x7C00
bits 16

%define ENDL 0x0D, 0x0A

;;
;; FAT12 header
;;
jmp short start
nop

bdb_oem:                    db 'MSWIN4.1'           ; 8 bytes
bdb_bytes_per_sector:       dw 512
bdb_sectors_per_cluster:    db 1
bdb_reserved_sectors:       dw 1
bdb_fat_count:              db 2
bdb_dir_entries_count:      dw 0E0h
bdb_total_sectors:          dw 2880                 ; 2880 * 512 = 1.44MB
bdb_media_descriptor_type:  db 0F0h                 ; F0 = 3.5" floppy disk
bdb_sectors_per_fat:        dw 9                    ; 9 sectors/fat
bdb_sectors_per_track:      dw 18
bdb_heads:                  dw 2
bdb_hidden_sectors:         dd 0
bdb_large_sector_count:     dd 0

; extended boot record
ebr_drive_number:           db 0                    ; 0x00 floppy, 0x80 hdd, useless
                            db 0                    ; reserved
ebr_signature:              db 29h
ebr_volume_id:              db 12h, 34h, 56h, 78h   ; serial number, value doesn't matter
ebr_volume_label:           db 'NANOBYTE OS'        ; 11 bytes, padded with spaces
ebr_system_id:              db 'FAT12   '           ; 8 bytes

;;
;; Code goes here
;;

start:
    ; setup data segments
    mov ax, 0                           ; can't write to ds/es directly
    mov ds, ax
    mov es, ax

    ; setup stack
    mov ss, ax
    mov sp, 0x7C00                      ; stack grows downwards from where we are loaded in memory

    ; some BIOSes might start us at 07C0:0000 instead of 0000:7C00, make sure we are in the
    ; expected location
    push es
    push word .after
    retf

.after:

    ; read something from floppy disk
    ; BIOS should set dl to drive number
    mov [ebr_drive_number], dl

    ; show loading message
    mov si, msg_loading
    call puts

    ; read drive parameter (sectors per track and head count),
    ; insted of relying on data on formatted disk
    push es
    mov ah, 08h
    int 13h
    jc floppy_error
    pop es

    and cl, 0x3F                        ; remove top 2 bits
    xor ch, ch
    mov [bdb_sectors_per_track], cx     ; sector count

    inc dh
    mov [bdb_heads], dh                 ; head count

    ; compute LBA of root firectory = reserved + fats * sectors_per_fat
    mov ax, [bdb_sectors_per_fat]       ; LBA of root = reserved + fats * fat_size
    mov bl, [bdb_fat_count]
    xor bh, bh
    mul bx                              ; ax = (fats * sectors_per_fat)
    add ax, [bdb_reserved_sectors]      ; ax = LBA of root directory
    push ax

    ; compute size of root directory = (32 * number_of_entries) / bytes_per_sector
    mov ax, [bdb_sectors_per_fat]
    shl ax, 5                           ; ax *= 32
    xor dx, dx                          ; dx = 0
    div word [bdb_bytes_per_sector]     ; number of sectors we need to read

    test dx, dx			        ; if dx != 0, add 1
    jz .root_dir_after
    inc ax			        ; division remainder != 0, add 1
                                        ; this means we have a sector only partially filled with entries

.root_dir_after:
    ; read root directory
    mov cl, al			        ; number of sectors to read = size of root directory
    pop ax				; ax = LBA of root firectory
    mov dl, [ebr_drive_number]		; dl = drive number (we saved it previously)
    mov bx, buffer			; es:bx = buffer
    call disk_read

    ; search for kernel.bin
    xor bx, bx
    mov di, buffer

.search_kernel:
    mov si, file_kernel_bin
    mov cx, 11			        ; compare up to 11 characters
    push di
    repe cmpsb
    pop di
    je .found_kernel

    add di, 32
    inc bx
    cmp bx, [bdb_dir_entries_count]
    jl .search_kernel

    ; kernel not found
    jmp kernel_not_found_error

.found_kernel:

    ; di should have the address to the entry
    mov ax, [di + 26]		        ; first logical cluster field (offset 26)
    mov [kernel_cluster], ax

    ; load FAT
    mov ax, [bdb_reserved_sectors]
    mov bx, buffer
    mov cl, [bdb_sectors_per_fat]
    mov dl, [ebr_drive_number]
    call disk_read

    ; read kernel and proccess FAT chain
    mov bx, KERNEL_LOAD_SEGMENT
    mov es, bx
    mov bx, KERNEL_LOAD_OFFSET

.load_kernel_loop:
    ; Read next cluster
    mov ax, [kernel_cluster]

    ; not nice :( hardcoded value
    add ax, 31               	       ; first cluster = (kernel_cluster - 2) * sectors_per_cluster + start_sector
                                       ; start sector = reserved + fats + root directory size = 1 +18 + 134 = 33
    mov cl, 1
    mov dl, [ebr_drive_number]
    call disk_read

    add bx, [bdb_bytes_per_sector]

    ; compute location of next cluster
    mov ax, [kernel_cluster]
    mov cx, 3
    mul cx
    mov cx, 2
    div cx			       ; ax = index of entry in FAT, dx = cluster mod 2

    mov si, buffer
    add si, ax
    mov ax, [ds:si]		       ; read entry from FAT table at index ax

    or dx, dx
    jz .even

.odd:
    shr ax, 4
    jmp .next_cluster_after

.even:
    and ax, 0x0FFF

.next_cluster_after:
    cmp ax, 0x0FF8         	       ; end of chain
    jae .read_finish

    mov [kernel_cluster], ax
    jmp .load_kernel_loop

.read_finish:
    ; jump to our kernel
    mov dl, [ebr_drive_number]	       ; boot device in dl
    mov ax, KERNEL_LOAD_SEGMENT        ; set segment registers
    mov ds, ax
    mov es, ax

    JMP KERNEL_LOAD_SEGMENT:KERNEL_LOAD_OFFSET
    jmp wait_key_and_reboot 	       ; should never happen

    cli
    hlt

;;
;; Error handlers
;;

floppy_error:
    mov si, msg_read_failed
    call puts
    jmp wait_key_and_reboot

kernel_not_found_error:
    mov si, msg_kernel_not_found
    call puts
    jmp wait_key_and_reboot

wait_key_and_reboot:
    mov ah, 0
    int 16h                             ; wait for keypress
    jmp 0FFFFh:0                        ; jump to beginning of BIOS, should reboot

.halt:
    cli                                 ; disable interrupts, this way CPU can't get out od "halt" state
    hlt

;;
;; Prints a string to the screen.
;; Params:
;;     - ds:si points to string
;;

puts:
    ; save registers we will modify
    push si
    push ax
    push bx

.loop:
    lodsb                               ; loads nextcharacter in al
    or al, al                           ; verify if next character is null?
    jz .done

    mov ah, 0x0E
    mov bh, 0
    int 0x10
    jmp .loop

.done:
    pop ax
    pop si
    ret

;;
;; Disk routines
;;

;;
;; Converts an LBA address to a CHS address
;; Parameters:
;;   - ax: LBA address
;; Returns:
;;   - cx (bits 0-5): sector number
;;   - cx (bits 6-15): cylinder
;;   - dh: head
;;

lba_to_chs:

    push ax
    push dx

    xor dx, dx                          ; dx = 0
    div word [bdb_sectors_per_track]    ; ax = LBA / SectorsPerTrack
                                        ; dx = LBA % SectorsPerTrack

    inc dx                              ; dx = (LBA % SectorsPerTrack + 1) = sector
    mov cx, dx                          ; cx = sector

    xor dx, dx                          ; dx = 0
    div word [bdb_heads]                ; ax = (LBA / SectorsPerTrack) / Heads = cylinder
                                        ; dx = (LBA / SectorsPerTrack) % Heads = head
    mov dh, dl                          ; dh =head
    mov ch, al                          ; ch = cylinde (lower 8 bits)
    shl ah, 6
    or cl, ah                           ; put upper 2 bits of cylinder in cl

    pop ax
    mov dl, al                          ; restore DL
    pop ax
    ret

;;
;; Reads sectors from a disk
;; Parameters:
;;  - ax: LBA address
;;  - cl: number of sectors to read (up to 128)
;;  - dl: drive number
;;  - es:bx: memory address where to store read data
;;
disk_read:

    push ax                             ; save registers we will modify
    push bx
    push cx
    push dx
    push di

    push cx                             ; temporarily save CL (number of sectors to read)
    call lba_to_chs                     ; compute CHS
    pop ax                              ; AL = number of sectors to read

    mov ah, 02h
    mov di, 3                           ; retry count

.retry:
    pusha                               ; save all registers, we don't, know what bios modifies
    stc                                 ; set carry flag, some BIOS'es don't set it
    int 13h                             ;carry flag cleared = success
    jnc .done

    ; failed
    popa
    call disk_reset

    dec di
    test di, di
    jnz .retry
.fail:
    ; all attempts are exhausted
    jmp floppy_error

.done:
    popa

    pop ax                             ; restore registers modified
    pop bx
    pop cx
    pop dx
    pop di
    ret

    ;;
    ;; Resets disk controller
    ;; Parameters:
    ;;  dl: drive number
disk_reset:
    pusha
    mov ah, 0
    stc
    int 13h
    jc floppy_error
    popa
    ret

file_kernel_bin:        db 'KERNEL  BIN'
msg_loading:            db 'Loading...',ENDL, 0
msg_kernel_not_found:   db 'Kernel could not be found...', ENDL, 0
msg_read_failed:        db 'The read of disk did not succeed...', ENDL, 0
kernel_cluster:         dw 0

KERNEL_LOAD_SEGMENT     equ 0x2000
KERNEL_LOAD_OFFSET      equ 0

times 510-($-$$) db 0
dw 0AA55h

buffer:

here is the line it complains about:
times 510-($-$$) db 0

ohhh i solved it :( the messages i wrote diffrent from you (i thought it was prettier) was too long so the bootloader was to large.

Glad you figured it out. 512 bytes really fills up fast.

Lol yeah.


Bug: Just goes to a blank page with four squares

This was working for me a few versions ago, but tried it again today and just takes me to a blank page with 4 pulsating blue squares.

Same bug for me.

Here is mine...
vscode-app-1727342425265.log

Is there any progress planed here to fix this bug?

same problem here.
Seems to be a useful tool, would be nice if the bug will be fixed in future.


Logic Apps omitting Content-Type header in HTTP Request action blocks

I'm using Logic Apps to perform REST operations and GET data from a third-party service. My Logic App fails with an error returned that correlates with no Content-Type being sent in my header. I confirmed with the third-party service's support team that no Content-Type header is being received on their end. But I am definitely sending it.
I think Logic Apps is auto-removing the Content-Type header from my request. The related Microsoft documentation states (emphasis mine):

...
If an HTTP trigger or action includes these headers, Logic Apps removes these headers from the generated request message without showing any warning or error:
Accept-* headers except for Accept-version
Allow
Content-* with these exceptions: Content-Disposition, Content-Encoding, and Content-Type
...

I think Logic Apps is mistakenly removing the Content-Type header without warning. According to the documentation, this is unexpected behavior.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 88388cfb-3f47-e89b-ad03-01d0c9674dc6
Version Independent ID: 21df1ee4-6487-b054-2a62-152e7bc768f6
Content: Call service endpoints by using HTTP or HTTPS - Azure Logic Apps
Content Source: articles/connectors/connectors-native-http.md
Service: logic-apps
GitHub Login: @ecfan
Microsoft Alias: estfan

He4llo @rgmatthes,
Thank you for your feedback! We will review and update as appropriate.

He4llo @rgmatthes,
Thank you for your feedback! We will review and update as appropriate.

Hi
I am seeing the same issue as @rgmatthes.
Since the API i am calling requires a content-type header this bug makes the http action useless for me.

Hi
I am seeing the same issue as @rgmatthes.
Since the API i am calling requires a content-type header this bug makes the http action useless for me.

Adding a +1 here. Has been an issue for a while now. Content-Type (Not sure about Content-Disposition, Content-Encoding) is being omitted from the request headers when you specify it. Makes the HTTP action in Logic Apps useless for querying strict APIs that require a content-type to be set.

Adding a +1 here. Has been an issue for a while now. Content-Type (Not sure about Content-Disposition, Content-Encoding) is being omitted from the request headers when you specify it. Makes the HTTP action in Logic Apps useless for querying strict APIs that require a content-type to be set.

@rgmatthes, I checked with the Logic Apps team, and they responded that the Content-Type header isn't usually included with GET requests. I'm checking whether you need to use a different method and what to do in situations when the target API expects and requires the Content-Type header.

@rgmatthes, I checked with the Logic Apps team, and they responded that the Content-Type header isn't usually included with GET requests. I'm checking whether you need to use a different method and what to do in situations when the target API expects and requires the Content-Type header.

@rgmatthes, the team responded that the Content-Type header is permitted for PUT and POST requests, just not GET requests. I can add a note to the doc that clarifies this detail.

@rgmatthes, the team responded that the Content-Type header is permitted for PUT and POST requests, just not GET requests. I can add a note to the doc that clarifies this detail.

#assign @ecfan

#assign @ecfan

The doc update should go live after 11 AM Pacific Time.

The doc update should go live after 11 AM Pacific Time.

Thanks ecfan, I see the update. At least it's something.
I added the UserVoice here: https://feedback.azure.com/forums/287593-logic-apps/suggestions/42578674-enable-support-for-content-type-header-in-http-get
@gjelhus @jrobijn @ecfan @ChaitanyaNaykodi-MSFT You know what to do

Thanks ecfan, I see the update. At least it's something.
I added the UserVoice here: https://feedback.azure.com/forums/287593-logic-apps/suggestions/42578674-enable-support-for-content-type-header-in-http-get
@gjelhus @jrobijn @ecfan @ChaitanyaNaykodi-MSFT You know what to do

@rgmatthes, I've alerted the engineering team that you opened the request. They'll evaluate based on how many people vote for the update.

@rgmatthes, I've alerted the engineering team that you opened the request. They'll evaluate based on how many people vote for the update.

I have the same issues, mandatory use op a header called  'Accept-Crs' with GET , which is omitted with http-request.
It is frustrating and time consuming, not getting any error and the blocking  is without need(?)

Hi @Pr-Barnart, thanks for your feedback. As the "Accept-Crs" header is included in the dropped headers list, I suggest sharing this feedback with the product team in the Logic Apps feedback forum.


Inject install.yaml into the helm binary prior to build

One thing we could do is maintain the YAML file as a separate artifact, and then inject it into the binary at build time.

And make it overridable on the command line.

So after testing a few things, this is clearly not the ideal solution to the problem. The manifest changes in very predictable ways -- most notably, the image field changes with each build. Maintaining this in a static text file is suboptimal. And then when we add in the process of importing that into the source code, it gets really cumbersome.
In contrast, embedding the file inside of the library and altering it to be a Go template means we can very easily parameterize it (which is more in step with our philosophy). I think I am going to experiment with that route for a bit.


manual build iohook failed with gyp stack error

try manual build iohook , but build failed with error
make: *** No rule to make target `Release/obj.target/uiohook/libuiohook/src/logger.o', needed by `Release/uiohook.dylib'.  Stop.

i see this error is fixed https://github.com/wilix-team/iohook/pull/258#issuecomment-723083004
but it not look like not work ?
Expected Behavior
build success
Current Behavior
throw error
Your Environment

IOHook Version: v0.9.3
Environment name and version (e.g. Chrome 39, node.js 5.4, electron 11.2): node v12.14.1, electron runtime node version v12.16.3, electron v10.4.7
Operating System and version (desktop or mobile): desktop macos v11.2.2
Optional Link to your project:local
package.json iohook config

"iohook": {
    "targets": [
      "node-72",  //this version is current mac installed node version abi or electron runtime's node version abi ? it has diffrence
      "electron-50"
    ],
    "platforms": [
      "darwin"
    ],
    "arches": [
      "x64"
    ]
  }

Hi, have you solved the problem yet?


Fix tf/tfstate output for security groups

Adjusted the tests and both the tf/tfstate exports according to the statements
below. The tests should be improved too, for now they're ok.
Note that if it's a VPC security group, the group name is nil in the permission
set.
EC2-Classic security groups can be:

security groups from the same account
security groups from another account
CIDR

If it is an EC2-Classic security group from the same account, the rule should
contain only the security group name not the group id.
Example tf export snippet: security_groups = ["sg-1234efgh"]
If it's an EC2-Classic security group from another account, the role should
contain the account id and the security group name, not the id.
Example tf export snippet: security_groups = ["098765432109/sg-1234efgh"]
VPC security groups can be:

security groups from the same account + same VPC
CIDR

A rule inside of a VPC security group can't be SGs from a different VPC or from
a differert account. Only CIDRs and SGs from the same VPC.
A rule should contain only the security group ID or a CIDR.
Example tf export snippet: security_groups = ["sg-1234efgh"]
The documentation says:
security_groups - (Optional)
List of security group Group Names if using EC2-Classic or the default VPC, or
Group IDs if using a non-default VPC.

Note that I've tested this in an environment with:

EC2-Classic only
VPC only
Mixed

The outputs were always OK and the tf was in sync with the tfstate.

Replaced all and to && and removed all next occurrences.

(I confirmed that CI fails are not related to your changes.)
LGTM 👍 Thanks ❗
Sorry for being late.


malformed JSON returned when querying $batch for user events with limited permissions

I'm working on a SharePoint App that uses the Graph API to access some functions of Exchange.
In this case, checking a couple calendars for read access to the events in them.
And as I was randomly going through the network requests today, I noticed that I have been requesting every field for that simple access check. But since I didn't need any field to begin with, I added $select=id to the request, to cut down on the response size.
And this is where everything started breaking "randomly", and I've spent the last few hours trying to track down what is breaking.
The problem: if a $batch request for a shared calendar's events fails while also providing a $select, the returned JSON is malformed and breaks literally everything that tries to parse it.
This is what the response looks like, the matching ] for the "value" property is nowhere to be found.

And each calendar that returns an error compounds that error. Meaning each error opens their "value" array, but none ever close any.
BUT this error happens only IF a $select is used, with the exception being $select=*. That does not cause the error either.
Here's the minimal setup I've used to recreate that error in the Graph Explorer, so the used libraries of the App and such could be ruled out as problem sources:
The requirement for causing the request to return 403 is simply any shared calendar, for which the user making the request does not have the Outlook permission Read: Full Details.
Request Body:
{
    "requests": [
        {
            "id": "1",
            "method": "GET",
            "url": "/users/{USER}/events?$top=1&$select=id",
            "headers": {}
        }
    ]
}

sent with POST to https://graph.microsoft.com/v1.0/$batch
The result is as shown above. Not even returning an error, it just shows a little red box with "400".
That's how much the response breaks parsers.

And this only happens in this odd edge-case.
If the $select is absent, it just returns a normal error or all fields for the found events, as expected.
But is the $select is added to cut down on the returned fields, it suddenly forgets to add the closing ] for "values".
Although my theory is that it was never meant to open an array for "values" in the first place.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: e33b4529-dfaa-b051-a73e-fa7312e911f5
Version Independent ID: 55111137-63ad-3408-9295-ef44128aed14
Content: Combine multiple requests in one HTTP call using JSON batching - Microsoft Graph
Content Source: concepts/json-batching.md
Product: non-product-specific
Technology: microsoft-graph
GitHub Login: @FaithOmbongi
Microsoft Alias: ombongifaith

Hi,
Thanks for your feedback. Unfortunately this repo is for keeping track of issues or new contributions in the Microsoft Graph docs and not to provide help about how to use Microsoft Graph. You should rely on the Microsoft Graph support area (https://developer.microsoft.com/en-us/graph/support) for this kind of questions. I'm going to close this item. Thanks for your understanding.


Automated Package Upgrade

:tada: This PR is included in version 2.2.203 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Cache docker images to make travis build faster

Fixes #41

This looks like it works! I'm gonna merge now.
@derrickmar Can you let me know if the builds on your branch are faster with these updates?


Add $PAGER support

Adds support to use a pager for long commands. By default we use less -FRX
which disables the init step (so the screen doesn't completely clear
when less starts), sends the raw output to less (so colors work), and
exits if less than one full screen is output.
We also honor the $PAGER environment variable, so the program that's
used for paging can be customized per http://manpages.ubuntu.com/manpages/bionic/en/man1/man.1posix.html
An easy way to test this is to change the vip app list to output 30
results instead of 10.
This is a good start, but it would be better if we could page over
results and write 10 at a time. It would also be nice if that was
pausable (like stream.pause()) so we could lazy load results (or never
load results) that aren't going to be on screen anyway.
See: #116

My current plan is to:

Refactor the formatData and related code to work on 1 line at a time and iterate with for..of
Where necessary, return custom iterables

This is nice because after step 1 everything will continue to work. The object we return is already iterable.
In cases where we want to return lots of data, we can implement a custom iterable that makes N API requests. We could make 1 request for every row or (more likely) only make a request every i.e. 10 rows. Since iterables support pausing, we can also not make more requests than we need -- maybe make 1 extra request in the background so that we never have to wait for things to load.
Note: This means we need to change the cli-table we use to return a full row for the header, but skip the first line of sequential rows so that each row doesn't have a double line between them. Pretty easy to implement, just something to keep in mind.
Implementing iterables: https://medium.freecodecamp.org/demystifying-es6-iterables-iterators-4bdd0b084082

Actually... solving the immediate issue by bumping the app limit to 100. We can add lazy load support later.

Tested on Windows and MacOS.

I think this is pretty good now.

👍


Error code PROTOCOL_INCORRECT_PACKET_SEQUENCE

Hi everyone.
I'm having difficulties implementing a simple query  on a AWS Lambda NodeJS (with JAWS framework). Running it on local it works, but when I upload it to AWS and then try to run it using the API Gateway endpoint, I got this error:
{
  "code": "PROTOCOL_INCORRECT_PACKET_SEQUENCE",
  "fatal": true
}

I can't find any response on google, stackoverflow or issues on git about this error. And I can't figure out what I'm doing wrong.
This is what I'm trying.
var mysql = require('mysql');

var connection = mysql.createConnection({
  host   : '',
  user   : '',
  password : '',
  database : ''
});

function getLists (client_id,api_key,callback){
    connection.query("SELECT * FROM list WHERE client_id = ?",
        [ client_id],function(error, results){
            connection.end();
            callback(error,results);
        }
    );
};

module.exports.run = function(event, context, cb) {
    getLists(event.x_mail_list_client_id,'',function(error,results){
        if(error){
            return cb(null,error);
        }
        return cb(null,results);
    });
};

It could possibly be a bug here or some kind of incompatibility with that server. Can you add debug: true to your options, then paste out the full output provided from start to when you get that error?

Yes, probably it's an incompatibility with the server.
I'm thinking that the logging tool of AWS Lambda isn't the best. On my local environment I get the entire output of the mysql library debug mode. But the AWS lambda log on the server only throw this:
START RequestId: 52035b31-7826-11e5-a20d-ff9a485b383d Version: $LATEST
2015-10-21T19:02:48.477Z	52035b31-7826-11e5-a20d-ff9a485b383d	Received event:
2015-10-21T19:02:48.477Z	52035b31-7826-11e5-a20d-ff9a485b383d	{}
2015-10-21T19:02:48.630Z	52035b31-7826-11e5-a20d-ff9a485b383d	<-- t
2015-10-21T19:02:48.630Z	52035b31-7826-11e5-a20d-ff9a485b383d	{ protocolVersion: 10,
serverVersion: '5.5.44-0ubuntu<IP_ADDRESS>',
threadId: 2283,
scrambleBuff1: <Buffer 76 69 2b 39 79 7a 77 65>,
filler1: <Buffer 00>,
serverCapabilities1: 63487,
serverLanguage: 8,
serverStatus: 2,
serverCapabilities2: 32783,
scrambleLength: 21,
filler2: <Buffer 00 00 00 00 00 00 00 00 00 00>,
scrambleBuff2: <Buffer 74 39 5b 41 71 39 66 76 3e 6e 34 56>,
filler3: <Buffer 00>,
pluginData: 'mysql_native_password',
protocol41: true }
2015-10-21T19:02:48.631Z	52035b31-7826-11e5-a20d-ff9a485b383d
END RequestId: 52035b31-7826-11e5-a20d-ff9a485b383d
REPORT RequestId: 52035b31-7826-11e5-a20d-ff9a485b383d	Duration: 156.21 ms	Billed Duration: 200 ms 	Memory Size: 1024 MB	Max Memory Used: 13 MB
I think that it will not help too much, I can't figure out how to get the entire debug log with this tool.
Any ideas?

Unfortunately I have never used those systems, so don't have any tips for how to get the logs. Please keep me posted with the full logs when you can get them. If you cannot figure out how to get them, then if you can debug the code, you could potentially just send a PR to address the issue as an alternative :)

I was also having this error, it resulted from not excluding the node-mysql module from the browserify builder step. Edit the awsm.json of the lambda to exclude mysql, and then put the path to the node-mysql module in the includePath.

@jewella you are right it worked. I read that this plugin have problem with the browserify library, but I could not find the way to exclude it correctly. Thank you very much.


Error while updating property 'tintColor' of a view managed by: RNSVGSvgView

Bug
When I use at version 9.7.1, there is nothing error, but after I update to the latest version,
I got this error Error while updating property 'tintColor' of a view managed by: RNSVGSvgView
react-native init CleanProject
cd CleanProject/
yarn add react-native-svg
cd ios && pod install && cd ..
modify App.js -> run the app

Environment info
System:
    OS: macOS 10.15.5
    CPU: (4) x64 Intel(R) Core(TM) i5-6267U CPU @ 2.90GHz
    Memory: 112.39 MB / 8.00 GB
    Shell: 5.7.1 - /bin/zsh
  Binaries:
    Node: 12.16.3 - /usr/local/opt/node@12/bin/node
    Yarn: 1.22.4 - /usr/local/bin/yarn
    npm: 6.14.4 - /usr/local/opt/node@12/bin/npm
    Watchman: 4.9.0 - /usr/local/bin/watchman
  Managers:
    CocoaPods: 1.9.1 - /usr/local/bin/pod
  SDKs:
    iOS SDK:
      Platforms: iOS 13.5, DriverKit 19.0, macOS 10.15, tvOS 13.4, watchOS 6.2
    Android SDK:
      API Levels: 21, 23, 24, 25, 26, 27, 28
      Build Tools: 23.0.1, 27.0.1, 28.0.3
      System Images: android-21 | Google APIs Intel x86 Atom, android-22 | Google APIs Intel x86 Atom, android-27 | Google Play Intel x86 Atom, android-28 | Google APIs Intel x86 Atom, android-28 | Google Play Intel x86 Atom
      Android NDK: Not Found
  IDEs:
    Android Studio: 3.5 AI-191.8<IP_ADDRESS>77832
    Xcode: 11.5/11E608c - /usr/bin/xcodebuild
  Languages:
    Java: 1.8.0_191 - /usr/bin/javac
    Python: 3.7.7 - /usr/local/opt/python/libexec/bin/python
  npmPackages:
    @react-native-community/cli: Not Found
    react: 16.11.0 => 16.11.0
    react-native: 0.62.2 => 0.62.2
  npmGlobalPackages:
    *react-native*: Not Found

Library version: 12.1.0

i encounter the same issue lately. Seems like a it's a bug.  I just removed this version and add @9.13.6 to get rid of error

I got the same issue on v12.1.0

It should not be an issue anymore, so I will close it. Feel free to comment here if something is wrong and we can always reopen it then, but please provide a reproduction so we could test it easily.


[Improve][E2E] Improve testcase output log style

Purpose of this pull request
Improve testcase output log style
Check list

[ ] Code changed are covered with tests, or it does not need tests for reason:
[ ] If any new Jar binary package adding in your PR, please add License Notice according
New License Guide
[ ] If necessary, please update the documentation to describe the new feature. https://github.com/apache/incubator-seatunnel/tree/dev/docs

network timeout

Restarted yet.

#3031


(linux) Use $XDG_CONFIG_HOME for gopass config yml

Since this is the default location for config file according to freedesktop configuration specification:
https://standards.freedesktop.org/basedir-spec/basedir-spec-latest.html

$XDG_CONFIG_HOME defines the base directory relative to which user specific configuration files should be stored. If $XDG_CONFIG_HOME is either not set or empty, a default equal to $HOME/.config should be used.

Need to look into how he'd handle the config location on other platforms.
If we find a good way to handle that, we should probably use $XDG_CONFIG_HOME on linux to not clutter our users homedirs.


Looping an array

I was writing a simple example app and came across a case I don't know how the library handles. Here's the code:
json.set! "$jason" do
  json.head do
    json.title "Demo"
  end
  json.body do
    json.sections do
      json.items do
        json.array!(@items) do |item|
          json.type "label"
          json.text item.name
        end
      end
    end
  end
end

Basically I just want to iterate through @items and generate the final markup, and I was converting it to support this gem, and then ended up with below code:
json.jason do
  head.title "Demo"
  body do
    sections do
      items do
        json.array!(@items) do |item|
          type "label"
          text item.name
        end
      end
    end
  end
end

As you can see, the rest of the code is much simpler but the loop is exactly the same as above, because I don't know of a way to use this library to loop. Is this the way to use this gem for looping through arrays? Or is there a simpler way to handle dynamic array looping as well? If there isn't I think it would be awesome to have one.

Try this:
json.jason do
  head.title "Demo"
  body do
    sections do
      items do
        @items.map { |item|  label item.name }
      end
    end
  end
end

This probably works as well, but I haven't tried it, yet:
json.jason do
  head.title "Demo"
  body do
    sections do
      @items.map { |item|  items.label item.name }
    end
  end
end

But thinking on this scenario, I think it would be appropriate to add delegator methods on the Jasonette::Sections class so that label, image, etc. delegate to those methods on the Jasonette::Items class.  Then it would further reduce to:
json.jason do
  head.title "Demo"
  body do
    sections do
      @items.map { |item|  label item.name }
    end
  end
end

Oh, and #map actually isn't needed because calling label does the appending to the items array. (just noticed that when I looked at the source)

Hmm sorry i tried my best but couldn't get the examples to work. maybe I'm doing something wrong, but I really tried every possible combination.
I was writing a short blog post about this and wanted to just set up a simple DB backed app with a single column (a Post model with content attribute), I have already populated the DB and it's working fine on the html side, but when I try any of these:
json.jason do
  head.title "Demo"
  body do
    sections do
      items do
        @posts.map { |post|  label post.content }
      end
    end
  end
end

json.jason do
  head.title "Demo"
  body do
    sections do
      items do
        @posts.each { |post|  label post.content }
      end
    end
  end
end

json.jason do
  head.title "Demo"
  body do
    sections do
      items do
        @posts.map do |post|
          label post.content
        end
      end
    end
  end
end

json.jason do
  head.title "Demo"
  body do
    sections do
      items do
        @posts.each do |post|
          label post.content
        end
      end
    end
  end
end

all of them throw the following error:

Am I correct to do this in the index.json.jbuilder? or for something like this I'm supposed to do this on the controller side?

Here's the project https://github.com/gliechtenstein/jasonette-rails-statusupdate/commits/master

@gliechtenstein I'm able to reproduce with your project and see the problem.  The local variables (i.e. @posts) in this case aren't propagating down the chain as expected so they're falling out of scope.  I'm working on setting up the "dummy" rails app within the gem so I can start replicating these issues with specs.


Refactor and improve definition list

The parser of the definition list was quite limited, it didn't support all feature that a definition list should support, and didn't fit in the new node structure.
By changing the implementation, upgrading the test result to cover the sphinx output this new rule is much closer to what we expect according to the doc-utils spec and sphinx output.

According to the spec, a paragraph is surrounded by blank lines. And a definition ends with a blank line. There is no way to have multiple paragraphs in a single definition. Unless you include a directive or any other block notation.

The spec explicitly allows it though (ref):

A definition is a block indented relative to the term, and may contain multiple paragraphs and other body elements. [...]
[...]

term 2
    Definition 2, paragraph 1.

    Definition 2, paragraph 2.

I believe the Sphinx parser looks at the line after the blank line (IIRC, this is also how I implemented it in the Doctrine rst-parser). If the line following the blank line is indented, it is part of the definition. If it isn't, it is terminating the definition list.

I must have misinterpreted some parts of the spec. It's not possible this way to have multiple definitions with this same term. I think that's where I did go wrong. The HTML spec allows that.  But it doesn't have to be the same for rst.
The node structure allows it now. I think I will keep it that way. But the rule needs an adjustment. That should be easy, as I implemented the definition parsing as a separate process.


Update Makefile

Codecov Report

Merging #8 (315f241) into main (14abeeb) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main       #8   +/-   ##
=======================================
  Coverage   55.69%   55.69%
=======================================
  Files           6        6
  Lines         237      237
=======================================
  Hits          132      132
  Misses         90       90
  Partials       15       15

Help us with your feedback. Take ten seconds to tell us how you rate us.


adapt TODO group structure

TODO group structure is a starting point for the content necessary for creating the UC OSPO franchise. The structure doesn't include a place for OSPO programs such as the OSRE or the incubator. The goal of this pull request is to eventually arrive at a structure that fuses the two roles of the OSPO UC Santa Cruz: an OSPO and an umbrella organization for UC OSPOs.

Please do not merge. This pull request is intended to track progress and reviews of creating the basic structure of the OSPO website.

I just did a "git rebase main" followed by a "git push" from my repository of this branch to update this branch with symposium-related commits. See this documentation (replace "master" with "main" and "experiment" with "carlosm-ns-wf").


fix-vertical-metrics.py: fixed linegaps arguments.

Previously, the script would not recoginise any linegap arguements, if their value was 0. This is because Python treats 0 as a False statement.

good catch! Thanks!


npm support does not work with nexus

What happened:
npm artifact type does not work with nexus
What you expected to happen:
npm resources should work with any npm repository
How to reproduce it (as minimally and precisely as possible):
15:31:38  debug sapOcmCreateComponent - components:
15:31:38  debug sapOcmCreateComponent - - name: github.wdf.sap.corp/open-component-model/npm-ocm
15:31:38  debug sapOcmCreateComponent -   version: ...15:31:38  debug sapOcmCreateComponent -   resources:
15:31:38  debug sapOcmCreateComponent -   - name: npmpackage
15:31:38  debug sapOcmCreateComponent -     type: npmPackage
15:31:38  debug sapOcmCreateComponent -     version: ...
15:31:38  debug sapOcmCreateComponent -     access:
15:31:38  debug sapOcmCreateComponent -       type: npm
15:31:38  debug sapOcmCreateComponent -       registry: https://staging.repositories..../stage/repository/...
15:31:38  debug sapOcmCreateComponent -       package: npm-ocm
15:31:38  debug sapOcmCreateComponent -       version: ...

OCM CLI generates a 404 error.
It is not an ocm issue. It is a nexus issue. You can do the same with curl:
curl -u : https://staging.repositories.../stage/repository/.../npm-ocm/0.1.0-...
{"success":false,"error":"Package 'npm-ocm-0.1.0-...' not found"}
The problematic call is:  https://github.com/npm/registry/blob/master/docs/REGISTRY-API.md#getpackageversion
The issue is documented here:  https://github.com/sonatype/nexus-public/issues/224
Is there any possibility to workaround this limitation?
Anything else we need to know:
Environment:

adding @hilmarf for awareness


Remove state operation for NTS/DTS should be banned

The code just panics at the moment and it seems there is no good option for continuing here. For BTS, based on HashSet/HashMap, this is easy to implement and maybe this should actually be the only type that does.

We now solve this by non longer implementing the Shrinkable trait for DTS or NTS. Further, we renamed BTS to MutableTs to reflect that the full mutability that this offers.


build(deps): bump all deps

:tada: This PR is included in version 2.3.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


warning: Month 13 is out of bounds  //In Xcode9, iOS11

because NSDate in _cacheInfo write to plist file
[_cacheInfo writeToFile:cachePathForKey(_directory, @"EGOCache.plist") atomically:YES];
hope fix it
Thanks

今天早上我也遇到这个问题，找了几个小时才定位到是这个库的问题。

It seems bug in SDK not from EGOCache.
Everything looks like it's working fine although i can see the log too.

注释这句[_cacheInfo writeToFile:cachePathForKey(_directory, @"EGOCache.plist") atomically:YES];就不会出现这个提示Month 13 is out of bounds。
然后作者早点修复一下。

我发现问题是在plist保存nsdate时发生的。我把保存的nsdate转为nsstring，就不会出现这个提示。但我不清楚这样做会不会出现性能上的差异。

Closing this out as it's an OS bug: https://encrypted.google.com/search?hl=en&q="Month 13 is out of bounds"


Push event log missing in main page

Description
After I had upgraded gitea version from 1.16.9 to 1.17.0, push event activities never shown in dashboard recent logs.
There must be something wrong with push event. And may be it is related to this issue #20482 .
Gitea Version
1.17.0
Can you reproduce the bug on the Gitea demo site?
No
Log Gist
No response
Screenshots

As is shown in the snapshot. I upgraded gitea version 5 days ago in repo greendata/devops-server. Then I pulled the repo and upgraded my server. After that, serveral pushes pushed, but none was shown in recent activities list.
Git Version
2.36.2, Wire Protocol Version 2 Enabled
Operating System
CentOS 7 with DockerCE 18.09.7
How are you running Gitea?
Docker image from official registry gitea/gitea:1.17.0
Database
MySQL

https://blog.gitea.io/2022/07/gitea-1.17.0-is-released/

Thank you very much.
I have checked upgrade document Upgrade from an old Gitea, but nothing mentioned here. I think there should be some work of the docs.

Thank you for your suggestion (I thought there were some documents, but there aren't 😂)
I propose a PR for the document.

#20682


Free hand drawing on the iPad is inconsistent

Opening this based on the discussion in #3468
Free-hand drawing on the iPad (Safari / Firefox / Chrome) is inconsistent with the strokes being eaten up sometimes. Demonstrated below.
https://user-images.githubusercontent.com/8571509/116011078-e694df80-a5d7-11eb-891b-bc3650ca8eee.mov

I'm wondering if this would be fixed by calling preventDefault when detecting a pointer down event.

I'm wondering if this would be fixed by calling preventDefault when detecting a pointer down event.

Yeah, it may be the issue since we've recently moved away from doing it to solve excalidraw integration issues: https://github.com/excalidraw/excalidraw/pull/3207 — as such, going back to it is probably not something we wanna do.
@aloknnikhil just to confirm this, can you check if it reproduces in here https://excalidraw-git-aakansha-export-excalidraw.vercel.app/? This should be before we stopped preventing the default.

Hmm. Looks like the text selection bug is back in this one ➝  https://excalidraw-git-aakansha-export-excalidraw.vercel.app/?
which is preventing me from testing the fix for this issue.

I think you should be able to open dev console on iPadOS, and from there paste this in to fix it:
var s = document.createElement('style'); s.innerHTML = '.visually-hidden { user-select: none }'; document.querySelector('head').appendChild(s);

Yeah, this issue makes excalidraw not work for freehand drawing on the iPad. It's even worse if you don't use cursive writing. Every other stroke is lost, so it's really not functional. Really hoping this gets picked up and fixed, it's our number one issue now that we have cloud file storage/sharing in excalidraw+.

@pjm17971 can you try disabling Scribble feature if it improves the situation (https://twitter.com/steveruizok/status/1389889293913571328)?

@dwelle I disabled Scribble and it made it work as expected.
I followed the tweet to the Apple forum post and found this post -- https://mikepk.com/2020/10/iOS-safari-scribble-bug/. Seems like some fix was suggested there. Not sure if that is a change that could be made?

Interesting, thanks for the link! Can't test myself. /cc @steveruizok unclear if we can do that without breaking other things.

For me turning off Scribble makes strokes work 80% of the time vs maybe 50% before. Below is output from both settings. Better but still can't use. This is on an iPad Pro.

For comparison, how does it work in this sandbox? https://perfect-freehand-example-steveruizok.vercel.app/

There’s an issue here that may be related https://github.com/steveruizok/perfect-freehand/issues/11 though the best comparison would be against an Excalidraw build from before we integrated perfect freehand. I also had missed strokes on the iPad with the old pen tool... though we’re able to repro this with mouse input too, right?

On 25 May 2021, at 20:12, David Luzar @.***> wrote:

For comparison, how does it work in this sandbox? https://perfect-freehand-example-steveruizok.vercel.app/
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.

though we’re able to repro this with mouse input too, right?

If this is related to https://github.com/excalidraw/excalidraw/issues/3564 then yes. But since the OP issue is pre-freedraw and it never happened to me pre-freedraw I'd say no?

Writing with the vercel app above works perfectly.

I have the same issue using excalidraw on a 2018 ipad with apple pencil 2. Strokes are missed when I write normal speed. Only when slowing down my writing to one stroke every second no strokes are missed.
The Vercel app  works perfectly for me.
It's a real shame because I want to use the excellent excalidraw integration for Obsidian in the same way as is mentioned in the issue above.

@h0uter oops, I thought we've solve this across the board, but apparently it's still a problem when Scribble is enabled. I'll take a look at it later — for now, if you disable Scribble (Apple Pencil settings), it should solve it.

Even I am facing the same issue as shown in video of the OP.

@kishorekumarxyz what device? If Apple with Apple Pen, do you have Scribble enabled or not?

@dwelle I turned off scribble and overall it works well enough, but palm rejection is iffy and iOS’s magnifying glass intermittently appears while writing.

@rememberthis9000 palm rejection now implemented via pen mode: https://twitter.com/excalidraw/status/1488884968243740674

Here's an attempted fix for the Scribble missing strokes issue: https://excalidraw-git-fixscribble-excalidraw.vercel.app/ Lemme know if you can still reproduce!

Hand writing seems to work fine in that version with scribble enabled!

Handwriting works fine for me too!
Up next it would be really cool if we can actually use scribble to write text fields in Excalidraw :)

@h0uter I'm already able to use scribble to write text fields. It's a bit tricky to get spaces detected correctly, though. Is that what you were referring to?

It’s that tricky part that’s annoying. I find that for some reason the text tool deselects itself randomly while I’m writing in scribble. I would love to use text, but it’s just not there… would love to be able to lock the text tool on.

https://github.com/user-attachments/assets/c76b4403-c75f-4980-9db6-2cd21f1b5945

while free hand drawing with apple pencil on ipad pro the UI keeps crashing and keep going to the support web...see the attached video. It is very annoying and is really hard to use. I was planning on using this for my upcoming interview but looks like I may have to find something else.
https://github.com/user-attachments/assets/7d41d7c4-5008-4fa9-81de-6aef9a70994b


Extend overloading of predict_mode, etc to all models, not just Supervised

Resolves first part of  #656.
Used to throw an error:
using MLJ
model = (@load GMMClusterer)()
X, _ = make_moons()
mach = machine(model, X) |> fit!
julia> predict_mode(mach, rows=1:2)
2-element CategoricalArrays.CategoricalArray{Int64,1,UInt32}:
 2
 1

cc @juliohm

Codecov Report

Merging #658 (ec4b8e2) into dev (b5fb660) will decrease coverage by 1.41%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##              dev     #658      +/-   ##
==========================================
- Coverage   85.50%   84.08%   -1.42%
==========================================
  Files          39       39
  Lines        3409     3350      -59
==========================================
- Hits         2915     2817      -98
- Misses        494      533      +39

Impacted Files
Coverage Δ

src/interface/model_api.jl
66.66% <100.00%> (-2.57%)
:arrow_down:

src/measures/meta_utilities.jl
25.00% <0.00%> (-71.67%)
:arrow_down:

src/measures/loss_functions_interface.jl
73.07% <0.00%> (-18.82%)
:arrow_down:

src/composition/abstract_types.jl
40.00% <0.00%> (-17.15%)
:arrow_down:

src/measures/measure_search.jl
50.00% <0.00%> (-6.25%)
:arrow_down:

src/measures/continuous.jl
91.30% <0.00%> (-4.53%)
:arrow_down:

src/measures/probabilistic.jl
61.33% <0.00%> (-1.83%)
:arrow_down:

src/hyperparam/one_dimensional_range_methods.jl
84.34% <0.00%> (-0.14%)
:arrow_down:

src/measures/finite.jl
98.10% <0.00%> (-0.03%)
:arrow_down:

src/MLJBase.jl
100.00% <0.00%> (ø)

... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b5fb660...ec4b8e2. Read the comment docs.


Decompilation Failed for a debug binary

Describe the bug
Decompilation failed for the following example written in rust:
use std::io::{self, BufReader};
use std::io::Read;

fn main(){
    println!("This is a simple test!");

    let mut stdin = std::io::stdin();
    let mut program : Vec<u16> = Vec::new();

    let mut numInsts = 0_u16;

    let mut tmpBuf = [0u8; 2];

    stdin.read_exact(&mut tmpBuf).unwrap();

    numInsts = u16::from_le_bytes(tmpBuf);

}

To Reproduce
Steps to reproduce the behavior:

cargo new example
cd example
change main.rs in the source directory
cargo build for a debug build
load the debug binary into Ghidra

Screenshots

Environment (please complete the following information):

OS: macOS 10.15.7
Java Version: 17.0.7
Ghidra Version: 10.3.1
Ghidra Origin: from github
Rustc: rustc 1.65.0

I'm not able to reproduce this issue anymore with the latest version of Ghidra, and the latest version of Rust. Would you please able to recheck?

Possibly fixed in 11.0 with the initial Rust support that was introduced.


Clarify the usage of CopyDirectory Alias within the documentation

It is not completely clear within the documentation for the CopyDirectory Alias that the source directory itself is not copied and only the contents of the source directory are copied.

Relates to #899


1111 collection res type phase 2

versioning
publishing
collection holds collections

@pkdash please review this pr when you get a chance. thanks

Can one of the admins verify this patch?

@zhiyuli I have left some comments. Once you address those, I can +1.

+1


Android support

i wanna be bussin on my phone, but i can't without an Android app >:(

#154 not happening

fine, i'll do it myself


PyQt5 broken

Issue description
PyQt5 is broken on master.
Steps to reproduce
$ nix-build -A python3.pkgs.pyqt5
qwebchannel.cpp:263:31: fatal error: moc_qwebchannel.cpp: No such file or directory
 #include "moc_qwebchannel.cpp"
                               ^

Technical details

system: "x86_64-linux"
host os: Linux 4.15.1, NixOS, 18.03.git.355de06 (Impala)
multi-user?: yes
sandbox: yes
version: nix-env (Nix) 2.0pre5889_c287d731
channels(root): "nixos-18.03pre126729.2e4aded3669"
channels(rschuetz): ""
nixpkgs: /nix/var/nix/profiles/per-user/root/channels/nixos/nixpkgs

/cc @svanderburg @FRidh

It's building fine on current master. Maybe this was a sandboxing issue.


SD card issue, missing flush method

I could not get the SD card example working.
After some investigation I noticed you are required to call flush() or close() to actually write the buffer to the file.
So I added multiplex.flush(); calls.
To find this didn't work as this method is not implemented.
So I added Multiplex.h:
  virtual void flush() override;
And Multiplex.cpp:
void Multiplex::flush() {   for (uint8_t i = 0; i < _count; i++)   {     if (_enabled[i])     {       _stream[i]->flush();     }   } }
After which everything works as expected.
If you grant me access I can push the PR or feel free to implement it yourself.

Thanks for the issue. (Good catch)
If you fork the repo you can always create a PR.
Better I will pick it up later this week, I am busy adding RP2040 builds to all my repos so I can add that in one go.
Btw your proposal looks ok.

@h3lpd3sk
A new develop branch will be available asap.

@h3lpd3sk
Do you have time to verify the develop branch?
If ok I will merge and release 0.2.5

@RobTillaart
Develop branch resolves the issue indeed! Thanks for your swift action.
I should contribute more to opensource perhaps.
Thanks for pointing out the Fork workflow, I wasn't familiar with it yet.

I should contribute more to opensource perhaps.

One advantage is that bugs are caught by others, sometimes ones you would never imagine.
On the feature side too, capturing (part of) your code into a library can make your projects richer as other people request features / enhancements that you can use into your own projects.

Fun to create and fun to see where your code lands eventually, in fact I get feedback / request from all over the world. Would be nice to see my code also go into space e.g. with a cube satellite, but that has not been confirmed yet.

Thanks for pointing out the Fork workflow, I wasn't familiar with it yet.

Just give it a try on this library to see how things work. (please mention it is a test :)

As the issue is solved, I close it. Feel free to reopen / create an new one if needed.


"Eelement" typo

There's a misspelling of "element" — as "Eelement" — on the main README.md.

Please see PR #71


Fixing waitForDisconnect to wait for disconnects

Prior integration tests drained all data before calling waitForDisconnect(), so were not affected by the condition variable being triggered by any changes to the connection, not just disconnects.
An alternate fix is to change the first 3 tcp proxy integration tests to do what the 4th does and actively drain fake_rest_connection before calling waitForDisconnect(), so waitForDisconnect's wait() can't be triggered by onData.  This would result in arguably cleaner tests, insofar as all data and events will always be accounted for, but leaves us with a confusingly named function and a requirement to do extra work even when it's not relevant to the system under test.    That's a super easy change as well so let me know if you'd prefer I go that route and I'll comment up waitForDisconnect as best I can :-)

I think @lizan opened this patch already a while ago and we decided not to merge it because at the time it was indicative of a test that was not written correctly. In this case, it seems like there is a real reason to do it this way? I'm fine going with this fix if it makes writing tests easier, but perhaps can you add a comment to waitForDisconnect() saying why we do the while loop and what type of testing that is useful for? cc @htuch

Sounds like there is some desire for that drain-by-default behavior.  New patch - stick with the old default behavior, allow an easy override and comment heavily what's going on in both cases :-)


update logger-config for light-controller to query and update logging level

 update logger-config for light-controller to query and update logging level light-4j master


Change from LiteralString to Literal (typing)

Change from LiteralString to Literal (typing)

Thanks mate! @chloedia can you check?


Configuring max pool reusable connections

:tada: This PR is included in version 1.61.2 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


"Cross-Origin-Resource-Policy: cross-origin" header?

Since August 5th jsdelivr has been serving files with a Cross-Origin-Resource-Policy : cross-origin header so that JsDelivr can be used in websites that use SharedArrayBuffer and other newfangled APIs that require cross origin isolation. It would be convenient if unpkg could do the same.
See the corresponding jsdelivr issue:
https://github.com/jsdelivr/jsdelivr/issues/18201

+1 this issue
unpkg needs to send this header, other CDNs such as CDNJS and Googleapis.com send this header

This for example leads to problems when trying to use flutter web (dev builds) with WASM using SharedArrayBuffer buffers to have something "like" threading. (As by default for dev builds<EMAIL_ADDRESS>is used.)


Update b2c starter user flow configuration

More general configuration for b2c user flow.
Add header agent when using auth code to request b2c access token.
Remove unused configuration properties oidcEnabled.
Remove repeated frontend page file greeting.html.
Reuse AAD common class for B2C, and move to common package in spring package.

/azp run java - spring - tests

/azp run java - spring - tests

/azp run java - spring - tests

/check-enforcer override

Approving this PR now, one of the IT passed and Yi Liu is fixing the IT pipeline now.


GitHub API rate limit exceed for  change log generation in large repos (> 3000 issues)

Since I need to fetch details about each issue separately - and GitHub api has limit to 5000 requests per hour - Need to figure out some thing.
Generate second token as temporary workaround?

Just ran into this myself on a large repo. Are there intermediary files created during the run so it can be resumed?

Unfortunately not yet.

What about limiting the amount issues pulled back via a command line arg? I don't really need everything from 2 years ago, just the last few months would be great.
github_changelog_generator --max-issues 500

@sneal  Yep, it's a good idea! I will consider this in next release.

Ok, I added fallback for this error, so version 1.3.11 not crashes anymore - just print warning  message, that rate limit exceed!

There are currently two options in the pipeline to fix this:

Amending missing versions instead of regenerating all of them (#209)
Use octokit/octokit.rb with Faraday HTTP Cache

Example:
project = 'skywinder/github-changelog-generator'

# Enable cache
stack = Faraday::RackBuilder.new do |builder|
  builder.response :logger if options[:debug]
  builder.use :http_cache, store: ActiveSupport::Cache::FileStore.new(File.join(Dir.tmpdir, 'ghclgen')) if options[:cache]
  builder.use Octokit::Response::RaiseError
  builder.adapter Faraday.default_adapter
end
Octokit.middleware = stack
# Octokit.auto_paginate = true

@client = Octokit::Client.new
releases = Octokit.releases project, :per_page => 2
releases.each do |release|
  puts release.inspect
end
tags = Octokit.tags project, :per_page => 2
tags.each do |tag|
  puts tag.inspect
end
issues = Octokit.issues project, :per_page => 2, :filter => :all, :state => :closed
issues.each do |issue|
  puts issue.inspect
end

Is there an eta for when the --max-issues argument fix will be released?

@daviddannunzio next week for sure!

Thanks @skywinder !

Perhaps I'm not building the gem correctly, but I tried running the current master branch using a very low --max-issues number, and I still get rate limit errors. It looks like the --max-issues field does not limit the actual Github call. It just limits the issues we return after we've queried the API. Is this correct?

@daviddannunzio Did you previously hit your rate limit without waiting for it to timeout/reset when you tried it with --max-issues?
Something to keep in mind is that max-issues is not exact because issues are pulled back in pages (30 issues per page). It stops pulling back more issues if it goes over max_issues.

@sneal I believe I waited a full hour before trying to run the command again. I still got the error. Even with --max-issues set to 1.

@daviddannunzio let's move discussion to #76.
If you are sure, that it's a bug - please an issue and put there output logs of the script.

This is a major problem for the project that I'm working on (https://github.com/gravitystorm/openstreetmap-carto) due to the moderately large number of issues and PRs (1322 and 773 so far). It is taking me a while just to implement our initial changelog, since I need to change issue tags, change config values, run github_changelog_generator again to see the results - and then I rapidly run out of API requests. In the future I will run out of API requests before the changelog can be generated just once!
Also, it takes a long time to download all the issues, so iterating our config values is painful.
I investigated the github API briefly. The list of issues (e.g. https://api.github.com/repos/gravitystorm/openstreetmap-carto/issues ) contains last-updated timestamps, so it seems possible to cache the details and only update when the timestamp changes. Do you think this would work? This way, repeated runs of github_changelog_generator would be faster and involve fewer API requests.

@gravitystorm Could you open a separate issue for the caching? (I dig it!)

Hi, sorry to dredge up an old thread.  Ran into the rate-limiting issue when trying to process a very large repo (~12k PRs merged over the history of the project).
It appears that the part that makes the vast majority of requests is fetching issue events, which needs to be done once per issue/PR.  Would it be reasonable, for large repos, to skip this step and instead used the merged_at or closed_at timestamp to determine where in the release history an item should live?
I'm not particularly fluent in Ruby, otherwise I'd offer to help.

@aelavender can you give us example repo for the tests?

Close it in favor of #361


Final Review of Azure Identity Samples, Quickstarts, and Readme assets before Nickel GA

Tracking issue for the final review of Azure Identity Samples, Quickstarts, and Readme assets before Nickel GA.
/cc @scottaddie

We have reviewed the consistency of the readme, quickstarts and samples across all languages and addressed for JS in this PR - https://github.com/Azure/azure-sdk-for-js/pull/18098


Improve SGv2/REST executeQueryAsync()

(from #2213 code review)
RestResourceBase method
  protected Uni<QueryOuterClass.Response> executeQueryAsync(

has a TODO note
    // TODO implement optimistic queries (probably requires changes directly in SchemaManager)

which might be doable as:
return findTableAsync(keyspaceName, tableName, true)
    .onItem()
    .transformToUni(table -> executeQueryAsync(queryProducer.apply(table)))
    .onFailure(t -> {// predicate for matching the optimistic schema failure}).retry().atMost(2);

@ivansenic Looking at this, I think that the problem is not the call sequence itself but that the method eventually called in StargateBridge needs to be executeQueryWithSchema() -- to use cached local copy of schema -- and not executeQuery().
So it seems that we are not actually using optimistic table/schema lookup at all currently (by REST API at least, and I don't think GraphQL does it either) but blocking lookup, incurring that extra roundtrip.

@ivansenic Looking at this, I think that the problem is not the call sequence itself but that the method eventually called in StargateBridge needs to be executeQueryWithSchema() -- to use cached local copy of schema -- and not executeQuery().
So it seems that we are not actually using optimistic table/schema lookup at all currently (by REST API at least, and I don't think GraphQL does it either) but blocking lookup, incurring that extra roundtrip.

We have a ticket for this, let's make it work..

Note: #2355 adds support to sgv2-quarkus-common, to be used by REST API.


Page about maintainers' subcommittee

Followed the template as closely as I could, but the list of members will always be up-to-date on the /lessons/ page, so linked to that. Have not added anything about AMY, because we've never decided who has formal oversight: I believe it should be the admin (Maneesha).
 My branch is up-to-date with gh-pages before issuing this PR - is your gh-pages branch behind?

re: branches up-to-date: nope! I should have made a feature branch for this, but once again I thought it was going to be a quick patch and once again I was wrong :) - I'll do the git surgery to sort this out and get your contribution merged.


CVXPY 1.0: Support 0-element vectors

A nice-to-have feature to simplify some problems.
Support of 0-element vectors for Variables, Parameters and functions of numpy arrays (eg, hstack).
This comes up because I have an optimization problem that is parameterized by a natural number, and sometimes the argument is 0. This results in constructions like:
import cvxpy
import numpy

n = 0

cvxpy.Variable((n,))
cvxpy.Parameter((n,))

x = cvxpy.Variable((1,))
a = numpy.zeros((n,))
cvxpy.hstack([x, a])

This is similar to #344 If it is addressed it will be in 1.0, after the full 1.0 release.


iOS App Build Failure with Precompose ViewModel Library

I encountered an issue while trying to build the iOS app with the Precompose ViewModel library 1.5.1. The error message I received is as follows:
e: Compilation failed: Generation of stubs for class org.jetbrains.kotlin.ir.symbols.impl.IrTypeParameterPublicSymbolImpl is not supported yet

 * Source files:
 * Compiler version: 1.9.0
 * Output kind: FRAMEWORK

This error is preventing me from proceeding with the build. I'm seeking guidance on any possible workarounds or solutions to resolve this issue and successfully build the iOS app. FYI, the android app runs well and there are no issues with the android app.
The kotlin version was first 1.9.10 and i changed it to 1.9.0 still the issue is present.

Are you using inline version of viewModel in composable function? If so can you try non inline version of viewModel and see if it works?

Close as inactive, reopen if you still have the same issue.


How can I pass objects to be used by my resources?

Description
Before, when I used flask_restful i did the following in my create_app function:
my_scheduler = ThreadPoolExecutor(max_workers=2)
api.add_resource(Test, '/test/<int:id>', resource_class_kwargs={'my_scheduler ': my_scheduler })

This way, I could access the same my_scheduler object in each function call of the Test Resource. Now I am trying to do the same with Connexion, but can't find a solution.
What's the right way to do this using Connexion?

This is not possible on a function level, but since Connexion 3, you can do this on a class level using the MethodResolver or MethodViewResolver (docs)


Bump minor version to 12.18

Bumping to ~> 12.18.0 following yesterday's 12.17 release.

👍

Hmm I think we'll need a chef-zero release to make travis happy https://github.com/chef/chef-zero/pull/247

https://github.com/chef/chef-zero/pull/249


networkmanager: 1.20.8 -> 1.22.2, modemmanager: 1.10.6 -> 1.12.2

Motivation for this change
https://gitlab.freedesktop.org/NetworkManager/NetworkManager/blob/1.22.0/NEWS
https://gitlab.freedesktop.org/mobile-broadband/ModemManager/blob/1.12.2/NEWS
Experimental features in NetworkManager are not enabled in this PR.
Things done
Built on master.

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

DHCP: switch "internal" DHCPv4 plugin from code based on systemd to use nettools' n-dhcp4 library.

Do we support that? Are nettools not needed?
I found https://gitlab.freedesktop.org/NetworkManager/NetworkManager/commit/d3c7083f976f0e769d7f0b55c3024084e46667b1 but it does not make it very clear.

@jtojnar I think this is internal which is code in NetworkManager.
dhcp defaulted to internal since the update to 1.20. However I'm already seeing bugreports and fixes because of using this code https://gitlab.freedesktop.org/NetworkManager/NetworkManager/merge_requests/368/diffs.

Looks like the library is vendored so I retract my comment: https://gitlab.freedesktop.org/NetworkManager/NetworkManager/tree/master/shared/n-dhcp4

I full confidence the 1.22.2 is probably more fab.

https://gitlab.freedesktop.org/NetworkManager/NetworkManager/blob/1.22.4/NEWS, ooh :rofl:
There's a fake hash in here, I should probably fix that in the next push.

Built on d7627dd2df9e40ace0d494f25d05f7bcbb18151c
/nix/store/qzr93yjmhnglkvbqfh6184bpiybpvics-network-manager-1.22.4
/nix/store/svcngl3lvnswjrb2cm01bbs1a6s1hyhw-modem-manager-1.12.2

Ok, I've built everything and the only issue was with python-dbusmock which is fixed with the update.


cleanup: SIMD runtime detection

Also cleanup, builds off #131
We can see the overhead improvements in uri parsing for smaller values (where overhead is relatively significant) and we can see it compound in header/count accumulating the overhead of jumping in & out of SIMD.
header/count

1
2
4
8
16
32
64
128

Before
22
39
77
144
283
578
1092
2159

After
21
37
71
135
271
568
1025
2034

uri

1b
2b
4b
8b
16b
32b
64b
128b
256b
512b
1024b
2048b
4096b

Before
7
8
9
11
8
6
7
11
19
34
67
127
270

After
5
5
7
9
6
5
6
9
20
31
60
119
255

cc @Noah-Kennedy

Small enum in lieu of func ptr is marginally better thanks to branch-prediction, observed on header/count:
test header/count_1 ... bench:          21 ns/iter (+/- 5)
test header/count_2 ... bench:          35 ns/iter (+/- 5)
test header/count_4 ... bench:          66 ns/iter (+/- 2)
test header/count_8 ... bench:         130 ns/iter (+/- 53)
test header/count_16 ... bench:         259 ns/iter (+/- 80)
test header/count_32 ... bench:         499 ns/iter (+/- 43)
test header/count_64 ... bench:         978 ns/iter (+/- 195)
test header/count_128 ... bench:        1938 ns/iter (+/- 116)

@seanmonstar Squashed to a single commit cleanup: simd runtime detection, since it's more of a cleanup than a perf improvement as we reverted to the atomic (which shouldn't be an issue in absolute but I would rather fine tune minimizing overhead of runtime feature detection in a separate PR)

I know when I originally added SIMD support to this crate, the is_x86_feature_detected! macro did not get inlined, so the function call was slower than caching in an atomic locally. Inline attributes were later added, so it could be that the cache is no longer worth keeping. Would be good to measure.


fix(ground_segmentation): fix build error in Humble

Description
以下を参考に修正を実施

https://github.com/autowarefoundation/autoware.universe/pull/804/files#diff-544a6a8c6f91999bdab2733dd058d341ceef621c1ae161f05e7fe658f9d364a7L35-R40
https://github.com/autowarefoundation/autoware.universe/pull/804/files#diff-0daa83cb73871768fe4b6c0c85c997da7023506e14206ce17fa429b94f2e9d6bR32
https://github.com/autowarefoundation/autoware.universe/pull/804/files#diff-4fed771cf4c2d7eeb0dcfb255310bccda4874960fff689c8f1ef1cdb96ca4905R58
https://github.com/autowarefoundation/autoware.universe/pull/804/files#diff-433178652c8774a40b0565f5b1f93d10de02a072b448e2e2f3cb603c657693c8R32
https://github.com/autowarefoundation/autoware.universe/pull/804/files#diff-bf17ef89f53943bf9b777b67c356f3b994fb97937d99799928e4504b0c43a63bL20
https://github.com/autowarefoundation/autoware.universe/pull/804/files#diff-bf17ef89f53943bf9b777b67c356f3b994fb97937d99799928e4504b0c43a63bL190-R189
https://github.com/autowarefoundation/autoware.universe/pull/804/files#diff-fec4f505a5843555889b0dc13e05c30eddde0575eb6938222fa7977a5bc7996dL300-R300

Related Links
https://tier4.atlassian.net/browse/AEAP-488
Tests performed

ground_segmentationがビルドできること
Effects on system behavior

Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.

[ ] I've confirmed the contribution guidelines.
[ ] The PR follows the pull request guidelines.

In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.

[ ] The PR follows the pull request guidelines.

Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.

[ ] There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Codecov Report

:exclamation: No coverage uploaded for pull request base (beta/v0.3.16@0ae551e). Click here to learn what that means.
Patch has no changes to coverable lines.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
Additional details and impacted files
@@              Coverage Diff               @@
##             beta/v0.3.16    #466   +/-   ##
==============================================
  Coverage                ?   0.00%
==============================================
  Files                   ?       5
  Lines                   ?     579
  Branches                ?       0
==============================================
  Hits                    ?       0
  Misses                  ?     579
  Partials                ?       0

Flag
Coverage Δ

differential
0.00% <0.00%> (?)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Question: profile: extended

Hi,
How does [$PROFILE$]: extended work. I put it on top of a string and ran it through markdown.geHtmlContent(myString) and it prints [$PROFILE$]: extended without executing it.

+1, have the same issue, how does it work ? Can you be more precise on your readme.md (using it with Java for instance,...) ? Thanks, Colin

OK I got it.
You simply have to add the following \n[$PROFILE$]: extended at the end of the MD string you want to htmlize... and that's it! (in Scala) :
val extended = "\n[$PROFILE$]: extended"
val myMd = getMyMd()
val myHtml = txtmark.Processor.process(myMd + extended)

I don't have a method called getHtmlContent in txtmark, so I'm a bit confused what you mean here.
In the meantime: have a look at com.github.rjeschke.txtmark.Configuration, there you can use forceExtendedProfile() with the builder and supply this configuration to Processor.process(String, Configuration).
Also, [...]: ... should never be visible, because it's a link definition in markdown.
And: the reason I added the extended profile was to keep backward compatibility with regular markdown, while still being able to introduce enhanced behaviour.


Made a button to make/view reviews in game detail page

Related Issue: #261
Tasks I completed in this PR:

Made a form ReviewForm for creating new reviews
Updated the GameDetailView with a FormMixin and LoginRequiredMixin to allow logged-in users to create reviews for games within the game detail page.
Made a ReviewListView and a game-review template. Also updated the URLs to include a URL to the game-reviews page for a specific game
Updated the game-detail template page to include a form to create new reviews

This PR depends on PR #274 that will create a new review entity in the models

https://github.com/uchicago-cs/chigame/assets/81624602/eadcd678-12ef-4159-ac42-0d7bb969694f
You can now leave a review on a game and view a list of a game's public reviews.

I noticed the template page was not displaying the game's name, in my latest commit, I fixed how it is rendered in the ReviewListView

If not supplying anything to a review, the validation error shows twice:
The titles of reviews are not seen in the list view:
Seen more obviously with:

Along with that, the numbers are displayed somewhat oddly. You use the `/5` instead of `/5.00` even though we are doing 2 decimal place floats from 1-5 for ratings.
Along with that, you still display the rating for reviews without one, leading to this odd feature of the UI:
Please address the following:

not displaying None ratings
changing the ratings to show /5.00 to better reflect the numbers for ratings
Actually display rating titles if they exist in the ratings-per-game list view

Issues to create based on enhancing the work in this PR

one to add a visual display (such as filled in stars) to reflect the rating

ie: 4.5 == 4 and a half filled in stars

remove duplicate error messages for review validation

add extra styling/CSS to the reviews in the review-per-game list view to make them look nicer (whatever that means to you).

Please make the requested changes and create issues in the backlog for all listed enhancements
Thank you for your work! this is super cool functionality that you've spearheaded @danielngira. This is quite close to merging!

If not supplying anything to a review, the validation error shows twice:
The titles of reviews are not seen in the list view:
Seen more obviously with:

Along with that, the numbers are displayed somewhat oddly. You use the `/5` instead of `/5.00` even though we are doing 2 decimal place floats from 1-5 for ratings.
Along with that, you still display the rating for reviews without one, leading to this odd feature of the UI:
Please address the following:

not displaying None ratings
changing the ratings to show /5.00 to better reflect the numbers for ratings
Actually display rating titles if they exist in the ratings-per-game list view

Issues to create based on enhancing the work in this PR

one to add a visual display (such as filled in stars) to reflect the rating

ie: 4.5 == 4 and a half filled in stars

remove duplicate error messages for review validation

add extra styling/CSS to the reviews in the review-per-game list view to make them look nicer (whatever that means to you).

Please make the requested changes and create issues in the backlog for all listed enhancements
Thank you for your work! this is super cool functionality that you've spearheaded @danielngira. This is quite close to merging!

Thank you! I have fixed the issue where the reviews list page showed NULL ratings. I also added the reviews title to the the page. I also changed the ratings to be placed </5.00>. Will work on making the backlog issues.

In my latest commit, I fixed a merge conflict in the views.py file


Bug: protect parameters as readonly np.arrays and MappingProxyTypes i…

…nstead of dicts

[X] Closes #177
[X] Tests added: I didnt add the test for the problem with channel parameters that went away, the new code is self-enforcing.
[X] User visible changes (including notable bug fixes) are documented in whats-new.rst: and in Parameters docs

Codecov Report

Merging #183 (72da094) into develop (67bc849) will increase coverage by 0.06%.
The diff coverage is 100.00%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
@@             Coverage Diff             @@
##           develop     #183      +/-   ##
===========================================
+ Coverage    77.26%   77.32%   +0.06%
===========================================
  Files           50       50
  Lines         6346     6364      +18
===========================================
+ Hits          4903     4921      +18
  Misses        1443     1443

Impacted Files
Coverage Δ

pywatershed/base/control.py
93.33% <100.00%> (+0.05%)
:arrow_up:

pywatershed/base/parameters.py
93.10% <100.00%> (+4.21%)
:arrow_up:

pywatershed/hydrology/PRMSChannel.py
95.40% <100.00%> (-0.52%)
:arrow_down:

pywatershed/hydrology/PRMSGroundwater.py
93.97% <100.00%> (+0.30%)
:arrow_up:

pywatershed/hydrology/PRMSSnow.py
90.16% <100.00%> (ø)

pywatershed/hydrology/PRMSSoilzone.py
87.61% <100.00%> (+0.07%)
:arrow_up:

... and 1 file with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Cleanup TODOs related to legacy monitoring configuration

How to categorize this PR?

/area monitoring
/kind cleanup
What this PR does / why we need it:
Cleanup TODOs related to legacy monitoring configuration.
ref: #187
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
N/A
Release note:

The legacy method of providing monitoring configuration via `ConfigMap`s labeled with `extensions.gardener.cloud/configuration=monitoring` has been removed. See [this](https://github.com/gardener/gardener/blob/master/docs/extensions/logging-and-monitoring.md#monitoring) instead.

/assign


fix/RC/XL-9314-nullable-arrays-bug

Description
There is an Apiato bug that prevented arrays of decoded ids to be nullable, due to the HashIdTrait processField() method working over null data. This PR fixes that.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Please upload report for BASE (explorer/production@1233a04). Learn more about missing BASE report.

Additional details and impacted files
@@                  Coverage Diff                  @@
##             explorer/production     #30   +/-   ##
=====================================================
  Coverage                       ?   5.13%
  Complexity                     ?     677
=====================================================
  Files                          ?     100
  Lines                          ?    2767
  Branches                       ?       0
=====================================================
  Hits                           ?     142
  Misses                         ?    2625
  Partials                       ?       0

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Support static file serving

Easy to use static file serving alongside the reverse proxy using the 'try_files' directive with named location technique

Can this get merged?

It's pretty straight forward, so I definitely think so, but I'm not the one calling the shots around here :-)

Ping @jwilder

shouldn't this proxy project stay focused on its mission: Automated nginx proxy for Docker containers using docker-gen?
This would add a new role (webserver) to this project. I like projects that do less but do it right (UNIX philosophy).
If one needs to serve static files, I suggest the use of a container that does the job of serving file in combination with nginx-proxy and not changing nginx-proxy

Normally I would agree with what @thomasleveil wrote, "use specialized tools for every need", but there aren't that many static file serving options out there (https://nbonvin.wordpress.com/2011/03/14/apache-vs-nginx-vs-varnish-vs-gwan/) and this is quite a common scenario.
Achieving this kind of configuration (static files with fallback to the reverse proxy) will still require specialized nginx (or other) configuration even if we were to use a specialized static file server.

Now that nginx-proxy supports per virtual-host configuration files, I don't really see a reason to add this to the default template. Also, it's possible to replace the default template either by bind-mounting it as a volume, or creating a simple Dockerfile that extends the image.
I'm sure there are people that want this, but not everyone. How about an "examples" directory in the repository, accompanied by a README.md that explains what each example does?

@thaJeztah, I'm using the bind-mount technique with my suggested template modification, but given the default behavior does not change for people who don't need/use this feature I think it will be a welcomed addition.

I'm on the fence on this one. Setting up nginx-proxy + an app + another nginx can be kind of tricky in terms of getting the virtual host stuff right. Without multiple paths supports (cf. #47), you'd either have to only use VIRTUAL_HOST on the nginx container that is itself proxying to the app or you'd have to arrange for the static assets to be served from a separate hostname.

I agree with @thaJeztah and @thomasleveil .  Since it is possible to do this with the current features, I think it's better to keep the project focused on a being a proxy for now and add examples or documentation on how to set this up if needed.  Static file serving will likely require other customization hooks for cache control, compression, etc. that I would rather not support right now.

Can anyone give some hints about how to proceed ?

See https://github.com/jwilder/nginx-proxy/blob/master/README.md#per-virtual_host

I followed the instructions, and I tried to add the following to nginx.
location /static/ {
	/usr/src/app/static/;
    }

These where added as a volume named as the host.
When I restarted nginx_proxy, the file was used, but the behavior is not the one I expected :

the index page is not showing my app anymore, instead it shows the "Welcome to nginx".
the /static/ folder returns a 404.

I know that my question might be related to nginx, but if anyone can point me toward the good direction, that'd very nice.
PS : I am using docker-compose to run my containers.

@tanzaho Hey Jean-Christophe! May I asked you back to question you asked a year ago ?

I know that my question might be related to nginx, but if anyone can point me toward the good direction, that'd very nice.


Revert "Update to standard library context package."

Reverts golang/protobuf#275
This is causing breakages for users. Will investigate more in-depth tomorrow.

Could you mention what users this is causing breakages for? Is there a plan to switch to stdlib "context" as some point in the future?

Once Go 1.9 is out with type aliases, then we can do this without drama.

Bump! Go 1.9 is out now. :-)

Unfortunately, the generation of context will not change until there are two releases of Go with type aliases. Thus, when Go1.10 is released, we'll make the change.

Is there a reason for waiting until two releases of Go with type aliases as opposed to versioning one with and one without? Just curious.

It'll be another 6 months or year due to App Engine stuff.