type control changes.

SonarQube analysis reported 4 issues

 2 major
 2 minor

Watch the comments in this conversation to review them.
3 extra issues
Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

 index.ts#L441: Update this function so that its implementation is not identical to the one on line 345.
 index.ts#L592: Remove this unnecessary cast.
 index.ts#L633: Remove this unnecessary cast.

SonarQube analysis reported 4 issues

 2 major
 2 minor

Watch the comments in this conversation to review them.
3 extra issues
Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

 index.ts#L441: Update this function so that its implementation is not identical to the one on line 345.
 index.ts#L592: Remove this unnecessary cast.
 index.ts#L633: Remove this unnecessary cast.

SonarQube analysis reported 4 issues

 2 major
 2 minor

Watch the comments in this conversation to review them.
3 extra issues
Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

 index.ts#L445: Update this function so that its implementation is not identical to the one on line 349.
 index.ts#L594: Remove this unnecessary cast.
 index.ts#L635: Remove this unnecessary cast.

SonarQube analysis reported 4 issues

 2 major
 2 minor

Watch the comments in this conversation to review them.
3 extra issues
Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

 index.ts#L449: Update this function so that its implementation is not identical to the one on line 351.
 index.ts#L596: Remove this unnecessary cast.
 index.ts#L637: Remove this unnecessary cast.

SonarQube analysis reported 4 issues

 2 major
 2 minor

Watch the comments in this conversation to review them.
3 extra issues
Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

 index.ts#L449: Update this function so that its implementation is not identical to the one on line 351.
 index.ts#L596: Remove this unnecessary cast.
 index.ts#L637: Remove this unnecessary cast.

SonarQube analysis reported 4 issues

 2 major
 2 minor

Watch the comments in this conversation to review them.
3 extra issues
Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

 index.ts#L449: Update this function so that its implementation is not identical to the one on line 351.
 index.ts#L596: Remove this unnecessary cast.
 index.ts#L637: Remove this unnecessary cast.

SonarQube analysis reported 4 issues

 2 major
 2 minor

Watch the comments in this conversation to review them.
3 extra issues
Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

 index.ts#L449: Update this function so that its implementation is not identical to the one on line 351.
 index.ts#L596: Remove this unnecessary cast.
 index.ts#L637: Remove this unnecessary cast.

SonarQube analysis reported 2 issues

 2 major

Watch the comments in this conversation to review them.
1 extra issue
Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

 index.ts#L449: Update this function so that its implementation is not identical to the one on line 351.


notify users that there is a new version

add icon on desktop that opens firefox release page

Also related to #52 #69

Thanks @Akshaiy91. Nice work on the version checker


hubble: add missing code documentation

Coverage decreased (-0.03%) to 36.978% when pulling 070f8e103e4081c023d9a6e946979fe1b6de01f7 on hubble-docstring into b0610a4b9a9eac349da5e409a532850fdfe38c18 on master.


通过VelaUX扩展能力进行操作启用禁用都不生效

KubeVela Version
CLI Version: v1.4.0
Core Version: 1.4.0
GitRevision: git-8f7a825
GolangVersion: go1.17.10

@SQGE The reason for this issue is that the query list is preferentially got from the cache, After the definition status changes, it will delay entering the cache. In fact, it has already been changed.


Inconsistent application of standard names and units in topmodel

This takes a little winding around to see what is happening here, so start with this definition of a topmodel output variable.  It claims that output variable p is atmosphere_water__domain_time_integral_of_rainfall_volume_flux with units of m h-1.
Next, look at this input variable which maps to rain and claims to be atmosphere_water__liquid_equivalent_precipitation_rate with units of kg m-2.
We can then see that the BMI Update function passes both of these variables from its struct to the topmodel function.
But when you carefully inspect topmodel, you can see that the code considers these two variables to be equivalent, assigning one to the other verbatim, with no transformation/conversion.
Even under an assumption that kg/m^2 == mm/hr, this doesn't match the units described by the variable p.

The variable name should not include "domain", because we are integrating
over time but not over the model domain.
Integrating over the entire model domain is an area integral.  The rainfall
rate names should be either:
"atmosphere_water__time_integral_of_rainfall_volume_flux"   [canonical
units:  L3  L-2  T-1 = L  T-1] or
"atmosphere_water__time_integral_of_rainfall_mass_flux"   [canonical
units:   M  L-2  T-1]
where:  M = mass, L = length, T = time.
Use of the word "rainfall" in the name, instead of "precipitation" or
"snowfall", etc. indicates that the precipitation
rate is a "liquid equivalent" rate, vs. an actual rate.
Density of liquid water is around:  1000 kg m-3
Density of hail is around:               700 to 900 kg m-3
Density of graupel is around:         50 to 890 kg m-3
Density of fresh, dry snow is around:  20 to 200 kg m-3  (or 10 to 350,
another source)
On Tue, Nov 16, 2021 at 4:19 PM Nels @.***> wrote:

This takes a little winding around to see what is happening here, so start
with this definition
https://github.com/NOAA-OWP/topmodel/blob/479d00684971977bc39f44491515c49fc82ab37e/src/bmi_topmodel.c#L12
of a topmodel output variable. It claims that output variable p is
atmosphere_water__domain_time_integral_of_rainfall_volume_flux with units
of m h-1.
Next, look at this input variable
https://github.com/NOAA-OWP/topmodel/blob/479d00684971977bc39f44491515c49fc82ab37e/src/bmi_topmodel.c#L113
which maps to rain and claims to be
atmosphere_water__liquid_equivalent_precipitation_rate with units of kg
m-2.
We can then see that the BMI Update function
https://github.com/NOAA-OWP/topmodel/blob/479d00684971977bc39f44491515c49fc82ab37e/src/bmi_topmodel.c#L389
passes both of these variables from its struct to the topmodel function.
But when you carefully inspect topmodel
https://github.com/NOAA-OWP/topmodel/blob/479d00684971977bc39f44491515c49fc82ab37e/src/topmodel.c#L168,
you can see that the code considers these two variables to be equivalent,
assigning one to the other verbatim, with no transformation/conversion.
Even under an assumption that kg/m^2 == mm/hr, this doesn't match the
units described by the variable p.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/NOAA-OWP/topmodel/issues/20, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AB2T4LZVA4OD4YGVR7GO2CTUMLRJRANCNFSM5IFRHPVA
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

Sorry, I made an important mistake in my haste.
When the name includes "time_integral", the "per time" units go away, so:
atmosphere_water__rainfall_volume_flux.    [ L T-1]
atmosphere_water__time_integral_of_rainfall_volume_flux.   [ L ]
atmosphere_water__rainfall_mass_flux.    [ M  L-2  T-1]
atmosphere_water__time_integral_of_rainfall_mass_flux.   [ M. L-2 ]
On Tue, Nov 16, 2021 at 8:31 PM Scott Peckham @.***>
wrote:

The variable name should not include "domain", because we are integrating
over time but not over the model domain.
Integrating over the entire model domain is an area integral.  The
rainfall rate names should be either:
"atmosphere_water__time_integral_of_rainfall_volume_flux"   [canonical
units:  L3  L-2  T-1 = L  T-1] or
"atmosphere_water__time_integral_of_rainfall_mass_flux"   [canonical
units:   M  L-2  T-1]
where:  M = mass, L = length, T = time.
Use of the word "rainfall" in the name, instead of "precipitation" or
"snowfall", etc. indicates that the precipitation
rate is a "liquid equivalent" rate, vs. an actual rate.
Density of liquid water is around:  1000 kg m-3
Density of hail is around:               700 to 900 kg m-3
Density of graupel is around:         50 to 890 kg m-3
Density of fresh, dry snow is around:  20 to 200 kg m-3  (or 10 to 350,
another source)
On Tue, Nov 16, 2021 at 4:19 PM Nels @.***> wrote:

This takes a little winding around to see what is happening here, so
start with this definition
https://github.com/NOAA-OWP/topmodel/blob/479d00684971977bc39f44491515c49fc82ab37e/src/bmi_topmodel.c#L12
of a topmodel output variable. It claims that output variable p is
atmosphere_water__domain_time_integral_of_rainfall_volume_flux with
units of m h-1.
Next, look at this input variable
https://github.com/NOAA-OWP/topmodel/blob/479d00684971977bc39f44491515c49fc82ab37e/src/bmi_topmodel.c#L113
which maps to rain and claims to be
atmosphere_water__liquid_equivalent_precipitation_rate with units of kg
m-2.
We can then see that the BMI Update function
https://github.com/NOAA-OWP/topmodel/blob/479d00684971977bc39f44491515c49fc82ab37e/src/bmi_topmodel.c#L389
passes both of these variables from its struct to the topmodel function.
But when you carefully inspect topmodel
https://github.com/NOAA-OWP/topmodel/blob/479d00684971977bc39f44491515c49fc82ab37e/src/topmodel.c#L168,
you can see that the code considers these two variables to be equivalent,
assigning one to the other verbatim, with no transformation/conversion.
Even under an assumption that kg/m^2 == mm/hr, this doesn't match the
units described by the variable p.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/NOAA-OWP/topmodel/issues/20, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AB2T4LZVA4OD4YGVR7GO2CTUMLRJRANCNFSM5IFRHPVA
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

@hellkite500 My reading of the code is that TOPMODEL expects input precipitation in m/h. That means that kg/m^2 is wrong for multiple reasons.


slider value is incorrect when using stepsArray

Steps to reproduce

Use an array for stepsValue, showTicks: true
In the view template render the slider value, ie - {{ slider.value }}
Notice the incorrect value as you interact with the slider

Expected behaviour
Slider value should result in the value of the selected step
Actual behaviour
Slider value looks to result in the index of the step (ie - 0, 1, 3, 4, etc)

This is working as design, see the doc:

stepsArray - Array: If you want to display a slider with non linear/number steps. Just pass an array with each slider value and that's it; the floor, ceil and step settings of the slider will be computed automatically. The rz-slider-model value will be the index of the selected item in the stepsArray.


return for showDialog , add barrierDismissible

add return for showDialog of type Future<List < Int > >
add parameter to Navigator.pop
null for cancel , selecteds for Confirm
so now we could know if user Dismiss dialog and we could get value without any function by doing like that
  var data = await  return Picker(
 .....
    ).showDialog(context);
if(data == null ) // user Dismiss dialog
else { print(data); } // will print data like [1,2]

add [bool barrierDismissible = true] to showDialog

the difference between dismiss and cancel
dismiss : when user click out of dialog
and  close it without call cancel so we couldn't know it close in any way
so i made this change

Thanks!  You have changed the layout of the code. It seems that there are many changes. Let me see at a glance that there are changes all over the place, It's too hard, So I can't merge your code directly...


Review the Travis checks

Look at the "travis_kernel" rule of the Makefile (https://github.com/online-labs/kernel-config/blob/master/Makefile#L173-L175)

cc @aimxhaisse

I just changed the config testing structure, now you need to edit this file:
https://github.com/online-labs/kernel-config/blob/master/tools/c1-checkconfig.sh

I switched again to this script, now you need to update those config files: https://github.com/online-labs/kernel-config/tree/master/tools/configs depending on the kind of kernel you want to check


stored procs

Hi Guys
how would you execute a stored proc, can you please give a guide

Hi Guys how would you execute a stored proc, can you please give a guide

Hi,
In this project, we don't use store procedure, because maintain of store procedure is a little hard. And with ef-core and linq we have more flexibility and easy to maintain.
For using store procedure, you can use dapper or ef-core for calling store procedure directly.


[WIP] Add MP Interactive Tutorial to Stateless Section

This provides the previously discussed/socialized and demoed Interactive Tutorial for configuring Java microservices in Kubernetes.
There will be two PRs of which only one should be accepted.
The first one which places the tutorial under the "Configuration" (/configuration) section in the ToC.
The second PR (this one) has the exact same content, but places it under "Stateless Applications" (/stateless-application) section in the ToC.
Please note that (in both PRs) the Katacoda tutorial is hosted at data-katacoda-id="jamiecoleman/kubeconfig" and not at kubernetes-bootcamp so that will likely need an action to be moved/migrated in Katacoda, and then the PR updated to point at the location in kubernetes-bootcamp

/assign @makoscafee

I followed what the bot instructed and assigned @xiangpengzhao to this PR, and @makoscafee to the second PR which have the exact same content (as per the description in the first comment), but are just in a different location.  Likely only one person should be assigned to both PRs (and only one PR should be approved).

I reviewed #21268
/assign

Hi @mbroz2 .
Just following up on this PR. Are you actively working on these changes?

Hello @mbroz2 .
I am closing this pull request.
At any time, you can reopen this PR to resume work.
/close

Hi, yes, was planning on having an update before the end of this week, just coordinating the changes to both the interactive tutorial (katacoda) and the text for the site. I'll reopen the PR when I have those updates ready.

Thank you for taking the time to provide the detailed feedback, we've been working on incorporating all of it into the Katacoda tutorial and PR for the tutorial page.
The Katacoda environment has been updated to reflect all the comments, with the exception of the HTTP basic auth being used. HTTP was purposefully used as it is not uncommon (especially in private cloud/kubernetes deployments) to terminate TLS at the proxy to reduce processing overhead and it simplifies the example in the tutorial and avoids complexities regarding trusting/managing self-signed certs. In other words, we were avoiding additional complexity and overhead of HTTPS. However, if you believe this is an issue and needs to be addressed, then we can change the environment to support HTTPS.
The tutorial topic page has also been changed to better match the other content under the "Configuration" (and Stateles/Stateful Applications) section, for example the "Configuring Redis using a ConfigMap" and "Example: Deploying PHP Guestbook application with Redis" with the main difference that instead of the instructions being placed on the page, the page instead links out the Katacoda Interactive Tutorial environment. Like the other examples, a light overview of the concepts is provided first, followed by the example section where the user goes more in-depth with the subject, in a hand-on approach. The Kubernetes topics have been moved to the beginning of the section and expanded on, while the Java/MP topics have been moved down and shortened.
Regarding the above comment "At any time, you can reopen this PR to resume work." is that possible, or do I need to open a new PR?

Yes:
/reopen

This also looks like an unintentional /reopen. ☝
/close

Hi @zacharysarah it was meant to be reopened and waiting for a review and approval/feedback, but I missed the bots instruction to assign @sftim.  Reopening and assigning sftim, please see my previous comment for details.
/reopen
/assign @sftim

@mbroz2 this is marked as work in progress; if that's not what you want, you can edit the PR title to remove the “[WIP]”

/nudge

Hi @mbroz2 .
I don't think it makes sense to keep two PRs open for the same tutorial.
I left several comments in PR #21268.
Please select one PR to close.
Thanks!

Hi @kbhawkey,
I'm happy to close this PR and just continue the conversation in PR #21268.  The reason 2 were open was to get feedback whether this guide should go into the Config section (#21268) or the Stateless App section (this PR), and each PR hosts the content under each of those categories.
If it's instead decided that the Stateless App section is a better place for this content then the Config section, then I'll just reopen this PR and close the other one.


echo dot 2 having trouble finding device

I had the echo connected to the unit until I tried to reboot several times. After that I could not get the unit to connect to the echo.
debug output shows the python script responding to the search attempts, but the echo will not fully pair.
What can I do to solve this? I tried to set a default port, but couldnt figure out how to set a static ip or port.
this is the output: (my local network is 192.168.1.x and the python script is running on a raspberry pi on <IP_ADDRESS>
Listening for UPnP broadcasts
got local address of <IP_ADDRESS>
UPnP broadcast listener: new device registered
FauxMo device 'living room lights' ready on <IP_ADDRESS>:39675
Entering main loop
Responding to search for living room lights
Responding to search for living room lights
Please help!

@drinnird I was able to set up Dot 2 with my Raspberry PI using this fork: https://github.com/n8henrie/fauxmo

Thanks!! I'll give it a shot. Turns out my rpi3 was using wifi all of a sudden and connected to the esp8266 sorta without encryption. I noticed something was strange when. No internet traffic was being sent past my router from RPI. Just got the rpi 3 so not used to it having wifi... Noobie mistake. I have it working great with nodemcu lua scripts


Does this client support syncing sessions across all available memcached nodes?

I'd like to use this client to make the memcached installation have session redundancy and be HA - does this client support this?
I see in the readme.md:

Also memcached failover (memcached crash) is supported via migration of sessions.

But I can't seem to find it in the SetupAndConfiguration page. Is it just supported automatically?

Does this client support syncing sessions across all available memcached nodes?

No, in sticky mode msm stores a session only in a single memcached node (as "backup", to support failover). In non-sticky mode msm stores a session in a primary memcached node and for backup in an additional node.

I'd like to use this client to make the memcached installation have session redundancy and be HA - does this client support this?

I'd say yes :-)

But I can't seem to find it in the SetupAndConfiguration page.

What are you missing?

Ok, I think I understand now. In order to get a session stored in multiple memcached nodes, I should set sticky=false when I add it to the context.xml for tomcat, yes?

You should only set sticky=false if you are not going to use sticky sessions. I.e. you must configure your loadbalancer appropriately, this also depends on the web framework you're using.


Option to not push to Git automatically

I'd like to have an option to not push to Git automatically. This is specially useful in CI when you need to do pushes a different way.
sh('git push https://${GIT_USERNAME}:${GIT_PASSWORD}@<REPO> --tags')
is an example we have on Jenkins if we want to push to a Git repository.

Does --post-success run before pushing to Git?


Added binary tree level order traversal.

Changes Unknown when pulling d9c79422ac72cb6eacec2a4605fcd11d209ee8db on binary-tree-level-order-traversal into ** on master**.


⚠ Samsung has degraded performance

In c7cc459, Samsung (https://samsung.com) experienced degraded performance:

HTTP code: 200
Response time: 2339 ms

Resolved: Samsung performance has improved in 6e2f600.


Extend Rancher Release CLI to be able to Tag a Rancher Release

Will need additonal safety checks.

Example:
rancher_cli tag -b dev-v2.8 -t v2.8.1

Checks:

Make sure the user is not on a fork
Verify the format of the given tag
Verify the branch


📖 Capture Alpha Users's Justice identity in order to prepare for migration to new identity strategy

User Story
As as AP engineer, I would like to start collecting AP users' justice identity so we can start preparing to the roll-out of our new identity strategy.
Value / Purpose
A single identity across our estate is the ultimate goal, not only for security reasons but also for easing onboarding onto the platform. All MOJ employees have or could get justice accounts but not everyone uses or needs Github accounts. Linking AP auth to justice identity will help expand our reach.
Useful Contacts
Michael Collins, Julia Lawrence
User Types
AP Users
Hypothesis
If we begin collecting this information now, we will be in a better position to migrate people when the time is right.
Proposal

Add a new page to display to users after logging in, where they can authenticate with their Justice identity
Amend the database structure to allow storage of users' justice identity information.
Amend Control Panel code to request post-auth AP users to authenticate with AzureAD (EntraID) to capture their justice identity.
Validate information is being stored.

Additional Information
Potential questions:
Should we allow new users to register with their justice identity going forward? Is it worth implementing that at the same time so we can lower the number of users we eventually need to migrate?
For QS:
Should we make providing the justice identity as a prereq for new QS accesss? (New UI only allows justice authentiation?)
Things to think about:
Deferral?
"I don't have a justice account?" (More likely with P&A folks)
Definition of Done

[x] New "frontpage" added to the control panel to allow EntraID auth
[x] EntraID auth process implemented
[x] Database schema amended
[ ] Users notified
[ ] Documentation outlining what we're doing and why drafted and published
[ ] Control Panel modified
[ ] Capability switched on

27/3/24
Basic implementation in place - draft PR open with full details
TODO

Confirm the best messaging for the user on the new page (feedback on the draft PR welcome)
Need to add unit tests
Refactoring as necessary

4/4/24
Secret was added as part of https://github.com/ministryofjustice/data-platform/issues/3868, to allow testing on dev.
Created a new release to add always prompt users to log in to their Justice account as part of the flow. Also updated the auth client implementation to use the Azure Client Secret. Currently this is not working (as I wanted to test the error sent to Sentry) - the secret has been added to dev, but a further change to the helm chart is required to set the env variable.

Helm chart updated to set the AZURE_CLIENT_SECRET env.
Updated the messaging shown to the user about capturing their Justice email.
Deployed to dev for the AP team to test.


Support for other than Array array types

We should try to support, at least in calculating spectrum using MPS:

[x] CuArray - this should be relatively simple
[ ] SharedArray - this should be simple
[x] DArray from DistributedArrays.jl - here we might run into problems - will @cast and @tensor work?

Distributed arrays do not work with @cast and @tensor.


Test: Settings editor search improvements

Refs: https://github.com/microsoft/vscode/issues/187959

[ ] anyOS @hbons
[ ] anyOS @bhavyaus
[ ] anyOS @sbatten

Complexity: 3
Create Issue

I have changed the search behaviour in the Settings editor to restrict the number of local and remote search results shown,
and to sort the results by their order within the table of contents (ToC) when the ToC is shown.
Part 1: Sanity testing

Navigate to the Settings editor.
Set workbench.settings.settingsSearchTocBehavior to filter.
Do a search.
Verify that there are fewer results than or the same number of results as on Stable.
Verify that the search results are sorted by ToC order.
Set workbench.settings.settingsSearchTocBehavior to hide.
Clear the search query.
Do another search.
Verify that the ToC hides and that the search results are not grouped by category. For example, a Python setting could appear between two TS settings now.
Set workbench.settings.settingsSearchTocBehavior to filter again.
Clear the search query.
Do another search.
Verify that the ToC shows up and that the search results are in ToC order again.

Part 2: Open-ended testing
Try out different queries in the Settings editor and confirm that the search results make sense.
If a search result doesn't seem to make sense, add the search result that showed up along with the query used to an issue for this TPI.
If a search result seems to be missing, add the the search result that didn't show up along with the query used to an issue for this TPI.

I can confirm all the steps on macOS.
Noticed a some strange things however:

When I search for workbench.settings.settingsSearchTocBehavior and change it from hide to filter, I first need to clear the search field using Backspace for it to take effect on the category sidebar. When I select the search text and immediately start typing without clearing the field first, the sidebar stays empty.

I expect the sidebar to actually hide when in hide mode. It looks weird to have it empty:


Made Website Bandwidth Calculator responsive

Fixes Issue🛠

Closes #1004
Description👨💻
Made Website Bandwidth Calculator responsive.

Type of change📄

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)

How this has been tested✅
Tested locally.

Checklist✅

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have added demonstration in the form of GIF/video file
[x] I am an Open Source Contributor

Screenshots/GIF📷

Merged 🎉!!
Make sure to fill every details properly asked in the PR template from the next time such as Description, How this has been tested etc. @agastya3636

Merged 🎉!!
Make sure to fill every details properly asked in the PR template from the next time such as Description, How this has been tested etc. @agastya3636


Fastnlight: Watch ppdit.shop

Fastnlight requests the watch of the watch_keyword ppdit\.shop. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

ppdit\.shop has been seen in 0 true positives, 0 false positives, and 0 NAAs.

Approved by Jeff Schaller in Charcoal HQ


Remove future module

Please fill in the fields below to submit a pull request.  The more information
that is provided, the better.
Fixes #1297
Description of the changes being introduced by the pull request:
Removes 168 occurrences of pattern from_future_import from 43 files.
With the release of tuf 0.17.0, Python2 is not supported. Therefore, backward compatibility of Python2 by importing future module is not required.
Please verify and check that the pull request fulfills the following
requirements:

[ ] The code follows the Code Style Guidelines
[ ] Tests have been added for the bug fix or new feature
[ ] Docs have been added for the bug fix or new feature

Thanks, commit looks good.
Would you mind getting rid of the extra merge branch 'develop' commit though? I think a rebase on top of develop should do that (and force pushing to this remove-future-module branch is fine).

@jku Thanks for the feedback! I have made the required changes. I have incorporated the latest commits from the main code as well.
Let me know if it looks okay!


HSEARCH-2523 Clarify the Elasticsearch integration is not ready for u…

…sage within OSGi
https://hibernate.atlassian.net/browse/HSEARCH-2523

I didn't mean to close this, sorry.


fix cases of composed line where datapoint is not initialized

This small change fix bug #16 (multiple vcards import cause an error).
Was verified carefully with multiple sets of vcards. all UTs pass.

Thanks a lot @mizrachiran ! @jacquarg or @aenario, could you have a look at this please ?

@mizrachiran Could you add tests?

Hi @frankrousseau,
I added a test, it doesn't check much but it will function as a gate to ensure this functionality.

I would appreciate if you will release an update to the npm package once you merge this change.
Thanks!

Great thank you!

Published as 0.2.14


Use the pkgver() function in all scripts applicable

Use the new Pacstall 1.3 "Amaranth" pkgver() function to fetch the upstream version.
This aims to fix #12

The teams whose code I am changing are:
@pacstall/bashtop-git
@pacstall/blang-git
@pacstall/bpytop-git
@pacstall/notion-git
@pacstall/st-distrotube
@pacstall/tuner-git

@edward-riley @Ganesha2282882 need to review it..

@Henryws Should I merge this? Its been 5 days since the review was requested but @edward-riley, and @Ganesha2282882 haven't reviewed it yet.

yeah


Add GitHub Repository listing

We expect the number of hosted projects to grow, and it would be nice to have a projects listing in a card layout, with a support of grouping and filtering. For inspiration, it could be a layout like https://blueswen.github.io/portfolio/

FTR https://github.com/blueswen/blueswen.github.io/issues/2 for conversing that sample code to a plugin

Sample from https://github.com/oleg-nenashev/repo-listing.github.io/pull/1


2.2.0-10.2.pre points to 2.3.0-0.1.pre

Compare https://github.com/flutter/flutter/tree/2.2.0-10.2.pre and https://github.com/flutter/flutter/tree/2.3.0-0.1.pre
They both point to the same commit. According to the release page 2.2.0-10.2.pre should point to b5017bf and not d72bfb8

This is causing version asserts in CI to break for us even though the commit of Flutter we're using didn't change.

@fkorotkov the tag was accidentally created and is now gone - can you please confirm this solves the issue for you?

Confirm. Everything is working as expected now. Thank you for a quick fix!

Apologies for the trouble. Thx for confirming @fkorotkov.


Cleanup View System

Currently we are using CoffeScript for our views. Just because getting good inference for TS was too hard.
Come up with a better view system just for us.

@vvakame 's code is most excellent : https://github.com/borisyankov/DefinitelyTyped/issues/3638

we have a working view system. For Panels as well as stuff that goes in the DOM. It will become more clear as we create more views.


Does not work on 1.8.1

Flat out fails to load, with an error message from ModTek that BT Performance Fix can not be started during the start-up of BATTLETECH.

If you attach logs, I'll be happy to help you.  With just the provided information there is nothing I can do.

Oh, sorry!
Here are the three logs after the last start-up.
And here's how the game greets me, when I have the mod enabled:
https://steamcommunity.com/sharedfiles/filedetails/?id=1960860250 (link to steam screenshot.)
ModTek.log
ModTek_runtime_log.txt
harmony_summary.log

Error: DLL specified (C:\STEAM-SSD\steamapps\common\BATTLETECH\Mods\BattletechPerformanceFix\BattletechPerformanceFix.dll), but it's missing! Aborting load.
Your install is busted. Bfix isn't loading because it doesn't exist.  Redownload latest release from github.

Mh. I just looked over the github, and the "BattletechPerformanceFix.dll" doesn't exist in any of the  folders found here.
Am I missing something? Is there another github page I need to get the files from? (I might be actually missing how to properly download it from github, in that case.)
I got the "BattletechPerformanceFix" folder and put it in my Battletech Mods folder.

And in that folder, the only files are those:
SQLite.Interop.dll
Settings.json
System.Data.SQLite.Linq.dll
System.Data.SQLite.dll
mod.json

Always use the latest release from here
https://github.com/m22spencer/BattletechPerformanceFix/releases

... That's what I've been doing yes. Sorry, I'm dumb. :-/
Thank you for your help and patience!

Okay, just tested it.
It loads, it works and it's an amazing speed upgrade.
Again, thank you very much!

No problem. Glad your issue is fixed.


Manifest-Conflicts odl "systems" vs "new "system"

Found in debug.log
foundryvtt up to date, dsa-modules up to date.
{"message":"Package dsa5-armory is using the old "systems" manifest key where a "system" key is expected","level":"warn","timestamp":"2021-07-11 14:15:02"}
{"message":"Package dsa5-bestiary is using the old "systems" manifest key where a "system" key is expected","level":"warn","timestamp":"2021-07-11 14:15:02"}
{"message":"Package dsa5-bestiary2 is using the old "systems" manifest key where a "system" key is expected","level":"warn","timestamp":"2021-07-11 14:15:02"}
{"message":"Package dsa5-core is using the old "systems" manifest key where a "system" key is expected","level":"warn","timestamp":"2021-07-11 14:15:02"}
{"message":"Package dsa5-drachenritter is using the old "systems" manifest key where a "system" key is expected","level":"warn","timestamp":"2021-07-11 14:15:02"}
{"message":"Package dsa5-godsofaventuria is using the old "systems" manifest key where a "system" key is expected","level":"warn","timestamp":"2021-07-11 14:15:02"}
{"message":"Package dsa5-introduction is using the old "systems" manifest key where a "system" key is expected","level":"warn","timestamp":"2021-07-11 14:15:02"}
{"message":"Package dsa5-magic-1 is using the old "systems" manifest key where a "system" key is expected","level":"warn","timestamp":"2021-07-11 14:15:02"}
{"message":"Package dsa5-magic-2 is using the old "systems" manifest key where a "system" key is expected","level":"warn","timestamp":"2021-07-11 14:15:02"}

Thats already resolved for the module updates this week.

thx


Website Loading on Mobile Browsers on Safari (latest version) on iOS

Description: Verify the website loads correctly on Safari (latest version) on iOS.
Preconditions: The website https://oportunitatisicariere.ro/ is live and accessible.

Step 2 : Navigate to https://oportunitatisicariere.ro/
Expected Result : The website should load without any visual or functional issues on Safari (latest version) on iOS.

Step 3 : Observe the page load time and any potential loading issues.
Expected Result: The website should load within 3 seconds.

Step 4 : Verify that the layout, images, text, and other elements are displayed correctly.
Expected Result: The page should fully render all elements correctly without visual issues (e.g., broken images, misaligned text).


improve support for FilteredForestConfiguration

Right now if you use FilteredForestConfiguration.withBlackList or withWhiteList, it might hide forests on some hosts.  But that will hide any documents in those forests from QueryBatcher which is unlikely the intention.  Let's either:

make FilteredForestConfiguration populate alternateHost on forests where getPreferredHost doesn't pass the black-list or white-list rules, or
make QueryBatcher recognize when FilteredForestConfiguration is used and keep all the forests in play if not all the hosts, or
make QueryBatcher have a mode that doesn't do forest-specific queries when people want to black-list or white-list

This was done in https://github.com/marklogic/java-client-api/commit/e7d06337d75fd0a19901386b516c0133955f7be3 to fix #642


[GR Phase 3] Step 6 - navigation, default data, logic and API call to save it

Design doc section: https://docs.google.com/document/d/1Y4P7G9h0Easjcea7wyk52gKrNB9o1yTjpmJFYkrHDW4/edit?tab=t.0#bookmark=kix.5lilyt657hrh

Hi! I'm Bartek from Callstack - expert contributor group. I’d like to work on this task.


Allow multiple extra node arguments to be passed

Without this patch, invoking swagger project start --node-args "--harmony --harmony_destructuring" would fail because of passing --harmony --harmony_destructuring  as one argument to node(mon)

Thanks!


Incorrect results?

# Results:

EFI firmware version check:
	[-] ATTENTION - You are running an unexpected firmware version given the model of your system (MacBookPro9,2) and OS build you have installed (16G1114). Your firmware is MBP91.00D7.B00, the firmware we expected to see is MBPro91.00D7.B00.

Highest build number check:
	[-] ATTENTION - You are NOT running the latest release build number of your OS version (10.12.6). Your build number is 16G1114, the latest release build number is 16G1036

I'm seeing this too. It looks like the difference is EFIgy is expecting "MBPro91.00D7.B00" and the system is returning "MBP" and then the exact same numbers. So, the firmware looks like it IS correct, but EFIgy is expecting the wrong thing.

Hey there! We found the issue that could cause out of date results in certain corner cases and patched the API to fix it. If you could, please test whether the returned results for your endpoints are now as expected.
The dataset is up to date with macOS 10.13.3 Supplemental Update (build 17D102 for non-iMac Pro and 17D2102/17D2104 for iMac Pro endpoints). Thanks for your reports!

@Lloir @G60GT @iMatthewCM When you get a chance let us know whether the issue still exists after aforementioned API update so we can go ahead and close this.

I do get the expected results now on my fully patched system. Thank you!

Excellent to hear, we'll close out this issue. Thanks for letting us know about the problem


[Fix #10373] Support top level departments in config

Support for top level departments is added, but there's no support for arbitrary levels of departments at this point. I.e., custom cops can be under various departments, which in turn are placed under a common top level department.
After this change it's possible to, for example, disable all cops in the cookstyle gem by adding to user configuration:
Chef:
  Enabled: false

Note! Only the Enabled parameter is supported. Setting other parameters such as Severity on the top level (when there are two department levels) will silently fail. No warning is shown.

Comments
Adding support for Enabled was relatively easy. Supporting other parameters on the top level seems harder, and it makes me question how useful this change would be and it it's worth the effort. There's currently only one custom cop project that has its own top level, and that's cookstyle, right? And the problem has been worked around by setting default Enabled parameters on the subdepartments there, plus a warning in RuboCop for settings on the top level.

It's a step in the right direction for sure. Before merging this we'll definitely need some warnings and proper documentation, though.

There's currently only one custom cop project that has its own top level, and that's cookstyle, right?

One that I know of. :-)

I'm closing this PR due to no recent activity. Feel free to re-open it if you ever come back to it.


[stable/prestashop] bump dependency mariadb 1.0.2

See https://github.com/kubernetes/charts/issues/1944#issuecomment-327856581


Using async - await with Express router

What version of this package are you using?
$ npx ts-standard --version
10.0.0

What operating system, Node.js, and npm version?
$ uname && node -v && npm -v
MINGW64_NT-10.0-19043
v14.17.3
6.14.13

What happened?
When using async-await with Express everything works as expected but I get an error when linting:
$ npm run lint

> @ lint C:\Users\USERNAME\Repos\express-ts-standard
> ts-standard --fix

ts-standard: Typescript Standard Style! (https://github.com/standard/ts-standard)
  C:\Users\USERNAME\Repos\express-ts-standard\src\router.ts:5:24: Promise returned in function argument where a void return was expected. (@typescript-eslint/no-misused-promises)

Here is my code for the route, I need to use async because I do a lot of request to other apis.
And I dont want to do a lot of nested .then
import { Request, Response } from 'express'
import axios from 'axios'

export const doRequest = async (_: Request, res: Response): Promise<Response> => {
  try {
    const fullURL = 'https://jsonplaceholder.typicode.com/todos/1'
    const requestResult = await axios.get(fullURL)
    return res.status(200).json(requestResult.data)
  } catch (error) {
    return res.status(500).json(error)
  }
}

Here a small repo as example: https://github.com/LuisEnMarroquin/express-ts-standard
I know I can use // eslint-disable-line @typescript-eslint/no-misused-promises
But is probably not good to populate all the code with that comment
What did you expect to happen?
I just want to avoid this warning
Promise returned in function argument where a void return was expected. (@typescript-eslint/no-misused-promises)

Or find a way to properly use async - await according to this rule
Are you willing to submit a pull request to fix this bug?
If it's an easy PR yes

I'm a bit confused by the line number 5 that is reported. What does that pertain to?

@mightyiam operating system, Node.js, and npm version
MINGW64_NT-10.0-19043 === Windows 10 build 19043

@LuisEnMarroquin in this output:
  C:\Users\USERNAME\Repos\express-ts-standard\src\router.ts:5:24: Promise returned in function argument where a void return was expected. (@typescript-eslint/no-misused-promises)

The number 5 refers to line 5 of that file.

That is the function that is imported in router.ts and used with router.get, here is the code:
import { doRequest } from './controller'
import { Router } from 'express'
const router = Router()

router.get('/example', doRequest)

export default router

Here is a small project with 3 files

I think the problem is that you have declared your function to return Promise<Response>, which makes the linter (and users reading the code I think as well) think that express is trying to use the return value of the function. But since the express function is declared as taking a void-returning function the linter believes that you have missed something.
In this specific case, I would recommend either using the Express.js 5.x beta which allows you to do this without the try/catch since it accepts async functions and will catch the error. Or use a small shim that wraps the function for you, e.g:
type Method = 'get' | 'post' | 'put' | 'delete'
type Handler = (req: Request) => Promise<void>
function route (method: Method, path: string, handler: Handler): void {
  router[method](path, (req, res, next) => { handler(req).catch(next) })
}

- router.get('/example', doRequest)
+ route('get', '/example', doRequest)

Hi @LinusU Promise<Response> it's because TS forces me to return a promise, I can use Promise<void> and the problem will persist
The code that you sent me kind of works, but it adds some hard to read code.
And I will have to make the following funcion (that would make code much harder to read) and add a validation is the Handler is Promise<void> of void, so I'm able to reuse it also with not async funcions
const router = Router()
type Method = 'get' | 'post' | 'put' | 'delete'
type HandlerPromise = (req: Request, res: Response) => Promise<Response>
export function route (method: Method, path: string, handler: HandlerPromise): void {
  router[method](path, (req: Request, res: Response, next: NextFunction) => { handler(req, res).catch(next) })
}
export const routes = router

Is there a way I can override that rule on .eslintrc or package.json, tried with this but wont work:
"eslintConfig": {
    "rules": {
      "@typescript-eslint/no-misused-promises": 0
    }
},

Otherwise I'll have to populate almost every route with: // eslint-disable-line @typescript-eslint/no-misused-promises

About express v5 I won't be confortable using it because is still in beta and could cause me some issues later

hi @LuisEnMarroquin  , have solved this issue because i'm getting this same problem but i couldn't find any solution.

@itsritiksingh Aparently the only solution is adding this comment // eslint-disable-line @typescript-eslint/no-misused-promises or using express V5

@LuisEnMarroquin @itsritiksingh
Try express-async-handler:
import asyncHandler from 'express-async-handler'

export const doRequest = async (_: Request, res: Response) => {
  try {
    const fullURL = 'https://jsonplaceholder.typicode.com/todos/1'
    const requestResult = await axios.get(fullURL)
    res.status(200).json(requestResult.data)
  } catch (error) {
    res.status(500).json(error)
  }
}

router.get('/test', asyncHandler(doRequest))

U can also create your own utility wrapper:
const asyncWrapper = (asyncFn: (req: Request, res: Response) => Promise<void>) => {
  function (req: Request, res: Response, next: NextFunction) {
    asyncFn(req, res).catch(next)
  }
}

Also you can use type assertion, which is a bit hacky:
import { RequestHandler } from 'express'

router.get('/example', doRequest as unknown as RequestHandler)


Add buttons to select difficulty of generated sudoku game and add loading screen while game loads

It needs to place something akin to a loading screen as the game board gets fetched by https://github.com/benjstorlie/sudoku-shuffle/issues/5.
It should call some function that updates the current game grid with the board data fetched.
It should then remove the loading screen

You can add const [gameIsLoading, setGameIsLoading] = useState(false); in utils/gameContext.js.
Then you do const {gameIsLoading} = useGameContext() in the game/SudokuGrid.js component, then just put a conditionally-rendered div inside the div#sudoku-grid -- before or after the boxes -- call it #overlay or #coverscreen or #loadingscreen or whatever.
Then, in game.css make sure to add it and include the following in its styling, which will position it on top of the boxes.  See my favorite CSS grid guide to learn more.
grid-area: 1 / 1 / 4 / 4;
z-index: 10

Maybe that's also where the 'you won!' box goes, showing your time and stats.  Or 'the grid is complete, but you still have errors. try again'.

add loading screen while game loads is most likely going to be part of #32


Issue 1761 fix supplier reuse

See https://github.com/temporalio/sdk-java/pull/1777 for background/most thoughts. This is the more ambitious fix that tries to resolve the "not set"/"null" ambiguity.
Closes #1761
Nested Optional didn't feel great, but I preferred it over the other solutions like "an Optional that is also nullable".

Can we add some tests for WorkflowLocal? Just to verify the original issue is resolved and we don't break any existing behaviour?

Added a test that I think shows the various required behaviors:

null initial values are fine
the supplier is called once
set is reflected in a subsequent get

Learning about the SDK as I go, it looks like maybe WorkflowThreadLocal could have the same problem! Want me to throw that into this PR? Not sure what your PR-scoping preferences are.

Yeah I think it will as well, If you don't mind feel free to include a fix in this PR.

Added. It ends up being basically a copypaste, but only two instances of the same behavior aren't an abstraction etc etc.

I believe CI is failing here because your branch does not have tags. I believe you can run git fetch --tags --all

I believe CI is failing here because your branch does not have tags. I believe you can run git fetch --tags --all

Sorry @Quinn-With-Two-Ns, despite having used git for a while, I'm not sure what to do here. I can fetch tags and push them to my fork, but I'm not sure how that is affecting tests, and I'm not sure how to affect a change on this PR. Does my branch need to contain some new tag or something?

Sorry it is not your fault, most repositories testing don't require git tags to work, but this one does for now. The reason your branch needs to contain tags is the gradle files use git to lookup the tags to figure out what current version is. Just pushing tags to your branch should fix the issue
https://github.com/temporalio/sdk-java/blob/18120b164ac5fdbaac894b84353552671b9a0ec9/gradle/versioning.gradle#L5

Ah, there we go; tag-pushing doesn't trigger a CI build. Had to push an inconsequential change to source.


Distribute version is hardcoded to 0.7.3

Don't hardcode the distribute version. Add it as a parameter. The version is in there now to get around annoying MySQL-python minimum version dependencies.

Rather than adding it as a parameter, it has been removed entirely as of #23.


Remove duplicate Python versions from images and use it in our tests

This PR removes a duplicate Python install from the base images - in some cases the versions were different.
I've also updated the ckan image for the correct libmagic dependency.
This PR also uses the amazeeio python 2.7 image to power the ansible testing.  We can move to 3.7 with some modifications.  We will also need to change our "filters as tests" to upgrade to Ansible 2.9
Checklist

[ ] Affected Issues have been mentioned in the Closing issues section
[ ] Documentation has been written/updated
[x] PR title is ready for changelog and subsystem label(s) applied

LGTM. I guess we need a follow-up issue to overhaul tests for ansible 2.9 and python 3?

yes - shouldn't be too hard IMO


The scroll bar will scroll accidentally.

Vue version
3.2.41
Link to minimal reproduction
https://stackblitz.com/edit/vitejs-vite-um8sx7?file=package.json&terminal=dev
Steps to reproduce

Drag the scroll bar to the bottom
click UI anywhere(Click on it a few times and you'll see the scroll will scrolling accidentally)

What is expected?
The scroll bar will NOT scroll accidentally.
What is actually happening?
The scroll bar will scroll accidentally.
System Info
No response
Any additional comments?
this react version
https://stackblitz.com/edit/react-ts-shvbn3?file=style.css,App.tsx
The scroll bar will NOT scroll accidentally.

The scroll bar will scroll accidentally,
only when Drag the scroll bar to the bottom(untill see the three red dom )
opposite, the scroll  will NOT scroll accidentally.

The result of both renderings is same and the height is exactly the same

I can't reproduce but also, the scrollbar handling is not related to Vue. My guess is you are relying on a browser side effect related to how elements are updated/inserted/removed but if you want to control the scroll position, you need to add the code to handle it

I think it has something to do with vue.
react version code and vue version code exactly same,
but react not have this problem

please look at this video
https://www.haolu.com/share/V00VJHGR2G/67fca5c391a751f1bef4a1c67625fa5a
@posva

VUE: https://stackblitz.com/edit/vitejs-vite-um8sx7?file=src%2FApp.vue&terminal=dev
react: https://stackblitz.com/edit/react-ts-shvbn3?file=style.css,App.tsx

and more,
if you Uncomment  59 line code
// r[2].part = '反';
this bug will disappear

I can reproduce it. but I think this might be related to CSS rules. Could you reproduce it after removing all styles?

and more, if you Uncomment 59 line code // r[2].part = '反'; this bug will disappear

still can reproduce.

I can reproduce it. but I think this might be related to CSS rules. Could you reproduce it after removing all styles?

and more, if you Uncomment 59 line code // r[2].part = '反'; this bug will disappear

still can reproduce.
if you remove display: flex rule of body. It will disappear.

done.  this is all css

#reader {
  white-space: break-spaces;
}
[part='一'] {
  color: red;
}

"if you remove display: flex rule of body. It will disappear."
好像并不是. 如果你再手动滚动一下滚动条, 这个bug就会重新出现.
而且这个bug只在"三个一"出现在屏幕的时候出现
It doesn't seem to be. If you scroll the scroll bar manually again, the bug will reappear.
And the bug only appears when "three red color '一'" appear on the screen

So is this really not a vue bug?
@posva @edison1105


ARROW-10106: [FlightRPC][Java] Expose onIsReady() callback

Expose onIsReady() callback on OutboundStreamListener

Add callback to run when the client is ready to receive new data during getStream.
This removes the need for FlightProducers to implement polling code on isReady.

FYI @lidavidm

LGTM, one minor typo - and is it worth adding a test? (Though this is a very thin wrapper around gRPC.)

Thanks. I'm looking to repurpose some existing tests that loop on isReady.

LGTM, one minor typo - and is it worth adding a test? (Though this is a very thin wrapper around gRPC.)

Thanks. I'm looking to repurpose some existing tests that loop on isReady.

I've created a BackpressureStrategy interface and a simple callback-based implementation.
I've used this to repurpose the tests in TestBackPressure to test both polling (existing) and callback-based solutions.
New tests in TestBackpressure are marked Ignored since the tests they were based on were also ignored due to flakiness. I ran them locally though and they passed with similar performance.
I needed to change getStream() to run in a background thread. Currently it gets run in the onHalfClosed callback handler in gRPC. In the test implementations, getStream() is a synchronous implementation which prevented the new callback handler from running. In practice, I'd expect real world getStream() implementations to be written asynchronously though, so perhaps we should change our test implementations of getStream() to be asynchronous instead.

This line of code eventually calls doGet, which must complete before onReady is called (thus, if doGet blocks until a notification from onReady, it never completes. But polling on isReady does): https://github.com/grpc/grpc-java/blob/0b6f29371bd96614fdbdcd3638d4bb6312258da3/stub/src/main/java/io/grpc/stub/ServerCalls.java#L182


Can't figure out how to use EnumVar

I'm trying to use EnumVar but can't figure out the interface and can't find an example for it.
create := token.Command("create", "create a token").Action(cmd.create)
create.Flag("format", "the output format: text, json or curl").Default("text").EnumVar(&cmd.Format, "text", "json", "curl")

I'm a bit of a Go newbie so I assume I'm just missing something, but I think an example in the docs would be useful to others!

Thanks for the heads up, tagged as v2.0.12.

Thanks! Pleased to learn I wasn't being daft!


V017 updates

I've updated some of the endpoints, reformatted it, added call to register_user, it should work now with Pocketbase 0.14.x.

Thank you @Leinnan
I will merge it & test it. It'll push it out in the next version.


fix(v2): tweak colors for announcement bar

Motivation
Make the announcement more prominent.
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan

Related PRs
(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)

See also https://github.com/facebook/docusaurus/pull/2504

@lex111 what do you think of using the default primary color?

It doesn't go well with bg color, IMO.

I changed the color to be black


Configurable aggregation behaviors for time series plots

Context
With query caching support coming soon :tm:, the next bottleneck for displaying many and/or large time series plots is going to be actually rendering them.
While native support for plots in re_renderer seems like the obvious path going forwards in the long term, it'll take a lot of work to get there.
In the meantime, egui_plot is still our best bet.
The plot view currently works by following these rough steps:

Query all the necessary data according to the current visible history query.
Very very costly as of today, but about to be orders of magnitude cheaper with the introduction of query caching.
Iterate through the data in order to generate the appropriate egui_plot primitives (points & lines).
This is generally relatively fast in practice, although it can get very costly for degenerate cases (e.g. all points in the plot have different attributes).
Tessellate the egui_plot primitives.
This happens on the CPU and takes about 3ms for 100k points on my machine IIRC.
Rendering.
Plain old GPU rendering of the generated triangles... but keep in mind: there can be a lot of overdraw!

Proposal
The proposal is to introduce the notion of aggregation functions (MAX, AVG...) to our plot view.
If you squint at it, you can see aggregation functions as a kind of deterministic, user-controlled LOD mechanism.
The idea is straightforward:

Introduce a way of asking the plot what's the range of a tick on the X axis at the current zoom level.

Might or might not exist already, I don't know.
Because it's all immediate mode, there's the usual chicken and egg problem, but I'm sure we'll find a way.

Pre-aggregate the query results based on the range retrieved in step 1, so we get a single value per visible tick.
We're already iterating through all results anyhow, so this won't add much cost.
Only tessellate/render the pre-aggregated results.
Should bring the rendering costs to near 0.

The aggregation function used would be configurable via a spaceview setting (blueprint!).
We would provide all the usual suspects: NONE, MIN, MAX, AVG, P90, P95, P99, P999.
NONE matches today's behavior: you get a faithful albeit potentially very messy and very slow representation of your data.
Anything else is a tradeoff in accurary in favor of performance/visibility. The hover UI would reflect that.
This feature would still be useful even once we switch to re_renderer-powered plots.
TBD

Heuristics: it would probably make sense to default the plots to something other than NONE if there more than N plots or P points in the recording.
How do secondary attributes (color, radius, scattered...) aggregate?
How does aggregation behave with continuous/decimal tick ranges?

great writeup!
I'd love if the answer would be that aggregation are down on the GPU on the fly. But that incurs extra memory "upload" costs and is pretty cumbersome to pull off without compute shaders.


Is anyone working on a SQLTools DuckDB driver as of yet?

We have a use case where it would be awesome to integrate DuckDB into SQLTools and VS Code.
Mirror posted on the DuckDB Issue tracker:

https://github.com/duckdb/duckdb/discussions/5067

I started working on it last week. Here is a brief demo so far using replica of SQLite chinook.db demo file:

I'll be posting more updates on that vscode IDE extension/duckdb driver on twitter: https://twitter.com/TarasNovak/status/1614629029642133504

Preview version of DuckDB Sql Tools VSCode extension is now available in marketplace:
https://marketplace.visualstudio.com/items?itemName=RandomFractalsInc.duckdb-sql-tools

@RandomFractals - Amazing! 😍 Thanks!


Update DFP to handle DISABLED/ENABLED/PASSIVE

Linear Ticket: SDK-1178
Changes:

Updates bootstrap data to use new dfpProtectedAuth type
Updates logic to correctly handle DISABLED, ENABLED, PASSIVE states

Notes:

Checklist:

[x] I have verified that this change works in the relevant demo app, or N/A
[x] I have added or updated any tests relevant to this change, or N/A
[x] I have updated any relevant README files for this change, or N/A

Re-requesting review since the fields have changed again

CC: @danny-stytch to make sure I interpreted this all correctly :)


Password Reset Email does not take into account a subdomain, if it's being used

Laravel Version: 5.7.9
PHP Version: 7.2.11
Database Driver & Version: Mysql, 5.7.20

Description:
When Auth::routes() is registered from within a Route::group that uses the subdomain option, the reset email still only links to the root domain. This isn't ideal for those using subdomains to provide people with their own unique accounts.
I believe this is related to commit cef10551820530632a86fa6f1306fee95c5cac43 where the APP_URL is added to ensure hostname security. Unfortunately, this breaks dynamic generation that url() would typically handle if the hostname wasn't included as part of the argument string.
Steps To Reproduce:
Create a route group for wildcard subdomains, then register the auth routes within that.
Route::domain('{subdomain}.'.env('APP_DOMAIN'))->group(function() {
    Auth::routes();
});

I also have a middleware registered that adds the domain as a URL param:
$subdomain = $request->route()->parameter('subdomain');
if ($subdomain) {
  if ($subdomain != 'admin') {
    // Sends a 404 if the organisation doesn't exist.
    Organisation::where('url', $request->route()->parameter('subdomain'))->firstOrFail();
  }
}

URL::defaults([
     'subdomain' => isset($subdomain) ? $subdomain : null,
]);

Then visit myrealsubdomain.myapp.com/password/reset and submit a password reset request - the URL on the action button will contain the value of APP_URL, without the subdomain.

For the record, i've worked around it by setting APP_URL at runtime in sendResetEmailLink

public function sendResetLinkEmail(Request $request)
    {
        $this->validateEmail($request);
        config(['app.url' => url('/')]);
        // We will send the password reset link to this user. Once we have attempted
        // to send the link, we will examine the response then see the message we
        // need to show to the user. Finally, we'll send out a proper response.
        $response = $this->broker()->sendResetLink(
            $request->only('email')
        );

        return $response == Password::RESET_LINK_SENT
            ? $this->sendResetLinkResponse($request, $response)
            : $this->sendResetLinkFailedResponse($request, $response);
    }

Also worth noting: When resetting the password, the $token argument can become out-of-order thanks to the fact that the subdomain is a request parameter, so the actual reset password page will show an invalid token error, as what it's validating is the subdomain parameter instead.

@danmatthews - I think I saw a PR for that for 5.8 - I think it is fixed there

@laurencei beautiful, thanks all.

@laurencei thanks for pointing that out.

@driesvints @laurencei just actually checked the PR - looks like it solves the token issue, but not the subdomain issue?

@driesvints no problem - i was myself.

Seems I'm not alone with the subdomain issue. RP #29919

Just tried this and I believe this has been resolved with this fix: https://github.com/laravel/framework/pull/32345


[Feature]: Close NavigationMenuContent on Click and prevent pointerleave

Describe the feature
Requesting a property for NavigationMenuContent to be able to close it ONLY on click outside
Current behavior:
When using :disableHoverTrigger="true" on  NavigationMenu component it controls only the opening trigger. But as soon as you leave the content with a pointer - it closes. And I found literally no way how can I prevent or override it.
I need it to close on a click outside content area.
Here is the video to illustrate:
https://www.awesomescreenshot.com/video/31821874?key=d79e8b41de5e2bf0caa2ba0ef0f2688c
disableOutsidePointerEvents on NavigationMenuContent is not an option for me, because I have several links in the Content area and it has to be clickable.
I tried   @pointerenter.prevent with @pointerleave.prevent, @mouseleave.prevent and even @interactOutside, @pointerDownOutside and @focusOutside. No chance.
It would be great at least to get which event is firing in the background and on which component. Maybe it´s still possible to prevent it.
Additional information

[ ] I intend to submit a PR for this feature.
[ ] I have already implemented and/or tested this feature.

Due to the limitation of pointerLeave event, we have added a new props to prevent pointerLeave to close the content 😁
https://reka-ui.com/docs/components/navigation-menu#root disablePointerLeaveClose


Conceptional bug?; culture/locale depends on selected language, not system locale

Hi all,
I was trying to find out why I always get datetime values displayed like this: MM/dd/yyyy in the dialogs/forms even when my computer (from where I browse to the SF project) is set to Switzerland locale which has the following datetime format: dd.MM.yyyy.
While trying to find out the problem, I discovered that Serenity is using the selected language to change locale.
In my example, I was using the english language. When I changed it to german, the date format changed to the desired format of dd.MM.yyyy.
In my opinion, this is conceptionally wrong.
An example: Switzerland has 4 official languages (german, french, italian and rumantsch - and we often use english within applications).
But the locale must not change depending on the selected language - it is still Swiss locale whose date format is dd.MM.yyyy.
So Serenity should read the locale from the browser and use this for formatting datetime fields within dialogs - independent of the selected app language.
Any chance that this behavior could be corrected? :-)
With kind regards,
John

See DetermineProviderCultureResult method UserCultureProvider.cs:
return Task.FromResult(new ProviderCultureResult(culture ?? "en-US", culture ?? "en-US"));

The first one is current culture (formats) while second one is ui culture (texts). It determines the "culture" based on language selected. The culture information sent by the browser is often not enough to determine corresponding .NET Culture. Plus, not everybody is aware of the system / browser culture like you assume. Most expect that when they change the language, they expect the culture to match the language. There is a TwoLetterToFourLetter dictionary there for that purpose. Browser or the language key is just "en", in that case it looks up from that dictionary to match it to a four letter culture, which is "en-US". In case of german, "de" is matched to "de-DE" as it does not have another match in the dictionary.
If you can find the perfect algorithm, which can please all kind of users, please share your completed work with a pull request.


Should DistT be renamed?

As pointed out in https://github.com/typelevel/spire/pull/460, RandomT (or similar) may be more appropriate.

Implemented by #4. I decided that Random as in random variable is the way to go. Dist and similar are reserved for forthcoming implementations of probability distributions.


Improve ephemeral account drift

This PR proposes a series of small changes in an attempt to fix (or improve) the drift we see in production. I have not been able to reproduce (meaningful) negative drift in a test locally and found debugging it on production quite challenging because you want to caveman debug both sides ideally. The following changes definitely improve things, but we'll need to keep following it up.

[x] plug leaks where we weren't withdrawing money from the EA even though we paid for things like PT updates
[x] pessimistically withdraw money from the account in DownloadSector (host only refunds storage revenue on failure)
[x] sync newly created accounts (avoids funding already funded accounts)
[x] reset drift in production (fresh start allows for better follow up)

I considered syncing the account balance when we fund an account. I went back and fourth on that several times but eventually removed it because it more or less makes requiresSync obsolete. The benefit though would be that you are certain the account has 1SC in it after you fund it, while at the same time keeping track of drift. So drift would still build up, but at the very least you have an account with 1SC and you never run into unexpected insufficient balance errors...

@ChrisSchinnerl keep going back and fourth on syncing before funding. I'm lean towards doing it after all


nuxtServerInit function is not called on production but works fine on localhost

I am using nuxt with cloude firebase. Im using nuxtServerInit function to get auth user from cookies. Function works fine on localhost but is not executed on production
In store/index.js
`export const actions = {
async nuxtServerInit({ commit }, { req }) {
const user = getUserFromCookie(req)
if (user) {
await commit('users/setCurrentUser', {
uid: user.user_id,
email: user.email,
displayName: user.name,
});
}
}
}`
Please Help

This question is available on Nuxt community (#c9723)

This fixed it for my static app https://github.com/nuxt/nuxt.js/issues/7051#issuecomment-604914461. Might be worth a try.


[DevX] Add a pre-commit hook to resize images to max width

Resize images capped to a maximum width or height so that size of the repo remains under control
ref: https://ericmjl.github.io/blog/2023/10/14/how-i-made-a-local-pre-commit-hook-to-resize-images/

This task is covered in the dev branch already now. Converted to an issue from the idea list


create_diff is unreasonably slow

Diffing files of ~500 lines with minor differences takes more than a couple minutes, which makes it practically unusable for interactive use.

Which version are you using? Normally, with the latest (0.8.x), #224 should have improved the performance of create_diff.

The version was locked at 0.7, let me try again with 0.8.

Much better ! sorry for not noticing the upgrade :)


(Re)add Python 3.11 support (RC for now)

Codecov Report

Merging #421 (c421cd8) into main (6f541a8) will decrease coverage by 4.17%.
The diff coverage is n/a.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #421      +/-   ##
==========================================
- Coverage   85.36%   81.19%   -4.18%
==========================================
  Files          60       60
  Lines        2228     2228
==========================================
- Hits         1902     1809      -93
- Misses        326      419      +93

Impacted Files
Coverage Δ

...orm/processors/project/merge_requests_processor.py
29.26% <0.00%> (-63.42%)
:arrow_down:

gitlabform/gitlab/projects.py
50.38% <0.00%> (-24.43%)
:arrow_down:

gitlabform/processors/util/branch_protector.py
62.39% <0.00%> (-15.39%)
:arrow_down:

gitlabform/processors/single_entity_processor.py
83.87% <0.00%> (-9.68%)
:arrow_down:

gitlabform/gitlab/branches.py
82.25% <0.00%> (-6.46%)
:arrow_down:

gitlabform/gitlab/core.py
90.07% <0.00%> (-6.11%)
:arrow_down:

gitlabform/processors/abstract_processor.py
83.33% <0.00%> (-2.39%)
:arrow_down:

gitlabform/processors/project/files_processor.py
85.58% <0.00%> (-0.91%)
:arrow_down:


[W.I.P] Updating Contributing.md

Description
Minor edits. More coming around features and pointers to our spec template.
Microsoft Reviewers: Open in CodeFlow

Thanks @paulcam206 :)

will resurrect with updated content


Settings button doesn't do anything

Microsoft PowerToys version
0.76.1
Installation method
GitHub
Running as admin
Yes
Area(s) with issue?
Settings
Steps to reproduce
Pressing the Settings button doesn't do anything - a white screen appears briefly, then disappears. When I left-click on the icon, a white screen appears briefly and then disappears.
PowerToysReport_2023-12-13-10-06-33.zip
✔ Expected Behavior
Click the Settings button to bring up the Settings screen.
❌ Actual Behavior
Pressing the Settings button doesn't do anything, a white screen appears briefly.
Other Software
No response

Where are you clicking the settings button? /needinfo

@TheJoeFin Right-click the PowerToys icon and then click the Settings button. I am using it on Korean Windows 11.

I tried it with an older version, 0.70.0, and the same thing happened.

Try with 0.76.2

@TheJoeFin I just installed 0.76.2 a while ago and tried it, and the same thing happened.

@TheJoeFin Is there any way to work around this?

I can see the crash in the bug report you uploaded, but if you could upload a bug report for 0.76.2 I would appreciate it. One of the fixes between 0.76.1 and 0.76.2 was related to UI crashes and I would like to see if there is a different message in 0.76.2 crash

@TheJoeFin Thanks for your kind help, I've uploaded a bug report as you requested, give me some instructions and I'll try to follow it and get back to you with the results.
PowerToysReport_2023-12-21-15-13-06.zip

I tried a fresh install of 0.78 a little while ago, but I'm still having the same problem.
PowerToysReport_2024-02-05-15-19-50.zip

@youngwoos I am not seeing any crashes on v0.78 in that latest bug report upload. Could you do a screen recording so we can see exactly you are doing and what is happening?

I recorded it as per your request. This keeps happening.
https://github.com/microsoft/PowerToys/assets/29052303/12b9d3b2-1304-47fb-9abf-a4af19afcbd6

@youngwoos thank you for the screen recording. That is helpful to see what is going on. Going through the bug report again I noticed there is no Preferred language. Can you provide a screenshot of your language settings:

Thanks for keeping an eye on it. I am using Korean.

Similar sounding issue #30755

@youngwoos can you try updating to 0.79 and see if this issue persists. I would guess it is related to WinUI3 or WPFUI. Both packages have been updated since this bug was originally opened, so behavior could change.

Thanks for keeping an eye on this. I just installed 0.79 and tried it, and the same problem is happening again. I've attached a bug report.
PowerToysReport_2024-03-19-11-12-20.zip

@youngwoos New update; new request to see if this issue has been solved 😄, how about now in v0.80.1 /needinfo
For context this could be related to a dependency like WinUI3, with each update we pull in new versions and they could solve low level bugs like what you are seeing here.

@TheJoeFin I'm still having the same problem in 0.80.1. Clicking on both Quick access and Settings doesn't bring up any windows. I wonder if it's a conflict with my existing Windows environment
PowerToysReport_2024-05-01-10-27-25.zip
, as it works fine on my new laptop.


Add support for recursive oneof fields

Currently, oneofs that reference a parent type result in compile errors.
By replicating the boxed check in field generation, oneofs may be recursive.
Fixes danburkert/prost#46

Good catch, thanks for the PR.  The CI failure is because the bootstrap test is failing - it's picking up nesting even through a map field.  You can reproduce with cargo test --all.  I think this is a bug even with the original message nesting; we're checking that it's not repeated, but we're not checking that it's not a map field.  Could you add your test case to tests, and extend it with repeated and map fields to make sure those don't box?

I think this is a bug even with the original message nesting; we're checking that it's not repeated, but we're not checking that it's not a map field.

@danburkert Thanks. I've pushed a change with a test case.
Unfortunately, when we check to see whether a oneof variant references an outer type, we don't know whether this reference is through a list or map. This causes the sometimes-unncessary boxing of oneof variants so that the size of a oneof is always known at compile-time.
Updating prost-types to have admit these unnecessary boxes allows the bootstrap test to pass.
I understand that this boxing is undesirable, but I don't understand this code base well enough to propose a solution that does not incur this cost. I'm open to other ideas.

I think I found a relatively simple workaround for the boxing issue.  We'll see what CI says :).

Squashed to master manually.  Thanks again for the PR.  Would a point release be helpful for y'all?

Fixed in 0.2.3.


Add double-quote highlight to SQL

Double quotes are used to wrap identifiers in sql syntax. There currently is no such highlighting for this at the moment in monaco:

It would be great to add this.
Thanks

Just realised this can be achieved using custom themes:
monaco.editor.defineTheme('myCustomTheme', {
    base: 'vs', // can also be vs-dark or hc-black
    inherit: true, // can also be false to completely replace the builtin rules
    rules: [
        { token: 'identifier', foreground: '#23ab23' },
    ]
});

monaco.editor.create(document.getElementById("container"), {
    value: `SELECT count(*) FROM "tablename"`,
    language: "sql",
    theme: "myCustomTheme"
});


[docs] Moving Flutterfire plugins to FirebaseExtended broke many links

Pretty much every link on this page is broken:
https://firebaseopensource.com/projects/flutter/plugins/
Thanks to this commit...
https://github.com/flutter/plugins/commit/3ad2d1d300b0d901ea9739e3b9f08eeebda8be04
Where is the source code now? Just a big treasure hunt. =(

https://github.com/FirebaseExtended/flutterfire/tree/master/packages

Beyond this, there is an infinite number of documentation resources, code links, issues, etc... all broken now. Couldn't have left directories with a README.md file in it?

cc @collinjackson

@lookfirst
This issue has been moved to https://github.com/FirebaseExtended/flutterfire/issues/341. Any further collaboration will be done there.


Add dockerignore file

What
Add .dockerignore file.
Why
Lighter images to make the CI faster and improve the network load.

@wbeuil Yeah, forked PRs can't access to secrets and it needs maintainers approval!
Thanks for your reply.

We added the .gitignore in the latest version of the github-action. I will close this issue. Thanks for your contribution.


Added WinGetUtil E2E tests

Added E2E tests for WinGetUtil project library:

CompareVersions
Download
Log
Manifest
SQLiteIndex

Added reference from E2E test project to WinGetUtil project

Copy dll to output directory

Microsoft Reviewers: Open in CodeFlow

The InstallerMetadataCollection tests are missing, are they to be sent in a separate pr?


Can not add new device: ERROR RPC error 504: Error: DB error (code 504)

I'm was download the keybase app on work computer; next I was try to login them. App was generates a secret phrase for me and was shown a message, what I need to add a new device in my authorized app. When I came home, I was trying to add a new devise as described abow, I was specify the next command:
keybase device add

next I was select the "(1) Desktop or laptop" options and type my verification code. Then I was reseived next messages:
✔ Verification code received.
▶ ERROR RPC error 504: Error: DB error (code 504)

my log id: 9896a1000f6d539ce300cd1c

I think you get this error if your first attempt fails, and then you try to reuse the QR code a second time (or third time). Does it work if you quit the app and then try again?
Thanks for your patience and also the good bug report.
Cc: @cjb and @chrisnojima

@maxtaco I dunno, DB error sounds to me like it's coming from the API server..

Oh, I suppose this could have been during Aurora migration downtime today?

I found the error on the API server, it comes from a primary key violation of trying to insert a 1st message into a KEX session for a second time.  The primary key is on (sessionID, packetSequenceNumber).

(It's sanitized so as not to reveal the SQL running on the server, but the server logs show the full error).

Small clarification: On the work computer I made two attempts to login in app (accordingly, it was generated two codes). On home notebook firstly I was plased first code, gets the error as described abow and then was try again with second code. And received the same error message again
Cc: @maxtaco and @cjb

Did you restart both your phone and your desktop app?  My guess is that you only restarted the desktop ap.

I dont using phone: both app installed on desktop. I restarts the home machine. The work machine I can starts in a few hours. Work machine is off at the moment.

Oh! Yeah, we don't really support this mode of operation.  Both devices need to be online at the same time.  It doesn't work if one is offline and one is online.  Use a "paper key" for that if you don't want to use an iPhone app.

Oh, really.. Okay, I will trying to use paperkey.
When I read the keybase docs I was not unerstanding this. May be you guys can expands the docs, can be added more information about use cases paperkeys & new devices?

And, error message can be more informativelly :)

Hi guys,
I'm also getting this error while trying to add a new computer device. I added a different device (mobile) prior to this and it went well, but not with this one.
First I tried to add it using the new mobile using QR code. After pointing at the QG code, the app took more than a minute and nothing happened so I killed it and retry again. However, since then I always got this error. Even after I tried to use a different device for adding the new one or while not using QR code but rewrote the sentences instead. Always the same error:
There was an error provisioning
RPC error 504: Error: DB error Error code 504: DB_UPDATE_ERROR in method keybase.1.device.deviceAdd

Hello, i am getting the same error when i am trying to add a phone device

I cannot add this device telling me not seen. How do I go about it.


Fix sample calculation in all examples

Propogate validation calculation fix across all examples
What does this add?
This PR makes sure that all validation metrics are calculated correctly when in multiprocess. There still lives the direct example in examples/multi_process_metrics.py, hence why there wasn't an explaination in these
Who is it for?
Closes https://github.com/huggingface/accelerate/issues/350

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.


use UUIDs for unnamed entities to avoid blank nodes

At the moment, all entities are represented with blank nodes. That's not only not a good practice, it also can lead to nodes unintentionally getting merged when we upload data to the graph (because of the blank node numbering rules in Stardog). So instead, we should generate random UUIDs for all unnamed entities in our data.
Here is how that happens in pyNIDM: https://github.com/incf-nidash/PyNIDM/blob/0b27cd8cdfb713ddf950c3c3735eb7f1a2fe57c5/nidm/experiment/Core.py#L25

The place where this should go is the node identifier @id: https://www.w3.org/TR/json-ld11/#node-identifiers

I think the way to go here is to add another special attribute to our models and have it map to the @id special word in the context file. A good attribute name would probably be identifier, but we're currently using this for text labels. So we should probably add a new label attribute and use identifier for the UUID instead.

Another question is: where do we add the identifier? The json files go through our tools twice:

When we first parse the BIDS dataset to produce a BIDS.json file
When we merge the demographic annotator output .json with it

I think 2) might be the better time to add the UUID, because we are considering to support a case where a subject exists only in the demographics file, but not in the BIDS directory. And we are still merging on the subject label / id.

Started working on this

One of the issues is that we're not validating the data before or after the merge. We can do this pretty easily, because the models are already pydantic classes. What is less clear is how validate both the BIDS.json type and the DEMO.json type, because they both will have different attributes modeled.

We also don't just want plain uuid but URIs. So we need to prepend the UUID string with a namespace prefix so that it can be expanded to an URI.
I may not be creative enough to solve this in a clean way, so for now what I'll do is have the default value of the identifier attribute of each class be a uuid string with the "bagel:" namespace prefix. That's not great, because adding the UUID is now hidden from view and ideally it should be done explicitly. We may have to revisit this.

There is a good reason why dandi is separating the UUID regular expressions out from the model https://github.com/dandi/dandi-schema/blob/71a8ea3f8231cc8bf4fadcc51ea76db86171925f/dandischema/models.py#L61: if you don't do that, flake8 gets tripped up and throws a syntax error. So now we do that too.

I noticed a bug where all UUIDs I create are the same. So now we'll need some tests for that and then fix the bug.


Feature request: respect "expand" query parameter when responding to create and update requests

I like the possibility to expand "relation"-type fields - for example, when requesting a photo I can also get a name of album in which this photo is located: client.Records.getOne("photos", "RECORD_ID", {expand: 'album'})
I also like that in response to "update" request I get full record - I can use it to re-render relevant part of HTML. For example, when user first opens an editor, I run:
const record = await client.Records.getOne("photos", "RECORD_ID");
mainDiv.innerHTML=render(record);

And when they click "save" button:
const data = { ... };
const record = await client.Records.update("photos", "RECORD_ID", data);
mainDiv.innerHTML=render(record);

However, these two options don't play nicely together: if I add {expand: 'album'} as an extra argument to both "getOne" and "update" functions, then I see that js SDK adds query parameter in both cases, but pocketbase backend expands the relation only in first case. Probably it would be nice if it was used to to show the expanded data :-)
A workaround is, naturally, to make two requests:
const data = { ... };
await client.Records.update("photos", "RECORD_ID", data);
const record = await client.Records.getOne("photos", "RECORD_ID", {expand: 'album'});
mainDiv.innerHTML=render(record);

so it's not a very big issue, but would be nice to have :-)

I understand your use case. I can't think of a reason why we cannot add it, so I'll consider it for the next minor bugfix/feature release, before starting working on the Dart SDK.

Although this is not a bug, I released it with v0.3.1 since it is fairly small feature.

is there a documentation how this works?
and is it possible to add a new child-relation without an id?

is there a documentation how this works?

It is available in the "API Preview" for each individual collection in the "Query parameters" table section. Currently it has the following description:

Auto expand relations when returning the created record. Ex.: ?expand=rel1,rel2.subrel21.subrel22
Supports up to 6-levels depth nested relations expansion.
The expanded relations will be appended to the record under the @expand property (eg. "@expand": {"rel1": {...}, ...}).
Only the relations that the user has permissions to view will be expanded.

and is it possible to add a new child-relation without an id?

I'm not sure that I understand the question. The expand is only for the return result after model creation. If you are asking for submitting together a base model + a relation together in a single request - this is not supported at the moment because it is ambiguous which collection API rule will apply.

Alright thank you, this answered my question! 👍🏻


Updated version of upload-artifact module in the workflow file

The version that was used before is not supported anymore and leads to pipeline failures.
I, however, do not know how to test that the changed pipeline works, as the pipeline is only executed on the main branch, as far as I see.

Thanks!


Apply delimiter to route param

I have a url that looks like:
http://localhost:3000/r/proud,cozy
And then have a route that looks like:
const nextRoutes = require('next-routes')
const routes = module.exports = nextRoutes()
routes.add('recommendations', '/r/:e')
This returns a query like:
{e: "proud,cozy"}
However I would like this returned instead:
{e: ["proud","cozy"]}
How could I apply a delimiter to the route, so that it knows that there can be one or more ':e', and that it would be split by ','?

Maybe this helps: https://github.com/fridays/next-routes/pull/2
It let's you pass an array to generate a repeat path segment. I think you still have to do .split() when receiving the value (check path-to-regexp)

@fridays is there a way to customize the delimiter character? By default it uses / (%2F) but I would like to use the pipe | instead. My use-case is on query parameters. Example:
Router.pushRoute('Home', {
  items: ['ONE', 'TWO', 'THREE'],
});

http://website.com?items=ONE|TWO|THREE   <-- I want this
http://website.com?items=ONE%2FTWO%2FTHREE   <-- I don't want this


Fixed #32395 -- Allowed capturing stdout of migration signals.

https://github.com/django/django/pull/13890#pullrequestreview-579320176
@felixxm I guess we could also document that pre_migrate and post_migrate are now passed an stdout kwarg since it's not too far fetched to assume it might be useful given verbosity and interactive are already provided.
Happy to adjust the PR in this direction if you think it might be valuable.

@charettes Thanks :+1: Yes, we should document the new argument for the pre_migrate and post_migrate. Please add also release notes.

Thanks for the adjustments and merge @felixxm!


can it be running on docker in Unraid  ?

someone tryed to use it in docker on Unraid ?

I did, try using the docker compose file with the Docker Compose plugin for unraid, but i can't get it to work (yet).
I got an error message :
failed to solve: rpc error: code = Unknown desc = failed to solve with frontend dockerfile.v0: failed to read dockerfile: open /var/lib/docker/tmp/buildkit-mount252714126/Dockerfile: no such file or directory

Ok, I've spent most of my evening trying to make it work. I got to the point where Tabby and its gateway are up and running.
But I can't connect them together (error 400 or 426 depending on what client i use to connect to the gateway)
Even if Tabby Web Docker is able to ping Internet and my local Network, I'm not able to initiate SSH connection.
Still working on it, but I don't know what to do next.

So, I tried everything I can think of without much success. I don't even have a clue on what could be wrong.
I would love to know if anyone was able to make it work.

My solution was just to run a vm for docker. Honestly, you will run into complications when using unraid directly for managing your containers. If you use the compose plugin you can just pass the plugin folder though to the vm but it will not migrate any volumes.


Add Maven generated site for all modules

You will need to take the following steps:

create an empty gh-pages branch using:git checkout --orphan gh-pages
git reset --hard
git commit --allow-empty -m "Initializing gh-pages branch"
git push origin gh-pages
git checkout master

run mvn clean site site:stage to get a locally built site in /$TMPDIR/staging
run mvn scm-publish:publish-scm to upload the generated site, which Github wil publish at https://gaul.github.io/modernizer-maven-plugin/

The site should also be published when using the regular mvn release:prepare and mvn release:perform  cycle
An example is available at: https://mprins.github.io/modernizer-maven-plugin/index.html
close #47

Thank you for your contribution @mprins!  I successfully pushed the page to https://gaul.github.io/modernizer-maven-plugin/ .


Decouples Express and adds request signing verification support

Summary
Addresses #57 and decouples the adapter from express.
Creates a breaking change that adds support for signing secrets (https://api.slack.com/docs/verifying-requests-from-slack) over legacy verification tokens.
This also decouples the adapter from express, which includes adding parsing on the adapter level and refactoring express-middleware.js into http-handler.
Requirements (place an x in each [ ])

[x] I've read and understood the Contributing guidelines and have done my best effort to follow them.
[x] I've read and agree to the Code of Conduct.

fixes #36


Demo for android TV

Does anyone can publish a github repo containing a minimal Demo using Norigin-Spatial-Navigation for AndroidTV?
I am struggling trying to figure out how to code it.
Thanks!

Hello @jeremies.
I assume you are wanting to use react-native in this instance? If so then it should just be a matter of following the example here: https://github.com/NoriginMedia/Norigin-Spatial-Navigation/#using-the-library-in-react-native-environment

Hello @predikament.
Yes, you are correct, we want to use react-native in this instance. I have followed the example https://github.com/NoriginMedia/Norigin-Spatial-Navigation/#using-the-library-in-react-native-environment you gave me with an expo blank app (npx create-expo-app NameApp) and it doesn't work.
Here you have the repo: https://github.com/jeremies/demo-norigin-spatial-navigation-androidtv
This demo has two blue buttons that should change to backgroundColor red when focused. But in an AndroidTV simulator doesn't work because the onFocus event never gets called. We can listen the sound when pressing arrow keys but the focus doesn't move.
How can this be fixed?
Thank you!

Hello again @jeremies,
I cannot see that this example is following the documentation quite as intended.
You are missing initializing the actual library.. : https://github.com/NoriginMedia/Norigin-Spatial-Navigation/#init
And then enabling the native flag: https://github.com/NoriginMedia/Norigin-Spatial-Navigation/#nativemode-boolean-default-false
Please make sure to properly read the documentation before opening issues here. Best of luck to you!

Hello @predikament
Sorry, I have updated the repo https://github.com/jeremies/demo-norigin-spatial-navigation-androidtv with init function, but still doesn't work. Which are the steps that I have to follow to fix it?
Thank you!

Hi @jeremies

Sorry, I have updated the repo https://github.com/jeremies/demo-norigin-spatial-navigation-androidtv with init function, but still doesn't work. Which are the steps that I have to follow to fix it?

I believe the problem is that you need to use the react-native-tvos
Please look at the example that @predikament has provided above (https://github.com/wouterds/react-native-tv-example).
Just to be clear, we don't include any logic for focusing items natively. When your Android app has received focus on your items, then you can sync it with our library.


A crash occurs when installing after packaging the release version

How to delete the NOTICES file generated when flutter packs and packs the apk because there are many urls for the NOTICES generated by relegation such as mobile information security, etc. 2. Re-problem is set by minifyEnabled true and proguard-rules.pro, packaged and released What is the reason for the crash when installing after the version?

@132056135
Check this issue comment for your reference, https://github.com/flutter/flutter/issues/73162#issuecomment-754805450
Closing from here and kindly do not open new issue for same reason.

It's all a problem. The link you gave didn't solve this problem. I publish it here to let others solve it. Can you open it for others to comment? This problem has bothered me for a long time and needs to be solved urgently now

@132056135
查看此问题评论以供参考，#73162（评论）
出于同样的原因，从这里关闭，请不要打开新问题。
都是问题。你给的链接没有解决这个问题。我把它发布在这里让其他人解决它。你能打开它让别人评论吗？这个问题困扰我很久了，现在急需解决


Tailwind v4 support & docs

Added support for Tailwind v4 and documentation of the setup process

We are waiting for version 4 to be out of alpha. Once it is out, we will check its support 🫡

https://tailwindcss.com/blog/tailwindcss-v4-beta :)

You can now use the plugin with Tailwind v4 https://docs.rombo.co/tailwind/installation

Hi,
Thank you very much for your work.
It seems that when using tailwind v4 i must use --legacy-peer-deps. Is it expected ?


set numpy version to fix deps conflict

Type of Change
fix conda install deps concflict
Description
detail description
JIRA ticket:
Expected Behavior & Potential Risk
conda install success
How has this PR been tested?
local test
Dependency Change?
no

local conda test: https://inteltf-jenk.sh.intel.com/job/lpot-release-wheel-build/16552/

local test for 3.9: https://inteltf-jenk.sh.intel.com/job/lpot-release-wheel-build/16563/

local test for 3.10: https://inteltf-jenk.sh.intel.com/job/lpot-release-wheel-build/16566/

final test：https://inteltf-jenk.sh.intel.com/job/lpot-release-wheel-build/16584/

Try with python 3.8

test with 3.8: https://inteltf-jenk.sh.intel.com/job/lpot-release-wheel-build/16814/


Update AirlineApplication.scala

Important planning issue can happen if both information aren't checked at same time.

Great!
Maybe will just tab in the code block but otherwise this looks good!
Thank you! @Eric1212

Great!
Maybe will just tab in the code block but otherwise this looks good!
Thank you! @Eric1212

Thanks, do you need me to arrange the code or you need to check something before autorising the PR ? @spencerm

No update required to be compatible with new version. Can be merged.