EOSJS issues with fetch() in Safari

Version of EOSJS
Last tested with "eosjs": "20.0.0"
Describe the bug
fetch() requests fail in Safari. I believe this issue documents the same if not a similar bug: https://github.com/github/fetch/issues/447
To Reproduce
Initialize an instance of eosjs with json rpc and fetch being node-fetch. Make any rpc request such as get_info() and it will fail in the browser. I'm not 100% certain why this occurs, but it seems to be a Safari-only related issue.
Expected behavior
fetch() should succeed, it works fine in Chrome/Firefox/Edge.
Additional context
This can be resolved by supplying your own fetch() function in place of node-fetch using axios. I'm sure there's a solution using fetch() but this was the first fix I tried that worked and was pretty simple.
        async function axiosFetch(url, args) {
            let result = undefined;
            if (args.method == 'GET') {
                result = await axios.get(url);
            }
            else if (args.method == 'POST') {
                const body = args.body;
                result = await axios.post(url, body);
            }
            return {
                ok: true,
                json: async function() {
                    return result.data;
                }
            }
        }

This should work fine as eosjs only makes POST type requests:
            const f = this.fetchBuiltin;
            response = await f(this.endpoint + path, {
                body: JSON.stringify(body),
                method: 'POST',
            });

You shouldn't have to use node-fetch if you're running in the browser as all modern browsers already include fetch. You only need to specify the fetch argument if:

You're running in nodejs: https://github.com/EOSIO/eosjs#json-rpc (use node-fetch)
You want to override a browser's default fetch behavior

Is your browser on this supported list? https://caniuse.com/#feat=fetch

I'm aware you shouldn't have to but this shouldn't cause issues if you do is what I'm pointing out. However, I had a user test with the newest version of Safari and they don't seem to be experiencing any issues so I'm wondering now if the user who reported this problem to me originally was on an older version of Safari. I'll double check with them... Going to close issue for now...


Bug: $generateHtmlFromNodes doesn't work inside of registerUpdateListener and editorState.read

I can't use $generateHtmlFromNodes the same way as I use $convertToMarkdownString to store the editor state somewhere.
Uncaught Error: Cannot use method in read-only mode.
    at errorOnReadOnly (Lexical.dev.js:5113:1)
    at new LexicalNode (Lexical.dev.js:5886:1)
    at new ElementNode (Lexical.dev.js:6613:1)
    at new ParagraphNode (Lexical.dev.js:8153:1)
    at ParagraphNode.clone (Lexical.dev.js:8159:1)
    at $cloneWithProperties (LexicalSelection.dev.js:23:1)
    at $appendNodesToHTML (helpers.ts:128:1)
    at $generateHtmlFromNodes (helpers.ts:113:1)

And if I run it outside of editorState.read I'm getting:
Uncaught Error: Unable to find an active editor state. State helpers or node methods can only be used synchronously during the callback of editor.update() or editorState.read().

Lexical version: 0.3.0
Steps To Reproduce

add a plugin listening to editor changes
try to serialize state

Link to code example:
function MyFunPlugin() {
    const [editor] = useLexicalComposerContext()

    // @ts-ignore
    editor.registerUpdateListener(({editorState}) => {
        editorState.read(() => {
            const tmp = $generateHtmlFromNodes(editor)
            console.log(tmp)
        })
    })
}

export default function RtfEditor() {
    return (
        <LexicalComposer initialConfig={editorConfig}>
            <MyFunPlugin />
// ...

The expected behavior
I can serialize editor state to HTML to store it in a local file.
PS it would be nice to update docs too, since the given example doesn't work:
https://lexical.dev/docs/concepts/serialization#lexical---html

This is because EditorState is independent of Editor, but in order to generate HTML we need to have knowledge of all the Lexical nodes in a given editor. You can instead use editor.updateinstead ofeditorState.read`. If an update doesn't actually update anything, it gets discarded as an optimization feature :)

I think this issue is fixed, right? Can you close this? @obask

I have still the same problem with serialize Lexical to HTML

My solution (combined with OnChangePlugin):
  const [html, setHtml] = useState<string>('')

  const onChange = (editorState: EditorState, editor: LexicalEditor) => {
    editor.update({
      const raw = $generateHtmlFromNodes(editor, null)
      setHtml(raw)
    })
  }

  return <OnChangePlugin onChange={onChange} ignoreSelectionChange />

ignoreSelectionChange because i wanna serialize all the state and without this flag my app is freezing if any tables are there

My solution (combined with OnChangePlugin):
  const [html, setHtml] = useState<string>('')

  const onChange = (editorState: EditorState, editor: LexicalEditor) => {
    editor.update({
      const raw = $generateHtmlFromNodes(editor, null)
      setHtml(raw)
    })
  }

  return <OnChangePlugin onChange={onChange} ignoreSelectionChange />

ignoreSelectionChange because i wanna serialize all the state and without this flag my app is freezing if any tables are there

Thanks so much for this! Don't know if the update method changed since then, but you do now have to do it as a callback function:
  const onChange = (editorState: EditorState, editor: LexicalEditor) => {
    editor.update(() => {
      const raw = $generateHtmlFromNodes(editor, null)
      setHtml(raw)
    })
  }

https://github.com/facebook/lexical/issues/2587#issuecomment-1449165003
editor.getEditorState().read(() => $generateHtmlFromNodes(editor, null)

using in combo with ref/onSubmit handler
const editorRef = useRef(null);
<Editor ref={editorRef} />;

  const handleSubmit = (e: React.FormEvent) => {
    e.preventDefault();
    const editor = editorRef.current;
    const htmlString = editor
      .getEditorState()
      .read(() => $generateHtmlFromNodes(editor, null));
    console.log(htmlString);
  };

import { $generateHtmlFromNodes } from "@lexical/html";
import { useEffect } from "react";

const HtmlGeneratorPlugin = () => {
  const [editor] = useLexicalComposerContext();

  function printHtml() {
    editor.update(() => {
      const html = $generateHtmlFromNodes(editor, null);
      console.log(html);
    });
  }

  useEffect(() => {
    editor.registerUpdateListener(() => {
      printHtml();
    });
  }, [editor]);

  return null;
};

export default HtmlGeneratorPlugin;

@samadfullstack can't get how you store html string


cannnot register the server's public key

Required Info

Camera Model
D400

Firmware Version

Operating System & Version
Linux (Ubuntu 16.04)

Kernel Version (Linux Only)
4.10.0-28-generic

Platform
PC

SDK Version

Issue Description
hi, I attempted to install by referring to this site, but an error occurred.
when i run sudo apt-key adv --keyserver keys.gnupg.net --recv-key 6F3EFCDE
i got the error
?: [fd 4]: read error: Connection reset by peer
gpgkeys: HTTP fetch error 7: couldn't connect: eof
↓
cannnot register the server's public key...

Hello @agari1229 ,
even though the symptoms are not identical - please check if this could be due to firewall #1276

Experiencing similar issues, trying solution suggested by @ev-mp results in following output:
sudo apt-key adv --keyserver hkp://keys.gnupg.net:80 --recv-key 6F3EFCDE
Executing: /tmp/tmp.VMct9acML8/gpg.1.sh --keyserver
hkp://keys.gnupg.net:80
--recv-key
6F3EFCDE
gpg: requesting key 6F3EFCDE from hkp server keys.gnupg.net
gpgkeys: key 6F3EFCDE not found on keyserver
gpg: no valid OpenPGP data found.
gpg: Total number processed: 0
gpg: keyserver communications error: key not found
gpg: keyserver communications error: bad public key
gpg: keyserver receive failed: bad public key

[Realsense Customer Engineering Team Comment]
@willemremie, @agari1229
Do you still have problem retrieving the key? I tested on my Ubuntu 16.04 with both address start with "hkp://" or without it, both can retrieve the key without problem.

@RealSense-Customer-Engineering, the problem is still persistent, however, I've managed to retrieve the key at my home network. I wasn't able to do so on company network, even with the fix provided by @ev-mp.

Sure, I only wanted to mention it. Apparently some networks have dicculties retrieving the key. Maybe make a note in the documentation?

[Realsense Customer Engineering Team Comment]
Okay, I will follow up to add this into the document. Thank you.

sorry for opening this again but I had the same issue at my home network, I fixed it by going from the 5 GHz wifi to 2.4 Ghz


add dependabot.yml

A quick PR to get dependabot running for our workflows. I will raise more PRs for further improvements

Raised in #55


Question about structured buffers

I'm having an issue with reflection information in glsl. A constant buffer declaration of the following format
struct MyStruct
{
    float a;
};

cbuffer g_MyStruct_CB
{
    MyStruct g_MyStruct;
};

gets translated to
layout(std140) uniform g_MyStruct_CB
{
    LargeScaleAOParams g_MyStruct;
} _709;

However, a declaration for structured buffers like the following
StructuredBuffer<MyStruct> g_RO_MyStruct;

gets translated into
layout(std430) buffer _18_20
{
    MyStruct _data[];
} g_RO_MyStruct;

where I would expect
layout(std430) buffer g_RO_MyStruct
{
    MyStructuredBuffer _data[];
} _18_20;

I find this to be a little bit inconsistent and it's throwing off the reflection queries we do later (as we get back _18_20 instead of the name of the structured buffer). Is this intended or an overlook?

Hi, yes. Block reflection information is known to be a bit annoying atm. In HLSL, the "block" type is basically nothing, it's the "variable" name which is most relevant. However, in GLSL, the "block" name is the significant name, like
uniform BlockName { ... } internal_useless_name;

In HLSL, it seems to be
uniform UselessName { } NameOfCbuffer

The workaround is using compiler.get_name(res.id).

Similar issue is: https://github.com/KhronosGroup/SPIRV-Cross/issues/195

Am I correct in thinking I can work around it by setting the block name to the useless name and viceversa through the reflection API? Ideally, we'd have this swapped by default if just for consistency.

yup, that works too. You can override the name of the block by setting compiler.set_name(res.base_type_id, "blockName")

It's a bit of a hassle though ^^ because it seems to validate the names so as not to repeat them? Anyway, it's possible so I'll work around it like this for now.

Yup ... There's no obvious solution here because doing this stuff automatically could be just as confusing. It might be best to add a utility function which would fix up block names automatically, but it'd have to be an explicit step.

I think this is a bug though. Why is doing it automatically as confusing? Reflection APIs that parse glsl surely treat the internal name (the instance name) and the real name (the name after the keyword uniform or buffer) in the same way?

Hm ... So, to make sure I understand the problem fully:

When declaring a StructuredBuffer in HLSL, a buffer block is emitted such that:
The block type has no name (some internally generated type).
The instance name is whatever the name of the StructuredBuffer is.

When reflecting for the block name, you get some weird, useless name back, because SPIRV-Cross is returning the block name, rather than the instance name.

When compiling to GLSL, the block name is not set, so SPIRV-Cross will invent some magic name for it, but the instance name "makes sense".

The solution you want is:

When reflecting for the block name, you'll want the instance name if it exists and block name does not exist.
When compiling to GLSL, if block name doesn't exist, use the same fallback as for reflection.

Well, to be fair SPIRVCross seems to return the useful name when I query it (so res.name or calling compiler.get_name(res.id) actually returns the useful name), the issue is that for one platform we use glsl as input to another compiler, and that compiler's reflection expects the useful name to be consistent with the constant buffer naming convention.
I can't seem to get the internal name though, no matter what I try.
compiler.get_name(id) returns the useful name,
compiler.get_name(type_id) returns empty, and
compiler.get_name(base_type_id) returns the useful name too. (?)

So:

compiler.get_name(id) returns the instance name (name of the block variable itself basically)
compiler.get_name(type_id) is generally meaningless. It is the pointer to the block, or an array of the block type. You generally just use this to figure out if you have a descriptor array.
compiler.get_name(base_type_id) returns the name of the block itself.

What do you mean by "internal name" here?

Sorry, I called internal name the useless name.

Oh ... I see what's going on ... HLSL now actually emits the name for both block and variable, but GLSL backend is probably tripping up the names because block and instance name alias and it cannot emit both ... This is clearly a bug, yes.

If by BlockName you mean
layout(std430) buffer BlockName
{
    StructName _data[];
} InstanceName;

then I think I'd be good with it. In my case I care about the name I've given to the block, not so much to the instance of it.

Ok, I'll make sure that BlockName always take precedence (and InstanceName will be a fallback), rather than other way around.

@redorav I have devised a solution which should solve your problems: https://github.com/KhronosGroup/SPIRV-Cross/pull/355. get_remapped_declared_block_name should be a bullet-proof way to figure out what the block was declared as in the shader.

That's great thanks! I'll try it out this week hopefully


Add an import module for dicty

We need to add an dicty_import file to define dicty GO terms
Blocked on: https://github.com/dictyBase/migration-data/issues/6

Hello @cmungall
Is there anything you need me to do to complete this ? I might unassign myself if not!
Pascale

@cmungall I don't know what I need to do here. Unassigning myself.

@cmungall - does this pull request need to be merged (looks like it has conflicts now), or should I just re-do the changes?


Prepare branch 3.4 for a release

https://hibernate.onjira.com/browse/HSEARCH-885

Isn't there a backward incompatible performance change between previous versions on Lucene and this version that would make this move unwise?

you' re right.
We could backport my workarounds for the Lucene changes, but maybe it's more effective to not upgrade Lucene. However this was asked for by other users, as Lucene fixed many bugs as well.
Closing this for now, revived the mailing list on the subject.

I don't have a strong opinion, but given that, as Sanne was saying, the most requested feature was a Lucene upgrade I would have voted for a Lucene upgrade as well. It's a trade-off between the fixes it offers against the new issues it introduces. Obviously it fixes some quite big bugs at the costs of performance. AFIR it does not introduce (known) bugs.
For this reason, I would support an upgrade. If performance becomes an issue the user will just have to upgrade Search.
My 0.02$

I'm a bit concerned about the Lucene upgrade in a micro version;
I would release this with current Lucene, and leave the options open for a 3.5 using latest Lucene at a later time, including the backport for the performance workaround, if we really think we will need a 3.5 (I guess currently we think not).

[this is in contrast with my own opinion, as I had initially proposed to upgrade.. ]

fair enough


Version 4.X of yq can't be used for "make generate"

When using yq version 4.18.1 (latest) I get the following issue:
➜ make generate
git submodule update --init --remote
Error: Parsing expression: Lexer error: could not match text starting at 1:1 failing at 1:1.
	unmatched text: "r"
Error: Parsing expression: Lexer error: could not match text starting at 1:1 failing at 1:1.
	unmatched text: "w"
make: *** [Makefile:17: generate] Error 1

This works if I run with 3.4.1 which is the last 3.X release.

This should be fixed with #54


[v2.7] net: gptp: type mismatch calculation error in gptp_mi

Interpreted from https://github.com/zephyrproject-rtos/zephyr/pull/44256
The NSEC_PER_SEC is an unsigned integer macro. Thus, -NSEC_PER_SEC will be treated as unsigned integer as well which lead to calculation error on 64bits integer variables.
The type mismatch causing nanosecond existed 9 digits value when passing to ptp_clock_set() API at gptp_update_local_port_clock():

The associated PR was merged


Add build timestamp to the built binary

We can show this info on the /status and /config-running pages.

This is how the top header looks like today:

it's been done already. https://github.com/cloudprober/cloudprober/pull/212


Results difference after converting a tensorflow op to TfLite

System information

Have I written custom code: No
OS Platform and Distribution: MacOS 10.15
TensorFlow version: 2.0
Python version: 3.6.9

Describe the current behavior
I converted a Tensorflow model with only one Tensorflow Keras layer tf.keras.layers.Conv2D to TFLite and ran the TFLite model. There was no quantization when converting the model.
Describe the expected behavior
The expected output of the TFLite model should be the same as the output of the Tensorflow model. However, the output of the TFLite model is slightly different from the result of the original Tensorflow model. I'm not sure whether this is a bug of TFLite framework or there was something wrong when I converted the Tensorflow model toTFLite.
Code to reproduce the issue
import tensorflow as tf

input = tf.keras.layers.Input(shape=(224, 224, 3), dtype='float32')
output = (filters=64, kernel_size=(7,7), strides=(2,2), padding='valid', data_format="channels_last", activation='linear', dilation_rate=(1,1), bias_initializer='zeros')(input)
tfmodel = tf.keras.Model(inputs=input, outputs=output)

x = tf.random.normal([1,224, 224, 3], dtype=tf.float32)
tf_y = tfmodel(x)

conv = tf.lite.TFLiteConverter.from_keras_model(tfmodel)
lite_bytes = conv.convert()
interp = tf.lite.Interpreter(model_content=lite_bytes)

input_index = interp.get_input_details()[0]['index']
output_index = interp.get_output_details()[0]['index']
interp.resize_tensor_input(input_index, [1, 224, 224, 3])
interp.allocate_tensors()
interp.set_tensor(input_index, x)
interp.invoke()
lite_y = interp.get_tensor(output_index)

Other info / logs
The issue is similar when the Conv2D layer is replaced with BatchNormalization layer.

@MonicaGu I ran your code and find very very small mismatch (in the 7th decimal) in the results between keras  and tflite_model. Do you see significantly different results. Please check the gist here. Thanks!

@jvishnuvardhan In my case, I also found very small mismatch in the 7th or 6th decimal. I am not sure is this small mismatch inevitable? Or is this caused by a bug in the computation of Conv2D in TFLite? Thank you!

It's expected behavior. Since floating point has limited precision, calculated results can be vary by order of execution.
https://en.wikipedia.org/wiki/Floating-point_arithmetic#Accuracy_problems
You can see we're allowing 1e-5 (0.00001) errors in our TFLite kernel testing.
https://github.com/tensorflow/tensorflow/blob/master/tensorflow/lite/kernels/conv_test.cc#L819
So the 7th or 6th decimal difference looks good.


[4.1] MCPWM second fault line broken (IDFGH-4194)

Environment

Module or chip used:  [ESP32-WROOM-32
IDF version (run git describe --tags to find it):
v4.1
Build System:         [idf.py]
Operating System:     [Windows]
(Windows only) environment type: [ESP Command Prompt].
Using an IDE?: [Yes (VS Code)]
Power Supply:         [Battery]

Problem Description
I use two fault signal. In ver 4.1 work only first. This same code work correctly with 4.0.
Code to reproduce this issue
void h_bridge_create(int output_a, int output_b, int input_pwm, int input_shutdown)
{
	mcpwm_gpio_init(MCPWM_UNIT_0, MCPWM0A, output_a);
	mcpwm_gpio_init(MCPWM_UNIT_0, MCPWM0B, output_b);
	mcpwm_gpio_init(MCPWM_UNIT_0, MCPWM_FAULT_0, input_pwm);
	mcpwm_gpio_init(MCPWM_UNIT_0, MCPWM_FAULT_1, input_shutdown);

	gpio_pulldown_en(input_pwm);	  //Enable pull down on FAULT0 signal
	gpio_pulldown_en(input_shutdown); //Enable pull down on FAULT1 signal

	mcpwm_config_t mcpwm_config =
		{
			.frequency = MOSFET_PWM_INIT_FREQ,
			.cmpr_a = 50.0,
			.cmpr_b = 50.0,
			.counter_mode = MCPWM_UP_DOWN_COUNTER,
		};

	ESP_ERROR_CHECK(mcpwm_init(MCPWM_UNIT_0, MCPWM_TIMER_0, &mcpwm_config));

	ESP_ERROR_CHECK(mcpwm_set_duty_type(MCPWM_UNIT_0, MCPWM_TIMER_0, MCPWM_OPR_A, MCPWM_DUTY_MODE_0));
	ESP_ERROR_CHECK(mcpwm_set_duty_type(MCPWM_UNIT_0, MCPWM_TIMER_0, MCPWM_OPR_B, MCPWM_DUTY_MODE_1));

	ESP_ERROR_CHECK(mcpwm_fault_init(MCPWM_UNIT_0, MCPWM_HIGH_LEVEL_TGR, MCPWM_SELECT_F0));
	ESP_ERROR_CHECK(mcpwm_fault_set_cyc_mode(MCPWM_UNIT_0, MCPWM_TIMER_0, MCPWM_SELECT_F0, MCPWM_FORCE_MCPWMXA_LOW, MCPWM_FORCE_MCPWMXB_LOW));
	ESP_ERROR_CHECK(mcpwm_fault_init(MCPWM_UNIT_0, MCPWM_HIGH_LEVEL_TGR, MCPWM_SELECT_F1));
	ESP_ERROR_CHECK(mcpwm_fault_set_cyc_mode(MCPWM_UNIT_0, MCPWM_TIMER_0, MCPWM_SELECT_F1, MCPWM_FORCE_MCPWMXA_LOW, MCPWM_FORCE_MCPWMXB_LOW));
}

Thanks for reporting.


buildDotnetModule: add support for args with spaces in makeWrapperArgs

Description of changes
buildDotnetModule allows makeWrapper arguments to be defined via the derivation attr makeWrapperArgs, but using values with spaces will result in wrong arguments passed to makeWrapper, even if they are shell-quoted. This PR adds support for values with spaces.
Fixes #218449
Things done

Built on platform(s)

[X] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[X] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 218991 run on x86_64-linux 1

30 packages built:

ArchiSteamFarm
BeatSaberModManager
alttpr-opentracker
baget
boogie
btcpayserver
btcpayserver-altcoins
denaro
depotdownloader
discordchatexporter-cli
eventstore
formula
galaxy-buds-client
inklecate
jackett
jellyfin
marksman
msbuild
nbxplorer
netcoredbg
omnisharp-roslyn
opentabletdriver
osu-lazer
pinta
ps3-disc-dumper
roslyn
ryujinx
scarab
wasabibackend
xivlauncher

Result of nixpkgs-review pr 218991 run on x86_64-linux 1

1 package marked as broken and skipped:

baget

22 packages failed to build:

ArchiSteamFarm
BeatSaberModManager
alttpr-opentracker
btcpayserver
btcpayserver-altcoins
denaro
eventstore
galaxy-buds-client
jackett
jellyfin
marksman
msbuild
nbxplorer
omnisharp-roslyn
opentabletdriver
osu-lazer
ps3-disc-dumper
roslyn
ryujinx
scarab
wasabibackend
xivlauncher

7 packages built:

boogie (dotnetPackages.Boogie)
depotdownloader
discordchatexporter-cli
formula
inklecate
netcoredbg
pinta

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-already-reviewed/2617/882


Quantum target universal and nodejs

Hi @nchanged
While building a package with QuantumPlugin for target universal, I've noticed that the produced bundle cannot be properly consumed from nodejs - when I try to require a bundle, produced by Quantum, all I get is an empty object console.dir(require('./bundle.js')) // yields an empty object like:  {}. I am not sure whether this is intended behaviour or not. I'm simply trying to build a umd like package that I can use in browser, through window.NAME as well as require it trough nodejs.
I do use the globals fuse-box configuration option and I've tried all the possible targets:

target server work on nodejs
target browser works in browser
target universal is not requirable from nodejs

Is there a way I can build a platform agnostic bundle, like umd?
(I've seen the other issues on fuse-box regarding umd, but they don't seem to answer my question)
Thanks!

Could you reproduce the problem in a repository?

Yep, will do

@nchanged the original question of the author of this topic:

Is there a way I can build a platform agnostic bundle, like umd?

Without Quantum it's possible to run the previous code in browser and in NodeJS (as a CommonJS module with the exports and so on), however, with Quantum the code is executed in an isolated function expression, no exports.
My solution was hacky since I didn't want to spend much time on it, I set target to universal@es5 in FuseBox config but target: "npm" in Quantum, then just mock module.exports in browser.

@eddyw
globals: { default: '*' }, should actually do it. Could you install @next version and try again? There might be an actual bug or lack of implementation for the universal target.  But all is fixable.

@nchanged I tried with @next, it didn't work. Same results.

@nchanged What's the status of this?

Have you tried with the latest version? I am in the middle of a big refactor now

Yes, latest and greatest. Would you like a minimal replicating sample?

Sure, I will make sure to give it a proper test with v4

@nchanged Here's a repo to reproduce the issue with: https://github.com/KonstantinSimeonov/wavy-carrot
Setup:
Node version: replicated with both 10.15.1 and 8.12.0.
// index.ts
export const add = (x: number, y: number): number => x + y;

Steps to reproduce the issue:

npm i
node fuse.js
node -p "require('./dist/es6.js')"

This outputs an empty javascript object, but should output an object with a single export, something like { add: (x, y) => x + y }.

If you don't have the time to do it, I can look into it and possible open a PR

@KonstantinKai as I mentioned, v4 will be a brand new product, with 7x-10x faster than v4. If you want to help push it faster, you are welcome ;-)

FuseBox v4 Major Upgrade
As of today, the latest major version of FuseBox v4 is available in fuse-box@next. FuseBox has undergone a full re-write from scratch, learning from its mistakes in the previous versions.
There are a lot of improvements, speed and config wise.
Get started here
We are still working on the documentation and polishing before the major release. We are getting very close. And we need help testing.
npm install fuse-box@next

Most of the issues that I am closing have been resolved, however, if you find that your issue is still relevant in v4 don't hesitate to re-open or (better) create a new one with v4 configuration.


[release/1.6] backport: Bug fix for mount path handling to 1.6

Currently when handling 'container_path' elements in container mounts we simply call
filepath.Clean on those paths. However, filepath.Clean adds an extra '.' if the path is a
simple drive letter ('E:' or 'Z:' etc.). These type of paths cause failures (with incorrect
parameter error) when creating containers via hcsshim. This commit checks for such paths
and doesn't call filepath.Clean on them.
It also adds a new check to error out if the destination path is a C drive and moves the
dst path checks out of the named pipe condition.
Signed-off-by: Amit Barve<EMAIL_ADDRESS>(cherry picked from commit bfde58e3cdc0d16b24342886db319a2a2b0964b9)
Signed-off-by: Amit Barve<EMAIL_ADDRESS>

Backport of #6651


Add some color options.

Is there any chance to have color options for the particles in the settings menu?

see #192

Good to see some more people working on this.

#192 and #193 are on the latest release, with random colors and a fixed color.


chore: Remove /api/users GET test

This removes the GET /api/users test endpoint. This userRepo.findAll was causing the type error. (I added this last minute to verify creating users worked). We can add it back in later.

LGTM for a temporary fix. Long-term we presumably still want a findAll() method, what's the plan for that?
To fix the Semantic PR failure, I recommend changing the PR title to something like test: Remove /api/users GET test

We will definitely add it back in. Next week we will run an architecture session and divide the work based off how we're spliting our codebase up. Whoever is responsible for user accounts will probably implement findAll again.

LGTM for a temporary fix. Long-term we presumably still want a findAll() method, what's the plan for that?
To fix the Semantic PR failure, I recommend changing the PR title to something like test: Remove /api/users GET test

We will definitely add it back in. Next week we will run an architecture session and divide the work based off how we're spliting our codebase up. Whoever is responsible for user accounts will probably implement findAll again.

I changed the PR title to a semantic one (with chore) but the Semantic PR bot is still failing. I'm going to merge anyways just so our main branch is in a compiling state. Priority on our repos DX is high though and we'll fix this asap.

I changed the PR title to a semantic one (with chore) but the Semantic PR bot is still failing. I'm going to merge anyways just so our main branch is in a compiling state. Priority on our repos DX is high though and we'll fix this asap.


If I come back to the account screen instead of sending

-If I am sending some amount to the contact and before clicking "Confirm and Send button" I return to the account screen using the back arrow and the next time I go to send the same contact, it will Shows previous amount under that contact name.

-Verified this issue on dev app v 1.5.0(246)


[ERROR] Sentry Example-App not building with latest Flutter Beta

Platform
Flutter Mobile
Obfuscation
Disabled
Debug Info
Disabled
Doctor
[✓] Flutter (Channel beta, 3.27.0-0.1.pre, on macOS 14.6.1 23G93 darwin-arm64, locale en-AT)
    • Flutter version 3.27.0-0.1.pre on channel beta at /Users/martin/fvm/versions/3.27.0-0.1.pre
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 2e2c358c9b (8 days ago), 2024-10-22 11:02:13 -0400
    • Engine revision af0f0d559c
    • Dart version 3.6.0 (build 3.6.0-334.3.beta)
    • DevTools version 2.40.1

[!] Android toolchain - develop for Android devices (Android SDK version 35.0.0)
    • Android SDK at /Users/martin/Library/Android/sdk
    • Platform android-35, build-tools 35.0.0
    • Java binary at: /Applications/Android Studio.app/Contents/jbr/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 17.0.11+0-17.0.11b1207.24-11852314)
    ! Some Android licenses not accepted. To resolve this, run: flutter doctor --android-licenses

[✓] Xcode - develop for iOS and macOS (Xcode 16.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 16B40
    • CocoaPods version 1.15.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2024.1)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 17.0.11+0-17.0.11b1207.24-11852314)

[✓] VS Code (version 1.94.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.98.0

[✓] Connected device (3 available)
    • macOS (desktop)                 • macos                 • darwin-arm64   • macOS 14.6.1 23G93 darwin-arm64
    • Mac Designed for iPad (desktop) • mac-designed-for-ipad • darwin         • macOS 14.6.1 23G93 darwin-arm64
    • Chrome (web)                    • chrome                • web-javascript • Google Chrome 130.0.6723.70

[✓] Network resources
    • All expected network resources are available.

Version
latest main branch
Steps to Reproduce
Use the current Flutter Beta (3.27.0-0.1.pre) and try to build the sentry example app with flutter build apk --debug
Expected Result
Successful build.
Actual Result
#: flutter build apk --debug
Changing current working directory to: /Users/martin/Repositories/sentry-dart/flutter/example

You are applying Flutter's app_plugin_loader Gradle plugin imperatively using the apply script method, which is deprecated and will be removed in a future release. Migrate to applying Gradle plugins with the declarative plugins block: https://flutter.dev/to/flutter-gradle-plugin-apply

You are applying Flutter's main Gradle plugin imperatively using the apply script method, which is deprecated and will be removed in a future release. Migrate to applying Gradle plugins with the declarative plugins block: https://flutter.dev/to/flutter-gradle-plugin-apply

 android plugin version 8.3.2
:app:external cmake build

FAILURE: Build failed with an exception.

* Where:
Build file '/Users/martin/Repositories/sentry-dart/flutter/example/android/build.gradle' line: 29

* What went wrong:
A problem occurred evaluating root project 'android'.
> A problem occurred configuring project ':app'.
   > Could not resolve all dependencies for configuration ':app:releaseCompileClasspath'.
      > Could not find io.flutter:x86_release:1.0.0-af0f0d559c8a87d912a20971bbd84afc80a54b0f.
        Required by:
            project :app

* Try:
> Run with --stacktrace option to get the stack trace.
> Run with --info or --debug option to get more log output.
> Run with --scan to get full insights.
> Get more help at https://help.gradle.org.

BUILD FAILED in 3s
Running Gradle task 'assembleDebug'...                              3.8s
Gradle task assembleDebug failed with exit code 1

Are you willing to submit a PR?
Yes

I was able to nail it down to the androidNativeBundle.
After removing the following lines:
android/build.gradle
classpath 'io.github.howardpang:androidNativeBundle:1.1.4'
app/build.gradle
apply plugin: 'com.ydq.android.gradle.native-aar.import'
externalNativeBuild {
    cmake {
        arguments.add(0, "-DANDROID_STL=c++_static")
    }
}

ndk {
    // Flutter does not currently support building for x86 Android (See Issue 9253).
    abiFilters("armeabi-v7a", "x86_64", "arm64-v8a")
}

externalNativeBuild {
    cmake {
        setPath("CMakeLists.txt")
    }
}

I was able to build the example app with fvm flutter build apk --debug again.

As written here, we should further investigate and check our gradle config for potential errors.

I forgot to remove the close #2381 statement, so I reopened the issue. We should investigate this problem further.

generally I'm not sure if spending more time on debugging this makes sense
We figured out the culprit and found a workaround that works. In the end it's only our example app and doesn't affect real users at all.
What we should investigate is if we still need this plugin? as far as I can tell we need it for our NDK example but are there alternatives?

Based on the responses to my comment in the flutter gradle change and the issue I created in the androidNativeBundle, it looks like it is a bug in the androidNativeBundle which came up with the recent flutter gradle changes.
The maintainer of the androidNativeBundle plans to adapt the plugin.
It's up to you @buenaflor, to decide, if we should leave this issue open, and come back, when the androidNativeBundle is updated, and revert the changes, or if we can leave everything as it is now, because we only want to test the build, which is now possible?
Regarding your question about the need of this plugin. As far as I can tell we don't have to use this plugin, but it makes handling native code very convenient. I also cannot say, if there are suitable alternatives for this plugin.
Maybe @romtsn is more familiar, with gradle and android native plugins and can answer this questions?

if the maintainer fixes it then it's fine for me to leave this upon and wait for his fix

Waiting for https://github.com/howardpang/androidNativeBundle/issues/20 to be fixed


video action recognition visualization

In the introduction video on youtube, we see the author visualize the recognition of human actions in video frames. What I want to know is, did the author include the code for video action recognition visualization in the code? I hope the author can provide some help, thank you very much

Hi, someone emailed me a similar question, here is my reply:
I wrote something for the dataset visualization when I got the demo from the author of Action Genome. Maybe you can extend it to visualize the prediction.
Sorry that I cannot clean the code for you, since I am quite busy with other projects now. I zip all files (including some dataset annotations and frames) for you. Graphviz is necessary for running the code. You can download the code here:
https://drive.google.com/file/d/1vuT0OXla0fhx2ekcLoGs5YZp-VsrRLOM/view?usp=sharing

were you able to visualize the graphs ?


Fixed VM system network configuration to have special name

This is necessary for testing scripts to work correctly because
generic name connections are wiped as garbage.
Fix for #356.

Approved


The example code is incomplete and app.js is missing

Hey, thank you for testing and contributing to wavesurfer.js!
Please make sure you can check all of these points below before opening an issue:
(You don't have to post this section)

[x] I have checked the FAQ and it doesn't solve my problem.
[x] I have checked the documentation and it doesn't solve my problem
[x] I have searched for already open issues which desribe my problem.
[x] The issue I'm having is related to and caused by wavesurfer.js, not by other software (which maybe packages and uses wavesurfer incorrectly) – In that case you should open the issue on the respective project pages.

Please make sure you provide the following information (if applicable):
Wavesurfer.js version(s):
Browser and operating system version(s):
Code needed to reproduce the issue:
(Please reduce your code as much as possible and only post the minimum code needed to reproduce the issue. A Code pen is an excellent way to share such code)
Use behaviour needed to reproduce the issue:
The example code is incomplete and app.js is missing

can you be more specific?

Sorry，The example code is incomplete and app.js is missing .File path: wavesurfer.js/tree/master/example/split-wave-point-plot/  I can't find the app.js file。

Sorry，The example code is incomplete and app.js is missing .File path: wavesurfer.js/tree/master/example/split-wave-point-plot/ I can't find the app.js file。

can you be more specific?
Sorry，The example code is incomplete and app.js is missing .File path: wavesurfer.js/tree/master/example/split-wave-point-plot/ I can't find the app.js file。

The example “split-wave-point-plot” cannot run completely。

can you be more specific?

i did not dig into the code but i can confirm that https://wavesurfer-js.org/example/split-wave-point-plot/index.html does not work for me:

Duplicate of #1286


c# UWP sample, VisionSource.FromFile method not working

Please provide us with the following information:

This issue is for a: (mark with an x)
- [x ] bug report -> please search issues before submitting
- [ ] feature request
- [ ] documentation issue or request
- [ ] regression (a behavior that used to work and stopped in a new release)

Minimal steps to reproduce

Run the UWP program (C#). Choose "Click to Select Image File" Button. Provide the location of a JPG file. Click Analyze.

Any log messages given by the failure
Error azac_err_failed_to_open_input_file_for_reading will be thrown. I have tried placing the JPG file in various locations, including the path of where the project solution is, it still fails
Expected/desired behavior

It should analyze the image the same way as the URL (VisionSource.FromUrl) method

OS and Version?

Windows 11

Versions

Mention any other details that might be useful

Thanks! We'll be in touch soon.

These are two locations where the UWP app has read access:
string path1 = Windows.ApplicationModel.Package.Current.InstalledLocation.Path;
This will be in the installed AppData folder (for example, for username "user-name" and app ID a467bb24-409a-b446-1075-338be52026c2_ay9t6efm8v3xw, this will be: C:\Users\user-name\AppData\Local\Packages\a467bb24-409a-b446-1075-338be52026c2_ay9t6efm8v3xw\LocalState)
Or
string path1 = ApplicationData.Current.LocalFolder.Path;
// For example, if you compiled the sample code in your azure-ai-vision-sdk GitHub repo clone, this will be the folder (for Debug build):  \samples\csharp\image-analysis\uwp\bin\x64\Debug\AppX

Thank you, it worked per your explanation!


samples: subsys: mgmt: smp_svr: Define Image Version in the example

Define CONFIG_MCUBOOT_IMAGE_VERSION as default in the example, as this
is crucial for versioning using mcumgr/smp_svr
Signed-off-by: João Dullius<EMAIL_ADDRESS>

Hi again, you will need to reformat the commit message, here is contribution guideline for commit message: https://docs.zephyrproject.org/latest/contribute/index.html?highlight=committing#commit-guidelines

Hi again, you will need to reformat the commit message, here is contribution guideline for commit message: https://docs.zephyrproject.org/latest/contribute/index.html?highlight=committing#commit-guidelines

Thanks, done.

I might be wrong, but I don't see any references to CONFIG_MCUBOOT_IMAGE_VERSION in the main Zephyr tree or in the Zephyr mcuboot fork. The only reference I could find, was somewhere in the nRF Connect SDK.

MCUBOOT_IMAGE_VERSION

Hm, I think you are right. I was quite convinced that imgtool picks that when invoked from west sign but could not find any reference.

Ok, so this is a NCS specific implementation, and not a Zephyr one, hence it makes no sense to add it to the Zephyr sample.
https://github.com/nrfconnect/sdk-nrf/blob/e67cf2aec35135431743cc2e973d04284e231939/modules/mcuboot/Kconfig#L11


[Question] why define SSIZE_MAX   as   (LLONG_MAX >> 1) in sds.h

why not LLONG_MAX   but  LLONG_MAX / 2 ?

Maybe I misunderstand the question but LLONG_MAX / 2 and LLONG_MAX >> 1 should be equivalent.

LLONG_MAX value is  2^32-1, which is the max value of signed long long.
The max signed size_t value is also  2^32-1.
So I think SSIZE_MAX  == LLONG_MAX.
But here we define  SSIZE_MAX   as (LLONG_MAX >> 1), why?


Update AFF to new AJSON functionality

Manual testing:

[ ] pull into ABAP system, Object looks good
[ ] diff page for JSON looks good
[ ] push from ABAP system


build.zig.zon requires path field

In the latest version of ziglang, build.zig.zon requires path field to be decalred.
akhil@ad:~/practice/immich$ zig fetch --save https://github.com/zigzap/zap/tarball/master
/home/akhil/.cache/zig/tmp/fa6da82352a5a36d/build.zig.zon:1:2: error: missing top-level 'paths' field
.{
 ^

I thought the readme was quite clear that zap requires the latest stable zig release 0.11. Please, people, read the readme. It's called readme and not .gitignore 🙂 for a reason!
So this is not an issue, as the correct and sane versions are specified. If you use zig master, you operate outside of the specs and there will be problems, and more will come as zig master keeps progressing.
If you want to use the released version of zap, please use zig 0.11. Zap is not meant to be needed to be updated every two weeks, following zig master.
If you know that you only want zig master, hop on the discord and check out the discussions there. Contributors have their own forks of zap and facilio for zig 0.12, and are updating some PRs that I haven't had time to look at.

Lol yaa I overlooked the required version (0.11.0). Was thinking to give PR to  master to be compatible with nightly zig. Anyways I made zap to work on nightly zig and I think I'll maintain my own fork until zap gets synced with zig's next release.
A small note, please put the line: Make sure you have the latest zig release (0.11.0) installed. Fetch it from [here](https://ziglang.org/download). anywhere in the top of readme so it would be easy to identify and first time users would be aware of incompatibility with nightly zig.

I totally agree! Let's make it less of a "haven't you read the fineprint?" situation 🙂.
There have been quite a few zig master forks popping up now... I hope I will have time to merge them into a branch over the holidays, when I also want to review and mildly refactor zap's API.
Especially since both the zig download page and projects like ziglings seem to nudge newcomers into going for zig master straight away.


Cosmos DB is retired from Azure Storage Explorer

This information is not accurate anymore,
Cosmos DB is retired from Azure Storage Explorer

[Enter feedback here]

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 4314a5a5-2599-b5fd-063f-a2670e4d18c5
Version Independent ID: 39a2f096-d18c-d51a-085a-4acc2a8cb834
Content: Manage Azure Cosmos DB resources by using Azure Storage Explorer
Content Source: articles/cosmos-db/storage-explorer.md
Service: cosmos-db
GitHub Login: @StefArroyo
Microsoft Alias: esarroyo

Hi @pveliz Thanks for your findings, I'm assigning this to the author for the feedback review.

@pveliz, thanks for the heads up! A change is now in flight.
#reassign:seesharprun

This article has now been removed. Please refer to Get Started with Storage Explorer for guidance on using the explorer with other data sources.
#please-close


[BEAM-3565] Add a single-stage fusion implementation

This takes in either a root PCollection (at execution time, a
RemoteGrpcRead), and a collection of consuming transforms (siblings)
or an in-environment Read node, and fuses as many PCollections
as possible into the stage, materializing PCollections which have
consumers that cannot be fused into the stage.
Future work can be performed to merge multiple subgraphs.
The current 'GreedyPCollectionFusers' implementation uses a slightly
simpler model for ParDo Fusion than the maximally permissive model.
For example, the fuser never fuses a ParDo which contains a side
input into an upstream stage, though it can if that stage contains no
upstream PCollections of any of its side inputs.

Follow this checklist to help us incorporate your contribution quickly and easily:

[x] Make sure there is a JIRA issue filed for the change (usually before you start working on it).  Trivial changes like typos do not require a JIRA issue.  Your pull request should address just this issue, without pulling in other changes.
[x] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue.

[ ] Run mvn clean verify to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
[x] If this contribution is large, please file an Apache Individual Contributor License Agreement.

CC: @axelmagn @bsidhom


Set x-nullable for parameters

We use WebApiToSwaggerGenerator to generate json and yaml swagger files. We have parameters and responses which should not be nullable. For the response we can use the SwaggerResponse attribute and set IsNullable to false. Can the same be achieved for parameters? Now this is always generated with x-nullable: true.
And is it possible to completely omit the generation of the x-nullable attributes?

I think if you put [Required] attribute to the parameter it should not set x-nullable to true

Does not seem to work...
public IHttpActionResult MyApiMethod([Required] MyRequestClass request)
Result in swagger:

"parameters": [
 "name": "request",
 "in": "body",
 "required": true,
 "schema": {
  "$ref": "#/definitions/MyRequestClass"
 },
 "x-nullable": true
]

So required is set correctly to true but x-nullable should be false in our case. Setting the Required attribute to the method parameter makes no difference.

We seem to appear to have the same problem here, "x-nullable" is always true

[NotNull] appears to work.
Though it feels counter intuitive having to mark parameters as required when they have no default value just because they can be null, compared to explicitly marking them as optional. Especially considering defining them in the route template does make them required (though in hindsight this kind of makes sense since the route resolver would not even locate the route if not all parameters are filled).
Possible to make this a option somewhere to inverse the behaviour?

Hi @RicoSuter !
I am working on a new project which gives me the pleasure to wow everyone with this amazing library and API client generation!
I do have a bit of a weird issue, though.
I have the following code:
[HttpGet("{foo:length(3)}")]
public async Task<Bar> FizzBuzz(string foo)
{
    // etc..
}

I would expect nswag to say that foo is required AND not nullable.
Now.. nswag generates x-nullable TRUE for this. Even though I have nullability checks on in the project, which I thought would be used to decide that it is not nullable. Otherwise Iwould mark it as string?
Another project I worked on (Using nswag 13.15.10 has the same sort of code ,but x-nullable is FALSE. I tried downgrading my new project to 13.15.10 as well, but with no success.
As far as Ican see, the setup for swagger is the same.
So.. Now that we are a few years later than the last comment.. should I still mark everything with [NotNull]? Or is there a better solution I am not seeing?
Doing so works.. But I am not really happy with it.. Especially since I dont use that in another project where x-nullable false DOES work correctly.


BaseCommand Documentation

Describe the bug
Copying and pasting the exact example from the documentation on creating a BaseCommand does not result in a functional command that can be used.
To Reproduce

Copy the code used in the example
Attempt to start the CLI: ./bin/dev.js
Note that said command does not appear

Expected behavior
I expected to be able to utilize a BaseCommand if I followed the instructions (or at least get some helpful debug output about why that didn't work :'( )
Environment (please complete the following information):

OS & version: [e.g. MacOS Monterey, Ubuntu 20.04.4 LTS, Windows 10]: MacOS 13.6.6
Shell/terminal & version [e.g. bash-3.2, bash-5.0, zsh 5.8, powershell 7.2.4, cmd.exe, Windows Terminal w/ powershell, etc... ]: zsh 5.9 (x86_64-apple-darwin22.0)

@JensAstrup I'm not able to reproduce this with the following:

oclif generate gh-1060 --yes
copy example into src/commands/hello/index.ts
bin/dev.js --name oclif

Is there anything I'm missing? Also you can get additional logs if you set the DEBUG=* in your environment

Nope, not missing anything 🤔  I used DEBUG, just felt wanting of more detail. Here's what I have using oclif/4.5.0 darwin-arm64 node-v21.7.1
Apologies if this is just me, my copy/paste job made it seem like an oclif issue - now I've got that sneaking feeling that I've overlooked something minor that'll have me 🤦
] +6ms
  config:espresso (import) /Users/jens/projects/espresso/src/commands/github/pending-review.ts +2s
Warning: Error
    at Plugin.warn (/Users/jens/projects/espresso/node_modules/@oclif/core/lib/config/plugin.js:372:17)
    at /Users/jens/projects/espresso/node_modules/@oclif/core/lib/config/plugin.js:276:30
    at async Promise.all (index 4)
    at async Plugin._manifest (/Users/jens/projects/espresso/node_modules/@oclif/core/lib/config/plugin.js:257:24)
    at async Plugin.load (/Users/jens/projects/espresso/node_modules/@oclif/core/lib/config/plugin.js:208:25)
    at async PluginLoader.loadRoot (/Users/jens/projects/espresso/node_modules/@oclif/core/lib/config/plugin-loader.js:67:13)
    at async Config.load (/Users/jens/projects/espresso/node_modules/@oclif/core/lib/config/config.js:267:27)
    at async Function.load (/Users/jens/projects/espresso/node_modules/@oclif/core/lib/config/config.js:157:9)
    at async run (/Users/jens/projects/espresso/node_modules/@oclif/core/lib/main.js:59:20)
    at async file:///Users/jens/projects/espresso/bin/dev.js:5:1
module<EMAIL_ADDRESS>task: findCommand (hello:hello)
plugin: espresso
root: /Users/jens/projects/espresso
See more details with DEBUG=*
Warning: Error
    at Plugin.warn (/Users/jens/projects/espresso/node_modules/@oclif/core/lib/config/plugin.js:372:17)
    at /Users/jens/projects/espresso/node_modules/@oclif/core/lib/config/plugin.js:276:30
    at async Promise.all (index 4)
    at async Plugin._manifest (/Users/jens/projects/espresso/node_modules/@oclif/core/lib/config/plugin.js:257:24)
    at async Plugin.load (/Users/jens/projects/espresso/node_modules/@oclif/core/lib/config/plugin.js:208:25)
    at async PluginLoader.loadRoot (/Users/jens/projects/espresso/node_modules/@oclif/core/lib/config/plugin-loader.js:67:13)
    at async Config.load (/Users/jens/projects/espresso/node_modules/@oclif/core/lib/config/config.js:267:27)
    at async Function.load (/Users/jens/projects/espresso/node_modules/@oclif/core/lib/config/config.js:157:9)
    at async run (/Users/jens/projects/espresso/node_modules/@oclif/core/lib/main.js:59:20)
    at async file:///Users/jens/projects/espresso/bin/dev.js:5:1
module<EMAIL_ADDRESS>task: findCommand (hello:hello)
plugin: espresso
root: /Users/jens/projects/espresso
See more details with DEBUG=*
  config:espresso (import) /Users/jens/projects/espresso/src/commands/shortcut/at-risk.ts +132ms
  config:espresso (import) /Users/jens/projects/espresso/src/commands/shortcut/missing-points.ts +0ms
  config:espresso (import) /Users/jens/projects/espresso/src/commands/shortcut/stalled-in-dev.ts +0ms


Fixed #23251 -- Uses a temporary folder for media upload when running tests

Made nature of media uploads in tests same as database.
If TEST_MEDIA_ROOT is defined in the settings:

Running the test suit will create a new folder using TEST_MEDIA_ROOT, if any file is uploaded.
During teardown of the test environment, the folder is deleted.
Using the --keep-media flag will prevent deletion of the test folder.

If TEST_MEDIA_ROOT is not defined in the settings, then it will follow the default behaviour of using MEDIA_ROOT as earlier (for maintaining reverse compatibility).

@shaib Do you want to take a look?

Waiting on Fixed #26029 -- Added STORAGES setting PR to get merged to proceed.


[DARGA] Backport model code from PR #11992 and #12114

Description
Backports ManageIQ/manageiq#11992 , ManageIQ/manageiq#12114 and  ManageIQ/manageiq#12106 to allow for pglogical to work properly... I think...
Includes the updates from ManageIQ/manageiq#11992 for the OwnershipMixin, and also includes the (minimal) necessary updates to allow it to work:  updating the arel for the evm_owner_userid virtual_column, which was handled by virtual_delegates in the newer releases.  The same was done for ManageIQ/manageiq#12114 and it's virtual_column.
PR ManageIQ/manageiq#12106 is simply brought in normally, but needed to be done manually to handle updates that have happened to the codebase in those files in master since darga.
Links

https://github.com/ManageIQ/manageiq/pull/11992
https://github.com/ManageIQ/manageiq/pull/12114
https://github.com/ManageIQ/manageiq/pull/12106
https://github.com/ManageIQ/manageiq/pull/10476
https://github.com/ManageIQ/manageiq/pull/11243
https://github.com/ManageIQ/manageiq/pull/12088
https://github.com/ManageIQ/manageiq/pull/10704
https://github.com/ManageIQ/manageiq/pull/10290

The above cops were like this on master, so I left them in place for easier code review.

@gtanzillo is this something we want on Darga?

Thanks for doing the heavy lifting acceptance testing :)


Set sampleRate with setOptions

I tested in my own fork and this seems to fix #51

Thanks for this!

sure thing!


No error or warnings when underlying models of ensemble model request doesn't succeed

Description
The reported Prometheus stats for the inference success rate of the ensemble mode are 100%. The 2 models that are used within the model are showing much lower success rates (~30% and ~50%). There are no clear errors/warnings in the verbose output (--log-verbose).
Because of the constant retrying the throughput of my model is reduced to a crawl.
Triton Information
I'm using the 20.06 V2 container and clients.
To Reproduce
Have an ensemble model and two underlying models. I don't think the config matters here, I just want error output.
Expected behavior
I would expect to see errors or warnings when inference fails. I need to know why it's failing.

Can you share a minimum repro? The error from the underlying models should be propagated to the ensemble

I found the cause of my issue. I was misinterpreting the values I was getting from Prometheus. No errors were actually occuring. Closing & thanks.


[RFR] Translate

[x] add angular-translate dependency and configure it
[x] move all text behind translate directive, filter, or service
[x] document it
[x] Fix tests

Closes #169.

Switching to RFR


Ketcher + dative bonds

It would be great if Ketcher supported dative bonds. We could either try to add this functionality ourselves or find another editor that already supports this feature.

#58 adds dative bonds in molfiles; we still need to get them into the SMILES.

Confirmed that Ketcher can now create dative bonds in ORD, and the molfile shows dative bonds as type "9". I haven't found confirmation that this is the correct value to describe dative bonds.
The SMILES string is not generated when the structure includes a dative bond.


In Tree grid view, is there any way through which I can enable lines which will connect from a parent node to child nodes?

I have implemented tree grid. Currently when I expand parent node, the list of child nodes displays. Is there any way through which I can enable lines which will connect from a parent node to child nodes?

Yeah, that sounds neat.  I can add it as a new feature.


[Self Signed Cert] Add a check on maven build to verify the self signed cert is not expired when building the product.

This will be a useful check to have so that we know when the cert gets expired. Please see attached screenshot.

@chamaraanu , @geethkokila , @madawas : Labels 3.1.0-RC2, medium

Pubudu,
We can either use exec-maven-plugin or write a mojo to do this @ build time.


Touhou 9.5 Shoot the Bullet Steam release isn't recognized

thcrap doesn't find the th095 steam release.

When I add it by hand (ie. write it into games.js), it doesn't patch the game

This is being worked on, please wait warmly~

done

I.. wow.. that was fast


Node version

Hello,
I have an error.
<EMAIL_ADDRESS>The engine "node" is incompatible with this module. Expected version ">=14.0.0 <17.0.0". Got "18.12.1"
Is it possible to update your lib to 18+?

https://github.com/candidosales/material-time-picker/pull/40

Thanks, @passtech for the improvement! @dpaniq It's fixed! :)

@dpaniq You can use the 2.8.0v. It's already been published. https://www.npmjs.com/package/@candidosales/material-time-picker?activeTab=versions


fix(markdown): improve markdown table styling

Thanks to @sanbornsen for showing me the right place to make these changes.
Rendered tables currently show up in OpenShift.io without borders and without any padding whatsoever. That makes them really hard to identify as tables.
This change adds

a border,
padding and
alternating row colors (taken from the color palette)

to a rendered table.
Before
This is how the rendering of a table looks in OpenShift.io before the style changes:

After
And this is how it looks with the style changes (applied in Chrome):

Try standalone
Here's a preview of the changes standalone:
https://www.w3schools.com/code/tryit.asp?filename=FQB3L3C4L6CM

Will this impact any of the other tables where this component is used, as it directly styles HTML elements?

Will this impact any of the other tables where this component is used, as it directly styles HTML elements?

@mindreeper2420 I'm styling inside the editor-preview, therefore I thought it can only influence tables within such a preview.

[test]

@mindreeper2420 I believe this will only impact tables inside the component which is intended. By default components do encapsulation.

@kwk that's what I'm not sure about - the styles are usually all dropped into the <head> area of the site. Not quite sure how to test it :)

@mindreeper2420 I can only find one class for an h1 on this page: https://prod-preview.openshift.io/_home

@sanbornsen view encapsulation is turned off for this component (from what I saw), as well as the majority of OSIO.
@kwk my biggest concern is if this will have unintended consequences one the Planner table - my thought is no, but I'm not sure :) I'll check the Planner page, to see if anything from this component ends up in the head section. I believe that is the only area that uses this component.

@mindreeper2420 true that it stays in the header but it has separate tags. Well, here is a test example. I kept two simple tables, one inside f8-markdown one outside it. The one outside has no style from the newly added CSS.

@sanbornsen @kwk I just checked in OSIO and, even though styles from this component are being added to <head>, they are inside of the class .editor-container, so they shouldn't affect anything else. There is currently an <h1> that is being overwritten by this component, but it is not affecting other <h1> elements.

@mindreeper2420 that sounds harm free then. Shall we merge this?


Improve Attach Detach Disk Performance

On my cluster disks can take up to 10 min to attach to my node after a failover because it takes too long to detach from old node before attaching to new one. Is there anything that can be done to fix this performance issue?

cc @andyzhangx

as I know it won't be related, what's your k8s version? @sharkymcdongles recently we fixed an issue which could lead to disk attach/detach failure

1.13
On Fri, Feb 1, 2019, 8:41 AM Andy Zhang<EMAIL_ADDRESS>wrote:

as I know it won't be related, what's your k8s version? @sharkymcdongles
https://github.com/sharkymcdongles recently we fixed an issue which
could lead to disk attach/detach failure
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/kubernetes/cloud-provider-azure/issues/78#issuecomment-459634475,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AbyiUcnL7ngWIJEIePZNvUVDVmrrWHPYks5vI--ZgaJpZM4ZPA24
.

@sharkymcdongles could it repro easily? and on which azure region?

This issue could be probably be due to this, the normal attach/detach operation is around 15s.
I will close this issue now, let me know if you have any question, thanks.
Issue details:
We found a disk attach/detach issue due to dirty vm cache PR introduced from v1.9.2, it would lead to following disk issues:

disk attach/detach failure for a long time
disk I/O error
unexpected disk detachment from VM
VM running into failed state due to attaching non-existing disk

Note: above error may only happen when there are multiple disk attach/detach operations in parallel and it's not easy to repro since it happens on a little possibility.

Related issues

Azure Disks volume attach still times out on Kubernetes 1.10
Azure Disks occasionally mounted in a way leading to I/O errors

Fix
We changed the azure disk attach/detach retry logic in k8s v1.13, switch to use k8s attach-detach controller to do attach/detach disk retry and clean vm cache after every disk operation, this issue is proved to be fixed in our disk attach/detach stress test and also verified in customer env:

PR remove retry operation on attach/detach azure disk in azure cloud provider
PR fix azure disk attach/detach failed forever issue
PR fix detach azure disk issue due to dirty cache

k8s version
fixed version

v1.9
issue introduced in v1.9.2, no cherry-pick fix allowed

v1.10
1.10.12

v1.11
1.11.6

v1.12
1.12.4

v1.13
no such issue

Work around:

if there is attach disk failure for long time, restart controller manager may work
if there is disk not detached for long time, detach that disk manually

Related issues

Multi Attach Error

/close

I just restarted a VM from the Azure portal that I cordoned and drained in k8s 1.13. I am still waiting for it to enter stopped status because the detach operations take so long. It took roughly 20 minutes just to enter stopped state. I am now waiting during the updating phase where it detaches the disks. This has taken a further 10 minutes. I don't think this is as fixed as you say it is. Is it possible because this cluster is provisioned with VMs that were created before this fix was made the fix isn't applied there? Or does the fix come from within k8s itself?

@sharkymcdongles what's your exact k8s version? The issue I mentioned happens when moving multiple disks from one node to another. That bug I fixed would lead to following issues:

disk attach/detach failure for a long time
disk I/O error
unexpected disk detachment from VM
VM running into failed state due to attaching non-existing disk

Back to your issue, if you restart a VM and it needs a long time, it could be simply an azure platform issue, you could provide activity logs and file an azure ticket.

@andyzhangx It takes around 14 mins in my Kubernetes cluster to attach disks sometimes. Doesn't seem consistent though.
Kubernetes version: 1.12.6 (AKS West Europe)
Got these events:

Looking at the events, would you say this is a Kubernetes/AKS issue or an Azure issue?

@dennisameling are you attaching multiple disks to one VM in parallel? 14 min is abnormal, we noticed slow disk attachment in west Europe region before, while it recovered finally.


Enhance the Text Content for Better Engagement on Html Sanity Check (HSC) Page

The current text content on the Html Sanity Check (HSC) page is informative but lacks an engaging tone. Updating the language to make it more compelling can help capture user interest and make the project more approachable. This will ensure users not only understand the purpose but are also excited to try out the tool.
Suggested Changes:
Introduce a Catchy Tagline:
Current: "This project provides some basic sanity checking on HTML files."
Suggestion: "Keep Your HTML Spotless with Html Sanity Check (HSC) – Your Go-To Solution for Error-Free Code!"
Make the Description More Enthusiastic:
Current: "It can be helpful in case of HTML generated from e.g. Asciidoctor, Markdown, or other formats - as converters usually don’t check for missing images or broken links."
Suggestion: "No more missed errors in your HTML! Whether you’re generating HTML from Asciidoctor, Markdown, or other formats, HSC has your back. It ensures every image is in place and no link is left broken, giving you peace of mind with every build."
Highlight the Versatility:
Current: "HSC can be used programmatically or as a Gradle plugin. A standalone Java command line interface (CLI) version is planned as well as a Maven plugin for future releases."
Suggestion: "Use HSC however you like—whether it’s programmatically or through a Gradle plugin. And there's more! A standalone Java CLI version and a Maven plugin are on the horizon, offering even more ways to integrate HSC into your workflow."

This sounds like a great idea, thanks for bringing this up, @Shreyhac. Would you like to work on this topic in the course of this years Hacktoberfest? I'd appreciate if you could polish some of the documents with your obvious writing skills.
To be honest, since I took over the project I didn't find much time to look into the documentation. Perhaps I even wrote new documentation fragments in the very same style as the old ones?
However, I think there are even more flaws as the code (and in particular the architecture) was refactored. Hence, the documentation needs to be aligned with the current and upcoming code changes. We already have some code for Maven (#314) and CLI (#318) in the pipeline, as well as a documentation update wrt. to architecture graphics (#326).

hey@= @ascheman  i would love to work on this , please assign me this under hactoberfest

Thanks a lot, it is assigned to you.
Are you on (the Hacktoberfest) Discord? You can reach out to me (gerdaschemann) so we could have a chat if you need any other support.


Merge master changes into major and update chat guide

This includes all of the changes from master as well as updates the DoneJS chat guide to work with DoneJS 1.0 things.

Coverage remained the same at 96.396% when pulling 4ea61592a7991999cb6838235ea1b40daba152b0 on chat-updates into 24dec74fd2c923691c2521518f34d7a96c611e1d on major.

Coverage remained the same at 96.396% when pulling 4ea61592a7991999cb6838235ea1b40daba152b0 on chat-updates into 24dec74fd2c923691c2521518f34d7a96c611e1d on major.

Coverage remained the same at 96.396% when pulling 4ea61592a7991999cb6838235ea1b40daba152b0 on chat-updates into 24dec74fd2c923691c2521518f34d7a96c611e1d on major.

Coverage remained the same at 96.396% when pulling b277d63055666a226aeeb5fae28b64c8e4b1955e on chat-updates into 24dec74fd2c923691c2521518f34d7a96c611e1d on major.

Closes https://github.com/donejs/donejs/issues/710


Add contributors to the README

Codecov Report

Merging #22 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           master    #22   +/-   ##
=====================================
  Coverage     100%   100%
=====================================
  Files          24     24
  Lines         260    260
  Branches       10     10
=====================================
  Hits          260    260

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f91d8a6...8b74c9f. Read the comment docs.


Display freezes after a few seconds

Hi, i have an SSD1306 128x64 OLED display, and it freezes about 10 seconds the stick is plugged in. Hot-plugging the OLED makes it work for another ten seconds or so.
Also, after powering down the stick, if i plug it back in right away the display rarely comes up. Hot-plugging the OLED does nothing there.
I have a couple more OLEDs on order from another seller and will try to figure out if the display itself is the issue.

Actually, on longer testing, sometimes the display comes to life again, and freezes again, and comes to life again, and repeat.

Hi @butterrsoft ,
Can you link the specific OLED that you are using?  I have run into some issues with OLEDs from Amazon and AliExpress.

This one from Aliexpress - https://www.aliexpress.com/item/32233334632.html?spm=a2g0o.order_list.0.0.6a181802U0pJZs
I have a couple more on order that actually say they have the ssd1306 chip in them, but they're probably the same.

Hi @butterrsoft ,
Feel free to join the OpenStick Discord if you would like to have a more in-depth chat about this.
Can you confirm which IIC address is selected on the back of the OLED and also what your display settings are currently set at in the online config tool?

Closing this as we have not been able to reproduce the issue via any configuration and consider this a hardware issue.  Will re-open if we can reproduce.

We have confirmed that this was a bad OLED module.


Use Enum or string in Struct serialization/deserialization for py:enum gen code

When serializing and deserializing Enums for Structs, we convert the Enum to a string instead of keeping it as an Enum. What this means is that the thrift file shows that an Enum is passed in the struct, when actually a string is passed in. This is very confusing can arbitrarily lead to KeyError and in the deserialization logic.
However, changing this behavior is potentially breaking. To avoid breaking existing users, check if the type is an Enum by using the hasattr check to see if type has attribute value. If so, parse as an enum. Otherwise parse as a string.
Given a thrift file like the following:
enum TestEnum {
  TestEnum0 = 0,
  TestEnum1 = 1,
}

struct TestStruct {
    1: optional string param1
    2: optional TestEnum param2
}

this is how you would create a struct before and after the change but both are valid.
# Before
TestStruct(param1="test_string", param2=TestEnum.TestEnum1.name) # or pass in "TestEnum1"

# After
TestStruct(param1="test_string", param2=TestEnum.TestEnum1)

Serialization/Deserialization Code Change Example-
class TestStruct(object):
    """
    Attributes:
     - param1
     - param2

    """

    def __init__(self, param1=None, param2=None,):
        self.param1 = param1
        self.param2 = param2

    def read(self, iprot):
        if iprot._fast_decode is not None and isinstance(iprot.trans, TTransport.CReadableTransport) and self.thrift_spec is not None:
            iprot._fast_decode(self, iprot, [self.__class__, self.thrift_spec])
            return
        iprot.readStructBegin()
        while True:
            (fname, ftype, fid) = iprot.readFieldBegin()
            if ftype == TType.STOP:
                break
            if fid == 1:
                if ftype == TType.STRING:
                    self.param1 = iprot.readString().decode('utf-8', errors='replace') if sys.version_info[0] == 2 else iprot.readString()
                else:
                    iprot.skip(ftype)
            elif fid == 2:
                if ftype == TType.I32:
--                    self.param2 = TestEnum(iprot.readI32()).name
++                    self.param2 = TestEnum(iprot.readI32())
                else:
                    iprot.skip(ftype)
            else:
                iprot.skip(ftype)
            iprot.readFieldEnd()
        iprot.readStructEnd()

    def write(self, oprot):
        if oprot._fast_encode is not None and self.thrift_spec is not None:
            oprot.trans.write(oprot._fast_encode(self, [self.__class__, self.thrift_spec]))
            return
        oprot.writeStructBegin('TestStruct')
        if self.param1 is not None:
            oprot.writeFieldBegin('param1', TType.STRING, 1)
            oprot.writeString(self.param1.encode('utf-8') if sys.version_info[0] == 2 else self.param1)
            oprot.writeFieldEnd()
        if self.param2 is not None:
            oprot.writeFieldBegin('param2', TType.I32, 2)
--            oprot.writeI32(TestEnum[self.param2].value)
++           oprot.writeI32(self.param2.value if hasattr(self.param2, 'value') else TestEnum[self.param2].value)
            oprot.writeFieldEnd()
        oprot.writeFieldStop()
        oprot.writeStructEnd()

    def validate(self):
        return

    def __repr__(self):
        L = ['%s=%r' % (key, value)
             for key, value in self.__dict__.items()]
        return '%s(%s)' % (self.__class__.__name__, ', '.join(L))

    def __eq__(self, other):
        return isinstance(other, self.__class__) and self.__dict__ == other.__dict__

    def __ne__(self, other):
        return not (self == other)
all_structs.append(TestStruct)
TestStruct.thrift_spec = (
    None,  # 0
    (1, TType.STRING, 'param1', 'UTF8', None, ),  # 1
    (2, TType.I32, 'param2', None, None, ),  # 2
)
fix_spec(all_structs)
del all_structs

[ ] Did you create an Apache Jira ticket?  (Request account here, not required for trivial changes)
[ ] If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"?
[x] Did you squash your changes to a single commit?  (not required, but preferred)
[x] Did you do your best to avoid breaking changes?  If one was needed, did you label the Jira ticket with "Breaking-Change"?
[ ] If your change does not involve any code, include [skip ci] anywhere in the commit message to free up build resources.

does this only affect how the python lib is called or does this actually affect how the serialized binary blob (aka wire protocol) would look like?
if this affects how the binary blob would look like, then this most certainly would break cross-test. we currently don't run cross-tests in github actions because the lib-java-kotlin test is broken, you can temporarily remove that as the dependency of cross-test in your PR to make it run cross test.

I see. So this is only about the "constructor", but the actual constructor doesn't do anything special and just stores the args, and all the special logic happens in other functions using the stored args.
I think it would make more sense to actually move the logic to constructor instead, e.g. convert either string or actual enum to the actual enum, so we don't have to do the same check everywhere else.

I see. So this is only about the "constructor", but the actual constructor doesn't do anything special and just stores the args, and all the special logic happens in other functions using the stored args.
I think it would make more sense to actually move the logic to constructor instead, e.g. convert either string or actual enum to the actual enum, so we don't have to do the same check everywhere else.

The issue is that people can construct the struct and then serialize/deserialize the struct later. I'm fine with your suggestion but it could potentially be breaking behavior.
struct = TestStruct(param1="test_string")
struct.param2="TestEnum1"
# serialize/deserialize logic ...

right but this is python so it's very hard to force anything, I guess? we don't even have type annotation (I believe there's an open ticket for that just no one picking it up yet).
so even if we move the logic to constructor the risk of someone doing other thing to override it is. I guess the current approach makes sense in the given circumstances.

right but this is python so it's very hard to force anything, I guess? we don't even have type annotation (I believe there's an open ticket for that just no one picking it up yet).
so even if we move the logic to constructor the risk of someone doing other thing to override it is. I guess the current approach makes sense in the given circumstances.

We can force this to be an enum by refusing to parse the value if it's a string but that would be a breaking change. I think its the right thing to do and I am okay with making this change as I'm pretty certain very few people use this functionality because it doesn't really make sense when interchanging strings/enums.

@fishy I gave it another try and I think this code is a bit more complex but is safer change to take in. It will essentially force the type to become an Enum and simplifies the hasattr check.
https://github.com/apache/thrift/pull/2825


Running apps from symlinks causes issues with debugging because the symlinks are resolved somewhere

This came up at https://github.com/Dart-Code/Dart-Code/issues/3896. It's not clear whether this is working as intended or a bug, but essentially if you run an app from a symlinked folder, something is resolving the symlinks which causes the paths to be sent back from the debugger to not match what's open in the IDE which causes all sorts of issues.
To repro:

Create a sample Dart CLI app in a folder named real_app
Change the implementation of main() to print('Hello world: ${Directory.current}!');
Create a symlink at linked_app that points to it
Delete .dart_tool, .packages if they exist
Run dart pub get inside linked_app
Verify that in .dart_tool/package_config.json there are only relative paths, nothing that crosses into real_app
Run the app using dart bin/foo.dart from inside the linked_app folder

The printed directory is the resolved folder and not the symlink as expected. If you run with --observe, you also see real_app as the library URI:

I'm not sure what's resolved the symlinks (or whether it's for good reason), but it does cause issues if the IDE believes the paths are one thing, and the debugger believes they are something else (for example setting breakpoints via the symlink does not cause them to actually apply to the running app).
@a-siva @mraleph I'm told you may best understand the components involved here so might understand where this is likely happening (and whether it's deliberate or avoidable).

I think you & @bkonyi have identified the root source of the problem correctly. Directory.current returns current directory with symlinks resolved and consequently package_config uses this resolved URI as a base location to resolve package:-uris into file: uris so the base component of the path has resolved path. The situation is a bit messy here though: package_config uses resolved root but does not actually resolve any subcomponents so file URIs emitted by CFE would contain mixed components (some symlinks resolve - some not).
It would be best if we were setting breakpoints in libraries using their import URIs rather than file URIs. Because import URIs are expected to be canonical and could be used to uniquely identify any library. But for that to work IDE should be able to compute canonical import URI for any given file it wants to set breakpoints in.
Alternatively you could put a workaround in the IDE plugin that takes into account the current canonicalisation behaviour and always resolves symlinks in the root location.
/cc @bkonyi @johnniwinther @lrhn to keep the folks in the loop.

It's not really possible to do this in the IDE in VS Code's case, since talks directly to the DAP server. It would have to go there (which now lives in the SDK). Although it feels odd to make this the responsibility of all of the tools talking to the VM Service - there are many of them so it seems like lot of duplicated work for something that they are not causing (I don't think it's obvious that Dart would resolve symlinks and not use the paths given to it).
It's also quite difficult to translate the paths because it would have to be done in both directions (eg. when the debugger breaks in a library that we didn't send any breakpoints in, we need to map that resolved path back to a symlinked path that matches what the user/IDE expects, which has to include assumptions - including that there are never two symlinked paths resolving to the same real path).
Is there a reason Dart must resolve the symlinks, and can't just use the paths as-is?

Is there a reason Dart must resolve the symlinks, and can't just use the paths as-is?

Well, Dart does not have to resolve symlinks, in fact there is no code that explicitly does it.  I think the only reason this happens is because some OS APIs (like getcwd which is used to implement Directory.current) are returning resolved paths. There is nothing we could do to avoid that.
I guess another way to workaround this problem is to change the way package_config.json is found. Instead of letting CFE search it via Directory.current which would lead to resolved path you could explicitly pass it down. This way you will synchronise which paths an IDE and CFE are using.
I am not sure if flutter tooling has enough configurability for this, but you can check this in CLI by doing:
$ dart --packages=$PWD/.dart_tool/package_config.json bin/foo.dart

If you connect to vm-service here and look at file uris for libraries then you should see paths going through symlinks.

@mraleph sorry for the delay. I tested your suggestion, but it didn't seem to make any difference:

However, it gave me the idea to try a full path to the entry point:
danny@Dannys-MacBook-Pro linked_app % dart --observe /Users/danny/Dev/TestStuff/linked_app/bin/real_app.dart

And that worked:

So I guess the issue is resolving the relative path passed. I'll do some testing to see whether passing the full absolute path in all cases (including tests, Flutter, etc.) all behave correctly and if so, that might be a reasonable fix.
Thanks!

sorry for the delay. I tested your suggestion, but it didn't seem to make any difference:

Okay, that's funny. Apparently instead of just passing --packages directly to CFE we relativize it on the way for some reason, which of course defeats the whole purpose of absolute paths.
I have been testing before by invoking CFE directly and looking at resolved paths inside the kernel AST.

I did some quick testing of the following:
dart /path/to/foo.dart
dart test /path/to/foo_test.dart
flutter run -t /path/to/lib/main.dart
flutter test /patj/to/project

And from the (so far limited) testing, it seems like all of them work correctly (the cwd matches the project path ofc). I'll try to get my integration tests working this way to get more coverage, and if everything seems to work, I think we can use this as a fix (I actually think the SDK DAPs may already be passing full paths for the Dart stuff).


Steam TOTP is broken

Yubico Authenticator version: 5.0.5
Operating system and version:  Windows 10
YubiKey model and version: 5 NFC
Bug description summary: "Steam:" prefixed entries are not supported anymore.

Steps to reproduce

Create an account prefixed by "Steam:"

Expected result

The resulting TOTP code is 5 alphanumeric characters

Actual results

The resulting TOTP code is 6 numeric characters

Other info
This used to work and was broken in this commit : f081fbe33987e957b82d87f1e7789689877e6af7
See code there : https://github.com/Yubico/yubioath-desktop/blob/e0ec006d39180c441a9ace29458bd19fa90d63cf/yubioath/core/standard.py
Currently working in the CLI app : https://github.com/Yubico/yubikey-manager/blob/258cf6c03c47f859e050b3c2d253271863f6d601/ykman/oath.py

Hi,
Thanks for finding this and reporting to us. We will fix this for the next release. In the meantime, I would recommend using version 5.0.4.

What an excellent news, thanks !


Rapid up-down scrolling (mouse wheel) is corrupting text

Type: Bug
All plugins removed.
Open C source file.  Using the mouse wheel rapidly scroll up and down, as you might do when flicking through code.
Fragments of code start being blatted across other sections, this is not just visual but actually corrupting the text file.   This is recent behaviour, I've used VSCode for a year or so on this install of Unbuntu (22.04) without any problems.  It actually seems to be getting progressively worse (although that could be my imagination playing tricks).
Probably unrelated but I have had recently, very briefly, MS CoPilot Plugin installed, I found this too invasive and removed it.
I am able to reliably reproduce this and can provide a screen capture of this occuring.
Thanks.
VS Code version: Code 1.91.1 (f1e16e1e6214d7c44d078b1f0607b2388f29d729, 2024-07-09T22:08:12.169Z)
OS version: Linux x64 6.5.0-44-generic
Modes:

System Info

Item
Value

CPUs
12th Gen Intel(R) Core(TM) i7-1255U (12 x 3922)

GPU Status
2d_canvas: enabledcanvas_oop_rasterization: disabled_offdirect_rendering_display_compositor: disabled_off_okgpu_compositing: enabledmultiple_raster_threads: enabled_onopengl: enabled_onrasterization: enabledraw_draw: disabled_off_okskia_graphite: disabled_offvideo_decode: enabledvideo_encode: disabled_softwarevulkan: disabled_offwebgl: enabledwebgl2: enabledwebgpu: disabled_off

Load (avg)
1, 1, 1

Memory (System)
23.16GB (20.79GB free)

Process Argv
--crash-reporter-id 8dcb86a5-16eb-4840-8055-a140561ea809

Screen Reader
no

VM
0%

DESKTOP_SESSION
ubuntu

XDG_CURRENT_DESKTOP
Unity

XDG_SESSION_DESKTOP
ubuntu

XDG_SESSION_TYPE
wayland

Extensions: none
A/B Experiments
vsliv368:30146709
vspor879:30202332
vspor708:30202333
vspor363:30204092
vscod805cf:30301675
binariesv615:30325510
vsaa593cf:30376535
py29gd2263:31024239
c4g48928:30535728
azure-dev_surveyone:30548225
962ge761:30959799
pythongtdpath:30769146
welcomedialog:30910333
pythonnoceb:30805159
asynctok:30898717
pythonregdiag2:30936856
pythonmypyd1:30879173
h48ei257:31000450
pythontbext0:30879054
accentitlementsc:30995553
dsvsc016:30899300
dsvsc017:30899301
dsvsc018:30899302
cppperfnew:31000557
dsvsc020:30976470
pythonait:31006305
dsvsc021:30996838
g316j359:31013175
pythoncenvpt:31062603
a69g1124:31058053
dvdeprecation:31068756
dwnewjupyter:31046869
impr_priority:31094925
refactorc:31098050
pythonrstrctxtcf:31093870
4930e709:31092288
hdi1a554:31097393

I've been able to reproduce this same problem in Eclipse so this is not specific to VS Code.  Closing.


[Feature request] knowledge.ca support

DO NOT REMOVE OR SKIP THE ISSUE TEMPLATE

[X] I understand that I will be blocked if I intentionally remove or skip any mandatory* field

Checklist

[X] I'm reporting a new site support request
[X] I've verified that I have updated yt-dlp to nightly or master (update instructions)
[X] I've checked that all provided URLs are playable in a browser with the same IP and same login details
[X] I've checked that none of provided URLs violate any copyrights or contain any DRM to the best of my knowledge
[X] I've searched known issues and the bugtracker for similar issues including closed ones. DO NOT post duplicates
[X] I've read the guidelines for opening an issue
[X] I've read about sharing account credentials and am willing to share it if required

Region
Canada
Example URLs
https://www.knowledge.ca/program/sgaawaay-kuuna-edge-knife
Provide a description that is worded well enough to be understood
Needs a free account and is geoblocked to Canada.
Provide verbose output that clearly demonstrates the problem

[X] Run your yt-dlp command with -vU flag added (yt-dlp -vU <your command line>)
[X] If using API, add 'verbose': True to YoutubeDL params instead
[X] Copy the WHOLE output (starting with [debug] Command-line config) and insert it below

Complete Verbose Output
yt-dlp -vU https://www.knowledge.ca/program/sgaawaay-kuuna-edge-knife
[debug] Command-line config: ['-vU', 'https://www.knowledge.ca/program/sgaawaay-kuuna-edge-knife']
[debug] Encodings: locale UTF-8, fs utf-8, pref UTF-8, out utf-8, error utf-8, screen utf-8
[debug] yt-dlp version<EMAIL_ADDRESS>from yt-dlp/yt-dlp [12b248ce6] (debian*)
[debug] Python 3.12.4 (CPython x86_64 64bit) - Linux-6.8.12-amd64-x86_64-with-glibc2.38 (OpenSSL 3.2.2 4 Jun 2024, glibc 2.38)
[debug] exe versions: ffmpeg 6.1.1-4 (setts), ffprobe 6.1.1-4
[debug] Optional libraries: Cryptodome-3.20.0, brotli-1.1.0, certifi-2024.06.02, mutagen-1.46.0, requests-2.32.3, secretstorage-3.3.3, sqlite3-3.46.0, urllib3-2.0.7, websockets-10.4
[debug] Proxy map: {}
[debug] Request Handlers: urllib, requests
[debug] Loaded 1820 extractors
[debug] Fetching release info: https://api.github.com/repos/yt-dlp/yt-dlp/releases/latest
Latest version<EMAIL_ADDRESS>from yt-dlp/yt-dlp
yt-dlp is up to date<EMAIL_ADDRESS>from yt-dlp/yt-dlp)
[generic] Extracting URL: https://www.knowledge.ca/program/sgaawaay-kuuna-edge-knife
[generic] sgaawaay-kuuna-edge-knife: Downloading webpage
WARNING: [generic] Falling back on generic information extractor
[generic] sgaawaay-kuuna-edge-knife: Extracting information
[debug] Looking for embeds
ERROR: Unsupported URL: https://www.knowledge.ca/program/sgaawaay-kuuna-edge-knife
Traceback (most recent call last):
  File "/usr/lib/python3/dist-packages/yt_dlp/YoutubeDL.py", line 1606, in wrapper
    return func(self, *args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3/dist-packages/yt_dlp/YoutubeDL.py", line 1741, in __extract_info
    ie_result = ie.extract(url)
                ^^^^^^^^^^^^^^^
  File "/usr/lib/python3/dist-packages/yt_dlp/extractor/common.py", line 734, in extract
    ie_result = self._real_extract(url)
                ^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3/dist-packages/yt_dlp/extractor/generic.py", line 2514, in _real_extract
    raise UnsupportedError(url)
yt_dlp.utils.UnsupportedError: Unsupported URL: https://www.knowledge.ca/program/sgaawaay-kuuna-edge-knife

I tried my hand at writing the new extractor but the tests didn't work for me; draft:
diff --git a/yt_dlp/extractor/_extractors.py b/yt_dlp/extractor/_extractors.py
index c411efb5a..4b47ed528 100644
--- a/yt_dlp/extractor/_extractors.py
+++ b/yt_dlp/extractor/_extractors.py
@@ -949,6 +949,7 @@
from .kickstarter import KickStarterIE
from .kinja import KinjaEmbedIE
from .kinopoisk import KinoPoiskIE
+from .knowledge-ca import KnowledgeCaIE
from .kommunetv import KommunetvIE
from .kompas import KompasVideoIE
from .koo import KooIE
diff --git a/yt_dlp/extractor/knowledge-ca.py b/yt_dlp/extractor/knowledge-ca.py
new file mode 100644
index 000000000..68f350340
--- /dev/null
+++ b/yt_dlp/extractor/knowledge-ca.py
@@ -0,0 +1,43 @@
+from .common import InfoExtractor
+
+
+class KnowlegdeCaIE(InfoExtractor):

IE_NAME = 'knowledge.ca'
IE_DESC = 'knowledge.ca videos'
_VALID_URL = r'https?://(?:www.)?knowledge.ca/program/(?P[^/])'
_TESTS = [{

   'url': 'https://www.knowledge.ca/program/sgaawaay-kuuna-edge-knife',

   'md5': 'TODO: md5 sum of the first 10241 bytes of the video file (use --test)',

   'info_dict': {

       # For videos, only the 'id' and 'ext' fields are required to RUN the test:

       'id': '42',

       'ext': 'mp4',

       # Then if the test run fails, it will output the missing/incorrect fields.

       # Properties can be added as:

       # * A value, e.g.

       #     'title': 'Video title goes here',

       # * MD5 checksum; start the string with 'md5:', e.g.

       #     'description': 'md5:098f6bcd4621d373cade4e832627b4f6',

       # * A regular expression; start the string with 're:', e.g.

       #     'thumbnail': r're:^https?://.*\.jpg$',

       # * A count of elements in a list; start the string with 'count:', e.g.

       #     'tags': 'count:10',

       # * Any Python type, e.g.

       #     'view_count': int,

   }

}]

def _real_extract(self, url):

   video_id = self._match_id(url)

   webpage = self._download_webpage(url, video_id)

   # TODO more code goes here, for example ...

   title = self._html_search_regex(r'<h1>(.+?)</h1>', webpage, 'title')

   return {

       'id': video_id,

       'title': title,

       'description': self._og_search_description(webpage),

       'uploader': self._search_regex(r'<div[^>]+id="uploader"[^>]*>([^<]+)<', webpage, 'uploader', fatal=False),

       # TODO more properties (see yt_dlp/extractor/common.py)

   }

Any Progress on this?  Have been wanting to DL from this site for years.  Nobody supports it.

@pto199 Can you share your solution? Which cookie did you use ?

You login to the site on your webbrowser, then you save the cookie to a text file with an extension.  You then use the --cookie flag in YT-DLP and point it to your text file.
Ask Chatgpt for detailed steps on how to save a stream with yt-dlp using a cookie.

thanks, works for me too

The original test show has expired. https://www.knowledge.ca/program/lennonyc is a current test URL.
The critical missing part of the draft code is that no formats have been extracted. The extractor needs to find the actual video link(s) that the browser will use. A link might be a plain mp4 or manifest URL in the HTML sent to a logged-in user, bearing in mind that the extractor will only see the plain HTML (View Source in the browser) and not the version shown in the browser's web tools Inspect HTML tab, which nowadays is likely to have been modified by site JS; or the wanted URL(s) might be constructed by combining URL patterns seen in the browser's web tools with information from the web page.
Should the development guidance be more explicit about this?

The original test show has expired. https://www.knowledge.ca/program/lennonyc is a current test URL.
Ah, thanks.
The critical missing part of the draft code is that no formats have been extracted. The extractor needs to find the actual video link(s) that the browser will use. A link might be a plain mp4 or manifest URL in the HTML sent to a logged-in user, bearing in mind that the extractor will only see the plain HTML (View Source in the browser) and not the version shown in the browser's web tools Inspect HTML tab, which nowadays is likely to have been modified by site JS; or the wanted URL(s) might be constructed by combining URL patterns seen in the browser's web tools with information from the web page.
Ok, will try to look into it.
Should the development guidance be more explicit about this?
Yes. As a somewhat seasoned contributor I was able to follow most but I think that some people might have difficulties to start contributing. Imo the  wiki could use improvement.


🐛 BUG: Astro VS Code extension v2.0.13 causes asset imports to be considered of type string instead of ImageMetadata

Describe the Bug
Imported assets (from assets folder, experimental mode is on) are seen as strings, so TypeScript shows this error when trying to access importedAsset.src:
Property 'src' does not exist on type 'string'. ts(2339)
Using extension v2.0.13.
Reverting to extension version v1.0.8 fixes the problem.
Steps to Reproduce

npm init astro using template
import a file from /src/assets
attempt to access importedFile.src
TypeScript Error: Property 'src' does not exist on type 'string'. ts(2339)

Expected result: no typescript error.

It's highly likely that the extension here is not wrong, but something in the project is overwriting the proper types. The previous version wrongly missed some types at times.
An easy way to test it is to see if you have the same types in .ts and .astro files, .ts being the one that's in the right.
I'll investigate to see if it's something in our types, and what we can do about it if so


White page when deploying to device

Hello,
I am following the documentation and I've created a new ember app, and ran corber init after that. ember server shows the ember welcome page neatly in my browser. However, when I run:
corber build --platform=android --environment=production
and then
corber proxy run android --device --nobuild
with my device connected and usb debugging enabled, it starts up the app, but it only shows a blank page.
The whole project and setup is vanilla, plainly followed the documentation. Surely something is wrong here?
I am using an Android 4.1.2 phone.

Hi Harm! Thanks, but I tried that already. I placed a h1 tag with hello world instead of the ember welcome page and it is still blank...
Limited message sent from my mobile device.

Op 17 apr. 2018 om 14:54 heeft Harm van de Ven<EMAIL_ADDRESS>het volgende geschreven:
@Pimnr47, I believe we both fell for the same small issue (yes, it caused me a couple of hours, and I needed the help of a friend to fix this). When in Ember you build for production the default Ember welcome page is not rendered. When I placed some random text in my application.hbs it appears my page is not blank at all....
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

 It works now. I think I haven't been building the app correctly (wrong java versions, etc.) and I changed to an Android emulator running android 6 instead of my old Android phone device.