[manila-csi-plugin] ControllerExpandVolume rounds up size to GiB

What this PR does / why we need it:
ControllerExpandVolume doesn't round up new size to GiB leading to an error described in #1764. This PR fixes bytesToGiB which ControllerExpandVolume uses to convert the input size in bytes to GiB.
Which issue this PR fixes(if applicable):
fixes #1764
Special notes for reviewers:

Logs:
I0124 13:50:37.660046       1 driver.go:314] [ID:15] GRPC call: /csi.v1.Controller/ControllerExpandVolume
I0124 13:50:37.660069       1 driver.go:315] [ID:15] GRPC request: {"capacity_range":{"required_bytes":2000000000},"secrets":"***stripped***","volume_capability":{"AccessType":{"Mount":{}},"access_mode":{"mode":5}},"volume_id":"b9eeed27-a1f8-4de2-8161-9af786ba24b8"}
I0124 13:50:37.660393       1 client.go:252] Using user-agent manila-csi-plugin/f1499fbb-dirty gophercloud/2.0.0
I0124 13:50:40.961397       1 driver.go:320] [ID:15] GRPC response: {"capacity_bytes":2147483648}
I0124 14:04:45.315667       1 driver.go:314] [ID:16] GRPC call: /csi.v1.Controller/ControllerGetCapabilities
I0124 14:04:45.315761       1 driver.go:315] [ID:16] GRPC request: {}
I0124 14:04:45.316042       1 driver.go:320] [ID:16] GRPC response: {"capabilities":[{"Type":{"Rpc":{"type":1}}},{"Type":{"Rpc":{"type":5}}},{"Type":{"Rpc":{"type":9}}}]}
I0124 14:04:45.318129       1 driver.go:314] [ID:17] GRPC call: /csi.v1.Controller/ControllerExpandVolume
I0124 14:04:45.318151       1 driver.go:315] [ID:17] GRPC request: {"capacity_range":{"required_bytes":3221225472},"secrets":"***stripped***","volume_capability":{"AccessType":{"Mount":{}},"access_mode":{"mode":5}},"volume_id":"b9eeed27-a1f8-4de2-8161-9af786ba24b8"}
I0124 14:04:45.318986       1 client.go:252] Using user-agent manila-csi-plugin/f1499fbb-dirty gophercloud/2.0.0
I0124 14:04:49.177117       1 driver.go:320] [ID:17] GRPC response: {"capacity_bytes":3221225472}

Issue in the linked bug report now goes away and resizing works correctly despite requesting new size in wrong units.
Release note:

NONE

Another approach would be to return an error on values that are not aligned to GiB, but to stay consistent with what CreateVolume does, it's probably better to just silently round up.

PTAL @ramineni @gouthampacha @tombarron

@gman0 looks good to me. Hope its documented somewhere that it gets round up GiB , when the unit given is GB

/lgtm

@ramineni it's not documented actually. The allocation unit in Manila is GiB, so it is implied that that's what users are going to get in any case. But it certainly wouldn't hurt to put this in the docs, that's for sure.
I hope that's a correct assumption @gouthampacha ^ ?

@ramineni it's not documented actually. The allocation unit in Manila is GiB, so it is implied that that's what users are going to get in any case. But it certainly wouldn't hurt to put this in the docs, that's for sure.
I hope that's a correct assumption @gouthampacha ^ ?

Yes; and this is true across OpenStack storage -- the unit of measurement is gibibytes (GiB) and minimum size of volumes (cinder) and shares (manila) is 1 GiB -- the API will reject fractional size requests, so it makes sense for the CSI drivers to convert and round up when the request isn't in whole GiB numbers. +1 on adding this to the manila/cinder-csi docs as well.
Thank you @gman0
/lgtm
/approve


Rename feature use-std to just std

The api-guidelines explicitly argues for the use of "std" as the feature name instead of "use-std.
So would probably be nice to update it for the 2.0 release.

Can probably do that today, by introducing std which depends on use-std, only removing use-std in 2.0.


[MM-22161] - Improve accessibility of channel switcher

Summary
Improved accessibility for channel switcher, added description for modal and actions as well as listing the channels provided.
Ticket Link
https://mattermost.atlassian.net/browse/MM-22161

Thank you @nevyangelova
Tested using macOS accessibility VoiceOver

Verified that dialog opens and indicates that it’s a dialog, text field, and reads the help text: "Type to find a channel. Use UP/DOWN to browse, ENTER to select, ESC to dismiss."

Verified using up/down arrows I can navigate through results and read channel names

I am seeing few smaller issues:

Text was changed from "Type to find a channel. Use 🔼 🔽 to browse,ENTER to select, ESC to dismiss." to "Type to find a channel. Use UP/DOWN to browse,ENTER to select, ESC to dismiss."

Unable to scroll up/down and read Unread channel names that are present when the modal is first open

When typing a search word e.g. test, help text (see below) is read again before top search result is read

VoiceOver is unable to read channels from the bottom of the list, the ones user does not belongs to (under `other channels')

Correction:
Out of scope - Verified points  2. and 4. on community, release and daily and it works the same as on the PR test server. Channel names in Unread Channels and Other Channels sections are not read by the VoiceOver when using up/down arrows.
@esethna Should we fix here as part of this PRI or create a new issue for follow up? Thanks.

@jgilliam17 we should fix this as part of this PR. Can you also help text on JAWS Windows? Please ask Linda for a license if you don't have it. Thanks.

/update-branch

Fixed, @esethna @jgilliam17

If I don't update the text to 'up/down' the screen reader won't read the symbols, I checked on mobile web and the same thing has been done there so it will be read out.

You probably need to wait for the screen reader to read the hint first. Fixed.

This is default browser behaviour for Chrome and its not repeated in Firefox for example. If you check Google or Stack overflow or any other site with a search box you will see the same behaviour.

Fixed.

Thank you @nevyangelova
Using Jaws on Windows

Verified that dialog opens and indicates that it’s a dialog, text field, and reads the help text: "Type to find a channel. Use UP/DOWN to browse, ENTER to select, ESC to dismiss."
Verified using up/down arrows I can navigate through results and read channel names, including unread, and other results.

I am seeing a new issues

Using arrows does not scroll the list results up, shows red outline outside the modal
Hitting Enter does not select the channel

@nevyangelova  I retested on daily for comparison

Using arrows does not scroll the list results up, shows red outline outside the modal

^ This is out of scope, works this way on daily. We can create a new issue for follow up.

Hitting Enter does not select the channel

This is a regression on this PR, on daily, hitting Enter selects the channel you navigated to using arrows

Thank you @nevyangelova
Tested, looks good to merge.

Verified dialog help text and up/down arrow navigation, Enter and ESC selection works as expected.

This is in progress and will miss code complete, so I'll push it to v5.29 for now. This is not a regression.

@amyblais its not it just needs reviews

/update-branch

/cherry-pick release-5.29

Cherry pick is scheduled.


Keys command: Non-uniform behavior

I am trying out etcd recently. I am confused by some edge cases about key commands.
Why do these two commands have different behaviors?
I can change a file to a directory with the following command:
> curl localhost:4001/v2/keys/file?value=1 -XPUT
{"action":"set","node":{"key":"/file","value":"1","modifiedIndex":124,"createdIndex":124}}
> curl localhost:4001/v2/keys/file?dir=true -XPUT
{"action":"set","node":{"key":"/file","dir":true,"modifiedIndex":125,"createdIndex":125},"prevNode":{"key":"/file","value":"1","modifiedIndex":124,"createdIndex":124}}

But if I add a prevExist=true here, it will ignore my dir=true tag, and just erase the value of /file into empty string.
> curl localhost:4001/v2/keys/file?value=1 -XPUT
{"action":"set","node":{"key":"/file","value":"1","modifiedIndex":127,"createdIndex":127}}
> curl 'localhost:4001/v2/keys/file?dir=true&prevExist=true' -XPUT
{"action":"update","node":{"key":"/file","value":"","modifiedIndex":128,"createdIndex":127},"prevNode":{"key":"/file","value":"1","modifiedIndex":127,"createdIndex":127}}

Could you please explain me about this? Is it designed to behave in this way? If not, which one is the standard way?

In the first case, the key is replaced totally, instead of update. You could check that the createdIndex in the second one is 125, which indicates it is a totally new key.
The second case assumes that you are working on a non-dir key. So it ignores dir=true, and parse prevExist=true to update the existing key. Because you don't give value, it sets the value to empty string.

I suppose that you have read the answer and feel satisfied about it. Feel free to continue discussion here.

Yes, your answer make me more clear about it. Thanks!


nvkelso/update-docs

Reformat entire layers.md document!
Add overview section: data sources and attribution, name localization, geometry types, data updates, and link to changelog
Add at least one example picture per layer (roads layer has many!)
Add new layers from v0.2 - v0.7 (like boundaries)
Indicate if what geometry types are included in the layer
Detail expanded whitelist of POI, road, water, and other kind values per layer
Indicate rough zoom ranges for features per layer (roads, pois)
Update properties list per layer, grouping into common, common optional, and optional sections
Document transform properties like landuse_kind and exterior water boundary
Note tips and gotchas inline with each layer
Minor updates to the display-tiles.md document to link directly to demo maps and source code
There are still some loose ends, but it's a huge step forward!

@rmarianski and @zerebubuth for review.
There are probably still some loose ends, but it's a huge step forward! I'd like to get this merged by Wednesday, we can make further changes once it's in master.
/cc @bcamper @migurski

It's easiest to preview (with images and formatting) here:
https://github.com/mapzen/vector-datasource/blob/nvkelso/update-docs/docs/layers.md

:+1: Nice work bringing this up to date! :zap:
Also noting that the changes suggested in #532, specifically being more explicit about what tag values we require for inclusion, will allow us to more confidently enumerate the possible kind values for more layers.

I think this is ready to merge.


fix(dropdown): Click outside dropdown

Clicking outside dropdown is now closing the dropdown.
Closes https://github.com/ngOfficeUIFabric/ng-officeuifabric/issues/254

Changes Unknown when pulling f9450e98bace48efb55870291f2b0ac7164ed4ef on rolandoldengarm:issue-254 into ** on ngOfficeUIFabric:dev**.

Changes Unknown when pulling b379352c6a14ce4d7fe52c6e276d440053fbff8e on rolandoldengarm:issue-254 into ** on ngOfficeUIFabric:dev**.


Created new frontend pages

Description

Related Issue

Does this introduce a breaking change?

[ ] Yes
[ ] No

Other information

Lgtm!


cli tool requires kubectl to be run before it in order for GKE auth to work

kubectl apparently does something that triggers a OAuth token refresh when it is expired, which the conduit CLI tool doesn't do. We need to figure out what kubectl is doing and do the same in the conduit CLI tool.

This might be caused by us using an old version of the client-go library. We should try upgrading to the newest version of client-go to see if that fixes this problem.

I'd be happy to take a stab at that, and agree that it would be great to update client-go. Will assign to myself. We had some issues initially with a bad interaction between client-go and dep, but I can't remember specifically what went wrong. It's also possible that has been fixed now.


Add a tab next to History tab on the side bar for graph resources.

Is your feature request related to a problem? Please describe.
Now that we have all resources and navigation properties in autocomplete endpoint of DevX API we can have a tab dedicated for these on GE
Describe the solution you'd like
Add a resources tab on Graph Explorer next to History that lists all parent resources and their children on Graph API together with the navigation properties. Like in the screenshots below:

When one selects, the query is pasted on the address bar.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.
AB#7498

Closing this as the resource explorer will be a fly out


css reset for recaptcha to fix display issues

Well. If it renders alright on Linux, then everything is fine. :)

Amazing!

Not amazing, it's a missing reset on Recaptcha. I hate the "let's embed html and reset everything that might have changed" approach. I hope the component stuff will be usable soonish.

Amazing that you fixed it, not that you had to do it :wink:


Sharing copy feature doesn't work on IOS

Share dialog copy not working on IOS.

Still repro

This works now on iOS 11


Feature request: provide a default JWT token validator

authlib contains pretty much all you need to implement JWT token validation. It would be nice if there was a simple default one provided. I'm not sure how many moving parts it would have. If no single validator would cover 80% of cases, maybe provide more docs on how to assemble one.
@lepture If you have a general idea of how you would like to see this implemented I would probably be able to do it.

I'm sorry to be way too brief again. I meant a Flask BearerTokenValidator that uses a token based on JWTClaims. This is something I quickly came up:
class JWTToken(JWTClaims, TokenMixin):
    def get_scope(self):
        return self.get("scope")

    def get_expires_at(self):
        return self.get("exp")

class JwtBearerTokenValidator(BearerTokenValidator):
    def __init__(self, realm=None, **decode_kwargs):
        super().__init__(realm)
        if "claims_cls" not in decode_kwargs:
            decode_kwargs["claims_cls"] = JWTToken
        self.decode_kwargs = decode_kwargs

    def authenticate_token(self, token_string):
        return jwt.decode(token_string, **self.decode_kwargs)

    def request_invalid(self, request):
        return False

    def token_revoked(self, token):
        return False

token_validator = JwtBearerTokenValidator(key=app.secret_key)
ResourceProtector.register_token_validator(token_validator)
require_oauth = ResourceProtector()

This is flexible enough to validate, for example, a token generated by Auth0 by setting key to a function that gets the key from a JWKS and claims_options to validate issuer and audience.

Is there a RFC? Authlib won’t contain it if there is no standard RFC. You can share your idea in your blog. Or I can put your idea in https://blog.authlib.org/

No, I don't believe the use of JWT as access tokens is covered in any RFC. However, it is in common use with commercial identity providers. The code above is merely glue between existing parts of authlib, in the same way as OAuth2TokenMixin is used to bridge the ResourceProtector to the Authorization Server.
I appreciate authlib's focus to implement the RFC building blocks. It's not trivial, however, to put together those building blocks into a application, so I thought some guidance would be nice. I think something like the code above would do it, but whether to include it in the code or add it to the docs (or in a closed GitHub issue :wink:) I'll leave to you. Whatever you decide, I can do a PR with the change if that is useful.

@jcassee did this ever get implemented? i'm also trying to do something similar with a Flask Rest API and was wondering if there's any custom code that can validate JWT tokens provided by a OpenID server
i'm not sure if this RFC is official though: https://tools.ietf.org/html/rfc7523

@DustinKLo the RFC you pointed is not related to this issue. But this RFC is already implemented in Authlib.

I've added a built-in JWT Bearer token generator and validator into RFC7523. But there should be a documentation for it.

https://github.com/lepture/authlib/commit/695af265255853310c905dcd48b439955148516f

No, I don't believe the use of JWT as access tokens is covered in any RFC

It's now covered in https://datatracker.ietf.org/doc/html/rfc9068 - would you be interested in a PR @lepture?

@adamjmcgrath yes, please.

Close this issue in favor of #427. There is a standard for JWT access token now.


FormBuilderSegmentedControl textStyle missing?

Hello,
Firstly thank you for the great work you've done developing and maintaining this package.
I recently upgraded this package and found that the textStyle attribute is missing for FormBuilderSegmentedControl.
Could anyone point me in the direction of how I could change the textStyle of the text contained within each selection box of the FormBuilderSegmentedControl please?
Thanks in advance.

This still an issue?

Due to lack of response and an old error, I will close this issue.
If the bug still exists, feel free to open a new issue


cmd/compile: nosplit stack overflow with gcflags "-N -l"

What version of Go are you using (go version)?

 % go version
go version go1.18.4 darwin/arm64

Does this issue reproduce with the latest release?
Yes
What operating system and processor architecture are you using (go env)?
go env Output
$ go env
GO111MODULE=""
GOARCH="arm64"
GOBIN=""
GOCACHE="/Users/spike/Library/Caches/go-build"
GOENV="/Users/spike/Library/Application Support/go/env"
GOEXE=""
GOEXPERIMENT=""
GOFLAGS=""
GOHOSTARCH="arm64"
GOHOSTOS="darwin"
GOINSECURE=""
GOMODCACHE="/Users/spike/go/pkg/mod"
GONOPROXY=""
GONOSUMDB=""
GOOS="darwin"
GOPATH="/Users/spike/go"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/opt/homebrew/Cellar/go/1.18.4/libexec"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/opt/homebrew/Cellar/go/1.18.4/libexec/pkg/tool/darwin_arm64"
GOVCS=""
GOVERSION="go1.18.4"
GCCGO="gccgo"
AR="ar"
CC="clang"
CXX="clang++"
CGO_ENABLED="1"
GOMOD="/Users/spike/repos/coder/go.mod"
GOWORK=""
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -arch arm64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/53/zffdtv3x7lg_pyhrk85p7_nw0000gn/T/go-build856354956=/tmp/go-build -gno-record-gcc-switches -fno-common"

What did you do?
I'm working with https://github.com/coder/coder and attempting a debug build in Goland.  Goland calls something like
go test  -gcflags all="-N -l" github.com/coder/coder/coderd/devtunnel

this combination of flags is presumably an attempt to keep breakpoints from being skipped, allow directly stepping through the code, etc.
What did you expect to see?
Successful build & run of test
What did you see instead?
% go test  -gcflags all="-N -l" github.com/coder/coder/coderd/devtunnel
# github.com/coder/coder/coderd/devtunnel.test
runtime.spanOf: nosplit stack overflow
	792	assumed on entry to gvisor.dev/gvisor/pkg/refs.(*AtomicRefCount).DecRef<1> (nosplit)
	744	after gvisor.dev/gvisor/pkg/refs.(*AtomicRefCount).DecRef<1> (nosplit) uses 48
	600	after gvisor.dev/gvisor/pkg/refs.(*AtomicRefCount).DecRefWithDestructor<1> (nosplit) uses 144
	472	after gvisor.dev/gvisor/pkg/refs.(*weakRefList).Remove<1> (nosplit) uses 128
	456	after gvisor.dev/gvisor/pkg/refs.(*weakRefEntry).SetNext<1> (nosplit) uses 16
	232	after runtime.gcWriteBarrier<1> (nosplit) uses 224
	200	after runtime.wbBufFlush<0> (nosplit) uses 32
	168	after runtime.wbBufFlush<1> (nosplit) uses 32
	120	after runtime.cgoCheckWriteBarrier<1> (nosplit) uses 48
	40	after runtime.cgoIsGoPointer<1> (nosplit) uses 80
	8	after runtime.inHeapOrStack<1> (nosplit) uses 32
	-40	after runtime.spanOf<1> (nosplit) uses 48
FAIL	github.com/coder/coder/coderd/devtunnel [build failed]
FAIL

Notes
https://github.com/golang/go/issues/14319 is similar but claims this was fixed long ago, and I'm seeing on latest release.
Interestingly, I can't reproduce it on Ubuntu, but it always happens on macOS for me.

Thanks!  I'll chase them


Install enum34 on all Python < 3.4

I am filing this PR on behalf of the author of GoogleCloudPlatform/google-cloud-python#4115.
In grpc's setup.py, on line 229, you specify the inclusion of enum34 as a dependency if the user is running in Python 2. However, the enum package was not added to the standard library until Python 3.4.
The correct syntax in setup.py to do the right thing all the time is:
    extras_require={
        ':python_version<"3.0"': ('futures >= 2.2.0',),
        ':python_version<"3.4"': ('enum34 >= 1.0.4',),
    },

I recognize that (like us) you likely do not officially support Python 3.3 anymore. However, this is an easy low-hanging fruit item, and it seems reasonably plausible that Python 3.3 will work. Since this is so low-hanging, it seems reasonable to change.
This is also more correct for other reasons (in principle, you can not rely on setup.py to be executed at install time).

:+1: Please merge post haste

Looks fine to me, I'll merge it on passing tests.

@lukesneeringer Just a heads up this PR is for the master branch, so it won't show up on 1.7.
Is this intended?

Is this still actionable? Do we believe there are users still running Python 3.[0, 4)?

Thank you for your pull request. Before we can look at your contribution, we need to ensure all contributors are covered by a Contributor License Agreement.
After the following items are addressed, please respond with a new comment here, and the automated system will re-verify.

User @lukesneeringer isn't covered by a CLA. They will need to complete the form at https://identity.linuxfoundation.org/projects/cncf

Regards,
CLA GitHub bot

Seems obsolete, closing.

How is this obsolete? As I see it, the setup.py file still has the same issue. The declared dependencies still depend on the version of Python the wheel was built with, which is wrong.

@lukesneeringer: should this still be merged? Does this address a need for 2.7 that matters for the next four months?

This PR is superseded by https://github.com/grpc/grpc/pull/18032.


Saving images by date

Hi
Is it possible to configure so that the added images are not just saved in the “images” folder, but in a subfolder but with the date the image was added “images\05-11-23”
I just need to save images by date, then I will clearly understand by folder which image I added when, and it will also get rid of garbage in the “images” folder

Answered in discussion https://github.com/trganda/obsidian-attachment-management/discussions/79


Stanford cars

#5108
I have added Stanford Cars dataset
I have one question regarding the testing class.
This is the following dataset structure -
root/cars_train (training image folder)
root/cars_test (test image folder)
root/cars_test_annos_withlabels.mat (matlab file containing annotation and labels for test dataset)
root/devkit/cars_meta.mat
root/devkit/cars_test_annos.mat
root/devkit/cars_train_annos.mat
root/devkit/readme.txt
root/devkit/train_perfect_preds.txt
I'm using only one file (cars_train_annos.mat) out of all files in root/devkit. so do I have to reproduce fake data files for all files in devkit or just one fake cars_train_annos.mat is sufficient?
This is my first contribution to this repo, let me know if there are any errors.
cc @pmeier

Regarding the code format and the failing CI job: we have a couple of autoformatters that handle this for you. Have a look at our contribution guide.

Regarding the code format and the failing CI job: we have a couple of autoformatters that handle this for you. Have a look at our contribution guide.

hey @pmeier ,
when i run pre-commit run --all-files on local, Mixed line check is failing and it is modifying 608 files because of the same.
Check docstring is first.................................................Passed
Check Toml...............................................................Passed
Check Yaml...............................................................Passed
Mixed line ending........................................................Failed

hook id: mixed-line-ending
exit code: 1

I feel this is wrong, and i feel that only 4 files (that i have edited/added) should be modified by the pre-commit hook.
How to handle this?
Thanks!

I feel this is wrong, and i feel that only 4 files (that i have edited/added) should be modified by the pre-commit hook.

Yes, that is wrong. Are you working on Windows by any chance? Anyway, you can disable it with SKIP=mixed-line-ending pre-commit --all-files

I feel this is wrong, and i feel that only 4 files (that i have edited/added) should be modified by the pre-commit hook.

Yes, that is wrong. Are you working on Windows by any chance? Anyway, you can disable it with SKIP=mixed-line-ending pre-commit --all-files

yes I'm currently using windows machine

im using windows and conda virtual environment

I'm still facing an issue in pre-commit; this is the error that I got after running $SKIP=mixed-line-ending pre-commit run --all-files.
Mixed-line-ending: The term 'mixed-line-ending' is not recognized as the name of a cmdlet, function, script file, or operable program. Check the spelling of the name, or if a path was
included, verify that the path is correct, and try again.
I am trying to search solution for the same.

@abhi-glitchhg Whatever you did, CI is happy with the code format now. You don't have to do anything else in that regard. Anyway, that is on us to investigate and fix. Thanks a lot for reporting the issue.

I have fixed issue with the cars_mata.mat not generated in test, though still unable to test on my local machine. Lets see if the tests are passing or not

@abhi-glitchhg thank you so much for your work on this PR! I took the liberty to fix some minor failures, and do a few cleanups in 8fceb0b  (changes look big but I mostly just moved stuff around, you had done all the hard work already!).
Perhaps @pmeier  can take a final look at it and I'll merge when green?


Update bot scripts to support mongodb database implementation

This includes installing dependencies and providing the necessary inputs to the envvars that are used for the db connection

Hello @kaxada I am interested in working on this. Please assign.

Hello @FaithKovi this issue is still pending given the fact that we haven't reached the implementation and integration of the database like we anticipated but soon we hope to come back here since we are scaling to using the website. Otherwise let me point you to what you can do in this script


netty TCP_NODELAY

I updated from 0.8 to 0.10 and getting following log now:

Jul 25, 2017 11:22:56 AM io.netty.bootstrap.AbstractBootstrap setChannelOption
WARNUNG: Unknown channel option 'TCP_NODELAY' for channel '[id: 0x8db1ec3d]'
Jul 25, 2017 11:22:56 AM io.netty.bootstrap.AbstractBootstrap setChannelOption
WARNUNG: Unknown channel option 'TCP_NODELAY' for channel '[id: 0xaa52e94e]' <

What does it mean? And how can I set 'TCP_NODELAY'?

Seems like this project had the same issue: lettuce, although it is just a warning, not sure if there are any side effects.

Fixed 513d4d79965c41bd76189afcf57bc056cffcac90


Add Touch Bar support

This PR adds support for MacBook Pro Touch Bar. Due to Touch Bar limitations, it can only display seven buttons but that should be enough for most cases.

@HsuanTingLu yes, there's an option to turn it off: https://github.com/suda/tool-bar/issues/213#issuecomment-356117931


[LIBS PLUGINS] Accessors to libs state tables fields

Motivation
Opening this issue first with the intention of seeking clarifications. Based on the answers received, there may or may not be a need to request an expansion or improvement of the plugin API.
While onboarding https://github.com/falcosecurity/plugins/pull/419 to the plugin framework for syscall event analysis augmentation, I encountered a few hiccups:

Whenever the thread entry field was not defined using define_static_field in libs, it seemed inaccessible. For example, the following didn't work: m_exe_from_memfd = m_thread_table.get_field(t.fields(), "exe_from_memfd", st::SS_PLUGIN_ST_BOOL);
Additionally, for non-standard types, I'm unsure how to access them. For instance, the k8smeta plugin fetched the cgroups natively from the event arguments. Is this intentional? It would be beneficial to access these fields after the library has completed its work, regardless. For example, I would prefer to easily access the following thread table entries:

std::vector<std::string> m_args; ///< Command line arguments (e.g. "-d1")
std::vector<std::string> m_env; ///< Environment variables
std::unique_ptr<cgroups_t> m_cgroups; ///< subsystem-cgroup pairs
...

Lastly, I wasn't yet sure how to access the fd table entries, and it seemed the documentation didn't provide examples. However, I might have overlooked them. I would appreciate some initial examples, if possible.
I haven't checked yet how to access container cache entries, but I anticipate this may also be needed down the road, however less urgently for a v1

exe_from_memfd

I think it's safe to add this one to the ones exported by libsinsp.

std::vectorstd::string m_args; std::vectorstd::string m_env; std::unique_ptr<cgroups_t> m_cgroups

Non-trivial types (e.g. vectors, maps) are something we currently don't support in the state API. This is something I have on my backlog since a while and is something I'm trying to figure out the best solution for. My guess is that the k8smeta plugin used the workaround of getting that data from the event payloads themselves, which is also an option for the short term.

Lastly, I wasn't yet sure how to access the fd table entries, and it seemed the documentation didn't provide examples. However, I might have overlooked them. I would appreciate some initial examples, if possible.
I haven't checked yet how to access container cache entries, but I anticipate this may also be needed down the road, however less urgently for a v1

Both the fd tables and the containers table are not exported yet. There are technical implications behind this that are similar to the ones of non-trivial types. Again, this is something I'm working on. How much of a road blocker is this currently for developing your plugin? Is this something you can attain from inspecting event payloads for the short term?

exe_from_memfd

I think it's safe to add this one to the ones exported by libsinsp.

std::vectorstd::string m_args; std::vectorstd::string m_env; std::unique_ptr<cgroups_t> m_cgroups

Non-trivial types (e.g. vectors, maps) are something we currently don't support in the state API. This is something I have on my backlog since a while and is something I'm trying to figure out the best solution for. My guess is that the k8smeta plugin used the workaround of getting that data from the event payloads themselves, which is also an option for the short term.

It would also be fair to find an (interim) way to support a set of currently knows vector types etc, most notable to expose the cmd args as this is part of the backbone of the anomalydetection plugin.

Lastly, I wasn't yet sure how to access the fd table entries, and it seemed the documentation didn't provide examples. However, I might have overlooked them. I would appreciate some initial examples, if possible.
I haven't checked yet how to access container cache entries, but I anticipate this may also be needed down the road, however less urgently for a v1

Both the fd tables and the containers table are not exported yet. There are technical implications behind this that are similar to the ones of non-trivial types. Again, this is something I'm working on. How much of a road blocker is this currently for developing your plugin? Is this something you can attain from inspecting event payloads for the short term?

Thanks @jasondellaluce, basically right now I cannot implement the planned v1 of the anomalydetection plugin, most notable because the fd table is not accessible and there wouldn't even be a workaround. Defining behavior profiles based on fd.name is the top number 1 use case of the planned anomalydetection plugin as I also highlighted during my KubeCon NA 23 talk 🙃
How can I help to make this happen?

@jasondellaluce: @leogr shared that you are already looking into it 🎉 ❤ .
In case a prioritization is useful:
Top 1: Access to fd.name and fd.nameraw and proc.cmdline (using the filtercheck fields for simplicity, you know which members I am referring to).
Actually Top 1 is all that is needed for a v1, but full access to the entire state would of course be ideal.

Timelines:
If we get this in for Falco 0.38.0 I can release an experimental anomalydetection plugin in June/July 2024, the originally planned timeline.

@incertum yes, this is on my plate, so the Falco 0.38 deadline seems very reasonable.

Access to fd.name and fd.nameraw and proc.cmdline (using the filtercheck fields for simplicity, you know which members I am referring to).

Good call about the cmdline, we currently don't share that. As for fd.*, the goal would be to open up all fd-related information!

Opened the first PR implementing the feature. The contribution plan is expected to consists of 4 pull requests:

[ ] Ground work on libsinsp state API: https://github.com/falcosecurity/libs/pull/1838
[ ] Definition of subtables in plugin API and sinsp state API: TBD
[ ] Exposing file descriptor tables from threads table and extensive unit testing: TBD
[ ] Exposing complex data-type fields (e.g. vector of strings env and args) from threads table: TBD

Amazing thanks a bunch @jasondellaluce!

@incertum the changes tracked in https://github.com/falcosecurity/libs/issues/1712#issuecomment-2095568407 are now all merged, and I think this should suit most of the needs for this tickets. The only thing left out is the containers table for now.

Amazing, I'll get back to the plugin soon (after Falco 0.38.0 is out) and will check it out. Thanks so much ❤ !
Should we close this one and open a new one for what's left for future use cases?


Make language codes & names match Google Translate

Codecov Report

Merging #30 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master     #30   +/-   ##
======================================
  Coverage    90.9%   90.9%
======================================
  Files           2       2
  Lines          66      66
======================================
  Hits           60      60
  Misses          6       6

Impacted Files
Coverage Δ

languages.js
100% <ø> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 777d7db...a8f9e28. Read the comment docs.

Coverage remained the same at 90.909% when pulling a8f9e28d0de2a7b229686d87646791ce1e4670e1 on Encrylize:update-languages into 777d7db94f82ec402e7758af1549818c07d55747 on matheuss:master.

Coverage remained the same at 90.909% when pulling a8f9e28d0de2a7b229686d87646791ce1e4670e1 on Encrylize:update-languages into 777d7db94f82ec402e7758af1549818c07d55747 on matheuss:master.

Coverage remained the same at 90.909% when pulling a8f9e28d0de2a7b229686d87646791ce1e4670e1 on Encrylize:update-languages into 777d7db94f82ec402e7758af1549818c07d55747 on matheuss:master.


Stemcell upload

proposed patch for issue number #84
the first commit adds the new functionality, the second commit cleans up the no longer needed methods for locally downloading stemcells.

There is one important use case which is not covered by this PR. Which is bosh prepare deployment --local Which works in environments without internet access. It assumes the needed stemcell is already available in .stemcells. Maybe there should be and option to force stemcells to be cached locally: bosh prepare deployment --cache-locally? Let met know what you think.

--cache-locally sounds good. I am going to provide another commit for this PR. Thanks.

I also support --cache-locally.
I guess it would be also nice to have ability to download stemcells from custom URL or setting path to stemcell file. For instance at the moment I have to do so for Power stemcells. What do you think?

@allomov This sounds like a feature request which I would support, too. I have provided a 2nd pull request to fix the issue only. So this PR is abandoned and I close it.


Doc: VMware vSphere Integration; sample not correct

vmware controller: file upload for custer
VCenter,Datacenter,DatacenterId
myvc1,datacenter1,1
the correct format is
VCenter,Datacenter,DatacenterID

Correct Id into ID


Discrepancies present in PublishAppService.json including uriPrefix, uriScheme

Bug Report
In the release/4.8.0-rc1 branch the uriPrefix, uriScheme may have been added to PublishAppService.json in anticipation for https://github.com/smartdevicelink/sdl_evolution/issues/678, however they are not currently included in the AppServiceManifest structure.
Also the "handledRPCs":["ButtonPress"] field currently contains an incorrect type... the handledRPCs field contains the Function IDs for the RPCs as list of integers but in the PublishAppService,json file it is a list of strings.

uriPrefix and uriScheme were part of the original proposal and they are entered with the structure defined there, but the proposal you linked had a vote to remove them as the author (me) didn't see them as sufficient in their original state (see this commit). Also the functionID's would have been "enums" but in JSON they are entered as strings. Both of those items were altered post the original acceptance of the feature as well as the development of the feature for the platform. The json files are also only for unit tests. However, the json file should be updated.


Fixed broken link for Azure documentation.

High-level description
Fixing the Azure documentation link as the documentation site has been reorganized recently.

@mesosphere-mergebot bump-ee


chore: bump to latest tensorflow version

Context
Tensorflow now supports proto 4 https://github.com/tensorflow/tensorflow/blob/master/requirements_lock_3_10.txt#L314.
We should bump tensorflow version in the pyproject.toml to  latest version that support proto4

I don't think we have a tf version specified at all right now, we just install a certain version in the test CI.
If we now specify this new version that would imply dropping support for all older versions, right?

If we now specify this new version that would imply dropping support for all older versions, right?

yes

I don't think we have a tf version specified at all right now
We don't have a tensorflow version specified because proto version was caped on tensorflow.

This would allow us to have proper dependency management for tensorflow

But here u are proposing only to cap the TF version to a minimum version? If we do not have any reason not to support the previous versions, what would be the benefit?

But here u are proposing only to cap the TF version to a minimum version? If we do not have any reason not to support the previous versions, what would be the benefit?

benefit would be that tensorflow could be registered as a dependency in docarray.
As of today no package manager know that docarray can have tensorflow has a dependecy

But here u are proposing only to cap the TF version to a minimum version? If we do not have any reason not to support the previous versions, what would be the benefit?

benefit would be that tensorflow could be registered as a dependency in docarray.
As of today no package manager know that docarray can have tensorflow has a dependecy

That seems more like a benefit to our dev workflow rather than a user benefit.
Yes, it would be nice for them to do pip install docarray[tf], but in return making it incompatible with every but the very newest tf version doesn't seem like a good tradeoff to me.

well not only our dev workflow but the dev workflow of our user ...
But yeah I see the argument, lets keep it like this then, but in 6 month probably we should reconsider


Project active?

Is this project actively maintained? There has been some months since last commit.

It's still maintained. You are correct that it hasn't been touched it in a while, I haven't been focusing on it as of late. But expect any major issues to get fixed.


extend table interface for NamedMatches

I had originally just extended out the metadata and kept the match, but I think it's more convenient to just include all the fields. The QueryMatch object can be recreated as in the new explain method, which lets you explain rows of the tables.

with the example of the new docs (#8),

using KeywordSearch, Random, DataFrames

queries =  [NamedQuery(FuzzyQuery("dog"), "find dog"),
            NamedQuery(FuzzyQuery("cat"), "find cat"),
            NamedQuery(Query("koala") | FuzzyQuery("Opossum"), "find marsupial")]

words = ["dg", "cat", "koala", "opposum"]
corpus1 = Corpus([Document(randstring(rand(1:10))*rand(words)*randstring(rand(1:10)), (; doc_index = j)) for j = 1:10], (;name = "docs"))

corpus1.documents

corpus2 = Corpus([Document(randstring(rand(1:10)), (; doc_index = 2*j)) for j = 1:10], (;name = "other docs"))

corpuses = [corpus1, corpus2]

matches = [ match(named_query, corpus) for named_query in queries for corpus in corpuses ];
filter!(!isnothing, matches);
DataFrame(matches)

yields this nice table
5×7 DataFrame
 Row │ haystack                           distance  indices    query                              query_name      name        doc_index
     │ Document…                          Int64     UnitRang…  Abstract…                          String          String      Int64
─────┼──────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
   1 │ Document with text "qYdg5 ". Met…         2  2:4        FuzzyQuery{DamerauLevenshtein{No…  find dog        docs                1
   2 │ Document with text "sjg ". Metad…         2  1:3        FuzzyQuery{DamerauLevenshtein{No…  find dog        other docs         14
   3 │ Document with text "9vKKGxdgtswy…         2  7:9        FuzzyQuery{DamerauLevenshtein{No…  find cat        docs                2
   4 │ Document with text "wfRKaI ". Me…         2  4:6        FuzzyQuery{DamerauLevenshtein{No…  find cat        other docs          4
   5 │ Document with text "5tkoalaN6L "…         0  3:7        Query("koala")                     find marsupial  docs                3

whereas on main, the same example gives
5×4 DataFrame
 Row │ match                              query_name      name        doc_index
     │ QueryMat…                          String          String      Int64
─────┼──────────────────────────────────────────────────────────────────────────
   1 │ QueryMatch with distance 2 at in…  find dog        docs                1
   2 │ QueryMatch with distance 2 at in…  find dog        other docs         14
   3 │ QueryMatch with distance 2 at in…  find cat        docs                2
   4 │ QueryMatch with distance 2 at in…  find cat        other docs          4
   5 │ QueryMatch with distance 0 at in…  find marsupial  docs                3

which is less helpful since you have to unpack the QueryMatch yourself.
Being able to do this is the big win of #5 since now we have that all matches are QueryMatches so we can unpack them for you.

Requesting review from @jrevels since he's been messing with Tables.jl so maybe he has thoughts about this.

I wonder if the haystack field should be renamed to document? Originally when I wrote it I thought there might be different kinds of documents but at this point it's always a Document. Even if you match against a Corpus, the haystack field will be populated by a particular Document from that Corpus.


rgb with only two params incorrectly parse color

Hey!
I'm using color package and have some local tests for invalid user input check. After recent release (4.0.2) couple of my tests started failing.
Previously rgb(255,2) color was invalid and now it returns [25, 5, 2].
The same goes for rgba(255,0)  - it returns [25, 5, 0].
Is this expected behaviour? As far as I know, it should be invalid syntax 🤔 .
Thanks! 🙏

Thanks for the report, sorry about that! Fix landed in 32f3e0092ffbe78f4dd7886dd1f225b114fb1a7b, released as 1.8.2.

Thanks, seems it fixed the problem 💯

No problem, thanks for confirming!

Thank you! 🎊


Don't needlessly rerender the whole stack on every stack change

This PR removes the rerendering of the whole stack on every stack change. We noticed that because the index card reloads the items when closing the items on top of it. So this change gets rid of that annoyance too.
Previously (see how it reloads the index card items for no good reason):
https://github.com/cardstack/boxel/assets/273660/c4e5efa0-0248-4b91-8176-d27127caa2b8
After the change:
https://github.com/cardstack/boxel/assets/273660/9112e7d3-e915-405b-8961-d43040f260e1

Hold off with the review please - I discovered a couple of bugs in the operator mode state service

So after removing the roundabout data behaviour where every stack change does a change to the state query param, which then restores (overrides) the whole state from the query param, I discovered multiple bugs in the operator state service.
The nature of these bugs was mostly about stack manipulations in a loop where the loop had an end condition that depended on the stack state that was looked up on every iteration. This completely broke the stack state in some cases.
On the other hand, the stack state query param was written correctly. We did not notice these bugs because on every change, the route would restore the state and rerender from the state in the query param. Removal of this coupling revealed the state in memory was not correct.
This is good to review now - I fixed these bugs and we also shouldn't see reloads and flickering due to stack rerenders anymore.


Debugging on OSX/Darwin always demands user password interaction

Please answer the following before submitting your issue:
Note: Please include any substantial examples (debug session output,
stacktraces, etc) as linked gists.

What version of Delve are you using (dlv version)?
Version: 1.0.0-rc.2
Build: 1758f8523aff3abbb6e07ba8bebac49d70f10c94

What version of Go are you using? (go version)?
go version devel +60be6f85c1 Thu Dec 21 17:00:39 2017 +0000 darwin/amd64
(approximately 1.10beta1)

What operating system and processor architecture are you using?
amd64, OSX 10.12.6

What did you do?
Debugged an executable more than once

What did you expect to see?
A single dialog asking for confirmation and password, across all the N debugging sessions.

What did you see instead?
Every time I debug, a dialog.

I know that there is some way not to require this, because MacPorts gdb 8.0.1 manages not to require this after the first confirmation.  I have tried to find some difference in the files (owner, group, codesigning, etc) that correlated with this different behavior, but no luck yet.  Both binaries are signed with the same certificate, I have tried calling dlv "gdb" instead to see if it depends on some weird hack, ensured that both binaries had same owner, etc, directories had same owner, etc.
Clues:

a difference in behavior when I click "cancel" on the dialog; gdb exits, whereas dlv reasserts the dialog.
I think I have to re-password the dialog for gdb each time I reboot.

I just tested this and it doesn't happen for me or, at least, if I start dlv, quit start it again I don't get a password dialog. This is on 10.12.6 with an unsigned dlv binary.
Since on macOS we don't call the kernel directly but instead go through either lldb-server or debugserver it could depend on that. The debugserver binary is located at /Library/Developer/CommandLineTools/Library/PrivateFrameworks/LLDB.framework/Versions/A/Resources/debugserver if we don't find it we try to use lldb-server instead (which we look for in $PATH). This could have something to do with it.

There's no lldb-server on my path, but there is a debugserver at the location you named, and it appears to be signed:
codesign -d -v -v -v -v -v /Library/Developer/CommandLineTools/Library/PrivateFrameworks/LLDB.framework/Versions/A/Resources/debugserver
Executable=/Library/Developer/CommandLineTools/Library/PrivateFrameworks/LLDB.framework/Versions/A/Resources/debugserver
Identifier=com.apple.debugserver
Format=Mach-O thin (x86_64)
CodeDirectory v=20200 size=37045 flags=0x0(none) hashes=1150+5 location=embedded
OSPlatform=36
OSSDKVersion=658688
OSVersionMin=658176
Hash type=sha256 size=32
CandidateCDHash sha1=230b93f1b5bff52b6cd8b28188b0d6457a83623b
CandidateCDHash sha256=1fbe35ee3ae711005093d9bab9191751a2789c41
Hash choices=sha1,sha256
Page size=4096
    -5=0f03e7ae430135179f41645776f756709b56ff9aa0556992e96a0a81330caa71
    -4=0000000000000000000000000000000000000000000000000000000000000000
    -3=0000000000000000000000000000000000000000000000000000000000000000
    -2=5337899028526c2fc244bf40775eba51fcb0af43470fe07a2f4adcf78f682a50
CDHash=1fbe35ee3ae711005093d9bab9191751a2789c41
Signature size=4535
Authority=Software Signing
Authority=Apple Code Signing Certification Authority
Authority=Apple Root CA
Info.plist entries=6
TeamIdentifier=59GAB85EFG
Sealed Resources=none
Internal requirements count=1 size=72

So not a bug in delve, but a mystery at the Apple end?  Do you know which of these two binaries you are using?

I'm using debug server too:
Identifier=com.apple.debugserver
Format=Mach-O thin (x86_64)
CodeDirectory v=20200 size=37045 flags=0x0(none) hashes=1150+5 location=embedded
OSPlatform=36
OSSDKVersion=658688
OSVersionMin=658176
Hash type=sha256 size=32
CandidateCDHash sha1=e99f66dff7c0a7f4451ec3dca793b248b0f39c18
CandidateCDHash sha256=d286cc84195b28f7f0c2d1ee35dd07bf5f537d87
Hash choices=sha1,sha256
Page size=4096
    -5=0f03e7ae430135179f41645776f756709b56ff9aa0556992e96a0a81330caa71
    -4=0000000000000000000000000000000000000000000000000000000000000000
    -3=0000000000000000000000000000000000000000000000000000000000000000
    -2=5337899028526c2fc244bf40775eba51fcb0af43470fe07a2f4adcf78f682a50
CDHash=d286cc84195b28f7f0c2d1ee35dd07bf5f537d87
Signature size=4535
Authority=Software Signing
Authority=Apple Code Signing Certification Authority
Authority=Apple Root CA
Info.plist entries=6
TeamIdentifier=59GAB85EFG
Sealed Resources=none
Internal requirements count=1 size=72```

maybe it's because I'm using an admin account?

I'm also in the admin group.  I tried firing up XCode to see if there was some preference or something or remaining initialization from the last upgrade, and there were additional installs, but they made no difference even after rebooting the laptop.

Haha, works just fine on my personal laptop at home.  First invocation with dlv exec foo requested password, second did not.  I can compare and contrast in the comfort of my own home, will report back what I find.

https://discussions.apple.com/thread/5083304 could be relevant

We have a winner!
~/.../go/src/cmd/compile/internal/ssa$ DevToolsSecurity
Developer mode is now enabled.
~/.../go/src/cmd/compile/internal/ssa$ DevToolsSecurity
Developer mode is already enabled.

and the problem is solved.


Running in Firebase Function

I am getting run-time error when trying to run LangGraph inside a Firebase function.
Firebase Function:
exports.langgraph = onRequest(async (request, response) => {
  const articleId = request.query.articleId as string;
  const workflow = getWorkflow();

  const result = await workflow.invoke({
    articleId,
  });
  response.json(result);
});

Workflow:
import { END, START, StateGraph } from "@langchain/langgraph";
import { AgentState } from "./state";
import { testNode, wikipediaNode } from "./nodes";
import { researcherNode } from "./nodes/researcher";

export const getWorkflow = () => {
  const workflow = new StateGraph(AgentState)
    .addNode("final", testNode)
    .addNode("wikipedia", wikipediaNode)
    .addNode("researcher", researcherNode)
    .addEdge(START, "wikipedia")
    .addEdge("wikipedia", "researcher")
    .addEdge("researcher", "final")
    .addEdge("final", END);

  return workflow.compile();
};

Error:
⚠  functions: Error: Expected a Runnable, function or object.
Instead got an unsupported type.
    at _coerceToRunnable (/Users/user/workspace/foo-api/functions/node_modules/@langchain/core/dist/runnables/base.cjs:1857:15)
    at StateGraph.addNode (/Users/user/workspace/foo-api/functions/node_modules/@langchain/langgraph/dist/graph/state.cjs:204:57)
    at getWorkflow (/Users/user/workspace/foo-api/functions/lib/src/graph/index.js:11:10)
    at /Users/user/workspace/foo-api/functions/lib/src/index.js:225:46
    at /Users/user/workspace/foo-api/functions/node_modules/firebase-functions/lib/v2/providers/https.js:65:29
    at cors (/Users/user/workspace/foo-api/functions/node_modules/cors/lib/index.js:188:7)
    at /Users/user/workspace/foo-api/functions/node_modules/cors/lib/index.js:224:17
    at originCallback (/Users/user/workspace/foo-api/functions/node_modules/cors/lib/index.js:214:15)
    at /Users/user/workspace/foo-api/functions/node_modules/cors/lib/index.js:219:13
    at optionsCallback (/Users/user/workspace/foo-api/functions/node_modules/cors/lib/index.js:199:9)
⚠  Your function was killed because it raised an unhandled error.

Any thoughts on why this might happen? My code worked with LangGraph studio. I've tried two ways of doing this: 1) the workflow is compiled at script start time, and 2) on demand via getWorkflow(). Both fail with same error.
Thanks

Follow-up: Looks like the issue is what the way nodes are defined. This works fine in LangGraph Studio, but fails at run-time when I hook it up to a Firebase Function. It seems like the graph doesn't like the way the node is defined, which is odd because I am following the docs. Is there something I am missing?
Node:
export const wikipediaNode = async (state: typeof AgentState.State) => {
  const x = state.articleId;
  const articleContent = await fetchArticleContent(Number(x));
  return { article: articleContent };
};

Simplified Example:
❌ FAILS
  workflow = new StateGraph(AgentState)
    .addNode("wiki", wikipediaNode)
    .addEdge(START, "wiki")
    .addEdge("wiki", END);

✅ SUCEEDS
workflow = new StateGraph(AgentState).addEdge(START, END);

Sorry for the delay - this is pretty odd. It should accept a function. Logging wikipediaNode just gives back a function?
Is there anything unique about Firebase Functions as a runtime?

They are just using NodeJS runtime although you can control which NodeJS version.  I wonder if its specific to a NodeJS version?  @objectiveSee what version of NodeJS are you using in your firebase functions?

This is running on node 22. What version have you been using? Have you gotten this to work?

Try adding .js file extensions on your imports


sklearn f1_score method has 'binary' as average default

sklearn f1_score makes use of 'binary' as average default parameter. It means, if the problem is a multiclass ones, it must be changed the average parameter to ones of ['micro', 'macro', 'weighted', 'samples']. In the ml module the sklearn_metric_loss_score is called without specifiyng that parameter. Consequently, at the moment, if a multiclass problem and f1 metric are choosen, a problem arise.
One solution, could be to set average='samples' when the task is multiclass:softmax.
However, choosing one of the above list options, depends on the nature of the labels (balanced/unbalanced). It may be interesting to automate the process of choosing the best metric looking to the nature of the labels.
Any idea?

settings = {
"time_budget": TIME_BUDGET,
"metric": 'f1',
"estimator_list": ['lgbm'],
"task": 'classification',
"log_file_name": 'flaml_lgb.log',
}

Hi @gianpDomiziani,
Thanks for reporting this issue. It seems f1 score is not a commonly used metric for multiclass classification tasks. So it is not clear to me how we should properly chose the 'best' metric in this case.
Among the several average options ['micro', 'macro', 'weighted', 'samples'], 'micro', 'macro', 'weighted' all work well. Do you think it is reasonable to just set the average option to be one of these three in the case of the multiclass classification task?
Thank you!

or maybe we should ask users to specify 'micro_f1', 'macro_f1', etc. as metrics.

Hi @qingyun-wu, yes, you right, it is not very common to use f1 score for multiclass tasks. However, sometimes looking to the f1-micro / f1-macro could be required. By very good, I mean that if the dataset is unbalanced a micro f1 should be used more tough than a macro f1, however it could be an unnecessary complication
Instead, I think the solution proposed by @sonichi should be great. If the task is multiclass f1 shouldn't be a valid option, while micro_f1/macro_f1 yes.

@qingyun-wu do you agree? If so, I'd encourage @gianpDomiziani to create a PR. Thanks.

I agree. Thanks!


Fixes stale columnar limitations in table management

closed by https://github.com/citusdata/citus_docs/pull/1113


Add example for bsnoop file

These files have packets in Bluetooth Attribute protocol (BTATT). It can be supported by formatting input like so:
tshark -r ./example.bsnoop -Y 'btatt.opcode == 0x1b && btatt.handle == 0x002c && btatt.value != 00:00:00:00:00:00:00' -T fields -e btatt.value | sed 's/.*:00/00:&/'

An example appeared on rgbCTF 2020

Sorry for the delay on the review... Thank you for your contribution ... The merge is now with the master branch


Character set conversion for one or more characters is not possible

in the option to open the package i can't see the information and  i have this message

your repository has only a readme (https://github.com/jddtrejo94/Dev). so the issue is related to an object in your Z-package.
try setting a break-point where the exception is probably raise:
https://github.com/abapGit/abapGit/blob/787bc605b078bfef8783093f608c3405f95b0ae9/src/utils/zcl_abapgit_convert.clas.abap#L221
then check the call-stack to find out which object type (zcl_abapgit_object_<type>) it's related to. In that class the value of attribute ms_item will tell you which object is causing the problem.

I only have a program in my packege,  as it is in the following image

my break-point doesn't stop in this exception

thanks for answering me

@jddtrejo94 try placing the breakpoint 4 lines down, at zcx_abapgit_exception=>raise_with_text( lx_error ).  as suggested by Marc

Hello dudes
I found the error, but to be honest, i don't know why i have this error, can someone guide? please.

check the call-stack to find out which object type (zcl_abapgit_object_<type>) it's related to.

My guess is that it's a non-Unicode system. string_to_xstring_utf8_bom might have a bug if iv_string is empty.

I work with ECC non-Unicode system, is there a possibility to do something to solve this error?

what is the callstack at the break-point?

to be honest, i'm not sure what is the callstack at the break-point dude,
i was investigating and i have this data

isn't that data the callstack?

yes, that's the callstack. the problem is a regression of #5638. fix coming up

please test the following change to method serialize (line 55384):
   "unicode systems always add the byte order mark to the xml, while non-unicode does not
    "this code will always add the byte order mark if it is not in the xml
    TRY.   "<<<INS
        lv_mark = zcl_abapgit_convert=>xstring_to_string_utf8( cl_abap_char_utilities=>byte_order_mark_utf8 ).
      CATCH zcx_abapgit_exception ##NO_HANDLER.   "<<<INS
    ENDTRY.   "<<<INS

I want to tell you thanks @mbtools
I could fix the error with your help.


feat(forge): improve UX of expectSafeMemory & expectSafeMemoryCall cheatcodes

Component
Forge
Describe the feature you would like
The cheatcodes currently expect uint64 parameters. It would be nice to have these as uint256 types so as otherwise I imagine the user will have to often convert these.
// Only allows memory writes to offsets [0x00, 0x60) ∪ [_min, _max) in the current subcontext. If any other
// memory is written to, the test will fail.
function expectSafeMemory(uint256 _min, uint256 _max) external;

// Only allows memory writes to offsets [0x00, 0x60) ∪ [_min, _max) in the next created subcontext.
// If any other memory is written to, the test will fail.
function expectSafeMemoryCall(uint256 _min, uint256 _max) external;

PR https://github.com/foundry-rs/foundry/pull/4491 @clabby
Additional context
No response

wdyt @mds1 ?

Seems like you could put a wrapper in forge-std, I don't think values that overflow are sane inputs


Draft/show editor before canvas load finished

I forgot to close this, as per conversation with Malte we decided to tackle this later down the line once we fixed the more fundamental editor load issues


implemented metadata and eventHandler dao in cassandra module

Pull Request Test Coverage Report for Build 3683

367 of 448 (81.92%)  changed or added relevant lines in 5 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.2%) to 69.695%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

cassandra-persistence/src/main/java/com/netflix/conductor/dao/cassandra/CassandraEventHandlerDAO.java
51
73
69.86%

cassandra-persistence/src/main/java/com/netflix/conductor/dao/cassandra/CassandraMetadataDAO.java
119
178
66.85%

Totals

Change from base Build 3677:
0.2%

Covered Lines:
11352

Relevant Lines:
16288

💛  - Coveralls


Build problems on Ubuntu 16.04

Building on Ubuntu 16.04 using "sudo npm install -g --unsafe-perm signalk-server" results in a stream of errors. Although a binary is created it is missing functionality.
error.zip

The log you have attached is not a result of sudo npm install -g --unsafe-perm signalk-server, it is from running bin/n2k-from-file.
The error concerns just the n2k demo data and is actually fixed in master  #820 , thanks for reminding me that we do need a new release.

builderror.zip
Sorry, here is the correct log file

It looks like you have Node JS 12.6.0 installed. We are just now making the transition from version 8 to 10.


Please indicate mechanism to retrieva data returning from a ContractCall.

The reads from a View Call return correctly, but there is no clarity on how to return values from a Call. I specifically need String, Bytes32, Integers, and Bytes coming back from the functions.
Thank you, J

The pattern to proceed is as follows:
var contractExecuteResult = new ContractExecuteTransaction(client).[...]..executeForRecord();
Thread.sleep(500);
var newIndex = contractExecuteResult.getCallResult().getLong(0);
The CallResult has all the return parameters.


Python and Pylance extensions failing to install on remote host

Issue Type: Bug
With the following settings on a remote host with no internet access, I am not able to install python and pylance extensions due to the jupyter extension file already existing.
"remote.SSH.localServerDownload": "always",
"remote.downloadExtensionsLocally": true,

Log:
[2021-08-24 09:16:48.854] [remoteagent] [info] [<IP_ADDRESS>][82fc4f69][ExtensionHostConnection] <84979> Launched Extension Host Process.
[2021-08-24 09:33:29.290] [remoteagent] [info] Installing extension: ms-python.python
[2021-08-24 09:33:31.069] [remoteagent] [info] Installing extension: ms-python.vscode-pylance
[2021-08-24 09:33:37.608] [remoteagent] [info] Installing extension: ms-python.python
[2021-08-24 09:33:37.844] [remoteagent] [info] Installing extension: ms-python.python
[2021-08-24 09:33:38.130] [remoteagent] [info] Installing extension: ms-python.vscode-pylance
[2021-08-24 09:33:38.334] [remoteagent] [info] Installing extension: ms-python.python
[2021-08-24 09:33:38.691] [remoteagent] [info] Installing extension: ms-python.vscode-pylance
[2021-08-24 09:33:39.302] [remoteagent] [info] Installing extension: ms-python.vscode-pylance
[2021-08-24 09:33:39.632] [remoteagent] [info] Installing extension: ms-toolsai.jupyter
[2021-08-24 09:33:39.778] [remoteagent] [info] Installing extension: ms-python.python
[2021-08-24 09:33:40.651] [remoteagent] [info] Deleted from disk ms-toolsai.jupyter /users/a/.vscode-server/extensions/ms-toolsai.jupyter-2021.8.1236758218
[2021-08-24 09:33:41.209] [remoteagent] [info] Installing extension: ms-python.python
[2021-08-24 09:33:41.392] [remoteagent] [info] Installing extension: ms-python.vscode-pylance
[2021-08-24 09:33:41.820] [remoteagent] [info] Installing extension: ms-python.vscode-pylance
[2021-08-24 09:33:43.435] [remoteagent] [info] Extracted extension to /users/a/.vscode-server/extensions/.6f1da5ef-699e-4143-97cb-538aa40610d3: ms-toolsai.jupyter
[2021-08-24 09:33:43.450] [remoteagent] [info] Renamed to /users/a/.vscode-server/extensions/ms-toolsai.jupyter-2021.8.1236758218
[2021-08-24 09:33:43.454] [remoteagent] [info] Extracting completed. ms-toolsai.jupyter
[2021-08-24 09:33:43.460] [remoteagent] [info] Extension installed successfully: ms-toolsai.jupyter
[2021-08-24 09:33:44.979] [remoteagent] [info] Installing extension: ms-python.python
[2021-08-24 09:33:45.178] [remoteagent] [info] Installing extension: ms-python.python
[2021-08-24 09:33:45.315] [remoteagent] [info] Installing extension: ms-toolsai.jupyter
[2021-08-24 09:33:45.977] [remoteagent] [info] Deleted from disk ms-toolsai.jupyter /users/a/.vscode-server/extensions/ms-toolsai.jupyter-2021.8.1236758218
[2021-08-24 09:33:46.018] [remoteagent] [info] Installing extension: ms-toolsai.jupyter
[2021-08-24 09:33:46.121] [remoteagent] [info] Installing extension: ms-toolsai.jupyter
[2021-08-24 09:33:46.250] [remoteagent] [info] Installing extension: ms-python.vscode-pylance
[2021-08-24 09:33:46.404] [remoteagent] [info] Installing extension: ms-python.vscode-pylance
[2021-08-24 09:33:46.726] [remoteagent] [info] Installing extension: ms-toolsai.jupyter
[2021-08-24 09:33:47.107] [remoteagent] [info] Installing extension: ms-toolsai.jupyter
[2021-08-24 09:33:48.993] [remoteagent] [info] Installing extension: ms-toolsai.jupyter
[2021-08-24 09:33:49.111] [remoteagent] [info] Installing extension: ms-toolsai.jupyter
[2021-08-24 09:33:50.260] [remoteagent] [info] Installing extension: ms-python.python
[2021-08-24 09:33:51.226] [remoteagent] [info] Extracted extension to /users/a/.vscode-server/extensions/.13efd12e-2377-4a0c-9a9c-962bb0e65a80: ms-toolsai.jupyter
[2021-08-24 09:33:51.241] [remoteagent] [info] Renamed to /users/a/.vscode-server/extensions/ms-toolsai.jupyter-2021.8.1236758218
[2021-08-24 09:33:51.246] [remoteagent] [info] Extracting completed. ms-toolsai.jupyter
[2021-08-24 09:33:51.253] [remoteagent] [info] Extension installed successfully: ms-toolsai.jupyter
[2021-08-24 09:33:51.495] [remoteagent] [info] Extracted extension to /users/a/.vscode-server/extensions/.affb66a9-ecfd-46c1-8b26-951f8a2dd4d7: ms-toolsai.jupyter
[2021-08-24 09:33:51.926] [remoteagent] [info] Rename failed because of EEXIST: file already exists, rename '/users/a/.vscode-server/extensions/.affb66a9-ecfd-46c1-8b26-951f8a2dd4d7' -> '/users/a/.vscode-server/extensions/ms-toolsai.jupyter-2021.8.1236758218'. Deleted from extracted location /users/a/.vscode-server/extensions/.affb66a9-ecfd-46c1-8b26-951f8a2dd4d7
[2021-08-24 09:33:51.927] [remoteagent] [error] Error while installing the extension: ms-toolsai.jupyter
[2021-08-24 09:33:51.929] [remoteagent] [error] EEXIST: EEXIST: file already exists, rename '/users/a/.vscode-server/extensions/.affb66a9-ecfd-46c1-8b26-951f8a2dd4d7' -> '/users/a/.vscode-server/extensions/ms-toolsai.jupyter-2021.8.1236758218'
at y.rename (/had/home/a/.vscode-server/bin/3866c3553be8b268c8a7f8c0482c0c0177aa8bfa/out/vs/server/remoteExtensionHostAgent.js:116:81014)
at async y.extractUserExtension (/had/home/a/.vscode-server/bin/3866c3553be8b268c8a7f8c0482c0c0177aa8bfa/out/vs/server/remoteExtensionHostAgent.js:116:77848)
at async Q.extract (/had/home/a/.vscode-server/bin/3866c3553be8b268c8a7f8c0482c0c0177aa8bfa/out/vs/server/remoteExtensionHostAgent.js:116:90124)
[2021-08-24 09:33:51.930] [remoteagent] [error] Failed to install extension: ms-toolsai.jupyter EEXIST: file already exists, rename '/users/a/.vscode-server/extensions/.affb66a9-ecfd-46c1-8b26-951f8a2dd4d7' -> '/users/a/.vscode-server/extensions/ms-toolsai.jupyter-2021.8.1236758218'
[2021-08-24 09:33:51.977] [remoteagent] [info] Extracted extension to /users/a/.vscode-server/extensions/.f12caf38-183c-4fa2-9d93-9d6f203d8a57: ms-toolsai.jupyter
[2021-08-24 09:33:52.442] [remoteagent] [info] Rename failed because of EEXIST: file already exists, rename '/users/a/.vscode-server/extensions/.f12caf38-183c-4fa2-9d93-9d6f203d8a57' -> '/users/a/.vscode-server/extensions/ms-toolsai.jupyter-2021.8.1236758218'. Deleted from extracted location /users/a/.vscode-server/extensions/.f12caf38-183c-4fa2-9d93-9d6f203d8a57
[2021-08-24 09:33:52.442] [remoteagent] [error] Error while installing the extension: ms-toolsai.jupyter
[2021-08-24 09:33:52.442] [remoteagent] [error] EEXIST: EEXIST: file already exists, rename '/users/a/.vscode-server/extensions/.f12caf38-183c-4fa2-9d93-9d6f203d8a57' -> '/users/a/.vscode-server/extensions/ms-toolsai.jupyter-2021.8.1236758218'
at y.rename (/had/home/a/.vscode-server/bin/3866c3553be8b268c8a7f8c0482c0c0177aa8bfa/out/vs/server/remoteExtensionHostAgent.js:116:81014)
at async y.extractUserExtension (/had/home/a/.vscode-server/bin/3866c3553be8b268c8a7f8c0482c0c0177aa8bfa/out/vs/server/remoteExtensionHostAgent.js:116:77848)
at async Q.extract (/had/home/a/.vscode-server/bin/3866c3553be8b268c8a7f8c0482c0c0177aa8bfa/out/vs/server/remoteExtensionHostAgent.js:116:90124)
[2021-08-24 09:33:52.442] [remoteagent] [error] Failed to install extension: ms-toolsai.jupyter EEXIST: file already exists, rename '/users/a/.vscode-server/extensions/.f12caf38-183c-4fa2-9d93-9d6f203d8a57' -> '/users/a/.vscode-server/extensions/ms-toolsai.jupyter-2021.8.1236758218'
[2021-08-24 09:33:53.469] [remoteagent] [info] Installing extension: ms-python.vscode-pylance
[2021-08-24 09:33:53.553] [remoteagent] [info] Extracted extension to /users/a/.vscode-server/extensions/.2e245d30-a61c-414b-afe1-3dc176becb31: ms-toolsai.jupyter
[2021-08-24 09:33:54.090] [remoteagent] [info] Rename failed because of EEXIST: file already exists, rename '/users/a/.vscode-server/extensions/.2e245d30-a61c-414b-afe1-3dc176becb31' -> '/users/a/.vscode-server/extensions/ms-toolsai.jupyter-2021.8.1236758218'. Deleted from extracted location /users/a/.vscode-server/extensions/.2e245d30-a61c-414b-afe1-3dc176becb31
[2021-08-24 09:33:54.090] [remoteagent] [error] Error while installing the extension: ms-toolsai.jupyter
[2021-08-24 09:33:54.091] [remoteagent] [error] EEXIST: EEXIST: file already exists, rename '/users/a/.vscode-server/extensions/.2e245d30-a61c-414b-afe1-3dc176becb31' -> '/users/a/.vscode-server/extensions/ms-toolsai.jupyter-2021.8.1236758218'
at y.rename (/had/home/a/.vscode-server/bin/3866c3553be8b268c8a7f8c0482c0c0177aa8bfa/out/vs/server/remoteExtensionHostAgent.js:116:81014)
at async y.extractUserExtension (/had/home/a/.vscode-server/bin/3866c3553be8b268c8a7f8c0482c0c0177aa8bfa/out/vs/server/remoteExtensionHostAgent.js:116:77848)
at async Q.extract (/had/home/a/.vscode-server/bin/3866c3553be8b268c8a7f8c0482c0c0177aa8bfa/out/vs/server/remoteExtensionHostAgent.js:116:90124)
[2021-08-24 09:33:54.091] [remoteagent] [error] Failed to install extension: ms-toolsai.jupyter EEXIST: file already exists, rename '/users/a/.vscode-server/extensions/.2e245d30-a61c-414b-afe1-3dc176becb31' -> '/users/a/.vscode-server/extensions/ms-toolsai.jupyter-2021.8.1236758218'
VS Code version: Code 1.59.1 (Universal) (3866c3553be8b268c8a7f8c0482c0c0177aa8bfa, 2021-08-19T11:53:52.479Z)
OS version: Darwin x64 19.6.0
Restricted Mode: No
Remote OS version: Linux x64 3.10.0-1062.49.1.el7.x86_64

System Info

Item
Value

CPUs
Intel(R) Core(TM) i9-9880H CPU @ 2.30GHz (16 x 2300)

GPU Status
2d_canvas: enabledgpu_compositing: enabledmetal: disabled_offmultiple_raster_threads: enabled_onoop_rasterization: enabledopengl: enabled_onrasterization: enabledskia_renderer: disabled_off_okvideo_decode: enabledwebgl: enabledwebgl2: enabled

Load (avg)
2, 2, 3

Memory (System)
32.00GB (4.28GB free)

Process Argv
--crash-reporter-id 374fef7b-70d5-4a1f-bc8a-01773fb43c52

Screen Reader
no

VM
0%

Item
Value

Remote
SSH: xxx.xxx.com (removed for privacy)

OS
Linux x64 3.10.0-1062.49.1.el7.x86_64

CPUs
Intel(R) Xeon(R) Gold 6150 CPU @ 2.70GHz (72 x 2700)

Memory (System)
754.33GB (19.14GB free)

VM
0%

Extensions (10)

Extension
Author (truncated)
Version

hive-sql
jos
0.0.4

remote-ssh
ms-
0.65.7

remote-ssh-edit
ms-
0.65.7

vscode-sql-formatter
adp
1.4.4

hive-sql
jos
0.0.4

vscode-sshfs
Kel
1.21.2

jupyter
ms-
2021.8.1236758218

autodocstring
njp
0.5.4

vscode-yaml
red
0.22.0

indenticator
Sir
0.7.0

A/B Experiments
vsliv368:30146709
vsreu685:30147344
python383:30185418
pythonvspyt602:30300191
vspor879:30202332
vspor708:30202333
vspor363:30204092
pythonvspyt639:30300192
pythontb:30283811
pythonptprofiler:30281270
vshan820:30294714
vstes263cf:30335440
pythondataviewer:30285071
pythonvsuse255:30340121
vscod805:30301674
pythonvspyt200:30340761
vscextlangct:30333562
binariesv615:30325510
pythonvssor306:30344512
bridge0708:30335490
pygetstartedc2:30351386
vstre464cf:30350173
bridge0723:30353136
vsdyn478:30356813

Hi, apologies, I'm unable to do that as I'm on a restricted machine.

I am mostly sure that I have fixed this issue in insiders. So please wait for next stable release and if it still reproduces reopen the issue.


Remove slurm extra

Right now, the slurm extra adds these two additional requirements:
$ poetry show clusterfutures

 name         : clusterfutures
 version      : 0.5
 description  : futures for remote execution on clusters

dependencies
 - cloudpickle *

$ poetry show cloudpickle
 name         : cloudpickle
 version      : 2.2.1
 description  : Extended pickling support for Python objects

required by
 - clusterfutures *

These are lightweight packages, with no further transitive dependencies.
Having slurm as a conditional extra makes a few codepaths within the runner more complex, with no actual benefit (since we mostly deploy in SLURM clusters). As a side comment, this also doesn't play nicely with conda-forge, since the code analysis always tries to add cloudpickle as a required dependency, since it is identified within the code base.
Shall we simply make clusterfutures and cloudpickle required dependencies? I don't see any relevant downside of it.
It'd be best to do this before V2 or as part of V2, to make a bunch of runner internals simpler.

No veto from my side. We can always get more complex if we'd actually support different backends in the future.


TestIngress fails on operator test

https://prow.istio.io/view/gcs/istio-prow/logs/integ-k8s-operator_istio_postsubmit/8
https://prow.istio.io/view/gcs/istio-prow/logs/integ-k8s-operator_istio_postsubmit/9
https://prow.istio.io/view/gcs/istio-prow/logs/integ-k8s-operator_istio_postsubmit/10
Seems like its getting 503s

Also TestIngessToPrometheus_IngressMetric, so seems like some ingress issues

no longer an issue


Updated README

Changes

Updated README to feature needed instructions to install pdf tools for the export to pdf feature

Tests applied
N/A
Issue ticket number(s)
Related to #67
Checklist

[ ] Documented
[ ] Linting tests successful
[ ] merge updated prod branch into development branch

Hold on the horses, these tools may no longer be needed as I'm about to change the way I implemented the export to PDF feature.

PR put on hold. As PDF dependencies may no longer be needed so will not require installing them.

The required packages have been updates, jspdf and html2canvas are no longer requires, opentype.js is now required.

Sorry, sneaking in because I haven’t unsubscribed to email notifications.
Why not add the dependency so it installs with pnpm install? 🤨

I see, then in that case, pnpm install opentype.js is obsolete as it will be executed as part of pnpm install  during the initial setup. Thank you for the advice.


python310Packages.pontos: 23.4.6 -> 23.4.7

Diff: https://github.com/greenbone/pontos/compare/refs/tags/v23.4.6...v23.4.7
Changelog: https://github.com/greenbone/pontos/releases/tag/v23.4.7
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 228594 run on x86_64-linux 1

4 packages built:

python310Packages.pontos
python310Packages.pontos.dist
python311Packages.pontos
python311Packages.pontos.dist


[Bug]: Not able to run puppeteer extension on AWS EC2 instance

Bug expectation
I have tried to run puppeteer extension on AWS EC2 instance using XVFB but it not running and also not running the background JS file.
On local machine Ubuntu it running perfectly using XVFB. I try to capture chorme stream using XVFB.
Please suggest any thing why it's not working on AWS EC2 instance.
Ubuntu 20.04
XVFB
Puppeteer
To run the code I am using below command
xvfb-run -a --server-args="-screen 0 1x1x24 -ac -nolisten tcp +extension RANDR" yarn serve
Bug behavior

[ ] Flaky
[ ] PDF

Minimal, reproducible example
import isRoot from 'is-root'
import path from 'path'
import { fileURLToPath } from 'url'
import puppeteer from 'puppeteer'

const dirname = path.dirname(fileURLToPath(import.meta.url))

const extension = path.join(dirname, 'extension')
console.log("Path extension", extension);
const extensionId = 'aahdpjnamionemlcfkodembopehdcipg'
const eventBlacklist = ['page', 'background_page']

const cdp = async (page) => {
  const client = await page.target().createCDPSession()

  client.send('Page.setDownloadBehavior', {
    behavior: 'deny'
  })
}

export default async (options) => {
  const width =  options.width //1280

  const height = Math.trunc(width / options.ratio) //options.height //Math.trunc(width / options.ratio)

  const browser = await puppeteer.launch({
    args: [
      '--block-new-web-contents',
      '--disable-breakpad',
      '--disable-dev-shm-usage',
      `--disable-extensions-except=${extension}`,
      `--file-url-path-alias=/=${path.join(dirname, 'forbidden')}/`,
      '--hide-crash-restore-bubble',
      '--kiosk',
      '--ignore-gpu-blocklist',
      `--load-extension=${extension}`,
      '--no-crash-upload',
      '--no-default-browser-check',
      '--no-first-run',
      '--no-recovery-component',
      isRoot() ? '--no-sandbox' : '',
      isRoot() ? '--no-zygote' : '',
      '--noerrdialogs',
      '--suppress-message-center-popups',
      `--use-gl=${process.env.GPU_GL || 'swiftshader'}`,
      `--user-data-dir=chrome-user-data/${options.token}`,
      `--window-size=${width},${height + 90}`,
      `--whitelisted-extension-id=${extensionId}`,
    ],
    defaultViewport: { width, height },
    // defaultViewport: null,
    executablePath: process.env.CHROMIUM_EXECUTE_PATH || undefined,
    // devtools: true,
    headless: 'chrome',
    ignoreDefaultArgs: [
      '--disable-popup-blocking',
      '--enable-automation',
      '--mute-audio',
    ]
  })

  const page = (await browser.pages())[0]
  await page.setUserAgent(options.userAgent);

  cdp(page)

  browser.on('targetcreated', async (target) => {
    if (!eventBlacklist.includes(target.type())) {
      return
    }

    await page.goto(target.url())

    (await target.page()).close()
  })

  return { browser, page }
}

Error string
no error
Puppeteer configuration
No response
Puppeteer version
19.7.5
Node version
18.13.0
Package manager
npm
Package manager version
9.5.0
Operating system
Linux

Could you use dumpio: true flag on the launch and  the env varDEBUG=puppeeteer:* and provide the resulting log?

I have add what you suggested and got the log, I am sharing the log screen shot.

It looks like you might not have gpu and you provide some custom attributes that are not compatible with your system. Try leaving out those attributes.

Try using --enable-gpu instead of --use-gl

Hello @OrKoN I have successfully run this project on local machine using Ubuntu 20.04 but it not working on AWS EC2 instance.
After adding --enable-gpu I have got below log:-

Unfortunately, we cannot provide further guidance. The problem is definitely in the AWS EC2 environment. Checkout the available CLI flags https://peter.sh/experiments/chromium-command-line-switches/ and known issues https://pptr.dev/troubleshooting#running-puppeteer-on-aws-ec2-instance-running-amazon-linux It looks like the problem is related to the GPU not being available on the EC2 instance. If you believe it is a Chromium bug, please report it to crbug.com.
Also, I noticed that you use headless: 'chrome' and that is outdated. The correct version is headless: 'new'  (see https://pptr.dev/guides/chrome-extensions)


@ #11 | coverage increase 4% more

before:
dev_1  | Ran 173 tests in 2.622s
dev_1  |
dev_1  | OK
dev_1  | coverage report --omit=test_classful/*,test_classful_py3/*,setup.py
dev_1  | Name                Stmts   Miss Branch BrPart  Cover
dev_1  | -----------------------------------------------------
dev_1  | flask_classful.py     270     14    141     11    94%

after:
dev_1  | Ran 178 tests in 2.002s
dev_1  |
dev_1  | OK
dev_1  | coverage report --omit=test_classful/*,test_classful_py3/*,setup.py
dev_1  | Name                Stmts   Miss Branch BrPart  Cover
dev_1  | -----------------------------------------------------
dev_1  | flask_classful.py     270      9    141      7    96%

so 2% more test coverage is added.


Normalized shortcuts for various apps

Wouldn't this prevent users from having multiple versions of a program installed?
Installing both dolphin-dev and dolphin-beta currently creates Dolphin (Development) and Dolphin (Beta) shortcuts. It looks like with this change there would only be one shortcut?
I would prefer to keep the shortcut names the way they are now.

I also agree that shortcut names for different app versions should be kept as-is. It's important to be able to use both stable and beta releases in parallel for comparison and bug reporting purposes :slightly_smiling_face:

There are apps that have nightly or dev versions alongside stable that do not differ in shortcuts. If I recall correctly @Calinou you had me change the Retroarch nighty shortcut to just be "Retroarch" for simplicity, so I assumed that was the preferred way.

@Calinou would you mind going through the alt versions of what it's the repo and updating them to fit that standard? I think some need fixed, but you have a better idea of how you want it.

@Calinou would you mind going through the alt versions of what is in the repo and updating them to fit that standard? I think some need fixed, you have a better idea.

I'm pretty busy with things at the moment, so I unfortunately don't have the time to do that just yet.


Add support for SSLKEYLOGFILE

See #132

@sneako thanks for taking a look.

There are a few things I think we should change about the implementation, the main thing being the use of the system ENV to toggle this behaviour.

One reason to use SSLKEYLOGFILE is that it is "standard" in that browsers and the NSS library recognize it - https://developer.mozilla.org/en-US/docs/Mozilla/Projects/NSS/Key_Log_Format. Of course, a configuration option passed to Finch would do as well. I discovered SSLKEYLOGFILE when I was doing some Wireshark tracing of browser-based HTTP2 sessions. I suspect that users will discover this feature in a similar manner so the code or documentation in Finch should reflect that. At any rate, I will switch to a configuration setting ... how about ssl_key_log_file? I will make sure the docs are clear about it.

I think it's fine to use the SSLKEYLOGFILE env var but it's important it is only read once, when pool starts, and not on every request. But an option is even better.

@sneako ready for a re-review. Thank you!

Thanks @wojtekmach, I agree with all of you points. And sorry everyone, it has been a busy week for me. One thing that hasn't been addressed yet was my comment re: sample_rate. If I tried to use this in production, I'm sure my node would be overloaded, so I think an optional sample_rate option would be one way around that. What do you all think?

@sneako oh, forgot to mention, I don't think it's going to be necessarily problematic in prod performance-wise, my understanding is we only log the keys on connect once per connection, not on every request.

Thanks everyone. I'll try to get these changes soon, but please note that you do have the ability to make changes to my branch and push directly to my fork if you'd like.
Logging secrets is not per-request, but per connection.

Ah perfect, disregard in that case 😄

@wojtekmach @sneako all set for re-review. For some reason GitHub isn't allowing me to re-request a review 🤷

Just two small comments, but otherwise I think this is good to go! We need to wait for https://github.com/elixir-mint/mint/pull/314 to be merged & released first though, right?

We need to wait for elixir-mint/mint#314 to be merged & released first though, right?

Actually, get_socket/1 is available in mint right now, it's just not officially "public" or with tests like I added in that PR.
Thanks for the review, I'll get the changes today.

@wojtekmach @sneako this is ready for re-review. Thanks in advance!

Hey @lukebakken ! So I checked out the PR locally and tried to get the TLS v1.3 tests to run on OTP 24, but ran in to some dependency issues with some of our test deps. So instead I tried out the feature (on OTP 24), both via the conn_opts and via the env var, and it worked well! I'll figure out the dependency issues as they get updated to support OTP 24, but I don't think we need to wait for that.
I felt that the docs you added warranted their own section, so I made that change and pushed. Please let me know what you think, and if it looks good, I will merge this and release Finch 0.7.0 😄

Ah perhaps I misunderstood the note here: https://github.com/keathley/finch/pull/133/commits/811f16b75df28ee79e583ab9b3738600219b1405 ? Shouldn’t these failing tests be skipped when TLS v1.3 is not supported anyway?


Warn when boundary relation is no longer closed

I operate a site that is a data consumer of administrative boundaries.  I am seeing a handful of administrative boundaries get broken each day by changesets from iD users, and I am constantly having to go in and fix these boundaries.  Often when contacted, the changeset authors noted that there was no warning given and everything "looked fine".
The most common errors are gaps in the boundary and extra segments added to the boundary.
Below are some recent changesets where this issue occurred.
https://www.openstreetmap.org/changeset/96835302
https://www.openstreetmap.org/changeset/97199863
https://www.openstreetmap.org/changeset/97060209
It would be great if there was a better way to detect that a change was made to a boundary relation and do some additional validation to prevent breakages.

Here is an additional case (iD 2.19.5): https://www.openstreetmap.org/changeset/98004483

Here is an additional case (iD 2.19.5): https://www.openstreetmap.org/changeset/98004483

The most common errors are gaps in the boundary and extra segments added to the boundary.

Boundaries normally have similar geometry requirements as multipolygons. I don’t think multipolygons currently enjoy geometry validation either, probably because iD has to be resilient to them being only partially downloaded. If not for that, both would ideally have the same kind of validation as areas (although disputed boundaries can have funky geometry by design).

Issue is still present as of iD 2.20.4:
https://www.openstreetmap.org/changeset/118554695

I use ID mostly for my edits and if I edit and an existing multipolygon (...Node Line Node Line Node Line Node Line Node...) and remove the center node in the multi polygon there is now a hole in the multiploygon. Save. When I save I get no errors that the multipolygon is now (broken). No warning no errors are being displayed.

An additional case of boundary breakage is when one of the members which should be inner is outer (or vice versa), for example, in this changeset.

Multipolygons do enjoy geometry validation, plus inner-outer role validation, though there are situations where iD has only partially downloaded the relation so the validation wouldn’t take place.

For boundaries, it’s usually the case that the boundary hasn’t been fully downloaded yet, which would prevent any validator rule from being able to detect a gap, fork, or incorrect role.
#4903 tracks automatically downloading the members of a relation as soon as you select it, which would unblock this feature. #6656 tracks automatically downloading the members of a relation while you use iD, so that hopefully all the members would be available by the time you open the panel. #5420 tracks a button for explicitly downloading all the members at once; perhaps iD could refuse to perform certain risky operations until the user clicks this button.


Start a secure channel listener at address api when a command node is created

Current Behaviour
> ockam node create blue

Node Created!

Node:
  Name: blue
  Status: Running
  API Address: <IP_ADDRESS>:58515
  Pid: 61985
  Worker count: 19
  Transport count: 1
  Log Path: /Users/mrinal/Library/Application Support/io.ockam.ockam-cli/node-blue/blue.log

> ockam secure-channel-listener create --node blue 'api'
Secure Channel Listener created at 0#api!

Desired Behaviour
> ockam node create blue

Node Created!

Node:
  Name: blue
  Status: Running
  API Address: <IP_ADDRESS>:58515
  Secure Channel Listener Address: /ockam/api
  Pid: 61985
  Worker count: 19
  Transport count: 1
  Log Path: /Users/mrinal/Library/Application Support/io.ockam.ockam-cli/node-blue/blue.log

So here the requirement is to merge secure-channel-listener create into node create, but what about secure-channel-listener in itself, should be removed or left as it is?

secure-channel-listener in itself, should be removed or left as it is?
That command stays as is.

I have added create_secure_channel_listener_impl in initialize_defaults.
Now, how can I test if secure channel listener is being created? As it doesn't have show/list and can be created a number of times with different ID's.
And as for output, there isn't an address being provided, so adding Secure Channel Listener Address: /ockam/api in query_status would be just fine as default ockam/api? Probably be used only if secure-channel-listener doesn't mutate it, If it does, where can I get it (from ockam::Context?)
OT: Is there an ockam internal design/architecture doc, unlike user focused docs.rs/ockam and get-started-guides?

Awesome, here's a test.
Note the comment this this code snippet
» ockam node create n1 --api-address <IP_ADDRESS>:6001

» ockam node create n2 --api-address <IP_ADDRESS>:6002

# This line is needed before your change and can be skipped after your change
» ockam secure-channel-listener create --node n2 "api"

» ockam secure-channel create --node n1 /ip4/<IP_ADDRESS>/tcp/6002/ockam/api
/ockam/3687bc44aee8486c7c9692bab875d492

» ockam message send /ip4/<IP_ADDRESS>/tcp/6001/ockam/3687bc44aee8486c7c9692bab875d492/ockam/uppercase "hello"
HELLO

And as for output, there isn't an address being provided, so adding Secure Channel Listener Address: /ockam/api in query_status would be just fine as default ockam/api

Yes

Probably be used only if secure-channel-listener doesn't mutate it, If it does, where can I get it (from ockam::Context?

Currently it can't mutate it. It is possible delete the listener but I think we have some work to do to make it easy to get that information. i.e channel worker need some kind of management api.

OT: Is there an ockam internal design/architecture doc, unlike user focused docs.rs/ockam and get-started-guides?

This is a bit all over the place, sorry about that. We're planning a bit docs refresh soon. The content in this guide should offer some insight https://github.com/build-trust/ockam/tree/develop/documentation/guides/rust#build-end-to-end-encrypted-and-secure-messaging-channels

ockam secure-channel create --node n1 /ip4/<IP_ADDRESS>/tcp/6002/ockam/api branch develop
Returns: error: Invalid value "/ip4/<IP_ADDRESS>/tcp/6002/ockam/api!" for '': unregistered protocol prefix "ockam"
anything after 6002 returns with same error

ockam secure-channel create --node n1 /ip4/<IP_ADDRESS>/tcp/6002
Returns: encountered an error in command handler code

Feels like "Works on my machine".
IMO, docs for structs like MultiAddr should contain some examples.

@anuvratsingh things are changing quickly in this area :)
/ockam/ was changed to /service/ earlier today https://github.com/build-trust/ockam/pull/3121
Please try:
ockam secure-channel create --node n1 /ip4/<IP_ADDRESS>/tcp/6002/service/api

IMO, docs for structs like MultiAddr should contain some examples

💯 agree.

If you can create a draft PR, I can help test as well

things are changing quickly in this area :)

Is there a more synchronous channel to keep up with it, unlike discussions?

no, just github for the time being.


Discovery Research spike: Document current wired comm system

There are quite a few processes involved in making wired communication with robot happen-
Network manager, Avahi, DHCP, networking related systemd processes and usb/ethernet drivers. We don't yet fully understand what each one does and whether all of them are working well together. Also, when you look at a robot's system log, we see some errors and warnings from these processes at quite a regular interval. We should investigate these messages and understand what exactly is going on during a wired communication with the robot.
Scope of this ticket:

[ ] Document the components & processes involved in robot's networking
[ ] Investigate the most commonly found system messages that are either mysterious or have warnings & errors

Closed with: https://coda.io/d/Robot-IP-Address-Assignment_dPkX21A5C1W/Overview_suXiL#_luyTZ


So we still need to include tini?

Since tini is included in docker @blacklabelops
NOTE: If you are using Docker 1.13 or greater, Tini is included in Docker itself.

This includes all versions of Docker CE. To enable Tini, just pass the --init flag to docker run.

I would like to keep tini. Passing a flag at each start is no permanent solution for me.


Create css-body-after.css

Body after pseudo element version
Adding a language

[X ] The code displays "Hello World"
[ ] I have updated the readme to include the new language
[ ] I have incremented the language count in the readme

We already have this.


WIP: 'create connection' cmd

Closes: #630
Description
Depends on #676

For contributor use:

[ ] Updated the Unreleased section of CHANGELOG.md with the issue.
[ ] If applicable: Unit tests written, added test to CI.
[ ] Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
[ ] Updated relevant documentation (docs/) and code comments.
[ ] Re-reviewed Files changed in the Github PR explorer.

Codecov Report

Merging #688 (f8e34a2) into master (b1b37f5) will increase coverage by 30.1%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master    #688      +/-   ##
=========================================
+ Coverage    13.6%   43.8%   +30.1%
=========================================
  Files          69     152      +83
  Lines        3752    9840    +6088
  Branches     1374       0    -1374
=========================================
+ Hits          513    4317    +3804
- Misses       2618    5523    +2905
+ Partials      621       0     -621

Impacted Files
Coverage Δ

modules/src/address.rs
100.0% <ø> (ø)

...application/ics20_fungible_token_transfer/error.rs
0.0% <ø> (ø)

...ion/ics20_fungible_token_transfer/msgs/transfer.rs
0.0% <ø> (ø)

modules/src/events.rs
0.0% <ø> (ø)

modules/src/handler.rs
100.0% <ø> (ø)

modules/src/ics02_client/client_def.rs
47.7% <ø> (ø)

modules/src/ics02_client/client_type.rs
79.1% <ø> (+31.5%)
:arrow_up:

modules/src/ics02_client/context.rs
100.0% <ø> (ø)

modules/src/ics02_client/error.rs
100.0% <ø> (ø)

modules/src/ics02_client/events.rs
15.7% <ø> (+15.7%)
:arrow_up:

... and 257 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7011aa8...be1e3d8. Read the comment docs.


Added Maze Game Project

Description 📜
Added Maze Game Project.
Fixes #175
The maze game works by presenting a maze in front of the user with a caterpillar that would like to feed on the cabbage but has to reach it through a maze. The player has to navigate the caterpillar using the arrow buttons of the keyboard or using the mouse and help it reach the cabbage. It also works on phone screens perfectly and the user can select the caterpillar and send it to desired location using hand touch. This game also has option to select from various difficulty levels viz : Easy, Medium, Hard and Extreme and with each increasing level, the user is presented with a more complex maze. Every single maze is different and unique.

Type of change 📝

[x] Add a new project

Domain of Contribution 📊
Please delete options that are not relevant.And in order to tick the check box just but x inside them for example [x] like this

[x] Project using HTML, CSS & JS

Checklist ✅

[x] I have performed a self-review of my own code or work.
[x] I have commented my code, particularly in hard-to-understand areas.
[x] My changes generates no new warnings.
[x] I'm GSSoC'22 contributor

Screenshots / Gif (Optional) 📸
Easy Level :

Medium Level :

Hard Level :

Extreme Level :

When the user successfully completes the right path, the number of steps taken is also printed on the screen along with a congratulations message

Kindly review and merge the PR.
Thank You !


Unsolicited response received on idle HTTP channel starting with

Unsolicited response received on idle HTTP channel starting with

Hello @pprogg ,
Seems like HTTP HEAD request returns body in response. I will handle it as soon as possible.
Thanks


Choose Wallet type

During onBoarding I choose between creating Enterprise wallet or Personal wallet.
If I choose Personal wallet the onboarding process is the usual one.

complexity: 0.5