Default xplat project cannot be built when .net8.0 is installed on linux (NETSDK1139: target platform 'android' is not recognized).

Describe the bug
Newly created cross-platform projects fail to build when net8.0 is installed. uninstalling anything related to .net8.0 and manually editing each project to instead point to net7.0 resolves this.
full error from dotnet build:
/usr/share/dotnet/sdk/8.0.102/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.TargetFrameworkInference.targets(117,5): error NETSDK1139: The target platform identifier android was not recognized. [/home/prydaran/Documents/Rider/TestAvaloniaNet8/TestAvaloniaNet8.Android/TestAvaloniaNet8.Android.csproj]

To Reproduce

follow instructions for setting up a development environment on linux over at the avalonia documentation
create a new cross-platform avalonia project (dotnet new avalonia.xplat)
restore any potentially missing workloads (sudo dotnet workload restore)
install appropriate android workload related items (JDK, SDK)
attempt to build.

Expected behavior
Project builds successfully.
Avalonia version
11.0.10
OS
Linux, Android
Additional context
it should be noted that this issue occurrs with both the CLI (dotnet), and with Rider (both normal and EAP). When creating a project in rider, the only option to choose for .net sdk is .net8.0 for an avalonia cross-platform project, even if .net8.0 is not installed.
Rider's project window:

dotnet workload install android

@maxkatz6 no effect

also, workload android doesn't exist for net8.0 according to 'dotnet workload search'

@maxkatz6 @AArnott somebody?

Workload exits for net8, I've installed it on my own. Try it from command line, as VS seems to be buggy here acc to some SO questions.
Note: If you need urgent support, you need payed support. Or wait until community has time to.

@timunie Apologies, I had assumed that since they had closed it that they had just left me to fend for myself. here's the output of dotnet workload search:
[prydaran@prydaran-framework-13 ~]$ dotnet workload search

Workload ID                 Description
----------------------------------------------------------------------------
aspire                      .NET Aspire SDK (Preview)
wasi-experimental           workloads/wasi-experimental/description
wasm-experimental           workloads/wasm-experimental/description
wasm-experimental-net7      .NET WebAssembly experimental tooling for net7.0
wasm-tools                  .NET WebAssembly build tools
wasm-tools-net6             .NET WebAssembly build tools for net6.0
wasm-tools-net7             .NET WebAssembly build tools for net7.0

please keep in mind that this is from a linux dev environment, not windows.

Use discussions for questions, not bug report. If .NET doesn't provide you the workload on Linux, that's nothing Avalonia can or should fix.

I don't see any NET8 workload in there. Are you sure you have the correct SDK installed? Runtime is not enough.

output of yay dotnet:
10 extra/dotnet-targeting-pack-7.0 7.0.15.sdk115-1 (6.2 MiB 40.9 MiB) (Installed)
    The .NET Core targeting pack
9 extra/dotnet-targeting-pack-6.0 6.0.26.sdk126-1 (5.7 MiB 37.2 MiB) (Installed)
    The .NET Core targeting pack
8 extra/dotnet-targeting-pack 8.0.2.sdk102-1 (6.4 MiB 45.5 MiB) (Installed)
    The .NET Core targeting pack
7 extra/dotnet-runtime-6.0 6.0.26.sdk126-1 (22.0 MiB 64.4 MiB) (Installed)
    The .NET Core runtime
6 extra/dotnet-runtime-7.0 7.0.15.sdk115-1 (22.8 MiB 66.7 MiB) (Installed)
    The .NET Core runtime
5 extra/dotnet-runtime 8.0.2.sdk102-1 (22.6 MiB 66.3 MiB) (Installed)
    The .NET Core runtime
4 extra/dotnet-sdk-7.0 7.0.15.sdk115-1 (82.4 MiB 306.6 MiB) (Installed)
    The .NET Core SDK
3 extra/dotnet-sdk-6.0 6.0.26.sdk126-1 (72.9 MiB 280.9 MiB) (Installed)
    The .NET Core SDK
2 extra/dotnet-host 8.0.2.sdk102-1 (139.8 KiB 458.7 KiB) (Installed)
    A generic driver for the .NET Core Command Line Interface
1 extra/dotnet-sdk 8.0.2.sdk102-1 (85.3 MiB 299.3 MiB) (Installed)
    The .NET Core SDK
==> Packages to install (eg: 1 2 3, 1-3 or ^4)
==>

Also, I Found Something. as mentioned by omajid:
Note to self: this current behaviouir results in a functional difference between a source-built SDK and a non-source-built SDK. dotnet workload list simply wouldn't show the workloads for users to install.

Edit:

As of Preview 6, the following 5 workloads are missing in a source-build SDK:

    android
    macos
    maui-android
    maui-tizen
    maui-windows

that was posted from when 8.0 was in preview 6. Later down the report, there is a linked issue involving an arch linux user not being able to find those workloads. It just so happens that's also my OS. listed workaround is that the workload manifests are missing, and should be added manually by the user...

not a bug on your end, but that does result in unintended behaviour

also, workload android doesn't exist for net8.0 according to dotnet workload search

Please open an issue at https://github.com/dotnet/sdk/issues.
Android workloads should be available on Linux starting with .NET 8, but I guess it still might require special setup.
For the long time it wasn't available on Linux at all.

what's funny was that they are available for net7.0 with no issue. at this point, it's a packaging problem on microsoft's part, so I will raise a bug report there.

I also have the same issue, have you solved it?


Xadmin needs to be removed

The last commit on xadmin was a year ago and there are 355 issues currently open. The demo is also not working. The devs are unfortunately not responding to queries or pull requests.

Seems to be the case. Done. Thanks for the heads up.


[ISSUE #8837] Remove netty codec threads for better performance

Which Issue(s) This PR Fixes

Fixes #8837
Brief Description
In the current implementation, a codec thread pool is set up for Netty, which is used to perform tasks such as encoding/decoding, and statistics.
We found that removing the codec thread pool and directly assigning these computational tasks to the NIO selector threads results in performance improvement.
Since these tasks do not involve IO operations, they will not block the NIO selector threads.
Our stress test results show that removing the codec thread pool can achieve higher TPS (5% increase) and also reduce CPU usage (4% reduction).
How Did You Test This Change?

A switch has already been added.
Close issue


Adjusted formatting on advanced IP settings

Adjusted IP advanced settings formatting to be more readable.
Description of the change:
Reason for the change:
Link to original source:

Closes #

thanks @hmbrown64!!

Hello @hmbrown64,Thanks again for the PR! We appreciate your contribution and look forward to                                              continued collaboration. Thanks!                                             Team SendGrid DX


why i don't have pdf export option

pandoc version
❯ pandoc --version
pandoc 3.1.2
Features: +server +lua
Scripting engine: Lua 5.4
User data directory: /Users/liuzhenfeng/.local/share/pandoc
Copyright (C) 2006-2023 John MacFarlane. Web:  https://pandoc.org
This is free software; see the source for copying conditions. There is no
warranty, not even for merchantability or fitness for a particular purpose.

I manage to get it after I've installed texlive-latex in Fedora 37. As I understand pandoc needs the TeX's distributive to export as PDF.

I have this intermittently as well. A restart or two seems to bring the command back. Not sure what I'm doing to make it go away.


Add --analyze param to CLI

TLDR: Execution plan output from EXPLAIN ANALYZE tells a story of how a query was executed and the goal of this command is to output a summary of that story.
I am working on adding this feature because I often look at the output of EXPLAIN ANALYZE and need to connect several dots myself to see what is important which can be quite manual and then if you are trying to do this across different queries or with different source data layouts you end up redoing a lot of work.
The new analyze parameter generates output like the below which is designed to make it easier to analyze queries and find hot spots (IO vs Compute and a breakdown of the core parts for each) and / or optimization opportunties.  It is still very much a WIP (organization, stats to shows, wording, etc) but it is now starting to take shape into something close to what i envision the v1 version will look like.
IO stats will have some relevant metrics available for different io execs (parquet, csv, ndjson, arrow, etc).  Starting with just parquet for now.
For compute stats i think im going to have 4 sections (projection, filter, sort, join, and aggregate, and other which will include everything else - getting more insight from others on potential execs to extract would be interesting).
One of the open points is about how i aggregate stats on the same nodes / execs.  Im probably going to just rollup details per exec for v1 but you do lose some interesting information by doing that so ideally id like to improve on that.
An example of using this could be benchmarking and analyzing parquet files with different layouts (for example file sizes, row group sizes, bloom filters, page sizes, etc). Ideally running this command and comparing the results should make it easier to choose the optimal layout.
Todo for v1

[x] Selectivity based on rows
[x] Selectivity based on bytes
[x] Add "Other" compute stats
[x] Add "Join" compute stats
[x] Add "Aggregate" compute stats
[x] Cleanup display (alignment, same header widths, fixed decimals, etc)
[x] ~For IO add % of total for scanning and opening~ Going to revisit this
[x] ~Add throughput to summary based on output bytes from IO layer. Would be cool to do a pass that pulled actual file sizes that could be used.~ Going to revisit this
[x] Ratio of selectivity to pruning for parquet
[x] Avg/median time to scan single row group (total scanning time / row groups)
[x] Update README

Future

identify nodes where some partitions are "hot" (i.e doing much more compute than others)

@alamb FYI I've been working on adding this --analyze feature to the cli (its meant to complement the existing EXPLAIN, EXPLAIN ANALYZE, and EXPLAIN VERBOSE functionality - thought you may have some thoughts or ideas on it.

Thanks @matthewmturner  -- I'll try and check this out shortly

Made some improvements - latest is in the below image.  Something I thought of that I think would be quite cool is adding a ratio of the queries selectivity to the effectiveness of its pruning to help guide improvements in how people layout their parquet files (for example end result is only a few rows but we do no row group pruning - that is far from ideal).

This is the latest report thats produced.  Adding the throughput and IO as % of total then putting a bow on this with some docs and merging.

I have also updated the PR description with more background context and examples how this could be used.

Cleaned up the display a lot just now after testing some more complicated queries.  I think this is the output ill be going with for v1


Error running gradlew clean build

Hello there, thanks for the great work, however I got an error when trying to run and build. Could not find or load main class org.gradle.wrapper.GradleWrapperMain

It seems like gradle-wrapper.jar is missing.

I am having same issue. Please can you provide information on how you got around this?
I'm not a java person so all this is new stuff to me.
Some are saying to use git add -f gradle/wrapper/gradle-wrapper.jar to get the jar file but that isn't doing anything since this repo doesn't have it.

Instead of using gradle wrapper I was able to run this using regular gradle version < 3.0
On Macports I was able to get version 2.14 using commands:
$_ svn checkout -r 150408 https://svn.macports.org/repository/macports/trunk/dports/devel/gradle
$_ cd gradle
$_ sudo port install
:)

Thanks for reporting. Added the gradle-wrapper.jar explicitly.
@lfatty @hshar7 Confirm if you are able to run the build with gradle wrapper.


Is Magnific-Popup abandoned?

Probably @dimsemenov is busy with life. Over a year there was not an update. There are 40 pull request on the waiting list to solve some issues.
Does anyone know a good fork?

It feels like this always happens..
Lightbox to Fancybox to Magnific Popup to ?
Magnific popup is an amazing modal library, and I really hope it is maintained. If @dimsemenov has no interest in maintaining it, I wonder if he'd be willing to add some of us to be-able to accept/reject PR's & maintain the library.
IMO it would be better than a fork. Maybe setting it up as an organization?

I weekly monitor issues & pull requests, but do not have an ability to reply. I'm not interested in adding new features, and just fixing important bugs.
If you want to become an official collaborator – I'd gladly accept the help and promote your name/company, send me an email with details about yourself.

Sounds good :) I dropped you an email earlier (Danny).

I would like too

LightGallery is really nice too
https://github.com/sachinchoolur/lightgallery.js

LightGallery is really nice too
https://github.com/sachinchoolur/lightgallery.js

I'm not a fan of more and more options. Also this is GPL3 licensed. So far we use Swiper in all projects.


[CWS] do not implement containers telemetry on windows

What does this PR do?
This PR removes the nolint:unused by gating the containers telemetry code to linux only, and creating an empty shell for other OS.
Motivation

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

/merge

/merge


lazygit: 0.39.3 -> 0.39.4

Description of changes
https://github.com/jesseduffield/lazygit/releases/tag/v0.39.4
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 245176 run on x86_64-linux 1

1 package built:

lazygit


feat/refactor: general improvements to ir, workspace, and implementation of new analyses/transforms

This is a big set of changes containing much of my work from the last month or so that I would like to get merged today/tomorrow. See the individual commits for information on the changes contained within.
This is going to get merged pretty much as-is, and iterated on further in more targeted PRs later. That said, feel free to use this opportunity to leave comments, ask questions, etc.
NOTE: There are still a few minor details that are still work-in-progress. Namely the Program and Linker structs, which go together, and are largely stubbed out at the moment until I finish up work on the codegen crate, which is not present in this changeset. That will follow in its own PR in the next couple days.
@greenhat This likely affects you in a couple (relatively minor) ways - I'm most interested in your feedback on whether there are things you'd like to see, or that you find awkward. Some of the public interfaces, particularly around the builders are not super refined yet, so this is definitely the time to tweak how those work.
@jjcnn There are a few small changes to how the IR gets output (we have additional data that needs to be represented now), let me know if you have any questions about that when it comes to the parser for the IR. Some of the changes should have actually made it easier for constructing the IR in the parser, since there is basically no dependency between a Function and its parent Module anymore. The main thing to be aware of is the new Ident, FunctionIdent, and Symbol types, used for identifiers/interned strings.

I would like to get merged today/tomorrow.

Sorry, but this isn't going to happen. The PR contains around 10,000 lines of code, and there is just no way this gets reviewed properly in a day (especially not a day when github has issues).
You can have a proper review in the time it takes to do a proper review, or you can spend some time separating the PR into multiple, smaller PRs (which is Best Practice).
Also, do you mind describing the actual changes this PR makes, so that I have a proper chance of figuring out what is going on in the code? It is not particularly helpful to refer to it as "a big set of changes containing much of my work from the last month or so" - not only is that not helpful to the reviewer, but we also need the description in the commit history so that we can track the reasons why changes were made.

Sorry, but [review by today/tomorrow] isn't going to happen

That's fine, we should merge this anyway. I was quite clear that these changes are meant to be merged without an expectation of in-depth review, and that any issues raised here, whether before or after the changes are merged, would be addressed in subsequent bug reports/PRs. The entire point was to get us back in a cycle of small changes, ASAP.

You can have a proper review in the time it takes to do a proper review, or you can spend some time separating the PR into multiple, smaller PRs (which is Best Practice).

I have no intention of breaking up this PR into smaller ones - I'm fine with these changes as-is, at least at this point in time. To the extent that there are issues with the code here, I expect those to be raised as bugs; addressed with subsequent PRs that introduce missing or stubbed-out functionality (e.g. the linker); or are addressed in the course of making more general code quality improvements, after things stabilize and we have time to polish. Whether you wish to do a proper review is your prerogative, but that was not the purpose of this PR. I would prefer that you sign off, and review at your leisure, so that @greenhat and I can start working on merging our streams of work together as soon as possible - but if you do not want to do that, then another alternative to consider is pairing up and walking through the changes together to try and simplifiy the process, since having me on hand to explain and provide context will save a lot of turnaround time, and likely be more useful to you anyway. Aside from that, I think you'll need to justify your reticence to merge this PR, aside from questions of process, if you expect that your review will push beyond this week to complete. If need be, I'll merge these changes directly, but I'm only inclined to do that if it starts blocking other work that is in progress. For the time being, I appreciate any review you have time to provide.

Also, do you mind describing the actual changes this PR makes, so that I have a proper chance of figuring out what is going on in the code?

You'll have to be more specific - the individual commit messages are descriptive, in some cases quite verbose, and the code itself is well documented, especially the analyses and transforms. I also pointed out in my initial PR description the specific areas relevant to what you are working on that you may want to look at. What areas of the code in particular are you finding unclear and could be improved with additional documentation?
In an effort to save time and perhaps anticipate some contextual questions you may have, here is some additional (perhaps redundant) summary:

To the extent that there is a notion of a complete feature(s) here, it is in the implementation of the analyses and transforms that operate on the IR, which are well documented. If there are critical docs missing, let me know and I'll make sure to add them. The transforms in particular are pre-requisites for the stackification pass, which will come in a follow-on PR.
Everything else is either something required by the Wasm frontend, or falls out from working out the kinks in the IR that was initially sketched out; mostly as a result of working through lowering the full instruction set to Miden Assembly.
Support for globals is required by Wasm (and many languages more generally). Those in turn require us to introduce a linking step, in order to de-duplicate and lay out globals on the heap prior to code generation, since we need to translate access of global symbols into absolute addresses. There is no native notion of globals in Miden, so we are implementing it in software for now.
Most changes to Module and Function are intended to make it easier to parellelize the compiler, allowing one to compile using a function per-thread, or a module per-thread, or a combination of the two, while making it easier to link them all together later.
There are changes to Signature to better represent certain low-level aspects of arguments and results, describe linkage, and to make the signature itself independent of function name
The Visibility bitflags were removed in favor of the Linkage enum, which is used for both functions and globals.
ExternalFunction was introduced to represent a dependency on another function, from within a Function. It consists of just the name and signature, and corresponds to a function declaration, rather than definition.
Function is now always created with an entry block that matches the function signature, as it was never necessary to represent bodyless functions anyway.
There is no purpose in explaining each of the instruction changes, because the initial instruction set was a rough draft to begin with - with a number of missing operations, insufficient specificity, incorrect typing rules, etc. However, some of these changes are mentioned in the relevant commit message. Most of them are obvious, but if you have specific changes you are curious about, I'm happy to provide more details.
The introduction of the ModuleBuilder is intended to make imperatively building a module and it's functions more concise, as well as provide additional validation when doing so. This is primarily for the benefit of constructing IR for testing, but obviously it is useful more generally as well. FunctionBuilder still exists, and can be used either to build up a function from scratch, or modify an already constructed function.
A significant number of asserts/validations were added to the InstBuilderBase trait, to protect against the construction of invalid IR. Some supporting macros were added to make expressing common validations easier.
Symbol/string interning was added to make it possible to use natural identifiers to reference modules/functions efficiently, rather than arbitrary integer ids, while retaining the ability to get the string representation, order by name, etc. All uses of String for identifiers was replaced with an appropriate interned equivalent. This also was important for decoupling Module and Function for multi-threaded compilation.
Our Rust toolchain was out of date, that was updated to the latest stable release

If I've left something out, feel free to ask questions.

@greenhat This likely affects you in a couple (relatively minor) ways - I'm most interested in your feedback on whether there are things you'd like to see, or that you find awkward. Some of the public interfaces, particularly around the builders are not super refined yet, so this is definitely the time to tweak how those work.

I rebased my branch on this one and I'm going through the process of exploring your changes and adopting my code. I expect to finish it today (your morning) and provide feedback.

I rebased my branch on this one and I'm going through the process of exploring your changes and adopting my code. I expect to finish it today (your morning) and provide feedback.

Awesome! Let me know if you have any questions, identify any bugs, or find anything missing/awkward to work with. We can address those changes/improvements in subsequent PRs, but I'll make sure to prioritize anything that is a blocker.

I rebased my branch on this one and I'm going through the process of exploring your changes and adopting my code. I expect to finish it today (your morning) and provide feedback.

Awesome! Let me know if you have any questions, identify any bugs, or find anything missing/awkward to work with. We can address those changes/improvements in subsequent PRs, but I'll make sure to prioritize anything that is a blocker.

I adopted my code and fixed the build and tests (except the test for unsupported ops). I pushed my branch in my PR https://github.com/0xPolygonMiden/miden-ir/pull/17
I had to make two changes to your code (see comments in my PR):

Get FunctionBuilder from ModuleFunctionBuilder https://github.com/0xPolygonMiden/miden-ir/pull/17#pullrequestreview-1613516064
Fix type mismatch for Load Miden IR op https://github.com/0xPolygonMiden/miden-ir/pull/17#pullrequestreview-1613532016

Also, I see binary and comparison ops expect only integers now. Makes total sense. Following our call, I think it's better to remove all the float ops translations and return the unsupported error. Sound good?
Besides that, I did not find anything missing or awkward. I have not tried to implement globals and data segments yet. That would be my next move after I fix some minor todos I left in the code on rebase.

As an aside, you probably noticed, but just in case it got lost in the sea of changes, I did add support for a few of the unsupported ops you had listed, namely unreachable and select. I can't recall if there were any others. I need to dig into the semantics of some of the Wasm instructions in the unsupported list to determine whether or not they can be handled with the instructions that are there now, or if we need new ones, but I don't know that any of them are particularly critical to implement at this point, but let me know if you think there are some big ones that would be nice to have.

Thanks for reminding me about unreachable and select! I added them to my PR's todo list. I've scanned the unsupported list, and the following ops caught my eye:

signed integer comparison ops: gt_s, le_s, etc.
i32.wrap_i64 (i64_val mod 2^32 should work, so probably no need for separate IR op);
ctz, clz;
shr_s (bitwise shift right signed).

They seem like a "nice to have" ops.

We should probably discuss data segments before you dig in to the implementation there, shoot me a message when you have time, and we can set up a quick call to work through it quick, make sure we have what we need, and that it will play nice with how things are going to be represented in MASM.

Sure! Let me clean up my todo list (new ops, globals, etc.), and I'll ping you when I get close to it.

As for global variables, I think everything you need should be there now, but there may be some kinks to work out, or improvements to the ergonomics of the APIs we can make. I should note that a Function has no notion of the actual global variable data itself, instead it has a notion of a global value, like in Cranelift, and global variables are actually defined/exported at the Module level. The linker, which isn't fully implemented yet, will be responsible for stitching together the global data, validating that all symbols are present, de-duplicating, that sort of thing. Then, during code generation, we'll compute absolute addresses to the global data based on the layout chosen by the linker. One of the things you can assume is that all global variables will be laid out in memory so that their addresses are either word- or felt-aligned, so that we can always use aligned loads/stores with them. We may even be able to use native pointer types with them, but that's an optimization we can look into later.

Sounds good! I'll dig into it.

I've scanned the unsupported list, and the following ops caught my eye:
..
signed integer comparison ops: gt_s, le_s, etc.

I've pushed a commit that expands our type system with signed and unsigned equivalents, all of the standard operators (comparison, arithmetic, etc.) will be compiled based on the semantics of the types involved. I still have to work out what to do about signed integers in general - our only native option in MASM for signed integers are field elements, the support for u32 and u64 is only useful for unsigned ops, as you'd expect. That probably means that we either need to implement our own primitives for representing, say, signed 32-bit integers, or promote all signed 32-bit integers to field elements, but that comes with its own complexities. I suspect for now we'll need some combination of the two, i.e. using field elements for signed integers, with some additional generated code around ops involving them to protect the range of the type in question. I think we can probably kick this can down the road a bit though.

i32.wrap_i64 (i64_val mod 2^32 should work, so probably no need for separate IR op);

I think from your end, you can use trunc for this, since I think the semantics are basically discarding the upper 32-bits; but I'm just throwing that out there off-hand, it may turn out we need a dedicated opcode for this.

ctz, clz

I've got these on my todo list, because I think I'll need them for some of the low-level stuff I'm doing in the address space translation layer, but not sure exactly when I'll get them implemented. I'll keep you posted.

shr_s (bitwise shift right signed)

I'm assuming this is a standard arithmetic shift (i.e. sign-extending the high bits after shifting). There isn't native support for this in MIden, but this is something we can emit an instruction sequence for pretty easily, just like we will for ctz/clz and others. I think for now we can leave this unsupported, but adding support for it should be straightforward when we have a bit of time for it.
If you see any instructions coming through from Rust-compiled Wasm modules that are blocking simple programs, can you leave a comment on #19? We can track what is unsupported, but wanted there.

I've scanned the unsupported list, and the following ops caught my eye:
..
signed integer comparison ops: gt_s, le_s, etc.

I've pushed a commit that expands our type system with signed and unsigned equivalents, all of the standard operators (comparison, arithmetic, etc.) will be compiled based on the semantics of the types involved. I still have to work out what to do about signed integers in general - our only native option in MASM for signed integers are field elements, the support for u32 and u64 is only useful for unsigned ops, as you'd expect. That probably means that we either need to implement our own primitives for representing, say, signed 32-bit integers, or promote all signed 32-bit integers to field elements, but that comes with its own complexities. I suspect for now we'll need some combination of the two, i.e. using field elements for signed integers, with some additional generated code around ops involving them to protect the range of the type in question. I think we can probably kick this can down the road a bit though.

Nice! I'll rebase and try them out.

i32.wrap_i64 (i64_val mod 2^32 should work, so probably no need for separate IR op);

I think from your end, you can use trunc for this, since I think the semantics are basically discarding the upper 32-bits; but I'm just throwing that out there off-hand, it may turn out we need a dedicated opcode for this.

Yeah, trunc should do the job.

shr_s (bitwise shift right signed)

I'm assuming this is a standard arithmetic shift (i.e. sign-extending the high bits after shifting). There isn't native support for this in MIden, but this is something we can emit an instruction sequence for pretty easily, just like we will for ctz/clz and others. I think for now we can leave this unsupported, but adding support for it should be straightforward when we have a bit of time for it.

Yep, here's the spec for it:
https://webassembly.github.io/JS-BigInt-integration/core/exec/numerics.html#op-ishr-s

If you see any instructions coming through from Rust-compiled Wasm modules that are blocking simple programs, can you leave a comment on #19? We can track what is unsupported, but wanted there.

Sure. Will do.


don't report blocked streams as active for sending data

Depends on #1069.
When a stream is stream-level flow control blocked, stream.popStreamFrame now doesn't report this stream as active. That way, we won't call popStreamFrame (which would return nil until new flow control credit is granted) every single time when packing a packet.
Note 3 things here:

When calling stream.Write or stream.Close after a stream became blocked, we're still reporting it as active. The streamFramer will call stream.popStreamFrame a single time (which would then report it as having no more data).
It is only possible to call stream.Write exactly once (unless you're setting write deadlines) after a stream became flow control blocked, since stream.Write blocks until all the data has been sent out.
This only works for stream-level blocking. If we're connection-level blocked, all streams will stay active, and stream.popStreamFrame will be called for every single one of them every time when sending a packet, and return nil (assuming the stream contributes to connection-level flow control), until new connection-level flow control credit is granted.

Codecov Report

Merging #1072 into master will decrease coverage by 0.08%.
The diff coverage is 86.11%.

@@            Coverage Diff             @@
##           master    #1072      +/-   ##
==========================================
- Coverage   90.94%   90.86%   -0.08%
==========================================
  Files         107      107
  Lines        7264     7286      +22
==========================================
+ Hits         6606     6620      +14
- Misses        427      434       +7
- Partials      231      232       +1

Impacted Files
Coverage Δ

stream.go
88.24% <ø> (ø)
:arrow_up:

streams_map.go
89.76% <ø> (-2.46%)
:arrow_down:

crypto_stream.go
100% <ø> (ø)
:arrow_up:

internal/flowcontrol/base_flow_controller.go
100% <ø> (ø)
:arrow_up:

internal/flowcontrol/connection_flow_controller.go
100% <100%> (ø)
:arrow_up:

session.go
84.71% <100%> (+0.08%)
:arrow_up:

internal/handshake/tls_extension_handler_server.go
88.89% <33.33%> (-3.42%)
:arrow_down:

internal/handshake/tls_extension_handler_client.go
90.16% <33.33%> (-3.06%)
:arrow_down:

internal/flowcontrol/stream_flow_controller.go
98.55% <75%> (-1.45%)
:arrow_down:

send_stream.go
95.91% <81.25%> (+0.2%)
:arrow_up:

... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae739f7...abf0020. Read the comment docs.


PIP_REQUIREMENTS='boto3==1.11.3' break with sed error

boto3 includes s3transfer, somehow when building with the latest release the build script show sed error where sed trying to modify pycache folder and end up with exit errocode 4
This issue does not appear in build f227220f885428f62012f4239f9ba7bca495dec6
[python/stderr] sed: couldn't edit pycache: not a regular file
ERROR: Failed to run plugin: python (exit code: 4)

@raymondsamalo I fixed this line. A directory has exec permission. Hence it was wrongly considered as an executable. At install boto3, or one of its deps, generates a pycache folder inside the bin folder.
I updated the plugin AppImage as well. Let me know if this fixes your issue, or not?

thanks @niess the fix fixed the issue
really grateful for the super fast response to fix this

@raymondsamalo Great. Thank your for reporting this bug :)


Added response.end() method & moved the Test.unit package into bower dependencies

I moved the Test.unit package into bower dependencies because without it there you get this build error another option was to move the Node.Express.Test.Mock module into the tests directory. I didn't go down that route because from earlier commits it seemed to have been moved into the src folder on purpose.

Thanks for the contribution! Looks good :+1:  However, the test case can be improved. Right now it doesn't check that end method is really called. You can remove the line setupMockApp $ use end and the test will still pass. One way to check the call is to add corresponding method into MockResponse here and make it do something, e.g. set a body to some predefined string. Later you can compare response body to that string and be sure that end is called.

@dancingrobot84 thanks for the tip on how to rewrite the test case, will make those changes.

@dancingrobot84 I made some changes to the tests as advised. I hope they suffice.

Good :+1:  Thank you!


Comments inside func defitions are rendered in the index

Go allows for comments inside the function definition in some cases, like the following example:
func Foo(r interface {
	// Comment about this function
	Bar(string)
})  {
}

One example where this is used is in the go-cmp package.
When the documentation for this package is rendered by gddo, the result is not what I would have expected (live version).
I'll include a screenshot to highlight the issue:

I would have expected the comments not to be included in the method definition overview, making the end result look like this:
func Reporter(r interface {
  PushStep(PathStep)
  PopStep()
}) Option

This will be resolved in the upcoming Go discovery site, golang/go#33654.

خبر
واکنش مقتدی صدر به حوادث اخیر عراق


I don't understand why the ScrollView background is painted with the MessageBox color in FSharp example.

It is not a language I master well. I do it out of curiosity but sometimes it ends me. Devil.
However, I will submit some changes in the opening of files.

The Editor and Hex open the same file on all system. It's on the PR #974.

TextField also doesn't get focus when clicked.


Get results more aligned with those returned by Chrome Dev Tools Lighthouse

I'm loading profiles from the Lightkeeper package so I would assume the results to be identical:
https://github.com/BKWLD/lightkeeper/blob/d783990eb535aa0b6cf4c2c0340d9da98ae37054/lightkeeper.coffee#L14-L15

[ ] Read variability docs to see if there is some intrinsic reason for difference
[ ] Search issues for anyone talking about ways to improve this

Fixed with #10


hello. sorry i asked question again . i am really sorry . can not create post and post not showing in main page but  in your latest repository

hello this is the latest from your repository i uploaded on github :
[

](https://github.com/am0029/latest-dev-to-clone.git)
at the first website not loading i have to delete this line from cliet/src/postlist/component./post.jsx   line 52 makes problem
and post page not showing at clinet/src/pages/postpage/componnets/post.jsx
  return (     post && (       <Wrapper>         {isFirstPost && (           <Image             onClick={() =>               navigate(/${post.author?.username}/${createPostUrl(post.title, post.id)})             }         I HAVE TO REMOVE THIS LINE UNTILL SITE WORK >>   src={post.image.url}           />         )}
cloudinary part uploading image to cloudinary .  but the posts not showing at the first page : localhost:3000   but it is ok in mongo db and post  saved in mongo db but not showing in website  post list . do not know why
and when u click on the post and it goes to blank page instead  .
this is your latest repository language english that i put 2 .env file one in client and one is server
but i did not add google client id because i do not have
and when u click on the post and it goes to blank page instead  .
can u check why post created in mongo db but not showing in website and pictures all white  it means picture uplaoded to cloudinary but there is no post in website with that picture and body and title . nothing . and picture not showing at all  .

And I already removed half of the code for posting to cloudinary in posts.. I am really disappointed is that for free again really

can u say what is the link of the source code that  u removed cloudinary ?
i downloaded latest from your repository and main page does not have new post .
yes it it was my problem i  did not wanted to pay to devleoper to build  for my college . there is no good thing in github .if it was good . it was not for free . but u help me really a lot but at the end nothing the issues is too many .
really need another developer
ok how much u want for fix this issues because it is not make sense i pay to another devloper . untill they come and see another code . that not make sense ..
say how much u want for this fixes ? and i pay to u
i need this for my college just send me full backup
<EMAIL_ADDRESS>


Convert _MessageBase to a typealias

Remove the _MessageBase protocol in favor of a type alias with different definitions for debug and release builds.
This should decrease the code size without requiring an underscored attribute (see #1497).

This seems like an even better option than the maker protocol.
Since _MessageBase is really just "a list of common protocols that messages conform to", I wonder if it's worth renaming it to hammer that point home. Something like _CommonMessageConformances, so people don't get the idea that they should try to constrain generics based on it or add functionality to it (which fortunately they won't be able to if it's just a typealias).

I like the new name.I will rename the type alias.

Thanks for the patch!


Proposal: Adding IServiceProvider to ConnectionFactory

Hi
This question is based is my assumption that the IConnectionInstance should be singleton and that the underlaying connection and authentication is managed by this package.
Following that, would it be possible to add IServiceProivder to ConmectionFactory?
Currently I’ve implemented a health check that runs on container startup and I would like to reuse that connection since it’s already authenticated. The health check retrieves singleton from service container and binds option to configuration.
Edit: I could of course use the options class in my health check if it (ConnectionFactory) is called once. I don’t think the breakpoint was hit multiple times inside the delegate.
best regards

This package doesn't actually create or manage a Redis connection, it just customizes a ConfigurationOptions instance that your app can use to create a Redis connection.
It sounds like you're using a dependency injection system. To add a singleton ConnectionMultiplexer instance you'd use something like this:
var redisConfig = ConfigurationOptions.Parse(redisConnectionString);
await redisConfig.ConfigureForAzureWithSystemAssignedManagedIdentityAsync(principalId);
services.AddSingleton<IConnectionMultiplexer>(await ConnectionMultiplexer.ConnectAsync(redisConfig));

Will that instance be used then if I don’t specify neither ConnectionString
nor ConnectionMultiplexerFactory during service registration?
Thanks
fre 3 maj 2024 kl. 17:31 skrev Philo @.***>:

This package doesn't actually create or manage a Redis connection, it just
customizes a ConfigurationOptions instance that your app can use to
create a Redis connection.
It sounds like you're using a dependency injection system. To add a
singleton ConnectionMultiplexer instance you'd use something like this:
var redisConfig = ConfigurationOptions.Parse(redisConnectionString);await redisConfig.ConfigureForAzureWithSystemAssignedManagedIdentityAsync(principalId);
services.AddSingleton(await ConnectionMultiplexer.ConnectAsync(redisConfig));
—
Reply to this email directly, view it on GitHub
https://github.com/Azure/Microsoft.Azure.StackExchangeRedis/issues/45#issuecomment-2093249060,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AADLF5FYDMXMHA7DXNHXCPTZAOUU3AVCNFSM6AAAAABHDZEXWWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOJTGI2DSMBWGA
.
You are receiving this because you authored the thread.Message ID:
@.***>

A connection string is passed into the ConfigurationOptions.Parse() call. The single instance created and registered via AddSingleton() in that sample will be used throughout your application.

Closing this now to tidy up. Feel free to reactivate if needed.


fix: incorrect Java SDK installation and initialization code examples

Thanks for submitting a PR! Please check the boxes below:

[ ] I have added information to docs/ if required so people know about the feature!
[X] I have filled in the "Changes" section below?
[X] I have filled in the "How did you test this code" section below?
[X] I have used a Conventional Commit title for this Pull Request

Changes
This PR fixes #4593 and brings the following changes :point_down:

Added closing bracket to version xml tag and made changes to include </dependency> as a part of the code example, in installing the sdk section
Updated the version of maven and gradle dependencies from 5.0.0 to 7.4.1
Changed the builder method to newBuilder() under FlagsmithConfig class
Formatted the maven dependency code with tabs (4 spaces) to look clean and good

How did you test this code?

Navigate to frontend directory.
Run npm ci
Run npm run dev
Open http://localhost:8080/ and create a test account.
Create a project after creating the organization.
Click on Environment section and then features from the side bar.
Checked the modified code examples by clicking in each of the two accordions.

Thanks @SaptarshiSarkar12 !

Thank you @matthewelwell for reviewing and merging my PR :heart:!


Add Spanish NLP

Added @dav009's list.

Looks interesting, but the list doesn't look very active.

@dav009 Can you read the contributing guidelines and the awesome manifest, and ensure your list follows it? Mainly, license, contributing guidelines, description for items. I would also clarify the headings POS TAGGERS, MLWE, NER. Not everyone interested knows the lingo.

@RichardLitt awesome.
@sindresorhus Gonna make  those changes and come back to this PR

<3

@sindresorhus  updated:

Added contribution guidelines
License
Expanded Acronyms

Added. Would still like to see more descriptions for the items, though.


Remove graphiql endpoint, fixes #253

Remove graphiql endpoint altogether, since apollo devtools have it included

Thanks @codepunkt !
I am gonna add u as a collaborator. You seem very interested in this project. 👍


onChange handler not called when only picking hours

First of all thank you for your work on this library! It's realy neat :)

Environment

Tech
Version

@material-ui/pickers
^4.0.0-alpha.7

Steps to reproduce
On desktop

Open a DateTimePicker (I'm using DesktopDateTimePicker) with the autoOk property
Pick an hour
Close the picker instead of picking a minute
Open the time picker again to see that the internal state has changed

Expected behavior
I'm not sure if this is a bug or just the intended behavior, but I would expect the onChange handler to be fired when the time changes even if the input is not complete, so to say.
Actual behavior
Just the onClose handler is called. The onChange handler only is called when also picking the minutes (together with onAccept).

Duplicate of #1709


Follow protocol grammar fix GCPhrase -> GCPhase

[ ] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #.
[x] Update the CHANGES log.

Follow https://github.com/apache/skywalking-data-collect-protocol/pull/60.

Let's whether e2e passed. This PR is using the protocol using GCPhrase.


Update README.md

#!/usr/bin/env sh
set -eu pipefail
echo "Installing CircleCI Runner for ${platform}"
base_url="https://circleci-binary-releases.s3.amazonaws.com/circleci-launch-agent"
if [ -z ${agent_version+x} ]; then
agent_version=$(curl "${base_url}/release.txt")
fi
Set up the runner directories
echo "Setting up CircleCI Runner directories"
sudo mkdir -p /var/opt/circleci /opt/circleci
Downloading launch agent
echo "Using CircleCI Launch Agent version ${agent_version}"
echo "Downloading and verifying CircleCI Launch Agent Binary"
curl -sSL "${base_url}/${agent_version}/checksums.txt" -o checksums.txt
file="$(grep -F "${platform}" checksums.txt | cut -d ' ' -f 2 | sed 's/^.//')"
mkdir -p "${platform}"
echo "Downloading CircleCI Launch Agent: ${file}"
curl --compressed -L "${base_url}/${agent_version}/${file}" -o "${file}"
Verifying download
echo "Verifying CircleCI Launch Agent download"
grep "${file}" checksums.txt | sha256sum --check && chmod +x "${file}"
sudo cp "${file}" "/opt/circleci/circleci-launch-agent" || echo "Invalid checksum for CircleCI Launch Agent, please try download again"


Poor distance accuracy on Android

Describe the bug
I tested the Android and iOS app with the beacon scanner of David Young http://www.davidgyoungtech.com/2020/04/24/hacking-with-contact-tracing-beacons
While the distance readings with my iPhone X are amazingly accurate at about +/- 30 centimetres, the results for a OnePlus A5010 are out of range. Readings were off about 3-5 meters.
Expected behaviour
At least an accuracy within a meter distance.
Steps to reproduce the issue
see screenshots
Test setup:
https://1drv.ms/u/s!AnKeW8KMoCcyyl9nsePdpaqpTSXU?e=8eKGhQ
The device running the beacon scanner was at the same position as the photographer.
Test results:
https://1drv.ms/u/s!AnKeW8KMoCcyymCv97la8HuPWDhG?e=kRbAMz
Technical details
iOS 13.5
Android 10
Possible Fix

Additional context

This cannot be fixed by the app itself. I advise to close. Out of scope.

Sorry, this cannot be closed w/o an official statement from the responsible developer.
If this accuracy is the case on Android in general, the app becomes meaningless.
I continued testing on iOS devices, and can confirm that the distance measurement on iOS devices is close to perfect.
Would be great if someone else could test this with other Android phones to verify if my OnePlus is maybe faulty or if this is a generic problem with the plethora of Android devices.

Works perfectly for me on my OnePlus 6T. So this might be an issue with your Android Device.

the accuracy of bluetooth attenuation in general is bad. it depends on so many variables. officials said they tested the concept under laboratory conditions, but these are not the same conditions where the app and smartphones are used.
I had recently pointed out this issue here: https://github.com/corona-warn-app/cwa-documentation/issues/85
See the comment from @SebastianWolf-SAP at the end. An app can't overcome this general issue. The devs are aware and this problem is "out-of-scope for this project".

@rawern @SebastianWolf-SAP thanks for cross referencing the issue.
I understand the problem with the BT based distance measurement, but apparently it can be solved in a reasonable manner as my test results indicate on iOS.
The app I use for testing is based on the  Android beacon lib https://github.com/AltBeacon/android-beacon-library
which I assume is also used in one form or the other in the official Google Covid API implementation (correct me if I am wrong).
So what would be helpful at least is to publish a list of "tested" Android devices where the distance readings are in ballpark accurate - lets say +/- one meter under pre-defined conditions. In cases as with my tested Android device, the app is useless because it would not track an infected person even if I literally hugged them ;-)

If this accuracy is the case on Android in general, the app becomes meaningless.

Well :) knowing about issues like this - I asked for a "whitelist" for working phones.
https://github.com/corona-warn-app/cwa-documentation/issues/198
Cheap Phones are designed to be cheap. That's why the Bluetooth stack is tested with headphones and ear pads. The Bluetooth LE fancy stuff - like iBeacons or Watches often have problems. Good luck with blacklisting devices - while we don't even have a whitelist...

Got nothing to do with cheap versus expensive BT hardware.. most of it is antenna design, orientation of the antenna and objects:
https://www.youtube.com/watch?v=SAi24ctpyZQ
Bluetooth Distance Estimates 101:
http://www.davidgyoungtech.com/2020/05/15/how-far-can-you-go
Improving BLE Beacon Proximity Estimation Accuracy through Bayesian Filtering:
https://arxiv.org/abs/2001.02396
Any distance is relevant, check the YouTube video to see how much of a difference it makes already if you wear your phone front or back pocket.

Ranging via RSSI is an inherently flawed technology. There's not much you can do. Even though it is flawed, it is the best technology for contact tracing that is widely available and cheap.

I am testing it right now between a Pixel 3 and a Pixel 3a.
Both smartphones are within 1 m. But measured distance is between 2 m and 9 m (rotation of the phones is a big factor).
Did you test distance measurements with smartphones that are in use (someone is watching a video horizontal, writing a message, has smartphone in different kind of pockets)?

As mentioned before, this is not an issue that the app itself can fix. Fraunhofer institute is heavily involved in testing this.
Additionally, as mentioned in this issue RSSI alone is not a good measure for distance but transmission power needs to be considered, as well, when comparing different devices (though this does, of course, not solve the front/back pocket issue)

@mtbsteve is the offset at least constant at a given distance? can you calculate the offset as a function of distance? can you find your phone (or similar) in this list, used to configure the French app? This might indicate an error in the signal strength communicated by your phone.

@pdehaye no I don’t own any of the Android phones listed in the code you were referencing.
I tested with some other phones in the meantime and found a more accurate distance measurements compared to my OnePlus A5010 I originally used. Results are still off compared to my iPhones,  but at least in reasonable ballpark.
Another observation is that the ID transmission frequency is a factor of 3 higher on iOS compared with the Android app. This results in a better accuracy when both the sending and receiving devices are moving.  Maybe this is something to look at. @tkowark


Propseg: WARNING: In /usr/local/ITK-static/include/ITK-4.5/itkGaussianOperator.hxx

when running propseg on the MNI-Poly-AMU t2 template:
command ran:
sct_segmentation_propagation -i MNI-Poly-AMU_T2.nii.gz -t t2 -mesh
'''''
WARNING: In /usr/local/ITK-static/include/ITK-4.5/itkGaussianOperator.hxx, line 61
itkGaussianOperator (0x7fff5b50f0f8): Kernel size has exceeded the specified maximum width of 32 and has been truncated to 33 elements.  You can raise the maximum width using the SetMaximumKernelWidth method.
'''''

This error will be fixed when using new version of spinal cord detection for PropSeg


Added graceful shutdown of host

I have added a StopAsync to the host so it shuts down gracefully thereby adhering to the way they do it in the .NET 6 of AspNetCore testing library: https://github.com/dotnet/aspnetcore/blob/330c2397160929d6d3275ade03cee436265258e8/src/Mvc/Mvc.Testing/src/WebApplicationFactory.cs#L585.

This will be in the next Nuget, probably later today

@mslot I reversed this out, it hangs on CI. There is a DisposeAsync() that uses the underlying StopAsync(). I'd suggest using that. GetAwaiter().GetResult() is always potential for deadlocks.

@mslot I reversed this out, it hangs on CI. There is a DisposeAsync() that uses the underlying StopAsync(). I'd suggest using that. GetAwaiter().GetResult() is always potential for deadlocks.

So you called DisposeAsync instead? Makes sense. Thanks for noticing it.


Duplication in hierarchical dimensions

Concerns test.visualize.admin.ch, with data source INT. For reproduction, look at cube with identifier Jstat_fullHierarchy_C-94 (name is "NFI: All target values by ownership" from the 06.04.2023.
After some internal feedback, we decided to try to add the grandchildren directly to the root. I.e. we have four hierarchies on the dimension nfi:unitOfReference with Root https://ld.admin.ch/country/CHE:

CH - Cantons
CH - Production Regions - Economic Regions
CH - Protection Forest Regions - Economic Regions
CH - Economics Regions this one is new

They all use the path schema:containsPlace and a sh:targetClass appropriate for the corresponding hierarchical branch.
In the drop-down menu, children and grandchildren of the hierarchy are displayed:

I don't think this is a data issue, as this should demonstrate.

👀 looking at the data published by @kronmar this seems really odd parsing in a very non-conformant way according to the cube spec. (i.e. including some non targetClasses)
potentially related to inference i.e. due to parsing other cubes shapes?

Yes, you are correct. The https://ld.admin.ch/dimension/bgdi/biota/economicregions/xx are indeed both children and siblings to the https://ld.admin.ch/dimension/bgdi/biota/productionregions/xx.
Another find that might be unrelated is this:

You can find it here. You'll see that the root is mentioned four times (number of branches in the hierarchy?). Again, not really sure if this is related or not. If you wish, I'll open a separate issue.


"Quota exceeded for quota metric 'Queries' and limit 'Queries per minute'

I'm getting the error:
"Quota exceeded for quota metric 'Queries' and limit 'Queries per minute'
on the first run.

Try using an API key. Get it from here.
Previously, PageSpeed used to allow API calls without an API key, but now they seem to have made it mandatory to use a key.


#3416 persisting cookie policy.

This will add in the option to persist cookie policies on requests when the session and request cookie jars are merged. Currently any custom cookie policies on the session are not sent as noted in #3416.

So I'm generally ok with this, but I'd like @sigmavirus24 and @kennethreitz to have a look.

@sigmavirus24 given your thoughts in #3595 on leaking cookies, I wanted to ping you on this again. Requests current implementation of prepare_cookies for Sessions silently deletes the cookie policy provided and gets rid of information like allowed_domains and blocked_domains.
Since I opened this, I ran across #2714, but this doesn't seem to fall under the work you've outlined there. There does seem to a bit of interaction between the code changes though. I'd appreciate any feedback you have.

Hey @sigmavirus24, I know you're busy. I just wanted to move this back up the stack again in case you find yourself with an extra moment to spare. Thanks!

Needs a rebase.

I'm actually going to propose we close this one unless there's consensus it's needed. There seem to be a lot of unresolved discussion on the state of Session cookies.

thanks @nateprewitt

Given @Lukasa's comment in #4000 do we want to revisit this?
The caveat of conflicting policies still seems a bit ugly but that would be a pretty rare case that requires manual user intervention to occur.


custom resource returned: Error: 'agentVersion'

Describe the bug
custom resource returned error when creating Agent (errorred out in us-west-2, us-east-1 seems to be fine):
[BedrockCRProviderCustomResources log:
[ERROR] KeyError: 'agentVersion'
Traceback (most recent call last):
File "/var/task/custom_resources/init.py", line 47, in on_event
return on_event_bedrock_agent_alias(event, context)
File "/var/task/custom_resources/bedrock_agent_alias.py", line 81, in on_event
return on_create(event, str(uuid.uuid1()))
File "/var/task/custom_resources/bedrock_agent_alias.py", line 311, in on_create
response = create_agent_alias(agent_id, alias_name, session, agent_version, client_token)
File "/var/task/tenacity/init.py", line 289, in wrapped_f
return self(f, *args, **kw)
File "/var/task/tenacity/init.py", line 379, in call
do = self.iter(retry_state=retry_state)
File "/var/task/tenacity/init.py", line 314, in iter
return fut.result()
File "/var/lang/lib/python3.12/concurrent/futures/_base.py", line 449, in result
return self.__get_result()
File "/var/lang/lib/python3.12/concurrent/futures/_base.py", line 401, in __get_result
raise self._exception
File "/var/task/tenacity/init.py", line 382, in call
result = fn(*args, **kwargs)
File "/var/task/custom_resources/bedrock_agent_alias.py", line 200, in create_agent_alias
agent_version = get_version(
File "/var/task/custom_resources/bedrock_agent_alias.py", line 169, in get_version
return routing_configuration[0]["agentVersion"]
Expected Behavior
Agent create success
Current Behavior
cdk stack deployment fails
Reproduction Steps
import * as cdk from 'aws-cdk-lib';
import { bedrock } from '@cdklabs/generative-ai-cdk-constructs';
import { Construct } from 'constructs';
export interface KbStatefulProps extends cdk.StackProps {
}
export class KbStatefulStack extends cdk.Stack {
constructor(scope: Construct, id: string, props: KbStatefulProps) {
super(scope, id, props);
const knowledgeBase = new bedrock.KnowledgeBase(this, 'BedrockKnowledgeBase', {
  embeddingsModel: bedrock.BedrockFoundationModel.TITAN_EMBED_TEXT_V1,
  instruction: `you are a knowledgeable base that answers all questions`,
});

const tamAgent = new bedrock.Agent(this, 'MyAgent', {
  name: 'MyAgent',
  description: 'The agent for consultation on any example issues.',
  foundationModel: bedrock.BedrockFoundationModel.ANTHROPIC_CLAUDE_V2,
  instruction:
    'You are a useful agent that provides details or advices related to any issues.',
  idleSessionTTL: cdk.Duration.minutes(15),
  knowledgeBases: [knowledgeBase],
  shouldPrepareAgent: false,
  aliasName: 'exampleAliasName',
});

}
}
Possible Solution
bedrock_agent_alias.py line 169, change to 'return routing_configuration[0].get("agentVersion")'
Additional Information/Context
No response
CDK CLI Version
2.139.0 (build 2699ffd)
Framework Version
0.1.134
Node.js Version
20
OS
Linux
Language
Typescript
Language Version
No response
Region experiencing the issue
us-west-2
Code modification
no
Other information
No response
Service quota

[X] I have reviewed the service quotas for this construct

Hi @InitialXW , thank you for reporting this issue. I was not able to reproduce, however we are working on updating this construct to use the official L1 Bedrock constructs, which will remove the custom resource and probably fix this on your end. I will update this ticket when the work is done

Also seeing this issue now since upgrading the package to version 0.1.140, can't actually deploy my stack at all now and this is blocking. Example to reproduce here: https://github.com/leegilmorecode/serverless-amazon-bedrock-agents

@leegilmorecode do you also see this error in us-west-2 ?

us-east-1 is where it was previously working fine. I’ve only updated this package from version 0.1.72 and I’m now getting the error. I can’t seem to get past it and deploy.

@leegilmorecode, please see my suggested fix in my post to unblock you till there is a perm fix


Fix DeltaTable.Exists() - look for checkpoint files as well as commit files, and iterate the entire log folder

Changes

Change the DeltaTable.Exists() function to recognize checkpoint files as well as commit files
Use the list iterator when looking for commit/checkpoint files, so that if none are on the first page of results we will look through the entire log folder
Add a pagination option to the S3 mock client for testing
Expand unit test

Tests
I added a unit test specifically for this situation, TestDeltaTableExistsManyTempFiles().  It fails without the changes to Exists() and passes with them.

[X] make test passing
[ ] relevant integration tests passing

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@8b1735a). Click here to learn what that means.
The diff coverage is n/a.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
@@           Coverage Diff           @@
##             main      #45   +/-   ##
=======================================
  Coverage        ?   74.91%
=======================================
  Files           ?       18
  Lines           ?     2790
  Branches        ?        0
=======================================
  Hits            ?     2090
  Misses          ?      541
  Partials        ?      159


GPU utils behave differently with libcuinterpose.so built from different env

investigating through objdump, compiler, and Makefile specifications to make sure all users can build the same .so file.
may need to add debug message in the intercept lib to check out the followings.
gpu utils by process
time interval
fill rate
cuda call token consumptions

mount /sys/fs/cgroup/  from host to container causing the difference, may overwrite container's own cgroup info
the required cgroup.process ID info is not retrieved correctly. So the gpu utilization by process did not get the real gpu utils.

the issue must be solved. manual installation requires too much work from the user side. 1)install nvidia tool kit, 2) install go lang, 3) copy paste .so and 4) launch vgpu server, and device plugin process on each gpu node....
current plan:

adding debug message to check the process id obtained from "/var/lib/alnair/workspace/cgroup.procs" in two different set up. Verify the process id is wrong in the containerized vgpu server and user container
change the /sys/fs/cgroup/ mounting point in the vgpu server
verify vgpu server can get the container process id correctly and user container load it correctly in the file.

confirmed the through mounting /sys/fs/cgroup, cgroup.procs file is there, but the file is empty, no process id visible in the container, which is unlike in the host.
this is mounting kind of created a nested docker hierarchy, which may not make sense. could search docker in docker more.
however, current solution is switched to mount docker socket, and ask process id through docker top <containerID> to obtain all the pid in the container.


add testcase for #1405

Codecov Report

Merging #1406 into master will increase coverage by <.01%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             master   #1406      +/-   ##
===========================================
+ Coverage      85.3%   85.3%   +<.01%
- Complexity     5808    5809       +1
===========================================
  Files           135     135
  Lines         20682   20682
  Branches       4630    4630
===========================================
+ Hits          17642   17643       +1
  Misses         1960    1960
+ Partials       1080    1079       -1

Impacted Files
Coverage Δ
Complexity Δ

...baba/fastjson/support/spring/FastJsonJsonView.java
90.52% <0%> (+1.05%)
33% <0%> (+1%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f367afd...30f00dc. Read the comment docs.


Custom ID Generator as an alternative to middleware

Problem
Prisma provides a way to autogenerate ids with @default however only few functions are available: cuid uuid and autoincrement. When using custom IDs, you'll have to manually provide the ID to the create function. This results in some unnecessary code that can be removed.
Using middleware is possible, however typescript will still required an id to be passed to the function.
Also, when generating ID's based on fields, this adds a bit more complications. The way I'm generating ID's is based on an object enum field with a single default value as such:
enum UserObject {
  user
}
model User {
  id String @id @map("_id")
  object UserObject @default(user)
}

Then, I made a function so that I use it as such: generateId('user') typed to accept only objects from the schema which will return an generated id based on that object, for example: usr_xxxxxxxxxxx.
Suggested solution
A way to achieve this is to allow @default(customIdGenerator()) in the schema file and then set globally an ID generator on the Prisma object, maybe something like this:
Prisma.setIdGenerator((data) => {
   // this will return
   return generateId(data?.object)
})

This should work with composite types as well

Would this request be covered by this very similar feature request here @HommeSauvage https://github.com/prisma/prisma/issues/6719?

Yes, that would be amazing. We can close this one.


docs: consistently use sidebars.js filename

Motivation

sidebar.js should be modified to sidebars.js in some files
Have you read the Contributing Guidelines on pull requests?

Yes!

@leedom92 Why closing this?

@leedom92 Why closing this?

I thought the PR was not accepted，I reopen it right now.

Just waiting for CLA. Have you signed it?

Just waiting for CLA. Have you signed it?

oh，thx! I had signed it just now.


Legacy env publish fails if [vars] syntax present in toml

Version:
<EMAIL_ADDRESS>
Config
[vars]
FOO = "test"

Command
> wrangler publish

Error
Cannot use 'in' operator to search for 'zone_id' in test

We should give a better error message for this, but - did you mean to use [vars] here instead of [env]?

Oh whoops, yes I did - edited, thanks.
The workaround is to use legacy_env = true.

The new device environments are still experimental so I'd caution against using them in production
But this scenario should still work. I'll investigate this soon, thanks for filing!

I made a sample repo here https://github.com/threepointone/test-wrangler-publish and it appears to work just fine. Could you make a sample repo that demonstrates the problem?

It might need a route to trigger the zone_id parsing. Will try it out shortly.

I tried to reproduce using your project and adding a bunch of stuff from my other project, but I'm not able to repro it. I'll re-submit with a minimal repro project if I encounter it again, closing for now - thanks for looking into this with me!


Favicon

to #29
This one appeared to be a bit messy. At the end I started looking into this option - meaning just ignore favicon requests. Maybe ... it is simpler to remove the favicon and choose that way ?
So:

favicon works (nodemon, npm start, docker), added a couple of deps
lives in public in the root
along with this some cleanups in config so that TS builds stuff into ./build dir, not ./build/src - this is for good anyway. But ended up messing the PR a bit, sorry for this.

maybe merge ? alternatively I can simplify it to the option I mentioned above. I actually started thinking that favicon is not that necessary for such a project :) But, need an opinion :)


Update forbid-prop-types: handle prop-type functions with no args

This PR aims to fix #1673 by adding a new option to the forbid-prop-types rule: empty.
This will catch prop types which are functions, such as shape() or arrayOf(), but are used with either no arguments, or empty arguments ({} or []). These prop types don't add a huge amount of value in those scenarios, and should be avoided if possible.
Feedback appreciated 🙂

I've added a lot of tests in this PR. Happy to cut them down if you think that would make it easier for other contributors to follow.

Just made a couple of small changes to make sure this is backwards-compatible 🙂

@jack-lewin ping, are you still interested in completing this PR?


Narrative & Structure

One of the challenges of writing an article as big as this, and covering as much content, is having a clear overarching narrative. I think at this point it is one of the biggest remaining weaknesses of this article.
A couple things you can do to help improve the narrative:

Try to write a 1 sentence explanation of what each section is about. Is it a coherent unit? Does the section title help the reader understand?
If you were making a "visual table of contents" for this article, is there a symbolic image that would feel appropriate for each section?

Here's something I threw together with my thoughts on the sections (it's very rough):

I mostly feel like the second section, presently titled "The Path of Descent" doesn't seem to have a super clear point to me. At the moment, it feels like the grouping of content is a bit forced.
You go through three cases: linear regression, polynomial regression, and graph laplacians. The section seems to switch back and forth between being focused on examples and being focused on particular failure modes, going through the subsections:

Linear Regression
Bad Scaling
Understanding Early Stopping

Example: Polynomial Regression -- this subsubsection is bigger than all the previous subsections combined

Laplacian Systems

The Colorization Problem

I think it would be clearer if you decided whether top level sections were going to be examples or properties of optimization. You might also be able to do both simultaneously if you made the sections something like "Linear Regression & Bad Scaling", "Polynomial Regression & Early Stopping", etc. (It might also be possible to make such sections into top-level sections.)
I also think you should consider whether laplacian systems might fit better in, or directly before, the "The Resisting Oracle".

These are great observations. I'll play around with the organization of the document this weekend and see if I can come can improve the organization. I'm warming to the idea of breaking up "the path of descent" and splitting it into two example sections, rather than have it as a monolithic example section. But I may keep things the way they are if the flow is broken too much. These reorganizations are always tricky but ultimately important.


[BACKLOG-40165] Introduce SMB VFS support

:x: Build failed in 13m 57s
Build command:
mvn clean verify -B -e -Daudit -amd -Djs.no.sandbox -pl core,engine

:ok_hand: All tests passed!
Tests run: 1908, Failures: 0, Skipped: 1    Test Results

:information_source:  This is an automatic message

:x: Build failed in 13m 38s
Build command:
mvn clean verify -B -e -Daudit -amd -Djs.no.sandbox -pl core,engine

:ok_hand: All tests passed!
Tests run: 1527, Failures: 0, Skipped: 1    Test Results

:information_source:  This is an automatic message

:x: Build failed in 13m 50s
Build command:
mvn clean verify -B -e -Daudit -amd -Djs.no.sandbox -pl core,engine

:ok_hand: All tests passed!
Tests run: 1527, Failures: 0, Skipped: 1    Test Results

:information_source:  This is an automatic message

:x: Build failed in 18m 58s
Build command:
mvn clean verify -B -e -Daudit -amd -Djs.no.sandbox -pl core,engine

:ok_hand: All tests passed!
Tests run: 1624, Failures: 0, Skipped: 1    Test Results

:information_source:  This is an automatic message

:x: Build failed in 16m 20s
Build command:
mvn clean verify -B -e -Daudit -amd -Djs.no.sandbox -pl core,engine

:ok_hand: All tests passed!
Tests run: 1652, Failures: 0, Skipped: 1    Test Results

:information_source:  This is an automatic message

:x: Build failed in 14m 13s
Build command:
mvn clean verify -B -e -Daudit -amd -Djs.no.sandbox -pl core,engine

:ok_hand: All tests passed!
Tests run: 1537, Failures: 0, Skipped: 1    Test Results

:information_source:  This is an automatic message

:x: Build failed in 15m 55s
Build command:
mvn clean verify -B -e -Daudit -amd -Djs.no.sandbox -pl core,engine

:ok_hand: All tests passed!
Tests run: 1705, Failures: 0, Skipped: 1    Test Results

:information_source:  This is an automatic message

:x: Build failed in 4s
Build command:
mvn clean verify -B -e -Daudit -amd -Djs.no.sandbox

:exclamation: No tests found!
Errors:
Filtered log (click to expand)

Could not find credentials matching jfrog-pentaho-service-cicd

:information_source:  This is an automatic message

:x: Build failed in 16m 39s
Build command:
mvn clean verify -B -e -Daudit -amd -Djs.no.sandbox -pl core,engine

:ok_hand: All tests passed!
Tests run: 1455, Failures: 0, Skipped: 1    Test Results

:information_source:  This is an automatic message

:x: Build failed in 13m 12s
Build command:
mvn clean verify -B -e -Daudit -Djs.no.sandbox -pl core,engine

:ok_hand: All tests passed!
Tests run: 3591, Failures: 0, Skipped: 5    Test Results

:information_source:  This is an automatic message

 Note:

Frogbot also supports Contextual Analysis, Secret Detection, IaC and SAST Vulnerabilities Scanning. This features are included as part of the JFrog Advanced Security package, which isn't enabled on your system.

🐸 JFrog Frogbot

:white_check_mark: Build finished in 27m 15s
Build command:
mvn clean verify -B -e -Daudit -Djs.no.sandbox -pl core,engine

:ok_hand: All tests passed!
Tests run: 3591, Failures: 0, Skipped: 5    Test Results

:information_source:  This is an automatic message

 Note:

Frogbot also supports Contextual Analysis, Secret Detection, IaC and SAST Vulnerabilities Scanning. This features are included as part of the JFrog Advanced Security package, which isn't enabled on your system.

🐸 JFrog Frogbot

:white_check_mark: Build finished in 29m 57s
Build command:
mvn clean verify -B -e -Daudit -Djs.no.sandbox -pl \
core,engine,plugins/file-open-save-new/core

:ok_hand: All tests passed!
Tests run: 3629, Failures: 0, Skipped: 5    Test Results

:information_source:  This is an automatic message


Providing filters to Connection.get_report results in JSON_PARSER_ERROR

Issue
When providing a list of filters to Connection.get_report, the response from SalesForce is:
[{u'errorCode': u'JSON_PARSER_ERROR', u'message': u'The request body is either invalid or incomplete.'}]

Note: this has nothing to do with the filters that are supplied, see below.
Reproduce
Make a call to Connection.get_report, with a list of filters, for example:
filter = {
                'column': 'AMS_Order__c.Name',
                'operator': 'equals',
                'value': 'ORD-1'
                }

filters = [filter]

connection = Connection(username, password, security_token)
connection.get_report('my-report-id', filters)

In order to verify that this has nothing to do with the filters, I commented out the lines in which the filters are appended to the metadata and the error persists.
Cause
I believe that this is due to the retrieval of the report metadata, to which the supplied filters are appended.
Currently this is done by appending /describe to the report URL, however at this point the URL already has the  ?includeDetails={}, which appears to result in a different (or invalid?) metadata object to be passed back. When this metadata is appended to and included in the POST request, we get the above error.
Altering the URL that is passed to _get_metadata so that it stops before the includeDetails parameter seems to fix this.

The format of report filters can be seen here; perhaps this has changed recently.

Finally got this! This package is really useful but this change (https://github.com/cghall/force-retrieve/pull/4!) is not in pypi, I had to fixed this bug myself. Please can you include this change in pypi? I think everybody would appreciate it. Thank you.


[Coverity CID :203483]Control flow issues in /subsys/net/lib/conn_mgr/events_handler.c

Static code scan issues seen in File: /subsys/net/lib/conn_mgr/events_handler.c
Category: Control flow issues
Function: conn_mgr_ipv4_events_handler
Component: Networking
CID: 203483
Please fix or provide comments to square it off in coverity in the link: https://scan9.coverity.com/reports.htm#v32951/p12996

@tbursztyka can you check this one, looks like the bits are wrongly checked in the code.


latency of Storm over Gearpump on YARN application is extremely high

Have you looked into this? storm module problem?

It doesn't happen on stand-alone Gearpump so I don't think it's related to storm module.

But looks like you only use one executor, it doesn't have much difference with standalone mode.

Can you reproduce this everytime?

yes, every time

Can you grab the metrics rest reply? Do you have a environement we can access?

What about SOL in Yarn mode?

The rest reply is consistent with that on the dashboard. Sorry, my environment is fragile (check #1384). Other applications are working fine although I've not tried all of them.

thanks to the findings of @clockfly, the root cause is that the 10 spout tasks sleep for 0.1s every one message and block the maximum 8 threads from thread pool. #1795 will allow users to configure a dedicated thread for a blocking-io task and we need to add documentation for this.

this is fixed in #1795


helm: Create cilium IngressClass

Description
Some environments might already have another ingress controllers such as
nginx, we need to create dedicated IngressClass for cilium, otherwise
IngressClass webhook validation might fail.
Signed-off-by: Tam Mach<EMAIL_ADDRESS>

Marked as ready to merge, feel free to let me know if you think otherwise.


payment plan

Hi, first offlove the bolt app.nice work
I seem to be stcuk on the 50 plan when i want to downgrade to the 20. Please fix
also I've added a few coupons for 30% off that were valid but did not seem to be applied, which sucks.
JP

Hi @jpstones,
Please reach out to<EMAIL_ADDRESS>with your account information for assistance with downgrading your plan.


Feat/create a controller for get all comment for specific ref

Before submitting your PR for review

Run npm run lint to find errors in code syntax/format
Run npm run lint:fix to fix all auto-fixable errors in source code and auto-format with prettier
Ensure you fix any linting errors displayed after running any of the above commands

What does this PR do?
The PR get the all the comments for a specific reference user.
Summarise the main tasks handled in the pull request
GET request Endpoint: GET /comments/refs/:id
description of Task to be completed?
Describe (in detail) what the task completed in the pull request does as per the relevant task
How should this be manually tested?
Goto: localhost:4000/comments/refs/:id
Give bullet point instructions on how to setup the code and test it manually (Assume no prior experience on JS or code)
Install an app
Any background context you want to provide?
No
Any pertinent information that should be considered
The user is needed to get all the comments related to the specific user.
What is the link to the issue on Github?
Issue #53
Questions:
If something is unclear or you want some questions to be addressed by your peers, mention them here

Kindly review the code, user which is the comment owner should be populated from the comments model. @Alao-Abiodun


Remove Client Hints flag only works on the first request

OS/Platform
Windows
Installed
https://ungoogled-software.github.io/ungoogled-chromium-binaries/
Version
131
Have you tested that this is not an upstream issue or an issue with your configuration?

[ ] I have tried reproducing this issue in Chrome and it could not be reproduced there
[ ] I have tried reproducing this issue in vanilla Chromium and it could not be reproduced there
[ ] I have tried reproducing this issue in ungoogled-chromium with a new and empty profile using --user-data-dir command line argument and it could not be reproduced there

Description
Browser sends sec-ch-ua headers even if the #remove-client-hints flag enabled
How to Reproduce?

Enable #remove-client-hints flag
Open any site that returns request headers
Make sure that the sec-ch-ua headers have not been sent
Send the same request to the site in devtools console using fetch
Get the sec-ch-ua headers in the response

Or just open any other site and check the network tab in devtools
Actual behaviour
Browser sends sec-ch-ua headers even if the #remove-client-hints flag enabled
Expected behaviour
Browser doesn't send sec-ch-ua headers even if the #remove-client-hints flag enabled
Relevant log output
No response
Additional context

It seems that fetches from the dev tools get the hints from a different section.  I'll start working on a new PR to update how that's handled.

@Bosnier It would be great if you could verify the fix with the next release.

Everything works fine. Thanks


Git repository is unreachable due to HTTPS certificate common name error

The Git repository is unreachable due to an error in the HTTPS certificate (or because the URL is outdated). Example in Firefox 62:

The URL https://gitlab.daplie.com/coolaj86/json2yaml does not cause this error to appear, but the repository seems to be private as it requires the user to sign in to view it.

I have updated the URL: https://git.coolaj86.com/coolaj86/json2yaml.js
Due to my experiences with hosting both on Github and then by mixing business and personal, I will now permanently host all that I do on my own domain (using gitea) so that I'm not subject to the whims of others any longer.


config file with yml extenstion not working

cli does not recognize yml extension (fing.yml)

fixed in fbb6ece


Failed to load css resources

I am trying to install and run an nbextension i created on binder to allow users to try out its functionality. I have been able to install the nbextension, but not of the css files are able to load. I get the following errors:

Does anyone have any idea how I could fix this?
My repository can be found at: https://github.com/uclixnjupyternbaccessibility/notebook-examples
My binder can be found at: https://mybinder.org/v2/gh/uclixnjupyternbaccessibility/notebook-examples/master
Thanks!

I have the same issue.
It arises in the Shiny app that's located inside the 'Shiny app' folder.
https://mybinder.org/v2/gh/pablobernabeu/Modality-exclusivity-norms-747-Dutch-English-replication/master?urlpath=rstudio

Do you know what generates the links for your extension?
I started the binder link you provided and this is the URL that is being loaded and gives 404:
https://hub.gke.mybinder.org/user/nbextensions/accessibility_toolbar/spell_checker/spellchecker.css?v=20190923140557
It should be something like:
https://hub.gke.mybinder.org/user/uclixnjupyternb-tebook-examples-ztsimprz/nbextensions/accessibility_toolbar/spell_checker/spellchecker.css?v=20190923140557
I suspect that somewhere the links are generated without taking into account that the notebook server is running as part of a JupyterHub.

Hi :wave: This is an old issue which doesn't sound like a BinderHub bug so I'm closing it. If you have more questions please use the Jupyter community forum https://discourse.jupyter.org/.


WIP: Fix issues on Windows and add CI testing

Afaik Windows was not a supported platform before, at least it was not in the supports or in the readme.
So super interesting that it worked before, but I suppose we will have to exclude some of the tests for Windows as test with a uid will never pass I think. Maybe we can try replacing that with a SID, although I am not sure if you are allowed to chose your own SID. I thought Windows always generated that.

In the latest release from PR #467 I updated the CI pipeline and added windows but it failed due to some more linux specific settings in code. Looks to be more work that will need to go into supporting windows then just adding it to CI workflow.


Add tests with absolute minimum code change

Hello! Thanks for creating this repository and making it public!
In light of https://github.com/actions/cache/issues/810 being open long-term, we'd like to move over to using this action. I am a Go developer and would like to harden this repo's code first. I thought I'd start by adding test coverage for the code's existing state, and after that exists, I might follow up with a second PR further hardening the code.
If that seems cool with you, it would be awesome if you'd consider this PR. Please let me know if there's anything you'd like me to change to make it better, I'd be happy to do that.
Thanks in advance! 😄 ❤

@tyrannosaurus-becks sorry I'm not a maintainer. At the moment, I think @amendoa is the only maintainer.

Same here @tyrannosaurus-becks, not a maintainer anymore.

Closing this since this repo doesn't appear to be maintained.


Modifying the LevelGraph data at runtime

Hi,
I would like to ask whether it is possible to manipulate the data for the level graph just before generating the dungeon.
My specific case: I want to be able to select a LevelGraph and a RoomTemplateSet via code just before generating a dungeon. The rationale is that the player will decide whether to generate a "long" or "short" dungeon (represented by different level graphs) and which biome (let's say "desert", "ice", "jungle", etc - represented by different room template sets).
I have been able to do both of the above by simply accessing the DungeonGenerator object and setting my desired values at runtime, but I ran into a problem with different biomes. All works perfectly well for normal rooms, but I have a spawn room in my level graphs which uses a room-specific template - so I need to set the template for that room as well, otherwise it will not match the biome.
I found that I would need to access the RoomBase children of the LevelGraph I am using (and I found which room to actually modify), but from what I can see that class only has getters and no visible way to actually set something. Would be grateful if you can correct me here :)
Of course what I can theoretically do is simply forget setting the biomes on the room template level and prepare separate level graphs for each biome. The issue is that then I would need a lot more level graphs (number of size options multiplied by number of biomes) so if possible I would prefer to avoid it.

Hello,
do you by any chance have the PRO version of the plugin? Because this whole scenario is quite simple there as you can implement custom input tasks. With them, you no longer have to prepare (assign) your room templates at design time. Instead, you can use the level graph only for the graph structure and then based on individual room types you implement a method that picks the correct room templates. So if you have a variable that indicates the current biome, you can just add an if statement that picks the correct spawn room for that biome.
If you don't have the PRO version, you can probably continue with what you're trying. If you found the correct RoomBase class, you should be able to just cast it to Room and access the room templates there. The RoomBase class is just the common ancestor for all the rooms (you can have custom room classes in the PRO version) and the concrete implementation in the free version is the Room class.
Let me know if this helps.


ValueError: Please call lr_find first.

After updating ktrain I get "ValueError: Please call lr_find first.".

As noted in the  installation instructions, there is a bug in TensorFlow 2.2 and TensorFlow 2.3 that causes the learning-rate-finder to keep running even after loss has diverged.  Google has fixed this in TensorFlow 2.4.   But, this means that, in TF 2.3.1 (current version of TF), you should use max_epochs argument with lr_find.
In the latest version of ktrain, if running lr_find without the max_epochs argument, the lr_find  method prints a warning about this and  outputs nothing.
Have you suppressed warnings from ktrain to cause the warning to not appear?
The warning should probably be changed to a raised exception to avoid this, and I will change this.

Thanks Arun, I indeed suppressed warnings, therefore didn't see the message.  Changing this to exception would've been better for me.
I am now re-running with learner.lr_find(max_epochs=1024), but the behavior is still not the same (while using the same exact data).
With ktrain '0.3.1' I would get a lr_find convergence after just a few epochs:
simulating training for different learning rates... this may take a few moments...
Epoch 1/1024
6710/6710 [==============================] - 83s 12ms/step - loss: 0.6805 - acc: 0.5580
Epoch 2/1024
6710/6710 [==============================] - 77s 11ms/step - loss: 0.6774 - acc: 0.5578
Epoch 3/1024
6710/6710 [==============================] - 77s 11ms/step - loss: 0.6547 - acc: 0.6300
Epoch 4/1024
6710/6710 [==============================] - 74s 11ms/step - loss: 0.3294 - acc: 0.9411
Epoch 5/1024
6710/6710 [==============================] - 72s 11ms/step - loss: 0.0151 - acc: 0.9978
Epoch 6/1024
6656/6710 [============================>.] - ETA: 0s - loss: 0.0124 - acc: 0.9982
done.
Now running ktrain '0.21.4' - I can't get this to converge even after 100+ epochs.  Is there a way for me to get this to work as in the older version?
learner.lr_find(max_epochs=1024)
simulating training for different learning rates... this may take a few moments...
Epoch 1/1024
210/210 [==============================] - 22s 106ms/step - loss: 0.6845 - accuracy: 0.5495

Epoch 116/1024
210/210 [==============================] - 22s 107ms/step - loss: 0.6641 - accuracy: 0.5952
Epoch 117/1024
210/210 [==============================] - 22s 106ms/step - loss: 0.6641 - accuracy: 0.6043
Epoch 118/1024
210/210 [==============================] - 23s 108ms/step - loss: 0.6637 - accuracy: 0.6049
Epoch 119/1024
148/210 [====================>.........] - ETA: 6s - loss: 0.6642 - accuracy: 0.6096

As mentioned in my original answer, this is a bug in TensorFlow 2.2 and 2.3, which causes the learning rate finder to run for as many as epochs you specify and ignore the divergence condition.  Since, you specified 1024 epochs, it'll take forever to run .  If you use the max_epochs argument, you should set it to something smaller like 5 epochs in your case.
This issue will be fixed by Google in TenorFlow 2.4, but TF 2.4 has not been released yet.  If you want it to work like before, you can temporarily downgrade TensorFlow to 2.1.0 until TensorFlow 2.4 is released.
Once TensorFlow 2.4 is released,  lr_find will stop at the appropriate moment again.

Thanks Arun.  I will use it with a small number of epochs

This will be changed to a raised Exception in the next release.


Remove project level tests

Purpose
$subject
Fixes #
Approach

Describe how you are implementing the solutions along with the design details.

Samples

Provide high-level details about the samples related to this feature.

Remarks

List any other known issues, related PRs, TODO items, or any other notes related to the PR.

Check List

[ ] Read the Contributing Guide
[ ] Required Balo version update
[ ] Updated Change Log
[ ] Checked Tooling Support (#)
[ ] Added necessary tests

[ ] Unit Tests
[ ] Spec Conformance Tests
[ ] Integration Tests
[ ] Ballerina By Example Tests

[ ] Increased Test Coverage
[ ] Added necessary documentation

[ ] API documentation
[ ] Module documentation in Module.md files
[ ] Ballerina By Examples

Codecov Report

Merging #18859 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #18859   +/-   ##
=======================================
  Coverage   14.95%   14.95%
=======================================
  Files          47       47
  Lines        1230     1230
  Branches      187      187
=======================================
  Hits          184      184
  Misses       1033     1033
  Partials       13       13

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 63a0939...e523355. Read the comment docs.


Tutorial adding command

Codecov Report

Merging #1 (56769b9) into master (fd87722) will decrease coverage by 2.06%.
The diff coverage is 41.97%.

@@             Coverage Diff              @@
##             master       #1      +/-   ##
============================================
- Coverage     72.15%   70.09%   -2.07%
- Complexity      399      407       +8
============================================
  Files            70       73       +3
  Lines          1232     1304      +72
  Branches        125      135      +10
============================================
+ Hits            889      914      +25
- Misses          311      351      +40
- Partials         32       39       +7

Impacted Files
Coverage Δ

.../java/seedu/address/logic/commands/AddCommand.java
92.30% <0.00%> (-7.70%)
:arrow_down:

...va/seedu/address/logic/commands/RemarkCommand.java
0.00% <0.00%> (ø)

.../seedu/address/logic/parser/AddressBookParser.java
88.88% <0.00%> (-11.12%)
:arrow_down:

...eedu/address/logic/parser/RemarkCommandParser.java
0.00% <0.00%> (ø)

.../java/seedu/address/model/util/SampleDataUtil.java
20.00% <ø> (ø)

src/main/java/seedu/address/ui/PersonCard.java
0.00% <0.00%> (ø)

...in/java/seedu/address/logic/parser/ParserUtil.java
92.68% <60.00%> (-4.54%)
:arrow_down:

...c/main/java/seedu/address/model/person/Remark.java
70.00% <70.00%> (ø)

.../java/seedu/address/storage/JsonAdaptedPerson.java
96.07% <75.00%> (-3.93%)
:arrow_down:

...c/main/java/seedu/address/model/person/Person.java
95.74% <77.77%> (-1.88%)
:arrow_down:

... and 4 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more