Can't gather facts when running seperate Task.

TASK [_gather_facts : Gather facts] ******************************************************************************
11:59:24 I p=29093 u=root | : TASK [_gather_facts : Gather facts] ******************************************************************************
fatal: [tbi_client01]: FAILED! => {"changed": false, "msg": "Unsupported parameters for (setup) module: _ansible_shell_executable Supported parameters include: fact_path,filter,gather_subset,gather_timeout"}
11:59:24 E p=29093 u=root | : fatal: [tbi_client01]: FAILED! => {"changed": false, "msg": "Unsupported parameters for (setup) module: _ansible_shell_executable Supported parameters include: fact_path,filter,gather_subset,gather_timeout"}
task looks like this:

name: Gather facts
action: setup

while gather_facts: no is set in my playbook

Hi Max,
Can you include the output of "ansible --version", the OS you're on and
the OS of the target machine. This seems to work for me locally.
On Wed, Mar 07, 2018 at 03:52:45AM -0800, maxhenze wrote:

TASK [_gather_facts : Gather facts]

11:59:24 I p=29093 u=root | : TASK [_gather_facts : Gather facts]

fatal: [tbi_client01]: FAILED! => {"changed": false, "msg": "Unsupported
parameters for (setup) module: _ansible_shell_executable Supported parameters
include: fact_path,filter,gather_subset,gather_timeout"}
11:59:24 E p=29093 u=root | : fatal: [tbi_client01]: FAILED! => {"changed":
false, "msg": "Unsupported parameters for (setup) module:
_ansible_shell_executable Supported parameters include:
fact_path,filter,gather_subset,gather_timeout"}
task looks like this:
• name: Gather facts
action: setup
while gather_facts: no is set in my playbook
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

Target:
NAME="openSUSE Leap"
VERSION="42.3"
ID=opensuse
ID_LIKE="suse"
VERSION_ID="42.3"
PRETTY_NAME="openSUSE Leap 42.3"
ANSI_COLOR="0;32"
CPE_NAME="cpe:/o:opensuse:leap:42.3"
BUG_REPORT_URL="https://bugs.opensuse.org"
HOME_URL="https://www.opensuse.org/"
Machine running ansible:
NAME="openSUSE Tumbleweed"
VERSION="20171010"
ID=opensuse
ID_LIKE="suse"
VERSION_ID="20171010"
PRETTY_NAME="openSUSE Tumbleweed"
ANSI_COLOR="0;32"
CPE_NAME="cpe:/o:opensuse:tumbleweed:20171010"
BUG_REPORT_URL="https://bugs.opensuse.org"
HOME_URL="https://www.opensuse.org/"
ansible --version
ansible <IP_ADDRESS>
config file = /RULES/siam/ansible/ansible.cfg
configured module search path = [u'/siam/ansible/plugins/modules', u'/usr/share/ansible', u'/usr/lib/python2.7/site-packages/ara/plugins/modules']
ansible python module location = /usr/lib/python2.7/site-packages/ansible
executable location = /usr/bin/ansible
python version = 2.7.14 (default, Oct 12 2017, 15:50:02) [GCC]

Can you share the command line you used to run it? Any ansible*_executable variables are handled specially by the modules, but there is another code path where they aren't, but I can't figure out how it gets triggered :)

Since ansible can't handle ssh-keys from variables yet i had to come up with some sort of  work around for my problem.
I decrypt my ssh key from my gpg encrypted passwordstore and store it during runtime in a temporary file which is removed after my run has finished
Playbook: test.yml

hosts: ToBeInstalled
roles:

testing
gather_facts: no

Role testing:

name: Decrypt SSH-Keys
include_role:
name: _add_ssh_key

name: Gather Facts
include_role:
name: _gather_facts

Role _decrypt_ssh_key:

name: decrypt password to local key
copy:
content: "{{ lookup('passwordstore', 'ssh-keys/' + inventory_hostname + '_rsa returnall=true') }}"
dest: "{{ playbook_dir }}/tmp/ssh/{{ inventory_hostname }}_rsa"
mode: 0400
delegate_to: localhost

While in my host_vars:
ansible_ssh_private_key_file: /siam/ansible/playbooks/tmp/ssh/tbi_client01_rsa
is set

also - i pressed the wrong button while commenting

At what point does the setup module get called in this structure? Is it from within another role?

Whoops, now I understand :)

I'm going to have to read the code line-by-line later to figure this out, I've reproduced your playbook structure and cannot trigger the problem with your exact version of Ansible. We're still missing something. Do you have anything magical in ansible.cfg?

ok - i stripped down my config to only use your strategy plugin + directory informations

no difference

from what i get the module_args get lost as soon as i m running with mitogen, when mitogen is not enabled default module_args are passed to the setup task:
fatal: [tbi_client01]: FAILED! => {
"changed": false,
"invocation": {
"module_args": {}
},
w/o mitogen:
"invocation": {"module_args": {"filter": "*", "gather_subset": ["all"], "fact_path": "/etc/ansible/facts.d", "gather_timeout": 10}}

Also i noticed theses beauties:
15:17:10 W mitogen: get_module_source('time'): cannot find source
15:17:10 W mitogen: get_module_source('operator'): cannot find source
15:17:10 W mitogen: get_module_source('_locale'): cannot find source
15:17:10 W mitogen: get_module_source('grp'): cannot find source
15:17:10 W mitogen: get_module_source('datetime'): cannot find source
15:17:10 W mitogen: get_module_source('syslog'): cannot find source
15:17:10 W mitogen: get_module_source('itertools'): cannot find source
15:17:10 W mitogen: get_module_source('select'): cannot find source
15:17:10 W mitogen: get_module_source('_random'): cannot find source
15:17:10 W mitogen: get_module_source('binascii'): cannot find source
15:17:10 W mitogen: get_module_source('math'): cannot find source
15:17:10 W mitogen: get_module_source('fcntl'): cannot find source
15:17:10 W mitogen: get_module_source('cStringIO'): cannot find source
15:17:10 W mitogen: get_module_source('cPickle'): cannot find source
15:17:10 W mitogen: get_module_source('_collections'): cannot find source
15:17:10 W mitogen: get_module_source('zlib'): cannot find source
15:17:10 W mitogen: get_module_source('bz2'): cannot find source
15:17:10 W mitogen: get_module_source('_hashlib'): cannot find source
15:17:10 W mitogen: get_module_source('_json'): cannot find source
15:17:10 W mitogen: get_module_source('_io'): cannot find source
15:17:10 W mitogen: get_module_source('strop'): cannot find source
15:17:10 W mitogen: get_module_source('_functools'): cannot find source
15:17:10 W mitogen: get_module_source('_heapq'): cannot find source
15:17:10 W mitogen: get_module_source('_struct'): cannot find source
any correlation?

Hi Max,
The most recent GitHub should not log those messages any more.
Thanks so much for hunting down the module_args hint, this is amazingly
helpful.
I just pushed one quick change that /might/ help, where Mitogen did
something subtly different and would have discarded some objects it should
keep. I don't think it'll fix your problem, but might be worth a retry just
in case
On 7 March 2018 at 20:04, maxhenze<EMAIL_ADDRESS>wrote:

Also i noticed theses beauties:
15:17:10 W mitogen: get_module_source('time'): cannot find source
15:17:10 W mitogen: get_module_source('operator'): cannot find source
15:17:10 W mitogen: get_module_source('_locale'): cannot find source
15:17:10 W mitogen: get_module_source('grp'): cannot find source
15:17:10 W mitogen: get_module_source('datetime'): cannot find source
15:17:10 W mitogen: get_module_source('syslog'): cannot find source
15:17:10 W mitogen: get_module_source('itertools'): cannot find source
15:17:10 W mitogen: get_module_source('select'): cannot find source
15:17:10 W mitogen: get_module_source('_random'): cannot find source
15:17:10 W mitogen: get_module_source('binascii'): cannot find source
15:17:10 W mitogen: get_module_source('math'): cannot find source
15:17:10 W mitogen: get_module_source('fcntl'): cannot find source
15:17:10 W mitogen: get_module_source('cStringIO'): cannot find source
15:17:10 W mitogen: get_module_source('cPickle'): cannot find source
15:17:10 W mitogen: get_module_source('_collections'): cannot find source
15:17:10 W mitogen: get_module_source('zlib'): cannot find source
15:17:10 W mitogen: get_module_source('bz2'): cannot find source
15:17:10 W mitogen: get_module_source('_hashlib'): cannot find source
15:17:10 W mitogen: get_module_source('_json'): cannot find source
15:17:10 W mitogen: get_module_source('_io'): cannot find source
15:17:10 W mitogen: get_module_source('strop'): cannot find source
15:17:10 W mitogen: get_module_source('_functools'): cannot find source
15:17:10 W mitogen: get_module_source('_heapq'): cannot find source
15:17:10 W mitogen: get_module_source('_struct'): cannot find source
any correlation?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/dw/mitogen/issues/109#issuecomment-371152335, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAAJCy7ZNfGtyTntLrSPXGQDNsFYvYAIks5tb-xrgaJpZM4SgUSF
.

Would it be possible for you to run the non-Mitogen case with
ANSIBLE_KEEP_REMOTE_FILES=1, then find the run of setup.py in the target
host's ~/.ansible/tmp, zip that whole dir up and send it to me?
Ansible's argument handling rules are a bit "fluid", there was quite some
guesswork involved in the initial implementation work
On 7 March 2018 at 20:06, David Wilson<EMAIL_ADDRESS>wrote:

Hi Max,
The most recent GitHub should not log those messages any more.
Thanks so much for hunting down the module_args hint, this is amazingly
helpful.
I just pushed one quick change that /might/ help, where Mitogen did
something subtly different and would have discarded some objects it should
keep. I don't think it'll fix your problem, but might be worth a retry just
in case
On 7 March 2018 at 20:04, maxhenze<EMAIL_ADDRESS>wrote:

Also i noticed theses beauties:
15:17:10 W mitogen: get_module_source('time'): cannot find source
15:17:10 W mitogen: get_module_source('operator'): cannot find source
15:17:10 W mitogen: get_module_source('_locale'): cannot find source
15:17:10 W mitogen: get_module_source('grp'): cannot find source
15:17:10 W mitogen: get_module_source('datetime'): cannot find source
15:17:10 W mitogen: get_module_source('syslog'): cannot find source
15:17:10 W mitogen: get_module_source('itertools'): cannot find source
15:17:10 W mitogen: get_module_source('select'): cannot find source
15:17:10 W mitogen: get_module_source('_random'): cannot find source
15:17:10 W mitogen: get_module_source('binascii'): cannot find source
15:17:10 W mitogen: get_module_source('math'): cannot find source
15:17:10 W mitogen: get_module_source('fcntl'): cannot find source
15:17:10 W mitogen: get_module_source('cStringIO'): cannot find source
15:17:10 W mitogen: get_module_source('cPickle'): cannot find source
15:17:10 W mitogen: get_module_source('_collections'): cannot find source
15:17:10 W mitogen: get_module_source('zlib'): cannot find source
15:17:10 W mitogen: get_module_source('bz2'): cannot find source
15:17:10 W mitogen: get_module_source('_hashlib'): cannot find source
15:17:10 W mitogen: get_module_source('_json'): cannot find source
15:17:10 W mitogen: get_module_source('_io'): cannot find source
15:17:10 W mitogen: get_module_source('strop'): cannot find source
15:17:10 W mitogen: get_module_source('_functools'): cannot find source
15:17:10 W mitogen: get_module_source('_heapq'): cannot find source
15:17:10 W mitogen: get_module_source('_struct'): cannot find source
any correlation?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/dw/mitogen/issues/109#issuecomment-371152335, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAAJCy7ZNfGtyTntLrSPXGQDNsFYvYAIks5tb-xrgaJpZM4SgUSF
.

newest version didn't fix the problem, but i tried several things and got something quite interesting:
once i replaced my role
- name: Gather facts
action: setup
with this:
- name: Gather facts
setup:
filter: "*"
gather_subset: ["all"]
fact_path: /etc/ansible/facts.d
gather_timeout: 11
and suddenly module_args appeared:
fatal: [tbi_client01]: FAILED! => {
"changed": false,
"invocation": {
"module_args": {
"fact_path": "/etc/ansible/facts.d",
"filter": "*",
"gather_subset": [
"all"
],
"gather_timeout": 11
}
},
"msg": "Unsupported parameters for (setup) module: _ansible_shell_executable Supported parameters include: fact_path,filter,gather_subset,gather_timeout"
}

Hey, is it definitely that exact step in your playbook that triggers the setup module? Some actions sometimes internally trigger it on demand. Does the part where the failure occurs definitely have the name of the task where you run setup appearing above it as the title?

Since module "setup" is even directly mentioned and i dont have any other steps in my stripped down playbook - I'm quite sure.
If you have any idea how to get more in depth data i'd be glad to have a deeper look into it.
14:50:05 E p=30079 u=root | : fatal: [tbi_client01]: FAILED! => {
    "changed": false,
    "invocation": {
        "module_args": {
            "fact_path": "/etc/ansible/facts.d",
            "filter": "*",
            "gather_subset": [
                "all"
            ],
            "gather_timeout": 11
        }
    },
    "msg": "Unsupported parameters for (setup) module: _ansible_shell_executable Supported parameters include: fact_path,filter,gather_subset,gather_timeout"

I had not even thought of that! If you pull the latest extension and run with "-vvvv", this will produce extreme logging, the part that would be useful is any line mentioning call_async(... run_module .. setup )
Sorry, a little overworked the past 2 days ;)

well - thats funny - newest version won't let me reproduce... did you solve by accident? :D

I fixed a bunch of important bugs yesterday, but I can't see how it could possibly be related! Grmbl.
This is actually a worse outcome than finally finding whatever was causing your issue :)
Yesterday I fixed

Modules were getting imported twice in children (can't see how this would fix it)
Tons of new logging (nope)
Implemented _transfer_data() for <2.4 Ansibles (nope)

And then a9c6c139b407d28ad4522611648b5b27442faa54 .. did your target machine have Ansible installed on it? That might somehow be an explanation

can confirm ansible on target machine
i removed ansible from the target machine - setup module still works

Ahah! Yes, and I bet the version of Ansible on the target was slightly younger than the one on the host :)   You can keep Ansible on the target machine now, it's no problem, that's fully protected against since yesterday.
Feel free to close this bug. I'm happy we've found the culprit :)
/cc #114

since i m able to run the whole of my playbook by now - i m thrilled to close this issue :)
thank you for your awesome work
i will report as soon as i dig up something new

Just one final note.. I am always interested in more timing information.. latency of network, CPUs of target boxes, how much playbook time is spent in big apt-gets and suchlike, and finally before/after of /usr/bin/time output. Thanks again

This is just from my Playbook doing nothing since nothing as changed. - Will update with Full Playbook runtime.
Before:
Playbook finished: Thu Mar  8 15:47:58 2018, 87 total tasks.  0:01:55 elapsed.

real    2m30.448s
user    0m45.182s
sys     0m19.054s

After:
Playbook finished: Thu Mar  8 15:53:04 2018, 87 total tasks.  0:01:02 elapsed.

real    1m26.091s
user    0m26.613s
sys     0m4.449s

Not exactly spectacular, but not bad either :)  Is this on a low latency network?

it is - both machines currently run on a dedicated switch - also i do a lot of package installation with this - and zypper isn't particularly fast when it comes to repo communication - so i guess  thats what killing the time improvements.


[BUG] Failed to install on RPi3+

Trying to install with
npm install -g homebridge-harmony
Getting error:
npm WARN deprecated<EMAIL_ADDRESS>request has been deprecated, see https://github.com/request/request/issues/3142
npm WARN deprecated<EMAIL_ADDRESS>request-promise has been deprecated because it extends the now deprecated request package, see https://github.com/request/request/issues/3142
npm WARN deprecated<EMAIL_ADDRESS>this library is no longer supported

<EMAIL_ADDRESS>install /usr/local/lib/node_modules/homebridge-harmony/node_modules/bufferutil
node-gyp-build

gyp WARN EACCES current user ("nobody") does not have permission to access the dev dir "/root/.cache/node-gyp/14.13.0"
gyp WARN EACCES attempting to reinstall using temporary dev dir "/usr/local/lib/node_modules/homebridge-harmony/node_modules/bufferutil/.node-gyp"
gyp WARN install got an error, rolling back install
gyp WARN install got an error, rolling back install
gyp ERR! configure error
gyp ERR! stack Error: EACCES: permission denied, mkdir '/usr/local/lib/node_modules/homebridge-harmony/node_modules/bufferutil/.node-gyp'
gyp ERR! System Linux 5.4.51-v7+
gyp ERR! command "/usr/bin/node" "/usr/local/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js" "rebuild"
gyp ERR! cwd /usr/local/lib/node_modules/homebridge-harmony/node_modules/bufferutil
gyp ERR! node -v v14.13.0
gyp ERR! node-gyp -v v5.1.0
gyp ERR! not ok
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR<EMAIL_ADDRESS>install: node-gyp-build
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>install script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
npm ERR!
Read about deleting ~/.node-gyp directory or ~/.npmrc file but i have neither.
Any ideas?
Thanks!

Hi,
Are you in a docker environment ? See : https://stackoverflow.com/questions/44633419/no-access-permission-error-with-npm-global-install-on-docker-image and https://github.com/npm/npm/issues/3849.
Maybe try setting npm user to anything else (maybe not root however) :
npm -g config set user root

I had the same problem, see here #309
https://github.com/nicoduj/homebridge-harmony/issues/309

I had the same problem, see here #309
#309

Worked just fine!
Thanks a lot!


Consolidate storybook colormode change options to just the dayScheme

Storybook change: Consolidate storybook colormode change options to just the dayScheme
Closes # https://github.com/github/primer/issues/325
Screenshots
Please provide before/after screenshots for any visual changes
Merge checklist

[ ] Added/updated tests
[ ] Added/updated documentation
[x] Tested in Chrome
[ ] Tested in Firefox
[ ] Tested in Safari
[ ] Tested in Edge

Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.

This is always nice to see ❤

Looks like the side-by-side feature that @langermank implemented in https://github.com/primer/react/pull/1479 makes having three dropdowns necessary. I vote that we close PR in favor of https://github.com/primer/react/pull/1479 because viewing two themes side-by-side in Storybook seems handy 😄

yep! makes sense. Closing this.


Use f-strings

It requires Python 3.6, but it would make a bunch of code look a lot nicer.

It requires Python 3.6, but it would make a bunch of code look a lot nicer.

 For example, that particular line could be replaced by f"string{number}string".
You can do a lot of other formatting, like aligning numbers and using repr, and you can get the same effects a few different ways using str.format. The documentations on format string syntax is the primary source, if you like very-detailed explanations.


Pop gesture not working when there is horizontal scrolling view.

When there is a horizontal scroll view attached to the left edge, the pop gesture will not work because the events are handled by the scroll view's scrolling gesture. Maybe u want to add the following code:

(BOOL)gestureRecognizer:(UIGestureRecognizer *)gestureRecognizer shouldBeRequiredToFailByGestureRecognizer:(UIGestureRecognizer *)otherGestureRecognizer {
return YES;
}

Also, an option to turn this feature on/off will be nice! :)

Good idea! Could you create a pull request with implementation?

I create a pull request to fix this issue. Please check it when you have time.

Wow awesome!!! Is this fixed?? How can I do it on AHKNavigationController?

@minchaej The PR was never reviewed but it looks like there is a closed PR for it.


[feat] add front-matter loading lib, or update to markdown editor

Look into:
https://github.com/dworthen/js-yaml-front-matter

This should be added with #60.
Closing in favor.


Release version with

Please :)

Solved by #120 and subsequent commits. Artifacts under way to Maven Central.


WIP: Add bazel build to the travis presubmit.

This change is

Closing this, we're not doing this.


Remember directory when installing templates file

Every single time when I install new export templates I have to manually navigate to the downloads directory. Copying the path isn't always easily accessible due to some Windows weirdness.
With this PR the "Install From File" option will automatically open the previously used directory.

Thanks!

Cherry-picked for 4.0.3.


Question: Support KMP and Compose Multiplatform for Client SDK?

Hello!
Thank you for this amazing project!
Are there any plans on supporting KMP and Compose Multiplatform for the client SDK?
I believe your android library is already clean enough to make a smooth transition, at least for android, desktop and iOS targets.
There is already a WebRTC library for KMP (Currently supports Android, iOS and JS), which works really well, I'm wondering if there's a way to integrate with your project which seems very promising in terms of performance and stability.

Hi there, thank you for the kind words!
KMP is not currently on the roadmap. we already support a wide range of SDKs for native platforms as well as cross-platform libraries such as Flutter, React Native, and Unity.

Thank you for the quick answer, @davidzhao!
I hope in the future KMP will become one of your cross-platform targets since it's quickly gaining popularity.

We'll definitely keep an eye on it! Appreciate you bringing it to our attention.


Create CODE_OF_CONDUCT.md

Reviewer: @kdzwinel

Description:

Because we aren't savages :)
This is just a standard document for addressing internet harassment

Should we add additional / alternative emails to this document?

@jonathanKingston  let's wait with this till we wrap up a broader discussion about which COC we want (and how to put it on all our repos).


Make array_equal also test shape, and add array_equiv for just testing broadcast elements

This is fixed now.


Release v1.2.17

Fixes:

GRD-67664: Data source Group delete
GRD-68799: Remove Delete actions from Exception and Group
GRD-68719: Wrong value type on database export
GRD-68379: Change in Short description for database instance is not exported to Guardium
issue-37: Feature request: Additional information on test definitions
issue-25: Feature request: Additional information from Guardium test results
issue-34: Feature request: Add documentation link to ServiceNow VR and CC modules
issue-33: Feature request: Add active/inactive toggle to Guardium collectors
issue-35: Bug: Last 30 Days report on Guardium Dashboard should only show Guardium generated items
issue-34: Feature request: Use Guardium-12345 notation for non-CVE test definitions

Release v1.2.17


Add staging hunks in Git

SourceTree has this feature, would be great if VS Code had it also.

Changes view > click on elipses on top > stage selected ranges

@isidorn Is it working on version 1.11.11 (Windows)?

I think this disappeared  in latest version, at least I dont see it on windows

@Kamahl19 yes. It is now possible to do this via the command palette (F1)

@isidorn How can I do this? I've tried to add only the selected lines typing 'stage' on the command palette, but I received these options. Am I doing something wrong?

Ah, I got it. Indeed, the vscode I have installed on my machine has the 'Stage Selected Ranges' option, in the first screenshot it is there, hehe. (I figure it out now). But I can only stage the entire hunk not a few lines, as the package Magit in the Emacs editor allows me to do. It will be nice if vscode could do that. Thanks for your help and time @isidorn.

@Matheus-de-Souza the issue you are explaining now is captured in another issue (you can search for it) and it will be fixed in a couple of days

Wish this was easier, like in SourceTree.  I have to select the lines, right click, choose "Command Palette" at the bottom of the menu, then click the first item (Git: Stage Selected Ranges) in the command selection (if it was the last thing you did).  How about just highlight, right click and choose "Git: Stage Selected Ranges" (i.e. put that command on the context menu).  Even that isn't as good as SourceTree, but better.


Feature Request: Mechanism to specify canister cycle balance to simulate low canister balance scenarios

This is primarily to be able to test auto topup mechanisms for canister fleets that we've been working on.
But we imagine it could be used in all other kinds of tests involving cycle balances.
@frederikrothenberger Thoughts?

Hi @saikatdas0790
Yeah, so far support for cycles has been sparse because in the II context we don't really need them. It would make sense to expand it.
Do you just need to set the number of cycles to some specific amount or do you need operations to actually burn cycles?

@frederikrothenberger
Setting is fine for our needs.
Basically test that low canister balances make the topup functions trigger automatically and perform the requisite actions.

Hi @saikatdas0790
Unfortunately, the underlying infrastructure does not allow to easily extend the test-state-machine with a way of setting a specific amount of cycles.
However, we could potentially allow setting the subnet configuration such that instructions / messages, storage, etc. actually have a cycles cost other than 0.
With that it should be possible to write a test that exercises the canister under test in such a way (given the cost of operations can be chosen freely) that it falls below certain limits (i.e. to trigger a top-up or fall below the configured freezing threshold).
Would this also satisfy your requirements?

@saikatdas0790
Ah, that's a good solution too. In that case I'll close this issue. Thanks for the feedback.

I think it's a good idea to add this capability in when the underlying infrastructure is refactored in the future and this becomes easier to implement. The reason is, as a integration test harness, it's a good idea for test-state-machine-client to include any behaviour that lets users tweak replica/canister runtime settings programmatically to simulate/test situations that canisters would run into the mainnet.

The testing teams roadmap has a feature for building a much more configurable / tweakable infrastructure similar to the one currently provided. It will definitely be included there. 🙂


Do we need keep_upright? Why not just lower center of gravity

Would I need a keep_upright function if I instead moved the center of gravity of every body to somewhere lower? We have this explicit function that handles keeping the player upright but I'm not sure if this is the best way? Like, wouldn't things naturally try to balance themselves based on the center of mass of any entity?
#[derive(Component)]
pub struct Upright;

const ROTATION_SPEED: f32 = 0.3; // Adjust this value for faster/slower rotation correction

const ROTATION_THRESHOLD: f32 = 60.0; // Angle in degrees. Adjust based on desired gameplay.

pub fn keep_upright(mut gravity_bound_query: Query<(&mut Rotation, &GravityBound), With<Upright>>) {
    for (mut rotation, gravity_bound) in &mut gravity_bound_query {
        let gravity_force = gravity_bound.gravity_force;
        if gravity_force == Vec3::ZERO {
            continue;
        }

        let gravity_up = -gravity_force.normalize();
        let player_up = rotation.0 * Vec3::Y;

        // Calculate the rotation from the player's up vector to the gravity up vector
        let rotation_angle = player_up.angle_between(gravity_up).to_degrees();

        // If the angle exceeds the threshold, don't try to correct
        if rotation_angle > ROTATION_THRESHOLD {
            continue;
        }

        let rotation_axis = player_up.cross(gravity_up);

        if rotation_axis != Vec3::ZERO {
            let rotation_axis = rotation_axis.normalize();
            let rotation_diff = Quat::from_axis_angle(rotation_axis, rotation_angle.to_radians());

            let target_rotation = rotation_diff * rotation.0;

            // Gradually rotate the player to align with the gravity direction
            rotation.0 = rotation.0.lerp(target_rotation, ROTATION_SPEED);
        }
    }
}

AI:
The script you've shared is a function to keep a game entity (such as a player character) upright relative to a source of gravity in a gameplay style reminiscent of "Super Mario Galaxy". This "Upright" component and the associated system you've written are a valid approach to achieving this. The script basically checks for the difference between the current orientation of the player and the desired orientation based on the gravity direction and then smoothly rotates the player to align with the desired orientation.
Regarding your question about moving the center of gravity to somewhere lower, let's clarify a few things:

Physics vs. Aesthetics: Adjusting the center of gravity of an object affects its physical behavior. For example, a toy with a lower center of gravity is less likely to tip over than one with a higher center. In game physics, shifting the center of gravity lower could make the character or entity more stable. However, simply adjusting the center of gravity won't inherently "correct" the orientation of the player to be upright. That would still require some logic like the one you've provided.

Gameplay Feel: Changing the center of gravity might alter the overall feel of the player's movement. In some cases, this might be desirable as it could give a more "grounded" feel to the character. However, it might also make certain movements or actions feel heavier or more sluggish. It's important to playtest these changes to ensure they provide the desired gameplay experience.

Complexity and Maintainability: Using a dedicated system (like your keep_upright function) to handle player orientation can be beneficial because it centralizes the logic. This can make it easier to tweak, debug, and extend in the future. Adjusting physical properties might give you the desired outcome, but it could introduce unforeseen side effects in other areas of your game.

Performance: Both approaches would have some computational overhead, but in most game scenarios, the difference would likely be negligible. The code you've written should run efficiently for typical numbers of player entities.

In conclusion, while adjusting the center of gravity can influence the physical behavior of your entities in the game, it won't inherently make them align upright with the gravity source. If you want that behavior, a function like the one you've written is still necessary.
However, adjusting the center of gravity could complement your existing solution, potentially making the upright behavior feel more natural. If you're curious, I'd recommend trying both methods (individually and combined) and playtesting to see which provides the desired feel for your game.


[W4.7c][W12-2]Lee Geng Yu

Code is modified to use HashMap<String, String> instead of String[], which originally stored a person's details

@leegengyu
Some comments added. Please take note and close the pull request.


[FLINK-18534][kafka][table] Fix unstable KafkaTableITCase.testKafkaDebeziumChangelogSource

What is the purpose of the change
This fix the unstable test with "Topic 'changelog_topic' already exists" exception.
Brief change log
Currently testKafkaDebeziumChangelogSource is executed multiple times because the super class is Parameterized with different formats. The Kafka cluster has a known issue that the topic cleanup is not guarenteed to take effect immediately.
However, this case only need to be executed once. Thus, we update the test to only execute when it is json format.
Verifying this change
Manually run in my local for hundreds of times.
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (yes / no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
The serializers: (yes / no / don't know)
The runtime per-record code paths (performance sensitive): (yes / no / don't know)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / no / don't know)
The S3 file system connector: (yes / no / don't know)

Documentation

Does this pull request introduce a new feature? (yes / no)
If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

Could you help to review this @leonardBang ?

Hi @leonardBang , I splitted the Kafka changelog source test into a separate class KafkaChangelogTableITCase. We can add other changelog format tests in there in the future.


Docs refer to vn-ki/anime-downloader even though it has moved to anime-dl/anime-downloader

Describe the bug
Docs refer to vn-ki/anime-downloader even though it has moved to anime-dl/anime-downloader
To reproduce
Visible at:
https://anime-downlader.readthedocs.io/en/latest/usage/installation.html and multiple other locations

Doesn't matter since github redirects to the new link.


Is there a way to generate a template object for the provided json schema?

What version of Ajv are you using? Does the issue happen if you use the latest version?
Ajv options object

JSON Schema

Sample data

Your code

Validation result, data AFTER validation, error messages

What results did you expect?
Are you going to resolve the issue?

I think you want this: https://github.com/json-schema-faker/json-schema-faker


Dropdown menu on mobile device not showing completly

How can we reproduce this bug?

go to the http://foundation.zurb.com/sites/docs/dropdown-menu.html
try it on mobile device or use Chrome inspector or whatever you use
go to Vertical section and try to tap on any of the links that have sub directory. On smaller screens you can not see sub menu when you open it, on larger only a part of them shows. The same problem I have on my website

What did you expect to happen?
Wanted to show sub menu
What happened instead?
Unable to see sub menu section
Test case:
http://foundation.zurb.com/sites/docs/dropdown-menu.html

I am having the same problem on my website: [http//www.caamuseum.org]

use the website on a computer screen, select each of the dropdown menu items  at the top of the    page and see the list of items
Now, use the website on a mobile device, and go to the "menu" list on the top right-side of the screen  and click on each of the vertical lines (representing the menu lists)
note that each of the menu lists do not display the last item in the list.

Any update on this issue? Am I the only one having the problems with this? I ask because the same example is still not working on F6 doc pages, and this is a crucial feature.

I have not had any response to my issue.  I am using F5 doc pages.

@Owlbertz is this something you can take a look at?

Yes.

Should be fixed with #8712.
@zlatiborac can you pull this down and test?


Website not generating proper certificate

No idea where to put this.
https://umurmur.net/ errors with a certificate pointing to github.com
GitHub has support for Let's Encrypt now: https://blog.github.com/2018-05-01-github-pages-custom-domains-https/

Updating the umurmur.net DNS records as in the links above should be enough to fix the certificate problem.

Fixed


Arrangement and execution of the meeting for overview of activities performed during development of dynamic systems (issue #908 related)

The goal is to arrange and execute the meeting for overview of activities performed during development of dynamic systems. The following things should be prepared:

[x] scope and schedule of meeting (in one week);

[x] conducting team (in two weeks);

[x] guide or instructions with examples (one week before meeting);

[x] announcement (in Slack and Teams channel) with basic information (conducting persons, date,scope,schedule) (one week before meeting);

[x] exemplary code in Jupyter (link) (one week before meeting).

Meeting has been executed.


datatable with laravel-modules

problem described here
https://github.com/yajra/laravel-datatables/issues/1820
if you can take a look, thanks by advance

here the answer

you need to use the module view namespace as path.
->addColumn('action', 'module::path.to.view')

https://github.com/yajra/laravel-datatables/issues/1820#issuecomment-414026484


Values aren't correct for Services

Hello,
The value "Unhandled" is wrong because Widgets use this calculation:
Unhandled = Critical - (Acknowledge + Downtimes + Problem_on_host)
Problem is a service can be in "donwtime" and "acknowledged" at the same time, so you can have negative value.

Please use the same calculation used at the right corner

Last patch (66e30e2) was tested on a customer platform, it's OK

Hi,
This patch has been released on the stable branch ? Availaible in CES ?
Because the issue is still there in the current version : https://github.com/centreon/centreon/issues/4710#issuecomment-246983722
Regards,

Hi,
we tested the patch successfully too. Make it available in the stable branch/ces repository would be great! :-)


How to implement Python-like solidityKeccak?

final_hash = Web3.solidityKeccak(['bytes','bytes','bytes'], [
    b,
    a,
    c
])

I didn't find anything at Utils

Hi @darren2025
That's keccak 256 hash library written in PHP. I think someone already port this into python.


Phonegap Build Error (Online Service) - Could not find any version that matches com.google.android.gms:play-services-gcm:12+

Build Error
BUILD FAILED
Total time: 1.288 secs
Command finished with error code 1: /project/gradlew cdvBuildDebug,-b,/project/build.gradle,-Dorg.gradle.daemon=true,-Dorg.gradle.jvmargs=-Xmx2048m,-Pandroid.useDeprecatedNdk=true
Error: /project/gradlew: Command failed with exit code 1 Error output:
FAILURE: Build failed with an exception.

What went wrong:
A problem occurred configuring root project 'project'.

Could not resolve all dependencies for configuration ':_debugApkCopy'.
Could not find any version that matches com.google.android.gms:play-services-gcm:12+.
Versions that do not match:
11.0.4
11.0.2
11.0.1
11.0.0
10.2.6
+ 18 more
Required by:
project :

config.xml
<preference name="phonegap-version" value="cli-6.5.0" />
<plugin name="phonegap-plugin-push" spec="~1.10.5">
	<param name="SENDER_ID" value="123456789" />
</plugin>
<plugin name="cordova-plugin-google-analytics" source="npm">
	<param name="ios-package" value="UniversalAnalyticsPlugin" />
	<param name="android-package" value="com.danielcwilson.plugins.analytics.UniversalAnalyticsPlugin" />
</plugin>

Comment
Is there a fix for the above?
Thanks

@BhavikaP the PGB team has asked for people with issues regarding phonegap build please start an issue on the support forum: https://forums.adobe.com/community/phonegap/build
please include an app id of an app that can replicate this issue.

Thanks  @macdonst
Is this a PG Build issue? Because I was able to successfully compile an App a week ago.
Would you know if they are aware of it and there is a solution to fix it.

Was able to resolve the issue by using an older version of the plugin.


After logging out from Publisher, APIs in Store are not visible

After logging out from Publisher, the token for Store also seems to be revoked. Hence the API calls happening after that gives a 401 Unauthorized.

Cannot reproduce in the current codebase


Add guard to improve testing feedback

Guard::RSpec allows to automatically launch specs when files are
modified. I have also included spring commands to speed up
RSpec tests.
To use it run:
$ guard

Closing this PR. Not sure about adding this, as there are other ad-hoc solutions for developers that don't pollute the Gemfile


issues about input chinese

I input 2 char but it get 1

I  input 你好 get 你
in ubuntu18.04

Thanks for the bug report. I do not know how to type those characters. But I tried to copy-paste those 2 characters. In this case, the former character worked as expected while the second one was pasted as two space. So, there is an issue but I cannot say yet what is the cause. Needs more investigation.

The issue is prob caused by the Mac fix I put in months ago to address another issue.

https://github.com/VladimirMarkelov/clui/issues/66

#66 has mostly *_osx.go files changed, but the trouble with invisible character(2 spaces instead of 1 wide character) I see in Windows as well


fix for issue #17

Fix for https://github.com/datmo/datmo/issues/17

Pull Request Test Coverage Report for Build 186

18 of 18 (100.0%) changed or added relevant lines in 3 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.04%) to 82.683%

Totals

Change from base Build 161:
0.04%

Covered Lines:
1929

Relevant Lines:
2333

💛  - Coveralls


net: l2: ieee802154: fix soft channel access algorithms

I believe that soft CSMA/CA and ALOHA access mechanisms had minor issues which are fixed in this PR (see details in the respective commit comments).
This change set required some initial level of standard compliant L2 multi-PHY awareness. The way multi-PHY awareness is introduced in this PR can only be preliminary. True multi-PHY support requires additional infrastructure in the radio API which is beyond the scope of this PR. See the closely related analysis in https://github.com/zephyrproject-rtos/zephyr/issues/50336#issuecomment-1251122582. There is a certain community interest in supporting additional PHYs (from myself and also @nandojve). TODOs indicating required future changes for true multi-PHY support have therefore been included.
As changes to the access mechanisms are hard to be covered by tests, a careful review wrt potential regressions would be great. @nandojve, @jukkar, @tbursztyka, could you maybe have a look as well?
Additionally we will give this change a bit of hardware exposure on TI's CC1352 chips. This requires changes to the driver to use the soft CSMA/CA algorithm which have not been finished yet (see the TODO's in 3e87cea951e75174d3c0af14c8f7c8d3af221106 building on top of this change set).
Maybe someone is able to try this out on at least one established hardware platform that does not have hardware support for CSMA/CA before we merge this?

Do you have an idea about time to introduce radio api for PIB?

This will happen very soon - the first use case being setting channel page, band and operating mode in the SubGHz driver and letting the driver derive PHY PIB attributes (e.g. number of available channels, symbol rate) that L2 will then be able to use.

If for some reason you need dig in the security

That's not on my roadmap for the foreseeable future. See the RFC and the issues in the public Zephyr/TSCH project: https://github.com/orgs/zephyr-tsch/projects/3/views/1

@nandojve Thanks for your review! I went through your comments and made changes or explained where I didn't, if you like you can have another look.

The CSMA/CA fixes have now been successfully tested against real hardware, see #58439. The other changes proposed by rlubos are outstanding and will be made asap.

@rlubos I fixed the issue that you discovered plus the other issues that I found pending. This includes a fix for the ack procedure which also had a few issues.
@nandojve As I added more commits maybe you want to have another look?

Side note, I started to think the ieee802154_radio_handle_ack can be deprecated at some point in the future. This is only required if radio is handling TX-CCA and auto RX-ACK, right? In this case, after this change, it can be possible PHY capabilities when using OpenThread. Is this assumption correct?

Side note, I started to think the ieee802154_radio_handle_ack can be deprecated at some point in the future. This is only required if radio is handling TX-CCA and auto RX-ACK, right? In this case, after this change, it can be possible not report PHY capabilities when using OpenThread + correct HW configs. Is this assumption correct?

IMO this assumption is NOT correct. "Soft ACK" on the TX path will be required in the long run for all chips that do not support "Hard ACK" which are several (including e.g. CC13/26xx Sub-GHz drivers which we use and which triggered most of the changes in this PR).

Driver Maintainers, @rlubos , @nandojve I compiled the following table which shows the assumptions I made when introducing additional/fixing existing capabilities:
Legend:

TX path:

CSMA: IEEE802154_HW_CSMA
TX_ACK: IEEE802154_HW_TX_RX_ACK
RETR: IEEE802154_HW_RETRANSMISSION (requires IEEE802154_HW_TX_RX_ACK)
h_ack(): correctly calls ieee802154_handle_ack()

RX path:

RX_ACK: IEEE802154_HW_RX_TX_ACK

Driver
CSMA
TX_ACK
RETR
h_ack()
RX_ACK [2]

B91
n
y
n
y
y

CC13/26-SG
y [1]
n
n
y [2]
n

CC13/26
y
y
y [2]
n [3]
y

CC1200
n
n
n
y
n

CC2520
n [4]
n
n
y
y

DW1000
n [5]
n
n
y
n

KW41Z
n [6]
y
n
y [7]
y

MCR20A
n [6]
y
n
y [8]
y

nRF5
x [9]
y
n
y
y

RF2xx
y
y
y
n [10]
y

UART
n
n
n
y
n

Footnotes:
[1] The version in this PR still claims support but this is not standard conforming and will be replaced in a later PR (see #...).
[2] introduced in this PR
[3] currently optional when driver supports IEEE802154_HW_RX_TX_ACK - will be required for enhanced ACK handling inside L2 independently from IEEE802154_HW_RX_TX_ACK
[4] implements a non-conforming CCA algorithm (one backoff with a fixed delay of 10ms) and does not claim IEEE802154_HW_CSMA capability
[5] implements CCA Mode 5 (HRP UWB preamble sense) but does not support CSMA/CA in HW (nor does it claim to do so)
[6] The tranceiver's T / TR sequences do not support true CSMA/CA with exponential backoff (and the driver doesn't claim to do so). The driver performs one additional Mode 1 CCA just before TX.
[7] The tranceiver does not provide the ACK package received in its TR sequence, so the driver re-creates a synthetic ACK and will therefore not be able to support enhanced ACKs unless introducing optional manual ACK RX.
[8] The driver seems to have a bug as it submits the received package to ieee802154_handle_ack() rather than the ACK package (which the hardware will not provide - see Ref.Man., section <IP_ADDRESS>.5 - "Because this is a Receive-Acknowledge-Only operation, and not a Sequence R, there will be no receive octets transferred to Packet Buffer [...]".). The call to ieee802154_handle_ack() will ignore this and as the driver does auto-ACK on the RX path, nothing really happens. Enhanced ACKs will not be supported by this driver, though.
[9] The driver dynamically determines this capability during initialization depending on the underlying SoC.
[10] Only called for OT L2.

@rlubos @nandojve Also see detailed regression tests (executed with two Texas Instruments CC1352P dev kits) documented here. Please note that introducing the required mandatory initial CSMA/CA random backoff reduces the max. data rate between two isolated nodes but is required for CSMA/CA to actually work. If it wouldn't exist, there would be no "fair" arbitration among WPAN participants. IMO the results are well in line with theory, although we'll definitely do more experimentation later on as we proceed with TSCH development (including more statistics specifically for IEEE 802.15.4).

If for some reason you need dig in the security

That's not on my roadmap for the foreseeable future. See the RFC and the issues in the public Zephyr/TSCH project: https://github.com/orgs/zephyr-tsch/projects/3/views/1

@fgrandel - I think this might be a private repository or project. Is that the case?

Just adding a DNM until after the release is cut (2 days from now, thanks for your patience and excellent work @fgrandel!)


Application failed to start when I use netflix-eureka-client and HikariCP

I want to report a bug. When I creata a simple project with spring-boot-starter-web, spring-boot-starter-jdbc, spring-cloud-and starter-netflix-eureka-client, it failed to start with an error below.
***************************
APPLICATION FAILED TO START
***************************

Description:

The dependencies of some of the beans in the application context form a cycle:

   org.springframework.boot.autoconfigure.jdbc.DataSourceJmxConfiguration$Hikari
┌─────┐
|  scopedTarget.dataSource defined in class path resource [org/springframework/boot/autoconfigure/jdbc/DataSourceConfiguration$Hikari.class]
↑     ↓
|  org.springframework.boot.autoconfigure.jdbc.DataSourceInitializerInvoker
└─────┘

Versions:
Spring Cloud: Finchley.RC1 or M7
Spring Boot: 2.0.0 or 2.0.1
Example codes:
https://github.com/cero-t/jdbc-example-bug
When I remove eureka-client from pom.xml, it works well. When I remove HikariCP from pom.xml, changing spring-boot-starter-jdbc to spring-jdbc, it works well, too. Then I suspect that the combination of eureka-client and HikariCP causes this error.
Thanks.

This is a duplicate. I'll find the issue number later. Thanks for the sample.

yup, I've started looking at this. He has a sample that is helpful.

Setting --spring.cloud.refresh.refreshable=none will work around the issue in the mean time.


Allow custom getCurrentPosition method

Allow to set a custom function for getCurrentPosition (useful to check if location permission is granted for example).

Hi @Mbompr, sorry for the delay. Can you fix the conflicts so I can merge this? :)

Hi @guilhermepontes, only the first commit was supposed to be merged. The other ones are more directly linked to my own use case (I have added the possibility to work with Algolia's autocomplete but in a quick and dirty way...). I will probably do it in a cleaner way later but right now I don't have enough time.
Are you interested in the first commit modifications?


[Sender] make resend interval configurable

When in offline mode, resend interval for cached events is hard coded as 60 seconds. This is too long for small application/tools which only run for several seconds. Application will hang in there, being prevented from exiting.
Here making the resend interval configurable in setOfflineMode API to give more flexibility to end users.

Thank you, looks good. Could you please add unit tests?

Sure. Will add it soon.

@kamilszostak I've added some unit tests. Please help review them. Thanks!

:+1:

Thanks a lot! :shipit:


chore: clean up fetching logic and warnings

@andrew2net some tests are failing due to mismatches in the <abstract> output. It seems that it started failing after ISO changed their site layout. Can you please help fix them and merge this? Thanks.

Thank you @andrew2net !


[language] Bring cost table code in the Move VM

This move cost table related code away from the VM and into move-core/types
and move-vm/types.
The goal is to bring everything about native functions into the
MoveVM where we can rationalize that first and then maybe relax and move
it to the Libra layer.
That cleaned up dependencies a bit too

@bors-libra r=tnowacki

:pushpin: Commit faf4e00 has been approved by tnowacki

:hourglass: Testing commit faf4e00bc5eca36d61885b2d09662ad951dac70a with merge 3af0f2457452ac6d37d2e823da27eb17ffe47aa8...

:sunny: Test successful - checks-actions_land_blocking_test, checks-circle_commit_workflow
Approved by: tnowacki
Pushing 3af0f2457452ac6d37d2e823da27eb17ffe47aa8 to master...


VM: Built-in identifier as prefix is not detected as a compile-time error.

This is the vm specific sub-issue for #28811, which has the details.
The vm should detect when a built-in identifier is declared as the name of a library prefix, and flag it as a compile-time error.
Usages are generally flagged by the vm as compile-time errors (the experiment mentioned in #28811 gives details). This is as specified, cf. the spec change (#28817).
It looks like the vm treats the built-in identifiers as keywords, so abstract.int v1 = 42; fails because abstract is an unexpected token at that point, but it should be rejected because abstract.int is a type name, and abstract is a built-in identifier, so it cannot occur in a type annotation. So the error message is somewhat confusing, but this is probably not a problem. At least, I cannot think of any programs that should be accepted/rejected where this makes the vm do the opposite.

In this CL, built_in_identifier_prefix_test.dart has been split into several tests, and the new tests contain updated expectations.
There are still some issues: dynamic<int> crashes three configurations (where $compiler is dartk or dartkp), Function(abstract) x = null; is not detected as a compile-time error even though it uses a built-in identifier in a type annotation (and there are about 15 similar cases), known_identifier_usage_error_test/none with --strong and --checked seems to give rise to code generation where an actual type argument (of a Future) has been dropped, export Function() x = null; does not incur a compile-time error (even though it uses the built-in identifier export in a type annotation) and similarly for import 'dart:core' as dynamic; (which uses a built-in identifier as a library prefix). Moreover, async<dynamic> is not considered a compile-time error with --strong even though async is a library prefix, and about 50 similar issues. (All the corresponding status file entries have been marked 'Issue 28814').
dynamic<int> is accepted, typedef Function() x = null; causes a crash, operator Function() x = null; is not a compile-time error (even though it uses a built-in identifier in a type annotation), and 19 other issues (marked as Issue 28813 in the status file).

The tests have been reorganized. known_identifier_prefix_test.dart deals with identifiers that are not built-in, but just "known" (such as hide and show). They are allowed to be used as the names of types, and known_identifier_prefix_test.dart does not occur in any status files. So I believe that part has been resolved at this point.
Similarly, known_identifier_prefix_error_test.dart uses the same identifiers in various ways which are compile-time errors (basically because they are attempts to use a library prefix as a generic class), and there are no other status file entries for that test than two entries applicable to !$strong.
So these "known-but-not-built-in" identifiers are tested correctly and successfully, I think.
However, the tests on actual built-in identifiers need some updates:

built_in_identifier_test.dart skips over covariant, deferred, Function, and possible others.
And so does built_in_identifier_illegal_test.dart.
(but built_in_identifier_type_annotation_test.dart seems to be OK).

So we could re-target this issue as an area-test to handle those things, or we could create a new issue for those things on the test and then handle any upcoming area-vm (and other area-...) failures when the tests have been updated.

I created https://github.com/dart-lang/sdk/issues/34346 to handle the tests; closing this one.


ROX-9946: Removing the requirement to have notifier modify permissions for the default vuln reporter role (migration included)

Description
Migration to ensure the default out of box vuln reporter role does not have the modify notifier permission since it is not required to be able to create a report.
Checklist

[x] Investigated and inspected CI test results
[x] Unit test and regression tests added
[x] Evaluated and added CHANGELOG entry if required
[x] ~Determined and documented upgrade steps~
[x] ~Documented user facing changes (create PR based on stackrox/openshift-docs and merge into rhacs-docs)~

Testing Performed
Automated, manual TBD

@clickboo
If we ignore the import updates, are the files with the relevant changes these?

CHANGELOG.md
central/role/datastore/singleton.go
migrator/migrations/m_96_to_m_97_modify_default_vulnreportcreator_role/migration.go
migrator/migrations/m_96_to_m_97_modify_default_vulnreportcreator_role/migration_test.go

@clickboo
I have deployed this image, and tested by creating an auth provider with default login of new VM report creator role. I could still create a report.
Someone else needs to check the actual Go code, but your change is working as expected. 👍

@vjwilson Yes, those are the files of interest. Thank you for the test, I gave it a spin on my local cluster too. @theencee review please, I expect cookies otherwise ;-)

I wish I could get cookies for not reviewing PRs. 😢

@clickboo If we ignore the import updates, are the files with the relevant changes these?

CHANGELOG.md
central/role/datastore/singleton.go
migrator/migrations/m_96_to_m_97_modify_default_vulnreportcreator_role/migration.go
migrator/migrations/m_96_to_m_97_modify_default_vulnreportcreator_role/migration_test.go

@theencee ^ (since this PR has 241 touched files just because of imports)


Add animation-control functions to Characters and other objects

This has been split from #18 to avoid scope-creep and since the best option is to have those enhancements in 2.0.
We have to enhance the interface of the PopochiuCharacter, PopochiuProp and PopochiuInventory classes to introduce more animation-controlling methods.
We have at least to provide:

[x] pause_animation
[x] resume_animation
[x] stop_animation
[x] (optional) a non-blocking version of play_animation that works in the background
[x] (optional) a wait_for_idle function that blocks a script until a character is not back to idle animation see comments

Of course the whole thing, plus conventions must be documented in the wiki.

wait_for_idle does not belong here. It is not meant to wait for animations alone but for movement or talking etc.
It is worth adding it as an optional to have better control during cutscenes.


Unclear how to enable backup on an existing cluster

Hi!
The following lines are a little bit unclear:
"First you need to enable the backup and restore service in your cluster. Get the template for the cluster that you want to deploy. You can either use the sample templates or create a Resource Manager template. Enable the backup and restore service with the following steps"
How would this be done on an existing cluster?
Thanks!

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 3f2bc356-6903-4a75-4c60-2888595afead
Version Independent ID: f993726e-375d-3f34-6423-957fa9273aa5
Content: Periodic backup and restore in Azure Service Fabric
Content Source: articles/service-fabric/service-fabric-backuprestoreservice-quickstart-azurecluster.md
Service: service-fabric
GitHub Login: @hrushib
Microsoft Alias: hrushib

Thanks for the question! We are investigating and will update you shortly.

@jfalameda the sample is for an exsisting cluster.
You would take whatever template you used to deploy your cluster, add the backup and restore configurations then update the cluster.
Are you running in Azure or on prem?

@jfalameda any update on this?

Alternately, you can do this using Azure Resource Manager. Note that you need to update fabricSettings  as well as addonFeatures with the values mentioned in Backup Restore service enablement document.

Thanks @hrushib for suggesting that as well :)
@jfalameda we will close this for now. If you are still having issues just let us know and we can always reopen and continue the discussion.

Thank you Micah,
I managed to fix it following your guidance.
Thanks a lot.
Kind Regards,
/ José.
El lun., 1 abr. 2019 a las 17:07, Micah<EMAIL_ADDRESS>escribió:

Closed #28128 https://github.com/MicrosoftDocs/azure-docs/issues/28128.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/MicrosoftDocs/azure-docs/issues/28128#event-2243660878,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AARjtjnMbvcUYmHWIZOqd9mrPw-64cWDks5vciDPgaJpZM4cN8E_
.


azure-mgmt-apimanagement / can only set only one tag instead of multiple tags in query param

Package Name:  azure-mgmt-apimanagement
Package Version:  3.0.0
Operating System: ubuntu 20.04
Python Version: 3.10

Describe the bug
A clear and concise description of what the bug is.
As per API doc, the query param accepts multiple tags in the form of &tags=a&tags=b, which means multiple query params with the same name.
But the python sdk accept only one tag:
https://github.com/Azure/azure-sdk-for-python/blob/60dd9429b48036b252d8376f4f6789d2877e22a7/sdk/apimanagement/azure-mgmt-apimanagement/azure/mgmt/apimanagement/operations/_api_operations.py#L88-L89
To Reproduce
Steps to reproduce the behavior:
The SDK just accepts tags field as a simple str:
https://github.com/Azure/azure-sdk-for-python/blob/60dd9429b48036b252d8376f4f6789d2877e22a7/sdk/apimanagement/azure-mgmt-apimanagement/azure/mgmt/apimanagement/operations/_api_operations.py#L41-L49
Expected behavior
A clear and concise description of what you expected to happen.
Whether key tags as str, but do some internal split before sending to backend API, whether make tags as list[str]
Screenshots
If applicable, add screenshots to help explain your problem.
Additional context
I only checked azure-mgmt-apimanagement, maybe same issue for other modules too.

Hi @copdips SDK is generated with swagger by tools. For this issue, we need to make sure:
(1) Does https://github.com/Azure/azure-rest-api-specs/issues/23731#issuecomment-1525151467 work? I understand not all the service support multi query values. If service doesn't support that and you want this feature, please make issue in https://github.com/Azure/azure-rest-api-specs/issues
(2) If service supports that, service team needs to update the swagger definition with guidance: https://swagger.io/docs/specification/2-0/describing-parameters/
(3) After (1) and (2) done, SDK team can release a new version to support that.

@msyyc
thank you very much for your check, I just dropped a message to APIM API team on github.


Blacklisted file extensions are still accepted

As the title says, uploading a blacklisted file extension (exe, msi, bat, etc.) gives a 403 but a link to download the file anyways.

Ok, that must have slipped through as I rewrote the upload system. Will try and fix it as soon as I get around to it.


Fix SetFocus based on win32gui.SetForegroundWindow. close #117

Current coverage is 96.84%

Merging #122 into master will not affect coverage as of 604bec4

@@            master    #122   diff @@
======================================
  Files           22      22
  Stmts        16461   16474    +13
  Branches         0       0
  Methods          0       0
======================================
+ Hit          15941   15954    +13
  Partial          0       0
  Missed         520     520

Review entire Coverage Diff as of 604bec4

Powered by Codecov. Updated on successful CI builds.


Update version numbers for DSM 7

Hi - thanks for this project, was really helpful in a personal project.  I've upgraded one of my Synology's to DSM 7, and had to tweak a couple version numbers for this to work.  I am just adding a download via API, not using all the features, so can't state with 100% confidence that everything works with DSM 7, but at least adding downloads does.

All good, thanks for adding this. 👍


new nuget package, UK fix

Can you please deploy a new nuget package?

+1 from my side too

@bryanvam You can use https://github.com/tinohager/Nager.Country


DPL-083: Automatic release versions

Work for https://github.com/sanger/deployment/issues/71
Changes proposed in this pull request:

Only check release versions have been incremented on master (i.e. production builds)
For develop builds, append the GitHub workflow run ID and -develop

Note I chose to use the workflow run ID that increments across all workflows in the repo.  I thought this was better than the ID of the one workflow, as that might get reset if the workflow gets renamed or we have two workflows doing release builds for some reason.

Incidentally, I have no idea if this works or not.  I don't know how I can test it other than to just try to create some releases.

CodeQL is lying.  Those are not "new" alerts.  I don't know if we should be fixing them in a separate PR though.


App.css?9a66:26 Uncaught Error: Cannot find module "react-router"

Version
Please replace this sentence with the React Router version that you are using.
Test Case
https://codesandbox.io/s/n55VljYk7
Steps to reproduce
Expected Behavior
Actual Behavior

App.css?9a66:26 Uncaught Error: Cannot find module "react-router"

This is a bug tracker, not a support system. For usage questions, please use Stack Overflow or Reactiflux where there are a lot more people ready to help you out. Thanks!


Fix tests/integ/test_stored_procedure.py

Please answer these questions before submitting your pull requests. Thanks!

What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Fixes #NNNN

Fill out the following pre-review checklist:

[ ] I am adding a new automated test(s) to verify correctness of my new code
[ ] I am adding new logging messages
[ ] I am adding a new telemetry message
[ ] I am adding new credentials
[ ] I am adding a new dependency

Please describe how your code solves the related issue.
Please write a short description of how your code change solves the related issue.

https://ci-dev-142.int.snowflakecomputing.com/job/PythonStoredProcBuildPrecommitTest/793/

Please update the description for reference purpose.


vaadinCompileWidgetset with gwt.jvmArgs produces "No main class found" but sucessfull build.

Setting gwt.jvmArgs leads to a wrong string concatenation in class CompileWidgetsetTask.groovy
which produces a "no main class found" in java.lang.String.
Unfortunately the var. "widgetsetCompileProcess"  is not logged out and the build is successfull
gwt {
// [ERROR] Fehler: Hauptklasse [Ljava.lang.String;@13fec43 konnte nicht gefunden ...werden
jvmArgs = ' -Xms500M '
logLevel = 'DEBUG'
logging = true
}
Doing the concatenation like it is done with gwt.extraArgs should solve the problem

An "as List" should solve the problem
def widgetsetCompileProcess = ['java']
if (project.vaadin.gwt.jvmArgs) {
   widgetsetCompileProcess += project.vaadin.gwt.jvmArgs as List
}

Addendum:
Using a String array like
jvmArgs = [ ' -Xms500M ']

(how it would be correct) doesn't solve the problem

Fixed in a8c52dfde665c4c90707ed3cb725c006ec6b3ab9


[Enhancement] Make list command always show all clusters. Remove --all option

It feels more natural to have the list command show all clusters by
default.
@zeerorg asked a question in the same area in #33.  I agree with his question as well.
I often forgot to add --all flag and find myself wondering what happened to the stopped clusters.

This seems good to me 👍
Also we should probably not remove --all since it might confuse existing users, instead add a deprecation flag.

@zeerorg I agree. Added --all back in and warn user about it.


ci: increase Jenkinsfile timeout for 1.10 branch

This is a hack to work around 1.10 Jenkins jobs timing out in backport testing due to having to download non-cached Vagrant boxes.
Full context:
We use a custom Vagrant cache to accelerate setting up Jenkins runners, but we only cache the latest 3 stable branches and master because testing is only conducted against those (or branches based off those).
There is an edge case for the overlap time where the newest stable branch (here 1.13) exists but has not been released yet, so the oldest stable (here 1.10) is still officially supported.
Caching an additional stable branch would increase the already long time it takes for runners to come up, and would not be much useful given the low volume of pipelines running against a soon-to-be deprecated branch.
Instead, we elect to allow a greater timeout on the 1.10 branch to compensate for the additional Vagrant box download time.

/test-backport-1.10

CI passed, marking ready to merge.


Replaced SheetLoader with SheetPlugin

New Pull Request
For more information, see the CONTRIBUTING guide.
Prerequisites
Please make sure you can check the following boxes:

[x] I have read the CONTRIBUTING document
[x] My code follows the code style of this project
[x] All new and existing tests passed

Type(s) of Changes
Contribution Type
What types of changes does your code introduce? Put an x in all the boxes that apply:

[ ] Bug fix (non-breaking change which fixes an issue, please reference the issue id)
[x] New feature (non-breaking change which adds functionality, make sure to open an associated issue first)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] I have updated the documentation accordingly
[ ] I have added tests to cover my changes

Description
Replaced the custom webpack loader SheetLoader with a custom webpack plugin SheetPlugin. This plugin (formerly loader) allows linking of stylesheets by injecting a code to the output index.js. When using a loader, there is a chance ( through misconfigurations ) to create multiple links in the resulting index.js. By using a plugin, there is a guarantee that the link is generated only once.
Reference to gitter thread in Piral community: https://gitter.im/piral-io/community?at=607deb98c60826673bb41d15

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Isuru Jayasooriya seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


found another firstmodule type that wasn't registered by goloader.

I keep running into this error:
[found another firstmodule type that wasn't registered by goloader. Symbol name:
Full error](panic: found another firstmodule type that wasn't registered by goloader. Symbol name: type:*go.shape.interface { Close() error; Position() github.com/go-gl/mathgl/mgl64.Vec3; Rotation() github.com/df-mc/dragonfly/server/block/cube.Rotation; Type() github.com/df-mc/dragonfly/server/world.EntityType; World() *github.com/df-mc/dragonfly/server/world.World }, type name: *go.shape.interface { Close() error; Position() github.com/go-gl/mathgl/mgl64.Vec3; Rotation() github.com/df-mc/dragonfly/server/block/cube.Rotation; Type() github.com/df-mc/dragonfly/server/world.EntityType; World() *github.com/df-mc/dragonfly/server/world.World }. This shouldn't be possible and indicates a bug in firstmodule type registration)
Is there something I am doing wrong here? Or are my dependencies really breaking it all?
Here is my loader
func (bl *BridgeLayer) LoadPlugin() {
	conf := jit.BuildConfig{
		KeepTempFiles:   false,
		ExtraBuildFlags: []string{"-x"},
		BuildEnv:        nil,
		TmpDir:          "",
		DebugLog:        true,
	}

	loadable, err := jit.BuildGoFiles(conf, "resources/plugins/coretest.go")

	if err != nil {
		panic(err)
	}

	module, err := loadable.Load()
	if err != nil {
		panic(err)
	}

	symbols := module.SymbolsByPkg[loadable.ImportPath]

	defer func() {
		err = module.Unload()
		if err != nil {
			fmt.Println(err)
			panic(err)
		}
	}()

	switch f := symbols["New"].(type) {
	case func() interface{}:
		pl := f()

		fmt.Println("Loaded first plugin")
		fmt.Println(pl)
	default:
		panic("Function signature was not what was expected")
	}
}

And here is my plugin
package coretestplugin

import (
	"github.com/nnnnt21/drag/plugins"
)

type CorePluginTest struct {
}

func (c CorePluginTest) Initialize(api plugins.ServerAPI) {
	//TODO implement me
	panic("implement me")
}

func (c CorePluginTest) OnPlayerJoin(player plugins.Player) {
	//TODO implement me
	panic("implement me")
}

func (c CorePluginTest) OnPlayerLeave(player plugins.Player) {
	//TODO implement me
	panic("implement me")
}

func New() interface{} {
	return CorePluginTest{}
}

var _ plugins.Plugin = (*CorePluginTest)(nil)

Could anyone provide me with some insight?

Hi, thanks for raising an issue - this panic was intended to flag failure cases (to me) where the type registration logic is faulty.
Would you mind posting the actual imports that cause this so I can reproduce/add a test case for it?

I am not really sure how to tell what module is causing it but i've attached the debug log below and here is my go.mod file if that is what your after
module github.com/nnnnt21/drag

go 1.20

require (
	github.com/df-mc/dragonfly v0.9.8
	github.com/eh-steve/goloader/jit v0.0.0-20230701235027-e554af95fe68
	github.com/google/uuid v1.3.0
	github.com/pelletier/go-toml v1.9.5
	github.com/sirupsen/logrus v1.9.0
)

require (
	github.com/brentp/intintmap v0.0.0-20190211203843-30dc0ade9af9 // indirect
	github.com/cespare/xxhash v1.1.0 // indirect
	github.com/df-mc/atomic v1.10.0 // indirect
	github.com/df-mc/goleveldb v1.1.9 // indirect
	github.com/df-mc/worldupgrader v1.0.8 // indirect
	github.com/eh-steve/goloader v0.0.0-20230701235027-e554af95fe68 // indirect
	github.com/go-gl/mathgl v1.0.0 // indirect
	github.com/golang/protobuf v1.5.3 // indirect
	github.com/golang/snappy v0.0.4 // indirect
	github.com/klauspost/compress v1.15.15 // indirect
	github.com/muhammadmuzzammil1998/jsonc v1.0.0 // indirect
	github.com/rogpeppe/go-internal v1.9.0 // indirect
	github.com/sandertv/go-raknet v1.12.0 // indirect
	github.com/sandertv/gophertunnel v1.31.0 // indirect
	github.com/stretchr/testify v1.8.4 // indirect
	go.uber.org/atomic v1.10.0 // indirect
	golang.org/x/crypto v0.5.0 // indirect
	golang.org/x/exp v0.0.0-20230206171751-46f607a40771 // indirect
	golang.org/x/image v0.5.0 // indirect
	golang.org/x/net v0.7.0 // indirect
	golang.org/x/oauth2 v0.4.0 // indirect
	golang.org/x/sys v0.5.0 // indirect
	golang.org/x/text v0.7.0 // indirect
	google.golang.org/appengine v1.6.7 // indirect
	google.golang.org/protobuf v1.31.0 // indirect
	gopkg.in/square/go-jose.v2 v2.6.0 // indirect
)

log.txt

I was looking for the minimal reproducing source of the JIT code that causes this issue (i.e. whatever is in nnnnt/drag/plugins).
I need to be able to build it to see what the symbol name should be.

Actually, there's a small chance I already fixed this in this PR which I haven't merged yet. Would you mind testing using aeda36ba1edee31cf00bd37d88724ef51f2529ea?

I apologize, that struct actually is from the github.com/df-mc/dragonfly/server/player package i believe, as I don't define that anywhere.
But in good news that PR actually did fix the issue, I appreciate it a ton.

Just a heads up that I might be rebasing that branch while I finish it off and will delete it once it's merged, so you might need to point at master again once I'm done

FYI I've just merged that PR into master now 🙂


Handle to_csv properly when resource contains int in Python 2.7.

This change is

Reviewed 2 of 2 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable


enhancement(monitor): enable dropping events at the kernel level

Signed-off-by: Achref ben saad<EMAIL_ADDRESS>Purpose of PR?: #1088 #1089 #1006
Does this PR introduce a breaking change? No
If the changes in this PR are manually verified, list down the scenarios covered::
Additional information for reviewer? :
Mention if this PR is part of any design or a continuation of previous PRs
Checklist:

[x] New feature (non-breaking change which adds functionality)
[x] This change requires a documentation update
[x] PR Title follows the convention of  <type>(<scope>): <subject>
[x] Commit has integration tests

New logic for droping events:

Noting the init container changes are not backwards compatible, so we  need to establish stable and version init containers as well.


Add Chibi Annie and Bun Bun

Baron Still broken

Is it possible to add the chibi gwen from the chinese version of tft?


[GUI] Alphabetize (Lexicographically) Interface Assignments Menu

[X] I have read the contributing guide lines at https://github.com/opnsense/core/blob/master/CONTRIBUTING.md
[X] I have searched the existing issues and I'm convinced that mine is new.

Is your feature request related to a problem? Please describe.
I get annoyed when I go into the interface assignments screen and look at the interfaces available for assignment. They aren't in any sort of order I can determine.
Describe the solution you'd like
I'd like to see the list of interfaces on the "Interfaces: Assignments" page sorted not just alphabetically, but lexicographically. E.g. a "vlan 10 on ..." entry would come after a "vlan 3 on ..." entry.
Describe alternatives you've considered
You can keep some ordered groupings to the list by creating interfaces in the exact order you need and then never editing them, but I don't think that's a good long term solution. If you want to keep them grouped in order, you'd have to edit each interface in order every time you wanted to do something to one of them. This would not only cause more disruption than it should, it's also very tedious.
Additional context
URL of the page in question is <opnsense_ip>/interfaces_assign.php

Please disregard; opened under the wrong account.


Grub menu not readable / old configuration always chosen

Describe the bug
I'm running NixOS 22.11. Recently, I saw that the Grub menu looks strange (way to big, not fully readable). I think this might be related to connecting an external monitor to the laptop. Upon further inspection, I also realized that there is always one specific generation set as the default value for Grub. Even when running nixos-rebuild switch/boot, the old generation stays. I can't seem to delete it neither.
Steps To Reproduce
:shrug:
Expected behavior
When running nixos-rebuild switch, a new configuration is installed as the default option in Grub
Screenshots
Generation 32 is always chosen:

Trying to delete the old generation doesn't work. It did work with the pre-32 generations (not visible in the screenshot). I made sure I'm running a non-32 generation when garbage-deleting (not sure if this matters).

Additional context
This is a  Thinkpad. I have recently setup a docking station with an external monitor connected. It worked fine out of the box. I had the laptop screen lid closed and only used the external monitor. Sometimes, I would use the laptop without the docking station. Going back and forth didn't cause any issue. 1-2 days ago, I updated the channels and did a general system update (sudo nix-channel --update; sudo nixos-rebuild switch; sudo nix-env -u '*'). I think the unreadable Grub menu has been there before but I'm not sure. The next time I connected the laptop to the docking station, the external monitor was now an 'empty' desktop (i.e. no taskbar, desktop icons, etc.). I realized it was not used as the only monitor but as an additional one (as if the lid was open). I could not change the desktop configuration (same issues as in https://github.com/NixOS/nixpkgs/issues/11244 / https://github.com/NixOS/nixpkgs/issues/12331). I then tried to rollback to a previous generation with no luck (i.e. desktop issue stays the same).
At some point, I had the nixos-unstable channel in the repository but removed it.
This is just for additional context to explain the journey.
Notify maintainers
@samueldr
Metadata
Please run nix-shell -p nix-info --run "nix-info -m" and paste the result.
[user@system:~]$ nix-shell -p nix-info --run "nix-info -m"
 - system: `"x86_64-linux"`
 - host os: `Linux 5.15.94, NixOS, 22.11 (Raccoon), 22.11.2720.50c23cd4ff6`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.11.1`
 - channels(root): `"nixos-22.11"`
 - channels(rolf): `""`
 - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`

I found this systemd issues that describes precisely the situation. The proposed solution  ("run bootctl set-default "" to delete the default EFI var ") worked: I was able to delete the config generation 32 and now upon nixos-rebuild switch, any new config gets chosen per default as expected.


Getting PR comments

Hello, with this integration is it possible to get the comments attached to a pull request?  I see it mentions comments for commits, but was hopeful to get PR's.  This way QA or business leaders can see within the JIRA ticket itself if PR's are being reiterated upon.  Simply adding as a comment on the ticket with some sort of call-out that it relates to the PR would be fantastic!  Thanks!

Hey @calloquy-dusty-fowler. A PR was recently merged by one of our team members that should address this issue for you so I'm going to go ahead and close this. Please feel free to reopen if you need further assistance.


'eligibility' only returns PreQualification.eligibilityCriteria

I expected to see tender.eligibilityCriteria.

Only extensions are included presently. We can add the core schema and codelists.

Only extensions are included presently. We can add the core schema and codelists.


suggestions to universal examples

Hi @jurgob.  They are similar, but you used Express, which is a better idea than mine since it's already in the stack. Your PR is more appropriate to me merged than mine, I think.
I wrote a few suggestions, if you'd like to incorporate them to your PR before it's merged it would be very nice. It's mostly focused on two ideas: calling it universal following the latest trend :smiley: ; and booting the server directly without generating a new bundle.
Let me know if you would like me to work a little more on something!

@jurgob, I change the server to proxy app.js. Do you think it's clearer this way?

the http-proxy could be a solution, but I was  thinking to  something simpler like keeping your previous implementation and doing something like (take it as pseudo-code):
app.use('/bundle.js', express.static(__dirname + '/bundle.js'));
if(process.env.NODE_ENV ==='development')
app.use('/webpack-dev-server/bundle.js', express.static(__dirname + '/bundle.js'));
do you see any problem with this approach?

@jurgob these examples are not supposed to be used directly in production. I liked the way the proxy route you suggested earlier describes what is really going on to access app.js.
The examples are good enough for me right now. Would you like to accept this PR and update #315 with this?


[Doc] Update torch installation

Issue #, if available:
Description of changes:

Remove the installation of gpu version since it's automatically handled by autogluon.
Update the cpu version.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Previous CI Run
Current CI Run

botocore==1.34.69
botocore==1.34.70

boto3==1.34.69
boto3==1.34.70

botocore==1.34.69
botocore==1.34.70

boto3==1.34.69
boto3==1.34.70


qr code for non support devices

@jkvjerin Looks like you were experimenting with my project and raised this PR my mistake.
Do you want something to be merged on this project? If yes then what these changes are about?

Closing this PR because it's not having any relevant changes for the project and also it has been inactive for a long time.

if the ar web page opens in any unsupported devices such as a pc or phones then a qr code for the page appears... it is done in such a way that different assets can be got via the url parameters and corresponting changes are reflected in the qr code and for trouble shooting the given default asset


Remove add-module-exports babel plugin

add-module-exports modifies the output only if there is a default export and no named exports. Both conditions are false now.

That's not true. This is to allow importing from e.g. react-router/lib/Link, which is required to minimize bundle size.

Oh, I didn't realize it could be used to minimize the bundle size. Thank you for clarifying!


deployed latest release with proxy configuration yet, cattle-node-agent and cattle-cluster fail to use proxy

Deployed Rancher 2.4.5 release with the following ...
helm install
rancher rancher-stable/rancher
--namespace cattle-system
--set hostname=********
--set ingress.tls.source=letsEncrypt
--set<EMAIL_ADDRESS>--set proxy='http://<IP_ADDRESS>:8888'
--set no_proxy='<IP_ADDRESS>,<IP_ADDRESS>/16,<IP_ADDRESS>/14,<IP_ADDRESS>/16,.svc'
Yes, cattle-node-agent and cattle-cluster instances keep restarting because they can not reach the public endpoint without use a proxy.  Proxy configuration are not found inside the containers, however, installation is successful and I can access the public endpoint which has a LB in front of it.  The control nodes are in a subnet where they can only reach outside through a proxy and that is working correctly.

I can run the following on the same worker node and I'm able to reach the rancher external endpoint.
/etc/hosts file has the <IP_ADDRESS>  proxy entry
The hosts file entry does exist in the cattle-node-agent and cattle-cluster instances, however, the environment variables do not.
root@rancherw01:~# docker run -it -v /etc/hosts:/etc/hosts -e https_proxy=http://proxy:8888 -e http_proxy=http://proxy:8888 ubuntu /bin/bash
root@78481daec927:/# curl -kv https://rancher.dexit.cloud/ping

Uses proxy env variable https_proxy == 'http://proxy:8888'
Trying <IP_ADDRESS>:8888...
TCP_NODELAY set
Connected to proxy (<IP_ADDRESS>) port 8888 (#27813
....
Connection state changed (MAX_CONCURRENT_STREAMS == 128)!
< HTTP/2 200

I can run the following on the same worker node and I'm able to reach the rancher external endpoint.
/etc/hosts file has the <IP_ADDRESS> proxy entry
The hosts file entry does exist in the cattle-node-agent and cattle-cluster instances, however, the environment variables do not.
root@rancherw01:~# docker run -it -v /etc/hosts:/etc/hosts -e https_proxy=http://proxy:8888 -e http_proxy=http://proxy:8888 ubuntu /bin/bash
root@78481daec927:/# curl -kv https://*******/ping
Uses proxy env variable https_proxy == 'http://proxy:8888'
Trying <IP_ADDRESS>:8888...
TCP_NODELAY set
Connected to proxy (<IP_ADDRESS>) port 8888 (#27813
....
Connection state changed (MAX_CONCURRENT_STREAMS == 128)!
< HTTP/2 200

$ kubectl get pods -A
NAMESPACE       NAME                                       READY   STATUS             RESTARTS   AGE
cattle-system   cattle-cluster-agent-77c97dbf5d-9c52j      0/1     CrashLoopBackOff   154        22h
cattle-system   cattle-node-agent-756kh                    1/1     Running            154        22h
cattle-system   cattle-node-agent-q9p8p                    1/1     Running            154        22h
cattle-system   cattle-node-agent-r257d                    1/1     Running            154        22h
cattle-system   cattle-node-agent-vfkkn                    1/1     Running            154        22h
cattle-system   cattle-node-agent-whnzf                    1/1     Running            154        22h
cattle-system   rancher-5f59f59cbd-m52vw                   1/1     Running            0          22h
cattle-system   rancher-5f59f59cbd-pjwvr                   1/1     Running            0          22h
cattle-system   rancher-5f59f59cbd-zd26x                   1/1     Running            0          22h
cert-manager    cert-manager-59c5868748-fvjjk              1/1     Running            0          22h
cert-manager    cert-manager-cainjector-76c6657c55-js59m   1/1     Running            0          22h
cert-manager    cert-manager-webhook-64b9b4fdfd-kt5xx      1/1     Running            0          22h
ingress-nginx   default-http-backend-598b7d7dbd-hcvb8      1/1     Running            0          22h
ingress-nginx   nginx-ingress-controller-8tkgf             1/1     Running            0          22h
ingress-nginx   nginx-ingress-controller-sstxv             1/1     Running            0          22h
kube-system     canal-42bwr                                2/2     Running            0          22h
kube-system     canal-c69w7                                2/2     Running            0          22h
kube-system     canal-pds4t                                2/2     Running            0          22h
kube-system     canal-v4jx2                                2/2     Running            0          22h
kube-system     canal-vlhvl                                2/2     Running            0          22h
kube-system     coredns-849545576b-9sq46                   1/1     Running            0          22h
kube-system     coredns-849545576b-f8lmq                   1/1     Running            0          22h
kube-system     coredns-autoscaler-5dcd676cbd-vhtvv        1/1     Running            0          22h
kube-system     metrics-server-697746ff48-j22zq            1/1     Running            1          22h
kube-system     rke-coredns-addon-deploy-job-t56tf         0/1     Completed          0          22h
kube-system     rke-ingress-controller-deploy-job-jvln2    0/1     Completed          0          22h
kube-system     rke-metrics-addon-deploy-job-7d272         0/1     Completed          0          22h
kube-system     rke-network-plugin-deploy-job-mnnv7        0/1     Completed          0          22h


Set JS files to be display either header or footer

Hello, good day i'm not used on posting issues in GitHub, bare me with this one thanks
is there a way we could set the .js files to be included on header and footer or its just me who don't know how to use properly the code thanks a lot.

Hi.
On the master view page echo js_files wherever you want.


Update API_LEVEL_18

Description
Update API_LEVEL_18
Changes include

[ ] Bugfix (non-breaking change that solves an issue)
[x] New feature (non-breaking change that adds functionality)
[ ] Breaking change (change that is not backwards-compatible and/or changes current functionality)
[ ] Tests
[ ] Documentation
[ ] Other (for changes that might not fit in any category)

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 59.65%. Comparing base (0ba8017) to head (b3855c4).
Report is 3 commits behind head on API_LEVEL_18.

Additional details and impacted files
@@              Coverage Diff              @@
##           API_LEVEL_18     #578   +/-   ##
=============================================
  Coverage         59.65%   59.65%
=============================================
  Files                12       12
  Lines              1678     1678
=============================================
  Hits               1001     1001
  Misses              677      677

Flag
Coverage Δ

unittests
59.65% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


RNN Using TensorFlow 2.0

Please let us know anything wrong in below code, not getting desire result -
from numpy import sqrt
from numpy import asarray
from pandas import read_csv
from tensorflow.keras import Sequential
from tensorflow.keras.layers import Dense
from tensorflow.keras.layers import LSTM
import tensorflow as tf
from sklearn import metrics
from sklearn.model_selection import train_test_split

Assign the value as 40 to the variabel RANDOM_SEED which will be the seed value.
Set the random seed value using the value stored in the variable RANDOM_SEED.
RANDOM_SEED = 40
tf.random.set_seed(RANDOM_SEED)

split a univariate sequence into samples
def split_sequence(sequence, n_steps):
    X, y = list(), list()
    for i in range(len(sequence)):
        # find the end of this pattern
        end_ix = i + n_steps
        # check if we are beyond the sequence
        if end_ix > len(sequence)-1:
            break
        # gather input and output parts of the pattern
        seq_x, seq_y = sequence[i:end_ix], sequence[end_ix]
        X.append(seq_x)
        y.append(seq_y)
    return asarray(X), asarray(y)

Read the dataset airline-passengers.csv and give parameter index_col as 0 and save it in variable df.
df = read_csv("airline-passengers.csv", index_col=0)
Convert the data type of the values dataframe df to float32 and save it in variable values.
Assign the value 5 to the variable n_steps which is the window size.
Split the samples using the function split_sequence and pass the parameters values and n_steps and save it in variables X and y
values = df.values.astype('float32')
n_steps = 5
X, y = split_sequence(values, n_steps)

Split the data X,y with the train_test_split function of sklearn with parameters test_size=0.33 and random_state=RANDOM_SEED.**
X_train, X_test, y_train, y_test = train_test_split(X, y, test_size=0.33, random_state=RANDOM_SEED)
Construct a fully-connected network structure defined using dense class
Create a sequential model
Add a LSTM layer which has 200 nodes with activation function as relu and input shape as (n_steps,1).
The first hidden layer has 100 nodes and uses the relu activation function.
The second hidden layer has 50 nodes and uses the relu activation function.
The output layer has 1 node.
model = Sequential()
model.add(LSTM(200, activation='relu',  input_shape=(n_steps,1)))
model.add(Dense(100, activation='relu'))
model.add(Dense(
50, activation='relu'))
model.add(Dense(1))

While comipling the model pass the following parameters -
-optimizer as Adam
-loss as mse
-metrics as mae
model.compile(optimizer='Adam', loss='mse', metrics=['mae'])
fit the model with X_train, y_train, epochs=350, batch_size=32,verbose=0.
model.fit(X_train, y_train, epochs=350, batch_size=32, verbose=0)
Perform prediction on the test data (i.e) on X_test and save the predictions in the variable y_pred.
y_pred = model.predict( X_test)
Calculate the mean squared error on the variables y_test and y_pred using the mean_squared_error function in sklearn metrics and save it in variable MSE.
Calculate the Root mean squared error on the variables y_test and y_pred by performing square root on the above result and save it in variable RMSE.
Calculate the mean absolute error on the variables y_test and y_pred using the mean_absolute_error function in sklearn metrics and save it in variable MAE.
MSE  = metrics.mean_squared_error(y_test,y_pred)
RMSE = sqrt(metrics.mean_squared_error(y_test,y_pred))
MAE  = metrics.mean_absolute_error(y_test,y_pred)
print('MSE: %.3f, RMSE: %.3f, MAE: %.3f' % (MSE, RMSE,MAE))

MSE: 665.522, RMSE: 25.798, MAE: 17.127 ... this we getting and it is wrong.
with open("MSE.txt", "w") as text_file:
        MSE=str(MSE)
        text_file.write(MSE)
with open("RMSE.txt", "w") as text_file:
        RMSE=str(RMSE)
        text_file.write(RMSE)
with open("MAE.txt", "w") as text_file:
        MAE=str(MAE)
        text_file.write(MAE)
# serialize model to JSON
model_json = model.to_json()
with open("model.json", "w") as json_file:
    json_file.write(model_json)

airline-passengers.zip
RNN_Question.zip
After running code then we execute
from hashlib import md5
f = open("MSE.txt", "r")
s=f.read()
s=float(s)
s=round(s,3)
f1=open("RMSE.txt","r")
s1=f1.read()
s1=float(s1)
s1=round(s1,3)
f2=open("MAE.txt","r")
s2=f2.read()
s2=float(s2)
s2=round(s2,3)
if (md5(str(s).encode()).hexdigest() == '51ad543f7ac467cb8b518f1a04cc06af') and (md5(str(s1).encode()).hexdigest() == '6ad48a76bec847ede2ad2c328978bcfa') and (md5(str(s2).encode()).hexdigest() == '64bd1e146726e9f8622756173ab27831'):

	print("Your MSE,RMSE and MAE Scores matched the expected output")
else :
	print("Your MSE,RMSE and MAE Scores does not match the expected output")

Here our output should be match but coming as unmatched.

please help us

@ashishsme14,
Looks like this is a duplicate of #45411.
And as mentioned, this question is better asked on StackOverflow since it is not a TensorFlow bug or feature request. There is also a larger community that reads questions there. Thanks!

No help from that

Hey, had you solved this problem. I'm also getting the same issue

@jagadeeshjr5  did u followed same steps and getting same outut?

@ashishsme14 yes I followed my steps and got the same output

@jagadeeshjr5  can u please tell ur steps n output please

@ashishsme14 I too got the same output, there's may be wrong in testcode or in the question

@jagadeeshjr5  so u passed test case?

@ashishsme14 for RNN only I'm not able to pass the testcase

please help us to review steps which we followed

@ashishsme14 raise a feedback in fresco regrading the issue

@jagadeeshjr5  can u try now n see any luck for me no

@ashishsme14 I already did, you also raise a feedback once

@ashishsme14 there's mistake from their end

@jagadeeshjr5  they saying they corrected it but no luck for me... that why any luck for u?

@ashishsme14 when did they told you

@jagadeeshjr5 today

@ashishsme14 try again, if not getting passed tell them there's an issue with the question

@ashishsme14 still not able to pass

@jagadeeshjr5 reset and install n follow rest process

@ashishsme14 have you completed

@ashishsme14 can you give me your number I'll text you, after that you can delete it

@ashishsme14 Still not able to pass

@ashishsme14 can you tell me what output you got (mse, rmse, Mar)

@ashishsme14 Can you help me with this

@jagadeeshjr5  Once launch do not install anything. 1st re start then install n follow rest process

@ashishsme14 I did it bro, but still no luck, can you tell me what output you got(mse, rmse, mae)

@jagadeeshjr5 not rem it ..

@ashishsme14 did you get the same as before or different

@jagadeeshjr5 different

@ashishsme14 can you tell me the exact procedure what you did

same steps as mentioned here
nothing different

@ashishsme14 I mean exactly what after clicking on start test

yes same steps  RESET -> Install ? Run -> Test

@ashishsme14 on getting into the environment Reset -> Install -> Run -> Open preview -> write code -> run -> test is this the process

yes

@ashishsme14 Still getting the same output bro, not able to pass

@ashishsme14 If you don't mind, can you reattempt it and tell me the output you got bro, that'll be very helpful

MSE: 1544.323, RMSE: 39.298, MAE: 37.612
I am getting these forMLP regression.This is njot matching . Can someone help me with the correct ones ?


[Geolocation] Android support

Just to check the reason that why RN did not support geolocation polyfill for Android in the mean time?
I knew there are some 3rd party modules exist, but I would like to see if it could be a builtin feature.
Are there any concerns?  If need, I can help to do it and send a PR.
Thanks.

Cc @dmmiller

@Kudo - this is on the roadmap, you can see it here: https://facebook.github.io/react-native/docs/known-issues.html#missing-modules-and-native-views

Sorry I missed the know issues document.
Thank you guys for hard working.  React Native is really cool, and hope it will be better and change to mobile development ecosystem.
If there are anything I can help, please feel free to let me know.

No problem, thanks @Kudo! Feel free to open up other issues if you run into bugs :)