Provide litArgs backwards compatibility

Recently I've been encountering some shader errors in different projects and I wish to have reassurance that previous projects will continue to function properly (I prefer not to rely on luck while performing a git pull).
My idea is a simple function which fixes the shader source, but maybe there is a better solution? Any thoughts?
Example for F12/DevTools:
const tests = [
    'x + litShaderArgs.albedo * y',
    'x + litShaderArgs.sheen.specularity * y',
];
const toLitArgs = src => src.replace(/litShaderArgs([\.a-zA-Z]+)/g, (a, b) => {
    return 'litArgs' + b.replace(/\./g, '_');
});
tests.map(toLitArgs);

I confirm I have read the contributing guidelines and signed the Contributor License Agreement.

I added a deprecation warning now, it looks like this in a real project:

Just want to say thanks to @kungfooman for this PR and thought I'd add a quick note on my thoughts, because chunks in the engine are so important.
While I understand the desire for this functionality (and very much sympathise with everyone who's projects break due to shader chunk changes), I don't think this is a good approach to maintaining backwards compatibility.
Reasons are because this approach:

is brittle (especially if we keep adding new fixup code)
will only ever work for some chunk changes/situations
means we are either just kicking the problem down the road (until we remove this code from the engine) or this patch and the grep work is done for everyone, forevermore
if we continue to add to fixup code, over time it will become more difficult to maintain and reason about
etc, I could go on.

Ideally we would have tools for detecting and updating shader chunks, but in the editor. Then we have no runtime performance cost and are free to implement any snazzy functionality we want. Then we could go crazy and store chunk metadata with engine versions etc etc.
Of course we don't have this functionality in the editor right now. So until then, we probably have to accept this approach.
I just hope we can keep this a one-off and actually remove it as soon as possible.

Thank you for adding your thoughts @slimbuck!

I just hope we can keep this a one-off and actually remove it as soon as possible.

Personally I merge main rather often, I just need a certain time frame where it is safe to test this and that PR without breaks that make PR testing harder than it really is (manual fixing checkout's, which is removing time/motivation from dealing with the actual issues).
Which time frame would you be happy with? A year would be enough for me and I enjoy to have the deprecation warnings in the meanwhile, which support the upgrading process to make it easy to switch to new engine versions.

Another related issue which took like 90 minutes to figure out (probably longer if @yaustar didn't help) because it simply fails silently without any deprecation warning:
We have to change:
vec3 getEmission() {
  return vec3(...);
}

to:
void getEmission() {
  dEmission = vec3(...);
}

Wouldn't it be nice to print a deprecation warning when people still submit shader chunks containing vec3 getEmission?
People trip over these things on Discord and they have no clue what is going on:

I saw a tutorial on how to do it from 2017 and it didn't work for me. Maybe there are newer examples or the engine has changed too much since then?

It doesn't feel good when old projects just slowly decay into non-working states even tho warnings would be easy/obvious to integrate at runtime. Of course these deprecation messages require "extra client work", but what about just putting them in:
        // #if _DEBUG
        ...
        // #endif

?
As a developer I use of course the bigger sized debug build, and the "final" project will see and execute absolutely nothing of these backwards compatibility checks and fixes.

We already have a system in place for this.
The emissive chunk was changed in https://developer.playcanvas.com/en/user-manual/graphics/shader-chunk-migrations/#engine-v157
Your runtime should specify which API version its chunks conform to. We check this at runtime and issue warnings when the API has been updated since then.
For example, if you had specified in your material mat.chunks.APIVersion='1.62' (or left APIVersion blank), then you would have received a warning that emissivePS has been updated.
For interest sake, why didn't you see this warning?

For interest sake, why didn't you see this warning?

I did see the warning, but it's rather useless.

Your runtime should specify which API version its chunks conform to. We check this at runtime and issue warnings when the API has been updated since then.

If every "should" in reality would be actualized, we should have less problems and yet in reality we have older projects like @willeastcott's project: https://playcanvas.com/project/1116002/overview/textmesh-sandbox-2
Fork it, launch it, you see this:

Show that message to 100 devs, I bet nearly no one knows what's going on or waste too much time on it. After like 90 minutes it dawned on me why it actually didn't work by searching through the engine code, but all I really needed would have been one message:
Signature 'vec3 getEmission()' is deprecated, please update your signature to 'void getEmission()' and write the return value into 'dEmission' instead.
If you show that message to 100 devs on Discord, how many will understand it right away?
Such message would be a simple String#includes and has the potenial to make the shader system way easier too use. In terms of runtime overhead and size it's nothing inside a _DEBUG. It would be stripped entirely out of the production builds.

Hey @kungfooman I can just imagine your frustration dealing with this. I'm really sorry you've wasted time tracking down the issues.
I agree we could easily improve that message - probably with link to URL as @mvaligursky suggests.
But yeah sorry, I don't agree that adding checks and greps at runtime for every shader chunk change in future is a good idea (if this is what you're advocating for). It is completely unmanageable longer term and doesn't belong in the engine (but does belong in the editor!)

But yeah sorry, I don't agree that adding checks and greps at runtime for every shader chunk change in future is a good idea (if this is what you're advocating for). It is completely unmanageable longer term and doesn't belong in the engine (but does belong in the editor!)

Sure, I also don't want bloated production builds. I see the point of an editor feature and it would be nice if the editor would help aswell in shader programming. In my particular case, I wouldn't have benefited from the editor feature because I found it as a standalone project on GitHub.
Current situation for backwards compatibility of shaders, using importmaps:
/**
 * @param {string} content
 * @returns {string}
 */
function importFile(content) {
  return "data:text/javascript;base64," + btoa(content);
}
const imports = {
  // Backwards compatibility of shaders
  //"playcanvas": "/playcanvas-engine-pr/src/index.js",
  //"playcanvas": "/playcanvas-engine-pr/build/playcanvas.dbg.mjs/index.js",

  // Lacking backwards compatibility of shaders, use/enable when everything is fixed!
  //"playcanvas": "/playcanvas-engine-pr/build/playcanvas.mjs/index.js",
  "playcanvas": "/playcanvas-engine-pr/build/playcanvas.prf.mjs/index.js",
  //"playcanvas": "/playcanvas-engine-pr/build/playcanvas.min.mjs/index.js",
};
const importmap = document.createElement("script");
importmap.type = "importmap";
importmap.textContent = JSON.stringify({imports});
document.body.appendChild(importmap);


Better handling of string IDs

In the two places where parseInt was being used, instead normalize the
two IDs into strings so they can be compared.
This would close #66 by fixing the two bugs that were brought up in the comments.

Not being able to delete an entity whose ID is a string
Not being able to delete an entity after creating it (as opposed to putting it in the initial data).

If this change gets released, it would save @a-rcrawford the trouble of having to run a custom build of json-graphql-server for the tests he's currently writing. :-)


Table filter indicators not showing in grid mode

Package
filament/tables
Package Version
v2.16.51
Laravel Version
v9.40.1
Livewire Version
v2.10.7
PHP Version
8.1.2
Problem description
When using filters in table with the new grid system, the appled filters doesn't show up as they do when filtering in normal table view.
Show example:
Normal table:

Grid table:

As you may notice, the the filters are applied btu the section where they should be showed doesn't say anything.
Expected behavior
When the filters are applied the counter should show how many filters are being used and display them in the upper secition of the table:
Steps to reproduce
There's an example in the author's resource in the reproduction repository.
public static function table(Table $table): Table
   {
       return $table
           ->columns([
               Grid::make(6)
                   ->schema([
                       Stack::make([
                           TextColumn::make('subject')
                               ->label(__('filament-core::labels.subject'))
                               ->searchable(['subject', 'body'])
                               ->alignLeft(),
                           TagsColumn::make('to')
                               ->separator(','),
                       ])->alignLeft()
                           ->columnSpan(4),
                       Stack::make([
                           TextColumn::make('created_at')
                               ->label(__('filament-core::labels.created_at'))
                               ->date('d.m.Y')
                               ->alignRight(),
                           TextColumn::make('created_at')
                               ->label(__('filament-core::labels.created_at'))
                               ->time('H:i A')
                               ->alignRight(),
                       ])->alignRight()
                           ->columnSpan(2),
                   ]),
           ])
           ->filters([
               Filter::make('to')
                   ->form([
                       TagsInput::make('to')
                           ->label(__('filament-core::labels.email_to'))
                           ->separator(','),
                   ])
                   ->query(function (Builder $query, array $data): Builder {
                       return $query
                           ->when(
                               $data['to'],
                               function (Builder $query, $to): Builder {

                                   foreach ($to as $email) {
                                       $query->orWhere('to', 'like', '%' . Str::lower($email) . '%');
                                   }

                                   return $query;
                               }
                           );
                   }),
               Filter::make('created_at')
                   ->label('filament-core::labels.created_at')
                   ->form([
                       DatePicker::make('created_from')
                           ->label(__('filament-core::labels.created_from')),
                       DatePicker::make('created_until')
                           ->label(__('filament-core::labels.created_until')),
                   ])
                   ->query(function (Builder $query, array $data): Builder {
                       return $query
                           ->when(
                               $data['created_from'],
                               fn (Builder $query, $date): Builder => $query->whereDate('created_at', '>=', $date),
                           )
                           ->when(
                               $data['created_until'],
                               fn (Builder $query, $date): Builder => $query->whereDate('created_at', '<=', $date),
                           );
                   })
           ])
           ->actions([
               DeleteAction::make(),
           ])
           ->bulkActions([
               DeleteBulkAction::make(),
           ]);
   }

Reproduction repository
https://github.com/romaldyminaya/demo
Relevant log output
No response

Since you are using a custom filter you need to specific what the indicators are on your filter with ->indicateUsing().
Relevant docs can be found at https://filamentphp.com/docs/2.x/tables/filters#custom-indicators
Closing as this is not a bug and using the appropriate method in your demo produces the desired results.

Thank you @awcodes ,
Crisp and clear.


Added support for Slack / MS Teams webhooks

I really love this tool and I am sad that this is not included in Docker out of the box. Additionally it would be awesome to also support Slack / MS Teams alerts to notify a developer / operations team that something went wrong.

Tested life in production with Microsoft Teams webhook.

Is this PR ready to be merged?

@willfarrell it should be ready to be merged :)

Can anyone else give this a spin and let me know.

@willfarrell worked for me

This branch did work and I was able to receive a notification, though I wonder if it would be better repurposed to use something generic like Apprise, which could handle passing the notification to any supported service? Apprise has support for Slack, Teams, and Gotify, among others.


Unhandled Exception: Invalid argument(s) Flutter

We using Bloc pattern in our project. In page A, it has a textView and a button. When textView is tapped, it will pass the list to page B. The list will then populate in listView page B.
When the row of listView is clicked, it will pass the selected data back to page A and add it to sink. It works exactly like how the startActivityForResult in Android.
TextField
   StreamBuilder(
                          stream: _bloc.locationListStream,
                          builder: (context, snapshot) {
                            return TextField(
                              onTap: () {
                                _goToPageB(snapshot.data);
                              },
                              style: TextStyle(fontSize: 12.0, height: 1.0),
                              onChanged: (text) =>
                                  _bloc.locationSink.add(text),
                                       .....
                              controller: _locationController,
                            );
                          },
                        ),

void _goToPageB(List locationList) async {
    var results = await Navigator.of(context)
        .push(MaterialPageRoute<dynamic>(builder: (BuildContext context) {
      return PageB(locationList);
    }));

    if (results != null) {
      setState(() {
        _locationController.text = results.name;
      });
      _bloc.locationSink.add(results.id);  // set the returned data to sink
    }
  }

When the button in page A is clicked, it will call submit() in bloc class.We want it print out the value, but we get this error.

E/flutter ( 8944): [ERROR:flutter/lib/ui/ui_dart_state.cc(148)]
Unhandled Exception: Invalid argument(s)

bloc class
  final _location = BehaviorSubject<String>();
  get locationSink => _location.sink;
  get locationStream => _location.stream;

Future submit(
      BuildContext context) async {
    final location = _location.value;
    print('The value is '+location);
 }

Hi @tony123S
This platform is not met for assistance on personal code.
Please see https://flutter.dev/community for resources for asking questions like this,
you may also get some help if you post it on Stack Overflow.
Closing, as this isn't an issue with Flutter itself,
if you disagree please write in the comments and I will reopen it
Thank you


Adds publication "How to use HeurisicLab to optimize a fitness function

Sorry, that it took so long. I think there are some images missing, the PR only adds the Markdown. Do you still have the images?

I forgot to add the images in the original PR, thank you for reminding me! They should be included now.

Thank you, Max!


play() fails on Chrome in Android

The following error is thrown after a .load() and .play() sequence:
Failed to execute 'play' on 'HTMLMediaElement': API can only be initiated by a user gesture.
Looks like chrome secured against auto-playing.
Can we work a workaround here?
Some inspiration here: https://foolip.org/2014/02/10/media-playback-restrictions-in-blink/demo.html

Can be easily worked around by calling audio element's .click() in the ng-click, for example


Allow decorating of services in the container

I started to try to implement this but I dont really understand how the internals are working right now. My Idea was to add another Option to di which is called Decorate.
package main

import (
	"fmt"

	"github.com/goava/di"
)

func main() {
	container, err := di.New(
		di.Provide(NewExample),
	)
	if err != nil {
		panic(err)
	}

	container.Invoke(func(e Example) {
		fmt.Println(e) // Will print "Example"
	})

       err = container.Decorate(DecorateExample)
       if err != nil {
		panic(err)
	}

	container.Invoke(func(e Example) {
		fmt.Println(e) // Will print "Example is now Decorated"
	})
}

type Example string

func NewExample() Example {
	return "Example"
}

func DecorateExample(e Example) Example {
	return e + " is now Decorated"
}

This can also be expaned to have options like priority to allow ordered decorations. Of course this only works when the decorated type isnt used before decoration. So you would have to call Decorate before Invoking anything.

@erickskrauch I changed the Name of the issue to make it more clear :D

Closed as unnecessary.

Would you accept a PR if I implement it? This is crucial for a plugin system I currently implement

@fionera For reference type modifying you can use Invoke(). Is this necessary for non-reference types?

No I would only use it for Interfaces but I want the possibility to get the previous instance from the container

func DecorateInterface(iface MyInterface) {
  // some stuff
}

di.Invoke(DecorateIterface)

Is this method not suitable?

Yes thats basically what I mean :) I attached an example on how I would use it. This way I can modify the implementation of a function of an interface without knowing the implementation itself. Symfony calls this System "Decorating" https://symfony.com/doc/current/service_container/service_decoration.html
type Test interface {
	MyFunc() string
}

type t1 struct{}

func NewT1() *t1 {
	return &t1{}
}

func (t *t1) MyFunc() string {
	return "t1"
}

type t2 struct {
	t Test
}

func NewT2(t Test) *t2 {
	return &t2{t}
}

func (t *t2) MyFunc() string {
	return t.t.MyFunc() + " t2"
}

func main() {
	container, err := di.New(
		di.Provide(NewT1, di.As(new(Test))),
		di.Provide(NewT2, di.As(new(Test))),
	)
	if err != nil {
		logrus.Fatal(err)
	}

	err = container.Invoke(func(test Test) {
		logrus.Info(test.MyFunc())
	})
	if err != nil {
		logrus.Fatal(err)
	}
}

Why is Decorate provided as ProvideOption? This looks more like Callback than Decorate.
Actually I'm also wondering why Decorate is needed, it's just like dosth after Resolve ?
Compared with Decorate, I actually hope to have Replace, so that I can replace certain elements in the middle of Invoke => Invoke, such as context.Context.


Flask python manage.py shell equivalent in Fastapi

Is there any equivalent approach for accessing fastapi application from IPython shell context?
Like we use python manage.py shell in flask?

are you referring to https://flask-script.readthedocs.io/en/latest/?  Which looks like it was supplanted by https://flask.palletsprojects.com/en/1.1.x/cli/
Can you use the issue template when creating new issues?
What is it that you are trying to do?

are you referring to https://flask-script.readthedocs.io/en/latest/?  Which looks like it was supplanted by https://flask.palletsprojects.com/en/1.1.x/cli/
Can you use the issue template when creating new issues?
What is it that you are trying to do?

@tiangolo registered fastapi-cli on PyPi, so maybe he's planning something around it. :smiling_imp:
We have what we (@ycd) developed on manage-fastapi, is that enough?

@tiangolo registered fastapi-cli on PyPi, so maybe he's planning something around it. :smiling_imp:
We have what we (@ycd) developed on manage-fastapi, is that enough?

Have been looking into this also. One of the great benefits of Flask I have found is the interactive shell for testing and creating models, etc. https://flask.palletsprojects.com/en/1.1.x/cli/.
I am just starting with Fastapi so not sure yet if there are any limiting factors in creating a similar experience.

Have been looking into this also. One of the great benefits of Flask I have found is the interactive shell for testing and creating models, etc. https://flask.palletsprojects.com/en/1.1.x/cli/.
I am just starting with Fastapi so not sure yet if there are any limiting factors in creating a similar experience.

Hello,
I do not know the idea of the @tiangolo  about how the cli will be.
As I'm using it in all my jobs, I'm getting up with some people to set up a cli to work on top of a cookiecutter that I set up with a colleague at work.
https://github.com/jonatasoli/fastapi-template-cookiecutter
The idea was to have these features:

create a new project
create a new subapp (see the cookiecutter)
run tests
run migrations with the versioning message
apply migrations
Run endpoints at the client level
rotate the prospector
generate coverage
Generate the orphans report
Show all routes that have been implemented

I know that there are very specific things in my template, but maybe it was possible to generate a version with the more general features and generate an extension of the general cli with the specific features of my template.

any update on this issue??

As a workaround you can do this, https://stackoverflow.com/a/70604378/7699859 .

I'm starting a client lib to fastapi when is minimal functional I check to send PR.
https://github.com/jonatasoli/fastcli

Would love to see this happen. Coming from a Flask background, having an interactive shell that has access to the whole application is very handy.

I'm start a PR but I was convinced that this is not a good option for fastapi, in flask it has only one server which is Werkzeug where it is totally dependent. In fastapi you have the freedom to use whatever server you want, which makes it impossible to make a cli to access the application, so I think this question can even be closed.

I think the really useful feature  a FastAPI shell could provide is resolving dependencies.
For example imagine some class with FastAPI dependencies declared in their init (like, a db connection pool etc), that are themselves cumbersome to initiate.
It would be SUPER useful to be able to enter a repl/shell and initialise this client and have its dependencies resolved in the shell (instead of manually passing them in).
Obviously some finer details like, what do if one of the dependencies is a Request or Header would need to be worked out.

I tried this
https://ipython.readthedocs.io/en/stable/api/generated/IPython.html#IPython.start_ipython
import os, sys, threading, IPython

if os.isatty(sys.stdin.fileno()) and os.isatty(sys.stdout.fileno()):
    threading.Thread(target=IPython.start_ipython).start()

# uvicorn.run only works in main thread
uvicorn.run( # ...

in ipython shell. example
await database.fetch_all(table_x.select())

Not enough ?

Thanks for the discussion everyone!
So, it seems this discussion involves several different things, all around CLI apps, but for different purposes. I'll focus on the original issue.
The manage.py described seems to be useful for interacting with mock data that would help simulate the internals of Flask, right? Because it wouldn't be handling an actual HTTP request, but just simulating data.
I see this would be useful in Flask, that it has a magical pseudo-global request object and a g variable, etc. But I don't see how it would really be useful in FastAPI, where everything is just pure code that you can call directly as a function, without needing to have a special type of shell.
If you need to interact with a request object directly, and if you need to see how it behaves, you can actually just create the object in a normal shell, you don't really need a special FastAPI shell or CLI for that.
Now, if you want to debug and explore your code, I would find it much easier and useful to use an integrated debugger: https://fastapi.tiangolo.com/tutorial/debugging/
Also, most of your code would actually be independent of FastAPI. There's no config in the FastAPI app, the docs even recommend using Pydantic directly. You could create instances of the Pydantic models directly. FastAPI doesn't depend on any particular database, so you can use whatever database you want directly, etc.
VS Code and PyCharm both have now pre-configured debuggers for FastAPI, you can put breakpoints, see variable values, execute code in the middle of an actual request, etc.
What use case would a custom shell solve or satisfy better than an integrated debugger in an editor?

About other possible uses for a FastAPI CLI, I have been waiting to see if there's something that could be solved by that that would justify it.
Here's how I think about it and approach it. When there's something that I could build, a CLI, a library, etc. that would normally use/wrap other tools underneath in some way, if learning and using the new tool I build is comparable to learning and using the tools underneath, I prefer to instead teach those tools underneath.
For example, I didn't add things to FastAPI to handle passwords, when they would just wrap passlib, instead I prefer to teach how to use passlib directly.
In many cases, having a CLI that generates code, would require learning the CLI commands, arguments, options, capabilities, etc. And passing almost all the details that you would put in code as parameters. The intention with the design of FastAPI was to remove as much code duplication as possible. That means that there's not much boilerplate. And if the little code that you would write by hand, with an editor that can provide you with autocompletion, syntax errors, etc, you have to pass it as values to parameters in a CLI, then I would think the effort is equivalent, and I would rather just teach people how to write that little code.
Another idea would be to wrap Uvicorn, but again, that would mean people would have to learn how to use this new CLI when they could instead learn how to use Uvicorn. So I prefer to teach how to use Uvicorn instead.
It's also because in these cases it would be easy for people to have to learn this new tool, but then also have to learn the thing underneath, and then they just had to put double the effort in the end, with no real benefit.
When I find something that I consider would save users a lot of time, or would improve code quality, developer experience, etc. then I end up writing that tool. That was the case with Typer, SQLModel, and Asyncer. And actually with FastAPI as well. I avoided building them as much as possible, until I thought that to get those benefits it was unavoidable to build a new tool.

On the other hand, there are many useful valid projects that can work as a CLI, for example, these multiple project generators with different flavors mentioned here. I even have one too. But I would think that it would be a more opinionated thing and more related to a particular type of project than being very specific to FastAPI as a CLI.
Anyway, just a bunch of thoughts, and why I haven't made an official FastAPI CLI. In short, I haven't found yet something that justifies a FastAPI CLI existing. :sweat_smile:

👍 My use case about a CLI for resolving dependencies above was for a hypothetical situation on a prod server when you need to debug something but where you may not be able to attach a debugger.
But I think your stance is solid, I also can't think of a good "CLI UX" that deals with the problem that Dependencies sometimes need actual requests to instantiate, so I no longer have a good use case for a FastAPI (currently) 😁

(sorry I just realised that my comment automatically removed the answered label: apologies)

Hehe, no worries, thanks for the feedback @adamserafini ! ☕

In case it helps someone, here is what I'm doing to get a shell, in a fastapi "context" (separate tho), async (you can await things)..
Embedding the whole thing so you see how it can be used, you will need to customize it for your env.
Just save this in it's own file, and remember to install ptpython
#!/usr/bin/env python3

"""
Everything imported and defined in this file will be available in the shell.

We use ptpython instead of ipython because ipython doesnt really have any good
ways to being embedded the way we want.
"""

from ptpython.repl import embed

from backend.services.rabbit.lifetime import init_rabbit, shutdown_rabbit
from backend.services.redis.lifetime import init_redis, shutdown_redis
from backend.db.config import database

from backend.db.models.app_model import *

import asyncio

loop = asyncio.get_event_loop()

async def setup():
    await database.connect()

    try:
        await embed(globals=globals(), return_asyncio_coroutine=True, patch_stdout=True)
    except EOFError:
        loop.stop()

def main():
    asyncio.ensure_future(setup())
    loop.run_forever()
    loop.close()

if __name__ == "__main__":
    main()


Payload size causes weird performance variance

as the snapshot shows, when using load_test code from example with different payload size, got a very strange performance variance. I don't know what causes it but I think a 10KB payload should be the real use case instead uWebsocket's load_test default 1MB payload size.

server flamegraph when payload size is 16KB (above) and 160KB (below).

Sorry for the confusing example of load test in the examples, this example is intended to be improved after the simd and deflate features are implemented, so it is only a semi-finished product and cannot be used in performance testing. If you want to do a load test, I recommend the load_test program in uWebSocket, you can modify your own payload size and number of clients to simulate different loads

I found out it was because some tokio scheduler issue cause the stuck. this pr can get right result but some time it still stuck...

If I increase the payload number, it becomes slower and slower, pretty weird...

Sorry for the confusing example of load test in the examples, this example is intended to be improved after the simd and deflate features are implemented, so it is only a semi-finished product and cannot be used in performance testing. If you want to do a load test, I recommend the load_test program in uWebSocket, you can modify your own payload size and number of clients to simulate different loads

btw, if i use uWebSockets load_test, when payload small than 64KB it's still stuck.
seem is something wrong with my system (Linux 5.15.0-56-generic #62-Ubuntu )...

when payload is less than 64kb, I stuck too, it seems like a limit of uWebSocket load test

After lunch time I will write a sync load test use multi thread, it may take some times.

Sorry for the confusing example of load test in the examples, this example is intended to be improved after the simd and deflate features are implemented, so it is only a semi-finished product and cannot be used in performance testing. If you want to do a load test, I recommend the load_test program in uWebSocket, you can modify your own payload size and number of clients to simulate different loads

btw, if i use uWebSockets load_test, when payload small than 64KB it's still stuck.
seem is something wrong with my system (Linux 5.15.0-56-generic #62-Ubuntu )...

please run git pull and try new load_test example

new sync version load_test work as expect.

tungstenite-rs is faster in 16KB load_test in my machine. bench_tungstenite 32204.095 vs bench_async_server 28720.104 vs bench_server_split 26821.550

That's wired,  tungstenite example unwrap recv result while bench_server and bench_async_server will check recv result, if i remove check code and unwrap them like tungstenite example. ws-tools is faster.
load test options --conn 1 -n 50000 -p 16
my bench result
tungstenite: 27535.843
bench_server: 29187.466
bench_async_server: 28784.453
tungstenite:

    loop {
        let (stream, addr) = listener.accept().unwrap();
        stream.set_nodelay(true).unwrap();
        std::thread::spawn(move || {
            tracing::info!("got connect from {:?}", addr);
            let mut ws = tungstenite::accept(stream).unwrap();
            loop {
                if let Ok(msg) = ws.read_message() {
                    if msg.is_close() {
                        break;
                    }
                    ws.write_message(msg).unwrap();
                } else {
                    break;
                }
            }
            tracing::info!("one conn down");
        });
    }

I changed tungstenite example to check recv result it still got ~32000+
Running `target/release/examples/load_test 'ws://<IP_ADDRESS>:9000' -c 1 -p 16 -n 50000`
2022-12-10T07:48:56.267408Z  WARN ws_tool::blocking: setting tls cert has no effect on insecure ws
[000 - OK] 32631.024

what's your benchmark machine and ip network kernel setting?

Intel Xeon Gold 6230 (80) @ 2.1GHz
force_latency=cstate.id:1|3
governor=performance
energy_perf_bias=performance
min_perf_pct=100
kernel.sched_min_granularity_ns=3000000
kernel.sched_wakeup_granularity_ns=4000000
vm.dirty_ratio=10
vm.dirty_background_ratio=3
vm.swappiness=10
kernel.sched_migration_cost_ns=5000000
net.core.busy_read=50
net.core.busy_poll=50
net.ipv4.tcp_fastopen=3
kernel.numa_balancing=0
cmdline_network_latency=skew_tick=1
net.ipv4.ip_forward=1
net.core.default_qdisc=cake
net.ipv4.tcp_congestion_control=bbr
net.ipv4.tcp_slow_start_after_idle=0
net.ipv4.tcp_notsent_lowat=16384

8KB payload result:
bench_server: 33021.222
bench_server_split: 32834.431
bench_tungstenite: 39017.241
bench_async_server: 33839.912

8KB payload bench_server (above) and bench_tungstenite (below) flamegraph.

It seems that ws-tool can operate buffered writer/reader when the payload is small, instead of directly operating the raw tcpstream, but this may cause higher latency, which needs more profiles to be sure. Perhaps it is possible to change the S in WsStream from tcpstream to BufferedStream without changing any code, which can be implemented in the factory function of the accept/connect function params


[MB-3963] Change comparison of Postgres error strings to error codes

Description
As part of the Pop v5 upgrade, the underlying Postgres driver is changing from lib/pq to jackc/pgx.  Because the driver is changing, the error strings returned by the driver are also changing.  We have some cases where we compare against explicit strings to validate a DB error, so those need to be altered.  But rather than just change the string to another hard-coded string literal, this PR introduces error codes from jackc/pgerrcode and compares against them instead, which should be less brittle.  We also use the pgconn.PgError error struct to pull out specific table and/or constraint names as well and test against them if appropriate.
For more info about the error checking strategy, see this Wiki page.
Reviewer Notes

Note that this PR is requesting a merge into rr-MB-2467-pop5 (the long-running branch for the Pop upgrade), not into master. Eventually we will merge the long-running branch into master after all tests are passing.
There are a few error string comparisons in pkg/migrate and pkg/services/dbtools that I didn't change yet (you'll see a TODO, however).  These will be revisited as part of the next story for this feature where we rework the current lib/pq dependency in this code.
I noticed that we have 20 or so cases of comparisons against a sql: no rows in result set string that we already have a models.RecordNotFoundErrorString constant to represent, so I remapped those.  Note that this particular DB error doesn't originate from the driver, but instead from ErrNoRows in Go's database/sql package.  In fact, we could probably simplify all comparisons to RecordNotFoundErrorString to instead do direct comparison against ErrNoRows instead, but I didn't want to add all of those changes to this PR/feature.

Setup

make server_test
Verify that all tests complete without any DB error string issues.
Note that you will still see errors in the packages below for now.  I believe these are all issues caused by the direct lib/pq COPY FROM functionality that we will be refactoring to use the jackc/pgx variant in the next story.

github.com/transcom/mymove/pkg/migrate
github.com/transcom/mymove/pkg/parser/pricing
github.com/transcom/mymove/pkg/services/dbtools

Code Review Verification Steps

[ ] Request review from a member of a different team.
[ ] Have the Jira acceptance criteria been met for this change?

References

Jira story for this change

Messages

:book:
:link: MB-3963

  Generated by :no_entry_sign: dangerJS against bcdefdc4901dec27f1002f7971ce53fc60f90e8f

@reggieriser it's hanging for me after the github.com/transcom/mymove/pkg/paperwork test. I will try again on Monday

@reggieriser it's hanging for me after the github.com/transcom/mymove/pkg/paperwork test. I will try again on Monday

It's the github.com/transcom/mymove/pkg/parser/pricing package that comes after paperwork that's the problem.  I thought it was hung too, but it will eventually finish -- it's getting stuck in a goroutine that will eventually timeout after 10 minutes (I think) and let the tests proceed.  I believe this is related to the COPY FROM stuff that needs to be changed in the next story since the pricing package uses that as well.

I decided to add some helper methods and abstract out the DB error checks to better isolate the specific error type dependency (so we can switch drivers easier during this migration).  Also makes things a little more DRY.  @pearl-truss , could you please re-review?

I decided to add some helper methods and abstract out the DB error checks to better isolate the specific error type dependency (so we can switch drivers easier during this migration). Also makes things a little more DRY. @pearl-truss , could you please re-review?

@reggieriser I just re-ran the server test and everything still looks good


Update JSFiddle template to use latest versions of Draft & React + Hooks

Summary
Closes https://github.com/facebook/draft-js/issues/1737. Updates the JSFiddle template for reporting issues to use the latest versions of Draft.js, React, ReactDOM, and changes the example to use Hooks.
Test Plan
Head to https://jsfiddle.net/dougmacknz/b5tukezn/

@niveditc done :)

Hi Doug, thanks for this PR! There was an issue on FB side about syncing files on .github folder. This is why this PR couldn't get merged. The issue is fixed now. However, we updated the fiddles on #2145. I'm closing this one. Thanks again!


bootstrap.sh is not enough

I ran bootstrap.sh as the README indicates and it seems to have worked as intended. If I look at Symbals/Configuration/Local/DevTeam.xcconfig it shows the correct LOCAL_DEVELOPMENT_TEAM, anyway.
However building for devices fails because Xcode still tries to use the wrong development team. It's necessary to change the team in Xcode too, because Xcode still wants to use the team found in the project file.

Changing the team in Xcode fixes the issue and the app builds. This is with Xcode 11.2.1 (11B53).

I've possibly misconfigured something as it should automatically switch, I'll dig into this when I get a chance and see.

@atomicbird The latest push should have fixed this.

That changes the error but bootstrap.sh still isn't doing it for me. I did a fresh clone and then did this:
sh bootstrap.sh
Creating 'Local' directory
Choose your developer team that you wish to sign SF Viewer with:
1) iPhone Developer: Tom Harrington (VC7282VPMT)
2) Apple Development: Tom Harrington (VC7282VPMT)
3) Apple Development: Tom Harrington (ELDFJKP8FN)
4) Quit
#? 1
You selected 'iPhone Developer: Tom Harrington (VC7282VPMT)' as your developer team, we've written this to 'Symbals/Configuration/Local/DevTeam.xcconfig'

So far so good. But Xcode's still not happy.

Digging a little deeper, VC7282VPMT is what bootstrap.sh finds, but does not match what I see when I log in to my Apple developer account. It's not a different team, though, because I can replace the end of the URL with VC7282VPMT and the developer site shows me the same team. It's as if I have two different team IDs and Xcode only likes the one that bootstrap.sh can't find. If I try security find-identity -v -p codesigning, the results do not include the team ID shown at Apple's developer site.
This might be an unusual or unique situation. I don't know what to make of it.


YARN-9468:Fix inaccurate documentations in Placement Constraints

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
36
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

_ trunk Compile Tests _

+1
mvninstall
1066
trunk passed

+1
mvnsite
19
trunk passed

+1
shadedclient
1705
branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1
mvninstall
11
the patch passed

+1
mvnsite
17
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
735
patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1
asflicense
26
The patch does not generate ASF License warnings.

2623

Subsystem
Report/Notes

Docker
Client=18.09.8 Server=18.09.8 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-717/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/717

JIRA Issue
YARN-9468

Optional Tests
dupname asflicense mvnsite

uname
Linux d3dbdee570b3 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 10:58:50 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 6282c02

Max. process+thread count
412 (vs. ulimit of 5500)

modules
C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-717/1/console

versions
git=2.7.4 maven=3.3.9

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
135
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

_ trunk Compile Tests _

+1
mvninstall
1343
trunk passed

+1
mvnsite
22
trunk passed

+1
shadedclient
2118
branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1
mvninstall
14
the patch passed

+1
mvnsite
20
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
799
patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1
asflicense
26
The patch does not generate ASF License warnings.

3226

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-717/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/717

JIRA Issue
YARN-9468

Optional Tests
dupname asflicense mvnsite

uname
Linux 2bb965e54e85 4.15.0-48-generic #51-Ubuntu SMP Wed Apr 3 08:28:49 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / c0a0c35

Max. process+thread count
341 (vs. ulimit of 5500)

modules
C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-717/2/console

versions
git=2.7.4 maven=3.3.9

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
63
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

_ trunk Compile Tests _

+1
mvninstall
1105
trunk passed

+1
mvnsite
19
trunk passed

+1
shadedclient
1797
branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1
mvninstall
15
the patch passed

+1
mvnsite
15
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
769
patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1
asflicense
28
The patch does not generate ASF License warnings.

2793

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-717/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/717

JIRA Issue
YARN-9468

Optional Tests
dupname asflicense mvnsite

uname
Linux 56fa216f37f9 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / e20b195

Max. process+thread count
412 (vs. ulimit of 5500)

modules
C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-717/3/console

versions
git=2.7.4 maven=3.3.9

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
50
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

_ trunk Compile Tests _

+1
mvninstall
1076
trunk passed

+1
mvnsite
21
trunk passed

+1
shadedclient
1717
branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1
mvninstall
10
the patch passed

+1
mvnsite
16
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
733
patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1
asflicense
27
The patch does not generate ASF License warnings.

2654

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-717/4/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/717

JIRA Issue
YARN-9468

Optional Tests
dupname asflicense mvnsite

uname
Linux b2ebcede66ac 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 10:58:50 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 70b4617

Max. process+thread count
466 (vs. ulimit of 5500)

modules
C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-717/4/console

versions
git=2.7.4 maven=3.3.9

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
82
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

_ trunk Compile Tests _

+1
mvninstall
1327
trunk passed

+1
mvnsite
27
trunk passed

+1
shadedclient
2161
branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1
mvninstall
14
the patch passed

+1
mvnsite
23
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
941
patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1
asflicense
30
The patch does not generate ASF License warnings.

3355

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-717/5/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/717

JIRA Issue
YARN-9468

Optional Tests
dupname asflicense mvnsite

uname
Linux b82f20126ec9 4.15.0-48-generic #51-Ubuntu SMP Wed Apr 3 08:28:49 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 397a563

Max. process+thread count
307 (vs. ulimit of 5500)

modules
C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-717/5/console

versions
git=2.7.4 maven=3.3.9

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
34
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

_ trunk Compile Tests _

+1
mvninstall
1213
trunk passed

+1
mvnsite
23
trunk passed

+1
shadedclient
2018
branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1
mvninstall
11
the patch passed

+1
mvnsite
17
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
844
patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1
asflicense
30
The patch does not generate ASF License warnings.

3050

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-717/6/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/717

JIRA Issue
YARN-9468

Optional Tests
dupname asflicense mvnsite

uname
Linux 5177e514a60f 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 10:55:24 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / e356e4f

Max. process+thread count
308 (vs. ulimit of 5500)

modules
C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-717/6/console

versions
git=2.7.4 maven=3.3.9

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
88
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

_ trunk Compile Tests _

+1
mvninstall
1260
trunk passed

+1
mvnsite
21
trunk passed

+1
shadedclient
2050
branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1
mvninstall
15
the patch passed

+1
mvnsite
18
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
879
patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1
asflicense
31
The patch does not generate ASF License warnings.

3186

Subsystem
Report/Notes

Docker
Client=19.03.0 Server=19.03.0 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-717/7/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/717

JIRA Issue
YARN-9468

Optional Tests
dupname asflicense mvnsite

uname
Linux b72af7d49fe2 4.15.0-52-generic #56-Ubuntu SMP Tue Jun 4 22:49:08 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 094d736

Max. process+thread count
334 (vs. ulimit of 5500)

modules
C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-717/7/console

versions
git=2.7.4 maven=3.3.9

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
63
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

_ trunk Compile Tests _

+1
mvninstall
1036
trunk passed

+1
mvnsite
19
trunk passed

+1
shadedclient
1701
branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1
mvninstall
13
the patch passed

+1
mvnsite
14
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
759
patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1
asflicense
27
The patch does not generate ASF License warnings.

2663

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-717/8/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/717

JIRA Issue
YARN-9468

Optional Tests
dupname asflicense mvnsite

uname
Linux 4667e3873e93 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 69ddb36

Max. process+thread count
412 (vs. ulimit of 5500)

modules
C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-717/8/console

versions
git=2.7.4 maven=3.3.9

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
39
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

_ trunk Compile Tests _

+1
mvninstall
1151
trunk passed

+1
mvnsite
25
trunk passed

+1
shadedclient
1908
branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1
mvninstall
14
the patch passed

+1
mvnsite
19
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
731
patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1
asflicense
31
The patch does not generate ASF License warnings.

2844

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-717/9/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/717

JIRA Issue
YARN-9468

Optional Tests
dupname asflicense mvnsite

uname
Linux 15bc56f1d87d 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 3329257

Max. process+thread count
413 (vs. ulimit of 5500)

modules
C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-717/9/console

versions
git=2.7.4 maven=3.3.9

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
54
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

_ trunk Compile Tests _

+1
mvninstall
1319
trunk passed

+1
mvnsite
23
trunk passed

+1
shadedclient
2119
branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1
mvninstall
14
the patch passed

+1
mvnsite
19
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
896
patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1
asflicense
33
The patch does not generate ASF License warnings.

3249

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-717/10/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/717

JIRA Issue
YARN-9468

Optional Tests
dupname asflicense mvnsite

uname
Linux 0655a12d5957 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 915cbc9

Max. process+thread count
438 (vs. ulimit of 5500)

modules
C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-717/10/console

versions
git=2.7.4 maven=3.3.9

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 36s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
@author
0m  1s
The patch does not contain any @author tags.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
20m 50s
trunk passed

+1 :green_heart:
mvnsite
0m 27s
trunk passed

+1 :green_heart:
shadedclient
35m 53s
branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 12s
the patch passed

+1 :green_heart:
mvnsite
0m 17s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
shadedclient
14m  8s
patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
asflicense
0m 30s
The patch does not generate ASF License warnings.

53m  7s

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-717/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/717

JIRA Issue
YARN-9468

Optional Tests
dupname asflicense mvnsite

uname
Linux 881a88962a33 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / e756fe35909

Max. process+thread count
414 (vs. ulimit of 5500)

modules
C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-717/3/console

versions
git=2.17.1 maven=3.6.0

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
1m 12s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
44m 15s

trunk passed

+1 :green_heart:
mvnsite
0m 46s

trunk passed

+1 :green_heart:
shadedclient
70m 28s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 18s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
mvnsite
0m 28s

the patch passed

+1 :green_heart:
shadedclient
25m 43s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
asflicense
0m 51s

The patch does not generate ASF License warnings.

100m 20s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-717/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/717

JIRA Issue
YARN-9468

Optional Tests
dupname asflicense mvnsite codespell detsecrets

uname
Linux 7b5d1fd157e1 4.15.0-175-generic #184-Ubuntu SMP Thu Mar 24 17:48:36 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / afdc1d1e3a1a77ed8e52ef0eb8cdab2e2132811e

Max. process+thread count
531 (vs. ulimit of 5500)

modules
C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-717/1/console

versions
git=2.25.1 maven=3.6.3

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.


Add composer-normalize

Q
A

QA
yes

Adds ergebnis/composer-normalize as a composer global dependency
Links the composer-normalize bin to /usr/local/bin/composer-normalize

@boesing
Please remember we do not want any further normalization, this was already done during migration from the Zend packages.

@froschdesign So we might close this PR? 🤷🏼♂

@boesing yes, that is correct


Addition of new peer org shouldn’t have a dependency on the orderer.

Is your feature request related to a problem? Please describe.
Addition of new peer org shouldn’t have a dependency on the orderer (fabric 2.5) since the channel creation is an independent operation.
Describe the solution you'd like
Users should be able to bootstrap a new org without orderer details in the network.yaml.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Fabric 2.5

Revisit once the standalone helm chart for fabric is complete


support for Anchors in buildUrl function

Description
Currently, the buildUrl function lacks support for appending an anchor (#) to the generated URL.
Proposed Usage
The proposed enhancement would allow users to specify an anchor parameter in the buildUrl options, resulting in a URL with a hash fragment pointing to the specified anchor.
Example
Here is an example of the desired usage:
const origin = "http://localhost:5000"
const url = buildUrl(origin, {
    paths: ['abc', 'pqr'],
    anchor: {
        anchor1: 'y',
    },
}).href;

Expected Output
http://localhost:5000/abc/pqr#anchor1=y
Additional Context
In some cases, third-party services like Twilio require URLs with anchors for callback requests. For example, Twilio’s webhook configuration allows URL fragments (anchors) to specify connection overrides. You can find more information and examples in the Twilio Webhooks documentation.
Let me know if there’s anything I can do to help clarify the requirements or contribute to this enhancement!

Are you referring to the hash? That is supported.

Are you referring to the hash? That is supported.

Currently, the hash property only accepts a string type. However, I would like hash to accept an object so we can provide key-value pairs for anchor parameters.
For example, to construct a URL like https://example.com/foo?query=123#ct=1000&rt=1000 (from Twilio's webhook connection overrides documentation):
Current experience:

buildUrl("https://example.com", {
        paths: [
            'foo',
        ],
        search: {
          query: 123
        },
        hash: 'ct=1000&rt=1000',
    }).href;

Expected experience:

buildUrl("https://example.com", {
        paths: [
            'foo',
        ],
        search: {
          query: 123,
        },
        hash: {
          ct: 1000,
          rt: 1000
        },
    }).href;

Ah, I see what you mean. That is not the appropriate use case for the hash property, it's mean to be used to reference a specific header on a page (for jumping to the header).
Historically the hash property was used as a replacement for SPA routing in browsers that didn't support the history API, but those days are long gone. Twilio's behavior that you mentioned is quite strange.
For the moment I'm going to close this as not planned, because it's not a standard use case for the hash property.


docs(readme): mention vim-plug with init.vim

Sorry for the late response; the README.md is already feeling somewhat cluttered, and vim-plug using two different languages for its setup here doesn't really help. This would be good to include when README.md grows to be more comprehensive and a proper table of contents etc. is introduced


In C#, how can I set the background colour of the document from white to another colour?

Do I need to use interop for this? If so, why doesn't ScintillaNET have this basic functionality built in?
Implementation of how to go about this would be appreciated.
I found this, but it's only C based:
http://stackoverflow.com/questions/12310144/how-to-change-the-editors-background-color-with-scintilla

The Default style BackColor determines the control background color. The equivalent ScintillaNET code for the C-code you linked would be:
scintilla.Styles[Style.Default].BackColor = Color.Pink;

Since I have a multitude of foreground colour styles, unfortunately, changing the Background colour like this doesn't affect the small block of colour behind each character. I know I can create a whole new set of styles with and without the new background colour, but it would be quicker to code (and to run) if one were able to change the background colour independently. Any way through interop per chance?

The quickest way to do what you want would be:
scintilla.Styles[Style.Default].BackColor = Color.Pink;
scintilla.StyleClearAll();

The StyleClearAll method applies the current Default style properties to all styles. Call this before you set your other styles and they will all start with a BackColor of pink.
There is no other, faster option--interop or otherwise.


Windows you can use w32 instead of cgo....

You can load windows API for all of the work you are doing for windows. This would make it more Pure-Go.
Check out github.com/AllenDang/w32 its a great package with almost everything.

Ok,Thank you for your suggestion,I will add it in future

But in linux and Mac OS X can't find someone,so don't add it.


Implement floating share link on homepage and choice pages

As the user scrolls down the homepage and choice pages on desktop, the earth icon should pop out from the bottom right corner, then a speech bubble with a call to action button appears. It links to the #share section.

[ ] Homepage should say - Share this site
[ ] Choice pages should say - Share this page

Bonus points:

[ ] Bring the earth icon to life by having it rotate a bit and expand/shrink as it pops in
[ ] Have it move a bit and its expression change when the action is pressed
[ ] Have its facial expression change as you scroll down the page

@ThePaulMcBride @barrymcgee @mattbudde
I've implemented this on the homepage and choice pages statically. I tried to get a bit of JS to work that makes it only appear once you've only scrolled down a couple of hundred pixels but couldn't get it to work. JS is not my bag :(
If anyone feels like looking into that bit at some point would be great thanks!


Is this Repo a Joke?!

Realy, why when i got "1","=","1" in my tags, output function gives me - ["1","="] ?
Why when i have duplicated tags (official feature) like 1 and 1, removing any of them removes them all?
Why when typing tags in order - "xxx","=","1","1" in output i have - ["1","=","xxx"] ?
Are you hacking kidding me? Why that stuff has >2,200 stars on github omg? :angry:

Why not fix the issue and contribute it to all the users? If still in rage, read the license more carefully, is explicitly states that

THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS
FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.

I'm not agree with your vision of situation, but appreciate your sensible response. Sounds really calm, isn't it? :smoking:

A better question is this repo still active? Last update was in October

Worse yet, you can't view forks.

Repo is not a joke. The plugin works really well, just follow the instructions. The project doesn't look like it's being supported any more so if you have an issue you can either go to stack overflow, fix it yourself or find something else to use instead of complaining. Have a bit of respect for the guys who initially created the plugin instead of moaning, we're all developers at the end of the day and as a community we rely on each other for support, if you don't understand that then you're in the wrong game...


In Ruby, subclass BadStatus to create an exception hierarchy

The API review noted that handling different statuses by doing control flow based on instance variables is awkward. It would be more user friendly to have a subclass of BadStatus for each status code. This can be done in a backwards compatible way.

addressed by https://github.com/grpc/grpc/pull/8879, this will be in the next release


plugin examples: fix plugin base _fireDataUpdated #1491

Type of PR: Plugin examples bugfix
PR checklist:

[x] Addresses an existing issue: fixes #1491

Overview of change:
_fireDataUpdated within plugin-examples/src/plugins/plugin-base.ts wasn't correctly bound to the instance, and thus the data update notifications weren't being correctly sent to the plugin instance.
The session highlighting example has been updated to include simulated streaming data as a test case.

On second thought, it is a bit strange to add simulated real-time updates to the session highlighting example since it is showing daily bars. So probably better to remove the changes made to plugin-examples/src/plugins/session-highlighting/example/example.ts.


building C++ ARM with C DSPAL

This is only loosely related to quest-fw.
The F' build system is rather difficult to parse. I can successfully build a C ARM / C DSPAL project using qurt_bundle. I would like to build a C++ ARM / C DSPAL project (like BlspI2CDriver).
Questions:

Is DspRelay/CMakeLists.txt being used? It's the only place where qurt_bundle is being used, but it seems like it is missing many of the *_relay.c drivers.
Where are SRC_DSPAL and SRC_SDFLIGHT used? From a find all, it looks like they are only defined -- I'm guessing there is a script somewhere that uses these to automatically detect new targets?

This is only loosely related to quest-fw.
The F' build system is rather difficult to parse. I can successfully build a C ARM / C DSPAL project using qurt_bundle. I would like to build a C++ ARM / C DSPAL project (like BlspI2CDriver).

Yes - the core F' team is working on switching over to CMake. In the meantime, the build system is a mix of Python scripts and GNU makefiles. Probably only worth learning if you intend to build inside F'. In this particular case, you can split the driver across the FastRPC calls. Just replicate the calls to the dsp_relay_* functions in whatever software stack you want to use it in.

Questions:

Is DspRelay/CMakeLists.txt being used? It's the only place where qurt_bundle is being used, but it seems like it is missing many of the *_relay.c drivers.

That file is not being used at present - I may have done an experiment in building using CMake at some point in the past.

Where are SRC_DSPAL and SRC_SDFLIGHT used? From a find all, it looks like they are only defined -- I'm guessing there is a script somewhere that uses these to automatically detect new targets?

The F' make system does different things depending on if you are building a binary (aka "deployment"), or if you are just building one code module (output is a static library). If you type make gen_make from any folder with a Makefile, the makefiles in mk/makefiles get (re-)generated. The targets in there control how much gets compiled / linked, and how.
We define specific build "targets" that are a combination of compiler / linker configs, path specs, and which files from each module to build. They are listed in mk/configs/builds/builds.mk. When one of those build names follows SRC_ in a mod.mk file, it means that those files are only built when the build of that name is invoked. Separately, if you are in a module folder when you type make, only that module is built. If you type make SDFLIGHT_opt, only the files for SDFLIGHT target from that module will be built, using the settings for cross-compile for the Snapdragon. If you are in a deployment folder (listed in the last line of mk/configs/modules/modules.mk), all modules for that deployment will be built. Same comment about build target applies (in determining which files from each module are built, and with which compiler / linker toolchain / flags).

Thanks!


Random Crash

The call stack is down below:

I have a mapView which is also rendered by the opengl es, but they are not in the same scene. I also found when I scroll the collectionView (the eaglView's sibling view) the camera responses slowly. I m not sure this is your issue, please help me out. thanks!

Is your problem likes this?
Maybe using opengl in multiple views is not work fine.

@yshrkt Thanks, you are right. Do you have any idea how to solve the video play laggy issue?


[Question] Isn't elongator affected by guest API shutting down?

Hello there, as you may know Nitter died because of the guest API shutting down.
As far as I understood elongator's README it uses the same API.
Wouldn't that kill FxTwitter & elongator too?

FxTwitter uses elongator which uses twitter accounts as proxies to fetch tweets. FxTwitter continues to also work with the guest API. Contrary to some of conversation around Nitter, the guest token API still functions, it's just a lot more limited in terms of rate limits and functionality. We use the guest API in the same way the Twitter Web App still does. That said, since we use account proxying by default we are unaffected by anything that happens to the guest token API. Hope that helps clear things up!


data:KaushikKundu

Fixes Issue

Changes proposed

Check List (Check all the applicable boxes)

[ ] My code follows the code style of this project.
[ ] My change requires changes to the documentation.
[ ] I have updated the documentation accordingly.
[ ] All new and existing tests passed.
[ ] This PR does not contain plagiarized content.
[ ] The title of my pull request is a short description of the requested changes.

Screenshots

Note to reviewers

LGTM.
Suggestion: You can add more links such as Linkedin, Github, etc.

As this is not a blocker I will merge your Pull Request.
When you are ready to add more links, please raise a new Pull Request - you may want to take a look at the Editing Guide in our Docs too: https://linkfree.io/docs/how-to-guides/editing


Blogpost down

Heads up that the linked blog post doesn't exist: http://blog.daviddias.me/post/stellar-module-management/

Thanks, good catch. New url at http://daviddias.me/blog/stellar-module-management/


number '1' in select field is replaced in output of {{ summary }}

PHP 7.4.30 / Kirby 3.6.6
I am using a basic version kirby-form-blocks in my blueprint:
fields:
  booking:
  type: blocks
    fieldsets:
      - form

In my form, I am using a standard select (dropdown) field with a few event dates as options, like this:
7. August 2022 10 Uhr 15
8. August 2022 18 Uhr 15
(…)

The form works as expected, but for some reason the number 1 gets replaced in the output of {{ summary }}. E.g. if I select the option 8. August 2022 18 Uhr 15, {{ summary }} would output 8. August 2022, 8 Uhr, 5.
This is the case in both the confirmation email and in the panel. It does not matter how I format the text of the dropdown, e.g. I tried 8_August_2022__18_15_h or similar – the 1 always gets replaced by , .
Also, I only have this issue in the dropdown field. Other fields, e.g. with a phone number, work fine an output the "1 correctly."

Thx for your Bugreport. What about the Option-Field. Same Error there?

I just checked, same error with an option (radio) field …
Thanks for the plugin!

I found the bug. It's fix in Version 2.0.1.

Wow! Amazing, thanks for the quick fix. Just sent through a donation, too.


Got an error: "Sorry, something went wrong activating IntelliCode support for Python. Please check the "Python" and "VS IntelliCode" output windows for details."

I got following error in notification.
Sorry, something went wrong activating IntelliCode support for Python. Please check the "Python" and "VS IntelliCode" output windows for details.
Therefore i checked output window and i got following logs there.
Language server is set to Pylance.
Acquiring model
Acquiring model 'intellisense-members-lstm-pylance' for python
Querying IntelliCode service for available models.
vs-intellicode-python was passed a model: {}.
Cached model is up to date.
Activating Python extension
Language server extension command failed. Exception: Error: command 'python.intellicode.loadLanguageServerExtension' not found
at p._tryExecuteCommand (file:///C:/Users/vikin/AppData/Local/Programs/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:1809:3360)
at file:///C:/Users/vikin/AppData/Local/Programs/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:1809:3241
at processTicksAndRejections (internal/process/task_queues.js:93:5)
Error while activating Python: {}

Thanks @ayim. It has been fixed and working fine for me now.

@GeGrieftGames @noelleleigh @GPla
Please upgrade to 2021.5.926500501 of the Python extension and let us know if the issue persists:
marketplace.visualstudio.com/_apis/public/gallery/publishers/ms-python/vsextensions/python/2021.5.926500501/vspackage


HOW do I run the script ?

When I am trying to run the script it says-
"Success, you can access this via terminal!"
How do I access it via terminal?

It hasn't be released or finished yet according to the developer :(

i think The developer is not gay although my friend said he is.

i think The developer is not gay although my friend said he is.

Don't be rude. Respect open source developers. They are doing it for you free without getting any return.

i think The developer is not gay although my friend said he is.

Well, first of all, no, i'm straight.
Secondly - this is offtopic and not related to this and most of other projects on github, if you don't respect me - i don't respect you, here goes your ban.

I know this is off topic but i have to say something, that dude you blocked was nothing but a rude a**hole, jeez some people have no respect, you handled that well @sTiKyt very well

Duplicate of #11


how can use the vuex-loading in mpvue

how can use the vuex-loading in mpvue
mpvue: https://github.com/Meituan-Dianping/mpvue

This is fully Chinese and I understand nothing :(

thanks


Form delivery

Please deliver completed forms to<EMAIL_ADDRESS>

Fixed in the MAVC repository


Fix issues with concurrent helm repo add commands

What this PR does / why we need it:
This PR aims to fix the issue with concurrent helm repo add commands reported in #5677.
It adds a test case to reproduce the issue:
# go test -v ./cmd/helm/ -run=TestRepoAdd
=== RUN   TestRepoAddCmd
=== RUN   TestRepoAddCmd/add_a_repository
--- PASS: TestRepoAddCmd (0.01s)
    helm_test.go:154: $HELM_HOME has been configured at .
    --- PASS: TestRepoAddCmd/add_a_repository (0.01s)
=== RUN   TestRepoAdd
--- FAIL: TestRepoAdd (0.01s)
    helm_test.go:154: $HELM_HOME has been configured at .
    repo_add_test.go:106: test-name-1 was not successfully inserted into /tmp/helm-repotest-391309255/repository/repositories.yaml
    repo_add_test.go:106: test-name-2 was not successfully inserted into /tmp/helm-repotest-391309255/repository/repositories.yaml
FAIL
FAIL    k8s.io/helm/cmd/helm    0.069s

# go test -v ./cmd/helm/ -run=TestRepoAdd
=== RUN   TestRepoAddCmd
=== RUN   TestRepoAddCmd/add_a_repository
--- PASS: TestRepoAddCmd (0.01s)
    helm_test.go:154: $HELM_HOME has been configured at .
    --- PASS: TestRepoAddCmd/add_a_repository (0.00s)
=== RUN   TestRepoAdd
--- FAIL: TestRepoAdd (0.01s)
    helm_test.go:154: $HELM_HOME has been configured at .
    repo_add_test.go:106: test-name-0 was not successfully inserted into /tmp/helm-repotest-560212793/repository/repositories.yaml
    repo_add_test.go:106: test-name-2 was not successfully inserted into /tmp/helm-repotest-560212793/repository/repositories.yaml
FAIL
FAIL    k8s.io/helm/cmd/helm    0.067s

Special notes for your reviewer:
The fix is implemented with github.com/gofrs/flock for cross platform file locking.
Timeout is hard-coded to 5 minutes for now.
If applicable:

[ ] this PR contains documentation
[x] this PR contains unit tests
[ ] this PR has been tested for backwards compatibility

I've implemented file locking to achieve cross processes synchronization.
This makes the manual testing work fine:
# helm repo list
Error: no repositories to show
# helm repo add repo1 https://kubernetes-charts.storage.googleapis.com & helm repo add repo2 https://kubernetes-charts.storage.googleapis.com &
[1] 3604
[2] 3605
# wait $(jobs -p)
"repo2" has been added to your repositories
"repo1" has been added to your repositories
[1]-  Done                    helm repo add repo1 https://kubernetes-charts.storage.googleapis.com
[2]+  Done                    helm repo add repo2 https://kubernetes-charts.storage.googleapis.com
# helm repo list
NAME    URL
repo2   https://kubernetes-charts.storage.googleapis.com
repo1   https://kubernetes-charts.storage.googleapis.com

However, it does not make the unit test pass as file locks are bound to processes, not file descriptors.
The test needs to be updated to perform repo additions in sub-processes.

Implementation updated to use github.com/gofrs/flock for cross platform file locking.
This library also enables same process go routines synchronization.
I've updated unit tests to test both same process and concurrent processes repository additions.

Rebased on master.

I had to decrease the number of concurrent sub-processes from 3 to 2 to for the helm repo add test case to fit within CircleCI's pipeline memory limit.
Otherwise, the job would fail randomly during unit tests execution with the following error:
/usr/local/go/pkg/tool/linux_amd64/link: signal: killed

@mattfarina I believe this PR is ready for final review.

Rebased on master to fix conflicts on glide.yaml.

Hi @bacongobbler and @hickeyma, as the most active maintainers here apart from @mattfarina who already reviewed and approved this PR, could you please take a look at it?


Check BBox of downloaded model is already sufficient

Prior to downloading a new model check if when there is an existing model on disk if it already meets the requirement, if yes, then do not download.

Seems to be already adressed.


Usbl dev

@PenguineZhang can you add testing instructions for this PR? Please write a tutorial in the Wiki, or link to one if it's written already. Thank you!

Responding for @PenguineZhang - working on the tutorial and should be done very soon.

To test this PR, see README.md at:
https://gitlab.nps.edu/frl/dave/-/tree/usbl_dev/usbl_gazebo

@bsb808 Any chance you have time to review this?

@bsb808 Any chance you have time to review this?

Can do.
@PenguineZhang are you allowed to add the wiki or do we need to move it over from gitlab?

@bsb808 I am not allowed to post anything other than review to public site. So It'll be better if you or other folks in NPS do that. The tutorial is already included in the usbl_gazebo directory as README.md file.

Roger - will do.

@M1chaelM The day got away from me.  Will attempt to defend time tomorrow.

New tutorial at https://github.com/Field-Robotics-Lab/dave/wiki/usbl_tutorial

Subset of email conversation with @PenguineZhang and @M1chaelM

I have gone through the PR.  Currently it doesn't seem to work - may have been something I did.
Peng - Please have a look at the current github/usbl_dev branch and the associated githhub tutorial.

If this is a small fix, please recommend how to fix via github or email
If it is a larger fix, please create a new gitlab branch to so that you can work on it directly to fix.

@bsb808 The USBL tutorial looks good to me

@bsb808 There's a small bug in my code. The fix is to add the following line after line 6 in transponderPlugin.cpp.
TransponderPlugin::~TransponderPlugin(){}

@bsb808 Still linked with open issue, so will leave branch intact for the time being.

@bsb808 Still linked with open issue, so will leave branch intact for the time being.


Create docker-compose-curseforge-atm7.yaml

ATM7 CURSEFORGE - Tested 20221005 v.0.4.32

Oh, does it work now with TYPE=CURSEFORGE? I had to do it as a generic pack:
https://github.com/itzg/docker-minecraft-server/blob/master/examples/docker-compose-generic-pack-atm7.yml

It does! It fired right up using the :latest


was built for newer iOS version (10.2) than being linked (8.0) duplicate symbol OBJC_CLASS$_TableHeaderView in

was built for newer iOS version (10.2) than being linked (8.0)
duplicate symbol OBJC_CLASS$_TableHeaderView in
导入项目的时候，不能用，

@MansionWayh 感谢反馈，现已纠正


How to check permission without requesting it ?

Before I used the cordova-plugin-firebase plugin from arnesson, where the following method existed
https://github.com/arnesson/cordova-plugin-firebase/blob/master/docs/API.md#haspermission
How can I do this, with your plugin ? My intent is, to first check if the user has given the permission, and if not, I first want explain why I'll ask for it, before I gonna request...

You can do it with Cordova diagnostic plugin

You can do it with Cordova diagnostic plugin

looks nice, and thanks for the tip!
But maybe this is a little bit an overkill, to integrate a whole plugin with so many features, for just a small check. If I don't need all the rest, this will unnecessary increase the size of my app.
Anyway let's see what @chemerisuk has to say about this ?

I don't feel this method is often needed. iOS provides a way to customize text in permission dialog where you can explain why. To show a different kind of screen at the first time - use a persistable flag.

I am currently switching over to this plugin from cordova-plugin-firebase as well and need this method as part of a complex authentication process on startup. Is there another way to check?

@WolftechBroadcastSolutions
As I also have local notifications, I used this plugin with the method hasPermission
It better fits my requirements, without bloating the app bundle too much with the diagnostic plugin.
But IMHO it would be better, if cordova-plugin-firebase-messaging would also be able to allow us to check, without requesting for it.
Unfortunately, I don't have any iPhone Dev knowlegde, so I'm unable to implement this natively as proposed by @chemerisuk


Greenkeeper/eslint plugin node 8.0.0

Not sure what this is and why it's by my name. I didn't to that 🤔


Select aspect ratio of a plot

There should be some mechanism in place for determining the X- and Y-axis scales for a plot. This could be done in a similar way to ET_Redux, where the user draws a bounding box; by manually entering the min/max of axes; or by adjusting sliders for either axis.

#395 adds the ability to manually enter the minimum and maximum extents for the X and Y axes from the "Plot Manager".


can not set style on component

can not set style on component like:
<PullView style={{...}}>

have fixed @Version1.0.9


Mild incompatibility with Recycle This

https://steamcommunity.com/sharedfiles/filedetails/?id=2567877605
With Recycle This loaded after Many Jobs (the default RimPy sort order) the DoBillsSmelter WorkGiver appears to be moved to Recycle This's "Recycle" work type. Moving Many Jobs below Recycle This in the load order "fixes" the problem, but the two mods are still conflicting, so look for a better solution ASAP.

Credit to @PK Droid on the RimWorld Discord for the report.


Option to disable automatic exception breakpoints, break only at explicit points

Please include the ability to disable automatic breakpoints, this extension is all but useless for debugging older code without it. I have inherited an ancient application built on a terrible homemade framework that constantly throws exceptions for small things, I don't want to click continue 100+ times before I can get to my own explicit breakpoint and fix actual feature code.
If you could point me to where the automatic breakpoints are configured / set, I can fork and solve this issue myself, but my understanding of the GDBp is limited, and TypeScript is somewhat foreign, so I need some direction.
Thanks.

 Thanks.

I definitely don't have those options under the breakpoint bar. I've restarted the app and all that, made sure the breakpoints bar was expanded, etc.

@knetworx did you run the debugger at least once? It needs to return those options to VS Code at least once

I've tried to, but I think I've got something wrong in my setup. It seems to die immediately.

We have a very complex project, and I'm trying to figure out the build process so I can debug in VSCode rather than XCode, but it's not my area of expertise, so I'm fumbling through it.

Seems like a different issue / problem with your setup. Please open a new issue and include the logs in the issue template

I figured it out, I just needed to set my DYLD_LIBRARY_PATH in my launch.json, like this:
"environment": [
	{
		"name": "DYLD_LIBRARY_PATH",
		"value": "bin"
	}
],

XDebug breaking on exceptions that are being caught is extremely annoying and breaks good code design...


Added deps.json to pull in TIA.exe from blob storage

add the 3rd party notices
looks fine

looks fine

as discussed offline not adding the 3rd party file


[eval] fix error of eval task

it can not read hive config

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


'terminate called without an active exception' during training

When I start training (on LJSpeech dataset), it's terminated on the first epoch. The traceback is:

python train_latest.py -c configs/ljs_mini_mb_istft_vits.json -m ljs_mini_mb_istft_vits
[INFO] {'train': {'log_interval': 200, 'eval_interval': 10000, 'seed': 1234, 'epochs': 20000, 'learning_rate': 0.0002, 'betas': [0.8, 0.99], 'eps': 1e-09, 'batch_size': 4, 'fp16_run': False, 'lr_decay': 0.999875, 'segment_size': 8192, 'init_lr_ratio': 1, 'warmup_epochs': 0, 'c_mel': 45, 'c_kl': 1.0, 'fft_sizes': [384, 683, 171], 'hop_sizes': [30, 60, 10], 'win_lengths': [150, 300, 60], 'window': 'hann_window'}, 'data': {'training_files': 'filelists/ljs_audio_text_train_filelist.txt.cleaned', 'validation_files': 'filelists/ljs_audio_text_val_filelist.txt.cleaned', 'text_cleaners': ['english_cleaners2'], 'max_wav_value': 32768.0, 'sampling_rate': 22050, 'filter_length': 1024, 'hop_length': 256, 'win_length': 1024, 'n_mel_channels': 80, 'mel_fmin': 0.0, 'mel_fmax': None, 'add_blank': True, 'n_speakers': 0, 'cleaned_text': True}, 'model': {'ms_istft_vits': False, 'mb_istft_vits': True, 'istft_vits': False, 'subbands': 4, 'gen_istft_n_fft': 16, 'gen_istft_hop_size': 4, 'inter_channels': 192, 'hidden_channels': 96, 'filter_channels': 768, 'n_heads': 2, 'n_layers': 3, 'kernel_size': 3, 'p_dropout': 0.1, 'resblock': '1', 'resblock_kernel_sizes': [3, 7, 11], 'resblock_dilation_sizes': [[1, 3, 5], [1, 3, 5], [1, 3, 5]], 'upsample_rates': [4, 4], 'upsample_initial_channel': 256, 'upsample_kernel_sizes': [16, 16], 'n_layers_q': 3, 'use_spectral_norm': False, 'use_sdp': False}, 'model_dir': './logs/ljs_mini_mb_istft_vits'}
Mutli-band iSTFT VITS
Mutli-band iSTFT VITS
./logs/ljs_mini_mb_istft_vits/G_0.pth
./logs/ljs_mini_mb_istft_vits/G_0.pth
[INFO] Loaded checkpoint './logs/ljs_mini_mb_istft_vits/G_0.pth' (iteration 1)
./logs/ljs_mini_mb_istft_vits/D_0.pth
./logs/ljs_mini_mb_istft_vits/D_0.pth
[INFO] Loaded checkpoint './logs/ljs_mini_mb_istft_vits/D_0.pth' (iteration 1)
/home/kbateeva/Projects/TTS/MB-iSTFT-VITS/venv/lib/python3.10/site-packages/torch/autograd/init.py:200: UserWarning: Grad strides do not match bucket view strides. This may indicate grad was not created according to the gradient layout contract, or that the param's strides changed since DDP was constructed.  This is not an error, but may impair performance.
grad.sizes() = [1, 9, 48], strides() = [17904, 48, 1]
bucket_view.sizes() = [1, 9, 48], strides() = [432, 48, 1] (Triggered internally at ../torch/csrc/distributed/c10d/reducer.cpp:323.)
Variable._execution_engine.run_backward(  # Calls into the C++ engine to run the backward pass
/home/kbateeva/Projects/TTS/MB-iSTFT-VITS/venv/lib/python3.10/site-packages/torch/autograd/init.py:200: UserWarning: Grad strides do not match bucket view strides. This may indicate grad was not created according to the gradient layout contract, or that the param's strides changed since DDP was constructed.  This is not an error, but may impair performance.
grad.sizes() = [1, 9, 48], strides() = [17712, 48, 1]
bucket_view.sizes() = [1, 9, 48], strides() = [432, 48, 1] (Triggered internally at ../torch/csrc/distributed/c10d/reducer.cpp:323.)
Variable._execution_engine.run_backward(  # Calls into the C++ engine to run the backward pass
[INFO] Train Epoch: 1 [0%]
[INFO] [4.6328253746032715, 2.759337902069092, 0.28215909004211426,<PHONE_NUMBER>0810547, 0.9382677674293518, 90.15510559082031, 4.346133232116699, 0, 0.0002]
terminate called without an active exception
[INFO] Saving model and optimizer state at iteration 1 to ./logs/ljs_mini_mb_istft_vits/G_0.pth
[INFO] Saving model and optimizer state at iteration 1 to ./logs/ljs_mini_mb_istft_vits/D_0.pth

Does somebody meet such error 'terminate called without an active exception'?

In my case, it was caused by different types of GPU. It isn't possible to start parallel training on them.


Write a TypeScript program to find sum of n natural numbers

Description
Write a TypeScript program to find sum of n natural numbers
Input  : 5
Output : 15

How to contribute

Save the solution in FindSumOfNNaturalNumbers.ts file
Add FindSumOfNNaturalNumbers.ts file in find-sum-of-n-natural-numbers folder

!assign


Consider improving bilinear filtering of skybox with mip >= 2

Right now, if a user set the mip parameter on Skybox then they can see artifacts of the bilinear filtering

Consider improving bilinear filtering as described by Inigo Quilez here.
Probably, it can be done here.

one repro is here
https://launch.playcanvas.com/984240


HBASE-23891: Add an option to Actions to filter out meta RS (#1217)

Branch-2.2 compatible PR for a fix already merged on master

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
5m  0s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 18 new or modified test files.

_ branch-2.2 Compile Tests _

+1 :green_heart:
mvninstall
6m  1s
branch-2.2 passed

+1 :green_heart:
compile
0m 35s
branch-2.2 passed

+1 :green_heart:
checkstyle
0m 21s
branch-2.2 passed

+1 :green_heart:
shadedjars
4m 42s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 16s
branch-2.2 passed

+0 :ok:
spotbugs
5m  0s
Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
0m  0s
branch-2.2 passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
5m 40s
the patch passed

+1 :green_heart:
compile
0m 31s
the patch passed

+1 :green_heart:
javac
0m 31s
the patch passed

+1 :green_heart:
checkstyle
0m 18s
hbase-it: The patch generated 0 new + 115 unchanged - 1 fixed = 115 total (was 116)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
shadedjars
4m 52s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
hadoopcheck
17m 30s
Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.

+1 :green_heart:
javadoc
0m 13s
the patch passed

+1 :green_heart:
findbugs
0m  0s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
1m 11s
hbase-it in the patch passed.

+1 :green_heart:
asflicense
0m 11s
The patch does not generate ASF License warnings.

54m 26s

Subsystem
Report/Notes

Docker
Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1295/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1295

JIRA Issue
HBASE-23891

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile

uname
Linux 33c47c329d15 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1295/out/precommit/personality/provided.sh

git revision
branch-2.2 / f17f0aa08c

Default Java
1.8.0_181

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1295/1/testReport/

Max. process+thread count
399 (vs. ulimit of 10000)

modules
C: hbase-it U: hbase-it

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1295/1/console

versions
git=2.11.0 maven=2018-06-17T18:33:14Z)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.