/sync response can be optimized

Currently, if a room has no updates, ruma outputs {"summary":{},"unread_notifications":{},"timeline":{"events":[]},"state":{"events":[]},"account_data":{"events":[]},"ephemeral":{"events":[]}}
which could just be left out from the join field entirely
ruma_client_api::r0::sync::sync_events::Response
more specifically: ruma_client_api::r0::sync::sync_events::JoinedRoom
but it's probably the case for more structs as well.
https://matrix.org/docs/spec/client_server/unstable#get-matrix-client-r0-sync

We can easily skip fields with serde, but we can't really filter out object or array entries. You'll have to make sure not to add empty entries yourself.


Fixed lexer pattern for bad character set

Fixes an issue with the lexer pattern for character ranges to now no-longer allow an unescaped closing square bracket inside a character set.
I'm using the following test rule, and test data.
$ cat ~/testrule.yara
rule test {
        strings:
                $ = /[0-9]-2/
        condition:
                all of them
}

$ cat ~/yara_test_file.txt
1-2-3-4-5

Using a version of Yara without a fix, Yara improperly gives an error for the pattern in the rule above.
$ /usr/bin/yara --version
3.9.0

/usr/bin/yara -s ~/testrule.yara ~/yara_test_file.txt
~/testrule.yara(3): error: invalid regular expression "$": bad character range

With my changes, Yara appears to be working as expected
./yara -s ~/testrule.yara ~/yara_test_file.txt
test /home/cyberdraco/yara_test_file.txt
0x0:$: 1-2

Closes #1690

This issue was already fixed in a91b8a1eece43f8e32af8988d6d392c335df019f and ee96a35dad4b0b4937e44a3eb8e9fd53c662a777. I didn't notice this PR with until know, but your solution was 100% correct.


Update LoggingInterceptor documentation

Added docs for LoggingInterceptor's log Level, as those were missing.
Used OkHttp HttpLoggingInterceptor.kt for reference.
Sample data from apollo-kotlin-tutorial.
./gradlew dokkaHtml executes locally without issues.
Sample screenshots:

@harmittaa: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/

Thanks!


Update autorest version to prerelease 3.0.0-alpha.20240425.5.x

Triggered from pull request: https://github.com/Azure/autorest.csharp/pull/4613

API change check
API changes are not detected in this pull request.


API App Registration Script

PR for issue #95
Shell script to create the app registrations for the API and the Swagger UI in Azure AD.
Uses the az rest rather than az ad app create as the CLI seems to be out-of-date and uses the old AAD API.
Note: The -a option to perform the admin consent seems to have stopped working. Need further investigation but may be due to a recent change in AAD and the Azure CLI has not caught up. In the meantime use the Azure Portal to grant admin consent.
It may be worth porting this from Bash to Python at some point.

Update to the -a option not working: Seems to be an Azure AD issue (https://github.com/Azure/azure-cli/issues/18603)


halide_15: init at 15.0.0

Description of changes
Introduce the pre-release version of Halide as a separate versioned package. We also introduce a flag to enable exception handling.
This package can be swapped with the default one when v15 is officially released.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

I think it would be better to have just another target within the same derivation.
One example: https://github.com/NixOS/nixpkgs/blob/nixos-unstable/pkgs/development/compilers/sbcl/bootstrap.nix#L78

Closed by #220286.


[BUG]: node-postgres date parser modified globally

What version of drizzle-orm are you using?
0.30.0
What version of drizzle-kit are you using?
0.20.14
Describe the Bug
in drizzle-orm/src/node-postgres/driver.ts the default date parsers are modified. we're trying to gradually adopt drizzle along another orm which started breaking tests because it was relying on default pg date parsing. why was this needed? can there be an opt out for this in the drizzle() function?
	initMappers() {
		types.setTypeParser(types.builtins.TIMESTAMPTZ, (val) => val);
		types.setTypeParser(types.builtins.TIMESTAMP, (val) => val);
		types.setTypeParser(types.builtins.DATE, (val) => val);
		types.setTypeParser(types.builtins.INTERVAL, (val) => val);
	}

Expected behavior
pg type parsers are not modified when calling drizzle()
Environment & setup
No response

Hey! We were discussing this part and planning to improve it by providing an option to create each driver instance ourselves rather than by the user, while still allowing the possibility to provide an existing driver.
https://orm.drizzle.team/docs/column-types/pg#timestamp

The reason we're doing this is to enable the possibility of having a mode string and mode date for dates/timestamps in Drizzle. We don't need a driver to handle these mappings; instead, we need to retrieve a raw value from the database and then either proxy it to the user (in string mode) or create a new Date (in date mode). This approach may not be ideal and shouldn't modify an instance for you, but it's necessary for Drizzle to work as expected.
Current Functionality:
We are still changing(and will change) the behavior of timestamps, dates, and intervals to align with Drizzle modes, ideally making users aware of these changes when using the client outside of Drizzle. Apologies for not mentioning this earlier.
Improvements Currently In progress:
The ability to specify the driver as a string and let Drizzle create a specific client instance for you, allowing for usage if needed and not modifying your client instance, that is owned by you and not Drizzle
Workarounds for You:
You can try creating another pg client and providing it to Drizzle. And leave your previous client for other parts of application, so it won't be modified by Drizzle

I was struggling with exactly same issue. And advice to "creating another pg client and providing it to Drizzle" didn't work, as Drizzle is just taking and modifying global pg types on its own.
The workaround I've used is to temporarily override the global setTypeParser function and record all the custom parsers Drizzle want to register, and then apply them just to the connection pool instead of globally:
import { drizzle } from 'drizzle-orm/node-postgres';
import { Pool, PoolConfig, types } from 'pg';
import TypeOverrides from 'pg/lib/type-overrides';

function prepareDrizzle(poolConfig: PoolConfig) {
  const typeOverrides = new TypeOverrides();

  const setTypeParserOrg = types.setTypeParser;
  types.setTypeParser = (...args: unknown[]) => {
    typeOverrides.setTypeParser(...args);
  };

  try {
    poolConfig = {
      ...poolConfig,
      types: typeOverrides,
    };

    const pool = new Pool(poolConfig);
    const db = drizzle(pool);
    return { pool, db };
  } finally {
    types.setTypeParser = setTypeParserOrg;
  }
}

I just spent hours chasing this and was pretty shocked to find out that this was the cause. I think it's really bad practice for Drizzle to be directly modifying runtime functions of a peer dependency, this is like a nightmare fuel bug. My use case is the same as OPs - I'm trying to gradually introduce Drizzle for a new API while old APIs using another query builder that expects pg's default behavior.

Agreed. I'll push a change to modify the parsers at the query level rather than globally. I'll use this API:
https://node-postgres.com/features/queries#types
We were planning a release tomorrow, so can include a fix for that as well

Sorry, didn't have a chance to respond here earlier

Great, thanks for the quick response. Let me know if you need any help with that PR.

It seems like this issue is resolved locally. I'll push it to beta soon and ping you. If everything looks good, it will be included in the next release

Please try<EMAIL_ADDRESS>

Hey @AndriiSherman I'm on the latest and I am finding that pglite parsers/serializers are being overridden once passed into drizzle.

Hey @AndriiSherman I'm on the latest and I am finding that pglite parsers/serializers are being overridden (or ignored?) once passed into drizzle.

Nevermind, I did not understand how to use customType and see that it will do exactly what I was hoping for! Thank you all for your excellent work on this library.


[SPARK-32316][TESTS][INFRA] Test PySpark with Python 3.8 in Github Actions

What changes were proposed in this pull request?
This PR aims to test PySpark with Python 3.8 in Github Actions. In the script side, it is already ready:
https://github.com/apache/spark/blob/4ad9bfd53b84a6d2497668c73af6899bae14c187/python/run-tests.py#L161
This PR includes small related fixes together:

Install Python 3.8
Only install one Python implementation instead of installing many for SQL and Yarn test cases because they need one Python executable in their test cases that is higher than Python 2.
Do not install Python 2 which is not needed anymore after we dropped Python 2 at SPARK-32138
Remove a comment about installing PyPy3 on Jenkins - SPARK-32278. It is already installed.

Why are the changes needed?
Currently, only PyPy3 and Python 3.6 are being tested with PySpark in Github Actions. We should test the latest version of Python as well because some optimizations can be only enabled with Python 3.8+. See also https://github.com/apache/spark/pull/29114
Does this PR introduce any user-facing change?
No, dev-only.
How was this patch tested?
Was not tested. Github Actions build in this PR will test it out.

Test build #125868 has started for PR 29116 at commit 16a2b75.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/30476/
Test PASSed.

Test build #125870 has started for PR 29116 at commit 7b47107.

Test build #125868 has finished for PR 29116 at commit 16a2b75.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/125868/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/30478/
Test PASSed.

Test build #125870 has finished for PR 29116 at commit 7b47107.

This patch fails PySpark pip packaging tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/125870/
Test FAILed.

Thanks, @dongjoon-hyun


Deploy on Vercel

Can you write a guide on how to deploy kucosjs to Vercel?
I tried myself by pushing source code directly to Vercel after edit config.
It's live at https://cmts.now.sh.
But It seem not to be working. If I enter wrong password, it'll warn me. If I enter real password, sometime I'll redirect to dashboard, sometimes it print 'undefined'. Also, deployment's output source code only contains index.js file, no css and other script at all

Using Vercel-cli fixed the issue.


Unified Access to Datasets

From the chat in discord:

I talked with Chris about this, and he was interested in this.
One cool thing that we might to is to provide a unified data access layer to all PAN datasets etc.
(we need to further discuss this in one of the next meetings, so I leave this issue on the agenda)


Bump bundler from 2.4.10 to 2.5.3

What problem does this pull request solve?

Bumps bundler from 2.4.10 to 2.5.3.

Release notes
Changelog
Commits

Things to consider when reviewing

Ensure that you consider the wider context.
Does it work when run on your machine?
Is it clear what the code is doing?
Do the commit messages explain why the changes were made?
Are there all the unit tests needed?
Has all relevant documentation been updated?

@aliuk2012 I've cherry-picked your change updating the platforms section of Gemfile.lock to save on deploying twice, would you mind re-approving?


Reduce redundancy pod label action

For that pod which has already been tag workflows.argoproj.io/completed: "true". It shouldn't be tag again and again.
In some large workflow,  these redundant tag action will cause much press to apiServer and cost much time.

@jessesuen @alexmt WDYT ?

Thanks for the great analysis!


Register Jenkins Otel Plugin in the Otel Registry

What feature do you want to see added?
Register Jenkins Otel Plugin in the Otel Registry
Upstream changes
No response

See https://github.com/open-telemetry/opentelemetry.io#adding-a-project-to-the-opentelemetry-registry

won't fix due to lack of bandwidth


Repl prepends whitespaces to soft wrapped lines causing issues with select+copy

The Repl prepends prompt.size whitespace characters to the beginning of new visual input lines (after soft wrapping). This makes it impossible (or dangerous) to copy using select + copy previous input from one shell to another because the contents may have changed depending on the terminal width and prompt size.

Yep this is a problem. This is even worse for code, because the random spaces will probably break whatever snippet you were running and it won't even compile.
Here's a solution that I just found: Fish Shell does this pretty neat thing:

Where if your command takes more than one line, they kick it to the next line below the prompt and have it start from the far left. This preserves both the "normal" single-line experience, provides a properly-aligned multi-line experience, and allows correct C&P.

That sounds like a sensible solution :)

This continues to annoy me


Full color range not available

This is a nice color picker, but there is one bug that I found and I am not sure how to fix it.  Regardless of the size you make the circle, you can not achieve the minimum color values of R/G/B.  If you move the mouser pointer around the perimeter you should be able to see a value of 00 through FF for each primary (RGB) color.  FF0000 is 100% red and 0% BLUE and GREEN, however, the minimum values are limited to FF0303, not FF0000 as you expect.
Is there a way to fix this?

After some more experimenting, it seems that the intensity (slider) is what is affecting this.  If you turn down the slider it affects how low the final value can be.  So, with the slider fully at the top, the minimum value you can achieve per color is 03, and with it fully at the bottom the minimum is 00.  Of course you can't have full intensity (FF) for the other colors if you lower the slider any amount.  But at least this might help you understand the problem.

Yes, the colors are three dimensional. And the wheel can represent only two dimensions, so to be able to select all the available colors you need another control to set the third variable. That's the purpose of the slider that is on the right side.
Any color picker has this "problem".
In this Wheel color picker, you can choose what of the three variables to be in the third control (the slider at the side) and what other two on the wheel.

Actually, I have never seen this with any color picker before (dating back to the Amiga).  The issue here is that you can't quite reach the full amount, depending exactly where the mouse pointer is located in the perimeter and where the intensity slider is set.  With any color picker you should be able to select full intensity and move the mouser pointer (with the mouse button held down) and see every R/G/B as 00/00/FF, 00/FF/00, 00/FF/FF, etc.   So, you should be able to reach both FF and 00, and with your color picker you can not reach 00 in all cases with intensity set at it's highest.  I think if you increased the diameter of the selectable area for the circle you could reach 00.  With the intensity at max (slider all of the way up) the lowest value you can select is 03.  If you move the intensity slider down a bit you can select 02, a bit more 01, and a bit more again 00.  So, you can't select FF/FF/00 with the slider up to the top... the best you can do is FF/FF/03, that means you are missing possible color values... actually quite a few because FF/FD/00 and many other color values are also not possible, resulting in a pretty big range that is missing.

As I said, three variables can't be set with two axis.
You don't need to look much to see the problem, just open Paint in Windows, open the color dialog and you'll see that there is an slider at the right, and without moving it you cannot get all the colors. The same as here, and as almost any other color picker (because it is a matter of logic, in a plane only two variables can be displayed, and a color is defined by three).
And regarding huge precision, enter the values in the textboxes, a visual picker can only achieve approximations. Or make the color wheel much bigger, that's another option, but still that won't be enough  (see below).
There are already set-up options for small, medium and large.
You also can choose between HSL and HSV color systems.
Perhaps changing the color system you get the colors that you want. But you'll never get all the colors on the screen at the same time because only two variables are displayed on the screen.
If you want to have all possible color on the screen, not even a 4k monitor (and using all the screen space) could show all them.
256 x 256 x 256 = 16,777,216 possible colors to show.
a 4k monitor using the whole screen: 3840 x 2160 pixel = 8,294,400 pixels/colors
an HD monitor: 1920 x 1080 = 2,073,600 pixels/colors
Impossible.

You probably should take a look at Paint, Photoshop, etc. again, because they all work exactly as I describe.  You can in fact get the minimum and maximum RGB values without any manipulation of an intensity slider required.   I can select the min/max RGB values of 00/00/FF, 00/FF/00, 00/FF/FF, FF/00/00, FF/00/FF, FF/FF/00 and FF/FF/FF all by simply using the mouse.  You can't do this with your color picker.  Open Paint.net, go to the color palette (looks just like yours) and select >>MORE.  Then grab the edge of the circle and move the pointer around the perimeter.  You will see exactly what I am talking about.  For me, it is critical to have the maximum (brightest) colors values available, so RED = FF/00/00, BLUE = 00/00/FF, etc.  With your picker the brightest RED is FF/00/04 unless you lower the intensity slider in order to make the BLUE value a possibility of 00 (instead of 04), but when you do that you can no longer get FF for RED.  I have the circle size of your color wheel at roughly 800 pixels wide (a little under 1/2 of the 1920 display width).
I don't want ALL of the colors on the screen, I just want to be able to select at the very least the minimum and maximum values for the primary (RGB) colors.  Some colors will appear to look the same but the hex representation will be correct.  There are only 256 possible shades of each RED, GREEN, and BLUE color, so it's easy enough to accomplish, even with a small color picker.  This is what Paint, Photoshop, Illustrator, Corel, etc. all do.  Take a look for yourself.  I have dealt with color pickers in graphics for decades, and this is a very common thing.  It's why this issue really stood out to me.

I made a screen capture of Paint.net's color picker.    You can see what I am talking about.
https://www.crxevent.com/data/screen.mov

Now I saw what you mean.
I made some changes. Please download and take a look now.

Thanks!  I will check it out!

Well, it's definitely better!  Using the size I chose for the color picker still makes most of the min/max colors not achievable.  I tried your example size in my code (as well as your actual example) and you can see that there are still two min/max colors that are not achievable - 00/FF/00 and FF/FF/00.  It seems that the size of the circle makes a difference on what the actual number of min/max achievable colors are.

Please test now.

It's better, but there are 6 colors in the Magenta range that don't go to full value, and now there is a new bug where one position generates white (FF/FF/FF), see screenshot.
I am testing this by simply dragging the mouse pointer around the perimeter of the circle.  Every position in that edge of the circle will always have one component (R, G, or B) that is always 00.  That is true except for Magenta now (and the new bug).

I have undone the first "fix" because it caused the other problems, and applied a different solution.
It seems to be working.

Yes!  It works correctly now!  Nice job, and thank you!
There are two issues that I did neglect to report to you, that might cause confusion with others.
In the .ctl's Usercontrol UserControl_ReadProperties(PropBag As PropertyBag), this line generates a run time "380" error:
If` Not SelectInListByItemData(cboSelectionParameter, mSelectionParameter) Then cboSelectionParameter.ListIndex = 0
In the Function InIDE(), this line generates a run time "11'" error:
Debug.Print 1 / 0
If I just comment these lines, the control works fine.  I am not sure what the problem is with the first, but the 2nd is obvious because you can't ever divide by zero.  This probably works on an executable, but it does not work within the VB6 IDE itself because On Error statements are ignored.
Again, thank you for your work on this!

OK, the first one was a bug, when SelectionParametersAvailable is set to cdSelectionParametersNone (0), the error happened. It is corrected now.
The second was intended, you must have VB6 set in the Options dialog (General tab) to Break in all errors. The usual is to set it to Break on unhandled errors or Break in class modules.  Some errors are normal and need to be handled.
Anyway now I changed the way it checks whether it is running in the IDE or not to a way that doesn't need error handling.
Thanks for your reports, you helped to improve this control.

Thanks.


Recommendation: Add "auto" to the title of the project

It's not possible to figure out that History Cleaner automatically performs its actions. The extension Cookie AutoDelete indicates automation.
I guarantee that you get more users if you extend the title of your project by adding "auto", because no other extension automatically clears the history as far as I know.

I personally think the name of the extension does a good job describing what it does. However, I'm not really opposed to changing the name.
I will continue to leave this issue open in case anyone else has feedback on the name (and I've also added the help wanted label to make it clear feedback is welcome)

I personally think the name of the extension does a good job describing what it does. However, I'm not really opposed to changing the name.
I will continue to leave this issue open in case anyone else has feedback on the name (and I've also added the help wanted label to make it clear feedback is welcome)

Suggestions:

History AutoDelete (based on Cookie AutoDelete)
AutoHistory (simple and direct)
History Zap (catchy and emphasizes action)
Hush History (privacy-focused)

Of those, I think History Zap sounds the best.
I wouldn't use History AutoDelete, as that's already the name of an extension by the same developer as CAD. Wouldn't want to give the false impression that HC and HAD are the same.

Of those, I think History Zap sounds the best.

I forgot to include "Auto". How about History AutoZap, or History AutoZapper?

I wouldn't use History AutoDelete, as that's already the name of an extension by the same developer as CAD. Wouldn't want to give the false impression that HC and HAD are the same.

Sorry, you're absolutely right about that.


added new cpp file for n_queens_problem

Here is a cpp program for N Queens problem in data structures

LGTM!


Broken Link in ML with Jupyter module

This link "Notebook with output: with-output/credit-risk-notebook-with-output.ipynb" is broken

FYI, this is due to git not being able to differentiate between Jupyter and jupyter. I'll get a workaround in the repo.

fixed by pr #51 and #52


Fix UnsupportedFeatureException when re-selecting scoped unknown object reference

Summary of the changes / Why this improves CrateDB
Fixes:
create table t (obj_dynamic object);
SET error_on_unknown_object_key = 'false';
select obj_dynamic['u'] from (select obj_dynamic['u'] from t) t2;
UnsupportedFeatureException[Can't handle Symbol [VoidReference: obj_dynamic['u']]]

The approach to fix is to refer to the behaviour of a similar query that works, select obj_dynamic['u'] from (select obj_dynamic from t) t2. See the comments for more details.
Checklist

[x] Added an entry in the latest docs/appendices/release-notes/<x.y.0>.rst for user facing changes
[x] Updated documentation & sql_features table for user facing changes
[x] Touched code is covered by tests
[x] This does not contain breaking changes, or if it does:

It is released within a major release
It is recorded in the latest docs/appendices/release-notes/<x.y.0>.rst
It was marked as deprecated in an earlier release if possible
You've thought about the consequences and other components are adapted
(E.g. AdminUI)

I thought this was blocking a fix for a regression on master but it turned out to be not a regression. Then I will resume the feature work and switch back to these bug fixes during feature freeze.

I resumed on this thinking that it is a bug but on a second thought, since https://github.com/crate/crate/issues/14828 is a feature, this PR could also be a feature.


Connection live time

Hi, what is the best way to use a connection in a long-lived asynchronous application? Is it better to create a new connection and open the cursor for each request, or is it possible to create a connection as a singleton and only open the cursor at each request? Thank you in advance.

Just use pool


ReferenceError: google is not defined and InfoBox is not defined

I want use infobox https://code.google.com/p/google-maps-utility-library-v3/source/browse/trunk/infobox/src/infobox.js?r=49 in my project
i also put infobox.js file in client/lib/js/infobox.js
it given error
my code is
var myOptions = {
disableAutoPan: true
,content: $("#imgR").html()
,isHidden: false
,boxStyle: {
textAlign: "center"
,fontSize: "8pt"
,width: "18px"
}
,pixelOffset: new google.maps.Size(-7, 0)
,position: point
,closeBoxURL: ""
,pane: "mapPane"
,enableEventPropagation: true
};
var infowin = new InfoBox(myOptions);
infowin.open(map.instance);

Hey I've just added a new method loadUtilityLibrary https://github.com/dburles/meteor-google-maps#googlemapsloadutilitylibrarypathtolibraryjs which may fix this issue.

thank you so much, it is work for me

Hi @rahultank1993 , I met the exact problem and don't know where to put GoogleMaps. loadUtilityLibrary(path/to/infobox.js) . Could you help me please ?

@leizard most likely alongside where you call GoogleMaps.load()

Hi @dburles, I put infobox.js in my public folder and call GoogleMaps.loadUtilityLibrary('infobox.js') after the GoogleMaps.load() and it works. But if I put infobox.js in my client folder and call GoogleMaps.loadUtilityLibrary('client/infobox.js'), it yields Uncaught ReferenceError: google is not defined . Do I have to put the file in public folder to make it work ?

Yep, public folder otherwise it won't work

@dburles thanh you.


[BUG]: drizzle-orm dependency missing in drizzle-kit

What version of drizzle-orm are you using?
0.33.0
What version of drizzle-kit are you using?
0.24.0
Describe the Bug
When I run drizzle-kit generate I get the following error:
TypeError: (0 , import_pg_core.isPgSequence) is not a function
at /Users/projects/monorepo/node_modules/.pnpm/drizzle-kit@0.24.0/node_modules/drizzle-kit/bin.cjs:18348:45
When I inspect the drizzle-orm version in package.json, it shows
 "drizzle-orm": "workspace:./drizzle-orm/dist",
Expected behavior
Generate command runs without error
Environment & setup
Node v18.19.1
pnpm 8.10.5
No response

I had the same issiue, used 0.22.8 version of drizzle-kit

also got this issue, but upgrading drizzle-orm to latest (0.33.0) seemed to fix it.

Hey mate, this issue seems to be that drizzle-kit v 23 onwards uses the dialect config option. When it does so it trys to import the pg_core from drizzle-orm in versions 32 onwards.
We had the same issue because we were using drizzle-kit 23+ but orm 31.
You might find your package.json had the version numbers set, but for whatever reason they were not the versions of code you were actually running with. If you update both kit and orm to the newest versions you might find this problem resolved

I had the same issiue, using 0.22.8 version of drizzle-kit fixed it

Can confirm this exists in v0.24.2 but downgrading to v0.22.8 resolved the issue.

Can confirm that this issue occurs in the latest v0.26.0. Downgrading to v0.25.0 fixes the issue 😞

Please provide a link to a reproduction repo so I can reproduce it myself. Thanks!

This should be fixed in latest.


Bug report: Chess Events list icon color today

Describe the bug
If date is today icon is red (past) and not green (current).
To Reproduce
In navigation and events list the icon has the wrong color.
Expected behavior
If the event starts today or is over today, the icon should be green for present.

Fixed in https://github.com/MichiBaum/Microservices/pull/117 and merged into develop


Can't update the data in my plot

Hello,
I was able to get the polar scatter plot working, but I cannot figure out how to add new data to the plot without trouble. When I use setState it causes the plot to slap a new empty plot, not even the same type over top of the old plot. The old plot remains unchanged and underneath the new empty plot...
Let me know if you are able to update the plot's data and if so, could you post the code for doing it correctly? I could really use a polar scatter plot in my project :)

Hi,
Not sure what you mean by "use setState" you should be able to change the props passed in to the "Plotly" element and the plot will update.

After more poking around in the code it looks like my issue has nothing to do with react-plotlyjs. It may be a plotly.js issue or just the way that I use plotly.js in react.


Gitea database Environment Variable: 'GITEA__database__SSL_MODE' not reading from environment.

Description
I am currently writing out deployment code (Bicep) to push out a multi-tier Gitea install in Azure using a container instance for the webserver and a postgres flexi server for the database.
I've defined my environment variables, and after running my deployment everything works as expected other than the SSL_MODE variable, which does not apply (it stays as disabled).
Reproduction Steps:
Define Environment Variable in Bicep Code:
            {
              name: 'GITEA__database__SSL_MODE'
              value: 'require'
            }

Referencing the cheat sheet here to pull the config value: https://docs.gitea.com/next/administration/config-cheat-sheet#database-database.
Check deployment to validate container deployed with variable successfully:

Navigate to web UI - SSL mode is not set to require:

Gitea Version
1.20.0+rc0
Can you reproduce the bug on the Gitea demo site?
No
Log Gist
No response
Screenshots
See descriptions.
Git Version
No response
Operating System
Linux
How are you running Gitea?
Pulling directly from dockerhub, gitea/gitea:latest.
Database
PostgreSQL

Please use 1.20 nightly

-> Show correct SSL Mode on "install page" #25818


Support for WaitStrategy on DockerComposeContainer - alternative approach

@bsideup, just wanted to continue the conversation from #598
I didn't want to update that pull request for now, as this is a much bigger change.
I've implemented an alternative approach, involving breaking out all of the methods that apply after startup from the  Container  interface into a new interface ContainerState.
I've also moved the functionality implemented in the various WaitStrategy classes into classes with the same names, but in a sub-package org.testcontainer.wait.strategy and updated the current implementations to delegate to the new ones. I have also deprecated the use of the current classes in favour of the new ones.
For each instance of a service started by docker-compose, I'm instantiating a class called DockerComposeServiceInstance, which implements ContainerState, and applying the new WaitStrategy implementation to them.
For example:
new DockerComposeContainer(new File("docker-compose.yml")
.withExposedService("redis_1", REDIS_PORT, Wait.forListeningPort())
.withExposedService("elasticsearch_1", ELASTICSEARCH_PORT, Wait.forListeningPort());

would create two instance, and apply a WaitStartegy to each.
This is a considerably larger change than the other pull request, and might not gel with the future plans for interface changes, so I thought I'd request feedback at this point. There's still work required on it, but all tests are passing.
If this is too large a change, or doesn't feel like the right approach, please let me know. If that's the case, maybe we should revisit after the planned changes for splitting configuration and state are done.

@barrycommins while I like the final result a lot, I'm thinking what if we dramatically reduce the number of changes by going a bit to the low level landscape and using com.github.dockerjava.api.model.Info as an argument to the wait strategies.
This way we can unify the strategies between GenericContainer and Docker Compose, always use the actual state (current implementation with GenericContainer will use the state set by user (i.e. envs), but what if Docker daemon will change them? Would be more safe to use Info object instead which represents the actual state received from Docker daemon)
WDYT?

That would certainly be a simpler solution.
I think it would probably work ok for the HostPortWaitStrategy and LogMessageWaitStrategy|, but maybe not the HttpWaitStrategy'.
For docker-compose, that wait strategy needs to know the port the service is mapped to on the SocatContainer, which wouldn't be available through the Info object of the service container.
I'll make another attempt at it though with that approach and see if I can come up with a solution.
Are you ok with deprecating the current WaitStrategy and creating new implementations in a sub-package, then delegating to the new implementations?
Or can you suggest an alternative approach for that?

That would certainly be a simpler solution.
I think it would probably work ok for the HostPortWaitStrategy and LogMessageWaitStrategy|, but maybe not the HttpWaitStrategy'.
For docker-compose, that wait strategy needs to know the port the service is mapped to on the SocatContainer, which wouldn't be available through the Info object of the service container.
I'll make another attempt at it though with that approach and see if I can come up with a solution.
Are you ok with deprecating the current WaitStrategy and creating new implementations in a sub-package, then delegating to the new implementations?
Or can you suggest an alternative approach for that?
Edit: thinking about it, the HostPortWaitStrategy requires commands to be executed within the running container to see if the internal port is listening, so would need access to the DockerClient and not just the Info object.

@barrycommins Docker client is always available as DockerClientFactory.instance().client(), so it's not a problem
Re HttpWaitStrategy - actually, DockerComposeContainer should handle it instead of a strategy itself because socat-based exposing is a detail of an implementation of it and strategies should be agnostic to it.
Maybe need a "proxying" object, something like WaitStrategyTarget, with Info plus everything related to the host, like getMappedPort.

Ok, good suggestions, thanks.
I'm very much in favour of reducing the changeset, so I'll take try this approach in the next week or so.

@barrycommins let me know if you need a help or something :)
Some thoughts:

WaitStrategyTarget is better be an interface with an abstract implementation or some default methods
Please keep your WaitStrategy refactoring 👍
Later, once we extract ContainerState at a core level, we could add it to the WaitStrategyTarget interface, so that the strategies can also benefit from it
Some operations (like getting mapped port, envs, etc) could be shared between GenericContainer and WaitStrategies. While I was writing this I realized that maybe it's a good idea to still introduce ContainerState interface, but with a very limited set of methods, and every method must use Info as a source, and also maybe implemented as a default method of ContainerState. How does it sound to you? :)

P.S. good job, thanks! Will be one of the biggest (and most awaited) features of the upcoming release 👍

Those are all really helpful suggestions, thanks.

@bsideup

While I was writing this I realized that maybe it's a good idea to still introduce ContainerState interface, but with a very limited set of methods, and every method must use Info as a source,

The Info class seems to refer to the Docker itself, rather than an individual container.
Should it be InspectContainerResponse?

@barrycommins oh, yes, InspectContainerResponse! Sorry :)

@bsideup
I've added another commit, which I hope is a bit closer to what you are looking for.
I added two more interfaces CommandExecutor and LogFollower, which could probably be folded into ContainerState, but didn't seem to quite fit there. Maybe that's just a naming problem.
The change set is still quite large, so if you have any more suggestions, or if I have misunderstood your earlier suggestions, please let me know.

Sorry for my continuing lack of review on this - it looks like a lot of hard, good work has gone into it, so thank you! I'll try to review tomorrow.

@bsideup I've made some of the changes you requested in the review, but had a couple of questions on other ones.
Let me know what you think, and I'll make further changes as necessary.

The latest commit is my favourite type of commit, because it mostly removes code.

Thanks for the review @rnorth, and thanks to @bsideup for helping beat this into shape.
I think it's a lot better now than it was when I first submitted it.
It's a feature I've been looking forward to for a while, so I'm happy I was able to help.
Went through about 10 commits, so I'm sure it will need a squash before merging.
Any other features/bugs you would like someone to look at, just let me know.

@barrycommins merged 🎉  Thanks a lot for this contribution 👍


Version Packages

This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.
Releases
<EMAIL_ADDRESS>Minor Changes

Introduce createIsomorphicRequest in @clerk/backend (#1393) by @anagstef
This utility simplifies the authenticateRequest signature, and it makes it easier to integrate with more frameworks.

Add updateUserProfileImage and updateOrganizationLogo methods for uploading images to User and Organization respectively. (#1456) by @anagstef

Patch Changes

Add missing property 'adminDeleteEnabled' in Organization resource (#1468) by @chanioxaris

Fix the headers checked to determine the Response Content-Type (#1469) by @anagstef

Add missing property 'privateMetadata' in OrganizationInvitation resource (#1468) by @chanioxaris

Updated dependencies [73c9c1d0e, ae9fc247a, 1a151e701, 090bab66e, 592911196]:

<EMAIL_ADDRESS>

<EMAIL_ADDRESS>Minor Changes

Add a confirmation input as an additional check when doing destructive actions such as: (#1454) by @raptisj

delete an organization
delete a user account
leave an organization

Νew localization keys were introduced to support the above

Patch Changes

Add missing property 'maxAllowedMemberships' in Organization resource (#1468) by @chanioxaris

Add form_username_invalid_character unstable error localization key. (#1475) by @desiprisg

Fixed a bug where overriding some localization values in the sign in/up start pages with an empty string would result in showing the english translation. (#1474) by @desiprisg

Changes to OrganizationSwitcher (#1462) by @panteliselef

Removal of user identifier from the trigger & popover
Hidden avatar of active user when hidePersonal is true

Enable the ability to target the avatar upload and remove action buttons (#1455) by @tmilewski

In the  component, if the newly created organization has max allowed membership equal to 1, skip the invitation page (#1471) by @chanioxaris

Updated dependencies [73c9c1d0e, ae9fc247a, 1a151e701, 090bab66e, 8bd5b3d38, 5ecbb0a37, 592911196, cd361e169]:

<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>

<EMAIL_ADDRESS>Minor Changes

Introduce createIsomorphicRequest in @clerk/backend (#1393) by @anagstef
This utility simplifies the authenticateRequest signature, and it makes it easier to integrate with more frameworks.

Patch Changes

Pass the ClerkFastifyOptions to the exported fastify plugin (#1488) by @mikestopcontinues

Updated dependencies [16c3283ec, 73c9c1d0e, ae9fc247a, 1a151e701, e3036848d, fd692af79, 090bab66e, bb0d69b45, 592911196]:

<EMAIL_ADDRESS><EMAIL_ADDRESS>

<EMAIL_ADDRESS>Minor Changes

Introduce createIsomorphicRequest in @clerk/backend (#1393) by @anagstef
This utility simplifies the authenticateRequest signature, and it makes it easier to integrate with more frameworks.

Patch Changes

Updated dependencies [16c3283ec, 73c9c1d0e, ae9fc247a, 1a151e701, e3036848d, fd692af79, 090bab66e, bb0d69b45, 592911196, dd10ebeae]:

<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>

<EMAIL_ADDRESS>Minor Changes

Add a confirmation input as an additional check when doing destructive actions such as: (#1454) by @raptisj

delete an organization
delete a user account
leave an organization

Νew localization keys were introduced to support the above

Add el-GR localization (#1479) by @EmmanouelaPothitou

Patch Changes

Add form_username_invalid_character unstable error localization key. (#1475) by @desiprisg

Add missing "delete account" French translations (#1487) by @selimjouan

Updated dependencies [73c9c1d0e, ae9fc247a, 1a151e701, 090bab66e, 592911196]:

<EMAIL_ADDRESS>

<EMAIL_ADDRESS>Minor Changes

Introduce createIsomorphicRequest in @clerk/backend (#1393) by @anagstef
This utility simplifies the authenticateRequest signature, and it makes it easier to integrate with more frameworks.

Improve dev-mode logs for authMiddleware (protectedRoutes and ignoredRoutes) by @nikosdouvlis

Patch Changes

Updated dependencies [16c3283ec, 73c9c1d0e, ae9fc247a, 1a151e701, e3036848d, fd692af79, 090bab66e, bb0d69b45, 592911196, dd10ebeae]:

<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>

<EMAIL_ADDRESS>Minor Changes

Introduce createIsomorphicRequest in @clerk/backend (#1393) by @anagstef
This utility simplifies the authenticateRequest signature, and it makes it easier to integrate with more frameworks.

Patch Changes

Updated dependencies [16c3283ec, 73c9c1d0e, ae9fc247a, 1a151e701, e3036848d, fd692af79, 090bab66e, 5ecbb0a37, bb0d69b45, 592911196, dd10ebeae]:

<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>

<EMAIL_ADDRESS>Minor Changes

Introduce createIsomorphicRequest in @clerk/backend (#1393) by @anagstef
This utility simplifies the authenticateRequest signature, and it makes it easier to integrate with more frameworks.

Patch Changes

Updated dependencies [16c3283ec, 73c9c1d0e, ae9fc247a, 1a151e701, e3036848d, fd692af79, 090bab66e, bb0d69b45, 592911196]:

<EMAIL_ADDRESS><EMAIL_ADDRESS>

<EMAIL_ADDRESS>Minor Changes

Deprecate the useOrganizations react hook. The hook can be replaced from useClerk, useOrganization, useOrganizationList (#1466) by @panteliselef

<EMAIL_ADDRESS>Minor Changes

Add a confirmation input as an additional check when doing destructive actions such as: (#1454) by @raptisj

delete an organization
delete a user account
leave an organization

Νew localization keys were introduced to support the above

Patch Changes

Add missing property 'maxAllowedMemberships' in Organization resource (#1468) by @chanioxaris

Add form_username_invalid_character unstable error localization key. (#1475) by @desiprisg

Add missing property 'privateMetadata' in OrganizationInvitation resource (#1468) by @chanioxaris

Enable the ability to target the avatar upload and remove action buttons (#1455) by @tmilewski

<EMAIL_ADDRESS>Patch Changes

Updated dependencies [73c9c1d0e, ae9fc247a, 1a151e701, 0a7a88995, 17f963e38, 592911196, dd10ebeae, cf918665c]:

<EMAIL_ADDRESS><EMAIL_ADDRESS>

<EMAIL_ADDRESS>Patch Changes

Updated dependencies [73c9c1d0e, ae9fc247a, 1a151e701, 0a7a88995, 17f963e38, 592911196, dd10ebeae, cf918665c]:

<EMAIL_ADDRESS><EMAIL_ADDRESS>

<EMAIL_ADDRESS>Patch Changes

Mark setSession as deprecated when it is re-exported within hooks (#1486) by @panteliselef

Updated dependencies [73c9c1d0e, ae9fc247a, 1a151e701, 090bab66e, 5ecbb0a37, 592911196]:

<EMAIL_ADDRESS><EMAIL_ADDRESS>

This PR has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.


Upgrade jape

jape hasn't been running for some time again and it shows because our clients have a small issue here and there (fixed here. Special thanks to @chris124567 for updating jape so it can handle client definitions in sub-packages and extending the GH action to support passing in directories

That's odd.  Before we merged the jape changes I tested it on a copy of the renterd at https://github.com/test5000009/renterd/actions/runs/6747834229 and it found the unused routes in bus.  Will look into this.

I got this configuration:
      - name: Check Endpoints
        uses: SiaFoundation/action-golang-analysis@HEAD
        with:
          analyzers: |
            go.sia.tech/jape.Analyzer@master
          directories: |
            autopilot
            bus bus/client
            worker worker/client

working on my test repository, using @master instead of @HEAD.  I'm not sure why Go is choosing an old version when @HEAD is specified.  I don't want to make the analyzer add @master instead of @HEAD because some packages are using main instead of master nowadays whereas specifying @HEAD should always work.  Do Go module proxies have some kind of cache?

Thanks @chris124567 - took me one hour this morning to come to that same conclusion you left on my PR 🤣

Hm @chris124567  it seems that the jape analyzer has an NDF now where it claims the client is missing methods for every single route. Any clue why that might be?
  Error: /home/runner/work/renterd/renterd/bus/client/chain.go:19:9: Client references route not defined by server: POST /txpool/broadcast
  Error: /home/runner/work/renterd/renterd/bus/client/chain.go:44:8: Client references route not defined by server: GET

https://github.com/SiaFoundation/renterd/actions/runs/6891677726/job/18747258490?pr=742

I got:
/home/christopher/prog/go/src/go.sia.tech/renterd/bus/client/metrics.go:22:34: route contains (1 path + 0 form) = 1 parameters, but 2 arguments are supplied
/home/christopher/prog/go/src/go.sia.tech/renterd/bus/client/metrics.go:44:34: route contains (1 path + 0 form) = 1 parameters, but 2 arguments are supplied
/home/christopher/prog/go/src/go.sia.tech/renterd/bus/client/metrics.go:69:34: route contains (1 path + 0 form) = 1 parameters, but 2 arguments are supplied
/home/christopher/prog/go/src/go.sia.tech/renterd/bus/bus.go:2038:13: Encode called on []go.sia.tech/renterd/api.ContractSetMetric, but was previously called on []go.sia.tech/renterd/api.ContractMetric
/home/christopher/prog/go/src/go.sia.tech/renterd/bus/bus.go:2052:13: Encode called on []go.sia.tech/renterd/api.ContractSetChurnMetric, but was previously called on []go.sia.tech/renterd/api.ContractMetric
/home/christopher/prog/go/src/go.sia.tech/renterd/bus/client/metrics.go:22:104: Client has wrong response type for GET /metric/:key (got *[]go.sia.tech/renterd/api.ContractSetMetric, should be *[]go.sia.tech/renterd/api.ContractMetric)
/home/christopher/prog/go/src/go.sia.tech/renterd/bus/client/metrics.go:22:9: Client has too few path parameters for GET /metric/:key
/home/christopher/prog/go/src/go.sia.tech/renterd/bus/client/metrics.go:44:9: Client references GET /metric/%s?%s multiple times
/home/christopher/prog/go/src/go.sia.tech/renterd/bus/client/metrics.go:69:9: Client references GET /metric/%s?%s multiple times

on latest renterd.  But if I run it multiple times I sometimes get your output.  Looks like this is a concurrency related issue (when multiple directories are passed they are are all analyzed in parallel).  If I run jape built locally with -race I get a bunch of race condition warnings - I think we should just revert https://github.com/SiaFoundation/jape/commit/148b9cf36e120b2cc3398ab25af299fe165caa66 which based on my testing locally is where this bug was introduced.

OK I made https://github.com/SiaFoundation/jape/pull/16.  On that branch I get the same output 100% of the time and no races.  Sorry for the bug - guess I just got lucky in testing because it didn't show up then.

... there we go.


Map locate component

We can create a component which allows user, when clicked, to see on the Map component where he/she is. It can be based for example on https://github.com/domoritz/leaflet-locatecontrol

As I just saw in the react-leaflet repository, it's got several plugins:
https://github.com/PaulLeCam/react-leaflet/blob/master/docs/Plugins.md
But none to handle the geolocation thing... So a development is required. Though I think we'd better create a plugin on its own, rather than coding it in osm-ui-react. That way, the new plugin will be available to people already using react-leaflet.
What do you think about it?
P.S.: Sorry for the delay of my input... ;)

Well it would be the best option. But it's more work than just integrating an existing plugin (well for Leaflet and not react-leaflet).

Yes indeed... May we keep that in mind as a future improvement?
About your commit, it seems to do the job :) Thanks!

What is the actual current status of this issue ?
Is it still "Doing" ? If not, please update the project accordingly.

@PanierAvide began the work, you can see it in the storybook, but I remember some issues about the (un)mount scenario...


consider switching CI to github actions

https://github.com/octomike/rmdaction
https://github.com/octomike/rmdaction/actions
https://octomike.github.io/rmdaction/
thanks @octomike!

done! started working in 56aecb7792ae9430014fa61588819cb998db347e. very cool!


Add missing exception javadoc/tests for some null arguments

Hello! I added some missing javadoc for null arguments and wrote tests when they didn't exist.
I tried to keep the diffs as small as possible and the sentences consistent.
I will be happy to change anything if needed. Thanks.

Hi @dvmarcilio & thank you for your PR. Let' hold off on this one. I want to normalize on using Java's Objects#requireNonNull().

Codecov Report

Merging #869 (d071740) into master (3ac6bea) will increase coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master     #869      +/-   ##
============================================
+ Coverage     91.72%   91.73%   +0.01%
- Complexity     7421     7423       +2
============================================
  Files           188      188
  Lines         15924    15924
  Branches       2999     2999
============================================
+ Hits          14606    14608       +2
+ Misses          726      724       -2
  Partials        592      592

Impacted Files
Coverage Δ

...main/java/org/apache/commons/lang3/ArrayUtils.java
95.84% <ø> (ø)

src/main/java/org/apache/commons/lang3/Range.java
91.20% <ø> (ø)

.../apache/commons/lang3/builder/ToStringBuilder.java
100.00% <ø> (ø)

...va/org/apache/commons/lang3/reflect/TypeUtils.java
60.80% <ø> (+0.36%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ac6bea...d071740. Read the comment docs.

Hi @garydgregory.
Thanks for pinging me. All should be fine now.


MasterDetailRelation Don't Save. Why?

I have several MasterDetalRelation working just fine on my project.
I add to the XYZRow.cs
`
[DisplayName("Estados"), MasterDetailRelation(foreignKey: "IdSiniestro"), ClientSide]
public List ListaEstadosGestiones
{
get { return Fields.ListaEstadosGestiones[this]; }
set { Fields.ListaEstadosGestiones[this] = value; }
}
`
On my XYZForm.cs file the Custom editor
`
[GestionesSiniestrosXEstadosEditor]
public List<Entities.GestionesSiniestrosXEstadosRow>  ListaEstadosGestiones { get; set; }
`
But when I click on save, nothing happens, no error, no nothing, and the form keep visible and thats is weird for me.
and thats my question...anyone can give some inside ?

transform t4 rebuild....

I did it so many times

I dont see anything wrong here

I Find the reason why my dialogue did not save the changes.
I forgot to put a "return true" in the validateentity method.
I hope it will serve somebody in the future.


load_template improvements

Here are some improvements to load_template() I think we should make.

Support 'replace' operation. I would propose that we add a mode='merge' / mode='replace' parameter.

Have it behave properly if you specify 'my_template.j2' currently it will look for 'my_template.j2.j2'.

Be able to load templates from current working directory (as long as we can make this work in a reasonable way without breaking backwords compatibility).

Improve the docs here, http://napalm.readthedocs.io/en/latest/base.html

I think the behavior of some of the parameters needs clarified.

cc @mirceaulinic
I can work on these, I just wanted a placeholder so I remember things that I saw.

Support 'replace' operation. I would propose that we add a mode='merge' / mode='replace' parameter.

I'm into this.

Have it behave properly if you specify 'my_template.j2' currently it will look for 'my_template.j2.j2'.

Funny one :) Yes, we should definitely avoid this.

Be able to load templates from current working directory (as long as we can make this work in a reasonable way without breaking backwords compatibility).
Improve the docs here, http://napalm.readthedocs.io/en/latest/base.html

They all sound good to me @ktbyers! Thanks!

Have it behave properly if you specify 'my_template.j2' currently it will look for 'my_template.j2.j2'.

The idea behind this was that you would specify you want the ntp template, so it wasn't really meant to be a file. That's why the .j2 was added by the method.

Be able to load templates from current working directory (as long as we can make this work in a reasonable way without breaking backwords compatibility).

If you load the template blah.j2 in your current folder, that code is gonna be bound to the vendor for which you wrote the template for. If you want to add another vendor later on, your code will have to be adapted. What's wrong with requiring people to put their templates in ./templates/$vendor? I am trying to see the use case because I think it's effortless and in the long term it might have benefits for the user without any actual drawback.

The advantage I see is since a lot of platforms copy Cisco for configuration, you could potentially use the same template across multiple platforms (without resorting to symlinks).
The method was confusing when trying to use it as it took several tries to figure out how to get it to work (i.e. the most logical expectation was you could specify 'my_file.j2' and it would look in current working directory). This could be improved, however, by improving the documentation for this method.

That the documentation could be improved nobody doubts it :(


How to download?

Idk, but i can't find "download" button.

Sorry, I think you are not skilled enough to use this kind of software.

=> https://github.com/sailro/EscapeFromTarkov-Trainer/releases/tag/installer-2.0


Firebase Messaging does not call onResume and onLaunch when sending data including "notification" when app is background or terminated

I use nodejs firebase-admin to send notifications to Android devices
I have configured flutter_local_notification as instructed in
https://pub.dev/packages/firebase_messaging#optionally-handle-background-messages
When I send the notification from node js with payload:
var payload = {
                  "data": {
                    "Nick": "Mario",
                    "body": "great match!",
                    "Room": "PortugalVSDenmark",
                    "screen": "ChannelScreen",
                  },
                };

then flutter_local_notification trigger onBackgroundMessage and displays the success message, but when I click on firebase_messaging does not trigger the onResume and onLaunch functions.
When I send the notification from node js with payload:
var payload = {
                  "data": {
                    "Nick": "Mario",
                    "body": "great match!",
                    "Room": "PortugalVSDenmark",
                    "screen": "ChannelScreen",
                  },
                  "notification": {
       "click_action": "FLUTTER_NOTIFICATION_CLICK" //or "clickAction":
                  }
                };

then the notification appears in the device's navigation bar and firebase_messaging's onResume was trigger when I click on the notificaition but flutter_local_notification does not trigger onBackgroundMessage when the app is in the background
Please help me, Thank so much.
sorry because my English not good

Did you get a fix?

@Mahmoud2B No, I am getting error, and I need help to fix it.
Thanh you for reply!

Hey all 👋
As part of our roadmap (#2582) we've just shipped a complete rework of the firebase_messaging plugin that aims to solve this and many other issues.
If you can, please try out the dev release (see the migration guide for upgrading and for changes) and if you have any feedback then join in the discussion here.
Given the scope of the rework I'm going to go ahead and close this issue in favor of trying out the latest plugin.
Thanks everyone 🤓


InflowWind output for pitch control

Hello everyone! I'm willing to design a reinforcement-learning-based controller for the blade pitch angle. For the states' definition, I need the wind velocity at each timestep, and I'm using an FF binary to represent the wind. For a more realistic approach, I think I'm going to need to get the wind velocity as the wind turbines do in real life. Is there such a way to get kind of the mesaure of a wind sensor in OpenFAST? Exploring the output list, I found these variables. I think they are what I'm looking for, but I'm not sure:

I have no idea what being defined by sensors means; I can't use them directly. Can you suggest me either a way to "activate" these outputs or any recommendation to get the "state of the wind" at each time step?

Dear @vicemora,
InflowWind module output parameters WindMeas1 etc. are available if you've enabled the LIDAR functionality within InflowWind; otherwise, these outputs are not avialable.
InflowWind has other sensors for outputting ambient wind named Wind1VelX etc. if you haven't enabled the LIDAR functionality.
Can you clarify what you mean when you refer to, "I'm going to need to get the wind velocity as the wind turbines do in real life"?  What effects are looking for?  Tower influence?  Induction?  Relative velocity between wind and structure?
Best regards,

Dear  @jjonkman
Thanks I did not notice the lidar parameter. I think it is a new section in the OpenFAST inflow file because it isn't within the InflowWind documentation.
For the second part, Wind1VelX gives the X velocity component of the wind at a certain point (defined by the user) as a time series output. In the default configuration of the model I'm using, that point is set at the hub.
However, when you want a RL-based controller, the approach is to train the controller in a simulated environment, and then the trained controller could be implemented in a real environment. In this project I'm not going to implement it in a real environment.  However, for the training, I want the way I get the wind velocity in OpenFAST (to define the state) to be consistent with the way the wind is measured by a sensor in a real wind turbine.
To clarify what I mean with that "consistency" concept:
Imagine that the turbine within the simulation is experiencing a certain "wind space." And imagine there is a way for a real wind turbine to experience that exact "wind space." Either the simulated wind turbine or the real one is experiencing the same wind conditions. The consistency I'm looking for is that the value measured by the wind velocity sensor of the real wind turbine and the wind velocity that I get in the simulation in that step are similar or equivalent.
With this consistency, one can expect that the controller could be reproducible in real experiments. And that is the reason I think using Wind1VelX is not the most appropriate way to do so. Because it is the velocity value of a point you defined, it might work, but for me, it doesn't seem like a reliable way to ensure reproducibility in an implementation.
I'm not pretending to measure the wind velocity in OpenFAST in the same way it is measured in the real life. I'm just looking for an equivalent way to represent the wind velocity you would measure in real life, but within the simulation. So that, my work in could be perceived with certain reliability to reproducing experiments.
Because of that, I was thinking about using the WindMeas 1. I had never used it, and I don't know if it will work as I'm expecting it to. But It sounds like the way to create that consistency  I'm looking for.
If you can help me with advices/recomendation/documentation It will be helpful. As I stated, the wind sensors sound like a way to create that consistency but I do not know If I'm in the right way. If you know about another way to creat that consistency I was talking about, please let me know.

Dear @vicemora,
The LiDAR functionality you are referring was a new addition to the InflowWind module introduced within OpenFAST v3.5 within the following pull request: https://github.com/OpenFAST/openfast/pull/1464.  This functionality enables you to extract the ambient wind in a way that a LiDAR would measure it with line-of-site projection of the wind velocity and impact of structural motions.  However, it does not include the effects of rotor induction.
Is the type of "real" sensor you had in mind?  Do you need to consider the effect of rotor induction, if so, at what location?
Best regards,


Issues with Google Drive and Onedrive folders

Describe the bug
When trying to open synced Google Drive folders in the app it causes a total crash.
Expected behavior
The main Google Drive folder shows files and folders fine, but then trying to open a folder within that causes the app to crash entirely. Attempted same thing with OneDrive and get same behaviour.
Desktop (please complete the following information):

OS Version: 19042.804
App version: <IP_ADDRESS>

Log file
Please upload the log file here so that we can understand your issue better. You can access it from Settings->About->Open log location. You can also find this file by going to %localappdata%\Packages\49306atecsolution.FilesUWP_et10x9a9vyk8t\LocalState [debug.txt](https://github.com/files-community/Files/files/6009729/debug.txt) , you should see a file in this directory called debug.txt or/and debug_fulltrust.txt.

Thanks for this report. This issue should be fixed in 1.2.3.
Please add the log files to the issue description so we can verify.
Could you try to enable the "open items with one click" option in Files settings and see if it solves this issue?


[remote][web] allow to install extensions via upload

A user should be able to drag and drop an extension from the local machine to the extensions view. It should be installed on the remote machine.

I think this shall work, can you please provide more details like what extension you are trying to drag n drop and does it work in local window?

I think this shall work, can you please provide more details like what extension you are trying to drag n drop and does it work in local window?

You probably mean that I can upload vsix file via the explorer view and then use Install from VSIX...? I hoped it would be possible to drop directly to the extension view. I tried it in GitHub Codespaces and it does not work.

You probably mean that I can upload vsix file via the explorer view and then use Install from VSIX...? I hoped it would be possible to drop directly to the extension view. I tried it in GitHub Codespaces and it does not work.

/duplicate
https://github.com/microsoft/vscode/issues/106914

/duplicate
https://github.com/microsoft/vscode/issues/106914


feat: integrating NIM model UI

Description
Adding NIM UI changes.

How Has This Been Tested?
Tested locally.
Test Impact

Request review criteria:

Self checklist (all need to be checked):

[x] The developer has manually tested the changes and verified that the changes work
[ ] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
[ ] The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

[x] Included any necessary screenshots or gifs if it was a UI change.
[ ] Included tags to the UX team if it was a UI/UX change.

After the PR is posted & before it merges:

[ ] The developer has tested their solution on a cluster by using the image produced by the PR to main

/ok-to-test


libwebp: Sync with upstream 1.2.2

Also re-add custom changes (and properly turn them into a patch) apparently needed for the HTML5 platform. Those were mistakenly removed in #55127.
Might need to be re-assessed, at least 3.5 beta 1 included #55127 and compiled fine (but it's hard to say if it works fine, I haven't seen bug reports specific to webp issues, but I can't say how widely tested the HTML5 builds for 3.5 beta 1 have been).

Also re-add custom changes (and properly turn them into a patch) apparently needed for the HTML5 platform. Those were mistakenly removed in #55127.
Might need to be re-assessed, at least 3.5 beta 1 included #55127 and compiled fine (but it's hard to say if it works fine, I haven't seen bug reports specific to webp issues, but I can't say how widely tested the HTML5 builds for 3.5 beta 1 have been).

So it seems these changes were added by @punto- in 83f2084cb82d1dc006e7a9c0f23ca66e03736c2b in 2015... that's pretty old!
The Emscripten target was pretty much in its infancy at the time, both in Godot and upstream. Might no longer be needed?

I think we can continue testing libwebp without re-applying the patch for JavaScript. The commit history hints that it was needed to be able to compile (with asm.js at the time), and this no longer seems needed with latest Emscripten + WebAssembly.
We'll see if anyone reports any issue while using the HTML5 port, and we can re-add it if needed (as a reminder, the changes were removed by mistake already when syncing 1.2.1, i.e. those changes are already live in Godot 3.5 beta 1 - but not backported to 3.4.x).
Here's a branch with the patch if we need to bring it back: https://github.com/akien-mga/godot/tree/libwebp-1.2.2-html5-patch

Cherry-picked for 3.5.


Fixed Syntax errors in Powershell script,

noticed the profile xml would not parse within powershell, so encapsulated the XML Information within an array and removed unnecessary parenthesis.
Have your engineers confirm the Profile.ps1 and profile.xml should now build successfully and a working connection will be created.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: frasercarter sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

@frasercarter Please fix merge conflict and I will approve this pull request.  Thanks!


xarray.rolling().construct() and sliding_window_view chunking behaviour

Using .rolling().construct() will inject new dimensions into an array with sliding_window_view under the hood. NumPy is clever about this by arranging things to be a view of the underlying array and thus not increasing the memory footprint. Problems are starting to show up if you call a follow up operation that requires a copy, std is an example.
It uses construct under the hood but the aggregation requires a copy to handle NaNs, which makes memory blow up. A better example is something like
arr = xr.DataArray(da.random.random((2000, 2000, 2000), chunks=(200, 200, 200)), dims=['x','y', 'z'])
arr = arr.rolling({"x": 10, "y": 20}).construct({"x": "dim1", "y": "dim2"})

construct increase the chunk size by a factor of 200 to 14GB , things are still fine because we haven't performed a copy yet. But almost every subsequent operation will require copying the data, so things will go south real quick
arr.isel(dim1=[1, 3, 5, 7, 9])

This reduces chunk size to 7GB, but we will make a copy and memory will blow up
How to deal with this?
My suggestions would be to split up the other chunks in sliding_window_view to keep chunk sizes the same after construct, this would slow us down for cases where we indeed don't make a copy, but I think this is sufficiently rare in the general construct case.
Construct is also used internally for reductions, splitting up chunks unnecessarily there is not great since the reducer actually gets us back to our initial chunk size and the splitting would lead to a highly fragmented array. My suggestion here is to expose an option for xarray to turn the rechunk off, if xarray is sure that memory won't blow up.
Thoughts @dcherian for this?

My suggestions would be to split up the other chunks in sliding_window_view to keep chunk sizes the same after construct, this would slow us down for cases where we indeed don't make a copy, but I think this is sufficiently rare in the general construct case.

:+1:

Construct is also used internally for reductions, splitting up chunks unnecessarily there is not great since the reducer actually gets us back to our initial chunk size and the splitting would lead to a highly fragmented array. My suggestion here is to expose an option for xarray to turn the rechunk off, if xarray is sure that memory won't blow up.

:+1: Yes, we'd be happy to opt-in to this behaviour.


fix typo

Summary
Summarize the contents of the code changes in your pull request. Tag any open issues you believe to be resolved by this pull request.
Additional Details
If you have anything else that you think may be relevant to this issue, list it here. Additional information can help us better understand your changes and speed up the review process.
Please add your name to the CONTRIBUTORS.md file. Adding your name to the CONTRIBUTORS.md file signifies agreement to all rights and reservations provided by the License.
Thanks for contributing to Terra.

+1


DATA-1730 Remove user_email from TrainingJobMetadata API

Scope doc.
Verified that user_email field is no longer being used in the app repo.

@tessavitabile could you merge in this change? It requires a force-merge since it's a breaking API change (the user_email field is no longer used anywhere)


Implement Deserialize for RuntimeMetadataPrefixed

RuntimeMetadataPrefixed is the type returned by Runtime::metadata() which implements Serialize and I imagine is the way metadata can be serialized to JSON to be used in JS. Once I have metadata as JSON I think is reasonable to want to deserialize it back to RuntimeMetadataPrefixed which can be used by Rust tools that don't want a hard dependency on a  specific runtime code don't you think?

See ongoing work in the new frame-metadata crate: https://github.com/paritytech/frame-metadata/pull/3

See ongoing work in the new frame-metadata crate: https://github.com/paritytech/frame-metadata/pull/3

Awesome! even better to have it as a tiny crate :)

Awesome! even better to have it as a tiny crate :)


Update KMeans.php

Allow get centroids from clusters when calculate a cluster with Kmeans.
Necesary fix to run
https://github.com/php-ai/php-ml-examples/blob/master/clustering/robberySquaredErrors.php

Hey @geopamplona, why did you close?

Reopen
I got confused about PR
it was not my intention to close it


Dev 36 - implemented 404 page

Please make sure these boxes are checked before submitting your PR, thank you!

[x] Make sure all the tests are still passing.
[x] Make sure the test coverage is still 100%.
[x] Make sure your source branch is correct.
[x] Make sure your destination branch is devel.
[x] Make sure the name of the PR has a correct DEV-# identification prefix.
[x] Make sure you reviewed all your changes and they look correct.
[x] Make sure all the commits have a correct format.
[x] Make sure you refer related issues for you PR.
[x] Make sure you add KovDimaY as a reviewer and assignee of your PR.

Take a look at the Issue #61

Coverage remained the same at 100.0% when pulling 8f0fcdee53625feb03ab8e23cb1acdb66100b36b on DEV-36 into bc676d8cfe45a6d2a3ef5b233ebb9c8142b6c773 on devel.

Looks great! Good job! I do approval.


editor.addCommand returns a command id string instead of a disposable

monaco-editor version: 0.13.1
Browser: Chrome 67
OS: macOS
In this file, StandaloneCodeEditor.addCommand returns a commandId instead of a disposable. Is there any specific reason for it? If yes, then how do I remove a manually added command with public api?

@alexandrudima I got the same question.
And is there a way to dispose added command?

You could simply switch to addAction and also define a label. The only real difference is that the F1 list will then show your command, which is not that bad...

@alexdima What you prescribe won't work for code lens out of the box unless you created some other machinery.

I don't found a method to reject addCommand ，but I found it won't be called multiply by repeat define addCommandin a react hook.  Was the addCommandjust like a Singleton? And I still want to know how to reject it.

I don't found a method to reject addCommand ，but I found it won't be called multiply by repeat define addCommandin a react hook.  Was the addCommandjust like a Singleton? And I still want to know how to reject it.

The upcoming editor release will add monaco.editor.registerCommand to cover this usecase. (via https://github.com/microsoft/vscode/commit/7c937a7a383ca131c5e36811d4440878c97a1191)

The upcoming editor release will add monaco.editor.registerCommand to cover this usecase. (via https://github.com/microsoft/vscode/commit/7c937a7a383ca131c5e36811d4440878c97a1191)


Add toast to all api calls

Pull Request Title
Add toast to all api calls
Description

The on success and error of all api calls triggers an alert
Adding react toastify makes the ui better

Related Issues
Resolves #133
-->
Type of Change

[ ] 🐛 Bug fix (non-breaking change that fixes an issue)
[x] ✨ New feature (non-breaking change that adds functionality)
[ ] 🔨 Breaking change (fix or feature that would cause existing functionality to change)
[ ] 📚 Documentation update
[ ] 🔧 Refactoring (code improvements without functional changes)
[ ] 🧪 Tests (adding or updating tests)
[ ] 🚀 Performance improvements

Checklist

[x] My code follows the style guidelines of this project
[ ] I have updated the documentation where necessary
[x] I have tested my changes and ensured that the code is working as expected
[ ] I have added/updated tests to cover my changes
[ ] All new and existing tests pass locally with my changes
[x] I have reviewed my code and addressed any potential issues

Screenshots (if applicable)

Additional Information

@Ehm-Ehs, Thanks for your contribution. I was a bit busy this time, which is why the review took longer than usual. Please feel free to work on other issues as well. I'm looking forward to seeing another PR from you soon!


Unknown resource 'picard'

I'm getting this error trying to run pipeline_mapping.
The picard resource was defined on the CGAT cluster, because running multiple picard jobs on a single compute node was leading to some very odd states where the processes would effectively wait forever, thus the picard resource was defined to allow only on process to run at once.
However, I'm not able to define this resorce on the cluster here. How might I get around this problem? I could just rip out the code referring to the picard resource, but I don't know if that is going to lead to problems.

Thanks. I think we need to get rid of this resource requirement and put in place a mechanism to specify job parameters for given jobs in pipeline.ini. I can implement that.
In the meantime if you want to submit a pull-request without all the picard requirements, please do so. I almost expect that this problem has gone away with upgrades to java and picard.

See above PR


Gmail issue?

URL issue : https://mail.google.com/mail/u/0/feed/atom
Add-on version: 2.6
i can't have my gmail feed ! it says it can recover the feed !
This issue occurs since a few monthes now

Does disabling Tracking Protection solve the issue ?

nope !

So is there any update on this? when I go to gmail, Livemarks offers me the opportunity to add the feed but when I attempt to add it it gives an error of "failed to fetch feed" BUT when I click on the "view source" link it shows the feed as I would expect it. Is there something that's allowing Livemarks to be able to see the feed but not able to read it?

here is what i have when i try to catch the gmail feed "impossible to catch the feed" or something like this, sorry i'm french

@GrosBourrin Thanks! I'm French too so no worries :)
So, there seems to be 2 issues:

the XHR to https://mail.google.com/mail/u/1/feed/atom gives you a 401 status, so it seems like Gmail doesn't want people to XHR the feed.
This console error: Request to access cookie or storage on “https://mail.google.com/mail/u/1/feed/atom” was blocked because it came from a tracker and content blocking is enabled.

I wonder if there are other APIs allowing us to workaround 1 (which may fix this issue), 2 can't be fixed without https://bugzilla.mozilla.org/show_bug.cgi?id=1502987 .

Ok, so thus far the feed was updated once and then it stopped which doesn't make a whole lot of sense, and the add-on I am using doesn't let me set the refresh period(that I can find) so I have no idea if it will update again but I'll let you know what happens in the next few hours.

@TheOncomingStorm Thanks for the update, that seems strange.
Btw, you mentioned another RSS reader works, which one is it ? This way we could look at how it's doing things.

I am going to try and compare the HTTP headers send when doing fetch in the webconsole on mail.google.com compared to a background XHR. I am curious how Google servers can tell the difference.

@nt1m it is Awesome RSS.  https://shgysk8zer0.github.io/
It doesn't seem to have updated my feed again so I'm kinda at a loss as to what happened. Maybe installing it allowed it a moment where it could grab it but whatever it is, I haven't yet worked it out. I do know I had not disabled Livemarks when I installed it so who knows.  I'll keep searching for a solution because this is the best way for me to keep up with all my email..

Thanks! From what I can see, Awesome RSS just redirects to the raw feed. You can view the raw feed going to the feed url shown by livemarks (above the "View source" link).

Well, it will give you a few ways to subscribe if you check the preferences. I just told it to use RSS.

Well, it will give you a few ways to subscribe if you check the preferences. I just told it to use RSS.
Can you maybe take a screenshot showing us what you mean?

When I click the link it literally just opens https://mail.google.com/mail/u/0/feed/atom, which is just a raw XML document. Looking at the code https://github.com/shgysk8zer0/awesome-rss/blob/master/js/background.js, there doesn't seem anything in this extension that actually loads or parses RSS feeds.

I am pretty sure we get that HTTP 401, because we are not sending Cookies, which we can't send because tracking protection is stripping them ...

I actually figure out how to hack around this problem. By requesting the cookies permission we can lookup the required cookies ourself and add them to the request.
I don't think we should do this, adding the cookies permissions will ask the users for additional permissions during updates, and it's doubt people will understand why we need it.
https://github.com/evilpie/livemarks/commit/ff996813a6601e0585c5c24d176badc3940ac30e

My feed just updated again for no reason that I can quite figure out. I did have to restart Firefox but that's never triggered a feed update before that I know of, and restarting it again got me nothing. Something is causing Livemarks to work, if even just for a moment.

Mozilla just fixed this with bug 1629436. The current Nightly (77) now allows access to gmail.


Unnoticed colour change with threshold 0

While comparing latest screenshots to baseline, I expected that the following colour difference would have triggered a test failure, however this still passes:

I have threshold: 0 specified in my config, but I just wanted to check if there still some tolerance being applied when comparing screenshots?

Tried this today and it only works if the threshold optional parameter is not passed at all.  Threshold set to anything causes the test to pass, even when I completely change padding and colour of the element.

For me if threshold is 0 then tests will pick up differences but if anything over 0 (0.1, 0.01) tests will pass with even major text changes, so something is broken here.


iTerm2 Problems on OSX

I tried running this on iTerm2 in OSX and ran into some problems:

All new chats are "JSON output" and I can't change the field
Using  on "chat" will tab into the Template and using it again will only add tabs inside the template widget. I need to use  to reach other widgets.
The format is always "JSON output" and I can't find a way to disable it. I thought of using just enter/return, but it does nothing.

Another "problem": Adding export OLLAMA_URL=http://$OLLAMA_HOST:11434/api is trivial but as all my other ollama based tools are just happy with using $OLLAMA_HOST I wished that oterm also would just use this or at least if there is no OLLAMA_URL in the environment.

Hey there,
JSON output is disabled by default. You need to click it to enable it.
This is off:

This is on:

I am afraid it's one of these times where using the mouse is necessary. I will try to figure out how to not capture TAB in the textareas but not sure it's possible. Keeping this open till then.

All models show JSON as enabled. Mouse is not working (I usually have mouse support switched off for terminals anyway).

Please look what I posted. This is the "off" state for the checkbox. I am afraid you won't be able to use oterm without mouse support.

Well. It did output json for me while it showed the state  as you can see in the video below. I did find out that it actually does switch the state when you are on it, and press space. It is just not visibel. Have a look at the video (first time I press 1. time space, 2. time I press space twice). From you image I thought "if it is not black" it is enabled and thought that "white" may be the green. But anyway. I do not need a mouse (and if you do a terminal programm you should think again using a library that only supports a checkbox with a mouse, lol). But the terminal needs to get updated correctly. I use a lot of terminal tools, never had such strange effects though.

What about the ENV variable? Wouldn't it be smarter to support the same ENV variable that ollama is using anyway?
P.S.: i wonder why you close something as completed when it obviously is not completed. And I already have the feeling that you think I work against you. So thanks for the tool, but I guess I need to make a fork then. Hopefully you do accept PRs.

I am sorry I offended you.
I am really not sure how to help you. I don't see the checkbox turning green in your video. I know for sure the default is off (which is not green). It is perhaps unfortunate that the checkbox from textual has an x inside on the off state, but I can't make every single widget from scratch, that's the one provided.
I am not going to get into a fight about whether one should use the mouse or not. textual which oterm uses provides a UI similar to your typical GUI which makes it necessary. I will accept PR that makes everything work with a keyboard alone.
Please open another issue for the env var, or even better make a pull request.
This issue was closed because it's 3 issues, one of which I cannot reproduce (JSON) , another that I will not work on (mouse), and a third that came as an afterthought.

I know that it does not turn green, but it changes the output. That is the whole point of the second video. This also explains why I thought it is always the default, because it was actually enabled ("hidden") as I was playing around and to I got the impression that they are always on by default.
About the mouse: I actually meant, that I can't believe that a terminal library does not support toggling a widget by mouse only. And as I wrote: It toggles when I use space while that widget is selected (in the result, but not visibly). So the real problem with that seems that the UI is not getting updated.
I understand that you can't or won't change every widget. I would expect that a terminal library can handle something like iTerm2 though. In the original terminal it does visual toggle using space and mouse. So it may even be just a problem with my color scheme in iTerm2. This terminal library does not seem to be very well designed though :)
About the "multiple topics in one issue": I see :) Sorry about that.


InternalServiceError(message:CreateWorkflowExecution operation failed. Error: invalid UUID "")

I'm trying to start workflow using Java TChannel client. I'm getting the following error when running against the local docker:
InternalServiceError(message:CreateWorkflowExecution operation failed. Error: invalid UUID "")
It looks like the error is returned by cassandraPersistence:
https://github.com/uber/cadence/blob/master/common/persistence/cassandraPersistence.go#L756
The relevant server log entries:
cadence_1    | time="2017-11-11T18:26:51Z" level=debug msg="Received StartWorkflowExecution. WorkflowID: 5ed7391d-612b-4aa6-a8d0-4742b9ee22b6" Service=cadence-frontend
cadence_1    | time="2017-11-11T18:26:51Z" level=debug msg="Start workflow execution request domain: test" Service=cadence-frontend
cadence_1    | time="2017-11-11T18:26:51Z" level=debug msg="Start workflow execution request domainID: f09d79d9-ebfe-4941-97c1-f173b34db4da" Service=cadence-frontend
cadence_1    | time="2017-11-11T18:26:51Z" level=info msg="Created RPC dispatcher outbound for service 'cadence-history' for host '<IP_ADDRESS>:7934'"
cadence_1    | time="2017-11-11T18:26:51Z" level=debug msg="Assigning transfer task ID: 1048576" Service=cadence-history shard-id=0 wf-component=shard-controller
cadence_1    | time="2017-11-11T18:26:51Z" level=debug msg="Assigning new timer (timestamp: 2017-11-11 18:27:11.446508875 +0000 UTC, seq: 1048577) ackLeveL: 0001-01-01 00:00:00 +0000 UTC" Service=cadence-history shard-id=0 wf-component=shard-controller
cadence_1    | time="2017-11-11T18:26:51Z" level=info msg="Range updated for shardID '0'.  RangeID: 2, StartSequence: 2097152, EndSequence: 3145728" Service=cadence-history shard-id=0 wf-component=shard-controller wf-event-id=3000

I've validated that workflow creation through Cadence CLI succeeds against the same docker service instance.

The root cause is missing requestID field in the createWorkflowExecution request. Keeping the issue open until Cadence service reports this missing field better than InternalServiceError.

Added validation of request id in StartWorkflowExecution.
PR: https://github.com/uber/cadence/pull/1319


Implement alternative Montgomery reduction

See blogpost here: https://jeffhurchalla.com/2022/04/28/montgomery-redc-using-the-positive-inverse-mod-r/

Interesting! I would love to help work on this.

That would be fantastic! Just for clarity, I don't know if this will be faster than our existing reduction, but it would be good to experiment and figure that out!

Hi @Pratyush ! Seems like there hasn't been much progress on this. Is this still open to work on?

Hi @ameya-deshmukh, I had unexpectedly got very busy after posting that comment so yeah the issue is still open on my end.

No worries! Would love to take this off your hands and work on it :)
Thanks for assigning it to me!

Hi folks, is anyone interested in picking this back up, or...?

Hey, thanks for the reminder! I have time on the weekend to work on this, will do it. Best way for questions/communication is through Discord right?


Fix incorrect expression base in AnimationNodeStateMachinePlayback::_check_advance_condition

Probably a typo when deciding the root to execute the advance expression.
Fixes #62530

Note that PR title/commit message can be improved, currently after reading it I'd have no idea what it's about (that it's animation related or something like that). For example changing it from:
Use the correct base in _check_advance_condition

to:
Use the correct base in `AnimationNodeStateMachinePlayback::_check_advance_condition`

should be already sufficient.
But also adding "fix" for bug fixes makes quick-glancing at the commit messages easier. So I'd go with something like:
Fix incorrect expression base in `AnimationNodeStateMachinePlayback::_check_advance_condition`

Note that PR title/commit message can be improved, currently after reading it I'd have no idea what it's about (that it's animation related or something like that). For example changing it from:
Use the correct base in _check_advance_condition

to:
Use the correct base in `AnimationNodeStateMachinePlayback::_check_advance_condition`

should be already sufficient. But also adding "fix" for bug fixes makes quick-glancing at the commit messages easier. So I'd go with something like:
Fix incorrect expression base in `AnimationNodeStateMachinePlayback::_check_advance_condition`

Thanks for the suggestion!
I was going to write something like you said, but the Github UI gave me a warning that it was too long

Thanks! However, I see you only changed the PR title. To change the commit message you can use commit --ammend (to change the message) and push --force (to replace the current commit with the changed one) commands. See Modifying a pull request for more details.

Ops, sorry!
Now the commit message is correct too

Does this resolve the second comment? https://github.com/godotengine/godot/issues/62530#issuecomment-1190456551

Does / Can this resolve the second comment? #62530 (comment)

Nope, this only solves the issue for the tree base.

Upon further inspection, setting the root node from the transition never worked, even on the original PR for this feature (#54327). I'm searching for a solution but haven't found anything yet.

Just a note, for me, this can be merged already. Removing or fixing the node root from the transitions should be done on another PR.

Thanks!


Could not find a declaration file for module @material-ui/system

There is no typings in the package @material/system module.

[ ] This is not a v0.x issue.
[x] I have searched the issues of this repository and believe that this is not a duplicate.

Expected Behavior 🤔
Tried import { palette } from '@material-ui/system' but since there are no typings generated, ide throw an error
Current Behavior 😯
Please generate typings in next version. That will be very helpful.
Steps to Reproduce 🕹

create-react-app ts-mat --typescript
yarn add @material-ui@next
import { palette } from '@material-ui/system' in App.tsx

Context 🔦
I shifted from V3 to V4 and I had a few components where theme object is being utilized. I tried replacing it from @material-ui/system package and couldn't make it through
Your Environment 🌎
"react": "16.8.6",
"@material-ui/core": "^4.0.0-alpha.7",
"@material-ui/icons": "^4.0.0-alpha.1",
"@material-ui/lab": "^4.0.0-alpha.6",
"@material-ui/styles": "^4.0.0-alpha.7",
"@material-ui/system": "^4.0.0-alpha.0",
"typescript": "3.4.2"

Duplicate of #14605


Steps are inappropriately skipped even when changed files match the filter

I made a PR with three commits in it. The final commit only touched a few files, so the changed file filter thought only those files were changed, and my other actions were skipped.

Hello, did some of the changes get merged into the target branch first?
Because the action uses git diff to compare versions of source branch and target branch.
Say, the pull requests consists of three commits. But the first commit was cherry-picked by others and merged into the same target branch (normally main or master). When next time the action runs, changes of the first commit will be excluded from the diff and not reported as changed.

No, none of the commits were merged. All were still pending, and the changed file filter skipped out lints and tests without us realizing, so we merged the entire PR all at once.

Update on this issue:
The "multiple commits" may have been a red herring. I just observed the same behavior on a PR with only one commit.
runs:
  using: 'composite'
  steps:
    - uses<EMAIL_ADDRESS>      id: filter
      with:
        filters: |
          hanaq:
            - '.github/**/*'
            - 'hanaq/**/*'
            - '.ruff.toml'
            - 'pyrightconfig.json'
          paqarina:
            - '.github/**/*'
            - 'paqarina/**/*'

I verified in the GitHub Action logs that these paqarina/ files were in the (long) list of files that were changed. Could they have been excluded because they were at the very end, or what happened here?

I created a repository using the rules you provided and added some dummy files through PRs. But I didn't find any unexpected behaviors.
From the snippet you provided, the filter seems to belong to a composite action. I added a composite action when testing.
Both PR and merge changes were detected.

I verified in the GitHub Action logs that these paqarina/ files were in the (long) list of files that were changed. Could they have been excluded because they were at the very end, or what happened here

Can you give me a ballpark figure of how many files were changed? Very long change list could potentially be an edge case because the action call git and parse its output. If output gets truncated because of some unknown limit, it could be the culprit

I noticed the same problem happened again on another large PR with 197 files changed, so I'm beginning to think that's the culprit.

Yes, I can confirm that from my test reuslts.
Found that the action didn't receive the complete stdout when calling git but merely the first output buffer.
I've opened #50 to fix this. Thanks!

@tylerlaprade  v0.2.4 released. If that didn't resolve your issue please reopen this one or create a new issue. Thank you.

Thank you so much! Looking forward to trying this out.


Key mappings through 'langmap' don't respect mappings, if "from" key is not 7-bit ASCII

Describe the bug
When using the 'langmap' setting to map keys from non-English keyboard layouts into keys such as braces and brackets in Normal mode, if the "from" key in the mapping is an accented character such as á, é or ø, or an extended symbol such as €, the "to" is not used to expand mappings defined with that symbol. If the "from" character is a basic symbol such as (, [ or 3, it works as expected.
To Reproduce
Detailed steps to reproduce the behavior:

Run vim --clean
Create a mapping to make < turn the text object uppercase: nmap < gU
Set a langmap with a special key mapping to <, for example :set langmap=á<
Type some contents into the buffer, preferrably lines with lowercase letters and with some indentation.
Use the áj command.

Expected behavior
I'd expect this to behave the same as gUj, meaning turn the current and following line to uppercase.
Instead, this ends up executing the original behavior of <, which is to unindent the current and following line.
The 'langremap' setting doesn't seem to make a difference here. (As I understand it, it defines how the RHS of mappings work.)
Using a symbol in the 7-bit ASCII range seems to work fine, for example :set langmap=[< or :set langmap=3<.
Environment (please complete the following information):

Vim version 8.2.2127 (latest from GH), Vim 8.2.1885 (Fedora), (also DroidVim, version 8.2.1704)
OS: Linux (also Android for DroidVim)
Terminal: GNOME Terminal (DroidVim ships its own copy of the Android Terminal Emulator)

Additional context
Uncovered in this question on the Vi & Vim Stack Exchange.

related (or duplicate of) https://github.com/vim/vim/issues/3018

@tonymec I tried it with both set langremap and set nolangremap (or the equivalent set langnoremap), it doesn't make a difference.
It really looks like the issue @habamax mentioned is the source of this bug.
The discussion over there suggests that a proper fix needs a somewhat deep refactor (and the issue has been around for a while), so not sure how quick we'll get a solution for this one...

yes, this is a duplicate of #3018. So closing. The thing is, this is a core function and I did not feel comfortable to make changes which might affect very many other things.