Add contrail nagios checks

Add nrpe-external-master interface to all (except contrail-openstack)
contrail charms
Add nagios_context and nagios_servicegroups config options to all
(except contrail-openstack) contrail charms

The following nagios checks were added:

contrail-agent:

Add nagios checks as subordinate
Add contrail-status check

contrail-analytics:

Add contrail-status check
Add http check for port 8081

contrail-analyticsdb:

Add contrail-status check

contrail-controller:

Add contrail-status check
Add http check for port 8082
Add http check for port 8143

This was successfully tested with the following bundle:
series: bionic
variables:
  auth-mode:           &auth-mode           'rbac'
  cloud-admin-role:    &cloud-admin-role    admin
  openstack-origin:    &openstack-origin    'distro'
  docker-registry:     &docker-registry     hub.juniper.net/contrail
  docker-user:         &docker-user         include-file://docker-user.txt
  docker-password:     &docker-password     include-file://docker-password.txt
  image-tag:           &image-tag           5.0.2-0.360-queens
machines:
  '0':
    constraints: arch=amd64 tags=os-nodes
    series: bionic
  '1':
    constraints: arch=amd64 tags=os-nodes
    series: bionic
  '2':
    constraints: arch=amd64 tags=os-nodes
    series: bionic
  '3':
    constraints: arch=amd64 tags=os-nodes
    series: bionic
  '4':
    constraints: arch=amd64 tags=os-nodes
    series: bionic
  '10':
    constraints: arch=amd64 tags=os-nodes
    series: bionic
  '11':
    constraints: arch=amd64 tags=os-nodes
    series: bionic
  '20':
    constraints: arch=amd64 tags=os-nodes
    series: bionic
services:
  cinder:
    charm: cs:cinder
    num_units: 1
    options:
      openstack-origin: *openstack-origin
      block-device: None
      glance-api-version: 2
      worker-multiplier: 0.25
      action-managed-upgrade: True
    to:
    - lxd:0
  glance:
    charm: cs:glance
    options:
      openstack-origin: *openstack-origin
      worker-multiplier: 0.25
      action-managed-upgrade: True
    num_units: 1
    to:
    - lxd:1
  keystone:
    charm: cs:keystone
    num_units: 1
    options:
      openstack-origin: *openstack-origin
      admin-password: admin
      admin-role: admin
      worker-multiplier: 0.25
      preferred-api-version: 3
      token-provider: 'fernet'
      action-managed-upgrade: True
    to:
    - lxd:0
  mysql:
    charm: cs:percona-cluster
    num_units: 1
    options:
      max-connections: 1000
      innodb-buffer-pool-size: 512M
    to:
    - lxd:1
  neutron-api:
    charm: cs:neutron-api
    num_units: 1
    options:
      openstack-origin: *openstack-origin
      worker-multiplier: 0.25
      manage-neutron-plugin-legacy-mode: false
      action-managed-upgrade: True
    to:
    - 0
  nova-cloud-controller:
    charm: cs:nova-cloud-controller
    num_units: 1
    options:
      openstack-origin: *openstack-origin
      console-access-protocol: spice
      network-manager: Neutron
      worker-multiplier: 0.25
      scheduler-default-filters: "AggregateInstanceExtraSpecsFilter,NumInstancesFilter,AggregateNumInstancesFilter,RetryFilter,AvailabilityZoneFilter,CoreFilter,RamFilter,ComputeFilter,ComputeCapabilitiesFilter,ImagePropertiesFilter,ServerGroupAntiAffinityFilter,ServerGroupAffinityFilter,PciPassthroughFilter"
      action-managed-upgrade: True
    to:
    - lxd:1
  nova-compute:
    charm: cs:nova-compute
    num_units: 2
    options:
      openstack-origin: *openstack-origin
      enable-live-migration: true
      enable-resize: true
      libvirt-image-backend: qcow2
      migration-auth-type: ssh
      virt-type: kvm
      aa-profile-mode: disable
      action-managed-upgrade: True
    to:
    - '10'
    - '11'
  ntp:
    charm: cs:ntp-28
    num_units: 0
  openstack-dashboard:
    charm: cs:openstack-dashboard
    options:
      openstack-origin: *openstack-origin
      webroot: "/"
      neutron-network-l3ha: True
      neutron-network-lb: True
      neutron-network-firewall: False
      action-managed-upgrade: True
    num_units: 1
    to:
    - lxd:1
  rabbitmq-server:
    charm: cs:rabbitmq-server
    num_units: 1
    options:
      source: *openstack-origin
    to:
    - lxd:0
  # Contrail components
  contrail-openstack:
    charm: ./contrail-charms/contrail-openstack
    series: bionic
    num_units: 0
    options:
      docker-registry: *docker-registry
      docker-user: *docker-user
      docker-password: *docker-password
      image-tag: *image-tag
  contrail-agent:
    charm: ./contrail-charms/contrail-agent
    num_units: 0
    series: bionic
    options:
      docker-registry: *docker-registry
      docker-user: *docker-user
      docker-password: *docker-password
      image-tag: *image-tag
      vhost-gateway: auto
  contrail-analyticsdb:
    charm: ./contrail-charms/contrail-analyticsdb
    num_units: 3
    series: bionic
    constraints: mem=4096 cores=2 root-disk=50G
    to:
      - kvm:2
      - kvm:3
      - kvm:4
    options:
      cassandra-minimum-diskgb: "4"
      cassandra-jvm-extra-opts: "-Xms1g -Xmx2g"
      docker-registry: *docker-registry
      docker-user: *docker-user
      docker-password: *docker-password
      image-tag: *image-tag
  contrail-analytics:
    charm: ./contrail-charms/contrail-analytics
    num_units: 3
    series: bionic
    constraints: mem=4096 cores=2 root-disk=50G
    options:
      docker-registry: *docker-registry
      docker-user: *docker-user
      docker-password: *docker-password
      image-tag: *image-tag
    to:
      - kvm:2
      - kvm:3
      - kvm:4
  contrail-controller:
    charm: ./contrail-charms/contrail-controller
    series: bionic
    num_units: 3
    options:
      auth-mode: *auth-mode
      cloud-admin-role: *cloud-admin-role
      cassandra-minimum-diskgb: "4"
      cassandra-jvm-extra-opts: "-Xms1g -Xmx2g"
      docker-registry: *docker-registry
      docker-user: *docker-user
      docker-password: *docker-password
      image-tag: *image-tag
    to:
      - 2
      - 3
      - 4
  contrail-keystone-auth:
    charm: ./contrail-charms/contrail-keystone-auth
    series: bionic
    num_units: 1
    to:
      - lxd:0
  # Nagios
  nagios:
    charm: cs:nagios
    num_units: 1
    to:
      - 20
  nrpe-container:
    charm: cs:nrpe
    options:
      nagios_hostname_type: unit
      disk_root: ''
      load: ''
      swap: ''
      swap_activity: ''
      mem: ''
  nrpe-host:
    charm: cs:nrpe
    options:
      nagios_hostname_type: host
      xfs_errors: "30"
relations:
  # openstack
  - [ "nova-compute:amqp", "rabbitmq-server:amqp" ]
  - [ "keystone:shared-db", "mysql:shared-db" ]
  - [ "nova-cloud-controller:identity-service", "keystone:identity-service" ]
  - [ "glance:identity-service", "keystone:identity-service" ]
  - [ "neutron-api:identity-service", "keystone:identity-service" ]
  - [ "neutron-api:shared-db", "mysql:shared-db" ]
  - [ "neutron-api:amqp", "rabbitmq-server:amqp" ]
  - [ "glance:shared-db", "mysql:shared-db" ]
  - [ "glance:amqp", "rabbitmq-server:amqp" ]
  - [ "nova-cloud-controller:image-service", "glance:image-service" ]
  - [ "nova-compute:image-service", "glance:image-service" ]
  - [ "nova-cloud-controller:cloud-compute", "nova-compute:cloud-compute" ]
  - [ "nova-cloud-controller:amqp", "rabbitmq-server:amqp" ]
  - [ "openstack-dashboard:identity-service", "keystone:identity-service" ]
  - [ "nova-cloud-controller:shared-db", "mysql:shared-db" ]
  - [ "nova-cloud-controller:neutron-api", "neutron-api:neutron-api" ]
  - [ "cinder:image-service", "glance:image-service" ]
  - [ "cinder:amqp", "rabbitmq-server:amqp" ]
  - [ "cinder:identity-service", "keystone:identity-service" ]
  - [ "cinder:cinder-volume-service", "nova-cloud-controller:cinder-volume-service" ]
  - [ "cinder:shared-db", "mysql:shared-db" ]
  - [ "ntp:juju-info", "nova-compute:juju-info" ]

  # contrail
  - [ "contrail-keystone-auth", "keystone" ]
  - [ "contrail-analytics", "contrail-analyticsdb" ]
  - [ "contrail-controller", "contrail-keystone-auth" ]
  - [ "contrail-controller", "contrail-analytics" ]
  - [ "contrail-controller", "contrail-analyticsdb" ]
  - [ "contrail-openstack", "nova-compute" ]
  - [ "contrail-openstack", "neutron-api" ]
  - [ "contrail-openstack", "contrail-controller" ]
  - [ "contrail-agent:juju-info", "nova-compute:juju-info" ]
  - [ "contrail-agent", "contrail-controller" ]
  - [ "contrail-controller", "ntp" ]
  - [ "contrail-analytics", "ntp" ]
  - [ "contrail-analyticsdb", "ntp" ]
  # Nagios
  - [ nrpe-container, contrail-keystone-auth ]
  - [ nrpe-host, contrail-controller]
  - [ nrpe-host, contrail-analytics]
  - [ nrpe-host, contrail-agent]
  - [ nrpe-host, contrail-analyticsdb]
  - [ nrpe-host, nova-compute]
  - [ nagios, nrpe-container ]
  - [ nagios, nrpe-host]

Hi,
Can you please tell me who wants this functionality, why and when?

Hi @Andrey-mp ,
I'm working for Canonical and we have a customer that requires that feature.
We need this feature to give visibility, into nagios, over the health of the Contrail elements.
We would need this feature as soon as possible.
Thanks for you help!

@Andrey-mp I successfully retested a deployment with the updated charms from 69e818839c36f0d5be4ef2c3df315b3fc6ed39af

all other logic looks good.
just one question - is it OK that script shows just first found error? would it be better to collect all issues and return all?

I reused the exact same logic as yours. It is more or less a copy-paste from https://github.com/Juniper/contrail-charms/blob/R5/contrail-agent/hooks/common_utils.py#L86-L124.
For a first implementation, it might be sufficient.
We might iterate on it and add more features afterwards.

I reused the exact same logic as yours. It is more or less a copy-paste from https://github.com/Juniper/contrail-charms/blob/R5/contrail-agent/hooks/common_utils.py#L86-L124.
For a first implementation, it might be sufficient.
We might iterate on it and add more features afterwards.

OK.

The deployment is successful with the latest pushed commit.


update edc commit to 740c100ac162bc41b1968c232ad81f7d739aefa9 and res…

…olve build errors
Signed-off-by: Dominik Pinsel<EMAIL_ADDRESS>

Great! It would be good to migrate to a862c02fa0dea6a29225344f29ffe0955a7578f7, that will permit to remove the custom oauth2 extension as the changes done here are already merged in upstream.

Yes, we should do this. But as we need the release today EOB I would try to go with this version and do the update later.


Add helper itemgetter function for TautulliStream fields

Fix #156 for fields in Varken NamedTuple which are not in Tautulli API

Thanks!


Create hookah_lounge.json

Create Hooka Lounge preset based on bar.json.
Proper icon still missing.
Closes #959

Thank you for making a PR! For an icon something like https://github.com/FortAwesome/Font-Awesome/issues/13809 should work.


Add ssh key and root cert test in simplified installer test

Remove RHEL 8.3, 8.4, and 8.5 tests
Add ssh key and root cert test in simplified installer test
Add test for configuring user in edge-installer BP

Failures are not caused by this PR. simplified-installer test failed on CS8 and CS9 is because new osbuild-composer is not available on CS8 and CS9.


For v3 before totaly migrating to Java 8 maybe we should have a transition version which supports Java 7

The new facts and rules abstraction which come with v3 is something that Java 7 users would want with their rule engines. Java 8-9 is undinable however lots of people still use java 7 these days especially if they had to maintain old  hevy enterprise applications .
Before totally migrating to Java 8 we should have transition version which supports Java 7. Maybe in later times we can tag this modification in a seperate branch and name it the last version which supports java 7.

You can assign it to me @benas

You are right! I'm closing this issue since your PR has been merged.
Many thanks.
Kr
Mahmoud


only works if called on server start

I'm logging everything as expected except for when the log or uncaught error is called by http latter on

@PedroEsperanca is this still relevant?

oh uau, long time ago maybe :p


Resolve data limit on output passed in the error reporting step of SFN

When running the schema 5.0 migration, we encountered an issue with the SFN failing due to having too much output passed in the error reporting step. We mistakenly thought we resolved this by reducing the amount of information we log to make the payload smaller, and a subsequent run of the SFN (in dev) succeeded. However, upon closer inspection, it seems like by the time we get to the reporting step of the SFN, we've already successfully migrated the dataset and it won't be picked up for migration by a subsequent run of the SFN.
This is probably best resolved by uploading the error reports to somewhere in S3, instead of trying to pass the payload around within the SFN directly. This will also have the benefit of us having more control over how long the error reports are retained for.

@metakuni - moving this to chanzuckerberg/single-cell-data-portal#6790 for triage.

This will likely be obviated by changes to the migration logic that will include greater usage of s3 for logging instead of reporting details of errors/successes to the step function output itself. TBD based on specifics of plan that results from this tech spec.

@danieljhegeman Understood and agreed, as I also suggested persisting logs in S3 in the ticket body as the best solution for solving this. To clarify, the purpose of this ticket is to capture the "business problem" so that Brian and Kuni can understand how to prioritize the work. If we didn't have this problem, we wouldn't consider changing our logging strategy.

@metakuni -moving this back to https://github.com/chanzuckerberg/single-cell-data-portal/issues/6790 per my comments above.  Per the conversation today, I'd also like to keep migration issues decoupled from delivering 5.1.0.

Hmm, ok. I was thinking of using #648 for the infrastructure work and creating a separate epic for the migration, but that makes no sense in hindsight. 🤦 I'll create a separate (pre-5.1) infra epic that we'll tackle before the platform work in #648.

I've made reference to completing this ticket in the Implementation section of the tech spec mentioned in my comment above

Holding off on this since we are not likely to make large-scale changes to the schema migration algorithm in the immediate future (i.e., ahead of Schema 5.1).

Some more investigation yields the following: this error appears to have happened primarily due to executing the SFN on a corpus that had a broken link between old and new dataset versions. This generated a ton of errors of the flavor
{
  "step": "dataset_migrate",
  "error": "An error occurred (404) when calling the HeadObject operation: Not Found",
  "args": [],
  "kwargs": {
    "collection_version_id": <redacted for example>,
    "collection_id": <redacted for example>,
    "dataset_id": <redacted for example>,
    "dataset_version_id": <redacted for example>
  }
}

a broken link between old and new dataset versions

Could you say more about how that condition arises?

In the most recent invocation that resulted in this particular error, we had 510 datasets that failed. Again, largely failing with the error detailed immediately above that is an artifact of running the SFN in an adhoc fashion where the original version for a dataset could not be easily retrieved. In other words, it is not because we're outputting too much data for individually-erroring datasets that we might expect during the course of a normal migration run.
This sort of thing should not be happening in the future, because it was all downstream of deploying to dev in the middle of a step function. If we don't do that, then we won't run into this error either. I recommend we not take action on this issue at this time, as it is not likely to pay dividends cc @metakuni @Bento007

a broken link between old and new dataset versions

Could you say more about how that condition arises?

@brianraymor this is the scenario that comes from a mid-sfn-run deployment which breaks the step function between the 'dataset migrate' step and the ingestion step. It causes the db to end up in a funny state where dataset version rows exist but no assets are in s3 under that version id. I ended up adding temporary adhoc code to recover some (possible for revisions only; not unpublished private) for the sake of the dev migration testing when this occurred originally.
Recommended course of action in the future is to simply reset the db and start from scratch rather than attempting to hobble through a (test) migration with these broken links.
To summarize: this will not happen as long as Engineering doesn't make mistakes by deploying mid-run again. And if they do that, they need to start over.

Unnecessary per reasoning given above


no match for some QQP IDs

Hi,
The ID for some of the examples in your split of Quora do not match the original Quora file, e.g, the first line of your test.tsv is:
1       What should I do to avoid sleeping in class ?   How do I not sleep in a boring class ?  50018
and, in the original Quora file at:
https://data.quora.com/First-Quora-Dataset-Release-Question-Pairs
id 50018 corresponds to:
50018   35003   17537   What is the cheapest, painless, easiest way to commit suicide?  What is the cheapest method to commit suicide?  1
some IDs match, such as the first example in train.tsv.
What happened? How can I relate the original Quora data and your partition?
Best,

Hi , have you sloved this problem?


access specifier warning

i'm getting warning saying, MarialDialog.Builder() as protected access in MatrialDialog

You can safely ignore related warnings.
They're protected so that people who want to subclass MaterialDialog can access them.


Auto-setup GitHub caches for python and pip

https://askubuntu.com/questions/519066/where-are-the-apt-indexes-stored-and-can-they-be-removed


Improve Search commands

The /wiki and /docs commands both perform searches.
We should investigate if and how the search can be improved for users.
Possible techniques to explore:

Auto-Completion for known Keywords / Classes
Fuzzy Searches
...

To get the best experience from auto completion we should most likely start to cache the Javadoc and wiki and once in a while i.e. 1 hour interval refetch them automatically.


Conserto do link quebrado da imagem

Explicação adicional da tabela verdade e sua importância

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)
[x] My pull request targets the master branch of freeCodeCamp.
[x] None of my changes are plagiarized from another source without proper attribution.
[x] My article does not contain shortened URLs or affiliate links.

If your pull request closes a GitHub issue, replace the XXXXX below with the issue number.
Closes #XXXXX

Congrats @LEpessoa  on your first pull request (PR)! 🎉
Thank you for your contribution to the page! 👍
We're happy to accept these changes, and look forward to future contributions. 📝


Added lastUpdate state update to ensure that synchronized commits display a succeeded status

Proposed changes
The proposed changes add lastUpdate state changes when a commit ID is already synchronized, but the stack is not already marked as succeeded.
Related issues (optional)
https://github.com/pulumi/pulumi-kubernetes-operator/issues/428

/run-acceptance-tests


Recent and saved connections are empty

SQL Operations Studio Version: master branch

Steps to Reproduce:

Click "New Connection"
Observe recent connections are empty
Go to saved connections and see it's empty too

This is a major regression. Not sure when it was checked in

We'll be tracking this in #958 so I'll close this copy of the issue


[FEATURE] Add Feature for Holiday Packages to Users

Description: We need to implement a new feature that allows users to access and manage holiday packages within the GSOC system. This will enhance user engagement by providing them with a seamless way to explore and book holiday packages directly through our platform.
Feature Details :
User Interface: Design and implement a section where users can view available holiday packages.
Packages: The feature should include detailed descriptions of packages, pricing, and availability.
Booking: Users should be able to book holiday packages and view their bookings in their profile.
Also We can add some Hotels that we can include in holiday packages

Pls assign this to me i will work on it


Support YugabyteDB as a storage backend

Requirement
YugabyteDB has a large, loyal user community that has raised the desire for YugabyteDB to be an officially recognized storage backend for Jaeger.
Problem
Currently, YugabyteDB is not an officially supported storage backend for Jaeger.
Proposal
By giving official support to YugabyteDB, it will improve the quality of experience for users who want to use Jaeger as a tracing platform in conjunction with YBDB. Additionally, official support might also benefit Jaeger via current users of YBDB who are looking for supported tracing platforms.
Open questions
No response

no interest from the community


Added tryAccept function (accept without throwing)

accept throws a SocketAcceptException when it is non-blocking and there is no connection which is bad for performance. tryAccept simply returns null instead of throwing

accept throws a SocketAcceptException when it is non-blocking and there is no connection which is bad for performance.

Generally the non-blocking flow is to add a listening socket to a SocketSet and select loop, then only call accept once select indicates it's readable.
Do you have a use case where the above is not applicable?

Uh I rarely ever used select and SocketSet but the advantage with this function is that it looks much more simple and more intuitive, plus it integrates much smoother with Fibers.

Can you give me an example of how you would use this function in your application?

// simplified but a bit like this
void acceptFiber()
{
  while (true)
  {
    auto client = server.tryAccept;
    if (client !is null)
      spawnFiber(new ClientFiber(client));
    Fiber.yield();
  }
}

I know it is possible with SocketSet and select too but I simply find this more elegant

// simplified but a bit like this

That code is not great because it will spin consuming 100% CPU all the time.

Uh I rarely ever used select and SocketSet

If you are using fibers and non-blocking sockets, you pretty much always also want to have an event loop. Generally, the event loop holds the responsibility of notifying the fibers when a connection socket is readable, or a listening socket is ready to accept a new connection.
I suggest that you have a look at how various networking libraries implement this, and try it out in practice in your own application, before submitting a patch to Phobos.
OK to close?

hm ok sure you can close this, I am currently writing an implementation with SocketSet to try it out because the CPU was so busy, I simply didn't do so before because it felt a bit hacky always readding the sockets (tip for other readers, there is a nice example doing a simple server with SocketSet here).
Also I'm just gonna push the documentation updates for the sake of completion though


PP-3265 Jenkins jobs converted to use selenium style smoke tests for all [DO NOT MERGE]

microservices
Smoke tests are being converted from cucumber to selenium so deployments
to ECS must now pass in their smoke test class, or default to all card
payment tests. Changes will need to be made to direct debit connector
and direct debit frontend for their specific smoke test classes.
Products already pass the correct smoke test class

Do Not Merge - requires all cucumber tests to be converted

I actually would like to do this from the jenkinsfile of the app, rather than triggering from deploy job

We are moving to each Jenkins file calling the relevant smoke tests, this will be done in another stream of work.


Gather info about the wiki size #7

Create a dashboard entry that shows info about the size of all available wikis.

Instance usage dashboard section:

This is a continuation of #19. The most important files added are: InstanceUsage.java and the created test, wikiSizeTemplate.vm and wikiSizeResult.java.


[Feature] Allow configuring menu placement on screen

There is already the option to configure a "Dropdown Gap" in Configuration > Bar. I think it would be nice if you could also configure the left/right placement of each menu, or at least make the menus respect the "Margin Sides" setting by default.

On a sort of semi related note, it would also be cool if changing the opacity of the menus/cards didn't change the opacity of the buttons or contents of the cards.


cannot subset NotoSansMyanmar-Regular.ttf

I ran this command:
pyftsubset NotoSansMyanmar-Regular.ttf --unicodes=U+1000-109F --output-file=NotoSansMyanmar-Regular-subsetted.ttf
the subsetted font has three serious errors warned by FontBook of Mac:

@jungshik @brawer

Hmm... I wonder why it's complaining about 'sfnt' table.
Have you tried a subsetted font with ots?

BTW, perhaps this had better be filed in fonttools/fonttools.


⚠ Bofrost.at has degraded performance

In 775ce77, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1032 ms

Resolved: Bofrost.at performance has improved in 8a47c0a after 6 minutes.


cue: performance pathology when evaluating field comprehension

What version of CUE are you using (cue version)?

$ cue version
cue version v0.9.0-alpha.5

go version go1.22.0
      -buildmode exe
       -compiler gc
  DefaultGODEBUG httplaxcontentlength=1,httpmuxgo121=1,tls10server=1,tlsrsakex=1,tlsunsafeekm=1
     CGO_ENABLED 1
          GOARCH arm64
            GOOS darwin
cue.lang.version v0.9.0

Does this issue reproduce with the latest stable release?
Yes, I discovered it on v0.8.2 initially, which behaves the same way.
What did you do?
Please see grpc_reproducer.txt. I discovered what seems to be a bug or a performance pathology in the evaluator when using the field comprehension (descriptor.packageName): descriptor on line 52 of grpc.cue (line 55 of the attached text file). Evaluation does not seem to finish in any reasonable amount of time, but I've only left it running for at most a couple of minutes, so I don't know if it eventually terminates. Commenting out the apiDescriptors declaration makes evaluation terminate quickly, as expected.
Note that evalv3 fixes the problem for the attached reproducer, but I am filing this issue anyway, just in case it is informative in some way. Apologies if it is not, or if this report is a duplicate, but I could not find something similar in a reasonable amount of time when I searched the issues.
What did you expect to see?
An invocation of cue eval -c which terminates in a reasonable amount of time. With CUE_EXPERIMENT=evalv3, this is indeed what I see.
What did you see instead?
cue eval -c hangs for a long time unless I am using evalv3.

Thanks for filing this issue! It is indeed useful and informative even if we can just close it as "resolved by the new evaluator" :) I will leave it open for the time being, as the new evaluator is not on by default yet.

I'm going to close this one out just like the other "evalv3-win" issues we have labelled and closed. Unlike the others, I'm not adding a regression test, because the CUE involved is very long at nearly 4k lines of code, and it is too slow on evalv2, whereas we still test on both evaluator versions for the foreseeable future.
Thanks again for filing this!


Invalid OpenAPI JSON - path parameter collection_id missing in PUT and POST

I'm trying to use the OpenAPI JSON produced by stac-fastapi to set up the API in Azure API Management. When validating the OpenAPI JSON, I get the following error
Declared path parameter "collection_id" needs to be defined within every operation in the path (missing in "put", "post"), or moved to the path-level parameters object

This can be fixed by manually editing the OpenAPI JSON and adding:
"parameters": [
    {
        "description": "Collection ID",
        "required": true,
        "schema": {
            "title": "Collection Id",
            "type": "string",
            "description": "Collection ID"
        },
        "name": "collection_id",
        "in": "path"
    }
],

into the definitions for the PUT and POST requests for /collections/{collection_id}/items.
I've tried to work out how to fix this myself, and have tracked it down to the differences between the code in register_get_item_collection in app.py and register_create_item and register_update_item in transaction.py. The former defines a request model:
request_model = create_request_model(
            "ItemCollectionURI",
            base_model=ItemCollectionUri,
            mixins=[get_pagination_model],
        )

that specifies the collection_id path parameter. But the latter only specify a request model of Item which doesn't have that path parameter.
I've tried creating a new request model of:
class ItemWithCollectionPathParam(stac_types.Item):
    collection_id: str = attr.ib(default=Path(..., description="Collection ID"))

and using that as the request model as follows:
def register_create_item(self):
        """Register create item endpoint (POST /collections/{collection_id}/items)."""
        self.router.add_api_route(
            name="Create Item",
            path="/collections/{collection_id}/items",
            response_model=Item if self.settings.enable_response_models else None,
            response_class=self.response_class,
            response_model_exclude_unset=True,
            response_model_exclude_none=True,
            methods=["POST"],
            endpoint=self._create_endpoint(self.client.create_item, ItemWithCollectionPathParam),
        )

But that doesn't seem to fix the OpenAPI JSON.
I'm happy to put in a PR to fix this, if someone can give me some advice on where/how to fix it.

@robintw I believe this is actually related to #406 and #384. Those endpoints did not include the {collection_id} in the request model, and I am guessing that is why they do not show up in the OpenAPI JSON. I'm working on a PR to address those issues and I'll let you know if it fixes this one as well.

That sounds great, thanks @duckontheweb


Social/academic icons not visible

While I was working on my web site I realised that the social/academic icons related to Twitter, GoogleScholar, ResearchGate, etc. are not visible on my old MacBookPro (1280x800 display).
I checked the demo available at https://sourcethemes.com/academic/ and the same behaviour is present (see attached image). However, social/academic icons are visible with Google Chrome. Furthermore, on iPhone, iPad and iMac social/academic icons are always visible.
I guess there is something related with CSS or with Safari but I'm not able to figure out.

You could try adding disable_sri = true under the [params] part of your config.toml. Possibly may help.

Nothing changed.

It may be related to #165 - i.e. using very old web browsers that do not support current HTML5/CSS3 web standards. Updating the browser, if possible, may help.

The browser is Safari updated to the latest version 10.1.1. This version shows fine the web page on iMac but not on a MacBookPro 13''. Old browsers usually show the social icons vertically instead of horizontally. In this case the social icons are completely missing.

I have the same issue.

MacBook Pro (Retina, 13-inch, Early 2015)
macOS Sierra 10.12.6
Safari 10.1.2

I fixed this issue by changing social-icon to social-test in layouts/partials/widgets/about.html and static/css/hugo-academic.css. However, I don't understand why this works.

I think this issue is related to Adblock Plus's Fanboy's Social Blocking list, in which social-icon is blocked. It seems that AdBlock Plus for Safari enables this blocking list by default, while AdBlock Plus for Chrome doesn't. This explains why these icons are invisible only for some Safari.
Maybe we can change social-icon to a new name to avoid being blocked?

I can confirm that after disabling Adblock on MacBookPro using Safari the social icons are now visible. The strange thing is that Adblock appears to hide the icons only on Safari running on MacBookPro machines and not on iMac.

Closing this as it will be improved in #276 by renaming the CSS (although the authors of the advert blocking plugins/lists should really correct it in their code/list instead).

Hi! I have the same problem. I can see the email icon, but not twitter icon.

I have added this piece code to "themes/hugo-academic/layouts/partials/widgets/contact.html":      {{ with $.Site.Params.twitter }}
                        {{ . }}
      {{ end }}
And added this to config.toml:
    icon = "twitter"
    icon_pack = "fa"
    link = "https://twitter.com/FanZhang_Jessie"```

How to deal with this?

Thanks,
Fan

cdn=true fixed it for me.


[Bug]: webpack_public_path runtime does not function correctly when using Webpack Module Federation.

Version
System:
    OS: macOS 14.5
    CPU: (10) arm64 Apple M1 Pro
    Memory: 172.09 MB / 16.00 GB
    Shell: 5.9 - /bin/zsh
  Browsers:
    Chrome: 130.0.6723.117
    Safari: 17.5
  npmPackages:
    @rsbuild/core: ^1.1.1 => 1.1.1
    @rsbuild/plugin-react: ^1.0.7 => 1.0.7

Details
When my remote app uses Webpack, webpack_public_path is set to the path of the remoteEntry.js import.
When my remote app uses RSBuild, webpack_public_path is set to window.location.origin.
As a result, when the remote app is loaded with RSBuild, the component is not loaded from the correct path.
The main application is located at http://localhost:1000/, where the host MWF is running. I need to load BugRsbuild, which is located at http://localhost:1000/static/bug-rsbuild/remoteEntry.js. After loading the remoteEntry.js, I expect that the remaining components will be loaded from the path http://localhost:1000/static/bug-rsbuild/..., but it loads everything from http://localhost:1000/..., resulting in an error.
But when use Webpack, work great:

When use rspack:

Reproduce link
https://github.com/cairon666/rsbuild-webpack-public-path-bug
Reproduce Steps

donwload nginx
load nginx.conf config
start nginx
npm i
npm run dev
go to localhost:1000
click the buttons

This might be related to the default value of output.publicPath being auto in webpack. You can try setting output.publicPath to the same value and then see if the results are consistent.

It seems that the issue was resolved by adding output.publicPath: "auto". Thank you!


Text going down instead of to the right

This is where I tested it, granted there are other issues but I think being able to read output properly would be a start, I think it might be the width & height to draw into being swapped judging by the way it displayed.
https://apps.facebook.com/islandexperiment/

These are the raw config options I tried together on the page
shumway.ignoreCTP = true
dom.mozBrowserFramesEnabled = true
shumway.rtmp.enabled = true
dom.mozTCPSocket.enabled = true


Update bug_template.yml to show app.all-hands.dev

End-user friendly description of the problem this fixes or functionality that this introduces

[ ] Include this change in the Release Notes. If checked, you must provide an end-user friendly description for your change below

Now people are starting to use app.all-hands.dev as a way to use OpenHands, we should probably add it to the bug template!

To run this PR locally, use the following command:
docker run -it --rm   -p 3000:3000   -v /var/run/docker.sock:/var/run/docker.sock   --add-host host.docker.internal:host-gateway   -e SANDBOX_RUNTIME_CONTAINER_IMAGE=ghcr.io/all-hands-ai/runtime:63d1202-nikolaik   --name openhands-app-63d1202   ghcr.io/all-hands-ai/runtime:63d1202

These make sense!
Just to clarify though, the online site will be running the open source software, so open source contributors will certainly be able to fix issues that appear when people run things there. And the two apps will largely be at feature parity, so it's not like the online site is extremely exclusive or anything. I don't know if that helps?
In terms of user support in billing, I assume that we will have something separate for that, but we're not that far yet.
As one idea, maybe we could put this later in the list instead of first?

Yeah it's a tough call. If you all made the decision to add this, I would add the new option last so it doesn't show up as the default for now.

Just a detail on this:

Just to clarify though, the online site will be running the open source software, so open source contributors will certainly be able to fix issues that appear when people run things there.

Of course, I'm sure the first is mostly the case. I'm not equally sure that the latter follows.
Not very relevant perhaps, but slightly related: a couple of nights ago I had to get out of bed to go try to repro an issue I was seeing on the site. Because amanape asked me to report it, and I realized I didn't know how to report it, I hadn't seen it before so I wasn't sure whether it is on the project or only on the site. I couldn't quite repro locally so I posted it for the site.(So I settled for the idea that there might be something site-specific, which may well not be accurate.)
An issue you cannot repro locally usually means a number of things. If it was seen on the site, however, it can mean a number of other things, specially when related to sessions, to auth, to user setup, to workspace setup, to permissions. 🤷
Surely, the agent is the same agent, but the agent errors might or might not be, I don't know, it depends. And people don't usually report good behavior. 😅
Thank you for taking the time for this discussion. I only found out about this intention a couple days ago, and I honestly didn't get to grapple with the consequences. I do think it's non-trivial.

Thanks @enyst , I see where you're coming from, and I also understand as well. Debugging on the hosted version is more opaque for me as well because I'm not really able to dig through the logs.
Just as a thought experiment, what are the options that we have here:

Status quo: We keep the form the same. If so, every time I choose "installation method" I need to pick "docker" or "dev workflow", but neither of these apply when I'm using it on the site.
Current proposed solution
Some other solution such as having an entirely different workflow for reporting issues for site users? This seems a bit sub-optimal, because that would fragment knowledge about potential issues, and many or even most of the issues on the site stem from something in the oss repo.

I realize that there's no perfect solution here, but I still would lean towards "2." It seems easier logistically and a good way to keep things as open as possible and share knowledge with the whole community. But on the other hand, I do understand that you (and likely others) may be frustrated by seeing some bugs that are not stemming from the open source.
And yes, thanks from my side for the discussion too! As always, OpenHands is a community effort, and I want to make sure we end up with something that everyone is happy with!

Well said. Option 2 seems to make a lot of sense for simple, pragmatical reasons.
I may be dense, I admit I initially assumed that the hosted app support is, or will be, part of a separate project set up for "all-hands.dev" website (option 3).
Let me take your thought experiment and go deeper into option 2: same place. If the site is here, what does it bring with it and where are the limits? They are shifting.

You say that the issues will be mostly with oh, and I see why that is likely. But I hear on slack that AH has an NDA for people to sign. I have no idea what is that about. Where are users under NDA going to post about their issues?

Are we looking to see here posts like "there was also a lot of red error text but I don't know if I'm allowed to talk about it here because NDA"?
This is a pragmatical question as well as a values question. On the pragmatical side, I don't see how that would work in a public repo.
On the other side. "Open source but you're not allowed to speak" would seem to be the new normal. I do question whether that is a value this project should have and what consequences it will have on it.

The more I think about it, the more option 2 makes sense. But it implies, shall we say, a tighter integration between this project and the site. From the project side, that is.
So, speaking of the site, I noticed a funny thing or two. Unlike the above, they're not exactly pragmatical issues with option 2, but they are little interesting tidbits and worth bringing up IMO.

The ToS for the website/service is public. Frankly most seems to be boring legalese, but there's a rather amusing detail.

The following are examples of kinds of content and/or uses that are illegal or prohibited...[AH reserves the right to...] including reporting the violator to law enforcement authorities.

 Really bad. Law enforcement authorities bad. Then among them:

engage in or use any data mining, robots, scraping, or similar data gathering or extraction methods.

About this...

We are an AI open source project; we work with LLMs day in day out; and internet datasets; we have an agent grabbing axtrees and we may do in-context learning on up-to-date software library documentation, to name just a few. 😂
Data mining and web scraping public data are legal. And well, essential. (Private data is different, because it's private data, not because of data mining or scraping.)
Does AH want to prevent people from scraping its website? Well OK, it's its website, surely the AH team can monitor and try to stop it if so it wants, this paragraph is IMO unnecessary. Idk though, we may have forgotten to tell our agents. 😅
As a policy matter, I believe AH is mistaken to add this on its website.
(IMO, you're helping interests that would like nothing more than to make startups like this pay through their teeth for the crime of fine-tuning llama or browsing the internet archive. That's just my honest opinion.)
What is your position on this?

Last, and least.

The same ToS (it's disputable if anyone reads or cares about these things, and whether it'd be worth your time and resources to even think of enforcing, but well, words have meaning)

Competitors: No employee, independent contractor, agent, or affiliate of any competing open source software development company is permitted to view, access, or use any portion of the Service without express written permission

A curious little detail... why single out "open source software development company", and not all competitors if so, is that a typo?
In the early days, "Devin" from "Cognition AI" apparently submitted a PR. I remember that when I brought it out in our slack, everyone was amused and excited. Is something like that becoming frown upon? Sorry, it was fun.
We also have a lot of issues posted in this repo, afaik roadmap-worthy, that describe or even include screenshots from devin. This... seems a little ironic.
On the other hand, please correct me if wrong, I think AH is not trying to enforce this. Then why say it? Legal stuff has the habit to become part of the shared understanding in a community. I believe people internalize it as shared values. Just like licenses. Just like it's meaningful that the license is MIT, a "live and let live" license.

Hi @enyst , thanks for sending! I just want to acknowledge that I saw this and will take a closer look but it might take a few days. CC @rbren for visibility too. Terms of service are obviously important but they need to reflect our values, so I'll take a close look at what we have now and circle back!

Thanks @rbren, 100% agree on revisiting the terms and thank you to @enyst for pointing this out (I didn't think as deeply about them as I should've either).
For the time being, I added "app.all-hands.dev" as one option but at the bottom of the list, and also added "Other" for other setups too. Let me re-request review, but I'm also happy to continue the discussion!

Thanks a lot! And let's continue the discussion, these sorts of things are super important to discuss and get right, so in the future I'll try to run things by you whenever there are similar decisions to be made.


Fix Compilation Error in React Native 0.47.0

createJSModules was removedin React Native 0.47.0 and results in the attached Build Error.
removing @Override fixes build (didn't remove function because I don't know if it should be kept for downard compatability?)
node_modules/react-native-fetch-blob/android/src/main/java/com/RNFetchBlob/RNFetchBlobPackage.java:23: error: method does not override or implement a method from a supertype
    @Override
    ^
1 error

Incremental compilation of 1 classes completed in 0.219 secs.
:react-native-fetch-blob:compileReleaseJavaWithJavac FAILED

FAILURE: Build failed with an exception.

Thank you for making a pull request ! Just a gentle reminder :)

If the PR is offering a feature please make the request to our "Feature Branch" 0.11.0
Bug fix request to "Bug Fix Branch" 0.10.7
Correct README.md can directly to master

Okay, thanks ! I think this is necessary, will see if that's backward compatible.


Log transaction start, commit, and rollback events

Transactions are not currently logged; this makes testing that transactions were properly applied to a given operation more difficult. This PR adds simple logging of transactions. Logging these up at the Fluent level might be a better solution in the long term since it would cover all drivers that support transactions, not just MySQL.

It would be rather difficult to do this at the Fluent level, so I think it's good here for now. Thanks :)


Unable to locate request-reviewers.yml

I'm trying to run the action but get this error
`Warning: Unexpected input(s) 'GITHUB_TOKEN', 'config_path', valid inputs are ['who-to-greet']
Run neo-diego-beltran/request-reviewers@f028375d516d93d6a4dd5f93feccfc7f3c768a9b
with:
GITHUB_TOKEN: ***
config_path: .github/request-reviewers.yml
who-to-greet: World
Repository owner: riversidefm
Repository name: mobile-test
Could not get the content from content path .github/request-reviewers.yml ERROR: HttpError: Not Found
Could not get the content from content path .github/CODEOWNERS ERROR: HttpError: Not Found
Current PR number: 1
Current PR labels: Studio
Current PR author: YoavGro
Current PR CODEOWNERS:
Current PR reviewers To Remove: YoavGro
Current PR teams assignees:
Current PR individuals assignees:`

The .github/request-reviewers.yml
Has the config file as the docs say

hey, you can try setting your with section with the following code example
with:
      GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
      config_path: '.github/request-reviewers.yml'
      codeowners_path: '.github/CODEOWNERS' <- this path is not required but the file needs to be there

Yep, that did the trick
thanks!
How do I use the code owners file?


Allow flutter hackers to rerun dashboard tasks

cc @CaseyHillers
Members of flutter-hackers could be granted permission to rerun tasks on the dashboard, so long as they have a an email connected with Google. These emails can be added to an allowlist in the datastore that manages these permissions. Currently it is limited to contributors with @google.com emails.
I've heard from some contributors that are in other time zones that would like to help manage the tree while most contributors with @google.com are offline.

Currently, someone at Google adds the email to the datastore, which isn't well documented in the team onboarding.
Longer term, it would be easier if Cocoon had a cron job that synced the Flutter organization, and set the allowlist table to be what was in GitHub.


Support for max date range

Copied from old repo
Feature Request from https://github.com/LuisWolf-Snapaddy
It would be nice to have an input maxRange where you can specify that a user should only be allowed to to select a range of e.g. a week ([maxRange]="7").

Already closed via #10


Fix typo in Reboot.md

Description
Fix a typo in Reboot.md, change from CTRL + , to CTRL +  ,
Motivation & Context
As mentioned in the related issue, CTRL + , is a little confusing since it shows "+" as if it was part of the key input. However, it is not, and I believe it is better if we kept it outside the kbd tag.
Type of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Refactoring (non-breaking change)
[ ] Breaking change (fix or feature that would change existing functionality)

Checklist

[X] I have read the contributing guidelines
[X] My code follows the code style of the project (using npm run lint)
[ ] My change introduces changes to the documentation
[X] I have updated the documentation accordingly
[ ] I have added tests to cover my changes
[ ] All new and existing tests passed

Live previews
https://deploy-preview-38001--twbs-bootstrap.netlify.app/docs/5.3/content/reboot/#user-input
The updated section should look like this:

Related issues
Closes #38000

IMO we can let it as it is now since it's just a matter of styling; both are possible (source: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/kbd).
If others think this PR brings more clarity too, I don't mind making such a change but the PR will need to modify all occurrencies in the project where  is used.

Hi @julien-deramond, thank you for your comment.
You're right, it is eventually a matter of style. However, the difference between Bootstrap kbd style and the one in the MDN documentation, is the fact that in the MDN documentation, all the examples containing nesting have custome styling in their CSS to support it using CSS combinators, in a way that makes the output more understandable. On the other hand, in bootstrap, I believe the KBD tag does not support nesting. That is why thee "+" was styled as a Keyboard input. We can either remove the nesting, or we can also add custom styles for nesting in the CSS. I guess we can also disregard the pull request as at the end of the story it is just a matter of style.
Thank you for your input!

I guess then we can drop the nesting approach (as suggested in this PR but everywhere in the docs): Key + Other Key → Key + Other Key for better readability.
On my side I haven't found any evidence of a better a11y with the nesting approach.
Before applying this modification everywhere, @patrickhlauke do you have more info about whether it's best to surround the combination of keys with a  for a11y purpose?

for what it's worth, screen readers don't make any special announcement about  being there or not. these sorts of text level semantics generally just don't get announced in any special way. so purely from a screen reader experience perspective, there's no material difference (heck, there's no difference to whether you use  or not in the first place).
so I think it comes down to personal preference. personally, i'm ok having the plus sign all part of the  as  isn't about the individual key, but about the keyboard input you need to perform, and i doubt (though might be wrong) that people get confused about the fairly common case of "something plus something else" meaning that they need to press these simultaneously (rather than needing to press the + key)

Hi @patrickhlauke , thank you for your input.
It might be unnecessary to clarify it, especially for experienced people. But I guess it may be helpful for those who are not familiar with Bootstrap. For instance, if we go back to the MDN Docs shared above, even in the nested case, there is always a difference between the keys to be pressed, and the indicative "+" sign.
I also think it won't be difficult to go through all the KBD tags and remove the nesting in all the documentation.

Thanks for the PR. Let's leave it as is and we can revisit later if needed.


Add Quantizable MobilenetV3 architecture for Classification

The pre-trained model was trained:
python -m torch.distributed.launch --nproc_per_node=8 --use_env train_quantization.py\
--model='mobilenet_v3_large' --wd 0.00001 --lr 0.001

Submitted batch job 35496554
Validated with:
python train_quantization.py --device='cpu' --model='mobilenet_v3_large' --test-only

Accuracy metrics (Epoch 89):
Acc@1 73.004 Acc@5 90.858

BTW, test failures seem to be related

@fmassa Thanks for flagging. I fixed the issues, did 1 epoch of training and 1 validation to ensure everything still works fine. The rest of the failing tests are not related to this PR. So we should be OK.


fix(ingestion): Only apply python restriction on looker module

Checklist

[ ] The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
[ ] Links to related issues (if applicable)
[ ] Tests for the changes have been added/updated (if applicable)
[ ] Docs related to the changes have been added/updated (if applicable)

@treff7es We would need changes in the github workflows also. If you search for 3.9.9 in the repository you will find restrictions added in multiple github workflows files in .github folder.

@treff7es We would need changes in the github workflows also. If you search for 3.9.9 in the repository you will find restrictions added in multiple github workflows files in .github folder.

We have Looker test which only runs on python <= 3.9.9 as it is still a restriction but limits it to a module and not everything.

This pr is obsoloted by this pr:
https://github.com/linkedin/datahub/pull/4312


[CeskaTelevizeBridge] Add New bridge

This bridge gets the latest videos of specific show url from https://www.ceskatelevize.cz/porady/

Hi @em92, thanks for your points.
Everything should be fixed.

gj @kolarcz !


Refs #18 -- Added as_list and as_tuple type converters

What, no docs? :)

I don't start writing docs before I know the patch is going to be accepted :wink:

All that's holding it back ... is the lack of docs.

There you go!


Clean up the sandcastle session properly when an SRPM build fails

So the cleanup is not run when an SRPM build fails?

Yes, that's what I've deduced from the logs. There was no Pod/PVC deletion status ... in logs after the crash.
Originally posted by @jpopelka in https://github.com/packit/sandcastle/issues/114#issuecomment-814938858

Succesful build
Logs:

reporting.py      DEBUG  Setting status 'pending' for check 'xyz': Starting RPM build...
abstract.py       INFO   Cleaning up the mess.
...
abstract.py       DEBUG  Job finished!
Deleting sandcastle pod.
PVC deletion status = ...

I'm wondering where/how do we actually call the sandcastle cleanup. I'd expect it in JobHandler.run_job() -> JobHandler.run_n_clean() -> JobHandler.clean() -> PackitApi.clean() -> SandcastleCommandHandler.clean(), but in that case would the Deleting sandcastle pod. be in logs before the Job finished!, not after it.

Failed SRPM build, i.e lingering pod & pvc left behind
Logs:

reporting.py      DEBUG  Setting status 'failure' for check 'xyz': SRPM build failed, check the logs for details.
abstract.py       INFO   Cleaning up the mess.
...
abstract.py       DEBUG  Job finished!
abstract.py       ERROR  SRPM build failed, check the logs for details.
Task TaskName.copr_build[abc] succeeded in 1526s:

That's my expectation as well.
Sadly I won't have time to work on this today, wanna finish some other work.

With the repository-cache volumes in the deployment, this is now a real problem.
When we leave the pod without clean-up, the old pod has the repository-cache volume mounted what blocks the creation of a new pod.
Here are some examples:

Two failed SRPM builds:

https://dashboard.packit.dev/results/srpm-builds/31105
https://dashboard.packit.dev/results/srpm-builds/31115

And pod can't be created in the next one:

https://dashboard.packit.dev/results/srpm-builds/31116


Example in README causes panic at 'called Option::unwrap() on a None value'.

If I follow the example in the README I get an:
    Finished release [optimized] target(s) in 0.17s
     Running target/release/deps/typing_project-b07c93921eeddaff

running 2 tests
test lm::tests::model_lengths ... ignored
test lm::tests::prediction ... ignored

test result: ok. 0 passed; 0 failed; 2 ignored; 0 measured; 0 filtered out

     Running target/release/deps/my_benchmark-ff1bb30b4a742495
thread 'main' panicked at 'called `Option::unwrap()` on a `None` value', libcore/option.rs:345:21
stack backtrace:
   0: std::sys::unix::backtrace::tracing::imp::unwind_backtrace
   1: std::sys_common::backtrace::print
   2: std::panicking::default_hook::{{closure}}
   3: std::panicking::default_hook
   4: std::panicking::rust_panic_with_hook
   5: std::panicking::continue_panic_fmt
   6: rust_begin_unwind
   7: core::panicking::panic_fmt
   8: core::panicking::panic
   9: criterion_plot::version
  10: <criterion::Criterion as core::default::Default>::default
  11: my_benchmark::main
  12: std::rt::lang_start::{{closure}}
  13: std::panicking::try::do_call
  14: __rust_maybe_catch_panic
  15: std::rt::lang_start_internal
  16: main
error: bench failed

Rust version is rustc 1.30.0-nightly (f2302daef 2018-09-12) on macOS 10.14 running Visual Studio Code.
Relevant extract from my Cargo.toml:
[dev-dependencies]
criterion = "0.2"

[[bench]]
name = "my_benchmark"
harness = false

And benches/my_benchmark.rs:
#[macro_use]
extern crate criterion;

use criterion::Criterion;

fn fibonacci(n: u64) -> u64 {
    match n {
        0 => 1,
        1 => 1,
        n => fibonacci(n - 1) + fibonacci(n - 2),
    }
}

fn criterion_benchmark(c: &mut Criterion) {
    c.bench_function("fib 20", |b| b.iter(|| fibonacci(20)));
}

criterion_group!(benches, criterion_benchmark);
criterion_main!(benches);

Not sure if that is related to #188, but I am not (consciously) using Valgrind or any other instrumentation.

Hey, thanks for trying Criterion.rs! I think this might be a duplicate of the issue in #227. Could you try it again using the latest Git version (see https://doc.rust-lang.org/cargo/reference/specifying-dependencies.html#specifying-dependencies-from-git-repositories) and see if you still have this issue?

Thanks, that was indeed the problem. Gnuplot itself fails with:
dyld: Library not loaded: /usr/local/opt/lua/lib/liblua.5.2.dylib
  Referenced from: /usr/local/bin/gnuplot
  Reason: image not found
fish: 'gnuplot' terminated by signal SIGABRT (Abort)

I just tried with the Git version

Thanks, looks like #227 was the problem for me. Gnuplot itself fails with:
dyld: Library not loaded: /usr/local/opt/lua/lib/liblua.5.2.dylib
  Referenced from: /usr/local/bin/gnuplot
  Reason: image not found
fish: 'gnuplot' terminated by signal SIGABRT (Abort)

I can confirm that when trying with master, it now just outputs Gnuplot not found or not usable, disabling plotting and continues with the benchmark.


How to train the ghost car

Hello, I am  using the default setting in the notebook to train the ghost car, and I set training iter=800 instead. But I got the result is far from yours in the paper. Can you share your command to train the ghost car?

Hi,
Unfortunately I generated those in Colab and didn't save the argument file. However, I can manage to replicate the image if I enable the improve_shape button (or alternatively if you run things locally - setting the weights of both clip ViT models to 1.0 seems to do the trick).
These are the results I'm getting with the notebook at 450 iterations with 'improve_shape' and the texts "car" -> "ghost car":

I tried to setting the weights of both clip ViT models to 1.0, but I only get the follwing pictures. It is more white than your results.

These seem similar enough that I'm not sure the difference is anything more than just the effects of some minor random initialization differences (I set the seed after I initialize the models, which means a few minor things like the mean latent code computation for truncation happens before the model runs).
If you want to try and fully replicate the conditions of a notebook run with 'improve_shape' you need to run with:

Both model weights at 1.0
Mixing at 0.9 instead of 0.0
auto_layers_k = 10, auto_layer_iters = 1

so the full command would be something like:
python train.py --size 512
                --batch 2
                --n_sample 4
                --output_dir /path/to/output/dir
                --lr 0.002
                --frozen_gen_ckpt /path/to/car_model.pt
                --iter 601
                --source_class "car"
                --target_class "ghost car"
                --auto_layer_k 10
                --auto_layer_iters 1
                --auto_layer_batch 8
                --output_interval 50
                --clip_models "ViT-B/32" "ViT-B/16"
                --clip_model_weights 1.0 1.0
                --mixing 0.9
                --save_interval 150

but I'm not sure you'll get anything fundamentally different. I ran the code a few times locally and it seems the variations I'm getting with multiple runs using the same parameters are of the order of the difference between my photo and the one from your last reply.

I trained with both model weights at 1.0 for several times and to my satisfaction, I got the image I wanted. thank you!


area auto save timer setting doesnt actually change timer length

exactly as it says on the tin. i've been trying everything and nothing seems to work. its stuck at 600 seconds.

What does the notification say?

What does entering advdupe2_auto_save_time in the console say?

notification says 600 seconds.
the command says "advdupe2_auto_save_time" = "10" client server_can_execute user lua_client


patrick-de-young.png -> patrick-de-young.jpg

https://github.com/govau/design-system-site/commits/bcbba12db30e37494494e7755f21311c0c8a9437/src/assets/img/contributors/patrick-de-young.jpg renamed this file, fixes broken images like on https://designsystem.gov.au/components/buttons/

@maxious it seems that @pattyde is well connected, going to close this in favour of https://github.com/govau/design-system-site/pull/470 just being merged ❤


bugfix: Checking a drive that doesn't exist would produce wrong results.

Here is how the story goes: When I write a simple demo snippet
function DoTest() {
    diskspace.check('E', function(err, total, free, status) {
        console.log(err);
        console.log(status);
    });
}

where the drive E is not present in my computer (running Windows 7).
I ran the code and found the value of err is null and status is undefined. That's definitely not accordable with description in the document.
Thus I checked inside of source and fixed the bug, at least in my point of view.
BTW, the bugfix commit of the underlying program diskspace can be found on https://github.com/keverw/drivespace/pull/1.

Thanks for both patches :+1:
Could you maybe provide a recompiled drivespace I could include in the NPM push? I've haven't been using Windows in a long while, and currently don't have anything setup to compile C#. I'm on a Mac, so maybe I could setup a Windows 10 VM using the preview to compile it if needed.

I finally setup a environment to compile a newer version! So I don't need a binary anymore to put in the latest diskspace.js release.


Make cloudbuild tests required

Currently these are 2 tests run on every PR:
graalvm-presubmit-sdk-platform-java-a (cloud-devrel-kokoro-resources)
graalvm-presubmit-sdk-platform-java-b (cloud-devrel-kokoro-resources)
They should be marked as required so they are forced to run on every PR.


SWARM-1354 Fraction detect mode is unavailable in Gradle plugin.

SWARM-1354 Fraction detect mode is unavailable in Gradle plugin.

Can one of the admins verify this patch?

Can one of the admins verify this patch?

ok to test

A problem of Gradle plugin as well.
https://github.com/wildfly-swarm/wildfly-swarm/blob/master/plugins/gradle/src/main/java/org/wildfly/swarm/plugin/gradle/PackagePlugin.java#L38
The SwarmExtension is created in when the apply plugin.
https://github.com/wildfly-swarm/wildfly-swarm/blob/master/plugins/gradle/src/main/java/org/wildfly/swarm/plugin/gradle/SwarmExtension.java#L58-L70
Initial modules are created here.
But the resourceOutputDir will only come existing after the archive(jar/war) task.
Then the initial modules would be empty.
So I have to package twice to package the modules. Or I have to run war separately before package.
I made a fix for it as well. Any better suggestion?

@Ladicek Please review. Thank you.

retest this please

... looks like I'm not authorized to trigger a CI build.

retest this please


Can't run it following README

Twice I tried to install this project by cloning  and strictly following the README and it fails with same message:
Creating edumeet-docker_redis_1 ... done
Creating edumeet-docker_edumeet_1 ... done
Attaching to edumeet-docker_redis_1, edumeet-docker_edumeet_1
redis_1    | 1:C 15 Sep 2022 14:50:08.147 # Fatal error, can't open config file '/usr/local/etc/redis/redis.conf': No such file or directory
edumeet_1  | Container starting up...
edumeet-docker_redis_1 exited with code 1
edumeet_1  | - process.env.DEBUG: ''
edumeet_1  | - config.mediasoup.worker.logLevel: warn
edumeet_1  | - config.mediasoup.worker.logTags: [ 'info', 'ice', 'dtls', 'rtp', 'srtp', 'rtcp' ]
edumeet_1  | node:internal/fs/utils:344
edumeet_1  |     throw err;
edumeet_1  |     ^
edumeet_1  |
edumeet_1  | Error: ENOENT: no such file or directory, open './certs/edumeet-demo-cert.pem'
edumeet_1  |     at Object.openSync (node:fs:585:3)
edumeet_1  |     at Object.readFileSync (node:fs:453:35)
edumeet_1  |     at Object.<anonymous> (/opt/edumeet/server/dist/server.js:68:14)
edumeet_1  |     at Module._compile (node:internal/modules/cjs/loader:1101:14)
edumeet_1  |     at Object.Module._extensions..js (node:internal/modules/cjs/loader:1153:10)
edumeet_1  |     at Module.load (node:internal/modules/cjs/loader:981:32)
edumeet_1  |     at Function.Module._load (node:internal/modules/cjs/loader:822:12)
edumeet_1  |     at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:81:12)
edumeet_1  |     at node:internal/main/run_main_module:17:47 {
edumeet_1  |   errno: -2,
edumeet_1  |   syscall: 'open',
edumeet_1  |   code: 'ENOENT',
edumeet_1  |   path: './certs/edumeet-demo-cert.pem'

Indeed, edumeet-demo-cert.pem in readme is cert.pem and should be located into /certs or configs/cert as in the README?
edumeet-docker# ls certs/
cert.pem  edumeet-demo-cert.pem  edumeet-demo-key.pem  key.pem

And about redis.conf, I don't know why it cries, it's present in configs/redis/
ls configs/redis/
redis.conf

Did you get the same kind of problem and fixed it?
PS: Additionally, copy config.example.yaml to config.yaml (step 5) should be done BEFORE gen-redis-password.sh (step 3)

Adding to .env
PWD=/<mypath>/edumeet-docker

fixed it
I guess ${PWD} is not resolved everywhere :smile:


Dynamic dependent pick list creation for task.json in TFS build task

I have two fields in my TFS build task:- 1) States and 2)Cities
I need to populate corresponding cites in drop-down list when a particular state is selected. What changes need to be done in task.json file to get this implemented?

I don't think we enable this behavior right now, docs on this are here - https://github.com/Microsoft/azure-pipelines-extensions/blob/0437e1b000985d1151cd625cc19e77f3a26c2aa6/docs/authoring/endpoints/dataSources.md#parameters
I'm not 100% sure though, you might be better off logging an issue in that repo (I think they own this functionality)


Issue & PR templates added

Solving #15
I have added two files in the root directory of the project that are ISSUE_TEMPLATE.md & PULL_REQUEST_TEMPLATE.md

Solving #15
I have added two files in the root directory of the project that are ISSUE_TEMPLATE.md & PULL_REQUEST_TEMPLATE.md

@naveen8801 have you deleted package-lock.json?

Solving #15
I have added two files in the root directory of the project that are ISSUE_TEMPLATE.md & PULL_REQUEST_TEMPLATE.md

@naveen8801 have you deleted package-lock.json?

No @rockingrohit9639, I didn't delete that file, I just executed 'npm install' command.

Solving #15
I have added two files in the root directory of the project that are ISSUE_TEMPLATE.md & PULL_REQUEST_TEMPLATE.md

@naveen8801 have you deleted package-lock.json?

No @rockingrohit9639, I didn't delete that file, I just executed 'npm install' command.

Have you run the project ? Was ut working?

Solving #15
I have added two files in the root directory of the project that are ISSUE_TEMPLATE.md & PULL_REQUEST_TEMPLATE.md

@naveen8801 have you deleted package-lock.json?

No @rockingrohit9639, I didn't delete that file, I just executed 'npm install' command.

Have you run the project ? Was ut working?

Yaa @rockingrohit9639 , its working fine locally :))

should I merge the main branch once
?


Clarify which methods will be implemented from those that will not

Some of the HTTP methods for each resource say "Not implemented." Could you indicate which ones are planned to be implemented and also those that are not planned to be implemented

Comment text
Description

Not implemented
Does not work, but will be added

Not allowed
Does not work and never will


Fix broken examples

This PR fixes the three broken example builds by upgrading to the latest versions of Next and React in those projects. Builds are now green again.
Basically ran this in those projects:
$ npm i react@latest
$ npm i react-dom@latest
$ npm i next@latest

Could you do a quick ./scripts/for-all-examples.sh npx prettier --write --ignore-path .gitignore '**/*.{js,jsx,ts,tsx,json,md,mdx,yml,css,vue,svelte,html}'?

Amazing, thx for calling that out! 😍


DEPRECATION: Ember.Handlebars.SafeString

DEPRECATION: Ember.Handlebars.SafeString is deprecated in favor of Ember.String.htmlSafe [deprecation id: ember-htmlbars.ember-handlebars-safestring] See http://emberjs.com/deprecations/v2.x#toc_use-ember-string-htmlsafe-over-ember-handlebars-safestring for more details.
Changes proposed:

Add polyfill for Ember.Handlebars.SafeString to keep backwards compatibility.

Tasks:

N/A

@kepek this is great! Thank you for your contribution! 😺

v3.0.1 has been released with this fix.


Add the ability to convert values in CSV filter

This PR adds the ability to use the converters option on the CSV parser - this allows end users to quickly convert values based on it's type - IE: Convert INTs etc to INTs automaticly.
Moved from https://github.com/elasticsearch/logstash/pull/1970

ignore


[Bug] Failed to connect to all addresses

Is this a new bug in the Pinecone Python client?

[X] I believe this is a new bug in the Pinecone Python Client
[X] I have searched the existing issues, and I could not find an existing issue for this bug

Current Behavior
I am simply trying to delete a specific namespace within my index using the following code:
import os
import sys
import json
import pinecone

# pinecone key
pinecone_env = xxxx
pinecone_key =  xxxx

# Initializing index name
index_name = "index_name"
# index = pinecone.Index(index_name)
index = pinecone.GRPCIndex(index_name)
namespace='namespace'

# Initialize pinecone
pinecone.init(
    api_key=pinecone_key,  # find at app.pinecone.io
    environment=pinecone_env  # next to api key in console
)

# Delete namespace
index.delete(delete_all=True, namespace=namespace)

print('Namespace deleted')

Doing this, I get the following error:
PineconeException: UNKNOWN:failed to connect to all addresses; last error: UNAVAILABLE: ipv4:<IP_ADDRESS>:443: recvmsg:Connection reset by peer {created_time:"2023-09-28T20:38:58.196686658+00:00", grpc_status:14}
Would appreciate any insights into this
Expected Behavior
Expected behavior was that the code would delete the specific namespace as requested.
Steps To Reproduce
Use grpc-gateway-protoc-gen-openapiv2-0.1.0
Relevant log output
No response
Environment
No response
Additional Context
No response

@Abe410 At a very high level, seems to be a network issue. Please let me know if you're still facing this issue while deleting the namespaces, Thanks


[SPARK-12770][SQL] Implement rules for branch elimination for CaseWhen

The three optimization cases are:

If the first branch's condition is a true literal, remove the CaseWhen and use the value from that branch.
If a branch's condition is a false or null literal, remove that branch.
If only the else branch is left, remove the CaseWhen and use the value from the else branch.

cc @cloud-fan

Test build #49668 has started for PR 10827 at commit 8e980b5.

Test build #49668 has finished for PR 10827 at commit 8e980b5.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/49704/
Test FAILed.

Test build #2410 has started for PR 10827 at commit 57c4088.

Test build #2410 has finished for PR 10827 at commit 57c4088.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

updated and tests passed - @cloud-fan

LGTM


CONFIG

is there any manual that i can read and get the env values from mongodb?
i am unable to find the options you have specified like
MONGODB_API
MONGODB_API_KEY
MONGODB_DATASOURCE
NEXT_PUBLIC_GA_MEASUREMENT_ID
all the variables looks same and its confusing me

MongoDB data API is deprecated, I will change it to another database, or use mongo client sdk to connect mongodb.

 Thank you !

ahhhhhhhh i am unable to find this data api option....

hi, it has been updated. now, you can set a environment variable MONGO_URI to connect your database.


WIP - set position for new record

@johnnyshields Hey, what with this PR? I have issue - #78. Checked yours solution on my enviroment and my specs are green. Maybe we can merge and create new release? Or smth like that. Thx.

@johnnyshields I can help CR, @skalibog feel free to finish this PR for us

Hi guys, yeah, I'm working on this now, need another week or so but it's on the chopping block for me to get into production. FWIW I am running this branch in staging with no issues for ~1 month, but I want to do one last review/cleanup on the code before releasing.


Failed to expose service when use Cilium and Kubernetes Gateway API

Is there an existing issue for this?

[X] I have searched the existing issues

Version
higher than v1.15.7 and lower than v1.16.0
What happened?
I am using Cilium and Kubernetes Gateway API in Amazon EKS.
I am trying to expose one of my service (Goldilocks in this case at hm-goldilocks-dashboard.production-hm-goldilocks.svc:80) at hm-goldilocks.internal.mydomain.com
Here is my setup:
---
apiVersion: cert-manager.io/v1
kind: ClusterIssuer
metadata:
  name: staging-lets-encrypt-cluster-issuer
  namespace: production-hm-cert-manager
spec:
  acme:
    email<EMAIL_ADDRESS>    server: https://acme-staging-v02.api.letsencrypt.org/directory
    privateKeySecretRef:
      name: staging-lets-encrypt-cluster-issuer-account-secret
    solvers:
      - selector:
          dnsZones:
            - internal.mydomain.com
        dns01:
          route53:
            region: us-west-2
---
apiVersion: cert-manager.io/v1
kind: Certificate
metadata:
  name: staging-hm-cilium-gateway-certificate
  namespace: production-hm-gateway-api
spec:
  commonName: "*.internal.mydomain.com"
  secretName: staging-hm-cilium-gateway-certificate
  dnsNames:
    - "*.internal.mydomain.com"
  issuerRef:
    kind: ClusterIssuer
    name: staging-lets-encrypt-cluster-issuer
  # https://letsencrypt.org/certificates
  privateKey:
    algorithm: ECDSA
    size: 384
    rotationPolicy: Always
---
apiVersion: gateway.networking.k8s.io/v1
kind: Gateway
metadata:
  name: hm-cilium-gateway
  namespace: production-hm-gateway-api
  labels:
    app.kubernetes.io/name: hm-cilium-gateway
    app.kubernetes.io/part-of: production-hm-gateway-api
spec:
  gatewayClassName: cilium
  infrastructure:
    annotations:
      # https://kubernetes-sigs.github.io/aws-load-balancer-controller/latest/guide/service/annotations
      # https://cloud-provider-aws.sigs.k8s.io/service_controller
      service.beta.kubernetes.io/aws-load-balancer-type: nlb
      service.beta.kubernetes.io/aws-load-balancer-internal: "true"
      service.beta.kubernetes.io/aws-load-balancer-subnets: subnet-xx,subnet-xx,subnet-xx,subnet-xx
  listeners:
    - name: http
      protocol: HTTP
      hostname: "*.internal.mydomain.com"
      port: 80
      allowedRoutes:
        namespaces:
          from: All
    - name: https
      protocol: HTTPS
      hostname: "*.internal.mydomain.com"
      port: 443
      allowedRoutes:
        namespaces:
          from: All
      tls:
        mode: Terminate
        certificateRefs:
          - kind: Secret
            name: staging-hm-cilium-gateway-certificate
            namespace: production-hm-gateway-api
---
apiVersion: gateway.networking.k8s.io/v1
kind: HTTPRoute
metadata:
  name: hm-goldilocks-http-httproute
  namespace: production-hm-goldilocks
spec:
  parentRefs:
    - name: hm-cilium-gateway
      namespace: production-hm-gateway-api
      sectionName: http
  hostnames:
    - hm-goldilocks.internal.mydomain.com
  rules:
    - filters:
      - type: RequestRedirect
        requestRedirect:
          scheme: https
          port: 443
---
apiVersion: gateway.networking.k8s.io/v1
kind: HTTPRoute
metadata:
  name: hm-goldilocks-https-httproute
  namespace: production-hm-goldilocks
spec:
  parentRefs:
    - name: hm-cilium-gateway
      namespace: production-hm-gateway-api
      sectionName: https
  hostnames:
    - hm-goldilocks.internal.mydomain.com
  rules:
    - matches:
      - path:
          type: PathPrefix
          value: /
      backendRefs:
        - name: hm-goldilocks-dashboard
          namespace: production-hm-goldilocks
          kind: Service
          port: 80

I can see that External DNS successfully registered with Route 53.

And Gateway's corresponding Load Balancer:

Here is my Gateway status:
➜ kubectl describe gateway hm-cilium-gateway -n production-hm-gateway-api
Name:         hm-cilium-gateway
Namespace:    production-hm-gateway-api
Labels:       app.kubernetes.io/name=hm-cilium-gateway
              app.kubernetes.io/part-of=production-hm-gateway-api
              argocd.argoproj.io/instance=hm-gateway-api
Annotations:  <none>
API Version:  gateway.networking.k8s.io/v1
Kind:         Gateway
Metadata:
  Creation Timestamp:  2024-08-01T21:07:08Z
  Generation:          1
  Resource Version:    1237234
  UID:                 c17f7a60-38ff-462a-90c6-b725066068c5
Spec:
  Gateway Class Name:  cilium
  Infrastructure:
    Annotations:
      service.beta.kubernetes.io/aws-load-balancer-internal:    true
      service.beta.kubernetes.io/aws-load-balancer-subnets:     subnet-xx,subnet-xx,subnet-xx,subnet-xx
      service.beta.kubernetes.io/aws-load-balancer-type:        nlb
  Listeners:
    Allowed Routes:
      Namespaces:
        From:  All
    Hostname:  *.internal.mydomain.com
    Name:      http
    Port:      80
    Protocol:  HTTP
    Allowed Routes:
      Namespaces:
        From:  All
    Hostname:  *.internal.mydomain.com
    Name:      https
    Port:      443
    Protocol:  HTTPS
    Tls:
      Certificate Refs:
        Group:
        Kind:       Secret
        Name:       staging-hm-cilium-gateway-certificate
        Namespace:  production-hm-gateway-api
      Mode:         Terminate
Status:
  Addresses:
    Type:   Hostname
    Value:  aa3ff376273144bd089a876b9417e2fd-3fadba626fbed2b5.elb.us-west-2.amazonaws.com
  Conditions:
    Last Transition Time:  2024-08-01T21:07:08Z
    Message:               Gateway successfully scheduled
    Observed Generation:   1
    Reason:                Accepted
    Status:                True
    Type:                  Accepted
    Last Transition Time:  2024-08-01T21:07:12Z
    Message:               Gateway successfully reconciled
    Observed Generation:   1
    Reason:                Programmed
    Status:                True
    Type:                  Programmed
  Listeners:
    Attached Routes:  1
    Conditions:
      Last Transition Time:  2024-08-01T21:41:06Z
      Message:               Listener Programmed
      Observed Generation:   1
      Reason:                Programmed
      Status:                True
      Type:                  Programmed
      Last Transition Time:  2024-08-01T21:41:06Z
      Message:               Listener Accepted
      Observed Generation:   1
      Reason:                Accepted
      Status:                True
      Type:                  Accepted
      Last Transition Time:  2024-08-01T21:41:06Z
      Message:               Resolved Refs
      Reason:                ResolvedRefs
      Status:                True
      Type:                  ResolvedRefs
    Name:                    http
    Supported Kinds:
      Group:          gateway.networking.k8s.io
      Kind:           HTTPRoute
    Attached Routes:  1
    Conditions:
      Last Transition Time:  2024-08-01T21:41:06Z
      Message:               Listener Programmed
      Observed Generation:   1
      Reason:                Programmed
      Status:                True
      Type:                  Programmed
      Last Transition Time:  2024-08-01T21:41:06Z
      Message:               Listener Accepted
      Observed Generation:   1
      Reason:                Accepted
      Status:                True
      Type:                  Accepted
      Last Transition Time:  2024-08-01T21:41:06Z
      Message:               Resolved Refs
      Reason:                ResolvedRefs
      Status:                True
      Type:                  ResolvedRefs
    Name:                    https
    Supported Kinds:
      Group:  gateway.networking.k8s.io
      Kind:   HTTPRoute
Events:       <none>

My http HTTPRoute status:
➜ kubectl describe httproute hm-goldilocks-http-httproute -n production-hm-goldilocks
Name:         hm-goldilocks-http-httproute
Namespace:    production-hm-goldilocks
Labels:       app.kubernetes.io/name=hm-goldilocks-http-httproute
              app.kubernetes.io/part-of=production-hm-goldilocks
              argocd.argoproj.io/instance=hm-goldilocks
Annotations:  argocd.argoproj.io/hook: PostSync
API Version:  gateway.networking.k8s.io/v1
Kind:         HTTPRoute
Metadata:
  Creation Timestamp:  2024-08-01T21:41:06Z
  Generation:          1
  Resource Version:    1237228
  UID:                 33184787-1469-473f-85f7-4e2d5df491d4
Spec:
  Hostnames:
    hm-goldilocks.internal.mydomain.com
  Parent Refs:
    Group:         gateway.networking.k8s.io
    Kind:          Gateway
    Name:          hm-cilium-gateway
    Namespace:     production-hm-gateway-api
    Section Name:  http
  Rules:
    Filters:
      Request Redirect:
        Port:         443
        Scheme:       https
        Status Code:  302
      Type:           RequestRedirect
    Matches:
      Path:
        Type:   PathPrefix
        Value:  /
Status:
  Parents:
    Conditions:
      Last Transition Time:  2024-08-01T21:41:06Z
      Message:               Accepted HTTPRoute
      Observed Generation:   1
      Reason:                Accepted
      Status:                True
      Type:                  Accepted
      Last Transition Time:  2024-08-01T21:41:06Z
      Message:               Service reference is valid
      Observed Generation:   1
      Reason:                ResolvedRefs
      Status:                True
      Type:                  ResolvedRefs
    Controller Name:         io.cilium/gateway-controller
    Parent Ref:
      Group:         gateway.networking.k8s.io
      Kind:          Gateway
      Name:          hm-cilium-gateway
      Namespace:     production-hm-gateway-api
      Section Name:  http
Events:              <none>

My https HTTPRoute status:
➜ kubectl describe httproute hm-goldilocks-https-httproute -n production-hm-goldilocks
Name:         hm-goldilocks-https-httproute
Namespace:    production-hm-goldilocks
Labels:       app.kubernetes.io/name=hm-goldilocks-https-httproute
              app.kubernetes.io/part-of=production-hm-goldilocks
              argocd.argoproj.io/instance=hm-goldilocks
Annotations:  argocd.argoproj.io/hook: PostSync
API Version:  gateway.networking.k8s.io/v1
Kind:         HTTPRoute
Metadata:
  Creation Timestamp:  2024-08-01T21:41:06Z
  Generation:          1
  Resource Version:    1237227
  UID:                 af2c2c67-4ff4-4c5d-963f-0c2c6222b04f
Spec:
  Hostnames:
    hm-goldilocks.internal.mydomain.com
  Parent Refs:
    Group:         gateway.networking.k8s.io
    Kind:          Gateway
    Name:          hm-cilium-gateway
    Namespace:     production-hm-gateway-api
    Section Name:  https
  Rules:
    Backend Refs:
      Group:
      Kind:       Service
      Name:       hm-goldilocks-dashboard
      Namespace:  production-hm-goldilocks
      Port:       80
      Weight:     1
    Matches:
      Path:
        Type:   PathPrefix
        Value:  /
Status:
  Parents:
    Conditions:
      Last Transition Time:  2024-08-01T21:41:06Z
      Message:               Accepted HTTPRoute
      Observed Generation:   1
      Reason:                Accepted
      Status:                True
      Type:                  Accepted
      Last Transition Time:  2024-08-01T21:41:06Z
      Message:               Service reference is valid
      Observed Generation:   1
      Reason:                ResolvedRefs
      Status:                True
      Type:                  ResolvedRefs
    Controller Name:         io.cilium/gateway-controller
    Parent Ref:
      Group:         gateway.networking.k8s.io
      Kind:          Gateway
      Name:          hm-cilium-gateway
      Namespace:     production-hm-gateway-api
      Section Name:  https
Events:              <none>

I can see http redirects to https, however, the https failed to point the Service in the Kubernetes:

Any guide would be appreciate, thanks!
How can we reproduce the issue?
Here is my Cilium Helm values.yaml
eni:
  enabled: true
ipam:
  mode: eni
egressMasqueradeInterfaces: eth0
routingMode: native
kubeProxyReplacement: true
k8sServiceHost: xx.gr7.us-west-2.eks.amazonaws.com
k8sServicePort: 443
rollOutCiliumPods: true
operator:
  enabled: true
  rollOutPods: true
l7Proxy: true
gatewayAPI:
  enabled: true
  gatewayClass:
    create: "true"
hubble:
  enabled: true
  relay:
    enabled: true
  ui:
    enabled: true

Cilium Version
➜ cilium version --helm-release-name=hm-cilium --namespace=production-hm-cilium
cilium-cli: v0.16.13 compiled with go1.22.5 on darwin/arm64
cilium image (default): v1.15.6
cilium image (stable): v1.16.0
cilium image (running): 1.15.7

Kernel Version
(Hmm, I am not sure where I should run this uname -a, in cilium-operator pod in EKS cluster?)
Kubernetes Version
➜ kubectl version
Client Version: v1.30.0
Kustomize Version: v5.0.4-0.20230601165947-6ce0bf390ce3
Server Version: v1.30.2-eks-db838b0

Cilium Users Document

[x] Are you a user of Cilium? Please add yourself to the Users doc

Code of Conduct

[X] I agree to follow this project's Code of Conduct

I tested a brand new Kubernetes 1.30 cluster with Cilium 1.16.0 with 1.1.0 experimental CRDs

https://raw.githubusercontent.com/kubernetes-sigs/gateway-api/v1.1.0/config/crd/experimental/gateway.networking.k8s.io_gatewayclasses.yaml
https://raw.githubusercontent.com/kubernetes-sigs/gateway-api/v1.1.0/config/crd/experimental/gateway.networking.k8s.io_gateways.yaml
https://raw.githubusercontent.com/kubernetes-sigs/gateway-api/v1.1.0/config/crd/experimental/gateway.networking.k8s.io_httproutes.yaml
https://raw.githubusercontent.com/kubernetes-sigs/gateway-api/v1.1.0/config/crd/experimental/gateway.networking.k8s.io_referencegrants.yaml
https://raw.githubusercontent.com/kubernetes-sigs/gateway-api/v1.1.0/config/crd/experimental/gateway.networking.k8s.io_grpcroutes.yaml
https://raw.githubusercontent.com/kubernetes-sigs/gateway-api/v1.1.0/config/crd/experimental/gateway.networking.k8s.io_tlsroutes.yaml

But still get same result.
I saw Cilium CRD schema validation, which shows 1.16.0 supports Kubernetes 1.29.9.
I am wondering does Cilium 1.16.0 support Kubernetes 1.30?

Joe Stringer answered me on Slack

The schema validation isn't k8s versions, that's Cilium resource versions. The top of the page points out that k8s 1.30 is tested in CI and should work: https://docs.cilium.io/en/latest/network/kubernetes/compatibility/#kubernetes-compatibility
Probably an issue with the gateway API integration, but I'm not sure what.

So Cilium 1.6 does support Kubernetes 1.30 today.
So still something else is wrong currently.

+1 to this issue as well. GatewayClass shows Unknown for the Accepted field. New or long-living existing AWS EKS cluster produces the same result, the GatewayClass is never accepted.

Thanks for your issue.,
Just curious if you are having issue with GatewayClass status (same as Jullian) as well :thinking:. Appreciate if you can attach sysump as well.

Hi @sayboras in my case, Cilium GatewayClass Accepted is True, which is why Gateway and  HTTPRoute also in Accepted states.
Hmm what do you mean sysump? Thanks!

Thanks for your issue.,
Just curious if you are having issue with GatewayClass status (same as Jullian) as well 🤔. Appreciate if you can attach sysump as well.

Coming back to this, if I restart my single EC2 instance I'm testing with on my AWS EKS cluster, the LoadBalancer reports as healthy for about 15-30 minutes, and then shows as unhealthy. I looked at the firewall rules section, and I'm a little lost on where/if to add the ports in my security group as I use the terraform-aws-eks module to provision my EKS cluster, which creates 3 security groups: the control plane cluster group, the cluster group itself, and one for the cluster nodes.
For example:

eks-cluster-sg-mycustomname-123 -> control-plane cluster security group

Allows all ingress traffic on itself, allows all egress on <IP_ADDRESS>/0

mycustomname-cluster -> the cluster security group

Allows ingress port 443 to node security group, no egress.

mycustomname-node -> cluster node security group
Allows all egress, and a bunch of default ports for the ingress added by the module (plus the ones mentioned in the firewall rules section that I added, with the source being the eks-cluster-sg-mycustomname-123 security group.

Here's a screenshot of a shortened list of rules for the node security group:

Okay, I found the problem.
The problem is that after deploying a Gateway that creates an external LoadBalancer service, if you restart the cilium-envoy, cilium, and cilium-operator pods (like the cilium docs suggest in certain sections), it fails to update the Endpoint resource in the cluster. If I then manually delete the Endpoint resource that targets the Gateway, the LB shortly-thereafter shows as healthy again.
Not sure if I'm missing a configuration somewhere to fix this, but I saw this in the logs:
{"level":"info","msg":"Envoy: Starting access log server listening on /var/run/cilium/envoy/sockets/access_log.sock","subsys":"envoy-manager"}
{"level":"info","msg":"Envoy: Starting xDS gRPC server listening on /var/run/cilium/envoy/sockets/xds.sock","subsys":"envoy-manager"}
{"level":"info","msg":"Kernel config file not found: if the agent fails to start, check the system requirements at https://docs.cilium.io/en/stable/operations/system_requirements","subsys":"probes"}
{"level":"info","msg":"Restored node IDs from the BPF map","module":"agent.datapath","count":2}
{"level":"info","msg":"Auto-enabling \"enable-node-port\", \"enable-external-ips\", \"bpf-lb-sock\", \"enable-host-port\", \"enable-session-affinity\" features","subsys":"daemon"}
{"level":"info","msg":"Datapath signal listener running","subsys":"signal"}
{"count":2,"file-path":"/var/run/cilium/state/local_allocator_state.json","level":"info","msg":"Restoring checkpointed local identities","subsys":"identity-cache"}
{"level":"info","msg":"regenerating all endpoints","reason":"one or more identities created or deleted","subsys":"endpoint-manager"}
{"ingress":"<node_IP>/32","level":"info","msg":"Restored ingress IP","subsys":"daemon"}
{"level":"info","msg":"restored 2 out of 3 possible prefixes in the ipcache","subsys":"daemon"}
{"file-path":"/sys/fs/bpf/tc/globals/cilium_ipcache","level":"info","msg":"Removed map pin at /sys/fs/bpf/tc/globals/cilium_ipcache, recreating and re-pinning map cilium_ipcache","name":"cilium_ipcache","subsys":"bpf"}
{"failedServices":0,"level":"info","msg":"Restored services from maps","restoredServices":19,"subsys":"service"}
{"failedBackends":0,"level":"info","msg":"Restored backends from maps","restoredBackends":12,"skippedBackends":0,"subsys":"service"}
{"level":"info","msg":"Reading old endpoints...","subsys":"daemon"}
{"endpointID":"272","error":"open /var/run/cilium/state/272/ep_config.h: no such file or directory","file-path":"/var/run/cilium/state/272","level":"warning","msg":"Couldn't find state, ignoring endpoint","subsys":"endpoint"}

... bunch more `Couldn't find state, ignoring endpoint`

Coming back to this, cilium 1.16.1 seems to have fixed the Gateway / Service endpoint reconciliation error, but I'd rather have someone else confirm as such.

Coming back to this, cilium 1.16.1 seems to have fixed the Gateway / Service endpoint reconciliation error, but I'd rather have someone else confirm as such.

Thanks, it was my hunch at first, here is the related PR https://github.com/cilium/cilium/pull/34131
@hongbo-miao appreciate if you can test it out with 1.16.1 as well. Sysdump is the utility to capture details for troubleshooting.
https://docs.cilium.io/en/stable/operations/troubleshooting/#sysdump

Thank you @sayboras ! I will try again and report back soon!

thanks, feel free to share your testing result here.

Hi @sayboras I haven't forgot this. I will test it on Sep 14 or 15, and post result here. Thanks!

Seems like there is no other user facing the same issue, let's close it out.
Feel free to re-open if it's not working with v1.16.2. Thanks for reporting.

Thanks @sayboras , still haven't got time on this, but will report back when I test in future, thanks!

Thanks @sayboras , sorry, I still haven't got time on this, but will report back when I test in future, thanks!

+1 to this issue as well. GatewayClass shows Unknown for the Accepted field. New or long-living existing AWS EKS cluster produces the same result, the GatewayClass is never accepted.
EDIT: apparently setting loadBalancer.l7.backend to envoy showed the gateway as accepted :|

I wish that would have helped me. But it didn't.
The Gateway class is adamant to be on UNKNOWN state no matter what I do!
I'm on cilium 1.16.4.
K8s version 1.30
Tried downgrading to 1.15.8 and setting loadBalancer.l7.backend=envoy
I'm battling with this for almost 7 days. :( :(