Message signing error handling

Problem
When a user scans a raw message to be signed (not wrapped in Specter Desktop QR format), SeedSigner will produce two errors:

Tells the user that the QR code is an unknown type
System error caused by a KeyError exception

I have verified this at commit b9eee39 of the dev branch. All line numbers refer to that point in time.

Stacktrace

Aug 26 02:23:39 raspberrypi python3[842]: Traceback (most recent call last):
Aug 26 02:23:39 raspberrypi python3[842]:   File "/home/pi/seedsigner/src/seedsigner/controller.py", line 307, in start
Aug 26 02:23:39 raspberrypi python3[842]:     next_destination = next_destination.run()
Aug 26 02:23:39 raspberrypi python3[842]:   File "/home/pi/seedsigner/src/seedsigner/views/view.py", line 161, in run
Aug 26 02:23:39 raspberrypi python3[842]:     return self._run_view()
Aug 26 02:23:39 raspberrypi python3[842]:   File "/home/pi/seedsigner/src/seedsigner/views/view.py", line 156, in _run_view
Aug 26 02:23:39 raspberrypi python3[842]:     return self.view.run()
Aug 26 02:23:39 raspberrypi python3[842]:   File "/home/pi/seedsigner/src/seedsigner/views/seed_views.py", line 1975, in run
Aug 26 02:23:39 raspberrypi python3[842]:     selected_menu_num = self.run_screen(
Aug 26 02:23:39 raspberrypi python3[842]:   File "/home/pi/seedsigner/src/seedsigner/views/view.py", line 109, in run_screen
Aug 26 02:23:39 raspberrypi python3[842]:     self.screen = Screen_cls(**kwargs)
Aug 26 02:23:39 raspberrypi python3[842]:   File "<string>", line 21, in __init__
Aug 26 02:23:39 raspberrypi python3[842]:   File "/home/pi/seedsigner/src/seedsigner/gui/screens/seed_screens.py", line 1516, in __post_in
Aug 26 02:23:39 raspberrypi python3[842]:     text=self.sign_message_data["message"],
Aug 26 02:23:39 raspberrypi python3[842]: KeyError: 'message'
Aug 26 02:23:39 raspberrypi python3[842]: 'message'
Aug 26 02:23:39 raspberrypi python3[842]: Traceback (most recent call last):
Aug 26 02:23:39 raspberrypi python3[842]:   File "/home/pi/seedsigner/src/seedsigner/controller.py", line 307, in start
Aug 26 02:23:39 raspberrypi python3[842]:     next_destination = next_destination.run()
Aug 26 02:23:39 raspberrypi python3[842]:   File "/home/pi/seedsigner/src/seedsigner/views/view.py", line 161, in run
Aug 26 02:23:39 raspberrypi python3[842]:     return self._run_view()
Aug 26 02:23:39 raspberrypi python3[842]:   File "/home/pi/seedsigner/src/seedsigner/views/view.py", line 156, in _run_view
Aug 26 02:23:39 raspberrypi python3[842]:     return self.view.run()
Aug 26 02:23:39 raspberrypi python3[842]:   File "/home/pi/seedsigner/src/seedsigner/views/seed_views.py", line 1975, in run
Aug 26 02:23:39 raspberrypi python3[842]:     selected_menu_num = self.run_screen(
Aug 26 02:23:39 raspberrypi python3[842]:   File "/home/pi/seedsigner/src/seedsigner/views/view.py", line 109, in run_screen
Aug 26 02:23:39 raspberrypi python3[842]:     self.screen = Screen_cls(**kwargs)
Aug 26 02:23:39 raspberrypi python3[842]:   File "<string>", line 21, in __init__
Aug 26 02:23:39 raspberrypi python3[842]:   File "/home/pi/seedsigner/src/seedsigner/gui/screens/seed_screens.py", line 1516, in __post_in
Aug 26 02:23:39 raspberrypi python3[842]:     text=self.sign_message_data["message"],
Aug 26 02:23:39 raspberrypi python3[842]: KeyError: 'message'

Steps to reproduce

Import or create a key
Enable message signing in the options
Seeds -> Key ID -> Sign Message
Scan a QR code (e.g. "Hello world!")

Observe both errors in sequence.
For convenience, here's a Hello world! QR code:

Requested changes

The first error be updated to mention Specter Desktop QR format
The second error message not occur

For the first change, we know that the user it trying to scan a message to sign, so we should be able to use that context to provide an improved error message.
Root cause
I believe the root cause of the second error is that the view is trying to advance to a screen to show the user the message they are about to sign and that it should instead be returning to the main menu.
The first issue isn't really an error, but rather just an opportunity to improve usability.
Code notes
I tried to dig into the code to figure out exactly what file and line I'm proposing be changed and I got stuck.
It looks like the Scan screen has no idea where it came from, which if that's true it means we can't provide that context-sensitive error message because we lack said context. I get this impressions from reviewing the code in ScanView::run(). If my interpretation is accurate, we can drop requested change 1 (improved error message). If it's possible to get that context, I maintain that a more specific error message that points the user in the right direction would be appropriate.
However that same function also show that the default next destination screen is NotYetImplementedView, whose class is implemented in view.py and its run method returns the MainMenuView, which seems like it should avoid that System Error screen... but it doesn't.
Taking a different approach, I decided to try to work my way backwards from SeedSignMessageConfirmMessageScreen. The stacktrace confirms that is called from SeedSignMessageConfirmMessageView. It looks like that is called from line 141, but for that to be reached, self.flow would have to have been set to FLOW__SIGN_MESSAGE in the SeedSelectSeedView constructor.
The only place where I see that occur is on line 1958, inside the SeedSignMessageStartView constructor.  OK, so how'd we get here when we say the first error try to send us back to the MainMenuView? Apparently from scan_views.py line 142!
But the only way we can get to line 142 is if the QR decoder's is_sign_message() method returns true, and that only happens if the message is a string that starts with "signmessage" (and our QR code did not).
...so I'm not sure where I went wrong here, but clearly I took a wrong turn at some point.
Background
Issue https://github.com/SeedSigner/seedsigner/pull/262 added support for message signing. Users may expect this to allow them to scan a QR code with any message and SeedSigner will sign it. This is not true. The message needs to be wrapped in a the "Specter Desktop QR format". This format includes the derivation path as well as the message, and maintains compatibility with some other software called Specter..
This all is perfectly reasonable and I believe the formats should remain the same. If the documentation needs updated to explain how to use this feature, that will be a separate ticket.

Since you found this at the same commit as is our 0.7.0-rc1 release candidate, I will lean towards the simplest code fix which removes the second error.
Thank you for such a carefully written bug report.  I will try to provoke this error and may append to this comment below later.

I can confirm that I'm seeing the same behavior as @jdlcdl. I only get the first error message (which, I agree, doesn't need changed for this release) when I go in via the scan menu.

The bug is if you enter the message signing flow from the Seed Options menu.
Working on a fix.


refactor: speed up tests

Summary
Speed up test runs by

merging main.yml jobs with duplicated steps.
reduce setTimeout durations from 50 to 10 ms

Test plan
All checks should pass.

Main job duration reduced from ~6 min 30 sec to 4 min 30 sec


[web, desktop] SelectableText - right click selects a word

expected
on right click over SelectableText, if nothing is selected:

on web - generic context menu
on desktop (windows) - nothing to happen. i'm not sure about macos and linux

actual
on both platforms a word is selected and selection context menu opened

code sample
import 'package:flutter/material.dart';

void main() => runApp(MyApp());

class MyApp extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    const title = 'code sample';
    return MaterialApp(
      title: title,
      home: Scaffold(
        appBar: AppBar(
          title: Text(title),
        ),
        body: Home(),
      ),
    );
  }
}

class Home extends StatelessWidget {
  const Home({Key key}) : super(key: key);

  @override
  Widget build(BuildContext context) {
    return Center(
      child: Column(
        mainAxisSize: MainAxisSize.min,
        children: [
          SelectableText(List.generate(100, (index) => 'word$index').join(' ')),
        ],
      ),
    );
  }
}

flutter doctor -v
[√] Flutter (Channel master, 2.1.0-13.0.pre.288, on Microsoft Windows [Version 10.0.19041.867], locale ru-RU)
    • Flutter version 2.1.0-13.0.pre.288 at c:\dev\src\flutter
    • Framework revision e384ca7979 (80 minutes ago), 2021-03-26 17:34:03 +0100
    • Engine revision b5e15d055d
    • Dart version 2.13.0 (build 2.13.0-162.0.dev)

[√] Android toolchain - develop for Android devices (Android SDK version 30.0.2)
    • Android SDK at C:\Users\danya\AppData\Local\Android\sdk
    • Platform android-30, build-tools 30.0.2
    • Java binary at: C:\Program Files\Android\Android Studio\jre\bin\java
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b01)
    • All Android licenses accepted.

[√] Chrome - develop for the web
    • Chrome at C:\Program Files\Google\Chrome\Application\chrome.exe

[√] Visual Studio - develop for Windows (Visual Studio Community 2019 16.7.7)
    • Visual Studio at C:\Program Files (x86)\Microsoft Visual Studio\2019\Community
    • Visual Studio Community 2019 version 16.7.30621.155
    • Windows 10 SDK version 10.0.18362.0

[√] Android Studio (version 4.0)
    • Android Studio at C:\Program Files\Android\Android Studio
    • Flutter plugin version 50.0.1
    • Dart plugin version 193.7547
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b01)

[√] VS Code (version 1.54.3)
    • VS Code at C:\Users\danya\AppData\Local\Programs\Microsoft VS Code
    • Flutter extension version 3.20.0

[√] Connected device (4 available)
    • Redmi Note 5 (mobile) • 40c9f14 • android-arm64  • Android 9 (API 28)
    • Windows (desktop)     • windows • windows-x64    • Microsoft Windows [Version 10.0.19041.867]
    • Chrome (web)          • chrome  • web-javascript • Google Chrome 89.0.4389.90
    • Edge (web)            • edge    • web-javascript • Microsoft Edge 89.0.774.57

• No issues found!

https://user-images.githubusercontent.com/39104740/112683512-b7793a00-8e82-11eb-9afc-ad9cea3b840d.mp4

Verified this on mac (web and desktop):

Web:  context menu is displayed (with text not selected):

Desktop: no action takes place

Keeping this issue open for further investigation for expected behavior across all platforms.

flutter doctor -v

[✓] Flutter (Channel stable, 2.0.3, on Mac OS X 10.15.4 19E2269 darwin-x64,
    locale en-GB)
    • Flutter version 2.0.3 at /Users/dhs/documents/Fluttersdk/flutter
    • Framework revision 4d7946a68d (10 days ago), 2021-03-18 17:24:33 -0700
    • Engine revision 3459eb2436
    • Dart version 2.12.2

[!] Xcode - develop for iOS and macOS
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 12.3, Build version 12C33
    ! CocoaPods 1.9.3 out of date (1.10.0 is recommended).
        CocoaPods is used to retrieve the iOS and macOS platform side's plugin
        code that responds to your plugin usage on the Dart side.
        Without CocoaPods, plugins will not work on iOS or macOS.
        For more info, see https://flutter.dev/platform-plugins
      To upgrade see
      https://guides.cocoapods.org/using/getting-started.html#installation for
      instructions.

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] VS Code (version 1.54.3)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.20.0

[✓] Connected device (3 available)
    • Darshan's iphone (mobile) • 21150b119064aecc249dfcfe05e259197461ce23 • ios
      • iOS 14.4.1
    • macOS (desktop)           • macos                                    •
      darwin-x64     • Mac OS X 10.15.4 19E2269 darwin-x64
    • Chrome (web)              • chrome                                   •
      web-javascript • Google Chrome 89.0.4389.90

! Doctor found issues in 1 category.

cc @chunhtai

see also https://github.com/flutter/flutter/issues/79592 which is duplicate, but contains a gif where it behaves real weird and resets an existing selection

Hi, Is there a bug fixing plan for this issue?

Isn't that the expected standard behavior? If you right-click any word in a text on a standard website (for example here, in GitHub comments), the same thing will happen - the world will be selected and a context menu will appear.

the default behavior needs to be investigated of course. what platform you are using, for the record?

I'm using Mac OS 11
https://user-images.githubusercontent.com/5337669/114265927-ca981800-99f3-11eb-9e54-e7d865e7b2a3.mov

This is still reproducible on macOS, Windows and Linux platforms and works fine on macOS Desktop only (Right-click on word selects the word and show the context menu).
MacOS ❌
Expected: Right-click selects the word and shows the context menu
Actual: On macOS Web text selection is incorrect, sometimes right-click selects an incorrect word and shows the context menu. While it works fine on macOS Desktop

Output
Web ❌
https://user-images.githubusercontent.com/31410839/168541782-3bb51013-927a-424f-ad96-7102cb6074f0.mov
Desktop ✅
https://user-images.githubusercontent.com/31410839/168541966-8e618698-93cf-438c-824c-b7dc7b54fddf.mov

Linux
https://user-images.githubusercontent.com/31410839/168542510-71f72907-5bf7-4137-a6b1-2cdf3380fc84.mp4
Windows ❌
Expected: On Windows, right-click should not select the word.
Actual:  Windows web works fine But on Windows Desktop it seems to behave similar to (macOS right-click selects the word) which makes it buggy.

output
windows Desktop ❌
https://user-images.githubusercontent.com/31410839/168550263-d1ca5588-0158-495c-97d1-1c1a9374e8c9.mp4
windows Web ✅
https://user-images.githubusercontent.com/31410839/168548905-fd9857f8-a271-45c8-b8ba-ba7a093955e4.mp4

✅ : No Issue
❌: Issue reproduced

is there any update on this?


Error "Mica-Electron work only on Windows 11."

I got "Mica-Electron work only on Windows 11." when running on Windows 10.
But at the same time, the Github Readme say "Mica electron is now compatible with windows 10".
What is true?
I use it like so:
  // Enable mica or acrylic
  if (IS_WINDOWS_11) {
    mainWindow.setMicaEffect();
  } else {
    mainWindow.setAcrylic();
  }

Thanks.

Same as https://github.com/GregVido/mica-electron/issues/31
I am on the version 1.5.9. It is a regression?

Hi, yes it's true, can I see all of your code to understand where the problem is?

Thank you for the answer.
Nothing more, the code I quoted. And the use of MicaBrowserWindow.
Le 18 mai 2024 à 18:49, GregVido @.***> a écrit :

Hi, yes it's true, can I see all of your code to understand where the problem is?
—
Reply to this email directly, view it on GitHubhttps://github.com/GregVido/mica-electron/issues/38#issuecomment-2118877918, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AAMADIR2PPZA5FBXTQOILCLZC6A77AVCNFSM6AAAAABH5H7T2GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMJYHA3TOOJRHA.
You are receiving this because you authored the thread.Message ID: @.***>

Thank you for the answer.
Nothing more, the code I quoted. And the use of MicaBrowserWindow.
import { app } from 'electron';
const { MicaBrowserWindow, IS_WINDOWS_11 } = require('mica-electron');

...

// Create the browser window.
  mainWindow = new MicaBrowserWindow({
    autoHideMenuBar: true,
    minHeight: 500,
    minWidth: 980,
    width: 1070,
    height: 650,
    show: false,
    webPreferences: {
      preload: path.join(__dirname, 'preload.js'),
    },
  });

  // Enable mica or acrylic
  if (IS_WINDOWS_11) {
    mainWindow.setMicaEffect();
  } else {
    mainWindow.setAcrylic();
  }

  // Dark or Light theme
  const currTheme = store.get('theme', 'system');
  if (currTheme == 'dark') {
    mainWindow.setDarkTheme();
  } else if (currTheme == 'light') {
    mainWindow.setLightTheme();
  } else {
    mainWindow.setAutoTheme();
  }

Okay, after more investigation, seems related to setAutoTheme / setDarkTheme / setLightTheme who are only for Windows 11.

Not fixed finally.
The error is trigger here https://github.com/GregVido/mica-electron/blob/6c62b86bc6af04126a85b24463598c9fb1ecc095/module/app.cpp#L41


Semantics for AssociatedResearchers tab on Sample Metadata template?

This is one component of issue microbiomedata/nmdc-metadata#375
I have no idea how to reflect this kind of data in the NMDC schema.

Field
Sample value

Name
Pajau Vangay

email
<EMAIL_ADDRESS>

ORCiD
0000-0002-9231-0692

Role- CRediT
Project   administration

Moving issue to nmdc-schema repo.
Question: Do we want a hierarchy of researchers? E.g.
researcher

investigator

co-investigator
principle investigator

other kinds of researchers?

In my experience, this would be sufficient:
investigator
- co-investigator
- principle investigator
but I don't know if this works in the environmental domain.
cc @cmungall

investigator

co-investigator
principal investigator

is fine with me, but the NMDC Sample Metadata Template also captures a CRediT term relating the co-investigator to the study.
For now, I've modeled it as a list of dicts, as below.
Note that I've also used an undefined "email_address" slot.
{ 'id': 'GOLD:Gs01971387',
 'type': 'Study',
 'principal_investigator': {'has raw value': 'Montana Smith',
                            'orcid': '0000-0002-8683-0050'},
 'co-investigators': [{'credit': 'Project administration',
                             'co-investigator': {'email_address'<EMAIL_ADDRESS>                                        'has_raw_value': 'Pajau Vangay',
                                        'orcid': '0000-0002-9231-0692'}}]
}

https://microbiomedata.github.io/nmdc-schema/CreditAssociation/


Create an issue template

Docs workflow actually do sanity check on each individual package. If failed the check, then we'd better to file an issue tracking the error. The PR is a script to create an issue.
Testing issues: https://github.com/Azure/azure-sdk-tools/issues/2195

The following pipelines have been queued for testing:java - templatejava - template - testsjs - templatenet - templatenet - template - testspython - templatepython - template - tests You can sign off on the approval gate to test the release stage of each pipeline. See eng/common workflow

The following pipelines have been queued for testing:java - templatejava - template - testsjs - templatenet - templatenet - template - testspython - templatepython - template - tests You can sign off on the approval gate to test the release stage of each pipeline. See eng/common workflow


Deprecated fat arrow functions not crossed out

Such as these in dom.ts:

Usages are not marked as deprecated:

If I change them to a normal function, it works

Tracked upstream by https://github.com/microsoft/TypeScript/issues/39374


Make camlistored log accessible

At the moment it looks like logs are written to /var/log/syslog, and journalctl (-u camlistored) does not show anything.
So I should probably figure out how it's done the systemd way, and in particular:

get the logs written to somewhere else
have them be accessible through journalctl

update: looks like after a reboot 2) is solved (which does not mean it's properly fixed).

@mpl, I suspect a bug we had with bad permissions on /var/log, if so, we should find out the cause and fix the issue from the Ubuntu image
Keep this issue updated if you have any new information


SDK release type as Beta and not Preview

From @ladonnaq
"During "create a release plan" we are asking if the SDK is preview or stable but the terms preview is related to API Spec and Beta is used for SDKs."
We need to change the wording from preview -> beta

Updated as part of change https://github.com/Azure/azure-sdk-tools/issues/6996


Able to draw out of height and width

On what kind of device are you using this library?

[X] Android
[X] iOS
[ ] Web

Environment
- OS: macOS Ventura
- react-native: 0.70.4
- @benjeau/react-native-draw: 0.8.3
- @benjeau/react-native-draw-extras: 0.2.2

Current Behavior
I'm developing an app for drawing above an image, I have restricted the canvas height and width but I can draw more than the specified height and width.
Code:
<View style={{ height: '60%, width: '100%', paddingHorizontal: 16 }}>
            <FastImage
                style={{ height: '100%', width: '100%' }}
                source={{ uri: image.uri }}
                resizeMode={FastImage.resizeMode.contain}
            />

            <Canvas
                enabled={isEditing}
                ref={canvasRef}
                style={{ position: 'absolute', top: 0, bottom: 0, left: 0, right: 0, backgroundColor: 'transparent' }}
                color={color}
                thickness={thickness}
                opacity={opacity}
                tool={DrawingTool.Brush}
                onPathsChange={setPaths}
            />
</View>

Sample Video:
https://user-images.githubusercontent.com/84722936/226907436-95a15c8f-93aa-44bf-b241-6b659e4c4e47.mov
Expected Behavior
I should be able to restrict drawing height to the view's height and width
Steps To Reproduce
You can check my above code in current behavior.
Anything else?
No response

Hey guys, any solution ?


Keycloak + mod_auth_openidc

This PR has a fully Dockerized OpenID Connect stack for protecting the hmda-platform API.  This is built using Keycloak as an Identity Provider and the Apache-based mod_auth_openidc as a Secure API Gateway (aka Auth Proxy).
This PR also includes a couple additional projects for testing purposes.  They will likely be removed once this is working well, but I think it's worth keeping them in place for now:

echo-api is a REST API that simply responds with what was requested.  This is especially useful to make sure all security-related headers are being set correctly.
oidc-test is a simple webapp which demonstrates the OpenID Connect Implicit Flow, redirecting to Keycloak for Authentication, and securely calling both the echo-api and the official hmda-platform /institutions endpoint.

So, what's left?  Primarily documentation.  What's in the README is no longer accurate.  Additionally, the Keycloak config is not yet fully automated, so that needs to be documented as well.  Coming soon...

Taking the WIP flag off the PR.  I have updated the README to include instructions for setting up a new realm, OIDC client, and a test user.  That should be everything you need to test it out.
@wpears, check it out, and let me know what you think.

Looks good, merging now. If my work in the front-end informs anything here, I'll PR it in, but I think this is a solid base.

Awesome.  Thanks @wpears!


How to sort items per bootstrap rows?

Hi,
I am looking for solutions, possible if TinySort can sort the items 3 items per row example?

 item 1

 item 2

 item 3

 item 4

 item 5

I'm not entirely sure what you are trying to achieve. Have you read the documentation? There are plenty examples in there.
If you mean multiple rows within multiple parents then no. It would work if you just have one row parent.


Fix homepage link

Thank you for your pull request,  Please add signed-off-by tag in commit message.

force pushed that


Experiments with performance

Based on experience learned from this PR another PR was created: https://github.com/elgopher/yala/pull/94


filter list showing wrong items for senders & implementers coders

If you search for senders or implementers, the drop down filters list shows slots  and variable filters that should only be displayed when viewing a class. Also, the class filter is not shown:


Not sure why types aren't working, I might have done something wrong

import { RetoolRPC } from "retoolrpc";

Could not find a declaration file for module 'retoolrpc'. '/[path]/node_modules/retoolrpc/dist/index.mjs' implicitly has an 'any' type.
  Try `npm i --save-dev @types/retoolrpc` if it exists or add a new declaration (.d.ts) file containing `declare module 'retoolrpc';`ts(7016)

rpc.register({
  name: "helloWorld",
  arguments: {
    name: { type: "string", description: "Your name", required: true },
  },
  implementation: async (args, context) => {
    return {
      message: `Hello ${args.name}`,
      context,
    };
  },
});

Parameter 'args' implicitly has an 'any' type.ts(7006)
Parameter 'context' implicitly has an 'any' type.ts(7006)

This is for when typescript is in strict mode. I am using this in a typescript project. I can't seem to get it working.
Retool RPC is a game changer and needs serious attention imo, it makes building retool native apps much easier without relying on building api infra to communicate with a backend.

Was using NodeNext as moduleResolution in tsconfig instead of Node. Also changed module to CommonJS and it works.


docs: improve data fetching section

🔗 Linked issue
None
❓ Type of change

[X] 📖 Documentation (updates to the documentation, readme or JSdoc annotations)
[ ] 🐞 Bug fix (a non-breaking change that fixes an issue)
[ ] 👌 Enhancement (improving an existing functionality like performance)
[ ] ✨ New feature (a non-breaking change that adds functionality)
[ ] 🧹 Chore (updates to the build process or auxiliary tools and libraries)
[ ] ⚠ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description
Minor clarifications to data fetching. There are concepts that are introduced before the previous completes introduction, so I added a more clearer presentation of these concepts in the beggining.
Also, added the section for immediate: false.
Full details on the diff.
📝 Checklist

[ ] I have linked an issue or discussion.
[X] I have updated the documentation accordingly.

All reviews approved.


Set tags for production environment to latest

All tags for production are set to latest. We need to make sure the containers are built like the following:

New pushes on the dev branch should build a container with tag dev. (I still want to remove the dev branch and use main and the feature branch workflow).
New tags will create an image with tags: <tag name> and latest.

This makes sure that all the newest commits have the tag dev (soon main), and the released versions (with tags and version numbers and are production ready) have the latest tag.
The dev tag is used for the test environment.
The latest tag is used for the production environment.

PR text is what should happen, but for now, we use tag 'main' instead of 'latest'


NaN and -NaN can give different bit patterns

AFAIK our intention is to always canonicalize so this should be fixed. Note that this only repros in Edge, not in ch.exe.
function numberToRawBits(v) {
  var isLittleEndian = new Uint8Array(new Uint16Array([1]).buffer)[0] === 1;
  var reduce = Array.prototype[isLittleEndian ? 'reduceRight' : 'reduce'];
  var uint8 = new Uint8Array(new Float64Array([v]).buffer);
  return reduce.call(uint8, (a, v) => a + (v < 16 ? "0" : "") + v.toString(16), "");
}

console.log(numberToRawBits(NaN));
console.log(numberToRawBits(-NaN));

Output on Edge 25:
fff8000000000000
7ff8000000000000

@Penguinwizzard I think you did some work in this area. Is this fixed / by design / still an issue we need to look at?


Create openid-configuration

Hi! I will merge this PR as soon as I see Premas/oauth2/keys added to it.


Updated JPhyloRef submission URL to ggvaidya.com

Since our backend server hosted at UF is temporarily down, this PR changes that to my server at ggvaidya.com for now. We'll revert it to UF once it's working again.
Should be merged after #178 and #179.

This seems to include quite a bit more than the title suggests, perhaps because it is against master whereas the branch it is coming from is not from the current HEAD of master?

Yup, that's right! I had to rebase those changes into this PR because that was the only way I could test them -- without changing the JPhyloRef URL, the resolution code doesn't work at all. However, it would have been cleaner to have one PR at the end whose only purpose is to combine those changes, such as https://github.com/phyloref/open-tree-resolver/pull/18. I'll do that in the future!

Regarding the specific change in the title, please refer to my comment for the corresponding OTR change.

I don't think I'll be able to get this to work by tomorrow except by closing #183, so I'll go ahead and merge this in for now. Once we resolve #183, this shouldn't be an issue any longer.


AJ-1585 - Add logic that writes Rawls Json to bucket

A few things at play:

GcsStorage now uses Data Import config class
GcsStorage is a Bean, but I added it as an Optional one since the way RecordSink is currently set up, it needs to be created no matter if we are in app plane or data plane. However, we do not need it for data plane and it will always fail since there is no defautl credential wds would be running under. David proposed to potentially split the Record Sinks implementations instead of them being shared but I say lets tackle that in a different ticket and not block import e2e on that
GcsStorage has a mock bean that is used just inside tests, it doesn't actually write anything to a real bucket, but that is how we test that things work as expected
Since there is no easy was to propagate BlobName back to a test a this time, I ended up adding a new method that only will work for Rawls Record Sink that allows us to get the blob name to verify that all worked correctly (we really only need this for the test so far). I want to note that this wont necessarily work if two imports are happening at once (at least the way I understand it) -- but that is not the case for the test so it works? 🤷 there is a better/prettier way to do this, but it did not arrive into my brain today 😄

Reminder:
PRs merged into main will not automatically generate a PR in https://github.com/broadinstitute/terra-helmfile to update the WDS image deployed to kubernetes - this action will need to be triggered manually by running the following github action: https://github.com/DataBiosphere/terra-workspace-data-service/actions/workflows/tag.yml. Dont forget to provide a Jira Id when triggering the manual action, if no Jira ID is provided the action will not fully succeed.
After you manually trigger the github action (and it completes with no errors), you must go to the terra-helmfile repo and verify that this generated a PR that merged successfully.
The terra-helmfile PR merge will then generate a PR in leonardo.  This will automerge if all tests pass, but if jenkins tests fail it will not; be sure to watch it to ensure it merges. To trigger jenkins retest simply comment on PR with "jenkins retest".

This is awesome! Thanks for leaning into and experimenting with all the bean config stuff. I have a few comments throughout for thought... probably the most major concern is the one you already highlighted in your PR description, which is that having the blobName persist on the instance state of RecordSink is probably not good. I have an idea of how to avoid that but curious what you think.

@jladieu love your suggestion - refactored to use it!


NetworkClient.owned not cleaned up

Describe the bug
When a player object is destroyed by being abandoned in a scene via scene change, NetworkClient.owned doesn't get cleaned up, resulting in a flood of the following warning:
Found 'null' entry in owned list for client. This is unexpected behaviour.
UnityEngine.Debug:LogWarning (object)
Mirror.NetworkClient:Broadcast () (at Assets/Mirror/Core/NetworkClient.cs:1489)
Mirror.NetworkClient:NetworkLateUpdate () (at Assets/Mirror/Core/NetworkClient.cs:1540)
Mirror.NetworkLoop:NetworkLateUpdate () (at Assets/Mirror/Core/NetworkLoop.cs:190)

Steps to reproduce
Repro project: SceneChangeTest.zip

Unzip and import the package into a project with Mirror
Add all 3 scenes to Build Settings (Offline first)
Build and run as Host
Play in editor as Client
Press [SPACE] in either one to change scenes
BUG: See flood of warnings in console

Expected Behavior

Player object is removed from NetworkClient.owned and no warnings when destroyed by scene change
If a null is found in that collection, remove the entry instead of flooding the warning

Additionally, per Alph in Discord, it's happening on server too, NetworkServer line ~1500 and he has a custom observers system here.
Environment

OS: Windows
Build target: standalone
Unity version: 2021 LTS
Mirror branch: master

note this is with a 'very old version of mirror'

see branch: repro_3308

can reproduce:

scene change doesn't call NetworkClient.DestroyObject(netid), so it's never removed.
the same happens with .spawned too.
for .spawned we even have a workaround for this already:


Use the new Windows Socket API

Use the new Windows Socket API instead of the BSD socket compatibility package.

Unmaintained project (published for reference)


Add the DAPLink version to the data logging HTM page.

As we are adding a new entry to the data log metadata with the DAPLink version, I've increased the MICROBIT_LOG_VERSION from 001 to 002.
This also means we have to pass an instance of MicroBitPowerManager to MicroBitLog, to be able to read the DAPLink version. So I had to add it to the MicroBitLog constructor, which technically speaking it could be consider a breaking change for any consumer of their own instance of MicroBitLog. However because there shouldn't be anybody else using this directly, and the public facing uBit object API is unchanged, then I'd rather safe the flash from creating another constructor (plus MicroBitPowerManager availability checks) and not have to refactor more the code.
@microbit-matt-hillsdon would you be able to review the HTML changes?
I was able to shave enough bytes to be able to parse the DAPLink version inside the embedded HTML. Technically this is not necessary, as we can only use it when online, and so that could go into the online js code.
However, it looks like right now the online JS doesn't have to be aware of the structure of the raw data (which can change in the future), only the HTML that's generated and the dl object, and that is a nice abstraction. So this way we don't have to update the online code to distinguish between MICROBIT_LOG_VERSION 001 and 002.
Resolves https://github.com/lancaster-university/codal-microbit-v2/issues/145

Merging this into a feature branch in this upstream repository and recreating this PR in TBD.
This is done to be able to create this second PR that builds on top of this one: TBD


Backend 147

This solves #147, #146 and #144.
Limitation, sorting on json fields applies only as "text" format.

Check sorting between strings of different lenghts (for example 1, 2.0 or 10) and check it is correct.
The issue might be:

length is applied, then 2 < 10 < 1.0
If length is not applied then 9.0 < 10 < 1

sorting by json fields seems not to work


Delete obsolete cilium-envoy.log on startup

We need to do a one-time cleanup of cilium-envoy.log on startup
and also rename the new file following log-rotation correctly to
envoy.log. This will ensure that users get their claimed disk space back.
Fixes: #3046
Signed-off-by: Manali Bhutiyani<EMAIL_ADDRESS>Delete obsolete cilium-envoy.log on startup

test-me-please

test-me-please

Maybe we should somehow mark the deletion of the old log file as deprecated, as we should be able to  remove those lines in some future release? I mean we do not need keep trying that forever?

test-me-please

test-me-please

@tgraf The ginkgo error seems unrelated to my changes
02:42:13 level=debug msg="running command: sudo cilium config -o json | jq '.mutable.PolicyEnforcement'"
02:42:13 level=debug msg="running command: sudo cilium config PolicyEnforcement=default"
02:42:13
02:42:13 • Failure [37.910 seconds]
02:42:13 RuntimeValidatedConntrackTable
02:42:13 /home/jenkins/workspace/Cilium-PR-Ginkgo-Tests-Validated/src/github.com/cilium/cilium/test/runtime/ct.go:53
02:42:13   Testing L3-L4-L7 policy while the L3-L4 connection was previously made to confirm L3-L4-L7 policy enforcement over the proxy with the same source port [It]
02:42:13   /home/jenkins/workspace/Cilium-PR-Ginkgo-Tests-Validated/src/github.com/cilium/cilium/test/runtime/ct.go:617
02:42:13
02:42:13   Setting 13628 endpoint's EgressPolicy as false
02:42:13   Expected
02:42:13       <bool>: false
02:42:13   to be true
02:42:13
02:42:13   /home/jenkins/workspace/Cilium-PR-Ginkgo-Tests-Validated/src/github.com/cilium/cilium/test/runtime/ct.go:627
02:42:13 ------------------------------
02:42:13 RuntimeValidatedConntrackTable
02:42:13   Testing L7 proxy redirection after a L3 connection is made with the exact 5 tuple
02:42:13   /home/jenkins/workspace/Cilium-PR-Ginkgo-Tests-Validated/src/github.com/cilium/cilium/test/runtime/ct.go:705
02:42:13 level=info msg="setting PolicyEnforcement=always"


Adding bookmark adds gibberish to URL when clicking on it(http%3A/homarr%3A7575)

Environment
Docker
Version
latest
Describe the problem
When adding a plain bookmark (like http://www.whatever.com) it executes but the link it is pointing to would be http://www.whatever.com/http%3A/homarr%3A7575) rendering the bookmark useless.
Logs
not sure where to find this
Context

Please tick the boxes

[X] I confirm that I attached the proper logs
[X] I've read the docs
[X] I've checked for duplicate issues
[X] I've tried to debug myself

I cannot confirm this behavior. Can you confirm that this is still happening in 0.14.3?


MRG: Remove unused code

Reference issue
in #8066 I removed a hack for calculating the position of short channels (where the source and detector are very close together). I left in some code that is doing nothing. Specific lines are here
What does this implement/fix?
Removes unused code
Additional information
I am surprised linting didnt pick this up, I will be more cautious in the future.

@larsoner @agramfort could you please review


Operating nodes returns "error": "invalid operation"

When I used Postman to test operating nodes, it returns the following response, and the status of the node didn't change (I used the operations: start, stop and restart and they all gave the same result.)
{
    "data": {
        "error": "invalid operation"
    },
    "msg": null,
    "status": "successful"
}

From the code here, it seems we can only operate the node when its status is paused or running
https://github.com/hyperledger/cello/blob/c9f538b17922e9dade7f56f3155ea4e7801a7517/src/api-engine/api/routes/node/views.py#L499-L517
However, the node status is created by default
https://github.com/hyperledger/cello/blob/c9f538b17922e9dade7f56f3155ea4e7801a7517/src/api-engine/api/models.py#L521-L526
Did I miss any API which can change nodes' status?

created should be able to start to running.
I would suggest after creating node from console, directly start it. a.k.a., no intermediate created status.

Fixed by creating /opt/hyperledger folder


Color for comments is difficult to read on some displays / view angles

The gray color used for comments in both the light and dark versions of this theme is difficult to read against the background color. This issue may be more noticeable on monitors with low contrast ratios (I'm using an HP 27Q monitor).
The gray color for comments is easier to read on better performing displays like the one built in to my MacBook Air. However, I think some subtle tweaking of this color or adding more theme options with an alternate comment color would solve this problem.

When designing the colours, I was targeting a decently well calibrated, relatively recent display with full sRGB coverage. If this is not what you‘re working with, the comment colour will not be the only issue I think.
Do you feel like it‘s fine on the MacBookAir?
The high(est) contrast version should be compensating for this already, do you have the same issue using the contrast++ version? (Unfortunately the design constraints do not allow for a higher contrast light version)


Generate list of SUNet IDs for all H2 managers, depositors, and reviewers

I need to send out some communications regarding the work cycle to these users. I would like to send out the first one BEFORE we actually start work, so I need this list this week.
I realize many of these will bounce, but that's fine. If there is a way to eliminate the ones that are currently not active, that would be great, but is not necessary.

List generated by jcoyne: https://docs.google.com/spreadsheets/d/1dwUtC73-Wf6NR3hcNpWdkcrRrkqxm20JAXeFqDrVpFs/edit#gid=0
Code: https://gist.github.com/jcoyne/601ac6c1b9915f0f3c26405dbb7f2165


all: fix several typos

This PR addresses several typos within the source code.
It should not have any visible affect.

Thanks for fixing these typos!
I renamed this PR to include the all: prefix. The prefixes we use for PRs and issues are noted in CONTRIBUTING.md.

🙏


Fixed flask app initialization for Travis CI

The environment variable FLASK_APP must be set for proper initialization with Travis CI.
See difference from the first and last build here.

Thanks


Running the demo on camera feed

Hi @yjxiong @yysijie , is there a way to run this quickly on camera feed ?
Thanks.

did you find a way to run it on using the camera?
Please let me know

@lianuo
this sounds like a very good idea. Do you plan to releaes the code realtime demo?

Would you like to know the implementation of real-time details。 Is it convenient to send it to the mailbox？Thanks very much@lianuo

it may be a litte complex, if there are many person in the video ,it is nessery to add pose tracking method to predict every ones action.

I used other openpose projects to extract 18 key points from each frame of the video.but how can i modify these data ,and put them into the action recognition demo.

@sandyflute, @intvo
Hi, the speed of prediction is enough fast. However, this implementation extracts all the skeleton sequence from video by Openpose offline, then predicts the action type according to the skeleton sequences. Thus, if you want to run this framework in real time, you should modify the code. you should run the Openpose in real time, and predict the action type according to the latest 20~30 frames at the same time. Welcome to create a pull request if you implement this feature.

I used other openpose projects to extract 18 key points from each frame of the video.but how can i modify these data ,and put them into the action recognition demo.thank u

它有效，我只是将姿势打包为（3，t，18,1）并将其输入网络。
t是时间，正如你的建议，我把它设置为20.
现在它可以实时工作。
Hello, could you send me this code for me to learn?

@yysijie
in the demo.py
data is fed in to the model.but the size is (3,222,18,2)
3 means 3 chanel
222 means the lenth of video,222 frames
18 is the keypoints
2 is the person number
output, feature = self.model.extract_feature(data)
the output size is 1,400,56,18,2
I have two questions

the data size should be if I want to predict action in realtime
2.in the output size, how the 56 means,I know it is from 222->111->55.5->56?
is this means for every 4 frames we have a prediction of action?
Thanks~

hello, i want to konw in st_gcn.py the fourth parameter  1 in the front two  network layer it can be changed by myself.   st_gcn(in_channels, 64, kernel_size, 1 , residual=False, **kwargs),             # st_gcn(64, 64, kernel_size, 1, **kwargs),what this parameter really mean and how does this parameter affect the overall performance?

@lianuo Could you tell me how to solve the input video stream problem that I want to implement the real-time system? Specifically,  VideoCapture() has been used in openpose project to estimate pose, so I can't use that function to get the real-time video stream in the st-gcn project for visualization. For example, I can neither print the st-gcn final weight of each joint nor the predict action at each frame, if the video stream unavailable in st-gcn. Is it possible to get the video stream in both openpose estimation and st-gcn visualization?

@AndyTaiwan I would say you write a wrapper that handles video capture and call openpose and st-gcn's APIs sequentially. Then the visualization can be done in the wrapper.

@yjxiong Thanks for your reply! About the wrapper, it is necessary for calling both pose estimation and action recognition APIs to use torch.multiprocessing right? The reason is that the real-time of action recognition need to run openpose and st-gcn at every 20 frames. Please correct me if I am wrong.

Real-time or not mostly depends on how fast the pose estimation runs on your devices. The wrapper would just grab the frames and send them to OpenPose and ST-GCN. You can implement it in the way you like.

@lianuo Could you help me if I want to feed the video to is demo for using real time camera~

Hello, don't know if you have completed the task of this change. @csuzenith @lianuo

It works , I just pack the poses as (3,t,18,1) and feed it in to the network.
t is the time ,as you suggest,  I set it to be 20.
Now it can works in realtime.
I retrained the model with my own data. top1 is 88%
But when i run it on camera feed.  The results are terrible.  I pack the poses as (3,30,18,1)
I don't know what the problem is.  Can you give me some suggestions ?  Thank you!

Hello,
Sorry guys, i stopped following this thread. I was able to do real time demo with camera without doing any change in the network architecture. If anyone needs help with this immediately, i might be able to guide.

@lianuo  Could you help me if I want to feed the video to is demo for using real time camera~
It works , I just pack the poses as (3,t,18,1) and feed it in to the network.t is the time ,as you suggest, I set it to be 20.Now it can works in realtime.

@lianuo  Could you help me if I want to feed the video to is demo for using real time camera~
It works , I just pack the poses as (3,t,18,1) and feed it in to the network.t is the time ,as you suggest, I set it to be 20.Now it can works in realtime.

Hello, don't know if you have completed the task of this change. @csuzenith @yysijie @yjxiong @durianno1


Editor scrolls out of view after adding Headers

After an Header is selected from the toolbar and you start typing the scroll gets out of scope of the view, it gets behind the navigation bar. Need to scroll manually to top or press return key to get back the scroll to its desired position.

Can you maybe post a sample? It's not happening to me off the master branch...


[PTRun]Dispatcher processing has been suspended, but messages are still being processed infinite error windows

Microsoft PowerToys version
0.58.0
Running as admin

[X] Yes

Area(s) with issue?
PowerToys Run
Steps to reproduce
Hi I'm having trouble calculating something or finding something by using powertoys run many times.
Usually some error messages come up and once a day the error messages infinitely generate as a photo attached.  I would appreciate it if you fix it at your earliest convenience.
following is the error message when it occurs.
Version: <IP_ADDRESS>
OS Version: Microsoft Windows NT 10.0.19044.0
IntPtr Length: 8
x64: True
Date: 2022-05-09 오전 11:26:14
Exception:
System.InvalidOperationException: 디스패처 처리는 일시 중단되었지만 메시지가 여전히 처리되고 있습니다.
at System.Windows.Threading.Dispatcher.WndProcHook(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
at MS.Win32.HwndWrapper.WndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
at MS.Win32.HwndSubclass.DispatcherCallbackOperation(Object o)
at System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Int32 numArgs)
at System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Int32 numArgs, Delegate catchHandler)

✔ Expected Behavior
No error messages.
❌ Actual Behavior
Version: <IP_ADDRESS>
OS Version: Microsoft Windows NT 10.0.19044.0
IntPtr Length: 8
x64: True
Date: 2022-05-09 오전 11:26:14
Exception:
System.InvalidOperationException: 디스패처 처리는 일시 중단되었지만 메시지가 여전히 처리되고 있습니다.
at System.Windows.Threading.Dispatcher.WndProcHook(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
at MS.Win32.HwndWrapper.WndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
at MS.Win32.HwndSubclass.DispatcherCallbackOperation(Object o)
at System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Int32 numArgs)
at System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Int32 numArgs, Delegate catchHandler)
Other Software
No response

This is #17371 and #9143 . So I'm guessing we're still getting this from time to time.
I wonder if it's got something to do with character set. Looking at recent occurrences, this one is using Korean characters while #17371 is using Chinese characters if I got that correctly.

Can you please test something to see if we can find out which module might be causing this?
In settings, disable every PowerToys Run plugin and restart the computer.
After the computer restarts, enable the PowerToys Run plugins one by one while testing the query that is causing these errors, to see if we can identify which one is causing this behavior for you. /needinfo

er.

It seems that windows Search is the problem. As you said, I turned off all of plugins and rebooted computer and I turn on calculator and typed the numbers several times and there's no problem but upon turning on Windows Search, error message just come up. when I re-run several times, the error message window that has no content iterated infinitely.

Can you please test something to see if we can find out which module might be causing this?
In settings, disable every PowerToys Run plugin and restart the computer. After the computer restarts, enable the PowerToys Run plugins one by one while testing the query that is causing these errors, to see if we can identify which one is causing this behavior for you. /needinfo

It seems that windows Search is the problem. As you said, I turned off all of plugins and rebooted computer and I turn on calculator and typed the numbers several times and there's no problem but upon turning on Windows Search, error message just come up. when I re-run several times, the error message window that has no content iterated infinitely.

@franky920920 , sorry to bother you, but is this something you were ever able to repro when using Chinese localization?

Can you please test something to see if we can find out which module might be causing this?
In settings, disable every PowerToys Run plugin and restart the computer. After the computer restarts, enable the PowerToys Run plugins one by one while testing the query that is causing these errors, to see if we can identify which one is causing this behavior for you. /needinfo

@franky920920 , sorry to bother you, but is this something you were ever able to repro when using Chinese localization?

Can confirm have the same issue here in zh-CN using PowerToys Run with most plugins turned on (including Windows Search). Will try to reproduce later. Log attached, with most plugins turned on. Since it's totally random, sometimes it works fine and sometimes it'll crash, I'll turn Windows Search off to see what's coming next.
PowerToysReport_2022-07-08-17-46-39.zip

@franky920920 , sorry to bother you, but is this something you were ever able to repro when using Chinese localization?

Sorry, missed this mention. Let me check this later.

In #20891, I report exactly the same issue, while I'm french and thus do not use chinese characters, this therefore has nothing to do with the chinese and/or Corean stuff.

I confirm that the windows Search module is clealry the issue: I desactivated it and now it works correctly. However, even after 0.64.1 update, reactivating it makes this bug comes back again and again... Made me lost my work twice today (as the only way out is to restart the computer).
This is really annoying, is this worked on or not at all ?

@lrnv , can you please send a Bug Report? I'd like to see if I can spot anything. It being identified as caused by the windows Search module is helpful as well. Does it occur only when you try to do a search, only on some specific characters or everytime?

The main reason why this isn't being worked on is that no dev has been able to reproduce it locally.

Hi @davidegiacometti , I've seen your comment that https://github.com/microsoft/PowerToys/issues/22104#issuecomment-1315926053 is a consistent repro of this.
I've tried with the "120/" query but been unable to repro it. Are you able to repro it consistently? I'd love to be able to fix this.
Can you please send your bug report so I can understand if there might be something special about the settings?

Hi @davidegiacometti , I've seen your comment that #22104 (comment) is a consistent repro of this. I've tried with the "120/" query but been unable to repro it. Are you able to repro it consistently? I'd love to be able to fix this. Can you please send your bug report so I can understand if there might be something special about the settings?

Hi Jaime! Sorry but I missed your message. Unfortunately I am not able to replicate this but the author of the issue said the error happened multiple times with that search.
Very hard to understand what's happening and the issue seems to be more frequent after 0.66 (may be a coincidence).

After the last update, I'm seeing this error daily now. :(

Same here. Does the sofware everything is packaged with powertoys run ?  Because I don't know if had installed it before ? Can it cause this issue ? Everithing is not new on my computer.
regards

Same here. Does the sofware everything is packaged with powertoys run ?  Because I don't know if had installed it before ? Can it cause this issue ? Everithing is not new on my computer. Also I notice this happen after first use (after boot)
regards

@Di3S3L59
No Everything is not included. There is a third-party PT Run plugin available on GitHub.
Our last investigation shows that it seems to be caused by Acrobat Reader if PDF thumbnails are enabled.

@jaimecbernardo
Were you able to reproduce it in the W10 vm? I like create a PR to improve thumbnail handling and need someone to test it. ;-)

In lin-ycv/EverythingPowerToys#33 I had the same issue and could track the bug down to file thumbnails for PDF files generated by the Adobe Preview Handler.
The problem (only?) occured when PDF files where part of the results (you can see two PDF files in OP's screenshot, too). After enabling "PDF thumbnails" in PowerToys File Explorer extension (and thus disabling thumbnails created by Adobe Acrobat Reader), the problem was gone.

I "retried" my issue and could provoke a Dispatcher processing has been suspended exception:

Enable "PDF file preview" in Adobe Acrobat Reader (settings > general > activate checkbox)
Use any search term that includes some PDF file in your result list.
Wox.Infrastructure.Image.WindowsThumbnailProvider.GetHBitmap will throw said exception
This execption is only thrown for PDF files. All other files work well.

After disabling this feature in Acrobat Reader the exception is not thrown anymore.
The PTRun window does not look like in the screenshots above anymore, but the app is completely frozen then.
Any other third party plugin (e.g. Everything) was not activated. The Windows Search plugin returned the PDF file result.
System.InvalidOperationException
  HResult=0x80131509
  Nachricht = Die Dispatcherverarbeitung wurde angehalten, es werden jedoch weiterhin Nachrichten verarbeitet.
  Quelle = WindowsBase
  Stapelüberwachung:
   bei System.Windows.Threading.Dispatcher.WndProcHook(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
   bei MS.Win32.HwndWrapper.WndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
   bei MS.Win32.HwndSubclass.DispatcherCallbackOperation(Object o)
   bei System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Int32 numArgs)
   bei System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Int32 numArgs, Delegate catchHandler)
   bei System.Windows.Threading.Dispatcher.LegacyInvokeImpl(DispatcherPriority priority, TimeSpan timeout, Delegate method, Object args, Int32 numArgs)
   bei MS.Win32.HwndSubclass.SubclassWndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam)
   bei Wox.Infrastructure.Image.WindowsThumbnailProvider.IShellItemImageFactory.GetImage(NativeSize size, ThumbnailOptions flags, IntPtr& phbm)
   bei Wox.Infrastructure.Image.WindowsThumbnailProvider.GetHBitmap(String fileName, Int32 width, Int32 height, ThumbnailOptions options) in ...\PowerToys\src\modules\launcher\Wox.Infrastructure\Image\WindowsThumbnailProvider.cs: Zeile111

I have a fix. Yeeeees!!!!

I managed to repro something on Windows 10, but it's not throwing that exception. It's just hanging the Window a lot. I did manage to repro it on Windows 11, though.

@daniel-richter
Please have in mind that the thumbnails are generetad in PT Run's code and not in the Plugin code. So every plugin has this bug if it shows a PDF file result.

I managed to repro something on Windows 10, but it's not throwing that exception. It's just hanging the Window a lot. I did manage to repro it on Windows 11, though.

I could repro it on Windows 10 and wrote a fix. PR is ready in a few minutes. I will ping you.

This was fixed in the 0.67.1 hotfix

i've never had that option activated in Adobe, and yet i get crashes in PowerToys Run on some PDFs in version v67.1
This never happened before v65 ? which used Separate Net Runtime.
2023-02-15.txt

i've never had that option activated in Adobe, and yet i get crashes in PowerToys Run on some PDFs in version v67.1
This never happened before v65 ? which used Separate Net Runtime.
2023-02-15.txt

@haldi4803
And the crash only happens with PDF files in the results?

i mainly use PDF and Word files. Or rather Shortcuts to those files as they are on a network drive which does not support windows indexing -.-
so i can't make a proper statements there.

i mainly use PDF and Word files. Or rather Shortcuts to those files as they are on a network drive which does not support windows indexing -.-
so i can't make a proper statements there.

@jaimecbernardo
Do we have a time-out bug because of the network path?

I don't think it's network related.
Actually i opened Adobe Acrobat Reader (haven't done that in years Saw that the mentioned options is NOT ticked, selcted it, unslected, and haven't had a single Crash until now.
So that WAS an adobe related crash it seems... best to uninstall adobe if you dont use it.

My issue (24459) happened once only and has not reoccurred. More detail about circumstances: invoked Powertoys run using the default keys and then started typing in the name of an application, Goodsync, to run.
It wasn't clear when the crash happened as I wasn't paying attention

@jaimecbernardo
Saw your thumbnail setting PR to late. Had the same idea a few days ago.
But additional I thought if we should add a second setting to enable "debug" logging for the thumbnail provider. U think it would help to log that we start and finished generating a thumbnail for file x with file type y. Because that will generate many log entries I thought about hiding this behind a setting.

For any users that are able to replicate this consistently, can you please update to 0.68.1 and disable thumbnail generation to verify if it fixes the issue? Please let us know!

as @jaimecbernardo requested, updated to v0.68.1. right after it updated I changed the requested config option and opened powertoys run, it crashed after typing a few letters.
closed the application as shown:

started it again and tried
reopened it, used the powertoys run short, typed a few letters and crashed again.
it should be mentioned whether the configuration option does what it suppose to or something else to fix the bug, in both cases of using the powertoys run shortcut and starting to type, the application had thumbnails for the application:

that again AFTER THE UPDATE AND CONFIG CHANGE maybe it relates only to special application without the basic thumbnail but anyway wanted to give the full report

@jaimecbernardo Ever since my bug report in https://github.com/microsoft/PowerToys/issues/21934 I have not had the error reoccur, but note I've stopped using the file search altogether by disabling Windows Search. All this to say that I've reactivated Windows Search after your comment on my issue and the bug does not happen again to me, even while leaving the thumbnail generation activated. Sadly, I think I'm not of much help... I'll leave it on for now and report back if I encounter the issue again ;)

I can confirm, that disabling thumbnail generation results in a working power toys run.

Hi @jhonDoe15 and @myserycrash ,
Could you please try a 0.0.1 x64 dev build so we can try to see if my fix solves this for you? (It's an unsigned build)
https://github.com/jaimecbernardo/PowerToys/releases/tag/0.0.1-test-pr24736-fix-18166
Please uninstall your current PowerToys installation, then install this debug build.
Try to replicate the bug. (With thumbnail generation enabled again)
Please remember to uninstall this debug build and install an official release of PowerToys again.
Thank you, in advance.

after installing the test build the issue itself was resolved. that said, it didnt matter if I activated the thumbnail generation + when activating the feature, it didnt generate thumbnails for apps that it could before. I tried searching for the example as in the image above but it didnt get the thumbnail (again even after enabling the feature) see example:

for any possible inquiries regarding the selected string, i tried the original example and it reproduced a similar result

Hi @myserycrash , @jhonDoe15 , @jaimecbernardo to have a correct validation please don't forget to remove PT Run's image cache. Otherwise the data from the run with thumbnails disabled might be used.

@htcfreek  How would you do that?

@htcfreek How would you do that?

@jhonDoe15  Delete following file <AppDataDir>\Local\Microsoft\PowerToys\PowerToys Run\Settings\ImageCache.json. After deleting the file and enabling "Generate thumbnails from files" option, do you still get same results (no thumbnails for apps and delay)?
@JoClever Would you be willing to install test build as explained here https://github.com/microsoft/PowerToys/issues/18166#issuecomment-1464132917 ? Thanks

Testing with 0.68.1 with the Generate thumbnails from files disabled seems to be working much better for me, no freezing/crashing, also I don't have to keep rebuilding my icon and thumbnail caches where they were getting corrupted by PowerToys Run.

Testing with 0.68.1 with the Generate thumbnails from files disabled seems to be working much better for me, no freezing/crashing, also I don't have to keep rebuilding my icon and thumbnail caches where they were getting corrupted by PowerToys Run.

Thanks for the feedback! What about the test build? Did you try it?

Thanks for the feedback! What about the test build? Did you try it?

Happy to test but was not aware there was a test build, please point me in the right direction and I'll give it a whirl. 🙂

Check out this comment: https://github.com/microsoft/PowerToys/issues/18166#issuecomment-1464132917
And don't forget to delete PT Run image cache by deleting following file <AppDataDir>\Local\Microsoft\PowerToys\PowerToys Run\Settings\ImageCache.json before testing.

@htcfreek How would you do that?

@jhonDoe15 Delete following file <AppDataDir>\Local\Microsoft\PowerToys\PowerToys Run\Settings\ImageCache.json. After deleting the file and enabling "Generate thumbnails from files" option, do you still get same results (no thumbnails for apps and delay)?
@JoClever Would you be willing to install test build as explained here #18166 (comment) ? Thanks

I am happy to report that I cannot reproduce the crashes with the test build, even with thumbnail generation enabled!

@JoClever Thanks for the testing and the feedback! And do you experience some performance issues with PT Run? Are thumbnails loaded for different apps?

@JoClever Thanks for the testing and the feedback! And do you experience some performance issues with PT Run? Are thumbnails loaded for different apps?

After using the debug build for a while, I can't find any performance issues. Icons are also generated reliably as far as I could tell.
Looking forward to the next release!

Coming from https://github.com/microsoft/PowerToys/issues/24974 with comment to update here.
I had the "Dispatcher processing has been suspended" error using PT Runs since updating to 0.68.1 from a rather old version. The issue was happening on about once every 2-3 use.
Disabling thumbnail generation fixed the issue, no error in the last 2 work days.

Coming from #24974 with comment to update here.
I had the "Dispatcher processing has been suspended" error using PT Runs since updating to 0.68.1 from a rather old version. The issue was happening on about once every 2-3 use.
Disabling thumbnail generation fixed the issue, no error in the last 2 work days.

Can confirm, until now no crashes!

No crashes anymore since this option is available, thanks, good job!!

Fix is in 0.69 which was released today, thanks everyone for helping debug this.


A282953159619251 tests refactoring

This change is

Coverage remained the same at 91.099% when pulling 8d75d0cbd4632b17470b35505f6eed984705c806 on Scandie:a282953159619251_tests_refactoring into 30d818474c2d2bcc89a970f0027b697367a95275 on openprocurement:a282953159619251_tests_refactoring.


Add constrained_types package to the standard library

Implements RFC 79.
https://github.com/ponylang/rfcs/blob/main/text/0079-constrained-types.md
Closes #4492

Action linter failure is expected as it doesn't yet know about the macos-14 runner type.

Hi @SeanTAllen,
The changelog - added label was added to this pull request; all PRs with a changelog label need to have release notes included as part of the PR. If you haven't added release notes already, please do.
Release notes are added by creating a uniquely named file in the .release-notes directory. We suggest you call the file 4493.md to match the number of this pull request.
The basic format of the release notes (using markdown) should be:
## Title

End user description of changes, why it's important,
problems it solves etc.

If a breaking change, make sure to include 1 or more
examples what code would look like prior to this change
and how to update it to work after this change.

Thanks.

After this goes out in a release, I'm going to add a Pony pattern.


feature: support save to the current project directory

~/.code-remark/{projectName}
{projectPath}/.code-remark

support save to some file

{projectPath}/.vscode/code-remark.xml
{projectPath}/.idea/code-remark.xml

https://github.com/wenzewoo/jetbrains-code-remark/releases/tag/1.4.0


Integration error w/Stoplight and Docusaurus

Our documentation website is currently making use of docusaurus and we are trying to integrate stoplight into our website for API documentation. On integrating stoplight with our codebase we get the following error
"Module not found: Error: Can't resolve './dist/abort-controller' Did you mean 'abort-controller.mjs'?"
Context
Our docs are on docusaurus and we tried integrating stoplight elements with docusaurus. We have the api definition file (yml) and also installed the necessary node packages.
We created a JS file and added the stoplight-elements react component to it.
Our JS file looks similar to this https://github.com/dyte-in/docs/blob/main/src/pages/api.jsx
On running and building the app we get the following error
"Module not found: Error: Can't resolve './dist/abort-controller' Did you mean 'abort-controller.mjs'?"
Current Behavior

gz#9362(related to Zendesk ticket #9362)

This is our docs repo: https://github.com/symblai/symbl-docs
and this is the branch where we attempted stoplight-docusaurus integration: https://github.com/symblai/symbl-docs/tree/api-playground-using-stoplight

https://stackoverflow.com/questions/74876229/how-to-tweak-docusaurus-webpack-config-for-some-react-component
++ would be great to have an elements-docusaurus-plugin package

core.esm.js?b97d:5645 Uncaught (in promise) ReferenceError: process is not defined
    at eval (core.esm.js?b97d:5645:1)
    at<EMAIL_ADDRESS>(vendors-node_modules_stoplight_elements_index_mjs.js:1566:1)
    at __webpack_require__ (runtime~main.js:36:33)
    at fn (runtime~main.js:356:21)
    at eval (index.mjs:49:76)
    at<EMAIL_ADDRESS>(vendors-node_modules_stoplight_elements_index_mjs.js:8110:1)
    at __webpack_require__ (runtime~main.js:36:33)
    at fn (runtime~main.js:356:21)
    at eval (index.mjs:5:83)
    at<EMAIL_ADDRESS>(vendors-node_modules_stoplight_elements_index_mjs.js:8118:1)

ah, does this tool not support webpack 5 then?

I resloved this problem by node-polyfill-webpack-plugin

Hello!
Our team recently took over the stewardship of the elements repo.
Due the volume of un-triaged issues that are pretty old and the time it would take us to get caught up on all of them, we kindly ask that you open up a new ticket if this is still an issue you're struggling with.
If you open a new issue please include:

clear steps to reproduce that include example OAS specs, application setup, code, etc.
the error or issue you are experiencing
the expected behavior

We will be triaging any new tickets in a timely manner.
Thank you for understanding!


Include summary row in Excel export

If a grid has a summary row, it should be included as the "root" of a tree excel export

See PR: https://github.com/xh/hoist-react/pull/1986


NextJS server side redirect not working properly

Before opening, please confirm:

[X] I have checked to see if my question is addressed in the FAQ.
[X] I have searched for duplicate or closed issues.
[X] I have read the guide for submitting bug reports.
[X] I have done my best to include a minimal, self-contained set of instructions for consistently reproducing the issue.

App Id
dt0016ajs5y61
Region
us-east-1
Amplify Console feature
Custom builds
Describe the bug
I'm trying to redirect a path to another internal path in my application on getStaticProps. The redirect is successful during my local builds, but on my Amplify deploys I just get a JSON response that looks like this:
{
  "pageProps": {
    "__N_REDIRECT": "redirect-url",
    "__N_REDIRECT_STATUS": 307
  },
  "__N_SSG": true
}

My getStaticProps return looks like this:
if (redirectUrl) {
    return {
      redirect: {
        destination: redirectUrl,
        permanent: false,
      },
    };
  }

The thing is that the redirect url it's returning in the json file is the correct one, but it won't really redirect the page. I tested it with getServerSideProps and it worked just fine. For now it should be just fine, but it would be ideal for my project to use use getStaticProps and take advantages of Next JS's ISG.
Expected behavior
The page should be redirected to the url provided.
Reproduction steps

Create a redirect page in your Next JS app.
Deploy the application to Amplify.
Go to path that should redirect to other url

Build Settings
version: 0.1
backend:
  phases:
    build:
      commands:
        - '# Execute Amplify CLI with the helper script'
        - amplifyPush --simple
frontend:
  phases:
    preBuild:
      commands:
        - export BUILD_DIR=$PWD/$BUILD_DIR_NAME
        - yarn install
        - cat aws-exports.js
        - yarn lint --fix
        - export NODE_OPTIONS="--max-old-space-size=5120"
    build:
      commands:
        - yarn build
    postBuild:
        commands:
        - yarn postbuild
  artifacts:
    baseDirectory: .next
    files:
      - '**/*'
  cache:
    paths:
      - node_modules/**/*

Additional information
No response

Hi 👋🏽, thanks for bringing this to our attention. We're looking into this issue and I'll update once I have more information.

For my part fallback: 'blocking' works fine but fallback: true leads to a next js error

I have a similar issue with the redirect clause in next.config.json.
/** @type {import('next').NextConfig} */
module.exports = {
	...
	async rewrites() {
		return [
			{
				source: '/robots.txt',
				destination: '/api/robots'
			}
		];
	}
};

It works locally and the build is correctly handled in Amplify.
But, I get a 503 from amplify when trying to hit https://domain.com/robots.txt.  Is this a CloudFront mapping issue?

Most probably you may have forgot to change the fetch/axios.get URL inside the getServersideprops function.

I have same issue with redirecting.
async redirects() {
    return [
      {
        source: '/policies',
        destination: '/policies/privacy-policy',
        permanent: true,
      },
      {
        source: '/privacy-policy',
        destination: '/policies/privacy-policy',
        permanent: true,
      },
      {
        source: '/terms-use',
        destination: '/policies/terms-of-service',
        permanent: true,
      },
      {
        source: '/disclaimer',
        destination: '/policies/disclaimer',
        permanent: true,
      },
      {
        source: '/ordering-dna-test-kit-and-genome-sequencing-kit-terms-and-conditions',
        destination: '/policies/kit-order-terms-and-conditions',
        permanent: true,
      },
      {
        source: '/refund-policy',
        destination: '/policies/refund-policy',
        permanent: true,
      },
      {
        source: '/order-terms-conditions-membership',
        destination: '/policies/membership-terms-and-conditions',
        permanent: true,
      },
      {
        source: '/cookie-policy',
        destination: '/policies/cookie-policy',
        permanent: true,
      },
    ];
  },

So we have our new version of site and old version, we are using proxy to make work both versions properly. All code is deployed via AWS. The problem is that on old version we have old urls like /cookie-policy and etc. i need to redirect user to a new url /policies/cookie-policy. On my local environment everything working properly, but on production it still showing old url and not redirecting.

I have same issue with redirecting.
async redirects() {
    return [
      {
        source: '/policies',
        destination: '/policies/privacy-policy',
        permanent: true,
      },
      {
        source: '/privacy-policy',
        destination: '/policies/privacy-policy',
        permanent: true,
      },
      {
        source: '/terms-use',
        destination: '/policies/terms-of-service',
        permanent: true,
      },
      {
        source: '/disclaimer',
        destination: '/policies/disclaimer',
        permanent: true,
      },
      {
        source: '/ordering-dna-test-kit-and-genome-sequencing-kit-terms-and-conditions',
        destination: '/policies/kit-order-terms-and-conditions',
        permanent: true,
      },
      {
        source: '/refund-policy',
        destination: '/policies/refund-policy',
        permanent: true,
      },
      {
        source: '/order-terms-conditions-membership',
        destination: '/policies/membership-terms-and-conditions',
        permanent: true,
      },
      {
        source: '/cookie-policy',
        destination: '/policies/cookie-policy',
        permanent: true,
      },
    ];
  },

So we have our new version of site and old version, we are using proxy to make work both versions properly. All code is deployed via AWS. The problem is that on old version we have old urls like /cookie-policy and etc. i need to redirect user to a new url /policies/cookie-policy. On my local environment everything working properly, but on production it still showing old url and not redirecting.

Did you manage to resolve this? Have the same issue

Has anybody found a solution to this issue?

Has anybody found a solution to this issue?

Double check if you have duplicate redirects, check if there are spaces before and after the redirects, check for bad characters, trailing slash setup etc.
Also if you use middlewares, try removing them and see if redirects work, for me a bad middleware config was the core issue

Has anybody found a solution to this issue?

Double check if you have duplicate redirects, check if there are spaces before and after the redirects, check for bad characters, trailing slash setup etc. Also if you use middlewares, try removing them and see if redirects work, for me a bad middleware config was the core issue

Thanks for the tips! :)
I am actually using server-side redirecting, I double-checked the redirect links and don't have any whitespace in them and I am not using any middleware either. :/
Locally works fine, but on amplify it returns the actual redirect object, instead of handling it. 😞


Enhancement: Contributors Page

Issue: #39
It will look like this

Hello @Sh4dab , this repo has been excluded from Hacktoberfest, but I'm not sure of the reason. I suspect it might have been reported. As a result, I have created the same project here. I'll create an issue there, and you can comment on it and make the necessary changes. Afterward, you can create a PR.


ERROR: Unable to lock database: Permission denied

Hello @jeremylong ! I'm hoping that you can advise me. I'm trying to add OWASP DC to my GitLab CI/CD pipeline. The workflow will be run OWASP DC (script) then import the XML scan results to OWASP Defect Dojo (after script) but I'm having issues with the last part. The script is run against the DC container. If you could also review my DC command syntax, I would be appreciative.
I was receiving curl command not found so I added it.
/bin/sh: eval: line 104: curl: not found
- apk add --no-cache curl

But now I'm getting permission denied for adding the curl command that I need to import the report.
ERROR: Unable to lock database: Permission denied
ERROR: Failed to open apk database: Permission denied

Do you know how I can achieve this without modifying the DC DOCKERFILE?
Here is the YAML code for the GitLab CI Job:
# Scan Dependencies for known Vulnerabilities
# -----------------------------------------
dependencycheck:
  stage: security
  variables:
    SCAN_TYPE: scan_type="Dependency Check"
    REPORT: gl-dependency-check-report.xml
  image:
      name: owasp/dependency-check
      entrypoint: [""]
  script:
      - /usr/share/dependency-check/bin/dependency-check.sh -v
        --format XML
        --enableExperimental
        --suppression=$CI_PROJECT_DIR/dependency_check_suppressions.xml
        --scan=$CI_PROJECT_DIR
        --out=$REPORT
  artifacts:
    paths:
      - $REPORT
  after_script:
    - apk add --no-cache curl
    - curl -v -X POST "${DOJO_URL}"
      --header "${DOJO_AUTH}"
      --header "${DOJO_CONTENT}"
      --form "${ENGAGEMENT}"
      --form 'verified="true"'
      --form 'active="true"'
      --form 'lead="1"'
      --form 'tags="gitlab"'
      --form "${SCAN_TYPE}"
      --form 'minimum_severity="Info"'
      --form 'skip_duplicates="true"'
      --form 'close_old_findings="false"'
      --form<EMAIL_ADDRESS>

It appears that there are no volumes setup. As such, this will fail. I see that this might be possible using config.toml

Owasp_Dependency_Check:
stage: test
image:
name: owasp/dependency-check:latest
entrypoint: [""]
before_script:
- apk add --no-cache python3 py3-pip
Naviguer vers le répertoire python où se trouve votre script
- cd python

script:
- python3 dependency-Check.py
only:
- main
- /^feature/
Voici le problème que je rencontre...
$ apk add --no-cache python3 py3-pip
ERROR: Unable to lock database: Permission denied
ERROR: Failed to open apk database: Permission denied
ERROR: Job failed: exit code 99


CTRL-^ and CTRL-6 does not work in pynvim

CTRL-^ and CTRL-6 should open alternate file (#), but those mappings simply does not work in pynvim.

I just added the translation for those keys(version 0.0.30), I will publish to pypi when neovim/neovim#2182 is merged later

Should be fixed on pypi now. Can you verify with pip install --upgrade neovim? You also need to update Neovim

I'm using neovim from PPA, so I will wait for update from there.


facebook errors

For some users request to facebook fails with error:
Uncaught Error. https://graph.facebook.com/?id=http%3A%2F%2FXXXXX.me%2XXXXX { "error": { "message": "Unsupported get request. Please read the Graph API documentation at https://developers.facebook.com/docs/graph-api", "type": "GraphMethodException", "code": 100, "error_subcode": 33, "fbtrace_id": "B4YGhGhhiQe" } }
The error not catched.

Fee free to submit a pull request with a fix.

Got this also once. Found out the post/comment was deleted. Facebook returns actually a error with faulty information.


[Task]: Redesign action selector

Is there an existing issue for this?

[X] I have searched the existing issues

SubTasks

[ ] PRD
[ ] Solution exploration
[ ] Refinement
[ ] Feedback
[ ] Handoff

Estimated due date: June 24th, 2022


fix: falsey arguments not getting passed to kwargs

About
Fixes the boolean expression in gateway.py to only check for NoneType and not just falsey expressions.
Checklist

[x] I've ran pre-commit to format and lint the change(s) made.
[x] I've checked to make sure the change(s) work on 3.8.6 and higher.
[x] This fixes/solves an Issue.

(If existent): #570

[ ] I've made this pull request for/as: (check all that apply)

[ ] Documentation
[ ] Breaking change
[ ] New feature/enhancement
[x] Bugfix

This PR currently has merge conflicts, and will be automatically merged upon resolution.

This PR will be closed in 1 week following this message if the changes requested, as well as the resolution of merge conflicts are not met.

Closing; merge conflicts have not been resolved


bug in draw_forces (points list of pipes not correct)

Isn't this fixed? Can you give further detail?

i also don't know what this is about...


Pack/Unroll for the common formats are not implemented

The LittleCMS library supports many variations of colorspaces, pixels layout, alpha, planar, etc/etc. To handle all that variations the library transforms the input/output data to/from the cmsFormatters16 or to/from the cmsFormattersFloat. To improve the performance of this operation the library selects some specific Input/output formatter based on input/output data.
For example, here is the list of input formatters for cmsFormatters16. Note that the Unroll1Byte formatter is small and fast, but a generic formatter which can handle all the formats is big and slow.
Unfortunately, the list for the cmsFormattersFloat type is small and has only some generic/slow formatters.
I am interested is it possible to implement the specific formatters for such common format as 3-components (ex RGB), and maybe 1-components (ex GRAY), 3-comps+1-extra (ex RGBA) or there are some limitations that I am missing? I assume the implementation of that formatters will be just copying the bytes from input to output similar to the implementation of Unroll1Byte/Unroll3Bytes/Unroll3BytesSkip1Swap?
Probably one  N-components formatter will be good enough if that will use just one simple loop.

This is on purpose and is a strategic decision. If you want to use lcms in your commercial products, that's ok but floating point is generic and slow. If you want fast floating point, then you could use the fast_float plugin, which is way faster than just changing the formatters. But this latter is under GPL3. I like to promote free projects under GPL3 so I give them this advantage.

Unfortunately the OpenJDK is not commercial and its license GPL2+CP is not compatible to the GPL3.

You could also create a plug-in for the extra formatters. This is really simple and could live in the OpenJDK layer.

That would be great. Any examples of some simple plugins I cat learn on how to implement it? I cannot look to the standard lcms plugin to make sure I did not copy it.

There is a full manual with examples. Take a look on doc folder of distribution


podvm: Helper script to extract qcow image from container image

hey @jtumber-ibm , I just created one script for that purpose even before I see this issue :)


Issue is created twice when having slow internet

Hey, as you can see at #213 and #214 the issue has been created twice because I'm in Italy and have a slow internet connection.

And you only clicked the submit button once?

No I clicked twice because I thought it wasn't clicked yet. Maybe we should catch the "Submit"-Signal and than disable it for 30 seconds so only one issue is created. What do you think @RolfKoenders

Disabling the button when its making a request is something we could definitely add and will probably help with this. It will be enabled again if there was a network timeout. I actually can't remember if there is a loader or spinner shown when the submit button is pressed, that also gives the user the feeling that there is something going on and may prevent the user from clicking again.

@RolfKoenders there is nothing shown to the users. Because the click isn't really visible because the onclick "color change" is just in a light grey and not really got recognize

@RolfKoenders we could show a loading spinner till the result of the POST is there. What do you think


Endorser protocol askar fixes

Add askar support to integration test script (BDD_EXTRA_AGENT_ARGS="{\"wallet-type\":\"askar\"}" ./demo/run_bdd)
Fix database locking errors (similar issues as were fixed in PR https://github.com/hyperledger/aries-cloudagent-python/pull/1439)
Fix/cleanup unit tests
WIP, current status is:

unit tests are all passing
./run_bdd all tests pass (indy-sdk, default wallet)
ACAPY_ARG_FILE=postgres-indy-args.yml ./run_bdd all tests pass (indy-sdk, postgres wallet)
BDD_EXTRA_AGENT_ARGS="{\"wallet-type\":\"askar\"}" ./run_bdd tests fails due to database locking issue (askar/credx, default wallet)
BDD_EXTRA_AGENT_ARGS="{\"wallet-type\":\"askar\"}" ACAPY_ARG_FILE=postgres-indy-args.yml ./run_bdd all tests pass (askar/credx, postgres wallet)

Codecov Report

Merging #1450 (da61da9) into main (0c266fa) will decrease coverage by 0.00%.
The diff coverage is 81.81%.

@@            Coverage Diff             @@
##             main    #1450      +/-   ##
==========================================
- Coverage   95.75%   95.75%   -0.01%
==========================================
  Files         485      485
  Lines       29779    29753      -26
==========================================
- Hits        28515    28490      -25
+ Misses       1264     1263       -1


File changed message

The message is repeated "twice" every single operation.

I realised that this is not a bug but a feature.


How to get claims only via userinfo endpoint and not in the access token

hi,
i want to get custom claims via the userinfo endpoint. That works too but all of the custom claims are in access token too. I understand it in that way, that there is a possibility where i can put one or two claims (like email or name) in the access token and all of the other claims (given_name,...) are accessed via the userinfo endpoint. (and they are not in the access token)
my ProfileService is looking like that:
public class ProfileService : IProfileService
    {
        private readonly IUserClaimsPrincipalFactory<CustomUser> _claimsFactory;
        private readonly UserManager<CustomUser> _userManager;

        public ProfileService(UserManager<CustomUser> userManager,    IUserClaimsPrincipalFactory<CustomUser> claimsFactory)
        {
            _claimsFactory = claimsFactory;
            _userManager = userManager;
        }

        public async Task GetProfileDataAsync(ProfileDataRequestContext context)
        {
            var sub = context.Subject.GetSubjectId();
            var user = await _userManager.FindByIdAsync(sub);
            var principal = await _claimsFactory.CreateAsync(user);

            var claims = principal.Claims.ToList();
            claims = claims.Where(claim => context.RequestedClaimTypes.Contains(claim.Type)).ToList();

            claims.Add(new Claim(JwtClaimTypes.GivenName, user.FirstName));

            context.IssuedClaims = claims;

        }

        public async Task IsActiveAsync(IsActiveContext context)
        {
            var sub = context.Subject.GetSubjectId();
            var user = await _userManager.FindByIdAsync(sub);
            context.IsActive = user != null;
        }
    }

this is my config.cs file:
return new List<IdentityResource>
            {
                new IdentityResources.OpenId(),
                new IdentityResources.Profile(),
                new IdentityResources.Email(),
            };
        }

 public static IEnumerable<ApiResource> GetApiResources()
      {
          return new List<ApiResource>
          {
              new ApiResource("api1", "My API", new [] {JwtClaimTypes.Name })
          };
      }
new Client
                {
                    ClientId = "xxx",
                    ClientName = "xxx",
                    //AccessTokenType = AccessTokenType.Reference,
                    AccessTokenType = AccessTokenType.Jwt,
                    AllowedGrantTypes = GrantTypes.Implicit,
                    AllowAccessTokensViaBrowser = true,
                    RequireConsent = false,

                    RedirectUris =           { "http://localhost:4200/home" },
                    PostLogoutRedirectUris = { "http://localhost:4200/unauthorized" },
                    AllowedCorsOrigins =     { "http://localhost:4200" },

                    AllowedScopes =
                    {
                        IdentityServerConstants.StandardScopes.OpenId,
                        IdentityServerConstants.StandardScopes.Profile,
                        IdentityServerConstants.StandardScopes.Email,
                        "api1"
                       }
                }
            };

Have i missunderstood it?

This seems to be a general question about IdentityServer - not a bug report or an issue.
Please use one of the our free or commercial support options
See here for more details.
Thanks!


BUG do not write .phpsu/config/ssh_config on --dry-run

[ ] the file .phpsu/config/ssh_config should only be generated if it is really needed.

@ChrisB9 should we generate this file into /tmp or rather tempnam(sys_get_temp_dir(), 'Phpsu.ssh_config')?


[Documentation] Missing Cross-Referenced Information for Basic Information Cluster / SubscriptionsPerFabric Field

Documentation issues

Section <IP_ADDRESS> of the "Core" standard describes the CapabilityMinimaStruct Type attribute of the Basic Information Cluster.

In that section, it references Section 8.5.1 for how to determine the required minimum of the SubscriptionsPerFabric field :

However, Section 8.5.1 does not contain any information as to the required minimum (and I can't find any guidance elsewhere on how this is set).

And on a similar note, for subscriptions, is there any defined limitation on the number of paths that can be included in a subscriptions? If so, is there an attribute that identifies that limit?

Platform
No response
Anything else?
No response

This has not been corrected in the Matter 1.3 Core spec.


Unable to switch between windows

I have tried all possible ways which are provided in the official documentation to switch between multiple windows.
My scenario is

On click of a link in the current window, a new window will get launched
I need to switch the focus to the newly launched window
I tried the following ways but it is switching to the old window only
switchPage(1)
switPage('page title')
switPage('substring of URL without HTTPS://')
without switching also I have asserted the title

I couldn't achieve it. Please help me to resolve this

most likely duplicate of #1606 so try 1.1.0.RC3 first
if you still see the problem it is mandatory that you follow this process: https://github.com/intuit/karate/wiki/How-to-Submit-an-Issue


Provide typings for xql

Please provide typings for xql so this wonderful library can be used with Typescript.

Hello, I have no experience with TypeScript so I would let someone else to provide typings. I would keep this open for now, but don't intend to work on it.

Closing as I will not work on this.


Fission Reactor Buffer Not Emptying

Hey o/
It seems like the Fission Reactor is no longer able to transfer energy fast enough to clear it's buffer. I believe the maximum energy outputted needs to be increased, as the update rate is fairly low.
Original issue: https://github.com/NillerMedDild/Enigmatica2Expert/issues/532
Version

NuclearCraft-2.12k--1.12.2

I think I have this fixed for next version :)


fix crypto command

Summary
The requireArgs function is not needed because name and email are passed as a flag but not an argument

Labels

Test Plan

Checklist

[ ] If required, I have updated the Plural documentation accordingly.
[ ] I have added tests to cover my changes.
[ ] I have added a meaningful title and summary to convey the impact of this PR to a user.
[ ] I have added relevant labels to this PR to help with categorization for release notes.

@michaeljguarino I fixed also the action function PTAL


Bad performance for EK-100 Action Recognition finetuning model

Dear Yue,
Thanks for this amazing repo, which is well-documented and easy to try on! However, when I followed your guidance to fine-tune the action recognition model on EK-100. I got very bad results (Acc@1 0.021 Acc@5 0.089 for test and train_Acc@1": 2.62106393129771, "train_Acc@5": 9.759661259541986 even for training). Do you have any idea about that?
To include more details for your reference, I used the resized, chunked version of EK-100 that you shared here. I used the pre-trained model you provided here. And the following is the command I used for fine-tuning.
PYTHONPATH=.:third_party/decord/python/ \
CUDA_VISIBLE_DEVICES="0,1" \
torchrun \
    --nproc_per_node=2 scripts/main_lavila_finetune_cls.py \
    --root datasets/EK100/EK100_320p_15sec_30fps_libx264/ \
    --video-chunk-length 15 --use-flash-attn \
    --grad-checkpointing \
    --use-fast-conv1 \
    --batch-size 256 \
    --fused-decode-crop \
    --use-multi-epochs-loader \
    --pretrain-model experiments/pretrain_lavila_vitb/avion_pretrain_lavila_vitb_best.pt \
    --output-dir experiments/EK100_test 2>&1 | tee experiments/EK100_test/train_log.txt

And I also attached the generated train_log.txt for your reference.
Thank you in advance for your help!

Update
I would like to share more of my trials for your reference.

Firstly, since the training loss cannot converge to a reasonable performance, I tried to train based on only one sample. It showed the model can achieve 100% accuracy, which means the back propagation actually works.
Secondly, I also tried to train the model with different backbones and different machines. It seems to show that they all converge to the same local minima, as is shown in the following table.

Hey @HaozheQi ,
The config seems okay to me. Could you try one with the same per-GPU batch size? We use a default batch size of 32. Not sure if something wrong was triggered because of that. You can also check out our training log here.

Dear Yue,
Firstly, thank you for the repo as well, it was super interesting and we're also trying to use the model for our purpose. As a starter, I am just trying to fine tune the model on the EK100 dataset before testing on my own dataset. However, I am also facing similar issue to what Qi had suggested. this was the config that I used to train on the full dataset with batch-size 32.
PYTHONPATH=.:third_party/decord/python/ torchrun \     --nproc_per_node=1 scripts/main_lavila_finetune_cls.py \     --root datasets/EK100/EK100_320p_15sec_30fps_libx264/ \     --video-chunk-length 15 --use-flash-attn \     --grad-checkpointing \     --use-fast-conv1 \     --batch-size 32 \     --fused-decode-crop \     --use-multi-epochs-loader \     --pretrain-model experiments/pretrain_lavila_vitb/avion_pretrain_lavila_vitb_best.pt \     --output-dir test_fine_tuning 2>&1 | tee test_fine_tuning/log.txt
This was what I got after 4 epochs (unfortunately, something went wrong during the training and crashed my computer).

Compared to your training log, it seems already much lower even after the same number of epochs.

Next, I tried training with only 100 samples to simplify the problem and tried getting it to overfit, but it did not manage to overfit even on the training set as shown below.

I would be grateful if you could provide any sort of advice to the problem.

Hi @FranklinLeong ,
I am not sure if @HaozheQi solved the issue but during the last email communication with him, I mentioned trying to turn off the loss scale to see if it works. For bf16 loss scaling is not required.

I unfortunately haven't solved the problem, disabling the mixup and upgrading the flash-attention to flash-attention 2 can improve the performance a bit but I cannot reach the ideal performance.

@HaozheQi
Can you check the decord version by running the following command (in the same working environment):
python -c "import decord; print(decord.__path__)"

It would be good to see if the correct decord is being used during training. The main branch would probably fail.

Hi, @zhaoyue-zephyrus

Directly run python -c "import decord; print(decord.__path__)" would point to another path ['/home/haozhe/.local/lib/python3.10/site-packages/decord-0.6.0-py3.10-linux-x86_64.egg/decord']
However, when running Avion, I will run as PYTHONPATH=.:third_party/decord/python/ python -c "import decord; print(decord.__path__)", this will point to the correct path. ['/home/haozhe/kitchen/AVION/third_party/decord/python/decord']

Therefore, I think my discord installation should have no problem, I also try to plot the image in the end of the video_loader and the generated video images look reasonable.

Hey @HaozheQi ,
The config seems okay to me. Could you try one with the same per-GPU batch size? We use a default batch size of 32. Not sure if something wrong was triggered because of that. You can also check out our training log here.

Hello @zhaoyue-zephyrus,
Thank you for sharing the code and the training logs.
Hi @HaozheQi,
I faced similar issues and I believe the reason is that the default value of weight decay is 0.05 whereas the the one in the training log is 4e-5. The relatively high default weight decay seems to have affected the training. Setting the weight decay to 4e-5 and changing other parameters to the ones from the log resolved the issue for me.

Hi @rishik18
Thanks for spotting this issue! I'll update the example command accordingly.
Best,
Yue

Hi @HaozheQi @FranklinLeong ,
The default optimizer uses SGD (instead of AdamW during pre-training) so a smaller weight decay value is required. Please give it another try. I'm closing this issue and feel free to re-open if the problem still exists.


Add gulp watch with livereload

This should automatically build in the background and automatically reload the debug page
This should make development easier
See https://github.com/jvwong/GOList as a reference with the code in the gulpfile and the livereload include in the html https://github.com/jvwong/GOList/blob/master/index.html#L11

@ugurdogrusoz @metincansiper Let me know if you run into any issues.  This should make debugging/testing much easier.