owasp/modsecurity-crs:apache server reached MaxRequestWorkers setting

The apache version does an infinite redirect if some /etc/passwd api/navigation url is called.
To Reproduce:
Take this docker file:
https://github.com/coreruleset/modsecurity-crs-docker/blob/main/docker-compose.yaml
# start crs-apache service
docker-compose up -d crs-apache

# this will work
curl http://localhost:80/?file=/etc/passwd

# this will crash the webserver
curl http://localhost:80/etc/passwd

Docker logs:
2024-06-27 10:56:53 crs-apache-1  | /usr/local/bin/generate-certificate: generating new certificate
2024-06-27 10:56:53 crs-apache-1  | Warning: No -copy_extensions given; ignoring any extensions in the request
2024-06-27 10:56:53 crs-apache-1  | /usr/local/bin/generate-certificate: generated /usr/local/apache2/conf/server.key and /usr/local/apache2/conf/server.crt
2024-06-27 10:56:54 crs-apache-1  | [Thu Jun 27 08:56:54.037390 2024] [ssl:error] [pid 1:tid<PHONE_NUMBER>31488] AH02217: ssl_stapling_init_cert: can't retrieve issuer certificate! [subject: OU=MyUnit,O=MyOrg,L=NY,ST=NY,C=US,emailAddress=none@none.com,CN=localhost / issuer: OU=MyUnit,O=MyOrg,L=NY,ST=NY,C=US,emailAddress=none@none.com,CN=localhost / serial: 2BB69DE0961FA576F1046042882927CBA1C203D9 / notbefore: Jun 27 08:56:53 2024 GMT / notafter: Jun 27 08:56:53 2025 GMT]
2024-06-27 10:56:54 crs-apache-1  | [Thu Jun 27 08:56:54.037436 2024] [ssl:error] [pid 1:tid<PHONE_NUMBER>31488] AH02604: Unable to configure certificate localhost:8443:0 for stapling
2024-06-27 10:56:54 crs-apache-1  | [Thu Jun 27 08:56:54.037466 2024] [security2:notice] [pid 1:tid<PHONE_NUMBER>31488] ModSecurity for Apache/2.9.7 (http://www.modsecurity.org/) configured.
2024-06-27 10:56:54 crs-apache-1  | [Thu Jun 27 08:56:54.037468 2024] [security2:notice] [pid 1:tid<PHONE_NUMBER>31488] ModSecurity: APR compiled version="1.7.2"; loaded version="1.7.2"
2024-06-27 10:56:54 crs-apache-1  | [Thu Jun 27 08:56:54.037470 2024] [security2:notice] [pid 1:tid<PHONE_NUMBER>31488] ModSecurity: PCRE compiled version="8.39 "; loaded version="8.39 2016-06-14"
2024-06-27 10:56:54 crs-apache-1  | [Thu Jun 27 08:56:54.037471 2024] [security2:notice] [pid 1:tid<PHONE_NUMBER>31488] ModSecurity: LUA compiled version="Lua 5.3"
2024-06-27 10:56:54 crs-apache-1  | [Thu Jun 27 08:56:54.037472 2024] [security2:notice] [pid 1:tid<PHONE_NUMBER>31488] ModSecurity: YAJL compiled version="2.1.0"
2024-06-27 10:56:54 crs-apache-1  | [Thu Jun 27 08:56:54.037473 2024] [security2:notice] [pid 1:tid<PHONE_NUMBER>31488] ModSecurity: LIBXML compiled version="2.9.14"
2024-06-27 10:56:54 crs-apache-1  | [Thu Jun 27 08:56:54.037474 2024] [security2:notice] [pid 1:tid<PHONE_NUMBER>31488] ModSecurity: Original server signature: Apache/2.4.59 (Unix) OpenSSL/3.0.11
2024-06-27 10:56:54 crs-apache-1  | [Thu Jun 27 08:56:54.037475 2024] [security2:notice] [pid 1:tid<PHONE_NUMBER>31488] ModSecurity: Status engine is currently disabled, enable it by set SecStatusEngine to On.
2024-06-27 10:56:54 crs-apache-1  | [Thu Jun 27 08:56:54.085027 2024] [ssl:error] [pid 1:tid<PHONE_NUMBER>31488] AH02217: ssl_stapling_init_cert: can't retrieve issuer certificate! [subject: OU=MyUnit,O=MyOrg,L=NY,ST=NY,C=US,emailAddress=none@none.com,CN=localhost / issuer: OU=MyUnit,O=MyOrg,L=NY,ST=NY,C=US,emailAddress=none@none.com,CN=localhost / serial: 2BB69DE0961FA576F1046042882927CBA1C203D9 / notbefore: Jun 27 08:56:53 2024 GMT / notafter: Jun 27 08:56:53 2025 GMT]
2024-06-27 10:56:54 crs-apache-1  | [Thu Jun 27 08:56:54.085054 2024] [ssl:error] [pid 1:tid<PHONE_NUMBER>31488] AH02604: Unable to configure certificate localhost:8443:0 for stapling
2024-06-27 10:56:54 crs-apache-1  | [Thu Jun 27 08:56:54.087594 2024] [mpm_event:notice] [pid 1:tid<PHONE_NUMBER>31488] AH00489: Apache/2.4.59 (Unix) OpenSSL/3.0.11 Apache configured -- resuming normal operations
2024-06-27 10:56:54 crs-apache-1  | [Thu Jun 27 08:56:54.087618 2024] [core:notice] [pid 1:tid<PHONE_NUMBER>31488] AH00094: Command line: 'httpd -D FOREGROUND'
2024-06-27 10:56:59 crs-apache-1  | [Thu Jun 27 08:56:59.851408 2024] [security2:error] [pid 32:tid<PHONE_NUMBER>14176] [client <IP_ADDRESS>:59528] [client <IP_ADDRESS>] ModSecurity: Warning. Matched phrase "etc/passwd" at ARGS:file. [file "/etc/modsecurity.d/owasp-crs/rules/REQUEST-930-APPLICATION-ATTACK-LFI.conf"] [line "116"] [id "930120"] [msg "OS File Access Attempt"] [data "Matched Data: etc/passwd found within ARGS:file: /etc/passwd"] [severity "CRITICAL"] [ver "OWASP_CRS/4.3.0"] [tag "modsecurity"] [tag "application-multi"] [tag "language-multi"] [tag "platform-multi"] [tag "attack-lfi"] [tag "paranoia-level/1"] [tag "OWASP_CRS"] [tag "capec/1000/255/153/126"] [tag "PCI/6.5.4"] [hostname "localhost"] [uri "/"] [unique_id "Zn0pW-L7yAD60VEVxI269gAAAEA"]
2024-06-27 10:56:59 crs-apache-1  | [Thu Jun 27 08:56:59.851533 2024] [security2:error] [pid 32:tid<PHONE_NUMBER>14176] [client <IP_ADDRESS>:59528] [client <IP_ADDRESS>] ModSecurity: Warning. Matched phrase "etc/passwd" at ARGS:file. [file "/etc/modsecurity.d/owasp-crs/rules/REQUEST-932-APPLICATION-ATTACK-RCE.conf"] [line "575"] [id "932160"] [msg "Remote Command Execution: Unix Shell Code Found"] [data "Matched Data: etc/passwd found within ARGS:file: /etc/passwd"] [severity "CRITICAL"] [ver "OWASP_CRS/4.3.0"] [tag "modsecurity"] [tag "application-multi"] [tag "language-shell"] [tag "platform-unix"] [tag "attack-rce"] [tag "paranoia-level/1"] [tag "OWASP_CRS"] [tag "capec/1000/152/248/88"] [tag "PCI/6.5.2"] [hostname "localhost"] [uri "/"] [unique_id "Zn0pW-L7yAD60VEVxI269gAAAEA"]
2024-06-27 10:56:59 crs-apache-1  | [Thu Jun 27 08:56:59.851916 2024] [security2:error] [pid 32:tid<PHONE_NUMBER>14176] [client <IP_ADDRESS>:59528] [client <IP_ADDRESS>] ModSecurity: Access denied with code 403 (phase 2). Operator GE matched 5 at TX:blocking_inbound_anomaly_score. [file "/etc/modsecurity.d/owasp-crs/rules/REQUEST-949-BLOCKING-EVALUATION.conf"] [line "233"] [id "949110"] [msg "Inbound Anomaly Score Exceeded (Total Score: 10)"] [ver "OWASP_CRS/4.3.0"] [tag "modsecurity"] [tag "anomaly-evaluation"] [tag "OWASP_CRS"] [hostname "localhost"] [uri "/"] [unique_id "Zn0pW-L7yAD60VEVxI269gAAAEA"]
2024-06-27 10:56:59 crs-apache-1  | [Thu Jun 27 08:56:59.852079 2024] [security2:error] [pid 32:tid<PHONE_NUMBER>14176] [client <IP_ADDRESS>:59528] [client <IP_ADDRESS>] ModSecurity: Warning. Unconditional match in SecAction. [file "/etc/modsecurity.d/owasp-crs/rules/RESPONSE-980-CORRELATION.conf"] [line "98"] [id "980170"] [msg "Anomaly Scores: (Inbound Scores: blocking=10, detection=10, per_pl=10-0-0-0, threshold=5) - (Outbound Scores: blocking=0, detection=0, per_pl=0-0-0-0, threshold=4) - (SQLI=0, XSS=0, RFI=0, LFI=5, RCE=5, PHPI=0, HTTP=0, SESS=0, COMBINED_SCORE=10)"] [ver "OWASP_CRS/4.3.0"] [tag "modsecurity"] [tag "reporting"] [tag "OWASP_CRS"] [hostname "localhost"] [uri "/"] [unique_id "Zn0pW-L7yAD60VEVxI269gAAAEA"]
2024-06-27 10:56:59 crs-apache-1  | {"transaction":{"time":"27/Jun/2024:08:56:59.852108 +0000","transaction_id":"Zn0pW-L7yAD60VEVxI269gAAAEA","remote_address":"<IP_ADDRESS>","remote_port":59528,"local_address":"<IP_ADDRESS>","local_port":8080},"request":{"request_line":"GET /?file=/etc/passwd HTTP/1.1","headers":{"Host":"localhost","User-Agent":"curl/8.7.1","Accept":"*/*"}},"response":{"protocol":"HTTP/1.1","status":403,"headers":{"Content-Length":"199","Content-Type":"text/html; charset=iso-8859-1"},"body":"<!DOCTYPE HTML PUBLIC \"-//IETF//DTD HTML 2.0//EN\">\n\n<title>403 Forbidden</title>\n\n
Forbidden
\n
You don't have permission to access this resource.
\n\n"},"audit_data":{"messages":["Warning. Matched phrase \"etc/passwd\" at ARGS:file. [file \"/etc/modsecurity.d/owasp-crs/rules/REQUEST-930-APPLICATION-ATTACK-LFI.conf\"] [line \"116\"] [id \"930120\"] [msg \"OS File Access Attempt\"] [data \"Matched Data: etc/passwd found within ARGS:file: /etc/passwd\"] [severity \"CRITICAL\"] [ver \"OWASP_CRS/4.3.0\"] [tag \"modsecurity\"] [tag \"application-multi\"] [tag \"language-multi\"] [tag \"platform-multi\"] [tag \"attack-lfi\"] [tag \"paranoia-level/1\"] [tag \"OWASP_CRS\"] [tag \"capec/1000/255/153/126\"] [tag \"PCI/6.5.4\"]","Warning. Matched phrase \"etc/passwd\" at ARGS:file. [file \"/etc/modsecurity.d/owasp-crs/rules/REQUEST-932-APPLICATION-ATTACK-RCE.conf\"] [line \"575\"] [id \"932160\"] [msg \"Remote Command Execution: Unix Shell Code Found\"] [data \"Matched Data: etc/passwd found within ARGS:file: /etc/passwd\"] [severity \"CRITICAL\"] [ver \"OWASP_CRS/4.3.0\"] [tag \"modsecurity\"] [tag \"application-multi\"] [tag \"language-shell\"] [tag \"platform-unix\"] [tag \"attack-rce\"] [tag \"paranoia-level/1\"] [tag \"OWASP_CRS\"] [tag \"capec/1000/152/248/88\"] [tag \"PCI/6.5.2\"]","Access denied with code 403 (phase 2). Operator GE matched 5 at TX:blocking_inbound_anomaly_score. [file \"/etc/modsecurity.d/owasp-crs/rules/REQUEST-949-BLOCKING-EVALUATION.conf\"] [line \"233\"] [id \"949110\"] [msg \"Inbound Anomaly Score Exceeded (Total Score: 10)\"] [ver \"OWASP_CRS/4.3.0\"] [tag \"modsecurity\"] [tag \"anomaly-evaluation\"] [tag \"OWASP_CRS\"]","Warning. Unconditional match in SecAction. [file \"/etc/modsecurity.d/owasp-crs/rules/RESPONSE-980-CORRELATION.conf\"] [line \"98\"] [id \"980170\"] [msg \"Anomaly Scores: (Inbound Scores: blocking=10, detection=10, per_pl=10-0-0-0, threshold=5) - (Outbound Scores: blocking=0, detection=0, per_pl=0-0-0-0, threshold=4) - (SQLI=0, XSS=0, RFI=0, LFI=5, RCE=5, PHPI=0, HTTP=0, SESS=0, COMBINED_SCORE=10)\"] [ver \"OWASP_CRS/4.3.0\"] [tag \"modsecurity\"] [tag \"reporting\"] [tag \"OWASP_CRS\"]"],"error_messages":["[file \"apache2_util.c\"] [line 275] [level 3] [client <IP_ADDRESS>] ModSecurity: Warning. Matched phrase \"etc/passwd\" at ARGS:file. [file \"/etc/modsecurity.d/owasp-crs/rules/REQUEST-930-APPLICATION-ATTACK-LFI.conf\"] [line \"116\"] [id \"930120\"] [msg \"OS File Access Attempt\"] [data \"Matched Data: etc/passwd found within ARGS:file: /etc/passwd\"] [severity \"CRITICAL\"] [ver \"OWASP_CRS/4.3.0\"] [tag \"modsecurity\"] [tag \"application-multi\"] [tag \"language-multi\"] [tag \"platform-multi\"] [tag \"attack-lfi\"] [tag \"paranoia-level/1\"] [tag \"OWASP_CRS\"] [tag \"capec/1000/255/153/126\"] [tag \"PCI/6.5.4\"] [hostname \"localhost\"] [uri \"/\"] [unique_id \"Zn0pW-L7yAD60VEVxI269gAAAEA\"]","[file \"apache2_util.c\"] [line 275] [level 3] [client <IP_ADDRESS>] ModSecurity: Warning. Matched phrase \"etc/passwd\" at ARGS:file. [file \"/etc/modsecurity.d/owasp-crs/rules/REQUEST-932-APPLICATION-ATTACK-RCE.conf\"] [line \"575\"] [id \"932160\"] [msg \"Remote Command Execution: Unix Shell Code Found\"] [data \"Matched Data: etc/passwd found within ARGS:file: /etc/passwd\"] [severity \"CRITICAL\"] [ver \"OWASP_CRS/4.3.0\"] [tag \"modsecurity\"] [tag \"application-multi\"] [tag \"language-shell\"] [tag \"platform-unix\"] [tag \"attack-rce\"] [tag \"paranoia-level/1\"] [tag \"OWASP_CRS\"] [tag \"capec/1000/152/248/88\"] [tag \"PCI/6.5.2\"] [hostname \"localhost\"] [uri \"/\"] [unique_id \"Zn0pW-L7yAD60VEVxI269gAAAEA\"]","[file \"apache2_util.c\"] [line 275] [level 3] [client <IP_ADDRESS>] ModSecurity: Access denied with code 403 (phase 2). Operator GE matched 5 at TX:blocking_inbound_anomaly_score. [file \"/etc/modsecurity.d/owasp-crs/rules/REQUEST-949-BLOCKING-EVALUATION.conf\"] [line \"233\"] [id \"949110\"] [msg \"Inbound Anomaly Score Exceeded (Total Score: 10)\"] [ver \"OWASP_CRS/4.3.0\"] [tag \"modsecurity\"] [tag \"anomaly-evaluation\"] [tag \"OWASP_CRS\"] [hostname \"localhost\"] [uri \"/\"] [unique_id \"Zn0pW-L7yAD60VEVxI269gAAAEA\"]","[file \"apache2_util.c\"] [line 275] [level 3] [client <IP_ADDRESS>] ModSecurity: Warning. Unconditional match in SecAction. [file \"/etc/modsecurity.d/owasp-crs/rules/RESPONSE-980-CORRELATION.conf\"] [line \"98\"] [id \"980170\"] [msg \"Anomaly Scores: (Inbound Scores: blocking=10, detection=10, per_pl=10-0-0-0, threshold=5) - (Outbound Scores: blocking=0, detection=0, per_pl=0-0-0-0, threshold=4) - (SQLI=0, XSS=0, RFI=0, LFI=5, RCE=5, PHPI=0, HTTP=0, SESS=0, COMBINED_SCORE=10)\"] [ver \"OWASP_CRS/4.3.0\"] [tag \"modsecurity\"] [tag \"reporting\"] [tag \"OWASP_CRS\"] [hostname \"localhost\"] [uri \"/\"] [unique_id \"Zn0pW-L7yAD60VEVxI269gAAAEA\"]"],"action":{"intercepted":true,"phase":2,"message":"Operator GE matched 5 at TX:blocking_inbound_anomaly_score."},"handler":"proxy-server","stopwatch":{"p1":471,"p2":625,"p3":0,"p4":0,"p5":86,"sr":0,"sw":0,"l":0,"gc":0},"response_body_dechunked":true,"producer":["ModSecurity for Apache/2.9.7 (http://www.modsecurity.org/)","OWASP_CRS/4.3.0"],"server":"Apache/2.4.59 (Unix) OpenSSL/3.0.11","engine_mode":"ENABLED"}}
2024-06-27 10:57:44 crs-apache-1  | [Thu Jun 27 08:57:44.147622 2024] [mpm_event:error] [pid 1:tid<PHONE_NUMBER>31488] AH00484: server reached MaxRequestWorkers setting, consider raising the MaxRequestWorkers setting

That's because you haven't specified a backend. The container runs in proxy mode by default and the proxy is configured for localhost, hence the redirects.

Please reopen if you feel that you need more help.


The unsaved file marker (the dot thing) should appear when content in buffer != content on disk

I have configured "files.autoSaveDelay": 10000 (10s). If I make an edit to a file I expect to see the unsaved file marker for 10s and then, after the file is saved, it disappears. Right now, I never see the dirty marker, even if I use a very large number for "files.autoSaveDelay" such as 1 week, effectively disabling the auto-save behaviour.

Forgot the mention I use these settings:
	, "files.autoSave": "afterDelay"
	, "files.autoSaveDelay": 10000

@alexandrudima we had this discussion in the UX team @stevencl @chrisdias and decided to not show it at all because otherwise we would also see it in our beloved 1s auto save delay setup in selfhost, which we did not find very compelling.

I think we have opened a door now with "files.autoSave": "onFocusChange" and the configurable timeout and old assumptions need to be revisited. Maybe it is not a problem for a 1s delay.
But for example, when I use onFocusChange I really don't get any dirty indication. I understand that setting a delay of 10s is artificial... but what do you think

@alexandrudima I think the better solution is to introduce another setting to control dirty indicators.

What if we just decided to delay showing the dirty indicators until 1 second has passed?  I think I would prefer that we fine tune the experience so that it works well without needing the user to configure whether or not they show up.
So if the user has autosave set to onfocuschange or ondelay and the file is dirty for more than 1 second we would show the dirty indicator.
What do you think?

Or if the delay is set to 1 second or less we don't show the dirty indicator. If it is set to more than 1 second we show it immediately. So in Alex's case above where he has it set to 10 seconds the dirty indicator would show up as soon as the file is changed. But in the case where the delay is set to 1 second, it wouldn't show up.

@stevencl I am happy to avoid another setting! I am fine with not showing it for a delay of 1s and below, but what about showing it always for then it is configured to save on focus change? Imho we need to be consistent and then show the indicator always in that case.

Yes, I agree. That was what I meant in my last comment, that we would only not show it if set to ondelay and the delay is set to 1 second or lower. If it is set to onfocuschange we always show the indicator.

Verify that dirty indicators show up unless auto save is configured 1s and below. Verify no data loss, also when quitting the app while you have dirty around (we automatically save instantly in that case).

@bpasero Nice! Thank you

Giving bug label to get it in verification queries


PR: Update py2app to 0.28 (Mac app)

Description of Changes
Update py2app to version 0.28.
This includes a new recipe for black, updated recipe for pyqt, and fixes for egg handling.
Some additions to the setup call brings the build into compliance with setuptools>60.10.0.
Issue(s) Resolved

Fixes #17609
Fixes #17551
Affirmation
By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct: @mrclary

Hello @mrclary! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file installers/macOS/setup.py:

Line 32:8: E221 multiple spaces before operator
Line 33:8: E221 multiple spaces before operator
Line 34:9: E221 multiple spaces before operator

@mrclary, our Mac app is failing to be built due to the release of Py2app 0.28. So, is there something else you need to finish here? Or can we merge it to fix our tests?

I was waiting to ensure that these CI tests to pass. Should be good to go now.


Replace bash script log collector with a more resilient go based log collector

Currently, the e2e tests just use kubectl logs -f ... to collect logs. This leads to issues if the pod goes away, as no more logs are collected. We have been seeing this in CI recently with the logs from the kafka-controller only including about 5 minutes worth of logs.

Proposed Changes

Use a go based logging solution that picks up on any new pods and starts gathering those logs too.
Put this into a separate directory so that we can ensure that this works before fully switching the logging solution used in CI

/cc @Leo6Leo @creydr @matzew

Maybe this is something what we could have the core in eventing-core (or pkg/reconciler-test repo?!?) and then reuse it in different repos. But I am fine with starting here and then tweaking it.

@creydr yeah I think I'd just like to start this here, and then when we know it works and are happy with it, move it somewhere more general.

/cc @creydr

/retest

/test reconciler-tests-namespaced-broker

/retest

can we remove the other one? and perhaps just use logs as directory name?

@pierDipi for suure, we just need to add the setup/teardown calls to this new package to all of the testing main functions first! I was planning on doing that in a separate PR after people were happy with the changes here

/retest-required

/retest-required


Parallelize release github action

This PR improves the release process (python-release.yml) by parallelizing the action per os and python versions to speed up the overall run.
Test run on branch, https://github.com/kevinjqliu/iceberg-python/actions/runs/12016469529
Versus main, https://github.com/kevinjqliu/iceberg-python/actions/runs/12016505196/job/33496840039

nevermind its not faster due to python package cache


Add test_bdb from CPython 3.9

Requesting @deantvv as a reviewer to help out with the test.support stuff.

@fanninpm There is still some weird error. For the test.support part, it looks good to me.


Make UDP service code simpler

Hi,
When I wrote this code, I was inspired from graphite and collectd endpoints. Then I noticed that Server and Service are the exact same thing ! I guess Server is the old name for Service, isn't it? So why bother making a kind of wrapper whereas it could be way simpler ?
I also removed the log each time a packet is read from UDP.
Hope this will be useful even if it's not crucial :)

@renan- This looks good.  I agree we probably had an extra layer in there.  It came from a quick refactoring.  This is better.
The logging is something we'll likely add a configuration option for in the future for debugging, but I agree, by default, it should be off.
Next up, testing :-).
Thanks again for all your hard work!
+1

You're welcome, I'm glad I could help out :-)
Btw, I'm currently working on making retention policy and consistency level configurable. Would you like me to create another PR for this feature ? (I could also add these config fields to the services lacking them).
Also, my company needs to be able to have multiple UDP services to run at the same time because database and rp are now service-instance-specific. I think this would be a great addition, just like it's done with Graphite (easy enough). What's your opinion on the matter ?

Let's do that in a future PR.  Also, before we allow multiple UDP ports, go ahead and actually open an issue stating your problem.  This will allow for the core team to comment on it as an ISSUE before you do work on it.  I do agree that people will likely need this feature.

Well that's not what I'd call an issue, it's more like a feature to me.
Currently working on configurable RP and CL, I'll open a PR when I'm done.

It's an issue in as much as the current system doesn't meet your needs.  Alternatively you can start a thread on the mailing list and our support team can turn it into an issue from there, but ultimately, I suspect it will end up being an issue as that is how we manage work effort on our team.

+1 from me too -- merging now.


Not working

Affaird to say, following this article does not yield the desired result.  Going into Teams -> Profile Button -> About has no "developer preview" Button.
You have Microsoft Teams Version <IP_ADDRESS>64 (64-bit). It was last updated on 5/7/19.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 008da4e2-979e-c396-db28-4acf57deb530
Version Independent ID: f1413f77-5eb3-e1fd-9235-d322d6e4eb6c
Content: Developer Preview - Teams
Content Source: msteams-platform/resources/dev-preview/developer-preview-intro.md
Product: msteams
GitHub Login: @o365devx
Microsoft Alias: o365devx

Could you please check with your tenant admin if sideloading is enabled in your organization?

Please re-open if you are still facing this issue.

On my tenant even as on my customer there is no ponit for developer mode(s). Independent of the clientarchitecture (x86/x64) and yes, sideloading is enabled OrgWide, on Team and even for (specific)User.
So please reopen and clarify a solution.


xmrig: 6.14.0 -> 6.14.1

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/xmrig/versions.
meta.description for xmrig is: "Monero (XMR) CPU miner"
meta.homepage for xmrig is: "https://github.com/xmrig/xmrig"
meta.changelog for xmrig is: ""
Updates performed

Version update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS

The tests defined in passthru.tests, if any, passed

/nix/store/52s25jxwpd14w3p3m4b9skqc8f91wi8a-xmrig-6.14.1/bin/xmrig passed the binary check.

1 of 1 passed binary check by having a zero exit code.

1 of 1 passed binary check by having the new version present in output.

found 6.14.1 with grep in /nix/store/52s25jxwpd14w3p3m4b9skqc8f91wi8a-xmrig-6.14.1

found 6.14.1 in filename of file in /nix/store/52s25jxwpd14w3p3m4b9skqc8f91wi8a-xmrig-6.14.1

directory tree listing: https://gist.github.com/99e9150ab6e26163527a9924f66013aa

du listing: https://gist.github.com/6d37920497565da4dba593076f048f32

Rebuild report (if merged into master) (click to expand)

2 total rebuild path(s)

1 package rebuild(s)

1 x86_64-linux rebuild(s)
0 i686-linux rebuild(s)
1 x86_64-darwin rebuild(s)
0 aarch64-linux rebuild(s)

First fifty rebuilds by attrpath
xmrig

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/52s25jxwpd14w3p3m4b9skqc8f91wi8a-xmrig-6.14.1 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A xmrig https://github.com/r-ryantm/nixpkgs/archive/784c5795c0096778974dbafdfacd845b27a16bc2.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/52s25jxwpd14w3p3m4b9skqc8f91wi8a-xmrig-6.14.1
ls -la /nix/store/52s25jxwpd14w3p3m4b9skqc8f91wi8a-xmrig-6.14.1/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

xmrig

Maintainer pings
cc @fpletz @kim0 for testing.

Result of nixpkgs-review pr 135119 at 784c5795 run on x86_64-linux 1

1 package built successfully:

xmrig

2 suggestions:

warning: missing-phase-hooks
installPhase should probably contain runHook preInstall and runHook postInstall.
Near pkgs/applications/misc/xmrig/default.nix:26:3:
   |
26 |   installPhase = ''
   |   ^

warning: missing-patch-comment
Consider adding a comment explaining the purpose of this patch on the line preceeding.
Near pkgs/applications/misc/xmrig/default.nix:21:15:
   |
21 |   patches = [ ./donate-level.patch ];
   |               ^

Result of nixpkgs-review pr 135119 run on x86_64-linux 1

1 package built:

xmrig


Support Firefox

Would it be possible to support this browser as well? If I understand correctly, they should be largely compatible.

While possible, this would require non-trivial changes since ics2gcal currently relies on at least some Chrome-specific APIs, such as chrome.identity. I would certainly support whoever forks ics2gcal and makes it available for Firefox, but I don't think I will get around to doing it myself.

Thanks, I didn't know things are that complex.


Removed total views from the usercard

Pull request checklist:

[x] CHANGELOG.md was updated, if applicable

Description
Twitch removed the 'total views' counter from the channel page, dashboard, and I am certain the number isn't being updated anymore. Some random article showing removal

https://discuss.dev.twitch.tv/t/get-users-api-endpoint-view-count-deprecation/37777

Also consider removing the field from the underlying data models


Upload file to media gallery blank response error 500

Lunar version: 0.8.0
Laravel Version: 10.43.0
PHP Version: 8.2
Database Driver & Version: MySql 8.0.32

Expected Behaviour:
Upload image to product without error.
Actual Behaviour:
When uploading a new image to product there are some images that upload successfully.
However, I have an image of 2.10 MB that give me a blank error. It just throws a livewire black error with no message.

The problem is that the error is very unclear. I checked the laravel.log file and there is no error recorded.
Before this error I had an error regarding the max upload size and I edited my php.ini like so:
post_max_size=20M
upload_max_filesize=20M

After this change, the upload was successed but when I click Save Product, I encounter this error.
Steps To Reproduce:

Fresh install lunar
Upload a file to product gallery larger than 2MB (i supose this is the problem because for smaller files this error is not present)
Save product

Thank you.

Found the issue.
The problem was regarding the memory_limit in php.ini.
If anyone encounter this problem, just change the memory_limit value to 256M or as much as you need it.
Also you have to also increase these post_max_size and upload_max_filesize
My final configuration that works for me is:
post_max_size=20M
upload_max_filesize=20M
memory_limit=256M

Happy codding!


Fix a directory leak when deleting files from bookshelf

From @manderson26 in chef/bookshelf#26

No tests yet, because we don't seem to test deletion at all in bookshelf.
To avoid breaking filesystems with large directory issues, we create a hierarchy of directories to
hold the actual files stored. But we never delete the directories.
This creates a problem, because we potentially create a directory for every file we store in
bookshelf. This can grow pretty large (4 levels deep, with 256 entries per level, so 2^32 + 2^24 +
2^16 + 2^8 > 4 billion). If we never delete them we will blow out the inode table, and consume
considerable disk space. For example ext4 will most likely allocate a full block (default 4KiB) for
each directory we create due to the long file names for the files we store
(https://ext4.wiki.kernel.org/index.php/Ext4_Disk_Layout)

@manderson26 Sorry to revive such an old thread.  This still looks relevant so I looked it over and left a few comments.

@markan Feel free to rebase and reopen this if you are still interested in pursuing it.  I think my code review comments still apply.  Apologies this didn't move forward sooner, but at this point it is pretty old so I think it is best to close it and reopen it when we need it or have time to work on it.


function_exported? is not as reliable as __info__(:functions)

I have some ecto embedded schemas that seems just like structs in all cases except when Maptu calls function_exported?(DB.SQL.Schema.Cart.Loyalty, :__struct__, 0) which returns false. After I instantiate a struct with %DB.SQL.Schema.Cart.Loyalty{} then function_exported?(DB.SQL.Schema.Cart.Loyalty, :__struct__, 0) returns true. However, DB.SQL.Schema.Cart.Loyalty.module_info(:exports) always returns an up to date list of functions.
https://github.com/elixir-lang/elixir/blob/v1.7.3/lib/elixir/lib/kernel.ex#L3245 After reading the documentation for function_exported? It's clear that it doesn't load the code, if it's not already loaded. This makes sense, because it's only happening in my test environment. In any case, I think it would be easier to use Maptu if we can make the change to use module_info or __info__ instead of function_exported?. I'm happy to make a PR, if that would help.

@lexmag Is there something I can do to push this forward? I'd love to get this fix into production.


Additional text property for WebSocketMessage or whatever

Is your feature request related to a problem? Please describe.
Looking at the type declaration of content here
https://github.com/mitmproxy/mitmproxy/blob/b4bd1741eb48971a62b26d366bc6e2768350783e/mitmproxy/websocket.py#L19-L21
I was assuming content would always be of type bytes. However, it is of type str if the opcode is TEXT. The issue lies here
https://github.com/mitmproxy/mitmproxy/blob/70777a1b6ed64af9cafcdef223a8a260ecc96864/mitmproxy/proxy/protocol/websocket.py#L101-L110
I know it's kind of common to do that in a scripting language, but it's also harder to work with.
Describe the solution you'd like
I'm not sure if we should make a breaking change and introduce text similar to how it works with HTTP MessageData? And then keep content for the raw bytes? I'm open for anything, I was just irritated that the type is not consistent.
Describe alternatives you've considered
I'm using gRPC and had the type declared as bytes. I want the raw bytes. I guess I could do the conversion on my end and get the bytes of content if the opcode is TEXT. Working around it is not the issue, but I'd rather have consistency.

I'm not sure if we should make a breaking change and introduce text similar to how it works with HTTP MessageData? And then keep content for the raw bytes? I'm open for anything, I was just irritated that the type is not consistent.

I really haven't looked at this for more than a second, but I remotely recall something about WebSocket TEXT frames having a very strictly defined encoding? It looks like we just forward what we get from wsproto. @Kriechi?
The second much simpler issue is that the type annotation is wrong in any case and needs to be fixed. :)

I really haven't looked at this for more than a second, but I remotely recall something about WebSocket TEXT frames having a very strictly defined encoding? It looks like we just forward what we get from wsproto. @Kriechi?

I think so too (it looks it it's strictly UTF-8) and wasn't implying that we need to do the encoding dance in the text getter/setter. I would be fine with keeping just content the way it currently is. It does make sense since it's either text or binary and not like with HTTP bodies where you don't know for sure sometimes and want to string replace on jpeg meta data or whatever. I was just tired yesterday.

The second much simpler issue is that the type annotation is wrong in any case and needs to be fixed. :)

I think I wouldn't have opened this issue with the correct typing, I was just digging into why gRPC was complaining that it was expecting bytes but received a string. It's all good :+1:


Revert "Emit #[must_use] in Generate new assist"

CC https://github.com/rust-analyzer/rust-analyzer/pull/11737#issuecomment-1079740305

bors r+


Delete comment tooltip overlapping with scrollbar

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

open any chat
hover over a message and then over delete icon

Expected results:
tooltip should not overlap with scrollbar
Actual results:
tooltip overlaps with scrollbar
NOTE : Issue occurs with "Mark as unread" tooltip too in the case of send money  request money
Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[x] MacOS / Chrome / Safari
[ ] MacOS / Desktop

Version Number: <IP_ADDRESS>
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

https://user-images.githubusercontent.com/43996225/235479238-fafc01fe-bb64-471f-9d45-87805a380deb.mp4
Expensify/Expensify Issue URL:
Issue reported by: @chiragxarora
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1682931249368549
View all open jobs on GitHub

Triggered auto assignment to @sophiepintoraetz (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

Bug0 Triage Checklist (Main S/O)

[ ] This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
[ ] This bug is not a duplicate report (check E/App issues and #expensify-bugs)

If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead

[ ] This bug is reproducible using the reproduction steps in the OP. S/O

If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
If the reproduction steps aren't clear and you determine the correct steps, please update the OP.

[ ] This issue is filled out as thoroughly and clearly as possible

Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.

[ ] I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

oh hm i think this may be from a PR I reviewed - https://github.com/Expensify/App/issues/17278 - looking into it now.

@kavimuru where does that scroll bar come from? That's not what I see on Chrome -

I know what line is causing the change, but not sure if it needs fixing.

@kavimuru where does that scroll bar come from? That's not what I see on Chrome -  I know what line is causing the change, but not sure if it needs fixing.

on windows os most likely.

this too

@shawnborton So this is due to switching the gutterWidth. I think without spending a HUGE amount of time on it, we have three options for this:

Keep the original tooltip slight gap between the pointer and the tooltip when at the edge of the screen
Have the pointer be slightly offset from the center of the component it's pointing to when at the edge of the screen
Have the tooltip slightly overlap the scrollbar (gutter) when near enough to it

2 and 3 in particular are mutually exclusive, since the pointer needs a certain amount of tooltip space to its right, and if it's in the center of the component that will push the tooltip too far into the scrollbar.
If it were up to me I'd stick with the change (i.e. 3) and accept a slight overlap, which to me doesn't hugely affect my experience of the app - but I'd love to know what you think.

I would go with option 4 - do nothing. I don't think this is really a bug nor is it worth solving.

Okay cool, I think we're aligned then actually - to clarify:
This bug (overlapping scrollbar) is not worth fixing. (This bug was introduced by fixing the original bug in #17278 - weird gap between tooltip and pointer.) So going with number 3 in my list is keeping the fix for the tooltip/pointer thing, and ignoring the tooltip/scrollbar overlap.
Does that sound right?

I am going to close this as not a bug/issue, but if you disagree with my wrap up @shawnborton lemme know and we can address or reopen. (It shouldn't block deploy in either case.)

Sounds good to me, thanks!


Current project status

Hi, what is the current status of this project? Is it still maintained?

@marcbachmann Might be worthwhile to update Readme.md/archive project, noting project is no longer maintained (presumably shouldn't be maintained either since core dependency, phantomJS is no longer being maintained). Package still gets a fair bit of traffic.
Some alternatives might be worth noting (from npm search engine --optimal flag):

https://www.npmjs.com/package/electron-pdf
https://www.npmjs.com/package/pdf-puppeteer
https://www.npmjs.com/package/prince
https://www.npmjs.com/package/html2pdf.js

Thank you for making this though - html to pdf is still an area of need even in 2020, much less when the project originally put together.

@marcbachmann Can I update the readme file about project status and introduce some alternatives?


Feature: in darkroom, add ability to reset all parameters to their default value on a given module

HI,
I regularly use some module and play with several parameters, until my pictures looks like $h!t ! :-D
I'd love to be able to reset (i.e. re set a value to its default one) all the module parameters with a single click.
Here is a worthless mockup:
Button on the right hand side on the module header would reset all 3 parameters group at once

Thanks
GLLM

Hi @hanatos,

you know that you can reset most individual widgets by double clicking, right? i mean in this case it would be 3x double click which is clearly more work than one click on a reset button though..
Yes, I knew ... still, one click would be nice from a UX perspective ;)

hm to place a button there i'd need to reimplement the expanders (currently these are stock imgui widgets), but it can be done. i wanted to put buttons there anyways (temporarily disable for instance).
oki :-)

Thanks


Not supported encoding format

i tried to make some old configs one of them give me none not supported as an encoding format and i want some help here
picture show the error
https://prnt.sc/10i7v5x
and thanks advance for help

Please add the LoliCode to your message so we can help you better

Please add the LoliCode to your message so we can help you better

and how i can do that  do you mean sharing my config here or what

Go to the LoliCode editor and copy the part of code that's broken

Go to the LoliCode editor and copy the part of code that's broken

its a variable link can i pm you

Please wait for @openbullet as I'm unsure about how he wants such info to be shared

anyway here is all the lolicode and the broken request is the last one cause in response header there is no encoding format
BLOCK:ConstantString
LABEL:kk
value = @input.CODE
=> VAR @kk
ENDBLOCK
BLOCK:HttpRequest
url = $"http://login.qhdtvpro.info/act.php?login="
customHeaders = {("Host", "login.qhdtvpro.info"), ("Connection", "close"), ("Accept-Encoding", "gzip, deflate"), ("User-Agent", "okhttp/3.8.1")}
TYPE:STANDARD
$""
$"application/octet-stream"
ENDBLOCK
BLOCK:Keycheck
banIfNoMatch = False
KEYCHAIN SUCCESS AND
STRINGKEY @data.SOURCE Contains "msg":"Welcome"
STRINGKEY @data.SOURCE Contains ""status":"001"
KEYCHAIN FAIL OR
STRINGKEY @data.SOURCE Contains "msg":"Welcome"
STRINGKEY @data.SOURCE Contains "status":"000""
ENDBLOCK
BLOCK:Parse
input = @data.SOURCE
leftDelim = "status":"001","msg":"Welcome, "
rightDelim = """
caseSensitive = False
MODE:LR
=> CAP @ExpirationMSG
ENDBLOCK
BLOCK:HttpRequest
url = $"http://cdnq.vcdn.tn/iptv/ch30?code="
autoRedirect = False
customHeaders = {("User-Agent", "QHDTV PRO/2.1.9 (Linux;Android 5.1.1) ExoPlayerLib/2.8.1"), ("Accept-Encoding", "gzip, deflate"), ("Host", "cdnq.vcdn.tn"), ("Connection", "close")}
TYPE:STANDARD
$""
$""
ENDBLOCK
BLOCK:Keycheck
KEYCHAIN SUCCESS OR
STRINGKEY @data.HEADERS["Location"] Exists ""
KEYCHAIN FAIL OR
STRINGKEY @data.HEADERS["Location"] DoesNotExist ""
ENDBLOCK
BLOCK:Parse
input = @data.HEADERS["Location"]
MODE:LR
=> VAR @link1
ENDBLOCK
BLOCK:Parse
input = @data.HEADERS["Location"]
leftDelim = "http://"
rightDelim = "/"
MODE:LR
=> VAR @host
ENDBLOCK
BLOCK:HttpRequest
url = $""
autoRedirect = False
securityProtocol = TLS13
customHeaders = ${("User-Agent", "QHDTV PRO/2.1.9 (Linux;Android 5.1.1) ExoPlayerLib/2.8.1"), ("Host", "")}
TYPE:STANDARD
$""
$"application/octet-stream"
ENDBLOCK

User blocked for posting illegal content


Fix null issue when publishing an event and no handlers have been registered

thank you!
available in v5.2.0-beta18


[apply-login-partner-changes] - Mentor Calendar Availability and previous calendar events completed, upcoming not shown

Describe the bug
Mentor users not able to see calendar to setup availability, and not able to see past events in calendar
To Reproduce
Steps to reproduce the behavior:

Go to login, enter<EMAIL_ADDRESS>/ pass123
Click on Mentor button
Go to main portal view, click Availability
See error calendar is greyed out

Expected behavior
User must be able to setup the calendar availability, this is an existing feature
User must be albe to see past events and upcoming events too.
Screenshots

@robert-dm  done

ok


fix: height fixes to render pipeline view

Renders pipeline view which was invisible due to styling issues

@yhl25 - please review and release v1.2.1.

Just about to report this, works fine with v1.2.1.


In-App Donations

:gift: In-App Donations
Allow users to donate to make In-App donations. Donations should not be in lieu of additional features.

Using Google Play's InAppBillingAPI V3 for implementing In-App Donations.

Added donations of three sizes as below.
:chocolate_bar: , :ice_cream: :bread:


Added Pose3 pybind11 interface

Signed-off-by: ahcorde<EMAIL_ADDRESS>🎉 New feature
Summary
This PR creates a Pose3 Pybind11 interface
Checklist

[x] Signed all commits for DCO
[x] Added tests
[ ] Added example and/or tutorial
[ ] Updated documentation (as needed)
[ ] Updated migration guide (as needed)
[x] codecheck passed (See contributing)
[x] All tests passed (See test coverage)
[x] While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

This pull request has been mentioned on Gazebo Community. There might be relevant details there:
https://community.gazebosim.org/t/new-ignition-releases-2022-03-01-citadel-edifice-fortress/1313/1


Upgrade Quickstart Python Scripts to Python 3

Description
Currently the quickstart scripts are using Python 2. For example, this syntax in the post-index-task-main script, is using Python 2 syntax. These scripts should be upgraded to Python 3.

I believe this has been addressed by https://github.com/apache/druid/pull/12841


Neuroscope: fix scale of signals.

Need to multiply not divide by 1000 for mV scale.

Do you have some documentation or some example traces? This seems reasonable, but it would be nice to know where the scale is coming from.

The only thing this corrects is the scaling factor applied to convert to mV from the raw samples. There is nothing in the .dat files. The corresponding .xml files contain the voltage range, number of bits for each sample, and amplification. There is nothing per se in those files which says it is mV.
I can tell you however that with the correction the other way, as before this change, the recordings are being shown as in the 100 nV range, which makes no sense for neurophysiological signals.
This is a common mistake and I have done it myself many times - dividing instead of multiplying by the amplification.
This change also includes a comment which clearly explains the derivation of the scale.

Since @samuelgarcia wrote this I put him to review it. My only suggestion would be to move the comment into the actual class rather than in the test so that future us see it there :)

OK. I added a comment in the source and clarified that this is the proper scale to convert a raw sample value to mV.

Oups.
Yes it was a mistake. Thanks for the catch.

OK. Can we get this reviewed and merged? I don't like keeping these branches open unnecessarily on my fork. Thanks.


FMX Mobile support?

Do you have a plan of fmx mobile support? ios and anroid. thank you!

Do you have a plan of websocket? thank you!

Do you have a plan of fmx mobile support? ios and anroid. thank you!
There are no such plans. This is a server framework. In general, I have not tried to build anything for mobile platforms.

Do you have a plan of websocket? thank you!

Web sockets are in the plans. But I have no feedback on how good the HTTP client model is. On top of it, i can develop  a web socket client. WebSocket Server is in the plans.


modify rate to irate in grafana dashboards

This allows us to identify more precisely in time when the system behavior changes.

LGTM, added to the commit comment and the description "why" we did the change.


Add standard representation for CharSequence

Currently CharSequence has no special handling in StandardRepresentation, so when you accidentally compare a String with for example a StringBuilder you get something like:

expected: test
but was: "test"

This assumes that for custom CharSequence types users have overridden toString, as required by the CharSequence Javadoc. Otherwise it might be a bit confusing that the result is now enclosed in ".
Check List:

Fixes #??? (ignore if not applicable)
Unit tests : YES
Javadoc with a code example (on API only) : NA
PR meets the contributing guidelines

Following the contributing guidelines will make it easier for us to review and accept your PR.

Integrated thanks @Marcono1234 !


[i2c,dv] Update testplan for MCTP/SMBus M4 features

Description

@hcallahan-lowrisc Please complete the PR based on Alex's feedback so we can close this

@hcallahan-lowrisc Please complete the PR based on Alex's feedback so we can close this

PR is now complete pending review.


Notary verification should fail if image has no signature

Currently If you have notary set up with a cert, verification passes if an image only has an SBOM.
The expectation is, if notary is configured with a cert, all images should have to have at least one signature.

Note: this can only be accomplished within Ratify if execution pass through mode is NOT enabled.
Currently, the config policy provider already supports this scenario if configured correctly. If the notation verifier is setup with certs but we do NOT encounter any notation signatures during execution, this will not return a failed verification result by default. If we want to add this policy, we need to add the "any" (or "all") in the artifactVerificationPolicies map.
Example config change:
"policy": {
        "version": "1.0.0",
        "plugin": {
            "name": "configPolicy",
            "artifactVerificationPolicies": {
                "application/vnd.cncf.notary.v2.signature": "any"
            }
        }
    },

Verified that policy works properly and return expected behavior


Automatically fix the whole repo

How can we automatically fix the whole repo ?
Because every time i commit it fixes the whole file, and Its difficult to find the changes that i made.
Is there any way we can do it all in once for the whole folder ?


Academic programs import

Coverage remained the same at 90.412% when pulling 678fdb98148eb2bbdcdee1a11d3c64202c79c904 on academic-programs-import into 9d8fd791a717474a693526b5342fb6538b97f9be on master.


added ReviewImageFragment Unittest

Description (required)
Added ReviewImageFragment Unittest
What changes did you make and why?
Added ReviewImageFragment Unittest

@madhurgupta10 All test in ReviewImageFragmentsTest is passed when i run it in  android Studio but in pull request it show Travis cl build failed

@madhurgupta10 All test in ReviewImageFragmentsTest is passed when i run it in android Studio but in pull request it show Travis cl build failed

Here are the tests which are not passed on Travis, did you try to run our tests with all other tests together?
fr.free.nrw.commons.review.ReviewImageFragmentTest > testOnYesButtonClicked FAILED
    java.lang.Exception at AndroidTestEnvironment.java:502
        Caused by: java.lang.IllegalStateException at ReviewImageFragmentTest.kt:124

fr.free.nrw.commons.review.ReviewImageFragmentTest > testOnUpdateCategoriesQuestion FAILED
    java.lang.Exception at AndroidTestEnvironment.java:502
        Caused by: java.lang.reflect.InvocationTargetException at ReviewImageFragmentTest.kt:112
            Caused by: java.lang.IllegalStateException at ReviewImageFragmentTest.kt:112

fr.free.nrw.commons.review.ReviewImageFragmentTest > testOnGetReviewActivity FAILED
    java.lang.Exception at AndroidTestEnvironment.java:502
        Caused by: java.lang.reflect.InvocationTargetException at ReviewImageFragmentTest.kt:141
            Caused by: java.lang.IllegalStateException at ReviewImageFragmentTest.kt:141

649 tests completed, 3 failed, 2 skipped

@madhurgupta10  i do not run all test of reviewImageFrament with  other all   tests together

@madhurgupta10 i do not run all test of reviewImageFrament with other all tests together

Can you try it locally if all tests are passed along with your new tests? Also can you post a screenshot of code coverage so that we can see lines hit/miss?

@madhurgupta10 how i run all the unit test  together i do search but not found correct solution ?

@madhurgupta10 how i run all the unit test together i do search but not found correct solution ?

You can right-click on test folder and run

@madhurgupta10 i already try the above method this method output is in below image

@madhurgupta10 In my android studio on right-click on test

@Prince-kushwaha can you share a screenshot of your configuration file?

Codecov Report

Merging #4413 (da58f19) into master (4b7e75c) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #4413   +/-   ##
=========================================
  Coverage     10.38%   10.38%
  Complexity      479      479
=========================================
  Files           342      342
  Lines         13154    13154
  Branches       1076     1074    -2
=========================================
  Hits           1366     1366
  Misses        11719    11719
  Partials         69       69

Impacted Files
Coverage Δ
Complexity Δ

...e/nrw/commons/upload/UploadMediaDetailAdapter.java
0.00% <0.00%> (ø)
0.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b7e75c...da58f19. Read the comment docs.

@Prince-kushwaha can you post a screenshot of code coverage for this file so that we can see lines hit/miss?

@madhurgupta10 thanks for help
code coverage

@madhurgupta10 thanks for help
code coverage

You can export this report and open the ReviewImageFragment to see lines miss/hit and take a screenshot, current tests only cover 26% of lines for this class, it would be great if it can be around 70-80%

@madhurgupta10 can i shift all the selected code in new function show that it is easy to write unit test for it ?

@madhurgupta10 can i shift all the selected code in new function show that it is easy to write unit test for it ?

We should try to write unit tests without refactoring the code unless it is absolutely necessary, in this case, I don't see why refactoring is needed? You can different tests for each case in the switch statement, use when-then  to mock position

@madhurgupta10 shift all the selected code in new function is absolutely necessary becouse i try to test
@Override     public View onCreateView(LayoutInflater inflater, ViewGroup container,                              Bundle savedInstanceState) {

it give error java.lang.NullPointerException: Layout parameters cannot be null and we do not change the  value of position        position = getArguments().getInt("position");

@madhurgupta10 shift all the selected code in new function is absolutely necessary becouse i try to test
@Override public View onCreateView(LayoutInflater inflater, ViewGroup container, Bundle savedInstanceState) {

it give error java.lang.NullPointerException: Layout parameters cannot be null and we do not change the value of position  position = getArguments().getInt("position");

@Prince-kushwaha You should set your layoutInflater in setUp()

@madhurgupta10 i try this solution but it not work https://github.com/commons-app/apps-android-commons/pull/4413#issuecomment-841764644 i have  to refactoring the code

@Prince-kushwaha Sorry for super late reply, I missed notification for this PR.
Here is what you can do to test the onCreateView method
@Test
@Throws(Exception::class)
fun testOnCreateView() {
    fragment.onCreateView(layoutInflater, null, savedInstanceState)
}

In your setUp() method initialize the layout inflater like this
layoutInflater = LayoutInflater.from(activity)

You need to replace the getString() method in onCreateView with layoutView.getContext().getString() in order for the tests to run without being attached to context

@madhurgupta10 we have position = getArguments().getInt("position"); in onCreateView Method so we not have to use
layoutView.getContext().getString()

@madhurgupta10 we have position = getArguments().getInt("position"); in onCreateView Method so we not have to use
layoutView.getContext().getString()

I haven't tried it but if changing getString() to layoutView.getContext().getString() is not needed then it is much better.

Hey @Prince-kushwaha , thanks a lot for the PR:) Are there any updates after @madhurgupta10 's reviews?

@neslihanturan It seems like the author isn't active on this PR, we can still merge it and if @Prince-kushwaha want to continue working on the suggested changes, can create a new PR :)

Thanks @madhurgupta10 and @Prince-kushwaha then :)


Java core tests fails on windows

Tests which fails on windows.
During development test suite which run java unit tests on windows (BEAM-10682) they appear to fail.
Those tests have comment with this Jira issue (introduced in PR mentioned above).
I didn't solve by myself them since I am not so much familiar with java and Beam logic so I didn't want just makes tests green which could hide potentially real issue.

Imported from Jira BEAM-10683. Original Jira may contain additional context.
Reported by: TobKed.

The following subtask(s) are associated with this issue: #20460, #20461, #20462, #20463, #20464, #20465, #20466, #20467, #20468, #20469, #20470, #20471, #20472, #20473, #20474, #20475, #20476, #20477, #20478, #20479, #20480, #20481, #20482, #20483, #20484, #20485


Get an example running with Azure Service Fabric

It should be possible to use Azure Service Fabric for hosting services instead of TopShelf Windows Services and IIS hosted APIs. I'm going to do a proof of concept, for part of an upcoming Microservices talk.

@dstockhammer now has his

Is this done yet?

No, not really. I've been playing around with Azure Functions and I think that environment is superior to Service Fabric for our needs. However there's a lot of churn with VS Function tools at the moment so that I've decided to wait until a VS 2017 version is available. See https://github.com/Azure/Azure-Functions/issues/201

ok


Time zone has the sign in the middle

Reported by Zac West via Twitter: https://twitter.com/zacwest/status/423243320626651136
STR welcome.

Any chance that this fix will ever be released to cocoapods?

That's up to @iOSCowboy. If you want to submit a pull request, I'd be willing to merge it in.

I think it has already been merged. There is no difference when i compare the branches for PR.

Oh, you're right! I merged this in [90f6cf0]. Sorry for the noise.
So, yeah, this will be in all future releases.

Any chance you'd consider publishing a podspec with this fix?


Feature: Added ClusterName into AuditLog event

Description
Some companies may have more than one StarRocks Cluster, And for manage StarRocks
Metadata, normally have this kind of link, report StarRocks metadata onto one metadata management
centre, So need identify the data coms from which StarRocks clusters
Solution
Added one more filed StarRocks cluster name into AuditLogEvent
What type of PR is this:

[ ✅] Feature

Checklist:

[ ] I have added test cases for my bug fix or my new feature
[ ] This pr will affect users' behaviors
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Teng Ma seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

[FE PR Coverage Check]
:heart_eyes: pass : 5 / 6 (83.33%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/scheduler/SqlTaskRunProcessor.java
0
1
00.00%
[36]

:large_blue_circle:
com/starrocks/scheduler/PartitionBasedMaterializedViewRefreshProcessor.java
1
1
100.00%
[]

:large_blue_circle:
com/starrocks/plugin/AuditEvent.java
3
3
100.00%
[]

:large_blue_circle:
com/starrocks/qe/ConnectProcessor.java
1
1
100.00%
[]

com/starrocks/scheduler/SqlTaskRunProcessor.java

Hi master, can you  help review it PR , thx


Add tile Label option

It would be great to be able to add labels to tiles for rotational information. Obvious one is labeling the Zulrah tiles with the position #s. Or label a tile in a row 'Multi' to remind yourself that it is multi beyond that location. Or Label the ground at EVERY bank 'Bring Spade'

I think #3395 solves this just fine?

@deathbeam great thank you, I will track it


No debug on F10/F11 works in reverse

When the "No debug on F10/F11" is set to True, F10 starts the debug (also F11).
When is set to False the F10/F11 keys do nothing.

Thanks!
I changed the name of the setting to match the boolean value. Now it makes sense again 👍


How to handle termination of subscription in relation to notification API?

Problem description
In the relation to the common notification API issues#8
Subscribe/notify API pattern puts API client in a passive role – it has subscribed and expects being notified when something happens (SimSwap for given MSISDN, device leaves a location etc).
However,  the subscriber owning given MSISDN (or a device) can terminate their contract or move to another MNO keeping their MSISDN
MNO must inform API client about this event as well, to allow it to act accordingly.
Possible evolution
One can suggest at least 2 approaches to solve this:
Each Camara API is obligated to inform their clients about contract termination using its notification channel (use same end point as it uses for “regular” notifications)
A centralized API to be introduced which an application provider should use to be informed about significant changes related to MSISDNs and devices (contract terminated/suspended/resumed/moved etc)
Since a common approach is selected, all Camara APIs must use it.

Thanks @gregory1g for raising this.
To add a clarification, as of now our pattern follow the first approach mentioned

Each Camara API is obligated to inform their clients about contract termination using its notification channel (use same end point as it uses for “regular” notifications)

@gregory1g As the guidelines was updated (and merged) with above pattern are you fine if I close the issue?

@bigludo7 , yes.

Closing as agreed.


Clarify/refactor handling of duplicate elements in ConfigSchemas

User Story
As a RS developer, I want clarity on what the expected behavior should be when multiple elements (either nested or not) exist with the same name in a config schema.
Description/Use Case
ConfigSchema has a property called duplicateElements which is used to enforce a requirement that multiple elements don't exist with the same name. This ticket aims to investigate the need for this restriction, and ensure that errors are thrown consistently between tests (like test transform with nested schemas in FhirTransformerTests and test convert in FhirToHl7ConverterTests) and the running application using real schemas.
Risks/Impacts/Considerations
We should be careful to consider reasons to keep some kind of restriction here, we don't want to open the possibility of something that causes unwanted behavior.
Dev Notes
We should also consider refactoring the duplicate element checking in FhirTransformer.transform and FhirToHl7Converter.convert to reduce duplicate code and make it easier to debug.
Acceptance Criteria

[ ] The need for duplicate element restrictions has been assessed
[ ] Any tests that trigger error conditions for duplicate elements can also be replicated by a running server
[ ] Behavior has been documented (either in the docs, or by comments on tickets related to documenting these schemas #10215)

Hey team! Please add your planning poker estimate with Zenhub @arnejduranovic @jack-h-wang @JessicaWNava @JFU-NAVA-PBC @jimmyfagan @luis-pabon-tf @mkalish @thetaurean

These tickets are thematically related and may be worth looking at for reasoning of duplicate handling in some places:
#7245 and #6139

Good finds @luis-pabon-tf ! In the PR comments here, Michael pointed out that overriding multiple elements with a single override was useful for the purposes of that ticket. These schemas and nested schemas and overrides and extensions are all confusing, so it might be that these are considered to be separate concepts or something, but anyway, hopefully this and other related tickets can get into all of that and also document more about how this actually works.


CirclePicker width is calculated in a wrong way

With this setup:
<Pane
            padding={12}
            display="flex"
            alignItems="center"
            justifyContent="center"
            flexDirection="column"
            position={Position.TOP_LEFT}
            >
            <CirclePicker
              colors={[
                "#ff3722", "#9c27b0", "#3f51b5", "#4caf50", "#ffeb3b", "#795548", "#607d8b"
                ]}
              circleSpacing={12}
              circleSize={20}
            />
          </Pane>

we have

If we comment CirclePicker width out:

we get it right:

Any way we could disable width calculation?
@casesandberg

🤦♂ fool me, need to better read docs.


Use kingpin.v2 to build up CLI utility interfaces

The default flag package isn't the nicest. While playing around with the tools, I rebuilt zkctl to use the kingpin flag package instead for it's CLI interface to make it easier to use and document what it was doing. Should this PR'd?

Not opposed to better cli library, but can this use cobra instead, since that's what etcd uses?


How to add additional claims to the token?

Services often need to add their own claims to tokens to manage what users are allowed to do in a system. OIDC providers like Okta, Auth0, and others allow their users to add claims via configuration and integrations to support this. How can this be done with mockoidc? One can decode the access token to get the claims.
I tried building a custom user object:
type myUserObject struct {
    mockoidc.MockUser
    PhoneVerified bool
}

with the Claims() method adding the additional data to the jwt.Claims, but I still only get the original data - nothing in the way of the custom claims I added.
What am I missing?

I created my own jsonClaims type that JSON encodes all the fields based on mockoidc's mockClaims type which adds the additional field which is what is used by my implementation of Claims().

PR #54 has some example code that exemplifies the behavior in a similar pattern to how I was doing it in my other code. The PR creates a custom user with a new attribute (PhoneVerified) and then adds a test to the session to get a token with the custom user type and checks for the attribute being in the claims as one would expect.  The new test presently fails.

I stumbled over the same, would be nice to have easier way adding new claims.


Recent change to PyQTgraph plotting API breaks plotting with units

I just merged QCoDeS master into our fork of QCoDeS and found that it breaks our live plotting.
I'll try to go to 0.1.7 now so that I have recent changes that I require.
Digging a bit deeper it seems that this is related to a change introduced by 35400a60448101c66337d9b3373b9af1c9666725
I have attached the relevant part of my traceback pointing to the problem.
I'll also add the relevant lines of codes with a bit more context below.
d:\githubrepos\pycqed_py3\pycqed\measurement\measurement_control.py in measure(self, *kw)
    171     def measure(self, *kw):
    172         if self.live_plot_enabled():
--> 173             self.initialize_plot_monitor()
    174
    175         for sweep_function in self.sweep_functions:

d:\githubrepos\pycqed_py3\pycqed\measurement\measurement_control.py in initialize_plot_monitor(self)
    570                                      subplot=j+1,
    571                                      color=color_cycle[j % len(color_cycle)],
--> 572                                      symbol='o', symbolSize=5)
    573                 self.curves.append(self.main_QtPlot.traces[-1])
    574                 j += 1

d:\githubrepos\qcodes\qcodes\plots\base.py in add(self, updater, *args, **kwargs)
     89         # TODO(giulioungaretti): replace with an explicit version, see expand trace
     90         self.expand_trace(args, kwargs)
---> 91         self.add_to_plot(**kwargs)
     92         self.add_updater(updater, kwargs)
     93

d:\githubrepos\qcodes\qcodes\plots\pyqtgraph.py in add_to_plot(self, subplot, **kwargs)
    147         if prev_default_title == self.win.windowTitle():
    148             self.win.setWindowTitle(self.get_default_title())
--> 149         self.fixUnitScaling()
    150
    151     def _draw_plot(self, subplot_object, y, x=None, color=None, width=None,

d:\githubrepos\qcodes\qcodes\plots\pyqtgraph.py in fixUnitScaling(self, startranges)
    528             for axis in ('x', 'y', 'z'):
    529                 if self.traces[i]['config'].get(axis):
--> 530                     unit = self.traces[i]['config'][axis].unit
    531                     if unit not in standardunits:
    532                         if axis in ('x', 'y'):

AttributeError: 'list' object has no attribute 'unit'

This is the method that hits the offending line when adding a plot.
    def initialize_plot_monitor(self):
        # new code
        if self.main_QtPlot.traces != []:
            self.main_QtPlot.clear()
        self.curves = []
        xlabels = self.sweep_par_names
        xunits = self.sweep_par_units
        ylabels = self.detector_function.value_names
        yunits = self.detector_function.value_units

        j = 0
        if (self._persist_ylabs == ylabels and
                self._persist_xlabs == xlabels) and self.persist_mode():
            persist = True
        else:
            persist = False
        for yi, ylab in enumerate(ylabels):
            for xi, xlab in enumerate(xlabels):
                if persist:  # plotting persist first so new data on top
                    yp = self._persist_dat[
                        :, yi+len(self.sweep_function_names)]
                    xp = self._persist_dat[:, xi]
                    if len(xp) < self.plotting_max_pts():
                        self.main_QtPlot.add(x=xp, y=yp,
                                             subplot=j+1,
                                             color=0.75,  # a grayscale value
                                             symbol='o', symbolSize=5)
                self.main_QtPlot.add(x=[0], y=[0],
                                     xlabel=xlab,
                                     xunit=xunits[xi],
                                     ylabel=ylab,
                                     yunit=yunits[yi],
                                     subplot=j+1,
                                     color=color_cycle[j % len(color_cycle)],
                                     symbol='o', symbolSize=5)
                self.curves.append(self.main_QtPlot.traces[-1])
                j += 1
            self.main_QtPlot.win.nextRow()

For reference self.main_QtPlot is below. from qcodes.plots.pyqtgraph import QtPlot
            self.main_QtPlot = QtPlot(
                window_title='Main plotmon of {}'.format(self.name),
                figsize=(600, 400))

It's hard for us to have visibility on how you are using qcodes in your fork but in this case I guess we should just replace that line with a get and skip the rescaling if no unit is set

Hi @jenshnielsen it may be a bit hard to see but the error is actually raised on the line where I am most definitely setting units (block slightly lower in the snippet I pasted). So I'm not sure what causes this. AFAIK I'm using the default API of the Qt_Plot object so I would expect this to work but it broke somehow. If your proposed solution solves the problem I'd be quite happy with it, I think not rescaling if it is not SI would make a lot of sense (and the other changes that were introduced).
Also I just merged 0.1.7 and the speed increase (#712 ) when setting up a plot is very noticable, I would not have found that! :+1: .

I think #770 will do the trick can you test that

Is your version online somewhere so I can test it. The issue behind #712 is really odd I have not had the time to dive into pyqt/qt to understand what happens

@jenshnielsen Let me try #770 . Our version is online at https://github.com/DiCarloLab-Delft/Qcodes.
I'll be going to a talk in 5 mins but let me try before that.
Also I think this behaviour is testable quite easy. I have Travis compatible tests set up for a lot of things involving the live plotting, if you want I can show you how we do it.

So far as I understand from the discussion, PR #805 fixed this, and it's merged, so I am closing this issue.


changefeed (ticdc): remove error state and add pending, warning state

What problem does this PR solve?

Issue Number: ref #9273
What is changed and how it works?
Check List
Tests

Unit test
Integration test

Questions
Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?
Release note
Please refer to [Release Notes Language Style Guide](https://pingcap.github.io/tidb-dev-guide/contribute-to-tidb/release-notes-style-guide.html) to write a quality release note.

If you don't think this PR needs a release note then fill it with `None`.

/test all

/test all

/test cdc-integration-mysql-test

/test all

/test all

/test all

/test verify

/test dm-integration-test


[19.03 backport] Entropy cannot be saved

backport of https://github.com/moby/moby/pull/39336 for 19.03
Remove non cryptographic randomness.

ping @justincormack @cpuguy83 ptal


Add query syntax to the test-client

Add query syntax to the test-client

Press the 'ENTER' key to continue
Ask to try to deploy a single Kubernetes cluster across multi-clouds
Add MCIS clean-up
Ask to clean up MCIS

It's getting to be a demo-client 😅

@seokho-son, thank you for your comments ^^


Provide Arch AUR package

@vyp
To alleviate some of the discussion from #20 I've started this issue.
I've uploaded a rust-beta-bin package to the AUR which you can use in your makedepends array since we're targeting stable Rust (even though clog should also build just fine with nightly). This provides cargo and rust so you won't need to specify those as a make-dep any more.

Wow, awesome! I just installed it and it works. So thanks so much, because I'll be using this until the stable release. :)
And I updated clog-git. I think this issue can serve as discussion place for the AUR package if the need arises. But I have no problems with closing it if you want to, because it's not really an 'issue' (we still get notifications for messages on closed issues right?).

Yep we'll still get notified even if its closed :) and we can always reopen it if needed.


Add multiplayer extension

This initial PR just adds Richard's multiplayer blocks, with some re-namespacing so that they extend existing toolbox categories rather than collect into a Multiplayer category. It does also introduce a Multiplayer category for blocks that didn't fit nicely anywhere else.
In a future PR, I will:

Add game over blocks
Add countdown block
Add blocks for setting presence bar icon

ping... this needs review.

I see blocks being added to all different categories. I am not sure how user will know these blocks will be added to the categories.  May be add them all to the "Multiplayer" category or at both locations? Usually, students will look into the new category which is added.

I see blocks being added to all different categories. I am not sure how user will know these blocks will be added to the categories. May be add them all to the "Multiplayer" category or at both locations? Usually, students will look into the new category which is added.

Multiplayer is a feature, not a category itself. It spans all the categories. I see the discoverability problem you're highlighting, but putting all these blocks in a single category has arguably greater discoverability issues. When a user wants to find the set player-1 sprite to mySprite block, where do you imagine them looking first: in Sprites? or Multiplayer? Adding all these blocks to a single category would result in a monstrously long scrolling toolbox drawer.

Is it possible to add a block in two locations?

I don't think it is possible without a separate shim Api.
I am ok adding in the current way and test with the user. First place I looked for the new blocks is multiplayer category and saw only few blocks and wondered where the rest of the stuff. 99% extensions add only blocks to single category and user is likely trained to expect that.

When a user wants to find the set player-1 sprite to mySprite block, where do you imagine them looking first: in Sprites? or Multiplayer?

I don't know. It is good to test this as well.


docs: walkthroughs on specific items

There are many things that I was searching for in the docs, for example how a contract handles coins and how it can handle multiple accounts/coins and cross contract interactions. Reading through cosmwasm-plus I found the answer, but it took me a bit of reading the docs before going to the code. Having some walkthroughs of the cosmwasm-plus code or specific take aways for how to do specific things would be greatly beneficial.

Thanks!
Yes you are absolutely right. Planning a documentation overwrite with 1.0 version. I assure you, there will be modular learning content.


Improve examples

Makes the examples a bit more Windows-ey
Improves some of the Python idioms

@zooba : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Ping @mattwojo

Thanks @zooba !


Decision Maker Persona - Social Tasks

Brainstorming some ideas:

Networking with key public stakeholders
PR with those in the public who want to get involved
Directing or creating a funnel to move people to the right places in the project


Interactive command

I really need this feature, but it doesn't seem to fit declaratively
like click.prompt() or click.confirm()

Would this work? https://cappa.readthedocs.io/en/latest/rich.html#prompt-confirm
At current moment, i believe it only operates as a default for missing values

Geez, I admit I overlooked the documentation here, I'll try it later

Rich is working fine.


Add targets in Windows OneCore target for making building libraries for Windows Store apps easier.

It is based on the effort of https://github.com/openssl/openssl/pull/7729.
I have merged the changes mentioned by https://github.com/openssl/openssl/pull/7729#issuecomment-448957705 and adapt them to the new codebase because of https://github.com/openssl/openssl/pull/8622.
New targets which I have added

VC-WIN32-UWP
VC-WIN64A-UWP
VC-WIN32-ARM-UWP
VC-WIN64-ARM-UWP

Usage example
perl Configure VC-WIN64A-UWP no-asm no-uplink
nmake build_libs

File list in the build folder
E:\Projects\openssl\build>dir
 Volume in drive E is Workspace
 Volume Serial Number is 488C-764C

 Directory of E:\Projects\openssl\build

2019/05/12  05:05    <DIR>          .
2019/05/12  05:05    <DIR>          ..
2019/05/12  05:05    <DIR>          apps
2019/05/12  04:57           610,074 configdata.pm
2019/05/12  05:03    <DIR>          crypto
2019/05/12  04:57    <DIR>          doc
2019/05/12  04:57    <DIR>          engines
2019/05/12  05:05    <DIR>          fuzz
2019/05/12  04:57    <DIR>          include
2019/05/12  05:01         3,001,856 libcrypto-3.dll
2019/05/12  05:01         9,302,736 libcrypto-3.ilk
2019/05/12  05:01         9,973,760 libcrypto-3.pdb
2019/05/12  05:01               932 libcrypto-shlib-libcrypto.res
2019/05/12  05:01           111,773 libcrypto.def
2019/05/12  05:01           598,444 libcrypto.exp
2019/05/12  05:01         1,004,258 libcrypto.lib
2019/05/12  05:01             1,186 libcrypto.rc
2019/05/12  05:04        17,444,478 libcrypto_static.lib
2019/05/12  05:05           677,376 libssl-3.dll
2019/05/12  05:05         3,223,792 libssl-3.ilk
2019/05/12  05:05         2,355,200 libssl-3.pdb
2019/05/12  05:04               924 libssl-shlib-libssl.res
2019/05/12  05:05            14,119 libssl.def
2019/05/12  05:05            72,033 libssl.exp
2019/05/12  05:05           119,622 libssl.lib
2019/05/12  05:04             1,180 libssl.rc
2019/05/12  05:05         3,529,178 libssl_static.lib
2019/05/12  04:57         1,430,429 makefile
2019/05/12  05:05         1,093,632 ossl_static.pdb
2019/05/12  04:57    <DIR>          providers
2019/05/12  05:05    <DIR>          ssl
2019/05/12  05:05    <DIR>          test
2019/05/12  04:57    <DIR>          tools
2019/05/12  04:57    <DIR>          util
              21 File(s)     54,566,982 bytes
              13 Dir(s)  25,465,364,480 bytes free

Kenji Mouri

I'm much more positive than I was in #7729, for various reasons...  I've learned some along the way, and the idea of this change has grown on me.  I'm sorry for having tested your patience in the process.

Side thing: I wonder if Appveyor has what's needed to support UWP.  We might want to consider adding a build that tries that.  I would say that's for another PR, though.

Side thing: I wonder if Appveyor has what's needed to support UWP.  We might want to consider adding a build that tries that.  I would say that's for another PR, though.

My UWP app project uses AppVeyor. It uses Visual Studio 2017 or 2019 image.
When I build FFmpeg lib for UWP, I have written these code and hope it helps you.
@setlocal EnableDelayedExpansion
@echo off

set VisualStudioInstallerFolder="%ProgramFiles(x86)%\Microsoft Visual Studio\Installer"
if %PROCESSOR_ARCHITECTURE%==x86 set VisualStudioInstallerFolder="%ProgramFiles%\Microsoft Visual Studio\Installer"

pushd %VisualStudioInstallerFolder%
for /f "usebackq tokens=*" %%i in (`vswhere -latest -products * -requires Microsoft.VisualStudio.Component.VC.Tools.x86.x64 -property installationPath`) do (
  set VisualStudioInstallDir=%%i
)
popd

if %1==x86 set VisualStudioToolKitType=x86
if %1==x64 set VisualStudioToolKitType=x86_amd64
if %1==ARM set VisualStudioToolKitType=x86_arm
if %1==ARM64  set VisualStudioToolKitType=x86_arm64

call "%VisualStudioInstallDir%\VC\Auxiliary\Build\vcvarsall.bat" %VisualStudioToolKitType% uwp

Kenji Mouri

I like what I see.  However, I'd like to do a verification build, and I can't for about a week, so I hope you don't mind 'til then for a final approval from me.
Of course, this doesn't stop anyone else from @openssl to look and review...

I like what I see.  However, I'd like to do a verification build, and I can't for about a week, so I hope you don't mind 'til then for a final approval from me.
Of course, this doesn't stop anyone else from @openssl to look and review...

Got it. I am looking forward to hearing from you.
Kenji Mouri

@levitte any update on this?
Thanks

Any news? @levitte

Thanks for the reminder.
Incidently, I stumbled on this earlier this morning, and am trying to decide if that makes this effort futile or not.  Any comments on that?

@levitte
I don't think this PR is useless. It can also help developers even the UWP app dead.
Everyone knows, Microsoft provide a way to use Windows Runtime XAML called XAML Island. It may be the future of the Windows application development.
We also know, there are some apps uses or will use XAML Island. For example, the Windows Terminal app which is open source from Microsoft.
If you read the source code of the Windows Terminal app, you will know it has two parts: Win32 app (in the form of exe) and UWP app (in the form of dll but renamed by exe). Win32 exe uses XAML Island to load the UWP dll.
In general, if we want to develop a app which uses Windows Runtime XAML today. We still need to create an UWP app project. (There is no XAML designer for non UWP C++ projects today.)
If I want to use the Windows Runtime XAML with the XAML Island for developing an app with modern app experience (touch and pen device),  I need to write two parts. If I can use the OpenSSL in the uwp part smoothly and integrate with Windows Runtime sockets easily, I won't choose the XAML Island.
I'm sure that when more developers touch the XAML Island, they'll agree with me.
So Microsoft has been forcing developers to touch the UWP app development. (In Linus way: "F**k you, Microsoft.)"
I am not good at English but I hope you can know my meaning.
Thanks.
Kenji Mouri.

@levitte
For more information about the XAML Island:
https://docs.microsoft.com/en-us/windows/apps/desktop/modernize/xaml-islands
https://github.com/marb2000/XamlIslands/tree/master/19H1_Insider_Samples/CppWin32App_With_Island
Kenji Mouri
Hope it can help you to understand me.

UWP is still important for upcoming platforms like the HoloLens 2, where it is a hard requirement.

@levitte it's taking more time just to have this debate than what it would take you to review the changes and run those tests you mentioned 20 days ago...
Can you please do it and we can the rest of us use it for other projects?
There are a lot of projects that are waiting on this.
Thanks

There's a non-technical problem with this PR.  It's been marked as "trivial", and while I understand that it's technically a fairly trivial thing, the "trivial" marker isn't about how easy or hard the work was, but about copyright, and what can pass as non-copyrightable.  I very much doubt that this work can be seen as such.
@openssl/omc, second opinion, please?

The solution to the triviality problem is, of course, to submit a signed CLA

This is the first time that you bring this problem up. Either is trivial or
not, please say so and it will be treated as necessary.
It seems that this is a never ending PR and that there is always an excuse
to move on with it.
You mentioned in the past that you tested the patience of everyone with
this PR (and the original one). You sure are.
Regards
On Sun, Jun 2, 2019, 7:08 PM Richard Levitte<EMAIL_ADDRESS>wrote:

The solution to the triviality problem is, of course, to submit a signed
CLA https://www.openssl.org/policies/cla.html
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/openssl/openssl/pull/8917?email_source=notifications&email_token=ABHT3KGA7AS6CXLWNNMW43DPYR4IJA5CNFSM4HMJALE2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWYD5MQ#issuecomment-498089650,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABHT3KFRE4IMWTMTNSPMJWDPYR4IJANCNFSM4HMJALEQ
.

This is the first time that you bring this problem up.

I hadn't noticed that detail before, sorry.

Either is trivial or not, please say so and it will be treated as necessary.

This is a matter that I do not want to decide alone, so I'm asking for the help from my OMC colleagues.
However, a CLA is the ultimate solution regardless of that judgement (i.e. a signed CLA trumps any triviality marker), and it's up to @MouriNaruto to decide to submit one or not, not us.

It is a straight forward change - but @levitte is correct - this is non-trivial - so it needs a CLA in place.

I would suggest writing something in NOTES.WIN regarding the conditions for building for UWP, and most specifically that no-asm and no-uplink must be given.

@levitte @t-j-h
I have submitted a signed Corporate Contributor License Agreement (CCLA) to<EMAIL_ADDRESS>It's my first time to contribute source code to a famous project like this.
I don't care the copyright and hope it is merged ASAP because I wonder to help more people which have the same experience. So I added the "trivial" marker because I want to pass the CLA check.
But I still signed a CLA because I hope it will be easier for me to contribute to the repository of this project in the future.
I am very happy to hear that.
Thank you.
Kenji Mouri

CLA has been recieved.

I would suggest writing something in NOTES.WIN regarding the conditions for building for UWP, and most specifically that no-asm and no-uplink must be given.

I have added some special notes. @levitte
Thank you.
Kenji Mouri

Thanks @MouriNaruto !
@levitte can you merge it now?

@levitte can you merge it now?

I can approve, but before any merging can happen, a 2nd approval is needed.

@openssl, what is your opinion on taking this back to 1.1.1 as well? I'm of two minds, as this is kind of a new config target, but at the same time, the lack of this make certain builds impossible if I understand correctly

what is your opinion on taking this back to 1.1.1 as well?

I am against. I consider new platforms to be a feature which is not allowed for stable releases.

I consider new platforms to be a feature which is not allowed for stable releases.

I hope it can be taken this back to 1.1.1 because there are a lot of projects that are waiting on this.

Please could you rebase this on top of a fresh master? There is a merge conflict at the moment.

@mattcaswell OK, I have solved the conflict.

@levitte  I have updated the source code and need your help.

Interesting discussion here. Next steps?

I think it's ready to be merged. @levitte or @mattcaswell can you please merge?

I squashed these commits and made a trivial edit to remove some trailing whitespace. I also removed the "CLA: trivial" line from the commit message (sine we decided it wasn't trivial and a CLA was later submitted).
Pushed to master. Thanks all!

Thanks all! I am very excited about that.
Kenji Mouri

@levitte @mattcaswell Here is the next talk about the UWP support. (https://github.com/openssl/openssl/issues/9125)


runtime/race: use runtime.CallersFrames

The backtraces from the race detector don't include inlined frames. But we now have that information available, via runtime.CallersFrames. It'd be nice to use it.
I went to look at adding this myself, but I'd need a few pointers--the race detector code is out of tree, and I can't find the place where the race detector traceback interacts with the Go runtime.
cc @dvyukov

The race detector run time support calls back into Go to print a stack trace.  The callback function is passed to the race detector in the call to __tsan_init from raceinit in runtime/race.go.  The callback function is racecallbackthunk, defined in runtime/race_amd64.s.  It calls racecallback in runtime/race.go, which calls FuncForPC to get the Go function name.
The PC values passed to FuncForPC are collected by calls to racefuncenter and racefuncexit inserted by the compiler (cmd/compile/internal/gc/racewalk.go).
So, yes, it would be nice to use CallersFrames, but it's not clear that we have the right data or API.

Re API: yes, need to extend it to make it possible to return several frames. Tsan runtime itself was always able to deal with inlined frames, so it's only tsan<->Go interface that needs to be changed.
Re right data: @ianlancetaylor why do you suspect that the data may not be right? Why calling CallersFrames with a single PC may not work?

Calling CallersFrames with a single PC will work, but I think that only collecting PCs at function entry points won't produce sufficient info when using mid-stack inlining.  If F calls G calls H calls I, and the middle is inlined, the race detector may report a stack trace showing F calling I.  To get the correct stack trace it needs to have not just the PC when it enters I, but the PC within F that calls I.
Perhaps the race detector does collect that, and I just understand how it works.

@ianlancetaylor on function entry it obtains caller pc, so it's actually call site. So everything should work.

Just ran into this again while investigating #36431.

Hmmm, I thought I fixed this in the fix for #33309.

Are you sure you saw a missing frame using 1.14? I don't see any missing frames. I get the same trace you did in #36431 where you said you turned inlining off. I didn't turn inlining off.

Hmm, must've been with go1.13.5 instead. I just tried go1.14beta1 and gotip again and I seem to be getting complete stack traces with those.

Phew, thanks. I'm going to close this issue then.


Binary operator '==' cannot be applied to operands of type 'Expression' and 'String!'

Hello,
I have the following:
var passedDetails:String! (it gets a value before the filtering)
let additivesTable = Table("Additives")
let keyColumn = Expression<String>("key")

When I try to filter:
let valueAdditive = additivesTable.filter(keyColumn == passedDetails)

I'm getting this error: Binary operator '==' cannot be applied to operands of type 'Expression<String>' and 'String!'
The same thing worked perfectly on Swift 1.2. Any ideas?

Hm, this may be a bug in Swift 2 type resolution. I'll see if I can repro and file a bug with Apple if need be. In the meantime, does the problem go away if you call passedDetails!? Is there a way to refactor this code so that you don't have to use an implicitly-wrapped optional?

Nope, the error appears even if its "passedDetails!".
It also appears if I simply add a string instead of the variable.

I forgot to add "import SQLite" into the class and that's why the error occurs. Geez...

Is it fixed? I am trying like this
var index = String
let Index = Expression<String?>("Index")
for row in DataManager.con.prepare(table).filter(index == Index){
}
gives me compile error like below.
/Common Files/GitHiub/vesseltracker-xcode/vesseltracker/vesseltracker/Model/CrewList.swift:155:64: Cannot convert value of type 'Expression<Bool?>' (aka 'Expression<Optional>') to expected argument type '@noescape (Row) throws -> Bool'
Am I doing anything wrong?

@vineethvijayan The filter method needs to be called on the table, not the prepared statement. Did you find an error in the docs that had you code it this way?

Yes my mistake @stephencelis Sorry about that

How about this case? Did I make something wrong?


Change default PoP argument of esp_prov.get_security from None to string (IDFGH-5381)

Closes IDFGH-5380

Thanks for your contribution.

Hi @alexhenrie
The esp_prov.py provides the option whether you want to use PoP or not as a CLI argument.
Could you tell us your usecase for calling the function separately from a different script ?
Thanks

My biggest reason for importing functions from esp_prov.py, but not running esp_prov.py directly, is to send data to a series of custom endpoints, none of which is named "custom-data". It's clear that esp_prov.py was designed to allow importing its functions into other scripts because its main logic is disabled by the if __name__ == '__main__': statement when importing.

Thank you.

Fixed with https://github.com/espressif/esp-idf/commit/5ed53c272b2fac5c052d2d097b2fd6e9957ffd01, thank you for your contribution.

Thank you!


haddock error

I'm getting a haddock error
$ haddock hie-build-plugin/Haskell/Ide/BuildPlugin.hs
Haddock coverage:

hie-build-plugin/Haskell/Ide/BuildPlugin.hs:308:9: error:
    parse error on input ‘-- * Backwards incompatible change to '

It looks like the comment line -- * in file hie-build-plugin/Haskell/Ide/BuildPlugin.hs is being interpreted as a section header by haddock, but section headers can't seem to be defined inside code, only at the top-level or within a module statement.
Here is a simplified example in a file called x.hs:
-- * ok
main = do
  -- * not ok
  let x = 1
  return ()

If I process x.hs by haddock, I don't get an error on the first comment line, but do get an error on the second:
haddock x.hs
Haddock coverage:

x.hs:3:3: error: parse error on input ‘-- * not ok’

I did a grep for similar patterns in all haskell files (ag --haskell '\-\- \*' .) but couldn't find any other bad instances of -- *.

Interestingly we merged https://github.com/haskell/haskell-ide-engine/pull/424/files some time ago

cc @shlevy

@nponeccop This issue was a little over 12 hours after the merge, so probably @stevenyvr987 hadn't pulled yet? Certainly the error message doesn't contain the extra spaces my PR added.

Yes, I had not pulled one more time before reporting the issue. After pulling, I tried stack haddock on the project, and although I still can't do it successfully, at least the error reported in this issue is gone. I'll close the issue now.
There still seems to be a problem with stack haddock. I am using most recent version of stack and lts-10.0 of stackage. I'll try to figure out the error message and report a new issue if needed.


Add more favicons for different browser sizes

Summary of changes
Provide a detailed description of proposed changes.

Adds a lot of favicons

Proposed area of change
Put an x in the boxes that apply.

[ ] apps/bridge-dapp
[ ] apps/hubble-stats
[x] apps/stats-dapp
[ ] apps/webbsite
[ ] apps/faucet
[ ] apps/tangle-website
[ ] libs/webb-ui-components

Reference issue to close (if applicable)

Closes #1644

The sizes of the favicons on Tangle Marketing and Tangle Stats are still different.

I’m aware, I think it won’t get larger and we should close this task.
On Fri, Sep 29, 2023 at 11:18 AM Trung-Tin Pham @.***>
wrote:

@.**** commented on this pull request.
The sizes of the favicons on Tangle Marketing and Tangle Stats are still
different.
[image: image]
https://user-images.githubusercontent.com/60747384/271497090-087d50cc-a007-4110-9cb7-15a148092574.png
—
Reply to this email directly, view it on GitHub
https://github.com/webb-tools/webb-dapp/pull/1717#pullrequestreview-1650204835,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ADELLF4TFZFOWEKEZNIQBRTX4ZY6BANCNFSM6AAAAAA5LWINJQ
.
You are receiving this because you were mentioned.Message ID:
@.***>

Ya I'm aware this didn't change it, we'd have to either get a bigger favicon or just not worry about this. CC @monaiuu maybe 16x16 isn't enough and we need 32x32, can you provide?

Ya I'm aware this didn't change it, we'd have to either get a bigger favicon or just not worry about this. CC @monaiuu maybe 16x16 isn't enough and we need 32x32, can you provide?

It is because the margins are inconsistent using different images, device specification and favicon sizes should not matter. The correct favicon file can be accessed here: https://www.notion.so/hicommonwealth/Tangle-Logo-029bec068f1a4690a7defc92125be03d?pvs=4
We should remove all old favicon files for Tangle, and opt for the above image in Notion instead.


Component Governance: System.Security.Cryptography.Xml.4.7.0

source-build appears to reference System.Security.Cryptography.Xml.4.7.0 that is causing the new component governance issue.
More details: https://dev.azure.com/dnceng/internal/_componentGovernance/dotnet-templating/alert/7360924?typeId=6669620
please check if this is should be addressed or dismissed.

[Triage] When I looked there are actually two CG alerts that need to be addressed.

@NikolaMilosavljevic - Is this something you can take a look at?  This is a higher priority item.  To fix this, newer SBRP packages need to be created, remove the older versions, update any existing SBRP references, and lastly, validate source-build builds cleanly.

@NikolaMilosavljevic - Is this something you can take a look at? This is a higher priority item. To fix this, newer SBRP packages need to be created, remove the older versions, update any existing SBRP references, and lastly, validate source-build builds cleanly.

Working on it - is main branch the target?

Yes - However be aware of https://github.com/dotnet/source-build/issues/3084.


Any updates for Nov. & Dec.?

Hi There,
Just checking for the changelog notes for last & this month
Thanks

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 87fb3b64-807c-48b1-bbb0-822255efafcb
Version Independent ID: 93a95ce4-cb41-4b3b-9d1d-49dd255f47b6
Content: What's new? Release notes for Azure AD
Content Source: articles/active-directory/fundamentals/whats-new.md
Service: active-directory
GitHub Login: @eross-msft
Microsoft Alias: lizross

@cconrado  Thanks for contacting us! The What's New content will be updated on 12/10 after 3pm. We merged the November and December items together due to the holidays and lack of items. Hope this helps!
#please-close

@eross-msft makes sense thanks 👍


Is it possible to run open-datastudio Zeppelin on your own K8S cluster?

From the documentation, I see that Zeppelin can be run on minikube. Is it also possible to run it on your own cluster?

Yes. Although each cluster environment is a little different and may require small changes sometimes, there's no reason why it can not run on any other Kubernetes cluster the same way it runs on minikube.