Added missing 'to' in key features list

Adding the word 'to' for the Custom Events key feature description for better wording

@toddfoust : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Verified the update.
@toddfoust Thanks for submitting this typo fix.


TypeError: Cannot read property 'replace' of undefined at Module.extractRequires [as _extractor]

Description
I recently upgraded my react-native package and some others in my package.json to the latest release. Each time I try to compile me project, I run into a this error in the terminal:
TypeError: Cannot read property 'replace' of undefined
    at Module.extractRequires [as _extractor] (PATH_TO_PROJECT/node_modules/react-native/packager/react-packager/src/node-haste/lib/extractRequires.js:31:10)
    at codePromise.then.result (PATH_TO_PROJECT/node_modules/react-native/packager/react-packager/src/node-haste/Module.js:209:49)
    at tryCallOne (PATH_TO_PROJECT/node_modules/promise/lib/core.js:37:12)
    at PATH_TO_PROJECT/node_modules/promise/lib/core.js:123:15
    at flush (PATH_TO_PROJECT/node_modules/asap/raw.js:50:29)
    at _combinedTickCallback (internal/process/next_tick.js:67:7)
    at process._tickCallback (internal/process/next_tick.js:98:9)

The simulator throws the following error:
{"type":"InternalError","message":"react-packager has encountered an internal error, please check your terminal error output for more details"}

I can't tell if this is a source code problem, or if I messed up somehow in updating my npm packages.
Additional Information

React Native version: 0.39.2
Platform: iOS
Operating System: MacOS

How did you upgrade? I suggest using http://facebook.github.io/react-native/blog/2016/12/05/easier-upgrades.html to do upgrades.

I managed to sort this out. Thanks for the link though.

@crellison How did you sort this out?

@shkfnly I wish I could tell you. I was updating my RN package and some other RN npm modules at the same time and lost track of what was new and what was old. I ended up updating everything to the latest release regardless and looked at recently posted issues on each page. This one may have been due to a mismatch of ReactNative and React, but I'm really not sure at this point. I wish I could help more...

@shkfnly @crellison has any of you some extra information on this? I've also updated all my dependencies to the latest version and I'm running into the same issue...

A clean restart of the packager solved the issue for me.
watchman watch-del-all
rm -rf node_modules && yarn
npm start -- --reset-cache


[Improvement] Generic template to Handle errors messages and links

I'd like to manage errors messages, as HttpResponseBadRequest or other raw HttpResponse messages with a template, to get them styled and good looking.
My purpose start from the following structure:

Create a custom_message.html template, in it we'll manage three variables:

Message (title)
Description (some words to explain what matters)
web link (Button to get out from there)

Often in a SAML IDP when it get in a stale request or in a timeout, returns with strange errors. In django we can manage this easily and so I'd like to get it ready this way :)

Got it in class SamlIDPErrorView(TemplateView), just need little improvements but I think that this can be closed


Failed to build vfio

I am trying to compiling vfio module, but got following error:
cd cmd/vfio && go fmt && go vet && go install -v vet: ./vfio.go:46:28: cannot use (pci.PCILister literal) (value of type pci.PCILister) as dpm.ListerInterface value in argument to dpm.NewManager: wrong type for method Discover Makefile:20: recipe for target 'build-vfio' failed make: *** [build-vfio] Error 2
Please help to check

Hello @x8091. We recently tagged a new version of https://github.com/kubevirt/device-plugin-manager. In this new version we use beta version of Device Plugin API (instead of alpha). I would guess it is this change which causes VFIO DP to fail.
We have two options, either to lock device-plugin-manager version in Gopkg.toml to v1.9.2 or make the code of plugins kept in this repository compatible with v1.10.0, I don't mind neither. Please send a PR with the prefered option.

Thanks. I changed as your suggestion:
`diff --git a/Gopkg.toml b/Gopkg.toml
index 9656eaf6..117c0b88 100644
--- a/Gopkg.toml
+++ b/Gopkg.toml
@@ -34,6 +34,6 @@
name = "github.com/kubevirt/device-plugin-manager"
[[constraint]]

version = "~v1.10"

version = "v1.9.2"
name = "k8s.io/kubernetes"

diff --git a/vendor/github.com/kubevirt/device-plugin-manager/Gopkg.toml b/vendor/github.com/kubevirt/device-plugin-manager/Gopkg.toml
index 19bec1e6..5ac11045 100644
--- a/vendor/github.com/kubevirt/device-plugin-manager/Gopkg.toml
+++ b/vendor/github.com/kubevirt/device-plugin-manager/Gopkg.toml
@@ -8,8 +8,8 @@
[[constraint]]
name = "google.golang.org/grpc"

version = "1.10.0"

version = "1.9.2"

[[constraint]]
name = "k8s.io/kubernetes"

version = "1.10.0"

version = "1.9.2"`

But it still fails to compile:
./vfio.go:46:41: cannot use pci.PCILister literal (type pci.PCILister) as type "github.com/kubevirt/device-plugin-manager/pkg/dpm".ListerInterface in argument to "github.com/kubevirt/device-plugin-manager/pkg/dpm".NewManager: 	pci.PCILister does not implement "github.com/kubevirt/device-plugin-manager/pkg/dpm".ListerInterface (wrong type for Discover method) 		have Discover(chan "github.com/kubevirt/kubernetes-device-plugins/vendor/github.com/kubevirt/device-plugin-manager/pkg/dpm".PluginNameList) 		want Discover(chan "github.com/kubevirt/device-plugin-manager/pkg/dpm".PluginNameList) make: *** [build-vfio] Error 2

@x8091 I think it maybe it an issue in your Go environment. I cloned the master and ran make build docker-build and it all passed fine (without any dependencies changed). Would you think that is possible?

I tried on 2 machines (MacOS and Ubuntu1804) with go1.12.1
I have been using it for several projects, so I don't think it's causing compile issue.
BTW, Can you check the diff I mentioned above? I found 4 files in the repo:
modified:   Gopkg.lock
modified:   Gopkg.toml
modified:   vendor/github.com/kubevirt/device-plugin-manager/Gopkg.lock
modified:   vendor/github.com/kubevirt/device-plugin-manager/Gopkg.toml

not sure which files you're referring to.

You should not edit anything under vendor/ manually. I updated version of deps on both the plugin-manager and this repo in https://github.com/kubevirt/kubernetes-device-plugins/pull/63. Could you please check if the PR works better for you? It passes on my laptop and on Travis CI.

Thanks @phoracek.

    Signed-off-by: Petr Horacek<EMAIL_ADDRESS>
commit 98fda99e06db30cf815ef14ffdbb5cff0f9709ee (origin/master, origin/HEAD)
Author: Nick Burrett<EMAIL_ADDRESS>Date:   Wed Sep 18 09:50:03 2019 +0100

    Fix compile error: "Info call has possible formatting directive %s"

    Signed-off-by: Nick Burrett<EMAIL_ADDRESS>
However, compiling still failed:
~/go/src/kubernetes-device-plugins$ make build-vfio
cd cmd/vfio && go fmt && go vet && go install -v
# kubernetes-device-plugins/cmd/vfio [kubernetes-device-plugins/cmd/vfio.test]
./vfio.go:46:41: cannot use pci.PCILister literal (type pci.PCILister) as type "kubernetes-device-plugins/vendor/github.com/kubevirt/device-plugin-manager/pkg/dpm".ListerInterface in argument to "kubernetes-device-plugins/vendor/github.com/kubevirt/device-plugin-manager/pkg/dpm".NewManager:
	pci.PCILister does not implement "kubernetes-device-plugins/vendor/github.com/kubevirt/device-plugin-manager/pkg/dpm".ListerInterface (wrong type for Discover method)
		have Discover(chan "github.com/kubevirt/kubernetes-device-plugins/vendor/github.com/kubevirt/device-plugin-manager/pkg/dpm".PluginNameList)
		want Discover(chan "kubernetes-device-plugins/vendor/github.com/kubevirt/device-plugin-manager/pkg/dpm".PluginNameList)
Makefile:20: recipe for target 'build-vfio' failed
make: *** [build-vfio] Error 2

I tried on both MacOS and Ubuntu with go version go1.11 linux/amd64 and go version go1.12.1 darwin/amd64
Can you share more details about your environment and setup?

This is super weird. I installed fresh Fedora 30 VM.
Then I installed Go 1.12.10 and other development dependencies on top of it:
dnf install -y go make

Get the DPs repository and build VFIO:
go get github.com/kubevirt/kubernetes-device-plugins
cd go/src/github.com/kubevirt/kubernetes-device-plugins/
make build-vfio

It built the binary successfully on completely fresh system. I'm not sure what could be the issue and I can't really debug it without a reproducer. Please let me know if you have an idea on how to do it.


Example placeholder not showing if nil is passed as placeholder (SwiftUI)

When not passing a placeholder string, no placeholder appears at all.
According to the README, I thought a default number should appear.

It works when providing:
iPhoneNumberField(nil, text: $text, isEditing: $isEditing) {
                    $0.withExamplePlaceholder = true
                }

But I would have thought it should work out of the box...

I will close this, as above solution is acceptable


make credo config more strict and fix issues

@meivantodorov @d-velev @nedelcho-delchev-tues @cheezus1
Could you help me to write these moduledocs, because I don't know what most of them are supposed to do and it's hard to me to write it. Since you've worked on some of them please provide in this issue moduledoc for whatever module you have built.
[R] ↑ Modules should have a @moduledoc tag.
┃       apps/aecore/lib/aecore/peers/sync.ex:1:11 #(Aecore.Peers.Sync)
┃ [R] ↑ Modules should have a @moduledoc tag.
┃       apps/aecore/lib/aecore/chain/block_validation.ex:1:11 #(Aecore.Chain.BlockValidation)
┃ [R] ↑ Modules should have a @moduledoc tag.
┃       apps/aehttpserver/lib/aehttpserver/web/plugs/set_header.ex:1:11 #(Aehttpserver.Plugs.SetHeader)
┃ [R] ↑ Modules should have a @moduledoc tag.
┃       apps/aehttpserver/lib/aehttpserver/web/plugs/authorization.ex:1:11 #(Aehttpserver.Plugs.Authorization)
┃ [R] ↑ Modules should have a @moduledoc tag.
┃       apps/aehttpserver/lib/aehttpserver/web/channels/notify.ex:1:11 #(Aehttpserver.Web.Notify)
┃ [R] ↑ Modules should have a @moduledoc tag.
┃       apps/aehttpserver/lib/aehttpserver/web/channels/notification_channel.ex:1:11 #(Aehttpserver.Web.NotificationChannel)
┃ [R] ↑ Modules should have a @moduledoc tag.
┃       apps/aehttpserver/lib/aehttpserver/application.ex:1:11 #(Aehttpserver.Application)
┃ [R] ↑ Modules should have a @moduledoc tag.
┃       apps/aecore/lib/aecore/wallet/worker/supervisor.ex:1:11 #(Aecore.Wallet.Worker.Supervisor)
┃ [R] ↑ Modules should have a @moduledoc tag.
┃       apps/aecore/lib/aecore/txs/pool/worker/supervisor.ex:1:11 #(Aecore.Txs.Pool.Worker.Supervisor)
┃ [R] ↑ Modules should have a @moduledoc tag.
┃       apps/aecore/lib/aecore/persistence/worker/supervisor.ex:1:11 #(Aecore.Persistence.Worker.Supervisor)
┃ [R] ↑ Modules should have a @moduledoc tag.
┃       apps/aecore/lib/aecore/peers/worker/supervisor.ex:1:11 #(Aecore.Peers.Worker.Supervisor)
┃ [R] ↑ Modules should have a @moduledoc tag.
┃       apps/aecore/lib/aecore/peers/scheduler.ex:1:11 #(Aecore.Peers.Scheduler)
┃ [R] ↑ Modules should have a @moduledoc tag.
┃       apps/aecore/lib/aecore/peers/peer_blocks_task.ex:1:11 #(Aecore.Peers.PeerBlocksTask)
┃ [R] ↑ Modules should have a @moduledoc tag.
┃       apps/aecore/lib/aecore/miner/worker/supervisor.ex:1:11 #(Aecore.Miner.Worker.Supervisor)
┃ [R] ↑ Modules should have a @moduledoc tag.
┃       apps/aecore/lib/aecore/chain/worker/supervisor.ex:1:11 #(Aecore.Chain.Worker.Supervisor)
┃ [R] ↑ Modules should have a @moduledoc tag.
┃       apps/aecore/lib/aecore/chain/difficulty.ex:1:11 #(Aecore.Chain.Difficulty)
┃ [R] ↑ Modules should have a @moduledoc tag.
┃       apps/aecore/lib/aecore.ex:1:11 #(Aecore)
┃ [R] → Prefer using an implicit `try` rather than explicit `try`.
┃       apps/aecore/lib/aecore/structures/data_tx.ex:77:5 #(Aecore.Structures.DataTx.process_chainstate)
┃ [R] → Prefer using an implicit `try` rather than explicit `try`.
┃       apps/aecore/lib/aecore/chain/chain_state.ex:91:5 #(Aecore.Chain.ChainState.validate_tx)
┃ [R] → Prefer using an implicit `try` rather than explicit `try`.
┃       apps/aecore/lib/aecore/pow/cuckoo.ex:96:5 #(Aecore.Pow.Cuckoo.exec_os_cmd)

@gspasov
Sync - Contains peer sync functionality.
BlockValidation - Contains functions used to validate data inside of the block structure.
SetHeader - A plug that adds a header which confirms that the server is an aehttpserver to every response.
Authorization - A plug which checks if the request authorization UUID matches the one from the server.
Notify - Contains websocket communication functionality.
NotificationChannel - Contains websocket topic validation.
Application - Contains the Aehttpserver application initialization settings.
Supervisor - Supervisor responsible for all of the worker modules in his folder. (should be the same for every supervisor)
Pool.Worker - GenServer that stores and manipulates transaction pool state.
Peers.Scheduler - Performs peer related operations every @check_time milliseconds.
PeerBlocksTask - A task which gets unknown blocks from a given peer URI and starting block hash and adds those blocks to the chain if a sync isn't in progress.
Difficulty - Contains functions used to calculate the PoW difficulty.


[QUESTION] How to use the sdk as dependency

There is kvs_gstreamer_sample.cpp in samples directory. I want to customize this sample and integrate it with my other project. So I am looking for a way to use the sdk as dependency. But there are no header files of SDK in /usr/local/include or /usr/include after installation.
And Is there anyway we can use the sdk in CMAKE as shown in below
cmake_minimum_required(VERSION 3.1)
# note: cxx-17 requires cmake 3.8, cxx-20 requires cmake 3.12
project(basic-pub-sub CXX)

file(GLOB SRC_FILES
       "*.cpp"
)

add_executable(${PROJECT_NAME} ${SRC_FILES})

set_target_properties(${PROJECT_NAME} PROPERTIES
    CXX_STANDARD 14)

find_package(aws-crt-cpp REQUIRED)
find_package(KinesisVideoProducer REQUIRED)

target_link_libraries(${PROJECT_NAME} KinesisVideoProducer AWS::aws-crt-cpp)

@CY-1992 ,
We do not install to /usr/include by default. It is a bug in our build system. https://github.com/awslabs/amazon-kinesis-video-streams-producer-sdk-cpp/issues/809. The workaround would be install in the open-source directory by default and setting the search path to that. Or, you can set up your own path and cache CMAKE_PREFIX_PATH.

@disa6302 I do not understand completely. It would be great if you could explain it in more detail. Also I try to use kinesis producer sdk as git submodule. Added as sub directory in cmakelists.txt.
add_subdirectory(${CMAKE_CURRENT_SOURCE_DIR}/kinesisProducer EXCLUDE_FROM_ALL)
I have also included the directories so that I could use the sdk in my project.
include_directories(     "${CMAKE_SOURCE_DIR}/src/kinesisProducer/include",     "${CMAKE_SOURCE_DIR}/src/kinesisProducer/src",     "${CMAKE_SOURCE_DIR}/src/kinesisProducer/src/credential-providers",     "${CMAKE_SOURCE_DIR}/src/kinesisProducer/src/common",     "${CMAKE_SOURCE_DIR}/src/kinesisProducer/src/JNI/include" )
But compilation throws following error
fatal error: com/amazonaws/kinesis/video/client/Include.h: No such file or directory     5 | #include "com/amazonaws/kinesis/video/client/Include.h"       |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ compilation terminated.

@CY-1992 having the same issue here. It can't find the client because it doesn't exist.
com/amazonaws/kinesis/video/client/Include.h
is a dependency of:
https://github.com/awslabs/amazon-kinesis-video-streams-producer-c/tree/v1.3.0/src/include/com/amazonaws/kinesis/video
but as you can see in the Picture below there is no client folder. @disa6302 how should we include files that doesn't exist?

@CY-1992 having the same issue here. It can't find the client because it doesn't exist.
com/amazonaws/kinesis/video/client/Include.h
is a dependency of:
https://github.com/awslabs/amazon-kinesis-video-streams-producer-c/tree/v1.3.0/src/include/com/amazonaws/kinesis/video
but as you can see in the Picture below there is no client folder. @disa6302 how should we include files that doesn't exist?

@CY-1992 you have to add the header files from kvspic too.


CML PR for exp fbfd19d1

Automated commits for https://github.com/iterative/demo-bank-customer-churn/commit/fbfd19d117d206126d9c7905a1a13013fd4dfec6 created by CML.

fbfd19d
Metrics

Path
f1
f1_by_geo.France
f1_by_geo.Germany
f1_by_geo.Spain
roc_auc
roc_auc_by_geo.France
roc_auc_by_geo.Germany
roc_auc_by_geo.Spain

metrics/metrics.json
0.5892
0.50155
0.66488
0.58974
0.85141
0.83162
0.84304
0.85373

Confusion Matrix


Support jetstream feature

What motivated this proposal?
We are paid customers. And we use nats.ws in our project. But nats.ws did not support jetstream feature. When we want to use jetstream api, we should change sdk from nats.ws to nats.dino. So, we want to use jetstream feature without nats.nino.
What is the proposed change?
Support jetstream feature in nats.ws.
Who benefits from this change?
Synadia`s customers.
What alternatives have you evaluated?
No response

@pkgonan nats.ws indeed supports jetstream in nats.ws - the nats.deno library is the home for all the common code for the nats javascript clients. The nats.ws simply contributes the websocket transport. But all usage is the same.
https://github.com/nats-io/nats.ws#jetstream
const nc = await connect();
const js = nc.jetstream()

You can also see the basic sanity tests here:
https://github.com/nats-io/nats.ws/blob/main/test/jetstream.js
While the extensive tests live in the github.com/nats-io/nats.deno repo


There is an error in the annotation

    def forward(
        self, h: FloatTensor, labels: LongTensor, mask: BoolTensor
    ) -> FloatTensor:
        """
        :param h: hidden matrix (seq_len, batch_size, num_labels)
        :param labels: answer labels of each sequence
                       in mini batch (seq_len, batch_size)
        :param mask: mask tensor of each sequence
                     in mini batch (seq_len, batch_size)
        :return: The log-likelihood (batch_size)
        """

In the annotation of this function, the shape of param h\labels\mask should be (batch_size,seq_len,)

@YangHaha11514
Thank you for discovering annotation misses.
If you don't mind, you can fix its and make pull requests ?


New session

Add new session form should now look identical to the Figma design. Used some different community packages for the Select menu and Date/Time Picker components.


Allow choosing the DNS update server

By defaulting to undef the current behaviour is maintained.
Closes GH-88

merged, bedankt @ekohl!


Feature Request: Only download if resource needs updating

Somehow Dependency Check does this (I haven't examined the source closely enough to see exactly how). It would be a nice optimization, so my cron job doesn't have be wasteful of network resources.

There is room for few optimizations:
Use of gzip encoding header
http://technet.rapaport.com/Info/RapLink/SampleCode/Java_Webrequest_Example.aspx
Check local vs remote filesizes
(I've been using a single HEAD request for that but you should use the META files)
Ref. https://nvd.nist.gov/download.aspx

@athiasjerome gzip compression will not matter since this utility already downloads the gzipped version from nist. Cannot use sha256 hash from meta files because the meta only has a hash of the raw xml. This utility only provides a mirror of the gzipped version and does not uncompress. Using HEAD for the time being. Open a new ticket if additional requests.


Turn off progress meter when progressbar_length=0

Instead of spewing errors when progressbar_length is set to 0, just hide the progress meter altogether. Note that this does hide the textual percentage as well.

Cheers, @pydsigner. And sorry for being so slow on this. :)


Utilizing stack caching

@Zhentar brought it to my attention that there's an undocumented ETW feature called stack caching. This feature should be utilized by etwprof. Details are in this gist.
Open questions:

What's the minimum Windows version required? I would guess Windows 8, but have to check
Does this "survive" trace merging? Even if the answer is no, the feature would still be useful, as the unmerged (intermediate) trace would be smaller
What parameters (bucket count, cache size) should we use?

PerfView applied a Windows 8 version check to its stack caching application, so that probably is the correct requirement.
One important note for etwprof application - I did not notice any sort of PID association on cached stacks, so you would probably need to track which StackKeys pass through the filtering relogger to filter the stack definitions appropriately (kernel & user stacks are cached separately, so you would definitely get cross PID matching on the kernel side, even if the user side is unlikely - and I'm not sure what PID will be associated with the cache eviction events but I don't think there's any guarantee it will be the process that created the entry).

Crap, I haven't thought of that... I would prefer to avoid introducing elaborate filtering logic and spelunking in internals. Maybe I will tie this to a command line switch, that way users can decide if their actual use case makes this worth turning on (profiled process is CPU-heavy: yes; otherwise: no).

I had a look at this, not much success so far. My first idea was to not use filtering at all: just turn on stack caching, and let every relevant event through. My assumption was that while this wastes some space (the trace will contain stacks from irrelevant processes), for CPU-heavy workloads the space savings might still be significant. I let through the following events without filtering from the StackWalk provider:

Key delete (35)
Key rundown (36)
Kernel-mode key reference (37)
User-mode key reference (38)

Events with opcode 34 are never emitted. I've tried a plethora of CacheSize and BucketCount combinations, but in my test scenarios, traces with stack caching turned on are always significantly larger. My tests didn't include a scenario where every logical CPU is pegged by the target process, but if this feature would be useful only in that extreme case, then I think it won't be useful at all.
According to the trace statistics view in WPA, the largest space consumers are key delete events (opcode 35). Since these delete events (and also 34, and 36, which share the same schema) are not associated with any process or thread, I can't say for sure, but to me, it feels like the majority of them must be belonging to other processes in the system.
Before I can give filtering a chance, I'd have to understand how stacks appear in the cache. Reference entries I get: they contain a key, and that's how they refer entries. Delete entries: why do they contain the entire call stack? If they are for invalidating entries, why doesn't the key suffice alone? How do stacks appear in the cache? I can't see any events that signal this.
@Zhentar, could you help me out here?

34, 35, and 36 would be better called "Key Definition" events. 34 defines the stack associated with a key before the first usage (i.e. when it is added to the cache), 35 defines the stack+key after the final usage  (i.e. when it is evicted from the cache), and 36 defines active keys that would not be included by one of the other two events (i.e. it dumps the cache contents).
At least in recent Windows 10 versions, I have found no evidence that the kernel is capable of producing leading definition events, nor does the API offer a mechanism that might control it, so I am inclined to guess that opcode 34 wasn't ever implemented.
So for implementing process filtering, I think you'd just need to track which keys the process of interest uses, and then drop any opcode 35s for keys not on that list.

Thanks, I think now I get it. It's a bit unorthodox that references are emitted before definitions, but as you mentioned in your gist, it's probably implemented this way to support circular tracing.
I implemented proper filtering in 831c53bcd957855af42bd5fb18f925c7d14de518.
However, I performed some measurements, and I'm still not seeing any space savings, no matter what I set the number of buckets to. In fact, the number of buckets does not seem to affect the trace size that much. For these tests, I set the memory limit to the maximum possible value, 50 MBs (I'm under the assumption that "too much" memory won't affect the hit ratio negatively, the worst that could happen is some wasted non-paged pool).
I used a video game as my test scenario. Idling in the main menu for 60 seconds (~ 1 logical CPU fully saturated):

No. of buckets
Trace size (KB)
No. of user key refs
No. of delete definitons

Content Cell
Content Cell
Content Cell
Content Cell

Content Cell
Content Cell
Content Cell
Content Cell

Content Cell
Content Cell
Content Cell
Content Cell

Content Cell
Content Cell
Content Cell
Content Cell

Content Cell
Content Cell
Content Cell
Content Cell

Content Cell
Content Cell
Content Cell
Content Cell

Content Cell
Content Cell
Content Cell
Content Cell

Content Cell
Content Cell
Content Cell
Content Cell

Thanks, I think now I get it. It's a bit unorthodox that references are emitted before definitions, but as you mentioned in your gist, it's probably implemented this way to support circular tracing.
I implemented proper filtering in 831c53bcd957855af42bd5fb18f925c7d14de518.
However, I performed some measurements, and I'm still not seeing any space savings (compared to stack caching turned off), no matter what I set the number of buckets to. In fact, the number of buckets does not seem to affect the trace size that much. For these tests, I set the memory limit to the maximum possible value, 50 MBs (I'm under the assumption that "too much" memory won't affect the hit ratio negatively, the worst that could happen is some wasted non-paged pool).
I used a video game as my test scenario. Idling in the main menu for 60 seconds (~1 logical CPU fully saturated):

No. of buckets
Trace size (KB)
No. of user key refs
No. of delete definitions

N/A (no stack caching)
3'930
N/A
N/A

256
4'884
~75'000
~60'000

1'511
4'658
~77'000
~49'000

3'719
4'229
~73'000
~37'000

6'907
4'291
~75'000
~36'000

10'037
4'445
~78'000
~39'000

40'087
4'167
~73'000
~35'000

66'841
4'481
~75'000
~39'000

100'151
4'446
~77'000
~38'000

A replay of a 6.5-minute match (about 1.5-2 logical cores fully saturated):

No. of buckets
Trace size (KB)
No. of user key refs
No. of delete definitions

N/A (no stack caching)
57'473
N/A
N/A

6'907
62'916
~1'170'000
~604'000

10'037
61'255
~1'140'000
~587'000

40'087
60'771
~1'134'000
~583'000

It doesn't seem like stack caching is particularly efficient (maybe that's why it's not utilized in neither xperf or WPA? 🤔), or maybe I'm getting something fundamentally wrong.

I think it's your workload - you're averaging under 2 references per definition, and it costs more to have a definition + reference pair than a single regular stacktrace because of the extra event header of overhead.
It should generally work a lot better for non-sampling kernel events like disk or memory, or if you've got particularly hot spots with deep stacks.

You are correct, I had a closer look, and there is very little duplication among call stacks in my scenarios (I used the flame graph for this: "fat bars" at the very top translates to repetition).
I also tested a scenario where all the CPU is spent in the very same call stack. There were nice gains according to the "Trace statistics" table (this reports uncompressed sizes), however, ETW's built-in compression works well enough that the resulting (compressed) trace size showed only a slight difference. However, ETW's compression works on trace buffers, so this was a best-case scenario for this. If duplication is not this local but "spread out" spanning multiple buffers, then this stack caching mechanism should perform much better (if "relevant" stacks are not evicted) than the built-in compression. Of course, this is all just speculation on my part.
Thanks for all the help, I think I will tie this functionality to a command line switch. I will also word the documentation carefully, so users won't associate this with "instant trace size reduction", or something like that.


NoneType error when finding aircrafts

It seems ADSBCOT crashes when a aircraft is missing any one piece of information (id, lat, long, etc). My question is how should this be handled? Should it be logged and the program continues or if the piece of information isn't critical (lat, long I would consider the critical part), should it just not provide that information? My current workaround is having a try and except check in classes.py on line 255 and it just ignores any aircraft missing a certain piece of information.

it shouldn't be crashing, it should just ignore the bad data. if you're
seeing it crash, can you send me the stack trace?
On Wed, Feb 15, 2023 at 6:01 PM gncnpk @.***> wrote:

It seems ADSBCOT crashes when a aircraft is missing any one piece of
information (id, lat, long, etc). My question is how should this be
handled? Should it be logged and the program continues or if the piece of
information isn't critical (lat, long I would consider the critical part),
should it just not provide that information? My current workaround is
having a try and except check in classes.py on line 255 and it just
ignores any aircraft missing a certain piece of information.
—
Reply to this email directly, view it on GitHub
https://github.com/ampledata/adsbcot/issues/24, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAAWIXUAQKV64AS3ZFJYDD3WXWDBHANCNFSM6AAAAAAU5SD4GI
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

--
Greg Albrecht @.***> W2GMD
EMT & ICT Specialist
Signal: +1-310-621-9598
https://ampledata.org/ http://ampledata.org/
https://github.com/ampledata

@ampledata Sure can do!

Sure! I'm using dump1090-fa and here's my config.ini
[adsbcot]
PYTAK_TLS_CLIENT_CERT = /etc/my_client_cert.pem
PYTAK_TLS_CLIENT_KEY = /etc/my_client_cert.pem
PYTAK_TLS_DONT_VERIFY = true
COT_URL = tls://XX.XX.XX.XX:8089
DUMP1090_URL = tcp+beast://<IP_ADDRESS>:30005

So I saw your message in Discord and I'll probably be switching over to the JSON feed instead, but I still would like to help fix this potential bug or if it's not a bug, help others find the solution :)

Hey @gncnpk, if you're running locally, I recommend switching to the new file:// based behavior, see: https://adsbcot.readthedocs.io/en/latest/config.html

using dump1090 from https://github.com/antirez/dump1090
running ./dump1090 --net --interactive
--> can see aircrafts locally on command line
--> can see aircrafts on hosted server with http://localhost:8080
running adsbcot -c config.ini with following config.ini
[adsbcot]
PYTAK_TLS_DONT_VERIFY = 1
PYTAK_TLS_DONT_CHECK_HOSTNAME = 1
PYTAK_TLS_CLIENT_CERT = /home/user/adsbcot/adsb.pem
PYTAK_TLS_CLIENT_KEY = /home/user/adsbcot/adsb.key
PYTAK_TLS_CLIENT_PASSWORD = password
COT_URL = tls://localhost:8089
FEED_URL = tcp+raw://localhost:30002

getting crash with error:
AttributeError: 'NoneType' object has no attribute 'replace'
DEBUG:asyncio:Close <_UnixSelectorEventLoop running=False closed=False debug=True>

running with FEED_URL = tcp://localhost:30003
adsbcot running, but reporting (DEBUG=1):
2024-11-29 12:02:27,869 pytak DEBUG pytak.classes.run:288 - Received 0 messages
2024-11-29 12:02:27,869 pytak DEBUG pytak.classes.run:288 - Received 0 messages
...
...
...

running with FEED_URL = http://localhost:8080/data.json
getting crash with error:
AttributeError: 'list' object has no attribute 'get'
DEBUG:asyncio:Close <_UnixSelectorEventLoop running=False closed=False debug=True>

if I open: http://localhost:8080/data.json the following data is seen (raw and changed):
[
{"hex":"123456", "flight":"ABC1234 ", "lat":12.345678, "lon":1.234567, "altitude":27050, "track":176, "speed":491}
]


Load cell reading issue?

When i put the calibration code in for the load cell, I get the output of  zeros over and over again and when I press the load cell it doesn't  read it. Sometimes though when I'm not touching it at all it jumps to high number like 3000. Help

Hi!
Your problem is most likely not related to the library itself.
Please seek advise at https://forum.arduino.cc/ or other similar community.
Olav


feat: pagination row count apis, new pagination docs

feat: Added rowCount table option as an alternative to pageCount
feat: Added getRowCount table instance API
feat: Added firstPage table instance API
feat: Added lastPage table instance API
feat:  Deprecated setPageCount API
docs: Updated pagination API Docs
docs: Wrote new Pagination Guide
docs: Updated the Pagination and Pagination Controlled examples

is there a way to update page count after table instance? any help?


Fix UI for "Assign Graders to Criteria" checkbox

Appears on its own row above the tables

Preview: https://gyazo.com/a0cf53a01d2ee8fe33199effc82e0b6e


chore: release main

:robot: I have created a release beep boop
@markdown-confluence/cli: 4.7.2
4.7.2 (2023-04-28)
Miscellaneous Chores

@markdown-confluence/cli: Synchronize obsidian packages versions

Dependencies

The following workspace dependencies were updated

dependencies

@markdown-confluence/lib bumped from 4.7.1 to 4.7.2
@markdown-confluence/mermaid-puppeteer-renderer bumped from 4.7.1 to 4.7.2

@markdown-confluence/lib: 4.7.2
4.7.2 (2023-04-28)
Bug Fixes

Don't specify default for contentRoot on CommandLineArgumentSettingsLoader. (ec8c338)

@markdown-confluence/mermaid-electron-renderer: 4.7.2
4.7.2 (2023-04-28)
Miscellaneous Chores

@markdown-confluence/mermaid-electron-renderer: Synchronize obsidian packages versions

Dependencies

The following workspace dependencies were updated

dependencies

@markdown-confluence/lib bumped from 4.7.1 to 4.7.2

@markdown-confluence/mermaid-puppeteer-renderer: 4.7.2
4.7.2 (2023-04-28)
Miscellaneous Chores

@markdown-confluence/mermaid-puppeteer-renderer: Synchronize obsidian packages versions

Dependencies

The following workspace dependencies were updated

dependencies

@markdown-confluence/lib bumped from 4.7.1 to 4.7.2

obsidian-confluence: 4.7.2
4.7.2 (2023-04-28)
Miscellaneous Chores

obsidian-confluence: Synchronize obsidian packages versions

Dependencies

The following workspace dependencies were updated

dependencies

@markdown-confluence/lib bumped from 4.7.1 to 4.7.2
@markdown-confluence/mermaid-electron-renderer bumped from 4.7.1 to 4.7.2

obsidian-confluence-root: 4.7.2
4.7.2 (2023-04-28)
Bug Fixes

Don't specify default for contentRoot on CommandLineArgumentSettingsLoader. (ec8c338)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/markdown-confluence/markdown-confluence/releases/tag/obsidian-confluence-v4.7.2 :sunflower:

:robot: Release is at https://github.com/markdown-confluence/markdown-confluence/releases/tag/%40markdown-confluence/lib-v4.7.2 :sunflower:

:robot: Release is at https://github.com/markdown-confluence/markdown-confluence/releases/tag/%40markdown-confluence/mermaid-electron-renderer-v4.7.2 :sunflower:

:robot: Release is at https://github.com/markdown-confluence/markdown-confluence/releases/tag/%40markdown-confluence/cli-v4.7.2 :sunflower:

:robot: Release is at https://github.com/markdown-confluence/markdown-confluence/releases/tag/%40markdown-confluence/mermaid-puppeteer-renderer-v4.7.2 :sunflower:

:robot: Release is at https://github.com/markdown-confluence/markdown-confluence/releases/tag/obsidian-confluence-root-v4.7.2 :sunflower:


Set generous CORS headers

This should be safe. https://jakearchibald.com/2021/cors/

If a resource never contains private data, then it's totally safe to put Access-Control-Allow-Origin: * on it. Do it! Do it now!

Already did it!


document path-to-regexp change in express 5 migration guide

Pre-req: https://github.com/pillarjs/router/pull/42
Refs: https://github.com/expressjs/discussions/issues/100#issuecomment-590058884

one approval, and this is should be ready to go in!
/cc @blakeembrey @dougwilson @wesleytodd @LinusU

Potentially we could also add explanations for the different suffixes?

@LinusU - from your approval, I am assuming that this comment is not a blocker?
@expressjs/express-tc - this is all set to land, towards express 5 GA. Is there anyone with spare bandwidth to review and merge this?

from your approval, I am assuming that this comment is not a blocker?

Correct 👍
Although @jonchurch have now provided an extend description which I think we should use 👏

I believe we need to wait for the express release with this change to be published prior to landing on the site (i.e. 5.0.0-beta.1)


Why is important to change the order of content['q'] and ?

As the comment says: https://github.com/mbzuai-oryx/Video-ChatGPT/blob/main/scripts/convert_instruction_json_to_training_format.py#L28

Hi @shufangxun,
Thank You for your interest in our work. The comment is referring to the importance of adding <video> token to the annotation which is going to be replaced with the actual video content during training. It is not referring to the order of content['q'] and <video>. However, during training this alternate order could be considered as form of regularization.
Please let me know if it clarifies the confusion. Thank you

Thanks for your reply! by the way, how much is the performance difference between these two ways？


MDX support

Does the markdown syntax also support MDX? it looks pretty good already.
I stumbled on some issues with another pkg https://github.com/brandonchinn178/sublime-mdx/issues/1

This rule for highlighting import statements of the other pkg might be nice to add in this project
https://github.com/brandonchinn178/sublime-mdx/blob/main/MDX.sublime-syntax#L43-L48

It supports component tags and jsx interpolation via curly praces as specified by Astro syntax specs. I would need to look into MDX specs to tell whether it's enough.
I may look into supporting MDX at some point, but the proposed import implementation is not in the shape to be added here. Modern syntaxes should no longer use push...with_prototype especially not to push complex syntaxes such as JSX.

It appears supporting import/export statements in Markdown (Astro) is not enough to fully support MDX.
Compared to CommonMark, MDX behaves completely different with regards to how content between "html" tags or components is treated.
It allows weird things like markdown blocks within html tags, but without "indented raw blocks" being supported.
<h1>

  # Heading 1

  - list
  - list

  > block quote

</h1>

This is a fundamental difference to how current markdown syntax works.

MDX support is planned to be provided by a dedicated package as it is unrelated to Astro.
see: https://github.com/SublimeText/MDX
It is requested for registration at packagecontrol.io as MDX to replace existing "MDX Syntax Highlighting" package.


Envelope signer / crypto abstractions

for implementing different signing algorithms

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

68 of 80 (85.0%)  changed or added relevant lines in 3 files are covered.
10 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.1%) to 57.143%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

extensions/envelope/signer.go
32
34
94.12%

extensions/envelope/middleware.go
18
21
85.71%

extensions/envelope/crypto.go
18
25
72.0%

Files with Coverage Reduction
New Missed Lines
%

extensions/token/balance_utxo.go
10
69.61%

Totals

Change from base Build<PHONE_NUMBER>:
-0.1%

Covered Lines:
3992

Relevant Lines:
6986

💛  - Coveralls


Fix code scanning alert - Flask app is run in debug mode

Tracking issue for:

[ ] https://github.com/mochiron-desu/petite-tube-wrapper-api/security/code-scanning/1

This app is not in production.


Garbled text on OSX

Text on the sample application is initially loading correctly, but then turns garbled within a second.
The issue has been reported on OSX,  JREs 1.8.0_66 and _121

This appears to be an issue with JavaFX WebView and Google Maps on OSX (works fine on linux).  Will submit a bug report to the JavaFX team.

Tested on Windows and it works fine as well. So it looks like it is only a problem on OSX.

I have same problem on OS X.

I've submitted a bug report to Oracle with an example test case that demonstrates the issue with the WebView.  I'll update this issue with the Oracle ticket number once its approved.

Oracle has acknowledged that this is a known issue and the fix for it is in Java 9.
http://bugs.java.com/bugdatabase/view_bug.do?bug_id=JDK-8088205

I have a workaround for the issue which should fix the issue in the next release of GMapsFX 2.12.0


Fix 4.1 ORT to work with 3.0 Traffic Ops

Draft - haven't tested yet.
This is especially necessary, because 4.1 TO has issues, with the generated logging.yaml among other things, that make it difficult or impossible to upgrade TO before ORT. This makes it possible to upgrade 3.0->4.1 ATC by upgrading ORT first.

What does this PR (Pull Request) do?

[ ] This PR fixes #REPLACE_ME OR is not related to any Issue

Which Traffic Control components are affected by this PR?

CDN in a Box
Documentation
Grove
Traffic Control Client
Traffic Monitor
Traffic Ops
Traffic Ops ORT
Traffic Portal
Traffic Router
Traffic Stats
Traffic Vault
CI tests

What is the best way to verify this PR?

If this is a bug fix, what versions of Traffic Control are affected?

The following criteria are ALL met by this PR

[ ] This PR includes tests OR I have explained why tests are unnecessary
[ ] This PR includes documentation OR I have explained why documentation is unnecessary
[ ] This PR includes an update to CHANGELOG.md OR such an update is not necessary
[ ] This PR includes any and all required license headers
[ ] This PR ensures that database migration sequence is correct OR this PR does not include a database migration
[ ] This PR DOES NOT FIX A SERIOUS SECURITY VULNERABILITY (see the Apache Software Foundation's security guidelines for details)

Additional Information

Found a problem with url_sig. The converted API call is missing an uppercase I in xmlid.
Seen:
/api/1.3/deliveryservices/xmlid/dsname/urlkeys

Correct path:
/api/1.3/deliveryservices/xmlId/dsname/urlkeys

Found a problem with url_sig. The converted API call is missing an uppercase I in xmlid.

Thanks! Fixed


kubefed: remove FederatedIngress feature

Kubefed v2 should be only focused on the federation of resources across kubefed clusters. In the Kubernetes ecosystem there are other third party tools (such as service meshes) that already provide support to the DNS based federated ingress.
As a consequence, kubefed won't create anymore IngressDNSRecord objects https://github.com/kubernetes-sigs/kubefed/blob/master/docs/ingressdns-with-externaldns.md).
Why is this needed:
Therefore, we need to remove any related work as part of kubefed to keep the source code clean and focused on satisfying the federation of resources.

/kind feature

In the Kubernetes ecosystem there are other third party tools that already provide support to the DNS based federated ingress.

I'm not familiar with this feature. Which third-party tools we are talking about here?

cc @shashidharatd @irfanurrehman

@hectorj2f This feature is already behind a feature flag and if we don't want to support it in future, it can always remain so, that is in an alpha state. If we foresee that this can burden us as maintenance debt, I would suggest to remove it when we reach that point (for example failing/flaky/broken tests which none of us wants to fix). If there are other more pressing issues/problems this is causing us now, I am quite curious to know.

I did miss saying that if it is enabled by default now, we can certainly change that  to keep it disbled in the default deploy configuration.

One of the intentions of this issue was to call the attention of any potential user of this feature. Based on the current reactions, I cannot see anyone relying on this feature at this moment and finding this action as a blocker to use kubefed. With that said, I am happy to follow a specific procedure such as disabling it first, and then delete it at some point in the future.
@RainbowMango I don't think there is any user using kubefed to just manage DNS records of Kubernetes Ingress resources created in other clusters. For sure, I can provide more context on which components can satisfy this similar scenario. I'd personally search for DNS discovery services or gateway-connected services for a multi-clusters env. I realize we should provide a more detailed information that describes which steps to follow to achieve the same result using these tools.
@irfanurrehman It sounds good to me to disable now, as part of a short term solution, and then delete it in the future. The main reason is to keep the source code focused on the federation and management of resources instead of having extra features that aim to address some networking gaps. This could also be a blocker to add new features to kubefed while having to support these ones.
I am not sure how much people is relying on this feature. We didn't have any bug since long time about this feature. Do you know if there is currently people using it ?.
Regarding to your point about removing it when failing/flaky/broken tests are discovered, it is a bit tricky :) because there is not much test coverage nowadays. I am sure that limiting the scope of kubefed to what people seems more interesting would help maintaining and improving kubefed, rather than trying to solve multiple problems at once.

LGTM for disabling and eventually remove from the code. This was an experimental feature and i don't know anybody using it. I agree that its a burden to keep maintaining the feature in alpha state.
Also it is high time to revisit the features in alpha state (https://github.com/kubernetes-sigs/kubefed#features) and evaluate whether to promote them to beta or drop them. keeping the features in alpha for long time does not give confidence to user apart from just playing with it for learning purpose.

One of the intentions of this issue was to call the attention of any potential user of this feature. Based on the current reactions, I cannot see anyone relying on this feature at this moment and finding this action as a blocker to use kubefed. With that said, I am happy to follow a specific procedure such as disabling it first, and then delete it at some point in the future.
@RainbowMango I don't think there is any user using kubefed to just manage DNS records of Kubernetes Ingress resources created in other clusters. For sure, I can provide more context on which components can satisfy this similar scenario. I'd personally search for DNS discovery services or gateway-connected services for a multi-clusters env. I realize we should provide a more detailed information that describes which steps to follow to achieve the same result using these tools.
@irfanurrehman It sounds good to me to disable now, as part of a short term solution, and then delete it in the future. The main reason is to keep the source code focused on the federation and management of resources instead of having extra features that aim to address some networking gaps. This could also be a blocker to add new features to kubefed while having to support these ones.
I am not sure how much people is relying on this feature. We didn't have any bug since long time about this feature. Do you know if there is currently people using it ?.
Regarding to your point about removing it when failing/flaky/broken tests are discovered, it is a bit tricky :) because there is not much test coverage nowadays. I am sure that limiting the scope of kubefed to what people seems more interesting would help maintaining and improving kubefed, rather than trying to solve multiple problems at once.

I‘m using this feature for muti-cluster dns discovery with external-dns and coredns.
Hope the community keep the feature.

@yuswift As a short term solution, we would disable it by default. But I'll share my thoughts during the next sig meeting about these features and their possible future.

/remove-lifecycle stale

/remove-lifecycle stale

with latest version, or v0.6.1, is this feature still available? In another word, user guide (https://github.com/kubernetes-sigs/kubefed/blob/master/docs/ingress-service-dns-with-coredns.md) is unavailable, is that right?
I have done the same work according the ingress-service-dns-with-coredns.md, but got empty spec in dnsendpoint and status. And  dig failed in dnstools container.

with latest version, or v0.6.1, is this feature still available? In another word, user guide (https://github.com/kubernetes-sigs/kubefed/blob/master/docs/ingress-service-dns-with-coredns.md) is unavailable, is that right?
I have done the same work according the ingress-service-dns-with-coredns.md, but got empty spec in dnsendpoint and status. And dig failed in dnstools container.

This feature has been disabled by default within v0.5.0 and will be removed in the future(maybe v0.6.2). If you want to try the feature, use v.0.4.1 or before.

@conquerorAlex Yes, @yuswift is right about the plans for this feature.
Are you still experiencing the issue with v0.5.0? Did you open any issue about it ?

Hi @hectorj2f I think we need to reopen this issue cause we can still create federatedingress in v0.7.0.  Shall we create a validating webhook for federatedingress or mutatingwebhook for federatedtypeconfig which disables the propagation?


inconsistent URLs in finder results

when i got to thor.dosomething.org/mx and filter by Environment I get a range of URLs for the campaigns. These include:

https://thor.dosomething.org/mx/voluntario/gtfo-mx
https://thor.dosomething.org/mx/campaigns/meatless-mondays (for Lunes Sin Carne)
https://thor.dosomething.org/mx/node/819 (for Bombs Away Semilla)

cc: @mshmsh5000 not sure if any of the work you're doing on URLs will address this or if you have any thoughts on what may be happening here

i'll delete these aliases, resave the nodes so better aliases get generated, reindex solr, clear drupal cache

I went through and ran the bulk update and reindexing yesterday and these seem to have been resolved. When the homepage loads, the URLs are still incorrect (missing the prefix) but when you use the finder the URLs are correct.

@mikefantini confirm that this is fixed and close out

urls from finder results look good to me. and I'm also seeing the proper prefix when the homepage loads.


Improvement(UI): Make docs styling responsive for better view on mobile devices.

Affected module
UI
Describe the bug
The view of the documentation of OM on mobile devices is not proper.
To Reproduce

Expected behavior
Styling should be proper for better readability on mobile devices.
Version:

OS: [e.g. iOS]
Python version:
OpenMetadata version: [e.g. 0.8]
OpenMetadata Ingestion package version: [e.g. openmetadata-ingestion[docker]==XYZ]

Additional context
Add any other context about the problem here.

Merged Changes in this PR


_ui.py inconsistent use of tabs and spaces in indentation

On line 34 in _ui.py, it uses tabs instead of spaces, so it causes the program to crash

updated. next time, you could just make a pull-request.

updated. next time, you could just make a pull-request.


Update tabs accessibility.mdx

Updating accessibility tab content

@alisonjoseph or @andreancardona Hey devs, this keeps failing the ci format, if someone could help Michael fix it. Thank you!


WIP

For #

[ ] Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR).
[ ] Title summarizes what is changing.
[ ] Has a news entry file (remember to thank yourself!).
[ ] Appropriate comments and documentation strings in the code.
[ ] Has sufficient logging.
[ ] Has telemetry for enhancements.
[ ] Unit tests & system/integration tests are added/updated.
[ ] Test plan is updated as appropriate.
[ ] package-lock.json has been regenerated by running npm install (if dependencies have changed).
[ ] The wiki is updated with any design decisions/details.

Codecov Report

Merging #10887 into master will decrease coverage by 0.38%.
The diff coverage is 20.00%.

@@            Coverage Diff             @@
##           master   #10887      +/-   ##
==========================================
- Coverage   60.67%   60.29%   -0.39%
==========================================
  Files         580      580
  Lines       31528    31547      +19
  Branches     4479     4485       +6
==========================================
- Hits        19131    19020     -111
- Misses      11427    11573     +146
+ Partials      970      954      -16

Impacted Files
Coverage Δ

src/client/datascience/jupyter/jupyterNotebook.ts
4.26% <0.00%> (-0.02%)
:arrow_down:

...ascience/jupyter/liveshare/guestJupyterNotebook.ts
9.48% <0.00%> (-0.07%)
:arrow_down:

src/client/datascience/types.ts
100.00% <ø> (ø)

src/client/datascience/jupyter/jupyterSession.ts
17.04% <12.50%> (-39.77%)
:arrow_down:

src/client/datascience/jupyter/jupyterWebSocket.ts
16.66% <25.00%> (+1.66%)
:arrow_up:

...ience/interactive-common/interactiveWindowTypes.ts
100.00% <100.00%> (ø)

...ent/datascience/jupyter/jupyterWaitForIdleError.ts
33.33% <0.00%> (-66.67%)
:arrow_down:

src/client/common/utils/async.ts
74.41% <0.00%> (-13.96%)
:arrow_down:

src/datascience-ui/react-common/arePathsSame.ts
75.00% <0.00%> (-12.50%)
:arrow_down:

... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a58ce8...e44add6. Read the comment docs.


Expose full ts object to global ts

It looks like the prior PR https://github.com/microsoft/monaco-editor/pull/2770 was close, but not quite. The object available is the exported set of vars at the end of typescriptServices.js:

Which isn't the typescript API, just a subset (used for ESM support I assume) - this means you don't get access to the underlaying ts.  To work around this, I've done a bit of a dance of exporting typescript from this object and then later adding that to the globalThis.
To validate, I've added to the smoketest for a non-exported property from the TypeScript compiler API. Nice test suite BTW 👍🏻

I took a look at what changed in the JS between:

monorepo: https://typescript.azureedge.net/cdn/4.6.0-dev.20211115/monaco/dev/vs/language/typescript/tsWorker.js
before: https://typescript.azureedge.net/cdn/4.4.4/monaco/dev/vs/language/typescript/tsWorker.js

Which looks to roughly be that the script didn't use umd-style requires and that's probably what used to set the top level as now it gets scoped into the function because they live in a "use strict" context.

:+1: Makes good sense!


fix(linter)!: override plugins array when passed in config file

fixes https://github.com/oxc-project/oxc/issues/6896

When the plugins config property is specified, it will overwrite the default plugins array. This allows the plugins list to be easily customized and allows for disabling default plugins at the same time as enabling non-default ones.

example: { "plugins": [] } will enable no plugins.
example: { } will enable default plugins.
example: { "plugins": ["typescript", "import"] } will enable only the import and typescript plugins.

Thanks on working on this. ❤ With the new overrides property there is a new discussion to make :)
{
  plugins: ["typescript"],
  overrides: [
    {
        files: ["*.tsx"],
        plugins: ["react"]
    }
  ]
}

with this config I expect to enable ts and react plugin for .tsx files. Maybe someone other expect it differently :)

That is a also a topic 👍 Let not block this PR, perrsonally im fine at the moment.

if i specify an empty array. but have a rule in the rules list that uses a plugin does it get reported as an unknown rule?

existing rules in the project should always be known and can be enabled/disabled in the rules block.
plugins + categories enables the base rules, rules block should adjust the last needs.
That what I expect as a user, don't know what the core team says about it :)

Thanks for working on this. ❤ With the new overrides property there is a new discussion to make :)
{
  plugins: ["typescript"],
  overrides: [
    {
        files: ["*.tsx"],
        plugins: ["react"]
    }
  ]
}

with this config I expect to enable ts and react plugin for .tsx files. Maybe someone other expect it differently :)

Good point, I forgot to consider the overrides property here. I think that making the plugins array append when inside of overrides feels the most intuitive to me? I can update the tests and behavior accordingly.

if i specify an empty array. but have a rule in the rules list that uses a plugin does it get reported as an unknown rule?

Yes, I think this should report as an unknown/disabled rule warning. I can imagine a case where you remove a plugin that is no longer needed and want to be warned of config that is no longer useful. Or, like in the case above with overrides, you need to explicitly enable the plugin to use the rule.

I think that making the plugins array append when inside of overrides feels the most intuitive to me?

Feels for me too, but I do not know how it is currently with categories.
When overrides really overrides and not append. I think my expection is wrong and we should keep it consistent.

I checked the behavior with the legacy .eslintrc setup in ESLint, and it this config will append so that .ts files have the react and typescript plugins enabled:
{
  "plugins": ["@typescript-eslint"],
  "overrides": [
    {
      "files": ["*.ts", "*.tsx"],
      "plugins": ["react"]
    }
  ]
}

So, I think this is the way to go for compatibility. And specifying an empty array here does not disable all of the plugins.

Merge activity

Nov 16, 12:41 AM EST: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.


Update blog URL to point to current address

http://blog.helioviewer.org is 404.

Additionally the wiki points to suske.


Fix mocking

Codecov Report

Merging #347 (707f01c) into master (5ccface) will increase coverage by 0.04%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #347      +/-   ##
==========================================
+ Coverage   41.70%   41.74%   +0.04%
==========================================
  Files          32       32
  Lines        4678     4678
==========================================
+ Hits         1951     1953       +2
+ Misses       2727     2725       -2

Impacted Files
Coverage Δ

assemblyline_core/dispatching/dispatcher.py
77.09% <0.00%> (+0.26%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5ccface...707f01c. Read the comment docs.


Improve config and logger

Relocate the blank import to resolve init() order issue between pkgs
Add logwriter option and update logger
Improve config for use regardless of node environment
Add templates of config.yaml and setup.env

/approve


Refactored AcarsTest.php

Refactor AcarsTest class

I'm not sure why I understand the motivation behind refactoring? A lot of this was split up the way it is, albeit more verbose, to make debugging and placing breakpoints, and viewing values for TDD much easier.

I just taught it was a little harder to read as methods were a bit long with a lot of variables. I think debbuging and viewing values is still very much achievable.

If you can fix the style ci checks, I'll take a closer look when I'm on the computer

I'd apply the diff that styleci is giving you, that should fix it


Create variable scripts a get command.

When saving a series, if the user creates a variable or a method the scripter only prints a 'get' statement. What if the script is being run against a database where the variable/method does not exist? the get command will cause an error.

@horsburgh , we're wondering if we still need to worry about this. It's only an issue if a user is running a script with save commands on a database different from the original database.

@AmberSJones - I don't know if this has been addressed.  I don't think it was just an issue with a script with save commands on a database different than the original database. It was an issue with saving when you are creating a new variable or method for the series you need to save. If @sreeder can verify that it has been fixed, we can close.

I just tried to do a quick test on the Master branch and I can't because none of the save stuff is working.  I can't get the partial Python script I created (before things broke down) to re-execute either.


New version: GNU.MidnightCommander version 4.8.24-221

[X] Have you signed the Contributor License Agreement?
[X] Have you checked that there aren't other open pull requests for the same manifest update/change?

[X] Does your manifest conform to the 1.0 schema?

Microsoft Reviewers: Open in CodeFlow

/azp run


Set GLIBCXX_USE_CXX11_ABI=0

Currently the mason packages node-osrm builds against are built with GLIBCXX_USE_CXX11_ABI=0. Setting this same value in the osrm-backend and node-osrm build ensures we are consistently building against the same libstdc++ api and protects against compilers or systems with alternative defaults.
Note: In the future we can easily move to GLIBCXX_USE_CXX11_ABI=1 if mason packages are available and built with that setting.

Current coverage is 0.00% (diff: 100%)

No coverage report found for master at 02153df.

Powered by Codecov. Last update 02153df...352ca6c


Python: DMatrix.slice() looses feature_names

One can see that DMatrix.split operation drops feature_names to default:
def demonstrate_split_problem():
    pool = xgboost.DMatrix(np.array([[0], [1]]), feature_names=['a'])
    subpool = pool.slice([0])
    if pool.feature_names != subpool.feature_names:
        print('I told you so!')

It is due to DMatrix.init() issue:
          if data is None:  # skips rest of the function in case of None input data
            self.handle = None
            return
  #end of the function:
  self.feature_names = feature_names
  self.feature_types = feature_types

But DMatrix.slice() use just this scenario of DMatrix.init() usage:
res = DMatrix(None, feature_names=self.feature_names)  # here feature_names is lost

I propose to move
 self.feature_names = feature_names
line to the end of the split function.
Steps to reproduce

Create DMatrix with feature_names
call split()
check current feature_names state

This seems to be an issue that we can fix, can you send a PR to fix this?

Consolidating to #3439. A new issue should be opened if someone decides to actively work on implementing this feature.

@hcho3 Could I work on this one? Do I need to reopen it?

@ma3axaka Please open a new issue.  We want to do some refactorings around DMatrix.  So maybe we can work on it together.

@trivialfis Can you open a new RFC about the proposed re-factoring? (Doesn't have to be too elaborate; just explain what you want to achieve)

@RAMitchell Here.

@trivialfis Is there a ticket for refactoring DMatrix?

@ma3axaka Not yet.  Should be up next week, we want to summarize collected ideas, thanks for the patience. ;)

@tarstars @bourbaki Fixed by #3766


Feature Request: Barrier Free PDF

Is this on the roadmap?

Do you mean accessible? (PDF/UA)

`yes it is


unexpected order of classpath precedence with resource files

I'm not sure if I should be reporting this in bazel proper or here, but an issue I ran into recently was the classpath ordering of resource files. In sbt, if I have a module foo with a resource named bar.properties under src/main/resources and a test that overrides that under src/test/resources/bar.properties, I can be sure that when I run my test, bar.properties will be read first when reading from the classloader as a stream.
However, with scala_test rules, if I have a similar declaration of resources in a scala_library dep of my scala_test, the copy from the scala_library's resources seems to get resolved first.
Again, I'm not sure if this is a specific problem to these rules or bazel in general. It also may be an antipattern that I shouldn't be doing in the first place :)

@softprops any chance for a printout of the classpath? you can cat the launcher script to see it. Additionally what I'd appreciate is if you could try and reverse the order of the two relevant jars and report if it solved it.
In general I think it's a good question on whether we want to supply such guarantees. Do you have any java code? The reason I'm asking is because this question feels like it deserves a more general Bazel JVM best practice than a specific scala one.

Relying on jar order feels like an anti pattern to me.
On Thu, May 4, 2017 at 09:12 Ittai Zeidman<EMAIL_ADDRESS>wrote:

@softprops https://github.com/softprops any chance for a printout of
the classpath? you can cat the launcher script to see it. Additionally
what I'd appreciate is if you could try and reverse the order of the two
relevant jars and report if it solved it.
In general I think it's a good question on whether we want to supply such
guarantees. Do you have any java code? The reason I'm asking is because
this question feels like it deserves a more general Bazel JVM best practice
than a specific scala one.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/bazelbuild/rules_scala/issues/189#issuecomment-299281464,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAEJdqMqU4mHwO-VtddEE10bQUPXwjCSks5r2iMdgaJpZM4NQ8T4
.

Relying on jar order feels like an anti pattern to me.

Yea that's the solution that I settled on ;). I worked around by renaming the version on the test classpath and referenced that from my test which solved the issue for me but I think everyone will have the interfaces built into their code do to so. So I'm unblocked for now but leaving this here for future reference of others are coming from sbt and hit this issue

That said I can think of a few more cases others may rely on. A file called log4j.properties is a common one. I haven't hit that yet but I'll post back here if I do.

Can we close this one for now under "won't fix"? At least until a stronger use-case will show up

Yes. It's notable we did actually run into this  another time with log4j.properties (and a few other misc cases). we had a third party dependency,a few actually, with log4j.properties at the root of thir jar as did we with our new bazel jar outputs. When loading these into our servlet container, we didn't get a deterministic copy resolved at runtime because the tomcat lib dir has less precedence than the classes dir, where we used to stage sbt outputs ( class files ). While this was annoying, it shouldnt have been surprising. The surprises were all just realizations bazel brought to our attention faster than with sbt. And for that we are thankful for bazel. I very much agree that order dependence should not be an expected propery of a deterministic build system. If these problems come up for others under these same circumstances it would be fair to say it's a user error.

@softprops when you say

I worked around by renaming the version on the test classpath and referenced that from my test
can you maybe give a bit more detail on what you mean?
As you suspected I indeed am hitting the very same issue :(

We have a huge problems with this with connection to akka and typesafe config. The configuration is done in such a way that there are multiple reference.conf files in base libraries that are then extended by a reference.conf in our codebase. These two files then have to be merged in order to work correctly. This is not a problem in *_deploy.jar that merges these files (not sure exactly what is the difference at the time).


source_files is empty

I'm working on makinacorpus/django-safedelete#56 where I'm facing some troubles moving coveralls to tox. It doesn't report any files and when running - coveralls debug instead of - coveralls in tox, source_files is empty:
{
    "config_file": ".coveragerc",
    "source_files": [],
    "service_name": "coveralls-python",
    "git": {
        "branch": "bug/can_hard_delete_fk",
        "remotes": [
            {
                "name": "origin",
                "url": "git@github.com:AndreasBackx/django-safedelete.git"
            },
            {
                "name": "upstream",
                "url": "git@github.com:makinacorpus/django-safedelete.git"
            }
        ],
        "head": {
            "author_name": "Andreas Backx",
            "id": "9861655e43d23c34a0bef6145ddf67ab2f9208f6",
            "author_email": "myemail",
            "committer_email": "myemail",
            "committer_name": "Andreas Backx",
            "message": "Moved coveralls to tox and ignore its exit code."
        }
    }
}

I can't see to figure out what is wrong and would appreciate it if you could point me in the right direction.

Hey! Just wanted to leave a comment pointing out that you probably won't get a response on this until #122 is resolved.

@TheKevJames thanks for the reference. I'll keep an eye out.

@AndreasBackx is this still an issue? If so: I've update coveralls debug to be a bit more usefully verbose. Could you re-run coveralls debug and paste the output?

We've held back on using tox with coveralls. @Gagaro might know more, I haven't done any work on it recently and I'm currently studying for exams.

Ok -- I'm going to close this ticket, since I think this should be fixed by now, but if you @AndreasBackx or @Gagaro find it is not, feel free to re-open.


Finer-grained syntax highlighting

Version of VSCode: 1.11.2
Version of the extension: 0.3.11
OS: LInux x64
Description:
Currently, the syntax highlighter is rather coarse and makes no distinction between identifiers and other forms of punctuation, lumping them all into the "source.rust" TM scope. This is making it challenging to design a color theme. Being able to color identifiers separately from punctuation would be very helpful.
In the long term, it could even be ideal to use the RLS to determine if an identifier is a struct/trait/local/etc to make even finer grained colorizations, but for now, any distinctions that can be determined from syntax alone would be nice to have.

@jpernst,
VSCode uses the following colorizer:
https://github.com/zargony/atom-language-rust
If you opened a PR, I would be glad to accept it.


Fix of export definitions for MS Windows

Hi Rado,
this is PR without squashing commits, hopefully you accept it.
Here is https://github.com/miroi/autocmake/blob/master/README.md with green tests of travis-ci, appveyor.
Please modify your README.md so that it includes badge of your own appveyor URL.

On the appveyor branch I don't mind so much nice history,
I can squash and rewrite it there myself.
But there are are conflicts - this cannot be automatically merged.
Please check whether this merges before filing the PR.

Please rebase these commits on top of the central appveyor.
See also https://help.github.com/articles/resolving-merge-conflicts-after-a-git-rebase/.

Closing this pull request as I am going to use another branch, reased, for this PR.


API for useApplyBillingAddressChange

We need a useApplyBillingAddressChange based on the use case that if a user selects a delivery option in cart we want to update the shipping address but we want the billing address to remain as it was.
For example: people using custom parcel pick up as a delivery option, and based on the user selection they want the address updated on the order shipping but in this case user shouldn't be able to select billing address same as shipping address.

Could you please provide an update on the progress of this feature?

Update: We have been exploring these use cases, and don't currently believe providing a billing address mutation is the right solution. In the use cases we have been seeing, the real need is for the billing address input form to be shown in scenarios where it is currently not shown. If the real need here is to cause the billing address form to be displayed, then exposing a mutation is the wrong solution, because it will require merchants/partners to implement their own form via extensions. This is a very difficult piece of UX to build, when you consider validation, auto-suggestions, and integration with 3rd party apps that provide these features. You should never need to recreate this form within checkout.
Please continue to share your use cases in this issue. It would be valuable to distinguish between:

Do you need the billing address form to be displayed? In what specific scenarios is it being hidden for you today? Be sure to specify if you are using 1-page vs 3-page layout, and what delivery methods.
Do you need a billing mutation for other reasons? Eg., when the billing address form is already being shown, but you still want to programmatically edit it. Note that auto-suggest extension APIs will already permit mutations here. We also intend to allow targetting of billing address fields via 3rd party validations (either UI extensions using buyer journey intercept, or validation functions).

@valerioCMW Where is the buyer's billing address stored in these cases such that the extension can pre-fill it? Presumably in some offline system? Or does the buyer actually have a customer account and it's just that their payment information isn't vaulted?


labelOffset and legendSize

The doc says:

A value that determines how far the label is from the symbol in each legend item. Default set to 10px.

But I think there is a problem, here are screenshots:

The code used to generate the legend:
legendSize()
.title(legendTitle.charAt(0).toUpperCase() + legendTitle.slice(1))
.scale(reportScale) // a quantitative scale with two values
.shape('line')
.shapePadding(10)
.shapeWidth(2)
.labelOffset(5)
.labelFormat('.0f')
.labelAlign('start')
.labels(({ i, domain }) => domain[i])
.orient('horizontal')

Also I set the font size to 11px in css.
Am I missing something?

It's poor wording in the documentation, it should say is the minimum offset from the shape. The expected behavior is that it aligns all of the labels vertically in the example you showed.

Ok it's clearer thanks !
Is there a way to get a constant padding with severals datasets?

hmmm could you explain more? do you mean across multiple legends?

Across multiple legends sharing the same config.
What I was thinking about is to have constant space between the blue lines below.

I'm surprised they aren't the same, I'll take a look, it's a bug.

Hey there @Lacroute a fix is in on v2.25.1 let me know if you have any problems with it.

I'll check soon and give you updates

Great! It works like a charm


Update auth0 to 1.33.0

Updates com.auth0:auth0 from 1.27.0 to 1.33.0.
GitHub Release Notes - Changelog - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "com.auth0", artifactId = "auth0" } ]

labels: library-update, semver-minor

Superseded by #229.


PyTorch Lightning Resnet returns a list, instead of a tensor.

https://github.com/PyTorchLightning/lightning-bolts/blob/48e75217d8c10e5726eafca2c85e795a993477e7/pl_bolts/models/self_supervised/resnets.py#L277
The code for Resnet class in Lightning Bolts needs modification. I found a discrepancy in the line referenced here.

The self.fc layer (final linear layer) needs to be implemented.
Please remove the square brackets from the next line. The output should be a tensor, not a list.

Thanks for the issue! Any chance you want to try and submit a fix?

Sure. I shall do this within this weekend.

False alarm, it seems that this code is intended to extract features from different layers of the ResNet. I had assumed that this code ought to give the final output from the ResNet. The original code is correct for its intended purpose.


Add support for running server on elastic beanstalk

Also includes config (encrypted) for deploying to EB.

Fuck, this wasn't supposed to end up in this repo... Hi @fippo


Bind all option-functions so they have a reasonable context

In my onSelect method, I sometimes want to insert pure text instead of the mention. This wasn't possible, since there was no (reasonable) this. Now you can do e.g. the following:
onSelect: function (item, insertItem) {
    if (item.whatEver) {
        const insertAtPos = this.mentionCharPos;
        this.quill.deleteText(
            this.mentionCharPos,
            this.cursorPos - this.mentionCharPos,
            Quill.sources.USER
        );

        this.quill.insertText(insertAtPos, item.whatEver);
    } else {
        insertItem(item);
    }
}

Super fast! Thank you! :)


Disable an event for for onSelectEvent

I need to have the Selectable option disabled for an event. I have 2 type of events i mean 2 different apis are implemented in a single calendar that is (1) holiday (2) leaves.
My issue is that i want to make the holiday event as a editable event and disable the leave events for edit option.
I have used this code for calender
<Calendar
            selectable
            onSelectSlot={this.toggleAddModal}
             onSelectEvent={this.toggleEditModal}
             events={list}
             startAccessor="start"
             endAccessor="end"
             defaultDate={moment().toDate()}
             localizer={localizer}
             eventPropGetter={event => {
                 const eventData = list.find(ot => ot.id === event.id);
                 const backgroundColor = eventData && eventData.color;
                 return { style: { backgroundColor } };
             }}
   />

the events are differentiated according to color of the event like red for holiday and green for leaves

resolved this issue by updating toggleEditModal into this
toggleEditModal = event => {         if (event.type == 'holiday') {             if (!this.state.isAddModalOpen) {                 let fields = this.state.fields;                 fields['is_restricted'] = event.resource;                 fields["occasion"] = event.title;                 fields['for_date'] = event.start;                 fields['id'] = event.id;                 this.setState({                     fields,                     currentEvent: event,                     isEditModalOpen: !this.state.isEditModalOpen,                 });             }         }     };


Part 1: RFQ uses fixed-points

The high-level goal of this change is to represent asset-to-BTC conversion rates using the new fixed-point number type. This PR updates several "price" related fields that were previously typed as milli-satoshis, which were used as a workaround in the Proof of Concept (PoC).
It is part of the ongoing effort to resolve: https://github.com/lightninglabs/taproot-assets/issues/871.
The ultimate goal is to align tapd with these BLIP changes: https://github.com/Roasbeef/blips/pull/4

Note to Reviewers
This is the first phase of the fixed-point refactor, targeting the approved-rfq-fixedpoint branch. This branch will accumulate all approved changes required to close https://github.com/lightninglabs/taproot-assets/issues/871 before being merged into main.
There are several TODO(ffranr): Temp solution. comments in this PR, which will be fully addressed in subsequent PRs before merging approved-rfq-fixedpoint into main.
Please review the commits in sequence. Note that some commit diffs may overlap slightly.

This change is

Current progress of feeding fixedpoints through the code, and building the commit structure through

I need to re-write this so that we use BigIntFixedPoint for all "internal" tapd fixed-points and then use Uint64FixedPoint when we export/import via RPC or wire messages.

@roasbeef: review reminder

Ok, discussed offline, and for now re format, we'll:

Figure out a proper format for the byte serialization of the fixed point instance.
As a stop gap, we'll:

Write a property based test for the new intermediate value, to ensure that we never lose scale.
On the wire, just use the big.Int serialization.
For the RPC interface, write the scale and coefficient values a strings.

Ok, discussed offline, and for now re format, we'll:
* Figure out a proper format for the byte serialization of the fixed point instance.

* As a stop gap, we'll:

  * Write a property based test for the new intermediate value, to ensure that we never lose scale.
  * On the wire, just use the `big.Int` serialization.
  * For the RPC interface, write the scale and coefficient values a strings.

  * Write a property based test for the new intermediate value, to ensure that we never lose scale.
  * On the wire, just use the `big.Int` serialization.

This two points are relevant to the part 2 PR: https://github.com/lightninglabs/taproot-assets/pull/1141
This PR doesn't include any any RFQ wire messages changes.

For the RPC interface, write the scale and coefficient values a strings.

This change is included in this PR.

Reviewed 30 of 30 files at r1, 1 of 29 files at r4.
Reviewable status: 2 of 30 files reviewed, 27 unresolved discussions (waiting on @ffranr)

rpcserver.go line 7174 at r4 (raw file):

	// Convert the asset amount into a fixed-point.
	assetAmount := rfqmsg.NewBigIntFixedPoint(req.AssetAmount, 0)

This should be using the decimal display of the given asset.
rfq/order.go line 128 at r4 (raw file):

	// Check that the HTLC amount is not greater than the negotiated maximum
	// amount.
	maxAssetAmount := rfqmsg.NewBigIntFixedPoint(c.MaxAssetAmount, 0)

Same here, should be using the proper scale value (from the decimal display).

@Roasbeef
In both of these comments I think you're asking me to construct the fixed-points using the asset's decimal display (instead of just using a scale of 0 and setting the coefficient directly).
I don't see why we should care about the decimal display value here. The value of the fixed-points remains the same, and the calculation is unaffected. Looking up the decimal display introduces a potential for error.

I think our confusion might come down to how we define fields. Consider this part of the code which is contentious:
	// Check that the HTLC amount is not greater than the negotiated maximum
	// amount.
	maxAssetAmount := rfqmath.NewBigIntFixedPoint(c.MaxAssetAmount, 0)

	maxOutboundAmount := rfqmath.UnitsToMilliSatoshi(
		maxAssetAmount, c.AskAssetRate,
	)

From my POV:

maxAssetAmount is in asset units uint64 (with not scaled down for decimal display in the UI). This isn't a cent float value. It is a fixed-point with coefficient c.MaxAssetAmount and scale 0.

c.AskAssetRate this is the asset units to BTC rate. It is not the same as the cents to BTC rate. It is the number of asset units per BTC. Before displaying this in a UI it would need to be scaled with decimal display.

maxOutboundAmount is in msats.


fix typo: base on -> based on

Describe what this patch does to fix the issue.
Link to any relevant issues or pull requests.

Thank you for the contribution!


Feat icons

name: 'Pull request'
about: A new pull request
New Pull Request
Checklist

[x] I am not disclosing a vulnerability.
[x] My code is conform the code style
[x] I have made corresponding changes to the documentation
[x] I have updated Typescript definitions when needed

Issue Description

Related issue: #752
Solution Description

Added multiple icons
And fixed existing icons svg
Fixed icon sizes in components in core and web3

@BillyG83 Only new icons added and existing icons sizes fixed in components
Merging this to check release action 🙌🏻


Unable to load Stock

Hi there,
I am facing an exception when running the test.py file which comes with the project.
Exception has occurred: BadRequest
400 Error while reading table: stocks, error message: CSV table references column position 7, but line starting at position:40 contains only 1 columns.

Location: US
Job ID: 73f41e76-e30d-45a3-b7fb-922682639401
  File "C:\Solus\googlefinance-sheets\gfs\google_finance.py", line 700, in gs_stocks
    stocks = list(query_job)  # Wait for the job to complete.
  File "C:\Solus\googlefinance-sheets\gfs\google_finance.py", line 827, in retrieve_stocks
    stocks = gs_stocks(path2json_service=path2json_service, bucket_name=bucket_name, table_id=table_id, fields="*", conds=conds)
  File "C:\Solus\googlefinance-sheets\test.py", line 21, in <module>
    stocks = google_finance.retrieve_stocks(

I can see that the Sheet is created in my Google Drive, and currently it is an empty sheet. I can't work out what may be going wrong here, do you have any suggestions?
Thanks

@mpainenz, sorry for the late response. COVID finally got me.
Yes, few questions/ideas.
The sheet was created so permissions should be ok. Filling the sheet might be the problem because it tries to read data but finds nothing at all. Let see if it is pointing to the right file in the drive.

The script empties the Google sheet before dumping new data. If the API fails to fill the sheet, you will find it empty. Can you see if the sheet history displays any activity please.
The error might come from versions differences. Which python version are you using? I will replicate you stack, saw in the other issue you are on windows. Can you paste your requirements please?

Hi @rolozanod
Thanks for getting back to me, and sorry to hear about the COVID.
I'm on Python 3.10.4
My requirements output is quite long from pip freeze, but the ones that I have which are in the requirements.txt file from this project, match exactly the requirements.txt file from the project :
pandas==1.4.2 google-api-core==2.7.1 google-api-python-client==2.43.0 google-auth==2.6.0 google-auth-httplib2==0.1.0 google-auth-oauthlib==0.4.6 google-cloud-bigquery==3.0.1 google-cloud-bigquery-storage==2.13.1 google-cloud-core==2.2.3 google-cloud-storage==2.2.1 google-crc32c==1.3.0 google-pasta==0.2.0 google-resumable-media==2.3.2 googleapis-common-protos==1.56.0
In the sheet history, there is nothing other than the initial creation of the Sheet, and any manual troubleshooting changes I've made.
Would the terraform_setup function initially create data in the sheet? Where could I look at the code which updates the contents of the sheet? I did look around quite a bit, but I wasn't able to find it.
Could you perhaps point me to where to look at the part which writes to the Google Sheet initially? I'm still trying to understand how the data flows from Sheet, to Bigquery etc.
Thanks again,
Mark

Hi @mpainenz, just uploaded a version with documented manual instructions.
Under the README file there are two options for the GCP setup.
Please follow the manual setup instructions. It worked for me, please let me know anything you need.
Sorry for the delay.