Vite: build errors when non-server-only exports contain server-only code

What version of Remix are you using?
2.2.0
Are all your remix dependencies & dev-dependencies using the same version?

[X] Yes

Steps to Reproduce
Create a route with a handle that includes a function that relies on server-only code:
import { doServerStuff } from "~/do-server-stuff.server.ts"

export const handle = () => {
  value: 1,
  onlyCallThisFromServer: () => doServerStuff("wow")
}

In the client build, do-server-stuff.server.ts will be an empty module, but handle won't get treeshaken nor DCE'd. And it shouldn't be! value may still be used/needed for the client build.
Expected Behavior
There's some way to include server-only functions within handle without client build failing.
Actual Behavior
In the client build, do-server-stuff.server.ts will be an empty module, but handle won't get treeshaken nor DCE'd. And it shouldn't be! value may still be used/needed for the client build.
But this causes client build to fail with an error that do-server-stuff.server doesn't export doServerStuff.

A workaround might be to use Vite's import.meta.env.SSR:
import { doServerStuff } from "~/do-server-stuff.server.ts"

export const handle = () => {
  value: 1,
  onlyCallThisFromServer: import.meta.env.SSR ? () => doServerStuff("wow") : null,
}

But haven't tested if the SSR part of the ternary gets DCE'd by Vite or not at compile time.

I tested both of these and they did not work for me. I'm still getting:
[vite]: Rollup failed to resolve import "~/utils/mdx.server.tsx" from "/Users/kentcdodds/code/kentcdodds.com/app/routes/blog_+/$slug.tsx".
This is most likely unintended because it can break your application at runtime.
If you do want to externalize this module explicitly add it to
`build.rollupOptions.external`
error during build:
Error: [vite]: Rollup failed to resolve import "~/utils/mdx.server.tsx" from "/Users/kentcdodds/code/kentcdodds.com/app/routes/blog_+/$slug.tsx".
This is most likely unintended because it can break your application at runtime.
If you do want to externalize this module explicitly add it to
`build.rollupOptions.external`
    at viteWarn (file:///Users/kentcdodds/code/kentcdodds.com/node_modules/vite/dist/node/chunks/dep-bb8a8339.js:48216:27)
    at onRollupWarning (file:///Users/kentcdodds/code/kentcdodds.com/node_modules/vite/dist/node/chunks/dep-bb8a8339.js:48248:9)

I commented something similar previously in https://github.com/remix-run/remix/issues/7864#issuecomment-1790039032.
Currently server only files are transformed to export default {}, so during dev, the import statement is "statically" rejected by browsers:
import {doServerStuff} from "/app/server-only.server.ts"
//  Uncaught SyntaxError: The requested module '/app/server-only.server.ts' does not provide an export named 'doServerStuff' (at test1.tsx:2:10)

So, in order to "cheat" this static error, I suggested this as a workaround:
import * as serverLib from '../server-only.server';

export const handle = {
  value: 1,
   // runtime error if it called on client since `serverLib = { default: {} }`
  onlyCallThisFromServer: () => serverLib.doServerStuff('wow'),
};

I made this reproduction on stackblitz:
https://stackblitz.com/edit/remix-run-remix-dd56g3?file=app%2Froutes%2Ftest1.tsx
(Btw, I recently learned that stackblitz can run vite app from github, for example, by https://stackblitz.com/fork/github/remix-run/remix/tree/main/templates/unstable-vite which is so cool!)
I think import.meta.env.SSR based tree-shaking should work but only for vite build, so during dev, some workaround is probably required to support this use case.
I'm not sure if it's possible to expand remix's "remix-remove-server-exports" plugin to achieve this somehow, but I think another direction of the fix would be to improve "remix-empty-server-modules" plugin to do be aware of named exports.
For example, instead of emptifying to export default {}, it could analyze exported names and transform it to export const doServerStuff = {} etc...
I had this idea before and I made a simple vite plugin with es-module-lexer here, but I haven't tested with remix plugin.
https://github.com/hi-ogawa/vite-plugins/blob/main/packages/vite-null-export
It might not work with remix plugin directly since it has some intricate pre/post phases.
Also another concern was that it might expose the export name doServerStuff on client bundle, but this may be mitigated by switching back to export default {} for vite build.

I think this is the same issue: https://github.com/remix-run/remix/issues/7931

Similar tree-shaking related issue happens for client-only code as well: https://github.com/remix-run/remix/issues/7972

@kentcdodds I think your issue is that ~/utils/mdx.server.tsx indeed does not exist. Should be ~/utils/mdx.server.ts.

Addressed by #8198

For onlookers, there are two separate cases that cause server-only code issues like this:

User-defined route exports that reference server-only code (#7864)
Referencing server-only code from client-safe route exports like handle (this issue)

Vite forced our hand to be stricter about what exports can be allowed for Remix routes, so user-defined exports from Remix routes are now considered invalid at build time, addressing (1). See #7864 for more details on that.
For (2), you can use dynamic exports as an escape hatch. For example, with handle, you can create an entry that is a function you'll only call on the server that dynamically imports server-only dependencies (#8198). This isn't something the vast majority of users will need, but its there if you need it. Just be careful, its a sharp knife.


Compile error - promise

What version of RN and react-native-fcm are you running?
RN: 0.56.0 / React-Native-FCM: 16.2.1
What device are you using? (e.g iOS9 emulator, Android 6 device)?
Android 8.0 device
Is your app running in foreground, background or not running?
Not compiling

When I create an react native app with react-native init and add react-native-fcm with npm, I cannot compile the projet with react-native run-android
Logs:
:react-native-fcm:compileReleaseJavaWithJavac - is not incremental (e.g. outputs have changed, no previous execution, etc.).
/home/arthur/Documents/node/react-native/ReactNotifTest2/node_modules/react-native-fcm/android/src/main/java/com/evollu/react/fcm/FIRMessagingModule.java:217: error: cannot find symbol
            promise.resolve(null);
            ^
  symbol:   variable promise
  location: class FIRMessagingModule
/home/arthur/Documents/node/react-native/ReactNotifTest2/node_modules/react-native-fcm/android/src/main/java/com/evollu/react/fcm/FIRMessagingModule.java:220: error: cannot find symbol
            promise.reject(null,e.getMessage());
            ^
  symbol:   variable promise
  location: class FIRMessagingModule
/home/arthur/Documents/node/react-native/ReactNotifTest2/node_modules/react-native-fcm/android/src/main/java/com/evollu/react/fcm/FIRMessagingModule.java:228: error: cannot find symbol
            promise.resolve(null);
            ^
  symbol:   variable promise
  location: class FIRMessagingModule
/home/arthur/Documents/node/react-native/ReactNotifTest2/node_modules/react-native-fcm/android/src/main/java/com/evollu/react/fcm/FIRMessagingModule.java:231: error: cannot find symbol
            promise.reject(null,e.getMessage());
            ^
  symbol:   variable promise
  location: class FIRMessagingModule
Note: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
4 errors
:react-native-fcm:compileReleaseJavaWithJavac FAILED

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':react-native-fcm:compileReleaseJavaWithJavac'.
> Compilation failed; see the compiler error output for details.

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.

BUILD FAILED

Step to reproduce:

react-native init {name}
npm i --save react-native-fcm
react-native link
react-native run-android

Ps: I'm a newbie to react native and firecloud

This change came from version 16.2.1....
You can fix that by changing your dependency in your package.json : "react-native-fcm" : "16.2.0" (important : remove the ^ to force this exact version)

@wynch Thank you that worked.

@wynch Thanks a lot, it works now

Is this normal ?

fixed in 16.2.2


Teams Web Logs collection fails when logs are generated within a folder

When Teams Web Logs are generated in a folder in the Downloads folder, the script fails to copy the individual log files (and thus does not copy them at all).
Adding a "-Recurse" at line 779 fixes the issue:
$FileResult = (Get-ChildItem $FolderPath -Recurse | Where-Object { $_.Name -match "MSTeams Diagnostics"  -and $_.LastWriteTime -gt (get-date).AddMinutes(-2)})

Thanks, yes they added more structure to the output folders which was not handled.
I've just pushed a new version which should resolve this.

Resolved with version 1.0.2104.1501


Make A Script (in any lanugange) in the microservice dir to check update times

We need to check the latency for the blue star alliance so i want you to make an script were when the match end you run  it and it check if the data has been updated. If the data has been updated then it will end and show the time it took for the thing to update. Try to get 5 -10 matches and average the latency. This is due by on Friday and will be used Saturday.

We need this done soon


Missing Laravel files to be ignored

Ignorable files according to the latest version of Laravel.
Just copied the missing lines from the Laravel out of the box .gitignore file.

Codecov Report

Merging #308 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           master   #308   +/-   ##
=====================================
  Coverage     100%   100%
=====================================
  Files          18     18
  Lines         381    381
=====================================
  Hits          381    381

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ffb5cf3...406802d. Read the comment docs.

I figured out that we just needed to update the submodule.  I might create a daily task which attempt to update the submodule  automatically.


Selenoid Android: can't start session - wait: http://<IP_ADDRESS>:4444/wd/hub does not respond in 30s

Hi, I'm trying to start Android emulator in docker and my setup is the following:
Base OS: MacOS Catalina 10.15.7
Docker version 20.10.2, build 2291f61
browser.json:
{
  "android": {
    "default": "10.0",
    "versions": {
      "10.0": {
        "image": "selenoid/android:10.0",
        "port": "4444",
        "path": "/wd/hub",
        "selenoid:options": {
          "enableVNC": true,
          "enableVideo": true
        }
      }
    }
  }
}

docker-compose.yml:
version: '3'
services:
  selenoid:
    image: "aerokube/selenoid"
    network_mode: bridge
    ports:
      - "4444:4444"
    volumes:
      - "$PWD/config:/etc/selenoid/" # assumed current dir contains browsers.json
      - "/var/run/docker.sock:/var/run/docker.sock"
      - "$PWD/video:/opt/selenoid/video"
      - "$PWD/logs:/opt/selenoid/logs"
    environment:
      - OVERRIDE_VIDEO_OUTPUT_DIR=$PWD/video
    command: ["-conf", "/etc/selenoid/browsers.json", "-video-output-dir", "/opt/selenoid/video", "-log-output-dir", "/opt/selenoid/logs"]
  selenoid-ui:
    image: "aerokube/selenoid-ui"
    network_mode: bridge
    links:
      - selenoid
    ports:
      - "8080:8080"
    command: ["--selenoid-uri", "http://selenoid:4444"]

So, when I open SelenoidUI at http://localhost:8080/#/capabilities/ and click "Create Session", the request fails with the error:
POST http://localhost:8080/wd/hub/session
status code 500  Internal Server Error
Response Body:
{"status":13,"value":{"message":"wait: http://<IP_ADDRESS>:4444/wd/hub does not respond in 30s"}}
More info:
docker ps -a
CONTAINER ID   IMAGE                  COMMAND                  CREATED          STATUS                    PORTS                    NAMES
a823c23ffd9d   aerokube/selenoid-ui   "/selenoid-ui --sele…"   34 minutes ago   Up 34 minutes (healthy)   <IP_ADDRESS>:8080->8080/tcp   selenoid-android_selenoid-ui_1
9a0f732951c1   aerokube/selenoid      "/usr/bin/selenoid -…"   34 minutes ago   Up 34 minutes             <IP_ADDRESS>:4444->4444/tcp   selenoid-android_selenoid_1

 docker image list -a
REPOSITORY             TAG              IMAGE ID       CREATED         SIZE
aerokube/selenoid      latest           c0ab90eb2ac0   2 weeks ago     16.8MB
aerokube/selenoid      latest-release   c0ab90eb2ac0   2 weeks ago     16.8MB
aerokube/selenoid-ui   latest           800e1f3d15fa   4 weeks ago     17.5MB
selenoid/android       10.0             78cbc1c22916   4 months ago    9.33GB
selenoid/android       7.0              0acd62321707   4 months ago    7.09GB

selenoid logs:
docker logs 9875f35a5a41
2021/02/04 17:51:44 [-] [INIT] [Loading configuration files...]
2021/02/04 17:51:44 [-] [INIT] [Loaded configuration from /etc/selenoid/browsers.json]
2021/02/04 17:51:44 [-] [INIT] [Video Dir: /opt/selenoid/video]
2021/02/04 17:51:44 [-] [INIT] [Logs Dir: /opt/selenoid/logs]
2021/02/04 17:51:44 [-] [INIT] [Your Docker API version is 1.41]
2021/02/04 17:51:44 [-] [INIT] [Timezone: UTC]
2021/02/04 17:51:44 [-] [INIT] [Listening on :4444]
2021/02/04 17:51:58 [-] [NEW_REQUEST] [unknown] [<IP_ADDRESS>]
2021/02/04 17:51:58 [-] [NEW_REQUEST_ACCEPTED] [unknown] [<IP_ADDRESS>]
2021/02/04 17:51:58 [3] [LOCATING_SERVICE] [android] [10.0]
2021/02/04 17:51:58 [3] [USING_DOCKER] [android] [10.0]
2021/02/04 17:51:58 [3] [CREATING_CONTAINER] [selenoid/android:10.0]
2021/02/04 17:51:58 [3] [STARTING_CONTAINER] [selenoid/android:10.0] [142d98e040eb00a7c572bfd9de19cb66eebf2b2753259942ccfc17976cd32bc4]
2021/02/04 17:51:58 [3] [CONTAINER_STARTED] [selenoid/android:10.0] [142d98e040eb00a7c572bfd9de19cb66eebf2b2753259942ccfc17976cd32bc4] [0.29s]
2021/02/04 17:52:28 [3] [REMOVING_CONTAINER] [142d98e040eb00a7c572bfd9de19cb66eebf2b2753259942ccfc17976cd32bc4]
2021/02/04 17:52:28 [3] [CONTAINER_REMOVED] [142d98e040eb00a7c572bfd9de19cb66eebf2b2753259942ccfc17976cd32bc4]
2021/02/04 17:52:28 [3] [SERVICE_STARTUP_FAILED] [wait: http://<IP_ADDRESS>:4444/wd/hub does not respond in 30s]

What am I doing wrong?

Update:
I've tried to add option
-service-startup-timeout 2m
But it didn't help, the error now is the same:
wait: http://<IP_ADDRESS>:4444/wd/hub does not respond in 2m0s

Ok we can close the issue, I've found the following error in android docker container:
emulator: ERROR: x86 emulation currently requires hardware acceleration!
CPU acceleration status: KVM requires a CPU that supports vmx or svm

adb: no devices/emulators found
adb: no devices/emulators found
adb: no devices/emulators found
adb: no devices/emulators found

It looks like my configuration doesn't support hardware acceleration for the emulator.

@TimurNurlygayanov Android images will not work under Mac because Docker for Mac does not forward KVM capabilities of the CPU.

@vania-pooh I noticed that SelenoidUI doesn't show any errors in case solenoid can't start the session, and the user has to check the dev console to see the error message from the backend. Maybe we can improve UX and add some information about error messages to Selenoid WebUI? (so it is not urgent)


Hyphens and Incorrect Rendering on Tab

Checklist

[x] I have read the tutorials and know the correct effect of the functional design.
[x] There are no similar question on existing issues (including closed ones).
[x] I searched the Internet for related problems, but still couldn't solve it.
[x] My question is based on the latest code of master branch.

Description

Since a few days ago, the tab would start to render hyphens and failed to render the Japanese characters correctly. If there a way to fix this?
Source code on https://github.com/animeaudioarchive/animeaudioarchive.github.io

Do not use cjk file name such as 日本語.md, just japanese.md and use title: 日本語 on front matter.

CJK filenames rendered fine 11 days ago and I want native speakers to be able to read in kanji. Furthermore, this doesn't solve the hyphen issue.

Furthermore, this doesn't solve the hyphen issue.

No, it works well.

Sorry for my mistakes.
Here is a non-compatible update "Add layout localization" which was commited 8 days ago. In this commit, the theme turned to use data/locales/[lang].yml for localization. You need to write a ja.yaml based on en.yml and add your tabs into this file, and then use lang: ja at _config.yml.

Got it. I'll apply changes and report back.

Issue fixed. Thanks a lot!


jdbc pseudo coroutines

Add a coroutines pseudo implementation to kotysa-jdbc.
This means that single actions will correctly be suspend functions, but a select returning several results would return a suspend List<T> instead of a Flow<T> in a full coroutines world.
Note : This module would use or be inspired by kotlin-coroutines-jdbc

After thinking, add a new Kotysa API to existing blocking, reactive and coroutines would be confusing.
I prefer staying with current APIs.


Key Manager Runtime with DCR APIs

Description:
A new runtime need to be plugged in for authentication/key management purposes.
Initial implementation with DCR/DCRM APIs.
Suggested Labels:

Suggested Assignees:

Affected Product Version:
OS, DB, other environment details and versions:
Steps to reproduce:
Related Issues:

DCR feature included in https://github.com/wso2/product-apim/pull/2026

Documentation https://docs.google.com/document/d/1RivUeiwiWZT2hhjk_jNuATBuZrHTQfQSMioaJoCZIJU/edit?usp=sharing


librealsense ROS Wrapper kernel patch failed on IntelAero

Required Info

Camera Model
D415, D435

Firmware Version
<IP_ADDRESS>

Operating System & Version
Ubuntu 16.04

Kernel Version (Linux Only)
4.4.76-aero-1.2

Platform
Intel Aero

SDK Version
{ master / 2.0.3 }

Language
C++

Segment
Drone

Issue Description
I have experienced a similar issue as described in #1320 . I followed the instructions under ROS wrapper to install the ROS wrapper. But I got an error when executing the kernel patch script with
./scripts/patch-realsense-ubuntu-lts.sh. This is probably because the script is for an Ubuntu 16.04 LTS kernel and I have the already patched Aero kernel. I can still launch the Realsense Camera and get all the data. But the incorrectly (or not at all) patched kernel causes the realsense node to throw the following warning:
26/06 15:45:18,160 WARNING [139849831933824] (backend-v4l2.cpp:486) Failed to read busnum/devnum. Device Path: /sys/dev/char/81:11/device/../../../../../../../../../../
26/06 15:45:18,160 WARNING [139849831933824] (backend-v4l2.cpp:486) Failed to read busnum/devnum. Device Path: /sys/dev/char/81:12/device/../../../../../../../../../../
26/06 15:45:18,160 WARNING [139849831933824] (backend-v4l2.cpp:486) Failed to read busnum/devnum. Device Path: /sys/dev/char/81:13/device/../../../../../../../../../../
26/06 15:45:18,161 WARNING [139849831933824] (backend-v4l2.cpp:486) Failed to read busnum/devnum. Device Path: /sys/dev/char/81:14/device/../../../../../../../../../../
26/06 15:45:18,161 WARNING [139849831933824] (backend-v4l2.cpp:486) Failed to read busnum/devnum. Device Path: /sys/dev/char/81:15/device/../../../../../../../../../../
26/06 15:45:18,161 WARNING [139849831933824] (backend-v4l2.cpp:486) Failed to read busnum/devnum. Device Path: /sys/dev/char/81:16/device/../../../../../../../../../../
26/06 15:45:18,162 WARNING [139849831933824] (backend-v4l2.cpp:486) Failed to read busnum/devnum. Device Path: /sys/dev/char/81:17/device/../../../../../../../../../../
26/06 15:45:18,162 WARNING [139849831933824] (backend-v4l2.cpp:486) Failed to read busnum/devnum. Device Path: /sys/dev/char/81:18/device/../../../../../../../../../../
26/06 15:45:18,162 WARNING [139849831933824] (backend-v4l2.cpp:486) Failed to read busnum/devnum. Device Path: /sys/dev/char/81:19/device/../../../../../../../../../../
26/06 15:45:18,163 WARNING [139849831933824] (backend-v4l2.cpp:486) Failed to read busnum/devnum. Device Path: /sys/dev/char/81:0/device/../../../../../../../../../../
26/06 15:45:18,163 WARNING [139849831933824] (backend-v4l2.cpp:486) Failed to read busnum/devnum. Device Path: /sys/dev/char/81:1/device/../../../../../../../../../../
26/06 15:45:18,163 WARNING [139849831933824] (backend-v4l2.cpp:486) Failed to read busnum/devnum. Device Path: /sys/dev/char/81:2/device/../../../../../../../../../../
26/06 15:45:18,163 WARNING [139849831933824] (backend-v4l2.cpp:486) Failed to read busnum/devnum. Device Path: /sys/dev/char/81:3/device/../../../../../../../../../../
26/06 15:45:18,164 WARNING [139849831933824] (backend-v4l2.cpp:486) Failed to read busnum/devnum. Device Path: /sys/dev/char/81:4/device/../../../../../../../../../../
26/06 15:45:18,164 WARNING [139849831933824] (backend-v4l2.cpp:486) Failed to read busnum/devnum. Device Path: /sys/dev/char/81:5/device/../../../../../../../../../../
26/06 15:45:18,164 WARNING [139849831933824] (backend-v4l2.cpp:486) Failed to read busnum/devnum. Device Path: /sys/dev/char/81:6/device/../../../../../../../../../../
26/06 15:45:18,165 WARNING [139849831933824] (backend-v4l2.cpp:486) Failed to read busnum/devnum. Device Path: /sys/dev/char/81:7/device/../../../../../../../../../../
26/06 15:45:18,165 WARNING [139849831933824] (backend-v4l2.cpp:486) Failed to read busnum/devnum. Device Path: /sys/dev/char/81:8/device/../../../../../../../../../../
26/06 15:45:18,165 WARNING [139849831933824] (backend-v4l2.cpp:486) Failed to read busnum/devnum. Device Path: /sys/dev/char/81:9/device/../../../../../../../../../../
26/06 15:45:18,166 WARNING [139849831933824] (backend-v4l2.cpp:486) Failed to read busnum/devnum. Device Path: /sys/dev/char/81:10/device/../../../../../../../../../../
This warning is somehow logged in the system log of the OS causing the log to build up and fill all the memory (in a matter of about 5min). Also the logging needs about 70% of the CPU power of the Intel Atom board.
Is there a possibility to provide a kernel patching script for the Intel Aero kernel (4.4.76-aero-1.2), to correctly install the ROS wrapper?

[Realsense Customer Engineering Team Comment]
Hi @baumanta,
Please check if you install Intel Realsense permission scripts located in librealsense source directory:
sudo cp config/99-realsense-libusb.rules /etc/udev/rules.d/
sudo udevadm control --reload-rules && udevadm trigger
If not, please install that. Then, reboot the system and try again.

I followed the instructions step by step. I did install the permission scripts under step 3 before trying to patch the kernel

[Realsense Customer Engineering Team Comment]
HI @baumanta,
If you think below warning message "Failed to read busnum/devnum ..." affects your system performance. You can try to comment out the debug log in "backend-v4l2.cpp", and rebuild librealsense.
// LOG_WARNING("Failed to read busnum/devnum. Device Path: " << path);
Let me know how this works.

[Realsense Customer Engineering Team Comment]
Hi @baumanta,
Any update? Still need any support for this topic?

We decided to not further use Intel Aero with the D415. Therefore, the problem is not relevant for me anymore. But if the Intel Aero should be compatible with the new Realsense generation, I would suggest providing a file to properly patch the Aero kernel.

[Realsense Customer Engineering Team Comment]
Ok, @baumanta, Thanks for the suggestion. We will try to support more platforms.

[Realsense Customer Engineering Team Comment]
D415/D435 camera + librealsense 2.15.0 + FW 5.10.3 can stream well as a USB2 device on Aero board + Ubuntu 16.04 + Kernel 4.13.0-36.
Don't need to apply the patch manually. Just install the DKMS pre-built package.
$ sudo apt install librealsense2-dkms


BUG: check if vtrype is not INVALID

BUG: Only access the value of si , if vrtype is not invalid. This prevents a SegmentationFault in the case of an invalid tag

PR Checklist

[x] No API changes were made (or the changes have been approved)
[x] No major design changes were made (or the changes have been approved)
[x] Added test (or behavior not changed)
[x] Updated API documentation (or API not changed)
[ ] Added license to new files (if any)
[ ] Added Python wrapping to new files (if any) as described in ITK Software Guide Section 9.5
[ ] Added ITK examples for all new major features (if any)

Refer to the ITK Software Guide for
further development details if necessary.

@mrc-sys Thanks for contributing to ITK :100: !
Can you please remove commit 4ed3b6fd187a733761217a4cbb52e9b81972f55d in the branch, as it is a duplicate of the latter b300ae27ad7e11e8b65c924fe1a6e5cd6d504046, this one having the appropriate style for an ITK commit? Thanks !

@mrc-sys Thanks for contributing to ITK 100 !
Can you please remove commit 4ed3b6f in the branch, as it is a duplicate of the latter b300ae2, this one having the appropriate style for an ITK commit? Thanks !

Can you describe me, how to remove the commit? I am happy to get the later commit in the appropriate style....

You're avoiding a segfault by hiding the symptoms. I suspect this creates an empty Data Element, this is not a desired behavior AFAIK.
If it´s possible to avoid the crash in a better way, I would prefer the better solution. But for now I have not found this better solution and this segfault is a showstopper for me.

Can you describe me, how to remove the commit? I am happy to get the later commit in the appropriate style....

You should rebase interactively using git rebase -i HEAD~2 then mark the commit to be deleted with d (for drop), exit with :wq, then continue the rebase with git rebase --continue, and it should be fine. Then you would git push -f origin {your_branch_name} to push to the repository.

Can you describe me, how to remove the commit? I am happy to get the later commit in the appropriate style....

You should rebase interactively using git rebase -i HEAD~2 then mark the commit to be deleted with d (for drop), exit with :wq, then continue the rebase with git rebase --continue, and it should be fine. Then you would git push -f origin {your_branch_name} to push to the repository.

Can this be done in the github web-gui too?

@mrc-sys

If it´s possible to avoid the crash in a better way, I would prefer the better solution. But for now I have not found this better solution and this segfault is a showstopper for me.

You'll need to provide us more detail on how to reproduce the segfault. Or simply dump part of the backtrace (eg. 'bt' under gdb).

I don't think rebase can be done in GitHub WebUI. But it can be done in e.g. TortoiseGit and gitk.

@mrc-sys

If it´s possible to avoid the crash in a better way, I would prefer the better solution. But for now I have not found this better solution and this segfault is a showstopper for me.

You'll need to provide us more detail on how to reproduce the segfault. Or simply dump part of the backtrace (eg. 'bt' under gdb).

I will try to reproduce the error again, but I have patched ITK 4.13.1 about 4 years ago (ubuntu 16.04) and the bug popped up again on porting our application to ubuntu 20.04 and ITK 4.13.3. As the patch solved the problem again and the source was not changed in the meantime, I have not tested without the patch again.

Addressing style issues


WS_HV scripts problem

Hi,
I have some problem with understanding your code.
I want to know the reason of  interpolating images(lines 73->88)  and change size of images (lines 47->71).
Thank you for your consideration,

Thank you so much for your response


[Feature]: SIgnup with google

🚀 Feature Request
📝 Feature Description
Adding google signup so that users can signup the website directly with google.
🔧 How Will This Enhance the App?
since the frontend is there, I want to integrate its backend and complete functioning.
🎯 Use Cases

📦 Suggested Implementation

📸 Additional Context

🚀 Feature Request
📝 Feature Description
Adding google signup so that users can signup the website directly with google.
🔧 How Will This Enhance the App?
since the frontend is there, I want to integrate its backend and complete functioning.
🎯 Use Cases
📦 Suggested Implementation
📸 Additional Context

Okay.All the Best!!


idsvr cookie vs sessionStorage cookie

After successfully implementing this incredibly lib and stack I notice the idsvr cookies being saved/used.  I have a requirement to allow unique logins per tab in the browser and the cookies contaminate the identity on second and later tabs. I believe this would work if the info in the cookie could instead be saved in sessionStorage and isolated per tab.  Is there any way to do this with oidc-client or idsvr using current code? Ideas on how this could be implemented?  Thanks in advance.

Actually I may have been mistaken.  Is LocalStorage persisting the user between tabs in the case of Oidc?  Noticed four entries in LocalStorage persisting between tabs. It would be my preference to login --> save any necessary things in sessionStorage for refreshes --> removed entirely upon tab in browser closing.

IdentityServer uses cookies, yes -- that's how SSO works.
oidc-client uses localStorage to persist the state required for handling the OIDC request/response. Once the signin has been completed, it uses sessionStorage to persist the user profile, tokens, etc.

Brock....that is exactly my issue and would love to see that feature come to existence.  I'm essentially looking for an isolated implementation where a call is made from a session and all necessary items self-contained in sessionStorage so it self-destructs on close of the browser tab and no identity contamination.  Tidy and keeps the boundaries.  Happy to test it with the code I have built if necessary. Thanks so much for your help and rescuing my sanity.

I'll close this here, since your requirement is unrelated to this library.


Add system prompt words and do not reply.

v0.3.34
Only secure origins are allowed (see: https://permanently-removed.invalid/Y0ZkNV).

use http bad   use https is ok


Add support for limit parameter in paginator

We currently limit users of the client to pages of size 10.

@DavidHuie the limit set in the initial request when starting pagination is retained when results are paginated, how would you like to see this implemented?
Currently:
response = client.call(:people, :index, limit: 100)
page1 = NationBuilder::Paginator.new(client, response)
page1.body['results'].count
=> 100
page2 = page1.next
page2.body['results'].count
=> 100

I don't think this is necessary, actually. Once you've set the limit in the original call, I don't think you can change the page size anymore (@aq1018 can correct me).

I think @codealchemy wants to retain pagination data when calling pages repeatedly.

@aq1018 @DavidHuie is this good to close?

@codealchemy I think that's up to you.

I stand corrected: the limit can be changed in subsequent pagination calls. I think a nice API for this looks like this:
page2 = page1.next(limit: 100)

The built-in CGI library can parse the query string. For converting back to a query string, you can follow these steps: http://stackoverflow.com/a/11251654


Adds Violations Requirements to MoneyRequestConfirmationList

Details

Fixed Issues

$ https://github.com/Expensify/App/issues/31090
PROPOSAL:
Tests

[ ] Verify that no errors appear in the JS console
[ ] Set the canUseViolations Permissions to true

If you have Tags and/or Categories enabled on your policy

[ ] Begin creating a new Money Request
[ ] Continue through steps until you reach the Confirmation Screen
[ ] Tap the drop down button
[ ] Verify you see the Required tag beside the correct menu items

If you do not have the policy requirements

[ ] In MoneyRequestConfirmationList, set shouldShowTags and shouldShowCategories to true
[ ] In the same file, in the respective MenuItems set the Boolean(props.policy.requiresCategories and Boolean(props.policy.requiresTags) to true. (NOTE: because the normal guards have been disabled this will cause an error if not implemented correctly)
[ ] Begin creating a new Money Request
[ ] Continue through steps until you reach the Confirmation Screen
[ ] Tap the drop down button
[ ] Verify you see the Required tag beside the correct menu items

Offline tests

Same as Tests
QA Steps

Same as Tests
PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message: Slack Message

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

There might actually be a change of the word used in the label. Conversation happening in Slack: https://expensify.slack.com/archives/C01GTK53T8Q/p1700064505893339

@cdanwards can you update your tests and QA sections

Make it clear in the test section that all cases should be tested, ie, when neither category or tag is required, when both are required, and when only one is required
Add steps to configure the policy for the cases above. These settings can be configured in old dot, by going to

For categories: Settings > Workspaces > [the workspace] > Categories > Switch on the toggle "People must categorize expenses", and make sure there's at least 1 enabled category
For tags: Settings > Workspaces > [the workspace] > Tags > Switch on the toggle "People must tag expenses", and make sure there's at least 1 enabled tag ("Do you want to use multiple levels of" should be off

QA steps need to be doable by Applause, and they can't really set anything to return true -- they're running whatever code is on staging

@shawnborton can you please take a look and see if we need different styles on the Required text?

Yup, we do need some style adjustments. The text should be using our textSupporting color, and it should be in our label font size (13px).

Original screenshot for reference:

@cdanwards after pulling main, app crashes
 ERROR  ReferenceError: Property 'Permissions' doesn't exist

@situchan thanks for the review! I'll get it updated.

Reviewer Checklist

[x] I have verified the author checklist is complete (all boxes are checked off).
[x] I verified the correct issue is linked in the ### Fixed Issues section above
[x] I verified testing steps are clear and they cover the changes made in this PR

[x] I verified the steps for local testing are in the Tests section
[x] I verified the steps for Staging and/or Production testing are in the QA steps section
[x] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[x] I checked that screenshots or videos are included for tests on all platforms
[x] I included screenshots or videos for tests on all platforms
[x] I verified tests pass on all platforms & I tested again on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[x] I verified proper code patterns were followed (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I verified that this PR follows the guidelines as stated in the Review Guidelines
[x] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native
https://github.com/Expensify/App/assets/108292595/cbae2349-f413-4e23-8149-ce02e64c29d4

iOS: mWeb Safari
https://github.com/Expensify/App/assets/108292595/0a7c7d82-cb47-476d-9858-5f9ced7f6e78

MacOS: Chrome / Safari
https://github.com/Expensify/App/assets/108292595/870ab629-817d-4232-92bb-d20dc5502609

MacOS: Desktop
https://github.com/Expensify/App/assets/108292595/fe3be7df-3cfa-4624-92ff-ec25dd3f8a0d

🚀 Deployed to staging by https://github.com/cead22 in version: 1.4.2-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

Hello @cdanwards, can you please help us, where I can set the canUseViolations Permissions to true? Thank you

@izarutskaya apologies! If you're able to access the Permissions file, you can set the function to return true there. I'll update this in the comment above.

🚀 Deployed to production by https://github.com/luacmartins in version: 1.4.2-3 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Handle undefined source database name in restore dialog

When first switching to File mode in the Restore dialog, the loading spinner in the corner would keep running forever without any data showing up in the table. This is because an error was being thrown (from the ModelView code) due to an undefined value in the source database dropdown, and so resetting the loading state would get skipped. This change fixes that undefined string issue and also adds a try-finally block for the loading logic so it doesn't get stuck on error.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 41.759%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
30828

Relevant Lines:
69082

💛  - Coveralls


Unmarshal error returned without further context

Running swagger generate client on a spec which has passed swagger validate (At least, the command exited with no errors/output....) is resulting in the following:
$ swagger generate client -f swagger.json
json: cannot unmarshal bool into Go value of type string

Is there an easy way to see where this has been generated to work out what the problem is?

would it be possible to show me the spec?

this might be because of lack of a space between the colon after a key and the value
results in the error:
definitions:
  error:
    type: object
    required:
      - message
    properties:
      code:
        type: integer
        format: int64
      message:
        type:string

correct:
definitions:
  error:
    type: object
    required:
      - message
    properties:
      code:
        type: integer
        format: int64
      message:
        type: string

considering there was no answer for this long, I'm going to close this and assume there was a resolution.

Pardon my reopening an old issue! I've encountered this exact same problem. I'm getting the error message
2017/02/02 18:38:54 json: cannot unmarshal bool into Go value of type []string
and I've no idea what in the 5824 line yaml file is causing the error. Some debug output identifying approximately where go-swagger got to when the issue is encountered would be great.

run the generation process with: DEBUG=1 SWAGGER_DEBUG=1

the problem with line numbers and so on is not the problem in go-swagger it's with the stdlib json and go-yaml implementations.
if you're able to share the spec I may be able to help you out but for now we have no control over linenumbers and character positions because we are reliant on the way go's stdlib json library works. I'm open to any suggestions on making this better because I know it's a problem

Hi, thanks your help! I've actually found the issue by diffing the last commit. The problem was a definitions object which looked like this:
definitions:   MenuItem:     properties:       group_id:         type: integer         format: int64       item_position:         type: integer         format: int32       item_currency:         type: string         required: false
where the item_currency's required key is false. I think go-swagger was expecting a []string here and not a boolean.

Hello, I am facing a similar issue.
operation (CreateIssueRequest): no spec available to unmarshal
on running with this:

run the generation process with: DEBUG=1 SWAGGER_DEBUG=1

here is the output:
inferring for string with models at github.com/Evalyn-Kemunto/token-api/vendor/github.com/hyperledger/fabric-sdk-go/pkg/fab/events/service/dispatcher against github.com/Evalyn-Kemunto/token-api/models 2019/04/17 18:02:42 inferring for string with models at github.com/Evalyn-Kemunto/token-api/vendor/github.com/go-logfmt/logfmt against github.com/Evalyn-Kemunto/token-api/models 2019/04/17 18:02:42 inferring for string with models at vendor/golang_org/x/crypto/cryptobyte/asn1 against github.com/Evalyn-Kemunto/token-api/models 2019/04/17 18:02:42 inferring for string with models at github.com/Evalyn-Kemunto/token-api/vendor/golang.org/x/net/context against github.com/Evalyn-Kemunto/token-api/models 2019/04/17 18:02:42 inferring for string with models at github.com/Evalyn-Kemunto/token-api/vendor/google.golang.org/grpc/peer against github.com/Evalyn-Kemunto/token-api/models 2019/04/17 18:02:42 inferring for string with models at github.com/Evalyn-Kemunto/token-api/vendor/google.golang.org/grpc/connectivity against github.com/Evalyn-Kemunto/token-api/models 2019/04/17 18:02:42 inferring for string with models at github.com/Evalyn-Kemunto/token-api/vendor/google.golang.org/grpc/resolver against github.com/Evalyn-Kemunto/token-api/models 2019/04/17 18:02:42 inferring for string with models at github.com/Evalyn-Kemunto/token-api/vendor/golang.org/x/sys/unix against github.com/Evalyn-Kemunto/token-api/models 2019/04/17 18:02:42 inferring for string with models at github.com/Evalyn-Kemunto/token-api/vendor/github.com/prometheus/common/internal/bitbucket.org/ww/goautoneg against github.com/Evalyn-Kemunto/token-api/models 2019/04/17 18:02:42 inferring for string with models at github.com/Evalyn-Kemunto/token-api/vendor/github.com/hyperledger/fabric-sdk-go/pkg/fab/events/deliverclient/seek against github.com/Evalyn-Kemunto/token-api/models 2019/04/17 18:02:42 inferring for string with models at encoding/xml against github.com/Evalyn-Kemunto/token-api/models 2019/04/17 18:02:42 inferring for string with models at github.com/Evalyn-Kemunto/token-api/vendor/github.com/hyperledger/fabric-sdk-go/pkg/fab/events/service against github.com/Evalyn-Kemunto/token-api/models 2019/04/17 18:02:42 inferring for string with models at github.com/Evalyn-Kemunto/token-api/vendor/golang.org/x/crypto/pkcs12/internal/rc2 against github.com/Evalyn-Kemunto/token-api/models 2019/04/17 18:02:42 inferring for string with models at github.com/Evalyn-Kemunto/token-api/vendor/github.com/hashicorp/hcl/json/token against github.com/Evalyn-Kemunto/token-api/models 2019/04/17 18:02:42 inferring for string with models at github.com/Evalyn-Kemunto/token-api/vendor/golang.org/x/text/width against github.com/Evalyn-Kemunto/token-api/models 2019/04/17 18:02:42 inferring for string with models at runtime/debug against github.com/Evalyn-Kemunto/token-api/models 2019/04/17 18:02:42 inferring for string with models at github.com/Evalyn-Kemunto/token-api/vendor/github.com/hyperledger/fabric-sdk-go/pkg/common/providers/core against github.com/Evalyn-Kemunto/token-api/models 2019/04/17 18:02:42 inferring for string with models at crypto/sha256 against github.com/Evalyn-Kemunto/token-api/models 2019/04/17 18:02:42 inferring for string with models at github.com/Evalyn-Kemunto/token-api/vendor/golang.org/x/crypto/sha3 against github.com/Evalyn-Kemunto/token-api/models 2019/04/17 18:02:42 inferring for string with models at github.com/Evalyn-Kemunto/token-api/vendor/github.com/google/certificate-transparency-go/x509 against github.com/Evalyn-Kemunto/token-api/models 2019/04/17 18:02:42 inferring for string with models at github.com/Evalyn-Kemunto/token-api/models against github.com/Evalyn-Kemunto/token-api/models

required is not a boolean in json schema, it shouldn't have passed validation


Can't download youtube video

 youtube-dl -x --audio-format mp3 https://youtu.be/IW4_FBpYARA --verbose
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: ['-x', '--audio-format', 'mp3', 'https://youtu.be/vjOUrM8eL2E', '--verbose']
[debug] Encodings: locale UTF-8, fs utf-8, out utf-8, pref UTF-8
[debug] youtube-dl version 2021.12.17
[debug] Python version 3.10.6 (CPython) - Linux-6.2.6-76060206-generic-x86_64-with-glibc2.35
[debug] exe versions: ffmpeg 4.4.2, ffprobe 4.4.2
[debug] Proxy map: {}
[youtube] vjOUrM8eL2E: Downloading webpage
ERROR: Unable to extract uploader id; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; see  https://yt-dl.org/update  on how to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
Traceback (most recent call last):
  File "/home/ameen/.local/lib/python3.10/site-packages/youtube_dl/YoutubeDL.py", line 815, in wrapper
    return func(self, *args, **kwargs)
  File "/home/ameen/.local/lib/python3.10/site-packages/youtube_dl/YoutubeDL.py", line 836, in __extract_info
    ie_result = ie.extract(url)
  File "/home/ameen/.local/lib/python3.10/site-packages/youtube_dl/extractor/common.py", line 534, in extract
    ie_result = self._real_extract(url)
  File "/home/ameen/.local/lib/python3.10/site-packages/youtube_dl/extractor/youtube.py", line 1794, in _real_extract
    'uploader_id': self._search_regex(r'/(?:channel|user)/([^/?&#]+)', owner_profile_url, 'uploader id') if owner_profile_url else None,
  File "/home/ameen/.local/lib/python3.10/site-packages/youtube_dl/extractor/common.py", line 1012, in _search_regex
    raise RegexNotFoundError('Unable to extract %s' % _name)
youtube_dl.utils.RegexNotFoundError: Unable to extract uploader id; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; see  https://yt-dl.org/update  on how to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.

I can't download this video(actually with some videos) as mp4 or mp3. It is always showing can't extract uploader-id.

I'm having this same issue

#30839 !


Database.EnsureDeleted() much slower if database does not exist

On my machine EnsureDeleted() takes ~50ms to run if the database is present, and ~10100ms if the database does not exist. Seems like we should be able to optimize the no-op path a little.
using Microsoft.EntityFrameworkCore;
using System;
using System.Diagnostics;

namespace EFCore101
{
    class Program
    {
        static void Main(string[] args)
        {
            using (var db = new BloggingContext())
            {
                db.Database.EnsureCreated();

                var sw = new Stopwatch();

                sw.Start();
                db.Database.EnsureDeleted();
                sw.Stop();
                Console.WriteLine($"Database exists: {sw.ElapsedMilliseconds}ms");

                sw.Restart();
                db.Database.EnsureDeleted();
                sw.Stop();
                Console.WriteLine($"Database doesn't exist: {sw.ElapsedMilliseconds}ms");
            }
        }
    }

    public class BloggingContext : DbContext
    {
        public DbSet<Blog> Blogs { get; set; }

        protected override void OnConfiguring(DbContextOptionsBuilder optionsBuilder)
        {
            optionsBuilder.UseSqlServer(@"Server=(localdb)\mssqllocaldb;Database=Demo;Trusted_Connection=True;");
        }
    }

    public class Blog
    {
        public int BlogId { get; set; }
        public string Name { get; set; }
        public string Url { get; set; }
    }
}

@rowanmiller Do you see the same results if the second EnsureDeleted is not immediately after the first? It could be hitting exists check issues and re-trying.

Yep, I was seeing this in demos where the database hadn't existed for hours. I tried inverting the calls in the repro code too, and get the same results. It seems to be a pretty consistent 10sec overhead (at least on my machine)

Investigated this and found it is due to a new feature introduced to SqlClient that does retries on connection failures. By default, the ConnectRetryCount is set 1 and the ConnectRetryInterval is set to 10 seconds. This is transparent to us and cannot be changed publicly without creating a new connection string, which has its own issues such as losing credentials. Therefore, discussed with @rowanmiller, @divega, and @AndriySvyryd and decided that we will not make any changes to EF code.
The workaround for this issue is to add "ConnectRetryCount=0" to the SQL Server connection string. The original, faster behavior for exists should then be restored, with the understanding that there is also a greater chance that the database will not be deleted because the connection to it failed to open.


test: add blob read check

add read checks
add blob constructor from fileURL
blob from fileURL was not working, as the file loaded was empty and the exception was not failing. so refactored to make sure that reads the file and checks the code.

Coverage increased (+0.05%) to 75.268% when pulling dd234d029e9f1a51d9c0c2513776ff0974a8cbab on test/blobReadTests into e9ab0a40e3425f04d87a5cf8e8f9fe67a8014bdc on master.


DocsArchive-1.0.21075.1Auto archive content

Auto archive content from https://github.com/opstestprod1/E2E_DocsArchive_Prod.git

Docs Build status updates of commit 1a8f5c8:
:warning: Validation status: warnings

File
Status
Preview URL
Details

e2e_archiveDocs_Prod_20210318220103/fallback.md
:warning:Warning
View
Details

.openpublishing.publish.config.json
:white_check_mark:Succeeded

.openpublishing.redirection.json
:white_check_mark:Succeeded

e2e_archiveDocs_Prod_20210318220103/TOC.yml
:white_check_mark:Succeeded
View

e2e_archiveDocs_Prod_20210318220103/breadcrumb/e2e_archiveDocs_Prod_20210318220103/toc.yml
:white_check_mark:Succeeded

e2e_archiveDocs_Prod_20210318220103/docfx.json
:white_check_mark:Succeeded

e2e_archiveDocs_Prod_20210318220103/fallback.md

Line 2, Column 1: [Warning-ms-author-missing] Missing required attribute: 'ms.author'. Add the current author's Microsoft alias.
Line 2, Column 1: [Warning-ms-prod-or-service-missing] One of the following attributes is required: 'ms.prod', 'ms.service'. Use ms.prod for on-premise products, or ms.service for cloud services.
Line 2, Column 1: [Suggestion-description-missing] Missing required attribute: 'description'.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


Adding Archeo and Trivy summaries

Adding summaries for Archeo and Trivy reports
Fixing small XHTML issues
Adding validation for generated HTML reports

Closes #18


使用omnidb访问数据库频繁时会报错No response from query server

客户反应使用omnidb访问数据库频繁时会报错No response from query server，必须重启jms_omnidb

I have encountered the same problem when I connect Oracle database via omnidb, only by restarting the service can the service recover.


refactor(TypeParameterParser): rename property type to constraint

Commit Body
BREAKING CHANGE: `TypeParameterParser#type` has been renamed to `#constraint`.

Codecov Report
Base: 62.88% // Head: 62.88% // No change to project coverage :thumbsup:

Coverage data is based on head (30ee459) compared to base (51a8c6a).
Patch coverage: 36.36% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #90   +/-   ##
=======================================
  Coverage   62.88%   62.88%
=======================================
  Files          50       50
  Lines        6443     6443
  Branches       52       52
=======================================
  Hits         4052     4052
  Misses       2351     2351
  Partials       40       40

Impacted Files
Coverage Δ

src/lib/structures/misc/TypeParameterParser.ts
62.16% <36.36%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Read ORCA Handbook and Policies

Read the Following Documents:

How_ORCA_Works.md
ORCA_Handbook.md
IT_and_Data_Security_Policies.md
Intellectual_Property_Policy.md
CODE_OF_CONDUCT.md
Add a comment to this issue with your initials and date completed, then close the issue

DR 5/17


Delete unwanted components

Related #525
Description
Deleted components deemed unnecessary.

Current behavior (updates)

New behavior

Is this a breaking change (Yes/No):

Additional Information

@Haru-0001 Please resolve conflict.

@Haru-0001競合を解決してください。

My apologies. We were unable to resolve the issue and will try to re-create a new branch.


Fix Elp

Fix precesion
Use data test from book instead of jpl horizon.

@mdmunir Thanks v3.0.2 is published


getting service unavailable error

ArrestDB is giving the error message "Service Unavailable" and I can't figure out what I might be doing wrong.
My config:
PHP 5.5 on LAMP (Ubuntu)
PDO enabled
$dsn = 'mysql://root:vertrigo@]localhost:443/viewfind/';
.htaccess just as presented in the example, in arrestDB directory
I can see the db (viewfind) and table (stories) using a mysql client with same credentials
trying a simple get:
http://localhost/php/arrestDB/stories/
I get:
{
"error": {
"code": 503,
"status": "Service Unavailable"
}
}
I would appreciate any help in troubleshooting. Thanks!

Never mind! After re-reading my post, I see a syntax error in my $dsn string - I left in one of the brackets. Problem solved. Fantastic code!


Set value separator in from_csv_file

Is your feature request related to a problem?
Table.from_csv_file does not work if anything but commas is used as value separator.
Desired solution
Add an optional, keyword-only parameter to define the separator.
Possible alternatives (optional)
No response
Screenshots (optional)
No response
Additional Context (optional)
No response

This was implemented in #758.


Why key can validate multiple use ?

when i validate key and success login , after i logout why it can use same key to validate
How can i implement it to expire key now after validate success.
thnak you

Thats how TOTP works... Each code is valid for a certain period (usually a 'window' of 30 seconds +/- 1 (or more periods either way) so in effect each code is (by default) valid for ~90 seconds.

... For this to work, the clocks of the user's device and the server need to be roughly synchronized (the server will typically accept one-time passwords generated from timestamps that differ by ±1 time interval from the client's timestamp). A single secret key, to be used for all subsequent authentication sessions, must have been shared between the server and the user's device over a secure channel ahead of time. If some more steps are carried out, the user can also authenticate the server using TOTP. (Source)

The period length (30 seconds) and number of intervals may differ and can both set ($period in the constructor and $discrepancy in the verifyCode() method). But not all "authenticator apps" support periods other than 30 (or multiples of seconds).

How can i implement it to expire key now after validate success.

Codes "expire" every (in the example above) 90 seconds (with a period of 30 s and T±1 interval). If you want to prevent a replay-attack (or "expire" a code immediately) you should store the last login timeslot (UNIXTIME modulo period) and disallow new logins in that same timeslot±X intervals. On how to do that; that's up to you. You could store it in a database, file, whatever...

ok,i understand and How i can  reduce time to expire (90 seconds) to 30 or 60 ?
iam try to chage $discrepancy it not work

How i can reduce time to expire (90 seconds) to 30 or 60 ?

Please read the README and above explanation. You can use $period and $discrepancy and both work exactly as documented.

iam try to chage $discrepancy it not work

Please tell me how to reproduce (i.e. what you did/do exactly, what "not work" means). Are you sure you're implementing it correctly and have understood how this all works? Opening an issue and complaining "iam try to chage $discrepancy it not work" after an (extended!) explanation of what is, essentially, also in the README is not the way to go; please show a little more effort on your behalf.

i just change $discrepancy = -4 but it same90 seconds

What made you think a $discrepancy of -4 would work?
The smallest discrepancy is 0. If anything, this library should throw on negative discrepancies...
The $discrepancy argument is the number of timeslices checked (to either side) of the current timeslice. So:

Discrepancy
Checked (or "valid") timeslices

0
T0

1 (default)
T-1, T0, T+1

3
T-3, T-2, T-1, T0, T+1, T+2, T+3

ok if iwant 30 to expire set $discrepancy and not concern $peroid ?

ok if iwant 30 to expire set $discrepancy=0 and not concern $peroid ?

Your question is unclear but from what I understand from it I'm pretty sure the answer is yes, pass 0 to the $discrepancy argument and keep $period default (or set it explicitly to 30). Again; this should be clear if you read the README (and/or my earlier posts in this thread).


Setting the namespace via a source AndroidManifest.xml's package attribute is deprecated.

Bug
package="com.brentvatne.react" found in source AndroidManifest.xml

Platform

Android

Environment info

React native info output:
npmPackages:
  react: 18.2.0 => 18.2.0
  react-native: 0.71.4 => 0.71.4
npmGlobalPackages:
  react-native: 0.71.4

Library version: 5.2.1
Steps To Reproduce

Try to generate the release APK of the project.

Expected behaviour

The build should succeed without ant failure.

Reproducible sample code

https://react-native-community.github.io/upgrade-helper/?from=0.70.0&to=0.71.4#RnDiffApp-android-app-src-main-AndroidManifest.xml
https://react-native-community.github.io/upgrade-helper/?from=0.70.0&to=0.71.4#RnDiffApp-android-app-build.gradle - check namespace
Video sample
If possible, include a link to the video that has the problem that can be streamed or downloaded from.

hi,i have the same problem.any solutions?

This namespace has been removed on 6.0.0-alpha.8.
If the problem still present, should patch file manifest.xml in the repo to remove the namespace


Ensure node.sep is honoured when generating CSV

Fixes #4977
node.sep was not being honoured in lots of places when generating CSV.
Given how many places had , hardcoded, I'm not 100% confident this won't have other side effects - so want to get more eyes on this (particularly from @Steve-Mcl) before merging.

Unsurprisingly, my changes are breaking lots of tests. So I have no expectation of merging this change as-is.
It may be the fix for the reported issue is a more focused fix around handling of node.sep. Putting this on hold until @Steve-Mcl is back from vacation and has a chance to look.

Yes - the template was always (previously) just comma separated... IE the definition of your columns did use commas,  and if you injected msg.columns it had to be comma separated - so if you change that it will break some people...

Okay, that makes sense. So there should be some scaled back version of my changes to fix the output generation without changing the template parsing.

So there should be some scaled back version of my changes to fix the output generation without changing the template parsing.

Yes. This ^
It is the output that needs fixing only Nick.
Thanks for responding @dceejay

I have undone the changes that affect legacy processing & the parts that affected msg.columns (which should alsways be comma separated)
I also added a new test that specifically targets the condition presented in #4977
 CSV node (RFC Mode)
   json object to csv
     ✔ should convert a simple object back to a tsv with headers using a tab as a separator

Lastly, added specific test for msg.columns to ensure correctness (presence and RFC compliance)

@dceejay as I have been part of this work, would you do the honours of approving? (we can leave merging to Nick so he has the last say)

@knolleary do we want to backport this to 3.x branch?

@Steve-Mcl I don't know - is this broken in the 3.1 branch? The issue report was against 4.x so I assumed this was a regression with the rework that was done in 4.x

Hmmm, doubting when RFC mode was introduced now 🤔
Checking changelog...

ok, sorry for the noise. CSV RFC mode was merged in V4.
Ignore & proceed 😊


Error raised after about 100 continuous sampling

Hi,

Error description

I'm testing a problem necessary to decompose qubits.
So its case should be tested continuously and repeatedly.
By the way, after sampling about 100 continuous sampling,
error was raised as following. Then, whenever a dwave sampler
is instantiated, the error happens.

RuntimeError                              Traceback (most recent call last)
 in
1 DWaveSampler(endpoint='https://cloud.dwavesys.com/sapi'
2                                                           , token='DEV-2d82722a40e192fb938da0012c507a9ae3277e31'
----> 3                                                           , solver='DW_2000Q_2_1')
~/anaconda3/envs/tf36/lib/python3.6/site-packages/dwave/system/samplers/dwave_sampler.py in init(self, **config)
110             config['solver'] = config.pop('solver_features')
111
--> 112         self.client = Client.from_config(**config)
113         self.solver = self.client.get_solver()
114
~/anaconda3/envs/tf36/lib/python3.6/site-packages/dwave/cloud/client.py in from_config(cls, config_file, profile, client, endpoint, token, solver, proxy, legacy_config_fallback, **kwargs)
316
317         _LOGGER.debug("Final config used for %s.Client(): %r", _client, config)
--> 318         return _clients_client
319
320     def init(self, endpoint=None, token=None, solver=None, proxy=None,
~/anaconda3/envs/tf36/lib/python3.6/site-packages/dwave/cloud/client.py in init(self, endpoint, token, solver, proxy, permissive_ssl, request_timeout, polling_timeout, connection_close, **kwargs)
395             worker = threading.Thread(target=self._do_submit_problems)
396             worker.daemon = True
--> 397             worker.start()
398             self._submission_workers.append(worker)
399
~/anaconda3/envs/tf36/lib/python3.6/threading.py in start(self)
844             _limbo[self] = self
845         try:
--> 846             _start_new_thread(self._bootstrap, ())
847         except Exception:
848             with _active_limbo_lock:
RuntimeError: can't start new thread

Expectation.

How to solve this problem?
If there is a limitation of continuous sampling, in a problem necessary to decompose many qubits, how to approach it?

Environment.
OS: Mac OS X Sierra 10.12
Python: 3.6

Regards,
Inwoo Chung

This is a known problem. See #91, #169.
Most likely the solution (for now) is to instantiate a single DWaveSampler instance and use that for all sampling rather than re-creating it.

Thank you for the response.
I will continue to test according to your advice.
And after completing a test, I will send an example code to show error.
Regards,
Inwoo Chung

On 30 Mar 2019, at 12:51 AM, Alexander Condello<EMAIL_ADDRESS>wrote:
This is a known problem. See #91 https://github.com/dwavesystems/dwave-system/issues/91, #169 https://github.com/dwavesystems/dwave-system/issues/169.
Most likely the solution (for now) is to instantiate a single DWaveSampler instance and use that for all sampling rather than re-creating it.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/dwavesystems/dwave-system/issues/171#issuecomment-478049446, or mute the thread https://github.com/notifications/unsubscribe-auth/AGjS8-Zv8vGUFSwI6oR0sWaBfJgjxj0wks5vbjaMgaJpZM4cSK1h.

I uploaded my quantum annealing test code about maximum cut via qubits decomposition.
So you can test it. Below is the link.
https://github.com/tonandr/dwave_qc/blob/master/src/space/max_cut.py

Hi @tonandr, until we implement a singleton thread pool in the dwave-cloud-client, you can simply extract the instance of DWaveSampler (or EmbeddingComposite that wraps it) outside of your loop and/or function (as @arcondello said above). It's straightforward here because you use the same solver in both places (L579 and L867).
Additional benefit of this global-sampler approach is you're saving on instantiation time (which can be significant since solvers' metadata (~1MiB) is downloaded on init/solver selection).
Alternatively, you can manually close DWaveSampler's client/solver after use, as mentioned in #169.


Upgrade to v0.6

Julia v0.6 is the current release. It seems there's no tests on v0.6, and when I try using Turing on v0.6 it stalls.

Yes, we plan to work on that. There is an issue prevent us from using Julia 0.6 at the moment, see
https://github.com/yebai/Turing.jl/issues/173
https://github.com/JuliaLang/METADATA.jl/pull/10646#issuecomment-321925262

I made some progresses on this issue. Now Turing can load within Julia 0.6, however, some tests are currently broken (Pkg.test("Turing")) -- the issue seems related to a change on the Julia side (https://github.com/JuliaLang/julia/issues/21356).

See also JuliaLang/julia#19774

I found that if we do the model evaluation and calling sample(), Julia doesn't throw the error. E.g.
modelf = gdemo(x)
sample(modelf, alg)

From https://docs.julialang.org/en/stable/manual/methods/#Redefining-Methods-1

But neither you, nor any of your callers, nor the functions they call, or etc. can call this new method definition!

Any news on this issue ?
Do we have a list of the issues/tests yet solved ?

@emilemathieu Please see https://github.com/yebai/Turing.jl/pull/341
In short Turing can be used in Julia 0.6 in this PR, and we are adapting the new co-routine and fixing some minor issues.

@xukai92 let's try to merge the PR this week - I will make an effort of fixing coroutine issue; Could you fix other known issues?

Duplicate: https://github.com/yebai/Turing.jl/issues/293

As of now, all tests in #341 are passing on Julia 0.6.

For the warnings you can just install Femtocleaner
https://github.com/JuliaComputing/FemtoCleaner.jl


Archieve unpacker not creating game id folder

Hello,
Curious if ive done something wrong or if there has been a change in playnite.
The extension is not creating a folder in the cache directry, I have tried both "C:\Playnite" and a custom directry "C:\Users\***\Documents\Playnite_Cache"
The games were imported using a custom profile that lists "zip, 7z" as supported file types with the Arguments set to "C:\Users\***\Documents\Playnite_Cache\{GameId}\{ImageNameNoExt}.iso"
The games are stored in a mix of .zip and .7z archieves on a network drive, when launched the emulator (PCSX2 PPSSPP etc) report that no game with name {gameid} {imagename} exists. No folders were created and there is nothing at all in the playnite extensions log.
the extension is enabled and playnite has been restarted a good few times while troubleshooting.
any suggestions for me ?

Hello,
not sure, I just tried with latest Playnite and different systems, it seems to work on my configuration.
This is a project made for hobby and I didn't include many checks or debug logs, sorry for that.
Did you check the 7-Zip path in addon configuration?

Hello and thnaks for the reply, yea 7z is installed and configured correctly C:\Program Files\7-Zip\7z.exe which I believe is also the default path your extension sets. I might spin up a VM and check as I have genuinely spent about 4 hours on this now and I'm starting to think its either a forest from the tress situation or something outside of the configurable settings is wrong. I'll report back if I figure it out :)


Use fullWidth prop from Autocomplete to render input

[ ] I have followed (at least) the PR section of the contributing guide.

Currently Autocomplete's renderInput force input to be fullWidth. This PR changes it to respect the fullWidth prop of AutoComplete. If Autocomplete is fullWidth, then the input is. If Autocomplete is NOT fullWidth, then the input is NOT.
Fix #36841

I'm afraid we can't proceed with this change as it would break existing layouts. We can revisit the problem when we work on Material UI v6.


chore(deps): update common-dev-assets digest to 5fdee53

This PR contains the following updates:

Package
Update
Change

common-dev-assets
digest
240edb4 -> 5fdee53

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

:tada: This PR is included in version 2.1.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Can't connect to SafePal Wallet on IOS

I am trying to connect to SafePal wallet using universal link https://link.safepal.io/ but it's not connecting, Connect Screen appear in SafePal wallet after clicking on approve button loading appear and nothing happen, on android it work
To Reproduce
try to connect to SafePal wallet in IOS
Screenshots

Smartphone (please complete the following information):

Device: Iphone 14, Iphone 11
OS: Latest

Hello @AmjadKhan2k18! I was able to reproduce this behavior also by scanning with SafePal wallet a QR code generated (outside WalletConnect) with the connection URI. Which makes me think it's probably an issue on SafePal side. I also tried an older version of iOS (15) and there I get an "Invalid Code" error when on SafePal side.
Also the fact that you are able to finish the connection with Android supports the theory that this is on SafePal side as we don't do anything really different between Android and iOS, but for sure we will keep investigating.

@quetool  Thanks for checking testing from your app, Now SafePal android started to have same problem too, tapping on Agree button redirect me to my app and doesn't connect


Error occurred - First query failed

Hi. I'm running the bot. I send it the /video command and a link to the video.
But the bot gives an error "Error occurred - First query failed".

As it stands, the bot cannot do anything much. Security improvements on the y2mate.com side is responsible for that. However, I might consider giving it a fix or even create an alternative to that using ytube-api if averything goes well.


Add support of ICO format

Add support of ICO format
Only encode is implemented.
What else might be affected
Tasks

[x] Add tests
[ ] Update Documentation
[ ] Update jimp.d.ts
[ ] Add SemVer Label

any update?

Sorry I didn't see this. Would it be possible to add encode support with this library? https://www.npmjs.com/package/icojs

Could we support decode with https://www.npmjs.com/package/icojs?

No cousin you remake?


Polymorphism doesn't work with Readonly args and strictFunctionTypes

TypeScript Version:  3.2.0-dev.20181019

Search Terms: readonly polymorphism mapped types interface extend
Code
interface Base<P> {
    method: (args: Readonly<P>) => void;
}

function fn(arg: Base<any>) { }

// It works
fn({} as Base<{ foo: string }>)

// Why error?
interface Child<P> extends Base<P> { }
fn({} as Child<{ foo: string }>)

Expected behavior:
No error
Actual behavior:
Error:
Argument of type 'Child<{ foo: string; }>' is not assignable to parameter of type 'Base<any>'.
  Types of property 'method' are incompatible.
    Type '(args: Readonly<{ foo: string; }>) => void' is not assignable to type '(args: Readonly<any>) => void'.
      Types of parameters 'args' and 'args' are incompatible.
        Type 'Readonly<any>' is not assignable to type 'Readonly<{ foo: string; }>'.
          Property 'foo' is missing in type 'Readonly<any>'.

Playground Link:
https://www.typescriptlang.org/play/index.html#src=interface Base<P> {
    method%3A (args%3A Readonly<P>) %3D> void%3B
}

function fn(arg%3A Base<any>) { }

%2F%2F It works
fn({} as Base<{ foo%3A string }>)

%2F%2F Why error%3F
interface Child<P> extends Base<P> { }
fn({} as Child<{ foo%3A string }>)
Related Issues:
Maybe related to #27484

Actually, it errors for any mapped type:
https://www.typescriptlang.org/play/index.html#src=interface Base<P> {
    method%3A (args%3A { [K in keyof P]%3A P[K] }) %3D> void%3B
}

function fn(arg%3A Base<any>) { }

%2F%2F It works
fn({} as Base<{ foo%3A string }>)

%2F%2F Why error%3F
interface Child<P> extends Base<P> { }
fn({} as Child<{ foo%3A string }>)

This is fixed by #27804 because we now measure variance of Readonly<T> and then just relate the types passed for T.


Browser demo/repl

Since this is in Haxe, I could just compile this to javascript and deploy to github pages at https://vurv78.github.io/ExpressionScript.
Then everyone could try it out. Would just be the transpiler for now.. for obvious reasons

Done. At least for the transpiler


Show block submenu as tabs above the content if the block is shown without title.

It should be done automatically inside the BxBasePage class.


Unable to select classifier for VOT enrichment

The selection of a custom AutoVOT classifier for VOT enrichment appears broken on my browser. Selecting one of the default presets works fine, but other combinations result in an unrunnable enrichment.

Browser version:
Google Chrome Version 74.0.3729.169 on MacOS 10.12.4

@MichaelGoodale @james-tanner did this get addressed?

@msonderegger  just fixed it. Something weird that only popped up in chrome so I hadn't ever seen it before.


Add R example and fix python examples.

In this PR, R examples are added and the Python examples are fixed.

Current coverage is 80.73%

Merging #36 into master will not affect coverage as of 2e0a917

@@            master     #36   diff @@
======================================
  Files           12      12
  Stmts          493     493
  Branches        97      97
  Methods          0       0
======================================
  Hit            398     398
  Partial          0       0
  Missed          95      95

Review entire Coverage Diff as of 2e0a917

Powered by Codecov. Updated on successful CI builds.

Merged.


Added cobweb renderer

In theory this can be a lot simpler. Take a look at sugarcane.

Oops.

By the way, I was going to add slab rendering but there doesn't seem to be a WoodSlabBlock or CobblestoneSlabBlock?

I don't know about that. They might be using another name. If not, add them.

Actually there just seems to be two blocks; full slabs (42) and half slabs (44), they both use data values to store block type; I'll just check that in the renderer and use the appropriate texture.

Cool.


Remove Some SAN (names) During Renewal

What is the name of answer file and where is it located (directory) used for renewal?
I need to remove some Subject Alternative Names (SAN) that is no longer used.
Do I need to start from scratch to remove SAN names?
Will there be an answer file if I have run it with manual option?

AFIAK there is no way to edit the SAN list through the answer file. I'm thinking of adding code for the IIS plugins to edit the SAN list based on currently configured bindings in a future release though.


Smoke test failing following React 18 release

npx create-react-app@latest --template defencedigital myapp is failing following the release of React 18 due to peer dependency errors:
Installing packages. This might take a couple of minutes.
Installing react, react-dom, and react-scripts with cra-template-defencedigital...

added 1370 packages in 39s

169 packages are looking for funding
  run `npm fund` for details

Initialized a git repository.

Installing template dependencies using npm...
npm ERR! code ERESOLVE
npm ERR! ERESOLVE could not resolve
npm ERR!
npm ERR! While resolving<EMAIL_ADDRESS>npm ERR! Found<EMAIL_ADDRESS>npm ERR! node_modules/react
npm ERR!   peer<EMAIL_ADDRESS>from<EMAIL_ADDRESS>npm ERR!   node_modules/react-dom
npm ERR<EMAIL_ADDRESS>from the root project
npm ERR!     peer react-dom@"*" from<EMAIL_ADDRESS>npm ERR!     node_modules/@testing-library/react
npm ERR<EMAIL_ADDRESS>from the root project
npm ERR!     1 more (styled-components)
npm ERR!   peer react@">= 16" from<EMAIL_ADDRESS>npm ERR!   node_modules/react-scripts
npm ERR<EMAIL_ADDRESS>from the root project
npm ERR!   4 more (the root project, @testing-library/react, ...)
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peerOptional<EMAIL_ADDRESS>|| ^17.0.0" from<EMAIL_ADDRESS>npm ERR! node_modules/@apollo/client
npm ERR<EMAIL_ADDRESS>from the root project
npm ERR!
npm ERR! Conflicting peer dependency<EMAIL_ADDRESS>npm ERR! node_modules/react
npm ERR!   peerOptional<EMAIL_ADDRESS>|| ^17.0.0" from<EMAIL_ADDRESS>npm ERR!   node_modules/@apollo/client
npm ERR<EMAIL_ADDRESS>from the root project
npm ERR!
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.

Blog post on React 18:
https://reactjs.org/blog/2022/03/29/react-v18.html

@jpveooys
The problem seems to be<EMAIL_ADDRESS>(latest) in the CRA template.
They've a peer dependecy range set for React of ^16.8.0 || ^17.0.0.
I've tried numerous workarounds including the overrides trick to no avail. Looks like we have the choice of either removing it from the CRA template or holding out a little bit longer and hoping for a bump in the supported range.
I've opened a ticket upstream.
RTL also creates an issue but that's an easy fix with a bump to the next major.
There are a few manual workarounds for consumers of the CRA template to follow - but these don't help us with the smoketest.
I've marked this as blocked for now and will re-visit over the next few days.

@c9qsm62x re: react-toast-notificaitons
That component hasn't been touched in a long time - i've created a ticket to look into removing reliance on that unmaintained dependency.

Looks like @apollo/client have just shipped a pre-release of the next minor that should fix this.
Picking this back up today.

@m7kvqbe1
I added overrides here:
https://github.com/defencedigital/mod-uk-design-system/commit/8e9da86a6e662875f28c11d801fe67f9bd91184c#diff-f00100e4c0b71343aacaa479809f7b08efb7e0f0fbb1d68677dfa24c0a8540d7R36-R39
and it did bypass the peer dependency errors:
https://github.com/defencedigital/mod-uk-design-system/runs/6108783518?check_suite_focus=true
(But it doesn't mean everything works, of course, and it'd be better if the dependencies has proper React 18 support.)


Fix httputil.NewCustomClient not having ctx

Using this function without WithContext before this fix will likely cause a program panic down the line. This PR fixes that.

Merged as commit 0d2711a.


Use git command instead of exec.Cmd in blame

extract from #18147

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@a95247b). Click here to learn what that means.
The diff coverage is 96.00%.

@@           Coverage Diff           @@
##             main   #22098   +/-   ##
=======================================
  Coverage        ?   48.22%
=======================================
  Files           ?     1041
  Lines           ?   142070
  Branches        ?        0
=======================================
  Hits            ?    68519
  Misses          ?    65359
  Partials        ?     8192

Impacted Files
Coverage Δ

modules/git/blame.go
80.24% <96.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

So IIRC the reasoning behind using exec.Cmd was to avoid the default timeout. I think we still need to do that.

So IIRC the reasoning behind using exec.Cmd was to avoid the default timeout. I think we still need to do that.

The default timeout mechanism of git command seems not good.
And there is a UseContextTimeout,  see https://github.com/go-gitea/gitea/pull/20689

@zeripath @wxiaoguang done.


Support Update 1

Updated readme based on team feedback

@homu r+

:pushpin: Commit 272c970 has been approved by smo-key

:hourglass: Testing commit 272c970 with merge 817b4d9...

:sunny: Test successful - status


Concentration

Wire up the concentration switch.
When taking damage, if concentrating:

Pop up dialog that contains the damage DC.
Two buttons "Pass / Fail" in the right colours.

Done in f44acdb.


about some use question

I want to consult how to convert the model Cnn14_mAP=0.431 to onnx format. I use the following way, but the conversion has been unsuccessful.
code:

error:


updated cubicsdr (0.1.27)

Is there a reason you switched to an alpha release? We prefer stable releases here.

Hi,
I understand you prefer stable releases. The previous version 0.1.4 was a beta, is over 8 months old, and wasn't particularly stable. Although 0.1.27 is tagged alpha, it is a very large improvement over 0.1.4 so I thought it was appropriate to provide a newer cask.
Thanks!

Took a quick look at the releases page, seems okay to use "alpha" releases as one tagged as stable is pretty far back.

Ok thanks. I'll keep it in mind next time for other casks. Cheers!


Parameters can't be ordered in the UI if no positional argument are used

It's possible to use the position property for actions. But the position property causes that a positional argument is passed to the action script. But I would like to use --parameter=somevalue, instead of a positional argument. In that case it would still be nice if parameters could be ordered in the UI.

Even just showing the parameters without a position property alphabetically would be an improvement. At the moment it's random.

@pietervogelaar Can you provide a little more info? You should be able to provide arguments by name even w/ position set.

Regarding  parameter ordering in the Web UI, I think this is what really meant: https://github.com/StackStorm/st2web/issues/154 (we have an issue for that).
@pietervogelaar You can :+1: there to bring more attention.

Thanks that's indeed what I meant!

Thanks for bumping that thread!  :+1:
The feedback is really important to bring more priority to different issues based on user's requests.
So I'm closing this in favor of https://github.com/StackStorm/st2web/issues/154


Playground should handle time-outs and errors

I've noticed that after sending a request, I can't seem to create a second one. I can go ahead and enter new text into the fields and it'll appear in the Request Body, but clicking on the "Send Message" button does nothing. I have to reload the entire page to send a second request.
I suspect this is related to issue #11 -- perhaps the page is waiting for some acknowledgement from the server before it "resets" to submit a second request, and if it's unable to communicate to the server, it's not getting back the acknowledgement it needs and therefore the page doesn't reset.

I have confirmed, incidentally, that was due to issue #11 when I was pointing to the wrong port to use for my server.
So make this a low-priority bug saying, "Hey, supporting server time-outs might be nice."

Actually, this also seems to happen when I get 500 Internal Server errors back from my request. Given that this is probably more likely to happen than time-outs, I'm going to suggest making this medium priority, and I'm changing the title again. :)

https://youtu.be/asuMjqyLPVE

https://youtu.be/F2kHP8aXf_M


next config set by jest tests doing setConfig isn't read by next-page-tester

🐛 Bug Report
v0.17.0 introduced the ability to read from the next config.  However, the next config can be set during jest tests, so it is separate from the next config. It is set via our code in jestSetup.ts:
import { setConfig } from "next/config";
setConfig({
  publicRuntimeConfig: {
...

which calls next's
    envConfig.setConfig({
      serverRuntimeConfig,
      publicRuntimeConfig,
    })

which calls runTimeConfig.ts
export function setConfig(configValue: any): void {
  runtimeConfig = configValue
}

The next-page-tester should do something like read in runtimeConfig via the runTimeConfig.ts
export default () => {
  return runtimeConfig
}

as default and then override with next config if the runtimeConfig is undefined.
To Reproduce
Set the runtimeConfig dynamically in jest setup.
run a jest test that uses runtimeConfig
Expected behavior
The jestSetup calls to setConfig take precedence of next's file config.
Link to repl or repo
Run npx envinfo --preset jest
Paste the results here:
  System:
    OS: macOS 10.15.6
    CPU: (12) x64 Intel(R) Core(TM) i9-8950HK CPU @ 2.90GHz
  Binaries:
    Node: 12.16.0 - ~/.nvm/versions/node/v12.16.0/bin/node
    Yarn: 1.17.3 - /usr/local/bin/yarn
    npm: 6.13.4 - ~/.nvm/versions/node/v12.16.0/bin/npm
  npmPackages:
    jest: ^26.6.3 => 26.6.3

Hi @DavidOrchard,
we definitely didn't consider the option of manually calling next/config's setConfig manually. It's not even mentioned in Next.js docs. :)
Do you know whether it's considered good practice? I thought setConfig as a private method called internally by Next.js (in fact next-page-tester also uses it to set runtime config from next.config.js).
Is there any use case not covered by setting runtime config from next.config.js?

Hi @DavidOrchard,
we definitely didn't consider the option of manually calling next/config's setConfig manually. It's not even mentioned in Next.js docs. :)
Do you know whether it's considered good practice? I thought setConfig as a private method called internally by Next.js (in fact next-page-tester also uses it to set runtime config from next.config.js).
Is there any use case not covered by setting runtime config from next.config.js?

Hi @DavidOrchard, we definitely didn't consider the option of manually calling next/config's setConfig. It's not even mentioned in Next.js docs. :)
Do you know whether it's considered good practice? I thought setConfig as a private method called internally by Next.js (in fact next-page-tester also uses it to set runtime config from next.config.js).
Is there any use case not covered by setting runtime config from next.config.js?

If it's not meant to be used I don't understand why it is exposed. At the very least it should be mentioned as a comment in the code or something =/


bikeshed spec returns 0 despite link error

https://travis-ci.org/w3c/webauthn/builds/286696061 succeeds even though there's a link error. I'd like either bikeshed spec to return a non-0 error code when there's a non-fatal link error or have an option to do so.

I was waiting for someone to ask for a way to kill the generation on link error.  It's very intentionally not what I'm doing by default (link errors used to be just plain fatal errors, I separated them out on purpose), but I'm happy to add a metadata to turn them fatal again.

For interactive use, it's great that we can get a spec generated even with link errors, but for interactive use I don't care about the exit code. If there's a metadata to make them set a non-0 exit code, I think I'd still want interactive use to be able to generate the spec.

That's what command-line metadata setting is for - you can pass --md-Link-Errors-Are-Fatal="yes" (or whatever I end up calling it) when Travis builds the spec.

'k, sounds good.

So this issue can be closed, I guess?
(It'd be good to document this, though.)

No, I haven't implemented the feature yet. 😀

Bump; we want this in gpuweb! We accidentally introduce things like bool when we meant boolean, which is a linker error because bool is a valid but unknown identifier.

@beaufortfrancois seems to have figured out that there's already an option (--die-on) for this in https://github.com/gpuweb/gpuweb/pull/366. Maybe this needs to be closed? :)

Yep, documented at https://tabatkins.github.io/bikeshed/#cli-options. Thanks!


Issues during importing hub

[s3prl.downstream.experts] Warning: can not import s3prl.downstream.a2a-vc-vctk.expert: No module named 'resemblyzer'. Pass.

This is fine, just a harmless warning


OffersList: unactive Buy buttons (+ allow start BTC->ETH swap with 0 balance)

[ ] allow start BTC->ETH swap with 0 balance

[ ] add tooltip with message WHY user can't click

Hey it seems the same is happening for Ghost related swaps


https://www.museoreinasofia.es/

Hello!,
I am setting up a timemap at the MNCARS and have spotted few issues which I would like to know if they're fixable. I am not a developper, just an user so I would need someone to fix them (for the sake of community :))

SORRY I clicked by mistake on the submit button...Please delete this thread (I've tried without any success)
thanks!