Update forcetk.js to support Windows8 in phonegap

Protocol in Windows8 app is ms-appx: not file:

Thanks!


multi: configurable anchor commitment conf target

In this commit, a new config option is added so that users can set the
confirmation target to be used for anchor commitments. The default value
is set to 6. Before this commit, a conf target of 3 was used.
cc @ziggie1984

@ellemouton, remember to re-request review from reviewers for your latest update

@ellemouton, remember to re-request review from reviewers for your latest update

@ellemouton, remember to re-request review from reviewers for your latest update

!lightninglabs-deploy mute 2022-Jan-01

@ellemouton, remember to re-request review from reviewers when ready

@ellemouton, remember to re-request review from reviewers when ready

@ellemouton, remember to re-request review from reviewers when ready

@ellemouton, remember to re-request review from reviewers when ready

@ellemouton, remember to re-request review from reviewers when ready

@ellemouton, remember to re-request review from reviewers when ready

@ellemouton, remember to re-request review from reviewers when ready

@ellemouton, remember to re-request review from reviewers when ready

!lightninglabs-deploy mute 2022-April-04

I think this is no longer needed (?) now that we'll not sweep anchors until we actually need to? Then once their swept, BumpFee can be used to increase the CPFP rate.

I think this is no longer needed (?) now that we'll not sweep anchors until we actually need to? Then once their swept, BumpFee can be used to increase the CPFP rate.

but doesnt that require a user to actively go and bump it then? This just allows them to set the default target if they want.
happy to close though - lemme know what you think

So I think it makes sense to distinguish between anchor and non-anchor channels but I probably think we should just make sure we always use the min_relay_fee for anchors, but not only ours but taking the ones of our peers into account as well (relates to https://github.com/lightningnetwork/lnd/issues/8302)


Fix method play() of rviz_visualizer

Method play() overridden, Qtest.qWait() used for the delay between one display to another instead of time.sleep().
In the original implementation method play() form base_visualizer was used.

Hi ! This project doesn't usually accept pull requests on master.
If this wasn't intentionnal, you can change the base branch of this PR to devel
(No need to close it for that). Best, a bot.

Thanks @danielcostanzi18 for your contribution.
I made a slight modifications.

Please follow the dry principle (Don't Repeat Yourself).
Instead of copy/pasting the whole play method, you can define the def sleep(self, dt) method in the base class, with time.sleep(dt) in the base case, and call that instead of time.sleep(dt) in the play method.
Then, in the RViz derived class, all you have to do is to define another def sleep(self, dt) method with the required qWait(dt * 1000) instead

@danielcostanzi18 COuld you handle the change requested by @nim65s?


Please tidy up the name used.

I was recently updating my node list.
I saw this node-red-contrib-ui-time-scheduler update available.
Oh.   Ok.....   Brain failure and so I thought I would search for it.
NOT FOUND.
After a lot of messing around it is called
ui_time_scheduler
It would be nice is the - were kept and not replaced with _.
It really makes searching for the node annoying.
No, not critical.   But it seems inconsistent with the use of - and _ interchangeably.

That would possible break existing installations therefore I won't change it now.
I will consider the change when I port the node to dashboard2.


Preview is very low quality on first drop

When I drop a file into the dropzone and then showing the preview, the first time the preview is a really quality. When I drag/drop a second file the preview seems to be fine. Any clue on why this is happening?

If you have ngf-thumbnail it would resize the photo to the size of the preview.
If you want to show the original image in the preview use ngf-src


I'm try to train with docker

root@21c2344a24ac:/benchmarks/benchmarks/AudioClassfication# python trainer.py --max_lr 3e-4 --run_name r1 --emb_dim 128 --dataset urban8k --seq_len 90112 --mix_ratio 1 --epoch_mix 12 --mix_loss bce --batch_size 1 --n_epochs 3500 --ds_factors 4 4 4 4 --amp --save_path outputs
/usr/local/lib/python3.8/dist-packages/torchaudio/backend/utils.py:53: UserWarning: "sox" backend is being deprecated. The default backend will be changed to "sox_io" backend in 0.8.0 and "sox" backend will be removed in 0.9.0. Please migrate to "sox_io" backend. Please refer to https://github.com/pytorch/audio/issues/903 for the detail.
warnings.warn(
Namespace(amp=True, augs_mix=['mixup', 'timemix', 'freqmix', 'phmix'], augs_noise=['awgn', 'abgn', 'apgn', 'argn', 'avgn', 'aun', 'phn', 'sine'], augs_signal=['amp', 'neg', 'tshift', 'tmask', 'ampsegment', 'cycshift'], batch_size=1, data_path='../data/UrbanSound8K', data_subtype='balanced', dataset='urban8k', dim_feedforward=512, ds_factors=[4, 4, 4, 4], ema=0.995, emb_dim=128, epoch_mix=12, ext_pretrained=None, filter_bias_and_bn=True, fold_id=None, gpu_ids=[0], kd_model=None, load_path=None, local_rank=0, log_interval=100, loss_type='label_smooth', max_lr=0.0003, mix_loss='bce', mix_ratio=1.0, model_type='SoundNetRaw', multilabel=False, n_classes=10, n_epochs=3500, n_head=8, n_layers=4, nf=16, num_workers=8, resume_training=False, run_name=PosixPath('r1'), sampling_rate=22050, save_interval=100, save_path=PosixPath('outputs'), scheduler=None, seq_len=90112, use_balanced_sampler=False, use_bg=False, use_ddp=False, use_dp=False, wd=1e-05)
-1
Dummy Run*
dummy succededd, avg_time_batch:15.636324882507324ms
Traceback (most recent call last):
File "trainer.py", line 699, in
main()
File "trainer.py", line 695, in main
train(args)
File "trainer.py", line 549, in train
for iterno, (x, y) in enumerate(train_loader):
File "/usr/local/lib/python3.8/dist-packages/torch/utils/data/dataloader.py", line 435, in next
data = self._next_data()
File "/usr/local/lib/python3.8/dist-packages/torch/utils/data/dataloader.py", line 1085, in _next_data
return self._process_data(data)
File "/usr/local/lib/python3.8/dist-packages/torch/utils/data/dataloader.py", line 1111, in _process_data
data.reraise()
File "/usr/local/lib/python3.8/dist-packages/torch/_utils.py", line 428, in reraise
raise self.exc_type(msg)
ValueError: Caught ValueError in DataLoader worker process 0.
Original Traceback (most recent call last):
File "/usr/local/lib/python3.8/dist-packages/torch/utils/data/_utils/worker.py", line 198, in _worker_loop
data = fetcher.fetch(index)
File "/usr/local/lib/python3.8/dist-packages/torch/utils/data/_utils/fetch.py", line 44, in fetch
data = [self.dataset[idx] for idx in possibly_batched_index]
File "/usr/local/lib/python3.8/dist-packages/torch/utils/data/_utils/fetch.py", line 44, in
data = [self.dataset[idx] for idx in possibly_batched_index]
File "/benchmarks/benchmarks/AudioClassfication/datasets/urban8K_dataset.py", line 65, in getitem
audio = AudioAugs(self.transforms, sampling_rate, p=0.5)(audio)
File "/benchmarks/benchmarks/AudioClassfication/datasets/audio_augs.py", line 464, in init
augs['phn'] = RandomPhNoise(p=p, fs=fs, sgm=0.01)
File "/benchmarks/benchmarks/AudioClassfication/datasets/audio_augs.py", line 387, in init
super().init(fs=fs)
File "/benchmarks/benchmarks/AudioClassfication/utils/helper_funcs.py", line 28, in init
raise ValueError
ValueError
my
torch==1.7.1+cu110 torchvision==0.8.2+cu110 torchaudio==0.7.2
and
tensorflow==2.7.0
and, i tried with edit DataLoader worker==0
and, in my docker environment, sampling rate is not fitted before add noise.  so, fitted fs = 20050,
it executed until forwarding but error accured with padding issue.
i guess it came from 4d conv.
please answer about my question.
ps. can you give me requirements.txt?

Hi,
The snapshot you copied is for not supported - since there are some augmentations in frequency domain, i've only taken care of 16000, 22050, 8000 Hz cases with corresponding stft parameters. Nevertheless, padding occurs if the loaded audio signal is shorter than provided sequence length "--seq_len 90112". can you provide what is the size of the sample that creates this crash?
regarding requirements.txt: torch 1.7.1 is fine, i've also tested with latest torch in case you want to upgrade the docker. i can create the txt file but it will take few days, presumably the issue is configuration rather with packages.

thank you, i will try again with 22050 Hz :)


problem with docker container configuration

I discovered a minor blemish in what I presume is the configuration for the simple docker container definition for a desktop machine.   To avoid the problem noted elsewhere with miniseed net,sta,chan, loc being messed up by save_data I used this construct to create a database handle:
db=Database(dbclient,'usarraytest',db_schema='mspass_lite')

When run on the docker image I get this error:
---------------------------------------------------------------------------
FileNotFoundError                         Traceback (most recent call last)
/usr/local/lib/python3.6/dist-packages/mspasspy/db/schema.py in __init__(self, schema_file)
     26         try:
---> 27             with open(schema_file, 'r') as stream:
     28                     schema_dic = yaml.safe_load(stream)

FileNotFoundError: [Errno 2] No such file or directory: '/mspass/data/yaml/mspass_lite'

Maybe that wouldn't happen if I didn't map /home to a local file system, but the error shows a disconnect in how MSPASS_HOME is set (I think) in the container.  I checked running a terminal from the notebook and get what I expected:  MSPASS_HOME is set to /mspass.   That is clearly not what it should be.   I have no clue how to fix that so I need to punt it to you, Ian.

This is just a typo, and the error message is telling the truth that there is no such file /mspass/data/yaml/mspass_lite. Instead, you should give the full filename mspass_lite.yaml i.e., Database(dbclient,'usarraytest',db_schema='mspass_lite.yaml').


Not compatible with JEI

Describe the Suggestion
REI frequently causes crashes, but JEI does not display recipes correctly.
Screenshots and Videos
No response
Additional Context
No response

I tried changing JEI versions and using other mods like EMI and it's been wildly inconsistent with showing stuff like assembly line crafting recipes

REI, JEI, and EMI are all supported.
If REI is crashing, report to REI.
Errors with all 3 should be mostly fixed in the next update.


Update meta.yaml

Checklist

[x] Used a fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[x] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy
[x] Ensured the license file is being packaged.

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.
I do have some suggestions for making it better though...
For recipe:

license_file entry is missing, but is expected.

@conda-forge-admin, please rerender

Hi! This is the friendly automated conda-forge-webservice.
I tried to re-render for you but ran into some issues, please ping conda-forge/core for further assistance.

Even though the package is no arch, it cannot be installed for Python 3.7. It is not necessary in Python 3.7 as it is included in the core packages, still I guess we should fix the compatibility issue.
UnsatisfiableError: The following specifications were found
to be incompatible with the existing python installation in your environment:

  - dataclasses -> python[version='>=3.6,<3.7']

@conda-forge/dataclasses

still I guess we should fix the compatibility issue.

@jan-janssen can you add skip: True  # [py>37] to the build section?

still I guess we should fix the compatibility issue.

Why? That error message just tells you that you cannot install it on py37. We could build it for py37 by removing the python pin in host and run but I remember @mingwandroid had some concerns on doing that.


Specify the URL while calling AWS

Hi,
thanks for sharing this repository on Github! The AWS toolkit is so old, it doesn't work anymore with v4 authentication.
Anyway, when I tried to connect to AWS, I've got a 'permanent redirect' status. So I slightly modified the classes to allow the user to write a base URL while instantiating the Connector. If not specified, the methods work as before.

Thanks for this @fracarma! We'll merge, best rgds

Fixed here: https://github.com/bigassforce/aws-sdk/commit/da5941848fa338b50c070962420353c318eb71bb


Question: How to detect wheter a file with invalid mimeType has been dropped

react-dropzone supports mimeType filtering. How can I detect wheter a dropped file has been declined by the filter? The onDrop handler seems not to be executed in such a case, it seems to fail silently...
Any idea how to deal with that...?

You can pass a callback for the onDropRejected callback:
https://github.com/okonet/react-dropzone/blob/master/src/index.js#L117

Exactly what I'm looking for :+1:


citadel: refactor addBook to get list of valid extensions from citadel-rs

Current dependencies on/for this PR:

main

PR #22   👈

This stack of pull requests is managed by Graphite.


Alert on update from new account

Provide a mechanism for people to notify the bot of an update from a new account.

Focus is shifting to story subs rather than advice ones, so updates from new accounts is less likely.


use 0xeee... for ETH transfers instead of 0x00

Do this only when the multicall nodes can be updated

already done


Can't render svg to canvas in ie.

I am using html2canvas to render svg to canvas, but it doesn't work.
Can  you tell me or could you suggest how to do to make it works.

fix the problem with html2canvas.svg.js


MID 61 Tightening subscription successful, but package is not received when tightening is performed [Help needed, question]

Program output:
Sending Tightening Subscribe...
Sending message:<PHONE_NUMBER>1
Response: 00240005        00000060
Tightening Subscribe accepted!
Sending Keep Alive...
Sending message: 00209999
Response: 00209999        0000
Keep Alive Received
Atlas Copco PF 4000. Tightening subscription is successful. But when i perform the tightening, below method is not getting executed. Any help in debugging will be highly appreciated. I am new to working with the controllers. Thank you
protected virtual void OnPackageReceived(object sender, Message message)
{
    try
    {
        Console.WriteLine($"Message arrived: {message.MessageString}");

        var mid = this._midInterpreter.Parse(message.MessageString);
        var action = this.OnReceivedMID.FirstOrDefault(x => x.Key == mid.GetType());

        if (action.Equals(default(KeyValuePair<Type, ReceivedCommandActionDelegate>)))
        {
            Console.WriteLine($"NO ACTION WAS REGISTERED TO MID: {mid.GetType()}");
            return;
        }

        action.Value(new MIDIncome() { Mid = mid });
    }
    catch (Exception ex)
    {
        Console.WriteLine($"Exception: {ex.Message}");
    }
}

You need to set a Job at the controller, which could be done manually by setting it through the controller panel or via open protocol (if enabled).
Once done, if the tool is rotating the fuse when you trigger the tool's button, then it must send you Mid0061 if you're subscribed.
Unfortunately I don't have any documentation about of how to configure the controller physically. I only remember doing it by navigating on every setting at it and trying out

Thank you. I will check the tightening via jobs instead of psets. Your help is much appreciated :)


CASMPET-5641 main : DOCS: Regenerate the 'etcd-client-cert' secret in the sysmgmt-health ns

Summary and Scope
This relates to CAST-29991 - During cert renewal, the etcd-client-cert secret used by the prometheus active targets to connect from the worker node to the master nodes to check etcd metrics also needed to be updated.
Issues and Related PRs
List and characterize relationship to Jira/Github issues and other pull requests. Be sure to list dependencies.

Resolves CASMPET-5641
Change will also be needed in main, 1.2 and 1.0 branches
Future work required by NA
Documentation changes required in NA
Merge with/before/after NA

Testing
vshasta
Tested on:

<development system>
Local development environment
Virtual Shasta

Test description:
How were the changes tested and success verified? If schema changes were part of this change, how were those handled in your upgrade/downgrade testing?

Were the install/upgrade-based validation checks/tests run (goss tests/install-validation doc)?
Were continuous integration tests run? If not, why?
Was upgrade tested? If not, why?
Was downgrade tested? If not, why?
Were new tests (or test issues/Jiras) created for this change?

Risks and Mitigations
Are there known issues with these changes? Any other special considerations?
Pull Request Checklist

[ ] Version number(s) incremented, if applicable
[ ] Copyrights updated
[ ] License file intact
[x] Target branch correct
[ ] CHANGELOG.md updated
[ ] Testing is appropriate and complete, if applicable
[ ] HPC Product Announcement prepared, if applicable

Does this need a 1.2 backport? What about 1.0?


[Bug] Keep best cp 0 keeps all.

Expected Behavior
"Jynx": {"keep_best_cp": 0},
Should release/transfer all Jynx.
Actual Behavior
Does not transfer any Jynx.
Steps to Reproduce
In config release setup put:
"Jynx": {"keep_best_cp": 0},
Other Information
OS: Ubuntu 15.04
Git Commit: (run 'git log -n 1 --pretty=format:"%H"' and paste it here)
Python Version: 2.7.9

well no. Keep = keep. Release = release. Just change the keep to relelase and it will release all jynx. Or change the CP 0 to 2000 and it will release all jynx as well... unless you get a strong one which you might wanna keep anyways :)

@RaizenInstinct the "0" in the config does not refer to the CP of the pokemon, it refers to how many you want to keep.
Therefore if Keep = 0 then it should not keep any.

True. Even I have faced this. I will try to change it to "release_below_cp" and then see what happens

Try this
Rattata": {"always_release": true},
might work. It is present in the example.json

Ok the always_release: true works of course, so does if you just put keep_best_cp: 1 and it will transfer all others.
Nevertheless i believe if keep = 0 it should transfer all.

I agree that keep=0 should transfer all but that's how it is! :p

Why was this closed? Is it fixed in some commit?


Preparation or improvement of the guide for the meeting (issue #240 related)

The goal is to preapre a guide covering methods of simulations on ODESystem objects

Issue can be closed.

Issue can be closed.


button when i click on it nothing happens

Is your feature request related to a problem? Please describe.

Describe the solution you'd like:

Describe alternatives you've considered:

Additional context:

Closing as incomplete. Please feel free to add more information if you have any and we can re-open the issue.


Remember sort selection?

Hello,
there is any way to make the browser to remember the user sort selection after page refresh?
thanks!

localStorage?

@TrejGun
i try to make it remember the sort selection but how can i init the items array dynamicly and pass props to the components, any idea?


Why two const SizedBox aren't identical?

Minimal Code:
@override
Widget build(BuildContext context) {
  const one = SizedBox();
  const two = SizedBox();

  print('${identical(one, two)}'); // prints false, should print true
  return Container();
}

Am I doing something wrong, here's the question on StackOverflow.
Flutter doctor:
[✓] Flutter (Channel dev, 1.22.0-1.0.pre, on Mac OS X 10.15.1 19B88, locale en-GB)
    • Flutter version 1.22.0-1.0.pre at /Users/me/Work/flutter
    • Framework revision ce40de69b7 (3 days ago), 2020-08-20 07:31:50 -0700
    • Engine revision 81027ab0cc
    • Dart version 2.10.0 (build 2.10.0-45.0.dev)

They are completely different objects that's why it prints false on the console.

@Mashood97 I hope you read the question before writing comment. The question is why they are not identical and not are they identical.

Hi @iLoveDocs
This issue doesn't seem to describe a bug or a feature request. Please see https://flutter.dev/community for resources and asking questions like this,
If you need help with your code, please see https://www.reddit.com/r/flutterhelp/
If you want to know more about this, then you can start by looking at https://github.com/flutter/flutter/issues/4562#issuecomment-275990100
Closing, as this isn't an issue with Flutter itself. If you disagree, please write in the comments and I will reopen it.
Thank you

@pedromassango  Definitely this isn't an issue with Flutter and I asked the question on Stackoverflow many months ago but received no useful answer there, so I thought of asking that question from actual Flutter developers (you guys).

@pedromassango Definitely this isn't an issue with Flutter and I asked the question on Stackoverflow many months ago but received no useful answer there, so I thought of asking that question from actual Flutter developers (you guys).

You did well by asking on Stack Overflow, Please see the https://flutter.dev/community link to see more ways of asking questions for Flutter developers.
Thanks once again

@iLoveDocs  It is a common problem in debug mode. You can try to run the code in release mode. In release mode, the result should be what you expect: they are identical. See more detailed explanation:
https://flutter.dev/docs/testing/debugging#widgets-marked-const-that-should-be-equal-to-each-other-arent

@shenjingfs This actually answered the post. I read the docs couple of months ago and as far as I remember, that part wasn't included.


Add Lahernan to Contributors list

@lahernan661, I'm quite elated about your PR. I wanna evolve this project to addresses various problems faced by first-time contributors. I'd love to learn about your journey in open source community, the problems, pain points you had etc.
Could you explain how you felt when you went through the tutorial, made a PR and learned that I merged it?

Yes, I was actually elated myself to see someone post a first time contributors project such as yours. Being new to GitHub and programming in general as I am still currently completing my computer science degree, I have been on and off GitHub just poking around trying to learn the GitHub process, using git, and how I could start off with small contributions to learn new skills and experience. When I came across your repository I was really psyched! And the fact that it was easy to understand and implement and gave me confidence to further explore I think there should be many more just like it. Thank you. A big fan.
Leonard
On Jul 12, 2017 3:38 AM, Roshan Jossey<EMAIL_ADDRESS>wrote:
@lahernan661https://github.com/lahernan661, I'm quite elated about your PR. I wanna evolve this project to addresses various problems faced by first-time contributors. I'd love to learn about your journey in open source community, the problems, pain points you had etc.
Could you explain how you felt when you went through the tutorial, made a PR and learned that I merged it?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/Roshanjossey/first-contributions/pull/229#issuecomment-314723431, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AYAAH1a3n2BWQJ2Pe9x5lY9YXqhN_s7Vks5sNKITgaJpZM4OVL1_.

@lahernan661, We also have a slack team to help/mentor people trying to contribute to open source projects.
You can join the team by going to https://firstcontributions.herokuapp.com


What is the minimum version of photoshop that psd-tools depends on

What is the minimum version of photoshop that psd-tools depends on

@wushiwein119 I don't know. Adobe does not publish detailed info on PSD format and Photoshop version correspondence. psd-tools parses PSD structure described in the following document.
https://www.adobe.com/devnet-apps/photoshop/fileformatashtml/


Add env_var support to migration templates

Extending functionality provided in #91 to the migration template files.

Hey @sfc-gh-jhansen, the approach taken in #91 is great, however, it doesn't cover our need of accessing environmental variables directly from migration template files. This PR mimics #90 using logic added in #91.

Looks good to me, thanks!


Correct comment on the link object

The example referencing the response body had the same comment as the one referencing the request path.
This one replaces #1381, which seems messed up after changing the base.

Merging as discussed on our weekly call.


added SDL keyboard handler

I was needing a keyboard driver using SDL under an unix system and thought that it could be useful for others in the future.

Superseded by https://github.com/lvgl/lv_binding_micropython/pull/215

Superseded by #215

Thank you very much for your work. I did not have the time to rewrite MR so I am very happy to test your solution. :)

so I am very happy to test your solution. :)

Great! Let me know if you see any problem.


Fold with_ Query flavors into Base

coverage: 93.309% (-0.2%) from 93.505%
when pulling 7f02dcda114123333f517d804ed9ac5e9d8520b7 on standardize-controller-indexes
into 16dccbdb097ba7baa2710c32fef9175039b33ba4 on main.


Cythonized class lacks type annotations

from typing import get_type_hints

class Kitteh:
    attr: float = 123.

print(get_type_hints(Kitteh))

This pure Python code results in different outputs depending on whether it has been cythonized or not.
# Cythonized
$ python -mtestx
{}

# Pure
$ rm testx/*.c testx/*.so
$ python -mtestx
{'attr': <class 'float'>}

This is unfortunate for use cases where you e.g. want to perform data parsing into classes based on type hints. Is this intended behavior? I observed this with both 0.29.6 and the latest master.
I attached a small pipenv project that reproduces the issue.
cythonbug.tar.gz

Duplicate of #2552.


[Improvement] Quickly delete local or HDFS data at the shuffleId level.

What changes were proposed in this pull request?
At the shuffleId level, data on the local or HDFS needs to be deleted synchronously. In some scenarios, the deletion time needs to be shortened. You can rename folders and delete them asynchronously.
Why are the changes needed?
Fix: #2083
Does this PR introduce any user-facing change?
No.
How was this patch tested?
UT.

Codecov Report
Attention: Patch coverage is 20.13889% with 115 lines in your changes missing coverage. Please review.

Project coverage is 52.87%. Comparing base (57f0f8b) to head (6052399).

Files
Patch %
Lines

...orage/handler/impl/HadoopShuffleDeleteHandler.java
0.00%
38 Missing :warning:

...e/uniffle/server/storage/HadoopStorageManager.java
35.13%
22 Missing and 2 partials :warning:

...he/uniffle/server/storage/LocalStorageManager.java
35.13%
22 Missing and 2 partials :warning:

...e/storage/handler/impl/LocalFileDeleteHandler.java
0.00%
22 Missing :warning:

...e/uniffle/server/storage/HybridStorageManager.java
0.00%
4 Missing :warning:

.../org/apache/uniffle/server/ShuffleTaskManager.java
60.00%
2 Missing :warning:

...pache/uniffle/server/ShuffleServerGrpcService.java
0.00%
1 Missing :warning:

Additional details and impacted files
@@              Coverage Diff              @@
##             master    #2084       +/-   ##
=============================================
+ Coverage          0   52.87%   +52.87%
- Complexity        0     2625     +2625
=============================================
  Files             0      412      +412
  Lines             0    19398    +19398
  Branches          0     1781     +1781
=============================================
+ Hits              0    10256    +10256
- Misses            0     8496     +8496
- Partials          0      646      +646

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Could you help share which case will need to shorten the deletion time.

During the Stage retry, delete the shuffle data block from the disk or hdfs.

@zuston Help trigger the error module, I have no local error.

Overwrite delete logic.

@zuston Could you help me review this pull request?

@zuston Could you help me review this pull request?

Yes, I will review this in the later 3 days.


[BC-breaking] Fix for integer fill value in constant padding

The previous implementation of pad with constant fill value had an undesired behavior when a single value was passed.
One would expect that it would fill the whole region with the (pad, pad, pad) value, but in fact it was doing (pad, 0, 0), as this is how Pillow handles it.
This is a backwards-incompatible change in torchvision that changes the behavior of the function, but given that most users use a value of 0, this shouldn't be a big issue.

@pmeier could you have a look to double-check?


[BUG] Aave Yield Chaser Bot Fees are incorrect on each chain. Polygon has Gas fee of $18,790.65

Aave Yield Chaser Bot Fees are incorrect on each chain. Polygon has Gas fee of $18,790.65

Polygon

Ethereum shows only $2.0 fee?

Fixed with https://github.com/VolumeFi/palomabot/pull/515


Remove Old Version Of Plex

[x] Have you signed the Contributor License Agreement?
[x] Have you checked that there aren't other open pull requests for the same manifest update/change?
[x] Does your manifest conform to the 1.0 schema?

Microsoft Reviewers: Open in CodeFlow

Thought this one happen. I will revert one and then go again.


Change what happens when someone adds an existing image

If someone uses mb.addimage with an image that's already in the collection, the image should have the current server added to its sids. That way, the image will start appearing in the new server.

No, sids are a property of command, not image.
Hmm.

@lupomikti Do you have any ideas?
If the "existing" image isn't associated with the user who tries to add it, they won't be able to pull the image even though they wanted to add it.
Maybe I should get rid of the duplicate image detector? Or only use it when the uid of the existing image equals the user who tried to add the duplicate image?

Are you sure SIDs aren't a property of images? That's what was planned in the media command insulation overhaul.

@lupomikti I mean the origin sids, whoops

Potential solution is changing the media.images table's PK to be (cmd, image_key, sid). This means that multiple images do not have to be physically stored, commands remain associated with their owners and origin servers, but the image can still be pulled on the non-origin server.

(talking to myself)
We'll need to :

Add sid to media.images's PK like Lupo suggested
For everything that has select whatever from media.images, group by sid or whatever, so we don't repeat images.
Make sure that every function that deletes rows will do what's expected if there are repeating images with different SIDs

With the removal of the complexity of the media insulation, does this still need to be addressed?

Nope! :D


Run clang format over DiffCloth

I noticed that the code was a bit uneven and makes diffs difficult.
Would you be interested in a clang-format pull request?

Sure that would be helpful!

So the first thing would be to guess your coding style
I have a procedure from https://github.com/AcademySoftwareFoundation/MaterialX/issues/652

Closing due lack of interest.


Feature idea : add open method, which always re-opens the page

It would be great to have an open page method, which always re-opens an URL even if it is already opened.
Currently, a workaround is to open and refresh which is not quite convenient. I suppose the use case is quite common, - changes made to the page are saved after calling open() method without a refresh, which is a bit confusing IMHO.
Use case for suggested open method :
@BeforeEach
open(URL)

@Test
modify page, assert

@Test
modify page, assert

....

Thanks

@Panwo Probably I didn't understand your question, but method open(URL) does exactly what you want: it opens given URL even if it was already opened.

@asolntsev
As I understand, when the same url is used in BeforeEachMethod, - page state remains unchanged before each new test execution, I expect that result of open method would be the same as clicking within a browser URL window and typing enter (same URL, but the page is refreshed)

It is also confirmed by test results when additional refresh is not used, all further open methods' execution time is much lower than the execution time of the first open method.
First open :

All next opens:

page state remains unchanged

No, it's not true. Every new open(url) does load the page again.

execution time is much lower than the execution time of the first open method

yes, this is normal because the first open call needs to start the browser (and sometimes load webdriver binary). It takes time. The following open calls already use the opened browser, but still load given url.


unable to run multiple MoneroUtils.getIntegratedAddress in parallel

Hello
I get error LibraryUtils.default.getWasmModule(...).queueTask is not a function when attempting to run MoneroUtils.getIntegratedAddress multiple times in parallel
Thank you

This is fixed with the last release. Thanks for reporting.


Error downloading object: Content/Characters/Mannequin_UE4/Animations/Jog_Fwd.uasset

Error downloading object: Content/Characters/Mannequin_UE4/Animations/Jog_Fwd.uasset (81b4dd2): Smudge error: Error downloading Content/Characters/Mannequin_UE4/Animations/Jog_Fwd.uasset (81b4dd2a00331ba3086ce06a8673667359183399c5fb1ab924060e2c84720691): batch response: This repository is over its data quota. Account responsible for LFS bandwidth should purchase more data packs to restore access.

solved by git lfs install && git lfs pull

Today we added more data packs, the issue should be resolved


Autocomplete stored procedure names in PostgreSQL

When I use CTRL+SPACE or . sign autocomplete feature shows me table names only. Is any way to get names of stored procedures also?
We use PostgreSQL 9.4.5 and DBeaver 3.7.4.

This is already supported in 4.x


RBAC in pipelines -- non-admin users are unable to view / create pipelines

Rancher versions:
rancher/server: Master 4/17
Steps to Reproduce:
As an admin user, create a cluster & enable pipeline integration w/ Github auth settings.
Add a standard user as a cluster owner or member.
Login as standard user, navigate to the existing cluster project & view pipelines. - All pipelines should be visible & new pipelines can be created.
Results:
Standard user cannot see any existing pipelines.
When adding a new pipeline, message that pipeline is not enabled is displayed with link to enable.
When clicking the link to enable, the user is logged out.

missing rbac rules for users as a project-owner.
In my test results:
As a Cluster-Owner, can list & add pipelines
As a Cluster-Member & Project-Member, can list & add pipelines
As a Cluster-Member & Project-Owner, cannot list & add pipelines
Should be fixed by https://github.com/rancher/rancher/pull/12573

Validated on master 4/18 - standard users can create/view pipelines if given access to cluster/project.


✨ Feat: add secure option in useStorage hook, shift question weights …

…to useStorage to handle incognito

Task linked: CU-85ztze460 Weighted Randomize Logic


possible MacOs issue

What happened?

i want to use the function https://python.stockindicators.dev/indicators/ZigZag/
it cant find the dll
i checked that the dll exists using:

ls -all /Users/myuser/my-pthon-project/venv/lib/python3.9/site-packages/stock_indicators/_cslib/lib

and it does exist.

System Version: macOS 15.2 (24C101), Kernel Version: Darwin 24.2.0
.NET for MacOs is installed:

dotnet --version
9.0.101

python.net is installed:

pip3 show pythonnet
Name: pythonnet
Version: 3.0.5

Code usage
from stock_indicators import Quote, EndType, indicators

...

results = indicators.get_zig_zag(quotes_list, EndType.HIGH_LOW, 3)

Log output
import sys; print('Python %s on %s' % (sys.version, sys.platform))
/Users/myuser/my-python-project/venv/bin/python -X pycache_prefix=/Users/myuser/Library/Caches/JetBrains/IntelliJIdea2023.3/cpython-cache /Users/myuser/Library/Application Support/JetBrains/IntelliJIdea2023.3/plugins/python/helpers/pydev/pydevd.py --multiprocess --qt-support=auto --client <IP_ADDRESS> --port 50730 --file /Users/myuser/my-python-project/scripts/find-candlestick-patterns.py
Connected to pydev debugger (build 233.13135.103)
Traceback (most recent call last):
  File "<frozen importlib._bootstrap>", line 1007, in _find_and_load
  File "<frozen importlib._bootstrap>", line 986, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 680, in _load_unlocked
  File "<frozen importlib._bootstrap_external>", line 790, in exec_module
  File "<frozen importlib._bootstrap>", line 228, in _call_with_frames_removed
  File "/Users/myuser/my-python-project/venv/lib/python3.9/site-packages/stock_indicators/__init__.py", line 17, in <module>
    from stock_indicators import indicators
  File "/Users/myuser/my-python-project/venv/lib/python3.9/site-packages/stock_indicators/indicators/__init__.py", line 3, in <module>
    from stock_indicators import _cslib
  File "/Users/myuser/my-python-project/venv/lib/python3.9/site-packages/stock_indicators/_cslib/__init__.py", line 25, in <module>
    clr.AddReference(skender_stock_indicators_dll_path)
System.IO.FileNotFoundException: Could not load file or assembly '/Users/myuser/my-python-project/venv/lib/python3.9/site-packages/stock_indicators/_cslib/lib/Skender.Stock.Indicators.dll, Culture=neutral, PublicKeyToken=null'. The system cannot find the file specified.

File name: '/Users/myuser/my-python-project/venv/lib/python3.9/site-packages/stock_indicators/_cslib/lib/Skender.Stock.Indicators.dll, Culture=neutral, PublicKeyToken=null'
   at System.Reflection.RuntimeAssembly.InternalLoad(AssemblyName assemblyName, StackCrawlMark& stackMark, AssemblyLoadContext assemblyLoadContext, RuntimeAssembly requestingAssembly, Boolean throwOnFileNotFound)
   at System.Reflection.Assembly.Load(AssemblyName assemblyRef)
   at Python.Runtime.AssemblyManager.LoadAssembly(AssemblyName name) in /home/benedikt/.cache/uv/sdists-v6/.tmpkW03e6/pythonnet-3.0.5/src/runtime/AssemblyManager.cs:line 234
   at Python.Runtime.CLRModule.AddReference(String name) in /home/benedikt/.cache/uv/sdists-v6/.tmpkW03e6/pythonnet-3.0.5/src/runtime/Types/ClrModule.cs:line 109
   at System.RuntimeMethodHandle.InvokeMethod(Object target, Void** arguments, Signature sig, Boolean isConstructor)
   at System.Reflection.MethodBaseInvoker.InvokeDirectByRefWithFewArgs(Object obj, Span`1 copyOfArgs, BindingFlags invokeAttr)
python-BaseException

What do you see when you run:
pip freeze --local

We also have a QuickStart tutorial that walks through setup steps in detail, if helpful.

@keltik85 were you able to resolve this issue on your own?

Some more details: it seems to be a compatibility issue with the .NET 9 runtime / SDK. The module imports correctly when using the .NET 8 runtime and SDK.

Some more details: it seems to be a compatibility issue with the .NET 9 runtime / SDK. The module imports correctly when using the .NET 8 runtime and SDK.

Helpful!  Thank you.  This DLL was built with .NET 8 and the internals for CLR must depend on that particular SDK.
This poses an interesting dilemma about maintaining environment compatibility — we could update that DLL to the latest  version built on .NET 9, but that’d be a breaking change for people who’ve not upgraded their environment accordingly.

@DaveSkender The target version of distributed dll is .NET 6.0. And that's how we're supporting all the versions above .NET 6.0.
Do we need to include the .NET 6.0 dll built on .NET 9..?
https://github.com/facioquo/stock-indicators-python/blob/main/stock_indicators/_cslib/__init__.py#L5-L8

@DaveSkender The target version of distributed dll is .NET 6.0. And AFAIK, that's how we're supporting all the versions above .NET 6.0. Do we need to include the .NET 6.0 dll built on .NET 9..?

That might work, let's update our build workflows to first just use .NET 9 SDK to see if it breaks similarly on MacOS builds (it should); then we can update use the net6.0 DLL from v2.6.0 which was built on .NET 9, to see if that works.


Minor tweaks to current Frontend/Gov banner

Making Gov banner consistent with other gov/federal webpages.

Changed styling under gov banner- "The .gov means it's official." Emboldened ".gov" and ".mil" in paragraph element to make consistent with other fed/gov websites.

@ValeriaReveles which PR fixes this?


Create Crossplane XRDs for following ressources:

[ ] RDS
[ ] Dynamodb
[ ] S3 bucket
[ ] Cloudfront
[ ] Gatsby agents
[ ] Web app

Closing issue, we will recreate the tasks individually when we get to them in the context of self-service @ DFDS


ISSUE-32 add google analytics opt out option

implements #32

add better description and options page layout - DONE
@simonhearne / @andydavies can you please look at the branch and suggest some descriptive text about the google analytics option

@simonhearne if you think it helps? perhaps a link to a predefined one?

Verified ok

@MalcolmSmithUK ready for review


Fix ordering of arguments to Matrix3.getElementIndex in documentation.

As they are reversed compared to the code.

Thank you so much for the pull request @srcejon! I noticed this is your first pull request and I wanted to say welcome to the Cesium community!
The Pull Request Guidelines is a handy reference for making sure your PR gets accepted quickly, so make sure to skim that.

:x: Missing CONTRIBUTORS.md entry.

Please add yourself to the contributors file!

:heavy_check_mark: Signed CLA found.
:grey_question: CHANGES.md was not updated.

If this change updates the public API in any way, please add a bullet point to CHANGES.md.

:grey_question: Unit tests were not updated.

Make sure you've updated tests to reflect your changes, added tests for any new code, and ran the code coverage tool.

Reviewers, don't forget to make sure that:

[ ] Cesium Viewer works.
[ ] Works in 2D/CV.

Note I added myself to CONTRIBUTORS.md in PR #9981

Thanks @srcejon! Would you mind adding yourself to CONTRIBUTORS.md here? This PR looks very straightforward and can be merged as soon as that file is updated.


raftstore: transfer leader should consider quorum progress

Signed-off-by: accelsao<EMAIL_ADDRESS>
What problem does this PR solve?
Issue Number: close #6106
Problem Summary: transfer leader should consider quorum logs
What is changed and how it works?
What's Changed:
add progress check while determine transfer leader or not, and add unit test
Related changes

Need to cherry-pick to the release branch

Check List
Tests

Integration test

Side effects

None

Release note
block transfer leader when followers log have not catch up

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Recognize contributor

https://github.com/gradle/gradle/pull/12816

@bot-gradle test and merge

Your PR is queued. See the queue page for details.

OK, I've already triggered a build for you.


make fmt update.

What this PR does / why we need it:
Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #
Special notes for your reviewer:
Release note:

NONE

/cc @rshriram

@gyliu513: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/pilot-e2e-smoketest.sh
44c3362fd69c3140226c07de98e8bbc3c1e0fe9d
link
/test pilot-e2e-smoketest

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


Wildcards character in publicPath not working for uploading source map

The resolve function from url package doesn't support wildcard characters.
Problem explaining
Let's assume we have a project, that outputs scripts.js and scripts.js.map in the root dist folder. The code is served from a subdomain of example.com, e.g. app.example.com and the files would be available at _https://app.example.com/scripts.js_ and _https://app.example.com/scripts.js.map_
Webpack config
  new BugsnagSourceMapUploaderPlugin({
    apiKey: 'YOUR_API_KEY',
    publicPath: 'https://*.example.com/',
  })

Expected
Source map files would be uploaded where url matches: https://*.example.com/scripts.js
Actual
The url that is being matched is https:///*.example.com/scripts.js (note the extra / before the wildcard).
Problem shooting
Turns out that the resolve function of the url package doesn't support * and hence resolves the URL to something unexpected. See source-map-uploader-plugin.js line 77
Changing publicPath in the webpack config produces following results:
publicPath: 'https:/*.example.com/' results https:/*.example.com/scripts.js
publicPath: 'https://*.example.com' results https:///scripts.js
Guess the publicPath: 'https:/*.example.com/' would work, since the wildcard in the result would then include the missing slash / in the protocol. However that would be a hack to circumvent the problem.

Hi @b-dur
Thanks for the report. We just recently became aware of this issue ourselves and are just scheduling a fix which we should be able to implement and release in the near future.
Thanks
Matt

@b-dur this has now been fixed in v1.4.1


wait-for-hosts loops forever until the user manually connects to serial consoles

Sal and Ron have found that connecting to each serial console in turn will fix the shell script checks for living VMs.
We should probably drop serial console support entirely.  We can't troubleshoot boot problems on VMs or physical hardware via serial console, so the first step in every troubleshooting process is to open a video console.

Fixed in #1242


[Feature Request] Google OAuth?

My reason:
For companies that use Google Apps & OAuth for authentication
Request:
Allow logging into verdaccio with Google OAuth, so users don't need a specific verdaccio username/password.

Since an authentication method must be a plugin, to fix this issue it has to be done in a separate repository. We will close this issue until pops up any proposal.

To create auth plugins with oauth flows, it must must be allowed for plugins to register own middleware, which has already been implemented in sinopia2 fork.
makes middlewares pluggable. i.e for custom oauth flows or analytics etc. #18

Afterwards this plugin sinopia-github-oauth can be easily transformed into bitbucket-oauth and also for other oauth providers.

Well, there is an easy PR if someone is willing to contribute 👍


Workaround Azure images not supporting rustup self update

@bors: r+

:pushpin: Commit 423300242ab527c72d7316602e03712eec4a9621 has been approved by gnzlbg

:hourglass: Testing commit 423300242ab527c72d7316602e03712eec4a9621 with merge 43cb5b3af75b3e4fb43452347d963a170579649a...

:sunny: Test successful - checks-cirrus-freebsd-11, checks-cirrus-freebsd-12, status-azure
Approved by: gnzlbg
Pushing 43cb5b3af75b3e4fb43452347d963a170579649a to master...


Thread-safe queued batched executor

Some changes to illustrate my proposal here.
Changes:

Added a way to handle batch overflow in BatchedExecutor (executor real batch size > params batch size).
Basically now BatchedExecutor has internal Queue of batches to process and it adds there a new batch in case of overflow.
Added some thread safety for BatchedExecutor.

Use case for this is to just run BatchedExecutor on a separate worker thread while using Conversation instances as front-end objects.

I like this approach of having a per-executor queue instead of a per-conversation queue is much better. I tried prototyping the per-cnoversation thing last night and it was looking very ugly!
I think there are a few thread safety issues in this implementation, but before getting into the details on that I wanted to ask some more questions about how you're using multiple threads in your setup.
There's a sequence of events you have to follow with the BatchedExecutor:

Prompt some conversations
Call infer
Sample the same conversations as prompted in step 1. This must be done before infer is called again.

How do you coordinate this with multiple threads?

Sample the same conversations as prompted in step 1. This must be done before infer is called again.

Oh, I've missed that condition and I've tested only with single conversation running at the same time, so probably it would'nt work with multiple conversations.
Right now I am just asynchronously waiting for RequiresInference/RequiresSampling flags in the Conversation wrapper and while single conversation is ok, multiple will cause issues as batch may be cleared before I sample.

So I've added a logit cache that would keep all logits based on epoch and batch index. Admittedly it creates some copying and memory overhead, so maybe it's not the best solution.

Now for some reason Guidance example stopped working :/

I think we're paying quite a high cost for thread safety here, both in terms of additional complexity and also actual runtime cost with the copying of the logits.
Do you mind if I take the queueing idea and implement that in a separate PR, and we discuss thread safety some more to work out the best way to do it?

Sure, that's fine by me.

Maybe it would be okay to just create another executor with this functionality?

It could be done as a threadsafe wrapper, or by adding thread safety into the batch/conversation objects themselves.
My main concern really is just working out how multithreading is expected to be used here - as far as I can see the only part of the whole process that can really benefit from parallelism is sampling (which isn't currently threadsafe, so there's definitely some benefit to be had there).

My main concern really is just working out how multithreading is expected to be used here - as far as I can see the only part of the whole process that can really benefit from parallelism is sampling (which isn't currently threadsafe, so there's definitely some benefit to be had there).

For unity case it's that:
a) Infer should not block main application thread
b) Hard to synchronize components all over the place that may use Conversation. E.g. two dialogues happening around same time, both requesting for next line to be generated.
Hence worker (Executor) with an inference job queue (coming from Conversations) is a natural answer.
Probably true for web services as well (although I never did those in c#, so no idea).

Infer should not block main application thread

For this issue, would using something like this work? The actual inference work in infer is already shifted off to another thread, so if you call infer and then yield instead of blocking on it that should free up the main thread (I think).

Dayum, I've missed this Task.Run in LLamaContext.DecodeAsync and I thought it was calling Decode directly. That simplifies a lot of things, got to test this.

I'll close this PR now, since I think we've moved in a bit of a different direction with BatchedExecutor.
I did experiment quite a lot with different systems based on this idea, but I couldn't quite find anything that works yet. Allowing over-size batches which are then split up into many smaller batches introduces a huge amount of incidental complexity into the executor. It's still something I'd like to address though (some kind of solution will be required for image embeddings, which are almost guaranteed to overflow the batch).


JSON schema is incorrect in website Dest should be Dst

https://fabiolb.net/ref/registry.backend/
The custom JSON schema field dest is incoorect it should be dst, I am currently trying to write a bridge for K8S services that are not descoverable by Consul due to lack of health checks and came across this issue
[
 {
  "cmd": "string",
  "service": "string",
  "src": "string",
  "dest": "string",
  "weight": float,
  "tags": ["string"],
  "opts": {"string":"string"}
 }
]

Should be dst... also would be useful to have some descriptions for the fields, I would gladly make a PR but I did not find the source code for the website...

it looks like docco is on the gh-pages branch...

thanks, ill do a PR

I have opened https://github.com/fabiolb/fabio/pull/854 but I am not sure who is maintaining this project right now.


Sidebar is not open permanently

Description
I always want to keep open sidebar, but everytime:

if i open vs code with fresh session ( -N i mean ) ➡ sidebar is close
if i open file with right click ( edit with VSCode ) ➡ sidebar is close
if i open new window ( File > New Window ) ➡ sidebar is close

Of course, pressing Ctrl + B is not a big deal, but if I have to do it every day several times, it is very very frustrating 😞 . Can we do something with this?
Please let me know how I can set sidebar permanently open

Technical info
Version: 1.36.1 (system setup)
Commit: 2213894ea0415ee8c85c5eea0d0ff81ecc191529
Date: 2019-07-08T22:59:35.033Z
Electron: 4.2.5
Chrome: 69.0.3497.128
Node.js: 10.11.0
V8: 6.9.427.31-electron.0
OS: Windows_NT x64 10.0.18362

Does this issue occur when all extensions are disabled?
Yes

We could introduce an option similar to workbench.startupEditor
Though I have no plans to tackle this now, thus leaving it open and assigning to backlog.
An alternative is to save this state globaly and not per workspace, which might make sense. Though it might also break other users behavior.

Thank you for the information.
I understand and look forward to developing this case. I hope you can do it.
I think that the option satisfying everyone would be something like:

"workbench.startupSidebar"

with the following options:

[ ] always (sidebar will always be open each time on startup)
[ ] never (never show sidebar on startup)
[ ] one (remember state from previous session)

Related tickets:
https://github.com/microsoft/vscode/issues/63354
https://github.com/microsoft/vscode/issues/3742

Agree, let's close as duplicate of https://github.com/microsoft/vscode/issues/63354
And you can add your point of view in that issue. Thanks


Bandit report

I decided to execute bandit on the codebase after seeing on its README that assert must be avoided and it's also considered as general bad practice in OpenStack codebases (outside tests).
Run started:2020-07-27 19:42:42.741117

Test results:
>> Issue: [B404:blacklist] Consider possible security implications associated with subprocess module.
   Severity: Low   Confidence: High
   Location: src/aiohabit/actions/ssh.py:18
   More Info: https://bandit.readthedocs.io/en/latest/blacklists/blacklist_imports.html#b404-import-subprocess
17	import os
18	import subprocess
19
20	from aiohabit.errors import ApplicationError

--------------------------------------------------
>> Issue: [B322:blacklist] The input method in Python 2 will read from standard input, evaluate and run the resulting string as python source code. This is similar, though in many ways worse, then using eval. On Python 2, use raw_input instead, input is safe in Python 3.
   Severity: High   Confidence: High
   Location: src/aiohabit/actions/ssh.py:53
   More Info: https://bandit.readthedocs.io/en/latest/blacklists/blacklist_calls.html#b322-input
52	            try:
53	                host_idx = int(input("Enter a number of host to ssh into: "))
54	            except ValueError:

--------------------------------------------------
>> Issue: [B603:subprocess_without_shell_equals_true] subprocess call - check for execution of untrusted input.
   Severity: Low   Confidence: High
   Location: src/aiohabit/actions/ssh.py:119
   More Info: https://bandit.readthedocs.io/en/latest/plugins/b603_subprocess_without_shell_equals_true.html
118	        print(cmd)
119	        process = subprocess.Popen(cmd, **run_args)
120	        process.communicate(input=psw_input)

--------------------------------------------------
>> Issue: [B101:assert_used] Use of assert detected. The enclosed code will be removed when compiling to optimised byte code.
   Severity: Low   Confidence: High
   Location: src/aiohabit/providers/aws.py:106
   More Info: https://bandit.readthedocs.io/en/latest/plugins/b101_assert_used.html
105	        ids = [srv.id for srv in aws_res]
106	        assert len(ids) == 1  # ids must be len of 1 as we provision one vm at the time
107
108	        # creating name for instance (visible in aws ec2 WebUI)
109	        self.ec2.create_tags(

--------------------------------------------------
>> Issue: [B101:assert_used] Use of assert detected. The enclosed code will be removed when compiling to optimised byte code.
   Severity: Low   Confidence: High
   Location: src/aiohabit/providers/aws.py:148
   More Info: https://bandit.readthedocs.io/en/latest/plugins/b101_assert_used.html
147	        response = self.client.describe_instances(InstanceIds=[aws_id])
148	        assert len(response["Reservations"]) == 1
149	        assert len(response["Reservations"][0]["Instances"]) == 1

--------------------------------------------------
>> Issue: [B101:assert_used] Use of assert detected. The enclosed code will be removed when compiling to optimised byte code.
   Severity: Low   Confidence: High
   Location: src/aiohabit/providers/aws.py:149
   More Info: https://bandit.readthedocs.io/en/latest/plugins/b101_assert_used.html
148	        assert len(response["Reservations"]) == 1
149	        assert len(response["Reservations"][0]["Instances"]) == 1
150	        result = response["Reservations"][0]["Instances"][0]

--------------------------------------------------

Code scanned:
	Total lines of code: 1950
	Total lines skipped (#nosec): 0

Run metrics:
	Total issues (by severity):
		Undefined: 0.0
		Low: 5.0
		Medium: 0.0
		High: 1.0
	Total issues (by confidence):
		Undefined: 0.0
		Low: 0.0
		Medium: 0.0
		High: 6.0
Files skipped (0):

Shouldn't we run it only on src dir and not tests. Most/all? of the asserts problem are from tests dir.

I agree, we should fix the asserts on src only.

+1 for removing the asserts. From the other issues. I'd ignore the B322:blacklist (the only "high" one). As it says it applies only for Python2 and is safe for Python3. Q is if we can somehow configure it to appear in other runs.  With the 2 subprocess things. I'm not sure what to do about them. IMHO we want to call "ssh". But we probably doesn't need "shell==True".

Some isssues might be fixed byt this PR
https://github.com/pvoborni/mrack/pull/24

Closing this, most of the issues were fixed, the remaining ones are related to subprocess and how we parse xml from Beaker.
Full report: bandit-report.txt


Fix broken link in Pod Security Standards

Fixed Broken Link in Security Pod Security Standard #40867

/retitle Fix broken link in Pod Security Standards

@niranjandarshann Thanks for the contribution. The new target link added as a part of this PR is not correct. I have included some inline suggestions.
Deploy Preview: deploy-preview-40885-pod-security-standards

@dipesh-rawat  please find the updated commit.

@niranjandarshann I see the Netlify build failed due to timeouts. Could you try to trigger the build again using:
git commit --amend --no-edit && git push --force-with-lease

@niranjandarshann I see the Netlify build failed due to timeouts. Could you try to trigger the build again using: git commit --amend --no-edit && git push --force-with-lease

@dipesh-rawat  thank you for your support but still facing issue. I am looking for it to get resolved.

@dipesh-rawat  now all the test case pass, requesting you for review.

/lgtm
/approve


Publishing packages by name may fail with "not found error".

When passing in a package by name (in YAML or when publishing from **/*.nupkg) a query is done to find the packageId. The result is only the top 1000 items, which may not be enough if your feed is proxying upsteam sources.
As a quick-fix I've added packageNameQuery=$packageId to the API call, this should limit the number of returned items quite a bit. But in weird cases this may still fail. The correct solution it to use the packageNameQuery and use top=&skip= in a loop.
See:
https://github.com/renevanosnabrugge/vsts-promotepackage-task/commit/91ba34193a1d66a83a2272e7e7be38de21e3c971

The work around has likely fixed:

https://github.com/renevanosnabrugge/vsts-promotepackage-task/issues/56
https://github.com/renevanosnabrugge/vsts-promotepackage-task/issues/51


Real Estate Cooperative Dao

Platform for Collective Ownership of Real Estate - Fractional Ownership, Cooperatives

[ ] _ My name is Mateo.  I am inventor and writer, academically trained in philosophy, originally from US, I spent last 7 years in developing countries (Argentina, Brazil, Kenya) trying to figure out how to leverage blockchain tech for social good.  I know a bit of solidity, but am better at big-picture abstract thinking than detailed coding.
[ ] _ I am researching projects in Blockchain space, most interested in DAOs and real estate, and cryptoart, but also try to follow the infrastructure development.
[ ] _ Simon de la Rouviere told me about the Ethereum crowdsale at a Bitcoin Conference in South Africa
[ ] _ Am based in Berlin, and attended EthBerlin last year, was part of a team that won a prize from Gnosis

Idea description
What is your idea? Give as many details as you possibly can.
The background of the idea can be viewed here:   It would essentially allow owners of real estate to whitelist addresses and sell fractional ownership of their real estate.  The bigger idea is to create a platform that allows both real estate owners and dwellers to customize and deploy a contract suite to suit their needs.  The project is inspired in large part by Radical Markets And the idea that space can be better utilized via an auction system, which additionally will allow people to be more mobile, and actually share via p2p, versus "sharing" through a central entity.  I say dwellers (instead of renters) because the overarching goal of this project is to reorient the dichotomy of home ownership / renting to something that makes more sense for urban environments where there is lack of affordable housing, and this terminology is borrowed from Doma project.
A further step after the MVP is to either create DAO functionality within the platform or plugin to other DAO-stacks (Aragon, Colony, Dorg, DaoStack) to get Cooperative ownership of buildings, or rather more that the buildings autonomously owns themselves and are managed through dwellers that participate via the smart contracts and DAO.  The same way Nathan Schnieder talks about having a way for tech-startups to IPO into cooperatives (becoming working owned), there are a lot of buildings with aging landlords where the renters can step-by-step gain more equity in the building over time, without having to resort to go to a bank for mortgage.  Similarly the landlords can divest their real estate holdings piecemeal while continuing maintenance and upkeep without being forced to sell to large property management conglomerate.
_ There are a lot of 'low-hanging' fruit bounties we can go after, since obviously full implementation of the project in 3 days is imposible.

3Box - Most Social Application - Housing Cooperative
3Box - Best Overall 3Box Integration -User Names for Addresses
Raiden - IoT Challenge - Unlocking a Door for Short-Term Rental

A simple implementation could look like this:
`Implementation One:
Legal (legacy) Owner of Real Estate wishes to open up her property to fractional ownership.

sign Tx to create contract
• Owner has functionality to whitelist other potential owner’s addresses.
• Owner has also functionality to limit ownership on offer (e.g. to maintain 51% ownership if desired)1
• Token creation event

Whitelisted address wishes to purchase percentage of ownership.

sign Tx to become member of contract
• After being whitelisted member sends ETH to contract in order to receive fractional ownership of contract
• A percentage of ETH goes into the tax and maintenance fund.
• Member receives ‘ownership’ tokens equal to the fractional percentage of of ownership she has invested.
• Member receives ‘use’ tokens equal to the fractional percentage of ownership she has invested. However this tokens have viability period of 365-days and if not used within time frame they are destroyed by the contract.

Owner or Real Estate (51%) wishes to pay taxes or maintenance with contract funds.
-sign Tx to withdraw ETH from contract to pay taxes maintenance (this could maybe be implemented on Aragon).
• Upon approval process, the request funds to pay taxes or maintenance are moved out of the contract to

Owners wish to book use of space.
-sign Tx to book space per day.  Contract must query calendar, and price owners pay can be discounted with ‘use’ tokens.
• Calendar displays unbooked days
• Whitelisted addresses can book days by paying required booking price
• Before sending TX book, option to discount price with ‘use’ tokens will be available in booking dashboard.

Owners wish to withdraw ownership.
-sign text to withdraw ETH originally invested.
 • Users original ETH investment is returned
• Existing ‘Use’ tokens are evenly distributed to remaining members
• The Tax and Maintenance portion of originally investment is not returned to user.  If the balance of Tax and Maintenance fund is over threshold a portion of the funds can also be evenly distributed to remaining `members.`

Skillset
What skills do you need, or think you might need to implement the idea?

[ ] Core Blockchain Development (Go, C++, Rust)
[ X] Smart Contracts (Solidity - and specifically someone who can do test-driven development)
[ X] DApps, Web3.JS (JavaScript, CSS)
[X ] Design, User Experience
[ ] Project Management
[ ] Game theory
[X ] _Any lawyer or people in Real Estate Industry, specifically Germans who are familiar with genossenschaft laws

Communication

[ ] Riot handle: bendicion

Hi Mateo, I found this idea quite interesting.
I could help with the smart contracts part (Solidity, Vyper - not an expert but can implement things). Moreover, a colleague could implement the JavaScript part.
I will write you a message on Riot.

If you plan to integrate with Raiden, check out the client I just build for the Grow Ethereum hackathon.
https://github.com/wslyvh/raiden-api-client
I'll be around all weekend, if you need help with it.

Hi there! I would love to help wit the Product Design, UX and Project Management & GT

Hi Mateo, I write you on Riot.


manageiq env plugins should update everything on bin/update

provider devs need to go through some manual commands to update their env to the latest miq branch. I.e. they would need to run bin/update; bundle update; rake spec:setup
this PR

changes manageiq_plugin_setup to run bundle update --> bin/update will actually update your dependencies
make the rake task test:vmdb:setup work when run from app:test:vmdb:setup
thus removes the need to have a Gemfile.lock inside spec/manageiq because no rake task is run from within this directory

see https://github.com/ManageIQ/manageiq-providers-ansible_tower/pull/11 how this would work in a provider

@bdunne please have a look

@bdunne have a look again. I also updated the PR description


⚠ Secret Website 3 has degraded performance

In 2e7170a, Secret Website 3 ($SECRET_WEBSITE_3) experienced degraded performance:

HTTP code: 200
Response time: 2312 ms

Resolved: Secret Website 3 performance has improved in cb13045.


Problems with dynamic data sources

When row focus changes, the getItemAt method is called to identify the focused item at the given row. This strategy fails, if the data provider return dynamic data (e.g. retrieved from a database).
It might happen that the database fetch initiated by the FocusListener return a different item for "row n" than when the grid filled its rows.
Therefore, the item field in a RowFocusEvent might be wrong.
Is there a way to fix this issue?

I think this is more generic issue. In the described case it is not just that wrong item is being returned. Actually the content shown in the Grid is kind of wrong as well, since it is not anymore reflecting the state of the data.

Is there a way to fix this issue?

There is no easy fix, and likely there is no fix that would not have significant performance impact.


fix(docs): @utils.use_signature formatting

Related to https://github.com/vega/altair/pull/3444#issuecomment-2196481574
Ready for review
API Functions
Before

After
*This change isn't related to the sphinx theme, which seems to be on a newer version. See table issue

Example (binding_radio)
Before

After

Misc
I didn't go through trying to fully resolve the mypy issues with @utils.use_signature.
However, I've updated the comments for future reference.

Good find! Thanks @dangotbanned!


feat(scale): ✨ add isEnharmonicWith methods

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 12 (100.0%)  changed or added relevant lines in 3 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
1086

Relevant Lines:
1086

💛  - Coveralls


Add flexo beard as SVG for project icon

Hi,
This is the SVG I created for consideration as project icon.  Thanks :)
Clemmitt Sigler

Thanks! I've merged it and included it into the README.md.

Hi,
Very pleased I could contribute :)
Clemmitt


[release-1.7] Enable TCP Telemetry v2 export via Stackdriver filter

Manual cherrypick required.
#25646 failed to apply on top of branch "release-1.7":

https://github.com/istio/istio/pull/26268 fixed this.


nvim config incomplete

Hi,  the nvim config is incomplete. I get heaps of errors when running it. Could you please upload the whole thing.

@plasmoduck its just a really shitty config


no-$ref-siblings URL Returns 404

When violation "a $ref cannot be placed next to any other properties" is produced, the learn more about URL for no-$ref-siblings returns a 404

Will fix ASAP.

This has been fixed in v0.0.48


Implement to_fits method on RHESSIVisibility

Can't write out a proper RHESSI fits file don't keep the control and info extensions and have no way to crated them. Should be able to read in / write out a visibility structure which is compatible with RHESSI software

Closed in #32


Make sure pip install BanditPAM recursively clones the repo

We moved carma to a submodule and should ensure practitioners get the right version of it from PyPi

If installed directly from a wheel, the submodules are not necessary.
Otherwise, the full source code uploaded to PyPi contains the submodules.


Errors in Sublime Console on Start

Haven't had the time to take a look at these in detail yet, but figured I'd list them out here.
Traceback (most recent call last):
  File "C:\Program Files\Sublime Text4\Lib\python33\sublime_plugin.py", line 1494, in run_
    return self.run(edit)

  File "C:\Users\USERNAME\AppData\Roaming\Sublime Text\Installed Packages\OrgExtended.sublime-package\orginsertselected.py", line 187, in run

  File "C:\Users\USERNAME\AppData\Roaming\Sublime Text\Installed Packages\OrgExtended.sublime-package\orginsertselected.py", line 137, in down

AttributeError: 'OrgInput' object has no attribute 'matched'

Traceback (most recent call last):

  File "C:\Users\USERNAME\AppData\Roaming\Sublime Text\Installed Packages\OrgExtended.sublime-package\orginsertselected.py", line 123, in on_change

  File "C:\Users\USERNAME\AppData\Roaming\Sublime Text\Installed Packages\OrgExtended.sublime-package\orginsertselected.py", line 81, in redraw

AttributeError: 'OrgInput' object has no attribute 'matched'

Good call.
Do you happen to recall what you were doing or what document you were looking at when that triggered? If it's on boot it could be any of the open tabs as I scan all open tabs as sublime starts.

The changes have been pushed to the repo. The exceptions seem to happen when the system is trying to determine what to do in the tooltip box. It shouldn't throw now although the tooltip will be blank.

I actually wasn't doing anything in Sublime at all. I have it open on a side screen all day and these messages are just appearing every couple of minutes or so. I could probably set my clock to it :-) Could these issues be stemming from the way path is set in orgDirs. I am on Windows and have it set to my Dropbox in the config file like so:
// Where are your org files?
"orgDirs": "c:\\Users\\olegbc\\Dropbox\\Oleg\\Org\\NewOrg",

Also, I saved the sublime startup log from the console just in case it may help figuring out what may be causing problems.
Sublime-startup-4-1-2021.log

Well that is concerning. The callstack looks like you have an input box open for some reason so you are on the date picker or inserting a tag or something. It's the tooltip help for that, that is asserting. My fix should get rid of the callstack but if this is a regular cadence we need to understand the root cause and get to the bottom of this.
Every couple of minutes makes me think this is the notifications thread (or I guess it could be an EventListener as well but that probably wouldn't be a regular cadence and probably would require some input from you)
2 Things to try here:
FIRST set this in your settings file:
"enableDebugLogging": true,
This will turn on more verbose trace logging. I don't know if that will help us here but it's worth a shot.
NEXT since I think this might be related to the notifications thread lets play with the period of that thread and see what happens. The problem here is changing the period means you have to restart sublime when you tweak it.
Open up you settings file for orgextended and add this:

"noticePeriod": 9999

Does that make this effectively go away or not happen on a regular period?
Next thing:

"noticePeriod": 1 (this will make it fire a notice every 60 seconds)

See if it comes back?
Would you do that for me? That can help us narrow this a little and try to validate my guess.

What is annoying about that error message is that I know WHAT is causing the exception, I just don't have the context of what is causing the InputBox code to trigger.

Interesting looking in your log this is certainly something to investigate:
orgDir path c does not exist!
Traceback (most recent call last):
File "C:\Program Files\Sublime Text4\Lib\python33\sublime_plugin.py", line 528, in on_api_ready
plc()
File "C:\Users\olegbc\AppData\Roaming\Sublime Text\Installed Packages\OrgExtended.sublime-package\orgextended.py", line 75, in plugin_loaded
db.Get().RebuildDb()
File "C:\Users\olegbc\AppData\Roaming\Sublime Text\Installed Packages\OrgExtended.sublime-package\orgdb.py", line 307, in RebuildDb
if not Path(orgPath).exists():
File "C:\Users\olegbc\AppData\Roaming\SUBLIM~1\Packages\pathlib\all\pathlib.py", line 1176, in exists
self.stat()
File "C:\Users\olegbc\AppData\Roaming\SUBLIM~1\Packages\pathlib\all\pathlib.py", line 1051, in stat
return self._accessor.stat(self)
File "C:\Users\olegbc\AppData\Roaming\SUBLIM~1\Packages\pathlib\all\pathlib.py", line 346, in wrapped
return strfunc(str(pathobj), *args)
OSError: [WinError 123] The filename, directory name, or volume label syntax is incorrect: ':'

I found a problem orgDirs is a list, it looks like you have it set to a string.
I have a fix that will automatically handle that now.

Looks like most of your problems are probably stemming from that.

Okay, I think we made some progress here. These fixes will be in 1.2.6.

Did I set orgDirs to a string by accident in my config somehow? Turning on verbose logging and will share them shortly

Yeah, the example you gave of your config had your orgDirs set to a string vs a list of strings, but the loader didn't check and just tried to iterate over that string! :)

Pushed 1.2.6

Sorry for not responding earlier. You've definitely fixed the issue, I don't see any errors in the console anymore.

Great!


Removed "pony" :)

http://svdictionary.com/words/ponyfill

Wow... I thought it was typo. Sorry :)


update with new required callbacks

Ecto 3.2.0 came out a couple days ago, and it adds some new required callbacks to Ecto.Type. This PR adds those new callbacks and uses the same defaults as Ecto chose to.
Ecto changelog here: https://github.com/elixir-ecto/ecto/blob/master/CHANGELOG.md#enhancements
Ecto defaults here: https://github.com/elixir-ecto/ecto/blob/master/lib/ecto/type.ex#L86-L87
This fixes #91

Thanks for fixing this @dnsbty :tada: :green_heart:
A merge and release would be appreciated :dancer:

Still shows warnings during compilation
==> ecto_enum
Compiling 5 files (.ex)
warning: function embed_as/1 required by behaviour Ecto.Type is not implemented (in module EctoEnum.Typespec.TestModule.PGStatusEnum)
  lib/ecto_enum/typespec.ex:28: EctoEnum.Typespec.TestModule.PGStatusEnum (module)

warning: function equal?/2 required by behaviour Ecto.Type is not implemented (in module EctoEnum.Typespec.TestModule.PGStatusEnum)
  lib/ecto_enum/typespec.ex:28: EctoEnum.Typespec.TestModule.PGStatusEnum (module)

probably due to import instead of use in https://github.com/gjaldon/ecto_enum/blob/master/lib/ecto_enum/typespec.ex#L24
Anyway, I don't understand why test code is in lib instead of test/support

Also still gives warnings, but if you do use Ecto.Type it'll work

Anyway, I don't understand why test code is in lib instead of test/support

The reason is explained pretty clearly in the @moduledoc.

You'll also need to add it to lib/ecto_enum/postgres/use.ex, and it'll then compile without warnings.

Thank you all for the contributions. Would very much like to see this released.

@gjaldon anything I can do to help get this through quicker? We can run off my fork for now, but I'd rather stick with the official repo when possible.

I appreciate all the approvals, but I don't have write access. I think only @gjaldon can merge this.

Hey @gjaldon, not to rush you, but can you take a look?

Any ETA on when this could land in master with a bumped version @gjaldon ?

Hm @gjaldon might not be doing OSS right now/might not have time for it. Aka no answer here so far. Someone might want to try and reach out in some other media (but politely) or we wait until he checks here again :)

I reached out via email yesterday

For anyone wanting a quick fix before the release just use this mix.exs setup:
{:ecto_enum, github: "dnsbty/ecto_enum", ref: "a69a9dde72cf98497606f9603bd46e3924979145"},

Which will pick up only the fix here https://github.com/dnsbty/ecto_enum/commit/a69a9dde72cf98497606f9603bd46e3924979145
Then switch back once released.

Great work everyone!
It has been a while since this PR was opened. In the event that it does not get merged soon would anyone be interested in taking up maintenance and pushing to Hex under a new name? It would be nice to pull deps from GitHub.

@lpil I considered requesting the name from Hex under their dispute policy for abandoned packages so that we everyone wouldn't have to update their package name. Does that seem too drastic?

I think a change of package name is good from a security point of view because then people know that the ownership has changed and that they need to re-evaluate their trust of the library as a result. It is always possible that a malicious actor takes over an abandoned package so better for the switch to be explicit and opt in.
There has been some high profile attacks in the npm ecosystem recently where a package name changed hand like this and the new owner used the good reputation of the old owner to inject malicious code via what looked like a routine update.

Note I'm not trying to say that you are untrustworthy, just that I think that mutable package names is not ideal from a security point of view.

@lpil I considered requesting the name from Hex under their dispute policy for abandoned packages so that everyone could keep pulling without changing the package name. Does that seem too drastic?

I won't go as far as suggesting that this project has been abandoned. There was some relatively recent activity on this project (last 3 months). I do hope this gets merged soon, though.

Yes, I hope the policy for abandoned packages would not trigger here yet.

I agree that it's unfair to say this project is abandoned yet, since this a relatively minor issue with a clear, and safe workaround (https://github.com/gjaldon/ecto_enum/pull/92#issuecomment-542627004).
That said, how long is too long to wait for an official release before blessing a fork with a new maintainer? Has anyone heard from @gjaldon in other channels?

My company uses EctoEnum often - we would happily take up maintenance if there's demand for it.
Having multiple users with write permission would help avoid this kind of bottleneck in the future. Would anyone else here like to volunteer as an active maintainer?

We use it a fair amount at Podium as well, so I think we would be open to maintaining as well. It might be nice to have multiple maintainers so that we can avoid a similar issue in the future.

💜 thank you!

@gjaldon Thank you very much! :green_heart: :rocket: :tada:

Thank you very much!


Obsidian Hotkeys (at least some) Don't Work in Cells

Describe the bug
When I want to introduce some text in a cell by using a hotkey that works everywhere across obsidian, nothing happens. It also happens, for instance, when using shortcodes or boxes to introduce emojis.
Steps to reproduce

I'm inside a cell, formatted as text.
I press ALT + H, the hotkey I use for introducing current time. Or use : shortcode for entering an emoji, or obsidian plugin command hotkey to open a box to enter an emoji.
Nothing happens (as opposed as anywhere else in obsidian where the current time/emoji would be inserted)

Expected behavior
To hotkeys to introduce text, emojis, etc., to work as everywhere else in Obsidian.
Are you using the mobile app?
 Which plugin is this?

@trey-wallis I also came across this issue when attempting to make text bold or italic.

There is no auto complete for bold or italic right now.


fix: Make react a peer dependency

Why
to avoid multiple react versions in the consumer

@marcel-casavo just 2 notes on the PR itself:

shorter PR name
fill the part of the template that you need istead of leaving as-is
add the typology label (chromatic wasn't required for this issue, but that not important)

tested locally with run dev and the builds command and LGTM 🚀

Thanks @moebiusmania, good points, thanks for the updates you did.
The draft PR was empty because the objective was only to test the CI in regards to a potential chromatic deploy to see if everything works as expected.

@moebiusmania  @pietrograndi  I reverted the package.json version bump as if I'm not wrong it's supposed to be in the commit that does the new release.

@marcel-casavo it was correct 😄 no need to have another PR just to bump the package, just reset to the prvious one and force push


Add Events API helper middleware

Hey there! We're currently using the slack library in our project, but had a need to use the Events API as well. I'm trying to contribute back some middleware we developed to get the Event API up and running.
I saw this was requested in #94, and unfortunately I don't have time to write parsers for all the event structures right now, I'm hoping that this middleware is general enough to provide as a starting point for future work.
Commit Message:
In order to use slack's Events API, your webhook must respond to a challenge request from Slack. This commit adds middleware that will look for Slack's challenge request and responds. Any other valid JSON request is forwarded to the user's handler for parsing.

doesn't seem like there is intent to ever pull this in


Different server issue

Have you had issues arise when moving from a local server to remote? All settings are the same in the package and records are being stored okay but no records are being pulled from the database on the remote server.

Ok, not an issue with the package. Apologies


tokenmeta dstore needs to re-query dns on s3 failure

tokenmeta keeps trying to connect to and s3 endpoint where the IP address changed (DNS is the same).  So the same request fails over and over and over.
(tokenmeta) starting run loop (bstream/eternalsource.go:103)
(tokenmeta) new live joining source (tokenmeta/pipeline.go:31){"start_block": "#150221099 (08f4312b9cd3d38ed1f859f4b2d68e3b6bd600368e20714b3d24e9ce902884e1)"}
(tokenmeta.js) creating new joining source (bstream/joiningsource.go:90)
(tokenmeta.js) Joining Source is now running (bstream/joiningsource.go:175)
(tokenmeta.js) joining state JOINING (bstream/joiningsource.go:541){"block_behind_live": 0, "last_file_block": 0, "last_live_block": 0, "last_merger_block": 0, "buffer_lower_block": 0, "buffer_higher_block": 0}
(tokenmeta.js.live) starting block source consumption (blockstream/source.go:152)
(tokenmeta.js.live) block stream source reading messages (blockstream/source.go:160)
(tokenmeta.js.live) source shutting down (blockstream/source.go:154){"error": "file source failed: reading file existence: ServiceUnavailable: Service Unavailable\n\tstatus code: 503, request id: tx000000000000000041387-005fa15eb3-bb684e-default, host id: "}
(tokenmeta) eternal source failed (bstream/eternalsource.go:125){"error": "file source failed: reading file existence: ServiceUnavailable: Service Unavailable\n\tstatus code: 503, request id: tx000000000000000041387-005fa15eb3-bb684e-default, host id: "}
(tokenmeta) sleeping before restarting underlying source (bstream/eternalsource.go:128){"wait_time": "2s"}
(tokenmeta) starting run loop (bstream/eternalsource.go:103)
(tokenmeta) new live joining source (tokenmeta/pipeline.go:31){"start_block": "#150221099 (08f4312b9cd3d38ed1f859f4b2d68e3b6bd600368e20714b3d24e9ce902884e1)"}
(tokenmeta.js) creating new joining source (bstream/joiningsource.go:90)
(tokenmeta.js) Joining Source is now running (bstream/joiningsource.go:175)
(tokenmeta.js.live) starting block source consumption (blockstream/source.go:152)
(tokenmeta.js.live) block stream source reading messages (blockstream/source.go:160)
(tokenmeta.js) joining state JOINING (bstream/joiningsource.go:541){"block_behind_live": 150529436, "last_file_block": 0, "last_live_block": 150529436, "last_merger_block": 0, "buffer_lower_block": 150529233, "buffer_higher_block": 150529436}
(tokenmeta) eternal source failed (bstream/eternalsource.go:125){"error": "file source failed: reading file existence: ServiceUnavailable: Service Unavailable\n\tstatus code: 503, request id: tx00000000000000004138b-005fa15eba-bb684e-default, host id: "}
(tokenmeta) sleeping before restarting underlying source (bstream/eternalsource.go:128){"wait_time": "2s"}
(tokenmeta.js.live) source shutting down (blockstream/source.go:154){"error": "file source failed: reading file existence: ServiceUnavailable: Service Unavailable\n\tstatus code: 503, request id: tx00000000000000004138b-005fa15eba-bb684e-default, host id: "}

In this case the s3 server is sending back HTTP error 503.

mindreader and merger work fine.  other components seem to not.

I can't reproduce by simply closing the endpoints:
local setup:

minio(1) listening on <IP_ADDRESS>
minio(2) listening on <IP_ADDRESS>

dns ceph.stepd A record pointing to both .1.1 and .2.2
a) if I close .1.1, I don't get a failure.
b) if I also close .2.2 I get failures in a loop (every 2 seconds) on tokenmeta:
2020-11-04T09:54:24.890-0500 (tokenmeta.js.live) source shutting down (blockstream/source.go:154) {"error": "file source failed: reading file existence: RequestError: send request failed\ncaused by: Head \"http://ceph.stepd:9000/blocks/0000000700.dbin.zst\": dial tcp <IP_ADDRESS>:9000: connect: connection refused"}
...

c) I edit the DNS entry and add <IP_ADDRESS> to ceph.stepd, then I start a minio instance listening only on that new address, and see blockmeta successfully passing over that 'reading file existence' step, printing the next log line: reading from blocks store: file does not (yet?) exist, retrying in (bstream/filesource.go:139) {"filename": "0000000700.dbin.zst", "base_filename": "0000000700", "retry_delay": "4s"}

so locally, when I set common blocks folder like this:
s3://ceph.stepd:9000/oneblocks?region=none&insecure=true&access_key_id=minio&secret_access_key=miniostorage
tokenmeta will successfully switch to a new endpoint (added in DNS) in case of failure...
I see the same behavior inside the relayer (it successfully connects to the next endpoint added in DNS -> relayer uses the same 'eternal joining source' pattern from the same library...

I am curious what kind of failure you tested.  In my test the connection was still active, but returning 503 errors.  That might be different than killing the entire service so the TCP connection breaks.


[Feature] network latency

ms

Yantze老师说参考这个实现：
https://github.com/opensumi/core/blob/ac49c6592914cf6532bb84ba368ca77b030bf7c5/packages/addons/src/browser/connection-rtt-contribution.ts#L33


Creating a "flyout" window

I'm using the term "flyout" not really knowing if that's the correct word, but what I mean is a window that usually has no borders and can be closed simply by clicking outside the window bounds. Think of the the dropdown list in a ComboBox, for instance, or a popup context menu. Or if you've used a date or time picker, the picker window pops up, but if you don't want to enter anything, you can just click somewhere else and it will go away.
Is this possible to do, given the current start of NAppGUI?

Hi @MikeLorenz! Thanks for the feedback.
I'm working in the support for "flyout" windows. It will be ready in next NAppGUI release 1.4.
Keep in contact.

Hi @MikeLorenz!
Implementation is almost finish. It will be soon available in GitHub.

Wow, that looks amazing!!!

Now in GitHub: https://github.com/frang75/nappgui_src/commit/ee5c8c8d76b3604151f5d4bbea2e2f405dbfc2ed


DigiArt Token

Hi, can you please add our token. Thank you. Have a nice day.

Added in another commit


Extract FakeChannelClient and test

When building RPS, it's been really useful to be able to use the FakeChannelClient when developing the application. We'll probably want to provide the FakeChannelClient as part of the developer toolkit for state channel development. In order to do this we need to extract it and make it more robust.
This issue has two parts:

[ ] To move the FakeChannelClient out of packages/rps and into packages/channel-client (https://github.com/statechannels/monorepo/pull/704)
[ ] To write tests for the FakeChannelClient

For the tests for the FakeChannelClient it'll be useful to create a set of ChannelResults that correspond to a valid evolution of the channel and store these in a scenarios file:
const makeChannelResult = (participants, turnNum, balances, status, appDef="0x0", appData="0x0") => {....} // or whatever
const state0 = makeChannelResult([alice, bob], 0, [5, 5], 'proposed')
const state1 = makeChannelResult([alice, bob], 1, [5, 5], 'opening')
const state2 = makeChannelResult([alice, bob], 2, [5, 5], 'funded')
// etc

And then write tests of the form:
const clientA = new FakeChannelClient(privateKeyA) // probably useful to change interface to pass in private key
const clientB = new FakeChannelClient(privateKeyB)

const messageQueueAtoB = [];
clientA.on('MessageQueued', m => messageQueueAtoB.push(m));

const r0 = await clientA.createChannel(state0.participants, state0.balances, ...);
expect(r0).toEqual(state0);

const message0 = messageQueueAtoB.shift();
clientB.pushMessage(message0);

// need to check that clientB triggers the 'ChannelUpdated' event with state0, so will need to bind a queue to that event or similar ...
// etc.

Is there a specific entry point for how a FakeChannelClient could be used in the testing of web3 torrent?


Add 1 cloud-init case and update some cloud-init cases

Add 1 openstack specific cloud-init case: test_cloudinit_create_vm_config_drive
Updated some cloud-init cases: mainly update the case tag and suitable platforms

LGTM. Thanks very much to add the detail Tier information in case_tags

Thanks Ming and Xiao, merging now


Expand unit tests

Even though the coverage is 100%, not all possible cases are covered. For example, we need to check what happens if e.g. an Astropy quantity is passed to a pint NumericalProperty. Or what happens if we pass an array with units to a NumericalProperty with no units.

A few tests added in e5ebd4b307771f5bd23268359a6dc964daec28fd


experiencing same behaviour as #46

Hey guys, I've noticed #46 was closed without any info. I'm experiencing the same behaviour. Windows 10, Atom 1.7.0 stable.

As commented in #46, i don't know how to reproduce it.

Did you check the keybindings resolver?
Do you see any errors?
 Let me know if you need help debugging it.

I'll try to debug it myself, and post some updates in a few days. Thanks!

I've set some breakpoints in the package, and I get the following error: Uncaught TypeError: Cannot read property 'invalidate' of undefined at git-diff-details-view:47 . Here's the stack trace:
module.exports.AtomGitDiffDetailsView.initialize (git-diff-detail…view.coffee:21)
View (C:\Users\geo\Ap…iews\node…:184)
AtomGitDiffDetailsView (git-diff-details-view.coffee:8)
(anonymous function) (main.coffee:22)
module.exports.Workspace.observeTextEditors (C:\Users\geo\Ap…rkspace.js:307)
module.exports.activate (main.coffee:21)
module.exports.Package.activateNow (C:\Users\geo\Ap…package.js:183)
(anonymous function) (C:\Users\geo\Ap…package.js:156)
module.exports.Package.measure (C:\Users\geo\Ap…\package.js:92)
(anonymous function) (C:\Users\geo\Ap…package.js:149)
module.exports.Package.activate (C:\Users\geo\Ap…package.js:146)
module.exports.PackageManager.activatePackage (C:\Users\geo\Ap…manager.js:538)
(anonymous function) (C:\Users\geo\Ap…manager.js:519)
module.exports.Config.transactAsync (C:\Users\geo\Ap…\config.js:337)
module.exports.PackageManager.activatePackages (C:\Users\geo\Ap…manager.js:514)
module.exports.PackageManager.activate (C:\Users\geo\Ap…manager.js:497)
(anonymous function) (C:\Users\geo\Ap…ronment.js:754)

Hope this helps!

I've submitted a pull request. Not sure if @mark-hahn was experiencing the same issue, but for me, that change fixes it.

I can also confirm this bug on a ubuntu 15.04 with atom 1.7.2

Fixed with #57


Use --feature production on cf deploy-all

The production feature flag is needed to enable assimp, which is needed for to deploy the assimp example. It's only adding that feature flag for deploy-all now though.
It feels like deploy-all should be moved to ambient runtime instead though, that that the ci job should just use the latest ambient runtime? (Instead of building at again)

I was planning on making it so we don't have to rebuild ambient to deploy. Yeah, we should be able to use ambientcli.

@pierd Don't know if we need to use ambientcli, could also just download artifacts from previous builds (like the golden images do; they download the ambient runtime executable).

Created an issue: https://github.com/AmbientRun/Ambient/issues/1069


Fixed build error for axios 0.21.4

Fixed error when import axios 0.21.4 library:
Error
(!) Plugin replace: @rollup/plugin-replace: 'preventAssignment' currently defaults to false. It is recommended to set this option to true, as the next major version will default this option to true.
[!] Error: Unexpected token (Note that you need @rollup/plugin-json to import JSON files)

I don't understand what this is. I believe the PR was made in error. It seems incomplete/unintentional.


wcss: support updates

Alaska Airlines Pull Request
Fixes: #83
Summary:
This PR addresses the addition of a new blockquote element for SSoT reuse; also addresses #83 to move the creation of the automated doc to the remote versus being dependent on a local build.
Type of change:
Please delete options that are not relevant.

[x] New capability
[x] Revision of an existing capability
[ ] Infrastructure change (automation, etc.)
[ ] Other (please elaborate)

Checklist:

[x] My update follows the CONTRIBUTING guidelines of this project
[x] I have performed a self-review of my own update

By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.
Thank you for your submission!
-- Auro Design System Team

:tada: This PR is included in version 3.5.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Why didn't version 1.4.0 publish to NPM

Describe the bug
1.3.0 still on NPM, https://www.npmjs.com/package/next-recaptcha-v3

My bad, I'm very sorry

v1.4.1 should be live now.
Sorry for any inconvenience 🙏


[risk=no] Use new cluster

Current dev usage points to the cluster defined in this PR. The previous cluster is not set up for external access.

Thank you!


deregister listeners when scope is destroyed

@teaualune thanks for you pull request. Could you perhaps provide some information about why you need this functionality. What is it that you want to cleanup in the returned deregister function ?

Hi @kasperp , thanks for your reply!
Actually I was working on another desired feature (implementation is done but neither documentation nor tests are prepared), so I made this pull request first, which improves performance and memory efficiency for ngReact.

@teaualune sorry for the long wait, I kind of forgot about this to be honest.
Anyway is this still relevant? Also could you perhaps enlighten me on how it improves performance ?

@kasperp originally I thought that the watchers should be deregistered when scope is destroyed, since the watchers become redundant thereafter.
However after some survey (especially onto this post), it seems that the $watchCollection listeners will be auto deregistered after the scope is destroyed (but I'm not pretty sure about this here).
To sum up, I guess this PR does some redundant things and can be ignored :sweat_smile:

thanks for getting back :smile: