Dlang update

Motivation for this change
Updating dmd, dtools and dub to newest versions.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[x] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

@GrahamcOfBorg build dmd dtools dub

Failure on aarch64-linux (full log)
Partial log (click to expand)
Package ‘dmd-2.079.0’ in /var/lib/gc-of-borg/nix-test-rs-30/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-30/pkgs/development/compilers/dmd/default.nix:236 is not supported on ‘aarch64-linux’, refusing to evaluate.

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

Success on x86_64-darwin (full log)
Partial log (click to expand)
Edit source/app.d to start your project.
installing
post-installation fixup
strip is /nix/store/4sdh09gmvl15cy0zb6i7mbvxh5syz206-cctools-binutils-darwin/bin/strip
patching script interpreter paths in /nix/store/df25k9rb95ww3ac0b38mjpwzx983lvqi-dubUnittests-1.8.0
building '/nix/store/kxkzs4sz7wcmr1658xn3n7qd6bsccr6q-dub-1.8.0.drv'...
installing
/nix/store/8rw80f2ljr0b685f77wg4123lccnn5va-dmd-2.079.0
/nix/store/cq9pvjrbxf03m1x36ir5sbqprzjgll2n-dtools-2.079.0
/nix/store/zbb0jxyi8ka61k0zng2jiszgsx0l5zj2-dub-1.8.0

The linux build is frozen.

Success on x86_64-linux (full log)
Partial log (click to expand)
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/863d2yjij6q2vg9s2y9bi3p75xpwhm2b-dubUnittests-1.8.0
strip is /nix/store/b0zlxla7dmy1iwc3g459rjznx59797xy-binutils-2.28.1/bin/strip
patching script interpreter paths in /nix/store/863d2yjij6q2vg9s2y9bi3p75xpwhm2b-dubUnittests-1.8.0
checking for references to /tmp/nix-build-dubUnittests-1.8.0.drv-0 in /nix/store/863d2yjij6q2vg9s2y9bi3p75xpwhm2b-dubUnittests-1.8.0...
building path(s) ‘/nix/store/sapbppdg7l1d4a1s8c2yavzk2zq3hrra-dub-1.8.0’
installing
/nix/store/sbnbpkab14vx6ci37529bqjqq9as3cj4-dmd-2.079.0
/nix/store/9s2xd62i2c8hj73in7kr5byzvj7lr0px-dtools-2.079.0
/nix/store/sapbppdg7l1d4a1s8c2yavzk2zq3hrra-dub-1.8.0


Cities not providing HR

I control 4 cities (around 200-300ppl all) and no HR is given in each FIA earn turn.
P.S. Tested with ACE in the develop branch in MP

likely because it is on Tanoa, which has a different population scale than Altis. We need to normalize the rate of HR increase by the total population someone.


Synthetic attribute instances should not allocate

The instances for synthetic attributes should not allocate, whenever possible. In particular, this requires:

[x] Do not derive Synthetic instances through Generic.
[ ] Use constant values instead of constructors.

@jberthold do you think this is still relevant?

IIUC the proposed second change is to replace all constructed Attribute.Something { isSomething :: Bool } by (pre-allocated) constants itIsSomething = Attribute.Something True or isNotSomthing = Attribute.Something False.
Neat idea, but not sure about the actual impact.
If we have time we can try it (for all wrapped booleans, of which we seem to have many).


Speedup Login

I faced a problem that login & logout are very slow (taking 6-7 seconds for each). The root cause was the use of deprecated logout() function instead of do_logout(), and too many hashed authcookie data remained in the database. Each hashed data needs 200ms for examination, in my environment.
The straight-forward solution is to clean up authTypeConcreteCookieMap table and to use  do_logout(), but many free theme in concrete5.org still don't use do_logout. I believe this trouble should be handled in other ways.
I suggest to check the stored hash in the descending order, so that the newer hash is examined earlier. In my case, the login time became from 7sec to 200ms, because there were needless 34 data.

This hasn't made any noticeable difference on my dev system, though I suspect it would were many users registered as in an ecommerce site. Anyway, I admire such small changes that have such big potential.
The big delay on login for a plain sample content dev site is the querying of concrete5.org for all the background info on the welcome page. Turning that off makes a very big difference. So perhaps the next trick would be to ajax load all that background stuff after the login is confirmed and take concrete5.org out of the critical path.


syntax highlighting for diff in Markdown codeblock

At present, code blocks have syntax highlighting in both the editor and in Markdown preview. The exact colors aren't a 1-to-1 match, but it's more or less the same.

editor

preview

For diff code blocks, however, the only highlighting comes in Markdown preview.

editor

preview

Be nice if this highlighting were also displayed in the editor.

Works for me in VS Code and in the current insiders build:

This is likely theme specific. What theme are you using?
/needsMoreInfo

Yep, it is the theme :/
sorry for the bother!


Use junit-platform 5.7.1 consistently in the codebase

@bot-gradle test @qFLO

Sorry I don't understand what you said.
Currently I support the following commands:

@bot-gradle test {BuildStage} to trigger a build

e.g. @bot-gradle test SanityCheck plz
SanityCheck/CompileAll/QuickFeedbackLinux/QuickFeedback/ReadyForMerge/ReadyForNightly/ReadyForRelease are supported
test this means test ReadyForMerge
SanityCheck can be abbreviated as SC, ReadyForMerge as RFM, etc.
Specific builds:

AST: AllSmokeTestsReadyForMerge
AFT: AllFunctionalTestsReadyForMerge
ASB: AllSpecificBuildsReadyForMerge
ACT: AllCrossVersionTestsReadyForNightly
APTN: AllPerformanceTestsReadyForNightly
AFTN: AllFunctionalTestsReadyForNightly
ACTR: AllCrossVersionTestsReadyForRelease
AFTR: AllFunctionalTestsReadyForRelease

@bot-gradle help to display this message
@bot-gradle clean to clear the conversation history

@bot-gradle test QuickFeedbackLinux

OK, I've already triggered QuickFeedbackLinux build for you.

@bot-gradle test rFM

OK, I've already triggered ReadyForMerge build for you.

Thanks for the early review, @bmuskalla! I wanted to wait until CI passes, but it's fine like this as well :)


fix repo for RHEL 8+

RHEL 8+ doesn't have releasever as 8Server, since we're releasing same binary for RHEL/CentOS, fixing it to 7Server.
Signed-off-by: Lizan Zhou<EMAIL_ADDRESS>

context: https://twitter.com/SRv6d/status/1345792361226514432

context: https://twitter.com/SRv6d/status/1345792361226514432


XLS-0066d Lending Protocol

Discussion thread can be found here: #190
Development branch can be found here: TBD

@Tapanito this PR seems ready to merge -- do you agree?
(Note that per the DRAFTS section of the CONTRIBUTING guidelines, merging does not mean endorsement or even a completed spec, but instead offers a way for spec editors to more easily edit using PRs).

Before merging, I'd like to have at least one review by an engineer to ensure everything is in order. In addition, similarly to Single Asset Vault, it is simpler/more convenient to edit a PR with various small design changes (e.g. names), rather than open a new PR for each of them. As a result, keeping a PR open allows to have a spec. that is more readily in-alignment with implementation.

Makes sense, especially if it's more convenient. Just didn't want you (or anyone reading along) to think that merging here implies "finished product" (that's why we have a d designator, to indicate draft status).


refactor: make jsonschema primitive synchronous

Current dependencies on/for this PR:

main

PR #48

PR #49

PR #50

PR #51

PR #52

PR #53

PR #54

PR #55   👈

Current dependencies on/for this PR:

main

PR #48

PR #49

PR #50

PR #51

PR #52

PR #53

PR #54

PR #55   👈

Graphite Merge Job
Current status: ⏳ Queued to merge
This pull request is currently queued to be merged as part of a stack.
This comment was auto-generated by Graphite.

Job Reference: G9qW3Gh7LcbjHSuwHmyz

Graphite Merge Job
Current status: ⏳ Queued to merge
This pull request is currently queued to be merged as part of a stack.
This comment was auto-generated by Graphite.

Job Reference: cDSyTs4rRKHy1gaGhtoF


The query configuration parser is too lenient

Describe the bug
The query configuration parser, which extracts the language and (optionally) indentation offset, uses a regular expression for (#PREDICATE! VALUE) tokens in the query language. It matches them anchored to the beginning of a line.
The same syntax can also be used in query rules...
To Reproduce
...so write a query rule with a predicate that's at the beginning of a line. For example:
(some_node
(_) @append_delimiter
(#!delimiter ";")
)

It may not be pretty, but this is a valid formatting query, which the configuration parser will think contains a configuration directive and fail with:
[2023-02-17T14:53:55Z ERROR topiary] Unknown configuration predicate 'delimiter'

Expected behavior
Only root level (i.e., not associated with any query) directives should be parsed as configuration directives.
Environment

OS name + version: NixOS 22.05
Version of the code: 04d7fd8b7368976

Additional context
n/a

The top-level predicates we want to capture in the configuration are stored in the general_predicates field of the tree-sitter query, once it has been parsed with Query::new().
The problem, however, is that you need to know the proper grammar to parse a query file, so we have a bootstrapping problem. Maybe some subroutines of Query::new() can help?

I've added a dependency on https://github.com/nvim-treesitter/tree-sitter-query to parse the query files. I have used that to extract the root-level predicates...I didn't see Query::general_predicates :sweat:
Not to worry :slightly_smiling_face: My solution is almost ready for a PR. Just need to write some tests.

I agree this should be improved, but I would argue that the priority of this issue is less than P1, given that none of our supplied query files, and no reasonably formatted custom query file, are affected.

Now that formatting rules exist for our queries, which would change the indentation error and thus stop the regex from matching, I agree that this can be downgraded to P2.

If we're planning to use a configuration file, rather than embedding configuration in the query files, should we downgrade the priority of this issue again? (@ErinvanderVeen)

With #448, this issue is now no longer valid I believe.


Add tests of tasks nad functions

Similar to https://github.com/chipsalliance/UHDM-integration-tests/tree/master/tests/VoidFunction
I created that test, because https://github.com/antmicro/verilator/pull/387 passes VoidFunction test, but doesn't pass this one.

When https://github.com/antmicro/verilator/pull/387 is merged https://github.com/chipsalliance/Surelog/issues/1508 is solved all tests should pass

Continuation in https://github.com/chipsalliance/UHDM-integration-tests/pull/374


[Bug]: ERROR: Failed to download and ERROR: Invalid download link on macOS

Operating system
macOS Sonoma 14.6.1
Description
I ran docker run -it --rm -p 8006:8006 --cap-add NET_ADMIN --stop-timeout 120 dockurr/windows-arm, and got a couple error messages:
...
/storage/tmp/win11arm64.esd    99%[+++++++++++++++++++++++++++++++++++++++++++++++++ ]   3.73G  --.-KB/s    in 0s
/storage/tmp/win11arm64.esd    99%[+++++++++++++++++++++++++++++++++++++++++++++++++ ]   3.73G  --.-KB/s    in 0s
❯ ERROR: Failed to download http://dl.delivery.mp.microsoft.com/filestreamingservice/files/a0a4e466-0094-4903-9d46-6421eb4b1e83/26100.2033.241004-2336.ge_release_svc_refresh_CLIENTCONSUMER_RET_A64FRE_en-us.esd , network failure!
❯ Failed to download Windows 11, will try another mirror now...
❯ Downloading Windows 11 from massgrave.dev...
/storage/tmp/win11arm64.iso       [ <=>                                              ]  20.58K  --.-KB/s    in 0.001s
❯ ERROR: Invalid download link: https://drive.massgrave.dev/SW_DVD9_Win_Pro_11_23H2.2_Arm64_English_Pro_Ent_EDU_N_MLF_X23-68023.ISO (is only 21070 bytes?). Please report this at https://github.com/dockur/windows-arm/issues.
❯ Failed to download Windows 11, will try another mirror now...
❯ Downloading Windows 11 from bobpony.com...
/storage/tmp/win11arm64.iso   100%[=================================================>]   5.89G  50.8MB/s    in 1m 56s
❯ Extracting Windows 11 image...
❯ Adding drivers to image...
❯ Adding win11arm64.xml for automatic installation...
❯ Building Windows 11 image...

Since it asked me to report the issue, I thought I would :)
I also got the KVM error message:
❯ Creating a 64G growable disk image in raw format...
❯ ERROR: KVM acceleration not available (device file missing), this will cause a major loss of performance.
❯ ERROR: See the FAQ on how to diagnose the cause, or continue without KVM by setting KVM=N (not recommended).

But added -e KVM=N to get past that. I'm okay with a slowdown to test this on macOS ;)
The second time I tried, it did not have an error downloading from Microsoft's server.
❯ Downloading product information from Microsoft server...
❯ Downloading Windows 11...
/storage/tmp/win11arm64.esd   100%[=================================================>]   3.73G  75.2MB/s    in 50s
...

Docker compose
docker run -it --rm -p 8006:8006 -e KVM=N --cap-add NET_ADMIN --stop-timeout 120 dockurr/windows-arm
Docker log
N/A
Screenshots (optional)
No response

Definitely, just wanted to see the macOS experience as a point of comparison :)

当然，只是想看看 macOS 的体验作为比较点 :)

why the speed you downloaded  the iso was so fast? @geerlingguy

@Whitelee20151004 - I guess good mirrors and a fiber Internet connection?


BUG: Grenade range is not accurate

Sometimes, if the player is adjacent ot the grenade range, but not inside it, they get damaged in the blast too. See in action on the video: https://github.com/user-attachments/assets/92944c6b-e2b7-4a0d-baeb-db819c3b9f90

This is most likely due to an inconsistency between a "range" value used to display the visuals of an effective range, and a "range" value used to determine if an entity is within a blast radius.
This issue will get resolved when we'll have a more well-defined data format for action types.

Possibly fixed


Error while casting label as ActiveLabel with Interface Builder

Hello, i would like to create a label with Interface Builder and cast it as ActiveLabel
(ex : @IBOutlet weak var postMessageCell: ActiveLabel!
)
I set ActiveLabel class as a custom class for the label but i've got this error from Xcode : Use of undeclared type 'ActiveLabel'.
So how to create a simple label with Interface Builder and cast it as an Active Label ?
Thank you

use field "module" under class name in IB to point where xcode should search for your class


The spec checking for systemd units is backwards

This is printing missing unit files as "extra elements" rather than "missing elements"
https://github.com/ManageIQ/manageiq/pull/21149#discussion_r620278790

With missing unit files this used to print:
Failures:

  1) MiqWorker::SystemdCommon.service_base_name every worker has a matching systemd target and service file
     Failure/Error: expect(found_units).to match_array(expected_units)

       expected collection contained:  ["manageiq-cockpit_ws.target"<EMAIL_ADDRESS>"manageiq-ems_metrics_processor.target...-ui.target"<EMAIL_ADDRESS>"manageiq-web_service.target"<EMAIL_ADDRESS>       actual collection contained:    ["manageiq-cockpit_ws.target"<EMAIL_ADDRESS>"manageiq-ems_metrics_processor.target...-ui.target"<EMAIL_ADDRESS>"manageiq-web_service.target"<EMAIL_ADDRESS>       the extra elements were:        ["manageiq-providers-ibm_power_vc_cloud_manager_metrics_collector.target", "manageiq-providers-ibm_po..._vc_cloud_manager_refresh.target"<EMAIL_ADDRESS>
Note the missing unit files were shown as "extra elements".
After this PR it prints:
Failures:

  1) MiqWorker::SystemdCommon.service_base_name every worker has a matching systemd target and service file
     Failure/Error: expect(expected_units).to match_array(found_units)

       expected collection contained:  ["manageiq-cockpit_ws.target"<EMAIL_ADDRESS>"manageiq-ems_metrics_processor.target...-ui.target"<EMAIL_ADDRESS>"manageiq-web_service.target"<EMAIL_ADDRESS>       actual collection contained:    ["manageiq-cockpit_ws.target"<EMAIL_ADDRESS>"manageiq-ems_metrics_processor.target...-ui.target"<EMAIL_ADDRESS>"manageiq-web_service.target"<EMAIL_ADDRESS>       the missing elements were:      ["manageiq-providers-ibm_power_vc_cloud_manager_metrics_collector.target", "manageiq-providers-ibm_po..._vc_cloud_manager_refresh.target"<EMAIL_ADDRESS>


Update zio, zio-test, zio-test-sbt to 1.0.9

Updates

dev.zio:zio
dev.zio:zio-test
dev.zio:zio-test-sbt

from 1.0.0-RC17 to 1.0.9.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Applied Migrations

github:zio/zio/CurriedAssert?sha=v1.0.0-RC18

Files still referring to the old version number
The following files still refer to the old version number (1.0.0-RC17).
You might want to review and update them manually.
project/Dependencies.scala

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "dev.zio" } ]

labels: library-update, semver-pre-release, scalafix-migrations, old-version-remains

Superseded by #121.


Fix a bug in throttler

This PR would fix a bug in the throttler.
The bug works like this

If we have a throttler to throttle rate at 100 per second and we call maybeThrottle for 1000
It will sleep for 10 seconds so the rate would be 100 per second.
If we call maybeThrottle for 500 right away, we are expecting it to sleep for 5 seconds, but it will not sleep at all.

This is the bug, it's caused by the error when setting the periodStartNs. If we have a sleep in the previous maybeThrottle call, then the periodStartNs will be set to a wrong value.
For example, if at t = 0, we call maybeThrottle for 1000, then we have to sleep for 10 second, but since the periodStartNs is set to now, which is 0, when we wake up from the sleep, our time still remains at 10 second ago.
This PR would fix that.

Codecov Report

Merging #1926 (5d40742) into master (15a0064) will decrease coverage by 58.51%.
The diff coverage is 0.00%.

@@              Coverage Diff              @@
##             master    #1926       +/-   ##
=============================================
- Coverage     73.93%   15.41%   -58.52%
+ Complexity     9666     2279     -7387
=============================================
  Files           690      691        +1
  Lines         53219    53235       +16
  Branches       6627     6629        +2
=============================================
- Hits          39345     8208    -31137
- Misses        11802    44551    +32749
+ Partials       2072      476     -1596

Impacted Files
Coverage Δ

...rc/main/java/com/github/ambry/utils/Throttler.java
40.47% <0.00%> (-47.62%)
:arrow_down:

.../src/main/java/com/github/ambry/router/Router.java
0.00% <0.00%> (-100.00%)
:arrow_down:

.../src/main/java/com/github/ambry/store/Message.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...rc/main/java/com/github/ambry/named/PutResult.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...rc/main/java/com/github/ambry/quota/QuotaMode.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...rc/main/java/com/github/ambry/quota/QuotaName.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...rc/main/java/com/github/ambry/rest/RestMethod.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...c/main/java/com/github/ambry/config/KMSConfig.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...c/main/java/com/github/ambry/config/SSLConfig.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...c/main/java/com/github/ambry/router/ByteRange.java
0.00% <0.00%> (-100.00%)
:arrow_down:

... and 545 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 15a0064...5d40742. Read the comment docs.

This PR would fix a bug in the throttler.
The bug works like this
If we have a throttler to throttle rate at 100 per second and we call maybeThrottle for 1000
It will sleep for 10 seconds so the rate would be 100 per second.
If we call maybeThrottle for 500 right away, we are expecting it to sleep for 5 seconds, but it will not sleep at all.

This is the bug, it's caused by the error when setting the periodStartNs. If we have a sleep in the previous maybeThrottle call,
then the periodStartNs will be set to a wrong value.
For example, if at t = 0, we call maybeThrottle for 1000, then we have to sleep for 10 second, but since the periodStartNs is
set to now, which is 0, when we wake up from the sleep, our time still remains at 10 second ago.


fix(api): Use the new sliding sync version API from the Rust SDK

Anticipating the merge of https://github.com/matrix-org/matrix-rust-sdk/pull/3889. The configuration of sliding sync on the Client has changed. This patch updates this project to match this change.
Please wait for the PR on matrix-rust-sdk to be merged before merging this one.

It seems that we are hitting a bug in uniffi-go sadly…  It fails to transform the SlidingSyncVersionBuilderProxy into a correct Rust value with the following error:
panic: invalid enum value `&{http://<IP_ADDRESS>:32779/}` in FfiConverterTypeSlidingSyncVersionBuilder.Write

which is an error generated by uniffi-go:
func (FfiConverterTypeSlidingSyncVersionBuilder) Write(writer io.Writer, value SlidingSyncVersionBuilder) {
	switch variant_value := value.(type) {
	case SlidingSyncVersionBuilderNone:
		writeInt32(writer, 1)
	case SlidingSyncVersionBuilderProxy:
		writeInt32(writer, 2)
		FfiConverterStringINSTANCE.Write(writer, variant_value.Url)
	case SlidingSyncVersionBuilderNative:
		writeInt32(writer, 3)
	case SlidingSyncVersionBuilderDiscoverProxy:
		writeInt32(writer, 4)
	case SlidingSyncVersionBuilderDiscoverNative:
		writeInt32(writer, 5)
	default:
		_ = variant_value
		panic(fmt.Sprintf("invalid enum value `%v` in FfiConverterTypeSlidingSyncVersionBuilder.Write", value))
	}
}

In this patch, the value is:
	slidingSyncVersion := matrix_sdk_ffi.SlidingSyncVersionBuilderProxy{Url: opts.SlidingSyncURL}

which looks correct to me.
The following code is generated:
type FfiDestroyerTypeSlidingSyncVersion struct{}

func (_ FfiDestroyerTypeSlidingSyncVersion) Destroy(value SlidingSyncVersion) {
	value.Destroy()
}

type SlidingSyncVersionBuilder interface {
	Destroy()
}

type SlidingSyncVersionBuilderProxy struct {
	Url string
}

func (e SlidingSyncVersionBuilderProxy) Destroy() {
	FfiDestroyerString{}.Destroy(e.Url)
}


[RESOLVED] High ICMP ping response time

Problem started at 08:15:16 on 2023.06.14
Problem name: High ICMP ping response time
Host: ST-FG
Severity: Warning
Operational data: Value: 931ms
Original problem ID: 28637
Event details in Zabbix: http://<IP_ADDRESS>/tr_events.php?triggerid=23135&eventid=28637

Problem has been resolved in 6m 0s at 08:21:16 on 2023.06.14
Problem name: High ICMP ping response time
Host: ST-FG
Severity: Warning
Original problem ID: 28637


Ability to add non-breadcrumb links to a header

Feature
The iTwinUI Header allows consumers to add links via a breadcrumbs prop. This displays the menu items with carets pointing to the next item to the right, making them feel logically connected. While this suits iTwin applications which display iTwins containing iModels containing versions, it limits apps displaying more traditional headers.
Examples
The current Connect Header has header items which do not feel connected in a bread-crumby fashion.

This will likely require breaking changes if we update Header. Or we could create a new version from scratch (HeaderNew) after releasing v3, and deprecate the old Header.
/cc @iTwin/itwinui-1


Install-WindowsUpdate command custom update servers

Hi, ive already posted this question here: https://boxstarter.codeplex.com/discussions/644348 but wasn't sure if that board is still active.. it says there "now on GitHub", so here goes:
--PASTE--
Hello,
I've been using Boxstarter for some time now and been wondering if it's possible to use your own update servers to update Windows machines, when using the Install-WindowsUpdate command.
This parameter says:
GetUpdatesFromMS
If this switch is set, the default windows update server, if any, is bypassed and windows update requests go to the public Microsoft Windows update service.
How can I specify a custom update server? For example:
Install-WindowsUpdate http://myserver.lan
Thanks for your help!
--PASTE--

I have not worked much at all with internal wus setups so I don't know how that all is setup. Its likely via group policy, but you would have to investigate. If GetUpdatesFromMS is specified, this tells the winduws update API to use the ssWindowsUpdate server selection instead of the default. See https://msdn.microsoft.com/en-us/library/windows/desktop/aa387280(v=vs.85).aspx


[SNAP-1185] Guard logging and time measurements

What changes were proposed in this pull request?

add explicit log-level check for some log lines in java code
(scala code already uses logging arguments as pass-by-name)
for System.currentTimeInMillis() calls that are used only by logging,
guard it with the appropriate log-level check
use System.nanoTime in a few places where duration is to be measured;
also using a DoubleAccumulator to add results for better accuracy
cache commonly used logging.is*Enabled flags

How was this patch tested?
SnappyData precheckin

looks good. Only one question, with DoubleAccumulator can we control the precision upto 3 digits. I think signifying upto millis precision it is right ?

with DoubleAccumulator can we control the precision upto 3 digits

DoubleAccumulator is used only for partial partition-wise results (as double millis) while final accumulated sum is converted back long millis as per the exposed Spark APIs. This is to avoid losing per-partition result accuracy for timings (with nanoTime we have that level of accuracy as opposed to currentTimeMillis which didn't have it at all).

right. probably candidate for contribution back to spark.

right. probably candidate for contribution back to spark.

Yes, this and kryo one SNAP-1136


Issue with tensor size by running with yolov3

Hi thanks for the repo.
Can you please help me with the current issue. I try to run the detect_fsnet.py tutorial and i get an error with yolov3 and yolov5 model in yolo,py (line 57, in forward)
RuntimeError: The size of tensor a (40) must match the size of tensor b (44) at non-singleton dimension 3
I try to exchange the yolov3 files with the new version from the yolov3 repo but they are to different.

I could fix it by exchanging the code

how? i have same error

how to exchange the code


chore(FDS-489): [Monorepo] - bump prettier to v2.5.1

This bumps prettier to its most recent version v2.5.1.
Dependencies
package.json file updated because of the version bump.
PR Author Checklist

[ ] PR title adheres to Conventional Commits
[ ] I have finished reviewing the contents of this PR for accuracy
[ ] If needed, I have included a Changeset and it follows Semantic Versioning principles
[ ] I have completed all of the above and have enabled auto-merge for this PR

Messages

:book:
Dangerfile.js does not run when the current branch is chore/FDS-489-update-prettier

  Generated by :no_entry_sign: dangerJS against e6a766f221d0f1bca2cdf1c3eefb719311061aa1


Web-Client Testing always times out😿

Version
4.3.4
Context
I am using the vertx-web-graphql dependency to run a graphql-server and now I want to test that said server.
And I am using Kotlin instead of Java.
Problem Code
Test-code
@ExtendWith(VertxExtension::class)
class GraphQlVerticleTest {

    private val loginFailedResponse =
		"{\"data\":{\"attemptCustomerLogin\":{\"token\":\"${LoginValidationResult.LOGIN_FAILED.message}\"}}}"

    @BeforeEach
    fun `deploy GraphQL Verticle`(vertx: Vertx, testContext: VertxTestContext) {
         vertx.deployVerticle(GraphQlVerticle(setupPostgreSqlClient(vertx),
		                              setupJWTAuthenticationProvider(vertx)),
		                              testContext.succeedingThenComplete())
    }

    private fun createLoginQueryAsJsonObject(email: String, password: String): JsonObject {
	return JsonObject().put("query",
		                "query { attemptCustomerLogin(customerEmail: \"$email\", customerPassword: \"$password\") { token } }")
    }

    @Test
    fun `Login attempt with Wrong Login data returns Login Failed message`(vertx: Vertx, testContext: VertxTestContext) {
	val webClient: WebClient = WebClient.create(vertx)

	testContext.assertComplete(webClient.post(graphQLPort, graphQLHostName, "/graphql")
			                     .putHeader("Content-Type", "application/json")
	                              .sendJson(createAttemptCustomerLoginQueryAsJsonObject(wrongEmail, wrongPassword)))
			.onComplete { asyncHttpResult ->
                                val httpResponse = asyncHttpResult.result() // .bodyAsString() = "{"data":{"attemptCustomerLogin":{"token":"Login failed. Invalid email or password."}}}"
                                assertThat(httpResponse.bodyAsString())
                                                    .isEqualTo(loginFailedGraphQLResponse)
				testContext.completeNow()
			}
	}

    @AfterEach
    fun `check that Verticle is still there`(vertx: Vertx, testContext: VertxTestContext) {
	assertThat(vertx.deploymentIDs()).isNotEmpty.hasSize(1)
    }
}

The Verticle and some of the functions don't really matter, as the Assert Statement does not fail, but for some reason the testContext never gets completed and then the Test times out.
I used the testContext.assertComplete(...).onComplete(...) in all my other Vertx-Tests, but with the Web-Client it just does not work.
Any help would be appreciated 🙂.

Have you tried to use onComplete after sendJson to understand if the
problem is with your web client call or vertx-junit5?

Yes I have, still times out sadly.
The assertion recieves the AsyncResult<HttpResponse> so that would mean that the web-client is done. I could add the response to the issue, but it's just a graphql response 🙂.
I have also tried closing the web-client manually after the assertion in case it is somehow blocking the testContext, but that does not changes anything.

I have updated the Code snippet. Is that what you mean with reproducer? 🤔

I read up a bit on reproducers, sorry have never been asked that so far as you could probably tell by my answer 😅.
I have changed the entire code snippets to a different verticle, but the problem remains the same.


BUG: Bugs with VTK 9

@GuillaumeFavelier you can now pretty easily build and install VTK 9 (which is good because they are on RC3, and it should fix some bugs and bring 3.8 support):
git clone --recursive https://gitlab.kitware.com/vtk/vtk.git
mkdir vtk-build
cd vtk-build
cmake -GNinja -DVTK_WHEEL_BUILD=ON -DVTK_PYTHON_VERSION=3 -DVTK_WRAP_PYTHON=ON ../vtk
python setup.py bdist_wheel
pip install dist/vtk-*.whl

However, there is at least one rendering bug (depth peeling again maybe?) where the surface overlay gets cut off at some distance based on rotation (note the rightward "v" cut of the overlay):

We might need to figure out how to properly resolve the coincident topology here -- relying on VTK to do it automagically might not work anymore. Or maybe it's something else...?

FWIW, PyVista worked "out of the box" this way, while Mayavi fails to compile (which I'll look into) :)

Can someone else on macOS see if you can replicate https://gitlab.kitware.com/vtk/vtk/-/issues/17846 ?

Thanks for starting this @larsoner. I'll follow the procedure your explained to be better prepared for VTK 9.
Also relevant for https://github.com/pyvista/pyvista/issues/562

Can you share that data or how to launch that scene? I'll try to look into this and see what's happening to the overlain mesh.

WARNING: Will download 1.5 GB of data to ~/mne_data (unless you give it a different path to use)
import faulthandler
import os.path as op
import mne

faulthandler.enable()
data_path = mne.datasets.sample.data_path()
sample_dir = op.join(data_path, 'MEG', 'sample')
subjects_dir = op.join(data_path, 'subjects')
inv = mne.minimum_norm.read_inverse_operator(op.join(
    sample_dir, 'sample_audvis-meg-eeg-oct-6-meg-eeg-inv.fif'))
evoked = mne.read_evokeds(op.join(sample_dir, 'sample_audvis-ave.fif'))[0]
evoked.apply_baseline((None, 0))
stc = mne.minimum_norm.apply_inverse(
    evoked, inv, method='dSPM', verbose='debug', pick_ori=None)  # 'vector')
initial_time = 0.1

with mne.viz.use_3d_backend('pyvista'):
    brain = stc.plot(subjects_dir=subjects_dir, initial_time=initial_time,
                     clim='auto', views='lat', hemi='lh',
                     smoothing_steps='nearest', verbose=True)

You will probably need to pip install nibabel https://github.com/mne-tools/mne-python/zipball/master first.
This is the code I was using (last I recall!), but for some reason now it hangs when I try it.

(FYI I forgot a ninja -j 4 in the command list above, I've updated it now)

Sorry I am late, I had to build everything from scratch and follow your instructions. I had to change:
- cmake -GNinja -DVTK_BUILD_TESTING=OFF -DVTK_WHEEL_BUILD=ON -DVTK_PYTHON_VERSION=3 -DVTK_WRAP_PYTHON=ON ../vtk
+ cmake -GNinja -DVTK_BUILD_TESTING=OFF -DVTK_WHEEL_BUILD=ON -DVTK_PYTHON_VERSION=3 -DVTK_WRAP_PYTHON=ON ..

This is the result of: python -c "import pyvista; print(pyvista.Report())"
--------------------------------------------------------------------------------
  Date: Wed Apr 15 15:02:56 2020 CEST

                OS : Linux
            CPU(s) : 4
           Machine : x86_64
      Architecture : 64bit
       Environment : Python
        GPU Vendor : NVIDIA Corporation
      GPU Renderer : GeForce GTX 960M/PCIe/SSE2
       GPU Version : 4.5.0 NVIDIA 430.64

  Python 3.6.10 |Anaconda, Inc.| (default, Mar 25 2020, 23:51:54)  [GCC 7.3.0]

           pyvista : 0.24.1
               vtk : 9.0.0
             numpy : 1.18.2
           imageio : 2.8.0
           appdirs : 1.4.3
            scooby : 0.5.2
            meshio : 4.0.10
             PyQt5 : 5.14.1
           IPython : 7.13.0
--------------------------------------------------------------------------------

rendering bug (depth peeling again maybe?) where the surface overlay gets cut off at some distance based on rotation

I can also reproduce the bug with the camera angle :+1:

git clone --recursive https://gitlab.kitware.com/vtk/vtk.git
mkdir vtk-build
cd vtk-build

after these three steps you should be in vtk-build, not vtk/vtk-build. Perhaps you had an extra cd vtk after the git clone line?

Yes but the sources are in vtk and not vtk-build right? It's just an empty folder.

I disabled depth peeling explictly without success:
ren_win = self.plotter.ren_win
ren_win.SetAlphaBitPlanes(0)
renderer = self.plotter.renderer
print(renderer.GetLastRenderingUsedDepthPeeling())  # prints 0
renderer.SetUseDepthPeeling(0)

Using offset like we did Vispy does work for me, I'll open a PR:
                mapper.SetResolveCoincidentTopologyToPolygonOffset()
                mapper.SetRelativeCoincidentTopologyPolygonOffsetParameters(-4., -4.)

vtk-build starts out empty, but the cmake line populates it. I wonder if your problems were due somehow to building in a subdirectory of the source directory, rather than a totally separate one

What's interesting about the topology problem is that I don't see it on mayavi. But whatever makes it work I guess!

I don't see it on mayavi.

Any idea how they deal with it?

No idea

I'm on it

@larsoner I installed it and I have an issue with picking:
Traceback (most recent call last):
  File "/home/guillaume/source/mne-python/mne/viz/_brain/_timeviewer.py", line 939, in on_pick
    cell = mesh.faces[cell_id][1:]
IndexError: invalid index to scalar variable.

But except from that, the app is completely interactive. All the sliders and tool bar buttons work and are linked correctly.

Hmm, must be some issue with my system. What's your mne sys_info? I'll try your version of Qt.

Platform:      Linux-4.19.114-1-MANJARO-x86_64-with-arch-Manjaro-Linux
Python:        3.6.10 |Anaconda, Inc.| (default, Mar 25 2020, 23:51:54)  [GCC 7.3.0]
Executable:    /home/guillaume/source/anaconda3/envs/pyvista-dev/bin/python
CPU:           : 4 cores
Memory:        Unavailable (requires "psutil" package)
mne:           0.21.dev0
numpy:         1.18.3 {blas=openblas, lapack=openblas}
scipy:         1.4.1
matplotlib:    3.2.1 {backend=Qt5Agg}

sklearn:       Not found
numba:         Not found
nibabel:       Not found
cupy:          Not found
pandas:        Not found
dipy:          Not found
mayavi:        Not found
pyvista:       0.24.1
vtk:           9.0.0

And I use PyQt5              5.14.1

Ahh right without mayavi it will not tell you, let me update sys_info...

Hooray! With pip install --upgrade --user pyqt5 which gives 5.14.2 everything works fine

Feel to try https://github.com/mne-tools/mne-python/pull/7665 then. It worked for me.

@GuillaumeFavelier looks like the topology problems are still there:
https://mne.tools/dev/auto_examples/inverse/plot_source_space_snr.html#sphx-glr-auto-examples-inverse-plot-source-space-snr-py

@GuillaumeFavelier might be good to fix this before looking into coreg

For future reference, the visual issues mentioned in https://github.com/mne-tools/mne-python/issues/7599#issuecomment-692696125:


Use the server's zone to determine a node selector when running in pods

This will allow workers to be target to specific nodes.
This works for now, but I haven't looked into what happens if a server changes zones. Leaving this as WIP until I get around to that.
As a part of this I added a validation to fail updates to a server's zone in pods. Additionally I created a UI PR to disable the zone drop-down for pods and handle validation errors when changing the server zone.
Fixes https://github.com/ManageIQ/manageiq-pods/issues/353

Cross repo tests https://github.com/ManageIQ/manageiq-cross_repo-tests/pull/62


Improve clusterIdsToHosts.

https://confluence.nebula-graph.io/pages/viewpage.action?pageId=9666582#id-性能调优-CASE4

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


default name of change log collection missleading in README.md

In the README.md's Standalone section (https://github.com/cloudyrock/mongock/blob/master/README.md#standalone-usage) the default for the change log collection is given as "dbchangelog".
builder.setChangelogCollectionName(logColName);   // default is dbchangelog, collection with applied change sets
This seams to be incorrect for version 2.0.2 here the collection is called "mongockChangeLog" by default. (I did not check the source code for other versions.)
This documentation misled me when I was setting up Mongock last week.

Hello @Endron ,
You are right, that's wrong in the documentation. As you say, the collection name is mongockChangeLock. That will be fixed in the documentation today, along any other issue.
Please, don't hesitate to ask me any question you have or if you need help.

@dieppa thanks for the amazingly fast response.
I do not need any further help from your side. After I found this it was easily fixed by just explicitly setting the collection name.

Thanks @Endron. Just out of curious, why do you need to set a specific collectionName?

We are migrating from MongoBee (https://github.com/mongobee/mongobee) by setting the collection name it should be very much an in place update as mongobee stored all its changes in documents that look like Mongock's changelog documents. So my hope is that this will keep everything running as is.

Ok, let me know if you fin any issue, because in the last versions we removed that setter. If that were the case, I would provide a fix, as it makes totally sense to keep for these cases.

I would encourage keeping the option to set the collection for the change log.
Being opinionated is fine and dandy. But you should always keep an option to get out of your carefully chosen defaults :wink: And if you remove it now you might be breaking backwards compatibility for anyone who is using it...

Thanks again. That's enabled in the last version 3.2.3.BETA ;).
I close this issue. Anything else you need, please let us know


[Bug] Inline code pieces are having excess bottom margin applied.

As seen on pages for the Design Manual, code tags that are placed inline with paragraph text are having extra bottom margin applied where it shouldn't be.
Current behavior

The code tags appear to be superscript compared to the other text in the sentences.

Expected behavior

The code tags run inline with the other text in the sentences.

Steps to replicate behavior

Go to http://cfpb.github.io/design-manual/best-practices/accessibility-best-practices.html#perceivable
Look at the paragraph copy in this and other sections on the page.

Screenshots
Current

Expected
For help in troubleshooting and determining what caused this:
The margin disappears if the overflow-x and margin-bottom attributes are turned off in the .content code CSS, along with the margin-bottom attribute in the general code CSS section.

It's being caused by an unfortunate combination of this line in CF and this line in the DM's CSS.
As for the CF code: @jimmynotjim Do you know why you needed the display: inline-block; for code elements? A cursory test seems to indicate that it's not necessary.
Separately, that margin-bottom in the DM styles should likely be on a whole pre block, not on any ol' code element.

I do not remember why inline-block was needed or if it even was. I feel like I took most of that code from another example, possibly GitHub itself, but it doesn't seem to be a style rule they're using, so lets drop it.

Was this fixed? I still see it happening on http://cfpb.github.io/design-manual/page-components/tables.html


chore(release): 0.0.3

@Poltergeist let's just make sure that we don't release on NPM before merging the release on Github because there is a release already on NPM. Thanks.

Yes I did the release but that was before I did know that master was blocked. So I am sorry.


Add user pages

On most sites that have users, you can click on the username or icon wherever it is displayed and go a user profile page, which displays the user activity and other info.
On Dockstore, users are displayed on organization pages and stargazers pages. You can't click on them, and it feels counter-intuitive.
IMO, we should make simple user pages that display the name, profile pic, activity/starred workflows, organizational affiliation, possibly contact information. We should link to these anywhere that a user is displayed.
Alternatively, we could modify the UI to look less like the users should be clickable. Especially on the stargazers page, where the usernames are in dark blue, it could give the impression that the links are broken.

┆Issue is synchronized with this Jira Story
┆Issue Type: Story
┆Fix Versions: Dockstore 1.10
┆Sprint: Backlog
┆Issue Number: DOCK-1297

Bumping.
Also adding that we could also use these pages for registrants of a workflow. For example, if I register and publish a workflow, there would be a link to my profile page on the public workflow site.


Use of GPyOpt for Bayesian Uncertainty Quantification of differential equations

To compare GPyOpt with other contributions in uncertainty quantification, do you have examples or tutorials for the following models: Lorenz63 (dim=3), Lorenz96(dim=9) and JAK-STAT as used by Campbell, Chkrebtii, Calderhead and Girolami in  https://arxiv.org/abs/1306.2365 and Hennig and Kersting? Many of these authors will participate to the forthcoming GP Summer School.
These examples could be rolled into the prototype templates of GPyOpt. The strength of GPyOPT is the unifying use of python whereas the papers mentioned above are all on different software.

This is a fantastic idea! I will thy to have those notebooks ready for the summer school.
Javier

Hi,
Due to time constrains we didn't manage to have these examples in place but it is something we are interested on. Keep us updated if you do something on this lines! Hopefully we can do that in the future.
Javier


Pluralize contribution (rephrase as contributions)

Notice

[x] I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":

I submit this contribution under the Apache 2.0 license and represent that I am entitled to do so on behalf of myself, my employer, or relevant third parties, as applicable.

I certify that (a) this contribution is my original creation and / or (b) to the extent it is not my original creation, I am authorised to submit this contribution on behalf of the original creator(s) or their licensees.

I certify that the use of this contribution as authorised by the Apache 2.0 license does not violate the intellectual property rights of anyone else.

Motivation and Context
Why was this PR created?
Resolve https://github.com/quantumblacklabs/kedro/pull/83#issuecomment-529732987. @921kiyo @yetudada
How has this been tested?
What testing strategies have you used?
Checklist

[x] Read the contributing guidelines
[ ] Opened this PR as a 'Draft Pull Request' if it is work-in-progress
[ ] Updated the documentation to reflect the code changes
[ ] Added new entries to the RELEASE.md file
[ ] Added tests to cover my changes
[ ] Assigned myself to the PR

👍 Could you move your name to "Thanks for supporting contributions" under Release 0.15.2, not 0.15.1?

My bad; done now!


feat: stronger typing for scope state utils.

Pull Request Checklist

[ ] New code has 100% test coverage
[ ] (If applicable) The prose documentation has been updated to reflect the changes introduced by this PR
[ ] (If applicable) The reference documentation has been updated to reflect the changes introduced by this PR
[ ] Pre-Commit Checks were ran and passed
[ ] Tests were ran and passed

Description

We use connection scope state to store a lot of different things for caching, auth, logging etc.
This PR improves the type safety of writing to, and retrieving from the scope state via the scope state utils and in doing so allows us to make another dozen or so improvements to our typing by removing casts and fixing existing type errors.
While this pattern of overloading the scope util methods for literal key arguments is quite verbose, the pattern is clear so I don't believe incremental changes to the data that we store in scope state will cause too much headache.
To add a new key to store in scope state:

add a new key literal to litestar.types.scopes
add a new constant to litestar.constants typed as the literal key name
add appropriate overloads to the get/pop/set utilities.

Additionally, the PR removes the "pop" behavior from get_litestar_scope_state() in favor of adding a new utility pop_litestar_scope_state() so that both the get and pop utils share the same semantics as dict.get() and dict.pop().
Close Issue(s)

@cofin I think this will cause some typing issues in AA where the session/engine etc are stored in state and we don't have the literal state keys/overloads defined for those in here. It should be a simple workaround to have AA create and use its own namespace within scope state (i.e., we store stuff in scope["state"]["__litestar__"], AA can use scope["state"]["__aa__"] or whatever), and we'll just re-implement versions of the scope access utils for over there.
We'd need to do that and release it before this PR makes it into a Litestar release - I'll send through a PR for that when I get a chance over the next day or so.

but what if instead of a module

Do you mean instead of a dict? I.e., the current scope["state"]["__litestar__"] = {} would instead be scope["state"]["__litestar__"] = LitestarScopeState()?
If so, it would probably be better, yeh. Although to enforce the state namespace we'd still need an access function to retrieve the state from the scope, so the pattern would be if get_scope_state(scope).url is Empty: ... smth like that anyway.

but what if instead of a module

Do you mean instead of a dict? I.e., the current scope["state"]["__litestar__"] = {} would instead be scope["state"]["__litestar__"] = LitestarScopeState()?
If so, it would probably be better, yeh. Although to enforce the state namespace we'd still need an access function to retrieve the state from the scope, so the pattern would be if get_scope_state(scope).url is Empty: ... smth like that anyway.

Oh, that's also a neat idea. But not what I was thinking!
The snippet I showed was meant literally; You'd instantiate a LitestarScopeState, which then internally defines the attributes, e.g. as properties:
class LitestarScopeState:
    def __init__(self, scope: Scope) -> None:
        self._scope = scope

    @property
    def accept(self) -> Accept | None:
        namespace = self._scope["state"].setdefault(constants.SCOPE_STATE_NAMESPACE, {})
        return namespace.get(constants.SCOPE_STATE_ACCEPT_KEY)

    @accept.setter
    def accept(self, value: Accept) -> None:
        self._scope["state"].setdefault(constants.SCOPE_STATE_NAMESPACE, {})[constants.SCOPE_STATE_NAMESPACE] = value


cranelift-wasm: Add a bounds-checking optimization for dynamic memories and guard pages

This is a new special case for when we know that there are enough guard pages to cover the memory access's offset and access size.
The precise should-we-trap condition is
index + offset + access_size > bound

However, if we instead check only the partial condition
index > bound

then the most out of bounds that the access can be, while that partial check still succeeds, is offset + access_size.
However, when we have a guard region that is at least as large as offset + access_size, we can rely on the virtual memory subsystem handling these out-of-bounds errors at runtime. Therefore, the partial index > bound check is sufficient for this heap configuration.
Additionally, this has the advantage that a series of Wasm loads that use the same dynamic index operand but different static offset immediates -- which is a common code pattern when accessing multiple fields in the same struct that is in linear memory -- will all emit the same index > bound check, which we can GVN.
Partially.
The bounds check comparison is GVN'd but we still branch on values we should know will always be true if we get this far in the code. This is actual br_ifs in the non-Spectre code and select_spectre_guards that we should know will always go a certain way if we have Spectre mitigations enabled. See the second commit for examples.
Improving the non-Spectre case is pretty straightforward: walk the dominator tree and remember which values we've already branched on at this point, and therefore we can simplify any further conditional branches on those same values into direct jumps.
Improving the Spectre case requires something that is morally the same, but has a couple snags:

We don't have actual br_ifs to determine whether the bounds checking condition succeeded or not. We need to instead reason about dominating select_spectre_guard; {load, store} instruction pairs.

We have to be SUPER careful about reasoning "through" select_spectre_guards.  Our general rule is never to do that, since it could break the speculative execution sandboxing that the instruction is designed for.

This pull request leaves implementing these new optimization passes for follow ups.

FWIW: I looked over the wasm filetest changes pretty closely, but did not go over the ISA-specific versions of those same tests in much detail.

Going to gather sightglass numbers now...

Looks like this gives not just execution speed ups, but also compilation speed ups (presumably due to processing less IR):
$ sightglass benchmark -e main.so -e opt.so --engine-flags="--static-memory-maximum-size=0 --dynamic-memory-guard-size=65536" -m insts-retired -- benchmarks/default.suite
execution :: instructions-retired :: benchmarks/spidermonkey/benchmark.wasm

  Δ = 354918771.70 ± 209612.26 (confidence = 99%)

  opt.so is 1.08x to 1.08x faster than main.so!

  [4757395008<PHONE_NUMBER>.90<PHONE_NUMBER>] main.so
  [4402584769<PHONE_NUMBER>.20<PHONE_NUMBER>] opt.so

execution :: instructions-retired :: benchmarks/pulldown-cmark/benchmark.wasm

  Δ = 2246146.90 ± 322.54 (confidence = 99%)

  opt.so is 1.07x to 1.07x faster than main.so!

  [35406698 35406850.20 35407505] main.so
  [33160532 33160703.30 33161229] opt.so

execution :: instructions-retired :: benchmarks/bz2/benchmark.wasm

  Δ = 20037307.30 ± 5.37 (confidence = 99%)

  opt.so is 1.05x to 1.05x faster than main.so!

  [402201103 402201106.00 402201111] main.so
  [382163791 382163798.70 382163803] opt.so

compilation :: instructions-retired :: benchmarks/pulldown-cmark/benchmark.wasm

  Δ = 80907.10 ± 30178.64 (confidence = 99%)

  opt.so is 1.01x to 1.01x faster than main.so!

  [9350309 9389659.00 9444444] main.so
  [9276889 9308751.90 9338252] opt.so

compilation :: instructions-retired :: benchmarks/spidermonkey/benchmark.wasm

  Δ = 1534345.20 ± 211755.93 (confidence = 99%)

  opt.so is 1.01x to 1.01x faster than main.so!

  [218580786 218834739.10 219048529] main.so
  [216969499 217300393.90 217501790] opt.so

Hm ok well I also see now that a test failed with something that should trap which didn't, which means now that I missed something in review, so I'm much less confident in my review now.

Ah yeah after digging in I believe that's correct. The configuration requires dynamic memories to have a 64k guard page region but the pooling allocator in this configuration specifically isn't decommitting memory past the end to avoid syscalls, which means that there's actually no guard pages at all upon reinstantiation. That's ok with today's impelmentation of bounds checks which don't try to exploit the fact that the arithmetic can be simplified (e.g. this PR).
This is a tough problem though because that was one of the assumptions about dynamic memory and the pooling allocator, that we could avoid decommitting memory and save on syscalls/contention. This is making me realize though that if we want to take advantage of guard pages on dynamic memories (which I suspect we do since it should help drastically simplify the complexity of analysis required to handle multiple bounds checks) then this optimization isn't possible.
The offending lines I think are here which those need to be executed unconditionally if the guard size for memory is more than 0 bytes, which I think is basically always.

The offending lines I think are here which those need to be executed unconditionally if the guard size for memory is more than 0 bytes, which I think is basically always.

Thanks! I was digging into the test but hadn't got that far before I was interrupted. Always nice when someone debugs the issue for you :)


Move save button in course editing view to a more visible location

Should we make the course edit page autosave? currently if you press "enter" in an input field the form is submitted. Either we remove this, or we make the form auto save.
I guess there is no destructive action that cannot be undone, so the autosave should be safe to implement.

This was implemented recently


asking two times in a row causes an infinite freeze on all NonObjectOptimizers

Steps to reproduce
This is not really a big issue, but I wanted to report this, and I had a bug in my code where the conditional for telling was always false and this was happening and I couldn't figure out why. So with NonObjectOptimizer, when you ask multiple times in a row, it just freezes forever. I know this type of optimizer doesn't support this, but it would be nice to get an error in that case.
Observed Results
It freezes forever.
Actually I've traced the exact line it freezes on to this:
candidate = self.messages_tell.get()  # get evaluated message

Line 84 in nevergrad/optimization/recaster.py, _MessagingThread > _fake_callable
Expected Results
It would be nice to get an error instead of a freeze that would tell what is wrong.
Relevant Code
import nevergrad as ng
def objective(arr:ng.p.Array): return (arr.value**2).mean()
optimizer = ng.optimizers.Powell(ng.p.Array(shape=(2,), lower=-10, upper=10, ), budget=100)

p = optimizer.ask()
p = optimizer.ask()

Also worth mentioning I am on windows. Maybe that is the issue..

This is an effect of the design. I don't think there's an easy robust way to fix this.

ah, no worries then!


Vars prefix

Hi,
I have a suggestion: it would be great to have prefix on your vars like this:

jenkins_hostname

Thanks

Quite true! I'll add this soon, and make sure it's in a new minor release, since the variable name could break some people's configurations.

Thanks :-)

I've added this and incremented minor version to 1.2.0 since it will require people to update their vars. Should be a simple update.


Remove all listeners for all subscriptions when the client is closed.

This update ensures that all listeners on all subscriptions are cleared when client.close() is called, and the subscriptions list is cleared as well.
Details:
Clear Subscriptions and Listeners:
•	When client.close() is called, all listeners on all subscriptions are removed to prevent them from continuing to receive events.
•	The subscriptions list is also cleared to release any references to the subscriptions.
Reason:
•	Previously, even after calling client.close(), the listeners remained active and continued to receive events from the Salesforce gRPC channel.
•	Since the channel is closed, these events cannot be handled properly and eventually result in errors such as Failed to load schema with ID ..... because the client is already closed.
This change prevents the aforementioned issues by ensuring that all subscriptions and their listeners are properly cleaned up when the client is closed.

Great catch @viktorlv30! Thanks for reporting it and providing the fix.
This may fix #36

Yes, I released it right away: it's version 4.1.1.


Fix error when RN version is x.x.x-rc1

Currently:
let rnVersion = '0.24.0-rc1';
const version = rnVersion.replace('-rc', ''); // becomes '0.24.01'
...
     if (semver.lt(version, item + '.0') && nextVersion) // throws exception since version is not valid semver

Fixed this, and also updated the unit tests.

Just hit this issue trying to use RN 0.24.0-rc1 :)

Ah, so awesome! Thank you, merging & including in the todays release with other fixes!


Help wanted, ${plugin.name}

I don't changed any plugin.yml or stuff like that

Can you pastebin your pom.xml?

Closing as this is a personal issue.

is the same POM.xml of this plugin

@RubeVi That doesn't help me. Obviously there's something wrong either in your plugin.yml, pom.xml, or just importing Maven dependencies. I've seen too many times people claiming they haven't changed anything but ended up just breaking it unknowingly.

With netbeans

And i have all the dependencies of the POM.xml

You need to build with maven. Don't export with NetBeans.

I'll do


Successful dump on a crusty SCPH-50001

This PS2 was on its last legs, broken fan header, the fan being hooked up via USB around the chassis to one of the USB ports, leaving the case half way open, a damaged on button cable, so the color is yellow when it's off, and the disc drive died.
I heard there was a new BIOS dumper, so I went and plugged it in. It went pretty well, and I got 6 files, put them in PCSX2 and got everything just how it was on my PS2. Even the model number and PS1 Driver version were right there in PCSX2.
It also kept my "Full" screen setting, which for some reason I had on my PS2 for years, not that it really changes anything outside of the BIOS.
Great, efficient dumper!
I plan on getting a new PS2 one of these days, and I'll be dumping those BIOS too. Have a nice day!

You know this is the issue section, right? This isn't where you should be posting feedback

It's okay, I stated in the readme that the issue tracker can be used for successful reports. I guess a discussion page would've been a better solution.


Cannot install php 5.4 on Ubuntu 16.04

WARNING: curl extension might be required for fetching data.
===> phpbrew will now build 5.4.45
You haven't set any variant. A default set of extensions will be installed for the minimum requirement:
[bcmath, bz2, calendar, cli, ctype, dom, fileinfo, filter, ipc, json, mbregex, mbstring, mhash, pcntl, pcre, pdo, phar, posix, readline, sockets, tokenizer, xml, curl, zip, openssl]
Please run 'phpbrew variants' for more information.
===> Loading and resolving variants...
Checking distribution checksum...
Checksum matched: 185f67f1ca652b18bc0cca9d7edbde7c
===> Distribution file was successfully extracted, skipping...
Source Directory: /home/sasha/.phpbrew/build/php-5.4.45
Found existing Makefile, running make clean to ensure everything will be rebuilt.
You can append --no-clean option after the install command if you don't want to rebuild.
===> Running make clean: /usr/bin/make -C '/home/sasha/.phpbrew/build/php-5.4.45' --quiet 'clean'
Running Command:/usr/bin/make -C '/home/sasha/.phpbrew/build/php-5.4.45' --quiet 'clean'
Writing variant info to /home/sasha/.phpbrew/php/php-5.4.45/phpbrew.variants
===> Checking patches...
Checking patch for replace apache php module name with custom version name
Enabled variants: [bcmath, bz2, calendar, cli, ctype, dom, fileinfo, filter, ipc, json, mbregex, mbstring, mhash, pcntl, pcre, pdo, phar, posix, readline, sockets, tokenizer, xml, curl, zip, openssl]
Disabled variants: []
Found existing build.log, renaming it to /home/sasha/.phpbrew/build/php-5.4.45/build.log.1488382833
===> Configuring 5.4.45...
Use tail command to see what's going on:
$ tail -F /home/sasha/.phpbrew/build/php-5.4.45/build.log
./configure '--cache-file='''/home/sasha/.phpbrew/cache/config.cache'''' '--prefix=/home/sasha/.phpbrew/php/php-5.4.45' '--with-config-file-path=/home/sasha/.phpbrew/php/php-5.4.45/etc' '--with-config-file-scan-dir=/home/sasha/.phpbrew/php/php-5.4.45/var/db' '--disable-all' '--enable-phar' '--enable-session' '--enable-short-tags' '--enable-tokenizer' '--with-pcre-regex' '--with-zlib=/usr' '--with-libdir=lib/x86_64-linux-gnu' '--enable-bcmath' '--with-bz2=/usr' '--enable-calendar' '--enable-cli' '--enable-ctype' '--enable-dom' '--enable-fileinfo' '--enable-filter' '--enable-shmop' '--enable-sysvsem' '--enable-sysvshm' '--enable-sysvmsg' '--enable-json' '--enable-mbregex' '--enable-mbstring' '--with-mhash' '--enable-pcntl' '--with-pcre-regex' '--with-pcre-dir=/usr' '--enable-pdo' '--enable-phar' '--enable-posix' '--with-readline=/usr' '--enable-sockets' '--enable-tokenizer' '--enable-dom' '--enable-libxml' '--enable-simplexml' '--enable-xml' '--enable-xmlreader' '--enable-xmlwriter' '--with-xsl' '--with-libxml-dir=/usr' '--enable-zip' '--with-openssl=yes' '--with-pear=/home/sasha/.phpbrew/php/php-5.4.45/lib/php' '--enable-zend-signals' >> /home/sasha/.phpbrew/build/php-5.4.45/build.log 2>&1
===> Checking patches...
Checking patch for php5.3.29 multi-sapi patch.
Checking patch for php5.3.x on 64bit machine when intl is enabled.
Checking patch for openssl dso linking patch
===> Building...
make >> /home/sasha/.phpbrew/build/php-5.4.45/build.log 2>&1
Error: Make failed:
The last 5 lines in the log file:
/home/sasha/.phpbrew/build/php-5.4.45/ext/openssl/xp_ssl.c:355: undefined reference to `SSLv3_server_method'
/home/sasha/.phpbrew/build/php-5.4.45/ext/openssl/xp_ssl.c:343: undefined reference to `SSLv3_client_method'
collect2: error: ld returned 1 exit status
Makefile:239: recipe for target 'sapi/cli/php' failed
make: *** [sapi/cli/php] Error 1
Please checkout the build log file for more details:
tail /home/sasha/.phpbrew/build/php-5.4.45/build.log
OS:
Ubuntu 16.04

Same problem here.

Looks like the openssl API was changed on Ubuntu 16. This couldn't be fixed without some patches for PHP.


Vulnerability is ignored unexpectedly

Expected Behavior
Scanning this file using kics should list "Hardcoded AWS Access Key In Lambda" vulnerability as part of the results.
Actual Behavior
"Hardcoded AWS Access Key In Lambda" vulnerability is ignored and not shown as part of the results
Deletion of the comment on line 32 fixes the issue.
Steps to Reproduce the Problem

Run the following command
docker run -t -v <path-to-terragoat-project>/terraform/aws:/path checkmarx/kics:latest scan -p /path
"Hardcoded AWS Access Key In Lambda" is not listed as part of the output

Delete the comment on line 32 in lambda.tf

Run the following command again
docker run -t -v <path-to-terragoat-project>/terraform/aws:/path checkmarx/kics:latest scan -p /path
Now "Hardcoded AWS Access Key In Lambda" is listed as expected

@cxMiguelSilva is anyone from the team given it a look?

Hi @ayala-orca,
Thank you for sharing this with us. I did a quick debug and came to the same result as you. Miguel (@cxMiguelSilva) or someone from his team are the most suitable ones to help with this.
One point I leave here is that despite this issue with the Hardcoded AWS Access Key In Lambda rule, the problem is correctly identified in the Passwords and Secrets - AWS Access Key rule.

Hi @lior-orca and @ayala-orca,
We already took an initial look at this issue. The problem resides somewhere in our Terraform parser and is not related to the rego queries. Thank you @rjegoncalves for the quick response and insights regarding this issue.
I will update this thread once we solve the bug.

Hi @lior-orca and @ayala-orca,
I am glad to let you know that this issue is being solved in #6170. The problem resided in the search key being unable to detect the vulnerability's correct location. Sorry for the misleading information in the previous comment.
Thank you so much for reporting this bug!


[AutoPR azureactivedirectory/resource-manager] chore: jsonfmt azureactivedirectory

Created to sync https://github.com/Azure/azure-rest-api-specs/pull/6301

This PR has been merged into https://github.com/Azure/azure-sdk-for-python/pull/5891


Improve develop info

Explain basic architecture and setup
More API docs
Better documentation for people who want to contribute

Started use Wiki for extra info


Upgrading to UserWarning so that the user gets the warning.

DeprecationWarning are hidden by default. Upgrading to UserWarning.

Maybe you could create a custom TorchAudioWarning type to make them easier for the user to filter them out without removing all the warnings?


Update to latest rust-dlc

Other than breaking changes to certain rust-dlc APIs, the main hurdle was to fix errors on ln-dlc-node tests that built on first
opening a DLC channel.
To do so we had to manually instruct the channel offerer to process the Finalize message. Before the dependency update this wasn't necessary, but now one must finish the channel open protocol before doing other things with the channel (such as closing it collaboratively), which makes sense.

bors r+

bors retry

bors retry

bors retry


missing word: but that will immediately any previous section

Not sure what should be here. Maybe this:
but that will immediately any previous section -> but that will immediately end any previous section

fixed


read_sql with return_type in "arrow2", "polars", "polars2" causes wrong selected date if date >= 2262/04/12

What language are you using?
Python
What version are you using?
connectorx 0.3.2a5
What database are you using?
Tested with Oracle and SQL Server.
What dataframe are you using?
polars 0.17.12
Can you describe your bug?
Selecting date columns with date in very future, cause inconsistents result. For instance, any date >= 2262/04/12 can reproduce this bug.
What are the steps to reproduce the behavior?
# ORACLE DB
import connectorx as cx
query = """SELECT TO_DATE('2262/04/11', 'YYYY/MM/DD') AS col_ok
                , TO_DATE('2262/04/12', 'YYYY/MM/DD') AS col_bugs_here
                , TO_DATE('2299/01/01', 'YYYY/MM/DD') AS col_bugs_here_too
          FROM dual"""

df = cx.read_sql(ENGINE_PATH, query, return_type="arrow2")

pyarrow.Table
COL_OK: timestamp[ns]
COL_BUGS_HERE: timestamp[ns]
COL_BUGS_HERE_TOO: timestamp[ns]
----
COL_OK: [[2262-04-11 00:00:00.000000000]]
COL_BUGS_HERE: [[1677-09-21 00:25:26.290448384]]
COL_BUGS_HERE_TOO: [[1714-06-13 00:25:26.290448384]]

The second and third columns dates blows up.
This happens if the return_type = None or "arrow2" or "polars" or "polars2".
But with return_type = "arrow" it works correct:
df = cx.read_sql(ENGINE_PATH, query, return_type="arrow")

pyarrow.Table
COL_OK: date64[ms]
COL_BUGS_HERE: date64[ms]
COL_BUGS_HERE_TOO: date64[ms]
----
COL_OK: [[2262-04-11]]
COL_BUGS_HERE: [[2262-04-12]]
COL_BUGS_HERE_TOO: [[2299-01-01]]

I've got this error through Polars, when loading data from a database, with columns with this kind os date.
Testing in SQL Server, with query = "SELECT CAST('2262-04-12' AS DATETIME2)" causes the same bug.
What is the error?
Very weired date is selected, instead the original date.
Maybe some kind of memory overflow??

It seems it's forcing the precision to ns; most databases only support ms or us precision though, so this is a bit overkill (and results in your overflow/wraparound) 😅

I was using 0.3.1 and didnt' see this behavior, so it is something new with 0.3.2. It's an issue with arrow2 and polars output.
This seems similar to the issue Pandas has using nanosecond precision everywhere, which causes us lots of issues with far future dates in the database. Particularly the end dates in type II dimensions.
Note that the new version does fix another bug I got on here to post about, which is that the Oracle DATE datatype is actually a timestamp but connectorx converts them to date32. 0.3.1 was truncating DATE columns with time components and returning them as a day32 format, which is also wrong. 0.3.2 returns timestamps for Oracle DATE columns, which is right, but does it at the overly granular nanosecond precision which now garbles the dates.
0.3.1 - Large DATE values come in correctly but return datatype truncates time
>>> query = """
...     select
...         date '9999-12-31' as extreme_date,
...         date '2023-01-01' as regular_date,
...         cast(timestamp '2023-01-01 12:34:56' as date) as date_w_time
...     from dual
... """
>>>
>>> connectorx.__version__
'0.3.1'
>>> df = connectorx.read_sql(
...     conn=url,
...     query=query,
...     return_type="arrow2",
... )
>>>
>>> df
pyarrow.Table
EXTREME_DATE: date32[day]
REGULAR_DATE: date32[day]
DATE_W_TIME: date32[day]
----
EXTREME_DATE: [[9999-12-31]]
REGULAR_DATE: [[2023-01-01]]
DATE_W_TIME: [[2023-01-01]]
>>>

0.3.2 - Large DATE values are garbled due to nanosecond precision, but are timestamps
>>> query = """
...     select
...         date '9999-12-31' as extreme_date,
...         date '2023-01-01' as regular_date,
...         cast(timestamp '2023-01-01 12:34:56' as date) as date_w_time
...     from dual
... """
>>>
>>> connectorx.__version__
'0.3.2'
>>> df = connectorx.read_sql(
...     conn=url,
...     query=query,
...     return_type='arrow2',
... )
>>>
>>> df
pyarrow.Table
EXTREME_DATE: timestamp[ns]
REGULAR_DATE: timestamp[ns]
DATE_W_TIME: timestamp[ns]
----
EXTREME_DATE: [[1816-03-29 05:56:08.066277376]]
REGULAR_DATE: [[2023-01-01 00:00:00.000000000]]
DATE_W_TIME: [[2023-01-01 12:34:56.000000000]]

Looking into this a little further, it appears that this was already an issue in earlier versions with timestamp fields - nanosecond precision failing for large/small dates. It was just masked in Oracle in versions prior to 0.3.2 due to the other bug which converted Oracle DATEs (which again are really timestamps) into date32[day] format.

@klaerik this bug appears with any date or datetime >= 2262/04/12
I'm using Polars, and I escaped it, by using cx return_type = "arrow" and them using polars.from_arrow


elastalert-create-index / errs / not working / not Idempotence

Hi, elastalert-create-index is failing for me, can you advise how to troubleshoot, resolve?
i have followed this issue, but I'm loss.
I was expecting the script to validate if the index exists prior to try to create it, and report that it does with exitcode 0 (index already exists); or to create the index again if using --recreate , but can't find the parameter for --recreate

[--recreate RECREATE]

Second, can you point to the documentation that explains the Permissions on ElasticSearch, when using TLS? The user has all read permissions on elastalert (create index will be requested) and on the index where the data to alert on is, but it is obvious from the 403 that I still lack some permissions
Lastly, the output of execution
tryes to create es_6 mappings into es_7 cluster, is this safe? can it be configured somewhere?
execution error
(virtual_env<EMAIL_ADDRESS>config$ elastalert-create-index --config config.yaml
Elastic Version: 7.5.0
Reading Elastic 6 index mappings:
Reading index mapping 'es_mappings/6/silence.json'
Reading index mapping 'es_mappings/6/elastalert_status.json'
Reading index mapping 'es_mappings/6/elastalert.json'
Reading index mapping 'es_mappings/6/past_elastalert.json'
Reading index mapping 'es_mappings/6/elastalert_error.json'
Traceback (most recent call last):
  File "/usr/local/elastalert/bin/virtual_env/bin/elastalert-create-index", line 11, in <module>
    load_entry_point('elastalert==0.2.1', 'console_scripts', 'elastalert-create-index')()
  File "/usr/local/elastalert/bin/virtual_env/lib64/python3.6/site-packages/elastalert/create_index.py", line 264, in main
    create_index_mappings(es_client=es, ea_index=index, recreate=args.recreate, old_ea_index=old_index)
  File "/usr/local/elastalert/bin/virtual_env/lib64/python3.6/site-packages/elastalert/create_index.py", line 30, in create_index_mappings
    if es_index.exists(ea_index):
  File "/usr/local/elastalert/bin/virtual_env/lib64/python3.6/site-packages/elasticsearch/client/utils.py", line 84, in _wrapped
    return func(*args, params=params, **kwargs)
  File "/usr/local/elastalert/bin/virtual_env/lib64/python3.6/site-packages/elasticsearch/client/indices.py", line 294, in exists
    return self.transport.perform_request("HEAD", _make_path(index), params=params)
  File "/usr/local/elastalert/bin/virtual_env/lib64/python3.6/site-packages/elasticsearch/transport.py", line 358, in perform_request
    timeout=timeout,
  File "/usr/local/elastalert/bin/virtual_env/lib64/python3.6/site-packages/elasticsearch/connection/http_requests.py", line 163, in perform_request
    self._raise_error(response.status_code, raw_data)
  File "/usr/local/elastalert/bin/virtual_env/lib64/python3.6/site-packages/elasticsearch/connection/base.py", line 182, in _raise_error
    status_code, error_message, additional_info
elasticsearch.exceptions.AuthorizationException: AuthorizationException(403, '')

execution with recreate:
(virtual_env<EMAIL_ADDRESS>config$ elastalert-create-index --config config.yaml  --recreate ''
Elastic Version: 7.5.0
Reading Elastic 6 index mappings:
Reading index mapping 'es_mappings/6/silence.json'
Reading index mapping 'es_mappings/6/elastalert_status.json'
Reading index mapping 'es_mappings/6/elastalert.json'
Reading index mapping 'es_mappings/6/past_elastalert.json'
Reading index mapping 'es_mappings/6/elastalert_error.json'
Traceback (most recent call last):
  File "/sites/monitoring-elastalert.internal/bin/virtual_env/bin/elastalert-create-index", line 11, in <module>
    load_entry_point('elastalert==0.2.1', 'console_scripts', 'elastalert-create-index')()
  File "/sites/monitoring-elastalert.internal/bin/virtual_env/lib64/python3.6/site-packages/elastalert/create_index.py", line 264, in main
    create_index_mappings(es_client=es, ea_index=index, recreate=args.recreate, old_ea_index=old_index)
  File "/sites/monitoring-elastalert.internal/bin/virtual_env/lib64/python3.6/site-packages/elastalert/create_index.py", line 30, in create_index_mappings
    if es_index.exists(ea_index):
  File "/sites/monitoring-elastalert.internal/bin/virtual_env/lib64/python3.6/site-packages/elasticsearch/client/utils.py", line 84, in _wrapped
    return func(*args, params=params, **kwargs)
  File "/sites/monitoring-elastalert.internal/bin/virtual_env/lib64/python3.6/site-packages/elasticsearch/client/indices.py", line 294, in exists
    return self.transport.perform_request("HEAD", _make_path(index), params=params)
  File "/sites/monitoring-elastalert.internal/bin/virtual_env/lib64/python3.6/site-packages/elasticsearch/transport.py", line 358, in perform_request
    timeout=timeout,
  File "/sites/monitoring-elastalert.internal/bin/virtual_env/lib64/python3.6/site-packages/elasticsearch/connection/http_requests.py", line 163, in perform_request
    self._raise_error(response.status_code, raw_data)
  File "/sites/monitoring-elastalert.internal/bin/virtual_env/lib64/python3.6/site-packages/elasticsearch/connection/base.py", line 182, in _raise_error
    status_code, error_message, additional_info
elasticsearch.exceptions.AuthorizationException: AuthorizationException(403, '')

python version

(virtual_env<EMAIL_ADDRESS>config$ python
Python 3.6.2 (default, Jul 18 2017, 22:59:34)
[GCC 4.8.5 20150623 (Red Hat 4.8.5-11)] on linux
Type "help", "copyright", "credits" or "license" for more information.

elastalert version

<EMAIL_ADDRESS>~$ source /usr/local/elastalert/bin/virtual_env/bin/activate
(virtual_env<EMAIL_ADDRESS>~$ pip freeze | grep elast
elastalert==0.2.1
elasticsearch==7.5.1

config file:
(virtual_env<EMAIL_ADDRESS>config$ cat config.yaml
# This is the folder that contains the rule yaml files
# Any .yaml file will be loaded as a rule
rules_folder: /usr/local/elastalert/config/rules.d

# How often ElastAlert will query Elasticsearch
# The unit can be anything from weeks to seconds
run_every:
  minutes: 3

# ElastAlert will buffer results from the most recent
# period of time, in case some log sources are not in real time
buffer_time:
  minutes: 1

# The Elasticsearch hostname for metadata writeback
# Note that every rule can have its own Elasticsearch host
es_host: elasticsearch-node-1.local.internal
# The Elasticsearch port
es_port: 9200
# Connect with TLS to Elasticsearch
use_ssl: True
# Verify TLS certificates
verify_certs: True
# GET request with body is the default option for Elasticsearch.
# If it fails for some reason, you can pass 'GET', 'POST' or 'source'.
# See http://elasticsearch-py.readthedocs.io/en/master/connection.html?highlight=send_get_body_as#transport
# for details
es_send_get_body_as: GET
# Option basic-auth username and password for Elasticsearch
#es_username: someusername
es_username: elastalert
es_password: super_password_123
# The index on es_host which is used for metadata storage
# This can be a unmapped index, but it is recommended that you run
# elastalert-create-index to set a mapping
# defaults: elastalert_status
writeback_index: elastalert_status
####
# Options from ElastAlert Documentation:
# https://elastalert.readthedocs.io/en/latest/elastalert.html#configuration
client_key: elastalert.local.key
client_cert: elastalert-1.local.cert
ca_certs: root_ca.crt
scan_subdirectories: True
old_query_limit:
  minutes: 60
disable_rules_on_error: True
add_metadata_alert: True
skip_invalid: True
scroll_keepalive: 10m

Taking it back.
 Skipping index creation.
(virtual_env<EMAIL_ADDRESS>config$ echo $?
0


docs/building-operators/helm/tutorial: remove unsupported 'operator-sdk run local'

Description of the change:
Updated the helm tutorial to match the unsupported status for 'operator-sdk run local' command.
Motivation for the change:
Disambiguation and avoidance of errors.

Sure! Will do it in a few minutes!

Squashed the edit, do you want me to open a pull request for 1.0.x or will we cherry-pick this one once it's applied to master?

Hi @kubealex,
Really thank you for your collab. I updated the title to clarifies better the change. I hope that it is fine.
Feel free to change if you do not agree.


Redefine the mesh path for all robots to match URDF convention

This task was partially done for the UR robot. We need to

Modify all URDF files to match convention
Add README documentation (optional)

Why would we need any documentation ? The whole point is that everything should work out of the box in all cases, right ?

Why would we need any documentation ? The whole point is that everything should work out of the box in all cases, right ?

Yes, I agree. But I am not sure if this possible. I didn't think about it.

Done.


Default tab length in "monaco" editor is now 4 signs instead of 2?

As title says: default tab length is now 4 spaces and thus many times unusable. Can it be reverted back to 2 ?

it is done in https://github.com/esphome/dashboard/pull/305.


Allow default case to return/break/continue

Currently you can't use the default case for control flow (ie. return) which is for example a common pattern to basically extract a value if there's a match or bail otherwise.
import gara, options

let opt = some 10

proc foo () =
  let val = match opt:
    Some(@a): a * 2
    _: return

  # do stuff with `val`

Sorry, I don't return is a good idea: let val = .. implies the expression will always return a valid value which will always be assigned to val. It would be not nice at all to break that, especially in a longer expession.
In your case, you can assign locally: Some(@a): val = a * 2 and return later. This is exactly how if / case work too.

Fair enough if you'd like to keep it as is but Rust's match works this way:
fn main() {
    let a = match "four" {
        "one" => 1,
        "two" => 2,
        _ => return
    };

    println!("a = {}", a); // never reached
}

It's hard to implement and it behaves differently than e.g. case as expression: I'd prefer to not do it for now


Automatically detect dependencies

For one-off scripts, it'd be a little more convenient to avoid having to write dependencies twice.  Once for the // cargo-deps:, and another for extern crate.  Could it perhaps infer // cargo-deps: from extern crate?
If the name has an underscore (which may or may not be a hyphen), then it could get the canonical name from crates.io.

Note that dependencies use package names and extern crate crate names, they can differ by more than just the hyphen.

Sorry for taking so long to respond to this.
There are numerous problems with this:

The crate name doesn't have to match the package name.
There's no way to specify version constraints.
There's no inherent way to correctly tell the difference between crates bundled with rustc and those you have to get via Cargo (and blacklists are dodgy).
extern crate can appear anywhere in the source, so I'd need a full Rust parser, which brings up massive compatibility problems.

As such, I'm not going to do this.  It's too much trouble to too small a gain.

What about the other way around then ? Auto-generate an extern crate for each crate that's in the generated Cargo.toml ?

I could've sworn I've had that discussion before, but damned if I can find it.
You still have the exact same problem: the name of the package doesn't have anything to do with the name of the actual library.  Knowing the package name doesn't tell you what the extern crate line has to contain.
Now, there's the -D / --dep-extern flag for expressions which does this, but that's only because there's also the -d / --dep flag which doesn't add an extern crate.  Basically, you can only do this if the user tells you which one to use.  At that point, you're having to add extra information to the script to tell it how to link to an external dependency... you might as well just write the extern crate out.
There's also another, softer reason why I don't like this idea: it means that you end up with .rs files that aren't actually compilable by anything other than cargo-script.  I really like that the current system works in such a way that the extra manifest information is just a comment that someone can interpret themselves without having to modify the script, and just pass it as-is to Cargo or rustc if they want.

Just a nit : Knowing the package name does tell you the extern crate line though. A package name is basically [a-zA-Z0-9_-]+ and the only 'weird' rule is that - becomes _.
I get what you mean about keeping some semblance of compatibility with the rest of the world, it's why the first idea was to take extern crate. I think I'm going to toy around with https://dtolnay.github.io/syn/syn/ and prototype something that does what I want, since it's something I'd really like for various reasons.

Knowing the package name does tell you the extern crate line though.

No, it doesn't.  You can name the library anything you want.  Look at the winapi family of crates.  The package kernel32-sys has a crate name of kernel32.  There is absolutely no requirement whatsoever for the package name and crate name to share anything in common.
And, again, parsing the extern crate items has the exact same problem, just in reverse.  Well, that and you also can't specify version numbers.

Just to have a more extreme example: Package piston2d-graphics uses crate name graphics.

  :P

Of interest : https://www.reddit.com/r/rust/comments/6q4m94/rfc_infer_extern_crate_declarations/

I originally intended cargo-script to link to Cargo itself for more information, but gave up based on two points: firstl, Cargo itself is a rat's nest of a codebase and I gave up trying to find a clean way of getting what I needed.  Secondly, Cargo is/was a pain to build on Windows, and I didn't need it that badly.
Also, you might be surprised to learn I'm very much not in favour of that RFC.  That said, if it gets accepted, then this becomes a completely moot point: the behaviour you want would just happen automatically without any changes needing to happen to cargo-script at all.


Fixed a bug that cause intermitted test failures.

fixes https://jira.duraspace.org/browse/FCREPO-2270

I tested this on my system, where previously the fcrepo-http-api module tests failed about 50% of the time. After running the test suite 40 times with no failures, I am confident that this change fixes the issue.

:+1:


[$250] LHN-Reports/chats missing in LHN when logging in to account in "#focus" priority mode

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 1.4.82-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team
Action Performed:

Log in to New Expensify with account<EMAIL_ADDRESS>Note the amount of reports in LHN
Navigate to settings > Preferences
Change priority mode to "#focus"
Log out and log in with the same account
Change the priority mode back to Most Recent

Expected Result:
The same amount of chats should be displayed as in Step 2
Actual Result:
Many chats (depending on the amount in account) are missing in LHN
The chats do not reappear after refreshing the page/relaunching the app, user is forced to change priority mode to most recent and relog to see all reports in LHN
Not reproducible for pinned/GBR chats.
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos
Add any screenshot/video evidence

https://github.com/Expensify/App/assets/78819774/5534c0c6-13a8-4d13-a081-9c17780c3ec3
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~013c1484a9570e0a56
Upwork Job ID:<PHONE_NUMBER>630180667
Last Price Increase: 2024-06-13

Issue OwnerCurrent Issue Owner: @getusha

@twisterdotcom  FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

Waiting on proposals

Waiting on proposals

Waiting for proposals

Doubling

Still waiting on proposals.

Okay, I'm not clear if this is still an issue. I tested it with<EMAIL_ADDRESS>and couldn't recreate. Gonna ask for a retest.

Issue is reproducible during KI retests.
https://github.com/Expensify/App/assets/43995119/06a72e13-eaf7-4f3f-9675-14846e4fbc97

Okay, so the recreation steps should be amended a bit:

Log in to any account
Make the preference "Most recent"
Pin a few of the chats, but leave some unpinned and without drafts
Switch to Focus mode
Sign in to the same account in a different browser window
Switch back to "Most recent"
See we did not load the unpinned chats into the LHN.

Hi, I am Alexey from Margelo and I can work on this issue.

This one is likely to be a BE issue: when we switch the priority mode in preferences, the request is sent to BE to update chat priority mode. The request seems correct and work properly when we switch modes from default to focus and back, however, if we switch the mode to focus, log out, log in again and switch it back to default (see ticket description), it seems that the next OpenReport query returns old data (3 records instead of 5 in my case), even though the flag has been changed

@getusha do you agree?

Yes, it looks like a backend issue. I see that nvp_priorityMode is set to the correct value, but as @Kureev mentioned, OpenReport is returning the filtered data despite the change.

Okay, let's make this internal.

I've just realized. This isn't a quality issue

It's a regular bug, because it's reliably reproduced.

I'm going to remove it from the project (sorry!)

Okay, this is still Internal and super annoying because it means your LHN is out of sync. Seems we know the problem, we just need somebody internal to take it on.

No internal assignee yet. Going to downgrade to Monthly given no uptake.

Not a priority it seems then


[bug]  padding

Describe the bug
The block padding for card's body and footer needs to be adjusted. Right now the space between the body and footer is 64px because of padding in both sections. The space between the body and footer should be 24px (--rh-space-xl).
Additionally, can the padding-inline of header be changed to --rh-space-2xl? It'll help the content in the header align with the rest of the content.
Which Component?
rh-card
Steps to reproduce

Pull up a demo of card.
Check to see if padding matches screenshots below.

Expected behaviour
The space between the body and footer should be 24px (--rh-space-2xl). Inline padding of header should change to 32px (--rh-space-2xl).
Screenshots
Current padding/spacing:

Expected spacing:

Element HTML
No response
Operating System (OS)
macOS
Browser
No response
More browser information
No response
Additional Info
No response

i see now, so this maybe could be solved with margin-trim, which is experimental
but in the mean time we can work this out maximum with empty classes and some oldschool css


Answering call for new maintainers

Hiya!
Great minds think alike! I actually started something extremely similiar the past couple of days, joshuadavidthomas/pytest-rich-reporter, though my project is barely past the 'get the bare minimum working implementation` phase.
At my day job I'm a web developer using primarily Django, so I'm familiar with using pytest. However, I'm quite green when it comes to actually developing custom plugins for it. I started the project as a way to explore and learn a bit of the internals of pytest.
If you'd be willing, I'd love to come on and help out in whatever way I can.

Hi @joshuadavidthomas!
Sounds great!
Feel free to look at the code and the issues I've opened up, and working in any of them. As things progress and you contribute more to the project, we can make you an official maintainer and even eventually transferring the repository to you if you like.
Closing this then, welcome!

Hi @nicoddemus @joshuadavidthomas!
First thank you all for the work on this project. I've just stumbled upon a post that mentioned this project and I got very interested on contributing to it. When you get a chance please let me know how can I help

Thanks @mazulo!
Feel free to browse the existing issues, and pick up any that interests you. Have you worked with pytest plugins before?

Thanks @mazulo!
Feel free to browse the existing issues, and pick up any that interests you. Have you worked with pytest plugins before?

Hey @nicoddemus not much. What I've done before was digging into the source code from a few plugins when I faced an issue and was trying to understand how it worked. But I'm going to take a look at the Pytest docs about plugins to get more familiarized/context


Wooded Kingdom Crash

After the Cutscene for Defeating Spewart, a white screen appears and then the game crashes. After loading the save, you crash immediately.

This probably came from spawning too many actors to capture, however, i dont think this is an issue anymore, but if it is someone please comment and I'll reopen this.


feat: add bbjs testing workflow

This PR introduces a GitHub Actions workflow named Test bb.js. The purpose of this workflow is to automate the testing and building process for our bb.js library in the browser.
Key Features of the Workflow:

Compiles the TypeScript code and packs the library for npm.
Integrates with the nextjs-bbjs-demo repository for testing.
Runs development and test scripts for thorough validation.

Links to: https://github.com/noir-lang/noir/issues/2252
This workflow is tested here: https://github.com/AztecProtocol/barretenberg/pull/702
Needs this to be merged: https://github.com/noir-lang/nextjs-bbjs-demo/pull/1

I think this is superceded by #1855


Handle digits precision

This commit fixes handling precision in digits.
# Previously returned "10"
assert(sprintf("%0.4d", [10]) == "0010")

Thanks and sorry being late to merge.


Unable to upload when logged-in with Github

How to reproduce

Go to https://openbenches.org/
Click on Add bench
Click on Sign in, Continue with Github
Complete the Github auth steps
Get returned to https://openbenches.org/add/
Which is just this

Clicking the Add bench button does nothing

Clients tried
I got the same result on:

Android Chrome
Android Firefox
Linux Chrome

This is very strange. I can see that some people are still signing in via GitHub - https://openbenches.org/bench/28592 - and I'm able to sign in.
Could you please try visiting https://openbenches.org/logout and see if that helps?
I'm in the process of finding a new social sign on service, so this is a good data point.

This is very strange. I can see that some people are still signing in via GitHub - https://openbenches.org/bench/28592 - and I'm able to sign in.
Could you please try visiting https://openbenches.org/logout and see if that helps?
I'm in the process of finding a new social sign on service, so this is a good data point.

This didn't make any difference, and I've since tried in it on my Mac with Chrome, Firefox and Safari and I get the same every time

Same thing using Edge in Parallels on my Mac (GitHub authentication). Will try an actual Windows computer.

The bad news is... I have no idea what's causing this. Only happens on Safari - which I have replicated.
The good new is... I have fixed this! The site rewrite should be live this weekend. I'll update this when done.

I think this is now fixed. Can you try going to https://openbenches.org/logout and then https://openbenches.org/add/logged_in

I've been looking at all the benches I pass waiting for one with an inscription.  Captured this one on my morning run, GitHub login worked perfectly https://openbenches.org/bench/28724
Thanks!

Thanks. I've now fixed the editing as well.


Do not reinstall existing dependencies

Closes #292, references #242 and a whole bunch of other issues.

Thank you sir!


Content picker doesn't work

The "add" button doesn't do anything onclick.

It is because there is no more id="layout-content" in Layout.cshtml.
It is called in many .js scripts.

The popup is also missing many css to be well rendered.

Still need to style ContentPicker.SummaryAdmin .cshtml

Still have an issue in Orchard.contentPicker/scripts/SelectableContentTab.js, line 21 :
window.opener.jQueryquery("callback");
window.opener.jQuery[query(...)] is not a function

Still need to fix tabs.
And change filters in RecentContentTab.cshtml

Pager is also not well displayed. see #21

I fixed a few display errors in the popup. The selected item(s) display still need to be well designed.

Selected content item fixed.
Stil need to right align the select button in popup but a flexbox css on .properties seems to be in conflict.


Integrate with angular-ui router.

As John Lindquist put it: needs some ui-router love.

Don't think I'll have the time to make another implementation for ui-router, but I will support the new Angular router coming in 1.4 (March).


[Bug]:  Fixing Nav Bar Let's Go Tab & RESET box

Give a brief about the bug ✍
Description
###Nav Bar:

-> Here in the Let's Go tab, The dimension of the box is not looking good

->The Text inside the reset button is equal as the start-button
->The color of start -button should be greenish
->The color of reset button should be reddish
What is the expected behavior? 🤔
Description:
button box

Butons will look something like this, i will add the gradient which will look more modern
###nav-bar button

Something like this with more modern look
Provide step by step information reproduce the bug 📄
Description
I will add the gradient with more modern designs
Select program in which you are contributing
GSSoC24
Code of Conduct

[X] I follow CONTRIBUTING GUIDELINE of this project.

@Durgesh4993  Please assign this issue to me, looking forward to have an amazing UI.
Thanks


move TODOs to issues

I think it's better to keep "TODO"s in one place.

Agreed. "TODO"s will go away over the next week or so; I am starting to write the extended abstract and in doing so will finalize some missing todo items

Fixed in https://github.com/QAOAKit/QAOAKit/commit/506ad0f814a056db488ce1406b6c1478a98be367