theme reset on esc

When user interacts with hotkey "esc" for going back to main menu, theme is back to default (light theme), regardless if users choice is dark theme

Following code does redirect back to the previous page, but it reloads page, which resets theme to default (light).
const redirectHome = () => {
        window.location.href = './index.html';
        //window.history.back()
        //window.history.go(-1)
    };

Interacting with back button does not make an issue, theme remains as selected.


Cannot use custom admin site "NoReverseMatch at /admin/"

What version of Unfold are you using?
0.34.0
What version of Django are you using?
5.0.7
What browser are you using?
Chrome 123
Did you checked changelog/commit history, if the bug is not already fixed?
Yes
Did you searched other issues, if the bug is not already fixed?
Yes
Repository with reproduced bug
https://github.com/bubblegumsoldier/django-unfold-custom-admin-example/tree/main
Describe your issue
I would like to be able to register my custom AdminSite like this:
from django.contrib import admin
from django.contrib.auth.models import User
from unfold import admin as unfold_admin

class CustomAdminSite(admin.AdminSite):
    def get_urls(self):
        urls = super(CustomAdminSite, self).get_urls()
        custom_urls = []
        return custom_urls + urls

class UserAdmin(unfold_admin.ModelAdmin):
    model = User

custom_admin_site = CustomAdminSite(name="snh2_dj_admin")
custom_admin_site.register(User, UserAdmin)

I can then register it like this:
from django.urls import path
from custom_admin.admin import custom_admin_site

urlpatterns = [
    path('admin/', custom_admin_site.urls),
]

That way I can specify what fields I would like to show in which django admin and can serve different types of admins under different routes very easily. It is a default functionality of django and I have been using it in multiple projects. That way if I have two user-groups I can build dedicated admins under different urls for each of them showing them different fields.
However, when I open the django app I get this issue:
NoReverseMatch at /admin/
Reverse for 'toggle_sidebar' not found. 'toggle_sidebar' is not a valid view function or pattern name.

Thanks 👍

Did you checked Formula repository? It implements custom admin site and it works.

Will check right away, thanks!

https://github.com/unfoldadmin/django-unfold/pull/659
Created PR


Hide Restore link and Snapshot button for entry previewers

Changes nothing about actual permissions; they were not allowed to use
these anyway

Coverage remained the same at 99.143% when pulling d767ab3bdaebe026543db6b8872a8a9019aa7dda on aviav:revisions-tab-permissions-fix into c042126bf0d90d4cbd7a0bfcf16a4cff9e75bbf8 on codevise:master.


[#3434] Improvement(build): Avoid name conflicts with project.properties

What changes were proposed in this pull request?
The naming of project.properties may conflict with other dependencies. When the class loading order is uncertain, it will cause the version comparison of the client and server to fail because of using the file of other dependencies. The naming rules here refer to Gluten.
Why are the changes needed?
Fix: #3434

@diqiu50 @jerryshao Could you please take a look of this? Thanks.


[stable/unifi] Docs: Fix name of cert secret

What this PR does / why we need it:
This PR fixes errant documentation in the unified chart.
Which issue this PR fixes
N/A
Special notes for your reviewer:
This is a simple documentation change so I didn't bother with bumping the chart version. I'm happy to do so if that's desired.
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[ ] DCO signed
[ ] Chart Version bumped
[ ] Variables are documented in the README.md
[ ] Title of the PR starts with chart name (e.g. [stable/mychartname])

@billimek @mcronce

Thanks @farmdawgnation, can you also please bump the chart version in Charts.yaml ?

Happy to! Just wasn't sure if I should for "just a doc change" :)
Doing it now.

/ok-to-test

✖ unifi => (version: "0.10.0", path: "stable/unifi") > Chart version not ok. Needs a version bump!

Hm, I've missed something.

/retest

/assign @billimek

/lgtm


🎮 Game Request
A simple match-3 for you to become THE Elementalist!
Point down the features
Gain levels by matching 3 or more elements.
Select program in which you are contributing
GSSoC23
Code of Conduct

[X] I follow CONTRIBUTING GUIDELINE of this project.

Hey @S-ishita !
Thank you for raising an issue 💗
You can self assign the issue by commenting /assign in comment 😀
Make sure you follow CODE OF CONDUCT and CONTRIBUTING GUIDELINES 🚀
Don’t Forget to ⭐ our GameZone🎮
Make sure you join our Discord🕹

Hey @S-ishita!
We are already having a similar game request in #1331 👀
Make sure you come up with a cool unique idea 😀
Waiting for your new game idea 💗.

Hey @S-ishita ! Thank you so much for your raising the issue💗
It’s all yours, you can come anytime again and make some contributions! 🚀
Alone, we can do little, but together we can do so much! 😇


Possible issues due to dev.onyxstudios

When running 1.16.5, the game seems to crash on startup.
crash-2021-05-15_10.36.41-client.txt

Hmm weird nobody sent me this kind of error earlier...
I see you had no other mods installed, except xp_storage and the fabric API, right?
I don't have a lot of time but I'll try to know the what's the issue quickly. I never tried with MultiMC launcher and I don't know why it would be a problem... Let me give it a try

It seems to work now, I'm not exactly sure why but it's working fine. May have been a hiccup with multimc or something.

Alright, glad to know then! Enjoy


Add Nav Link Text Color Override

I'm building a site with a dark color for the navigation background. The primary color is also on the dark side. The issue is that the primary color is used for for the menu active text .mud-nav-link.active. I made attempts to override the value but it seems as adding a pallet color for navigation text this would be a nice addition.
Thanks!

The color of NavMenu can now be set.


Add French translations

Thank you very much for your contribution, @regisrob ! Will be released as version 0.3.0 soon :smiley:

That was quick! Thanks @morpheus-87 😉


[backport] Support device specifiers in PTB example

Backport of #7055

[automatic post] Jenkins, test this please.

LGTM!

Jenkins CI test (for commit 0ee98a68d4babeefb6f8bf3f82c50c5c675cacf5, target branch v6) failed with status FAILURE.

Jenkins, test this please.

Jenkins CI test (for commit 0ee98a68d4babeefb6f8bf3f82c50c5c675cacf5, target branch v6) failed with status FAILURE.

LGTM, failures seem unrelated.


Allow for empty setting designator

The IVCT GUI enforces a non-empty RTI settings designator. This way it is impossible that the system ever falls back on the default. In the case of the IVCT Docker version the default can be set from the docker-compose file. Setting the default from the compose file is quite useful for automation (less action required from the user). Request therefore to allow for an empty string.

This enhancement is needed urgently to assist testing the IVCT with different RTIs.

possible solution is to use empty string in CS.json, and interpret this as a fallback to the default value

other option is to include a boolean property in the CS.json, like "USE_DEFAULT_SETTINGS_DESIGNATOR" to overwrite the actual CS setting.

Tried editing the CS file, but no effect.
These is a SETTINGS_DESIGNATOR ENV, but the handling is entirely unclear, see https://github.com/IVCTool/IVCT_Framework/issues/229.

handling should work as desribed in https://github.com/IVCTool/IVCT_Framework/blob/development/docs/src/2-8-IVCT_Configuration.adoc
Currently using default settings instead of using the CS settings is not possible. This requires GUI extension --> feature request

Given the handling as described on https://github.com/IVCTool/IVCT_Framework/blob/development/docs/src/2-8-IVCT_Configuration.adoc, I propose to set the value of the SETTINGS_DESIGNATOR to an empty string.  The currently listed default value is Pitch RTI specific.
The LRC Base image currently uses FEDERATIONNAME (see https://ci.tno.nl/gitlab/msaas/general/lrc). The naming needs to be aligned (TBD).

agreed. I have changed the default SETTINGS_DESIGNATOR to an empty string, in order to avoid vendor specfic IVCTool defaults.


How to access /AA dictionary of an annotation

How would I access the contents of the /AA dictionary of an annotation?
I read somewhere that the additional actions of an annotation are not supported by pdf.js. This is fine (and I am intending to implement a portion of them). However: The promise I get via page.getAnnotations() provide me with no handle to even parse these data and I am not sure if it is indeed necessary to extend the parser, and if yes how, and if no if there is a further function via which I can get the contents of the /AA.
The issue to be repaired here: The documentation does not really help with this... :-(

Generally speaking: When opening an issue, please provide all of the information requested in https://github.com/mozilla/pdf.js/blob/master/.github/ISSUE_TEMPLATE.md

How would I access the contents of the /AA dictionary of an annotation?

You can't, since there's currently no parsing of that entry; this issue is thus (basically) a duplicate of e.g. #9776.

Given that all parsing happens in a worker-thread, you cannot pass data as-is to the main-thread (which is where the API is) without first carefully validating it (since all data needs to be clonable) and converting it into a format that makes sense for the display-layer.


Recover options (success or failed)  isn't working, due VM have same prev state variables:
  <STATE>3</STATE>
  <LCM_STATE>63</LCM_STATE>
  <PREV_STATE>3</PREV_STATE>
  <PREV_LCM_STATE>63</PREV_LCM_STATE>

To Reproduce
I'm not sure, but try to start resizing VM by hook immediately after it went into POWEROFF state.
Sometimes it work like so.
Expected behavior
VM resized without problems
Details

Affected Component: [e.g. Sunstone, Scheduler or Storage]
Hypervisor: [e.g. KVM]
Version: [e.g. 5.4.12 or development]

Additional context
Currently the only way to solve this problem is hard replace it's state in db:
onedb change-body vm --id $VMID /VM/STATE 8
onedb change-body vm --id $VMID /VM/LCM_STATE 0

Progress Status

[ ] Branch created
[ ] Code committed to development branch
[ ] Testing - QA
[ ] Documentation
[ ] Release notes - resolved issues, compatibility, known issues
[ ] Code committed to upstream release/hotfix branches
[ ] Documentation committed to upstream release/hotfix branches

I can reproduce this behaviour for "SNAPSHOT" as well. Taking new (Ceph) snapshots as well as reverting. As soon as I execute a script that performs quit a few operations after each other the VM might get stuck in a STATE. A "recover" operation won't help at that point in time. And I need to use "update-body vm --id $id" to fix STATES by hand.

AFAIU this is for fixing the recovery process for several transient operations.

The problem is in the hook script. If I have hook on power off state:
VM_HOOK = [
 name      = "poweroff_hook",
 on        = "CUSTOM",
 state     = "POWEROFF",
 lcm_state = "LCM_INIT",
 command   = "/tmp/my_hook",
 arguments = "$ID $PREV_STATE $PREV_LCM_STATE" ]

The my_hook script:
onevm disk-snapshot-create $1 0 generate_new_name
The state transition after power of is:
POWEROFF -> hook trigger -> DISK_SNAPHOT_POWEROFF -> POWEROFF -> hook trigger -> DISK_SNAPSHOT_POWEROFF -> ... and so on forever
Solution to this might be to check the $PREV_LCM_STATE at the begining of the hook. If it is SHUTDOWN_POWEROFF then execute the script, if it is DISK_SNAPSHOT_POWEROFF exit


Cleanups and refactors

This is a random collection of refactors.  Sorry that it's not more structured.  I'll leave comments inline in the diff.

Current coverage is 94.49%

Merging #310 into master will increase coverage by +2.76% as of c39b976

@@            master    #310   diff @@
======================================
  Files            9       9
  Stmts          230     218    -12
  Branches        48      47     -1
  Methods        110     106     -4
======================================
- Hit            211     206     -5
+ Partial          5       3     -2
+ Missed          14       9     -5

Review entire Coverage Diff as of c39b976

Uncovered Suggestions

+1.38% via src/datepicker.jsx#90...92
+0.92% via src/calendar.jsx#95...96
+0.46% via ...dropdown_options.jsx#69...69
See 3 more...

Powered by Codecov. Updated on successful CI builds.

Looks like one of the tests is still failing.

Aha, forgot I had a fix for the other test in my git stash =P

@martijnrusschen, the codecov CI results always seem to get stuck in pending, do you know what might be going on?

I pushed a change for the codecov hook in travis.yml. Not sure if it fixes the issue, but this looks to be the recommended way to do this.

Okay, looks like I made a mistake in the codecov config. I fixed that, so it should be able to post its status to GH now. This diff looks good to go.

Hooray, codecov worked now!


return best_regularization in the TRF.test

I think it is still a good idea to return the best_regularization, because it is decided based on the mse of the training fold but we just return the r and mse for  the testing fold

The reason I took it out is that I can not really imagine a situation where one might want this output, If you disagree about that I am happy to discuss putting it back in

seems that returning it would potentially be helpful when people want to choose a regularization parameter for permutation test #21


Change page title

Changed the page title to "Event Calendar" (Closes #24 )

@CodingSpecies Thank You for pointing it out. I have removed it.

@CodingSpecies Thank You for pointing it out. I have removed it.

@CodingSpecies Thank You for pointing it out. I have removed it. I deleted it. But I think this would not work?

In the LinkFree repo in EddieHub, the package.json is always altered, so we tell them to take it out of the commits. We will see what the maintainers say. Thank you.

Great collaboration 👍
Deleting it is not a good idea, it is best to put it back to what it was, I think you can use
git checkout origin/master package-lock.json

@eddiejaoude so in this repo do we not need to remove the package.json? Unless it is needed for this pull request?

We need to keep the package.json and package-lock.json files in the repo, but people should not commit these unless they made changes to the package.json file

Ok thank you

Should I change anything or wait for maintainers to instruct?

@developer-diganta https://github.com/EddieHubCommunity/EventCalendar/pull/25#issuecomment-962280718

"error: pathspec 'origin/master' did not match any file(s) known to git " I get this error.. What can I do to resolve it?

"error: pathspec 'origin/master' did not match any file(s) known to git " I get this error.. What can I do to resolve it?

We dont have a master branch. We have a main branch 😄

@mohan-murali Thank you so much for pointing it out! I have done it....

Great collaboration everyone.
Thanks for the updates @developer-diganta , we can merge once the package-lock file is removed from the PR

Sorry! Got a bit busy with college work.. I wanted to know how to remove the file from the pr?

No problem.
I added a comment previously https://github.com/EddieHubCommunity/EventCalendar/pull/25#issuecomment-962280718

@eddiejaoude  I have run that command. Is there anything else that I should do?

@eddiejaoude I have run that command. Is there anything else that I should do?

@developer-diganta An easy way would be to just copy-paste the file from this repo, Created PR: https://github.com/developer-diganta/EventCalendar/pull/1

Hey there @developer-diganta 👋 Just checking in, do you need any help?

Sorry! I had not seen this for quite some time now. I think the changes this PR targeted has already been made. Shall I close this PR?


Create master-pr-check-version.yml

This PR should fail until we add a commit bumping the version.

Good, it failed. Works as intended!


[Enhancement]: Publishing message to Rabbitmq test-container Queue and consuming it

Module
RabbitMQ
Proposal

Currently, looks like we don't support publishing message to Rabbitmq test-container Queue and consuming it.
Also, when this functionality is completed, we should have proper documentation around it.

Can you elaborate on this, please? Are you talking about utility methods to use rabbimq command inside the container?

I'm trying to write integration test for my Spring Application which uses Rabbitmq as Message Broker. In order to do that I have made below mentioned changes,

Adding Rabbitmq container details to the ConnectionFactory,

@Bean
  public CachingConnectionFactory connectionFactory() throws Exception {

    RabbitMQContainer rabbit =
        new RabbitMQContainer(DockerImageName.parse("rabbitmq:3.7.25-management-alpine"));
    rabbit.start();

    final RabbitConnectionFactoryBean rabbitConnectionFactoryBean =
        new RabbitConnectionFactoryBean();
    rabbitConnectionFactoryBean.setHost(rabbit.getHost());
    rabbitConnectionFactoryBean.setPort(rabbit.getAmqpPort());
    rabbitConnectionFactoryBean.setUsername(rabbit.getAdminUsername());
    rabbitConnectionFactoryBean.setPassword(rabbit.getAdminPassword());
    rabbitConnectionFactoryBean.setUseSSL(Boolean.parseBoolean(userSsl));
    rabbitConnectionFactoryBean.setSslAlgorithm(sslVersion);
    rabbitConnectionFactoryBean.setEnableHostnameVerification(false);
    rabbitConnectionFactoryBean.afterPropertiesSet();

    final CachingConnectionFactory connectionFactory =
        new CachingConnectionFactory(rabbitConnectionFactoryBean.getObject());

    return connectionFactory;

Similarly created RabbitTemplate, SimpleRabbitListenerContainerFactory  and using above mentioned connection factory
  @Bean
  public SimpleRabbitListenerContainerFactory rabbitListenerContainerFactory() throws Exception {
    SimpleRabbitListenerContainerFactory factory = new SimpleRabbitListenerContainerFactory();
    factory.setConnectionFactory(connectionFactory());
    factory.setMaxConcurrentConsumers(1);
       return factory;
  }

 @Bean
  public RabbitTemplate amqpTemplate() throws Exception {
    return new RabbitTemplate(connectionFactory());
  }

@Bean
  public Queue abc() {
    return new Queue("abc", false);
  }

Next I'm creating Exchange and Routing Key binding to Queues,

 @Bean
  public Declarables httpBinding() {
    val queue = QueueBuilder.durable("queue").build();
    val declarables = new Declarables(exchange, queue,
        bind(queue).to("exchange")
            .with("routingKey");
    return declarables;
  }

Now, I send message to the Rabbitmq

rabbitTemplate.convertAndSend(exchange, routingKey, "data");

But I don't see my Rabbitmq listener listening to this message here,
 @RabbitListener(id = "1",
      queues = "queue")
  public void listener(final Message message) throws DimensionException {
  // .......
  }

Am I missing something here, as per my understanding the only change that needs to be done is that ConnectionFactory should point to Rabbitmq test container, ryt?
Also, can we do more operations with RabbitMQContainer?
Even, I have bean created for the Queue, I'm getting this error in logs

2023-09-01 00:38:38,888 WARN  [1-1] listener.BlockingQueueConsumer (BlockingQueueConsumer.java:670) - Queue declaration failed; retries left=3
org.springframework.amqp.rabbit.listener.BlockingQueueConsumer$DeclarationException: Failed to declare queue(s):[abc]


Better Installation Instruction

We would like to improve the installation instructions for HADES with container and Linux instructions.

Inspired by our Github Actions workflow, here are the Linux libraries you'll need:
apt-get install -y libssh-dev
apt-get install -y default-jdk
apt-get install -y make
apt-get install -y libicu-dev
apt-get install -y libcurl4-openssl-dev
apt-get install -y libssl-dev
apt-get install -y libxml2-dev
apt-get install -y pandoc
apt-get install -y git
apt-get install -y libssh2-1-dev
apt-get install -y libpq-dev
apt-get install -y unixodbc-dev

I don't see libsodium, but some packages (like keyring) will need that too,

Here is the repo to check out in order to submit pull requests...
https://github.com/ftrotter/Broadsea


Make action bar match theme colour when run as PWA

Chrome

Before
After

iOS

Before
After

Dark mode sidebar fix

Before
After

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@f78389b). Click here to learn what that means.
Patch has no changes to coverable lines.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #793   +/-   ##
=======================================
  Coverage        ?   65.85%
=======================================
  Files           ?       53
  Lines           ?     7646
  Branches        ?        0
=======================================
  Hits            ?     5035
  Misses          ?     1775
  Partials        ?      836

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Thanks for the proposal! However, it would involve to many things (security, specific headers, etc.) and I don’t have enough time nor the will to maintain such feature.


K8s operator tweaks

What changed, and why it matters
A couple of additions to the Kubernetes operator docs, from some friction I had when trying it out in GCP kubernetes engine.

Hi @kevinbowman-aiven thanks for this clarification. I validated that on Standard GKE, the command works as expected and the pods are running. As you mentioned, for Autopilot GKE, -n cert-manager needs to be specified and then the pods are running. Few observations:
I see the following warnings with autopilot:
Warning: Autopilot set default resource requests for Deployment cert-manager/cert-manager-cainjector, as resource requests were not specified. See http://g.co/gke/autopilot-defaults.
deployment.apps/cert-manager-cainjector created
Warning: Autopilot set default resource requests for Deployment cert-manager/cert-manager, as resource requests were not specified. See http://g.co/gke/autopilot-defaults.
deployment.apps/cert-manager created
Warning: Autopilot set default resource requests for Deployment cert-manager/cert-manager-webhook, as resource requests were not specified. See http://g.co/gke/autopilot-defaults.
deployment.apps/cert-manager-webhook created
Warning: AdmissionWebhookController: mutated namespaceselector of the webhooks to enforce GKE Autopilot policies.

I see the following here:
name: cert-manager-cainjector:leaderelection
  namespace: kube-system

Since this is the case, how do we override global.leaderElection.namespace from kube-system to cert-manager?  I see the Helm option "--set global.leaderElection.namespace=cert-manager". Can we do this with kubectl?

Makes sense. Do you think mentioning ** into cert-manager namespace** might be a bit more clear instead of into a specified namespace? This is just nits.

Yeah absolutely, I'm happy with nit-picking :)  I'll update the PR (although I also don't mind if you want to make tweaks yourself, I'm not precious about it).


Add some basic Issue templates for easier triage

Summary
Adds templates for people to file bugs into. These will:

Auto-assign some labels onto the issues
Structure input a little more clearly

Test Plan
N/A, this is a GitHub-specific change. You can check out what it looks like here: https://github.com/jvacek/ruff/issues/new/choose

The point is to make it easier to parse out what's going on from an issue, and effectively push it to the next step.
I'm very happy to hear out what your most common issues are like so I can structure this into something that would be more useful for you guys.

Lot of CI running there for a non-code MR 🤔

Thanks for the nice message, understood, already had a brief chat in the discord about this.
FYI the example here is very over the top, but just wanted to show off the fields that make sense.
I'd propose keeping only the version field, one markdown field for free text, and the optional field for keywords.


lxd launch --vm should wait for lxd-agent to be ready before returning

Required information

Distribution: Ubuntu
Distribution version: 21.04 (devel)
The output of "lxc info" or if that fails:

Kernel version: 5.8.0-25-generic
LXC version: 4.7
LXD version: 4.7
Storage backend in use: zfs

Issue description
Currently when lxd launch --vm returns there's not guarantee that the VM is already reachable via lxd-agent. When using LXD interactively this means that one should try lxc exec several times before being able to proceed (poor UX). In automation this translates in polling loops that do basically the same. I understand there isn't really a better way then polling, but then I think this polling should be done by LXD itself and hidden from the user/consumer.
The polling loop is not immediate to do right, as sometimes right after a VM launch lxd-agent becomes reachable for a short moment, then unreachable again, and then finally up for real (see "steps to reproduce" below). This causes issues in automation and working around it with an arbitrary sleep feels wrong. Another good reason to have a solid wait logic implemented on the LXD side.
Steps to reproduce
$ lxc launch --vm ubuntu:focal paride-f-vm
Creating paride-f-vm
Starting paride-f-vm

# Nice! VM is up?

$ lxc exec paride-f-vm uptime
Error: Failed to connect to lxd-agent
$ lxc exec paride-f-vm uptime
Error: Failed to connect to lxd-agent
$ lxc exec paride-f-vm uptime
Error: Failed to connect to lxd-agent
$ lxc exec paride-f-vm uptime
 10:29:50 up 0 min,  0 users,  load average: 0.00, 0.00, 0.00

# There, it's up! But let's check again:

$ lxc exec paride-f-vm uptime
Error: Failed to connect to lxd-agent

# It's down again :(

$ lxc exec paride-f-vm uptime
Error: Failed to connect to lxd-agent
$ lxc exec paride-f-vm uptime
Error: Failed to connect to lxd-agent
$ lxc exec paride-f-vm uptime
 10:30:02 up 0 min,  0 users,  load average: 0.00, 0.00, 0.00
$ lxc exec paride-f-vm uptime
 10:30:04 up 0 min,  0 users,  load average: 0.08, 0.02, 0.01

# Now it's up for real.

This is not really any different than waiting for networking or cloud init to complete with containers.
Not all VM images will have the agent running either and more importantly, LXD has no idea when the agent is ready.
The agent responding and then going away in your case is most likely because the VM rebooted to do a clean cloud-init run.
I'll take a quick look at that part of the logic as we may be able to prevent the agent from answering in that case.

@stgraber could we add something to the lxc info <vm> command showing that we have an lxd-agent connection?

@stgraber one difference with waiting for network/cloud-init is that in those cases it's easy to wait for them:
lxc exec <container> systemctl is-system-running --wait
# or:
lxc exec <container> cloud-init status --wait

What would you think of a lxc launch --wait flag that makes documented assumptions on the container/vm (like: has systemd, has lxd-agent, ...)

@tomponline we already have that to some extent, PID is -1 until we have an agent.
@paride as I said, LXD has absolutely no idea when the agent is ready and with instances like Windows, MAAS, ... it actually never will be. Having LXD keep poking those instances indefinitely would be a waste of time and resources.
Having to wait for something to respond is a pretty normal thing to do when interacting with virtual machines or the cloud, LXD is far from being unique there.
The main issue here is that the agent was responding and then went away and came back. This is because of the reboot we're doing to workaround cloud-init's lack of native LXD support but we need to fix the agent so that it doesn't actually accept requests on that first startup.


feat(Input): add highlightAutofill prop

FX-2887
Description
Add highlightAutofill property to Input. It is expected to be used only internally by @toptal/picasso-forms, that is why I left out any comment to not have it in storybook docs.
How to test

check storybook
check the naming of new prop

Screenshots

Development checks

[x] Add changeset according to guidelines (if needed)
[x] Read CONTRIBUTING.md and Component API principles
[x] Make sure that additions and changes on design follow Toptal's BASE design, and it's been already discussed with designers at #-base-core
[x] Annotate all props in component with documentation

left out on purpose

[x] Create examples for component
[x] Ensure that deployed demo has expected results and good examples
[x] Ensure the changed/created components have not caused accessibility issues. How to use accessibility plugin in storybook.
[x] Self reviewed
[x] Covered with tests

Breaking change

codemod is created and showcased in the changeset
test alpha package of Picasso in StaffPortal

All development checks should be done and set checked to pass the
GitHub Bot: TODOLess action

PR commands

List of available commands:

@toptal-bot run package:alpha-release - Release alpha version
@toptal-anvil ping reviewers - Ping FX team for review

PR Review Guidelines

When to approve? ✅
You are OK with merging this PR and

You have no extra requests.
You have optional requests.

Add nit: to your comment. (ex. nit: I'd rename this variable from makeCircle to getCircle)

When to request changes? ❌
You are not OK with merging this PR because

Something is broken after the changes.
Acceptance criteria is not reached.
Code is dirty.

When to comment (neither ✅ nor ❌)
You want your comments to be addressed before merging this PR in cases like:

There are leftovers like unnecessary logs, comments, etc.
You have an opinionated comment regarding the code that requires a discussion.
You have questions.

How to handle the comments?

An owner of a comment is the only one who can resolve it.
An owner of a comment must resolve it when it's addressed.
A PR owner must reply with ✅ when a comment is addressed.

@toptal-anvil ping reviewers

@toptal-anvil ping reviewers


UI - Use green screen

A green screen will help give back more space to the overlay

Green screen has been acquired. I've been testing things out and working on the best way to use it with the bulbs still being visible in the stream.


Add a task page for setting up kubeconfig

This is an umbrella issue

What would you like to be added
Add a new task page that explains how to put a kubeconfig in place for accessing a cluster.
Why is this needed
People might set up a PC to authenticate to a cluster that they did not deploy, and would like to learn how.
Comments
We already have:

a reference page
a task page for when you want to access more than one cluster

but we don't have a task page for setting up kubeconfig when you just want to access a single cluster.
We should try to merge a basic task page first, but leave this issue open until that task is thorough and covers details such as impersonation, credential plugins, and kuberc (experimental - see https://github.com/kubernetes/enhancements/blob/master/keps/sig-cli/3104-introduce-kuberc/README.md).
/sig cli
/language en
/kind feature

Related to https://github.com/kubernetes/website/issues/38478

/priority important-longterm
/triage accepted

It seems to me that simply adapting the contents of the existing Configure Access to Multiple Clusters page to configure a single cluster would satisfy this requirement.
What is currently missing in the existing document is the pre-requisite to obtaining the necessary existing cluster information from a cluster administrator. Things like the cluster URL and the client SSL certificate or other necessary access credentials.
It would be useful to include links to the kubectl reference documentation, such as:
kubectl [set-cluster|set-context|set-credentials].
And a link to the kubeadmin reference documentation could also be useful: Generating kubeconfig files for additional users.
What do you think @sftim?

It seems to me that simply adapting the contents of the existing Configure Access to Multiple Clusters page to configure a single cluster would satisfy this requirement.

Sounds good to me.
For certificates, we should try to cover real-life workflows (for example: generate a key locally, get a certificate signed, use that) and not only less secure stories such as: a cluster administrator emails you a certificate and private key.
Replace “emails” with Teams or Slack and it's the same problem. There is a more secure option and we should avoid implying that the bad way is what you do.
It'd be nice to cover credential plugins, too. Those are another good way to set up actually-secure API access.
We can mention that various Kubernetes components also load kubeconfig files.
There are two lots of kubectl documentation; see https://github.com/kubernetes/website/issues/25943
Feel free to borrow from either.

/help

Is this still required? If so, can I assign myself to this issue?

Hi @mariasalcedo, since it's not closed yet, I believe you can.

/assign


FEATURE - Introduce "View All" view to Blogs filters

As a developer looking for specific content in the blogs tab of knowledge hub,
I want to see all of the filters available to me,
so that I can better understand the different topics I can read about
Description
blogs.sap.com has a View all feature that allows users to see all of the tags that exist on the platform. In order to create feature parity with the site and help users understand the wide variety of topics available to them, we should also introduce similar functionality: https://blogs.sap.com/tags/. The tags are searchable and update based on the users current input.
Technical Design
What modules need to be created or enhanced?
How would the functionality be exposed and how can it be consumed?
Acceptance Criteria
GivenWhenThen format (https://martinfowler.com/bliki/GivenWhenThen.html)
Given I have the filter interface open in the Blogs tab ...
when I click the View all button ...
then all of the tags available on blogs.sap.com should be viewable in a pop-up
and I should be able to search for existing tags
and I should be able to select a tag and go back to the blog tab
and then I should be able to click View All again and select another tag in addition if required.
Notes
Tasks

[ ] Create a new tag page -- 2 days
[ ] Update routing for clicking tags -- 2 days
[ ] Unit Tests added -- 2 days
[ ] Test Cases defined

@gpeuc We will need some design for that story

This is present and tested in the latest version. Closing this.


fix: Test fixed by bumping boot version

Fixed test expdecting boot in latest.release (for now) by setting the boot version in expected pom.xml to 3.0.3.
A method exists to retrieve the latest version. A helper should be called there to retrieve the version.

Create a test helper to retrieve the latest version of a given dependency.

Create a test helper to retrieve the latest version of a given dependency


[release-v2.7] Automated cherry pick of #96: upgrade TF provider 1.124.2

/area/open-source
/kind/bug
Cherry pick of #96 on release-v2.7.
#96: upgrade TF provider 1.124.2
Release Notes:
The following terraform provider plugin is updated:
- aliyun/terraform-provider-alicloud: 1.124.0 -> 1.124.2

/invite @vpnachev


add ids to contribution state and query

@richarddubay wasn't able to run through a testing flow on this (having local-environment issues) - but if you're able to confirm this doesn't break giving, I believe this might clear up the connected issue. This is based on the comments in this issue: https://github.com/apollographql/apollo-client/issues/2510
Fixes #676
Creator

[ ] Build relevant tests if any apply
[ ] Ensure there are no new warnings
[ ] Upload an animated GIF showcasing the solution (if it applies)
[ ] Set a relevant reviewer

Reviewer

[ ] Run test and make sure all tests pass
[ ] Review function and form on iOS
[ ] Review function and form on Android
[ ] Review function and form on Web
[ ] Review new test logic

@conrad-vanl Did you pull from alpha before you made this change? It says the branch is out of date, but I wasn't confident I could just click the button. I was able to give a gift and schedule one for tomorrow. Is there some other flow I should be testing? @FrankGrand Do you have any thoughts on how much or what specifically I should test before we attempt to make a build with this?

@richarddubay I accidentally based this off of master instead of alpha, clean merge...it's fine. So I fixed that.

@richarddubay this change is so minor in scope that if we can give a few different ways (on web, on android, on ios using restored checkout), I don't see any issues with releasing it.


Make all strings translatable

(hopefully) all strings are translatable now
app version has to be updated in harbour-...qml
default translations added (not really translated yet)

Thanks! Will test the new versioning system with 0.8.1 in a sec

Works great, thanks a ton!


Add CVE customize notebook

Adding notebook to showcase CVE customization. This is the second notebook users will run after the deploy notebook on brev.dev

Closing in favor of updated PR: #39


Request for support of the Intel(R) Quark SE C1000 microcontroller

Request for support of the Intel(R) Quark SE C1000 microcontroller in ZMRAA.  The D2000 is currently supported so this request would be to add matching support for both cores of the C1000 in ZMRAA and the related samples.

Work on this is ongoing. Pinmapping is ready for the board but needs to be tested with Zephyr 1.6 and some sensor drivers.


Improve parsing of responses from the AI

Summary of the Pull Request
Instead of manually parsing out code blocks from the response we receive, use the cmark library.
Validation Steps Performed
Responses are parsed as expected.
PR Checklist

[ ] Closes #xxx
[ ] Tests added/passed
[ ] Documentation updated

If checked, please file a pull request on our docs repo and link it here: #xxx

[ ] Schema updated (if necessary)

I initially wanted to directly use the RichTextBlock we get from MarkdownToXaml::Convert added in #17585, but because we want to allow the user to click individual code blocks to send it to the shell we cannot just present one RichTextBlock - the palette needs to know which items are code and which items are plaintext

the palette needs to know which items are code and which items are plaintext and present them individually

does it? could we just put all the output in a single speech bubble? i'd rather avoid reimplementing the cmark->xaml parser that mike just wrote if at all possible.

mine had a play button, chat needs a copy. that might make the reuse a little trickier

mine had a play button, chat needs a copy. that might make the reuse a little trickier

Why not both? Having a copy button in your markdown pane seems useful as well. It would also mirror GitHub which also has a copy button on each code block.

Closing this in favour of #18220


Ignore more dirs in flake8 tests

There's additionally venv in .gitignore, maybe that should be added as well? On the other hand, .venv (with a leading dot) is ignored here, but that's not in .gitignore...

Thanks @scop ! I also changed .gitignore to ignore .venv/ instead of venv/ in https://github.com/dbtsai/python-mimeparse/commit/566632cb3591e2fe3371bd446b46f28ea961caf3


Problem when Compiling for non Cmake Build System

I try to compile Diligent for a non Cmake build System (Scons). To test it, i wanted to build the Tutorial00_HelloLinux but with Scons instead of CMake. (Curently I'm working on Linux, but I want to Compile it on Windows too, on a later point)
Therefore i copied the .cpp file to a seperat folder and compiled Diligent as discriped in the Section "Your Project Does Not Use Cmake"
I tryed the following steps:
in the cloned repository (i call the folder DiligentFolder in the rest of this issiue):
cmake -H. -B./cmk_build/Linux64 -G "Unix Makefiles" -DCMAKE_BUILD_TYPE="Debug" -D CMAKE_INSTALL_PREFIX=install
and after than:
cmake --build . --target install
in /cmk_build/Linux64
I than use
'DiligentFolder/DiligentEngine/install/DiligentCore/headers'
as my CPPPATH and
'DiligentFolder/DiligentEngine/install/DiligentCore/lib'
as my LIBPATH
i link against the following librarys:
'libLinuxPlatform', 'GL', 'X11', 'xcb', 'GraphicsEngineOpenGL-static', 'GraphicsEngineVk-static', 'glslang', 'HLSL', 'OGLCompiler', 'OSDependent', 'SPIRVCross', 'SPIRV', 'SPIRV-Tools-opt', 'SPIRV-Tools', 'glew-static', 'vulkan'
I get a lot of errors, but they all are similar to this:
/usr/bin/ld:
DiligentFolder/DiligentEngine/install/DiligentCore/lib/libGraphicsEngineOpenGL-static.a(ShaderResourceBinding
GLImpl.cpp.o): in function `Diligent::RefCountedObject<Diligent::IShaderResourceBindingGL>::GetReferenceCounters() const':
DiligentFolder/DiligentEngine/DiligentCore/Common/interface/RefCountedObjectImpl.h:521: undefined reference to `DebugAsser
tionFailed(char const*, char const*, char const*, int)'

I propably did something wrong when compiling, but I don't know wich command is missing and couldn't find anything in the documentation.

On Linux, the order in which you list libraries is important. Try to move 'libLinuxPlatform', 'GL', 'X11', 'xcb' to the end of the list.
Also, try linking against DiligentCore.lib instead of GraphicsEngineOpenGL-static or GraphicsEngineVk-static because the library has all required dependencies (except for third-party). The easiest way though is to link with dynamic libraries (GraphicsEngineOpenGL-shared or GraphicsEngineVk-shared) as you will not need to sort out dependencies.

there is no DiligentCore.lib in the lib folder.

It should be in install/DiligentCore/lib/libDiligentCore.a.
I checked the log of the last Linux build and the library should be there.

the folder only contains the following files:
libBasicPlatform.a
libCommon.a
libglew-static.a
libglslang.a
libGLSLTools.a
libGraphicsAccessories.a
libGraphicsEngine.a
libGraphicsEngineNextGenBase.a
libGraphicsEngineOpenGL.so
libGraphicsEngineOpenGL-static.a
libGraphicsEngineVk.so
libGraphicsEngineVk-static.a
libGraphicsTools.a
libHLSL2GLSLConverterLib.a
libHLSL.a
libLinuxPlatform.a
libOGLCompiler.a
libOSDependent.a
libPrimitives.a
libSPIRV.a
libSPIRVCross.a
libSPIRV-Tools.a
libSPIRV-Tools-opt.a
are the comands I discribed in my initial post corect or am I missing something?

Yes, these commands seem to be correct. These are commands run by the CI server and here is the library installed by the server.
Does it produce the libDiligentCore.a at all?

no, its not in the folder and I couldn't find it anyware else.


Adapt library to work with Hanami

Coverage increased (+2.3%) to 91.351% when pulling 3ef943e30fb75181751e9ebe199a8b1bde4ccc18 on mjacobus:adapt-to-hanami into e3fd092386d6d9884d33966887666a1fbc37d7cd on watir:master.

Coverage increased (+2.3%) to 91.351% when pulling 3ef943e30fb75181751e9ebe199a8b1bde4ccc18 on mjacobus:adapt-to-hanami into e3fd092386d6d9884d33966887666a1fbc37d7cd on watir:master.

Coverage increased (+2.3%) to 91.351% when pulling 3ef943e30fb75181751e9ebe199a8b1bde4ccc18 on mjacobus:adapt-to-hanami into e3fd092386d6d9884d33966887666a1fbc37d7cd on watir:master.

Coverage increased (+2.3%) to 91.351% when pulling 3ef943e30fb75181751e9ebe199a8b1bde4ccc18 on mjacobus:adapt-to-hanami into e3fd092386d6d9884d33966887666a1fbc37d7cd on watir:master.

Coverage increased (+2.3%) to 91.351% when pulling 3ef943e30fb75181751e9ebe199a8b1bde4ccc18 on mjacobus:adapt-to-hanami into e3fd092386d6d9884d33966887666a1fbc37d7cd on watir:master.

Sorry! I thought i created the PR against my own branch.


[MAIN] Move to Golang version 1.21

What this PR does / why we need it:

See comment: https://github.com/openshift-knative/serving/pull/545#issuecomment-1827650117.
Main upstream has moved to 1.21 and we need the same downstream for release-next and nightly jobs.

@mgencur does this affect downstream builds?

Do we maybe also want to bump all GH-actions:

https://github.com/openshift-knative/serving/blob/main/.github/workflows/vulncheck.yaml#L25
https://github.com/openshift-knative/serving/blob/main/.github/workflows/validate.yaml#L21

@mgencur does this affect downstream builds?

This is for release-next branch only and 1.13+.
cc @dsimansk

Looks good to me. +1 Reto's comment about GH actions.
/lgmt

Thinking of this again I will update the actions here.

In the functions repo. I've tried moved the Go version to a single composite config. We could do that from our openshift-knative/hack and share from there probably.  A next iteration improvement perhaps.
https://github.com/knative/func/blob/main/.github/composite/go-setup/action.yaml

@mgencur does this affect downstream builds?

I think it should NOT affect downstream builds. But at some points we should also update it here: https://github.com/openshift-knative/serving/blob/main/.github/workflows/multiarch-build.yaml#L9
And set the version like:
jobs:
  multiarch-build:
    uses: openshift-knative/hack/.github/workflows/multiarch-build.yaml@main
    secrets: inherit
    with:
      goversion: '1.21.x'

We use the action to build test images for P/Z team.

@mgencur @ReToCode the multi-arch job is fixed.

/unhold
Thanks for the fix for multiarch.

/lgtm


Click the "adopt" botton can't connect the transaction of wallet

Reason:
Today, I do a test about how to create dapp named pet-shop-box follow the offcial tutorial . I am following the tutorial is here:http://truffleframework.com/tutorials/pet-shop.The issue is occuring after I operate until the commend npm run dev,html is occur,but when I click the "adopt" button ,the terminal and web happen nothing,and when I run npm run dev,the terminal is show the 304.
System:
OS: ubuntu-14.04
Truffle v4.0.3 (core: 4.0.3)
Solidity v0.4.18 (solc-js)
Experiment
The First step:
the code of truffle.js as fellow:
module.exports = {     // See <http://truffleframework.com/docs/advanced/configuration>     // for more about customizing your Truffle configuration!     networks: {       development: {         host: "localhost:",         port: 8545,         network_id: "*" // Match any network id       }     }   };
the commend to launch ganache-cli as fellow:testrpc
the current RPC of MetaMask as fellow:http://localhost:8545
The Second step:
the code of truffle.js as fellow:
module.exports = {     // See <http://truffleframework.com/docs/advanced/configuration>     // for more about customizing your Truffle configuration!     networks: {       development: {         host: "localhost:",         port: 9545,         network_id: "*" // Match any network id       }     }   };
the commend to launch ganache-cli as fellow:truffle develop
the current RPC of MetaMask as fellow:http://localhost:9545
I have try the another port such 7545 and the host linke'<IP_ADDRESS>:port',but the issue still take place.And the develop tool of chorme is normal and no issue is remindered. But I type to console.log() in the app.js and observe the initcontract() is not work .So I don't know where the I should modify for this project?
The picture of terminal is here:

The picture of web is here:

in the src/js/app.js file markAdopted function, please try this instead of hard coded adopter address.
if (parseInt(adopters[i], 16) < 1) {
     $('.panel-pet').eq(i).find('button').text('Success').attr('disabled', true);
}

Hi! @masanggil1986 .It's isn't useful for me follow your tutorial.Nothing changed .

It worked when i changed the below snippet
if (parseInt(adopters[i], 16) < 1) {
$('.panel-pet').eq(i).find('button').text('Success').attr('disabled', true);
}
to
if (parseInt(adopters[i]) > 1) {
$('.panel-pet').eq(i).find('button').text('Success').attr('disabled', true);

Hi, I have followed all the pet -shop tutorial.
Instead to use Ganache I have used "truffle develop".
In the web3 code I inserted
App.web3Provider = new web3.providers.HttpProvider('http://<IP_ADDRESS>:9545');
In MetaMask, I entered int the "New RPC URL" field the address "http://<IP_ADDRESS>:9545"
The adopt button doesn't work.
Would you please help me.
thanks
@ri2rajsingh in which file there is the code you changed?

304 is non modified error. Can you hard reload the page by emptying the cache.
This trick worked for me

Has anyone been able to fix this issue? Can't find any solutions.


[Docs]: fixed mistakes, removed [&]

I see some examples use [&] and the advanced reference says that it's better not to use it. So I don't think we should do it in the examples. Also, there were punctuation mistakes in those files, fixed those.

[X] My pull request is made against the dev branch.
[X] I have ensured that the changed library can be built on your target system. I did not introduce any platform-specific code.
[X] I have ensured that all methods and functions are fully documented using doxygen style comments.
[X] I tested my commits, by adding a test case to the unit tests if needed
[X] I have ensured that I did not break any existing API calls.
[X] My code follows the coding style guide (if you are not sure, match the code style of existing files including indent style etc).
[X] I have not built my pull request using AI, a static analysis tool or similar without any human oversight. Where I have generated this pull request using a tool, I have justified why this is needed.

I would advise that you move your future PRs into a separate branch.

But if I do so, some files will be missing and I'll request pull without needed/non-up-to-date files, no?

you can create new branch which will be copy of current dev branch and use git cherry-pick (more detailed here)

But if I do so, some files will be missing and I'll request pull without needed/non-up-to-date files, no?

No. If you make your branch from dev, you'll be okay. Even if you don't, if you only commit your files, only they get seen by GitHub.

you can create new branch which will be copy of current dev branch and use git cherry-pick (more detailed here)

You don't need git cherry-pick. Just do git checkout -b branch-name dev

But if I do so, some files will be missing and I'll request pull without needed/non-up-to-date files, no?

No. If you make your branch from dev, you'll be okay. Even if you don't, if you only commit your files, only they get seen by GitHub.

So if I copy it to my own branch and commit files that I need to only, I'll be fine and I won't have to keep pulling/re-cloning?

So if I copy it to my own branch and commit files that I need to only, I'll be fine and I won't have to keep pulling/re-cloning?

Exactly. This means you just do what you want on your branch and once the PR is merged, you delete the branch. You should still keep pulling dev though, to make sure that's up-to-date.

Exactly. This means you just do what you want on your branch and once the PR is merged, you delete the branch. You should still keep pulling dev though, to make sure that's up-to-date.

So, I "copy" the branch, do stuff and when it's merged, delete it and do it over again?

Exactly. This means you just do what you want on your branch and once the PR is merged, you delete the branch. You should still keep pulling dev though, to make sure that's up-to-date.

So, I "copy" the branch, do stuff and when it's merged, delete it and do it over again?

Yup. If you feel like you need more information about this, I can look to make a tutorial for this.

Yup. If you feel like you need more information about this, I can look to make a tutorial for this.

I guess I'll just keep on learning the power of Googling.


Remove reduce(final U identity, final BiFunction<U, ? super T, U> accumulator)

Duplicate of foldLeft(final U identity, final BiFunction<U, ? super T, U> accumulator)

Remove reduce methods entirely on Folds (leave on ReactiveSeq for backwards compatibility with Stream).

Merged.


Schema curation custom component

This project applies Python user code to a schema which is produced by SchemaGen, in order to curate the schema based on domain knowledge.  For example, if the range of a numeric feature is actually greater than what SchemaGen infers, then the range in the schema can be adjusted.  Or if there are valid categorical values that are not included in the inferred schema, they can be added.  This will include a user-supplied module file which contains the user code for curating the schema.  The user code will likely make heavy use of the TFDV library.


New release with smallvec 1.0?

Can we get a new release with #188?

This is a breaking change. So we should see if there is anything else valuable in the pipeline to merged/do first. We are currently working on adding more tests to various aspects of this crate. Would be nice to get that done first. In case the tests show any issues, it would be nice to have them fixed before a new major release.
And I see we have some documentation to update. For example, Mutex and Once is now 1 byte even on stable. It has been for a while, but the docs don't reflect that.

I think the ecosystem is slowly moving to smallvec 1.0 so we should perhaps cut this release as soon as we can.

Ok. Some tests are merged and no problems found so far. Unless @Amanieu has some other plans, maybe we can try publishing a release this weekend.

parking_lot 0.10.0 along with parking_lot_core 0.7.0 and lock_api 0.3.2 has been published! Closing this.

Thank you!


Demo: Add sample code for Bootstrap 4 usage

Ref #2131.
Simple page showing how to use jquery-validation with Bootstrap 4.

@Arkni - I just uploaded code with your suggestions - thank you!
I didn't add Bootstrap 3 style feedback icons to the sample. Bs3 used Glyph icons to do this, which are not in Bs4.
From https://www.quackit.com/bootstrap/bootstrap_4/differences_between_bootstrap_3_and_bootstrap_4.cfm

Validation styles are not available for Bootstrap 4 forms. Use custom Bootstrap form validation messages instead.

I applied the changes you pushed (found in branch patch-2 in your fork) manually and pushed them to the branch patch-1, because when you update the file using GitHub interface, it creates a new branch for each update, that's why I didn't see the changes here.
Thanks a lot for your contribution :)


Adding podTag as free podcasts for pt_BR

What does this PR do?
Add Resource
For resources
Description
podTag is a podcast with 4 hosts including Software Engineer, Scrum master, CTO and Community manager. They discuss several subjects about technology, programming, experiences in daily life or interviewing a guest.
Why is this valuable (or not)
The episodes content is not only technical. The podTag hosts interview many people that has a lot of experiences with soft skills, culture in other countries, and more. And it's separated by lists/context/subjects.
How do we know it's really free?
All the episodes are free to listen
For book lists, is it a book?
No
Checklist:

[x] Not a duplicate
[x] Included author(s) if appropriate
[x] Lists are in alphabetical order
[x] Needed indications added (PDF, access notes, under construction)

Thanks, and welcome to free-programming-books!


RequestException: 403

Hello,
I tried the standard script provided in the example and I received the following error:
python .\sec_edgar_scrapper.py
cik for AAPL is 320193
getting ['10-Q', '10-Q/A'] filing info from https://www.sec.gov/Archives/edgar/full-index/2016/QTR1/master.idx
Traceback (most recent call last):
  File ".\sec_edgar_scrapper.py", line 9, in <module>
    filing = stock.get_filing(period, year, quarter)
  File "D:\Programming\Stonks\sec-edgar-financials-master\edgar\stock.py", line 34, in get_filing
    filing_info_list = get_financial_filing_info(period=period, cik=self.cik, year=year, quarter=quarter)
  File "D:\Programming\Stonks\sec-edgar-financials-master\edgar\edgar.py", line 277, in get_financial_filing_info
    return get_filing_info(cik=cik, forms=forms, year=year, quarter=quarter)
  File "D:\Programming\Stonks\sec-edgar-financials-master\edgar\edgar.py", line 165, in get_filing_info
    return _get_filing_info(cik=cik, forms=forms, year=year_str, quarter=quarter_str)
  File "D:\Programming\Stonks\sec-edgar-financials-master\edgar\edgar.py", line 215, in _get_filing_info
    response = GetRequest(url).response
  File "D:\Programming\Stonks\sec-edgar-financials-master\edgar\requests_wrapper.py", line 8, in __init__
    raise RequestException('{}: {}'.format(response.status_code, response.text))
edgar.requests_wrapper.RequestException: 403: <!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">

<meta http-equiv="Content-Type" content="text/html; charset=UTF-8" />
<title>SEC.gov | Request Rate Threshold Exceeded</title>

Your Request Originates from an Undeclared Automated Tool

To allow for equitable access to all users, SEC reserves the right to limit requests originating from undeclared automated tools. Your request has been identified as part of a network of automated tools outside of the acceptable policy and will be managed until action is taken to declare your traffic.

Please declare your traffic by updating your user agent to include company specific information.

My code is the following:
from edgar.stock import Stock

stock = Stock('AAPL')

period = 'quarterly' # or 'annual', which is the default
year = 2016 # can use default of 0 to get the latest
quarter = 1 # 1, 2, 3, 4, or default value of 0 to get the latest
# using defaults to get the latest annual, can simplify to stock.get_filing()
filing = stock.get_filing(period, year, quarter)

# financial reports (contain data for multiple years)
# income_statements = filing.get_income_statements()
# balance_sheets = filing.get_balance_sheets()
cash_flows = filing.get_cash_flows()
print(cash_flows)

Anyone else encountered this?
They say maximum 10 requests per second, is the provided script doing more?

from edgar.stock import Stock
import requests

original_get = requests.get

def get_with_user_agent(*args, **kwargs):
    if 'headers' not in kwargs:
        kwargs['headers'] = {}
    kwargs['headers']['User-Agent'] = 'Your-name app-name your-email'
    return original_get(*args, **kwargs)

requests.get = get_with_user_agent

stock = Stock('AAPL')

period = 'quarterly' # or 'annual', which is the default
year = 2016 # can use default of 0 to get the latest
quarter = 1 # 1, 2, 3, 4, or default value of 0 to get the latest
# using defaults to get the latest annual, can simplify to stock.get_filing()
filing = stock.get_filing(period, year, quarter)

# financial reports (contain data for multiple years)
# income_statements = filing.get_income_statements()
# balance_sheets = filing.get_balance_sheets()
cash_flows = filing.get_cash_flows()
print(cash_flows)

Hope this helps

Thanks a lot, it worked.


bug: The Java spotless CI code should reformat code to indent 4 spaces rather than 8

From a recent PR code review:
This is a bug in spotless for services (the original directive was miscommunicated repeatedly) that we should not, in my opinion, replicate.
continuation_indent should be 4, not 8.
The intent for services was to be 4 base and 4 more for continuation, but that was communicated as 8 total and translated to spotless as 8 more.

@jsync-swirlds  fixed this issue with commit d8292475


In the CodeGenerated demo, pathfinding is jerky

Terrain3D version
v0.9.2-dev
System information
Godot v4.2.2.stable - Windows 10.0.19045 - Vulkan (Forward+) - dedicated Radeon RX 560 Series (Advanced Micro Devices, Inc.; 31.0.14001.45012) - Intel(R) Core(TM) i5-4570 CPU @ 3.20GHz (4 Threads)
Is the issue reproducable in the demo?
Yes
Issue description
When I started the CodeGenerated.tscn demo, the agent’s path search was intermittent with long delays, there were times when the agent stood next to me and for about 6 seconds could not find the path to me
https://github.com/TokisanGames/Terrain3D/assets/130399274/418d7c81-55e4-4728-9baa-b0a35c28b16e
Logs
Empty

There are a few reasons for this, but it's not a bug. It's a lot clearer why it happens if you make navigation visible:

https://github.com/TokisanGames/Terrain3D/assets/165720/d1867aca-105f-45ea-9171-cde7d0e39bb9
The blue mesh that covers the ground is the navigation mesh. The RuntimeNavigationBaker script periodically rebakes this on a thread. You can adjust the "bake cooldown" on the baker to do this more frequently, but you'll still run into the fact that baking navigation is just slow. This is why editor/compile-time baking navigation is usually a better option for games (where that can be done).
However, runtime baking can still be usable. There are a few things you can do to speed it up, or work around the slowness:

You can create a set of fallback behaviors that get used when proper navigation isn't possible. In this way, you can make AI degrade when waiting for nav, or out of range of the nav mesh, without completely failing. This approach comes with its own drawbacks and limitations, and how you go about it depends on what's acceptable for your project. In my own project, agents bee-line when off-mesh. This works fine for me.
You can reduce the speed of the player character. Delays happen frequently in the demo because the player can move across the mesh so rapidly.
You can reduce the size of the baked mesh to make it cheaper to bake (mesh_size).
You can increase the size of the cells (i.e. reduce the resolution of the navmesh), defined in the NavigationMesh template (cell_size), to reduce the amount of work to do. But note that if you increase it too far, obstacles may hide within a cell and break your navigation. You can write fallback behaviors for that, or you can ensure your obstacles are all larger than the cell size.

A second, smaller delay is due to how frequently the navigation agent updates its path. You can do this more frequently by adjusting the RETARGET_COOLDOWN constant (currently 1.0 seconds), but if you have a lot of agents that's going to come with a performance cost.

Thanks, I think this should be mentioned somewhere in the documentation

@tcoxon Thanks for looking at it and providing the explanation.
Docs updated in https://github.com/TokisanGames/Terrain3D/commit/15ff7e5b89dfc58fd6d9336924679a6780ef111e


Error while Installing Voyager

I am getting database migration error while using the  "php artisan voyager:install --with-dummy" command

Pratik@Pratikbhai MINGW64 /d/Pratik/Work/project ultron/ultron_admin/voyager
$ php artisan voyager:install --with-dummy
Publishing the Voyager assets, database, and config files
Copied Directory [\vendor\tcg\voyager\publishable\database\seeds] To [\database\seeds]
Publishing complete.
Publishing complete.
Migrating the database tables into your application
Migrating: 2017_01_14_005015_create_translations_table
Illuminate\Database\QueryException  : SQLSTATE[42S01]: Base table or view already exists: 1050 Table 'translations' already exists (SQL: create table translations (id int unsigned not n
ull auto_increment primary key, table_name varchar(191) not null, column_name varchar(191) not null, foreign_key int unsigned not null, locale varchar(191) not null, value text not n
ull, created_at timestamp null, updated_at timestamp null) default character set utf8mb4 collate 'utf8mb4_unicode_ci')
at D:\Pratik\Work\project ultron\ultron_admin\voyager\vendor\laravel\framework\src\Illuminate\Database\Connection.php:664
660|         // If an exception occurs when attempting to run a query, we'll format the error
661|         // message to include the bindings with SQL, which will make this exception a
662|         // lot more helpful to the developer instead of just the database's errors.
663|         catch (Exception $e) {

664|             throw new QueryException(
665|                 $query, $this->prepareBindings($bindings), $e
666|             );
667|         }
668|

Exception trace:
1   Doctrine\DBAL\Driver\PDOException::("SQLSTATE[42S01]: Base table or view already exists: 1050 Table 'translations' already exists")
D:\Pratik\Work\project ultron\ultron_admin\voyager\vendor\doctrine\dbal\lib\Doctrine\DBAL\Driver\PDOStatement.php:119
2   PDOException::("SQLSTATE[42S01]: Base table or view already exists: 1050 Table 'translations' already exists")
D:\Pratik\Work\project ultron\ultron_admin\voyager\vendor\doctrine\dbal\lib\Doctrine\DBAL\Driver\PDOStatement.php:117
Please use the argument -v to see more details.
I got this error after editing AppServiceProvider.php file with this below code
Illuminate\Support\Facades\Schema;
and
public function boot()
{
Schema::defaultStringLength(191);
}

Hi @sutharpratik10
Closing as it looks like you've submitted this to the wrong repo. This is related specifically to Voyager not the voyager-frontend repo.


Multiple log file directories

I noticed in the README that the documentation specified multiple sources can be specified.
sources:
  - path: hello.txt
    tag: hello

however this does not seems to work, based on the code it looks like the only config option that it allows is source_dir https://github.com/concourse/blackbox/blob/master/config.go#L44
there is this https://github.com/concourse/blackbox/blob/fd8a846251368fbe293f6356192082f138951270/config.go#L37-L40
but it does not seems to be used and the config does not get unmarshalled into it.
is this just a typo or am I missing something? I would like to be able to read logs from multiple directories rather than just one recursively.

Hi @warroyo, we updated README with accurate configuration. Thanks for pointing to this issue.


Impossibility to provide "Custom SQL" for Crate.io source

While configure Crate.io data source using ZoomData dialog, there is no option to specify "Custom SQL".
Steps to reproduce:

Create Connector server (according to video)
Create Connection type (according to video)
Configure data source in ZoomData
On "Tables" tab - there is no option "Custom SQL"

Custom SQL option available for other source (e.g. Impala)

@Delicate-aRt suggest we close this issue for now. CrateDB has basically no support of subqueries. Although more is coming in 0.56, I don't think it will be enough for Zoomdata to consider this feature supported.

@Delicate-aRt and @bowenwr thanks for the feedback. right now we support only SUBSELECTs that can be solved on parser level -> meaning basically being rewritten / appended to the WHERE clause. that might be sufficient for some of the CUSTOM SQL cases.
full SUBSELECT support is very high on our roadmap. we'll update this issue once we start working and finish them :)

@jodok Thanks for the update! It would be great to be able to provide custom SQL in this example once Crate has adequate support.

@jodok After the upgrade, I ran some tests and all the integration tests pass for custom SQL except for those involving both LIMIT and ORDER BY. A query such as the following is ordering randomly for each request and not deterministically:
select ds.string_full as string_full
from (select * from integration_tests.connector_test) as ds
where not (ds.string_full = 'Accessories Computers' or ds.string_full is null)
group by string_full
order by string_full asc
limit 5

I'm seeing the 5 records in a different order each time. This is on Crate 1.0.1.

Per https://github.com/crate/crate/issues/4673 this should be revisited once 1.0.3 is released.

This has been completed since Crate 1.0.3 has been out.


Add String#center method

String#center(width, char) returns a new string of length width with original string centered, and padded with char (default = space)

This continues the previous PR #3924 (stalled).

Thank you!


[ARCTIC-1382]Improve unit test codes in module Hive

Why are the changes needed?

As described in #1382, we need to improve the unit test codes in module Hive.
This PR attempts to replace the existing unit tests under the Hive module with a new unit testing framework, however, the test coverage of the module still falls short of the target of 90%.
Subsequent PRs will further improve the unit test coverage of the module.
Brief change log

Replace the existing unit tests under the Hive module with a new unit testing framework
Add ArcticTableUtil in module core
Make GenericTaskWriters build writer for unkeyed table
Fix BaicKeyedTableScan cannot filter expression bug

How was this patch tested?

[x] Add some test cases that check the changes thoroughly including negative and positive cases if possible

[ ] Add screenshots for manual tests if appropriate

[x] Run test locally before making a pull request

Documentation

Does this pull request introduces a new feature? (yes / no)
If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

LGTM


Add 'async' to ES6/7 keywords

You already added 'await' keyword, but it is actually used with 'async' one in function declaration by ES7 draft specification.

Thanks, merged!

Thank you! ;)


Space separated attributes are not supported

They are supported by jade and used in the wild. They were recently documented (see https://github.com/jadejs/jade/commit/9cc207fedd64326a3147d4d91b2c3ff98792c151)

Added your attribute Test to current Version 1.0.0 and it is working.


refactor: enhance config override at compile time.

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

[x] N
[ ] Y

refactor: enhance config override at compile time when the attribute operator is the override operator =.

kclvm/sema/src/pre_process/config.rs

2. What is the scope of this PR (e.g. component or file name):

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

[ ] Affects user behaviors
[ ] Contains syntax changes
[ ] Contains variable changes
[ ] Contains experimental features
[ ] Performance regression: Consumes more CPU
[ ] Performance regression: Consumes more Memory
[x] Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

[x] N
[ ] Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

[x] Unit test
[ ] Integration test
[ ] Benchmark (add benchmark stats below)
[ ] Manual test (add detailed scripts or steps below)
[ ] Other

kclvm/sema/src/pre_process/tests.rs

6. Release note

Please refer to Release Notes Language Style Guide to write a quality release note.
None

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

26 of 34 (76.47%)  changed or added relevant lines in 2 files are covered.
222 unchanged lines in 7 files lost coverage.
Overall coverage decreased (-0.5%) to 57.987%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

kclvm/sema/src/pre_process/tests.rs
19
27
70.37%

Files with Coverage Reduction
New Missed Lines
%

kclvm/parser/src/lexer/indent.rs
4
78.31%

kclvm/parser/src/lexer/mod.rs
4
80.78%

kclvm/ast/src/token_stream.rs
6
78.57%

kclvm/sema/src/ty/mod.rs
35
66.02%

kclvm/3rdparty/rustc_span/src/analyze_source_file.rs
48
75.26%

kclvm/parser/src/lib.rs
54
83.44%

kclvm/sema/src/resolver/scope.rs
71
60.56%

Totals

Change from base Build<PHONE_NUMBER>:
-0.5%

Covered Lines:
20404

Relevant Lines:
35187

💛  - Coveralls


SFT阶段的数据集会开源吗？

Please check the report of InternLM-XComposer2-4KHD: A Pioneering Large Vision-Language Model
Handling Resolutions from 336 Pixels to 4K HD for dataset details https://arxiv.org/pdf/2404.06512.pdf


Embedded wallet MVP

The Chore
Initial super MVP version of embedded wallet.
Tasks

[ ] Move the entire wallet as is into Console
[ ] Shove it in the top right ... literally just do this

Additional details / background info

Previous PR did not close the issue, this was a mistake


test sendSubscribeForSpotsRequest

Why did you remove the library?

"tls": "0.0.1"
Is it ok?

I've removed TLS library because there is https://nodejs.org/api/tls.html.


Integration Test - Release - 2019/10/11 19:56:56

Auto create for integration test. IssueCommandFlow

@PRMergerTest3 : Thanks for your contribution! The author(s) have been notified to review your proposed change.


Health checks are not able to see newly created DNS resources

Hi there,
Thank you for opening an issue. Please note that we try to keep the Terraform issue tracker reserved for bug reports and feature requests. For general usage questions, please see: https://www.terraform.io/community.html.
Terraform Version
0.12.28
Affected Resource(s)
Please list the resources as a list, for example:
cloudflare_record
cloudflare_healthcheck
If this issue appears to affect multiple resources, it may be an issue with Terraform's core, so please mention this.
Expected Behavior
If I create a DNS record, and then want to create a health check for that site, it should create fine
Actual Behavior
module.www-dns.cloudflare_record.record: Creating...
module.www-dns.cloudflare_record.record: Creation complete after 1s [id=056f8d5ef3f06a9a2ce4c0ed1299f15f]
module.www-dns.cloudflare_healthcheck.health_check: Creating...
Error: error creating standalone healthcheck: error from makeRequest: HTTP status 400: content "{\n  "result": null,\n  "success": false,\n  "errors": [\n    {\n      "code": 1002,\n      "message": "lookup www.mysite.com on <IP_ADDRESS>:53: no such host"\n    }\n  ],\n  "messages": []\n}\n"
Steps to Reproduce
Please list the steps required to reproduce the issue, for example:
resource "cloudflare_record" "record" {
zone_id = lookup(data.cloudflare_zones.zone.zones[0], "id")
name    = var.name
value   = var.value
type    = var.type
proxied = var.proxy_enabled
}
resource "cloudflare_healthcheck" "health_check" {
zone_id                      = lookup(data.cloudflare_zones.zone.zones[0], "id")
name                         = "${var.env}-${var.name}"
description                  = var.description
address                      = cloudflare_record.record.hostname
suspended                    = false
check_regions                = ["WNAM","ENAM"]
notification_suspended       = false
notification_email_addresses =<EMAIL_ADDRESS>type                         = "HTTPS"
port                         = "443"
method                       = "GET"
path                         = "/"
expected_codes               = ["2xx"]
follow_redirects             = true
allow_insecure               = false
timeout                      = 10
retries                      = 2
interval                     = 60
consecutive_fails            = 3
consecutive_successes        = 2
}

Do you get the same issue if you wait a minute before applying the healthcheck to allow any DNS changes to propagate through Cloudflare's systems?

No, but there is no syntax you can use in Terraform to force a wait.
On Sun, Sep 6, 2020 at 5:35 PM Jacob Bednarz<EMAIL_ADDRESS>wrote:

Do you get the same issue if you wait a minute before applying the
healthcheck to allow any DNS changes to propagate through Cloudflare's
systems?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/cloudflare/terraform-provider-cloudflare/issues/786#issuecomment-687920899,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AEFFTWQ4FU3TRCGFDBDYCFTSEQFEXANCNFSM4Q5AH37Q
.

Maybe it would be possible to build some automatic retries into the
provider? It doesn't seem to take too long to propagate.
On Sun, Sep 6, 2020 at 5:46 PM Ian Binder<EMAIL_ADDRESS>wrote:

No, but there is no syntax you can use in Terraform to force a wait.
On Sun, Sep 6, 2020 at 5:35 PM Jacob Bednarz<EMAIL_ADDRESS>wrote:

Do you get the same issue if you wait a minute before applying the
healthcheck to allow any DNS changes to propagate through Cloudflare's
systems?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/cloudflare/terraform-provider-cloudflare/issues/786#issuecomment-687920899,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AEFFTWQ4FU3TRCGFDBDYCFTSEQFEXANCNFSM4Q5AH37Q
.

Thanks for confirming. As I'm sure you're aware at this point, the issue is that the dependant DNS system hadn't yet propagated the change and the healthcheck backend is failing to perform the lookup. I'm hesitant to retry on the exception provided ("no such host") as it's also possible the configuration is bad and by retrying, you end up with a longer feedback loop. As it boils down to DNS lookups, I'm unsure if we can catch only the cases where the record is propagating but exists compared to a busted configuration. My advice, for now, would be to create them in separate applys and we can evaluate if this is a common issue and spend some more time on investigating other avenues of handling this scenario.

Separate applies are cool and all, but I was trying to make a template for
my team who has no idea how to set these up that does everything in one
place. Every time we create a record, I create the corresponding health
check. There is a lot of utility in that. It's a shame this is just getting
closed out.
On Sun, Sep 6, 2020 at 6:28 PM Jacob Bednarz<EMAIL_ADDRESS>wrote:

Closed #786
https://github.com/cloudflare/terraform-provider-cloudflare/issues/786.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/cloudflare/terraform-provider-cloudflare/issues/786#event-3734655460,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AEFFTWWXSFHOAHNR3VPHYFLSEQLKHANCNFSM4Q5AH37Q
.

There is a lot of utility in that. It's a shame this is just getting closed out.

In this project, a closed issue isn't the end of the conversation. It merely means there isn't any further action required. Issues are also lightweight enough that we can continue the discussion and if there is new information or another approach suggested, we can reopen. It's far from a set and never change again status.
While I agree it's a pain, you seem to be ignoring the other side of this request. If someone does manage to input an incorrect hostname and we retry, it takes the feedback cycle from ~ 1s to 30s. That is a significant workflow change and something we cannot take lightly given that we don't have insight into how everyone is using this resource.
I've put together #789 which adds the functionality and I'll ping a few others users of this provider to see whether it's something we can evaluate.


sentry.options.traces_sample_rate- is not configurable with dotenv vars

Environment
How do you use Sentry?
Sentry SaaS (sentry.io)
Which SDK and version?
sentry-symfony: 4.2.4
Steps to Reproduce
Consider following configurations...
sentry.yaml #1
parameters:
    env(SENTRY_TRACE_SAMPLE_RATE): 0

sentry:
    options:
        traces_sample_rate: '%env(SENTRY_TRACE_SAMPLE_RATE)%'

Expected Result
Traces sample rate is set to 0.
Actual Result
❯ ./bin/console

In BaseNode.php line 545:

  Invalid type for path "sentry.options.traces_sample_rate". Expected "float", but got "int".
  Hint: The sampling factor to apply to transactions. A value of 0 will deny sending any transaction, and a value of 1 will send all transactions.

sentry.yaml #2
parameters:
    env(SENTRY_TRACE_SAMPLE_RATE): 0.1

sentry:
    options:
        traces_sample_rate: '%env(SENTRY_TRACE_SAMPLE_RATE)%'

Expected Result
Traces sample rate is set to 0.1.
Actual Result
❯ ./bin/console

In OptionsResolver.php line 938:

  The option "traces_sample_rate" with value "0.1" is expected to be of type "int" or "float", but is of type "string".

My bad, found a solution just by adding float:, f.e. '%env(float:SENTRY_TRACE_SAMPLE_RATE)%'


Fix deprecation by using Guard instead of SimplePreAuthenticatorInterface

Resolve the following deprecation :
The "Gesdinet\JWTRefreshTokenBundle\Security\Authenticator\RefreshTokenAuthenticatorBase" class implements "Symfony\Component\Security\Http\Authentication\SimplePreAuthenticatorInterface" that is deprecated since Symfony 4.2, use Guard instead.

@Mapsred there are still some errors with code style

Nice work @Mapsred, but it breaks some method signatures then I'm going to merge it and release it in v0.7 version. thanks!


Using the video last generated by mediapipe holistic, how to extract the video with only lines instead of the original person?

Please make sure that this is a Tasks issue.
System information (Please provide as much relevant information as possible)

Have I written custom code (as opposed to using a stock example script provided in MediaPipe):
OS Platform and Distribution (e.g., Linux Ubuntu 16.04, Android 11, iOS 14.4):
MediaPipe Tasks SDK version:
Task name (e.g. Object detection, Gesture recognition etc.):
Programming Language and version ( e.g. C++, Python, Java):

Describe the expected behavior:
Standalone code you may have used to try to get what you need :
If there is a problem, provide a reproducible test case that is the bare minimum necessary to generate the problem. If possible, please share a link to Colab, GitHub repo link or anything that we can use to reproduce the problem:
Other info / Complete Logs :
Include any logs or source code that would be helpful to
diagnose the problem. If including tracebacks, please include the full
traceback. Large logs and files should be attached:

Hi @zjkafasf,
Would you let us know the platform you are referring such as Python, Javascript or other solution available and elaborate the query in the more details?

Closing this issue as Duplicate of #3997. Please follow the another issue raised.


Sphinx documentation that converts markdown using recommonmark

@minrk Here's a first pass at using recommonmark to convert the markdown within Sphinx. There were some new updates on the rtd side for both recommonmark and commonmark.py today.
Highlights:

doc-requirements.txt for now pins recommonmark
conf.py adds a source parser section that uses recommonmark
moved all docs into docs directory

@minrk I'm not sure commit 2815f722505c35eedea3b76c704ef238eb48f317 is needed. It did get Travis to pass the tests on Python 3.3.

Nice !
Just note that for readthedocs you can also just make documentation using mkdocs

@minrk If you like this, please merge since I don't have write access on the PR.
@Carreau It looks as if readthedocs is leaning more toward recommonmark over mkdocs these days. Let's use recommonmark for now. We can always use mkdocs down the road if needed.

Merged, thanks!

Thanks @minrk. If you can grant me admin privileges on this repo, I can set up the RTD service in the Webhooks and Settings tab. Or if you feel more comfortable, I can ping you to add the setting once I have the RTD site set up.

@minrk If you could add me as an admin on the RTD project (https://readthedocs.org/projects/jupyterhub/), I would appreciate it :sunflower:

@minrk If you could add me as an admin on the RTD project (https://readthedocs.org/projects/jupyterhub/), I would appreciate it

Done.

@Carreau Thanks :sunny:


Codegen: dependency iteration limit

Currently running into the iteration limit for codegen:
ERROR roslibrust_codegen: Unable to resolve dependencies after reaching iteration limit (2048)

Would it be reasonable to have a feature flag to disable the limit or some other way to specify the limit?

Hey Nathan, I'll probably take some time to improve the error message right away, because it is highly likely you have a different problem then that message actually points you at.
That iteration limit would only be hit if you had a scenario where:
Message A Needs -> Message B Needs -> Message C ........... All the way to Message XXXZZX or whatever. You would have to have a dependency chain more that 2048 message long.
Instead what is likely going on here is that you pointed the codegen at some directories where it found messages that referenced other messages in other packages, but those packages weren't found in any of its search paths.
That message should really say something like:
"After reaching the maximum iteration limit for resolving dependencies failed to find message definition for {missing_message} which is needed by {message_with_dependency}, consider adding the path for the package containing that message to your search paths, or to the ROS_PACKAGE_PATH environment variable"
I'm actually doing an overhaul of the error messages produced by codegen at the moment, and will work on that shortly!

PR #127 is up and significantly improves this error message into something like:

@NathanSWard v0.8 of roslibrust, roslibrust_codegen, and roslibrust_codegen_macro were released moments ago.
Would be very curious to see what errors you get if you re-attempt what you were trying to do with those versions.

Thanks @Carter12s !
I'll give it a spin this weekend and get back to you on if this helped with the errors messages!
Appreciate the quick turn around :D


all: replace min/max helpers with min/max builtins

Closes https://github.com/gonum/gonum/issues/1904.
We support minimum Go 1.21 since v0.15.0 (https://github.com/gonum/gonum/pull/1935).
Please take a look.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 72.35%. Comparing base (8a2036b) to head (7328ab2).

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1965      +/-   ##
==========================================
- Coverage   72.38%   72.35%   -0.03%
==========================================
  Files         556      556
  Lines       65134    65056      -78
==========================================
- Hits        47147    47074      -73
+ Misses      15385    15381       -4
+ Partials     2602     2601       -1

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


add decurved and ssflow

Thanks for this helpful repository. These works may be related to this repository.

thanks!


How to properly create tests for Mapings.

I have a Asp .net core api with the following configured in startup.cs in order to load all my mapping
        // Mapster configuration
        var typeAdapterConfig = new TypeAdapterConfig();
        // scans the assembly and gets the IRegister
        var mappingRegistrations = TypeAdapterConfig.GlobalSettings.Scan(Assembly.GetExecutingAssembly());
        // adds the registration to the TypeAdapterConfig
        mappingRegistrations.ToList().ForEach(register => register.Register(typeAdapterConfig));
        // register the mapper as Singleton service for my application
        var mapperConfig = new Mapper(typeAdapterConfig);
        services.AddSingleton<IMapper>(mapperConfig);

Then I have created a test project where I have created a lot of tests for each of the mappings.  An example of one of them can below.  In the constructor I have been loading the start up from the API project so that I grab all the mappings.
 public class ConditionMapingTests
    {
        private readonly TestServer _server;
        private readonly HttpClient _client;

        public ConditionMapingTests()
        {
            // Arrange
           _server = new TestServer(new WebHostBuilder()
               .UseStartup<Startup>());
           _client = _server.CreateClient();
        }

        [Fact]
        public async void Map_ListConditionEntity_Should_Work()
        {

            var options = new List<ConditionOptions>()
            {
                new ConditionOptions()
                {
                    Id = "ConditionOne"
                },
                new ConditionOptions()
                {
                    Id = "ConditionTwo"
                }
            };

            var report = options.Adapt<List<Entry>>();
            report.Should().NotBeNull().And.HaveCount(2);
        }

If i run the tests one at a time it works fine, but if i try to run all my tests at once i start getting errros

System.InvalidOperationException: Operations that change non-concurrent collections must have exclusive access. A concurrent update was performed on t...

and

Expected dest.FullUrl to be "Condition/ConditionOne", but found .

or

System.NullReferenceException: Object reference not set to an instance of an object.

Basically they all fail.

Is there another way to be doing this to have it load my mappings in the test?  They are all independent I cant see how they would be effecting each other in this way.
Update
Attempt number two was to create an attrubute which will register the mappings before each of the tests run.
This kind of works it works for each file but when more then one group of tests runs at the same time then it starts to fail again.
 [AttributeUsage(AttributeTargets.Class | AttributeTargets.Method, AllowMultiple = false, Inherited = true)]
    public class LoadMappingAttribute : BeforeAfterTestAttribute
    {
        public override void Before(MethodInfo methodUnderTest)
        {
            var typeAdapterConfig = new TypeAdapterConfig();
            var mappingRegistrations = new List<IRegister>
            {
                .... Lots of mapping files here .....

            };
            mappingRegistrations.ToList().ForEach(register => register.Register(typeAdapterConfig));
            var mapperConfig = new Mapper(typeAdapterConfig);
            TypeAdapterConfig.GlobalSettings.Compile();
        }

        public override void After(MethodInfo methodUnderTest)
        {

        }
    }
}

Cross posted from How to add tests for Mapster mapping, works when run signally but not when run at the same time

Operations that change non-concurrent collections must have exclusive access. A concurrent update was performed on this collection and corrupted its state. The collection's state is no longer correct.

Hi @LindaLawton,
I'm facing similar problem, did you found how to do this ?

seeing as the question was deleted on stack overflow after someone mentioned duplicate mapping files.  I would have to say it may have been that.
TBH i cant remember what i did last month let alone a year ago sorry :)


Expected Behavior of Abort with the AWS JDBC Wrapper

I'm developing an application that connects to PostgreSQL via JDBC using Spring Boot and HikariCP.
When attempting to stop the application (sending SIGINT) while a long-running query is active, it seems that HikariCP waits for the query to complete before aborting the connection. This behavior appears to be related to the AWS JDBC Wrapper's implementation:
(https://github.com/aws/aws-advanced-jdbc-wrapper/blob/main/wrapper/src/main/java/software/amazon/jdbc/util/WrapperUtils.java#L186)
In contrast, when using only the standard PostgreSQL driver, the connection is forcibly terminated even if a long-running query is in progress.
Question:
Is there a configuration or method to avoid this behavior?
According to the java.sql.Connection#abort specification, the connection should be forcibly terminated.
Thank you.

Hi @kiichiro-ito, thank you for reaching out and raising this issue. Could you please clarify whether you are interrupting the long-running query with Connection.abort or by executing kill -SIGINT <PID> on the command line? I'm assuming the former, since from my testing kill -SIGINT<PID> ends the application immediately but Connection.abort seems to wait until the query finishes like you mentioned. Let me know, and in the meantime I will keep investigating. Thanks!

Hi @aaron-congo. Thanks for your response!

When Spring Boot receives a SIGINT,  SpringApplicationShutdownHook runs in the background. This hook initiates the shutdown process, which calls HikariDataSource.shutdown and eventually leads to Connection.abort.
Below is a thread dump captured during this behavior.
"SpringApplicationShutdownHook" #16 prio=5 os_prio=0 cpu=15.62ms elapsed=11.09s tid=0x000002070f1bb730 nid=0x55e0 waiting on condition  [0x000000a528ffe000]
   java.lang.Thread.State: WAITING (parking)
        at<EMAIL_ADDRESS>Method)
        - parking to wait for  <0x00000006092d2bd0> (a java.util.concurrent.locks.ReentrantLock$NonfairSync)
        at java.util.concurrent.locks.LockSupport.park(java.base@<IP_ADDRESS>/LockSupport.java:211)
        at java.util.concurrent.locks.AbstractQueuedSynchronizer.acquire(java.base@<IP_ADDRESS>/AbstractQueuedSynchronizer.java:715)
        at java.util.concurrent.locks.AbstractQueuedSynchronizer.acquire(java.base@<IP_ADDRESS>/AbstractQueuedSynchronizer.java:938)
        at java.util.concurrent.locks.ReentrantLock$Sync.lock(java.base@<IP_ADDRESS>/ReentrantLock.java:153)
        at java.util.concurrent.locks.ReentrantLock.lock(java.base@<IP_ADDRESS>/ReentrantLock.java:322)
        at software.amazon.jdbc.ConnectionPluginManager.lock(ConnectionPluginManager.java:158)
        at software.amazon.jdbc.util.WrapperUtils.executeWithPlugins(WrapperUtils.java:234)
        at software.amazon.jdbc.util.WrapperUtils.runWithPlugins(WrapperUtils.java:165)
        at software.amazon.jdbc.wrapper.ConnectionWrapper.abort(ConnectionWrapper.java:180)
        at com.zaxxer.hikari.pool.HikariPool.abortActiveConnections(HikariPool.java:535)
        at com.zaxxer.hikari.pool.HikariPool.shutdown(HikariPool.java:230)
        - locked <0x0000000609b8abc0> (a com.zaxxer.hikari.pool.HikariPool)
        at com.zaxxer.hikari.HikariDataSource.close(HikariDataSource.java:351)
        at org.springframework.beans.factory.support.DisposableBeanAdapter.destroy(DisposableBeanAdapter.java:232)
        at org.springframework.beans.factory.support.DefaultSingletonBeanRegistry.destroyBean(DefaultSingletonBeanRegistry.java:587)
        at org.springframework.beans.factory.support.DefaultSingletonBeanRegistry.destroySingleton(DefaultSingletonBeanRegistry.java:559)
        at org.springframework.beans.factory.support.DefaultListableBeanFactory.destroySingleton(DefaultListableBeanFactory.java:1202)
        at org.springframework.beans.factory.support.DefaultSingletonBeanRegistry.destroySingletons(DefaultSingletonBeanRegistry.java:520)
        at org.springframework.beans.factory.support.DefaultListableBeanFactory.destroySingletons(DefaultListableBeanFactory.java:1195)
        at org.springframework.context.support.AbstractApplicationContext.destroyBeans(AbstractApplicationContext.java:1183)
        at org.springframework.context.support.AbstractApplicationContext.doClose(AbstractApplicationContext.java:1144)
        at org.springframework.context.support.AbstractApplicationContext.close(AbstractApplicationContext.java:1090)
        at org.springframework.boot.SpringApplicationShutdownHook.closeAndWait(SpringApplicationShutdownHook.java:145)
        at org.springframework.boot.SpringApplicationShutdownHook$$Lambda$857/0x00000206ca5cfc08.accept(Unknown Source)
        at java.lang.Iterable.forEach(java.base@<IP_ADDRESS>/Iterable.java:75)
        at org.springframework.boot.SpringApplicationShutdownHook.run(SpringApplicationShutdownHook.java:114)
        at java.lang.Thread.run(java.base@<IP_ADDRESS>/Thread.java:833)

Maven dependencies:
	<parent>
		<groupId>org.springframework.boot</groupId>
		<artifactId>spring-boot-starter-parent</artifactId>
		<version>3.3.0</version>
		<relativePath />
	</parent>
	<dependencies>
		<dependency>
			<groupId>org.springframework.boot</groupId>
			<artifactId>spring-boot-starter-web</artifactId>
		</dependency>
		<dependency>
			<groupId>org.springframework.boot</groupId>
			<artifactId>spring-boot-starter-aop</artifactId>
		</dependency>
		<dependency>
			<groupId>org.mybatis.spring.boot</groupId>
			<artifactId>mybatis-spring-boot-starter</artifactId>
			<version>3.0.3</version>
		</dependency>
		<dependency>
			<groupId>org.postgresql</groupId>
			<artifactId>postgresql</artifactId>
			</dependency>
		<dependency>
			<groupId>software.amazon.jdbc</groupId>
			<artifactId>aws-advanced-jdbc-wrapper</artifactId>
			<version>2.4.0</version>
		</dependency>
	</dependencies>

thank you.

Hi @kiichiro-ito,
We have just merged in a fix. Could you kindly checkout our latest snapshot build and let us know if the issue still persists?
Thank you!

Hi @aaron-congo,
I tested it with the snapshot, and it's working as expected now.
Thanks for the fix!

Hi @kiichiro-ito ,
The fix is now available in the recently released v2.5.3 of the driver, so I will close this ticket now. Please feel free to open another ticket if you encounter any issues.
Thank you!


Separate source/header files, bug fixes…

Non-templated, non-trivial or non-performance critical code is all in a separate source file.
Replaced ELPP_STACKTRACE_ON_CRASH (which wasn’t used) with ELPP_FEATURE_CRASH_LOG.
Small fixes for compiler warnings.

Please note that the code is working. I'm making the PR now so you can make sure all of the tests are working. There is still much to do before releasing this:

Projects to create static and dynamic libs. I have already done this for Xcode, I'll be pushing that soon.
Update the README for the new way of using the lib. I'm working on this. Ultimately I'd like to substantially edit the docs to be easier to use.
Sample files that illustrate usage of source, static lib, and dynamic lib. I have an Xcode project that does this.
Sample file that illustrates all of the possible uses of CustomFormatSpecifier. Still working on this.

I think a lot of more code can be moved to cc file such as initialize easyloggingpp and user will not need to do this. But i am happy so far. Greatly thanks for this

The call to init elpp is in the cc file now, but I guess all of those macros can go away now. If you eliminate those macros, then you don't need to check ELPP_AS_DLL in the cc file, the init can always be done there and then the user doesn't need to.
There isn't much more code that can be moved to the cc. I went over line pretty carefully. Everything that I left in the header is either:

Templated code that must remain in the header.
Trivial code that won't cause code bloat by being inlined.
Performance critical code that will benefit from inlining.

One important thing that will have to be noted in the docs: there are some config macros that will significantly change the code in a static or dynamic lib. It may be necessary to have different versions, for example thread-safe vs. non-thread-safe. I'll leave it to you to figure out which macros will have this effect.


ds-dev CLI help and usage

ds-dev CLI should output decently formatted help for usage

There are now docs specifically for using ds-dev. I think it's good enough for now.