Changes to jinja environment variables are global, and shouldn't be

If i run the following code:
from pathlib import Path
from yasha.cli import cli

Path('template.j2').write_text("{{ var is string }}, {{ var }}")
cli(['--var=foo', 'template.j2'], standalone_mode=False)
assert Path('template').read_text() == 'True, foo'

cli(['--var=foo', 'template.j2'], standalone_mode=False)
assert Path('template').read_text() == 'True, foo'

everything works fine.
If, instead, i run this code:
from pathlib import Path
from yasha.cli import cli

Path('template.j2').write_text("<< var is string >>, << var >>")
Path('extensions.py').write_text("""
BLOCK_START_STRING = '<%'
BLOCK_END_STRING = '%>'
VARIABLE_START_STRING = '<<'
VARIABLE_END_STRING = '>>'
COMMENT_START_STRING = '<#'
COMMENT_END_STRING = '#>'
""")

cli(['--var=foo', '-e', 'extensions.py', 'template.j2'], standalone_mode=False)
assert Path('template').read_text() == 'True, foo'

Path('template.j2').write_text("{{ var is string }}, {{ var }}")
cli(['--var=foo', 'template.j2'], standalone_mode=False)
assert Path('template').read_text() == 'True, foo'  # -> AssertionError
Path('template').read_text()  # -> '{{ var is string }}, {{ var }}'

The second call to cli fails, it prints the entire template, unrendered, to the output file. It appears jinja no longer recognizes that second template as a template, and just treats it as text. I suspect that although the second cli call doesn't use the extensions file, the jinja configuration overrides in that file are persisting somewhere in the python interpreter's global state

I think i found the culprit, in yasha/cli.py

I think i found the culprit, in yasha/cli.py

The first cli call should print the template also but it seems like the Jinja defaults (module global variables) didn't get change in time. This feature is related to https://github.com/kblomqvist/yasha#template-syntax.


No /configs/config.json or specified config

Whenever I start the bot using python pokecli.py this happens:
$ python pokecli.py
2016-08-08 00:47:22,256 [       cli] [INFO] PokemonGO Bot v1.0
2016-08-08 00:47:22,259 [       cli] [INFO] Error: No /configs/config.json or sp                                                                                ecified config
usage: pokecli.py [-h] [-cf CONFIG] -a AUTH_SERVICE [-u USERNAME]
[-ws WEBSOCKET.SERVER_URL]
[-wss WEBSOCKET.START_EMBEDDED_SERVER]
[-wsr WEBSOCKET.REMOTE_CONTROL] [-p PASSWORD] [-l LOCATION]
[-lc LOCATION_CACHE] [--forts.spin FORTS.SPIN] [-w WALK]
[-k GMAPKEY] [-e SHOW_EVENTS] [-d DEBUG] [-t TEST]
[-du DISTANCE_UNIT] [-ec EVOLVE_CAPTURED]
[-rt RECONNECTING_TIMEOUT] [-hr HEALTH_RECORD]
[-ac FORTS.AVOID_CIRCLES] [-mcs FORTS.MAX_CIRCLE_SIZE]
[--catch_randomize_reticle_factor CATCH_RANDOMIZE_RETICLE_FACT                                                                                OR]
[--catch_randomize_spin_factor CATCH_RANDOMIZE_SPIN_FACTOR]
[--map_object_cache_time MAP_OBJECT_CACHE_TIME]
pokecli.py: error: argument -a/--auth_service is required
Other Information
OS: Windows 10
Git Commit: (run 'git log -n 1 --pretty=format:"%H"' and paste it here)
Python Version: (run 'python -V' and paste it here)

Maybe I'm editing the wrong directory? How to find the correct one

You want to rename /configs/example.config.json to /configs/config.json.

Ohhhok ty I'm working on it, turns out the ones I edited were examples

same problem even though i made a config.json file


Virustotal flags it like it is a virus

It's not. Raw Accel's driver are fully signed for use in windows, and RA is an open source project hosted on GitHub with a decent amount of downloads. We cannot control what Virustotal does and does not flag.


Trigger JK BLE SOC reset when using Step Mode

@mr-manuel Could you please review the position of the SOC reset trigger while charge voltage control is in step mode? I'm not sure if that is the best position.

There where you put the trigger_soc_reset() for step mode was not the same place as in linear mode. I moved it to the same place and added a check, that it's only called, if the charging mode is changing from bulk or absorption to float.


Vivado warnings/errors for SLINK AXI stream interface clocks

Describe the bug
When using the AXI-Lite top-level interface, Vivado 2023.2 produces critical warnings like this for the AXI Stream interfaces for SLINK:
[BD 41-967] AXI interface pin /processor_subsystem/neorv32_SystemTop_ax_0/s1_axis is not associated to any clock pin. It may not work correctly.
This can also lead to block design validation errors when connecting the interfaces to other components such as the Xilinx AXI DMA, since Vivado cannot detect the correct clock frequency for the AXI stream interface (it seems to default to 100 MHz) and detects a mismatch with the other component. It is possible to work around this by manually setting the CLK_DOMAIN and/or FREQ_HZ parameter on the AXI stream interface on the NEORV32 core in the block design. However, it seems that these overridden settings do not always "stick" when exporting the block design back into tcl code for version control, so this is a nuisance to manage.
It looks like adding some dummy clock inputs to the top-level AXI wrapper (rtl/system_integration/neorv32_SystemTop_axi4lite.vhd) avoids this problem, for example:
    -- ------------------------------------------------------------
    -- AXI4-Stream-Compatible Interface --
    -- ------------------------------------------------------------
    -- Source --
    s0_axis_tdata  : out std_logic_vector(31 downto 0);
    s0_axis_tvalid : out std_logic;
    s0_axis_tlast  : out std_logic;
    s0_axis_tready : in  std_logic;
    s0_axis_aclk   : in  std_logic;
    -- Sink --
    s1_axis_tdata  : in  std_logic_vector(31 downto 0);
    s1_axis_tvalid : in  std_logic;
    s1_axis_tlast  : in  std_logic;
    s1_axis_tready : out std_logic;
    s1_axis_aclk   : in  std_logic;

Then if the same clock input used for m_axi_aclk is connected to these new clock ports, Vivado is able to figure out the clock domain for the AXI stream ports properly.
I guess the only downside of doing this is it might create the impression that the core supports using different AXI stream clocks from the main core clock, when it really doesn't. I suppose if you did try to use a mismatched clock it would probably end up with a timing failure, unless you happened to use clocks that were related/divisible which could just cause duplicate data words or something.

Good point. Seems like I have never used the SLINK in a Vivado block design... 🙈

s0_axis_aclk   : in  std_logic;

Shouldn't the clock of the TX link be an output (controlled by the main clock of the CPU)?

s1_axis_aclk   : in  std_logic;

Hmm this might be a real problem... A real dual-clock FIFO inside the SLINK would be nice here - but this would be quite heavy to implement (in a platform-independent style). 🤔

Shouldn't the clock of the TX link be an output (controlled by the main clock of the CPU)?

It's arguable I suppose, but the usual convention for these with the Xilinx components (like their AXI DMA) seems to be to have the clock as an input for both the TX and RX sides, so the user can drive the clock however they want in the block design.

Hmm this might be a real problem... A real dual-clock FIFO inside the SLINK would be nice here - but this would be quite heavy to implement (in a platform-independent style). 🤔

I think some Xilinx IPs do some kind of magic to detect if the clocks are synchronous and use different implementations based on that, but that's probably not possible without some custom Xilinx tcl scripting magic. I guess you could have a generic to select between common-clock and cross-clock FIFOs without degrading the implementation for the common-clock use case. But if someone really wants to use a stream on a different clock domain they could already use some Xilinx IP like the AXI Stream Data FIFO to convert it, so I'm not sure it's that necessary. Maybe just documenting the limitation would be enough?

It's arguable I suppose, but the usual convention for these with the Xilinx components (like their AXI DMA) seems to be to have the clock as an input for both the TX and RX sides, so the user can drive the clock however they want in the block design.

This "feels" wrong. But okay, that is up to Vivado 😅
What do you think would happen if we add the AXIS clocks outputs to the core? Do you think Vivado / IP integrator could handle and resolve that?

But if someone really wants to use a stream on a different clock domain they could already use some Xilinx IP like the AXI Stream Data FIFO to convert it, so I'm not sure it's that necessary

:+1:

Maybe just documenting the limitation would be enough?

Absolutely!
Could you propose a PR for this? :wink:

What do you think would happen if we add the AXIS clocks outputs to the core? Do you think Vivado / IP integrator could handle and resolve that?

If you mean having the AXIS clocks be an output from the core, unfortunately that doesn't seem to work well, since Vivado doesn't know that it is the same clock as input on m_axi_aclk, and so that produces errors when connecting the interface about the CLK_DOMAIN and FREQ_HZ not matching between the two ends of the stream connection.
So it seems like having these as dummy clock inputs may be the best we can do easily.. if you're OK with that I can create a PR for that change?

So it seems like having these as dummy clock inputs may be the best we can do easily.. if you're OK with that I can create a PR for that change?

If that makes Vivado happy then I'm absolutely fine with it. We should then simply add clear documentation about this. :+1:


Added weight regularizer to an mlp model

Coverage increased (+2.8%) to 65.814% when pulling 8663d245175788027db4c92ea7ecaaab84131143 on dev into 958aa2aef4b5ce6aa968290ce5c7446bbb2ddd6d on master.


[INLONG-6176][Agent] Support collect data from Oracle

Prepare a Pull Request
(Change the title refer to the following example)

Title Example: [INLONG-XYZ][Component] Title of the pull request

(The following XYZ should be replaced by the actual GitHub Issue number)

Fixes #6176

Motivation
Explain here the context, and why you're making that change. What is the problem you're trying to solve?
Modifications
Describe the modifications you've done.
Verifying this change
(Please pick either of the following options)

[ ] This change is a trivial rework/code cleanup without any test coverage.

[ ] This change is already covered by existing tests, such as:
(please describe tests)

[ ] This change added tests and can be verified as follows:
(example:)

Added integration tests for end-to-end deployment with large payloads (10MB)
Extended integration test for recovery after broker failure

Documentation

Does this pull request introduce a new feature? (yes / no)
If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
If a feature is not applicable for documentation, explain why?
If a feature is not documented yet in this PR, please create a follow-up issue for adding the documentation

@haibo-duan here we need to add Oracle Source to the JobProfileDto.class. You can refer to MongoDB at https://github.com/apache/inlong/pull/5674.
maybe other sources you added in the agent also add the job definition, like PostgreSQL/SQLServer.


Moved note as people unable to see it

Moved note to the top as field engineer told he was unable to see it as he did not scroll

@chrisda could you please approve these changes


Envoy reports a connection failure, but I succeed to curl the host in the container where envoy is located

I deploy envoy in a container and have the following problem.
Envoy reports a connection failure with the target ip (connection failure, error number:113). But when I go to the container where envoy is located and try to curl the target ip, it succeeds.
envoy log:
2022-10-11T12:19:20.654165Z	debug	envoy upstream	addHost() adding <IP_ADDRESS>:80
2022-10-11T12:19:20.654166Z	debug	envoy pool	queueing stream due to no available connections (ready=0 busy=0 connecting=0)
2022-10-11T12:19:20.654266Z	debug	envoy upstream	membership update for TLS cluster InboundPassthroughClusterIpv4 added 1 removed 0
2022-10-11T12:19:20.654283Z	debug	envoy upstream	re-creating local LB for TLS cluster InboundPassthroughClusterIpv4
2022-10-11T12:19:20.654266Z	debug	envoy pool	trying to create new connection
2022-10-11T12:19:20.654267Z	debug	envoy upstream	membership update for TLS cluster InboundPassthroughClusterIpv4 added 1 removed 0
2022-10-11T12:19:20.654394Z	debug	envoy upstream	re-creating local LB for TLS cluster InboundPassthroughClusterIpv4
2022-10-11T12:19:20.654324Z	trace	envoy pool	ConnPoolImplBase 0x55fdeb7f4e00, ready_clients_.size(): 0, busy_clients_.size(): 0, connecting_clients_.size(): 0, connecting_stream_capacity_: 0, num_active_streams_: 0, pending_streams_.size(): 1 per upstream preconnect ratio: 1
2022-10-11T12:19:20.654435Z	debug	envoy pool	creating a new connection (connecting=0)
2022-10-11T12:19:20.654522Z	debug	envoy connection	[C9] current connecting state: true
2022-10-11T12:19:20.654531Z	debug	envoy client	[C9] connecting
2022-10-11T12:19:20.654534Z	debug	envoy connection	[C9] connecting to <IP_ADDRESS>:80
2022-10-11T12:19:20.654674Z	debug	envoy connection	[C9] connection in progress
2022-10-11T12:19:20.654686Z	trace	envoy pool	not creating a new connection, shouldCreateNewConnection returned false.
2022-10-11T12:19:20.654693Z	trace	envoy http	[C8][S9663562306288894161] decode headers called: filter=envoy.filters.http.router status=1
2022-10-11T12:19:20.654701Z	trace	envoy http	[C8] parsed 73 bytes
2022-10-11T12:19:20.654713Z	debug	envoy upstream	membership update for TLS cluster InboundPassthroughClusterIpv4 added 1 removed 0
2022-10-11T12:19:20.654721Z	debug	envoy upstream	re-creating local LB for TLS cluster InboundPassthroughClusterIpv4
2022-10-11T12:19:20.911743Z	debug	envoy main	flushing stats
2022-10-11T12:19:20.919174Z	trace	envoy upstream	Stale original dst hosts cleanup triggered.
2022-10-11T12:19:20.919190Z	trace	envoy upstream	Cleaning up stale original dst hosts.
2022-10-11T12:19:20.919194Z	trace	envoy upstream	Keeping active host <IP_ADDRESS>:80.
2022-10-11T12:19:20.919197Z	trace	envoy upstream	Stale original dst hosts cleanup triggered.
2022-10-11T12:19:23.710964Z	trace	envoy connection	[C9] socket event: 3
2022-10-11T12:19:23.710991Z	trace	envoy connection	[C9] write ready
2022-10-11T12:19:23.711005Z	debug	envoy connection	[C9] delayed connect error: 113
2022-10-11T12:19:23.711010Z	debug	envoy connection	[C9] closing socket: 0
2022-10-11T12:19:23.711032Z	trace	envoy connection	[C9] raising connection event 0
2022-10-11T12:19:23.711038Z	debug	envoy client	[C9] disconnect. resetting 0 pending requests
2022-10-11T12:19:23.711046Z	debug	envoy pool	[C9] client disconnected, failure reason: delayed connect error: 113
2022-10-11T12:19:23.711061Z	debug	envoy router	[C8][S9663562306288894161] upstream reset: reset reason: connection failure, transport failure reason: delayed connect error: 113
2022-10-11T12:19:23.711099Z	trace	envoy main	item added to deferred deletion list (size=1)

curl:
root@fake-proxy:/proxy# curl http://<IP_ADDRESS>
FROM CLIENT: Hello world

This confused me and I would like to get some analysis or debug suggestions.

Hi, could you provide some more contexts?

Which version of envoy is used?
Is this problem always occurred for every request?
Will this problem occurred for clusters of other types?

cc @kyessenov

Running from istio-proxy container means you might be accessing IP directly without traffic capture by Envoy. I suggest posting your Istio config as an issue in Istio, and see if we can figure out why Envoy config is not working for you.


Add dependabot config to check for GitHub Actions updates

Adds a dependabot config to check for updates to the GitHub Actions we use and makes a PR with the version bump if a new version is found.
Code review:
None
Testing:
None

Not much to say here. Just gonna merge cause all it's gonna do is notify us when there are updates to the actions we use.
In the future we could probably extend it to also check for updates on the dependencies we submodule ^^


Initial code commit

What would you like to be added or you are addint (if you have created something on fork, please point ot the fork and code change)?
Add initial codebase and codeformatting
What is the feature and why is needed?
COdebase needed

Closing the issue as delivered


Added support for different scalapack contexts of the initial and target matrices.

Most important commits were cherry-picked from this commit and hence this PR can now be closed.

Most important commits were cherry-picked from this commit and hence this PR can now be closed.


[PB-1651] feat: integrate replace file endpoint

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (5761c4a) 65.71% compared to head (e9819b4) 65.84%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #189      +/-   ##
==========================================
+ Coverage   65.71%   65.84%   +0.12%
==========================================
  Files          39       40       +1
  Lines        1085     1089       +4
  Branches      150      150
==========================================
+ Hits          713      717       +4
  Misses        330      330
  Partials       42       42

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Fixed bug in array responses

Fixing response to return Hashie::Rash objects for all items in an array of results, instead of an array of hashes.

Sorry this fix took me so long.  Just pushed a 0.2.1 version up with the fix.
~ Tom


Bump to k8s 1.29

Related to: https://github.com/rancher/rancher/issues/45351

.drone.yml was updated to curl down helm instead of relying on presence of zypper, so no need to base drone on an older rancher image.


2 sensors are missing after last update (5.0.5)

Hi,
After update 5.0.5 the following sensors are missing:
sensor.afvalwijzer_first_next_in_days
sensor.afvalwijzer_first_next_item
With version 5.0.3 they were still there?

Ouch, sensors have been renamed (removed "first_")


Can not install package on Linux64

Hi,
I'm trying install node-usb from my project but seem like it don't have releases for Linux right?

Thanks.

There are pre-built binaries for Windows and macOS, but it will build from source on Linux.
From the README:

On Linux, you'll need libudev to build libusb. On Ubuntu/Debian: sudo apt-get install build-essential libudev-dev

Post the full error message if it fails to build.

I already fixed it after install node-gyp package.
Thanks you.


emit d.cts files in src/cjs

Adds separate types for cjs and esm in package.json
tsconfig.base.json emits type declarations
changed the postbuild command to convert .d.ts files to .d.cts

Await review by @arijoon

Thanks for the importHelpers tip.


redis-app dependency on redis-datasource

Is your enhancement related to a problem? Please describe.
There is no bug or problem
Describe the solution you'd like
Review on "redis-app" plugin dependency to redis-datasource v2.2.0 or >v2.1.1
Describe alternatives you've considered
Specifying "GF_INSTALL_PLUGINS" in proper order to override dependency problem. See additional context for working example.
Firstly, Grafana will install redis-datasource v2.1.1; then redis-app v2.2.1 and finally will install redis-datasoruce v2.2.0
However on every startup, redis-app will cause reinstallation of redis-datasource again. This will require a grafana startup script externally to override the behaviour with manual grafana cli plugins install method.
Additional context
Working example for docker-compose.yml Grafana service definition :
grafana:
    image: "grafana/grafana:9.5.14"
    container_name: grafana
    hostname: grafana
    user: "0"
    volumes:
      - ./etc/grafana/grafana.ini:/etc/grafana/grafana.ini
      - ./etc/grafana/provisioning/dashboards/:/etc/grafana/provisioning/dashboards/
      - ./etc/grafana/provisioning/datasources/:/etc/grafana/provisioning/datasources/
      - ./data/grafana/:/var/lib/grafana/
    # TODO : Add new plugins to be installed within below variable
    environment:
      GF_INSTALL_PLUGINS: >-
        redis-app 2.2.1,
        redis-explorer-app 2.1.1,
        redis-datasource 2.2.0
    networks:
      redis-network:
        ipv4_address: <IP_ADDRESS>
    ports:
      - "3000:3000"
    logging: *default-logging

Grafana logs for downgrading redis-datasource for redis-app plugin installation :
✔ Downloaded and extracted redis-datasource v2.2.0 zip successfully to /var/lib/grafana/plugins/redis-datasource

Please restart Grafana after installing or removing plugins. Refer to Grafana documentation for instructions if necessary.

✔ Downloaded and extracted redis-app v2.2.1 zip successfully to /var/lib/grafana/plugins/redis-app

Fetching redis-datasource dependency...

✔ Downloaded and extracted redis-datasource v2.1.1 zip successfully to /var/lib/grafana/plugins/redis-datasource

Please restart Grafana after installing or removing plugins. Refer to Grafana documentation for instructions if necessary.

✔ Downloaded and extracted redis-explorer-app v2.1.1 zip successfully to /var/lib/grafana/plugins/redis-explorer-app

Fetching redis-app dependency...

✔ Downloaded and extracted redis-app v2.2.1 zip successfully to /var/lib/grafana/plugins/redis-app

Please restart Grafana after installing or removing plugins. Refer to Grafana documentation for instructions if necessary.

See https://github.com/grafana/grafana/issues/78713. I had opened the same issue in Grafana, and now they told me that Grafana does not and will not support semver expressions like "version": "^2.1.1".


JSX text causes random formatting

There's not a solid repro for this but there's a bug in our SyntaxKind enum -- the JsxText kind parses as a token (which it should), but it's after LastToken. The formatting engine uses an N * N sparse array computed with N = LastToken. When the formatting computes the formatting context by using a token pair, this means a JsxToken ends up looking up a random formatting context. This causes JSX formatting to break, sometimes, when you add a new token and change the value of LastToken.
/cc @weswigham who was understandably baffled by this https://github.com/Microsoft/TypeScript/pull/10425/commits/11dce6ff5442c8d4951bf1efffc73de160cbe83c

Thanks for the callout; it's nice to know what was up!


Revert "Remove UDTFJexl from built-in function (#11365)"

This reverts commit 044a00b83b90b5cdae7480a32f524e9d47460461.

Codecov Report

Merging #11381 (1eec92f) into master (1c2c428) will decrease coverage by 0.04%.
Report is 1 commits behind head on master.
The diff coverage is 0.70%.

@@             Coverage Diff              @@
##             master   #11381      +/-   ##
============================================
- Coverage     48.64%   48.60%   -0.04%
+ Complexity    24416    24410       -6
============================================
  Files          2814     2815       +1
  Lines        172603   172743     +140
  Branches      20607    20617      +10
============================================
+ Hits          83958    83963       +5
- Misses        88645    88780     +135

Files
Coverage Δ

...ne/execution/fragment/FragmentInstanceContext.java
64.17% <ø> (+0.34%)
:arrow_up:

...f/builtin/BuiltinTimeSeriesGeneratingFunction.java
100.00% <100.00%> (ø)

...tion/schedule/DriverTaskTimeoutSentinelThread.java
0.00% <0.00%> (ø)

...org/apache/iotdb/commons/udf/builtin/UDTFJexl.java
0.00% <0.00%> (ø)

... and 14 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Similar dependency broke our CI

Description
See https://github.com/gfx-rs/naga/pull/472/checks?check_run_id=1904641293#step:4:93
When testing on Rust-1.43.0, similar fails to build:
error[E0034]: multiple applicable items in scope
Error:   --> /home/runner/.cargo/registry/src/github.com-1ecc6299db9ec823/similar-1.2.0/src/algorithms/lcs.rs:25:18
   |
25 |     if new_range.is_empty() {
   |        ----------^^^^^^^^--
   |        |         |
   |        |         multiple `is_empty` found
   |        help: disambiguate the method call for candidate #2: `std::iter::ExactSizeIterator::is_empty(&new_range)`
   |
   = note: candidate #1 is defined in an impl for the type `std::ops::Range<_>`
   = note: candidate #2 is defined in an impl of the trait `std::iter::ExactSizeIterator` for the type `std::ops::Range<usize>`

Reproduction steps

Build 1.5.3 and up on Rust-1.43.0

Additional helpful information:

Version of insta: 1.6.0
Version of rustc: 1.43.0
Operating system and version:

What did you expect
Not breakage
Notes
Of course we can work around this by either fixing the insta version to 1.5.2, or not building it on our MSRV.
Just thought I'd fire up this bug to see your thoughts on it.

@kvark I'm sorry for that. I lowered the minimum requirements to 1.41.0 now which I think should be a good base for both similar and insta. Upgrading to 1.6.2 should fix it for you.


[ASTMangler] Drop the legacy ASTManger constructor, always require ASTContext&

See https://github.com/swiftlang/swift/pull/77115 for the overall goal. This is a follow-up to https://github.com/swiftlang/swift/pull/77115 that removes the "legacy" ASTMangler constructor, but it's in a separate PR because we need to first fix out-of-repo users of this API (namely LLDB).

https://github.com/swiftlang/llvm-project/pull/9683
@swift-ci smoke test

@swift-ci please test


Fix bug: Pressing back on create/edit copyright exits activity #884

Fixes #884
Changes:
1. Add Copyright Fragment to backstack
2. Change activity's home action to finish() only when there's no fragment in backstack
Screenshots of the change:

@iamareebjamal Please review.


ACS Commons Error Page Handling Issues On Dispatcher

I was wondering if someone could explain why ACS Commons Error Handler is not functioning properly on the Dispatcher?
Here are some of the tests I have done:
Accessing the publisher with the following URL's it will resolve the en-us specific 404 page properly:
http://publisher:4503/content/en-us/nopage
http://publisher:4503/content/en-us/products/nopage.html
When I access the dispatcher with the URL's below it does not resolve the page with the custom 404, but instead with a blank page (Console does show 404). I can set the error-page.system-path to point to the /content/en-us/404 page and it would behave correctly as a catch all.
http://qa.crown.com/content/en-us/nopage
http://qa.crown.com/content/en-usnopage
When I access the dispatcher with the following URL's it will resolve the 404 page (Seems the period is needed after en-us)
http://qa.crown.com/content/en-us.htmlblabla
http://qa.crown.com/content/en-us.nopage
http://qa.crown.com/content/en-us/products.nopage
http://qa.crown.com/content/en-us/products.htmlblabla
On the dispatcher I did set DispatcherPassError to 0 so that the dispatcher spools all error responses to AEM. I have also tested this without any rewriterules and it results with the same issue.
We're currently using ACS Commons 2.8.0, but have tried the latest relase (2.10.0) in another environment, but I'm not having much luck with the latest version as it seemed to have broken the Author and Publisher region specific 404, looking at the logs it tries to resolve the "System error page" /content/error.html rather than the one under /content/en-us/error/404. Dispatcher obviously still does not work.

@y0050915 few questions; which page is the errorPages property on? I assume its on /content/en-us/jcr:content@errorPages
If this is true, then requests' to /content/en-usnopage should use the system page, however requests to /content/en-us/nopageuse the errorPages defined on the en-us page.
I'm surprised /content/en-us/nopage doesnt work though ...

Thanks for that information. I was able to resolve the issue. It was something to do with how /etc/map was configured to remove /content so I used the Apache Sling Resource Resolver Factory.

Hi ,
I am facing similar issue in calling custom pages using acs-commons error handler in dispacther url. Our dispacther url is https://domainname/junction/content/abc/home.html. In Author and Publish my custom error pages are coming up for 404 and 500, but in the end url default error message from apache shows up but not my custom error pages. Can anyone suggest any solution on this? Should I need to make any changes in dispatcher configurations?
@zhengy370  Can you elaborate what you have done to make it working?

Hi, currently I'm facing the same issue on the dispatcher.
I have error pages set on /market/language with system fallback to cover /some-non-existing-page
It works fine directly on publish, but on dispatcher /some-non-existing-page is blocked and default web server 404 is responded.


minion becomes unresponsive when pulsar returner can't reach splunk

When splunk is unavailable, the pulsar returner hangs the minion (it is not responsive from the master):
[DEBUG   ] LazyLoaded splunk_pulsar_return.returner
[INFO    ] Options: {"index": "target_hubble", "token": "REDACTED", "sourcetype": "hubble_pulsar", "indexer": "REDACTED"}
https://unavailable-splunk-server:8088/services/collector/event
[INFO    ] Starting new HTTPS connection (1): REDACTED

Thanks, we'll get this fixed.


Consider supporting setCustomValidity

The w3c specifies HTMLObjectElement.setCustomValidity.
I would suggest that in TeaVM jso-apis an HTMLObjectElement will be introduced with the method setCustomValidity(String customValidity) and HTMLInputElement should extend this new  interfaceHTMLObjectElement.
Any concerns? Should I provide a PR?

To fix issues like these you only need trivial change, so it's better to provide PR right away.

Sure, will do that next time omitting the issue. I was not aware how you deal with these things as every github project does this differently. Further, I was not aware if the HTML*Element types are missing out some properties on purpose (e.g. for ultimate performance). However, my understanding of TeaVM is that code that is not used, should also not affect run-time-performance (but maybe minimal impact on size and compile-time performance).


Downloading wrong or no video (teamcoco)

Please follow the guide below

You will be asked some questions and requested to provide some information, please read them carefully and answer honestly
Put an x into all the boxes [ ] relevant to your issue (like this: [x])
Use the Preview tab to see what your issue will actually look like

Make sure you are using the latest version: run youtube-dl --version and ensure your version is 2018.05.18. If it's not, read this FAQ entry and update. Issues with outdated version will be rejected.

[X] I've verified and I assure that I'm running youtube-dl 2018.05.18

Before submitting an issue make sure you have:

[X] At least skimmed through the README, most notably the FAQ and BUGS sections
[X] Searched the bugtracker for similar issues including closed ones
[X] Checked that provided video/audio/playlist URLs (if any) are alive and playable in a browser

What is the purpose of your issue?

[X] Bug report (encountered problems with youtube-dl)
[ ] Site support request (request for adding support for a new site)
[ ] Feature request (request for a new functionality)
[ ] Question
[ ] Other

If the purpose of this issue is a bug report, site support request or you are not completely sure provide the full verbose output as follows:
Add the -v flag to your command line you run youtube-dl with (youtube-dl -v <your command line>), copy the whole output and insert it here. It should look similar to one below (replace it with your log inserted between triple ```):
$ youtube-dl.exe -v "http://teamcoco.com/italy/jordan-schlansky-lectures-conan-about-coffee-in-naples?playlist=x;eyJ0eXBlIjoidGFnIiwiaWQiOjF9"
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: ['-v', 'http://teamcoco.com/italy/jordan-schlansky-lectures-conan-about-coffee-in-naples?playlist=x;eyJ0eXBlIjoidGFnIiwiaWQiOjF9']
[debug] Encodings: locale cp1252, fs mbcs, out cp1252, pref cp1252
[debug] youtube-dl version 2018.05.18
[debug] Python version 3.4.4 (CPython) - Windows-7-6.1.7601-SP1
[debug] exe versions: avconv v11.7, avprobe v11.7, ffmpeg 3.2.2, ffprobe 3.2.2, rtmpdump 2.3
[debug] Proxy map: {}
[generic] jordan-schlansky-lectures-conan-about-coffee-in-naples?playlist=x;eyJ0eXBlIjoidGFnIiwiaWQiOjF9: Requesting header
WARNING: Falling back on generic information extractor.
[generic] jordan-schlansky-lectures-conan-about-coffee-in-naples?playlist=x;eyJ0eXBlIjoidGFnIiwiaWQiOjF9: Downloading webpage
[generic] jordan-schlansky-lectures-conan-about-coffee-in-naples?playlist=x;eyJ0eXBlIjoidGFnIiwiaWQiOjF9: Extracting information
[download] Downloading playlist: Jordan Schlansky Lectures Conan About Coffee In Naples
[generic] playlist Jordan Schlansky Lectures Conan About Coffee In Naples: Collected 2 video ids (downloading 2 of them)
[download] Downloading video 1 of 2
[debug] Default format spec: bestvideo+bestaudio/best
[debug] Invoking downloader on 'http://ak.static.teamcoco.com/evergreen/eggs/durst/Durst.mp3'
[download] Jordan Schlansky Lectures Conan About Coffee In Naples (1)-jordan-schlansky-lectures-conan-about-coffee-in-naplesplaylist=x;eyJ0eXBlIjoidGFnIiwiaWQiOjF9-1.mp3 has already been downloaded
[download] 100% of 12.62KiB
[download] Downloading video 2 of 2
[debug] Default format spec: bestvideo+bestaudio/best
[debug] Invoking downloader on 'http://static.teamcococdn.com/www/promos/uk-promo.mp4'
[download] Jordan Schlansky Lectures Conan About Coffee In Naples (2)-jordan-schlansky-lectures-conan-about-coffee-in-naplesplaylist=x;eyJ0eXBlIjoidGFnIiwiaWQiOjF9-2.mp4 has already been downloaded
[download] 100% of 3.20MiB
[download] Finished downloading playlist: Jordan Schlansky Lectures Conan About Coffee In Naples

Description of your issue, suggested solution and other information
The youtube-dl support for teamcoco site was updated last week and it works except for the "jordan schlansky" videos.
These download a mp3 and the United Kingdom trailer
http://teamcoco.com/italy/conan-jordan-schlansky-hit-the-streets-of-florence
http://teamcoco.com/italy/jordan-schlansky-poses-as-a-nude-model
http://teamcoco.com/italy/conan-jordan-schlansky-go-truffle-hunting
http://teamcoco.com/italy/conan-jordan-schlansky-s-italian-wine-tasting
http://teamcoco.com/italy/jordan-schlansky-lectures-conan-about-coffee-in-naples
These fail to download anything with the error: ERROR: Unable to extract video url; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
http://teamcoco.com/italy/conan-jordan-schlansky-s-italian-road-trip
http://teamcoco.com/italy/conan-visits-jordan-s-favorite-restaurant
http://teamcoco.com/italy/conan-jordan-s-fake-italian-movie-trailer
$ youtube-dl.exe -v "http://teamcoco.com/italy/conan-jordan-s-fake-italian-movie-trailer"
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: ['-v', 'http://teamcoco.com/italy/conan-jordan-s-fake-italian-movie-trailer']
[debug] Encodings: locale cp1252, fs mbcs, out cp1252, pref cp1252
[debug] youtube-dl version 2018.05.18
[debug] Python version 3.4.4 (CPython) - Windows-7-6.1.7601-SP1
[debug] exe versions: avconv v11.7, avprobe v11.7, ffmpeg 3.2.2, ffprobe 3.2.2, rtmpdump 2.3
[debug] Proxy map: {}
[generic] conan-jordan-s-fake-italian-movie-trailer: Requesting header
WARNING: Falling back on generic information extractor.
[generic] conan-jordan-s-fake-italian-movie-trailer: Downloading webpage
[generic] conan-jordan-s-fake-italian-movie-trailer: Extracting information
[Instagram] BfXB57dlgqf: Downloading webpage
ERROR: Unable to extract video url; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
Traceback (most recent call last):
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmpco7jv88i\build\youtube_dl\YoutubeDL.py", line 792, in extract_info
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmpco7jv88i\build\youtube_dl\extractor\common.py", line 503, in extract
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmpco7jv88i\build\youtube_dl\extractor\instagram.py", line 191, in _real_extract
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmpco7jv88i\build\youtube_dl\extractor\common.py", line 1001, in _og_search_video_url
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmpco7jv88i\build\youtube_dl\extractor\common.py", line 892, in _html_search_regex
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmpco7jv88i\build\youtube_dl\extractor\common.py", line 883, in _search_regex
youtube_dl.utils.RegexNotFoundError: Unable to extract video url; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.

This also fails to download, possibly due to the date at the end 04/25/18 looking like subdirectories, but it works on the website.
$ youtube-dl.exe -v http://teamcoco.com/video/the-conan-audiencey-awards-for-04/25/18
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: ['-v', 'http://teamcoco.com/video/the-conan-audiencey-awards-for-04/25/18']
[debug] Encodings: locale cp1252, fs mbcs, out cp1252, pref cp1252
[debug] youtube-dl version 2018.05.18
[debug] Python version 3.4.4 (CPython) - Windows-7-6.1.7601-SP1
[debug] exe versions: avconv v11.7, avprobe v11.7, ffmpeg 3.2.2, ffprobe 3.2.2, rtmpdump 2.3
[debug] Proxy map: {}
[Teamcoco] the-conan-audiencey-awards-for-04: Downloading JSON metadata
ERROR: This video is no longer available.
Traceback (most recent call last):
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmpco7jv88i\build\youtube_dl\YoutubeDL.py", line 792, in extract_info
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmpco7jv88i\build\youtube_dl\extractor\common.py", line 503, in extract
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmpco7jv88i\build\youtube_dl\extractor\teamcoco.py", line 106, in _real_extract
youtube_dl.utils.ExtractorError: This video is no longer available.

This appears to be a problem again now that everything's switched over to classic.teamcoco.com, for example https://classic.teamcoco.com/node/106270 / https://classic.teamcoco.com/late-night-with-conan-obrien/season-6/episode-82/conan-in-ireland-03-17-99 has the following output:
C:\Users\Chris\Desktop>youtube-dl -v "https://classic.teamcoco.com/late-night-with-conan-obrien/season-6/episode-82/conan-in-ireland-03-17-99"
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: ['-v', 'https://classic.teamcoco.com/late-night-with-conan-obrien/season-6/episode-82/conan-in-ireland-03-17-99']
[debug] Encodings: locale cp1252, fs mbcs, out cp437, pref cp1252
[debug] youtube-dl version 2021.06.06
[debug] Python version 3.4.4 (CPython) - Windows-10-10.0.19041
[debug] exe versions: none
[debug] Proxy map: {}
[Teamcoco] late-night-with-conan-obrien/season-6/episode-82/conan-in-ireland-03-17-99: Downloading JSON metadata
ERROR: This video is no longer available.
Traceback (most recent call last):
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\ytdl-org\tmpkqxnwl31\build\youtube_dl\YoutubeDL.py", line 815, in wrapper
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\ytdl-org\tmpkqxnwl31\build\youtube_dl\YoutubeDL.py", line 836, in __extract_info
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\ytdl-org\tmpkqxnwl31\build\youtube_dl\extractor\common.py", line 534, in extract
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\ytdl-org\tmpkqxnwl31\build\youtube_dl\extractor\teamcoco.py", line 131, in _real_extract
youtube_dl.utils.ExtractorError: This video is no longer available.


Added Rival95 mice support

Very similar to Rival100 but without LED indicators.

Thank you !
I will release this soon :)

Released in rivalcfg v3.9.0, thanks again :)


Building Scalable Multi-Module Projects in Spring Boot

Article checklist
Pre-submission checks

Please ensure that you have only one open topic suggestion (issue) + in-review article (linked pull request) at a time. This will ensure that we complete the review process in a timely manner from inception to publishing

If you have not already, please go over our Resources Page for more tips and tricks on how to improve your overall technical writing so reviews are swifter, increase the chance of a payout and provide more value to our readers.

For first-time contributors and for more details on our submission guidelines, see our Contributing Guidelines.

Formatting and structure checks

[x] Have you used the correct folder and file structure? - see Contribution Guidelines

[x] Is your article properly formatted in Markdown? - see Github Markdown guide

[x] Have you used our preferred heading structure? - H3 (###) and up

[x] Does your article follow any of the suggested structure formats? - see example formats

[x] Is your article over 750 words? - Tool: Wordcounter.net

[x] Is the article you are submitting an in-depth and unique article? Does it go beyond what is in the official docs and what is covered in other blog sites. See these articles as examples.

[x] Does your article provide enough value and detail about your topic? - Articles should be clear, accurate, and fully explained.

[x] Can your article be understood by beginners? - Assume the audience is smart but has no prior exposure to the common terminology in your article.

[x] Have you included a hero image that is 600x400 pixels and have the copyright to use it? - Tools: Pixlr Image Editor for resizing and Unsplash for Creative Commons images

Grammar & plagiarism checks

[x] Have you spellchecked and grammar checked your article? - Tools: Write&Improve - ProWritingAid - Grammarly
[x] Please place your article through a 3rd party plagiarism checker. We suggest using Quetext, this tool is free and has a daily limit. We typically accept articles with 10% or less.
[x] Have you checked your article for readability? - Tool: Hemmingway
[ ] Have you added sources for quotes and images that aren't yours?

Technical checks

[x] Are your code snippets properly formatted for syntax highlighting - see Syntax guide
[x] Have you checked your code runs correctly and you've highlighted all necessary dependencies for installation?
[x] Are the software programs and packages you're highlighting in your article up to date, using current versions and not deprecated?

Topic suggestion this closes

Remove the backticks and add the issue number below to link and close your Topic Suggestion (issue) when your article has been published (PR has been merged). See this video for more details.

This closes issue #5078

Finally, delete the article checklist notes in blockquotes and submit your PR. We look forward to reviewing your article.

This fixes #5079

@srishilesh Hi friend. As you suggested. I have opened a new PR. And I believe all is well now. Please let me know if it is ready for review now.
Thank you very much for all you do
@Kayere @hectorkambow

@srishilesh Hi friend. As you suggested. I have opened a new PR. And I believe all is well now. Please let me know if it is ready for review now.
Thank you very much for all you do
@Kayere @hectorkambow

@teevyne
This looks good.
Let's wait for this PR to get plagiarism checked.
Until then, I'll go through your PR to find for any formatting changes.
Thanks.

You referenced an issues that has not been approved https://github.com/section-engineering-education/engineering-education/issues/5079

You referenced an issue that has not been approved #5079

Hi @WanjaMIKE Thank you. I have changed to reference the right issue #5078

@srishilesh Hi friend. As you suggested. I have opened a new PR. And I believe all is well now. Please let me know if it is ready for review now.
Thank you very much for all you do
@Kayere @hectorkambow

@teevyne
This looks good.
Let's wait for this PR to get plagiarism checked.
Until then, I'll go through your PR to find for any formatting changes.
Thanks.

Thank you very much. I look forward to hearing from you soon.

@srishilesh  Hi, I thought to check with you on this. Thank you for all you have done thus far

@srishilesh  Hi, I thought to check with you on this. Thank you for all you have done thus far

Hi @teevyne ,
As I had mentioned earlier, let's wait for the plagiarism check before we get started with the actual review.
Thanks.

@srishilesh  Hi, I thought to check with you on this. Thank you for all you have done thus far

@srishilesh  Hi, I thought to check with you on this. Thank you for all you have done thus far

Hi @teevyne ,
As I had mentioned earlier, let's wait for the plagiarism check before we get started with the actual review.
Thanks.

Thanks a lot for the reply.

@srishilesh Hi, I thought to check with you on this. Thank you for all you have done thus far

@srishilesh  Hi, I thought to check with you on this. Thank you for all you have done thus far

Hi @teevyne ,
As I had mentioned earlier, let's wait for the plagiarism check before we get started with the actual review.
Thanks.

Thanks a lot for the reply.
@hectorkambow  @WanjaMIKE  @Kayere  @srishilesh  Any updates for me today? Good morning wonderful people

@teevyne
it seems this PR is still quite a bit aways from being completed.
As a rule of thumb - please only submit articles (pull requests) with a complete and fully polished article - ready to be published.
All revisions and edits should be completed on your own forked repo (as to not take up room in the queue).
We will be closing this and please re-submit when it is ready to be published as a new PR (and you can add the duplicate label) and ping the reviewer and myself.
Closing a PR does NOT mean the article can not be published (or fixed) it simply means that the edits, revisions, and fixes will happen outside of the queue.
👍
cc @srishilesh

@teevyne
I've responded to your comments. Please have a look at them.
Also, looks like we have got back those unwanted files again.
You can create a new PR with all these suggested changes. Ping me once you're done. Ensure you don't have those unwanted files in your new PR.
Make sure that your new PR is ready to be published, and needs no extra revisions.
Thanks.

@srishilesh All that is asked of me has been done. I will not create a new PR and tag you to it


introduce setValueChangeEvent option

Proposed changes
New option "setValueChangeEvent". It's needed to avoid firing change event.
Checklist
[ +] Checkstyle and unit tests pass locally with my changes by running gradle check chrome htmlunit command
[ - ] I have added tests that prove my fix is effective or that my feature works
[ + ] I have added necessary documentation (if appropriate)

Codecov Report

Merging #718 into master will decrease coverage by 0.06%.
The diff coverage is 40%.

@@             Coverage Diff              @@
##             master     #718      +/-   ##
============================================
- Coverage     63.49%   63.43%   -0.07%
  Complexity      862      862
============================================
  Files           154      154
  Lines          2978     2981       +3
  Branches        288      290       +2
============================================
  Hits           1891     1891
- Misses          988      989       +1
- Partials         99      101       +2

Impacted Files
Coverage Δ
Complexity Δ

...ain/java/com/codeborne/selenide/Configuration.java
0% <0%> (ø)
0 <0> (ø)
:arrow_down:

...n/java/com/codeborne/selenide/commands/Append.java
83.33% <50%> (-16.67%)
2 <0> (ø)

...java/com/codeborne/selenide/commands/SetValue.java
93.93% <50%> (-2.94%)
12 <0> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 688db05...4f37fc5. Read the comment docs.

Coverage decreased (-0.0002%) to 66.823% when pulling 4f37fc53b6ab9e07fa9fcb40ae81c18ca17797f1 on MikeShysh:setValueChangeEventOption into 688db05d34e9c6a5b7c7da8458446ce13b2163f8 on codeborne:master.

@MikeShysh Can you please provide some tests for this ability?

@MikeShysh, some tests failing, please take a look at them:
> Task :htmlunit FAILED
430 tests completed, 2 failed, 50 skipped

Fixed. Thanks, @BorisOsipov and @rosolko for help

@BorisOsipov done


No Premium Feature in Study Plan

Describe the bug
Not able to access the premium Questions in the study plan

yes, you have to search for them by name at https://leetcode.com/problemset/


Refresh use of unstable features according to latest nightly

Code now uses postfix await notation.

@calops: Thank you for your contribution, I am sorry for the late reply.
It seems like the PR doesn't pass automatic tests. Perhaps we need to update the travis.yml to a newer version of rust. If you have some time you can check travis.yml and try to change it and see if the tests pass.
On a larger scale, I do not recommend to use the code in this repository at this point in time.
I believe that there are some edge cases that were not handled correctly, therefore using async_mutex might cause deadlocks.
What I believe wasn't handled correctly is some dropping cases, which might leave an async_mutex locked forever. I hope to find the time to go back to this codebase and fix those issues.


Documentation icon linking to commits

The documentation icon on the three contributors in README.md links to commits by that user. The info in README.md doesn't explain this, as the field next to Documentation is empty.

Thanks for pointing that out...
I'm actually not sure what to do about this. Sometimes documentation lives in the README.md, other times it lives in a separate site... I'm thinking that we'll just say that it should be linked to any relevant information indicating their contributions (whether that be their commits to the project or otherwise). Wanna make a PR (be sure to add yourself to the list of contributors :smile:)

I don't necessarily object to it not linking to their commits, @kentcdodds.. just think that the documentation in this project's README.md should explain the link (if any).

Right, agreed.

I'll submit a PR in a few minutes, @kentcdodds :smile:


Running TCLP on low quality GPUs

I'm trying to run TCLP on 1660 super, but it does not run well.
Could you provide your GPU spec and some ways to lower GPU computation?

The minimum VRAM for TCLP is 10GB. To lower the computation, you can change the number of stage and CNN layers in MSTCN.


Full caddy production environment in a single command.

There are a couple of steps I need to take to start up a caddy server in production:
$ sudo -s
$ source .env
$ nohup caddy >> logs/out.log &

Is there a way to minimize this into one command?
$ sudo caddy

Or maybe add a few new daemon style commands like:
$ caddy start
$ caddy logs
$ caddy stop
$ caddy logs https://example.org
$ caddy stop https://example.org

It would need to do the following which I currently do manually:

Add environment variables from a local .env file (see the node dotenv package for more information, although it is using the bash script formatting options).
Redirect caddy output to a log file.
Run caddy in the background so it persists after ending an SSH session.

Are these things possible? Is nohup the right way to run caddy in production?

Make a service of it...  (either systemd or upstart).
I have created both an upstart and systemd script, maybe I can also share the second one, but I haven't got much experience with systemd.

Btw: why running Caddy as root? You can bind to port 80 as a normal user by using setcap
From the readme:

Running as root: We advise against this; use setcap instead, like so:
setcap cap_net_bind_service=+ep ./caddy This will allow you to listen on
ports < 1024 like 80 and 443.

If you want to stick to nohup you could create a 'start' script that writes the process id to a file, and then create a 'stop' script that reads the pid from the file and kills it.

SystemD Service

create the service file:

cat <<EOF ><EMAIL_ADDRESS>[Unit]
Description=Caddy HTTP/2 web server %I
Documentation=https://caddyserver.com/docs
After=network.target

[Service]
User=%i
Environment=STNORESTART=yes
ExecStart=/usr/sbin/caddy -agree=true -conf=/etc/caddy/Caddyfile
Restart=on-failure
SuccessExitStatus=2 3 4
RestartForceExitStatus=3 4

[Install]
WantedBy=multi-user.target
EOF

reload the systemd daemon: systemctl daemon-reload
start the service: systemctl start caddy@someuser
enable it (to start it automatically on boot): systemctl enable caddy@someuser

Thanks guys, this is seriously really helpful. However, if caddy wants to be the easiest solution to integrate, maybe it's worth considering abstracting this process?
Or at least put a tutorial somewhere with instructions for deploying a caddy server.

Good suggestion...

@klingtnet will that work and start on ports 80 and 443 with a regular user?

Deploying an application is very different from serving websites; I don't want to get into that business... sounds more like sysadmin work.
But perhaps we could post some examples to the caddyserver/examples repo in a new folder called "deployment" or something, since it's a common enough question.

@mholt but that's something most of your target users will eventually want to do. Adding start/stop commands would fulfill most basic cases.

@DenBeke using upstart, where is the .caddy folder supposed to go?

.caddy folder?

Where lets encrypt key pairs go. Normally it's in the home folder (~/.caddy).

@matthewp If you have run setcap cap_net_bind_service=+ep $(which caddy) beforehand, then yes.

Deploying an application is very different from serving websites; I don't want to get into that business... sounds more like sysadmin work.

Can't we have Caddy in the package managers? Or an install script which downloads caddy, detects the correct init system, creates the correct start files, ...?

I could write a AUR repositort for Arch Linux if someone is interested.

@DenBeke it seems $HOME is an empty string in the upstart script, should I put it at root?

@calebmer How do you mean?

@DenBeke caddy wants to put all of the lets encrypt configuration into $HOME/.caddy, however $HOME is not defined in the upstart script/end script portion. What do I do? Does caddy allow me to reconfigure where that directory goes? Should I put the .caddy folder at root to reflect that $HOME is empty? Do I define $HOME as the caddy user's home?

Can't we have Caddy in the package managers? Or an install script which downloads caddy, detects the correct init system, creates the correct start files, ...?

I am with @DenBeke  on this. I think this needs to happen for greater adoption.
e.g. on Ubuntu
$ sudo apt-get install caddy

@abiosoft I'm afraid the Ubuntu packages won't be quickly enough released, so apt-get will always be an older version. Arch is much faster in this.
For now a bootstrap script is maybe the most easy solution. I can help with this...

@DenBeke I'd love you help :+1:

I don't know if this will be helpful, but https://getcaddy.com

That's a good starting point, @mholt!
Together with that we should install service files (matching the system), set cap, ...

This is the (SysV?) init script I'm using at /etc/init.d/caddy
#!/bin/bash
# Caddy daemon
# chkconfig: 345 20 80
# description: Caddy daemon
# processname: caddy

DAEMON_PATH="/usr/local/bin"

DAEMON='./caddy'
DAEMONOPTS="-conf=/etc/caddy/Caddyfile -log /var/log/caddy.log"

NAME=caddy
DESC="Caddy upstart"
PIDFILE=/var/run/$NAME.pid
SCRIPTNAME=/etc/init.d/$NAME

case "$1" in
start)
	printf "%-50s" "Starting $NAME..."
	cd $DAEMON_PATH
	PID=`$DAEMON $DAEMONOPTS > /dev/null 2>&1 & echo $!`
	echo "Saving PID" $PID " to " $PIDFILE
        if [ -z $PID ]; then
            printf "%s\n" "Fail"
        else
            echo $PID > $PIDFILE
            printf "%s\n" "Ok"
        fi
;;
status)
        printf "%-50s" "Checking $NAME..."
        if [ -f $PIDFILE ]; then
            PID=`cat $PIDFILE`
            if [ -z "`ps axf | grep ${PID} | grep -v grep`" ]; then
                printf "%s\n" "Process dead but pidfile exists"
            else
                echo "Running"
            fi
        else
            printf "%s\n" "Service not running"
        fi
;;
stop)
        printf "%-50s" "Stopping $NAME"
            PID=`cat $PIDFILE`
            cd $DAEMON_PATH
        if [ -f $PIDFILE ]; then
            kill -HUP $PID
            printf "%s\n" "Ok"
            rm -f $PIDFILE
        else
            printf "%s\n" "pidfile not found"
        fi
;;

restart)
  	$0 stop
  	$0 start
;;

*)
        echo "Usage: $0 {status|start|stop|restart}"
        exit 1
esac

Got this working on my FreeBSD Server: https://gist.github.com/justrjlewis/a3b4c36767a98b8b3c75

@mholt
I am puzzled beyond belief at your sysadmin vs serving websites comment.  What is it you think that sysadmins do?
(NOT trolling:  Definitely want to start a dialogue....)

I'm going to leave it up to the sysadmin to decide how he/she wants to run Caddy. All I meant by that comment is that Caddy serves websites, and I don't want the scope to creep up to the system environment level where it configures a system so it can run a certain way.

@justrjlewis, thank for the start up script! I'm considering attempting to make caddy a port/package with freeBSD and that will help out a lot.
@faddat, not everyone uses systemd and/or linux, and I'd rather a specific OS determine how to startup a process when it's installed in the OS.

@jungle-boogie that would be great!

@jungle-boogie That script needs some work - it's got some bugs.  I haven't had a chance to jump back into it, but let me know if you come up with any changes! :+1:

Thanks, @justrjlewis

@mholt the comments at the top of https://getcaddy.com are wrong.  It says:
#	$ curl getcaddy.com | bash
#	 or
#	$ wget -qO- getcaddy.com | bash

These now need to be:
#	$ curl https://getcaddy.com | bash
#	 or
#	$ wget -qO- https://getcaddy.com | bash

Or it fails saying "bash: line 1: a: No such file or directory"

@andyjeffries
wget -qO - getcaddy.com works fine. curl needs the L` switch to follow redirects:
curl -L getcaddy.com | bash

OK.  I'd already got past it, so it was more of a nudge so that "getcaddy.com" is updated and more people don't hit this.  Thanks though.

I'd go with the https:// ones.
It is bad enough that it pipes directly to bash, the link being plain http will further put one off.
Yeah, I'm aware it will redirect to https and I know many apps still use this as default way of installation. Just thinking as a random cautious first time user.

Thanks for the reminder; will update that soon.

Hey guys!  FYI: new freebsd service script.  I haven't tried it yet, but looks legit. :+1:
https://www.davd.eu/posts/caddy-freebsd-init-script/

@justrjlewis I didn't recognize you already made a service script, otherwise I would've saved me the hassle ;-) I enhanced my script so that you could change the user the process runs on. What I would love to see is privilege dropping within Caddy because running a webserver as root user is a pain in the ass, especially on FreeBSD where setcap is not really an option (at least as I'm aware of). I've now accomplished this by jailing the server but generally - having packages for both Linux and FreeBSD that provide anything to run Caddy in production would be great, if anyone has motivation towards doing that for FreeBSD (either as a port or for pkgng) I'd like to help.

@dprandzioch
No worries.  I'm anxious to try your implementation.  I never thought of outputting the the log file, CPU settings, or testing for the email.  Also, my script doesn't include a status message, so cool.  I can't wait to play with it!
The freebsd code is in the handbook under  15.5.4. The MAC Port Access Control List PolicyThe MAC Port Access Control List Policy
What I didn't get at first was that you have to use ALL of those commands, so it boils down to this:
net.inet.ip.portrange.reservedlow=0
net.inet.ip.portrange.reservedhigh=0
security.mac.portacl.port_high=1023
security.mac.portacl.suser_exempt=1
security.mac.portacl.rules=uid:[uid for desired user]:tcp:80,uid:[uid for desired user]:tcp:443,etc...

What I plan to work on, is updating the Caddy docs to be as platform agnostic as the server itself.  It's early days, but for my mind doing that and having tons of examples for people is the key long term growth.  I would love to see Caddy added to the package manager.  I'm still new to freebsd myself and have four huge projects to finish up before I start playing with my freebsd box again, but message me if you start before I do.  Also, check with @jungle-boogie - he may already be working on something.

Yeah, with freeBSD you can use jails or MAC port access until Caddy can support some kind of privileg dropping: https://github.com/mholt/caddy/issues/528

@justrjlewis Thanks you so much, I already tried to figure out to get this running but didn't succeed until now. :-)
@jungle-boogie Just added my 2c to #528. I'm currently running Caddy jailed anyway but'd rather prefer a native implementation that's just as self-contained as Caddy itself is. Anyway, I think it's better keeping that separate in the other bug report :-)
However, is there any development going on regarding providing Caddy packages for various Linux / BSD systems? I think that will be interesting for many people for the long run, including sample configuration (however the current documentation is very good anyway) and most certainly an init script for systemd/rc.d (I think sysvinit and upstart can be dropped by now as the most Linux distros are migrating to systemd just to not make it more complicated as it needs to be?). On the other hand this kind of reduces the portability of that single statically-linked executable that I like so much but I think especially when it comes to larger production deployments you might wanna have more framework around the webserver itself.

@dprandzioch There is some effort and definitely a lot of interest in distributing Caddy via system packages; anyone is welcome to step up to the plate in #395, where I invite anyone who would like to to be involved in that way.

@justrjlewis @jungle-boogie @alexbilbie @klingtnet @calebmer @DenBeke (phew!) There is now a folder in dist/init where we are assembling "init" scripts. These are not officially part of the project, but if you would like to add your own to that folder (and keep them maintained if they change, please), we'd really appreciate it! Thanks to David for that PR above with the idea.
When you submit your script, please include a brief paragraph in the README there about how to use it. Preferably, comment it so it can be customized easily, but choose sensible defaults. Also please include your GitHub username or email address so people can ask you their questions.

@mholt Great! I will review my SystemD service file tomorrow and open up PR.

@mholt I'm happy that this one finally made it into the repository. I'll try create a PR, commenting my init script as soon as possible.

Yay, we've got two now.
I also welcome discussion on how to improve getcaddy.com without getting too crazy about it. :smile:
I'm going to close this issue. Feel free to continue the discussion though, and remember that you can add your own scripts to dist/init! Pull requests welcome.


Missing reposts on channel

After upgrading to 0.50.1 the reposts of the last days went away in one channel.
The search still reveals them but they are not visible in any view.

Can you check your settings to see if you've hidden reposts? If not, please email us at<EMAIL_ADDRESS>with the details.

We've found the issue with new reposts and will get a fix out later today.

@tzarebczan  Sorry - but the fix did only fix this on lbry.tv.  The desktop client is still affected.
Even new reposts from today are not appearing.


issue updating on client machine?

i got this error Err when i try to get update of
http://<IP_ADDRESS> trusty/main amd64 Packages
404  Not Found
Ign http://<IP_ADDRESS> trusty/main Translation-en
W: Failed to fetch http://<IP_ADDRESS>/dists/trusty/main/binary-amd64/Packages  404  Not Found

I can't help you with that. There's not enough information.
Point your browser to http://<IP_ADDRESS>
See what you're serving and so on, what you've into apt-sources.

apt- sources file
deb http://<IP_ADDRESS>/ trusty main

I can't see what  http://<IP_ADDRESS>/ is, right?
You might have amd64 architecture missing there for example, there 1000s of reasons for this failure.

i cant see the repositoy which created but with aptly  show command i can see how i can create a sub dir for amd64 ?

If you have amd64 published, aptly publish list should show it for your published repositories.
Usually aptly guesses architectures correctly, but in case of problems you can always force architectures while publishing with -architectures flag.
Anyway, please try following some tutorial to try aptly in some simple scenario: http://www.aptly.info/tutorial/

ok

this is what aptly publish list showing
Published repositories:

./trusty [amd64] publishes {main: [ubuntu2]}

then amd64 is published,
next check contents of ~/.aptly/public, check that it matches contents of  http://<IP_ADDRESS>/ - it should match filesystem contents

i have made the .aptly file in the /var/www/html/ which is apache directory now .aptly/pulic has
dists pool var
cd .aptly/public/dists/trusty/main/binary-amd64 has
Packages  Packages.bz2  Packages.gz  Release
i think var is extra directory or not?

Filesystem view and "http" view should be the same.
Just try starting aptly serve to test it out, then fight with apache.


feat: add C implementation for math/base/special/cos

Description

What is the purpose of this pull request?

This pull request:

adds C implementation for math/base/special/cos.

Related Issues

Does this pull request have any related issues?

This pull request:

resolves a part of #649.

Questions

Any questions for reviewers of this pull request?

No.
Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

I have added the extended comment from the FreeBSD source in both the C and javascript implementations.
Checklist

Please ensure the following tasks are completed before submitting this pull request.

[x] Read, understood, and followed the contributing guidelines.

@stdlib-js/reviewers

@gunjjoshi Thank you, @gunjjoshi! Will merge shortly.

@kgryte I've made a new PR incorporating the changes at #2355.


openroad errors out with pin access check error in IO pad opening

Describe the bug
I use OpenLane + OpenROAD to create a pad ring using GF180MCU pad cells.
When getting into phase "26", the detailed router gets invoked.
The detail router errors out with pin access errors on the pad openings of the IO cells (pin PAD), that are also defined as the modules main inputs / outputs.
[ERROR DRT-0073] No access point for pad_din/PAD.
[ERROR DRT-0073] No access point for pad_dout/PAD.
[ERROR DRT-0073] No access point for pad_clk/PAD.
Error: droute.tcl, 38 DRT-0073
child process exited abnormally
A work-around is to mark the nets connected to the PAD pin and module inputs/outputs as "special net".
If these nets are marked "special nets", the detailed router continues without pin access errors.
Please find attached a test case (ipython notebook) that can be executed in Google Colab to reproduce the issue:
OpenRoad__invalid_pin_access_check_on_pads.ipynb.gz
/cc @proppy
/cc @dhaentz1
Expected Behavior
The detailed router should know by the pin type and by its connection to the module I/Os, that it should not try to route to the PAD pins, even w/o explicitly marking the nets connecting the PAD pins as "special nets".
OpenROAD Environment
Env.sh seems not to be included in my litex-hub package - please use the testcase notebook to extract data.

OpenLane Environment
env.py seems to be broken in my setup - please use the testcase notebook to extract data.

To Reproduce
_build.zip
Relevant log output
[STEP 26]
[INFO]: Running Detailed Routing (log: runs/RUN_2023.06.29_11.44.31/logs/routing/26-detailed.log)...
[ERROR]: during executing openroad script /content/eda/share/openlane/scripts/openroad/droute.tcl
[ERROR]: Log: runs/RUN_2023.06.29_11.44.31/logs/routing/26-detailed.log
[ERROR]: Last 10 lines:
[INFO DRT-0033] Via3 shape region query size = 2760.
[INFO DRT-0033] Metal4 shape region query size = 25741.
[INFO DRT-0033] Via4 shape region query size = 1506.
[INFO DRT-0033] Metal5 shape region query size = 13841.
[INFO DRT-0165] Start pin access.
[ERROR DRT-0073] No access point for pad_din/PAD.
[ERROR DRT-0073] No access point for pad_dout/PAD.
[ERROR DRT-0073] No access point for pad_clk/PAD.
Error: droute.tcl, 38 DRT-0073
child process exited abnormally

[ERROR]: Creating issue reproducible...

Screenshots
No response
Additional Context
No response

@chaufe
Attach issue_reproducible generated by the flow.
Given attachment is not valid test case.

What pin type are you seeing on the PAD pin?  I'm looking at a proprietary PDK that just uses SIGNAL.  If you use ICeWall it should mark these nets as special.

@vijayank88
I've added a _build.zip containing data created by  or_issue.py
@maliberty
The pin type is "SIGNAL", the pad is CLASS PAD AREAIO, but using CLASS PAD INPUT and CLASS PAD INOUT would give the same result. The I/O pads have already been instantiated in RTL, and only been placed using place_pad.

There is no reason for the router to assume it can't route a signal net to pad.

How would the router know if it should try to route to the pad or not?
As a user, I would expected the pad to be only connected by a bond wire, or - if available - by a redistribution layer to a bump.
Is there a special requirement OpenROAD has on the pad class or pin type so it would not try to route to the pad?

In general, unless a net is

Already routed
Marked as special
A supply net (power / ground)

The detail router will try to route it. The RDL router should be run before the detail router to ensure any pad / RDL connections have already been routed. I believe that RDL nets are generally marked as special, anyways.

@rovinski I agree with your points.
But I'm still wondering:

Why does the detail router stop when checking pin access? It could as well leave the net unconnected but report it as a routing error / open net.
Why does the net connected to the pad opening not get marked as a special net? (i.e. when calling place_pad) Of cause, this can be done by user code, but for most users switching from proprietary tool flows, this is at least a very unexpected task to do.

I also think the issue has been introduced earlier this year. Earlier versions of OpenROAD would not complain about pin access on the pad opening even if the IO pad cells were just placed using the macro config file.

Why does the detail router stop when checking pin access?

I'm not sure; I believe it's mostly a design decision. The latter parts of the routing algorithm depend on having valid pin access points and so not finding any valid access points will lead to more trouble down the line.

It could as well leave the net unconnected but report it as a routing error / open net.

I think we mostly abide by the philosophy of "fail early". It is a common problem among EDA tools that errors are lost in the noise, and then your job runs for hours or days without any hope that it will complete successfully. OR tries to detect problems early and error if there is no hope of a good solution.

Why does the net connected to the pad opening not get marked as a special net?

I am not well-versed in the OpenLane flow, I mostly work with ORFS. Does OpenLane perform RDL routing for gf180? The PAD tool I believe marks the RDL nets as special nets. Otherwise, the nets have to be marked as special by the user. OR will never try to infer a net as special; it has to be explicit. I believe this is consistent with commercial tools.

For my case, this is an IO cell with bond pad, so no RDL routing is involved.
(An I think there is no RDL in that PDK / metal stack)
I still believe setting this net to special should be done inside place_pad.
Knowing the instance to be of CLASS PAD AREA_IO, having one of its pins being a top-level port, and being placed by place_pad (plus maybe a pin size check) should suffice for a good guess to decide if a net needs to be a special net that is not intended to be routed by drt.
In my experience with commercial tools, I never had to mark IO nets special.

Is the pin directly on the pad and the pad is either contained by the I/O cell or connected by abutment? If so I can see where the problem might come in. The pin access check is done before any abutment checks, so the pin access check doesn't know whether a pin is abutting and it can ignore the pin access check.

In my experience with commercial tools, I never had to mark IO nets special.

In all likelihood the nets did get handled by the detailed router but sometimes the tools are smart enough to recognize abutted pins. I have seen cases in both of the major P&R tools where abutted I/O pins were handled well and not well when forgetting to annotate them as special nets.

place_bondpad will mark the associated net as special.  place_pad does not as it is simply placing the IO.  Are you using the former?

I'm using place_pad, as the bond pad is already part of the I/O cells for gf180mcuC I/Os.
There is no extra bond pad master inside gf180mcuC I/O IP.

@gadfort any thoughts on this case with integrated bond pad?

@maliberty probably needs a modification to ICeWall to indicate that the wirebond cells are integrated. I can take a look, but a runnable testcase would be very helpful. Are the ones attached working?

I haven't tried.

@chaufe @maliberty is this still an issue?

@chaufe reopen if still relevant.


adguardhome: misleading assertion message

https://github.com/NixOS/nixpkgs/blob/9b5328b7f761a7bbdc0e332ac4cf076a3eedb89b/nixos/modules/services/networking/adguardhome.nix#L143
Should be settings.bind_port (copy paste error)

In the meanwhile this has changed again, and bind_host and bind_port are only valid up to v0.107.33. Since v0.107.36 the correct configuration is via settings.http.address (see the AdguardHome Wiki for more information)


Where do you separate Train/Val data?

According to the paper, you mentioned 70% data for training and 30% for testing. However, I cannot find you data separation in your code. It seems to me that you are testing using training data. Please clarify if I miss something.

Split is encoded when creating the dataset at https://github.com/danfeiX/scene-graph-TF-release/blob/master/data_tools/vg_to_roidb.py#L586


Coordinate constructor Lat/Lon

Hey there,
new to your repo and testing your demo right now.
Can you explain me, why i have to set Lat and Lon at the Coordinate-constructor like this to get Frankfurt on the map:
Demo:

G-Maps:

If i dont get it wrong then the Coordinate-constructor binding the parameters to the wrong attributes:

I saw your Major Changes note at your readme, but im still a bit confused. Maybe you can help me back on track. Thanks in advance.
Best regards

You are right. X = Longitude, Y = Latitude.

It's fixed in latest 1.5.4. Please check.

Thank you very much! Unfortunately im still working with .Net 6. I can only use version 1.5.0, but I will update to .Net 8 in the future and after that im able to test your new version.
Take care!
Best regards

That would be appreciated, if you got time to support .net 6 again! I could upgrade to your latest version and it would be awesome for other .net 6 users too.


Advance to "Update DBConnection" commit from 9 Jan 2016.

Coverage increased (+0.1%) to 87.052% when pulling d5bb2939abe905228426f6cfd12bd94728f7681f on db-connection-0.1.8 into 9759d104980ceef0962dc7861627d10c890362f3 on master.


[FIX] Fix broken azure_auth test

This PR addresses the error that was thrown when trying to run the test_get_token_provider_from_default_azure_credential test. This error arose as a result of changes in azure-identity version 1.18 which introduced a get_token_info method which returns an AccessTokenInfo object. The get_token_info method is an alternative method to the previously existing get_token "that improves support for more complex authentication scenarios" and is the default for authentication aside from when the credential object does not have the get_token_info attribute. Thus, the unit tests now mock hasattr for 'get_token_info' arg.
This PR adds unit tests to use both the get_token and get_token_info methods when calling get_token_provider_from_default_azure_credential to connect to an AOAI endpoint.
Also, instances of Mock are changed to MagicMock.

Looks good to me. @rdheekonda do you have thoughts on increasing the lower bound on azure-identity?

Thanks for the fix, @jsong468. Could you confirm that this works with latest version azure-identity 1.19.0?


null check seems unnecessary

consider this object
const company = {
 addresses: 'aaa'
 contacts: Contact[];
 createdAt: 'some date;
 deletedAt: null;  //this is null!!!
 id: 111;
}

i have a mape like this (deletedAt and createdAt are stripped off)
const map= {
 addresses: 'aaa'
 contacts: Contact[];
 id: 111;
}

then I get deletedAt, although it is not in the map.
I feel like the code here should not check for the null case, if there is no other need for that:
const reducer = (input, map, options) => {
savedOpts = options || savedOpts || {}
Object.keys(input).forEach(function (key) {
if (input[key] !== null) {
innerCompare(input[key], map[key], input, key)
}
})
return input
}

What is the input map?

Additionally there is:  https://www.npmjs.com/package/object-reduce-by-map#example-use
// Pass options
const calculatedWithOptions = objectReduceByMap(input, map, {
  keepKeys: true,
  throwErrorOnAlien: true
})

This will retain keys with null value... however (and at this point neither solution seems accurate) what is better for a documentation driven API output... truly open ended question i don't know which is the correct answer.

with the objects above, company and map,
what I get as the result is
const reducedObject = {
 addresses: 'aaa'
  deletedAt: null;  //this is null!!!
 id: 111;
}

The problem is that, I get deletedAt, even if it is not in the map. So, the problem is not keeping the null properties, on the contrary, stripping them from the result.

that is the input object @atillabaspinar
what is the input map?

yeah, maybe the destinction here is null and undefined
undefined is a horrible thing. if a key's value is undefined, that just means it does not exist - in js(on) terms, { key: undefined } is meaningless, as that's just { }
in the case of null, that's the explicit setting to a non-value, or unsetting. It's basically every other languages version of undefined. IMO, you should never write the word undefined anywhere in the code base - you can always do the same thing without actually writing it
So if what keepKeys does is add undefined keys for everything in the map, but ignore null when it's false, then there may be a way to deal with this. undefined and null shouldn't be treated the same

@johndcarmichael
the map, i had wrote above:
const map= {
 addresses: 'aaa'
 contacts: Contact[];
 id: 111;
}

ahhhh sorry i think i misread the original post - ok i get the issue now.. yea that should not happen

it has been a while since i wrote that code - but i think this area could likely be the culprit:
https://github.com/johndcarmichael/object-reduce-by-map/blob/master/src/reducer.js#L57
this is where the attribute is removed and looks like the condition needs extending.

or can it be this line?
https://github.com/johndcarmichael/object-reduce-by-map/blob/6a7806ce57603bc13b711fab9fca221ebcf14930/src/reducer.js#L92
if (input[key] !== null)
So if we have user = { name: null}  then 'name'  is removed from the output. It is not undefined but null here.
I am not sure why there is check at line 92, but maybe it should be like,
if (input[key] !== undefined)

Maybes - but have a go at tweaking those conditions; the are i pointed to and the area you pointed to.
There are tests written  but i seems that this condition was not accounted for.

@atillabaspinar  i think this rc release solves the issue.


Cucumber executable should be in bin folder under Rails 4

I did a
rails generate cucumber:install
on a new Rails 4 project today and noticed that the cucumber file was still placed in the script folder.
My understanding is that the script folder is no longer utilised for Rails 4 and all "executables" are now stored in the bin folder (with rake, rails and bundle).
So shouldn't the generator now be placing the cucumber executable in the bin folder?
ruby 2.0.0p353
rails 4.0.3
cucumber 1.3.10
cucumber-rails 1.4.0
OS Win64

So what's the status for this issue? When I'm on Rails 4 can I just manually remove script/cucumber and replace it with the bin/cucumber from https://github.com/dnrce/tracks/blob/7d7e47deffe6e0c628ccaa6f910750fab8040370/bin/cucumber? (Yes, I'm using Spring)

@vindia there was no progress on this. If you would like to do a PR you're more than welcome :-)

@vindia i think you can have a look at this one if you want: https://github.com/cucumber/cucumber-rails/pull/314

@Kosmas Thanks! From #314 I get that the entire file is not needed at all, right?

@vindia not quite sure if that is the case but you can have a play around to see if it works. Have also a look at the comment that @tooky left about rspec-rails.

Rails 5 doesn't use the script folder too.

As this repo hasn't integrated the stale/lockbot. I'm going to close this issue off, given the majority of stuff Mentioned is several versions out of date and we've also began to drop support for older rails / ruby versions in cucumber-rails
If the OP still has an issue with an up to date version of the gem and rails then feel free to open a new issue


istioctl should install Gateway API CRDs for you

Describe the feature request
istioctl precheck should check for the correct version of the Gateway API CRDs for you, and (optionally) istioctl install should install them for you.
Describe alternatives you've considered
Make everyone read an awkward warning on every page of istio.io.
Affected product area (please put an X in all that apply)
[x] Ambient
[x] Docs
[x] User Experience

Check SGTM.
Install -- is there a meaningful difference between "make sure you install with istioctl install --include-gateway-crds" vs "install, then run kubectl apply crds.yaml"? Or is the expectation it would be on by default as well?
The tricky thing with the CRDs is Istio doesn't own them. There are many versions, variants (experimental or not), and many implementations in the same cluster concurrently using them

Seems like we should at least consider a --install-if-not-found type of behavior to prevent trampling existing CRDs

is there a meaningful difference between X and Y

People seem to care about how many "steps" a "getting started" guide takes.  Given we have our own utility that does the installation, I'd love to get as much as practical into that.  (For example, I'm also checking if we can have it handle addons.)

Addon removal was intentional: https://docs.google.com/document/d/1jJ4kkALCUPWIlz_Ldu6jpeelMNxyY_SZDMaZmeSpfkM/edit#heading=h.qlmnvhzb2ib2

if we want a kitchen-sink playground to install in 1 step we can do something like https://github.com/csantanapr/knative-kind

I do remember that.
Part of the reasoning behind the question was @peterj's comment that with other tools, you only need the client binary to get going, and you get a lot more in the download for Istio.
I don't like how we're judged, but if there are simple things we can do to improve the process, I'd love to consider them.

Not sure who's maintaining it, but there's a Homebrew package for Istio CLI. Using that gets rid of a couple of steps in the installation (download the package, it creates a folder for you, copy/move the istioctl binary somewhere, put it in the path etc.).
However, if you've installed the CLI with brew you don't have any of the addon YAML files. Pointing users to install or download the YAMLs files from github URLs doesn't look pretty. My thinking was if we'd embed the Grafana/Jaeger/Kiali manifests into the istioctl binary and add a subcommand that installs those either individually or as part of some demo installation:
istioctl install --set profile=demo -y
..
istioctl addons prometheus install
istioctl addons grafana install
..

(Or just have the istioctl command download them from GitHub URLs)

istioctl precheck should check for the correct version of the Gateway API CRDs for you, and (optionally) istioctl install should install them for you.

+1 to this and other's comments about installing the Gateway API CRDs if not found. That would be pretty helpful imo.


dapr  fail to init Kubernetes in limited network

I used the new installer-bundle and download the bits , extract the bits and called :dapr init for self hosting , and its worked fine , thank you.
Now I wanted to  : dapr init -k it on my local Kubernetes (Tanzu by VMWare)  and getting this errors:
dapr init -k
Making the jump to hyperspace...
Note: To install Dapr using Helm, see here: https://docs.dapr.io/getting-started/install-dapr-kubernetes/#install-with-helm-advanced
Deploying the Dapr control plane to your cluster...
looks like "https://dapr.github.io/helm-charts" is not a valid chart repository or cannot be reached: Get "https://dapr.github.io/helm-charts/index.yaml": dial tcp <IP_ADDRESS>:443: connectex: A connection attempt failed because the connected party did not properly respond after a period of time, or established connection failed because connected host has failed to respond.

Is there a way to get the Helm-charts Locally ?
Can this be part of the installer-bundle ?
How can init dapr control plane on Kubernetes , from local files on local Helm Repository ?

Hope there is easy solution ?

Merge this to
https://github.com/dapr/cli/pull/895#issue-1139602197

Duplicate of #https://github.com/dapr/cli/pull/895#issue-1139602197

Duplicate of #dapr/cli#895 (comment)

@shaibarlev That PR has been triaged for 1.8 release ...

Thanks @mukundansundar .
Is there a workaround to make this work via manual steps now , before its hit 1.8 ?

Duplicate of https://github.com/dapr/installer-bundle/issues/8#issuecomment-1168801047

Closing due to no activity


Use virtual service accounts instead of local accounts

Virtual service accounts have several advantages over regular local accounts:

no passwords!
no separate creation step required

It would be great if this article could be updated to recommend or at least mention their use.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: b0bd8cb8-7e28-8c4d-a550-3aea8f3ab4dd
Version Independent ID: 4b60d24e-ef05-15e5-10b4-483094081bf3
Content: Host ASP.NET Core in a Windows Service
Content Source: aspnetcore/host-and-deploy/windows-service.md
Product: aspnet-core
Technology: aspnetcore-hostdeploy
GitHub Login: @guardrex
Microsoft Alias: riande

Moved to Master issue, look here first. #18118

@Rick-Anderson ... Closing this one. The topic already cross-links to the correct coverage for Group Managed Service Accounts on Line 133 of the topic. I recommend that we let devs use this approach :skull: at their own risk :skull: given that (IIRC) these types of accounts use the computer account to run the service.


Gets absolutely all paragraphs in document (no matter what object the…

…y are nested in or how deeply) to process them. This commit also reduces dependency on the co-ordinates processing, which I don't believe you actually need.

Sounds and looks reasonable.
I'll just investigate a bit into why those coordinates where introduced in the first place before merging, in case.

Okay, coordinates seems to be a leftover froma old implentation in POI instead of docx4j


Update figures section exercises

Final changes to this plotting section

Opps. It is a bit late. I'll open PR.


Support JP2 images

Sometimes JPEG images carry the image/jp2 MIME type (JPEG2000 encoding). ImageMagick supports this if it has the correct delegates compiled.

Is there a reason this isn't getting merged in?


Getting a 404 for a link in the docs in 'Statistics Overview'

This is about the link 'API Statistics Overview' in Statistics Overview
Expected content
link to API statistics overview.
Actual content
404
Link to page: Statistics Overview](https://sendgrid.com/docs/ui/analytics-and-reporting/stats-overview/

Hi @pavan-kalyan ,
I'm sorry you struggled with this issue, but we really appreciate the feedback! We've added this to our internal docs backlog and will hopefully get it resolved shortly.
Twilio SendGrid Docs Team


Restructure the "Evaluating models" documentation page and rename this page to "Testing models"

Proposed changes:

Make information about conversation tests the first thing on this page
Make sure this information is correct (especially after all the variable names changes)
Rename the page to “Testing models”
Add a link to a dedicated forum category (because we expect people to ask more questions about testing)

Status (please check what you already did):

[x] updated the documentation
[x] updated the changelog (please check changelog for instructions)

@alwx what is the reason behind the strict use of testing over evaluation btw? "Evaluating a model" is super common terminology. cc @TyDunn

also i still want to review, so please don't merge before that :D

@alwx also which issue does this cover? Is this one still relevant to do then? https://github.com/RasaHQ/rasa-x/issues/2239

@akelad it's this one: https://github.com/RasaHQ/rasa-x/issues/2237

@akelad @alwx I think the general idea is that we wanted to shift the high level language to "test your assistant", but I was in favor of keep the word "evaluate" around when it made sense (e.g. "model evaluation"). I expressed this opinion in this issue as well: https://github.com/RasaHQ/rasa-x/issues/2239

ok i will request some changes then :D

I guess this one should potentially also go in: https://github.com/RasaHQ/rasa/pull/5467/files


Unable to Use C Style Arrays

Hello, I am currently playing around with blobify and I noticed that using a C arrays causes errors to appear (error.log). Here is an example below:
struct headerSFAT {
    char indentifier[4];
    uint16_t length;
    uint16_t byteOrder;
    uint32_t fileSize;
    uint32_t dataOffset;
    uint16_t versionNumber;
    uint16_t reserved;
};

I was wondering if this is normal or not?

If there was a reason not to support C-array members, I can't remember it anymore.
As you probably noticed, std::array members are supported, since they are special-cased in load.hpp. A similar check could be added for C-style arrays.


RequestAuthorizer mentioned in readme doesn't exist

I see RequestAuthorizer mentioned in the generated readme at https://github.com/yonaskolb/SwagGen/blob/master/Templates/Swift/README.md, however it doesn't actually exist in the generated code. Is the readme just out of date?

The readme is indeed out of date. The RequestAuthorizer has been replaced with RequestBehaviour.validate which allows you to do the same thing - asynchronously modify the request or fail


Correction for raw affiliation Department of Biochemistry, Western University

Correction needed for raw affiliation Department of Biochemistry, Western University
raw_affiliation_name: Department of Biochemistry, Western University
new_rors: 02grkyz14
previous_rors: 02agqkc58
works_examples: W4387966939;W4389625833;W4389365395
contact: 50f32d411ad432de23f54cfb4f807210:2c25e21bbd277138 @ uwo.ca

This issue was accepted and ingested by the OpenAlex team on 2024-12-19. The new affiliations should be visible within the next 7 days.


Bot connection issues

Everytime a player does "/startdiscordvoicechat" the bot will join the voice channel, but will continuously leave and join over and over.

please send logs

please send logs

I would but there isn't much to send. Here's my latest.log.
https://mclo.gs/0BzglbP

I'll ask if any simple voice chat updates will have broken it. I'm currently occupied with other projects, but if I'm not busy, I can continue working on 1.5.0 and investigating the issues next weekend.

Can also confirm this issue.
Here's my latest.log: https://mclo.gs/xxlNEWU

I also have this bug, if you plan on fixing this bug and haven't been able to recreate it I can give you access to my linux ubuntu

I also have this bug, if you plan on fixing this bug and haven't been able to recreate it I can give you access to my linux ubuntu

Don't worry they know already

Closing this for now as it's known by the dev. Please refer to https://github.com/naturecodevoid/voicechat-discord/issues/12 for more insight.

why would you close it? it's not fixed yet

why would you close it? it's not fixed yet

Good point, just remembered it disappears if it is closed. My bad!

This is an SSL issue that occurs JDA tries to connect to Discord through WebSocket. Here are some ways you might be able to solve it:

Make sure you have updated Java. If the issue still persists, try installing Java from https://adoptium.net. If this still doesn't fix the issue, try installing a Java build from another vendor. (If you find one that works for you, please comment here with a link!)

If you are on Simple Voice Chat Discord Bridge 1.5.0 or higher, add this to the command you use to start the server: -Djda.disablessl=true. This must go before the -jar part. Example: java -Djda.disablessl=true -jar server.jar

Let me know if this helps anyone.

Note: it may also be a JDA bug. In this case, you won’t be able to fix it without me updating the mod. Until then, you can try a nightly build: https://github.com/naturecodevoid/voicechat-discord/actions/workflows/nightly.yml. However, nightly builds may be extremely buggy! Use at your own risk.
This seems to be an SSL issue that occurs JDA tries to connect to Discord through WebSocket. Here are some ways you might be able to solve it:
1. Make sure you have updated Java. If the issue still persists, try installing Java from https://adoptium.net. If this still doesn't fix the issue, try installing a Java build from another vendor. (If you find one that works for you, please comment here with a link!)

2. If you are on Simple Voice Chat Discord Bridge 1.5.0 or higher (or using a recent nightly build), add this to the command you use to start the server: `-Djda.disablessl=true`. **This must go before the `-jar` part.** Example: `java -Djda.disablessl=true -jar server.jar`

Let me know if this helps anyone.

No luck sadly. Nightly builds don't seem to work, although with a different issue. (See #18)

I also have the same issue

How do I do the 2nd fix if i use a hosting service like ploudOS?

This issue still exists in the latest version 2.1.1.
All solutions in this thread doesn't fix it.

I confirm this problem, all methods from this issue dont help

A 3.0.0 beta build that fixes this is available at https://github.com/naturecodevoid/voicechat-discord/actions/runs/9744638041

3.0.0 is now out, which fixes this issue.
Paper/Purpur: https://modrinth.com/plugin/simple-voice-chat-discord-bridge/version/3.0.0
Fabric: https://modrinth.com/plugin/simple-voice-chat-discord-bridge/version/zQYUpUdg


Wrong Designing and Overlapping Issue

Description
The logo in the course page is overlapping with the navbar due to improper styling. needs to be readressed well.

Steps to Reproduce
go to https://ml-fusion-lab.netlify.app/pages/course_details.html?courseId=course_1
Expected Behavior
This should not be overlapping
Actual Behavior
No response
Screenshots

Additional Information
No response
What browser are you seeing the problem on?

[ ] Firefox
[ ] Chrome
[ ] Safari
[ ] Microsoft Edge

Checklist

[X] I have checked the existing issues
[X] I have read the Contributing Guidelines
[X] I want to work on this issue. (optional)

Please assign me this issue as I have understood and fixed it locally.

/assign

@AkshatSharma5 make sure to complete this.


shared code list

Firebase Helpers

[ ] ts, arrayUnion, etc
[ ] getDocument, getDocumentsInCollection
[ ] batch

Queries

[ ] friends

Typescript

[ ] definitions!


Enhance the Harbor CRD

Expose more configuration options:
# log configurations
log:
  level: debug

# set proxy
proxy:
  http_proxy: <IP_ADDRESS>
  https_proxy: <IP_ADDRESS>
  no_proxy: <IP_ADDRESS>
    components:
    - core
    - jobservice
    - clair

Use harbor version and a unified registry to define the images of Harbor components:
# source registry of images
imageSource:
  registry: harbor.com
  imagePullSecrets:
   - pSecret

work has been done, close this issue now.


Can't XCM Transfer of the Bifrost Chain

improve issue: https://github.com/Koniverse/SubWallet-Extension/issues/35
Description the bug
Can not XCM transfer of the Bifrost Chain & not display transaction history
To reproduce
Steps:

Open the extension
Go to the XCM Transfer screen
Perform transfer of the Bifrost Chain
Actual: Send Fund failed (see file attachment below) & do not display transaction history above although Bifrost have support xcBNC

Version test: https://file.cdmteck.com/s/4oimk9zDJ8R5Aai/download?path=%2F&files=./543-merge-build-0.5.5-1660291942887.zip
Please check:

[ ] Double check some issues when user send 0

[ ] Can't send KAR from Bifrost -> Karura
Actual:

Can't send KAR

Transaction history incorrect

[ ] Can't send KSM

Can't send KSM

Transaction history incorrect

Validation passed!

Version test: https://file.cdmteck.com/s/4oimk9zDJ8R5Aai/download?path=%2F&files=./543-merge-build-0.5.5-1660623430987.zip

File record validation:
333_Validation.zip


fix monitor-xdrip

Local (offline) looping hasn't been working on my rig since the latest update from dev. Turns out the script is called from crontab with extension .sh (monitor-xdrip.sh), which cannot be found. This commit removes the filename extension in consistency with other bash scripts called from crontab.
Note: this fix requires re-running oref0-setup.sh.

I'd noticed an error in mine, but figured it was being caused by something else. I ended up copying /src/ore0/bin/monitor-xdrip.sh into my myopenaps folder. This seems more like the proper way to fix it!
Tested your the fix, and confirmed that it works. @scottleibrand can we still get this into 0.5.3?

Yes, this kind of bug fix is very appropriate for 0.5.3.  Good catch: thanks for the fix and to both of you for testing it promptly.