Common Core Framework

Something I've been doing recently with the company I cofounded, is creating a common core application that runs our primary code. It handles initial server setup, ble wifi credential setting (improv-wifi spec), barebones/basic MQTT connection to home assistant, ota updates, etc. I wonder if it doesn't potentially make sense to create a stripped-down version to offer users to build from in xs-dev, that gives them some core features pre-programmed, an interface to interact with, and some compartments/mod options to extend the core app?
I imagine there are some common use cases (wifi onboarding was one for us) that pop up, some devs might like a framework with prebuilt features to start from.

There are probably a few ways to go about this idea. The common core could be installed as a third-party module (see this new proposal #49) and instantiated by the project. Or it could be part of a starter template, similar to how Moddable examples can be used to initialize new projects.
The first option makes it easy to provide upgrades to consumers of this common core feature set, while the latter gets them up and running quicker through a pre-configured host with separate project main.
How would you think about distributing such a thing without bundling it directly into xs-dev?

I've narrowed it down to a handful of things i think most users may want.

A way to "register" sensor readings and values, to sync with mqtt/home assistant out of the box
A simple HTTP server that registers a local domain, serves a simple visualization to send HTML page, probably served via cdn
A simple way of onboarding wifi credentials (esp32 i have ble implementation using improv-wifi) out of the box
Out of the box OTA support, UI

Numbers 1-3, i have a good working knowledge of how to solve and expose via a common host file, number 4 is upcoming on a project of mine but i haven't dug into it a ton.


Provide authenticated_keys for SSH access to docker container

Provide authenticated_keys for SSH access to docker container

See https://github.com/exasol/exasol-testcontainers/issues/202


add GitHub URL for PyPi

Warehouse now uses the project_urls provided to display links in the sidebar on this screen, as well as including them in API responses to help the automation tool find the source code for Requests.
Example: pypi.org/pypi/requests/json
Docs: packaging.python.org/en/latest/guides/distributing-packages-using-setuptools/#project-urls

this package is not recommended anymore so I don't see any usage of this PR for now.


[Validator Badge] Celo.Works 0x3C86b6A27a074c1c4CC904d8808A1C33078DB4E6

[Validator Badge] Celo.Works claiming validator badge

@david-trustworks can you update the branch?

@bohan-zhang Done 👍


Create a StackOverflow tag

There's no so tag for this project yet.

The tag quill  was taken by another project.
We'd probally take another tag like quill-sql  or something else
@getquill/maintainers

maybe quill-scala?

quill-persistence, quill-db ?

Quill is intended to be used with other target languages, not only for sql/databases/persistence. For example, it could generate GraphQL queries. That's why I voted for quill-scala, wdyt?

quill-lang, quill-dsl ?

There is quill.io tag. But quill.io domain is owned by https://github.com/ekryski and I suppose that it's for quilljs/quill though it already has quilljs.com. Maybe if @ekryski does not need quill.io anymore then he could transfer it to @fwbrasil.
I agree that @fwbrasil about quill-scala because it's common practice to append or prepend name of platform, OS or language to tag in case of such collisions.

@mxl not related at all and we're not transferring as we have something planned for it that is coming soon. 😄

@ekryski Thanks for the answer! I was just curious :wink:

@MateuszKubuszok was kind enough to create it: https://stackoverflow.com/questions/tagged/quill-scala
I think the ticket can be closed now.

thank you @Krever @MateuszKubuszok


Gentler subprocess termination, for windows

As a follow-up to #857, we want to make subprocess termination a little more selective/gentler on Windows, too.
@mattn and @ChrisHines had a bunch of thoughts, already, but I wanted to move that discussion to an issue here, so that that PR can focus on getting the UNIX support done. Here's my attempt to summarize those thoughts:

Invoke taskkill:

exec.Command("taskkill", "/F", "/T", "/PID", fmt.Sprint(cmd.Process.Pid)).Run()

Recursive TerminateProcess on the process subtree
Windows Job Objects, perhaps by reusing @alexbrainman's ps library

I suggest to use alex's ps package.

I wrote a package called graceful that will hopefully work well for you.
It's based on a solution to the same problem used in git-for-windows that issues an ExitProcess() call within the target process. My understanding is that the git-for-windows client will trap this action and execute a controlled cleanup.
I don't have any knowledge of how other version control systems will handle the intrusion, but I expect it will still be preferable to calling TerminateProcess().

@JoshuaSjoding iiiinteresting. yeah, all we can really hope for here is incremental improvement over the current conditions.
any interest in making a PR? 😄

I do not know what the problem is that you are trying to fix in this current issue. I looked at issue #823, and it is about dep taking long time to complete - 20 minutes long. It should not take 20 minutes for git to copy even large repo, so I suspect some state is corrupted. If it is something that git manages, how can you prevent this from happening? On the other hand @sdboyer says (here https://github.com/golang/dep/pull/857): "I think git is quite careful to ensure it cleans up after itself - possibly even incrementally, so that progress is saved?". So, I take it, you hope that git is OK to be killed by Windows TerminateThread. There might be undoubtedly be some child processes left, and they might interfere with new git process trying to redo all interrupted work again. But issue #823 is not even for Windows. So I am not even convinced you have Windows issue to fix. Do you have more information to add to this issue? Do you have a repro that I can run here?
It is, probably, OK to use github.com/gentlemanautomaton/graceful instead of calling Windows TerminateThread (that is what you do now). But github.com/gentlemanautomaton/graceful just calls Windows ExitProcess, and ExitProcess will run more of "my process is stopping" code than TerminateThread. You can read ExitProcess doco - https://msdn.microsoft.com/en-us/library/windows/desktop/ms682658(v=vs.85).aspx that explains what ExitProcess does, but you still cannot be sure that it will run the code you need - the code that saves state to the disk. Maybe ExitProcess will handle child processes better than TerminateThread, but maybe it won't. So, perhaps, it is good idea to implement killing of all Git children too. you can use Windows Job Objects as suggested by @ChrisHines or you could just use something like https://github.com/mattn/psutil/blob/master/psutil_windows.go#L53 as suggested by @mattn. The second approach would be more error prone, because it is racy.
I can implement whatever you decide, but it would be nice if we had some Windows repro before we try and fix this. Please, let me know if you want me to do something here.
Alex

hi Alex, thanks for coming by!

I do not know what the problem is that you are trying to fix in this current issue.

this issue is best understood as me, probably unwisely, extrapolating from a fix we needed to make on the UNIXish side: i had written subprocess termination code that relied on os.Process.Kill() without parameterizing per platform. this would be triggered by a Ctrl-C, and was resulting in numerous git repositories that were mid-clone becoming corrupted in unpredictable ways.
#857 was my fix for non-Windows platforms, shifting to sending os.Interrupt signals with a timer-based fallback to Process.Kill(). but Windows retained the same Process.Kill() semantics as before.
my goal with this issue is just to try to narrow the window of possibility that an attempt to terminate dep processes early on windows could lead to corrupted cache items. my criteria for evaluating whether or not a change here is worth making is whether it reliably achieves that goal, without introducing other problems.
but it's worth noting that:

it would be nice if we had some Windows repro before we try and fix this.

it does not appear that this is a problem our windows users have encountered yet - at least, judging from bug reports. so it may be best to let it sit? i don't know. this is my essential problem - i lack the experience with windows to know what the overall least-risky path is here.

#857 was my fix for non-Windows platforms, shifting to sending os.Interrupt signals with a timer-based fallback to Process.Kill(). but Windows retained the same Process.Kill() semantics as before.

Yes. You replaced os.Process.Kill() call with os.Process.Signal(os.Interrupt) in the hope that the process that gets killed will be able to run some "clean up" code from its os.Interrupt handler. Unfortunately there is no such mechanism on Windows - Windows process (in general) does not have a way to say to OS to run some code before it gets killed. So, unless Git provides some instructions about this, I don't think you can do anything useful.

it does not appear that this is a problem our windows users have encountered yet - at least, judging from bug reports. so it may be best to let it sit?

I would wait for reports. On Windows you cannot delete files or directories, if some process have them opened. So I suspect you will know quickly if you leave some external processes hanging.
I say don't change things, because you might make things worse. For example, at this moment only main Git process gets killed via TerminateProcess, all other children of his (hopefully) exit themselves for one reason or the other. But if you introduce Windows Job Objects, the way to kill whole process tree is to call TerminateJobObject. But TerminateJobObject just "as if TerminateProcess were called for each process associated with the job". So now even child processes won't have even chance to exit properly.
Alex

cool, i'm good with that. thanks for your input - updating labels a bit accordingly 😄


A vulnerability assessment solution should be enabled on your virtual machines but policy does not target vmss

Hello,
If my understanding is correct, this page lists policies applicable to scalesets, however the policy linked for vulnerability assessment for example targets only virtual machine and so does not apply to scaleset.
Is it an error in the policy, the docs, or my understanding ? :)
Thanks !

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 520e01f9-2a9b-acf6-01a5-3a9233a373cb
Version Independent ID: d835791e-94b2-781b-6838-901ccea6ff33
Content: Azure security baseline for Virtual Machine Scale Sets
Content Source: benchmark/azure/baselines/virtual-machine-scale-sets-security-baseline.md
Service: virtual-machine-scale-sets
GitHub Login: @msmbaldwin
Microsoft Alias: mbaldwin

@EmiFlo
Thanks for the feedback! I have assigned the issue to content author to check and update the document as appropriate.

@msmbaldwin
Can you please check and add your comments on this doc update request as applicable.


Support case insensitive .wav extension.

I came across some files using .WAV as an extension. on Linux this is reasonably straight forward to fix but on other OS's it might be much harder, it wouldn't supprise me if .Wav also exists so it would be good to support all these.

great point @simotek 👍🏻
I'm actually doing some work in this part of the codebase so I'll change it to make the extension check be case insensitive.


5.1.3 is not available on nuget

Prerequisites

[X] I have searched for duplicate or closed feature requests
[X] I have read the contributing guidelines

Proposal
Release 5.1.3 to nuget.
Motivation and context
If this is not the right place to report this, please let me know where I should report it.
5.1.2 is the latest available version on nuget. However, I can't use 5.1.2 due to a bug that was fixed in 5.1.3.

It literally was just released as I wrote this comment. Thanks!


fix: Fix tests/util/util_spec.lua accessing undefined variable Util

fix: Fix tests/util/util_spec.lua accessing undefined variable Util
Signed-off-by: Edmond<EMAIL_ADDRESS>

@Edmond-J-A Not complete enough, please fix .

@rushitote

@Edmond-J-A don't flood so many commits:

@Edmond-J-A ideally contains only one single commit

@Edmond-J-A fix:


Replace link to gitter chat with freenode webchat

Not sure about fetching the badge from https://img.shields.io.
I guess we could also just put the svg inside the repo itself.

I think the linking is fine, one file less for us to manage. Thanks! :)


Add uninstall option to setup.py

As you might now, Cython can be installed from source using
python setup.py install
It would be nice if there would be a simple
python setup.py uninstall
option.

You can use pip install . and pip uninstall Cython instead. I don't think we should try to implement this ourselves.


Prefetch

Making prefetch available to be configured.
Reviewers

[x] @podviaznikov

Verified this on staging. Works as expected


Change network interface ip address

Hi guys,
someone knows if it's possible to change network interface ip address from <IP_ADDRESS> to another one?
The 172.18.0 subnet is already in use in my network.
Thanks

I think this question is more related to docker configuration. Not sure this is the best place to ask this question.


disable off-canvas menu

How can this bug be reproduced?

Step one
update v2.8 to v.2.9
Step two
Step three

What did you expect to happen?
Off-canvas menu is not displayed. The menu(links) seems to be displayed, but it seems to be the same color as the background color and it disappears.
I tried various css (.off-canvas, .menu> li> a etc.), but it has no effect at all.

I tried it with and without it too.
The code is the same as v 2.8.
Where should I change?
Please List the Following:

OS & version: macOS Sierra
Node version (node -v) [Node v4+ is required] :
The request is satisfied.
Foundation version (bower list) :
v6.3

Include Test Case (if applicable):
Give us a link to a CodePen or JSFiddle that recreates the issue.

CodePen with Foundation 6 and MotionUI
CodePen with Foundation 6, Flexbox grid and MotionUI

Hi, I know it's been a while, are you still experiencing the same issue?
Did you update to the newest version of FP? If not, can you try it with the new version and tell us if you still have the same issue? Thanks!

@annrie
Unable to reproduce your error. The off-canvas menu is properly displayed on my dev environment. Your CodePen links are empty, so I can't verify the issue remotely. If you're still experiencing problems, please have a look in the devtools console and see if it throws any errors. Might be an issue with javascript not loading correctly on your setup. I will close this issue. Please reopen if this is still an issue on your end.


Manual Updates

Type: Feature Request
As a user when I select "Manual" as my update mode, I want to check to SEE if there are updates, AND MANUALLY apply them IF I CHOSE TO.
STEPS:
Click Settings icon
click Application
Find "Mode" dropdown
Select Manual
Click Settings icon
Click "Check for Updates"
When the check is complete you will see that a restart is needed to apply the update. However, since I know this update has a bug I don't want to apply it and there is, seemingly, no way to "cancel" applying this update.
VS Code version: Code 1.94.2 (384ff7382de624fb94dbaf6da11977bba1ecd427, 2024-10-09T16:08:44.566Z)
OS version: Windows_NT x64 10.0.22631
Modes:

What I'm hearing is you'd like a way to check the latest available version of VS Code from within VS Code.


Badges

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (c5c6136) to head (130a9be).

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff            @@
##              main        #2   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            8         8
  Lines          988       988
  Branches       103       103
=========================================
  Hits           988       988

Flag
Coverage Δ

unittests
100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Placement of power supply in enclosure

What has to be done
Must decide where the power supply (adapter) and power jack are to be placed in the enclosure.

must not interfere with pneumatic assembly
must include necessary mounting for adapter (which adapter?)
must have cut-out in the enclosure and secure mounting for power cable (or power jack?)

How do you know it has to be done
The v0.3 builds had no provision for any of this, and there was not even a way to run a power cable out of the enclosure without cutting additional holes in metal.
Code pointers
TODO
Don't forget

[ ] Put the issue in a milestone
[ ] Assign it to one of the projects
[ ] Add appropriate labels
[ ] Mention dependent/blocked issues if any

Blocked by #966 (selection of power supply)

Blocked by #966 (selection of power supply)

We want to keep the ventilator agnostic of the AC power grid, so it will internally be 12V. Thus, no power adapter is integrated into the unit. A selection of the external adapter is tracked in #966 and the enclosure should simply have a plug such as this:
https://www.digikey.com/en/products/detail/kycon-inc/KPJX-PM-4S/9990081

We want to keep the ventilator agnostic of the AC power grid, so it will internally be 12V. Thus, no power adapter is integrated into the unit. A selection of the external adapter is tracked in #966 and the enclosure should simply have a plug such as this:
https://www.digikey.com/en/products/detail/kycon-inc/KPJX-PM-4S/9990081

Mirror what was done on front. Acrylic back holding PCB/Battery can also mount switch/power connector. A cutout in the back plate allows access.

Mirror what was done on front. Acrylic back holding PCB/Battery can also mount switch/power connector. A cutout in the back plate allows access.

So, power supply itself is definitely external.
Having a connector on the enclosure is addressed in #1040


Cell counts

Hi! Lovely package. Apologies if its a bit of a silly question, but how do I just get the number or percent of each cells for each sample after deconvolution? I am using Nanostring GeoMX data on ROIs that were drawn (and are fairly big). I want to get the cell counts/percent cell type for each ROI.
I calculated here:
ad_map = tg.map_cells_to_space(
adata_sc,
adata_sp,
mode='clusters',
cluster_label='CellType')
Thanks!

Hi @spatts14 !
This is not a silly question in my opinion, as it is not evident from the tutorial. I am not a developer of the package, but I came up with a workaround.
from anndata import AnnData
from pandas import DataFrame

def get_tangram_predictions(adata: AnnData, perc=0, inplace=True) -> AnnData | DataFrame:
    tg_ct_pred = adata.obsm["tangram_ct_pred"]
    tg_ct_pred = tg_ct_pred.clip(
        tg_ct_pred.quantile(perc), tg_ct_pred.quantile(1 - perc), axis=1
    )
    tg_ct_pred = (tg_ct_pred - tg_ct_pred.min()) / (tg_ct_pred.max() - tg_ct_pred.min())

    df = DataFrame()
    df["tangram_prediction"] = tg_ct_pred.idxmax(axis=1)
    df["tangram_score"] = tg_ct_pred.apply(lambda x: max(x), axis=1)

    if inplace:
        adata.obs = adata.obs.join(df)
        return adata

    return df

This function is inspired by the construct_obs_plot function, which is hidden inside of the plot_cell_annotation_sc function, which plots the predicted annotations.
If you pass inplace=True, then the function will populate adata.obs with two new columns, called "tangram_prediction" and "tangram_score". Otherwise the function will return a dataframe with those columns.
Hope this helps,
Vasily

Thanks so much for your feedback! Sorry for the late response I somehow missed this. Really appreciate your detailed work around @tsvvas


PS: Consider use cases for returning unconnected segments

Currently we filter the returned segments for connectedness.
If the PS can't find a connected set of segments it might in some cases make sense to return unconnected segments. First we need to figure out potential cases and then we should decide if it makes sense to handle those.

This no longer applies to the new segfetcher logic (see #2454)


Add support for packer_build module

Add support for packer build module
PR Checklist

[x] I have updated the documentation accordingly.
[x] I have added tests to cover my changes.
[x] All new and existing tests passed.
[x] My code follows the code style of this project.
[x] I ran lint checks locally prior to submission.
[x] Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Description
Add packer_build variable to use the packer_build module added to terraform-azurerm-caf

Does this introduce a breaking change

[ ] YES
[x] NO

Testing

Thanks for your contribution to CAF @dimitrifc!

Is this in main?


K3S is crashing by running out of free inodes

Version:
k3s version v1.17.4+k3s1 (3eee8ac3)
K3s arguments:

server

Describe the bug
The server, running K3OS is running out of free inodes, and crashes. The issue seems to be the same as, or similar to, #1042
To Reproduce

Reboot
Run sysctl fs.file-nr
Run df -i
Run find / -xdev -printf '%h\n' | sort | uniq -c | sort -k 1 -n

Let the system run, without any workloads or modification for a day or two and check again; you'd see the number of open files has increased substantially.
When running the last command, on my single k3s node, the local-path-provisioner has the most files open; but, still this could be a side effect of the containerd/containerd#3949 bug that has resurfaced!
Expected behavior
Normal file usage
Actual behavior
System runs out of free inodes and crashes
Additional context / logs
df -i
/dev/loop0        9450   9450       0  100% /usr
none            485303    420  484883    1% /etc
tmpfs           485303   1688  483615    1% /run
tmpfs           485303      3  485300    1% /tmp
dev             248418   2184  246234    1% /dev
shm             485303      1  485302    1% /dev/shm
cgroup_root     485303     16  485287    1% /sys/fs/cgroup
shm             485303      1  485302    1% /run/k3s/containerd/io.containerd.grpc.v1.cri/sandboxes/9df614249ace9f598269b5b1eaf60cb32732c60ac2e7d159f95448689c30ae2e/shm
shm             485303      1  485302    1% /run/k3s/containerd/io.containerd.grpc.v1.cri/sandboxes/aed0ed03e3e79e84c1f9ddefb6d6873a36986945480e68cc58a38402f6833125/shm
shm             485303      1  485302    1% /run/k3s/containerd/io.containerd.grpc.v1.cri/sandboxes/eeabace49f51281d8db242d2a6930d3c6bb7aa6708880a3a4132aa3c30421dc0/shm
shm             485303      1  485302    1% /run/k3s/containerd/io.containerd.grpc.v1.cri/sandboxes/03e1426a31455376f168bb7e3d617bf881a299039ca7cae4a3301165c28d8022/shm
shm             485303      1  485302    1% /run/k3s/containerd/io.containerd.grpc.v1.cri/sandboxes/2fbe6b4aa6a5f930f7e5190aa1b0678a90e965a0906d6ee1b1e8a743917ad680/shm
overlay        1865344<PHONE_NUMBER>075    7% /run/k3s/containerd/io.containerd.runtime.v2.task/k8s.io/03e1426a31455376f168bb7e3d617bf881a299039ca7cae4a3301165c28d8022/rootfs
overlay        1865344<PHONE_NUMBER>075    7% /run/k3s/containerd/io.containerd.runtime.v2.task/k8s.io/eeabace49f51281d8db242d2a6930d3c6bb7aa6708880a3a4132aa3c30421dc0/rootfs
overlay        1865344<PHONE_NUMBER>075    7% /run/k3s/containerd/io.containerd.runtime.v2.task/k8s.io/aed0ed03e3e79e84c1f9ddefb6d6873a36986945480e68cc58a38402f6833125/rootfs
overlay        1865344<PHONE_NUMBER>075    7% /run/k3s/containerd/io.containerd.runtime.v2.task/k8s.io/9df614249ace9f598269b5b1eaf60cb32732c60ac2e7d159f95448689c30ae2e/rootfs
overlay        1865344<PHONE_NUMBER>075    7% /run/k3s/containerd/io.containerd.runtime.v2.task/k8s.io/2fbe6b4aa6a5f930f7e5190aa1b0678a90e965a0906d6ee1b1e8a743917ad680/rootfs
overlay        1865344<PHONE_NUMBER>075    7% /run/k3s/containerd/io.containerd.runtime.v2.task/k8s.io/0a69b70870c7f5b390a48a71f98a07ed0caf778fa5aeee5d98d9f07e1ead6d75/rootfs
overlay        1865344<PHONE_NUMBER>075    7% /run/k3s/containerd/io.containerd.runtime.v2.task/k8s.io/a03d4a3caacc6f27d8e8e74d8cc4d59a4b6e0aa4d5913d8f04f53f5dcd061df7/rootfs
overlay        1865344<PHONE_NUMBER>075    7% /run/k3s/containerd/io.containerd.runtime.v2.task/k8s.io/091c48a0ca458a64622ef067b0c95866fed75b648d3640c6f3ff18f26d9e5c0c/rootfs
shm             485303      1  485302    1% /run/k3s/containerd/io.containerd.grpc.v1.cri/sandboxes/69b9ea2a392a5d63ef943efd1dee8e2d7ad6bb6951955acdba08ed7371a7eb09/shm
overlay        1865344<PHONE_NUMBER>075    7% /run/k3s/containerd/io.containerd.runtime.v2.task/k8s.io/69b9ea2a392a5d63ef943efd1dee8e2d7ad6bb6951955acdba08ed7371a7eb09/rootfs
overlay        1865344<PHONE_NUMBER>075    7% /run/k3s/containerd/io.containerd.runtime.v2.task/k8s.io/5230d47f2d815220df871f679742eacef8cc70203abc06dfe2c0db4052057a47/rootfs
overlay        1865344<PHONE_NUMBER>075    7% /run/k3s/containerd/io.containerd.runtime.v2.task/k8s.io/ef584224314c6f445d5a0d04d8a564e5832b46ad5c81d4a91bd7c8fc0395887f/rootfs
overlay        1865344<PHONE_NUMBER>075    7% /run/k3s/containerd/io.containerd.runtime.v2.task/k8s.io/668b82418576a0a9945017889c2337d403373292d2ee77091052a8c72f80044e/rootfs
overlay        1865344<PHONE_NUMBER>075    7% /run/k3s/containerd/io.containerd.runtime.v2.task/k8s.io/2abd230e958d41a802c18e33c55e7a4542f346804f06f8cc6423c09573a5297b/rootfs
find / -xdev -printf '%h\n' | sort | uniq -c | sort -k 1 -n
open-files.txt

Since the last reboot, 3 days ago, with no workload added, except for what comes out of the box, this has been the stat of running sysctl fs.file-nr command:
1- day 1 after reboot - ~13,500
2- day 2 - ~148,000
3- day 3 - ~260,000

Inodes are managed by the filesystem; there's no such thing as a per-process inode limit. File descriptors belong to a process, are associated with an open file or socket, and can have a configurable limit. Are you running out of inodes or fds?

I don't think I've said k3s sets any limits there. What I've observed after letting the system-upgrade-controller upgrade the system, is that it works itself out of fds, as I don't think it's normal to see it consume around 100,000 per day; it exhausts the max set by k3os in about a week.
I also see the number of used inodes to be high; so, I don't know if it's the same issue manifesting itself in two ways, or if the issue is just fd exhaustion.
I wanted to point that out, so, it could be tested, hopefully, prior to the next release.

Thanks for reporting @masoudbahar! If local-path-provisioner seems to be the only thing that causes this then I am not sure it is a k3s issue, might be good to eliminate containerd and see if it is reproducible with docker, or if it is a probing bug in general outside of local-path-provisioner.

You mentioned both in the subject and description that you're running out of inodes, which would generally mean that you've filled the filesystem. The symptom you're describing sounds like file descriptor exhaustion, though.

@erikwilson, thanks for the suggestion. What I’m not sure about, and was hoping to get some feedback on, is that why containerd (which seems to be the chief offender) and local path provisioner (to a much lesser degree, but still substantial) have so many files open.
I can of course use docker to determine if containerd is causing the problem; however, considering that my work is focused on kubernetes, via k3s, on edge devices, docker would be the least desired option, considering its resource requirements.
I looked at replacing containerd with cr-io, but k3os makes it very difficult to accommodate customization without resorting to image customization, which isn’t very sustainable, and diverts the efforts from the core topics I’m trying to address on the application side.
Nonetheless, as a community member, appreciative of all the work that is put into these products, I wanted to report that a core component of k3s seems to be misbehaving.
@brandond, my apologies, but my intention was publishing what I’m seeing on the system, not causing confusion; maybe I could’ve chosen a better title; I’ll take that into account in the future.

@masoudbahar to be fair it does look like you are actually out of inodes on one of your partitions:
df -i
/dev/loop0 9450 9450 0 100% /usr

My understanding is that /usr on k3os is readonly, so that's probably expected. When the host crashes, what's the specific error message you get?

@brandond, I have an out of the box installation, as I’m working through the environment customization I need (scripts and such) before I start putting applications on it.
Then a few days ago, I lost ssh and console access with a “too many files open” error followed by a crash.
That’s when I started to looking into inodes and fds, and observed that something’s seems To be wrong.
What I’m curious about is why others haven’t seen it, considering that I haven’t put any workload on the system to suspect it could be my app.
I’m planning to do a clean install on the weekend to find out if it makes a difference. If it goes away, or persists, I’ll update the ticket to let whoever might be interested know.
Thanks for looking through the logs though.

I'm seeing a linear growth in open files in my k3s cluster but only on k3os nodes which were installed via overlay on top of ubuntu 20.04.  @masoudbahar I'm curious what type of installation you did with k3s?
Here are some graphs:

@billimek, mine was also an overlay installation on Ubuntu 19.10.
Right now, I’m trying k3s on Ubuntu 20.04 and Alpine 3.11, to find out compared to K3OS, which one can provide the least disruptive experience, as my focus is on kubernetes, not the OS.

I wonder if this is something more related to k3os and/or overlay installation of k3os, given the two datapoints from @masoudbahar and myself.
@dweomer FYI this symptom is related to our conversation about increased memory (specifically slab) over slack.
Some further digging on my side into the issue reveals some details which may be helpful:

Out of 7 k3s nodes running on k3os in my environment, this issue with linear growth in open file descriptors (file descriptor leak?) is only present in the four nodes that were k3os installed, via overlay, on top of ubuntu focal (20.04).
Of the four nodes impacted, three are arm64 and one is amd64
There was an issue before with similar symptoms due to a bug in containerd with exec-based probes, but that was fixed in containerd 1.3.3 (see #1042 & containerd #3949)
another symptom is the same linear-growth pattern in kernel unreclaimable slab memory, which I suspect is directly related to open file descriptors being consumed
lsof counts are wildly different than what  sysctl fs.file-nr reports:

'bad' nodes:
k3os-d [~]# lsof | wc -l
5173
k3os-d [~]# sysctl fs.file-nr
fs.file-nr = 408672     0       1048576

k3os-pi4-a [/var/log]# sysctl fs.file-nr
fs.file-nr = 570944     0       1048576
k3os-pi4-a [/var/log]# lsof | wc -l
1054

k3os-pi4-b [~]# sysctl fs.file-nr
fs.file-nr = 464352     0       1048576
k3os-pi4-b [~]# lsof | wc -l
1666

k3os-pi4-c [~]# sysctl fs.file-nr
fs.file-nr = 460960     0       1048576
k3os-pi4-c [~]# lsof | wc -l
1322

'good' nodes:
k3s-0 [/var/lib/rancher/k3s/server/cred]# sysctl fs.file-nr
fs.file-nr = 5120       0       1048576
k3s-0 [/var/lib/rancher/k3s/server/cred]# lsof | wc -l
4940

k3os-b [~]# sysctl fs.file-nr
fs.file-nr = 3104       0       1048576
k3os-b [~]# lsof | wc -l
3193

k3os-c [~]# sysctl fs.file-nr
fs.file-nr = 1792       0       1048576
k3os-c [~]# lsof | wc -l
1781

Googling and digging around has yet to show me a path to reconciling the huge difference in 'open file descriptors' reported by sysctl vs lsof.  In other words, I can't seem to pinpoint a PID or collection of PIDS that are responsible for this growth.  Is it something happening with the kernel?
Assuming there is some pattern aligning an overlay installation of k3os, what is special or different about that which may trigger this type of behavior?  From what I understand the existing installation kernel & boot system remain in place but all of the runtime (starting with init are replaced with k3os components.
It seems that increasing the max files count and/or periodic rebooting may help with the symptom, but not the root-cause.
Really curious if anyone else in this thread has some investigation ideas to try.

A couple more graphs with all the nodes together to better illustrate the growth pattern.  The point at which the growth starts coincides with the k3os overlay installation.  Prior to that is a previous regular k3s install directly or k3os install via ISO (depending on the node):
Open File Descriptors:

Unreclaimable slab memory:

As predicted, the k3os nodes became unresponsive once the total number of open file descriptors exceeded the limit.  This is the last snapshot from one of the nodes before everything essentially stopped:

From that same node with a shell already previously established, dmesg is outputting the following every 30s:
[Sat May 23 13:32:03 2020] VFS: file-max limit 1048576 reached while lsof | wc -l shows 833 and sysctl fs.file-nr shows 1077152:
k3os-pi4-b [~]# lsof | wc -l
833
k3os-pi4-b [~]# sysctl fs.file-nr
fs.file-nr = 1077152    0       1048576
k3os-pi4-b [~]#

All of the above should not be too surprising, but want to add additional information to this issue for completeness.

@billimek I see similar on my local cluster arm/arm64 overlays on top of Eoan.

Sounds like maybe this issue should move to https://github.com/rancher/k3os/issues/

I’ve updated the title to properly reflect the issue, but, I don’t know if someone can move it to the K3OS repo or not!

Just out of curiosity, did you do a takeover, or ARM overlay?

https://github.com/rancher/k3os#takeover-installation
*https://github.com/rancher/k3os#arm-overlay-installation

Mine was an ARM overlay.
What K3OS does on ARM that is different from a x86 overlay (if there’s a reason to do one), I don’t know; it will be interesting to try!

@masoudbahar what OS did you install over the top of?

@brandond, yes, I use Ubuntu on arm64.
@billimek, I like the declarative design of K3OS too, but ended up writing a lot of customization scripts, which I either have to add through write_files, or download from a file server, using a bootstrap script that is added as a write file.
One of the primary use cases of K3S is running kubernetes on edge devices (my use case), but unfortunately, K3OS, isn’t, at least for now, and I really hope not for long, stable enough on such devices.
As an interim or even permanent solution, I like Ubuntu for its ease of customization, and Alpine, for its minimalism (which is more resource friendly too).

I did a takeover install on an Ubuntu x86_64 VM and I'm not seeing any inode growth - container_fs_inodes_total has been steady for the last 24 hours. Is this the metric that you were looking at?

I did a takeover install on an Ubuntu x86_64 VM and I'm not seeing any inode growth - container_fs_inodes_total has been steady for the last 24 hours. Is this the metric that you were looking at?

I was looking at the output of sysctl fs.file-nr which is also expressed in the prometheus node-exporter as node_filefd_allocated.
Here is a graph from an amd64 node I'm running that's based on ubuntu 20.04 with the k3os overlay installation:

(the green part is the max open files that I experimented raising but eventually the OS ran out of memory as slabv unreclaimable grew too high; the yellow part is the linear growth pattern I describe earlier and the 'drops' represent reboots)


Validate domain preview fallback image

The DomainPreview component is widely used on profile pages to show a PFP image for a domain. There is image onError handling existing in the component, which does not properly handle the case where a fallback image does not properly load. If the fallback image doesn't load, the component will continually try to request the failing fallback image.

/gcbrun


Allow values > 1 for friction and bounce in PhysicsMaterial

Allows friction and bounce in PhysicsMaterial to be set with values higher than 1 in the editor, but still doesn't allow negative values and clamps the slider between 0 and 1.
Fixes #48298
Supersedes #48321

Seems good to solve the immediate issue, but I still think we should also improve the documentation as I mentioned here: https://github.com/godotengine/godot/pull/48321#issuecomment-829957834
After all this discussion it's still unclear to me whether friction > 1 is physically correct or not. From the bug report it seems like friction may not be a ratio.

Seems good to solve the immediate issue, but I still think we should also improve the documentation as I mentioned here: #48321 (comment)
After all this discussion it's still unclear to me whether friction > 1 is physically correct or not. From the bug report it seems like friction may not be a ratio.

Yeah, definitely. It will require some tests, because it's a bit different between Godot Physics and Bullet if I remember correctly.

Thanks!

Cherry-picked for 3.3.1.

Cherry-picked for 3.4.

For info, I've opened #48461 to keep track of the documentation issue.


[Bug]: Oder in which changes are displayed is not clear

Is there an existing issue for this?

[X] I have searched the existing issues

Description
The order in which the changes are displayed in the git modal is confusing. We should set a particular order so that reading through the changes makes sense.
Steps To Reproduce

Add a page
Now add a datasource.
Make some changes to the above page.

Expected: The order in which the changes are displayed should be defined.
Actual: We see changes in random order.
Public Sample App
No response
Environment
Release
Severity
Medium (Frustrating UX)
Issue video log
https://www.loom.com/share/309e240c64054c95bf3b83b53d6a7018
Version
Cloud

The order will be -

Non expandable page changes (in alphabetical order)
Expandable page changes (in alphabetical order)

Jsobjects
Queries


[Feature Request] el-image大图预览能否增加点击遮罩关闭大图的功能，关闭按钮也可以明显一点

Existing Component
是
Component Name
image
Description
el-image大图预览能否增加点击遮罩关闭大图的功能，关闭按钮也可以明显一点

Me too, the right top corner 's close icon is gray, which cause user cannot find the icon sometimes.

Me too, the right top corner 's close icon is gray, which cause user cannot find the icon sometimes.

所以我自己写样式覆盖了，原来灰色变成白色，显眼多了

Already fixed in version 2.15.0

Already fixed in version 2.15.0


Modifying tags - need more clarity

What do you mean by "Modifying and deleting tags and other properties of resources in the MC_* resource group can lead to unexpected results such as scaling and upgrading errors. Modifying the resources under the MC_* in the AKS cluster breaks the SLO" - If as part of corporate governance we need to tag each VM to indicate the cost center etcs.. wouldn;t that be possible? If my cluster is mult-tenant and is being used by multiple applications, how would we attribute the cost in this scenario if we cannot add any additional tags to the VMs being provisioned?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: d501ff67-9208-8bcb-e8df-f09e9b16a802
Version Independent ID: e3fc3851-ddc4-d26c-251d-6ae53d714081
Content: Frequently asked questions for Azure Kubernetes Service (AKS)
Content Source: articles/aks/faq.md
Service: container-service
GitHub Login: @iainfoulds
Microsoft Alias: iainfou

@badalk Thanks for the comment. Your feedback has been shared with the content owner for further review.

@badalk Thanks for the question. Adding tags is fine. As you note, that's common behavior to keep track of resources. You are then free to modify or delete those custom tags.
What's not supported is modifying or deleting the existing tags assigned by the Azure platform. A VM that is part of an AKS cluster includes tags for the ACS version, Kubernetes version, associated nodepool and resource group, etc. Modifying or deleting these assigned tags can cause problems within the cluster.
I'll update the FAQ to make this clearer.
#in-progress


cmd/go: [modules + integration] per-goproxy disabling of any notary check

This report is part of a series, filled at the request of @mdempsky, focused at making Go modules integrator-friendly.
Please do not close or mark it as duplicate before making sure you’ve read and understood the general context. A lot of work went into identifying problems points precisely.
Needed feature
Go needs to allow disabling any notary check on specific goproxy sources (#31304)
The check disabling needs to be per-module source, not per-module-match or for all, like in GONOVERIFY.
Constrains

the disabling needs to apply on specific goproxy sources

Motivation
The whole point of working in a trusted baseline mode is the ability to inject last-mile critical fixes in the third party modules used, and avoid lockdown while their upstream considers how it wants to fix identified problems. Therefore, any baseline module is likely not  matching any external public notary hash. And this is not a problem.
Moreover, any module produced by intermediary go mod pack (issue #31302) calls can’t have been vouched for by any notary by construction:

it has just been created within the same CI/CD job
the CI/CD will typically block remote network calls.

Asking a remote notary to attest you can use files you’ve just produced yourself would be more than slightly masochistic.
However, just because one needs to disable notary checks for internal goproxy module sources, does not mean that one would like to disable verifications for other modules sources like the internet.

I believe this goes against go's security posture of allowing injection attacks.
We expect replacements to be explicit as replaces.


Fuzzing ignore custom onchain url

I have been running test on speed using custom chain url i.e. -u, --onchain-url <ONCHAIN_URL>
When I run a custom url https://rpc.ankr.com/bsc<my_api>, the fuzzing ignores the url and uses the default url inferred from chain-type.
I run test and check request in dashboard, with custom url I expect request count to increase but it does not.
Is there any other way to point to custom url to be used during fuzzing?
Thanks

You can use ETH_RPC_URL environment variable

Thanks this works, but setting ETH_RPC_URL is giving the following warning when fetching contract code:
INFO Unexpected RPC error, consider setting env <ETH_RPC_URL>
but it seems to work despite, that


 We can improve and expand on the basic PrevoutProvider while we're at it.
/triage accepted
/area packages

/priority important-soon

/kind feature

/assign @thedoublejay for assignment to @WavesHQ since it directly affects Wallet UX. Not urgent or blocking, do it at your own org pace.

Do I need to update these 2 functions to ignore the UTXO's that are immature?
https://github.com/JellyfishSDK/jellyfish/blob/main/packages/whale-api-wallet/src/prevout.ts#L18-L39
If so how would I get the number of confirmations for a specific UTXO?

@canonbrother gave me this.
const txn = await this.client.rawtx.getRawTransaction(txid, true)

https://github.com/JellyfishSDK/jellyfish/blob/811b25814de3204b21e84e8ccccc82dda75410ae/packages/jellyfish-api-core/src/category/rawtx.ts#L328
rawtx.ts

Also how would I run a test of some sort so I can step through the code to look at what I am working with?

@canonbrother gave me this.
const txn = await this.client.rawtx.getRawTransaction(txid, true)

https://github.com/JellyfishSDK/jellyfish/blob/811b25814de3204b21e84e8ccccc82dda75410ae/packages/jellyfish-api-core/src/category/rawtx.ts#L328
rawtx.ts

Yes, but it's too expensive to call this.
You can get the current block height by using this.client.blockchain.getBlockCount() and probably .filter() and calculate the confirmation manually.
Fortunately,
https://github.com/JellyfishSDK/jellyfish/blob/811b25814de3204b21e84e8ccccc82dda75410ae/packages/whale-api-client/src/api/address.ts#L191
contains block.height so the call won't be expensive.

If I were to write a unit test, how should it look like? Is there any other test I can refer to?

Should the test be at

packages/whale-api-wallet/__tests__

If I were to write a unit test, how should it look like? Is there any other test I can refer to?
Should the test be at

packages/whale-api-wallet/__tests__

You can try looking at existing literature on how PRs are created for whale-api related change.
I assumed it's packages/whale-api-wallet/__tests__; you can give it a go — I will review it afterward if it's awkwardly placed.


[Bug] Using custom authservers wont work

I recompiled the jar on java 20 with my custom API servers to fetch profiles UUID's, i'm on a Minecraft 1.20.4 Server running in pterodactyl with a Java 20 to run, it indeed can prefetch the players from the servers
container@pterodactyl~ java -jar migrator.jar -online Starting MinecraftOfflineOnlineConverter Version 2.3.4... Found world name "Final" in server.properties. Trying to target this world folder. Detected Bukkit/Spigot/Paper server. CONVERSION: OFFLINE --> ONLINE Was able to prefetch player Izar from usercache.json Was able to prefetch player Greivus560 from usercache.json Was able to prefetch player V4lcofter from usercache.json Was able to prefetch player Min from usercache.json Was able to prefetch player Pommiess from usercache.json Was able to prefetch player NiKinot from usercache.json Was able to prefetch player Lumonafu from usercache.json Was able to prefetch player Shaki from usercache.json Was able to prefetch player Dam_lovs_ from usercache.json Was able to prefetch player cheeseah_ from usercache.json Was able to prefetch player Alfie8306 from usercache.json Was able to prefetch player Luu from usercache.json Was able to prefetch player Spid3rDan from usercache.json Was able to prefetch player Setco0 from usercache.json Was able to prefetch player XxErnestopikaxX from usercache.json Was able to prefetch player Musa from usercache.json [...]
but it just wont covert the uuids to online mode
Working on playerdata... There was a problem whilst converting the UUID from the file ./Final/playerdata/8b25c298-ded6-37cd-88ef-dcec8a90ec9a.dat. Probably offline! There was a problem whilst converting the UUID from the file ./Final/playerdata/1f03c98a-51f9-325f-b5d6-1e257599d3de.dat. Probably offline! There was a problem whilst converting the UUID from the file ./Final/playerdata/684ca5de-01e0-33a4-8333-ff6a1538b57c.dat. Probably offline! There was a problem whilst converting the UUID from the file ./Final/playerdata/d6962edd-958b-359a-bfce-2d0ba72b087a.dat. Probably offline! There was a problem whilst converting the UUID from the file ./Final/playerdata/cca400cd-fa18-314e-a94f-3df3fc762476.dat. Probably offline! Player b0mi1 --> ab0aae9a-6538-4fb7-8ac0-7a54be308d2c to ab0aae9a-6538-4fb7-8ac0-7a54be308d2c There was a problem whilst converting the UUID from the file ./Final/playerdata/13339273-c661-32f0-a7d6-945d5e49a4c3.dat. Probably offline! There was a problem whilst converting the UUID from the file ./Final/playerdata/99fc0149-5200-314b-802f-68ed4737194b.dat. Probably offline! There was a problem whilst converting the UUID from the file ./Final/playerdata/7474bfbc-4258-3f3b-8a5b-8dc718c13a69.dat. Probably offline! There was a problem whilst converting the UUID from the file ./Final/playerdata/00000000-0000-0000-0009-000009deb3fc.dat. Probably offline!
it just work with players who already use with online UUIDS

From my first look it seems like that basically all UUIDs that "had a problem" and "probably offline" does apply.
You can use some publicly available service to check usernames and UUIDs and they are all non existent, meaning those are all UUIDs from offline accounts. These can't be converted to online, you need a bought Minecraft account for that!
Could you please give me the whole log without leaving anything out? Either via GIT gists or Pastebin?
There is some funky stuff going on with: Player b0mi1 --> ab0aae9a-6538-4fb7-8ac0-7a54be308d2c to ab0aae9a-6538-4fb7-8ac0-7a54be308d2c
Maybe I can find some underlying bug.


FulIncomingSlipLetter: Don't include "Available items" for article copies

In these cases, we get a list of all the items/issues associated with the relevant holdings.. which can be several pages.
Not sure how to best filter these, perhaps on request type PHYSICAL_NON_RETURNABLE or DIGITAL...

Added a filter on material_type != 'Article' in https://github.com/scriptotek/alma-slipsomat/commit/319de859b75bfa5ba6ff1c2ba31bca551da26c84 . Might not catch all cases, but most.


Official Remix + Chakra-UI template is broken

Description
Official remix template is not working. If you open the sandbox, the styles will go after load. I would like to use official template.
here's video:
https://user-images.githubusercontent.com/83508485/217382419-dee1738b-1865-49e9-8b09-89c71d947b66.mp4

This works fine on my PC
have you tried refreshing your browser not codesand box browser ?

oh yeah, found the issue... The same problem were causing two things.

Browser plugin to disable google analytics javascript.
Ofc I tried running in incognito mode my app, but google tag manager script was causing this bug also. (google analytics works)
So, the way to fix it, is to check dangerously set scripts in app. I think I can close it for now, since it's resolved.


Fix SDL2_gfx download link

Should fix the Travis build.
Appears SourceForge changed some of there download mirror domain names.

Nice !


Wrong definition parse

Describe the bug
If struct has embedded struct field with name as other same aliased struct, definition's embedded field will aliased
To Reproduce

Set --pd using go list
Define main struct with embedded struct that has name as alias from other package (embedded struct without alias)
Specify response comment with main struct
Definition parsing will find embedded struct by alias from other package

Expected behavior
Definition parser looks up by struct name, not alias name
Your swag version
1.16.3
Your go version
1.19.13
Additional context
The main problem with parsing dependencies via go list, because it will return packages that parsed from main directory before. TypeSpecDef has NotUnique field = True. Same struct has duplicates by package paths (relative from parse main dir, full path from parse dependency via go list). When parsing embedded structs, the parser tries to look up the field by name and may find an aliased struct from another package.

Alias is usually used to distinguish definitions with the same name but from different packages, meanwhile, reduce the length of the name of a definition.
If the alias has not made the definition unique, I am confused about its existence. I think this is an artificial bug.

swag lookup definitions through the imports at the top of the current go source file, but you didn't import bad package in .../good/data.go.
I have checked the test example in the testdata directory you commited, I don't think swag will lookup Emb from the bad package.
And also I try the newest swag, it works well.
Have you provided the right example which leads to this issue?

swag lookup definitions through the imports at the top of the current go source file, but you didn't import bad package in .../good/data.go.
I have checked the test example in the testdata directory you commited, I don't think swag will lookup Emb from the bad package.
And also I try the newest swag, it works well.
Have you provided the right example which leads to this issue?

this is strange because in my case the latest version does not pass the test. And just parses the structure with the alias from the bad package

https://github.com/swaggo/swag/blob/c7f1cd8e8e3702096516b82068b662a29eb79dea/parser.go#L398
At this point swag collects packages also from bad package and parse bad.Emb with alias.
When parse struct, swag finds Emb field from bad package because of alias

I can't regenerate the issue you described.
swag collects Emb from bad package with name 'Emb', and from good pacage with name 'good.Emb'.
When parsing the struct, swag first lookup good.Emb, then Emb.
So normally good.Emb will be found.

Can you please show me how you're trying to regenerate issue

I got your point and find the cause.
The file including good.Emb was parsed twice, which led to self conflicts.
A better way to solve it, I think, is to guarantee a file identified by its absolute path be parsed only once.

Your version does not pass my test.
Error parsing type definition 'Gen': emb: cannot find type definition: Emb
Because when trying to find good.Gen struct, it tries to find via import and load external package
https://github.com/swaggo/swag/blob/c7f1cd8e8e3702096516b82068b662a29eb79dea/packages.go#L532
This line leads the structure to parsing the same files again. After this, good.Emb in unique definitions is nil

Your version does not pass my test. Error parsing type definition 'Gen': emb: cannot find type definition: Emb Because when trying to find good.Gen struct, it tries to find via import and load external package
https://github.com/swaggo/swag/blob/c7f1cd8e8e3702096516b82068b662a29eb79dea/packages.go#L532
This line leads the structure to parsing the same files again. After this, good.Emb in unique definitions is nil

Yes I know this.
As good.Gen has been renamed to Gen,it cannot be found. This is the correct behavior,I think.
Just remove the name prefix 'good.' from the API comments.

If you will delete good.Emb as nil (e. g. like here) it will find Emb by alias from bad package

Yes I know this. As good.Gen has been renamed to Gen,it cannot be found
No, it cant find exactly Emb struct


Simplify docs feedback

This PR simplifies the feedback widget at the bottom of every docs page. Previously, clicking Yes or No would trigger a popup with a hubspot form. Now, clicking Yes returns a "Thanks for the feedback!" message, and clicking No returns "Thank you! Have specific feedback? Please open an issue." "open an issue" is a link to the docs github repo.
I'd like to roll this out and see if the volume of feedback increases.
@mjibson, do you see ways to clarify or clean this up further?

This change is

http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/d364d61516c09469031d901fd4e0a72deb75cfd9/

http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/64c0d31129aedb9560896b4ae4b2bff4624599e9/

http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/2e3a9c492db5b258f3c0aa60c305936099dc7b1a/

http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/e1954991ed27d35e627a238a356ccb6195fc297f/

http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/dee517488855d86e9a04c54836ace0b789437df9/

@sploiselle will help pre-populate title of issue with url of page from which feedback is submitted.

This no longer submits the feedback.

Review status: 0 of 4 files reviewed at latest revision, 3 unresolved discussions.

_includes/feedback-widget.html, line 17 at r1 (raw file):

<script>
  $(document).ready(function(){
      $("#yes-response, #no-response").hide();

The spacing here is inconsistent. It apparently should be 2 spaces per indent, but there are 4 here.

_includes/feedback-widget.html, line 19 at r1 (raw file):

      $("#yes-response, #no-response").hide();
      $("#yes-button, #no-button").bind("click", function () {
        $("#yes-response, #no-response").hide();

remove whitespace at EOL

css/components/_feedback-widget.scss, line 51 at r1 (raw file):

}

#yes-response, #no-response {

I think you can just use .feedback-question for this and below instead of the IDs.

Comments from Reviewable

Yes, we're no longer using hubspot but rather just tracking the click events in Google Analytics.

Review status: 0 of 4 files reviewed at latest revision, 4 unresolved discussions.

_includes/feedback-widget.html, line 17 at r1 (raw file):
Previously, mjibson (Matt Jibson) wrote…
> The spacing here is inconsistent. It apparently should be 2 spaces per indent, but there are 4 here.

I've simplified the jquery based on your input. Thanks!

_includes/feedback-widget.html, line 19 at r1 (raw file):
Previously, mjibson (Matt Jibson) wrote…
> remove whitespace at EOL

Done.

css/components/_feedback-widget.scss, line 51 at r1 (raw file):
Previously, mjibson (Matt Jibson) wrote…
> I think you can just use `.feedback-question` for this and below instead of the IDs.

Through simplified jquery, I've removed some of the css.

Comments from Reviewable

http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/df9456a3845ac4d5f6a39183e14b5699b07d5496/

Review status: 0 of 4 files reviewed at latest revision, 4 unresolved discussions.

_includes/feedback-widget.html, line 10 at r2 (raw file):

  $(document).ready(function(){
      $("#yes-button, #no-button").bind("click", function () {
        $("#yes-response, #no-response").hide();

This line can go away.

Comments from Reviewable

 after my comment

Review status: 0 of 4 files reviewed at latest revision, 4 unresolved discussions.

Comments from Reviewable

Review status: 0 of 4 files reviewed at latest revision, 4 unresolved discussions, all commit checks successful.

_includes/feedback-widget.html, line 10 at r2 (raw file):
Previously, mjibson (Matt Jibson) wrote…
> This line can go away.

Done.

Comments from Reviewable

@sploiselle, let's do pre-populate the issue title in a follow-up PR. I create an issue for you: #844

http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/fc1571226027de91a11746f5683a0466dec61eb7/


Added RigidBody and finished Resource class-reference

Added RigidBody and finished Resource class-reference. Also synced with the current git master documentation template.

Apparently the commit(s) are not being attributed to your Github account. The reason may be that your git configuration uses a different e-mail address to your Github account. Read this article for more information.
However, that does not prevent from merging this Pull Request.

Yep, noticed just a few seconds after commiting. Fixed it now :)

Please rebase the merge commit out, since it doesn't add any value.

Ah, as you can see I'm not so natural with git. Lets just nuke this PR, I will do another one tomorrow when I have time to fix my repo/commits.

I think you can just remake this PR as many times as necessary, so no need
to create another one.
On Mon, May 30, 2016 at 10:59 PM, J08nY<EMAIL_ADDRESS>wrote:

Ah, as you can see I'm not so natural with git. Lets just nuke this PR, I
will do another one tomorrow when I have time to fix my repo/commits.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/godotengine/godot/pull/4933#issuecomment-222547656,
or mute the thread
https://github.com/notifications/unsubscribe/AAAX05ZtanijGkAg0amQbx7r8CgjltHpks5qG0GqgaJpZM4Ip_rc
.

Commits now fixed.


Added Bing Search toggle plus some support functions

Added a framework to make toggle switches like dark mode easier. As long as the checkbox is called "WPFToggle" it will automatically be given the Invoke-WPFToggle function (similar function to Invoke-Button) and automatically checked if the status is enabled or disabled.

I like the addition of the toggle. I might start coding these type of function into other parts of the script as well.

That's the idea, hopefully this will make it easier to migrate over to using toggle switches in the future. I will try to think of a way to use the config files as well but so far don't see a good enough pattern.
I would be careful of what you convert to a toggle switch, right now it performs a check on load so if you have a complex toggle it will impact the initial load times.


Update Rosetta with various improvements

This pull request includes several improvements to Rosetta:

Remove unnecessary code and return inferred nonce in /construction/metadata

Update account balance retrieval using GraphQL query when requesting balance at tip and make it able to respond when not connected to a DB

Don't rely on runtime config for genesis balance anymore

Use token_id from request in account SQL query

Reformat Rosetta code

Changes tested locally on demo netwok.

!ci-build-me

!ci-toolchain-me

!ci-build-me

!ci-nightly-me

!approved-for-mainnet


Record Audio in Unity

Be able to record Audio and serialize it to a file type

Set limit as to how long a recording can be
Allow user to redo recording

Completed during Hackathon


DC: After DC/reconnect, menu appears, but buttons are non-responsive

I had a three-person game where one of the devices temporarily disconnected while I was taking a screencap. After I re-opened the app (for iOS), the game behaved like the player had been reconnected on all other devices, but the menu modal was open on the device that had disconnected. A solid red bar was across the top of the modal, and none of the buttons were able to be pressed, preventing the user from actually pressing the "reconnect" button. The game then eventually treats that device as disconnecting again, and all players time out of the game.

saw this yesterday as well. Maybe has to do with the new error message in modal? @mattwbenson it would be helpful to try and recreate this with any console/layout information via dev tool screenshots if possible.

more info on this:
nothing was wrong with the game. I opened the menu modal and tried clicking on one of the buttons before it fully animated in. nothing happened, and then all the of the buttons were non resposonsive. ON my other device, I opened the menu modal and waited until it was finished animating in. I then tried to press the back to game button and nothing happened. other buttons non responsive. last device opened menu modal and no buttons were responsive.
not a touch target thing because I tried pressing everywhere, no dice. Also waited about 3-4 minutes and no response so there was no delay.

Note: clicking reconnect does nothing, and freezes all buttons in menu. other buttons work fine UNTIL you hit the reconnect button.

actually, when I open the menu one time and then hit back to game, the menu closes normally. After opening it a second time and trying to hit back to game, the menu does not close, and the buttons don't respond.

confirmed fix. Buttons are responsive on app (ios) and desktop.


xen-tools/init-initrd: Add protection against wrong environment declarations

Custom variables are passed to container applications through the /mnt/environment file. Although variables are parsed and trimmed (spaces and double quotes) by pillar, a wrong declaration like the following can still happen:
"MYVAR="wrong"
Other declaration ways can also be exploited to break the shell, which will lead the shim VM to crash.
This commit adds a protection against a bad environment file by first processing it in a sub shell and only executing source command if the file is valid.
Custom variables are passed to container applications through the /mnt/environment file. Any syntax error on this file will break the shell and make the shim VM crash with no clear error indication.
This PR adds a validation of the /mnt/environment file and write a proper error message in the file cannot be processed by the shell.
PS: Parsing improvements are provided by the PR https://github.com/lf-edge/eve/pull/3760

Updates in this PR:

Remove forcing default environment
This PR now just adds a validation of the /mnt/environment file and write a proper error message in the file cannot be processed by the shell.
Pillar parsing it's improved by the PR https://github.com/lf-edge/eve/pull/3760


oskar terms in oogenesis

Are there oskar mRNAs in non-insects? If not, can I
move the oskar
terms in the oogenesis section, to be under sensu
Insecta terms. eg:
CHANGE
pole plasm mRNA localization ; GO:0019094
--%pole plasm oskar mRNA localization ; GO:0045451
TO
pole plasm mRNA localization ; GO:0019094
--%pole plasm mRNA localization (sensu Insecta) ;
GO:0048120
----%pole plasm oskar mRNA localization ; GO:0045451
and CHANGE
pole plasm protein localization ; GO:0007318
--%pole plasm protein localization (sensu Insecta) ;
GO:0048115
--<regulation of oskar mRNA translation ; GO:0046011
TO
pole plasm protein localization ; GO:0007318
--%pole plasm protein localization (sensu Insecta) ;
GO:0048115
----<regulation of oskar mRNA translation ; GO:0046011
and expand the definition of 'regulation of oskar mRNA
translation ; GO:0046011' from
definition: Any process that modulates the frequency,
rate or extent of oskar mRNA translation.
definition_reference: GO:curators
to:
definition: Any process that modulates the frequency,
rate or extent of oskar mRNA translation. To ensure the
localization of Oskar protein at the posterior pole of
the oocyte, translation of oskar mRNA is repressed
during its transport to the posterior pole and
activated upon localization of the mRNA at the
posterior cortex.
definition_reference: GO:curators
definition_reference: PMID:12538512
The current definition for pole plasm assembly ;
GO:0007315 is also insect specific so I have
transferred this to pole plasm assembly (sensu Insecta)
; GO:0048113.
Also, I'd be grateful if a non-insect person could take
a look at this part of the ontology to see whether we
need all the generic and sensu Insecta terms that are
in this bit of GO (see SourceForge:852632).
thanks,
Becky
Reported by: beckyfoulger
Original Ticket: "geneontology/ontology-requests/1764":https://sourceforge.net/p/geneontology/ontology-requests/1764

thanks www.movied.org


Mysql2::Error: Data too long for column 'user_agent'

Describe the bug
Occasional database error from HTTP requests that have a long user-agent header.
To Reproduce
curl 'https://domain/{server_id}/{email_tracking_id}' -A "Mozilla/5.0 (Linux; Android 13; Pixel 4a (5G) Build/TQ2A.230505.002; wv) AppleWebKit/537.36 (KHTML, like Gecko) Version/4.0 Chrome/112.0.5615.136 Mobile Safari/537.36 GoogleApp/<IP_ADDRESS>.arm64 AppEngine-Google; (+http://code.google.com/appengine; appid: s~...................)"
an observe that a 500 is returned.
Expected behaviour
No errors to be raised, and long user agents either to be stored in the db correctly or truncated if they are excessively long.
Additional information/context
Stack trace:
Mysql2::Error: Data too long for column 'user_agent' at row 1 (Mysql2::Error)
  from mysql2 (0.5.6) lib/mysql2/client.rb:151:in `_query'
  from mysql2 (0.5.6) lib/mysql2/client.rb:151:in `block in query'
  from mysql2 (0.5.6) lib/mysql2/client.rb:150:in `handle_interrupt'
  from mysql2 (0.5.6) lib/mysql2/client.rb:150:in `query'
  from lib/postal/message_db/database.rb:326:in `query_on_connection'
  from lib/postal/message_db/database.rb:234:in `block in insert'
  from lib/postal/message_db/connection_pool.rb:20:in `use'
  from lib/postal/message_db/database.rb:345:in `with_mysql'
  from lib/postal/message_db/database.rb:233:in `insert'
  from lib/tracking_middleware.rb:89:in `dispatch_redirect_request'
  from lib/tracking_middleware.rb:26:in `call'
  from secure_headers (6.5.0) lib/secure_headers/middleware.rb:11:in `call'
  from railties (<IP_ADDRESS>) lib/rails/engine.rb:530:in `call'
  from puma (6.4.2) lib/puma/commonlogger.rb:47:in `call'
  from puma (6.4.2) lib/puma/configuration.rb:272:in `call'
  from puma (6.4.2) lib/puma/request.rb:100:in `block in handle_request'
  from puma (6.4.2) lib/puma/thread_pool.rb:378:in `with_force_shutdown'
  from puma (6.4.2) lib/puma/request.rb:99:in `handle_request'
  from puma (6.4.2) lib/puma/server.rb:464:in `process_client'
  from puma (6.4.2) lib/puma/server.rb:245:in `block in run'
  from puma (6.4.2) lib/puma/thread_pool.rb:155:in `block in spawn_thread'

Definitely a rarity but worth fixing one way or the other

@willpower232 I don't mind attempting a PR for this. Would you support changing the field type to mediumtext or similar with a limit of 32k and truncating the value just in case?

It isn't really my decision to make but I would probably say leave the database alone and limit it to 255 characters because otherwise it feels like a waste.


Add a Java Style Documentation

📚 Documentation
Create a Java Style Guide Documentation in the specific Java  Directory which serves the following purpose:

Acquaint the User about the Java Styles Guide and what are the best practices to follow.
Mention about Code Width and Alignment, a proper convention to add Whitespaces and Indentation.
Mention about Variable Naming Conventions and various best practices followed in Java Programming.

Have you read the Contributing Guidelines on Pull Requests?
Yes

I would like to work on this.Pls assign

I would like to contribute to this.

I would like to work on it. If available please assign it to me.


Fix Azure Text Analytics Readme Issue

Fix issue #18882
@ramya-rao-a , @meeraharidasa , @mayurid and @deyaaeldeen for notification.

@v-jiaodi, Next time you can add the term "fixes" or "resolves" before the issue link and the issue will automatically get closed once the PR is closed.  Please see https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue

@ramya-rao-a, OK, thank you for your reminder.


Increment version to 1.3.9

Signed-off-by: Divya Madala<EMAIL_ADDRESS>Description
Bump version from 1.3.8 to 1.3.9
Issues Resolved
[List any issues this PR will resolve]
Check List

[ ] New functionality includes testing.

[ ] All tests pass, including unit test, integration test and doctest

[ ] New functionality has been documented.

[ ] New functionality has javadoc added
[ ] New functionality has user manual doc added

[ ] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Codecov Report

Merging #161 (81c0cb8) into 1.3 (aa38960) will not change coverage.
The diff coverage is n/a.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@           Coverage Diff           @@
##              1.3     #161   +/-   ##
=======================================
  Coverage   95.30%   95.30%
=======================================
  Files           5        5
  Lines         149      149
  Branches       45       45
=======================================
  Hits          142      142
  Misses          7        7

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


fix folder writing for cadl-output

fixes #1615

fix https://github.com/Azure/autorest.python/issues/1617


added acord_131_2009_10

acord_131
-- I added the acord 131 json file

The changes in this PR are going to be captured in: https://github.com/sensible-hq/sensible-configuration-library/pull/68. Going to close out this one.


Making meridiem string (AM/PM) configurable in time picker

It seems 'AM' 'PM' is hard coded in time picker. Could you make it configurable, like the labels for OK and Cancel button? We need to configure them for different languages. Thank you!

+1

+1


Wimpie/employee address service refactor

@Wimmas there is no validation added on any of these? existence must be checked, then is the authority correct to perform the service method. eg. if (_identity.IsSupport == false) throw new CustomException("Unauthorized Access.");

@Wimmas @EduanO The logic is not correct in your recent commit
there are some helper methods that dont need the auth check.
there are some methods that need the id compared and the identity support check.


added documentation to the transforming telemetry page

Please let me know if this is what was envisioned for the documentation. All tests have been run before.

CLA.pdf
It should have been signed now.

@alejandraquintero018 I believe you need to submit your signature to the CLA tool; just proving that you did here won't be sufficient to get the CI check to pass.
(Sorry for the trouble here, it's sadly a necessary process so that we aren't liable for lawsuits and stuff years down the road)

@alejandraquintero018 you don't need to share the signed CLA with us, I removed that link.
If you need any assistance with fixing this issue, please let us know! As @cartermp this is unfortunately a process we have to go through, but we are here to help to get this fixed if needed.

I reached out to linux and the issue was that the commit was made under a different name because the computer I am using doesn't belong to me. I was able to do that but the error hasn't cleared because I need to rebase my previous commits. I am doing that now.

@alejandraquintero018 did you have a chance to sort the CLA issues?

@alejandraquintero018 did you have a chance to sort the CLA issues?

@alejandraquintero018 could you sort the CLA issue or do you need any additional help ? are you still interested in working on this PR?

Closing due to inactivity