The generation process of depth image

I use MiDaS and follow the instructions in https://pytorch.org/hub/intelisl_midas_v2/ to get the depth image, white the depth of the demo image I get is as follows:

It seems very different from the depth image provided in this repo:

the code I use is like this:
midas = torch.hub.load("intel-isl/MiDaS", "MiDaS").cuda()
midas_transforms = torch.hub.load("intel-isl/MiDaS", "transforms")
transform = midas_transforms.default_transform

image = np.asarray(Image.open(input_image))
img = transform(image)
with torch.no_grad():
    prediction = midas(img.cuda())
    # prediction = torch.nn.functional.interpolate(
    #     prediction.unsqueeze(1),
    #     size=image.shape[:2],
    #     mode="bicubic",
    #     align_corners=False,
    # ).squeeze()
depth_image = prediction.cpu().numpy().squeeze()
depth_image = cv2.convertScaleAbs(depth_image, alpha=255/np.max(depth_image))
Image.fromarray(img, mode="L").save("demo.png")

Could you please give some details about how to get the depth image?

Hi @Victarry,
we generated depth maps using the "run.py" script from the MiDaS repo as it was in August 2020, using model-f45da743.pt weights. Maybe you are using a different model?


Fix FreeBSD build

Add a couple forgotten BX_PLATFORM_BSD
Use stdlib.h instead of deprecated malloc.h/alloca.h (that #error on FreeBSD 12)

More info about deprecated alloc headers: https://stackoverflow.com/a/12973361

Don't mess with includes, I have compatibility includes here:
https://github.com/bkaradzic/bx/blob/master/include/compat/freebsd/alloca.h

mutex.cpp and thread.cpp changes seem fine, just arrange defines alphabetically.

Oh, I guess I need to add that directory in bgfx-cmake. Sorry, I'm not familiar with this project, I'm just porting REGoth.
Sorted the defines.

BTW, why do you have an override for dirent.h? o_0
Another library used by REGoth, tinydir, needs the normal dirent.h, not sys/dirent.h.

No clue.

I don't have FreeBSD, and I might ran this from some live FreeBSD distro where that fixed build issue.


Matching not implemented for every proved law with THERE EXISTS and FOR ALL involved

Syllogism matching rules are not implemented yet as mentioned in Ex22.8 description, but matching rules for every other law related to THERE EXISTS/FOR ALL (aka the entire Chapter 18 and 22) are not implemented either. This makes for some big inconvenience later on, e.g Ex22.6(b) cannot be used on Ex23.2.

Yes, as mentioned in Ex 14.1, most exercises from this point onwards do not have matching implemented (more precisely, any law involving a predicate, operator, or term does not have matching implemented unless there is a specific hardcoded matching routine for that law).  Any specific law can be matched by a custom matching algorithm, but this takes a certain amount of time (particularly with regards to debugging) and about a page worth of code.  Ideally there should be a general solution that does not require individual matching algorithms for each exercise; I don't have a good proposal for this currently, particularly for those laws where the matching is non-unique.

Actually, it occurs to me that for some of these exercises, one can use the existing matching method for a simpler template (replacing some predicate terms with atomic propositions).    So I could code a proxy template for several of these laws which would reduce the number of laws without matching capability, though it would not eliminate them entirely.  (But then again many of the later laws are unlikely to be useful in matching anyway, for instance it's unlikely that the Lewis Carroll syllogism will see much use.)
In the meantime, I have placed an explicit notice in the notes for every exercise for which matching is not currently implemented.

Given the repetition of text, you could mark this programmatically with a
custom attribute on the exercise element, say, “data-not-matched,” and then
check the attribute when adding the notes to append the disclaimer. This
will also make it easier to track which exercises don’t have matching.
On Thu, Aug 30, 2018 at 5:00 PM teorth<EMAIL_ADDRESS>wrote:

Actually, it occurs to me that for some of these exercises, one can use
the existing matching method for a simpler template (replacing some
predicate terms with atomic propositions).  So I could code a proxy
template for several of these laws which would reduce the number of laws
without matching capability, though it would not eliminate them entirely.
(But then again many of the later laws are unlikely to be useful in
matching anyway, for instance it's unlikely that the Lewis Carroll
syllogism will see much use.)
In the meantime, I have placed an explicit notice in the notes for every
exercise for which matching is not currently implemented.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/teorth/QED/issues/22#issuecomment-417505871, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAVt7qv2e7FhGwFJXoVrQSDCwDmJdJ-eks5uWHyTgaJpZM4WRR8r
.

OK, I've managed to use such proxy templates to implement matching for a large number of exercises that previously could not be matched (For instance, all of the syllogisms now can be used for matching).  There are still a number of exercises which are not matchable at present, but the issue seems to be significantly less serious now.


Updating Templates and Wizards for 1.1.18 release

@jayaranigarg,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot


Fix incorrect query params type

Description
This is the result of my deep-dive into this comment.
Our GET query parsing method incorrectly assumed that our query parameters could be lists. As a result some of our types were sligtly incorrect and we had an unnecessary block handling the case.
Generally it would be correct that GET query parameters could contain lists (e.g. ?variables={}&variables={} could be parsed as a list). The sanic integration even contains a warning about this. However, it turns out none of our integrations interprets query parameters which are defined multiple times as lists by default (not even sanic). I manually checked every integration and also added a test to prove this.
(fyi: most of these frameworks provide a getlist method which can be used to explicitly interpret multi-defined GET query parameters as a list).
Types of Changes

[ ] Core
[ ] Bugfix
[ ] New feature
[x] Enhancement/optimization
[ ] Documentation

Checklist

[ ] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[ ] I have tested the changes and verified that they work and don't break anything (as well as I can manage).

Summary by Sourcery
This pull request fixes the incorrect type handling of query parameters in GET requests by ensuring they are not interpreted as lists. It simplifies the internal GET query parsing logic by removing unnecessary checks, adds a test to verify the correct behavior, and includes a release note documenting the changes.

Bug Fixes:

Fixed incorrect type handling of query parameters in GET requests, ensuring they are not interpreted as lists.

Enhancements:

Simplified the internal GET query parsing logic by removing unnecessary checks for list types, improving code clarity and performance.

Documentation:

Added a release note to document the patch release and the changes made to the GET query parsing logic.

Tests:

Added a test to verify that query parameters are never interpreted as lists across all integrations.

Thanks for adding the RELEASE.md file!

Here's a preview of the changelog:

This release removes an unnecessary check from our internal GET query parsing logic making it simpler and (insignificantly) faster.
Here's the tweet text:
🆕 Release (next) is out! Thanks to @NucleonJohn for the PR 👏

Get it here 👉 https://strawberry.rocks/release/(next)

Thanks for adding the RELEASE.md file!

Here's a preview of the changelog:

This release removes an unnecessary check from our internal GET query parsing logic making it simpler and (insignificantly) faster.
Here's the tweet text:
🆕 Release (next) is out! Thanks to @NucleonJohn for the PR 👏

Get it here 👉 https://strawberry.rocks/release/(next)


Update format for yapf 0.27

This is the result of tox -e format having applied yapf changes from
version 0.26 to 0.27.
re #1895

... if it passes CI.

Indeed. I'll briefly point out that I did zero local testing or review with this, with the thought being "we can either rely on yapf or we can't". While I am taking responsibility for making the changes in this PR, I am not necessarily taking responsibility for the changes themselves. yapf gets the credit there, even if I end up with the git blame. :)

Travis failures appear to be network-related. There are two failures in separate tests, both were caused by this:
 [WARNING]: - timezone was NOT installed successfully: Failed to get data from
the API server (https://galaxy.ansible.com/api/): ('The read operation timed
out',)

I recommend ignoring the travis failure, unless I've misdiagnosed the issue here.

Nice one. Restarted those failed network builds (still happening ...) but the linter is complaining https://travis-ci.com/ansible/molecule/jobs/191585216.

Seems this is pretty damn important now since all the CI failures are related.
Thanks for picking this up!

Yeah, totally missed the linter failures before, sorry about that.
If yapf is writing out files that fail lint, then my faith in yapf has been eroded. I'm definitely not interested in weeding through the yapf changes and finding the middle ground between the changes yapf makes and the formatting flake8 will accept. It looks like there's an open bug that is at least related to this, so it might be that the solution for now is to pin yapf to 0.26 to cut down on the CI noise related to 0.27's changes and figure out what to do later.

so it might be that the solution for now is to pin yapf to 0.26 to cut down on the CI noise related to 0.27's changes and figure out what to do later.

Let's do that!!!

Closing this for now, then. I'll put up a different PR summing up the problem and pinning yapf.


[FLOC 4269] Rename keypair suggestion

Fixes 4269
Addresses a suggestion raised by @moshez
Note - Point 2 raised in 4269 "Move the Volume Hub part of step 2 to Step 1.5. Looks too mushed up with Step 2." has not been corrected in this PR - this will be done as part of the review comments submitted by FFFunction, that are currently being transcribed into JIRA tickets. (will update here when references are available)

Hi @moshez
Thanks for the feedback - we use  to display variables throughout the rest of the docs, so I've added these, and made them italic as suggested - I thought that helped make them easily identifiable in this doc as user specific variables.

Thanks @davidoliverSP2
I quickly skimmed http://clusterhq-staging-docs.s3-website-us-east-1.amazonaws.com/cloudformation-docimprovements-FLOC-4269/docker-integration/cloudformation.html and it looks better.
I might have suggested using <em> rather than <i> but that's just nit picking.
Please merge.


PIN is not necessarily unique

PIN is a random number between 1 and 99999. It should be ensured that the randomly assigned PIN does not already exist.

Fixed with commit 16bce1dd761067af0ca0ed09024462f62679860a


Sending emails

Hi,
I'm running unit tests via PHPUnit on GitLab CI and I do get the following error:
sh: 1: /usr/sbin/sendmail: not found
In this case, I don't need any real email to be send. What would be the best way to incorporate this (e.g. combine MailHog with this Docker image)?
Any other suggestions?
Thanks

You can setup mailhog or similar as a service, but i don't know if this is possible on gitlab-ci, i myself never used for this purpose. Um any case the mailhog is just a UI to see the mail content, there are other ways to test just if the e-mail are been sent. If you are in Laravel you can use the LOG driver

+1 for the Laravel log driver, or perhaps you could mock sendmail in your unit tests?

Thanks for your replies.
I am familiar with Laravel, but this is a non-Laravel project.


Possibly support for swift2.3?

Why not use version 1.0.1 until you upgrade your code to swift 3?
pod 'EasyTipView', '1.0.1'


chore: Update docs link for git

Description

Updated docs link for git as the docs for git was just restructured.

Fixes #13821
How Has This Been Tested?

Locally

Checklist:

[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes

/ok-to-test sha=c495588

Should we setup redirects for the old URLs? In here https://github.com/appsmithorg/appsmith-docs/blob/v1.3/.gitbook.yaml?


PyQt5 file dialog crash only when launched from integrated terminal AND with a .json file next to the python file

Type: Bug
I had a project which worked well, using PyQt5. Today, after several weeks without touching this project, it didn't work so well. I couldn't open any file dialog. The software freezes and begins to take more and more memory.
After investigation with a very minimal program, a python environment (tried python 3.10 and 3.11) with only PyQt5 installed and all extensions disabled:
from PyQt5.QtWidgets import QApplication, QFileDialog

app = QApplication([])
w = QFileDialog()
w.show()
app.exec_()

it appears that this bug only happens when opening a PyQt5 File Dialog if run from the integrated terminal (tested with fish or bash and "python main.py") and if there's a json file alongside the main.py file.
The bug is still there if I try from another folder, with a valid, invalid, or empty json file, whatever its name.
It works from another terminal. It works if I remove the json extension of the file or change it to anything else like txt (which is not used by my program at all).
So, this is very particular but it seems to be linked to vscode. It took me some time to find what was the problem so I figured it was better to share it. I guess it comes from a recent version of vscode as it worked before.
VS Code version: Code 1.84.2 (1a5daa3a0231a0fbba4f14db7ec463cf99d7768e, 2023-11-09T10:50:47.800Z)
OS version: Linux x64 6.6.1-1-MANJARO snap
Modes:

System Info

Item
Value

CPUs
Intel(R) Core(TM) i9-10980HK CPU @ 2.40GHz (16 x 4597)

GPU Status
2d_canvas: enabledcanvas_oop_rasterization: disabled_offdirect_rendering_display_compositor: disabled_off_okgpu_compositing: enabledmultiple_raster_threads: enabled_onopengl: enabled_onrasterization: enabledraw_draw: disabled_off_okvideo_decode: enabledvideo_encode: disabled_softwarevulkan: disabled_offwebgl: enabledwebgl2: enabledwebgpu: disabled_off

Load (avg)
1, 1, 1

Memory (System)
31.11GB (23.38GB free)

Process Argv
--no-sandbox --force-user-env --unity-launch --log trace

Screen Reader
no

VM
0%

DESKTOP_SESSION
plasma

XDG_CURRENT_DESKTOP
KDE

XDG_SESSION_DESKTOP
KDE

XDG_SESSION_TYPE
x11

Extensions (1)

Extension
Author (truncated)
Version

vscode-language-pack-fr
MS-
1.84.2023111509

When it works (here, changing the extension of the empty file to "anything.NOT_json") it should look like that : an opened window where you can choose a file to open.

When the extension is json however, the window is empty (we see behind part of vscode), I have to kill the program manually, otherwise it takes more and more memory.

I don't know how much it is due to Qt or vscode ; but one thing is sure : this does not happen when I use an external console. It only happens via the integrated terminal of vscode and from a recent version of vscode.

Thanks for the info. Here's info on how to provide more details about your issue https://github.com/Microsoft/vscode/wiki/Performance-Issues

Info from code --status are included in this performance report issue (all extensions are disabled)
Type: Performance Issue
VS Code version: Code 1.84.2 (1a5daa3a0231a0fbba4f14db7ec463cf99d7768e, 2023-11-09T10:50:47.800Z)
OS version: Linux x64 6.6.2-1-MANJARO snap
Modes:

System Info

Item
Value

CPUs
Intel(R) Core(TM) i9-10980HK CPU @ 2.40GHz (16 x 4600)

GPU Status
2d_canvas: enabledcanvas_oop_rasterization: disabled_offdirect_rendering_display_compositor: disabled_off_okgpu_compositing: enabledmultiple_raster_threads: enabled_onopengl: enabled_onrasterization: enabledraw_draw: disabled_off_okvideo_decode: enabledvideo_encode: disabled_softwarevulkan: disabled_offwebgl: enabledwebgl2: enabledwebgpu: disabled_off

Load (avg)
1, 1, 0

Memory (System)
31.11GB (25.77GB free)

Process Argv
--no-sandbox --force-user-env --unity-launch

Screen Reader
no

VM
0%

DESKTOP_SESSION
plasma

XDG_CURRENT_DESKTOP
KDE

XDG_SESSION_DESKTOP
KDE

XDG_SESSION_TYPE
x11

Process Info
CPU %	Mem MB	   PID	Process
    0	   127	  3309	code main
    0	    32	  3311	   zygote
    0	    32	  3312	   zygote
    0	   191	  3361	window [1] (main.py - test_qt5_file_dialog - Visual Studio Code)
    0	    96	  4890	window [2] (Rapporteur du problème)
    0	   127	  3340	   gpu-process
    0	    32	  3344	   utility-network-service
    0	    64	  3417	ptyHost
    0	     0	  3484	     /usr/bin/fish
    0	   924	  3961	       python main.py
    0	    96	  3427	shared-process
    0	     0	  4900	     /usr/bin/ps -ax -o pid=,ppid=,pcpu=,pmem=,command=
    0	    64	  3428	fileWatcher [1]
    0	    96	  3429	extensionHost [1]

Workspace Info
|  Window (main.py - test_qt5_file_dialog - Visual Studio Code)
|    Folder (test_qt5_file_dialog): 4418 files
|      File types: sip(786) py(753) pyc(752) qml(695) png(219) qm(195) so(181)
|                  qmlc(170) qmltypes(53) 5(48)
|      Conf files:;

Extensions (1)

Extension
Author (truncated)
Version

vscode-language-pack-fr
MS-
1.84.2023111509

@joaomoreno or @rzhao271 any ideas related to Linux x64 6.6.2-1-MANJARO snap?

This is very likely a snap problem


Implement DEX pallet in the trappist runtime.

Implement DEX pallet located in https://github.com/Wiezzel/substrate-dex into Trappist runtime.
In case there are some parameters to define let's bring the discussion here.

@hbulgarini There's a bunch of constants to configure for the dex pallet:

PalletId – Pallet ID. Used for account derivation.
ProviderFeeNumerator – Numerator of the fractional number representing liquidity provider fee. Should be lower than
the denominator (fees cannot exceed 100%).
ProviderFeeDenominator – Denominator of the fractional number representing liquidity provider fee.
MinDeposit – Minimum amount of currency which must be deposited when creating a new exchange.

I believe PalletId doesn't really matter. We just need some ID.
Provider fee is something we can potentially tweak. For tests I used the same value which original Uniswap V1 uses, i.e. 0.3%.
MinDeposit – I'm not sure about this one. How much HOPS is considered a reasonable min deposit? In real-world use case it shouldn't be too low to avoid tx spamming, but here it's monopoly money anyway.

PalletId(*b"trappist/dex");
PalletId must be 8 characters; My proposal is: PalletId(*b"py/trdex")

PalletId(*b"trappist/dex");

PalletId must be 8 characters; My proposal is: PalletId(*b"py/trdex")

How about trappdex? To me the meaning of py/trdex is a bit unobvious.


Add option to disable sync to media

Avoiding sync to media for every single update dramatically boosts performance at the cost of losing recent changes if all nodes crash at the same time. When using ext3 or ext4 file system with default settings it is 5 seconds worth of data at most (see man mount -> commit).

Included in 0.0.6.


LNbits startup fails due to unavailability of Boltz API

Oops 😅
2023-05-08 11:59:11.18 | DEBUG | lnbits.extensions.boltz.tasks:check_for_pending_swaps:104 | Boltz - startup swap check
Task exception was never retrieved
....
httpx.HTTPStatusError: Client error '400 Bad Request' for url 'https://boltz.exchange/api/getpairs'
For more information check: https://httpstatuses.com/400
...
message: temporarily disabled

Sry about this but also glad we helped you to catch it

fixed in e72ccbf0a07752d79c1205550223a1b8a3b8cd864bb6d0040e601c38548e421d.
release 0.2.3 is out https://github.com/lnbits/lnbits-extensions/pull/99


archiver: Fix flaky TestArchiverAbortEarlyOnError

What does this PR change? What problem does it solve?
Saving the blobs of a file by now happens asynchronously to the processing in the FileSaver. Thus we have to account for the blobs queued for saving.

Was the change previously discussed in an issue or on the forum?
See https://github.com/restic/restic/actions/runs/3554529717/jobs/5970687531 and https://github.com/restic/restic/actions/runs/3558479192/jobs/5977170322 for failed test runs.

Checklist

[x] I have read the contribution guidelines.
[x] I have enabled maintainer edits.
[x] I have added tests for all code changes.
[ ] I have added documentation for relevant changes (in the manual).
[ ] There's a new file in changelog/unreleased/ that describes the changes for our users (see template).
[x] I have run gofmt on the code in all commits.
[x] All commit messages are formatted in the same style as the other commits in the repo.
[x] I'm done! This pull request is ready for review.

LGTM.


Making Windows x86-64 debug builds with Visual Studio 2019

I'm unable to carry out a x86_64.win64-debug builds using Visual Studio 2019.
Following the instructions in the README, setting up VS_HOME and WINDOWSSDK only as specified plus putting devenv.com in the PATH results in:
/cygdrive/c/Users/Administrator/opensplice/bin/ospl_wincmd link  -nologo -incremental:no -machine:X64 -subsystem:console -L/cygdrive/c/Users/Administrator/opensplice/lib/x86_64.win64-debug -L"/cygdrive/c/Program Files (x86)/Microsoft Visual Studio 14.0/VC/lib/amd64" -L"/cygdrive/c/Program Files (x86)/Windows Kits/10/Lib/10.0.10150.0/ucrt/x64" -L"/cygdrive/c/Program Files (x86)/Windows Kits/10/../8.1/Lib/winv6.3/um/x64" -L"/cygdrive/c/Program Files (x86)/Windows Kits/10/../8.1/lib/x64" -DEBUG -MANIFEST -NODEFAULTLIB:MSVCRT ospl_winln.obj   -o ospl_winln.exe
ospl_wincmd mt -manifest ospl_winln.exe.manifest "-outputresource:ospl_winln.exe;#1"
ERROR: exec failed 2

After some creative fiddling and setting
VS_HOME='/cygdrive/c/Program Files (x86)/Microsoft Visual Studio/2019/Community/'
WINDOWSSDKDIR='/cygdrive/c/Program Files (x86)/Microsoft Visual Studio/2019/Community/SDK'

I managed to get it going for a while up to a point where I get:
error CS0006: Metadata file 'C:\Program Files (x86)\Reference Assemblies\Microsoft\Framework\.NETFramework\v4.7.2\System.dll' could not be found
make[5]: *** [/cygdrive/c/Users/Administrator/opensplice/setup/makefiles/target-only.mak:157: dcpssacs.netmodule] Error 1

I'm probably not the first nor the last that comes with an error gist. Just trying to rule out obvious mistakes that someone else may be able to spot immediately.

@hidmic did you resolve this? For VS 2019 we use as default .net 4.7.2, when installing vs 2019 professional this gets installed also. I don't know how this is for the community edition as it seems that you are missing this dependency.

Hi,
this seems to me that the problem originates from the invocation of mt.exe (Microsoft reference here). This is sometimes a problem with code that gets built with toolchains which are made for non-Windows systems.
Windows SDK
The Windows SDK path you have shown is not correct. Visual Studio does not provide a Windows SDK installation. You have to install the Windows SDK separately. You can tick off a checkbox in the VS2019 installer that it gets installed too but it still is a seperate installation. Otherwise download and install it manually (e.g. download here).
After that you have to set the environment variable WINDOWSSDKDIR to C:\Program Files (x86)\Windows Kits\10 respectively '/cygdrive/C/Program Files (x86)/Windows Kits/10' like the README says and you are good to go.
export WINDOWSSDKDIR='/cygdrive/C/Program Files (x86)/Windows Kits/10'

mt.exe
The mt.exe is not shipped with the Visual Studio installation anymore and has been moved to the Windows SDK (since Visual Studio 2008 or 2010 I think). After you have installed the appropriate Windows SDK you can find the mt.exe in its folders. But there can be multiple occurences of the file as you can have multiple Windows SDK installations in parallel.
For me with Windows 10 SDK I have the following locations (depending on the platform the file should be executed on):
C:\Program Files (x86)\Windows Kits\10\bin\10.0.17763.0\arm64\mt.exe
C:\Program Files (x86)\Windows Kits\10\bin\10.0.17763.0\x64\mt.exe
C:\Program Files (x86)\Windows Kits\10\bin\10.0.17763.0\x86\mt.exe

Now the Vortex OpenSplice toolchain (as the most *inux-toolchains I have seen) expects that the mt.exe can be invoked just from anywhere thus is has to be in the PATH.
Most likely you are using a Windows 64 bit build system which means your PATH should contain the PATH to C:\Program Files (x86)\Windows Kits\10\bin\10.0.17763.0\x64 (the version part could be different).
Windows console command:
set PATH=C:\Program Files (x86)\Windows Kits\10\bin\10.0.17763.0\x64;%PATH%

or from the cygwin bash:
export PATH=/cygdrive/c/Program\ Files\ \(x86\)/Windows\ Kits/10/bin/10.0.17763.0/x64:$PATH


Use custom logo on DoltLab instance is not working for me.

Hi,
As I am looking to change my doltlab instance log by using this document, But is not working. Does anyone know the issue?
Note: I am using the doltlab version "public.ecr.aws/dolthub/doltlab/dolthub-server:v2.0.8"

"ALT_LOGO variable is not set. Defaulting to a blank string  " I am getting this warning when running the ./start-doltlab.sh

@resulraveendran you must be a DoltLab Enterprise client for the custom logo to work, cc @bpf120 who can discuss Enterprise more with you.


can't crawl tesla.com; context deadline exceeded

Hi, @kanXer!
Is there any progress?

No seem like they have implemented anti-scraping or bot detection because its works on other websites.


Fix spark_connect(master = "local") when version isn't set

This PR fixes an issue introduced by 84e7ce09a1769440bb92bb7196c08db18c943158 where connection in local mode fails when version isn't specified.
Current behavior:
> sc <- spark_connect(master = "local")
Error in shell_connection(master = master, spark_home = spark_home, app_name = app_name,  :
                            Failed to connect to Spark (SPARK_HOME is not set).

With patch:
> sc <- spark_connect(master = "local")
* Using Spark: 2.0.0

Yes, this makes sense. Thank you, Kevin.


Create additional info blocks

You can make your resume less official by adding more entertaining info, like your hobbies and interest, or what do you like, some interactive content or joke, easter egg, etc.

Info Blocks

The language block is not centered


sound/alsa: stop actual playback after PCM_STOP

Depends on #483
Summary of the PR

Queued buffers were played even after the guest issued PCM_STOP.
This commit makes the ALSA worker threads respect the stopped status
instead.

Requirements
Before submitting your PR, please make sure you addressed the following
requirements:

[x] All commits in this PR are signed (with git commit -s), and the commit
message has max 60 characters for the summary and max 75 characters for each
description line.
[x] All added/changed functionality has a corresponding unit/integration
test.
[x] All added/changed public-facing functionality has entries in the "Upcoming
Release" section of CHANGELOG.md (if no such section exists, please create one).
[x] Any newly added unsafe code is properly documented.

This commit makes the ALSA worker threads respect the stopped status
instead.
Why only the respecting the stop and not the start aswell?

IIUC this fixes the extra(unwanted) sound that is being reproduced at the end of aplay when using alsa backend right?

Hey Dorinda,

Why only the respecting the stop and not the start aswell?

Can you clarify what you mean by that? PCM_START was already handled (i.e. sound was playing) but when stopping the stream playback continued until flushing the I/O messages. This is what this commit fixes.

IIUC this commit fixes the extra(unwanted) sound that is being reproduced at the end of aplay when using alsa backend right?

Possibly, to be honest I do not recall this behavior right now but it sounds familiar.

Duplicate of https://github.com/rust-vmm/vhost-device/pull/487


Logging, refactor context

is @abirismyname awake?

is @breton16 awake?

Yo

wat

is @abirismyname awake?

is @abirismyname awake?

is @abirismyname awake?

is @abirismyname awake?

is @abirismyname awake?

is @abirismyname awake?

is @abirismyname awake?

is @abirismyname awake?

is @abirismyname awake?

is @abirismyname awake?

is @abirismyname awake?

is @abirismyname awake?

is @abirismyname awake?

is @abirismyname awake?

is @abirismyname awake?

is @abirismyname awake?

is @abirismyname awake?

is @abirismyname awake?

is @abirismyname awake?

is @abirismyname awake?

is @abirismyname awake?

is @abirismyname awake?

is @abirismyname awake?

is @abirismyname awake?

is @abirismyname awake?

is @manishapriya94 awake?

is @manishapriya94 awake?

is rufusmbugua awake?

is rufusmbugua awake?


Remove etcd-druid nondistroless prow job

What this PR does / why we need it:
Remove etcd-druid nondistroless prow job, since feature gate UseEtcdWrapper is promoted to GA by https://github.com/gardener/etcd-druid/pull/936.
Which issue(s) this PR fixes:
Fixes partially https://github.com/gardener/etcd-druid/issues/776
Special notes for your reviewer:
@oliver-goetz I am unaware of the prow job manifests under https://github.com/gardener/ci-infra/tree/master/config/jobs/etcd-druid/releases. Are these used only for running prow jobs against older release branches? If that's the case, I'm assuming I need not change them in this PR, correct? Please let me know.

@plkokanov @rfranzke PTAL. Not urgent, but would be nice to get rid of the now unnecessary prow job, since the feature gate on druid is moving to GA via https://github.com/gardener/etcd-druid/pull/936

/lgtm
/approve

/kind cleanup


[BUG] KoP cannot start with preciseTopicPublishRateLimiterEnable

Describe the bug
https://github.com/apache/pulsar/pull/7078 introduced the precise topic publish rate limiter, but if it was enabled in KoP, KoP would fail to start.
To Reproduce
Append following configurations to conf/standalone.conf:
messagingProtocols=kafka
kafkaListeners=PLAINTEXT://<IP_ADDRESS>:9092
brokerEntryMetadataInterceptors=org.apache.pulsar.common.intercept.AppendIndexMetadataInterceptor
entryFormat=kafka
allowAutoTopicCreationType=partitioned
brokerDeleteInactiveTopicsEnabled=false
preciseTopicPublishRateLimiterEnable=true

Then start standalone by bin/pulsar standalone.
The 6650 and 8080 ports were listened on, which means the broker service and web service succeeded to start. But the 9092 port was never listened on, which means KoP didn't start.
After I removed the preciseTopicPublishRateLimiterEnable=true config and restart, it worked well.
Expected behavior
KoP should start successfully with preciseTopicPublishRateLimiterEnable=true.
Screenshots
If applicable, add screenshots to help explain your problem.
Additional context
There're a lot of logs like:
16:41:52.822 [pulsar-timer-78-1] INFO  org.apache.pulsar.client.impl.ProducerImpl - [public/__kafka/__consumer_offsets-partition-42] [standalone-1-7] Message send timed out. Failing 1 messages
... (each partition of __consumer_offsets)
16:41:52.850 [pulsar-timer-78-1] INFO  org.apache.pulsar.client.impl.ProducerImpl - [public/__kafka/__consumer_offsets-partition-9] [standalone-1-40] Message send timed out. Failing 1 messages

It could also be reproduced in unit tests, just add
kafkaConfig.setPreciseTopicPublishRateLimiterEnable(true);

to KopProtocolHandlerTestBase#resetConfig and run any test.

It's fixed by https://github.com/apache/pulsar/pull/11446 that will be included in Pulsar 2.8.1.


Allow programmatic manipulation of task execution plans

Enable public APIs for modifying task execution plans. AFAICT execution plans are not available for programmatic manipulation through public APIs, even if the ExecutionPlan interface itself seems to be a public API.
Expected Behavior
Task execution plan manipulation should be available in the public API (within whenReady?) to enable programmatic configuration of requested tasks or task filters.
Current Behavior
Before Gradle 7.4, the execution plan was somewhat configurable through the use of TaskExecutionGraphInternal. In Gradle 7.4, execution plan configuration now requires an instance of ExecutionPlan, which is no longer available through the public API.
Context
We have a bootstrap task in our root project that we run automatically to update the development environment of all our developers in a transparent way. In order to force running this task in all builds (whether from the command line or IDE), we used to add a reference to it to StartParameter. When enabling configuration caching, however, we switched to adding the task to the graph directly using TaskExecutionGraphInternal.addEntryTasks(). Gradle 7.4 makes execution plans unavailable during the configuration phase, so this approach no longer works.

We'd like to add some APIs to allow build logic to mutate the execution plan in various ways, but in the mean time I think it would be good to get you off those internal types. The internal types can change at any time (as you've seen), and those particular ones will continue to be very volatile over the next few releases.
One way to do this would be to get the StartParameter mutations to be honored when the configuration cache is enabled. Do you have some more details about why you switched to using internal types when you enabled the configuration cache? Potentially there's something simple we can fix to get it to work.
Regarding adding new APIs, do you have a bit more details about the bootstrap task. eg what kinds of things does it do to update the dev environment? would you expect it to run before any other tasks?

Thanks, Adam! I gave {{StartParameter}} a try and, as it turns out, it works with configuration caching: the extended list of tasks is run even when restoring the graph from the configuration cache. I'm not sure whether it always worked and I assumed it wouldn't, or whether it got fixed in a recent version. Does Gradle offer any guarantees about mutating {{StartParameter.taskRequests}} during configuration time? Is there anything in particular we should worry about?
As for {{bootstrap}}, we use this task for setting up the development environment in areas unrelated to Gradle (since the Gradle build is entirely self-contained). We want the task to run with every build, started from the command line or the IDE, as a means to ensure that developers consistently work on the latest development environment configuration without the need for any manual intervention. The bootstrap task runs tasks like the following:

Deploy configuration scripts to the home directory.
Deploy git configuration.
Configure iTerm2 terminal profiles.
Compile and deploy Flipper plugins.
Fetch and install Android Studio and IntelliJ plugins.
Update the IDE configuration.
Fetch and configure custom checkstyle and ktlint rules in the IDE.
...

Since these tasks are unrelated to the build itself, they can run without any dependencies – just like the task had been added explicitly in the command line.


Clang 16 regression causes compilation error in ssl_stream in C++20 mode

Hello, I want to notify you about https://github.com/llvm/llvm-project/issues/60749
This is a problem in Clang itself but they decided that it is not a release blocker. Clang 16 will be released in a week and provided code is not compiling. Is it possible to change something on Beast side? It seems that the bug requires very specific conditions.
Sorry for inconvenience, we want to switch to LLVM 16 asap and I'm not sure what to do in light of this bug.

FYI
For our purposes we just made this small patch, after that Beast compiles fine
diff --git a/boost/beast/ssl/ssl_stream.hpp b/boost/beast/ssl/ssl_stream.hpp
index d7ce7c1..51cc9d0 100644
--- a/boost/beast/ssl/ssl_stream.hpp
+++ b/boost/beast/ssl/ssl_stream.hpp
@@ -673,7 +673,7 @@ public:
         ssl_stream<SyncStream>& stream,
         boost::system::error_code& ec);

-    template<class AsyncStream, BOOST_BEAST_ASYNC_TPARAM1 TeardownHandler>
+    template<class AsyncStream, class TeardownHandler>
     friend
     void
     async_teardown(
@@ -697,7 +697,7 @@ teardown(
 }

 template<class AsyncStream,
-        BOOST_BEAST_ASYNC_TPARAM1 TeardownHandler = net::default_completion_token_t<beast::executor_type<AsyncStream>>>
+        class TeardownHandler = net::default_completion_token_t<beast::executor_type<AsyncStream>>>
 void
 async_teardown(
     boost::beast::role_type role,

Loosening requirements is not good but Clang bug lies exactly in applying concepts in template list so removing concepts helps. In original issue someone mentioned that you can also move concept to requires clause, like template<Concept x> to template<class x> requires Concept(x) or something similar, but I did not manage to get working version of this.

Am I correct that this didn't make it into 1.83 despite the assigned milestone?

Archlinux has bumped to clang 16 now, causing this error to pop up on my local development machine.  clang15 package is available in extras, but would be nice to be able to build with clang 16 too.

Similar issue over at FreeBSD and most likely several other places too. I'm not involved in boost development but maybe this would justify a patch release (i.e. boost 1.83.1)?

Yeah, I forgot to merge in time. Issue is fixed in develop. Really sorry about that.

Yeah, I forgot to merge in time. Issue is fixed in develop. Really sorry about that.

Could you share a link to the particular commit so downstream package maintainers could potentially ship the patch if no 1.83.1 release is planned to address this issue (is there?)?

https://github.com/boostorg/beast/commit/72c2eeb3980ed0dc530de9241e25b247517de018


cloudapi: Add /distributions/{arch} to cloudapi

This pull request includes:

[X] adequate testing for the new functionality or fixed issue
[ ] adequate documentation informing people about the change such as

[ ] submit a PR for the READMEs listed here
[ ] submit a PR for the osbuild.org website repository if this PR changed any behavior not covered by the automatically updated READMEs

I'm thinking I want to extend this to return more, so converting to draft for now.


Split data from root TinaCMS provider

Based off of the bones of this POC.
Giving the user the option to use forms separately from the root TinaCMS component via useTina.
A few things to note:

Currently, if you were to have multiple useTina calls on the same page, one would override the other. If we want to change this behaviour, I think splitting up useGraphqlForms would be a precursor.
I tweaked useGraphqlForms so that it won't blow up if you pass in an empty query.

fixes: #2413
Bundle size for each page with useTina increases ~-.09kB (Importing the hook from our Tina Provider, but not TinaCMS)

TODO:

[x] Allow the user to use/not-use render props
[x] Fix issue when switching between pages
[x] Sanity check bundle size to make sure we're not bundling tinacms in the prod bundle
[x] Test backwards-compatibility if you are to pass query/variables into <TinaCMS>, using/not-using render prop etc.
[ ] Should formify be allowed at the hook level?
[ ] Decide on naming (useTina?)
[ ] Prep documentation

Currently, if you were to have multiple useTina calls on the same page, one would override the other.

Is this an issue when someone uses the <TinaCMS> query/variables props and the new hook? The useGraphQLForms refactor I'm working on will handle this, that being said I think we can ignore that problem for now since we don't anticipate this hook to be used anywhere besides the top of the tree until we get read-only tokens.

Currently, if you were to have multiple useTina calls on the same page, one would override the other.

Is this an issue when someone uses the <TinaCMS> query/variables props and the new hook? ...

Yeah that functionality wouldn't be supported as is, It would likely just override the root  query with the page query.


Improve 1.7 upgrade and nodeport documentation

Document the steps necessary for handling the kubernetes.io/cluster-service label change in the Cilium DaemonSet
Clarify the limitations on the externalIP service implementation

This change is

test-docs-please

Coverage increased (+0.02%) to 46.058% when pulling 9b6223ad46f013e6b3affb7afbdcf53e05a48ab8 on joestringer:submit/1-7-upgrade into 5bc434dc70c8a8219c65c9c9ad92eb67dd61992a on cilium:master.

test-docs-please


ABY inner product AMI: volume size

Hi,
I cannot deploy instances for the ABY inner product protocol since the disk is too small (see below for a traceback). In deploy_instances() the disk image is fixed to a size of 20 G:
https://github.com/cryptobiu/MATRIX/blob/92cc27b504d4e7fa48dedfe0194e2633b375bc8e/Deployment/aws_deploy.py#L144 The error message says that the snapshot for the AMI needs at least 100 G. Is an image that big necessary?
Welcome to MATRIX system.
Please Insert your choice:
1. Deploy Menu
2. Execute Menu
3. Analysis Menu
4. Generate Circuits
5. Exit
Your choice:1
Enter configuration file(s):
Configuration file path (current path is: /path/to/MATRIX): ProtocolsConfigurations/Config_ABY_InnerProduct.json
Choose cloud provider:
1. AWS
2. Scaleway
Your choice:1
Choose deployment task
1. Deploy Instance(s)
2. Create Key pair(s)
3. Create security group(s)
4. Get instances network data
5. Terminate machines
6. Change machines types
7. Start instances
8. Stop instances
Your choice:1
Current date :
2018-09-16 08:31:13.071261
Deploying instances :
region : us-east-1b
number of instances : 2
ami_id : ami-08c9a677
instance_type : c5.large
valid until : 2018-09-16 14:31:13.071261
Traceback (most recent call last):
  File "main.py", line 171, in <module>
    main()
  File "main.py", line 159, in main
    print_instances_management_menu(conf_file_path)
  File "main.py", line 54, in print_instances_management_menu
    deploy.deploy_instances()
  File "/path/to/MATRIX/Deployment/aws_deploy.py", line 167, in deploy_instances
    'Value': protocol_name
  File "/path/to/MATRIX/.venv/lib/python3.7/site-packages/botocore/client.py", line 320, in _api_call
    return self._make_api_call(operation_name, kwargs)
  File "/path/to/MATRIX/.venv/lib/python3.7/site-packages/botocore/client.py", line 623, in _make_api_call
    raise error_class(parsed_response, operation_name)
botocore.exceptions.ClientError: An error occurred (InvalidBlockDeviceMapping) when calling the RunInstances operation: Volume of size 20GB is smaller than  snapshot 'snap-0cfcf1ed8aca9f22e', expect size >= 100GB

Hi,
The disk size determined by the AMI. No need to specify it.


Catch up to BDK for IonQ error mitigation, image URIs, and new additionalMetadata

Issue #, if available: N/A
Description of changes: Catch up to BDK for IonQ error mitigation, image URIs, and new additionalMetadata
Testing done: Unit and integ tests passed locally
Merge Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.
General

[x] I have read the CONTRIBUTING doc
[x] I used the commit message format described in CONTRIBUTING
[x] I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

[x] I have installed and run git secrets to make sure I did not commit any sensitive information (passwords or credentials)
[x] I have added tests that prove my fix is effective or that my feature works (if appropriate)
[x] I have checked that my tests are not configured for a specific region or account (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Codecov Report
Attention: 28 lines in your changes are missing coverage. Please review.

Comparison is base (f42a5ec) 95.30% compared to head (f2aacfd) 79.70%.

Additional details and impacted files
@@             Coverage Diff             @@
##             main      #66       +/-   ##
===========================================
- Coverage   95.30%   79.70%   -15.61%
===========================================
  Files          35       36        +1
  Lines        3831     3744       -87
===========================================
- Hits         3651     2984      -667
- Misses        180      760      +580

Files
Coverage Δ

src/Braket.jl
100.00% <ø> (ø)

src/local_jobs.jl
100.00% <100.00%> (ø)

src/task.jl
98.45% <100.00%> (-0.06%)
:arrow_down:

src/error_mitigation.jl
0.00% <0.00%> (ø)

src/jobs.jl
85.71% <66.66%> (ø)

src/raw_schema.jl
89.23% <13.33%> (-4.72%)
:arrow_down:

... and 24 files with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


name threads

#54  👈
master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @pepyakin and the rest of your teammates on  Graphite


outlookMsgToEmail loses nested msg attachments

Code:
public static void main(String[] args) throws IOException {
    viewMsg();
    viewEml();
}

public static void viewMsg() throws IOException {
    Email em1 = EmailConverter.outlookMsgToEmail(new File("Email.msg"));
    System.out.println("--------------------------------------------------------");
    System.out.println(em1.getSubject());
    System.out.println(em1.getAttachments());
    System.out.println("--------------------------------------------------------");
}

public static void viewEml() throws IOException {
    Email em1 = EmailConverter.emlToEmail(new File("Email.eml"));
    System.out.println("--------------------------------------------------------");
    System.out.println(em1.getSubject());
    System.out.println(em1.getAttachments());
    System.out.println("--------------------------------------------------------");
}

Expected result:
Email
AttachmentResource
{
name='PHOTO-2020-02-18-07-42-08_1.jpg',
dataSource.name=PHOTO-2020-02-18-07-42-08_1.jpg,
dataSource.getContentType=image/jpeg
},
AttachmentResource{
name='This msg file is an attachment.msg',
dataSource.name=This msg file is an attachment.msg,
dataSource.getContentType=application/octet-stream
}
--------------------------------------------------------

--------------------------------------------------------
Email
AttachmentResource
{
name='PHOTO-2020-02-18-07-42-08_1.jpg',
dataSource.name=PHOTO-2020-02-18-07-42-08_1.jpg,
dataSource.getContentType=image/jpeg
},
AttachmentResource{
name='This msg file is an attachment.msg',
dataSource.name=This msg file is an attachment.msg,
dataSource.getContentType=application/octet-stream
}]
--------------------------------------------------------

Actual result:
Email
AttachmentResource
{
name='PHOTO-2020-02-18-07-42-08_1.jpg',
dataSource.name=PHOTO-2020-02-18-07-42-08_1.jpg,
dataSource.getContentType=image/jpeg
}
--------------------------------------------------------

--------------------------------------------------------
Email
AttachmentResource
{
name='PHOTO-2020-02-18-07-42-08_1.jpg',
dataSource.name=PHOTO-2020-02-18-07-42-08_1.jpg,
dataSource.getContentType=image/jpeg
},
AttachmentResource
{
name='This msg file is an attachment.msg',
dataSource.name=This msg file is an attachment.msg,
dataSource.getContentType=application/octet-stream
}
--------------------------------------------------------

Do you have a test message for me to analyse the problem with?

Do you have a test message for me to analyse the problem with?

Sory yes, I meant to attach. Both Emails from the sample code are in the zip.
Email.zip

Sory yes, I meant to attach. Both Emails from the sample code are in the zip.
Email.zip

I tested this with https://github.com/bbottema/outlook-message-parser directly which had no issues at all. I'll see what happens with Simple Java Mail...

I tested this with https://github.com/bbottema/outlook-message-parser directly which had no issues at all. I'll see what happens with Simple Java Mail...

Ahh, In OutlookEmailConverter#71, I can see it is omitted by design, because I didn't know how to translate an Outlook attachment to a Datasource (standard java type), which is the attachment data type in Simple Java Mail for all regular attachments (which already contains a byte[] and a mimetype, which is what comprises a Datasource).
I still wouldn't know how to convert that, because outlook-message-parser obviously returns a custom data class for nested Outlook msg file, rather than the msg file itself as raw binary file. Perhaps outlook-message-parser should include the original msg file in the custom class so we can always get the original data back...
Other ideas?

Ahh, In OutlookEmailConverter#71, I can see it is omitted by design, because I didn't know how to translate an Outlook attachment to a Datasource (standard java type), which is the attachment data type in Simple Java Mail for all regular attachments (which already contains a byte[] and a mimetype, which is what comprises a Datasource).
I still wouldn't know how to convert that, because outlook-message-parser obviously returns a custom data class for nested Outlook msg file, rather than the msg file itself as raw binary file. Perhaps outlook-message-parser should include the original msg file in the custom class so we can always get the original data back...
Other ideas?

Ok, I've found a way to deal with this. So the problem is that Outlook parsing is one-way: from .msg to a Java object structure. Since these are attachments, they have to be DataSource objects instead. In this case I used Email's semi-recent ability to serialize to a binary value which can then be encapsulated as a DataSource.
So, here's how to to read an Email and access its nested Outlook message:
public Email getNestedOutlookMessage(...yourOutlookMessageSource) {
	Email email = EmailConverter.outlookMsgToEmail(yourOutlookMessageSource);

	// now the nested Outlook message is converted to an Email and subsequently serialized:
	// email.getAttachments().get(0).getName() == "attachment 0 as nested Outlook message (converted).sjm"

	InputStream sjmInputstream = email.getAttachments().get(0).getDataSourceInputStream();
	Email nestedOutlookMessage = deserializeEmail(sjmInputstream);

	return nestedOutlookMessage;
}

private Email deserializeEmail(InputStream sjmInputStream) {
	try (ObjectInputStream in = new ObjectInputStream(sjmInputStream)) {
		return (Email) in.readObject();
	} catch (final ClassNotFoundException | IOException ex) {
		throw new SerializationException(ex);
	}
}

Released in 6.5.0

Using 6.5.2 I am able to access a nested Outlook message as above, and I can use EmailConverter.emailToEML(nestedOutlookMessage) to get a .eml version of the nested message.
However - if the nested message itself includes an attachment (in my example a Word file), then I see the following error from emailToEML()
Exception in thread "main" java.lang.NullPointerException
at org.simplejavamail.converter.internal.mimemessage.MimeMessageHelper.determineResourceName(MimeMessageHelper.java:270)
at org.simplejavamail.converter.internal.mimemessage.MimeMessageHelper.getBodyPartFromDatasource(MimeMessageHelper.java:252)
at org.simplejavamail.converter.internal.mimemessage.MimeMessageHelper.setAttachments(MimeMessageHelper.java:193)
at org.simplejavamail.converter.internal.mimemessage.MimeMessageProducerMixedAlternative.populateMimeMessageMultipartStructure(MimeMessageProducerMixedAlternative.java:39)
at org.simplejavamail.converter.internal.mimemessage.MimeMessageProducer.populateMimeMessage(MimeMessageProducer.java:86)
at org.simplejavamail.converter.internal.mimemessage.MimeMessageProducerHelper.produceMimeMessage(MimeMessageProducerHelper.java:55)
at org.simplejavamail.converter.EmailConverter.emailToMimeMessage(EmailConverter.java:449)
at org.simplejavamail.converter.EmailConverter.emailToMimeMessage(EmailConverter.java:441)
at org.simplejavamail.converter.EmailConverter.emailToEML(EmailConverter.java:544)
Attached an email with attached Outlook message that works (Email.msg) and one that fails (Email2.msg).
Email2.zip

Thank you, I will look into it asap.

I was going to give up trying to serialize/deserialize the nested attachments, even after switching the Kryo. But I got it working finally.
So the OutlookModule now has an extra dependency on Kryo, but nested attachments are now maintained when trying the read back nested outlook messages. I'm including a convenient SerializationUtil to keep your code clean:
public Email getNestedOutlookMessage(...yourOutlookMessageSource) {
	Email email = EmailConverter.outlookMsgToEmail(yourOutlookMessageSource);

	// now the nested Outlook message is converted to an Email and subsequently serialized:
	// email.getAttachments().get(0).getName() == "attachment 0 as nested Outlook message (converted).sjm"

	InputStream sjmInputstream = email.getAttachments().get(0).getDataSourceInputStream();
	Email nestedOutlookMessage = SerializationUtil.deserialize(sjmInputstream);

	return nestedOutlookMessage; // now with attachments, yay!
}

I haven't pushed the changes yet and haven't released yet, because my family came over now, but I'll get it out soon :)

Thanks for this.

Since this feaure was released already and can be in only one milestone, I've added a new issue #314 detailing this bug and its solution.


ref(*): mock the k8s API interactions and remove Container model

This change removes the Container model as it is redundant and changes around the MockScheduler to instead mock out actual k8s API calls and responses to get real testing of the scheduler code.
Chaos scheduler was ripped temporarily but will be readded in the future (see #412)
More logic needs to go into the mock handling to deal with pod transitions
Fixes #29, #60

Current coverage is 76.39%

Merging #497 into master will decrease coverage by -6.62% as of 330c481

@@            master    #497   diff @@
======================================
  Files           32      36     +4
  Stmts         1914    2275   +361
  Branches       270     326    +56
  Methods          0       0
======================================
+ Hit           1589    1738   +149
- Partial         61     111    +50
- Missed         264     426   +162

Review entire Coverage Diff as of 330c481

Powered by Codecov. Updated on successful CI builds.

Closes #512

@helgi made a few "meta" comments, but code LGTM

I've seen failures from make test-unit on this PR. One example:

======================================================================
FAIL: test_tags (api.tests.test_config.ConfigTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/usr/local/Cellar/python3/3.5.1/Frameworks/Python.framework/Versions/3.5/lib/python3.5/unittest/mock.py", line 1157, in patched
    return func(*args, **keywargs)
  File "/Users/matt/Projects/src/github.com/deis/controller/rootfs/api/tests/test_config.py", line 472, in test_tags
    self.assertEqual(response.status_code, 201)
AssertionError: 400 != 201

----------------------------------------------------------------------
Ran 152 tests in 37.485s

Fixes #522

The approach looks good to me, though the tests need to go green.


Possibility to define endpoint in the .password-s3fs file

Would it be possible to let users define their own custom endpoint in the config file?
I've got a use case where it would be suitable to easily mount a custom S3 storage as a catalogue.

Where do you find reference to a .password-s3fs?
s3fs uses boto configuration options, so anything they provide, we we implicitly use; I am unaware of an endpoint config in a file or environment variable.


added LocalizationService SystemLocaleId

Looks good, can you add an entry to FEATURES.md here too?

Coverage increased (+0.02%) to 96.337% when pulling 08b3617c9b9f8e6756cd422acb8f488cca6f7681 on aportner:localization-system-locale-id into cbf189b6bb7698c0e1f79ccdea4fd42d608ce931 on LPGhatguy:master.


Feature request - migrations add

Current bahaviour:
dotnet ef migrations add -> Missing required argument '<NAME>'.
Required behaviour:
dotnet ef migrations add -> Create new migration based on previous name with autoincremented index.
example:
Previous migration name is "migration_12". After execution command "dotnet ef migrations add", new migration is created with name "migration_13".
Use case - Business model is under development and is constantly changing. User is going to make hundreds of changes in a couple of days. User wants to continuously sync model with db schema.
There is no need to make migrations with semantic naming.
Note: Is there a better alternative to automatically sync db schema to the data model without creating migration?

Looking for #3053?

@kmolerov As @bricelam says, the underlying motivation here seems a lot like #3053, so I'm going to close this as a duplicate. However, any solution to #3053 is likely to involve not creating explicit migrations rather than using auto-incrementing IDs. For explicit migrations, we think that using a semantic name is better practice that ID numbers. This doesn't mean you can't use numbers manually, but rather that we won't promote it by building it into the API.


Allow inputing policies directly into the yaml file, without pointing to a file

policy: |
  pattern not-affected = cyclonedx::component-purls | lang::map<uri::purl> | osv::from-purl | openvex::from-osv | list::none<openvex::affected>
name: vulnerabilities::not-affected

I think instead the action should point to an 'enforcer' configuration file, which could potentially refer to policies by file, string-literal (as you suggest here) or urls. But I don't think it should be part of the GHA configuration, which IMHO should be kept minimal and only point to a configuration file (i.e .seedwing/enforcer.toml by default) so that we can provide a consistent CI experience across GHA and other CI systems


How to hide prev and next arrows

Hi
I have ngx-swiper-wrapper version ^10.0.0
I have a slider with 5 items and with prev and newxt arrows
I need to hide prev arrow when slider is displayed the first time and also when there are no more previous items to show
and I need to hide next arrow when all items are displayed.
Which is the right way to do that?
Now I'm using directiveRef.getIndex() in order to know the current index, then I sum slidesPerView value and, if total is <= my list lenght, then I hide arrow
I don't know if there is a better way to do that
The problems here are:

Number of slidesPerView changes depending on resolution
If user drag and drop items instead of clicking on arrows, I don't know the index of the slide
This second problem could be resolved if i can disable drag and drop of items inside slider. Is this possible?

Thanks

as i know it hides automatically,


Put files & specs in correct folder

Somehow they start to live in different home: request_sources, and request_source. This Pull Request brought those wrongly lived files and specs 🏠.

Ah great, I'm ok with using my admin powers to merge this, just a conflict on the CHANGELOG 👍

just a conflict on the CHANGELOG

Resolved 🙇

Cool - yep, looks like just danger failing 👍


Implement expansion of wildcards for Windows

Implements expansion of wildcards ("globbing") via the 'wild' crate
Should close issue #39

Side-note: I noticed that cargo test gives me three errors, but it did that even prior to my changes. Is this known?

Thanks for looking out for the windows users!
I'll take a look at those failing tests, thanks for the heads up.


Remove console warnings & errors

While running npm test one get following console warnings and errors which are maybe due to not updating Examples while updating props of elements. This issue can be resolved by updating examples as required.

Hi @interactivellama, I am working on it. Please comment if there are any more guidelines attached to this issue.


change facebook comment font color

Hi.
How can I change the font color of a facebook comment to be white, please?

Don't think Facebook lets you control the color that way. You can either use the light or dark color scheme for all comments.
You'll have to dig through their API to see if it's possible.


添加JustList: {YUSD}

检查清单

[ x ] 我已知晓此issue不是提交token而是提交JustList
[ x ] 我已经测试粘贴JustList URL到justswap.org的添加列表中并能够正常展示.
[ x ] 我已知晓提交的issue不能确保通过并且提交的JustList不确保能在jsutlists网站中显示.

请提供以下的信息
JustList的json URL必须以HTTPS开头.
JustList URL: https://raw.githubusercontent.com/aoeng/younique/master/justlists.json
JustList 名称: YUSD-JustList
JustList 提交者的网站或主页:  https://www.youni.cool/tw/yusd

Thanks for reaching out.
We are currently very tight on development resources and adding new lists on a case-by-case basis.
If timing is a key issue for you, we recommend you join the existing community SUNSWAP list, for example: Tron Alliance List: https://github.com/listtronalliance/tronalliance.
Thanks.


Metadata request connection error region failover

Background
Operations which have end-to-end timeout configured have no way of marking a region as unavailable as the operation times out and gets cancelled much earlier than the time it takes for connection establishment to time out with the replica or the gateway. Connection timeouts could be symptomatic of a region-outage and therefore requires the region to be marked as unavailable.
This PR tracks the cancellation status of such timed-out requests and triggers an additional address refresh call when a connection establishment times out (to recover from a bad region), or server-side 410 (to recover from stale caches) errors are thrown. An address refresh call is a metadata request which is made to the gateway. If the SDK sees connection issues with the gateway as well, the region is marked as unavailable. This helps subsequent requests to make use of other regions that may have been configured for the account.

API change check
API changes are not detected in this pull request.

/azp run java - cosmos - tests

/azp run java - cosmos - tests

/azp run java - cosmos - tests

/azp run java - cosmos - tests

/azp run java - cosmos - tests

Issues created:

https://github.com/Azure/azure-sdk-for-java/issues/35938
https://github.com/Azure/azure-sdk-for-java/issues/35905
https://github.com/Azure/azure-sdk-for-java/issues/35904

The live test pipeline fails on the following

CosmosConflictsTest - known flaky test, tests pass locally
CosmosBulkTest - tests pass locally
AsyncCacheNonBlockingIntegrationTest - tests pass locally

/check-enforcer override


Test.fm integration

Evaluate how to integrate test.fm into reference framework, the following task has to be integrated into the fmw:

the evaluator splits the dataset into test and training sets, generating the related files.
the evaluator sends the training set to train the algorithm: the evaluator writes on a configured location the files to be used as training set. The algorithm regularly checks this location for new files
the algorithm notifies the evaluator that the training is completed: the algorithm writes a new file in a configured location. The evaluator regularly checks this location
the evaluator sends the recommendation requests (e.g., a set of user to compute the TOP-10 recommendation for). the evaluator writes on a configured location the files containing the userids and the command to execute (e.g., GETTOPRANK).
The algorithm checks such folder and will compute the recommendations, saving the results in a configured path. The evaluator will reads such results and will be able to compute the quality metric.

Arise any doubt on interfaces and orchestration process (https://github.com/crowdrec/reference-framework/wiki/ORCHESTRATOR)

we have a new avaluation logic, no need of integration with test.fm


EF ignores ValueGeneratedOnAdd

Describe what is not working as expected.
Steps to reproduce
I have following model
public class Area
{
        [DatabaseGenerated(DatabaseGeneratedOption.Identity)]
        public DateTimeOffset CreatedDate { get; set; }

        [Key]
        [DatabaseGenerated(DatabaseGeneratedOption.Identity)]
        public Guid Id { get; set; }

        public string Name { get; set; }
}

I've even added manually:
builder.Entity<Area>().Property(r => r.Id).ValueGeneratedOnAdd();

The query generated by EF is:
exec sp_executesql N'SET NOCOUNT ON;
INSERT INTO [Job].[Area] ([Id], [Name])
VALUES (@p0, @p1);
SELECT [CreatedDate]
FROM [Job].[Area]
WHERE @@ROWCOUNT = 1 AND [Id] = @p0;

',N'@p0 uniqueidentifier,@p1 nvarchar(4000)',@p0='0E466D42-ED59-4023-6E49-08D62F701EBE',@p1=N'test'

I would expect that Id will be generated by server. but it is inserted.
Further technical details
EF Core version: 2.1.4
Database Provider: (Microsoft.EntityFrameworkCore.SqlServer)
Operating system:  Windows 10 Pro
IDE: (e.g. Visual Studio 2017 15.8.7)

@msmolka See my answer here: https://github.com/aspnet/EntityFrameworkCore/issues/10070#issuecomment-336502376


Changing visibility after being set does not change

Testing #103833

Set a view to hidden
Launch extension, view is hidden
Change view to collapsed
Relaunch extension
:bug: visibility does not change

I would only expect this to not be respected only when the user has made a change to the view

Agree, seems like after launching once, VS Code remembers the view state even it I didn't touch the view. The only way I could get changes to visibility to take was to set a new --user-data-dir each time to simulate first launch.

This is intentional, visibility is only respected the first time. We don't want to start changing the visibility of views for existing users.

Not sure I agree with this, I'd imagine from an extension author's perspective it would be annoying that you couldn't hide/collapse certain views for existing users if they didn't modify that view.


Latest SNP OVMF binary causes measurement failure

The OVMF binary that's built using the AMDSEV repository now contains a SVSM Calling Area Address (CAA) section type.
Defined here as:
%define OVMF_SECTION_TYPE_SVSM_CAA        0x4

This causes the measurement to fail with
ValueError: 4 is not a valid SectionType

Could you give me some guidance on how I could fix the measurement calculation?

Thank you @ShannonSD for reporting this issue with new OVMFs.
I think this is what needed to support it:

Add the new section type to the SectionType enum definition in ovmf.py
Add another if clause in function snp_update_section in guest.py; it seems that for this section it should be measured as a zero page.

Hi @dubek,
Thank you for the response, I've modified the snp_update_section as you've explained to measure the OVMF_SECTION_TYPE_SVSM_CAA page as zero pages.
However,  the launch measurement in the attestation report does not match the digest produced by this tool.
I am uncertain whether this is because of the change in the snp_update_section or whether I am doing something wrong when trying to generate the digest.
I am using the AMDSEV repository (snp-latest branch) to create the OVMF binary, guest and host kernels (6.9.0 patched), and qemu. The build has been modified to build "OvmfPkg/AmdSev/AmdSevX64.dsc" as I'd like to measure the kernel.
The VM is launched using the launch-qemu.sh script, the launch command is:
/home/ubuntu/AMDSEV/snp-release-2024-05-27/usr/local/bin/qemu-system-x86_64 -enable-kvm -cpu EPYC-v4 -machine q35 -smp 4,maxcpus=255 -m 2048M,slots=5,maxmem=10240M -no-reboot -bios /home/ubuntu/AMDSEV/snp-release-2024-05-27/usr/local/share/qemu/OVMF.fd -netdev user,id=vmnic,hostfwd=tcp::8000-:22 -device e1000,netdev=vmnic,romfile= -drive file=/home/ubuntu/img/disk.qcow2,if=none,id=disk0,format=qcow2 -drive if=virtio,format=raw,file=../seed.img -device virtio-scsi-pci,id=scsi0,disable-legacy=on,iommu_platform=true -device scsi-hd,drive=disk0 -machine memory-encryption=sev0,vmport=off -object memory-backend-memfd,id=ram1,size=2048M,share=true,prealloc=false -machine memory-backend=ram1 -object sev-snp-guest,id=sev0,cbitpos=51,reduced-phys-bits=1 -nographic -monitor pty -monitor unix:monitor,server,nowait

The measurement is generated using:
sev-snp-measure.py \
    --mode snp \
    --vmm-type=QEMU \
    --vcpus=4 \
    --vcpu-type=EPYC-v4 \
    --ovmf=AMDSEV/snp-release-2024-05-27/usr/local/share/qemu/OVMF.fd

I've tried using the tool within the guest VM to directly measure the kernel as well using (copied the ovmf binary into the guest):
sev-snp-measure.py \
    --mode snp \
    --vmm-type=QEMU \
    --vcpus=4 \
    --vcpu-type=EPYC-v4 \
    --ovmf=OVMF.fd \
    --kernel=/boot/vmlinuz

The measurement still doesn't match.
Finally, I've even tried using the --guest-features parameter with 1 and 33.
Do you see an issue with my use of the measurement tool?

Are you working with sev-snp-measure 0.0.10 or 0.0.9? On last Friday I released 0.0.10 which includes the merged PR #48 which modifies the VMSA. However, depending on the host kernel, this might not be what you want... You can try with the other version.
Also, don't pass --kernel to sev-snp-measure if you didn't also pass -kernel to QEMU and enabled kernel-hashes=on.

The issue is resolved with release 0.0.10.
Thank you @dubek !

Thanks to @DGonzalezVillal and @larrydewey , the original issue (ValueError: 4 is not a valid SectionType) is fixed in PR #53 and now released as sev-snp-measure 0.0.11 (on pypi).


getting error when setup fresh bagisto from master

Bug report

git clone https://github.com/bagisto/bagisto

cd bagisto

composer create-project

Same issue here, seems to be caused by the latest merge 7ea7eadfb6a03dba7481261c82da76f947bbbcee (same error appears in CI output) as I'm able to install when reverting to the previous commit 4f92ca602fc15ffb038dde1db1d153ce90503f4e.

@GiovanniMounir
please check now it's working fine with the updated commit.


remove major sorting

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.02%) to 77.047%

Totals

Change from base Build<PHONE_NUMBER>:
-0.02%

Covered Lines:
715

Relevant Lines:
928

💛  - Coveralls


remain object coordinates in scene when marker is off camera?

Is there a way to remain the object in the last seen coordinates when marker is off camera?
so if I turn my camera away from marker, the object still response to camera rotation like in a-frame?
an alternative way I tried is to use a-maker-camera, but the object was fixed to screen position, not world coordination, not the behavior I want.
any ideas please? :)

You could in fact do this with placing a hidden object in the marker and feed the global coorss to your model which recides outside the marker. You would need to somehow get accellerameter values for zooming when the marker is not detected. This isn't trivial though as you'dd need to gather stats on the sensors data compared to the marker position when detection is lost and found again or else the model will jump around.

Sorry, I am new, and this sounds a lot complex than I expect...
basically I was looking for a way to keep displaying object when marker is off camera,
After some search I found it is not possible, unless using SLAM.
but I wonder if it is possible to fake it, e.g. when the marker is visible, put object on it, when marker is off camera, record its last position and let gyro take over, so objects still response to phone rotation like a-frame does. When a marker is visible again, the marker position will overwrite object position.
Again, I am a layman to coding.....

Of course that is possible, you described the logic behind it - but nobody has written that code. Problem is that this wouldn't look and "feel" good or natural in any way to the user.

thanks for your opinion, I was quiet surprised no one tried it before,
this may solve occasional lost-tracking issue, keep object say in the scene.  I think it worth a try?

I have this problem too ... please write your solution code

@janpio The experience would probably feel a bit weird if the solution was just to use the giro sensors and the effect would be like in VR, but if you could also get in depth perception with the accelerometer sensor then I think the transition would work. There's just quite a bit of work to get this to really function and that involves gathering statistical data from the sensor and and using that to auto correct positioning in relation to the marker when it's found again.


Exponential Backoff or Interval

To upload the metadata one would need Exponential Backoff or Interval. How and where could we implement that.
_ipfsMetas.json
shows
"code": "quota_limit",
"message": "Too many requests hit the API too quickly. We recommend an exponential backoff of your requests. If you need higher limits see https://nftport.xyz/pricing"

I've fixed this issue by re-writing some of the code. I've added the updates to a new branch.
https://github.com/codeSTACKr/video-source-code-create-nft-collection/tree/fix-uploads-mints


Update README for FOSS support

Thank you for your PR. However at this point of time, we don't think it is strictly relevant to the subject matter at hand or significantly improves documentation. We hope to see more contributions from you in the future!


Bump loki queriers to statefulsets to use pvc for sync'ing indices

Description
This PR addresses a performance optimization when running Loki queriers with boltdb indices. In detail it bumps queriers to statefulsets to use PVC for storing boltdb index files after syncing them from the object storage. This ensures that queriers don't require to share the node disk. Furthermore it aligns with grafana/loki/pull/2547.

@squat I believe we are fine now to merge? WDYT?


Out of Stock filter not working

I have installed this module. Its working Fine. Out of Stock is not working that url is coming empty. But in stock is working fine.
Please help me.
Thanks !
Alex

@alvaialex First make sure that the "Show out of stock products" flag is set to yes in System->Configuration->Inventory->Stock Options.
then make sure your indexes are up to date.

Hello tzyganu
i install and select Show out of stock products .but dont show in my frontend
regards

Hi Tzyganu,
Thanks for your response. In my product listing page all products are listing. instock product as well as out of stock products, but out of stock filter not working.
Thanks
Alex

@alvaialex What Magento version are you using? Are the indexes up to date?

Hi Tzyganu,
Magento Community edition <IP_ADDRESS>
Yes, indexing up to date. clear catch also.
Thanks
Alexander

The filter is not working or the filter option is not appearing? I cannot reproduce the issue. It works fine on my install. Do you have any other extensions related to layered navigation?

Filter is not appearing. Also i have installed amasty layered navigation pro extension.

There is a chance that the amasty extension is not compatible with my extension (or the other way around). Try disabling that extension and see if it works. Also make sure that the stock filter extension is enabled from system->configuration.

When i am install magento fresh pack its working fine.
Is there any chance to combine both extension :)

Sorry, but I don't have access to the amasty extension and making them compatible is not in the scope of this extension.
I guess you cannot use both.
I will close this issue since is not related to the extension itself.

Hi tzyganu,
Thank you very much. Thanks for your time.
I will try to do that.


[Discussion] Bad training results

As title says.
Why after I've trained a model, the two resulting stems kind of bleed in to each other.
Both of them vaguely have audio from each other.

Hi @aidv
Short answer: Source separation is hard :)
Since we don't know your data it's impossible to say what's possibly going wrong or not. You may want to analyze your learning process, specifically whether it overfits or underfits your training data.  If your dataset is not so large, it's also probably to fine-tune an existing pre-trained model rather that trying to train from scratch.
Finally, don't hesitate to evaluate your trained model on public datasets such as musdb. In any case, look for the file where the separation results are not good and try to understand why (mixing conditions ? unbalance of this genre in your dataset ? ...)
As always in machine learning: errors are more interesting than successes.

@mmoussallam it's very hard, seems like.
Would you say that difference in amplitude makes a huge difference?
Let's say that the volume of the input stems don't perfectly match the volume of the stems when mixed down.
Will this significantly affect the training results?


Add admin permission const

Closes #1739
This PR simply adds a single const value to the permission const values so that the list is comprehensive for use in downstream APIs.

@svanharmelen  - Very simply PR here, ready for your review when you have some time :)


[SPARK-12220][Core]Make Utils.fetchFile support files that contain special characters

This PR encodes and decodes the file name to fix the issue.

CC @vanzin

Test build #47373 has started for PR 10208 at commit 56a35a3.

LGTM pending tests.

Test build #47373 has finished for PR 10208 at commit 56a35a3.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/47373/
Test FAILed.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/47435/
Test FAILed.

retest this please

Test build #47437 has started for PR 10208 at commit 2c31643.

retest this please

Test build #47529 has started for PR 10208 at commit 2c31643.

Test build #47529 has finished for PR 10208 at commit 2c31643.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/47529/
Test PASSed.

Merged build finished. Test PASSed.

@srowen further comments?

This feels hacky to be partly encoding URIs with ad-hoc methods. I understand the problem but this seems to be making the project code more complex. The methods seems like overkill since you're just calling a single (tested) JDK method. shrug

@srowen Just found org.apache.commons.httpclient.util.URIUtil has already supported URI decode/encode features and updated my PR with it.

LGTM

yeah if it doesn't mean adding a dependency on HttpClient into core -- it may happen to come in transitively already

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/47664/
Test FAILed.

Merged build finished. Test FAILed.

retest this please

Test build #47675 has started for PR 10208 at commit 8734464.

Test build #47675 has finished for PR 10208 at commit 8734464.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/47675/
Test FAILed.

retest this please

Test build #47683 has started for PR 10208 at commit 8734464.

Test build #47683 has finished for PR 10208 at commit 8734464.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/47683/
Test PASSed.

Merged build finished. Test PASSed.

Test build #47767 has started for PR 10208 at commit 28fa737.

Test build #47767 has finished for PR 10208 at commit 28fa737.

This patch fails PySpark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/47767/
Test FAILed.

retest this please

Test build #47786 has started for PR 10208 at commit 28fa737.

Test build #47786 has finished for PR 10208 at commit 28fa737.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/47786/
Test PASSed.

The problem is, nothing else in Spark uses HttpClient. I don't think it's worth it just for this, especially since there's essentially a one-liner using JDK methods. I agree that, if we could reuse a significant set of methods from HttpClient and retire some Spark code, that'd make it worth it. That's a bit of a separate issue. Still there, I know HttpClient versions can be a bit of a problem since lots of things depend on various versions of 3.x and 4.x, and it's easy to hit version compatibility problems.

I suppose the decision is what we want to maintain more: our own encode/decode logic, or potential dependency conflicts. If we test the encode/decode logic well then we probably don't need to maintain it much, but at the same time it's good to use a trusted library in case there's something we missed. Though I agree the dependency thing could be more difficult to maintain. I'm OK one way or the other, so we can just do it ourselves as @srowen prefers.

Okey. I just removed my last 2 commits.

retest this please

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/47846/
Test FAILed.

Test build #47847 has started for PR 10208 at commit 2c31643.

Test build #47847 has finished for PR 10208 at commit 2c31643.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/47847/
Test PASSed.

Merged build finished. Test PASSed.

@srowen do the latest changes LGTY?

OK. I think this pretty fine.

Great. Merging to master and 1.6


Improving the documentation

Hi Robin, I'm currently working on rewriting a lot of the current documentation for better readability.
I found an inconsistency while rewriting the documentation of the renumber method from nfa.md.  It says, "The new states will
be named as q0, q1, q2, and so on."
But this is what I get with the following code:
from automathon import NFA

q = {'state1', 'state2', 'state3', 'state4'}
sigma = {'0', '1'}
delta = {
    'state1' : {
            '0' : {'state1'},
            '1' : {'state1', 'state2'}
            },
    'state2' : {
            '0' : {'state3'},
            '' : {'state3'}
            },
    'state3' : {
            '1' : {'state4'},
            },
    'state4' : {
            '0' : {'state4'},
            '1' : {'state4'},
            },
}
initial_state = 'state1'
f = {'state4'}

automaton = NFA(q, sigma, delta, initial_state, f)

print(automaton.q) # {'state2', 'state3', 'state1', 'state4'}

automaton.renumber()

print(automaton.q) # {'0', '2', '3', '1'}

It's renaming them to numbers and not putting a 'q' as a prefix. Is this intended and the documentation is incorrect? Or is this a bug?

Hey @Buitragox thank you for your contribution! That's an error, isn't intended to work like that. I think that should be interesting to add an optional argument like prefix = "q" to allow the user to use a custom prefix.
class NFA:
    ...
    def renumber(self, states_prefix = "q") -> None:
    ...

If you want, you can open a PR with this refactor :)

If you want, you can open a PR with this refactor :)

Sure, I'll be working on it.


[Enhancement] In Welcome Tour ->once the tour is completed there should be close icon to close the pop up.

Description
[What happened ] In Welcome tour feature->once the tour is completed there should be close icon to close the pop up. currently we can only go to home or got to next mission which is making difficult to see what is the data displayed in the built table
Steps to reproduce the behaviour:
1.In the application page
2.click on Welcome tour
3.Click on Lets go Button
4.Click on Start Building button
5.Clik on do it for me button continuously
6.Validate the Functionality
expected result:
In Welcome tour feature->once the tour is completed there should be close icon to close the pop up.
Actual Result:
In Welcome tour feature->once the tour is completed there should be close icon to close the pop up. currently we can only go to home or got to next mission which is making difficult to see what is the data displayed in the built table

Important Details
Version: Cloud
OS: Windows
Browser Chrome
Environment Production

@Nikhil-Nandagopal is this even possible or intended?

@somangshu it wasn't but we can pick this up as an enhancement


Implement GraphQL Collector

Description
The graphQL collector serves as a way to configure the collection of new metrics available through graphQL. The collector will act as a replacement for the Python implementations of arpState and deviceState collectors. The following is the graph collector configuration used to replace deviceState.
[[inputs.t128_graphql]]
  collector_name = "device-state"
  base_url = "http://localhost:31517/api/v1/graphql/"
  entry_point = "allRouters[name:${ROUTER}]/nodes/nodes[name:${NODE}]/nodes/deviceInterfaces/nodes"

  [inputs.t128_graphql.extract_fields]
    enabled = "enabled"

  [inputs.t128_graphql.extract_tags]
    name = "name"
    admin-status = "state/adminStatus"
    operational-status = "state/operationalStatus"
    provisional-status = "state/provisionalStatus"
    redundancy-status = "state/redundancyStatus"
    mac-address = "state/macAddress"

Testing
Unit tests
Through 128T-monitoring-agent
[centos@t193-dut2 ~]$ systemctl status 128T-telegraf@t128_device_state -l
...
Feb 22 19:00:05 t193-dut2.openstacklocal telegraf[30765]: device-state,admin-status=ADMIN_UP,host=t193-dut2.openstacklocal,mac-address=22:f4:9e:12:06:c6,name=gre-0,node=combo-east,operational-status=OPER_UP,provisional-status=PROV_UP,redundancy-status=NON_REDUNDANT,router=ComboEast enabled=true<PHONE_NUMBER>000000000

Note
There are so many commits because I created the feature branch off of 1.16
The relevant commits start on 2/4/2021 with commit 7713fb3

Hey guys (@salegria8 and @agrawalkaushik), this isn't right. I'm not sure what happened, but there are suddenly >100 commits in this PR. I'm guessing somehow a 1.16 branch got merged into a 1.17 branch. It will need to be reverted and done again.

Hey guys (@salegria8 and @agrawalkaushik), this isn't right. I'm not sure what happened, but there are suddenly >100 commits in this PR. I'm guessing somehow a 1.16 branch got merged into a 1.17 branch. It will need to be reverted and done again.
The correct approach is to cherry-pick relevant commits, not to merge the older branches into the newer ones. Each branch is managed separately - a different approach from what we generally use in our repos.

That was my mistake on first creating the feature branch off of 1.16. My approach was to merge 1.17 into the feature branch (and correct some merge conflicts/issues). I'll have to go back and fix it


CLID-174: Use io.MultiWriter for the logger - logs to both stdout and…

… working-dir/logs
Description
This enables oc-mirror to send logs both to the console output and to a file  working-dir/logs/oc-mirror.log.
Please note that the logs folder is cleared at each start of oc-mirror, so the file will contain the logs from a single execution (no append).
Fixes # CLID-174
Type of change
Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

How Has This Been Tested?
Run a mirror to disk and check the working-dir/logs/oc-mirror.log file.
Expected Outcome
oc-mirror.log file contains logs

/lgtm


Fuzzy Intellisense only uses last typed character and is too loose

VSCode Version: 1.4.0-insider (4d0b2f5f15bf7011d3a99888763a7b46a5953d95)
OS Version: OS X 10.11.5

Steps to Reproduce:

Start typing anything that will prompt Intellisense in C#
See that only the single last character entered is highlighted and used for filtering

To demonstrate, here is a gif of how it works in VSCode 1.3.1:

Note that all characters are highlighted and used for filtering
Here is a gif of latest insider build:

See that only the last char is highlighted and used for filtering.

Can no longer reproduce in latest version (f4780e67933164a2289b86f2c279aaa05fda672f). Closing.


Examples fail on macOS 10.13.6 on MacBook Pro (17-inch, Early 2011)

Neat project! I just tried taking things for a spin, but it's failed:
$ RUST_BACKTRACE=full cargo run --package progress_bar
    Finished dev [unoptimized + debuginfo] target(s) in 0.22s
     Running `target/debug/progress_bar`
thread 'main' panicked at 'called `Option::unwrap()` on a `None` value', src/libcore/option.rs:378:21
stack backtrace:
   0:        0x104ecd735 - backtrace::backtrace::libunwind::trace::hb16ec6045891ce5a
                               at /Users/runner/.cargo/registry/src/github.com-1ecc6299db9ec823/backtrace-0.3.40/src/backtrace/libunwind.rs:88
   1:        0x104ecd735 - backtrace::backtrace::trace_unsynchronized::hcacbd0efdffd74c6
                               at /Users/runner/.cargo/registry/src/github.com-1ecc6299db9ec823/backtrace-0.3.40/src/backtrace/mod.rs:66
   2:        0x104ecd735 - std::sys_common::backtrace::_print_fmt::h39e22de9d6757d12
                               at src/libstd/sys_common/backtrace.rs:77
   3:        0x104ecd735 - <std::sys_common::backtrace::_print::DisplayBacktrace as core::fmt::Display>::fmt::h415ddd0ba88caaaf
                               at src/libstd/sys_common/backtrace.rs:61
   4:        0x104eebf20 - core::fmt::write::h3335552e2df81c1d
                               at src/libcore/fmt/mod.rs:1028
   5:        0x104ecbb4b - std::io::Write::write_fmt::he6837371b9a45188
                               at src/libstd/io/mod.rs:1412
   6:        0x104ecf4c3 - std::sys_common::backtrace::_print::h89459d14ba97f5fa
                               at src/libstd/sys_common/backtrace.rs:65
   7:        0x104ecf4c3 - std::sys_common::backtrace::print::ha4c6688e811b8829
                               at src/libstd/sys_common/backtrace.rs:50
   8:        0x104ecf4c3 - std::panicking::default_hook::{{closure}}::h708e66cfeb0483ba
                               at src/libstd/panicking.rs:188
   9:        0x104ecf1ca - std::panicking::default_hook::h39ea8ddf674c04ec
                               at src/libstd/panicking.rs:205
  10:        0x104ecfc0b - std::panicking::rust_panic_with_hook::h9db77b22c2255a16
                               at src/libstd/panicking.rs:464
  11:        0x104ecf769 - std::panicking::continue_panic_fmt::h2dfa3a5b90265361
                               at src/libstd/panicking.rs:373
  12:        0x104ecf669 - rust_begin_unwind
                               at src/libstd/panicking.rs:302
  13:        0x104ee811c - core::panicking::panic_fmt::hec1ee47b7e17dca5
                               at src/libcore/panicking.rs:139
  14:        0x104ee8074 - core::panicking::panic::h30fe7b508c26b15d
                               at src/libcore/panicking.rs:70
  15:        0x1047dc1e0 - core::option::Option<T>::unwrap::hbec2fdf7224360a8
                               at /rustc/73528e339aae0f17a15ffa49a8ac608f50c6cf14/src/libcore/macros.rs:41
  16:        0x10492a144 - wgpu_request_adapter
                               at /Users/me/.cargo/registry/src/github.com-1ecc6299db9ec823/wgpu-native-0.4.3/src/instance.rs:474
  17:        0x1046b563d - wgpu::Adapter::request::ha66b32bd73380b41
                               at /Users/me/.cargo/registry/src/github.com-1ecc6299db9ec823/wgpu-0.4.0/src/lib.rs:545
  18:        0x1045f5910 - iced_wgpu::renderer::Renderer::new::h0682673c8b9bd9dc
                               at wgpu/src/renderer.rs:57
  19:        0x1045f73f4 - <iced_wgpu::renderer::Renderer as iced_native::window::renderer::Renderer>::new::h83bcc0cb7e69d4e0
                               at wgpu/src/renderer.rs:463
  20:        0x1044cd175 - iced_winit::application::Application::run::h9acff3abb7370115
                               at /Users/me/Documents/Code/rust/other/iced/winit/src/application.rs:169
  21:        0x1044a570f - iced::application::Application::run::h5d35e322149e3428
                               at /Users/me/Documents/Code/rust/other/iced/src/application.rs:177
  22:        0x1044a58c0 - iced::sandbox::Sandbox::run::h86da6c61095980ec
                               at /Users/me/Documents/Code/rust/other/iced/src/sandbox.rs:128
  23:        0x1044cddaa - progress_bar::main::hb68c8566db5e82d4
                               at examples/progress_bar/src/main.rs:4
  24:        0x1044a8672 - std::rt::lang_start::{{closure}}::h7a47d33c58d14eee
                               at /rustc/73528e339aae0f17a15ffa49a8ac608f50c6cf14/src/libstd/rt.rs:61
  25:        0x104ecf5e8 - std::rt::lang_start_internal::{{closure}}::hccd7db6d8a0ebab5
                               at src/libstd/rt.rs:48
  26:        0x104ecf5e8 - std::panicking::try::do_call::hd5a3af8d00c06681
                               at src/libstd/panicking.rs:287
  27:        0x104ed1bdf - __rust_maybe_catch_panic
                               at src/libpanic_unwind/lib.rs:78
  28:        0x104ed005e - std::panicking::try::h7a0bd4c078131d2f
                               at src/libstd/panicking.rs:265
  29:        0x104ed005e - std::panic::catch_unwind::h75c3fbe62776ab10
                               at src/libstd/panic.rs:396
  30:        0x104ed005e - std::rt::lang_start_internal::haa52aabac43378ff
                               at src/libstd/rt.rs:47
  31:        0x1044a8652 - std::rt::lang_start::h20470961c581b479
                               at /rustc/73528e339aae0f17a15ffa49a8ac608f50c6cf14/src/libstd/rt.rs:61
  32:        0x1044ce072 - progress_bar::Message::SliderChanged::hefc33626c8183d38

I can try on macOS 10.14 if you need output from a Metal target as well.

$ git log
commit 4e9e051caaf76e2c76aaa79c2463409a8280265f (grafted, HEAD -> master, origin/master, origin/HEAD)
Author: Héctor Ramón Jiménez<EMAIL_ADDRESS>Date:   Fri Feb 7 20:45:09 2020 +0100

    Fix crates.io link in `README`

Related to #48.
On macOS, you will need a Metal-capable graphics processor to run the examples for the time being.

Yup! Seems to work fine on the other Mac. Considering Apple's dropped support for OpenGL, I think it's best to focus on making sure Metal targets work as good as they can instead of supporting my ancient machine.

I have observed the same issue on Ubuntu 18.04 with integrated Intel CPU chipset

So it seems to work if I install OpenGL & Vulkan
sudo apt install libglu1-mesa-dev freeglut3-dev mesa-common-dev libvulkan1 mesa-vulkan-drivers vulkan-utils

Please mention that these system dependencies are needed in the installation guide


When I fail to log in or keep spinning in circles, I will exit the webpage through the full screen gesture, and I will start to log out of the login exception such as sign_in_canceled，com.google.android.gms.common.api.ApiException: 12501: how can i to handle the  PlatformException error

Steps to Reproduce

Execute flutter run on the code sample
...
...

Expected results:
Actual results:

Code sample

Logs

I use google_sign_in: ^6.0.2 in flutter application , When I fail to log in or keep spinning in circles, I will exit the webpage through the full screen gesture, and I will start to log out of the login exception
1、 Android paltform
2、fail to log in or keep spinning in circles
3、I will exit the webpage through the full screen gesture ，throw com.google.android.gms.common.api.ApiException: 12501
paltformException,how can i handle it

Closing as duplicate of https://github.com/flutter/flutter/issues/85785


fix: ACNA-2959, ACNA-2966, ACNA-2784 - creating a standalone app, and running aio app dev, results in an exception. add unit tests

fixes #22
fixes #27
added complete coverage with unit tests

How Has This Been Tested?

in progress

Types of changes

[X] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[X] I have signed the Adobe Open Source CLA.
[ ] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[X] I have read the CONTRIBUTING document.
[x] I have added tests to cover my changes.
[x] All new and existing tests passed.

due to the changes for e2e, the unit tests have to be fixed.