Conversion to Linalg on Tensors seems (very) incomplete

Following a discussion 10 days ago, I learned that ConvertHLOToLinalgOnBuffersPass is to be deprecated and replaced with lowering HLO to linalg-on-tensors. I have also learned that this new lowering code has already been upstreamed to the MHLO repository.
I have therefore tried to use the last version of the MHLO transformations, available as tf-opt --hlo-legalize-to-linalg (after pulling the most recent version of TF, which includes MHLO).
On my RESNET50 example, the pass cannot transform two fundamental operations:

mhlo.convolution, if there is padding
mhlo.constant, if the constant is not a scalar

I have simplified the input to the following 3 functions:
  func @test_conv(%750: tensor<1x7x7x512xf32>,%247:tensor<3x3x512x512xf32>) -> (tensor<1x5x5x512xf32>) {
    %751 = "tf.Conv2D"(%750, %247) {
	     padding = "VALID",
	     strides = [1, 1, 1, 1]
	     } : (tensor<1x7x7x512xf32>, tensor<3x3x512x512xf32>) -> tensor<1x5x5x512xf32>
    return %751: tensor<1x5x5x512xf32>
  }

  func @test_conv_pad(%750: tensor<1x7x7x512xf32>,%247:tensor<3x3x512x512xf32>) -> (tensor<1x7x7x512xf32>) {
    %751 = "tf.Conv2D"(%750, %247) {
             dilations = [1, 1, 1, 1],
	     padding = "SAME",
	     strides = [1, 1, 1, 1]
	     } : (tensor<1x7x7x512xf32>, tensor<3x3x512x512xf32>) -> tensor<1x7x7x512xf32>
    return %751: tensor<1x7x7x512xf32>
  }

  func @test_const() -> (tensor<f32>,tensor<2xf32>,tensor<3x3x512x512xf32>) {
    %30 = "tf.Const"() {value = dense<1.0> : tensor<f32>} : () -> tensor<f32>
    %31 = "tf.Const"() {value = dense<[1.0,2.0]> : tensor<2xf32>} : () -> tensor<2xf32>
    %247 = "tf.Const"() {value = dense<1.0> : tensor<3x3x512x512xf32>} : () -> tensor<3x3x512x512xf32>
    return %30,%31,%247: tensor<f32>,tensor<2xf32>,tensor<3x3x512x512xf32>
  }

The compilation command is:
tf-opt     --tf-to-hlo-pipeline     --mhlo-test-unfuse-batch-norm     --hlo-legalize-to-linalg conv.mlir
Note in the output that the first convolution, without padding, is correctly translated, whereas the second is left untranslated at MHLO level. Maybe there is another lowering option allowing the conversion in this case?
For constants (in the last function) it's even worse - this limitation did not previously exist in the IREE pipeline, it was introduced now. In my example, only the first mhlo.constant is correctly translated into a standard constant. The other two remain at mhlo.constant level.
I'm on TF commit ac5f2a1f0db1ba1e585559ad4e593fdb3e73713a (I don't know how this is mirrored on the MHLO standalone repo, but a priori it's mirrored).
ADDENDUM: while digging deeper, I found the solution to the first issue, but this one remains inside IREE: it's the option -iree-flow-extract-pad-from-conv. I guess this one should be moved to MHLO, too, and included in the pipeline, because it completes the pass. The mhlo constant translation issue, on the other hand, I don't yet understand.

Convolution with padding attributes makes Linalg transforms harder, so we extract it to be another operation in IREE. Many transforms in Linalg do not work with operations that has padding attribute.
The HLOToHLOPreprocessing pass is used to make MHLO ops being IREE-friendly. There are other operations that we want to tweak a bit before jumping into IREE pipeline. If you are relying on them, you're going to want to move these patterns/passes upstream. You can upstream some of them to MHLO repo, like mhlo::PopulateUnfuseBatchNormPatterns, mhlo::PopulateComplexLoweringPatterns, and mhlo::PopulateGatherToTorchIndexSelectPatterns, etc. And integrate them in your project.
I think different projects has different ways to handle constants. In IREE, we inline splat constants and small constants to dispatch regions. Large constants will be flow.variables or something at flow level. (flow is a dialect defined by IREE). There is a pattern in iree-codegen-hlo-to-linalg-on-tensors that lowers all kinds of mhlo.constants to std.constants, but I did not upstream it to MHLO repo yet. The logic of the pattern in MHLO only handle scalar cases, but maybe it is okay to upstream it.
https://github.com/google/iree/blob/96e9c4946399f2a0df6794252c77506e9ac1c9a5/iree/compiler/Conversion/HLOToLinalg/HLOToLinalgOnTensors.cpp#L231-L239

FYI, you can run resnet model with IREE. We have a test file with fake weight: https://github.com/google/iree/blob/main/iree/test/e2e/models/resnet_fake_weights.mlir
And there are some integration tests for ResNet50 in integrations/tensorflow/e2e/keras/applications/
It looks like there is no action item on IREE side, so I'm going to close the issue.


Update asyncactioncompletedhandler.md

IAsyncAction.Completed takes an IAsyncAction but the param name is asyncInfo

@asklar : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@jwmsft will changing the signature in the xml comment automatically fix the type of the parameter and the link?

mmm the metadata says iasyncaction, but the cppwinrt projection says iasyncinfo... let me follow up with cppwinrt first before we merge this
CC @kennykerr

@asklar Any updates on this? Happy to move the conversation to email if you'd prefer - hickeys a microsoft

the type in the doc is correct, and the parameter name matches what's in the metadata, but the name in the metadata is wrong :)
I think it would be good to rename the parameter to asyncAction

@asklar, sorry I missed your question previously. The syntax that you updated in this PR is injected for the convenience of the author, but is not used in the published doc. What's published in the syntax block is generated entirely from the metadata and there's no way to manually update it.


Update Jetty to address CVE

Dropwizard 2.0.20 uses a Jetty version (9.4.37.v20210219) that has a CVE (https://nvd.nist.gov/vuln/detail/CVE-2021-28165) reported against it. A Jetty version with the corresponding fixes is already in 2.0.21; could you please let me know if it would be possible to release that version with the update? It appears that the milestone is complete.
Thanks!

Refs https://github.com/dropwizard/dropwizard/pull/3821


KB should be kB

See https://en.wikipedia.org/wiki/Kilobyte, its a little on the fence as KB is commonly used, officially it should be kB to be SI
refs #63

It actually seems like KB is correct since 10^3 == 1000 ==  kB whereas 2^10 == 1024 == KB.
Feel free to open if you think otherwise :+1:


adding dacy to danlp

I have added the DaCy model, including checks and performance on the test set of DaNE. I have restrained from editing the code in such a way that it would break compatibility, however as this model requires Spacy v.3.
if you want to provide a direct download link via. DaNLP the model can be downloaded here (this is not a permanent link) or from the github:
https://github.com/KennethEnevoldsen/DaCy

I have added a "(✅)" to the column on whether it will be on DaNLP. That is naturally assuming you want to host it. If that is not something you want, we can naturally change it, and then I will figure out a way to make a permanent download link from our end.
best

Hi Kenneth,
we won't upgrade the package yet with spaCy >v3 (but we should do it in the future so let's keep the integration of your models for future improvement).
In accordance with this, I propose for now to remove

the modifications made under the danlp folder and in the requirements
the test script

It seems that the benchmark scripts are not compatible with the new version of spaCy.
There are several problems :

tokens_from_list is deprecated, instead you should do (in order to evaluate on the DDT tokenization)
from spacy.tokens import Doc doc = Doc(nlp.vocab, words=["Hej", "!"])
the path to the model is not correct, what about using your dacy package? such as
import dacy nlp = dacy.load(model_name)
parser = nlp would not work because nlp cannot be applied to a Doc, instead use first
transformer = nlp.get_pipe('transformer') parser = nlp.get_pipe('parser')
so that you can apply both on a Doc:
doc = transformer(doc)  doc = parser(doc)
tok.pos_ should be replaced with tok.tag_

I also propose to add model_name as an argument of the dacy benchmark functions so that you can call it on each model in the main function. But for now, I would keep these calls as comments in the main functions as it requires an upgrade of spaCy and would not be compatible with the other functions.
Once the benchmark scripts work, please update the score with what you obtain by running them.

Thanks, Ophelia,
I will take a look at this once a window of time opens up. The performance scores however should remain unchanged unless the default split is not constant. Will naturally change them if they are not the same, but that would mean a difference in DaNLP and SpaCy measures of performance. Which I would be surprised to see.

Thanks for the correction, Ophelia. I have updated it accordingly.
The performance changes are primarily because the 'correct' tokenization is given to DaCy, which results in a better performance overall. However, this is probably slightly misleading as tokenization is naturally not given to the model in any real scenario.

Thanks for the correction, Ophelia. I have updated it accordingly.
The performance changes are primarily because the 'correct' tokenization is given to DaCy, which results in a better performance overall. However, this is probably slightly misleading as tokenization is naturally not given to the model in any real scenario.

Thanks for integrating the changes. It looks really good.
For comparison between different systems, it is quite standard to apply it on gold tokenization in order to have scores that are actually comparable, i.e. systems are compared on the same bases. I agree that the scores do not represent performance in a "real scenario" but this way we compare the performance of the systems for one specific task only, independently from previous steps.
One last question. I do not seem to be able to download the small model. Is it actually available or am I missing something?

I agree with the use of the gold standard tokenization. Simply wanted to state it so that the cause for the change was apparent.
It should be available on the following link:
https://sciencedata.dk//shared/d845d4fef9ea165ee7bd6dd954b95de2?download
(taken directly from spacy).
Are you using the latest version from Github? If not I would love to see the error message - then I will look into the issue.

After downloading (using nlp = dacy.load("da_dacy_small_tft-0.0.0")), the model is called "da_dacy_-l-ctra_small_tft-0.0.0" instead of "da_dacy_small_tft-0.0.0" in my cache dir.
If I change the name for the last one it works. However the scores do not correspond to what you reported for the NER model: I get LOC/79.23 ORG/61.82 PER/88.52 while you have LOC/83.09 ORG/67.35 PER/89.62.

Ahh, I see. I have fixed the naming issue. I also see I added the DaCy small to the NER. This wasn't my intention I have removed it.
I haven't tested the performance of the small DaCy model using the gold tokens. I initially planned to add it but choose to remove it as it compares unfavorably without a runtime efficiency. Do feel free to add it though. There is also a good chance I will update the model in the future. So as it seemed less permanent I would not bother adding it. (for this reason, I also just added versions numbers)
The performance metrics from DaCy itself reflect the performance metrics reported by SpaCy (which does not use the golden standard tokens).
https://github.com/KennethEnevoldsen/DaCy/tree/main/DaCy_training/metrics
(I have also added a note on this in DaCy)
(the numbers reported here for the small model is not correct. They are neither match the DaCy performance metrics nor the DaNLP. It is likely an error left there from some copy-paste action as the LOC matches the DaCy medium)

Ok, good.
So yes it makes sense to keep only the medium and large scores for now.


Missing lambda spans when called from distributed map in step functions

Hi,
I'm struggling with the problem of missing spans in DataDog when calling a lambda function from a step function where distributed maps are in use. Considering the AWS developer guide there is an information that Step Functions doesn't support X-Ray tracing for the child workflow executions started by a Distributed Map state.
I am still able to re-enable X-Ray tracing by creating a new segment inside the function, however such traces are not pulled by the DD - X-Ray integration. Moreover the child spans created with the dd-trace tracer are not visible anymore.
Only spans created by the extension layer are still visible in DD: one or two depending on the cold start.
With the manual lambda invocation the spans created and all associated X-Ray traces are visible id DD.
I wonder if there is any alternative solution that:

Make the traces created by the new X-Ray segment visible to DD.
will allow you to create new dd-trace spans and associate them with a given lambda call by SF

current environment details:

GO 1.22
Datadog-Extension:51 - (I will bump it soon and then confirm the issue)
enabled active X-Ray tracing
enabled DataDog - X-Ray integration,
DD_MERGE_XRAY_TRACES set to true

I will be grateful for the community's support on this topic,
Adam.

Hi Adam,
Unforuntately, Datadog also can't trace across a distributed map state. The distributed map state doesn't pass enough context to the lambda function to be able to reconstruct a trace ID. Distributed map states also result in, theoretically, very wide traces, which presents a problem for both X-Ray and our APM system. Both of these are problems we are working to solve, but I suspect it won't be quick.
If you send an email to<EMAIL_ADDRESS>you can ask them to add you to the feature request for span linking across distributed map states.
Sorry and all the best!
-Chris

Thanks for the quick response.
I fully accept the argument related to the properties of distributed maps.
However do you see any way to configure the X-Ray integration to be able to pull the manually created (besides the active tracing) segments, being aware that they may be not correlated with traces created by the Datadog extension or spans created within the step function?
I'm wondering if the lambda traces might be completely independent from step function trace, like for the manual function invocation. In my case this will be even better than nothing.
Best regards,
Adam

Hey @agocs,
What do you think about above solution proposed by Adam in a case of distributed maps?

@astuyve @agocs Would anyone be able to support here?

Hi @adatob , do you mean something like this?

It seems like it should just work. You could use our X-Ray integration or instrument the Lambda functions using datadog instrumentation, whatever you want.

Hey @nine5two7 is there any update on above?

still WIP

Hey @nine5two7 @joeyzhao2018 - I would like to ask you, is there any progress on that topic as that limits our monitoring by a lot due to fact that we are using Distributed maps at scale.

Hi @xrn, I'm actively working on merging parent execution and child executions of a distributed map into one trace. Clarifying it here because I realize that this issue also talks about merging X-Ray spans. And please feel free to comment on how you use distributed maps if you have more complicated setups such as nested maps. Thanks.


feat(json-tags): Add case style config option

This PR allows users to choose which case style will be used to generate JSON tags.
The style can be selected by adding the json_tags_case_style setting key.

camelCase - "camel"
PascalCase - "pascal"
snake_case - "snake" (default)

Changes

Add JSONTagsCaseStyle field to package settings and set its default value to snake.

config/config.go
config/v_one.go

Implement SetCaseStyle function which converts the tag name to the specified case style.

codegen/golang/field.go

Wrap JSON tags name with the SetCaseStyle function.

Add test for each case style.

endtoend/testdata/camel_case/...
endtoend/testdata/pascal_case/...
endtoend/testdata/snake_case/...

Add json_tags_case_style key to the documentation.

Resolve #878

The default is to just use the name of the column in the database. This behavior needs to stay the default.

I removed the renames, a sure thing, I totally agree.

renames do not currently apply to JSON tags. I don't think we should start doing that now.

I added a wrapper which applies the case style formatter only if the json_tags_case_style is set. If its value is none or has no value (the key is omitted) the name of the column in the database is used (the default).
Changes:

Removed the renames
Added JSONTagName which decides if SetCaseStyle is applied:

func JSONTagName(name string, settings config.CombinedSettings) string {
	style := settings.Go.JSONTagsCaseStyle
	if style == "" || style == "none" {
		return name
	} else {
		return SetCaseStyle(name, style)
	}
}

Changed the function pattern of the SetCaseStyle:

- func SetCaseStyle(name string, settings config.CombinedSettings) string {
+ func SetCaseStyle(name string, style string) string {

Updated the documentation


how to show local timestamp in angular-cli compile output?

when ng serve and file changed, angular-cli will automatically compile and output to console.
Like this,

but the date is UTC+0.
How to show local timestamp in angular-cli compile output?

Duplicate of https://github.com/angular/angular-cli/issues/12562


Label commenting bot

Is your feature request related to a problem? Please describe.
I would like it to generate different messages for following labels:-
lgmsoc21
level0
level1
level2
level3
under review
changes requested
screenshots

@QAZIMAAZARSHAD Just I want to clear that I'll be inactive on github for a week(sem exams). I want to tell that if it's ok then will complete this after a week.

fine

@srisatya1197 any updates?


#55 Add Shadow function

Overview
Added the ability to receive shadows to StandardShader.
The Buildin pipeline could not find any other way to receive shadows other than to add a Pass, and for these reasons we have made it URP-only once.
Also, unlike the method described in #55, I did not use a RendererFeature, but instead completed it in the Shader.
　I am still learning, so there may be places where I am forcing things. If you have any suggestions for improvement, let me know!
Changes
#55
The changes are in the following file.
com.microsoft.mrtk.graphicstools.unity/Editor/ShaderGUIs/StandardShaderGUI.cs
Allows display of _RECEIVESHADOW parameters.
com.microsoft.mrtk.graphicstools.unity/Runtime/Shaders/GraphicsToolsLighting.hlsl
What I have done is to allow shadowCoord to be passed as an argument to GTGetMainLight in order to use the shadowCoord provided in URP's RealtimeLighting.hlsl.
com.microsoft.mrtk.graphicstools.unity/Runtime/Shaders/GraphicsToolsStandard.shader
Add new parameter [Toggle(_RECEIVESHADOW)] _ReceiveShadow("ReceiveShadow",Float) =0.0
com.microsoft.mrtk.graphicstools.unity/Runtime/Shaders/GraphicsToolsStandardCanvas.shader
Parameters have been added to the StandardShaderGUI.cs with the changes.
com.microsoft.mrtk.graphicstools.unity/Runtime/Shaders/GraphicsToolsStandardInput.hlsl
add  half4 shadowCoord : TEXCOORD4;
com.microsoft.mrtk.graphicstools.unity/Runtime/Shaders/GraphicsToolsStandardProgram.hlsl

This is much needed, thanks. I tried to test this by using "Window / Graphics Tools / Show samples", then I opened up "Packages/com.microsoft.mrtk.graphicstools.unity/Samples/MaterialGallery/MaterialGallery.unity". I wasn't able to see the shadows. Maybe I'm missing some configuration?

@HoloMoto & @pinkwerks, just a FYI, I merged the shadow casting PR #146 into main.

@Cameron-Micka  @pinkwerks
Sorry I haven't been able to work on it at all.
I have some conflicts with #146 here, so I would like to import the main branch into the main branch and work on it.
I checked the fb you gave me just the day before yesterday.
　I'll rename it and make some adjustments!

Closing this for now - we can revisit this when time allows!


[JBEAP-12826, WFCORE-3203] WildFlyTestRunner throws NullPointerExcept…

…ion during stop intermittently
JBEAP: https://issues.jboss.org/browse/JBEAP-12826
WFCORE: https://issues.jboss.org/browse/WFCORE-3203

My previous comment / your response is hidden a bit now, so I'll reply here.
@xstefank The current code in master, L227 the thread that invoked stop() will not proceed until process.waitFor() returns. It doesn't care whether destroy() was called or not -- it waits until process.waitFor() returns.
The new code assumes that a call to process.destroy() means the process is gone when that call returns. But that in my experience that is not a correct assumption -- a call to destroy() does not mean the process is gone when that call returns. The destroyForcibly() method has explicit javadoc saying that's not the case and I'm pretty sure it was never the case with plain old destroy() either.

@bstansberry Thank you for the explanation! I really appreciate that I learned something new :) hope that now it is alright


Status is not showing in Original Theme

Status is not showing in Original Theme

Update: Thank you for reporting the error.
The issue has been fixed in the new release v0.3.2, which you can find here and https://github.com/medeirosinacio/jira-backlog-issue-status-extension/compare/v0.3.1...v0.3.2.


docs: Needed Conceptual Overview and Examples of Common Configurations

Documentation Is:

[x] Missing
[x] Needed
[ ] Confusing
[ ] Not Sure?

Please Explain in Detail...
Heyo :wave: It's been a while since I have setup a webpack development server / hot reloading. Jumping back in wasn't super straightforward, though I did end up getting it mostly figured out. I wanted to open an issue to address what could have helped me (and maybe even contribute to some of that change).
That said... I got the beta/v2 up and running today without too much hassle -- y'all are doing a great job with this tool so far :+1: Thanks for all your hard work.
Your Proposal for Changes

Added conceptual overview

Think: "How does webpack-serve fit into the system?" or "What roles does webpack-serve fill?". It's nice to be reminded, and see it concisely described.
I know this one seems a little weird, but I think it'd be really helpful even if it doesn't strictly cover only webpack-serve.
I took a stab at this sorta thing when I added webpack-serve and hot reloading to this little test repo if you want an example of what I mean.

Examples of common configurations

I think it'd be awesome to see some variations of:

webpack-serve + react-hot-loader + express
webpack-serve + react-hot-loader + fastify

Lemme know if I can clarify anything described or suggested here.

Maybe add an examples folder the way the Testem repo does it?
see: https://github.com/testem/testem/tree/master/examples

DEPRECATED. Please use webpack-dev-server (he is in support and update mode again). Feel free to create a issue if some features are not implemented in webpack-dev-server.
Why deprecated webpack-serve ?

The author stopped developing the package.
Two development servers are misleading for developers.
Hard to maintain two packages with same purpose.
Some dependencies are not available to fixes/implement new features/etc (https://www.npmjs.com/package/webpack-hot-client and https://github.com/shellscape/koa-static) and there's nothing we can do here.
webpack-dev-server is stable.

Thanks for using webpack! We apologize for the inconvenience. In the future, we will avoid such situations.


Docstrings for Timestamp*Array.

Which issue does this PR close?
Re #302
@alamb thought I would add documentation for the Timestamp*Array types. Starting off with TimestampSecondArray to get some quick feedback. A couple of specific questions for you:

There are no assertions here ... I am only trying to provide some hints on how to set these up. Is this ok?
Curious about how to document things that are currently under the feature flag chrono-tz -- specifically, the ability to specify Australia/Sydney as the timezone. Is this appropriate and if so, shall I just make reference to the flag needing to be enabled?

Thankyou.

Codecov Report

Merging #988 (83abb7f) into master (32d8c0a) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #988      +/-   ##
==========================================
- Coverage   82.31%   82.31%   -0.01%
==========================================
  Files         168      168
  Lines       48715    48763      +48
==========================================
+ Hits        40100    40137      +37
- Misses       8615     8626      +11

Impacted Files
Coverage Δ

arrow/src/datatypes/native.rs
72.91% <0.00%> (-1.56%)
:arrow_down:

arrow/src/datatypes/datatype.rs
65.95% <0.00%> (-0.43%)
:arrow_down:

arrow/src/array/data.rs
79.79% <0.00%> (-0.42%)
:arrow_down:

arrow/src/util/display.rs
20.00% <0.00%> (-0.39%)
:arrow_down:

arrow/src/array/array.rs
85.45% <0.00%> (-0.26%)
:arrow_down:

parquet/src/basic.rs
94.38% <0.00%> (-0.23%)
:arrow_down:

arrow/src/array/equal/mod.rs
93.29% <0.00%> (-0.17%)
:arrow_down:

arrow/src/array/transform/mod.rs
85.10% <0.00%> (-0.10%)
:arrow_down:

arrow/src/alloc/types.rs
0.00% <0.00%> (ø)

parquet/src/file/writer.rs
93.30% <0.00%> (ø)

... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 32d8c0a...83abb7f. Read the comment docs.

@novemberkilo  this PR is still marked as a Draft. Do you think it is ready to merge or are there other things you plan to do?

Ah sorry about that @alamb - now ready for review and merge. Thanks.

Thanks again @novemberkilo


Converts

Hi. So i came up with the variable for fahrenheit and pressed run test to see if I defined it correctly. It then passed as if it was correct. Yay for it being correct cause it stumped me a bit, but I didn't change any of the inputs to give me any of the values it asked for. It was nice to pass it, but I feel like we should have to do all of them to get a green light since those are some of the ones needed checked too. Thank you and hope this helped and wasn't a waist of time. - Eric
Challenge Checkpoint: Convert Celsius to Fahrenheit has an issue.
User Agent is: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_0) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/48.0.2564.22 Safari/537.36.
Please describe how to reproduce this issue, and include links to screenshots if possible.
My code:
function convert(celsius) {
  // Only change code below this line

var fahrenheit = ((celsius * 9) / 5) + 32;

  // Only change code above this line
  if ( typeof fahrenheit !== 'undefined' ) {
  return fahrenheit;
  } else {
    return 'fahrenheit not defined';
  }
}

// Change the inputs below to test your code
convert(30);

I'm not sure I understand what your issue is. Are you saying to think you should have needed to change the following line to the different values used in the test cases to pass?
// Change the inputs below to test your code
convert(30);

That is correct. It asked for multiple different ones, but passes without doing them. Or maybe if it just didn’t have the list of them red x-ed it wouldn’t even be an issue. I understand the formula works for them all just kinda confusing.

On Jan 14, 2016, at 7:46 PM, Logan Tegman<EMAIL_ADDRESS>wrote:
I'm not sure I understand what your issue is. Are you saying to think you should have needed to change the following line to the different values used in the test cases to pass?
// Change the inputs below to test your code
convert(30);
—
Reply to this email directly or view it on GitHub https://github.com/FreeCodeCamp/FreeCodeCamp/issues/6169#issuecomment-171865125.

The tests are there to make sure your solution works consistently for a number of different inputs. Making you change the number to run each of those tests would be tedious and wouldn't teach you about programming. The call inside the editor is just there in case one of the tests wasn't passing like you thought it should and you want to display the output your code is giving to the console. Thanks and happy coding!

Right on, thanks for your time.


Forbids dynamic attributes defined statically on factories

I proposed it in #393.
It complains against nonstatic attributes declared statically without being wrapped in a block.
The idea is to cover cases like:
# bad
kind [:active, :rejected].sample
# good
kind { [:active, :rejected].sample }

# bad
closed_at 1.day.from_now
# good
closed_at { 1.day.from_now }

# good
kind :static

# good
comments_count 0

# good
type User::MAGIC

I logged in buildkite website but I don't have access to the build links. 🤔

@jonatas: You can look at the Travis build (it's the "public" CI). The BK build is something @backus setup for collaborators.

Ok! Thanks, @dgollahon! looking the Travis is enough 👍

I have run on a local project and overall looks good. It does not catch cases where the dynamic call is in a hash/array/other structure though. Also, the list of dynamic methods can be expanded. I think catching all send nodes will do better job, but I'm not sure if this won't lead to some false positives. I'll be happy to test each implementation against my code base to see for such false positives

Since it sounds like @Darhazer approves, could you squash down the commits into one nice passing commit and rebase @jonatas? I'll merge after that

@Darhazer, I'm not sure about how to keep it using a simple send. Got some issues with the implementation because constants are also a send.

Got some issues with the implementation because constants are also a send.

WDYM, exactly? Do you have an example of a case you found problematic? Referencing a const is not the same as a send (unless there's some case I'm not aware of).
$ ruby-parse -e 'closed_at { HISTORICAL_DATE }'

(block
  (send nil :closed_at)
  (args)
  (const nil :HISTORICAL_DATE))

I was tryng a example with Faker:
$ ruby-parse -e 'description FFaker::Lorem.paragraph(10)'                                 17:07:35
(send nil :description
  (send
    (const
      (const nil :FFaker) :Lorem) :paragraph
    (int 10)))

So in that case it is non-static and you would want to flag it. The AST is only showing you that (const (const nil :FFaker)) is the receiver of the send node--the constant lookup itself does not involve a send.
You should be able to capture the children of the factory-related send (in this case, description) and just recurse over its children with another matcher that just looks for any send node.
That's assuming the point is to enforce no non-static, non-block factories (which may or may not fit everyone's use cases).

Thanks, @dgollahon! I implemented your suggestion and now it catches all send 🎉

This is neat! I ended up doing a quick look over the code since it is significant that we are adding a new namespace. Can you add a CHANGELOG entry?

Rebased again @backus! Is there anything else I can do now?

Quick note (I can explain more after work if this isn't clear0 I wrote the badge stuff for rubocop and I'm pretty sure it will only ever sample the last two names in the class definition to build the cop badge (so even if it is RuboCop::Cop::RSpec::FactoryGirl::Thing it will never generate a badge like RSpec/FactoryGirl/Thing. I'm fine with just shipping FactoryGirl/CopName and I think it is also reasonable to have the RSpec/FactoryGirl key under AllCops to help clarify.

@backus I think now it's ready to go. Feel free to merge it 🎉

🎈 nice work!


[Suggestion] 1.1.0 for other versions

Would it be possible to add support for other versions?
(if the server is on, release 1.1.0 support, 1.8, 1.9 1.7, 1.6, 1.5)
The ProtocolSupport, stopped being updated, (in addition to be very buggy, sounds do not work, etc)
The ViaVersion is higher, contains optimizations that the ProtocolSupport doesn't have.
Would it be possible to study this possibility?

Hi,
We'll not officially support older version/backwards compatibility between major versions.
The aim of ViaVersion is to allow a newer client on an older server.
Know that backwards compatibility is way more work. You'd have to handle things that didn't exist in previous minecraft versions.
ProtocolSupport has a devbuild that supports 1.10 IIRC.


Supported handlebars functions.

Today I did try to create a response with a link. The problem is that if I want to create custom text, then handlebars function fails to create a response
{{{link "See more..." http://google.sk}}}

And I get an error In api endpoint
api_1       | Failed to generate valid response for intent faqUpdateHandling

What is the list of supported handlebars functions?
Is there a possibility to create custom link?
FYI: Pasting a pure link works. This is results in very looong texts. This why I want to have custom link.

@Johnz86 where did you see that helper. It's likely just that we don't have it installed as I don't think it' s part of the default handlebars functionality. We can either install it/add it. Or think of some way of exposing the ability to install your own. But that will take more thought as it's code execution...
We support the default handlebars functionality as well as most of these.

@wrathagom I seen it here http://handlebarsjs.com/expressions.html
Adding a link is common thing in FAQ answers. Normal links work, but shorter anchor links are preferable.

Are you just showing the links in our chat area or what platforms do you have connected to Articulate? We can show some rich text in our chat area, but it likely wont be compatible with other services.

Currently no platforms are connected to articulate. In future I need to connect them to a website and internal company chat system. I think, that we will reuse some API endpoint, but currently I have no idea, how to connect my own chat presentation layer to articulate. Which endpoints can be used for this?

Whenever you are chatting in the interface you are using the /converse endpoint with a session ID of articulateUI


Feedback File Layout & Disbursement Activity

User Story
As a ministry user, I need the files sent to NSLSC to reflect all the data we have on file accurately and for the files received to be read in accurately.
Acceptance Criteria

[ ] FT Feedback File: PD/PPD flag is not being included in the file being received. Please confirm the layout we are using is accurate:

Business Context/Additional Considerations
FOS & Year of Study -- we need to add additional verification to make sure year of study aligns with field of study code
Currently rejecting at ecert time with no SIMS system catching it
make sure we expect SFAS/SIMS mixed records on all received files.

Updated this to 2.0 - it has to do with the FT files and possible future validations.


SF Project Retrieve Start --package-name also downloads "unpackaged" folder

Summary
Running the command sf project retrieve start --package-name 'name-of-changeset' will also download the folder 'unpackaged' which contains all the metadata in the environment.
Steps To Reproduce:
Using the following version of SF: @salesforce/cli/1.79.0 darwin-arm64 node-v18.15.0

create a change set with 1 or more components called testchangeset1
open a terminal and navigate to a folder with a Salesforce project
run the following command: sf project retrieve start --package-name testchangeset1
confirm that the change set as well as the unpackaged folder are downloaded

Expected result

testchangeset1 should be downloaded, no other folders

Actual result

There are two folders: testchangeset1 and unpackaged

System Information

Which shell/terminal are you using? (e.g. bash, zsh, powershell 5, powershell 7, cmd.exe, etc.)

If you are using sfdx

Run sfdx version --verbose --json

If you are using sf

Run sf version --verbose --json

{
"cliVersion"<EMAIL_ADDRESS>"architecture": "darwin-arm64",
"nodeVersion": "node-v18.15.0",
"osVersion": "Darwin 22.1.0",
"shell": "zsh",
"rootPath": "/Users/bambrick/.local/share/sfdx/client/7.201.6-4edd82d/sf",
"pluginVersions": [
"@oclif/plugin-autocomplete 2.2.0 (core)",
"@oclif/plugin-commands 2.2.15 (core)",
"@oclif/plugin-help 5.2.9 (core)",
"@oclif/plugin-not-found 2.3.23 (core)",
"@oclif/plugin-plugins 3.0.1 (core)",
"@oclif/plugin-search 0.0.17 (core)",
"@oclif/plugin-update 3.1.14 (core)",
"@oclif/plugin-version 1.3.4 (core)",
"@oclif/plugin-warn-if-update-available 2.0.36 (core)",
"@oclif/plugin-which 2.2.20 (core)",
"@salesforce/cli 1.79.0 (core)",
"apex 2.2.17 (core)",
"auth 2.7.15 (core)",
"data 2.3.16 (core)",
"deploy-retrieve 1.8.20 (core)",
"info 2.6.10 (core)",
"limits 2.3.14 (core)",
"login 1.2.8 (core)",
"org 2.8.2 (core)",
"schema 2.3.10 (core)",
"settings 1.4.6 (core)",
"sobject 0.1.18 (core)",
"source 2.10.7 (core)",
"telemetry 2.2.0 (core)",
"templates 55.4.13 (core)",
"trust 2.4.16 (core)",
"user 2.3.10 (core)"
]
}
Additional information
Feel free to attach a screenshot.

Hey @jxbambrick, is this a recent change in behavior? If so, what version of the CLI where you seeing the desired behavior?

I had an error after updating SFDX to the latest version. I don't know what my previous version was. In an attempt to resolve the error and update my deployment scripts, I switched from using SFDX commands to SF commands. I only need to download the specified change sets but it's including the unpackaged folder.
SFDX:

sfdx force:source:retrieve -x package_xml -u user_alias_placeholder --json

SF:

sf project retrieve start--target-org --target-metadata-dir dir_placeholder --manifest manifest_placeholder --json

Ok, I am still not able to reproduce your issue due to something unrelated, but I have been able to show that this used to work with sfdx force:mdapi:retrieve -p testchangeset1 -r export-dir -o hub
The structure created was (after unzipping):
.
|____testchangeset1
| |____package.xml
| |____objects
| | |____Broker__c.object
|____unpackaged.zip

Note that the unpackaged.zip only contained the the contents of the unpackaged directory


NuGet.exe update should mention PackageReference

The docs for NuGet.exe update mention that project.json is not supported. It should also mention that PackageReference is not supported by update.
https://docs.microsoft.com/en-us/nuget/tools/cli-ref-update

Fixed this a while ago.

@kraigb
"nuget update xxx.sln" could update all packages in all projects, but how to do it with "dotnet add package"?  If no, I don't think it's a fix.
https://docs.microsoft.com/en-us/dotnet/core/tools/dotnet-add-package
"dotnot add xxx.sln package" to update all packages?
Thanks a lot.

@fishingry For product changes and requests like this, please file an issue on https://github.com/NuGet/Home/issues. This repo is for documentation issues only.


Latest Version is broken on pnpm Watch

Describe the bug
Calling pnpm watch, it cannot find some files:
Library not loaded: @rpath/Squirrel.framework/Squirrel
Library not loaded: @rpath/ReactiveObjC.framework/ReactiveObjC
Library not loaded: @rpath/Mantle.framework/Mantle
I manually edited the node_modules folder to get the paths to match the error message. It works now, but will break again
Wanted path: node_modules/electron/dist/Electron.app/Contents/Frameworks/Squirrel.framework/Squirrel
Actual path:
node_modules/electron/dist/Electron.app/Contents/Frameworks/Squirrel.framework/Versions/A/Squirrel
The difference is "/Version/A/"
Weird?

When it breaks? I not testing and have not opportunity to support all package managers 😔 Maybe someone else can help 🤞

The odd thing is that I cloned your repo a few days ago and it worked fine. So maybe something changed with the latest commit.


Add Sbjson 5

This release allows scalar values at the top level; as recommended by RFC 7159, which obsoletes the original RFC 4627. Since it is a change in behaviour I chose to bump the major version to 5.
The main.m deviates slightly from v4 versions, as it does not exit immediately when it's parsed the first chunk. This brings it in line with non-chunking parsers that read the whole input before deciding if there's an error, thus reporting errors on "garbage after input" as the spec requires. (You probably wouldn't do this if using SBJson, but I wanted to make it clear that there's nothing stopping you from doing so.)

BTW, happy to move the latter two commits to a separate PR. I accept that you might not agree with those.

I updated this PR to remove the changes to the tests, which has been moved to #66.

cool, no more (known) crashers :)
http://seriot.ch/json/parsing.html#61


Execution runStudy with cohort

I tried to execute the program but keep getting stuck
**********************************************************
 ---- Copy cohorts to main table ----
**********************************************************
Copy and censor cohorts to main analysis table
  |                                                                    |   0%
Error: Error executing SQL:
Not enough resources for query planning - too many subqueries or query is too complex.

The underlying SQL looks like it's trying to do 1,275 union all statements in a CTE.  Apparently BigQuery has a limit of 1000 for unions within a cte.
If I re-write the query so all of the unions are inside a big "from" (i.e.: SELECT * INTO #TempTable FROM (the_long_list_of_unions) a), then I can get it to complete.  I'm not sure how to fold that into the program though.

Hi @CartWill - I think I need to pull in the BigQuery SMEs on this one. Let me reach out to them to see if they can provide some guidance. I seem to recall they had some approaches to deal with this limitation.

Hi @anthonysena @CartWill
It looks like you met this type of limits from this page:
Maximum number of tables referenced per query — 1,000
But I may be wrong. I asked this question to GCP team.

@anthonysena
I got confirmation from GCP team that this is a hard limit -- for the query engine. This was not part of the DDL limit removal. Suggestion it to break this up into separate jobs and then fuse the results.
@CartWill is it a problem you meet in this analysis only?

@konstjar @anthonysena It just happens with the runStudy with the "strata" group.  I also tried with the "feature" group and it also fails.  It looks like the SQL being generated is invalid:
Error executing query job. Message: Syntax error: Expected ")" but got keyword SELECT at [5:1]

SQL:
create table temp_covid_scratch.kivdo23ntarget_strata_xref
           as with data as (

select na target_id, na strata_id, na cohort_id, 'NA' cohort_type
select  target_id,  strata_id,  cohort_id, '' cohort_type
          )
           select target_id,strata_id,cohort_id,cohort_type
           from data

@CartWill - something seems a bit off in that I would have expected the inner query to contain the list of targetStrataXref contents as a list of UNION'ed SELECT statemented per the code here.
Could you share the parameters you are using to call the runStudy function? I'm particularly interested if you are overriding these default parameters:
cohortIdsToExcludeFromExecution = c(),
cohortIdsToExcludeFromResultsExport = NULL,
cohortGroups = getUserSelectableCohortGroups(),

These are the parameters I'm using.  It's basically just the standard params with just our local DBMS information filled in.
oracleTempSchema <- "temp_covid_scratch"

# Details specific to the database:
databaseId <- "UCHealth_OMOP"
databaseName <- "OMOP_COVID19"
databaseDescription <- "COVID19_UCHealth_OMOP"

# Details for connecting to the CDM and storing the results
outputFolder <- file.path("/srv/covid/Charybdis/Output")
cdmDatabaseSchema <- "omop_covid19"
cohortDatabaseSchema <- "omop_covid19_cohort"
cohortTable <- paste0("AS_CHARYBDIS_", databaseId)
cohortStagingTable <- paste0(cohortTable, "_stg")
featureSummaryTable <- paste0(cohortTable, "_smry")
minCellCount <- 10
maxCores <- 4
useBulkCharacterization <- TRUE
cohortIdsToExcludeFromExecution <- c()
cohortIdsToExcludeFromResultsExport <- NULL

      runStudy(connectionDetails = connectionDetails,
               cdmDatabaseSchema = cdmDatabaseSchema,
               cohortDatabaseSchema = cohortDatabaseSchema,
               cohortStagingTable = cohortStagingTable,
               cohortTable = cohortTable,
               featureSummaryTable = featureSummaryTable,
               oracleTempSchema = oracleTempSchema,
               exportFolder = outputFolder,
               databaseId = databaseId,
               databaseName = databaseName,
               databaseDescription = databaseDescription,
               cohortIdsToExcludeFromExecution = cohortIdsToExcludeFromExecution,
               cohortIdsToExcludeFromResultsExport = cohortIdsToExcludeFromResultsExport,
               incremental = TRUE,
               useBulkCharacterization = useBulkCharacterization,
               minCellCount = minCellCount)


Update PD Milestone levels for Confidence

Background
On #31  we did a first iteration using the Communication competency as an example of how we could allocate milestones by identifying what is good and what isn't. We need to do the same work for all other competencies.
This ticket is dependent on #41
Acceptance criteria

Add the milestones for all Confidence coursework (Emerging - Level 1, Developing - Level 2, Established)
Evaluate if changes are needed to the coursework and raise other tickets for it.

Owner: @LaraHuzjan @kfklein15
Stakeholder: @SallyMcGrath
Approver: @kfklein15

Confidence levels


Add Codable Support for Swift 4.x

Codable Suppor with Swift 4.x
Some examples of using Codable In and Out
Codable style function signature
Create file helloCodableAsync.swift
// Domain model/entity
struct Employee: Codable {
  let id: Int
  let name: String
}
// codable main function
func main(input: Employee, respondWith: (Employee?, Error?) -> Void) -> Void {
    // For simplicity, just passing same Employee instance forward
    respondWith(input, nil)
}

wsk action update helloCodableAsync helloCodableAsync.swift swift:4.1

ok: updated action helloCodableAsync
wsk action invoke helloCodableAsync -r -p id 42 -p name Carlos

{
    "id": 42,
    "name": "Carlos"
}

Codable Error Handling
Create file helloCodableAsync.swift
struct Employee: Codable {
    let id: Int
    let name: String
}
enum VendingMachineError: Error {
    case invalidSelection
    case insufficientFunds(coinsNeeded: Int)
    case outOfStock
}
func main(input: Employee, respondWith: (Employee?, Error?) -> Void) -> Void {
    // Return real error
    do{
        throw VendingMachineError.insufficientFunds(coinsNeeded: 5)
    } catch {
        respondWith(nil, error)
    }
}

wsk action update helloCodableError helloCodableError.swift swift:4.1

ok: updated action helloCodableError
wsk action invoke helloCodableError -b -p id 42 -p name Carlos

{
"name": "helloCodableError",
"response": {
  "result": {
    "error": "insufficientFunds(5)"
  },
"status": "application error",
"success": false
}

Depends on #22
Closes #2

TODOs

[ ] Handle when input params is empty
[ ] Add tests cases for Codable

I've been testing out Codable support from the sample above in my library for wrapping Swift actions to produce binaries.
https://github.com/jthomas/OpenWhiskAction/blob/swift4/Sources/epilogue.swift
It's all working great but I made a few changes to improve the developer experience that we'd probably want to include. Here are the things I found....

Support @escaping closures to allow users to use with async calls.

func _run_main<In: Codable, Out: Codable>(mainFunction: (In, @escaping (Out?, Error?) -> Void) -> Void) {
}

This just needs the annotation adding and doesn't affect existing code or people who don't use that.

Improved error handled to give more descriptive messages, e.g.
https://github.com/jthomas/OpenWhiskAction/blob/swift4/Sources/epilogue.swift#L84-L93

This helps the user understand when there has been problems using the Codable API versus something else.

Sync method style APIs should probably support throws. This enables uses to use normal error handling to surface issues.

I'm away on vacation for a week but will attempt to push a PR when I return.

Thanks @jthomas for the review and starting the work to externalize the epilogue in to it's own library/package.

Support @escaping closures to allow users to use with async calls.

func _run_main<In: Codable, Out: Codable>(mainFunction: (In, @escaping (Out?, Error?) -> Void) -> Void) {
}

This just needs the annotation adding and doesn't affect existing code or people who don't use that.
Guess what I have in my TODOs?
TODOS:

[ ] Finish with the Codable test cases
[ ] Use @escaping instead for the callback
[ ] Refresh again with latest 4.1 snapshot
[ ] With now 4.2 announced 4.1 is stable, so skip/remove 4.0 support only do 4.1 for now

https://github.com/jthomas/OpenWhiskAction/blob/swift4/Sources/epilogue.swift#L84-L93
This helps the user understand when there has been problems using the Codable API versus something else.

I will add the one for more verbose errors 👍

[ ] Improved error handled to give more descriptive messages, e.g.

Sync method style APIs should probably support throws. This enables uses to use normal error handling to surface issues.

I thought about this one, will look into this but probably a different PR since it's an improvement to dictionary sync that we have today.
https://github.com/apache/incubator-openwhisk-runtime-swift/issues/29
Super happy that someone is trying this stuff 🎉

Woot !

[ ]  Finish with the Codable test cases

Woot !

[ ] Refresh

again with latest 4.1 snapshot

Woot !

[ ]  Improved error handled to give more descriptive messages, e.g.

With now 4.2 announced 4.1 is stable, so skip/remove 4.0 support only do 4.1 for now

Going to move this to a new issue https://github.com/apache/incubator-openwhisk-runtime-swift/issues/30

I think I'm ready for review and final merge of this PR


Version
v2.12.2
Reproduction link
https://codesandbox.io/s/serene-minsky-66vzv?file=/pages/index.vue
Steps to reproduce

add

Please use the head property to add external scripts (related: https://vue-meta.nuxtjs.org/api/#script)


Add UTM parameter to the custom social link

FEATURE OVERVIEW
User Story
As an admin, I would like to easily see in GA all traffic coming in from custom social links.
Additional Information (optional)
If this is doable, will get the UTM parameter we want to use
Why This Matters
So we can see who is coming in from the custom social link
Current Workaround w/o Feature (if applicable)
There's a way to manually group all of the traffic from custom social links in GA, but it's not ideal.

General Custom Social Shares (‘normal’ people)
https://dosomething.org/us/campaigns/lose-your-v-card?source=user/northstarID?utm_source=influencer&utm_medium=referral_web&utm_campaign=members
and for the social buttons, let's just keep them the same since it's too deep to change the UTM parameters that are already there and you can't have multiple of the same UTM parameters (to my knowledge) -- meaning we couldn't append it w/ another medium (custom_shares). this is ok with marketing and since we're hiding hte problem share, we know that this is the custom social share. for future uses of teh custom social though, we'll want to dig into the code and be able to edit these UTM parameters.
let me know if you have ?s!


Rename the global variable in Base64

Since this is a "class", it should be named with the first letter in uppercase.

Hi,
I think that it's a namespace not a class.
Ant it seems there is no convention about namespace naming.
How do you think?

If you see it as a namespace, it's fine as it is. I'd think at it more as a class with only static methods.


Python Language Extension to have the same Functionality as C# or C++

This issue has been moved from a ticket on Developer Community.

I will like Microsoft to extend to the Python language the same functionality that is with the C++ and C# languages on VS IDE.
But before promising me you will come back to me in 7 days.  Do something concrete and just make sure that in the next major release of VS IDE, it will have a fully functional Python language tool (with support for Windows, desktop, Cloud, UWP etc. projects).
If you can do this, then I will believe that in the future, say for the 2024 edition of VS IDE, you will also build in Java, Rust, Kotlin and maybe Scala support.

Original Comments
Feedback Bot on 10/19/2022, 11:29 PM:
(private comment, text removed)
andrew goh soo meng on 10/20/2022, 06:06 AM:
(private comment, text removed)
andrew goh soo meng on 10/22/2022, 01:40 AM:
(private comment, text removed)

Hi there, thank you for your feedback! We do have a roadmap on the way for PTVS, and we have also just opened the discussion session for moving issues to discussion as enhancement requests for comments and upvotes.😊Let us know if you have any specific suggestions. Thanks!


Prevent logs to write credentials from installs

Overview
We have several log messages, that need to be disabled or protected under a flag, to prevent log of some key credentials:
Examples:
LOG: 2022/09/12 13:46:34.422067 /home/developer/app/cmd/createUtils.go:243: {"keys":[],"keys_base64":[],"recovery_keys":

Mitigated on #953.

No creds were found on 1.11 effort after post #896 to be completed.


Adding timestamp option for S390x platform

Fixes #3511

@msimberg FWIW, I added this to the 1.2.1 milestone. We should consider having it in the point release

Somehow boost_context is not provided on this arch and I could not compile hpx and test this pr.

Looks relevant: https://github.com/openmainframeproject/tsc/blob/master/proposed_projects/Boost Context.md. I think we can live without s390x for now.

@diehlpk I think we just miss a !defined(__s390x__) here: https://github.com/STEllAR-GROUP/hpx/blob/master/hpx/runtime/threads/coroutines/detail/context_impl.hpp#L116 and a defined(__s390x__) here: https://github.com/STEllAR-GROUP/hpx/blob/master/hpx/runtime/threads/coroutines/detail/context_impl.hpp#L125. Also you shouldn't try to compile on that platform using the Boost context library.

@diehlpk could you trigger a new build, please? Please also remove the -DHPX_WITH_GENERIC_CONTEXT_COROUTINES=On for this platform.

@hkaiser Still some unsupported plattform error https://koji.fedoraproject.org/koji/watchlogs?taskID=32537060

@hkaiser Your latest commit compiles, but does not link
https://kojipkgs.fedoraproject.org//work/tasks/8921/32538921/build.log

@hkaiser The latest commit resolves in
BUILDSTDERR: /builddir/build/BUILD/hpx_1.2.1/src/runtime/threads/coroutines/swapcontext.cpp:19:2: error: #error Unsupported platform
BUILDSTDERR:    19 | #error Unsupported platform

on s390x, arm64, and arm7.
https://koji.fedoraproject.org/koji/taskinfo?taskID=32541821

@hkaiser Could you revert the last commit, there is some special behaviour on fedora on s390x and I could resolve it, but not using your latest commit.

Somehow arm7 fails now not due to memory consumption, it fails because of
/BUILD/hpx_1.2.1/src/runtime/threads/coroutines/swapcontext.cpp
BUILDSTDERR: /builddir/build/BUILD/hpx_1.2.1/src/runtime/threads/coroutines/swapcontext.cpp:19:2: error: #error Unsupported platform
BUILDSTDERR:    19 | #error Unsupported platform
BUILDSTDERR:       |  ^~~~~
BUILDSTDERR: make[2]: *** [src/CMakeFiles/hpx.dir/build.make:1002: src/CMakeFiles/hpx.dir/runtime/threads/coroutines/swapcontext.cpp.o] Error 1

https://kojipkgs.fedoraproject.org//work/tasks/4907/32544907/build.log

@diehlpk On ARM architectures we do need the Boost context library, please add -DHPX_WITH_GENERIC_CONTEXT_COROUTINES=On for that platform.

Could you revert the last commit, there is some special behaviour on fedora on s390x and I could resolve it, but not using your latest commit.

Feel free to push to this branch with any changes you have to apply.

@hkaiser I already used this flag to build on arm for f28 and f29, but somehow it is not working anymore

%build
# use generic context for these archs
%ifarch aarch64 armv7hl
%define cmake_opts -DHPX_WITH_GENERIC_CONTEXT_COROUTINES=ON
%endif

@diehlpk from the logs you linked above I see:
+ /usr/bin/cmake -DCMAKE_C_FLAGS_RELEASE:STRING=-DNDEBUG \
    -DCMAKE_CXX_FLAGS_RELEASE:STRING=-DNDEBUG \
    -DCMAKE_Fortran_FLAGS_RELEASE:STRING=-DNDEBUG \
    -DCMAKE_VERBOSE_MAKEFILE:BOOL=ON \
    -DCMAKE_INSTALL_PREFIX:PATH=/usr \
    -DINCLUDE_INSTALL_DIR:PATH=/usr/include \
    -DLIB_INSTALL_DIR:PATH=/usr/lib \
    -DSYSCONF_INSTALL_DIR:PATH=/etc \
    -DSHARE_INSTALL_PREFIX:PATH=/usr/share \
    -DBUILD_SHARED_LIBS:BOOL=ON \
    -DLIB=lib \
    -DCMAKE_CXX_FLAGS=-O2 -g -pipe -Wall -Werror=format-security \
    -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS \
    -fexceptions -fstack-protector-strong -grecord-gcc-switches \
    -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 \
    -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 \
    -march=armv7-a -mfpu=vfpv3-d16 -mtune=generic-armv7-a \
    -mabi=aapcs-linux -mfloat-abi=hard -O1

which tells me that the flag is not passed down to the cmake invocation...

Also, somehow the build still reports HPX V1.2.0 I think you're missing some of @msimberg's patches.

It seems that the HPX version is not updated in the 1.2.1-rc candidate

@msimberg ping?

It seems that the HPX version is not updated in the 1.2.1-rc candidate

@msimberg ping?

I've just fixed that on the release branch. I'll make a PR to generate the version header based on the values in CMakeLists.txt, this is a bit too error prone...


Add test for Local Variable Type Inference

Enhance the test suite to verify that variables in tests containing var keywords are correctly recorded. Similar tests can be found in the junit4-tests project. For more info about Local Variable Type Inference, see JEP 286 and JEP 323.
Also, add a failing test to the showcase project, to make sure that the rendered failure message looks pretty.
Note: please make sure to visit the contribution and development guide for some important notes on how to build and debug Scott.

I will work on this.

Awesome! 👍

Hi David
I had a bit of trouble with Jdk 11 on my Dev environment. I could not
progress much on this one.
My apologies :(
On Wed., 24 Oct. 2018, 05:28 Dávid Csákvári<EMAIL_ADDRESS>wrote:

Hey @vpondala https://github.com/vpondala ,
How's it going? Can I help you with anything regarding this issue?
Cheers,
David
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/dodie/scott/issues/47#issuecomment-432364819, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ABYhMO8EtZIYgS9l2pNWQKFejl5OOIcyks5un1_GgaJpZM4XBEyl
.

Sure, no problem. :)

I'm having trouble with maven plugin compatibility with JDK 11. Let me work on this and keep you posted.

Sure! Thanks for piloting the JDK 11 support!

Hi @vpondala!
I am planning to release the next version of Scott soon, so I've added the necessary changes regarding this issue, to make the next version Java 11 compatible.
Cheers,
David

Great stuff. Sorry for the delay.
On Sat., 1 Dec. 2018, 09:34 Dávid Csákvári<EMAIL_ADDRESS>wrote:

Hi @vpondala https://github.com/vpondala!
I am planning to release the next version of Scott soon, so I've added the
necessary changes regarding this issue, to make the next version Java 11
compatible.
Cheers,
David
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/dodie/scott/issues/47#issuecomment-443360287, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ABYhMNVcuUTwpu4II2KEE61p-lCZARcqks5u0bKFgaJpZM4XBEyl
.


display kph to km/h mph to mi/h

Choose one of the templates below:
Fingerprint
This pull requests adds a fingerprint for <Make - Model - Year - Trim>.
This is an explorer link to a drive with the stock system enabled: ...
Car support
This pull requests adds support for <Make - Model - Year - Trim>.
This is an explorer link to a drive with the stock system enabled: ...
This is an explorer link to a drive with openpilot system enabled: ...
Feature
This pull requests adds feature X
Description
Explain what the feature does
Testing
Explain how the feature was tested. Either by the added unit tests, or what tests were performed while driving.

I will merge this but
it is better if you make this PR directly to comma.ai branch


Any way to remember window positions?

I have to drag the windows to the side monitors every single time I launch,  any way to make them remember where they go and even auto launch them when I start Icarus?

Yeah this is minor annoyance. To be honest, I probably won't bother as dealing with things like displays changing size or configuration (and even just multiple displays on Windows) is a pain to do, but it's a reasonable request!


TypeScript Error with latest dom-testing-library

I'm not sure whether this rather belongs into dom-testing-library...

react-testing-library version: 6.0.1
react version: 16.8.4
node version: 10.15.3
npm (or yarn) version: 1.15.2

Relevant code or config:
We are using a default CRA2 setup. There is no dependency on dom-testing-library defined on the project; only react-testing-library.
What you did:
yarn update

What happened:
yarn start now yields:
node_modules/react-testing-library/typings/index.d.ts
TypeScript error: Type 'typeof import("./node_modules/dom-testing-library/typings/queries")' does not satisfy the constraint 'Queries'.
  Property 'findByLabelText' is incompatible with index signature.
    Type 'FindByText' is not assignable to type 'Query'.
      Type 'Error | Promise<HTMLElement>' is not assignable to type 'HTMLElement | HTMLElement[] | null'.
        Type 'Error' is not assignable to type 'HTMLElement | HTMLElement[] | null'.
          Type 'Error' is missing the following properties from type 'HTMLElement[]': length, pop, push, concat, and 26 more.  TS2344

    11 | }
    12 |
  > 13 | export type RenderResult<Q extends Queries = typeof queries> = {
       |                                              ^
    14 |   container: HTMLElement
    15 |   baseElement: HTMLElement
    16 |   debug: (baseElement?: HTMLElement | DocumentFragment) => void

After pinning dom-testing-library to version 3.18.1 via resolutions everything compiles again.

Reproduction:

Problem description:

Suggested solution:

I don't maintain the typescript typings. If anyone would like to open a pull request to fix this I will merge it.

I prepared a quick fix for this.

:tada: This issue has been resolved in version 6.0.2 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Disable/Remove input toolbar for one-way messaging

I need to setup a one-way messaging system in my app and am hoping to use this library. Is it possible to remove the input toolbar completely? So that on the user-end of this app, they can receive but not send messages?

I came across the same problem and went through the same steps and got the same results. It crashes when i try to do what was suggested in #446  I was wondering why no one has brought up the option of just setting hidden to YES? It seems to work for me and no crashes either. My code looks like
        self.inputToolbar.contentView.textView.editable = NO;
        self.inputToolbar.hidden = YES;

[self.inputToolbar removeFromSuperview]; makes the text in my bubbles appear with only 1 or 2 characters per line.


#14763 - Migrate PDF endpoint to a service model

Pull-request for issue #14763 created by @pasaperez-slingr
What it does?
Migrates the pdfGenerator endpoint to pdf service.
How to test it?
Make calls from console to the service.
Implementation notes
There no implementation notes
Deployment notes
Register the service on Developer-Portal. And build last version.

We are in master so consider as merged.


Google Bluetooth disabled notification not translated to German

Avoid duplicates

[X] Bug is not mentioned in the FAQ
[X] Bug is specific for Android only, for general issues / questions that apply to iOS and Android please raise them in the documentation repository
[ ] Bug is not already reported in another issue
This bug was mentioned as an aside in https://github.com/corona-warn-app/cwa-app-android/issues/2564#issuecomment-796685805 from @dsarkar.

Technical details

Device name: Samsung Galaxy A5 (2017) SM-A520F
Android version: 8.0.0
App version: 1.14.3
Google Exposure Notifications System version:<PHONE_NUMBER>0

Describe the bug
The notification produced by the Google Exposure Notifications System when Bluetooth is disabled is partially in English when the device locale is set to Deutsch (Deutschland) i.e. German.
Steps to reproduce the issue

Set device locale to Deutsch (Deutschland)
Open CWA and ensure that status "RISIKO-ERMITTLUNG AKTIV" is shown
Close CWA
Einstellungen > Verbindungen > Bluetooth and disable Bluetooth (AUS)
Wait for notification

The notification no longer appears immediately, like it did in the past. You need to wait. I don't know what controls the delay and I can't say how long you need to wait: somewhere between 5 and 30 minutes.
The screenshot below shows the notification with the locale set to Deutsch (Deutschland) on the left and English (United States) on the right,

Expected behavior
If the device locale is set to Deutsch (Deutschland) then the complete text of the Google Exposure Notifications System notification should be in the German language. The notification is displayed (delayed) after Bluetooth is disabled whilst there is an active COVID-19 app on the device.
Possible Fix
Ensure that German strings are available and used for the Google ENS notification message.
This is a Google issue.

Internal Tracking ID: EXPOSUREAPP-5574

@dsarkar posted detailed screenshots showing the previous message in https://github.com/corona-warn-app/cwa-app-android/issues/920#issuecomment-750849906:

This shows that it is a regression in Google ENS.

@MikeMcC399
Thank you. I have created a Jira ticket for the problem. We will notify Google about the issue.

Corona-Warn-App Open Source Team

Will be fixed in the next Google ENF release v1.8 >= 210900000

Duplicate of Internal Tracking ID: EXPOSUREAPP-5574

Verified fixed with Google Play services (Google Play-Dienste) 21.09.15, shown in CWA as<PHONE_NUMBER>0.
The following notification is shown 30 minutes after disabling Bluetooth when:

device locale is set to Deutsch (Deutschland)
CWA is installed and was showing "RISIKO-ERMITTLUNG AKTIV" before Bluetooth was disabled

Closing due to successful resolution by Google.

@MikeMcC399  thanks for checking.

@MikeMcC399 I can confirm your observation in your last comment. Did you trigger to get the new ENS the following way?
OS Settings > Apps > Scroll down to Google Play Services and tap on it > Scroll down to details in store and tap on it > tap on update.
Then close CWA (swipe up) and re-open CWA.

@dsarkar

OS Settings > Apps > Scroll down to Google Play Services and tap on it > Scroll down to details in store and tap on it > tap on update.

That is a good way to check if any updates are available to Google Play services (including the Exposure Notifications System). In fact I have one device that updated on its own and another device Samsung Galaxy A50 SM-A505FN which still hasn't had an update offered. This one has 21.06.13<PHONE_NUMBER>43053) of Google Play services currently installed. I would have expected it to get Version: 21.09.15<PHONE_NUMBER>52764) installed, but something seems to be preventing the rollout of this particular variant. Perhaps there is an issue and Google has paused the rollout?

@MikeMcC399

I would have expected it to get Version: 21.09.15<PHONE_NUMBER>52764) installed, but something seems to be preventing the rollout of this particular variant. Perhaps there is an issue and Google has paused the rollout?

I triggered the update with above described method about one hour ago.

@dsarkar

I triggered the update to Version: 21.09.15<PHONE_NUMBER>52764) with above described method about one hour ago.

Interesting! What device and what Android version is this for? Mine is A50 and Android 10.

@MikeMcC399 Samsung A21s and Android 10. Just now I got feedback from a dev: Also Google Play Services is rolled out in stages.

@MikeMcC399 Could you let me know if you could trigger a Google Play Services update at some point on your Samsung Galaxy A50 SM-A505FN  and if this then included ENS > 210900000? Thanks!

@dsarkar
My Samsung Galaxy A50 SM-A505FN is still at
21.06.13<PHONE_NUMBER>43053)
and no update for Google Play services is offered to me by Google Play Store at this time. I will continue to monitor the device.

@MikeMcC399 Good morning, could you update GPServices? Thanks.

@dsarkar
Good morning!
No change on the device Samsung Galaxy A50 SM-A505FN. If I go to Google Play Store there is no option to Update, only to Deactivate.

@MikeMcC399 OK, thanks for the feedback! I assume that ENS version number has not change and notifications are still in English then (even when German locale). Will try to get some info, if roll-out has been stopped.

@dsarkar
On my Samsung Galaxy A50 SM-A505FN the ENS has updated automatically to Version<PHONE_NUMBER>0.
The UI also now has an additional option "Add another region". This feature allows the user to choose a country and if appropriate also a region in a country. This then links to an entry for the appropriate app in the Google Play Store to be able to install the app. Google Exposure Notifications System still allows only one region to be active at one time, so if a user of CWA for Germany installs an app from another country and makes this other app active then CWA will be deactivated. By opening CWA it is possible to switch back to CWA as active app once again.

@MikeMcC399 Thanks for the feedback. So apparently no always and every user can update Google Play Services on demand.

The UI also now has an additional option "Add another region". This feature allows the user to choose a country and if appropriate also a region in a country. This then links to an entry for the appropriate app in the Google Play Store to be able to install the app. Google Exposure Notifications System still allows only one region to be active at one time, so if a user of CWA for Germany installs an app from another country and makes this other app active then CWA will be deactivated. By opening CWA it is possible to switch back to CWA as active app once again.

This reminds me that we probably need a FAQ explaining what to do if you travel.

@dsarkar

So apparently no always and every user can update Google Play Services on demand.

Unfortunately the way Google handles this is not transparent, so it's difficult to predict what is possible and not possible.

This reminds me that we probably need a FAQ explaining what to do if you travel.

That would be a good idea. It could cover short trips, longer trips and what to do if a user lives in a border region and regularly moves between one country and another such as on a daily basis.


Migrating: fs2-compress

Migration Checklist
Project Submission Issue: #90
For All Projects:

[x] Add project to the site by adding an entry to the projects.yml file

Announcements
These steps are optional but encouraged.

[ ] Write a blog post announcing the change
[ ] Post to our social channels (Twitter, Mastodon)

Added to site in https://github.com/typelevel/typelevel.github.com/pull/443

I'll toot it on a weekday when more people are paying attention.

Toot


Feature/config option if elasticsearch is not located in the root folder

…: http://Server:Port/Path

Thanks :)


Update MS High Performance Package to 7.0.0

Currently the high performance dependency uses a preview release. The package now has a stable version. Would be great to get a new nuget package with the latest stable version.

Thanks for notifying. I'll see if I can get an update out today or tomorrow.

New version is out on Nuget now