Multi-select in the Explorer: Delete deselected folder instead of selected ones

Exactly the same issue as #43233, it doesn't seem to be fixed here (or re-introduced).

VSCode Version: 1.41-insiders
OS Version: Win7x64

Steps to Reproduce:

Multi-select several folders/files in the explorer.
Deselect a single folder (CTRL+Click)
Use the delete key on the keyboard

Expected: It should delete the folders/files still in the multi-selection
Actual: It wants to delete the de-selected folder/file

This issue is also present in vscode stable, so not an immediate regression.
The issue here is that we always respect focus when you are triggering commands.
And in this particular case the focus does not really repesetn what you want to do.
Bottom line I think the list / tree should not focus an element if it is removed from the selection.
The focus should remain unchanged. Only if clicked one more time.
Let me know what you think @joaomoreno

Not sure I agree, since the focus is later on used as an anchor point for contiguous multiple selection.
Maybe the better fix would be to disregard focus and just use selection if there is multiple selection and the driving user action was the keyboard.

Any idea why it was reintroduced, by the way? Assuming it was fixed last time.

Yes, we could disregard focus if there is multiple selection. However commands are not aware how they are triggered via keyboard or via context menu.
As to why it was reintroduced: I do not know, my best guess would be that I did some ugly workaround to make it work and than later when refactoring the code I removed the workaround. Sorry for not remembering more.

I personally think this should be addressed for a few reasons.

Most importantly, this bug has serious consequence: the users may accidentally delete a file and therefore data loss.
This is clearly a bug, not a feature request. So I'm not sure why it applies to whatever the bot linked above ("decision-making process").
It has been reported before and presumably fixed, but reintroduced (therefore it shouldn't be "out-of-scope" this time.)

+1

+1


Variable Substitution Relative Path

The current set of Variable Substitution macros does not support the ability to access a relative path to the current opened file based off the cwd of the task.
${workspaceRoot} the path of the folder opened in VS Code
${file} the current opened file
${fileBasename} the current opened file's basename
${fileDirname} the current opened file's dirname
${fileExtname} the current opened file's extension
${cwd} the task runner's current working directory on startup

I've played around with the code and think I can make a PR for this. Just wondering whether it would be better to surface:
${relDir}  path to the directory of the current opened file based off the cwd
or
${relFile} path to the current opened file based off the cwd

PR: https://github.com/Microsoft/vscode/pull/8982
Also added to the documentation here: https://github.com/Microsoft/vscode-docs/pull/464

PR got merged a long time ago. Closing


Added Haveno, removed Localmonero

Title is self explanatory, this PR replaces Localmonero with Haveno in Community > Merchants & Exchanges > P2P exchanges and Atomic Swaps.
Closes #2304

replace logo with svg [logo]

We should.consider leaving it up and displaying the above timeline for 6 months with the deletion coming after as this may help someone
~ plowsof

Looking at #2293, how should it be handled?
IMO if you want to keep linking Localmonero it may make sense to just push it to the bottom of the list since the roadmap is displayed prominently on the homepage of Localmonero.
It could also be grayed out / a warning could be shown in the description but at that point what's the point of keeping it linked?

replace logo with svg [logo]

i thought we had established svg's should be replaced from getmonero https://github.com/freedomofpress/securedrop/issues/1574#issuecomment-279068270

I also NACK at this moment in time for listing haveno.exchange on the merchants/p2p section. it's mostly info / a blog.

I also NACK at this moment in time for listing haveno.exchange on the merchants/p2p section. it's mostly info / a blog.

Sure, I'll close this until it's more mature.


Develop: Accessibility adjustments for Chatbot

As a user who enables accessibility features on my device, I want the application to be intuitive to use with these tools.
Acceptance Criteria

For the Login Page:

All functionality can be read and interacted with using native screen reader tools

Controls are read in a logical order to orient the listener without looking at the screen
No extraneous content is read aloud which provides no value to the listener

All functionality can be accessed intuitively using native voice control tools

Controls can be accessed wherever possible using their "name" rather than forcing users to rely on "numbers"

Will need to use the "show numbers" functionality on this page

Generally Verified - Test PASS


Captions

Fixes captions toward brevity and discussion in the text. Thanks for the review @jbae11 .

@jbae11 is this ready to merge, then?

Thanks!


Define iostream, compatible with stream interface

Entire I/O stream feature will be implemented at dedicated streaming library


interolivary commissure

need terms for hindbrain commissures, in particular the interolivary commissure.  A similar posting is made on adult mouse anatomy tracker.
Reported by: cindyJax
Original Ticket: obo/mammalian-phenotype-requests/877

MA term is "inferior olivary commissure" MA:0003019
No definition for this term in uberon
Only 1 annotation to abnormal commissure mentions interolivary
closing, will reopen if needed


Update unique-tags.md

👷 Deploy Preview for famous-marshmallow-cfbd61 processing.

Name
Link

🔨 Latest commit
3f55780637290736e5ad434bedf2db90bc99bdd0

🔍 Latest deploy log
https://app.netlify.com/sites/famous-marshmallow-cfbd61/deploys/64a5069fdf39240008e472cd


ResolutionParser.TryParse doesn't recognize dates because LUIS doesn't provide resolution_type anymore

Here's a fragment of the JSON LUIS returns:
{
  "entity": "next week",
  "type": "builtin.datetime.date",
  "startIndex": 23,
  "endIndex": 31,
  "resolution": {
    "date": "2017-W09"
  }
},

Since there's no resolution_type on the resolution object, ResolutionParser skips it.

I'm not reproducing this issue - what endpoint are you using?
{
  "query": "can you set an alarm for last week and saturdays in september",
  "intents": [
    {
      "intent": "builtin.intent.alarm.set_alarm"
    }
  ],
  "entities": [
    {
      "entity": "last week and saturdays in september",
      "type": "builtin.alarm.start_date",
      "resolution": {
        "date": "2017-W07",
        "resolution_type": "builtin.datetime.date"
      }
    },
    {
      "entity": "last week and saturdays in september",
      "type": "builtin.alarm.start_date",
      "resolution": {
        "resolution_type": "builtin.datetime.set",
        "set": "XXXX-WXX-6"
      }
    },
    {
      "entity": "last week and saturdays in september",
      "type": "builtin.alarm.start_date",
      "resolution": {
        "date": "XXXX-09",
        "resolution_type": "builtin.datetime.date"
      }
    }
  ]
}

LUIS returns resolution only for the English culture

@jorupp Do you still need help here, or did the comment from @willportnoy clarify your issue?

I'm using a custom LUIS app. (will email subscription key to @carlosscastro's listed address )
https://api.projectoxford.ai/luis/v2.0/apps/d04fe6ff-5710-4a2b-9abc-658022974967?subscription-key=xxxxxxxxxxxxxxxx&q=find a sharepoint developer next week for 5 hours
returns:
{
  "query": "find a sharepoint developer next week for 5 hours",
  "topScoringIntent": {
    "intent": "getExpertAvailability",
    "score": 1.0
  },
  "entities": [
    {
      "entity": "developer",
      "type": "role",
      "startIndex": 18,
      "endIndex": 26,
      "score": 0.969879031
    },
    {
      "entity": "sharepoint",
      "type": "expertArea",
      "startIndex": 7,
      "endIndex": 16,
      "score": 0.974121451
    },
    {
      "entity": "a",
      "type": "builtin.number",
      "startIndex": 5,
      "endIndex": 5,
      "resolution": {
        "value": "1"
      }
    },
    {
      "entity": "5",
      "type": "builtin.number",
      "startIndex": 42,
      "endIndex": 42,
      "resolution": {
        "value": "5"
      }
    },
    {
      "entity": "next week",
      "type": "builtin.datetime.date",
      "startIndex": 28,
      "endIndex": 36,
      "resolution": {
        "date": "2017-W12"
      }
    },
    {
      "entity": "5 hours",
      "type": "builtin.datetime.duration",
      "startIndex": 42,
      "endIndex": 48,
      "resolution": {
        "duration": "PT5H"
      }
    }
  ]
}

Do I need to change a setting in my LUIS app, or the intent that's recognizing this?  I don't seem to have much control from the UI over the matching of the built-in datatypes like this one.

Should also add - the LUIS app's culture is set to en-us.

@jameslew, @chrimc62 can you comment on this? Thanks!

The resolution type is only returned in case of the Cortana pre-built application

Just to clarify Carols comments, when you use the prebuilt Cortana domain it includes a resolution type.  In this case it is because it is the alarm prebuilt intent.  When you include the generic date time resolution type is not included.  I'll file a bug to look at this.


LINK : fatal error LNK1104: cannot open file 'ucrtd.lib'

I have installed windows 10 sdk, but vcpkg can't find it.
[1/2] cmd /c "cd .. && "H:/ProgramData/CMake/bin/cmake.exe" "H:/ProgramDesign/VCPKG/vcpkg/buildtrees/zlib/src/1.2.11-f690224aeb" "-DSKIP_INSTALL_FILES=ON" "-DSKIP_BUILD_EXAMPLES=ON" "-DCMAKE_MAKE_PROGRAM=H:/ProgramDesign/VCPKG/vcpkg/downloads/tools/ninja/ninja-1.8.2/ninja.exe" "-DBUILD_SHARED_LIBS=ON" "-DVCPKG_CHAINLOAD_TOOLCHAIN_FILE=H:/ProgramDesign/VCPKG/vcpkg/scripts/toolchains/windows.cmake" "-DVCPKG_TARGET_TRIPLET=x64-windows" "-DVCPKG_PLATFORM_TOOLSET=v140" "-DCMAKE_EXPORT_NO_PACKAGE_REGISTRY=ON" "-DCMAKE_FIND_PACKAGE_NO_PACKAGE_REGISTRY=ON" "-DCMAKE_FIND_PACKAGE_NO_SYSTEM_PACKAGE_REGISTRY=ON" "-DCMAKE_INSTALL_SYSTEM_RUNTIME_LIBS_SKIP=TRUE" "-DCMAKE_VERBOSE_MAKEFILE=ON" "-DVCPKG_APPLOCAL_DEPS=OFF" "-DCMAKE_TOOLCHAIN_FILE=H:/ProgramDesign/VCPKG/vcpkg/scripts/buildsystems/vcpkg.cmake" "-DCMAKE_ERROR_ON_ABSOLUTE_INSTALL_DESTINATION=ON" "-DVCPKG_CXX_FLAGS=" "-DVCPKG_CXX_FLAGS_RELEASE=" "-DVCPKG_CXX_FLAGS_DEBUG=" "-DVCPKG_C_FLAGS=" "-DVCPKG_C_FLAGS_RELEASE=" "-DVCPKG_C_FLAGS_DEBUG=" "-DVCPKG_CRT_LINKAGE=dynamic" "-DVCPKG_LINKER_FLAGS=" "-DCMAKE_INSTALL_LIBDIR:STRING=lib" "-DCMAKE_INSTALL_BINDIR:STRING=bin" "-G" "Ninja" "-DCMAKE_BUILD_TYPE=Release" "-DCMAKE_INSTALL_PREFIX=H:/ProgramDesign/VCPKG/vcpkg/packages/zlib_x64-windows""
FAILED: ../CMakeCache.txt
cmd /c "cd .. && "H:/ProgramData/CMake/bin/cmake.exe" "H:/ProgramDesign/VCPKG/vcpkg/buildtrees/zlib/src/1.2.11-f690224aeb" "-DSKIP_INSTALL_FILES=ON" "-DSKIP_BUILD_EXAMPLES=ON" "-DCMAKE_MAKE_PROGRAM=H:/ProgramDesign/VCPKG/vcpkg/downloads/tools/ninja/ninja-1.8.2/ninja.exe" "-DBUILD_SHARED_LIBS=ON" "-DVCPKG_CHAINLOAD_TOOLCHAIN_FILE=H:/ProgramDesign/VCPKG/vcpkg/scripts/toolchains/windows.cmake" "-DVCPKG_TARGET_TRIPLET=x64-windows" "-DVCPKG_PLATFORM_TOOLSET=v140" "-DCMAKE_EXPORT_NO_PACKAGE_REGISTRY=ON" "-DCMAKE_FIND_PACKAGE_NO_PACKAGE_REGISTRY=ON" "-DCMAKE_FIND_PACKAGE_NO_SYSTEM_PACKAGE_REGISTRY=ON" "-DCMAKE_INSTALL_SYSTEM_RUNTIME_LIBS_SKIP=TRUE" "-DCMAKE_VERBOSE_MAKEFILE=ON" "-DVCPKG_APPLOCAL_DEPS=OFF" "-DCMAKE_TOOLCHAIN_FILE=H:/ProgramDesign/VCPKG/vcpkg/scripts/buildsystems/vcpkg.cmake" "-DCMAKE_ERROR_ON_ABSOLUTE_INSTALL_DESTINATION=ON" "-DVCPKG_CXX_FLAGS=" "-DVCPKG_CXX_FLAGS_RELEASE=" "-DVCPKG_CXX_FLAGS_DEBUG=" "-DVCPKG_C_FLAGS=" "-DVCPKG_C_FLAGS_RELEASE=" "-DVCPKG_C_FLAGS_DEBUG=" "-DVCPKG_CRT_LINKAGE=dynamic" "-DVCPKG_LINKER_FLAGS=" "-DCMAKE_INSTALL_LIBDIR:STRING=lib" "-DCMAKE_INSTALL_BINDIR:STRING=bin" "-G" "Ninja" "-DCMAKE_BUILD_TYPE=Release" "-DCMAKE_INSTALL_PREFIX=H:/ProgramDesign/VCPKG/vcpkg/packages/zlib_x64-windows""
CMake Warning at H:/ProgramDesign/VCPKG/vcpkg/scripts/buildsystems/vcpkg.cmake:107 (message):
There are no libraries installed for the Vcpkg triplet x64-windows.
Call Stack (most recent call first):
H:/ProgramData/CMake/share/cmake-3.14/Modules/CMakeDetermineSystem.cmake:93 (include)
CMakeLists.txt:4 (project)
-- The C compiler identification is MSVC 19.0.24215.1
-- Check for working C compiler: D:/Program Files (x86)/Microsoft Visual Studio 14.0/VC/bin/amd64/cl.exe
-- Check for working C compiler: D:/Program Files (x86)/Microsoft Visual Studio 14.0/VC/bin/amd64/cl.exe -- broken
CMake Error at H:/ProgramData/CMake/share/cmake-3.14/Modules/CMakeTestCCompiler.cmake:60 (message):
The C compiler
"D:/Program Files (x86)/Microsoft Visual Studio 14.0/VC/bin/amd64/cl.exe"

is not able to compile a simple test program.
It fails with the following output:
Change Dir: H:/ProgramDesign/VCPKG/vcpkg/buildtrees/zlib/x64-windows-rel/CMakeFiles/CMakeTmp

Run Build Command(s):H:/ProgramDesign/VCPKG/vcpkg/downloads/tools/ninja/ninja-1.8.2/ninja.exe cmTC_b7e4c
[1/2] Building C object CMakeFiles\cmTC_b7e4c.dir\testCCompiler.c.obj
[2/2] Linking C executable cmTC_b7e4c.exe
FAILED: cmTC_b7e4c.exe
cmd.exe /C "cd . && H:\ProgramData\CMake\bin\cmake.exe -E vs_link_exe --intdir=CMakeFiles\cmTC_b7e4c.dir --rc=C:\PROGRA~2\WI3CF2~1\10\bin\x64\rc.exe --mt=C:\PROGRA~2\WI3CF2~1\10\bin\x64\mt.exe --manifests  -- D:\PROGRA~1\MICROS~1.0\VC\bin\amd64\link.exe /nologo CMakeFiles\cmTC_b7e4c.dir\testCCompiler.c.obj  /out:cmTC_b7e4c.exe /implib:cmTC_b7e4c.lib /pdb:cmTC_b7e4c.pdb /version:0.0  /machine:x64  /debug /INCREMENTAL /subsystem:console  kernel32.lib user32.lib gdi32.lib winspool.lib shell32.lib ole32.lib oleaut32.lib uuid.lib comdlg32.lib advapi32.lib && cd ."
LINK Pass 1: command "D:\PROGRA~1\MICROS~1.0\VC\bin\amd64\link.exe /nologo CMakeFiles\cmTC_b7e4c.dir\testCCompiler.c.obj /out:cmTC_b7e4c.exe /implib:cmTC_b7e4c.lib /pdb:cmTC_b7e4c.pdb /version:0.0 /machine:x64 /debug /INCREMENTAL /subsystem:console kernel32.lib user32.lib gdi32.lib winspool.lib shell32.lib ole32.lib oleaut32.lib uuid.lib comdlg32.lib advapi32.lib /MANIFEST /MANIFESTFILE:CMakeFiles\cmTC_b7e4c.dir/intermediate.manifest CMakeFiles\cmTC_b7e4c.dir/manifest.res" failed (exit code 1104) with the following output:
LINK : fatal error LNK1104: cannot open file 'ucrtd.lib'
ninja: build stopped: subcommand failed.

CMake will not be able to correctly generate this project.
Call Stack (most recent call first):
CMakeLists.txt:4 (project)
-- Configuring incomplete, errors occurred!
See also "H:/ProgramDesign/VCPKG/vcpkg/buildtrees/zlib/x64-windows-rel/CMakeFiles/CMakeOutput.log".
See also "H:/ProgramDesign/VCPKG/vcpkg/buildtrees/zlib/x64-windows-rel/CMakeFiles/CMakeError.log".
[2/2] cmd /c "cd ../../x64-windows-dbg && "H:/ProgramData/CMake/bin/cmake.exe" "H:/ProgramDesign/VCPKG/vcpkg/buildtrees/zlib/src/1.2.11-f690224aeb" "-DSKIP_INSTALL_FILES=ON" "-DSKIP_BUILD_EXAMPLES=ON" "-DCMAKE_MAKE_PROGRAM=H:/ProgramDesign/VCPKG/vcpkg/downloads/tools/ninja/ninja-1.8.2/ninja.exe" "-DBUILD_SHARED_LIBS=ON" "-DVCPKG_CHAINLOAD_TOOLCHAIN_FILE=H:/ProgramDesign/VCPKG/vcpkg/scripts/toolchains/windows.cmake" "-DVCPKG_TARGET_TRIPLET=x64-windows" "-DVCPKG_PLATFORM_TOOLSET=v140" "-DCMAKE_EXPORT_NO_PACKAGE_REGISTRY=ON" "-DCMAKE_FIND_PACKAGE_NO_PACKAGE_REGISTRY=ON" "-DCMAKE_FIND_PACKAGE_NO_SYSTEM_PACKAGE_REGISTRY=ON" "-DCMAKE_INSTALL_SYSTEM_RUNTIME_LIBS_SKIP=TRUE" "-DCMAKE_VERBOSE_MAKEFILE=ON" "-DVCPKG_APPLOCAL_DEPS=OFF" "-DCMAKE_TOOLCHAIN_FILE=H:/ProgramDesign/VCPKG/vcpkg/scripts/buildsystems/vcpkg.cmake" "-DCMAKE_ERROR_ON_ABSOLUTE_INSTALL_DESTINATION=ON" "-DVCPKG_CXX_FLAGS=" "-DVCPKG_CXX_FLAGS_RELEASE=" "-DVCPKG_CXX_FLAGS_DEBUG=" "-DVCPKG_C_FLAGS=" "-DVCPKG_C_FLAGS_RELEASE=" "-DVCPKG_C_FLAGS_DEBUG=" "-DVCPKG_CRT_LINKAGE=dynamic" "-DVCPKG_LINKER_FLAGS=" "-DCMAKE_INSTALL_LIBDIR:STRING=lib" "-DCMAKE_INSTALL_BINDIR:STRING=bin" "-DSKIP_INSTALL_HEADERS=ON" "-G" "Ninja" "-DCMAKE_BUILD_TYPE=Debug" "-DCMAKE_INSTALL_PREFIX=H:/ProgramDesign/VCPKG/vcpkg/packages/zlib_x64-windows/debug""
FAILED: ../../x64-windows-dbg/CMakeCache.txt
cmd /c "cd ../../x64-windows-dbg && "H:/ProgramData/CMake/bin/cmake.exe" "H:/ProgramDesign/VCPKG/vcpkg/buildtrees/zlib/src/1.2.11-f690224aeb" "-DSKIP_INSTALL_FILES=ON" "-DSKIP_BUILD_EXAMPLES=ON" "-DCMAKE_MAKE_PROGRAM=H:/ProgramDesign/VCPKG/vcpkg/downloads/tools/ninja/ninja-1.8.2/ninja.exe" "-DBUILD_SHARED_LIBS=ON" "-DVCPKG_CHAINLOAD_TOOLCHAIN_FILE=H:/ProgramDesign/VCPKG/vcpkg/scripts/toolchains/windows.cmake" "-DVCPKG_TARGET_TRIPLET=x64-windows" "-DVCPKG_PLATFORM_TOOLSET=v140" "-DCMAKE_EXPORT_NO_PACKAGE_REGISTRY=ON" "-DCMAKE_FIND_PACKAGE_NO_PACKAGE_REGISTRY=ON" "-DCMAKE_FIND_PACKAGE_NO_SYSTEM_PACKAGE_REGISTRY=ON" "-DCMAKE_INSTALL_SYSTEM_RUNTIME_LIBS_SKIP=TRUE" "-DCMAKE_VERBOSE_MAKEFILE=ON" "-DVCPKG_APPLOCAL_DEPS=OFF" "-DCMAKE_TOOLCHAIN_FILE=H:/ProgramDesign/VCPKG/vcpkg/scripts/buildsystems/vcpkg.cmake" "-DCMAKE_ERROR_ON_ABSOLUTE_INSTALL_DESTINATION=ON" "-DVCPKG_CXX_FLAGS=" "-DVCPKG_CXX_FLAGS_RELEASE=" "-DVCPKG_CXX_FLAGS_DEBUG=" "-DVCPKG_C_FLAGS=" "-DVCPKG_C_FLAGS_RELEASE=" "-DVCPKG_C_FLAGS_DEBUG=" "-DVCPKG_CRT_LINKAGE=dynamic" "-DVCPKG_LINKER_FLAGS=" "-DCMAKE_INSTALL_LIBDIR:STRING=lib" "-DCMAKE_INSTALL_BINDIR:STRING=bin" "-DSKIP_INSTALL_HEADERS=ON" "-G" "Ninja" "-DCMAKE_BUILD_TYPE=Debug" "-DCMAKE_INSTALL_PREFIX=H:/ProgramDesign/VCPKG/vcpkg/packages/zlib_x64-windows/debug""
CMake Warning at H:/ProgramDesign/VCPKG/vcpkg/scripts/buildsystems/vcpkg.cmake:107 (message):
There are no libraries installed for the Vcpkg triplet x64-windows.
Call Stack (most recent call first):
H:/ProgramData/CMake/share/cmake-3.14/Modules/CMakeDetermineSystem.cmake:93 (include)
CMakeLists.txt:4 (project)
-- The C compiler identification is MSVC 19.0.24215.1
-- Check for working C compiler: D:/Program Files (x86)/Microsoft Visual Studio 14.0/VC/bin/amd64/cl.exe
-- Check for working C compiler: D:/Program Files (x86)/Microsoft Visual Studio 14.0/VC/bin/amd64/cl.exe -- broken
CMake Error at H:/ProgramData/CMake/share/cmake-3.14/Modules/CMakeTestCCompiler.cmake:60 (message):
The C compiler
"D:/Program Files (x86)/Microsoft Visual Studio 14.0/VC/bin/amd64/cl.exe"

is not able to compile a simple test program.
It fails with the following output:
Change Dir: H:/ProgramDesign/VCPKG/vcpkg/buildtrees/zlib/x64-windows-dbg/CMakeFiles/CMakeTmp

Run Build Command(s):H:/ProgramDesign/VCPKG/vcpkg/downloads/tools/ninja/ninja-1.8.2/ninja.exe cmTC_8c2ed
[1/2] Building C object CMakeFiles\cmTC_8c2ed.dir\testCCompiler.c.obj
[2/2] Linking C executable cmTC_8c2ed.exe
FAILED: cmTC_8c2ed.exe
cmd.exe /C "cd . && H:\ProgramData\CMake\bin\cmake.exe -E vs_link_exe --intdir=CMakeFiles\cmTC_8c2ed.dir --rc=C:\PROGRA~2\WI3CF2~1\10\bin\x64\rc.exe --mt=C:\PROGRA~2\WI3CF2~1\10\bin\x64\mt.exe --manifests  -- D:\PROGRA~1\MICROS~1.0\VC\bin\amd64\link.exe /nologo CMakeFiles\cmTC_8c2ed.dir\testCCompiler.c.obj  /out:cmTC_8c2ed.exe /implib:cmTC_8c2ed.lib /pdb:cmTC_8c2ed.pdb /version:0.0  /machine:x64  /debug /INCREMENTAL /subsystem:console  kernel32.lib user32.lib gdi32.lib winspool.lib shell32.lib ole32.lib oleaut32.lib uuid.lib comdlg32.lib advapi32.lib && cd ."
LINK Pass 1: command "D:\PROGRA~1\MICROS~1.0\VC\bin\amd64\link.exe /nologo CMakeFiles\cmTC_8c2ed.dir\testCCompiler.c.obj /out:cmTC_8c2ed.exe /implib:cmTC_8c2ed.lib /pdb:cmTC_8c2ed.pdb /version:0.0 /machine:x64 /debug /INCREMENTAL /subsystem:console kernel32.lib user32.lib gdi32.lib winspool.lib shell32.lib ole32.lib oleaut32.lib uuid.lib comdlg32.lib advapi32.lib /MANIFEST /MANIFESTFILE:CMakeFiles\cmTC_8c2ed.dir/intermediate.manifest CMakeFiles\cmTC_8c2ed.dir/manifest.res" failed (exit code 1104) with the following output:
LINK : fatal error LNK1104: cannot open file 'ucrtd.lib'
ninja: build stopped: subcommand failed.

CMake will not be able to correctly generate this project.
Call Stack (most recent call first):
CMakeLists.txt:4 (project)
-- Configuring incomplete, errors occurred!
See also "H:/ProgramDesign/VCPKG/vcpkg/buildtrees/zlib/x64-windows-dbg/CMakeFiles/CMakeOutput.log".
See also "H:/ProgramDesign/VCPKG/vcpkg/buildtrees/zlib/x64-windows-dbg/CMakeFiles/CMakeError.log".
ninja: build stopped: subcommand failed.

https://github.com/Microsoft/vcpkg/issues/5854#issuecomment-478252275
full reinstall windows sdk

@FishHe I noticed the V140 tools was set, please ensure you installed C:\Program Files (x86)\Windows Kits\10\Lib\10.0.10240.0.. before run vcpkg install.

I fully reinstalled windows sdk and vcpkg, and it works.....
@LarryIII @Voskrese Thanks~


[wip] lxcfs,pam: disable cgmanager, enable pam_cgfs, lxcfs 2.0.7 -> 2.0.8

Motivation for this change
Deprecation of cgmanager, switch to pam_cgfs, see #30023
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

Marked as work in progress, needs testing on stock NixOS, especially parameters passed to pam_cgfs needs verifying.

I tested this with cgroupv1. I also want to test cgroupv2, when I reboot later.


Playbook for API-First Transformation

A playbook for API-first transformation at scale- Delivery Infrastructure Platform Part 1 - https://medium.com/@jayadebaj/a-playbook-for-api-first-transformation-at-scale-delivery-infrastructure-platform-part-1-6a9176be0057
A playbook for API-first transformation at scale- Delivery Infrastructure Platform Part 2 — https://medium.com/@jayadebaj/a-playbook-for-api-first-transformation-at-scale-delivery-infrastructure-platform-part-2-639bf4f37d7d

API Contract = capability features/operations specifications + non-functional features specifications + metadata
Choosing an Interface Definition Language (IDL) for describing an API Contract
Governance Tools
CI/CD pipeline.
Linter/Validator- The API Linter/Validator runs many rulesets against the API contract IDL files (swagger.json, asyncapi.json, query/mutation.graphql etc.) and reports violations. Examples of rulesets are design standards ruleset(e.g., API styling ruleset, API protocol (HTTP/REST/GraphQL) specific ruleset, authN/authZ ruleset, i18N ruleset, internet standards format ruleset (e.g., RFC 3339), documentation ruleset, API IDL (OpenAPI, AsyncAPI, GraphQL rulesets), business domain & data quality rulesets and compliance rulesets (security, privacy, legal).
The validator should be fully integrated to the CI/CD pipeline and automatically update the maturity assessment validation criteria in Align and Design process.
Code Generator — The code generator compliments the API validator and generates all compliance policies/configurations, service code (functional) and all code/policy/configurations for all non-functional areas (AuthZ, AuthN, Logging, data handling etc.). The code generator also generates API tests (functional, negative/fault injection, security/compliance test cases) and mocks.
Gateways
Depending on the types of APIs (e.g., GraphQL, REST, Events, Websockets) that you are serving, you may even think of separate gateways for each API protocol.
Service Mesh
All the code/configs/policies generated by the code generator for all non-functional/cross-cutting concerns are deployed as part of your sidecar proxy in the service mesh infrastructure. A service mesh is also a very important infrastructure component for reliable service communication and observability.
Data Aggregator
Discovery
DDD


Updated text

:star: PR built and available in a preview environment michaelwallett-mw-demo-pr-1 here


<>-style type assertion represented by JsxElement

🔎 Search Terms
(I did search the open issues and couldn't find anything, but I am also very new to TypeScript, so I might have missed something.)
I was trying to parse an expression like the following using the TypeScript Compiler API:
console.log((<string>"x").length)

Now I was surprised that the ts.CallExpression's arguments contained a single element with kind ParenthesizedExpression. I would have expected a PropertyAccessExpression. So somehow the ParenthesizedExpression here represents the call's argument list, which looks very strange.
Further, when drilling down further, the ParenthesizedExpression in turn contains a JsxElement and when I call getFullText() on that I get the result "<string>"x").length)". This to me looks like a compiler bug of some sort.
In the compiler options I did try to set jsx: ts.JsxEmit.None, but to no avail.
🕗 Version & Regression Information

This changed between versions ______ and _______
This changed in commit or PR _______
This is the behavior in every version I tried, and I reviewed the FAQ for entries about 5.6.2
I was unable to test this on prior versions because _______

I did try version back to 5.3.3.
⏯ Playground Link
https://ts-ast-viewer.com/#code/MYewdgziA2CmB00QHMAUqA8EAuAnAlmMgHwBEAHqQJSKxHYAWVQA
💻 Code
// Your code here

🙁 Actual behavior
I tried for the longest time to reproduce a minimal example, but I failed. But the TypeScript AST Viewer shows the exact same behavior as I see it:

🙂 Expected behavior
Instead of that ParenthesizedExpression with a JsxElement I am expecting a PropertyAccessExpression with a nested ParenthesizedExpression and then inside there a TypeAssertionExpression.
Additional information about the issue
No response

I think I just figured it out. I think I had the wrong "script kind" set in my compiler options. Sorry about the noise.


Provide Spanish translation of FAQ

You rock! Thanks for this.

Live at: https://lib.reviews/faq?uselang=es


New spkl task to register plugin steps and custom workflow activities from same assembly

This is PR to functionality looked after on issue #366. This PR adds new command pluginandworkflows to spkl.exe. This command simultaneously registers and updates plugin steps and custom workflow activities present on same assembly into CDS. Previously you haven't been able to do this.
If command line argument /e introduced is PR #302 is present then only assembly is updated and registration information of steps and activities is left intact on CDS. I updated also workflow task to use /e flag because otherwise it would've behaved differently from other two registration tasks. I made this change because I felt it was honouring the intent of #302 which was to speed up updates of large assemblies when there were changes only to assembly and not in registrations.

I'm wondering - the issue is that when updating plugins, the workflow registrations are removed (and visa versa) - perhaps the simplest would be to simply filter on the isworkflowactivity attribute of the PluginTypes - this way we can only remove 'orphaned' registrations if they match the type being registered?
I'm thinking this because it would then avoid having this 'hybrid' task.
Thoughts?

You mean that you've first registered both plugins and workflows with this new task and then you change task to different one (plugins or workflows)? On this case other half of the registrations will disappear and that's one reason why I think this kind of task is needed. Also updating plugins and workflows in one go would be great. Currently manual operation with pluginregistrationtool is required to achieve that.

I thought this a bit more. I would like to have possibility to registet assembly and everything in it in one go. This would speed up the process as you would upload assembly only once. This would also reduce possibility of not updating something as you would not have to know you need to run two separate commands. If I got you Scott correctly you want at least that existing plugin and workflow tasks wouldn't delete activities or steps respectively?


Add causal product incrementality analysis with multivariate interrupted time series models

This PR will add new functionality to pymc-marketing. Namely it will allow causal analysis of product incrementality/cannibalization.
In this initial PR we will focus on:
a) adding docs to introduce the idea behind incrementality/cannibalization analysis
b) in terms of modeling we will start with a multivariate interrupted time series model. This will include a notebook to illustrate its use, as well as docs in the guide section to convey the basic workings.
Later PR's will add additional modeling options, such as nested discrete choice models.
TODO

[X] Finish "Introduction to product incrementality" docs page
[x] Finish MV-ITS model explanation
[x] Add tests
[x] Finish how-to notebook demonstrating use

[X] Add module code
[x] Add Scenario 3 where we operate on product level data
[x] Add scenario where market is not saturated + update relevant docs + tests

[ ] Add a QuickStart on the Getting Started docs page
[ ] Rename module to consumer-choice. Update docs and imports and re-run notebooks etc.
[ ] Fix typo "isoluate" -> "isolate"

Known limitations
At the moment the MVITS model is very simple. It only has an intercept term, embodying the assumption that sales are relatively static over time. Clearly there are many ways to expand this model, so the proposal is that we get this in as a first attempt and stepwise add features over time. We can be lead by feature requests (if there are any), but this establishes an MVP which can be built upon.
Checklist

[ ] Checked that the pre-commit linting/style checks pass
[ ] Included tests that prove the fix is effective or that the new feature works
[ ] Added necessary documentation (docstrings and/or example notebooks)
[ ] If you are a pro: each commit corresponds to a relevant logical change

Modules affected
This PR will create a new module and will not affect the MMM or CLV modules.
Type of change

[X] New feature / enhancement
[ ] Bug fix
[ ] Documentation
[ ] Maintenance
[ ] Other (please specify):

📚 Documentation preview 📚: https://pymc-marketing--803.org.readthedocs.build/en/803/

Thanks for the comments @juanitorduz + @wd60622. I'll get on those soon. Should be able to mark as ready for review soon.

Failing test FAILED tests/test_prior.py::test_constrain is nothing to do with me ;)

I'm not 100% sure why the code coverage is failing. I've got integration tests in there, so assumed that would do a good enough job 🤷🏻♂

Tagging @aseyboldt in case you want to browse the docs https://pymc-marketing--803.org.readthedocs.build/en/803/ and see if there are any refinements that could be made.

Note to self... Use test_model_builder.py to guide the mission of making the MVITS class inherit from ModelBuilder. In that file is a test class with the minimum set of abstract methods implemented. It also has tests, and I'll need to add such tests.

Can you add an item to the PULL_REQUEST_TEMPLATE.md for this module

Fantastic work @wd60622 ! 🚀 ! Let's push this one to the finish line and cut a release :D !

Fantastic work @wd60622 ! 🚀 ! Let's push this one to the finish line and cut a release :D !

Just a note of caution on merging this - we only really get one chance to release this as a new module, and I think the framing of the new module is important. At the moment all the guide and how-to docs are all framed as product incrementality. But there should be some discussion of whether this is the best thing. For example, it could be more pithy and punch if we called it something like an uplift module. Though some have proposed something like sales analytics - though that might be too broad because MMM could fall under that banner.
I'll try to engage people again in the Labs discord to try to reach a consensus.

I now officially don't like the term product incrementality. But please add your thoughts to some of the suggestions I've dropped into Discord.

I am having a bug with the predictions in the model. They seem to be overwriting the posterior_predictive group. This can be seen in the charts that have the plot_fit being the same as the plots from the plot_counterfactual method calls.
Here is a basic example:
from pymc_marketing.product_incrementality import MVITS

So just flagging up that in the change over to using ModelBuilder, the results have changed. In the mv_its_saturated.ipynb the first trace plot used to look like this:

But now looks like this:

Maybe just a change in the priors, but the results we have before "made sense".

Made changes in the saturated notebook. Would have to add some comments as well.
Need to make changes to other one as well. I will be afk for bit so feel free to take a stab @drbenvincent

That last commit was a bit of a big one.

changed the package name from product_incrementality to cc
ran make uml and added new images into CONTRIBUTING.md

Not sure why the streamlit tag was auto added to this PR

Getting crazy mypy errors in the pre-commit. Pushed the last one with --no-verify because it's late on a Friday and it seems unrelated to what I did adding the plot_total_sales kwarg 😅

All looks really clean @drbenvincent Nice work!
I will take a look later and can do those edits to docstrings, tests, etc when I get the chance

@wd60622 All tests pass again now - aside from code coverage. Am I right in understanding that you might do some work on this PR? I probably need to put this aside until late next week until things free up a bit.

Nice. Yes, I take a look today

@drbenvincent what is the plan for this PR?

I think it's very close to done. Would appreciate a review on any of the 'packaging' aspects and docs etc

@drbenvincent I will have the time to look into this one during this end-of-the-year break 🙏 . it would be great to have it merged by January for our next release ... let's see :)

I will create some issues for next iterations

The pre-commit error will be fixed after we merge https://github.com/pymc-labs/pymc-marketing/pull/1313

great work @drbenvincent ! Let's keep working on iterations

Great stuff. Thanks for all the review comments. I'm happy to write a social media post when the next release comes out, explaining that this is a minimal viable product which is in line for some improvements.
I'm pretty much unable to do any work until Jan 6th though.

Sure! No rush! I thing is actually to post about it even in mid or late January! Enjoy your time off !


Remove version: bornova.numara version 3.6.6

[Automated] It returns code over 400 in all urls
Microsoft Reviewers: Open in CodeFlow

URL: https://github.com/bornova/numara-calculator/releases/download/v3.6.6/Numara-3.6.6.exe
Response Error: The remote server returned an error: (404) Not Found.
(Automated message - build 910)


matrix inverse & transpose

It'd be really handy to bring in GLSL ES 3.0's inverse & transpose functions, they're very useful.
(btw, thanks for publishing this, I'm experimenting with swapping the vector math in my game out with this and results so far are promising)

@shakesoda totally agree :), I'll add those in pretty soon, likely at some point next week (I'll add outerProduct and determinant too). If you get to inverse and transpose before me I'm happy to accept a PR for them
Super keen to hear how you get on with the swap

sounds great, and things are behaving well with the library swap. performance and memory usage are comparable (now that I've worked out the remaining bugs, mostly from minor differences in behavior, such as normalize not guarding against 0 and copying instead of operating in place).
I ended up adding a sanity checked normalize for my own convenience, but that's about all. I tried out the f32 flag and my hl/jit build crashes - haven't run an hl/c build yet, but I think it was recently fixed in the jit and I just need to update.
@:overload(function(v: Float): Float {})
@:overload(function(v: Vec2): Vec2 {})
@:overload(function(v: Vec3): Vec3 {})
@:overload(function(v: Vec4): Vec4 {})
macro function checked_normalize(v) return useCurrentPos(
	switch mapVecType(v) {
		case 1: macro $v == 0 ? 0.0 : 1.0;
		default: macro {
			final len2: Float = $v.dot($v);
			len2 == 0 ? $v.clone() : $v / Math.sqrt(len2);
		}
	}
);

here's debug stage working:

Your game looks awesome! What are you using for rendering out of interest?
The spec doesn't explicitly set the behavior for normalizing a zero vector but after some testing it seems like returning 0.0 is a common implementation and sensible enough so I've made this the default (https://github.com/haxiomic/vector-math/commit/62b0591a0f8281c007825c4de53a03d2a7099b8c)
Not sure what's causing the crash on hl – I ran the tests with hl + vector-math-f32 and it seemed happy, curious to hear if you get to the bottom of it!

Thanks! I'm currently rendering with OpenGL 4.3. I want to do some internal redesigns and maybe move it to Vulkan, but that's for another day.
Checking the normalize will prevent a lot of headaches, and thanks for checking out the hl issue - I think it was hl issue 411 and/or 412, I'll update and try again. It's a minor hassle to do that on my end since I've got local patches (hl 244, wasn't merged) to the modules, so I've been putting that off.

Any progress in inverse. :)

here's one if you need it now
function mat4_inverse(m: Mat4): Mat4 {
	final a00 = m[0][0];
	final a01 = m[0][1];
	final a02 = m[0][2];
	final a03 = m[0][3];

	final a10 = m[1][0];
	final a11 = m[1][1];
	final a12 = m[1][2];
	final a13 = m[1][3];

	final a20 = m[2][0];
	final a21 = m[2][1];
	final a22 = m[2][2];
	final a23 = m[2][3];

	final a30 = m[3][0];
	final a31 = m[3][1];
	final a32 = m[3][2];
	final a33 = m[3][3];

	final b00 = a00 * a11 - a01 * a10;
	final b01 = a00 * a12 - a02 * a10;
	final b02 = a00 * a13 - a03 * a10;
	final b03 = a01 * a12 - a02 * a11;
	final b04 = a01 * a13 - a03 * a11;
	final b05 = a02 * a13 - a03 * a12;
	final b06 = a20 * a31 - a21 * a30;
	final b07 = a20 * a32 - a22 * a30;
	final b08 = a20 * a33 - a23 * a30;
	final b09 = a21 * a32 - a22 * a31;
	final b10 = a21 * a33 - a23 * a31;
	final b11 = a22 * a33 - a23 * a32;

	final det = 1.0 / (b00 * b11 - b01 * b10 + b02 * b09 + b03 * b08 - b04 * b07 + b05 * b06);

	return mat4(
		(a11 * b11 - a12 * b10 + a13 * b09) * det,
		(a02 * b10 - a01 * b11 - a03 * b09) * det,
		(a31 * b05 - a32 * b04 + a33 * b03) * det,
		(a22 * b04 - a21 * b05 - a23 * b03) * det,
		(a12 * b08 - a10 * b11 - a13 * b07) * det,
		(a00 * b11 - a02 * b08 + a03 * b07) * det,
		(a32 * b02 - a30 * b05 - a33 * b01) * det,
		(a20 * b05 - a22 * b02 + a23 * b01) * det,
		(a10 * b10 - a11 * b08 + a13 * b06) * det,
		(a01 * b08 - a00 * b10 - a03 * b06) * det,
		(a30 * b04 - a31 * b02 + a33 * b00) * det,
		(a21 * b02 - a20 * b04 - a23 * b00) * det,
		(a11 * b07 - a10 * b09 - a12 * b06) * det,
		(a00 * b09 - a01 * b07 + a02 * b06) * det,
		(a31 * b01 - a30 * b03 - a32 * b00) * det,
		(a20 * b03 - a21 * b01 + a22 * b00) * det
	);
}

Just added new methods transpose, determinant, inverse and adjoint along with validation tests and published 1.5.0 to haxelib (used glMatrix as a reference)


How do I check Docker CLI version included PR or not.

Now I am trying to use Compose On Kubernetes on GKE with as follows.

Important: You will need a custom build of Docker CLI to deploy stacks onto GKE. The build must include this PR which has been merged onto the master branch.

But I'm not sure convinced the right Docker CLI version of local machine.
How Do I check it.
Thank you for the developer Team.

Unless you build and use your own docker/cli, this PR will be shipped only in the next docker/cli release 19.03 (which will be pretty soon). All previous releases (last one is 18.09) are not compatible with GKE.

I will now close this issue, hopping my previous comment has enough informations to answer the question. Feel free to re-open the issue if you think I'm wrong 👍

@silvin-lubecki
Thank you very much.
Should I add this information to document(install-on-gke.md) by PR ?
OR does it not need as 19.03 will ship soon ?

I think it's not needed as the release will be in few days 👍


compile and test to support python 3.6 and upload to anaconda.org/

Hopefully this will be done in the next few weeks.

It would be great if you could look at the conda-forge feedstock too.
I've tried to get it to work in this PR, but failed.

any updates on python3.6 support?

Hopefully soon.

Everyone, last release nb_conda 2.2.0 is already built and available in conda-forge including py3.6 support.
Closing now.

Btw, conda packages from defaults channel will be available soon.


Occamy on FPGA - "axi_flat.svh" header file is missing on the repo

Thank you for your proving us Occamy source code.
I tried to create Occamy FPGA code, based on your Occamy instruction on the repo.
--> make occamy_vcu128
The following error message will be reported.
ERROR: [Synth 8-1766] cannot open include file axi_flat.svh [/home/nam/codeSim/project/snitch/hw/system/occamy/src/occamy_xilinx.sv:9]
ERROR: [Synth 8-2841] use of undefined macro AXI_FLATTEN_MASTER [/home/nam/codeSim/project/snitch/hw/system/occamy/src/occamy_xilinx.sv:525]
I think "occamy_xilinx.sv" must include "axi_flat.svh" header file.
But, we can't find the header file on the Github repo.
I think uploading of the header file was missed.
It would be very grateful to you if you upload "axi_flat.svh" header file on this repo.
Thank you.
Seungseok

Fixed in #436


vagrant setup is broken

Trying to do vagrant up and it fails on an npm install command for the ui (permissions issue, will post exact error a little later).  However, I make the following change and this gets around the issue:
diff --git a/provisioning/roles/sp_mini_5_build_ui/tasks/main.yml b/provisioning/roles/sp_mini_5_build_ui/tasks/main.yml
index 1dd0bd2..3f079aa 100644
--- a/provisioning/roles/sp_mini_5_build_ui/tasks/main.yml
+++ b/provisioning/roles/sp_mini_5_build_ui/tasks/main.yml
@@ -2,10 +2,8 @@
 - include_vars: ../../common_vars.yml

 - name: Install npm packages based on package.json.
-  become: yes
   npm:
     path: "{{playbook_dir}}/resources/ui"

 - name: Create dist files
-  become: yes
   shell: "cd {{playbook_dir}}/resources/ui; tsc -p js --outDir dist/ && browserify dist/SnowplowMiniApp.js -o dist/bundle.js && uglifyjs dist/bundle.js > dist/snowplow-mini.js"

Hi @davidsiefert , thanks for the notice. I haven't encountered this so far but I'll investigate and get back.

Odd, I stashed my changes and reran vagrant up 2x already... magically working.

In my experience this can sometimes happen with npm and the Vagrantfile NFS option:
https://github.com/snowplow/snowplow-mini/blob/master/Vagrantfile#L7-L9
The option greatly speeds up the filesystem but can cause issues when writing files to the shared directory sometimes.

thanks @jbeemster , closing


TypeError: Cannot read property 'lookup' of undefined

I believe this is related to a regression in Ember 2.13.0-beta, but I thought I'd file an issue in order to track it. We are getting an error in href-to here: https://github.com/intercom/ember-href-to/blob/master/addon/helpers/href-to.js#L6 when testing:
const $result = Ember.$(`<div>${helper.compute([ event ])}</div>`);
assert.equal($result.text(), 'Version 511 was activated', 'full text');

Where our helper simply calls hrefTo:
hrefTo('configure.service.version', version)

The fix to this was to change the aforementioned like 6 in href-to.js to:
const container = getOwner(context) || context.container;
let router = container.lookup('router:main');

which was recommended in a similar issue in the torii project, here: https://github.com/Vestorly/torii/issues/349#issuecomment-302141236

Related to: https://github.com/emberjs/ember.js/issues/15492

anyone have a reproduction or specific Safari versions/platforms?


Unable to save model for Tensorflowjs using tfjs.converterjs

I am using the Tensorflow hub for importing the Imagenet, but after retaining my data, I wanted to save the model for the TensorFlow Js, I am using
tfjs.converters.save_keras_model(model, path1)
I am not able to save the model for my TensorFlow's, I am getting the error
RuntimeError: Unable to create a link (name already exists)
I need to save only in the format supported by TensorFlowJs

@Gautamshahi,
This issue is not related to TF Hub but it is related to TF JS. Request you to raise an issue in TFJS Repository. Thanks!


Revert to older TE version

Revert to older TE version. We're seeing some issues with flash-attn mismatch.

Force merging after approval from @dakinggg


Clarify what all sources are supported for Terraform Dependency Updates

Code of Conduct

[X] I have read and agree to the GitHub Docs project's Code of Conduct

What article on docs.github.com is affected?
https://docs.github.com/en/code-security/dependabot/dependabot-version-updates/configuration-options-for-the-dependabot.yml-file
What part(s) of the article would you like to see updated?
Background Information
Unlike other package managers, Terraform is a multi-sourcetype package managers with private registry support (that only applies to a few of these source types).
The following are various sample combinations of what all counts as a "module source" in Terraform:

No
Source
Sample Source
Is this a Terraform Registry
Private Access Supported
Update Possible

1
Local Path
../consul
NA
No

2
Terraform Registry
hashicorp/consul/aws
Yes, https://registry.terraform.io/
No
Yes

3
Terraform Private Registry
app.terraform.io/example-corp/k8s-cluster/azurerm
Yes
Yes
Yes

4
GitHub
github.com/hashicorp/example
No
Yes
Yes

5
GitHub (SSH)
git@github.com:hashicorp/example.git
No
Yes
Yes

6
BitBucket
bitbucket.org/hashicorp/terraform-consul-aws
No
Yes
Yes

7
Generic Git
git::https://example.com/vpc.git (Other Valid Git URLs also work)
No
Yes
Yes

8
Generic Mercurial
hg::http://example.com/vpc.hg
No
Yes
Yes

9
HTTP URls
https://example.com/terraform-source
No
Yes
No

10
S3 Bucket URL
s3::https://s3-eu-west-1.amazonaws.com/examplecorp-terraform-modules/vpc.zip
No
Yes
No

11
GCS Bucket URL
gcs::https://www.googleapis.com/storage/v1/modules/foomodule.zip
No
Yes
No

Current Documentation Status
The following is all of the text* that is present on the docs website about Dependabot Terraform setups:
The table tells us that Terraform integration supports both Private Repositories and Private registries (and not vendoring):

The second page tells us about terraform registry configuration.

The terraform-registry type supports a token.

registries:
  terraform-example:
    type: terraform-registry
    url: https://terraform.example.com
    token: ${{secrets.MY_TERRAFORM_API_TOKEN}}

Unanswered Questions
There are 7 different kinds of sources in the above table that support updates. Of these, 2 are well documented (Terraform Registry / Terraform Private Registry) with clear documentation on how it supports Private registries as well.
The other 5 are left very unclear, across each of their public/private variant (so 10 possibilities).
The core change in #30139:

You can give Dependabot access to private package registries hosted by GitLab or Bitbucket by specifying a type of git.

does not clarify if this works with Terraform. It is unclear if Mercurial repositories are updated.
Suggested Change
Similar to how swift in the table links to a clear indication of what is supported, a similar section should be added for Terraform. Something like:

Only modules hosted on Terraform Registry or a publicly reachable Git repository are supported. Private Terraform Registry is supported, and you can configure access for private git repositories by configuring a git registry.

Additional information
This is a re-opening of #8419. The relevant PR #30139 does not answer the important questions.

@captn3m0 Thank you for your suggestions to improve GitHub Docs! I will get this triaged for review ✨

@captn3m0 Thank you for your suggestions to improve GitHub Docs! I will get this triaged for review ✨

Hi @nguyenalex836. This issue was raised in #8419 and solved with pull request #30139

Thank you for the heads up, @CBID2! ✨
@captn3m0 Would you be able to clarify how you think the pull request #30139 doesn't answer the important questions you are referring to?

I've mentioned that above:

The core change in https://github.com/github/docs/pull/30139 :

You can give Dependabot access to private package registries hosted by GitLab or Bitbucket by specifying a type of git.

does not clarify if this works with Terraform. It is unclear if Mercurial repositories (hosted on bitbucket or elsewhere) are updated.

For discovery, this isn't listed under the terraform section, does not show up anywhere Terraform appears. It shows up under the "Private Registry" section, which is something I wouldn't look up if my source happens to be a public mercurial/git repository. The change is about "access" to the source itself - dependabot being able to access my source does not guarantee that dependabot will be able to correctly update it as well.
Further, the "supported sources" is still not clearly documented. You can piece together enough information after reading across 3 different pages that Git and Terraform registries are supported, but it does not tell a reader whether S3/GCS buckets or other sources might be supported. As a terraform user who might rely on a S3 source, I don't know if dependabot will update it.

@captn3m0 Thank you for the thorough reply! Our writers will review your response ✨

@captn3m0 👋 - thanks for the comprehensive context and explanation. Let me see what we can do to improve these docs ✨

I agree that the docs are lacking information wrt Terraform support, and will create an internal issue for us to tackle this.

Closing this in favor of the internal issue I've just created. I think this is probably a bit too complex for an external contributor to work on, especially if they are not familiar with Dependabot and Terraform.

@captn3m0 (and any one else interested) - we've updated the docs as per your findings and suggestions: https://docs.github.com/en/code-security/dependabot/dependabot-version-updates/configuration-options-for-the-dependabot.yml-file#terraform
Thanks for helping us improve our docs ✨


Fixed a typo.

In -> It

@lextm,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by .NET Foundation. We will now review your pull request.
Thanks,
.NET Foundation Pull Request Bot

@lextm  Thanks


Style/AlignHash error when using EnforcedColonStyle: table

Config
Style/AlignHash:
  EnforcedColonStyle: table

Source
def foo(**kw)
  new(
    a: 1,
    **kw
  )
end

Reproduction
$ cat rubocop.yml
Style/AlignHash:
  EnforcedColonStyle: table

$ cat ex.rb
def foo(**kw)
  new(
    a: 1,
    **kw
  )
end

$ rubocop -V
0.47.0 (using Parser <IP_ADDRESS>, running on ruby 2.4.0 x86_64-darwin16)

$ rubocop -c rubocop.yml ex.rb -d
configuration from /dev/project/rubocop.yml
Default configuration from /Users/johnbackus/.gem/ruby/2.4.0/gems/rubocop-0.47.0/config/default.yml
Inheriting configuration from /Users/johnbackus/.gem/ruby/2.4.0/gems/rubocop-0.47.0/config/enabled.yml
Inheriting configuration from /Users/johnbackus/.gem/ruby/2.4.0/gems/rubocop-0.47.0/config/disabled.yml
Inspecting 1 file
Scanning /dev/project/ex.rb
An error occurred while Style/AlignHash cop was inspecting /dev/project/ex.rb:3:4.
undefined method `delimiter' for "s(:kwsplat,\n  s(:lvar, :kw))":RuboCop::AST::KeywordSplatNode
Did you mean?  delimiter_delta
/Users/johnbackus/.gem/ruby/2.4.0/gems/rubocop-0.47.0/lib/rubocop/cop/mixin/hash_alignment.rb:84:in `value_delta'
/Users/johnbackus/.gem/ruby/2.4.0/gems/rubocop-0.47.0/lib/rubocop/cop/mixin/hash_alignment.rb:36:in `deltas'
/Users/johnbackus/.gem/ruby/2.4.0/gems/rubocop-0.47.0/lib/rubocop/cop/style/align_hash.rb:143:in `block in check_pairs'
/Users/johnbackus/.gem/ruby/2.4.0/gems/rubocop-0.47.0/lib/rubocop/cop/style/align_hash.rb:141:in `each'
/Users/johnbackus/.gem/ruby/2.4.0/gems/rubocop-0.47.0/lib/rubocop/cop/style/align_hash.rb:141:in `check_pairs'
/Users/johnbackus/.gem/ruby/2.4.0/gems/rubocop-0.47.0/lib/rubocop/cop/style/align_hash.rb:124:in `on_hash'
/Users/johnbackus/.gem/ruby/2.4.0/gems/rubocop-0.47.0/lib/rubocop/cop/commissioner.rb:43:in `block (2 levels) in on_hash'
/Users/johnbackus/.gem/ruby/2.4.0/gems/rubocop-0.47.0/lib/rubocop/cop/commissioner.rb:102:in `with_cop_error_handling'
/Users/johnbackus/.gem/ruby/2.4.0/gems/rubocop-0.47.0/lib/rubocop/cop/commissioner.rb:42:in `block in on_hash'
/Users/johnbackus/.gem/ruby/2.4.0/gems/rubocop-0.47.0/lib/rubocop/cop/commissioner.rb:41:in `each'
/Users/johnbackus/.gem/ruby/2.4.0/gems/rubocop-0.47.0/lib/rubocop/cop/commissioner.rb:41:in `on_hash'
/Users/johnbackus/.gem/ruby/2.4.0/gems/rubocop-0.47.0/lib/rubocop/ast/traversal.rb:101:in `block in on_send'
/Users/johnbackus/.gem/ruby/2.4.0/gems/rubocop-0.47.0/lib/rubocop/ast/traversal.rb:99:in `each'
/Users/johnbackus/.gem/ruby/2.4.0/gems/rubocop-0.47.0/lib/rubocop/ast/traversal.rb:99:in `each_with_index'
/Users/johnbackus/.gem/ruby/2.4.0/gems/rubocop-0.47.0/lib/rubocop/ast/traversal.rb:99:in `on_send'
/Users/johnbackus/.gem/ruby/2.4.0/gems/rubocop-0.47.0/lib/rubocop/cop/commissioner.rb:47:in `on_send'
/Users/johnbackus/.gem/ruby/2.4.0/gems/rubocop-0.47.0/lib/rubocop/ast/traversal.rb:95:in `on_def'
/Users/johnbackus/.gem/ruby/2.4.0/gems/rubocop-0.47.0/lib/rubocop/cop/commissioner.rb:47:in `on_def'
/Users/johnbackus/.gem/ruby/2.4.0/gems/rubocop-0.47.0/lib/rubocop/ast/traversal.rb:12:in `walk'
/Users/johnbackus/.gem/ruby/2.4.0/gems/rubocop-0.47.0/lib/rubocop/cop/commissioner.rb:60:in `investigate'
/Users/johnbackus/.gem/ruby/2.4.0/gems/rubocop-0.47.0/lib/rubocop/cop/team.rb:121:in `investigate'
/Users/johnbackus/.gem/ruby/2.4.0/gems/rubocop-0.47.0/lib/rubocop/cop/team.rb:109:in `offenses'
/Users/johnbackus/.gem/ruby/2.4.0/gems/rubocop-0.47.0/lib/rubocop/cop/team.rb:51:in `inspect_file'
/Users/johnbackus/.gem/ruby/2.4.0/gems/rubocop-0.47.0/lib/rubocop/runner.rb:248:in `inspect_file'
/Users/johnbackus/.gem/ruby/2.4.0/gems/rubocop-0.47.0/lib/rubocop/runner.rb:195:in `block in do_inspection_loop'
/Users/johnbackus/.gem/ruby/2.4.0/gems/rubocop-0.47.0/lib/rubocop/runner.rb:227:in `block in iterate_until_no_changes'
/Users/johnbackus/.gem/ruby/2.4.0/gems/rubocop-0.47.0/lib/rubocop/runner.rb:220:in `loop'
/Users/johnbackus/.gem/ruby/2.4.0/gems/rubocop-0.47.0/lib/rubocop/runner.rb:220:in `iterate_until_no_changes'
/Users/johnbackus/.gem/ruby/2.4.0/gems/rubocop-0.47.0/lib/rubocop/runner.rb:191:in `do_inspection_loop'
/Users/johnbackus/.gem/ruby/2.4.0/gems/rubocop-0.47.0/lib/rubocop/runner.rb:101:in `block in file_offenses'
/Users/johnbackus/.gem/ruby/2.4.0/gems/rubocop-0.47.0/lib/rubocop/runner.rb:111:in `file_offense_cache'
/Users/johnbackus/.gem/ruby/2.4.0/gems/rubocop-0.47.0/lib/rubocop/runner.rb:99:in `file_offenses'
/Users/johnbackus/.gem/ruby/2.4.0/gems/rubocop-0.47.0/lib/rubocop/runner.rb:90:in `process_file'
/Users/johnbackus/.gem/ruby/2.4.0/gems/rubocop-0.47.0/lib/rubocop/runner.rb:68:in `block in each_inspected_file'
/Users/johnbackus/.gem/ruby/2.4.0/gems/rubocop-0.47.0/lib/rubocop/runner.rb:65:in `each'
/Users/johnbackus/.gem/ruby/2.4.0/gems/rubocop-0.47.0/lib/rubocop/runner.rb:65:in `reduce'
/Users/johnbackus/.gem/ruby/2.4.0/gems/rubocop-0.47.0/lib/rubocop/runner.rb:65:in `each_inspected_file'
/Users/johnbackus/.gem/ruby/2.4.0/gems/rubocop-0.47.0/lib/rubocop/runner.rb:57:in `inspect_files'
/Users/johnbackus/.gem/ruby/2.4.0/gems/rubocop-0.47.0/lib/rubocop/runner.rb:36:in `run'
/Users/johnbackus/.gem/ruby/2.4.0/gems/rubocop-0.47.0/lib/rubocop/cli.rb:72:in `execute_runner'
/Users/johnbackus/.gem/ruby/2.4.0/gems/rubocop-0.47.0/lib/rubocop/cli.rb:27:in `run'
/Users/johnbackus/.gem/ruby/2.4.0/gems/rubocop-0.47.0/bin/rubocop:13:in `block in <top (required)>'
/Users/johnbackus/.rubies/ruby-2.4.0/lib/ruby/2.4.0/benchmark.rb:308:in `realtime'
/Users/johnbackus/.gem/ruby/2.4.0/gems/rubocop-0.47.0/bin/rubocop:12:in `<top (required)>'
/Users/johnbackus/.gem/ruby/2.4.0/bin/rubocop:22:in `load'
/Users/johnbackus/.gem/ruby/2.4.0/bin/rubocop:22:in `<main>'
C

Offenses:

ex.rb:1:1: C: Style/FrozenStringLiteralComment: Missing frozen string literal comment.
def foo(**kw)
^

1 file inspected, 1 offense detected

1 error occurred:
An error occurred while Style/AlignHash cop was inspecting /dev/project/ex.rb:3:4.
Errors are usually caused by RuboCop bugs.
Please, report your problems to RuboCop's issue tracker.
Mention the following information in the issue report:
0.47.0 (using Parser <IP_ADDRESS>, running on ruby 2.4.0 x86_64-darwin16)
Finished in 0.14244399999734014 seconds

Thanks @backus! Will look into it. 😀

@backus: Found a specific set of conditions that weren't covered by tests. 😞 I just opened a bugfix PR.


Plans to support Java Records (Java-14)?

Quoting from a StackOverflow Q&A , the current version 2.3.8 doesn't seem to support java record classes.
The minimal code sample used to test this (quoting the link)
public record UserDto(String firstName,
                      String lastName,
                      String email,
                      String imageUrl) {}

 User post = modelMapper.map(userDto, User.class);

Records must be instantiated through their constructor.  In the preview as of Java 14, the usual Unsafe tricks may work, but these will stop working before records become a permanent feature.  Frameworks will need to examine a class to see if it is a record (Class::isRecord) and if so, find the canonical constructor (guaranteed to be there) through reflection.

Reference: https://github.com/youribonnaffe/jackson-databind/commit/072189b72509ebc8abc1c0feee93d6ad393f8d90

Bump. Any updates on this as a supported feature?

What about now? I miss this in my current project.

Any updates on current status or plans to support this please?

There is no update on this issue.
ModelMapper can easily support Record -> POJO by implementing ValueReader.
But it's tricky to support POJO/Record -> Record, because the record is an immutable class, and ModelMapper is not supporting constructor based destination.
I can implement Record -> POJO  but leaving POJO/Record -> Record  unimplemented, I don't have any plan to support constructor based destination.
mapstruct might be an option for you if it blocks you. Sorry for the inconvenience.

@chhsiao90
Hi, I just implemented Record -> POJO for my local app.
Do you have any plan to support Record -> POJO ?
If I can add class for Record -> POJO, I am thinking to make Pull Request for adding the feature.
maybe adding class org.modelmapper.internal.valueaccess.RecordValueReader
The implemented codes are below.
import org.modelmapper.internal.Errors;
import org.modelmapper.spi.ValueReader;

import java.lang.reflect.Field;
import java.util.ArrayList;
import java.util.Collection;
import java.util.List;

public class RecordValueReader implements ValueReader<Record> {
    @Override
    public Object get(Record record, String memberName) {
        Field field = matchField(record, memberName);
        if (field != null) {
            try {
                return field.get(record);
            } catch (IllegalAccessException e) {
                throw new Errors().addMessage(e, "Cannot get the member").toMappingException();
            }
        }
        return null;
    }

    @Override
    public Member<Record> getMember(Record record, String memberName) {
        Field field = matchField(record, memberName);
        Class<?> type = field != null ? field.getClass() : Record.class;
        return new Member<>(type) {
            @Override
            public Object get(Record source, String memberName) {
                return RecordValueReader.this.get(source, memberName);
            }
        };
    }

    @Override
    public Collection<String> memberNames(Record record) {
        Field[] fields = record.getClass().getDeclaredFields();
        List<String> memberNames = new ArrayList<>(fields.length);
        for (Field field : fields) {
            field.setAccessible(true);
            memberNames.add(field.getName());
        }
        return memberNames;
    }

    private Field matchField(Record source, String memberName) {
        for (Field field : source.getClass().getDeclaredFields()) {
            field.setAccessible(true);
            if (memberName.equalsIgnoreCase(field.getName()))
                return field;
        }
        return null;
    }
}

are there any updates on supporting records?

Are there any updates on supporting records?

Are there updates?

Any update?

made PR supporting Record -> POJO
https://github.com/modelmapper/modelmapper/pull/715

Any update on this? Thanks!

for Record -> POJO, use this repository.
https://github.com/modelmapper/modelmapper-module-record

Hello,
Any recommandations for POJO-> Record ?
I am getting back :
Ensure that MYRECORD has a non-private no-argument constructor.
Caused by: java.lang.NoSuchMethodException: MYRECORD .()
at java.base/java.lang.Class.getConstructor0(Class.java:3585)
1 error
at org.modelmapper.internal.Errors.throwMappingExceptionIfErrorsExist(Errors.java:386)
at org.modelmapper.internal.MappingEngineImpl.map(MappingEngineImpl.java:80)
at org.modelmapper.ModelMapper.mapInternal(ModelMapper.java:589)
at org.modelmapper.ModelMapper.map(ModelMapper.java:422)

这是来自QQ邮箱的假期自动回复邮件。

您好，我最近正在休假中，无法亲自回复您的邮件。我将在假期结束后，尽快给您回复。

Still a huge need!

for Record -> POJO, use this repository. https://github.com/modelmapper/modelmapper-module-record

Unfortunately it doesn't work. Please, look at https://github.com/modelmapper/modelmapper-module-record/issues/1

Any update?


Create a download status monitor

Create data model for tracking the status of downloads
Create daemon that will monitor each downloader & update the status of downloads
Update dashboard to display current status

This is now complete.


fix shrx, shlx, sarx, rorx

All had the same off by 1 in addressing operands.
ref:

https://www.felixcloutier.com/x86/sarx:shlx:shrx
https://www.felixcloutier.com/x86/rorx

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Added with https://github.com/Vector35/binaryninja-api/commit/34bd2341f9fb8d5e8bc57639cb0ec547c3b8596b and on 4.3.6491-dev.
Thank you!


Expand Selection less useful on XML

Given this XML file
<?xml version="1.0" encoding="utf-8"?>
<odoo>
  <data>
    <menuitem id="estate_menu_root" name="Real Estate">
      <menuitem id="estate_menu_first_level" name="Advertisements">
        <!-- CURSOR HERE --> <menuitem id="estate_model_menu_action" action="estate_action"/>
      </menuitem>

      <menuitem id="estate_type_menu_first_level" name="Settings">
        <menuitem id="estate_type_model_menu_action" action="estate_type_action"/>
        <menuitem id="estate_tags_model_menu_action" action="estate_tags_action"/>
      </menuitem>
    </menuitem>
  </data>
</odoo>

If my cursor is where it says <!-- CURSOR HERE -->, and I trigger an Expand Selection command, I expect to select just the line where the cursor is. Then expand to the immediate surrounding tag. Then the next tag, etc.
However, in reality, what happens is, it selects the entire document from top to bottom. That's not very useful.
Is that the intended behavior?

This issue lacks

mentioning of extensions that provide these results or the lack of therefore

Hi @jrieken. This issue is about the built-in smart select feature in VSCode. No extension needed.

I know but that feature only comes with a default, best-effort solution and needs extension support to really shine.

Closing this as extension-candidate

@jrieken Sorry, I don't understand. The Smart Select feature works great in React's JSX files. Does it work so well there because of some extension? Does that mean I have to look for some extension that enhances Smart Select for XML files?

Yes - that's what it means

@jrieken You're right. I installed XML language support and now it works much better. Thanks for your time!


[backport] Fix typo in note

Backport of #3012

[automatic post] Jenkins, test this please.

Jenkins CI test (for commit 38354b7a7637cf1adf488ea921e9f3e55c52a6c3, target branch v7) succeeded!


load a warc archive without a cdx file

this code effectively loads the CDX index, and gets the warc pages if needed.
val rdd: RDD[WarcRecord] = ArchiveSpark.load(sc, WarcCdxHdfsSpec("/data/example.cdx.gz", "/data"))
I see that definition of ArchiveSpark.load(sc: SparkContext, spec: DataSpec[Raw, Parsed]): RDD[Parsed], and I see that there are several implementations of DataSpec, but all the Warc one require a CDX file.
Is it possible to load a warc archive without a CDX file? how?

Hi David,
ArchiveSpark's efficiency comes through its two-step loading approach. It first loads the metadata from CDX, which is lightweight and fast, you can then apply filters to it, or group, or sort it, etc., and only then, when you call enrich, it will integrate the actual data from the WARC files. If you directly work with WARCs it would be much slower, as it needs to load parse every single record, even if you don't need it for you analysis and will filter it out. That's the core concept of ArchiveSpark.
However, in the coming version there will be a DataSpec to load raw WARCs in two different formats. The main purpose of this is to generate CDX files though.

Ok, thx!
I see that you have different DataSpec implementation, but I don't see an explanation about them.
To use a file from s3n, can I simply use WarcCdxHdfsSpec and pass string like this s3n://commoncrawl/crawl-data/CC-MAIN-2016-36/segments/1471982290442.1/warc/?

The WarcCdxHdfsSpec uses Hadoop's filesystem classes, I am not sure if they support s3n, if so this should work, but you always need CDX as well.

This is possible now, please read https://github.com/helgeho/ArchiveSpark/blob/master/docs/DataSpecs.md for an overview of available DataSpecs.
A concrete example loading WARCs without CDX is available here:
https://github.com/helgeho/ArchiveSpark/blob/master/notebooks/Generate_CDX.ipynb


How to ignore one image?

Or just set the best quality compress (png) just for a specific file.

Docs changed.  See https://gruntjs.com/configuring-tasks#globbing-patterns


Zoom limit on iOS

Attach (recommended) or Link to PDF file here:
zoom test.pdf
Configuration:

Web browser and its version: Safari 12
Operating system and its version: ipadOS 13.1.2
PDF.js version: 2.1.266
Is a browser extension: no

Steps to reproduce the problem:

Open attached file in Safari on an iPad running ipadOS 13 in the pdfjs demo viewer https://mozilla.github.io/pdf.js/web/viewer.html
click zoom + button to zoom into 220%.
The file is no longer displayed instead all white is shown. If a Safari inspector is attached it will write "Canvas area exceeds the maximum limit (width * height > 16777216)." in the console.

What is the expected behavior? (add screenshot) : to be able to zoom more than 200%
What went wrong? (add screenshot): white is shown instead of the content of the file.
Link to a viewer (if hosted on a site other than mozilla.github.io/pdf.js or as Firefox/Chrome extension): https://mozilla.github.io/pdf.js/web/viewer.html
It seems that the zoom limit is different for different files. Is there a way to calculate what it is at runtime each file so I avoid showing white instead of the file without having to set a very low zoom limit on iOS devices?

The file is no longer displayed instead all white is shown. If a Safari inspector is attached it will write "Canvas area exceeds the maximum limit (width * height > 16777216)." in the console.

That's quite strange, since the maximum canvas size should be limited to a much smaller value on mobile platforms; see https://github.com/mozilla/pdf.js/blob/16ae7c6960c1296370c1600312f283a68e82b137/web/viewer_compatibility.js#L23-L29

Then I guess I know what the problem is: Apple have made Safari on ipadOS 13 "a desktop class browser" which means that it reports EXACTLY the same navigator.userAgent string as Safari on MacOS reports => isIOS() returns false. According to https://stackoverflow.com/questions/57765958/how-to-detect-ipad-and-ipad-os-version-in-ios-13-and-up the only way currently to distinguish between Safari 13 on Mac and ipadOS is to test for navigator.maxTouchPoints > 1.

Apple have made Safari on ipadOS 13 "a desktop class browser" which means that it reports EXACTLY the same navigator.userAgent string as Safari on MacOS reports => isIOS() returns false.

That seems kind of, for lack of a better word, stupid to me; but obviously that's part of the problem is not something we can fix...
Anyway, can you please check if preview build in PR #11246 is enough to work-around this issue?

I can only agree!

I can only agree.
The build at http://<IP_ADDRESS>:8877/65321f96da43bee/web/viewer.html works on my ipad pro running ipadOS 13.1.2.
When will this fix be available in a build of the npm library?

When will this fix be available in a build of the npm library?

Considering that it's neither approved nor landed yet, that's probably anyone's guess at this point :-)
Furthermore, this really doesn't seem anywhere near serious enough to warrant a new release right away.
Given that the default viewer (purposely) isn't shipping via npm, I'd assume that you're using the viewer components in some way. In that case, note that the PDFViewer constructor already accepts a custom maxCanvasPixels value; see https://github.com/mozilla/pdf.js/blob/16ae7c6960c1296370c1600312f283a68e82b137/web/base_viewer.js#L33-L66 hence you can already "fix" this yourself, in your implementation, until such a time that the PR lands!

The fix is now merged and will be in the next release, but it's not yet known when that is going to be made. For now it's best to set maxCanvasPixels yourself like in the comment above.

I am running into the same issue. I tried to change maxCanvasPixels to 5242880. If I change it to a very low number eg 1000 it does work, but but obviously you can not read anything :) I am using ng2-pdf-viewer (https://github.com/VadimDez/ng2-pdf-viewer/issues/492)


BAU: disable the Rails IP spoofing check

It can cause errors but gives no benefit. From Rails release notes:
"The fact that Rails checks for IP spoofing can be a nuisance for sites that do heavy traffic with cell phones, because their proxies don't generally set things up right."
In our case, we think it’s some misconfiguration at the Welsh Assembly causing errors in the frontend.
Solo: @hugh-emerson

Hmm - this seems like it might be of value? @jakubmiarka @rachelthecodesmith  - does this make any sense?

Hugh said it was something he saw while yakking, so might be worth merging.


Adding dashboards-security-plugin to 1.3 manifest

Signed-off-by: Dave Lago<EMAIL_ADDRESS>Description
Adding dashboards security plugin to the 1.3 Dashboards manifest
Issues Resolved
N/A
Check List

[x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Codecov Report

Merging #1614 (346c53e) into main (de56d0f) will decrease coverage by 0.13%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #1614      +/-   ##
============================================
- Coverage     94.67%   94.54%   -0.14%
============================================
  Files           163      132      -31
  Lines          3435     3279     -156
  Branches         21        0      -21
============================================
- Hits           3252     3100     -152
+ Misses          180      179       -1
+ Partials          3        0       -3

Impacted Files
Coverage Δ

src/system/temporary_directory.py
83.87% <0.00%> (-12.91%)
:arrow_down:

src/system/os.py
92.30% <0.00%> (-7.70%)
:arrow_down:

src/jenkins/InputManifest.groovy

src/jenkins/BuildManifest.groovy

tests/jenkins/jobs/PublishNotification_Jenkinsfile

src/jenkins/Messages.groovy

tests/jenkins/jobs/DownloadFromS3_Jenkinsfile

...rtifacts_actions_OpenSearch_Dashboards_Jenkinsfile

deployment/lib/build-artifact-stack.ts

tests/jenkins/jobs/BuildDockerImage_Jenkinsfile

... and 23 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de56d0f...346c53e. Read the comment docs.

@davidlago If other plugins are 1.3.0 on main, don't hesitate to add them :)


Map BIOS stage-4 at lower address to avoid conflicts with the kernel

Parts of stage-4 need to be identity-mapped. This can lead to 'page already mapped' errors when the kernel already occupies the virtual address corresponding to the physical address of the stage-4. For example, a typical virtual start address of the kernel is 2MiB. This was where we placed the stage-4 in physical memory before. This commit avoids that conflict by keeping the stage-4 below the 2MiB boundary.
Fixes #331

@an-owl Could you try whether this fixes #331 for you?

Thanks that works


Basic functionality for logstore interface

This provides the backend for expose the server logs from two different logstore implementation:

Static logfiles
A ElasticSearch instance

The API and the LogStore interface only exposes a query method that expect the parameters from the UI (PR TBD) and returns a list of POJO representing each entry found on the configured LogStore implementation.
The configuration for each LogStore implementation has to be added to the brooklyn.cfg file:
For ElasticSearch:
brooklyn.logbook.logStore = org.apache.brooklyn.util.core.logbook.opensearch.OpenSearchLogStore
brooklyn.logbook.openSearchLogStore.host = https://localhost:9200
brooklyn.logbook.openSearchLogStore.index = brooklyn
brooklyn.logbook.openSearchLogStore.user = admin
brooklyn.logbook.openSearchLogStore.password = admin
brooklyn.logbook.openSearchLogStore.verifySSl = false

For the plain log file:
brooklyn.logbook.logStore = org.apache.brooklyn.util.core.logbook.file.FileLogStore
brooklyn.logbook.fileLogStore.path = /var/logs/brooklyn/brooklyn.debug.log

There are some pending tasks to be implemented:

[ ] Add more unit test
[ ] Improve the plain log implementation
[ ] Add "tail" behaviour to keep updating the ui with new entries

Looks ok in general. Some JavaDocs would be really appreciated.

This looks great @jcabrerizo .  Super work on hard stuff.  And really nice to have!  One important thing, as part of startup it looks like API resource classes get added in three places; in addition to rest/rest-resources/src/main/resources/OSGI-INF/blueprint/service.xml there are:
rest/rest-resources/src/main/java/org/apache/brooklyn/rest/BrooklynRestApi.java
rest/rest-server/src/main/webapp/WEB-INF/web.xml

Would be nice to simplify that but easiest thing for now probably to be safe and consistent, add this LogbookResource in those places.
If you're busy I can do that.  But if you have the chance to do this, and add one comment (on datetime) to answer my question.

@ahgittin I added the resources to the required files


[SPARK-24240] Add a config to control whether InMemoryFileIndex should update cache when refresh.

What changes were proposed in this pull request?
In current code(https://github.com/apache/spark/blob/master/sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/InsertIntoHadoopFsRelationCommand.scala#L172), after data is inserted, spark will always refresh file index and update the cache. If the target table has tons of files, job will suffer time and OOM issue. Could we add a config to control whether InMemoryFileIndex should update cache when refresh.
How was this patch tested?
To be added

Test build #90447 has started for PR 21289 at commit b49665d.

cc @cloud-fan @gengliangwang @adrian-ionescu
Do you have any thoughts?
Please take a look when you have time, thanks !

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/3099/
Test PASSed.

Test build #90447 has finished for PR 21289 at commit b49665d.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/90447/
Test PASSed.

I just took a quick look... Do I understand correctly that your flag basically controls whether the refresh is eager (true, current behavior) vs lazy (false)? If so, let's rename the flag accordingly.
Also, with lazy mode we just delay file listing from immediately after an append operation until the next Spark job involving that table, right? It doesn't seem like we gain much overall..
What's the general use-case that motivated you to make this change? Please explain that more clearly in the PR description. Also, let's add a test that verifies the intended behavior.

@cloud-fan @adrian-ionescu
Thanks for looking into this !
The issue is that when I append into a table with sql below:
insert into X select ....

It always refresh the file index of table X in memory, though I don't query X after this job. From this point, the refresh is not necessary and costs much time and memory.
In this pr, I proposes to mark the file index as 'outdated', and postpone the refresh until next query of the file index.

I mean the memory refresh always happen after writing data, which I think is not necessary ?

Fair enough. Actually I think that's how CatalogFileIndex works. So, for consistency, we might even want to consider making this the default.
Please add a test, though, and improve the PR description.

@cloud-fan  @adrian-ionescu
I added a test, please check when you have time.

Test build #90637 has started for PR 21289 at commit 5cabfd6.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/3228/
Test PASSed.

Test build #90637 has finished for PR 21289 at commit 5cabfd6.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/90637/
Test PASSed.

Build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/5886/
Test PASSed.


proof: add magic bytes to individual proofs and proof files

Fixes https://github.com/lightninglabs/taproot-assets/issues/402.

Postgres itest failed in CI, I've re-run.

Postgres itest failed in CI, I've re-run.
EDIT: and it's failed again with:
2023-09-07 13:08:59.719 [INF] TADB: Connecting to Postgres fixture: ***localhost:32828/test?sslmode=disable

Yeah, the postgres itest failure is really weird. It looks like the process is just killed after some time. Sounds like an issue with the GitHub environment. Maybe we're using too much memory? I'll try to investigate. Here's something I found: https://github.com/Lightning-Universe/lightning-bolts/issues/409


DRAFT: Add Cere type bundle.

Changes were applied in this PR https://github.com/Cerebellum-Network/explorer/pull/86


PR for #1394 custom error type for client/da-availability

Here is my first draft for the custom error handling in the client/data-availability crate. (#1394)
I propose to use a DaError struct which is composed of a DaLayer and a custom DaLayerError type which encompasses several types of error (blob related, client related or config related).
I implemented it for the avail DA as an example (and will do it for Celestia and Ethereum after some feedback)

Please add the labels corresponding to the type of changes your PR introduces:

Feature

Does this introduce a breaking change?
I don't think so

Ok, so if I understand correctly, I can remove the DALayer type attribute and then use even more customized error types ?

It's a bit complicated to use the original error types, for instance FailedWsConnection can be linked with an anyhow::Error and a subxt::error::Error, should I use a more general Error type ?

anyhow::Error is already a wrapper around any error type
You can use it to avoid creating new intermediate enum error

I factorized the error types as much as possible and re-used a known error type when possible

I just removed the String (it created an error in crates/node/src/service.rs which I adapted accordingly even though this part of the code has been deleted since then)

should be good now

@peyha still some conflicts

@peyha you should use rebase rather than merge in this type of situation

wanted to use rebase to keep the branch clean but merged by error, shall i change something ?

wanted to use rebase to keep the branch clean but merged by error, shall i change something ?

No, we will squash all commits anyway that's fine

@peyha more conflicts sorry

Now rpc tests are not passing anymore

Now rpc tests are not passing anymore

It's already the case in main, not you bad

It's already the case in main, not you bad

Saw that every PR was failing shortly after sending my message
Hopefully first and not last PR merged on the repo :rocket: ready to take any related (or not) issue now that I am more familiar with the project
(and #1394 can be closed)


google search need enter a CAPTCHA

prompt message:Our systems have detected unusual traffic from your computer network.

This is a common issue when you tunnel through a VPS. The VPS provider may have many other users doing the same thing, which makes Google believe there is something unusual.

This occurs when v2ray::freedom connects to google from an IPv6 IP address.
Suggest adding an option to only use ipv4 in the freedom protocol.

The reason is All VPS from one provider are created with one IPv6 address, which is acquired by Stateless Address Autoconfiguration (SLAAC), and browers may use ipv6 address as first priority, so google may consider huge hit from one IPV6 address  is very suspicious,  I just request additional staic IPV6 pool from VPS porvider, and add one of static IPV6 addr then fix it. I still have my IPV6 address but not lease from SLAAC.  if you won't need IPV6, you can simply swtich off the IPV6 in your server, it also help solve this issues

/etc/gai.conf  add this
precedence ::ffff:0:0/96 100


Checksum validation for Ethereum address

Package version eg. v8, v9:
v10
Issue, Question, or Enhancement:
Enhancement
I was reading the codebase and I came across this comment from 2018-04-08:
https://github.com/go-playground/validator/blob/ea924ce89a4774b8017143b34b946db46add9df1/baked_in.go#L530
Following the link, I found out that it has been implemented since 2018-05-04: https://github.com/golang/crypto/pull/41#issuecomment-386774251
As it is now possible to implement the checksum validation for Ethereum address, I went ahead and implemented it: https://github.com/go-playground/validator/pull/630
Please let me know if I missed anything

Since merge of #630 I think we can close that issue.

Okay, closing this as fixed.


Chage to monorepo

せっかくなのでものレポに変更してみました！

This pull request includes several significant changes to the project structure and configuration, primarily focusing on the frontend build process and project organization. The most important changes include modifying build commands, updating the package.json file, and adding a new .gitignore file for the frontend package.
Build and Configuration Updates:

.github/workflows/ci.yml: Changed the build command from yarn build to yarn frontend build to align with the new project structure.
README.md: Updated the documentation to reflect the new build and development commands (yarn frontend build and yarn frontend dev).

Project Structure and Dependencies:

package.json: Renamed the project to airdrop_quest, updated the version to 1.0.0, added repository information, author, and license, and restructured scripts to use workspaces. Removed old dependencies and devDependencies.
pkgs/frontend/.gitignore: Added a new .gitignore file for the frontend package to ignore various files and directories such as node_modules, .next, and environment files.
pkgs/frontend/package.json: Created a new package.json for the frontend package with necessary dependencies and devDependencies, aligning with the new project structure.


Downloading from Internal Repo using Token

Following from here, I'm getting a 404 error when trying to access a file on an Internal repo here on github.
Not sure if it matters, but the repo I'm trying to access is an institutional account with single-sign-on (SSO), so maybe this complicates things.
task as follows (actual project names changed):
task downloadModelFileRobot(type: Download) {
    preemptiveAuth true
    username System.getenv("GITHUB_USER")
    password System.getenv("GITHUB_TOKEN")
    src 'https://github.com/foo/bar'
    dest project.ext.ASSET_DIR + '/bar'
    overwrite false
}

I've verified that the token is still valid, and the env vars are accessible from the current terminal.
I updated to 5.3.1 as requested and reran the build with the preemptiveAuth true. No error from the addition of the preemptiveAuth true, but still getting the same 404 error. I managed to find the HTTP request/response this time around though:
2023-03-13T16:50:03.639+0900 [DEBUG] [de.undercouch.gradle.tasks.download.internal.DebugInterceptor] Sending request:
> GET /foo/bar/blob/master/model.tflite
> Accept-Encoding: gzip, x-gzip, deflate
> Host: github.com
> Connection: keep-alive
> User-Agent: Apache-HttpClient/5.1.3 (Java/1.8.0_322)
> Authorization: Basic <redacted token/hash>

2023-03-13T16:50:03.893+0900 [DEBUG] [de.undercouch.gradle.tasks.download.internal.DebugInterceptor] Received response:
< HTTP/1.1 404 Not Found
< Server: GitHub.com
< Date: Mon, 13 Mar 2023 07:50:03 GMT
< Content-Type: text/html; charset=utf-8
< Transfer-Encoding: chunked
< Vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame
< Cache-Control: no-cache
< Set-Cookie: _octo=GH1.1.1647069296.1678693803; domain=github.com; path=/; expires=Wed, 13 Mar 2024 07:50:03 GMT; secure; SameSite=Lax
< Set-Cookie: _gh_sess=<redacted token/hash>; path=/; secure; HttpOnly; SameSite=Lax
< Strict-Transport-Security: max-age=31536000; includeSubdomains; preload
< X-Frame-Options: deny
< X-Content-Type-Options: nosniff
< X-XSS-Protection: 0
< Referrer-Policy: origin-when-cross-origin, strict-origin-when-cross-origin
< Content-Security-Policy: default-src 'none'; base-uri 'self'; block-all-mixed-content; child-src github.com/assets-cdn/worker/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com objects-origin.githubusercontent.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com cdn.optimizely.com logx.optimizely.com/v1/events *.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ wss://*.actions.githubusercontent.com online.visualstudio.com/api/v1/locations github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com objects-origin.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; worker-src github.com/assets-cdn/worker/ gist.github.com/assets-cdn/worker/
< Vary: Accept-Encoding, Accept, X-Requested-With
< Content-Encoding: gzip
< X-GitHub-Request-Id: CBE4:14D6:74022D:98E1BF:640ED5AB

The HTTP request and response look correct. Either the repository/path does not exist or your credentials are incorrect.
I don't know if you're using your personal credentials, but you may try to use a GitHub access token instead. This usually helps, for example if you've enabled 2FA.

The unredacted version of the file /foo/bar/blob/master/model.tflite is accessible via firefox (after single sign on 2FA), so I know the path exists. Also these line:
    username System.getenv("GITHUB_USER")
    password System.getenv("GITHUB_TOKEN")

are making use of GitHub access tokens. The GITHUB_TOKEN here is an environmental variable that stores such a token. The token has been verified to not be expired, and verified to work with the following command:
curl -v -H "Authorization: token $GITHUB_TOKEN" -o model.tflite -L https://github.com/foo/bar/blob/master/model.tflite
By "work" above, I mean that it successfully downloads model.tflite using the same GitHub access token used by gradle.

A few things that might be of interest from the curl output:
* Connected to github.com (<IP_ADDRESS>) port 443 (#0)
* ALPN, offering h2
* ALPN, offering http/1.1
*  CAfile: /etc/ssl/certs/ca-certificates.crt
*  CApath: /etc/ssl/certs
* TLSv1.0 (OUT), TLS header, Certificate Status (22):
} [5 bytes data]

...

* SSL connection using TLSv1.3 / TLS_AES_128_GCM_SHA256
* ALPN, server accepted to use h2
* Server certificate:
*  subject: C=US; ST=California; L=San Francisco; O=GitHub, Inc.; CN=github.com
*  start date: Feb 14 00:00:00 2023 GMT
*  expire date: Mar 14 23:59:59 2024 GMT
*  subjectAltName: host "github.com" matched cert's "github.com"
*  issuer: C=US; O=DigiCert Inc; CN=DigiCert TLS Hybrid ECC SHA384 2020 CA1
*  SSL certificate verify ok.
* Using HTTP2, server supports multiplexing
* Connection state changed (HTTP/2 confirmed)
* Copying HTTP/2 data in stream buffer to connection buffer after upgrade: len=0
* TLSv1.2 (OUT), TLS header, Supplemental data (23):
} [5 bytes data]

...

* TLSv1.2 (OUT), TLS header, Supplemental data (23):
} [5 bytes data]
* Using Stream ID: 1 (easy handle 0x55c127b9bb60)
* TLSv1.2 (OUT), TLS header, Supplemental data (23):
} [5 bytes data]
> GET /foo/bar/blob/master/model.tflite HTTP/2
> Host: github.com
> user-agent: curl/7.81.0
> accept: */*
> authorization: token <redacted Token>
>

Not sure if it is relevant as I know very little about network security, but does gradle-download-task support this ca-certificate lookup, SSL, HTTP2, and TLSv1.2?

I see. The difference is that curl is using authorization: token ... instead of authorization: basic .... You've used the -H parameter to set the HTTP header accordingly (-H "Authorization: token $GITHUB_TOKEN"). Just do the same with gradle-download-task and you should be good to go:
task downloadModelFileRobot(type: Download) {
    header 'Authorization', 'token ' + System.getenv("GITHUB_TOKEN")
    src 'https://github.com/foo/bar'
    dest project.ext.ASSET_DIR + '/bar'
    overwrite false
}

Thanks for your ongoing support. I tried, and it still gave me the 404 error, but looking back at the curl results, it appears that also did not work (the contents of the file were simply "Not Found" rather than the actual binary). I should have verified that, sorry.
It appears this is not an issue with gradle-download-task so much as how GitHub is handling serving release assets in private/internal repos (from what I can tell). As a test, I did the following:

Upload the identical model.tflite file to a public repo as a part of a release. This is just a sandbox repo (so source code is completely unreleated)
Try to curl this public asset with: curl -o model.tflite -L https://github.com/topherbuckley/mavenTest/releases/download/0.1.1/model.tflite (this works as expected)
Try to curl the zipped source file from the Internal repo with curl -o tmp -H "Authorization: token $GITHUB_TOKEN" -L https://github.com/foo/bar/archive/refs/tags/0.1.1.zip. This also works
Try to curl the model.tflite file with idential syntax: curl -o model.tflite -H "Authorization: token $GITHUB_TOKEN" -L https://github.com/foo/bar/releases/download/0.1.1/model.tflite This changes the contents of the local model.tflite to "Not Found".
I can use the same link: https://github.com/foo/bar/releases/download/0.1.1/model.tflite in firefox, and it downloads just fine.

You can close this issue now (as I don't think this is specifically related to gradle-download-task) unless you are interested to follow my progress on this as it pertains to the use of gradle-download-task later.

If you are curious, [this] discusses this issue more detail, though I haven't found a place discussing this generalized to github, as the link above is a project discussion that is running into the same issue.
Essentially, I need to use the GitHub rest API to find an asset_id, then I can create a url to download that asset. I see no way of grabbing this asset_id other than using the rest API. Copying the syntax from a post within the link:
curl -v -L -H 'Accept: application/octet-stream' -H 'Authorization: token $GITHUB_TOKEN' https://api.github.com/repos/:owner/:repo/releases/assets/:asset_id
You can find this asset_id via: curl -L -H "Accept: application/vnd.github+json"   -H "Authorization: token $GITHUB_TOKEN"  -H "X-GitHub-Api-Version: 2022-11-28"   https://api.github.com/repos/<owner>/<repo>/releases/<release_id>/assets
And to get the release_id you need:
curl -L -H "Accept: application/vnd.github+json"   -H "Authorization: token $GITHUB_TOKEN"  -H "X-GitHub-Api-Version: 2022-11-28"   https://api.github.com/repos/<owner>/<repo>/releases
This is all per the GitHub rest API
At this point, it might be easier to just use the GitHub cli to downloaded these. Maybe you can come up with a more elegant solution to incorporate into gradle-download-task, or just wait on the GitHub team to make this easier.

Finally got something to work. I'm not a groovy or gradle guru by any means, so if you have tips for touching it up, I'm glad to hear them
def String getAssetID(String token, String owner, String repo, String tag_name, String asset_name){
    def jsonFile = new ByteArrayOutputStream()
    String path = "https://api.github.com/repos/${owner}/${repo}/releases".toString()
    def asset_info
    def asset_id
    exec {
        commandLine 'curl', '-L', '-H', 'Accept: application/vnd.github+json', '-H', "Authorization: token $token", '-H', 'X-GitHub-Api-Version: 2022-11-28', path

        standardOutput = jsonFile
    }
    def jsonContent = new JsonSlurper().parseText(jsonFile.toString())
    def release_info = null
    for (def obj : jsonContent) {
        if (obj.tag_name == tag_name) {
            release_info = obj
            def assets
            if (release_info != null) {
                assets = release_info.assets
//                    println("assets: $assets")
                if (assets != null) {
                    for (def asset : assets) {
                        if (asset.name == asset_name) {
                            asset_info = asset
                            println("found asset $asset_name")
                            break
                        }
                    }
                    if (asset_info != null){
                        asset_id = asset_info.id
                        println("asset_id: " + asset_id)
                        return asset_id
                    }else {
                        println "Asset with $asset_name not found"
                    }
                } else {
                    println "Release with tag $tag_name has no assets"
                }
            } else {
                println "Release with tag $tag_name not found"
            }
            break
        }
    }
}

task downloadModelFileRobot(type: Download) {
    doFirst{
        String token = System.getenv("GITHUB_TOKEN")
        String owner = 'foo'
        String repo = 'bar'
        String tag_name="0.1.1"
        String asset_name = "model.tflite"
        String asset_id = getAssetID(token, owner, repo, tag_name, asset_name)
        println("asset_id: " + asset_id)
        header 'Authorization', 'token ' + System.getenv("GITHUB_TOKEN")
        src "https://api.github.com/repos/$owner/$repo/releases/assets/$asset_id"
        dest project.ext.ASSET_DIR + '/model.tflite'
        overwrite false
    }
}

Looks good to me. Thanks for the feedback.
As for the tips: If you like, you may replace the call to curl with new URL(...).openConnection() and use setRequestProperty() to set the authentication header (see here for an example in Groovy: https://stackoverflow.com/questions/25692515/groovy-built-in-rest-http-client)
Can we close the ticket now?

Yep, sorry for the spamming comments on this. Hope it helps someone else in the future though. :) Thanks for your helps as well!


Add abstraction for operator installs + add param for flink operator bundle image

/packit test --labels smoke


Taj/1976 user search extension

Moved ExtensionsManager from react-sdk/ModuleRunner to here.
Added extension to augment user-directory/search REST calls. Note that to work, this PR must be accompanied by a change to matrix-js-sdk to make client.searchUserDirectory() accept extra arguments.

Target branch for this PR should be verji-main.


Window not responding to closes at times

Sometimes when running the application and attempting to close it via the X, the window does not respond and will not close. It appears that the delegate at line 147 of gl_window.d (As of commit https://github.com/jython234/mango-engine/commit/1c4e905332a8761ad63032b5e43c0425cdbf1ad1 on branch new-structure) is not being called. This is strange as the delegate is supposedly executed in the main thread.

Fixed as of commit https://github.com/jython234/mango-engine/commit/c3e014de89bab60f5203495b69976febab9882e3.