Update to Icon SVG Handling created Accessibility regression

Expected Behaviour
Icons should contain some form of alt text for the image tag.
Actual Behaviour
No alt text exists, and thus Accessibility issue is raised on PSI check.
Reproduce Scenario (including but not limited to)
Steps to Reproduce
Load any demo page. Here is a PSI check of a page with multiple icon references.

Do we consider it solved with https://github.com/adobe/aem-lib/pull/26 ?


Error in configuration file

@awvwgk,
this error appears with cmake:
``
CMake Error at CMakeLists.txt:33 (math):
math cannot parse the expression: " * 10000
+ * 100
+": syntax error, unexpected exp_TIMES (2).

--
cmake version 3.16.3
ninja version 1.10.0
Fortran compiler 9.3.0

Can you share which version of NLopt you are using? Does this one come with a CMake config file?

Can you share which version of NLopt you are using? Does this one come with a CMake config file?

@awvwgk ,
I forgot that information in the previous comment
nlopt version 2.6.2
I am now checking if it is a localization problem of the nlopt libraries.

I find the description of the proposal interesting, will your tblite library be embedded in xtb?

This error would happen if CMake can find NLopt
https://github.com/grimme-lab/nlopt-f/blob/37a418f0f0f96c7ca109ce8083454327bc197068/CMakeLists.txt#L29-L31
but the config file does not set the NLopt_VERSION_* variables as promised by the CMake documentation.
Not sure how I should solve this, one option would write a custom finder which can guarantee that the variables are set. This might be preferable because than we can also use pkg-config to find older NLopt versions build with autotools.
Or CMake didn't find NLopt because I forgot to add the REQUIRED to the finder. Could you attach the full configuration output?

Yes, this is the ultimate plan for the tblite library, to provide one place for a reference implementation of the xTB Hamiltonian, which is usable for everybody who doesn't want to implement the Hamiltonians themselves. Using it in xtb is planned for version 6.5.0, but I have no concrete time when this will happen.

Or CMake didn't find NLopt because I forgot to add the REQUIRED to the finder

Now nlopt-f installation via CMake is ok.
--
I tried some simple examples for configuration files, CMakeList, but an error for locating the libraries persists.
Maybe I forgot something
  Target "main" links to target "nlopt-f::nlopt::wrap" but the target was not   found.  Perhaps a find_package() call is missing for an IMPORTED target, or   an ALIAS target is missing?
CMakeLists.txt

Sorry, I thought you were seeing an error when building NLopt rather than building a project against the wrapper. This is a typo in the README, it should use the target nlopt-f::nlopt-f instead. Will fix this in #8.
For finding the project robustly downstream I recommend to use a find module. You can adapt the one for test-drive here and have your project add it to the CMAKE_MODULE_PATH:
https://github.com/grimme-lab/nlopt-f/blob/main/config/cmake/Findtest-drive.cmake
I don't include it in the README because it is a lot of CMake boilerplate code.

This is a typo in the README, it should use the target nlopt-f::nlopt-f instead. Will fix this in #8.

For my simple configuration file, CMakeLists.txt, #8 works!
--
I will use a find module

Thanks for testing. Getting CMake projects working as dependencies is... tricky.
Will close this as resolved.


I want ask a question?

Sorry because i dont understand the code and I need your help ! I have two question

The first question: I understand that the score and aug_score is the tour length. But went i test it with my own dataset, i change the scale so the ans is different. So i want to ask that the train scale and test scale must be the same ?
The second question: I know that max_pomo_reward.max(dim=0) is the best tour and I dont know how to get it, and I know self.env.slected_node_list is the tour but how i can get it from the best tour ?
TKS!!

yes. the scales should be the same.
"max" function returns a namedtuple (values, indices). Use the indices to extract the good tour from the selected_node_list.


Combining templated razor delegates and partials

Consider the attached files. The razor slice Test.cshtml passes in a templated razor delegate to another razor slice Partial.cshtml:

@(await RenderPartialAsync(MyProject.Slices._Partial.Create<Func<dynamic, object>>(@hello!)))

However, compilation fails with:

1>obj\Debug\net9.0\generated\Microsoft.CodeAnalysis.Razor.Compiler\Microsoft.NET.Sdk.Razor.SourceGenerators.RazorSourceGenerator\Slices_Test_cshtml.g.cs(79,17,79,27): error CS0103: The name 'PushWriter' does not exist in the current context
1>obj\Debug\net9.0\generated\Microsoft.CodeAnalysis.Razor.Compiler\Microsoft.NET.Sdk.Razor.SourceGenerators.RazorSourceGenerator\Slices_Test_cshtml.g.cs(81,17,81,26): error CS0103: The name 'PopWriter' does not exist in the current context

Not sure if this is out of scope for Razor Slices, but since each feature is supported individually, the ability to compose them would be nice to have.
Slices.zip

Note that you can work around this as follows:

@(await RenderPartialAsync(MyProject.Slices._Partial.Create<Func<dynamic, object>>(_ => new HtmlString("hello!"))))

Would be nice to be able to use the more concise templated delegate syntax though.

My guess is this is due to how the Razor compiler lowers templated Razor delegates as arguments in the compiled output. IIRC the PushWriter and PopWriter methods are used to dynamically change the TextWriter being used as the output stream in MVC Razor views, but Razor Slices isn't natively TextWriter based, but rather is PipeWriter based.
I need to investigate the code-gen of this scenario more carefully to figure out if there's a good way to support this or not. Can you share the full content of the generated Slices_Test_cshtml.g.cs file, along with the CS of the class generated for your .cshtml file in a regular MVC project from the Razor compiler itself (you can extract it from your application assembly using a tool like ILSpy).

Here's the template for Index.cshtml:
@{
    Func<dynamic, object> tmpl = @hello!;
}
<!DOCTYPE html>

    <title></title>

@await Html.PartialAsync("_Partial", tmpl, null)

Here's _Partial.cshml:
<button>
    Snippet: @Model(default(dynamic))
</button>

Here's the ILSpy decompiled code for Index.cshtml, which does push/pop a TextWriter, as you suspected:
// RSTest, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=null
// AspNetCoreGeneratedDocument.Views_Home_Index
using System;
using System.IO;
using System.Runtime.CompilerServices;
using System.Threading.Tasks;
using Microsoft.AspNetCore.Html;
using Microsoft.AspNetCore.Mvc;
using Microsoft.AspNetCore.Mvc.Razor;
using Microsoft.AspNetCore.Mvc.Razor.Internal;
using Microsoft.AspNetCore.Mvc.Razor.TagHelpers;
using Microsoft.AspNetCore.Mvc.Rendering;
using Microsoft.AspNetCore.Mvc.ViewFeatures;
using Microsoft.AspNetCore.Razor.Hosting;
using Microsoft.AspNetCore.Razor.Runtime.TagHelpers;
using Microsoft.AspNetCore.Razor.TagHelpers;

[RazorCompiledItemMetadata("Identifier", "/Views/Home/Index.cshtml")]
[CreateNewOnMetadataUpdate]
internal sealed class Views_Home_Index : RazorPage<dynamic>
{
	private TagHelperExecutionContext __tagHelperExecutionContext;

	private TagHelperRunner __tagHelperRunner = new TagHelperRunner();

	private string __tagHelperStringValueBuffer;

	private TagHelperScopeManager __backed__tagHelperScopeManager = null;

	private HeadTagHelper __Microsoft_AspNetCore_Mvc_Razor_TagHelpers_HeadTagHelper;

	private BodyTagHelper __Microsoft_AspNetCore_Mvc_Razor_TagHelpers_BodyTagHelper;

	private TagHelperScopeManager __tagHelperScopeManager
	{
		get
		{
			if (__backed__tagHelperScopeManager == null)
			{
				__backed__tagHelperScopeManager = new TagHelperScopeManager(base.StartTagHelperWritingScope, base.EndTagHelperWritingScope);
			}
			return __backed__tagHelperScopeManager;
		}
	}

	[RazorInject]
	public IModelExpressionProvider ModelExpressionProvider { get; private set; } = null;

	[RazorInject]
	public IUrlHelper Url { get; private set; } = null;

	[RazorInject]
	public IViewComponentHelper Component { get; private set; } = null;

	[RazorInject]
	public IJsonHelper Json { get; private set; } = null;

	[RazorInject]
	public IHtmlHelper<dynamic> Html { get; private set; } = null;

	public override async Task ExecuteAsync()
	{
		Func<dynamic, object> tmpl = (dynamic item) => new HelperResult(async delegate(TextWriter __razor_template_writer)
		{
			PushWriter(__razor_template_writer);
			WriteLiteral("hello!");
			PopWriter();
		});
		WriteLiteral("<!DOCTYPE html>\r\n\r\n");
		__tagHelperExecutionContext = __tagHelperScopeManager.Begin("head", TagMode.StartTagAndEndTag, "f28ac40da6b48d0ff2fc68470c48da621fef46d49584f3027c39d8caac6bdfc83899", async delegate
		{
			WriteLiteral("\r\n    <title></title>\r\n");
		});
		__Microsoft_AspNetCore_Mvc_Razor_TagHelpers_HeadTagHelper = CreateTagHelper<HeadTagHelper>();
		__tagHelperExecutionContext.Add(__Microsoft_AspNetCore_Mvc_Razor_TagHelpers_HeadTagHelper);
		await __tagHelperRunner.RunAsync(__tagHelperExecutionContext);
		if (!__tagHelperExecutionContext.Output.IsContentModified)
		{
			await __tagHelperExecutionContext.SetOutputContentAsync();
		}
		Write(__tagHelperExecutionContext.Output);
		__tagHelperExecutionContext = __tagHelperScopeManager.End();
		WriteLiteral("\r\n");
		__tagHelperExecutionContext = __tagHelperScopeManager.Begin("body", TagMode.StartTagAndEndTag, "f28ac40da6b48d0ff2fc68470c48da621fef46d49584f3027c39d8caac6bdfc84912", async delegate
		{
			WriteLiteral("\r\n
");
			IHtmlContent value = await Html.PartialAsync("_Partial", tmpl, null);
			Write(value);
			WriteLiteral("
\r\n");
		});
		__Microsoft_AspNetCore_Mvc_Razor_TagHelpers_BodyTagHelper = CreateTagHelper<BodyTagHelper>();
		__tagHelperExecutionContext.Add(__Microsoft_AspNetCore_Mvc_Razor_TagHelpers_BodyTagHelper);
		await __tagHelperRunner.RunAsync(__tagHelperExecutionContext);
		if (!__tagHelperExecutionContext.Output.IsContentModified)
		{
			await __tagHelperExecutionContext.SetOutputContentAsync();
		}
		Write(__tagHelperExecutionContext.Output);
		__tagHelperExecutionContext = __tagHelperScopeManager.End();
		WriteLiteral("\r\n");
	}
}

And decompiled source for _Partial.cshtml:
// RSTest, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=null
// AspNetCoreGeneratedDocument.Views_Home__Partial
using System.Runtime.CompilerServices;
using System.Threading.Tasks;
using Microsoft.AspNetCore.Mvc;
using Microsoft.AspNetCore.Mvc.Razor;
using Microsoft.AspNetCore.Mvc.Razor.Internal;
using Microsoft.AspNetCore.Mvc.Rendering;
using Microsoft.AspNetCore.Mvc.ViewFeatures;
using Microsoft.AspNetCore.Razor.Hosting;

[RazorCompiledItemMetadata("Identifier", "/Views/Home/_Partial.cshtml")]
[CreateNewOnMetadataUpdate]
internal sealed class Views_Home__Partial : RazorPage<dynamic>
{
	[RazorInject]
	public IModelExpressionProvider ModelExpressionProvider { get; private set; } = null;

	[RazorInject]
	public IUrlHelper Url { get; private set; } = null;

	[RazorInject]
	public IViewComponentHelper Component { get; private set; } = null;

	[RazorInject]
	public IJsonHelper Json { get; private set; } = null;

	[RazorInject]
	public IHtmlHelper<dynamic> Html { get; private set; } = null;

	public override async Task ExecuteAsync()
	{
		WriteLiteral("<button>\r\n    Snippet: ");
		Write(base.Model(null));
		WriteLiteral("\r\n</button>");
	}
}

And with a simple extension method for each scoped content, like this:
public static ValueTask<Scope> Button(this RazorSlice scope, string css) =>
    Scope.Create(scope, Slices.ButtonBegin.Create(css), Slices.ButtonEnd.Create());

It simplifies to:

@{
    await using (await this.Button(FormButton.Purple))
    {
        <text>simplest yet!</text>
    }
}

Awesome, thanks! Is there a way to share templated razor methods across a bunch of different slices? That could also solve a few issues with reuse.

No. The classes produced from the Razor compiler for .cshtml files are "unspeakable" so you can't access them or their members. This means there's no way to share templated delegates or methods unfortunately. You can use partials of course.
Now, all that said, theoretically it might be possible to take as similar approach to how this library itself generates wrapper types for each slice that you can use and then do runtime dispatching/thunking into the unspeakable types and their members, effectively creating a new pattern similar to the helpers pattern in ASP.NET Web Pages (the original Razor framework). I've logged #70 to capture that idea.

This fix is now available in https://github.com/DamianEdwards/RazorSlices/releases/tag/v0.9.0


"Cannot find package.." after running npx amplify sandbox

Environment information
** Used yarn for installation
  System:
    OS: macOS 14.2
    CPU: (8) x64 Intel(R) Core(TM) i7-1068NG7 CPU @ 2.30GHz
    Memory: 13.69 GB / 32.00 GB
    Shell: 5.9 - /bin/zsh
  Binaries:
    Node: 18.18.1 - /usr/local/bin/node
    Yarn: 1.22.19 - /usr/local/bin/yarn
    npm: 9.8.1 - /usr/local/bin/npm
    pnpm: Not Found
    bun: Not Found
    Watchman: Not Found
  npmPackages:
    @aws-amplify/backend: ^0.6.0 => 0.6.0
    @aws-amplify/backend-cli: ^0.9.2 => 0.9.2
    aws-amplify: ^6.0.9 => 6.0.9
    aws-cdk: Not Found
    aws-cdk-lib: ^2.116.0 => 2.116.0
    typescript: ^5.3.3 => 5.3.3

Description
After following gen2 "getting started" docs, up to the point where it says to run npx amplify sandbox, I received errors on that command.
I was only able to resolve the errors by installing the packages it says are missing.
I am assuming these are probably peerDeps that didn't get installed or recognised correctly.
Here are the dependencies in my package.json after installing the additional packages
  "dependencies": {
    "@aws-amplify/adapter-nextjs": "^1.0.9",
    "@radix-ui/react-accordion": "^1.1.2",
    "@radix-ui/react-dialog": "^1.0.5",
    "@radix-ui/react-label": "^2.0.2",
    "@radix-ui/react-popover": "^1.0.7",
    "@radix-ui/react-slot": "^1.0.2",
    "aws-amplify": "^6.0.9",
    "aws-cdk-lib": "^2.116.0",
    "class-variance-authority": "^0.7.0",
    "clsx": "^2.0.0",
    "cmdk": "^0.2.0",
    "constructs": "^10.3.0",
    "lucide-react": "^0.295.0",
    "next": "14.0.5-canary.19",
    "react": "^18",
    "react-dom": "^18",
    "tailwind-merge": "^2.1.0",
    "tailwindcss-animate": "^1.0.7"
  },
  "devDependencies": {
    "@aws-amplify/backend": "^0.6.0",
    "@aws-amplify/backend-cli": "^0.9.2",
    "@types/node": "^20",
    "@types/react": "^18",
    "@types/react-dom": "^18",
    "autoprefixer": "^10.0.1",
    "eslint": "^8",
    "eslint-config-next": "14.0.4",
    "postcss": "^8",
    "tailwindcss": "^3.3.0",
    "typescript": "^5.3.3"
  }

Hey @brandoncroberts :wave: thanks for raising this! and yes I think you're right, these are peerDependencies that were not installed. What version of npm are you using? Or do you have legacy-peer-deps enabled by chance?

I noticed you said you used yarn for installation. We currently only support npm, so it's expected that you would have to manually install peer deps if using yarn. We are actively working on supporting other package managers. You can follow the progress on the package-manager-support branch

Closing as a duplicate of https://github.com/aws-amplify/amplify-backend/issues/517

@josefaidt , npm version is 9.8.1
and thanks for clarifying
I might recommend you consider to have the users install aws-cdk-lib / contructs in addition to the aws-amplify package, instead of including it as a peerDep.
It's similar to what chakra-ui does for example


Add a Gitter chat badge to README.rst

djc/runa now has a Chat Room on Gitter
@djc has just created a chat room. You can visit it here: https://gitter.im/djc/runa.
This pull-request adds this badge to your README.rst:

If my aim is a little off, please let me know.
Happy chatting.
PS: Click here if you would prefer not to receive automatic pull-requests from Gitter in future.

Coverage remained the same at 93.43% when pulling 3077bb015d51b74c31a63f361fefadf7c2bf8088 on gitter-badger:gitter-badge into 830157e6d86f3cae49f34a0ca78379a6465ab8e1 on djc:master.

Fixed in f894554.


Getting memory crashes in NSOperationQueue (QOS: UNSPECIFIED) EXC_BAD_ACCESS 0x0000000000000000

What version of gRPC and what language are you using?
1.22.0 grpc version and using Swift language
What operating system (Linux, Windows,...) and version?
iOS
What runtime / compiler are you using (e.g. python version or version of gcc)
What did you do?
If possible, provide a recipe for reproducing the error. Try being specific and include code snippets if helpful.
We have an iOS app using Protobuf and grpc-swift ( https://github.com/grpc/grpc-swift ) library. Internally it is using grpc 1.22.0 version. But our app's users are seeing lots of crashes like these -
We haven't been able to understand those crashes or what can cause it. As our implementation is in swift and those errors are way deep into cc files, not sure what we are doing wrong here. We do use Protobuf for communication which internally uses GRPC.
What did you expect to see?
No crashes
What did you see instead?
The crashes are at various places. But it might be great if we can get some help in finding some pattern regarding what can cause those.

Crashed: NSOperationQueue 0x10b8259d0 (QOS: UNSPECIFIED)
0  grpc                             0x10b1b9954 grpc_slice_ref + 54 (slice.cc:54)
1  SwiftGRPC                        0x10a979804 cgrpc_metadata_array_copy + 86 (metadata_shim.c:86)
2  SwiftGRPC                        0x10a97b814 Call.start(_:metadata:message:completion:) + 108 (Metadata.swift:108)
3  SwiftGRPC                        0x10a98a0b4 ClientCallUnaryBase.start(request:metadata:completion:) + 49 (ClientCallUnary.swift:49)
Crashed: NSOperationQueue 0x10d91df70 (QOS: UNSPECIFIED)
0  libsystem_kernel.dylib           0x1c2410ef4 __pthread_kill + 8
1  libsystem_pthread.dylib          0x1c2331d1c pthread_kill + 196
2  libsystem_c.dylib                0x1c22c1a54 abort + 104
3  grpc                             0x10d271254 gpr_zalloc + 64 (alloc.cc:64)
4  SwiftGRPC                        0x10caa97c8 cgrpc_metadata_array_copy + 83 (metadata_shim.c:83)
5  SwiftGRPC                        0x10caab814 Call.start(_:metadata:message:completion:) + 108 (Metadata.swift:108)
6  SwiftGRPC                        0x10caba0b4 ClientCallUnaryBase.start(request:metadata:completion:) + 49 (ClientCallUnary.swift:49)
Make sure you include information that can help us debug (full error message, exception listing, stack trace, logs).
See TROUBLESHOOTING.md for how to diagnose problems better.
Anything else we should know about your project / environment?
It is an iOS app using Swift, grpc-swift library and Protobuf

I don't think we are able to address this issue without more information. The crash looks to be related to the usage of grpc core API (e.g. double destroy of metadata or slice). I'd suggest to file issue with grpc-swift to check for reason.


LiveView: stop the TUI & node itself.

Now pressing q (in a live view) stops the TUI as well as the node itself.

So, my idea is to make q more powerful. We display:

Press Q to quit

and user expects that quit means complete exit (stop the node). So we pass nodeThread to LiveView, and after user pressed q - just cancel node's working thread (function handleSimpleNode).

That is fine, but we need it to work for other signals as well.
We cannot have a terminal that doesn't respond to outside signals.
One of these signals is CTRL+C and it's currently being swallowed by that same thread (I presume).
You can simply rethrow the exception or throw an asynchronous one.

bors r+

bors r+


Fix empty string in text block

Fixes an issue where the plugin would treat something like:
$version: "2.0"
namespace com.foo

@someTrait(
    {
	stringAttribute: """
    		This breaks the parser -> ""
    	"""
    }
)
structure Foo {}

as invalid, because it couldn't handle 2 consecutive dquotes within a text block.

Thanks for the contribution, @milesziemer!

Will be released in v2.0.13 (should land in a day or two).


Wrong mouse cursor over BACKUP BRAINKEY RECOMMENDED

The mouse cursor over the text BACKUP BRAINKEY RECOMMENDED in the bottom toolbar is wrong. Should be a hand pointer suggesting an action instead of a cursor suggesting an input field.
Win 7, Chrome.

I don't think it is platform specific.  The change I pushed should fix it though.  Thanks for point this out.


Ensure responses from redirect requests are always processed

When UserAgentApplication is instantiated, it will check to see if there is a hash in the url and that we are not in a popup or iframe. If both are true, it infers that the request was a redirect, and thus the hash should be processed. The problem is that there are scenarios where the logic to determine whether or not we are in a popup is incorrect, such as when the window is opened in a new tab, or we are calling a redirect method inside a popup. This results in these checks failing, and the hash not getting processed.
To address this, we will now include a value in the encoded state value that will indicate what type of request method was used (popup, redirect, silent). When we receive a response we will check to see what the request method is, and if it was a redirect, always process it (regardless of whether or not we are in a popup, for example).
This PR builds on:

#1358
#1395

The initial changes made specifically for this PR are here (the rest of the diff is from the above unmerged branches): https://github.com/AzureAD/microsoft-authentication-library-for-js/pull/1413/commits/c52ad933f84dc708463a01c1886f4f3bbfbeca5d
This PR should fix:

#1198
#1095
#1301

TODO (@tnorling):

[x] Fix existing tests (@jasonnutter)
[ ] Unit tests
[x] Verify scenarios listed above are fixed
[ ] Additional code cleanup

Coverage decreased (-5.1%) to 71.56% when pulling 8a427681cc8e6a736fcfe339bd54a21b294820a0 on redirect-library-state into 37913c9129caca2e71d05a85f100263c92454c53 on dev.

We had the same issue when using redirectLogin so we are currently using popup. However i just tested this branch and it resolves the issue.
Now we are just waiting for it to be released and we can go back to our original auth flow.
God job @jasonnutter !

@tnorling Updates look good!


Fix mypy typing with aiohttp headers

Fixed the recent CI issues caused by mypy by (almost) doing what the aiohttp devs intended.

mypy is so cursed..
can't believe we have to go with a solution like this lol


docs: Tweak pull request template

Q
A

Branch?
develop

Bug fix?
yes

New feature?
no

Deprecations?
no

Tickets
N/A

License
MIT

Changelog
Yes

Doc PR
N/A

Tweak the table to smaller size

coverage: 99.718%. remained the same
when pulling 71dbcafe9ca5e4c9c3263391a23500b60c011d66 on tweak-pull-request-template
into e02bef959ac9df3cb25cea1690ec93ecdf5b0581 on develop.


Need a media type for OpenAPI Specifications

We are implementing an API in which the body of some messages can be OpenAPI Specification "documents". For this purpose, we need a media type for  OpenAPI Specifications. We would prefer to use a standard one (or more) blessed by the OpenAPI initiative rather than making up our own.
Our application requires that OpenAPI Specifications be treated as text documents, in the sense that if a specification is PUT or POSTed, a subsequent GET will return a body that is character-by-character the same as the one that was PUT (assuming someone else didn't change it in between times). This suggests to us that for this usage, a text/something media type is the right one. Our preferred format is yaml, so something like text/oas+yaml would make sense. We would probably also support  text/oas+json. If we did not have the requirement of character-by-character fidelity, we might be attracted more to something in the application/something family, and it may be that different media types are needed for different usages.

Duplicate of https://github.com/OAI/OpenAPI-Specification/issues/110

I'm not sure I understand the suggested relationship between symmetrical PUT/GET requests and the text/* media types.  A server can chose to make GET/PUT symmetrical whether the media type is application/* or text/.  And personally I see no reason for trying to register a text/ media type for OpenAPI.

Oops, sorry about the duplicate.
It seems to be hard to find clear guidance on when to use application/something versus text/something. Why do we use text/html rather than application/html? Why is there both text/xml and application/xml? RFC 3023 says this: "If an XML document -- that is, the unprocessed, source XML document -- is readable by casual users, text/xml is preferable to application/xml".
In our scenarios, the clients are treating the OAS as a text document, so text/oas+yaml makes sense to me. If our client was interested primarily in the API specified by the OAS document, rather than the document itself, text/oas+yaml would make sense to me. It would be nice if OAS allowed URLs for both the API and the OAS document to be established, as JSON Schema does. If we had that, a way to formalize what I said above would be to say that application/oas+yaml would be my preferred media type for the API itself, while text/oas+yaml would be my preferred media type for the OAS document that describes it.

@darrelmiller @mpnally - since this is indeed a duplicate of #110, would you mind moving this part of the discussion there? It'd make tracking things easier.

My fault, sorry. Should we just stop this thread, or should I also try to transfer some of this discussion to  f #110 ?

@mpnally yes, do it, please.

I'd suggest moving the critical parts there, though the issues are linked and should be handled together. For a higher chance of this being taken under consideration, mention those there please.
Closing the ticket for now.


Misc additions

Preview of Seas Of Shandalar Standard: is Fruity Madness WotC's biggest mistake yet?
Video: MTG – How I would improve Goblin Tribal in Magic: the Gathering, Part 2
New preview card from Dominaria! Is it a more reliable Mox Sapphire?

looks good!  :ok_hand:


Docker checksums

This PR just includes the workflow change and the unrelated ExampleConfig fix. If tests pass and no other changes (they should, I tested a huge chunk locally) are needed we can close this without changes.

Closing, this functionality change does not impact the current ocean.py code.


Update Blog Post “2020-05-iterating-on-code-mil”

Automatically generated by Netlify CMS

Deploy preview for dds-mil ready!
Built with commit f410b7a598af3450d2e9b29efc1f4f40808a88c2
https://deploy-preview-230--dds-mil.netlify.app

Deploy preview for dds-mil ready!
Built with commit 996c7479445a408677b5bf3abf27845fb91181ef
https://deploy-preview-230--dds-mil.netlify.app


fix(core): fix array remove operation for array of oneOf

fix #3794
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
PR fixes the issue of array remove operation failing when elements are oneOf
Issue: for enabling support of multi schema type elements in the array, we set the key as null but in remove operation we were reseting to the current index.
Please check if the PR fulfills these requirements

[x] The commit messages follow our guidelines: https://github.com/angular/angular.js/blob/master/CONTRIBUTING.md#commit-message-format
[ ] A unit test has been written for this change.
[x] Running npm run build produced a successful build. (Unit testing can be done by running npm test;)
[ x] My code has been linted. (npm run lint to do this. npm run build will fail if there are files not linted.)

Please provide a screenshot of this feature before and after your code changes, if applicable.
Other information:

Thank you @dev-kanishk!


Error: chequebook init: chequebook not deployed by factory

⚠ Requests for support in an issue-format will be closed immediately. For support questions, we welcome you to our Discord.
Summary

Steps to reproduce

Expected behavior

Actual behavior

time="2021-06-22T12:12:25+09:00" level=info msg="using ethereum address 819c5a5f0ac21aab48018dac50ccb38afeff81a9"
time="2021-06-22T12:12:25+09:00" level=info msg="version: 1.0.0-2572fa48"
time="2021-06-22T12:12:25+09:00" level=info msg="debug api address: [::]:1615"
time="2021-06-22T12:12:27+09:00" level=info msg="using default factory address for chain id 100: c2d5a532cf69aa9a1378737d8ccdef884b6e7420"
time="2021-06-22T12:12:29+09:00" level=info msg="using existing chequebook 10b7faa5c8cb9870face25b1ad6faf65a88eb1c1"
Error: chequebook init: chequebook not deployed by factory
I have 0.01xdai in my account
The following is my yaml configuration：
clef-signer-enable: false
data-dir: D:/.bee
swap-enable: true
swap-endpoint:  https://stake.getblock.io/mainnet/?api_key=ca6780d3-f5e3-4722-a472-fa9cdf677060
verbosity: info
welcome-message: "BOOM"
debug-api-enable: true
swap-initial-deposit: 0
bootnode-mode: true
mainnet: true
full-node: true
block-time: 5
gateway-mode: false
network-id: 1
api-addr: :1613
debug-api-addr: :1615
p2p-addr: :1614

add：
swap-initial-deposit: 0

same issue how to fix?

Keep the keys file and delete the rest of the old data
在 周二, 6月 22, 2021 在 22:38, William @.***> 来信：

same issue how to fix?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

same issue how to fix?

the chequebook in the log is from goerli test network. please make sure to start your mainnet node with a new data directory (copy over the keystore directory if not using clef).

Error: chequebook init: Insufficient funds. The account you tried to send transaction from does not have enough funds. Required<PHONE_NUMBER>000000 and got: 0


Shortcut Guide does not appear after holding down the Windows key

ℹ Computer information

PowerToys version: v0.20.1
PowerToy Utility: Shortcut Guide
Running PowerToys as Admin: No
Windows build number: 10.0.20197.1000

📝 Provide detailed reproduction steps (if any)

Ensure that Shortcut Guide is enabled (100 ms duration, 90% opacity, etc.)
Hold down the Windows key

✔ Expected result
The Shortcut Guide should appear after holding down the Windows key for the given duration.
❌ Actual result
The Shortcut Guide does not appear after the time. After releasing the key, the Start menu opens.
📷 Screenshots
Are there any useful screenshots? WinKey+Shift+S and then just paste them directly into the form

@nitishvijai
the fix will be available in 0.22
https://github.com/microsoft/PowerToys/pull/6025


Not compatible with React v16

I'm Submitting a ...
[X] Bug report
[ ] Feature request
[ ] Support request
Since react 16 removed .DOM from the react package, the component cannot be used with the latest beta release of react.
See this comment
I tried this PR#358 And it worked very fine. What is preventing you for merging it ? I can help if needed :)
Thanks for the awesome work anyway !

I'll be coming on board as a maintainer shortly.  This is likely the 1st PR I'll merge.  We are just currently waiting for the owner of the repository to come back from vacation to grant me rights.

Awesome, thanks for the input!

@vouill Thanks for posting this issue, and as you can see the PR has been merged and deployed!


Clear $this->collection even when empty, to reset keys

To have same behavior as when $this->empty() === false, that is to say reset $this->collection keys

I've manually cherry-picked this into 2.5 and merged into it and also into master. Thanks @steevanb: good catch! 👍
master: doctrine/doctrine2@c1480595930166a77a597b65dc8850509d57a934
2.5: doctrine/doctrine2@4d699789a25990f5514461f6b17b50f887d65f31

Thanks !
Do you know when 2.5.6 will be available, with this fix ?

At earliest occasion.
On 28 Nov 2016 2:26 p.m., "Steevan BARBOYON"<EMAIL_ADDRESS>wrote:

Thanks !
Do you know when 2.5.6 will be available, with this fix ?
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
https://github.com/doctrine/doctrine2/pull/6110#issuecomment-263270559,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAJakC54ehd_cZnE4CqlGiGtPi0c7sC5ks5rCtZ0gaJpZM4Kk5i7
.


Node_modules inclusion in the project asked 3 times

After installing NTVS 1.2 Alpha and opening existing solution with 1 NTVS project + 1 SQL Server project, the NTVS ask to include node_modules 3 times. I always select 'Don't include node_modules (recommended)'
UPDATE
Here the image of the dialog which appears

Can you please provide a screenshot of the dialog box you are seeing. We do have code that will show a dialog box about including node_modules, but the text it uses (IncludeNodeModulesCancelTitle) is different than what you describe. I want to make sure that the dialog is actually coming from our code.
Also, is node_modules being correctly not included from the project after you select no? That is, is the bug just the repeated prompting?
Thanks.

@mjbvz Update initial description to include image of dialog

That's our dialog box all right.
A few more questions: Was this a one time problem or does it happen whenever you open the project? Does it effect other projects or just this one? Do you have any more specific repo steps?
Thanks.

@mjbvz It happens when I open the project. But it ask me 3 times. I suspect that this could be due to fact that NTVS try to add typings folder from following 3 modules: typings, tslint, gulp-tsc. These modules included in the project, but node_modules folder itselft, does not part of the project. That's strange.

Thanks, those three packages and the observation about typings were key to getting a repo of the issue. I believe that the typings acquisition is the root cause.
Will have a fix out for PR shortly.


Register ProfilerController only if profiler service is defined

Problem
During cache:clear command in a production environment an exception is thrown:
[Symfony\Component\DependencyInjection\Exception\ServiceNotFoundException]
  The service "contentful.profiler_controller" has a dependency on a non-existe
  nt service "profiler".

Solution
We don't need a ProfilerController in a production environment. It's only used by Symfony Profiler, so I moved the definition for that controller to a different file and load that file only when profiler service is defined.

+1
This is very needed.  Please merge soon.
@tomaszhanc Do you think the data_collector could also be moved out as well?  I believe it's only needed for the profiler.

@realityking Maybe you can chime in here and help us get this merged?  Thank you.

@solomonjames
Unfortunately it can't, because we need all services in the container for ProfilerPass (in FrameworkBundle) which gather all services tagged as data_collector. When we moved it like the ProfilerController then that service is not visible by that ProfilerPass. One solution for that could be to register ContentfulBundle in the AppKernel before FrameworkBundle, but I didn't check it and actually don't like it that solution.

@tomaszhanc ahh I see.  You could do a check in the ContenfulExtension::prepend() method for the "web_profiler" and add the config then, but doesn't mean the profiler service is available.
This seems like the best solution.  The FrameworkBundle creates a dumby profiler service that doesn't do anything so this shouldn't be adding overhead.
+1 :shipit:

@realityking No problem, I will do it :)

@realityking In ContentfulExtensionTest there loadEmpty method but it doesn't have a test prefix so it's not executed - is it on purpose?

No, no it's not 😱
Fixing that at once.

@realityking Made changes, added unit test for CompilerPass, added sufi for loadEmpty :)

LGTM.
@tomaszhanc I could live with ContainerTrait, I'll leave this open for a bit in case you do want to change it.

@realityking I can live with it too, so if everything is fine for you, we can merge it.

Thanks for the great contribution 😊

Awesome @tomaszhanc !!
@realityking @solomonjames thanks!

Yaayy! Thanks @tomaszhanc @realityking


ci: change to using solo-charts repo and solo-containers repo

Description
This pull request changes the following:

Pointing to new chart repo
Rebrand any fst reference to solo

Related Issues

Closes #647

:tada: This PR is included in version 0.31.1 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 0.31.1 :tada:
The release is available on:

npm package (@release-0.31.x dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


mongo_db_plugin time error

as you can see above, create time for 'eosio' is 2018-11-27(time when I started sync). But I think tiime shoud be about 2018-06-~~ like below pic.

I'm syncing node from https://eosnode.tools/blocks
mongo_db_plugin options is default

sovled by bloks.io admin


not syncing on new records?

I installed the algolia extension 1-2 months ago and followed the instructions to do the initial data import.
however, subsequent changes do firestore have not triggered updates on algolia. currently, I have a new record in one of my collections (verified on Firebase dashboard) but searching for its id in algolia returns no results.

hey @jonathan-chin sorry for the delay, has the issue been resolved?  can you share your configuration details?

I am closing this issue, but please reopen if you can share additional details.


DaisyUI can't find type module

Discussed in https://github.com/saadeghi/daisyui/discussions/819

Originally posted by huskyjp May 28, 2022
I do have Nextjs & Tailwind codebase and just implemented daisyui by npm i daisyui .
Then added plugins: [require('daisyui')] in tailwind.config.js file.
I get a warning error that says like below and I believe typescript currently can not find daisyui type file??
Could not find a declaration file for module 'daisyui'. '/Users/dev//node_modules/daisyui/src/index.js' implicitly has an 'any' type.
  Try `npm i --save-dev @types/daisyui` if it exists or add a new declaration (.d.ts) file containing `declare module 'daisyui';`ts(7016)

Also - when I tried to simply implemet some daisyui component like
<button class="btn">My DaisyUI button</button>
it just shows text without any daisyui design.
I am not sure if the root problem is typescript error but when I start running the app, I get the daisyUI message so I believe the implementation is good but not working correctly for some reasaons.
 daisyUI components 2.15.1  https://github.com/saadeghi/daisyui
  ✔ Including:  base, components, themes[29], utilities

Would love to know following points 🙏

the type error reason
any possible reason why daisyui component is not working

Try using the repo examples as a boilerplate to start your project.
here: https://stackblitz.com/edit/daisyui-nextjs?file=package.json
I'm guessing it has to do with the way you set up your project.

@yajatvishwak
It's not. I'm getting the same issue, and it's due to there existing no type declarations anywhere.
So ideally either the published package should contain type definitions, or they should exist under @types/daisyui.

having the same issue
the best way to fix it IMHO would be to create a "@types/daisyui" package at https://github.com/definitelytyped/definitelytyped

having the same issue
the best way to fix it IMHO would be to create a "@types/daisyui" package at https://github.com/definitelytyped/definitelytyped

do you know the shape of daisyui export thou?

Hey! I'm happy to take this issue if no one else has started work. I've added types for some (much smaller) Tailwind plugins I've written so should be pretty simple. I'm also planning on adding types for the config so you should  get intellisense for the daisyui field in your tailwind.config.js.

Hey! I'm happy to take this issue if no one else has started work. I've added types for some (much smaller) Tailwind plugins I've written so should be pretty simple. I'm also planning on adding types for the config so you should get intellisense for the daisyui field in your tailwind.config.js.

Great, I am having this issue


rtic migration strategy for eh-1.0

I am trying to compile some examples with embeddeded-hal 1.0.0-rc.2 using stm32f4xx-hal from github which now uses it. One problem is that types for delay_ms and delay_us are now in embedded_hal::delay::DelayNs. This causes cortex-m-rtic = ">=1.0" to fail compiling.
Looking for a new github version I discovered that I should be migrating to rtic v2.  I really want to understand the changes, async functions, etc, before I jump into that, but the bigger problem is needing to use nightly.
Since release of eh-1.0 is planned before the end of the month, is it intended that everyone using rtic will be forced to use nightly in order to switch to the release of embeddeded-hal 1.0.0?  Or will there be a cortex-m-rtic with delay types from DelayNs? Or is there some other migration strategy I should try?

After some work with rtic v2 and some further reflection I will try to answer my own question. I would appreciate pointers to anything wrong:
Switching from rtic v1 to v2 is not too difficult. There is a change in logic that takes some adjustment.  It is not a disproportionately large part of the change to embedded-hal v1.0.0. Assuming rtic v1 will not be maintained as a permanent alternate to v2, then:

No one should start a new project using v1.
Don't expect a release of cortex-m-rtic  with delay traits in DelayNs, so cortex-m-rtic  will not compile for code using  embedded-hal v1.0.0. There will be a forced conversion to rtic v2 for anyone wanting to use embedded-hal v1.0.0.  (Developers have no interest in supporting legacy code just so I can be lazy and not make the switch.)
The requirement to use nightly will probably be removed soon, with a new release of rust. This may even happen before the release of  embedded-hal v1.0.0 at the end of December.

Update to embedded-hal 1.0 https://github.com/rtic-rs/rtic/pull/879.
However in V2 nightly is still needed because of TAIT.

This has been resolved by just moving to embedded-hal 1.0.


refactor: prefer GraphQL SDL for base/meta schema

@lutter thoughts on that? mainly around api.rs and the schema we are building there. I feel like using SDL might be simpler for most of the static definitions?
Also related:
https://github.com/graphprotocol/graph-node/pull/3201
https://github.com/graphprotocol/graph-node/pull/3184

Yes, my preference would be to express as much as plain text files (GraphQL SDL) as possible instead of doing that in code. Of course, some of that has to be dynamic since it depends on user-supplied types.


Sharpness heatmaps

Added functionality to compute and visualize sharpness heatmaps; the main computation work is done in the new heatmaps.py module in src.
Other notable changes: I moved metrics_f and single_metrics into a separate metric_list.py file so that both heatmaps and init.py could import them without a circular import; the function names in init.py have changed to specify whether they are computing metrics globally or locally (i.e., via a heatmap); and the s1 metric which previously incorporated a heatmap in its computation has been altered to remove that heatmap, bringing it more into line with the other metrics.
Heatmap computation is done, by default, on overlapping blocks that are ~1/8th the size of the input image, so as to not be tremendously slow on large images; the size of the blocks is printed whenever they are automatically set.
For benchmark.py, I added a "--heatmap" option, which adjusts both the computation and output routines, as seen in the README. For heatmap computation, we compute all the heatmaps and output them as figures as well as printing the average value across all the blocks. When the metric returns a pair of heatmaps (i.e., all the metrics in single_metrics) and we're computing all the metrics, only the heatmap for T is displayed in the large grid of figures created by benchmark.py. Once the list of metrics is completely settled, it would be fairly easy to create a better large figure grid.

@jsschreck The filter size and padding amount should be dynamic based on the size of the input image; the block size will be ~1/8th of the width of the input image, while the padding will be ~1/16th of the width. I can add some details on that choice into the README to make it clearer what's going on.


[Usage] I cannot load the finetuned model with my own language model

Describe the issue
I use a llama2 ( Different sizes from yours ) as the language model, after finetuning , i cannot load the finetuned model , i use the  cli,py ,get this:

tokenizer, model, image_processor, context_len = load_pretrained_model(args.model_path, args.model_base, model_name, args.load_8bit, args.load_4bit, device=args.device)
function load_pretrained_model failed
image_processor is none makes NoneType error

Hi @Eric-is-good, I'm new in this field. I now have a dataset for fine-tuning the llava, but I don't sure if I need to pre-train as this, or I just need to run the finetune script. Looking forward to your reply!

Hi @Eric-is-good, I'm new in this field. I now have a dataset for fine-tuning the llava, but I don't sure if I need to pre-train as this, or I just need to run the finetune script. Looking forward to your reply!

you need pre-train and finetune both

Thank you for your reply! I also want to know what the difference is between pre-trained and fine-tuned datasets? It looks like they have the same structure.

Thank you for your reply! I also want to know what the difference is between pre-trained and fine-tuned datasets? It looks like they have the same structure.

pre-trained is picture and caption, finetune is picture and dialogue with tasks. the structures of them are the same.

You made me understand at once. Thank you!

Describe the issue
I use a llama2 ( Different sizes from yours ) as the language model, after finetuning , i cannot load the finetuned model , i use the cli,py ,get this:
tokenizer, model, image_processor, context_len = load_pretrained_model(args.model_path, args.model_base, model_name, args.load_8bit, args.load_4bit, device=args.device)
function load_pretrained_model failed image_processor is none makes NoneType error

Hello, have you solved this problem? Could you please give me some advice? Thank you very much.


HDDS-3446. Enable TestOzoneManagerRestart and address any failure.

What changes were proposed in this pull request?
Enable and address failure for TestOzoneManagerRestart test cases.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-3446
How was this patch tested?
Running TestOzoneManagerRestart case multiple times.

Thank you @prashantpogde for the contribution.


Remove unused calls to pure functions

Babili could use an @pure JSDoc tag to determine which functions are pure, then remove unused calls to them.
AST Explorer with code + example: https://astexplorer.net/#/gist/bdcbc34df3916d324454a332988503c7/7c39cede7af9cc9244f89876bb8339a5a4fb3d37
In:
/** @pure */
const myPureFunc = () => {}
myPureFunc()

Out:
/** @pure */
const myPureFunc = () => {}

Instead of @pure Babili could use #__PURE__, like Uglify: mishoo/UglifyJS2#1448, babel/babel#5632

This is a similar request to https://github.com/babel/babel/issues/5632? Referencing the same issue too. I'm already in favor of doing it

Sort of — this one will strip out calls to pure functions, while that one wants to add an annotation to functions wrapping transpiled classes.

Duplicate #520


[Package Request]:

Package Requested

[X] I would like someone else to build the manifest.
[ ] I would like help so I can submit the manifest.
[X] I have performed a search and couldn't find this package.
[ ] I have checked that the installer for this package is not a standalone or portable executable or a .zip file
[ ] I think there is a new version available and I have provided the URL.

Please provide the following information
Publisher: TechPowerUp
Publisher Url: https://www.techpowerup.com
Package Name: NVCleanstall
Description: NVCleanstall lets you customize the NVIDIA GeForce Driver package by removing components that you don't need (or want). This not only keeps things tidy, but also lowers disk usage and memory footprint.
Package Version: 1.10.0
Installer URL: https://www.techpowerup.com/download/techpowerup-nvcleanstall/
Current Package Identifier (for new versions):

Late reply but @W1zzardTPU do you have an idea for a workaround?
Or a standalone installer we can use for WinGet?
Would it be possible to add a /wait command when /install is executed?

Would it be possible to add a /wait command when /install is executed?

Certainly, or is there any way to have winget look for another running process and wait for that?

@denelon

https://github.com/microsoft/winget-cli/issues/418

I think this issue is intended to address that scenario. At least I hope it would cover it. We currently don't watch the process tree, just the thread we executed. It sounds like this installer is doing similar to what squirrel installers do.

* [Support installers that close the install process and launch a new process for install winget-cli#418](https://github.com/microsoft/winget-cli/issues/418)

I think this issue is intended to address that scenario. At least I hope it would cover it. We currently don't watch the process tree, just the thread we executed. It sounds like this installer is doing similar to what squirrel installers do.

What's your ETA to address this?

We don't have an ETA. We tend to prioritize "bugs", then "features" in most general cases. We have quite a backlog of bugs currently in progress. Likely more than we will complete by the 1.2 target release. We communicate the roadmap in terms of GitHub Milestones. Note, the date and scope are not commitments, but a best attempt. I'm in the process of culling what won't be completed in the client 1.2 milestone, and looking at 👍 to determine the relative priority based on community feedback. In some cases, we do prioritize other issues based on internal or partner needs above the community vote alone.
Most of what I shared in just to help with transparency. We have a large surface area to deliver against between the Client, the reference REST implementation, the services for validation and publishing the default "winget" and "msstore" sources, the PowerShell cmdlets and all our other compliance, security, privacy, and localization concerns.

Please test if www.techpowerup.com/wizzard/NVCleanstall_1.10.3.exe installs correctly using winget
I changed the installer logic so that it will launch the installer and wait for it to complete before it exits

Please test if www.techpowerup.com/wizzard/NVCleanstall_1.10.3.exe installs correctly using winget
I changed the installer logic so that it will launch the installer and wait for it to complete before it exits

Yeeeap that worked flawlessly

Awesome, will push out the new build this week,

Hello. Looks like they update the NVCleanstall (v1.11.0) to work with winget.
"...To fix a compatibility issue with winget, NVCleanstall will now wait for the installer to complete before terminating..."
Thanks.


KeyError: interp_SMB_ICESat2_ATL15.py hemisphere flag dictionary expects different keys

In  interp_SMB_ICESat2_ATL15.py, a hemisphere flag ('S' or 'N') is set depending on the region of interest. However in Line 262, the hemisphere flag dictionary is indexed for 'AA' or 'GL' resulting in the following error:
ERROR:root:Traceback (most recent call last):
  File "/Users/rohaizharis/miniforge3/envs/SMB/lib/python3.12/site-packages/SMBcorr-0.0.0-py3.12.egg/EGG-INFO/scripts/interp_SMB_ICESat2_ATL15.py", line 520, in main
    interp_SMB_ICESat2(args.directory, args.infile, args.model,
  File "/Users/rohaizharis/miniforge3/envs/SMB/lib/python3.12/site-packages/SMBcorr-0.0.0-py3.12.egg/EGG-INFO/scripts/interp_SMB_ICESat2_ATL15.py", line 262, in interp_SMB_ICESat2
    MERRA2_REGION = dict(AA='ais',GL='gris')[HEM]
                    ~~~~~~~~~~~~~~~~~~~~~~~~^^^^^
KeyError: 'S'```

should be fixed in #32 :facepalm:


Foreign key constraint is incorrectly formed

SQLSTATE[HY000]: General error: 1005 Can't create table `laravel`.`plan_features` (errno: 150 "Foreign key constraint is incorrectly formed") (SQL: alter table `plan_features` add constraint `plan_features_plan_id_foreign` foreign key (`plan_id`) references `plans` (`id`) on delete cascade on update cascade)
Using PHP 8 & 10.4.24-MariaDB

Nevermind, this was my issue, sorry


(FACT-1222) Update OS release regex for SPARC Solaris 10

SPARC and X86 Solaris systems contain slightly different
release strings in /etc/release. They differ by a single
character, where SPARC uses the letter 's' and X86 uses
the letter 'x'. This commit relaxes the regex used to grab
this string so as to be compatible with both architectures.

Actually, retargeting this at stable.


NIFI-4289 - InfluxDB put processor

Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:

[x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?

[x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

[x] Has your PR been rebased against the latest commit within the target branch (typically master)?

[x] Is your initial contribution a single, squashed commit?

For code changes:

[x] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
[x] Have you written or updated unit tests to verify your changes?
[x] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[x] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
[x] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
[x] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

[ ] Have you ensured that format looks appropriate for the output in which it is rendered?

Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.

Hey Nifi Team:  Please let me know your feedback/comments on this processor.  Thanks.

Hey Folks - Please let me know your feedback/suggestions for this time-series db processor.  Thanks

@mattyb149 @MikeThomsen
Please let me know if you have any addiional comments/recommendations for this processor.
Thanks

@MikeThomsen -
If the fields, tags and timestamp for a measurement are the same, they are considered to be the same record.
Regarding size limit - I did not find any mention of size limit for posting data in the influxdb docs. I think this all depends on use cases and with the size limit processor property available, the nifi admin configure the values based on their influx db cluster and load.
Let me know if I have missed anything or anything else required.
Thanks again for your advice/comments.

@pvillard31 @alopresto Could one of you take a look? I think @mans2singh has done an excellent job addressing our concerns.

@pvillard31 -
You were right - After renaming the integration tests they don't get executed by default mvn install.  Also removed test profile from pom.xml as recommended.
Please let me know if you have any additional recommendation.
Thanks again.

It looks OK to me, I'd just suggest allowing EL on username/password. Will probably be useful with the Registry stuff. I know sensitive properties are not handled by the registry work yet, but that could be in the future.
Before giving a final +1, I'd appreciate another opinion on L&N aspects but it LGTM. Thanks for all your work @mans2singh

The L&N LGTM :) the MIT license reference goes in the assembly LICENSE and the NAR license (which it is), and nothing in the NOTICE unless its transitive dependencies have NOTICEs, I verified only Apache Commons Lang does, and it is included.

@pvillard31 @mattyb149 @MikeThomsen
I've added expression language support for username and password.
Please let me know if there is any other recommendation.
Thanks
Mans

Did some additional local tests. LGTM.
+1, merging to master, thank you all.

Thanks @MikeThomsen @pvillard31 @mattyb149 @joewitt @jskora and everyone for your advice/support.


Proposal for WebGL rendering

I'm working with @jmuhlich and @dpwrussell on an application using OpenSeadragon. Along the way, we've outlined one approach to a WebGL rendering engine within OpenSeadragon. We'd like to know whether these changes would be of general interest, and we're looking for feedback on the general approach outlined below.

We propose changes to OpenSeadragon to replace canvas 2D rendering with rendering through WebGL. The proposed OpenSeadragon updates will allow application-specific “GLSL” fragment shaders to modify all pixels in tiled images. Custom shaders will let applications render color images directly from a variety of useful scientific encodings such as 2D label maps or high dynamic range grayscale images.
All browsers supporting OpenSeadragon’s use of canvas also support the proposed use of WebGL. No up-to-date browsers will benefit from a 2D canvas fallback from WebGL; therefore, we propose removing “2d” contexts entirely to reduce the number of implementations to maintain. After feature detection, OpenSeadragon will use either a “webgl2” context, a “webgl” context, or the HTML rendering fallback.
If OpenSeadragon detects WebGL support, each image record will manage TypedArray objects from decoded ajax responses or from rendered image elements. Methods of the drawer, tiled images, and tiles will render these arrays to textures and bind all textures per frame to a webgl context. Without WebGL, the image record will still manage image elements directly. In either case, no rendered 2D canvas context will be created or stored by the image job. With WebGL, the drawer will call a new method of Tile named drawGL, which will use a cached TypedArray. Otherwise, the drawer will still call drawHTML from a cached image element. In either case, the drawCanvas method will not be called, and the sketch canvas will not be needed.
We will add to the API, updating the interfaces and descriptions in the OpenSeadragon docs. The API will remain compatible with the current (version 2.3.x) API; however, plugins will break if they rely on overwriting methods that Openseadragon will no longer call internally. New external API endpoints will allow projects depending on OpenSeadragon to supply custom functions written in GLSL ES 1.00 to use in all current browsers and/or GLSL ES 3.00 to use in browsers with detected webgl2 support.
Open Questions:

With Ajax enabled and WebGL supported, we intend to store pixel data in TypedArrays instead of HTML image elements to support high dynamic range grayscale images common in scientific imaging. As HTML image elements only provide 8-bit pixel data from standard HTML5 image formats, we will need to support loading from higher-depth formats through JavaScript implementations of PNG (16-bit), TIFF, etc. We are unsure whether to bundle these decoders within OpenSeadragon or ask applications to pass a custom decoder as a tilesource option.

OpenSeadragon will cease to use certain documented properties and methods. For example, the viewer event tile-loaded supplies an HTML image element. Even when no image element is needed internally, the new implementation of such events must always supply an image element and handle modifications to it in order to maintain compatibility with existing plugins. The documentation only references some properties (e.g. a drawer’s SketchCanvas) indirectly within descriptions of other properties and methods. We are unsure whether to remove such properties entirely.

We suggest continuing to handle the pyramids generated by an ImageTileSource by initializing tiles with “2d” contexts, but these contexts will be used to either call drawGL on a TypedArray or drawHTML on a HTML image element. We are unsure whether any simpler solution could better support the API.

Exciting! We've been interested in something like this for a long time (see #68 for webGL and #1380 and #1215 for image format support). Just to be clear, I believe the advantage we're seeking with webGL is performance.
The addition of support for other formats, including those with deeper bit depth, also sounds great, though I suppose that change would still be possible with canvas (though perhaps it would require too much pixel manipulation to be performant).
I don't think I can support removing the canvas draw path immediately, however. I think in order to make this a successful transition we're going to need to maintain both the canvas and webGL draw paths for at least some period of time. For one thing, as you point out, many plugins rely on the canvas draw path, and it would be good to give them a chance to migrate to the webGL draw path before breaking them. This can only happen if there is a period of overlap where both options are available.
I know from my own development experience on other projects that while all of the major browsers currently support webGL, they don't all do it better than canvas. IE 11 has a number of bugs related to webGL, and lower powered mobile devices also have issues with webGL compared to canvas. For this reason, webGL isn't an automatic win for every device/browser, so we'd be doing a disservice to simply move everyone over.
So, I propose moving forward with a new webGL draw path that can coexist with the canvas draw path. Perhaps to cut down on the initial complexity, that can happen at first with regular images and the additional image format support can be added once the new draw path is in place.
Regarding the new formats, I'll be interested to know the trade offs involved with internal support vs. external. I see three options for each format: Supported directly within OSD, supported via plugin, or supported via user code. Given the different trade offs for different formats, I can imagine some formats would be better with one form of support where as others would be better with another. I'd love to see a general purpose "format support" mechanism.
Like I said, I'm excited; both webGL support and new format support are big features that have been of interest for a long time!

That's great! Thanks for your support.
To some extent support for images with higher bit depths is a separate issue from a webGL drawer, but a solution without webGL would require something to reformat the images as 8-bit RGBA for canvas. According to the MDN documentation ,ctx. putImageData  and ctx.drawImage support ImageData and CanvasImageSource , respectively. Certainly ImageData and apparently all types in CanvasImageSource only support 8-bit RGBA. There may be a method I haven't considered.
The format support interface could work similarly to the TileSource interface. There are a few built-in options, but then there's one getTileUrl function that's easy to understand but generally useful for user-defined code. It would require careful thought to come up with a getImagePixels interface that is similarly useful, but it would be worth the effort.
In terms of compatibility, it's good to know about the WebGL bugs in IE 11 or mobile devices. I agree that maintaining canvas rendering is the easiest way to guarantee backwards-compatible plugin support. I'm still uncertain how to handle plugins that override canvas methods that will only be called when WebGL is not enabled. For that reason, do you think WebGL be enabled with a custom flag, or perhaps enabled by default except in specific browsers?

If a getImagePixels entry point:

accepts ArrayBuffer from ajax response
returns a TypedArray
The "2d" canvas draw path should only allow getImagePixels to return:
UInt8Array
The "webgl" draw path should only allow getImagePixels to return:
UInt8Array
UInt16Array
The "webgl2" draw path should allow getImagePixels to return:
UInt8Array
UInt16Array
UInt32Array
Float32Array

I'm imagining we'll want the default to be an auto-detect that uses WebGL on most browsers but chooses canvas for some. Then we can have an option that forces it to one or the other if the developer needs.
We'll probably want to add an API that can tell you which drawer is being used, so moving forward, plugins that require one or the other can gracefully disable themselves as needed. I could also imagine plugins that would support both, but would need to know which thing to hook into.
We might also want to support things like a canvas based overlay; no reason we couldn't have a 2d canvas over top of a WebGL canvas.
Presumably if we wanted to "support" (i.e. not break entirely) 16- and 32-bit images on canvas we could crunch them down to 8-bit (along with a warning that that's what's happening).
BTW, while we're in this area, the ability to generate and/or customize tiles after they've been loaded but before they've been drawn is just kind of hacked in to the system. It would be great if that stuff could be cleaned up a bit in the process. Just a thought.
Anyway, figuring out how to break this down into sensible chunks is probably the best way to keep us all sane! :)

@iangilman Thank you for your help planning this. I'm going to start writing a standalone drawer. After I have something worth sharing, I'll return to your notes here to begin a more detailed API specification.
I think it seems sensible to break the project up along the various API endpoints needed. While I'm not particularly attached to any of these details, here are my initial thoughts on each endpoint:

Custom tile generation:

Developer defines loadResponseArray, given the URL:

It functions like makeAjaxRequest
It returns a UInt8Array that is arbitrarily encoded
Default to makeAjaxRequest or html image loading

Developer defines readResponseArray, given the response:

It can decode, unpack, or otherwise modify the bit
It returns a TypedArray with actual image pixels
Default to decoding jpg/png/gif (as html image does)

Log warning when reducing higher bit-depths

Custom WebGL code:

Developer requests a type (e.g. vec2) for tile pixels
Developer defines a fragment shader to act on tile pixels

It can be glsl 1.0 (for WebGL 1 or 2) or glsl 3 for (WebGL 2 only):
It must set a vec4 called rgba
It can read these values

Viewport-coordinate bounds of tiled image
Image-coordinate bounds of tile
World index of tiled image
Sampler u_tile giving tile (as requested type)
Auv holding vec2 tile coordinates

Which drawer to use

Viewer option useWebGL: true overrides useCanvas: true
Developers can read Drawer.useWebGL xor Drawer.useCanvas

Or Drawer.contextType of [undefined, "2d", "webgl", webgl2]

Feature detection

WebGL 2: anything with getContext('webgl2')
WebGL: anything with getContext('webgl')

except ie11, old mobile browsers

Canvas 2D: anything with getContext('2d')

Looks great to me! And yes, starting with the drawer seems like a good plan. I'm excited to see this in action!

I am considering coding something similar in purpose to what @thejohnhoffer has proposed. I have similar needs:

View multi-channel high bit depth (uint16, float16, or float32) image data
Mapping from multi-channel high bit depth to 8-bit RGB for display
User interface for making interactive adjustments (e.g. gamma, offset, gain, range, normalise) to the mapping quickly on the client side without re-fetching image data from the server

Openseadragon and viaWebGL look like excellent starting points for this.
I have a concern about the performance of using pixelwise loops in JavaScript for data conversions. I found an example from a LeafletsJS plugin which does this kind of pixelwise data conversion in GLSL.
Are any status updates on the work proposed in this issue? It would be good to know before I start coding.

Great to have your support, @yellowtailfan ! @thejohnhoffer had to take a break so our team hasn't had a chance to finish the specification or write any code, but we're still desperate for this feature in OSD. Maybe together we can flesh out the API spec outlined above, before diving in to the coding? You can find my email in my profile and contact me to work out a plan. I'm also curious what you're working on! (We're visualizing many-channel fluorescence microscopy images)

Thanks @jmuhlich, that sounds great. I’ll be in touch soon.
My application is related: I’m working on scientific image processing.
I also found another approach to high bit depth data in the JavaScript Extended-Range Image (JERI) Viewer. They used emscripten to compile the OpenEXR C/C++ library into WebAssembly. OpenEXR is a multi channel high bit depth image file format used for visual effects (JERI was written by Disney Research).
I don’t know much about performance optimisation in modern JavaScript. Can anyone comment on the relative performance of pixel-wise data type conversion and range mapping in:

Pure JavaScript
WebAssembly
WebGL shaders

I would guess that WebGL shaders would be the fastest, but I don’t know how much difference there would be between the 3 options. I imagine there would be browser compatibility issues too, especially on mobile.

I would guess WebGL shaders as well, since they are run straight on the GPU just like shaders that come from native code. I don't have any hard data to back that up. Seems like some experimentation/benchmarking might be in order.

Possibly relevant to this issue, @karin-toth posted in https://github.com/openseadragon/openseadragon/issues/1683#issuecomment-574162070 a link to her stab at a WebGL renderer for OpenSeadragon:
https://github.com/karin-toth/openseadragon/tree/kato-webgl
Her comments:

I've been working on a webGL renderer for quite some time now, but as many other things, it's more complex that it seems. I got something to work, but taking it from a seems to work-state to the type of fail-safe production code that is required takes more time than I thought. So I would have loved to contribute, but I just don't have the time to complete this.
I'm of course open for answering questions and other help in the future if someone wants to continue.

Any updates on this from the maintainers? If OSD has anything akin to a roadmap, is this on it? Or will someone need to contribute a fully polished PR for it to happen?

Nothing new on this front. All of the work on OSD is from volunteers, so we don't have a roadmap... It's just whatever someone is motivated to work on. I feel like there's potential for the many institutions that use OSD to kick in some money for more directed development (and we do have an Open Collective), but I think in order to make that happen, we'll need someone who can actually go around and hit those institutions up. I'm thinking it may be time to start looking for that person, so if you (or anyone else) have suggestions, I'm all ears!
But I digress. No, nothing new on the WebGL front. Every now and then someone gets interested and takes a stab at it, but none of it has come to fruition yet. A company almost hired me to do it a year or two ago, but that didn't end up happening either. I think I've got a pretty good idea of how to make it happen, but it's a big job and I can't afford to take that much time off from work without getting paid for it.
If you're interested in tackling it, or if you know someone who might want to fund it, dive in! I'm happy to help point the way :)

This is now superseded by #2310.


Mosaic split

Enable the creation of mosaics after cow changes.
More info: https://github.com/nemtech/nem2-sdk-typescript-javascript/issues/48

Blocked by this issue: https://github.com/nemtech/nem2-sdk-typescript-javascript/issues/76


Disable CORS for Vega editors

[x] https://vega.github.io/editor/
[x] http://idl.cs.washington.edu/projects/lyra/app/

Will be done in #2346 shortly.


[AUTOPATCHER-kernel] Kernel upgrade to version <IP_ADDRESS> - branch main -

[AUTOPATCHER-kernel] Kernel upgrade to version <IP_ADDRESS> - branch main
Upgrade pipeline run -> https://dev.azure.com/mariner-org/mariner/_build/results?buildId=342180&view=results
AMD64 build -> https://dev.azure.com/mariner-org/mariner/_build/results?buildId=342231&view=results
ARM64 build -> https://dev.azure.com/mariner-org/mariner/_build/results?buildId=342232&view=results

Closing due to newer update https://github.com/microsoft/CBL-Mariner/pull/5316


:bug: Drop sudo modification from ubuntu flavors

We were "fixing" the sudo command but that resulted in sudo not working on livecd and weird behaviour.
Leave it as it is as it should come with proper perms from the package directly

What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

@Itxaka should we close this one?

Probably yeah


:wrench: Gradle wrapper upgrade and optimizations

updated gradle wrapper to 7.0.2
replaced the deprecated compile/testCompile dependencies with implementation/testImplementation
added process forking for tasks of type JavaCompile; this improves performance of gradle daemon reducing the amount of garbage collection in its process
added process forking for tests
enabled build caching of inputs and outputs

Overall, I saw about a 50% reduction in build time from the above changes

Thanks for your contribution, now it really builds with maybe more then 50% less time!

 It's my pleasure to be able to help out the project :)


Added praqmajutils library to jenkins artifactory

Description
Utility library used in ClearCase UCM library and various other plugins praqma has developed.
https://github.com/Praqma/praqmajutils
Submitter checklist for changing permissions
Always

[x] Add link to plugin/component Git repository in description above

For a new permissions file only

[x] Make sure the file is created in permissions/ directory
[x] artifactId (pom.xml) is used for name (permissions YAML file).
[x] groupId / artifactId (pom.xml) are correctly represented in path (permissions YAML file)

When adding new uploaders (this includes newly created permissions files)

[x] Make sure to @mention an existing maintainer to confirm the permissions request, if applicable
[x] Use the Jenkins community (LDAP) account name in the YAML file, not the GitHub account name
[x] All newly added users have logged in to Artifactory at least once

Again another library we want to move. Added myself @MadsNielsen and @ReleasePraqma as publishers.

Have you considered publishing to Central (via OSSRH) instead? This is currently using hpi packaging yet it does not seem to call any Jenkins APIs. If it is indeed a pure library, it would be better published independently (with jar packaging); the Jenkins plugin can simply declare a Maven dependency on it in order to bundle it.

@jglick That is exact what we currently do, i changed the packaging to .hpi from .jar to make it clear it is intended for Jenkins. The plugin is already published but we're shutting down our own maven repository soon, and i thought this was the easiest way to go about it for finding a new home for this dependency.
I'll close this if you do not allow any libraries the do not use any Jenkins libraries and i'll see if i can figure out to get it published via OSSRH.

We actually don't have an established process for these. There are some exceptions (those with component- file name), but AFAICT those mostly are upstream libraries we patched, or other obvious Jenkins specific libraries.
If you still want to go this route, I recommend an email to the dev list.

@daniel-beck Yeah, that's the reason i added the component name in this request. I'll try to go the OSSRH route instead since i might have misunderstood what component was used for in this context in the Jenkins organisation. This particular library is used in 4 different Jenkins plugins and nowhere else. TBH i only did it here since i thought it was the fastest route to get an artifact hosted.

@daniel-beck Alright, i think it should be clarified in the documentation that, these components are usually structural in nature, like shaded libraries, and for jenkins core, or alternatively has to use a Jenkins API in order to be eligable for hosting consideration.

This particular library is used in 4 different Jenkins plugins and nowhere else.

In such case we could consider converting it to an API plugin with a generic name. It's what we did for UCM API a while ago.
But for the linked codebase I am not sure it's feasible. Praqma utils is a pack of various small classes which duplicate existing APIs in newer Java versions and logging systems. I am not sure what would be the benefit for the community

@oleg-nenashev Yeah, it was also one of the conclusions i came to (this is when JDK7 was in beta). So i'm OK with this one being rejected for hosting, but i still maintain that the requirements are rather vauge for this kind of API.
Im looking forward to the UCM API being accepted so we can finally move to the cloud and away from our old maven repo :)

@MadsNielsen I agree with your feedback. IMHO it would be useful to formalize requirements, and it would be a subject for JEP IMHO. I created https://issues.jenkins-ci.org/browse/INFRA-1662 for it


Improvement: Card sizing and image

[x] Add height prop to card image
[x] Make card expand to parent div height
[ ] Add placeholder/fallback image to card image

merged into main


Support NerdGraph Cloud Integrations

Feature Description
Enable managing Cloud integrations via NerdGraph
{
  actor {
    account {
      cloud {
        linkedAccount { }
        linkedAccounts { }
        provider { }
        providers { }
      }
    }
  }
}

mutation {
  cloudConfigureIntegration { }
  cloudDisableIntegration { }
  cloudRenameAccount { }
  cloudLinkAccount { }
  cloudUnlinkAccount { }
}

Additional context
This will unlock the ability to configure Cloud integrations via Terraform: https://github.com/terraform-providers/terraform-provider-newrelic/issues/62

Required for terraform-providers/terraform-provider-newrelic#62

This was completed in #459


Condense two SharedSecret instances into a single one

To make this work, we can move org.interledger.stream.SharedSecret into the ilp-core module. We should make sure there are no Jackson annotations on it.
Next, we will likely need to make a Jackson Serializer/Deserializer + Module in the jackson-datatypes module.

If there's time we can maybe slide this into v1.0. Otherwise, it's fine to put into v1.1.

Fixed by #314


/actuator/refresh Can't access

I use spring boot2.0 + spring cloud Finchley M7 to create config-server and config-client， when I visit /actuator/health return info, but when I visit /actuator/refresh having error.
{
"timestamp": "2018-03-26T03:48:54.604+0000",
"status": 403,
"error": "Forbidden",
"message": "Forbidden",
"path": "/actuator/refresh"
}

my config

Hmm, I doubt this had anything to do with spring cloud. Can you provide a project that reproduces the problem?

Hello, this is the project address.
https://github.com/zhongzunfa/spring-cloud-test

@spencergibb  can you tell me whay?  and How do I solve this problem?

Not this week. I'm away from work

Try to add management.security.enabled=false as actuator's endpoints are restricted by default

@tdanylchuk The new version is not management.security.enabled。 this is spring boot 1.x

Sorry, didn't notice about boot version.
As for issue - I guess it's better to move this to spring boot issues as it's not related to config.
In spring boot CsrfFilter does not allow POST requests. Only GET", "HEAD", "TRACE", "OPTIONS allowed.
For more info take a look on CsrfFilter.DefaultRequiresCsrfMatcher class.

Hmm, I already mentioned that before. this is address : https://github.com/spring-projects/spring-boot/issues/12536
but tell me,

try
@Bean public SecurityWebFilterChain securityWebFilterChain(   ServerHttpSecurity http) {     return http.authorizeExchange()       .pathMatchers("/actuator/**").permitAll()       .anyExchange().authenticated()       .and().build(); }

I try to do it. but

Well it was hard and not obvious, but I finally got the expected result with your source code.
You change  protected void configure(HttpSecurity http)
add http.csrf().disable();
And add:
      <dependency>             <groupId>org.springframework.security</groupId>             <artifactId>spring-security-rsa</artifactId>             <version>1.0.5.RELEASE</version>         </dependency>
to client-refresh pom.

@spencergibb can you tell me whay? and How do I solve this problem?

@spencergibb How should I configure it?

Can you provide a complete, minimal, verifiable sample that reproduces the problem?

@spencergibb  this is the project address.
https://github.com/zhongzunfa/ch11-2.git

Finchley.M9 is the latest release, can you please update to it?

Ok, I'll give it a try.

I just tried it, but I can't.

I find post method ， can't acess. I don't known Where is the wrong configuration.

Did you try https://github.com/spring-cloud/spring-cloud-config/issues/950#issuecomment-377180581. This was the solution.

@tdanylchuk @spencergibb Thank you for the answer

@tdanylchuk tdanylchuk  I got it working the way you have but I would like to autneticate the /refresh url alone,
and the server authenticates it giving me a 401, what would be the crendential that I will need to provide for the /refresh endpoint?
http.authorizeExchange()
.pathMatchers("/actuator/refresh").authenticated()
.anyExchange().permitAll().and().csrf().disable();


Validation issue with +249121961467

I have the following mobile numbers:
+543513116713
+522226727438
+542944894250
+249129271988
+249121961467
+249114436643
These are valid mobile numbers, but the library shows that they are a landline!

@anas-aldrees
Thank you for taking the time to improve libphonenumber!

For Argentina and Mexico  phone numbers: +543513116713, +542944894250
and +522226727438:
This is a known issue. Please take a look at the below listed FAQ.
https://github.com/googlei18n/libphonenumber/blob/master/FAQ.md#why-is-this-number-from-argentina-ar-or-mexico-mx-not-identified-as-the-right-number-type

Sudan numbers: +249129271988, +249121961467 and +249114436643
ITU doc says that 12 XXX XXXX phone numbers are landline numbers.
https://www.itu.int/dms_pub/itu-t/oth/02/02/T02020000C40002PDFE.pdf

We have considered 11 XXX XXXX as fixed-line range based on the user report. Wikipedia says the same. ITU do not mention this range. https://en.wikipedia.org/wiki/Telephone_numbers_in_Sudan
Closing this issue as working as intended. Please reopen the issue if you have any official evidence that says these Sudan are mobile numbers. See our
guidelines.


[Question] lit_firebase_auth from git is forbidden?

Not sure if I need to fix or ignore this:

which version should we use?

Lit needs an update to the latest version of all the packages. This will be done soon.

Lit needs an update to the latest version of all the packages. This will be done soon.


chore: Reduce log lines for ICE errors

Fixes #N/A
Description
How was this change tested?
Does this change impact docs?

[ ] Yes, PR includes docs updates
[ ] Yes, issue opened: #
[x] No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>3
Details

19 of 19 (100.0%)  changed or added relevant lines in 3 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.002%) to 79.283%

Totals

Change from base Build<PHONE_NUMBER>1:
0.002%

Covered Lines:
5974

Relevant Lines:
7535

💛  - Coveralls


[5.4] Fix 'Too Many Connections' error during testing using $connectionsToTransact

Terminate user defined database connections after rollback while using the DatabaseTransactions trait.
Note: This bug fix is pointed to the 5.4 branch as the corresponding code doesn't exist in the 5.1 release.

I run into this one all the time. The point where I created a trait that does this (but does so by overriding tearDown by keeping temp variables around to be able to call setPDO(null) on it afterwards).
Never noticed connection had a disconnect method. I quite like this approach. How well does it work when used with the DatabaseMigrations trait?

What causes the too many connections? Obviously this doesn't happen on every test suite. Is adding this going to seriously affect performance of the tests?

Maybe related: https://github.com/laravel/framework/issues/18471

What causes the too many connections?

I think something is holding onto the connection object. Maybe there's a reference cycle that's not being cleaned up?
Thinking out loud: I wonder if running gc_collect_cycles() would fix anything…

… Obviously this doesn't happen on every test suite

Most likely because:

Most test suites use SQLite for testing instead of MySQL
The default concurrent connection count for MySQL is 300 connections
I'd guess its unlikely that there'd be 300+ test cases that all use the database for at least smallish apps.

If you have an application that connects to more than one database (I have one that uses 4 for instance) it makes this problem pop up much, much quicker.

In my case I am using MySql for the testing.
As @thecrypticace suggested my 'max_connections' value is 151.
I have 5 database connections that are created on every request to my API.
I have a suite of 36 tests.
36 * 5 = 180 = 💥
I'm not sure where the default 'mysql' connection is terminated, but upon testing it appears that it is terminated after each test is ran, preventing this sort of issue from occurring if a user is not using the $connectionsToTransact variable. But if you are none of the connections are terminated until after the entire test suite is completed.

@taylorotwell If I increase my max_connections value and run my test suite without my changes the elapsed time, according to PHPUnit, is 33 seconds.
If I run my test suite with my changes it is 31 seconds.
So these changes actually increased performance in my scenario, which makes sense because my database isn't trying to maintain hundreds of connections simultaneously.

I would also think that any proponent of TDD would say that my suite of 36 tests is child's play, not suitable as a true testing solution. In fact the tests in question are only my acceptance tests, this issue would be greatly exacerbated if I include integration tests across components that reference multiple database connections.

I did a bit of testing. I can reproduce the error with this script:
require __DIR__.'/bootstrap/autoload.php';

for ($i = 0; $i < 300; $i++) {
    $app = require __DIR__.'/bootstrap/app.php';
    $app->make(Illuminate\Contracts\Console\Kernel::class)->bootstrap();
    $app["db"]->connection(null)->beginTransaction();
    $app["db"]->connection(null)->rollBack();
    $app = null;

    echo ".";
}

And it appears that gc_collect_cycles(); does not help.

Many thing for the PR! Can also confirm it works.
I feel a bit bad because I was using a custom trait with exactly this changes for years but failed to provide an upstream PR :-/

I am still having this problem in Laravel 5.6.8 with the $connectionsToTransact property in a base test case (with 2 connections) and a mysql database.


KeyVault Full Backup

This would be part of the administration module (#19461)

Resolved as part of https://github.com/Azure/azure-sdk-for-go/issues/19461


Bump Escrow to v0.16.1

Summary
Type of change

Improvement (refactoring, restructuring repository, cleaning tech debt, ...)

Changes
The following changes have been made:

Added #[storage(read / write)]

Related Issues
Closes #98

Closing in favour of #100


Consider changing the name of the default branch from 'master' -> 'default'

... or 'main' or something else. FWIW, we're changing the master to default for the google-cloud-cpp repo https://github.com/googleapis/google-cloud-cpp/issues/4393

+100, thanks for the reminder.
On Fri, Jun 12, 2020 at 2:44 PM Greg Miller<EMAIL_ADDRESS>wrote:

... or 'main' or something else. FWIW, we're changing the master to
default for the google-cloud-cpp repo googleapis/google-cloud-cpp#4393
https://github.com/googleapis/google-cloud-cpp/issues/4393
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/abseil/abseil-cpp/issues/711, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AC7CRX7AJ6CNQD5ZCTEDW6LRWJZSTANCNFSM4N4R5IOQ
.

--
*If you get an email from me outside of the 9-5 it is not because I'm
always on or expect an immediate response from you; it is because of work
flexibility
http://www.inc.com/john-boitnott/how-flexible-hours-can-create-a-better-work-life-balance.html
.  Evening and weekend emails are a sign I allocated some regular working
hours for other things (such as family, gym, friends,...).  And I encourage
you to feel free to do the same.

FWIW, GitHub is working on some changes to make renaming the master branch easier with better support for redirects, etc. More details here: https://github.com/github/renaming/
From that page:

If you haven’t moved yet, we recommend not moving right now, and waiting until later this year. We’re investing in tools to make the renaming the default branch of an existing repository a seamless experience for both maintainers and contributors.

Hey Dan!
As I'm sure you know, this probably isn't as simple as clicking a button or running a few commands. I'm guessing this will break our export workflow in some way.
Fortunately, @dinord is also looking into making some other updates to our export workflow. This is probably a good opportunity to tackle this one as well.

Also, don't use 'default', use main, which seems to be the new "default" :-)


Use Danger to append a checklist to the end of a PR

We'd like to improve visibility of whether someone has tested on a device, or run through the code at all. So, to look at improving this, we're going to try two things:

Making a checklist inside the PR body from Danger on every PR for both the PR author, and all assignees to verify they've double checked - code then app.

Making it easier to get set up with the code locally. Danger can provide a C&Pable way to get the PR running locally or on a device if we get PRs deployable via Emission.

This issue will have what I'd imagine the template to look like appended. See below:

Tested on Device?

[ ] @orta
[ ] @mennenia

How to get set up with this PR?

To run on your computer: Ensure you have hub installed:
git checkout https://github.com/artsy/emission/pull/541
yarn install
yarn ios
yarn start

To run inside Eigen (prod or beta) or Emission (beta): Shake the phone to get the Admin menu.
If you see "Use Staging React Env" - click that and restart, then follow the next step.
Click on "Choose an RN build" - then pick the one that says: "X,Y,Z"

LOVE THIS
does the apphub stuff also do prs? or just what is in master for emission?

Today: only master - it's not unreasonable to do PRs too.

Looking great! Just missing the cd Example && pod install part

Added 👍

I’m actually thinking that maybe we shouldn’t make this dependent on having hub installed, if we’re offering copy-pasteable commands anyways?

could use the git fetch origin pull/ID/head:BRANCHNAME - the PR one is only useful for cross-fork PRs

Fixed by #558


Use new adapter template

To benefit from the updates in architecture and structure we should update to the newer adapter templates structure.
This additionally enables other ioBroker developer to support this more easily

Resolved in fec5227e5fe41847508fb07774ab7b2610298745


Inconsistensy with stage rendering

Now we place stage for documents with amendments/corrigendum and documents without in different places.
For "ISO/IEC 14496-12/CD Amd 4" we have stage after number, but for "ISO/IEC TR CD 20943-5" it's placed before document number.
Should we generate something like "ISO/IEC CD 14496-12/Amd 4"?
Or "ISO/IEC TR 20943-5/CD" instead of "ISO/IEC TR CD 20943-5"?

These are two entirely different cases:
Amd/Cor uses this pattern:
{base PubID}/{supplement PubID}

"ISO/IEC 14496-12/CD Amd 4" means CD stage of "Amd 4" for base document "ISO/IEC 14496-12".
"ISO/IEC TR CD 20943-5" means CD stage of "ISO/IEC TR 20943-5".

The meanings are entirely different, please keep them separate. Thanks.

These are two entirely different cases:
Amd/Cor uses this pattern:
{base PubID}/{supplement PubID}

"ISO/IEC 14496-12/CD Amd 4" means CD stage of "Amd 4" for base document "ISO/IEC 14496-12".
"ISO/IEC TR CD 20943-5" means CD stage of "ISO/IEC TR 20943-5".

The meanings are entirely different, please keep them separate. Thanks.

How URN format should reflect it?
Now URN format don't make difference between amendment stage or document stage
"ISO/IEC 14496-12/CD Amd 4" -> "urn:iso:std:iso-iec:14496:-12:stage-30.00:amd:4:v1"
"ISO/IEC TR CD 20943-5" -> "urn:iso:std:iso-iec:tr:20943:-5:stage-30.00"

This is a good find -- this issue is not addressed in RFC 5141.
However, we can assume the following:

the {base PubID} is always the published one.

This means there is no need to encode the stage of the base document, and that the stage always applies to the Amd.
This is correct:
"ISO/IEC 14496-12/CD Amd 4" -> "urn:iso:std:iso-iec:14496:-12:stage-30.00:amd:4:v1"
"ISO/IEC TR CD 20943-5" -> "urn:iso:std:iso-iec:tr:20943:-5:stage-30.00"


Multiple hosts

HI,
how can I crawler different hosts without creating different crawler instances?
Thanks M.

Im curious about this also. I have attempted to create multiple instances however cannot see a way to kill and instance after a successful crawl.
Appreciate any guidance.

I used
  const crawler = new Crawler("https://www.domain1.com");
  crawler.queueURL("https://www.domain2.com");

I'm also concerned about the crawler hanging, so i implemented a timeout function which stops it after 15 min.
  // Add a time limit for maximal execution
  const timeout = setTimeout(function() {
    crawler.stop();
    clearTimeout(timeout);
    console.warn(`Crawl for ${site.domain} timed out and was aborted!`);
    callback(count);
  }, 900000); // 15 minutes

Hi everyone! Seems like there are two different things that you folks are trying to accomplish.
If you're trying to crawl multiple domains with one crawler instance, have a look at the crawler.domainWhitelist setting.
If you're trying to launch multiple crawler instances, then there's no one true way, but I have in the past built a system where a mother process would spawn child processes and each one crawler a different domain.
I'll close this for now, but let me know if you continue having trouble @mdalmazzi


URGENT: CAD won't load after last update

What version of Node.js are you using?
16.13.1
What version of npm are you using?
Latest
What operating system are you using?
Windows Server 2019
What version of SnailyCAD are you currently using?
Latest
Describe the Bug

I'm suddenly getting a BAD REQUEST error when I try to load CAD after the most recent update. (Method Automatic)
Expected Behavior
To load CAD as normal
To Reproduce
No response

Remove the packages/client/.next folder. Then run yarn turbo run build before starting the CAD.


Error when reordering plugin sorter

🐛 Bug
When I tried to drag and drop plugins for get_reader in the plugin sorter, I got the following error:
AttributeError                            Traceback (most recent call last)
~/projects/napari/napari/_qt/widgets/qt_plugin_sorter.py in dropEvent(self=<napari._qt.widgets.qt_plugin_sorter.QtHookImplementationListWidget object>, event=<PyQt5.QtGui.QDropEvent object>)
    227         """
    228         super().dropEvent(event)
--> 229         order = [self.item(r).hook_implementation for r in range(self.count())]
        order = undefined
        self.item = <built-in method item of QtHookImplementationListWidget object at 0x17c5d7d30>
        global r.hook_implementation = undefined
        global r = undefined
        global range = undefined
        self.count = <built-in method count of QtHookImplementationListWidget object at 0x17c5d7d30>
    230         self.order_changed.emit(order)
    231

~/projects/napari/napari/_qt/widgets/qt_plugin_sorter.py in <listcomp>(.0=<range_iterator object>)
    227         """
    228         super().dropEvent(event)
--> 229         order = [self.item(r).hook_implementation for r in range(self.count())]
        global order = undefined
        global self.item = undefined
        r.hook_implementation = undefined
        r = 4
        global range = undefined
        global self.count = undefined
    230         self.order_changed.emit(order)
    231

AttributeError: 'QListWidgetItem' object has no attribute 'hook_implementation'

thanks for the report @jni.  I'm unable to recreate at the moment... but I can see how this might potentially happen if something independently added an item to QtHookImplementationListWidget.  We might be able to patch it just by using getattr(..., None)... but i'd feel a bit better about it if i knew exactly how a QListWidgetItem got added without getting that hook_implementation attribute (which should have happened here)

... aaaand I can't reproduce either. 🤦
A bit more context, though I don't know how much it would help:

I installed napari-bioformats
I tried to open a .nd2 file
The builtins keep higher priority because the author of napari-bioformats has no faith in their own library. 😜
The builtins don't error out gracefully, so I was getting annoying error messages (though eventually bioformats picks it up)
I tried to reorder the plugins.

Unfortunately I can't remember whether I tried to drag plugins down or bioformats up. ALSO, and this probably is relevant, when I fiddled around some more there turned out to be a blank item in the list — ie dragging way down left a gap in the list between the last item and the newly dragged item.
Perhaps recapitulating all of the above in a clean env would work... 🤷

there turned out to be a blank item in the list

Ohh!  Yeah that's helpful.  Thanks for the details, will dig.
Also, we should definitely fix the annoying error message independently

Is this issue still a problem?   I just created a fresh environment, installed napari from github, conda installed napari-bioformats, and found a sample .nd2 file to open.  It worked for me!  I saw that the bioformats reader was also listed at the top when I looked at the plugins list.  I moved things around just for fun and still no problem.  Let me know I should keep digging here.  I also didn't see any error messages.

I can't reproduce either. I'll close and reopen if I ever run into it again.