Add teleportOrientation(?) for rigidbody

Currently rigidbody.teleport requires you to set a position if you want to change the orientation. We should  provide a method if you only want to change the orientation.

We could add a few methods like setPosition, setRotation on the rigidbody.

Yes,I think so!That will be a greater way to change the orientation in the future.

Perhaps setPosition and setRotation on rigidbody might confuse as being same name as on Entity. Different naming might help to distinguish behaviour and relevance to entiyty or rigidbody.

The 'nullification' (is that a word) of setPosition/Rotation when adding a dynamic rigid body component has been a source of confusion and endless support queries since we implemented the API. Can we make look again at whether we can solve that problem? The reason we introduced this was because we didn't want the entity to know about the rigidbody component. But perhaps we should look at this again...

@willeastcott you mean to make setPosition and setRotation on Entity, to actually change rigidbody instead? Perhaps that would dramatically simplify the whole world of working with physical objects, indeed.

I was thinking more that updating the transform of the entity via the standard functions could set some flag which the rigidbody could query and then handle. So the entity still wouldn't need to know about the rigidbody component. But I'm sure I would have thought about this before so there's probably a problem with this.

That probably wont work, as setPosition and setRotation, and other methods should have immediate effect, rather than delayed.

Do it with events? The rigidbody component could register an event on the entity if the position or orientation is updated and respond accordingly?

Could, but feels like an overhead. I would rather check if entity has method _syncTransform, and if does, it would call it every time transform has been changed.
Then rigidbody would define that method when component is added and would remove it when removed.
That way entity does not need to know about rigidbody, only about possible _syncTransform. Overhead is minimal here - single if to check if method is defined.
Events would have too much of an overhead to deal with, as transform changes - is very-very often thing in update loop.

Yeah, that'd work (for now). It's internal so we can always change it later if necessary.


Install instructions don't work for Ubuntu 21.10 (No 21.10 debs are built)

The guidelines at https://docs.microsoft.com/en-us/cli/azure/install-azure-cli-linux?pivots=apt don't work on Ubuntu 21.10 because no 21.10 repository exists on https://packages.microsoft.com/repos/azure-cli/dists/
Is it possible to get these added to the build chain?
Thanks!

Could you add a symlink?


MQTT nodes shows configuration error even when it's correct

I have an MQTT broker running with mosquitto. This server only allows connection from publishers and subsrcibers by a username/password and a CA certificate. This is all set up and running correctly!
When using the cli tools you would connect to the broker somehow like this:

mosquitto_sub -p 8883 -u USER -P PASS --cafile /etc/mosquitto/ca.crt -t 'topic/#'

Now I wanted to use it this way in node-red too. In general no problem. I added the CA file under mqtt node > mqtt-broker config > tls-config and added the path /etc/mosquitto/ca.crt into the field Certificate.
After deploy this settings everything workes fine, node-red can now publish to the broker. But the node, incoming as well as outgoing, show an configuration error (tiny little triangle on top). The node sill want to have the field Private Key to be filled up too. But this is wrong. There is no key file needed in this setup.
Because of this, every time deploying a warning comes up, saying The workspace contains some nodes that are not properly configured, what's not true ...

The certificate field is for a client certificate, not the CA certificate
You should place the CA Certificate in the CA Certificate field;

Yes, I was thinking that too first! But entering the path to the CA there, causes the node to not connecting properly. Then the node always shows disconnected below and no error message in debug sidebar. So I think there could be something else wrong then with the node ...

That said and to confirm the situation:
I have no problems using the CA certificate file with the CLI tools and I got even MQTT.fx running with just that CA file. So it should be confirmed that there is no configuration error with the broker or the cert file. I only got problems with the node-red mqtt nodes connecting ...

The problem becomes a bit stranger too. After a restart of the node-red service, the configuration error showing on the nodes will be removed and deploy has no error message. But when going to the nodes -> mqtt-broker -> tls-config the field show the error as before.
So as said, it's still running, but there is no error message anymore, beside the error in the config dialog. Bit inconsistend ...

I am having a similar issue with Node-Red on Windows. When I use the CA Certificate field and enter a correct path to my ca certificate file I can't connect to the broker. The node says "Disconnected". If I leave the field blank I get the configuration error message.
How ever...
I managed to get it to work by entering dummy text into the ca certificate field ("anytext"), all other fields left blank. The result is that the connection works and no configuration errors. Debug shows Error: ENOENT: no such file or directory, open 'xxxxxx'. I think this works since my mqtt server certificate is signed by a trusted authority (DigiCert) and installed in the operating system.
Very confusing!

experienced this behavior after updating to 0.17.5 - haven't had an issue with 0.16.2
@maurert thanks for the workaround

Which TLS version is Node-Red MQTTS able to use? Mine is configured for TLS1.2, but I am unable to get Node-Red NQTT node to connect to my broker.


Graduate efficient watch resumption to GA

Ref https://github.com/kubernetes/enhancements/issues/1904
/assign @sftim

/unassign
I'm happy for to SIG Release Docs team and SIG API Machinery to collaborate on getting this one reviewed. My role so far was just to point out that an update was needed.

/assign @deads2k

/assign @kbhawkey

/assign @mehabhalodiya

/approve
The upstream change (kubernetes/kubernetes#10694) is now in.

/lgtm


AprelTech.SilentInstallBuilder version <IP_ADDRESS>

[ ] Have you signed the Contributor License Agreement?
[ ] Have you checked that there aren't other open pull requests for the same manifest update/change?
[ ] Have you validated your manifest locally with winget validate --manifest <path>?
[ ] Have you tested your manifest locally with winget install --manifest <path>?
[ ] Does your manifest conform to the 1.0 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

Please modify already existing manifests than reverting commits and causing merge conflicts.


Rewrite simulation code generation and execution in the WeDo style

Is your feature request related to a problem? Please describe.

We have a couple of open issue in simulation execution: #1116, #1053, #1008, #1153, #1003, #1002, #981, #903
Describe the solution you'd like
Rewrite the code generation and execution like we did it already for WeDo (not used for simulation but for steering/triggering WeDo via bluetooth). With this stack based way we expect to get rid of a couple of issues that we have with the old simulation. Also some issues we cannot fix with the old way.

Additional context

see and get more information from the WeDo intepreter project

see also #215 for a collection of errors

all errors mentioned here are now linked in #215. This ticket is closed.


BUG in the new PPO trainer

System Info
In the init function of the new ppo trainer (renamed from ppo trainer v2), it says
 if ref_policy is policy:
            raise ValueError(
                "`policy` and `ref_policy` cannot be the same object. If you want `ref_policy` to be the "
                "same as `policy`, you must mass a copy of it, or `None` if you use peft."
            )

But actually, the ref_policy cannot be None. Otherwise, it will lead to an error when later in the init function  remove_dropout_in_model() is called.
Information

[X] The official example scripts
[ ] My own modified scripts

Tasks

[X] An officially supported task in the examples folder
[ ] My own task or dataset (give details below)

Reproduction
See the description above
Expected behavior
peft support.
Checklist

[X] I have checked that my issue isn't already filed (see open issues)
[X] I have included my system information
[X] Any code provided is minimal, complete, and reproducible (more on MREs)
[X] Any code provided is properly formatted in code blocks, (no screenshot, more on code blocks)
[X] Any traceback provided is complete

Hi...I think we need to create a copy of the policy model using create_reference_model() function....is it ??
I'm facing another problem in new PPOTrainer()...according to documentation  we need to pass 'module' unlike the previous version(HF PreTrainedWrapper ).
How to get the HF pretrainedWrapper models and pass to PPOTrainer() as module

I'm hopeful that https://github.com/huggingface/trl/pull/2344 will address this issue! :raised_hands:

I turned to v0.11 as a bypass🤣

May I ask which version you are using?
As far as I know, the current version (0.12.1) does not support PEFT for PPOTrainer yet. However, if you want to try PEFT support, you can consider using pip install git+https://github.com/huggingface/trl.git to experiment with it. :muscle:

Thank you for your reply.
I am using 0.12.1.
I will try pip install git+https://github.com/huggingface/trl.git

I turned to v0.11 as a bypass🤣

Does 0.11 support PEFT?


"Vary (Region)" Inpainting Feature

Is it possible to use "Vary (Region)" feature via API? Select specific area and vary that area with new prompt.

looking for this as well

Looking forward to providing this feature

Are there other solutions？

+1


samples: pm: fix init priority after init level change

Moving from APPLICATION level to POST_KERNEL and keeping both parent and
child on the same level is causing problems, so fix this by putting them
on different priorities in POST_KERNEL.
Also, this sample runs fine in qemu, so make it the integration
platform.
Fixes #62772
Signed-off-by: Anas Nashif<EMAIL_ADDRESS>

How does a manually created device have parents/children? It has no links to devicetree.

How does a manually created device have parents/children? It has no links to devicetree.

Parent/child may not be the best words, but the sample exercises two devices where the child needs another device active (parent) so it gets/puts a reference to the parent in its logic, though there is not dependency in device tree it shows one manually created device depending in another.

The test could have both drivers initialized at the same level since they are used only in main(), but I rather have an error message and them in different levels.


Missing columns

Hi I have the following issue:
when I load a ndax file in a dataframe, it doesn't show all the columns of the original ndax file.
for example I'm missing the specific discharge capacity.

Hi @ecalandrini , many of the columns you see in BTSDA are not actually stored in the ndax file but are being calculated on the fly. The goal of NewareNDA is to efficiently read the files without getting into post-processing. If there is another field you need, it shouldn't be too hard to calculate yourself.

thank you for your answer!


[Bug]: Trying to access response.status() right after the navigation can cause a TypeError "Cannot read properties of null (reading 'status')"

Minimal, reproducible example
'use strict';

const puppeteer = require('puppeteer');

(async () => {
  const browser = await puppeteer.launch({
    protocol: 'webDriverBiDi',
    headless: false,
  });

  const page = await browser.newPage();

  await page.setRequestInterception(true);
  page.on('request', async request => {
    request.continue();
  });

  const response = await page.goto(`https://developer.mozilla.org/en-US/`);
  console.log(`status=${response.status()}`);

  await browser.close();
})();

Background
No response
Expectation
That the returned response object is valid and properties can be accessed.
Reality
The response is undefined unless await is used in the interception handler for request.continue(). Note that all Puppeteer docs do not list await and when using Firefox it also works with out await.
Puppeteer configuration file (if used)
No response
Puppeteer version
22.13.1
Node version
22.2.0
Package manager
npm
Package manager version
10.7.0
Operating system
macOS

@OrKoN can you please take a look?

So request.continue() returns a Promise. As such I would expect that using await would wait for it. But actually it is not working for Chrome even when I've mentioned it before. Not making the callback an async function fixes the problem.

Note that this also fails with the CDP protocol enabled.

@whimboo It does not fail with CDP for me. It seems that it might be the issue of early navigate returns since there are some fragment navigations happening on that page. It seems to work with https://wikipedia.org

I think it make it consistent we would need to land https://github.com/puppeteer/puppeteer/pull/11929 but it had some blockers on both chromium-bidi and Firefox side.

I see. So we probably should get this fixed as part of the next chunk of work.
For my cross-browser example script I can actually use https://addons.mozilla.org which works fine as well.

Looking at this more, it is actually more of the opposite case, the fragment navigated is received right after the real navigation. So there are probably two issues:

In Puppeteer, we wait for the latest navigation so need to unblock improvements like https://github.com/puppeteer/puppeteer/pull/11929
In chromium-bidi, the history update counts as a fragment navigated, and it looks Firefox is correctly not sending it, that is why it works.

So we first need https://github.com/w3c/webdriver-bidi/pull/740 and then chromium-bidi needs to be updated to emit the new event instead.

Right, for now, I think we can deprioritze and document this edge case since our API allows returning null for some cases so technically one needs to check if the result is null.

@whimboo did you investigate how exactly the page is redirecting after the initial navigation? I assume it is via history but after the discussion on Matrix is looks like there could be multiple redirects. I want to add a test for this situation.

I see the event '{"type":"event","method":"browsingContext.fragmentNavigated","params":{"context":"092346F42BC26DAB7C323B73DA892FC7","navigation":"ce26eab6-c710-4793-b248-5dd444803907","timestamp":1721290646618,"url":"https://developer.mozilla.org/en-US/"}}' which could be either a fragment navigation or a history update

The historyUpdated event would have been really useful, and maybe we need to attach a stack trace to it 😅

Interestingly, if I open with DevTools on, there are no same document navigations and the script succeeds.

When I use Firefox with MOZ_LOG="BCWebProgress:5" logging enabled I can see:
[Parent 30551: Main Thread]: I/BCWebProgress OnLocationChange({isTopLevel:1, isLoadingDocument:1}, <null>, https://developer.mozilla.org/en-US/, LOCATION_CHANGE_SAME_DOCUMENT) on {top:1, id:d, url:https://developer.mozilla.org/en-US/}

So this looks like some history API usage given that no HASH_CHANGE flag is set. Note that we do not yet have a flag or history API usage but would consider adding one once the required HTML spec changes are done.

@whimboo could you find where it is coming from on the site?

I am not able to reproduce with replaceState or pushState in atest.

found where it is coming from, it seems to call replace state multiple times.

I am still not able to replicate it in the test :/

When I set breakpoints to those two replaceState calls the debugger never pauses. Only for the one entry in main.js it sometimes pauses. @jdescottes will have a closer look given that he is more familiar with the DevTools features.

As far as I can tell, the calls are all coming from react-router. FWIW, I can also replicate the issue when testing with Chrome, I think I am testing with the regular Chrome release. @OrKoN are you testing on a specific channel ? Is the test passing successfully for you on Chrome?

I am testing with stable and I am able to reproduce the issue with Chrome on the live website but not in a test: https://github.com/puppeteer/puppeteer/pull/12777

I was able to reproduce if I would wait for network idle and not only the load event.


Columns don’t show correctly on Outlook 17

The layout now seems to break on the latest Outlook.
Outlook 17 treats the responsive columns as if they are on mobile. So are displayed below each other at all times. Rather than side by side.

Hi @jonwinstanley, I might recommend checking out Husk as an updated version of Antwort. I baked in more than a dozen fixes to common email client issues and if it doesn't natively fix the Outlook 17 issue then open an issue on Husk's github page and I'll take a look at it. Cheers


Support for shorter dependency descriptors

Briefly discussed at Scala Up North with @MasseGuillaume.
It would be cool to allow users to specify a dependency like typelevel/cats, for "org.typelevel" %% "cats" % "latest.release" (with support for latest.release to be added to coursier too). The scala index could be used to get the module org and name "org.typelevel" %% "cats" from typelevel/cats - for public repositories at least (they need to be published on Central too, I guess).
In particular, that would allow to seamlessly launch applications like
$ coursier launch lihaoyi/Ammonite

Support for only the project name (just cats or Ammonite) could be added too, like
$ coursier launch Ammonite

Lastly, for projects publishing several modules, this kind of syntaxes could be supported:

http4s/http4s->http4s-circe for org.http4s:http4s-circe_2.11:latest.release (http4s/http4s resolved to "org.http4s" %% ... with the scala index, and the part after -> being interpreted as a specific module of it),
or http4s->http4s-circe for org.http4s:http4s-circe_2.11:latest.release (like before, with just http4s resolved to "org.http4s" %% ... too),
which would allow things like

$ coursier fetch http4s/http4s->http4s-circe
$ coursier fetch http4s->http4s-circe

To handle the same syntax for private repositories (e.g. in corporate settings), we could either:

get those infos directly from repositories (as suggested by @djspiewak), or
crawl a repository and get those infos from its metadata.

Getting infos from repositories would require launching SBT, and have it output the relevant things (org / name for each published sub-project). Which may be a bit cumbersome, as it requires launching SBT for each project we want to index.
Crawling a repository may only work for Maven repos (via the SCM infos of the POMs), not for Ivy ones.
As getting those infos is a bit cumbersome no matter what, these could fetched only from time to time, and made available to possible users, by putting those in a single JAR and publishing it to a repository. That way, users would just have to reference the repository and module of the index. This could possibly be made so by some config files under ~/.coursier. These JAR with the infos would be cached like any JAR, and could be updated from time-to-time via the already existing TTL mechanism say.

Instead of trying to automatically figure out maven coordinates with for example scaladex, would it be possible to support configuration for aliases? For example,
$ cat ~/.coursier/coursier.conf
aliases = [
  {
    name = "scalafmt",
    groupId = "com.geirsson",
    artifactId = "scalafmt-cli",
    main = "org.scalafmt.cli.Cli",
    jvmOptions = "-Xss8m"
  }
]

Then you could run
sudo coursier bootstrap --standalone scalafmt -o /usr/local/bin/scalafmt
# OR with hypothetical install/upgrade commands
coursier install scalafmt # puts it in ~/local/bin or wherever you want according to coursier.conf
coursier upgrade scalafmt # if artifact is on maven, use latest version in maven-metadata.xml
coursier upgrade scalafmt 1.0 # manually provide version, this is unnecessarily complex with homebrew

I imagine that it might be possible to create a decentralized system for sharing coursier.conf aliases in a similar way as homebrew works.
coursier add-alias olafurpg/scalafmt
# fetches from olafurpg/coursier-scalafmt,
# similar to homebrew tap olafurpg/scalafmt

There could be a centrally managed collection of aliases in coursier/aliases. However, I believe the decentralized model would more scalable. It's annoying to wait for PR approval when you're publishing your first cli app.
PS. I have given up on supporting homebrew for scalafmt https://github.com/scalameta/scalafmt/commit/0cf3b79be32ed084875e167a52af31272c577570 I really believe coursier offers a much more better way to share and consume cli apps on the JVM. I'm happy to help contribute on this front.

Something along those lines should totally be done (after 1.0 final is out). This is the kind of things that were initially discussed at Scala Up North - @djspiewak was interested in that kind of way of handling aliases IIRC.
brew-like repositories look fine. This could also handle private repositories (both GitHub and Nexus ones, for the aliases and the artifacts).
The scaladex support could be given a lower priority and / or be triggered by a --scaladex flag. (The scaladex handler could also be made more interactive at the same time, like offering to choose among the scaladex search results...)

The scaladex support could be given a lower priority and / or be triggered by a --scaladex flag. (The scaladex handler could also be made more interactive at the same time, like offering to choose among the scaladex search results...)

I agree.
I was thinking about the syntax of the configuration. It might be beneficial to support something lightweight that handles the most common cases (published to maven, no custom jvm options) and something more verbose but flexible. Example
aliases {
  scalafmt =<EMAIL_ADDRESS># lightweight
  scalafmt-nightly { # verbose, but more flexible
    org = "com.foo"
    artifact = "bar"
    resolver = "bintray:scalameta/maven"
    password = ${?NEXUS_PW}
  }
}

Initial issue fixed by https://github.com/coursier/coursier/pull/385.

Would it be possible to host the aliases/metadata in the original repo? That is, when users run coursier install scalameta/scalafmt that would fetch necessary metadata from a .coursier file in the scalameta/scalafmt repo. We are experimenting with a similar approach in https://github.com/densh/scala-native-cli (installing from .scalanative files)

@olafurpg I guess that could be added, yeah. The scaladex support works this way (fetches / caches an intermediate file, that contains the coordinates of the actual dependency).

It would be nice as the tooling author to have the ability to specify the exact version, org, artifact, main class and optionally jvm options. coursier install scalafmt currently fetches scalafx and then fails to find a main class.
So far, however, it's been working fine to generate the full coordinates in CI and let users copy-paste the installation command from the docs http://scalameta.org/scalafmt/#Coursier

coursier launch scalafmt fetches scalafx because it's the first entry that the scaladex returns:
$ curl https://index.scala-lang.org/api/search\?q\=scalafmt\&target\=JVM\&scalaVersion\=2.11.11
[{"organization":"scalafx","repository":"scalafx",
...

Yeah, I know 😞 The search relevance will hopefully get better soon https://github.com/scalacenter/scaladex/issues/389#issuecomment-308341744
Even if scaladex search relevance improves, I'm not sure if it will be able to handle tricker cases like custom main like here http://scalameta.org/scalafmt/#Nailgun

weird this was supposed to be fixed: https://index.scala-lang.org/search?q=scalafmt.
let me see what's wrong.
I like olaf's approach too. the only issue I see is this can get out of sync. one can release a new version an forget to update the meta file.

The meta file can be generated on sbt load to keep it in sync.
Automatically finding the right artifact from scaladex is quite challenging, for example in scalafmt it should be the scalafmt-cli module (out of ~3-4 modules) and main org.scalafmt.cli.Cli (out of two mains, can't be auto-detected). I admit it's a bad idea to have two mains, but it would be nice that if it wasn't a problem.

As described in Alex's ScalaDays talk this now exists, using as the central source of descriptors the https://github.com/coursier/apps repo but also the ability to add your own (ala "brew tap").


Feature Request: Fab button

Since bootstrap 4 is targeting mobile, Fab button should be the first component to be included. Angular Material has so many examples showing the utility of Fab button:  https://material.angular.io/components/button/examples

They're buttons with different transitions—we're not going to implement anything like this in Bootstrap.


Add Windows standalone binary

This pull request adds:

a script for building a standalone binary on Windows
minor code changes to accommodate running aqt as a standalone binary
workflow for building and testing the standalone binary on windows
workflow for automatically building and uploading the standalone binary when a new release is created

There seems many code duplication among .github/workflows/build-standalone.yml with other existent script.(You may copy)
Could you manage a standalone executable generation and test with  github actions matrix variations?
Here is an just idea but we can put  matrix variable artifact: [standard, binary] and switch on/off with actions if: clause and/or python if condition in the script. You can put binary only for windows using exclude/include clause of actions.

The reason I added this is because there are a number of setup scripts for build environments on Windows which require QT.

Python is installed on most CI cloud services, but when you need to setup your own build servers, it will be cumbersome.

IMHO a standalone binary is not needed. Python would be needed by end users anyway, sooner or later since lot of tools now depend on python, including build tools such as meson. So end users should just install the distro of python that seems to be matching their needs better and not to install bloated bundled unupdateable versions of python.

IMHO a standalone binary with bundled python is not needed. Python would be needed by end users anyway, sooner or later since lot of tools now depend on python, including build tools such as meson. So end users should just install the distro of python that seems to be matching their needs better and not to install bloated bundled unupdateable versions of python.

There are a number of problems with this:

On Windows, actually locating Python is not straightforward; you don't actually know that python will be on the PATH and not in some god-forsaken Conda environment or what-have-you,
PIP's approach to dependency management means that installing ANY package with a frequently used dependency could potentially break your environment
It's not strictly necessary, and for a bespoke script for installing a QT version where aqtinstall may be a temporary tool, installing Python too is overkill.

There are a number of problems with this:

IMHO, It seems that the genuine Qt installer is best for you. It doesn't request a python, single binary, and works well with Windows GUI environment. It also provides an automation mechanism through Qt scripting (but I don't know well).
This abandoned PR (https://github.com/miurahr/aqtinstall/pull/251/files) and discussion on a closed issue (https://github.com/miurahr/aqtinstall/issues/236) might give you some hint (see install-qt.qs file in PR).
Even though my above comment, I'd like to add a binary version of aqtinstall distribution,  @nikitalita  suggested, on github release, because it seems not harm for another artifacts, and @nikitalita suggest a release automation on github actions.

On Windows, actually locating Python is not straightforward; you don't actually know that python will be on the PATH and not in some god-forsaken Conda environment or what-have-you,

Easily solved by installing everything into the global environment and adding the binary from conda distro into %PATH%. If some program bundles own python, it is their problems to solve.

PIP's approach to dependency management means that installing ANY package with a frequently used dependency could potentially break your environment

Solved by updating all the broken packages to their latest versions, where incompatibilities are fixed. If they are not fixed, then it is not the latest version and the latest is the one with a patch fixing the incompatibilities landed/rebased over it :)

aqtinstall may be a temporary tool, installing Python too is overkill.

One still have to install it ... most of software is installed by just unpacking it. One still has to unpack code in order to run it locally (or one can use cloud where everything is installed and unpacked by cloud owner).

There seems many code duplication among .github/workflows/build-standalone.yml with other existent script.(You may copy)
Could you manage a standalone executable generation and test with github actions matrix variations?
Here is an just idea but we can put matrix variable artifact: [standard, binary] and switch on/off with actions if: clause and/or python if condition in the script. You can put binary only for windows using exclude/include clause of actions.

Ok, this is done.

LGTM.

Does v2.0.0rc4 is a status the PR intended?
It just have an exe file in download list.
Why not explain what it is in README?

Yes, that is intended; every time a new release is created, it will build and upload a new standalone release artifact, which is just the bare exe.
Do you want it to be in a zip with a README in it instead?

I think the bare aqt.exe is exactly what we need in the download list.
However, we definitely need to add a section to the README, probably in the installation instructions, that discusses where to find aqt.exe and why you might want to use it instead of installing via pip.
Additionally, I think it may be useful to offer a continuous release, like the one from linuxdeployqt. To download the most current version of linuxdeployqt, all you have to do is curl https://github.com/probonopd/linuxdeployqt/releases/continuous/linuxdeployqt-continuous-x86_64.AppImage. The link never changes, so you never have to update your CI code to point to newer releases.

Additionally, I think it may be useful to offer a continuous release, like the one from linuxdeployqt. ...

See https://github.com/miurahr/aqtinstall/pull/397#discussion_r710540102 .


End of life for .NET Core 1.0 / 1.1 (project.json)

.NET Core 1.0/1.1 reached end of life and went out of support on 27 June 2019.
Support for project.json should be removed.
We would like to remove it from OmniSharp
cc @akshita31 @rchande

project.json is also used by old school PCL projects along with a .csproj file. Do we want to remove both?

we never did anything special to support that in OmniSharp, has it ever really worked?

I don't know. I only brought it up because back when Dustin added the 'project.json is deprecated' message, we got complaints from folks with PCL projects since those are not deprecated. For this new effort maybe they can be ignored.

Could you guys look at the telemetry to determine how much project.json is used?
An alternative approach would be to extract it from OmniSharp and make it a plugin (ala Razor) that users can opt into.

We only keep telemetry going back a couple of months, but in that time I see 0 instances of projects targeting .NETCore 1.0. I think it's safe to remove support.

I am also OK with removing project.json support.

This is done.


fix(balancer) protect against empty upstreams_dict on eventual

Summary
When using "eventual" worker_consistency, get_all_upstreams() may be called before any balancer object is created. This is not an error, so we should return an empty table instead of nil.
Fixes the following error:
2020/07/10 15:44:48 [error] 215#0: *5954 lua entry thread aborted: runtime error: /usr/local/share/lua/5.1/kong/runloop/balancer.lua:662: attempt to index local 'upstreams_dict' (a nil value)
stack traceback:
coroutine 0:
        /usr/local/share/lua/5.1/kong/runloop/balancer.lua: in function 'get_upstream_by_name'
        /usr/local/share/lua/5.1/kong/runloop/balancer.lua:683: in function 'get_balancer'
        /usr/local/share/lua/5.1/kong/runloop/balancer.lua:1101: in function 'execute'
        /usr/local/share/lua/5.1/kong/runloop/handler.lua:870: in function 'balancer_execute'
        /usr/local/share/lua/5.1/kong/runloop/handler.lua:1242: in function 'after'
        /usr/local/share/lua/5.1/kong/init.lua:761: in function 'access'
        access_by_lua(nginx-kong.conf:88):2: in main chunk, client: <IP_ADDRESS>, server: kong, request: "GET /one HTTP/1.1", host: "localhost:32781"

Issues resolved
Fix #6302

This only happened on a 200 rps stress test scenario whilst updating a upstream every second.

I just rebased the branch on last master. Let's merge this when CI is green.

no clue why Travis CI is failing but GitHub actions is not

When using "eventual" worker_consistency, get_all_upstreams() may be called before any balancer object is created. This is not an error, so we should return an empty table instead of nil.

based on feedback on #6302 this will just make the balancer return 503 instead of 500 because here https://github.com/Kong/kong/blob/fix/balancer-empty-upstreams-dict/kong/runloop/balancer.lua#L672-L675 we will have an empty table but nothing in that table so upstream_id will be nil (no upstream by the name, so instead of invoking the ring-balancer we will do a DNS lookup)...

we need to further investigate this... probably will be solved in the upcoming eventual balancer refactor but we still need to determine the root causes of the issue

As this is not the solution to the issue, I'm closing this PR. Thanks, @murillopaula!


Feature/teku integration

https://app.clickup.com/t/2645698/DEV-5909
DEV-5909

Note: this PR only includes support for Teku beacon client - we're still waiting for input on how do we want to manage validator keystores


http: Fix CVE CVE-2023-44487

Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

should we document the stats in docs/root/configuration/http/http_conn_man/stats.rst? I need to blame to find this commit to get more sense on http.downstream_rq_too_many_premature_resets

Hi,
Can someone please explain/confirm that in case of max_requests_per_io_cycle when connection is mentioned in the documentation than what is meant there? TCP connection?


LFS-426 / LFS-467: Show the subject's hierarchy in the subject selector table

Jira link.
Some of this code has already been included in #229 because I confused the two. This includes changes from the rework in #226 so it's based off of it as well.

This problem may be caused by 426-458, but either way it is only apparent once the subject's hierarchy is shown in the subject selector table. I can make a subject and create its parent. When I open the modal again, I can see that the parent has been created, but the child shows "No parents" in its hierarchy.

This has now been fixed in #226, so it should be fixed here as well.


Adds Mode

Coverage remained the same at 100.0% when pulling d9892ea31f56146ad77a5be2de2810c9699d9186 on feat/mode into 8efcf5b0a74a0dabbfb5d72838d42e7cf7248036 on master.


Update hosts information

Hi!
I am trying to use the API with pylair in order to modify host information but I don't see any example about how to do it. Is there a way to update/modify host information (for example statusMessages) using the API? and to delete hosts/services/etc ?
Thank you.

hi @X-C3LL. You essentially modify a dict and then call import project. Maybe this will help? https://github.com/lair-framework/drone-smbversion/blob/master/drone-smbversion.py
You can not currently delete hosts and services. Maybe checkout the browser scripts.


feat(advertise): use the website QR Code

In the footer, also use a URL that contains the analytics tags.
closes #37
Screenshots

On my screen:

On my screen:

what is your browser (I guess you are on windows)? do you use browser zoom?

@assynour I think I fixed the problem in 5637b79.
Tested on Ubuntu with Brave, Chrome, Firefox.

@assynour I think I fixed the problem in 5637b79. Tested on Ubuntu with Brave, Chrome, Firefox.

Tested on Windows with Chrome, Firefox, edge ✅


aria hide summary list action text if visually hidden text is set

Currently the summary-list component offers a visuallyHiddenText property to add hidden text to action links for use with screen readers, the only problem is it is designed on the assumption that the text will follow on naturally from the action text. While fine in English, the gramatical order of the sentence may be completely different once translated - where a 'change' verb could be in the middle of a sentence rather at the beginning, or when written as sentence may be a completely different word from that which you'd use as a singular call to action.
Because of this I currently have locales files full of spans which I'm passing to the html text prop, which is a bit messy.
With this pull request I've refactored the component to wrap the normal action text in an aria hidden span if visually hidden text is set, so you can use entirely separate pieces of content for both sighted and screen reader users.
The only downside is it would be a breaking change as you'd have to refactor your use of the component from:
{
  actions: {
    items: [
      {
        text: "Change",
        visuallyHiddenText: "name"
      }
    ]
  }
}

to
{
  actions: {
    items: [
      {
        text: "Change",
        visuallyHiddenText: "Change name"
      }
    ]
  }
}

@gunjam Thanks a lot for your work on this 🙌 It looks like this would be a breaking change for our users. I've added this to our team triage next week so that we can discuss how to best proceed.

@gunjam As this would be a breaking change we're not able to merge this right now. We would like to look at this but will have to wait until we release GOV.UK Frontend 4.0 which is not yet imminent. We're going to close use this PR as it's going to fall behind but we'll use it as the basis for  exploring a solution when working on 4.0 fixes.
As you mentioned you can currently get around this by including the content with action.html although it's not an ideal solution.
Are you happy to create an issue about this which we can assign to the 4.0 milestone or shall I do this on your behalf?
Thanks again for working on this.

@gunjam it can be dangerous but have you considered using aria-label on the anchor?
{
  actions: {
    items: [
      {
        text: "Change",
        attributes: {
            "aria-label": "Change name"
       }
      }
    ]
  }
}

I spoke to @gunjam on Slack and they said that it's OK to 'shelve' this for now given there's workarounds but that we should consider this sort of thing when looking into translations for example Welsh support.


Change GUI colors, icon and minor adjustments

Changed color scheme of GradPad
Changed GradPad icon

Minor adjustments:

Command box
Borders
Scroll bar
Status bar

GradPad default view:

GradPad fullscreen view:

Closes #65

Codecov Report

Merging #66 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master      #66   +/-   ##
=========================================
  Coverage     71.94%   71.94%
  Complexity      377      377
=========================================
  Files            69       69
  Lines          1155     1155
  Branches        111      111
=========================================
  Hits            831      831
  Misses          294      294
  Partials         30       30

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0f8c638...d284441. Read the comment docs.


Feat: add Bogo Sort

Add file bogo_sort.nim within a new sorts directory, includes tests and runnableExamples

Please run nimpretty on your file.

Does your editor remove the newline at the end of the file? My nimpretty (version 0.2, the one shipped with Nim 2.2.0 by choosenim) adds a newline at the end.

Does your editor remove the newline at the end of the file? My nimpretty (version 0.2, the one shipped with Nim 2.2.0 by choosenim) adds a newline at the end.

No, my bad I took out the newline. I ran nimpretty again and it should have the newline now


MCMCDistributed() not working properly - only worker 2 is sampling

Hi everyone,
I am currently trying to sample from a posterior distribution using the MCMC methods implemented in Turing.jl, however to speed things up I'd like to use the MCMCDistribution() functionality which seem very convenient. The problem is, whenever I use it:

The packages imported (with the using and include keywords) are not shared between the workers, so I have to manually pass the relevant functions to a "wrapper function" (this is not a big problem, but I'm curious on how to solve it in a more elegant way)
I suspect only worker 2 does the sampling, since there is a log message in the code (println("blabla")) but only worker 2 prints it (I'm using 4 workers). Also, going from 1 to 4 cores did not change the sampling time at all...

If you know what causes these issues (esp. the second one since it is the most important), please let me know :)

Actually it is an error on my end


angular2-cli gives @multi styles error

Please provide us with the following information:

OS?

Windows 7, 8 or 10. Linux (which distribution). Mac OSX (Yosemite? El Capitan?)
Ubuntu 14.04 LTS

Versions.

Please run ng --version. If there's nothing outputted, please run in a Terminal: node --version and paste the result here:
krishna@Krishna:~/angular2_migrate/webui$ ng version
Could not start watchman; falling back to NodeWatcher for file system events.
Visit http://ember-cli.com/user-guide/#watchman for more info.
angular-cli: 1.0.0-beta.17
node: 4.4.3
os: linux x64

Repro steps.

Was this an app that wasn't created using the CLI? What change did you do on your code? etc.
It was an app created using cli
I started using angular2-cli recently and created a new project. I wanted to use bootstrap in my project hence I installed bootstrap and then wanted to import the bootstrap css file like it is shown in the the angular2-cli guide here. https://github.com/angular/angular-cli#global-library-installation After running ng serve I get the following error.

The log given by the failure.

Normally this include a stack trace and some more information.

ERROR in multi styles Module not found: Error: Can't resolve '/home/krishna/angular2_migrate/webui/node_modules/bootstrap/dist/css/bootstrap.min.css' in '/home/krishna/angular2_migrate/webui/node_modules/angular-cli/models' @ multi styles
Mention any other details that might be useful.
node -v
4.4.3
npm -v
3.10.6

Thanks! We'll be in touch soon.

The error says it all, bootstrap cannot be found in node_modules. Do you have it installed?

^ what @ciesielskico said 💃


How can I see network traffic for my app using perfetto?

I tried various datasources but I cannot find network traffic for my application.
Can I have raw data of network traffic per each X-axis like AndroidStudio profiler does?

There is no network information in traces yet.
Android studio likely takes that from something != trace (by polling at some /proc counter perhaps).
Nothing planned too soon on this front, so closing this.


2.5: HTML-CSS output and outline styling

Due to (I think) #893, the output now gets outlines when tabbing through content (or clicking on it).
The HTML-CSS output on Chrome gets some pretty odd looking outlines. I don't like disabling them but perhaps we can improve them.

You are right, this is due to the tabindex added in #893.  The browsers don't seem to be taking the clipping regions into effect when the determine the bounding boxes for the math, which is why the outlines are so strange.  (The HTML-CSS output uses very tall boxes to make it possible to do absolute positioning without having an accurate measurement of the position of the baseline, and that is what is causing the strange outlines on top.)
I suggest we remove the tabindex for now and do an accessibility update later (when we do the menus, for example).  We really need to get some input from the accessibility community about what is really needed.

FWIW, I think it's only Chrome that's not taking the clipping into account (I tried a recent WebKit build, current FF, IE9-11).
But I'll ask around for alternatives for input.

No, it is in all the browsers I tested.  Here are images from Safari, Firefox, and Chrome.

Chrome is certainly the worst.  The others seem to take the smallest rectangle containing all the bounding boxes in the selection.  None seem to honor the clipping regions that MathJax has in place.

Ah, I missed the overall problem due to the jagged edges in Chrome.
BTW, the outline can be disabled via CSS.  But I'm fine with throwing the tabindex out. I suspect the future menu will be very different anyway.

I'm removing the tabindex setting for now.  This is in the issue997 branch of my fork of MathJax.

=> Merged


How to specify type on an attribute in MIDL?

I'm implementing a XAML MarkupExtension which expects the derived runtime class to have MarkupExtensionReturnTypeAttribute on it that specifies the type of the return value. I initially tried to use a string for specifying the type name however that doesn't work. Turns out that you've to specify the type itself directly and that works however then I get an error on the C++/WinRT side:
The type "String" was referenced as an attribute but its type definition was not found.

Is this a supported scenario?

This sounds like a question for the Xaml team. Can you open an issue on their repo?
https://github.com/microsoft/microsoft-ui-xaml

This is a MIDL compiler issue. You can only refer to types coming from your own assembly. https://stackoverflow.com/questions/52763407/how-to-use-the-templatepart-attribute-on-a-custom-control#comment120704283_52823160


json.exception.parse_error.101 only occurs outside of IDE

Description
Encountered a terminating error outside of IDE (VSCode) that I can't seem to get around. I did this issue posted before back in 2017-2018, but none of the solutions or checks that were discussed solved this problem. The repository used is PUPPET on my Github page, in case you want to reproduce the error. The full error is provided below:
terminate called after throwing an instance of 'nlohmann::detail::parse_error'
what(): [json.expection.parse_error.101] parse error at line 1, column 1: syntax error while parsing value - unexpected end of input; expected '[', '{', or a literal
Reproduction steps
Strangely, it only occurs outside of the IDE, when calling the command json::parse(fstream ifs) or ifs >> json dict (the type is not called of course, it's just for reference). I don't think this is a bug with the library, but rather something I don't know when building it. I call the below build:
C:\msys64\mingw64\bin\g++.exe -fdiagnostics-color=always -g E:\Users\buzze\Documents\GitHub\PUPPET\.cpp\*.cpp -o E:\User\buzze\Documents\Github\PUPPET\puppet.exe -static.
I apologize if my information is unclear or lacking, or if this isn't a bug at all. Thank you for looking into this!
Expected vs. actual results
The expected result should load up the game menu, and allow the user to start a new game, resume a previous, select options, or exit. In particular, selecting options should be able to access and change the value(s) of the options.json file, but instead the program runs into the error and shuts down immediately.
Minimal code example
#include "../.hpp/json.hpp"
#include <fstream>

using namespace std;
using json = nlohmann::json;

int main() {
    ifstream ifs("../.json/options.json");
    json options = json::parse(ifs);

   return 0;
}

Error messages
terminate called after throwing an instance of 'nlohmann::detail::parse_error'
  what(): [json.expection.parse_error.101] parse error at line 1, column 1: syntax error while parsing value - unexpected end of input; expected '[', '{', or a literal

Compiler and operating system
mingw64, Windows 10
Library version
3.10.5
Validation

[X] The bug also occurs if the latest version from the develop branch is used.
[ ] I can successfully compile and run the unit tests.

Can you please check if the working directory is properly set such that ../.json/options.json is an existing file? The error message indicates the file was not found. Maybe try an absolute path.

Ah thank you! It seems that VSCode's .exe launch.json started from the .cpp file level (${fileDurname}) and not from the working directory (${workspaceFolder}). This, in combination with using "../.json" instead of just ".json", caused a mismatch in where to look. Thanks again, no bug here at all!


Plumbing for local items support

bors r+

🎉🤖🚀❤💟😍

What's the next step of supporting local imports?

How do you intend to handle something like
fn foo() {
    {
        fn bar() {}
    }
}

? Should the container just be the function here, even though it's actually a nested scope?

@ice1000 local imports will be supported last, as they are the most complex bit.
@flodiebold don't know yet! My current plan is to treat every item as if declared in the outermost block, which will cover 80% of use-cases I hope!
I think though we do want to anchor every item at the def, for identification purposes. That is, the name resolution scopes don't have to correspond 1-to-1 to how we store things internally.


using Summary description instead of Event description in tooltip popup

Is your feature request related to a problem?
Please describe.
Tooltip pop up allows default 10,000 characters and could be a big popup making it impossible to click in the event
Describe the solution you'd like
Use the summary description instead of using the event description.

This should be a setting in order to not change behaviour on existing users who expect the description to be in the popup.

It seems to me it is the actual event that popup not the description and I don't see a setting for it. The only way I can control the popup amount of content is by cutting it from 10000 to 200 characters.
Thanks for you input, I'll revisit the setting just in case I missed something.

If I can step back in, I think allowing the user to select is good, my preference would be no option at all, the summary will be used for the popup and you can also limit the characters to e.g. 250 the full description will display after the link is clicked.  Less required steps is always better. The summary is more steps for the user, for less steps you can allow just the "first 250 characters plus ...more" of the description to display. With the latter you won't need the summary option or the limit on the description.

Sorry didn't mean to close it maybe someone else want to contribute

I disagree because of upgrades, this would change the current behaviour on users that already have it working the way they want. I think this should be either a setting or included in a new template (I have to check on templates on this module first), but a solution that would not change the popup content without a user action first in order to not change the behaviour on upgrades automatically.

I will have to agree with you. I don't know all the history or dependencies.

There is a template for the tooltip.
If people want the summary in the tooltip, it is just a matter of changing template.
No need to change anything or adding a setting.

So basically, these two links should document how to modify a template:
https://github.com/DNNCommunity/DNN.Events/wiki/The-use-of-Templates
https://github.com/DNNCommunity/DNN.Events/wiki/Tokens-to-be-used-in-Templates
Changing the token used in the tooltip template should resolve the issue for this situation without changing anything in the code.

I will give it a try later this week. Stay tuned.

This is a very old issue I was surprised to not see my two cents on this as I know I posted about it a few times... and is annoying
https://github.com/DNNCommunity/DNN.Events/issues/93
This post has my 2 cents on it.
Also the popup is very useful in a way but gets in the way... I seen a magnify glass on one of my listings when I set there to be a custom page link for the event.
I could not find the custom page link anywhere so I will make another issue now on that.
I believe that popup "Summary" should only show up when you hover over that magnify glass.  And when you click the link for the event it shows up with "Full Description" it should show a link to that custom page.

One last note is it is very hard to try to get that mouse to click on the event to see full description as the popup gets in the way which is why I suggested the magnify glass that shows up when you select using a custom page.

Also Inside the popup maybe a link to the full description by default


UTKFace dataset error

When trying to run the demo/tutorial code with the UTKFace dataset, it produces the following error:
ML-Doctor/demoloader/dataloader.py", line 73, in __getitem__
    gender = int(attrs[1])
ValueError: invalid literal for int() with base 10: ''

When printing the attrs it shows that the problem is with the missing gender:
['53', '', '0', '20170116184028385.jpg']
which seems to be a problem on line 4172 of the data file: landmark_list_part2.txt : 53__0_20170116184028385.jpg
There seem to be two entries for that jpg since it is repeated on line 4213 with 62_1_0_20170116184028385.jpg
Removing line 4172 fixes the error.
Is this the correct way to preprocess the UTKFace data? If so, perhaps a note in the README would help others avoid the pain?

Hi, thanks for notifying me of the information. It is indeed the error of UTKFace dataset. I deleted the data with irregular names when I ran the experiments. I will update the README later.

Hi, I have updated the code of UTKFace datasets.


log-backup: implement subscribe flushing

What is changed and how it works?

Issue Number: Close #13824
What's Changed:
This PR:

Implements the new gRPC interface "SubscribeFlush".

Added a new structure SubscriptionManager in the checkpoint manager module, this actor receives subscribe requests and flush events. It manages the event routing and the subscription life time management.
Related changes

PR to update pingcap/docs/pingcap/docs-cn:
Need to cherry-pick to the release branch

Check List
Tests

Integration test

Release note
None

/merge


Incosistent behaviour w/ CLI: per-file-ignores not being used

Describe the bug
Pycharm warns me of errors I have explicitly ignored usign the ruff.toml file and that are ignored by the CLI.
To Reproduce
Steps to reproduce the behavior:

Create a ruff.toml file with the following contents:

line-length = 120
select = ["ALL"]
ignore = ["ANN101", "ANN102"]
fix=false

show-source = true

[pydocstyle]
convention = "google"

[per-file-ignores]
"tests/*.py" = ["S101", "ANN001","ANN101", "ANN102", "ANN201", "D100", "D101"]

This should:

Apply all linters, except ["ANN101", "ANN102"] to all files
Apply all linters except  ["S101", "ANN001","ANN101", "ANN102", "ANN201", "D100", "D101"] to the files in the tests folders

Concretely, the D100 and D101 should make that don't require docstrings at the module and class levels.

Create a dummy file tests/example.py with the following content:

class DummyTest:

    def test_i_dont_want_type_hints(self):
        """Here I explain what the test do."""

Run the following:

$ ruff tests/examples.py
# No errors are returned

Check on Pycharm and see the following:

Expected behavior
I will expect the pycharm plugin to:

Be consistent with the CLI behaviour
Ignore files and rules that I have configured it to ignore

Screenshots
Already provided in the step 5.
Environments

IDE: PyCharm 2022.3.1 (Professional Edition) (Build #PY-223.8214.51, built on December 20, 2022)
OS: Ubuntu 22.04.1 LTS
Ruff Version: 0.0.225
Plugin version: 0.0.5

Additional context
Not important for this case, but while checking at the plugin configuration I come accross this typo on Settings > Editor > Inspections > Python > Ruff inspeciton ( It should read inspection)

Thank you so much, it works like a charm

Unfortunately this still doesn't seem to work if your ruff config isn't in the root directory of your project. Maybe there should be a setting for configuring the config file path? Although I'm noticing that when using the ruff CLI it seems to be able to pick up my config regardless of the working directory, so maybe it's possible to piggyback off of that

@henribru
Thank you for your comment.

Although I'm noticing that when using the ruff CLI it seems to be able to pick up my config regardless of the working directory, so maybe it's possible to piggyback off of that

Did you mention the option?
ruff check --help | grep "\-\-config"
      --config <CONFIG>  Path to the `pyproject.toml` or `ruff.toml` file to use for configuration

@henribru Thank you for your comment.

Although I'm noticing that when using the ruff CLI it seems to be able to pick up my config regardless of the working directory, so maybe it's possible to piggyback off of that

Did you mention the option?
ruff check --help | grep "\-\-config"
      --config <CONFIG>  Path to the `pyproject.toml` or `ruff.toml` file to use for configuration

No, when I tested with the CLI I didn't use that option. According to https://github.com/charliermarsh/ruff#pyprojecttoml-discovery the Ruff CLI automatically finds the closest config file for each file when no config path is specified, I guess that's why it works

The latest plugin adds the option :thinking:

@henribru
Can you show me your project file tree structure?
I can't reproduce the problem on my local machine.

Unfortunately this still doesn't seem to work if your ruff config isn't in the root directory of your project.

It works for me. 🤔
pyproejct.toml is for only Poetry in the example.

@koxudaxi In my project I'm using pyproject.toml for the Ruff config, but pyproject.toml isn't in the project directory, it's in a first-level subdirectory. It would be like moving main.pyand pyproject.toml inside root in your example screenshot and removing ruff.toml and putting that config inside pyproject.toml instead.

@henribru
Thank you for explaining your situation.
I try to reproduce your project.
It works fine with ruff 0.0.246 and the plugin v0.0.8

@koxudaxi I was planning to make a reproduction repo, but when trying the latest version now it seems to work fine actually. Not sure what change fixed it, but thanks!


[cli] resolve files local to the current folder

so for example -c examples/configuration/echo.json works
the cli changes directory to apicast and then all relative paths would
stop working

I think that breaking the read method into smaller ones would help readability. Possible ones: absolute_path, is_valid_path, strip_trailing_slash, etc. What do you think?

Yep. Good idea. Will do.


Remove zanata configuration from .travis.yml

There's a deploy job to push to zanata in Travis. It caused Travis failed when when PR is merged into master. Since we do not use zanata any more, zanata setting should be removed.
Failed deploy job can be found from https://travis-ci.org/github/weldr/cockpit-composer/jobs/667298469?utm_medium=notification&utm_source=github_status

@martinpitt, @marusak, The edge scenario failed is not caused by this PR and I'm working on PR #917 to fix flaky issue. Thanks!


add syntax highlighting

@hurradieweltgehtunter
As talked about yesterday please implement syntax highlighting in the way you want.

done


[Feature] Backend: Add Beneficiary Data

As per created wireframe "Add new Beneficiary" (https://www.figma.com/file/RYfJNeymmqXdbVTtdmQzva/Podkrepi-Campaign?node-id=0%3A1)
add additional fields:

Date of birth (DateTime)
Region (Enum type)
Address (string, max-length 100)
Connection with the Beneficiary (Enum type)

Made relevant changes in the proto fails: https://github.com/podkrepi-bg/types/pull/8


Switched check identity to hash of definition

PR for issue #1296
In ConsistentHashBuilder inside soda/core/soda/execution/identity.py,
        elif (
            isinstance(value, Location)
            or isinstance(value, MissingAndValidCfg)
            or isinstance(value, ChangeOverTimeCfg)
            or isinstance(value, ThresholdCfg)
            or isinstance(value, SchemaValidations)
        ):
            self.add_all(value.get_identity_parts())

still should be removed / cleaned up.  I think from a first look, it is not being needed by the metric identity creation, but it should be double checked.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.1 out of 2 committers have signed the CLA.:white_check_mark: tombaeyens:x: pre-commit-ci[bot]You have signed the CLA already but the status is still pending? Let us recheck it.

I like the change, it simplifies things and removes flaky logic of what is included in identity for different check types. We also have a test that tests whether similarly looking checks will pass (which previously caused issues), but may I suggest that we should add one test for this change?
The tests should tests that line changes are not affecting the check identity by creating a check file, adding one check into it, then calculate identity (e.g. identity is X), then add another check into the file on a line before the original (so that the original check with identity X is now on a different line) and calculating the identities again, making sure that the original check still has identity X.
This scenario was reported as a bug earlier when moving a check to a different line changed its identity and confused Cloud.


Mistral 7B

Will there be a release of the Mistral 7b model?

We haven't tried the Mistral 7b in our paper but you can easily train it using our script by replacing the model path with mistralai/Mistral-7B-v0.1, after downloading the data at selfrag/selfrag_train_data.
Currently, we have limited bandwidth, but we will announce it if we train the 7B model based on Mistral 7b in the next few weeks!


Adds github client and PAT inspection

Implements feature for https://github.com/owasp-dep-scan/dep-scan/issues/100

Ok, so there are two discrete issues causing the checks to fail.

The built-in GITHUB_TOKEN we're putting in the env for some workflow steps does not work in Ubuntu when we try to authenticate. Since I don't really like the idea of us generating a new token with expanded privileges, We must instead catch the exception.

The type hints for get_token_scopes and get_token_extra_scopes is screwing up runs using python 3.8. Instead of list[str] should just be list.

We ultimately can't actually test the condition exists to output a warning from within our own repo without implementing the same poor security practice we intend to warn against, as @prabhu describes below - unless we want to set up a separate repo with such overly permissive permissions and run a test there.

A number of users of AppThreat pass the default GITHUB_TOKEN with overly generous read/write permissions across their repos and packages. It would be nice to detect this and flag up a warning.

I have therefore made minor changes to the pr to address these two issues.

Thanks @prabhu and @cerrussell for your feedback and help!
@prabhu I looked at AppThreat VDB and it looks like it calls the https://api.github.com/graphql with a query for securityAdvisories. I tried calling the endpoint directly with various tokens, and found that although a token is required (classic or fine-grained both work), the token doesn't require any permissions to be granted. I am updating this PR to reflect that discovery, including:

Update README with guidance on fine-grained and classic token usage
Code is simpler because any permissions granted is overly permissive and a warning will be issued for any permission greater than minimum
Note: The warning only works for classic token types. As detailed here, there is no way presently to see the permissions of a fine-grained token.

@cerrussell Thanks for helping with the failing tests. I am not understanding your ask for creating a repo with the overly permissive token. Can you please elaborate more? For example, how could I do this in my existing fork? Also, is this a temporary setup, or should this be everlasting to continuously demonstrate this works?

@cerrussell @timmyteo What is left in this PR?

@prabhu I think I had wanted a demo to show this works, which we can't do by scanning from our own repo.

@cerrussell, you can run it using a workflow on AppThreat org, which uses such overly generous GITHUB_TOKEN by default.

@prabhu @timmyteo  I am quite possibly missing something here, but I'm getting that the token is expired or invalid rather than the expected message on the test workflow.

@cerrussell Interesting! Both classic and newer fine grained tokens should work, so I don't think that is the problem here. One of these two exceptions are being thrown. Your Github token may be expired, although if it is being used in this workflow, it seems unlikely. Maybe this catch for the two exceptions needs to be separated out for describing different error scenarios, especially if a different issue is occurring here besides expired token.

@timmyteo The GITHUB_TOKEN is automatically generated by GitHub when the workfow is run, so it must be something else.

Thanks for these details @cerrussell. It seems the tokens for Actions have a reduced scope by default, which was not suitable for calling the users API. I reworked the code to not call the API for the user details, and instead just call the base API. Testing with classic tokens and fine-grained access tokens show no regression from expected functionality, and I believe this will work now for Action tokens as well.

@timmyteo Thanks! I just tried it out, but still couldn't get anything in CI. However, I was able to get it locally with a token I generated, so that's good. I guess we just won't be able to do this in CI.

@timmyteo Confused - I thought that might be it, but I mentioned this upthread and and your reply to that was they should both work. Am I missing something?

@cerrussell Sorry for the confusion! Let me know if this explanation helps. GitHub has these 3 main token types:

Classic
Fine-Grained
Auto-generated for Actions

The first two can be long lived and are generated by the developer and associated to their account. The third is short lived, lesser privileged, and generally only lives as long the action does.
This pull request adds two pieces of functionality with respect to these three token types:

Log an error if the token returns a 401 Unauthorized from the GitHub API (applicable to all 3 token types)
Log a warning if oauth scopes are returned from the GitHub API, signaling that the token has more permission than is necessary for depscan. (Only the classic token type returns oauth scopes from the GitHub API)

@timmyteo I understand that, I meant you're comment in response to where I said "Maybe the built-in GITHUB_TOKEN is not a classic token"

@cerrussell Interesting! Both classic and newer fine grained tokens should work, so I don't think that is the problem here. One of these two exceptions are being thrown. Your Github token may be expired, although if it is being used in this workflow, it seems unlikely. Maybe this catch for the two exceptions needs to be separated out for describing different error scenarios, especially if a different issue is occurring here besides expired token.

Ah yes, I was misunderstanding how the workflow was configured. My first guess was that a personal access token (classic or fine-grained) was generated and manually set as a workflow environment variable GITHUB_TOKEN. But I learned as part of our conversation thanks to your help that there is the option for the additional token type of auto-generated token, which you are utilizing here. So sorry for the confusion and this is just one of many examples that you learn something new everyday :)

@timmyteo Gotcha, no problem, just wanted to make sure I was on the same page.


Why can a local server connect to only one database?

Why can a local server connect to only one database? Why can a local server connect to only one database instead of a traditional database service? I've seen a similar design on other vector database services, is this design to avoid any problems?
By the way, I've been learning code of chroma lately. It's not very easy to understand just by looking at the code, where can I find design documents like architecture diagrams?

hey @Amphetaminewei, single-node Chroma has two modes of operation:

Persistent or Ephemeral client - intended for embedding in an application. In PersistentClient mode, you can create multiple clients, each connecting to a different db (persistent dir).

import chromadb
pclient1 = chromadb.PersistentClient(path="db1")
pclient2 = chromadb.PersistentClient(path="db2")

Client/Server (or simply HttpClient) - In this mode you can also specify multiple clients that connect to different servers

import chromadb

client1 = chromadb.HttpClient("http://localhost:8000")

client2 = chromadb.HttpClient("http://mydomain.com:8000")

With the above in mind, can you tell me in which category or in what way you'd like to use Chroma and connect to multiple DBs? Or perhaps share a code snippet that poses the challenge?
Regarding the architecture, Chroma is still in active development and changes frequently. I'll see if I can share some high-level overview of the single-node architecture.

With the above in mind, can you tell me in which category or in what way you'd like to use Chroma and connect to multiple DBs?

Hi @tazarov  i start the server on my local computer, and connect to the server with the HTTP client, and I find that when the service starts, I need to specify a database as a parameter. I think this means that this service can only manage a specified database.
I'm learning how to build a vector database service, so I'm actually more curious about the reason for this design

@Amphetaminewei, can you show me the bit of code that requires you to specify the database parameter? Do you mean that the persistent dir or the address is what you specify as a database?

@tazarov  I started the database service in the following ways:
chroma run --path ~/.local/vectordb/

Then connect to the server through the HTTP client：
import chromadb
client1 = chromadb.HttpClient("http://localhost:8000")

This makes it impossible for my database service to manage multiple databases with one service like a traditional database service like MySQL, but only to connect to the one database specified in the --path parameter, and I would like to know the reason for this design

@Amphetaminewei
the HTTP Client accepts tenant and database as input params
https://github.com/chroma-core/chroma/blob/7b991fa6a949142851ff4b715f00f48f6bcc13da/chromadb/__init__.py#L162
are you saying you want one client and be able to specify the tenant and db dynamically?

@jeffchuber
Yes, with traditional database services such as MySql, the client can specify which database to connect to, but it seems that Chroma Server can only connect to a certain database.
I've been learning about vector databases lately, and I'm a little curious about why it's designed this way. Is it because vector storage is special? Or is it because we don't actually need to split the data into multiple databases, just multiple collections.
By the way, I've been learning chroma code recently, it's a bit difficult for me to just read the code, there are very few in-depth interpretation materials on the Internet, most of the ones you can find are about how to use, do you know where to find relevant documents, architecture diagrams, source code parsing and the like? Thank you so much if you have one!

@Amphetaminewei in the current python client design - you need a separate client for each connection to a tenant-database pair. However - the python client is OSS and merely a wrapper around a HTTP REST server routes. You could easily fork and build your own version if you do not like these ergonomics. 99% of users spread their data across collections vs databases.
closing as we have identified a valid solution / workaround.
thanks for the questions!
for the chroma code and arch diagrams - we are working to improve this soon!


fix some type import paths

Fixes #653

A lot more work is needed to make vendoring work it seems, css import assertions aren't supported and type imports that are using the import map such as import("rollup") are not working either.
This would be a lot easier if deno would just ignore the imports from JSDoc comments.

I think all of the imports have been fixed, though bare specifiers from import maps and css type assertions are still making it impossible to deno vendor /src/mod.js. I don't think there's much that can be done here unless https://github.com/denoland/deno/issues/16551 is fixed. But if anything at least this cleans up some inconsistencies in the code.


Bug: Enabling and disabling Markdown removes styles applied to text

When writing styled text containing whitespaces, enabling and disabling Markdown removes any style applied to the text. The text is also replaced by Markdown.
Lexical version:
Steps To Reproduce

Write any text with whitespaces.
Apply styles to the text
Convert to Markdown
Disable Markdown

https://user-images.githubusercontent.com/44519061/189119324-b11b4556-508f-40ed-a547-2ec048f21072.mov

I can't reproduce this with the current version. I can definitely still see some bugs in how the table support is implemented and how leading or trailing styled whitespace is handled, but this case seems to work ok (ignoring the other table related issues)


Add a section with working example for connecting using multiple wallets

We'd be happy to look into this for you. Kindly file a support ticket here
https://forms.gle/zVGLP7GATPsDHdkH9

@george-gkas We'd be happy to look into this for you
kindly file a support ticket below
https://forms.gle/7KbQyuY5NoxyrhNz5

We'd be happy to look into this for you
kindly file a support ticket below
https://forms.gle/FhSmn4AznQtZcruX8


[TW#27668] Change BLUETOOTH Passkey programmatically

I'm testing the "new" feature to set passkey to BLE.
All works (i'm basing on security gatts example) but, if i try to change the pass key from bonded device i have several issues.
uint32_t newPassKey = 123457;
esp_ble_gap_set_security_param(ESP_BLE_SM_SET_STATIC_PASSKEY, &newPassKey, sizeof(uint32_t));
remove_all_bonded_devices();
esp_ble_gatts_close(gl_profile_tab[PROFILE_A_APP_ID].gatts_if, gl_profile_tab[PROFILE_A_APP_ID].conn_id);

After this the client can anyway connect to server (it connects also with no password) and i receive some errors like:
I (19516) BLE: pair status = fail
I (19526) BLE: fail reason = 0x51
W (19526) BT_BTM: btm_sec_clr_temp_auth_service() - no dev CB

E (36436) BT_BTM: Device not found
W (36436) BT_APPL: BTA got unregistered event id 31
W (36436) BT_APPL: BTA got unregistered event id 31

@lettierimarco, Please describe your test process in detail.

@Weijian-Espressif
THE BLE CONFIGURATION:
uint32_t newPassKey = 123456; esp_ble_auth_req_t auth_req = ESP_LE_AUTH_BOND;     //bonding with peer device after authentication 	esp_ble_io_cap_t iocap = ESP_IO_CAP_OUT;           //set the IO capability to No output No input 	uint8_t key_size = 16;      //the key size should be 7~16 bytes 	uint8_t init_key = ESP_BLE_ENC_KEY_MASK | ESP_BLE_ID_KEY_MASK; 	uint8_t rsp_key = ESP_BLE_ENC_KEY_MASK | ESP_BLE_ID_KEY_MASK; 	//set static passkey 	uint8_t auth_option = ESP_BLE_ONLY_ACCEPT_SPECIFIED_AUTH_DISABLE; 	//uint8_t oob_support = ESP_BLE_OOB_DISABLE; 	esp_ble_gap_set_security_param(ESP_BLE_SM_SET_STATIC_PASSKEY, &passKey, sizeof(uint32_t)); 	esp_ble_gap_set_security_param(ESP_BLE_SM_AUTHEN_REQ_MODE, &auth_req, sizeof(uint8_t)); 	esp_ble_gap_set_security_param(ESP_BLE_SM_IOCAP_MODE, &iocap, sizeof(uint8_t)); 	esp_ble_gap_set_security_param(ESP_BLE_SM_MAX_KEY_SIZE, &key_size, sizeof(uint8_t)); 	esp_ble_gap_set_security_param(ESP_BLE_SM_ONLY_ACCEPT_SPECIFIED_SEC_AUTH, &auth_option, sizeof(uint8_t)); 	//esp_ble_gap_set_security_param(ESP_BLE_SM_OOB_SUPPORT, &oob_support, sizeof(uint8_t)); 	/* If your BLE device act as a Slave, the init_key means you hope which types of key of the master should distribut to you, 	and the response key means which key you can distribut to the Master; 	If your BLE device act as a master, the response key means you hope which types of key of the slave should distribut to you, 	and the init key means which key you can distribut to the slave. */ 	esp_ble_gap_set_security_param(ESP_BLE_SM_SET_INIT_KEY, &init_key, sizeof(uint8_t)); 	esp_ble_gap_set_security_param(ESP_BLE_SM_SET_RSP_KEY, &rsp_key, sizeof(uint8_t)); 	for(int i=0;i<ESP_BLE_PWR_TYPE_NUM;i++){ 		ret = esp_ble_tx_power_set(i, ESP_PWR_LVL_P9); 		if (ret) { 			ESP_LOGE(GATTS_TABLE_TAG, "%i Unable to set BLE Tx power level. err: %x \n", i,ret); 			return; 		} 	}
Try to connect via nRF connect app for Android.
When connected you'll have a prompt for "Associate" and input the passkey.
If you click "Associate" and leave empty the passkey and press "CANCEL", you receive CONNECT_EVT and this log:
I (33234) BLE: pair status = fail
I (33234) BLE: fail reason = 0x63

but the connection is up and you're able to write on characteristics.
So i change the passkey via:
uint32_t newPassKey = 123457;
esp_ble_gap_set_security_param(ESP_BLE_SM_SET_STATIC_PASSKEY, &newPassKey, sizeof(uint32_t));
remove_all_bonded_devices();
esp_ble_gatts_close(gl_profile_tab[PROFILE_A_APP_ID].gatts_if, gl_profile_tab[PROFILE_A_APP_ID].conn_id);

I try with 123456 and i connect correctly, so the passkey doesn't change.

@lettierimarco

After Bluetooth connection, You can  decide whether to start encryption. even if the encryption fails, it will not affect the Bluetooth connection.
Please set static passkey when Bluetooth initializes. If you clear the bonded keys, please delete the pairing record in the phone Bluetooth settings.

the second, is solved,thanks.
For the first the problem still live.
i've setted the encryption on connect:
esp_ble_set_encryption(param->connect.remote_bda, ESP_BLE_SEC_ENCRYPT_MITM);
but i try to set  notify  after connection and it passes, and after i receive GATT_INSUF_AUTHENTICATION.
`
I (5519) BLE: ESP_GATTS_CONNECT_EVT, conn_id 0, remote 7a:0e:1c:25:cb:80:
W (5519) BT_L2CAP: l2cble_start_conn_update, the last connection update command still pending.
I (6569) BLE: GATT_WRITE_EVT, conn_id 0, trans_id 1, handle 43 prepare 0
I (6569) BLE: notify enable
E (6679) BT_GATT: gatts_write_attr_perm_check - GATT_INSUF_AUTHENTICATION
I (35529) BLE: remote BD_ADDR: 7e0e1e25bb80
I (35529) BLE: address type = 1
I (35529) BLE: pair status = fail
I (35529) BLE: fail reason = 0x63
W (35539) BT_BTM: btm_sec_clr_temp_auth_service() - no dev CB
I (35549) BLE: ESP_GATTS_DISCONNECT_EVT
E (35679) BT_BTM: Device not found
W (35679) BT_APPL: BTA got unregistered event id 31

Do you have setup all characteristics and descriptors with permission:
ESP_GATT_PERM_READ_ENCRYPTED and/or ESP_GATT_PERM_WRITE_ENCRYPTED

ESP_GATT_PERM_READ and ESP_GATT_PERM_WRITE_ENCRYPTED, because
seems ESP_GATT_PERM_READ_ENCRYPTED has some problem with iOS
    case ESP_GATTS_CREATE_EVT:
        //ESP_LOGI(GATTS_TABLE_TAG, "CREATE_SERVICE_EVT, status %d,  service_handle %d\n", param->create.status, param->create.service_handle);
        gl_profile_tab.service_handle = param->create.service_handle;
        gl_profile_tab.char_uuid.len = ESP_UUID_LEN_16;
        gl_profile_tab.char_uuid.uuid.uuid16 = GATTS_CHAR_UUID_TEST_A;

        esp_ble_gatts_start_service(gl_profile_tab.service_handle);
        a_property = ESP_GATT_CHAR_PROP_BIT_READ | ESP_GATT_CHAR_PROP_BIT_WRITE | ESP_GATT_CHAR_PROP_BIT_NOTIFY;
        esp_err_t add_char_ret = esp_ble_gatts_add_char(gl_profile_tab.service_handle, &gl_profile_tab.char_uuid,
        												ESP_GATT_PERM_WRITE_ENCRYPTED|ESP_GATT_PERM_READ,
                                                        a_property,
                                                        &gatts_demo_char1_val, NULL);
        if (add_char_ret){
            ESP_LOGE(GATTS_TABLE_TAG, "add char failed, error code =%x",add_char_ret);
        }
        break;

Remember to set this to CCC descriptor too.

thanks @chegewara
solved


Export tables separately

Good afternoon, I would like to know if there is how to export the tables separately, does each table generate its file?

You can choose to export each table in separate file or conditional export. You can have a look at this documentation and see whether your problem get solved or not.


add writable directory for containers

This is a little fix: Now users can test Neurodesk images before they are officially released.

Merged, and new image has just been deployed. Would have done it sooner, but neurodebian seemed to be down, breaking the build.
Thanks @stebo85

Thank you @andybotting :) Unfortunately, it didn't work yet - but it's probably something I did wrong. My goal with this change was to have a writable directory at:
/neurocommand/local/containers
Could it be that I got the order wrong and that ansible needs something else first?


Defer/(Preferably discard) Running task if there is a task from same Task family running on the host.

Is there a way to not schedule the task by central scheduler if a same task from the same task family is running on the host? If not is there a way to kill it by checking whether a similar task is running on the host.

After going through the docs it is clear that  by setting the unique resource will fix the problem. Here is the doc for  reference


Added the possibility to have function declared as required propOption

Added the possibility to declare a function as value for required PropOption which should return a truthy or falsy value as the following:
props: {
  myProp: {
    type: String,
    required: function () {
      /* Treatment here */
      return result // truthy or falsy
    }
  }
}

Why do you need the required property to change? I can understand it changing depending on other props (eg one of two different props being required) but in that case, you wouldn't be able to rely on it because of the order. What is your usecase?

The case I needed it is a component which has two different "states" (one to create and another to modify).
Thus, there are some properties that are needed in a state, but not in the other.
So here would be the case:
props: {
  state: {
    type: String,
    required: true,
    validator: function (val) {
      return !!~['create','edit'].indexOf(val)
    }
  },
  content: {
    type: String,
    required: function () {
      return this.state === 'edit'
    }
  }
}

If you are in edit mode, you have to pass some content as you can't have something to edit where there's nothing, and you can have pre-loaded content in create mode.
Of course, the order of the props is important in that case, as not all of it will be loaded, but it could give some more power and flexibility to props.

Of course, the order of the props is important in that case, as not all of it will be loaded, but it could give some more power and flexibility to props (still there are some workarounds).

What I was saying is that using an object doesn't let you rely on the order. Furthermore, you may want something like
props: {
  one: {
    required () {
      'one' in this || 'two' in this
    },
  two: {
    required () {
      'one' in this || 'two' in this
    }
}

But that'd require the required function to be called after all props have been initialized.
IMO this is more of a validator function but it's true that validator doesn't have access to this (it's a pure function).

imo relying on other props in the initialization phase can be problematic because the Object enumeration order is inconsistent in different JavaScript engines - e.g. your code may work in Chrome but break in Safari.
I think it's safer to just check and emit your custom warning in the created hook of your component when all props have been initialized.

That's right that browsers are really capricious with objects.
Well, seems like I'll stay with workarounds 👍

I recommend you to add checks on the created hook and display warnings that are stripped off in when bundling in production (this needs some Webpack/rollup configuration):
// inside of created
if (process.env.NODE_ENV !== 'production') {
// check here
}

If you used the webpack template for your project, you don't need to configure anything 🙂


undefined reference to `cv::Mat::updateContinuityFlag()' error

Hi, I am getting this error when I run "catkin_make_isolated." I'm not that good with Linux, would anyone be able to help me?
Thanks so much!
==> Processing catkin package: 'handeye_calib_camodocal'
==> Building with env: '/home/blingshock/me8287_ws/devel_isolated/ceres-solver/env.sh'
Makefile exists, skipping explicit cmake invocation...
==> make cmake_check_build_system in '/home/blingshock/me8287_ws/build_isolated/handeye_calib_camodocal'
-- Using CATKIN_DEVEL_PREFIX: /home/blingshock/me8287_ws/devel_isolated/handeye_calib_camodocal
-- Using CMAKE_PREFIX_PATH: /home/blingshock/me8287_ws/devel_isolated/ceres-solver;/opt/ros/kinetic
-- This workspace overlays: /opt/ros/kinetic
-- Using PYTHON_EXECUTABLE: /usr/bin/python
-- Using Debian Python package layout
-- Using empy: /usr/bin/empy
-- Using CATKIN_ENABLE_TESTING: ON
-- Call enable_testing()
-- Using CATKIN_TEST_RESULTS_DIR: /home/blingshock/me8287_ws/build_isolated/handeye_calib_camodocal/test_results
-- Found gmock sources under '/usr/src/gmock': gmock will be built
-- Found gtest sources under '/usr/src/gmock': gtests will be built
-- Using Python nosetests: /usr/bin/nosetests-2.7
-- catkin 0.7.14
-- Using these message generators: gencpp;geneus;genlisp;gennodejs;genpy
-- No preference for use of exported gflags CMake configuration set, and no hints for include/library directories provided. Defaulting to preferring an installed/exported gflags CMake configuration if available.
-- Found installed version of gflags: /usr/local/lib/cmake/gflags
-- Detected gflags version: 2.2.0
Gflags found = TRUE
Glog found = TRUE
-- Found installed version of Eigen: /usr/lib/cmake/eigen3
-- Found required Ceres dependency: Eigen version 3.2.92 in /usr/include/eigen3
-- Found installed version of glog: /usr/local/lib/cmake/glog
-- Detected glog version: 0.3.5
-- Found required Ceres dependency: glog
-- Found installed version of gflags: /usr/local/lib/cmake/gflags
-- Detected gflags version: 2.2.0
-- Found required Ceres dependency: gflags
-- Found Ceres version: 1.14.0 installed in: /home/blingshock/me8287_ws/devel_isolated/ceres-solver with components: [EigenSparse, SparseLinearAlgebraLibrary, LAPACK, SuiteSparse, CXSparse, SchurSpecializations, OpenMP, Multithreading]
-- OpenCV version: 3.3.1
-- defined HAVE_OPENCV3
GLOG = glog::glog
-- Configuring done
-- Generating done
-- Build files have been written to: /home/blingshock/me8287_ws/build_isolated/handeye_calib_camodocal
==> make -j4 -l4 in '/home/blingshock/me8287_ws/build_isolated/handeye_calib_camodocal'
[ 33%] Linking CXX executable /home/blingshock/me8287_ws/devel_isolated/handeye_calib_camodocal/lib/handeye_calib_camodocal/handeye_calib_camodocal
CMakeFiles/handeye_calib_camodocal.dir/src/handeye_calibration.cpp.o: In function cv::Mat::Mat(int, int, int, void*, unsigned long)': handeye_calibration.cpp:(.text._ZN2cv3MatC2EiiiPvm[_ZN2cv3MatC5EiiiPvm]+0x2a1): undefined reference to cv::Mat::updateContinuityFlag()'
collect2: error: ld returned 1 exit status
CMakeFiles/handeye_calib_camodocal.dir/build.make:224: recipe for target '/home/blingshock/me8287_ws/devel_isolated/handeye_calib_camodocal/lib/handeye_calib_camodocal/handeye_calib_camodocal' failed
make[2]: *** [/home/blingshock/me8287_ws/devel_isolated/handeye_calib_camodocal/lib/handeye_calib_camodocal/handeye_calib_camodocal] Error 1
CMakeFiles/Makefile2:1091: recipe for target 'CMakeFiles/handeye_calib_camodocal.dir/all' failed
make[1]: *** [CMakeFiles/handeye_calib_camodocal.dir/all] Error 2
Makefile:138: recipe for target 'all' failed
make: *** [all] Error 2
<== Failed to process package 'handeye_calib_camodocal':
Command '['/home/blingshock/me8287_ws/devel_isolated/ceres-solver/env.sh', 'make', '-j4', '-l4']' returned non-zero exit status 2
Reproduce this error by running:
==> cd /home/blingshock/me8287_ws/build_isolated/handeye_calib_camodocal && /home/blingshock/me8287_ws/devel_isolated/ceres-solver/env.sh make -j4 -l4
Command failed, exiting.

HI, I am getting same error，as shown below:
CMakeFiles/handeye_calib_camodocal.dir/src/handeye_calibration.cpp.o: In function cv::Mat::Mat(int, int, int, void*, unsigned long)':
handeye_calibration.cpp:(.text._ZN2cv3MatC2EiiiPvm[_ZN2cv3MatC5EiiiPvm]+0x2a1): undefined reference to cv::Mat::updateContinuityFlag()'
and the opencv version that catkin_make found:
--Found OpenCV: /opt/ros/kinetic (found version "3.3.1")  -- OpenCV version: 3.3.1
I guess it is caused by a version mismatch.
Modify the CMakeLists.txt file:
change find_package(OpenCV REQUIRED) to find_package(OpenCV 3.4.5 REQUIRED).
(3.4.5 is the version the OpenCV I installed.)
error solved !

HI, I am getting same error，as shown below:
CMakeFiles/handeye_calib_camodocal.dir/src/handeye_calibration.cpp.o: In function cv::Mat::Mat(int, int, int, void*, unsigned long)':
handeye_calibration.cpp:(.text._ZN2cv3MatC2EiiiPvm[_ZN2cv3MatC5EiiiPvm]+0x2a1): undefined reference to cv::Mat::updateContinuityFlag()'
and the opencv version that catkin_make found:
--Found OpenCV: /opt/ros/kinetic (found version "3.3.1") -- OpenCV version: 3.3.1
I guess it is caused by a version mismatch.
Modify the CMakeLists.txt file:
change

find_package(OpenCV REQUIRED)
to
find_package(OpenCV 3.4.5 REQUIRED).

(3.4.5 is the version of OpenCV I installed.)
error solved !

HI, I am getting same error，as shown below:
CMakeFiles/handeye_calib_camodocal.dir/src/handeye_calibration.cpp.o: In function cv::Mat::Mat(int, int, int, void*, unsigned long)': handeye_calibration.cpp:(.text._ZN2cv3MatC2EiiiPvm[_ZN2cv3MatC5EiiiPvm]+0x2a1): undefined reference to cv::Mat::updateContinuityFlag()'
and the opencv version that catkin_make found:
--Found OpenCV: /opt/ros/kinetic (found version "3.3.1")  -- OpenCV version: 3.3.1
I guess this error is caused by a version mismatch.
so I modify the CMakeLists.txt file:
change
find_package(OpenCV REQUIRED)
to
find_package(OpenCV 3.4.5 REQUIRED).
(3.4.5 is the version of OpenCV I installed.)
then the catkin_make error solved !

Hi, I am getting this error when I run "catkin_make_isolated." I'm not that good with Linux, would anyone be able to help me?
Thanks so much!
==> Processing catkin package: 'handeye_calib_camodocal'
==> Building with env: '/home/blingshock/me8287_ws/devel_isolated/ceres-solver/env.sh'
Makefile exists, skipping explicit cmake invocation...
==> make cmake_check_build_system in '/home/blingshock/me8287_ws/build_isolated/handeye_calib_camodocal'
-- Using CATKIN_DEVEL_PREFIX: /home/blingshock/me8287_ws/devel_isolated/handeye_calib_camodocal
-- Using CMAKE_PREFIX_PATH: /home/blingshock/me8287_ws/devel_isolated/ceres-solver;/opt/ros/kinetic
-- This workspace overlays: /opt/ros/kinetic
-- Using PYTHON_EXECUTABLE: /usr/bin/python
-- Using Debian Python package layout
-- Using empy: /usr/bin/empy
-- Using CATKIN_ENABLE_TESTING: ON
-- Call enable_testing()
-- Using CATKIN_TEST_RESULTS_DIR: /home/blingshock/me8287_ws/build_isolated/handeye_calib_camodocal/test_results
-- Found gmock sources under '/usr/src/gmock': gmock will be built
-- Found gtest sources under '/usr/src/gmock': gtests will be built
-- Using Python nosetests: /usr/bin/nosetests-2.7
-- catkin 0.7.14
-- Using these message generators: gencpp;geneus;genlisp;gennodejs;genpy
-- No preference for use of exported gflags CMake configuration set, and no hints for include/library directories provided. Defaulting to preferring an installed/exported gflags CMake configuration if available.
-- Found installed version of gflags: /usr/local/lib/cmake/gflags
-- Detected gflags version: 2.2.0
Gflags found = TRUE
Glog found = TRUE
-- Found installed version of Eigen: /usr/lib/cmake/eigen3
-- Found required Ceres dependency: Eigen version 3.2.92 in /usr/include/eigen3
-- Found installed version of glog: /usr/local/lib/cmake/glog
-- Detected glog version: 0.3.5
-- Found required Ceres dependency: glog
-- Found installed version of gflags: /usr/local/lib/cmake/gflags
-- Detected gflags version: 2.2.0
-- Found required Ceres dependency: gflags
-- Found Ceres version: 1.14.0 installed in: /home/blingshock/me8287_ws/devel_isolated/ceres-solver with components: [EigenSparse, SparseLinearAlgebraLibrary, LAPACK, SuiteSparse, CXSparse, SchurSpecializations, OpenMP, Multithreading]
-- OpenCV version: 3.3.1
-- defined HAVE_OPENCV3
GLOG = glog::glog
-- Configuring done
-- Generating done
-- Build files have been written to: /home/blingshock/me8287_ws/build_isolated/handeye_calib_camodocal
==> make -j4 -l4 in '/home/blingshock/me8287_ws/build_isolated/handeye_calib_camodocal'
[ 33%] Linking CXX executable /home/blingshock/me8287_ws/devel_isolated/handeye_calib_camodocal/lib/handeye_calib_camodocal/handeye_calib_camodocal
CMakeFiles/handeye_calib_camodocal.dir/src/handeye_calibration.cpp.o: In function cv::Mat::Mat(int, int, int, void*, unsigned long)': handeye_calibration.cpp:(.text._ZN2cv3MatC2EiiiPvm[_ZN2cv3MatC5EiiiPvm]+0x2a1): undefined reference to cv::Mat::updateContinuityFlag()'
collect2: error: ld returned 1 exit status
CMakeFiles/handeye_calib_camodocal.dir/build.make:224: recipe for target '/home/blingshock/me8287_ws/devel_isolated/handeye_calib_camodocal/lib/handeye_calib_camodocal/handeye_calib_camodocal' failed
make[2]: *** [/home/blingshock/me8287_ws/devel_isolated/handeye_calib_camodocal/lib/handeye_calib_camodocal/handeye_calib_camodocal] Error 1
CMakeFiles/Makefile2:1091: recipe for target 'CMakeFiles/handeye_calib_camodocal.dir/all' failed
make[1]: *** [CMakeFiles/handeye_calib_camodocal.dir/all] Error 2
Makefile:138: recipe for target 'all' failed
make: *** [all] Error 2
<== Failed to process package 'handeye_calib_camodocal':
Command '['/home/blingshock/me8287_ws/devel_isolated/ceres-solver/env.sh', 'make', '-j4', '-l4']' returned non-zero exit status 2
Reproduce this error by running:
==> cd /home/blingshock/me8287_ws/build_isolated/handeye_calib_camodocal && /home/blingshock/me8287_ws/devel_isolated/ceres-solver/env.sh make -j4 -l4
Command failed, exiting.

HI, I am getting same error，as shown below:
CMakeFiles/handeye_calib_camodocal.dir/src/handeye_calibration.cpp.o: In function cv::Mat::Mat(int, int, int, void*, unsigned long)': handeye_calibration.cpp:(.text._ZN2cv3MatC2EiiiPvm[_ZN2cv3MatC5EiiiPvm]+0x2a1): undefined reference to cv::Mat::updateContinuityFlag()'
and the opencv version that catkin_make found:
--Found OpenCV: /opt/ros/kinetic (found version "3.3.1")
-- OpenCV version: 3.3.1

I guess this error is caused by a version mismatch.
so I modify the CMakeLists.txt file:
change
find_package(OpenCV REQUIRED)
to
find_package(OpenCV 3.4.5 REQUIRED).
(3.4.5 is the version of OpenCV I installed.)
then the catkin_make error solved !

this looks to be resolved, thanks @zhkai929 !

it  works for me.thx

SET(OpenCV_DIR  <opencv_so.dir>)