"Format Document With" doesn't work the same as codeActionsOnSave

Describe the bug
With editor.codeActionsOnSave.source.fixAll set to true, on save ESLint and Prettier run as expected.
But when using Format Document/Format Document With Prettier ESLint, formatting does not work as expected.
Specifically, the extension "simple-import-sort" only works when using source.fixAll, not when using "Format Document".
To Reproduce
Steps to reproduce the behavior:

Go to '...'
Click on '....'
Scroll down to '....'
See error

Expected behavior
A clear and concise description of what you expected to happen.
Both should behave the same.
Example Project
(If possible, please create an example project here on GitHub.com that exhibits the problematic
behavior, and link to it here in the bug report.
If you are using an older version of GitHub, this will also determine whether the bug has been fixed
in a more recent version)
Screenshots
If applicable, add screenshots to help explain your problem.
Versions (please complete the following information):

VS Code Prettier ESLint extension [e.g. 3.1.0] 5.0.4
Visual Studio Code: [e.g 1.57.1] 1.71.1
Node: [e.g. 12.21.0] 14.19.3
Package Manager [e.g. npm 7.18.1, yarn 1.22.10, pnpm 6.7.6] yarn 1.22.17
prettier: [e.g. 1.9.2] 2.7.1
eslint: [e.g. 6.8.0] 8.21.0

System Specifications (please complete the following information):

OS: [e.g. MacOS Big Sur 11.4] macOS 12.5.1
Processor: [e.g. Intel i7 6-core 2.6Ghz] Apple M1 Pro
RAM Size: [e.g. 16 GB] 16GB

Additional context
Add any other context about the problem here.

@alecrobertson1 Could you create an example project or at least attach your ESLint config file?

Have the same issue


[SILGen] Cleanup profiler handling

Use SILDeclRef::hasUserWrittenCode in shouldProfile, which subsumes existing logic and avoids emitting coverage maps for property wrapper backing initializers without user code (rdar://99931619).
Stop forcing emission of functions for profiling, as we should now always SILGen functions with user-written code.
Remove setUpForProfiling, instead creating the SILProfilers when we emit the function definitions. This matches what we do for other SILDeclRefs.

Also noticed that SILDeclRef::isAnyThunk is an exact copy of SILDeclRef::isThunk, and can be dropped.

@swift-ci please test

@swift-ci please test source compatibility

@swift-ci please build toolchain macOS


Doc for using PowerShell to CRUD firewall rules for Microsoft.DBforMySql

Details for this are missing from the main content. While there are no PowerShell cmdlets specifically related to adding firewall rules to Azure Database for MySQL, the process can be achieved using other cmdlets, achievable in Cloud Shell if desired.
I hope this is acceptable/suitable.

Microsoft authors of articles need to make updates through the private repository so the updates can be staged and validated by the current validation rules. After you review staging and fix all validation issues, you can add the sign-off comment to let the PR reviewers know the updates are ready to be merged.It's easy to access the private repo version of your articles in GitHub. Just add -pr to the URL, as follows:
Public repo URL: https://github.com/Microsoft/azure-docs/blob/master/articles/azure-portal-overview.md
Private repo URL: https://github.com/Microsoft/azure-docs-pr/blob/master/articles/azure-portal-overview.md
We have closed this pull request. Please resubmit the updates through the private repo. If you need perms to the private repo, see the contributor guide instructions


How to use elementOrder?

This is a great package, and it works very well!
I'm trying to figure out how to make elementOrder work. In the example below, I have added two elements, email and password, and removed file upload. I think I have the syntax right, but something must be wrong, since no matter what I do the two I've added appear at the top of the list.
Any suggestions? Thanks in advance for any help you might be able to provide.
formeo = new FormeoEditor({
    editorContainer: '#fb-editor',
    controls: {
        disable: {
            elements: ['upload'],
        },
        elements: [
            {
                tag: 'input',
                config: {
                    label: 'Password',
                    disabledAttrs: ['type']
                },
                meta: {
                    group: 'common',
                    id: 'password',
                    icon: '',
                },
                attrs: {
                    type: 'password'
                },
            },
            {
                tag: 'input',
                config: {
                    label: 'Email',
                    disabledAttrs: ['type'],
                    lockedAttrs: [],
                },
                meta: {
                    group: 'common',
                    id: 'email',
                    icon: '',
                },
                attrs: {
                    type: 'email',
                    name: 'email',
                },
            },
        ],
        elementOrder: {
            // Must be set in conjunction or it may not appear in the group
            common: ['button','checkbox','date-input','email','email','hidden','number','password','textarea','text','select','radio'],
        },
    },

});

Actually, never mind. It worked. It must have been a cache thing.


Command icon doesn't show in editor/title

Issue Type: Bug
The following code stopped working in 1.55.0 while running under extensionHost.  Worked in 1.54.2
      {         "command": "myextension.ExecuteRequest",         "icon": {           "light": "resources/light/play.svg",           "dark": "resources/dark/play.svg"         }       }
      "editor/title": [         {           "command": "myextension.ExecuteRequest",           "group": "1_run",         }       ]
Icon "play" doesn't show up in the editor/title and there is no area in editor/title that would be respond to a click with corresponding functionality.  Keybindings works.
VS Code version: Code 1.55.0 (c185983a683d14c396952dd432459097bc7f757f, 2021-03-30T16:01:55.261Z)
OS version: Windows_NT x64 10.0.19042

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-8565U CPU @ 1.80GHz (8 x 1992)

GPU Status
2d_canvas: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onoop_rasterization: enabledopengl: enabled_onprotected_video_decode: enabledrasterization: enabledskia_renderer: enabled_onvideo_decode: enabledvulkan: disabled_offwebgl: enabledwebgl2: enabled

Load (avg)
undefined

Memory (System)
31.82GB (15.45GB free)

Process Argv
--crash-reporter-id 997c6246-9091-403a-b6d1-1128094b0972

Screen Reader
no

VM
0%

Extensions (13)

Extension
Author (truncated)
Version

azurite
Azu
3.11.0

vscode-eslint
dba
2.1.19

tsl-problem-matcher
eam
0.4.0

rest-client
hum
0.24.4

vscode-azurefunctions
ms-
1.3.0

vscode-azureresourcegroups
ms-
0.3.0

csharp
ms-
1.23.9

python
ms-
2021.3.680753044

jupyter
ms-
2021.5.702919634

azure-account
ms-
0.9.7

debugger-for-chrome
msj
4.12.12

vscode-yaml
red
0.17.0

LiveServer
rit
5.6.1

A/B Experiments
vsins829:30139715
vsliv368cf:30146710
vsreu685:30147344
vspor879:30202332
vspor708:30202333
vspor363:30204092
pythonvspyt875:30259475
vspre833:30267464
vshan820cf:30276953

See #117259 for the testplan item for two related issues that may be relevant. However these changes landed in 1.54

Probably #117593
Since you appear to be an extension developer I recommend that you use Insiders regularly. Doing this should give you early warning of changes that impact your extensions, and time to adapt or get changes made before the next Stable.

Yes, using "editor/title/run" fixed the problem.  I will definitely switch to Insiders.
Thank you gjsjohnmurray.

👍 please close the issue then.

Yeah, the 1_run doesn't exist anymore


ArduinoSA.IDE.stable version 2.3.3

Checklist for Pull Requests

[x] Have you signed the Contributor License Agreement?
[ ] Is there a linked Issue?

Manifests

[x] Have you checked that there aren't other open pull requests for the same manifest update/change?
[x] This PR only modifies one (1) manifest
[x] Have you validated your manifest locally with winget validate --manifest <path>?

[x] Does your manifest conform to the 1.6 schema?

Note: <path> is the directory's name containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

memo
wingetcreate update ArduinoSA.IDE.stable --version 2.3.3 --display-version 2.3.3 -i

winget validate manifests\a\ArduinoSA\IDE\stable\2.3.3
winget install -m manifests\a\ArduinoSA\IDE\stable\2.3.3
wingetcreate submit manifests\a\ArduinoSA\IDE\stable\2.3.3

Use the i option since there is a user and machine.
The display version is also updated to 2.3.3.


Check if resume connection is possible

Describe the bug
Current the client try to always reconnection to gateway when we got a WebSocketCloseEvent:
https://github.com/Skillz4Killz/Discordeno/blob/d612af80d0f3d5d87d9dc3cdd6280e94cd7752a4/module/shard.ts#L109-L112
Expected behavior
We should determine if the connection need to resume but not always resume it.
Some error codes are not recoverable like 4012 Invalid API Version or 4013 Invalid Intent(s).
ref: https://discord.com/developers/docs/topics/opcodes-and-status-codes

@binotaliu Let me know if I am missing any codes you would like to handle differently.

I'm gonna leave this issue open but i have merged the PR so the users can have better error handling until tomorrow. If you see anything i missed let me know here or send another pr for it please 🙏

Havent seen any issues yet so this looks good to close


 tag not valid anymore?

Hey @jdrouet, I was updating the Elixir mjml_nif package to use mrml v2.1.1 and saw an issue with rendering previously valid MJML templates that included an <mj-font> tag. (Also see https://github.com/adoptoposs/mjml_nif/issues/119)
It looks like if I remove the <mj-font> tag from the template and instead pass the fonts render option, then rendering works again as expected.
Is the <mj-font> tag not handled anymore in v2.1.1 or should either way of configuring fonts in the MJML template work?

in should, I'll take a look at that, thanks for noticing!

After looking at it, <mj-font {...attrs} /> is the expected behavior. But I can add the behavior for <mj-font {...attrs}></mj-font>.

@jdrouet Ooh, alright. I just checked again with the self-closing tag and it looks like the issue is how the Elixir template engine renders an embedded template: It turns <mj-font ... /> into <mj-font ...></mj-font> (https://github.com/phoenixframework/phoenix_live_view/issues/1596), which is now an invalid format when passed to mrml.
Is there other self-closing tags that are handled similarily? I could see e.g. <mj-divider /> and <mj-image /> work  and do not throw errors, even though they got changed to <mj-divider ...></mj-divider> and <mj-image ...></mj-image> respectively in Elixir before passing it to mrml.

That's weird, mj-image and mj-divider are implemented exactly the same way 🤔

That was amazingly fast! Thanks, Jérémie, for the fix and all the good work you put into mrml! :heart:


Rework listing mode

Generic functionalities are merged into listing mode, making it into a
widget with an interface to be extended from outside of the shell
core. histlist, location and lastcmd are re-implemented in an embedded
module, using the method mentioned above.

More on loading a elv module when starting editor: later we can also move the default keybindings there.

It is no longer possible to have submode-specific keybindings. ... My suggestion is to preserve edit:binding[histlist loc lastcmd], and teach edit:listing-read to accept extra key bindings. When starting (e.g.) histlist pass $edit:binding[histlist] to it.

I'd prefer to let user providing an anonymous binding map which could override default binding temporarily. It's a more dynamic way to archive.

Separated as a new mode and disabled by default.


Lab1-3: Design and implement save/ restore feature of phone book tree

"Add member functions that use a text file to save and restore tree"
This will require the underlying classes to be available and will utilize file reading/ writing.
Dr. Berman recommends we set up the user interface with an empty phone book first (see issue Lab1-4). If we can perform operations on an empty phone book then we get 90/100 pts, this issue is essentially for the last 10 pts.

merged into master with pull request #12 . All that is left to be done from here is to verify/ validate a bit, maybe prettify, screen shot some input/output examples, zip it up, and turn it in.


SPARK-32097: Enable Spark History Server to read from multiple directories

Change-Id: Ie3e2a6cc08b4c0e8770417c3b66f2f747bebefda

What changes were proposed in this pull request?
Currently logDir just refers to one directory. We would like to add a capability to HistoryServer UI to read from multiple directories.

Why are the changes needed?
To view data from multiple clusters/environments on the same history server

Does this PR introduce any user-facing change?
No

How was this patch tested?
By running existing test suites.

Can one of the admins verify this patch?

Can one of the admins verify this patch?

I'm not sure your PR really deals with reading from multiple directories. The change is listing -> glob with *. Could you please elaborate what is the difference? The change also doesn't have any new unit tests verifying the changes.
In general comment with the idea, having multiple root directories are still possible, but probably better to be just a static list (IMHO) instead of regex, as listing with glob pattern is known to be very slow.
One thing I'm afraid of having multiple root directories is, SHS is already very complicated in point of thread-safety view even we only allow single root directory, and it may make things more complicated. I'm on the fence on doing this, until we are clear that this won't make SHS more complicated.

I'm not sure your PR really deals with reading from multiple directories. The change is listing -> glob with *. Could you please elaborate what is the difference? The change also doesn't have any new unit tests verifying the changes.
In general comment with the idea, having multiple root directories are still possible, but probably better to be just a static list (IMHO) instead of regex, as listing with glob pattern is known to be very slow.
One thing I'm afraid of having multiple root directories is, SHS is already very complicated in point of thread-safety view even we only allow single root directory, and it may make things more complicated. I'm on the fence on doing this, until we are clear that this won't make SHS more complicated.

Thanks for your response! By multiple directories I meant that a regex could potentially match more than one directory. In case of external file system, glob pattern might be better considering we will have to make just one over the network call. Also, it will be easier for the user to specify just one setting, instead of multiple values. What do you think?
I will add the unit tests. Thanks for pointing out.
MHS will function only as a read only server. Can thread-safety be an issue in that case?

SHS isn't a read-only; there's also a cleanup phase, and load and cleanup phases are running in parallel. Please take a look at the SHS code in master branch thoughtfully.

SHS isn't a read-only; there's also a cleanup phase, and load and cleanup phases are running in parallel. Please take a look at the SHS code in master branch thoughtfully.

Thanks. I will go over those phases and ensure there aren't any concurrency concerns.

I don't think Spark has the concept of "clusters". Even I don't think Spark has the concept of "cluster", unless you use standalone mode. If the rationalization of SPARK-32097 and SPARK-32135 is to make SHS be cluster-wise, then probably the concept of "clusters" needs to be defined and introduced, instead of having some fixes for workaround.
Everyone has different views on being "cluster-wise". e.g. If SHS is cluster-wise, I would prefer "isolated view" per cluster, like selecting the cluster first, and see restricted view for the cluster. I wouldn't prefer listing all applications from all clusters in the same list. This would be the opposite view you're proposing in SPARK-32135. So that's not a trivial thing. It warrants the discussion, including we really want to make it be "cluster-wise".

cc @rednaxelafx  @jiangxb1987

I don't think Spark has the concept of "clusters". Even I don't think Spark has the concept of "cluster", unless you use standalone mode. More specifically, there's no strong relation between applications, and there's no sort of control plane for Spark side to control all applications in the cluster. The cluster is actually resource scheduler's cluster.
If the rationalization of SPARK-32097 and SPARK-32135 is to make SHS be cluster-wise, then probably the concept of "cluster" needs to be defined and introduced, instead of having some fixes for workaround.
Everyone has different views on being "cluster-wise". e.g. If SHS is cluster-wise and supports multi-clusters, I would prefer "isolated view" per cluster, like selecting the cluster first, and see filtered view for the cluster. I wouldn't prefer listing all applications from all clusters in the same list. This would be the opposite view you're proposing in SPARK-32135. So that's not a trivial thing. It warrants the discussion, including we really want to make it be "cluster-wise".

Hey, I have updated the JIRA with a more elaborate description of our use-case. Initially, I had tried to keep it general but I noticed that has caused a lot of unintended confusion. Apologies for that. Could you review our use-case again and we can discuss what you think would be a better way to support it.


Create dask.gdf from collection of GDF fragments

Subscribe

TODOS:

[ ] add test to fragmented serialized data in different partition and combine them into one


Added One Hot Encoding

A part of issue #173 has been addressed here. Rest of the issue will be addressed soon.
✔ Check List (Check all the applicable boxes)

[ ✔] My code follows the code style of this project.
[✔ ] This PR does not contain plagiarized content.
[ ✔] The title of my pull request is a short description of the requested changes.

@Suvodeep-Das Please add the remaining part as well. PR will be reviewed later.


Compare outputs with icclim

Description
Include comparison of ICCLIM results into the tests.
In particular, check how ICCLIM handles spells that last longer than the resampling period.

ICCLIM does not seem to work out of the box with our files in testdata. It complains about missing _FillValue attributes or NETCDF4 format... Could we add a couple of test data files from CMIP5 (tasmin, tasmax, tas, pr) with a normal calendar ?
I've been able to run tests with ocgis however, and CFD (consecutive_frost days) yields the following results for calc_grouping ['month', 'year']:
array([31., 28., 15., 23., 13.,  2.,  0.,  0.,  2.,  8., 27., 31.],
      dtype=float32)

which suggests that the array is resampled first, then the condition is evaluated.
Integrating explicit ICCLIM tests is going to be a pain before the refactoring Xavier is doing.
I suggest we close this issue and reopen it when ICCLIM is updated.

From the tests I've done with ICCLIM I can say that it's a pain to work with. I had the same problem with subsetted files.
I only succeeded in installing ICCLIM on python 2.7 also.

@huard Are we still interested in working on this issue?

I would say no... but only because I have had too much trouble installing / running ICCLIM to make it a worthwhile endeavor.

I've understood there is a new release of ICCLIM. Maybe worth checking.

Ideas:

Open a ticket within https://github.com/cerfacs-globc/icclim about creating a new conda package?
Install the newest version locally and create test data?
@huard will open a channel with Christian Pagé about getting some test data from him?

I just stumble upon this issue and I will at some point do manual/semi-automated tests to compare icclim_v4 and xclim/icclim_v5.
However because icclim v5 will be based on Xclim it will not make much sense to fully automatize tests I think.
By the way if you have issues in installing/running icclim and still wish to do it, don't hesitate to ask me.

Hi @bzah
Do you have any updates? Are you far along in the comparison that you feel this issue can be closed?

Hello @huard,
I just finish yesterday the report comparing icclim v5 (thus xclim) against icclim v4 and Climpact.
I'm expecting a last review from Christian before officially sharing it.
The TL;DR is:

Most indices work just fine.
Indices relying on "consecutive days" have varying result due to #956. However it's not as bad as expected.
Bootstrap algorithm is quite effective. See WSDI chapter for its effect.
The computed percentiles are a bit different between the 3 software, but I could not find why.
icclim v4 could generate some strange results, we are truly happy with what v5 has become thanks to xclim, xarray and dask.

If you want to have a look now, you can grab it on icclim-sandbox release along with all the figures in the zip file.
Don't hesitate to create an issue there if you have any question or remarks.

Went through your report, thanks for all the work !
I'll close this issue, but feel free to open issues to look into differences for specific indices.


questions about image regression

I'd like to use MxNet for image regression, namely my input data is image and output is a number. How can I process my data? I have tried to process in the way as doing image classification, and I change to use a LinearRegressionOutput instead of SoftmaxOutput, but the Train-accuracy=0.00, Could someone tell me where's wrong?

You need to change your eval_metric from 'acc' to 'MAE', 'MSE', or 'RMSE' if you're using the Python package.

Thanks a lot@jmschrei. But how to change the eval_metric?

If you're using python, add eval_metric='rmse' to the fit method.

Thank u. I have solved the problem. And I have another question, how to visualize the learned filters in MxNet. I haven't found relative tutorials. Could you give me some advice for that?

@attitudechunfeng  Could you please give me a little hint on how to use LinearRegressionOutput to do the image regression. My task is to give a regression y(x) from 0-1 and the one-dimensional x is from 0 -> + infinity. Thank you very much.


Review RDBES: visibility of certain codetypes

Should be visible?
https://vocab.ices.dk/?ref=1654

for the RDBES team to discuss, if it should stay in RECO.
If it stays, consider  generalizing the label, and making it invisible

Codes: Admin, Download, Upload
@EjazAtIces: could you give an update?

We should delete these codes and code type RDBES_CT_PageAccess.
@HenrikK-N , @cekv please let me know once you are ready to delete so I can deploy RDBES


fix: fix regex for parsing git branch

In certain cases the trailing ) produced by git show -s --pretty=%d HEAD was kept in the branch name.

:tada: This PR is included in version 2.0.1 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


[fix][fn] Fix function update error

Fixes #19721

Master Issue: #xyz

PIP: #xyz

Motivation
functions are failed to update when --py|--go|--jar is specified
Modifications
add 1 to functions' version when uploading package while updating functions
Verifying this change

[x] Make sure that the change passes the CI checks.

(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)

[x] This change added tests and can be verified as follows:

Added integration tests for updating function code file

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

[ ] Dependencies (add or upgrade a dependency)
[ ] The public API
[ ] The schema
[ ] The default values of configurations
[ ] The threading model
[ ] The binary protocol
[ ] The REST endpoints
[ ] The admin CLI options
[ ] The metrics
[ ] Anything that affects deployment

Documentation

[ ] doc
[ ] doc-required
[x] doc-not-needed
[ ] doc-complete

Matching PR in forked repository
PR in forked repository: https://github.com/jiangpengcheng/pulsar/pull/8

/pulsarbot rerun-failure-checks

Without this fix, when users update a function with the new jar, py or go binary, they will get the following error:
➜  apache-pulsar-2.11.0 ./bin/pulsar-admin functions update \
--py examples/python-examples/exclamation_function.py \
--classname python-examples.ExclamationFunction \
--inputs public/default/test \
--output public/default/test-output2 \
--name ExPy2 \

Package 'function://public/default/ExPy2@0' metadata already exists

/pulsarbot rerun-failure-checks

/pulsarbot rerun-failure-checks

Codecov Report

Merging #19895 (aff1693) into master (1e44ba1) will increase coverage by 37.55%.
The diff coverage is 32.96%.

@@              Coverage Diff              @@
##             master   #19895       +/-   ##
=============================================
+ Coverage     24.42%   61.97%   +37.55%
- Complexity      291    26087    +25796
=============================================
  Files          1603     1859      +256
  Lines        124343   136817    +12474
  Branches      13571    15047     +1476
=============================================
+ Hits          30369    84795    +54426
+ Misses        89490    44279    -45211
- Partials       4484     7743     +3259

Flag
Coverage Δ

inttests
24.38% <19.78%> (-0.05%)
:arrow_down:

systests
25.23% <26.37%> (?)

unittests
59.31% <32.96%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...ker/loadbalance/extensions/models/TopKBundles.java
0.00% <0.00%> (ø)

...nsions/policies/AntiAffinityGroupPolicyHelper.java
0.00% <0.00%> (ø)

...extensions/reporter/TopBundleLoadDataReporter.java
0.00% <0.00%> (ø)

...dbalance/extensions/scheduler/TransferShedder.java
0.00% <0.00%> (ø)

...java/org/apache/pulsar/common/util/FutureUtil.java
79.62% <61.53%> (+49.10%)
:arrow_up:

...ar/metadata/coordination/impl/LockManagerImpl.java
89.47% <71.42%> (+31.57%)
:arrow_up:

...metadata/coordination/impl/LeaderElectionImpl.java
71.79% <75.00%> (+18.89%)
:arrow_up:

...org/apache/pulsar/broker/ServiceConfiguration.java
98.74% <100.00%> (+0.84%)
:arrow_up:

...ulsar/functions/worker/rest/api/FunctionsImpl.java
52.36% <100.00%> (+51.61%)
:arrow_up:

...he/pulsar/functions/worker/rest/api/SinksImpl.java
51.33% <100.00%> (+50.60%)
:arrow_up:

... and 1 more

... and 1382 files with indirect coverage changes

/pulsarbot rerun-failure-checks

@nlu90 Do we need to cherry-pick to other branches for this patch ?


[stable/kube-bench] Update kube-bench image to 0.8.0

bump kube-bench chart version to 0.1.16

Description
Update kube-bench image to 0.8.0
Checklist

[x] Title of the PR starts with chart name (e.g. [stable/mychartname])
[x] I have read the contribution instructions, bumped chart version and regenerated the docs
[ ] Github actions are passing

Unsure why the checkout failed for the conftest, maybe rerunning it helps?
or upgrading actions/checkout to v3?

Hmmm, looks to be some issue with Github actions OS image:
Post job cleanup.
/usr/bin/docker exec  4fcd1ec9d83cb4e878b9[2](https://github.com/deliveryhero/helm-charts/actions/runs/9835887256/job/27151236239?pr=589#step:7:2)3d6331bafdad5a5df3770d0ce7553016e37e1d71674 sh -c "cat /etc/*release | grep ^ID"
Error relocating /__e/node20_alpine/bin/node: secure_getenv: symbol not found


Does Chromely support Media Source Extensions?

I am using flv.js(https://github.com/bilibili/flv.js) to play video that relies on Media Source Extensions, it works fine on Chrome(Version 91) and other browsers.
Please tell me why if you know. Thanks!

@jim-lin507 Chromely is based on CEF/CefGlue, so if it does not work, it may be proprietary issue - https://www.magpcss.org/ceforum/viewtopic.php?f=17&t=18373


feat!: pass preventScroll to focus and autoFocus

This migrates to an opts object for focus and an object for autoFocus prop. This lets users pass this option to the underlying lexical editor.
BREAKING CHANGE: use opts object instead of strings | boolean

Makes sense. I will go over that during the weekend.


Cancelling SMT build hangs until engine is built then throws 404

During testing, I've observed that if I build an SmtTransfer engine and then attempt to cancel it, it doesn't interrupt the build process but waits til it's built then throws a 404 because there is no active build. Have you observed this, @johnml1135 ?

The main cause of this issue is that we are not checking the cancellation token often us when training an SMT model. I am reopening this issue, because it has not been addressed yet.

@Enkidu93 - has this been fully addressed?  I believe it has...

@ddaspit  has this been resolved?

My apologies, @johnml1135. Somehow your earlier comment slipped under my radar. I'm happy to investigate this unless @ddaspit has already determined the answer (?).

I can now verify that this has been addressed.


Update builds to use Go modules

We have updated the master branch to use Golang 1.12.5 for builds and testing.
Our builds/tests continue to use Golang _vendor_ing because we build on the GOPATH.
This issue is move to using Go modules and not use the vendor directory (and it could be removed).
Note: this issue is created based on a discussion with @geeknoid about what needs to be done to get to Go modules.

A first step to see where we are is to create a new Istio-builder image where GO111MODULE is set to on (will force module usage even on the GOPATH) https://github.com/istio/test-infra/pull/1370
Once this image is created, the test-infra yaml for the prow-staging branch can be updated to use the image and we can see what additional changes are required.
Note that other issues are needed to finish this work:
https://github.com/istio/istio/issues/14795
https://github.com/istio/istio/issues/14475

Note that there is discussion on this within #14795 as well.

We could not assume every user can access the vendor pkgs very easily. Take me as an example, i can not access k8s.io, gcr.io, etc, directly.

#15056 added vendor check in ci

PR #15166 uses an Istio-builder image which set GO1111MODULE=on as a test in the prow-staging branch.

Note that there are some places doing hacky stuff with paths (like computing GOPATH from something istio-specific instead of $(go env GOPATH), putting istio-specific stuff under GOPATH and using all that to locate other things like test data). If you just enable GO111MODULE but don't get rid of dependencies on GOPATH from scripts and code, it may work correctly by accident but start doing weird things as soon as somebody decides to move the Go module somewhere else (because, why not? Go modules are supposed to work from anywhere on the file system..).
All that is to say to setting GO111MODULE is a step forward, but alone it may leave us in a more brittle state so if we're going to do it we should commit to eradicating GOPATH dependencies.

Done by https://github.com/istio/istio/pull/16668. Thanks for all the work from @ericvn and @geeknoid to allow me press to easily press the rm -rf vendor button


Experimental classes in high-level package

Feature description
After the discussion in the developers meeting, this issue is open to continue discussion for a higher-level API. I think this high level API would mimic PyBOP workflows, but could also provide other functionality. An example API for this package (pbx?) would be:
import pbx

pbx.load("path/to/data")
pbx.gitt(pbx.spm, parameter_set=params, etc.)
pbx.plot()

@martinjrobins @davidhowey @brosaplanella @NicolaCourtier
Motivation
This could provide a nice entry point for new-users; however, we would need more development resources to maintain both packages.
Possible implementation
No response
Additional context
No response

Sorry for the delayed response, still clearing off backlog from before Christmas. I am not sure I see all the advantages of having a separate package. If pbx just contains the wrapper classes to streamline the process, it will be quite light but still require PyBOP as a dependency, so we will only be shaving a few lines of codes from PyBOP but we now have 2 packages to maintain and keep synced.
IMO, these wrapper classes could coexist with the more detailed workflows. It would be similar of how PyBaMM can be easily streamlined with a simulation of a standard model, but you can also use the methods in it to solve your own models.


Enable Deployer-Specified Name for SAML2 pac4j clients

In order to differentiate multiple SAML2 Delegated AuthN clients on the login page, expose the "Name" field of the SAML2Client pac4j class via CAS properties such that deployers can set a unique name for each SAML2 client like this:
cas.authn.pac4j.saml[0].clientName = This Org
cas.authn.pac4j.saml[1].clientName = That Org

CAS server version 5.1.0
Container/environment type/version (Tomcat, Jetty, Java, Linux/Windows, etc) Tomcat 8.5 on Linux

I have a patch for this, but it will take some time for me to fiddle around with github and get the CLA stuff in place to ask for a pull request.

Outstanding. Please speak up if you run into any issues with that process and worst case,  feel free to paste/attach the patch here and we'll import it under your name.

Also, you may want to two pull requests: one for 5.1.x and one for master as target branches. Or, do one branch and I can lend a hand with porting it to the other relevant branches if needed.

Hi there, have you had a chance to review this issue again and make progress?

I've been promised an answer on the CLA by the beginning of next week.  I'll push to my repo and start a pull request then.

Outstanding. Please remember that CLA's on our side are optional for all contributors. The ask is only a sign of good will. So you perfectly CAN start with the work without ever having to sign the CLA.
If you were to become a committer, different issue.

So the organization sponsoring my work (not my employer) has declined the CLA, but they're happy for me to put my changes on github and do a pull request, which I'll once master builds successfully again.

Outstanding. Master should be back to normal. Check with Travis for full clarity.


[11.x] Add in() and inHidden() functions to Context Stacks

I'm really liking the addition of Context and the support for stacks. But I was missing a function where you could easily check if a certain value actually is within a stack. It's basically just adding in_array() support for the stacks.
You could use it as follows:
# Normal
Context::push('foo', 'bar', 'lorem');

Context::in('foo', 'bar'); # true
Context::in('foo', 'doesNotExist'); # false

# Hidden
Context::pushHidden('foo', 'bar', 'lorem');

Context::inHidden('foo', 'bar'); # true
Context::inHidden('foo', 'doesNotExist'); # false

This is really cool! Very handy for when you're building analytics around contextual requests, or pulling out trends.

A thought that just passed my mind, I could possibly also make the $strict an optional passable parameter for the in_array. Where it's non-strict by default, but can be made strict by passing true.
Not sure if that's needed, though.

An optional parameter isn't going to be breaking, I'd go for it.
This would be super useful in pulse!

Added it, and a test to ensure strictness works!

I've proposed a change to the closure based functionality in https://github.com/laravel/framework/pull/52381


Release workflows

These changes are made under both the "Apache 2.0" and the "GNU Lesser General
Public License 2.1 or later" license terms (dual license).
SPDX-License-Identifier: Apache-2.0 OR LGPL-2.1-or-later

In general, I see that distributing linux binaries is a way to go, but I don't think it is what we want to do in the long term.  What would be better is if we select a small number of Linux distributions (like Ubuntu or CentOS) and build packages appropriate for the platform (e.g., for use with apt or yum).  On MacOS, I would recommend a Homebrew formula (which would work for Linux, as well, but very few people use Homebrew on Linux).  Since we have no CI for FreeBSD, we can't readily create a pkg file for that platform.
Ideally, this would include all the bits that are created after a make install, which includes the wrapper script that allows you to run atomvm (all lover case) without having to specify the location of the atomvmlib.avm core library.
For example, here is what happens when you run make install
Install the project...
-- Install configuration: ""
-- Up-to-date: /usr/local/lib/atomvm/AtomVM
-- Up-to-date: /usr/local/bin/atomvm
-- Up-to-date: /usr/local/bin/PackBEAM
-- Installing: /usr/local/lib/atomvm/atomvm.avm

However, I understand this is a stop-gap measure so that we have something, rather than nothing.


Subscription checks very complicated

Need three roles:
Self-Configured integration
Satellite 6 Integration
subscription-manager integratation
Checks:
Check if packages available from needed repositorys.
For Demo Scenario:
Use RedHat Login as variable
execute following commands (example):
subscription-manager clean
subscription-manager remove --all
subscription-manager register
rm -rf /etc/yum.repos.d/*
rm -fr /var/cache/yum/*
yum clean all
subscription-manager list --available --all
subscription-manager attach --pool=xxx
subscription-manager release --set=7.2
subscription-manager repos --disable=rhel-7-server-rpms
subscription-manager repos --enable=rhel-7-server-eus-rpms
Deltarpm is necessary for the following rpm installation ?!?!
yum install -y deltarpm

@tbludau There is some good work that can be done here.. Both in specific tasks and structure.
Many of these tasks where the shell or command modules are being used for subscriptions can be remediated using either the redhat_subscription or yum_repository modules.
As far as structure we should be able to reduce some of these plays by enforcing a desired state around subscriptions rather than doing checking like so:
- name: Reset all previous repositories
  shell: |
    subscription-manager repos --disable="*"
    num=0
    for r in /etc/yum.repos.d/*.repo; do
      num=$(( num + $(grep  -c "^enabled.*=.*1$" $r) ))
      sed -i 's/^enabled.*=.*1/enabled = 0/g' $r
    done
    echo "$num"
  register: repo_cleanup
  changed_when: repo_cleanup.stdout > 0
  failed_when: repo_cleanup.rc > 0
  when: force_repo_reset

We shouldn't need to do loops in tasks for each repo, the yum_repository module should be able to disable all repos. We should also try to get to a state with this role assuming that we either want to force a repo reset every time or not before this task.
If there are instances where the answer is 'it depends' we should try to be more selective in resolving repo conflicts
Lastly, I think we can restructure the suggest roles into either 'self-configured' or 'subscription-based'. We should be able to perform a couple of tasks based on wether a Sat 6 URL var is present or not, then proceed as normal.
Thoughts?

@tbludau I think we can close this task -- there is a lot of cleanup to be done in issue #13 so I can resolve some of these.

@tbludau question though..  are we setting a strict level on ansible version? There's currently a new rhsm_repository module in the development stream for ansible 2.5 that might clean up some of this too.

hey @kyleabenson thanks for your input and sorry for my delayed response. as you descibed we can close this case, because it should not be part of the ansible deployment and brings a lot of erros in aws and azure environments.


Error running from examples

No error compiling the program. Error when running.
thread 'main' panicked at 'called Result::unwrap()on anErr value: PerformError { error: Error { repr: Custom(Custom { kind: Other, error: Error { description: "Problem with the SSL CA cert (path? access rights?)", code: 77, extra: None } }) } }', /checkout/src/libcore/result.rs:860

Hm this looks like curl is attempting to probe CA path locations but the permissions are off? Do you know if that is true on your system?

Yup, I'm using this example from tokio-curl https://docs.rs/tokio-curl/0.1.9/tokio_curl/
Cargo.toml
[dependencies]
tokio-curl="0.1.9"
curl="0.4.8"
futures="0.1.14"
tokio-core="0.1.9"

Yes. Working in Windows 10 Pro but not in GNU/Linux Lubuntu 16.04

Sorry I don't know where this would come from :(
You may want to try digging around in curl's source to see where this error comes from, but short of that I don't otherwise know how to fix this offhand.

It's okay, @alexcrichton , I'll try to find out the problem. I just want to make sure that the bug is not from tokio-curl

I had this error message (Debian stretch at this time) for a package that was probably using curl through the same path, in my case cargo-outdated's cargo code. (While cargo had no problem, the difference being of course that cargo-outdated was compiled locally).
I fixed it by uninstalling libcurl3-nss, the nss version does not support reading pem certificates at this time (The problem is something like that). The package manager should ensure that an alternate libcurl library remains installed, otherwise se to that.
After package removals, I rebuilt cargo-outdated and it worked fine.


Track clicks when element inside of  tag  is clicked.

Expected result:
Clicking on image results in tracking
Actual Result:
Clicking on image does not result in tracking.

Hey @fleitz, thanks for the PR, and sorry for the delay (have been focused on other projects). This change makes sense to me. Instead of setting matchedElement on the event, it would be good to make this the matched element (as libraries like jQuery do).

Yeah, that sounds like a way cleaner way to implement.

@ankane implemented.

Thanks @fleitz! This is a great feature.


Refactor: Memory to z3 Array (Issue #685)

Memory is now byte indexed
Memory is a z3 Array
Still need to write unit tests for new memory

@nbanmp , whenever memory is extended, the gas should be consumed.

After the work I've done on this, I don't think we should actually make the switch to a z3 array, and instead we should just use a list wrapped in a class that handles the important logic for stored symbolic values. It is probably a cleaner and faster solution to #685, as long as we don't need symbolic indexes.
As such, I'm going to close this for now and open a new pr later this week with a better implementation.


REST API is inconsistent + No need for a try/catch block in Update a Promotion

Describe the bug

Delete accepts a UUID and Read and Update accept a String as an ID. Make it consistent with the model.
There is no need for a try/catch block in Update a Promotion because the deserialize() method will do that for you.

To Reproduce
Steps to reproduce the behavior:

Go to '...'
Click on '....'
Scroll down to '....'
See error

Expected behavior
A clear and concise description of what you expected to happen.
Observed behavior
A clear and concise description of what you actually saw.
Screenshots
If applicable, add screenshots to help explain your problem.
Additional context
Add any other context about the problem here.

solved in #38


feat: add a feature flag to disable updates email for signees

 As a Petitions clerk I want to ensure that a signee doesn't expect updates about a petition that I can't supply.


pythone keep crashing

how to fix duhhhh

its only work with python 3.9

i have 3.9 tought it still crashes after copple mins saids "error" or sum

yeah this was a bug in my code should be good now


GPU performance issues

Hi,
I tried a modified demo.py as recommended in the issues using the link https://debuggercafe.com/inference-using-yolopv2-pytorch/ but I don't get the improvement of fps switching from cpu to gpu.
I used the pre-trained model on an NVIDIA A4000 GPU and as input a 482x302 jpg image and updated pytorch to 1.13.1.
Result fps with cpu: 2.5
Result fps with gpu: 0.6
Does anyone know if I'm doing something wrong?
Thank you in advance.

Update: I tried Google Colab enabling GPU (NVIDIA Tesla T4) with torch version 1.13.0+cu116 and inferred an image 100 times and got 57 of average fps instead with NVIDIA A4000 and updated torch the performance is very low (see previous comment).
What could be the problem?


New Component: Just a test

Detailed description of the component, its design and behavior
Test
Do you plan to use this component for web applications, mobile or both?
Test
Upload a screenshot or reference an example if possible
Test
Why do you need this component?
Test
Do you have a deadline?
Test
What project is this component for?
Test
Additional information
Test

Your Issue has been approved! You can follow the latest status on our public backlog board. Thank you for your contribution!


Add a review - An Api endpoint to add review to product

Note: Access to the endpoint is only from verified user

fixed


Add Schedule Functionality

Back in the Watchtower days, we had the "--schedule" feature. Instead of specifying an interval to perform checks, you could define a cron-like schedule to perform updates. That way, you could have your containers update at 5am every day, when you or others aren't using your containers. Or, you could have it update every hour on the hour, instead of being relative to when the Ouroboros container started.
I would love to see this feature implemented! As an aside, the ability to specify a time zone would probably be nice to have as well, for ease of scheduling.

I'm a little on the fence on adding this to app for a couple of reasons:
There's nothing stopping a user from implementing their own crontab that does:
via docker
*  5  *  *  * docker run --rm -d --name ouroboros -v /var/run/docker.sock:/var/run/docker.sock circa10a/ouroboros --interval 1 --runonce

via pip installed cli
*  5  *  *  * ouroboros --interval 1 --runonce

This allows ouroboros to run one time then boom, done. With the user handling their own schedule details.
The other reason is because I couldn't find a good python lib to handle the crontab syntax for executing functions. I'd have to build my own regex parser which isn't a huge deal, but feels kind of hacky. I'm totally against the idea, I guess I'm just trying to weigh the advantages of having it vs using regular cron.
Thoughts @dannysauer @tlkamp ?

@circa10a I have to agree. I don't want to go reinventing a scheduling tool that's still very widely used

Maybe just add some sweet docs for scheduling?

Strongly seconded. Using cron (or, even better, systemd timers - which would allow for "service 2 update happens when service 1 is back up" and "only run update if service 3 is running and service 4 is not" kinds of complex logic) is the right way to do this.

Arch Linux provides some nice documentation on use of timers at https://wiki.archlinux.org/index.php/Systemd/Timers.

Sounds like it's decided. We won't add it to the application, but will be sure to provide docs around the subject.

I went ahead and created a Docker image that extends this one and includes cron in it: https://hub.docker.com/r/phasecorex/ouroboros-scheduler. It serves my needs, and completely replaces how I was using Watchtower. Maybe others who used the --schedule argument in Watchtower will find use in this as well.
I like relying on the underlying OS as little as possible. That way, my Docker containers won't break if I move them to a host missing certain programs (cron) or using a different init system. The more the container can do on it's own, the better.

@PhasecoreX Very cool! That's what open source is all about. Be sure to set up an automated build so you can continually get the new features!

@PhasecoreX
One thing I want to add, in your repo you said that the args aren't changeable. All of ouroboros' args can be interchanged with environment variables, so you can indeed modify the parameters without hardcoding them in the entrypoint. You can see the environment variables in the README


chore: update README image path

:tada: This PR is included in version 1.0.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


add example of a c-based extension

See perhaps here on how to  add an C-file + swig wrapper using setup.py's Extension module:
https://scipy-lectures.github.io/advanced/interfacing_with_c/interfacing_with_c.html
Make example of an algorithm implemented in c as an extension.  This is not quite the same thing as including a C library in the package (like libeventio), which should perhaps be done via a conda package or similar...

:+1: to add a swig-wrapped C file as an example.
We should also add a Cython-wrapped one, which is what most scientific Python packages use.
Maybe it would be best to have a ctapipe.examples sub-module or something like that, which contains very simple commented examples of interfacing with C code or using Numba?

Maybe the cython stuff from @MaxNoe in https://github.com/fact-project/pyeventio could serve as a nice example on how to speed up Python with Cython.

I don't think we should add examples that are not needed here.
As soon as we decided we need an extension for some task, we can add the extension, but I would not add one just for the sake of having an example.


Crash on start on Android tablet with Hello_World

I'm having a weird issue on Galaxy tablet. When I run the command flutter run in the hello_world directory, the app crashes on start. Flutter_gallery works fine though. Seems to only happen on my tablet, tested on a phone, the app starts as expected. This is happening on the most recent build of flutter. The gist is here: https://gist.github.com/jslavitz/c5d9ad43b1332512a168522d14622617
Flutter doctor:
[✓] Flutter (Channel master, v0.10.1-pre.102, on Mac OS X 10.13.6 17G65,
    locale en-US)
[✓] Android toolchain - develop for Android devices (Android SDK 28.0.1)
[✓] iOS toolchain - develop for iOS devices (Xcode 9.4)
[✓] Android Studio (version 3.1)
[✓] IntelliJ IDEA Community Edition (version 2018.1)
[!] VS Code (version 1.27.2)
[!] Connected device
    ! No devices available

! Doctor found issues in 2 categories.```

Did #6619 fix this issue?


List uncompleted tasks

Is your feature request related to a problem? Please describe.
We need to list the tasks we have to accomplish.
Describe the solution you'd like
Use getTasksList method in getting the list of uncompleted tasks. Filter the data you get to show only tasks where isDone is set to false. Use jquery to manipulate DOM. Keep it clean and minimal, prefer encapsulating code into a function.
Please make sure that the web app is still cohesive and uniform when your changes are added before opening the PR.
Describe alternatives you've considered
N/A
Additional context
N/A

Hi @andresitodeguzman , I'd like to work on this issue. Hope you can assign it to me.

I'll send a PR soon


update quickstart.rst: a2enmod requires apache2.2-common, sudo missing

some fixes for quickstart on debian-8.4.0
[X] SSH-Server
[X] Standard-Systemwerkzeuge
update for #377

add missing sudo

Thanks for your contribution, I will add the hint on the package selection to the docs.
I am sorry but I still do not see any need for apache2.2-common, on a fresh install of debian using the provided vagrant setup I get:
which a2enmod
/usr/sbin/a2enmod
aptitude show apache2
Package: apache2
State: installed
Automatically installed: yes
Version: 2.4.10-10+deb8u4
aptitude show apache2.2-common
Package: apache2.2-common
State: not installed
Version: 2.4.10-10+deb8u4
I also disagree adding sudo by default - sure it is handy and a very common way to work on debian but its not required for the PoC itself


refactor(core): refactor md files

added dependabot autocheck target: dev branch

added FUNDING config

added CODE_OF_CONDUCT.md, SECURITY.md, CONTRIBUTING.md

added gitignore

added pull/bug templates

added pylint base

optimized README.md, split into DEVELOPMENT.md, INSTALL.md, TROUBLESHOOTING.md

optimized style

fixed typos

#28

Thank you @JuanVilla424  for the great work !


add option for resolving links

Was having an issue where i was using richTextOutputFormat: 'none'
The assets being linked in the richtext eg: an image was not pulling in the data as resolveLinks is hardcoded to false.
added an option to set to true

Hey @melono6,
Just curious, how do you access images from within the rich text field?

you enable the option in rich text settings on the right

and then you can add in top right in the richtext

Hey @melono6
Thanks for the PR, approved.
P.S.: in my previous question I meant how do you access images embedded in rich text from within your website code.
Also note, that with this flag, Contentful will resolved links between the objects.
But this Sourcebit plugin has its own method of resolving objects by using value.sys.id of one field to match id of another object:
https://github.com/stackbit/sourcebit-source-contentful/blob/23e13cbf4b/lib/contentful-util.js#L71-L84
I hope these two methods of resolving links won't conflict.

i am using the contentful rich text package
https://www.npmjs.com/package/@contentful/rich-text-react-renderer
you then pass the array that contentful gives you into the function and can provide differnet rendering for different node block types:
eg:
{documentToReactComponents(richText, {           renderNode: {             [INLINES.HYPERLINK]: (node, renderedValues) => {               return (                 <Link href={node.data.uri} passHref>                                        {renderedValues}                                    </Link>               );             },             [BLOCKS.EMBEDDED_ASSET]: (node) => {               return (
                   <Image                     src={node.data.target.fields.file['en-US'].url}                     alt={node.data.target.fields.file['en-US'].fileName}                     width={node.data.target.fields.file['en-US'].details.image.width}                     height={node.data.target.fields.file['en-US'].details.image.height}                   />
               );             },             [INLINES.ENTRY_HYPERLINK]: (node, text) => {               const { slug } = node.data.target.fields;               return (                 <Link href={/${slug}} passHref>                   {text}                 </Link>               );             },             [INLINES.ASSET_HYPERLINK]: (node) => {               const { title, file } = node.data.target.fields;               const { url } = file;               return (                 <Link href={url} passHref>                                        {title}                                    </Link>               );             },           },         })}
the image node being BLOCKS.EMBEDDED_ASSET in above snippet

Published under v0.6.5


Add more fixture files with Lighthouse data

Feature Description
We currently have 1 single fixture file for the https:\\amp-wp.org page.
We should extend this to have multiple pages across multiple real domains as fixture files, so that we can use the --url flag to choose one of multiple fixture files. These should include official pages from the AMP and/or WordPress project.
Ideally, we would have enough fixture coverage to have most or all of Lighthouse's audits be triggered for producing data.
To ensure we can easily maintain this, the fixture files should be generated via a script that we can trigger at a later point to update the fixture files.

Based on the discussion with @westonruter & @ediamin so far, this is the current plan:

Build a script to easily pull up a WordPress server locally that can be made accessible to the public. A possible implementation might use WP-CLI to set up a server, use the wp server command to serve it locally, and then use ngrok to make that server publically accessible.
Build a script to audit a URL via the PageSpeed Insights API and store the JSON result under the tests/fixtures folder, using the URL and the versions of both PageSpeed Insights API and the embedded Lighthouse audit.
Use the AMP plugin reference site implementation to build a "worst possible site" that can trigger all warnings that Lighthouse has to offer. This can also include settings or hacks in ngrok to slow down the network stack.
Build a GitHub Actions workflow that pulls up a server via 1., runs the audit from 2., checks whether there were changes in the tests/fixtures folder, and if so, create a new pull request to add that new fixture file to the repo. This can be based on a similar workflow in the AMP toolbox repo: https://github.com/ampproject/amp-toolbox-php/blob/main/.github/workflows/sync-spec-test-suite.yml

This will allow us to have consistent fixture files to test against, and that keep up-to-date automatically with the latest PSI/Lighthouse changes.

@schlessera Need some help for the point 3. I'm currently using the wp post create to generate a post from a html file with some content. Could you please suggest me what content should I use to generate fixture file? What content should I use to build the "worst possible site"?

Update: Working on the GitHub workflow. It is almost finished. Tested it in a fork and it is working fine so far. After this I'll build the WordPress content against which we will run the PageSpeed Insight tests.


Enhancement: Pump card for the Builder

It would be a good idea because it adds a tool that can be used a lot in the custom dimensions.

Yeah, in 1.10.2, there's no pump mods.


Multiselect

#199
Hi, @AllenFang
This is my draft implementation of multi select. I think it works pretty stratiforward although It might cause some issues while using with remote bc I didn't test it.
Please take a look if it's ok with your thoughts.
P.S. I rebased my branch to develop so had to recreate PR

Hi, @AllenFang
Actually I have a couple more ideas about custom filters so could you please review the PR to say whether it's OK from your perspective? I'd like to implement range filter as well, I think the same way.

@Ignalion sure, sorry I'm a little busy recently, will have a look in this couple day, thanks

@AllenFang is it possible to merge this today?
Currently, my project needs a multifilter select functionality, any help/idea how would I add achieve this?

@AmitKKhanchandani sorry, I think I still need some works on this PR, if ok, probably able to release in this weekend.

@Ignalion I think you have to rebase your branch firstly, you contain a wrong commit in this patch. If you don't know how to do, you can

recreate a new branch
cherry pick your patch from current branch to new branch
submit a new PR.

I rebased branch from develop and re-created PR #438

released on<EMAIL_ADDRESS>


Documentation:  Remove {rlang} from derive_basetype_records example

Please select a category the issue is focused on?
No response
Let us know where something needs a refresh or put your idea here!
rlang is called in the example but it isn't necessary.  Thus it should be removed

Definition of Done

rlang removed from https://pharmaverse.github.io/admiral/reference/derive_basetype_records.html?q=basetype#ref-usage
Double check no other calls to rlang occur in our examples

A quick one for anyone looking to contribute @pharmaverse/admiral_comm

@bms63 show me the path to the file where it should be updated.

@bms63 show me the path to the file where it should be updated.

@Brijeshthummar02 this is the one - https://github.com/pharmaverse/admiral/blob/6351451ac289b17bf0530e2a7c87cdece8003fff/R/derive_basetype_records.R#L42

@bms63 go through pr #2598.


Parser crashes on incomplete ordered and unordered lists

Ordered Lists
input.md
1.

(no newline at end of file)
error
Raised at Cmarkit_lib__Cmarkit.Block_struct.accept_cols.loop in file "cmarkit.ml" (inlined), line 1961, characters 9-16
Called from Cmarkit_lib__Cmarkit.Block_struct.accept_cols in file "cmarkit.ml", line 1968, characters 4-50
Called from Cmarkit_lib__Cmarkit.Block_struct.accept_list_marker_and_indent in file "cmarkit.ml" (inlined), line 1990, characters 4-35
Called from Cmarkit_lib__Cmarkit.Block_struct.list_item in file "cmarkit.ml", line 2440, characters 23-73
Called from Cmarkit_lib__Cmarkit.Block_struct.list in file "cmarkit.ml", line 2460, characters 32-53
Called from Cmarkit_lib__Cmarkit.Block_struct.parse.loop in file "cmarkit.ml" (inlined), line 2719, characters 15-28
Called from Cmarkit_lib__Cmarkit.Block_struct.parse in file "cmarkit.ml", line 2723, characters 8-17
Called from Cmarkit_lib__Cmarkit.Doc.of_string in file "cmarkit.ml", line 2974, characters 18-38

Unordered Lists
input.md
-

(no newline at end of file)
error
(Invalid_argument "index out of bounds")
  Raised at Cmarkit_lib__Cmarkit.Block_struct.accept_cols.loop in file "cmarkit.ml" (inlined), line 1961, characters 9-16
Called from Cmarkit_lib__Cmarkit.Block_struct.accept_cols in file "cmarkit.ml", line 1968, characters 4-50
Called from Cmarkit_lib__Cmarkit.Block_struct.accept_list_marker_and_indent in file "cmarkit.ml" (inlined), line 1990, characters 4-35
Called from Cmarkit_lib__Cmarkit.Block_struct.list_item in file "cmarkit.ml", line 2440, characters 23-73
Called from Cmarkit_lib__Cmarkit.Block_struct.list in file "cmarkit.ml", line 2460, characters 32-53
Called from Cmarkit_lib__Cmarkit.Block_struct.parse.loop in file "cmarkit.ml" (inlined), line 2719, characters 15-28
Called from Cmarkit_lib__Cmarkit.Block_struct.parse in file "cmarkit.ml", line 2723, characters 8-17
Called from Cmarkit_lib__Cmarkit.Doc.of_string in file "cmarkit.ml", line 2974, characters 18-38

Thanks!
Incidentally this also fixed a position bug I hadn't seen in the test suite that would have been a bit annoying to track.


Encoding performance

Default string literals to be encoded as ascii-8bit so we can avoid calling .b on string literals. Also change string literals to be mutable so we can avoid calling .dup on string literal buffers.
This should reduce method calls, but I didn't see any change in performance. I suspect that since the time is being dominated by String#<< this won't make much difference until we better support String#<< in YJIT
cc @nirvdrum

It's a bit surprising that time is so dominated by string concat that it dwarfs everything else so completely. Would be curious to see profiling data.


PR: Refactor test_autoindent.py to make the pytest logs cleaner

Description of Changes

Loop over all test cases inside each test instead of using the @pytest.mark.parametrize decoration. This reduces the number of lines in our pytest report by more than 100 and makes our log cleaner.
test_autoindent.py pytest report before this PR:

test_autoindent.py pytest report after this PR:

Hello @jnsebgosselin! Thanks for submitting the PR.

In the file spyder/plugins/editor/widgets/tests/test_autoindent.py, following                are the PEP8 issues :

Line 90:80: E501 line too long (81 > 79 characters)

I based this on master. I can re-base to 3.x if you prefer.

I can re-base to 3.x if you prefer.

No, don't worry. I don't think we're going to touch those tests in 3.x anymore.

I just fixed our tests. Please rebase or merge with master to fix them.


Consider empty locale list

Contentful always fallbacks to a default locale, but what should the interface expect?

IMO current state of interface/implementation solves this issue quite well.
Localization strictly depends on underlying platform and it's documentation should be referenced instead of expecting unified solution behind interface.


Undefined behavior from poll_fn + futures::join! / std::future::join!

Recently, when working on a library for observables, I found new miri test failures (I had been getting them on a specific test before, but didn't investigate after ensuring it wasn't my own UB). This lead to a bug report to tokio where Alice Ryhl showed that it didn't actually require tokio::spawn (which I had failed to get rid of in minimizing the issue), and the same issue was reproducible with join! + futures_executor.
I have now reduced the example much further, to this (works with the nightly std::future::join!, or futures::join!; playground):
#![feature(future_join)]

use std::{
    future::{join, poll_fn, Future},
    pin::pin,
    sync::Arc,
    task::{Context, Poll, Wake},
};

fn main() {
    let mut fut = pin!(async {
        let mut thing = "hello".to_owned();
        let fut1 = async move {
            poll_fn(|_| {
                thing += ", world";
                Poll::<()>::Pending
            })
            .await;
        };

        let fut2 = async {};

        join!(fut1, fut2).await;
    });

    let waker = Arc::new(DummyWaker).into();
    let mut ctx = Context::from_waker(&waker);
    _ = fut.as_mut().poll(&mut ctx);
    _ = fut.as_mut().poll(&mut ctx);
}

struct DummyWaker;

impl Wake for DummyWaker {
    fn wake(self: Arc<Self>) {}
}

Alice suggested that this may be an instance of https://github.com/rust-lang/rust/issues/63818, is that correct? I was under the impression that the compiler for now doesn't implement alias restrictions for !Unpin types, but maybe this only applies to the LLVM backend, not miri?

In the original bug report to Tokio, the UB was happening even though tokio::spawn was used instead of join!. So it may not be the join! macro's fault.

It seems adding move to poll_fn silences SB violation error: playground

adding move to poll_fn silences SB violation error

Or making thing &mut _: playground
(This reminds me of https://internals.rust-lang.org/t/surprising-soundness-trouble-around-pollfn/17484)
Btw, it is also possible to reproduce the error with a function, such as futures::future::join(), rather than a macro: playground

Minimized:
use std::{
    future::{poll_fn, Future},
    pin::Pin,
    sync::Arc,
    task::{Context, Poll, Wake},
};

fn main() {
    let mut thing = "hello".to_owned();
    let fut = async move {
        poll_fn(|_| {
            thing += ", world";
            Poll::<()>::Pending
        })
        .await;
    };

    let mut fut = MaybeDone::Future(fut);
    let mut fut = unsafe { Pin::new_unchecked(&mut fut) };

    let waker = Arc::new(DummyWaker).into();
    let mut ctx = Context::from_waker(&waker);
    assert_eq!(fut.as_mut().poll(&mut ctx), Poll::Pending);
    assert_eq!(fut.as_mut().poll(&mut ctx), Poll::Pending);
}

struct DummyWaker;

impl Wake for DummyWaker {
    fn wake(self: Arc<Self>) {}
}

pub enum MaybeDone<F: Future> {
    Future(F),
    Done,
}
impl<F: Future<Output = ()>> Future for MaybeDone<F> {
    type Output = ();

    fn poll(mut self: Pin<&mut Self>, cx: &mut Context<'_>) -> Poll<Self::Output> {
        unsafe {
            match *self.as_mut().get_unchecked_mut() {
                MaybeDone::Future(ref mut f) => Pin::new_unchecked(f).poll(cx),
                MaybeDone::Done => unreachable!(),
            }
        }
    }
}

Removing the MaybeDone::Done variant will also hide the UB

The memory that the conflict occurs on is the fut itself. Do I understand correctly that async move means we are moving thing into the future, and then creating a reference to it? So the future has (at least) two fields, a String and a ThingAdder pointing to that string.
The match *self.as_mut().get_unchecked_mut() will read the discriminant of the MaybeDone, which has been niche-optimized to be stored inside the String. This read overlaps with where the thing` points to, thus invalidating the mutable reference. Finally, the mutable reference is used again, causing UB.
In other words, this is the "mutable reference aliasing" version of why UnsafeCell blocks niches: we also need to block niches for fields that have self-referential references pointing to them. So the fix here is to change async lowering to use UnsafePinned and then have UnsafePinned block niches the same way UnsafeCell blocks niches.

Since Miri is behaving as intended here, I'm going to close the issue in favor of https://github.com/rust-lang/rust/issues/63818 and https://github.com/rust-lang/rust/issues/125735. I don't see a way that we can work around this akin to the !Unpin hack; this fundamentally needs the layout of these futures to be different from what it is today.
Thanks for bringing this up! In retrospect it is somewhat surprising that it took us so long to discover this, given that we already knew about the exact same issue with shared references and UnsafeCell...
Cc @rust-lang/opsem, just an FYI :)

In retrospect it is somewhat surprising that it took us so long to discover this

I'm just as surprised! 😄
Given that the &mut method I'm trying to call in the real code that made me look into this is on my own type (not String), is there something I can do hide its niches without using unsafe, as a temporary measure to unblock me from using miri to detect other potential unsoundness?

If you only need &mut access, you could wrap the thing the mutable reference points to in an UnsafeCell. :joy:

Is there anything Tokio should be doing to avoid UB with niche-optimized enums? We have the MaybeDone enum:
pin_project! {
    /// A future that may have completed.
    #[derive(Debug)]
    #[project = MaybeDoneProj]
    #[project_replace = MaybeDoneProjReplace]
    pub enum MaybeDone<Fut: Future> {
        /// A not-yet-completed future.
        Future { #[pin] future: Fut },
        /// The output of the completed future.
        Done { output: Fut::Output },
        /// The empty variant after the result of a [`MaybeDone`] has been
        /// taken using the [`take_output`](MaybeDone::take_output) method.
        Gone,
    }
}

I don't know if you should be doing anything, since it seems unlikely that this will lead to actual miscompilations. Though maybe @comex is able to trick LLVM into generating bad code here again. ;)
What you could do it mark that enum with a repr, which AFAIK prevents it being being niche-optimized.
The best thing to do would be to find someone who can implement UnsafePinned. :)

What you could do it mark that enum with a repr, which AFAIK prevents it from being niche-optimized.

While this is adequate as a workaround for the specific case here, it does not appear to be a reasonable workaround for this problem as a whole. This is because the same issue can be caused by using Option instead of a custom enum like MaybeDone.
https://play.rust-lang.org/?version=nightly&mode=debug&edition=2021&gist=63ab1f219beadfb593aac4ec5e0952d7

Yeah I did not mean to imply that this is a reasonable work-around for this case, I just pointed out the possibility.
I don't think there is a good work-around, this fundamentally needs rustc layout computation to change -- either by special-casing generators, or by implementing https://github.com/rust-lang/rust/issues/125735.

I don't think there is a good work-around, this fundamentally needs rustc layout computation to change -- either by special-casing generators, or by implementing rust-lang/rust#125735.

I thought wrapping a coroutine with a MaybeUninit inside a future returned by an async block/async function (like https://github.com/crossbeam-rs/crossbeam/pull/834) as a potential workaround.
In previous async lowing I think it was enough to change the GenFuture field from T to MaybeUninit<T>, but I'm not sure what should be done since such a type is not used in recent async lowing.

Here's a proper work-around: https://github.com/rust-lang/rust/pull/129313. It increases the size of some futures, though...


AIR: Specifying icons in the descriptor makes packaging fail

An error like this appears when trying to package an AIR application which has icons specified in its application descriptor:
Packaging failed: D:\path\to\my project\src\XXX_AIR-app.xml: error 303: Icon com/XXX/ assets/images/appIcons/icon_PP.png is missing from package
Possible solution: add a convention property to GradleFx to which those icons can be specified (or find them automatically)

Fixed this by adding an "air.includeFileTrees" property which can be used like this:
e.g. you specified an icon in your AIR descriptor file
<icon>
    <image32x32>assets/appIcon.png</image32x32>
</icon>

Then you can add this file by specifying it like this in your build script:
air.includeFileTrees = [
    fileTree(dir: 'src/main/actionscript/', include: 'assets/appIcon.png')
]


Add new volume rendering tests and baselines

Description
These were created by @ARSanderson during his VTK-9/OSPRay work.
Type of change

* [ ] Bug fix
* [ ] New feature
* [ ] Documentation update

[X] Other~~
Testing

How Has This Been Tested?
Running the tests on pascal.
Reminders:

Please follow the style guidelines of this project.
Please perform a self-review of your code before submitting a PR and asking others to review it.
Please assign reviewers (see VisIt's PR procedures for more information).

Checklist:

[ ] I have commented my code where applicable.~~
[ ] I have updated the release notes.~~
[ ] I have made corresponding changes to the documentation.~~
[ ] I have added debugging support to my changes.~~
[ ] I have added tests that prove my fix is effective or that my feature works.~~
[ ] I have confirmed new and existing unit tests pass locally with my changes.~~
[ ] I have added new baselines for any new tests to the repo.~~
[ ] I have NOT made any changes to protocol or public interfaces in an RC branch.~~

@ARSanderson there are issues with volume_10 and volume_20.
When run in serial or parallel modes the images are blank.
When run in scalable,parallel,icet mode the images are not blank.

Yes, in some cases there is an issue with the VTK actor dropping off to lala land.  I have been able to reproduce it but only with certain data sets. Others it works. Quite odd. @brugger1  and I discussed adding a ticket for this issue as IIRC we saw it with the old rendering too. I did not add a ticket because we wanted the dust to settle on the merge/updates etc (in the hopes it would not be an issue further).


Negative soil NO3, NH4 and UREA in SOILNI.for

File: SOILNI.for.
Lines:
SNO3(L) = SNO3(L) + DLTSNO3(L)
SNH4(L) = SNH4(L) + DLTSNH4(L)
UREA(L) = UREA(L) + DLTUREA(L)
In some cases, SNO3, SNH4 and UREA in the soil layers are getting negative values. This is happening because calculated values of DLTSNO3, DLTSNH4, and DLTUREA are negative (which is acceptable), but these calculated values sometimes exceed the actual values of SNO3, SNH4, and UREA in the soil layer (which is incorrect). It is necessary to Identify what is happening with DLTSNO3, DLTSNH4 and DLTUREA.

Hi @thiagoferreira53!
Is this issue refers to PR #337 ?
Thank you.

Hello,
Yes, it is related to it but we still need to conduct a further investigation on DLTSNO3, DLTSNH4, and DLTUREA. We are planning to do that during the DSSAT Sprint.

Oh Ok. Gracias!


LibRadar isn't working

I am using the latest rdb file (https://github.com/pkumza/Data_for_LibRadar/blob/master/LibRadarData0410.rdb) and the latest version of LibRadar. I configured it as described in the readme file, but i get always an
empty output. This is not the case when i use LiteRadar. By looking in the code,
i found that LibRadar is using besides db 0 and 1, db 2.
redis-cli -n 2 followed by keys * results in the following output:

(empty list or set)

Is it possible that you didn't upload the latest version of LibRadar?

I found that the keys in the previous mentioned rdb file are just 32 characters long, so i assume it is still using md5 sums instead of sha256. Is their any updated file?

https://github.com/pkumza/Data_for_LibRadar/blob/master/LibRadarData0410.rdb is not the latest rdb file because the latest rdb file is very large. (several GB)
I can't find a stable repository for my Large file... Every time a upload a file, the link breaks after several month.
Could you please try github.com/pkumza/LiteRadar? They are almost the same.

I created a new rbd file from lite_dataset_10.csv using the following python script:
import redis

DB_HOST = 'localhost'
DB_PORT = 6379
DB_ID = 0
DB_PSWD = ''

DB_FEATURE_CNT = 'feature_cnt'
DB_FEATURE_WEIGHT = 'feature_weight'
DB_UN_OB_PN = 'un_ob_pn'
DB_UN_OB_CNT = 'un_ob_cnt'

db = redis.StrictRedis(host=DB_HOST,port=DB_PORT, db=0, password=DB_PSWD)
db.flushall()
f = open('lite_dataset_10.csv', 'r')
for line in f:
    array = line.split(",")
    print (line)
    db.hset(DB_UN_OB_PN, array[0], array[4])
    db.hset(DB_FEATURE_CNT, array[0], array[1])
    db.hset(DB_UN_OB_CNT, array[0], array[3])
    db.hset(DB_FEATURE_WEIGHT, array[0], array[2])
db.save()

There's no feature data in lite_dataset_10.csv.🤔


slideshowItems Array contains 2 more ImageSlideshowItems than I added

Hi,
I create an image slideshow in each table view cell.  I add my own image sources called FirebaseImageSource.
for example like this:
var inputSourceArray:[FirebaseImageSource] = []
        for url in photoURLs {
            inputSourceArray.append(FirebaseImageSource(urlString: url)!)
        }

self.imageSlideshow.setImageInputs(inputSourceArray)
up until this point all works fine.
Tapping on a cell triggers a segue to a detail vc where I create another image slideshow with the same images as the tapped cell. for efficiency reasons, it doesn't make sense to re-download the same images again.
in prepare for segue I do the following logic:
var photoArray:[UIImage] = []
for item in cell.imageSlideshow.slideshowItems {
if let image = item.imageView.image  {
// print("appending image")
photoArray.append(image)
}
}
To my surprise, the number of images (and also Image slideshow items) are 2 more than the image urls.  Still, the tableview cells show the correct number of images (e.g. 3).  but the image slideshow in the detail view shows 5 images but there are only three images urls ...   Is this a bug?  actually the first two images are repeated at the end.
if there  is only one image url, both image slideshows show 1 image correctly. but if there are 2 images, the same two image items are added again.
thanks for any hints.

OK, I figured it out... in circular mode, there are two two of the items repeated at the end and the beginning of the array...
To extract the images from the image slideshow in the TV cell, fixed it like this:
var photoArray:[UIImage] = []
for item in cell.imageSlideshow.slideshowItems {
if let image = item.imageView.image  {
photoArray.append(image)
}
}
if cell.imageSlideshow.circular  && cell.imageSlideshow.slideshowItems.count > 1 {
            photoArray.removeLast()
            photoArray.removeFirst()

        }

Those two extra items are put to circular slideshow intentionally to provide smooth scrolling between edge (first and last item). You should not remove those items, otherwise scrolling issues might appear.
But in general you should not need to care about efficiency this way, most image loading libraries like AlamofireImage or SDWebImage provides caching so the full screen image will be loaded from cache.

Thanks - I'm using Firebase here and therefore had to create my own class conforming to InputSource protocol. I will see how to get them from cache if I can access it. Till then, the workaround works fine. I don't change the content of the slideshowItems array but only copy the images .


Use 'hive.openshift.io/v1' as apiVersion for SSS

Update the apiVersion for the selectorsyncset to 'hive.openshift.io/v1' so that can be applied to the new v4 hive shards.

/assign @cblecker

/lgtm
/approve


Integration could not load, after update to Homea Assistant Core 2024.5.3

After update to Version 2024.5.3 the integration could not be started. I removed the integration and reinstall it. But now it is not possible to start it.

Regards Juerg

Same here.

It is because of ha.UnitOfFrequency.HERTZ declaration in const.py file. HA seem to removed it so the integration can not look up the value. Suggest to remove this. I did it and it work good.

It is because of ha.UnitOfFrequency.HERTZ declaration in const.py file. HA seem to removed it so the integration can not look up the value. Suggest to remove this. I did it and it work good.

thanks. That works fine!

It is because of ha.UnitOfFrequency.HERTZ declaration in const.py file. HA seem to removed it so the integration can not look up the value. Suggest to remove this. I did it and it work good.

Thank you, this solved my issue. It is working again now.


Certificate Errors on deployment

Environment
I am using Ubuntu 20.04 with SGX 2.17. Installed Teaclave with the following:
sudo docker run --rm -v $(pwd):/teaclave -w /teaclave \
  -it teaclave/teaclave-build-ubuntu-2004-sgx-dcap-1.14:0.2.0 \
   bash -c ". /root/.cargo/env && \
     . /opt/sgxsdk/environment && \
     mkdir -p build && cd build && \
     git config --global --add safe.directory '*' && \
     cmake -DTEST_MODE=ON -DDCAP=ON .. && \
     make -j"

Set environment variables:
export AS_SPID="00000000000000000000000000000000"
export AS_KEY="00000000000000000000000000000000"
export AS_ALGO="sgx_ecdsa"
export AS_URL="https://<IP_ADDRESS>:8081"
export TEACLAVE_LOG=trace

Modified build.config.toml so it used DCAP cert.
# Intel Attestation Service root CA certificate to verify attestation report
# as_root_ca_cert = { path = "config/keys/ias_root_ca_cert.pem" }
# For DCAP, use the following cert
as_root_ca_cert = { path = "config/keys/dcap_root_ca_cert.pem" }

AESM service:
● aesmd.service - Intel(R) Architectural Enclave Service Manager
     Loaded: loaded (/lib/systemd/system/aesmd.service; enabled; vendor preset: enabled)
     Active: active (running) since Tue 2023-12-12 17:51:37 UTC; 57min ago
    Process: 20825 ExecStartPre=/opt/intel/sgxpsw/aesm/linksgx.sh (code=exited, status=0/SUCCESS)
    Process: 20834 ExecStartPre=/bin/mkdir -p /var/run/aesmd/ (code=exited, status=0/SUCCESS)
    Process: 20836 ExecStartPre=/bin/chown -R aesmd:aesmd /var/run/aesmd/ (code=exited, status=0/SUCCESS)
    Process: 20837 ExecStartPre=/bin/chmod 0755 /var/run/aesmd/ (code=exited, status=0/SUCCESS)
    Process: 20838 ExecStartPre=/bin/chown -R aesmd:aesmd /var/opt/aesmd/ (code=exited, status=0/SUCCESS)
    Process: 20839 ExecStartPre=/bin/chmod 0750 /var/opt/aesmd/ (code=exited, status=0/SUCCESS)
    Process: 20840 ExecStart=/opt/intel/sgxpsw/aesm/aesm_service (code=exited, status=0/SUCCESS)
   Main PID: 20841 (aesm_service)
      Tasks: 4 (limit: 38387)
     Memory: 3.3M
     CGroup: /system.slice/aesmd.service
             └─20841 /opt/intel/sgxpsw/aesm/aesm_service

dic 12 17:51:47 teaclave-vm aesm_service[20841]: [QCNL] Try memory cache...
dic 12 17:51:47 teaclave-vm aesm_service[20841]: [QCNL] Try remote service...
dic 12 17:51:47 teaclave-vm aesm_service[20841]: [QCNL] Request URL https://<IP_ADDRESS>:8081/sgx/certification/v3/pck>...
dic 12 17:51:47 teaclave-vm aesm_service[20841]: [QCNL] HTTP status code: 200
dic 12 17:51:47 teaclave-vm aesm_service[20841]: [QCNL] Try memory cache...
dic 12 17:51:47 teaclave-vm aesm_service[20841]: [QCNL] Retrieved PCK certchain from memory cache successfully.
dic 12 17:51:47 teaclave-vm aesm_service[20841]: [QCNL] Try memory cache...
dic 12 17:51:47 teaclave-vm aesm_service[20841]: [QCNL] Retrieved PCK certchain from memory cache successfully.
dic 12 17:51:47 teaclave-vm aesm_service[20841]: [QCNL] Try memory cache...
dic 12 17:51:47 teaclave-vm aesm_service[20841]: [QCNL] Retrieved PCK certchain from memory cache successfully.

PCCS Service
● pccs.service - Provisioning Certificate Caching Service (PCCS)
     Loaded: loaded (/lib/systemd/system/pccs.service; enabled; vendor preset: enabled)
     Active: active (running) since Tue 2023-12-12 13:59:48 CET; 5h 56min ago
       Docs: https://github.com/intel/SGXDataCenterAttestationPrimitives/blob/master/QuoteGeneration/pccs/README.md
   Main PID: 4156670 (node)
      Tasks: 15 (limit: 538088)
     Memory: 37.3M
        CPU: 2.672s
     CGroup: /system.slice/pccs.service
             └─4156670 /usr/bin/node /opt/intel/sgx-dcap-pccs/pccs_server.js

Dec 12 13:59:48 syp-s1 systemd[1]: Started Provisioning Certificate Caching Service (PCCS).
Dec 12 13:59:50 syp-s1 node[4156670]: 2023-12-12 13:59:50.003 [info]: HTTPS Server is running on: https://localhost:>
Dec 12 18:51:47 syp-s1 node[4156670]: 2023-12-12 18:51:47.805 [info]: Client Request-ID : 999f8a12d6474051b90a2ec262>
Dec 12 18:51:47 syp-s1 node[4156670]: 2023-12-12 18:51:47.832 [info]: <IP_ADDRESS> - - [12/Dec/2023:17:51:47

Error
Now on ./run-teaclave-services.sh
teaclave-frontend-service          | [ERROR teaclave_frontend_service_enclave] Failed to run service: invalid peer certificate: Other(UnsupportedCertVersion)
teaclave-frontend-service          | [2023-12-12T18:58:34Z DEBUG teaclave_binder::ipc::app] ecall_ipc_entry_point OK. App Received Buf: [123, 34, 69, 114, 114, 34, 58, 34, 83, 101, 114, 118, 105, 99, 101, 69, 114, 114, 111, 114, 34, 125]
teaclave-frontend-service          | [2023-12-12T18:58:34Z DEBUG teaclave_binder::ipc::app] ecall_ipc_app_to_tee: 1002, 4 bytes
teaclave-frontend-service          | [TRACE teaclave_frontend_service_enclave] tee receive cmd: 1002, input_buf = [110, 117, 108, 108]
teaclave-frontend-service          | [DEBUG teaclave_frontend_service_enclave] handle_invoke
teaclave-frontend-service          | [DEBUG teaclave_service_enclave_utils] Enclave finalizing
teaclave-frontend-service          | [DEBUG teaclave_service_enclave_utils] g_peak_heap_used: 614400
teaclave-frontend-service          | [DEBUG teaclave_service_enclave_utils] g_peak_rsrv_mem_committed: 0
teaclave-frontend-service          | [2023-12-12T18:58:34Z DEBUG teaclave_binder::ipc::app] ecall_ipc_entry_point OK. App Received Buf: [123, 34, 79, 107, 34, 58, 110, 117, 108, 108, 125]
teaclave-frontend-service          | [2023-12-12T18:58:34Z DEBUG teaclave_binder::binder] Dropping TeeBinder, start finalize().
teaclave-frontend-service          | [2023-12-12T18:58:34Z DEBUG teaclave_binder::ipc::app] ecall_ipc_app_to_tee: 1002, 4 bytes
teaclave-frontend-service          | [2023-12-12T18:58:34Z ERROR teaclave_binder::ipc::app] ecall_ipc_entry_point, app sgx_error:InvalidEcnalveId
teaclave-frontend-service          | [2023-12-12T18:58:34Z ERROR teaclave_binder::binder] IpcError(SgxError(InvalidEcnalveId))
teaclave-frontend-service exited with code 0

Maybe a problem of self-signed certificates from PCCS? PCCS is on V3.
Thanks in advance.

Update: I could solve UnsupportedCertVersion error, I had to create a new cert for pccs but with version 3, since it was on version 1, that solved the error. Now I get UnknownIssuer error, which I guess it's because the certificate is a self signed one. I don't know if teaclave has some option to allow that kind of certs.
[ERROR teaclave_sgx_tool_enclave] Failed to attest: invalid peer certificate: UnknownIssuer
[2023-12-13T12:37:33Z DEBUG teaclave_binder::ipc::app] ecall_ipc_entry_point OK. App Received Buf: [123, 34, 69, 114, 114, 34, 58, 34, 83, 101, 114, 118, 105, 99, 101, 69, 114, 114, 111, 114, 34, 125]
[2023-12-13T12:37:33Z DEBUG teaclave_binder::binder] Dropping TeeBinder, start finalize().
[2023-12-13T12:37:33Z DEBUG teaclave_binder::ipc::app] ecall_ipc_app_to_tee: 1002, 4 bytes
[TRACE teaclave_sgx_tool_enclave] tee receive cmd: 1002, input_buf = [110, 117, 108, 108]
[DEBUG teaclave_sgx_tool_enclave] handle_invoke
[DEBUG teaclave_service_enclave_utils] Enclave finalizing
[DEBUG teaclave_service_enclave_utils] g_peak_heap_used: 188416
[DEBUG teaclave_service_enclave_utils] g_peak_rsrv_mem_committed: 0
[2023-12-13T12:37:33Z DEBUG teaclave_binder::ipc::app] ecall_ipc_entry_point OK. App Received Buf: [123, 34, 79, 107, 34, 58, 110, 117, 108, 108, 125]
Error: ServiceError

It might help for diagnosis if you put the logs of the DCAP, PCCS and other related services.

Hi, if you are using a self-signed certificate for your PCCS service, there are a few things to pay attention:

Open the configuration file for your DCAP attestation under the path /etc/sgx_default_qcnl.conf, and make sure that "use_secure_cert": false
Make sure that you are pointing at the correct address under the file pccs_url
Use example codes in https://github.com/intel/SGXDataCenterAttestationPrimitives to verify your PCCS works correctly

Configuration is correct, also logs don't show errors or warnings. My pccs version, which is on host machine, is 1.19, maybe that could cause problems since my vm is working with sdk 2.17 and dcap 1.14 as teaclave needs.

Update: Installed 1.14 version of PCCS on my VM, error is the same, configuration file /etc/sgx_default_qcnl.conf is working well since changes on certs reflect on error logs on teaclave. Sample codes also work as they should. Also ,neither aesmd or pccs services show any errors.

I suggest that you revise the configuration file /opt/intel/sgx-dcap-pccs/config/default.json and change the LogLevel to info or debug, as long as you make the DCAP quote, you will see much more information from the PCCS service log, don't forget to restart the service after you update the configuration file.

So I changed LogLevel to debug in /opt/intel/sgx-dcap-pccs/config/default.json:
{
"HTTPS_PORT" : 8082,
"hosts" : "<IP_ADDRESS>",
"uri": "https://api.trustedservices.intel.com/sgx/certification/v3/",
...
"LogLevel" : "debug",

Now once I restart pccs service, I run sudo -E ./teaclave_sgx_tool attestation --url https://localhost:8082 --algorithm sgx_ecdsa to test atttestation. Output is the following:
[ERROR teaclave_sgx_tool_enclave] Failed to attest: invalid peer certificate: Other(UnsupportedCertVersion)
[2024-01-03T10:35:40Z DEBUG teaclave_binder::ipc::app] ecall_ipc_entry_point OK. App Received Buf: [123, 34, 69,
114, 114, 34, 58, 34, 83, 101, 114, 118, 105, 99, 101, 69, 114, 114, 111, 114, 34, 125]
[2024-01-03T10:35:40Z DEBUG teaclave_binder::binder] Dropping TeeBinder, start finalize().
[2024-01-03T10:35:40Z DEBUG teaclave_binder::ipc::app] ecall_ipc_app_to_tee: 1002, 4 bytes
[TRACE teaclave_sgx_tool_enclave] tee receive cmd: 1002, input_buf = [110, 117, 108, 108]
[DEBUG teaclave_sgx_tool_enclave] handle_invoke
[DEBUG teaclave_service_enclave_utils] Enclave finalizing
[DEBUG teaclave_service_enclave_utils] g_peak_heap_used: 180224
[DEBUG teaclave_service_enclave_utils] g_peak_rsrv_mem_committed: 0
[2024-01-03T10:35:40Z DEBUG teaclave_binder::ipc::app] ecall_ipc_entry_point OK. App Received Buf: [123, 34, 79, 107, 34, 58, 110, 117, 108, 108, 125]
Error: ServiceError

PCCS show the following:
● pccs.service - Provisioning Certificate Caching Service (PCCS)
     Loaded: loaded (/lib/systemd/system/pccs.service; enabled; vendor preset: enabled)
     Active: active (running) since Wed 2024-01-03 10:40:22 UTC; 2min 0s ago
       Docs: https://github.com/intel/SGXDataCenterAttestationPrimitives/blob/master/QuoteGeneration/pccs/README.md
   Main PID: 96704 (node)
      Tasks: 11 (limit: 38387)
     Memory: 68.4M
     CGroup: /system.slice/pccs.service
             └─96704 /usr/bin/node -r esm /opt/intel/sgx-dcap-pccs/pccs_server.js

ene 03 10:40:22 teaclave-vm systemd[1]: Started Provisioning Certificate Caching Service (PCCS).
ene 03 10:40:22 teaclave-vm node[96704]: Wed, 03 Jan 2024 10:40:22 GMT morgan deprecated default format: use combined format at node_modules/esm/esm.js:1:278827
ene 03 10:40:25 teaclave-vm node[96704]: 2024-01-03 10:40:25.129 [info]: HTTPS Server is running on: https://localhost:8082

Although log doesn't show more info  I must pointing at the right service, because if I change pccs cert to a v3 cert, error changes as I said to [ERROR teaclave_sgx_tool_enclave] Failed to attest: invalid peer certificate: UnknownIssuer
In fact, command curl -v -k -G "https://localhost:8082/sgx/certification/v3/rootcacrl" returns what it should,

So doing some testing I used the keys located at /incubator-teaclave/config/keys to try to bypass the error. I used dcap_server_cert.pem and dcap_server_key.pem as my pccs certificate and private key (since the other way around didn't work as it outputs the same error). I was able to solve the issue that way by now, after that, I encountered the following after sudo -E ./teaclave_sgx_tool attestation --url https://localhost:8082 --algorithm sgx_ecdsa:
[TRACE teaclave_attestation::service] HTTP/1.1 404 Not Found
X-Powered-By: Express
Request-ID: 0e4fa148a288438da52437c0b7db823c
Content-Security-Policy: default-src 'none'
X-Content-Type-Options: nosniff
Content-Type: text/html; charset=utf-8
Content-Length: 169
Date: Thu, 04 Jan 2024 16:06:15 GMT
Connection: close                                                                                <!DOCTYPE html>

<meta charset="utf-8">
<title>Error</title>

Cannot POST /sgx/dev/attestation/v4/report

                                                                                [DEBUG teaclave_attestation::service] http_response.parse
[DEBUG teaclave_attestation::service] Attestation service responds an unknown error
[ERROR teaclave_sgx_tool_enclave] Failed to attest: Attestation service responds an unknown error.

Also pccs service now shows some log info:
ene 04 16:06:15 teaclave-vm node[98964]: 2024-01-04 16:06:15.686 [info]: Client Request-ID : 0e4fa148a288438da52437c0b7db823c
ene 04 16:06:15 teaclave-vm node[98964]: 2024-01-04 16:06:15.694 [info]: <IP_ADDRESS> - - [04/Jan/2024:16:06:15 +0000] "POST /sgx/dev/attestation/v4/report HTTP/1.1" 404 169 "-" "-"

Something messed up, it seems it calls EPID attestation API to the DCAP PCCS service.

Yes I am aware of all of that, so I am assuming it is a configuration issue from my teaclave? Since it is the one who is making those requests. Maybe there is some config I should change bu I couldn't find propper DCAP deployment documentation.
Also:
admin-ubuntu@teaclave-vm:/opt/intel/SGXDataCenterAttestationPrimitives/SampleCode/QuoteGenerationSample$ ./app
Step1: Call sgx_qe_get_target_info:succeed!
Step2: Call create_app_report:succeed!
Step3: Call sgx_qe_get_quote_size:succeed!
Step4: Call sgx_qe_get_quote:succeed!cert_key_type = 0x5

Yes I am aware of all of that, so I am assuming it is a configuration issue from my teaclave? Since it is the one who is making those requests. Maybe there is some config I should change bu I couldn't find propper DCAP deployment documentation.
Also:
admin-ubuntu@teaclave-vm:/opt/intel/SGXDataCenterAttestationPrimitives/SampleCode/QuoteGenerationSample$ ./app
Step1: Call sgx_qe_get_target_info:succeed!
Step2: Call create_app_report:succeed!
Step3: Call sgx_qe_get_quote_size:succeed!
Step4: Call sgx_qe_get_quote:succeed!cert_key_type = 0x5

https://www.intel.com/content/www/us/en/developer/articles/guide/intel-software-guard-extensions-data-center-attestation-primitives-quick-install-guide.html
This is the best official doc I can find from Intel. For the teaclave, I am afraid that you might need to trace down the source code and find out why. If there is a bug, you may submit a PR to fix it.

I might need to trace down source code, nevertheless, I am only able to bypass the certificate error using the attestation tool to test it, if I try to load teaclave services, I get NotValidForName error, using teaclave DCAP certificates on PCCS service. So I guess there should be another solution to make it work. It would be great to know if PCCS needs some particular type of certificates or some kind of config needs to be changed to make it work.

Could someone explain me the correlation between these keys and my pccs service keys? Do I need to change cert and key and add my pccs files? Is it necessary to have a particular type of certificate on the pccs? Should It work with no changes for development and testing?

So I was able to temporary bypass the certification problems, but the issue with de 404 error is still there:
[TRACE teaclave_attestation::service] HTTP/1.1 404 Not Found
X-Powered-By: Express
Request-ID: 0e4fa148a288438da52437c0b7db823c
Content-Security-Policy: default-src 'none'
X-Content-Type-Options: nosniff
Content-Type: text/html; charset=utf-8
Content-Length: 169
Date: Thu, 04 Jan 2024 16:06:15 GMT
Connection: close                                                                                <!DOCTYPE html>

<meta charset="utf-8">
<title>Error</title>

Cannot POST /sgx/dev/attestation/v4/report

                                                                                [DEBUG teaclave_attestation::service] http_response.parse
[DEBUG teaclave_attestation::service] Attestation service responds an unknown error
[ERROR teaclave_sgx_tool_enclave] Failed to attest: Attestation service responds an unknown error.

● pccs.service - Provisioning Certificate Caching Service (PCCS)                                                                                Loaded: loaded (/lib/systemd/system/pccs.service; enabled; preset: enabled)                                                                                Active: active (running) since Thu 2024-02-01 19:03:32 CET; 24min ago                                                                                Docs: https://github.com/intel/SGXDataCenterAttestationPrimitives/blob/master/QuoteGeneration/pccs/README.md                                                                           Main PID: 726334 (node)                                                                                Tasks: 15 (limit: 538163)                                                                                Memory: 38.0M                                                                                CPU: 2.239s                                                                                CGroup: /system.slice/pccs.service                                                                                └─726334 /usr/bin/node /opt/intel/sgx-dcap-pccs/pccs_server.js                                                                                Feb 01 19:03:32 syp-s1 systemd[1]: Started pccs.service - Provisioning Certificate Caching Service (PCCS).                                                                                Feb 01 19:03:33 syp-s1 node[726334]: 2024-02-01 19:03:33.470 [info]: HTTPS Server is running on: https://localhost:8081                                                                    Feb 01 19:27:49 syp-s1 node[726334]: 2024-02-01 19:27:49.545 [info]: Client Request-ID : e78567d41444428f94bde3b583db8092                                                                  Feb 01 19:27:49 syp-s1 node[726334]: 2024-02-01 19:27:49.576 [info]: <IP_ADDRESS> - - [01/Feb/2024:18:27:49 +0000] "POST /sgx/dev/attestation/v4/report HTTP/1.1" 404 169 "-" "-"

Maybe some kind of config? It seems to be using EPID but as I already showed everything should be well configured...

I saw dcap testing tool (/release/dcap/teaclave_dcap_ref_as) actually accepts the POST connection.
POST /sgx/dev/attestation/v4/report application/json:
   >> Matched: (verify_quote) POST /sgx/dev/attestation/v4/report application/json
   >> Outcome: Success
   >> Response succeeded.

Is it my PCCS fault then?