HomePage Redesign

As a User,
I want to visit the ReportStream Homepage,
So that I can become informed about ReportStream and find more information.
Content Updates

See Figma

Page Title

CDC ReportStream - Homepage

Analytics

Page Load
"Connect Now" Button Click
"Get Started" Button Click
"Connect with us" Button Click
"Subscribe" Submission

Storybook updates

TBD

Verification Steps

Code Review
Trail / Dev environment signoff by Product / Design
Staging environment signoff by Product / Design
Production environment signoff by Engineering, Product and Design

Acceptance Criteria

[ ] Analytics / Metrics Required
[x] Storybook update required
[x] Unit Tests
[x] Manual Testing Steps
[x] Convert to MDX
[ ] Final Client Approval (See PM)

Manual Testing Steps

Log into RS
Homepage will appear
Clicking on a button will trigger the correct action
Clicking on a link will trigger the correct action

Dependencies

Designs - https://www.figma.com/file/Du7feM8huRDAAZCQcUIj93/Wireframes?type=design&node-id=1%3A17&mode=dev
Platform API Endpoints - N/A

Additional Details

The deployment strategy will follow the general deployment strategy for the Website Redesign EPIC. We will deliver the homepage in isolation from the other pages.
The Top Navigation is it's own separate ticket! https://app.zenhub.com/workspaces/web-experience-607d9d5e68b95200150fec37/issues/gh/cdcgov/prime-reportstream/10709

Hey team! Please add your planning poker estimate with Zenhub @penny-lischer @etanb @jpandersen87

I've ranked this as a 5 with a big caveat: we remove the "subscribe" section. We don't have any functionality in place to capture email addresses and I don't believe we've approach who'd manage a newsletter etc yet. cc @chris-kuryak @KeithNava @jillian-hammer

@jillian-hammer Was there a plan in place as to how the "subscribe" functionality would work with the engagement team? Did y'all already have a plan/idea in place?
In @audreykwr draft I see it just commented as a "future capability". Shall we leave it out of this round of updates?

hi! we removed it from the latest wireframe since it was flagged as a bigger lift during a previous review. i updated the link in the main issue so hopefully it redirects y'all to the current iteration. 🤞
@etanb @chris-kuryak

Thank you @jillian-hammer!

End to End Tests will be done in another ticket.

@chris-kuryak which Analytics / Metrics did you want to be captured?

I think we discussed this a little bit, but tracking button clicks would be the only thing on top of our regular analytics.
@KeithNava we have the SPIKE coming up to determine how to do that for all pages moving forward. So as long as that does not get lost and we can start tracking button clicks within a sprint or two, up to y'all on how you want to deploy this page.

Client/PO feedback from 8/17:
Improvements for future releases:

Hero Image: "Connect Now" button contrast is bad. And hovering actually makes it worse. It may fail a contrast check. Need to increase contrast on the blue button with blue background.
Ideally, we don't want our users to be linking out of our website after their first interaction. Considering embedding forms into our website in the future.
The new Smartsheet Onboarding Form first page says "submit" as the button at the bottom, but it takes you to a new page for more information. Consider changing to "Next".
The new Smartsheet Onboarding Form does not indicate how many pages are part of the form. Consider adding page numbers or some indication of a user's progress through the form.
The new Smartsheet Onboarding Form has a standard success message upon finishing. It does not indicate anything specific to ReportStream or what the user should expect to happen next. More informative (RS specific) text would be better.
The new Smartsheet Onboarding Form keeps you in the form upon finishing successfully. Instead, the user should be redirected to the ReportStream website.
The button clicks are not currently being tracked. Consider tracking them in the near future to help track how users are interacting with our website.
Does SmartSheet indicate/track progress of how far someone gets through a form if they don't complete it successfully? Would be useful for tracking user interaction and engagement.
Why do the calls to action have different text when they both lead to the same place? One says "Connect Now" and the other says "Get Started".
The text "Public Health Entities" is "hanging" on the page, seems disjointed from rest of page.
The quote at the bottom of the page appears to be hanging as well and somewhat disjointed from the rest of the page.


Dark Mode Labels incorrect

The text color of the labels is not correct in Dark Mode.  I have attached a picture to show what I mean.
Image

Seeing something similar on bar charts.   The bars are the same color as the background.

@rmbeaty It's fixed it will be released soon


OOP school library: preserve data

Saved the data (books, people, and rentals) into JSON files.

Load the data when app is run

On startup of the app load all data from files.

Thank you @ShahierNashaat for your feedback and for approving our code.


ipld: Implement API for application sovereignty: query data per namespace

Summary
Application Clients (e.g. from ORUs) need a way to simply download all data specific to their namespace (application sovereignty).
Proposal
Add a simple library that traverses the NMT and returns all data of the requested namespace ID.
It might be valuable to consider adding an RPC endpoint for this too. E.g. for block explorers who want to serve Txs of certain applications (or ORU chains), too.

Reimplement the API to retrieve shares by namespace referenced here:
https://github.com/celestiaorg/celestia-core/pull/422
ADR for reference: ADR-003

personal reminder to refactor and add back in these extra tests https://github.com/renaynay/celestia-core/pull/2, after we complete the main implementation.

Resolved by #170.


Build Prerequisites are Missing for Build on Mac

I experience two failures building turicreate from source on Mac High-Sierra:

bin/sh -c \"/Users/mordoron/GitHub/turicreate/debug/src/visualization/Turi\Create\Visualization.build/Debug/Tui\ Create\ Visualization.build/ScriptFC1A878A1FB14D2900A67DAD.sh\"/Users/mordoron/GitHub/turicreate/debug/src/visualization/Turi Create Visualization.build/Debug/Turi Create Visualization.build/ScriptFC1A878A1FB14D2900A67DAD.sh: line 3: npm: command not found/Users/mordoron/GitHub/turicreate/debug/src/visualization/Turi CreateVisualization.build/Debug/Turi Create Visualization.build/ScriptFC1A878A1FB14D2900A67DAD.sh: line 4: npm: command not found Command /bin/sh failed with exit code 127
This is due to npm not being installed on my Mac.
We may want to add this as a prerequisite to the build.md file.

/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: libunity_coreml_model_export.a(NeuralNetwork.cpp.o) has no symbols
This was fixed by updating Xcode.app.
Again we may want to add a prerequisite with Xcode version.

Fixed with #230.


Update azure_* crates to 0.20

PR #7539 has done the 0.19 update but for the 0.20 update we are blocked by https://github.com/Azure/azure-sdk-for-rust/issues/1652 , because 0.20 is pulling in async-io which we don't want in our dependency graph.

might be related: https://github.com/apache/opendal, not sure if they have s3 time travel support but would be good for unifying everything without worrying about vendor-dependent things.

@skyzh that's interesting. could you file a separate issue about evaluating adoption of opendal? It's orthogonal to this issue.

There is a 0.21 version now, and we still can't update, because of https://github.com/Azure/azure-sdk-for-rust/issues/1652 .


OOP school library: set up associations

In this project, I did the following:

Set up associations between classes and objects.
Create a class Classroom.
Create the has-many/belongs-to relationship between Classroom and Student.
Create a class Book.
Create a class Rental.
Create the many-to-many (also has-many-through) relationship between Person and Book using the intermediate class Rental.

@tumainimaganiko Kindly look at the discussion by the previous reviewer and find my comments within them.

@tumainimaganiko Excellent work reaching out to clear your doubt about the milestone over a call.


Deprecation messages for re-eported items from other packages get lost

Original reporter: sol@

Probably fixed by above merge, but worth confirming..

Not fixed yet. :/
module Temp (readsUnary) where
import Data.Functor.Classes

Produces

Yet, in Data.Functor.Classes we have

Fixing this is actually not too difficult:

add an instWarningMap field to InstalledInterface
use ifaceWarningMap from Interface to populate that field

I'm going to hold off on fixing this though, since it would collide with the Hi Haddock changes.

Issue moved to https://gitlab.haskell.org/ghc/ghc/-/issues/24913

I believe @luite didn't intend to close this. My commit message says: Haddock also needs to be fixed: https://github.com/haskell/haddock/issues/223 and it confused github apparently.
As I've already moved the issue upstream (https://gitlab.haskell.org/ghc/ghc/-/issues/24913), we can keep it closed here though.


using Mesh for efficient streamline plotting

cc @choldgraf
Should fix the performance issue discussed https://github.com/maartenbreddels/ipyvolume/issues/71

Btw, the interact doesn't work now, but I thought it's easier for you to fix.

thanks @maartenbreddels - will check this out.
btw, will there be a new release of ipyvolume soon?

@maartenbreddels - the drawing is awesome. but i don't know how to enable/disable viewing a specific line or set of lines using the method.
i tried setting the mesh.color attribute but that didn't work, i.e. the figure doesn't update.
https://github.com/satra/niwidgets/commit/79b0b714aad349dcec013bdb09b127f2da0269c7

also related question, how do i remove a mesh from a figure when i have one or more meshes?

The issue is that if you modify the mesh.color's internals, the library doesn't pick that up, the default way is to make a copy, modify that and then assign is. But since the array is quite large, I'd do sth like this:
mesh.color[:100000] = 0  # the (traitlets) library will not pick up a change
mesh.send_state('color')   # force sending the state to the browser

Figure.meshes has the same issue, modifications to the meshes list cannot be picked up, for instance this won't work:
fig.meshes.remove(mesh)
fig.meshes.add(mesh)

Instead, this will work:
meshes = list(fig.meshes)
meshes.remove(mesh)
fig.meshes = meshes
fig.meshes = list(fig.meshes) + [mesh]

Does this help?
Hiding individual lines is a good question, I was also thinking how it could be possible to select/pick of detect hover over a specific line. Hiding could be done using the alpha channel (in color), although I don't think that works now. Modifying the indices array would work, let them all point to the same vertex will make them hide. Would that work for you?

@maartenbreddels - thanks for these pointers. to start of with i wanted to try something quite simple. i.e. regenerate the mesh on every threshold change. so within my interact function i have this:
       with state['fig'].hold_sync():
            fig = state['fig']
            print(len(state['indices']))
            x, y, z, indices, colors = self._create_mesh(indices2use=state['indices'])
            mesh = ipv.Mesh(x=x, y=y, z=z, lines=indices, color=colors)
            meshes = list(fig.meshes)
            if meshes:
                meshes.pop()
                fig.meshes = meshes
            fig.meshes = list(fig.meshes) + [mesh]
            ipv.pylab._grow_limits(y, y, y)  # may chance in the future.. ?
            fig.camera_fov = 1
            fig.meshes[0].send_state()

while state['indices'] and length x is changing, the figure isn't updating in the browser. i must be missing sth about how to update the mesh.

Maybe you forget to remove the previous mesh, for instance, would this work:
fig.meshes = [mesh]

@maartenbreddels - it doesn't. the first mesh gets drawn, but no updates happen. how can i see what information is being sent to the browser?

In chome, View->Developer->Developer Tools->Network->Ws (if you don't see anything, refresh the page, the dev tools have to be open at page load to see the websocket connection).
But, also, try playing in the notebook, get a reference to the figure (fig = ipv.gcf()) and print out the meshes, remove  them etc.

tried this in the notebook - makes no difference to the interactive widget, but if i paste fig into a new cell, which redraws it there, the mesh is indeed gone.
fig = ipv.gcf()
mesh = fig.meshes[0]
fig.meshes = []
fig.send_state()

i also tried this:
mesh.lines[some_indices] = 0
mesh.send_state('lines')

again, the interactive figure does not update, but if i open the figure in a new cell, i see the updated lines.

Ok, I just fixed the issue with the meshes not being removed (https://github.com/maartenbreddels/ipyvolume/commit/a24d5ece55c4b36ebd962fe062daecc80dbece99)

mesh.lines[some_indices] = 0
mesh.send_state('lines')

seems buggy, for small amount of data it sometimes works, i'm still figuring this one out.
copy = mesh.lines.copy()
copy[:] = 0
mesh.lines = copy

This gives me consistent results, can you try this and let me know if it works?

@maartenbreddels - both the first and the second appears to be working, but not respecting hold_sync()

@maartenbreddels - definitely option 1 is more buggy than option 2

@maartenbreddels - nevermind my previous two comments - hold_sync is working fine. i'm trying to get a bit more debugging going to fix some remaining issues.
this has been super helpful - thank you.

Thanks as well for pushing ipyvolume to the max!


TODO and fix for document test suite execution from buildout

Coverage remained the same at 96.364% when pulling 3d0d38ce0b6d7a4d8c78b1e281b7f917ff475609 on sasha-kantoriz:a406246993541115_tests_refactoring into 2daefb9ac33369b4cd9d66cbd11884971a7dd8cd on openprocurement:master.


Fix index CTAD

Caught by @dalg24 in #1158.

Dunno why CI restarted. First build passed. Second one did too, but something happened on the last post step of SYCL.


serializer, TitleInfo

For long regions:

And for short:

You should also adjust ProfileOwnerDetailViewSerializer to display regions on the user's profile page.
And add style property max-width: 72% to .title-block__company_region to ensure correct size of region block, when many regions are selected.

Thank you for feedback. Done


https://github.com/CodeIntelligenceTesting/jazzer/tree/main/examples/junit not compling

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.1:testCompile (default-testCompile) on project jazzer-junit-example: Compilation failure: Compilation failure:
[ERROR] /C:/temp/jazzer/examples/junit/src/test/java/com/example/MutatorFuzzTest.java:[42,34] cannot find symbol
[ERROR]   symbol:   method invalidCorpusFilesPresent()
[ERROR]   location: class com.code_intelligence.jazzer.driver.FuzzTargetRunner
[ERROR] /C:/temp/jazzer/examples/junit/src/test/java/com/example/MutatorFuzzTest.java:[43,36] cannot find symbol
[ERROR]   symbol:   method mutatorDebugString()
[ERROR]   location: class com.code_intelligence.jazzer.driver.FuzzTargetRunner
[ERROR] -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException

something wrong with

jazzer-0.16.1.jar as dates are  1985

these are the changed versions that are not reflected in 0.16.1

Both changes are done in on 3rd and 4th Aprill after 0.161 uploaded that is 30th March 2023

Time to release the new version of jazzer-0.16.x.jar

Some of the examples turned into internal tests, sorry for that. Please see https://github.com/CodeIntelligenceTesting/jazzer/tree/main/examples/junit-spring-web for an actual example -  we will move the other tests to prevent confusion in the future.
The modification times of entries in Jazzer's release JARs are set to hardcoded values for reproducibility - this is working as intended.


errwrap linting errors: call could wrap the error with error-wrapping directive %w

Surfaced by errwrap v1.5.0:
/__w/check-cert/check-cert/internal/netutils/net.go:354:27: call could wrap the error with error-wrapping directive %w
/__w/check-cert/check-cert/internal/netutils/net.go:592:26: call could wrap the error with error-wrapping directive %w
/__w/check-cert/check-cert/internal/config/config.go:167:11: call could wrap the error with error-wrapping directive %w
/__w/check-cert/check-cert/cmd/check_cert/annotations.go:76:48: call could wrap the error with error-wrapping directive %w

Surfaced by errwrap v1.5.0:
/__w/check-cert/check-cert/cmd/check_cert/annotations.go:76:48: call could wrap the error with error-wrapping directive %w

Reported this one upstream to the linter author/maintainer. This looks like a false-positive:
https://github.com/atc0005/check-cert/blob/b8e02c30cf4692b50c6de54c2d8eb161eeb87803/cmd/check_cert/annotations.go#L76-L81

Another likely false-positive:

/__w/check-cert/check-cert/internal/netutils/net.go:592:26: call could wrap the error with error-wrapping directive %w

https://github.com/atc0005/check-cert/blob/b8e02c30cf4692b50c6de54c2d8eb161eeb87803/internal/netutils/net.go#L592-L597
This syntax would be supported in Go 1.20, but is not in Go 1.19 (linter intends to support back to Go 1.16).


Rename Quit menu to Quit Ockam in desktop system tray app.

Current
We're building a Desktop System Tray app, see https://github.com/build-trust/ockam/issues/5228
The current Quit menu looks like this:

Desired
According to Apple's design guidelines, Quit menus should show the name of the app.
We want to change it to Quit Ockam
Steps to reproduce
You can run the app as follows:
cd implementations/typescript
pnpm install
pnpm build

cd ../../implementations/rust/ockam/ockam_app
cargo tauri dev

Source Code
The code is here

https://github.com/build-trust/ockam/blob/develop/implementations/rust/ockam/ockam_app/src/quit/menu_items.rs#L13

We love helping new contributors!
If you have questions or need help as you work on your first Ockam contribution, please leave a comment on this discussion or join us on discord. If you're looking for other issues to contribute to, checkout labels -  https://github.com/build-trust/ockam/labels/good first issue or https://github.com/build-trust/ockam/labels/help wanted

@mrinalwadhwa let me do it .

Reopening this issue, since it seem we have some regression back to Quit in the latest develop. cc: @adrianbenavides @etorreborre


Unable to pipe YAMLs to the kubeconform container

I'm trying to pipe my YAML manifest to the kubeconform container, but I'm unable to do so.
Here is a minimal reproduction:
$ echo "" | docker run -it ghcr.io/yannh/kubeconform:latest
the input device is not a TTY

kubeconform expects an TTY, but it seems like that is not possible when piping in data to a docker run command. I don't think the TTY should be necessary in that case anyway.

The use case for me is that I use my devops-toolbox that contains all handy tools for me within that container. My command looks like this:
$ kubectl kustomize cert-manager --enable-helm | kubeconform -schema-location default -strict -summary
the input device is not a TTY
write /dev/stdout: broken pipe

Where kubectl and kubeconform are both just docker commands:
$ type kubectl
kubectl is aliased to `docker run -it -e HOME -e USER -v $PWD:/workdir -v $HOME/.kube/config:$HOME/.kube/config ghcr.io/skaronator/devops-toolbox:latest kubectl'
$ type kubeconform
kubeconform is aliased to `docker run -it -e HOME -e USER -v $PWD:/workdir -v $HOME/.kube/config:$HOME/.kube/config ghcr.io/skaronator/devops-toolbox:latest kubeconform'

Now I feel stupid. I tried everything and double-checked everything but yeah... That error is from docker not from kubeconform.


[stdlib] Improve readability by replacing if let with guard let in lexicographicallyPrecedes method

In the lexicographicallyPrecedes method, replace if let with guard let to decrease nesting levels and enhance readability.

@swift-ci please test

This looks good to me! Let's run tests

@swift-ci please test

@Azoy
Thank you for reviewing my pull request and running the CI tests.  Since I don't have the authority to approve and merge the PR, could you please take care of it if everything looks good to you?
I appreciate your help! 💚


Replace atom-space-pen-views with atom-select-list

This pull request uses atom-select-list as a drop-in replacement for atom-space-pen-views. Feature-wise nothing should change, but this will help removing jQuery from Atom.
/cc: @ungb for 👀

Looks good @as-cii I didn't see any issues while testing.

I just tested on latest from your branch, I didn't find any regressions.
One issue I noticed that also repros before your change is the setting Search All Panes.

Disable Search All Panes
Click cmd-b to search from buffer
Expected: only buffer from existing pane to show up. Actual: all results show up, if you click on a result, it is reopened in the active pane.

NOTE: if you have Search All Panes Enabled, it goes to the file in that pane.
Search All Panes Disabled:

Search All Panes Enabled:

NOTE: this issue I'm not sure classifies as a regression as it current exist, I can create another bug for it if needed.


BWNT pushed to Firefox

I'm a user of FRC New Tab. Recently, it seems like FRC New Tab has changed to erikboesen/BWNT on Firefox. Can this be changed back please?

Good lord...  Will fix this right now.

Pushed a new version. Sorry about that and thanks for letting me know.

No problem, thanks for getting it fixed so quickly!

I think the version number has to be higher than the "old one" which is showing as 2.1.3 (BWNT)

Fixed.


feat: add ability to delete specific tag

What type of PR is this?

Which issue does this PR fix:
What does this PR do / Why do we need it:
If an issue # is not available please add repro steps and logs from IPAMD/CNI showing the issue:
Testing done on this change:

Automation added to e2e:

Will this break upgrades or downgrades. Has updating a running cluster been tested?:
Does this change require updates to the CNI daemonset config files to work?:

Does this PR introduce any user-facing change?:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Also, you need to squash your commits so you only have 1

Superseded by https://github.com/project-zot/zui/pull/401

@eviishondell Thanks for your PR.

@eviishondell Thanks for your PR.

No problem!


New Kotlinx Coroutines Version

I think it is a best to use this after next release versions because it may break some codes.
https://github.com/Kotlin/kotlinx.coroutines/releases/tag/0.26.0

Maybe we can work on #429 when working on this. By semantic versioning, if the upgrade we require breaks current consumers it will be on 2.0.0.

I agree with @SleeplessByte I think we can take this opportunity to clear up the current APIs and provide the better ones.

Closed by #438


Fixes #9004: Change version from 3.3 to 4.0 in parent-pom

https://www.rudder-project.org/redmine/issues/9004

OK, merging this PR


Disable Editing / Deleting for a specific reply (Hacky solution inside)

First, thank you for making this tool. It's well designed and has a lot of potential.
Issue
I'll have multiple users replying to an annotation. When a specific user clicks on the annotation, it would be nice to have them edit only their replies. The other replies should be read-only and without the edit/delete dropdown. Is there a way to do that?
Hacky Solution
I found a hacky solution that will suffice on my end for now. I wanted to mention it in case someone else is looking to do this.
Make sure to use setAuthInfo so that each conversation is associated with a displayName.
Use the selectAnnotation event handler. When an annotation is selected, I used JQuery to find the label boxes that are NOT the current user that is logged in. I then traverse up using parent() to find the .icon and hide that.
Here's the javascript code:
var removeEditDropdown;

removeEditDropdown = function() {
  return $(".lastmodified-by:not(:contains(" + asset.userName + "))").parent().parent().find('.icon').hide();
};

anno.on('selectAnnotation', function(annotation) {
  $('.icon.arrow-down').show();
  return setTimeout(removeEditDropdown, 40);
});

setTimeout had to be used or otherwise there's not enough of a delay to remove the drop down elements.
Is it pretty? No. But it will suffice for now.
Here's the result:

Hi, thanks for the positive feedback. I appreciate that!
For your specific case (disabling the editing of other users' comments): in fact there's a proper solution available since on of the recent releases (v2.1.0). But that's still so new I didn't get around to properly documenting it yet...
The comment widget now supports an additional editable config option. In your case, the initialization should look like this:
var anno = Annotorious.init({
  image: '...',
  widgets: [
    { widget: 'COMMENT', editable: 'MINE_ONLY' }
  ]
});

That will give you an editor popup like in your image (comments & replies, but no tagging), and the comment widget will have the MINE_ONLY editing rule set:

The comment widget now has an additional editable config option so you can switch (separately from the global setting) between editable (editable: true), not editable (editable: false) and editable, but don't allow editing other users' contributions
(editable: 'MINE_ONLY).

Fantastic! Thank you so much for the quick reply and for describing the solution to this!

Hello, this is related to this feature, but how to also prevent a user from moving the annotation if he did not originally create it? It seems to me this should be included in this disabling functionality?


Fix quoting of bootstrap_expect in README

Coverage remained the same at 100.0% when pulling 5527c9dd790cdaa0b8d689588bb9074cd4421fde on jhmartin:patch-2 into 52f6669a0ad3e03bd0de15bd79ef61c4ae935665 on johnbellone:master.


Use system installed deflate library

Use pkgconfig if available to locate a libdeflate system library.
If a specific library prefix is given by LIBDEFLATE_PREFIX=somepath, use that.
Otherwise if pkgconfig is installed and the library can be located via that, use that one.
Otherwise (or if enforced by USE_BUNDLED_DEFLATE=yes), fall back to bundled code.
Build tested, with and without deflate library installed, on OpenBSD
amd64 current. Tests pass.

BTW, I edited the top post a bit to reflect the current behaviour.

BTW, our tests of course only test the default behaviour and do not set any of these env vars yet - but I suspect you tried all modes manually?

On Thu 03/03/2022 09:47, TW wrote:

@ThomasWaldmann commented on this pull request.

pc = None

+deflate_sources = [

"deflate.c",
+]

+if prefer_system_libdeflate and system_prefix_libdeflate:

print("Detected and preferring libdeflate [via LIBDEFLATE_PREFIX]")
extension_kwargs = dict(include_dirs=[os.path.join(system_prefix_libdeflate, "include")],

                       library_dirs=[os.path.join(system_prefix_libdeflate, "lib")],

                       libraries=["deflate"])

+elif prefer_system_libdeflate and pc and pc.installed("libdeflate", ">= 1.10"):

print("Detected and preferring libdeflate [via pkgconfig]")
extension_kwargs = pc.parse("libdeflate")
+else:
print("Using bundeld libdeflate")

typo
--
Reply to this email directly or view it on GitHub:
https://github.com/dcwatson/deflate/pull/29#pullrequestreview-899290779
You are receiving this because you authored the thread.
Message ID: @.***>

Fixed :-)

BTW, our tests of course only test the default behaviour and do not set any of these env vars yet - but I suspect you tried all modes manually?

Yes, tried all modes manually. So far, behavioud is as expected.

@dcwatson I think this is a good and very flexible improvement to deflate and it especially enables dist package maintainers to not use the bundled code (or even remove it) if they rather prefer to use the libdeflate library from another dist package.
Avoids duplication and eases maintenance, especially in case of critical bug or security fixes, they then only need to get fixed at one place.
Merge?

@bket If you don't mind, I'll fix it now according to the review comments of @dcwatson ...

@dcwatson have a look now!

@bket if this gets merged and release, it will unblock some borg PRs, that's why I am trying to speed this up a bit. :-)

maybe squash all commits together instead of merging all the separate commits.

trying pytest within cibuildwheel now ^^^^.

@dcwatson considering this works and wheels are even tested now, i'ld like to merge this if you don't object.
this will remove the pypy wheel build (which likely was broken before also, just nobody noticed).
i'll remove that temporary commit now, which was just for demonstation purposes, but we still have the test results linked above.

temporary commit removed, rebased on current master.

As there were no more objections, I merged this now.
In case we find more to do / to fix, it can be done in a later PR.
Next thing we need is a new release. @dcwatson can you do that or give me permissions on pypi.org to do that? #26


Github Container Registry URL 404

The available ghcr.io/actualbudget/actual-server url doesn't seem to be working as it 404s for docker pull. The  jlongster/actual-server reference does, at least.

Hey,
I think this is fixed now, if your still having issues let me know and I will re-open this issue.
Cheers
Rich

Hi Rich, I just tried pulling and am getting this output:
# docker pull ghcr.io/actualbudget/actual-server Using default tag: latest Error response from daemon: Head "https://ghcr.io/v2/actualbudget/actual-server/manifests/latest": unauthorized


int("01:02:03") does not raise ValueError

I wrote a bi-directional converter function intended to take either an integer number of seconds or a duration in hh:mm:ss format and return a tuple like (3723, "01:02:03"), i.e. represented as both int seconds and a time duration string.
To test whether the argument is an int, I have
        try:
            s = int(input_str)
            h = m = "00"
        except ValueError:
            ...

Transcrypt (v3.6.92) is rendering this as
					try {
						var s = int (input_str);
						var __left0__ = '00';
						var h = __left0__;
						var m = __left0__;
					}
					catch (__except0__) {
                                         ...

That correctly raises a ValueError if input_str is something like "foo" but returns 0 with no exception raised if input_str is a formatted time duration like "01:02:03".
It's definitely the transcrypted int function since I can call it directly in DevTools and observe the incorrect result, e.g.
hmi_server.int ("01:02:03")
0

Apologies if this is known issue. I didn't find anything apropos when I searched.

Hi Michael,
Will look into this.
Maybe the price in terms of performance is too high, maybe not.
Will get back on this.
KR
Jacques

Thanks, Jacques!


Add test utils with get_test_instance for testing

This change is

Please break into smaller PRs

Previously, dan-starkware wrote…
Please break into smaller PRs

ptal https://reviewable.io/reviews/starkware-libs/starknet-api/6

ptal https://reviewable.io/reviews/starkware-libs/starknet-api/6

To be implemented as macro rules in papyrus, or as a derive macro in starknet_api (https://reviewable.io/reviews/starkware-libs/starknet-api/6)


Copy Miro master assets

What is this PR trying to achieve?
Move miro master assets to their final destination (for now)
Who is this change for?
👩  👨  👨🚀  👩🎨 🤸♀ 👨🍳  💻 🚶♀ 🐺
Have the following been considered/are they needed?

[ ] Run terraform apply.

Thanks for the comments @alexwlchan . I'm going to address them now. Just to let you know, changes to the lambda utils module are now in a separate patch: #1078 , so I'll address those regarding that code in there. Once that is merged to master I'll fix the conflicts here


UglifyJsPlugin: typescript sourcemap not match

Do you want to request a feature or report a bug?
Bug

What is the current behavior?
After use webpack build my project (ts) with UglifyJsPlugin, it worked well, but sourcemap not match when debug with chrome.

line 81 can not have a breakpoint.
Begin,  I at line 80 and item.isCompletion==true, it will jump to line 83 if I single step debugging.

// webpack.config

   module: {
        rules: [
            {
                test: /\.ts$/,
                exclude: /node_modules/,
                loader: 'happypack/loader?id=ts'
            }
        ]
    },
    resolve: {
        extensions: ['.ts', '.js']
    },
   output: {
        filename: '[name].js',
        path: __dirname,
        libraryTarget: 'window'
    },
    plugins: [
        new HappyPack({
            id: 'ts',
            threadPool: happyThreadPool,
            loaders: [
                {
                    path: 'ts-loader',
                    query: {
                        happyPackMode: true
                    }
                }
            ]
        }),
        new webpack.optimize.UglifyJsPlugin({
            sourceMap: true,
            mangle: false
        })
    ],
   devtool: 'source-map'

If the current behavior is a bug, please provide the steps to reproduce.
build with UglifyJsPlugin

What is the expected behavior?
debug work well!!!
If this is a feature request, what is motivation or use case for changing the behavior?
none
Please mention other relevant information such as the browser version, Node.js version, webpack version and Operating System.
browser version: 58.0.3029.110
Node version: v6.9.5
webpack: v2.6.0
OS: win7

With minimizing you may loose details in the source map.
Try analysing the source-map with http://sokra.github.io/source-map-visualization/

Thx for your reply!
With source-map-visualization, it seems to lines all match!
js & map

ts

Or where i am wrong?

the --and ++ operators seem to point to the incorrect lines

:+1: Yes, You are right!
I build my project without UglifyJs Plugin， debug works for me.
Is there any good solution to the problem? Or I have to study how ts/uglifyjs works together to generate sourcemap ...

@webpack-bot move to webpack-contrib/uglifyjs-webpack-plugin


ExternalName Service Causes Unintended External Traffic

Issue: ExternalName Service Causes Unintended External Traffic in helloworld-go Sample
Version Affected: 1.14.0
Description:
After applying the helloworld-go sample provided in the latest release (version 1.14.0) of Knative Serving, an ExternalName service was generated as described below. This service setup leads to internal application requests being routed externally via the NAT Gateway, instead of being contained within the cluster. This behavior might not be intended as it causes cluster-internal communications to be sent over the internet.
Generated Service YAML:
apiVersion: v1
kind: Service
metadata:
  annotations:
    serving.knative.dev/creator: system:admin
    serving.knative.dev/lastModifier: system:admin
  creationTimestamp: "2024-04-25T07:51:10Z"
  labels:
    serving.knative.dev/route: helloworld-go
    serving.knative.dev/service: helloworld-go
  name: helloworld-go
  namespace: default
  ownerReferences:
  - apiVersion: serving.knative.dev/v1
    blockOwnerDeletion: true
    controller: true
    kind: Route
    name: helloworld-go
    uid: d4bd7725-d0ec-4c60-9e1d-5fc0a9f0e4e5
  resourceVersion: "1883"
  uid: 8321e1c1-5850-4dfb-b78b-687d717a9083
spec:
  externalName: helloworld-go.default.example.com
  ports:
  - appProtocol: kubernetes.io/h2c
    name: http2
    port: 80
    protocol: TCP
    targetPort: 80
  sessionAffinity: None
  type: ExternalName
status:
  loadBalancer: {}

Expected Behavior:
Internal requests to the service should remain within the cluster, avoiding unnecessary use of external network resources.
Actual Behavior:
Traffic intended for internal services is routed externally, causing potential latency and cost implications.
Steps to Reproduce:

Deploy the helloworld-go sample from Knative Serving 1.14.0.
Observe the routing behavior of requests to the helloworld-go service.

The externalName: helloworld-go.default.example.com is a temporary placeholder until the underlying networking layer provides an alternate hostname or IP.
Are you not seeing the service being updated with the cluster local host or cluster ip?

@kahirokunn just following up here

This also occurred when using Cilium's GatewayAPI.
We have not had time to re-verify this one.
I will share the results and the scripts etc. I used when I tested it next time!
thx :pray:

We don't test with Cillium - so it's probably specific to that implementation.

I understand.
Please let me share any more information when I get it.

@dprotaso for me with cilium, my test deployment's generated ExternalName service stay as externalName: http-bin.thenamespace.svc.cluster.local

/reopen


Initialize backend

From backend branch create new called "initialize-backend" and initalize the backend by setting up main structure with Flask. After that create pull request assigning backend lead and one other 3rd year.
Make sure to create a backend folder in main directory.

Merged initial backend commit to main


#448 Sheepdog logo

Deploy preview for landscape ready!
Built with commit 9777e2d308427570469a3c44d86b47fa4520b677
https://deploy-preview-452--landscape.netlify.com

Awesome, thanks.


[UI-Components] Endless loop in DateTimePicker when using objects.

Hi! I found a endless loop, which can be created if a controlled DateTimePicker component sets a object instead of a string. I have a "good" and a "evil" example which you can copy into the playground
😇
import React, { useEffect, useState } from "react"
import { DateTimePicker } from "juno-ui-components"

export default function App() {

const [testState, setTestState] = useState({
    date: {
      end: null
    },
  })

  return (
  <DateTimePicker
              value={testState?.date?.end}
              dateFormat="Y-m-d H:i"
              label="Select a end date"
              enableTime
              time_24hr
              required
              onChange={(e, f) => {
                console.log("end date as a string:", f)
                setTestState({ ...testState, date: { end: f } })
              }}
            />
  )
}

😈
import React, { useEffect, useState } from "react"
import { DateTimePicker } from "juno-ui-components"

export default function App() {

const [testState, setTestState] = useState({
    date: {
      end: null
    },
  })

  return (
  <DateTimePicker
              value={testState?.date?.end}
              dateFormat="Y-m-d H:i"
              label="Select a end date"
              enableTime
              time_24hr
              required
              onChange={(e, f) => {
                console.log("end date as a object", e)
                setTestState({ ...testState, date: { end: e } })
              }}
            />
  )
}

Hey Tilman,
thanks for reporting this issue, I can reproduce it locally, too. I think I know where to look, but I will not have the time to investigate any further until mid next week.


Move to node-mihome from miio

Currently, I'm using a fork of miio where support for miot devices were added. It's really hard to add support for new devices without owning them. I found node-mihome project which seems a lot more feature complete with more device support.

Hi torifat, do you think you will be able to implement the support for the 3C model due to the API changes? Let me know if I can help on testing it.

Hi torifat, do you think you will be able to implement the support for the 3C model due to the API changes? Let me know if I can help on testing it.

Hi torifat, do you think you will be able to implement the support for the 3C model due to the API changes? Let me know if I can help on testing it.

Probably, it's in the node-mihome supported devices list.

Hi torifat, do you think you will be able to implement the support for the 3C model due to the API changes? Let me know if I can help on testing it.

Probably, it's in the node-mihome supported devices list.

Hi Torifat, the mb3 model belongs to the Air Purifier 3H, the 3C model is
the mb4 and this one is not in the list.
Regards.
El El mar, 19 ene 2021 a las 1:13, ifeign<EMAIL_ADDRESS>escribió:

Hi torifat, do you think you will be able to implement the support for the
3C model due to the API changes? Let me know if I can help on testing it.
Probably, it's in the node-mihome supported devices list.
[image: Screen Shot 2021-01-18 at 4 12 10 PM]
https://user-images.githubusercontent.com/32289760/104972927-0a78d180-59a8-11eb-8dab-1d0a7bb947c2.png
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/torifat/xiaomi-mi-air-purifier/issues/19#issuecomment-762523979,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AH3CBQM2JMOLC5SKNTTGTG3S2TFB5ANCNFSM4VWWAO3Q
.

--
Daniel Astudillo Vila

Hi Torifat, the mb3 model belongs to the Air Purifier 3H, the 3C model is
the mb4 and this one is not in the list.
Regards.
El El mar, 19 ene 2021 a las 1:13, ifeign<EMAIL_ADDRESS>escribió:

Hi torifat, do you think you will be able to implement the support for the
3C model due to the API changes? Let me know if I can help on testing it.
Probably, it's in the node-mihome supported devices list.
[image: Screen Shot 2021-01-18 at 4 12 10 PM]
https://user-images.githubusercontent.com/32289760/104972927-0a78d180-59a8-11eb-8dab-1d0a7bb947c2.png
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/torifat/xiaomi-mi-air-purifier/issues/19#issuecomment-762523979,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AH3CBQM2JMOLC5SKNTTGTG3S2TFB5ANCNFSM4VWWAO3Q
.

--
Daniel Astudillo Vila

the node-mihome is not a Homebridge plugin right? not sure how to add this under Homebridge. Sorry I'm new in this world.

the node-mihome is not a Homebridge plugin right? not sure how to add this under Homebridge. Sorry I'm new in this world.

@danixque no, it's not a homebrige plugin. It's a library for controlling devices. If I move to it then I will be able to support all the devices. I spent some time recently exploring it. The main problem is it works a bit differently. For example, you need to give it your xiaomi username and password. It uses that to pull your list of devices and generate token. My concern is some people might not be happy to provide their username and password.

@danixque no, it's not a homebrige plugin. It's a library for controlling devices. If I move to it then I will be able to support all the devices. I spent some time recently exploring it. The main problem is it works a bit differently. For example, you need to give it your xiaomi username and password. It uses that to pull your list of devices and generate token. My concern is some people might not be happy to provide their username and password.

Is the node-mihome library a way of testing some devices in order to be able to create a Homebridge plugin after the investigation?
Is this a good place to run the mihome code https://npm.runkit.com/node-mihome ?
Should I post the console results somewhere?

Is the node-mihome library a way of testing some devices in order to be able to create a Homebridge plugin after the investigation?
Is this a good place to run the mihome code https://npm.runkit.com/node-mihome ?
Should I post the console results somewhere?

Is it gonna be online only solution? I have disabled internet connection on my xiaomi devices. So it will not work for me i think

Is it gonna be online only solution? I have disabled internet connection on my xiaomi devices. So it will not work for me i think

I don't think any of the mi purifier plugins out there work without
internet access.. or am I missing something?
On Thu, Jan 21, 2021 at 12:11 AM adamrzanek<EMAIL_ADDRESS>wrote:

Is it gonna be online only solution? I have disabled internet connection
on my xiaomi devices. So it will not work for me i think
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/torifat/xiaomi-mi-air-purifier/issues/19#issuecomment-764460412,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AHWLHYFWIG5RA6PTJIFKXGLS27OT5ANCNFSM4VWWAO3Q
.

I don't think any of the mi purifier plugins out there work without
internet access.. or am I missing something?
On Thu, Jan 21, 2021 at 12:11 AM adamrzanek<EMAIL_ADDRESS>wrote:

Is it gonna be online only solution? I have disabled internet connection
on my xiaomi devices. So it will not work for me i think
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/torifat/xiaomi-mi-air-purifier/issues/19#issuecomment-764460412,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AHWLHYFWIG5RA6PTJIFKXGLS27OT5ANCNFSM4VWWAO3Q
.

They all work without internet :) i have no internet access set on homebridge and all xiaomi devices and it’s all working good

On 22 Jan 2021, at 20:36, ifeign<EMAIL_ADDRESS>wrote:

I don't think any of the mi purifier plugins out there work without
internet access.. or am I missing something?
On Thu, Jan 21, 2021 at 12:11 AM adamrzanek<EMAIL_ADDRESS>wrote:

Is it gonna be online only solution? I have disabled internet connection
on my xiaomi devices. So it will not work for me i think
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/torifat/xiaomi-mi-air-purifier/issues/19#issuecomment-764460412,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AHWLHYFWIG5RA6PTJIFKXGLS27OT5ANCNFSM4VWWAO3Q
.

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or unsubscribe.

They all work without internet :) i have no internet access set on homebridge and all xiaomi devices and it’s all working good

On 22 Jan 2021, at 20:36, ifeign<EMAIL_ADDRESS>wrote:

I don't think any of the mi purifier plugins out there work without
internet access.. or am I missing something?
On Thu, Jan 21, 2021 at 12:11 AM adamrzanek<EMAIL_ADDRESS>wrote:

Is it gonna be online only solution? I have disabled internet connection
on my xiaomi devices. So it will not work for me i think
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/torifat/xiaomi-mi-air-purifier/issues/19#issuecomment-764460412,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AHWLHYFWIG5RA6PTJIFKXGLS27OT5ANCNFSM4VWWAO3Q
.

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or unsubscribe.

Which plugin are you using? I've been using this one and it doesn't seem to
work offline https://github.com/YinHangCode/homebridge-mi-airpurifier
On Fri, Jan 22, 2021 at 11:41 AM adamrzanek<EMAIL_ADDRESS>wrote:

They all work without internet :) i have no internet access set on
homebridge and all xiaomi devices and it’s all working good

On 22 Jan 2021, at 20:36, ifeign<EMAIL_ADDRESS>wrote:

I don't think any of the mi purifier plugins out there work without
internet access.. or am I missing something?
On Thu, Jan 21, 2021 at 12:11 AM adamrzanek<EMAIL_ADDRESS>wrote:

Is it gonna be online only solution? I have disabled internet
connection
on my xiaomi devices. So it will not work for me i think
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<
https://github.com/torifat/xiaomi-mi-air-purifier/issues/19#issuecomment-764460412
,
or unsubscribe
<
https://github.com/notifications/unsubscribe-auth/AHWLHYFWIG5RA6PTJIFKXGLS27OT5ANCNFSM4VWWAO3Q

.

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or unsubscribe.

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/torifat/xiaomi-mi-air-purifier/issues/19#issuecomment-765642169,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AHWLHYB4UETK7PLSXPLFA4LS3HIHTANCNFSM4VWWAO3Q
.

Which plugin are you using? I've been using this one and it doesn't seem to
work offline https://github.com/YinHangCode/homebridge-mi-airpurifier
On Fri, Jan 22, 2021 at 11:41 AM adamrzanek<EMAIL_ADDRESS>wrote:

They all work without internet :) i have no internet access set on
homebridge and all xiaomi devices and it’s all working good

On 22 Jan 2021, at 20:36, ifeign<EMAIL_ADDRESS>wrote:

I don't think any of the mi purifier plugins out there work without
internet access.. or am I missing something?
On Thu, Jan 21, 2021 at 12:11 AM adamrzanek<EMAIL_ADDRESS>wrote:

Is it gonna be online only solution? I have disabled internet
connection
on my xiaomi devices. So it will not work for me i think
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<
https://github.com/torifat/xiaomi-mi-air-purifier/issues/19#issuecomment-764460412
,
or unsubscribe
<
https://github.com/notifications/unsubscribe-auth/AHWLHYFWIG5RA6PTJIFKXGLS27OT5ANCNFSM4VWWAO3Q

.

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or unsubscribe.

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/torifat/xiaomi-mi-air-purifier/issues/19#issuecomment-765642169,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AHWLHYB4UETK7PLSXPLFA4LS3HIHTANCNFSM4VWWAO3Q
.

This one  https://github.com/YinHangCode/homebridge-mi-airpurifier for 2h

On 22 Jan 2021, at 23:15, ifeign<EMAIL_ADDRESS>wrote:

Which plugin are you using? I've been using this one and it doesn't seem to
work offline https://github.com/YinHangCode/homebridge-mi-airpurifier
On Fri, Jan 22, 2021 at 11:41 AM adamrzanek<EMAIL_ADDRESS>wrote:

They all work without internet :) i have no internet access set on
homebridge and all xiaomi devices and it’s all working good

On 22 Jan 2021, at 20:36, ifeign<EMAIL_ADDRESS>wrote:

I don't think any of the mi purifier plugins out there work without
internet access.. or am I missing something?
On Thu, Jan 21, 2021 at 12:11 AM adamrzanek<EMAIL_ADDRESS>wrote:

Is it gonna be online only solution? I have disabled internet
connection
on my xiaomi devices. So it will not work for me i think
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<
https://github.com/torifat/xiaomi-mi-air-purifier/issues/19#issuecomment-764460412
,
or unsubscribe
<
https://github.com/notifications/unsubscribe-auth/AHWLHYFWIG5RA6PTJIFKXGLS27OT5ANCNFSM4VWWAO3Q

.

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or unsubscribe.

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/torifat/xiaomi-mi-air-purifier/issues/19#issuecomment-765642169,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AHWLHYB4UETK7PLSXPLFA4LS3HIHTANCNFSM4VWWAO3Q
.

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or unsubscribe.

This one  https://github.com/YinHangCode/homebridge-mi-airpurifier for 2h

On 22 Jan 2021, at 23:15, ifeign<EMAIL_ADDRESS>wrote:

Which plugin are you using? I've been using this one and it doesn't seem to
work offline https://github.com/YinHangCode/homebridge-mi-airpurifier
On Fri, Jan 22, 2021 at 11:41 AM adamrzanek<EMAIL_ADDRESS>wrote:

They all work without internet :) i have no internet access set on
homebridge and all xiaomi devices and it’s all working good

On 22 Jan 2021, at 20:36, ifeign<EMAIL_ADDRESS>wrote:

I don't think any of the mi purifier plugins out there work without
internet access.. or am I missing something?
On Thu, Jan 21, 2021 at 12:11 AM adamrzanek<EMAIL_ADDRESS>wrote:

Is it gonna be online only solution? I have disabled internet
connection
on my xiaomi devices. So it will not work for me i think
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<
https://github.com/torifat/xiaomi-mi-air-purifier/issues/19#issuecomment-764460412
,
or unsubscribe
<
https://github.com/notifications/unsubscribe-auth/AHWLHYFWIG5RA6PTJIFKXGLS27OT5ANCNFSM4VWWAO3Q

.

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or unsubscribe.

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/torifat/xiaomi-mi-air-purifier/issues/19#issuecomment-765642169,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AHWLHYB4UETK7PLSXPLFA4LS3HIHTANCNFSM4VWWAO3Q
.

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or unsubscribe.


How to disable animation on MobFoxBannerView instance?

I'd like to disable animation on MobFoxBannerView instance. Setting refreshAnimation property to UIViewAnimationTransitionNone has no effect.
Is this the correct way to disable animation?
Please, find my code below
MobFoxBannerView *bannerView = [[MobFoxBannerView alloc] initWithFrame:CGRectZero];

bannerView.allowDelegateAssigmentToRequestAd = NO;
bannerView.delegate = self;
bannerView.backgroundColor = [UIColor blackColor];
bannerView.refreshAnimation = UIViewAnimationTransitionNone;
bannerView.autoresizingMask = UIViewAutoresizingFlexibleWidth | UIViewAutoresizingFlexibleTopMargin;

Hi,
Actually there was a bug in the SDK that caused the animation to always be "flip from left", I'll push a fix in a minute. Sorry for the trouble, your code is OK.


Granular aggregation

Types of changes

[ ] Enhancement (project structure, spelling, grammar, formatting)
[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have added tests to cover my changes.
[x] All new and existing tests passed.

A description of the changes proposed in the Pull Request

@jmcook1186 @manushak build will be resolved after updating if-core version.

Updated


add glob like path support and file copy on disk

I needed a way to emit multiple files with glob pattern, to handle them in zip plugin for real builds.
But also to copy them on disk to handle serve use cases with plugins that does not actually use the emitedFiles.
Other plugins I found like cpy do not emit files and are written in plain JS so I think the best solution is to add options in your plugin to also understand glob pattern and copy files on disk.

Hi,
Sorry for not replying for a long time. Your code doesn't work with emitFile because your call it inside a callback. A glob.sync method should be used, as I think. Anyway, thank you for the PR, I'll merge it and add some fixes.


Xray ADOT Addon

Describe the feature
AWS X-Ray helps developers analyze and debug production, distributed applications, such as those built using a microservices architecture. This Addon deploys an AWS Distro for OpenTelemetry (ADOT) Collector for X-Ray which receives traces from the application and sends the same to X-Ray console. You can change the mode to Daemonset, StatefulSet, and Sidecar depending on your deployment strategy.
Use Case
This enables a simplified experience for instrumenting your applications running on Amazon EKS to send metric and trace data to multiple monitoring service options like Amazon CloudWatch, Prometheus, and X-Ray.
Proposed Solution
New XRay Addon to remote write traces to Xray Console using ADOT Addon.
Other Information
No response
Acknowledgements

[X] I may be able to implement this feature request

CDK version used
2.33
EKS Blueprints Version
1.1.0
Node.js Version
18.6.0
Environment details (OS name and version, etc.)
mac

PR #449


Add exception for Syling Tracker

Added an exception for the "Syling Tracker" addon. Since there was no exception, the blizzard quests module overlapped the addon.

LGTM, sorry for the delay and thanks for your changes!

I'll have time to do some more tests and push a new release tomorrow. Thanks for your patience!


How to improve window dragging performance?

I am experiencing quite a lot of lag when I drag windows around. Is there any way to fix this lag?

Still no clue

@y2k04 did you find the way to fix this?

No I didn't. I just uninstalled it because of how painful the lag was to deal with on a daily basis. I just could not bare it anymore.

I had closed this issue because nothing seemed to be done about it.

Did you turn on Blur Behind? If so, this is expected behaviour.

No.

y2k04 did you find the way to fix this?

btw it was "blur behind" issue for me

I had closed this issue because nothing seemed to be done about it.

You're right, nothing can be done. If it happens only on a specific app then its the app's problem and you should make a rule to exclude the app. If this happens on all apps then it should be a bug in Windows or a hardware compatibility issue.

I had closed this issue because nothing seemed to be done about it.

You're right, nothing can be done. If it happens only on a specific app then its the app's problem and you should make a rule to exclude the app. If this happens on all apps then it should be a bug in Windows or a hardware compatibility issue.

It occurs system-wide. All apps were lagging like crazy.

It happened most notably with Explorer


[$500] Payment issue for #29435

This is a payment issue for #29435
I just need to get the Upwork automation to create the job so I can pay @gadhiyamanan
If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number:
Reproducible in staging?:
Reproducible in production?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @gadhiyamanan
Slack conversation:
Action Performed:
Break down in numbered steps
Expected Result:
Describe what you think should've happened
Actual Result:
Describe what actually happened
Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01ca1fcd13b8889f95
Upwork Job ID:<PHONE_NUMBER>020460032
Last Price Increase: 2023-10-24

Payment has been issued!


Error in graph.py when running momentum_pipeline.py example algorithm.

Dear Zipline Maintainers,
Before I tell you about my issue, let me describe my environment:
Environment

Operating System: Ubuntu 16.04
Python Version: 2.7
How did you install Zipline:  pip
List of packages:
alembic (0.9.6)
backports.functools-lru-cache (1.4)
bcolz (0.12.1)
Bottleneck (1.2.1)
certifi (2<IP_ADDRESS>)
chardet (3.0.4)
click (6.7)
contextlib2 (0.5.5)
cycler (0.10.0)
cyordereddict (1.0.0)
Cython (0.27.2)
decorator (4.1.2)
empyrical (0.3.2)
idna (2.6)
intervaltree (2.1.0)
Logbook (1.1.0)
lru-dict (1.1.6)
Mako (1.0.7)
MarkupSafe (1.0)
matplotlib (2.1.0)
multipledispatch (0.4.9)
networkx (2.0)
numexpr (2.6.4)
numpy (1.13.3)
pandas (0.18.1)
pandas-datareader (0.5.0)
patsy (0.4.1)
pip (9.0.1)
pkg-resources (0.0.0)
pyparsing (2.2.0)
python-dateutil (2.6.1)
python-editor (1.0.3)
pytz (2017.2)
requests (2.18.4)
requests-file (1.4.2)
requests-ftp (0.3.1)
scipy (0.19.1)
setuptools (36.6.0)
six (1.11.0)
sortedcontainers (1.5.7)
SQLAlchemy (1.1.14)
statsmodels (0.8.0)
subprocess32 (3.2.7)
tables (3.4.2)
toolz (0.8.2)
urllib3 (1.22)
v (3.0.0)
wheel (0.30.0)
zipline (1.1.1)

Now that you know a little about me, let me tell you about the issue I am
having:
When I run the momentum_pipeline.py from example algorithms by using the following command:
zipline run -f momentum_pipeline.py --start 2017-02-02 --end 2017-10-20 -o results_mom.pickle
it results in the following error:
Traceback (most recent call last):
File "/home/ubuntu/venv-zipline/bin/zipline", line 11, in
load_entry_point('zipline==1.1.1', 'console_scripts', 'zipline')()
File "/home/ubuntu/venv-zipline/local/lib/python2.7/site-packages/click/core.py", line 722, in call
return self.main(*args, **kwargs)
File "/home/ubuntu/venv-zipline/local/lib/python2.7/site-packages/click/core.py", line 697, in main
rv = self.invoke(ctx)
File "/home/ubuntu/venv-zipline/local/lib/python2.7/site-packages/click/core.py", line 1066, in invoke
return _process_result(sub_ctx.command.invoke(sub_ctx))
File "/home/ubuntu/venv-zipline/local/lib/python2.7/site-packages/click/core.py", line 895, in invoke
return ctx.invoke(self.callback, **ctx.params)
File "/home/ubuntu/venv-zipline/local/lib/python2.7/site-packages/click/core.py", line 535, in invoke
return callback(*args, **kwargs)
File "/home/ubuntu/venv-zipline/local/lib/python2.7/site-packages/zipline/main.py", line 97, in _
return f(*args, **kwargs)
File "/home/ubuntu/venv-zipline/local/lib/python2.7/site-packages/click/decorators.py", line 17, in new_func
return f(get_current_context(), *args, **kwargs)
File "/home/ubuntu/venv-zipline/local/lib/python2.7/site-packages/zipline/main.py", line 240, in run
environ=os.environ,
File "/home/ubuntu/venv-zipline/local/lib/python2.7/site-packages/zipline/utils/run_algo.py", line 179, in _run
overwrite_sim_params=False,
File "/home/ubuntu/venv-zipline/local/lib/python2.7/site-packages/zipline/algorithm.py", line 709, in run
for perf in self.get_generator():
File "/home/ubuntu/venv-zipline/local/lib/python2.7/site-packages/zipline/gens/tradesimulation.py", line 237, in transform
algo.before_trading_start(self.current_data)
File "/home/ubuntu/venv-zipline/local/lib/python2.7/site-packages/zipline/algorithm.py", line 453, in before_trading_start
self._before_trading_start(self, data)
File "momentum_pipeline.py", line 68, in before_trading_start
context.pipeline_data = pipeline_output('my_pipeline')
File "/home/ubuntu/venv-zipline/local/lib/python2.7/site-packages/zipline/utils/api_support.py", line 57, in wrapped
return getattr(algo_instance, f.name)(*args, **kwargs)
File "/home/ubuntu/venv-zipline/local/lib/python2.7/site-packages/zipline/utils/api_support.py", line 104, in wrapped_method
return method(self, *args, **kwargs)
File "/home/ubuntu/venv-zipline/local/lib/python2.7/site-packages/zipline/algorithm.py", line 2457, in pipeline_output
return self._pipeline_output(p, chunks)
File "/home/ubuntu/venv-zipline/local/lib/python2.7/site-packages/zipline/algorithm.py", line 2499, in _pipeline_output
pipeline, today, next(chunks),
File "/home/ubuntu/venv-zipline/local/lib/python2.7/site-packages/zipline/algorithm.py", line 2546, in _run_pipeline
self.engine.run_pipeline(pipeline, start_session, end_session),
File "/home/ubuntu/venv-zipline/local/lib/python2.7/site-packages/zipline/pipeline/engine.py", line 311, in run_pipeline
initial_workspace,
File "/home/ubuntu/venv-zipline/local/lib/python2.7/site-packages/zipline/pipeline/engine.py", line 471, in compute_chunk
refcounts = graph.initial_refcounts(workspace)
File "/home/ubuntu/venv-zipline/local/lib/python2.7/site-packages/zipline/pipeline/graph.py", line 147, in initial_refcounts
refcounts[t] += 1
TypeError: 'OutDegreeView' object does not support item assignment
Here is how you can reproduce this issue on your machine:
Reproduction Steps

Run the momentum_pipeline.py example from the environment similar to mine

What steps have you taken to resolve this already?
It looks like the error comes from the file graph.py.  In the function initial_refcounts there is a line
'refcounts[t] += 1' , but the object doesn't support item assignment.
I have changed its type to dictionary:
before:
refcounts =   self.graph.out_degree()
after:
refcounts =  dict(self.graph.out_degree() )
After this I was able to run the algorithm.   I couldn't find that someone has the similar issue, which is strange cause I just followed the steps to install zipline and there shouldn't be something special in my environment
Sincerely,
Vitaly Ermilov

@VitalyErmilov the error message here is coming from networkx.  I notice in your pip freeze output that you have networkx 2.0 installed, but our tests are currently running against 1.9.1.  My guess is there are some breaking changes in the newest version of networkx.

Yup, looks like the behavior of out_degree changed in https://networkx.github.io/documentation/stable/release/release_2.0.html#api-changes.

@ssanderson you're right.  So we need either to make zipline installer to install networkx 1.9.1 by default, which is simpler, or to modify the pipeline code to reflect the changes in api.
Now this issue impacts zipline's core functionality in all new installations, cause the pipeline algorithms won't run due to the networkx api changes.


Option expected only string

Is there a possibility to treat Option as a container and place a 'View' or other element in it? It would be really helpful, for example if I want to add some counter of elements that the Select Option contains, like:
Select category:
- Comedy          [ 9 ]
- Thriller            [ 7 ]
- Sciene-fiction [ 3 ]

Hi,Sorry for late reply.
Try passing  is it breaking ? If it breaks I will publish a fix tomorrow.
Thanks

Yes, it breaks, because Text element

I am fixing it. Thanks


hammer.js is outdated though installed from runspired/hammer.js#develop

The docs say one should install hammer.js from the forked repo by using bower install --save runspired/hammer.js#develop.
However that repository contains some changes in the src files, but there seems to be no freshly built hammer.js file in there, see the comparison: https://github.com/hammerjs/hammer.js/compare/master...runspired:develop
So the file installed by bower won't contain any of those changes!

doh :'(
Hammer 2.0.5 lands sometime this week though :)  PR is in, waiting final release approval.

Addressed with release of Hammer 2.0.5 and ember-gestures 0.0.8


Implement Switching TV Inputs and Launching Apps.

I am creating this issue in favor of my previous issue, #12, since this request includes both apps and input switching since  the method used is similar.
I have found example code, albeit in nodejs, for either switching to an app or an input source.
Switching source/app: https://github.com/g30r93g/homebridge-panasonic/blob/master/index.js#L232
HTTP Captures and a method of getting the list of apps can be found in the, now closed, issue #12

After having a look through the library, it would seem that the library already contains support for launching apps; however it would be preferable that it can generate the app list itself from the TV.

Inputs can be switched via
rc.send_key("NRC_HDMI1-ONOFF")


GROUP_NONE constant not working

function currentLogin()
{
$leGroupNone = GROUP_NONE;
for some reason, GROUP_NONE assumed to be string "GROUP_NONE" not the constant GROUP_NONE that = 0

closed via 102bdeec062eb56b156342b8790da60dcd9433d7


[1.0.0] Update default timeout

Description

Changed timeout to 300000

Issues Resolved
[List any issues this PR will resolve]
Check List

[ ] New functionality includes testing.

[ ] All tests pass, including unit test, integration test and doctest

[ ] New functionality has been documented.

[ ] New functionality has javadoc added
[ ] New functionality has user manual doc added

[ ] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Codecov Report

Merging #494 (4807826) into aos-<IP_ADDRESS>-ga (a008aa7) will decrease coverage by 10.76%.
The diff coverage is n/a.

@@                  Coverage Diff                  @@
##             aos-<IP_ADDRESS>-ga     #494       +/-   ##
=====================================================
- Coverage             64.18%   53.42%   -10.77%
  Complexity              309      309
=====================================================
  Files                   102       69       -33
  Lines                  4420     2454     -1966
  Branches                666      277      -389
=====================================================
- Hits                   2837     1311     -1526
+ Misses                 1415      978      -437
+ Partials                168      165        -3

Flag
Coverage Δ

dashboards-reports
?

reports-scheduler
53.42% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...r/routes/utils/visual_report/visualReportHelper.ts

...main/__tests__/__utils__/main_utils_test_utils.tsx

...ashboards-reports/server/routes/utils/constants.ts

...report_definitions/delivery/delivery_constants.tsx

.../components/main/report_details/report_details.tsx

dashboards-reports/test/httpMockClient.js

...ublic/components/main/report_definitions_table.tsx

...ublic/components/report_definitions/utils/index.ts

...omponents/report_definitions/delivery/delivery.tsx

...shboards-reports/public/components/utils/utils.tsx

... and 23 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Remove delay from Transcode.ToAnimated

Brief Summary of Changes
Removed delay from Transcode.toAnimated
@const-cloudinary I think this is a breaking changes and requires a major version
What does this PR address?

[ ] GitHub issue (Add reference - #XX)
[ ] Refactoring
[ ] New feature
[x] Bug fix
[ ] Adds more tests

Are tests included?

[x] Yes
[ ] No

Reviewer, please note:
Checklist:

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[x] I ran the full test suite before pushing the changes and all the tests pass.

You can just mark it as deprecated, similar to PHP:
https://github.com/cloudinary/php-transformation-builder-sdk/blob/f6ad4fdfd7199a547ed0da3452119a5c100f471c/src/Transformation/Video/Transcode/ToAnimated/ToAnimatedActionTrait.php#L49


remove unnecessary points/completed items. Clarify eth-only descriptions

Fully contained in https://github.com/Valdorff/RPIPs/pull/12/files -- will be reviewing that PR instead


Latest release dropped the required=True on request body by default

I can set it back to True thanks to the new extra_body argument.
The default value is supposed to be False in case it is not provided according to OpenAPI specifications but the code is actually expecting it to be provided.
IMO it should be considered as required by default in the code, set to required by default in the generated OpenAPI. However setting it to None or False should allow body not to be provided (set to None then when received in the endpoint).

I agree very much!


Add CI step to generate documentation

With having the Workflow that pushes the latest master to bee-js-docs I would pronounce this issue as solved.


Add example for testing Rake tasks

Consider a rake subscriptions:confirmation_overdue:delete task that deletes unconfirmed subscriptions that have passed a confirmation deadline (e.g. created_at is > 3 days ago).

In progress in pull request #22


Add QOL features

I would really like to see some QOL features on this. I really think this is one of the best synctube-like apps out there. But it's missing some features that I feel would enhance the user experience, such as:

Ability to change the title of the media you add
Add and delete emotes on the fly (Like in cytube)
Ability to add subtitles to videos
I've already implemented some of these features on my fork. But I would really like these features to be on the main repository.
Please and thank you.

Thanks, i added media title input. About emotes, this requires more work, like edit mode with simple way to change, remove and reorder items, i think only add/remove alerts are not useful enough as gui. Maybe it can fits better as server and client chat /addEmote, /removeEmote commands. Also, as you are using heroku, i need to mention that not commited changes by client/server are removed every day, so such feature only useful for personal servers.
About subtitles, there is ass plugin that is too big/experimental to have out of box, but it can be polished for simpler installation and more features, depending on use cases.

Thanks, i added media title input. About emotes, this requires more work, like edit mode with simple way to change, remove and reorder items, i think only add/remove alerts are not useful enough as gui. Maybe it can fits better as server and client chat /addEmote, /removeEmote commands. Also, as you are using heroku, i need to mention that not commited changes by client/server are removed every day, so such feature only useful for personal servers.
About subtitles, there is ass plugin that is too big/experimental to have out of box, but it can be polished for simpler installation and more features, depending on use cases.

Thank you so much! Yea, I am aware of the Heroku thing, so I'm looking into different options. And as for the subtitles plugin, are you perhaps referring to octosubs? If so then I will try to look into it and see what I can do with it.

Thank you so much! Yea, I am aware of the Heroku thing, so I'm looking into different options. And as for the subtitles plugin, are you perhaps referring to octosubs? If so then I will try to look into it and see what I can do with it.

Yes, i mean the question is what you want from octosubs.

Yes, i mean the question is what you want from octosubs.

Yes, that would be great! Also, thank you for suggesting the /addEmote and /removeEmote commands, I'm working on implementing them on my server right now!

Yes, that would be great! Also, thank you for suggesting the /addEmote and /removeEmote commands, I'm working on implementing them on my server right now!


Improve error message on home directory mismatch

Refs #1884 - Augment error message displayed to the user when there's a mismatch between $HOME and the euid-obtained value for the home directory

AppVeyor had a couple tests failing, all with an error message of: An attempt was made to create more links on a file than the file system supports.
I don't think that's due to the changes here (I see the same error message in other PR builds), but let me know if that's something I need to look at on my end.

AppVeyor had a couple tests failing, all with an error message of: An attempt was made to create more links on a file than the file system supports.
I don't think that's due to the changes here (I see the same error message in other PR builds), but let me know if that's something I need to look at on my end.

Yeah, that's appveyor being a pain.  I'm looking at what it might take to switch to a different Windows provider for builds.  I'm going to chat to someone from Travis tomorrow.

thanks @kinnison! squashed accordingly.
so I know for future reference, is it that rustup uses different commit message standards or that contributors should squash all commits into one?

Travis failure seems unrelated, but again please let me know if there's anything needed on my end
info: downloading component 'rustfmt'
error: component download failed for rustfmt-x86_64-unknown-linux-gnu
info: caused by: could not download file from 'https://static.rust-lang.org/dist/2019-05-23/rustfmt-1.2.0-x86_64-unknown-linux-gnu.tar.xz' to '/home/travis/.rustup/downloads/c6a734a2721ec288f9e96d7e33f23fd1ed6f85effd4bcac28f020f7b2db247fb.partial'
info: caused by: failed to make network request
info: caused by: https://static.rust-lang.org/dist/2019-05-23/rustfmt-1.2.0-x86_64-unknown-linux-gnu.tar.xz: timed out
error: 'rustfmt' is not installed for the toolchain 'stable-x86_64-unknown-linux-gnu'

thanks @kinnison! squashed accordingly.
so I know for future reference, is it that rustup uses different commit message standards or that contributors should squash all commits into one?

It's more that I prefer the commits be actually useful for working out why a line is what it is.
i.e. the change should be attributed to the functional difference, not that you were making a cleanup in response to a code review :D

Travis failure seems unrelated, but again please let me know if there's anything needed on my end

I've retried the travis, it shouldn't be anything you did, looks like an internal timeout in Travis


This is a test but i dont know what im doing

@Ally-Lamb , please put some detail  :)

I thought i knew what i was doing, but turns out i dont hahaha


Fix header toggle functionality and clean up code

"Fix header toggle functionality": This indicates that I have corrected the logic for the header toggle behavior.
"and clean up code": This suggests that I have made improvements to the readability and conciseness of the code.

PLEASE READ #90

PLEASE READ #90


Update proxy sha

Update proxy sha, also update stats test config to make it pass.

Thanks @bianpengyuan!


Missing dependency debug in production mode.

Dependency debug is always used. Should be dependency not devDependency.
Edit:
Just noticed it could be just removed from src/utils/index.js, as it is never used that way anyway.
I've encountered this when oembed-parser was installed as a dependency of other package. When using pnpm which doesn't leak dependencies like npm does.

@kub1x thank you. Actually this library does not use debug anywhere. We should remove  debug from src/utils/index.js to avoid issue on the environment where there is no debug installed. Will be fixed now.


5.0: An opaque type from other modules isn't inferred correctly

Bug Report
🔎 Search Terms

unique symbol
type inference
opaque

🕗 Version & Regression Information

This changed between versions v4.9.5 and v5.0.2
The nightly build also has the bug

⏯ Playground Link
Playground (v5.0.2)
💻 Code
declare const tag: unique symbol;
type Tagged<Token> = {
  readonly [tag]?: Token;
};
export type Opaque<Type, Token = unknown> = Type & Tagged<Token>;
export type Query<_V, _R> = Opaque<string>;

const q: Query<{}, {}> = 'query {}'

The opaque type that I borrowed from:

https://younho9.dev/how-to-iterate-object-more-safely (Korean)
https://evertpot.com/opaque-ts-types/

🙁 Actual behavior
The type of q is annotated correctly, Query<{}, {}> while the declaration of Query is on the same file. However, when I moved it to another file, the q is inferred as Query<_V, _R>. It is not reproduced on v4.9.5.
🙂 Expected behavior
The type of q should be inferred as Query<{}, {}> wherever the declaration of Query is located.

This looks like just a tooltip issue? The declaration emit shows {}, {} as expected.

@RyanCavanaugh Could you try the following types?
type PickVariable<T> = T extends Query<infer V, infer _R> ? V : never;
type PickResponse<T> = T extends Query<infer _V, infer R> ? R : never;

const v: PickVariable<Query<{}, {}>>;
const r: PickResponse<Query<{}, {}>>;

The v and r is inferred as {} on 4.9 but unknown on 5.0.

Even in the same file the behavior is bad in the nightly.
declare const tag: unique symbol;
type Tagged<Token> = {
  readonly [tag]?: Token;
};
export type Opaque<Type, Token = unknown> = Type & Tagged<Token>;
export type Query<_V, _R> = Opaque<string>;

const q: Query<{}, {}> = 'query {}'
//    ^?
// 5.1.0-dev.20230331: const q: Query<_V, _R>
// 5.0.2: const q: Query<{}, {}>

The "same file" test case provided by @whzx5byb can be bisected to: https://github.com/microsoft/TypeScript/pull/53246


Converting to monorepo

It would be useful to convert the eyre, color-eyre, stable-eyre et.al. It would improve the discoverability of the different subcrates, as well as provide a single place where issues can be reported.
The current separate repositories makes it difficult for users to know where to report the errors as it may not initially be obvious if the source is in Eyre or an eyre hook implementer. It is a case of the classic "where should it go"
Merging them will improve the ease of issue creation and discovery, as well as overview.
The proposed structure will also improve ease of integration testing and examples and side-by-side development between the crates.

Furthermore, it would provide a common CI between the crates, which ensures that each of the subcrates, such as color-eyre also gets tested and a single PR can test regressions on both the core eyre as well as our crates that use eyre at the same time.


Expand examples based on customer feedback

CrossRef: https://github.com/wildfly-extras/wildfly-camel/issues/1386

Waiting on @sundarmr whether he want to transform these such that they are actually using the wildfly-camel integration

Hi Thomas
Yes I want to transform the code examples to use wildly-camel
Regards
Sundar M R
On Fri, Nov 25, 2016 at 5:54 AM Thomas Diesler<EMAIL_ADDRESS>wrote:

Waiting on @sundarmr https://github.com/sundarmr whether he want to
transform these such that they are actually using the wildfly-camel
integration
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/wildfly-extras/wildfly-camel-examples/issues/7#issuecomment-262931570,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AGz6NuByZZQZc-gEZlOU8_WeswFt2GvQks5rBr5bgaJpZM4K8QaR
.

Ok, look forward to seeing the first cut

Any news on this? I think pulling in some of the Spring examples would be useful as we often get questions around developing WildFly-Camel apps with Spring, and we have no examples other than test cases.

This has moved back to: wildfly-extras/wildfly-camel#1386


sip: add tests for headers sticky buffers v4

Ticket #6374
Ticket
If your pull request is related to a Suricata ticket, please provide
the full URL to the ticket here so this pull request can monitor
changes to the ticket status:
Redmine ticket:
https://redmine.openinfosecfoundation.org/issues/6374

Merged in #2053, thanks!


Few base images updates

This PR contains the following changes:

Update QEMU to v5.2.0+balena4
Add Go v1.16 and v1.15.8
Add dotnet v5.0.3 and v3.1.12
Add node v15.10.0 v14.16.0 v12.21.0 and v10.14.0

@balena-ci I self-certify!


Update Adam in optimizer.py

Added bias correction to first and second moment estimate in the Adam optimizer.

Thanks for the PR!
Please explain in more detail what you are trying to do here.

Thanks for your review
The first moment (mean) and the second moment (variance) of the gradients have been initialized as a vector of zeros.
I had read from the paper https://arxiv.org/pdf/1412.6980v8.pdf that doing so would make the moment estimates biased towards zero. To counteract it, a bias correction term is added to both mean and variance which can then be used to update the parameters.

Thanks for your review
The first moment (mean) and the second moment (variance) have been initialized as a vector of zeros. According to the paper [] (https://arxiv.org/pdf/1412.6980.pdf), doing so would lead the moment estimates to be biased towards zero. To counteract it, a bias correction term is added which can then be used to update the parameters.


error: 'fd_set' undeclared (first use in this function)

Hi Everyone,
I working from nsd master on OpenBSD 6.6. Bootstrap and configure go well, but compile has a hiccup:
$ make -k
...
gcc  -I. -fasynchronous-unwind-tables -fexceptions -fstack-protector-strong -Wer
ror=implicit-function-declaration -fdata-sections -ffunction-sections -fPIC  -Wa
,--noexecstack -g -O2 -c ./popen3.c
./popen3.c: In function 'popen3':
./popen3.c:106: error: 'fd_set' undeclared (first use in this function)
./popen3.c:106: error: (Each undeclared identifier is reported only once
./popen3.c:106: error: for each function it appears in.)
./popen3.c:106: error: expected ';' before 'rfds'
./popen3.c:111: warning: implicit declaration of function 'FD_ZERO'
./popen3.c:111: error: 'rfds' undeclared (first use in this function)
./popen3.c:112: warning: implicit declaration of function 'FD_SET'
./popen3.c:113: warning: implicit declaration of function 'select'

I believe this is the OpenBSD doc of interest: select(2) - OpenBSD manual pages. It looks like OpenBSD puts the declaration in <sys/select.h>.
Another man page of interest is the Linux man page. Linux and libc put the declarations in either <sys/types.h> or <sys/select.h>.
Related, the source file also uses ssize_t. I believe that is defined in <sys/types.h>.

Looks like that file was missing a bunch of other system includes.  Those are fixed in the commit.  I think that may solve the problem, since other code also uses fd_set and compiles, with those includes.  If not, let me know, and I'll start testing and including sys/select.h, also for the other cases.  Also ssize_t and other declarations should be covered by these extra includes.
Thanks for the test and report!


TagBot trigger issue

This issue is used to trigger TagBot; feel free to unsubscribe.
If you haven't already, you should update your TagBot.yml to include issue comment triggers.
Please see this post on Discourse for instructions and more details.
If you'd like for me to do this for you, comment TagBot fix on this issue.
I'll open a PR within a few hours, please be patient!

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/51241

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/52306

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/52349

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/52481

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/58276


Added Subset Sum Using DP

Have you read the Contributing Guidelines on Pull Requests?
(Write your answer here.)
yes
Description
(Write your answer here.)
This problem is solved using dp.
In this problem we have to check whether the values of subset of array is equal to sum or not.
if equal then we will return true else we will return false.
Input -
5 11
2 3 7 8 10
Output -
Yes
Checklist

[x] I've read the contribution guidelines.
[x] I've checked the issue list before deciding what to submit.
[x] I've edited the README.md and link to my code.

Related Issues or Pull Requests
(Write your answer here.)
#5021

Please make an issue here and raise a PR, for an article as part of our Docs repository: https://github.com/TesseractCoding/NeoAlgo-Docs
It would be much appreciated. Thanks!


using thread safe timeout to allow code execution to be compatible wi…

…th multi-threading/multi-processing
Right now if you try to run a chat in a different thread/process you get an error that signal must be in the main thread this is because of the use of the signal library in the code_utils.py module using signal.signal to set a timeout.
to mitigate this issue I am using the thread safe future.result(timeout) which sets the timeout and allows for code execution to take place in a different thread/process

@microsoft-github-policy-service agree [company="{your company}"]

@microsoft-github-policy-service agree

@afourney not sure what i need to do to add a reviewer here??

Codecov Report

Merging #224 (2e30bf3) into main (1394e29) will decrease coverage by 0.08%.
The diff coverage is 88.88%.

@@            Coverage Diff             @@
##             main     #224      +/-   ##
==========================================
- Coverage   43.31%   43.24%   -0.08%
==========================================
  Files          17       17
  Lines        2133     2132       -1
  Branches      481      482       +1
==========================================
- Hits          924      922       -2
- Misses       1126     1127       +1
  Partials       83       83

Flag
Coverage Δ

unittests
43.15% <88.88%> (-0.08%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Files
Coverage Δ

autogen/code_utils.py
48.48% <88.88%> (-0.66%)
:arrow_down:


Set :fire: to everything related to overviews

Context: [PROJECT] Deprecate raster overviews
Note: Don't merge into master until authorized.
Don't create new overviews tables when importing large datasets.

PR: #14304

I just realized, we probably want to get rid of extension stuff as well for a fully executed fatality.

I have mixed feeling about that. My first thought was about to get rid of the extension's functions, then I realized that those functions might be helpful in some scenarios. Furthermore, thinking about cartodb-extension as a piece of software it might have the sense to expose some functionality that we stopped of using it, I don't know if there are people using the extension directly.
In any case, I don't have a strong opinion about that. I'm totally open to another point of view.


v0.57.0 doesn't allow me to extend my zones below the limit of the full-sized W10 taskbar.

Microsoft PowerToys version
v0.57.0
Running as admin

[X] Yes

Area(s) with issue?
FancyZones
Steps to reproduce
Set the taskbar size to 'small' and create zones that extend close to it. It won't work properly.
✔ Expected Behavior
As with the previous versions, it should be possible to extend the zones as close to the small-sized taskbar as possible (I manually adjusted the windows to represent the desired layout in the screenshot).

❌ Actual Behavior
Although the zone editor shows the zones going all the way down, in practice there is a big gap, which corresponds to the limit the zones would have in case the full-sized taskbar were active - or maybe W11 taskbar? (notice the difference between the window position an the zone limit).

Also notice how the zone preview shows the actual layout, which respects the would-be boundaries of the full-sized taskbar (or W11 taskbar?).

Actually, on further analysis, the whole resolution of the preview is wrong.
Other Software
No response

/bugreport

Hey! Here it goes. I was looking for this feature but couldn't find it.

Hey! Here it goes. I looked for this feature but couldn't find it.
PowerToysReport_2022-04-03-14-32-10.zip

Thank you for the report. It looks like there was a problem with the canvas layout creation on some of the previous versions. Recreation the layout from scratch solves this problem. Please let me know if it doesn't help you. Thanks! /dup of #17382

Hey! I forgot to report back here. That actually solved it. Thank you.


Restrict Gemfile conditional gems scope

The Gemfile conditionally adds dependecies basing on env vars
presence, allowing CI to setup the testing environment with different
dependencies. But such env vars could conflict with user env vars,
leading to redundant dependencies added to the users’ projects.
This commit restricts the env vars checks adding the CI env var
presence check. CI env var is a standard de facto for representing
continuous integration environments, and its presence checking should
reasonably ensure that we are in a CI context.

How do you set them locally? Can't we just change their name?

@kennyadsl I don't have those env vars set; actually I opened this PR because I thought you was concerned by env vars in the Gemfile: what were your concerns about?

I was not concerned about the env var itself, I was concerned that if you don't set those the project won't work. I was more for having a default that can be easily changed with an ENV var, that was my point.

@kennyadsl oh ok, so I think we can safely close this PR, since now there's a generator for that :+1:


tsc returns base class instead of "this" class

TypeScript Version:  2.2.1
You can test the issue with this: https://github.com/sevensc/linqscript
This is my class:
    export class List<T> extends Array<T> {}

When compiling with latest typescript version on Mac "tsc source.ts", the source.js function looks like this:
function List() {
            return _super !== null && _super.apply(this, arguments) || this;
        }

which returns a new instance of an "Array", instead of an instance of a "List"
Actual behavior:
var list = new List<string>() // -> list = []

Anyhow, when i change the function to:
function List() {
            _super !== null && _super.apply(this, arguments) || this;
        }

or
function List() {
           return this;
        }

everything works just fine.
Expected behavior:
var list = new List<string>() // -> list = List {}

https://github.com/Microsoft/TypeScript/wiki/FAQ#why-doesnt-extending-built-ins-like-error-array-and-map-work

@RyanCavanaugh Thanks for the quick answer.  Since i created this repo with an older version of typescript and this is in productive usage, is there any way to fix this, except for the not IE working
Object.setPrototypeOf(this, FooError.prototype); ?

I just saw that im having the same trouble, extending from  Date

One thing you could do is rewrite as an ES5-style class and set up the prototype chain between the two manually.

Hi @DanielRosenwasser! Thanks you for your response! This i my "workaround":

export class List<T> extends Array<T> {
public _array: Array<T>;
public Where(delegate: (value: T) => boolean, args?: any): List<T> {
  try {
     const list = new Array<T>();
     if (!this.validDelegate(delegate))
         return list.ToList();

     for (let i = 0; i < this._array.length; i++) { //replaced 'this' with property 'this._array'
           const c = this._array[i]; //replaced 'this' with property 'this._array'
           if (c === null)
               continue;

           if (delegate.call(args, c))
               list.push(c);
           }

           return list.ToList();
  }
  catch (ex) {
     this._array = null;
     return new List<T>();
  }
}
...

Interface
interface Array<T> {
    Where(delegate, args?);
}

prototype
Array.prototype.Where = function(delegate, args){
    ls.List.prototype._array = this; //set public variable on class List
    var returnValue = ls.List.prototype.Where(delegate, args);
    ls.List.prototype._array = null; //and reset
    return returnValue;
}


Also allow the classic banner to page appear in conjunction with the -AddPageAcceptBanner  option

Closing this one in favor of documenting the approach. See #198 for the new documentation task


Error when using async functions: "ReferenceError: async is not defined"

🐛 Bug Report
Jest throws an ReferenceError: async is not defined error when the async keyword is used and there is a comment in the function args list.
To Reproduce
Define the following function in any file tested by Jest:
const foo = async (/** any text  */ name) => name;

and run Jest.
I came across this bug using Typescript JSDoc annotations in JS files (ex: /** @type {string} */). This is just the use case I have for being able to put /** ... */ style comments inline in async functions.
But still, it is valid Javascript and there is no reason Jest should throw an error when it encounters it.
Expected behavior
The test should execute correctly and not
Link to repl or repo (highly encouraged)
https://repl.it/@david_arteaga/jest-async-bug
envinfo
System:
  OS: macOS 10.15.7
  CPU: (8) x64 Intel(R) Core(TM) i7-6920HQ CPU @ 2.90GHz
Binaries:
  Node: 12.16.2 - ~/.nvm/versions/node/v12.16.2/bin/node
  Yarn: 1.22.4 - ~/.yarn/bin/yarn
  npm: 6.14.4 - ~/.nvm/versions/node/v12.16.2/bin/npm
npmPackages:
  jest: ^26.6.3 => 26.6.3

I'm still having this error 2 years later.

Can not reproduce this. Tried Jest 26 and higher versions.