Add pyproject.toml for Custom Node Registry

We are working with dr.lt.data and comfyanon to build a global registry for custom nodes (similar to PyPI). Eventually, the registry will be used as a backend for the UI-manager. All nodes go through a verification process before being published to users.
The main benefits are that authors can

publish nodes by version and users can safely update nodes knowing ahead of time if their workflows will break or not
automate testing against new commits in the comfy repo and existing workflows through our CI/CD dashboard

Action Required:

[ ] Go to the registry. Login and create a publisher id. Add the publisher id into the pyproject.toml file.
[ ] Write a short description.
[ ] Merge the separate Github Actions PR and run the workflow.

If you want to publish the node manually, install the cli and run comfy node publish
Check out our docs if you want to know more about the registry. Otherwise, feel free to message me on discord at haohao_81202 or join our server if you have any questions!

hey @rcsaquino, wanted to send a small nudge and ask if you had any questions!

@rcsaquino, wondering if there's any way we can support you on this PR!


OCPBUGS-8329: update sysconfwatch-controller logging

There is no need to log the gateway IP address every time we look it
up, so only log it when it changes. This is somewhat redundant to the
logic in the controller itself, but the IP returned from GetHostIP()
is not always the gateway IP and GetHostIP() may have other callers.
This change also rewords another log message related to how the host
IP is being selected to make it clear what effect the failure to find
a default route has on the outcome.

/jira refresh

/retest-required

/lgtm

/cherry-pick release-4.13


issue

Hi when i use ur ttrs hack i get kicked out and sent to home screen

Try refreshing the page or restarting your browser. What browser are you using?


Adding information about how Amazon AWS uses PowerShell.

PR Summary
Adding information about how Amazon AWS uses PowerSHell
PR Context
PR Checklist

[x ] PR has a meaningful title

Use the present tense and imperative mood when describing your changes

[ x] Summarized changes
[ x] Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
[ x] This PR is ready to merge and is not Work in Progress.

If the PR is work in progress, please add the prefix WIP: or [ WIP ] to the beginning of the title (the WIP bot will keep its status check at Pending while the prefix is present) and remove the prefix when the PR is ready.

Breaking changes

[x ] None
OR
[ ] Experimental feature(s) needed

[ ] Experimental feature name(s):

User-facing changes

[ x] Not Applicable
OR
[ ] Documentation needed

[ ] Issue filed:

Testing - New and feature

[ ] N/A or can only be tested interactively
OR
[ ] Make sure you've added a new test if existing tests do not effectively test the code changed

Tooling

[ ] I have considered the user experience from a tooling perspective and don't believe tooling will be impacted.
OR
[ ] I have considered the user experience from a tooling perspective and enumerated concerns in the summary. This may include:

Impact on PowerShell Editor Services which is used in the PowerShell extension for VSCode (which runs in a different PS Host).
Impact on Completions (both in the console and in editors) - one of PowerShell's most powerful features.
Impact on PSScriptAnalyzer (which provides linting & formatting in the editor extensions).
Impact on EditorSyntax (which provides syntax highlighting with in VSCode, GitHub, and many other editors).

@PoshChan Please remind me in 24 hours

@TravisEz13, this is the reminder you requested 24 hours ago

rebased the branch to try to address test issues

@PoshChan Please remind me in 1 day

@TravisEz13, this is the reminder you requested 1 day ago

@PoshChan Please remind me in 1 hour

@TravisEz13, this is the reminder you requested 1 hour ago


How does one build this?

What are assembly_guiutils_publicized, assembly_utils_publicized, assembly_valheim_publicized?
Which versions of BepInEx / Harmony to build against?
Do Unity dependencies come from the game client or game server?
Any building instructions at all?
Many thanks!

https://valheim-modding.github.io/Jotunn/guides/guide.html#manual-setup explains how to get publicized assemblies.
https://valheim-modding.github.io/Jotunn/guides/guide.html#bepinex-and-unstripped-unity-dlls how to get Unity and Harmony dlls.

@JereKuusela thanks, the links do not work as they are supposed to, but easy enough to find the right pages on the site.


Make Debug impls optional

When disabled, this buys us a ~12% reduction in buildtime in my environment
I'd like some discussion on whether it should be enabled by default. It's less breaking that way, but I dunno how often people are going to scan the feature list for opportunities to improve buildtime.

Since nobody seems to feel strongly, I've updated this to disable the feature by default.

I'm tracking the windows-rs repository, and users seem rather disgruntled by the removal of Debug. Not sure if they'd be as unhappy if there was a debug feature, even id disabled by default.

I don't have enough experience with winapi to judge how the usage patterns might vary. I'd rather have this in but enabled by default than not in at all, if that's your preference? I'll ask around and see if anyone I know would be impacted; hard to predict in general.

windows-rs, the replacement for winapi - gauging the few replies and thumbs up here, and the Rust API guidelines suggesting to implement it for public types: https://rust-lang.github.io/api-guidelines/debuggability.html#all-public-types-implement-debug-c-debug it seems better to leave it on by default? I'm still fine with having it as feature of course.
OTOH I'm not sure how useful our limited debugging implementation is: we don't even (and for good reason) dereference and follow pointers. Still, at least being able to see pointer values and everything else that's not a pointer already goes a long way. Still on the fence about default-enabling or disabling it...

I think our current Debug impls are trivially useful for output structures, and potentially useful for input structures that might get handled by intermediate layers of abstractions in user code. Sure, a lot of stuff needs pointer context for completeness, but lots of stuff doesn't as well; e.g. being able to quickly and easily inspect memory barriers seems convenient.
Given the uncertainty, I think it's better for us to merge this with the feature enabled by default than agonize over it, so I've turned it back on. We can always disable in the future.

@Ralith On my machine I can win another 400-500ms (7.9s down to 7.4s) by removing const_debugs: https://github.com/Ralith/ash/compare/optional-debug...MaikKlein:optional-debug
We may want to preserve just the debug for Result though?

I preserved Result (for unwrap()) and ObjectType (for debug messenger purposes).


Update ERC Standards Blog Posts

📖 Description
Enhanced the blog by including interactive visuals, detailed use cases for ERC tokens, and a new ERC-777 Standard.

Fixed Issue #123

🛫 Checklist

[x] The Post and any related files have been added to the appropriate folder.
[x] Grammatical errors are thoroughly checked for in the source files.
[x] For clearer understanding, I've added examples and pictures.

Great @Envoy-VC .This looks clean and understandable .


add an accessibility doc

I went looking around for iced's accessibility support, and found some relevant discussions in #282 and #552. It would be useful to write those discussions up in an ACCESSIBILITY.md doc, both to answer the question and to keep it alive in contributors' minds.

I think it's a good idea. PRs welcome! We should mention the feature in the ROADMAP too.


remove double "backspace" press

Describe the bug
So it is not an actual bug, but when I press backspace once on filled input it removes the value but doesn't go to the previous cell.
To Reproduce
Steps to reproduce the behavior:

Go to https://ngx-otp-input.vercel.app/
Click in the first cell and start typing
remove last cell value
See that focus still in same (empty cell)

Expected behavior
So in my logic and best practices is next - When I deleted the value of the cell, it should focus on the previous cell, and if I type a new value should be checked if the cell does not empty populate new value to the next empty cell otherwise fill new value in current
Desktop (please complete the following information):

Browser chrome
Version 95

Smartphone iPhone iOS 15:

Browser safari

Additional context
Add any other context about the problem here.

Hi @ddtch!
Why should it focus on the previous cell? The current behaviour is nearly identical to your description. Because if your previous cell has a value, the input would jump forward anyway, right? If I misunderstood your request, let's discuss it! :)

It should BCS in case I want to delete 4 symbols I will press backspace 8 times. this is weird UX.
But if I delete the last value and go to previous cell, and will type something under the hood should be checked like 'if current cell has value -> populate value in next empty cell'
Just try to do this in any bank apps or so where we have classic otp inputs

I could add a new option for the desired behaviour. The current one remains the default.

I published a new version of the lib, see the commit here: https://github.com/pkovzz/ngx-otp-input/commit/8cec872bbb7171fdacd0fdf29f42960c7212d02f
In the end, I created a hybrid solution. By default, the deletion will work as we discussed, but add new values remains the same as was. So as I mentioned, this new approach is the default behaviour now, but I also added a new optional property called behavior, which can toggle between the old and new behaviours.


Bloodstained: Curse of the Moon [PCSE01262]

App summary

App name: Bloodstained: Curse of the Moon
App serial: PCSE01262
App version: 1.01

Vita3K summary

Version: v0.2.0
Build number: 3713
Commit hash: https://github.com/vita3k/vita3k/commit/880365af
CPU backend: Dynarmic
GPU backend: Vulkan

Test environment summary

Tested by: RetroGameTalk
OS: Microsoft Windows 10 Professional (build 19045)
CPU: 11th Gen Intel(R) Core(TM) i7-11700KF @ 3.60GHz | 16 Threads | 3.6 GHz
GPU: NVIDIA GeForce RTX 3070
RAM: 48 GB

Issues

None
Screenshots

Log

vita3k.log
Recommended labels

Playable

love this bot. ^^


GPU out of memory

Hi,
i run cellpose on a cluster with A100 gpu. I update to the last version. I run the command :
python -m cellpose --dir ${images_dir} --pretrained_model cyto --chan 0 --no_npy --save_txt --diameter 80 --use_gpu
I get the following error :
2022-05-31 19:38:35,098 [INFO] ** TORCH CUDA version installed and working. **
2022-05-31 19:38:35,099 [INFO] >>>> using GPU
2022-05-31 19:38:35,106 [INFO] >>>> running cellpose on 18 images using chan_to_seg GRAY and chan (opt) NONE
2022-05-31 19:38:35,106 [INFO] ** TORCH CUDA version installed and working. **
2022-05-31 19:38:35,106 [INFO] >>>> using GPU
2022-05-31 19:38:35,106 [INFO] >> cyto << model set to be used
2022-05-31 19:38:35,216 [INFO] >>>> model diam_mean =  30.000 (ROIs rescaled to this size during training)
2022-05-31 19:38:35,218 [INFO] >>>> using diameter 80.000 for all images
2022-05-31 19:38:35,223 [INFO] 0%|          | 0/18 [00:00<?, ?it/s]
2022-05-31 19:38:35,297 [INFO] ~~~ FINDING MASKS ~~~
2022-05-31 19:39:50,145 [INFO] 0%|          | 0/18 [01:14<?, ?it/s]
Traceback (most recent call last):
File "/shared/space2/laporte/labo6_laporte1/Quentin_C/conda/conda_envs/cellpose_2.0/lib/python3.8/runpy.py", line 194, in _run_module_as_main
return _run_code(code, main_globals, None,
File "/shared/space2/laporte/labo6_laporte1/Quentin_C/conda/conda_envs/cellpose_2.0/lib/python3.8/runpy.py", line 87, in _run_code
exec(code, run_globals)
File "/shared/space2/laporte/labo6_laporte1/Quentin_C/conda/conda_envs/cellpose_2.0/lib/python3.8/site-packages/cellpose/main.py", line 348, in
main()
File "/shared/space2/laporte/labo6_laporte1/Quentin_C/conda/conda_envs/cellpose_2.0/lib/python3.8/site-packages/cellpose/main.py", line 232, in main
out = model.eval(image, channels=channels, diameter=diameter,
File "/shared/space2/laporte/labo6_laporte1/Quentin_C/conda/conda_envs/cellpose_2.0/lib/python3.8/site-packages/cellpose/models.py", line 238, in eval
masks, flows, styles = self.cp.eval(x,
File "/shared/space2/laporte/labo6_laporte1/Quentin_C/conda/conda_envs/cellpose_2.0/lib/python3.8/site-packages/cellpose/models.py", line 551, in eval
masks, styles, dP, cellprob, p = self._run_cp(x,
File "/shared/space2/laporte/labo6_laporte1/Quentin_C/conda/conda_envs/cellpose_2.0/lib/python3.8/site-packages/cellpose/models.py", line 651, in _run_cp
outputs = dynamics.compute_masks(dP[:,i], cellprob[i], niter=niter, cellprob_threshold=cellprob_threshold,
File "/shared/space2/laporte/labo6_laporte1/Quentin_C/conda/conda_envs/cellpose_2.0/lib/python3.8/site-packages/cellpose/dynamics.py", line 726, in compute_masks
mask = remove_bad_flow_masks(mask, dP, threshold=flow_threshold, use_gpu=use_gpu, device=device)
File "/shared/space2/laporte/labo6_laporte1/Quentin_C/conda/conda_envs/cellpose_2.0/lib/python3.8/site-packages/cellpose/dynamics.py", line 581, in remove_bad_flow_masks
merrors, _ = metrics.flow_error(masks, flows, use_gpu, device)
File "/shared/space2/laporte/labo6_laporte1/Quentin_C/conda/conda_envs/cellpose_2.0/lib/python3.8/site-packages/cellpose/metrics.py", line 282, in flow_error
dP_masks = dynamics.masks_to_flows(maski, use_gpu=use_gpu, device=device)
File "/shared/space2/laporte/labo6_laporte1/Quentin_C/conda/conda_envs/cellpose_2.0/lib/python3.8/site-packages/cellpose/dynamics.py", line 278, in masks_to_flows
mu, mu_c = masks_to_flows_device(masks, device=device)
File "/shared/space2/laporte/labo6_laporte1/Quentin_C/conda/conda_envs/cellpose_2.0/lib/python3.8/site-packages/cellpose/dynamics.py", line 153, in masks_to_flows_gpu
mu = _extend_centers_gpu(neighbors, centers, isneighbor, Ly, Lx,
File "/shared/space2/laporte/labo6_laporte1/Quentin_C/conda/conda_envs/cellpose_2.0/lib/python3.8/site-packages/cellpose/dynamics.py", line 70, in _extend_centers_gpu
pt = torch.from_numpy(neighbors).to(device)
RuntimeError: CUDA out of memory. Tried to allocate 13.66 GiB (GPU 0; 19.62 GiB total capacity; 25.27 MiB already allocated; 12.90 GiB free; 28.00 MiB reserved in total by PyTorch) If reserved memory is >> allocated memory try setting max_split_size_mb to avoid fragmentation.  See documentation for Memory Management and PYTORCH_CUDA_ALLOC_CONF
Any idea to solve the issue ? My images are tiff between 112Mo and 884Mo

it seems like you might have been running something else on the GPU if it can't use the full GPU? but regardless you can decrease the batch size with for example --batch_size 2

I try to use the option --batch_size 2 but i get the same error. Nothing else run on the gpu so i don't understand and i don't know how to fix it.

I try to use the option --batch_size 2 but i get the same error. Nothing else run on the gpu so i don't understand and i don't know how to fix it.

Hi did you figure out the issue? I got the same error with the largest GPU on the server but still met the error.

I try to use the option --batch_size 2 but i get the same error. Nothing else run on the gpu so i don't understand and i don't know how to fix it.

Hi did you figure out the issue? I got the same error with the largest GPU on the server but still met the error.

No. I went back to the cpu version even though it takes much longer.

I try to use the option --batch_size 2 but i get the same error. Nothing else run on the gpu so i don't understand and i don't know how to fix it.

Hi did you figure out the issue? I got the same error with the largest GPU on the server but still met the error.

No. I went back to the cpu version even though it takes much longer.

Jesus. Thanks for the information! Will try GPU for the last time with batch size = 2, otherwise will go with CPU!
By the way for CPU version, is it just delete --use_gpu in my command?

Hey same issue.
I'm trying to use python to segment a whole slide image. It's an ome.tif file of 20 megabytes (compressed), 450 megabytes uncompressed,  something like 10.000x15.000 pixels.
I tried for several hours to troubleshot the issue but I just don't understand where it comes from.
I'm running a simple:
def run_cellpose(image, model_cellpose, diameter=None):
    channel = [[0, 0]]
    mask_cellpose, _, _, _ = model_cellpose.eval(
        image, diameter=diameter, channels=channel
    )
    return mask_cellpose

And I'm getting an error after a few minutes
RuntimeError: CUDA out of memory. Tried to allocate 3.03 GiB (GPU 0; 10.76 GiB total
capacity; 7.61 GiB already allocated; 1.90 GiB free; 7.61 GiB reserved in total by
PyTorch) If reserved memory is >> allocated memory try setting max_split_size_mb to
avoid fragmentation.  See documentation for Memory Management and
PYTORCH_CUDA_ALLOC_CONF

I think that if you are running in a notebook, pytorch may be holding onto memory? but I would try --batch_size 2

Same issue on a 2D grayscale image with the size of (37678, 66107)
RuntimeError: CUDA out of memory. Tried to allocate 5.53 GiB (GPU 0; 31.75 GiB total capacity; 29.84 GiB already allocated; 882.50 MiB free; 29.86 GiB reserved in total by PyTorch) If reserved memory is >> allocated memory try setting max_split_size_mb to avoid fragmentation.  See documentation for Memory Management and PYTORCH_CUDA_ALLOC_CONF
This was done on a computing node with 320GB system memory and one 32GB VRAM v100x GPU. Given the fact that cellpose does tiling under the hood, this error doesn't make much sense to me. Smaller images such as 20,000 by 20,000 can be processed without issue.

Just want to follow up and see if anyone has solved this issue.

Tried downgrading from cellpose 2.1.1 to 2.0.5 as I have a friend that use it sucessfully, still the same error.

this is the QC step that's failing (where cellpose throws out masks which don't have flows that are similar to the model's predicted flows), you can turn it off by setting flow_threshold=0.
alternatively, I am setting a check for this that estimates the amount of memory remaining on the GPU to decide whether or not to run the step on the GPU, try it out with pip install git+https://github.com/mouseland/cellpose.git


Fix Blynk and Netpie cloud platform support

Blynk and Netpie cloud platform support have been broken since we migrate to the new device library. This must be fixed before we can release v0.5.0.

We are now done with Blynk virtual devices. Netpie is coming soon.

Done


Aspire: Support kafka.server.v0

https://github.com/dotnet/aspire/pull/951 added support for Kafka. We should support this in azd.
https://learn.microsoft.com/en-us/azure/container-apps/tutorial-dev-services-kafka?tabs=bash

We will not add hand-crafted, template-based Bicep deployment support in azd. Instead, we will be moving towards using bicep resource type and CDK effort.

https://github.com/dotnet/aspire/issues/1941
https://github.com/Azure/azure-dev/issues/3279


PDF on the library website is displaying the wrong images

A reader has written in to point out an issue with the PDFs on this book: https://wellcomelibrary.org/item/b29334123
If you download (say) volume 3, you get the images from volume 4 (see title page: “Volume IV”).
I flagged this to Tom Crane, who pointed me at http://wt-havana:85/Dash/Manifestation/b29334123_0001. If we click “Delete PDF”, that will delete the cached PDF, and it'll be rebuilt the next time somebody requests it. Unfortunately, clicking that button throws a 400 Bad Request error and a stack trace. Tom is going to investigate what's going on in the dashboard.

[x] Fix the borken PDFs
[x] Let reader know they can download the PDFs they want
[ ] Document the process of clearing the PDF cache, so we know how to resolve this in future without having to ask Tom

v1 PDF downloads fine in UV
v2 PDF downloads fine in UV
v3 PDF downloads in UV but it's v4
v4 PDF downloads in UV but it's v5
v5 cannot download PDF in UV (but can download it by selecting v4)
v6 cannot download PDF in UV
v7 cannot download PDF in UV
v8 cannot download PDF in UV
So you can download PDFs of vols 1, 2, 4, 5.
You cannot download PDFs of vols 3, 6, 7, 8

Happened to need to delete a PDF (a rare thing) today so I took some screenshots.
b30303989 was ingested from IA and IA gave us corrupted images. All images were blank gray. I re-ingested them after IA fixed them. Downloading the PDF after I harvested the new items, the PDF still showed the gray images.
This items's PDF had been requested by a reader on the 3rd of Feb so it showed that date.

I clicked the Deleted PDF button and when the page refreshed, the PDF was waiting to be remade:

I clicked Make PDF and it created it with today's timestamp:

And then I went to https://wellcomelibrary.org/item/b30303989?ts=637165741321373533 and downloaded the PDF option and the PDF was showing the correct page images.
So I can confirm the Delete PDF button bug is resolved. And I hope these screenshots help tick off the last box of this ticket!


Update sidebar to better expose latest prod and testing releases

Create prod and testing sections.
Expose latest release under each. Last 3 for prod. Only one
for testing.
Add intro to all prod patch release notes linking users
to GA release notes for full feature summaries and upgrade
instructions. With this, we can remove GA release notes
from sidenav.

Fixes #7547.
Fixes #7506.

This change is

Online preview: http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/e7736eb257130099e15776eee4a16a6df2c76e1b/

LGTM!


Make GitOid generic over the underlying hash output size.

This commit redesigns the implementation of the GitOid type,
changing the underlying buffer from one designed to fit the largest
possible hash algorithm supported by the crate regardless of the
actual hash algorithm used in a specific case, to one that is sized
to have exactly the space needed for the selected hash algorithm.
This involves a little bit more complexity than I'd like, because Rust's
const-generics support is still incomplete and thus this crate
relies on the generic_array crate to provide what we need. In the
future we'd replace this with normal const-generic arrays which
would (hopefully) also simplify the bounds on the generic types.
This commit does not complete the work for this transition, as it
does not address fixing the FFI story. The FFI module is commented
out, and will need to be updated before this can be merged.
This commit does remove the finder API. After consideration,
I think the current API for finding matching GitOids is both too
complicated in terms of trait bounds AND under-powered in terms
of controlling matching behavior. It may not even make sense to
proscribe how matching can be performed on a scale beyond
"check object against GitOid" given the complexities of performance
tuning which are possible.
A fun note on sizing, in the prior code the size of a GitOid was fairly
large, as the GitOid type had to store two 4 byte enums (HashAlgorithm
and ObjectType) plus a "usize" (usually 4 bytes), and a 32-byte buffer.
So it would generally be 52 bytes.
In the new code, for SHA-256, GitOids are 33 bytes (1 byte for the
ObjectType, and 32 bytes for the buffer), and for SHA-1 GitOids are
21 bytes (1 byte for the ObjectType, 20 bytes for the buffer). Given that
we expect code using GitOids in OmniBOR to be using large numbers of
them, this size saving is great news!
Fixes #82.

If we ignore the deletion of the finder API (which adds lots of deleted lines but isn't central to the core API change here), this draft PR currently results in a diff size of +204/-251, so a net change of -47 lines of code!

This change should also include a re-export of the Sha1 and Sha256 types so users don’t have to deal with importing those crates themselves and matching our own versions of them.

For future space savings we might want to explore a GitOidSet type which doesn’t repeat the object type.

Haha just realized I can use similar compile-time techniques to eliminate storage of the object type.

Spelling out the last comment more, I would basically convert the current enum into another sealed trait to encode the object type information at compile time instead of runtime. So at runtime only the buffer of hash data is stored, bringing the storage for any GitOid to the absolute minimum of 20 bytes for SHA-1 and SHA-1DC, and 32 bytes for SHA-256.

I've now implemented the conversion of object type from runtime-encoded to compile time encoded, bringing the size of the GitOid struct down to the absolute minimum by only storing a buffer at runtime.


Moves tests/* to tests/miniconda/*.

Related: #24.

Not sure what happened with the tests - it's complaining that the WORKSPACE file is missing?

Change the path:
https://github.com/spietras/rules_conda/blob/9f85c13da012f0c01ed605b369ca54a1bb29f271/tests/miniconda/WORKSPACE#L28
to path = "../../"

Change the path:
https://github.com/spietras/rules_conda/blob/9f85c13da012f0c01ed605b369ca54a1bb29f271/tests/miniconda/WORKSPACE#L28
to path = "../../"

Oops. Yeah, I discovered this myself when running bazel test locally. Should have checked my mail first.


auto step issuse

Why does dat.gui automatically set step without setting step, while lil.gui's step is always 1

folder.add( { key: 1 },  'key' )

If you don't specify a step, lil-gui sets it to 0.1 or 0.1% of the range between min and max. But I'm not sure exactly what your question is.

if me not set min and max ，sample folder.add( { key: 1 }, 'key' ), dat.guI can auto set step,but lil guide can't ,it always 1

if me not set min and max ，sample folder.add( { key: 1 }, 'key' ), dat.guI can auto set step,but lil guide can't ,it always 1

What are you expecting step to be in this case for lil-gui?

I hope it can implement a dynamic step, or based on initial values such as 1step 0.1, 0.1 step 0.01, or dynamically change the accuracy according to the user's modified range, or add an accuracy input box

Got it. If I remember, in dat.gui, if there was no min/max, we set the step based on the magnitude of the initial value. Maybe that's what you mean by dynamic step? That behavior was a bit too magical in my opinion.
If there's no step specified, the intent is:

Number box dragging increments by 0.1 per pixel
One arrow key === +/- 1

Step is already calculated "dynamically" if min and max are provided.


Strange behavior with HTTPError and multiprocessing

Hello!
We use gcsfs in a cloud workflow via Kubernetes VMs.
Our workflow uses concurrent.futures (multiprocessing). We are aware of the fork issues and we make sure to use the spawn context when we create our process pool when using gcsfs.
When a gcsfs.retry.HTTPError with a response is raised in a subprocess, while it is being forwarded to be raised by the host process, it crashes the process pool, and sometimes this causes the VM to hang. The main process sometimes crashes, but sometimes hangs. See below for a minimal reproducer.
In the main function, it calls all three functions with the process pool. First one (baseline ZeroDivisonError) fails as expected and raises the correct issue. The second one (HttpError with a response) fails with a BrokenProcessPool and the traceback says the HTTPError caused this. The third one (HTTPError without response) raises HTTPError as expected. Looking at the traceback, seems like when the HTTPError is being re-raised, the response has been stringified already but as you know (here) it expects a response with two fields. Not sure why/how this is breaking.
Do you have any ideas about this?
P.S. it may be too much to look at but this is how we use it:

Call from host process here
The function being called here
The lines where gcsfs gets used are here and here. We use Zarr's integration with gcsfs.

Thanks!
Code
from gcsfs.retry import HttpError
from concurrent.futures import ProcessPoolExecutor
import multiprocessing as mp
from random import random

DUMMY_RESPONSE = {
    "code": 429,
    "message": "You have exceeded your bucket's allowed rate. See https://cloud.google.com/storage/docs/hotspotting for details.",
}

def http_error_generator_with_response(_):
    proba = random()

    if proba > 0.85:
        try:
            1 / 0
        except ZeroDivisionError as e:
            raise HttpError(DUMMY_RESPONSE)

def http_error_generator_no_response(_):
    proba = random()

    if proba > 0.85:
        try:
            1 / 0
        except ZeroDivisionError as e:
            raise HttpError()

def zero_division_generator(_):
    proba = random()

    if proba > 0.85:
        try:
            1 / 0
        except ZeroDivisionError as e:
            raise e

def main():
    ctx = mp.get_context("spawn")

    with ProcessPoolExecutor(4, mp_context=ctx) as p:
        # This raises zero division error correctly.
        results = p.map(zero_division_generator, range(100))
        _ = list(results)

        # This causes a broken process pool and hangs Google cloud VMs.
        results = p.map(http_error_generator_with_response, range(100))
        _ = list(results)

        # This raises an HTTPError as expected.
        results = p.map(http_error_generator_no_response, range(100))
        _ = list(results)

if __name__ == "__main__":
    main()

Traceback

Click to expand.
concurrent.futures.process._RemoteTraceback:
'''
Traceback (most recent call last):
  File "/Library/Frameworks/Python.framework/Versions/3.11/lib/python3.11/concurrent/futures/process.py", line 419, in wait_result_broken_or_wakeup
    result_item = result_reader.recv()
                  ^^^^^^^^^^^^^^^^^^^^
  File "/Library/Frameworks/Python.framework/Versions/3.11/lib/python3.11/multiprocessing/connection.py", line 250, in recv
    return _ForkingPickler.loads(buf.getbuffer())
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/user.name/PycharmProjects/my-package/.venv/lib/python3.11/site-packages/gcsfs/retry.py", line 19, in __init__
    self.code = error_response.get("code", None)
                ^^^^^^^^^^^^^^^^^^
AttributeError: 'str' object has no attribute 'get'
'''

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "/Users/user.name/PycharmProjects/my-package/gcsfs_exception_mvp.py", line 61, in <module>
    main()
  File "/Users/user.name/PycharmProjects/my-package/gcsfs_exception_mvp.py", line 53, in main
    _ = list(results)
        ^^^^^^^^^^^^^
  File "/Library/Frameworks/Python.framework/Versions/3.11/lib/python3.11/concurrent/futures/process.py", line 602, in _chain_from_iterable_of_lists
    for element in iterable:
  File "/Library/Frameworks/Python.framework/Versions/3.11/lib/python3.11/concurrent/futures/_base.py", line 619, in result_iterator
    yield _result_or_cancel(fs.pop())
          ^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Library/Frameworks/Python.framework/Versions/3.11/lib/python3.11/concurrent/futures/_base.py", line 317, in _result_or_cancel
    return fut.result(timeout)
           ^^^^^^^^^^^^^^^^^^^
  File "/Library/Frameworks/Python.framework/Versions/3.11/lib/python3.11/concurrent/futures/_base.py", line 456, in result
    return self.__get_result()
           ^^^^^^^^^^^^^^^^^^^
  File "/Library/Frameworks/Python.framework/Versions/3.11/lib/python3.11/concurrent/futures/_base.py", line 401, in __get_result
    raise self._exception
concurrent.futures.process.BrokenProcessPool: A process in the process pool was terminated abruptly while the future was running or pending.

~I suppose we make no guarantees that exceptions should be serialisable across processes - the traceback object will, after all, contain all the frames and variables of the stack, and those can include sessions, sockets and such.~
~When used with dask, a common multiprocessing setup for gcsfs, dask makes sure to carefully serialise exceptions into text and pass that instead. You could do the same, if you find the code for it or - perhaps? - you can actually use dask in your workflow too.~
Having said all that, I can confirm that HttpError with a response set (and no other stack involved) is not pickleable. I don't immediately see why the message is being passed back as error_response, but it should be simple to fix by providing an explicit __reduce__
--- a/gcsfs/retry.py
+++ b/gcsfs/retry.py
@@ -29,6 +29,9 @@ class HttpError(Exception):
         # Call the base class constructor with the parameters it needs
         super().__init__(self.message)

+    def __reduce__(self):
+        return HttpError, ({"code": self.code, "message": self.message.rsplit(",", 1)[0]}, )
+

Great, lemme try it and I can make a PR.

It does work and raises the correct error. I will raise a PR! Thanks a lot.


Update randomised transpiler-equivalence test strategies

Summary
This commit updates the strategies used to do the randomised testing of
transpiler equivalence, having three main effects:

The "pre-transpilation" circuit is now run on an Aer backend without
any transpilation at all, making the test truer to its name.
Previously execute was used which secretly performs a transpilation
internally.  This was accompanied by a small change to the set of
gates, to ensure only those that are directly supported by Aer are
used.

The strategies used for drawing gates are simplified into (mostly) a
single rule that draws a gate from a set, and populates it.  This is
just tidying up - it unifies the logic for drawing a gate into one
strategy rather than several.

The tests are updated to avoid using deprecated behaviour (e.g.
back-referencing a register from a bit) or features (e.g. various old
gate classes, and the old Aer qasm_simulator).

Point 1 in this list is also a fix to recent randomised testing
failures; since the tests were updated in ff4ee1b to call backend.run
directly (rather than execute) in the second run of each circuit,
when Hypothesis was drawing None as the backend in conjunction with a
gate Aer didn't know how to simulate (e.g. CRZGate), Aer would raise
an exception.  Previously this behaviour was hidden by the internal call
to transpile inherent in execute, and was a logic error in the test
suite, rather than in Terra.

Details and comments
This fixes the cause of the nightly randomised testing failures since #7945 - the intent of that PR was correct, it just exposed a minor logic error in the test.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
3 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.005%) to 84.238%

Files with Coverage Reduction
New Missed Lines
%

qiskit/pulse/library/waveform.py
3
89.36%

Totals

Change from base Build<PHONE_NUMBER>:
-0.005%

Covered Lines:
54069

Relevant Lines:
64186

💛  - Coveralls

I don't know at all, to be honest - I don't know how hypothesis works. I found that putting the precondition on the rule that the circuit at least had some qubits and clbits first seemed to make it more reliably test more paths, but beyond that I don't know.

I found that putting the precondition on the rule that the circuit at least had some qubits and clbits first seemed to make it more reliably test more paths

Ah yeah, this is consistent with my understanding of preconditions as well. Using assume in the body of a rule function causes the test to just get thrown out if the condition isn't satisfied, whereas the precondition decorator prevents invalid tests from being explored.
Even if these changes do change the rule probabilities, I suppose the transpile equivalence test rule's precondition requires at least one Measure present, and there's a good change then that the add_gate rule would've been called a decent number of times.


NCTL: add keys for uploading logs on failure

Changes:

Adds back keys needed for uploading to s3

bors r+


Mention the '--expires' flag available to the 'tuf gen-key' command

Thanks! The commit message needs a DCO sign-off before we can merge (you can amend+force push to update the PR)


Define ledger agnostic AnonCreds interfaces for ACA-Py

Placeholder issue to define the AnonCreds interfaces for ACA-Py.
TODO

[ ] AnonCreds routes.py
[ ] anoncreds issuer, holder, verifier
[ ] anoncreds service that manages multiple anoncreds registries
[ ] anoncreds registry

https://hackmd.io/Ailjb-WDTeC48EjF0gjrGA

@swcurran @andrewwhitehead @ianco question about the backwards compatibility we need to keep.
AFJ
I'll describe here how we tackle backwards compatibility in AFJ for reference. In AFJ we are removing the ledger api (which used to do all operations related to indy ledgers dids, schemas, creds defs, etc..) and instead creating more focused apis. So we have the did api that allows to create/resolve dids and the anoncreds api that allows to create / retrieve anoncreds objects. This replaces the 'ledger' classes. The notion of ledger is removed and we have just implementations of specific topics. So the IndySdkDidResolver, or the AnonCredsRsIssuer, but not something focused around a ledger anymore (as all these topics could work without ledger).
We are implementing the AnonCreds apis for the new AnonCreds-RS library, as well as the indy-sdk. The indy-sdk anoncreds implementation will only be able to support legacy, unqualified indy style anoncreds objects. If you want to use it with did:indy or other anoncreds methods you have to use the anoncreds-rs implementations (And thus the other shared components libraries).
ACA-Py
As ACA-Py already supports the shared components, the question is, whether support for the indy-shared-rs (credx) library must be retained. Indy SDK allows for legacy indy wallets to be used that haven't gotten the chance to update yet, but the anoncreds-rs lib will be able to replace the indy-credx library. So I'm currently leaning to implementing the ledger agnostic anoncreds interfaces in ACA-Py twice. Once with the indy-sdk and once with the anoncreds-rs lib. Same as with AFJ, indy-sdk will only support legacy indy objects identfiiers, anoncreds-rs will support legacy, did:indy and other methods.
We will probably rename the indy folder to anoncreds and update the current issuer/holder/verifier interfaces to be ledger agnsotic, and create a registry service (like the did resolver) that allows to interact with multiple anoncreds registries (indy ledger, cheqd ledger, etc..). this is mostly internal changes and shouldn't cause any problems.
The public API is where it get's interesting.
Ideally we would create an AnonCreds api in ACA-Py that is designed for ledger agnositc anoncreds:

GET /anoncreds/schema/{schema_id}
POST /anoncreds/schema
GET /anoncreds/credential-definition/{cred_def_id}
POST /anoncreds/credential-definition

We could also look at keeping the existing API endpoints, however as the models are going to change slightly (and more for revocation), we are going to need to make breaking changes either way and this is a great chance to do it properly for the 1.0.0 release of ACA-Py (that could have some breaking changes I guess).
We are probably also going to make some changes to the revocation API. A lot can stay the same, but some (like the revocation list model) will cause breaking changes). We could create a new API under /anoncreds/revocation, that is based on the existing api. If we move them under /revocation/anoncreds they're not in the generic 'revocation' domain, but focused solely on anoncreds revocation.
Lot of things to consider here. I think my main questions is: Can we create a new /anoncreds/ API in ACA-Py that is ideal for the new ledger agnostic anoncreds, or do we need to try to minimize breaking changes and adhere to the existing API as much as possible? If we want to make ACA-Py as generic as possible I'm leaning to break things now for the better, but I see the strategy of minimizing breaking changes to make updating easier.
cc @karimStekelenburg @blu3beri

Is it an option to leave all the existing API's as is (but deprecate them) and add a new anoncreds api which is ledger agnostic?  @swcurran ?
Regarding continuing support for credx that's a question for @andrewwhitehead I think.

Is it an option to leave all the existing API's as is (but deprecate them) and add a new anoncreds api which is ledger agnostic?

I think that should be possible. We should probably change the underlying implementation a bit

Here are my thoughts in reading this -- some ideas, nothing more.
I'd like us to consider dropping the indy-sdk entirely in ACA-Py 1.0 and only support the shared components.  Any thoughts on that? Not particularly relevant to this question, but while we're talking about such a big breaking change, here are some others:

In a breaking change 1.0 release, we should consider making more adjustments to the startup parameters (e.g. making "emit-https-message-prefix" the default), and to the admin API to drop "old stuff".  We might also consider determining what startup parameters should be updatable on the fly, and what ones should be updatable in a per tenant context.  I don't think there are a lot of them, but we should check.

I do think we need to try to retain the existing Admin API handling "indyanoncreds-style" issuing and presenting. If we find that to be too complex, we have the "breaking change" excuse to fall back on.  I don't know how the code is structured around the protocol messages and the handling of attachments, but I assume the attachment handling is where the impact will be.  I'd like to note that I hope/expect we will be seeing "W3C Format AnonCreds" in the near future and the restructuring of the implementation issue-credential, present-proof attachment handling should include or anticipate that.

With anoncreds-rs nearing completion, it is nearing time to replace the CredX implementation of AnonCreds with the new one in ACA-Py. We need to decide on the right way to add the new implementation such that anoncreds becomes ledger agnostic.  We do not want to continue to use CredX from indy-shared-rs -- we want ACA-Py to only use the "proper" anoncreds-rs implementation.
Adding to what @TimoGlastra wrote above, my assumption is that in ACA-Py we want to support:

The existing "Legacy Indy" implementation we have today. All AnonCreds operations will continue to work as is. The implementation must address the differences between the current Indy data structures and those expected by the anoncreds-rs implementation.
A new did:indy based implementation will be added. In that, the new format for Indy DIDs (see this from did:indy spec) will be used, as will the new format for all of the object identifiers (see this from the did:indy spec.).
Ideally, we will add a did:web AnonCreds Method resolver capability, supporting the objects being stored on a web server as per the did:web specification. The DID URLs for for the various AnonCreds objects should be the same as is specified for did:indy.

We would have to do something more advanced to do the registering of DIDs and AnonCreds objects using did:web.  AFAIK, how that is to be done is undefined,.
We could also do the same for did:github, where the DIDs and AnonCreds objects are stored on GitHub.

Document how to add support for new AnonCreds methods, to support others (such as Cheqd and Cardano) adding support in ACA-Py, likely through plugins

The reason for supporting numerous AnonCreds Methods out of the box is so that we are certain we have the right abstraction in the code -- that it is as easy as possible to add support for other Methods.
We also need a way to allow someone to define what AnonCreds Method they are going to use for an issuer -- for writing AnonCreds objects.
I had expected that the AnonCreds Methods would be from an external, shared repository that ACA-Py, other Aries Frameworks and other non-Aries components would call, and that component would call the appropriate SDK for the VDR they are using. E.g. the Indy one might support both legacy Indy and did:indy and both would use Indy VDR.  However, in talking with @TimoGlastra and @blu3beri, they expect that the "AnonCreds Methods" will be added in ACA-Py, and not in a common repo, if for now other reason than having to have another set of Rust wrappers would be a pain.
Discuss...
@andrewwhitehead @ianco

Here's a bold idea that was brewing in my head.
Originally, aca-py was exclusively dealing with indy cred (credx?) until a contribution was made by Animo to include json-ld VC.
We are now looking at extracting Indy creds from the Aries library and re-implementing it as a stand-alone credential type/model.
Would it make sense to review the existing /credentials* endpoints with this fresh perspective? I've been following the w3c-ccg vc-api folks for some time and as an example they define the POST /credentials/issue endpoint. This endpoint takes a credential field and an options field, then returns a signed credential. Currently only w3c VC are defined but they made it clear they want to extend this to other credential types such as mDL (and, who knows, maybe eventually AnonCreds????). They definitely find the direction AnonCreds are going very interesting.
Now where I see potential is to define such endpoint (there is no POST /credentials/issue at the moment on aca-py, therefore wouldn't change any of the existing functionalities) and enable the issuance of both json-ld and anoncred through this endpoint, effectively implementing one of the vc-api endpoints, enabling 2 types of credential to be issued. It's also foreseeable that eventually, aca-py might benefit from issuing mDL credentials (another topic on its own).
This would also make Hyperledger and ACA-py an official implementation of the vc-api and open the door for other vc-api implementers to experiment with AnonCreds based on the shared components model defined by Animo's work, furthering global interoperability on the credential models scope.
The /anoncred endpoints suggested could still exist to lay the foundation necessary to issue such credentials (dealing with schemas/cred defs).
Here's an issue I opened sometime ago regarding multi-credential formats on the vc-api. As you can see, it's still unsure how this would be implemented but this would make a great use case to propose something back to the w3c-ccg vc-api group, at the very least identifying challenges and limitations to this approach. There will be some overlapping misconception based on each frameworks way of doing things (looking at you, CredentialStatusList2017 / revocation mechanisms). Which will require some work to iron out.
Curious to hear your opinions on this @swcurran  @TimoGlastra @ianco

Interesting ideas — definitely worth a discussion.
ACA-Py already has a version of the endpoint that you are talking about. /issue-credential/send is the  end to end “issue credential” endpoint that supports AnonCreds and W3C Verifiable Credentials Data Model Standard credentials. It could be used as a kind of equivalent to the vc-api. However, I suspect that with vc-api, there is not a concept of issuer/holder back-and-forth messages to accomplish the issuance.
One simplification to the API that we might consider is to eliminate (or deprecate) the other per Aries Issue Credential protocol admin endpoints, and just assume that ACA-Py will handle the whole process. We’ve always had the other endpoints, but I’d be willing to bet no one is using them. The controller would only be contacted if something goes wrong.  Something to consider.
As well, if we move AnonCreds to use the W3C Verifiable Credentials Data Model Standard, then we can further merge the processing.
Interesting topics.


Update backtrace documentation for Rust 1.65 release

Rust 1.65 stabilizes the backtrace API which previously required nightly, this PR updates the documentation accordingly
I've tested this and the backtrace does work without the backtrace feature on 1.65. (Make sure to enable backtrace in the Playground)

I'll instead make it an issue to use the std's API when possible


Add Christian to Contributors list

Hi  @CTSalinas, I'm quite elated about your pull request. I wanna evolve this project to addresses various problems faced by first-time contributors. I'd love to learn about your journey in open source community, the problems, pain points you had etc.
Could you explain how you felt when you went through the tutorial, made a pull request and learned that I merged it?
We’ve recently added social share  to our web app. Could you please go to https://roshanjossey.github.io/first-contributions/#social-share and share your first contribution to open source?
Also, check out projects with easy issues while you’re there.

@Roshanjossey It felt great going through the process! However, there was one thing I was confused about; why my name wasn't hyperlinked compared to everybody else. Not sure where I messed up in the markdown.
Also, might not hurt to throw in how to change the branch name. This is definitely my fault, but I sped through the instructions without reading further on and learned that adding "add-christian-s" would be a good branch name. Perhaps I could add those instruction myself?

@CTSalinas,

why my name wasn't hyperlinked compared to everybody else. Not sure where I messed up in the markdown.

It's because there is a space between ] and (. feel free to submit another pull request to fix this.

Also, might not hurt to throw in how to change the branch name.

One thing we care about a lot is to keep the tutorial short and on the dot. Like, it should be easy for anyone to go through it in 5 minutes. I feel instructions to change branch name might be a digression.
I’d urge you to continue contributing to other open source projects.
We also have a slack team to help/mentor people trying to contribute to open source projects.
You can join the team by going to https://goo.gl/PM1Jdh


Delete downloaded files in case of exception as well

https://dimagi.atlassian.net/browse/SC-3646
We were retaining files in case the task fails.
Also reached out to @sravfeyn to confirm this change does not cause unexpected issues here
The other place mentioned in the ticket should be handled by this change itself because the exception raised is caught in refresh_hq_datasource_task after that.

Hey @mkangia
Just realised , there is one more place that the file may remain if exceptions occurs for data source refresh in sync mode here

Ajeet, I rebased the feedback fix since this was a very small PR. Requesting for a quick pass on review again. The overall changes remain the same as you reviewed.

oh yes, good find. Addressed that as well. Trying to add a test for it as well.

fyi @ajeety4
test added for error handling.


[HUDI-8680][DNM] Enable partition stats by default 3

Change Logs
Describe context and summary for this change. Highlight if any code was copied.
Impact
Describe any public API or user-facing feature change or any performance impact.
Risk level (write none, low medium or high below)
If medium or high, explain what verification was done to mitigate the risks.
Documentation Update
Describe any necessary documentation update if there is any new feature, config, or user-facing change. If not, put "none".

The config description must be updated if new configs are added or the default value of the configs are changed
Any new feature or user-facing change requires updating the Hudi website. Please create a Jira ticket, attach the
ticket number here and follow the instruction to make
changes to the website.

Contributor's checklist

[ ] Read through contributor's guide
[ ] Change Logs and Impact were stated clearly
[ ] Adequate tests were added if applicable
[ ] CI passed

closing in favor of https://github.com/apache/hudi/pull/12511


OCM-5440: OCP-65645: Mp reconciliation feature TC

Ran 1 of 50 Specs in 16.752 seconds
SUCCESS! -- 1 Passed | 0 Failed | 1 Pending | 48 Skipped
PASS
Ginkgo ran 1 suite in 17.715053201s
Test Suite Passed

/test rosa-sts-advanced-optional-presubmit

/test rosa-sts-advanced-optional-presubmit

/test rosa-sts-advanced-optional-presubmit

/lgtm
/approve

/override ci/prow/rosa-sts-advanced-optional-presubmit
it should be fixed by yuwan's PR (mentioned here). If no PR by tomorrow, I'll remind him


Card holder name is validated by client side scripts instead of Adyen due to 'required' attribute in code

Describe the bug
We are getting an odd error message for card holder name field.
When we set card holder name (holderNameRequired = true) the Card Holder name input field is rendering with 'required' attribute unlike card number field, cvv field, expiry date field etc.
Due to this 'required' attribute the client side code dong a validation on that required field even before Adyen does the same.
Please note that, if we remove the 'required' attribute it will work as expected.
To Reproduce
Steps to reproduce the behavior:
Enabled Card holder name from BM, set holderNameRequired = true
Expected behavior
The field should be validated by Adyen instead of client side scripts since its coming from Adyen,
Screenshots

Desktop (please complete the following information):

OS: Windows 10
Browser Chrome
Version 97

Additional context
Add any other context about the problem here.

Comparison image with and without 'required' attribute.

Hi @johns-abraham-borngroup ,
Thanks for reaching out. Can you share what version are you using? I did a quick test on the latest release and on (https://www.mystoredemo.io/)[MyStore demo] and I didn't manage to reproduce this issue.

Hi @ribeiroguilherme,
We also have a problem with the cardholder name we are using version 5.3.1 (we cannot update to the latest version released because of another bug reported https://github.com/Adyen/adyen-web/issues/1426).
We observed that after the drop-in is loaded if you click on the cardholder name and change the focus on another element following message appears "Invalid cardholder name".
Steps to reproduce:

Make sure you configure the option "holderNameRequired": true:

  paymentMethodsConfiguration: {
                    card: {
                        hasHolderName: true,
                        holderNameRequired: true
                    }
                }

When the drop-in appears click on the cardholder name field.
Click on the region above the input (See screenshot)

Following message appears:

Expected result
Validation should appear only when the user clicks on the "Save" button.

@AndreaGhisa1 we are currently discussing various issues with UX/design team including how/when fields are validated and we'll get back to you

I am closing this issue since I believe it has been addressed in later releases. If you still think this issue persists please make a new ticket

To whoever may run into this problem:
It's mainly caused by the fact that you are using a form to submit data to adyen. The required field prevents the form from being submitted and Adyen validation to trigger.
The solution is to just add the noValidate attribute to your form and Adyen will take care of the rest.


mac-address: Support interface mac-address

Coverage increased (+0.02%) to 64.554% when pulling 88c386b1b5837e60a6f66616505cd9742e62c8d4 on EdDev:mac-address into 7dc0335be3b167beed41c5aae40e4be1e7f45a55 on nmstate:master.

I have added integration tests for the mac in the bond tests.
We should cover other interface types, but I think we should be safe as it is, because the mac is set explicitly in all the running tests anyway.
Added a ticket to make sure we add it later on: https://nmstate.atlassian.net/browse/NMSTATE-169


Test PR, Added Some Comments

Just added some function headers and comments to NetManager.cs and  UIController.cs

looks good.
Unity will update their UI system and networking stack later this year, so we will leave these system until future updates.
also some tips for the comments, they are supposed to be helpful for understanding concepts or overall blueprints, if the comments duplicate what code obviously means, it'll add noise to the codebase.


Fixed unallowed html syntax in ews-operations-in-exchange.md

The disallowed html syntax in this case was simply invisible. So you couldn't see . I escaped the angle brackets with '`' and also made them bold and italic to make it more clear.

Docs Build status updates of commit 673a3cb:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/web-service-reference/ews-operations-in-exchange.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit 471f384:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/web-service-reference/ews-operations-in-exchange.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


Updated to 1.16.3

Thought you might want this. It might be best to put this on a new branch.

This is MIT licensed and the author doesn't really seem to care about this mod anymore. You could re-release it with credits.

@thakyZ Do you want to push this to CurseForge? If not, I'll do so in a bit (week or so). Obviously, I'll credit you, and if you want to upload it under your name later, I'll take mine down.

There is a mod for that already https://www.curseforge.com/minecraft/mc-mods/rsinfinitybooster

@DAmNRelentless I... Thanks. Umm. That simplifies my weekend.


Analytics: Relocate UUID to homebrew.analyticsuuid in .git/config

[x] Have you followed the guidelines in our Contributing document?
[x] Have you checked to ensure there aren't other open Pull Requests for the same change?
[x] Have you added an explanation of what your changes do and why you'd like us to include them?
[x] N/A. Have you written new tests for your changes? Here's an example.
[x] Have you successfully ran brew tests with your changes locally?

Discussions in #145.
This way analytics related settings and parameters (currently analyticsdisabled, analyticsmessage and analyticsuuid) are all kept in the same place.
Note that in this commit we offer a path of migration: if ~/.homebrew_analytics_user_uuid already exists, read the UUID from it, write to homebrew.analyticsuuid, and remove it.

I didn't realize ~/.homebrew_analytics_user_uuid is documented. Documentation now updated.

@mikemcquaid Addressed both comments.

LGTM 👍 If @xu-cheng is happy I'll :shipit:

Addressed a bunch of great suggestions from @UniqMartin.

One comment. Otherwise LGTM

:+1: I think this is ready to be shipped.

Addressed a bunch of great suggestions from @UniqMartin.

Thanks for the kind words!

EDIT: I ended up pushing two more times, one fix, one improvement. Sorry for taxing the CI.

No worries! Builds for formula PRs are usually taxing it much more than this kind of PR.

:+1: as well. I tested it interactively on 10.9 and it worked as expected.

@apjanke Replying to your comment in an outdated diff:

Minor style note: cmd/update.sh is using underscores/snake_case in its function names. Maybe we should change one of these to match the other?

There's also update-preinstall in brew.sh. Personally I prefer underscores in shell function names to set them apart from executable names (where I prefer to use hyphens), but I'm not sure about other people's opinions.

Thanks for the good discussion prior to this PR and then following up with the implementation! Great work, @zmwangx! Merged in c63400d56baaa36f111c2e2d7e709c9ea7b8b992. :tada:

To comment on the style discussion: I guess we haven't yet converged as much on a style as I thought we had. I prefer using dashes over underscores to differentiate function names from variable names. I don't see a need to differentiate functions from external commands as I treat them mostly alike.
Probably a good idea to fix the confusing style differences once we agree on our preferred style.

To comment on the style discussion: I guess we haven't yet converged as much on a style as I thought we had. I prefer using dashes over underscores to differentiate function names from variable names. I don't see a need to differentiate functions from external commands as I treat them mostly alike.
Probably a good idea to fix the confusing style differences once we agree on our preferred style.

I prefer underscores to avoid confusion when writing POSIX-compliant shell scripts: http://unix.stackexchange.com/a/168222

Interesting; I didn't know that. I think I'd also prefer underscores because that's the convention we're using in the Ruby code.


Move world_location_news_translations pages to GDS Design System

What

Duplicated edit and renamed to legacy_edit

Duplicated world_location_news_translation_controller and renamed to legacy_world_location_news_translation_controller

Updated edit to use GDS components

Duplicated index and renamed to legacy_edit

Updated index to use GDS components

Added render_design_system feature flag to world_location_news_translation_controller

Added login_as_preview_design_system_user to world_location_news_translation_controller

Appended test title with legacy

Added confirm_destroy page

Added Route for confirm_destroy

Removed RtL test as components all do this

Why

Align edit with the GDS Design System

Align index with the GDS Design System

Remove duplicate testing

Confirm delete of translations

Consistent GDS design across Whitehall

Notes

Blocked by world_location_news so this is built off that branch.

Needs rebasing onto main once blockers merged

Trello

https://trello.com/c/inRlaZLs/52-world-location-news-translations-show-page

Pics

Show no translations

Index Page

Edit Page

Confirm Destroy page

⚠ This repo is Continuously Deployed: make sure you follow the guidance ⚠
Follow these steps if you are doing a Rails upgrade.

@CL-GDS Few comments:
Tabs page:

The Translations tab should be marked
Move the select and green button above the table or empty message
Green button should be Create new translation
Instead of using the inset for No translations, use this style (just the grey message)

Locale label should be the medium label in bold
Remove the Actions title and keep it empty (but add the aria-label)
Move View on the left of the Edit button

Edit page:

Labels should use the medium bold label

Nikin is happy with design

Handing over the test fixes & current page underline issue to @davidgisbey due to backend complexity.


Feature: Add topics taxonomy tree

Description
This PR adds the topics taxonomy hierarchical table into a collapsible tree, it renders V1 and V2 of topic taxonomy with a search bar allowing searching of multiple leveled topics.

Relevant Technical Choices

D3JS is used to create a tree that handles user click events for adding and removing nodes.

Testing Instructions

Open the PSAT panel, and move to the topics component.
Select the Taxonomy V2/V1 tab, a tree will load up.
Click on a circular node will open the child node, whereas the rectangle as the leaf node.
Try searching a topic and select it, it should toggle the node.

Additional Information:

Screenshot/Screencast
https://github.com/user-attachments/assets/9b283cb4-6911-4210-b355-f9081ae59b0e

Checklist

[x] I have thoroughly tested this code to the best of my abilities.
[x] I have reviewed the code myself before requesting a review.
~This code is covered by unit tests to verify that it works as intended.~
[x] The QA of this PR is done by a member of the QA team (to be checked by QA).

Fixes #783

@mayan-000 I think we should reduce the font-size a bit

As discussed previously, can we also add link to the source file on Github?

"Root" is not the taxonomy name right, it just indicates that this node is the root node?
If that is that case, let's remove the word "Root" and leave the root node empty, as it creates a little confusion.

I think the search input box needs to be moved to the left a bit.


Enhancement of carrom game UI

PR Description 📜
Please include summary related to the issue you have fixed and describe your PR in brief over here by specifying the issue number on which you were working below
Fixes #4614

Mark the task you have completed ✅

[x] I follow CONTRIBUTING GUIDELINE & CODE OF CONDUCT of this project.
[x] I have performed a self-review of my own code or work.
[x] I have commented my code, particularly in hard-to-understand areas.
[x] My changes generates no new warnings.

Add your screenshots(Optional) 📸

earlier it was simple white, no alignment

Thank you soo much for contributing to our repository 💗

Thank you @sau-mili ,for creating the PR and contributing to our GameZone 💗
Review team will review the PR and will reach out to you soon! 😇
Make sure that you have marked all the tasks that you are done with ✅.
Thank you for your patience! 😀

@ishita-43 please check

Thank you  @sau-mili , for your valuable time and contribution in our GameZone 💗.
It’s our GameZone, so Let’s build this GameZone altogether !!🤝
Hoping to see you soon with another PR again 😇
Wishing you all the best for your journey into Open Source🚀


strict row types

Convert from the Row = Dict[str, Any] type we were passing around everywhere to strictly defined dataclasses with fields. Pure refactoring, (except I may have fixed a bug where were were failing to add name metadata correctly in some cases.)
But we were using the Row type extensively so this touches almost everything.
Row has now been disambiguated into the following types, and it's much easier to understand what we're passing around when.

SatelliteAnswer / SatelliteAnswerMetadata
IpMetadata
Row, with child classes HyperquackRow and SatelliteRow
BlockpageRow
ReceivedHttps (for the parsed content of an HTTP/S request, shared between HyperquackRow and BlockpageRow)

TESTED: passed e2e test and e2e test with runtime_type_check=True.
I'm somewhat worried about the memory implication of passing around dataclasses instead of dicts. Ran a test job to check, which took 16 hours to complete instead of the usual 9.

Switched to composition instead of inheritance as discussed.
The dict-update-like methods for IpMetadata and SatelliteAnswers ended up being required. For both of them we need a way to merge multiple disparate sources of metadata/tags while ignoring nulls. The version for ReceivedHttps data is gone though.
I've added the serialization methods in schema.py as flatten_for_bigquery_*


Expose SuiteSparseQR_C_backslash to Python as qr_solve.

Hi,
Thanks for the wrapper, almost exactly what I was looking for. :)
As for the "almost" part, here is a quick addition to PySPQR that allows solving A x = b in the least-squares sense. Using SuiteSparseQR_C_backslash for this is usually much faster than first explicitly constructing Q via SuiteSparseQR_C_QR (although this approach is now also documented in the docstrings).
I also took the liberty to remove trailing whitespace, and added/expanded some docstrings.
I've tested this with both the small test in main() and an approximately 4500x1500 matrix in a project I'm working on, and it works. Solve time for the 4500x1500 is under 3 seconds on an i7 (whereas first decomposing with qr() takes about a minute).
I'm not 100% sure if I did all the low-level stuff (memory handling / data type conversion) correctly - comments are welcome.

Thanks! I merged the changes. I made a change to fix a memory error. I added a .copy() to the use of cffi_asarray, because that returns a view.

Ok. Thanks for the fix!
Just a minute ago, I updated the README to reflect that the solvers are now also wrapped (and some minor edits to the examples), do you want to pull that too?

I think I pulled those. It seems that pull requests automatically update to include all changes in your fork.

Correct. However, there were some last-minute edits that didn't make it into the pull :)
Also, there was a potentially confusing copy'n'paste typo in one my added docstrings in spqr.py; that is now also fixed in my fork.

Got it. I pulled those changes now, too.

Thanks for your patience!
And... if you want, there's one more new last-minute edit in the README.md in my fork: I just now noticed that Markdown supports syntax highlighting. It's now enabled for the examples.
Now I think I probably won't make more edits to this any time soon :)


One line seperation

VSCode Version: 1.35.1
OS Version: Windows 10

Does this issue occur when all extensions are disabled?: Yes
I keep having an issue where I upload files to a server via Filezilla, and when I download them back I have a white space separation on EACH line of every page which is driving me and my coworkers nuts tbh. I have tried different versions and no extensions at all and keep having the same issue.

Please clarify how Filezilla fits into the picture.

Please clarify how Filezilla fits into the picture.

Hmm well, it's what I use to upload files to a server, when I get the files again they are formatted, the issue has never hapenned doing something different but it is always the same server. Does not happen with other servers.

So then I'm not clear why you think it's a VSCode issue.

VSCode writes a file to your local disk.
I assume that if you close it in VSCode, then reopen it, it looks correct.
You use Filezilla to upload it to a server, then download it back to your local disk.
You open it in VSCode and it now has extra linebreaks.

So I think you need to investigate what Filezilla is doing.


Wont drive P10 to P17；

Wont drive P10 to P17；
can only read P00 to p07
import pcf8575
from machine import I2C, Pin
i2c = I2C(scl=Pin(13), sda=Pin(12))
pcf = pcf8575.PCF8575(i2c)
print(0,pcf.pin(0))
print(1,pcf.pin(1))
print(2,pcf.pin(2))
print(3,pcf.pin(3))
print(4,pcf.pin(4))
print(5,pcf.pin(5))
print(6,pcf.pin(6))
print(7,pcf.pin(7))
print(10,pcf.pin(10))
print(11,pcf.pin(11))
print(12,pcf.pin(12))
print(13,pcf.pin(13))
print(14,pcf.pin(14))
print(15,pcf.pin(15))
print(16,pcf.pin(16))
print(17,pcf.pin(17))
k1=pcf.port
On a D1 mini Pro;

import pcf8575
from machine import I2C, Pin
i2c = I2C(scl=Pin(13), sda=Pin(12))
pcf = pcf8575.PCF8575(i2c)
def read8575():
k1=pcf.port
k2= str(bin(k1))
k3 = []
for i in range(len(k2[2:])):
i=i+1
#print(i,k2[-i])
k3.append(int(k2[-i]))
for j in range(16-len(k2[2:])):
k3.append(0)
return k3
f1=read8575()
print (f1)
for reading all pins
exec(open('8575.py').read(),globals())
[0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0]

Are you using a pcf8575 breakout, or the chip directly?
Are you sure you have a pcf8575 and not a pcf8574?
Do you have pull ups on your I2C line?


Can't compile openblas

getarch_2nd.c: In function ‘main’:
getarch_2nd.c:12:35: error: ‘SGEMM_DEFAULT_UNROLL_M’ undeclared (first use in this function)
printf("SGEMM_UNROLL_M=%d\n", SGEMM_DEFAULT_UNROLL_M);
^
getarch_2nd.c:12:35: note: each undeclared identifier is reported only once for each function it appears in
getarch_2nd.c:13:35: error: ‘SGEMM_DEFAULT_UNROLL_N’ undeclared (first use in this function)
printf("SGEMM_UNROLL_N=%d\n", SGEMM_DEFAULT_UNROLL_N);
^
getarch_2nd.c:14:35: error: ‘DGEMM_DEFAULT_UNROLL_M’ undeclared (first use in this function)
printf("DGEMM_UNROLL_M=%d\n", DGEMM_DEFAULT_UNROLL_M);
^
getarch_2nd.c:15:35: error: ‘DGEMM_DEFAULT_UNROLL_N’ undeclared (first use in this function)
printf("DGEMM_UNROLL_N=%d\n", DGEMM_DEFAULT_UNROLL_N);
^
getarch_2nd.c:19:35: error: ‘CGEMM_DEFAULT_UNROLL_M’ undeclared (first use in this function)
printf("CGEMM_UNROLL_M=%d\n", CGEMM_DEFAULT_UNROLL_M);
^
getarch_2nd.c:20:35: error: ‘CGEMM_DEFAULT_UNROLL_N’ undeclared (first use in this function)
printf("CGEMM_UNROLL_N=%d\n", CGEMM_DEFAULT_UNROLL_N);
^
getarch_2nd.c:21:35: error: ‘ZGEMM_DEFAULT_UNROLL_M’ undeclared (first use in this function)
printf("ZGEMM_UNROLL_M=%d\n", ZGEMM_DEFAULT_UNROLL_M);
^
getarch_2nd.c:22:35: error: ‘ZGEMM_DEFAULT_UNROLL_N’ undeclared (first use in this function)
printf("ZGEMM_UNROLL_N=%d\n", ZGEMM_DEFAULT_UNROLL_N);
^
getarch_2nd.c:67:50: error: ‘SGEMM_DEFAULT_Q’ undeclared (first use in this function)
printf("#define SLOCAL_BUFFER_SIZE\t%ld\n", (SGEMM_DEFAULT_Q * SGEMM_DEFAULT_UNROLL_N * 4 * 1 *  sizeof(float)));
^
getarch_2nd.c:68:50: error: ‘DGEMM_DEFAULT_Q’ undeclared (first use in this function)
printf("#define DLOCAL_BUFFER_SIZE\t%ld\n", (DGEMM_DEFAULT_Q * DGEMM_DEFAULT_UNROLL_N * 2 * 1 *  sizeof(double)));
^
getarch_2nd.c:69:50: error: ‘CGEMM_DEFAULT_Q’ undeclared (first use in this function)
printf("#define CLOCAL_BUFFER_SIZE\t%ld\n", (CGEMM_DEFAULT_Q * CGEMM_DEFAULT_UNROLL_N * 4 * 2 *  sizeof(float)));
^
getarch_2nd.c:70:50: error: ‘ZGEMM_DEFAULT_Q’ undeclared (first use in this function)
printf("#define ZLOCAL_BUFFER_SIZE\t%ld\n", (ZGEMM_DEFAULT_Q * ZGEMM_DEFAULT_UNROLL_N * 2 * 2 *  sizeof(double)));
^
make: *** [getarch_2nd] Error 1
Makefile:131: *** OpenBLAS: Detecting CPU failed. Please set TARGET explicitly, e.g. make TARGET=your_cpu_target. Please read README for the detail..  Stop.

What system are you trying to build OpenBLAS on ? If it is a rather new CPU, e.g. latest Intel "Kaby Lake" i7 or "Bay Trail" Celeron/Atom N35xx you need to download the current develop branch from here
or build with either "make TARGET=HASWELL" (high-end systems) or "make TARGET=ATOM" (cheap netbook or fileserver) as appropriate.

@martin-frbg Thank you so much ,it is work. Probably because my CPU is i7,so i builded with  "make TARGET=HASWELL" .


Expose select() method to override default behaviour

It would be great of the select() method was exposed, like listItemFn() and scoreFn() are, so that the default behaviour of selecting the value could be overridden.
An example could be the need to update the value in several different places (input and select, etc).

Closing because the project went stale some years ago.


Sync/hf diffusers/0.9

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.


Message tails for longer/taller messages need curvature removed

No content

Issue created by BlueBubbles Bot in the BlueBubbles commnity on behalf of @zach in #android-bugs.

Fixed. My beta branch


How to give labels to x- axis and y- axis

I want to give name for the labels for example x-axis and y-axis has weight and height values respectively, now I want to add text below the x-axis values like "Weight". How to add it?

use 'axistitle' plugin


Bug encountered while running fibonacci example

Why is it null ?
Encountered during the cli test run with server
I ran the fibonacci code with default parameters
and this was the output
{
  "data": [
    {
      "comments": "creating the stack",
      "state_def": {
        "body": [],
        "variable_name": "stack"
      },
      "state_type": "stack_declare"
    },
    {
      "comments": "",
      "state_def": {
        "body": [
          0
        ],
        "element": 0,
        "variable_name": "stack"
      },
      "state_type": "stack_push"
    },
    {
      "comments": "",
      "state_def": {
        "body": [
          0,
          1
        ],
        "element": 1,
        "variable_name": "stack"
      },
      "state_type": "stack_push"
    },
    {
      "comments": "this will store the answer",
      "state_def": {
        "value": null,
        "variable_name": "answer"
      },
      "state_type": "variable_declare"
    },
    {
      "comments": "this will store the second highest",
      "state_def": {
        "value": null,
        "variable_name": "answer"
      },
      "state_type": "variable_declare"
    }
  ],
  "status": "run_default"
}

the code of the fibonacci doesnt look good either tbh
it could be a error in the variable class or could be an error in the fibonacci code
import ARgorithmToolkit

def run(**kwargs):
    n = kwargs["n"]
    algo = ARgorithmToolkit.StateSet()
    st = ARgorithmToolkit.Stack("stack" , algo , "creating the stack")
    st.push(0)
    st.push(1)
    curr = ARgorithmToolkit.Variable("answer",algo , comments="this will store the answer")
    temp = ARgorithmToolkit.Variable("answer",algo , comments="this will store the second highest")
    if n > 0:
        for i in range(1,n):
            temp.value =  st.pop()
            curr.value = temp.value + st.top()
            st.push(temp.value)
            st.push(curr.value)
    return algo

you can replicate these results
python -m ARgorithmToolkit test

ARgorithmToolkit : 0.0.6

@yatharthmathur maybe we need to increase the quality of testing
currently testing is only being done for the state_type
i think it would be better to have more in depth tests written

I'll add more stringent test cases for other structures too tomorrow.

fixed in #7


Add new inscription ID

You have to add your inscriptionId not the one from the readme

Inscription ID of what?…. Any ghost ordinal?
Sent from Yahoo Mail for iPhone
On Saturday, July 1, 2023, 1:23 AM, Eloc @.***> wrote:
You have to add your inscriptionId not the one from the readme
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: @.***>

@boka340 you need to inscribe the manifesto from here
See the instructions https://github.com/cypherpunklab/manifesto/tree/main#inscribe

Closing this PR. Make a new one if you end up inscribing your own


Fix formatting issue on Manage security and authorization page

On Manage security and authorization page ( /v2.0/security/):

Fix this sentence:
Use secrets in a query Import the influxdata/influxd/secrets package and use the secrets. (Pulling in header and body text from the Store and use secrets page (/v2.0/security/secrets/).

fix in #1030


3rd level menu item resets all the menu

Version information

Laravel: v5.7.*
Voyager: v1.1.*
PHP: 7.1
Database: MySQL

Description
When any 3rd level menu item is clicked, the expanded menus are reseted.
Steps To Reproduce

Build a 3rd level menu item
Click on it.

Expected behavior
When a 3rd level menu item is clicked, keep the menu expanded.

Please search before opening new issues.
Closing as a duplicate of https://github.com/the-control-group/voyager/issues/2125
Will be fixed in https://github.com/the-control-group/voyager/pull/3620


Send SMS to add to Notion?

Hello Kevin, first I'd like to thank you for your Notion + Google assistant guide. Great stuff!
As I was looking through it, I got an idea. What if, instead of using Google assistant to add to Notion, you could send a text to a certain number to accomplish the same thing? Perhaps with some tags to put it into different pages depending on the type of content it is. Do you think this is possible without an API?

Hey @secretlycarl,
I'm glad you enjoyed the content I produced!

What if, instead of using Google assistant to add to Notion, you could send a text to a certain number to accomplish the same thing?

This is 100% doable, although it would require some custom work to make it function as expected. IFTTT doesn't support SMS (text messages) anymore, and Zapier only uses SMS to send information. You'll likely have to set up an SMS service (e.g., Twilio), then connect it somehow to your web server (e.g., notion-heroku) to then add stuff to your Notion.
Overall, it's likely a lot of work.

Do you think this is possible without an API?

Yes as you can use the unofficial Notion API like notion-py.

I wish you the best of luck if you are going to attempt this :). Let me know how it goes.


verifies algorithm before evaluating keyfinder

issue 343 PR (coordinated with @zinosama)

CI failing unrelated to PR, no?
The command "bundle exec rspec && bundle exec codeclimate-test-reporter" exited with 1.

@ab320012 fyi here is the PR that was discussed as part of issue 343.

cc: @laurawyse @pjo336 @zinosama

@excpt @ab320012 any advice on how to push this forward?

This looks good to me also. I made a change to the key loader and I'd also like to see this rolled into the next release with both our changes.
See #348

thanks @bdewater for the approval.


"Closing the application" window does not get closed

More infor:
Either an error is raised but not caught in the shutdown request immediately before window.close in default.js:
httpGetWallet("shutdown");
shutDownWindow.close();
...or that the variable isn't set to null in main.js because mainWindow.on('closed'... is not being raised correctly etc.
Will look at this today.

This can be fixed by wrapping the call in a try catch:
try {
httpGetWallet("shutdown");
}
catch(e){
}
I have tested this and it works with the gui shutting down as expected.
I suspect that the call to Global.WalletWrapper.EndAsync(); in startup.cs is the cause.
Will investigate further as it would be nice to fix the cause not just handle the error.

Changing httpGetWallet("shutdown"); to httpGetWalletAsync("shutdown"); fixes the issue.
In the controller 'shutdown' is marked as async.


Bump RxAndroid version in dependency list to v. 1.1.0 in code samples

Solved in https://github.com/pwittchen/ReactiveBeacons/commit/6f59c0deb4b867666b500d831d8c38f426f4b40e.


[stable/mediawiki] disable https port by default

What this PR does / why we need it:
Unless you are terminating SSL inside the pod, this is not needed. Most people will terminate SSL at the ingress, be it a LoadBalancer, Istio, or some other Ingress.
Which issue this PR fixes

fixes #18087

Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[x] DCO signed
[ ] Chart Version bumped
[x] Variables are documented in the README.md
[x] Title of the PR starts with chart name (e.g. [stable/chart])

@nesl247
Would you mind to bump the chart to the latest version please? Thank you.

Thanks for the contribution, before continue, you should increment the chart version in the Chart.yml according to semver:

Given a version number MAJOR.MINOR.PATCH, increment the:

MAJOR version when you make incompatible API changes,
MINOR version when you add functionality in a backwards-compatible manner, and
PATCH version when you make backwards-compatible bug fixes.
Additional labels for pre-release and build metadata are available as extensions to the MAJOR.MINOR.PATCH format.

In this case a minor bump can be fine.

Hi,
I've bumped the chart as requested. I hadn't done so originally as I wasn't sure if the change would have been accepted as it was.

/ok-to-test

/lgtm


Implement sparse matrix operations

Referring to https://groups.google.com/forum/#!msg/nd4j/YAgumxCwc7k/OHE7T6CCW9AJ, there should be a sparse matrix implementation supporting (all) matrix operations.
Just adding this as an issue to keep track.

Wanted to address this: This will be on a backend basis. Need to get the scaffolding for it in place, but we could likely support this in:
opencl
java
cuda
I'm going to have to add some additional layers to the api for this.

Talking with some other folks, it is likely we are going to add sparse matrix operations next. I'm seeing this be possibly a breeze backend as the primary benefactor of this.

So the apace spark community is looking for another linear algebra library to wrap around, for their linear algebra operations. This issue is one of the criteria

license
sparse support
performance
Java compatibility

So here's where I'm at. We'd fit the bill. The only thing we need to be able to do is add it at the api level.
Read:
INDArray arr = Nd4j.createSparse
and then pick 1 or 2 backends to implement sparse ops. Try pitching it to them and see what they think.
Our main reason for existing is swappable chips and the like anyways (while being able to optimize in isolation.

There is also JOCL which I am currently implementing which takes away most of the arguments. In fact, it could fit the bill for what you are looking for. I have created a fairly fast CSC matrix and dot product with it. Please consider.

@asevans48 Is it general purpose though? I'd be looking for something equivalent to a cusparse, not something half baked with only 1 algorithm ;/

Hello, Adam @agibsonccc.
Lately we at Apache Flink started the discussion about integration of Flink with DL4J.
During analysis we have found the following issue: FLINK-5782:  Support GPU calculations.
Shortly speaking it means: we would like to use ND4J as math library, supporting GPU, but we need the following issues to be covered in it:

ND4J doesn’t support sparse matrixes.
It’s impossible for now programmatically configure ND4J to use currently for calculations CPU or GPU, to switch you need to take another library. But we need to switch between this resources when they are available.
Flink manages consumed memory and performs spill on the disk, when memory is not enough. But ND4J allocates offheap memory also, and this cases incorrect memory assessment for Flink process. It seems that ND4J should provide some API to get information how much memory was already allocated.
So, as you can see, we need some help from the side of DL4J/ND4J community.
Could we solve these issues in ND4J?

Related to #https://github.com/deeplearning4j/deeplearning4j/issues/1831

This is being worked on this summer (including sparse cuda and sparse cpu native routines).
Yes you technically use a backend: http://nd4j.org/backend.html . You can have multiple backends on the classpath now and it will usually automatically pick whatever is available to it for a job. Admittedly this isn't a well tested scenario (we typically just include 1 needed backend). If you have a particular scenario we are happy to talk about it though.
We use javacpp for this (we maintain this as well) which the mahout project also uses. Javacpp itself obeys heap space, see: https://deeplearning4j.org/spark#memory1

For both backends we know amount of RAM/vRAM being used. However in case of CUDA it's bit of vague due to optional memory reuse mechanics.

Thank you, guys.
Regarding 1 -> could you please suppose how long this implementation could take?
Regarding 2 -> I will check the integration scenario closer in Flink.
Regarding 3-> >>However in case of CUDA it's bit of vague due to optional memory reuse mechanics. How currently is this managed?

There's configurable options that allow you tweak different aspects of CUDA backend, and switch between direct allocation & memory reuse available as well. However, memory reuse is mostly suited for cyclic workloads, like model training. So if your workload isn't cyclic - you don't need cache anyway :)

1 -> No comment. We just don't know.
2 -> For flink it should be the exact same mechanics.
3 -> We typically pre allocate our own memory. You can see the implementation for the memory management here:https://github.com/deeplearning4j/nd4j/tree/master/nd4j-backends/nd4j-backend-impls/nd4j-cuda/src/main/java/org/nd4j/jita/allocator

We have an "early" version of this merged with basic blas support via mkl and cusparse with indexing working. https://github.com/deeplearning4j/nd4j/pull/1711

When will the next release containing this enhancement be done? Is it possible to get an up-to-date snapshot release meanwhile?

Sorry, we’re not announcing public release dates
Yes, we’re working on snapshots atm. However, you should be still able to build everything from sources, since that’s just CPU backend.

28 сент. 2017 г., в 14:05, Gunnar Völkel<EMAIL_ADDRESS>написал(а):
When will the next release containing this enhancement be done? Is it possible to get an up-to-date snapshot release meanwhile?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub https://github.com/deeplearning4j/nd4j/issues/66#issuecomment-332803675, or mute the thread https://github.com/notifications/unsubscribe-auth/ALru_7Ow6Tfwy2KlOzNi2UGEcEg4MAkAks5sm32OgaJpZM4D9E4a.


VS Code 1.66 requires GLIBC 2.25 on RHEL 7

VS Code version: code-1.66.0-1648620680
OS: Red Hat Enterprise Linux 7.9
Running yum update on RHEL 7 produces an error:
Error: Package: code-1.66.0-1648620680.el7.x86_64 (code)
Requires: libc.so.6(GLIBC_2.25)(64bit)
According to https://code.visualstudio.com/docs/supporting/requirements the required version of GLIBC is 2.15 or later.
Red Hat Enterprise Linux 7 uses GLIBC 2.17.

Just ran into this when trying to upgrade this moring.

I also ran into this problem trying to install today

cc @deepak1556 @rzhao271

can confirm as well.
There finally needs to be a pipeline that checks RHEL/CentOS 7 comptability. This is a very important stable developer OS with support until 2024.
We went through this with the false electron update a while back and now this silently broke again.

Same problem here:
yum update -y code                                                                                 50.54 Dur  18:39:25
Loaded plugins: enabled_repos_upload, langpacks, package_upload, product-id, search-disabled-repos, subscription-manager
rhel-7-server-extras-rpms                                                                                | 2.0 kB  00:00:00
rhel-7-server-optional-rpms                                                                                | 2.0 kB  00:00:00
rhel-7-server-rpms                                                                                | 2.0 kB  00:00:00
rhel-7-server-satellite-tools-6.7-rpms                                                                                | 2.1 kB  00:00:00
rhel-server-rhscl-7-rpms                                                                                | 2.0 kB  00:00:00
Resolving Dependencies
--> Running transaction check
---> Package code.x86_64 0:1.65.2-1646927812.el7 will be updated
---> Package code.x86_64 0:1.66.0-1648620680.el7 will be an update
--> Processing Dependency: libc.so.6(GLIBC_2.25)(64bit) for package: code-1.66.0-1648620680.el7.x86_64
--> Finished Dependency Resolution
Error: Package: code-1.66.0-1648620680.el7.x86_64 (code)
Requires: libc.so.6(GLIBC_2.25)(64bit)

Dependency resolving failed due to missing dependencies.
Some repositories on your system are disabled, but yum can enable them
and search for missing dependencies. This will require downloading
metadata for disabled repositories and may take some time and traffic.

rhel-7-server-supplementary-rpms/x86_64                                                                                | 2.0 kB  00:00:00
rhel-7-server-ansible-2-rpms/x86_64                                                                                | 2.4 kB  00:00:00
rhel-7-server-satellite-tools-6.6-rpms/x86_64                                                                                | 2.1 kB  00:00:00
rhel-7-server-rh-common-rpms/x86_64                                                                                | 2.1 kB  00:00:00
--> Running transaction check
---> Package code.x86_64 0:1.66.0-1648620680.el7 will be an update
--> Processing Dependency: libc.so.6(GLIBC_2.25)(64bit) for package: code-1.66.0-1648620680.el7.x86_64
--> Finished Dependency Resolution
Error: Package: code-1.66.0-1648620680.el7.x86_64 (code)
Requires: libc.so.6(GLIBC_2.25)(64bit)
You could try using --skip-broken to work around the problem
You could try running: rpm -Va --nofiles --nodigest
Uploading Enabled Repositories Report
Loaded plugins: langpacks, product-id, subscription-manager
Time: 0h:00m:11s

It it possible this issue would also cause the vscode remote server to fail to start inside a rhel 7 container? I can no longer use the "clone in container" option with a project using a rhel7 base image.

@chriscasola it is unrelated, please open a separate issue for it at https://github.com/microsoft/vscode-remote-release/issues to investigate further, thanks!

Just an update on the issue, it is not caused by electron update. Rather with 1.66 we automated the process of how the package dependencies are generated as part of our build pipeline https://github.com/microsoft/vscode/issues/17142, which now generates the right set of dependencies for all the native modules and binaries shipped with the package. The current GLIBC_2.25 requirement was generated from one our native module dependency and this modules dependency has not changed for a while now, basically we were previously shipping with an incorrect dependency list which was now caught.
Although we had a test plan item for verifying this new process https://github.com/microsoft/vscode/issues/145608, we had missed to verify on CentOS 7. Sorry about the update breakage!

thank you for the update! Is there an ETA for a fix?
This is currently causing a lot of stir because regular updates now fail without the --skip-broken option.

Verification steps on CentOS 7:

Download latest rpm from https://code.visualstudio.com/insiders/#linux
rpm -ivh <rpm-file>
Launch the application and login to settings sync
Ensure the credentials are encrypted in the system keystore for key starting with vscode-insiders-

This still does not allow installation:
rpm -ivh code-insiders-1.67.0-1649050674.el7.x86_64.rpm  error: Failed dependencies: 	libc.so.6(GLIBC_2.25)(64bit) is needed by code-insiders-1.67.0-1649050674.el7.x86_64
sudo yum install code Loaded plugins: langpacks, versionlock Resolving Dependencies --> Running transaction check ---> Package code.x86_64 0:1.66.0-1648620680.el7 will be installed --> Processing Dependency: libc.so.6(GLIBC_2.25)(64bit) for package: code-1.66.0-1648620680.el7.x86_64 --> Finished Dependency Resolution Error: Package: code-1.66.0-1648620680.el7.x86_64 (code)            Requires: libc.so.6(GLIBC_2.25)(64bit)  You could try using --skip-broken to work around the problem  You could try running: rpm -Va --nofiles --nodigest

Insiders with the fix has not been released yet, it will be notified in this thread once the builds are available.

I have the same problem and I could not install VSCode 1.66 on centos 7.

Looks good to me, RHEL 7.9 with the insider build via standard install.
Workaround: rpm -Uvh --nodeps <vscode rpm>.

Succesfully installed code-insiders-1.67.0-1649156474.el7.x86_64.rpm on RHEL 7.
/verified

@deepak1556 so is this issue fixed?

I'm not familiar with vscode release procedures... What is the timeline for getting the fixed build pushed to Stable?  Just wondering when we should expect our production systems to see the update.

To learn more about our recovery releases please read this wiki post https://github.com/microsoft/vscode/wiki/Running-the-Endgame#recovery-build
To understand our development process better please check this out https://github.com/microsoft/vscode/wiki/Development-Process
This fix should be in stable either tomorrow, or early next week. So in the next 6 days.
In the meantime please use the vscode insiders build if you are blocked, it has the fix. Thanks


fcp_xml adapter doesn't seem to export offline/unreferenced clips correctly

When exporting an XML with offline/unreferenced clips, OTIO should provide all tags needed to recreate those clips in an application even though some tags remain "empty". Currently the _build_clip_item_without_media function doesn't include the <name>, <duration>, <pathurl> and <timecode> tags in the <clipitem> -> <file> tag which results in the clip not getting created.
I like the explicitness of a call to _build_clip_item_without_media, but is it really necessary to differentiate the creation of an "online" or "offline" clip other than the <pathurl> being empty?  All other data should be in place if it's a clip placed in a timeline should it not?
Please note that I only tested import of such an XML in Hiero.

@bashesenaxis Do you have any thoughts on this?

The idea behind _build_clip_item_without_media is that it deals with title objects. So they would never have any media.
For example:
https://github.com/PixarAnimationStudios/OpenTimelineIO/blob/master/tests/sample_data/premiere_example.xml#L688
In this case, <clipitem> -> <file> -> <name> is identical to <clipitem> -> <name>, the <duration> wouldn't have any meaningful information and there would not be a <parthurl> associated with it either.
I am not entirely sure whether this is a premiere specific way of doing things.

Closing this one as it's really old and I haven't had use for this since the hiero plugin came to life.
Feel free to reopen if someone finds it useful.


Wav2Vec 2: Data for training a new model

Hi,
Is it necessary that each speech audio file in training dataset contains only one speaker?
Thanks.

No, but they should be separated without overlapping. But you would need more material if finetuning.

Thank you for your answer. So what are the requirements  for constructing a new training dataset?

Check the paper to see what material they used. And it depends on your use case. If you want to transcribe phone calls, I wouldn't take spotless training files :-)


Running dev server instructions assume you have Grunt installed

sudo npm install -g grunt -cli should be added to the instructions for those that don't currently have Grunt!
Also, once I try to run Grunt, I'm faced with a pretty tragic Node error :( that's like, some kind of C level issue, solved here:
https://github.com/nodejs/node/issues/10659#issuecomment-270927364
This updated package.json.
Going to possibly keep adding things to this issue just to get up and running with devise-token-auth!

@lynndylanhurley which version of Node was this package originally created with?
I'm realizing now it's pre React 16 so we can't just seamlessly update the versions of everything (big work there), so I wanted to try to install and run this package with older versions....but Node v0.10.48 throws a bunch of errors for me.

Working on this now. I'll get you an ETA later today.

Thank you!

@zachfeldman sorry for the delay.  Can you please try one more time?

We have liftoff!