fix(scan): update Scan function to reset structs to zero values for each scan

[x] Do only one thing
[x] Non breaking API changes
[x] Tested

What did this pull request do?
Addresses #6819
Adding the else condition to use the base type when data is nil ensures that the struct field is always set by the scanIntoStructMethod
User Case Description
It fixes the example from the docs where you initialize the var once:
    var datasetRow T
    for rows.Next() {
        err := db.ScanRows(rows, &datasetRow)

This code will overwrite every type of field except for embedded pointer type structs.
It is difficult to determine whether or not that field should be reset to nil since if user is selecting a field i.e. NULL AS embedded_ptr_struct_int_field then the field should be initialized with its zero value but that would make a breaking change

@jinzhu any concerns with this PR?

@a631807682

the PR is because there is a breaking change in v1.24.6, for example if User is scanned 1 time, then the next scan if there is a Ptr field but the value from the db is null, the scan skips the field. Meaning User2 still has User1 data. This is because now for each row scan all values are not being reset.

var user User
for rows.Next() {
  // ScanRows scan a row into user
  db.ScanRows(rows, &user)

  // do something
}

I am not sure what you mean?

I cannot reset an embedded ptr struct to nil because THAT would be a breaking change for gorm, we instead want to have only the values reset not the embedded ptr structs

@a631807682 I expanded the test to also have your example, thank you for sharing that!
Here is the output that we expect for the scan when db returns nulls for all the scanned columns:
{
    BoolField:false
    IntField:0
    Int8Field:0
    Int16Field:0
    Int32Field:0
    Int64Field:0
    UIntField:0
    UInt8Field:0
    UInt16Field:0
    UInt32Field:0
    UInt64Field:0
    Float32Field:0
    Float64Field:0
    StringField:""
    TimeField:0001-01-01 00:00:00 +0000 UTC
    TimePtrField:<nil>
    EmbeddedStruct:{EmbeddedIntField:0 NestedEmbeddedStruct:{NestedEmbeddedIntField:0 NestedEmbeddedIntFieldWithDefault:2}}
    EmbeddedPtrStruct:<nil>
}

@a631807682

the PR is because there is a breaking change in v1.24.6, for example if User is scanned 1 time, then the next scan if there is a Ptr field but the value from the db is null, the scan skips the field. Meaning User2 still has User1 data. This is because now for each row scan all values are not being reset.

var user User
for rows.Next() {
  // ScanRows scan a row into user
  db.ScanRows(rows, &user)

  // do something
}

I am not sure what you mean?

My question is why User2 is not empty time, but the default value?
Can we reset reflect value like ?

	...
	// reset if type struct ...
	db.Statement.ReflectValue.Set(reflect.Zero(reflectValue.Type()))
    ...
	db.scanIntoStruct(...)

@a631807682

the PR is because there is a breaking change in v1.24.6, for example if User is scanned 1 time, then the next scan if there is a Ptr field but the value from the db is null, the scan skips the field. Meaning User2 still has User1 data. This is because now for each row scan all values are not being reset.

var user User
for rows.Next() {
  // ScanRows scan a row into user
  db.ScanRows(rows, &user)

  // do something
}

I am not sure what you mean?

My question is why User2 is not empty time, but the default value?
Can we reset reflect value like this?

	...
	// reset if type struct ...
	db.Statement.ReflectValue.Set(reflect.Zero(reflectValue.Type()))
    ...
	db.scanIntoStruct(...)

Maybe it would be clear if I explained my usage. I query a table for all of my user data and then I iterate through to format and save into an excel report. Before v1.24.6,  I used the golang code from the gorm docs to allow me to have 1 instance of the var that is just reused instead of allocating memory per row scan. I noticed my tests breaking when updating gorm because of the behavior change. For each scan the struct should start as default and then scan in the value from the db if there is one. The User2 data was not reset for me for the time.Time fields due to the database value being NULL and the User1 having data. Please let me know if that is a bit clearer. Thanks

I will try that

The User2 data was not reset for me for the time.Time fields due to the database value being NULL and the User1 having data

I understand that the User2 time field needs to be reset, I am sure this is a bug, my question is why do we need to reset to defalut value instead of zero value?

The User2 data was not reset for me for the time.Time fields due to the database value being NULL and the User1 having data

I understand that the User2 time field needs to be reset, I am sure this is a bug, my question is why do we need to reset to defalut value instead of zero value?

@a631807682 Ah just got what you meant now, updated the logic to reset to the zero values. I originally had that but was not aware of the default value annotation and thought the DefaultValueInterface was how gorm was referring to zero values. I applied your solution and my test passes locally I think the tests are broken in places outside my change?

@a631807682 @jinzhu I accidentally closed this PR, but wanted to grab your thoughts about the commit: f0f01b1 (before the last one). Am I correct in using: mode == ScanInitialized to ensure the update and conflict modes are not impacted? This isn't breaking any functionality according to the tests, but I would like to double check since you may be aware of more context that I am not here. The last commit was just for me to see if I broke the tests or they were already broken in the master branch for GORM. Appreciate your time!

@a631807682 just looking for your insight on the commit f0f01b1, is that solution sound? If it is I will reopen an MR, just want to have the full context in this MR. So you can refer to the history easily. Thanks

@a631807682 just looking for your insight on the commit https://github.com/go-gorm/gorm/commit/f0f01b115610a16b9ef55031eeb3909719c2559e, is that solution sound? If it is I will reopen an MR, just want to have the full context in this MR. So you can refer to the history easily. Thanks

@a631807682 just looking for your insight on the commit f0f01b1, is that solution sound? If it is I will reopen an MR, just want to have the full context in this MR. So you can refer to the history easily. Thanks

LGTM


update="append" not working for vis.scatter

Hi there!
I am running the following commands, but the update part doesn't show the scatter points for (Xc_tsne, Xc_tgt).
vis.scatter(X_tsne, (X_tgt+1)/(X_tgt+1),win="1")
vis.scatter(Xc_tsne, Xc_tgt+1, win="1", update="append")

Hi @IssamLaradji, can you provide more details -  What appears in the server logs? Have you installed from source or are you running on the pip version? What are the dimensions for these arrays?
I am able to use both types of scatter appends as demonstrated in the demo here through line 382: https://github.com/facebookresearch/visdom/blob/ec91e738e100a9cbf946c332c7783ffd12c644b5/example/demo.py#L351 The first appends a new trace, the second adds data to both traces.


Allow strict_version entries

strict_version helps to restrict the version bumps to exact "= major.minor.patch" .
This is useful when you depend on packages that don't always follow the semver and you want automated test+bump for each release.
Only the Entries of format PkgName = "= a.m.x" are bumped to PkgName = "= b.n.y", whenever bump_compat_containing_equality_specifier=true and strict_version=true, while the rest go through usual bump.

Waiting for status to be reported - which status is being expected here?

I might be misunderstanding this feature, but I don't think this makes sense to include in CompatHelper.
The goal of CompatHelper is to notify package authors about breaking releases of

I want the versions in MyPkg to be bumped but something like PkgA = "= 0.3.0" be bumped to PkgA = "= 0.3.1" or PkgA = "= 0.4.0" ... i. e retain the {equals sign MAJOR.Minor.patch} in Project.toml compat entry
Currently If I've PkgA = "= 0.3.0" & bump_compat_containing_equality_specifier=true, it bumps to PkgA = "0.4" & drops = sign.

It's been a couple years since this PR was first opened. When it was first opened, I was opposed to this feature. Since then, however, I've been thinking about it some more, and now I'm in favor of adding this feature.
It does look like we'll have to rebase and fix a lot of merge conflicts, or recreate the branch from scratch.


help

Hi sir
My friend is having some problem while deploying his project on heroku.
His app works fine on the localhost. But gives permission denied errno13.
He has tried using chmod chown command and every thing else he found on
the internet.  It would be of great help if u  could help him .
please

@Abdul24-code Is your friend trying to deploy this project on heroku? I am not familiar with heroku. My advice is to post the whole error and maybe the whole project on some heroku discussion forum for help.
p/s: I will be removing this issue soon since it it irrelavant to the project. Good luck


NIFI-8021: Fixed bug in ConsumeKafka_2_* and ConsumeKafkaRecord_2_* where explicit partition assignment causes issues with more than 1 concurrent task. Also fixed bug that prevented more nifi nodes than partitions because it didn't properly handle empty string for the list of partitions

Thank you for submitting a contribution to Apache NiFi.
Please provide a short description of the PR here:
Description of PR
Enables X functionality; fixes bug NIFI-YYYY.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:

[ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?

[ ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

[ ] Has your PR been rebased against the latest commit within the target branch (typically main)?

[ ] Is your initial contribution a single, squashed commit? Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not squash or use --force when pushing to allow for clean monitoring of changes.

For code changes:

[ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
[ ] Have you written or updated unit tests to verify your changes?
[ ] Have you verified that the full build is successful on JDK 8?
[ ] Have you verified that the full build is successful on JDK 11?
[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
[ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
[ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

[ ] Have you ensured that format looks appropriate for the output in which it is rendered?

Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI for build issues and submit an update to your PR as soon as possible.

Of note, I created this PR using two separate commits: the first to update *2_0 processors, the other to update *2_6 processors. I did this in case the fix needs to be backported to any previous version that didn't have the *2_6 processors. So it may make sense to merge the two commits into main instead of squashing them.

Of note, I created this PR using two separate commits: the first to update *2_0 processors, the other to update *2_6 processors. I did this in case the fix needs to be backported to any previous version that didn't have the *2_6 processors. So it may make sense to merge the two commits into main instead of squashing them.

Merged to main with two separate commits, thanks @markap14

Merged to main with two separate commits, thanks @markap14


Upgrade CertHandler to use TLS certificates v4

Enhancement Proposal
There is a brand new version of the tls_certificates lib with Python API changes.
We should investigate how to modify CertHandler in order to use that new lib version.

TLS Lib v4 automatically takes care of:

Private key management
CSR creation
Certificate request and renewals

It should render CertHandler unnecessary at this point.


Ajax setup

User story

As a developer
I want / need to setup ajax
In order to implement it as web socket

Acceptance criteria

Test and implement Ajax for setting up as web socket

Definition of done

Added only after week 5
The same for all features

scraped


Excessive CPU usage (~3.3%)

(Transcluded from the issue I erroneously opened on the mainline FanControl repo)
Describe the bug
With the ADLX plugin and a fairly regular fan curve, FanControl perpetually sits at roughly 3.3% of CPU usage (with 12 logical processors in the system). A quick peek into Process Hacker reveals that 2 threads are responsible for most of that usage, the TIDs of which change all the time. Frequent termination and spawning of threads can also be seen.

Additionally, as per Process Hacker's statistics, roughly ⅔ of all the CPU time of the process is being spent in kernel mode.
Is there a log.txt file next to FanControl.exe with recent date entries?
Nope.
Relevant hardware specs and setup

CPU: AMD Ryzen 5 3600
GPU (only device whose fan is being controlled): AMD Radeon RX 6600

@mordang7, just as a heads up, MSI Afterburner is a decent temporary alternative for controlling the temperature at which Zero RPM is engaged. The following setup works quite well for me, at a much smaller CPU cost than FanControl.ADLX:

@Rem0o Thank you for your reply and explanation, I really appreciate it! I am no expert, not by a mile actually. If you want me to test any betas, or need more information let me know and I'll help as much as I can.

https://github.com/Rem0o/FanControl.ADLX/releases/tag/V0.1


generate-sas generate useless SAS if permission and expiry are not given.

The only required parameters in blob generate-sas command are container name and blob name. When other parameters are omitted, the result is useless. The SAS token can do nothing because neither permission or expiry are represented in the token.
Recommendation, have default permission or expiry set to the token.

Talk to the folks in storage because I believe you can generate a SAS token using an ACL entry, in which case the expiry and permissions may be tied to that.

If you specify --policy-name you can link to a stored access policy which can already have set permissions and/or expiry. Perhaps we should have a validator that either the policy or the other things are specified... although I believe you could point to a SAP that DOESN'T specify those things and would still have to provide them.

Cleaning u old issues, reopen if this is still active.


Make rust emitted code compatible with Rev A Playdate hardware

Hi there! I've been working on a Playdate game in rust for the last 9 months using crankstart. Thanks for all the work on this project which has made that possible! I have a bunch of changes to both crankstart and crank, some of which are probably useful to others, so I'm planning to start sending some back upstream. Here's the first! Changelog below:
--
The FPU settings for C code are -mfpu=fpv5-sp-d16, the -sp- part means that double precision floating point is unsupported. The rust docs show that getting this same effect from rustc-emitted code requires this additional target feature. Note that at the moment this produces a warning that this target flag is unstable.
Without this, I was getting "undefined instruction" errors for f64 instructions on the original Playdate hardware, with this change it seems to be resolved.

Hey @boozook are you interested in getting something like this merged?

Wow, I've just added same as note in the wiki at same moment. I'll fix it in the cargo-playdate soon, but if you want do it yourself, it could be great.

Sorry, I'm not sure what you're saying. You don't want to make this change to this repo, you want me to do it in here instead? Is crankstart/crank deprecated/unmaintained now?

I apologize for my crooked lang. I passively support and review pull-requests this repository. I also plan to make a similar fix in my main project in the near future. But if you want to do PR there, that would be great.

Got it, thanks for merging! I can make a PR there.

Thank you so much!


Api endpoint for OMIS dataset

Description of change
Adds new app datasets
Adds an api endpoint for OMIS dataset under datasets app (/v4/datasets/omis-dataset)
Adds new HAWK credentials for authenticating with data-flow-api
Adds new HAWK scope for data-flow-api
Checklist

[ ] Has a new newsfragment been created? Check changelog/README.rst for instructions
[x ] Do any added or updated endpoints appear in the API documentation? See docs/Maintaining the API documentation.md for more details
[ ] Have any relevant search models been updated?
[ ] Have any relevant fixtures (fixtures/test_data.yaml) been updated?
[ ] Have any relevant select-/prefetch-related field lists in the views and search apps been updated?
[ ] Has the admin site been updated (for new models, fields etc.)?
[ ] Has the README been updated (if needed)?

Missing tests.

@yusufertekin You may have seen already but there are some Flake8 failures in the CI build.
Have a look through https://github.com/uktrade/data-hub-leeloo/blob/develop/docs/Code review guidelines.md and https://github.com/uktrade/data-hub-leeloo/tree/develop/changelog as well.
A couple of points from those:

the commit message should start with a verb and read like an instruction e.g. 'Add endpoint for...'
a news fragment should be added

Addressed comments, and created another PR request with conventional branch naming
https://github.com/uktrade/data-hub-leeloo/pull/2001


#question: x11docker on bare server (no "ServerGUI")

#01 Can x11docker  run on Unix servers without X11 (running) ?
Context: "An X server. Probably already installed." on https://github.com/mviereck/x11docker/wiki/Dependencies
Looking to use x11docker to run graphical applications on a bare, remote Ubuntu server and to access them remotely.
In the spirit of avoiding the risks outlined here https://help.ubuntu.com/community/ServerGUI am thinking it would be best to not install X11 on host.
But then the dependencies wiki page suggests X11 packages must be installed on the host. Must also have X11 started or just installed? If must run then how to think about the risks to the host outlined in the link above?
#02 How good would be the graphical quality given that the servers have poor graphical hardware. Asking by comparison with virtualbox which simulates the graphics and can provide high resolution even for low resolution cards.
#03  In terms of remote access, this VNC image https://github.com/mviereck/x11docker/wiki/VNC says "x11docker would not be required at all".
That sounds a bit confusing: VNC is for remote access but x11docker is has many other features.
VNC gives advantages over ssh https://github.com/mviereck/x11docker/wiki/Remote-access-with-SSH because one can leave containers running and re-connect.
Also, am looking to run Docker containers using "contexts" as per https://www.docker.com/blog/how-to-deploy-on-remote-docker-hosts-with-docker-compose/ and starting a container over ssh would ... conflict with that.
Such control over lifespan of remote container is critical in complex development / troubleshooting where multiple containers may need to be composed.
Did not see a VNC docker image and feel am missing something... :thinking:
Please advise (one question at a time, as you can afford).

#01 Can x11docker run on Unix servers without X11 (running) ?

X clients always need an X server. The only way I see to have no X server on the server is to run ssh -X x11docker --hostdisplay. This way you use the X server of your client system.

In the spirit of avoiding the risks outlined here https://help.ubuntu.com/community/ServerGUI am thinking it would be best to not install X11 on host.

Beside Xorg (package xorg) there are other possible X servers. xpra can use Xvfb o Xdummy, VNC normally uses Xvfb, too.
I see several risks if you install a full desktop environment with several "services" as outlined in the article. I'd say an X server on its own is less an issue. However, multiple X applications running on the same X server can spy and control each other.

Must also have X11 started or just installed?

x11docker runs the X server on its own, it does not need to run beforehand. However, nested X servers like Xephyr need an already running X environment or ssh -X. One possible setup is to run x11docker with --xvfb and access this with xpra.

#02 How good would be the graphical quality given that the servers have poor graphical hardware. Asking by comparison with virtualbox which simulates the graphics and can provide high resolution even for low resolution cards.

Most setups use software rendering / CPU only. You can specify an arbitrary display size. Setups using a GPU are possible, but need more manual setup.

VNC gives advantages over ssh https://github.com/mviereck/x11docker/wiki/Remote-access-with-SSH because one can leave containers running and re-connect.

I prefer xpra to allow re-connection. I am less familiar with VNC. However, it has xorg-xserver-core in its dependency chain although it could run with Xvfb only. Providing a dummy package replacing xserver-xorg-video-dummy could be a workaround to use xpra without installing xorg.

Did not see a VNC docker image and feel am missing something... thinking

There is no VNC image. In fact, I barely tested VNC setups at all.

#03 In terms of remote access, this VNC image https://github.com/mviereck/x11docker/wiki/VNC says "x11docker would not be required at all".
That sounds a bit confusing: VNC is for remote access but x11docker is has many other features.

That could be explained better, yes.
x11docker runs an X server on host and provides X access to the container.
Alternatively, you can run VNC or xpra server inside the container. In that case the X server runs in the container, too.
x11docker is not needed but still possible to run the container. You can run x11docker with option --tty to start no X server on host. Instead, you set up the container that it starts VNC or xpra itself.
Overall, I see two ways for detachable setups:

Set up xpra or VNC in the container and run it with x11docker option --tty.  No X server on the server, but needs additional packages and setup in the container.
Install Xvfb and one of xpra or VNC on the server. This way you have an X server on the server (but not Xorg). Run x11docker with --xvfb and access the X display afterwards with xpra or VNC

You can also run VNC with its own X server and run x11docker --hostdisplay as a VNC client.

I hope my answer is not confusing. Feel free to ask further.

This definitely got to be added to docs.

Thanks. this helps.

"I'd say an X server on its own is less an issue."

How to think when comparing having virtualbox for all users vs individual x11dockers ?

nested X servers like Xephyr need an already running X environment or ssh -X.

Hmm... not an expert in X stuff so am having a hard time understanding this "or".
Wip on studying and experimenting with https://github.com/mviereck/x11docker/wiki/Remote-access-with-SSH and https://github.com/mviereck/x11docker/wiki/Short-setups-to-provide-X-display-to-container which are very rich, thank you.
If I am supposed to understand then above from those articles then will dig.
Extra hints always appreciated.

you can run VNC or xpra server inside the container. In that case the X server runs in the container, too.
x11docker is not needed but still possible to run the container.

Would this not avoid having to install X and having it stared on the host ?

Set up xpra or VNC in the container and run it with x11docker option --tty. No X server on the server host system, but needs additional packages and setup in the container.

This sounds attractive!
If possible not to have an X server running outside containers (on the host) then how come this is not documented? :-)
Again from security POV it would be great to have all this X stuff run from Docker so that we/I could control external access at network level. I have OpenVPN  setup and looking to have X/VNC traffic just in the VPN virtual network and none on the main network. This would be a decent way to mitigate the risks from "ServerGUI" above, no?
If agreeable that it is, then may I bug you for some help to implement this deployment mode ?

If possible not to have an X server running outside containers (on the host) then how come this is not documented?

Originally x11docker was intended run run GUIs in container visible on a local system.
Running an invisible X server (along with VNC or xpra) in a container possible, but not part of x11docker. You have to set up X in container yourself.
x11docker can still be useful in this picture with some features like container user setup.

(How would that work: have a dedicated container with X running and docker-compose with? thinking )

Possible in general. However, if more than one container accesses this X server, they could spy and control each other. It would be simpler to have a base image with an X server setup and build other images upon it.

This would be a decent way to mitigate the risks from "ServerGUI" above, no?

Yes, of course.

If so, then may I bug you for some help to implement this deployment mode ?

You're welcome.
My attempt would be to create a base image with VNC or xpra. Build images with desired applications based on this VNC/xpra image. Let VNC/xpra run the desired applications.
A dedicated VNC/xpra image is possible, too. I would run one instance per desired container. However, I am not familiar with setups where containers communicate with each other. Not sure how to share an X unix socket across containers. Alternatively, an X TCP setup is possible, but discouraged by X developers.

Just for refererence: Similar setups, but with focus on GPU support: #197 #199

Thanks.
Still parsing a few things out about about how x11docker and this other image (or container) would work together.

x11docker can still be useful in this picture

Does this look close to what you are thinking ?
https://github.com/retog/docker-x11-xpra

Does this look close to what you are thinking ?

Yes, sort of. Sorry for my late response.
Basically I'd recommend that you first try a setup with VNC or xpra on host until it works and you are satisfied.
Than do the same in a container and look where it fails. Likely you have to do some port forwarding, but not more than that.
I am not sure if x11docker will be a great help here. It might make more sense to look which of its features would be helpful for you, and than implement them yourself. I think, container user setup and privilege restrictions are most of interest. The wiki already gives some hints. If you know which features you need and you get stuck, just ask me.


Agora keeps sending pre-images to Stoa

I'm seeing this in Stoa's log after fixing bpfk/stoa#164:
Nov 04 06:28:38 eu-002 docker[8094]: [Stoa] 2020-11-04T06:28:38.960Z info Saved a pre-image enroll_key : 0xdb3931bd87d2cea0, hash : 0xbb10e5050a2d0acd, distance : 6
Nov 04 06:28:44 eu-002 docker[8094]: [Stoa] 2020-11-04T06:28:44.975Z info Saved a pre-image enroll_key : 0xb20da9cfbda971f3, hash : 0x7b78dd8534d0b964, distance : 6
Nov 04 06:28:48 eu-002 docker[8094]: [Stoa] 2020-11-04T06:28:48.966Z info Saved a pre-image enroll_key : 0xdb3931bd87d2cea0, hash : 0xbb10e5050a2d0acd, distance : 6
Nov 04 06:28:54 eu-002 docker[8094]: [Stoa] 2020-11-04T06:28:54.975Z info Saved a pre-image enroll_key : 0xb20da9cfbda971f3, hash : 0x7b78dd8534d0b964, distance : 6
Nov 04 06:28:58 eu-002 docker[8094]: [Stoa] 2020-11-04T06:28:58.962Z info Saved a pre-image enroll_key : 0xdb3931bd87d2cea0, hash : 0xbb10e5050a2d0acd, distance : 6
Nov 04 06:29:04 eu-002 docker[8094]: [Stoa] 2020-11-04T06:29:04.973Z info Saved a pre-image enroll_key : 0xb20da9cfbda971f3, hash : 0x7b78dd8534d0b964, distance : 6
Nov 04 06:29:08 eu-002 docker[8094]: [Stoa] 2020-11-04T06:29:08.962Z info Saved a pre-image enroll_key : 0xdb3931bd87d2cea0, hash : 0xbb10e5050a2d0acd, distance : 6

@Geod24 Are you aware of any doubts about this issue?
I tried debugging, but I can't find the exact cause.

I can still see it happening in the live system, yes.

This issue is caused by constantly sending a pre-image in the function 'checkRevealPreimage' of the Validator. The reason why it keeps sending it constantly is that there might be some nodes not having pre-images due to some reason like a network outage. But, it can be changed to not sending the pre-image if it's present in the ValidatorSet as follows. The 'getValidatorPreimageAtis not implemented but it could just call thegetPreimageAtfunction of theValidatorSet`.
private void checkRevealPreimage () @safe
{
    PreImageInfo preimage;
    if (**this.enroll_man.getValidatorPreimageAt(this.ledger.getBlockHeight() + 1)** &&
        this.enroll_man.getNextPreimage(preimage, this.ledger.getBlockHeight()))
    {
        this.enroll_man.addPreimage(preimage);
        this.network.sendPreimage(preimage);
        this.pushPreImage(preimage);
    }
}

Sorry for the late notice.
@TrustHenry Could we have a whiteboarding session at your desk or mine?

But, there are some points we need to check if the solution I described breaks test codes and whether it's right to send pre-image once the same way as sending a transaction.

The reason why it keeps sending it constantly is that there might be some nodes not having pre-images due to some reason like a network outage.

But why does it keep sending to Stoa ?
I guess we could also handle it on the Stoa side and make it ignore already-received pre-image (and other data).

https://github.com/bpfkorea/stoa/blob/485a7f6a0b7c79821fa5374c8e8e2a848f88ccd1/src/modules/storage/LedgerStorage.ts#L352-L367
When updating the image of the store, the distance must be greater than the current value.
I ignore anything else.
However, in this case, the message is also marked as saved.

However, in this case, the message is also marked as saved.

Then maybe we should do the sane thing and only output a message on update at info level... We can still output all http traffic at http level.

There are two agora in the live system.
Doesn't it seem like the pre-image is transmitting a lot because both of these agora send a pre-image?

I think we should maintain the feature a validator keeps sending pre-images because the situation where pre-images of validators are missing is very critical. This issue could lessen if we set the preimage_reveal_interval to a larger value like 30 seconds in the faucet live system. And this issue is already worked around by @TrustHenry in the PR.  So this issue can be closed in the current state, I think.

I think we should maintain the feature a validator keeps sending pre-images because the situation where pre-images of validators are missing is very critical. This issue could lessen if we set the preimage_reveal_interval to a larger value like 30 seconds in the faucet live system. And this issue has already been worked around by @TrustHenry in the PR.
So this issue could be closed in the current state, I think.

@Geod24 ping

@Geod24 Do you think this issue has been resolved?

We're blocked on Stoa working to actually test this.

We're blocked on Stoa working to actually test this.

Stoa is unblocked.

Stoa is unblocked.

Looks like this is solved.

Looks like this is solved.


RFC - Reserved names $

I feel that this is a good rule to follow: https://google.github.io/styleguide/angularjs-google-style.html#dollarsign
I think we should avoid using the dollar sign as it should be a framework level namespace.
What are your thoughts? Do you all agree or have issues?

i think this repo is abandoned.

$ is for angular services.
yes, it should be avoided. If interested, make a PR.

@johnpapa Would adding it within https://github.com/johnpapa/angular-styleguide/tree/master/a1#services work?  What section did you have in mind?

probably near here https://github.com/johnpapa/angular-styleguide/tree/master/a1#style-y125


feat(curriculum): add css lectures

Sorry this is so big, but I want to just try and add as many of these as I can. This adds all the lecture blocks and challenges + questions in the CSS chapter.
There's three lectures that haven't been written yet: 672aa58c389eb9565978495d, 672ab82c1a9bbd0e3aabc39d, and 672ab83c4297910eade53c2e - so we will need to come back and add those questions.
There was a number of times where I wasn't sure if text should be in backticks or not.
We will also need to come back and add all the video ID's when they are finished.
Checklist:

[x] I have read and followed the contribution guidelines.
[x] I have read and followed the how to open a pull request guide.
[x] My pull request targets the main branch of freeCodeCamp.
[x] I have tested these changes either locally on my machine, or GitPod.

Closes #XXXXX

Thanks for taking a look @jdwilkin4 👍 The issue with the backticks in titles is that the markdown isn't parsed - so they just show up as backticks. We would also need to parse the markdown in all the challenges where the title is displayed too. We haven't ever used backticks in the titles, maybe it's time to start - but I don't think we should add them here until that is added. It probably wouldn't be that hard to add, but there's a lot of other stuff to get done. Wondering if we should leave them for now and revisit it post-mvp.

Yeah, that sounds good.
I just left a few comments about rewording some of the titles and then this should be good to go 👍

I added those three challenges to the project board.


What license is this project under?

Hi,
Could you tell us what license your project is under? because I've not seen any mention in the repository itself. I run a fork of your project here  and would like to know what licensing terms apply. If you specify no license at all, that means that I cannot modify your code (except fork it on GitHub).
Since it is possible that a license was not added unintentionally, after reading the attached post here, would you still stay your project has no license? If yes, then I will have to retire my fork and delete it since I've made public changes to your code.

hey @cyfrost ,
that's super hard question for me...
I don't really know what license I can choose since the app is a wrapper for the proprietary software (Todoist). Will my license (let's say MIT) conflict with Todoist? I don't know... I'll try to research this issue a bit and let you know.
As for your fork, it looks great. I saw it already and I really like everything you did there.
You don't need a license file in this project to continue maintain your fork. You just need to know that author of the original fork (me) is not going to perform any sanctions to you just because you modified the code. As far as I got the answer on Stackexchange, it suggests to assume worst scenario just to keep you protected in terms of any legal things.
Please don't think I'm going to perform any legal-related actions to any fork this project has. It's not interesting.

Alright, Thanks!


Add Time Picker

https://material.io/components/time-pickers

I think we need the community package for iOS: https://github.com/react-native-community/react-native-picker

I need help/tips with the dragging the clock hand on screen and animations. I don't know how to handle that yet

Development of this has started in the https://github.com/web-ridge/react-native-paper-dates/tree/development branch

This is almost ready, need some extra testing with the AM/PM switcher and text inputs

Released!


Building burn examples individually breaks

Describe the bug
Cd-ing into a mnist or other example crate, and trying to build will result in errors due to incorrect feature flag settings.
To Reproduce

cd to examples/text-classification
cargo build

Screenshots
   Compiling text-classification v0.10.0 (/Users/dilshod/Projects/burn/examples/text-classification)
error[E0433]: failed to resolve: could not find `train` in `burn`
  --> examples/text-classification/src/training.rs:21:5
   |
21 |     train::{
   |     ^^^^^ could not find `train` in `burn`

error[E0432]: unresolved import `burn::train`
  --> examples/text-classification/src/model.rs:17:5
   |
17 |     train::{ClassificationOutput, TrainOutput, TrainStep, ValidStep},
   |     ^^^^^ could not find `train` in `burn`

error[E0432]: unresolved import `burn::train`
  --> examples/text-classification/src/training.rs:21:5
   |
21 |     train::{
   |     ^^^^^ could not find `train` in `burn`

Some errors have detailed explanations: E0432, E0433.
For more information about an error, try `rustc --explain E0432`.
error: could not compile `text-classification` (lib) due to 3 previous errors

Additional context
Strangely it works if the entire project is build from the root.

for the "error[E0433]: failed to resolve: could not find train in burn", usually should add "train" feature in cargo.toml.
but, for your purpose, you should read the examples/text-classification/README.md

@antimora Thanks for this, I wasn't able to check compilation flags with cargo check. Weirdly it always worked when within the workspace, but I'm happy to know we can still validate examples this way.

@antimora Thanks for this, I wasn't able to check compilation flags with cargo check. Weirdly it always worked when within the workspace, but I'm happy to know we can still validate examples this way.

I think @dae has added examples checks but by default they're not run. If you run example checks, then you can see the failure:
[burn]$ ./run-checks.sh examples
    Finished dev [unoptimized + debuginfo] target(s) in 0.23s
     Running `target/debug/xtask run-checks examples`
Checking examples compile

Checking examples/mnist

    Checking burn-common v0.10.0 (/Users/dilshod/Projects/burn/burn-common)
    Checking burn-autodiff v0.10.0 (/Users/dilshod/Projects/burn/burn-autodiff)
    Checking burn-core v0.10.0 (/Users/dilshod/Projects/burn/burn-core)
    Checking burn v0.10.0 (/Users/dilshod/Projects/burn/burn)
    Checking mnist v0.10.0 (/Users/dilshod/Projects/burn/examples/mnist)
error[E0433]: failed to resolve: could not find `train` in `burn`
  --> examples/mnist/src/training.rs:12:5
   |
12 |     train::{
   |     ^^^^^ could not find `train` in `burn`

error[E0432]: unresolved import `burn::train`
  --> examples/mnist/src/model.rs:10:5
   |
10 |     train::{ClassificationOutput, TrainOutput, TrainStep, ValidStep},
   |     ^^^^^ could not find `train` in `burn`

error[E0432]: unresolved import `burn::train`
  --> examples/mnist/src/training.rs:12:5
   |
12 |     train::{
   |     ^^^^^ could not find `train` in `burn`

Some errors have detailed explanations: E0432, E0433.
For more information about an error, try `rustc --explain E0432`.
error: could not compile `mnist` (lib) due to 3 previous errors
[burn]$


MBps?

B = bytes, while b = bits
Bandwidth is conventionally described as bits per second.
So does the reference of MBps really mean Mega Bytes, or is this a typo?
Letter Cases Matter!
Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: cebc38c1-00c8-0de2-afba-43b88ded279a
Version Independent ID: 7ad6ff43-016c-3806-6a1f-63f37ef7cbb9
Content: Azure Well-Architected Framework review of Azure Application Gateway - Azure Architecture Center
Content Source: docs/networking/guide/waf-application-gateway.md
Service: architecture-center
Sub-service: azure-guide
GitHub Login: @PageWriter-MSFT
Microsoft Alias: pnp

Thanks for reporting - this issue is under review. This is a Microsoft Internal DevOps Bug ID # 494597


rubocop - get linting started early

This can be hooked to automatically fail test
runs when linting fails, including on the ci.

Happy to add whatever commit message policy anyone wants.


Usb: add sim usb device and host driver

Summary

Use Linux Raw Gadget and Dummy UDC to set up virtual USB device;
Get Raw Gadget:
Get Raw Gadget code at https://github.com/xairy/raw-gadget.
Make Raw Gadget:
Run make in the raw_gadget and dummy_hcd directory. If raw_gadget build fail, you need to check which register interface meets your kenel version, usb_gadget_probe_driver or usb_gadget_register_driver.
Install Raw Gadget:
Run ./insmod.sh in the raw_gadget and dummy_hcd directory.

Simulate USB Host using libusb,  it's possible to connect simulated USB devices and real USB devices based on the configured VID and PID.  At this stage, only one USB device can be connected.

Impact
NA
Testing
sim:usbdev sim:usbhost test adb, rndis, cdcacm, cdcecm.

@zyfeier create a separate PR to install libusb package:
https://github.com/apache/nuttx/blob/master/tools/ci/docker/linux/Dockerfile#L251

@zyfeier are you planing to add some driver examples implementing a USB device? It should be a good idea

let's add some instruction in sim README.txt about the new usbdev/usbhost config:
https://github.com/apache/nuttx/blob/master/boards/sim/sim/sim/README.txt#L563

let's add some instruction in sim README.txt about the new usbdev/usbhost config: https://github.com/apache/nuttx/blob/master/boards/sim/sim/sim/README.txt#L563

Please don't! Use the Documentation, we need to phase out these README.txt file since we didn't find a way to automatically get content of README.txt to feed the Documentation.

@zyfeier are you planing to add some driver examples implementing a USB device? It should be a good idea

@acassis This is a good idea, and I'll add some examples after this PR submitted.

I noticed that we are running out of space again on the docker image build/push so I don't think the image got updated :(. I think I know how to free up some more space on the worker that I can try this evening.  Otherwise I can manually push the updated image for the short term.

I noticed that we are running out of space again on the docker image build/push so I don't think the image got updated :(. I think I know how to free up some more space on the worker that I can try this evening. Otherwise I can manually push the updated image for the short term.

Thanks @btashton , let's wait your try if the result isn't good please update the image manuaully to unblock this PR.

@btashton do you have progress, thanks?

@btashton do you have progress, thanks?

Sorry for the delay. Let's see if this works, it looks like it frees up about 13GB.
https://github.com/apache/nuttx/pull/8680

@btashton do you have progress, thanks?

Sorry for the delay. Let's see if this works, it looks like it frees up about 13GB.
#8680

Thanks! @btashton


Added Czech namedays API

Change Czech national bank´s category
Thank you for taking the time to work on a Pull Request for this project!
To ensure your PR is dealt with swiftly please check the following:

[x] Your submissions are formatted according to the guidelines in the contributing guide.
[x] Your changes are made in the README file, not the auto-generated JSON.
[x] Your additions are ordered alphabetically.
[x] Your submission has a useful description.
[x] Each table column should be padded with one space on either side.
[x] You have searched the repository for any relevant issues or PRs.
[x] Any category you are creating has the minimum requirement of 3 items.

Hi @xnekv03 , thanks for the PR! Could you please update the Description to be more easily understood? Thanks!

Hopefully that's better

adding https for CZ nationl bank

Looks good, thanks!


Apply autopep8 and flake8 to obey PEP8.

Codecov Report

Merging #112 into master will decrease coverage by 0.04%.
The diff coverage is 87.5%.

@@            Coverage Diff             @@
##           master     #112      +/-   ##
==========================================
- Coverage   73.28%   73.23%   -0.05%
==========================================
  Files          69       69
  Lines        2583     2582       -1
==========================================
- Hits         1893     1891       -2
- Misses        690      691       +1


NULL values are returned as string

Currently (3.0.0-beta-9) NULL values in the DB are returned as "NULL" (the string). They need to be returned as JS null. Among other reasons the current behaviour would prevent saving the string "NULL" to the database, even if one tried to work around this on the receiving end. I tried a quick change in UtilsSQLCipher.swift and changed "NULL" to nil in getColumnValue and that seemed to work well.

@chriswep The "NULL" in getColumnValue is required for the importFromJson and exportToJson methods to work

i haven't used (or looked at) the json import/export features. However returning the string "NULL" for null values is breaking core SQLite (or database in general) functionality, so i'd suggest refactoring to the json features to work with "real" null values?

@chriswep solve in 3.0.0-beta.11


🐛 FIX: Sphinxcontrib-bibtex version issue

Codecov Report

Merging #56 (aecc942) into master (1014f8f) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #56   +/-   ##
=======================================
  Coverage   97.89%   97.89%
=======================================
  Files           5        5
  Lines         237      237
=======================================
  Hits          232      232
  Misses          5        5

Flag
Coverage Δ

pytests
97.89% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1014f8f...aecc942. Read the comment docs.


refactor: expose lookup_async from beatree ReadTransaction

This adds a lookup function for async reads using the beatree ReadTransaction.
Loads of overflow values still block; this will be fixed in a follow-up.

#626
#625  👈 (View in Graphite)
master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Merge activity

Dec 19, 8:09 AM EST: A user started a stack merge that includes this pull request via Graphite.


Finetuned model weights

Hi,
Thank you for releasing code for the work! Have you released the weights for any finetuned model in the paper?
Thanks.

Thanks for your attention! You can construct your own prompt set to get a model that better meets your needs.

#84

Why does the script scripts/train_refl_sdxl.sh require images too (train_refl.sh doesnt)?

Why does the script scripts/train_refl_sdxl.sh require images too (train_refl.sh doesnt)?

I meet the same question, do you have solved it? i don't understand what the images refer to..

This is code contributed by a community friend who supposedly added the pre-training loss function mentioned in the paper. You can refer to https://github.com/THUDM/ImageReward/pull/89


IEC method for number of wakes impacting turbines

Complete this sentence
THIS PULL REQUEST IS READY TO MERGE
Feature or improvement description
A function is added to turbine_map that returns the number of wakes impacting each turbine for a particular wind direction. It uses the waked sector formula from Fig. A.1 in Annex A of IEC 61400-12-1. This formula is used to determine unwaked directions for power performance testing, so it probably errs on the side of caution when saying a turbine is unwaked.
Related issue, if one exists
None.
Impacted areas of the software
turbine_map.py
Additional supporting information

Test results, if applicable

@paulf81 here is the IEC method for determining waked directions

That looks great!  Really elegant function

Thanks for doing that so fast!


[bug] lnreader fails to build on python 3.12

Steps to reproduce
python --version === 3.12
npm install
npm run buildRelease

Expected behavior
I has apk
Actual behavior
BUILD FAILED
LNReader version
git
Android version
N/A
Device
Linux
Other details
None
Acknowledgements

[X] I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open or closed issue.
[X] I have written a short but informative title.
[X] If this is an issue with a source, I should be opening an issue in the sources repository.
[X] I have updated the app to version 1.1.18.
[X] I will fill out all of the requested information in this form.

Python should be 3.7>=

Gradle daemons will seek to keep using the same python version and will not respect the environment variables you set. Can either

kill them off or
delete the ~/.gradle folder or
restart computer after setting the environment variables.

Resetting whatever gradle daemons that are currently running is the only solution.


onTap GestureDetector on Flutter web makes the browser's previous arrow enabled

Steps to reproduce

Use a GestureDetector somewhere in your code with onTap method. This method can be empty if you want, but no null
Run your code with Flutter Web
Click on your GestureDetector

Expected results
The previous arrow in the browser shouldn't be enabled
Actual results
The previous arrow in the browser is enabled. This can lead to some problems with more complicated cases where clicking on the previous arrow display a white screen. The same problem might occur with the other gestures.
Code sample
Code sample
import 'package:flutter/material.dart';

void main() {
  runApp(const MyApp());
}

class MyApp extends StatelessWidget {
  const MyApp({super.key});

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'Flutter Demo',
      theme: ThemeData(
        colorScheme: ColorScheme.fromSeed(seedColor: Colors.deepPurple),
        useMaterial3: true,
      ),
      home: const MyHomePage(title: 'Flutter Demo Home Page'),
    );
  }
}

class MyHomePage extends StatefulWidget {
  const MyHomePage({super.key, required this.title});

  final String title;

  @override
  State<MyHomePage> createState() => _MyHomePageState();
}

class _MyHomePageState extends State<MyHomePage> {
  bool selectWidget = true;

  @override
  Widget build(BuildContext context) {
    return Scaffold(
        appBar: AppBar(
          backgroundColor: Theme.of(context).colorScheme.inversePrimary,
          title: Text(widget.title),
        ),
        body: Center(
          child: Column(mainAxisSize: MainAxisSize.min, children: [
            GestureDetector(
              onTap: () {
                setState(() {
                  selectWidget = !selectWidget;
                });
              },
              child: const Text("Click here !"),
            ),
            if (selectWidget) ...[
              const Text("Widget 1")
            ] else ...[
              const Text("Widget 2")
            ]
          ]),
        ));
  }
}

Screenshots or Video

Screenshots / Video demonstration
https://github.com/flutter/flutter/assets/164201184/037b0c82-4c7c-4be4-8045-ab8a735b6633

Logs
Logs
[Paste your logs here]

Flutter Doctor output
Doctor output
Doctor summary (to see all details, run flutter doctor -v):
[√] Flutter (Channel stable, 3.19.5, on Microsoft Windows [Version 10.0.19045.4291], locale en-GB)
[√] Windows Version (Installed version of Windows is version 10 or higher)
[√] Android toolchain - develop for Android devices (Android SDK version 32.1.0-rc1)
[√] Chrome - develop for the web
[√] Visual Studio - develop Windows apps (Visual Studio Community 2022 17.5.1)
[√] Android Studio (version 2021.2)
[√] IntelliJ IDEA Community Edition (version 2022.1)
[√] VS Code (version 1.89.0)
[√] Connected device (3 available)
[√] Network resources

• No issues found!

Thanks for the report. I was able to replicate this using latest versions.

 stable, master flutter doctor -v
[!] Flutter (Channel stable, 3.19.6, on macOS 12.2.1 21D62 darwin-x64, locale
    en-GB)
    • Flutter version 3.19.6 on channel stable at
      /Users/dhs/documents/fluttersdk/flutter
    ! Warning: `flutter` on your path resolves to
      /Users/dhs/Documents/Fluttersdk/flutter/bin/flutter, which is not inside
      your current Flutter SDK checkout at
      /Users/dhs/documents/fluttersdk/flutter. Consider adding
      /Users/dhs/documents/fluttersdk/flutter/bin to the front of your path.
    ! Warning: `dart` on your path resolves to
      /Users/dhs/Documents/Fluttersdk/flutter/bin/dart, which is not inside your
      current Flutter SDK checkout at /Users/dhs/documents/fluttersdk/flutter.
      Consider adding /Users/dhs/documents/fluttersdk/flutter/bin to the front
      of your path.
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 54e66469a9 (6 days ago), 2024-04-17 13:08:03 -0700
    • Engine revision c4cd48e186
    • Dart version 3.3.4
    • DevTools version 2.31.1
    • If those were intentional, you can disregard the above warnings; however
      it is recommended to use "git" directly to perform update checks and
      upgrades.

[!] Xcode - develop for iOS and macOS (Xcode 12.3)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    ! Flutter recommends a minimum Xcode version of 13.
      Download the latest version or update via the Mac App Store.
    • CocoaPods version 1.11.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] VS Code (version 1.62.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.21.0

[✓] Connected device (5 available)
    • SM G975F (mobile)       • RZ8M802WY0X • android-arm64   • Android 11 (API 30)
    • Darshan's iphone (mobile)  • 21150b119064aecc249dfcfe05e259197461ce23 •
      ios            • iOS 14.4.1 18D61
    • iPhone 12 Pro Max (mobile) • A5473606-0213-4FD8-BA16-553433949729     •
      ios            • com.apple.CoreSimulator.SimRuntime.iOS-14-3 (simulator)
    • macOS (desktop)            • macos                                    •
      darwin-x64     • Mac OS X 10.15.4 19E2269 darwin-x64
    • Chrome (web)               • chrome                                   •
      web-javascript • Google Chrome 98.0.4758.80

[✓] HTTP Host Availability
    • All required HTTP hosts are available

! Doctor found issues in 1 category.

[!] Flutter (Channel master, 3.22.0-23.0.pre.43, on macOS 12.2.1 21D62
    darwin-x64, locale en-GB)
    • Flutter version 3.22.0-23.0.pre.43 on channel master at
      /Users/dhs/documents/fluttersdk/flutter
    ! Warning: `flutter` on your path resolves to
      /Users/dhs/Documents/Fluttersdk/flutter/bin/flutter, which is not inside
      your current Flutter SDK checkout at
      /Users/dhs/documents/fluttersdk/flutter. Consider adding
      /Users/dhs/documents/fluttersdk/flutter/bin to the front of your path.
    ! Warning: `dart` on your path resolves to
      /Users/dhs/Documents/Fluttersdk/flutter/bin/dart, which is not inside your
      current Flutter SDK checkout at /Users/dhs/documents/fluttersdk/flutter.
      Consider adding /Users/dhs/documents/fluttersdk/flutter/bin to the front
      of your path.
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision b8abc10689 (12 hours ago), 2024-05-05 13:01:23 -0400
    • Engine revision 624dcb987f
    • Dart version 3.5.0 (build 3.5.0-131.0.dev)
    • DevTools version 2.35.0
    • If those were intentional, you can disregard the above warnings; however
      it is recommended to use "git" directly to perform update checks and
      upgrades.

[!] Android toolchain - develop for Android devices (Android SDK version 30.0.3)
    • Android SDK at /Users/dhs/Library/Android/sdk
    ✗ cmdline-tools component is missing
      Run `path/to/sdkmanager --install "cmdline-tools;latest"`
      See https://developer.android.com/studio/command-line for more details.
    ✗ Android license status unknown.
      Run `flutter doctor --android-licenses` to accept the SDK licenses.
      See https://flutter.dev/docs/get-started/install/macos#android-setup for
      more details.

[✓] Xcode - develop for iOS and macOS (Xcode 13.2.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 13C100
    • CocoaPods version 1.11.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] IntelliJ IDEA Ultimate Edition (version 2021.3.2)
    • IntelliJ at /Applications/IntelliJ IDEA.app
    • Flutter plugin version 65.1.4
    • Dart plugin version 213.7228

[✓] VS Code (version 1.62.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.29.0

[✓] Connected device (3 available)
    • Darshan's iphone (mobile) • 21150b119064aecc249dfcfe05e259197461ce23 • ios
      • iOS 15.3.1 19D52
    • macOS (desktop)           • macos                                    •
      darwin-x64     • macOS 12.2.1 21D62 darwin-x64
    • Chrome (web)              • chrome                                   •
      web-javascript • Google Chrome 109.0.5414.119

[✓] Network resources
    • All expected network resources are available.

! Doctor found issues in 1 category.

[!] Xcode - develop for iOS and macOS (Xcode 12.3)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    ! Flutter recommends a minimum Xcode version of 13.
      Download the latest version or update via the Mac App Store.
    • CocoaPods version 1.11.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] VS Code (version 1.62.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.21.0

[✓] Connected device (5 available)
    • SM G975F (mobile)       • RZ8M802WY0X • android-arm64   • Android 11 (API 30)
    • Darshan's iphone (mobile)  • 21150b119064aecc249dfcfe05e259197461ce23 •
      ios            • iOS 14.4.1 18D61
    • iPhone 12 Pro Max (mobile) • A5473606-0213-4FD8-BA16-553433949729     •
      ios            • com.apple.CoreSimulator.SimRuntime.iOS-14-3 (simulator)
    • macOS (desktop)            • macos                                    •
      darwin-x64     • Mac OS X 10.15.4 19E2269 darwin-x64
    • Chrome (web)               • chrome                                   •
      web-javascript • Google Chrome 98.0.4758.80

[✓] HTTP Host Availability
    • All required HTTP hosts are available

! Doctor found issues in 1 category.

Does this only happen with flutter run -d chrome or when you deploy the app normally (flutter run -d web-server should be a decent proxy for that mode)?

If you are using the old navigation model, the expected behavior is that the back button is always enabled. That's because we push a history entry immediately when the app starts. The reason you don't see it until you interact with the page is probably due to some Chrome behavior.
To get a more sane navigation model, try the newer MaterialApp.router() or go_router.


show state immediately after neo-node start error

It is caused by the change https://github.com/neo-project/neo-node/pull/758, localnode is null at this time.
after several seconds later, it shows numbers.

Revert #758?

Revert #758?

If you have better solution to solve https://github.com/neo-project/neo/issues/2380.
I found that if you start node with websockt port occupied by another application, you will get different localnodes before and after call NeoSystem.StartNode.


hdf5.h: No such file or directory (Ubuntu 15.04)

When I try to build bindings-hdf5, I get the following error:
bindings-hdf5-0.1.1: build
Preprocessing library bindings-hdf5-0.1.1...
Types.hsc:1:18: fatal error: hdf5.h: No such file or directory
compilation terminated.
compiling .stack-work/dist/x86_64-linux/Cabal-<IP_ADDRESS>/build/Bindings/HDF5/Types_hsc_make.c failed (exit code 1)
command was: /usr/bin/gcc -c .stack-work/dist/x86_64-linux/Cabal-<IP_ADDRESS>/build/Bindings/HDF5/Types_hsc_make.c -o .stack-work/dist/x86_64-linux/Cabal-<IP_ADDRESS>/build/Bindings/HDF5/Types_hsc_make.o -fno-stack-protector -D__GLASGOW_HASKELL__=710 -Dlinux_BUILD_OS=1 -Dx86_64_BUILD_ARCH=1 -Dlinux_HOST_OS=1 -Dx86_64_HOST_ARCH=1 -I.stack-work/dist/x86_64-linux/Cabal-<IP_ADDRESS>/build/autogen -include .stack-work/dist/x86_64-linux/Cabal-<IP_ADDRESS>/build/autogen/cabal_macros.h -I/home/sidharth/.stack/snapshots/x86_64-linux/lts-4.1/7.10.3/lib/x86_64-linux-ghc-7.10.3/bindings-DSL-1.0.23-Es09zjDpTFQCqScuh7qYEQ/include -I/home/sidharth/.stack/programs/x86_64-linux/ghc-7.10.3/lib/ghc-7.10.3/base_HQfYBxpPvuw8OunzQu6JGM/include -I/home/sidharth/.stack/programs/x86_64-linux/ghc-7.10.3/lib/ghc-7.10.3/integ_2aU3IZNMF9a7mQ0OzsZ0dS/include -I/home/sidharth/.stack/programs/x86_64-linux/ghc-7.10.3/lib/ghc-7.10.3/include -I/home/sidharth/.stack/programs/x86_64-linux/ghc-7.10.3/lib/ghc-7.10.3/include/

--  While building package bindings-hdf5-0.1.1 using:
      /home/sidharth/clones/bindings-dsl/bindings-hdf5/.stack-work/dist/x86_64-linux/Cabal-<IP_ADDRESS>/setup/setup --builddir=.stack-work/dist/x86_64-linux/Cabal-<IP_ADDRESS> build lib:bindings-hdf5 --ghc-options " -ddump-hi -ddump-to-file"
    Process exited with code: ExitFailure 1

I'm using Ubuntu 15.04.
I believe this issue may be related to the following issues: https://github.com/NVIDIA/DIGITS/issues/156, https://github.com/BVLC/caffe/issues/2690, https://groups.google.com/forum/#!topic/caffe-users/cdyqjNpoFRY.
(Apparently, the location of hdf5.h changed in the newest Ubuntu HDF5 packages, which is why the build script can't find the header file.)
It seems like we might need to update bindings-hdf5/configure to look in the right directory for hdf5.h, but I'm not sure exactly how to do this.
Does anyone here know how we can fix this?

I fixed it by adding the following to bindings-hdf5.cabal, under library:
  include-dirs: /usr/include/hdf5/serial
  extra-lib-dirs: /usr/lib/x86_64-linux-gnu/hdf5/serial

Should we add this to the repo? That would be useful so that other people using Ubuntu 15.04 can run stack install bindings-hdf5 globally and it would just work, rather than having to manually clone the repo, update the cabal file, and build manually.

The cabal file is really not the place for such system-specific settings.  They should become arguments to the stack install command.

FWIW, I can reproduce the error.
I wonder if it would be a better idea to use pkgconfig-depends: hdf5 instead of a configure script?

Out of curiosity, what usually happens in this situation? In my /usr/include directory on my Ubuntu 15.04 machine, I can see many libraries that have a folder structure: X11, boost, cairo, curl, gsl, gtk-3.0, etc. Do people usually have to specify the directory when including these libraries (i.e. include <cairo/cairo.h>)?

Er, disregard my advice: it appears that hdf5 does not ship with a .pc file. That is an Ubuntu-ism. (source: https://github.com/mokus0/bindings-hdf5#installation)

@RyanGlScott I'm not sure how pkg-config works, but on my machine, pkg-config --libs hdf5 yields
-L/usr/lib/x86_64-linux-gnu/hdf5/serial -lhdf5

which looks to me like the desired output.


Add a basic CODEOWNERS file.

Yeah, it's a good idea. It might be nice to get other folks to review if there is a slsa-framework org-wide team for this kind of project.


Added double quotes around $@

This is to ensure multi-word arguments are supported when invoking
the maas plugin wrapper script.


The cipher 'aes256-cbc' is required, but it is not available

I have already once reported about this issue (in http://dbeaver.jkiss.org/forum/viewtopic.php?f=2&t=1887) where the existing JRE policy file does not contain support for cipher 'aes256-cbc' so as a fix we have to download and replace the policy file which does contain the mentioned cipher.

That makes sense. I'll patch JRE shipped with Windows installer.
Thanks for reminder.

Hi Serge, I have downloaded the installer today and it does not work with tunnel
Can't initialize tunnel
Cannot establish tunnel
com.jcraft.jsch.JSchException: The cipher 'aes256-cbc' is required, but it is not available.

Make sure that JRE shipped with installer is actually used (main menu Window->Installation Information->Configuration->property java.home ).

Hi Serge,
Thanks for the reply.
Actually I have fixed it adding the right local_policy.jar in the security folder in my JRE.
I have another issue with the tunnelling, I could ask for some help later on.
Cheers
Filippo
From: Serge Rider<EMAIL_ADDRESS>Sent: 14 November 2016 12:39
To: serge-rider/dbeaver<EMAIL_ADDRESS>Cc: Filippo Pirro<EMAIL_ADDRESS>Comment<EMAIL_ADDRESS>Subject: Re: [serge-rider/dbeaver] The cipher 'aes256-cbc' is required, but it is not available (#586)
Make sure that JRE shipped with installer is actually used (main menu Window->Installation Information->Configuration->property java.home ).
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHubhttps://github.com/serge-rider/dbeaver/issues/586#issuecomment-260324789, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AM6Quj14UFm9dywgkzUjvHcn0oW7EhB4ks5q-FZkgaJpZM4JHOgU.

I faced the same issue when trying to connect to a Cassandra DB using an encrypted Putty private key (.ppk) for SSH tunneling.
Got it resolved by converting the putty private key (.ppk) to an OpenSSH one (this can be done by loading the putty private key in "Puttygen" & then converting it to OpenSSH key). Refer stackoverflow.com/questions/17989883/the-cipher-aes256-cbc-is-required-but-it-is-not-available for more details.


Fix most leak reports from run-tests.py

See https://github.com/ariya/phantomjs/issues/13882

In addition to Vitallium's line notes, I want to bring issue #13121 to your attention - to fix this we're probably going to have to make phantom.exit() call the C library's exit(), which means app.exec() will never return.  We don't want to lose leak detection in debug builds by doing that, but it may take some finagling.

That'll be tricky because Phantom needs to be destructed in addition to calling clearMemoryCaches or there will still be leaks.

I've gone ahead and landed this with the changes as discussed.  There are two remaining testsuite failures introduced by debug mode:
module/webpage/includejs: ERROR
ERROR: Unexpected output on stderr
  ASSERTION FAILED: !m_frame->page()->defersLoading() || InspectorInstrumentation::isDebuggerPaused(m_frame)
  loader/DocumentLoader.cpp(361) : void WebCore::DocumentLoader::finishedLoading(double)
  1   0x1fe6292 /home/zack/projects/phantomjs/bin/phantomjs() [0x1fe6292]
[...]
ERROR: PhantomJS killed by signal 11

regression/pjs-10690: ERROR
ERROR: Unexpected output on stderr
  LEAK: 1 CachedResource

The leak is your issue #13920.  I've filed #13935 for the assertion.

That'll be tricky because Phantom needs to be destructed in addition to calling clearMemoryCaches or there will still be leaks.

Yeah, I know. It might end up having to do something pretty nasty.


YUM package update as a group vs individual packages

Filing on behalf of a customer here.
This started out as possibly an issue with the OpenSSL cookbook, because it was failing to upgrade the openssl package when using the openssl:upgrade cookbook.  The error message is as follows
---- Begin output of ----
STDOUT: STDERR:
Transaction Check Error:
file /etc/pki/tls/certs/ca-bundle.crt from install of openssl-0.9.8e-32.el5_11.x86_64 conflicts with file from package openssl-0.9.8e-26.el5_9.1.i686
file /usr/share/man/man1/ca.1ssl.gz from install of openssl-0.9.8e-32.el5_11.x86_64 conflicts with file from package openssl-0.9.8e-26.el5_9.1.i686
file /usr/share/man/man1/req.1ssl.gz from install of openssl-0.9.8e-32.el5_11.x86_64 conflicts with file from package openssl-0.9.8e-26.el5_9.1.i686
file /usr/share/man/man1/x509.1ssl.gz from install of openssl-0.9.8e-32.el5_11.x86_64 conflicts with file from package openssl-0.9.8e-26.el5_9.1.i686

Error Summary

-------------

---- End output of ——

# Declared in /var/chef/cache/cookbooks/openssl/recipes/upgrade.rb:33:in `block in from_file'
package("openssl") do
action [:upgrade]
retries 0
retry_delay 2
guard_interpreter :default
package_name "openssl"
version "0.9.8e-32.el5_11"
timeout 900
cookbook_name "openssl"
recipe_name "upgrade"
end

The tricky part comes from manually doing a yum update openssl and getting no error.  But the chef-client is doing the updates one at a time, akin to running yum update openssl-0.9.8e-26.el5_9.1.i686 which fails.
Unfortunately, I don’t have the archeology of the code traces handy, but I think the issue is actually with the package resource not the openssl cookbook. The cookbook is, by default, specifying a package family (not any specific version or architecture which would likely work in this case
if the YUM package used only the family).
From what I could infer from the YUM package code, it looked as if the resource was querying the system to determine which packages were installed, capturing them in a list, and then iterating through the list to do the updates one at a time instead of as a family.
If so, this would result in the issue we're is seeing.

This is probably yet another incarnation of the yum arch bug which is fixed in master and should be released in 12.4.0

Hmm, no nevermind its not that bug.  This is sort of like the multipackage stuff, but with a single label inflating to multiple packages to install.  The cookbook can probably code around this by using a multipackage install and manually inflating the group itself.

Yes it sounds like the multipackage would resolve the issue described above.

Exactly how do i get around this problem with multipackage?

easiest way for now probably looks something like this (off the top of my head so probably has a bug or three):
execute "install openssl" do
  command "yum -y install openssl"
  not_if "rpm -qa | egrep openssl"
end

the 'right' way to fix it involves resolving the group of packages to a single package via yum and then doing a multipackage install of that list.  i can't claim to know yum very well any more, so don't know what that is without a bunch of research.

I was hitting this issue a few days ago actually. In my case, I was able to work around it by adding apt cookbook to the runlist, and enabling compile time update
    attributes:
      apt:
        compile_time_update: true
        compiletime: true

@timgriffiths Try (for example):
multipackage [ "vim-common", "vim-minimal", "vim-enhanced" ] do
  action :upgrade
end

Using https://supermarket.chef.io/cookbooks/multipackage/versions/2.0.4

This is working for me right now on centos 7:
[2016-11-29T19:42:05+00:00] DEBUG: yum_package[openssl] checking yum info for openssl
[2016-11-29T19:42:05+00:00] DEBUG: yum_package[openssl] installed version: ["1.0.1e-42.el7"] candidate version: 1.0.1e-51.el7_2.7
[2016-11-29T19:42:05+00:00] DEBUG: yum_package[openssl] openssl is out of date, will upgrade to 1.0.1e-51.el7_2.7
[2016-11-29T19:42:05+00:00] INFO: yum_package[openssl] installing openssl-1.0.1e-51.el7_2.7 from updates repository
[2016-11-29T19:42:05+00:00] DEBUG: yum_package[openssl]: yum command: "yum -d0 -e0 -y install openssl-1.0.1e-51.el7_2.7"
Delta RPMs disabled because /usr/bin/applydeltarpm not installed.
[2016-11-29T19:42:07+00:00] INFO: yum_package[openssl] upgraded openssl to 1.0.1e-51.el7_2.7

    - upgrade package openssl from 1.0.1e-42.el7 to 1.0.1e-51.el7_2.7

Also appears to work on centos 6:
[2016-11-29T19:47:54+00:00] DEBUG: yum_package[openssl] checking yum info for openssl
[2016-11-29T19:47:54+00:00] DEBUG: yum_package[openssl] installed version: ["1.0.1e-48.el6"] candidate version: 1.0.1e-48.el6_8.3
[2016-11-29T19:47:54+00:00] DEBUG: yum_package[openssl] openssl is out of date, will upgrade to 1.0.1e-48.el6_8.3
[2016-11-29T19:47:54+00:00] INFO: yum_package[openssl] installing openssl-1.0.1e-48.el6_8.3 from updates repository
[2016-11-29T19:47:54+00:00] DEBUG: yum_package[openssl]: yum command: "yum -d0 -e0 -y install openssl-1.0.1e-48.el6_8.3"
[2016-11-29T19:47:58+00:00] INFO: yum_package[openssl] upgraded openssl to 1.0.1e-48.el6_8.3

    - upgrade package openssl from 1.0.1e-48.el6 to 1.0.1e-48.el6_8.3

based on the package versions this looks like it affects CentOS 5, but unfortunately my ability to run CentOS 5 bento boxes is busted right now due to virutalbox issues, which impedes researching this one.

This looks like its been fixed for some time now, I can't replicate on Chef 13.5.25


Error opening input file Agora-Bridging-Header.h

Running on Version 9.2 (9C40b), why can't I successfully build? It won't get past the bridging header issue. Anyone receive this bug?

Didn't need bridging anymore, you still have to put AgoraRtcEngineKit.framework to 'libs' though.


Dump syms should work for .app files

For https://github.com/BugSplat-Git/my-qt-crasher/pull/41 we're putting the file in a folder myQtCrasher.app but the module name and folder expected by the backend is myQtCrasher.

This was fixed by #105 #106 and #107


Implement CNI network policy

https://coreos.com/kubernetes/docs/latest/deploy-master.html

This is duplicated, closing in favour of https://github.com/Capgemini/kubeform/issues/88


create folder to house jinja templates

Create a folder called doc-templates in the src folder to house the base jinja templates that the first pass project created by cookiecutter can depend on.
The folder will contain all the files from here: https://github.com/linkml/linkml/tree/main/linkml/generators/docgen
The reason why this is useful is because users would no longer have to go to the above location to fish out starter jinja templates to begin modifying the style and content of their web documentation pages.

Decide if this is still the best way forward. Close it out if not.
Caveats:

We can't have an empty doc-templates folder (on GitHub)
Shouldn't confuse users/developers by exposing more files in src


XGBOOST hangs

Hi,
XGBOOST hangs with a specific model I created after 2,750,000 calls to predict using R.
It's happened to me before with a different model after 300,000 calls to predict.
Please find attached the saved XGBOOST model.
Thanks in advance
GrupoBimbo_SALES_R_MODEL.txt

Now it is fixed by https://github.com/dmlc/xgboost/pull/1489


2022.26.12 updates

The __init__.py files in both clients and models appear to have gotten removed in this PR. Python needs these to detect available imports during runtime.
Similar to an index.ts you'll see in TypeScript projects although they don't require any code.

Fixed!

In order to support the type hinting union operator |, we need to bump the minimum python version to 3.10 in setup.cfg.
Attempting to install the package currently would only run for 3.10 or higher. We could update the syntax generation to support down to 3.7 in a future PR.
Additionally from a convenience standpoint we should declare the required dependencies - related issue


A Newbies Questions

The readme said to open an issue to discuss Anything about Antigen.

Any comments/suggestions/feedback is truly welcome. Please say hello to us on Gitter. Or open an issue to discuss something (anything!) about the project ;).

So I'm gonna give this a shot before diving in head first.
I have been using Oh-My-zsh and just now learned about Antigen.
I'm also fairly new to zsh in general so I'm not quite sure how the configuration work, so my question is as follows:
In my .zshrc I have a few things configured so far.
So when I install Antigen I should only have to replace the following lines with the Antigen commands as explained here:

export ZSH="/home/sonofdiablo/.oh-my-zsh"
ZSH_THEME="sod"
plugins=(...)
source $ZSH/oh-my-zsh.sh

The rest should be left as is.
Am I understanding this correctly?

probably yes!

probably yes!

Totally forgot I opened an issue here.
I tried it out a few days ago and it seemed to work without problems.
Thanks for the reply though appreciate it :)


1.5.1 release doesn't have .jar artifact

would it be possible to add a .jar artifact for 1.5.1 as it does for 1.5.0?

It is easier to upgrade the existing pipeline using the 1.5.0 artifact.
I am having issues building on my M1 Mac.
some clients frown when 3rd party software has to be built, unfortunately.

If there is another place to find the artifact, that would be great -- I didn't in my maven repo search.
Thank you.

Hi Neal! Where are you looking for that? It looks like it's published https://central.sonatype.com/artifact/org.openpolicyagent.kafka/opa-authorizer/overview

Oh, sorry, you're saying it's missing a jar file? I'll take a look at that today then and will let you know when that's fixed.

I just pulled the jar from https://mvnrepository.com/artifact/org.openpolicyagent.kafka/opa-authorizer/1.5.1 and it looks like everything is in there. Am I missing something @nbuesing? 🙂

Thank you.
I was looking at the github releases (https://github.com/StyraInc/opa-kafka-plugin/releases) where previous versions included it, but the 1.5.1 did not.
I am now confused why I didn't find it there, but that works for me; sorry about that.

with it being here, https://mvnrepository.com/artifact/org.openpolicyagent.kafka/opa-authorizer/1.5.1 - closing issue

Ah, yes, the release process here has been rather manual, I'm afraid. I'll make sure to add the jar to GitHub too for completeness. Thanks!


Vscode hangs if an unbuilt local workspace extension is installed

Steps to reproduce:

Open vscode over ssh
Make a fresh clone of this repo (or git clean -fdx to remove the node_modules/ from the local workspace extension, and uninstall it if installed)
Install the vscode-selfhost-test-provider local workspace extension
Reload window, it should hang

When doing this locally, I get Cannot activate, becase ./out/extension.js not found. It's not clear from the docs that the extension needs to be built. However over ssh it gets vscode into a bad state.
Proposals:

local workspace extensions should allow built vsix packages to be used instead, similar to how https://marketplace.visualstudio.com/items?itemName=garmin.private-extension-manager works
Users should be able to be install them globally so they don't have to install the extension per worktree

It is unclear and confusing to me what you are asking for. Summary and Description are not matching.
Summary says VS Code is unusable and I do not see anything related to that in the description.

Updated the issue! Sorry I was trying to be concise. After the reload is when it happens. And I did a bit more testing, this only happens over ssh. I was able to install a local extension over ssh when it was built though, so this only happens when it's not built

Updated the issue! Sorry I was trying to be concise. After the reload is when it happens. And I did a bit more testing, this only happens over ssh. I was able to install a local extension over ssh when it was built though, so this only happens when it's not built

Do you mean that if the extension's .vsix is in the extension dir, then the workspace will load?
A bunch of devs at my company ran into this too and our  code-workspace got into a broken state. We have a few custom extensions in the .vscode/ directory at the root of our monorepo, and I moved them to .vscode/extensions, but it's just the source code and no .vsix. Although https://code.visualstudio.com/updates/v1_88#_local-workspace-extensions implies that this feature is opt-in, on Insiders only, with the extensions.experimental.supportWorkspaceExtensions config, none of which are true for us, we were still prompted to install workspace extensions. After doing so and reloading the extension host, the workspace never loads over SSH. Even after reverting the change and restoring the extensions back to their original location, e.g. .vscode/extension-1, the workspace wouldn't load. I discovered that I had to rm -rf ~/.vscode-server on the remote host and remove ~/Library/Application Support/Code/CachedConfigurations locally in order to be able to load the workspace again.

Also @pcasdf, it's no longer insiders only https://code.visualstudio.com/updates/v1_89#_local-workspace-extensions

Also @pcasdf, it's no longer insiders only https://code.visualstudio.com/updates/v1_89#_local-workspace-extensions

Oops, I need to read the release notes more carefully 😇 well that's unfortunate since it doesn't seem ready to be on stable.

Thanks for filing the issue and sharing your feedback. This is a bug in remote set up which I fixed it.
Thanks.

Is there a workaround to fix this issue by myself ? I cannot access server with remote-ssh now

Same, I tried running rm -rf ~/Library/Application\ Support/Code/CachedConfigurations locally like @pcasdf mentioned, but mine still hangs

I have fixed this.

Search the .vscdb file of the remote-ssh session in local. For example: I connect to remote from windows, and vscode store files under %appdata%\Code\User\workspaceStorage. There are many hashed name folder, you can connect remote-ssh session and close, then the most recent folder shall be the target. Remember check the workspace.json in the folder to ensure that.
Use any sqlitebrowser open the .vscdb file, and filter key with "workspaceExtension", there should a nearly matched record and it's value is those workspace extensions you installed. Remember close any vscode connection to the remote before opening the db file, vscode will cached one while connecting remote, so any modifications to db files is useless if there is any connection to the target remote.
Remove the record and commit your change to db file, re-connect to remote and it should no longer hang.

Thanks! It didn't seem like the storage was too important, it seemed to just record open files and UI data. So I just moved the folder on my remote and local to get a clean state. This seems like the wrong place to store workspace extension data. I really think the implementation of local workspace extensions needs to be better thought out if it can cause failures like this.

This bug has been fixed in the latest release of VS Code Insiders!
@AndrewNolte, you can help us out by commenting /verified if things are now working as expected.
If things still don't seem right, please ensure you're on version 405ce83a24f38fd70751b03438763a1503329fe0 of Insiders (today's or later - you can use Help: About in the command palette to check), and leave a comment letting us know what isn't working as expected.
Happy Coding!


Add UI tests to TwoPage sample

Adds UI tests that focus on page swiping and page content visibility
Also updates the project structure for the sample and includes an enhancement where page numbers are placed in a bottom bar instead of at the end of the text content, so the page numbers are always visible and placed at the same y position

The test cases look good. Just a small question aboutWindowMetricsCalculator from JWM testing, should we update our TestUtils or WindowState to cover it?


Add support for Python 3.9

Summary
Python 3.9.0 was released on 10-05-2020, this commits marks the support
of Python 3.9 in qiskit-terra. It adds the supported python version in
the package metadata and updates the CI configuration to run test jobs
on Python 3.9 and build python 3.9 wheels.
Details and comments
Missing Support/Wheels:
requirements:

[ ] retworkx (https://github.com/Qiskit/retworkx/pull/168 ) 0.6.0
[x] numpy (added in 1.19.3)
[ ] scipy

optional requirements:

[ ] tweedledum
[ ] matplotlib
[ ] pandas
[ ] pyrsistent
[ ] tornado

test requirements:

[ ] lazy-object-proxy
[ ] PyYAML

The linux Python 3.9 CI job finally passed. But none of the packages listed in the PR summary have wheels yet so they were all compiled from source for that job. A subset of those packages are also why windows and macOS jobs fail because the compilation fails in those environments. This will likely be blocked until we have at least the requirements and optional requirements updated with python 3.9 wheels

Are there more dependencies with wheels now?

Are there more dependencies with wheels now?

It looks like pandas and tornado did. I've updated the PR summary to mark that. But based on the latest run of CI here from yesterday things are still blocked on scipy not supporting python 3.9 yet. The rest of the wheels that are missing are listed after it in the logs. For example: https://dev.azure.com/qiskit-ci/qiskit-terra/_build/results?buildId=20937&view=logs&j=0966c229-dc5e-59db-1707-4394fcb5748f&t=949aafd6-37aa-5146-914f-bcc53e2bf912&l=1159 although in those cases they built successfully from source. But before we merge this we'll want all of those (in the requirements and optional requirements) to have wheels because otherwise we're forcing our users to have compilers setup locally which they often don't.

Looks like the windows tests are reliably failing for test.python.tools.jupyter.test_notebooks.TestJupyter.test_jupyter_jobs_pbars due to an asyncio method not implemented on windows. (ref: https://dev.azure.com/qiskit-ci/qiskit-terra/_build/results?buildId=21667&view=logs&j=7ac14b15-9bb5-559c-7b14-675b8058d5d8&t=8c2cbfe9-8c63-538d-2158-ae270fcfde5d&l=7234 )
From https://docs.python.org/3/library/asyncio-platforms.html , it looks like the default event loop changed (in python 3.8) to ProactorEventLoop which does not support add_reader.
We have a skip for this test for python 3.8 that could be updated https://github.com/Qiskit/qiskit-terra/blob/01ded73/test/python/tools/jupyter/test_notebooks.py#L73 (and to include that the osx 3.9 test must have passed).

Would it be possible/better to set a different event loop that is more compatible with all platforms?  Or at least detect the OS and test on the best event loop for that OS?

Would it be possible/better to set a different event loop that is more compatible with all platforms? Or at least detect the OS and test on the best event loop for that OS?

I don't think it's really an issue for here and is outside the scope of what that test is verifying. The event loop error is coming from inside of jupyter/nbclient and is an internal issue for jupyter. For testing we're only trying to verify that the progress bar widget works as expected. The windows test failure because of a jupyter issue isn't something we should block this on. If you have a way to fix the test so it runs on windows please push a follow up PR to do that and remove the test skip.


Option to only show "test regex..." only when cursor is on line.

If you have several lines of regex, the "test regex..." line creates a lot of wasted space. An option to only display the text for one regex/line at a time would solve the issue.

I agree. It should also recognize the regex strings so it will only display "Test Regex..." on the appropriate lines of code. What is the regex to match a regex string, BTW? Here I found a regex to match Javascript regex strings:
https://stackoverflow.com/questions/17843691/javascript-regex-to-match-a-regex
But for Python or other languages there are some differences.


CustomDocument#dispose should be #delete

This came up yesterday and we concluded that deleting is the 99% way how extension would implement nuking of a backup, so we should just call it delete. We should also consider if backupId should be named just id, like TreeItem#id, Breadpoint#id etc etc
interface CustomDocumentBackup {
	readonly id: string;
	delete(): void | Thenable<void>;
}

I'm good with delete.
We intentionally decided to call it backupId though so that would be is symmetrical with the backupId field passed to open: https://github.com/microsoft/vscode/blob/f56960538dfdd03173ac57cdfcc8964c6d7549be/src/vs/vscode.proposed.d.ts#L1406

I kept it as backupId for now but we can discuss it tomorrow


Wait for OpenFGA to be healthy in tests

Summary
this actually waits for the in-process OpenFGA server to report health
before running the tests.
Change Type
Mark the type of change your PR introduces:

[ ] Bug fix (resolves an issue without affecting existing features)
[ ] Feature (adds new functionality without breaking changes)
[ ] Breaking change (may impact existing functionalities or require documentation updates)
[ ] Documentation (updates or additions to documentation)
[x] Refactoring or test improvements (no bug fixes or new functionality)

Testing
Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.
Review Checklist:

[x] Reviewed my own code for quality and clarity.
[ ] Added comments to complex or tricky code sections.
[ ] Updated any affected documentation.
[ ] Included tests that validate the fix or feature.
[ ] Checked that related changes are merged.

coverage: 39.297%. remained the same
when pulling 4223257afb8129d6abd1c14078b77ba05607b95b on wait-healthy
into 8de958bcf0f483d225053d9ffbde81b7ddca8743 on main.


Put SWIG-generated files into the correct directory in the python package

What is the goal of this PR?
SWIG-generated library files for python driver (typedb_client_python.py and _typedb_client_python.so) are automatically put into the bazel-out/.../bin directory and typedb module can't reach them. We move them into the typedb directory.
What are the changes implemented in this PR?

We change the paths of all files in bazel-out/.../.../**/* to typedb/**/*.
We updated the rules_python version to 0.24.0 and replaced deprecated pip_install() with pip_parse().

https://github.com/vaticle/typedb-driver-python/pull/304 depends on this PR.

We have rolled in the changes from https://github.com/vaticle/bazel-distribution/pull/378 into this PR, except the nodejs permissioning error fix, which should be easy enough to re-create.


Add username modal component

Adds a component for requesting and saving a username for users.
Also now displays usernames in comments for users with username.

 (0/5) [story] [comment view] As a feedback giving user, after writing and sending a comment, the Feedbacker UI asks for a name if no name is specified, so that I can write my own name or nickname and use name Tobias

Might still need some configuration to be usable in different places, currently optimized for using when adding new comment


chore: Add ash version from ENV and ci matrix

Add ash version from ENV and ci matrix.
Addresses https://github.com/ash-project/ash/issues/50

Pull Request Test Coverage Report for Build cceb3db6d0f896e1a17a1430ab5221d58559c3d8-PR-2

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 0.0%

Totals

Change from base Build 64d2e241b71cb6a86a6f556a54a2507823261c19:
0.0%

Covered Lines:
0

Relevant Lines:
223

💛  - Coveralls

Pull Request Test Coverage Report for Build cceb3db6d0f896e1a17a1430ab5221d58559c3d8-PR-2

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 0.0%

Totals

Change from base Build 64d2e241b71cb6a86a6f556a54a2507823261c19:
0.0%

Covered Lines:
0

Relevant Lines:
223

💛  - Coveralls

Pull Request Test Coverage Report for Build cceb3db6d0f896e1a17a1430ab5221d58559c3d8-PR-2

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 0.0%

Totals

Change from base Build 64d2e241b71cb6a86a6f556a54a2507823261c19:
0.0%

Covered Lines:
0

Relevant Lines:
223

💛  - Coveralls

Pull Request Test Coverage Report for Build cceb3db6d0f896e1a17a1430ab5221d58559c3d8-PR-2

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 0.0%

Totals

Change from base Build 64d2e241b71cb6a86a6f556a54a2507823261c19:
0.0%

Covered Lines:
0

Relevant Lines:
223

💛  - Coveralls

Pull Request Test Coverage Report for Build cceb3db6d0f896e1a17a1430ab5221d58559c3d8-PR-2

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 0.0%

Totals

Change from base Build 64d2e241b71cb6a86a6f556a54a2507823261c19:
0.0%

Covered Lines:
0

Relevant Lines:
223

💛  - Coveralls

Pull Request Test Coverage Report for Build cceb3db6d0f896e1a17a1430ab5221d58559c3d8-PR-2

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 0.0%

Totals

Change from base Build 64d2e241b71cb6a86a6f556a54a2507823261c19:
0.0%

Covered Lines:
0

Relevant Lines:
223

💛  - Coveralls

Pull Request Test Coverage Report for Build 58f1988e81d06659123dd04defbbb982ff7433d9-PR-2

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 0.0%

Totals

Change from base Build 64d2e241b71cb6a86a6f556a54a2507823261c19:
0.0%

Covered Lines:
0

Relevant Lines:
223

💛  - Coveralls

Pull Request Test Coverage Report for Build 58f1988e81d06659123dd04defbbb982ff7433d9-PR-2

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 0.0%

Totals

Change from base Build 64d2e241b71cb6a86a6f556a54a2507823261c19:
0.0%

Covered Lines:
0

Relevant Lines:
223

💛  - Coveralls

Pull Request Test Coverage Report for Build 58f1988e81d06659123dd04defbbb982ff7433d9-PR-2

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 0.0%

Totals

Change from base Build 64d2e241b71cb6a86a6f556a54a2507823261c19:
0.0%

Covered Lines:
0

Relevant Lines:
223

💛  - Coveralls

Pull Request Test Coverage Report for Build 58f1988e81d06659123dd04defbbb982ff7433d9-PR-2

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 0.0%

Totals

Change from base Build 64d2e241b71cb6a86a6f556a54a2507823261c19:
0.0%

Covered Lines:
0

Relevant Lines:
223

💛  - Coveralls

Pull Request Test Coverage Report for Build 58f1988e81d06659123dd04defbbb982ff7433d9-PR-2

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 0.0%

Totals

Change from base Build 64d2e241b71cb6a86a6f556a54a2507823261c19:
0.0%

Covered Lines:
0

Relevant Lines:
223

💛  - Coveralls

Pull Request Test Coverage Report for Build 58f1988e81d06659123dd04defbbb982ff7433d9-PR-2

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 0.0%

Totals

Change from base Build 64d2e241b71cb6a86a6f556a54a2507823261c19:
0.0%

Covered Lines:
0

Relevant Lines:
223

💛  - Coveralls

@zachdaniel this one is good to go too, was the same Elixir version issue.

Great work!
🚀 Thank you for your contribution! 🚀


DIEMS

@omcoolkarni22 First stage of verification passed, official domain is dietms.org as far as I verified. This is just an informational note. Pull request is still in the review. I appreciate your patience while waiting for the final decision.

@omcoolkarni22 Pull request merged. Thank you.


Can this task work on linux pipeline?

We're trying to replace the URL on a script reference in an index.html file.

For me it runs on a x64 Ubuntu. I have no issues with this task


64bits

I implemented support for 64 bits numbers, if you are interested to merge it in, including the rebuilt workflow directly usable with Alfred.

Thanks for this!  Can you amend the PR to not include the binary workflow?  I'll compile that and verify it after I merge the PR.

PR no longer includes my rebuilt binary


new windows issue on ios

@hlta can you describe the issue that this fixes more clearly?

@milkman4
This addresses two issues:

Open a link in new windows
Fix the problem on the checkout page if you are suing (Afterpay , PayPal ... ). These payment provider required to have a checkout page instance open and open their security page in the new window

I think this is still relevant.

@jackkinsella yes, i agree


AltGr+4 prints the "4" before the actual character "~" (Spain's Spanish layout)

This is not a new issue, has been there for almost a year.
With my layout I need to press AltGr+4 to print the "~" character, it works like any other tilde, the 1st press doesn't print anything, in case you want to put the character on top of a letter (ie: ã ñ) and the second press should be an space for the empty tilde or the letter. Pressing AltGr+4 twice will print "~~".
So this is how it works with Terminus:
1st press:  "4". Expected: nothing

2nd press (on Space key): "4~" (the 4 was printed with the 1st press). Expected: "~"
2nd press (on AltGR+4): "44~" (the first 4 was printed with the 1st press). Expected: "~~"

Is the only one with this behaviour, other like ^ ¨ ´ ` work as expected.

I confirm, same problem on FR AZERTY keyboard.
Duplicate of https://github.com/Eugeny/terminus/issues/2866

Same happening for me on a brand new installation. Any workaround?

Same happening for me on a brand new installation. Any workaround?

Not yet, I confirm latest version still has this bug. Very annoying for non qwerty keyboard users.

Duplicate of #768


Can't find portaudio in alpine docker container

I was having trouble locating the portaudio library inside an alpine docker container. It appears that this is because ctypes.util.find_library has trouble finding libraries in some cases. The workaround is to make a symlink to the library without the digit:
apk add portaudio
cd /usr/lib && ln -s [library.name.[0-9]]  [library.name]
I found this solution here: https://bugs.python.org/issue43642
It looks like maybe this issue on the cpython repo has some further discussion:
from: https://github.com/python/cpython/pull/18380
Leaving this issue here for anyone else who is looking for a workaround.
example error text (for searches)
Traceback (most recent call last):
  File "<frozen runpy>", line 198, in _run_module_as_main
  File "<frozen runpy>", line 88, in _run_code
  File "/usr/local/lib/python3.11/site-packages/sounddevice.py", line 71, in <module>
    raise OSError('PortAudio library not found')
OSError: PortAudio library not found

libportaudio alpine docker python portaudio

More discussion here:
https://github.com/docker-library/python/issues/111
https://github.com/python/cpython/issues/65821