Filter Set through filtergroup on dimension field shows up on page.

steps:
in the us container.
create an extension app and extend sales invoice list page and on its onopenpage trigger put filter on dimension value using filtergroup.

now  publish the app and go to sales invoice list page.
try to filter on dimension 1 (department code).
It will show the filter set using filtergroup.

even after chaning the value in the filter field i the page, it keep showing the same filters set through filtergroup.
we have tried with other filter groups, same issue

The typical usage of different filter groups considers that the field that got filtered at group 2 is not going to be available on the page for further filtering by users

Right. And the problem here is that apparently it is. That should not happen: filters set in group 2 should be hidden from the user and applied regardless of their own (group 0) filters.

Hi @shashiBssi, I tried your code and it worked as expected on my side. As @StanPesotskiy mentioned the FilterGroups other then 0 can not be changed by user, for details see https://docs.microsoft.com/en-us/dynamics-nav/filtergroup-function--record-. FilterGroup 2 is not intended to be available on the page. How did you manage to make it visible, any specific steps? Could you also provide the BC/AL version you use. Thank you.
ALProject55.zip

Also, when i filter on this field on top of extension applied filter, it is filtering erratically.
For first value it filters good.
2, 3 different value attempts .... it shows all data.

I can replicate that now that it has been clarified. By revealing filters, adding an empty filter on Department Code, hiding filters, and then revealing filters again, suddenly the filter pane shows ADM|PROD from FilterGroup(2).

Also, when i filter on this field on top of extension applied filter, it is filtering erratically.
For first value it filters good.
2, 3 different value attempts .... it shows all data.
create 2 sales invoice
one with department ADM
another with department PROD.
first sales invoice list will show above two invoice.
filter by ADM.... will show one invoice
filter by PROD.. will show one invoice
filter by ADM... will show TWO invoice (situation) ..... should be only one invoice....

any update on this @AndreyKorepanov @dtkb

Dunno why you're asking me, since I'm just a random user like you, but what I can say is that usually if there is an update then the devs would post it, and asking "any update" just bothers everyone else with useless emails.

Looks like fixed in v17 of BC


Update client to support Meilisearch 0.25

What does this PR do?
This pull request makes sure all tests are working with the Meilisearch 0.25.
I've removed the same methods and tests from your PR.
I've renamed UpdateStatus to TaskInfo and not TaskStatus because TaskStatus is already used by the framework.
Since Index are now created asynchronous, methods are now returning TaskStatus and we have to await for it to finish and then fetch the index.
var indexUid = "IndexFetchExistingIndexPrimaryKeyTest";
var taskInfo = await this.defaultClient.CreateIndexAsync(indexUid, this.defaultPrimaryKey);
await this.defaultClient.Tasks.WaitForPendingTaskAsync(taskInfo.Uid);
var createIndex = await this.defaultClient.GetIndexAsync(indexUid);

It's not very user friendly and I think we should hide from the end user this complexity and make.
The same code should be like this (the way, it is working right now)
var indexUid = "IndexFetchExistingIndexPrimaryKeyTest";
// We await in this call the end of the create index task
var createIndex = await this.defaultClient.CreateIndexAsync(indexUid, this.defaultPrimaryKey);

Also Task related functions and Dump related functions are in their own class.
This reduce a bit the size of the Index.cs class

Hello @juchom thanks a lot for your involvement in this project.
Making this package up to date with MeiliSearch v0.25.0 is a huge work and it's not that easy when you don't know perfectly the changelog.
As you might have seen, I've already started the work on this branch (https://github.com/meilisearch/meilisearch-dotnet/pull/202). I have to do the rest of it and merge it into this PR before merging on main.
Thanks for your work anyway, it will definitely help me update this package
Sorry for the delay in making this package compatible with MeiliSearch v0.25.0, but we are a small team, and the changes in v0.25.0 are huge. We succeeded to release some clients by the release deadline, but not all of them.
Thanks again for being around 😁


Icon logo refactor

Alaska Airlines Pull Request
Summary:
This update is a BREAKING CHANGE. Logo SVGs that were part of the default icons dist are no longer in that group. Logos have been moved to a new location in the dist dir. Also, there is a new RESTRICTED category for icons that are intended for restricted use.
Type of change:
Please delete options that are not relevant.

[x] New capability
[x] Revision of an existing capability
[ ] Infrastructure change (automation, etc.)
[ ] Other (please elaborate)

Checklist:

[x] My update follows the CONTRIBUTING guidelines of this project
[x] I have performed a self-review of my own update

By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.
Thank you for your submission!
-- Orion Design System Team

:tada: This PR is included in version 4.0.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


[build] docker/publish.sh doesn't work for pulsar-all and pulsar-standalone images

Motivation
pulsar-all and pulsar-standalone dont tag correct as pulsar image.
so it fails docker/publish.sh
Modifications
Tag no-repo for both latest and the release version for both pulsar-all and pulsar-standalone
Verify this change
After patching this change, docker/publish.sh works as expected.

retest this please

run java8 tests

run java8 tests

run java8 tests

@sijie @merlimat @codelipenghui
May I ask how "tag no-repo" works here?
When @lhotari added the lightweight test image (https://github.com/apache/pulsar/commit/b47297898146ec8b366e71e2c2e822adfad6784e), there's no such trick and it seems to work fine.
Our published images are with repo prefix also.


Code block highlighting of script tag in html syntax is invalid

Have you read the Contributing Guidelines on issues?

[X] I have read the Contributing Guidelines on issues.

Prerequisites

[X] I'm using the latest version of Docusaurus.
[X] I have tried the npm run clear or yarn clear command.
[X] I have tried rm -rf node_modules yarn.lock package-lock.json and re-installing packages.
[X] I have tried creating a repro with https://new.docusaurus.io.
[X] I have read the console error message carefully (if applicable).

Description
When I upgrade from v2 to v3. I found the html code block not recognize the js code in

Your environment

Docusaurus version used: v3.0.0
Environment name and version (e.g. Chrome 89, Node.js 16.4): Chrome 119, Node.js 18.8.0
Operating system and version (e.g. Ubuntu 20.04.2 LTS): Windows/Mac

Self-service

[ ] I'd be willing to fix this bug myself.

Hi, could you try https://github.com/facebook/docusaurus/discussions/9506#discussioncomment-7506183?

Hi, could you try #9506 (comment)?

Wow... it works. THANKS SO MUCH!

Going to reopen until it gets fixed on prism-react-renderer's end. I'm going to send a issue if no one else has

cc @carloskelly13 any idea what's happening here?
Looks like languages are now loaded in the wrong order? (cf https://github.com/facebook/docusaurus/discussions/9506#discussioncomment-7506183)

@slorber Yeah, good find. The problem is the html (https://github.com/FormidableLabs/prism-react-renderer/blob/master/packages/generate-prism-languages/index.ts#L23) language preset does not highlight script tags. I've fixed this locally with reverting back to top-level markup and will get a patch published here.
Here is an example of the fix doing what I think we want →

Thanks @carloskelly13!
Let me know when it's on npm so that I can test it.

@slorber<EMAIL_ADDRESS>is published. Let me know if this fixes it! Thanks!

Thanks @carloskelly13 👍  I'll test it soon

@carloskelly13 some impacts our visual regression testing tool detected.
(by the way I should have been more careful because when upgrading it reported the regressions 😅 )
It also improves inline style:

It fixes this

But for some reason this one lose its highlighting when upgradng to v2.2

Both cases on page https://docusaurus.io/docs/seo
Not a big deal though, because it was already the case before under v1. I just thought you might like to know about this edge case.


feat: add escape sequence

This is a great idea; thanks! 🎉

Oops. Sorry about closing that.

I've spent a lot of time trying to figure out why this PR didn't run cleanly (and in the process determined that we should probably have never let it run in the first place), but little time looking at the PR itself. So, here's some comments on the PR.
General

Please use sentence case in pull request titles; these are going to end up in the release notes and it'd be great to keep them looking consistent (I've updated this one already)
I strongly encourage the use of emoji in PR titles; they keep something quite boring a little more fun (I try to remember myself, but often forget)

Style
I should probably have a code style guide somewhere for InSeven, but this will have to suffice.

Avoid chaining SwiftUI modifiers; putting each on a new line makes it much easier to quickly glance over the code and see the styles that have been applied

closed in favour of https://github.com/inseven/tinyboard/pull/35


Windows colour workaround breaking...on Windows

I only happened upon this because the systemjs babel plugin is using chalk.  See this ticket here: https://github.com/systemjs/plugin-babel/issues/80
Looks like undefined.open isn't a thing.

I don't see anything in that stack trace that has anything to do with Chalk. Could you post the relevant code?

The issue here was SystemJS builder support for the pattern in ansiStyles:
Object.defineProperty(module, 'exports', {
  get: createExports();
});

I've managed to find a workaround for the underlying use case for now at least.

@sindresorhus why were we doing this again?

@Qix- It's to make immutable. You're the one that added it: https://github.com/chalk/ansi-styles/pull/12 😛


JsGetAndClearException() returns bad pointer

I had an issue with invalid exceptions getting thrown, so I ran some tests in the debugger.  It seems that in certain cases:

JsGetAndClearException() returns JsNoError.
Before calling, JsValueRef value is 0xcccccccc (uninitialized stack variable)
After calling, JsValueRef is 0xcdcdcdcd, indicating freed memory!

ChakraCore version is 1.7.1.

Not a ChakraCore bug; turns out I had called JsSetException() earlier with a bad ref pointer and JsGetAndClearException() was just giving the same bad value back to me. 😞


NODE-4214: Support cert and key values

Description
What is changing?
This change adds back support to keys and certificates being values.
Is there new documentation needed for these changes?
What is the motivation for this change?
The ability to pass ssl keys and certificates as values (instead of file paths) was removed. This creates a security vulnerability in our application by forcing us to write our private keys to the disk.
Double check the following

[ ] Ran npm run check:lint script
[ ] Self-review completed using the steps outlined here
[X] PR title follows the correct format: <type>(NODE-xxxx)<!>: <description>
[ ] Changes are covered by tests
[ ] New TODOs have a related JIRA ticket

Closing the loop: See JIRA ticket for resolution.


downloadPathwayArchive not working

Hi,
I get this error:
rWikiPathways::downloadPathwayArchive(organism="Homo sapiens")
Error in rWikiPathways::downloadPathwayArchive(organism = "Homo sapiens") :
  Could not find a file matching your specifications. Try browsing https://data.wikipathways.org.

sessionInfo
R version 4.4.1 (2024-06-14)
Platform: x86_64-pc-linux-gnu
Running under: Ubuntu 18.04.6 LTS

Matrix products: default
BLAS:   /shared/apps/R/4.4.1/lib/R/lib/libRblas.so
LAPACK: /shared/apps/R/4.4.1/lib/R/lib/libRlapack.so;  LAPACK version 3.12.0

locale:
 [1] LC_CTYPE=C.UTF-8       LC_NUMERIC=C           LC_TIME=C.UTF-8        LC_COLLATE=C.UTF-8     LC_MONETARY=C.UTF-8
 [6] LC_MESSAGES=C.UTF-8    LC_PAPER=C.UTF-8       LC_NAME=C              LC_ADDRESS=C           LC_TELEPHONE=C
[11] LC_MEASUREMENT=C.UTF-8 LC_IDENTIFICATION=C

time zone: Etc/UTC
tzcode source: system (glibc)

attached base packages:
[1] stats     graphics  grDevices utils     datasets  methods   base

other attached packages:
[1] workflowr_1.7.1

Thanks!

Fixed in development branch. You can install it like so...
install.packages("devtools")
library(devtools)
install_github('wikipathways/rWikiPathways', build_vignettes=TRUE)
library(rWikiPathways)

The fix will be included in the upcoming Bioconductor release in October.
Thanks for reporting!


querying databases creating the issue of non-numeric value

/ GET: Fetch Sites by Location
router.get("/catalougesite/:location", async (req, res) => {
const { location } = req.params; // geting the query
try {
const siteRepository = await myDatabase.getRepository(Site);
// get the name of all the sites with location
const sites = await siteRepository.find({
where: { location },
select: ["name"],
});
if (sites.length > 0) {
const siteNames = sites.map((site) => site.name);
// 200 found the sites with given location
res.status(200).json(siteNames);
} else {
// 404 not found the location and sites
res.status(404).send("Not available");
}
} catch (error) {
console.error("Error fetching Sites:", error);
// 500 error while fetching the sites
res.status(500).json({ error: error.message });
}
});
tried to call this end point but get an error of non-numeric value

Could you provide more information about this error? Which branch was this on, how was this endpoint called(in a test file or from a script)?

it should be in sites.js


Unable to resolve modules/files outside of root react-native directory in an ejected project / example monorepo request

Is this a bug report?
Yes

Have you read the Contributing Guidelines?
Yes
Environment
Environment:
OS: macOS Sierra 10.12.4
Node: 8.5.0
Yarn: 0.27.5
npm: 5.3.0
Watchman: 4.9.0
Xcode: Xcode 8.2.1 Build version 8C1002
Android Studio: 2.2 AI-145.3537739
Packages: (wanted => installed)
react: 16.0.0 => 16.0.0
react-native: 0.50.3 => 0.50.3
Target Platform: iOS

Steps to Reproduce

(Write your steps here:)
Hard to write out reproduction steps since this request/bug might be outside of the scope of just react-native...but in any case, see the Readme of linked example repo to reproduce.
Expected Behavior

I expected modules/files to resolve using aliases within a ejected React Native App, since they worked in a non-ejected(CRNA).
Actual Behavior

My setup is pure typescript and includes api, native, core, and infrastructure code. It is setup using yarn workspaces and I am using crna-make-symlinks-for-yarn-workspaces to reference sym linked node_modules in root dir. It is possible this is the root issue, but wanted others input. I had it working with CRNA, but then when ejecting I got this module not found error again and because running react-native run-ios builds successfully I am fairly certain the issue is not related to the node_module linker but instead an aliasing issue.
Here is some more context.

package.json modules
"dependencies": {
    "react": "16.0.0",
    "react-native": "0.50.3"
  },
  "devDependencies": {
    "@types/react": "^16.0.28",
    "@types/react-native": "^0.51.0",
    "babel-plugin-module-resolver": "^3.0.0",
    "babel-preset-react-native-stage-0": "^1.0.1",
  }

babelrc (located in native) Note I need to create aliases to the compiled javascript from typescript.
{
  "presets": ["babel-preset-react-native-stage-0/decorator-support"],
  "plugins": ["transform-react-jsx-source",
    [
      "module-resolver",
      {
        "extensions": [".js", ".ios.js", ".android.js"],
        "alias": {
          "~/core": "../dist/core",
          "~/infrastructure": "../dist/infrastructure",
          "~/native": "../dist/native"
        },
        "cwd": "babelrc"
      }
    ]
  ]
}

What I am trying to import in my react native project
import test from "~/core";
alert(test);

compiles to:

const core_1 = require("~/core");
alert(core_1.default);

Error Im getting

This is a fraction of what I have tried:

Adding { name: "topLevelPath" } to the top level package.json. It works (example import core from "topLevelPath/dist/core", but I can't then alias it.
Removing and adding root in babelrc. Didn't work.
Adding and removing "cwd": "babelrc". Didn't work.
Tried using module-alias instead of babel-plugin-module-resolver. Didn't work.
Adding react-native as the preset. Didn't work.
I reset yarn start -- --reset-cache before every build.
Tried deleting the ios build folder.

My goal is a pure typescript monorepo. Hopefully someone sees something here I have missed.
Reproducible Demo

https://github.com/dalinarkholin/example-typescript-monorepo

To answer my own question, during the eject process for react-native the babelrc preset gets changed from babel-preset-expo to babel-preset-react-native-stage-0/decorator-support
Simple reverting this back fixed the issue. Not sure if any harm will come of it by leaving it as babel-preset-expo
Any thoughts from the react native folks? Thanks for your time.

Is it resolved?  I meet it in version 0.54.2

Future note to myself and others...
yarn workspaces now support the nohoist option so you can set up your root packages like this
{
  "private": true,
  "workspaces": {
    "packages": ["packages/*"],
    "nohoist": ["**/react-native", "**/react-native/**"]
  }
}

here's the blog post: https://yarnpkg.com/blog/2018/02/15/nohoist/


The Stirling Socket Tracer fails to record relevant request and response entries when the response is excessively large

Describe the bug
I have built Stirling and used Stirling_wrapper for testing. I use the redis-benchmark to sent two consecutive get commands.  The value corresponding to this get command is a large value, around 3MB. I can see the requests and responses in tcpdump, but they are not visible in the output of Stirling_wrapper. However, for smaller values, in the range of a few tens of bytes, I can observe them in the Stirling_wrapper output.
redis-benchmark command I executed,  and I have pre-created the key and large value.:
redis-benchmark -h {ip}  -r 3 -c 1 -n 2 get __rand_int__

tcpdump：

I can see the requests and responses in tcpdump.
and redis-benchmark's output:
====== get __rand_int__ ======
  2 requests completed in 0.57 seconds
....

the two request all succeeded.
and the Stirling_wrapper's output:
[redis_events] time_:[2024-03-03 20:19:02] upid:[{0:500714:1082513724}] remote_addr:[<IP_ADDRESS>] remote_port:[6379] local_addr:[-] local_port:[-1] trace_role:[2] req_cmd:[SAVE] req_args:[["3600 1 300 100 60 10000"]] resp:[] latency:[0 seconds] px_info_:[conn_tracker=conn_id=[upid=500714:1082513724 fd=4 gen=10825137247545168] state=kTransferring remote_addr=<IP_ADDRESS>:6379 role=kRoleClient protocol=kProtocolRedis ssl=false record=req=[base=[timestamp_ns=1709497142140662188 byte_size=31] payload=[["3600 1 300 100 60 10000"]] command=SAVE] resp=[base=[timestamp_ns=1709497142140662188 byte_size=0] payload=[] command=] role_swapped=true]
[redis_events] time_:[2024-03-03 20:19:02] upid:[{0:500714:1082513724}] remote_addr:[<IP_ADDRESS>] remote_port:[6379] local_addr:[-] local_port:[-1] trace_role:[1] req_cmd:[CONFIG GET] req_args:[{"parameter":"appendonly"}] resp:[["appendonly","no"]] latency:[0.000650927 seconds] px_info_:[conn_tracker=conn_id=[upid=500714:1082513724 fd=4 gen=10825137247545168] state=kTransferring remote_addr=<IP_ADDRESS>:6379 role=kRoleClient protocol=kProtocolRedis ssl=false record=req=[base=[timestamp_ns=1709497142140011261 byte_size=36] payload=[{"parameter":"appendonly"}] command=CONFIG GET] resp=[base=[timestamp_ns=1709497142140662188 byte_size=19] payload=[["appendonly","no"]] command=] role_swapped=false]
[dns_events] time_:[2024-03-03 20:19:15] upid:[{0:2606493:423948407}] remote_addr:[<IP_ADDRESS>] remote_port:[53] local_addr:[-] local_port:[-1] trace_role:[1] req_header:[{"txid":64014,"qr":0,"opcode":0,"aa":0,"tc":0,"rd":1,"ra":0,"ad":0,"cd":0,"rcode":0,"num_queries":1,"num_answers":0,"num_auth":0,"num_addl":0}] req_body:[{"queries":[{"name":"s3-r-w.eu-west-3.amazonaws.com","type":"AAAA"}]}] resp_header:[{"txid":64014,"qr":1,"opcode":0,"aa":0,"tc":0,"rd":1,"ra":1,"ad":0,"cd":0,"rcode":0,"num_queries":1,"num_answers":0,"num_auth":1,"num_addl":0}] resp_body:[{"answers":[]}] latency:[0.00119556 seconds] px_info_:[conn_tracker=conn_id=[upid=2606493:423948407 fd=17 gen=10825150425737512] state=kTransferring remote_addr=<IP_ADDRESS>:53 role=kRoleClient protocol=kProtocolDNS ssl=false record=req=[header={"txid":64014,"qr":0,"opcode":0,"aa":0,"tc":0,"rd":1,"ra":0,"ad":0,"cd":0,"rcode":0,"num_queries":1,"num_answers":0,"num_auth":0,"num_addl":0} quI20240304 04:19:16.718147 500951 uprobe_manager.cc:985] Number of uprobes deployed = 27
I20240304 04:19:21.739650 501002 uprobe_manager.cc:985] Number of uprobes deployed = 27
I20240304 04:19:24.350064 501034 uprobe_manager.cc:985] Number of uprobes deployed = 9

the above two redis command is not the commands i sent, Those commands were sent by the Redis-benchmark tool.
How to reproduce？
I believe that reproducing this issue should be possible by constructing two extremely large (exceeding 3MB) key-value pairs and then sending consecutive get requests.
my machine environment：
Linux VM-4-9-ubuntu 5.15.0-72-generic #79-Ubuntu SMP Wed Apr 19 08:22:18 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
and redis version：
Redis server v=7.2.4
Stirling version:
just building from source(main branch)

@hengyoush thanks for the detailed bug report. There are some well known issues that cause missing protocol traces as payload size increases (https://github.com/pixie-io/pixie/issues/1755 for example). I need to spend some time trying your instructions and investigating the source of the issue and hope to do that over the next few days.


plan for releasing the training code?

Hi @Steven-SWZhang , thanks for the awesome work.
Do you have any plans for releasing the training code?

Thank you for your interest in our work. We apologize that we currently do not have any plans to release the code for the training portion.


Added snackbar, story book

Added snackbar UI element.
Setup css with variables [not sure if this is a good idea].
Setup a storybook to show example of the element.

Upcoming next
Integrate snackbar to all repos

Fixed all the issues

Renamed snack_bar to snackbar
settings.json / notably adds the new line at the end of files, 120 line width for folding
moved css to under /lib
Removed the config option on the snackbar time on screen

Could you take a look again? Thanks! @marianamarasoiu

Fixed all the issues

Renamed snack_bar to snackbar
settings.json / notably adds the new line at the end of files, 120 line width for folding
moved css to under /lib
Removed the config option on the snackbar time on screen

Could you take a look again? Thanks! @marianamarasoiu


fix: always calculate likelihoods when save_for_report>0 #140

This is an attempted fix for issue #140. I tested locally on the Big Skate model which has lambda = 0 for mean size at age data and the likelihood is now reported (without contributing to the total likelihood).
I also found 4 other locations where adding save_for_report>0 seemed necessary for consistent reporting, a couple of which already had more complex if() statements.
@Rick-Methot-NOAA, could you check the change in this pull request to confirm that I put the parentheses and || in the right places before merging this change?

Great.  We have a good system in place.
Richard D. Methot Jr. Ph.D.NOAA Fisheries Senior Scientist for Stock
Assessments
Mobile:<PHONE_NUMBER>
On Fri, Mar 5, 2021 at 10:54 AM Kathryn Doering<EMAIL_ADDRESS>wrote:

I made sure SS could build with this branch (
https://github.com/nmfs-stock-synthesis/stock-synthesis/runs/2041773884?check_suite_focus=true#step:2:163)
and there were no issues. Also, no changes when running from a par file
with no estimation on jenkins, so at least no uninitialized variables were
caught while building and running with no est.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/nmfs-stock-synthesis/stock-synthesis/pull/141#issuecomment-791614428,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABPV4IDSRRRHSA5LHZ7VAF3TCESEVANCNFSM4YUIAWVA
.


default_runtime for kata-runtime not work

This is part of the configuration of the config.toml file
[plugins.cri.containerd]
      snapshotter = "overlayfs"
      no_pivot = false
      [plugins.cri.containerd.default_runtime]
        runtime_type = "io.containerd.kata.v2"
        runtime_engine = ""
        runtime_root = ""

Run ctr  with default runtime
ctr run --rm busybox:1.30.1 default-kata uname -a
Linux master-0 5.0.0-29-generic #31~18.04.1-Ubuntu SMP Thu Sep 12 18:29:21 UTC 2019 x86_64 GNU/Linux

In the Host exec uname -a
Linux master-0 5.0.0-29-generic #31~18.04.1-Ubuntu SMP Thu Sep 12 18:29:21 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Run ctr with specified runtime
ctr run --rm --runtime io.containerd.kata.v2 busybox:1.30.1 kata uname -a
Linux clr-c1d1d9a844634fb393a2807ca094a404 5.4.32-9.container #1 SMP Fri Nov 13 00:28:56 UTC 2020 x86_64 GNU/Linux

It  seems like that the default_runtime for kata-runtime is not in effect.
Reference documentation: https://github.com/kata-containers/documentation/blob/master/how-to/containerd-kata.md

ctr doesn't use CRI. So this is expected behavior.

you can try it with crictl

thx, close this issue now.


Columns and rows not working properly

Duplicate Check

[X] I have searched the opened issues and there are no duplicates

Describe the bug
When assigning a function to the on_scroll method of a column or a row, it throws a 'KeyError', and, when trying to set a specific height and width to a column and a row respectively, without the on_scroll property, it doesn't work and the content overflows. I'm using Flet 0.23.2 with visual studio code and python 3.12..2,
Code sample
Code
import flet as ft

def main(page:ft.Page):

    def on_scroll(e:ft.OnScrollEvent):
        print(e.data)

    column_on_scroll = ft.Column(
        height = 300,
        on_scroll = on_scroll,
        scroll = ft.ScrollMode.ALWAYS,
        controls = [
            ft.Container(width=100, height=100, bgcolor=ft.colors.RED),
            ft.Container(width=100, height=100, bgcolor=ft.colors.RED),
            ft.Container(width=100, height=100, bgcolor=ft.colors.RED),
            ft.Container(width=100, height=100, bgcolor=ft.colors.RED),
        ]
    )

    column_height = ft.Column(
        height = 200,
        controls = [
            ft.Container(width=100, height=100, bgcolor=ft.colors.RED),
            ft.Container(width=100, height=100, bgcolor=ft.colors.RED),
            ft.Container(width=100, height=100, bgcolor=ft.colors.RED),
            ft.Container(width=100, height=100, bgcolor=ft.colors.RED),
        ]
    )

    page.add(
        ft.Row([
            column_on_scroll,
            column_height
        ])

    )

if __name__ == '__main__':
    ft.app(target=main)

To reproduce
Run the code as a desktop app  and scroll the column, it gaves an error
Expected behavior
Executing the function that is assigned to the on_scrolled method, and when a height is set the content shuldnt overflow, or should it?
Screenshots / Videos

Captures
[Upload media here]

Operating System
Windows
Operating system details
windows 11
Flet version
0.23.2
Regression
I'm not sure / I don't know
Suggestions
No response
Logs
Logs
[Paste your logs here]

Additional details
No response

Please upgrade your Flet version to the latest and retry.


Tests that have reference input files but no reference output files

The following tests have source files and .reference_input files but no .reference_output files:
0337/0337_0021
0338/0338_0085
0338/0338_0086
0691/0691_0042
0691/0691_0099
0691/0691_0103
0691/0691_0104

Thank you for looking at this.  Unfortunately, all of the tests listed in this issue are still missing reference output files.  Can you please fix this?

Why there are tests without reference output is explained in https://github.com/fujitsu/compiler-test-suite/issues/7#issuecomment-2561540567 . If these tests are inconvenient for you, please let us know the situation.


Benchmark not run in MS Test test class

Given the following test class in MS Test:
[TestClass]
public class TestBenchmarkDotNet
{
    [TestMethod]
    public void Test()
    {
        BenchmarkRunner.Run<TestBenchmarkDotNet>();
    }

    [Benchmark]
    public void Benchmark()
    {
        Thread.Sleep(5000);
    }
}

Running Test() from the Visual Studio test runner will not trigger the benchmark method at all, neither in Release or in Debug mode. Is this scenario supported?

No, we don't have the unit test support for now. You should create a console application.

@gabisandor If you want to ask us some questions about BenchmarkDotNet please use our chat.

You should at least be able to run a test, see the output and report Asserts against the results, see this code for example (Xunit, but the approach should work with MS Test)

Seems like a natural extension to unit tests. Nice to have the benchmarks listed in the IDE as tests currently are.

@mms- the thing is that you should have all applications (including IDE) closed when benchmarking, otherwise it can affect your results ;)

@adamsitnik Agree :) Especially now that VS 2015 seems to be using just as much CPU as the unit test while it's running.
But it still has merit. I'm referring to code refactoring with performance as a goal. Meaning you have old code and new code and want to compare what is faster, all the while you need to maintain correctness. Since tests will be updated anyway when this happens you might as well get feedback on performance.
That is often before one does a serious benchmark on a ready piece of code there is a period (usually long) of experimentation to see what gives better results, a guided search if you will. Accuracy of the benchmark does not matter here just the direction, is it faster or not. Getting this info from the IDE would increase productivity, weather through unit tests or some one other VS panel. Perhaps this is something the Visual Studio team could integrate.

But it still has merit. I'm referring to code refactoring with performance as a goal.

@mms- You are right. @ig-sinicyn is working right now on #155 which will give us performance test runner.
@ig-sinicyn @AndreyAkinshin @mattwarren  do you think that we should have our own VS benchmark  runner or maybe have (x/n)unit integration for the incoming performance tests runner?

@adamsitnik We've integration with nUnit, xUnit and MsTest.
xUnit one is quite lame (waiting for https://github.com/xunit/xunit/issues/908), others two work fine. I'm on vacation this week, so no new commits for some time, sorry :)
About accuracy. As @mms wrote there's actually no need in accuracy in unit tests. The thing you want is not accuracy but repeatability. Same code should produce same results on different runs, different machines and on different environments. If this is false the entire thing is failed. We have our tests running on appveyor CI, local buildserver, dev machines, ultrabooks and even tablets. No failures:)
* Of course, all above is true for "common" benchmarks, those that depend hardly on CPU features, memory available or on IO latency will require same-level hardware to get similar results.


Add user/team access tabs for instance groups

Something I noticed here and in some other team/user access tabs was that after a successful addition/removal of access, the corresponding tab (User/Team access) is no longer highlighted as the current tab.


Add examples for advanced data passing, e.g. how to pass x_attr/y_attr

          Can we create an issue for this?

Originally posted by @michalk8 in https://github.com/theislab/moscot/pull/633#discussion_r1444077840

also include set_xy/x/y, and set_graph_xy

main message: "show where we can fetch data from our anndata object"

fetch data from .X (e.g. if you wanna have raw counts)
fetch data from .layers (e.g. if you wanna have normalized counts)
fetch data from .obsm (e.g. if you wanna have PCA, but please do example with something else)

Use a FGW problem, and take different embeddings for all of them, e.g. with the MappingProblem:

x: normalized spatial (no callback here, but something pre-computed (but obv. link to callback))
y: PCA of all single-cel genes
xy: 50 most highly variables genes which are log1p normalized


Wrong file uploaded

Description
I can't manage to upload the file I want. everytime it uploads .ftpconfig even if the file is not opened.
Steps to Reproduce

use upload shortcut cmd+shift+U

Expected behavior: [What you expect to happen]
upload selected tab or file
Actual behavior: [What actually happens]
always upload .ftpconfig
Reproduces how often: [What percentage of the time does it reproduce?]
100%
Versions
1.22.1

The cmd+shift+u triggered remote-ftp:upload-selected command. It upload in selected on TreeView. This command can be changed otherwise in your keymap.cson. By default, it upload once on cmd + s.


Enabling gated check-in leds the build pipeline failed, source code couldn't be check in

I used Azure DevOps build pipeline in my TFVC project, everything worked well. However, the build pipeline ran into failure and the source code couldn't check in after enabling the gated check-in option. no documentation mentioned about this behave.
The gated check-in configuration

The error log
[Error]The shelveset _Build_78;Build\7861acc1-a686-42a0-9a0b-5a43fc3d2bf2 could not be found for check-in

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 86d45218-2e94-7724-67de-cf0d325df210
Version Independent ID: 3c563cbd-6ab1-50e9-75e2-ebcc71a5ae33
Content: Check in to a folder controlled by gated build process - Azure Repos
Content Source: docs/repos/tfvc/check-folder-controlled-by-gated-check-build-process.md
Product: devops
Technology: devops-code-tfvc
GitHub Login: @apawast
Microsoft Alias: sdanie

By the way, the text Required permissions in red box below should be wrapped instead of following the picture.

#reassign @IlyaChistov

Could not reproduce the issue. In my testing everything seems to work as described in documentation.

@IlyaChistov I got the gated check-in working with workaround mentioned in Developer Community # Gated check-in error could not found the shelveset several months ago.

Project > settings > disabled 'limit job authorization scope to current project'

I will create an demo project to reproduce this issue next week.


Unable to save macOS 14 VM state if "Use Trackpad" not enabled

Describe the issue
Unable to save macOS 14 (beta) VM state if "Use Trackpad" is not enabled in VM settings
Steps to reproduce:

Select a macOS 14 beta VM
Edit VM details / Virtualization / uncheck "Enable Entropy Device" & uncheck "Enable Sound" (everything else checked)
Open the VM
Click the red close button in the upper left corner of the VM window

(suspending works, as expected)

Edit VM details
Edit VM details / Virtualization / also uncheck "Use Trackpad"
Open the VM
Click the red close button in the upper left corner of the VM window

What happens: UTM complains that closing the window will kill the VM
Expected: save the state and close

Configuration

UTM Version: 4.4.1 (89)
macOS Version: 14.0 Beta (23A5337a)
Mac Chip (Intel, M1, ...): M1

Yes, this is expected and is an unfortunate requirement imposed by Apple.

So there's a handful of options that Apple doesn't support and they've been changing this throughout the betas so I don't know if this is a bug or something that will be fixed. For example shared directory doesn't work either.


Question: Sparse heterogenous data

Hi, Rudiger, et al,
David Phelan has asked me to look at using this library for dClimate, and I was hoping you could help answer a question for me.
We have weather station telemetry data that has the general form:

timestamp
var1
var2
var3

2023-05-18
2.1

6.5

2023-05-19
2.1

6.5

2023-05-20

2023-05-21
2.1
4.2

2023-05-22
2.1
4.2

2023-05-23
2.1
4.2
6.5

In plain English, for a specific index, we have several variables, any of which may or may not have a value.
David did point me to this older work where it's clear you were thinking about heterogenous data and missing values, but looking at the Banyan repository, it's not obvious to me how these are handled. Is this use case accounted for with Banyan, or should we be looking elsewhere?
If this is an accounted for use case, what's the best way to go about it? Use a separate tree for each variable, using Option<T> for the value, or use a single tree with a tuple value?
I'm not sure if this is related or not, but I don't have a good handle on what the "Forest" abstraction is or does. Is there any information you could provide about that?
Thank you!
Chris

Hi Chris,
this repo just tackles the issue of storing a persistent tree data structure on IPFS, it does not implement the columnar storage that @rklaehn blogged about. Rüdiger should be able to give you better pointers.
Regards,
Roland

Hi @chrisrossi. Just saw this. I try to limit my screen time on Sundays, but will give you a detailed answer some time next week.

Got it. Thank you for clarifying. Will be getting into it this week.
Thanks!
Chris

@rklaehn Is there an open source example of something using the columnar approach with Banyan?
Thanks!
Chris

@rklaehn Is there an open source example of something using the columnar approach with Banyan?
Thanks! Chris

This https://github.com/Actyx/banyan/blob/master/banyan-utils/src/tag_index.rs is a little bit like it, and a long time ago I started on an implementation of this approach in rust here https://github.com/rklaehn/iptm-rs/tree/master/src
But the production quality tag index is in the actyx code base, which is proprietary.
Depending on how your data looks (nested or not) this does not have to be hard though.

Thanks, I'll take a look at those! The data, AFAIK, is all expressible in CSV, so simple tables, no nesting. I'll look at the columnar approach, but I'm also thinking about just adding a field to each row that is a bitmap indicating presence/absence of a variable.
E.G.  this example data, would be transformed:

timestamp
var1
var2
var3

2023-05-18
2.1

6.5

2023-05-19
2.1

6.5

2023-05-20

2023-05-21
2.1
4.2

2023-05-22
2.1
4.2

2023-05-23
2.1
4.2
6.5

to this (2023-050-20 can be omitted):
2023-05-18, 0b101, 2.1, 6.5
2023-05-19, 0b101, 2.1, 6.5
2023-05-21, 0b110, 2.1, 4.2
2023-05-22, 0b110, 2.1, 4.2
2023-05-23, 0b111, 2.1, 4.2, 6.5
Obviously, anticipating data with many more than 3 columns.

Just f64 values, no need for a variant? How many columns approximately?
So a value would be something like
struct Row {
  time: u64,
  values: BTreeMap<String, f64>,
}

?

Yes, I was asking what is in a Row in principle. Storing this exactly as is would be inefficient obviously.
So what you would do if you wanted a columnar approach would be to define a RowSeq type that efficiently stores a sequence of rows, and then use that in banyan. E.g. something like this:
struct RowSeq {
  names: Vec<String>, // names, unique (or unique and sorted)
  times: Vec<u64>, // time for each row, should be delta encoded when serializing
  colums: Vec<Column>, // columns, same number of items as names
}

struct Column {
  values: Vec<f64>, // values
  times: Vec<usize>, // indexes into the times table, guaranteed to be strictly sorted, should be delta encoded when serializing
}

Ok, so if I'm following along, RowSeq is the value type stored in Banyan. So instead of storing a single row per index in the Banyan tree, we'll store a certain number of rows (transformed into columnar format) at each index in the tree. Is there a heuristic for deciding how many rows to store in a RowSeq? Or have I misunderstood?

@rkuhn any chance you can open source some of the relevant code? It would be really helpful here I think.

Ah, turns out that the tag index part is open source already. It is not exactly what you need, but it might help as inspiration...
https://github.com/Actyx/cbor-tag-index


[ADD] Debug Function with Variadic Functions

This commit adds two variadic functions based debugger, which helps in better readability of the code. One functions end with a newline, and one doesn't. In the functions, we can pass any number of arguments to the functions that will print them space-separated when DEBUG Flag is defined. Also, build.sh is added for easily move library to samples folder.

I have updated the code wherever it was applicable. Please have a look. Thanks for the suggestions.
cc @krshrimali

Thanks, @rajivnayanc for the contribution. LGTM. 🚀

Thank You! Looking forward to make more contributions. :)


Autocomplete is activated when attempting to add tab

This is very annoying, In the JS window the trigger for AC is Tab. Most of the time i just want to indent my code and i get the autocomplete.
Maybe Ctrl + Enter would be a better key combination.
Thanks for this project - my online editor of choice.
Keep up the good work.

This issue appears to be back. Can we reopen it?


TS2708: Cannot use namespace 'LazyCookie' as a value.

TypeScript Version<EMAIL_ADDRESS>
Search Terms:
Code
LazyCookie in jsdom-extra
https://github.com/bluelovers/jsdom-extra/blob/1ffaa074fd08407ffc1ab8beb135101473005397/lib/cookies.ts#L5-L17
LazyCookie in lazy-cookies
https://github.com/bluelovers/ws-rest/blob/1250d03b98cbe9305f21afc9664e077a374e8135/packages/lazy-cookies/index.ts#L10
import { LazyCookie, LazyCookieJar } from 'jsdom-extra/lib/cookies';
import { LazyCookie as LazyCookie2 } from 'lazy-cookies';

let a;

// @ts-ignore
console.log(a instanceof LazyCookie)

// @ts-ignore
console.log(a instanceof LazyCookie2)

Expected behavior:
"use strict";
Object.defineProperty(exports, "__esModule", { value: true });
const cookies_1 = require("jsdom-extra/lib/cookies");
const lazy_cookies_1 = require("lazy-cookies");
let a;
// @ts-ignore
console.log(a instanceof cookies_1.LazyCookie);
// @ts-ignore
console.log(a instanceof lazy_cookies_1.LazyCookie);

Actual behavior:

TS2708: Cannot use namespace 'LazyCookie' as a value.

ReferenceError: LazyCookie is not defined

Object.defineProperty(exports, "__esModule", { value: true });
const lazy_cookies_1 = require("lazy-cookies");
let a;
// @ts-ignore
console.log(a instanceof LazyCookie);
// @ts-ignore
console.log(a instanceof lazy_cookies_1.LazyCookie);

Playground Link:
https://www.typescriptlang.org/v2/en/play?module=1#code/JYWwDg9gTgLgBAbzgGQIYC8CeBhCEDWwApgDQoY56FEBSqUcAvnAGZQQhwDkAVgM4ATDgFoiADxhRUAegA2wAEbSAxlWJ8uAbgBQoSLETksuAsTio+RyqaIAmJq3acusisNU2NO7bKLxU3tLScAACMHzCwADmAHbQRNqqMXwQvgB0shBRABSocMDJMKgxykQQLFYm1ACU2tpBoeGRsfGJEMmpRBlZufmFxaXllWp2tdpAA
Related Issues:

I think jsdom-extra is attempting to augment the LazyCookie namespace and re-export it, but it is doing so incorrectly. We should be reporting an error due to the conflicting definitions for LazyCookie in that library:
// imports a class which is both a value and a type
import { LazyCookie } from "lazy-cookies";

// re-exports the class
export { LazyCookie };

// this should be an error as you can't augment the class this way...
export namespace LazyCookie {
  interface Properties { ... }
}

In addition, it seems like we see the definition of LazyCookie from jsdom-extra and interpret it as an "uninstantiated namespace" (i.e., an ambient namespace that only contains types), which does not give it a "value" meaning. Since it doesn't have a "value" meaning, it can't become "referenced", so we don't emit it.
There are two bugs here for the compiler, and one in jsdom-extra:

typescript - You should not be able to have both an import and a namespace of the same name. We generally allow this when the two declarations do not share a meaning (i.e., one can be a "value" and the other can be a "type"), but a class is both a "value" and a "type" so this shouldn't have been allowed.
typescript - We may need to reconsider how we handle the above import (which should be considered an error) even when --skipLibCheck is enabled.
jsdom-extra - Needs to update cookies.ts to the correct approach for module augmentation (as they will be broken if we fix (1), above):import { LazyCookie, ... } from "lazy-cookies";
...
export { LazyCookie };

// correct way to augment `LazyCookie`
declare module "lazy-cookies" {
  namespace LazyCookie {
    interface Properties { ... }
  }
}

Given that there's at least one external problem here, I'm calling this external. The other issues can be looked at if someone else runs into them.


Artifactory Plugin causes Bamboo 5.6.0 to not start

It looks like the version of Guava changed in Bamboo 5.6.0 and so on startup with this plugin installed, there is a NoClassDefFound exception.
org.springframework.beans.BeanInstantiationException: Could not instantiate bean class [com.atlassian.bamboo.build.logger.DefaultBuildLoggerManager]: Constructor threw exception; nested exception is java.lang.NoSuchMethodError: com.google.common.cache.CacheBuilder.build(Lcom/google/common/cache/CacheLoader;)Lcom/google/common/cache/LoadingCache;
Caused by: org.springframework.beans.BeanInstantiationException: Could not instantiate bean class [com.atlassian.bamboo.build.logger.DefaultBuildLoggerManager]: Constructor threw exception; nested exception is java.lang.NoSuchMethodError: com.google.common.cache.CacheBuilder.build(Lcom/google/common/cache/CacheLoader;)Lcom/google/common/cache/LoadingCache;
Caused by: java.lang.NoSuchMethodError: com.google.common.cache.CacheBuilder.build(Lcom/google/common/cache/CacheLoader;)Lcom/google/common/cache/LoadingCache;
	at com.atlassian.bamboo.build.logger.DefaultBuildLoggerManager.<init>(DefaultBuildLoggerManager.java:37)
	at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
	at sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:57)

@elig - The mirror issue BAP-218 is resolved, so this one can be closed too I guess?!


Create KIND deployment option for MLX including KFP

See local cluster deployment options for Kubeflow Pipelines at https://www.kubeflow.org/docs/components/pipelines/installation/localcluster-deployment/.
The MLX API and UI should simply be deployed on top of that. Easy as pie 😄 🍰

/assign @sabary661990615

FYI non org members only can self assign issues.

FYI @romeokienzler -- Yash is working on a KIND deployment option for MLX


Missing type definitions in webcryptoapi.dart

In 1.0.0, some SubtleCrypto methods have untyped parameters, thus making them hard to use:
E.g. importKey():

Before 1.0.0, it was possible to figure out and pass KeyAlgorithm(name: 'AES-GCM') as the algorithm argument. This class is however gone in 1.0.0.
Other missing definition examples are AesGcmParams, which was useful for SubtleCrypto.encrypt()/ SubtleCrypto.decrypt().
Current implementation of AlgorithmIdentifier is a simple typedef:
typedef AlgorithmIdentifier = JSAny;

Hmm, this may be a bug with the Web IDL but not sure.
KeyAlgorithm is defined but never used in the IDL except as a superinterface: https://github.com/w3c/webref/blob/5308f9a9c0914d765fcbbb55f7d01d313ae37eda/ed/idl/WebCryptoAPI.idl#L25. The subinterfaces are never referred to either.
https://github.com/dart-lang/web/commit/7604578eb538c471d438608673c037121d95dba5 uses the MDN compatibility data to avoid emitting experimental/nonstandard APIs. MDN doesn't contain compatibility data for dictionaries, so we depend on whether or not its used by a non-experimental/standard API to determine if we should emit the dictionary. Here, KeyAlgorithm is never actually used except as a superinterface, and the subinterfaces are never used either: https://github.com/w3c/webref/blob/5308f9a9c0914d765fcbbb55f7d01d313ae37eda/ed/idl/WebCryptoAPI.idl#L25. The case is the same with AesGcmParams: https://github.com/w3c/webref/blob/5308f9a9c0914d765fcbbb55f7d01d313ae37eda/ed/idl/WebCryptoAPI.idl#L206.
We could instead choose to only not emit dictionaries that are explicitly used by experimental/nonstandard APIs, and that may cover this, but it also may mean we're including some dictionary types that are subject to change often.


Polygonscan API update

Polygonscan updated their API code, it now takes the action=tokennfttx switch same as Etherscan, so you'll need to check both =tokentx and =tokennfttx, if you aren't already doing so.

@JamesSmartCell Hmm.. we have always done it that way. But just to be sure, here's how we classify the chains to decide whether to use tokennfttx (those returning .etherscan does): https://github.com/AlphaWallet/alpha-wallet-ios/issues/3859


Licenses requirements update

I have updated license requirements for Microsoft Defender Advanced Threat Protection.
Problem: https://github.com/MicrosoftDocs/windows-itpro-docs/issues/7094

@JohanFreelancer9 - kindly do the copy editor review for this PR. Thanks.

Applied changes as per @JohanFreelancer9


Add project role email goes to owner not role recipient

Linked to https://github.com/zooniverse/Panoptes-Front-End/issues/1749#issuecomment-260837490
The project owner gets the email about new roles and not the role recipient. Here should probably be using the linked user instead of the api user.

@zwolf you fancy fixing this bug ?

also interestingly when I added some people I didn't get the email at all. I added Chris to the project shortly after that as well and I didn't get an autoemail. Oddly only for the new user account both when I included and then revised the role. I wonder if there is also a bug where if your account is already on some other Zooniverse project then you don't get this email about be adding to a new different one

@zwolf is this fixed now?

Closed by https://github.com/zooniverse/Panoptes/pull/2068


As a pet owner, I want to create a profile for my pet, so that potential pet sitters can understand my pet's needs and preferences. [1]

completed


[CRITICAL] SBF fix for do-not-use values

We have encountered a case on an AsteRx-m2 UAS where do-not-use values were being reported in velocity fields without a corresponding error code or fix-type 0. Support confirmed that this is happening. This adds a check for known invalid data and sets the appropriate flags.
Unfortunately I have currently no hardware to test this anymore. Not 100% sure if this is the best way to do the checks.
Note that if the glitches are short, EKF will reject the extreme velocity values and it goes unnoticed. Other estimators might behave differently.

Note that the m2 reference specifies in a very broad and general sense that these do-not-use values might occur at anytime in any field (in theory). We might want to extend the checks further.


Use quorum queues for higher reliability

As opposed to the use case of automatically generated, exclusive queues, a named queue should be as reliable as possible. For that reason, I added the durable queue option in #312. Since RabbitMQ 3.8 reliable HA queues are of type quorum which replace the legacy mirrored queues. This merge-request changes the options when creating named queues accordingly.
https://www.rabbitmq.com/quorum-queues.html

Coverage increased (+0.3%) to 59.351% when pulling 425a688fbfdc58049906259e8d159c35b4011388 on feature/use-quorum-queues-for-higher-reliability into 0bee059abd7ee0d1ca9b48d90bfb3b0e083abdfb on main.


Thread shift for 0.18

Merges #1411 into master.

Codecov Report

Merging #1422 into master will increase coverage by 1.72%.
The diff coverage is 77.77%.

@@            Coverage Diff             @@
##           master    #1422      +/-   ##
==========================================
+ Coverage   71.22%   72.95%   +1.72%
==========================================
  Files         259      259
  Lines        6041     6039       -2
  Branches      364      367       +3
==========================================
+ Hits         4303     4406     +103
+ Misses       1738     1633     -105

Impacted Files
Coverage Δ

...scala/org/http4s/server/tomcat/TomcatBuilder.scala
45.07% <ø> (+15.49%)
:arrow_up:

...c/main/scala/org/http4s/server/ServerBuilder.scala
66.66% <0%> (-6.07%)
:arrow_down:

...ala/org/http4s/server/blaze/Http1ServerStage.scala
74.02% <100%> (-0.05%)
:arrow_down:

.../main/scala/org/http4s/servlet/Http4sServlet.scala
64.7% <83.33%> (+64.7%)
:arrow_up:

.../scala/org/http4s/testing/ArbitraryInstances.scala
92.21% <0%> (-7.79%)
:arrow_down:

core/src/main/scala/org/http4s/AttributeMap.scala
47.61% <0%> (+4.76%)
:arrow_up:

core/src/main/scala/org/http4s/HttpVersion.scala
100% <0%> (+6.66%)
:arrow_up:

...n/scala/org/http4s/server/jetty/JettyBuilder.scala
45.83% <0%> (+15.27%)
:arrow_up:

...n/scala/org/http4s/server/blaze/BlazeBuilder.scala
38.7% <0%> (+20.43%)
:arrow_up:

... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a588d6...96d6121. Read the comment docs.


How to handle Modal OnDismissed event

Hi,
I cannot handle onDismissed event from modal panel.
Can you please support me with an example ?
Best Regards,
Ciro

Hello! If you mean utilizing the onDismissed callback, it's as easy as passing in a pre-defined function or anonymous function when you initialize the modal plugin like so:
$('[data-aljs="modal"]').modal({
    onDismissed: function(e) { // your stuff here }
});

You can also take advantage of our namespaced event that the modal itself fires:
$('#my-modal').on('dismissed.aljs.modal', function(e) { // your stuff here });

Hi Kevin,
very appreciated your answer.
I tried to handle onDismissed event in both ways.
Unfortunately with no luck. It seems onDismiss event is not rised.
Do you have any idea about it ?
Best Regards,

This must be a bug on the latest release. I'll check it out when I can and report back!

Hi @tuxolino, it seems to be working on our end. What version of ALJS are you running, and would you be able to provide the code you're using so we can assist you? Thanks!


NOISSUE - fix security doc

Signed-off-by: Manuel Imperiale<EMAIL_ADDRESS>

Codecov Report

Merging #897 into master will decrease coverage by 0.04%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #897      +/-   ##
==========================================
- Coverage   84.58%   84.54%   -0.05%
==========================================
  Files          74       74
  Lines        4879     4879
==========================================
- Hits         4127     4125       -2
- Misses        511      513       +2
  Partials      241      241

Impacted Files
Coverage Δ

things/service.go
86.61% <0%> (-1.41%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ddbf172...0fcfed4. Read the comment docs.


[FX-5057] Migrate ButtonAction to TailwindCSS

FX-5057
Description
We are going to migrate ButtonAction to TailwindCSS and new MUI Base Button
How to test

Temploy

Development checks

N/A Add changeset according to guidelines (if needed)
[x] Read CONTRIBUTING.md and Component API principles
[x] Make sure that additions and changes on the design follow Toptal's BASE design, and it's been already discussed with designers at #-base-core
[x] Annotate all props in component with documentation
N/A Create examples for component
[x] Ensure that deployed demo has expected results and good examples
[x] Ensure the changed/created components have not caused accessibility issues. How to use accessibility plugin in storybook.
[x] Self reviewed
[x] Covered with tests (visual tests included)

All development checks should be done and set checked to pass the
GitHub Bot: TODOLess action

PR commands

List of available commands:

@toptal-bot run package:alpha-release - Release alpha version
@toptal-anvil ping reviewers - Ping FX team for review

PR Review Guidelines

When to approve? ✅
You are OK with merging this PR and

You have no extra requests.
You have optional requests.

Add nit: to your comment. (ex. nit: I'd rename this variable from makeCircle to getCircle)

When to request changes? ❌
You are not OK with merging this PR because

Something is broken after the changes.
Acceptance criteria is not reached.
Code is dirty.

When to comment (neither ✅ nor ❌)
You want your comments to be addressed before merging this PR in cases like:

There are leftovers like unnecessary logs, comments, etc.
You have an opinionated comment regarding the code that requires a discussion.
You have questions.

How to handle the comments?

An owner of a comment is the only one who can resolve it.
An owner of a comment must resolve it when it's addressed.
A PR owner must reply with ✅ when a comment is addressed.

Cool to see Toptal on https://twitter.com/Base_UI


Governing body detail page

It requires a change in the backend that is in this PR.

I'll update this to use the new card component!


Failure to download an image required for a transform makes site innaccessible

Hi, I am working on a Craft site that is being run on a number of different dev, test and prod environments. Images are loaded from S3.
One dev site in particular cannot access S3 due to the way the network here is set up (corporate environment). That means that image transforms fail. I believe it is the calls to craft.imager.transformImage() from the twig templates.
It is correct that the image transforms fail as the images are not accessible but it would be great if the site was still accessible. Right now an exception is thrown, there does not seem to be any way to catch an exception in Twig, and so the site just displays error output. The exception message is below:
cURL error “60” encountered while attempting to download “image url”. The error was: “SSL certificate problem: unable to get local issuer certificate”
The exception appears to be being thrown in Imager_ImagePathsModel::_downloadFile()
Ideally there would be a way to get the site to still load without images. Perhaps logging an error and returning null instead of throwing an exception.

Following up with a work around for my specific error plus, possibly, a bug in imager.
To avoid the SSL error I needed CURLOPT_SSL_VERIFYPEER to be set to false (really I needed the network to be set up differently but that is not within my control). Setting CURLOPT_SSL_VERIFYPEER within curlOptions in config.php seems to have no effect. However adding CURLOPT_SSL_VERIFYPEER to the $defaultOptions array in _downloadFile() did however cause SSL to be bypassed allowing the image transforms to occur.
Should the value in config.php be used?

Regarding your first post, if you don't want twig to throw exceptions, you can set suppressTemplateErrors => true in your config. I'll have a look at the curl options thing.

I misread your second post, there wasn't actually an issue there... :)
Did you try the suppressTemplateErrors setting to avoid exceptions?

We didn't as ideally we could still see other errors in the browser as this is for development sites. Right now we have modified our code to turn off CURLOPT_SSL_VERIFYPEER if the site is running at localhost. If it is at localhost it is likely running within the corporate network so SSL connections to outside the network are likely to fail. Pretty ugly solution but it does get things functional.
There may still be some value in adding a config setting to have imager log an error rather than throwing an exception. If you do not feel that there is value in that then go ahead and close this :)

This issue has been causing us problems too. In our case the images should exist locally on the server, but there are cases in production where it's acceptable to for that image to not be present as they are downloaded from an external source, if that source should fail to download we attempt to download it in a second pass later, but in the meantime we have an entry that may be missing one of it's many images.
If that image doesn't exist in the file system a fatal error is thrown. The   'suppressTemplateErrors' => true, setting does work for us, but I consider this a workaround for us. As the issue really for us is this error shouldn't be considered fatal, and in suppressing all errors we could end up missing other errors that we should see.

Ok, I guess I could add a suppress errors thing to Imager too.

I'm not sure an option to suppress all errors is needed, that wouldn't make sense to me. The issue here I feel is why kill the entire page with a fatal error just for a missing image. Perhaps a way to change the severity of the missing image error maybe?

There's not really many options when it comes to how errors are returned to the template. Either the plugin has to cast an exception, which is what it does now, or it has to return something to the template that can gracefully be handled by the developer (ie, you get null back, instead of a working Imager_ImageModel).
But, by "The issue here I feel is why kill the entire page with a fatal error just for a missing image.", do you mean a missing remote/external image? I guess it could be nice if the config setting had the options false, true, and remoteonly, maybe? So if the setting was remoteonly, only the errors caused by missing remote images would make Imager silently return null, while all other errors would raise an exception like it does now. What do you think about something like that?

Null back would be perfectly fine for us. In reality a missing image is going to be very much down to the individual project, so some it maybe considered fatal, in our case it would never be fatal, images are always associated with content therefore there is no need to not show the content just because the image is missing.
In our case, we are not downloading images remotely, they all exist in a local folder, outside of crafts assets index. The reason in our case that images may not exist is the images are downloaded from an external XML feed, but in the case that a download fails, we deem this not serious, and reattempt the download later. However the feed at this point has already been imported so we now have potential for it to fail.
If for example Imager gives us the option to output something to the template to hand this gracefully, that would be perfect, as we could then output a placeholder image to the template, and perhaps even if we did consider it a serious problem, come up with some way to notify and admin of the situation.

Has there been any progress on this issue? If not, I don't mind having a crack with a pull request?

No, I haven't had time to do it yet. Feel free to submit a PR if you want to give it a go.
I've given it some thought, and I think the most natural way to solve this is to return null to the template if an external file couldn't be loaded. Preferably hidden behind a config setting to keep backwards compability.

A new config option has been added in version 1.3.0, suppressExceptions, that when enabled, logs errors and instead returns null to the templates.


Fix import cirq

Description of the issue
Using Python 3.10, and the most updated cirq on pip (0.13.1) fails to import properly
How to reproduce the issue
>>> import cirq
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/usr/lib/python3.10/site-packages/cirq/__init__.py", line 15, in <module>
    from cirq import _import
  File "/usr/lib/python3.10/site-packages/cirq/_import.py", line 25, in <module>
    class InstrumentedFinder(importlib.abc.MetaPathFinder):
AttributeError: module 'importlib' has no attribute 'abc'. Did you mean: '_abc'?

I can import correctly with:
>>> from importlib import abc; import cirq

Hey @quosta, this was fixed in https://github.com/quantumlib/Cirq/issues/4637. You can get the fix my installing the nightly version of Cirq. I will close this issue; but please ask questions if you have them.


Does Orbit DB create roughly N² rooms for N IPFS peers on the same database?

It appears that whenever a new IPFS peer joins a database, a separate IPFS PubSub subscription is created between them. Thus, if we have four peers, and one new peer joins, four new subscriptions are created. The total number of subscriptions is then (number of peers) * (number of peers - 1).
In looking at the code that is run when a peer connects:
https://github.com/orbitdb/orbit-db/blob/master/src/OrbitDB.js#L173-L205
and
https://github.com/orbitdb/orbit-db/blob/master/src/exchange-heads.js#L21
I tested this locally and it seems to be the case. When I'm running paired OrbitDB instances and IPFS instances, and I list active IPFS PubSub subscriptions on one of those IPFS peers, I see a subscription for the pairs of that peer and each other peer. For example, if I'm on PeerA, and have four other database peers online, I'll see subscriptions to rooms:
DBAddress
/.../PeerA/PeerB
/.../PeerA/PeerC
/.../PeerA/PeerD
/.../PeerA/PeerE

Peer B will have subscriptions to
DBAddress
/.../PeerA/PeerB
/.../PeerB/PeerC
/.../PeerB/PeerD
/.../PeerB/PeerE

Etc.
Is this correct?
This seems to be a concerning scaling limit.
I've heard IPFS PubSub has issues with too many rooms. N² subscription growth would seem to put a pretty strong limit on how many peers could be online at one time. If I have a 10,000 users online at the same time, that's 99,990,000 IPFS PubSub rooms, which, I'm guessing would have IPFS PubSub broken a long time before that point.
All the rooms won't exist on every IPFS node, but I'm thinking that "hub" IPFS nodes or IPFS bootstrap nodes could get a lot.
Sample code below, just change ports and run from a a different directory each time you launch:
const IPFS = require('ipfs')
const OrbitDB = require('orbit-db')

const ipfsOptions = {
  EXPERIMENTAL: {
    pubsub: true
  },
  config: {
    Addresses: {
        Swarm: [
          '/ip4/<IP_ADDRESS>/tcp/4062',
          '/ip4/<IP_ADDRESS>/tcp/4063/ws'
        ],
        API: '/ip4/<IP_ADDRESS>/tcp/5062',
        Gateway: '/ip4/<IP_ADDRESS>/tcp/9160'
      },
  },
  repo: '.'
}

// Create IPFS instance
const ipfs = new IPFS(ipfsOptions)

ipfs.on('error', (e) => console.error(e))
ipfs.on('ready', async () => {
  const orbitdb = new OrbitDB(ipfs)

  // Create / Open a database
  const db = await orbitdb.log('DBNAME')
  await db.load()

  // Listen for updates from peers
  db.events.on('replicated', (address) => {
    console.log("replicated")
  })

  // Add an entry
  const hash = await db.add('world')
  console.log(hash)

})

// Show this peer's active subscriptions
setInterval(async () => {
    console.log("-----")
    console.log(await ipfs.pubsub.ls())
}, 2000);

Short answer: no.
For exchanging the heads upon connecting, there's a 1-to-1 connection between each peer across all databases, so each peer only has one subscription to every other peer. There's also only one connection between peers on libp2p level.

The total number of subscriptions is then (number of peers) * (number of peers - 1).

The total number of subscriptions per peer is 1 * number of peers.

Each peer has N subscriptions, but the total number of distinct rooms used across all the connected database instances is roughy N², right?
And something like the IPFS pubsub bootstrap nodes would we see all of these if the local IPFS PubSub node is in its default config?


ENH: Add FOH and equivalent impulse response discretizations to scipy.signal.cont2discrete

Two additional methods for discretization of continuous LTI systems. SciPy definitely lacks them. The realizations are based on the theory from book "Digital control of dynamic systems" by Franklin, Powell, and Workman.

Thanks for the contribution @balodja . Unfortunately we can't use any of the material from matlab regardless of its triviality. You can add another example from Franklin & Powell.

Unfortunately we can't use any of the material from matlab regardless of its triviality. You can add another example from Franklin & Powell.

Sorry for a confusion. I mean that the FOH result for that particular test I have computed with matlab. Just like some other tests in scipy.signal, e.g. https://github.com/scipy/scipy/blob/master/scipy/signal/tests/test_cont2discrete.py#L331

I have changed the vstack/hstack for the block, and added a brief comment with the source of true values in the test.

@ilayn I would like also to add impulse discretization method. Should I do it in this PR?

Sorry for a confusion. I mean that the FOH result for that particular test I have computed with matlab. It's just like some other tests in scipy.signal

Ah, my bad. Sorry. Do you mind clarifying that sentence a bit more? You can mention that the values are compared, in agreement or verified with matlab or something like that.

I would like also to add impulse discretization method. Should I do it in this PR?

Often we try to keep things separate for review convenience but I think we can accommodate the impulse invariance method here too.

@ilayn is it OK now? I have corrected the FOH code, added impulse method, and changed description.

I have added some more interesting tests that check the invariants: step invariance of zoh method, linear invariance of foh method, and impulse -- of... yep, of impulse one.
@ilayn could you take a look, please?

@ilayn done

Great! Thanks a lot @balodja

Nice. This may be worth a mention in the release notes. @balodja would you mind adding 1-2 sentences about this feature in https://github.com/scipy/scipy/wiki/Release-note-entries-for-SciPy-1.3.0#scipysignal-improvements


GRG Widget - tasks don't execute when published to a single gp service

Widget
GRG
Version of widget
0.1.0
Bug or Enhancement
The "Create Area GRG", "Create Point GRG", and "Delete GRG" tools will execute successfully if each tool is published as a separate GP service; however, they will not execute if the tools are published to a single GP service.
Receive error:
cannot open '\server\arcgisserver_directories\arcgissystem\arcgisinput\Test\GRG.GPServer\extracted\v101\Military.sde\GRGGrid'
Repo Steps or Enhancement details
@adgiles FYI

@elinz GP service is no longer needed in the new GRG widget.