In _core.py: set of variables related issues

In order not to spam everyone and create n issues, I pushed my branch Issue30_pep8 parsed with a flake8 git hook gives the following errors:

tofu/geom/_core.py:2083:9: E743 ambiguous function definition 'I'
tofu/geom/_core.py:2090:21: E741 ambiguous variable name 'I'
tofu/geom/_core.py:2098:13: E741 ambiguous variable name 'I'
tofu/geom/_core.py:2100:13: E741 ambiguous variable name 'I'
tofu/geom/_core.py:3907:20: F821 undefined name 'self'
tofu/geom/_core.py:3912:16: F821 undefined name 'self'
tofu/geom/_core.py:3914:36: F821 undefined name 'self'
tofu/geom/_core.py:4822:24: F821 undefined name 'Dsi'
tofu/geom/_core.py:4822:29: F821 undefined name 'usi'
tofu/geom/_core.py:5012:24: F821 undefined name 'force'
tofu/geom/_core.py:5078:20: F821 undefined name 'Nonei'
tofu/geom/_core.py:5464:17: F841 local variable 'kRMin' is assigned to but never used
tofu/geom/_core.py:5858:17: F841 local variable 'kh' is assigned to but never used
tofu/geom/_core.py:6203:34: F821 undefined name 'fkwdargs'

I verified all of them and they are non-trivial (except maybe from Nonei which is probably a typo).
@Didou09 I'll leave you the handling of the branch, so you can change it as you want.

Again, these errors found by flake look like they are actually bugs, or could be bugs in the future:

tofu/geom/_core.py:2019:9: E743 ambiguous function definition 'I'
tofu/geom/_core.py:2026:21: E741 ambiguous variable name 'I'
tofu/geom/_core.py:2034:13: E741 ambiguous variable name 'I'
tofu/geom/_core.py:2036:13: E741 ambiguous variable name 'I'
tofu/geom/_core.py:4695:24: F821 undefined name 'Dsi'
tofu/geom/_core.py:4695:29: F821 undefined name 'usi'
tofu/geom/_core.py:4885:24: F821 undefined name 'force'
tofu/geom/_core.py:4948:20: F821 undefined name 'Nonei'
tofu/geom/_core.py:5334:17: F841 local variable 'kRMin' is assigned to but never used
tofu/geom/_core.py:5746:13: F841 local variable 'indt' is assigned to but never used
tofu/geom/_core.py:5871:17: F841 local variable 'kh' is assigned to but never used
tofu/geom/_core.py:6217:34: F821 undefined name 'fkwdargs'

Good point, will look at it tomorrow

@lasofivec since Pr #240 is now merged and closed, I label this issue "fixed in devel", ok for you ?

No... I don't see the relationship between the two 😅
This issue is related to the two comments above... which have nothing to do with the additional files that were introduced at another PR into devel.

I just realized you meant it was solved in PR #236
Then yes :)

Yes, sorry, I wasn't clear:
PR #236 also solves this issue


Unable to close sarama.AsyncProducer

The sarama.AsyncProducer needs to Close

@llife09 if this is bug report, it's quite short. Logrus hook interface doesn't have special "Close" method. And in theory only one hook should be created per one hook assignment. So, in general, only one or several required amount of objects will be created, it will save from resource leakage. But graceful producer termination seems difficult for realization here.


Fix: ArgumentError (negative argument) if message is shorter than titles

Describe the change
It fixes the following bug:
> TTY::Box.error('BOO!')
Traceback (most recent call last):
        4: from /home/daniel/.rvm/gems/ruby-2.6.0/gems/tty-box-0.5.0/lib/tty/box.rb:165:in `error'
        3: from /home/daniel/.rvm/gems/ruby-2.6.0/gems/tty-box-0.5.0/lib/tty/box.rb:225:in `frame'
        2: from /home/daniel/.rvm/gems/ruby-2.6.0/gems/tty-box-0.5.0/lib/tty/box.rb:330:in `top_border'
        1: from /home/daniel/.rvm/gems/ruby-2.6.0/gems/tty-box-0.5.0/lib/tty/box.rb:330:in `*'
ArgumentError (negative argument)

More broadly this execption is raised every time a message is shorter than the length of all titles and corners in either top or bottom.
To me TTY::Box.error('BOO!') was the most obvious way to show off TTY toolkits to my colleague, imagine my embarrasment when it failed with an exception, i.e. I was very much motivated to fix the bug :-)
Benefits
Bug will no longer be there.
Drawbacks
Requirements
Put an X between brackets on each line if you have done the item:
[X] Tests written & passing locally?
[X] Code style checked?
[X] Rebased with master branch?
[n/a] Documentaion updated?

@piotrmurach unfortunately a lot of methods needed to be extracted in order to get this bug fixed and keep the code reasonably DRY. It easily comes to attention that a lot of methods keep sharing the same values of border, width, titles etc between each other by passing them as arguments. It is a clear indication that those methods would benefit from being instance methods of a class which in its turn would store border, width, titles etc as instance fields.
Such methods as .frame, .warn, .error could be left class methods (in order to keep API stable) but under the hood they would just create an instance of a class that will do the actual job using its instance methods like #bottom_border, #format or even #fg and #bg.
WDYT, Piotr? I am suggesting it cautiously as I assume you already have a future design of this gem in your head.

Pull Request Test Coverage Report for Build 52

19 of 19 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build 51:
0.0%

Covered Lines:
179

Relevant Lines:
179

💛  - Coveralls

I hope you're ok after the demo and haven't lost faith in tty gems. I also trust your colleague recovered from watching your terminal explode. 😉
Thank you for fixing this! ❤
This is a direct extraction from a terminal game. It served a purpose but I haven't spent much time thinking about the design. Often I actually avoid design until a gem is used in more scenarios and grows in functionality. I only recently added warn, error, info, success based on a feature request from a user. My overall plans are more focused on functionality rather than the internal design. I'm more than happy for you to have a crack at teasing out some objects/reusable code and making things more maintainable. The only thing I'd say the smaller the PRs the easier it is to review and merge.

@piotrmurach got it, I'll do my best to do everything in small chunks


RabbitMQ Deployment Scheme for SyncFlow.

Now that #148 is done, it might be good to move forward with an automated deployment scheme for a Rabbit MQ and add an HTTP authentication backend for it with SyncFlow.
Originally posted by @umesh-timalsina in https://github.com/oele-isis-vanderbilt/SyncFlow/issues/144#issuecomment-2408286236

Before this is done, it might be nice to trim down some of the redundant config variables in the DeploymentConfig.


Cannot create a file if name contains '[' or ']' character (Windows 11)

Prerequisites

[X] Write a descriptive title.
[X] Make sure you are able to repro it on the latest released version
[X] Search the existing issues.
[X] Refer to the FAQ.
[X] Refer to Differences between Windows PowerShell 5.1 and PowerShell.

Steps to reproduce
Cannot create a file if name contains '[' or ']' character.
$Path = "MyFilename[1].txt"
"Text" | Out-File -FilePath $Path

These characters are allowed characters.
https://learn.microsoft.com/en-us/windows/win32/fileio/naming-a-file
It is also possible to create such filenames in Explorer or in CMD shell.
Same issue also exists with legacy powershell 5.1
Expected behavior
'Text' written to file 'MyFilename[1].txt'

Actual behavior
Cannot perform operation because the wildcard path MyFilename[1].txt did not resolve to a file.
[C] Continue [I] Silently Continue [B] Break [S] Suspend [?] Help (default is "Continue"):

Error details
No response
Environment data
Name                           Value
----                           -----
PSVersion                      7.4.0
PSEdition                      Core
GitCommitId                    7.4.0
OS                             Microsoft Windows 10.0.22631
Platform                       Win32NT
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0…}
PSRemotingProtocolVersion      2.3
SerializationVersion           <IP_ADDRESS>
WSManStackVersion              3.0

Visuals
No response

Out-file -LiteralPath $Path

The -Path / -FilePath parameter of provider (file-handling) cmdlets (which the first positional argument implicitly binds to), expects wildcard expressions.
Because PowerShell's wildcard language also supports expressions such as [a-z], paths meant to be literal ones are misinterpreted if they happen to contain [ chars.
To pass a literal path as such, use the -LiteralPath parameter explicitly.

Learned something again ;-)


Fix missing comma in DATABASES dictionary

Fixes following error when running bin/yscb script:
File "./bin/ycsb", line 86
    "hbase098"     : "com.yahoo.ycsb.db.HBaseClient",
                   ^
SyntaxError: invalid syntax

That's a nice catch, thanks. But why not just drop a comment on the still-open PullRequest?
The branch you're PRing to is not intended for use in it's current state. It is very much under active development...

As a sidenote: I will be able to merge this PR only after fixing a current problem with kdbplus-java

RE: https://github.com/TSDBBench/YCSB-TS/pull/9#issuecomment-370157242
Do you mean this PR https://github.com/brianfrankcooper/YCSB/pull/1095? The missing comma was introduced with https://github.com/TSDBBench/YCSB-TS/commit/af83dbd3bf0a539698c5551d790a6990d3956302, so doesn't affect that PR or other branches.
It is a bit of a silly PR, and I was thinking of raising an issue, but thought it would be easier to submit a 1 line patch that could be pulled in 🤷
I checked out this branch as I'm trying to a 50/50 read/insert workload using YCSB-TS on kairosdb but have been getting errors. I was hoping there might have been a fix with all the work you've been doing on this branch :)

Do you mean this PR brianfrankcooper#1095?

I meant https://github.com/brianfrankcooper/YCSB/pull/1068.

I checked out this branch as I'm trying to a 50/50 read/insert workload using YCSB-TS on kairosdb but have been getting errors.

Please do submit an issue for the kairosdb problem you're seeing. I've only been moving stuff over for now. Validating that everything runs as expected is the next step.


Update index.md

I was having a good time until I read this little tiny part, please take in account the 1% of girls that love programming :)

J'avoue, c'est un peu la honte. Je me désolidarise de ces propos. (Ouais parait que c'est bien de faire ça en c'moment).

what is the issue with that? it's just a play on words. if we start to think about who some wording might offend, we wouldn't be able to keep that tone we have and we would start making a difference between people and categories of people. I don't like that.

I've to admit that I never liked that much this one.
+1 for merging the PR or +1 to find another expression. marcassin is fun, maybe we can do better.

Of course! So offensive! So discriminant! :disappointed:


[MWB] Pressing shift repeatedly causes sticky keys activation popup on computer that the keyboard is connected to

Microsoft PowerToys version
0.72.0
Installation method
Microsoft Store
Running as admin
Yes
Area(s) with issue?
Mouse Without Borders
Steps to reproduce
Setup:
Keyboard and mouse connected to computer 1.
Mouse connected to computer 2.
When computer 2 is active, pressing shift five times causes the sticky keys activation to popup on computer 1, not computer 2.
Normally moving the mouse prevents the sticky keys activation to pop up, but moving the mouse connected to computer 2 does not prevent it.
The main problem is when working normally on computer 2, pressing shift several times is not uncommon, and would not be a problem as the sticky keys activation is prevented by mouse movements. Computer 1 is registering the shift presses eventhough the keyboard is supposed to be redirected to computer 2, and it doesn't see the mouse movements, so it shows the sticky keys activation.
✔ Expected Behavior
Sticky keys activation appearing on the active computer.
Sticky keys activation not poping up because the mouse is moving.
❌ Actual Behavior
Stick keys activation pops up on the computer that the keyboard is connected to, not the active computer.
Sticky keys activation pops up eventhough mouse is moving.
Other Software
No response

Are you still experiencing this issue? /needinfo


[sui/move] support dynamic access of child objects

This is a step we have discussed that will significantly improve the expressiveness of Sui Move by allowing the implementation of collections that require pointer-like structures. The basic idea is:

Remove the requirement to supply child objects as explicit transaction inputs
Expose operators for dynamically accessing child objects given a reference to the parent. Children might be accessed by a "key" value (e.g., remove_child_by_key<K: copy + drop, P: key, C: key>(parent: &mut P, key: &K): C), a type (e.g., remove_child_by_type<K, P: key, C: key(parent: &mut P): C), by id (e.g., remove_child_by_id<P: key, C: key>(parent: &mut P, id: ID): C, or all of the above.
The parent/child relationship now looks like a pointer, and design patterns/collection types that require this can be build accordingly

gaining consensus around lamport timestamps
Todd to bring up remaining decision points in next weeks design meeting

How long will it take to complete this feature

If completed, can an object own infinitely many child objects, like Key-Value map?
(What I mean by "Infinitely" is only in theoretical term.)

If completed, can an object own infinitely many child objects, like Key-Value map? (What I mean by "Infinitely" is only in theoretical term.)

Yes! It can have an unbounded number

How long will it take to complete this feature

This is a question for @tnowacki, but I think sometime in October

How long will it take to complete this feature

This is a question for @tnowacki, but I think sometime in October

@tnowacki Can you speed it up

Removing child objects by type would be useful for the following use case:
// package1
struct Foo has key {
  id: UID,
  children: vector<ID>,
}

struct Bar<phantom FT> has key {
  id: UID,
  amount: Balance<FT>,
}

public fun pop_child_any_mint<FT>(parent: &mut Foo): Balance<FT> {
  let Bar { id, amount } = remove_child_by_type<FT>(parent);
  object::delete(id);
  amount
}

// package2

// custom royalty collection in USDC and SUI
public fun custom_royalty_collection(foo: Foo) {
  let ft = package1::pop_child_any_mint<USDC>(&mut foo);
  let s = package1::pop_child_any_mint<SUI>(&mut foo);
  // ...
}

Ie. I know the type I want to get in specific implementation, but want to create a generic interface for doing that for any type.

It would be ideal to also have native APIs to check whether a parent object owns a child object, and other helper methods as well. e.g.contains_child_by_id<P: key>(parent: &P, id: &ID): bool
Are there APIs to show all objects the parents owns? If not then a vector of IDs need to be kept to keep track of which objects the parent owns.

It would be ideal to also have native APIs to check whether a parent object owns a child object, and other helper methods as well. e.g.contains_child_by_id<P: key>(parent: &P, id: &ID): bool Are there APIs to show all objects the parents owns? If not then a vector of IDs need to be kept to keep track of which objects the parent owns.

has_child_object is being included as a method:
https://github.com/MystenLabs/sui/pull/5169/files


Extract a clearer IERC1155Factory interface

Split the concept of a "pool factory" (which encompasses a single method and a single event) away from all of the other opinionated spellings in the IERC1155MixedFungible interface.
The parameters of the TokenPoolCreation event have also been altered, but both the old and new parameters will be parsed by the listener.

#128


Import Portfolio snippets

The portfolio snippet has an ext_object containing a single asset. The filename of the asset ends with ".por".
We extract just the .html files inside the statblocks_html directory of the ZIP file.
The JSZip library can be used to read the contents of the zip file.

First pass done as part of 0.0.15:
All entries in statblocks_html are made inline within the generated HTML.


Please support electron 8

Need support for the new electron release.

To clarify, I'm getting the following error:

An unhandled error occurred inside electron-rebuild
Could not detect abi for version 8.0.0 and runtime electron.  Updating "node-abi" might help solve this issue if it is a new release of electron

However, I'm on the latest node-abi version (2.13.0). So I think the issue is with the node-abi package https://github.com/lgeiger/node-abi/issues/77

node-abi 2.14.0 was just published, so update to that to fix this issue
https://github.com/lgeiger/node-abi/issues/77#issuecomment-582073349

electron-rebuild does not need to be updated to pick up new node-abi minor versions, see #294 (comment) and #294 (comment) (TL;DR: run yarn upgrade electron-rebuild or npm upgrade node-abi --depth=100 to upgrade node-abi for your project.)


fix: add cap on max allowed port in network init

resolves issue https://github.com/Azure/mmlspark/issues/719

/azp run

/azp run


Memory leakage?

The code: https://gist.github.com/superhero/16c81ebdb6a07caaf536
Using PhantomJS 2.0 on Ubuntu 14.04.
After each request I see an ascending memory usage for the service running in a docker container. After 10 000 requests to the server, I'm at 43% of 8GB memory.
I tried using clearMemoryCache right before I close the page, no difference..
Am I missing something simple here? or is it as I suspect, a memory leakage issue?
Possible solution?
I looked at: https://github.com/ariya/phantomjs/issues/10357
...where I noticed this possibility: PrivateBrowsingEnabled -> http://doc.qt.io/qt-4.8/qwebsettings.html#WebAttribute-enum I like to make a request for this future if possible.

Lets track this in https://github.com/ariya/phantomjs/issues/11390


gnu-tests: rollback to ubuntu-20.04 for gnu-tests until fixed

GNU tests are not working properly after ubuntu-latest changed to 22.04. Explicitly specifying Ubuntu version as ubuntu-20.04 for GNUTests CI, until there is a fix for ubuntu-latest.
The issue when using ubuntu-latest:

#4186

oh, amazing
how did you find this?

The same issue started to happen in my fork a week before it happened here. I started investigating, finding the difference here and in my fork, saw that Ubuntu versions were different.

bravo :)


Fix: Fixes scrutinizer

PHPUnit does not support PHP 7 codecoverage

Scrutinizer still aint happy

I think I fixed it now, but there is 1 scrutinizer job blocking the last version (or it needs to timeout after 30min). Could you cancel it? https://scrutinizer-ci.com/g/thephpleague/fractal/inspections (c95a6d).
I also think that after https://github.com/thephpleague/fractal/pull/211 is accepted. The timeout for scrutinizer for receiving code coverage can be lowered. It's now set at 30 min, but I think 10 will be more then enough.
Within the `.scrutinizer.yml'-file:
tools:
    external_code_coverage:
        timeout: 600
        runs: 3

@philsturgeon Yay... it now works :)


wpa_supplicant: wpa_dbus_property_changed errors

Describe the bug
wpa_supplicant produces the following errors:
dbus: wpa_dbus_property_changed: no property RoamTime in object /fi/w1/wpa_supplicant1/Interfaces/0
dbus: wpa_dbus_property_changed: no property RoamComplete in object /fi/w1/wpa_supplicant1/Interfaces/0

Steps To Reproduce
Steps to reproduce the behavior:
IDK how to reliably reproduce this behavior cause it's definitely dependent on the wireless environment.
Expected behavior
There should be no errors logged
Screenshots
If applicable, add screenshots to help explain your problem.
Notify maintainers
cc @globin @rnhmjoj
Metadata
Please run nix-shell -p nix-info --run "nix-info -m" and paste the result.

system: "x86_64-linux"
host os: Linux 5.14.20, NixOS, 21.11 (Porcupine)
multi-user?: yes
sandbox: yes
version: nix-env (Nix) 2.5pre20211007_844dd90
nixpkgs: /nix/store/ixpnxqyishs7xp7sz2dpjx960pszpfwc-source

Maintainer information:
# a list of nixpkgs attributes affected by the problem
attribute:
# a list of nixos modules affected by the problem
module: networking.wpa_supplicant

Is there any problem at all or you're just reporting you noticed these lines in the log?
It seems they're just warnings that have been fixed in a yet unrelease wpa_supplicant version. The reason they didn't do a bugfix release is probably because they're harmless.


How to avoid Message recursion

I'm creating a Configuration panel, and I found myself a little stuck when creating a Restore Default button. See the snippet:
gtk::Box {
    set_orientation: gtk::Orientation::Horizontal,

    #[name = "rest_spin_btn"]
    gtk::SpinButton {
        set_tooltip_text: Some("Rest Duration"),
        set_range: (1.0, 180.0),
     /* #[watch] */
        set_value: (model.config.rest_time.as_secs() / 60) as f64,
        set_increments: (1.0, 5.0),

        connect_value_changed[sender] => move |btn| {
            let value = btn.value() as u64;
            sender.input(AppMsg::ChangeConfig(Box::new(move |mut config|
                config.rest_time = Duration::from_secs(value * 60)
            )))
        },
    },

    #[name = "defaults_btn"]
    gtk::Button {
        set_icon_name: ICON_RESTART,
        set_tooltip_text: Some("Restore default configuration"),
        connect_clicked => AppMsg::ChangeConfig(Box::new(|config|
            *config = Config::default()
        )),
    },
}

This will create the rest_spin_btn : SpinButton to edit some configuration and a defaults_btn : Button that restores the configuration default. This will work, but the panel will not reflect the changes after defaults_btn is pressed. The commented out #[watch] is the normally preferred way to reflect changes in the UI, but if it was un-commented, set_value would be called and the connect_value_changed signal would be emitted, causing a loop.
This seems like a fairly common case, what's the best way to circumvent this?

I think the block_signal attribute should do the job: https://github.com/Relm4/Relm4/blob/main/examples/macro_reference.rs#L133-L138

It works, although, assuming by the example, i needed to create a new "toggle_handler" variable manually for each signal, which makes sense.
There's already documentation for all macro attributes somewhere? I thought i knew all of them, but searching for #[ in the 10.1. Macro expansion shows a lot more, like root, #[transition(SlideLeft)], #[block_signal(toggle_handler)], #[local], #[local_ref], which aren't in the 10. Component macro reference. Also, the #[iterate] is not present in the 10.1. Macro expansion.


Can't delete guest from automated script

In the __delete() function, this line:
read -p "Are you sure you want to delete $name and all associated datasets [Y/N]? " an </dev/tty
We need a way to skip the /dev/tty and read line. (Maybe -F?) This is for our new API, which of course doesn't have an active /dev/tty to read from.

Ditto for the __rmpci() and __remove() functions as well.

Great idea!
I've also found three instances:
https://github.com/pr1ntf/iohyve/blob/master/iohyve#L824
https://github.com/pr1ntf/iohyve/blob/master/iohyve#L892
https://github.com/pr1ntf/iohyve/blob/master/iohyve#L953
Adding a check for another flag will require a rewrite of those functions, but shouldn't take long™.

This has been implemented. Adding -f before the name of the guest will not prompt for deletion.
Nice API by the way!


Implement storage

Implements:

append
compact
and also changes get

Also added a quick change to properly deal with multiple requests for the same document.

I will add list_all, remove the Vec<Vec<u8>>, and add a storage load before the network sync for request, tomorrow, and then I'll put it back to ready to review @alexjg

Ready for review @alexjg
There are many things that can be improved(better definition of error types for example), which I would rather leave to a follow-up as things settle down a bit.


Pull Envoy and Gateway API versions out of code.

Include them dynamically in the docs index, and manually in a barebones compatibility matrix.
Reviewers: It is very much worth discussing whether the approach here of pulling versions out
of the code is the Right Way to Do Things™.
Signed-off-by: Flynn<EMAIL_ADDRESS>

Codecov Report

Merging #400 (0cf8cff) into main (562c5f9) will decrease coverage by 0.38%.
The diff coverage is 25.00%.

@@            Coverage Diff             @@
##             main     #400      +/-   ##
==========================================
- Coverage   61.49%   61.10%   -0.39%
==========================================
  Files          36       37       +1
  Lines        3714     3754      +40
==========================================
+ Hits         2284     2294      +10
- Misses       1308     1338      +30
  Partials      122      122

Impacted Files
Coverage Δ

internal/cmd/versions.go
23.07% <23.07%> (ø)

internal/cmd/root.go
100.00% <100.00%> (ø)

internal/gatewayapi/runner/runner.go
64.70% <0.00%> (-3.53%)
:arrow_down:

internal/xds/translator/runner/runner.go
85.18% <0.00%> (+11.11%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@kflynn when you have a moment, can you fix the merge conflict and resolve the above feedback?

@kflynn consider using https://pages.github.com/ to host the project docs.

@kflynn can you fix the CI failure, create a v0.2.0 issue to track https://github.com/envoyproxy/gateway/pull/400#discussion_r984153656 and then I'm fine merging?

@danehans Fixed the lint failure and created issue #498.


The performance during training is always the same

Dear all,
I am trying to train the model on windows 10 (CPU). The problem that I am finding is that the performance doesn't change at all even if the cost change a little.  If I rerun the training the performance values change but remain again constant.
Thank you in advance,
Best

how long did u train to get 64% accuracy?

Sir,
I have been training the model for more than 24 hours and the performance did not change. It started at 64% and remained there.

I have the same issue. Could you fix it?

@Abduoit around line 265 of train.py is an parameter to train method called batch_size.

Thanks @WaGjUb
Do you mean the first 50 images that we see in the terminal are for testing not for training, does this effect the training process?
I found this line in the train.py
test_xs, test_ys = unzip(list(read_data("test/*.png"))[:50])
I changed it to this
test_xs, test_ys = unzip(list(read_data("test/*.png"))[:batch_size]) and I left the line at the end as same like this
batch_size=50,
But I don't think this is correct, any suggestion please, should I leave it as it is ??

@Abduoit

Do you mean the first 50 images that we see in the terminal are for testing not for training, does this effect the training process?

Yes! I think so because the training try to minimize the loss as you can see around line 175  "train_step = tf.train.AdamOptimizer(learn_rate).minimize(loss)"
It try to minimize the loss and the loss is calculated by the given result of predictions of test

But I don't think this is correct, any suggestion please, should I leave it as it is ??

I don't think you must do it, but will work as well. You just changed your test size as the same of train batch size.


build(deps): update scala3-library from 3.1.0 to 3.1.1

Updates org.scala-lang:scala3-library from 3.1.0 to 3.1.1.
GitHub Release Notes - Version Diff - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.scala-lang", artifactId = "scala3-library" } ]

labels: library-update, early-semver-patch, semver-spec-patch, commit-count:1

Codecov Report

Merging #45 (6811c47) into main (638fe8e) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##              main       #45   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            1         1
  Lines           18        18
  Branches         1         1
=========================================
  Hits            18        18

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 638fe8e...6811c47. Read the comment docs.


Minify index.js

Could the index.js be minified to reduce the filesize ?

It's a bad practice to have minified and/or bundled stuff in repositories and npm packages.
You should use a bundler in the app level that takes care of that for you (e.g.: webpack, rollup, browserify, etc).


WIP: localdev publishing

For discussion...
Amendments to Build.psm1

Add LocalDevInstall switch to Install-PublishedModule
Logic to install the module from ./dist to powershell modules path under version.9999 e.g. <IP_ADDRESS>99
Add function Install-DevelopmentModule that will call this function with the -LocalDevInstall switch

Amendments to .vscode file

Add task to run Install-Dependencies
Add task to run Install-DevelopmentModule
Add task to run Uninstall-DevelopmentModule
Add task to run Invoke-PowerShellGetTest

Amendments to readme.md

Update help to explain above.

Notes:-
Only the module version in the psd1 file in ./dist is updated with the .9999 - this will never be checked in.
Build server will never run with the -LocalDevInstall switch.
The zip artifact published to ./dist is never modified.

Thanks @Benny1007 . I haven't tried this but looks reasonable. Could you look at the Travis CI test failures to see if they may be related to the change?
BTW I typically change $env:psmodulepath to include $pwd\src rather than installing the module while working on it.


feat(cdk/testing): support modifiers for clicking on a TestElement

Adds the ability to provide modifier keys when clicking on a TestElement.

@wwjhu apologies, I missed this PR while I was out on vacation. It looks good, though it does need to be rebased now.

Rebased.

Given the rightClick that landed in https://github.com/angular/components/pull/20400, do you think the modifiers should be added to rightClick as well?

Yeah I think that would make sense, people will expect the method signatures to be the same

Rebased.

Rebased.


Improve handling of refactored concatenated strings

https://github.com/neo4j/neo4j/commit/03ece4f24163204d8a3948eb53576f1feaa86a61#diff-98890cebc6bfa323c73ece0cc5bb33d966544e06a42251033dff545ac12207ccR91-R92
There are two Extract Variable refactorings happening in this case,
one in the source method (message variable) and one in the extracted method (help variable).
We have the following issues:

storeDir variable is not matched in the initializer of extracted variable message
storeLockFile variable in not matched in the initializer of extracted variable message
the initializer of variable help should be matched with part(s) of the string literals in the throw statements.

Replicated at https://github.com/pouryafard75/TestCases/commit/956a94a7736152c85548ab7c6a048f2d9afa8959

@tsantalis
Is this the expected behavior?

You can find the exportedHTML export.zip

@pouryafard75
How did you do that? !!!!!!
It's even better than what I thought it would be possible.

The multi-mapping with ". " on the right is a bit strange

Fixed:

storeDir variable matched in the initializer of extracted variable message
storeLockFile variable matched in the initializer of extracted variable message

@tsantalis
Can you please take a verify the correctness for this exportedHTML.zip?
I have tested and all of the cases are passing.


Support customizing "Report an issue" menu action

Hey !
Is it possible to remove the Built with Nativefier branding ? If so how can I do it ?

Hey @leovarmak. The Help menu provides helpful (!) information about the version used (which may be useful for troubleshooting), as well as a link to the GitHub issue tracker. Both seem very relevant so no, there's not plan to remove them. Note that without menu bar (which is the default) they're not visible, so that's a way to do that. Closing.

I have the same issue as users of my app wanted to "Report an issue" but got to github here instead of a page about my app. The "build with ..." is fine but the "Report issue" might be a problem as people may think it is for the app content itself :-)

"The "build with ..." is fine but the "Report issue" might be a problem as people may think it is for the app content itself :-)"

@gitmh good point, and that's feedback I saw here several times. Re-opening.

Any updates on this?


What will the theme support in the future?

BForms is really succesfull but What will the theme support in the future? The current theme is not enough. I wanted to use Metronic theme (http://www.keenthemes.com/preview/metronic/). But that is not possible like for now.
What do you think about that?
Thanks...

We are not planning to extend the current theme system in the future. You can use other themes on top of BForms but some overriding will be necessary.


Proposal · Provide different set of keys used for meta tags

Proposal --
If returning multiple items from a route, allow to return a model under the key meta.
So for example...
currentRouteModel.meta.articleTitle || currentRouteModel.articleTitle

This seems logical to me 👍

I believe this PR accomplishes this https://github.com/shipshapecode/ember-meta/pull/13
Can we close this @snewcomer?


.optional type enforcing .constrained even when nil

If I define a type like this:
CountryCode = Types::Strict::String.optional.constrained( included_in: CountryCodes.values ).constructor{|v| v.to_s.upcase[0...2] unless v.nil? }

I would expect it to be able to have either nilor any member of CountryCodes.values as value.
It seems that the constraint is always in effect though and triggers when I try to initialise it to nil. What is expected behaviour here? If the above is the expected behaviour; is there any way of getting what I want?

Given that this is in the test suit:
context 'with an optional sum type' do
    subject(:type) do
      Dry::Types['string'].constrained(size: 4).optional
    end

    it 'passes when constraints are not violated' do
      expect(type[nil]).to be(nil)
      expect(type['hell']).to eql('hell')
    end

    ...

  end

it looks like the behaviour from above is a bug.

Ok, I found it ... It's operator precedence :) If I change it to:
CountryCode = Types::Strict::String.constrained( included_in: CountryCodes.values ).optional.constructor{|v| v.to_s.upcase[0...2] unless v.nil? }

It works, notice the moved .optional.
Shouldn't the "optionality" set during type construction be preserved no matter where in the method chain it comes?

I'll try to improve it one way or the other. It'd be perfect if the order didn't matter but it may turn out to be tricky, we'll see what makes sense.


nhwave.F

New changes

Commit #31 nhwave.F. Corrects error in subroutine probe in nhwave.F which caused printing station data twice at each time step if a station was located exactly at a grid point in x or y.


Set up API client code generation

This PR adds the main code generation setup to :tidalapi, as well as the generated files.
Please review commit by commit to have an easy overview, and just skip the commit adding the generated files 😄
Note for reviewers:
The code in this pull request is a MVP. Please point out anything you don't like, but the idea is to get this one merged and then improve what needs improving in subsequent PRs. So if you request changes it should be for things that absolutely can't go in like this.
Please also look at the additional info provided in the commit messages.
Note about the generated code:
I debated whether it should be in the src folder or not, but after some reading I decided yes, because:

We will commit the generated code
Generation will not happen as part of the normal build process
Generated code in the future will be changed and reviewed via PR.

How can you test this?

Check out the branch
Publish to MavenLocal
Add MavenLocal in settings.gradle.kts like this:

dependencyResolutionManagement {
    repositories {
        mavenCentral()
        }
}

Add a dependency to com.tidal.sdk.tidalapi:0.1.0 where you want to use it, and instantiate an api client like this:

 val client: TidalApiClient = TidalApiClient(credentialsProvider)

Play around with it.

Do you need to test it to review this?
At this stage, no imho. But if you like to, feel free!
How to/ test code generation?
As you currently need a binary of my fork of openapi-generator, ask me personally, if you want to play around with it.
But after this PR, we wil quickly move towards making this available via GH Actions, which will simplify this all.

I don't see why we would want to commit the generated code. It sounds more reasonable to me to generate it on CI on publish, put it in the published binary and that's it.

I don't see why we would want to commit the generated code. It sounds more reasonable to me to generate it on CI on publish, put it in the published binary and that's it.

There are a number of reasons for it, here are some:

We want engineers to easily review the changes in generated code before merging
We want to keep open the ability to manually change details before merging, if needed
API code generation (especially on Android, where we needed to alter the generator) is still quite brittle, and the schemas are still in a phase where they might change quite significantly. This approach makes it easier to step in and apply quick fixes

I know that you added a similar comment on my earlier PR, and I would have liked to do it that way too. But this approach made the most sense to thew devs involved (not just for Android) and so we decided to go with this way.
However, once we are past an MVP situation and both schema design and client use have stabilized it might be nice to revisit the approach and maybe reconsider/improve, but currently this is the way to go.


Add typescript deps as dev deps

Hey @ianschmitz, @iansu, @mrmckeb, this might be useful to take a look.


which element would sit on top of which?

Please refer to this issue https://github.com/fabric8io/fabric8-planner/issues/810.

@vikram-raj These were asked in https://github.com/fabric8io/fabric8-planner/pull/812, but I wanted to post the questions here as well. Feel free to answer them in the Fabric8-Planner area.
Questions:

why does the panel have a z-index of 100? Why so high? Also, I was unable to find a z-index for any other element - modal, navigation, or anything else.
Do other elements already have z-indexes?
Is Bootstrap / PatternFly being used to control the layering, as it should? Those frameworks cover layering for modals, slideouts, and other aspects. Custom code should not be there for that. @michaelkleinhenz, @michaelvirgil - how much of Bootstrap/PatternFly is being used at this point?

We will most likely not be able to give you a z-index for every single element - that is what the embedded frameworks are for. The CSS for each framework will properly handle the button layering, modal layering, etc.


Fix VF handling after virtlet restart while VMs are running

This change is

Review status: 0 of 2 LGTMs obtained

pkg/nettools/nettools.go, line 388 at r1 (raw file):

		// nil to slice
		// TODO: differentiate missing link from other possible errors
		link, _ := netlink.LinkByName(iface.Name)

I'd check for err anyway. Is it documented that LinkByName always returns nil in case of error and not some dummy link? Is it guaranteed to be so in future netlink library versions? I understand that this is unlikely, but still, it's better to be explicit here & follow the documented interface.

pkg/nettools/nettools.go, line 704 at r1 (raw file):

	for i, link := range contLinks {
		if link == nil {
			return nil, fmt.Errorf("have missing %d interface in list of container links what should be possible only during recovery after virtlet pod restart", i)

"missing link #%d in the container network namespace (Virtlet pod restarted?)"

pkg/tapmanager/tapfdsource.go, line 68 at r1 (raw file):

// GetFDPayload contains the data that are required by TapFDSource
// to create the tap device

a tap device

pkg/tapmanager/tapfdsource.go, line 71 at r1 (raw file):

type GetFDPayload struct {
	// Description specifies pod network description for already
	// prepared network configuration

Description contains the pod information necessary to set up the tap device

pkg/tapmanager/tapfdsource.go, line 76 at r1 (raw file):

// RecoverPayload contains the data that are required by TapFDSource
// to recover the tap device that was already configured

a tap device

pkg/tapmanager/tapfdsource.go, line 79 at r1 (raw file):

type RecoverPayload struct {
	// Description specifies pod network description for already
	// prepared network configuration

Description contains the pod information necessary to recover the tap device

pkg/tapmanager/tapfdsource.go, line 86 at r1 (raw file):

	// HaveRunningContainers contains the information about running
	// containers (domains). If there is one - VF reconfiguration
	// has to be skipped.

HaveRunningContainers is true if any domains are currently running for this pod. VF reconfiguration is to be skipped if that's the case.

Comments from Reviewable

Review status: 0 of 2 LGTMs obtained

pkg/nettools/nettools.go, line 704 at r1 (raw file):
Previously, ivan4th (Ivan Shvedunov) wrote…
"missing link #%d in the container network namespace (Virtlet pod restarted?)"

Done.

pkg/tapmanager/tapfdsource.go, line 71 at r1 (raw file):
Previously, ivan4th (Ivan Shvedunov) wrote…
Description contains the pod information necessary to set up the tap device

It's not used only for setting up tap device. Btw. why there should be inconsistent use of "a tap device", and "the tap device" (above comment)?

pkg/tapmanager/tapfdsource.go, line 79 at r1 (raw file):
Previously, ivan4th (Ivan Shvedunov) wrote…
Description contains the pod information necessary to recover the tap device

As above.

pkg/tapmanager/tapfdsource.go, line 86 at r1 (raw file):
Previously, ivan4th (Ivan Shvedunov) wrote…
HaveRunningContainers is true if any domains are currently running for this pod. VF reconfiguration is to be skipped if that's the case.

Done.

Comments from Reviewable

Review status: 0 of 2 LGTMs obtained

pkg/tapmanager/tapfdsource.go, line 71 at r1 (raw file):
Previously, jellonek (Piotr Skamruk) wrote…
It's not used only for setting up tap device. Btw. why there should be inconsistent use of "a tap device", and "the tap device" (above comment)?

The above comment is about GetFDPayload being applicable to any tap device used by Virtlet, and the Description field concerns the concrete tap device this GetFDPayload instance is about. Can we change comment to "Description contains the pod information and DNS settings for the pod" maybe?

pkg/tapmanager/tapfdsource.go, line 79 at r1 (raw file):
Previously, jellonek (Piotr Skamruk) wrote…
As above.

As above, too.

Comments from Reviewable

Review status: 0 of 2 LGTMs obtained

pkg/nettools/nettools.go, line 388 at r1 (raw file):
Previously, ivan4th (Ivan Shvedunov) wrote…
I'd check for err anyway. Is it documented that LinkByName always returns nil in case of error and not some dummy link? Is it guaranteed to be so in future netlink library versions? I understand that this is unlikely, but still, it's better to be explicit here & follow the documented interface.

Documentation for that is ... I've read that part of netlink library quite a lot (and extended it already) and I'm sure that there would be a nil value in case of any error, but better would be to verify there error type, if it's netlink.LinkNotFoundError instance.
Also i've unexported this func as it's used only in this file.

pkg/tapmanager/tapfdsource.go, line 68 at r1 (raw file):
Previously, ivan4th (Ivan Shvedunov) wrote…
a tap device

I used there a more precise wording.

pkg/tapmanager/tapfdsource.go, line 71 at r1 (raw file):
Previously, ivan4th (Ivan Shvedunov) wrote…
The above comment is about GetFDPayload being applicable to any tap device used by Virtlet, and the Description field concerns the concrete tap device this GetFDPayload instance is about. Can we change comment to "Description contains the pod information and DNS settings for the pod" maybe?

Done.

pkg/tapmanager/tapfdsource.go, line 76 at r1 (raw file):
Previously, ivan4th (Ivan Shvedunov) wrote…
a tap device

Used more precise wording (it's not only a tap device).

pkg/tapmanager/tapfdsource.go, line 79 at r1 (raw file):
Previously, ivan4th (Ivan Shvedunov) wrote…
As above, too.

Done.

Comments from Reviewable

Review status: 0 of 2 LGTMs obtained, and 1 stale

Comments from Reviewable

Review status: 1 of 2 LGTMs obtained, and 1 stale

Comments from Reviewable

So what should i do to solve:
missing link #0 in the container network namespace (Virtlet pod restarted?)


Update loadgen.sh

change HELLOWORLD_URL to GATEWAY_URL to match README

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: janitha09
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: kyessenov
If they are not already assigned, you can assign the PR to them by writing /assign @kyessenov in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

samples/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Hi @janitha09. Thanks for your PR.
I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: howardjohn, janitha09
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

samples/OWNERS [howardjohn]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@janitha09: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-simpleTests.sh
027b7f7e3656b41c4d40a81c01331c7a4cf71185
link
/test e2e-simpleTests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/ok-to-test

@janitha09: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-simpleTests.sh
027b7f7e3656b41c4d40a81c01331c7a4cf71185
link
/test e2e-simpleTests-master

prow/istio-pilot-multicluster-e2e.sh
027b7f7e3656b41c4d40a81c01331c7a4cf71185
link
/test istio-pilot-multicluster-e2e-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@janitha09: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-simpleTests.sh
027b7f7e3656b41c4d40a81c01331c7a4cf71185
link
/test e2e-simpleTests-master

prow/istio-pilot-multicluster-e2e.sh
027b7f7e3656b41c4d40a81c01331c7a4cf71185
link
/test istio-pilot-multicluster-e2e-master

prow/integ-mixer-k8s-presubmit-tests.sh
027b7f7e3656b41c4d40a81c01331c7a4cf71185
link
/test integ-mixer-k8s-presubmit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@janitha09: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-simpleTests.sh
027b7f7e3656b41c4d40a81c01331c7a4cf71185
link
/test e2e-simpleTests-master

prow/istio-pilot-multicluster-e2e.sh
027b7f7e3656b41c4d40a81c01331c7a4cf71185
link
/test istio-pilot-multicluster-e2e-master

prow/integ-mixer-k8s-presubmit-tests.sh
027b7f7e3656b41c4d40a81c01331c7a4cf71185
link
/test integ-mixer-k8s-presubmit-tests-master

prow/integ-mixer-k8s-k8s-presubmit-tests.sh
027b7f7e3656b41c4d40a81c01331c7a4cf71185
link
/test integ-mixer-k8s-k8s-presubmit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@janitha09: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-simpleTests.sh
027b7f7e3656b41c4d40a81c01331c7a4cf71185
link
/test e2e-simpleTests-master

prow/istio-pilot-multicluster-e2e.sh
027b7f7e3656b41c4d40a81c01331c7a4cf71185
link
/test istio-pilot-multicluster-e2e-master

prow/integ-mixer-k8s-presubmit-tests.sh
027b7f7e3656b41c4d40a81c01331c7a4cf71185
link
/test integ-mixer-k8s-presubmit-tests-master

prow/integ-mixer-k8s-k8s-presubmit-tests.sh
027b7f7e3656b41c4d40a81c01331c7a4cf71185
link
/test integ-mixer-k8s-k8s-presubmit-tests-master

prow/integ-galley-local-presubmit-tests.sh
027b7f7e3656b41c4d40a81c01331c7a4cf71185
link
/test integ-galley-local-presubmit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@janitha09: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-multicluster-e2e.sh
027b7f7e3656b41c4d40a81c01331c7a4cf71185
link
/test istio-pilot-multicluster-e2e-master

prow/integ-mixer-k8s-presubmit-tests.sh
027b7f7e3656b41c4d40a81c01331c7a4cf71185
link
/test integ-mixer-k8s-presubmit-tests-master

prow/integ-mixer-k8s-k8s-presubmit-tests.sh
027b7f7e3656b41c4d40a81c01331c7a4cf71185
link
/test integ-mixer-k8s-k8s-presubmit-tests-master

prow/integ-galley-local-presubmit-tests.sh
027b7f7e3656b41c4d40a81c01331c7a4cf71185
link
/test integ-galley-local-presubmit-tests-master

prow/integ-telemetry-k8s-presubmit-tests.sh
027b7f7e3656b41c4d40a81c01331c7a4cf71185
link
/test integ-telemetry-k8s-presubmit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test integ-galley-local-presubmit-tests-master

@janitha09: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-multicluster-e2e.sh
027b7f7e3656b41c4d40a81c01331c7a4cf71185
link
/test istio-pilot-multicluster-e2e-master

prow/integ-mixer-k8s-presubmit-tests.sh
027b7f7e3656b41c4d40a81c01331c7a4cf71185
link
/test integ-mixer-k8s-presubmit-tests-master

prow/integ-mixer-k8s-k8s-presubmit-tests.sh
027b7f7e3656b41c4d40a81c01331c7a4cf71185
link
/test integ-mixer-k8s-k8s-presubmit-tests-master

prow/integ-telemetry-k8s-presubmit-tests.sh
027b7f7e3656b41c4d40a81c01331c7a4cf71185
link
/test integ-telemetry-k8s-presubmit-tests-master

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
027b7f7e3656b41c4d40a81c01331c7a4cf71185
link
/test istio-pilot-e2e-envoyv2-v1alpha3-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test istio-pilot-e2e-envoyv2-v1alpha3-master


Helm search repo with the created date and time

Hi ,
We have a requirement to fetch the latest created chart from our helm repository hence is it possible to get the chart details along with the created date and time?
Current Behaviour
Example:
helm search repo  --versions
NAME              	CHART VERSION	APP VERSION	DESCRIPTION
r	230306       	230306     	A Helm chart for Kubernetes
	        1689         	1.16.0     	A Helm chart for Kubernetes
	        1.6.89       	1.16.0     	A Helm chart for Kubernetes
 	        1.3.6        	         1.3.6      	A Helm chart for Kubernetes
Please also suggest to me if we have an alternative way to suffice our requirement

Are you sure you want the "latest" version as defined by timestamp? Generally, latest might be determined by semver comparison. For example, publishing a prerelease version or patch version for a prior release version would publish with the newer timestamp. But neither of these would necessary be considered to be the "latest" version.
To answer your question directly, I also don't see the publishing timestamp on helm search repo -o json. I think it would be necessary to first check if the repository search returns a timestamp. If the repository doesn't return the publishing timestamp, it won't be possible to output it of course.

The changes were approved by a community member, not a maintainer. Thought I'm also not a maintainer, I added a comment as to why the PR cannot be merged in its current form.


Type 'string' is not assignable to type 'Exclude<T, number>' when narrowing using generic

Bug Report
🔎 Search Terms

remove a type from generic union as return type
remove a type from generic union
remove a certain type from generic

🕗 Version & Regression Information

This is the behavior in every version I tried, and I reviewed the FAQ for entries about <Can't find anything related>

⏯ Playground Link
https://www.typescriptlang.org/play?ts=5.1.0-dev.20230507#code/GYVwdgxgLglg9mABGEBbARgUwE4BU4DKU2MYA5gDy4B8AFAG4CGANiJgFyK4CUnAogA8IrACaYqAGmRos2aogDeAWABQidYmyYoIbEigBPAA6Y4wRE1aZEAXjuIA5Cgw4HiAPyIABgBIFltgBfL0ROAMwAblVA1VUAejjEEABnRjJMVVBIWAREZMxmTGhcTAEoWihSqE5k4lIyRAAfRAAlTDJBI25FVQ1EBMQoOBE4aNiVLOh4JEYwOCgACxwAMTBaRmwyTmdZJry68j22joEunrUNAcWYZMQbxEZoEBZmA0QAdzhsAGt6qXQQFA8nBUJgFnB3ogADKkawAJjut1qMGYzE0jBu9UGS0QOGwX16Gi0Oj0eQKRSgJTKtB2OHwRBI5HWm243CiKkCQA
💻 Code
function numberToString<T>(value: T): Exclude<T, number> {
    return typeof value === 'number' ? `${value}` : value;
//  ^^^^^^ Error
}

// usage
function selectText(text: string | RegExp) {
    // todo
}

function anotherFn(arg: number | string | RegExp) {
    // this is actually working, but somehow Line 2 is still raising the error
    return selectText(numberToString(arg));
}

🙁 Actual behavior
Type 'string | T' is not assignable to type 'Exclude<T, number>'.
  Type 'string' is not assignable to type 'Exclude<T, number>'

🙂 Expected behavior
There should be no issue, since T is extending any by default, hence string should absolutely be included in Exclude<T, number>, where it should be any type but without number

This would probably be a duplicate of #33912 it the return type were changed to T extends number ? string : T to correspond to what the function is actually doing.
Currently if you call numberToString(10), then T is inferred as 10 and the return type Exclude<10, number> which is never.  But the function implementation returns a string, which (like all values) is not assignable to never.  So the compiler error is a good one.

@jcalz Thanks for the response. This seems reasonable to me, however I've given it a try but unfortunately it's not working.
https://www.typescriptlang.org/play?ts=5.1.0-dev.20230507#code/GYVwdgxgLglg9mABGEBbARgUwE4BU4DKU2MYA5gDy4B8AFAG4CGANiJgFyK4CUnAogA8IrACaYqAGmRos2aogDeAWABQidYmyYoIbEigBPAA6Y4wRE1aZEAXjuIA5Cgw4HiAPyIABgBIFltgBfL0ROAMwAblVA1VUAejjEEABnRjJMVVBIWAREZMxmTGhcTAEoWihSqE5k4lIyRAAfRAAlTDJBI25FVQ1EBMQoOBE4aNiVLOh4JEYwOCgACxwAMTBaRmwyTmdZJry68j22joEunrUNAcWYZMQbxEZoEBZmA0QAdzhsAGt6qXQQFA8nBUJgFnB3ogADKkawAJjut1qMGYzE0jBu9UGS0QOGwX16Gi0Oj0eQKRSgJTKtB2OHwRBI5HWm243CiKhiKnGkxySFpeEIBzIcKodHCnB4EtxZUwYBEt35Hm8flwwVCXHOfWJun0xlM5nCtnsThkriVvn8LCCITCVsiYy5E3AU1y-PpQoAzKKGHaJbwNVVZfLpC5sEraoyGlLlBd1NrSYYTGYLHajTZHPy3J4LeE1barOzOUA

but unfortunately it's not working.

It's not working because #33912 is not implemented.

where it should be any type but without number

TypeScripts type system can't represent such types. Exclude<> is only used to remove types from a union type. This would require #4196.


Apostrophes in Neighborhood Names

Apostrophes in neighborhood names appear as HTML code

Addressed in PR #375

Duplicate, addressed in PR #375


Issue #SB-16961:fix Profile Edit: Proper telemetry is not getting gen…

…erated for location update on profile page

@ArjunKhetia-NIIT Still code can be better. @deveshMantra @rajeevsathish Take this example & think to write generic, instead of code specific only that workflow/logic.


created select options for city and class in progress

What changes have you made?

Started work on city and class dropdown

@petemcfarlane since we will be having more if statements to include other cities would a loop work better?


Flake in json_serialization_test

Potential flake that I've seen once in CI as well as (I think) once on my mac locally:
Comparing against revision 'origin/master'.
Found 3 test files associated with changes.
============================= test session starts ==============================
platform linux -- Python 3.7.10, pytest-6.2.4, py-1.10.0, pluggy-0.13.1
rootdir: /home/runner/work/Cirq/Cirq
plugins: asyncio-0.15.1, cov-2.12.0, forked-1.3.0, xdist-2.2.1
collected 55 items / 1 error / 54 selected

==================================== ERRORS ====================================
_____ ERROR collecting cirq-core/cirq/protocols/json_serialization_test.py _____
cirq-core/cirq/protocols/json_serialization_test.py:429: in <module>
    _list_public_classes_for_tested_modules(),
cirq-core/cirq/protocols/json_serialization_test.py:422: in _list_public_classes_for_tested_modules
    for mod_spec in MODULE_TEST_SPECS
/opt/hostedtoolcache/Python/3.7.10/x64/lib/python3.7/contextlib.py:119: in __exit__
    next(self.gen)
cirq-core/cirq/testing/deprecation.py:66: in assert_deprecated
    yield True
cirq-core/cirq/testing/logs.py:98: in __exit__
    f'Expected {count} log message but ' f'got {len(records)}. Log messages: ' f'{msgs}'
E   AssertionError: Expected 1 log message but got 0. Log messages: []
=========================== short test summary info ============================
ERROR cirq-core/cirq/protocols/json_serialization_test.py - AssertionError: E...
!!!!!!!!!!!!!!!!!!!! Interrupted: 1 error during collection !!!!!!!!!!!!!!!!!!!!
=============================== 1 error in 0.48s ===============================

It wasn't a flake.
Adding some info in case someone runs into something similar.
What was happening is that the cirq-google dependencies were missing on the CI job due to my refactors.
This triggered the conditional import of cirq_google package to fail.
The json_serialization_test.py file checks for cirq_google being present on the PYTHONPATH - and then it assumes that it is included - and asserts the deprecationwarning to be emitted. But, because of the missing dependencies, import google in the protobuf files fail, leading to an import error in cirq/__init__.py which caught by a way too wide Exception handling mechanism (https://github.com/quantumlib/Cirq/issues/4106 should fix this and result in a better error message)...resulting in an inconsistent state: cirq_google is on the path but cirq.google does not exist.
--- Logging error ---
Traceback (most recent call last):
  File "/usr/local/google/home/balintp/dev/proj/Cirq/cirq-core/cirq/__init__.py", line 581, in <module>
    _compat.deprecated_submodule(
  File "/usr/local/google/home/balintp/dev/proj/Cirq/cirq-core/cirq/_compat.py", line 546, in deprecated_submodule
    new_module = importlib.import_module(new_module_name)
  File "/usr/local/lib/python3.8/importlib/__init__.py", line 127, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
  File "<frozen importlib._bootstrap>", line 1014, in _gcd_import
  File "<frozen importlib._bootstrap>", line 991, in _find_and_load
  File "<frozen importlib._bootstrap>", line 975, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 671, in _load_unlocked
  File "<frozen importlib._bootstrap_external>", line 783, in exec_module
  File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
  File "/usr/local/google/home/balintp/dev/proj/Cirq/cirq-google/cirq_google/__init__.py", line 17, in <module>
    from cirq_google import api
  File "/usr/local/google/home/balintp/dev/proj/Cirq/cirq-google/cirq_google/api/__init__.py", line 16, in <module>
    from cirq_google.api import v2
  File "/usr/local/google/home/balintp/dev/proj/Cirq/cirq-google/cirq_google/api/v2/__init__.py", line 16, in <module>
    from cirq_google.api.v2 import (
  File "/usr/local/google/home/balintp/dev/proj/Cirq/cirq-google/cirq_google/api/v2/batch_pb2.py", line 7, in <module>
    from google.protobuf import descriptor as _descriptor
ModuleNotFoundError: No module named 'google'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/usr/local/lib/python3.8/logging/__init__.py", line 1085, in emit
    msg = self.format(record)
  File "/usr/local/lib/python3.8/logging/__init__.py", line 929, in format
    return fmt.format(record)
  File "/usr/local/lib/python3.8/logging/__init__.py", line 668, in format
    record.message = record.getMessage()
  File "/usr/local/lib/python3.8/logging/__init__.py", line 373, in getMessage
    msg = msg % self.args
TypeError: not all arguments converted during string formatting
Call stack:
  File "/usr/local/google/home/balintp/.virtualenvs/tmp-e19c4b6b0f10298/bin/pytest", line 8, in <module>
    sys.exit(console_main())
  File "/usr/local/google/home/balintp/.virtualenvs/tmp-e19c4b6b0f10298/lib/python3.8/site-packages/_pytest/config/__init__.py", line 185, in console_main
    code = main()
  File "/usr/local/google/home/balintp/.virtualenvs/tmp-e19c4b6b0f10298/lib/python3.8/site-packages/_pytest/config/__init__.py", line 143, in main
    config = _prepareconfig(args, plugins)
  File "/usr/local/google/home/balintp/.virtualenvs/tmp-e19c4b6b0f10298/lib/python3.8/site-packages/_pytest/config/__init__.py", line 318, in _prepareconfig
    config = pluginmanager.hook.pytest_cmdline_parse(
  File "/usr/local/google/home/balintp/.virtualenvs/tmp-e19c4b6b0f10298/lib/python3.8/site-packages/pluggy/hooks.py", line 286, in __call__
    return self._hookexec(self, self.get_hookimpls(), kwargs)
  File "/usr/local/google/home/balintp/.virtualenvs/tmp-e19c4b6b0f10298/lib/python3.8/site-packages/pluggy/manager.py", line 93, in _hookexec
    return self._inner_hookexec(hook, methods, kwargs)
  File "/usr/local/google/home/balintp/.virtualenvs/tmp-e19c4b6b0f10298/lib/python3.8/site-packages/pluggy/manager.py", line 84, in <lambda>
    self._inner_hookexec = lambda hook, methods, kwargs: hook.multicall(
  File "/usr/local/google/home/balintp/.virtualenvs/tmp-e19c4b6b0f10298/lib/python3.8/site-packages/pluggy/callers.py", line 187, in _multicall
    res = hook_impl.function(*args)
  File "/usr/local/google/home/balintp/.virtualenvs/tmp-e19c4b6b0f10298/lib/python3.8/site-packages/_pytest/config/__init__.py", line 1003, in pytest_cmdline_parse
    self.parse(args)
  File "/usr/local/google/home/balintp/.virtualenvs/tmp-e19c4b6b0f10298/lib/python3.8/site-packages/_pytest/config/__init__.py", line 1283, in parse
    self._preparse(args, addopts=addopts)
  File "/usr/local/google/home/balintp/.virtualenvs/tmp-e19c4b6b0f10298/lib/python3.8/site-packages/_pytest/config/__init__.py", line 1191, in _preparse
    self.hook.pytest_load_initial_conftests(
  File "/usr/local/google/home/balintp/.virtualenvs/tmp-e19c4b6b0f10298/lib/python3.8/site-packages/pluggy/hooks.py", line 286, in __call__
    return self._hookexec(self, self.get_hookimpls(), kwargs)
  File "/usr/local/google/home/balintp/.virtualenvs/tmp-e19c4b6b0f10298/lib/python3.8/site-packages/pluggy/manager.py", line 93, in _hookexec
    return self._inner_hookexec(hook, methods, kwargs)
  File "/usr/local/google/home/balintp/.virtualenvs/tmp-e19c4b6b0f10298/lib/python3.8/site-packages/pluggy/manager.py", line 84, in <lambda>
    self._inner_hookexec = lambda hook, methods, kwargs: hook.multicall(
  File "/usr/local/google/home/balintp/.virtualenvs/tmp-e19c4b6b0f10298/lib/python3.8/site-packages/pluggy/callers.py", line 187, in _multicall
    res = hook_impl.function(*args)
  File "/usr/local/google/home/balintp/.virtualenvs/tmp-e19c4b6b0f10298/lib/python3.8/site-packages/_pytest/config/__init__.py", line 1070, in pytest_load_initial_conftests
    self.pluginmanager._set_initial_conftests(early_config.known_args_namespace)
  File "/usr/local/google/home/balintp/.virtualenvs/tmp-e19c4b6b0f10298/lib/python3.8/site-packages/_pytest/config/__init__.py", line 500, in _set_initial_conftests
    self._try_load_conftest(anchor, namespace.importmode)
  File "/usr/local/google/home/balintp/.virtualenvs/tmp-e19c4b6b0f10298/lib/python3.8/site-packages/_pytest/config/__init__.py", line 508, in _try_load_conftest
    self._getconftestmodules(anchor, importmode)
  File "/usr/local/google/home/balintp/.virtualenvs/tmp-e19c4b6b0f10298/lib/python3.8/site-packages/_pytest/config/__init__.py", line 536, in _getconftestmodules
    mod = self._importconftest(conftestpath, importmode)
  File "/usr/local/google/home/balintp/.virtualenvs/tmp-e19c4b6b0f10298/lib/python3.8/site-packages/_pytest/config/__init__.py", line 570, in _importconftest
    mod = import_path(conftestpath, mode=importmode)
  File "/usr/local/google/home/balintp/.virtualenvs/tmp-e19c4b6b0f10298/lib/python3.8/site-packages/_pytest/pathlib.py", line 524, in import_path
    importlib.import_module(module_name)
  File "/usr/local/lib/python3.8/importlib/__init__.py", line 127, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
  File "<frozen importlib._bootstrap>", line 1014, in _gcd_import
  File "<frozen importlib._bootstrap>", line 991, in _find_and_load
  File "<frozen importlib._bootstrap>", line 961, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
  File "<frozen importlib._bootstrap>", line 1014, in _gcd_import
  File "<frozen importlib._bootstrap>", line 991, in _find_and_load
  File "<frozen importlib._bootstrap>", line 975, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 671, in _load_unlocked
  File "<frozen importlib._bootstrap_external>", line 783, in exec_module
  File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
  File "/usr/local/google/home/balintp/dev/proj/Cirq/cirq-core/cirq/__init__.py", line 590, in <module>
    warning("Can't import cirq.google: ", ex)
Message: "Can't import cirq.google: "
Arguments: (ModuleNotFoundError("No module named 'google'"),)
_________________________________________________________________________________________________________________________ ERROR collecting cirq-core/cirq/protocols/json_serialization_test.py _________________________________________________________________________________________________________________________
cirq-core/cirq/protocols/json_serialization_test.py:429: in <module>
    ???
cirq-core/cirq/protocols/json_serialization_test.py:420: in _list_public_classes_for_tested_modules
    return [
/usr/local/lib/python3.8/contextlib.py:120: in __exit__
    next(self.gen)
cirq-core/cirq/testing/deprecation.py:66: in assert_deprecated
    yield True
cirq-core/cirq/testing/logs.py:97: in __exit__
    assert count is None or len(records) == count, (
E   AssertionError: Expected 1 log message but got 0. Log messages: []
--------------------------------------------------------------------------------------------------------------------------------------------------- Captured stdout ----------------------------------------------------------------------------------------------------------------------------------------------------
cirq_google on path : True
=============================================================================================================================================== short test summary info ================================================================================================================================================
ERROR cirq-core/cirq/protocols/json_serialization_test.py - AssertionError: Expected 1 log message but got 0. Log messages: []


Element select not working

i can't see select on page components. Please update element select. Thanks for sharing

Checked everything still not working

There doesn't seem to be any known issues with a simple select not working right now. Please create a new issue with a codepen (http://codepen.io/Dogfalo/pen/xbzPQV) example. Make sure you have initialised the javascript code indicated in http://materializecss.com/forms.html#select .

Select works with these files:
<script src="//code.jquery.com/jquery-2.1.2.min.js"></script>
<script src="//cdnjs.cloudflare.com/ajax/libs/materialize/0.97.4/js/materialize.min.js"></script>
The select didn't work for me with these files:
<script src="https://cdnjs.cloudflare.com/ajax/libs/jquery/3.0.0-alpha1/jquery.min.js"></script>
<script src="https://cdnjs.cloudflare.com/ajax/libs/materialize/0.97.5/js/materialize.min.js"></script>
So, I copy-pasted my whole page to codepen and everything magically worked.
I found out that codepen used different versions of the JS-files that what I had included.
You can see it from the Pen Settings:

adsadasdasd

Yes, so don't use jQuery 3.0.0 and 2.2.0.

with jquery 2.1.4 and this:
$(document).ready(function() {
$('select').material_select();
});
select work fine

@RealTekOne Thanks, it tooks me a long time to figure out why it was not working...


Fixed nullptr assignment, allow a reference to free function

Hi Erik,
There is a small fix for nullptr assignment. And I also added std::decay<F> to deal with references to free functions in the template Function constructor.

Ah, this is what I was talking about before regarding free functions and unbound member functions.  :+1:


First step to manage timeout in Maven goals based on the output #351

Pull Request Test Coverage Report for Build 1430

72 of 91 (79.12%) changed or added relevant lines in 13 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.3%) to 52.85%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

repairnator/repairnator-pipeline/src/main/java/fr/inria/spirals/repairnator/process/maven/MavenHelper.java
29
31
93.55%

repairnator/repairnator-pipeline/src/main/java/fr/inria/spirals/repairnator/process/step/TestProject.java
4
6
66.67%

repairnator/repairnator-pipeline/src/main/java/fr/inria/spirals/repairnator/process/step/ResolveDependency.java
3
5
60.0%

repairnator/repairnator-pipeline/src/main/java/fr/inria/spirals/repairnator/process/step/NPERepair.java
3
5
60.0%

repairnator/repairnator-pipeline/src/main/java/fr/inria/spirals/repairnator/process/step/ComputeClasspath.java
3
5
60.0%

repairnator/repairnator-pipeline/src/main/java/fr/inria/spirals/repairnator/process/step/BuildProject.java
2
5
40.0%

repairnator/repairnator-pipeline/src/main/java/fr/inria/spirals/repairnator/process/maven/RunnableMavenInvoker.java
18
24
75.0%

Totals

Change from base Build 1422:
0.3%

Covered Lines:
2040

Relevant Lines:
3860

💛  - Coveralls


Fix getDefaultBucket timeout

Codecov Report

Merging #493 into master will not change coverage.
The diff coverage is 100%.

@@            Coverage Diff            @@
##             master     #493   +/-   ##
=========================================
  Coverage     78.59%   78.59%
  Complexity      668      668
=========================================
  Files            73       73
  Lines          1901     1901
  Branches        283      283
=========================================
  Hits           1494     1494
  Misses          229      229
  Partials        178      178


[KYUUBI #3206] Change Flink default version to 1.15

Why are the changes needed?

How was this patch tested?

[ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible

[ ] Add screenshots for manual tests if appropriate

[ ] Run test locally before make a pull request

Please update the corresponding GitHub workflow, we should verify the default Flink version with which build should work on all supported versions of Flink distributions.

Codecov Report

Merging #3207 (09c854e) into master (6aa898e) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #3207      +/-   ##
============================================
- Coverage     51.54%   51.53%   -0.01%
  Complexity        6        6
============================================
  Files           459      459
  Lines         25556    25556
  Branches       3545     3545
============================================
- Hits          13172    13170       -2
+ Misses        11124    11121       -3
- Partials       1260     1265       +5

Impacted Files
Coverage Δ

...rg/apache/kyuubi/ctl/cmd/log/LogBatchCommand.scala
78.00% <0.00%> (-2.00%)
:arrow_down:

...che/kyuubi/server/KyuubiTHttpFrontendService.scala
64.23% <0.00%> (-0.73%)
:arrow_down:

...yuubi/server/metadata/jdbc/JDBCMetadataStore.scala
89.27% <0.00%> (-0.70%)
:arrow_down:

...a/org/apache/kyuubi/service/TFrontendService.scala
91.17% <0.00%> (-0.30%)
:arrow_down:

...g/apache/kyuubi/operation/BatchJobSubmission.scala
74.40% <0.00%> (ø)

...pache/kyuubi/engine/YarnApplicationOperation.scala
64.81% <0.00%> (ø)

...in/scala/org/apache/kyuubi/config/KyuubiConf.scala
97.32% <0.00%> (+0.08%)
:arrow_up:

...ain/scala/org/apache/kyuubi/engine/EngineRef.scala
76.19% <0.00%> (+0.95%)
:arrow_up:

...apache/kyuubi/engine/JpsApplicationOperation.scala
80.64% <0.00%> (+3.22%)
:arrow_up:

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

Thanks, merging to master


Rename this repository

@ljharb correctly points out the name of this shouldn't be the solution but the problem.  Only I don't know a short description for this:  "Await dictionary of promises"?

That seems reasonable - Promise.all is "a promise for a list of promises", this is more like "a promise for a map of promises".

I'll make this change tonight or tomorrow unless someone suggests otherwise:
Repository name: "proposal-await-dictionary"
Title: "Await dictionary of Promises"


Proposal: Inherit constructor and static methods from base Message class

I was wondering why we are generating static methods instead of simply inheriting them from the base class. Is there a reason for that?
With these messages also also used in the frontend as part of e.g. connect-web, I think we have to be extra careful not to add too much weight especially for projects with a lot of messages.
I was thinking of doing something like this with the base Message class:
export class Message<T extends Message<T> = AnyMessage> {
  static readonly runtime: ProtoRuntime;
  static readonly typeName: string;
  static readonly fields: FieldList;

  static fromBinary<T extends Message<T>>(
    this: MessageType<T>,
    bytes: Uint8Array,
    options?: Partial<BinaryReadOptions>
  ): T {
    return new this().fromBinary(bytes, options);
  }

  static fromJson<T extends Message<T>>(
    this: MessageType<T>,
    jsonValue: JsonValue,
    options?: Partial<JsonReadOptions>
  ): T {
    return new this().fromJson(jsonValue, options);
  }

  static fromJsonString<T extends Message<T>>(
    this: MessageType<T>,
    jsonString: string,
    options?: Partial<JsonReadOptions>
  ): T {
    return new this().fromJsonString(jsonString, options);
  }

  static equals<T extends Message<T>>(
    this: MessageType<T>,
    a: T | PlainMessage<T> | undefined | null,
    b: T | PlainMessage<T> | undefined | null
  ): boolean {
    return this.runtime.util.equals(this, a, b);
  }

  constructor(data?: PartialMessage<T>) {
    const self = <typeof Message<T>>this.constructor;
    self.runtime.util.initPartial(data, this as any);
  }

  // ...
}

Are there any reasons why this wouldn't work at runtime?

You'll get CSP errors if you try to new this.constructor(). Instead just new this().
class A {
  static foo() {
    return new this();
  }
  constructor() {
    this.bar = 1;
  }
}

class B extends A {
  constructor() {
    super();
    this.baz = 2;
  }
}

const b = B.foo() // B {bar: 1, baz: 2}

Ah, yeah... I ran into that in the past. Anyways, this is just sudo code for now to illustrate the proposal.

@fubhy, we ran into some type issues with this. It has been a while, and unfortunately I can't tell you whether it was related to to an older version of TypeScript (we test down to 4.1.2), or compilation to .d.ts losing type information, or something else.
The code compresses very well, but it would obviously be pretty neat if we could get around it!

@timostamm Do you think it would make sense for me to try and experiment with this a bit? Does @smaye81 maybe remember what the limitation was or one of your colleagues? I'd be keen to give it a shot unless you can confirm it's indeed proven to be a dead-end :-)

Sorry for the delay.  I don't actually remember what it was either.  If you are able to get around it though, as @timostamm said, we'd be all ears!

Hi @fubhy just doing some maintenance of the repo. Were you still working on this PR? If so, no worries. If not, was going to close it due to staleness.

Hi @fubhy just doing some maintenance of the repo. Were you still working on this PR? If so, no worries. If not, was going to close it due to staleness.

Sorry, saw your message but then forgot to reply. No, I'm currently not working on this. I'm neck deep in other unrelated work atm. and won't have time for OSS in the next few days / weeks.

No worries. I'm going to close this, but if you get back around to it, feel free to reopen. Thanks!


Allow installation of custom packages on provisioning

What feature would you like to be added?
A way to be able to install packages on worker deployment.
What are use cases of the feature?
As example when running https://longhorn.io/ on the workers, some additional packages like open-iscsi have to be installed.

@fionera at the moment this is handled by using custom image with everything you need preinstalled. Being a cross distribution package manager is out of scope of KubeOne and MachineController.

On the other hand, we could install ’open-iscsi’ specifically.


Object files from src/ should end up in board-specific build directories

When building for multiple boards, the object files from the shared sources src/ end up in the same directory, i.e. _build/src/.
I gave it a shot and tried to fix it, but can't come up with a simple solution. Creating this issue for visibility. For now, one has to remove _build before building for a different board, otherwise the usb descriptor etc will be reused from the previous build.

Yes, it's a tradeoff of using tinyusb's build system which we might outgrow at some point, no easy fix for that one right now.

For ecp5 I already took out the tinyusb build system because it was too inflexible. If you want I can make the same change for the other platforms which will actually simplify things for ecp5?  The changes I made already almost address this issue because otherwise you get namespace clashes (or at least the potential for them)....wouldn't be difficult to prepend the target name into the build output directory.

Sure, go for it :)


Change TransactionRequest to return a response.

examples/online_debit_transaction.rb line 54 defines to return a response.

Thank you so much @adbatista :clap:

cool :smile:
seems good to me

:+1:


cc!ban does not ban the user if they have DMs disabled

Describe the bug
Attemping to ban a user who has DMs disabled from server members will not sucessfully ban the user, instead a DiscordAPIError will be thrown and the user remains in the server (the only way to ban them is via Discord directly or through another bot)
Expected behavior
The user should be banned regardless of their privacy settings. Although I would suggest that a message be sent in chat letting the moderator know that while the ban was successful, the user would not have recieved the appeal form or reason.
To Reproduce
Steps to reproduce the behavior:

Disable DMs from server members on an alt account
Attempt to ban the alt account via cc!ban
Error is thrown and user is not banned.

Screenshots

Additional context
Fairly low-priority bug seeing as we can always just ban via Discord but it's also decently important to have users receive the appeal form.

Text commands have been phased out.


Auto run all tests for CI.

This pull request accomplishes the same as exercism/xruby#100 without changing
any slugs in the config.json folder.
I still ended up having to change some of the name of some of the files loaded and also the names of some of the test files to conform to what's on the config.json.

Hmm.. I don't think that failure is real.  All I did was remove script I used to clean up some of the name discrepancies.

Yeah, you can change the names of all the files inside the test folder. The only restriction is that the example file needs to have /[Ee]xample/ in the name, and the test file is assumed to follow the .*_test.rb format (though I think that the code allows for a much looser definition).

This looks very nice. Using hyphens for the filenames is unusual, but that might be worth it. The only worry that I have is that newbies will see this and think it's a convention, and then use it in their projects.
What do you think of saying tr '-' '_' when renaming the example file to the assignment slug so that we follow ruby conventions?

yeah, that makes senses.

@kytrinyx this now uses _ for all tests and source files by tr-ing the - to _.

I love this, thanks so much for taking the time to work it out!

Thanks!


Is this project maintained?

@dims pointed this tool out in https://github.com/kubernetes/community/issues/3700.
The tool currently only uses the list of commits for a particular path. While this can helpful in getting an idea of who worked on the code more, it doesn't give an idea of who is also reviewing the most.
I have a few enhancements in mind, but I was wondering if this repo is still maintained or if I should be adding my changes in a fork.
cc @philips

I hit enter too early and added the issue body after creating the issue, so cc'ing again. :grimacing:
I'll add stuff in my fork for now, but still curious about the status of this project. If you are open to maintaining this project,  maybe we can migrate it to kubernetes someday. :)
cc @philips @dims

this project is no longer maintained. Feel free to create a fork and a PR pointing to your fork and I will archive the project.


Can we apply actionformer to video streams?

As mentioned in the paper, for inference, the whole video clip is fed into the network because no position encoding is added.
What if the input is a non-stopping video stream? Can we make some adjustments to actionformer, like adding position encoding? Will it work?

Hello, I think they may refer to online action recognition/detection methods.


No easy way to manually construct and sign transactions into Transaction

Is your feature request related to a problem? Please describe.
Sometimes you want to have total control over the transaction by manually filling in all the fields (i.e. no RPC calls to find out what the nonce should be, for example). However, ethers-rs seems to offer no easy way to do this. To manually construct a transaction ready to be broadcast, you'll need to:

Construct a TransactionRequest instance and fill in all Option fields with Some (clearly this is not designed to be used this way);
Sign the TransactionRequest object with a signer, by calling the (unnessarily) async sign_transaction() method, to obtain a Signature;
Calculate the transaction hash by calling keccak() on rlp_signed() to figure out transaction hash (this is because you need the hash to construct a Transaction object!);
Construct the Transaction object by unwrapping all the Option fields on TransactionRequest.

This is unnessarily complicated, since we're actually using the flow which assumes some fields are missing.
Describe the solution you'd like
There should be:

An UnsignedTransaction struct type designed specially for this, with none of the fields optional;
a non-async sign_transaction() equivalent that directly turns UnsignedTransaction into Transaction.

Describe alternatives you've considered
N/A
Additional context
N/A

a non-async sign_transaction() equivalent that directly turns UnsignedTransaction into Transaction.

Alternatively, we can have the function return a Signature, for consistency's sake, and add a method to construct Transaction from UnsignedTransaction and Signature.

This will allow for easily signing transactions in a non-async context, where all the transaction fields are known in advance.

Oh, also such a UnsignedTransaction will only accept an actual address as to, not ENS names, as that would introduce the need for RPC calls again.

Just in case someone needs it, this is the code I'm using right now:
use ethers::{prelude::*, utils::keccak256};

pub struct UnsignedTransaction {
    pub from: Address,
    pub to: Option<Address>,
    pub gas: U256,
    pub gas_price: U256,
    pub value: U256,
    pub data: Bytes,
    pub nonce: U256,
}

pub async fn sign_transaction(
    signer: &LocalWallet,
    unsigned_transaction: UnsignedTransaction,
) -> Transaction {
    let tx_request = TransactionRequest {
        from: Some(unsigned_transaction.from),
        to: unsigned_transaction.to.map(NameOrAddress::Address),
        gas: Some(unsigned_transaction.gas),
        gas_price: Some(unsigned_transaction.gas_price),
        value: Some(unsigned_transaction.value),
        data: Some(unsigned_transaction.data),
        nonce: Some(unsigned_transaction.nonce),
    };
    let tx_signature = match signer.sign_transaction(&tx_request).await {
        Ok(signature) => signature,
        Err(_) => panic!("Infallible"),
    };

    Transaction {
        hash: keccak256(tx_request.rlp_signed(&tx_signature)).into(),
        nonce: unsigned_transaction.nonce,
        block_hash: None,
        block_number: None,
        transaction_index: None,
        from: unsigned_transaction.from,
        to: unsigned_transaction.to,
        value: unsigned_transaction.value,
        gas_price: unsigned_transaction.gas_price,
        gas: unsigned_transaction.gas,
        input: tx_request.data.unwrap(), // This won't panic as tx_unsigned.data holds a Some()
        v: tx_signature.v.into(),
        r: tx_signature.r.as_fixed_bytes().into(),
        s: tx_signature.s.as_fixed_bytes().into(),
    }
}

unwrap() is used in constructing Transaction to avoid (potentially expensive) data copy, and is actually safe.

Hello, I think you are over-complicating things. Please consult the examples to see the intended usage: link here

Construct a TransactionRequest instance and fill in all Option fields with Some (clearly this is not designed to be used this way);

you want the builder pattern (see the example)

Sign the TransactionRequest object with a signer, by calling the (unnessarily) async sign_transaction() method, to obtain a Signature;

Signer::sign_transaction is necessarily async, as most signers used in prod are async. This includes ledgers, HSMs, RPC, and other remote signers. If you would like to sign a transaction synchronously, consider using the underlying SigningKey for your local wallet.
@gakonst we should consider having Wallet<SigningKey> provide a synchronous signing interface

Thanks for the detailed answer!
I was aware that one can use the chained (fluent) API for building a transaction manually. However, that pattern still assumes that not all fields are filled. There's no way to enforce all necessary fields are provided at compile time.
As for async, sorry I should have looked deeper into the code before submitting the issue lol. I thought the async was only for looking up the missing fields, and this calling it "unnecessary" in my use case.
Maybe my use case is niche enough that it's better served as a custom utility function similar to what I posted above.

to ensure all fields are present, have your code invoke each builder method (at least) once. the compiler will ensure that each method has a valid argument

Fair enough, but:

"calling each method at least once" is not enforceable by the compiler (and should not, as that's not the intended usage). Someone forgetting to call a certain method might unknowingly leave it to be fetched from RPC at runtime;

the resulting object still has Options for all its fields when they're actually knowingly Some.

These issues exist because TransactionRequest is not intended for offline signing. My proposed UnsignedTransaction is.
I'm just gonna use my utility function for now. Please close this issue if you guys believe it's unnecessary to support it in the core. (if that's the case we can probably still add an example though)

@xJonathanLEI Closing this optimistically - please re-open if you think it's still an issue.
The recent EIP-1559 changes made it so that send_raw_transaction takes the RLP-bytes which you get via this call.
As a result, the flow would be:
let signature = signer.sign_transaction
let bytes tx.rlp_signed(chain_id, signature)
// ...do whatever you want


[hotfix] Compile error of ForStStateExecutor

What is the purpose of the change
Compile error due to creating invoker from one PR and modifying the signature by another PR.

I'd propose we merge this ASAP after the CI compile stage passed.

@flinkbot run azure

@flinkbot run azure

Compile CI passed: https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=62691&view=logs&s=ab6e269b-88b2-5ded-2544-4aa5b1124530&j=b59e5554-36c7-5512-ab1a-b80b74075fce
Merging...


[C++][Parquet] Travis coverage is broken

Pull request #92 (https://github.com/apache/parquet-cpp/pull/92) made changes to the travis build dir. These changes seem to have broken the coverage.
https://coveralls.io/builds/6003456
Errors can be seen below
https://travis-ci.org/apache/parquet-cpp/jobs/126949580
Reporter: Deepak Majeti / @majetideepak
Assignee: Wes McKinney](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=wesm) / @wesm
Note: This issue was originally created as PARQUET-606. Please see the migration documentation for further details.

Wes McKinney / @wesm:
Issue resolved by pull request 101
https://github.com/apache/parquet-cpp/pull/101

Wes McKinney / @wesm:
patch here: https://github.com/apache/parquet-cpp/pull/101
will verify that it fixes the coverage build before we merge

Wes McKinney / @wesm:
The problem is that I switched us from Ubuntu 14.04 to 12.04 because of the LLVM toolchain switch, and it caused some issues. I'm going to try to revert it now


Cicero Template Version

Hello Team,
I am using cicero latest version (0.21.9). Is there any way to allow cicero node package to accept multiple template version?
Please help me about that request.
Thanks

Hello Team,
I am using cicero latest version (0.21.9). Is there any way to allow cicero node package to accept multiple template version?
Please help me about that request.
Thanks

@fnaeemgsi Apologies for answering this with so much delays. Could be a bit more specific (maybe with an example of what you are trying to do?).
You should be able to run various template versions as long as they are compatible with your current version of Cicero.


"Do you want to open it anyway?" in diff editor no-ops

The text view should be able to try to render the binary data, if you open it in a non-diff view it does show text.

To clarify, we want to replace a diff editor with a normal editor right? Or should this action reopen as diff editor?

It has to do with replacing a side of a diff editor input.
There's two possible solutions here.

Support replacing sides of a diff editor input (probably over complex) so that the user will see the binary message and then can click open anyways
Always open text diffs as files even if binary.

I think I would expect the diff editor to reopen where both sides pick the editor I selected from the quick pick.

The quickpick only knows about one side of the editor at a time. We explicitly disable reopen with in diffs for this reason. Just the binary case is a special case as the user can trigger the quickpick from the link

I see, I probably then would expect that it opens the editor where I selected the link from. If that is too complex, maybe we open the editor as a new editor, and not as diff?

What I don't understand is why we have this idea of a binary diff editor? It's of no use and both sides just show that they're binary and request to be opened as something else. Wouldn't it make more sense to just show the text representation of the file if opened in the diff view. Any useful binary representations will get delegated to an extension anyways which is supported.

@lramos15 for consistency reasons and for performance reasons.

consistency: if you get the binary editor by clicking on the binary file, I would expect the same when diffing
performance: binary files can easily be gigabytes in data, just opening them as text for the diff case would potentially bring down the window

This is really tricky to fix, the issue is here:
https://github.com/microsoft/vscode/blob/f2b1f78ad45d5b19fe220e4533356efb31f4dcc1/src/vs/workbench/contrib/files/browser/editors/binaryFileEditor.ts#L53-L60
We try to replace the editor, but the editor is actually not opened as a single editor, it is opened as a diff editor on the one side.
I would also argue that this line is fishy:
https://github.com/microsoft/vscode/blob/f2b1f78ad45d5b19fe220e4533356efb31f4dcc1/src/vs/workbench/contrib/files/browser/editors/binaryFileEditor.ts#L47-L47
Because that only makes sense if the editor that is picked is a text editor, not when it is a custom editor.
I think we need to revisit that code entirely, since it originates from a time where we did not have overrides either.

Maybe this could work:

since this can only be triggered by the user from the active editor, check if group.activeEditor is a side by side editor and then tweak the call to replaceEditors accordingly
only call setForceOpenAsText if the picked editor is a text editor

Diffing two random exe's from the vscode repo, it looks like nothing is shown in the diff view. We should at least have some message here
https://user-images.githubusercontent.com/2230985/124199962-0db0d700-da89-11eb-88a4-da5d30698e0e.mp4

This now seems to be opening a monaco text diff editor and not a binary diff editor anymore which seems like a regression from our work in the editor service (most likely):

@lramos15 this is a regression from comparing untyped based in matches for typed editor inputs:
https://github.com/microsoft/vscode/blob/5b29adfa24daf111d35367e9e23ddd4557ec363a/src/vs/workbench/common/editor/diffEditorInput.ts#L157-L159
The isResourceDiffEditorInput unfortunately will be true even for DiffEditorInput.
I will open a PR to make our various functions that check for untyped editors more robust.


Prophet111

Checklist before submitting

[ ] Did you read the contributor guide?
[ ] Did you update any affected documentation?
[ ] Did you write any tests to validate this change?

Description
Fixes # (issue).
Review process to land

All tests and other checks must succeed.
At least one maintainer must review and approve.
If any  maintainer requests changes, they must be addressed.

No proper open-ce branch selected to make local commit.