Support ligatures in terminal

Regresses with performance improvements in terminal's renderer https://github.com/Microsoft/vscode/pull/33954

Hi! is there any timeline for this feature?

Nope.
Here's the upstream issue https://github.com/sourcelair/xterm.js/issues/958

Would be really nice if there was a setting to re-enable the old terminal rendering until all the issues with the new terminal are resolved (blurriness, ligatures, emoji).

It seems there is now an xterm.js plugin for ligatures support:
https://github.com/xtermjs/xterm-addon-ligatures
How can we get it into vscode?

@MPV it would have to be built into the core, the main thing that needs to happen now is to evaluate how much weight the addon would add to the VS Code distributable.

any news on it? I believe this is the last thing is missing for terminal to render everything proper

Just tried Cascadia Code font in the integrated terminal... ligatures not present 😢

I see that there's a way to do this via an extension that modifies VS Code's internal files. Would it be possible to add a checkbox in settings that toggles this itself? @Tyriar

@jhpratt that's what it would do eventually, the remaining work here is slimming down the ligatures xterm.js addon to bare essentials and test/include it. I don't have time to do it right now due to other priorities though.

Is this bug why I got this in vscode:

instead of:

(using this font https://github.com/adam7/delugia-code)?

@Geobert probably caused by https://github.com/xtermjs/xterm.js/issues/1709 or https://github.com/xtermjs/xterm.js/issues/942, ligatures are different to emoji.

Got a bunch of questions about ligatures when tweeting about the WebGL renderer so I'll give an update here. Here's the remaining work to do on this:

xterm.js

Integrate xtermjs/xterm-addon-ligatures into the xtermjs/xterm.js repo, this will enable automated publishing and ensure tests continue to pass
Hook up ligatures into the demo
Set up some puppeteer tests that verify on all renderers (dom, canvas, webgl) that ligatures are working
Slim down the dependencies as much as possible

vscode

Integrate xterm-addon-ligatures such that the addon code is not loaded if ligatures is off, add the setting, etc.

Apologies if this comment is not appropriately placed as I'm new to github and dev in general.
So it's my understanding that ligatures in the integrated terminal are disabled until other problems are fixed? Thanks and good day!

@threedogs1 yep, the first step above is happening in https://github.com/xtermjs/xterm.js/pull/2847

Looks like this has been merged? https://github.com/xtermjs/xterm.js/pull/2847

https://github.com/xtermjs/xterm.js/issues/958

This should help https://github.com/vercel/hyper/issues/3607

@regisbsb there are additional challenges for vscode, we would likely have to break the support once again soon as we're working towards turning off node in the renderer which the addon depends on.

@Tyriar I was really interest to see if it made to hyper tbh but vscode would be nice enough

Any progress on this? The Terminal still doesn't seem to support ligatures...

Any progress on this? The Terminal still doesn't seem to support ligatures...

This open source. You can always create PR if it's so urgent for you.

Here's what this issue is blocked on FYI https://github.com/xtermjs/xterm.js/issues/958#issuecomment-623114150

so this was released 2 months ago https://www.npmjs.com/package/xterm-addon-ligatures
does it just need integrated?

@Pyrolistical see https://github.com/microsoft/vscode/issues/34103#issuecomment-561851965

for anyone still looking who'd be satisfied with basic ligature support:

using common zsh themes n fonts on big sur with the following entries in settings.json
{
    "terminal.integrated.fontFamily": "Fira Code", // 1st prompt, zsh 'cloud' theme

   // "terminal.integrated.fontFamily": "MesloLGS NF" // 2nd, oh-my-zsh p10k theme
}

terminal.integrated.fontFamily value set per discussion in this gist
doesn't seem to track output / totality of behaviour mentioned above, but for me those more a "nice-to-have"

@zzstoatzz I'm sorry, but I don't quite understand your post. Where in the image are ligatures demonstrated?

@zzstoatzz I'm sorry, but I don't quite understand your post. Where in the image are ligatures demonstrated?

oof, sincere apologies, I've deleted my comment since I realized I had misunderstood ligatures to be special characters as opposed to specific combinations of special characters

Blocker:

[ ] Make sure font-finder isn't bundled into product build

Around 2023 then?

I tried recently to integrate this but ran into some electron related problems including a segfault on macos, so this got pushed. See https://github.com/microsoft/vscode/pull/139537

PR to enable ligatures with an experimental setting: https://github.com/microsoft/vscode/pull/157008

Hi,
So is this expected to be done?

@remidebette not yet, but soon

So can I enable the experiment or is it not even an experiment yet?

I want ligatures on my terminal, even if it's hacky. How hard would it be?

Would love to see this. Specifically, I'm using Twilio Sans Mono and would like the (::) ligature to work when I run npx bitandbang :)

This is still blocked on https://github.com/microsoft/vscode/pull/157008#issuecomment-1206848384. If anyone wants to help investigate that would be helpful, otherwise since this is pretty low priority against my other tasks it's up to whether I feel the motivation in my free time.

why is this feature taking several years what am I missing?

Yes, you are completely missing the fact it's an open source. Go and implement yourself if it's so urgent for you.

Claiming that VS Code is "open source" is childish and unreasonable. This is a Microsoft product.

This is, open source, this ˅, isn't

I don't care but stop pretending the codebase has any excuse to be rotting, Microsoft has enough cash and engineers, it's just bad management, not "open source".

@junaga a few things:

Copyleft is open source, open source is not copyleft
This repository is literally open source
This particular issue would happen if someone helped out as called out in https://github.com/microsoft/vscode/issues/34103#issuecomment-1331018529, every time I give this a shot I hit some roadblock and it gets pushed back
Suggesting to rewrite the terminal is really silly
Suggesting to embed Windows Terminal is also silly, WT lacks a lot of features we do and it wouldn't work on the Linux, macOS or the web which is are all major platforms we target. You're either suggested we drop support for those platforms or waste time trying to support multiple terminal frontends
Read the code of conduct
I recommend switching editors if ligatures is more important to you than everything else VS Code offers

Windows Terminal
I was not aware Windows Terminal only runs on Windows, my apologies. wt being a new product, with the fancy trailer and all, I thought it was linux, macos and freebsd too. I still think it a wt extension would have been worth a shot otherwise.
open source
VS Code is, in any meaningful interpretation of the word "open source", not an open source community project, but a company-owned, brand, designed and tested. I know closed-source projects that are more open than the VS Code app. Publicly readable source code is of little use if everyone pulls your build with closed-source DRM and trackers. Also, there are no other providers to sign in and settings sync. My guess is ~80% of users don't know other builds exist, or they simply don't trust them (fear of scam). a gap in subject knowledge is the oldest excuse in the book of exploitation. The whole point of the term "open source" was freedom, for our half of the world, the blue internet. But I wouldn't expect an $MSFT employee to understand that.
again, I don't care,
bad management
but hiding behind an "open source" shield is not respectable. you are employed and literally paid to write this code. I understand that ligatures are not as much a priority, as the fancy GitHub copilot chat, which is why I might just switch to Google IDX, they have ligatures on their homepage.
have a nice day @Tyriar

@junaga btw Google IDX is a fork of VS Code so it wouldn't have ligatures in the terminal either

god damn it, nvm then

but you see the issue, right? this is what MIT enables.

I'm not understanding your point. It's open source so people can fork it, which is a good thing? Google may also end up contributing upstream, improving VS Code and all its forks.
Yes VS Code is "built on OSS", not open source itself. It follows a very similar pattern to Chromium and Chrome. I'm pretty sure VS Code would not exist if there was not a private fork as MS needs to protect its trademarks. It seems like a net benefit to me that VS Code, this OSS project and all its forks exists.
You can argue forever about free software/copyleft vs open source, but that's not going to change the license of the repo or anything.

My point was, that it doesn't matter if a new fork is better or not on MIT projects.

https://hackaday.com/2023/08/23/linux-fu-the-old-school-terminal/

just rewrite the terminal service If it's not feasible

why is this feature taking several years what am I missing?

(https://github.com/microsoft/vscode/issues/34103#issuecomment-1680584127)
Look, I get that many of us have reasons to hate on Microsoft, but berating their engineers working on open-source (or at least, source-available) and free (as in beer) projects isn't a good way to cope with it, because:

They are engineers too, just like you (at least, I would like to believe you are, although the above quoted passages bring that into question)
It's free stuff, for goodness' sake. Even with paid products, companies sometimes fail to maintain adequately because their priorities are elsewhere, and the appropriate recourse in that case is to vote with your wallet and take your money elsewhere (or even invest in creating your own alternative out of spite). Open source isn't special, if you don't like it, take the money you're not paying elsewhere, make your own, or, even better, fix it yourself.

Once more for those in the back: open source isn't special. "submit your own patch" isn't a shield, it's literally the one unique thing you can do compared to closed-source, proprietary stuff.
On the other hand, demanding that some other engineer do it because they're paid (not by you) by the company funding the development of the project isn't open source, it's open entitlement. It's the type of thing that makes corporations feel like

"open source" is childish and unreasonable

(https://github.com/microsoft/vscode/issues/34103#issuecomment-1684891222)
Thanks for coming to my TED talk, mods, please hide the above bunch of comments so other people who come looking for terminal ligature support won't go away shaking their hands and without terminal ligature support.

Hi @jeslinmx, That's a good TED talk. However, there are two things you got wrong.
This is a Microsoft product
VS Code is a fork of gh:microsoft/vscode. However, the majority of users believe that VS Code is a distribution of gh:microsoft/vscode.

gh:microsoft/vscode is MIT lincenced (not FOSS/copyleft)
VS Code is closed-source and proprietary software
VS Code includes evilish google grade, trackers, DRM, etc.
the gh:microsoft/vscode repository description literally links to https://code.visualstudio.com/

This is a Microsoft product, with Microsoft responsibility, management, and funding.
The narrative of VS Code being open source was mistakenly constructed from misleading web pages, readmes, videos, and word-of-mouth conversations. Microsoft's failure to uphold its responsibility in this case is a reminder of the importance of corporate ethics.
Sorry @Tyriar, but comparing this distribution model to Google Chromium/Chrome is again a bit misleading. Google Chrome does not title itself as being "built on open Source" whatever that means. Atom was, but it had no users, which was a product design issue, not a licencing issue.
Wikipedia got it right
https://en.wikipedia.org/wiki/Visual_Studio_Code

made by Microsoft

https://en.wikipedia.org/wiki/Google_Chrome

developed by Google

Not called "open source" once in either article.
Source-available is the norm nowadays
Go ahead and try to get any downloads on a closed-source npm package. good luck. It's the same everywhere. The super secret SaaS product your company is working on would hardly get any downloads if distributed closed-source. Yes, we usually tend to overvalue our own software. But no developer will ever choose a closed-source technology (framework, library, middleware, code linter, etc.) to develop their own software with.
Oftentimes SaaS vendors don't even have the choice anymore to go closed-source. Without adoption, maybe even without VC investment, you can't build the product, and huge repercussions (https://www.youtube.com/watch?v=HzBA6FIn_Bo&t=142s) will follow if you close it afterward.
Other software, imho
Only apps and games distributed within app stores benefit from being closed-source as of 2020. Users and developers expect products to be source-available. This is a significant change from 20 years ago. I would argue a positive cultural development. The world should not be split into computer wizards and mortals.
Personal talk
How about you mark your own post as off-topic 😅. Because my previous comments were a lot more on-topic than your meta-discussion (discussion about discussions).
Of the many VS Code users I've spoken to, both in professional and personal settings, none were aware that VS Code is closed-source software. In fact, many Discord users I talked to (hundreds), were under the impression that it is free and open-source software (FOSS). It was important for me to speak out about this misunderstanding in plain and honest language.
Trying to personally attack ("you're not an engineer") is actually the thing that makes open source look unprofessional. Not harsh language itself. You're correct, I am not. I work as a developer, as you can read from my profile, and I honestly don't have compassion for brittle, company, code. and yes, grown-ups sometimes cuss. I apologize.

@junaga please stop, you're only being a nuisance. Whenever you make a comment, everyone who is subscribed or has commented will get a notification. A feature request about ligatures in a terminal is not the right place for this kind of thing.
You were warned before about the code of conduct. If you keep going I'll either block you from the repo or lock this issue, the latter of which I really don't want to do as it disables voting.

https://www.unicode.org/L2/L2023/23107-terminal-suppt.pdf TCSS (Terminal Complex Script Support)

We find that a standardized specification for how to handle text in terminals is important work for the modern community of developers, and all other people that use text terminals.

Fonts that meet these requirements, referred to as “terminal fonts”, will work properly with the layout algorithm defined in the specification.

Looks like the issue will be fixed upstream. Couldn't the mentioned algorithm be re-used, but with queries against the font instead? I mean, it would have to be implemented in the terminal emulator either way.

@junaga the terminal renderers work by splitting up the rendering of the characters. The ligatures addon in xterm.js is implemented by joining sets of characters such that they are rendered together: https://github.com/xtermjs/xterm.js/tree/master/addons/xterm-addon-ligatures
So yes, but this is already done. We're just stuck on a packaging issue as mentioned in the last update: #34103 (comment)

The mentioned PR is closed but this issue is still open - any idea what the current state is?

Related on Stack Overflow:

setting character variants ss01, ss02, ... in vscode settings does not work in vscode terminal
Progress bar in Vs code terminal

so this is still an  open  issue ? Is there a specific reason why ?

Can we ever get this implemented? 2025 is around the corner and this issue was opened in 2017?

@airstrike if you want it, you should see if you can fix the previously mentioned blocker and submit a PR yourself: https://github.com/microsoft/vscode/issues/34103#issuecomment-1699403159

With this config: "editor.fontLigatures": "'calt' 0, 'zero' 1" in settings.json you can get the slashed zero for Jetbrains Mono, but terminal still shows the usual doted zero... A "terminal.fontLigatures": "'calt' 0, 'zero' 1" would be a great fit

@Tyriar is there a repro of the bundling issue? I feel like that would be a good starting point for those that want to help here

Giving it another shot in https://github.com/microsoft/vscode/pull/232829

Wow amazing!

Finally

Just to confirm, this setting only accepts a boolean value and does not enable explicit font-feature-settings like ss01 or cv69? That is, even if terminal.integrated.fontLigatures is true, the font may not necessarily match the style sets and character variants enabled in the editor?
// settings.json

// Works
"terminal.integrated.fontLigatures": true

// Won't work as expected at this time?
"terminal.integrated.fontLigatures": "'calt', 'liga', 'ss19', 'cv69'"

Compare editorOptions.ts to terminalConfiguration.ts.

@joshlawton yes it's all or nothing right now. If someone can figure out how to pass that information on to an OffscreenCanvas it should be trivial to add the support: https://developer.mozilla.org/en-US/docs/Web/API/OffscreenCanvasRenderingContext2D#text_styles
Created https://github.com/microsoft/vscode/issues/235316 to track

It works strangely on the latest Insiders build. Some of the ligatures are working, and some are not. Cannot figure out the rule, but for instance '=>' works, but not '-<'.
Note that it doesn't work in the input but does work on the output; some ligatures don't work either on the input line or in the output.

It works strangely on the latest Insiders build. Some of the ligatures are working, and some are not. Cannot figure out the rule, but for instance '=>' works, but not '-<'.
Note that it doesn't work in the input but does work on the output; some ligatures don't work either on the input line or in the output.

I found - and < has different colors in the first line, which may be the reason.
The third line is correct.

I found - and < has different colors in the first line, which may be the reason.

@Master-Hash yes that's by design in that particular case since pwsh is coloring is differently

Inconsistent Ligatures
This was just released as preview and for some reason is not properly doing the ligatures on zsh, tried a few nerd fonts too, I'm certain the font is not the issue as it works on the editor itself but not the terminal for some reason It's inconsistent and completely random, attaching image:

As you can see <== is properly represented but not the rest of ligatures also failing for the next <== which is typed in the same exact manner.
snippet settings.json
{
  "terminal.integrated.fontFamily": "Fira Code",
  "editor.fontFamily": "Fira Code",

  "editor.fontLigatures": true,
  "terminal.integrated.fontWeight": "normal",
  "terminal.integrated.fontLigatures": true,
}

Any idea on why this behavior is happening only for certain ligatures, or any fixes/reconfiguration I can do ?
System

Arch Linux
zsh
P10k
Fira Code

I encountered a problem where the progress bar cannot be displayed correctly in the terminal using the Fira Code font.
echo "[=========================---------------------------------------------------------------]"

Will be

@sunshaoce tracked in https://github.com/microsoft/vscode/issues/235988 👍


Slimeread: Move slimeread to lib-multsrc and add mahouscan

Closes #6630
Closes #6673
Checklist:

[ ] Updated extVersionCode value in build.gradle for individual extensions
[x] Updated overrideVersionCode or baseVersionCode as needed for all multisrc extensions
[x] Referenced all related issues in the PR body (e.g. "Closes #xyz")
[x] Added the isNsfw = true flag in build.gradle when appropriate
[x] Have not changed source names
[ ] Have explicitly kept the id if a source's name or language were changed
[x] Have tested the modifications by compiling and running the extension through Android Studio
[x] Have removed web_hi_res_512.png when adding a new extension

@choppeh Depois manda teu discord que eu te add la

@choppeh Depois manda teu discord que eu te add la

Tô no discord da Keiyoushi com msm nickname do Github


⚠ Fortnite has degraded performance

In 4c854f7, Fortnite (https://fortnite.com) experienced degraded performance:

HTTP code: 200
Response time: 1545 ms

Resolved: Fortnite performance has improved in bb10a9b.


Automated Package Upgrade

:tada: This PR is included in version 9.3.10 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


add support for undo and redo to vi KeyMap

This adds support for undo and redo to the vi KeyMap. This required adding the concept of an undo group to the Buffer struct.
#6
Depends on #27
Blocks #29

Included in MovingtoMars/liner#30


map tlc --> /tools/bin/tlc

@pjbreaux
Issues:
Fixes #371
Problem: tlc is used as part of the in-house test
procedure, but it's install procedure does not
place it in a standard location.
Analysis: This commit makes invocations of tlc explicitly
call /tools/bin/tlc the location it is installed to.

Could we just alter the PATH in the makefile?

@pjbreaux rebased on top of device version multiplex from @swormke .

OK @pjbreaux "all checks have passed"

Ahh...   I see your question.
I think altering the path in the makefile doesn't buy us anything.
Making the invocation explicit in the scripts doesn't lose us anything.
By being explicit we make the task of the person reading the scripts easier.
The tools running the scripts don't care if the invocations have a few extra characters.
So, my opinion is that being explicit here makes the code more readable, for no drawback...    am I missing something?

Here's another point...    suppose we set the "USERS" path in the Makefile to include "/tools/bin"...    well in some cases the User (probably 'buildbot') must already have this in their PATH...    and this is fine...   making it an explicit path in the scripts won't adversely affect "buildbot"...
What it does do is make it unambiguous that when we say "tlc" in the scripts we mean "the tlc that was installed by 'make tlc-install'".
This is explicit and therefore good.


Revisions 22, 23

Move branch validation workflow to correct path
Merge pull request https://github.com/dwellir-public/polkadot-operator/pull/44 from dwellir-public/clarify-config-description
Removed the need for validator-address config param https://github.com/dwellir-public/polkadot-operator/pull/46 https://github.com/dwellir-public/polkadot-operator/pull/41/commits/42e20c262b76dcbe443c64af18360df90a90b565
-Merge pull request https://github.com/dwellir-public/polkadot-operator/pull/48 from dwellir-public/liberland
Fixed typo in event result key for action

This PR accidentally claimed rev 20, 21 -> this one becomes 22, 23.

I think it is time to merge this for a new revision now. Two steps remain though:

Anyone against releasing, e.g. some code just about to come in?
We should do the standard tests with this code; deploy to this version, refresh from previous version to this one, use the actions in this one. Any taker to do that?

Local tests of charm checks out. Someone please approve :D

Push to prod! :beers:


Doesn't work unfortunately.

When the radio icon is clicked, it does not work anymore. Just complete silence.
EDIT: It started working, wasn't working for a while now. Thank you for the extension so much!

Hello @khanpearl ,
Thanks for the report. I already submitted the fix (v0.6.0) for review and am waiting for the result.
To give you some background, Twitch sends a silent video (or audio) during the advertisement. So, if you are lucky and don't need to wait for the ads, the audio will be played immediately. With ads, the audio will be still played normally in 15-30 seconds.
I think the way I used to bypass the ads in previous versions is not working anymore.
The new version (v0.6.0) unfortunately plays the ads in the radio mode, which I think is better than just 30 seconds of silence, but instead it should now skip the ads if you subscribe the channel or have Twitch Prime.

Sorry I forgot to close this issue. Closing it now.
v0.6.0 was released about a month ago and the issue should have been resolved. Please let me know if you have any other problems.


Bring help command back to working condition

TODO: Add discord embed back to fix fully

const embed = new Discord.RichEmbed();
    embed.setColor('RANDOM');
    embed.setDescription(`**${command.name}:** ${command.description}`);
message.channel.send({ embed });

Gonna go ahead and push this PR.. embeds aren't really needed.

pushed.


How to add search filter

hi,
I'm using this lib for section in recyclview but how to add search filter in list

I am adding search filter in recyclerview .my issue is FilterResults not working. some value add for multiple time in list.

any demo project / sample code?


Ejsorrento solution

Completeness : 5
Comfort: 2.5
I understood the objective of todays lesson, I just had trouble building it. I've found multiple pages to study tonight and have found a lot of info for this in my JavaScript For Dummies book. I realize now that I'll have to fill in knowledge gaps by writing them down and revisiting them later on, on my own.
Sorry about commit 4, 5, 6. I forgot those because I went in a new code direction

👍
let me know if you have specific questions


Reco examples

Added two reconstruction examples; one or fully-sampled cartesian data and one for radial-interleafed
Both files have markdown comments in order to be visually appealling in their jupyter-notebook end-form

superseded by other PRs on radial and Cartesian reconstruction


Replace sanitize by clearState()

What does this PR do?
Replace sanitize function by clearState() delivered by Torch
What are the relevant issues?
#106
Questions:
@bamos
I tested it using nn4.small2 model
Sanitize: 170 Mb
clearState: 101 Mb
The model delivered by you have only 30 Mb. I get back to commit before adding 'cudnn.convert' and here model use only 30 Mb (Threre I tested clearState and produce the model with similar number of Mb).  So #108 add some bug at saving modules (neither Sanitize nor clearState clear all buffers). I want to start with the easiest part of new features, but now I have trouble in each of them....

Hi @melgor - interesting! Too bad these features weren't as easy as we thought. I wonder if there's an easy way to dump out the memory buffers that each module is using. Maybe by modifying Torch's File:writeObject? https://github.com/torch/torch7/blob/1cf98511b39a486f74aa4ecce02f8de422101a2d/File.lua#L107
-Brandon.

I found the reason of this situation. I just print
model:listModules()

and it gives me each modules with theirs buffers and matrix in it. This let me see what buffer are not empty.
'gradWeight','gradBias' - removing them from nn4.small2 reduce size by 13 MB. These buffers where mostly in BN and CONV layers
'_gradOutput' - removing it reduce size by next 73 Mb. These buffers where mostly in ReLU layers
So, final model have only ~15 Mb. You can test such sanitize if models still works ok by replacing in sanitize.lua
local common = {'output', 'gradInput'}

by
local common = {'output', 'gradInput','buffer','gradWeight','gradBias','_gradOutput'}

So, I think that this is problem related to Torch. This buffers should be at their "clearState" function.
But there is another problem:) ex.nn.ReLU and cudnn.ReLU will have different "clearState" implementation, so nn.ReLU:clearState() will not clear the buffers from cudnn version
So, @bamos Will we merge it now and wait until Torch dev will fix it or we will now just add some parameters to "sanitize" and stay with it (which may be better to get smaller models)?

@melgor one can't simply remove those gradWeight and gradBias buffers in clearState, as they are needed for training and are not reconstructed in the forward/backward passes. They enter in another category actually, as you usually call :getParameters before training, and that requires one to have the gradWeight/gradBias already initialized.
There are some alternatives, as writing a function like :unpack or here and calling the functions uppon loading from disk, but they don't yet handle shared gradients.
About the difference in the clearState from nn and cudnn, this is actually not a problem, as during the conversion the cudnn descriptors are cleared

@melgor - great to know :listModules prints the buffers, and that you were able to trim the size from 100mb to 15mb.
@fmassa - thanks for commenting on these with the helpful advice.
Let's use clearState for now without deleting the buffers needed in training. When I plan to release a new model I'll manually chop all of the training buffers for the default model since most people won't use it in training mode and I'll also release the full training model.


PMID:11231572 actin patches

decreased rate of actin cortical patch localization
related synonym yada movement

normal rate of actin cortical patch localization

undirected actin cortical patch movement
related synonym yada localization; no xp
def: ... in which actin cortical patches move within the cell cortex in a less directed manner than normal. The rate of movement may be normal.

decreased rate of actin cortical patch localization FYPO:0006176
undirected actin cortical patch movement FYPO:0006177
normal rate of actin cortical patch localization FYPO:0006178
edit file: 8aa8e2d9f153e0a57b0d4d62cdeebcfbe68024a7
release: 36712382f085093b31d1d1e73ad8414c05c15b7b


[BUG] System.UnauthorizedAccessException: Access to the path 'C:\Users\PC\Desktop\Bloxstraps\Bloxstrap\Roblox\Player\content\sounds\ouch.ogg' is denied.

Acknowledgement of preliminary instructions

[X] I have read the preliminary instructions, and I am certain that my problem has not already been addressed.
[X] I have thoroughly looked through the available Wiki articles and could not find a solution to my problem.
[X] I am using the latest version of Bloxstrap.
[ ] I did not answer truthfully to all the above checkboxes.

Bloxstrap Version
v2.8.1
What problem did you encounter?
they wont let me play
Bloxstrap Log
N/A

first clear your temp and %temp% then goto appdata and clear bloxstrap then open bloxstrap and set it up


No session data after updating to Appsignal Elixir 2.0

Appsignal.Plug is matching against true in the Plug.Conn.private.plug_session_fetch field:
https://github.com/appsignal/appsignal-elixir-plug/blob/main/lib/appsignal_plug.ex#L187
It should be matching against :done, as it does in Appsignal.Transaction.set_request_metadata/2:
https://github.com/appsignal/appsignal-elixir/blob/master/lib/appsignal/transaction.ex#L514
As :done is the value set by Plug: https://github.com/elixir-plug/plug/blob/master/lib/plug/session.ex#L85

Hey @mbuhot,
Thanks a lot for bringing this to our attention. You’re right, this should have been :done, there. I’ve just released version 2.0.3 which should resolve this issue. Could you upgrade :appsignal_plug in your project mix deps.update appsignal_plug, and let me know if it resolved this issue for you?


Error running phy

Hello,
I'm a brand new user (to Phy and Klusta both). I just installed Phy using the command:
conda install conda python=3 pip numpy matplotlib scipy h5py pyqt ipython-notebook requests && pip install vispy phy
Trying to run the software with $ phy cluster-manual /path/file.kwik, the data successfully loads, but then it seems like the GUI can't open. Here's the error I'm getting:
2015-05-28 13:27:28  dock:37                 PyQt is not available.
Traceback (most recent call last):
File "/Users/Evan/miniconda/bin/phy", line 9, in
load_entry_point('phy==0.1.0', 'console_scripts', 'phy')()
File "/Users/Evan/miniconda/lib/python3.4/site-packages/phy/scripts/phy_script.py", line 90, in main
run(kwik_path, interactive=interactive)
File "/Users/Evan/miniconda/lib/python3.4/site-packages/phy/scripts/phy_script.py", line 111, in run
gui = session.show_gui(show=False)
File "/Users/Evan/miniconda/lib/python3.4/site-packages/phy/cluster/manual/session.py", line 414, in show_gui
gui = self.gui_creator.add(config, **kwargs)
File "/Users/Evan/miniconda/lib/python3.4/site-packages/phy/cluster/manual/gui.py", line 403, in add
gui = ClusterManualGUI(self.session, config=config)
File "/Users/Evan/miniconda/lib/python3.4/site-packages/phy/cluster/manual/gui.py", line 37, in init
self._dock = DockWindow(title=self.title)
File "/Users/Evan/miniconda/lib/python3.4/site-packages/phy/utils/dock.py", line 211, in init
self.setWindowTitle(title)
AttributeError: 'DockWindow' object has no attribute 'setWindowTitle'
Trying to go through the getting started tutorial, I run into a similar issue running the command phy.enable_qt(), getting
2015-05-28 13:30:27  dock:37                 PyQt is not available.
I've made sure PyQt is installed, but I'm not experienced using Python, so I'm not really sure what other mistakes I could be making. I'm running on Mac OSX 10.9. Thanks for any help!

Hi,
can you try to launch ipython in a terminal and then:
import PyQt4
import PyQt4.QtGUI

do you get any error message by doing that?
@nippoo can you try phy on your mac?

Yes, here's the error. Maybe something is going wrong with the install?
In [1]: import PyQt4
In [2]: import PyQt4.QtGui
ImportError                               Traceback (most recent call last)
 in ()
----> 1 import PyQt4.QtGui
ImportError: dlopen(/Users/Evan/miniconda/lib/python3.4/site-packages/PyQt4/QtGui.so, 2): Library not loaded: @rpath/libpng15.15.dylib
Referenced from: /Users/Evan/miniconda/lib/libQtGui.4.8.6.dylib
Reason: image not found

it looks like this bug: https://twitter.com/astrofrog/status/604039591939698688

Ah, makes sense. Thanks! I'll try to watch to see when it gets fixed.

can you try to execute conda install libpng=1.5 in your terminal and try again

That worked, thanks!

great!

This has now been fixed by the conda guys.


9/5 offline meet-up #1

Last night we studied MST, mobx, and React.
As a result, we created 'AppStore'. It consists of 'spinning, alert, load' and can be used at any time in the subcomponent.


Adding new REST endpoints

Basically rest-update endpoint with #259 on top based on develop, as discussed by @keppel.

Looks good to me, thank you for contributing! This will get rolled into an upcoming release.

Awesome, thanks! I am gonna do a few more queries later on, stay tuned lol.


When placeholderData is set, initial status is success

Describe the bug
When placeholderData is set, initial status is success
To Reproduce
Example: https://codesandbox.io/s/react-query-placeholder-data-h7hz4?file=/src/App.js
Expected behavior
From documentation is not clear if this is expected behavior. I understand the initial status success using initialData because is persisted in the cache, but if I have partial data to show I still need to know if the rest of it is loading
Smartphone (please complete the following information):
any platform
Additional context
I'm starting to migrate an app from redux-saga to react-query and is really wonderful
Thanks

This is by design. If you need to use placeholder data while the query is loading, simply default your data variable to whatever you want:
const query = useQuery(...)
const data = query.data ?? defaultData

This is by design. If you need to use placeholder data while the query is loading, simply default your data variable to whatever you want:
const query = useQuery(...)
const data = query.data ?? defaultData

Also, you can still know if the query is fetching by using the query.isFetching property.

Also, you can still know if the query is fetching by using the query.isFetching property.

@eedv here is an example if you (or anyone else that comes acress this problem) is using useQuery with destructuring and needs a default value:
     const {
       isLoading: chartLoading,
       error: chartError,
       data: chart = []       //chart will be an empty array until the request returns a result
     } = useQuery('barchart', api.barchart);

so if network request fails, will we still get placeholder/initialData in data?

so if network request fails, will we still get placeholder/initialData in data?

here is an extensive read about placeholderData, initialData and the differences between them:
https://tkdodo.eu/blog/placeholder-and-initial-data-in-react-query

Thanks @TkDodo, I actually came across your blog but looked at Error Handling
My issue was/is that my initialData was coming from an async fn, so the initial request gets undefined for initialData and thus when it fails, it fails with undefined for data.
i don't want to do {...result, data: result.data ?? initDataFromAsync } but it seems the only way :\

setting the queryKey shouldn't be needed. here is an example of async initialData done with dependent queries:

https://github.com/tannerlinsley/react-query/discussions/1288#discussioncomment-129114

Thanks @TkDodo
Just FYI, setting queryKey seems to be needed here. Even in dependent queries example the 1st query is causing a change in the queryKey of the subsequent one. (once the 1st is resolved, its result (userId) is used in the queryKey of the 2nd query)

This is by design. If you need to use placeholder data while the query is loading, simply default your data variable to whatever you want:
const query = useQuery(...)
const data = query.data ?? defaultData

I might be in the minority, but this is super counterintuitive to me. It seems that there's a general confusion around how this works and the expectation that provided the placeholderData, the query should start with a loading state. To me, placeholder data should semantically work exactly as the example above. It's even more confusing in Typescript where providing the initialData removes the loading option from the status field but the placeholderData doesn't.
I agree that if the initialData is provided, the query should be successful from the get go. That's what I would use if I have the initial data at page load time and I can hydrate the page immediately without waiting. However, intuitively, placeholder data is typically only used to eliminate the need to add a lot of if conditions to account for nulls and undefineds. It feels right to use loading as the initial state for this case.

and the expectation that provided the placeholderData, the query should start with a loading state.

loading state is used to describe and discriminate the data property. When you are in loading state, you cannot, per definition, have data. It is defined as:
status: 'loading',
data: undefined,
error: null

success state merely means that we have data. That is why you are in success state when you provide placeholderData.

I'd argue that if queries with placeholderData started with a loading state, the user can still decide whether they display the loading state based on the loading status or the fetching status, or no?

You can still do that by checking for the isPlaceholderData flag returned from useQuery.

placeholderData currently feel a little redundant and I don't have a good understanding of when it's useful.

I've written about the differences (and similarities) to initialData here: https://tkdodo.eu/blog/placeholder-and-initial-data-in-react-query

You can still do that by checking for the isPlaceholderData flag returned from useQuery.

I didn't know that. Thank you. I guess we could use this flag instead or in addition to the loading flag to display content placeholders. I wonder if this should be mentioned in the description of placeholderData flag.

Good idea, do you want to contribute that?

the docs say:

If set, this value will be used as the placeholder data for this particular query observer while the query is still in the loading data and no initialData has been provided.

The query is in loading state but your observer goes to success state because it shows placeholder data


response-body not showing when error encountered

If the endpoint returns an error status (like 500) then no response body is shown. If I manually hit the endpoint with the same data, I get an expected error message describing the problem with the payload.
The expectation here is that if there is response data and verbose is on, then I should see the response data even if the server returned a non-200 code.
(note: originally this issue was about it not showing in general. What was actually happening is that this other issue was making it seem like there was a general problem)

Will see if I can take a look at this today

Busy debugging a small issue with the required change, which I can hopefully resolve soon

You are welcome to test this now, v3.0.5 released


Using bootstrap 4 mixins with angular2

Hi,
don't know if its the right place to ask here but I'm
trying to get this repo work with bootstrap 4 mixins.
I followed the wiki bootstrap 4 guide and everything
looks good.
But if I have an component for instance
home.component.ts
@Component({
  selector: 'home',
  styleUrls: ['./home.style.scss'],
  templateUrl: './home.template.html'
})

and home.style.scss
@include media-breakpoint-up(md) {     .dosomething {          padding: 0px;     } }
I get 'No mixin named media-breakpoint-up'.
If i add the following line to home.style.scss
it works. But I don't know it it's the right thing todo.
@import "./node_modules/bootstrap/scss/_variables.scss";
@import "./node_modules/bootstrap/scss/mixins/_breakpoints.scss";

So is it possible to inject _breakpoints.scss (mixins) and _variables.scss
global or if its needed? Shouldn't webpack handle this case?
Regards

I got this to work by importing @import "../../../node_modules/bootstrap/scss/bootstrap-grid.scss"; instead of the breakpoints directly. The Bootstrap-Grid file does include the breakpoints along with other pieces.

@jshamley True. Thank you. bootstrap-grid.scss looks better. But you need still manually import the scss files right? Where do you import the scss - in every component where you need the mixins or globally (maybe in app.styles?)
Regards

@regenrek I have been importing them per component SCSS file. I have only needed those mixins a couple times so far so I didn't take the time to import globally.

A bit off topic: but you can use all the import Sass files with module syntax by prefixing it with ~ import "~boostrap/scss/bootstrap-grid.scss.

@katallaxie That would be great but I'll get
Cannot find module "~bootstrap/scss/bootstrap-grid.scss"

@regenrek check the path, this was just an example.
https://github.com/jtangelder/sass-loader#imports

@katallaxie yes. tried to include it in the home.component.ts. Works so far.
home.style.scss
@import "~bootstrap/scss/bootstrap-grid.scss";

@regenrek have you seen https://ng-bootstrap.github.io/ ? It uses the latest RC.6 and it possible just to import one like any other new ngModules
ps: IMO ng-bootstrap is the subject for some new webpack-starter branch of this repo ?

+1 for ng-bootstrap branch

I think should be sufficient to have this in README. @regenrek could you do that and do a PR?

⚠⚠⚠
@import "../../../node_modules/bootstrap/scss/bootstrap-grid.scss"; is not a good solution! This is causing Bootstrap's grid CSS to be regenerated every place you use this import. You only want the mixins, which by themselves don't add to any generated CSS output. Here is the best solution.


Adapt jsonapi generation for fueling api

Adapt api generation
Flatten api response structure

@patrickniepel This should be ready?

@EmDee It's ready

This could win an award for pyramid of doom.


BinaryHeap bug

I think the com.badlogic.gdx.utils.BinaryHeap.remove() method has bug.
I am sorry i have no time to write a test class, but I list the actions below, look at the last line:
version:1.9.10
add 44.683983
pop 44.683983
add 160.47682
add 95.038086
add 396.49918
add 835.0006
add 439.67096
add 377.55692
add 373.29028
pop 95.038086
add 926.524
pop 160.47682
add 189.30789
remove 926.524
add 924.88995
add 700.856
add 342.5846
add 313.3819
pop 189.30789
add 407.9829
add 1482.5394
add 1135.7894
add 362.44937
pop 313.3819
add 725.86615
add 1656.2006
add 490.8201
pop 342.5846
remove 725.86615
add 723.18396
add 716.36115
remove 490.8201
add 474.9852
add 379.61304
pop 362.44937
add 465.81775
add 440.83838
add 1690.9901
add 1711.5605
add 1795.7483
add 388.60376
add 2119.6921
pop 373.29028
add 1040.5143
add 1018.3097
add 1039.8417
add 1142.326
add 1045.692
add 820.3383
remove 474.9852
add 430.27383
add 506.89728
pop 377.55692
add 973.9379
remove 723.18396
add 619.83624
remove 1656.2006
add 1547.9089
pop 379.61304
remove 1018.3097
add 930.3666
remove 1039.8417
add 950.749
remove 1142.326
add 1055.636
remove 1045.692
add 958.5852
remove 820.3383
add 771.37115
remove 506.89728
add 417.02042
pop 388.60376
remove 930.3666
add 864.04517
remove 950.749
add 879.2704
remove 958.5852
add 894.9335
add 1534.2864
pop 396.49918
remove 619.83624
add 548.92786
remove 924.88995
add 905.3478
pop 407.9829
remove 440.83838
add 436.48087
pop 417.02042
remove 1040.5143
add 950.6953
add 992.51624
add 808.5153
pop 430.27383
add 876.47845
add 472.963
pop 436.48087
remove 465.81775
add 461.85135
add 1552.4479
pop 439.67096
pop 461.85135
remove 950.6953
add 862.6192
remove 992.51624
add 900.9059
remove 808.5153
add 716.3565
remove 876.47845
add 610.04565
add 598.95935
add 487.93192
remove 864.04517
add 852.66907
remove 879.2704
add 867.3523
remove 894.9335
add 884.0505
pop 472.963
pop 487.93192
add 548.7671
pop 548.7671
add 1437.1154
add 1934.038
add 2401.7002
pop 548.92786
remove 973.9379
add 903.2409
remove 1547.9089
add 1481.2589
pop 598.95935
add 1430.7216
pop 700.856 ---------------------- the correct value is 610.04565

Confirmed in a test and via step debugging. Code for a test is here; it will need some extra code to be runnable with just libGDX. The only method it needs, I think, is Maker.makeHM(K, V, Object...), in squidlib-util's squidpony package; I could copy it into the test if anyone wants.

It's possible that this change set is all that's needed to fix this: https://github.com/SquidPony/SquidLib/commit/6eb882f62ba5f092837bf4ae40957c7f743cd054 . I hope there's a way to run the added code conditionally, but I don't really understand heaps that well.
What my code does is run part of up() near the end of down(), because in the current libGDX code, methods like remove() swap the last node with the removed node even if the new position for the last node isn't valid by the heap property. Filtering up as well as down ensures it's in the right place, but can probably be optimized.

Thank you, tommey!
I found this when I use the IndexedAStarPathFinder class in gdx AI, some times it gots a wrong path.
I fix the finder up with use setValue() instead of remove() and add() to update heap node.

Good find @windmeup! I use BinaryHeap in a few projects, but I only remove the root.
Thanks for the test @tommyettinger! I gdxified it and put it in CollectionsTest.
remove was using the logic for removing the root (first) node. When removing any other node, we need to fix up the heap using up or down based on the values.

Hooray, it is fixed!


Add grouping function

First, thank you for this great module.
It miss only a group function. Is there a way to do this?

Aka the joinGroup and leaveGroup methods from node-sonos

Can you please give an example how to use this functions?

joinGroup and leaveGroup do not appear to be implemented in node-red-contrib-better-sonos, though they are implemented in node-sonos

latest version of this node has been updated with join & leave commands.
Please refer to the node info for documentation


[Automation] - Updating the Jenkins job to support recurrent execution.

Summary
Improvements to the initial Jenkins UI tests execution. https://github.com/rancher/dashboard/pull/9432
README added.
Technical notes summary
This enables the code logic to be self sufficient to deploy a Rancher instance and execute the tests on it.
The PR depends on the Corral Package changes that builds the environment and execute the tests.
https://github.com/rancherlabs/corral-packages/pull/19
More information in the readme.
The latest supported versions in Cypress can be found here.

@bmdepesa / @yonasberhe23 let me know if there's any objections / comments, otherwise will merge tomorrow (uk) morning


Review GitHub readme

Random thoughts:

Potentially update the screenshot to use the new colors?
Include screenshot and "Launch Encompass" in their own section instead of lumping them into "Introduction"?

I did these things.

so is this ticket good to go then?

I can't really say. I think the README is in an okay place.
Closing but feel free to re-open @ericboucher if there are more changes that need to be made.

Sgtm
Eric Boucher

On May 9, 2018, at 14:06, Brian Lewis<EMAIL_ADDRESS>wrote:
Closed #745.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.


Change all instances of "colour" to "color"

Kills me but might make things easier seeing as the spec uses the American spelling?
color: $colour-text;

Yay! :us: But seriously I think matching the spec is better.

I agree. Still annoys me that the spec went with American spelling :stuck_out_tongue: but such is life.

Addressed in #74.


Generating Manifest V2 extension by default

Google search terms

Describe the bug
My initial trial of this boilerplate generated a manifest v2 extension.   These are now effectively obsolete.   Reading the more extensive extend-chrome docs, I think it supports manifest v3; anyone trying to build their first extension will be confused by this boilerplate.
How do we reproduce?
npx create-react-crx
cd # to project sub-dir
npm install
npm run dev

Expected behavior
An installable extension with minimal function
Actual behavior
The generated extension won't install due to the v3 manifest in the ./dist folder.
Screenshots

Please complete the following information:

Library Version<EMAIL_ADDRESS>Operating System: Windows 11
Browser: Brave 1.42.86 Chromium 104.0.5112.81 (Official Build) (64-bit)
Node Version: V18.5.0

@jacksteamdev :  Thanks for your work on this, are you maintaining this repo, or is there some better boilerplate you can point me to?
I'd be happy to contribute some PRs if you want to keep updating this.

@BurtHarris Thanks for your kind messages. I've mostly moved on to developing CRXJS, a Vite plugin with all the features of this boilerplate, but adds true HMR. You can check it out at https://dev.to/jacksteamdev/create-a-vite-react-chrome-extension-in-90-seconds-3df7

I'd happily merge some PRs if you'd like to contribute here!


HLM-638 | Changes in verify certificate for revocation

@prasanna-egov @saiprakash-v @varadeth
SearchCertificate doesn't need Authorisation token

Change to main branch.

Please resolve conflicts

Resolve conflicts please. This is urgent.


Distribute with pypi?

Is this package available in pyi? I tried pip install elasticsearch-dsl-py, but no luck.

The package is called elasticsearch-dsl:
pip install elasticsearch-dsl

https://pypi.python.org/pypi/elasticsearch-dsl

Yes, as Will said. The version installable from PYPI is not 100% up to date, I will do another release soon once we hammer out the details regarding #58 and attribute access to fields in _meta.


Commutation pass

Summary
A commutation analysis and a commutation transformation pass are implemented.
Details and comments
The commutation analysis pass creates property_set["commutation_set"] for each DAG, property_set["commutation_set"] is a dictionary mapping each operation to a set of nearby operations that commutes with it.
The commutation transformation pass transforms the current DAG to a DAG that includes the commutation relations found by the commutation analysis pass, but unfriendly to simple scheduling.
The attached DAG visualization illustrates an example:

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Can you please add a test to test/python/transpiler/commutation-pass.py?
Can you please update to use the new DAG.

@godott as discussed let's close this and open a new PR that only adds the files related to the commutation pass, contains tests, and uses the new object-based DAG.


[CI] Freeze array-api-test

Description
Fix unix-cpu test
Checklist
Essentials

[ ] PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
[ ] Changes are complete (i.e. I finished coding on this PR)
[ ] All changes have test coverage
[ ] Code is well-documented

Changes

[ ] Feature1, tests, (and when applicable, API doc)
[ ] Feature2, tests, (and when applicable, API doc)

Comments

If this change is a backward incompatible change, why must this change be made.
Interesting edge cases to note here

@mxnet-bot run ci [miscellaneous, website]


make docker-run fails

Trying to preview changes to documentation I used  make docker-run and came across two issues :

had to manually install sass
footer.css is missing

$ make docker-build
sass src/static/css/base.sass src/static/css/base.css
Error: Can't find stylesheet to import.
@import footer.css
        ^^^^^^^^^^
  src/static/css/base.sass 2:9  root stylesheet
make: *** [build-css] Error 65

+1 regarding SASS install. This should be in docker.
The README is also a bit off. To start a preview, do
make && make docker-run

That should bring up localhost:8080.

Regarding SASS, I guess this would solve it:
Have our Dockerfile make a two-step build. Step 1 would use a heavy image to build SASS (requires ruby), pull in the external repos (requires git), generate the site (requires hugo). Step 2 would only take the output of step 1 into a even more lightweight nginx-based image.

make && make docker-run produce the exact same error.
The src/static/css/footer.css file is there but somehow sass does not find it.
base.sass looks correct to me
$ head src/static/css/base.sass
@import icomoon
@import footer.css

Not sure what we are missing here.

Status info: I already looked into this a while back, but couldn't find a working SASS binary yet. The way it's described on the SASS website (https://sass-lang.com/install) the dart version is the standalone one that should work, however it didn't work for me in Docker.


[#2164]optimization client build path #2170

at client, valid contextPath if need, and change build path user Paths. Done #2164

Make sure that:

[x] You have read the contribution guidelines.
[x] You submit test cases (unit or integration tests) that back your changes.
[x] Your local test passed mvn clean install -Dmaven.javadoc.skip=true.

Codecov Report

Merging #2172 (414f318) into master (c69d8d8) will decrease coverage by 0.01%.
The diff coverage is 13.33%.

@@             Coverage Diff              @@
##             master    #2172      +/-   ##
============================================
- Coverage     60.47%   60.45%   -0.02%
- Complexity     4066     4068       +2
============================================
  Files           607      607
  Lines         18096    18097       +1
  Branches       1734     1734
============================================
- Hits          10943    10940       -3
+ Misses         6268     6265       -3
- Partials        885      892       +7

Impacted Files
Coverage Δ

...alibaba/dubbo/AlibabaDubboServiceBeanListener.java
0.00% <0.00%> (ø)

...t/apache/dubbo/ApacheDubboServiceBeanListener.java
0.00% <0.00%> (ø)

...ient/springcloud/init/ContextRegisterListener.java
22.50% <0.00%> (+0.54%)
:arrow_up:

...cloud/init/SpringCloudClientBeanPostProcessor.java
73.01% <25.00%> (-2.40%)
:arrow_down:

...enyu/client/tars/TarsServiceBeanPostProcessor.java
55.88% <33.33%> (ø)

...yu/sync/data/http/refresh/AbstractDataRefresh.java
72.41% <0.00%> (-13.80%)
:arrow_down:

...che/shenyu/sync/data/http/HttpSyncDataService.java
81.55% <0.00%> (-7.77%)
:arrow_down:

...shenyu/sync/data/consul/ConsulSyncDataService.java
66.10% <0.00%> (-3.39%)
:arrow_down:

...shenyu/web/controller/LocalMetadataController.java
73.33% <0.00%> (+73.33%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c69d8d8...414f318. Read the comment docs.


fix(gitlab): modify notes and comments

Summary
modify gitlab notes and comments
Does this close any open issues?
close #1475
Current Behavior
Describe the current behaviour of this issue, if relevant.
New Behavior
Describe the new behaviour updated in this issue, if relevant.
Screenshots

Other Information
Any other information that is important to this PR.

LGTM


numba_dpex not stable with numba==0.56.4

While trying to bump numba to 0.56.4 after bumping numba_dpex to 0.19.0 leads to some bugs: compilation errors and wrong numerical outputs.
At https://github.com/soda-inria/sklearn-numba-dpex all tests pass with numba<0.56 but a some fail with ==0.56.4.
this test fails with a compilation error.
E                   numba.core.errors.TypingError: Failed in dpex_nopython mode pipeline (step: nopython frontend)
E                   No implementation of function Function(<numba_dpex.compiler.DpexFunctionTemplate object at 0x7f775ad61ca0>) found for signature:
E
E                    >>> <unknown function>(array(uint64, 2d, C), Literal[int](0))
E
E                   There are 2 candidate implementations:
E                     - Of which 2 did not match due to:
E                     Overload in function 'compile_func_template.<locals>._function_template.generic': File: numba_dpex/compiler.py: Line 292.
E                       With argument(s): '(array(uint64, 2d, C), int64)':
E                      Rejected as the implementation raised a specific error:
E                        KeyError: "Failed in dpex_nopython mode pipeline (step: Custom Lowerer with auto-offload support)\n<class 'numba_dpex.core.types.array_type.Array'>"
E                     raised from /opt/venv/lib/python3.9/site-packages/numba/core/datamodel/manager.py:29
E
E                   During: resolving callee type: Function(<numba_dpex.compiler.DpexFunctionTemplate object at 0x7f775ad61ca0>)
E                   During: typing of call at /sklearn-numba-dpex/sklearn_numba_dpex/common/tests/test_random.py (217)
E
E
E                   File "sklearn_numba_dpex/common/tests/test_random.py", line 217:
E                       def _rand_uniform_kernel(
E                           <source elided>
E                                   return
E                               out[out_idx] = rand_uniform_kernel_func(private_states, 0)
E                               ^

The function for which the implementation can't be found is a dpex.func defined in another module, defined as a closure, and the input is a dpex.private.array. The kernel itself is also defined as a closure.
It seems the test pass if one of those two things change:

define everything in the same module rather than importing the kernel func from another module

or change the dpex.private.array to a normal array in global memory

But there must be something more specific to this example since I can't get a minimal reproducer yet. Will update if a minimal reproducer is found.

I've opened a separate issue with the minimal reproducer at https://github.com/IntelPython/numba-dpex/issues/867


No ChannelOption.SO_REUSEPORT

Expected behavior
Have option Channel.SO_REUSEPORT
SO_REUSEPORT can be better understood here:
https://lwn.net/Articles/542629/
I want to enable this option to be able to re-use the same port over and over again (because of stress tests - running the test over and over again, the test creates server, and so I encountered this issue).
Actual behavior
Do not have this options
Steps to reproduce
    serverBootstrap
        .group(bossGroup, workerGroup)
        .channel(NioServerSocketChannel.class)
        .option(EpollChannelOption.SO_REUSEPORT)
        .handler(new LoggingHandler(LogLevel.INFO))
        .childHandler(channelHandler);

Notice that we have EpollChannelOption and not ChannelOption.
Minimal yet complete reproducer code (or URL to code)
Netty version
4.1.79
JVM version (e.g. java -version)
OS version (e.g. uname -a)

It's in UnixChannelOption, yeah.


start of plotting "help" module

[x] clean up codes
[x] wraps the import to matplotlib and cartopy to include an Optional dependencies warning
[x] validate that a projection is passed if using a geoaxes
[x] add docstring
[x] create examples
[ ] tests ?

As of right now, the goals are:

implement #200
create a function to return a LineCollection to avoid using apply_ragged() with matplotlib functions (to fix #227).

Great start! maybe call the module plothelp or helper instead of help which is a bit too general?
Maybe the two goals could be combined? i.e. the function that returns the LineCollection returns extra lines when crossing the dateline to accommodate? How do we make sure that the assigned colors of the lines for the drifters that cross the dateline are the same?

What do you think about utility? For the function that inserts NaN at dateline, I suggest making a function that inserts NaNs between segments, and let the user segment the dateline. That could fit in the analysis module. I don't quite see the need for a separate module here. I know @selipot suggested it and I didn't say anything, but I don't see it as compelling.

and let the user segment the dateline

We can then have a separate function that segments the dateline specifically, so the desired functionality here would be by chaining the two functions.

I have no preference about the name of the module and/or the locations of those functions.
I was going to make the first function to insert nan general enough to deal with any periodic domain, expanding on this:
nan_indices = np.cumsum(cd.analysis.segment(lon, 180, rowsize=cd.analysis.segment(lon, -180)))[:-1]

I can switch it to utility.py for now and we see where we put the functions once ready.

Not sure exactly how to proceed now. segment only supports 1-d array... 😭

@selipot want to test? I guess I might have some time next week during Thanksgiving to play with this.

I'm abandoning the idea of rebasing this branch. Many files have been renamed, deleted and functions moved around, making this very annoying. I might just reopened another PR once we are closer to merging this.

I'm abandoning the idea of rebasing this branch. Many files have been renamed, deleted and functions moved around, making this very annoying. I might just reopen another PR once we are closer to merging this.

Sorry about that, that happens when a PR is open for too long for a version 0.x software I guess. Do you want me to test before you open another PR or after?

No worries, the easiest would be just to copy the function.

One question, how can I test something that requires optional dependencies... 🤔 I guess we would need to have a different environment for the test, which would include all the mandatory and optional packages.

How about installing all dependencies (core and optional) for testing?

Testing your function. I think there is an issue with your first test lines 132-150. It raises a valueError if ax is a simple plt.Axes which it should as it is written. As an example this does not work:
fig = plt.figure()
ax = fig.add_subplot(1, 1, 1)
plot_ragged(ax, ds.lon, ds.lat, ds.rowsize, colors=np.arange(len(ds.rowsize)));

The examples need editing which I can do once you submit a new PR.

Did you try the latest version? You can use this branch, I fix it yesterday.

I copied the code for the function from the PR branch as you instructed. Again, lines 132-150 don't make sense to me or rather the error I get makes sense. Why would you test for ax to have the attribute coastline if it is only plt.Axes?
if isinstance(ax, plt.Axes) and hasattr(
         ax, "coastlines"
     )
...

If it has attributes coastline, it is a geoAxe and we have to also try to load cartopy. I'm on the plane now. But it was working for me yesterday. I will check again in ~2h.

What's next with this @philippemiron ?

Did you have chance to give it a try?

Yes! Works for me. But did not test with cartopy.

Ok, it was working fine with me. I will generate some tests later today. I think I should be able to test that it is wokring without cartopy and returning proper exception without matplotlib.

I forgot one important thing: we should add a note to the installation instructions (in README.md and docs/install.rst) about installing optional dependencies.

I think we discussed and established that matplotlib-core is already implicitly installed by depending on xarray, correct? In that case, I think only cartopy should be an optional dependency.

If I installed the environment I don't get matplotlib.

I think we discussed and established that matplotlib-core is already implicitly installed by depending on xarray, correct? In that case, I think only cartopy should be an optional dependency.

do we really need this? If someone tries to import the module it already say:
raise ImportError("missing optional dependency 'matplotlib'")

@selipot please check on your end if all good, and merge when ready.


Overhaul all metrics

Fix names to comply with the official guidelines and to better mirror the names of similar timeseries from the much-more-popular cAdvisor, when reasonable. And don't use the word "svc" to refer to tasks, as it is just not correct.
Improve helps.
Stop reporting per-CPU usage metrics. They're empirically only available in Fargate, but the current collector implementation assumes they're available everywhere. (They were previously available in EC2 but that stopped being the case when ecs-agent was upgraded to use cgroups v2.)  Given that it's not clear why per-CPU numbers are useful in general, remove them everywhere instead of exposing disjoint metrics for Fargate and EC2. This will also prevent Fargate from potentially spontaneously breaking in the same way EC2 did.
Fix task-level memory limit to actually be in bytes (it previously said "bytes" but was in fact MiB).
Correctly report container-level memory limits in all cases - the stats limit is nonsense if, as in Fargate, there is no container-level limit configured in the task definition. While the right data for all cases is hiding in the stats response somewhere, I have instead opted to cut out the stats middleman and use the task metadata directly to drive this metric. I think it's substantially less likely that ECS fails to effect the configured limits upon cgroups correctly than it is that we fail to interrogate cgroups output correctly: the latter empirically happens with some frequency :^).
Add metrics concerning Fargate ephemeral storage and task image pull timestamps.
Remove the task_arn label on task-level metrics, as it does not distinctly identify anything within the instance - the instance is the task! Users needing the task ARN in their timeseries labels may do so by joining to ecs_task_metadata_info.

I have tested these changes both in Fargate and EC2 and they look correct to me.
Closes #70 (by way of obsoleting it).
Closes #74.
Closes #69.
Closes #35.
Closes #16 (as far as I can tell).

Thanks for reviewing.  We will begin relying on this exporter heavily within the next few months.  So if anything ends up being off or incomplete with this overhaul, I will be following up.
If not, this exporter might be close to being feature complete, and we could consider cutting 1.0 after some time.


Demo scene is missing files

Having a blast baking models already, what a great project!
When trying to open res://demo/ForestTest.tscn the following warning is displayed:
 Can't open file from path 'res://ImpostorShader.shader'.
 Failed to get modified time for: res://ImpostorShader.shader.

Also a minor nitpick would be that the demo's images are very big.
I had to switch to my desktop because my laptop crashed when importing them.
Can't wait to contribute to this!
Also: You have to add this to Godot's asset library!

Demo files should be fixed. The images in the demos folder are 4k in size. Godot should not have a problem loading such files, but I can be wrong. If more people report a problem, I will change Textures to TextureArrays.


Add a Code of Conduct

Since many folks might take this repository to teach about open source, it would be great to add a template code of conduct that they can use at their event/communities. There's a guide we can use to add a Code of Conduct.
Additionally, folks will have to add their contact information to the Code of Conduct so people can report any incidents.

I've added a code of conduct for contributing to this repo using a CODE_OF_CONDUCT.md file.
We also mention the code of conduct in the details of the flow of the day, with links to a range of code of conducts including the Microsoft event one, and the GitHub event one. Any ways we can improve this?

Most students will not go deep into the Code of Conduct selection. What we could do is create a pre-workshop section so they know what they need to prepare before the event and add a note for the students that they need to add their contact details on the CoC and then add a note that they can review other code of conducts if they feel the current one doesn't meet their needs.


Error Creating OpenSSL DSA Keys

Describe the bug
I am unsure why but I can't create a DSA key using the following code:
$res = \openssl_pkey_new([
                'digest_alg' => 'sha512',
                'private_key_bits' => 2048,
                'private_key_type' => OPENSSL_KEYTYPE_DSA,
            ]);
            // Get private key
            \openssl_pkey_export($res, $keyContent, 'mystrongpassword');

This code works fine for PHP 8.1 and 8.2 but fails in 7.4 and 8.0. The call to openssl_pkey_new() returns false. I have been able to generate such a key locally on PHP 7.4 and 8.0 in other environments so suspect this might be something to do with the openssl.cnf on the runners although this is purely a guess.
Version

[ ] I have checked releases, and the bug exists in the latest patch version of v1 or v2.
[x] v2
[ ] v1

Runners

[x] GitHub Hosted
[ ] Self Hosted

Operating systems
Ubuntu-latest
PHP versions
7.4, 8.0, 8.1, 8.2
To Reproduce
I create a basic test repo to show the issue
Expected behavior
The call to openssl_pkey_new should return an OpenSSLAsymetricKey
Screenshots/Logs
Detailed in the test repo
Additional context
N/A
Are you willing to submit a PR?
I'm unsure of the root cause so wouldn't be able to at this time

If you are running this on the ubuntu-latest or ubuntu-22.04 runner, that has OpenSSL 3 and support for it was added to PHP in 8.1. Please use ubuntu-20.04 runner with the older PHP versions and this should work.


[Bug] Video rendering stops prematurely on a hour long video

I have a hour long video of a pink screen
here's the log file
vhs_last_debug_log.log

Hi
Maaybe it's not a bug
The fact is that the metadata field in the video container, from which the final number for the counter is taken, is inaccurate according to the specification.
When processing takes place, the increment counter is used and the actual number of frames in the file is actually counted.
Therefore, the file may end up to the end correctly
But the counter due to this feature can be in the state of 98/100 or 102/100 for example
When the rendering stopped on your video, did the output file form correctly?
Or is it just stuck on [GUI STATUS] Progress: 60626/90000 and not doing anything else?


Switch to new registry system (RegistryEvent)

…instead of using the old GameRegistry.register. At this point, it's the best way to register blocks, items, and the like.

985b7537d0dd913fd9d23a56d045a540cd7db943


Add files to the package

I need to add a file from the project in the RPM
In the %install section of the generated spec file I want to add the two lines below
mkdir -p ${RPM_BUILD_ROOT}/etc/myproject
install -m 755 somefile.toml ${RPM_BUILD_ROOT}/etc/myproject/somefile.toml
question is how to get somefile.toml into the rpm SOURCES used for building the rpm?

I found that I can copy files to the .rpm folder - case can be closed


如何修改鼠标移入辅助线上点的样式，使其和point的shape一致

The issue which is not created via https://antv-issue-helper.surge.sh will be closed immediately.

注意：不是用 https://antv-issue-helper.surge.sh 创建的 issue 会被立即关闭。

area-line-stack.html

已解决，感谢


VLAZ: Watch kelvinconsult-property.com

VLAZ requests the watch of the watch_keyword kelvinconsult-property\.com. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

kelvinconsult-property\.com has been seen in 1 true positive, 0 false positives, and 0 NAAs.

Approved by Jeff Schaller in Charcoal HQ


i cant edit config

when i try to add new configuration options into config.json the bot doesnt start, what is wrong?

You put a slash before the command.
On Sat, Aug 17, 2019 at 3:19 AM jonathan123700<EMAIL_ADDRESS>wrote:

when i try to add configuration options into config.json the bot doesnt
start, what is wrong?
[image: test123]
https://user-images.githubusercontent.com/54201120/63208054-80547b80-c0d8-11e9-9f8c-8d58db4a22a4.PNG
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/Dragory/modmailbot/issues/339?email_source=notifications&email_token=AEVVC25VW4WBHXKKGRHA4Z3QE6RBPA5CNFSM4IMOSKMKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HFYSI7A,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AEVVC2YXIVUZWWUBPH3FXQ3QE6RBPANCNFSM4IMOSKMA
.

in the command prompot?

The error tells you what's wrong: there is an invalid character (in this case a forward slash) in one of the lines of the config file. Fix the errors you made in the file.
v / r
Robert Klebes
Mobile:<PHONE_NUMBER>
https://keybase.io/sporkwitch
https://www.linkedin.com/in/klebes
On August 17, 2019 10:14:24 AM EDT, jonathan123700<EMAIL_ADDRESS>wrote:

in the command prompot?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/Dragory/modmailbot/issues/339#issuecomment-522240933

oh i solved it, but how to disable the bot?

Your should also probably reset your token


Organize distributions module; fix make docs

This moves remaining Pyro distributions from distributions.torch.* to distributions.*, and makes pyro.distributions.torch a single-file module rather. This is just cleanup after our migration to PyTorch distributions, and makes our distributions file locations more consistent.
This PR also fixes make docs to work locally. I've locally run make docs to ensure the reorganized documentation is still generated correctly. The fix is to guard our readthedocs hacks by if 'READTHECOCS' in os.environ: ... which should only be run on readthedocs servers.

isnt make docs run in travis?

you're right, and I don't know why it's failing locally for me yet passing on travis. Anyway this PR should speed up make docs everywhere except readthedocs.


JSCS hangs when running against a folder on Windows

2.2.1

---
Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/27166777-jscs-hangs-when-running-against-a-folder-on-windows?utm_campaign=plugin&utm_content=tracker%2F281640&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F281640&utm_medium=issues&utm_source=github).

@zxqfox i remember you were using windows (?), could you check this out?

@irengrig I need some additional info. Can't repeat with jscs --preset .\path (it works as expected). What hangs you see?

Friendly ping

I'm really sorry, but now it just works ok. Checked with several projects.
Seems to have been some local problem.

Ok great - thanks for the report anyway!


Ignite-2.5.1-p141-pme

PR seems to be temporary for testing, closing it, for now, feel free to reopen if it is needed.


Bot bug: bot is stuck in a dead loop when adding or removing label: no receive activity

In this pr https://github.com/Azure/azure-rest-api-specs/pull/27220, two bots are stuck in a dead loop when adding or removing label: no receive activity

This was a transient issue due to FabricBot backend misbehavior.  The long term solution is likely to eliminate our dependency on FabricBot.


[BUG] Blank screen when selecting Toolkit Reports

Describe the bug
There was a ynab update today. https://www.youneedabudget.com/release-notes/ After updating, the toolkit reports screen no longer loads. Seems to be related to a previous issue #2020 and #2023 (although the difference with #2023, is that it still worked when starting from other views) .
To Reproduce
Click on Toolkit Reports from any view.
Desktop (please complete the following information):
Occurs on windows and mac in chrome.

Works perfectly! For those on Chrome. Go to chrome://extensions/, click on details for ynab toolkit, click update in the top left. Version should change to 2.31.0 and issue is fixed.

In Firefox, process is similar

in the Hamburger menu, go to Add-ons
click Extensions
click the settings gear
there should be an option to Check for Updates (and my settings had automatically update enabled so it applied the 2.31.1 update)

I ran into this one earlier today. Seems like adjusting my theme on YNAB got the plugin into a bad state:

Disabling uBlock didn't work
Tabbing in from "All Accounts" (rather than "Budget" or "Reports") didn't work

What worked for me was resetting local storage:

Open Chrome developer tools
"Application" tab
Right-click "https://app.youneedabudget.com" under "Local Storage" on the left side of developer tools
Click "Clear"
Hard-refresh via ctrl+shift+R to be sure
App reloads and toolkit was working as usual from that moment on

Really enjoy this plugin and was happy that I was able to get it working again relatively quickly ❤


Support databinding within jsonforms directive #32

Support label attribute for controls #33

Looks great and works well (except for the known bugs such as #14)! Specifying the data via scope variables makes a clean impression. I also like the rename from parameter to scope in the ui schema. Thanks!!


Material Design components for Angular

Hello,
This is not really an issue but a question, are the Material Design components for Angular supported?
We have a page builder on top of the Monaco editor (html), and after we introduced the new material components it was all messed up.
Is this possible to achieve? I couldn't find anything related on the configuration yet.
Thank you for any help you can offer,
Carla Lima

I use ngx-monaco-editor with Angular Material with no problems. Maybe some custom CSS of yours is conflicting with Material?

Hello!
We realized by now, that it's because we are rendering the html that was made in the editor, from the database into a div.
It was used before as sort of a page designer, and with only native html and custom classes worked fine, but as soon as we added material design elements it needs to be rendered properly.
I know now the editor has nothing to do with the issue so this can be closed.
But still, thank you for your help!


Reuse and improve ergonomics of assert_raises utility

Move assert_raises to testutils
Add optional message argument, with reasonable default
Reverse order of expr and exception type for readability
Lambda argument no longer takes parameter
Convert applicable snippets to use assert_raises

Cool! Less is more.


Bug with latest release:

Version
2.0.0
Test Case
http://colddigitalheart.com/
Steps to reproduce
Visit link above
Expected Behavior
site displays react components
Actual Behavior
Failure to load, error:
ReactRouter.min.js:1Uncaught TypeError: Cannot read property 'getCurrentLocation' of undefined

Downgrade to 2.8.1<EMAIL_ADDRESS>

@timdorr I noticed that it's only happening when we don't provide one of the histories option..
Is it a bug from 3.0 (there should be a default one) or it's required to pass a history?
If its required, we may have to fix the example in this page https://github.com/ReactTraining/react-router/blob/master/docs/guides/RouteConfiguration.md.

I am curious about this issue as well.

I also ran into this, feels like the framework should either throw a more explicit exception if you don't provide a history or keep the default from before.


Offsets not working on array when non-zero

Markers/Popups (haven't tested other objects) don't offset with an array parameter if one of the values is 0
Non-working offset
<Marker
  offset={[0, -7]}
  coordinates={[x, y]}
>

Working offset
<Marker
  offset={[0.01, -7]}
  coordinates={[x, y]}
>

I have to resort to using a close to 0 number to achieve offset.

Hey @iop280 sorry for the late reply, this should be fixed with https://github.com/alex3165/react-mapbox-gl/commit/bc275652794956f51d9fb77fbc6c1997569f965c 👍 thanks for reporting the issue


ARROW-14990: [CI] Fix nightly dask integration build (ensure pandas is installed)

@github-actions crossbow submit test-conda-python-3.9-dask-latest test-conda-python-3.9-dask-master


chore: update README and fix yarn dev command

Adds yarn dev command to package.json in base directory.

✅

@jleach Hey Jason, this is ready for your review

Resolved merge conflicts.


Missing Legend property on Chart ref object in type definition

Feature Proposal
Noticed that the legend property is missing from the type definition of the ref.current object that's attached to the Chart instance.
Console.log of the ref.current property:

Possible Implementation
I'd like to add this myself, but not sure how to contribute to the project
Hopefully it's just a matter of adding legend: LegendElement<ChartType> to the list of readonly properties in the class definition of Chart (here if I'm not being clear: https://github.com/chartjs/Chart.js/blob/56661e448d8478e7cbce0f30d70d0bf1d2a2da8c/types/index.esm.d.ts#L483)
Again more than happy to create a PR myself but a bit confused on how to 😅
Thanks for any help/info you can give me!

Apologies, I've submitted this to the wrong repo (meant to submit to https://github.com/reactchartjs/react-chartjs-2)
Closing this one and recreating the issue over there.

Thanks so much @etimberg 🙇♂


Switch to recommending stable

Now 1.30 is out, what stops anyone building all the examples with stable Rust?

Ah, the answer is 2018 edition syntax.

So I figured it out. It's empty when compiling to thumbv7em-none-eabi and it works for thumbv7em-none-eabihf. I opened #147.
I believe that: "You can use stable Rust to develop for embedded" is much stronger message than "You don't have to type 5 lines saying extern crate ...;", so I'd suggest to make it stable.


Delete project from Git repo when user deletes the project

Added method deleteProject() and addDeletedFolderToIndex() to delete project from Repository.

Related to https://github.com/apache/camel-karavan/issues/551


[TestJSONEncoder] - testEncodingDate still has an unhandled edge case

Originally we thought the level of precision requested internally by JSONSerialization (via snprintf) could always be two or more digits larger. Turns out it can be any level of precision larger than requested.
This addresses those edge cases and expands the known cases to cover one discovered last night.

@swift-ci smoke test

@itaiferber I'm going to merge this unless there's an objection...

@bendjones LGTM so I went ahead and merged — sorry for the delay


Add tests

This should fix the default() function position in all files where it had been moved to the bottom of the page to satisfy an eslint rule instead of at the top for readability reasons. The rule has been disabled (no-use-before-defined).

looks good! merging

leaving merge for sprinkle

Coverage remained the same at 71.326% when pulling 3494053ed55c62e7f21616af6ae4cbe765f95060 on addTests into aafd2ea7260e99261862dd7e21fb7095b0e0368d on master.


Backend Image Handler Lambda Function - Timeout following API Gateway

Backend Image Handler Lambda Function construct (CDK) has a timeout of timeout: Duration.minutes(15).
It makes no sense to continue executing the lambda after 29 seconds since Api Gateway on front will have replied to CloudFront with a 504 status code (Gateway Timeout).
Notice: read about Api Gateway integrations limits with Lambda.
Issue #, if available: #379
Description of changes:
Backend Image Handler Lambda Function construct (CDK) configured with timeout: Duration.seconds(29).
Checklist

[x] :wave: I have run the unit tests, and all unit tests have passed.
[ ] :warning: This pull request might incur a breaking change.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@fvsnippets thank you for your contribution. We will look into it and add it to our backlog.

This pr has not received a response in a while. If you want to keep this issue open, please leave a comment below and auto-close will be canceled.

Keeping it open.

Updated with current main branch (using rebase). Conflicts were resolved.

Hi @fvsnippets,
This change has been included in v6.2.4 of SIH. Our internal processes have us merge the code manually, so you won't see this PR get merged, but your profile has been included in the external contributors list at the bottom of the readme.
Thanks for your contributions :)
Simon


feat: add amount field component

Part of LEA-1720
https://github.com/user-attachments/assets/eb5ef453-cdb2-457e-97bb-95c9ea82081e
Adds the AmountField component for review, while I'm still working integrating into the form.
@fbwoolf Might need a little coordination for adding few things to the form for this.
Coming up with separate PRs:

Integrating this to the actual form
Adding character animations

There's currently a noticeable flicker when the font size changes, will be gone by itself once the text is animated.

Found few ways to significantly simplify this. Will re-open next week.

Found few ways to significantly simplify this. Will re-open next week.

👍 I was just reviewing now and it looks good so far


Inconsistent licenses

When looking at individual branches, I noticed they all have different licenses:
module-2
https://github.com/fabwu/dddinaction/blob/ad91f5408250cf9f04155c76cfad5e7e1c2b489b/composer.json#L3
❗ Also note that running
$ composer validate

on module-2 yields
./composer.json is valid, but with a few warnings
See https://getcomposer.org/doc/04-schema.md for details on the schema
License "GPL-3.0" is a deprecated SPDX license identifier, use "GPL-3.0-only" or "GPL-3.0-or-later" instead

module-3
https://github.com/fabwu/dddinaction/blob/a553dceea58bf6a86322d9b8ce87449f4db7d63b/composer.json#L3
module-5
https://github.com/fabwu/dddinaction/blob/c25304d3340804b9d38d51a6041893313375a1ca/composer.json#L3
module-6
https://github.com/fabwu/dddinaction/blob/dcb0edbfa25366750cc7702cdeafab0ca30afbcb/composer.json#L3
module-7
https://github.com/fabwu/dddinaction/blob/cbd423e099f284f2016ed253a7a59752b1d02d77/composer.json#L3
What do you think about using consistent licenses across all branches?

Thanks for pointing that out! I switched to MIT and made the license consistent over all branches.


Added Huffman codec to utils

The codec is intended to be used by compression tools and is designed to be compatible with bit_stream utils, but can be built and used independently.

Remaining changes required:

HuffmanCodec constructor comment should say that it assumes the histogram does not have entries with zero counts. If you want to be more relaxed then that, then give bounds somehow. But I'd just recommend being strict.
CreateEncodingTable implementation comment (around the Context struct, probably) should say that because weights are assumed non-zero, then the huffman tree is nearly balanced, and so 64 bits is sufficient as a path label down to any leaf.

Remaining changes required:

Done.

Squashed and pushed into master as 40a282961


Ensure 4D input/outputs

A bunch of code I've written (especially display-related) assumes that the input / output of model (and thus the attributes that Synthesis methods will have) will be 3d or 4d (batch, channel, etc) and fail in weird ways when that's not true.
We should decide if that's how we want to handle it (and make sure that works for videos, RGB images, etc) and, if so, explicitly check for this and raise a more helpful exception everywhere.

Display code now checks explicitly (after #93), and otherwise this will be part of #86


SaveAttachmentsTo will fail if the name contains invalid path characters (Windows)

Describe the bug
Passing SaveAttachmentsTo to Get-GSGmailMessage fails when the attachment file name contains characters treated as invalid by Windows.
An exception is thrown in the call to [System.IO.File]::Create($fileName) .
To Reproduce
Steps to reproduce the behavior:

Send an email with an attachment named as: ENDEP1_2019-03-29 08:30:00.docx
Call Get-GSGmailMessage -SaveAttachmentsTo

Expected behavior
The file should appear in the folder with invalid characters substituted out.
Environment (please complete the following information):

OS: Windows 10 1803
PowerShell Version: 5.1.17134.590
PSGSuite Version: 2.25.3

@craigminihan - Thanks for opening this up! My initial thought to resolve this is replace any unsafe characters with underscores; would this be an alright approach? If not, what would the preferred behavior be? I should be able to get this resolved pretty quickly tonight and will proceed with underscores as the replacement character unless otherwise noted 🙂

@craigminihan - Fix is being rolled out with v2.26.0, should be on the Gallery shortly!
Here's what I've added, for reference:
foreach ($att in $attachments) {
    $cleanedName = $att.FileName -replace "[$(([System.IO.Path]::GetInvalidFileNameChars() + [System.IO.Path]::GetInvalidPathChars()) -join '')]","_" # <<<<< FileName cleanup via RegEx replace
    $fileName = Join-Path $resPath $cleanedName
    Write-Verbose "Saving attachment to path '$fileName'"
    $stream = [System.IO.File]::Create($fileName)
    $att.ContentObject.DecodeTo($stream)
    $stream.Close()
}

nice - thanks for resolving this so quickly!


Fix output_parser for generate_answer_node

This is a fix for #788
It looks like this case was forgotten during a previous refactoring.


[SPARK-46228][SQL] Insert window group limit node for limit outside of window

What changes were proposed in this pull request?
In ad hoc queries we often need to limit the number of rows returned, if query is limit outside of window, similar to top-k, we can insert node WindowGroupLimit to reduce shuffle.
It supports following pattern:
SELECT (... (row_number|rank|dense_rank|sum|max...)()
    OVER (
PARTITION BY ...
ORDER BY  ... ) AS v)
LIMIT ...

Whether support inferring WindowGroupLimit from Limit outside of Window. Check if:

The window orderSpec exists unfoldable one or all window expressions should use the same expanding window.
All window expressions should not have SizeBasedWindowFunction.
The Limit could not be pushed down through Window.

Limit can be pushed down to the limit of each window group, and enough rows are obtained according to RowFrame/RangeFrame to ensure the accuracy of the function calculation.
For example
  Seq(
      ("a", 0, "c"),
      ("a", 1, "x"),
      ("a", 2, "y"),
      ("a", 3, "z"),
      ("a", 4, ""),
      ("a", 4, ""),
      ("b", 1, "h"),
      ("b", 1, "n")).toDF("a", "b", "c").createOrReplaceTempView("t")

sql1 (RangeFrame)
SELECT *, sum(b)
    OVER (
PARTITION BY a
ORDER BY c ) AS v
FROM t
LIMIT 1

We can extract the limit value 2 (("a", 4, ""),("a", 4, "")) on window group a because window expression is RangeFrame and after sort, the sort values of the first row and the second row are the same, limit value 1 (("b", 1, "h")) on window group b in WindowGroupLimitExec.
sql2 (RowFrame)
SELECT *, row_number()
    OVER (
PARTITION BY a
ORDER BY c ) AS v
FROM t
LIMIT 1

We can extract the limit value 1 (("a", 4, "")) on window group a, limit value 1 (("b", 1, "h")) on window group b in WindowGroupLimitExec.
The effect is similar to #38799. This is beneficial, assuming the per-window-group data size is large. Otherwise, the method to determine window group boundaries is pure overhead. The config spark.sql.window.group.limit.threshold could avoid the overhead if the per-window-group data size is small enough.
Why are the changes needed?
Reduce the shuffle write to improve the performance.
Does this PR introduce any user-facing change?
No.
How was this patch tested?

UT
manual test on TPC-DS
TPC-DS data size: 10Gb.
This improvement is valid for TPC-DS q67-changed

SELECT *
FROM
  (SELECT
    i_category,
    i_class,
    i_brand,
    i_product_name,
    d_year,
    d_qoy,
    d_moy,
    s_store_id,
    sumsales,
    rank()
    OVER (PARTITION BY i_category
      ORDER BY sumsales DESC) rk
  FROM
    (SELECT
      i_category,
      i_class,
      i_brand,
      i_product_name,
      d_year,
      d_qoy,
      d_moy,
      s_store_id,
      coalesce(ss_sales_price * ss_quantity, 0) sumsales
    FROM store_sales, date_dim, store, item
    WHERE ss_sold_date_sk = d_date_sk
      AND ss_item_sk = i_item_sk
      AND ss_store_sk = s_store_sk
      AND d_month_seq BETWEEN 1200 AND 1200 + 11
    ) dw1) dw2
LIMIT 100

TPC-DS Query
Before(Seconds)
After(Seconds)
Speedup(Percent)

q67-changed
18.246
10.799
168.96%

Was this patch authored or co-authored using generative AI tooling?
No.

@beliefer If you have time, can you help me take a look? cc @cloud-fan

Although I understood the mechanism, please add more detail in the PR description. So as contributors could understand.

Although I understood the mechanism, please add more detail in the PR description. So as other contributors could understand.

Done

cc @cloud-fan

@zml1206 The PR description is not clear enough. Please modify
We can extract the limit value 2 (("a", 4, ""),("a", 4, "")) on window group a because window expression is RangeFrame and after sort, the sort values of the first row and the second row are the same, limit value 1 (("b", 1, "h")) on window group b in WindowGroupLimitExec.
You can change to We infer the rank() on window group a because window expression is RangeFrame and after sort. WindowGroupLimitExec will select RankLimitIteratorto select the range values. We infer the rownumber() on window group b.WindowGroupLimitExecwill selectSimpleLimitIterator to select the row values.

@zml1206 The PR description is not clear enough. Please modify We can extract the limit value 2 (("a", 4, ""),("a", 4, "")) on window group a because window expression is RangeFrame and after sort, the sort values of the first row and the second row are the same, limit value 1 (("b", 1, "h")) on window group b in WindowGroupLimitExec. You can change to We infer the rank() on window group a because window expression is RangeFrame and after sort. WindowGroupLimitExec will select RankLimitIterator to select the range values. We infer the rownumber() on window group b. WindowGroupLimitExec will select SimpleLimitIterator to select the row values.

The description is a bit ambiguous. I made some changes. Please see what you think about it.

I changed the description. Do you think it’s easier to understand this way? @cloud-fan


Unable to render due to windows being unable to find a name

i believe a possible reason is that i transferred this from a computer with a different account name, but i don't know if there is a way to change the name it checks for.

Closed due to issue being stale


memory leaks running reports

Memory leaks, 3.0.45 (and likely cvs)
From LINES-L, from David Martin
My comments are still for 3.0.45-2 beta, not for the
new 3.0.46
beta.
I tried several things, checking reportleaks.log after
each one:
- no leaks reported after Read or Save GEDCOM (2132
persons)
- after running report book-latex.ll v3.1 (with bug fix):
Node memory leaks: 4274 items leaked
Record memory leaks: 1 item leaked
- after running report cousins.ll v6.0
Record memory leaks: 2 items leaked
- after Add person
Record memory leaks: 1 item leaked
- after Add as child to a parent
Record memory leaks: 2 items leaked
Reported by: elsapo
Original Ticket: "bugs/207":https://sourceforge.net/p/bugs/207

Using the latest git master, the following leaks could not be reproduced:

book-latex.ll (Node memory)
Add person (Record memory)

All the rest can still be reproduced.

book-latex.ll (Record memory, 1)
cousins.ll (Record memory, 2)
Add as child to parent (Record memory, 2)

While debugging "add as child to parent", I also found a similar leak in "add as child to family".

The record leaks in book-latex.ll and cousins.ll were tracked down to ask_for_indi_key().
The record leaks in "Add as child to parent" and "add as child to family" were tracked down to prompt_add_child().