HADOOP-17077. S3A delegation token binding to support secondary binding list

extracted interfaces from some of the classes to allow for
separate/wrapper implementations. Maybe we don't actually need that though.
Add TokenIssuer for the new tokens
wip binding to s3a fs.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 32s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s
The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
18m 44s
trunk passed

+1 :green_heart:
compile
0m 36s
trunk passed

+1 :green_heart:
checkstyle
0m 27s
trunk passed

+1 :green_heart:
mvnsite
0m 40s
trunk passed

+1 :green_heart:
shadedclient
14m 50s
branch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
0m 30s
trunk passed

+0 :ok:
spotbugs
1m  1s
Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
0m 58s
trunk passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 33s
the patch passed

+1 :green_heart:
compile
0m 28s
the patch passed

+1 :green_heart:
javac
0m 28s
the patch passed

-0 :warning:
checkstyle
0m 19s
hadoop-tools/hadoop-aws: The patch generated 5 new + 8 unchanged - 0 fixed = 13 total (was 8)

+1 :green_heart:
mvnsite
0m 31s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
shadedclient
13m 38s
patch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
0m 26s
the patch passed

-1 :x:
findbugs
1m  4s
hadoop-tools/hadoop-aws generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

_ Other Tests _

+1 :green_heart:
unit
1m 20s
hadoop-aws in the patch passed.

+1 :green_heart:
asflicense
0m 32s
The patch does not generate ASF License warnings.

57m 21s

Reason
Tests

FindBugs
module:hadoop-tools/hadoop-aws

Unread field:SecondaryDTBinding.java:[line 55]

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-2083/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2083

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux b397fac21284 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / d50e93ce7b6

Default Java
Private Build-1.8.0_252-8u252-b09-1~18.04-b09

checkstyle
https://builds.apache.org/job/hadoop-multibranch/job/PR-2083/1/artifact/out/diff-checkstyle-hadoop-tools_hadoop-aws.txt

findbugs
https://builds.apache.org/job/hadoop-multibranch/job/PR-2083/1/artifact/out/new-findbugs-hadoop-tools_hadoop-aws.html

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-2083/1/testReport/

Max. process+thread count
437 (vs. ulimit of 5500)

modules
C: hadoop-tools/hadoop-aws U: hadoop-tools/hadoop-aws

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-2083/1/console

versions
git=2.17.1 maven=3.6.0 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 34s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s
No case conflicting files found.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
19m 51s
trunk passed

+1 :green_heart:
compile
0m 43s
trunk passed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04

+1 :green_heart:
compile
0m 32s
trunk passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09

+1 :green_heart:
checkstyle
0m 24s
trunk passed

+1 :green_heart:
mvnsite
0m 37s
trunk passed

+1 :green_heart:
shadedclient
15m  0s
branch has no errors when building and testing our client artifacts.

-1 :x:
javadoc
0m 31s
hadoop-aws in trunk failed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.

+1 :green_heart:
javadoc
0m 26s
trunk passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09

+0 :ok:
spotbugs
1m  5s
Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
1m  3s
trunk passed

-0 :warning:
patch
1m 24s
Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 35s
the patch passed

+1 :green_heart:
compile
0m 33s
the patch passed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04

+1 :green_heart:
javac
0m 33s
the patch passed

+1 :green_heart:
compile
0m 28s
the patch passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09

+1 :green_heart:
javac
0m 28s
the patch passed

-0 :warning:
checkstyle
0m 18s
hadoop-tools/hadoop-aws: The patch generated 6 new + 8 unchanged - 1 fixed = 14 total (was 9)

+1 :green_heart:
mvnsite
0m 32s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
shadedclient
13m 51s
patch has no errors when building and testing our client artifacts.

-1 :x:
javadoc
0m 26s
hadoop-aws in the patch failed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.

+1 :green_heart:
javadoc
0m 26s
the patch passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09

-1 :x:
findbugs
1m  3s
hadoop-tools/hadoop-aws generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

_ Other Tests _

+1 :green_heart:
unit
1m 21s
hadoop-aws in the patch passed.

+1 :green_heart:
asflicense
0m 31s
The patch does not generate ASF License warnings.

61m 50s

Reason
Tests

FindBugs
module:hadoop-tools/hadoop-aws

Unread field:SecondaryDelegationToken.java:[line 122]

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-2083/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2083

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux 6511d2c11786 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / fa14e4bc001

Default Java
Private Build-1.8.0_252-8u252-b09-1~18.04-b09

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_252-8u252-b09-1~18.04-b09

javadoc
https://builds.apache.org/job/hadoop-multibranch/job/PR-2083/2/artifact/out/branch-javadoc-hadoop-tools_hadoop-aws-jdkUbuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.txt

checkstyle
https://builds.apache.org/job/hadoop-multibranch/job/PR-2083/2/artifact/out/diff-checkstyle-hadoop-tools_hadoop-aws.txt

javadoc
https://builds.apache.org/job/hadoop-multibranch/job/PR-2083/2/artifact/out/patch-javadoc-hadoop-tools_hadoop-aws-jdkUbuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.txt

findbugs
https://builds.apache.org/job/hadoop-multibranch/job/PR-2083/2/artifact/out/new-findbugs-hadoop-tools_hadoop-aws.html

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-2083/2/testReport/

Max. process+thread count
414 (vs. ulimit of 5500)

modules
C: hadoop-tools/hadoop-aws U: hadoop-tools/hadoop-aws

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-2083/2/console

versions
git=2.17.1 maven=3.6.0 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 32s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s
No case conflicting files found.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 2 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
18m 56s
trunk passed

+1 :green_heart:
compile
0m 42s
trunk passed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04

+1 :green_heart:
compile
0m 36s
trunk passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09

+1 :green_heart:
checkstyle
0m 28s
trunk passed

+1 :green_heart:
mvnsite
0m 39s
trunk passed

+1 :green_heart:
shadedclient
14m 59s
branch has no errors when building and testing our client artifacts.

-1 :x:
javadoc
0m 31s
hadoop-aws in trunk failed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.

+1 :green_heart:
javadoc
0m 30s
trunk passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09

+0 :ok:
spotbugs
0m 59s
Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
0m 56s
trunk passed

-0 :warning:
patch
1m 16s
Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 33s
the patch passed

+1 :green_heart:
compile
0m 33s
the patch passed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04

+1 :green_heart:
javac
0m 33s
the patch passed

+1 :green_heart:
compile
0m 28s
the patch passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09

+1 :green_heart:
javac
0m 28s
the patch passed

-0 :warning:
checkstyle
0m 19s
hadoop-tools/hadoop-aws: The patch generated 8 new + 18 unchanged - 2 fixed = 26 total (was 20)

+1 :green_heart:
mvnsite
0m 31s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
shadedclient
13m 56s
patch has no errors when building and testing our client artifacts.

-1 :x:
javadoc
0m 28s
hadoop-aws in the patch failed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.

+1 :green_heart:
javadoc
0m 26s
the patch passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09

-1 :x:
findbugs
1m  5s
hadoop-tools/hadoop-aws generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

_ Other Tests _

+1 :green_heart:
unit
1m 23s
hadoop-aws in the patch passed.

+1 :green_heart:
asflicense
0m 31s
The patch does not generate ASF License warnings.

61m  7s

Reason
Tests

FindBugs
module:hadoop-tools/hadoop-aws

Unread field:SecondaryDelegationToken.java:[line 157]

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-2083/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2083

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux 91b036b8a814 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 03f855e3e7a

Default Java
Private Build-1.8.0_252-8u252-b09-1~18.04-b09

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_252-8u252-b09-1~18.04-b09

javadoc
https://builds.apache.org/job/hadoop-multibranch/job/PR-2083/3/artifact/out/branch-javadoc-hadoop-tools_hadoop-aws-jdkUbuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.txt

checkstyle
https://builds.apache.org/job/hadoop-multibranch/job/PR-2083/3/artifact/out/diff-checkstyle-hadoop-tools_hadoop-aws.txt

javadoc
https://builds.apache.org/job/hadoop-multibranch/job/PR-2083/3/artifact/out/patch-javadoc-hadoop-tools_hadoop-aws-jdkUbuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.txt

findbugs
https://builds.apache.org/job/hadoop-multibranch/job/PR-2083/3/artifact/out/new-findbugs-hadoop-tools_hadoop-aws.html

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-2083/3/testReport/

Max. process+thread count
452 (vs. ulimit of 5500)

modules
C: hadoop-tools/hadoop-aws U: hadoop-tools/hadoop-aws

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-2083/3/console

versions
git=2.17.1 maven=3.6.0 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 55s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s
No case conflicting files found.

+0 :ok:
markdownlint
0m  1s
markdownlint was not available.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 2 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
25m 15s
trunk passed

+1 :green_heart:
compile
0m 47s
trunk passed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04

+1 :green_heart:
compile
0m 35s
trunk passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09

+1 :green_heart:
checkstyle
0m 28s
trunk passed

+1 :green_heart:
mvnsite
0m 41s
trunk passed

+1 :green_heart:
shadedclient
17m 37s
branch has no errors when building and testing our client artifacts.

-1 :x:
javadoc
0m 35s
hadoop-aws in trunk failed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.

+1 :green_heart:
javadoc
0m 27s
trunk passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09

+0 :ok:
spotbugs
1m 21s
Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
1m 18s
trunk passed

-0 :warning:
patch
1m 36s
Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 40s
the patch passed

+1 :green_heart:
compile
0m 38s
the patch passed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04

+1 :green_heart:
javac
0m 38s
the patch passed

+1 :green_heart:
compile
0m 30s
the patch passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09

+1 :green_heart:
javac
0m 30s
the patch passed

-0 :warning:
checkstyle
0m 21s
hadoop-tools/hadoop-aws: The patch generated 9 new + 18 unchanged - 2 fixed = 27 total (was 20)

+1 :green_heart:
mvnsite
0m 33s
the patch passed

-1 :x:
whitespace
0m  0s
The patch has 2 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply

+1 :green_heart:
shadedclient
16m 33s
patch has no errors when building and testing our client artifacts.

-1 :x:
javadoc
0m 27s
hadoop-aws in the patch failed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.

+1 :green_heart:
javadoc
0m 24s
the patch passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09

-1 :x:
findbugs
1m 15s
hadoop-tools/hadoop-aws generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

_ Other Tests _

+1 :green_heart:
unit
1m 18s
hadoop-aws in the patch passed.

+1 :green_heart:
asflicense
0m 29s
The patch does not generate ASF License warnings.

74m 52s

Reason
Tests

FindBugs
module:hadoop-tools/hadoop-aws

Unread field:SecondaryDelegationToken.java:[line 186]

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-2083/4/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2083

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle markdownlint

uname
Linux ae74b57eb298 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 84110d850e2

Default Java
Private Build-1.8.0_252-8u252-b09-1~18.04-b09

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_252-8u252-b09-1~18.04-b09

javadoc
https://builds.apache.org/job/hadoop-multibranch/job/PR-2083/4/artifact/out/branch-javadoc-hadoop-tools_hadoop-aws-jdkUbuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.txt

checkstyle
https://builds.apache.org/job/hadoop-multibranch/job/PR-2083/4/artifact/out/diff-checkstyle-hadoop-tools_hadoop-aws.txt

whitespace
https://builds.apache.org/job/hadoop-multibranch/job/PR-2083/4/artifact/out/whitespace-eol.txt

javadoc
https://builds.apache.org/job/hadoop-multibranch/job/PR-2083/4/artifact/out/patch-javadoc-hadoop-tools_hadoop-aws-jdkUbuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.txt

findbugs
https://builds.apache.org/job/hadoop-multibranch/job/PR-2083/4/artifact/out/new-findbugs-hadoop-tools_hadoop-aws.html

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-2083/4/testReport/

Max. process+thread count
428 (vs. ulimit of 5500)

modules
C: hadoop-tools/hadoop-aws U: hadoop-tools/hadoop-aws

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-2083/4/console

versions
git=2.17.1 maven=3.6.0 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 34s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s
No case conflicting files found.

+0 :ok:
markdownlint
0m  0s
markdownlint was not available.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 5 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
19m 27s
trunk passed

+1 :green_heart:
compile
0m 41s
trunk passed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04

+1 :green_heart:
compile
0m 35s
trunk passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09

+1 :green_heart:
checkstyle
0m 28s
trunk passed

+1 :green_heart:
mvnsite
0m 40s
trunk passed

+1 :green_heart:
shadedclient
15m  8s
branch has no errors when building and testing our client artifacts.

-1 :x:
javadoc
0m 31s
hadoop-aws in trunk failed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.

+1 :green_heart:
javadoc
0m 30s
trunk passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09

+0 :ok:
spotbugs
0m 59s
Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
0m 58s
trunk passed

-0 :warning:
patch
1m 16s
Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 32s
the patch passed

+1 :green_heart:
compile
0m 33s
the patch passed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04

+1 :green_heart:
javac
0m 33s
the patch passed

+1 :green_heart:
compile
0m 27s
the patch passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09

+1 :green_heart:
javac
0m 27s
the patch passed

-0 :warning:
checkstyle
0m 20s
hadoop-tools/hadoop-aws: The patch generated 12 new + 19 unchanged - 2 fixed = 31 total (was 21)

+1 :green_heart:
mvnsite
0m 31s
the patch passed

-1 :x:
whitespace
0m  0s
The patch has 2 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply

+1 :green_heart:
shadedclient
13m 44s
patch has no errors when building and testing our client artifacts.

-1 :x:
javadoc
0m 27s
hadoop-aws in the patch failed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.

+1 :green_heart:
javadoc
0m 25s
the patch passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09

-1 :x:
findbugs
1m  3s
hadoop-tools/hadoop-aws generated 4 new + 0 unchanged - 0 fixed = 4 total (was 0)

_ Other Tests _

+1 :green_heart:
unit
1m 24s
hadoop-aws in the patch passed.

+1 :green_heart:
asflicense
0m 31s
The patch does not generate ASF License warnings.

61m 39s

Reason
Tests

FindBugs
module:hadoop-tools/hadoop-aws

Self assignment of field ExtensionBindingData$Builder.storeContext in org.apache.hadoop.fs.s3a.auth.delegation.ExtensionBindingData$Builder.withStoreContext(StoreContext)  At ExtensionBindingData.java:in org.apache.hadoop.fs.s3a.auth.delegation.ExtensionBindingData$Builder.withStoreContext(StoreContext)  At ExtensionBindingData.java:[line 100]

Unwritten field:ExtensionBindingData.java:[line 100]

Unread field:SecondaryDelegationToken.java:[line 217]

Unread field:SecondaryDelegationToken.java:[line 190]

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-2083/5/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2083

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle markdownlint

uname
Linux 4b5f860a2ec3 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / e0c1d8a9690

Default Java
Private Build-1.8.0_252-8u252-b09-1~18.04-b09

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_252-8u252-b09-1~18.04-b09

javadoc
https://builds.apache.org/job/hadoop-multibranch/job/PR-2083/5/artifact/out/branch-javadoc-hadoop-tools_hadoop-aws-jdkUbuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.txt

checkstyle
https://builds.apache.org/job/hadoop-multibranch/job/PR-2083/5/artifact/out/diff-checkstyle-hadoop-tools_hadoop-aws.txt

whitespace
https://builds.apache.org/job/hadoop-multibranch/job/PR-2083/5/artifact/out/whitespace-eol.txt

javadoc
https://builds.apache.org/job/hadoop-multibranch/job/PR-2083/5/artifact/out/patch-javadoc-hadoop-tools_hadoop-aws-jdkUbuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.txt

findbugs
https://builds.apache.org/job/hadoop-multibranch/job/PR-2083/5/artifact/out/new-findbugs-hadoop-tools_hadoop-aws.html

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-2083/5/testReport/

Max. process+thread count
453 (vs. ulimit of 5500)

modules
C: hadoop-tools/hadoop-aws U: hadoop-tools/hadoop-aws

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-2083/5/console

versions
git=2.17.1 maven=3.6.0 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
21m 50s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s
No case conflicting files found.

+0 :ok:
markdownlint
0m  0s
markdownlint was not available.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 7 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
18m 50s
trunk passed

+1 :green_heart:
compile
0m 41s
trunk passed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04

+1 :green_heart:
compile
0m 36s
trunk passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09

+1 :green_heart:
checkstyle
0m 28s
trunk passed

+1 :green_heart:
mvnsite
0m 41s
trunk passed

+1 :green_heart:
shadedclient
15m  4s
branch has no errors when building and testing our client artifacts.

-1 :x:
javadoc
0m 31s
hadoop-aws in trunk failed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.

+1 :green_heart:
javadoc
0m 29s
trunk passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09

+0 :ok:
spotbugs
1m  0s
Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
0m 57s
trunk passed

-0 :warning:
patch
1m 16s
Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 33s
the patch passed

+1 :green_heart:
compile
0m 33s
the patch passed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04

+1 :green_heart:
javac
0m 33s
the patch passed

+1 :green_heart:
compile
0m 27s
the patch passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09

+1 :green_heart:
javac
0m 27s
the patch passed

-0 :warning:
checkstyle
0m 20s
hadoop-tools/hadoop-aws: The patch generated 14 new + 20 unchanged - 2 fixed = 34 total (was 22)

+1 :green_heart:
mvnsite
0m 32s
the patch passed

-1 :x:
whitespace
0m  0s
The patch has 2 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply

+1 :green_heart:
shadedclient
13m 48s
patch has no errors when building and testing our client artifacts.

-1 :x:
javadoc
0m 28s
hadoop-aws in the patch failed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.

+1 :green_heart:
javadoc
0m 26s
the patch passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09

-1 :x:
findbugs
1m  3s
hadoop-tools/hadoop-aws generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0)

_ Other Tests _

+1 :green_heart:
unit
1m 22s
hadoop-aws in the patch passed.

+1 :green_heart:
asflicense
0m 31s
The patch does not generate ASF License warnings.

82m 21s

Reason
Tests

FindBugs
module:hadoop-tools/hadoop-aws

Unread field:SecondaryDelegationToken.java:[line 217]

Unread field:SecondaryDelegationToken.java:[line 190]

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-2083/6/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2083

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle markdownlint

uname
Linux c0a7b58409d2 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 74fc13cf918

Default Java
Private Build-1.8.0_252-8u252-b09-1~18.04-b09

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_252-8u252-b09-1~18.04-b09

javadoc
https://builds.apache.org/job/hadoop-multibranch/job/PR-2083/6/artifact/out/branch-javadoc-hadoop-tools_hadoop-aws-jdkUbuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.txt

checkstyle
https://builds.apache.org/job/hadoop-multibranch/job/PR-2083/6/artifact/out/diff-checkstyle-hadoop-tools_hadoop-aws.txt

whitespace
https://builds.apache.org/job/hadoop-multibranch/job/PR-2083/6/artifact/out/whitespace-eol.txt

javadoc
https://builds.apache.org/job/hadoop-multibranch/job/PR-2083/6/artifact/out/patch-javadoc-hadoop-tools_hadoop-aws-jdkUbuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.txt

findbugs
https://builds.apache.org/job/hadoop-multibranch/job/PR-2083/6/artifact/out/new-findbugs-hadoop-tools_hadoop-aws.html

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-2083/6/testReport/

Max. process+thread count
429 (vs. ulimit of 5500)

modules
C: hadoop-tools/hadoop-aws U: hadoop-tools/hadoop-aws

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-2083/6/console

versions
git=2.17.1 maven=3.6.0 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
18m  2s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s
No case conflicting files found.

+0 :ok:
markdownlint
0m  0s
markdownlint was not available.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 10 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
1m  3s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
19m 34s
trunk passed

+1 :green_heart:
compile
19m 13s
trunk passed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04

+1 :green_heart:
compile
16m 49s
trunk passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09

+1 :green_heart:
checkstyle
2m 45s
trunk passed

+1 :green_heart:
mvnsite
2m 11s
trunk passed

+1 :green_heart:
shadedclient
19m 17s
branch has no errors when building and testing our client artifacts.

-1 :x:
javadoc
0m 46s
hadoop-hdfs in trunk failed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.

-1 :x:
javadoc
0m 41s
hadoop-aws in trunk failed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.

+1 :green_heart:
javadoc
1m 32s
trunk passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09

+0 :ok:
spotbugs
1m 21s
Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
4m 23s
trunk passed

-0 :warning:
patch
1m 43s
Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 27s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m  7s
the patch passed

+1 :green_heart:
compile
18m 55s
the patch passed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04

+1 :green_heart:
javac
18m 55s
the patch passed

+1 :green_heart:
compile
16m 41s
the patch passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09

+1 :green_heart:
javac
16m 41s
the patch passed

-0 :warning:
checkstyle
2m 42s
root: The patch generated 12 new + 31 unchanged - 3 fixed = 43 total (was 34)

+1 :green_heart:
mvnsite
2m 21s
the patch passed

-1 :x:
whitespace
0m  0s
The patch has 4 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply

+1 :green_heart:
shadedclient
14m  7s
patch has no errors when building and testing our client artifacts.

-1 :x:
javadoc
0m 50s
hadoop-hdfs in the patch failed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.

-1 :x:
javadoc
0m 45s
hadoop-aws in the patch failed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.

+1 :green_heart:
javadoc
1m 42s
the patch passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09

+1 :green_heart:
findbugs
4m 30s
the patch passed

_ Other Tests _

-1 :x:
unit
93m 38s
hadoop-hdfs in the patch passed.

+1 :green_heart:
unit
1m 48s
hadoop-aws in the patch passed.

+1 :green_heart:
asflicense
0m 58s
The patch does not generate ASF License warnings.

269m 34s

Reason
Tests

Failed junit tests
hadoop.hdfs.server.namenode.TestFSImageWithAcl

hadoop.hdfs.server.blockmanagement.TestUnderReplicatedBlocks

hadoop.hdfs.server.sps.TestExternalStoragePolicySatisfier

hadoop.hdfs.server.blockmanagement.TestBlockTokenWithDFSStriped

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-2083/7/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2083

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle markdownlint

uname
Linux 83e9172cbc90 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / e8dc862d385

Default Java
Private Build-1.8.0_252-8u252-b09-1~18.04-b09

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_252-8u252-b09-1~18.04-b09

javadoc
https://builds.apache.org/job/hadoop-multibranch/job/PR-2083/7/artifact/out/branch-javadoc-hadoop-hdfs-project_hadoop-hdfs-jdkUbuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.txt

javadoc
https://builds.apache.org/job/hadoop-multibranch/job/PR-2083/7/artifact/out/branch-javadoc-hadoop-tools_hadoop-aws-jdkUbuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.txt

checkstyle
https://builds.apache.org/job/hadoop-multibranch/job/PR-2083/7/artifact/out/diff-checkstyle-root.txt

whitespace
https://builds.apache.org/job/hadoop-multibranch/job/PR-2083/7/artifact/out/whitespace-eol.txt

javadoc
https://builds.apache.org/job/hadoop-multibranch/job/PR-2083/7/artifact/out/patch-javadoc-hadoop-hdfs-project_hadoop-hdfs-jdkUbuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.txt

javadoc
https://builds.apache.org/job/hadoop-multibranch/job/PR-2083/7/artifact/out/patch-javadoc-hadoop-tools_hadoop-aws-jdkUbuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.txt

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-2083/7/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-2083/7/testReport/

Max. process+thread count
4537 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs hadoop-tools/hadoop-aws U: .

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-2083/7/console

versions
git=2.17.1 maven=3.6.0 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 29s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+0 :ok:
markdownlint
0m  1s
markdownlint was not available.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 10 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
1m  4s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
21m 45s
trunk passed

+1 :green_heart:
compile
20m 30s
trunk passed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04

+1 :green_heart:
compile
17m  2s
trunk passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09

+1 :green_heart:
checkstyle
2m 48s
trunk passed

+1 :green_heart:
mvnsite
2m  6s
trunk passed

+1 :green_heart:
shadedclient
20m 52s
branch has no errors when building and testing our client artifacts.

-1 :x:
javadoc
0m 42s
hadoop-hdfs in trunk failed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.

-1 :x:
javadoc
0m 35s
hadoop-aws in trunk failed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.

+1 :green_heart:
javadoc
1m 20s
trunk passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09

+0 :ok:
spotbugs
1m  7s
Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
4m 10s
trunk passed

-0 :warning:
patch
1m 25s
Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 21s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
1m 40s
the patch passed

+1 :green_heart:
compile
19m 34s
the patch passed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04

+1 :green_heart:
javac
19m 34s
the patch passed

+1 :green_heart:
compile
17m  1s
the patch passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09

+1 :green_heart:
javac
17m  1s
the patch passed

-0 :warning:
checkstyle
2m 49s
root: The patch generated 12 new + 31 unchanged - 3 fixed = 43 total (was 34)

+1 :green_heart:
mvnsite
2m  6s
the patch passed

-1 :x:
whitespace
0m  0s
The patch has 4 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply

+1 :green_heart:
shadedclient
15m 17s
patch has no errors when building and testing our client artifacts.

-1 :x:
javadoc
0m 42s
hadoop-hdfs in the patch failed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.

-1 :x:
javadoc
0m 35s
hadoop-aws in the patch failed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.

+1 :green_heart:
javadoc
1m 21s
the patch passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09

+1 :green_heart:
findbugs
4m 30s
the patch passed

_ Other Tests _

-1 :x:
unit
91m 48s
hadoop-hdfs in the patch passed.

+1 :green_heart:
unit
1m 37s
hadoop-aws in the patch passed.

+1 :green_heart:
asflicense
0m 51s
The patch does not generate ASF License warnings.

254m 20s

Reason
Tests

Failed junit tests
hadoop.fs.contract.hdfs.TestHDFSContractMultipartUploader

hadoop.hdfs.server.sps.TestExternalStoragePolicySatisfier

hadoop.hdfs.TestGetFileChecksum

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-2083/8/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2083

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle markdownlint

uname
Linux 2d4b977ebf27 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 0427100b754

Default Java
Private Build-1.8.0_252-8u252-b09-1~18.04-b09

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_252-8u252-b09-1~18.04-b09

javadoc
https://builds.apache.org/job/hadoop-multibranch/job/PR-2083/8/artifact/out/branch-javadoc-hadoop-hdfs-project_hadoop-hdfs-jdkUbuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.txt

javadoc
https://builds.apache.org/job/hadoop-multibranch/job/PR-2083/8/artifact/out/branch-javadoc-hadoop-tools_hadoop-aws-jdkUbuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.txt

checkstyle
https://builds.apache.org/job/hadoop-multibranch/job/PR-2083/8/artifact/out/diff-checkstyle-root.txt

whitespace
https://builds.apache.org/job/hadoop-multibranch/job/PR-2083/8/artifact/out/whitespace-eol.txt

javadoc
https://builds.apache.org/job/hadoop-multibranch/job/PR-2083/8/artifact/out/patch-javadoc-hadoop-hdfs-project_hadoop-hdfs-jdkUbuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.txt

javadoc
https://builds.apache.org/job/hadoop-multibranch/job/PR-2083/8/artifact/out/patch-javadoc-hadoop-tools_hadoop-aws-jdkUbuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.txt

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-2083/8/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-2083/8/testReport/

Max. process+thread count
3258 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs hadoop-tools/hadoop-aws U: .

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-2083/8/console

versions
git=2.17.1 maven=3.6.0 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 38s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+0 :ok:
markdownlint
0m  1s
markdownlint was not available.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 10 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
0m 27s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
20m 12s
trunk passed

+1 :green_heart:
compile
21m 29s
trunk passed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04

+1 :green_heart:
compile
18m  6s
trunk passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09

+1 :green_heart:
checkstyle
2m 54s
trunk passed

+1 :green_heart:
mvnsite
2m 25s
trunk passed

+1 :green_heart:
shadedclient
19m 40s
branch has no errors when building and testing our client artifacts.

-1 :x:
javadoc
0m 45s
hadoop-hdfs in trunk failed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.

-1 :x:
javadoc
0m 42s
hadoop-aws in trunk failed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.

+1 :green_heart:
javadoc
1m 35s
trunk passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09

+0 :ok:
spotbugs
1m 17s
Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
4m 37s
trunk passed

-0 :warning:
patch
1m 39s
Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 28s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
1m 47s
the patch passed

+1 :green_heart:
compile
20m 48s
the patch passed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04

+1 :green_heart:
javac
20m 48s
the patch passed

+1 :green_heart:
compile
16m 41s
the patch passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09

+1 :green_heart:
javac
16m 41s
the patch passed

-0 :warning:
checkstyle
2m 38s
root: The patch generated 5 new + 31 unchanged - 3 fixed = 36 total (was 34)

+1 :green_heart:
mvnsite
2m 19s
the patch passed

-1 :x:
whitespace
0m  0s
The patch has 4 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply

+1 :green_heart:
shadedclient
13m 56s
patch has no errors when building and testing our client artifacts.

-1 :x:
javadoc
0m 50s
hadoop-hdfs in the patch failed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.

-1 :x:
javadoc
0m 44s
hadoop-aws in the patch failed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.

+1 :green_heart:
javadoc
1m 40s
the patch passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09

+1 :green_heart:
findbugs
4m 32s
the patch passed

_ Other Tests _

-1 :x:
unit
94m 45s
hadoop-hdfs in the patch passed.

+1 :green_heart:
unit
1m 57s
hadoop-aws in the patch passed.

+1 :green_heart:
asflicense
1m  4s
The patch does not generate ASF License warnings.

259m  4s

Reason
Tests

Failed junit tests
hadoop.hdfs.server.balancer.TestBalancer

hadoop.hdfs.web.TestWebHdfsWithMultipleNameNodes

hadoop.hdfs.server.blockmanagement.TestBlockTokenWithDFSStriped

hadoop.hdfs.server.sps.TestExternalStoragePolicySatisfier

hadoop.fs.contract.hdfs.TestHDFSContractMultipartUploader

hadoop.hdfs.server.namenode.ha.TestHAAppend

hadoop.hdfs.server.namenode.TestDiskspaceQuotaUpdate

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-2083/9/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2083

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle markdownlint

uname
Linux f5dfabcb19d4 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 0427100b754

Default Java
Private Build-1.8.0_252-8u252-b09-1~18.04-b09

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_252-8u252-b09-1~18.04-b09

javadoc
https://builds.apache.org/job/hadoop-multibranch/job/PR-2083/9/artifact/out/branch-javadoc-hadoop-hdfs-project_hadoop-hdfs-jdkUbuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.txt

javadoc
https://builds.apache.org/job/hadoop-multibranch/job/PR-2083/9/artifact/out/branch-javadoc-hadoop-tools_hadoop-aws-jdkUbuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.txt

checkstyle
https://builds.apache.org/job/hadoop-multibranch/job/PR-2083/9/artifact/out/diff-checkstyle-root.txt

whitespace
https://builds.apache.org/job/hadoop-multibranch/job/PR-2083/9/artifact/out/whitespace-eol.txt

javadoc
https://builds.apache.org/job/hadoop-multibranch/job/PR-2083/9/artifact/out/patch-javadoc-hadoop-hdfs-project_hadoop-hdfs-jdkUbuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.txt

javadoc
https://builds.apache.org/job/hadoop-multibranch/job/PR-2083/9/artifact/out/patch-javadoc-hadoop-tools_hadoop-aws-jdkUbuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.txt

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-2083/9/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-2083/9/testReport/

Max. process+thread count
4318 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs hadoop-tools/hadoop-aws U: .

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-2083/9/console

versions
git=2.17.1 maven=3.6.0 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Related to this, we want different DT bindings to be able to return different auth chains for different usages. e.g Dt 1 provides auth for s3, but DT 2 does dynamoDB
Proposed: we extend the auth chain logic so that

S3ADelegationTokens stores map of client-role -> auth chain

On demand, token providers are asked for the auth chain for a specific role -they can choose whether to return one or none at all. The default chain is the one built up during init

S3A DT will have exactly one list it builds up, the s3 one.
When anything asks for a new set of AWS creds via  AWSCredentialProviderList shareCredentials, with no dt: return the s3 list.
with DT: ask all the way through each DT plugin
And aggregate these for the final chain

Every DT should, by default, provide its initial set of AWS credential providers to all authentication clients. It is only when a client knows that it wants to provide a different (possibly empty) list of credential providers. that there's any need to differ.
+define the "official" names of credential chains needed.Proposed: by AWS service rather than use made in app.
troublespotshareCredentials() uses reference counting to decide when to go through the provider list and close them. This matters for providers which use close() to release resouces like threads

we MUST call close on all providers when they are no longer needed anywhere,
we MUST NOT close() a provider which may be needed elsewhere

If we have different AWSProviderList lists with different sharing, we can't use a simple reference count for the list any more.
If a new provider list is generated, then all providers in it MUST be new or we do some complicated and hard to test/maintain tricks to reference count providers in there.
If we go with "needs new providers" then we will need some two pass collection for non-default lists, something like

ask all entries if they wish to provide a new provider list
if all say no: return old one
If any one says yes: ask every provider to generate a new provider with its own lifecycle. It may just be the empty list for an unsupported service

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 52s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+0 :ok:
markdownlint
0m  1s
markdownlint was not available.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 10 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
0m 27s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
21m  7s
trunk passed

+1 :green_heart:
compile
21m 14s
trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1

+1 :green_heart:
compile
18m 18s
trunk passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09

+1 :green_heart:
checkstyle
2m 34s
trunk passed

+1 :green_heart:
mvnsite
2m 17s
trunk passed

+1 :green_heart:
shadedclient
19m 25s
branch has no errors when building and testing our client artifacts.

-1 :x:
javadoc
0m 47s
hadoop-hdfs in trunk failed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.

-1 :x:
javadoc
0m 42s
hadoop-aws in trunk failed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.

+1 :green_heart:
javadoc
1m 33s
trunk passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09

+0 :ok:
spotbugs
1m 14s
Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
4m 14s
trunk passed

-0 :warning:
patch
1m 35s
Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 27s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
1m 46s
the patch passed

+1 :green_heart:
compile
20m 22s
the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1

+1 :green_heart:
javac
20m 22s
the patch passed

+1 :green_heart:
compile
17m 45s
the patch passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09

+1 :green_heart:
javac
17m 45s
the patch passed

-0 :warning:
checkstyle
2m 45s
root: The patch generated 5 new + 30 unchanged - 3 fixed = 35 total (was 33)

+1 :green_heart:
mvnsite
2m 23s
the patch passed

-1 :x:
whitespace
0m  0s
The patch has 4 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply

+1 :green_heart:
shadedclient
13m 53s
patch has no errors when building and testing our client artifacts.

-1 :x:
javadoc
0m 46s
hadoop-hdfs in the patch failed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.

-1 :x:
javadoc
0m 41s
hadoop-aws in the patch failed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.

+1 :green_heart:
javadoc
1m 33s
the patch passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09

+1 :green_heart:
findbugs
4m 39s
the patch passed

_ Other Tests _

-1 :x:
unit
98m 34s
hadoop-hdfs in the patch passed.

+1 :green_heart:
unit
1m 44s
hadoop-aws in the patch passed.

-1 :x:
asflicense
0m 57s
The patch generated 1 ASF License warnings.

262m 43s

Reason
Tests

Failed junit tests
hadoop.hdfs.server.namenode.snapshot.TestRandomOpsWithSnapshots

hadoop.hdfs.server.namenode.snapshot.TestSnapshot

hadoop.hdfs.TestSafeModeWithStripedFileWithRandomECPolicy

hadoop.hdfs.server.blockmanagement.TestBlockTokenWithDFSStriped

hadoop.hdfs.TestSafeMode

hadoop.hdfs.TestRollingUpgrade

hadoop.hdfs.server.namenode.snapshot.TestRenameWithSnapshots

hadoop.fs.contract.hdfs.TestHDFSContractMultipartUploader

hadoop.hdfs.server.sps.TestExternalStoragePolicySatisfier

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2083/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2083

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle markdownlint

uname
Linux ab9c3e3a957c 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 05b3337a460

Default Java
Private Build-1.8.0_252-8u252-b09-1~18.04-b09

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_252-8u252-b09-1~18.04-b09

javadoc
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2083/3/artifact/out/branch-javadoc-hadoop-hdfs-project_hadoop-hdfs-jdkUbuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.txt

javadoc
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2083/3/artifact/out/branch-javadoc-hadoop-tools_hadoop-aws-jdkUbuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.txt

checkstyle
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2083/3/artifact/out/diff-checkstyle-root.txt

whitespace
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2083/3/artifact/out/whitespace-eol.txt

javadoc
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2083/3/artifact/out/patch-javadoc-hadoop-hdfs-project_hadoop-hdfs-jdkUbuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.txt

javadoc
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2083/3/artifact/out/patch-javadoc-hadoop-tools_hadoop-aws-jdkUbuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.txt

unit
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2083/3/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2083/3/testReport/

asflicense
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2083/3/artifact/out/patch-asflicense-problems.txt

Max. process+thread count
4050 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs hadoop-tools/hadoop-aws U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2083/3/console

versions
git=2.17.1 maven=3.6.0 findbugs=4.0.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.


Bump to v3.0.0-beta.1

Bump to v3.0.0-beta.1

Codecov Report

Merging #1480 into master will increase coverage by 0.26%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1480      +/-   ##
==========================================
+ Coverage   67.26%   67.52%   +0.26%
==========================================
  Files         158      158
  Lines       15383    15383
==========================================
+ Hits        10347    10387      +40
+ Misses       4102     4075      -27
+ Partials      934      921      -13

Impacted Files
Coverage Δ

pkg/metricutil/metricutil.go
90.62% <0%> (-9.38%)
:arrow_down:

client/client.go
68.29% <0%> (+0.23%)
:arrow_up:

server/cluster_info.go
85.62% <0%> (+0.41%)
:arrow_up:

server/cluster.go
75.6% <0%> (+0.54%)
:arrow_up:

server/leader.go
86.55% <0%> (+0.84%)
:arrow_up:

server/core/kv.go
78.26% <0%> (+1.44%)
:arrow_up:

server/region_syncer/client.go
79.74% <0%> (+2.53%)
:arrow_up:

server/region_syncer/server.go
81.89% <0%> (+3.44%)
:arrow_up:

server/schedule/basic_cluster.go
92.45% <0%> (+3.77%)
:arrow_up:

server/namespace_cluster.go
88.31% <0%> (+3.89%)
:arrow_up:

... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 09aa89e...fe81113. Read the comment docs.

/rebuild
/run-unit-test


Improve Rule description!

When you will improve the documentation to include better descriptions at the rules? Having a rule with a description Rule 981312 doesn't help to know what it does! Enabling all rules have a huge impact on WAF performance and we need to know what exactly each rule does in order to fine tune it.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: f9c5b784-df0f-30cc-1547-bb4de751b7de
Version Independent ID: 8434d925-968a-ceea-e1f6-56d7816f7b3d
Content: Azure Application Gateway web application firewall CRS rule groups and rules
Content Source: articles/application-gateway/application-gateway-crs-rulegroups-rules.md
Service: application-gateway
GitHub Login: @vhorne
Microsoft Alias: victorh

@rodrigoffonseca Thanks for the feedback! I have assigned the issue to the content author to evaluate and update as appropriate.

@rodrigoffonseca, thanks for the feedback. I'll investigate...
#in-progress

any update about it?

@rodrigoffonseca
The CRS article has been updated. Should be live in a few hours.

#please-close

@rodrigoffonseca We will now proceed to close this thread. If there are further questions regarding this matter, please tag me in your reply. We will gladly continue the discussion and we will reopen the issue.


use self.nchannels such that it is defined

User description
fixes an error in AudioStretch.save

PR Type
Bug fix

Description

Fixed an error in the save_mp3 method of the AudioStretch class by replacing nchannels with self.nchannels.
Ensures that the self.nchannels attribute is used consistently within the method.

Changes walkthrough 📝
Relevant filesBug fix

stretch.pyFix undefined variable error in `save_mp3` method

src/audiostretchy/stretch.py
Replaced nchannels with self.nchannels in save_mp3 method.  Ensures self.nchannels is used consistently.

+1/-1

💡 PR-Agent usage:
Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

oh it seems #8 already fixes this. I'll leave this open for now seeing as it seems to have been auto-triaged unlike the other.


A small turbulent velocity script

Yields the following figures:

Thanks, @fjebaker - this looks great! @katebolam and @jj-auer you should be able to see the section of the code where you can put in a prescription for the turbulence.
This reminded me that perhaps §2 of Accretion disc turbulence and the X-ray power spectra of black hole high states (1995) by Nowak & Wagoner might be worth a read where they describe the "basics of disc turbulence".
However, I would recommend starting with a pretty simple description just to get things working and to make some nice plots for your presentation. You might also want to investigate how to use Gradus.jl with this new velocity field (we can talk about this at the next project meeting).
One possible Julia package for generating noise could be CoherentNoise.jl. Alternatively, you could write your own, which might become necessary to really understand how the noise is being generated and to ensure it has the desired properties. Any other suggestions, @fjebaker?
Happy for this to be merged once Kate and Joschka have had a look.


Update connector-dynamics-crm-office-365.md

fix the ms date

Microsoft authors of articles need to make updates through the private repository so the updates can be staged and validated by the current validation rules. After you review staging and fix all validation issues, you can add the sign-off comment to let the PR reviewers know the updates are ready to be merged.It's easy to access the private repo version of your articles in GitHub. Just add -pr to the URL, as follows:
Public repo URL: https://github.com/MicrosoftDocs/azure-docs
Private repo URL: https://github.com/MicrosoftDocs/azure-docs-pr
We have closed this pull request. Please resubmit the updates through the private repo. For more information, [see the contributor guide].(https://docs.microsoft.com/en-us/contribute/)


The benefits of filelists randomly shuffling?

Hi,
Thank you for this great project, and we're trying to implement a open-source Taiwanese text-to-speech synthesis service with this project.
We found the three lists (train, test, val) in filelists/ is randomly shuffling.
For example, the first few lines in ljs_audio_text_train_filelist.txt is
DUMMY/LJ001-0003.wav|...
...
DUMMY/LJ001-0001.wav|...
...
DUMMY/LJ001-0002.wav|...
...

Rather in order
DUMMY/LJ001-0001.wav|...
DUMMY/LJ001-0002.wav|...
DUMMY/LJ001-0003.wav|...
...

We wonder the reason of shuffling, thinking if we need to shuffle our corpus list too.
Is there any benefits to shuffle?

The idea behind shuffling is to not converge too early to the local minima and let model generalize better.

Ooh I see. :D
Some parts of the corpus may contains some similar sentence patterns or same words next to each lines, like talking about a particular topic.
With shuffling, we disrupt all the speech patterns in the corpus to avoid from the local minima.


(WIP) Design System Storybook: Tooltips

Summary
Tooltip component based on figma added to storybook.
Relevant Technical Choices

Takes dashboard tooltip and adds extra positions to it like can be found in existing editor tooltip
Adds functionality to show tooltip on relevant focus (like editor)
Uses a clip-path for tooltip tail because it's got curves

To-do

[x] Confirming proper background color with Sam

User-facing changes
None, storybook only
Testing Instructions
Go to storybook > designSystem > components > tooltip and see both dark and light mode tooltips. They should mirror figma.
Demo with keyboard focus

Demo with cursor

Right aligned with tail

Center aligned with tail

Updated tooltip colors as of 18/11/2020:

Addresses #4958

Main cases for the editor I'm worried about:

Tooltip width being too small when wrapping a small component
Tooltip exceeding bottom of scroll container and causing a layout shift

@littlemilkstudio these are great call outs, thanks!
I can check for the browser edges to adjust for placement. I was erring on the side of simple with the dashboard usage of the tooltips and avoiding the popup component that the tooltips in the editor are wrapped in, but i'm thinking that this should be used for this off the bat to avoid any regression, which adds some complexity that's unnecessary in the dashboard but allows for shared functionality with the editor so it's probably worth it.
I'm swapping this to draft and taking it back to in progress.

lol sorry accidentally closed the pull request for a sec there.
And yea if you can avoid any of the complexity that's in the current editor tooltip that'd be awesome! just wanted to point out some of the edge cases we've had to account for there


Issues with thepiratebay module

Hi again, I see you're using "thepiratebay": "^1.4.5" in this add-on.
Coincidentally, I've also played with this module in my free time lately. My fork is at https://github.com/jaruba/thepiratebay , I have not PRed my changes yet, and due to a lack of time to actually clean up the code, I'm uncertain when I will.
At the moment I believe it works far better then the original, due to proxy failures and other issues I believe I may have solved along the way. If you wish to test it, you can use
"thepiratebay": "https://github.com/jaruba/thepiratebay/tarball/master"

in your package.json.
Good luck with your add-on! :)

Thank you Jaruba, indeed there were issues with the original thepiratebay npm module. Adding yours seems to run ok. Let me know you PR your changes in the future.
Good luck to you too.


Cannot call method 'split' of null

Just a heads up lovely peeps at zurb. This breaks meteor 1.3 beta 4.
TypeError: Cannot call method 'split' of null
    at /tools/isobuild/linker.js:231:38
    at Array.forEach (native)
    at Function._.each._.forEach (/Users/sylar/.meteor/packages/meteor-tool/.1.1.11-modules.5.gs455p++os.osx.x86_64+web.browser+web.cordova/mt-os.osx.x86_64/dev_bundle/lib/node_modules

Can you let us know what plugin or method is breaking?

Also @juliancwirko can you offer any insight?

I test it for the first time and it seems that there are problems with npm and motion-ui. For now we have:
Npm.depends({
  'motion-ui': '1.1.0'
});
(...)
api.addFiles('.npm/package/node_modules/motion-ui/dist/motion-ui.css', 'client');
api.addFiles('.npm/package/node_modules/motion-ui/dist/motion-ui.js', 'client');
(...)

Now in 1.3 it probably can't be used like that.
We probably need another Meteor package for Motion-ui.  It should be simple to do because Motion-ui has its own repo. It will be much cleaner too.
Also I think this library should be optional and now it is required by some of the Foundation's plugins (as far as I know).
The second problem is that when I want to test it locally and I git clone all to the packages it will not run because in v1.3 Meteor can see also files which are not added in the addFiles rule and it can't manage it. I don't know exactly why. For me it looks like a bug in 1.3 beta version.
For now I think the best solution is to wait for official Meteor 1.3 release with official docs on how to use packages. We eventually can prepare Motion-ui meteor package, for example zurb:motion-ui then we can add it in the zurb:foundation-sites as a dependency so we don't have to use npm package here.
Also I'll try to ask on the Meteor forums why Meteor 1.3 sees all the files in the local package. This is quite important because Foundation for Meteor hasn't its own repo (with files only for Meteor) and testing it locally is very hard with Meteor 1.3.

... also I am not sure if we need Meteor package in Meteor 1.3 It will have standard Npm support, and maybe it will be simpler to just instal Foundation from Npm.

@juliancwirko I can get behind that.

:+1:
One addition though, Motion-UI is no longer required by any plugin as of Orbit getting a fallback for slide changing, and a bug fix for Toggler/Close Button.

Foundation and Motion-UI is on NPM registry. I wonder if Meteor 1.3 users will want to have Meteor packages with Foundation and Motion at all. Because they'll be able to just include it in the packages.json in the Meteor app and install it through Npm. I think we could wait for Meteor 1.3 and then decide. Or if you want there could be also Meteor package for both.

@juliancwirko It's not a huge hassle to keep publishing the package for now, and it's possible that there will be folks who can't upgrade to 1.3 right away, so we can keep it around.
But since we don't plan on doing anything Meteor-specific with the framework, transitioning users to npm makes sense.

It sounds reasonable. So we can publish zurb:motion-ui on the Atmospherejs.com and then modify package.js in zurb:foundation-sites We can remove Motion-UI at all. We can only add a week dependency (http://docs.meteor.com/#/full/pack_use) because now it is not needed and if people want Motion-UI they will be able to add it (by meteor add zurb:motion-ui) and it should play well with Foundation package and also as a standalone library.
Anyway there is a problem with local testing and not needed Scss files in Foundation repo. I mean when we clone Foundation to /packages folder in Meteor app. I've tested it with Stylus and there is the same problem. Meteor bundles files which we don't want to. We want only those which are added in addFiles so I think this is a bug in 1.3 beta. I'll try to find out what's going on.

@juliancwirko So if:

The problem is with our Atmosphere package when used in Meteor 1.3
Meteor 1.3 has first-class support for npm

Can we consider this a non-issue, given our recommendation to 1.3 users will be to use the npm package instead?

I think yes, but for now there are problems with .scss files imports from node_modules This is because Meteor has a specific build plugin for scss and also it is a community package (3rd party) so maybe it needs to be prepared too. I hope that till official Meteor 1.3 it will be working well. There are similar problems on the forum here
I'll try to do more research ASAP (for now I have 2:10 AM here ;) so probably in a few hours)

Alright, I'll close this for now, but do keep us in the loop. :) Since Meteor 1.3 is still in beta this is sort of out of our hands.

Ok there are two issues reported by me which we can track:

Style files imports from node_modules
Style files in local packages


Docs: the version should be ordered by number, where 3.10 > 3.9

See https://github.com/scylladb/scylla-monitoring/issues/1654

Closed by https://github.com/scylladb/scylla-monitoring/pull/1691


General dialog misaligned on larger screens

Steps to Reproduce
Click to open the general dialog on a large resolution monitor.
Expected Result
The general dialog to cover all of the underlying dApp window.
Actual Result
A small misalignment at the bottom of the general dialog, resulting in a small section of the underlying dApp window showing.
Additional Infos (Optional)

Done @taleldayekh fixed it


Remove workShownBy HAL Link (from 120)

Problem Description:
the workShownBy HAL Link is a duplicate of the workCarriedBy HAL Link
Expected Behavior/Solution:
workShownBy is removed, workCarriedBy behaves the same as current
Requirements:
Remove the workShownBy HAL Link. This will require that the frontend changes any pages that use workShownBy to use workCarriedBy instead
Needed for promotion:
If an item on the list is not needed, it should be crossed off but not removed.
- [ ] Wireframe/Mockup - Heather
- [ ] Committee discussions - Sarah
- [ ] Feasibility/Team discussion - Sarah
- [ ] Backend requirements - TBD

[ ] Frontend ticket from @kl762
- [ ] Questions
- List of questions for discussions. Answers should be documented within the issue.

UAT/LUX Examples:

https://lux-front-tst.collections.yale.edu/data/text/6aaa7701-02e7-4249-9bf5-faf1edc2c652

Dependencies/Blocks:
Related Github Issues:

https://github.com/project-lux/lux-frontend/issues/277

Related links:
Wireframe/Mockup:

@kamerynB - what is the FE ticket for this? and is there a UAT link where I can see the worksShownBy hal link is removed from the JSON?

Approved by UAT

Looks good in prod. Closing.


Please make mouse "forward" and "back" buttons bindable.

VSCode Version: 1.2.1
OS Version: All

Some mice have "forward" and "back" buttons in addition to the standard ones.   Would be nice to to be able to bind those to VSCode's navigateForward/navigateBack actions.

From my experience, this is highly dependant on one's mouse setup. Most mice I have seen have the default setup has those mouse buttons mapped to the keys: alt+left, alt+right for back, and forward respectively.
I have a Logitech G7000s which has 8 buttons addition button. Logitech ships it with software that lets you map what happens when you press a key. I would check your mouse's manufacture to see what they have available. If there's nothing of use, there's a bunch of software out there to help you do it manually.

Note that currently we only support these buttons on Windows. There they are bound to navigating in the history.

+1 for linux support.  I'd love to have the default behavior match that of other applications, or at least be customizable (e.g. browsers, eclipse).

it's driving me crazy when I follow a definition and then want to jump back to where I was. Right now it just changes the indent on the current line. (I've been loving and abusing this in slack lately :P)

@g5codyswartz for temporary fix you can use ctrl-o ctrl-i vim bindings with vim plugin. But having this on mouse too would be pretty sweet. (gd for jumping to definition)

Still not implement in Electron (see https://github.com/electron/electron/issues/6996) but this node module was made especially to tackle this issue.
Could it be used for VS-Code to solve this?

+1 for macOS too. Is there any reason this has to be platform-specific?

Be great to get this in Linux. I've managed to translate across all of my IntelliJ shortcuts except for this one (Microsoft ergonomic sculpt mouse).

Any updates on this? It is really that hard to make Mouse4, Mouse5 etc. buttons bindable in Linux?

Is there at least a general way of mapping mouse buttons to actions? Like if the button was just received as "button 4" or something?

For all: please look at the beginning of the thread! This issue cannot be solved (apparently) from the VSCode side, it is (currently) a limitation from electron!

If anyone looking for Linux solution: xbindkeys and xdotool can be used to trigger keyboard sequence on mouse clicks. This is what I'm using:
~/.xbindkeysrc
"xdotool key alt+Left"
	b:9
"xdotool key alt+Right"
	b:8

@skyjur That's a cute solution, but won't be satisfactory for most people I guess; nobody wants a special keyboard shortcut to be system-wise if it should only be used from within a single software!
(but maybe I'm just a little bit too picky…)

If you are using BetterTouchTool on Mac you can map the mouse shortcuts to keyboard shortcuts specific to VSCode application, like button4 to Cmd [ for navigating back in VSCode.
It works like a charm for me :)

It can't be hard to make these bindable in Linux, and especifically in Electron apps, since my back button works fine in Chrome/Chromium to begin with (and elsewhere, including PhpStorm).

@skyjur unfortunately that won't help Wayland users I'm afraid. This should totally be doable in the app without any hacks.

@luispabon

It can't be hard to [...] in Linux

😂

;)

@skyjur thanks for the suggestion. Although I'm not completely comfortable doing this, I cannot dispense with mouse-based navigation. I'd to switch the order for Logitech MX Master 2 on Ubuntu 16.04 though.
That is,
"xdotool key alt+Left"
	b:8
"xdotool key alt+Right"
	b:9

Seriously, this doesn't need any X hacks to work properly. Chrome and chromium work fine with mouse navigation buttons and have done so for years. Something's not wired up properly on the vscode codebase itself.

That it works in Chrome doesn't automatically mean that it'd work in Electron apps.
For what it's worth, the mouse buttons work in Slack and Spotify Windows clients (which are Electron apps AFAIK) but not in Linux clients.
The related Electron issue was already linked here https://github.com/electron/electron/issues/6996

I adopted your hacky linux workaround using xbindkeys, but I didn't want it messing with the normal mouse buttons so I did this:
"xdotool key --clearmodifiers alt+Left" 	control + b:9 "xdotool key --clearmodifiers alt+Right" 	control + b:8
I have to hit control to navigate using the buttons, but my finger is usually there since I control click to follow functions anyway. Such a silly minor thing to support the navigation buttons, but was driving me nuts.

Is there a way to disable the back and forward mouse buttons from navigating on Windows, or are disabling these buttons tied to the electron issue mentioned above?

As other's have mentioned (at least on Windows), I can go into my mouse's software configuration (in my case Logitech's SetPoint Settings software), and assign a keystroke assignment to the buttons. In my case I reassigned the back button to 'Alt+Left' for VS Code. The cool thing is that now navigates backward in code location as I desired, yet also still retains native functionality around the rest of the OS like in the browser still allowing it to go back in the history. Kind of gives me the best of both worlds.

Any news on this issue? All software editors that I use in Linux do support out of the box forward-back navigation with the forward-back buttons of the mouse. Why wouldn't VS Code do the same?

@JoseFMP because VSCode is written in Electron and electron doesn't support this within the window by default. Would love to see this adapted in VSCode for Linux as well.

Meanwhile I was able to configure it using xbindkeys and xdotool as @aapocketz mentioned above. Though I have mines set without the CTRL key:
"xdotool key --clearmodifiers control+alt+minus"
	b:8
"xdotool key --clearmodifiers control+shift+minus"
	b:9

xbindkeys reference: http://xahlee.info/linux/linux_xbindkeys_tutorial.html

The electron version of this bug has been closed as there already being a way to achieve mouse navigation functionality with electron. https://github.com/electron/electron/issues/6996#issuecomment-423873660
Could this be implemented in VSCode as well?
Please understand that this is a severely annoying issue, given that it's a standard and habituated functionality in desktop applications. There should be no need for user configuration or shady workarounds, it should work by default.

super annoying that this doesn't work, and working around with xbindkeys breaks back/forward in the other apps that do listen correctly for the mouse buttons, not to mention that wayland is quickly becoming standard

I'm in fact suprised that code vscode, so popular and feature packed editor requires to use xbindkeys hacks to provide mouse-buttons navigation...

Any news on this issue? i.e. it was closed because of another issue? but the other issue has no content at all.

If you are using BetterTouchTool on Mac you can map the mouse shortcuts to keyboard shortcuts specific to VSCode application, like button4 to Cmd [ for navigating back in VSCode.
It works like a charm for me :)

You've changed my life!

I've subscribed to this issue just to learn when it'll be fixed, and not for 100 ways to break your forward/backward mouse buttons :crying_cat_face:

Has anyone tried out this extension, sounds good, I know it's not out of the box native, but if it fixes the problem I say use it! :)
https://marketplace.visualstudio.com/items?itemName=SamHarwell.MouseNavigation

I've started trying to use the following which seems to work in many other programs like slack and web browsers.

backwards: ctrl + [
forwards ctrl + ]

I know it doesn't answer the feature request/bug and I still have issues switching between different OS where my mouse works and doesn't -- I'm just too used to navigating with it, it's just convenient. Currently it works on Windows out of the box if I recall correctly. The only way my mouse works on Mac is because it's a Razer and I have to use the software to remap Mouse4 and Mouse5 to "forward" and "backwards" actions. So far I haven't had much luck on Linux unfortunately, but I need to try the methods outlined here, but it sounds like it removes original key functionality unfortunately :[

I took a deep dive into the land of modding x, which I know isn't the full fix we're looking for but the bandaid. At this point I feel defeated; I really thought finding those navigation keys would work : [ I also know I'll just live with this fix and probably never look back.
I was really hoping the following from my research would work using XF86Back and XF86Forward. It worked fine in browsers, but I got no response out of the box with VSCode in the editor like Windows OS works fine with. I tried to bind it in the keyboard settings for giggles. Interestingly enough it did recognize the key, but it didn't actually map to a known VSCode key so it came up as "unknown" which showed the following when you hovered it: code: BrowserBack, keyCode: 166, key: BrowserBack => UI: unknown, user settings: unknown, dispatch: null
I'm not sure if there's another button hiding out there that does this as this is similar to what I have to do in Mac with my Razer mouse. From my twenty tabs I have open I haven't seen anything else it seems : . Maybe someone still has an old keyboard with the forward/back buttons that can log the button that it sends if it normally works for them in VSCode? I imagine it will just be those XF86Back/Forward buttons though.
What I hoped worked
~/.xbindkeysrc
"xdotool key XF86Back"
  b:8
"xdotool key XF86Forward"
  b:9

What does end up working
This is honestly just synonymous to using the arrow keys as well unfortunately. For now since all I do is browse the internet and code this will work for me.
Dependencies
I believe mac has the same brew installs from what I saw.
sudo apt install xbindkeys xdotool

~/.xbindkeysrc
"xdotool key ctrl+bracketleft"
  b:8
"xdotool key ctrl+bracketright"
  b:9

Reload .bindkeysrc
xbindkeys --poll-rc

Ultimately...
We just need VSCode to pick up on these, but that seems to be an issue with Electron that they don't want to fix. Sorry for the spam here.

Don't read past here... unless you want the pain I had.
Research Dump
AutoKey/AutoHotKey Road...
The irony is that they aren't anywhere near parity for implementations x'D
I thought maybe using an AutoHotKey variation for Linux would remap the mouse properly. It seemed to be overkill and not what I wanted.

https://askubuntu.com/questions/609033/how-to-install-autohotkey-in-ubuntu
https://code.google.com/archive/p/autokey/
https://www.youtube.com/watch?v=4KV_B6dBFHA

I was hoping to do something like this From AutoHotkey. I'm not sure if these Browser Back/Forward are the same as the XF86Back/Forward keys I found, but I would have to assume so.
XButton1::Browser_Back
XButton2::Browser_Forward

https://autohotkey.com/board/topic/98621-mouse-button-4-5-to-altshift/
https://autohotkey.com/docs/KeyList.htm
https://autohotkey.com/board/topic/19568-assigning-multiple-keys-to-one-key/

I even considered if I needed to bind both?

Hop on the Linux Waggon Fully

https://chrisjean.com/navigate-in-ubuntu-nautilus-using-the-mouse/

Fantastic writeup!

http://xahlee.info/linux/linux_xvkbd_tutorial.html
http://xahlee.info/linux/linux_show_keycode_keysym.html

xev is super useful!

http://wiki.linuxquestions.org/wiki/List_of_Keysyms_Recognised_by_Xmodmap

Nothing in here comes up with forward or backward

https://askubuntu.com/questions/24412/disable-xf86back-and-xf86forward-browser-back-forward-on-lenovo-thinkpad

Now we're onto something with this shenanigan browser back/forward buttons!
xmodmap looks interesting
We now also know the keycodes for XF86Back XF86Forward is 166 and 167

http://www.streppone.it/cosimo/blog/2011/02/disable-evil-page-backforward-keys-on-a-lenovo-t500-thinkpad/

Is this the same guy?! Same laptop it seems lol.

https://wiki.archlinux.org/index.php/xmodmap#Swapping_mouse_buttons

Deeper dig into xmodmap

https://cgit.freedesktop.org/xorg/proto/x11proto/tree/XF86keysym.h

Now this is the keylist I've been longing for. Interesting vendor keys.
I could only find the XF86XK_Back/Forward when searching for forward back browser

https://wiki.archlinux.org/index.php/Mouse_buttons#Thumb_Buttons_-_forward_and_back

HUGE wealth of knowledge ⭐

Worth checking out the table of contents https://wiki.archlinux.org/index.php/Mouse_buttons

https://www.archlinux.org/packages/?name=xautomation

Searching packages and differences between them as well as sizes...
https://www.archlinux.org/packages/community/x86_64/xautomation/
https://www.archlinux.org/packages/community/x86_64/xdotool/

https://www.semicomplete.com/projects/xdotool/
https://github.com/jordansissel/xdotool
https://wiki.archlinux.org/index.php/Keyboard_input#Identifying_keycodes_in_Xorg
https://wiki.archlinux.org/index.php/Xbindkeys
PS: Holly crapple... :sigh:

An extension to what @ctsstc wrote:
Instead of using "ctrl+bracketleft" and "ctrl+bracketright" I would recommend rebinding back and forward in vscode to "alt+Left" and "alt+Right".
This has the big advantage that is this combination is also used by chrome so that the mouse buttons will keep working as expected for that as well.
"xdotool key alt+Left"
  b:8

"xdotool key alt+Right"
  b:9

Frankly, this is inexcusable because their competitors have this working on OSX. I consider it a showstopping bug, but whatever.
Hopefully, this helps everyone though. I got this work with Sensible Side Buttons (free).
https://sensible-side-buttons.archagon.net/
Get that, which maps Forward and Back to swipe left and swipe right respectively. Once you have that, go to your settings in VS code and look for the swipe settings. Turn them all on.
Once that's set you should be good to go.
I refuse to pay 10 dollars for what should be essential functionality.

@jmcadams-r7 A "showstopping bug"? Come on man, take a step back and rethink that. There are multiple workarounds in the meantime, as you yourself have found, so how would this be a showstopper?

No...I'm sticking to my guns on that one...This is Microsoft. It's not some independent 3rd party putting together a college research project. The competition figured this one out at least a year ago. I also don't consider making users download 3rd party paid software (better touch bar) a valid "work around."
I don't know how anyone thinks basic navigation isn't important. I guess if I were working on small 50ish lines of code one-offs, it wouldn't be a big deal. But any code base of moderate complexity requires that the developers jump around between files, which makes this a pretty critical feature.
I shrug, either fix bugs like this or keep pushing developers to other IDEs.

FYI there are keyboard shortcuts for these actions (for me on Linux it's Alt+- for workbench.action.navigateBack and Alt+Shift+- for workbench.action.navigateForward), so it's not like it's impossible to navigate around. I've just been using those shortcuts for now, and consider mouse support a nice-to-have.

Sure this is backed by MS, but it doesn't cost you anything while other IDEs can, this isn't directly making them any money to have a dedicated team that they've put on it, and it's open source so we can make the changes ourselves, or continue using bandaids for the time being. Sure it would be nice to see this make it onto a backlog/roadmap though.

That's all fine, but their indifference on quality of life things like this for the development community is why *nix is taking off as the dev platform of choice. I feel like I'm one of the last MS fanboys, and things like this are why.

@jmcadams-r7 @ctsstc @JoshMcCullough you're all correct...
On the one hand, it's not a big deal when coming from small editors and small projects.
But use IntelliJ for a while and get used to the Ctrl-Click and mouse-back navigation workflow, and going to Code to do a bit of Angular is very jarring.

Electron has added support for Linux to access app-command events (back/forward) for a while now:

electron/electron#15441
https://github.com/electron/electron/blob/master/docs/api/browser-window.md#event-app-command-windows-linux

This is related to #3130.

This is what i did, if someone is looking for a solution :)
To install:
sudo apt-get install xbindkeys
To kill process:
killall xbindkeys
To activate config:
xbindkeys -f ~/.xbindkeysrc
Run to check names for keys and mouse events:
xev
Create/Edit your config file:
nano ~/.xbindkeysrc
"xte 'keydown Control_L' 'keydown Shift_L' 'key minus' 'keyup Control_L' 'keyup Shift_L'"
        b:9
"xte 'keydown Control_L' 'keydown Alt_L' 'key minus' 'keyup Control_L' 'keyup Alt_L'"
        b:8

This is what i did, if someone is looking for a solution :)

@robba86 worked great for me in Fedora too. Thank you!

Back in December there was an update in electron to finally fix the navigation on linux.
When is VSCode incorporating that change?

Back in December there was an update in electron to finally fix the navigation on linux.
When is VSCode incorporating that change?

This electron pullRequest is mentioned in https://github.com/electron/electron/releases/tag/v5.0.0-beta.1
According to the next release plan for vscode https://github.com/Microsoft/vscode/issues/71830 they referred upgrading to electron 4.0.
My guess is that it will come to vscode when electron releases 5.0 and vscode upgrades to 5.0. So it will take some time :/

2K19... still no mouse button navigation support in VSCode :)

Eh. I went to JetBrains. It's not worth waiting for MS to fix this stuff.

Since there is no solution yet there is another small hack that can be used together with the xbindkeys method that's been mentioned to make sure you can still use back/forward everywhere else.
First you point to other scripts in your .xbindkeysrc (replace buttons/folders as necessary)
".vscode/vscode_back.sh"
    b:8

".vscode/vscode_fwd.sh"
    b:9

Then in those scripts, you detect the active window and only change if it's vscode. This one is for back so you can change the key to XF86Forward for forward.
#!/bin/bash
W=`xdotool getactivewindow`
S1=`xprop -id ${W} |awk '/WM_CLASS/{print $4}'`
S2='"Code"'
if [ $S1 = $S2 ]; then
   xdotool key ctrl+alt+minus
else
   xdotool key XF86Back
fi

It would still be nice to eventually have the back button natively supported by VS Code though since this still has a side effect. Normally the back/forward button press (at least for my mouse on Ubuntu 18.04) went to the window under the pointer but with this method it always goes to the active window which could be annoying for people who keep multiple apps visible at the same time.

Note that currently we only support these buttons on Windows. @bpasero

i'm used VSCode and buttons 'MOUSE4','MOUSE3' worked for "go back/forward".
but i switched to VSCode-Insiders and that feature is gone!

I found a fix...use JetBrains on OSX...I wouldn't have tried it had they fixed this issue, but it's a million miles better than VS Code at this point. MS is really dropping the ball lately.

@SupinePandora43 I just installed version 1.36.0 of VSCode, and it does appear that it was indeed broken in this release. Hopefully they can fix this soon because I use that feature extensively and would hate to revert to using alt+left/right.

Please see https://github.com/microsoft/vscode/issues/71318 for support of mouse buttons 4 and 5 for navigation purpose. The recent Electron update broke this feature on Windows it seems, but my fix tries a different approach and should work on Windows and Linux going forward.

+1 for linux support.
By the way, thanks always. vscode is awesome.

If people want to give the following builds a try to see if mouse buttons back/forward are working on Windows and Linux:
Here are builds to try it out:

Windows: download
Linux: download

If people want to give the following builds a try to see if mouse buttons back/forward are working on Windows and Linux:
* Windows: [download](https://az764295.vo.msecnd.net/insider/28988230cd15af27b2da8fa895315eacb1243e79/VSCode-win32-x64-1.37.0-insider.zip)

* Linux: [download](https://az764295.vo.msecnd.net/insider/28988230cd15af27b2da8fa895315eacb1243e79/code-insider-1562303537.tar.gz)

works great here with Ubuntu 18.04

If people want to give the following builds a try to see if mouse buttons back/forward are working on Windows and Linux:

Windows: download
Linux: download

Just tested on Ubuntu 16.04 and Ubuntu 18.04. Works! :tada:

Yeah, seems to work in latest vscode-insiders!

It now works with 1.36.1 out of the box.
I think we can close this issue now.
(Tested on Arch Linux)

@k0rn1 also works on windows
Version: 1.37.0-insider (user setup)
Commit: 46cc0a1670b7047e610aaef1bf84f1190802e9ec
Date: 2019-07-11T05:39:48.279Z
Electron: 4.2.5
Chrome: 69.0.3497.128
Node.js: 10.11.0
V8: 6.9.427.31-electron.0
OS: Windows_NT ia32 6.1.7601

Working on 1.36.1 in Ubuntu 19.04 via snap.

I'm using 1.36.1 on OSX and still cannot use my mouse button to move foward/backward. Will it be supported in the next version ? Or just for Linux/Windows ?

@Happin3ss

lightweight editor

for reasons implicit to me, vscode is not a lightweight code editor for me, because when I want to create something more (not just change ~ 2 files), everything starts to slow down! This, and the fact that Java support does not work well, I have to use for Java android Studio

@Happin3ss

lightweight editor

for reasons implicit to me, vscode is not a lightweight code editor for me, because when I want to create something more (not just change ~ 2 files), everything starts to slow down! This, and the fact that Java support does not work well, I have to use for Java android Studio

Well It seems you are in the same boat with me. My current project use a Java spring server as back-end services and a React app as client. Whenever have do deal with both, Intellij IDEA is the only option to go. But most of the times I just have to work with React app so I prefer VSCode much more than.
A few reasons behind it included:

VSCode setting syncs really well cross-platform. I'm using OSX at my work but a windows station at home.
Rich of themes and colorschemes
I'm getting a very serious font blurring issue with IDEA when use it on Windows (which doesn't happen with any other IDE/Code Editor). The issue was created on Jetbrains youtrack a couple of months ago and vote up many times by many users but they still cannot figure out where is the root cause and also cannot provide any workaround.

a trick on Mac OS Mojave 10.14.6
paste this in keybindings.json
https://gist.github.com/jihuichoi/42cf86b3610266bd7e35e2f9737b1293

a trick on Mac OS Mojave 10.14.6, vscode 1.37.1.
It works perfectly for me.
paste this in keybindings.json
https://gist.github.com/jihuichoi/42cf86b3610266bd7e35e2f9737b1293
Version: 1.37.1
Commit: f06011a
Date: 2019-08-15T16:16:34.800Z
Electron: 4.2.7
Chrome: 69.0.3497.128
Node.js: 10.11.0
V8: 6.9.427.31-electron.0
OS: Darwin x64 18.7.0

Didn't work for me. I also had a quick look in the script and I will be very surprise If it can work :)

Didn't work for me. I also had a quick look in the script and I will be very surprise If it can work :)

I guess it might be different depends on the model of the mouse.
Here's how I made it works. you can find yours, too.

find out what's happening when you click extra buttons of your mouse.
in my case, indent and outdent.

find the keys which are related 1. actions from default keybindings.json
for me,  cmd+[, cmd+]

finally, remove keys from indent,outdent and bind cmd+[,] to back/forward
I overwrote them using keybindings.json

If people want to give the following builds a try to see if mouse buttons back/forward are working on Windows and Linux:

Windows: download
Linux: download

What about macOS?

I encourage people using macOS interested in this matter to report an issue to Chrome (http://crbug.com) that mouse buttons 4 and 5 can be detected on macOS platform. That is the only way moving forward on this issue, there is nothing VSCode can do.

I encourage people using macOS interested in this matter to report an issue to Chrome (http://crbug.com) that mouse buttons 4 and 5 can be detected on macOS platform. That is the only way moving forward on this issue, there is nothing VSCode can do.

Pardon me If I misunderstood. This issue/requirement is about allowing to use mouse forward and back for navigation - That's all from user perspective.
And in order to implement this feature, VSCode needs chromium support to do some detection. Technically, I think the one who supposed to implement this feature (VSCode team ? Because I think you already have some idea in mind) is the one who should do the reporting (or maybe feature request) to chromium team. I believed it would potentially open technical discussion how/why, which people not invoked in have no idea about and cannot give detail explanation.
Imagine that I report the issue to chromium team then got the question why you need it ? Am I suppose to say "to support VSCode to do xyz?" :(

Easy: https://bugs.chromium.org/p/chromium/issues/detail?id=1014938

Easy: https://bugs.chromium.org/p/chromium/issues/detail?id=1014938
Now if it is not too much work for people to click the upvote on that issue at least...

Thank you :) Just have a look on it and upvote. Hope we can get the response soon :)

VSCode insiders has resumed with Electron 7. To benefit from this change you can give our preview releases a try from: https://code.visualstudio.com/insiders/

If you are using BetterTouchTool on Mac you can map the mouse shortcuts to keyboard shortcuts specific to VSCode application, like button4 to Cmd [ for navigating back in VSCode.
It works like a charm for me :)

Work with me.
Mac 10.14.6
VSCode 1.42.0

It's glorious! Thank you!
1.43.0-insider
OS 10.15.2

👍 It works !
But, I have SensibleSideButtons to have theses buttons working on other programs like Firefox, and I have to disable it.
Now it's working in vscode and no more in Firefox.. 😅

I have upgraded to 1.43 stable version on mac, but my 4/5 buttons still doesn't seem to work... Do I need to turn on some settings? Thanks!

I have upgraded to 1.43 stable version on mac, but my 4/5 buttons still doesn't seem to work... Do I need to turn on some settings? Thanks!

If you have SensibleSideButtons running on your mac, try to turn it off. I tested the this feature is only works with SensibleSideButtons disabled, so I have to choose between browser navigation or VSCode navigation.

I have upgraded to 1.43 stable version on mac, but my 4/5 buttons still doesn't seem to work... Do I need to turn on some settings? Thanks!

If you have SensibleSideButtons running on your mac, try to turn it off. I tested and this feature only works with SensibleSideButtons disabled, so I have to choose between firefox + system navigation or VSCode navigation.
Seems that because of the SensibleSideButtons bind the Mouse 4 and 5 to the swipe left/right gestures so It doesn't work. I'm not sure if we are able to make swipe left/right gestures of Mac to be navigate-able in VSCode.

Thanks for telling me this. I don't have that software running, but indeed I am using Logitech Options driver, which might rebind my 4/5 keys to some other keys called "forward/back". Although it works on chrome, it doesn't work in vscode. After killing the driver deamon, the 4/5 keys work in vscode, but other custom keys dead... So I have to live with Logi driver. Don't know why it functions well on Windows, hope this could be fixed on mac soon!

@JimAmuro same - I am using a Logi ergo mouse with Logi Options and the daemon running and I do not get back and forward working ...
@bpasero Is there a setting in VSCode that would detect this context and enable this to work with logi options?

No there is no setting and I doubt Electron would provide the APIs for us to detect this. If you feel strong about it, ask for it over at https://github.com/atom/electron
I suggest we stop discussion here and move to new issues as needed to reduce the spam for people subscribed to this otherwise closed issue.

On macOS using a Logitech mouse with the Logi Options driver, I only needed to rebind the keystrokes that the Mouse buttons 4/5 (sidebar buttons) perform and which keystrokes the VS Code workbench.action.navigateBack and workbench.action.navigateForward actions are bound to.

I bound the mouse "backward" button and the VS Code navigate backward action to Cmd+LeftArrow.
I bound the mouse "forward" button and the VS Code navigate forward action to Cmd+RightArrow.

I chose those keybindings because they continued to navigate forward/backward in Chrome for me, too. Felt like a win-win-win scenario.
Screenshot of VS Code keyboard shortcuts on top with the Logi Options window on bottom

macOS Catalina: 10.15.3
Logitech Mouse: M510
Logi Options: 8.10.64 (driver for the mouse)
VS Code Version: 1.43.0
Commit: 78a4c91400152c0f27ba4d363eb56d2835f9903a
Date: 2020-03-09T19:34:44.548Z
Electron: 7.1.11
Chrome: 78.0.3904.130
Node.js: 12.8.1
V8: 7.8.279.23-electron.0
OS: Darwin x64 19.3.0


Don't cross-compile cargo2nix to musl by default

Changed

Specify crossSystem ? null for the cargo2nix Rust crate.

Since the cargo2nix crate cannot even compile under musl on Linux anyway, thanks to the nix-prefetch-git dependency added in #62, it no longer makes sense to recommend cross-compiling to that platform by default. Instead, we should default to compiling for the system and libc of the build platform, where the command is likely to be running anyway.
This is not a breaking change for downstream users of the cargo2nix overlay. It also should not affect future installations of the cargo2nix CLI tool because the README already recommended installing with --arg crossSystem null anyway.
Fixes #88.

It's going to take a while for the Nix cache in CI to repopulate, so I'm going to have to keep retriggering CI until the build completes.

Also, we should extend #69 to include some examples of cross-compiling crates to musl to verify that support for that target still works, even when we are no longer dogfooding it with cargo2nix itself.

Looks like build jobs are getting killed in roughly the same location in the logs every time. I don't think the Nix build itself is failing because there is no "cannot build derivation" message at the very end, and the build always ends abruptly with a Received "killed" signal message. Need to investigate further.

Ah, it might be a Docker related memory issue.

I might have to build cargo2nix locally, push the artifacts to Cachix, and re-trigger CI one more time.

CI should be fixed in #90, so I'll get that PR merged first. I'll also populate the new Cachix cache with glibc build artifacts as well so this PR completes smoothly.

Rebased branch after fixing CI caching with #90. Kindly re-requesting a review!


[Task] Add database

This database will eventually store the following*:

vectors
lists
user state
cached api requests
...
*This task is just for adding a database to the project and adding a vectors collection that is used to retrieve the active vectors instead of packages/nextjs/components/impact-vector/ImpactVectors.ts. No need to add any other collections

I am thinking MongoDB but only because it is familiar to me. Feel free to suggest a better storage solution if you know of one and we can discuss.

I have the time to take this one unless someone else wants it.
I don't have much experience with MongoDB but would love an excuse to gain some.

Ok I'll hop into this today