Cannot flash STM32WL55JC

Describe the bug
Hi,
I am trying to flash stm32 using the cargo flash tool, but for some reason it cannot connect to the chip and I am not sure what is the problem here. I can flash the board no problem using stm32cubeprogrammer. I got NUCLEO-WL55JC2 board.
To Reproduce
Steps to reproduce the behavior:

Connect the board
Try running cargo flash --relase --chip stm32wl55jcix --connect-under-reset --log=DEBUG
See error in log

Expected behavior
Expect board to be flashed
Stacktrace
   Flashing /home/adejewski/Projects/smart-postbox/smart-postbox/target/thumbv7em-none-eabi/release/smart-postbox
       DEBUG probe_rs::config::registry > Searching registry for chip with name stm32wl55jcix
       DEBUG probe_rs::config::registry > Exact match for chip name: STM32WL55JCIx
        WARN probe_rs::config::target   > Using custom sequence for ARMv7 STM32WL55JCIx
        INFO tracing::span              > list_all;
        INFO tracing::span              > list_cmsisdap_devices;
       DEBUG probe_rs::probe::cmsisdap::tools > Searching for CMSIS-DAP probes using libusb
       DEBUG probe_rs::probe::cmsisdap::tools > Found 0 CMSIS-DAP probes using libusb, searching HID
       DEBUG probe_rs::probe::cmsisdap::tools > Found 0 CMSIS-DAP probes total
        INFO tracing::span                    > list_stlink_devices;
        INFO tracing::span                    > list_jlink_devices;
       DEBUG jaylink                          > libusb <IP_ADDRESS>24
       DEBUG jaylink                          > libusb has capability API: true
       DEBUG jaylink                          > libusb has HID access: true
       DEBUG jaylink                          > libusb has hotplug support: true
       DEBUG jaylink                          > libusb can detach kernel driver: true
        INFO tracing::span                    > list_espjtag_devices;
        INFO tracing::span                    > open;
       DEBUG probe_rs::probe::cmsisdap::tools > Attempting to open 0483:374e in CMSIS-DAP v1 mode
       DEBUG probe_rs::probe::stlink::usb_interface > Acquired libusb context.
       DEBUG probe_rs::probe::stlink::usb_interface > Aquired handle for probe
       DEBUG probe_rs::probe::stlink::usb_interface > Active config descriptor: ConfigDescriptor { bLength: 9, bDescriptorType: 2, wTotalLength: 128, bNumInterfaces: 4, bConfigurationValue: 1, iConfiguration: 4, bmAttributes: 128, bMaxPower: 250, extra: [] }
       DEBUG probe_rs::probe::stlink::usb_interface > Device descriptor: DeviceDescriptor { bLength: 18, bDescriptorType: 1, bcdUSB: 512, bDeviceClass: 239, bDeviceSubClass: 2, bDeviceProtocol: 1, bMaxPacketSize: 64, idVendor: 1155, idProduct: 14158, bcdDevice: 256, iManufacturer: 1, iProduct: 2, iSerialNumber: 3, bNumConfigurations: 1 }
       DEBUG probe_rs::probe::stlink::usb_interface > Claimed interface 0 of USB device.
       DEBUG probe_rs::probe::stlink::usb_interface > Succesfully attached to STLink.
       DEBUG probe_rs::probe::stlink                > Initializing STLink...
       DEBUG probe_rs::probe::stlink                > Current device mode: Jtag
       DEBUG probe_rs::probe::stlink                > STLink version: (3, 10)
        INFO cargo_flash                            > Protocol speed 12000 kHz
       DEBUG tracing::span                          > Asserting hardware assert;
        INFO probe_rs::session                      > Custom reset sequences are not supported on ST-Link V3.
        INFO probe_rs::session                      > Falling back to standard probe reset.
       DEBUG probe_rs::probe                        > Asserting target reset
        INFO tracing::span                          > attach;
       DEBUG probe_rs::probe::stlink                > Current device mode: Jtag
       DEBUG probe_rs::probe::stlink                > Switching protocol to SWD
        INFO probe_rs::probe::stlink                > Target voltage (VAPP): 3.28 V
       DEBUG probe_rs::probe::stlink                > Successfully initialized SWD.
        INFO tracing::span                          > initialize;
        INFO probe_rs::architecture::arm::ap        > valid_access_ports; dp=Default
        INFO probe_rs::architecture::arm::ap        > read_ap_register; ap=0 register="IDR"
       DEBUG probe_rs::probe::stlink                > Opening AP 0
       DEBUG probe_rs::architecture::arm::ap        > Register read succesful
        INFO probe_rs::architecture::arm::ap        > read_ap_register; ap=1 register="IDR"
       DEBUG probe_rs::probe::stlink                > Opening AP 1
       DEBUG probe_rs::architecture::arm::ap        > Register read succesful
        INFO probe_rs::architecture::arm::ap        > read_ap_register; ap=2 register="IDR"
       DEBUG probe_rs::probe::stlink                > Opening AP 2
       DEBUG probe_rs::architecture::arm::ap        > Register read succesful
        INFO probe_rs::architecture::arm::ap        > read_ap_register; ap=0 register="IDR"
       DEBUG probe_rs::architecture::arm::ap        > Register read succesful
        INFO probe_rs::architecture::arm::ap        > read_ap_register; ap=0 register="BASE"
       DEBUG probe_rs::architecture::arm::ap        > Register read succesful
        INFO probe_rs::architecture::arm::ap        > read_ap_register; ap=0 register="BASE2"
       DEBUG probe_rs::architecture::arm::ap        > Register read succesful
        INFO probe_rs::architecture::arm::ap        > read_ap_register; ap=0 register="CSW"
       DEBUG probe_rs::architecture::arm::ap        > Register read succesful
       DEBUG probe_rs::architecture::arm::ap        > Writing register CSW, value=CSW { DbgSwEnable: 1, HNONSEC: 1, PROT: 6, CACHE: 3, SPIDEN: 0, _RES0: 0, MTE: 0, Type: 0, Mode: 0, TrinProg: 0, DeviceEn: 0, AddrInc: Single, _RES1: 0, SIZE: U8 }
        INFO probe_rs::architecture::arm::ap        > read_ap_register; ap=0 register="CSW"
       DEBUG probe_rs::architecture::arm::ap        > Register read succesful
       DEBUG probe_rs::architecture::arm::ap        > Writing register CSW, value=CSW { DbgSwEnable: 0, HNONSEC: 0, PROT: 2, CACHE: 3, SPIDEN: 0, _RES0: 0, MTE: 0, Type: 0, Mode: 0, TrinProg: 0, DeviceEn: 1, AddrInc: Single, _RES1: 0, SIZE: U32 }
       DEBUG probe_rs::architecture::arm::communication_interface > HNONSEC supported: false
       DEBUG probe_rs::architecture::arm::communication_interface > Device enabled: true
        INFO probe_rs::architecture::arm::ap                      > read_ap_register; ap=0 register="CFG"
       DEBUG probe_rs::architecture::arm::ap                      > Register read succesful
       DEBUG probe_rs::probe::stlink                              > AP ApAddress {
    dp: Default,
    ap: 0x0,
}: MemoryAp(MemoryApInformation { address: ApAddress { dp: Default, ap: 0 }, supports_only_32bit_data_size: false, debug_base_address:<PHONE_NUMBER>, supports_hnonsec: false, has_large_address_extension: false, has_large_data_extension: false, device_enabled: true })
        INFO probe_rs::architecture::arm::ap                      > read_ap_register; ap=1 register="IDR"
       DEBUG probe_rs::architecture::arm::ap                      > Register read succesful
        INFO probe_rs::architecture::arm::ap                      > read_ap_register; ap=1 register="BASE"
       DEBUG probe_rs::architecture::arm::ap                      > Register read succesful
        INFO probe_rs::architecture::arm::ap                      > read_ap_register; ap=1 register="BASE2"
       DEBUG probe_rs::architecture::arm::ap                      > Register read succesful
        INFO probe_rs::architecture::arm::ap                      > read_ap_register; ap=1 register="CSW"
       DEBUG probe_rs::architecture::arm::ap                      > Register read succesful
       DEBUG probe_rs::architecture::arm::ap                      > Writing register CSW, value=CSW { DbgSwEnable: 1, HNONSEC: 1, PROT: 6, CACHE: 3, SPIDEN: 0, _RES0: 0, MTE: 0, Type: 0, Mode: 0, TrinProg: 0, DeviceEn: 0, AddrInc: Single, _RES1: 0, SIZE: U8 }
        INFO probe_rs::architecture::arm::ap                      > read_ap_register; ap=1 register="CSW"
        WARN probe_rs::probe::stlink                              > send_jtag_command 242 failed: SwdApFault
       DEBUG probe_rs::probe::stlink                              > Current device mode: Jtag
        INFO cargo_flash                                          > Metadata {
    chip: Some(
        "\"stm32wl55jcix\"",
    ),
    probe: Some(
        "ST-Link V3",
    ),
    speed: Some(
        "12000",
    ),
    release: "0.18.0",
    commit: "crates.io",
}
       Error Connecting to the chip was unsuccessful.

  Caused by:
          0: An ARM specific error occured.
          1: The debug probe encountered an error.
          2: An error specific to a probe type occurred
          3: Command failed with status SwdApFault

Desktop (please complete the following information):

Linux (Ubuntu,)

Any hints, what might be wrong?

Your version seems to be outdated. Mind upgrading and reporting back? :)

Thanks for pointing it out, you are right, I installed cargo-flash instead of probe-rs, now I am on the latest version:
cargo flash --version
cargo-flash 0.21.1
git commit: crates.io

Unfortunately it didn't help, still the same issue. I attach the log below
    Flashing /home/adejewski/Projects/smart-postbox/smart-postbox/target/thumbv7em-none-eabi/release/smart-postbox
       DEBUG probe_rs::config::registry > Searching registry for chip with name stm32wl55jcix
       DEBUG probe_rs::config::registry > Exact match for chip name: STM32WL55JCIx
        WARN probe_rs::config::target   > Using custom sequence for ARMv7 STM32WL55JCIx
        INFO tracing::span              > list_all;
        INFO tracing::span              > list_cmsisdap_devices;
       DEBUG probe_rs::probe::cmsisdap::tools > Searching for CMSIS-DAP probes using libusb
       DEBUG probe_rs::probe::cmsisdap::tools > Found 0 CMSIS-DAP probes using libusb, searching HID
       DEBUG probe_rs::probe::cmsisdap::tools > Found 0 CMSIS-DAP probes total
        INFO tracing::span                    > list_stlink_devices;
        INFO tracing::span                    > list_jlink_devices;
       DEBUG jaylink                          > libusb <IP_ADDRESS>24
       DEBUG jaylink                          > libusb has capability API: true
       DEBUG jaylink                          > libusb has HID access: true
       DEBUG jaylink                          > libusb has hotplug support: true
       DEBUG jaylink                          > libusb can detach kernel driver: true
        INFO tracing::span                    > list_espjtag_devices;
        INFO tracing::span                    > open;
       DEBUG probe_rs::probe::cmsisdap::tools > Attempting to open 0483:374e in CMSIS-DAP v1 mode
       DEBUG probe_rs::probe::stlink::usb_interface > Acquired libusb context.
       DEBUG probe_rs::probe::stlink::usb_interface > Aquired handle for probe
       DEBUG probe_rs::probe::stlink::usb_interface > Active config descriptor: ConfigDescriptor { bLength: 9, bDescriptorType: 2, wTotalLength: 128, bNumInterfaces: 4, bConfigurationValue: 1, iConfiguration: 4,
 bmAttributes: 128, bMaxPower: 250, extra: [] }
       DEBUG probe_rs::probe::stlink::usb_interface > Device descriptor: DeviceDescriptor { bLength: 18, bDescriptorType: 1, bcdUSB: 512, bDeviceClass: 239, bDeviceSubClass: 2, bDeviceProtocol: 1, bMaxPacketSize
: 64, idVendor: 1155, idProduct: 14158, bcdDevice: 256, iManufacturer: 1, iProduct: 2, iSerialNumber: 3, bNumConfigurations: 1 }
       DEBUG probe_rs::probe::stlink::usb_interface > Claimed interface 0 of USB device.
       DEBUG probe_rs::probe::stlink::usb_interface > Succesfully attached to STLink.
       DEBUG probe_rs::probe::stlink                > Initializing STLink...
       DEBUG probe_rs::probe::stlink                > Current device mode: MassStorage
       DEBUG probe_rs::probe::stlink                > STLink version: (3, 10)
       DEBUG tracing::span                          > Asserting hardware assert;
        INFO probe_rs::session                      > Custom reset sequences are not supported on ST-Link V3.
        INFO probe_rs::session                      > Falling back to standard probe reset.
       DEBUG probe_rs::probe                        > Asserting target reset
        INFO tracing::span                          > attach;
       DEBUG probe_rs::probe::stlink                > Current device mode: MassStorage
       DEBUG probe_rs::probe::stlink                > Switching protocol to SWD
        INFO probe_rs::probe::stlink                > Target voltage (VAPP): 3.28 V
       DEBUG probe_rs::probe::stlink                > Successfully initialized SWD.
        INFO tracing::span                          > initialize;
        INFO probe_rs::architecture::arm::ap        > valid_access_ports; dp=Default
        INFO probe_rs::architecture::arm::ap        > read_ap_register; ap=0 register="IDR"
       DEBUG probe_rs::probe::stlink                > Opening AP 0
       DEBUG probe_rs::architecture::arm::ap        > Register read succesful
        INFO probe_rs::architecture::arm::ap        > read_ap_register; ap=1 register="IDR"
       DEBUG probe_rs::probe::stlink                > Opening AP 1
       DEBUG probe_rs::architecture::arm::ap        > Register read succesful
        INFO probe_rs::architecture::arm::ap        > read_ap_register; ap=2 register="IDR"
       DEBUG probe_rs::probe::stlink                > Opening AP 2
       DEBUG probe_rs::architecture::arm::ap        > Register read succesful
        INFO probe_rs::architecture::arm::ap        > read_ap_register; ap=0 register="IDR"
      DEBUG probe_rs::architecture::arm::ap        > Register read succesful
        INFO probe_rs::architecture::arm::ap        > read_ap_register; ap=0 register="BASE"
       DEBUG probe_rs::architecture::arm::ap        > Register read succesful
        INFO probe_rs::architecture::arm::ap        > read_ap_register; ap=0 register="BASE2"
       DEBUG probe_rs::architecture::arm::ap        > Register read succesful
        INFO probe_rs::architecture::arm::ap        > read_ap_register; ap=0 register="CSW"
       DEBUG probe_rs::architecture::arm::ap        > Register read succesful
       DEBUG probe_rs::architecture::arm::ap        > Writing register CSW, value=CSW { DbgSwEnable: 1, HNONSEC: 1, PROT: 6, CACHE: 3, SPIDEN: 0, _RES0: 0, MTE: 0, Type: 0, Mode: 0, TrinProg: 0, DeviceEn: 0, Add
rInc: Single, _RES1: 0, SIZE: U8 }
        INFO probe_rs::architecture::arm::ap        > read_ap_register; ap=0 register="CSW"
       DEBUG probe_rs::architecture::arm::ap        > Register read succesful
       DEBUG probe_rs::architecture::arm::ap        > Writing register CSW, value=CSW { DbgSwEnable: 0, HNONSEC: 0, PROT: 2, CACHE: 3, SPIDEN: 0, _RES0: 0, MTE: 0, Type: 0, Mode: 0, TrinProg: 0, DeviceEn: 1, Add
rInc: Single, _RES1: 0, SIZE: U32 }
       DEBUG probe_rs::architecture::arm::communication_interface > HNONSEC supported: false
       DEBUG probe_rs::architecture::arm::communication_interface > Device enabled: true
        INFO probe_rs::architecture::arm::ap                      > read_ap_register; ap=0 register="CFG"
       DEBUG probe_rs::architecture::arm::ap                      > Register read succesful
       DEBUG probe_rs::probe::stlink                              > AP ApAddress {
    dp: Default,
    ap: 0x0,
}: MemoryAp(MemoryApInformation { address: ApAddress { dp: Default, ap: 0 }, supports_only_32bit_data_size: false, debug_base_address:<PHONE_NUMBER>, supports_hnonsec: false, has_large_address_extension: false, has
_large_data_extension: false, device_enabled: true })
        INFO probe_rs::architecture::arm::ap                      > read_ap_register; ap=1 register="IDR"
       DEBUG probe_rs::architecture::arm::ap                      > Register read succesful
        INFO probe_rs::architecture::arm::ap                      > read_ap_register; ap=1 register="BASE"
       DEBUG probe_rs::architecture::arm::ap                      > Register read succesful
        INFO probe_rs::architecture::arm::ap                      > read_ap_register; ap=1 register="BASE2"
       DEBUG probe_rs::architecture::arm::ap                      > Register read succesful
        INFO probe_rs::architecture::arm::ap                      > read_ap_register; ap=1 register="CSW"
       DEBUG probe_rs::architecture::arm::ap                      > Register read succesful
       DEBUG probe_rs::architecture::arm::ap                      > Writing register CSW, value=CSW { DbgSwEnable: 1, HNONSEC: 1, PROT: 6, CACHE: 3, SPIDEN: 0, _RES0: 0, MTE: 0, Type: 0, Mode: 0, TrinProg: 0, De
viceEn: 0, AddrInc: Single, _RES1: 0, SIZE: U8 }
        INFO probe_rs::architecture::arm::ap                      > read_ap_register; ap=1 register="CSW"
       DEBUG probe_rs::architecture::arm::ap                      > Register read succesful
       DEBUG probe_rs::architecture::arm::ap                      > Writing register CSW, value=CSW { DbgSwEnable: 0, HNONSEC: 1, PROT: 0, CACHE: 3, SPIDEN: 1, _RES0: 0, MTE: 0, Type: 0, Mode: 0, TrinProg: 0, De
viceEn: 1, AddrInc: Off, _RES1: 0, SIZE: U32 }
       DEBUG probe_rs::architecture::arm::communication_interface > HNONSEC supported: true
       DEBUG probe_rs::architecture::arm::communication_interface > Device enabled: true
        INFO probe_rs::architecture::arm::ap                      > read_ap_register; ap=1 register="CFG"
       DEBUG probe_rs::architecture::arm::ap                      > Register read succesful
       DEBUG probe_rs::probe::stlink                              > AP ApAddress {
    dp: Default,
    ap: 0x1,
}: MemoryAp(MemoryApInformation { address: ApAddress { dp: Default, ap: 1 }, supports_only_32bit_data_size: false, debug_base_address:<PHONE_NUMBER>, supports_hnonsec: true, has_large_address_extension: false, has_
large_data_extension: false, device_enabled: true })
        INFO probe_rs::architecture::arm::ap                      > read_ap_register; ap=1 register="IDR"
       DEBUG probe_rs::architecture::arm::ap                      > Register read succesful
        INFO probe_rs::architecture::arm::ap                      > read_ap_register; ap=1 register="BASE"
       DEBUG probe_rs::architecture::arm::ap                      > Register read succesful
        INFO probe_rs::architecture::arm::ap                      > read_ap_register; ap=1 register="BASE2"
       DEBUG probe_rs::architecture::arm::ap                      > Register read succesful
        INFO probe_rs::architecture::arm::ap                      > read_ap_register; ap=1 register="CSW"
       DEBUG probe_rs::architecture::arm::ap                      > Register read succesful
       DEBUG probe_rs::architecture::arm::ap                      > Writing register CSW, value=CSW { DbgSwEnable: 1, HNONSEC: 1, PROT: 6, CACHE: 3, SPIDEN: 0, _RES0: 0, MTE: 0, Type: 0, Mode: 0, TrinProg: 0, DeviceEn: 0, AddrInc: Single, _RES1: 0, SIZE: U8 }
        INFO probe_rs::architecture::arm::ap                      > read_ap_register; ap=1 register="CSW"
       DEBUG probe_rs::architecture::arm::ap                      > Register read succesful
       DEBUG probe_rs::architecture::arm::ap                      > Writing register CSW, value=CSW { DbgSwEnable: 0, HNONSEC: 1, PROT: 0, CACHE: 3, SPIDEN: 1, _RES0: 0, MTE: 0, Type: 0, Mode: 0, TrinProg: 0, DeviceEn: 1, AddrInc: Off, _RES1: 0, SIZE: U32 }
       DEBUG probe_rs::architecture::arm::communication_interface > HNONSEC supported: true
       DEBUG probe_rs::architecture::arm::communication_interface > Device enabled: true
        INFO probe_rs::architecture::arm::ap                      > read_ap_register; ap=1 register="CFG"
       DEBUG probe_rs::architecture::arm::ap                      > Register read succesful
       DEBUG probe_rs::probe::stlink                              > AP ApAddress {
    dp: Default,
    ap: 0x1,
}: MemoryAp(MemoryApInformation { address: ApAddress { dp: Default, ap: 1 }, supports_only_32bit_data_size: false, debug_base_address:<PHONE_NUMBER>, supports_hnonsec: true, has_large_address_extension: false, has_large_data_extension: false, device_enabled: true })
       DEBUG tracing::span                                        > debug_device_unlock;
        INFO probe_rs::probe::stlink                              > read_mem_32bit; address=3758366724 ap=0 length=4
        INFO tracing::span                                        > get_last_rw_status;
       DEBUG probe_rs::probe::stlink                              > Read ok
        INFO tracing::span                                        > get_last_rw_status;
       DEBUG probe_rs::core::core_state                           > debug_core_start; id=0
        INFO probe_rs::probe::stlink                              > read_mem_32bit; address=3758157296 ap=0 length=4
        INFO tracing::span                                        > get_last_rw_status;
       DEBUG probe_rs::probe::stlink                              > Read ok
        INFO tracing::span                                        > get_last_rw_status;
       DEBUG probe_rs::core::core_state                           > debug_core_start; id=1
        INFO probe_rs::probe::stlink                              > read_mem_32bit; address=3758157296 ap=1 length=4
        INFO tracing::span                                        > get_last_rw_status;
        WARN probe_rs::probe::stlink                              > send_jtag_command 242 failed: SwdDpWait
        WARN probe_rs::probe::stlink                              > got SwdDpWait/SwdApWait, retrying.
        INFO tracing::span                                        > get_last_rw_status;
        WARN probe_rs::probe::stlink                              > send_jtag_command 242 failed: SwdApWdataError
       DEBUG probe_rs::probe::stlink                              > Current device mode: Jtag
       Error Connecting to the chip was unsuccessful.

  Caused by:
          0: An ARM specific error occurred.
          1: The debug probe encountered an error.
          2: An error specific to a probe type occurred
          3: Command failed with status SwdApWdataError

hmm, it works for me also from the openocd command, but cargo fails :(

Hmm this should be performing a proper HW reset tho. I think the error might be somewhere else ... it looks like it has trouble unlocking the co-processor. This might need some custom sequence to work :)

@Yatekii any hints how to deal with this problem? I can try to debug it but not sure where to start

So, there is a trait called DebugSequence. That needs to be implemented for a handler struct that can be registered during startup (here: https://github.com/probe-rs/probe-rs/blob/master/probe-rs/src/config/target.rs#L112).
In there you have multiple hooks to set up your chip. How exactly you need to set it up is defined in the chips reference manual. What could simplify figuring what you need to do is having a look at the .pdsc file in the CMSIS-Pack for the chip, which often describes the sequence in terrible XML syntax, but it's a start :)

My STM32WLE5CCUx also encountered the same issue: my version is: probe-rs 0.24.0
probe-rs run --chip STM32WLE5CCUx --protocol swd --connect-under-reset target/thumbv7m-none-eabi/release/bin.hex

WARN probe_rs::probe::stlink: send_jtag_command 242 failed: SwdApFault
Error: Connecting to the chip was unsuccessful.

Caused by:
    0: An ARM specific error occurred.
    1: The debug probe encountered an error.
    2: An error which is specific to the debug probe in use occurred.
    3: Command failed with status SwdApFault

But I can burn hex code with Keil.


[CP][beta channel] fix for recent regression to expression evaluation in DDC

commit(s) to merge: 2e97d91dcd6676e32a87a4c0707d73493f14f7cf
merge instructions: N/A - beta hash has not been selected yet so I couldn't try it out, but likely a clean merge.
What is the issue: A change landed last week to fix a long standing bug (https://github.com/dart-lang/sdk/issues/39187) where stepping speed when debugging flutter-web apps was very slow (a single step could be longer than 15s). The change was a large (~20x) improvement, but it involved some non-trivial reorganization of symbols in the DDC output.
The change indirectly broke expression evaluation in some cases (e.g. when the expression being evaluated used indirectly types or constants.)
What is the fix: Further changes to adjust the implementation and the expression evaluator to work well together.
Why cherrypick: Regression on eval. This and a previous change from last week (37d8c78237e875355ffe36d6b2b33c29606a43fa) should be shipped together on the same release to prevent a regression on expression evaluation.
We'd prefer to include both in this beta release to get feedback from users before the upcoming stable release next year. If we feel the risk is too high, we should then revert the previous change as well to prevent the regression.
Risk: medium - both this and the other change are fairly recent and have little coverage beyond manual testing. Even though the first change is already covered by bots and internal users, the coverage depends on their use of debugging features like stepping and evaluation.
Link to original  issue(s): https://github.com/dart-lang/sdk/issues/39187
/cc @kevmoo @mit-mit @whesse @athomas @vsmenon @franklinyow @Markzipan

We have a branch point this morning--a92baed5f8e23759b4d0dbd45ea19c597b1d95b9
@sigmundch  What is the risk of do nothing?  I'm worry about medium risk change when we are so close to holiday.
@pcsosinski  FYI

Given that we have known regressions with 37d8c78 I feel it is a higher risk doing nothing. If we wanted to go with the lowest risk, then reverting 37d8c78 would be the safest.
@mariamhas @kevmoo  - I'm also curious to hear your thoughts on the product perspective here: Is it better to wait or is it better to get this out to get more coverage prior to the upcoming stable release?

I'd love to keep the improvement. Do we feel good about the regression tests, @sigmundch ?

i agree it's better to keep the improvements, but this is also an example of why we should revert rather than fix forward.  off my soapbox, how long do you need internal users / whatever criteria to have confidence in https://github.com/dart-lang/sdk/commit/2e97d91dcd6676e32a87a4c0707d73493f14f7cf @sigmundch?  we'll likely get a beta build Monday CET.

+1 to keeping improvement and getting more coverage before stable release.
On Fri, Dec 11, 2020 at 4:18 PM Patrick Sosinski<EMAIL_ADDRESS>wrote:

i agree it's better to keep the improvements, but this is also an example
of why we should revert rather than fix forward. off my soapbox, how long
do you need internal users / whatever criteria to have confidence in
2e97d91
https://github.com/dart-lang/sdk/commit/2e97d91dcd6676e32a87a4c0707d73493f14f7cf
@sigmundch https://github.com/sigmundch? we'll likely get a beta build
Monday CET.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/dart-lang/sdk/issues/44452#issuecomment-743431664,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ANRXIQPFY7K2QOHIKMEGLJ3SUKEBDANCNFSM4UV3ZKQA
.

It's hard to get any coverage in the wild because evaluation is not yet supported internally, so we rely mostly on our test coverage, external usage, and manual validation.
I was torn earlier today to be honest, so I tried some additional manual testing this afternoon and I unfortunately still found cases where we need an additional fix (likely very small). I'm tempted to go the safe route here and hold off on the feature for a bit longer (keep it in master, but cherry-pick a revert for the beta cut).
@mariamhas @kevmoo - I assume we don't want any regression on the eval functionality, correct?  As an example a regressions without the cherry-pick would be that anything that needs types or constants may fail. This includes things like typing a function name, like main in the eval console (its type is computed when evaluating it as an expression)
@Markzipan - I'll try to create a small repro for you on Monday.

After further discussion, we are inclined to take the safe route and release the current beta without the improvements. I filed a request to cherry-pick the revert here: https://github.com/dart-lang/sdk/issues/44471


refactor PackageDependencyDescription towards identity changes

motivation: improve code infrastrucuture towards fixing correctness issues with identity
changes:

rename PackageDependencyDescription::url to PackageDependencyDescription::location to reflect its true meaning
rename PackageDependencyDescription::name to PackageDependencyDescription::nameForTargetDependencyResolutionOnly to make sure its not used for wrong reasons
move "file://" prefix handing from PackageDependencyDescription::init to PackageDependencyDescription::init(json) which where all the other location validation is done
addjsut call-sites
adjust and add tests

@swift-ci please smoke test

<EMAIL_ADDRESS>&& :
20:47:00
<unknown>:0: error: module file<EMAIL_ADDRESS>is out of date and needs to be rebuilt: signature mismatch

cc @shahmishal

@swift-ci please smoke test linux

Reviewed this as part of https://github.com/apple/swift-package-manager/pull/3244, which includes these changes.


python312Packages.numpyro: 0.15.3 -> 0.16.1

Things done
Also, I enabled xdist because this test suite takes ages to run (~30min on a Ryzen 5600x).
Changelog: https://github.com/pyro-ppl/numpyro/releases/tag/0.16.1
cc @fabaff

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review pr 362982

x86_64-linux

:white_check_mark: 28 packages built:

python311Packages.arviz
python311Packages.arviz.dist
python311Packages.bambi
python311Packages.bambi.dist
python311Packages.corner
python311Packages.corner.dist
python311Packages.flowmc
python311Packages.flowmc.dist
python311Packages.numpyro
python311Packages.numpyro.dist
python311Packages.nutpie
python311Packages.nutpie.dist
python311Packages.pymc
python311Packages.pymc.dist
python312Packages.arviz
python312Packages.arviz.dist
python312Packages.bambi
python312Packages.bambi.dist
python312Packages.corner
python312Packages.corner.dist
python312Packages.flowmc
python312Packages.flowmc.dist
python312Packages.numpyro
python312Packages.numpyro.dist
python312Packages.nutpie
python312Packages.nutpie.dist
python312Packages.pymc
python312Packages.pymc.dist

aarch64-linux

:white_check_mark: 28 packages built:

python311Packages.arviz
python311Packages.arviz.dist
python311Packages.bambi
python311Packages.bambi.dist
python311Packages.corner
python311Packages.corner.dist
python311Packages.flowmc
python311Packages.flowmc.dist
python311Packages.numpyro
python311Packages.numpyro.dist
python311Packages.nutpie
python311Packages.nutpie.dist
python311Packages.pymc
python311Packages.pymc.dist
python312Packages.arviz
python312Packages.arviz.dist
python312Packages.bambi
python312Packages.bambi.dist
python312Packages.corner
python312Packages.corner.dist
python312Packages.flowmc
python312Packages.flowmc.dist
python312Packages.numpyro
python312Packages.numpyro.dist
python312Packages.nutpie
python312Packages.nutpie.dist
python312Packages.pymc
python312Packages.pymc.dist

x86_64-darwin

aarch64-darwin

:white_check_mark: 8 packages built:

python311Packages.bambi
python311Packages.bambi.dist
python311Packages.numpyro
python311Packages.numpyro.dist
python312Packages.bambi
python312Packages.bambi.dist
python312Packages.numpyro
python312Packages.numpyro.dist


Convert LazyBodyNode to real ones before performing (deep)Copy

[ci no changelog needed]
Pull Request Description
Patch provided by Jaroslav, appears to fix local issues with inifite loop
introduced in https://github.com/enso-org/enso/pull/3429.
Fairly urgent since this issue currently blocks people.
[ci no changelog needed]
Important Notes
This renders https://github.com/enso-org/enso/pull/3439 obsolete. Related to https://www.pivotaltracker.com/n/projects/2539304/stories/182024911
Checklist
Please include the following checklist in your PR:

[ ] The documentation has been updated if necessary.
[x] All code conforms to the Scala, Java, and Rust style guides.
All code has been tested:

[x] Unit tests have been written where possible.
[ ] If GUI codebase was changed: Enso GUI was tested when built using BOTH ./run dist and ./run watch.

While we should probably proceed with this ASAP to avoid blocking, I think we should investigate why it kept working on the CI, given that all (?) of us were able to reproduce this locally - and if we can do something to make sure that such issues are not overlooked by the CI.

Absolutely agree with @radeusgd point we should understand why CI didn't show this issue


Bug Fix: Parsing Argument --finetune always True

I use f5-tts_finetune-gradio and found out that the finetune checkbox will always send finetune=true to the argument, eventhought the checkbox are off.
After some investigation turns out using type=bool on ArgumentParser always return true because in python:
bool("False") are True.

@hndrbrm seems bugs in first commit
feel free to test if works, if so will merge
thanks again~

Its working, thanks.


Fix missing variables new client (#331)

Fix bug #331

no need for this PR anymore as a taipy-gui PR has addressed this issue


INSERT INTO ... VALUES (?) should give IntelliJ parameter hints

INSERT INTO test_table (test_column, test_column2)
VALUES (?, ?)

if your cursor is in the values block doing cmd+p should bring up a parameter list with test_column test_column2.

hi, I used INSERT INTO ... VALUES(?,?); in .sq. resulting building failure.
how should I use it correctly?

Can you post the failure SQLDelight gave you as well as the exact INSERT INTO statement which caused the failure?

insert_row:
INSERT INTO devicetb(device_code, device_type, device_locale, device_name)
VALUES (?,?,?,?);

and whats the build failure you're getting?

sorry for the poor detailed context. I'm doing this in AS and Ver is com.squareup.sqldelight:gradle-plugin:0.4.3. The building failure message I got is :
Error:Execution failed for task ':app:generateDebugSqlDelightInterface'.

Generation failed; see the generator error output for details.
Which I could not tell the the detail problem is. But if I commented the INSERT lines, it build all right.

try using latest version (0.5.1) and see if build succeeds

0.5.1 build succeeds


Hamburger close button disappears in website resize

Small edge case bug:
If you open the theme in a very small footprint (mobile view), open the hamburger menu, then resize the page, the close button (X) will disappear.

I cannot reproduce this.
I used chrome dev tools in responsive view across various sizes and the menu didn't disappear.
Is this a real use case?
If the user was actually on a mobile device, they coulden't resize their screen?

This happened while testing on my pc with firefox. As I said, this is a small edga case, but for me this is reproducible.

@NicoHood thank you for the bug report. I'll keep an eye out for it while testing in the future.


Fallback to first open superclass when generating Kotlin DSL typesafe accessors

The compileKotlin task is not accessible in a type safe manner and requires explicitly importing the KotlinCompile task and defining the task using a less pleasant syntax.
Expected Behavior

For instance developers should be able to use the generated compileKotlin task accessor in the following build.gradle.kts just like other accessors but this is not the case.
plugins {
  kotlin("jvm")
}

tasks {
  compileKotlin {
    dependsOn(...) // error, task type is **Any**
  }
}

Current Behavior

The generated javadoc for the task accessor above notes that

compileKotlin is not accessible in a type safe way because: org.jetbrains.kotlin.gradle.tasks.KotlinCompileWithWorkers is not public

forcing developers to instead use one of the syntax below which is slightly less pleasant
import org.jetbrains.kotlin.gradle.tasks.KotlinCompile

plugins {
  kotlin("jvm")
}

tasks {
  val compileKotlin by existing(KotlinCompile::class) {
    dependsOn(...)
  }
  // OR
  named<KotlinCompile>("compileKotlin") {
    dependsOn(...)
  }
}

Looking at the kotlin gradle plugin source, KotlinCompileWithWorkers is indeed internal but its immediate superclass, KotlinCompile, is open and feels like a better candidate for the task type than Any.
Is it possible to fallback to using the first open superclass when generating accessors?
Your Environment

Gradle 5.1-rc-3
Build time:   2018-12-21 23:03:45 UTC
Revision:     bf267654ac894c160b5b6c5e5c06d72f1ecaa23c
Kotlin DSL:   1.1.0
Kotlin:       1.3.11
Groovy:       2.5.4
Ant:          Apache Ant(TM) version 1.9.13 compiled on July 10 2018
JVM:          1.8.0_172 (Oracle Corporation 25.172-b11)
OS:           Mac OS X 10.14.3 x86_64
Android Studio 3.5 Canary 1
Build #AI-183.48<IP_ADDRESS>15047, built on January 8, 2019
JRE: 1.8.0_152-release-1248-b22 x86_64
JVM: OpenJDK 64-Bit Server VM by JetBrains s.r.o
macOS 10.14.3
Kotlin Plugin 1.3.20-eap-100-Studio3.4-1

Looks that I reported duplicate of this issue:
https://github.com/gradle/gradle/issues/9420

The compileKotlin task type is now correctly exposed
@eskator It exposed correctly only if you do not use new worker-based tasks API of Kotlin Gradle plugin, you can see issue #9420 I add some detail about this, to reproduce you should enable option kotlin.parallel.tasks.in.project which soon will be enabled by default and it will break all usages of type-safe accessors for compileKotlin and compileTestKotlin tasks

@gildor, you're right!
Closing this one as a duplicate of https://github.com/gradle/gradle/issues/9420


An error in document. Type 'null' is not assignable to type 'void'

I found an error in the basic type section of the document
"Declaring variables of type void is not useful because you can only assign undefined or null to them"
However,the viod type cannot be assigned null

It can, if you have strictNullChecks disabled: https://www.typescriptlang.org/play/#src=const foo%3A void %3D null%3B

What you also quote is that only null and undefined can be assigned to void, where as it makes no statements about void being assignable to anything, including null, but null is not assignable to void under --strictNullChecks.
How is this causing an issue?  Also as stated, it would be great if you could reference the document.

ok，thanks


SOE "Sequence of events" table needed for linking resources to FHIR Encounter

EPIC Condition.encounter is OPTIONAL
UCDavis screenshare is true, this would be a curveball. Likely means I will update CORE to find “encounter.diagnosis” and/or “condition.encounter”
http://hl7.org/fhir/r4/condition-definitions.html#Condition.encounter
https://build.fhir.org/encounter-definitions.html#Encounter.diagnosis
@dogversioning noted this is true in FHIR spec as well.

CORE linking of encounter_ref and subject_ref is a 🛑 blocker for progress on many/most things
Applies to
FHR Condition 13% of Cerner
FHIR Medication (Cerner rare, Epic common)
FHIR Observation (Cerner rare )
Likely will invoke building the common “SOE” (Sequence of events) table in health studies
Condition.recordeddate is between Encounter.period.start and Encounter.period.end
MedicationRequest.authoredOn is between Encounter.period.start and Encounter.period.end

COUNT report for each FHIR resource type having or lacking linkages in SOE

resolved via #85


VS Code nest cshtml and cshtml.cs

Could you please nest cshtml and cshtml.cs. as wells as .razor and .razor.cs files.
It currently doesn't do nesting of the related files and editor shows lot of files under Pages folder for ASP.NET Core razor pages template.
VSCode: 1.42.0

/duplicate of #6328


Add dart before pub run

Fixes #679
- What I did
Added dart before pub, which has been deprecated as standalone command
- How to verify it
Unit tests should work again
- Description for the changelog
Add dart before pub run for unit tests

@gkc
Looks like simply adding dart isn't enough. Can you please take a look:
Run dart pub run coverage:format_coverage --lcov --in=coverage --out=coverage.lcov --packages=.packages --report-on=lib
  dart pub run coverage:format_coverage --lcov --in=coverage --out=coverage.lcov --packages=.packages --report-on=lib
  shell: /usr/bin/bash -e {0}
  env:
    proot-working-directory: ./at_root/at_persistence_root_server
    root-working-directory: ./at_root/at_root_server
    psecondary-working-directory: ./at_secondary/at_persistence_secondary_server
    secondary-working-directory: ./at_secondary/at_secondary_server
    PUB_CACHE: /home/runner/.pub-cache
    DART_HOME: /opt/hostedtoolcache/dart-sdk
    pythonLocation: /opt/hostedtoolcache/Python/3.8.1[2](https://github.com/atsign-foundation/at_server/runs/6402089265?check_suite_focus=true#step:20:2)/x64
    LD_LIBRARY_PATH: /opt/hostedtoolcache/Python/[3](https://github.com/atsign-foundation/at_server/runs/6402089265?check_suite_focus=true#step:20:3).8.12/x6[4](https://github.com/atsign-foundation/at_server/runs/6402089265?check_suite_focus=true#step:20:4)/lib
Unhandled exception:
FormatException: Unexpected character (at character 1)
# This file is deprecated. Tools should instead consume
^

#0      throwError (package:package_config/src/errors.dart:32:3[5](https://github.com/atsign-foundation/at_server/runs/6402089265?check_suite_focus=true#step:20:5))
#1      parsePackageConfigString (package:package_config/src/package_config_json.dart:54:12)
#2      PackageConfig.parseString (package:package_config/src/package_config.dart:94:7)
#3      Resolver._parsePackages (package:coverage/src/resolver.dart:115:23)
#4      Resolver.create (package:coverage/src/resolver.dart:34:13)
#5      HitMap.parseJson (package:coverage/src/hitmap.dart:45:37)
#[6](https://github.com/atsign-foundation/at_server/runs/6402089265?check_suite_focus=true#step:20:6)      HitMap.parseFiles (package:coverage/src/hitmap.dart:1[7](https://github.com/atsign-foundation/at_server/runs/6402089265?check_suite_focus=true#step:20:7)3:41)
#7      main (file:///home/runner/.pub-cache/hosted/pub.dartlang.org/coverage-1.3.0/bin/format_coverage.dart:66:31)
#[8](https://github.com/atsign-foundation/at_server/runs/6402089265?check_suite_focus=true#step:20:8)      _delayEntrypointInvocation.<anonymous closure> (dart:isolate-patch/isolate_patch.dart:2[9](https://github.com/atsign-foundation/at_server/runs/6402089265?check_suite_focus=true#step:20:9)5:32)
#9      _RawReceivePortImpl._handleMessage (dart:isolate-patch/isolate_patch.dart:192:[12](https://github.com/atsign-foundation/at_server/runs/6402089265?check_suite_focus=true#step:20:12))
Error: Process completed with exit code [25](https://github.com/atsign-foundation/at_server/runs/6402089265?check_suite_focus=true#step:20:25)5.


Modal is over the notification

I have a modal with a 'save' button, that can throw a notification if something is wrong. I was testing and the notification appears behind the modal. How can put the notify showing over it?

You can append the notification to the modal using the 'element' settings as given in the documentation here.


Need a way to build for iOS devices w/o codesigning

We can't easily codesign from our bots.  But @chinmaygarde says its possible to build with codesigning disabled.
flutter build ios --no-codesign or similar.  FYI @devoncarew
Will remove the call to flutter build ios on the bots for now.
https://codereview.chromium.org/1864203002

fixed by https://github.com/flutter/flutter/pull/3140


May I ask why the two directives HLVX.HU and HLVX.WU are added? Are there any special uses for them?

The privilege document has the following description:
Instructions HLVX.HU and HLVX.WU are the same as HLV.HU and HLV.WU, except that execute
permission takes the place of read permission during address translation. That is, the memory being
read must be executable in both stages of address translation, but read permission is not required.
For the supervisor physical address that results from address translation, the supervisor physical
memory attributes must grant both execute and read permissions. (The supervisor physical memory
attributes are the machine’s physical memory attributes as modified by physical memory protection,
Section 3.7, for supervisor level.)
These two instructions allow LSU to obtain instructions. What is the use after obtaining the instructions? Is there any special use of the software? Can you describe a typical scenario in which these two instructions are used in software?

HLVX is used by a hypervisor to read guest code (hence the checking of execute permission instead of read permission), e.g. for emulating an instruction that was trapped to the hypervisor.

OK, Thanks.


ABC-105 Only expose redux store globally in dev builds

Summary
Only expose redux store globally in dev builds.
Ticket Link
https://mattermost.atlassian.net/browse/ABC-105
Checklist

[x] Ran make check-style to check for style errors (required for all pull requests)

@lieut-data no specific exploit being covered here, more for consistency and hiding dev functionality on production builds and a bit of "better safe than sorry"


Update Broadway to v0.5.0

I know a new release is imminent, but in the meantime this will point master to a proper Broadway release.

:heart: :green_heart: :blue_heart: :yellow_heart: :purple_heart:


How do I build without Install?

I would like to build Neofetch without install for a project I am working on. How do I build it without install?

You don't build neofetch it's just a script. Copy it somewhere and run it.


outdated link to mnist dataset

Hi,
After having problems with my own rbm implementation I was very happy to notice your code, and wanted to try out the examples.
Unfortunately the http://data.neuflow.org/data/mnist-th7.tgz link is broken and you dont seem to use the same format as the dataset in https://s3.amazonaws.com/torch7/data/mnist.t7.tgz

Hi,
The dropbox link in the code https://www.dropbox.com/s/zdq98audyn8j845/mnist_lua.tar.gz?dl=0 and
https://www.dropbox.com/s/1l9q60brgnssjde/mnist_lua.tar.gz?dl=0 both give 404.
Is there another adress I can use?
Best regards,
Yagiz

https://www.dropbox.com/s/zdq98audyn8j845/mnist_lua.tar.gz?dl=0
I restored the file in my dropbox. Can you try again?
best regards Søren
On 18 Mar 2015, at 11:14, yagizy<EMAIL_ADDRESS>wrote:

Hi,
The dropbox link in the code https://www.dropbox.com/s/zdq98audyn8j845/mnist_lua.tar.gz?dl=0 and
https://www.dropbox.com/s/1l9q60brgnssjde/mnist_lua.tar.gz?dl=0 both give 404.
Is there another adress I can use?
Best regards,
Yagiz
—
Reply to this email directly or view it on GitHub.

Yes, I can download the dataset now. Thanks!
Best regards,
Yagiz

I checked and the link works. Sorry, could not respond earlier...
--
Yagiz Yasaroglu
+90-533-2360727
Managing Partner
Mobilus Ltd.
Turkey
On Fri, Nov 6, 2015 at 7:17 PM, Søren Kaae Sønderby <
<EMAIL_ADDRESS>wrote:

Closed #3 https://github.com/skaae/rbm_toolbox_lua/issues/3.
—
Reply to this email directly or view it on GitHub
https://github.com/skaae/rbm_toolbox_lua/issues/3#event-457156248.


Add a way to simulate a player chatting

This would call the necessary events to take action as if a player had passed a given message to chat, throwing event & such (Would this work better with causes once those are added @gabizou)
This would add a method like:
/**
  * Simulate a player having chatted on the server. This will post the appropriate events, and handle commands as necessary
  *
  * @param input The input, as would be provided by this player
  * @return The event that has been thrown. Changes have no effect, this is simply to report back information
*/
PlayerChatEvent chat(String input); // Don't really think it makes sense to allow a Text here? dunno. Makes things more difficult for commands.

to Player

Why wouldn't you have the method accept a Text? PlayerChatEvent chat(Text input)
After all, there's plenty of uses for it. I can see maybe having both of them, but that would break the standard that we currently have, of only accepting Text.

@FerusGrim I guess because we want to be able to simulate what the player has entered in their chat window and that is just a String. Either a command in which case a Text is pretty useless or a chat message which then has to be check whether it is a legacy or json message.
However the method naming is bad. chat() sounds to much like chatting between players.

@ST-DDT I suppose that makes sense. Though, I still believe it'd be a waste to not have the ability to bedazzle the message.
Maybe at least a PlayerChatEvent#isSimulated, so that plugins that use it can modify it afterwards?

Is it possible for a player to send a real Json Message at all? If yes you can still convert the Text to a JSON String although this seems a little bit complicated.
Maybe just have two different input methods

simulateInput(String) - Commands and Chat
simulateChat(Text) - Chat only

But I have too few knowledge on the internals here whether this is even possible.
Regarding the isSimulated() method i am really not sure whether we should allow the plugin writers to treat messages differently whether its simulated or not.

@zml2008
Can you send a command as a CommandSource in SpongeAPI? If so, we already have support. Unless you want to make that easier to use.

You can send a command, can't send chat though currently.

@zml2008
Though, you could send the command "say" with your message (or tellraw for something complex)

Does that call events? I seem to remember it also using a different format for messages.
Also, under that logic why do we have all this api when we have commands that can do the same things.

/say and normal chat are different:
/say hi --> [SomeGuy47] hi
hi --> <SomeGuy47> hi

@zml2008 Should be closed because it was added: https://github.com/SpongePowered/SpongeAPI/commit/e5a7785fd62359299580a321020165be37be8e47


Knowledge - Ingestion failure relating to failed to clean website content: run exceeded maximum time of 10m0s

Encountered the following ingestion error for 2 files when ingesting https://nginx.org/en/docs - https://test.acornlabs.com/admin/agents/a1skql2
failed to clean website content: run exceeded maximum time of 10m0s

api results from - https://test.acornlabs.com/api/agents/a1skql2/knowledge-sources/ks1hvkpz/knowledge-files
    {
      "id": "caf8a8bbd69c03b7c92f526050ece03267b319400fda96d30c0e834ef2432299",
      "created": "2024-12-17T19:17:53Z",
      "revision": "1476673",
      "type": "knowledgefile",
      "fileName": "nginx.org/en/docs/dirindex.html.html",
      "state": "error",
      "error": "failed to clean website content: run exceeded maximum time of 10m0s",
      "agentID": "a1skql2",
      "knowledgeSetID": "kst1-a1skql2",
      "knowledgeSourceID": "ks1hvkpz",
      "approved": true,
      "url": "https://nginx.org/en/docs/dirindex.html",
      "updatedAt": "\"673ca6b1-2113\"",
      "checksum": "1a7ff893b62365b87c663bda74c90423e96bdff0b66df9c31a2573739d44d1dc",
      "lastIngestionStartTime": "2024-12-17T19:34:08Z",
      "lastIngestionEndTime": "2024-12-17T19:44:08Z",
      "lastRunIDs": [
        "r1whqqk"
      ],
      "sizeInBytes": 79798
    }

   {
      "id": "caf8a8bbd69c03b7c92f526050ece03267b319400fda96d30c0e834ef2432299",
      "created": "2024-12-17T19:17:53Z",
      "revision": "1476673",
      "type": "knowledgefile",
      "fileName": "nginx.org/en/docs/dirindex.html.html",
      "state": "error",
      "error": "failed to clean website content: run exceeded maximum time of 10m0s",
      "agentID": "a1skql2",
      "knowledgeSetID": "kst1-a1skql2",
      "knowledgeSourceID": "ks1hvkpz",
      "approved": true,
      "url": "https://nginx.org/en/docs/dirindex.html",
      "updatedAt": "\"673ca6b1-2113\"",
      "checksum": "1a7ff893b62365b87c663bda74c90423e96bdff0b66df9c31a2573739d44d1dc",
      "lastIngestionStartTime": "2024-12-17T19:34:08Z",
      "lastIngestionEndTime": "2024-12-17T19:44:08Z",
      "lastRunIDs": [
        "r1whqqk"
      ],
      "sizeInBytes": 79798
    }

Note - This error was encountered when ingesting other websites  like  acorn.io and intel.com as well - https://test.acornlabs.com/admin/agents/a1x6qvg and https://test.acornlabs.com/admin/agents/a1w9jv5

@iwilltry42 any thoughts on this one?

I tried ingested 9k files that are scraped from cnn.com, most of them finished, but there are around 40 files that failed with this exact error. Even retry would not work. So I put the problematic files into the website-cleaner tool and put a debugger on it.
It turns that the timeout here https://github.com/obot-platform/tools/blob/main/website-cleaner/main.go#L167 is too low for some big files. For these files it always failed because LLM couldn't return the result in 2 minutes.


Collections: Get From Dictionary should accept a default value

Pop From Dictionary has support for returning a default value if the key isn't found in the dictionary. e.g.
Pop From Dictionary  ${myDict}  myKey  myDefaultValue

I think it'd be great if Get From Dictionary also support having a default value passed to it. 🙂
e.g.
Get From Dictionary  ${myDict}  myKey  myDefaultValue

This is certainly true. Adding the default value would also be pretty easy. Anyone interested to provide a pull request?

Wow, that was quick! 🙂  Thank you guys! ^_^

I didn't expect this to make it to RF 5.1 alpha 1 but @oboehmer was very quick with a PR. :smile:

Indeed! 😀


[BUG] Could not read OpenAPI specification

Release version
v4.10.1
Describe the bug
This week, my apiops "publish" pipeline stopped working. I have an old process that uses Development Resource Kit, which also stopped working. I believe there was some update to the APIM platform that caused the problem
Expected behavior
Deploy with success
Actual behavior
Error using APIOPs
info: Publisher[0]
Beginning execution...
info: Publisher[0]
Commit ID was not specified, will put all artifact files...
info: Microsoft.Hosting.Lifetime[0]
Application started. Press Ctrl+C to shut down.
info: Microsoft.Hosting.Lifetime[0]
Hosting environment: Production
info: Microsoft.Hosting.Lifetime[0]
Content root path: /home/vsts/work/1/s
info: Publisher[0]
Putting API azure-ai-language...
crit: Publisher[0]
System.IO.IOException: Could not read OpenAPI specification file /home/vsts/work/1/s/artifacts/apis/azure-ai-language/specification.yaml.
at publisher.Api.GetOpenApiV3SpecificationText(OpenApi openApiSpecificationFile)
at publisher.Api.GetApiSpecificationJson(ApiSpecificationFile specificationFile, CancellationToken cancellationToken)
at publisher.Api.GetApiJson(ApiName apiName, ApiInformationFile apiInformationFile, ApiSpecificationFile specificationFile, JsonObject configurationApiJson, CancellationToken cancellationToken)
at publisher.Api.PutApi(ApiName apiName, ApiInformationFile apiInformationFile, ApiSpecificationFile specificationFile, JsonObject configurationApiJson, ServiceUri serviceUri, PutRestResource putRestResource, ILogger logger, CancellationToken cancellationToken)
at publisher.Api.<>c__DisplayClass23_0.<b__4>d.MoveNext()
--- End of stack trace from previous location ---
=================================================================
Error using Development Resource Kit

az deployment group create --resource-group  --parameters ../parameters/apim-parameters-tst.json --template-file apim-api.template.json --parameters PolicyXMLBaseUrl=/ PolicyXMLSasToken=<token

ERROR: {"status":"Failed","error":{"code":"DeploymentFailed","message":"At least one resource deployment operation failed. Please list deployment operations for details. Please see https://aka.ms/arm-deployment-operations for usage details.","details":[{"code":"BadRequest","message":"{\r\n  "error": {\r\n    "code": "ValidationError",\r\n    "message": "One or more fields contain incorrect values:",\r\n    "details": [\r\n      {\r\n        "code": "ValidationError",\r\n        "target": "value",\r\n        "message": "Error downloading document from the provided link."\r\n      }\r\n    ]\r\n  }\r\n}"},{"code":"BadRequest","message":"{\r\n  "error": {\r\n    "code": "ValidationError",\r\n    "message": "One or more fields contain incorrect values:",\r\n    "details": [\r\n      {\r\n        "code": "ValidationError",\r\n        "target": "value",\r\n        "message": "Error downloading document from the provided link."\r\n      }\r\n    ]\r\n  }\r\n}"}]}}
Reproduction Steps
1 - Execute Extrator from DEV environment
2 - Execute publisher to TST environment

We found local error here. Issue Cancelled

Hi @lrlemos, I am experiencing the same issue. Can you please told me what was your local problem? Maybe it is the same is blocking my pipeline. Thank you very much.

In my version of devops with Jenkins + DevOps Resource Kit, the problem was a powershell update, which changed the SaSToken format (the "?" disappeared at the beginning). The infrastructure team fixed it, but I don't know what the versions were.
In my Azure Devops + apiops version I didn't find the history of what was the problem.
Enviado do Outlookhttp://aka.ms/weboutlook

De: leopardorossi @.>
Enviado: sexta-feira, 9 de fevereiro de 2024 16:11
Para: Azure/apiops @.>
Cc: lrlemos @.>; Mention @.>
Assunto: Re: [Azure/apiops] [BUG] Could not read OpenAPI specification (Issue #423)
Hi @lrlemoshttps://github.com/lrlemos, I am experiencing the same issue. Can you please told me what was your local problem? Maybe it is the same is blocking my pipeline. Thank you very much.
—
Reply to this email directly, view it on GitHubhttps://github.com/Azure/apiops/issues/423#issuecomment-1936200520, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ASHFQMSBZQQ32ZV476DRUQDYSZDBPAVCNFSM6AAAAAA7XYGBYSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMZWGIYDANJSGA.
You are receiving this because you were mentioned.Message ID: @.***>


updating pre-commit and adding pyproject.toml

Approving to get the repo as you like for the class. I may have to check and revert some changes in the precommit later

Sorry I didn't have a chance to answer the message. Today as we expected was very hectic.
I simply deleted some pre-commits and checked what worked. I remember reading a problem in the logs with isort. So I removed that because it is in ruff.
But I remember that the licence check see was still working. At least it required the license on the toml file I added so I don't know what it does.
It could just as well be reimplemented.


Cannot delete a RandomSecret

I am currently testing this operator to manage some of our workflows and it looks awesome !
I am creating & deleting the below yaml to test my policies :

setup a KV v2 mount
create a secret in this mount with a RandomSecret
create a k8s secret with VaultSecret

apiVersion: redhatcop.redhat.io/v1alpha1
kind: SecretEngineMount
metadata:
  name: kv
  namespace: geocoding-dev
spec:
  authentication:
    path: k8s/o2sm-kubernetes
    role: o2sm-secret-engine-admin
  config:
    defaultLeaseTTL: ""
    forceNoCache: false
    listingVisibility: hidden
    maxLeaseTTL: ""
  options:
    version: "2"
  type: kv
  path: k8s/o2sm
---
apiVersion: redhatcop.redhat.io/v1alpha1
kind: RandomSecret
metadata:
  namespace: geocoding-dev
  name: geocoding
spec:
  authentication:
    path: k8s/o2sm-kubernetes
    role: o2sm-secret-engine-admin
  isKVSecretsEngineV2: true
  path: k8s/o2sm/kv/data
  secretKey: password
  secretFormat:
    passwordPolicyName: database_policy
  refreshPeriod: 1h
---
apiVersion: redhatcop.redhat.io/v1alpha1
kind: VaultSecret
metadata:
  name: database-geocoding
  namespace: geocoding-dev
spec:
  vaultSecretDefinitions:
    - authentication:
        path: k8s/o2sm-kubernetes
        role: o2sm-secret-engine-admin
      name: database-geocoding
      path: k8s/o2sm/kv/data/geocoding
  output:
    name: database-geocoding2
    stringData:
      password: '{{ index . "database-geocoding" "password" }}'
    type: Opaque
    annotations:
      refresh: every-minute
  refreshPeriod: 3m0s

Everything works fine from a Vault perspective (creation & deletion) but I'm left with the RandomSecret in k8s.
The object have the correct properties set and no errors in describe section :
deletionGracePeriodSeconds: 0
deletionTimestamp: "2022-12-29T15:40:43Z"

In operator logs, I see the SecretEngine & VaultSecret logs but nothing for RandomSecret
2022-12-29T15:40:43.208781957Z 1.6723284432085931e+09    DEBUG    controller-runtime.webhook.webhooks    received request    {"webhook": "/validate-redhatcop-redhat-io-v1alpha1-secretenginemount", "UID": "64ed7231-853c-4a0f-859c-4cf66c974f79", "kind": "redhatcop.redhat.io/v1alpha1, Kind=SecretEngineMount", "resource": {"group":"redhatcop.redhat.io","version":"v1alpha1","resource":"secretenginemounts"}}
2022-12-29T15:40:43.209019439Z 1.672328443208945e+09    INFO    secretenginemount-resource    validate update    {"name": "kv"}
2022-12-29T15:40:43.209189195Z 1.672328443209107e+09    DEBUG    controller-runtime.webhook.webhooks    wrote response    {"webhook": "/validate-redhatcop-redhat-io-v1alpha1-secretenginemount", "code": 200, "reason": "", "UID": "64ed7231-853c-4a0f-859c-4cf66c974f79", "allowed": true}
2022-12-29T15:40:43.237149308Z 1.672328443237007e+09    DEBUG    controllers.VaultSecret    Delete Event    {"kind": "VaultSecret", "namespacedName": "geocoding-dev/database-geocoding"}
2022-12-29T15:40:43.248093813Z 1.672328443247921e+09    DEBUG    controllers.VaultSecret    Delete Event    {"kind": "Secret", "namespacedName": "geocoding-dev/database-geocoding2"}

Also quick question, what are the expected semantics of RandomSecret ? is it a one-shot generation only ? will it try to regenerate a secret in Vault if its deleted there ?
Thanks

not sure why the random secret is not getting deleted. In theory it should be deleted after ensuring that the corresponding secret in vault is also deleted.
Random secret works in two ways: once only secret generation, or periodic secret generation (that is the case in your example). Either way, the controller has no way of knowing if anything changes on the Vault side.
I think all controllers wake up every 6 hours by default, so any configuration divergence should be reconciled at least with that frequency.

Thanks

not sure why the random secret is not getting deleted. In theory it should be deleted after ensuring that the corresponding secret in vault is also deleted.

Any simple way to debug this ? I'm open to making changes and deploying a custom version more verbose.
What is the expected flow of RandomSecret deletion ?

api/v1alpha1/randomsecret_webhook.go
controllers/randomsecret_controller.go

please look at #93 to see if you are in the same situation, Also I just pushed a fixed to it, which might help you case too.

please look at #93 to see if you are in the same situation, Also I just pushed a fixed to it, which might help you case too.

No I don't think so, resources are properly created and there is no logs at all
I'll give a shot to the last version

@raffaelespazzoli Tested with latest image and I don't have the issue anymore, thanks 👍


Fix JSX Syntax Error in App.js: Adjacent JSX Elements Must Be Wrapped in an Enclosing Tag

In src/App.js, there is a JSX syntax error where adjacent elements are not properly enclosed in a single parent element. This leads to the build failing with the message: "Adjacent JSX elements must be wrapped in an enclosing tag." To resolve this issue, the elements need to be wrapped in a  or a React fragment (<>...</>). I would like to address this error and improve the component structure.

@iamparas0

In src/App.js, there is a JSX syntax error where adjacent elements are not properly enclosed in a single parent element. This leads to the build failing with the message: "Adjacent JSX elements must be wrapped in an enclosing tag." To resolve this issue, the elements need to be wrapped in a
or a React fragment (<>...</>). I would like to address this error and improve the component structure.

@iamparas0

I have fixed it cause lot of people getting errors, it need to be fixed quick


Bugged Conduit Connectors after Server Crash; cant destroy them

Im playing on FTB Direwolf20 1.0.3 and my Server crashed for whatever reason.
After restarting it, the conduits of my mining machine were bugged:
They have been replaced by "Conduit Connectors" as you can see here;

Everytime I try to break or right click them, I get kicked by the Server: "Internal Server Error".
The Server Log says the following:
[22:29:13] [Server thread/WARN]: Failed to handle packet for /<IP_ADDRESS>:54791
java.lang.ClassCastException: buildcraft.factory.TileMiningWell cannot be cast to crazypants.enderio.conduit.IConduitBundle
at crazypants.enderio.conduit.BlockConduitBundle.func_149727_a(BlockConduitBundle.java:470) ~[BlockConduitBundle.class:?]
at net.minecraft.server.management.ItemInWorldManager.func_73078_a(ItemInWorldManager.java:376) ~[mx.class:?]
at net.minecraft.network.NetHandlerPlayServer.func_147346_a(NetHandlerPlayServer.java:556) ~[nh.class:?]
at net.minecraft.network.play.client.C08PacketPlayerBlockPlacement.func_148833_a(SourceFile:60) ~[jo.class:?]
at net.minecraft.network.play.client.C08PacketPlayerBlockPlacement.func_148833_a(SourceFile:9) ~[jo.class:?]
at net.minecraft.network.NetworkManager.func_74428_b(NetworkManager.java:212) ~[ej.class:?]
at net.minecraft.network.NetworkSystem.func_151269_c(NetworkSystem.java:165) [nc.class:?]
at net.minecraft.server.MinecraftServer.func_71190_q(MinecraftServer.java:659) [MinecraftServer.class:?]
at net.minecraft.server.dedicated.DedicatedServer.func_71190_q(DedicatedServer.java:334) [lt.class:?]
at net.minecraft.server.MinecraftServer.func_71217_p(MinecraftServer.java:547) [MinecraftServer.class:?]
at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:427) [MinecraftServer.class:?]
at net.minecraft.server.MinecraftServer$2.run(MinecraftServer.java:685) [li.class:?]
[22:29:13] [Server thread/INFO]: BrainSlug lost connection: TextComponent{text='Internal server error', siblings=[], style=Style{hasParent=false, color=null, bold=null, italic=null, underlined=null, obfuscated=null, clickEvent=null, hoverEvent=null}}
[22:29:13] [Server thread/INFO]: BrainSlug left the game

That sounds like your block ID table got corrupted - do you have a backup of your world?

Wouldn't that change other conduits in the world, too?
I think this bug occured because the miningmachine was moving at the time of the crash/restart...
I just want to remove these blocks without restoring a relativly old backup

Go into MCEdit and remove them then. This not an EIO bug, just seems like world corruption.


Build: add polyfills in rollup configuration

We are using the Rollup createCompatibilityConfig as a base to build our projects, but we couldn't figure out how to add custom polyfills by ourselves like a plugin but without touch the indexHTML. How can you add them?

It's not that well described in the docs yet (so let's keep this issue open as a reminder). But basically you can configure rollup-plugin-index-html to add polyfills: https://open-wc.org/building/rollup-plugin-index-html.html#polyfills
You can pass the index.html configuration to createCompatibilityConfig using a propery, see: https://open-wc.org/building/building-rollup.html#common-extensions

Wow, thanks for being so fast Lars I will take a look


Model Files

More of a question than an issue.
How were the model files generated? for example SystemInfoResponse.Generated

Hey, you can read about this here : https://github.com/Microsoft/Docker.DotNet/tree/master/tools/specgen

Let me know if you need any more info. Closing for now.


Cleanup Kruize directory structure

This PR does some general cleanup related to naming conventions and directory structure

Rename most autotune instances to kruize
Rename AutotuneConfig to kruizeLayer
Rename dbactivites to database
Rename KruizeDeployment to KruizeOperator and move it to com.autotune.operator dir
Move performanceProfiles to analyzer module (analyzer/performanceProfiles dir)
Move all recommendation related classes to analyzer/recommendations dir
Move recommendation algorithms to analyzer/recommendations/algos dir
Move all experiment related classes to com.autotune.analyzer.experiment
Rename com.autotune.common.experiments to com.autotune.common.trials
Rename validationResultData to validationOutputData
Remove all files related to src/main/java/com/autotune/common/queue
Move AnalyzerConstants and AnalyzerErrorConstants to analyzer module
Move all classes related to KruizeObject to analyzer/kruizeObject dir
Move all classes related to layers to analyzer/kruizeLayer dir
Move all classes related to experiment to analyzer/experiment dir
Move analyzer/variables to common/variables

Thanks @dinogun for raising this PR, It helps to fix the issue #660

LGTM!
Will take this to complete the container refactoring  in #637


lint using flake8

this is rebased and ready for review

thanks @danieleades, good to see you again smile

ha good to be back. life got in the way


Add a limited Not query filter

Objective
Resolve #7265.
Solution
Create a Not query filter, inverting primitive query filters.
Implementation note and future work
This implementation only allows for inversions of Added<T>, Changed<T>, With<T> and Without<T>. The implementation without the added InvertibleFilter trait produces the correct result for tuples (and Or tuples) of only archetypal filters and only non-archetypal filters, but not tuples that mix the two. I was unable to figure out how to distinguish these cases, and chose to omit tuples altogether for correctness since it does not affect the possible filters that can be expressed.

Changelog
Add a Not query filter, inverting the condition of primitive query filters.

Without being able to use Not on Or and tuples is it worth taking on this complexity over just having a NotChanged and NotAdded Filter types?


fitBounds not supported?

Hey
Looks like fitBounds is not supported as I am adding new overlays after the map was loaded and nothing happens?
Am I correct that it is not supported?
Thanks
Nick

If you are trying to keep an overlay the same size regardless of zoom, see here:
https://github.com/AckerApple/agm-overlays#zoom-sizing
We just called it bounds, and the boundaries are typically a small x/y grouping of numbers indicating in all directions of how to size the overlay at all times.
The demo code has one overlay with a fixed size definition as well:
https://github.com/AckerApple/agm-overlays/blob/master/example/src/app.template.ts#L44

He was talking about this : https://github.com/SebastianM/angular-google-maps/blob/master/docs/content/guides/implement-auto-fit-bounds.md
With these feature, you can put juste put markers on the map and it will set the center and the zoom level automaticaly.
It's so awesome !
In agm-marker, in ngOnChange, if latitude or longitude change, they just emit new values on a subject

There is a quick workaround in the line of @JulienBourgain suggested: wrapping the agm-overlay component with a custom component that implements FitBoundsAccessor.
The custom component would look like:
import { FitBoundsAccessor, FitBoundsDetails } from '@agm/core';
import { Component, forwardRef, Input, OnInit } from '@angular/core';
import { BehaviorSubject, Observable } from 'rxjs';

@Component({
    selector: 'app-map-bounds',
    template: ` <ng-content></ng-content> `,
    providers: [{ provide: FitBoundsAccessor, useExisting: forwardRef(() => MapBoundsComponent) }],
})
export class MapBoundsComponent implements OnInit, FitBoundsAccessor {
    @Input() latitude: number;
    @Input() longitude: number;

    fitBoundsDetails$ = new BehaviorSubject<FitBoundsDetails>(null);

    getFitBoundsDetails$(): Observable<FitBoundsDetails> {
        return this.fitBoundsDetails$.asObservable();
    }

    ngOnInit() {
        const latLng: google.maps.LatLngLiteral = { lat: this.latitude, lng: this.longitude };
        this.fitBoundsDetails$.next({ latLng });
    }
}

And then you would use it to wrap markers in the template where you define the map:
<agm-map [fitBounds]="true" style="height:400px;">
    <app-map-bounds [agmFitBounds]="true" *ngFor="let marker of markers" [latitude]="marker.latitude" [longitude]="marker.longitude]>
        <agm-overlay [latitude]="marker.latitude" [longitude]="marker.longitude>
            <! -- Your content... -->
        </agm-overlay>
    </app-map-bounds>
</agm-map>

@d-silvas you have just made my day
So easy and so cool!
One little thing is that I would change ngOnInit to ngOnChanges, this way you will react on every lat/lon change if marker is dynamic
Also you can make component be OnPush

You can just create a marker collection that is not visible.
<agm-map [fitBounds]="true" style="height:400px;">         <agm-overlay [latitude]="marker.latitude" [longitude]="marker.longitude">             <! -- Your content... -->         </agm-overlay>          <agm-marker[latitude]="marker.latitude" [longitude]="marker.longitude" [visible]="false" [agmFitBounds]="true">             <! -- Your content... -->         </agm-marker> </agm-map>


Fixes and refactoring for discojs supports node #309

In one of the last big refactor PR's the end 2 end tests were removed by accident (these need to be added again); part of the refactoring was for memory, but this broke the browser-less version, which is mostly fixed in this PR. This is done partially with the help @tharvik
Done:

[x] Fixed memory class to return undefined for browser-less
[x] Reduced server memory overhead by clearing created models
[x] Refactored  server app engine into functions (avoid code being executed just through imports"

TODO:

[ ] Add again end to end tests
[ ] fix the 2 user case of benchmark.ts, current issue is related with tfjs engine "duplicate variable".

add serialization for tf models
rebase sur develop and some fixes
use interfaces instead of classes for Task
server: keep models in memory
default models & tasks instead of using tasks.json
do not yet allow to store new tasks on disk
bunch of reordering
split routers in various files


CIV-9039 Add doc generation events

JIRA link (if applicable)
https://tools.hmcts.net/jira/browse/CIV-9039
Change description
Add doc generation events
Does this PR introduce a breaking change? (check one with "x")
[ ] Yes
[x] No

Closing PR as ticket is PO Blocked

bulked with 11119


[Usage]: Can and How we start server on multi-node multi-gpu with torchrun?

Your current environment
Collecting environment information...

However I cannot get it work.

 Thanks a lot.
Before submitting a new issue...

[X] Make sure you already searched for relevant issues, and asked the chatbot living at the bottom right corner of the documentation page, which can answer lots of frequently asked questions.

we don't support torchrun . if you want to scale the number of vllm instances, maybe you'd be interested at https://docs.ray.io/en/latest/serve/tutorials/vllm-example.html

we don't support torchrun . if you want to scale the number of vllm instances, maybe you'd be interested at https://docs.ray.io/en/latest/serve/tutorials/vllm-example.html

Can this code exemple be used for llama70b ?

@antoineDievDecath sure, use -tp 4 should be enough for llama 70b with H100.


[proposal] standarize providing additional properties to JPA persistence context

I have reported this in the bugzilla (ID 123) once but can't find this anymore (and can't find it in the archive either) I'll try to rephrase it here:
Currently JPA reads the metadata in a static way. This leads to the problem that one either has to hardcode connection information, or create an incomplete unit and handle the life-cycle manually. Both approaches are very inconvenient from a management perspective.
The proposal is to allow integration of JPA with the CM service to dynamically discover and apply configuration changes.
In Pax JPA we have implemented the following approach:

For any PU we discoverer /track a corresponding configuration under pid org.ops4j.pax.jpa.pu.<name of pu>
Whenever the configuration changes it updates the properties and maybe comple/register the services

The code responsible for this can be found here as an example.
This is very convenient, simple to implement and uses standard OSGi techniques so I'd like to propose that something similar get standardized in the JPA spec.

can you reference some more?
Aries JPA is the reference implementation

I think having more than one OSGi-JPA service won't work well anyways,

All OSGi specifications have to deal with situations where multiple implementations are present. DS extenders will only process bundles that are wired to their osgi.extender capability for this reason.

and there are other services that mandate how to provide configuration in an provider independent way (e.g. declarative services) so what makes Jpa-Service special here?

No specification of which I am aware standardises a PID. Some standardise framework properties that can be used as defaults, but in those cases the provider-specific configuration takes precedence.

But it should be rare to have multiple log implementations.

The same applies to JPA (and DS) as well, I really can't think about a use-case where this becomes necessary to have multiple of this services (even though its possible) and in such special configuration one has to make sure that the config binds to the desired implementation (or they can even share the configuration).

Still the most useful feature of PAX JPA, hardcoding values in xml files is just not an option...


draft CPDB apps release plan

[x] talk to GIS, AE, and Amanda
[ ] draft plan
[ ] share plan on 6/10

per discussions with project teams, will share for feedback/confirmation
ESRI app

intended users are Capital Planning team
available to the public by 6/28
will not promote app but being able to share it with anyone is high-impact

custom app

intended users are everyone
staging version available to DCP by 6/28
one month for DCP testing and completion of all features
available to public by 7/28
will be promoted publicly


PublicKey.from_hex/from_bytes need coin argument

In ESV, code passes in the current coin to relevant calls. Where it does PublicKey.from_hex (which calls from_bytes) it has no ability to pass in the coin, so has to manually set it for now with public_key._coin = Net.COIN.

I have tried, where possible, to remove the two things that are not really properties of the public keys: namely whether compressed, and the coin.  These are private members only to remember creation context where it would be awkward not to.
Instead I preferred to pass the coin in the few cases it was needed, such as converting to a base-58 address.  Is that not possible in ESV?  Can you explain your use-case / point me at it?

I thought the code path to display did not involve any way to specify a coin, but I was wrong. I'll close the issue.

OK that's great.  If something is needed happy to discuss and find a way.  Thinking about this has made me think the optional value to the constructors should not be something specific like uncompressed or coin, but a single "presentation" object (which would hold both of those things, but be logically expansible too in future).


Migrate to Tree-Sitter

Turns out tree-sitter has a pretty slick query language which makes matching for identifiers much nicer than the Lezer approach.
It took a bit for me to get it working due to some architecture issues, but I was able to include the wasm build of tree-sitter-wasm (hooray for wasm, again) working fine. This way we don't need to include multiple builds. The repo hasn't be released to npm (and won't, for the foreseeable future), so we're including a build manually. We'll likely need to add attribution once merged.
Fixes https://github.com/NateLevin1/wati/issues/2
New Features
This is the start of a lot of really interesting features. We can start type-checking functions before compile-time to ensure they return the right kinds of data. We can list regions of used memory. For this change, we're just migrating away from regex for capturing identifiers.
The most notable upgrade here is we're going to start capturing functions/globals/tables on a stack. This way we can retrieve declarations by index. Every identifier is actually just an alias for an index in WAT.
We can allow both formats of
(call 0)
(call $main)

and provide hover information for both of them.
We have separate "stacks" for locals, globals, funcs, types, tables, labels, and memory. We know which stack to look at based on the context being used. (br 2) means the 3rd item in our label stack. (local.get 1) means the 2nd item in our local stack (which includes params).
ToDo

[x] Add tree sitter wasm
[x] Add idents collection code
[ ] Replace regex with idents
[ ] Add import globals
[ ] Add types?

This PR might not include types. They're not super difficult, but it might hold up the PR from being merged. Every function declaration is also a type declaration which complicates things.

Looking great - I do want to note that for hover info to be useful, we likely will need the type of the variable. Am I understanding this correctly?

Yeah, technically speaking we're allowed to have a function, a global, a local, and a table with the exact same name. They exist on separate stacks, so their index can align (and thus their aliased name). This is valid:
(type $main (func (param i32)))
(func $main (type $main) (param $main i32))
(global $main (mut i32) (i32.const 0))

We'd need to know in what context an index or variable name is in to know where to go looking for it to retrieve its type.

Lots of my other projects took the front seat recently, but I'd like to finish up the PR at some point, so here's an update:
This PR now involves completely removing TS in favor of JSDoc and switching to CJS.
TS → JSDoc
I was really trying to avoid doing this, but our current TS build step includes more than just type-stripping which has made debugging very difficult. You'll see some added code in the build directory. It is migrating from ESM exports to CJS ones. It's doing some backwards compatibility on nullish coalescing.
Setting breakpoints in a file I didn't build has been difficult for iteration.
The inclusion of regular assets (the wasm file) has also created an infinite loop of TS repeatedly building a recursive directory until your PC runs out of memory. For tree-sitter to even work I'd also need to include a script that copies over the WASM file. This would also mean we'd have redundant assets unless I moved it out into a higher directory.
JSDoc is unfortunately more verbose, but it does fix a lot of our problems there. We completely remove the build step, lowering our final bundle size. We can still use TS Types as long as it's in a separate TS definition file.
This PR is also going to delete tons more code, so it should get far less messy soon enough.
ESM → CJS
Surprise surprise, VS Code has 0 support for ESM in extensions. This one was super frustrating. There's a comment about how to get around all of this, but it completely messes with our TS language server (we're still using tsconfig.json here) and is overall a super hacky solution.
Previously we had TS transforming our code as part of the build step. Now we're just going to use require straight up.
TL;DR
In order to keep working on this, I had to make some larger project changes. Not happy that I had to go in that direction, but everything should come out much cleaner once I finish the PR. I've still yet to delete around 300 more lines of code.

As long as you think these changes need to be done, I'm okay with merging them. Everything looks good so far.

Some updates (long hiatus, again):
I tried to focus on performance a bit too early on. This meant I spent a lot of time dealing with the artifacts of the "fast" system instead of being productive on actual features, which took away some motivation. The focus now is on being correct and adding in a caching layer once our feature-set looks refined enough and/or performance tuning becomes important.
Current State
The new approach fixes a bunch of problems with the old system. Hovering over an identifier will now have us crawl up the chain to find the source of the identifier. This gives us correct hover information for types, tables, functions, local variables (local + param), and globals.
Because we're now treating these as separate domains, we don't run into the name-collision issue I mentioned earlier.
Possible Perf Impacts
Even though we've pre-computed the tree, we're still running a "query" on every hover. We can cache this for pretty quick wins on subsequent hovers.
We also might want to pre-compute all variable hover information. This isn't terribly difficult, but I worry about massive files (in the megabytes) which people might be opening when inspecting compiled source code.
Regardless, this perf work will be added in a subsequent PR, not this one. The reason being that I'll probably never get to releasing this update if we don't split it off.
Future Work
This gives us some pretty nice follow-ups:

Jump to Definition
Type validation for function arguments

What's Left For This PR
I want to get this released soon. Even in a less-than-perfect state. I imagine the PR right after this will be mostly cleaning up a ton of unused code.
2 features I'm going to add before calling this "done":

Show information for labels (in br, br_if, block, label)
Show hover information for indexes

I'm excited about this one. It's one of the bigger wins we get with a more structured approach. Variable names are just index aliases and we currently have no support for resolving indexes. This is also something you get when compiling where it removes all symbols. Looking through a WAT source file will show you almost only (call 0), (call_indirect 2), etc

Wow, this is really great! I've wanted to support indexes for a while and am glad that they'll finally be working.
I agree with you on the performance front - let's not worry too much about it. As long as the initial load into VSCode is not slow, the performance doesn't matter too much.

And we got the bare-bones migration working!

Next PR will probably be jump to definition and cleanup.

Indexes are live!

There are still some small areas I'd like to improve, but as mentioned earlier, I'd like to get this shipped and follow up in a future PR.

Looking great, so I'll merge now - here are some little things I noticed that could be addressed in the future. No pressure to implement these, just thought it might be useful 😄:

Providing the label of function arguments would be nice - this was actually a feature of the old regex-based parser, so maybe this should be priorized

E.g. when hovering over $test below, it should show (func $test (param $someParam i32)) instead of (func $test (param i32))

(func $test (param $someParam i32))
...
call $test

It would be fine to default to the current shortening behavior if not all of the params have labels

There's an extra unnecessary parentheses added when hovering non-mut variables - e.g. hovering over $name shows (local $name (i32)), which has unnecessary parens around i32
Hovering over a variable label in its definition gives "Could not resolve function"

This is of questionable utility because it would just be repeating the information right in front of the cursor - but it might be good to fix regardless for consistency
For example, try hovering over $name below:(func $test (param $name i32))

Unlabeled indexed branches give "No such label in scope" — maybe they could give the line of the relevant branch? This can be very low priority

Example - when hovering over the 0, it could show "Branch to line #.."loop
  br 0
end


AttractRepulseSpartGeneratro and tests for it.

For some reason, this pull request contains not only AttractRepulseSparkGenerator and related stuff, but everything else that should not be merged for now. Can you look into this?
*I would suggest you not to commit .sln file at all.

Hi, I removed the .sln file and other unnecessary files from the commit. Pull request is correct, I hope.

Great! Please fix the build first. https://ci.appveyor.com/project/tsimafei-markhel/fireworks/build/<IP_ADDRESS>

Merged, thank you!


fix invalid datetime value error on generic entity search

1. Why is this change necessary?
The generic entity search (for example used in attribute fields with entity selection) throws exceptions regarding "General error: 1525 Incorrect DATETIME value" with MySQL 8 (MySQL 8.0.21 in my case)
2. What does this change do, exactly?
The change excludes all datetime fields from beeing used as search field in generic entity search
3. Describe each step to reproduce the issue or behaviour.

Add a attribute with type multi selection for entity Category
Open a category and start typing in the multiselection field
The triggered AJAX request produces an exception as described in 1

4. Please link to the relevant issues (if any).
5. Which documentation changes (if any) need to be made because of this PR?
6. Checklist

[ ] I have written tests and verified that they fail without my change
[ ] I have squashed any insignificant commits
[ ] This change has comments for package types, values, functions, and non-obvious lines of code
[ X ] I have read the contribution requirements and fulfil them.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Philipp Mahlow seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

would you mind adding a test for this? 🙂

This PR was closed due to inactivity. If this change is still important to you, feel free to create a new pull request.
For more information about our contribution guidelines, see https://developers.shopware.com/contributing/contribution-guideline/.


Sharing teacher model checkpoints.

Hi,
Could you share checkpoints for the teacher model? We find it difficult to obtain the accuracies reported in the paper, perhaps due to the teacher being not trained to the same accuracy as reported.

Hi, you can train the teacher model using train_teacher.py. How different is the performance of your trained teacher model compared to teacher model printed paper?

Hi, thanks for getting back. I used train_teacher.py. For 1000 labels on CIFAR10 dataset, WRN 28-5 teacher is trained to accuracy of 92.82. Using this trained teacher and SRST_AWR I get a standard test accuracy 82.19, PGD20 accuracy of 48.73, and Autoattack accuracy of 46.0. The exact values for 1000 labels is not reported in the paper, instead the graph in Figure 1 of paper indicates autoattack accuracy greater than 50%.

I also do not get the reported values for SVHN and STL10 as well. For SVHN, the wrn-28-2 teacher is trained to an accuracy of 96.6 and wrn-28-5 teacher model for STL10 to an accuracy of 87.9. Both are using strictly 1000 labels.

Thank you for detailed response. I found that the total epochs in train_teacher.py  should be 1000, not 500.
500 is the number for fast implementation. The model for reproducing the results in this paper will be updated in next week. Thank you for your attention to my paper. Feel free to ask any further questions!!


Media Not Found (Again)

Now that it works, Any show, even if it exists, shows media not found. Any tips??

Also, I cannot see terminal after it says this. It instantly closes

Hey @MagnusStrom, would you mind sharing more details? Which command you entered to run the script? Try with -d flag in the end of the command, it will print out all debug logs. If you could paste some logs here, I can take a deeper look.

Hey @MagnusStrom, it's been a month and there is no further information provided from your side. I assume you managed to make it work? So, I'm closing this issue for now. If you are still facing the same issue, please provide more details and logs in the comment or in a new issue, I will try to take another look.

Hello, I gave up and stuck with torrents but now I am back. I cannot provide copy paste logs as the program closes right after the error, but here is what i got from a clip.

Hey @MagnusStrom, could you please let me know which movie or TV you are trying to download with the script? Mind sharing the command you executed?

Hello, if I run ./soap2day-dl.sh, it does not run and says media not found, but if I run soap2day-dl.sh, it runs fine. Im assuming this is a certified windows moment.

Hey @MagnusStrom,

if I run ./soap2day-dl.sh, it does not run and says media not found, but if I run soap2day-dl.sh, it runs fine. Im assuming this is a certified windows moment.

If it's an OS issue, I don't know how it could be fixed in the script... Moreover, it's not related to the error Media not found in your screenshot. I just want to know the name of media you used to download -n <name>. If you provide me the name, I can try it on my side.

It is related though. That screenshot happens when i do  ./soap2day-dl.sh -n "The Snoopy"

Hey @MagnusStrom, the same media title works for me. From your logs, it looks like the fetched cookie is invalid. Unfortunately, the logs in your screenshot are incomplete, it doesn't pinpoint the exact error.
You could try to remove cookie.json in the script directory and run script again, it will generate a new file. If it's still not working, please paste the complete logs here and I will take another look.


Fix broken link

SSIA

I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.

Codecov Report

Merging #26 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master     #26   +/-   ##
======================================
  Coverage    70.3%   70.3%
======================================
  Files          15      15
  Lines         825     825
======================================
  Hits          580     580
  Misses        223     223
  Partials       22      22

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e2a93d...5d8b7ee. Read the comment docs.

thank you for the contribution @mkontani !


Limit buffers sizes to leave some memory for the platform

Some conformance tests use directly the size returned by the runtime
for max memory size to allocate buffers.
This doesn't leave enough memory for the system to run the tests.

@jlewis-austin It depends really of what the implementation is returning as max size. If the implementation returns the whole available memory in the system, creating a buffer with that size will succeed but the system won't have enough memory left.

There's some good fixes in here, but it also introduces functional changes that could impact existing implementations. I think we need to address the fundamental question first--should an implementation report a buffer size that can't be created due to platform memory usage? I tend to think that the allocation tests should be able to pass as-is without adjusting the reported numbers, but welcome other opinions.

Agreed we need more opinions on that before processing with the other comments as this is fundamental for this change.
I don't think any implementation should return something else than the maximum memory available for the buffer creation.
Only the application is aware of the memory needed for the system and the operations that are going to be performed in the system with the buffer.
The implementation can't know what is needed for the platform and this can be different from a platform to another, so if it doesn't report the whole memory it would apply an arbitrary factor and would work for most of the platforms ?
What about passing a parameter to the test ? as we do in test_allocation reduction% ?

I should clarify that most of the reductions look fine, for the tests that aren't specifically testing max alloc size functionality. The main one I'm concerned about is test_api_min_max, where there's no "app" to speak of beyond spinning up the platform and doing a single allocation.
That being said, I think you're right about not estimating platform usage, and I got two trains of thought mixed up in the problem statement. The real question should have been whether the CTS lower limits on retries (ie, your PASSING_FRACTION) serve as a "reasonable" minimum value that should succeed, or if the tests should remove all limitations and simply keep re-trying down to size 1. On the max allocation tests, I think it makes sense in either case to always attempt the max size in order to verify that it either fails gracefully or succeeds.