synchronize schema spec

What
APM agent json schema automatic sync
Why
Changeset

https://github.com/elastic/apm-server/commit/d1b5503a6 Extend intake API to accept info about target service (https://github.com/elastic/apm-server/pull/7870)

:green_heart: Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

Build stats

Start Time: 2022-04-19T07:22:51.739+0000

Duration: 50 min 51 sec

Test stats :test_tube:

Test
Results

Failed
0

Passed
2845

Skipped
20

Total
2865

:green_heart: Flaky test report
Tests succeeded.
:robot: GitHub comments
To re-run your PR in the CI, just comment with:

/test : Re-trigger the build.

run benchmark tests : Run the benchmark tests.

run jdk compatibility tests : Run the JDK Compatibility tests.

run integration tests : Run the Agent Integration tests.

run end-to-end tests : Run the APM-ITs.

run windows tests : Build & tests on windows.

run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)


[BUG] pip install -e . uses pyproject.toml but the file doesn't exist

setuptools version
68.2.2
Python version
CPython (3.10.13)
OS
Ubuntu 22.04.3
Additional environment information
This only happens on Github action. I can't reproduce on my local machine (Windows 10)
Description
Also reported at https://github.com/pypa/pip/issues/12339, @uranusjr said it belongs to setuptools.
I'm maintaining an old package using setup.py. There is a pip install -e . command when building on Github action.
However, the result of pip install -e . looks weird. It seems that it tries to build the wheel using pyproject.toml which doesn't exist at all:
  Preparing editable metadata (pyproject.toml): started
  Preparing editable metadata (pyproject.toml): finished with status 'done'

And it seems that scripts written in setup.py doesn't run.
Expected behavior
When running the same command on my local machine (Windows 10), it seems to use setup.py correctly:
C:\Users\eight04\dev\node_vm2>pip install -e .
Obtaining file:///C:/Users/eight04/dev/node_vm2
  Preparing metadata (setup.py) ... done
Installing collected packages: node-vm2
  Attempting uninstall: node-vm2
    Found existing installation: node-vm2 0.4.5
    Uninstalling node-vm2-0.4.5:
      Successfully uninstalled node-vm2-0.4.5
  Running setup.py develop for node-vm2
Successfully installed node-vm2-0.4.5

How to Reproduce
This happens on Github action so you can view the workflow here:
https://github.com/eight04/node_vm2/actions/runs/6486910183/workflow
Output
Full log:
https://github.com/eight04/node_vm2/actions/runs/6486910183/job/17616088836

Hi @eight04 , thanks for opening the issue...

This only happens on Github action. I can't reproduce on my local machine (Windows 10).

Uuummm without a deterministic reproducer it is very difficult to investigate and help...
Could you please try to create a minimal reproducer in a bran new virtual environment in your local machine? Also could you please update pip to its latest version and then pip uninstall both setuptools and wheel from this virtual environment before running your edutable installation?
Finally when running the editable install, could you please use pip in the verbose mode and pass the -C verbose=true flag? (E.g. pip -vvv install -e . -C verbose=true)

I'm going to close this since it works as intended.
I also found why I couldn't reproduce on my local machine. It seems that if wheel is installed in the environment, pip install -e . still runs setup.py develop. If wheel is not installed (e.g. on Github action), pip creates a "build-env" and use the new method.


Is there a road map to make the operator production ready ?

It is production ready with current v1.6.1.


Error: Directory import '...' is not supported resolving ES modules imported

Environment
<EMAIL_ADDRESS><EMAIL_ADDRESS>Reproduction

clone https://github.com/varugasu/reproduction-bundle-bug
yarn install
yarn test

Describe the bug
I have an issue with the output from unbuild with vitest with the following error:
 FAIL  src/component.test.tsx [ src/component.test.tsx ]
Error: Directory import '/Users/vargasmesh/Projects/Git/varugasu/reproduction-bundle-bug/node_modules/@mui/material/Button' is not supported resolving ES modules imported from<EMAIL_ADDRESS>Did you mean to import @mui/material/node/Button/index.js?

To reproduce it, I created this library and published to GitHub packages: https://github.com/varugasu/reproduction-lib
This library uses unbuild and one thing that I am doing is to preserve the folder structure by following Rollup instructions using glob: https://rollupjs.org/configuration-options/#input
I also created this project:  https://github.com/varugasu/reproduction-bundle-bug
This project imports the @varugasu/reproduction-lib package. I can normally run in dev mode and build, but when I execute yarn test it breaks
Additional context
No response
Logs
No response

This seems to be related on how Vitest resolves dependency. See https://github.com/vitest-dev/vitest/discussions/4233 for more information.
Based on @sheremet-va reply (https://github.com/vitest-dev/vitest/discussions/4233#discussioncomment-7179094):

Vitest has to use Node.js resolution so you don't have multiple instances of the same package, and Node.js doesn't support module field.

After reading https://nodejs.org/api/packages.html#package-entry-points I saw we have node option:

"node" - matches for any Node.js environment. Can be a CommonJS or ES module file. In most cases explicitly calling out the Node.js platform is not necessary.

Based on this, I changed the package.json to:
  "exports": {
    "./*": {
      "types": "./dist/*/index.d.ts",
      "node": "./dist/*/index.cjs",
      "import": "./dist/*/index.mjs",
      "require": "./dist/*/index.cjs"
    }
  },

Therefore, to solve this issue we need the line "node": "./dist/*/index.cjs" on exports
On my @varugasu/reproduction-lib the version 1.0.1 is broken. But I created 1.0.2-fix that if we run yarn test with it, it passes.


Renaming the "tests_tmt_ref" input

This is just a suggestion, or maybe a proposition for further "brainstorming".
We should be cautious with the public API of this GitHub action, as it would be hard to rename the user-defined variables when the action will be used more.
We should also double-check all other inputs, not only the test_tmt_ref, if they are really needed, and if their naming is suitable.
@phracek, @pkubatrh please take a look.

This can be discussed also with @thrix. He is the developer of testing farm. WDYT?

Naming was solved in another PR. I am closing this now, as it is not needed anymore.


Nothing shows up after initial boot

When I try to run balena-dash on a Raspberry Pi 3 with official 7" touch screen, I'm not seeing anything on the screen when the browser should be showing up.
Observations:

Confirmed screen is fine by using normal Raspberry Pi OS. Result is that both screen and touch work fine
Tried "Deploy with Balena" button, did not resolve my issue
When I turn on the pi I see the rainbow splash screen. Then just black
LAUNCH_URL is set, and I can use the web UI to set the URL, it just doesn't show anything on the screen.

Can you suggest anything I can do to narrow this issue down? This project has worked for me in the past with this same raspberry pi, but it has been a year or so.

After noticing that an error in the log was showing "./tohora file not found" I found this stack overflow question that pointed me in the right direction. The solution to this issue was to use the Raspberry Pi 3 device in Balena (not Raspberry Pi 64 bit).


Swift 2.0 support

Hey @yoiang, thanks! I actually just pushed a PR to track Xcode 7.0 and Swift 2.0 support in #31 - guess our timing was pretty close. Sorry for the double work, though.
As I did before with prior Xcode betas, I'll keep them on a branch until Xcode 7.0 is released, though. Feel free to jump in on the discussion over there if you'd like, though!

Haha! No worries :)


Flaky firebase deploy on python functions

Python function deployment seems very flakey. e.g.
$ firebase deploy --only functions

=== Deploying to 'aaa'...

i  deploying functions
i  functions: preparing codebase ingestion for deployment
i  functions: ensuring required API cloudfunctions.googleapis.com is enabled...
i  functions: ensuring required API cloudbuild.googleapis.com is enabled...
i  artifactregistry: ensuring required API artifactregistry.googleapis.com is enabled...
✔  functions: required API cloudfunctions.googleapis.com is enabled
✔  artifactregistry: required API artifactregistry.googleapis.com is enabled
✔  functions: required API cloudbuild.googleapis.com is enabled
⚠  functions: Failed to detect functions from source FirebaseError: User code failed to load. Cannot determine backend specification.
stderr: * Tip: There are .env or .flaskenv files present. Do "pip install python-dotenv" to use them.

WARNING: This is a development server. Do not use it in a production deployment. Use a production WSGI server instead.
 * Running on http://<IP_ADDRESS>:8081
Press CTRL+C to quit

Error: User code failed to load. Cannot determine backend specification

Goes away immediately on next try 🤷🏼

Hello. Is there a ‘firebase-debug.log’ generated that you can share here?


[FEATURE] CGI Implementation

Add CGI implementation for GET, POST and DELETE requests:

Possibility to handle multiple CGI, specifying it through a configuration file;
Properly interpret request body when the request is a POST;
Properly set environment variables for the child process running the CGI binary.

Add tests to server features:

Test GET, POST and DELETE requests;
Test CGI interpretation in GET and POST requests, using PHP and Python;
Test autoindex;
Test file uploading;
Test error page management.

Add an example configuration file with example pages and assets to easily present the project functionalities.

Nice 👍


docs: Update BYOB builder version in docs

/cc @AdamKorcz @enteraga6
@aalmiray I was not able to find the v1.0.0-java release for the Java builder. Is it already released?

NOTE: Don't merge this PR until:

we have more visibility into the Maven / Gradle builders: either they'll be released along the Bazel builders or not (we'll adjust the tags)
we know the JReleaser tag

/cc @AdamKorcz @enteraga6
@aalmiray I was not able to find the v1.0.0-java release for the Java builder. Is it already released?

Just landed in Chile. will check soon

/cc @AdamKorcz @enteraga6
@aalmiray I was not able to find the v1.0.0-java release for the Java builder. Is it already released?

Just landed in Chile. will check soon

friendly ping to get this PR merged.


Check if schema is already been enabled

When schema is already enabled you do not have to enable it again. Otherwise it will overwrite your current ords configuration.

Can not get it to work without hitting error shown in screenshot...

All I can do would be to check if schema is already enabled.


[FEATURE] Provide a higher level implementation for REST handlers

Is your feature request related to a problem?
In https://github.com/opensearch-project/opensearch-sdk-java/blob/main/src/main/java/org/opensearch/sdk/sample/rest/RestHelloAction.java#L37 the developer has to implement a handleRequest that acts as a router that checks for methods, e.g.
if (Method.GET.equals(method) && "/hello".equals(uri)) {
            return new BytesRestResponse(OK, GREETING);
        }

This is unnecessarily verbose.
What solution would you like?
Provide a higher level implementation that implements ExtensionRestHandler . As a developer I would like to write something shorter:
public class RestHelloAction extends GenericExtensionRestHandler {

    @Override
    public List<Route> routes() {
        return singletonList(
            new RouteHandler(GET, "/hello", this.handleHello),
            new RouteHandler(GET, "/world", this.handleWorld)
        );
    }

    public RestResponse handleHello(...) {
    }

    public RestResponse handleWorld(...) {
    }
}

Alternatives?
There might be an HTTP handler library that provides routing out of the box that we could optionally plug in, e.g. https://github.com/undertow-io/undertow like so.

new RouteHandler(GET, "/hello", this.handleHello)

I can see some of the benefits here, where we would store a functional interface in the registry rather than a class.  However, I'm not sure there's much added benefit vs. just splitting out the two routes into two classes (RestHelloAction and RestWorldAction) each with their own handleRequest() implementation.
The "unnecessarily verbose" check is really just (possibly unnecessary?) defensive programming against a "this should never happen" condition.
I definitely think we should at least keep the existing implementation as it is a direct corollary to the prepareRequest() method on plugins and should ease plugin-to-extension migration.
The big difference in your proposal vs. just splitting out classes is in mapping methods to routes, and I think a class like your proposed GenericExtensionRestHandler could enable that optional behavior.
So I agree this is a "nice to have" functionality but don't think I should change the existing interfaces.

Speaking of libraries, might be interesting to try to integrate with a JAX-RS (JSR-311) library to use annotations.  I wonder if these also help in generating OpenAPI specs?
@Path("/hello")
public class HelloService{
    @GET
    @Path("/{param}")
    public Response getMsg(@PathParam("param") String msg) {
        String output = "Jersey say : " + msg;
        return Response.status(200).entity(output).build();
    }
}

Two ways to go about this syntax:
new RouteHandler(GET, "/hello", this.handleHello)

Function<ExtensionRestRequest, ExtensionRestResponse> handleHello = (request) -> { ... };

Or, alternately
new RouteHandler(GET, "/hello", r -> this.handleHello(r))

ExtensionRestResponse handleHello(ExtensionRestRequest request) { ... };


Backpack loses entire inventory if placed and picked up.

I placed down my backpack to clean it out in the middle of a cave after looking a bunch of stuff in an ancient city. Once I finished cleaning it I picked it back up with left shift and everything in the backpack literally just disappeared.

Are you using the latest version? I thought I fixed this in 20.1-0.16-v2

modrinth unfortunately didnt show me an update available until after it happened so no, i wasnt on the latest version. i didnt realize it until after i posted this though. sorry.

phew... I thought I released a version for the fix and never fixed it. You had me scared for a second but no problem! Sorry about your items :(


Development Fix server style after version bump

Checklist
General
Server

[x] I followed the coding and design guidelines.

Description

Run ./gradlew :spotlessApply and committed changed as after recent bump the server style github job failed
Review Progress

Code Review

[ ] Review 1

It's a spotless bug in v5.16.0, we will revert to v5.15.0


Feat/events

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

20 of 41 (48.78%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-1.5%) to 65.217%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

internal/controller/githubapp_controller.go
20
41
48.78%

Totals

Change from base Build<PHONE_NUMBER>:
-1.5%

Covered Lines:
315

Relevant Lines:
483

💛  - Coveralls


CoPilot Extension needs an update but none is available

Azure Data Studio Version: 1.49.0
OS Version: MacOS 14.2.1

Steps to Reproduce:

Install ADS
Install CoPilot Extension and sign in
See error message about update

Does this issue occur when all extensions are disabled?: This is an extension issue

I attempted to report this using the report issue with extension button but it takes me to a dead link instead of allowing me to submit my issue

@reedws someone else ran into this too and workaround the issue discussed here https://github.com/microsoft/azuredatastudio/issues/25802.  The latest version in the marketplace is v.199.0, but for some reason it's not auto-updating in some cases, we'll investigate this.
Do you see the newer version if you uninstall the extension and try to reinstall from the Extension Manager?

Yep! manually uninstalling and re-installing forced it to update

@reedws thanks for the update!  I'll use this issue to track the "Extension Manager not showing latest version & auto-updating" bug.


Add support for generic classes

At the moment generic classes are not supported (since instanceof only is used to check for a particular class).
Important the existing support for non-generic classes, especially Date should not be broken (#1)

Closed by #9


getEntityMetadata() doesn't return anything

I don't know if this the correct place to report this.
Using Channel Integration Framework, Channel Provider, widget/sidebar
Using msdyn_cilibrary.js, getEntityMetadata() times out.
Another way to test without msdyn_cilibrary.js, getenvironment returns, but getEntityMetadata does not:
window.addEventListener('message', e => console.log(e.data));

window.top.postMessage({
            messageCorrelationId: (Math.random() + 1).toString(36).substring(7),
            messageType: 'getenvironment',
            messageData: new Map()
}, '*');

window.top.postMessage({
            messageCorrelationId: (Math.random() + 1).toString(36).substring(7),
            messageType: 'getEntityMetadata',
            messageData: new Map().set('entityName', 'contact').set('attributes', [])
}, '*');

@vegarda thanks for creating this issue. Will pass this on to the product team for investigation.

@vegarda Please raise a support ticket.

@vegarda Which CIF version are you using? This is fixed in the latest versions. The version should be <IP_ADDRESS>2 or later.

yes, it looks to be returning something now

Closing the issue based on the customer's response above.


ui color change

Is there a way to edit the color of the ui. i want it to be black with white writing. If anyone can help that would be great!

maybe i should give a little more info. i have edit the code in the index.html file for the background will be black with white text. when i try to run the ui is still shows up the same way. i deleted the whole index.html file and its still calling the old web ui. where is it pulling the file from if its deleted?


Iterative Version of decorator_class

Iterative solution to #821

Issue: https://github.com/drapergem/draper/issues/819

Closing this in favor of #821


Use native node:crypto

[x] tests and linter show no problems (npm t)
[x] tests are added/updated for bug fixes and new features
[x] code is properly formatted (npm run fmt)
[x] description of changes is added in CHANGELOG.md

Landed in https://github.com/metarhia/metautil/commit/70081ce009b7ad0c0bc3fd66d430c6b83aceda50, https://github.com/metarhia/metautil/commit/6d3d7b27830f2e89a63fe4e753b8b2b7328b53a7, and https://github.com/metarhia/metautil/commit/c77f7ce8cf8039da63439571d47821f1acac225f


Coding Styles: Easier to Ask for Forgiveness than Permission(EAFP) vs Look Before You Leap(LBYL)

Context:
It starts from reading this blog: https://securitylab.github.com/research/Ubuntu-gdm3-accountsservice-LPE
In software development, time-of-check to time-of-use (TOCTOU, TOCTTOU or TOC/TOU) is a class of software bugs caused by a race condition involving the checking of the state of a part of a system (such as a security credential) and the use of the results of that check.
Despite conceptual simplicity, TOCTOU race conditions are difficult to avoid and eliminate. One general technique is to use exception handling instead of checking, under the philosophy of EAFP – "It is easier to ask for forgiveness than permission" rather than LBYL – "look before you leap" – in this case there is no check, and failure of assumptions to hold are detected at use time, by an exception.

https://en.wikipedia.org/wiki/Time-of-check_to_time-of-use

Difference
### EAFP
try:
    x = my_dict["key"]
except KeyError:
    # handle missing key

### LBYL
if "key" in my_dict:
    x = my_dict["key"]
else:
    # handle missing key

In a multi-threaded environment, the LBYL approach can risk introducing a race condition between “the looking” and “the leaping”. For example, the code, if key in mapping: return mapping[key] can fail if another thread removes key from mapping after the test, but before the lookup. This issue can be solved with locks or by using the EAFP approach.

https://docs.python.org/3/glossary.html#term-eafp
https://docs.python.org/3/glossary.html#term-lbyl

Moral
Use Exception Handling Well

Easier to Ask for Forgiveness than Permission(EAFP) vs Look Before You Leap(LBYL)
Context:
It starts from reading this blog: https://securitylab.github.com/research/Ubuntu-gdm3-accountsservice-LPE
In software development, time-of-check to time-of-use (TOCTOU, TOCTTOU or TOC/TOU) is a class of software bugs caused by a race condition involving the checking of the state of a part of a system (such as a security credential) and the use of the results of that check.
Despite conceptual simplicity, TOCTOU race conditions are difficult to avoid and eliminate. One general technique is to use exception handling instead of checking, under the philosophy of EAFP – "It is easier to ask for forgiveness than permission" rather than LBYL – "look before you leap" – in this case there is no check, and failure of assumptions to hold are detected at use time, by an exception.

https://en.wikipedia.org/wiki/Time-of-check_to_time-of-use

Difference
### EAFP
try:
    x = my_dict["key"]
except KeyError:
    # handle missing key

### LBYL
if "key" in my_dict:
    x = my_dict["key"]
else:
    # handle missing key

In a multi-threaded environment, the LBYL approach can risk introducing a race condition between “the looking” and “the leaping”. For example, the code, if key in mapping: return mapping[key] can fail if another thread removes key from mapping after the test, but before the lookup. This issue can be solved with locks or by using the EAFP approach.

https://docs.python.org/3/glossary.html#term-eafp
https://docs.python.org/3/glossary.html#term-lbyl

Moral
Use Exception Handling Well


Network with empty routes produces 404 error

If a network with no routes is iterated before the network with the route being imported or updated, a 404 error is produced:
aws_route53_record.record: Refreshing state... [id=Z06558302SO4GX058CO2F_platform-database.sct-prd-west.nowsecure.io._CNAME]
╷
│ Error: Status code: 404, Response body: []
│
│   with openvpncloud_route.ops,
│   on main.tf line 152, in resource "openvpncloud_route" "ops":
│  152: resource "openvpncloud_route" "ops" {

While it is reasonable for api/beta/networks/%s/routes to return a 404 when a specific network has no routes, it seems less reasonable for that error to be treated as fatal:
https://github.com/OpenVPN/terraform-provider-openvpn-cloud/blob/9346cb3e36a3d632ac05a0f9b31e8b72694f1b90/client/route.go#L103

Hey! @chornns Does the issue still persist?

This is a bit disruptive to test, but I don't see why a description on a default route would help when the situation described is a network without any routes.

We've published new version of Terraform Provider to Registry: https://registry.terraform.io/providers/OpenVPN/cloudconnexa/latest
Going forward only https://registry.terraform.io/providers/OpenVPN/cloudconnexa/latest will be developed.
Please give new provider a try, hopefully it will fix your issue.
In case if problem persists - please open new "Issue" (https://github.com/OpenVPN/terraform-provider-cloudconnexa/issues)
Sorry for inconvenience.


Kind of an issue?

Could you make one for Tokyo Mirage Sessions #Fe? Performance and Quality? Would be extremely grateful.

Tokyo Mirage doesn't even play properly, it's hard to see anything at all. Once Exzap improves compatibility for this game, I'll consider it.

Eh, screw it. Adding.


No data send to Firebase Crashlytics

What happen
After set FirebasePlugin.logMessage("my message")  FirebasePlugin.logError(nameError) and
create an error in my code to test crash report on Crashlytics Dashboard in Firebase, I build successfully and test on a phone  my app and when the error arrives it appears in the console (  via a console.log ) but logMessage and logError doesn't react and send nothing to Firebase Crashlytics.
FirebasePlugin is defined, logMessage and logError are existing function.
Did i miss something when I was setting Crashlytics or not ?
The app is tested on Android , and I have already google-services.json on my project.
I have set Firebase Analytics already and it works perfectly fine.
Plugin Version
cordova : 8.1.2
firebase : cordova-plugin-firebasex  & cordova-plugin-androidx-adapter

On Android you currently will only see the log output appear in the Firebase Console.
logError() sends the message right away:

logMessage() only sends the message along with the next crash:

See the Crashlytics docs for Android for details.
However I will improve the Android implementation in the next version so it also logs to the native logcat output.
On iOS, the plugin uses the CLSNSLog which logs data to the Xcode console as well as to the remote Crashlytics service.
Both logError() and logMessage() only send along with the next crash dump:

Note: in an iOS debug build you may need to upload the dSYM in order to see you crash data appear in the Firebase Console.
See the Crashlytics docs for iOS for details.
You can call FirebasePlugin.sendCrash() to force a crash - see here for details on crash testing.

Hey Dave, I have a question about this: in the firebase crashlytics console I'm only getting one issue:

All the non-fatal exceptions are being grouped into one issue, is there anyway to separate these issues?


Daily task indicators: Don't send Herb Box notifications to Ironmen by default

Ironmen can't buy Herb Boxes from NMZ (btw), so there is no point in sending notifications.

I was thinking of disabling every option by default anyways, I will push it right now and if Adam or anyone else wants, they can merge it

Just pushed a lame solution #1119


Database Query using PropertyFilter on Text returns error

Hi, I'm trying to query a database based on the property Name:

The equivalent curl request gives a successful response:
➜ curl -X POST 'https://api.notion.com/v1/databases/'$DB_ID'/query' \
  -H 'Authorization: Bearer '"$NOTION_API_KEY"'' \
  -H 'Notion-Version: 2022-02-22' \
  -H "Content-Type: application/json" \
  --data '{
  "filter": {
    "property": "Name",
    "title": {
      "equals": "May 2022"
    }
  }
}'

However when using the package:
	dbQueryReq := &notionapi.DatabaseQueryRequest{
		PropertyFilter: &notionapi.PropertyFilter{
			Property: "Name",
			Text: &notionapi.TextFilterCondition{
				Equals: today.Format("Jan 2006"),
			},
		},
	}
	d, err := t.client.Database.Query(ctx, notionapi.DatabaseID(dbId), dbQueryReq)

Returns the error
panic: body failed validation. Fix one:
body.filter.or should be defined, instead was `undefined`.
body.filter.title should be defined, instead was `undefined`.

...

Looks like the Text field in PropertyFilter needs to have it's json_tag updated to use rich_text ?

Thank you for submitting the issue! The new version with the fix is coming soon


Refactor import-assets

Instead of iterating through objects multiple times, we can do it in one go.

tests are reporting about bunch of alerts and crushes from cluster-capi-operator, @alexander-demichev can you take a look please, it might be connected with this changes

/retest

/retest

/retest


Upgrade to solc 0.5.5

[x] check the changelog and the release note of 0.5.5.
[ ] actually change the solc versions in the Solidity sources.

This should go in the next minor package update.

I heard somewhere, 0.5.6 contains bug fixes to 0.5.5.  So I guess it's better to skip 0.5.5. and directly jump to 0.5.6.

#748 is about solc 0.5.6.


Confused about when to call speaker.Play()

First, thank you for the awesome project!
I have multiple, large music files I want to stream from disk, like this:

play song A
stop song A, start playing B
stop B, continue playing A
etc

When a song plays all the way through, I rewind it (via. streamer.Seek(0)).
Given this kind of usage, what I've come up with is to have ctrl := beep.Ctrl{...} where I keep changing ctrl.Streamer to the song I want to play.
However I'm confused about when I need to call speaker.Play(). Do I just call it once, after constructing ctrl? Or every time I change ctrl.Streamer? Or only after I rewind a streamer?
Thanks for any info!
Original issue: https://github.com/faiface/beep/issues/143

Question was answered in original issue.


Optimized design system bundle

Current bundle analysis

Ideally the design system output looks similar to the Lodash screenshot, where you can see many many small modules all broken up. This effectively equates to proper tree shaking.


Invalid record literal type "record binding pattern"

This is in SemanticAnalyzer

This is yet to be implemented

Related issues: https://github.com/ballerina-platform/ballerina-lang/issues/29166, https://github.com/ballerina-platform/ballerina-lang/issues/19804


not working in Android Real Device

run example given in code in android real device,
its not showing any devices,
--
woking in ios simulator but not in android real device

Android doesn't support emulator only support real devices

I am trying on Android real device not emulator
On Tue, 29 Mar 2022, 8:16 pm Nankai, @.***> wrote:

Android doesn't support emulator only support real devices
—
Reply to this email directly, view it on GitHub
https://github.com/VNAPNIC/flutter_nearby_connections/issues/39#issuecomment-1081963558,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AS5API65W2SWYSK254JURLLVCMJT7ANCNFSM5R5IH5WA
.
You are receiving this because you authored the thread.Message ID:
@.***>

Same issue here.
Samsong S9, Android 10, real phone
Samsong A31, Android 11, real phone
Not working

Same issue here. Samsong S9, Android 10, real phone Samsong A31, Android 11, real phone
Not working

Did you manage to fix this?

Same issue here
Android12 Xperia
Android 13 Pixel5a

I think this not working on android real devices because of missing config in .android folder, I facing with this too and try to copy all of my code into lib's example folder and it work.


fix(notice): fix limit 1 on useNotice does not work

Closes #695
Description
fix limit 1 on useNotice does not work
Current behavior (updates)
Setting the limit value to 1 does not limit the number of displays.
New behavior
If the limit is set to 1, only one is displayed.
If an invalid value such as -1 is set for the limit value, it is ignored.
Is this a breaking change (Yes/No): No
Additional Information
NIL

@illionillion
I think it is this isssue.
https://github.com/framer/motion/issues/2462
Removing AnimatePresence in notice-provider.tsx will work correctly.
<AnimatePresence initial={false}>
    {notices.map((notice) => (
      <NoticeComponent key={notice.id} variants={variants} {...notice} />
    ))}
</AnimatePresence>

@illionillion I think it is this isssue. framer/motion#2462
Removing AnimatePresence in notice-provider.tsx will work correctly.
<AnimatePresence initial={false}>
    {notices.map((notice) => (
      <NoticeComponent key={notice.id} variants={variants} {...notice} />
    ))}
</AnimatePresence>

@108yen
Thanks.
Please correct it that way.

@illionillion
If you remove AnimatePresence, the bug will be fixed, but the animation won’t be rendered. Is that okay? Since it’s a minor bug, waiting for a fix in framer-motion might be a good idea
https://github.com/hirotomoyamada/yamada-ui/assets/9676316/0e82c9d3-c4c1-44c7-86a6-e468c4b52581

@illionillion If you remove AnimatePresence, the bug will be fixed, but the animation won’t be rendered. Is that okay? Since it’s a minor bug, waiting for a fix in framer-motion might be a good idea
notice.mp4

That's not good.
Let's wait for the framer-motion to fix it.
I think it is good to merge.


removed rgw print continue = false, to set it to its default value of…

… true
Fixes : https://github.com/ceph/ceph-ansible/issues/455

Thanks @Abhishekvrshny


Setup Github Actions to run tests for all packages

Remove deprecated .gitlab-ci.yml in each package

Remove deprecated .gitlab-ci.yml in each package

Gitlab ci was also doing npm publish so I'd like to confirm what to do about that before deleting it. Shall we add that step in the workflow to auto publish or skip it?


ghcjsHEAD: bump ghcjs shims

There have been a few fixes so it makes sense to update this.

cc @peti


[feature-#1720][connection][mongodb] Support mongodb sql mode #1722

[Support mongodb sql mode. the issue address is [1720]
https://github.com/DTStack/chunjun/issues/1720

Thanks for the PR, it would be even better if you could provide a script example and Doc


Necessary info needed for library load when system not match

Currently, we will try a default lib loader "VeloxSharedlibraryLoader" which may cause exception without more hints, like this error
Caused by: java.lang.ClassCastException: scala.runtime.BoxedUnit cannot be cast to io.glutenproject.utils.VeloxSharedlibraryLoader 	at io.glutenproject.backendsapi.velox.VeloxInitializerApi.loadLibFromJar(VeloxInitializerApi.scala:40) 	at io.glutenproject.backendsapi.velox.VeloxInitializerApi.initialize(VeloxInitializerApi.scala:48)
We'd better add a warning message to tell user it's about a OS version not supported problem.

Fixed.


Question for the cost in /data/sensor_graph/distances_la_2012.csv

Thanks for your paper and your code. I've got some problems on the cost in /data/sensor_graph/distances_la_2012.csv. According to paper, I thought that the "cost" should be the distance, but the value I calculated didn't seem like distance, may I know more about the details of the "cost"? Besides, why are the costs not symmetric?
Thanks for your answer.

Thanks for the interest of the paper. The cost in the  /data/sensor_graph/distances_la_2012.csv indicates the road network distance from the start to the end, which is not symmetric, e.g., some of roads might be one way.

Thanks again!

hello,i have a question that is how we calculate the cost in "distance_la_2012.csv"?Are you get the cost from the latitude and longitude in graph_sensor_locations.csv?

As mentioned in the Section 4, the pairwise road network distances between sensors are used as the cost.
To get the cost, we may first map the lat/lon into the road network (with map-matching), and then run the A* algorithm to find the shortest distance between sensor pairs. An alternative way is to use online Map service, which can provide the distance given a source and destination pair.


Git-it  "Pull Never Out Of Date" Unable to read Repository

I'm having an issue where I am doing this activity involving the fetching of an edited repository called "Patchfork" from Jflord.  I had already push my changes to my repository and shared my repository with RepoRobot to complete the previous activity "It's a Small World".  There were no changes made to the repository made after the activity for "Pull Never Out Of Date", but Git-It was not able to read that because it couldn't do the fetch --dry-run command through that exact repository.  I had done the command myself and it works.  Can someone look into this issue?  Thanks!

I have an update on the issue that I've been having for a while now.  I've discovered that "add-eboone.txt" is in Patchwork/Contributors folder under my branch "add-ebooneW00", but it never made it into the "gh-pages" branch.  What should I do?  Please let me know!


Add Amelia's photo

Closes #14

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:


search string not found when building Typescript Vue app

Describe the bug
After creating sample Vue Typescript app npm run build gives the error.
Reproduction
see below
Steps to reproduce

npm create vite .
select Vue then Typescript
npm install
npm run build
get error

Generated package.json
{
  "name": "vite-test",
  "private": true,
  "version": "0.0.0",
  "type": "module",
  "scripts": {
    "dev": "vite",
    "build": "vue-tsc && vite build",
    "preview": "vite preview"
  },
  "dependencies": {
    "vue": "^3.3.11"
  },
  "devDependencies": {
    "@vitejs/plugin-vue": "^4.5.2",
    "typescript": "^5.2.2",
    "vite": "^5.0.8",
    "vue-tsc": "^1.8.25"
  }
}

System Info
Arch Linux
Node v22.10.0
NPM 10.9.0

Used Package Manager
npm
Logs
realgecko@rog-strix ~/D/vite-test> npm run build

><EMAIL_ADDRESS>build
> vue-tsc && vite build

/home/realgecko/Development/vite-test/node_modules/vue-tsc/bin/vue-tsc.js:68
                        throw err;
                        ^
Search string not found: "for (const existingRoot of buildInfoVersionMap.roots) {"
(Use `node --trace-uncaught ...` to show where the exception was thrown)

Node.js v22.10.0
realgecko@rog-strix ~/D/vite-test [1]>

Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Make sure this is a Vite issue and not a framework-specific issue. For example, if it's a Vue SFC related bug, it should likely be reported to vuejs/core instead.
[X] Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
[X] The provided reproduction is a minimal reproducible example of the bug.

Running npm install vue-tsc@latest --dev fixes the problem.

Probably it's because vue-tsc@1 does not support TypeScript 5.6.
npm create vite . uses the cache stored locally regardless of a new version published on npm, it's recommended to add @latest when using npm create (e.g. npm create vite@latest .).

Thanks for clarification :+1:


Mixing and matching rendered values with html nodes

Currently a rendered value will crush html nodes declared before it:
    .person
      .address
      = Subtemplate()

.address will be removed from the DOM and only the result of Subtemplate() will remain. We should be able to keep both.
The current workaround is to wrap = Subtemplate() in a %div or other element.

Fixed


Support rust-lang/rust repo.

https://deps.rs/repo/github/rust-lang/rust

I think in order to get this to work we'd have to make it capable of following git submodules.


Refactor handlers

This changes it so that handlers take an argument for initial events (as in events that should be run once loaded)
Todo:

[x] Remove the unsafe coerces (turns out they aren't needed, I just ran into the problem with monomorphisation restriction)
[x] Remove the test deps
[x] Check that using a default record works for effect/handlers

The default record way should work for newer versions of GHC, see https://gitlab.haskell.org/ghc/ghc/-/issues/16501

Alright so adding back in the Typeable constraint ended up making everything more annoying

The typeable constraint is actually fine and good, but I'm wondering if I should bother with this at all?  instead of initEvents I could have onLoad event cont which is pretty clear and simplifies things.
Was this change worth it?  Really not sure.


Local Scope and Functions issue with commented code.

Challenge Local Scope and Functions has an issue.
User Agent is: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:50.0) Gecko/20100101 Firefox/50.0.
Please describe how to reproduce this issue, and include links to screenshots if possible.
 IF I COMMENT  IT, I SUCCESFUL FINISH THE CHALLENGE.. BUT IF I DELETE LINE 7, IT DOESN'T WORK... and if I UnComment it, so it doesn't work too.. That's a bug
myLocalScope();

// Run and check the console
// myVar is not defined outside of myLocalScope

// Now remove the console log line to pass the test

We do have an issue with commented code not working. This is also the case on beta.

/cc @freeCodeCamp/moderators

Sorry, but I'm not sure I understand the issue here.
Given the following challenge seed code:

function myLocalScope() {
  'use strict';

  console.log(myVar);
}
myLocalScope();

// Run and check the console
// myVar is not defined outside of myLocalScope
console.log(myVar);

// Now remove the console log line to pass the test

to pass this challenge:

add a local myVar
remove the console.log() call outside of the function.

Then the following code passes the tests

function myLocalScope() {
  'use strict';
  var myVar = 'totally a variable'

  console.log(myVar);
}
myLocalScope();

// Run and check the console
// myVar is not defined outside of myLocalScope

// Now remove the console log line to pass the test

@lukashanak I think the issue with your code above is that the 'use strict' option is disabled, which causes your code to behave differently.
Without strict mode, variables declared without for example var in front will be turned into global variables, which should prevent the tests from passing.
What I find strange though is that the commented line actually makes the challenge pass. Since you neither used 'use strict' or var in front of myVar, your code shouldn't pass as I explained above.
@raisedadead I've noticed this behavior earlier as well.

Yup and I notice that this is the case in the beta as well. I guess adding using strict; in the seed is one way to go. But that's gonna lead to unwanted issues, all together.

@raisedadead Maybe we could add a hidden 'use strict' in the head-section of the challenge?

add a hidden 'use strict' in the head-section of the challenge?

@Greenheart  In my opinion this will only teach bad behavior since a camper can remove the tag, submit a wrong code and still pass it giving them the false impression to have done the right thing.
Or in other word we are actually teaching (or perhaps not-teaching) a valuable lesson: why strict is important and why globals aren't always a good thing.
I would rather add some comment line (and maybe change the CSS associated) to use strict to inform the user to never remove that line
"use strict"    //NOT remove this line

Or add a test cases that will look for strict mode and prompt fail if removed.

@Greenheart
The thing is I can pass the challenge with completely incorrect code like this:
function myLocalScope() {
  'use strict';

  console.log(myVar);
}
myLocalScope();
var myVar;
// Run and check the console
// myVar is not defined outside of myLocalScope
console.log(myVar);

// Now remove the console log line to pass the test

You will notice that both the test cases should have been false with the above code.

@Marmiz @raisedadead Good points!
I'm not so sure what to do about this. What's your ideas? :blush:

Hey everyone! There's a couple of things going on here.
To understand why things are happening, looking at the tests is really helpful here
https://github.com/freeCodeCamp/freeCodeCamp/blob/f373eca1aaf963671dcafcd96f199214df7a2077/seed/challenges/02-javascript-algorithms-and-data-structures/basic-javascript.json#L2527-L2530
This explains why @raisedadead's sample passed. The text var myVar was in the code (passing the first test), but because it was not set to anything, it was still undefined (passing the first test).
It also explains why @lukashanak's original code only worked with the comment there. The text var myVar was only present within the comment (passing the first test). Because it was in a comment, even though the text was there, the variable was still undefined (passing the second test). If the comment was removed, the text var myVar was no longer anywhere in the code (failing the first test).
It is currently possible to pass this challenge with the following as the entire code:
// var myVar

Potential solution
Requiring myVar to be set to a specific value will make sure incorrect solutions like the one @raisedadead shared won't work. We could also check whether the line that contains the var myVar declaration doesn't start with //. Checking for multiline comments seems to complicated for a regex, but the chance of that happening seems low.

@systimotic Great detective work here, and thanks for resurrecting this old (but unresolved) issue.
Yes - I agree with your potential solution. Could you create a PR for this?
Regarding removing commented code before processing, this sounds like it would be a good long-term solution for this kind of situation, but would involve changes to the platform itself. So I'll CC @BerkeleyTrue on this.

I'm closing this issue as stale since it hasn't been active lately. If you think this is still relevant to the newly updated platform, please explain why, then reopen it.


TimeoutException is not raised if using subprocess

I'm using Tesseract as OCR engine to process some documents. However, I would like to restrict the time of execution for tesseract process max to 5 mins.
The problem is that the code below sometimes kills the process properly after 5 mins, but sometimes I see a slowdown in the system due to tesseract process running for much longer.
For example, today I've noticed in logs that it took 37 minutes between Will run OCR... and Tesseract timed out. Killing the ocr process ...  (Code block execution exceeded 300 seconds timeout internal stopit log message).
try:
    with stopit.ThreadingTimeout(300, swallow_exc=False):
        logger.info('Will run OCR...')

        command = 'tesseract {} {} --psm 1 -l eng hocr'.format(image_path, hocr_file_path).split()
        ocr_process = subprocess.Popen(command, stdout=subprocess.PIPE, stderr=subprocess.PIPE)
        # Wait for the tesseract process to finish and fetch stdout/stderr
        stdout, stderr = self.ocr_process.communicate()

        # ...
        # Do some processing of results
except stopit.utils.TimeoutException:
    logger.exception('Tesseract timed out. Killing the ocr process ...')
    ocr_process.kill()
    # ...

Can you help me please to understand if I'm using stopit for the wrong scenario or what can be the problem?

HI @azastupailo , you hit another limitation of stopit I didn't mention in the doc, and you made a mistake in your code. stopit ignores and cannot control (kill) a subprocess. You should use the timeout optional parameter of the communicate() method of Popen objects.
https://docs.python.org/3/library/subprocess.html#subprocess.Popen.communicate

Hi @glenfant , thank you for taking a look at the issue so fast. Also, good catch with a timeout parameter! I'll try to implement and test fixes in a couple of days and will update the issue so that maybe it will save some time for somebody else.

The README writes that the ThreadingTimeout CM "Can't interrupt a long Python atomic instruction. e.g. if time.sleep(20.0) is actually executing, the timeout will take effect at the end of the execution of this line.". That's what happened. The TimeoutException is in effect AFTER the end of call of communicate() call because this took more than 5 minutes.

Note that the new asyncio based subprocesses control provides a clean way to manage timeout in subprocesses too.

@glenfant thank you for your suggestions again. For now we sticked with the timeout parameter in communicate() method as it does the job in our case and it was a quick change. However, we'll consider asyncio too for our scenario.
We migrated recently from Python 2 to 3 and timeout was introduced in Python 3 which we somehow missed.
Anyways, thank you for this library and your support.


li instruction after div expansion does not get expanded properly

First note, I'm not certain if the title of this issue is accurate.
As context, I have a matching scratch for a function here: https://decomp.me/scratch/U1RC7
Assembly line 0x6e8 uses a li      a0,0x1000, which of course needs to be expanded. In the game binary, this is a ori   $a0, $zero, 0x1000, but when I build, I get addiu $a0, $zero, 0x1000.
To diagnose the issue, I broke up the build process by running up until the step which invokes maspsx. That produced the following file:
https://gist.github.com/bismurphy/c45f2baa19144e249da115cab8bfdd35
The relevant instruction is under the LM188: label.
To replicate the problem, go to the sotn-decomp root directory, and copy the above gist file into that root directory (of course, you don't actually have to do this in the sotn-decomp directory, you could do it on a "naked" maspsx, but I'm describing my own process). Then, with the file in the working directory with the filename maspsx_testcase, run:
cat maspsx_testcase | python3 tools/maspsx/maspsx.py --no-macro-inc --expand-div --expand-li > maspsx_output.txt
If you then open maspsx_output.txt, you'll find that under LM188, there is a commented copy of the li line, as well as a non-commented version right above. But both of them retain the li, rather than expanding it according to the expand-li option.
I believe the root of this issue is here: https://github.com/mkst/maspsx/blob/master/maspsx/init.py#L413 in the fact that, if an instruction is skipped (which in this case the li is), then it will never get a chance to run the expand-li logic, and will not be expanded. This leads to the li instruction going through to the assembler unchanged. Ultimately, this is because the li instruction is sandwiched directly between div instructions which each get expanded.
I am not familiar enough with maspsx to propose a fix that would solve this, but hopefully this issue report is detailed enough to fully describe the problem. I hope having the compiled file to directly pass to maspsx is also helpful.

Closed via #47.


Call modification

Hi Peng,
Thanks again for ccsmeth. You suggested using "Quick start", I have a question related to the call modification step and train step. What is the difference between the two steps? If I skip the modification call and after the first and second steps, extract the features from hifi reads, that would be correct? Why should I do the modification step?
Thanks a lot for your time and help.

I guess the call modification step is important because that gives you the modification probabilities of each potentially methylated cytosine base and also it gives you the sequence context of methylation and other information.

@RahelehSalehi , train step is for traing a new model for modification calling, while call modificatino step calls per-read modifications from ccs.ban with a pre-trained model as @olaraym said.

Dear PengNi,
I ran ccsmeth call_mods on my dataset. the problem is that after 21% of running, the running process is frozen and it doesn't work. I got the following errors:   File "/home/rsalehi/miniconda3/envs/ccsmethenv/lib/python3.8/site-packages/torch/serialization.py", line 920, in _legacy_load
magic_number = pickle_module.load(f, **pickle_load_args)
_pickle.UnpicklingError: invalid load key, '{'.
Process Process-4:
Traceback (most recent call last):
File "/home/rsalehi/miniconda3/envs/ccsmethenv/lib/python3.8/multiprocessing/process.py", line 315, in _bootstrap
self.run()
File "/home/rsalehi/miniconda3/envs/ccsmethenv/lib/python3.8/multiprocessing/process.py", line 108, in run
self._target(*self._args, **self._kwargs)
File "/home/rsalehi/miniconda3/envs/ccsmethenv/lib/python3.8/site-packages/ccsmeth/call_modifications.py", line 301, in _call_mods_q
para_dict = torch.load(model_path, map_location=torch.device('cpu'))
File "/home/rsalehi/miniconda3/envs/ccsmethenv/lib/python3.8/site-packages/torch/serialization.py", line 713, in load
return _legacy_load(opened_file, map_location, pickle_module, **pickle_load_args)
File "/home/rsalehi/miniconda3/envs/ccsmethenv/lib/python3.8/site-packages/torch/serialization.py", line 920, in _legacy_load
magic_number = pickle_module.load(f, **pickle_load_args)
_pickle.UnpicklingError: invalid load key, '{'.
split_holebatches process-1579883 generates 9347 hole/read batches(50)
Could you please help me, with how I can solve my problem?
Thanks alot.

Dear PengNi, I ran ccsmeth call_mods on my dataset. the problem is that after 21% of running, the running process is frozen and it doesn't work. I got the following errors: File "/home/rsalehi/miniconda3/envs/ccsmethenv/lib/python3.8/site-packages/torch/serialization.py", line 920, in _legacy_load magic_number = pickle_module.load(f, **pickle_load_args) _pickle.UnpicklingError: invalid load key, '{'. Process Process-4: Traceback (most recent call last): File "/home/rsalehi/miniconda3/envs/ccsmethenv/lib/python3.8/multiprocessing/process.py", line 315, in _bootstrap self.run() File "/home/rsalehi/miniconda3/envs/ccsmethenv/lib/python3.8/multiprocessing/process.py", line 108, in run self._target(*self._args, **self._kwargs) File "/home/rsalehi/miniconda3/envs/ccsmethenv/lib/python3.8/site-packages/ccsmeth/call_modifications.py", line 301, in _call_mods_q para_dict = torch.load(model_path, map_location=torch.device('cpu')) File "/home/rsalehi/miniconda3/envs/ccsmethenv/lib/python3.8/site-packages/torch/serialization.py", line 713, in load return _legacy_load(opened_file, map_location, pickle_module, **pickle_load_args) File "/home/rsalehi/miniconda3/envs/ccsmethenv/lib/python3.8/site-packages/torch/serialization.py", line 920, in _legacy_load magic_number = pickle_module.load(f, **pickle_load_args) _pickle.UnpicklingError: invalid load key, '{'. split_holebatches process-1579883 generates 9347 hole/read batches(50) Could you please help me, with how I can solve my problem?
Thanks alot.

I guess this is because the model ckpt file doesn't match the version of ccsmeth. Please update ccsmeth to the latest version, and use the latest model in the `models' directory, and then try again.  If you still have problems, please contact me again. Thank you.
Best,
Peng

Thanks a lot for the quick reply.  I updated ccsmeth in the new version, it is frozen again at the beginning, I got the following error:
Traceback (most recent call last):
File "/home/rsalehi/miniconda3/envs/ccsmethenv/lib/python3.8/multiprocessing/process.py", line 315, in _bootstrap
self.run()
File "/home/rsalehi/miniconda3/envs/ccsmethenv/lib/python3.8/multiprocessing/process.py", line 108, in run
self._target(*self._args, **self._kwargs)
File "/home/rsalehi/miniconda3/envs/ccsmethenv/lib/python3.8/site-packages/ccsmeth-0.4.1-py3.8.egg/ccsmeth/call_modifications.py", line 327, in _call_mods_q
para_dict = torch.load(model_path, map_location=torch.device('cpu'))
File "/home/rsalehi/miniconda3/envs/ccsmethenv/lib/python3.8/site-packages/torch/serialization.py", line 713, in load
return _legacy_load(opened_file, map_location, pickle_module, **pickle_load_args)
File "/home/rsalehi/miniconda3/envs/ccsmethenv/lib/python3.8/site-packages/torch/serialization.py", line 920, in _legacy_load
magic_number = pickle_module.load(f, **pickle_load_args)
_pickle.UnpicklingError: invalid load key, '{'.
Traceback (most recent call last):
File "/home/rsalehi/miniconda3/envs/ccsmethenv/lib/python3.8/multiprocessing/process.py", line 315, in _bootstrap
self.run()
File "/home/rsalehi/miniconda3/envs/ccsmethenv/lib/python3.8/multiprocessing/process.py", line 108, in run
self._target(*self._args, **self._kwargs)
File "/home/rsalehi/miniconda3/envs/ccsmethenv/lib/python3.8/site-packages/ccsmeth-0.4.1-py3.8.egg/ccsmeth/call_modifications.py", line 327, in _call_mods_q
para_dict = torch.load(model_path, map_location=torch.device('cpu'))
File "/home/rsalehi/miniconda3/envs/ccsmethenv/lib/python3.8/site-packages/torch/serialization.py", line 713, in load
return _legacy_load(opened_file, map_location, pickle_module, **pickle_load_args)
File "/home/rsalehi/miniconda3/envs/ccsmethenv/lib/python3.8/site-packages/torch/serialization.py", line 920, in _legacy_load
magic_number = pickle_module.load(f, **pickle_load_args)
_pickle.UnpicklingError: invalid load key, '{'.
2023-07-11 09:06:21 - INFO - split_holebatches process-2083568 generates 9347 hole/read batches(50)
batch_reader:   1%|▋                                                                                | 65/9347 [00:19<04:10, 37.01it/s]
Thanks a lot to help me out.

@RahelehSalehi , could you tell me the exact command and the model file you are using?

Of course, I use this:
ccsmeth call_mods --input /playground/AK_Giehr/user/rahelehsalehi/Ssm/SEQ00XX/2-Align/call-align-16/data/hifi-SEQ00XX-barcode-16.pbmm2.bam --ref /playground/AK_Giehr/genomes/ncbi/Escherichia_phage_Lambda/GCF_000840245.1_ViralProj14204_genomic.fasta --model_file /playground/AK_Giehr/user/rahelehsalehi/Ssm/SEQ00XX/3-Call-Mod/On_Cluster/traind-model/model_ccsmeth_5mCpG_aggregate_attbigru_b11.v2p.ckpt --output /playground/AK_Giehr/user/rahelehsalehi/Ssm/SEQ00XX/3-Call-Mod/On_Cluster/Call-mod-16/data/SEQ00XX-barcode-16.hifi.pbmm2.call_mods --threads 10 --threads_call 2 --mode align --model_type attbilstm2s

It seems it works, thanks alot

still, the error is there:
File "/home/rsalehi/miniconda3/envs/ccsmethenv/lib/python3.8/site-packages/torch/serialization.py", line 920, in _legacy_load
magic_number = pickle_module.load(f, **pickle_load_args)
_pickle.UnpicklingError: invalid load key, '{'.
2023-07-11 09:36:34 - INFO - extract_features process-2090330 starts
2023-07-11 09:36:34 - INFO - extract_features process-2089363 starts
2023-07-11 09:36:34 - INFO - extract_features process-2089370 starts
2023-07-11 09:36:35 - INFO - extract_features process-2090315 starts
2023-07-11 09:36:35 - INFO - split_holebatches process-2089361 generates 9347 hole/read batches(50)
batch_reader:   0%|                                                                                | 0/9347 [00:00<?, ?it/s]2023-07-11 09:36:35 - INFO - extract_features process-2091049 starts
2023-07-11 09:36:35 - INFO - extract_features process-2089369 starts
2023-07-11 09:36:35 - INFO - extract_features process-2090653 starts
2023-07-11 09:36:35 - INFO - extract_features process-2089371 starts
2023-07-11 09:36:35 - INFO - extract_features process-2090941 starts
2023-07-11 09:36:35 - INFO - extract_features process-2091452 starts
2023-07-11 09:36:35 - INFO - extract_features process-2091309 starts
2023-07-11 09:36:35 - INFO - extract_features process-2091052 starts
2023-07-11 09:36:35 - INFO - extract_features process-2091126 starts
2023-07-11 09:36:35 - INFO - extract_features process-2089365 starts
2023-07-11 09:36:35 - INFO - extract_features process-2089367 starts
2023-07-11 09:36:35 - INFO - extract_features process-2091382 starts
2023-07-11 09:36:35 - INFO - extract_features process-2091454 starts
2023-07-11 09:36:35 - INFO - extract_features process-2091055 starts
batch_reader:   0%|▏                                                                                | 18/9347 [00:00<00:53, 175.16it/s]2023-07-11 09:36:35 - INFO - extract_features process-2089373 starts
2023-07-11 09:36:35 - INFO - extract_features process-2091387 starts
2023-07-11 09:36:35 - INFO - extract_features process-2091652 starts
2023-07-11 09:36:35 - INFO - extract_features process-2091409 starts
2023-07-11 09:36:35 - INFO - extract_features process-2091648 starts
2023-07-11 09:36:35 - INFO - extract_features process-2091124 starts
2023-07-11 09:36:35 - INFO - extract_features process-2091192 starts
2023-07-11 09:36:35 - INFO - extract_features process-2091536 starts
2023-07-11 09:36:35 - INFO - extract_features process-2089372 starts
2023-07-11 09:36:35 - INFO - extract_features process-2090518 starts
2023-07-11 09:36:35 - INFO - extract_features process-2091583 starts
2023-07-11 09:36:35 - INFO - extract_features process-2090848 starts
2023-07-11 09:36:35 - INFO - extract_features process-2091045 starts
2023-07-11 09:36:35 - INFO - extract_features process-2091650 starts
2023-07-11 09:36:35 - INFO - extract_features process-2091125 starts
2023-07-11 09:36:35 - INFO - extract_features process-2091717 starts
2023-07-11 09:36:35 - INFO - extract_features process-2091054 starts
2023-07-11 09:36:35 - INFO - extract_features process-2090783 starts
2023-07-11 09:36:35 - INFO - extract_features process-2091181 starts
2023-07-11 09:36:35 - INFO - extract_features process-2090670 starts
2023-07-11 09:36:35 - INFO - extract_features process-2091582 starts
2023-07-11 09:36:35 - INFO - extract_features process-2091651 starts
2023-07-11 09:36:35 - INFO - extract_features process-2091050 starts
2023-07-11 09:36:35 - INFO - extract_features process-2091107 starts
batch_reader:   0%|▌                                                                                | 38/9347 [00:00<00:49, 186.79it/s]2023-07-11 09:36:35 - INFO - extract_features process-2091257 starts
2023-07-11 09:36:35 - INFO - extract_features process-2090980 starts
2023-07-11 09:36:35 - INFO - extract_features process-2089632 starts
2023-07-11 09:36:35 - INFO - extract_features process-2091056 starts
2023-07-11 09:36:35 - INFO - extract_features process-2091047 starts
2023-07-11 09:36:35 - INFO - extract_features process-2091258 starts
2023-07-11 09:36:35 - INFO - extract_features process-2091649 starts
2023-07-11 09:36:35 - INFO - extract_features process-2091059 starts
batch_reader:   5%|██████▎                                                                                | 469/9347 [00:19<00:33, 263.97it/s]

Thanks, I used all your recommendations, and still, the error is there. It seems the error is related to pickle library. Maybe I should use another version of python?
File "/home/rsalehi/miniconda3/envs/ccsmethenv/lib/python3.8/site-packages/torch/serialization.py", line 920, in _legacy_load
magic_number = pickle_module.load(f, **pickle_load_args)
_pickle.UnpicklingError: invalid load key, '{'.

@RahelehSalehi , thanks for your patience. I can't reproduce this error myself. Maybe you can try the One-step installation in README to re-install a virtual environment.
If it still doesn't work, please show me the version of all packages in your environment by using conda list.

Thanks, I used all your recommendations, and still, the error is there. It seems the error is related to pickle library. Maybe I should use another version of python? File "/home/rsalehi/miniconda3/envs/ccsmethenv/lib/python3.8/site-packages/torch/serialization.py", line 920, in _legacy_load magic_number = pickle_module.load(f, **pickle_load_args) _pickle.UnpicklingError: invalid load key, '{'.

I reinstalled again ccsmeth package and still the error is coming up. Please find the version of all packages in my environment here:
Name                    Version                   Build  Channel
_libgcc_mutex             0.1                        main
_openmp_mutex             5.1                       1_gnu
bedtools                  2.26.0                        0    bioconda
blas                      1.0                         mkl
bzip2                     1.0.8                h7b6447c_0
c-ares                    1.19.0               h5eee18b_0
ca-certificates           2023.05.30           h06a4308_0
ccsmeth                   0.4.1                    pypi_0    pypi
cudatoolkit               10.2.89              hfd86e86_1
curl                      8.1.1                h5eee18b_1
cython                    0.29.36                  pypi_0    pypi
intel-openmp              2023.1.0         hdb19cb5_46305
joblib                    1.3.1                    pypi_0    pypi
krb5                      1.20.1               h568e23c_1
ld_impl_linux-64          2.38                 h1181459_1
libcurl                   8.1.1                h91b91d3_1
libedit                   3.1.20221030         h5eee18b_0
libev                     4.33                 h7f8727e_1
libffi                    3.4.4                h6a678d5_0
libgcc                    7.2.0                h69d50b8_2
libgcc-ng                 11.2.0               h1234567_1
libgomp                   11.2.0               h1234567_1
libnghttp2                1.52.0               ha637b67_1
libssh2                   1.10.0               h37d81fd_2
libstdcxx-ng              11.2.0               h1234567_1
libuv                     1.44.2               h5eee18b_0
mkl                       2023.1.0         h6d00ec8_46342
ncurses                   6.4                  h6a678d5_0
numpy                     1.24.4                   pypi_0    pypi
openssl                   1.1.1u               h7f8727e_0
packaging                 23.1                     pypi_0    pypi
pandas                    2.0.3                    pypi_0    pypi
patsy                     0.5.3                    pypi_0    pypi
pbccs                     6.4.0                h9ee0642_0    bioconda
pbmm2                     1.12.0               h9ee0642_0    bioconda
pip                       23.1.2           py38h06a4308_0
pybedtools                0.9.0                    pypi_0    pypi
pysam                     0.21.0                   pypi_0    pypi
pytabix                   0.1                      pypi_0    pypi
python                    3.8.17               h7a1cb2a_0
python-dateutil           2.8.2                    pypi_0    pypi
pytorch                   1.11.0          py3.8_cuda10.2_cudnn7.6.5_0    pytorch
pytorch-mutex             1.0                        cuda    pytorch
pytz                      2023.3                   pypi_0    pypi
readline                  8.2                  h5eee18b_0
samtools                  1.5                           1    bioconda
scikit-learn              1.3.0                    pypi_0    pypi
scipy                     1.10.1                   pypi_0    pypi
setuptools                67.8.0           py38h06a4308_0
six                       1.16.0                   pypi_0    pypi
sqlite                    3.41.2               h5eee18b_0
statsmodels               0.14.0                   pypi_0    pypi
tbb                       2021.8.0             hdb19cb5_0
threadpoolctl             3.1.0                    pypi_0    pypi
tk                        8.6.12               h1ccaba5_0
torch                     1.12.1                   pypi_0    pypi
tqdm                      4.65.0                   pypi_0    pypi
typing-extensions         4.7.1                    pypi_0    pypi
typing_extensions         4.6.3            py38h06a4308_0
tzdata                    2023.3                   pypi_0    pypi
wheel                     0.38.4           py38h06a4308_0
xz                        5.4.2                h5eee18b_0
zlib                      1.2.13               h5eee18b_0

@RahelehSalehi , from the versions I still can't find any problem. May you list the directory that you use to save the models (the /playground/AK_Giehr/user/rahelehsalehi/Ssm/SEQ00XX/3-Call-Mod/On_Cluster/traind-model/ dir) by ls -la? Maybe there are problems in the model files.

Of course! Here you are:

There is no error now, but it is still frozen after 5% of the process. Do you have any suggestions?
1234
===============================================
2023-07-11 15:47:29 - INFO - [main]call_mods starts
2023-07-11 15:47:29 - INFO - cuda availability: False
2023-07-11 15:47:30 - INFO - split_holebatches process-2353074 starts
2023-07-11 15:47:32 - INFO - extract_features process-2353340 starts
2023-07-11 15:47:32 - INFO - extract_features process-2353185 starts
2023-07-11 15:47:32 - INFO - extract_features process-2353276 starts
2023-07-11 15:47:32 - INFO - extract_features process-2353406 starts
2023-07-11 15:47:33 - INFO - extract_features process-2353405 starts
2023-07-11 15:47:33 - INFO - extract_features process-2353472 starts
2023-07-11 15:47:33 - INFO - extract_features process-2354499 starts
2023-07-11 15:47:33 - INFO - extract_features process-2354645 starts
2023-07-11 15:47:33 - INFO - extract_features process-2353076 starts
2023-07-11 15:47:33 - INFO - call_mods process-2353077 starts
2023-07-11 15:47:33 - INFO - extract_features process-2353341 starts
2023-07-11 15:47:33 - INFO - extract_features process-2353418 starts
2023-07-11 15:47:33 - INFO - extract_features process-2353718 starts
2023-07-11 15:47:33 - INFO - extract_features process-2354507 starts
2023-07-11 15:47:33 - INFO - extract_features process-2354512 starts
2023-07-11 15:47:33 - INFO - extract_features process-2353212 starts
2023-07-11 15:47:33 - INFO - extract_features process-2353120 starts
2023-07-11 15:47:33 - INFO - extract_features process-2353082 starts
2023-07-11 15:47:33 - INFO - extract_features process-2353078 starts
2023-07-11 15:47:33 - INFO - extract_features process-2355208 starts
2023-07-11 15:47:33 - INFO - extract_features process-2355577 starts
2023-07-11 15:47:33 - INFO - call_mods process-2353079 starts
2023-07-11 15:47:33 - INFO - extract_features process-2354040 starts
2023-07-11 15:47:33 - INFO - extract_features process-2353081 starts
2023-07-11 15:47:33 - INFO - extract_features process-2354504 starts
2023-07-11 15:47:33 - INFO - extract_features process-2354506 starts
2023-07-11 15:47:33 - INFO - extract_features process-2353080 starts
2023-07-11 15:47:33 - INFO - extract_features process-2355546 starts
2023-07-11 15:47:33 - INFO - extract_features process-2355547 starts
2023-07-11 15:47:33 - INFO - extract_features process-2354509 starts
2023-07-11 15:47:33 - INFO - extract_features process-2354360 starts
2023-07-11 15:47:33 - INFO - extract_features process-2354364 starts
2023-07-11 15:47:33 - INFO - extract_features process-2354430 starts
2023-07-11 15:47:33 - INFO - extract_features process-2355093 starts
2023-07-11 15:47:33 - INFO - extract_features process-2354511 starts
2023-07-11 15:47:33 - INFO - extract_features process-2353083 starts
2023-07-11 15:47:33 - INFO - extract_features process-2355469 starts
2023-07-11 15:47:33 - INFO - extract_features process-2354496 starts
2023-07-11 15:47:33 - INFO - split_holebatches process-2353074 generates 9347 hole/read batches(50)
batch_reader:   0%|                                                                                | 0/9347 [00:00<?, ?it/s]2023-07-11 15:47:33 - INFO - extract_features process-2355351 starts
2023-07-11 15:47:33 - INFO - extract_features process-2355092 starts
2023-07-11 15:47:33 - INFO - extract_features process-2354298 starts
2023-07-11 15:47:33 - INFO - extract_features process-2354169 starts
2023-07-11 15:47:33 - INFO - extract_features process-2355471 starts
2023-07-11 15:47:33 - INFO - extract_features process-2354233 starts
2023-07-11 15:47:33 - INFO - extract_features process-2354773 starts
2023-07-11 15:47:33 - INFO - extract_features process-2355099 starts
2023-07-11 15:47:33 - INFO - extract_features process-2354495 starts
2023-07-11 15:47:33 - INFO - extract_features process-2354362 starts
2023-07-11 15:47:33 - INFO - extract_features process-2354516 starts
2023-07-11 15:47:33 - INFO - extract_features process-2354498 starts
2023-07-11 15:47:33 - INFO - extract_features process-2354502 starts
2023-07-11 15:47:33 - INFO - extract_features process-2354901 starts
2023-07-11 15:47:33 - INFO - extract_features process-2355095 starts
2023-07-11 15:47:33 - INFO - extract_features process-2354514 starts
2023-07-11 15:47:33 - INFO - extract_features process-2355576 starts
2023-07-11 15:47:33 - INFO - extract_features process-2354510 starts
2023-07-11 15:47:33 - INFO - extract_features process-2354287 starts
2023-07-11 15:47:33 - INFO - extract_features process-2354428 starts
batch_reader:   0%|▎                                                                                | 26/9347 [00:00<00:36, 252.16it/s]2023-07-11 15:47:33 - INFO - extract_features process-2354518 starts
2023-07-11 15:47:33 - INFO - extract_features process-2354513 starts
2023-07-11 15:47:33 - INFO - extract_features process-2355088 starts
2023-07-11 15:47:33 - INFO - extract_features process-2354361 starts
batch_reader:   5%|██████▍                                                                                | 459/9347 [00:02<00:40, 218.67it/s]batch_reader:   5%|██████▋                                                                                | 471/9347 [00:19<00:40, 218.67i

There is no error now, but it is still frozen after 5% of the process. Do you have any suggestions? 1234
===============================================
2023-07-11 15:47:29 - INFO - [main]call_mods starts 2023-07-11 15:47:29 - INFO - cuda availability: False 2023-07-11 15:47:30 - INFO - split_holebatches process-2353074 starts 2023-07-11 15:47:32 - INFO - extract_features process-2353340 starts 2023-07-11 15:47:32 - INFO - extract_features process-2353185 starts 2023-07-11 15:47:32 - INFO - extract_features process-2353276 starts 2023-07-11 15:47:32 - INFO - extract_features process-2353406 starts 2023-07-11 15:47:33 - INFO - extract_features process-2353405 starts 2023-07-11 15:47:33 - INFO - extract_features process-2353472 starts 2023-07-11 15:47:33 - INFO - extract_features process-2354499 starts 2023-07-11 15:47:33 - INFO - extract_features process-2354645 starts 2023-07-11 15:47:33 - INFO - extract_features process-2353076 starts 2023-07-11 15:47:33 - INFO - call_mods process-2353077 starts 2023-07-11 15:47:33 - INFO - extract_features process-2353341 starts 2023-07-11 15:47:33 - INFO - extract_features process-2353418 starts 2023-07-11 15:47:33 - INFO - extract_features process-2353718 starts 2023-07-11 15:47:33 - INFO - extract_features process-2354507 starts 2023-07-11 15:47:33 - INFO - extract_features process-2354512 starts 2023-07-11 15:47:33 - INFO - extract_features process-2353212 starts 2023-07-11 15:47:33 - INFO - extract_features process-2353120 starts 2023-07-11 15:47:33 - INFO - extract_features process-2353082 starts 2023-07-11 15:47:33 - INFO - extract_features process-2353078 starts 2023-07-11 15:47:33 - INFO - extract_features process-2355208 starts 2023-07-11 15:47:33 - INFO - extract_features process-2355577 starts 2023-07-11 15:47:33 - INFO - call_mods process-2353079 starts 2023-07-11 15:47:33 - INFO - extract_features process-2354040 starts 2023-07-11 15:47:33 - INFO - extract_features process-2353081 starts 2023-07-11 15:47:33 - INFO - extract_features process-2354504 starts 2023-07-11 15:47:33 - INFO - extract_features process-2354506 starts 2023-07-11 15:47:33 - INFO - extract_features process-2353080 starts 2023-07-11 15:47:33 - INFO - extract_features process-2355546 starts 2023-07-11 15:47:33 - INFO - extract_features process-2355547 starts 2023-07-11 15:47:33 - INFO - extract_features process-2354509 starts 2023-07-11 15:47:33 - INFO - extract_features process-2354360 starts 2023-07-11 15:47:33 - INFO - extract_features process-2354364 starts 2023-07-11 15:47:33 - INFO - extract_features process-2354430 starts 2023-07-11 15:47:33 - INFO - extract_features process-2355093 starts 2023-07-11 15:47:33 - INFO - extract_features process-2354511 starts 2023-07-11 15:47:33 - INFO - extract_features process-2353083 starts 2023-07-11 15:47:33 - INFO - extract_features process-2355469 starts 2023-07-11 15:47:33 - INFO - extract_features process-2354496 starts 2023-07-11 15:47:33 - INFO - split_holebatches process-2353074 generates 9347 hole/read batches(50) batch_reader: 0%| | 0/9347 [00:00<?, ?it/s]2023-07-11 15:47:33 - INFO - extract_features process-2355351 starts 2023-07-11 15:47:33 - INFO - extract_features process-2355092 starts 2023-07-11 15:47:33 - INFO - extract_features process-2354298 starts 2023-07-11 15:47:33 - INFO - extract_features process-2354169 starts 2023-07-11 15:47:33 - INFO - extract_features process-2355471 starts 2023-07-11 15:47:33 - INFO - extract_features process-2354233 starts 2023-07-11 15:47:33 - INFO - extract_features process-2354773 starts 2023-07-11 15:47:33 - INFO - extract_features process-2355099 starts 2023-07-11 15:47:33 - INFO - extract_features process-2354495 starts 2023-07-11 15:47:33 - INFO - extract_features process-2354362 starts 2023-07-11 15:47:33 - INFO - extract_features process-2354516 starts 2023-07-11 15:47:33 - INFO - extract_features process-2354498 starts 2023-07-11 15:47:33 - INFO - extract_features process-2354502 starts 2023-07-11 15:47:33 - INFO - extract_features process-2354901 starts 2023-07-11 15:47:33 - INFO - extract_features process-2355095 starts 2023-07-11 15:47:33 - INFO - extract_features process-2354514 starts 2023-07-11 15:47:33 - INFO - extract_features process-2355576 starts 2023-07-11 15:47:33 - INFO - extract_features process-2354510 starts 2023-07-11 15:47:33 - INFO - extract_features process-2354287 starts 2023-07-11 15:47:33 - INFO - extract_features process-2354428 starts batch_reader: 0%|▎ | 26/9347 [00:00<00:36, 252.16it/s]2023-07-11 15:47:33 - INFO - extract_features process-2354518 starts 2023-07-11 15:47:33 - INFO - extract_features process-2354513 starts 2023-07-11 15:47:33 - INFO - extract_features process-2355088 starts 2023-07-11 15:47:33 - INFO - extract_features process-2354361 starts batch_reader: 5%|██████▍ | 459/9347 [00:02<00:40, 218.67it/s]batch_reader: 5%|██████▋ | 471/9347 [00:19<00:40, 218.67i

@RahelehSalehi, maybe this is because the process is too slow. We recommend to use a GPU machine for call_mods if available.
Best,
Peng

Thank you so much for your response. I tried on GPU as well, before that I reinstalled the ccsmeth package, then I ran the command, and the following error is coming up. Do you have any suggestions?

Thank you so much for your response. I tried on GPU as well, before that I reinstalled the ccsmeth package, then I ran the command, and the following error is coming up. Do you have any suggestions?

Hi @RahelehSalehi , what's the command and the model file you used?

I used this command:
ccsmeth call_mods --input /data/raheleh_salehi/Strand-Specific-Methylation/SEQ00XX/3-Call-Mod/Dataset/call-align-16/data/hifi-SEQ00XX-barcode-16.pbmm2.bam --ref /data/raheleh_salehi/Strand-Specific-Methylation/SEQ00XX/3-Call-Mod/Dataset/genome/GCF_000840245.1_ViralProj14204_genomic.fasta --model_file /data/raheleh_salehi/Strand-Specific-Methylation/SEQ00XX/3-Call-Mod/traind-model/model_ccsmeth_5mCpG_call_mods_attbigru2s_b21.v2.ckpt --output /data/raheleh_salehi/Strand-Specific-Methylation/SEQ00XX/3-Call-Mod/Call-mod-16/data/SEQ00XX-barcode-16.hifi.pbmm2.call_mods --threads 10 --threads_call 2 --mode align --model_type attbilstm2s
and the model is model_ccsmeth_5mCpG_call_mods_attbigru2s_b21.v2.ckpt

@RahelehSalehi ， please use --model_type attbigru2s and try again.

Thanks alot, I change the model_type, there is no error, but still it is frozen :(

@RahelehSalehi , maybe it is because the GPU card in your machine is too new for the pytorch and CUDA version in the virtual environment. ref: https://discuss.pytorch.org/t/nvidia-geforce-rtx-3090-with-cuda-capability-sm-86-is-not-compatible-with-the-current-pytorch-installation/141940.
What is the CUDA driver version in your machine? can you show me what nvidia-smi shows? If the CUDA driver version in your machine is greater than 11.3, then you can reinstall pytorch in the ccsmethenv virtual environment by:
conda install pytorch==1.11.0 torchvision==0.12.0 torchaudio==0.11.0 cudatoolkit=11.3 -c pytorch


[aes] Replace more number literals with params, parameterize CTR module

This PR replaces more number literals inside aes_core/control.sv with parameters exported by the register tool. In addition, the counter module is now parameterized.
This is a follow up of #5697. Note that the PR contains many white space changes. I recommend not to display them for review.

Thanks for the quick review @cdgori !
@tjaychen or @msfschaffner , would it be possible for one of you to quickly check lint for this PR please? The last PR already introduced some errors and I suspect this one might, too.

will do!
i will let you know shortly..
On Tue, Mar 23, 2021 at 1:34 PM Pirmin Vogel @.***>
wrote:

Thanks for the quick review @cdgori https://github.com/cdgori !
@tjaychen https://github.com/tjaychen or @msfschaffner
https://github.com/msfschaffner , would it be possible for one of you
to quickly check lint for this PR please? The last PR already introduced
some errors and I suspect this one might, too.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/lowRISC/opentitan/pull/5745#issuecomment-805233098,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAH2RSST5HDA4DZWL5QRZFLTFD3OJANCNFSM4ZU5K5EA
.

looks completely clean!

Great, I was pretty sure the parameterization of the counter module would lead to new lint errors. Thanks a lot for checking @tjaychen !


Apple Homekit theme

There is no Apple Homekit theme maybe it can be in framework7?

Your issue is closed because it is not filled correctly. Before you open an issue please review the contributing guideline.
Please fill the issue template correctly and:

Clearly describe the issue including steps to reproduce when it is a bug.
Make sure you fill in the earliest version that you know has the issue.
Provide live link or JSFiddle/Codepen or website with isssue

It will save a lot of time for other contributors to check your issue and fix it.


Adding functools.wraps to generate_calls().

Fixes #103.

For now, this has no tests, simply because I wanted to get it out for discussion with @theacodes. I am in the process of writing a few tests right now.

@theacodes I'm struggling here with the tests. I made an overly-specific update to test__parametrize.py but I think there needs to be an end-to-end test in place. Can you do the honor of deciding where it goes and how to run it? I'm happy to supply cases to be placed in there.

Can you do the honor of deciding where it goes and how to run it?

Maybe makes sense for manifest to test the two combinations?

ISTM that test_manifest.py is too "unit testy", i.e. it invokes methods on Manifest directly, rather than running the whole system.

Eh, I'm fine with mixing "unit" tests and "integration" tests, as I really don't (personally) make a distinction.

@theacodes PTAL. I went a little wild and did some editorializing (that I maybe should put in a new PR):

Added a LICENSE header to tests/resources/noxfile.py
Removed your nox._testing.Namespace class and just replaced with argparse.Namespace.

Rather than putting the end-to-end test in test_manifest.py I put it in test_main.py. It (right now) has way too many magic strings in it, so we should discuss how to make the test less dependent on the contents of the source file. I could just dump contents in a tempfile, but I actually like the idea of having a sample repository of configs you could point users to.

Looks fine, just one little comment. Definitely appreciate the cleanup work.

Go for it! Thank you! :)
On Thu, Aug 23, 2018 at 1:20 PM Danny Hermes<EMAIL_ADDRESS>wrote:

@dhermes commented on this pull request.
In tests/resources/noxfile_nested.py
https://github.com/theacodes/nox/pull/104#discussion_r212444011:

-class Namespace:

"""A class that makes the provided kwargs available as attributes."""
def init(self, **kwargs):

   self.__dict__.update(kwargs)

+def eat(cheese):

print("Noms, {} so good!".format(cheese))

Works for me. Dropped in 5c78529
https://github.com/theacodes/nox/commit/5c785299d74c77c9bc00ad8ee44cfb552cf1c523.
Shall I merge?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/theacodes/nox/pull/104#discussion_r212444011, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAPUc26yLsublkFAceKKiSJMdKR7lNS-ks5uTw6fgaJpZM4WIitr
.


fix an out-of-bound access when setting morphing buffer

Because the morphing buffer is actually a texture, it's possible that
the last line is not a full-width line when updating the buffer.
Because textures are updated via a rectangle, it was possible to read
past the malloc'ed buffer during the update.
Moreover, because the count can be specified, we can't just blindly send
more "dummy" data.
Finally, added an offset to match the skinning API, and in that case,
the first line can also be incomplete.
We fix this by issuing up to 3 texture update calls if needed.
The java/js API update will come later.

@daemyung you might be interested in having a look at this one.

LGTM.
BTW is there any performance regression doing copy 3 times? I know there is no way doing this unless we keep data or use glMapBufferRange.
I think MorphTargetBuffer will be modified very rarely so... using device local memory is best and using glMapBufferRange will be improper. However filament is mobile first engine and mobile use unified memory so there is no different between host and device memory so... using glMapBufferRange can be fine.

Partial texture uploads are never good, for sure.
For glMapBufferRange I don't think you can do that with a texture?
I don't see how it would be efficient because map/unmap would have to do the swizzling.
What you can do is use a PBO and map that, but you'd still have the same number of calls to glTexImage2D.


Accessing Rancher API using service account's secret (external tool - Azure DevOps Environments)

Is your feature request related to a problem? Please describe.
Hello,
I'd like to connect our Rancher-managed cluster (RKE1) with Azure DevOps Environments. Only way to do it is by providing service account's secret (docs https://docs.microsoft.com/en-us/azure/devops/pipelines/process/environments-kubernetes?view=azure-devops#add-a-non-aks-kubernetes-resource).
As far as I understand, there are 2 ways to communicate with clusters Rancher-managed clusters:

by Rancher proxy using Rancher external url
directly (using local IP) as described here: https://rancher.com/docs/rancher/v2.5/en/cluster-admin/cluster-access/ace/

I am able to communicate with the cluster both using kubeconfig and HTTP API, but how to do that using service account's secret that Azure only supports?
I tried to create service account and bindings in my namespace and give the secret to Azure, but it fails with 401 error. I assume that Azure uses token from the secret as a Bearer token while calling HTTP API, which doesn't work for me also. Token from secret is very long whereas "working" token from kubeconfig is short.
Describe the solution you'd like
Can someone, please, tell me whether

I'm missing something and there is a way to get the desired secret. If so, I suggest to improve the docs.
I'm right there is no way to get the secret and it's a desired for Rancher to not provide it
it's a feature Rancher maybe implements in next version
I should create an issue on the Azure side and suggest supporting of e.g. kubectl configs

Thank you!

Can confirm - it's annoying.
My workaround was to save the connection with Bad values, and then edit the service connection in "Service Connections" to switch it from Service Account to Kubeconfig.


Layout issues

I am having problems getting this widget to work.  The issue is purely related to display, the retrieval of relationships and related records works great!
I suspect that I'm having similar issues to those described here:
https://github.com/cmv/cmv-app/issues/233
What I can tell from my testing is that for one thing, the only tab position that works is 'left-h'.  If I use anything other, the tabcontainer and grid are not displayed.  Actually they are displayed but the contentPane the widget is placed in has a height of 0.
If I use the default 'left-h' tab position, then the tab is displayed but the grid is not.  It's in the dom but has it's container height is 0.  If I click on the pane splitter, do not need to drag, just the click is sufficient, then it causes the widget to redraw and everything looks fine.
Any ideas on how to get this working?
Thanks!

Did you find that worked for you? I ended up switching themes to the nihilo dojo theme as dbootstrap is no longer maintained.

Feel free to reopen if you encounter issues.


Auto complete broken for Typography tokens

Describe the bug
When you want to reference any typography (font family, weight etc) in a Typography token, the auto complete doesn't show any available options.
Note
You can still reference when typing the token without using the auto complete.
Screenshots or Screencasts
https://github.com/tokens-studio/figma-plugin/assets/109062656/abf734c2-db61-4d88-bcda-9d16360a1b4d

I'm also experiencing this same issue. Even tried uninstalling figma (as I couldn't find a way to just remove the tokens studio plugin) and reinstalling to check it wasn't an update issue.

Experiencing this too

Same bug here as well.


Whizle

Whizle: turn passive hours of YouTube watching into active learning. It takes the YouTube videos and articles which a professional consumes and converts them into quizzes, flashcards and summaries shared in a social feed.
https://whizle.com
@basheir
Please make sure your repository has a readme with instructions how to run and deploy your project.

please add a repo link

Done, please check, thank you
On Mon, Jan 23, 2023 at 10:31 PM Andreas Thomas @.***>
wrote:

please add a repo link
—
Reply to this email directly, view it on GitHub
https://github.com/chronark/starlog/issues/3#issuecomment-1401098741,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AKPKEQDENCECWDW7M5EI7O3WT4BDHANCNFSM6AAAAAAUELIHSE
.
You are receiving this because you authored the thread.Message ID:
@.***>

it's a 404

Ok, I will check it, please note it is a private repository, does it have
to be public?
On Fri, Jan 27, 2023 at 8:39 AM Andreas Thomas @.***>
wrote:

it's a 404
—
Reply to this email directly, view it on GitHub
https://github.com/chronark/starlog/issues/3#issuecomment-1406182085,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AKPKEQF4E5RYY3DJJAJPECLWUOCTZANCNFSM6AAAAAAUELIHSE
.
You are receiving this because you authored the thread.Message ID:
@.***>

Yes it needs to be public, how else could people learn from it?


feature request: retrier: reset number of retries/backoff time

Imagine that I have an application that is an event processor that connects to some event log and for every event that arrives I want to do something with it. Also imagine that I have a Retrier with exponential backoff (100ms initial backoff time) and 5 retries.
We can get errors because of network issues (server not ready to accept connections, server disconnected for some reason like server LoadBalancer downscaling instances) or errors processing events.
If the app fails 5 times to process an event the retry loop should end and return error. This is good.
If my app fails to connect 5 times in a row the same should happen.
But if my app connects to the server, happily processes messages for 2hours then gets a server disconnection. It will retry the connection and (if successful) continue processing events. In the next few hours we receive 4 more server disconnections, but after each one we're able to reconnect and continue processing messages for some time. It does not make sense to say "we've failed 5 times so let's just finish here and return an error".
So basically the Retrier should expose a Reset() method which would cause the retrier to "forget" that it encountered errors before so that the next time that it encounters an error, instead of sleeping for a long time due to exponential backoff it will just sleep for the initial 100ms (as per the example) and it could tolerate 5 more errors later.
Here's a very simple skeleton of code that shows how this feature could be used:
r := retrier.New(retrier.ExponentialBackoff(5, 100 * time.Milliseconds), nil)
err := r.Run(func() error {
  server, err := connect(address)
  if err != nil {
    return err
  }

  for {
    event, err := server.getNextEvent()
    if err != nil {
      return err
    }
    err = processEvent(event)
    if err != nil {
      return err
    }
    // Because we've been able to process an event it seems that all is working correctly
    // so it doesn't matter that in the past we had (for example 2 errors), the next time we
    // see an error should be like it was the first error we've seen, and the backoff time to
    // to wait until next try should be the initial one passed by the user.
    r.Reset()
  }
}

Perhaps I am missing something about the use case, but wouldn’t it be simpler to move the retrier to wrap the logic inside the for {}? That accomplishes the same thing without the need for the manual Reset call.

You mean:
server, err := connect(address)
if err != nil {
  return err
}

for {
  r := retrier.New(retrier.ExponentialBackoff(5, 100 * time.Milliseconds), nil)
  err := r.Run(func() error {
    event, err := server.getNextEvent()
    if err != nil {
      return err
    }
    err = processEvent(event)
    if err != nil {
      return err
    }
  }
}

This won't work because if there's a disconnection we'll need to connect again, but that part is out of the retrier. And still if there were many disconnections the retrier in the end would give up.

If you are cool with this feature I can send a PR.

And still if there were many disconnections the retrier in the end would give up.

Each new call to Run resets the retry count, so the sample you posted would not give up as long as there was at least once success before five consecutive failures. But the point about retrying the connect call is important.

If you are cool with this feature I can send a PR.

OK

This won't work because if there's a disconnection we'll need to connect again, but that part is out of the retrier. And still if there were many disconnections the retrier in the end would give up.

Can you try something like this?
func ConsumeEvents() error {
	server, err := getConn()
	if err != nil {
		return err
	}
	for err == nil {
		if err := test(server); err == ErrConn {
			server, err = getConn()
		}
	}
	return err
}

func test(server server) error {
	r := retrier.New(retrier.ExponentialBackoff(5, 100*time.Millisecond), retrier.BlacklistClassifier{ErrConn})
	for {
		err := r.Run(
			func() error {
				event, err := server.getNextEvent()
				if err != nil {
					return err
				}
				return processEvent(event)
			},
		)
		if err == ErrConn {
			return err
		}
	}
}

You can notice I am using BlacklistClassifier, so while getting/processing events, if it encounters ConnectionErr, the retrier will classify the error as fail as we blacklisted that error. so we can check if error returned by the retrier is a connection error. If it is we can return the error as it is and the consume event func will obtain a new connection and the process goes on.

Closing due to lack of activity. I'm still willing to consider cases and proposals like this, but in hindsight I think the Retrier is not the right pattern in the first place when there's no real "Success" state. Maybe moving the Retrier instance to just wrap the connect call (and have everything else outside of the block) would have been best.


Create Traditional Chinese translation of Dungeon World character sheet.

Full translation to Traditional Chinese from original English version.

Just FYI, new alternate translation sheets will not be accepted starting September 1st. The current existing sheets, including this one, will still exist, we just won't accept new ones. If you want to add a translation to an existing sheet after that date you can use the new translation tools we released several months ago, documented here: https://wiki.roll20.net/Character_Sheet_i18n


Fix: Tor Desktop binary refs

There is no win32 binary variant for Tor. This must have been some rebase/merge error from upstream. Additionally, allowed the zip copier to overwrite as you want to be able to ship newer binaries, or add missing files (such as what I experienced after noticing win64 zip was not copying

I don't have the means to test this. LGTM

wait yes I can. It copies. Good.


Alignment everywhere is here!

Yeas ago, when the CSS Working Group was creating Grid, they realized that the alignment features from Flexbox should also work inside Grid. And then they decided, actually, they should work everywhere — including Flow layout and Table layout.
So the Box Alignment specification was born.
Now, finally browsers are implementing. It will be supported in Safari 17.4 and Chrome 123.
It would be great to have a page on Can I Use about this. It's not a new property. It's a new aspect to layout / a new concept.

https://chromestatus.com/feature/5159040328138752
https://developer.apple.com/documentation/safari-release-notes/safari-17_4-release-notes

Excited as well, but isn't this issue the same as your own https://github.com/Fyrd/caniuse/issues/6978 as well as https://github.com/Fyrd/caniuse/issues/2537? 🤔
At least the latter also seems to point to css-align-3, but maybe the meaning has changed over time or it's different parts (flex & grid vs. outside of those)…?

Hahahaha, I filed last week and forgot? Zeesh.


Environment management with Poetry

With Poetry, it is much easier to build project environment, and adding new dependencies, as well as publishing package to PYPI.

Related branch was merged into v0.1.1x