Cannot add the integration - getting unknown error message

Integration stopped working
I removed the integration and added it again .
While it is installed in HACS , when I try to add it to Integration I get "unknown error occurred"
I validated and this is the exact same PWD used in https://rym-pro.com/#/

Do you have logs to share (debug log level)?
Did you remove it from HA or HACS? Did you restart the HA in between?
Thanks

There are no logs as apparently the integration is installed on Hacs but is
not installed as integartion.
I added the debug to logger but could not find anything related to it .
I have removed it from HACS and from Integration as well as removed old
integration which was still there ( by removing the directory from custom
components )
Next step would be to restore a backup to see if this is solved .
I rebooted in between
On Sun, Jun 2, 2024, 18:05 Elad Bar @.***> wrote:

Do you have logs to share (debug log level)?
Did you remove it from HA or HACS? Did you restart the HA in between?
Thanks
—
Reply to this email directly, view it on GitHub
https://github.com/maorcc/citymind_water_meter/issues/70#issuecomment-2143891807,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ATBF5GZCO5JHEJOBGCIYOCTZFMYELAVCNFSM6AAAAABIVEEGOCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNBTHA4TCOBQG4
.
You are receiving this because you authored the thread.Message ID:
@.***>

@elad-bar
Don't know if it is the same issue, but I fail to connect

Without logs I cannot assist

Please follow the next steps and share the resilt:

Remove integration
Uninstall integration from HACS
Restart HA
Make sure integration is not installed
Install from HACS
Add logger section to enable debug logs as in README
Restart HA
Set up integration
If still not working, share logs

Please note that integration name is citymind not read your meter pro, in addition, please state you HA version
Thanks

@eyalcha you have tried to set up read your meter pro which is official integration based on this repo but still WIP
Please report the issue in HA core repo.
Thanks

addon also doesn't load for me.

In core log file I see the following:
2024-06-02 21:32:00.767 ERROR (MainThread) [custom_components.citymind_water_meter] Failed to load CityMind, error: , line: 36

Just to mention I just rolled back to 30May backup and it seems to be
working now.
I suspect something with the update might be buggy .
I will share more feedback if I see that there are errors or malfunction .
On Sun, Jun 2, 2024, 21:41 arnonsha @.***> wrote:

addon also doesn't load for me.
image.png (view on web)
https://github.com/maorcc/citymind_water_meter/assets/35176391/872e660b-959b-4d68-b195-6a187f457e1c
In core log file I see the following:
2024-06-02 21:32:00.767 ERROR (MainThread)
[custom_components.citymind_water_meter] Failed to load CityMind, error: ,
line: 36
—
Reply to this email directly, view it on GitHub
https://github.com/maorcc/citymind_water_meter/issues/70#issuecomment-2143982161,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ATBF5G6WRNN3ZJZRMOMLUNDZFNRN5AVCNFSM6AAAAABIVEEGOCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNBTHE4DEMJWGE
.
You are receiving this because you authored the thread.Message ID:
@.***>

@arnonsha did you set debug log level? Did you follow the steps for clean install?
@drorya1 I guess you are on v2.0.15 now, is that correct?
Can you enable debug logs (from logger component not ui) and upgrade again?
You can revert to previous versions using hacs (redownloaf) no need to restore backup
Thanks

will update documentation and make it clearer
It means that encryption key was modified from outside the code, Please remove the integration and re-add it to make it work again.
if still not working, remove the integration (from devices & service not hacs) again, in /config/.storage directory remove files contains citymind, restart and set up integration again

I'm afraid that wasn't enough. I updated again to 3.0.3, removed the integration, deleted these two files:
.storage/.citymind_water_meter
.storage/citymind_water_meter.9b1ce813b6d085b692e806fa39d61bec.config.json

And then tried adding it again. Failed with:
2024-06-03 11:51:52.801 INFO (MainThread) [custom_components.citymind_water_meter.managers.flow_manager] Config flow started, Step: user, Input: None
2024-06-03 11:52:03.740 INFO (MainThread) [custom_components.citymind_water_meter.managers.flow_manager] Config flow started, Step: user, Input: {'email': 'XXXXX', 'password': 'XXXXX'}
2024-06-03 11:52:03.740 INFO (MainThread) [custom_components.citymind_water_meter.managers.config_manager] loaded: None
2024-06-03 11:52:03.741 INFO (MainThread) [custom_components.citymind_water_meter.managers.config_manager] default_configuration: {'meters': {}}
2024-06-03 11:52:03.741 INFO (MainThread) [custom_components.citymind_water_meter.managers.config_manager] adding meters
2024-06-03 11:52:03.741 INFO (MainThread) [custom_components.citymind_water_meter.managers.config_manager] updated
  File "/config/custom_components/citymind_water_meter/config_flow.py", line 36, in async_step_user
  File "/config/custom_components/citymind_water_meter/managers/flow_manager.py", line 69, in async_step

@Elad bar
Indeed I am on 2.0.15 tried to update to 3.0.3 and the integration does not
work
Unfortunately I cannot roll back see attached clip I will try to delete
mannually
On Sun, Jun 2, 2024 at 11:58 PM Elad Bar @.***> wrote:

@arnonsha https://github.com/arnonsha did you set debug log level? Did
you follow the steps for clean install?
@drorya1 https://github.com/drorya1 I guess you are on v2.0.15 now, is
that correct?
Can you enable debug logs (from logger component not ui) and upgrade again?
You can revert to previous versions using hacs (redownloaf) no need to
restore backup
Thanks
—
Reply to this email directly, view it on GitHub
https://github.com/maorcc/citymind_water_meter/issues/70#issuecomment-2144018652,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ATBF5G2VDHR4BRZXXYRUXODZFOBP7AVCNFSM6AAAAABIVEEGOCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNBUGAYTQNRVGI
.
You are receiving this because you were mentioned.Message ID:
@.***>

config_entry-hacs-4f0fd37a37158caccbd39a15b513591b.json
https://github.com/maorcc/citymind_water_meter/assets/79847067/6a096637-d0cf-49c3-a39c-2a82cdd95d40

@elad-bar
Reverting back to 2.0.15 restores the service

It's happened to me too when upgrading from 2.0.15 to 3.0.3

Did you try what I wrote above?

I see the same issue.

is it still relevant?
thanks

I removed and reinstalled. Solved my problem
I also see that the meter name now also contains the full name and not just the meter number which is very helpful (I have few meters)

Issue solved by reinstalling the integration.
Thank you very much.

I can also confirm that removing and reinstalling was required, but fixed the issue for me as well. Just doing a "reload" or even "(re-)configure"  after upgrading to 3.0.5 was insufficient.

Working for me as well
On Tue, Jun 25, 2024, 10:34 Elad Bar @.***> wrote:

Closed #70 https://github.com/maorcc/citymind_water_meter/issues/70 as
completed.
—
Reply to this email directly, view it on GitHub
https://github.com/maorcc/citymind_water_meter/issues/70#event-13276611255,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ATBF5G3QDDKKLPJE2HV6LELZJEMQBAVCNFSM6AAAAABIVEEGOCVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJTGI3TMNRRGEZDKNI
.
You are receiving this because you were mentioned.Message ID:
@.***>


Refactor: remove anythingConcatLists

Removes the cursed anythingConcatLists type used in the HM and nixos modules.
TODO:

[x] get ride of duplicate code in modules/default.nix

don't see any changes in eval time on my HM config


RESTful-style API handler should support filtering with "null" for nullable fields

I think not equal operator is not supported as well which I think is needed. Please let me know if I need to open a new issue record for this.


Add warning on good practice in the Module webpage

Discussed in https://github.com/orgs/Proteobench/discussions/237

Originally posted by mlocardpaulet February  8, 2024
There is no way to check the data publicly uploaded to ProteoBench. Currently, the only thing that we can do is to save the parameter files associated with the benchmark runs, so that we can reproduce them.
This may not be enough... And it has been discussed a lot among us.
We need to add a warning in the Module, such as the one in the documentation:
This module is not designed to compare later-stages post-processing of quantitative data such as missing value replacement, and we advise users to publically upload data without replacement of missing values and without manual filtering.

We also need to discuss with the developers of the tools that we make compatible with ProteoBench to be sure that a maximum of the parameters can be retrieved from their ProteoBench-compatible parameter files.

So this can be closed?


[Storage] az storage fs generate-sas:  Support generate sas token for file system in ADLS Gen2 account

Description

Testing Guide

History Notes

[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change.
[Component Name 2] az command b: Add some customer-facing feature.

This checklist is used to make sure that common guidelines for a pull request are followed.

[ ] The PR title and description has followed the guideline in Submitting Pull Requests.

[ ] I adhere to the Command Guidelines.

[ ] I adhere to the Error Handling Guidelines.

Storage


help

can someone help me fix how there is no make user button

https://github.com/AlphaNecron/Void/issues/55 You may have to use prisma studio.

is there not a built in user add button or invite code make or what ever

Currently, Void is not finished and I literally have no time to maintain this, if you want a more stable service, you can try diced/zipline.


React to WebHostingBuilder

https://github.com/aspnet/Hosting/pull/237
cc @divega @davidfowl Any way to avoid CallContextServiceLocator here?

I can flow in the IServiceProvider from the Program class. File a bug and I'll fix.

:shipit: Can service building be decoupled from hosting? It feels like the Startup.ConfigureServices pattern of building services is orthogonal from the rest of the hosting pipeline.

Great, filed https://github.com/aspnet/EntityFramework/issues/2024

re splitting service building, I'm not sure we can, since Startup potentially can take things like IHostingEnvironment in its ctor which only come from hosting.

99ebd0cf3f8755bb9a25e63aa464388f374eb71e


jenkins plugins and dependencies

#Jenkins Plugins
Changes
Adds  android-signing dependencies plugin + xcode-plugin fork from aerogear
Verification steps
ansible-playbook -i inventory.cfg digger-playbook.yml --tag=plugins

I had some problems verifying it as I always get an authentication error from ansible playbook but running the jenkins-cli command myself works fine.

👁

@odra
I created a fresh cluster to test this. Ran ansible-installer role and there were some errors:
WARNING: Some health checks are reporting as unhealthy: [plugins : There are 16 failed plugins: token-macro; config-file-provider; managed-scripts; github; github-branch-source; blueocean-pipeline-api-impl; blueocean-events; blueocean-dashboard; blueocean-git-pipeline; github-organization-folder; blueocean-github-pipeline; blueocean-personalization; blueocean-pipeline-editor; blueocean; android-signing; xcode-plugin]

Full log: https://gist.github.com/aliok/4bccc344e471844949cd7676e24e86a7

closed due to #29

@odra ,  how is PR#29 is different than this PR? What was the problem?

My pr was a duplicate of #29, problem was that we need to remove plugins first, restart jenkins, install plugins, restart again, etc - this work was already done in #29


Retry cloud installation up to 5 times to handle newly created droplets not yet being ready

Tested in Chrome (typically install has been able to connect on the first or 2nd try for me).
Also added new unit tests

Yay! Thanks for doing this, really improves the installer situation.

Just made most of those changes, PTAL

:+1:


[Bug][relay][pytorch] Wrong implementation logic in Threshold operator

Relay has a wrong implementation logic about the threshold operator, It was used the same as relu.  You can see Line 1334-1336 in file frontend/pytorch.py

The implementation logic in PyTorch documentation is shown as follows:

This bug was detected by this test case:
import torch
from tvm import relay
import tvm
import numpy as np

m = torch.nn.Threshold(1.0, 3.0,)
input_data = torch.tensor([[-1.0, 2.0]], dtype=torch.float32)

torch_outputs = m(input_data)

trace = torch.jit.trace(m, input_data)
input_shapes = [('input0', torch.Size([1, 2]))]

mod, params = relay.frontend.from_pytorch(trace, input_shapes)

with tvm.transform.PassContext(opt_level=3):
    exe = relay.create_executor('graph', mod=mod, params=params, device=tvm.device('llvm', 0), target='llvm').evaluate()
input_tvm = {'input0': np.array([[-1.,  2.]], dtype='float32')}
tvm_outputs = exe(**input_tvm).asnumpy()

np.testing.assert_allclose(torch_outputs, tvm_outputs, rtol=1e-3, atol=1e-3)

Expected behavior
TVM gives same result as Pytorch
Actual behavior
TVM gave different result with Pytorch, It seems TVM produce the wrong result.

Triage

frontend:pytorch

cc @Hzfengsy @echuraev @shingjan @yelite

Fixing this bug needs to master the complete code structure of Relay.  I am not very familiar with this process.
@Hzfengsy @echuraev @shingjan
Are you willing to give me some advice and suggestion on how to learn it?
BTW,  From my knowledge, the core of TVM is optimization, do you think detecting and fixing frontend bugs is meaningful work?

@jikechao Thank you for your finds. IMHO, fixing frontend bugs is also very important work. TVM also cares about the accuracy because if we have a good performance but bad accuracy then it makes no sense because the final result is incorrect. By fixing such bugs and adding new operators support, you make a great contribution to model coverage by TVM. I think it is an important work.

Are you willing to give me some advice and suggestion on how to learn it?

Also, it is my personal opinion, but usually I use official documentation, you can find there many useful articles. E.g.:

Python API of Relay: https://tvm.apache.org/docs/reference/api/python/relay/index.html
If you type relay in the search field, then you see many different articles related to relay and you can find something useful for you.

Another trick which I commonly use, I try to find in the source code or in the git history something similar to my task and understand which components I have to modify. For example, if I need to add new operator support, I would find another commit which adds some another operator to TVM and learn how it was done.

@echuraev Thank you for your valuable suggestion. I will continue to learn and try to detect and fix frontend bugs.

This issue has been fixed by the PR-14820


[Bug] design_decor:breaker_switch is not craftable

design_decor:breaker_switch is not craftable, despite appearing in recipe viewer.
Currently on design_decor-0.4_fabric+1.20.1.jar

Full Log:
https://mclo.gs/ZjBaNvf

I assume it doesnt work due mod uses "forge" tags.
Some examples:
https://github.com/DrMango14/Create-Design-n-Decor/blob/484c3624230408e074847b1a65be522efb9fc8a7/src/main/resources/data/design_decor/recipes/crafting/breaker_switch.json#L17 https://github.com/DrMango14/Create-Design-n-Decor/blob/484c3624230408e074847b1a65be522efb9fc8a7/src/main/resources/data/design_decor/recipes/crafting/gas_tank.json#L11 https://github.com/DrMango14/Create-Design-n-Decor/blob/484c3624230408e074847b1a65be522efb9fc8a7/src/main/resources/data/design_decor/recipes/stonecutting/blank_sign.json#L5
Personally I made datapack (design_decor_fabric_fix.zip) to fix it.

do you mind if I use that to fix the recipes?

@Szedann yep, use it.

 But where, and how do I use your fix?  But where, and how do I use your fix? I've been looking everywhere but I don't know where to place you files :(

I did not make a fix, focusing on other things at the moment

Yeah, sorry I tagged the wrong person hehe.  But where, and how do I use your fix? I've been looking everywhere but I don't know where to place you files :(

Yeah, sorry I tagged the wrong person hehe.  But where, and how do I use your fix? I've been looking everywhere but I don't know where to place you files :(

Either look up a guide on how to load datapacks, or use a mod such as "Open Loader" to do it


[Snyk] Upgrade io.grpc:grpc-core from 1.45.1 to 1.46.0

This PR was automatically created by Snyk using the credentials of a real user.Snyk has created this PR to upgrade io.grpc:grpc-core from 1.45.1 to 1.46.0.
:information_source: Keep your dependencies up-to-date. This makes it easier to fix existing vulnerabilities and to more quickly identify and fix newly disclosed vulnerabilities when they affect your project.

The recommended version is 1 version ahead of your current version.
The recommended version was released 22 days ago, on 2022-04-25.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open upgrade PRs.
For more information:
🧐 View latest project report
🛠 Adjust upgrade PR settings
🔕 Ignore this dependency or unsubscribe from future upgrade PRs

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Cirrus tasks marked as pending in cocoon

Cirrus tasks are showing as pending in the devicelab, even though they have run and succeeded.
https://cirrus-ci.com/build/flutter/flutter/cca1215939af648f9f35e4a6ce1b32467708b7cf?branch=master

Fix: https://github.com/flutter/cocoon/pull/1001


my house is 45 years olb, but externally isolated since. No option was shown for it

> This ticket was created automatically by our robot from our translation contribution page.

Hi, thank you for your feedback. The age of your house is used only to calculate the part of construction attributed to your yearly carbon footprint, your isolation will be taken into account in your energy bills.


Missing feature to define multiple waypoints and draw road

Would it possible to draw roads (add/remove waypoints) with tapping directly inside the map? Is there maybe at least a listener for tapping/click event on the map?
This would be a great feature because I need to draw routes by tapping/clicking on the map and finally drawing a road based on all the defined waypoints.

I already open discussion about selectionPosition #97  and I proposed to add longPressListen callback
this feature i will added by the end of june when at least add drawRoad for ios support.
for drawRoad you can draw route with multple points just you need to add interestPoints attribute

I have another question
the method `drawRoadè  doesn't fill your need ? or you just want callback to get tapping from map ?

You're right, I found a way using mapController.selectPosition(); and mapController.drawRoad(). However, I had to fork the repo and change the API URL from https://router.project-osrm.org/route/v1/driving/ to https://routing.openstreetmap.de/ in order to get it working. Seems that the API source is broken or has changed.
Test this link and see that it is broken:
https://router.project-osrm.org/route/v1/driving/routed-car/route/v1/driving/8.2278234308,47.4159237209;8.2386224920,47.4168952180;8.2477985729,47.4235684965;8.2446774569,47.4285095564?alternatives=false&overview=full&steps=true

yeah, i will make new drawRoad more customizable
and also i started creation the feature of tapping callback into the map(android)  but i'm facing small problem but it will be shipped by the next week

the osrm using /route/v1/diving
but if you have your own routing api
i will add new way as i told you that you will configure routing api in library

that was my fault when i upgraded osmbonuspack i didn't realize that thet start using https and they change endpoint
the new version 0.7.8+4 fix that problem #109

good news listener to SingleTap and LongPress is ready to be shipped in the next version
here example that you will find in readme
controller.listenerMapLongTapping.addListener(() {
      if(controller.listenerMapLongTapping.value!=null){
            //logic
      }
    });
    controller.listenerMapSingleTapping.addListener(() {
      if(controller.listenerMapSingleTapping.value!=null){
          //logic
      }
    });

and you can get last geoPoint tapped like this and don't forget to test if it null or not
final geoP = controller.listenerMapLongTapping.value;

Hi @liodali
This is amazing. Thank you! I will test it.

Hi, It would be nice beeing able to define the route mode is for driving, walking etc. I can see that the API url has been completely removed now within this plugin. Any chance to define and customize the url?

for osm routing i will add that just i need finish drawing road in ios side to implement that
for customizable url, that little complicated because i need to know if endpoint return the same as routing api of osm
and also I'm planning to support for geojson format that will make easly integrated in ios and android side from dart

I cannot get it running. The listeners do work, but now drawRoad() seems to be broken.

can you provide me more information

I figured out now what does not work. The listeners only work once, after changing screen and returning again, the listeners do not work anymore. Would you be able to reproduce this behavior?

did you dispose the screen when you go the next screen or you keep it alive
but I idea about the problem  I will fix it

when you change screen id of method channel change and in dart side i already manage to listener to multiple id of method channel but it seems that it dosn't work properly i will fix it

I fix the problem i will publish new version
the problem that when you change the screen and go back to the map i forget to re init stream because i already disposed

check the new version 0.7.9+2

Great, thank you. It works now. I would like to add a first marker for drawing a road using the coordinates after tapping on the map using this listener, similar to what "await controller.selectPosition()" basically would do. It works, but i cannot define the marker icon for that. However, I think this is another topic :)

yeah  i will add new method addMarker for that purpose

i added method addMarker to be used with Taplistener or in any other use case
it will be available in version 0.12.0


AmendmentTable improvements

While working on retiring amendments I made a number of improvements to the AmendmentTable and its unit tests.  Since we're not moving forward with retiring amendments, this pull request contains the improvements to the AmendmentTable and its unit tests that I believe we want to keep.
This code should look very familiar to the reviewers.  It's just selected favorite highlights from the retiring amendments pull request.  Thanks for looking it over again.

Codecov Report

Merging #3404 into develop will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop    #3404      +/-   ##
===========================================
+ Coverage    70.44%   70.45%   +0.01%
===========================================
  Files          682      682
  Lines        54392    54389       -3
===========================================
+ Hits         38315    38321       +6
+ Misses       16077    16068       -9

Impacted Files
Coverage Δ

src/ripple/app/misc/AmendmentTable.h
100.00% <ø> (ø)

src/ripple/app/misc/impl/AmendmentTable.cpp
98.17% <100.00%> (+4.02%)
:arrow_up:

src/ripple/rpc/handlers/Feature1.cpp
96.15% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9771210...b7fdb29. Read the comment docs.


Insert transactions received via new payload into pool

Describe the feature
NewPayload with encoded transactions is received here:
https://github.com/paradigmxyz/reth/blob/b7395a89a5520f739a09826374ac957410ccecfc/crates/rpc/rpc-engine-api/src/engine_api.rs#L66-L69
ideally all of them should be inserted into the pool
I think this should happen here and not in BeaconEngine, wdyt @rkrasiuk?
Additional context
No response

i think it should be done either in the engine or in the blockchain tree. the thing is, we want to make sure that the payload is valid and that it is a part of the canonical chain

@mattsse actually, should we insert any transactions regardless of whether it's a canonical chain or not?


i18n: adds Occitan language

I hope it's correct to contribuite this way!

Thank you for the PR! See https://github.com/dargmuesli/nuxt-cookie-control/discussions/83#discussioncomment-5519954 to see what's missing ;)

Thank you for the PR! See #83 (comment) to see what's missing ;)

made the changes! I hope it will work

I fixed a minor linting issue for you :rocket:

:tada: This PR is included in version 5.6.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

thank you @dargmuesli !


[DDW-555] Improve URL validation on Stake Pools

This PR improves the error messages in the custom SMASH server url input.
Todos

[x] Improve the error messages
[x] Copy & translation

Screenshots

Testing Checklist

Slack QA thread
[ ] Test

Test scenarios
Scenario 1 - Insert URL without "https://"
Given that I am on Stake Pools screen on "Settings"
And the option "Custom server" is selected
When I insert an URL that doesn't start with "https://"
Then the input is outlined in red
And the following message is displayed on a tooltip

- ENGLISH: The URL should start with "https://"
- JAPANESE: URLは「https://」から始めてください

Scenario 2 - Insert URL with "https://" and a path
Given that I am on Stake Pools screen on "Settings"
And the option "Custom server" is selected
When I insert an URL that start with "https://" and has a path
Then the input is outlined in red
And the following message is displayed on a tooltip

- ENGLISH: Only "https://" protocol and hostname (e.g. domain.com) are allowed
- JAPANESE:「https://」プロトコルおよびホスト名（例：domain.com）のみ使用できます

Scenario 3 - Insert URL with "https://" and no path
Given that I am on Stake Pools screen on "Settings"
And the option "Custom server" is selected
When I insert an URL that start with "https://"
Then no error is displayed on the input

Review Checklist
Basics

[ ] PR has been assigned and has appropriate labels (feature/bug/chore, release-x.x.x)
[ ] PR is updated to the most recent version of the target branch (and there are no conflicts)
[ ] PR has a good description that summarizes all changes
[ ] PR has default-sized Daedalus window screenshots or animated GIFs of important UI changes:

[ ] In English
[ ] In Japanese

[ ] CHANGELOG entry has been added to the top of the appropriate section (Features, Fixes, Chores) and is linked to the correct PR on GitHub
[ ] Automated tests: All acceptance and unit tests are passing (yarn test)
[ ] Manual tests (minimum tests should cover newly added feature/fix): App works correctly in development build (yarn dev)
[ ] Manual tests (minimum tests should cover newly added feature/fix): App works correctly in production build (yarn package / CI builds)
[ ] There are no flow errors or warnings (yarn flow:test)
[ ] There are no lint errors or warnings (yarn lint)
[ ] There are no prettier errors or warnings (yarn prettier:check)
[ ] There are no missing translations (running yarn manage:translations produces no changes)
[ ] Text changes are proofread and approved (Jane Wild / Amy Reeve)
[ ] Japanese text changes are proofread and approved (Junko Oda)
[ ] UI changes look good in all themes (Alexander Rukin)
[ ] Storybook works and no stories are broken (yarn storybook)
[ ] In case of dependency changes yarn.lock file is updated

Code Quality

[ ] Important parts of the code are properly commented and documented
[ ] Code is properly typed with flow
[ ] React components are split-up enough to avoid unnecessary re-renderings
[ ] Any code that only works in main process is neatly separated from components

Testing

[ ] New feature/change is covered by acceptance tests
[ ] New feature/change is manually tested and approved by QA team
[ ] All existing acceptance tests are still up-to-date
[ ] New feature/change is covered by Daedalus Testing scenario
[ ] All existing Daedalus Testing scenarios are still up-to-date

After Review

[ ] Merge the PR
[ ] Delete the source branch
[ ] Move the ticket to done column on the YouTrack board
[ ] Update Slack QA thread by marking it with a green checkmark

@daniloprates Looks good, just one detail:

URLs with no extension are considered valid (no error is displayed before submitting it). Could this be improved? Check this video.

I added some test scenarios on this PR.

@daniloprates Looks good, just one detail:

URLs with no extension are considered valid (no error is displayed before submitting it). Could this be improved? Check this video.

I added some test scenarios on this PR.

@gnpf we can't prevent this. Because of new top-level domains, a URL can be valid without the extension.

shouldn't we hide this when we focus other field?

Hi @a-rukin.It seems to be hiding ok for me on the Mac builds  16487  video. What Os did you test on ?

Hi @a-rukin .It seems to be hiding ok for me on the Mac builds 16487 video. What Os did you test on ?

Just built latest commit 🤷

Pls use "font-medium" here instead of "font-bold"


TypeError: Cannot read property 'insertBefore' of null

Received this error and tried a million things to get it to go away. Must be using JQLIte, not jQuery.
When you have a ui-view element with default content in it that contains an ng-repeat directive, the TypeError is thrown when changing to the child states. I was able to solve this problem by creating an abstract state for the parent and putting the default content into a new child state, with the parent's URL. That one took some real troubleshooting.
Plunkr here: http://plnkr.co/edit/6fSNgaifgVlAraHrPBgX?p=preview

confirmed - simplified example with ng-if and a temporary "workaround":
http://plnkr.co/edit/SB2Ic2YVgZTsIagjY0fP?p=preview
basically, the problem is that the controller is attaching to the content, that's being replaced with the "new" ui-view
the aforementioned "workaround" is a small variable that is state-dependant.
just uncomment the line 38:
      // ctrl.showDefault = ( state.name === 'main' );

the error will be gone.

Is this going to be corrected soon? I have this issue with any list view that has child edit states.

This happens for me when I have a variable in both scopes and that variable is used in the template.

I am also running into this, will this be fixed?

I had this issue a while ago but it just came up again. I found out it only happens if ng-repeat is an immediate child of your ui-view.
For example the following layout would cause this issue

But it works perfectly fine if you surround your ng-repeat with a parent div that doesn't have a ui-view
ie the following works fine

Yeah, I've got this with ng-if directive, and what @epelc suggested also fixed this for me, would be good if there is some explanation why this happens (i'm using angular 1.4-beta-6).

After looking into it some more I think it has to be with scope inheritance. If you namespace your controller using controllerAs the problem goes away.

I had a similar problem with using an ng-if on an ng-include to conditionally load UI assets if the user was/wasn't logged in. I ultimately went with this approach and the errors disappeared:

This answer explained what was happening, and a comment in it provided the above solution/workaround. http://stackoverflow.com/a/25674022

Both ng-if and ng-include are queued up to execute, and ng-if has a higher priority so it runs first. If the expression is false, then ng-if removes the element, but doesn't cancel the ng-include from running. Since the element is removed, ng-include is unable to inject the loaded content into the element and you get this error.

You'll likely run into the same thing whenever you try to combine multiple transcluded directives in an equivalent hierarchy. Please report the the issue against Angular core. If there's a fix that UI-Router can provide to mitigate it, I have yet to figure out what that would be and, as simple workarounds exist, it's not really a priority. As always, PRs are welcome.

@nateabele Apologies, I'm not using angular-ui sp this would be a core issue.
Thanks!


Pulsar SQL is (still/again?) not able to read the latest message

Describe the bug
Referring to bug
https://github.com/apache/pulsar/issues/3828
https://github.com/apache/pulsar/issues/4976
which was fixed in
https://github.com/apache/pulsar/pull/5822
I'm still having this exact problem.
Steps to reproduce
Running Pulsar standalone 2.9.1 on EC2.
In /home/ec2-user/apache-pulsar-2.9.1/conf/broker.conf
I set the value according to the fix:
bookkeeperExplicitLacIntervalInMills=10
Restart Pulsar.
Spawn ./pulsar sql-worker run
Event sending:
I parse a CSV file and send the records to Pulsar like this:
1.) Create Pulsar client + producer
2.) Read Csv line by line, map to PoJo, send via producer (async) + save returned CompletableFuture
3.) Make sure all CompletableFutures complete by calling completableFutures.forEach(CompletableFuture::join);
4.) Close pulsar producer & pulsar client
Afterwards when I query my topic via Pulsar SQL I'm missing the last record (sometimes I'm missing even more records than only the last record).
This is true until I parse the CSV again and send it, then the previous missing records are there in Pulsar SQL query, but ofc the new last record is missing...
Now, since parsing lines and sending them are fast operations, I also tried to add some delay between the sending of each record (Thread.sleep(20), even Thread.sleep(1000)). Even then the issue remains.
Question
Is there anything I can check to see if the
bookkeeperExplicitLacIntervalInMills=10
setting is actually in effect?
Do you need more explanation?

By default, pulsar sql won't get the last message in the topic. If you want to
get the last message, you need to configure the following configurations.
For the broker config, you need to set bookkeeperExplicitLacIntervalInMills.
For the Presto config, you need to set pulsar.bookkeeper-use-v2-protocol=false and pulsar.bookkeeper-explicit-interval.
Then you should get the last message from sql.

Yes I did that now, and the results are the same: The sql lags 1 record behind, doesn't show the latest...
./pulsar-client produce sqltest -m "hello" -k **"test_1"**
presto> select * from pulsar."public/default".sqltest;  __value__ | __partition__ | __event_time__ | __publish_time__ | __message_id__ | __sequence_id__ | __producer_name__ | __key__ | __properties__ -----------+---------------+----------------+------------------+----------------+-----------------+-------------------+---------+---------------- **(0 rows)**
 ./pulsar-client produce sqltest -m "hello" -k **"test_2"**
presto> select * from pulsar."public/default".sqltest;    __value__    | __partition__ |     __event_time__      |    __publish_time__     | __message_id__ | __sequence_id__ | __producer_name__ | __key__ | __properties__ ----------------+---------------+-------------------------+-------------------------+----------------+-----------------+-------------------+---------+----------------  68 65 6c 6c 6f |            -1 | 1970-01-01 00:00:00.000 | 2022-02-23 14:08:41.905 | (2409,0,0)     |               0 | standalone-6-7    | **test_1**  | {} (1 row)
So I guess it has to be some configuration problem then?
Can I somehow check if the settings I've mentioned a post above are even in effect?

There have some logs when starting the component, you may check that configurations are applied in the logs

Closed as stale. Feel free to open a new issue if it's still relevant for maintained versions.


[Bug] deploy flink job on yarnApplication Mode bug fixed

[Bug] deploy flink job on yarnApplication Mode bug fixed

Maybe dev branches need to be merged as well

This part of the code seems to conflict with the dev branch, I will see if I can sort it out into the dev branch


Volume resize

hi,
I think it's can be a great feature to be able to resize a volume on fly (I use size for quota and sometime quota of my container must change), actually handling it in my app with multiple volume it's can be a great feature.

This looks like a duplicate of #64


Remove underscores from poll text

Only affects text shown in UI so shouldn't mess with anything else, if theres something that read this text that I haven't seen. Issue #612
Ignore the branch name :)

@skcin You did a click-poll-to-open sometime a while ago. Does this interfere?

This shouldn't interfere with my changes.


Fixes GH issue #118 "Division by zero when there are no relevant expressions

Fixed by showing 100% coverage in that case (100% is what coveralls.io shows when there are no relevant lines).

Coverage decreased (-0.2%) to 93.294% when pulling 835c9f8cdd4aa8f35acb93379388f98eadf07235 on fix-div-by-zero--issue-118 into 7a5e12cd42f5984db86776a6385ac065471ba489 on master.


Syncing Fixes

This is a bunch of changes that improve video player syncing particularly having to do with the video queue.
Closes #34

I've been racking my brain over this for the past few days.  Finally I've gotten this issue solved.  This should be stable enough for a new pre-release.


Added missing dependency for microprofile

Worked with Jon to get this to an acceptable way to fix the micro profile.

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Can one of the admins verify this patch?


Allow users to disable confirmation dialog

Note: This PR depends on #178
This change allows the user to disable the confirmation dialog that appear when submitting decisions, and persists that state into the browser's local storage.
Additionally, some convenience methods were added to the results page testing object to apply and submit review decisions more easily within the browser tests.
Bug: T290953

This is only working if I check the box and then reload the page. If I chose an option from the dropdown and the box opens and then proceed. And then I chose another option without reloading the page, the box appears again. I think this is due to the fact that you are only retrieving the value of the disableConfirmation in mounted and not saving it as a local data variable as well.

Thanks! It turned out that we just needed to ensure that the checkbox rest when the dialog is dismissed (rather than on every close, like before). I also made sure to fix the tests do that they would fail  in this case, as they should have.


Move-to-ubuntu-22.04

[ ] I added an entry to CHANGELOG.md if knowledge of this change could be valuable to users.

Here is a brief summary of what I did:

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage decreased (-14.06%) to 70.6%

Files with Coverage Reduction
New Missed Lines
%

operators/src/source/ogr_source/mod.rs
1
58.1%

Totals

Change from base Build<PHONE_NUMBER>:
-14.06%

Covered Lines:
16178

Relevant Lines:
22915

💛  - Coveralls

 Update zu Ubuntu 22.04.

bors merge

bors merge

bors merge

bors merge


Settings page reflects connected status only after reload

After successfully connecting my nextcloud instance in the compose settings I see a green notification, but the "Status"-text stays at "not connected" (including the link). Only after a page reload the new status text is shown.
When disconnecting from nextcloud the page reloads instantly, to the effect that the status text is updated.
It would be nicer to also on establishing the connection see the new status instantly (also because the notification vanishes after a few seconds and can be missed).

Should be fixed with cb2cb8f and is released in v<IP_ADDRESS>


Make README more legible for native english speakers

Made the README more legible for native english speakers
Proposed changes
Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.
Types of changes
What types of changes does your code introduce to Kylin?
Put an x in the boxes that apply

[ ] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[x] Documentation Update (if none of the other choices apply)

Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

[ ] I have create an issue on Kylin's jira, and have described the bug/feature there in detail
[ ] Commit messages in my PR start with the related jira ID, like "KYLIN-0000 Make Kylin project open-source"
[ ] Compiling and unit tests pass locally with my changes
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] If this change need a document change, I will prepare another pr against the document branch
[ ] Any dependent changes have been merged

Further comments
If this is a relatively large or complex change, kick off the discussion at user@kylin or dev@kylin by explaining why you chose the solution you did and what alternatives you considered, etc...

Pull Request Test Coverage Report for Build 6636

0 of 0   changed or added relevant lines in 0 files are covered.
9 unchanged lines in 4 files lost coverage.
Overall coverage decreased (-0.006%) to 28.041%

Files with Coverage Reduction
New Missed Lines
%

stream-core/src/main/java/org/apache/kylin/stream/core/storage/columnar/ColumnarStoreCache.java
1
56.82%

tool/src/main/java/org/apache/kylin/tool/query/ProbabilityGenerator.java
1
81.58%

core-cube/src/main/java/org/apache/kylin/cube/cuboid/TreeCuboidScheduler.java
2
68.46%

core-metrics/src/main/java/org/apache/kylin/metrics/lib/impl/MetricsSystem.java
5
66.67%

Totals

Change from base Build 6634:
-0.006%

Covered Lines:
26252

Relevant Lines:
93621

💛  - Coveralls

Anytime, feel free to merge (or give me write access)!


chore(main): release 2.0.0-alpha.1

:robot: I have created a release beep boop
2.0.0-alpha.1 (2024-10-16)
✨ New Features

Flutter 3.24.3 upgrade (#33) (588ec2f)

⛓ Dependencies

Update dependencies (5a4d182)

🧹 Miscellaneous Chores

Fix routes in example app (609fc83)

This PR was generated with Release Please. See documentation.

:robot: Created releases:

v2.0.0-alpha.1
:sunflower:


Allow dates on Exhibition featured card

The featured card doesn't currently display dates for the exhibition at the top of the homepage. I'm not sure if this has always been the case, or a regression, but feels like dates should probably be there (as they are on other exhibition cards)

Some investigation context; we use the card content type on the homepage, so it's not the exhibition itself that's linked, but the Hard Graft card. In the code we force that by not displaying anything but cards. Might be time to change that.
talking about it with editorial here

Will move back to Icebox after discussion with @LaurenFBaily and @davidpmccormick , changing the logic when we're thinking of redoing the homepage doesn't feel like a priority.


Potential config file corruption

This is a potential issue, I don't think it actually happened yet.
In many places, RaspiBlitz currently uses echo "something=something" >> /mnt/hdd/raspiblitz.conf.
If the user manually modifies the config file, and for some reason removes the newline at the end (it's unlikely, I just wanted to report this), this command will end up with the config file looking something like this:
Before:
oldConfig=oldValue

Expected:
oldConfig=oldValue
something=something

Actual config file:
oldConfig=oldValuesomething=something

In this scenario, doing echo "something=something" | tee -a /mnt/hdd/raspiblitz.conf would be better.
Even though this is unlikely you may find it's worth fixing it, because it can be fixed by a simple search and replace.

Good point thanks and easy to fix.

See discussion on changing how we adit the config file here:
https://github.com/rootzoll/raspiblitz/pull/2755#issuecomment-987948372

The solution in the redis branch is still using the old >> way to add values:
https://github.com/rootzoll/raspiblitz/blob/fd46eb202fdbe6fdb1cad91414148ab4945d8540/home.admin/config.scripts/blitz.conf.sh#L50
TODO on this issue: replace that with the tee -a solution

OK change on the redis branch is in ... ready for final testing

Scripts works fine during the RCs. Closing this issue for v1.7.2 release.


[SDL-0188] Scripts for checking error handling during resumption for IVD

ATF Test Scripts to check #FORDTCN-7219 and #FORDTCN-7220
This PR is not ready for review.
Summary
Scripts for checking error handling during resumption for IVD
ATF version
develop
CLA

[х] I have signed the CLA

Review still in progress.

Review has been finished

@aderiabin, all comments are addressed.
Please find an update in 3505557.


Serve the internal api at /internal

I would really like to also see a test that catches this sort of failure. This kind of thing should fail the build.

I think that the test is going to be out of scope for this PR

https://www.pivotaltracker.com/story/show/155422061
Add a test to CI that hits a hello world endpoint. Make sure routing works


Can I disable contextMenu for first n columns only?

I used
contextMenu: function(obj, x, y, e) {

        if(x<5){
          return false;
        }
...
}

to disable contextMenu for the first few columns and it works. But the problem is when I right-click on columns after 5th column  contextMenu appears as it should be, but then it also starts to appear on right-clicking columns which are < 5.

Change return false; to return [];


isort: fix compatibility with isort v5

fix CLI arguments for isort v5

Coverage remained the same at 0.0% when pulling 954a841ef41d5333e1ddc6a4c73578b2c727fbaa on jrcastro2:fix-isort-v5 into bfd64ec3d788630db12986b74a86dedd6c72466c on inveniosoftware:master.


Add funding reminder dialog

This adds the funding reminder as no-op to add the strings. Changes are done in a separate pull-request.

Can we limit this to just the strings? It feels like the code will have to change anyway to be able to support the flow we talked about.


Real time processing

Dear author,
Thank you for your amazing work.
Is your method able to run in real-time?
I try to run your demo but there is error in mmdetection config file:
   obj = obj_cls(**args)  # type: ignore TypeError: __init__() got an unexpected keyword argument 'input_size'
Can you upload the config file for this detection model:
        config = './mmdetection/configs/yolox/yolox_x_8x8_300e_coco.py'
        checkpoint = './mmdetection/checkpoints/yolox_x_8x8_300e_coco_20211126_140254-1ef88d67.pth'

Dear author,
Thank you for your amazing work. Is your method able to run in real-time? I try to run your demo but there is error in mmdetection config file:  obj = obj_cls(**args) # type: ignore TypeError: __init__() got an unexpected keyword argument 'input_size' Can you upload the config file for this detection model:
        config = './mmdetection/configs/yolox/yolox_x_8x8_300e_coco.py'
        checkpoint = './mmdetection/checkpoints/yolox_x_8x8_300e_coco_20211126_140254-1ef88d67.pth'

Hi, I have encountered this error before.
This may be related to the version of mmdetection (try to use an older version).
The following versions work with torch 1.12.1 on my environment.
mmcv-full              1.7.1
mmdet                  2.26.0
mmengine               0.8.4


craft reciep conflict with xdecor

xdecor:rope is crafted out of 3 farming:cotton
and castle:ropes is using the same recipe
https://github.com/minetest-mods/xdecor/issues/73

File a report against xdecor.  Castle mod predates it by quite some time.


Add a link to OpenAPI Generator

Think this is a dupe of #1600

Closing as a duplicate, as above. Thanks for the PR.


Add better support for WireMock's RequestMatcherExtension

With RequestMatcherExtension we could consider allowing giving the users the option to pass in their own, custom matching options. Sth like this:
class DefaultRequestMatcher extends RequestMatcherExtension {

	private static final String GROOVY_EXPRESSION = "groovy-expression";

	@Override
	public MatchResult match(Request request, Parameters parameters) {
		if (!parameters.containsKey(GROOVY_EXPRESSION)) {
			return MatchResult.exactMatch();
		}
		String expression = parameters.getString(GROOVY_EXPRESSION);
		GroovyShell groovyShell = new GroovyShell();
		groovyShell.setVariable("body", request.getBody());
		return MatchResult.of(groovyShell.evaluate(expression) != null);
	}

	@Override
	public String getName() {
		return GROOVY_EXPRESSION;
	}
}

the WireMock stub could look like this:
{
    "request" : {
        "customMatcher" : {
            "name" : "groovy-expression",
            "parameters" : {
                "groovy-expression" : "new JsonSlurper(body.asString()).findAll {it.name == 'foo'}"
            }
        }
    },
    "response" : {
        "status" : 422
    }
}

then in the DSL one could call:
bodyMatchers {
    expression('new JsonSlurper(body.asString()).findAll {it.name == 'foo'}')
}

To consider:

security issues (you can run an arbitrary Groovy code)
maybe SPeL would be enough
passing in slurped body (either json or xml) instead of WireMock's body

As per our (@marcingrzejszczak and I) discussion yesterday:

Tim: I’d suggest to start with a custom matcher based on SPeL, and make a separate one for groovy? Like you said, it has a lot of security implications.
Marcin: I wonder if Spel is actually good enough to do the slurping etc. cause the body would need to be converted to a map or sth for spel to work. otoh we already parse groovy scripts that can contain all sort of crap.
Tim: That’s also true 😂 But passing the slurped body to both custom matchers should make your life easier I guess.
Marcin: I think that it could be a map - then Spel would work
Tim: Let me add these comments to github later today, so others can see our new thoughts :)


Double cancel already cancelled dao order

I believe in this block we should add also .isDeleted check
https://github.com/deso-protocol/core/blob/main/lib/block_view_dao_coin_limit_order.go#L296-L298
3JuETwcE2Qs7aUqsZruCpVds6L83Nkmug2qxTitq1VjQx9reQ8rRBR and 3JuEUVThNeQxZHEcMKFqY2ykD6CgY5Z83QV3QSQhUxb4n3UCoLUckq
Delete same dao order with id 7d034b7d1a2ead22b3ff2188e4f40a37cc143540e45cda0b83161d067625c5db
Looks like it's not normal behavior and once it's deleted first time second time the consensus should send rule error that order does not exist.

This is resolved w/ PR #363


How does this work when a user id changes their username to someone else's former username?

User ID 1 has the username "Bob"
Bot scrapes their profile
User ID 1 changes username to "Smith"
Bot scrapes the new profile "Smith"
User ID 2 creates a new account with the username "Bob"
Bot scrapes their profile

In step 4 is the previous username account renamed from Bob to Smith, or is a new folder created?

The behavior of Instaloader in step 4 depends on the invocation of Instaloader. If you instruct Instaloader to download "Bob", it will automatically detect the profile name change and renames the folder Bob to Smith. Otherwise, if you instruct Instaloader to download the renamed profile "Smith" instead while the old folder Bob exists, you would take the possibility from Instaloader to look inside the Bob folder and to apply a proper renaming. If the stored ID in the folder Bob is associated with a profile name whose folder already exists, Instaloader will also be unable to rename it.

Will it work if I only have an old nickname and don't know the new one?


[question] Same trigger different behavior depending on location?

As a newbie I don't know if it's possible to trigger different nodes using same trigger, and a previous issue called "dynamic trigger" may be also refering to this.
Below is a usecase, If I am not sure how many people will come to my party, but now I want to write an invitation. What I want to accomplish is when I press a common trigger(maybe enter), if I am in greeting area, repeat template1, else if I am in greeting area, repeat template2.
The benefits is obvious, I don't have to create snippets for those two template and memorizing their triggers, it's handdy to extend content using common trigger.

This is greeting:
Hello, [insert_node: somebody]!             (<-template1)
This is good bye:
Goodbye,[insert_node: somebody]!        (<-template2)

I have tried to use case_node inside case node to try to achieve this somehow, but it seems invalid and throws errors.
Any clue how to done this? Thanks in advance.

Alternatively (to the ideas in luasnip-tutorial), use condition to mutually exclude snippets with the same trigger.

  local input = s(
    {trig = "(input .*,)", regTrig = true },{
    d(1, function(_, snip)
        return sn(1,   fmt([[
{}
input [{} - 1:0] {}]],{t(snip.captures[1]), i(1,"WIDTH"), i(2,"SIGNAL")}))
    end)
  }
  )
  table.insert(autosnippets, input)

  local output = s(
    {trig = "(output .*,)", regTrig = true },{
    d(1, function(_, snip)
        return sn(1,   fmt([[
{}
output [{} - 1:0] {}]],{t(snip.captures[1]), i(1,"WIDTH"), i(2,"SIGNAL")}))
    end)
  }
  )
  table.insert(autosnippets, output)

A sampe I did to replicate lines that starts with input and ends with ","
The concept is add two types of new lines are all triggered by typing ",", but actually use regTrig to make them differ from each other. I hope this helps somebody.


[FIX JENKINS-31463] Implement Serializable.

Building on a slave machine you receive the following error:
Caused by: java.io.NotSerializableException: org.jenkinsci.plugins.graniteclient.JenkinsResponseProgressListener
at java.io.ObjectOutputStream.writeObject0(ObjectOutputStream.java:1183)
at java.io.ObjectOutputStream.defaultWriteFields(ObjectOutputStream.java:1547)
at java.io.ObjectOutputStream.writeSerialData(ObjectOutputStream.java:1508)
at java.io.ObjectOutputStream.writeOrdinaryObject(ObjectOutputStream.java:1431)
at java.io.ObjectOutputStream.writeObject0(ObjectOutputStream.java:1177)
at java.io.ObjectOutputStream.defaultWriteFields(ObjectOutputStream.java:1547)
at java.io.ObjectOutputStream.writeSerialData(ObjectOutputStream.java:1508)
at java.io.ObjectOutputStream.writeOrdinaryObject(ObjectOutputStream.java:1431)
at java.io.ObjectOutputStream.writeObject0(ObjectOutputStream.java:1177)
at java.io.ObjectOutputStream.writeObject(ObjectOutputStream.java:347)
at hudson.remoting.UserRequest._serialize(UserRequest.java:158)
at hudson.remoting.UserRequest.serialize(UserRequest.java:167)

So the JenkinsResponseProgressListener is not Serializable.
@reviewbybees

I'm not sure why the tests are failing. Locally checking out the master branch they also fail.

This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation.

Thank you for the PR. I'll get a build out by early next week.


Load error

It works fine on sidequest
QuestPatcher.Core.AdbException: error: device '(null)' not found
at QuestPatcher.Core.AndroidDebugBridge.RunCommand(String command, Int32[] allowedExitCodes) in D:\a\QuestPatcher\QuestPatcher\QuestPatcher.Core\AndroidDebugBridge.cs:line 148
at QuestPatcher.Core.AndroidDebugBridge.IsPackageInstalled(String packageId) in D:\a\QuestPatcher\QuestPatcher\QuestPatcher.Core\AndroidDebugBridge.cs:line 191
at QuestPatcher.Core.QuestPatcherService.RunStartup() in D:\a\QuestPatcher\QuestPatcher\QuestPatcher.Core\QuestPatcherService.cs:line 112
at QuestPatcher.Services.QuestPatcherUIService.LoadAndHandleErrors() in D:\a\QuestPatcher\QuestPatcher\QuestPatcher\Services\QuestPatcherUIService.cs:line 95

This is an ADB problem, not a QuestPatcher problem. You need to check your ADB drivers and developer mode.


postgresql: update to v14.10 to fix CVE-2023-5868, CVE-2023-5869 and CVE-2023-5870 (CP #7138)

…

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

[X] The toolchain has been rebuilt successfully (or no changes were made to it)
[X] The toolchain/worker package manifests are up-to-date
[X] Any updated packages successfully build (or no packages were changed)
[X] Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
[X] Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
[X] All package sources are available
[X] cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
[X] LICENSE-MAP files are up-to-date (./SPECS/LICENSES-AND-NOTICES/data/licenses.json, ./SPECS/LICENSES-AND-NOTICES/LICENSES-MAP.md, ./SPECS/LICENSES-AND-NOTICES/LICENSE-EXCEPTIONS.PHOTON)
[X] All source files have up-to-date hashes in the *.signatures.json files
[X] sudo make go-tidy-all and sudo make go-test-coverage pass
[X] Documentation has been updated to match any changes to the build system
[X] Ready to merge

Summary

update to v14.10 to fix CVE-2023-5868, CVE-2023-5869 and CVE-2023-5870 (CP #7138)
Change Log

update to v14.10 to fix CVE-2023-5868, CVE-2023-5869 and CVE-2023-5870

Does this affect the toolchain?

NO
Links to CVEs

https://nvd.nist.gov/vuln/detail/CVE-2023-5868
https://nvd.nist.gov/vuln/detail/CVE-2023-5869
https://nvd.nist.gov/vuln/detail/CVE-2023-5870

Test Methodology

None,  CP #7138

Auto cherry-pick results:

main :x:

Auto cherry-pick pipeline run -> https://dev.azure.com/mariner-org/mariner/_build/results?buildId=477487&view=results


Update CORE Ambassadors subtitle

@nancypontika do you still need this update?

It's stale for more than a year and since this is my PR, I close it. Reopen and merge if you need it.


Close open capture together with session

Description
When I capture multiple frames and close my application, the tab for the session in RenderDoc stays open.  When I close the tab and confirm that I don't want to save any of the captures, the currently open capture still stays open and I have to separately confirm not saving it when I launch the application again.  If I close the open capture first, there's no confirmation (because the capture is still available in the session).  Would it be possible for the session save confirmation dialog to have a checkbox to close the open capture as well if it's part of the session to be closed?
Environment

RenderDoc version: v1.12-dfsg-1
Operating System: Debian (unstable/experimental)
Graphics API: OpenGL

Indeed not closing the active open capture when you "close/delete all" by closing the connection window is deliberate, since it's an expected workflow that someone may make many captures and then close them all once they find the one that they want. There's enough ambiguity there that I want to keep an explicitly separate confirmation for the open capture and not unexpectedly lose work. As you say if you close in the other order it's much less ambiguous about the user's intent because they no longer have a capture open, so doesn't need separate confirmation.
Adding a checkbox to the close-all dialog to do this would work for an explicit confirmation, but it doesn't feel particularly 'natural' to me in UX terms and I don't think it's sufficiently valuable over the existing close menu item to justify adding it. It's still an opt-in either way, the only thing it changes as I see it is removing a separate confirmation dialog.
You could always add this customisation in a fork, or with a UI extension something along these lines in response to a menu item or keyboard shortcut:
# Close current open capture
pyrenderdoc.CloseCapture()

# Get Qt helper
mqt = pyrenderdoc.Extensions().GetMiniQtHelper()

# Find connection window
cap = mqt.FindChildByName(pyrenderdoc.GetMainWindow().Widget(), 'LiveCapture')
# this assumes there's only one connection
# you could filter with mqt.GetWidgetText(cap) to get the window title

# Close the connection, will prompt for saving
mqt.CloseToplevelWidget(cap)


cuDNN path

Click to expand!
Issue Type
Build/Install
Source
source
Tensorflow Version
tf 2.7
Custom Code
No
OS Platform and Distribution
RHEL 7
Mobile device
No response
Python version
3.9.5
Bazel version
3.7.2
GCC/Compiler version
10.3.0
CUDA/cuDNN version
11.2.1/<IP_ADDRESS>
GPU model and memory
2 nvidia v100 32gb each
Current Behaviour?
This is more of a question: on the remote server I'm working on cuDNN libraries are not installed under CUDA/11.2/include but rather they have the following paths:
for cuda: `/usr/local/easybuild/software/CUDAcore/11.2.1`
for cuDNN: `/usr/local/easybuild/software/cuDNN/<IP_ADDRESS>-CUDA-11.3.1`
When I am trying to configure by tensorflow build, I get the following message:

Could not find any cudnn.h, cudnn_version.h matching version '8.2.1' in any subdirectory:
        ''
        'include'
        'include/cuda'
        'include/*-linux-gnu'
        'extras/CUPTI/include'
        'include/cuda/CUPTI'
        'local/cuda/extras/CUPTI/include'
of:
        '/usr/local/easybuild/software/CUDAcore/11.2.1/'

I do not have sudo access to generate symlinks. I was wondering if there is a way to specify the cuDNN library path separately to the CUDA library path.

### Standalone code to reproduce the issue

```shell
##Have cuDNN and CUDA installed in separate directories
$ git clone https://github.com/tensorflow/tensorflow.git
$ cd tensorflow
$ git checkout v2.7.0
$ ./configure
You have bazel 3.7.2 installed.
Please specify the location of python. [Default is /usr/local/easybuild/software/Python/3.9.5-GCCcore-10.3.0/bin/python3]:

Found possible Python library paths:
  /usr/local/easybuild/software/Python/3.9.5-GCCcore-10.3.0/easybuild/python
  /usr/local/easybuild/software/Python/3.9.5-GCCcore-10.3.0/lib/python3.9/site-packages
Please input the desired Python library path to use.  Default is [/usr/local/easybuild/software/Python/3.9.5-GCCcore-10.3.0/easybuild/python]

Do you wish to build TensorFlow with ROCm support? [y/N]: N
No ROCm support will be enabled for TensorFlow.

Do you wish to build TensorFlow with CUDA support? [y/N]: y
CUDA support will be enabled for TensorFlow.

Do you wish to build TensorFlow with TensorRT support? [y/N]: N
No TensorRT support will be enabled for TensorFlow.

Could not find any cuda.h matching version '' in any subdirectory:
        ''
        'include'
        'include/cuda'
        'include/*-linux-gnu'
        'extras/CUPTI/include'
        'include/cuda/CUPTI'
        'local/cuda/extras/CUPTI/include'
of:
        '/lib'
        '/lib64'
        '/opt/dell/srvadmin/lib64'
        '/opt/dell/srvadmin/lib64/openmanage'
        '/opt/dell/srvadmin/lib64/openmanage/smpop'
        '/usr'
        '/usr/lib64//bind9-export'
        '/usr/lib64/dyninst'

Asking for detailed CUDA configuration...

Please specify the CUDA SDK version you want to use. [Leave empty to default to CUDA 10]: 11.2

Please specify the cuDNN version you want to use. [Leave empty to default to cuDNN 7]: 8.2.1

Please specify the locally installed NCCL version you want to use. [Leave empty to use http://github.com/nvidia/nccl]:

Please specify the comma-separated list of base paths to look for CUDA libraries and headers. [Leave empty to use the default]: /usr/local/easybuild/software/CUDAcore/11.2.1/, /usr/local/easybuild/software/cuDNN/<IP_ADDRESS>-CUDA-11.3.1/

Could not find any cudnn.h, cudnn_version.h matching version '8.2.1' in any subdirectory:
        ''
        'include'
        'include/cuda'
        'include/*-linux-gnu'
        'extras/CUPTI/include'
        'include/cuda/CUPTI'
        'local/cuda/extras/CUPTI/include'
of:
        '/usr/local/easybuild/software/CUDAcore/11.2.1/'

Asking for detailed CUDA configuration...

Please specify the CUDA SDK version you want to use. [Leave empty to default to CUDA 10]:

### Relevant log output

```shell
You have bazel 3.7.2 installed.
Please specify the location of python. [Default is /usr/local/easybuild/software/Python/3.9.5-GCCcore-10.3.0/bin/python3]:

Found possible Python library paths:
  /usr/local/easybuild/software/Python/3.9.5-GCCcore-10.3.0/easybuild/python
  /usr/local/easybuild/software/Python/3.9.5-GCCcore-10.3.0/lib/python3.9/site-packages
Please input the desired Python library path to use.  Default is [/usr/local/easybuild/software/Python/3.9.5-GCCcore-10.3.0/easybuild/python]

Do you wish to build TensorFlow with ROCm support? [y/N]: N
No ROCm support will be enabled for TensorFlow.

Do you wish to build TensorFlow with CUDA support? [y/N]: y
CUDA support will be enabled for TensorFlow.

Do you wish to build TensorFlow with TensorRT support? [y/N]: N
No TensorRT support will be enabled for TensorFlow.

Could not find any cuda.h matching version '' in any subdirectory:
        ''
        'include'
        'include/cuda'
        'include/*-linux-gnu'
        'extras/CUPTI/include'
        'include/cuda/CUPTI'
        'local/cuda/extras/CUPTI/include'
of:
        '/lib'
        '/lib64'
        '/opt/dell/srvadmin/lib64'
        '/opt/dell/srvadmin/lib64/openmanage'
        '/opt/dell/srvadmin/lib64/openmanage/smpop'
        '/usr'
        '/usr/lib64//bind9-export'
        '/usr/lib64/dyninst'

Asking for detailed CUDA configuration...

Please specify the CUDA SDK version you want to use. [Leave empty to default to CUDA 10]: 11.2

Please specify the cuDNN version you want to use. [Leave empty to default to cuDNN 7]: 8.2.1

Please specify the locally installed NCCL version you want to use. [Leave empty to use http://github.com/nvidia/nccl]:

Please specify the comma-separated list of base paths to look for CUDA libraries and headers. [Leave empty to use the default]: /usr/local/easybuild/software/CUDAcore/11.2.1/, /usr/local/easybuild/software/cuDNN/<IP_ADDRESS>-CUDA-11.3.1/

Could not find any cudnn.h, cudnn_version.h matching version '8.2.1' in any subdirectory:
        ''
        'include'
        'include/cuda'
        'include/*-linux-gnu'
        'extras/CUPTI/include'
        'include/cuda/CUPTI'
        'local/cuda/extras/CUPTI/include'
of:
        '/usr/local/easybuild/software/CUDAcore/11.2.1/'

Asking for detailed CUDA configuration...

Please specify the CUDA SDK version you want to use. [Leave empty to default to CUDA 10]:

</details>

@ozencgungor Could you refer to this link to know more on the tested build configurations . Please try with the latest TF v2.8.0  and let us know if it helps ?
Thank you!

@sushreebarsa I will try but the cluster I'm working with has Bazel v3.7.2 as the latest version. I'll try and update the Bazel version and build Tensorflow v2.8.0. The issue seems that my cuDNN library files are not under the CUDA directory /usr/local/easybuild/software/CUDA/11.3.1 but rather at /usr/local/easybuild/software/cuDNN/<IP_ADDRESS>-CUDA-11.3.1. I do not have sudo access to create symlinks but maybe the newer bazel version and the newer tensorflow version will solve this issue.

@sushreebarsa Tried with Bazel v5.1.1 insalled through bazelisk with the latest tf version obtained from github through a git clone and no git checkout and it still is the same issue. Because cuDNN libraries are in a different directory, the configuration script fails to find the cuDNN libraries and the cudnn.h file. I have added all the relevant paths to my $LD_LIBRARY_PATH and my $PATH in my ~/.bashrc file and sourced it to no avail.
As a note, I am able to build the latest jax and jaxlib versions on this system without any issues so it seems the issue is that configure.py and configure.cmd are only able to look for cudnn files under .../CUDA/11.3.1 even though I supply the correct path when prompted.
Here is an example configure step:
[oxg34@gput062 tensorflow]$ ./configure
You have bazel 5.1.1 installed.
Please specify the location of python. [Default is /usr/local/easybuild/software/Python/3.9.5-GCCcore-10.3.0/bin/python3]:

Found possible Python library paths:
  /usr/local/easybuild/software/Python/3.9.5-GCCcore-10.3.0/easybuild/python
  /usr/local/easybuild/software/Python/3.9.5-GCCcore-10.3.0/lib/python3.9/site-packages
Please input the desired Python library path to use.  Default is [/usr/local/easybuild/software/Python/3.9.5-GCCcore-10.3.0/easybuild/python]
/usr/local/easybuild/software/Python/3.9.5-GCCcore-10.3.0/lib/python3.9/site-packages
Do you wish to build TensorFlow with ROCm support? [y/N]: N
No ROCm support will be enabled for TensorFlow.

Do you wish to build TensorFlow with CUDA support? [y/N]: y
CUDA support will be enabled for TensorFlow.

Do you wish to build TensorFlow with TensorRT support? [y/N]: N
No TensorRT support will be enabled for TensorFlow.

Could not find any cuda.h matching version '' in any subdirectory:
        ''
        'include'
        'include/cuda'
        'include/*-linux-gnu'
        'extras/CUPTI/include'
        'include/cuda/CUPTI'
        'local/cuda/extras/CUPTI/include'
of:
        '/lib'
        '/lib64'
        '/opt/dell/srvadmin/lib64'
        '/opt/dell/srvadmin/lib64/openmanage'
        '/opt/dell/srvadmin/lib64/openmanage/smpop'
        '/usr'
        '/usr/lib64//bind9-export'
        '/usr/lib64/dyninst'

Asking for detailed CUDA configuration...

Please specify the CUDA SDK version you want to use. [Leave empty to default to CUDA 11]: 11.3

Please specify the cuDNN version you want to use. [Leave empty to default to cuDNN 2]: 8.2.1

Please specify the locally installed NCCL version you want to use. [Leave empty to use http://github.com/nvidia/nccl]:

Please specify the comma-separated list of base paths to look for CUDA libraries and headers. [Leave empty to use the default]: /usr/local/easybuild/software/CUDA/11.3.1/, /usr/local/easybuild/software/cuDNN/<IP_ADDRESS>-CUDA-11.3.1/

Could not find any cudnn.h, cudnn_version.h matching version '8.2.1' in any subdirectory:
        ''
        'include'
        'include/cuda'
        'include/*-linux-gnu'
        'extras/CUPTI/include'
        'include/cuda/CUPTI'
        'local/cuda/extras/CUPTI/include'
of:
        '/usr/local/easybuild/software/CUDA/11.3.1/'

Asking for detailed CUDA configuration...

Please specify the CUDA SDK version you want to use. [Leave empty to default to CUDA 11]: 11.3

Please specify the cuDNN version you want to use. [Leave empty to default to cuDNN 2]: 8

Please specify the locally installed NCCL version you want to use. [Leave empty to use http://github.com/nvidia/nccl]:

Please specify the comma-separated list of base paths to look for CUDA libraries and headers. [Leave empty to use the default]: /usr/local/easybuild/software/CUDA/11.3.1/:/usr/local/easybuild/software/cuDNN/<IP_ADDRESS>-CUDA-11.3.1/

Could not find any cuda.h matching version '11.3' in any subdirectory:
        ''
        'include'
        'include/cuda'
        'include/*-linux-gnu'
        'extras/CUPTI/include'
        'include/cuda/CUPTI'
        'local/cuda/extras/CUPTI/include'
of:

Asking for detailed CUDA configuration...

Please specify the CUDA SDK version you want to use. [Leave empty to default to CUDA 11]:

The paths to CUDA and cuDNN for me are:
-for CUDA: /usr/local/easybuild/software/CUDA/11.3.1/
-for cuDNN: /usr/local/easybuild/software/cuDNN/<IP_ADDRESS>-CUDA-11.3.1/
-for NCCL: /usr/local/easybuild/software/NCCL/2.10.3-GCCcore-10.3.0-CUDA-11.3.1
I do not have sudo access to create a symlink or anything similar. Any help would be appreciated.

@ozencgungor,
Glad that this issue is resolved.
export statement is already available in GPU support doc. Please take a look at this link. Thank you!
export LD_LIBRARY_PATH=$LD_LIBRARY_PATH:/usr/local/cuda/extras/CUPTI/lib64

Hi @ozencgungor,
Since the issue is resolved can we move this to closed status.
Thank you!


webpack 4 merge

Alright this is looking much closer then it was initially.
@sokra:
* what remaining issues do we have (if you have their issues) remaining to cut a RC for 4.
@d3viant0ne: We should get a quick and dirty interop map for v4 and what plugins and loaders break via use.
@andreicek: We are pretty darn close to being able to use webpack-canary. I wonder if we can strap up canary for v4 against all loaders and plugins in webpack-contrib.

We are pretty darn close to being able to use webpack-canary. I wonder if we can strap up canary for v4 against all loaders and plugins in webpack-contrib.

As discussed over slack - @darkokukovec and myself will start on adding webpack-canary to the webpack core and start testing contrib packages that have an exmaple folder first, afterwards we'll either open an issue or add an example folder ourselves on contrib repos that are not yet eligible.

Found a pretty bad bug with the tree shaking using side-effects: false and slimmed down the repro. The repro occurs when a file is blank or only contains comments, and is exported using * export from the index of a library.
Here's a basic setup that I got reproing. I'm not completely sure i can distill a simpler repro. both app and my-library are "side-effects": false.
If you comment out the blank.js export from my-library / index.js, then the string shows up. But when it's included a bunch of the modules don't show up in the bundle! There are references to them, but they're missing.
app / index.js:
import { foo } from './MyLibrary';
console.log(foo);

app / MyLibrary.js
import * from 'my-library';

my-library / index.js:
export * from './foo.js'
export * from './blank.js'

my-library / foo.js:
export const foo = 'foo';

my-library / blank.js:
// Blank

@TheLarkInn - All of the repos that have already been converted to defaults run a canary test suite on NodeJS v8 on the webpack master branch.
We can switch that to a convention that doesn't require the code to land in the master branch as long as we can come up with some sort of convention we are all going to stick to thought master is probably going to be the most useful as it picks up unpublished fixes for whatever the currently major version series is without requiring the changes to be published to a beta / next tag.

This discussion with the canary group has continued in slack & published tags aren't going to be a viable option. The current thinking is going this route....

//cc @andreicek

@sokra Tests pass 😮😮😮! Do you have a short list of things waiting on this to go master? I have one or two maybe that we should cut final v3 on.

@mathiasbynens Could you sign the CLA (again)? https://cla.js.foundation/webpack/webpack?pullRequest=5660
Not sure why it says you haven't signed it...

@mathiasbynens Could you sign the CLA (again)? https://cla.js.foundation/webpack/webpack?pullRequest=5660

Done.

Does this mean we can go forward with Prettier PR?
On Tue, Feb 13, 2018, 3:58 AM Tobias Koppers<EMAIL_ADDRESS>wrote:

Merged #5660 https://github.com/webpack/webpack/pull/5660.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/webpack/webpack/pull/5660#event-1471485073, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ADQBMKUV9Sjo_IwDM-hr4ASahsy0R26rks5tUXjegaJpZM4PS-_w
.


ludwig CLI: cannot 'train' or 'experiment'

Installed ludwig today (pip install ludwig) on Python 3.5.5 on Ubuntu 16.04 and on Python 3.6.8 on Windows 10 (version 1809).   In both environments, ludwig seems to be failing to open the model file and issues the error "AttributeError: 'str' object has no attribute 'get'".
Here is my cmd line:
ludwig experiment  --model_definition model_definition.yaml  --data_csv e:\github\LabCoat\Client\data\cars.json
Here is the stack trace:
Traceback (most recent call last):
File "c:\anaconda3\envs\babyai\lib\runpy.py", line 193, in _run_module_as_main
"main", mod_spec)
File "c:\anaconda3\envs\babyai\lib\runpy.py", line 85, in run_code
exec(code, run_globals)
File "c:\anaconda3\envs\babyai\Scripts\ludwig.exe_main.py", line 9, in
File "c:\anaconda3\envs\babyai\lib\site-packages\ludwig\cli.py", line 86, in main
CLI()
File "c:\anaconda3\envs\babyai\lib\site-packages\ludwig\cli.py", line 64, in init
getattr(self, args.command)()
File "c:\anaconda3\envs\babyai\lib\site-packages\ludwig\cli.py", line 67, in experiment
experiment.cli(sys.argv[2:])
File "c:\anaconda3\envs\babyai\lib\site-packages\ludwig\experiment.py", line 548, in cli
experiment(**vars(args))
File "c:\anaconda3\envs\babyai\lib\site-packages\ludwig\experiment.py", line 161, in experiment
model_definition = merge_with_defaults(model_definition)
File "c:\anaconda3\envs\babyai\lib\site-packages\ludwig\utils\defaults.py", line 126, in merge_with_defaults
model_definition.get('preprocessing', {})
AttributeError: 'str' object has no attribute 'get'
It doesn't seem to be opening the model file (same error with existing or non-existing model file specified).

Also, just tried building ludwig from source code.  Build completed OK (and created new ludwig.exe), but running 'train' or 'experiment' still gives the same error as above.

Could you please paste your model_definition yaml file?

Sure, here it is:
input_features:
-
name: text
type: text
encoder: parallel_cnn
level: word
output_features:
-
name: class
type: category

PLease use --model_definition for passing a YAML encoded string, while use --model_definition_file for the YAML file.
Example:
--model_definition "{input_features: [{name: body, type: text}], output_features: [{name: class, type: category}]}"

is equivalent to:
--model_definition_file def.yaml

with def.yaml:
input_features:
  -
    name: body
    type: text
output_features:
  -
    name: class
    type: category

@rfernand2 I think the issue is your yaml file's format. You need to tab/space separate the features like shown in the previous comment:
input_features:
name: text
type: text

output_features:
name: class
type: category

@msaisumanth - thanks but I did have spaces (of 2 and 4) as shown in your example.  For some reason, copy/paste stripped them out.  I think the problem was using the wrong cmd line argument as pointed out by @w4nderlust above.

Looks like that solved it.

@w4nderlust - thanks for the correction about the command line argument name.  I can see I am getting further now.  I'll close this issue now.

Hello,
I have build the traning and test csv files for image classification excercise. The moment I launch:
ludwig train
--data_train_csv </Users/tomcheckiewics/Documents/Datasets/catsdogs_dataset_training.csv>
--data_test_csv </Users/tomcheckiewics/Documents/Datasets/catsdogs_dataset_test.csv>
--model_definition_file model_definition.yaml
I am getting the follwing error:
usage: ludwig train [options]
ludwig train: error: one of the arguments -md/--model_definition -mdf/--model_definition_file is required
it looks like the --model_definition_file model_definition.yaml is not recognized by ludwig train.
Would you be able to point me out into a right direction to resolve this ?
Many thanks
T.

Remove < and > from your command.

Thank you very much and enjoy the weekend.
T.


Give priority to target module hints when stringifying imports

Will solve #41.
The bug was introduced by using the first Hint, but it may be the case that the first hint is not a hint from the target module. Solved this by partitioning the list and then concatenating it again. I believe that this will fix it (modules cannot declare a certain type/type alias twice and thus the first Hint will be the correct import reference.
One thing I do not understand is why this code relies on Hints? This makes it prone to these kind of errors. What is the use case for this?
Should I also generate the new indexer.js?

@stil4m, thanks a lot for the PR!  I'll try this out tomorrow.  This package started out as an experiment to put type hints in Atom (the initial code was from Try Elm).  I only wanted to have the "Sidekick" functionality to help me read and understand Elm 0.17 code (I was using 0.16 back then).  I realized that I could have other features like Go To Definition by just using the hints, and haven't had the chance to refactor the code since then.  The ideal and accurate solution would really be to use ASTs and I'm patiently waiting for the core team to release that :-)

You can generate indexer.js if you like, else I can do it after testing.  I had to include that in the repo since it's going to be used by Atom.

I think it is better for you to generate the javascript. That keeps this PR simple and clean.
I had to figure out how the project was set up. Are you planning to add build scripts? I can do this in a new PR if you like.
About the hints: That clears things up :)

Thanks for the offer!  You can submit a PR for that.  I'm just compiling the .elm files manually.  I'll generate the js file after testing.  Thanks again!


PR #96 changes affected our implementation

I'm a contributor to WhisperKit repo. We're trying to adopt mlx-swift so it can work side by side with coreml implememtation.
When updating mlx-swift to the latest version (0.16.0) our whipser mlx pipeline started working incorrectly.
Details:

the last working commit is d6d9472da5bf7ec2654e8914bd1d15622f45b6a9 seems like 36d63a1fc386a551df14f5b67df1756dc17d2ebc broke something (this PR https://github.com/ml-explore/mlx-swift/pull/96)
I suspect it might be related to the functions which allow conversion between MLXArray and MLMultiArray types, these functions are here:

asMLMultiArray
asMLXArray

Not sure what's wrong here, I'd be grateful for any advice, thanks!

Happy to help but I need more info about what isn't working -- what is the failure and how can I reproduce it?

Happy to help but I need more info about what isn't working -- what is the failure and how can I reproduce it?

testArrayConversion in MLXUtils.swift stopped working for mlx-swift after the mentioned PR #96 I suspect that asStrided here is not needed any more, could you confirm that?
If I remove asStrided tests are passing but the pipeline is outputting garbage so the bug is still there. Implementation wise, does these 2 functions looks good to you?

asMLMultiArray
asMLXArray

Ah, this is an interesting one. So consider this code:
let count = 16
let arr1 = MLXArray(0..<count, [2, count / 2]).asType(Int32.self)

// asMLXOutput
let t1 = arr1.squeezed().swappedAxes(0, 1).expandedDimensions(axes: [0, 2])

If we print(t1.strides) we will see [16, 2, 2, 1] -- these are the strides in the graph before it is evaluated (contiguous).  If we evaluate the graph and print the strides, now we see [8, 1, 16, 8] -- these are the actual strides, once realized.
In asMLMultiArray() it uses the latter strides with t1.asData(), however, the fix mentioned above fixes that method to produce contiguous ([16, 2, 2, 1]) memory.
So we have a few interesting bits:

strides returns different values if the graph is evaluated or not
asData used to return the contents of memory as-is and now returns the data linearized

So the fix for WhisperKit could be to not use strides but compute the contiguous strides instead, in particular in the asMLMultiArray() call.
However, I have a few questions, maybe @awni has an opinion here:

should asData return the linearized form of the MLXArray backing?

I think so -- the rough equivalent is tolist in python, but that is not an exact match
if it didn't do this then I think we would want an operation to convert an MLXArray to contiguous backing for those callers who need it

should strides return different values over time?

there is no python equivalent to this
but the C++ API would suggest this is fine -- it is the expected stride until realized

should swift expose the strides property?

C++ does but python does not
In C++ you have more access to the raw memory so perhaps it is needed

Thanks for the answer @davidkoski will dig deeper into it. You mentioned

So the fix for WhisperKit could be to not use strides but compute the contiguous strides instead, in particular in the asMLMultiArray() call.

how can I compute the contiguous strides? Does mlx-swift allow to do it right now?

There isn't a function for it, but it would be something like this:
        var contiguousStrides = [1]
        var stride = 1
        for dimension in self.shape.dropFirst().reversed() {
            stride = stride * dimension
            contiguousStrides.append(stride)
        }
        contiguousStrides.reverse()

got it, or computing the strides before the graph is evaluated, so asMLMultiArray could looks something like this
func asMLMultiArray() throws -> MLMultiArray {
    let dataType = multiArrayDataType()
    let strides = strides.map { NSNumber(value: $0) }
    // a buffer to be passed to CoreML
    let buffer = UnsafeMutableRawPointer.allocate(byteCount: nbytes, alignment: 8)
    // copy the data from the MLXArray backing into buffer
    asData(noCopy: true).withUnsafeBytes { ptr in
        let destination = UnsafeMutableRawBufferPointer(start: buffer, count: nbytes)
        ptr.copyBytes(to: destination)
    }
    return try MLMultiArray(
        dataPointer: buffer,
        shape: shape.map { NSNumber(value: $0) },
        dataType: dataType,
        strides: strides,
        deallocator: { $0.deallocate() }
    )
}

but probably computing contiguousStrides makes more sense because the point where the graph is evaluated might change

yeah, exactly -- you don't know if it has already been evaluated when your code is called

I think your larger message above covers everything @davidkoski !
My vote would be on not exposing the strides at all in Swift. It is slightly counter intuitive but the pointer should also not be exposed because it might not exist yet (ie be null). Both of these are artifacts of the lazy evaluation.
A good compromise is to design a small protocol like the buffer protocol in python that when accessed would force array evaluation.
In C++ that could be something returning an instance of the following struct
template <typename T>
struct Buffer {
  T *data;
  vector<size_t> shape;
  vector<size_t> strides;
}

Obviously this brings forward the question of data ownership. So who owns the data pointer? To have a true no copy casting maybe that struct could hold the mlx array so as long as the struct instance exists then the data exists too.

My vote would be on not exposing the strides at all in Swift.

+1, it is a foot gun. It's not really intended to be used in the C++ API either unless you are doing an extension.
I'm not sure the best thing to do for asData. It sounds like it's more low-level access to the array than tolist and it would be nice if it could be copy free? Is that right? In that case I like @angeloskath suggestion, provided we can work out ownership issues.

asData() has two modes right now:

attempt to wrap the interior pointer without copying -- caller is responsible for lifetime

this is useful e.g. for passing off image data to create a new image where you only need the data for an instant
this will always return contiguous data so it falls back to copying if needed

copy the data as contiguous -- safe in all cases

I like @angeloskath suggestion.  I think it will be something along the lines of:
struct Result {
    let data: Data
    let shape: [Int]
    let strides: [Int]
    let dType: Type
}

enum AccessMethod {
    case copy
    case noCopyContiguous
    case noCopyStrided
}

func asData(access: AccessMethod = .copy) -> Result

Something like that -- callers can specify how they want the data exposed.  The first two enum options are what we have right now.
Then I will deprecate the strides method on MLXArray

Sounds great to me. What do you think about these case names maybe slightly more clear:
enum AccessMethod {
    case copy
    case noCopyIfContiguous
    case noCopy
}

Yes, I like those better


Integration: Google Calender

I know that this is not ready to merge yet, but can @timabbott take a look at it and make sure it's fine so far and that I'm on the right track?
Thanks.
I just need to add the documentation and it should be done, assuming I've done it correctly so far.

Automated message from Dropbox CLA bot
@fazerlicourice7, it looks like you've already signed the Dropbox CLA. Thanks!

It's hard to tell what you changed; can you do separate commits for the code changes from renaming the file?
That's our expected version control style anyway: https://zulip.readthedocs.io/en/latest/version-control.html

@timabbott like this?

Yeah, that's a lot more readable.  Cool, this looks pretty reasonable, thanks for working on this @fazerlicourice7!  A few thoughts:

We should write the documentation and then get another developer on chat.zulip.org to test-solve the new documentation; that will also server to test the tool :)
It seems like this removes support for specifying a specific calendar -- it now only supports the primary calendar for a google account.  How hard would it be to restore that capability?

I was told not to worry about the client_secret file, and that those would be created on each server. I'm not exactly sure what I can do about that.

@fazerlicourice7, looks good. I have left minor feedback mostly relating to style.

Am I supposed to make the changes that @umairwaheed left or not since @femnad accepted it?

Generally you should try to address everyone's request for changes. I accepted as a way of saying that I passed the torch to other reviewers.

@fazerlicourice7, looks almost done, however, you need to fix the following before we can merge this:

Use imperative style in your commit messages. See commit message style guide for Git.
Fix those Travis builds.

I've been out of the loop on this PR, but I'm not sure why we are writing credentials files into the repo directory structure:
+    credential_dir = os.path.join(ZULIP_PATH, 'api/integrations/google/')
 +    if not os.path.exists(credential_dir):
 +        os.makedirs(credential_dir)
 +    credential_path = os.path.join(credential_dir,
 +                                   'google-credentials.json')

Why can't we write to the user's home directory?
Also, we may just want to squash these three commits together, as I'm not convinced the first two commits represented working code or just work in progress.

Do you want me to go ahead and make those changes? Or is that something that you and the other mentors need to decide?

@fazerlicourice7 You can make those changes now.

@showell Are you sure I should squash the commits, because that's what I originally had, but @timabbott said I should separate them...

Ideally, I'd like them separate too, but I wasn't exactly sure that the code was still working after the 1st and 2nd commits.   Also, the first commit seemed to introduce some random changes like changing the timer.
Pinging @timabbott to look at this, anyway.  I'm not too familiar with the history of this code, and I haven't been following the PR too closely.

I didn't change the code at all in the 3rd commit, it was only documentation. It works fine for all the tests I've done...

Also, there seems to be a conflict, but I don't see it if I update my local fork with fetch upstream and rebase upstream, and it won't load when I click "Resolve Conflicts".

If this isn't ok, can I have an extension? Because I won't be able to come back to this until after school tomorrow. Thanks.

I can take care of splitting the technical changes from the file move just before merging.
I think this looks good, but @TomaszKolek can you give this a review (including testing it out manually to make sure it works)?

@timabbott I think this is ready to merge with a few caveats.  You volunteered to help reorganize the commits a bit here with regard to moving the files to their new home.  We still have "gcal" in some names, which causes minor irritations like making alphabetizing lists of integrations brittle (gcal < git < google-calendar).  Can we consider using a longer name like "google-calendar"?

Hmm, yeah, I think calling it "google calendar" rather than "gcal" is a good idea.

@fazerlicourice7 can you rename it, and then I'll take care of the extra git gymastics?

done @timabbott :)

@fazerlicourice7 I tried running this, and got this exception:
Traceback (most recent call last):
  File "/srv/zulip-py3-venv/lib/python3.5/site-packages/oauth2client/clientsecrets.py", line 122, in _loadfile
    with open(filename, 'r') as fp:
FileNotFoundError: [Errno 2] No such file or directory: '/home/tabbott/client_secret.json'

I'm a bit confused how this works -- did you register an Oauth application and then the idea is that we'll oauth to that app, and it'll save the credentials?  The problem with that approach is that then the setup process will require the user to register an oauth application to set this up...

In reply to your first comment, yes, the user does have to create an oauth application through google, and save those credentials, the script then gets authorization from an individual google account.  In the docs, there are complete instructions on how to do this. I know that this is tedious for the user, but oauth needs an application's client_secret info, and the only way to do that is to distribute via Zulip(which is better for the user), but @showell said Zulip doesn't do that. So, the user would have to get their own client_secret file from google.

OK, makes sense; I guess I'd just missed that in the instructions.  Eventually we'll want to setup a nicer Oauth system for doing this, but this is great for now.  Merged, thanks @fazerlicourice7!!

yup, no problem.


Change actions to a list in the defineVote method

We need to change how "actions" executes. If we want to execute multiple actions, dictionaries do not have a guaranteed order, so this could become a problem if order of actions matters.

@BennyOptions I think order in dictionary is guaranteed to be insertion order in python 3.7+.

Thanks Ted. Good to know!


refactor(starknet_api): transaction hash

This change is

#638  👈
nimrod/resources_enum/hold_validResourceBounds

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @AvivYossef-starkware and the rest of your teammates on  Graphite