revert pdf changes and add new pdf for empty page testing

revert the layout parser fast pdf file to original with just two pages
add a new file that has one empty page and one page says "this page is intentionally left blank" for tests

since most of these tests are mocks, can we go back with the old example-docs/layout-parser-paper-fast.pdf in the fixtures? (only change any test that needs to be changed)

I would argue all the partition tests should be testing against a doc with potential blank page. The existing tests are testing different parameters for partitioning. Alternatively we should probably give a variety of documents (the empty page is just one edge case) to test for each partition setup as another parametrized fixture.

ok, i wasn't sure all of these tests were doing real partitioning vs. testing the flow of the code.
assuming it is doing real partitioning, the -empty- files seems like it is more real (ignoring empty) pages than it needs to be which will add significant time to CI vs the existing -fast.pdf file (which isn't processed super "fast," to be fair).

ok, i wasn't sure all of these tests were doing real partitioning vs. testing the flow of the code. assuming it is doing real partitioning, the -empty- files seems like it is more real (ignoring empty) pages than it needs to be which will add significant time to CI vs the existing -fast.pdf file (which isn't processed super "fast," to be fair).

is it adding a lot though? Looking at successful action runtime it seem to have barely changed compared to existing ones. Also this change adds one blank page and one page with one line of text. If this do actually add a lot of time we do have something to worry about.
With that said, yes, running tesseract on a single page is adding a few seconds on linux so for those tests we are adding a few seconds to each test.
The new setup of one real blank and one with one line (that also allows us to test difference between fast and other strategies) is justifiable since it adds two most basic edge case testing scenarios without adding more. Now I do think we could do better with the testing by saving the results from tersseract calls for later use on the same page (which probably can be a feature even...)

ok, i was thrown off by:

looking much larger. i thought you were taking layout-parser-paper.pdf and adding pages which would have been much slower.
still not crazy about extra seconds when one test should be sufficient to show we are handling blank pages correctly. 🤷 these tests show we are not crashing (which is fine), but since we have the extra test file, we might as well assert the metatdata.page_numbers we are getting back are what's expected.

ok, i was thrown off by:  looking much larger. i thought you were taking layout-parser-paper.pdf and adding pages which would have been much slower. still not crazy about extra seconds when one test should be sufficient to show we are handling blank pages correctly. 🤷 these tests show we are not crashing (which is fine), but since we have the extra test file, we might as well assert the metatdata.page_numbers we are getting back are what's expected.

that's fair; let me just use the empty page one for that one test for now


Nested object - java.util.NoSuchElementException: head of empty list

exception is thrown when:
    case class A(b: B)
    case class B(c: Option[C])
    case class C(s1: String, s2: String)

    val msg = A(B(Some(C("ds", "xd"))))
    val bytes = msg.toPB
    val parsed = bytes.pbTo[A]

If you change B to to case class B(c: C) it works.
If you change C to case class B(c: C) it works.
Am I doing something wrong or is it bug?

I believe you missed the following import cats.instances..option._ when you call msg.toPB ?
If you import cats.instances.option._ and then run your code it should be ok.


heartbeat can not be set to 0

The internal logic treats 0 as None and sets the default instead. There is no workaround I can see except to set heartbeat to a ridiculously high number.
The real problem however is that my apps are getting heartbeat exceptions even tho there is traffic on the connection. RabbitMQ 3.5.1, python 2.7.9 on Amazon Linux, local connection between client and server.
I believe this is because there has been other traffic sent on the connection during the interval, hence no heartbeat is sent by the server on channel 0. I am checking w Pivotal to confirm my understanding of server behavior.

Oh actually the logic looks OK - I missed a paren - I'll investigate more and comment again.

Ah - the logic in Channel0._negotiate is the culprit:
return min(client_value, server_value) or (client_value or server_value)
will never return a 0 for heartbeat.

Still leaving the real problem however...

And the same logic prevents the 'ridiculously high number' workaround - hmmm.

I'll look into this ASAP.

Thanks!
On Monday, April 13, 2015, Gavin M. Roy<EMAIL_ADDRESS>wrote:

I'll look into this ASAP.
—
Reply to this email directly or view it on GitHub
https://github.com/gmr/rabbitpy/issues/69#issuecomment-92362452.

I'll release the a new version ASAP (likely tonight)


CLOUDSTACK-8634: Made changes to test_security_group.py test suite to support EIP

Made changes to test_security_group.py test suite to support EIP

In case of a basic zone with EIP/ELB capability vm will have two ip addresses one from public ip range and another one from guest ip range.
vm creation method in base.py returns vm ip address which is part of guest ip range as the vm.ssh.ipaddress if we don't pass mode to it. So access to vms with that ip address would not be successful. Made changes to handle this
2.vm public address is associated with Netscaler. So even if we don't allow ping traffic in security groups applied to vm, ping will be successful. Skipping ping test in case the zone is enabled with EIP/ELB
3.Removing default rules from security groups except what is needed for that test.

Test Results:
Test ingress rules for specific IP set ... === TestName: test_ingress_rules_specific_IP_set | Status : SUCCESS ===
ok
Test revoke ingress rule ... === TestName: test_01_revokeIngressRule | Status : SUCCESS ===
ok
Test ingress rules for specific IP set and non default security group ... === TestName: test_ingress_rules_specific_IP_set_non_def_sec_group | Status : SUCCESS ===
ok

LGTM

LGTM


Changed package of WrapsDriver class.

Percy is not compatibile with Selenium 4 because WrapsDriver has been removed from package org.openqa.selenium.internal (marked as Deprecated since Selenium v. 3.14.0).

By this change new Percy java version will be compatible with Selenium v. 3.14.0 and later

👋🏼 thanks for the PR! this will be taken care of with #70. This would be a breaking change (see #68 for context). It was originally set to use internal, then the proper import (from 3.14 forward). But since the SDK worked with 3.x, shipping that was a breaking change and needed to be reverted (for a major version)


TypeError: Cannot read property 'error' of null

`
TypeError: Cannot read property 'error' of null
_toError
node_modules/spotify-web-api-node/src/http-manager.js:34
31 | };
32 |
33 | var _toError = function(response) {

34 |   if (typeof response.body === 'object' && response.body.error && typeof response.body.error === 'object' && response.body.error.reason) {
35 |     return new WebapiPlayerError(response.body, response.headers, response.statusCode);
36 |   }
37 |
`

I keep getting these errors for spotify recommendation tracks node. Any one know how to circumvent these errors? They are getting more and frequent.  What is going on?

Hi, I'm getting the same error when using the searchTracks() helper function. Have you found any solution to this yet?

still facing this issue

this generally happens when we get the response code 403  which means forbidden according to Spotify's API documentation.
to solve this problem just add the scope of the response you want to get in the authentication URL and it will start working.

I would like to work on this Issue to throw forbidden error on 403 response code, if no one is working on this assing this to me please.


contrafissura, exsuscitate

This pull request was generated by the 'mq' tool
[test]
flake rate: 0.4
logical conflict every: 100
sleep for: 300s
[pullrequest]
requests per hour: 30
deps=[c,e]

/trunk merge


refactor: sqlite delegate sorting

Summary
https://app.clickup.com/t/862kdkh56
For sqlite databases temporary tables are used to store data used for sorting

Checklist

[ ] I checked my UI changes against the design and there are no notable differences
[ ] I checked my UI changes for any responsiveness issues
[ ] I checked my UI changes in light AND dark mode
[ ] I checked my (code) changes for obvious issues, debug statements and commented code
[ ] I opened a corresponding card on Clickup for any remaining TODOs in my code
[ ] I added a short description on how to test this PR (if necessary)
[ ] Documentation (if necessary)
[ ] Tests (if necessary)
[ ] Ready to be merged

closing as we'll disable sorting instead since it makes it quite messy


Please invite me to the GitHub Community Organization

Please invite me to the GitHub Community Organisation.

Name: Chinmay Agnihotri

Discord Username(if exists):

Additional Context:

I saw Eddie's profile on LinkedIN

I am a CS student aspiring to be a developer, and since I use open-source software, I'd like to learn how to contribute to the community! Thank you.
:nerd_face:

Invitation sent for the GitHub Organisation. Welcome to the community 🎉
Don't forget after accepting to make it public so it appears on your GitHub profile for everyone else to see, you can do this by finding your name in the GitHub organisation list and change the dropdown to public https://github.com/orgs/EddieJaoudeCommunity/people
Tips for practising:
Customise your GitHub profile, here is a live stream on it https://www.youtube.com/watch?v=cT6GXCuS0Zo
Practice repo, instructions on how to add your name to the README in the README https://github.com/EddieJaoudeCommunity/hacktoberfest-practice
Remember contributing to open source is not just about code, its about collaboration, communication and adding value
I hope that helps

Invitation sent for the GitHub Organisation. Welcome to the community 🎉
Don't forget after accepting to make it public so it appears on your GitHub profile for everyone else to see, you can do this by finding your name in the GitHub organisation list and change the dropdown to public https://github.com/orgs/EddieJaoudeCommunity/people
Tips for practising:
Customise your GitHub profile, here is a live stream on it https://www.youtube.com/watch?v=cT6GXCuS0Zo
Practice repo, instructions on how to add your name to the README in the README https://github.com/EddieJaoudeCommunity/hacktoberfest-practice
Remember contributing to open source is not just about code, its about collaboration, communication and adding value
I hope that helps


Removed tests out of run_in_graph_and_eager_mode in lookahead

cc @gabrieldemarmiesse

@cyberzhg
You are owner of some files modified in this pull request.
Would you kindly review the changes whenever you have the time to?
Thank you very much.


Testbench gives multiples 1'bx when use high number of inputs/outputs

Hello every one,
As the title says i had a couple of erros when i used mutiples i/o. Trying to find the mistake, i simplified my modules on a couple of adders:
The module adder_128_with_vector is a simple add of two numbers of 128 bits, the output has 129 bits and the i/o are defined as a unitary vector, e.g. input [127:0] i_num_1.

The module adder_128_without_vector is a simple add of two numbers of 128 bits, the output has 129 bits and each i/o are defined 1 by 1, I thought the problem might be the definition of i/o.

the module adder_128SSE perform 4 adds of two numbres of 32 bits but it received just 1 input of 128 bits.

It can be seen in the previous images that each of the above testbenches has an error or unknow value.
I want to know what is wrong in my project and how i can solve my problem?
share my openfpga_flow folder
https://github.com/Baungarten-CINVESTAV/OpenFPGA_addr_test
Thanks in advance

Sorry, I forgot to add this information.
Those testbench was run with the task preconfigured_testbench_without_self_checking

@Baungarten-CINVESTAV Can you check if the post-synthesis netlists from Yosys is correct or not? This will help us to spot the bug.

Hello @tangxifan
With the post-synthesis netlists from Yosys file are you talking about xxx_ace_out.blif, xxx_yosys_out.blif, xxx.blif , xxx.net or  fabric_netlist.v file?

@Baungarten-CINVESTAV Can you check if the post-synthesis netlists from Yosys is correct or not? This will help us to spot the bug.

Hello,
I have checked all the .blif files and their boolean equations are correct, to test the blif file, I developed a matlab script that takes the blif file and gets the SOP boolean equation for each output, then I compared the result of the boolean equation with a golden variable that stores a 128 bit sum. I did the same with the 3 blif files and everything works fine.
I also developed a testbench of the adder_128_with_vector_output_verilog.v (The verilog file made by yosys based on the .blif file) and the result was the same the module develops well the sum.

What do you think is the problem?

This issues was solve in #880, Summary, icarous verilog has some flaws.


sequence flows lose conditions

On certain reasons the conditions on the sequence flows get deleted. Could be if you morph the target activity (Further investigation needed, but I have no time yet).
Could you please doublecheck?
Cheers, Ingo

To verify this:
Model an exclusive gateway
model an outgoing sequence flow to a new acivity
add a condition to the sequence flow: Expression ${approved}
morph the activity to a user task
check the condition again. It's empty now, but ${approved} should be preserved.
checked on version 1.0.0


chore(workspace): update Docker image with Chromium for M1 Macs

Problem
The Docker image we use for visual regression tests is (like most) an amd64 one. On M1-based machines (arm64), Docker Desktop will have to run it using the QEMU emulator, which seems to make Chrome crash.
PR description
The test script had been updated to use another image available in both amd64 and arm64 flavors (automatically selected by docker run). As there is no linux/arm64 version of Chrome available, the image also replaces the Desktop Chrome Playwright project with a Desktop Chromium one. Updated snapshots are also provided (identical in content but with a new filename).

The PR will be complete once I can push the image to the proper Docker repo, but should work as-is already.

the action-group png change is strange a bit

this is strange indeed.
if I checkout main and run the e2e tests against the current screenshot, everything is ok (as it should).
but if I delete the Chrome-Stable image and regenerate it, the new one actually looks like the picture from the PR...


Fix clearing packets on ordered channels

Closes: #2670
Description

PR author checklist:

[x] Added changelog entry, using unclog.
[x] Added tests: integration (for Hermes) or unit/mock tests (for modules).
[x] Linked to GitHub issue.
[x] Updated code comments and documentation (e.g., docs/).
[x] Tagged one reviewer who will be the one responsible for shepherding this PR.

Reviewer checklist:

[ ] Reviewed Files changed in the GitHub PR explorer.
[ ] Manually tested (in case integration/unit/mock tests are absent).

Integration tests are failing with a packet messages are redundant error, need to investigate further.

Just a note that I had tested this with a custom gaiad that emits begin and endblock events for some packets, in separate blocks (to simulate the #2670 scenario) and the events are all picked and correctly sorted.


allow build without gradle

To exclude gradle itself is moreover easy. But that removes groovy.  WDYT?

What's exactly the problem?

Hi!  The patches to build without gradle looks like this:
https://src.fedoraproject.org/rpms/forbidden-apis/blob/master/f/fix-gradle-maven-build.patch

https://src.fedoraproject.org/rpms/forbidden-apis/blob/master/f/forbidden-apis.spec#_72

I'm not sure what the groovy script is dooing, and whether forbidden apis are still doing what they should (I built it for gradle-less fedora just now).
If I drop gradle, I have to drop groovy.  Anyway, I was more thinking about build switch of no_gradle.
Thanx for promt reply!

Hi judovana (are you Jiri?),
no problem, thanks for the clarification. I was expecting that a linux distribution was behind this request :-)
I will carefully answer your question:

I'm not sure what the groovy script is dooing, and whether forbidden apis are still doing what they should (I built it for gradle-less fedora just now).

The Groovy script is not necessary to actually build everything from source. As you might have seen from the patch, it's part of a custom task. IMHO, in the patch, you should remove the generate-* tasks completely, because those depend on Groovy. But actually for a Linux distribution (I refer here to Debian, who are very paranoid with external stuff) it might still be good to make sure that the generate-* tasks are applied.
Why are the generate-tasks not needed? They are used to produce some of the signatures files (main ly the deprecated signatures). They are not hand-maintained, but generated from the JDK class library. As you need to run the code to generate them on all and every supported JDK (6, 7, 8, 9, 10, 11, 12, 13 - soon 14) that's a big hassle: https://github.com/policeman-tools/forbidden-apis/tree/master/src/main/resources/de/thetaphi/forbiddenapis/signatures; so they are one time generated after release of a new JDK and before a new release of forbiddenapis. Some of the files in the above folder have no license header, because they are autogenerated (jdk-deprecated-* and jdk-internal-*). From our checks and communication with the OpenJDK / Oracle guys, this is no problem, but if you are paranoid you would need to regenerate them. To regenerate, the ant tasks ant generate-deprecated and ant generate-internal are used as part of code maintenance. If you don't delete above files, you can remove groovy.

If I drop gradle, I have to drop groovy. Anyway, I was more thinking about build switch of no_gradle.

This should be unrelated to each other. You can remove gradle and leave groovy.
Now some general comments:

I figured out in the above patch, that you seem to patch the Gradle Task Java file, but the spec file deletes it afterwards (the whole gradle folder is removed from source). I was wondering what the removal/patching of the annotation helps, the whole file relies on Gradle. :-)
As noted before, I'd suggest to remove the generate-deprecated ANT task completely if you remove Groovy.
I don't like to make Gradle support to be compiled "configurable". The reason for this is backed by a general problem that most Java / Maven /Gradle plugin developers have with Linux distributions: Linux distributions mostly try to be self contained, they rebuild everything from source (instead of using Maven central). From my background with Apache Lucene, I know how horrible that is, because the build environments are just patched and the JAR files produced don't behave identical to the original ones, often be more buggy and lacking fetaures. People relying on them can never be sure that everything works as expected (it's like here: You don't know if everything works). With Lucene we had the problem that Debian rebuilds JavaCC files, but uses wrong JDK for that, which leads to different text analysis (because Unicode versions of newer JDKs change), breaking people's index. Another issue is also related to build tools: The default ANT as shipped with Fedora is unuseable to build e.g., Lucene, because it pollutes classpath with unrelated libraries (as does forbiddenapis after your patch). ASM is very problematic, e.g. if somebody installs forbiddenapis in the Fedora system, it may be installed in some ANT/Maven Lib folder and because ASM is not shaded/jarjared, it will break other tools.

 If we support different JAR file variants with reduced behaviour, how would somebody e.g. build Elasticsearch on his Fedora system when using the native forbiddenapis shipped with operating system? So please ship the JAR file in unmodified form and not stripped down functionality. You can build it from source, but please don't modify features. What's the problem with building the Gradle plugin correctly?
I hope the previous info helps to understand the position.

Hi judovana (are you Jiri?),

Yup!  Sorry for the confusion.

no problem, thanks for the clarification. I was expecting that a linux distribution was behind this request :-)
I will carefully answer your question:

I'm not sure what the groovy script is dooing, and whether forbidden apis are still doing what they should (I built it for gradle-less fedora just now).

The Groovy script is not necessary to actually build everything from source. As you might have seen from the patch, it's part of a custom task. IMHO, in the patch, you should remove the generate-* tasks completely, because those depend on Groovy. But actually for a Linux distribution (I refer here to Debian, who are very paranoid with external stuff) it might still be good to make sure that the generate-* tasks are applied.

I see. Groovy in fedora was depending on gradle, so it went out with it. So you are right, you do not need gradle for grovy in runtime, but you need it in build time. Once those are connected, yo suddenly needs gradle for groovy:(

Why are the generate-tasks not needed? They are used to produce some of the signatures files (main ly the deprecated signatures). They are not hand-maintained, but generated from the JDK class library. As you need to run the code to generate them on all and every supported JDK (6, 7, 8, 9, 10, 11, 12, 13 - soon 14) that's a big hassle: https://github.com/policeman-tools/forbidden-apis/tree/master/src/main/resources/de/thetaphi/forbiddenapis/signatures; so they are one time generated after release of a new JDK and before a new release of forbiddenapis. Some of the files in the above folder have no license header, because they are autogenerated (jdk-deprecated-* and jdk-internal-*). From our checks and communication with the OpenJDK / Oracle guys, this is no problem, but if you are paranoid, you would need to regenerate them (downloading and installing temporary each of the above JDKs). To regenerate, the ant tasks ant generate-deprecated and ant generate-internal are used as part of code maintenance. If you don't delete above signatures files, you can remove groovy.

Thanx a lot for explanation! That explains why I had hard times to find the connection. I will happily keep the pre-generated signature files.

The reason why it's written in Groovy is as its dynamically compiled. The script works with all JDK versions, where a compiled version would not even build with older JDKS, leading to an chicken-egg problem.

Sure.  I like groovy:)  And this is nice example of its usage.

If I drop gradle, I have to drop groovy. Anyway, I was more thinking about build switch of no_gradle.

This should be unrelated to each other. You can remove gradle and leave groovy.

Right, except the build chahin as told above:( But with the expalined usage.. no more needs to look ito it. Really thanx!

Now some general comments:
* I figured out in the above patch, that you seem to patch the Gradle Task Java file, but the spec file deletes it afterwards (the whole gradle folder is removed from source). I was wondering what the removal/patching of the annotation helps, the whole file relies on Gradle. :-)

Yah.  noticed it right after push in above shining diff.  I will remove it in next  iteration. At least it amde your day a bit more funnier :)

* As noted before, I'd suggest to remove the `generate-deprecated` ANT task completely if you remove Groovy.

Will keep it in mind.  A  bt more is now broken in fedora javastack (mostly exactly because of the reasons yu descibe lower)

* I don't like to make Gradle support to be compiled "configurable". The reason for this is backed by a general problem that most Java / Maven /Gradle plugin developers have with Linux distributions: Linux distributions mostly try to be self contained, they rebuild everything from source (instead of using Maven central). From my background with Apache Lucene, I know how horrible that is, because the build environments are just patched and the JAR files produced don't behave identical to the original ones, often be more buggy and lacking fetaures. People relying on them can never be sure that everything works as expected (it's like here: You don't know if everything works). With Lucene we had the problem that Debian rebuilds JavaCC files, but uses wrong JDK for that, which leads to different text analysis (because Unicode versions of newer JDKs change), breaking people's index. Another issue is also related to build tools: The default ANT as shipped with Fedora is unuseable to build e.g., Lucene, because it pollutes classpath with unrelated libraries (as does forbiddenapis after your patch). ASM is very problematic, e.g. if somebody installs forbiddenapis in the Fedora system, it may be installed in some ANT/Maven Lib folder and because ASM is not shaded/jarjared, it will break other tools.

 If we support different JAR file variants with reduced behaviour, how would somebody e.g. build Elasticsearch on his Fedora system when using the native forbiddenapis shipped with operating system? So please ship the JAR file in unmodified form and not stripped down functionality. You can build it from source, but please don't modify features. What's the problem with building the Gradle plugin correctly?

Fedora dropped gradle. That is all. But quite crucial :) So the idea is to build maven and ivy plugins, so fedora toolchain can continue.
But I understand your ponit of view. So definitely closing as upstream issue., as it remains downstream, even fedora, only. Thanx a lot for hints how to do it in better way.
Me as developer, relay on centrals. Me as linux user relyes on repositories. Those are hard decissions from time to time.

I hope the previous info helps to understand the position.

hank you very much! Your advices were direct and helpful.
J.


nestjs 10 update

Please update dependencies to support NestJS release 10

@kjetilhp check now :)

https://github.com/igrek8/gc-json-logger-nestjs/releases/tag/v1.5.0

Thank you!


Redbeesoftware - Verify if the location of the jobs are displayed

Description :  On production (https://peviitor.ro) all the jobs are displayed alongside their locations)
Precondition: The website is up and running

Step 1 : Open the URL (https://peviitor.ro)
Expected result : The homepage is displayed

Step 2 : Verify if the searching bar is functional by clicking inside it.
Expected result : The text can be typed inside the searching bar

Step 3 : Verify that under the jobs name the location is displayed(exemple : Cluj-Napoca)
Expected result : The job location is displayed under the job name


Add parent workflow information to WorkflowInfo

The structure returned workflow.GetInfo() should include parent workflow information.
Also we should make sure that any other relevant information (like previous runId) is also available.

https://github.com/uber-go/cadence-client/pull/655


v0.13.0

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 86.447%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
10237

Relevant Lines:
11842

💛  - Coveralls


Release v1.23.0

What would you like to be added:
k8s 1.23 was released on Dec 7th and still we don't have a cri-tools release for 1.23
Why is this needed:

I'd like to get the CI back before doing a release. Right now there seems to be two in flight:

https://github.com/kubernetes-sigs/cri-tools/pull/858
https://github.com/kubernetes-sigs/cri-tools/pull/853

We're not in a hurry since we would be still backwards compatible with Kubernetes. We also do not have CRI v1 support merged yet, so the changes between 1.22 and 1.23 seem marginal.

@feiskyer @mrunalp do we wanna switch to CRI v1 before releasing 1.23? This would be a breaking change.
Or do we wanna support both CRI versions in parallel? We could make it configurable, but it would increase the implementation effort.

With Kubernetes usual N / N-1 support style, shall critool 1.23 support both Kubernetes 1.23 / 1.22?
If yes, does OCI only supported by Kubernetes 1.22, or still required for legacy Docker format support?

The packages are still on 1.19, so I think crictl has a longer life span.
The homepage says that it supports anything from k8s 1.16.x and up

If you use cri-o, it sets up 1.21 to be used.
 cri-tools |   1.21.0~2 | http://download.opensuse.org/repositories/devel:/kubic:/libcontainers:/stable/xUbuntu_20.04  Packages

If you use containerd, you get 1.19 instead
 cri-tools |  1.19.0-00 | https://apt.kubernetes.io kubernetes-xenial/main amd64 Packages

Assuming that one wants to use modern packaging, like apt.
And not fall back to having to install odd things from tarballs.

For people who interested with latest up-to-date but non-official deb/rpm for Ubuntu/Debian/CentOS/RHEL/Fedora/openSUSE, I have a OBS repo for try: https://build.opensuse.org/project/show/home:alvistack

We are having big stability problems with OBS when it comes to installing cri-o, would be nice with something a bit more stable (and official!) for a tool that is now required by the default installer. Especially if multiple versions

We are having big stability problems with OBS when it comes to installing cri-o, would be nice with something a bit more stable (and official!) for a tool that is now required by the default installer. Especially if multiple versions*

Hopefully this is what you are looking for :-)

Hopefully this is what you are looking for :-)

Putting the version in the name ? Wow, that's wild.

Here are the current requirements:
Package: kubeadm
Version: 1.23.1-00
Priority: optional
Section: misc
Maintainer: Kubernetes Authors<EMAIL_ADDRESS>Installed-Size: 45.2 MB
Depends: kubelet (>= 1.19.0), kubectl (>= 1.19.0), kubernetes-cni (>= 0.8.7), cri-tools (>= 1.19.0)
Homepage: https://kubernetes.io
Download-Size: 8579 kB
APT-Manual-Installed: yes
APT-Sources: https://apt.kubernetes.io kubernetes-xenial/main amd64 Packages
Description: Kubernetes Cluster Bootstrapping Tool
The Kubernetes command line tool for bootstrapping a Kubernetes cluster.
N: There are 233 additional records. Please use the '-a' switch to see them.
When using standard Ubuntu 20.04 LTS.

@feiskyer @mrunalp do we wanna switch to CRI v1 before releasing 1.23? This would be a breaking change.

I think it's ok to cut the release without v1. It would need some time for runtimes to support and migrate to v1.

Or do we wanna support both CRI versions in parallel? We could make it configurable, but it would increase the implementation effort.

Could we do this in the next release (e.g. 1.24)? In this way, crictl version won't need to be coupled with kubernetes and runtime versions.

@feiskyer sounds good to me. :+1:

Release build is in progress: https://github.com/kubernetes-sigs/cri-tools/runs/4841568433

Done https://github.com/kubernetes-sigs/cri-tools/releases/tag/v1.23.0


Compatiblity with Java 11

Track blocking issue which prevent the switch to Java 11:

[ ] sundrio/sundrio#129 prevents to compile when running Maven with Java 11

Proposed PR for sundrio/sundrio#129 ->  sundrio/sundrio#131

#2319 moved to Java 11.


fpm: fix vulnerable dependency

Motivation for this change
Further to #22342, this fixes the vulnerable gem by applying the Debian patch.
fpm runs but I'm not really in a position to test it out as I don't have a use for it.
@offlinehacker and @Szczyp, do you want to try this out with your respective packages?
Things done

[X] Tested using sandboxing
(nix.useSandbox on NixOS,
or option build-use-sandbox in nix.conf
on non-NixOS)
Built on platform(s)

[X] NixOS
[ ] macOS
[ ] Linux

[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[X] Fits CONTRIBUTING.md.

I guess this should go to stable as well?


Extend Package

@nWidart is there a way to extend your package without messing with your code?
If for example I would like add some more methods to the Module Class how I can do that?
Is it possible for me to create a package that extends yours?
If it's possible can you provide a sample please?

Hello,
The Module class has the Macroable trait so you can add methods to it using that.
Example here: https://laravel.com/docs/5.8/collections#extending-collections

Thank you. This is what I needed.


update trust-dns-server

dependabot told us to
Signed-off-by: Brent Baude<EMAIL_ADDRESS>

LGTM, CI is flaky i have restarted test

/lgtm

/hold cancel
/lgtm

/hold cancel


[Bug] Dying in a shell when your your only other shell was destroyed (i.e. TNT, Creeper) causing a few issues

What happened?

You can still walk around and deal damage to entities/blocks. You cannot interact with XP and drops.
You must save and quit, then reload to be presented with the normal death screen.
There is a then ghost entry in the shell selection wheel that cannot be removed.

I recreated these issues in a few minute video here to demonstrate:
https://youtu.be/jafm4RoZnDA
Apologies for the quality.
Version
mc1.18-3.0
Minecraft Version
1.18.1
Fabric API Version
0.45.0+1.18
Installation Source
Modrinth
Logs
MultiMC version: 0.6.14-3001

Launched instance in online mode

authserver.mojang.com resolves to:
    [<IP_ADDRESS>]

session.minecraft.net resolves to:
    [<IP_ADDRESS>, <IP_ADDRESS>, <IP_ADDRESS>]

textures.minecraft.net resolves to:
    [<IP_ADDRESS>, <IP_ADDRESS>, <IP_ADDRESS>, <IP_ADDRESS>]

api.mojang.com resolves to:
    [<IP_ADDRESS>]

Minecraft folder is:
C:/Program Files/MultiMC/instances/SFVNWH 6.00 (Isolation)/.minecraft

Java path is:
C:/Program Files/Java/jdk-17.0.1/bin/javaw.exe

Checking Java version...
Java is version 17.0.1, using 64-bit architecture, from Oracle Corporation.

Main Class:
  net.fabricmc.loader.impl.launch.knot.KnotClient

Native path:
  C:/Program Files/MultiMC/instances/SFVNWH 6.00 (Isolation)/natives

Traits:
traits FirstThreadOnMacOS
traits XR:Initial

Libraries:
  C:/Program Files/MultiMC/libraries/org/lwjgl/lwjgl-glfw/3.2.2/lwjgl-glfw-3.2.2.jar
  C:/Program Files/MultiMC/libraries/org/lwjgl/lwjgl-jemalloc/3.2.2/lwjgl-jemalloc-3.2.2.jar
  C:/Program Files/MultiMC/libraries/org/lwjgl/lwjgl-openal/3.2.2/lwjgl-openal-3.2.2.jar
  C:/Program Files/MultiMC/libraries/org/lwjgl/lwjgl-opengl/3.2.2/lwjgl-opengl-3.2.2.jar
  C:/Program Files/MultiMC/libraries/org/lwjgl/lwjgl-stb/3.2.2/lwjgl-stb-3.2.2.jar
  C:/Program Files/MultiMC/libraries/org/lwjgl/lwjgl-tinyfd/3.2.2/lwjgl-tinyfd-3.2.2.jar
  C:/Program Files/MultiMC/libraries/org/lwjgl/lwjgl/3.2.2/lwjgl-3.2.2.jar
  C:/Program Files/MultiMC/libraries/com/mojang/blocklist/1.0.6/blocklist-1.0.6.jar
  C:/Program Files/MultiMC/libraries/com/mojang/patchy/2.1.6/patchy-2.1.6.jar
  C:/Program Files/MultiMC/libraries/com/github/oshi/oshi-core/5.8.2/oshi-core-5.8.2.jar
  C:/Program Files/MultiMC/libraries/net/java/dev/jna/jna/5.9.0/jna-5.9.0.jar
  C:/Program Files/MultiMC/libraries/net/java/dev/jna/jna-platform/5.9.0/jna-platform-5.9.0.jar
  C:/Program Files/MultiMC/libraries/org/slf4j/slf4j-api/1.8.0-beta4/slf4j-api-1.8.0-beta4.jar
  C:/Program Files/MultiMC/libraries/org/apache/logging/log4j/log4j-slf4j18-impl/2.16.0/log4j-slf4j18-impl-2.16.0.jar
  C:/Program Files/MultiMC/libraries/com/ibm/icu/icu4j/69.1/icu4j-69.1.jar
  C:/Program Files/MultiMC/libraries/com/mojang/javabridge/1.2.24/javabridge-1.2.24.jar
  C:/Program Files/MultiMC/libraries/net/sf/jopt-simple/jopt-simple/5.0.4/jopt-simple-5.0.4.jar
  C:/Program Files/MultiMC/libraries/io/netty/netty-all/4.1.68.Final/netty-all-4.1.68.Final.jar
  C:/Program Files/MultiMC/libraries/com/google/guava/failureaccess/1.0.1/failureaccess-1.0.1.jar
  C:/Program Files/MultiMC/libraries/com/google/guava/guava/31.0.1-jre/guava-31.0.1-jre.jar
  C:/Program Files/MultiMC/libraries/org/apache/commons/commons-lang3/3.12.0/commons-lang3-3.12.0.jar
  C:/Program Files/MultiMC/libraries/commons-io/commons-io/2.11.0/commons-io-2.11.0.jar
  C:/Program Files/MultiMC/libraries/commons-codec/commons-codec/1.15/commons-codec-1.15.jar
  C:/Program Files/MultiMC/libraries/com/mojang/brigadier/1.0.18/brigadier-1.0.18.jar
  C:/Program Files/MultiMC/libraries/com/mojang/datafixerupper/4.0.26/datafixerupper-4.0.26.jar
  C:/Program Files/MultiMC/libraries/com/google/code/gson/gson/2.8.8/gson-2.8.8.jar
  C:/Program Files/MultiMC/libraries/com/mojang/authlib/3.2.38/authlib-3.2.38.jar
  C:/Program Files/MultiMC/libraries/org/apache/commons/commons-compress/1.21/commons-compress-1.21.jar
  C:/Program Files/MultiMC/libraries/org/apache/httpcomponents/httpclient/4.5.13/httpclient-4.5.13.jar
  C:/Program Files/MultiMC/libraries/commons-logging/commons-logging/1.2/commons-logging-1.2.jar
  C:/Program Files/MultiMC/libraries/org/apache/httpcomponents/httpcore/4.4.14/httpcore-4.4.14.jar
  C:/Program Files/MultiMC/libraries/it/unimi/dsi/fastutil/8.5.6/fastutil-8.5.6.jar
  C:/Program Files/MultiMC/libraries/org/apache/logging/log4j/log4j-api/2.16.0/log4j-api-2.16.0.jar
  C:/Program Files/MultiMC/libraries/org/apache/logging/log4j/log4j-core/2.16.0/log4j-core-2.16.0.jar
  C:/Program Files/MultiMC/libraries/com/mojang/text2speech/1.11.3/text2speech-1.11.3.jar
  C:/Program Files/MultiMC/libraries/net/fabricmc/intermediary/1.18.1/intermediary-1.18.1.jar
  C:/Program Files/MultiMC/libraries/net/fabricmc/tiny-mappings-parser/0.3.0+build.17/tiny-mappings-parser-0.3.0+build.17.jar
  C:/Program Files/MultiMC/libraries/net/fabricmc/sponge-mixin/0.10.7+mixin.0.8.4/sponge-mixin-0.10.7+mixin.0.8.4.jar
  C:/Program Files/MultiMC/libraries/net/fabricmc/tiny-remapper/0.6.0/tiny-remapper-0.6.0.jar
  C:/Program Files/MultiMC/libraries/net/fabricmc/access-widener/2.0.1/access-widener-2.0.1.jar
  C:/Program Files/MultiMC/libraries/org/ow2/asm/asm/9.2/asm-9.2.jar
  C:/Program Files/MultiMC/libraries/org/ow2/asm/asm-analysis/9.2/asm-analysis-9.2.jar
  C:/Program Files/MultiMC/libraries/org/ow2/asm/asm-commons/9.2/asm-commons-9.2.jar
  C:/Program Files/MultiMC/libraries/org/ow2/asm/asm-tree/9.2/asm-tree-9.2.jar
  C:/Program Files/MultiMC/libraries/org/ow2/asm/asm-util/9.2/asm-util-9.2.jar
  C:/Program Files/MultiMC/libraries/net/fabricmc/fabric-loader/0.12.12/fabric-loader-0.12.12.jar
  C:/Program Files/MultiMC/libraries/com/mojang/minecraft/1.18.1/minecraft-1.18.1-client.jar

Native libraries:
  C:/Program Files/MultiMC/libraries/org/lwjgl/lwjgl-glfw/3.2.2/lwjgl-glfw-3.2.2-natives-windows.jar
  C:/Program Files/MultiMC/libraries/org/lwjgl/lwjgl-jemalloc/3.2.2/lwjgl-jemalloc-3.2.2-natives-windows.jar
  C:/Program Files/MultiMC/libraries/org/lwjgl/lwjgl-openal/3.2.2/lwjgl-openal-3.2.2-natives-windows.jar
  C:/Program Files/MultiMC/libraries/org/lwjgl/lwjgl-opengl/3.2.2/lwjgl-opengl-3.2.2-natives-windows.jar
  C:/Program Files/MultiMC/libraries/org/lwjgl/lwjgl-stb/3.2.2/lwjgl-stb-3.2.2-natives-windows.jar
  C:/Program Files/MultiMC/libraries/org/lwjgl/lwjgl-tinyfd/3.2.2/lwjgl-tinyfd-3.2.2-natives-windows.jar
  C:/Program Files/MultiMC/libraries/org/lwjgl/lwjgl/3.2.2/lwjgl-3.2.2-natives-windows.jar
  C:/Program Files/MultiMC/libraries/com/mojang/text2speech/1.11.3/text2speech-1.11.3-natives-windows.jar

Mods:
  [✔] fabric-api-0.45.0+1.18
  [✔] sync-mc1.18-3.0

Params:
  --username  --version MultiMC5 --gameDir C:/Program Files/MultiMC/instances/SFVNWH 6.00 (Isolation)/.minecraft --assetsDir C:/Program Files/MultiMC/assets --assetIndex 1.18 --uuid  --accessToken  --userType  --versionType release

Window size: 854 x 480

Java Arguments:
[-XX:HeapDumpPath=MojangTricksIntelDriversForPerformance_javaw.exe_minecraft.exe.heapdump, -Xms4096m, -Xmx8192m, -Duser.language=en]

Minecraft process ID: 13548

Using onesix launcher.

[23:20:45] [main/INFO]: Loading Minecraft 1.18.1 with Fabric Loader 0.12.12
[23:20:46] [ForkJoinPool-1-worker-3/WARN]: The mod "sync" contains invalid entries in its mod json:
- Unsupported root entry "includes" at line 49 column 13
[23:20:46] [main/INFO]: Loading 54 mods:
	- cloth-basic-math 0.6.0 via cloth-config
	- cloth-config 6.1.48 via sync
	- crowdin-translate 1.4+1.18 via sync
	- fabric 0.45.0+1.18
	- fabric-api-base 0.4.1+b4f4f6cd65 via fabric
	- fabric-api-lookup-api-v1 1.5.0+17be577f65 via fabric
	- fabric-biome-api-v1 6.0.1+ded849a965 via fabric
	- fabric-blockrenderlayer-v1 1.1.9+3ac43d9565 via fabric
	- fabric-command-api-v1 1.1.6+3ac43d9565 via fabric
	- fabric-commands-v0 0.2.5+b4f4f6cd65 via fabric
	- fabric-containers-v0 0.1.18+d154e2c665 via fabric
	- fabric-content-registries-v0 0.4.5+6f53a73d65 via fabric
	- fabric-crash-report-info-v1 0.1.8+3ac43d9565 via fabric
	- fabric-dimensions-v1 2.1.7+43d2957165 via fabric
	- fabric-entity-events-v1 1.4.5+6b21378a65 via fabric
	- fabric-events-interaction-v0 0.4.16+bfa23f1765 via fabric
	- fabric-events-lifecycle-v0 0.2.6+b4f4f6cd65 via fabric
	- fabric-game-rule-api-v1 1.0.10+3ac43d9565 via fabric
	- fabric-item-api-v1 1.3.0+691a79b565 via fabric
	- fabric-item-groups-v0 0.3.3+3ac43d9565 via fabric
	- fabric-key-binding-api-v1 1.0.8+c8aba2f365 via fabric
	- fabric-keybindings-v0 0.2.6+b4f4f6cd65 via fabric
	- fabric-lifecycle-events-v1 1.4.10+c15ca33565 via fabric
	- fabric-loot-tables-v1 1.0.8+3ac43d9565 via fabric
	- fabric-mining-level-api-v1 1.0.3+3ac43d9565 via fabric
	- fabric-mining-levels-v0 0.1.7+b4f4f6cd65 via fabric
	- fabric-models-v0 0.3.3+3ac43d9565 via fabric
	- fabric-networking-api-v1 1.0.18+3ac43d9565 via fabric
	- fabric-networking-v0 0.3.5+b4f4f6cd65 via fabric
	- fabric-object-builder-api-v1 1.11.0+3b82842e65 via fabric
	- fabric-object-builders-v0 0.7.8+3ac43d9565 via fabric
	- fabric-particles-v1 0.2.9+526dc1ac65 via fabric
	- fabric-registry-sync-v0 0.8.6+533be9ba65 via fabric
	- fabric-renderer-api-v1 0.4.9+3ac43d9565 via fabric
	- fabric-renderer-indigo 0.4.12+3ac43d9565 via fabric
	- fabric-renderer-registries-v1 3.2.7+b4f4f6cd65 via fabric
	- fabric-rendering-data-attachment-v1 0.3.4+7242e9d765 via fabric
	- fabric-rendering-fluids-v1 0.1.18+3ac43d9565 via fabric
	- fabric-rendering-v0 1.1.9+b4f4f6cd65 via fabric
	- fabric-rendering-v1 1.10.3+6b21378a65 via fabric
	- fabric-resource-loader-v0 0.4.11+3ac43d9565 via fabric
	- fabric-screen-api-v1 1.0.7+3ac43d9565 via fabric
	- fabric-screen-handler-api-v1 1.1.11+3ac43d9565 via fabric
	- fabric-structure-api-v1 2.0.8+295197a765 via fabric
	- fabric-tag-extensions-v0 1.2.5+3ac43d9565 via fabric
	- fabric-textures-v0 1.0.9+3ac43d9565 via fabric
	- fabric-tool-attribute-api-v1 1.3.4+7de09f5565 via fabric
	- fabric-transfer-api-v1 1.5.6+b4f4f6cd65 via fabric
	- fabricloader 0.12.12
	- java 17
	- minecraft 1.18.1
	- smart-recipes 0.2.0+1.18 via sync
	- sync 3.0
	- team_reborn_energy 2.0.0-beta1 via sync
[23:20:46] [main/INFO]: SpongePowered MIXIN Subsystem Version=0.8.4 Source=file:/C:/Program%20Files/MultiMC/libraries/net/fabricmc/sponge-mixin/0.10.7+mixin.0.8.4/sponge-mixin-0.10.7+mixin.0.8.4.jar Service=Knot/Fabric Env=CLIENT
[23:20:46] [main/INFO]: Compatibility level set to JAVA_16
[23:20:46] [main/INFO]: Compatibility level set to JAVA_17
[23:20:48] [main/WARN]: @Inject(@At("INVOKE")) Shift.BY=3 on fabric-lifecycle-events-v1.mixins.json:client.WorldChunkMixin::handler$zdg000$onLoadBlockEntity exceeds the maximum allowed value: 0. Increase the value of maxShiftBy to suppress this warning.
[23:20:49] [Render thread/INFO]: Environment: authHost='https://authserver.mojang.com', accountsHost='https://api.mojang.com', sessionHost='https://sessionserver.mojang.com', servicesHost='https://api.minecraftservices.com', name='PROD'
[23:20:50] [Render thread/INFO]: Setting user: thatguyel0c
[23:20:50] [Render thread/INFO]: [Indigo] Registering Indigo renderer!
[23:20:50] [Render thread/INFO]: Backend library: LWJGL version 3.2.2 build 10
[23:20:53] [Render thread/INFO]: Narrator library for x64 successfully loaded
[23:20:53] [Render thread/INFO]: Reloading ResourceManager: Default, Fabric Mods (Cloth Config v6, Fabric API, Fabric API Base, Fabric API Lookup API (v1), Fabric Biome API (v1), Fabric BlockRenderLayer Registration (v1), Fabric Command API (v1), Fabric Commands (v0), Fabric Containers (v0), Fabric Content Registries (v0), Fabric Crash Report Info (v1), Fabric Dimensions API (v1), Fabric Entity Events (v1), Fabric Events Interaction (v0), Fabric Events Lifecycle (v0), Fabric Game Rule API (v1), Fabric Item API (v1), Fabric Item Groups (v0), Fabric Key Binding API (v1), Fabric Key Bindings (v0), Fabric Lifecycle Events (v1), Fabric Loot Tables (v1), Fabric Mining Level API (v1), Fabric Mining Levels (v0), Fabric Models (v0), Fabric Networking API (v1), Fabric Networking (v0), Fabric Object Builder API (v1), Fabric Object Builders (v0), Fabric Particles (v1), Fabric Registry Sync (v0), Fabric Renderer API (v1), Fabric Renderer - Indigo, Fabric Renderer Registries (v1), Fabric Rendering Data Attachment (v1), Fabric Rendering Fluids (v1), Fabric Rendering (v0), Fabric Rendering (v1), Fabric Resource Loader (v0), Fabric Screen API (v1), Fabric Screen Handler API (v1), Fabric Structure API (v1), Fabric Tag Extensions (v0), Fabric Textures (v0), Fabric Tool Attribute API (v1), Fabric Transfer API (v1), Fabric Loader, Smart Recipes, Sync (Fabric), Energy)
[23:20:53] [Render thread/INFO]: [STDOUT]: Inject generated resource packs.
[23:20:55] [Render thread/INFO]: OpenAL initialized on device OpenAL Soft on Headphones (HyperX Cloud Flight S Game)
[23:20:55] [Render thread/INFO]: Sound engine started
[23:20:55] [Render thread/INFO]: Created: 1024x1024x4 minecraft:textures/atlas/blocks.png-atlas
[23:20:55] [Render thread/INFO]: Created: 256x128x4 minecraft:textures/atlas/signs.png-atlas
[23:20:55] [Render thread/INFO]: Created: 1024x512x4 minecraft:textures/atlas/banner_patterns.png-atlas
[23:20:55] [Render thread/INFO]: Created: 1024x512x4 minecraft:textures/atlas/shield_patterns.png-atlas
[23:20:55] [Render thread/INFO]: Created: 256x256x4 minecraft:textures/atlas/chest.png-atlas
[23:20:55] [Render thread/INFO]: Created: 512x256x4 minecraft:textures/atlas/beds.png-atlas
[23:20:55] [Render thread/INFO]: Created: 512x256x4 minecraft:textures/atlas/shulker_boxes.png-atlas
[23:20:56] [Render thread/INFO]: Created: 256x256x0 minecraft:textures/atlas/particles.png-atlas
[23:20:56] [Render thread/INFO]: Created: 256x256x0 minecraft:textures/atlas/paintings.png-atlas
[23:20:56] [Render thread/INFO]: Created: 256x128x0 minecraft:textures/atlas/mob_effects.png-atlas
[23:21:41] [Render thread/WARN]: Ambiguity between arguments [teleport, location] and [teleport, destination] with inputs: [0.1 -0.5 .9, 0 0 0]
[23:21:41] [Render thread/WARN]: Ambiguity between arguments [teleport, location] and [teleport, targets] with inputs: [0.1 -0.5 .9, 0 0 0]
[23:21:41] [Render thread/WARN]: Ambiguity between arguments [teleport, destination] and [teleport, targets] with inputs: [Player, 0123, @e, dd12be42-52a9-4a91-a8a1-11c01849e498]
[23:21:41] [Render thread/WARN]: Ambiguity between arguments [teleport, targets] and [teleport, destination] with inputs: [Player, 0123, dd12be42-52a9-4a91-a8a1-11c01849e498]
[23:21:41] [Render thread/WARN]: Ambiguity between arguments [teleport, targets, location] and [teleport, targets, destination] with inputs: [0.1 -0.5 .9, 0 0 0]
[23:21:41] [Render thread/INFO]: Reloading ResourceManager: Default, Fabric Mods (Fabric Tool Attribute API (v1), Sync (Fabric))
[23:21:41] [Render thread/INFO]: Skipped 0 recipes
[23:21:41] [Render thread/INFO]: Loaded 7 recipes
[23:21:41] [Render thread/INFO]: Loaded 1141 advancements
[23:21:41] [Render thread/INFO]: Applied 0 biome modifications to 0 of 61 new biomes in 1.348 ms
[23:21:42] [Render thread/INFO]: Environment: authHost='https://authserver.mojang.com', accountsHost='https://api.mojang.com', sessionHost='https://sessionserver.mojang.com', servicesHost='https://api.minecraftservices.com', name='PROD'
[23:21:42] [Server thread/INFO]: Starting integrated minecraft server version 1.18.1
[23:21:42] [Server thread/INFO]: Generating keypair
[23:21:42] [Server thread/INFO]: Preparing start region for dimension minecraft:overworld
[23:21:43] [Render thread/INFO]: Preparing spawn area: 0%
[23:21:43] [Render thread/INFO]: Preparing spawn area: 0%
[23:21:43] [Render thread/INFO]: Preparing spawn area: 5%
[23:21:44] [Render thread/INFO]: Preparing spawn area: 18%
[23:21:44] [Render thread/INFO]: Preparing spawn area: 31%
[23:21:45] [Render thread/INFO]: Preparing spawn area: 44%
[23:21:45] [Render thread/INFO]: Preparing spawn area: 57%
[23:21:46] [Render thread/INFO]: Preparing spawn area: 72%
[23:21:46] [Render thread/INFO]: Preparing spawn area: 88%
[23:21:47] [Render thread/INFO]: Time elapsed: 4406 ms
[23:21:47] [Server thread/INFO]: Reloaded 1 recipes (removed: 1 | added: 0) on the 'minecraft:end_data_pack_reload' event
[23:21:47] [Server thread/INFO]: Changing view distance to 12, from 10
[23:21:47] [Server thread/INFO]: Changing simulation distance to 12, from 0
[23:21:47] [Server thread/INFO]: thatguyel0c[local:E:662ce85b] logged in with entity id 1 at (8.5, -60.0, 5.5)
[23:21:47] [Server thread/INFO]: thatguyel0c joined the game
[23:21:48] [Render thread/INFO]: Loaded 0 advancements
[23:22:09] [Render thread/INFO]: Loaded 4 advancements
[23:22:10] [Render thread/INFO]: Loaded 9 advancements
[23:22:50] [Server thread/INFO]: Saving and pausing game...
[23:22:50] [Server thread/INFO]: Saving chunks for level 'ServerLevel[Sync Bug Demo]'/minecraft:overworld
[23:22:50] [Server thread/INFO]: Saving chunks for level 'ServerLevel[Sync Bug Demo]'/minecraft:the_nether
[23:22:50] [Server thread/INFO]: Saving chunks for level 'ServerLevel[Sync Bug Demo]'/minecraft:the_end
[23:22:51] [Server thread/INFO]: thatguyel0c lost connection: Disconnected
[23:22:51] [Server thread/INFO]: thatguyel0c left the game
[23:22:51] [Server thread/INFO]: Stopping singleplayer server as player logged out
[23:22:51] [Server thread/INFO]: Stopping server
[23:22:51] [Server thread/INFO]: Saving players
[23:22:51] [Server thread/INFO]: Saving worlds
[23:22:51] [Server thread/INFO]: Saving chunks for level 'ServerLevel[Sync Bug Demo]'/minecraft:overworld
[23:22:52] [Server thread/INFO]: Saving chunks for level 'ServerLevel[Sync Bug Demo]'/minecraft:the_nether
[23:22:52] [Server thread/INFO]: Saving chunks for level 'ServerLevel[Sync Bug Demo]'/minecraft:the_end
[23:22:52] [Server thread/INFO]: ThreadedAnvilChunkStorage (Sync Bug Demo): All chunks are saved
[23:22:52] [Server thread/INFO]: ThreadedAnvilChunkStorage (DIM-1): All chunks are saved
[23:22:52] [Server thread/INFO]: ThreadedAnvilChunkStorage (DIM1): All chunks are saved
[23:22:52] [Server thread/INFO]: ThreadedAnvilChunkStorage: All dimensions are saved
[23:22:55] [Render thread/WARN]: Ambiguity between arguments [teleport, location] and [teleport, destination] with inputs: [0.1 -0.5 .9, 0 0 0]
[23:22:55] [Render thread/WARN]: Ambiguity between arguments [teleport, location] and [teleport, targets] with inputs: [0.1 -0.5 .9, 0 0 0]
[23:22:55] [Render thread/WARN]: Ambiguity between arguments [teleport, destination] and [teleport, targets] with inputs: [Player, 0123, @e, dd12be42-52a9-4a91-a8a1-11c01849e498]
[23:22:55] [Render thread/WARN]: Ambiguity between arguments [teleport, targets] and [teleport, destination] with inputs: [Player, 0123, dd12be42-52a9-4a91-a8a1-11c01849e498]
[23:22:55] [Render thread/WARN]: Ambiguity between arguments [teleport, targets, location] and [teleport, targets, destination] with inputs: [0.1 -0.5 .9, 0 0 0]
[23:22:55] [Render thread/INFO]: Reloading ResourceManager: Default, Fabric Mods (Fabric Tool Attribute API (v1), Sync (Fabric))
[23:22:55] [Render thread/INFO]: Skipped 0 recipes
[23:22:55] [Render thread/INFO]: Loaded 7 recipes
[23:22:55] [Render thread/INFO]: Loaded 1141 advancements
[23:22:55] [Render thread/INFO]: Applied 0 biome modifications to 0 of 61 new biomes in 149.9 ?s
[23:22:59] [Render thread/WARN]: Ambiguity between arguments [teleport, location] and [teleport, destination] with inputs: [0.1 -0.5 .9, 0 0 0]
[23:22:59] [Render thread/WARN]: Ambiguity between arguments [teleport, location] and [teleport, targets] with inputs: [0.1 -0.5 .9, 0 0 0]
[23:22:59] [Render thread/WARN]: Ambiguity between arguments [teleport, destination] and [teleport, targets] with inputs: [Player, 0123, @e, dd12be42-52a9-4a91-a8a1-11c01849e498]
[23:22:59] [Render thread/WARN]: Ambiguity between arguments [teleport, targets] and [teleport, destination] with inputs: [Player, 0123, dd12be42-52a9-4a91-a8a1-11c01849e498]
[23:22:59] [Render thread/WARN]: Ambiguity between arguments [teleport, targets, location] and [teleport, targets, destination] with inputs: [0.1 -0.5 .9, 0 0 0]
[23:22:59] [Render thread/INFO]: Reloading ResourceManager: Default, Fabric Mods (Fabric Tool Attribute API (v1), Sync (Fabric))
[23:22:59] [Render thread/INFO]: Skipped 0 recipes
[23:22:59] [Render thread/INFO]: Loaded 7 recipes
[23:22:59] [Render thread/INFO]: Loaded 1141 advancements
[23:22:59] [Render thread/INFO]: Environment: authHost='https://authserver.mojang.com', accountsHost='https://api.mojang.com', sessionHost='https://sessionserver.mojang.com', servicesHost='https://api.minecraftservices.com', name='PROD'
[23:22:59] [Server thread/INFO]: Starting integrated minecraft server version 1.18.1
[23:22:59] [Server thread/INFO]: Generating keypair
[23:22:59] [Server thread/INFO]: Preparing start region for dimension minecraft:overworld
[23:22:59] [Render thread/INFO]: Preparing spawn area: 0%
[23:23:00] [Render thread/INFO]: Preparing spawn area: 4%
[23:23:01] [Render thread/INFO]: Preparing spawn area: 12%
[23:23:01] [Render thread/INFO]: Preparing spawn area: 12%
[23:23:01] [Render thread/INFO]: Preparing spawn area: 65%
[23:23:02] [Render thread/INFO]: Preparing spawn area: 75%
[23:23:02] [Server thread/INFO]: Reloaded 1 recipes (removed: 1 | added: 0) on the 'minecraft:end_data_pack_reload' event
[23:23:02] [Server thread/INFO]: Changing view distance to 12, from 10
[23:23:02] [Server thread/INFO]: Changing simulation distance to 12, from 0
[23:23:02] [Render thread/INFO]: Time elapsed: 2975 ms
[23:23:02] [Server thread/INFO]: thatguyel0c[local:E:38678d07] logged in with entity id 10 at (-6.5, -60.0, -4.5)
[23:23:02] [Server thread/INFO]: thatguyel0c joined the game
[23:23:02] [Render thread/INFO]: Loaded 0 advancements
[23:23:21] [Render thread/INFO]: Loaded 4 advancements
[23:23:22] [Render thread/INFO]: Loaded 9 advancements
[23:24:21] [Server thread/INFO]: Saving and pausing game...
[23:24:21] [Server thread/INFO]: Saving chunks for level 'ServerLevel[Sync Bug Demo 1]'/minecraft:overworld
[23:24:21] [Server thread/INFO]: Saving chunks for level 'ServerLevel[Sync Bug Demo 1]'/minecraft:the_nether
[23:24:21] [Server thread/INFO]: Saving chunks for level 'ServerLevel[Sync Bug Demo 1]'/minecraft:the_end
[23:24:22] [Server thread/INFO]: thatguyel0c lost connection: Disconnected
[23:24:22] [Server thread/INFO]: thatguyel0c left the game
[23:24:22] [Server thread/INFO]: Stopping singleplayer server as player logged out
[23:24:22] [Server thread/INFO]: Stopping server
[23:24:22] [Server thread/INFO]: Saving players
[23:24:22] [Server thread/INFO]: Saving worlds
[23:24:22] [Server thread/INFO]: Saving chunks for level 'ServerLevel[Sync Bug Demo 1]'/minecraft:overworld
[23:24:23] [Server thread/INFO]: Saving chunks for level 'ServerLevel[Sync Bug Demo 1]'/minecraft:the_nether
[23:24:23] [Server thread/INFO]: Saving chunks for level 'ServerLevel[Sync Bug Demo 1]'/minecraft:the_end
[23:24:23] [Server thread/INFO]: ThreadedAnvilChunkStorage (Sync Bug Demo 1): All chunks are saved
[23:24:23] [Server thread/INFO]: ThreadedAnvilChunkStorage (DIM-1): All chunks are saved
[23:24:23] [Server thread/INFO]: ThreadedAnvilChunkStorage (DIM1): All chunks are saved
[23:24:23] [Server thread/INFO]: ThreadedAnvilChunkStorage: All dimensions are saved
[23:24:26] [Render thread/INFO]: Attempt 1...
[23:24:28] [Render thread/WARN]: Ambiguity between arguments [teleport, location] and [teleport, destination] with inputs: [0.1 -0.5 .9, 0 0 0]
[23:24:28] [Render thread/WARN]: Ambiguity between arguments [teleport, location] and [teleport, targets] with inputs: [0.1 -0.5 .9, 0 0 0]
[23:24:28] [Render thread/WARN]: Ambiguity between arguments [teleport, destination] and [teleport, targets] with inputs: [Player, 0123, @e, dd12be42-52a9-4a91-a8a1-11c01849e498]
[23:24:28] [Render thread/WARN]: Ambiguity between arguments [teleport, targets] and [teleport, destination] with inputs: [Player, 0123, dd12be42-52a9-4a91-a8a1-11c01849e498]
[23:24:28] [Render thread/WARN]: Ambiguity between arguments [teleport, targets, location] and [teleport, targets, destination] with inputs: [0.1 -0.5 .9, 0 0 0]
[23:24:28] [Render thread/INFO]: Reloading ResourceManager: Default, Fabric Mods (Fabric Tool Attribute API (v1), Sync (Fabric))
[23:24:28] [Render thread/INFO]: Skipped 0 recipes
[23:24:28] [Render thread/INFO]: Loaded 7 recipes
[23:24:29] [Render thread/INFO]: Loaded 1141 advancements
[23:24:29] [Render thread/INFO]: Applied 0 biome modifications to 0 of 61 new biomes in 124.8 ?s
[23:24:33] [Render thread/WARN]: Ambiguity between arguments [teleport, location] and [teleport, destination] with inputs: [0.1 -0.5 .9, 0 0 0]
[23:24:33] [Render thread/WARN]: Ambiguity between arguments [teleport, location] and [teleport, targets] with inputs: [0.1 -0.5 .9, 0 0 0]
[23:24:33] [Render thread/WARN]: Ambiguity between arguments [teleport, destination] and [teleport, targets] with inputs: [Player, 0123, @e, dd12be42-52a9-4a91-a8a1-11c01849e498]
[23:24:33] [Render thread/WARN]: Ambiguity between arguments [teleport, targets] and [teleport, destination] with inputs: [Player, 0123, dd12be42-52a9-4a91-a8a1-11c01849e498]
[23:24:33] [Render thread/WARN]: Ambiguity between arguments [teleport, targets, location] and [teleport, targets, destination] with inputs: [0.1 -0.5 .9, 0 0 0]
[23:24:33] [Render thread/INFO]: Reloading ResourceManager: Default, Fabric Mods (Fabric Tool Attribute API (v1), Sync (Fabric))
[23:24:33] [Render thread/INFO]: Skipped 0 recipes
[23:24:33] [Render thread/INFO]: Loaded 7 recipes
[23:24:34] [Render thread/INFO]: Loaded 1141 advancements
[23:24:34] [Render thread/INFO]: Environment: authHost='https://authserver.mojang.com', accountsHost='https://api.mojang.com', sessionHost='https://sessionserver.mojang.com', servicesHost='https://api.minecraftservices.com', name='PROD'
[23:24:34] [Server thread/INFO]: Starting integrated minecraft server version 1.18.1
[23:24:34] [Server thread/INFO]: Generating keypair
[23:24:34] [Server thread/INFO]: Preparing start region for dimension minecraft:overworld
[23:24:34] [Render thread/INFO]: Preparing spawn area: 0%
[23:24:34] [Render thread/INFO]: Preparing spawn area: 5%
[23:24:35] [Render thread/INFO]: Preparing spawn area: 20%
[23:24:36] [Render thread/INFO]: Preparing spawn area: 33%
[23:24:36] [Render thread/INFO]: Preparing spawn area: 47%
[23:24:37] [Render thread/INFO]: Preparing spawn area: 60%
[23:24:37] [Render thread/INFO]: Preparing spawn area: 69%
[23:24:37] [Render thread/INFO]: Preparing spawn area: 96%
[23:24:38] [Server thread/INFO]: Reloaded 1 recipes (removed: 1 | added: 0) on the 'minecraft:end_data_pack_reload' event
[23:24:38] [Server thread/INFO]: Changing view distance to 12, from 10
[23:24:38] [Server thread/INFO]: Changing simulation distance to 12, from 0
[23:24:38] [Render thread/INFO]: Time elapsed: 3601 ms
[23:24:38] [Server thread/INFO]: thatguyel0c[local:E:6bfcef83] logged in with entity id 43 at (3.5, -60.0, 10.5)
[23:24:38] [Server thread/INFO]: thatguyel0c joined the game
[23:24:38] [Render thread/INFO]: Loaded 0 advancements
[23:24:47] [Render thread/INFO]: Loaded 4 advancements
[23:24:48] [Render thread/INFO]: Loaded 9 advancements
[23:25:48] [Server thread/INFO]: thatguyel0c fell out of the world
[23:25:48] [Server thread/INFO]: [thatguyel0c: Killed thatguyel0c]
[23:25:48] [Render thread/INFO]: [CHAT] thatguyel0c fell out of the world
[23:25:48] [Render thread/INFO]: [CHAT] Killed thatguyel0c
[23:25:52] [Render thread/INFO]: [CHAT] The selected shell cannot be found
[23:25:59] [Server thread/INFO]: Saving and pausing game...
[23:25:59] [Server thread/INFO]: Saving chunks for level 'ServerLevel[Sync Bug Demo]'/minecraft:overworld
[23:25:59] [Server thread/INFO]: Saving chunks for level 'ServerLevel[Sync Bug Demo]'/minecraft:the_nether
[23:25:59] [Server thread/INFO]: Saving chunks for level 'ServerLevel[Sync Bug Demo]'/minecraft:the_end
[23:25:59] [Server thread/INFO]: thatguyel0c lost connection: Disconnected
[23:25:59] [Server thread/INFO]: thatguyel0c left the game
[23:25:59] [Server thread/INFO]: Stopping singleplayer server as player logged out
[23:25:59] [Server thread/INFO]: Stopping server
[23:25:59] [Server thread/INFO]: Saving players
[23:25:59] [Server thread/INFO]: Saving worlds
[23:25:59] [Server thread/INFO]: Saving chunks for level 'ServerLevel[Sync Bug Demo]'/minecraft:overworld
[23:26:00] [Server thread/INFO]: Saving chunks for level 'ServerLevel[Sync Bug Demo]'/minecraft:the_nether
[23:26:00] [Server thread/INFO]: Saving chunks for level 'ServerLevel[Sync Bug Demo]'/minecraft:the_end
[23:26:00] [Server thread/INFO]: ThreadedAnvilChunkStorage (Sync Bug Demo (1)): All chunks are saved
[23:26:00] [Server thread/INFO]: ThreadedAnvilChunkStorage (DIM-1): All chunks are saved
[23:26:00] [Server thread/INFO]: ThreadedAnvilChunkStorage (DIM1): All chunks are saved
[23:26:00] [Server thread/INFO]: ThreadedAnvilChunkStorage: All dimensions are saved
[23:26:03] [Render thread/WARN]: Ambiguity between arguments [teleport, location] and [teleport, destination] with inputs: [0.1 -0.5 .9, 0 0 0]
[23:26:03] [Render thread/WARN]: Ambiguity between arguments [teleport, location] and [teleport, targets] with inputs: [0.1 -0.5 .9, 0 0 0]
[23:26:03] [Render thread/WARN]: Ambiguity between arguments [teleport, destination] and [teleport, targets] with inputs: [Player, 0123, @e, dd12be42-52a9-4a91-a8a1-11c01849e498]
[23:26:03] [Render thread/WARN]: Ambiguity between arguments [teleport, targets] and [teleport, destination] with inputs: [Player, 0123, dd12be42-52a9-4a91-a8a1-11c01849e498]
[23:26:03] [Render thread/WARN]: Ambiguity between arguments [teleport, targets, location] and [teleport, targets, destination] with inputs: [0.1 -0.5 .9, 0 0 0]
[23:26:03] [Render thread/INFO]: Reloading ResourceManager: Default, Fabric Mods (Fabric Tool Attribute API (v1), Sync (Fabric))
[23:26:03] [Render thread/INFO]: Skipped 0 recipes
[23:26:03] [Render thread/INFO]: Loaded 7 recipes
[23:26:03] [Render thread/INFO]: Loaded 1141 advancements
[23:26:03] [Render thread/INFO]: Applied 0 biome modifications to 0 of 61 new biomes in 117.8 ?s
[23:26:03] [Render thread/INFO]: Environment: authHost='https://authserver.mojang.com', accountsHost='https://api.mojang.com', sessionHost='https://sessionserver.mojang.com', servicesHost='https://api.minecraftservices.com', name='PROD'
[23:26:03] [Server thread/INFO]: Starting integrated minecraft server version 1.18.1
[23:26:03] [Server thread/INFO]: Generating keypair
[23:26:03] [Server thread/INFO]: Preparing start region for dimension minecraft:overworld
[23:26:03] [Render thread/INFO]: Preparing spawn area: 0%
[23:26:04] [Render thread/INFO]: Preparing spawn area: 1%
[23:26:04] [Render thread/INFO]: Preparing spawn area: 84%
[23:26:04] [Server thread/INFO]: Reloaded 1 recipes (removed: 1 | added: 0) on the 'minecraft:end_data_pack_reload' event
[23:26:04] [Render thread/INFO]: Time elapsed: 1072 ms
[23:26:04] [Server thread/INFO]: Changing view distance to 12, from 10
[23:26:04] [Server thread/INFO]: Changing simulation distance to 12, from 0
[23:26:04] [Server thread/INFO]: thatguyel0c[local:E:198f3b21] logged in with entity id 84 at (3.79206985931899, -60.0, 5.984118207131491)
[23:26:04] [Server thread/INFO]: thatguyel0c joined the game
[23:26:04] [Render thread/INFO]: Loaded 9 advancements
[23:26:37] [Render thread/INFO]: [CHAT] The selected shell cannot be found
[23:27:06] [Server thread/INFO]: thatguyel0c fell out of the world
[23:27:06] [Server thread/INFO]: [thatguyel0c: Killed thatguyel0c]
[23:27:06] [Render thread/INFO]: [CHAT] thatguyel0c fell out of the world
[23:27:06] [Render thread/INFO]: [CHAT] Killed thatguyel0c
[23:27:18] [Server thread/INFO]: Saving and pausing game...
[23:27:18] [Server thread/INFO]: Saving chunks for level 'ServerLevel[Sync Bug Demo]'/minecraft:overworld
[23:27:18] [Server thread/INFO]: Saving chunks for level 'ServerLevel[Sync Bug Demo]'/minecraft:the_nether
[23:27:18] [Server thread/INFO]: Saving chunks for level 'ServerLevel[Sync Bug Demo]'/minecraft:the_end
[23:27:19] [Server thread/INFO]: thatguyel0c lost connection: Disconnected
[23:27:19] [Server thread/INFO]: thatguyel0c left the game
[23:27:19] [Server thread/INFO]: Stopping singleplayer server as player logged out
[23:27:19] [Server thread/INFO]: Stopping server
[23:27:19] [Server thread/INFO]: Saving players
[23:27:19] [Server thread/INFO]: Saving worlds
[23:27:19] [Server thread/INFO]: Saving chunks for level 'ServerLevel[Sync Bug Demo]'/minecraft:overworld
[23:27:19] [Server thread/INFO]: Saving chunks for level 'ServerLevel[Sync Bug Demo]'/minecraft:the_nether
[23:27:19] [Server thread/INFO]: Saving chunks for level 'ServerLevel[Sync Bug Demo]'/minecraft:the_end
[23:27:19] [Server thread/INFO]: ThreadedAnvilChunkStorage (Sync Bug Demo (1)): All chunks are saved
[23:27:19] [Server thread/INFO]: ThreadedAnvilChunkStorage (DIM-1): All chunks are saved
[23:27:19] [Server thread/INFO]: ThreadedAnvilChunkStorage (DIM1): All chunks are saved
[23:27:19] [Server thread/INFO]: ThreadedAnvilChunkStorage: All dimensions are saved
[23:30:57] [Render thread/INFO]: Stopping!
Process exited with code 0.
MultiMC: Log upload triggered at: 24 Dec 2021 23:31:04 -0600

Other Mods
None

Additional Information
I'm using MultiMC, but not sure that would be applicable to these particular bugs.

I somehow managed to forget that a block can be broken not only by a player :)
Thank you for reporting this one, the video is also deeply appreciated! Cool skin, by the way :)
P.S. - to remove a ghostshell in your existing world you can use /sync ghostshells remove nickname x y z


Add CQL source code generator

It is well established already that we have the Translator project which converts CQL source code to ELM source code, and that we have the CQL Engine project that takes ELM source code and evaluates it to produce result values or other output.
However, I am not aware of any projects that go the other way, either taking ELM and generating CQL, or in particular, an Engine feature that takes an arbitrary in-memory CQL value and generates valid CQL (or ELM) source code that when executed produces the same CQL value.
The task of this ticket is to do the last of these (generating valid CQL source code for an in-memory value), in particular, or otherwise identifying where the functionality already exists.
See also related ticket #40.
The fundamental deliverable of this ticket is characterized by a Java function that takes any Java Object X as input which can be the result of an Executable.evaluate() call, and produce a Java String value consisting of an anonymous valid CQL expression, the E in "define e: E" in Population context, such that subsequent translation and Executable.evaluate() of E would produce a Java Object Y representing a CQL value for which Equivalent(X,Y) would result in true.
One use of this function is that it can be exposed as a CQL "external" function, thus a CQL expression can result in CQL source code, a demonstration of the "external" feature of the language.
Another, very important, use of this function, is that it can be used by the CQL Runner to generate the results displayed back to users.  The current output approximates but doesn't equal valid CQL, so it can't be copy-pasted back into input without manual editing; moreover, the current output may display non-identical values identically.  With the new version, if they display the same / different, they are the same / different respectively.
Note that this ticket is not about generating entire CQL libraries, just individual values; the former if desired (and I think it would be) is the task of another ticket, if not already done.
I estimate that this task can be completed within 1 day of work, given similar features already extant.

There's now an ELM to CQL generator in the cqf-tooling project:
https://github.com/cqframework/cqf-tooling/blob/a4cc500d7525b4f2df69909019d09d0f01ba97a2/src/main/java/org/opencds/cqf/tooling/cql_generation/drool/visitor/ElmToCqlVisitor.java


[WIP] Ratelimits

To make it more enjoyable we should ratelimit some points of the bot.

Why? Are you really joining servers that quickly that you're incurring some kind of rate limit for opening DMs?

GUILD_CREATE gets called a lot more often then only when a bot gets added for the first time. (It's mainly to reduce the stress on the DB (especially since GUILD_CREATE tends to get called during startup where it's not the only part connecting with the DB)

It sounds to me like you just need a flag for when guild streaming is done.

Won't work if the bot is added to guild during downtime, and then gets the GUILD_CREATE's afterwards

You can still go over all guilds once streaming is done in the fiber of the last event

That might work. How can I check if the guilds are streaming?

Collect a list of unavailable IDs from READY, then check if you've accounted for all of them in each GUILD_CREATE event. If you have, start rolling through guilds at whatever rate.
Psuedocode using an unordered Set(UInt64):
@unavailable_guilds = Set(UInt64).new
@available_guilds = Set(UInt64).new
@streaming = false

client.on_ready do |payload|
  # Only fire on the first READY received, or if the ID cache was cleared
  next unless @unavailable_guilds.empty?
  @streaming = true
  @unavailable_guilds.concat payload.guilds.map(&.id)
end

client.on_guild_create do |payload|
  if @streaming
    @available_guilds.add payload.id

    # We're done streaming
    if @available_guilds == @unavailable_guilds
      # Process each guild at a rate
      @cache.guilds.each do |guild|
        handle_new_guild(guild)
        sleep RATE_LIMIT
      end
      # Any guild after this is new, we're not streaming any more
      @streaming = false
    end
  else
    # Brand new guild
    handle_new_guild(payload)
  end
end

def handle_new_guild(guild : Discord::Guild)
  # DM the owner, etc
end

Could probably exploit this too to generate a measure of how long startup time takes to cache all guilds.

Closing in favour of #81


nfldb stats

I noticed there aren't any stats for the 2015 preseason, but there were preseason stats last year. Is there a bug? The game table shows the correct 2015 schedule but the scores are 0-0.

On Sep 3, 2015 1:54 AM, "vinnypimp"<EMAIL_ADDRESS>wrote:

I noticed there aren't any stats for the 2015 preseason, but there were
preseason stats last year. Is there a bug? The game table shows the correct
2015 schedule but the scores are 0-0.
—
Reply to this email directly or view it on GitHub
https://github.com/BurntSushi/nfldb/issues/96.

I did. The schedule updated and showed the games as final with 0-0 scores. Also, there were no player stats. I also ran a python script to see if it was my import and it too game back with no stats.

Was thinking.. I haven't made any updates to the modules. Can that be the reason? It was working fine last season. Were there any updates made between end of last season and now?

You should always be upgrading. If something isn't working as expected, the very first thing you should try is upgrading. To make sure you have the latest, run pip install --upgrade nfldb. Then run nfldb-update again.


[Event Parameter Change] Table 5406 Prod. Order Line - Trigger OnValidate Item No. - Event OnAfterCopyFromItem

We would like the parameter/-s CurrFieldNo added to the following event.
Table 5406 Prod. Order Line - Trigger OnValidate Item No. - Event OnAfterCopyFromItem
Original:
    OnAfterCopyFromItem(Rec, Item, xRec);

    [IntegrationEvent(false, false)]
    local procedure OnAfterCopyFromItem(var ProdOrderLine: Record "Prod. Order Line"; Item: Record Item; var xProdOrderLine: Record "Prod. Order Line")
    begin
    end;

Change:
    OnAfterCopyFromItem(Rec, Item, xRec, CurrFieldNo);

    [IntegrationEvent(false, false)]
    local procedure OnAfterCopyFromItem(var ProdOrderLine: Record "Prod. Order Line"; Item: Record Item; var xProdOrderLine: Record "Prod. Order Line"; CurrFieldNo: Integer)
    begin
    end;

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.
Build ID: 47191.


Release macOS arm64 binaries are x86_64

Hello @synesthesiam, I just want to let you know that binaries provided for macOS arm64 at the release page are not built for arm64.
file -b piper
Mach-O 64-bit executable x86_64

For the context, I'm currently trying to write a JNI wrapper for piper so I can use it on a Java project, it's already working but I'm struggling with the macOS arm64 cross build on the pipeline, so I checked yours and saw the problem.
I forked the current piper CMakeLists.txt so the build is pretty similar. What I'm trying is to build with -DCMAKE_OSX_DEPLOYMENT_TARGET=11 -DCMAKE_OSX_ARCHITECTURES=arm64 but it seems to get ignored by the ExternalProject_Add function. I don't know too much about cmake, not sure how to solve this, I think I'll try to use an apple silicon runner https://github.com/actions/runner-images/issues/8439.
Best regards, and the project is amazing by the way, congratulations to the people behind it.

It worked for me using the macos-13-xlarge runner.

It worked for me using the macos-13-xlarge runner.

Might I make a suggestion? Feel free to use FlyCI's M1 and M2 runners. Our runners are on average 2x faster and 2x cheaper than GitHub's AND we have a free tier for OSS projects (see below).
Install Instructrions
Easily replace your M1 runners:
jobs:
 ci:
-    runs-on: macos-latest
+    runs-on: flyci-macos-large-latest-m1
   steps:
   - name: 👀 Checkout repo
     uses: actions/checkout@v4

Or try the M2 runners:
jobs:
  ci:
-    runs-on: macos-latest
+    runs-on: flyci-macos-large-latest-m2
    steps:
      - name: 👀 Checkout repo
        uses: actions/checkout@v4

Pricing

Processor
vCPU
RAM (GB)
Storage
Label
Price on FlyCI
Price on GitHub

M1
4
7
28 GB
flyci-macos-large-latest-m1
$0.06
-

M1
8
14
28 GB
flyci-macos-xlarge-latest-m1
$0.12
$0.16

M2
4
7
28 GB
flyci-macos-large-latest-m2
$0.08
-

M2
8
14
28 GB
flyci-macos-xlarge-latest-m2
$0.16
-

500 mins/month Free for Public Repos
If your repo is public, then FlyCI offers 500 mins/month of free M1 runner usage with the flyci-macos-large-latest-m1 runner.
Best Regards,
Kiril Gantchev
CEO and co-founder of FlyCI


Short content doesn't look good on Kubeflow site

Thanks @IronPan ! I'm closing this as a duplicate of issue #322
Note also that the Docsy theme fixes this problem. See issue #291

/close


fix: load fewer lots into rails

I noticed these frequent queries for size=99 hitting the API and thought they must be excessive, as no UIs appeared to ever list that many items. Tracing them, though, it seems like a few rails could display up to 99 results. It's unlikely, but even if you e.g. follow Andy Warhol and visit a Warhol-only sale with hundreds of lots, I don't think it's necessary or practical to list that many in the top-most rail. Similarly for the other 2 cases (buy-now works associated with a sale, or current auctions while viewing a sale preview), though I think those are even less likely.

Concur that it's totally not practical to have this many things in a rail


The spell check may not be checking hidden files and directories

Version
1.0.0
What happened?
In my CppStarter project, I found that I need to run cspell --dot **/* and add .git/* to the CSpell configuration file:
{
  "ignorePaths": [".git/*"]
}

This suggests the workflow may not have the correct command.
What should happen?

The spell check step should check all files.
Document that users should put .git in the configuration. This may not be necessary if the action accounts for it.

I was wrong; this step works correctly. See this screenshot from my CppStarter repo. The workflow correctly found spelling mistakes in files in .vscode/.


pin poetry to version 1.1.15 to avoid package resolution issues, do not remove lock file

Feature or Bugfix

Bugfix

Detail

other github workflows as well as codebuild buildspecs are currently pinning poetry to version 1.1.15, updating cfn-nag workflow to be consistent
do not remove poetry.lock

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

AWS CodeBuild CI Report

CodeBuild project: GitHubCodeBuild8756EF16-4rfo0GHQ0u9a
Commit ID: 1d7b927c24ede75b9cbcd65aa39d78aa2b8a394c
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: GitHubCodeBuild8756EF16-4rfo0GHQ0u9a
Commit ID: 1d7b927c24ede75b9cbcd65aa39d78aa2b8a394c
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: GitHubCodeBuild8756EF16-4rfo0GHQ0u9a
Commit ID: 78358a8aa9dbb694813c8fb02079b354d08e37f3
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository


[Bug Report]: Transmog scroll causes weird space between enchants and scroll protection

Spark link
No response
Server Version
1.20.2
Server Platform
Paper
Describe the bug
Applying a transmog scroll causes a weird space between the enchants and scroll/crystal protections placed on the item, not sure what happens when lore is involved as well.

Steps to reproduce

Apply custom enchants on a piece of gear
Apply a white scroll and/or protection crystal
Apply a transmog scroll
Result: Weird space that triggers my OCD

Additional context
No response
Agreements

[X] I have searched for and ensured there isn't already an open issue regarding this.
[ ] I ticked all the boxes without actually reading them
[X] My version of Minecraft is supported by CrazyCrew.

Oh and I noticed if you add enchantments after that the number doesn't update, I'm not sure if it's supposed to or not 🤷♂

Fixed in latest update.


ci: Reduce build matrix size

Significantly reduce the build matrix size for simpler results and less build scheduling latency. Drops multi-compiler tests.
Based on the 0.17 update branch because of a minor conflict it will create.

I don't understand why it is an issue to test multiple compilers with CI. It seems on the contrary a good test to do.

Minor rant about test strategies:
Adding anything possible is not a good test strategy, and more tests are not itself better than fewer as they are a liability and add noise (the more indicators, the less each one means), test time (either per run or in scheduling and full test completion), and maintenance (minor here, but still a factor)  that should be justified. Focus should be on adding tests that are expected to add value and cover new areas or known problem areas.
Testing clang vs. gcc tells us very little. It does not test for distro or OS build environment compatibility, as each OS and distro use different compiler versions, library versions and configurations. With that in mind it just seemed like noise to me.


JavaScript eta?

Would like to start playing with this, the JS version im after specifically.

It'll probably be at least couple months. I have a super basic proof-of-concept done, but I'm currently prioritizing solidifying the API using C++/Python before finishing the Javascript implementation.

Adding JavaScript support has been deprioritized for now. There is a proof-of-concept merged into the repo, if anyone wants to develop further on it.


⚠ Bofrost.es has degraded performance

In dc0997b, Bofrost.es (https://www.bofrost.es) experienced degraded performance:

HTTP code: 200
Response time: 1592 ms

Resolved: Bofrost.es performance has improved in 67cbb43 after 13 minutes.


Adding Arabic Translation

I have added Arabic translation to miniflix but seems i have a problem in forming the plural formula as for some feeds i'm getting the following error message:
Notice: Undefined offset: 4 in C:\wamp\www\miniflux\lib\Translator.php on line 100
Note:
Arabic language is RTL language therefore some words direction might be shown improperly specially characters like open/close brackets.
The miniflux themes has to be forced to show RTL direction when Arabic language is selected.
i don't know if that can be done through miniflux code instead of theme code.

Thanks, I merged your translation.
The error messages are coming from the plural strings. Apparently, Arabic language have 6 plural forms and in the file you set only 2 plural forms:
'After %d day' => array('بعد %d يوم', 'أيام %d بعد'), // <= the list should have 6 items

I changed the code to avoid the warnings. I also modified the user interface to be more "RTL compliant" but it's not perfect yet. Many improvements have to be done.


[QUESTION] Incident comments - max lines

Hi guys.
Sometimes the STAT app needs to add long comments to the incident, however, I've noticed that when the comments have a large number of lines, they seem to exceed the currently allowed limit.
As seen in the picture below.
I've searched for a setting to increase the maximum number of lines allowed per comment, but I haven't been able to find any.

Hi @SimonRefslund
Sentinel has a limit of 30,000 characters per comment.  If you exceed that number the comment will fail to create.
So, we've done 2 things:

Limited the output to never exceed 30,000 so in the unlikely event we hit that number a comment will still be made though it will likely be hard to read as it will almost certainly break the html format: https://github.com/briandelmsft/STAT-Function/blob/70e6903252229bac0ff912f3f6d1d0d56bd567d5/shared/rest.py#L213

Chosen a max number of rows per module that we believe will safely fall within that limit which is 20 by default if not explicitly defined otherwise by the module when converting the array to html https://github.com/briandelmsft/STAT-Function/blob/70e6903252229bac0ff912f3f6d1d0d56bd567d5/shared/data.py#L4

There is no exposed setting via the connector to manipulate this, but if you're modifying the python package you could include max_rows=x in the call to the add_incident_comment() function to add more rows, but be aware if you exceed 30,000 it will be truncated and the table will likely not render.
Another thing to note is the modules DetailedResults array in it's output will contain all rows, even when truncated in the table, so you could also do something with that.
About the only thing we can do to reliably increase row count would be to build in some logic to the table generation to generate the table with all rows, measure the size and then determine if any need to be truncated.

I see. Thank you for the clarification


In text citation order

The order of numeric in text citations is non-standard. Is LaTeX doing this based automatically based on the publication date or can we just move citation order around to make this look nicer?

Looks like LaTex is doing this based on publication date.

Btw I remember now why this is. Originally I was using the full (Name,
Year) citation style in the text, and so then wanted to order the
bibliography alphabetically because that seemed to be the easiest way to
find a given citation. When we switched to the number style, I forgot to
take out the ordering by name. There will be an option somewhere in the
bibliography commands to change the sort order.
On Tuesday, 22 May 2018, Chris Clarkson<EMAIL_ADDRESS>wrote:

Looks like LaTex is doing this based on publication date.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/malariagen/agam-vgsc-report/issues/168#issuecomment-390963077,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAq8QkwX0q8sHZH47_y24TA4A9WDsgqtks5t0_x5gaJpZM4UIaGj
.

--
If I do not respond to an email within a few days, please feel free to
resend your email and/or contact me by other means.
Alistair Miles
Head of Epidemiological Informatics
Centre for Genomics and Global Health
Big Data Institute
Li Ka Shing Centre for Health Information and Discovery
Old Road Campus
Headington
Oxford
OX3 7LF
United Kingdom
Phone: +44 (0)1865 743596 or +44 (0)7866 541624
Email<EMAIL_ADDRESS>Web: http://a http://purl.org/net/alimanlimanfoo.github.io/
Twitter: @alimanfoo https://twitter.com/alimanfoo


relative link

@ElizabethSamuel-MSFT

Docs Build status updates of commit 313f917:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/index.yml
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel


Fix Laravel Mix source maps

https://github.com/roots/sage/pull/2197/commits/a524006214018cefcefdfdf3d26dab564f9f7681 needs to make it into the 10 dev branch since #2197 won’t be part of the first alpha release

[x] I've read the guidelines for Contributing to Roots Projects

Resolved in #2268 👍


Please update the most recent documentation

Anyone can help here?

what do you have?

@serderovsh check this https://gitee.com/jjhoc/tronpytool


CORS support

I could be wrong, but it seems that this server doesn't support CORS out-of-the-box.
My guess is that it should be relatively simple to implement it with usage iron-cors.

Yep, it's a missing feature right now but not hard to add. Maybe iron-cors-rs. PR welcome!

FYI this features is in progress now and will be available on next release.

Wow, great! Thank you. I also observed some minor issue with building it on Alpine (for very lightweight docker images), but I don't understand what is the culprit. It has something to do with rust bindings to openssl. Finally, I managed to build rust-openssl with this recipe: https://github.com/gnzlbg/ctest/issues/95 But even after this I couldn't succeed to build this repo on Alpine.. It's really only if you are curious, since it is possible to just use another base image.

I didn't get it, do you want to build the whole project using Alpine? It would be interesting specially to save bytes but I have not tried it out with it.
As you probably know, this project uses a relative big image which is based on debian:buster-slim for a "convenient way" to cross-compile this project (Linux/Darwin).
Yes, you need build openssl and set up it around the system and probably you also want to take a look at https://github.com/joseluisq/rust-linux-darwin-builder/blob/master/docker/Dockerfile.

I wanted to build static-web-server only to have it's binary in a fixed environment. I was building rust-openssl because errors in build log were pointing at it. So, after I managed to compile it alone with non-packaged Rust and  x86_64-unknown-linux-musl target, I hoped that static-web-server will compile also with the same toolchain, but this didn't happen.
Alpine just makes it a bit complicated with packaging only musl as a C library. I think, it is worth to spend time for this issue only out of perfectionism. On the other hand, simple-http-server can be compiled even with default Rust package there. I'm not sure how they made it possible.
I think I try to build it one more time later, just to get the error message at least.

If you intention is not to just copy the binary from the scratch image, it would be interesting, just going on... 😅
I'm also particularly interested such research in pro not only of this tool. That's for sure.
By the way, I will try to find time to play around with that.

Super, thanks!

v1.9.0 released.

Actually, I realized only now that you are uploading the Docker image to Docker Hub.
It's much easier to use it than to build complete project in Alpine :) Thanks a lot!

Yeah, since the first version. Makes more sense because I use it to serve several sites in production.
Actually there are two images, the scratch that you can easily extend it and the Alpine as well. Both have just the static binary.
Enjoy it!


RawEventHandlers fluent-menu-item has error

There is an error in RawEventHandlers.razor file which prevents to run.

I don't understand why you're getting an error on this attribute. role is a string attribute, so you can place any string you like.
On the other hand, we don't have this error with the latest version of Visual Studio Preview.
Which version are you using? Which version of .NET?

I don't understand why you're getting an error on this attribute. role is a string attribute, so you can place any string you like.
On the other hand, we don't have this error with the latest version of Visual Studio Preview.
Which version are you using? Which version of .NET?

I am using Dotnet 9 and Visual studio the latest preview version.

I don't understand why you're getting an error on this attribute. role is a string attribute, so you can place any string you like.
On the other hand, we don't have this error with the latest version of Visual Studio Preview. Which version are you using? Which version of .NET?

I cloned again the dev branch it has this error yet

Can you try to build using DotNet8 (and not 9)?

Can you try to build using DotNet8 (and not 9)?

I tried dotnet build --framework net8.0 error still exists.

This is caused by an error in your environment, not by an issue in the library/code. Another thing you can try is to add a global.json file to the root of your repo folder containing the following:
{
  "sdk": {
    "version": "8.0.302",
    "rollForward": "major"
  }
}

Closing this as it can't be solved from our side.


The source tenant does not authorize mailbox for migration

Hello.
I'm trying to use this feature following the official documentation and a tutorial on Youtube, but when I run the test command "Test-MigrationServerAvailability -EndPoint "[the name of your migration endpoint]" -TestMailbox "[Primary SMTP of MailUser object in target tenant]"" (Replacing the values, obviously) returns that the source tenant does not authorize the mailbox migration.
How can I enable this migration?
I already repeated the step by step several times, including using different names in the API, Endpoint, etc, so that there was no conflict.
I correctly collected the ExchangeGUID and LegacyExchangeDN values from the MailBox in the source and assigned to the MailUser in the target.
I also enabled some parameters with Set-OrganizationRelationship, but without success.
Below is the complete error:

Result          : Failed
Message         : The connection to the server 'outlook.office365.com' could not be completed.
SupportsCutover : False
ErrorDetail     : Microsoft.Exchange.Migration.MigrationServerConnectionFailedException: Não foi possível concluir a conexão ao servidor
'outlook.office365.com'. ---> Microsoft.Exchange.MailboxReplicationService.MRSRemotePermanentException: The source tenant
'adfc66f7-9f68-48d1-8337-7b77a2b946e7' does not authorize mailbox 'c14b6cc0-9172-4651-a9c1-71c0f97d43e9' for migration.
Please ensure the migration scope is setup correctly on the source tenant and scope identifier is set in organization
relationship.
at Microsoft.Exchange.MailboxReplicationService.MailboxReplicationServiceFault.ReconstructAndThrow(String serverName,
VersionInformation serverVersion)
at Microsoft.Exchange.Connections.Common.WcfClientWithFaultHandling2.<>c__DisplayClass4_0.<CallService>b__0()                      at Microsoft.Exchange.Net.WcfClientBase1.CallService(Action serviceCall, String context)
at Microsoft.Exchange.Connections.Common.WcfClientWithFaultHandling2.CallService(Action serviceCall, String context)                      at Microsoft.Exchange.MailboxReplicationService.WcfClientWithVersion2.CallService(Action serviceCall, String context)
at Microsoft.Exchange.MailboxReplicationService.MailboxReplicationServiceClient.GetMailboxInformation(RequestJobBase
requestJob, Guid primaryMailboxGuid, Guid physicalMailboxGuid, TenantPartitionHint partitionHint, ADObjectId
targetMdbAdObjectId, String targetMdbName, String remoteHostName, String remoteOrgName, Guid requesterOrgId, String
remoteDCName, NetworkCredential cred, MailboxConnectFlags mailboxConnectFlags)
at Microsoft.Exchange.Migration.MigrationExchangeProxyRpcClient.GetMailboxInformation(TransactionalRequestJob
requestJob, Guid primaryMailboxGuid, Guid physicalMailboxGuid, TenantPartitionHint partitionHint, ADObjectId
targetMdbAdObjectId, String targetMdbName, String remoteHostName, String remoteOrgName, Guid requesterOrgId, String
remoteDCName, NetworkCredential cred, LocalizedException& error)
--- End of inner exception stack trace ---
at Microsoft.Exchange.Migration.MigrationEndpointVerifier.GetMailboxInformation(String remoteServer,
TransactionalRequestJob requestJob, Guid primaryMailboxGuid, Guid physicalMailboxGuid, String sourceTenantName, Guid
targetTenantId, TenantPartitionHint targetTenantPartitionHint, ADObjectId targetMdbId, NetworkCredential appCred)
at Microsoft.Exchange.Management.Migration.MigrationService.Endpoint.TestMigrationServerAvailability.InternalProcessCro
ssTenantScenario()
at Microsoft.Exchange.Management.Migration.MigrationService.Endpoint.TestMigrationServerAvailability.InternalProcessEnd
point(Boolean fromAutoDiscover)
TestedEndpoint  :
IsValid         : True
Identity        :
ObjectState     : New

Good evening, Juan.
Did you create the mail-enabled security group in the source tenant and add the mailbox you are testing, to that group?
https://learn.microsoft.com/en-us/microsoft-365/enterprise/cross-tenant-mailbox-migration?view=o365-worldwide#prerequisites-for-source-and-target-tenants
Thanks,
Roman

It worked. Thanks!


Remove duplicated rules

Remove duplicated rules which are already included in @Symfony rules.
To verify that the @Symfony rules include the removed rules see https://github.com/FriendsOfPHP/PHP-CS-Fixer/blob/2.16/src/RuleSet.php or run:
php php-cs-fixer.phar describe @Symfony | grep -A 3 array_syntax
php php-cs-fixer.phar describe @Symfony | grep -A 3 no_superfluous_phpdoc_tags
// ...

Thanks Michael. I like this kind of contributions because even if it looks small, it removes "noise" and simplifies maintenance. Thanks!


how do i use this?

I found this info: https://endrift.com/2015/03/24/gbpp/
To run the code, I think that the host program is compiled using make then ran, and the ino sketch is uploaded to the microcontroller used by the setup.


Fix UCAS matches summary in support

Context
We are getting errors for individual UCAS match pages:
https://sentry.io/organizations/dfe-bat/issues/1936503787/?project=1765973

Changes proposed in this pull request
- Consider recruitment cycle when looking up course for UCAS matches
Now that we are approaching the next recruitment cycle we have two courses with the same code and provider. One for each recruitment cycle year. Decided to hardcore it instead of using RecruitmentCycle.current_year, RecruitmentCycle.previous_year as it’s going to change soon but we still want to compare courses in 2020 recruitment cycle.
- Fix UCAS matches summary for apply again candidates
When a candidate applied again they would have two application forms. find_by was returning the latest application form, which in most cases was incomplete and not sent to providers and therefore had no application choices. Candidate’s ids for which this was the case: 96, 471, 3410, 1030, 2485, 2850, 3327, 3616.
Guidance to review
Review questions:

thought on hardcoding recruitment cycle year
is there a fancy join I can do to avoid 2 queries in the 2nd commit?

Don't think we can reproduce the same issue locally. We can get the same error by running GenerateTestData.new(10).generate a few times but this is because some test application forms are generated without application choices, I think.
Link to Trello card

Things to check

[ ] This code does not rely on migrations in the same Pull Request
[ ] If this code includes a migration adding or changing columns, it also backfills existing records for consistency
[ ] API release notes have been updated if necessary
[ ] New environment variables have been added to the Azure config

https://trello.com/c/RAdk0NeY/2301-fix-ucas-matching-sentry-error


[core] Use the new recursion safety feature in tiny-async

This makes DelayedCollectCoordinator able to handle when there's many AsyncFuture's linked that are immediately resolved. Previous to this change, that scenario would result in a stack overflow.
This requires tiny-async 1.11.0, which we just switched to.

Current coverage is 45.41% (diff: 100%)

Merging #187 into master will increase coverage by <.01%

@@             master       #187   diff @@
==========================================
  Files           605        605
  Lines         15674      15678     +4
  Methods           0          0
  Messages          0          0
  Branches       1604       1604
==========================================
+ Hits           7118       7120     +2
- Misses         8095       8096     +1
- Partials        461        462     +1

Powered by Codecov. Last update 53ebb58...ed3479d

@udoprog: I can add some configuration or feature flag, if you'd like?

@udoprog: I can add some configuration or feature flag, if you'd like?

No, let's go with this. We've tested the implementation of it fairly well already. If we find that it causes any issues we can hide it behind configuration and refine it.


Create nfri-ctf-nf1-project.yaml

Ok, I'm pretty sure this is my last project config file for a while... :)
Thanks!

Makes sense, thanks!


SignalR 1.1 update

This checklist is used to make sure that common guidelines for a pull request are followed.

[ ] The PR has modified HISTORY.rst describing any customer-facing, functional changes. Note that this does not include changes only to help content. (see Modifying change log).

[ ] I adhere to the Command Guidelines.

@zikalino I've fixed issues according to the comments. Please have a look.

I am going to merge this, despite minor comments I left.
need to add entry in HISTORY.rst in a separate PR.