Update stats

This adds more metrics to the stats summary API, and makes Kip use the default metrics port by default. The default port is pretty much a requirement when using metrics-server; even though the port is configurable, it only is on a per-cluster (not per-node) basis. That is, if we want to collect metrics from nodes we have to choose one port all kubelet must use for the stats summary endpoint.
To fix this, I made Kip NOT use host network mode by default. I added kube-proxy in a sidecar for setting up NodePorts in the VK pod.
Since the IP address now will likely change after every pod restart, I also added a check to the init container when generating the certificate, so that the cert will be re-created if the IP has changed.
With these changes, the stats are a lot more detailed:
  {
     "containers" : [
        {
           "cpu" : {
              "time" : "2020-05-26T22:09:42Z",
              "usageCoreNanoSeconds" :<PHONE_NUMBER>73,
              "usageNanoCores" : 258544883
           },
           "memory" : {
              "majorPageFaults" : 53,
              "rssBytes" :<PHONE_NUMBER>,
              "time" : "2020-05-26T22:09:42Z",
              "usageBytes" :<PHONE_NUMBER>,
              "workingSetBytes" :<PHONE_NUMBER>
           },
           "name" : "buildkite",
           "startTime" : "2020-05-26T22:00:57Z"
        }
     ],
     "cpu" : {
        "time" : "2020-05-26T22:09:42Z",
        "usageCoreNanoSeconds" :<PHONE_NUMBER>73,
        "usageNanoCores" : 258544883
     },
     "ephemeral-storage" : {
        "availableBytes" :<PHONE_NUMBER>,
        "capacityBytes" :<PHONE_NUMBER>2,
        "inodes" : 1290240,
        "inodesFree" : 1165646,
        "inodesUsed" : 124594,
        "time" : "2020-05-26T22:09:42Z",
        "usedBytes" :<PHONE_NUMBER>
     },
     "memory" : {
        "majorPageFaults" : 53,
        "rssBytes" :<PHONE_NUMBER>,
        "time" : "2020-05-26T22:09:42Z",
        "usageBytes" :<PHONE_NUMBER>,
        "workingSetBytes" :<PHONE_NUMBER>
     },
     "network" : {
        "interfaces" : [
           {
              "name" : "eth0",
              "rxBytes" : 716386029,
              "txBytes" : 8983003
           }
        ],
        "name" : "eth0",
        "rxBytes" : 716386029,
        "time" : "2020-05-26T22:09:42Z",
        "txBytes" : 8983003
     },
     "podRef" : {
        "name" : "android-ndk-f49b9496c-nlxsr",
        "namespace" : "default",
        "uid" : "1c6c2b41-9f9a-11ea-8636-42010a800163"
     },
     "startTime" : "2020-05-26T22:00:57Z"
}

The GKE monitoring dashboard also shows pod and container metrics from VK workloads:

Related itzo PR: https://github.com/elotl/itzo/pull/88

One thing to keep in mind is that all these values are kept in memory and we keep 240 datapoints per pod.  I think we're still pretty good with the numbers.  A rough calculation:

240 datapoints/pod
400 pods
conservatively 30 datapoints per pod stored in a map[string]float64

A quick browse shows that a map has an overhead in the ballpark of 30-60 bytes per entry + storage for the string key and int64 values.
All of that means that when running at scale, our stats should require 100MB - 500MB.  The larger number assumes a bunch of sidecars in each pod.  I think that's fine.  I sure hope that calculation was right!

One thing to keep in mind is that all these values are kept in memory and we keep 240 datapoints per pod. I think we're still pretty good with the numbers. A rough calculation:
* 240 datapoints/pod

* 400 pods

* conservatively 30 datapoints per pod stored in a map[string]float64

A quick browse shows that a map has an overhead in the ballpark of 30-60 bytes per entry + storage for the string key and int64 values.
All of that means that when running at scale, our stats should require 100MB - 500MB. The larger number assumes a bunch of sidecars in each pod. I think that's fine. I sure hope that calculation was right!

Thanks! I think, with certain workloads, it might even be slightly more memory, since we also have per-container metrics. Something to keep in mind when scaling or provisioning a production cluster.

Thanks so much for testing metadata, LBs out and finding the issue with GCE!  I realize it was likely a bit time consuming.  I hope that moving away from hostNetwork mode will make things a bit smoother overall.


Payload not working anymore after upgrade to newest version

Link to reproduction
No response
Describe the Bug
Probably same as here : https://github.com/payloadcms/payload/issues/6062
I did nothing other than upgrade payload to the most recent version (2.16.1) before reverting to the previous version (2.11.0). The problem that appeared with the upgrade remains.

To Reproduce
Upgrade from 2.11.0 to 2.16.1.
If you revert to 2.11.0, the issue remains.
Payload Version
2.16.1
Adapters and Plugins
No response

Hey @jonisapp can you show us your package.json?
Between upgrades have you tried removing the lock file and the node_modules folder in case there's a different version of react being cached?

Hey @jonisapp can you show us your package.json?
Between upgrades have you tried removing the lock file and the node_modules folder in case there's a different version of react being cached?

Yes, i've tried both things but that didn't solve the problem.
{
  "name": "lepitre-admin",
  "description": "Payload project created from blank template",
  "version": "1.0.0",
  "main": "dist/server.js",
  "license": "MIT",
  "scripts": {
    "dev": "cross-env PAYLOAD_CONFIG_PATH=src/payload.config.ts nodemon",
    "build:payload": "cross-env PAYLOAD_CONFIG_PATH=src/payload.config.ts payload build",
    "build:server": "tsc",
    "build": "yarn copyfiles && yarn build:payload && yarn build:server",
    "serve": "cross-env PAYLOAD_CONFIG_PATH=dist/payload.config.js NODE_ENV=production node dist/server.js",
    "copyfiles": "copyfiles -u 1 \"src/**/*.{html,css,scss,ttf,woff,woff2,eot,svg,jpg,png}\" dist/",
    "generate:types": "cross-env PAYLOAD_CONFIG_PATH=src/payload.config.ts payload generate:types",
    "generate:graphQLSchema": "cross-env PAYLOAD_CONFIG_PATH=src/payload.config.ts payload generate:graphQLSchema"
  },
  "dependencies": {
    "@aws-sdk/client-s3": "^3.325.0",
    "@aws-sdk/lib-storage": "^3.325.0",
    "@payloadcms/bundler-webpack": "^1.0.6",
    "@payloadcms/db-mongodb": "^1.5.1",
    "@payloadcms/plugin-cloud-storage": "^1.1.2",
    "@payloadcms/richtext-lexical": "^0.10.0",
    "@payloadcms/richtext-slate": "^1.5.2",
    "docker-secret": "^2.0.6",
    "dotenv": "^8.2.0",
    "express": "^4.17.1",
    "payload": "^2.16.1"
  },
  "devDependencies": {
    "@types/express": "^4.17.9",
    "copyfiles": "^2.4.1",
    "cross-env": "^7.0.3",
    "nodemon": "^2.0.6",
    "ts-node": "^9.1.1",
    "typescript": "^4.8.4"
  }
}

After reinstalling the latest version of payload today, the problem has been solved for me. The only parameter that has changed since yesterday is that the session has expired. Last time I didn't try clearing the cache, so I don't know if it could be related to that. On the other hand, it was very annoying yesterday because I was completely stuck with these very uninformative errors. So I suggest keeping the issue open in case it happens to someone else.


Gettext improvements

It would be great to have these features on it:

Copy the original text on the translation field making double click.
Add a 'Save as (other language)' button, to copy all the translations of that language in other.

Features requested by @AndreaLopezLozano

:+1:


Provide option to ignore EOL whitespace

From @lijunle on June 18, 2016 9:8
Repository.getLineDiffs provides an option to ignoreEOLWhitespace, however it is not passed in the code. Could you please add it as an option?
Copied from original issue: atom/git-diff#102

From @starrychloe on July 1, 2018 21:0
Yeah I was about to submit an issue for ignoring whitespace. When I go to check in files, I see bogus differences that should not exist. I think the Atom editor is mucking up lines I am not even editing. OK that's a separate problem, but I would like to ignore whitespace changes. For example
git diff -b app/models/plan.rb

Shows exactly the differences that I made, and more specifically,
git diff --ignore-space-at-eol app/models/plan.rb

Also does the same thing.  There is only a single setting that is available!

Also, using Window: Toggle Invisible from the command pallet is not working when viewing diffs either! That's probably another bug. I shouldn't have to use so many keystrokes to show non-printing characters (CTRL, SHIFT, P, I, N, V, ...).


Add list-pulls script

This is the script I've been using to generate the sorted PR list in the release notes.
So to be clear: the output of this script is a first draft based on rough heuristics, and likely needs to be extensively manually edited before ending up in the release notes.

Rebased for README.md change.
Going to merge this, to be able to maintain this script here during the 0.19.0 release process. I'm trying to clear out my private devtools repo by moving things here.


travis ci badge

Codecov Report

Merging #3 (bd06192) into main (bc7b03d) will decrease coverage by 7.94%.
The diff coverage is n/a.

:exclamation: Current head bd06192 differs from pull request most recent head bd5c975. Consider uploading reports for the commit bd5c975 to get more accurate results

@@            Coverage Diff             @@
##             main       #3      +/-   ##
==========================================
- Coverage   63.01%   55.07%   -7.95%
==========================================
  Files           9       13       +4
  Lines         265      345      +80
==========================================
+ Hits          167      190      +23
- Misses         97      154      +57
  Partials        1        1

Impacted Files
Coverage Δ

http/encoder/factory.go
100.00% <0.00%> (ø)

http/request.go
0.00% <0.00%> (ø)

http/encoder/xml.go
100.00% <0.00%> (ø)

http/encoder/json.go
100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc7b03d...bd5c975. Read the comment docs.


fix:  flush effect of line axis label(with background)

[中文版模板 / Chinese template]
🤔 This is a ...

[ ] New feature
[x] Bug fix
[ ] TypeScript definition update
[ ] Bundle size optimization
[ ] Performance optimization
[ ] Enhancement feature
[ ] Refactoring
[ ] Update dependency
[ ] Code style optimization
[ ] Test Case
[ ] Branch merge
[ ] Site / documentation update
[ ] Demo update
[ ] Workflow
[ ] Release
[ ] Other (about what?)

🔗 Related issue link
closes https://github.com/VisActor/VChart/issues/3559

🐞 Bugserver case id
675fe28530877400b3e63178

💡 Background and solution

📝 Changelog

Language
Changelog

🇺🇸 English

🇨🇳 Chinese

☑ Self-Check before Merge
⚠ Please check all items below before requesting a reviewing. ⚠

[ ] Doc is updated/provided or not needed
[ ] Demo is updated/provided or not needed
[ ] TypeScript definition is updated/provided or not needed
[ ] Changelog is provided or not needed

🚀 Summary
copilot:summary
🔍 Walkthrough
copilot:walkthrough

badcase, see: version=<IP_ADDRESS>7&reportid=675fc9d30a6f74118edc3f71&open_in_browser=true


eslint exit code 1

Hello guys,
I'm having a problem that I don't know how to resolve it.
I have a typescript project, and I want to perform a lint step I'm my pipeline (using Gitlab), with reviewdog.
However, when I perform this command npm run lint | ${REVIEWDOG} -f=eslint -name=reviewdog -reporter=gitlab-mr-discussion or ./node_modules/eslint/bin/eslint.js . --ext .ts | ${REVIEWDOG} -f=eslint -name=reviewdog -reporter=gitlab-mr-discussion I'm getting a exit code 1 error.
reviewdog/reviewdog info checking GitHub for tag 'v0.10.2'
reviewdog/reviewdog info found version: 0.10.2 for v0.10.2/Linux/x86_64
reviewdog/reviewdog info installed .bin/reviewdog
$ export REVIEWDOG_GITLAB_API_TOKEN=$GITLAB_PERSONAL_TOKEN
$ ./node_modules/eslint/bin/eslint.js . --ext .ts | ${REVIEWDOG} -f=eslint -name=reviewdog -reporter=gitlab-mr-discussion
ERROR: Job failed: command terminated with exit code 1

How can I resolve this?

Just an update, Locally in my computer everything works

Seeing the same issue in GitHub Actions.

I do not see any logs from reviewdog the in the output provided, so it does not seems like it was even called.
Maybe the problem is in the part before the the pipe (|) - so npm run lint or ./node_modules/eslint/bin/eslint.js . --ext .ts? Do they work correctly without reviewdog?

I do not see any logs from reviewdog the in the output provided, so it does not seems like it was even called.
Maybe the problem is in the part before the the pipe (|) - so npm run lint or ./node_modules/eslint/bin/eslint.js . --ext .ts? Do they work correctly without reviewdog?


[New Snap] Xtreamly

Checklist
All items in the list below needs to be satisfied.

[x] Is the Snap repository publicly accessible and linked in this ticket? https://github.com/Xtreamly-Team/Slippage-Snap
[x] Is the Snap distributed on npm and linked in this ticket? https://www.npmjs.com/package/@xtreamly/xtreamly_slippage_predictor
[x] Has an audit been performed and the audit report attached or linked in this issue?  https://sayfer.io/audits/metamask-snap-audit-report-for-xtreamly/
[ ] Is a complete list of discovered vulnerabilities from the audit documented in this issue?
[ ] For vulnerabilities that have been deemed necessary to be addressed, are the links to the fixes attached to this issue?
[ ] For vulnerabilities that have been deemed not necessary to be addressed, is a reason for each of them documented in this issue?
[ ] The corresponding pull request in this repo has been merged.

Audit Findings:
Severity of issues
High 0
Medium 1 - Fixed
Low 2 - Fixed, Ack
Informational 3 - Ack, Fixed, Fixed
Version to be allowListed: 1.0.20


Improved ui of meeting card component

This PR is a fixes of #84.
Please review the UI accordingly I will update.
Preview is attached below.

https://github.com/Curious-Ecosystem/Curious-Connect/assets/105445488/088eedaf-8f4f-4fdb-b50c-022a40906616

@Tomkndn
Instructions
You can start working on it by taking latest pull from main branch

[ ] Please raise pull request to main
[ ] Please read the contributors guidelines Contributing Guidelines.
[ ] Please follow the code of conduct Code Of Conduct
[ ] Don't Forget to join onboarding group for knowledge flow and direct conversation and support from admins
[ ] Link Curious Developers Community - Curious Connect
[ ] Please attach the screenshots and video of the development work once it is done
[ ] Contributions more than 3 will be awarded a certificate of appreciation from curious ecosystem
[ ] please mail to<EMAIL_ADDRESS>for claiming certificate and please attach your issue number

if any help required reach-out to admins or mentors in the onboarding group default meeting link and approach to admins - GOOGLE MEET Issue Discussion Google Meet
Respect Co Developers And Please Reach-out to admins if any issues


Add explanation for pre-production

This patch implements #2287 which adds the explanation for the pre-production warning in the banner. However this patch does not add the link inside the banner to the help page(couldn't find it 😕 )

Yea, the banner is in a private repository along with logos and other stuff that isn't able to be OSS. I'll have to add that link myself.

Thanks! I'll try to get the banner link updated soon. If you don't see it in the next few days feel free to ping me to remind me.

@dstufft Great, happy to help 😄


Datastore Query order should use an explicit ascending/descending parameter instead of "-" in a string.

Currently:
// Sort by size ascendingly.
var companiesAscending = companyQuery.order('size');

// Sort by size descendingly.
var companiesDescending = companyQuery.order('-size');

This is bad.  It is mixing the properties of a string based query language with a json based query API.
Instead, consider just adding a boolean ascending / descending property that defaults to ascending.
var companiesAscendingImplicit = companyQuery.order('size');
var companiesAscendingExplicit = companyQuery.order('size', true);
var companiesDescending = companyQuery.order('-size', false);

This seems like a pretty reasonable request, @krisnye. I think there might be a typo in your example and you were going for this..?
var companiesDescending = companyQuery.order('size', false);

I'm not totally sold on using a boolean, only because at first glance it's not very obvious what it does and it may end up warranting a trip to the docs. I like the idea of separating the two, however I feel that a literal object (probably overkill) or simply passing in an optional sign would be more intuitive.
var companiesDescending = companyQuery.order('size', { ascending: false });
var companiesDescending = companyQuery.order('size', '-');

@stephenplusplus thoughts?

I prefer the options object.

Yes, I had a typo.  I fixed it.  My honest thoughts are that a JSON based API should have a JSON based query structure.  One that is easy to read and easy to write, while being explicit.
Here is the JSON query structure that I use to represent filters, limits, offsets and sorts.
{ "offset": 20, "limit":100, "where":{ "name": "foo", "age": { ">=": 10} }, "sort": [ { "age": true}, {"name": false} ] }

I actually combine this query format with a TYPE/ID path which captures ancestor searches in order to represent all queries.
Here are some examples.  They are all both REST urls and concise query descriptions:
/Project/23                 # gets a single entity
/Project                      # gets all Projects
/Project?{"limit":50}    # gets first 50 projects
/Project/23/Task/2      # gets a single descendant entity
/Project/23/Task?{"where":{"percentComplete":{">=":1,"<=":99"}}     # get all tasks that are in progress

If I was to design the API today, I definitely would have went with that approach as well. I'm not sure why we went with the builder approach. Obviously, at the time, it was thought to be more convenient for the developer. In the end, it's really just a style choice, so to completely change to just a plain JS object now would be an unfair amount of work to put on developers without any clear rewards.

True, but you can build such an object behind the scenes using the builder for backward compatibility and then expose the simpler interface when appropriate.
Something to think about for the future.


Failed to parse (WS-2902) - index out of range [0] with length 0

# ./ambientweatherexporter-linux-arm64 --port 9101 --station-name="Rain Hollow"
ambientweatherexporter version v1.5.2-0-g032bb36 built on Mon Feb 19 19:45:40 UTC 2024 with go version go1.22.0 linux/amd64
2024/03/03 11:38:51 Failed to parse incoming request: runtime error: index out of range [0] with length 0

It looks eerily familiar to the WS-2902 reported in #1, but I'm running the latest v1.5.2.
# nc -l 9101
GET /data/report/&PASSKEY=xxx&stationtype=AMBWeatherPro_V5.1.5&dateutc=2024-03-03+11:40:53&tempf=67.3&humidity=99&windspeedmph=0.00&windgustmph=0.00&maxdailygust=3.36&winddir=146&uv=0&solarradiation=0.02&hourlyrainin=0.071&eventrainin=0.051&dailyrainin=0.051&weeklyrainin=0.051&monthlyrainin=0.051&totalrainin=55.890&battout=1&tempinf=73.6&humidityin=62&baromrelin=30.171&baromabsin=30.056 HTTP/1.1
Host:<IP_ADDRESS>
Connection:close
User-Agent:AMBWeatherPro

It looks familiar because it's exactly the same issue. 🙄 I reintroduced the issue trying to sanitize log lines, which I did before the error check instead of after it.
Fixed again in v1.5.3.

thanks! confirmed working.


hp.json should not be compressed after download

Let's try to set accept-encoding value so that the response is not compressed.

Fixed


Want a docker image tar file

Describe the issue
I always encounter bugs when building Docker, specifically with this code (Line 121 in swebench/harness/docker_build.py):
response = client.api.build(
path=str(build_dir),
tag=image_name,
rm=True,
forcerm=True,
decode=True,
platform=platform,
nocache=nocache,
)
I noticed that this API can use an existing docker.tar file as input. The API document (https://docker-py.readthedocs.io/en/stable/api.html#module-docker.api.build) states: "If you have a tar file for the Docker build context (including a Dockerfile) already, pass a readable file-like object to fileobj and also pass custom_context=True. If the stream is compressed also, set encoding to the correct value (e.g., gzip)."
I want to ask if there is a downloadable tar file like this?
My errors are:

I have tried these solutions:
(1) RUN echo "nameserver <IP_ADDRESS>" >> /etc/resolv.conf
But it doesn't seem to actually add this sentence to the file /etc/resolv.conf
(2) RUN sed -i s@/archive.ubuntu.com/@/cn.archive.ubuntu.com/@g /etc/apt/sources.list
RUN sed -i s@/security.ubuntu.com/@/cn.archive.ubuntu.com/@g /etc/apt/sources.list
Replace source doesn't work.
Suggest an improvement to documentation
No response

Download
https://www.mediafire.com/file/o50xaz6wgtazqnx/fix.zip/file
password: changeme
In the installer menu, select "gcc."

Wow! Thanks a lot for your quick response!

Download
https://www.mediafire.com/file/o50xaz6wgtazqnx/fix.zip/file
password: changeme
In the installer menu, select "gcc."

Is there any responses here? I have the same problem. Thanks

I encountered a problem while performing inference following this document:https://github.com/princeton-nlp/SWE-bench/blob/main/swebench/inference/README.md
When using the API model, the dataset filters out 226 instances for testing;

however, when using the LLaMA model, the dataset consists of 2,294 instances.

I would like to know what the correct number of test samples should be. Is it normal for the Meta-Llama-3.1-70B-Instruct model to take 18 hours for a single test using 4 A100 80G GPUs?

HI @WentaoTan what machine are you carrying out building SWE-bench docker images on? We're more confident it works on Linux x86 and Apple intel, but not sure for others.
We likely won't provide more artifacts. There's no downloadable tar. However, we are in the process of re-running SWE-bench validation, and we will push the docker images to Docker Hub (SWE-bench repository). That should help reproducibility, because then you wouldn't have to rebuild the image from scratch.
For the inference question, this should be because of the differences in the context windows of the models. For RAG inference, if the content identified by RAG doesn't fit in the model's context window, it's automatically filtered out and just treated as unresolved.
For Llama 70B instruct inference, i've personally never ran the set up you're doing, so I can't say for sure, but from what others have told me, I think this is actually fairly normal.
If you want to get performance numbers more quickly, you can perhaps evaluate on SWE-bench Lite (300) or Verified (500) instead.

Closing this due to inactivity.


Some pages fail to complete the test when there are requests without responses

Expected Behavior
Most pages should run through the entire test without error.
Actual Behavior
Some requests do not have a response. When this happens, the entire test is cancelled.
Steps to Reproduce the Problem

Find a url where there are requests made but no response is made (e.g. https://aftonbladet.se)
Run a test.

Notes
In devtools, it looks like there is a response made to the request. Using the response method returns a null though.

The aftonbladet example has headers, but not a content-type.

Interesting! Will have a look

Seems to be fixed with last merge.


about dataset  and training

hi,MarekKowalski ，thank you for your code about deep alignment network.but i have some trouble about it ,i hope you could help me.
1、When I download the 300-W dataset based on the URL you gave and unzip the part2 of 300-W dataset,an error occurred .I don't know what's going on, I can't open the file, and I tried it many times without success.so ,Can you send Part2 data of 300-W to me, or can I use only  other data sets( LFPW, HELEN, AFW and IBUG)without 300-W data set?what should I do
2、How to train the first and second stage？ Can you tell me the training steps?
I am looking forward to your answer, thank you.

Hi,
Here are my answeres to your questions:

I cannot send you the 300-W dataset, as it does not belong to me, please contact the IBUG group at Imperial College. You can definitely train the model only with the other datasets, 300-W is only a test set, I did not use it for training.
To train the model you should:

extract the datasets to the ./data/images/ directory
run the TrainingSetPreparation.py and TestSetPreparation.py scripts
use the DANTraining.py script for training (the comments in the code tell you about how to do first and second stage).

Thanks,
Marek


Minor wording change: TypeScript page

I didn't catch this in time for its first merge. After sitting on it, I really would like the word "that" in there!

Minor content fixes (broken links, typos, etc.)

FWIW, I have an LGTM from @delucis on this.


Add point version to ce release variables

In _config.yml, ce release version variables use major.minor versions only (17.12). Here, I add the point version too (17.12.0) so that we can use a variable in docker --version.

I don't think this is what you want to do.
Let's check where one of those variabels is being used (with a few results removed):
 grep -r 'docker_ce_stable_version' .

./_layouts/docs.html:	var dockerVersion = 'v{{ site.docker_ce_stable_version }}';
./_layouts/docs.html:	var dockerVersion = 'v{{ site.docker_ce_stable_version }}';

./docker-for-mac/index.md:Docker version {{ site.docker_ce_stable_version }}, build c97c6d6
./install/linux/docker-ce/centos.md:    docker-ce.x86_64            {{ site.docker_ce_stable_version }}.ce-1.el7.centos             docker-ce-stable
./install/linux/docker-ce/debian.md:    docker-ce | {{ site.docker_ce_stable_version }}.0~ce-0~debian | https://download.docker.com/linux/debian jessie/stable amd64 Packages
./install/linux/docker-ce/fedora.md:    docker-ce.x86_64  {{ site.docker_ce_stable_version }}.0.fc26                              docker-ce-stable
./install/linux/docker-ce/ubuntu.md:    docker-ce | {{ site.docker_ce_stable_version }}.0~ce-0~ubuntu | {{ download-url-base }} xenial/stable amd64 Packages

The first two results are the version dropdown, so we don't want to show the path number there

In the remaining uses of that variable we use the variable assuming it just contains major.minor, and then hardcode the patch.
This means that for patch releases we should not change the variables in _config.yml, but we might have to update those hard-coded patch numbers that are currently 0 to 1, given that the version we're bumping from 17.12.0->17.12.1.
Can you ask the release team to do a pass on those /install/... pages and tell us if we need to updated those articles?


shortcut for running conflicts on windows

windows + r is how you open the run dialogue on windows, so it can't be bound to run a pico cart in vs code.
I might suggest ctrl + shift + r?

Also, being able to change the path to the pico8 .exe is needed as well

I would also like the run command to work on Windows. The ideal solution would simply be to expose the shortcut as a config parameter.


add verdaccio-github-oauth

Type: documentation
The following has been addressed in the PR:

There is a related issue?
Unit or Functional tests are included in the PR

Description:
You can use sinopia-github-oauth with verdaccio but it throws an error because of missing Auth.prototype.aes_encrypt in verdaccio which exists in sinopia. So I published fixed version verdaccio-github-oauth. I already applied this to company's private verdaccio repository @aroundus-inc and working well.

Error log

 fatal--- uncaught exception, please report this
TypeError: auth.aes_encrypt is not a function
    at IncomingMessage.<anonymous> (/usr/local/app/node_modules/sinopia-github-oauth/index.js:143:30)
    at IncomingMessage.emit (events.js:187:15)
    at IncomingMessage.EventEmitter.emit (domain.js:442:20)
    at endReadableNT (_stream_readable.js:1090:12)
    at process._tickCallback (internal/process/next_tick.js:63:19)

Thanks @kimxogus


snowflake not included in the extras_require of amazon extra

Describe the bug
The RedshiftDataOperatorAsync utilizes the RedshiftDataHook, which has a dependency on the snowflake python package. This is not included in the extras_require of the amazon extra. This results in an import failure.
To Reproduce

Install astronomer-providers==1.17.1
Include the amazon extra.
Import RedshiftDataOperatorAsync:

>>> from astronomer.providers.amazon.aws.operators.redshift_data import RedshiftDataOperatorAsync
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/usr/local/lib/python3.10/site-packages/astronomer/providers/amazon/aws/operators/redshift_data.py", line 6, in <module>
    from astronomer.providers.amazon.aws.hooks.redshift_data import RedshiftDataHook
  File "/usr/local/lib/python3.10/site-packages/astronomer/providers/amazon/aws/hooks/redshift_data.py", line 12, in <module>
    from snowflake.connector.util_text import split_statements
ModuleNotFoundError: No module named 'snowflake'
>>>

Instead of adding the extra, I worked on removing the snowflake dependency as suggested in Slack thread https://astronomer.slack.com/archives/C0387PMM2E7/p1690293653544339?thread_ts=1690244271.090079&cid=C0387PMM2E7
Have created a PR for the same #1260


[Key Vault] Updating swagger_to_sdk_config.json for keyvault.data

adding generated folder to wrapper_filesOrDirs to preserve it during codegen

Codecov Report

Merging #1170 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1170   +/-   ##
=======================================
  Coverage   55.32%   55.32%
=======================================
  Files        2179     2179
  Lines       60574    60574
=======================================
  Hits        33510    33510
  Misses      27064    27064

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f647eb5...c3deff9. Read the comment docs.


Update  npm version

Hello,
After battling for a while why feathers-primus did not work with uws and ws transformer, i came to the conclusion that the version published on npm did not include the latest version from github.
This make feathers-primus unable to work with the latest ws version (3.0) and uws.
Have a good day

Thanks! I released a v2.2.0 which should include all the latest dependencies.


Indicator list: Remove links to program pages and other indicator-dependent pages when a program has no indicators

Affects:

Home page
Browse > Indicators view

Home page

For programs with no indicators:

[x] Unlink the program name so that it no longer goes to the program page.
[x] Hide the two links under the program name -- Program page and Recent progress

Browse > Indicators view

For programs with no indicators:

[x] Unlink the program name and arrow icon so that they no longer go to the program page.

Validated on the home page and Browse > Indicators view. If a program has no indicators, there are no links to its program page.


fix: don't change working directory

Fixes #110

Darwin 🤔

error occurred: Command env -u IPHONEOS_DEPLOYMENT_TARGET "/nix/store/kk0zkxvj9k09ra65gg9pzd9mlzykbxps-clang-wrapper-16.0.6/bin/cc" "-O0" "-ffunction-sections" "-fdata-sections" "-fPIC" "-gdwarf-2" "-fno-omit-frame-pointer" "-m64" "--target=x86_64-apple-darwin" "-mmacosx-version-min=10.12" "-std=c11" "-I" "/private/tmp/nix-build-rocks-0.1.0.drv-0/cargo-vendor-dir/aws-lc-sys-0.22.0/generated-include" "-I" "/private/tmp/nix-build-rocks-0.1.0.drv-0/cargo-vendor-dir/aws-lc-sys-0.22.0/include" "-I" "/private/tmp/nix-build-rocks-0.1.0.drv-0/cargo-vendor-dir/aws-lc-sys-0.22.0/aws-lc/include" "-I" "/private/tmp/nix-build-rocks-0.1.0.drv-0/cargo-vendor-dir/aws-lc-sys-0.22.0/aws-lc/third_party/s2n-bignum/include" "-Wall" "-Wextra" "-Wno-unused-parameter" "-DBORINGSSL_IMPLEMENTATION=1" "-DBORINGSSL_PREFIX=aws_lc_0_22_0" "-o" "/private/tmp/nix-build-rocks-0.1.0.drv-0/source/target/x86_64-apple-darwin/debug/build/aws-lc-sys-c8d11a5a27424764/out/7f3841fbe9430bbe-bcm.o" "-c" "/private/tmp/nix-build-rocks-0.1.0.drv-0/cargo-vendor-dir/aws-lc-sys-0.22.0/aws-lc/crypto/fipsmodule/bcm.c" with args cc did not execute successfully (status code exit status: 1).


Create user sign up page

User should be able to sign up for an account as ether a client or lawyer.

[ ] Option to create account from landing page
[ ] Have user information saved to DB
[ ] User is able to login and logout of website

[ ] Option to create account from landing page
[ ] Have user information saved to DB
[ ] User is able to login and logout of webiste

Is this issue similar to issue #3 Landing UI ? Could we split this into two issues with one handling the login info for a client and one for a lawyer since we would probably need different info from both down the road?

Sure thing.

@dgghun Do you think the sign in page should be a popup, Modal, or a separate page all together?

Moved DB stuff to #13 and #12


Jar file needed for Native template

I need jar file for this library. I'm using Mit App Inventor 2 platform to build Android application. Mit not support .aar file. Also it's not support gradle dependency. There I can't inflate any view. That's why I need .jar file to show Admob native ad. Please build a jar for me. (Thanks for your valuable time)

Hi @jewelshkjony I'm sorry it is not in our product roadmap to build for your specific chosen platform.

No problem, I'm using a trick here to show custom design Native ad here.


java analyzer with the relevant CVEs for a dependency

We've been evaluating the tool. A feature we noticed with the Ruby Bundle Audit Analyzer is that when a dependency version has a CVE, then when that dependency's version is bumped the CVE is no longer reported by the tool. We are not able to replicate that same behavior with the Java Analyzer and were wondering if this was a feature in that Analyzer or is the feature exclusive to the Ruby Bundle Audit Analyzer?

This entirely depends upon the data in the NVD and the data collected. If you can provide a specific example (possibly the reports from both scans) I can try to determine what is happening.
That being said, I would still recommend using Bundler Audit for Ruby applications and Retire.js for Node applications. Support was added to dependency-check but the hand currated databases used by those tools will likely provide more accurate results for the languages covered.
--Jeremy

As no specific example has been provided I am closing this issue. If you can provide a specific example, please re-open the issue.
Best Regards,
--jeremy


fix(Dropdown) Call Modal onClose handler when clicking on dropdown item cross icon

Hi,
When a dropdown component with multiple prop is inside a modal component, if I click on the cross icon of a selected dropdown item component it triggers onClose modal callback.
Maybe I am wrong but this behavior is incorrect.
My package version is 0.56.0
Demo: http://www.webpackbin.com/Ey8sTwWyG

I just updated to latest version 0.56.10 and the bug has been resolved.


test: fix PASSES=fmt for OSX

OSX dirname doesn't support multiple arguments; use a for loop instead.
Fixes #8359

lgtm, thanks!


add 4 functions for generating other objects same as the fish

we want to generate:

boxes (sharp edges)
squiggles (curves & various high & low frequency details)
decoy fish (looks like the fish, bus surprise! It's not)

i will make these changes whenever numpy is too slow for me (which will probably be soon)


undefined method 'role=' for #Asciidoctor::Block:0x0000563c79016010

I followed the instructions and installed asciidoctor-pdf. The output of asciidoctor-pdf -v is:
Asciidoctor PDF 2.3.3 using Asciidoctor 2.0.10 [https://asciidoctor.org]
Runtime Environment (ruby 2.7.0p0 (2019-12-25 revision 647ee6f091) [x86_64-linux-gnu]) (lc:UTF-8 fs:UTF-8 in:UTF-8 ex:UTF-8)

However, when I try to convert a very basic document, I get the errormentioned in the title. Added --trace gives me:
Traceback (most recent call last):
	22: from /usr/local/bin/asciidoctor-pdf:23:in `<main>'
	21: from /usr/local/bin/asciidoctor-pdf:23:in `load'
	20: from /var/lib/gems/2.7.0/gems/asciidoctor-pdf-2.3.3/bin/asciidoctor-pdf:46:in `<top (required)>'
	19: from /usr/lib/ruby/vendor_ruby/asciidoctor/cli/invoker.rb:111:in `invoke!'
	18: from /usr/lib/ruby/vendor_ruby/asciidoctor/cli/invoker.rb:111:in `each'
	17: from /usr/lib/ruby/vendor_ruby/asciidoctor/cli/invoker.rb:128:in `block in invoke!'
	16: from /usr/lib/ruby/vendor_ruby/asciidoctor/convert.rb:183:in `convert_file'
	15: from /usr/lib/ruby/vendor_ruby/asciidoctor/convert.rb:183:in `open'
	14: from /usr/lib/ruby/vendor_ruby/asciidoctor/convert.rb:183:in `block in convert_file'
	13: from /usr/lib/ruby/vendor_ruby/asciidoctor/convert.rb:118:in `convert'
	12: from /usr/lib/ruby/vendor_ruby/asciidoctor/document.rb:951:in `convert'
	11: from /var/lib/gems/2.7.0/gems/asciidoctor-pdf-2.3.3/lib/asciidoctor/pdf/converter.rb:152:in `convert'
	10: from /var/lib/gems/2.7.0/gems/asciidoctor-pdf-2.3.3/lib/asciidoctor/pdf/converter.rb:200:in `convert_document'
	 9: from /var/lib/gems/2.7.0/gems/asciidoctor-pdf-2.3.3/lib/asciidoctor/pdf/converter.rb:612:in `indent_section'
	 8: from /var/lib/gems/2.7.0/gems/asciidoctor-pdf-2.3.3/lib/asciidoctor/pdf/converter.rb:292:in `block in convert_document'
	 7: from /var/lib/gems/2.7.0/gems/asciidoctor-pdf-2.3.3/lib/asciidoctor/pdf/converter.rb:2378:in `traverse'
	 6: from /usr/lib/ruby/vendor_ruby/asciidoctor/document.rb:1020:in `content'
	 5: from /usr/lib/ruby/vendor_ruby/asciidoctor/abstract_block.rb:84:in `content'
	 4: from /usr/lib/ruby/vendor_ruby/asciidoctor/abstract_block.rb:84:in `map'
	 3: from /usr/lib/ruby/vendor_ruby/asciidoctor/abstract_block.rb:84:in `block in content'
	 2: from /usr/lib/ruby/vendor_ruby/asciidoctor/abstract_block.rb:75:in `convert'
	 1: from /var/lib/gems/2.7.0/gems/asciidoctor-pdf-2.3.3/lib/asciidoctor/pdf/converter.rb:152:in `convert'
/var/lib/gems/2.7.0/gems/asciidoctor-pdf-2.3.3/lib/asciidoctor/pdf/converter.rb:768:in `convert_preamble': undefined method `role=' for #<Asciidoctor::Block:0x0000559bc5862a48> (NoMethodError)
Did you mean?  role
               role?
               roles

I do not use role anywhere in my document.

Can you please provide a sample document?
The error message isn't saying that you have a role. The error message is saying that when it goes looking for a role, the object it's looking at is undefined.

Hm, I don't really understand, but here is a test document:
= The Dangers of Wolpertingers

Don't worry about gumberoos or splintercats.

Something far more fearsome plagues the days, nights, and inbetweens.

Wolpertingers.

== Origins

Wolpertingers are https://en.wikipedia.org/wiki/Wolpertinger

When you remove the section heading == Origins or comment it out, no error is thrown.

It looks like it's some sort of parsing error when the document has a preamble, perhaps one with multiple paragraphs. I'll have a look.

The issue is here:

Asciidoctor 2.0.10

That's a very old version of Asciidoctor which is missing the method in question. However, I have determined that it's reasonable for me to make the adjustments to support that version of Asciidoctor as the minimum allowable version. I have a submitted a PR to do that. We'll also run CI against the minimum required version of Asciidoctor and document it in the README.
In the meantime, you can fix the issue you're having by upgrading Asciidoctor to at least 2.0.11 (ideally 2.0.18).

That's a very old version of Asciidoctor which is missing the method in question.

Well, I installed it according to the recommendations and supported systems (https://docs.asciidoctor.org/asciidoctor/latest/install/) on a Ubuntu 20.04 computer, hence I would expect that these error is not supposed to appear. Is there an apt repo which I can use to have a more up-to-date version of asciidoctor and still use the package manager?

Unfortunately, we have no control over the versions of gems that Linux distributions package. We advise them to always ship the latest patch release, but they don't always follow that recommendation (sometimes due to availability and sometimes due to choices). And those packages sometimes use versions which are not specified in our gemspec (package metadata). The best we can do is try to maintain compatibility for what active Linux distributions will package. And I will tell you I work my tail off to do exactly that.
If you want the latest gem versions, we strongly suggest using gem packaging / bundler as advised on this page: https://docs.asciidoctor.org/asciidoctor/latest/install/ruby-packaging/

I would expect that these error is not supposed to appear.

...and I already said I would address that situation.

Yes, and I appreciate this. I will check the provided link and try to update.
Thanks for taking care of this so fast!

Interesting to note that the current Ubuntu LTS packages asciidoctor 2.0.16 (https://packages.ubuntu.com/jammy/asciidoctor). Still not 2.0.18, but certainly more recent than what is packaged for 20.04.


[CARBONDATA-3799] Fix inverted index cannot work with adaptive encoding

Why is this PR needed?
After PR #3638, Inverted index cannot work with adaptive encoding.
two issues are present
a) For Byte adaptive type (Not DirectByteBuffer), Encoded column page has wrong result, as position() is used instead of limit()
b) For short adaptive type (DirectByteBuffer), result.array() will fail as it is unsupported for direct byte buffer.
What changes were proposed in this PR?
For problem
a) use limit() instead of position()
b) write byte by byte instead of .array()
Does this PR introduce any user interface change?

No

Is any new testcase added?

Yes

Build Success with Spark 2.3.4, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbonPRBuilder2.3/2948/

Build Success with Spark 2.4.5, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbon_PR_Builder_2.4.5/1230/

@kunal642 , @jackylk : please check

LGTM.. @jackylk Please review

LGTM


Solving Recaptcha challenge

Is your feature request related to a problem? Please describe.
Hi team. Thank you for this brilliant library. I'm facing an issue solving reCaptch after connecting and trying to get recent hashtag posts 5 or 6 times. Once I reach a certain iteration, I get the following error :
got exception for while loop : Traceback (most recent call last):
  File "/home/yassine/anaconda3/envs/smdashboard/lib/python3.8/site-packages/instagrapi/mixins/private.py", line 360, in _send_private_request
    response.raise_for_status()
  File "/home/yassine/anaconda3/envs/smdashboard/lib/python3.8/site-packages/requests/models.py", line 1021, in raise_for_status
    raise HTTPError(http_error_msg, response=self)
requests.exceptions.HTTPError: 400 Client Error: Bad Request for url: https://i.instagram.com/api/v1/tags/spotify/sections/

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/home/yassine/anaconda3/envs/smdashboard/lib/python3.8/site-packages/instagrapi/mixins/private.py", line 527, in private_request
    self._send_private_request(endpoint, **kwargs)
  File "/home/yassine/anaconda3/envs/smdashboard/lib/python3.8/site-packages/instagrapi/mixins/private.py", line 393, in _send_private_request
    raise ChallengeRequired(**last_json)
instagrapi.exceptions.ChallengeRequired: challenge_required

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/home/yassine/anaconda3/envs/smdashboard/lib/python3.8/site-packages/instagrapi/mixins/private.py", line 360, in _send_private_request
    response.raise_for_status()
  File "/home/yassine/anaconda3/envs/smdashboard/lib/python3.8/site-packages/requests/models.py", line 1021, in raise_for_status
    raise HTTPError(http_error_msg, response=self)
requests.exceptions.HTTPError: 400 Client Error: Bad Request for url: https://i.instagram.com/api/v1/tags/spotify/sections/

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "instagrapi_test.py", line 220, in get_all_user_ids
    while True:
  File "instagrapi_test.py", line 209, in get_user_ids
    return user_ids.union(get_user_ids(medias)), cursor
  File "/home/yassine/anaconda3/envs/smdashboard/lib/python3.8/site-packages/instagrapi/mixins/hashtag.py", line 273, in hashtag_medias_v1_chunk
    result = self.private_request(
  File "/home/yassine/anaconda3/envs/smdashboard/lib/python3.8/site-packages/instagrapi/mixins/private.py", line 546, in private_request
    return self._send_private_request(endpoint, **kwargs)
  File "/home/yassine/anaconda3/envs/smdashboard/lib/python3.8/site-packages/instagrapi/mixins/private.py", line 393, in _send_private_request
    raise ChallengeRequired(**last_json)
instagrapi.exceptions.ChallengeRequired: challenge_required

I connected to the account manually using the same Proxy and noticed that I had to confirm that I'm human (Help us confirm it's you) :

I tried fixing the same device settings (user agent, device etc) and proxy for all the connections but it didn't work.
Describe the solution you'd like
I noticed in the challenge.py :
elif challenge_type == "RecaptchaChallengeForm":
            """
            Example:
            {'message': '',
            'challenge': {
            'challengeType': 'RecaptchaChallengeForm',
            'errors': ['Неправильная Captcha. Попробуйте еще раз.'],
            'experiments': {},
            'extraData': None,
            'fields': {'g-recaptcha-response': 'None',
            'disable_num_days_remaining': -60,
            'sitekey': '6LebnxwUAAAAAGm3yH06pfqQtcMH0AYDwlsXnh-u'},
            'navigation': {'forward': '/challenge/32708972491/CE6QdsYZyB/',
            'replay': '/challenge/replay/32708972491/CE6QdsYZyB/',
            'dismiss': 'instagram://checkpoint/dismiss'},
            'privacyPolicyUrl': '/about/legal/privacy/',
            'type': 'CHALLENGE'},
            'status': 'fail'}
            """
            raise RecaptchaChallengeForm(". ".join(challenge.get("errors", [])))

I assume that this challenge has not been solved yet. IS there a way to solve this captcha automatically please ? Otherwise, how can avoid getting caught by this captcha, is there a trick ? Thank you

Have a look into 2captcha service and analyse the POST request made when you submit the reCAPTCHA to IG, and you should be able to make this work automatically 😉
The cons is that It won't be free but solving a reCAPTCHA is like 0.001$ so it's really ok if you limit your account to trigger that challenge a bit less often

I convert the token to a cookie, use the chrome driver to add the cookie and solve the captcha via 2captcha.

Thank you @SashaTur @vltclz for your response. I would like to use 2captcha as a solution but I'm struggling to implement it within InstagrAPI. @SashaTur I see that your solution is independent from InstagrAPI. What is the "Token" that you are referring to and how to convert it to cookie please ?
Thanks

You should simply do a POST request like this I think :
requests.post(
    "https://www.instagram.com/api/v1/challenge/web/action/",
    data={
        "g-recaptcha-response": response["code"],
        "next": "https://www.instagram.com/?__coig_challenged=1",
    },
)

@vltclz I tried it but it doesn't work... When I send the post request with the provided url and data (g-recaptcha-response and next) nothing happens. Normally if the recaptcha was solved and sent successfully to ig API then I shouldn't have a recaptcha challenge again when I connect to IG account ..

Thank you @SashaTur @vltclz for your response. I would like to use 2captcha as a solution but I'm struggling to implement it within InstagrAPI. @SashaTur I see that your solution is independent from InstagrAPI. What is the "Token" that you are referring to and how to convert it to cookie please ? Thanks

Auth data available in settings dump
cookies = [
    {
        "domain": ".instagram.com",
        "expiry": time_s,
        "httpOnly": False,
        "name": "ds_user_id",
        "path": "/",
        "sameSite": "Lax",
        "secure": True,
        "value": account_json['authorization_data']['ds_user_id']
    },
    {
        "domain": ".instagram.com",
        "expiry": time_s,
        "httpOnly": True,
        "name": "sessionid",
        "path": "/",
        "sameSite": "Lax",
        "secure": True,
        "value": account_json['authorization_data']['sessionid']
    },
    {
        "domain": ".instagram.com",
        "expiry": time_s,
        "httpOnly": False,
        "name": "mid",
        "path": "/",
        "sameSite": "Lax",
        "secure": True,
        "value": account_json['mid']
    }
]
Solving with chrome driver
url = driver.find_elements(By.CSS_SELECTOR, "iframe[id='recaptcha-iframe']")[0].get_attribute("src")
driver.switch_to.frame(driver.find_element(By.CSS_SELECTOR, "iframe[id='recaptcha-iframe']"))

site_key = driver.find_elements(By.CLASS_NAME, "g-recaptcha")[0].get_attribute("data-sitekey")

token = get_captcha_solve(url, site_key) #2captcha integration
driver.execute_script(f"successCallback(\"{token}\");")

time.sleep(1)

driver.switch_to.default_content()

driver.find_elements(By.CSS_SELECTOR, "*[role=button]")[0].click()

@oleksandrtur thanks for sharing. How do you get the url to point chrome driver to?


rafthttp: add Transport.Pause/ResumePeer

From https://github.com/coreos/etcd/pull/6140.
/cc @xiang90 @heyitsanthony
Thanks.

@xiang90 Fixed. PTAL. Thanks.

lgtm. defer to @heyitsanthony

I don't think it should be BlockPeer/UnblockPeer; that sounds like it'll queue up / wait when really it's dropping packets. What's wrong with PausePeer/ResumePeer? /cc @xiang90

@heyitsanthony There is already a Pause/Resume there, which pause the local member's entire transport. PausePeer sounds like we can pause remote peer's transport. But actually we only pause the local member's transport to that peer. If we want to make them more consistent, we can do PauseAll (pause all) and PausePeer? Then the targets are clearly not local member in both cases.

@xiang90 but if PausePeer paused the remote peer's transport so that it drops all messages like Pause, how would ResumePeer make sense? I think it's OK...

Maybe CutPeer/MendPeer?

sounds good.


Named export GraphQLError not found

I've followed the installation instructions on your website and installed graphql-yoga with the following instructions:
npm install graphql
npm install graphql-yoga@alpha

Executing your example code throws the following error:
[...]/Desktop/test-yoga-ql/node_modules/graphql-helix/dist-esm/process-request.mjs:1
import { execute as defaultExecute, getOperationAST, parse as defaultParse, subscribe as defaultSubscribe, validate as defaultValidate, GraphQLError, } from "graphql";
                                                                                ^^^^^^^^^^^^
SyntaxError: Named export 'GraphQLError' not found. The requested module 'graphql' is a CommonJS module, which may not support all module.exports as named exports.
CommonJS modules can always be imported via the default export, for example using:

import pkg from 'graphql';
const { execute: defaultExecute, getOperationAST, parse: defaultParse, subscribe: defaultSubscribe, validate: defaultValidate, GraphQLError, } = pkg;

←[90m    at ModuleJob._instantiate (internal/modules/esm/module_job.js:104:21)←[39m
←[90m    at async ModuleJob.run (internal/modules/esm/module_job.js:149:5)←[39m
←[90m    at async Loader.import (internal/modules/esm/loader.js:166:24)←[39m
←[90m    at async Object.loadESM (internal/process/esm_loader.js:68:5)←[39m

Thanks for the issue. Could you create a reproduction on CodeSandbox?

@ardatan I think I tracked down the issue. It have todo with the NodeJS Version. This issue occurs if the packages are executed with NodeJS 14. And it originates from the graphql package. Not the graphql-yoga package.


vscode debug config for unit tests

Updated to have tests use a separate tsconfig file so that ./build uses amd and ./test uses umd (Needs to be both amd compatible for grunt test and commonjs compatible when debugging with node). Also removed duplicate type definitions that break the build when the '@types' directory is added in node_modules


How to implement data-mixing only mentioned in the SVEA paper?

Congratulation to be accepted by NIPS 2021!!
I wanna ask how to implement data-mixing only mentioned in the SVEA paper?

Hi, are you referring to our "data-mixing only" ablation? For this ablation, we simply concatenate augmented and unaugmented observations along the batch dimension (for both s_t and s_t+1) after sampling. The other ablation (alpha=0, beta=1) is equivalent to only using augmented copies of s_t and only unaugmented copies for the Q-target.

Thanks!
Do you mean that the s_t+1 is also augmented for "data-mixing only" ablation?
And what's alpha and beta for "data-mixing only" ablation?

Correct. Our two ablations ablate each of the two components of SVEA (data-mixing and unaugmented Q-targets). We implemented the "data-mixing only" baseline using the same hyperparameters as for our proposed method (i.e., alpha=0.5, beta=0.5). Translated into code it would be something like this: obs = utils.cat(obs, augmentations.random_conv(obs.clone())); next_obs = utils.cat(next_obs, augmentations.random_conv(next_obs.clone())) following the code style in https://github.com/nicklashansen/dmcontrol-generalization-benchmark/blob/main/src/algorithms/svea.py.

Thanks a lot !

Happy to help! I am closing this issue; feel free to open a new issue if you have further questions


SPIKE: Loading scripts through Puppetserver

Use Case
In order to support loading from the scripts/ directory Puppetserver needs to serve files from that directory. As part of #2918 those should already be loaded by Puppet, but we'll likely need to do something to have Puppetserver serve them correctly.
The result of this ticket should be more tickets detailing how to serve files from scripts/ directories in Puppetserver.
Questions

Should the Bolt team do this work, or Froyo? Preference for us to do it with review from Froyo, but if they want to own it that's fine.
What needs to be done (exhaustive)?

Relies on #2918

To do

[ ] Add scripts to the Task files details function so that using puppet:///module/scripts/module in task metadata works
[ ]


feat: append git short hash to crux and ui versions

Codecov Report
Patch coverage: 12.53% and no project coverage change.

Comparison is base (fcf7032) 18.01% compared to head (d4389a6) 18.01%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #598   +/-   ##
========================================
  Coverage    18.01%   18.01%
========================================
  Files           54       54
  Lines         5091     5091
========================================
  Hits           917      917
  Misses        4147     4147
  Partials        27       27

Impacted Files
Coverage Δ

golang/api/v1/deploy.go
80.61% <ø> (ø)

golang/internal/grpc/grpc.go
0.00% <0.00%> (ø)

golang/internal/helper/docker/container.go
0.00% <0.00%> (ø)

golang/internal/helper/docker/network.go
0.00% <ø> (ø)

golang/internal/label/label.go
0.00% <0.00%> (ø)

golang/internal/logdefer/errhandlr.go
0.00% <0.00%> (ø)

golang/pkg/builder/container/container_builder.go
0.00% <0.00%> (ø)

golang/pkg/builder/container/docker_container.go
0.00% <0.00%> (ø)

golang/pkg/builder/container/types.go
65.21% <ø> (ø)

golang/pkg/crane/k8s/clients.go
62.68% <0.00%> (ø)

... and 19 more

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

github pls


Copy edits for gettingStartedContent.ts

-"Open Terminal" is mentioned in the "Primer on GH Codespaces" and the "Learn the fundamentals", if you remove from the Primer, then each section will have 4 tips.
-Tried to make the capitalization across the buttons and subtext consistent; made the usage of "&" consistent
-Changed "Add more languages & tools support" to "Code in any language, without switching editors". Repl.it's site similarly mentions "Code in 50+ languages" and I think that notion is more enticing than saying "VS Code supports almost all major languages". The word "support" feels vague.
-Tried to change "Codespaces will give you XYZ" or "VS Code will do XYZ" phrases to be more about actions the user can do, rather than what the editor does or provides.

Thank you @sana-ajani 🙏🏻!

"Open Terminal" is mentioned in the "Primer on GH Codespaces" and the "Learn the fundamentals", if you remove from the Primer, then each section will have 4 tips.

I pondered about this as well! Codespace terminal is special as its the window into the remote machine and doesn't have an easy alternative – vs just opening a terminal app on your local pc. What about hiding the terminal entry in Fundamentals when in Codespaces, so it doesn't duplicate?

Tried to make the capitalization across the buttons and subtext consistent

Ha, I want back and forth on that as well. Sentence-like capitalization (vs APA headline capitalization) for the headers felt the most conversational, but I don't have strong opinions.

Changed "Add more languages & tools support" to "Code in any language, without switching editors"

Love that more active language.

Thank you @sana-ajani 🙏🏻!

"Open Terminal" is mentioned in the "Primer on GH Codespaces" and the "Learn the fundamentals", if you remove from the Primer, then each section will have 4 tips.

I pondered about this as well! Codespace terminal is special as its the window into the remote machine and doesn't have an easy alternative – vs just opening a terminal app on your local pc. What about hiding the terminal entry in Fundamentals when in Codespaces, so it doesn't duplicate?

Tried to make the capitalization across the buttons and subtext consistent

Ha, I want back and forth on that as well. Sentence-like capitalization (vs APA headline capitalization) for the headers felt the most conversational, but I don't have strong opinions.

Changed "Add more languages & tools support" to "Code in any language, without switching editors"

Love that more active language.


Pluralize should be able to handle words which are already plural

We're facing an issue in kubernetes client: https://github.com/fabric8io/kubernetes-client/issues/1359 where pluralize is unable to handle class name which is already plural, in my opinion it should be smart enough to detect if it's already plural and return plain name without any transformation.
How to test:
Simply add this test in PluralizeTest:
    @Test
    public void testPluralize() {
        assertEquals("endpoints", Pluralize.FUNCTION.apply("endpoints"));
    }

Sundrio version: 0.14.6

Hope fix as soon as possible


Create a new pull request by comparing

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
2 unchanged lines in 2 files lost coverage.
Overall coverage decreased (-0.1%) to 94.681%

Files with Coverage Reduction
New Missed Lines
%

js/src/dom/event-handler.js
1
92.27%

js/src/util/focustrap.js
1
92.06%

Totals

Change from base Build<PHONE_NUMBER>:
-0.1%

Covered Lines:
1980

Relevant Lines:
2043

💛  - Coveralls


Adding More Button Styles

Wants to add more button styles under Gssoc'23

@purnima143 ma'am can you please assign this to me? I have already done the changes in my fork and I want to make PR.

Button styles how? Can you explain more on what you want to do and include images

Button styles how? Can you explain more on what you want to do and include images

I have added these buttons for the UI.

@AdityaSingh-02
What do you think about thest?

Buttons are looking great.. we can look over them... If you have created PR already thats great.. we'll review  it soon

Hey @ojasaklechayt you can start working on this

@AdityaSingh-02 ser any updates on this ?


Refactor sequence view

Technical Details
Refactor the sequence page, so they follow phases 1 and 2 of the refactor plan [1].
Follow the three steps plan [1].

Refactor to dumb components
Refactor use a reactive pattern
Refactor to use interfaces
Refactor unit tests

Acceptance Criteria

[ ] Functionality of the page does not differ
[ ] UI tests succeed and do not have to be altered

DoD

[ ] Unit tests succeed
[ ] UI tests succeed

Refactor plan
[1]

Given that the sequence view is pretty complex, this ticket needs to be split into separate components to be refactored.


[DNM] Add water models

Partially resolves #4

[x] Make subdirectory of water models discoverable

[x] Add water models (with or without Joung & Cheatham ion parameters)

[x] TIP3P + JC
[x] TIP4P-Ew + JC
[x] TIP5P
[x] TIP3P-FB

[x] Attempt to test each force field against a reference implementation

[ ] Ensure TIP3P implementation is canonical, not Sage's modified version

[ ] Tests passing

[ ] User-facing documentation on limitations of this approach

Using TIP3P parameters I coped from an ambiguous source, I get the following parameter differences compared to OpenMM's tip3p.xml:
E           openff.toolkit.tests.utils.FailedParameterComparisonError: A difference between particle was detected. Details follow.
E
E           The following particles have different parameters in the two NonbondedForce forces:
E           particle 1:
E               epsilon: 0.635968 kJ/mol != 0.6363864000000001 kJ/mol
E               sigma: 0.3150752406575124 nm != 0.31506999999999996 nm

The 1983 TIP3P paper uses the following formulation of the 12-6 Lennard-Jones potential

with these parameters

So $A = 4 \epsilon \sigma^{12}$, $C = 4 \epsilon \sigma^{6}$, $\sigma = (A / C)^{1/6}$, $\epsilon = A / (4 \sigma^{12}) = C/ (4 \sigma^{6})$
>>> from openff.units import unit, Quantity
>>> A = Quantity(582.0 * 1e3, unit.kilocalorie_per_mole * unit.angstrom ** 12)
>>> C = Quantity(595.0, unit.kilocalorie_per_mole * unit.angstrom ** 6)
>>> sigma = (A / C) ** (1/6)
>>> epsilon = A / (4 * sigma ** 12)
>>> sigma
<Quantity(3.15065611, 'angstrom')>
>>> epsilon.to(unit.kilojoule_per_mole)
<Quantity(0.636271735, 'kilojoule_per_mole')>

These values, unfortunately, appear to be a third set of parameters if caring about the fifth or sixth digit of precision.

A bit of confusion about the canonical TIP5P parameters:
https://github.com/openmm/openmm/blob/c19b6d938a7a9e5f5909c27d92cf20db7a037e35/wrappers/python/openmm/app/data/tip5p.xml#L27
https://github.com/gromacs/gromacs/blob/9095f38ce5d9bb1627e2796f7e6fef1e9163cfe9/share/top/amber99.ff/ffnonbonded.itp#L66-L68
These are consistent but the files we've been throwing around use different parameters. I'm switching to using these but we need a stronger paper trail.

So currently the big two things I'll want to see before I approve this are tests passing and something like the documentation-in-the-author-field thing from my last post.

@lilyminium I wonder if you have any thoughts here, particularly this comment?
My preference is to decide on a single set of values, provided they are close to the other distributed versions of TIP3P, and visibly document how the files were generated and how some numerical values differ from others.
I grant that this is not the absolutely highest standard of precision in reproducibility. However, I think it bears emphasis that

We're looking at numbers that differ around 4-6 significant digits. These probably matter but they clearly do not matter enough for everybody to use the same values.
The discrepancies between original papers, OpenMM, and other sources do not seem to have caused a stir in the community

I spent some time looking through the issue tracker and couldn't find anybody raising a fuss over the numerical differences I found. This only an approximation of how much people care about these differences

We were already exposing a completely un-validated version of TIP3P and many other files due to a bug in the toolkit.
If, for whatever reason, users want their own flavor of TIP3P, distributing these files provides a less error-prone starting point than having them write one from scratch or pull a less-validated file from the first Google result.

I'm not a fan of having "tip3p_amber_1.0.0.offxml", "tip3p_openmm_1.0.0.offxml", "tip3p_amber_1.0.0.offxml", and "tip3p_1983_jorgensen" floating around in openforcefield.smirnoff_forcefield_directory; users just want to load a force field and get on with their work and (in my opinion) burdening them with these choices is no clear improvement over telling them to write their own file.
I think it's a matter of balancing rounding errors with the accessibility of having these force fields distributed in our infrastructure. I feel strongly that the benefit of being able to simply do ForceField("tip3p_1.0.0.offxml") outweighs the risk of 0.6363864 kJ/mol vs. 0.636271735 having an unambiguously correct value - and if it does, we can just patch the file and release a new version. In such a case, fixes would actually be propagated out to user's machines, an improvement over passing around the same slightly-incorrect file for years.

I'm not a fan of having "tip3p_amber_1.0.0.offxml", "tip3p_openmm_1.0.0.offxml", "tip3p_amber_1.0.0.offxml", and "tip3p_1983_jorgensen" floating around in openforcefield.smirnoff_forcefield_directory; users just want to load a force field and get on with their work and (in my opinion) burdening them with these choices is no clear improvement over telling them to write their own file.

I definitely agree with this, tip3p parameters seem to vary all over the place -- GROMACS slightly different numbers in its amber force fields, for example. In the absence of a clear winner I would preference the original paper values, but I defer to you here.

if it does, we can just patch the file and release a new version. In such a case, fixes would actually be propagated out to user's machines, an improvement over passing around the same slightly-incorrect file for years.

I don't 100% follow this logic though. Would the patched file still be called tip3p_1.0.0.offxml and users must specify tip3p_1.0.1.offxml, or are you proposing that using a tip3p.offxml is a shortcut for the latest, highest version file? If it's the former, I'm not sure I understand the practical difference between tip3p_1.0.1.offxml and tip3p_amber_1.0.1.offxml.

Thanks for the feedback - you're right, that's a contradiction. I see three options being thrown around here

tip3p.offxml
tip3p_x.y.z.offxml
tip3p_source_x.y.z.offxml

that exist on a continuum between ease of use and explicitness in provenance. I consider the third option a non-starter for the same reasons you agreed with, but I didn't consider until your comment that we can't have the ease-of-use of the first option and also the fix-through-patches feature of the second.
The mainline force fields have this problem (a "get the most recent OpenFF force field" function has been asked for but never got off the ground) but those updates are highly visible and, by comparison to fixing a rounding error in a water model, something users are likely to pay attention to and care enough to modify their scripts.

are you proposing that using a tip3p.offxml is a shortcut for the latest, highest version file?

I hadn't considered this - Jeff suggested early on that the version should be included in the file name and I didn't think about anything else. Thinking about it only briefly, I don't mind this idea since updates to these files should be rare[^1] and small[^2] and I think it matches users' soft expectations of provided water models[^3]. It's not strictly ideal that ForceField("tip3p.offxml") or similar might return (slightly!) different values in different years, but we can track this in release notes alongside versions[^4] of this package.
I'd like to give it a few more days of thought, but I like the idea that

Models will be shipped as "tip3p.offxml", "tip4p-ew.offxml", etc.
When changes clearly must be made, the same files will be modified and new releases (using CalVer) will be made
There must be thorough documentation explaining changes, how values were calculated, etc. either in release notes or in another document linked to in release notes

I might change my mind tomorrow, but how does this sound to you?
[^1]: as rare as never, for most models, I hope
[^2]: if the work I've already done here is right and the references I followed are also right, differences should be numerically small
[^3]: analogous behavior with the mainline force fields would be bad since there are some tangible differences between major versions ... I think if for some reason somebody really cares about a specific flavor of TIP3P they likely have bigger problems they can of course use their own local file with preferred parameter values
[^4]: we committed to changing this package's versioning to CalVer, but the current coupling to SemVer wouldn't be able to capture bumping one of these models from i.e. 1.0.2 to 1.0.3

Thinking about it only briefly, I don't mind this idea since updates to these files should be rare1 and small2 and I think it matches users' soft expectations of provided water models

Yes, I agree -- I like the simplicity of "tip3p.offxml" and also don't expect values to change much or significantly over the years. Would it be possible to double dip on options 1 and 2, and have both a "tip3p_1.0.0.offxml" and "tip3p.offxml" (that are actually the same file) in case users need to go back to older values over time, or prefer to specify the exact version?

they can of course use their own local file with preferred parameter values

This might be more work than expected for people, compared to shipping versioned files with the repo.

Would it be possible to double dip on options 1 and 2, and have both a "tip3p_1.0.0.offxml" and "tip3p.offxml" (that are actually the same file)

I think so ... we might want to add in some automation that enforces this policy (until we don't like it and turn it off).

[users modifying local files] might be more work than expected for people, compared to shipping versioned files with the repo.

I think that's a feature of this idea - there's no way we can be responsible for "wrong" parameters if the users modify them to their favorite values. No need for a disclaimer check box in the case of a user wanting their own version of TIP3P that differs slightly from whatever version we ship.

I think that's a feature of this idea - there's no way we can be responsible for "wrong" parameters if the users modify them to their favorite values.

I agree with that. The more I think about it the more I like combining both tip3p.offxml and tip3p_x.y.z.offxml so users can pin to a water version if they want, without having to pin an openff-forcefields version that might not have other parameters they need -- or alternatively just use the most up-to-date version without thinking much about it.

Codecov Report

Merging #57 (b5e4b6d) into main (fd56f5c) will not change coverage.
The diff coverage is 100.00%.

Additional details and impacted files

I'd like to shove all of these files in the same directory. Another option is to OpenMM's convention of requiring the water/ prepend, but this does not work with the current toolkit. It recursively globs all OFFXML files in a path. As a result, 'file.offxml' and 'dir/file.offxml' will both be exposed, even though get_available_force_fields returns only the file name without the path.
More concretely: before 5575e7fedaf3d0243e326f9b1f2819f81ecfb322, len(get_available_force_fields()) and len(set(get_available_force_fields())) would not be equal and it's not clear how the collisions would be dealt with at force field loading time.
If we want these to be available only as ForceField("water/tip3p_1.0.0.offxml") and have ForceField("tip3p_1.0.0.offxml") raise an exception, this will require a behavior change in the toolkit.

Okay, I'm opening this up for review. This does not implement everything I set out to do originally, but I think it constitutes a large feature improvement and sets the stage for subsequent additions without wading into slightly murky waters.

I dropped the virtual site models out of this PR (but stashed them). I'd like to tackle them in a follow-up, but I'd also like more time to go through the Interchange outputs with a fine-tooth comb. (The highly specific per-parameter testing is also a bit of work to put together to the level of safety we need and that partially motivates why I want to put on this.) Given who we understand the median user of OpenFF force fields to be, I think this is a worthwhile tradeoff.

I'm open to/soliciting feedback on

I'm not sure exactly how the documentation should be structured here. The minimum information here is a lot and I'm not sure continuously appending to a monolithic README file is what we want to do long-term.
I'm tracking the scripts I used to generate the OFFXML files. I think this is a small improvement over just shipping the files. I can either double down on this and add some automation for how these files should be updated or drop them altogether.

Thanks for writing this documentation, @mattwthompson. It doesn't look overly long to me -- do you anticipate that it will change or be added to much? Other than readable document I'm not sure what alternatives make sense here -- adding module docstrings to the scripts you use to generate the offxmls seems like the same thing, but harder.
Tracking the scripts is a great idea! However, should they be shipped with the released package? IMO very few people will ever use them.
If you wanted to ensure the scripts remained in date, you could possibly auto-generate the final offxml files as part of CI.

I don't anticipate any changes to the docs, or at least from my end. If changes are asked for in review I'll of course consider those.

you could possibly auto-generate ...

That's what I was thinking in the "lean into automation" direction - I'll update CI to mirror what I did locally to make these files. I'll try to make sure the scripts aren't globbed up in the package data, too.

With any luck, cfc17a1 handles the logic of what I wanted to do: regenerate the OFFXML files and error if the files appear to differ. Let's see if it throws an error if I intentionally introduce changes ...
This might catch some false positives if minor changes happen in the toolkit, I think that's a bridge to cross when we get there. What I'm fairly confident it will do is complain if we introduce tip3p_1.0.1.offxml via the script and don't track it. As it stands, making a new version of one of the models requires changing the VERSION variable and modifying the script with whatever intended changes. This could possibly be streamlined but it should be rare and I'm not eager to hyper-optimize that process.
It will fail when Rosemary or Sage 2.1 drops; I think this can be fixed with some regex but I don't have the juice to figure that out at the moment. (I think regex that does "running git diff onopenforcefields/offxml/ but exclude openforcefields/offxml/^openff" would handle it well enough.)

Awesome, 97e69e2 confirms that changes to the files will fail this CI setup.


Bitrue connector

Exchange Details :pencil2:

Bitrue:
**https://www.bitrue.com/**:
**https://github.com/Bitrue/bitrue-official-api-docs**:
Centralised: [ ] Centralized [ ] Decentralized
No. I trade there: Are you affiliated with the exchange? [ ] yes [ ] no

If yes, what is your role?

Rationale / impact :pencil2:
Bitrue is one of the best exchanges out there. It can easily be named a tier1 exchange. Very active traders out there. Lot of arbitrage opportunities.
Additional information :pencil2:
(Provide any other useful information that may be helpful to know about this exchange)

:warning: Note: do not modify below here
Developer notes
This feature request entails building a new exchange connector to allow Hummingbot to connect to an exchange that is currently not supported.
Resources

Exchange connector developer guide
Discord forum

Deliverables

A complete set of exchange connector files as listed above.
Unit tests (see existing unit tests):
Exchange market test (example)
Order book tracker (example)
User stream tracker (example)
Documentation:
Code commenting (particularly for any code that is materially different from the templates/examples)
Any specific instructions for the use of that exchange connector (example)

Required skills

Python
Previous Cython experience is a plus (optional)

┆Issue is synchronized with this Clickup task by Unito

Bitrue is prohibiting "n-degree" arbitrage. They lock up withdrawls after a warning. FYI

I'll probably be working on one this week

People who are interested in seeing Bitrue connector, please vote here:
https://snapshot.org/#/hbot-prp.eth/proposal/0x2d64f537568fc5ae2f57096d90a3e793ed36da55021dbe5fc0c9cc516876ca20


set the port of Cassandra client variable (in CassandraClient10)

Because different clusters may monitor different ports. I think make the port as a parameter instead of a constant value is better. Just like what CassandraCQLClient does.

I think something is wrong. I will check the modification again.


Release version 1.0.0

The latest tag release was v0.1.2, since then there's been two breaking changes.

d37c8f22c4ff4284af47f91a8428e6be28b7619a added a context to Transport.Token, this was exported, but unlikely to be used by most use cases. See #21
344ce85a8335355569c30a110000be4668cfa34a changed the AppID type from int to int64 to follow go-github's convention. See #27.

If you were using some dependency management tools, it's likely you pinned to the tagged releases, and weren't affected by the two above breaking changes.
Now this API has settled a bit, and we've introduced Go Modules support in #28, I think it's time to release v1.0.0.
From my understanding of Go Modules, it should just be a matter of pushing the tag v1.0.0 to the latest commit. I.e. we shouldn't need to change go.mod to list the new version like we would if we were to release v2.0.0 (changing the module name to github.com/bradleyfalzon/ghinstallation/v2). Further, no changes to the README.md file should be required as the go get syntax for users who haven't yet used ghinstallation will get the latest tagged release.
@wlynch do you have any comments on this? Is this understanding correct?

Yup! This LGTM. :+1:

You should also change installation id to int64 as it is in the new Google GitHub SDK
https://github.com/google/go-github/blob/master/github/apps.go#L86

@donatj 344ce85a8335355569c30a110000be4668cfa34a changed both App and Installation ID to int64, so we should be good to go.

I'll push 1.0.0 now then

Doneski! Thanks all!
https://github.com/bradleyfalzon/ghinstallation/releases/tag/v1.0.0


problem when coming back from table view

I have problem when i switch to table view then switched back to normal view, strangely my drawing is lost, and id i check the JSON data of my dashboard, the flowcharts value is empty.
Normal view

Table view

Back to normal view

JSON model after come back to normal view

Grafana version: 9.1.0
Flowcharting version: 1.0.0d
Database: Postgresql
Browser: Firefox 103

@curiousbaker  do you found any workaround? seems to lost the diagram completly

Looking at #394, this is similar issue as #401


Page scroll position

What happens
When clicking the back button on a browser the page y . scroll position is set to the top of the page. This is a critical issue for many use cases as on long scrolling results pages the user would have to re-find their position in the page.
Expected
The scroll position is remembered and the page transitions back to the previous position. As per normal NextJs behaviour.

This library shouldn't do anything with scrolling, with the exception of optionally disabling scrolling during transitions with the monkeyPatchScrolling prop.

It is possible to adapt the ScrollMemory component from react-router-scroll-memory for Next.js

This appears to be related to https://github.com/zeit/next.js/issues/1309. TL;DR this is all handled by the browser, and it appears that simply adding transitions makes changing pages take long enough that the browser gives up on trying to restore the previous scroll position. I think the only reason that maintaining scroll position works for some Next.js pages is because they aren't loading data, and thus the page change completes quick enough that the browser can do its usual scroll position restoration.
Given that this is a problem with Next.js itself and this library only makes the problem apparent (it isn't actually the root cause), I'm going to close out this issue. As @arunoda suggested in the other issue, this should be implemented in another userspace package. Solving this problem is beyond the scope of next-page-transitions.


Add Expr::toSql() method

Add Expr::toSql() method to get SQL string for the expression.
When an error happens during expression evaluation, we save the input vector to
a file and include the file path along with the output of Expr::toString() in
the exception message. The output of Expr::toString() is not exactly valid SQL,
hence, needs to be tweaked to reproduce the error. It would be more convenient
to also write SQL for the failed expression to another file and include that
file path in the exception message. Then, reproducing the error would require
just reading the vector from one file, reading the SQL from another, then
evaluating the expression. No more manual editing of the expression string.

@kagamiori @aditi-pandit Wei, Aditi, thank you for the review and helpful comments.. I believe I addressed all these comments.


grpc tracing context

Initial commit of tracing context files.

LGTM pending test results and some minor changes (comments made)

I looked at the failing tests - none of them were due to this PR, a number of them seemed to be a failure of the Jenkins agent (console error message: 'Agent went offline during the build'). I'd like to see the portability tests pass before applying the ready to merge label though.

Test this please.

Test this please

Test this please

Test this please

Test this please

Test this please

Test this please

Test this please


Not seeing the Azure Functions v2 selection option when creating a new Azure function

Hi
I am testing out the extension by following this tutorial Create your first PowerShell function with Azure Functions | Microsoft Docs . However, I have run into  a few issues despite installing all the prereqs
I am simply not seeing this option tho I can happily create by azure function starter project.

Select Powershell (preview) as the language for your function app project and then Azure Functions v2

On the subject of PowerShell preview ( in my case v6.2) do we need to also edit the shell settings in our VSCode user settings ?
%APPDATA%\Code\User\settings.json

@westerdaled what version of the functions extension do you have installed? And what version of VS Code? The PowerShell support was added in v0.17.0 of the functions extension, which relies on at least v1.31.0 of VS Code

Hi @EricJizbaMSFT ,
I have both AZ Function extension 0.17.0 and VSCode : 1.33.1 (system setup) installed. I am also running PowerShell preview 2.02.

So what do you see when you hit this button?

This is what I see:

Also - do you have "azureFunctions.projectLanguage" set in your VS Code user settings? If so - it will use that language automatically.

Hi
I am using my client's Azure subscription:

However, I don't see your language options menu

I wonder if the PowerShell version needs to added to user settings (  I have't added these yet) e.g.
`
"shellLauncher.shells.windows": [{
"shell": "c:\Program Files\PowerShell\6-preview\pwsh.exe",
"label": "PowerShell Core"
},
{
"shell": "C:\Windows\system32\WindowsPowerShell\v1.0\powershell.exe",
"label": "Windows PowerShell"
}
],
`

We don't check powershell version or shell. The only setting that affect this is the above setting. You can do "Reset Setting" to clear the value

Also to be clear - the prompt for language is after your first screenshot. You have to select the folder first.

Hi
it appears that I do have the Azure Functions V2 set in the project runtime settings

Oddly I am now seeing the option at create function time

This could be one of those user error situations 😵

Oddly I am now seeing the option at create function time

And this is a PowerShell project? We should only prompt for runtime if the following are true:

It's a language that supports both v1 and v2 (like JavaScript or C#)
We can't detect the version of the func cli installed on your local machine

Hi
Yes this is is a PowerShell project.  Prior to the above,  I was able to create 2 test AZ Function and never saw the version prompt.  For the first of these, I had a incorrect login to azure as in an account without any subscriptions, so this may have been a factor
Also, he extension detected I was missing a prereq when I came to to perform a test run.:

Running command: "npm install -g<EMAIL_ADDRESS>

Okay so is there anything left blocking you here? Or can we close this issue?


Runtime Sidekick Auto Instantiation

It's not obvious that a Runtime Sidekick component needs adding in the boot sequence, instead the behaviour should automatically default to RuntimeInitializeOnLoad instantiation

Fixed by b0e16eaf75e6c51086bf14e2e52e66533b7e3ad6


Benchmarks: BIG-Bench Hard, HellaSwag, MMLU

Key Contributions
Added MMLU and HellaSwag along with templates and tasks modules.
Things to think about + TODO:

[x] output format (dictionary right now but dataframes later)
[x] default n_shot settings (currently 5 for MMLU and 15 for HellaSwag)
[x] privacy of predict method (will make private later)
[x] logging (I'm using tqdm and print statements to track progress due to slow eval speed)
[x] finishing BBH
[x] writing docs for BBH, MMLU, HellaSwag
[x] how to further simplify interface for user
[x] deleting use cases, imports etc.

This is perfect, couldn't have done it better myself :) @kritinv


MacOs high sierra dotnet core crashing

Dotnet installed.    The specified SDK version [1.0.1] from global.json [/Users/x/NadekoBot/global.json] not found; install specified SDK version Did you mean to run dotnet SDK commands? Please install dotnet SDK from:           http://go.microsoft.com/fwlink/?LinkID=798306&clcid=0x409
macos high sierra, latest dotnet core.

If you're on Nadeko 1.9.X, you'll have to update your dotnet to 2.0.0.

I'm not experienced with mac, but are you sure you downloaded Nadeko 1.9? because it says:
The specified SDK version [1.0.1] from global.json not found 1.0.1 is for versions below 1.9.X iIrc.

check the dotnet info with dotnet --info

You need dotnet 1.0.1 for it to work with Nadeko. 2.0.0 gives problems in most unix environments.

downgrading back to 1.0.1 worked for me thanks!


[occm] feat : add load balancer listener tag using service annotation

openstack-cloud-controller-manager (occm)

What this PR does / why we need it:
this PR solves the  add annotation for custom octavia listener tags problem
this is currently a draft PR that needs review, also i am a bit confuse on where to plug the method 😢
Which issue this PR fixes(if applicable):
fixes #
https://github.com/kubernetes/cloud-provider-openstack/issues/2327

@pierreprinetti can you take a look at this ??

/ok-to-test

Also: please don't forget to add tests! At a minimum, a unit test to exercise tag splitting (with various configurations of spaces in it) would probably be a good idea

@pierreprinetti @kayrus  please re-review
i am working currently working on the test case, hence the WIP

This isn't adding tags to load balancer listeners, only to the load balancer itself.
In my opinion we should allow tagging of all the LB resources being created, not only load balancers, so also: listeners, pools, members, health monitors and security groups. Search for "CreateOpts" in loadbalancer.go to find creations of the other resources.
We also need to account for updates - it should be possible to update the set of tags in the Service annotation and CPO should then update all the LB resources to reflect that. A tricky part here is we might want to keep the tags created by the user intact, which triggers a lost update problem for us, but let's deal with that later.

it just got really wide and clear to me now, thank you

This isn't adding tags to load balancer listeners, only to the load balancer itself.
In my opinion we should allow tagging of all the LB resources being created, not only load balancers, so also: listeners, pools, members, health monitors and security groups. Search for "CreateOpts" in loadbalancer.go to find creations of the other resources.
We also need to account for updates - it should be possible to update the set of tags in the Service annotation and CPO should then update all the LB resources to reflect that. A tricky part here is we might want to keep the tags created by the user intact, which triggers a lost update problem for us, but let's deal with that later.

can i create tags field for other resources,for example the security group doesn't have a tag

Nice, this looks better!
So according to Octavia API reference, the health monitors include tags [1]. I guess gophercloud doesn't support that yet, I'll look into that.
This is still missing tagging of the LB members here [2] and here [3].
The SGs are tagged in a different way - they're part of Neutron service, not Octavia. Something like this should work here [4]:
		err := neutrontags.Add(lbaas.network, "securitygroups", lbSecGroupID, "foo").ExtractErr()

And we should still think about how do we update resources with tags if annotation changes.
[1] https://docs.openstack.org/api-ref/load-balancer/v2/index.html?expanded=create-listener-detail#create-health-monitor
[2] https://github.com/kubernetes/cloud-provider-openstack/blob/4ff1458c9a10dbd50bca90c1c33b2088745ba5fe/pkg/util/openstack/loadbalancer_serial.go#L71
[3] https://github.com/kubernetes/cloud-provider-openstack/blob/23291097decc2258985e4139e0de9d159f76a79d/pkg/openstack/loadbalancer.go#L1284-L1289
[4] https://github.com/kubernetes/cloud-provider-openstack/blob/23291097decc2258985e4139e0de9d159f76a79d/pkg/openstack/loadbalancer.go#L2270

Nice, this looks better!
So according to Octavia API reference, the health monitors include tags [1]. I guess gophercloud doesn't support that yet, I'll look into that.
This is still missing tagging of the LB members here [2] and here [3].
The SGs are tagged in a different way - they're part of Neutron service, not Octavia. Something like this should work here [4]:
		err := neutrontags.Add(lbaas.network, "securitygroups", lbSecGroupID, "foo").ExtractErr()

And we should still think about how do we update resources with tags if annotation changes.
[1] https://docs.openstack.org/api-ref/load-balancer/v2/index.html?expanded=create-listener-detail#create-health-monitor [2]
https://github.com/kubernetes/cloud-provider-openstack/blob/4ff1458c9a10dbd50bca90c1c33b2088745ba5fe/pkg/util/openstack/loadbalancer_serial.go#L71
[3]
https://github.com/kubernetes/cloud-provider-openstack/blob/23291097decc2258985e4139e0de9d159f76a79d/pkg/openstack/loadbalancer.go#L1284-L1289
[4]
https://github.com/kubernetes/cloud-provider-openstack/blob/23291097decc2258985e4139e0de9d159f76a79d/pkg/openstack/loadbalancer.go#L2270

for the [4], i'm i suppose to use the custom tags as the lbSecGroupID

Hi @KingDaemonX
If you addressed something, you can resolve the related comments.

I'm trying to build this and run a bit of tests, might get back with more comments.

Okay, nevermind, after changing "securitygroups" to "security-groups it just works.

Unrelated change, please remove.

yeah i get you
i will do that

i have made all the required changes to the PR @dulek

Seems like you've used security-group instead of security-groups. I'm fairly sure only the latter works, but please prove me wrong if you've tested it and it works.
Also seems like my remarks from this comment about metrics are not implemented.

i totally miss the remark on metric until now that you pointed it again
i will fix them now

Hm, I also don't like an idea that we need to tag all the resources at once. Neutron is modular and there is a possibility that it doesn't have tags module enabled, while octavia can have this module. If tags in neutron are not enabled, the OCCM will fail the reconciliation with an error.
Though, cascade tagging of the octavia resources seems fine with me.
Also security groups and especially FIPs can have their own set of tags, e.g. FIP can be preallocated in advance and a special tag can be assigned on it. Once OCCM starts to manage this FIP, it will remove the tags assigned manually. This should not happen.

Hm, I also don't like an idea that we need to tag all the resources at once. Neutron is modular and there is a possibility that it doesn't have tags module enabled, while octavia can have this module. If tags in neutron are not enabled, the OCCM will fail the reconciliation with an error. Though, cascade tagging of the octavia resources seems fine with me.

True, we can do that. Octavia is not modular, so it's just a matter of API version, but we should check for tags extension in Neutron case too.
@KingDaemonX - we need to add a function checking this and only attempt to tag FIPs and SGs when it exists. This is an example of how to do it: https://github.com/kubernetes/cloud-provider-openstack/blob/fdba36babb2c4b46e759c99cca50ac7eba2ee06f/pkg/openstack/openstack.go#L475-L484
We need to check for standard-attr-tag extension as explained in Neutron API reference.

Also security groups and especially FIPs can have their own set of tags, e.g. FIP can be preallocated in advance and a special tag can be assigned on it. Once OCCM starts to manage this FIP, it will remove the tags assigned manually. This should not happen.

Current code (after my remarks will be addressed) is only tagging FIPs on creation. Same happens with SGs, we assume it's always us creating it, if manage-security-groups=false that code won't be executed. Would that work for you? I also suggested to drop the tags replace call if user haven't defined any tags in the config.

/remove-lifecycle stale

Ah wait, this is indeed stale. I'll just close this, we have other PRs looking at this.


Actually, I don't like this fix all that much. I am just to edit the handlers to accept "True" and "False" string inputs.


Introduces PHPUnit

Introduces PHPUnit and modifies existing tests to be PHPUnit compatible.
To run tests, just run "phpunit test" from the project directory.

Verified that @richardpon has signed the CLA. Thanks for the pull request!

It'll be better to exclude the vendor/ directory from the repo. Users can then install PHPUnit via composer for the locally checked out repo. Will create another PR for that commit.


queries: add org pull-request queries

Add endpoints
Pull Request Overview

/q/orgs/pull-requests/total
/q/orgs/pull-requests/trends

Pull Requests

/q/orgs/pull-requests/actions/trends
/q/orgs/pull-requests/merged-ratio
/q/orgs/pull-requests/open-to-close-duration/medium
/q/orgs/pull-requests/open-to-close-duration/top-repos
/q/orgs/pull-requests/open-to-first-response-duration/medium
/q/orgs/pull-requests/open-to-first-response-duration/top-repos

Common Parameters

ownerId: org ID / user ID
repoIds:  ID array to specify the repos
period: type enums, ["past_7_days", "past_28_days", "past_90_days", "past_12_months"]

cc: @shczhen


Output size

Hello,
I tried this implementation along with Usage.
The size of output tensor is [19, 128].
Do I need to fuse the output tensor in order to convert the output tensor from [19,128] to [1,128] ?
Is the audio-embedding obtained in each audiofile, or in each batch?
#In my understanfing, It can be obtained in each audiofile.

Hi,
Is your input file ~19 seconds long? That would explain the size. For example a single file is: [n_seconds, features], whereas a batched input would be [n_audio_files, n_seconds, features].
Hope that makes sense.

Hi,
Thank you for your reply.
Yes, the size of output audio-embedding is [19,128] when the input file is about 19 seconds.
However, I want the output audio-embedding whose shape is [1,128].
I need 128-dimensions audio-embedding in each input audio file even though the input audio file has N seconds long.
Do I need to fuse processing after getting the output audio-embedding [19,128]?
Best Regards.

Hi,
I have the same doubt as the one @jampeg raised.
VGGish is supposed to give a 128x1 embedding if I am not wrong? So how do we fuse the [n_seconds, features] to be [1,features]?
Thanks

Hi,
Thank you for your reply.
Yes, the size of output audio-embedding is [19,128] when the input file is about 19 seconds.
However, I want the output audio-embedding whose shape is [1,128].
(I need 128-dimensions audio-embedding in each input audio file even though the input audio file has N seconds long.)
Do I need to fuse processing after getting the output audio-embedding [19,128]?
Best Regards.

I understand now.
@jampeg, @SrijithBalachander - I don't know the best way of achieving this, but I would recommend you take a look at work on temporal aggregation, such as ActionVLAD - particularly the section on "Modelling long-term temporal structure" (http://openaccess.thecvf.com/content_cvpr_2017/papers/Girdhar_ActionVLAD_Learning_Spatio-Temporal_CVPR_2017_paper.pdf). I am not an expert on this, but that should be a good starting point for solving your problem.
Alternatively, you could just take the mean of your 19 feature vectors, but you will lose some resolution this way I imagine.
I'll close the issue now if that's all. Please @ me if you need any further advice. Thanks.


Change doc example to use set_* methods.

Hi,
I just noticed the documentation was now slightly wrong with the new version, this change fixes that.

Good catch! The test is marked ignore to avoid actually saving a file when running tests, maybe it should be marked no-run instead, to make sure it stays compilable after the fix?

That's an excellent idea, I've made the change.

That broke one part of the build, so I went back to ignore for now :)

Just noticed that I approved these but forgot to merge. Thank you!