Calling .html() on a shallow render crashes PhantomJS

I'm upgrading my codebase from<EMAIL_ADDRESS>to 3.1.1 and all of my tests that call the .html() method on a shallow render are causing PhantomJS to crash. The test cases are pretty simple, like this:
const props = {}
const wrapper = shallow(<Component {...props}/>)

describe('...', () => {
  it('should not crash', () => {
    expect(wrapper.html()).toContain('text')
  })
})

And that's pretty much it. I have maybe 50 tests that do his (the other 1,000 tests work fine), and it looks like each of them have the same issue (if I isolate karma to just these tests, they're the only ones that fail). I also tried<EMAIL_ADDRESS>and above, and enzyme-adapter-react-16 earlier versions.
These are my other dependencies:

"phantomjs-prebuilt": "2.1.16",
"karma": "1.7.1",
"karma-webpack": "2.0.6",
"enzyme": "3.1.1",
"enzyme-adapter-react-16": "1.0.4",
"react": "16.1.0", "react-dom": "16.1.0"

This is what the PhantomJS stack trace looks like (I don't know how to get a more detailed log - does anyone have any tips?):
12 11 2017 19:47:28.483:ERROR [phantomjs.launcher]:
1   0x1b67967 /home/cody/workspace/projects/frontend/node_modules/phantomjs-prebuilt/lib/phantom/bin/phantomjs() [0x1b67967]
2   0x1baac35 /home/cody/workspace/projects/frontend/node_modules/phantomjs-prebuilt/lib/phantom/bin/phantomjs() [0x1baac35]
3   0x1b9369c /home/cody/workspace/projects/frontend/node_modules/phantomjs-prebuilt/lib/phantom/bin/phantomjs() [0x1b9369c]
4   0x18970ad /home/cody/workspace/projects/frontend/node_modules/phantomjs-prebuilt/lib/phantom/bin/phantomjs() [0x18970ad]
5   0x1896ace /home/cody/workspace/projects/frontend/node_modules/phantomjs-prebuilt/lib/phantom/bin/phantomjs() [0x1896ace]
6   0x1896ddf /home/cody/workspace/projects/frontend/node_modules/phantomjs-prebuilt/lib/phantom/bin/phantomjs() [0x1896ddf]
7   0x1907ec8 /home/cody/workspace/projects/frontend/node_modules/phantomjs-prebuilt/lib/phantom/bin/phantomjs() [0x1907ec8]
8   0x7f379e32381a [0x7f379e32381a]
PhantomJS has crashed. Please read the bug reporting guide at
<http://phantomjs.org/bug-reporting.html> and file a bug report.

Any ideas? Happy to provide more info!

FWIW - it also crashes if I use Chrome to run the tests. I can't even get Chrome to show a stack trace; it just hangs and Karma restarts.

What version of cheerio are you using?
Also, it seems like you upgraded to enzyme 3 and react 16 at the same time - this makes breakage more likely and debugging nearly impossible. Can you roll back to react 15, and get that passing on enzyme 3 first? That will narrow down if it's enzyme 3, or react 16 that's breaking for you.

Good idea, thanks for the tip! You are correct that I upgraded enzyme and react at the same time in my initial issue.
Now, I only upgraded enzyme to 3.1.1 and installed enzyme-adapter-react-15@latest on my existing code which is React 15.6.1. This seems to be working, although there were a few errors I had to fix up.
It could definitely be that one of those errors I fixed was the issue I was hitting, so let me get this committed, and I'll try to upgrade React next and see what happens.
Thanks again - I'll keep you posted!

Interestingly enough, I hit the same issue when upgrading to React 16. To sum up it up:

My tests worked on<EMAIL_ADDRESS>and<EMAIL_ADDRESS>I upgraded to<EMAIL_ADDRESS>and the tests still work (after fixing a couple of issues).
After upgrading to<EMAIL_ADDRESS>I get the crash mentioned above.

This is the only change to my project to upgrade React, and it breaks the enzyme tests:
modified   frontend/package.json
@@ -36,6 +36,7 @@
+    "immutability-helper": "2.5.0",
     ...
-    "react": "15.6.2",
+    "react": "16.1.0",
     ...
-    "react-dom": "15.6.2",
+    "react-dom": "16.1.0",
     ...
-    "react-router": "3.0.5",
+    "react-router": "3.2.0",
     ...
     "enzyme": "3.1.1",
-    "enzyme-adapter-react-15": "1.0.5",
+    "enzyme-adapter-react-16": "1.0.4",
     ...
-    "react-addons-test-utils": "15.5.1",
-    "react-test-renderer": "15.6.2",
+    "react-test-renderer": "16.1.0",

modified   frontend/test/index.js
@@ -3,7 +3,7 @@
  */

 const enzyme = require('enzyme')
-const Adapter = require('enzyme-adapter-react-15')
+const Adapter = require('enzyme-adapter-react-16')

 enzyme.configure({ adapter: new Adapter () })

Cheerio - you mentioned it in the first comment, but I'm just using the Cheerio that comes with enzyme (v1 rc2). I did, for posterity, install 0.22.0 and I get the same crash (may be a clue, I didn't get a different error).
I realize this is difficult without a stack trace or some sort of error, but all I can get is a crash, so, I'm still trying to get more details.
If there's any other info I can provide just let me know! And if you have any ideas for a rabbit hole I can jump that would be great - it's honestly really weird.

It'd be useful if you could narrow down your tests to see which test files are causing the crash; presumably it's not all of them.
After that, we can probably narrow it down to which of your components is causing it, and then that's probably a React 16-related issue.

Alright, @ljharb, I think enzyme is not the culprit here :smile: I traced it down to calling .html() on a single component that uses the react-modal library.
I'm still not sure what the issue is, but it seems related to https://github.com/reactjs/react-modal/issues/538. He doesn't give any information, but enzyme is probably calling renderToStaticMarkup during .html() at some point, right? Sounded related. For now I'm just not using .html() for a couple tests.
Thanks for the help (and enzyme).


coco pseudo mask

Hello author, I am very interested in your work. Could you please provide the coco pseudomask you generated or the irn weight of the coco? Thank you very much

hi, you can try this: https://drive.google.com/file/d/1Nlh8QisjKt9Sy9HpzPSFlY8KrfCYEDXS/view?usp=sharing

Hello author, thank you very much for your reply. Due to the long time required to generate the pseudo mask, could you please provide your pseudo mask directly? I apologize for any inconvenience caused


Inventory walk hacks not available in config

There isn't an option to turn off the check for inventory walk hacks in the config file

Just forgot to implement it. It's resolved now.

Where is it? I don't see it on the wiki or the javadoc.

it's called illegalActions


Lost native connections when loading from file

Hi,
Thank you for bringing us the awesome UnityHeapExplorer!
I found that when I use Capture and Analyze, everything is OK. But when I use Open... to load snapshot from file, all native objects' references seems to be dropped, without any errors or warnings.
When use Capture and Analyze:

When use Open...:

Is this a known issue? (Btw, my Unity version is 2019.4.5f1.)
Thanks!

Thank you for the bug-report. I didn't know about this issue, but I'm able to reproduce it.

I just pushed a fix. Could you please test if it's fixed for you in Heap Explorer 3.8.0?
Old snapshots don't include the connections, but when you capture a new snapshot, then save and load it, it should restore the connections properly.
Please let me know if it works for you.

Nice! It works.
Thank you.


No test with nested IDs.

Just a drive-by issue while I am doing work on a microformats2 JSON schema. There was a problem with my schema that was not caught by any JSON files in the test suite:

{
  "rels": {},
  "rel-urls": {},
  "items": [
    {
      "type": [
        "h-a"
      ],
      "properties": {
        "z": [
          {
            "type": [
              "h-b"
            ],
            "properties": {
              "name": [
                ""
              ]
            },
            "id": "b",
            "value": ""
          }
        ]
      },
      "id": "a",
      "children": [
        {
          "type": [
            "h-c"
          ],
          "properties": {
            "name": [
              ""
            ]
          },
          "id": "c"
        }
      ]
    }
  ]
}

(Output taken from the great and fast in-browser TypeScript parser.)
Microformats within items collections, children collections, and when detected on properties, can all have an id object member with a string value. My schema was getting this wrong and there was no occurrence of this within the test suite to catch it.
We needs tests for this now that https://github.com/microformats/microformats2-parsing/issues/44 has landed in the parsing specification, and has been there since December 2018.
I will probably look into adding a more complete example later.

@Zegnat Just PR'ed this in #121.


what's wrong with my portainer?

let me know how to remove duplicated endpoints entry, also unable to run app templete such as "Gitlab CE"

Can you tell us more information about your environment? (OS, platform, Docker version) as well as how did you deploy Portainer?

Centos7/ Docker CE, the first time not deployed portainer well so I have removed it and re-deploy it then issue happens.

@Kris-ping what command did you use to deploy Portainer?

@deviantony :
docker run -d -p 9000:9000 --restart=always -v /var/run/docker.sock:/var/run/docker.sock -v portainer_data:/data portainer/portainer

And whats the issue with Portainer once it starts?
That CLI looks fine.
Do you have SElinux or AppArmour enabled?
Rgds,
Neil Cresswell
On 19/02/2019, at 10:13 AM, 勇敢的人 <notifications<EMAIL_ADDRESS>wrote:
@deviantonyhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_deviantony&d=DwMCaQ&c=euGZstcaTDllvimEN8b7jXrwqOf-v5A_CdpgnVfiiMM&r=0fx0h4vB56iTLpw2McH1ZD6TqG_QGpbggVOB-PfMJpM&m=gIy_3eSKoz5IGL8uJoFPwWrFpW3wdFdfiTJuSWHlv6w&s=PJoSFivowK0PcD9SttFcOIc0UeSstpSo6J2QXbl3O0M&e= :
docker run -d -p 9000:9000 --restart=always -v /var/run/docker.sock:/var/run/docker.sock -v portainer_data:/data portainer/portainer
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHubhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_portainer_portainer_issues_2718-23issuecomment-2D464880947&d=DwMCaQ&c=euGZstcaTDllvimEN8b7jXrwqOf-v5A_CdpgnVfiiMM&r=0fx0h4vB56iTLpw2McH1ZD6TqG_QGpbggVOB-PfMJpM&m=gIy_3eSKoz5IGL8uJoFPwWrFpW3wdFdfiTJuSWHlv6w&s=tdNsvN4hQAL1dVTYi6Ak2V-kZZjIWLOZtx5MDAJklEs&e=, or mute the threadhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AWGrlUQZ0qLNuOoDQ7deL9dQqP47qot3ks5vOxdtgaJpZM4a-5FZcz&d=DwMCaQ&c=euGZstcaTDllvimEN8b7jXrwqOf-v5A_CdpgnVfiiMM&r=0fx0h4vB56iTLpw2McH1ZD6TqG_QGpbggVOB-PfMJpM&m=gIy_3eSKoz5IGL8uJoFPwWrFpW3wdFdfiTJuSWHlv6w&s=SDYFCn1cxdqyHr80GYXb8S9bUj_nJPvQh3dxpHTZB0w&e=.

@ncresswell  hi: SElinux disabled and now the duplicated entry was left 2 after 3 days eplaped, looks related to cookie, so question now maybe is how to remove cookie, and I already ran prune.

@Kris-ping probably not related to cookie, to confirm this you can try to access Portainer in incognito mode (private navigation in your browser).
In order to fully reset Portainer, you could try to clean your browser local storage (which is where Portainer persists local data in browser),  stop the Portainer container, remove Portainer data by executing docker volume rm portainer_data and then re-deploy it.

@deviantony all your mentioned steps I have did but not works.

Can you give me more details about the cloud provider where your hosting this Portainer instance? We will need to try to reproduce.

hosted on Aliyun.com

@deviantony  is this bug fixed?

No update on this topic yet.

I haven't been able to reproduce in our test lab with centos7 and Portainer 1.23.2. Maybe its related to the cloud platform


Micro optimizations

Closing in favor of https://github.com/quantopian/zipline/pull/1559, which removes the optimization around using history(1) for data.current.


[BUG] availabilityZones() function for class ApplicationGatewayImpl class throw an exception

Describe the bug
calling the function: applicationGateway.availabilityZones() when application gateway has availability zones returns this error:
class com.azure.resourcemanager.resources.fluentcore.arm.AvailabilityZoneId cannot be cast to class java.lang.Comparable (com.azure.resourcemanager.resources.fluentcore.arm.AvailabilityZoneId is in unnamed module of loader 'app'; java.lang.Comparable is in module java.base of loader 'bootstrap').
The reason for this exception is that you try to add elements to tree set that do not implement Comparable interface
Exception or Stack Trace
Add the exception log and stack trace if available
To Reproduce
Steps to reproduce the behavior:
Code Snippet
Add the code snippet that causes the issue.
Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
Setup (please complete the following information):

OS: [e.g. iOS]
IDE: [e.g. IntelliJ]
Library/Libraries: [e.g. com.azure:azure-core:1.16.0 (groupId:artifactId:version)]
Java version: [e.g. 8]
App Server/Environment: [e.g. Tomcat, WildFly, Azure Function, Apache Spark, Databricks, IDE plugin or anything special]
Frameworks: [e.g. Spring Boot, Micronaut, Quarkus, etc]

If you suspect a dependency version mismatch (e.g. you see NoClassDefFoundError, NoSuchMethodError or similar), please check out Troubleshoot dependency version conflict article first. If it doesn't provide solution for the problem, please provide:

verbose dependency tree (mvn dependency:tree -Dverbose)
exception message, full stack trace, and any available logs

Additional context
Add any other context about the problem here.
Information Checklist
Kindly make sure that you have added all the following information above and checkoff the required fields otherwise we will treat the issuer as an incomplete report

[ ] Bug Description Added
[ ] Repro Steps Added
[ ] Setup information Added

@rnizhar-te Thank you for reaching out. @XiaofeiCan you please look into this?


Can't access datasets

The website is saying that "Under Maintenance", so we can't access datasets. Could you upload the datasets to Baidu Yun or Google Drive?

Hi @penguinbing , we add Google Drive link for data: https://drive.google.com/drive/folders/1ZduWjWn5sqbiU7aG2VSFm5YcdGudFTwk?usp=sharing


Anyone working on the replication?

Pls implement the replication feature of mysql etc.
is there a wal log just curious. if dolt mysql server is down, all data will be lost?

The replication strategy right now is "push on write". You can even have a
background daemon just running push. But yes. It's on our roadmap. See:
https://www.dolthub.com/blog/2021-06-14-dolt-is-a-database/
On Tue, Jun 22, 2021 at 11:50 AM hiqsociety @.***>
wrote:

Pls implement the replication feature of mysql etc.
is there a wal log just curious. if dolt mysql server is down, all data
will be lost?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/dolthub/go-mysql-server/issues/481, or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABJAR3HB73X3FGRLMH5CKHLTUDLORANCNFSM47EIMUQA
.

Dolt replication is now production ready. Nothing native exists in this package, however.


error in chapter 5, p162

I think the output for the W matrix is wrong. Here is what i got:
Matrix W:
[[-0.2406 -0.0834]
[-0.3537 -0.1577]
[-0.0168  0.0908]
[ 0.1532 -0.2698]
[ 0.1532 -0.2698]
[-0.4775  0.3745]
[ 0.3644  0.2362]
[-0.3711 -0.2667]
[-0.3711 -0.2667]
[-0.236   0.3187]
[-0.1565 -0.1489]
[-0.1565 -0.1489]
[-0.1584  0.2568]]

Thanks for your note! Hm, that's weird, I still get the same if I rerun that environment. May I ask which numpy version you are using?

Hello!
import numpy numpy.version.version
gives:
'1.14.2'
It is odd that i am getting the right eigen values, but not the eigen vectors! I have my notebook here (I like to do type the code from the book)
https://github.com/mzakariaCERN/FunWithPython/tree/master/4_PCA

Hm. I just reran the code in NumPy 0.14.5 and 0.14.6 and get the same results as in chapter 5. However, when I use numpy 1.15.4 the eigenvectors look slightly differently:
NumPy 0.14:
Matrix W:
 [[-0.13724218  0.50303478]
 [ 0.24724326  0.16487119]
 [-0.02545159  0.24456476]
 [ 0.20694508 -0.11352904]
 [-0.15436582  0.28974518]
 [-0.39376952  0.05080104]
 [-0.41735106 -0.02287338]
 [ 0.30572896  0.09048885]
 [-0.30668347  0.00835233]
 [ 0.07554066  0.54977581]
 [-0.32613263 -0.20716433]
 [-0.36861022 -0.24902536]
 [-0.29669651  0.38022942]]

NumPy 0.15.6:
Matrix W:
 [[ 0.1481 -0.4092]
 [-0.0908 -0.1577]
 [ 0.0168 -0.3537]
 [-0.1484  0.3223]
 [ 0.0163 -0.0817]
 [-0.1913  0.0842]
 [ 0.7338  0.2823]
 [ 0.075  -0.0102]
 [-0.0018  0.0907]
 [-0.294  -0.2152]
 [ 0.0328  0.2747]
 [ 0.3547 -0.0124]
 [ 0.3915 -0.5958]]

When I look at the projections though, they still look reasonable:
PCA:

LDA:

My guess the change is due to some improvements in NumPy, but you should still get a good clustering/seperation. Have you tried to run the Jupyter notebook on your machine without making changes to the code? Maybe there's a chance that you accidentally executed some code in a different order or made some typo when typing the code directly from the book

Found the problem. Mea Culpa!


Path or pattern "bower_components/ember-cli-moment-shim/moment-shim.js" did not match any files

Ember-cli version 0.2.7

The issue is that ember-cli-moment-shim has been migrated from bower to npm in the last version.

+1

A quick fix is to force on your bower.json the version 0.2.0 of ember-cli-moment-shim.
"ember-cli-moment-shim": "0.2.0",

So, we must to wait a newer version of ember-bootstrap-datetimepicker in order to use the new version of ember-cli-moment-shim?

https://github.com/plusacht/ember-bootstrap-datetimepicker/pull/44

status of using this alongside 0.6.0 of ember-cli-moment-shim? https://github.com/jasonmit/ember-cli-moment-shim, do we still need the bower listing and import?

It's an addon now, so npm dep only and yes to import.  Import as 'moment'

@jasonmit do you know where to import moment? i am getting Uncaught bootstrap-datetimepicker requires Moment.js to be loaded first, prolly get rid of this in the index.js but not sure where to put import now
included: function(app) {
    this._super.included(app);

    app.import(app.bowerDirectory + '/ember-cli-moment-shim/moment-shim.js', {
      exports: {
        moment: ['default']
      }
    });
  }

I've ended up writing a new addon that uses the latest versions of the dependencies (bootstrap-datetimepicker and ember-cli-moment-shim).
Also, it doesn't have any view so you don't get any deprecation warnings with ember 1.13+.
Feel free to give it a try - https://github.com/btecu/ember-cli-bootstrap-datetimepicker

@btecu Thank your for answering and helping in this. Do you want collaboration rights for this project? So you could help out?

@jcope2013 'ember install ember-cli-moment-shim'

And remove the app.import, you will not be needing that anymore.

@jasonmit hmm i give it another shot later but that sounds similar to what i tried, do you have it working alongside the npm package? I was getting this error inside the bootstrap-datetimepicker Uncaught bootstrap-datetimepicker requires Moment.js to be loaded first

Push what you have to a branch.  I don't know anything about bootstrap date picker to help until I see what you have.

this is what I npm linked into my app https://github.com/jcope2013/ember-bootstrap-datetimepicker
I manually do the imports in my own app so i removed them from the index.js, maybe that is the culprit

@claudiocro I thought about trying to solve this issue, but then I saw that there was a pull request (#44) that stayed open for over two weeks and I wasn't sure if you were still interested in this project or maybe if you have the time for it. Additionally, this addon relies heavily on the old ember view and causes deprecation warnings in 1.13. In 2.0 is not going to work unless you specifically pull the legacy-view. So it seemed that it would be better to start from zero. It's not that much code any way...

@jcope2013 https://github.com/plusacht/ember-bootstrap-datetimepicker/pull/45/commits should fix the issue

#45 has been comited and should fix this


Installation contributors

First pass (will update more before merge)

@wellcometrust/experience-dev taking this out of dev, I'll put another PR in with the UI stuff.

@wellcometrust/experience-dev scrap that comment... UI is basically done.
Waiting on a discussion with @jennpb and Jen before we make it better though.


Adding dropna

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

16 of 18 (88.89%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.06%) to 82.821%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

pynapple/process/perievent.py
1
3
33.33%

Totals

Change from base Build<PHONE_NUMBER>:
0.06%

Covered Lines:
1941

Relevant Lines:
2287

💛  - Coveralls


NuGet hang due to bug in NuGet 4.6.0

Cake hangs when restoring certain signed NuGet packages. The longest I waited before killing was between 5 and 10 minutes. A repro is a .cake script with #tool WiX.Toolset.UnofficialFork. The latest version of that package, 3.11.1, is the first signed version.
I verified that the bug is present in https://dist.nuget.org/win-x86-commandline/v4.6.0/nuget.exe but not in https://dist.nuget.org/win-x86-commandline/v4.6.1/nuget.exe, running nuget.exe verify -signatures wix.toolset.unofficialfork.3.11.1.nupkg against each.
Cake currently bundles NuGet 4.6.0 assemblies, so it seems that updating its NuGet dependencies to 4.6.2 might resolve this problem.
/cc @gep13

@jnm2 have you added anything to that other issue that I pointed you at?

@gep13 Our network is online and this does look like an already-fixed bug in an earlier version of NuGet. Do you think I should?

@jnm2 @gep13 You're talking about https://github.com/NuGet/Home/issues/7008? The offline part was online a guess of mine. Since I had this issue in our offline network but not in our online network. But Microsoft also failed to reproduce it, so it might be the same issue (and I can update the title to a more appropriate one)

@pascalberger yes, it is that issue.  Initially I thought the two problems were related, but @jnm2 is using 4.6.2 (which after checking) is what you were running, and now his issue is fixed.

@pascalberger Your issue is with NuGet 4.6.2, where this particular bug is not present.

But mine issue was with NuGet 4.62

Lol, three-way race condition 😆

I think it's more likely that the bug that I'm seeing (fixed in 4.6.1) was https://github.com/NuGet/Home/issues/6643.

Just checking, which version of NuGet is 0.29.0 using?

@jnm2 It looks like it's using version 4.6.0.

Thanks! We're okay waiting, but is there a contribution I could make to move to newer NuGet?

@jnm2 rebase https://github.com/aelij/NuGet.Client/tree/netstandard on top of 9245481f357ae542f92e6bc5e504fc898cfe5fc0 and submit a PR to @aelij. Once that’s pushed, update Cake to use 4.7.0

@mholo65 How would I handle these merge conflicts?
        deleted by us:   .teamcity.properties
        both modified:   scripts/cibuild/ConfigureVstsBuild.ps1

scripts/cibuild/ConfigureVstsBuild.ps1
```ps1
<#
.SYNOPSIS
Sets build variables during a VSTS build dynamically.
.DESCRIPTION
This script is used to dynamically set some build variables during VSTS build.
Specifically, this script reads the buildcounter.txt file in the $(DropRoot) to
determine the build number of the artifacts, also it sets the $(NupkgOutputDir)
based on whether $(BuildRTM) is true or false.
.PARAMETER BuildCounterFile
Path to the file in the drop root which stores the current build counter.
.PARAMETER BuildInfoJsonFile
Path to the buildInfo.json file that is generated for every build in the output folder.
.PARAMETER BuildRTM
True/false depending on whether nupkgs are being with or without the release labels.
#>
param
(
[Parameter(Mandatory=$True)]
[string]$BuildCounterFile,
[Parameter(Mandatory=$True)]
[string]$BuildInfoJsonFile,

[Parameter(Mandatory=$True)]
[string]$BuildRTM,

[switch]$SkipUpdateBuildNumber

)
Function Get-Version {
param(
[string]$ProductVersion,
[string]$build
)
Write-Host "Evaluating the new VSIX Version : ProductVersion $ProductVersion, build $build"
# Generate the new minor version: 4.0.0 => 40000, 4.11.5 => 41105.
# This assumes we only get to NuGet major/minor 99 at worst, otherwise the logic breaks.
#The final version for NuGet 4.0.0, build number 3128 would be 15.0.40000.3128
$finalVersion = "15.0.$((-join ($ProductVersion -split '.' | %{ '{0:D2}' -f ($_ -as [int]) } )).TrimStart("0")).$build"
    Write-Host "The new VSIX Version is: $finalVersion"
    return $finalVersion

}
Function Update-VsixVersion {
param(
[string]$ReleaseProductVersion,
[string]$manifestName,
[int]$buildNumber
)
$vsixManifest = Join-Path $env:BUILD_REPOSITORY_LOCALPATH\src\NuGet.Clients\NuGet.VisualStudio.Client $manifestName
Write-Host "Updating the VSIX version in manifest $vsixManifest"

[xml]$xml = get-content $vsixManifest
$root = $xml.PackageManifest

# Reading the current version from the manifest
$oldVersion = $root.Metadata.Identity.Version
# Evaluate the new version
$newVersion = Get-Version $ReleaseProductVersion $buildNumber
Write-Host "Updating the VSIX version [$oldVersion] => [$newVersion]"
Write-Host "##vso[task.setvariable variable=VsixBuildNumber;]$newVersion"
# setting the revision to the new version
$root.Metadata.Identity.Version = "$newVersion"

$xml.Save($vsixManifest)

Write-Host "Updated the VSIX version [$oldVersion] => [$($root.Metadata.Identity.Version)]"

}
<<<<<<< HEAD
Function Print-GitLog {
$mdFolder = [System.IO.Path]::Combine($env:SYSTEM_DEFAULTWORKINGDIRECTORY, 'MicroBuild', 'Output')
New-Item -ItemType Directory -Force -Path $mdFolder | Out-Null
$mdFile = Join-Path $mdFolder 'GitLog.md'
& git log -1 --pretty=format:' Author: %an%n Commit: %H%n Message: %s' 2>&1  | Set-Content $mdFile
Write-Host "##vso[task.addattachment type=Distributedtask.Core.Summary;name=Associated changes;]$mdFile"
}

:tada: Created 4.3.0 preview4 branch
$msbuildExe = 'C:\Program Files (x86)\Microsoft Visual Studio\2017\Enterprise\MSBuild\15.0\bin\msbuild.exe'

Turn off strong name verification for common DevDiv public keys so that people can execute things against
test-signed assemblies. One example would be running unit tests on a test-signed assembly during the build.
$regKey = "HKLM:SOFTWARE\Microsoft\StrongName\Verification*,b03f5f7f11d50a3a"
$regKey32 = "HKLM:SOFTWARE\Wow6432Node\Microsoft\StrongName\Verification*,b03f5f7f11d50a3a"
$regKeyNuGet = "HKLM:SOFTWARE\Microsoft\StrongName\Verification*,31bf3856ad364e35"
$regKeyNuGet32 = "HKLM:SOFTWARE\Wow6432Node\Microsoft\StrongName\Verification*,31bf3856ad364e35"
$has32bitNode = Test-Path "HKLM:SOFTWARE\Wow6432Node"
update submodule NuGet.Build.Localization
$NuGetClientRoot = $env:BUILD_REPOSITORY_LOCALPATH
$Submodules = Join-Path $NuGetClientRoot submodules -Resolve
$NuGetLocalization = Join-Path $Submodules NuGet.Build.Localization -Resolve
$NuGetLocalizationRepoBranch = 'release-4.3.0-preview4'
$updateOpts = 'pull', 'origin', $NuGetLocalizationRepoBranch
Write-Host "git update NuGet.Build.Localization at $NuGetLocalization"
& git -C $NuGetLocalization $updateOpts 2>&1 | Write-Host
Get the commit of the localization repository that will be used for this build.
$LocalizationRepoCommitHash = & git -C $NuGetLocalization log --pretty=format:'%H' -n 1
if (-not (Test-Path $regKey) -or ($has32bitNode -and -not (Test-Path $regKey32)))
{
Write-Host "Disabling StrongName Verification so that test-signed binaries can be used on the build machine"
New-Item -Path (Split-Path $regKey) -Name (Split-Path -Leaf $regKey) -Force | Out-Null
if ($has32bitNode)
{
    New-Item -Path (Split-Path $regKey32) -Name (Split-Path -Leaf $regKey32) -Force | Out-Null
}

}
if (-not (Test-Path $regKeyNuGet) -or ($has32bitNode -and -not (Test-Path $regKeyNuGet32)))
{
Write-Host "Disabling StrongName Verification for NuGet public key so that test-signed binaries can be used on the build machine"
New-Item -Path (Split-Path $regKeyNuGet) -Name (Split-Path -Leaf $regKeyNuGet) -Force | Out-Null
if ($has32bitNode)
{
    New-Item -Path (Split-Path $regKeyNuGet32) -Name (Split-Path -Leaf $regKeyNuGet32) -Force | Out-Null
}

}
if ($BuildRTM -eq 'true')
{
# Set the $(NupkgOutputDir) build variable in VSTS build
Write-Host "##vso[task.setvariable variable=NupkgOutputDir;]ReleaseNupkgs"
<<<<<<< HEAD
Write-Host "##vso[task.setvariable variable=VsixPublishDir;]VS15-RTM"
# Only for backward compatibility with orchestrated builds
if(-not $SkipUpdateBuildNumber)
$numberOfTries = 0
do{
    Write-Host "Waiting for buildinfo.json to be generated..."
    $numberOfTries++
    Start-Sleep -s 15
}
until ((Test-Path $BuildInfoJsonFile) -or ($numberOfTries -gt 50))
$json = (Get-Content $BuildInfoJsonFile -Raw) | ConvertFrom-Json
$currentBuild = [System.Decimal]::Parse($json.BuildNumber)
# Set the $(Revision) build variable in VSTS build
Write-Host "##vso[task.setvariable variable=Revision;]$currentBuild"
Write-Host "##vso[build.updatebuildnumber]$currentBuild"
$oldBuildOutputDirectory = Split-Path -Path $BuildInfoJsonFile
$branchDirectory = Split-Path -Path $oldBuildOutputDirectory
$newBuildOutputFolder =  Join-Path $branchDirectory $currentBuild
if(Test-Path $newBuildOutputFolder)

:tada: Created 4.3.0 preview4 branch
{
$numberOfTries = 0
do{
Write-Host "Waiting for buildinfo.json to be generated..."
$numberOfTries++
Start-Sleep -s 15
}
until ((Test-Path $BuildInfoJsonFile) -or ($numberOfTries -gt 50))
$json = (Get-Content $BuildInfoJsonFile -Raw) | ConvertFrom-Json
$currentBuild = [System.Decimal]::Parse($json.BuildNumber)

    # Set the $(Revision) build variable in VSTS build
    Write-Host "##vso[task.setvariable variable=Revision;]$currentBuild"
    Write-Host "##vso[build.updatebuildnumber]$currentBuild"
    $oldBuildOutputDirectory = Split-Path -Path $BuildInfoJsonFile
    $branchDirectory = Split-Path -Path $oldBuildOutputDirectory
    $newBuildOutputFolder =  Join-Path $branchDirectory $currentBuild
    if(Test-Path $newBuildOutputFolder)
    {
        Move-Item -Path $BuildInfoJsonFile -Destination $newBuildOutputFolder
        Remove-Item -Path $oldBuildOutputDirectory -Force
    }
    else
    {
        Rename-Item $oldBuildOutputDirectory $currentBuild
    }
}

}
else
{
# Only for backward compatibility with orchestrated builds
if(-not $SkipUpdateBuildNumber)
{
$revision = Get-Content $BuildCounterFile
$newBuildCounter = [System.Decimal]::Parse($revision)
$newBuildCounter++
Set-Content $BuildCounterFile $newBuildCounter
# Set the $(Revision) build variable in VSTS build
Write-Host "##vso[task.setvariable variable=Revision;]$newBuildCounter"
Write-Host "##vso[build.updatebuildnumber]$newBuildCounter"
Write-Host "##vso[task.setvariable variable=BuildNumber;isOutput=true]$newBuildCounter"
}
else
{
$newBuildCounter = $env:BUILD_BUILDNUMBER
}
<<<<<<< HEAD
$VsTargetBranch = & $msbuildExe $env:BUILD_REPOSITORY_LOCALPATH\build\config.props /v:m /nologo /t:GetVsTargetBranch
$CliTargetBranch = & $msbuildExe $env:BUILD_REPOSITORY_LOCALPATH\build\config.props /v:m /nologo /t:GetCliTargetBranch
$SdkTargetBranch = & $msbuildExe $env:BUILD_REPOSITORY_LOCALPATH\build\config.props /v:m /nologo /t:GetSdkTargetBranch
Write-Host $VsTargetBranch
}
else
{
$revision = Get-Content $BuildCounterFile
$newBuildCounter = [System.Decimal]::Parse($revision)
$newBuildCounter++
Set-Content $BuildCounterFile $newBuildCounter
# Set the $(Revision) build variable in VSTS build
Write-Host "##vso[task.setvariable variable=Revision;]$newBuildCounter"
Write-Host "##vso[build.updatebuildnumber]$newBuildCounter"

:tada: Created 4.3.0 preview4 branch
$jsonRepresentation = @{
BuildNumber = $newBuildCounter
CommitHash = $env:BUILD_SOURCEVERSION
BuildBranch = $env:BUILD_SOURCEBRANCHNAME
LocalizationRepositoryBranch = $NuGetLocalizationRepoBranch
LocalizationRepositoryCommitHash = $LocalizationRepoCommitHash
<<<<<<< HEAD
VsTargetBranch = $VsTargetBranch.Trim()
CliTargetBranch = $CliTargetBranch.Trim()
SdkTargetBranch = $SdkTargetBranch.Trim()
}
=======
}
:tada: Created 4.3.0 preview4 branch

New-Item $BuildInfoJsonFile -Force
$jsonRepresentation | ConvertTo-Json | Set-Content $BuildInfoJsonFile
$productVersion = & $msbuildExe $env:BUILD_REPOSITORY_LOCALPATH\build\config.props /v:m /nologo /t:GetSemanticVersion
if (-not $?)
{
    Write-Error "Failed to get product version."
    exit 1
}
Update-VsixVersion -manifestName source.extension.vs15.vsixmanifest -ReleaseProductVersion $productVersion -buildNumber $newBuildCounter

}

</details>

@jnm2 oh, did I say rebase :smile:, try a merge instead :smile:

@mholo65 Someone with dmoain knowledge is going to have to do this, I think. 😆
        deleted by them: .teamcity.properties
        both modified:   build/config.props
        both modified:   build/vsts_build.yaml
        both modified:   scripts/cibuild/ConfigureVstsBuild.ps1
        both modified:   scripts/utils/InsertNuGetIntoSdkAndCli.ps1
        both modified:   scripts/utils/PostGitCommitStatus.ps1
        both modified:   scripts/utils/TagNuGetClientGitRepostoryOnRelease.ps1
        both modified:   src/NuGet.Clients/NuGet.MSSigning.Extensions/MSSignCommand.cs
        both modified:   src/NuGet.Clients/NuGet.PackageManagement.PowerShellCmdlets/Cmdlets/UpdatePackageCommand.cs
        both modified:   src/NuGet.Clients/NuGet.PackageManagement.VisualStudio/IDE/VSSolutionManager.cs
        both modified:   src/NuGet.Clients/NuGet.PackageManagement.VisualStudio/Services/NuGetLockService.cs
        both modified:   src/NuGet.Clients/NuGet.PackageManagement.VisualStudio/Telemetry/ProjectTelemetryEvent.cs
        added by us:     src/NuGet.Clients/NuGet.PackageManagement.VisualStudio/Telemetry/VSTelemetryServiceUtility.cs
        both modified:   src/NuGet.Clients/NuGet.SolutionRestoreManager/SolutionRestoreJob.cs
        both modified:   src/NuGet.Core/NuGet.Build.Tasks.Pack/NuGet.Build.Tasks.Pack.targets
        both modified:   src/NuGet.Core/NuGet.Commands/RestoreCommand/RequestFactory/DependencyGraphSpecRequestProvider.cs
        both modified:   src/NuGet.Core/NuGet.Commands/RestoreCommand/RestoreCommand.cs
        both modified:   src/NuGet.Core/NuGet.Commands/RestoreCommand/RestoreRequest.cs
        both modified:   src/NuGet.Core/NuGet.Commands/SignCommand/CertificateProvider.cs
        both modified:   src/NuGet.Core/NuGet.Commands/SignCommand/SignCommandRunner.cs
        both modified:   src/NuGet.Core/NuGet.Commands/Strings.resx
        both modified:   src/NuGet.Core/NuGet.Commands/VerifyCommand/VerifyCommandRunner.cs
        both modified:   src/NuGet.Core/NuGet.Common/Errors/NuGetLogCode.cs
        both modified:   src/NuGet.Core/NuGet.PackageManagement/NuGet.PackageManagement.csproj
        both modified:   src/NuGet.Core/NuGet.PackageManagement/PackagePreFetcherResult.cs
        both added:      src/NuGet.Core/NuGet.PackageManagement/Telemetry/ActionEventBase.cs
        both modified:   src/NuGet.Core/NuGet.Packaging/PackageArchiveReader.cs
        both modified:   src/NuGet.Core/NuGet.Packaging/PackageExtractor.cs
        both modified:   src/NuGet.Core/NuGet.Packaging/PackageFolderReader.cs
        both modified:   src/NuGet.Core/NuGet.Packaging/PackageReaderBase.cs
        both modified:   src/NuGet.Core/NuGet.Packaging/Signing/Archive/SignedPackageArchiveIOUtility.cs
        both modified:   src/NuGet.Core/NuGet.Packaging/Signing/Archive/SignedPackageArchiveUtility.cs
        both modified:   src/NuGet.Core/NuGet.Packaging/Signing/Authoring/ITimestampProvider.cs
        both modified:   src/NuGet.Core/NuGet.Packaging/Signing/Authoring/SignPackageRequest.cs
        deleted by them: src/NuGet.Core/NuGet.Packaging/Signing/Authoring/Signer.cs
        both modified:   src/NuGet.Core/NuGet.Packaging/Signing/Authoring/X509SignatureProvider.cs
        both added:      src/NuGet.Core/NuGet.Packaging/Signing/DerEncoding/DerGeneralizedTime.cs
        both modified:   src/NuGet.Core/NuGet.Packaging/Signing/Native/NativeCms.cs
        both modified:   src/NuGet.Core/NuGet.Packaging/Signing/Oids.cs
        both modified:   src/NuGet.Core/NuGet.Packaging/Signing/Package/ISignedPackageReader.cs
        both modified:   src/NuGet.Core/NuGet.Packaging/Signing/Package/SignedPackageArchive.cs
        both modified:   src/NuGet.Core/NuGet.Packaging/Signing/SignatureVerificationProviderFactory.cs
        both modified:   src/NuGet.Core/NuGet.Packaging/Signing/Signatures/Signature.cs
        both modified:   src/NuGet.Core/NuGet.Packaging/Signing/Timestamp/Rfc3161TimestampProvider.cs
        both modified:   src/NuGet.Core/NuGet.Packaging/Signing/Timestamp/Timestamp.cs
        both modified:   src/NuGet.Core/NuGet.Packaging/Signing/Timestamp/TimestampRequest.cs
        both added:      src/NuGet.Core/NuGet.Packaging/Signing/Utility/AttributeUtility.cs
        both added:      src/NuGet.Core/NuGet.Packaging/Signing/Utility/CertificateChainUtility.cs
        both added:      src/NuGet.Core/NuGet.Packaging/Signing/Utility/CertificateUtility.cs
        both added:      src/NuGet.Core/NuGet.Packaging/Signing/Utility/SignatureUtility.cs
        both added:      src/NuGet.Core/NuGet.Packaging/Signing/Utility/SigningUtility.cs
        both added:      src/NuGet.Core/NuGet.Packaging/Signing/Utility/VerificationUtility.cs
        both added:      src/NuGet.Core/NuGet.Packaging/Signing/Verification/AllowListVerificationProvider.cs
        both added:      src/NuGet.Core/NuGet.Packaging/Signing/Verification/CertificateHashAllowListEntry.cs
        both modified:   src/NuGet.Core/NuGet.Packaging/Signing/Verification/IPackageSignatureVerifier.cs
        both modified:   src/NuGet.Core/NuGet.Packaging/Signing/Verification/IntegrityVerificationProvider.cs
        both modified:   src/NuGet.Core/NuGet.Packaging/Signing/Verification/PackageSignatureVerifier.cs
        both modified:   src/NuGet.Core/NuGet.Packaging/Signing/Verification/SignatureTrustAndValidityVerificationProvider.cs
        both modified:   src/NuGet.Core/NuGet.Packaging/Signing/Verification/SignedPackageVerifierSettings.cs
        both added:      src/NuGet.Core/NuGet.Packaging/Signing/Verification/VerificationAllowListEntry.cs
        both added:      src/NuGet.Core/NuGet.Packaging/Signing/Verification/VerificationTarget.cs
        both modified:   src/NuGet.Core/NuGet.Packaging/Strings.Designer.cs
        both modified:   src/NuGet.Core/NuGet.Packaging/Strings.resx
        both added:      src/NuGet.Core/NuGet.Packaging/Telemetry/PackageExtractionTelemetryEvent.cs
        both modified:   src/NuGet.Core/NuGet.ProjectModel/ProjectRestoreMetadata.cs
        both modified:   src/NuGet.Core/NuGet.ProjectModel/TargetFrameworkInformation.cs
        both modified:   src/NuGet.Core/NuGet.Protocol/LegacyFeed/V2FeedParser.cs
        both modified:   src/NuGet.Core/NuGet.Protocol/Plugins/PluginPackageReader.cs
        both modified:   src/NuGet.Core/NuGet.Protocol/Utility/OfflineFeedUtility.cs
        both modified:   test/NuGet.Clients.FuncTests/NuGet.CommandLine.FuncTest/Caching/CachingTestContext.cs
        both modified:   test/NuGet.Clients.FuncTests/NuGet.CommandLine.FuncTest/Commands/SignCommandTests.cs
        both modified:   test/NuGet.Clients.FuncTests/NuGet.CommandLine.FuncTest/Commands/VerifyCommandTests.cs
        both modified:   test/NuGet.Clients.Tests/NuGet.CommandLine.Test/RestoreNETCoreTest.cs
        both modified:   test/NuGet.Clients.Tests/NuGet.PackageManagement.VisualStudio.Test/Services/NuGetLockServiceTests.cs
        both modified:   test/NuGet.Clients.Tests/NuGet.PackageManagement.VisualStudio.Test/Telemetry/NuGetTelemetryServiceTests.cs
        deleted by them: test/NuGet.Core.FuncTests/Dotnet.Integration.Test/MsbuilldIntegrationTestFixture.cs
        both modified:   test/NuGet.Core.FuncTests/NuGet.Packaging.FuncTest/NuGet.Packaging.FuncTest.csproj
        both added:      test/NuGet.Core.FuncTests/NuGet.Packaging.FuncTest/SigningTests/AllowListVerificationProviderTests.cs
        both modified:   test/NuGet.Core.FuncTests/NuGet.Packaging.FuncTest/SigningTests/IntegrityVerificationProviderTests.cs
        both modified:   test/NuGet.Core.FuncTests/NuGet.Packaging.FuncTest/SigningTests/SignatureTests.cs
        both modified:   test/NuGet.Core.FuncTests/NuGet.Packaging.FuncTest/SigningTests/SignatureTrustAndValidityVerificationProviderTests.cs
        both modified:   test/NuGet.Core.FuncTests/NuGet.Packaging.FuncTest/SigningTests/SignedPackageIntegrityVerificationTests.cs
        deleted by them: test/NuGet.Core.FuncTests/NuGet.Packaging.FuncTest/SigningTests/SignerTests.cs
        both modified:   test/NuGet.Core.FuncTests/NuGet.Packaging.FuncTest/SigningTests/SigningTestFixture.cs
        both added:      test/NuGet.Core.FuncTests/NuGet.Packaging.FuncTest/SigningTests/SigningUtilityTests.cs
        both modified:   test/NuGet.Core.FuncTests/NuGet.Packaging.FuncTest/SigningTests/TimestampProviderTests.cs
        both modified:   test/NuGet.Core.Tests/NuGet.Commands.Test/RestoreCommandTests.cs
        both added:      test/NuGet.Core.Tests/NuGet.Commands.Test/SignCommandRunnerTests.cs
        both added:      test/NuGet.Core.Tests/NuGet.Common.Test/TelemetryTest.cs
        both modified:   test/NuGet.Core.Tests/NuGet.Packaging.Test/NuGet.Packaging.Test.csproj
        both modified:   test/NuGet.Core.Tests/NuGet.Packaging.Test/PackageExtractorTests.cs
        both added:      test/NuGet.Core.Tests/NuGet.Packaging.Test/SigningTests/AttributeUtilityTests.cs
        both added:      test/NuGet.Core.Tests/NuGet.Packaging.Test/SigningTests/CertificateChainUtilityTests.cs
        both added:      test/NuGet.Core.Tests/NuGet.Packaging.Test/SigningTests/CertificateUtilityTests.cs
        both added:      test/NuGet.Core.Tests/NuGet.Packaging.Test/SigningTests/DerGeneralizedTimeTests.cs
        both modified:   test/NuGet.Core.Tests/NuGet.Packaging.Test/SigningTests/SignTestUtility.cs
        both added:      test/NuGet.Core.Tests/NuGet.Packaging.Test/SigningTests/SignatureUtilityTests.cs
        both modified:   test/NuGet.Core.Tests/NuGet.Packaging.Test/SigningTests/SignedPackageArchiveIOUtilityTests.cs
        both modified:   test/NuGet.Core.Tests/NuGet.Packaging.Test/SigningTests/SignedPackageArchiveUtilityTests.cs
        deleted by them: test/NuGet.Core.Tests/NuGet.Packaging.Test/SigningTests/SignerTests.cs
        both modified:   test/NuGet.Core.Tests/NuGet.Packaging.Test/SigningTests/SigningUtilityTests.cs
        both modified:   test/NuGet.Core.Tests/NuGet.Protocol.Tests/DownloadResourceResultTests.cs
        both modified:   test/TestUtilities/Test.Utility/GlobalFolderUtility.cs
        both added:      test/TestUtilities/Test.Utility/Signing/CertificateAuthority.cs
        both added:      test/TestUtilities/Test.Utility/Signing/CertificateUtilities.cs
        both added:      test/TestUtilities/Test.Utility/Signing/IssueCertificateOptions.cs
        both added:      test/TestUtilities/Test.Utility/Signing/OcspResponder.cs
        both modified:   test/TestUtilities/Test.Utility/Signing/SignedArchiveTestUtility.cs
        both modified:   test/TestUtilities/Test.Utility/Signing/SigningTestUtility.cs
        both added:      test/TestUtilities/Test.Utility/Signing/TimestampService.cs
        both modified:   test/TestUtilities/Test.Utility/Signing/TrustedTestCert.cs
        both modified:   test/TestUtilities/Test.Utility/SimpleTestSetup/SimpleTestPackageContext.cs
        both modified:   test/TestUtilities/Test.Utility/SimpleTestSetup/SimpleTestPackageUtility.cs
        both modified:   test/TestUtilities/Test.Utility/Test.Utility.csproj

@jnm2, np. I can take a look tonight!

@mholo65 I've added you as a collaborator on the repo and as an owner on NuGet, feel free to push any change :)

@aelij thank you very much!


chip dv] Fix AST initialization routine

Use absolute address range of AST rather than reference the AST CSRs via
RAL, because those structures do not exist in the closed source.
Signed-off-by: Srikrishna Iyer<EMAIL_ADDRESS>

Waveform from non-SW CSR test showing AST initialization using the same mechanism as the SW tests.

@tjaychen, need your approval to merge this :)
Thanks.

Please use parameter from ast_pkg.sv that defines the last register offset for both open and close source. Parameter name is AstLastRegOffset.

Done - PTAL, thanks!

The ast_pkg.sv is a single file that is identical for open and close source. The REGAL is a dummy external register that does not exist in the close source. Can you please remove the reference to REGAL from the ast_pkg.sv

Updated.


Remove checker qual and migrate to jetbrains annotations

Closes #386.
This also removes the compile only dependencies on checker qual, not sure if these should be left until a breaking release or not.
Some points of note:

Some @Nullable annotations were added where they were missing in equals overrides.
There is no replacement for @MonotonicNonNull or @PolyNull. Both have been replaced with @Nullable annotations with appropriate @Contract annotations for poly null methods.

org.jetbrains.annotations.UnknownNullability?

org.jetbrains.annotations.UnknownNullability?

I pondered that but it's not really true, we do know the nullability but there's no way to accurately express it. That being said, it is definitely the case that @UnknownNullability will prevent IDE warnings (IDEA doesn't bothing nagging you) but at the cost of people potentially missing errors in their own code. I think it might make more sense to leave it @Nullable and let people ignore this warning if they know that the supplier never returns null.

I think it might make more sense to leave it @Nullable and let people ignore this warning if they know that the supplier never returns null.

I would rather we drop the annotation - I know that having this @Nullable would annoy people, myself included.

I would rather we drop the annotation - I know that having this @Nullable would annoy people, myself included.

Okie dokie! I've moved it over to @UnknownNullability as that is the default for non-annotated types and the docs for that method state pretty much the exact reason we'd use it in these supplier cases.

Rebase required.


SQS queue disconnects after going idle overnight

Contact Details
No response
Version
8.x
On which operating system(s) are you experiencing the issue?
Windows
Using which broker(s) did you encounter the issue?
Amazon SQS
What are the steps required to reproduce the issue?
This is similar to the reported issue here: https://github.com/MassTransit/MassTransit/issues/1513 that has since been closed. We have MT setup to consume from an SQS queue - .net 6 web api and MT 8.0.8 - Initially it consumes from the queue with no issues, but left idle overnight and it stops consuming anything. We only have to refresh the swagger endpoint on the api in order for it to start consuming again.

setup:

using System;
    using Amazon.SQS;
    using CG.DE.Remote.Service.Configuration;
    using CG.DE.Remote.Service.Handlers.MassTransit;
    using MassTransit;
    using Microsoft.Extensions.DependencyInjection;
    using Service;

    public static class ServiceMassTransitExtension
    {
        public static void SetupMassTransit(this IServiceCollection collection, AwsQueueSettings massTransitQueueSettings)
        {
            collection.AddMassTransit(mt =>
            {
                mt.AddConsumer<MassTransitQueueConsumer>(x => x.Options<BatchOptions>(options => options
                    .SetMessageLimit(Convert.ToInt32(massTransitQueueSettings.BatchLimit))
                    .SetConcurrencyLimit(Convert.ToInt32(massTransitQueueSettings.ConcurrencyLimit))
                ));

                mt.UsingAmazonSqs((context, cfg) =>
                {
                    cfg.Host(massTransitQueueSettings.Region, h =>
                    {
                        h.AccessKey(massTransitQueueSettings.AccessKey);
                        h.SecretKey(massTransitQueueSettings.SecretKey);
                    });
                    cfg.AutoStart = true;

                    cfg.ReceiveEndpoint($"{massTransitQueueSettings.ExtractionRequestsQueue}", endpoint =>
                    {
                        endpoint.ConfigureConsumer<MassTransitQueueConsumer>(context);
                        endpoint.QueueAttributes.Add(QueueAttributeName.KmsMasterKeyId, Constants.ExportQueuesEncryptionKey);
                    });
                });
            });
        }
    }

### What is the expected behavior?

Queue is still consumed even after a long (hours) period of no messages

### What actually happened?

Messages are not consumed until the swagger endpoint for the api is refreshed - or the api is restarted

### Related log output, including any exceptions

```shell
2022-12-01 15:32:06.9494 Debug started the api ok Thread= Session= App= Org= User=

2022-12-01 15:32:07.8119 Info Configured endpoint Requests-Queue, Consumer: Handlers.MassTransit.MassTransitQueueConsumer Thread= Session= App= Org= User=

2022-12-01 15:32:09.1682 Info Bus started: amazonsqs://eu-west-2/ Thread= Session= App= Org= User=

2022-12-01 15:53:04.6855 Info Bus stopped: amazonsqs://eu-west-2/ Thread= Session= App= Org= User=

Link to repository that demonstrates/reproduces the issue
No response

This is similar to the reported issue here: https://github.com/MassTransit/MassTransit/issues/1513 that has since been closed. We have MT setup to consume from an SQS queue - .net 6 web api and MT 8.0.8 - Initially it consumes from the queue with no issues, but left idle overnight and it stops consuming anything. We only have to refresh the swagger endpoint on the api in order for it to start consuming again.

It isn't similar at all. This isn't anything under the control of MassTransit.

Thanks, for anyone else that comes across this - we needed to fix the idle timeout on the app pool in IIS to resolve.

Good to know, thanks for following up!


Wrong tag value for <IP_ADDRESS>

name: "SCORED | <IP_ADDRESS> | PATCH | (L1) Ensure 'Always install with elevated privileges' is set to 'Disabled'"
block:

name: "SCORED | <IP_ADDRESS> | PATCH | (L1) Ensure 'Always install with elevated privileges' is set to 'Disabled'"
win_regedit:
path: HKU:.DEFAULT\Software\Policies\Microsoft\Windows\Installer
name: AlwaysInstallElevated
data: 0
type: dword

name: "SCORED | <IP_ADDRESS> | PATCH | (L1) Ensure 'Always install with elevated privileges' is set to 'Disabled'"
win_regedit:
path: HKCU:\Software\Policies\Microsoft\Windows\Installer
name: AlwaysInstallElevated
data: 0
type: dword
when: rule_19_7_41_1
tags:

level1

level2

rule_<IP_ADDRESS>

patch

Addressed with PR#24 and release 1.2.1


Remove prefixed info (like package name) from element description in XSD

For example for https://frankdoc.frankframework.org/#!/Pipes/BytesOutputPipe the code completion shows:
BytesOutputPipe - nl.nn.adapterframework.pipes.BytesOutputPipe used as Pipe Output bytes as specified by the input XML.
This is very confusing. In my opinion there's no need to add "BytesOutputPipe - nl.nn.adapterframework.pipes.BytesOutputPipe used as Pipe" at the beginning of the text. Please remove it.

Why is that relevant for the end user? When you look at the below screenshots the XmlInputValidator/Pipe part it is already mentioned on the left side. That it is a XmlValidator used as Validator/Pipe can also be deducted from the word XmlInputValidator/Pipe on the left side. So this all seems rather redundant information that distracts from the most important info saying that this pipe can be use to validate against a XML-Schema


improve actionbar layout

Adds a pack_width alias property to ActionItem. This property is equal to the lesser of minimum_width and width. Previously, ActionView was assuming items would use more space than they actually do, because minimum_width was greater than the actual width of the item, leading to premature hiding of items.
Also modifies ActionPrevious so that the Label is not part of the Button area.

@kived +1. You can rebase and merge the changes yourself :)

I know get the following error when using ActionLabel (<ActionLabel@ActionItem+Label>) when I updated to the latest Kivy master branch:
[CRITICAL] [Clock       ] Warning, too much iteration done before the next frame. Check your code, or increase the Clock.max_iteration attribute
Might it be related to this update?
Here is a simple example generating the error:
http://pastebin.com/YAHKVJdr
It has to do with calling:
text: app.foo


Fortify token handling

Really two issues, but I think a common resolution so I'm just opening one:

There's a side-channel vulnerability with the fortify token protection. An attacker could work backwards from the .webbreaker file timestamp to narrow in on and eventually determine the file content.
The setup code for secrets doesn't play well with Python3 (string handling differences, etc.)

I suggest (well, actually I forward a suggestion from @aparsons) that we move to using https://cryptography.io . Should be straightforward to solve both Python 2/3 compatibility and pseudorandom key generation.

This was fixed in PR #5
Thanks for the feedback!


fix(cli): Fix path to default config

copilot:all

Current dependencies on/for this PR:

main

PR #3322   👈

This comment was auto-generated by Graphite.


Zone.js Performance drag with Core.js polyfill & Webpack

After switching to the webpack branch for the Angular CLI I noticed a huge performance hit.
My page that use to take 1.5 seconds to load now takes about 12 seconds to load.  It seems the vast majority of the time is idle time.  The only change, besides switching to webpack that I saw was the introduction of core.js bringing in reflection from es7.

We were able to reproduce the problem using the old polyfill method es6-shim and reflect-metadata. The issue was zone.js not being loaded before other 3rd party scripts. There might be an iframe auth issue with zone.js or at least a common gotcha. Bootstrapping after the document is ready, which is best practice, was something else that cut the boot time in half. The change detection running after 10 seconds was due to a setInternal


Invalid hook definition

You must deactivate hooks that are not intended for the version of the game the plugin was running on.
Use something like GetGameVersion() == ENGINE ? zSwitch(0x004240C0, 0x00424C70) : 0
https://github.com/Silver-Ore-Team/zBassMusic/blob/3bd3c4c7dd756bf1cc25fc7b6eff3ac07a3bdb3f/plugin/src/Gothic/Hooks.hpp#L5-L11

Fixed in v0.0.21


adding namespace-has-resourcequota policy

What is this PR About?
Adds namespace-has-resourcequota. Closes #55
Check list

[x] Have you created a test case in _test/conftest-unittests.sh
[ ] Have you created a test case in _test/opa-profile.sh
[ ] Have you created a test case in _test/gatekeeper-integrationtests.sh
[x] Have you followed the TESTING.md doc? If not, please provide commands/steps to test this PR.
[x] Have you re-generated POLICIES.md

The other namespace-has-* policy didn't have a test case in _test/opa-profile.sh or _test/gatekeeper-integrationtests.sh, so I didn't add tests there since this one is similar.
cc: @redhat-cop/rego-policies

/assign @etsauer

@deweya ; can you:

rebase
GO111MODULE=on go get github.com/plexsystems/konstraint
konstraint doc -o POLICIES.md

that should fix the CI.

@garethahealy Fixed the CI. That policy regen is cool stuff

/lgtm
/approve


refactor: move type_coercion to analyzer

Which issue does this PR close?

Closes #5848
Rationale for this change
What changes are included in this PR?

Move type_coercion to analyzer.
fix type coercion for subquery

Are these changes tested?
No need new test
Are there any user-facing changes?

This PR contains a fix for type coercion of subquery. I will polish it in following PR.
This fix is important, because it will move cast from expression into subplan. It means that we don't cast expression in eval expression and we do cast before eval expression.
But look like it just a little help for performance.
--- before
tpch q17
cargo run --release --bin tpch -- benchmark datafusion --iterations 5 --path ./data --format tbl --query 17 --batch-size 4096
Query 17 iteration 0 took 5233.1 ms and returned 1 rows
Query 17 iteration 1 took 4940.8 ms and returned 1 rows
Query 17 iteration 2 took 5160.2 ms and returned 1 rows
Query 17 iteration 3 took 5315.6 ms and returned 1 rows
Query 17 iteration 4 took 4967.7 ms and returned 1 rows
Query 17 avg time: 5123.48 ms

--- after
tpch q17
Query 17 iteration 0 took 4789.5 ms and returned 1 rows
Query 17 iteration 1 took 4785.2 ms and returned 1 rows
Query 17 iteration 2 took 4791.5 ms and returned 1 rows
Query 17 iteration 3 took 5051.4 ms and returned 1 rows
Query 17 iteration 4 took 4817.7 ms and returned 1 rows
Query 17 avg time: 4847.07 ms

slt run fail, but it's strange. cc @alamb @melgenek
[dates.slt] Running query: "select i_item_desc
from test
where d3_date > d2_date + INTERVAL '1 days';"
Error: statement is expected to fail with error:
[dates.slt] Running query: "select i_item_desc
	DataFusion error: Error during planning: Timestamp(Nanosecond, Some("+00:00")) + Utf8 can't be evaluated because there isn't a common type to coerce the types to
from test
but got error:
where d3_date > d2_date + INTERVAL '5 days';"
	DataFusion error: Error during planning: Timestamp(Nanosecond, Some("+00:00")) + Utf8 can't be evaluated because there isn't a common type to coerce the types to

PR is ready for reivew, cc @mingmwang @alamb @liukun4515

I will take a look tomorrow.
@jackwener One thing need to confirm with you is the Error behavior.
Originally the optimizer rules might return an error, and the logical plan optimizer will skip the failed rule by default and will
not fail the SQL.  But I think for Analyzer rules, if the rule return an Error, I think the SQL should failure immediately.
For the type_coercion rule, the rule itself is to ensure the correctness, I think if there is error, the SQL should failure.
#5831
       /// When set to true, the logical plan optimizer will produce warning
        /// messages if any optimization rules produce errors and then proceed to the next
        /// rule. When set to false, any rules that produce errors will cause the query to fail
        pub skip_failed_rules: bool, default = true


amplifyPush --simple not working with dotnet

Describe the bug
I am working on setting up the console using the new dotnet Amplify support. I have a react front-end with a dotnet serverless back-end. I setup my app with the default build settings that are generated as part of the documentation (i.e. amplify.yml):
version: 0.1
backend:
  phases:
    build:
      commands:
        - '# Execute Amplify CLI with the helper script'
        - amplifyPush --simple
frontend:
  phases:
    preBuild:
      commands:
        - npm ci
    build:
      commands:
        - npm run build
  artifacts:
    baseDirectory: build
    files:
      - '**/*'
  cache:
    paths:
      - node_modules/**/*

However, when I go to deploy this, it fails while building the back-end:
                                 # Starting phase: build
                                 # Executing command: amplifyPush --simple
2020-05-14T21:16:57.459Z [INFO]:
2020-05-14T21:16:57.460Z [INFO]: For more information on AWS Profiles, see:
                                 https://docs.aws.amazon.com/cli/latest/userguide/cli-multiple-profiles.html
2020-05-14T21:16:57.745Z [INFO]: Amplify AppID found: xxxxxxxxxx. Amplify App name is: ReactAmplified
2020-05-14T21:16:57.837Z [INFO]: Backend environment dev found in Amplify Console app: ReactAmplified
2020-05-14T21:16:58.239Z [INFO]:
2020-05-14T21:16:58.909Z [INFO]: Note: It is recommended to run this command from the root of your app directory
2020-05-14T21:17:02.184Z [WARNING]: - Initializing your environment: dev
2020-05-14T21:17:03.226Z [WARNING]: ✔ Initialized provider successfully.
2020-05-14T21:17:03.363Z [INFO]: Unable to find dotnet version 3.1 on the path.
2020-05-14T21:17:03.365Z [INFO]: init failed
                                 Error: Missing required dependencies to package ReactAmplify
                                 at buildResource (/root/.nvm/versions/node/v10.16.0/lib/node_modules/@aws-amplify/cli/node_modules/amplify-provider-awscloudformation/lib/build-resources.js:28:11)
                                 at process._tickCallback (internal/process/next_tick.js:68:7)
2020-05-14T21:17:03.366Z [WARNING]: ✖ An error occurred when pushing the resources to the cloud
                                    ✖ There was an error initializing your environment.
2020-05-14T21:17:03.379Z [ERROR]: !!! Build failed
2020-05-14T21:17:03.465Z [ERROR]: !!! Non-Zero Exit Code detected
2020-05-14T21:17:03.465Z [INFO]: # Starting environment caching...
2020-05-14T21:17:03.465Z [INFO]: # Environment caching completed

It seems to know the problem when it says Unable to find dotnet version 3.1 on the path, but I'm not sure the fix. Also, it seems like this should be adjusted for the default dotnet amplify template and/or added in documentation.
To Reproduce

Follow this documentation, but instead of an Angular app, make a React app.
Push to a git repository. I'm using GitLab, but I'm sure the same issue would occur with GitHub too.
Connect a branch for the front-end.
Do a build.

Expected behavior
I expect the back-end to build successfully with the default settings. I also expect that the default amplify template would have already had this setup successfully.
Screenshots
n/a
Additional context
In another app I have, I am able to build React without a problem. This experiment is me trying to add the dotnet backend and ultimately setup dev/prod environments. The environments seem to be setup great when testing locally, but the problem occurs when trying to setup the build in the amplify console.

@CoreyPritchard  .net is not installed in the build container. Could you try adding sudo yum install dotnet-sdk-x.x to your amplify.yml

@swaminator Thanks for looking into this for me! I added sudo yum install dotnet-sdk-3.1, which complained about sudo, saying line 5: sudo: command not found. So, I tried it without, and got the error No package dotnet-sdk-3.1 available..
For reference, here's my updated amplify.yml:
version: 0.1
backend:
  phases:
    build:
      commands:
        - '# Execute Amplify CLI with the helper script'
        - yum install dotnet-sdk-3.1
        - amplifyPush --simple
frontend:
  phases:
    preBuild:
      commands:
        - npm ci
    build:
      commands:
        - npm run build
  artifacts:
    baseDirectory: build
    files:
      - '**/*'
  cache:
    paths:
      - node_modules/**/*

I'm still having issues. Can anyone help?

I finally was able to get dotnet installed with the following amplify.yml file. I'm now running into a new issue (#685) that requires a restart.
version: 0.1
backend:
  phases:
    preBuild:
      commands:
        - rpm -Uvh https://packages.microsoft.com/config/centos/7/packages-microsoft-prod.rpm
        - yum install -y dotnet-host-3.1.4
        - yum install -y dotnet-sdk-3.1
        - dotnet tool install -g Amazon.Lambda.Tools
        - dotnet tool install -g Amazon.Lambda.TestTool-3.1
    build:
      commands:
        - '# Execute Amplify CLI with the helper script'
        - dotnet lambda
        - amplifyPush --simple
frontend:
  phases:
    preBuild:
      commands:
        - npm ci
    build:
      commands:
        - npm run build
  artifacts:
    baseDirectory: build
    files:
      - '**/*'
  cache:
    paths:
      - node_modules/**/*

I know this ticket is closed, but our team ran into this issue yesterday. We weren't big fans of changing the build script to support this, because that would require dotnet core to be installed on every build. We opted to swap in a custom docker build image. I wrote up the steps we performed to handle this here: https://github.com/aws-amplify/amplify-console/issues/685#issuecomment-685684624


Suddenly `check_status': notFound: File not found

I saw that the script doesn't sync anymore files. I noticed that it keep running background using a lot of CPU (around 50-100% of my raspberry) then it stops after 1 minute (some times 3-4 minutes) without give any error or printing some info about sync. I thought the authorization was broken and it keep retrying to connect to the google's api.
I removed the ~/.credentials/drivesync.yaml and created a new authorization token, but now I got this error:
/var/lib/gems/2.3.0/gems/google-api-client-0.23.4/lib/google/apis/core/http_command.rb:218:in `check_status': notFound: File not found: 1QyyQUEJnFpY9dUUnCENSORED. (Google::Apis::ClientError)
	from /var/lib/gems/2.3.0/gems/google-api-client-0.23.4/lib/google/apis/core/api_command.rb:116:in `check_status'
	from /var/lib/gems/2.3.0/gems/google-api-client-0.23.4/lib/google/apis/core/http_command.rb:183:in `process_response'
	from /var/lib/gems/2.3.0/gems/google-api-client-0.23.4/lib/google/apis/core/http_command.rb:299:in `execute_once'
	from /var/lib/gems/2.3.0/gems/google-api-client-0.23.4/lib/google/apis/core/http_command.rb:104:in `block (2 levels) in execute'
	from /var/lib/gems/2.3.0/gems/retriable-3.1.2/lib/retriable.rb:61:in `block in retriable'
	from /var/lib/gems/2.3.0/gems/retriable-3.1.2/lib/retriable.rb:56:in `times'
	from /var/lib/gems/2.3.0/gems/retriable-3.1.2/lib/retriable.rb:56:in `retriable'
	from /var/lib/gems/2.3.0/gems/google-api-client-0.23.4/lib/google/apis/core/http_command.rb:101:in `block in execute'
	from /var/lib/gems/2.3.0/gems/retriable-3.1.2/lib/retriable.rb:61:in `block in retriable'
	from /var/lib/gems/2.3.0/gems/retriable-3.1.2/lib/retriable.rb:56:in `times'
	from /var/lib/gems/2.3.0/gems/retriable-3.1.2/lib/retriable.rb:56:in `retriable'
	from /var/lib/gems/2.3.0/gems/google-api-client-0.23.4/lib/google/apis/core/http_command.rb:93:in `execute'
	from /var/lib/gems/2.3.0/gems/google-api-client-0.23.4/lib/google/apis/core/base_service.rb:360:in `execute_or_queue_command'
	from /var/lib/gems/2.3.0/gems/google-api-client-0.23.4/generated/google/apis/drive_v3/service.rb:792:in `get_file'
	from /opt/drivesync/src/drive_manager.rb:152:in `get_folder'
	from /opt/drivesync/src/drive_manager.rb:142:in `resolve_path'
	from /opt/drivesync/src/drive_manager.rb:87:in `block in get_files'
	from /opt/drivesync/src/drive_manager.rb:87:in `each'
	from /opt/drivesync/src/drive_manager.rb:87:in `get_files'
	from /opt/drivesync/src/synchronizer.rb:85:in `get_files'
	from /opt/drivesync/src/synchronizer.rb:66:in `run'
	from /opt/drivesync/drivesync.rb:23:in `sync'
	from /opt/drivesync/drivesync.rb:64:in `<main>'

Is this a problem of google's api?

@FedericoHeichou Have you tried running ruby drivesync.rb reset ? This will delete the local drive folder, the sync manifest and authorization. Afterwards you can re-authorize and have a clean slate.

Yes I did it

Looks like the API is looking for a folder which doesn't exist. I don't see how DriveSync itself could cause this, but if it does, it would have to be fixed by a total reset. If you do try to reset again, make sure that both the manifest and authorization files have actually been deleted (DriveSync will tell you their paths during the reset process).
If the issue persists, let me know.

Suddenly (I did nothing) it seems it works again.
It was a Google's problem as I thought.
Thank you very much, I will monitor tomorrow too and then if it works I'll close this issue.


extensive CPU usage when gRPC clients timeout

I create 5000 clients and 10 stream per clients to an etcd server. And then I close all gRPC connection at client side. After a while, the server starts to kill the streams and the CPU usage starts to increase. I have not investigated more into this issue at all.

It turns out that this is not a grpc issue. Watch cancellation at etcd side uses most of the CPU. I am still investigating

OK. Cancellation is O(N^2) (N is the watchers on the same key). https://github.com/coreos/etcd/blob/master/storage/watchable_store.go#L208
I guess we should avoid the extensive copy at least.

Should we try map on synced?

@gyuho yes. you should. but be careful about memory usage implication.

Sure I will try that with comparison with current implementation. Thanks.

Fixed by https://github.com/coreos/etcd/pull/3899


Peter new matrix

Updates the comparison page

This change is

Online preview: http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/0e4709052894c90d2d111e99471060145f999c78/
Edited pages:

v19.2/cockroachdb-in-comparison.md

Online preview: http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/f9b6f5f40a8a4022de43e1882aef681cb01e7545/
Edited pages:

v19.2/cockroachdb-in-comparison.md

Online preview: http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/68d7a41bd081333cd4f8701ee38b24e6435f9bd2/
Edited pages:

v19.2/cockroachdb-in-comparison.md

@jaymce, want to review this? http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/68d7a41bd081333cd4f8701ee38b24e6435f9bd2/v19.2/cockroachdb-in-comparison.html
@anagio, looks like there's a broken link. Once this is final, please port the change to the 20.1 version of the page as well.

Online preview: http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/28c915c5f7081d386a7a25ec3fcb50fc852fa0c5/
Edited pages:

v19.2/cockroachdb-in-comparison.md

@jseldess had left it as a draft to get a preview up. Jim asked I remove the links until new ones are available. Updated pr ready for review

Online preview: http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/9da3824993c908a605324372116bdae03061c825/
Edited pages:

v19.2/cockroachdb-in-comparison.md

Online preview: http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/e699974bf00ccdfccd85cfa03550da662b45d337/
Edited pages:

v19.1/cockroachdb-in-comparison.md
v19.2/cockroachdb-in-comparison.md
v20.1/cockroachdb-in-comparison.md

Online preview: http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/26d59f92fcab256a9b7e0c74ca548b8a91c8e3bd/
Edited pages:

v19.1/cockroachdb-in-comparison.md
v19.2/cockroachdb-in-comparison.md
v20.1/cockroachdb-in-comparison.md


test: Building out a test to get some surface coverage of the mlapi p…

…rofiler functionality

Closing this in favor of just getting this in develop for a future release


Issue with adding Ranger & Ranger KMS to services list in blueprint_dynamic (for 'all' group_var)

Hello
I hope you are well
First I want to thank you for this incredible work, its help me a lot .
I already try the playbook its work fine for me + I add some services like (superset, kafka..) and all work fine, but when I try to add Ranger and RangerKMS I found an error :
"Ranger is part of the blueprint but the database is set to 'embedded'."
Thanks

@alexandruanghel  I need your help AGAIN :'(

hi @thepg
you have to change the database to something else: https://github.com/hortonworks/ansible-hortonworks/blob/master/playbooks/group_vars/all#L47
Those components do not support embedded database configurations

Hello @alexandruanghel
I add a new config like this :
database: 'mysql'
database_options:
  add_repo: yes
  external_hostname: ''
  rangeradmin_db_name: 'ranger'
  rangeradmin_db_username: 'ranger'
  rangeradmin_db_password: 'ranger'
  rangerkms_db_name: 'rangerkms'
  rangerkms_db_username: 'rangerkms'
  rangerkms_db_password: 'rangerkms'

Hi @thepg
Yes, it should work with database: mysql  (or postgres)
Assuming it works now for you, can you please those the issue? Thx 👍

Hi @thepg
Yes, it should work with database: mysql (or postgres)
Assuming it works now for you, can you please those the issue? Thx 👍

Hello @lhoss
Yes thanks its already work for me
thank you

Cool, thanks for confirming!


Opening Draft tag issue

Tags are separated by space but on Draft backend they are saved with ,, when opening draft to editor please make sure to remove , and replace with   space

Added some code to fix it. Can you please check with draft that includes comma?

fixed