Incorrect parameter name in docstring for artifact.add_dir()

The docstring shows an example with parameter name path,
https://github.com/wandb/wandb/blob/097ef2ea6d033d2f45f667e006e9b4df3793c130/wandb/sdk/interface/artifacts.py#L449
however the function expects parameter name
https://github.com/wandb/wandb/blob/097ef2ea6d033d2f45f667e006e9b4df3793c130/wandb/sdk/interface/artifacts.py#L432

Hi @noobmldude thanks so much for spotting and reporting this. The correct usage is indeed name and not path, I created a ticket for the team and we will update the docstring accordingly. Thanks!

PR was created. Waiting for review.


SAK-31999: allow one to copy a list of site member's usernames in Site Info

I think I've addressed all the comments in this PR that need addressing.

Not working for me. I picked onto a fresh master, rebuilt site-manage and when I click the button I get this:

@adrianfish : Actually I don't really like the way this person has done this too much at all.  There's no need to have the pop up include the portal, it's unnecessary code and more to maintain.  It's much easier if it was just a link you clicked that gave you a text file. Easy to do and worth a rewrite imho.

I'd rather we spent our time implementing a nicer solution than fixing up a bad and buggy one.

Close the PR and just keep the branch. You won't have time to redo this before 12.x, unless you like working late :)


Import once

I'd like to have main run.cqsm script, but each subscripts also could be run separately for e.g testing.
run.cqsm
DEFINE market 'en'
IMPORT market.cqsm
DEFINE market 'pl'
IMPORT market.cqsm

market.cqsm
IMPORT definitions.cqsm ONCE
CREATE USER my_user ${user_path}/${market}
# ...

but the IMPORT path ONCE is not available. Still redefining variables is nice, but if definitions.cqsm has some other rules that shouldn't be run again that ONCE will prevent some errors and improve performance.
this is issue is about a workaround which can be handled in other way: https://github.com/Cognifide/APM/issues/34 (which I also invented, but nah still not implemened)

In APM 5.0.0 variables for each referenced script are stored in separate context, so IMPORT needs to execute each time, but there won't be any problems with overriding previous variables.


Fix typo

thanks! we'll make CI work for forks now :) -- working on this

Thanks for the PR, but we need to get a CLA in place so can't merge this quite yet... :( I made the change though since it's important, looks like it was from a search and replace operation.

How to sign CLA is not ready, right?
https://github.com/fnproject/fn/blob/master/CONTRIBUTING.md
I don't mind if you close this PR and fix directly (it's just one character :))

@making it's not quite ready yet (the CLA), should be up in the next couple of days.


Create a backend wrapper to automatically update metadata when calling a load job

Customer Pain: Customer has to call setMetadata() function every time he wants to update table's metadata.
Issue summary: Problem encountered:
When calling a load job using Java Client Library for BigQuery 1 the metadata is only set at table creation, but not updated on recurrent calls to the function. In order to update it it's necessary to call setMetadata() function 2.
What you expected to happen:
It would be great if a backend wrapper that triggers setMetadata() when calling load() function to allow updating metadata once a BigQuery table is already created.

Closing this as per discussion w team that this needs to be a BE feature.


Add documentation and sample settings to support S3 on Heroku

Heroku's ephemeral file storage is problematic for demos that last more than a few hours.  While not free, S3 support via django-storages would allow for a very low cost persistent solution.

This may be my lack of knowledge with Heroku and S3, but presumably the only way to implement S3 on Heroku easily is with the Heroku bucketeer?
@heymonkeyriot bucketeer looks like it would resolve this issue; we could write documentation for how to do this 'by hand' and then the user would only be charged for actual S3 costs (pennies instead of $5 a month).
I am in favor of authoring the supplemental docs to DIY the config and not advocate for a particular heroku addon.

We can repurpose content from https://wagtail.io/blog/amazon-s3-for-media-files/ or https://www.caktusgroup.com/blog/2014/11/10/Using-Amazon-S3-to-store-your-Django-sites-static-and-media-files/


error in compute cost

In linear regression 1 variable I have the following error
Error: File: computeCost.m Line: 21 Column: 22
Unexpected MATLAB operator.
Error in run (line 33)
computeCost(X, y, theta)

sorry not supporting this repo and working on this full time: https://github.com/WalnutiQ/wAlnut

if you make a pull request with the fix I'll merge it


Using reference for parentSelector causes "Cannot read property 'ownerDocument' of null" error

Summary:
I believe I found a bug the happens when the parentSelector prop function is set by reference, in cases where the parentSelector is an element within the page, and a parent is unmounted suddenly.
This is documented and addressed before (here , and here), but I think I am running into a wall caused by a since added update
Since I am passing the parent node via function return
parentSelector={ () => modalParentRef.current}

the new check
(parentSelector && parentSelector().ownerDocument) || document

throws an error "Cannot read property 'ownerDocument' of null" when the existing node referenced by modalParentRef.current is removed (because of navigation or parent unmount). This is because parentSelector is still a defined function, but returns null.
I have tried a number of workarounds, such as
parentSelector={
    modalParentRef.current
        ? () => modalParentRef.current
        : undefined
}

but I think the prop does not update in time.
My current workaround is
parentSelector={
    (modalParentRef.current || { ownerDocument: undefined, contains: () => false }) as HTMLElement
}

which is unseemly at best, but it works as I would expect.
Steps to reproduce:

Use a Ref in the parentSelector prop e.g. parentSelector={() => someRef.current}

Unmount a parent containing a modal

Get crash and "Cannot read property 'ownerDocument' of null" error

Expected behavior:
I would expect the Modal to realize the return node no longer exists, and handle it that way. My simple and humble suggestion only based on https://github.com/reactjs/react-modal/pull/965 would be to check something like
(parentSelector && parentSelector() && parentSelector().ownerDocument) || document

but there may be a better fix

@tuckbarber In this case it's not a bug. If you use parentSelector, then it must always return a valid element.
We could:

display a warning about it (not sure if it is the right way).
fail explaining what happened
update the doc to explicitly say that it must always return a valid element (seem to be the way to go)

Thanks for the reply @diasbruno That makes sense.
I wish there were some way to unmount this modal's parent safely. I think the issue is that the Modal is trying to remove the portal via the now non-existant parent specified by the ref, yeah?
I find something like
parentSelector={
    () => (props.modalParentRef.current ? props.modalParentRef.current : document) as HTMLElement
}

also fails (Failed to execute 'removeChild') because the document doesn't contain the portal node it is looking for.

hmmm...It'll depend on your setup and/or the lifetime of the parent element.
You should be fine by rearranging things...or it also can be caused by redirecting to early,
like performing a redirect where you set the modal state to close
or on the onRequestClose close.

@diasbruno Aha your rearranging comment along with https://github.com/facebook/react/issues/14811#issuecomment-518430470 gave me the idea to stick with the general ordering of

    <ReactModal parentSelector={selectorFunction} />

with the modal first. This was previously giving me an error with 'appendChild'- instead of 'removeChild' as when the order was parent, then modal. The key was something like
parentSelector={ modalParentRef.current ? () => modalParentRef.current : undefined }

So that the parent is only used after it is set. This seems to work without errors or warnings. Thanks!

This will "reparent" the modal to the default we use. It's kinda ok tough.
Just be careful with "reparenting", it may cause some leaks...

I'll close this, but let me know if you still have problems with this.


Sanitize projects

I fixed all projects building.

Fix .gitignore based on Github template
Upgrade solutions to VS2019 or VS2017 (some legacy projects)
Use v142 toolset on VS2019 sln and use v141 toolset on VS2017 sln
Fix Windows SDK version
Fix PIX version
Fix Package path on ModelConverter
Fix linking on Desktop/D3D12LinkedGpus and UWP/D3D12Residency
Add a missing model for D3D12RaytracingMiniEngineSample
Fix deprecated function on D3D12MemoryManagement

This is a lot of change in this PR, but I see at least a few source changes that we should take. Can you submit the .cpp/.h file changes in their own PR?

Over the past year, it seems that most of these problems have been fixed by other PRs.
Thanks #730.


fix: replace 'fix' by 'chore' and include imported repository URL in PR title

Related: jenkins-x/jx-promote#83

Hi @hervelemeur. Thanks for your PR.
I'm waiting for a jenkins-x or todo member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please assign jstrachan
You can assign the PR to them by writing /assign @jstrachan in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Merge conflict, I'll create another PR without it.


Sleeping processes not being killed?

Hey,
We've been using this package for a while now, and we love it.
We're sadly stuck in Laravel 4.2 for a while, but we've begun running into some issues.
We have some clients, each client has their own Codebase‚ and therefore their own Schedule-command to run.
I've noticed that the process is not always being killed properly after the check has finished.
We've added it to /etc/crontab like this:
*/5 * * * * forge php /data01/Source-share/clients/team/artisan scheduled:run 1>> /dev/null 2>&1
We've set it to every 5 minutes, otherwise the server is killing itself after a short while.
But when i look at "sleeping processes", every time it has run, the numbers just climbs and climbs without being killed again, which makes the load-average ever-increasing.
And looking at "ps axjf" to get a tree view of the processes,
32831 33379 32831 32831 ?           -1 S        0   0:00  \_ CRON
33379 33418 33418 33418 ?           -1 Ss    1001   0:00  |   \_ /bin/sh -c php /data01/Source-share/clients/team/artisan scheduled:run 1>> /dev/null 2>&1
33418 33449 33418 33418 ?           -1 D     1001   0:00  |       \_ php /data01/Source-share/clients/team/artisan scheduled:run

And then it stays as a sleeping process without being removed, and just adds new ones, each time the cron is being executed.
We have about 30'ish codebases now, which are all close to identical apart from a few config settings unrelated to the commands being run, and our schedule server is being pounded down by this.
Is this an issue with how this package works, or some server-configuration issue?

I've isolated the issue somewhat now.
For some reason, the process it spawns "/bin/sh -c php .....", if there is no quotation marks around the actual php-command, it just never dies and goes to sleep.
If i add quotation marks, it finished the job as expected and kills itself..
However this doesn't function as expected through the cronjob..
It just ends up writing;
/bin/sh: 1: php /data01/Source-share/clients/team/artisan scheduled:run --debug: not found
However, if i copy and run it manually it works as expected.

I realize this is most likely a server-related issue, and not because of this package.
Here's what i've tried so far, without luck:
I put it in /etc/crontab, i used tabs instead of spaces, i added php to the PATH of /etc/crontab, added quotation marks around the actual command in /etc/crontab, both single and double quotes.
All above, even combined in various different ways haven't resolved it.
I'll be closing this ticket, but hope that someone drops by, who might have some knowledge on it, to nudge me in the right direction to fix this.

Alright.
So i managed to resolve the issue.
Not entirely sure.
But i removed the Null-pipe and used --debug instead to get some output, and disabled mail-sending in CRON.
Now they are executed and "killed" as they usually have.
Might be related to PHP7.0 handling it differently than PHP5 or HHVM?

I was mistaken. It actually still doesn't work with a large quantity of requests.
It seems to work as expected with a few crons being fired off, but when it have to dispatch many of them at once, it breaks for some reason.

I want to comment so you're aware I saw this, but I don't plan to continue to maintain this package since scheduling is now a part of the core of Laravel.  If you find a solution for the issue you have, I'd be happy to release a patch if it's non-breaking.


acme/new-authz returns [500] error

Hello,
Just faced this issue:
  + ERROR: An error occurred while sending post-request to https://acme-v01.api.letsencrypt.org/acme/new-authz (Status 500)

Details:
<TITLE>Error</TITLE>
An error occurred while processing your request.

Reference #179.7941160.1492661366.abef6c5

 + CloudFlare hook executing: request_failure
Traceback (most recent call last):
  File "hooks/cloudflare/hook.py", line 203, in <module>
    main(sys.argv[1:])
  File "hooks/cloudflare/hook.py", line 199, in main
    ops[argv[0]](argv[1:])
KeyError: 'request_failure'

I'm using let's encrypt for long time, and recently decided to change validation method to DNS.
Thank you for great lib, hope we can solve it /

Solved by reinstalling pip packages with --user flag


Feature/reset animations

Pull request for issue #1702

How about instead of resetAnimations, which I think is a little vague, we call it removeAllAnimations, to be consistent with the removeAllObjects array method?
Just FYI, you can easily get the effect of the resetAnimations method by just replacing the animator with a new instance, but I can see how these array-like methods could be useful, particularly the method for removing a single animation.

@lauraskelton Good idea. Refactored. Thanks.

Looks good!


[backport to 2.x] Add Support for Handling Missing Data in Anomaly Detection (#1274)

Description
backport https://github.com/opensearch-project/anomaly-detection/pull/1274 to 2.x
Check List

[X] New functionality includes testing.
[X] New functionality has been documented.
[X] API changes companion pull request created.
[X] Commits are signed per the DCO using --signoff.
[X] Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

approved, just looks like whitesource security check had issue connecting to the repo

approved, just looks like whitesource security check had issue connecting to the repo

yep. Thanks.


Remove 'Import a Monitoring Plan' Button

Currently, there is an 'Import a Monitoring Plan' button in the Workspace>Monitoring Plan>Select Configurations screen
Action: Remove this button

Note: Import a Monitoring Plan button shall only be available on the individual Configurations tab

Test Case: TC590


Error during save: NBT Stream Too Short

Encountering this error when I try to save my MCPE 13.1 World. Running MCEdit 1.5.1, Windows 64bit.

Can you send your map here?

This is the same issue as:
#473

Here is my world
https://www.dropbox.com/s/6bh7yblz7tw4if5/Ignas.zip?dl=0

I have this same problem :( Any discoveries as of late?

Confirming this is still an issue, full error is as follows:


Notifications broken on version 1.9.1

The notification system is totally broken on version 1.9.1, tested on a Sony Xperia M2 running Android 4.4.4. I've disabled and re-enabled notification access, but still refuses to work. In the application itself, it clearly says there are no apps added to the notification apps list, however there are several already. You can have a look in the screenshot attached.

are you by any chance rooted?

@jareddlc Not at the moment, but I can root it if needed

I will need access to the logs to determine what the issue is. I'm on 6.0.1 and notifications where working fine.  Ive listed how to get logs if you are rooted:
http://forum.xda-developers.com/gear-fit/themes-apps/openfit-source-gear-fit-application-t3005697

A user was kind enough to send me a small log. It looks like it could have possibly have an issue with the new way for notifications. here: https://github.com/jareddlc/OpenFit/blob/master/app/src/main/java/com/solderbyte/openfit/NotificationService.java#L331
I wonder if this doesnt work for andorid 4.4.4 as it was reported on 4.4.4

Does Google Play Developer Console let you check the Android OS version of the people who left you a review in the Play Store? Because if so, I've seen 2 or 3 comments that do describe my exact same issue, but I can't see what OS version they have. Also, I'll try once I arrive home with an Android 5.1.1 device, to see if that changes or not.

It does, it shows a few comments as 4.4 and one of 5.1 and another of 6. However I think the 5.1 and 6 maybe a different issue. Would it be possible to provide with more logs. I only got 1 line. and based on thee log you send. One notification was filtered because it wasn't added to the list. However it is known that WhatsApp emits two notifications. Thanks
On Oct 4, 2016 10:17 AM, Sergio Castell<EMAIL_ADDRESS>wrote:Does Google Play Developer Console let you check the Android OS version of the people who left you a review in the Play Store? Because if so, I've seen 2 or 3 comments that do describe my exact same issue, but I can't see what OS version they have. Also, I'll try once I arrive home with an Android 5.1.1 device, to see if that changes or not.
—You are receiving this because you were mentioned.Reply to this email directly, view it on GitHub, or mute the thread.

@sergiocastell have you tried restarting your phone?
https://code.google.com/p/android/issues/detail?can=2&start=0&num=100&q=&colspec=ID Type Status Owner Summary Stars&groupby=&sort=&id=62811

I think I will try this method. To force the notification service listener
http://stackoverflow.com/a/38636227/1657579

I've finally managed to give it a try on my own device, which is also a Xperia M2 but running on Android 5.1.1. The issue still happened, on WhatsApp and Telegram as far as I tested, since I was receiving Newton Mail notifications (twice, btw). All 3 mentioned apps were in the Notification listener list. Now, I need to try again on Android 4.4, but my guess is that the same thing will happen.
I've attached a log for you, if you see some Bluetooth crashing please ignore it, it may be related with the ROM I'm currently running on.
Log_2016-10-05_18-36-17.txt

Thanks @sergiocastell  Another user sent in logs, with the exact issue as yours. I think I maybe able to solve this soon. Update soon

Nice one @jareddlc, it's been fixed, working on both Android 4.4 and 5.1. Congrats for the nice app!


basic path function

We need a basic path function to implement #34's augmentation in the first place, to determine the property/index that lead from a parent to a child. Eventually this is the type of function that should be moved into Treecle if we end up making that, but this is a quick PR so that we're not blocked on spinning up Treecle

@LeaVerou any thoughts on this?

There's a bit of a catch 22 here: The path() function should be able to use these parent pointers if they exist, and calculate them when they don't.
But calculating them when they don’t exist (as needed by parents.set()) is a much simpler problem.
I think a better path forwards might be to implement #34 without a new path() function, and then we can see what functionality might make sense to abstract away into a path() function.

Sounds good


Consolidate examples and push them to a separate repository (Getting Started Guide)

To have only one but a straightforward example, the current examples will be merged into one. Furthermore, we will create a new repository for these examples, where the current versions of the examples will be pushed with every release. With this, it should be easy for users to clone/fork the example repository.
Example flow:

Delivery: via ArgoCD (GitOps) and kubectl (simple)
Installation of observability features
Deploy V1 -> Failed Pre-Deployment Evaluation
Deploy V2 -> Successful
Deploy V3 -> To show some metrics as time between two deployments
Uninstall

References: #362
https://github.com/keptn/lifecycle-toolkit/issues/365#tasklist-block-d9929f32-8ab6-4e45-899a-8d6f57025bcf

We need to provide a V0 without the app toolkit extensions
I would also add a separate step for adding a Keptn function

This


Update list-all-running-container-images.md

fix syntax  error

This change is

@chenopis "when" has been added in Line 49. Thanks.

@islinwb Why are these PRs getting closed? Now that the change was made, I could have merged this PR.


Ability to run (synchronously) any python custom code rather than only external scripts

Applies on top of PR #2

ping


anallergic, dissever (logical-conflict)

This pull request was generated by the 'mq' tool

/trunk merge


Ripple Effect bug on iOS

The ripple effect is using the wohle screen while animating.
Sometimes the the Animation still remains on the screen.
Example: https://i.imgsafe.org/80eb024.jpg
I created my own branch to test the demo on iOS because the known compile problems with alt.
If someone want to give a shot ( https://github.com/duketwo/demo-app )

Fixed most of it now, maybe someone is willing to fix the bug with alt in the demo project. Then I could create PRs with the most recent fixes regarding iOS.
I think swapping alt with redux and the given router with react-native-router-flux would be a good goal.
Anyway, thanks for the great work. Looks really awesome on iOS and android.


Release cloudnative-pg-v0.20.1

Automatically restart operator on config changes by @baurmatt in https://github.com/cloudnative-pg/charts/pull/172
Integrated the Grafana Dashboard into the operator chart by @itay-grudev in https://github.com/cloudnative-pg/charts/pull/176

Note: This is a minor release. It doesn't contain the recently released operator. See #180 for that.

Looks like the gh action didn't like the empty commit or maybe I should not have "Rebase and squash"-ed it, still the release with v1.22.1 of CNPG is due today, so we'll just do that instead.

Here is the PR, reusing 0.20.1 since it didn't get tagged.
https://github.com/cloudnative-pg/charts/pull/182
@itay-grudev @phisco


Include XML documentation in the NuGet package.

Some members have XML documentation in code, but it is not included into produced NuGet packages. This PR fixes it.

Thx for contrib.
v5.2.7 published.


Remove Chrome Store link and add local setup instructions

The URL returns a 404.

It was taken down by Google Chrome Store team.
The Chrome store link needs to be removed and instructions for developers to enable it needs to be added.

It was taken down by Google Chrome Store team.

Due to violation of some weird policy? :thinking:

@vladimyr Yes!

Which one in particular? This is classic example of userscript and can not imagine scripts suddenly become outlawed. Is usage of 3rd party resolver service problematic bit here?

Hello,
As a workaround:

Go to https://github.com/prabhakar267/github-email-extractor and click on clone or download green button
Clone the project on your computer. (Unzip if you are not using Git).
Go to chrome://extensions/

Tick Developer mode button
Click on Load unpacked extension
Select src folder containing the manifest file

Enjoy your extension.

Best regards.


713 implement css shadow parts on all components except for checkout

Note: https://github.com/justifi-tech/web-component-library/pull/709 Should be reviewed and merged first
This PR include the following changes:

Adds a Theme switcher (default, light, dark) for all components that didn't have it yet (except for Gross Payment Chart).
Add CSS parts to the components to enable customization
Created Header components to abstract parts and bootstrap classes.

Links
#713
Developer considerations

On any task

[ ] Previous unit and e2e tests are passing
[ ] Perform dev QA on Chrome, Firefox, and Safari

On new features

[ ] Add unit tests
[ ] Add e2e tests
[ ] Add documentation
[ ] Does the component have exportedparts for styling? If so, add unit a unit test for each exportedpart

On bugs

[ ] Add unit tests to prevent the bug from happening again

Developer QA steps
[ ] - All components should have a Theme switcher on the Story controls (except Gross Payment Chart)
[ ] - The components that already had the Theme switch before, should not have changed.
[ ] - The components that now present the Theme switcher should now be able to toggle between Default, Light and Dark
[ ] - There are lots of new CSS parts, it would be hard to QA them all, but basically it should be possible to change styles by adding CSS rules targeting any CSS part provided in the apps/docs/stories/themes/dark.ts and apps/docs/stories/themes/light.ts files

Great work overall man - this is a huge refactor!
I'm not done looking yet - but I spotted a few noticeable spots to touch up since we introduced the light and dark theme to so many new component examples / stories.
One example is on both the payments-list and payouts-list components. Specific to the light theme - I think the issue is mainly in regards to the card background for these components in this theme.

And I also noticed on the payment-form component that the Card / Bank Account switcher has lost some of the styling that it used to have for the Light and Dark themes. So in this branch it looks like default bootstrap no matter which theme you're viewing.
Here is the component in the light theme - you can see that its using the default bootstrap styling, but it used to have specific styling for the light and dark themes

Great work overall man - this is a huge refactor!
I'm not done looking yet - but I spotted a few noticeable spots to touch up since we introduced the light and dark theme to so many new component examples / stories.
One example is on both the payments-list and payouts-list components. Specific to the light theme - I think the issue is mainly in regards to the card background for these components in this theme.

And I also noticed on the `payment-form` component that the Card / Bank Account switcher has lost some of the styling that it used to have for the Light and Dark themes. So in this branch it looks like default bootstrap no matter which theme you're viewing.
Here is the component in the light theme - you can see that its using the default bootstrap styling, but it used to have specific styling for the light and dark themes

Nice catch!
For the table width issue, I think it will be nice to have table-wrapper and table parts and add overflow: auto to the table-wrapper part 👍
I'll add it.


Create styles file with reusable styles and measurements

For example, the AppBar at the top I think is '68px' (In desktop, I am not sure about phones), and I have to hardcode it every time I use it. It would be useful to have a way of making this "importable", like in android where you can have a common styles file for these cases.
This will also allow to have standard values for height/width/displacements in components across the application.
This issue would supose a big change, since we would have to go across all of the files looking for hardcoded values and fix it.

@AlbertoCasasOrtiz Is this still a valid open issue? Thanks

I don't think so, as the values that are hardcoded right now are standard (like 68px for top bars), and we introduced the css files for GUI and app versions.


Improve tailwind setup

This PR does two things:

change the setup to use the build time tailwind setup, following the official Tailwind with Parcel guide.

Pros:

Smaller bundle size, as tailwind will only generate the classes that were used.
Better maintainability

Cons:

Packages to maintain
npm run build is slower

I tried my best to keep them consistent, but there were some minor padding differences:
Before

After

Note: The missing xmrit background image in the charts is not caused by this PR. The main branch faces this issue too.

import handsontable minified css from its npm package instead of jsdelivr link, keeping the css and javascript code in sync, and reducing 1 round trip.

Size difference:

Step
styles.css size
handsontable.full.min.css size

Website
57.88 kB
40.53 kB

Original
41.38 KB
40.53 kB

Tailwind Setup
36 KB
40.53 kB

Handsontable
72.85 KB
n/a

I think the website is bigger because afaik, it's a different setup, so the css minifier might be worse.

Nice, #10 does not set Inter and I didn‘t catch that tailwind prose was used.

lgtm


RFC: Data plane and plugin interfaces to simplify plug n play, testing

This is simply moving around code so that all consumers of the data plane (typically the xDS servers)
can easily mock the data plane (or vice versa), and also consume different versions of the data plane that Istio exports..
e.g., dataplane.NewDataplane("v1alpha5") will return a v1alpha5 version of the data plane code, that can be used for
BuildClusters, BuildListeners, ...
Similarly, within the data plane, the proposed set of Plugin interfaces simplify addition of new functionality on top of
the default configuration generated by v1alpha3.. E.g. authn is a plugin that adds mTLS support. Mixer would be a plugin that
adds mixer filter for HTTP listeners/TCP listeners, etc.
The plugin inteface is very granular, to allow implementations to plug into different phases of the configuration generation, such
as during generation of outbound cluster/listener/route, inbound cluster/listener/route.
The exact nature of function arguments to these plugin callbacks is TBD.
The plugin model cleanly separates the set of filters that we or anybody else adds to the system, allowing us to turn on or turn off, or
mock different plugins, for easier testing.
Signed-off-by: Shriram Rajagopalan<EMAIL_ADDRESS>

@rshriram: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
8970fd27bc43a032cf318b8092aecc31bfa66f2a
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

This should be followed by moving all networking/ code into dataplane/, and all the authN code into dataplane/authentication/v1alpha1/, ...

I'm on board with this as a starting point.
Longer term, PluginCallbacks interface should be replaced with a visitor pattern in some form (the problem is that visitors/double-dispatch is not clean to implement in golang, as least as far as I've seen). I'll have to noodle a bit on what that looks like.
We also talked a bit out directory structure: I think pkg/dataplane/networking, pkg/dataplane/auth, pkg/dataplane/mixer, etc is a reasonable way to structure the code.
I think we'll wind up wanting to tweak this stuff, but IMO this is a decent thing to get in and iterate on. @costinm thoughts?

With regard to directory structure, I suggest we have dataplane/plugins explicitly, as it conveys the fact that others can write more plugins, just by looking at the code, instead of having to ask around. We could even have some dummy or mock plugin, that will serve as a starting point.

@rshriram: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
3f38cc4e45d3b43527510a745b071897b7a7f9ca
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

In general - long term seems good, but with the events I mentioned.
However: changing the plugin interface at the same time with the work in v2 seems too much for one release. Can we keep using the current registry/model - and focus on converting from the model
to v2 and the grpc implementation - and do the optimizations in 0.9 ?

@rshriram: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
3f38cc4e45d3b43527510a745b071897b7a7f9ca
link
/test istio-unit-tests

prow/istio-pilot-e2e.sh
3f38cc4e45d3b43527510a745b071897b7a7f9ca
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

To clarify: we do not have to implement any plugin interface. to start with. Its just there as a way for the mixer filter to move into v2 version in a clean way, without tracking where our code is moving. Same applies to auth filter as well.

@rshriram: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
3f38cc4e45d3b43527510a745b071897b7a7f9ca
link
/test istio-pilot-e2e

prow/istio-unit-tests.sh
219216f0f4709aabcd8ddd1e8662e8fcdcb42793
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


The SDK examples for finetuning in the docs are wrong.

Confirm this is a Node library issue and not an underlying OpenAI API issue

[X] This is an issue with the Node library

Describe the bug
In the docs it tells you to use:
const fineTune = await openai.fineTunes.create({ training_file: 'file-abc123', model: 'gpt-3.5-turbo' })

Whereas in the API reference, it says to use:
const fineTune = await openai.fineTuning.jobs.create({ training_file: 'file-abc123', model: 'gpt-3.5-turbo' })

I'm assuming the API reference is the correct version, if so, the docs need to be updated.
Link to relevant section in docs: https://platform.openai.com/docs/guides/fine-tuning/create-a-fine-tuned-model
To Reproduce

read docs here: https://platform.openai.com/docs/guides/fine-tuning/create-a-fine-tuned-model
read API reference here: https://platform.openai.com/docs/api-reference/fine-tuning/create

Code snippets
No response
OS
macOS
Node version
Node v18.17.1
Library version
openai v4.5.0

Please report issues with the docs or API to https://community.openai.com.


Direction for this plugin

First of all, thanks a lot for this PoC @benwilcock. I've managed to get it running on my own machine and it works pretty well. As I mentioned offline at KubeCon I really like this idea of having an AI powered Chatbot within Backstage. I've PoC'ed something similar within my company based on Azure OpenAI and I think this is something that we're really interested in, especially since you're running the AI within your own private space which ensures that you don't accidentally leak company secrets into the public ones. So I'm keen on pushing this idea further and would love to help out.
Right now this plugin is essentially re-hosting the UI of either ChatbotUI and/or Text Gen Web UI using an iframe. While that works well for a proof of concept I don't think it is very feasible in an actual production deployment, let alone the security implications of such a deployment where you're exposing those tools directly to the end user.
So I think for this to be truly viable I think we'd have to build the UI into the plugin itself. If we're going that route I think it makes sense to all add a backend plugin that could save the conversations and provide a pluggable way of integrating with various backends to provide the actual AI if that makes sense.
Any thoughts on this?

Absolutely. I would love it to be a proper client with its own gui. That's certainly the direction I was hoping we could take. I also really would like to keep the idea of having either changeable backends or changeable models (or both) so that folks can choose the model they need and run with it.
I'm so glad you like the idea. It would be great if you could bring your skills to beat on it to turn the dream into a reality.

Seems like a good start. As far as the UI/UX goes, I think the overarching look and feel of ChatbotUI is probably a good analogue as it allows users to do 4 main tasks well:

Chat
Store and recall chats
Store and recall prompts
Change and configure models (e.g temperature).

This is a great start towards that. Keep going!

Yes, this was definitely inspired by ChatbotUI, just build up with Backstage/Material-UI components. There's definitely more finetuning to be done here, but I guess it's a start. I've committed the things I have so far to the main branch in my fork. I've also introduced a feature flag so that it can be easily switched back to the current version.
So far I've build everything into the BackchatComponent directly, so that will need some refactoring. I'll also have to look into how I'm going to add a backend plugin to the repo as well.

I think when I looked into backend plugins in the past, they're either separate repos, or some sort of folder structure is introduced where they're siblings like this example from the QetA plugin: https://github.com/drodil/backstage-plugin-qeta/tree/main/plugins.
Would it be more convenient for me to add you as a contributor so you don't need to maintain a fork?

Today I added another switchable GUI and updated all the documentation in both repos. I got excited by Ollama Web UI's simplicity and ease of use. It's great to look at and it offers a very good downloader for LLMs. There's just one problem - I don't think it's OpenAI API compatible - which is a shame. If it had OpenAI API it would be my new favorite for sure.
We should probably talk roadmap. I'm thinking that there's a possibility we don't need a backend plugin.

Shall we switch to LinkedIn chats? https://www.linkedin.com/in/benwilcock/

Shall we switch to LinkedIn chats? https://www.linkedin.com/in/benwilcock/

Watching your talk now and taking a look. What about GitHub discussions or Backstage discord?


decoder return type should forbid excess properties

Screenshot

Description
size2 should not be allowed because it is not a known property. (Notice size is not required because it has a default).

Oh darn, right, this is not possible currently:

https://github.com/microsoft/TypeScript/issues/241
https://stackoverflow.com/questions/63258306/how-to-force-typescript-excess-property-check-on-function-return-value
https://github.com/microsoft/TypeScript/pull/40311


How long before we can get to this level

https://www.microsoft.com/en-us/research/project/vasa-1/

Just wait until they release new weights and then compare again.

https://www.microsoft.com/en-us/research/project/vasa-1/

I've made some videos that look better than those VASI-1 examples, but I'm also looking forward to the release of the pre-trained audio model, especially since M$ won't release vasa-1 for some time, if ever.

https://www.microsoft.com/en-us/research/project/vasa-1/

I've made some videos that look better than those VASA-1 examples, but I'm also looking forward to the release of the pre-trained audio model, especially since M$ won't release vasa-1 for some time, if ever.

How and proof video would be nice. We are really interested in your progress.

https://www.microsoft.com/en-us/research/project/vasa-1/

I've made some videos that look better than those VASA-1 examples, but I'm also looking forward to the release of the pre-trained audio model, especially since M$ won't release vasa-1 for some time, if ever.

How and proof video would be nice. We are really interested in your progress.

I will post a few examples on social media, and you are welcome to include them here as examples, as long as you attribute the source.

https://www.microsoft.com/en-us/research/project/vasa-1/

I've made some videos that look better than those VASA-1 examples, but I'm also looking forward to the release of the pre-trained audio model, especially since M$ won't release vasa-1 for some time, if ever.

How and proof video would be nice. We are really interested in your progress.

I will post a few examples on social media, (https://www.instagram.com/reel/C6CdHDTOtFW/), and you are welcome to include them here as examples, as long as you attribute the source.   The "how," at least until the audio model is released, is a matter of choosing an appropriate video and photo.  The illusion breaks down if the head movement is too rapid or the angle is too extreme.

Could you provide a better video the instagram reel is partially cutoff

https://www.microsoft.com/en-us/research/project/vasa-1/

I've made some videos that look better than those VASA-1 examples, but I'm also looking forward to the release of the pre-trained audio model, especially since M$ won't release vasa-1 for some time, if ever.

How and proof video would be nice. We are really interested in your progress.

I will post a few examples on social media, (https://www.instagram.com/reel/C6CdHDTOtFW/), and you are welcome to include them here as examples, as long as you attribute the source.   The "how," at least until the audio model is released, is a matter of choosing an appropriate video and photo.  The illusion breaks down if the head movement is too rapid or the angle is too extreme.

This is quite impressive, thank you very much!

https://www.microsoft.com/en-us/research/project/vasa-1/

I've made some videos that look better than those VASA-1 examples, but I'm also looking forward to the release of the pre-trained audio model, especially since M$ won't release vasa-1 for some time, if ever.

How and proof video would be nice. We are really interested in your progress.

I will post a few examples on social media, (https://www.instagram.com/reel/C6CdHDTOtFW/), and you are welcome to include them here as examples, as long as you attribute the source.   The "how," at least until the audio model is released, is a matter of choosing an appropriate video and photo.  The illusion breaks down if the head movement is too rapid or the angle is too extreme.

This is quite impressive, thank you very much!

Here's another, feel free to use an example if you want: https://www.youtube.com/shorts/lgnfAuh5wBY


Export-DbaJob - Can be used as template for other exports

@PowerDBAKlaas made a good point, I'm just gonna create a universally pipable object.


Add ToroKernel

[ToroKernel](http://www.torokernel.io). `[FPC]` This is a library-kernel that allows freepascal applications which are specially ported to run alone in the system. Toro is compiled within the user's application thus resulting in a single binary that can boot on baremetal or as a guest in a modern hypervisor,e.g., hyperv, kvm, qemu, firecraker. ToroKernel addresses the development of microservices by providing a dedicated API.

Added, thanks


minimap2: 2.17 -> 2.22

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/lh3/minimap2/releases.
meta.description for minimap2 is: "A versatile pairwise aligner for genomic and spliced nucleotide sequences"
meta.homepage for minimap2 is: "https://lh3.github.io/minimap2"
meta.changelog for minimap2 is: ""
Updates performed

Version update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS

The tests defined in passthru.tests, if any, passed

/nix/store/8pv7d07f8z4z8g9vw39m42rjhjxps2gn-minimap2-2.22/bin/minimap2 passed the binary check.

1 of 1 passed binary check by having a zero exit code.

1 of 1 passed binary check by having the new version present in output.

found 2.22 with grep in /nix/store/8pv7d07f8z4z8g9vw39m42rjhjxps2gn-minimap2-2.22

found 2.22 in filename of file in /nix/store/8pv7d07f8z4z8g9vw39m42rjhjxps2gn-minimap2-2.22

directory tree listing: https://gist.github.com/7fd6a8d1a7a95272f9232e13412eeb85

du listing: https://gist.github.com/65197f0a7cc8077a5d6b671e9e564668

Rebuild report (if merged into master) (click to expand)

4 total rebuild path(s)

1 package rebuild(s)

1 x86_64-linux rebuild(s)
1 i686-linux rebuild(s)
1 x86_64-darwin rebuild(s)
1 aarch64-linux rebuild(s)

First fifty rebuilds by attrpath
minimap2

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/8pv7d07f8z4z8g9vw39m42rjhjxps2gn-minimap2-2.22 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A minimap2 https://github.com/r-ryantm/nixpkgs/archive/5693a554e295bbcc6eb7906542bf8151823bc6e8.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/8pv7d07f8z4z8g9vw39m42rjhjxps2gn-minimap2-2.22
ls -la /nix/store/8pv7d07f8z4z8g9vw39m42rjhjxps2gn-minimap2-2.22/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

minimap2

Maintainer pings
cc @arcadio for testing.

Result of nixpkgs-review pr 134045 at 5693a554 run on x86_64-linux 1

1 package built successfully:

minimap2

1 suggestion:

warning: missing-phase-hooks
installPhase should probably contain runHook preInstall and runHook postInstall.
Near pkgs/applications/science/biology/minimap2/default.nix:16:3:
   |
16 |   installPhase = ''
   |   ^


"open with" fix for context menu

"open with" for folder on context menu

suggestion: add in .deb "control" one postinst
#!/usr/bin/env bash
update-alternatives --remove editor /usr/bin/atom
update-alternatives --install /usr/bin/editor editor /usr/bin/atom 0
if hash desktop-file-install 2>/dev/null; then
echo hash;
	desktop-file-install /usr/share/applications/atom.desktop
fi
update-desktop-database

@jamilservicos What exactly does this fix?

"open with" context menu to open "project folder" directly of the nautilus

This should probably be optional. We removed this behavior by default on Windows because people complained about it appearing all over the shell there.

But definitely leave it as an option, love that feature. I have a commit to get this this to work on Cinnamon, but this might make it redundant.

Hey @jamilservicos. Apologies for not looking into this on time. I know this PR has been here for a very long time, during that time Atom has seen a number of changes. Due to the changes, this PR has now become outdated. Is it possible for you to resolve the conflicts?

Hey @jamilservicos. Apologies for not looking into this on time. I know this PR has been here for a very long time, during that time Atom has seen a number of changes. Due to the changes, this PR has now become outdated. Is it possible for you to resolve the conflicts?

if you refer about the change in "resources/linux/atom.desktop.in", it is already in the current version.

@jamilservicos Yes, I can see the change in the current version. We should then close this PR. Thank you.


Add jest version for @jest-environment docs

This is the fixed version of my previous PR, highlighting that the @jest-environment docblock can be only used with Jest v20.0.0.

Not sure what's going on here but we already have this in the docs as of yesterday: http://facebook.github.io/jest/docs/configuration.html#testenvironment-string
Thanks for contributing, I'm unclear why GitHub isn't showing a merge conflict or something.

Codecov Report

Merging #3291 into master will decrease coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3291      +/-   ##
==========================================
- Coverage   63.89%   63.89%   -0.01%
==========================================
  Files         176      176
  Lines        6473     6472       -1
  Branches        4        4
==========================================
- Hits         4136     4135       -1
  Misses       2336     2336
  Partials        1        1

Impacted Files
Coverage Δ

packages/jest-cli/src/TestPathPatternPrompt.js
98% <0%> (-0.04%)
:arrow_down:

packages/jest-jasmine2/src/assert-support.js
0% <0%> (ø)
:arrow_up:

packages/jest-cli/src/TestNamePatternPrompt.js
94.33% <0%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 77ce9ec...46fe115. Read the comment docs.


Provide an example wknd tutorial with Nuxt/Vue

Feature Request

Please provide a headless Example with Nuxt https://nuxt.com/  and/or Vue.js https://vuejs.org/

Expected Behavior

It should work the same way as the already existing Next.js/React.js examples, just to give an idea for people developing frontends with Vue/Nuxt-based applications that need to integrate with AEM Headless.

Actual Behavior

Currently there are tutorials for Next.js, React, Android, Webcomponents etc. but none for Nuxt/Vue.

Open points

It's unclear if an integration with the provided libraries and AEM headless is feasible and possible with those technologies (Vue/Nuxt).

Can you check out the vue sample here? https://experienceleague.adobe.com/landing/experience-manager/headless/developer/code.html?lang=en

@davidjgonzalez thank you for the link, I was not aware of those playgrounds. The vue example is already interesting.
Do you also have an example in work for a Nuxt app. Similar to the Next.js starter app?
There are two Nuxt GraphQL modules that might be of help for that.
https://github.com/tobiasdiez/nuxt-graphql-server
https://github.com/diizzayy/nuxt-graphql-client

Unfortunately no - everything we have is listed.

@davidjgonzalez is there a way to provide and test one from outside over a contribution that could run alongside the ones you listed?

keep in mind AEM doesn't use POST based GQL like most clients/frameworks - AEM has its own abstraction of persisted queries (which is a HTTP GET to an endpoint that gets you a GQL like response) - this is a long way of saying, im skeptical Nuxt Graphql libraries would be useful for interaction w AEM.

Absolutely! Link to a GitHub repo that has one you have the rights to contribute and we'll work on getting it moved over/posted to code playgrounds section!! That would be fantastic! 🙇

@davidjgonzalez unfortunately I don't have a private instance, just one in the office that I could try against.
Is there a way to export the AEM model you guys used for the adventure setup?
I would suggest to use the same as base and maybe add also a request with multiple params. Since there is a bug when you send multiple params with the headless packages.
See: https://github.com/adobe/aem-headless-client-js/issues/61


Pin zipp + importlib_metadata to maintain python 3.7 support

3.7 is now EOL, do we still have a reason to support it?


remove redundant condition from r script

The sudo option is no longer needed: https://blog.travis-ci.com/2018-11-19-required-linux-infrastructure-migration.
@jimhester

That is true, LGTM


When gitops run is started, create an empty entrypoint kustomization if the target directory doesn't exist

If the workload directory (the directory the user specifies on the CLI) doesn't exist, create it, and put an empty kustomization in it.
If a user:

Creates a new initialized repository in github (initialized in order to remove a couple of steps)
Clones it.
cd into it, and runs gitops beta run ./workload even though that directory does not exist.

Then:

By the time gitops run is started, the directory ./workload should exist.
It should contain an empty placeholder k8s kustomization file (e.g. similar to this).
When the user adds files to it, they should be automatically updated.

@ozamosi there is a bug where gitops run hangs when you run against an empty directory.  Would this in theory fix that too?  If not, I can file a separate issue.

I wasn't going to check for empty directories, but it's a tiny extra check to add - I'll add it.


Expiring roles

For automatically revoking access once an officer's term completes.

Related to #405, still best implemented in Jedi (https://github.gatech.edu/RoboJackets/jedi/issues/23)


ModuleNotFoundError: No module named 'teleoprtc'

Describe the bug
build and run master branch on device:

Manager failed to start
Traceback (most recent call last):
File "/data/openpilot/selfdrive/manager/./manager.py", line 231, in
main()
File "/data/openpilot/selfdrive/manager/./manager.py", line 199, in main
manager_prepare()
File "/data/openpilot/selfdrive/manager/./manager.py", line 113, in manager_prepare
p.prepare()
File "/data/openpilot/openpilot/selfdrive/manager/process.py", line 213, in prepare
importlib.import_module(self.module)
File "/usr/local/pyenv/versions/3.11.4/lib/python3.11/importlib/init.py", line 126, in import_module
return _bootstrap._gcd_import(name[level:], package, level)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "", line 1204, in _gcd_import
File "", line 1176, in _find_and_load
File "", line 1147, in _find_and_load_unlocked
File "", line 690, in _load_unlocked
File "", line 940, in exec_module
File "", line 241, in _call_with_frames_removed
File "/data/openpilot/system/webrtc/webrtcd.py", line 21, in
from teleoprtc import WebRTCAnswerBuilder
ModuleNotFoundError: No module named 'teleoprtc'

OIC


Fix missing/incorrect autocomplete on nested types

Fix #71734

Fix nested classes not being suggested for global classes

Remove various invalid suggestions (functions, constants, parent classes/enums) for when suggesting types from nested classes.

*User signals are still being suggested, but this should be fixed by #70002
Technical Details
Changes:

When auto-completing COMPLETION_TYPE_ATTRIBUTE, use _guess_identifier_type for the first type in the type chain to account for global classes.
Added p_only_types parameter in _find_identifiers_in_base and _find_identifiers_in_class to filter for only type identifiers.
Added is_meta_type for found classes in _guess_identifier_type and _guess_identifier_type_from_base. Correct me if I'm wrong, but is_meta_type should be for identifiers that represents it's own type (like a class identifier) rather than being an instance of said type. If that's true, then all found class identifiers should be a meta type.

I also added a small clarification comment for CompletionContext.current_argument. At first I was very confused why "current_argument" was being used for a type_chain's size, but turns out it's used for both parameter index and type_chain size, so I thought having a small comment could help clear confusion for future devs.

I realized constants could also be used as types, but decided against including them because of the difficulty of figuring out if a constant is a script or a resource. The three options I had were:

Show no constants.
Show all constants. While this would make it easier for users to choose what they want, it introduces potentially incorrect suggestions
Show only constants that is initialized with preload and is preloading a .gd file. This works, but is inconsistent. It seems to work with a global classes but not with a preloaded scripts.

For now, I'm inclined to not show constants at all. Even with option 3, it is still pretty inconsistent, plus the fact that this won't work for constants assigned to other constants and that users are unlikely to be mixing global class and preloaded scripts make me think it's not really worth it. Let me know if you have any other opinions/suggestions.

Not sure what is the difficulty here. If it's a constant it should have a value already, then you can check if the value is a script or not.

Just realized I could just check the datatype of the initializer to see if a constant is a script. I was trying to check if the expression node was a preload. I've added and a line to allow constant that are scripts or classes. It works well for global classes, but for preloaded classes still doesn't show constants as it seems like the constant's initializer hasn't been reduced at the time of auto-completion.

Postponed to 4.3 as this is not a critical bug and some work is needed on this PR.

I also added a small clarification comment for CompletionContext.current_argument. At first I was very confused why "current_argument" was being used for a type_chain's size, but turns out it's used for both parameter index and type_chain size, so I thought having a small comment could help clear confusion for future devs.

Couldn't we use a union for that?

@poohcom1 are you still interested in working on this, or can it be salvaged?

@HolonProduction Yeah I'd prefer it if someone else could salvage it. I mostly work with C# now and I've kinda forgotten what I was doing here.


*: add metric.

@ngaut @BusyJay @disksing @tiancaiamao

Coverage decreased (-21.4%) to 60.289% when pulling 7cd311cad7b7f4a4ba69c4b29e5aa4d515b6846f on siddontang/metric into 86ffb900805a945a9c6e1bf12b8f6630281fcea2 on master.

LGTM

LGTM

Coverage decreased (-0.05%) to 81.688% when pulling 1bac519c7f4ecb93a2a1775d17706464c3ff8020 on siddontang/metric into 86ffb900805a945a9c6e1bf12b8f6630281fcea2 on master.


Node Searching

Hi
Awesome work..
Q1. Is it possible to search for a node by a path e.g. a\b\c?
Q2. Is it possible to feed this a JSON schema that has parent & child relationships?
Thanks.

Hi!
A1: No, currently there is no way to search for a node
A2: You would have to write a function yourself, that creates that tree for you. I will leave you a simple example below that could work depending on your usecase:
let mySchema = {
  name: 'root_node',
  children: [
    { name: 'child_1' },
    {
      name: 'child_2',
      children: [
        { name: 'child_3' },
      ],
    },
  ],
};

function generateTree(schema) {
  if(schema instanceof Array){
    return schema.map(generateTree)
  }

  let node = new TreeNode(schema.name);

  if(schema.children instanceof Array){
    generateTree(schema.children).forEach(function(child) {
      node.addChild(child);
    });
  }

  return node;
}

let root = generateTree(mySchema);

Sorry if these are not the answers you were looking for.

Closing due to inactivity


Fix a bug related to textDocumentation/implementation

Previously, doing "Find implementations" only showed one result when there were multiple results available. Now, all available results should be shown after this fix.
Opening this as a draft since it's still not working 100% and I'm gonna continue with this PR tomorrow.
Test plan
See newly added snapshot tests. I'm also manually testing this change by uploading the generated dump.lsif to Sourcegraph here https://sourcegraph.com/github.com/sourcegraph/scip-typescript@34337f2fa29d3a83c71814458d19741ae4f21db9/-/blob/snapshots/input/syntax/src/inheritance2.ts?L2:3&subtree=true#tab=implementations_typescript

It's working correctly now

The root bug was that we were always emitting fresh implementationResult vertexes because we didn't pass around symbolInformationIDs pointers. This explains why it always showed only one result for implementations.

It's difficult to see the difference from the raw dump.lsif payloads. Here are screenshots showing the gist of the difference


update navbar model zoo link

Description
Update the link in navigator for model zoo
Checklist
Essentials

[x] To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

[x] update the model zoo link in navigator to Gluon model zoo

updated doc: http://mxnet-doc.s3-accelerate.dualstack.amazonaws.com/index.html

LGTM


Replace .Sources package references with local code

This copies code from aspnet/Extensions into this repo. This code is not actually used in aspnet/Extensions, so it seems more appropriate to put the shared sources here.
Having the code locally makes it easier to

debug and develop this code
source link
ensure patches and servicing are done correctly

FYI @ajaybhargavb @JunTaoLuo  - this will conflict with the .csproj file changes you're making as a part of #4246

/AzurePipelines run AspNetCore-ci


Length tool in modalities CT, DX, MG show the units in pixels

I have been testing the length tool in different modalities and I see that only in CT shows the units in mm. The tests were done on the most recent version of the viewer and the configuration used is that of dcm4cheeDIMSE.
In the DX, CR, MG modes, the tool displays the units in pixels.
I send the samples so they can try.
DX --> Units in pixels.

DICOM Files:
IM-0001-0001-0001.dcm.zip
CR --> Units in pixels.

DICOM Files:
IM-0001-0001-0001.dcm.zip
MG --> Units in pixels.

DICOM Files:
https://drive.google.com/file/d/1t5pS4QPjhIbUPvCGGY6CtgmNU9LeWlwf/view?usp=sharing
CT --> OK units in mm.

DICOM Files:
https://drive.google.com/file/d/1EcO_5Gt8JxGs10ICcjgri1cQJXkRH1Za/view?usp=sharing
Thank you very much, I remain attentive to your comments.

I add more image type
MR --> OK units in mm
RF, RG,US -->units in pixels
I tried print out value "imagePlaneModule' on CR and CT image.
(cornerstone.metaData.get('imagePlaneModule', imageId))
There is not "rowPixelSpacing" and "columnPixelSpacing" in CR, so "pixels" unit is used.
Does anybody know the root cause?
Result:
1.CR
frameOfReferenceUID:undefined
imageOrientationPatient:undefined
imagePositionPatient:undefined
pixelSpacing:(2) [0.1, 0.1]
sliceLocation:undefined
sliceThickness:undefined
2.CT
columnCosines:s {x: 0, y: 1, z: 0}
columnPixelSpacing:0.5
columns:512
frameOfReferenceUID:"1.2.392.200036.9<IP_ADDRESS>.500000065.3.2017052614085796.1"
imagePositionPatient:s {x: 0, y: -128, z: 236.3}
rowCosines:s {x: 0, y: 0, z: -1}
rowPixelSpacing:0.5
rows:512

Hi guys, also experiencing this issue on DX and MG modalities, anyone have comments on this?

Resolved

Hi Christian Vargas,
Can you please help me out to get the fixed code of this thread, Still the measurement tool showing in pixels for MG and DX modalities with the latest git version of the viewer code.

This happens if the DICOM does not have a pixelSpacing tag. We need it to convert pixel length to mm.


Fix docs path relativism after docs theme change

After the algolia theme change, all resource paths were made absolute to the root, which doesn't work when we try to export them to the mlflow.org website, where they are under /docs/.
These ones are the only still-absolute paths I can find:
$ grep -r /_static/ build/html  | grep -v '\.\./'
build/html/_static/websupport.js:    commentImage: '/static/_static/comment.png',
build/html/_static/websupport.js:    closeCommentImage: '/static/_static/comment-close.png',
build/html/_static/websupport.js:    loadingImage: '/static/_static/ajax-loader.gif',
build/html/_static/websupport.js:    commentBrightImage: '/static/_static/comment-bright.png',
build/html/_static/websupport.js:    upArrow: '/static/_static/up.png',
build/html/_static/websupport.js:    downArrow: '/static/_static/down.png',
build/html/_static/websupport.js:    upArrowPressed: '/static/_static/up-pressed.png',
build/html/_static/websupport.js:    downArrowPressed: '/static/_static/down-pressed.png',

Browsing through the website locally seems to generally work; I'm not sure those files are actually used anywhere.

We should probably run make in the docs directory in Travis (@andrewmchen).


How is the accuracy calculated ? Its mentioned that it is averaged over 100 episodes, but averaged over which 100 episodes ? Is it from 1 - 100 ?

I am not sure if I understand your question, but accuracy is averaged over 100 separate test episodes at the end of training.

what is the accuracy returned by running
python a3c_main.py --evaluate 1 --load saved/pretrained_model
Sorry for such basic questions ! I am still a beginner.

The accuracy can be anywhere between 0.8 and 1.0 because the episodes are generated randomly.

Yes this is what i wanted to confirm ! So it means once my model is trained , while testing it I test it over any 100 test episodes and then report the avg value right ?
Thanks

Thanks @devendrachaplot

A silly question, @devendrachaplot it is not an issue, just wanted to know that I am currently training my own model for same work (visual grounding) on your modified environment and I am receiving avg reward as 0 for quite a long time now, so could you let me know if this actually happens at the start of training time.
Thanks

@devendrachaplot I have mailed you at<EMAIL_ADDRESS>Your help will mean a lot.
Thanks!


\n alone is not rendered but seems skipped

Hi here,
I don't know if it is an issue or an expected behaviour but I explain my case.
If I use two \n consecutively: Here is a text.\n\nHere is another text., it will be rendered as two parts as expected:
Here is a text.

Here is another text.

But I have a "weird" behaviour, when I test with this text: Here is a text.\nHere is another text.. I got all wrapped in a
 like:
Here is a text. Here is another text.
 (the \n is replaced by a space).
I think the expected render should be replacing \n by a
, what do you think?

No, this is the expected behavior in markdown. If you want to force newlines, use two spaces before the newline character. See http://markdown-guide.readthedocs.io/en/latest/basics.html#line-return

Ok this two spaces with a \n. Thanks for the quick response @rexxars 👍

The input source
a\s\s
\s\s
a

is rendered as

a

a

instead of

a

a

Is this how markdown behaves?

Working as intended.


Possible error in docs

Hey, looks like a great package. Just wondering if there's a typo in the usage example code for the observer?
Step 4: $frequency = 'custom';
If the example is to trigger after each 10th user registration, should this instead be  $frequency = '10';

you're absolutely right, I'll fix it. Thanks for pointing this out

#9 Fixed README file and publishing of configuration files


Travis CI integrated

@dexter1691 Travis is working fine. This build failed because we have some errors as I referenced in #19 . After fixing this issue, we are good to go.


Consider adding a stable clippy job

In #1144, nightly clippy introduced a new lint, which caused errors in all our builds.
This has happened at least three times that I remember - so it seems like we might get a similar error every month or two.
Let's think about switching to stable clippy jobs. Ideally, we'd run one job on nightly, and use a setting like Travis CI's "allow failures", so builds still succeed if it's just nightly that fails.
Related to #924, where we're thinking about adding a nightly compile job.

I'd prefer to leave it on nightly. Clippy passing shouldn't be a required check in our CI pipeline, so I think that the benefits of staying up to date with the newest version of clippy outweigh the costs of occasionally having errors show up in CI without any changes to the code, especially since those errors don't prevent us from merging code.

We can do both stable and nightly - if GitHub actions has an allow failures or similar setting. I've clarified the title of the PR.

In this ticket and #924, I'd like to isolate infrastructure and dependency errors from errors that are caused by code changes.
That's really important for new and occasional contributors, who might not understand why all their PRs are suddenly failing. And it's useful for the core team, because it's less distracting - we don't have to drop what we're doing to fix CI, or ignore warnings or errors in our builds.
We might not be able to have perfectly reproducible builds, but we can:

eliminate spurious errors,
change how we present them, or
provide a stable job for manual comparison.

We can do both stable and nightly - if GitHub actions has an allow failures or similar setting.

It does have an allow failures and its already allowed as far as I could tell when I just checked the settings.

As far as I can tell the CI configuration is already in the state described by this issue. This does however seem to be non obvious with the current github ui, so if there's a setting to more clearly separate jobs that are and aren't required we should definitely enable that.

Yeah, I'm used to Travis CI, which has a yellow marker (?) for failed allow failures jobs, and a build summary marker which ignores allow failure jobs.
Does the Google Cloud trigger run a stable clippy job?
If not, we should add a stable clippy job for comparison.
I'll also write a TODO list in the ticket summary, so we can track what we want to do as part of the ticket.

Okay, so gcloud is stable, that's good.
Can we add a separate stable clippy job that's allow failure?


feat: migrate image_preview using sidekiq

Describe the changes you have made in this PR -
Migrate Image preview to amazon s3 using background jobs
Usage
MigrateImagePreviewJob.perform_async

Don't wrap everything inside a single job. Also it doesn't make sense to call a rake job from a sidekiq worker


Error from Swift.classes

using frida 15.1.5
spawning with frida like this: frida -U -f x.y.z
and then calling: Swift.classes throws always the following error:
Error: Failed to create symbolicator
at g (frida/node_modules/frida-swift-bridge/dist/lib/symbols.js:91)
at o (frida/node_modules/frida-swift-bridge/dist/lib/symbols.js:12)
at b (frida/node_modules/frida-swift-bridge/dist/lib/macho.js:133)
at N (frida/node_modules/frida-swift-bridge/dist/lib/types.js:354)
at g (frida/node_modules/frida-swift-bridge/dist/lib/types.js:40)
at o (frida/node_modules/frida-swift-bridge/dist/lib/registry.js:18)
at shared (frida/node_modules/frida-swift-bridge/dist/lib/registry.js:44)
at get classes (frida/node_modules/frida-swift-bridge/dist/index.js:38)

Could you try with the freshly released Frida 15.1.6? Also which platform are you using?

@arcanegrowl @savveex Could you folks try again with the latest from git? Just clone it then npm run install && npm run build then frida -U -f x.y.z -l _agent.js

For me that fixes the issue :) Thanks for quick support


docs: add javascript marshaling example

Description

Added example/js-generate-marshalling
Modified docs/language/javascript.md

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.05%) to 93.5%

Totals

Change from base Build<PHONE_NUMBER>:
0.05%

Covered Lines:
2490

Relevant Lines:
2538

💛  - Coveralls

LGTM 👍 Do you mind changing the title of the PR to docs, as this is not a feature people can use, this is more towards the documentation and testing 🙂
Also maybe docs: add javascript marshaling example is a more accurate title🤔 What do you think?

Done 😊

@all-contributors please add @Samridhi-98 for code, test, docs, example


[Feature] Measure internal RTT

It would be useful to track the rtt internal to snarkos for received message -> sent response as this is currently still an issue in bootnodes.

Closed by #1073.


navbar brand name link

hello @arpitghura I think the navbar brand name Typing Test should be a link pointing to the homepage and not just a level one heading thereby the home button will not be needed,  I could work on it if approved and assigned, thank you

Good Idea, you can start your work.

@arpitghura thank you, done and submitted a pull request


html/css paths not resolved correctly

Need to add moduleId to component definition in order for angular to resolve template/css file paths correctly.
Currently, when using systemjs, the html/css files do not load (404).

Hi @scotmeiste,
I have tried manually adding your change and building the module, but still having the same issue. Did you make it work?

yeah, it did work for me.
you might try also deleting the './' portion of the templaturl as well. like this:
templateUrl: 'ng2-datepicker.component.html',


Start/Stop-Transcript does not capture everything written to the console

Start/Stop-Transcript does not always capture everything written to the console.
I created a github repo with code, repro steps and more context: https://github.com/zammitt/PowerShellTranscriptIssue
Steps to reproduce
In a script file (.ps1)

Start-Transcript
Run a Cmdlet that outputs data with WriteObject
Stop-Transcript
Observe that the output was not written to the transcript

Here is a script to repro:
Install-Module TranscriptIssue
Import-Module TranscriptIssue

Start-Transcript -Path transcript.txt -UseMinimalHeader

Write-Output "Hello from Write-Output"
Write-Host "Hello from Write-Host"

Test-TranscriptIssue

Write-Output "Goodbye from Write-Output"
Write-Host "Goodbye from Write-Host"

Stop-Transcript

# Write out the transcript to the console
cat ./transcript.txt

The code for Test-TranscriptIssue can be found here:  https://github.com/zammitt/PowerShellTranscriptIssue/blob/master/TestIssueOnPowerShellCore/Test-TranscriptIssue.cs
Expected behavior
The contents of the transcript match what was written to the console while the transcript was active.
Transcript started, output file is transcript.txt
Hello from Write-Output
Hello from Write-Host

Goodbye from Write-Host
TestProperty
------------
TestValue
Goodbye from Write-Output
Transcript stopped, output file is D:\code\PowerShellTranscriptIssue\TestIssueOnPowerShellCore\bin\Debug\netcoreapp3.0\transcript.txt
**********************
PowerShell transcript start
Start time:<PHONE_NUMBER>0138
**********************
Hello from Write-Output
Hello from Write-Host

Goodbye from Write-Host
TestProperty
------------
TestValue
Goodbye from Write-Output
**********************
PowerShell transcript end
End time:<PHONE_NUMBER>0138
**********************

Actual behavior
The transcript is missing data that was written to the console while the transcript was active.
Transcript started, output file is transcript.txt
Hello from Write-Output
Hello from Write-Host

Goodbye from Write-Host
TestProperty
------------
TestValue
Goodbye from Write-Output
Transcript stopped, output file is D:\code\PowerShellTranscriptIssue\TestIssueOnPowerShellCore\bin\Debug\netcoreapp3.0\transcript.txt
**********************
PowerShell transcript start
Start time:<PHONE_NUMBER>0138
**********************
Transcript started, output file is transcript.txt
Hello from Write-Output
Hello from Write-Host

Goodbye from Write-Host
**********************
PowerShell transcript end
End time:<PHONE_NUMBER>0138
**********************

Environment data

Name                           Value
----                           -----
PSVersion                      6.2.3
PSEdition                      Core
GitCommitId                    6.2.3
OS                             Microsoft Windows 10.0.17134
Platform                       Win32NT
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0…}
PSRemotingProtocolVersion      2.3
SerializationVersion           <IP_ADDRESS>
WSManStackVersion              3.0

TLDR:

Mixing and matching objects, strings, and write-host with transcription is really tricky.

I’m not sure this is a bug, per se, but a subtle interaction between the script and how transcription works with our pipelines. I will agree that it is in no way intuitive.
One of the things that happen when you emit objects is that the formatting of those objects gets handled by out-default, but after the script has completed and since transcription has stopped, that output doesn’t get transcribed. Strings are handled differently, they’re sometimes short-circuited through formatting (but sometimes not). The combination of write-host (which makes an immediate write), write-object  (which may get short-circuited through formatting), and output of a  makes this pretty hard to reason about what’s going to happen. However, there may be a way that you may want to try (See “A POSSIBLE WAY” below).
Even more details:
Here are a couple of variations on the theme:
Variation 1 – your scenario, with the output of a structured object at the end of all of the other operations.
PS> cat s2.ps1
remove-item s2 -ea ignore
start-transcript s2 -usemin
write-host "1"
write-output "2"
get-location
write-host "4"
write-output "5"
stop-transcript

PS> ./s2.ps1
Transcript started, output file is s2
1
2

4
Path
----
/Users/jimtru/src/projects/transcript
5
Transcript stopped, output file is /Users/jimtru/src/projects/transcript/s2

This one is really confusing, but explainable (but perhaps not satisfying). ‘Write-Host 4’ is visible before get-location because Write-Host is hot-rodded directly into the host and emitted (there’s code in transcription which essentially tees the output to the transcript file and the console). Then we have the regular output of get-location and write-output 5 sent as output of the script.
Since transcription is turned off before the script exits, it’s not rendered in the transcript, because the objects were sent to the next consumer in the pipeline (in this case, it’s out-default which is what the engine does automatically). The tricky bit is that strings are also somewhat hot-rodded in our formatting, so the first write-output 2 gets emitted and captured by the transcript, but the insertion of the get-location object causes it to be pushed into the stack of things that need actual formatting, which sets a bit of state for any remaining objects which may need formatting (which is why the second write-output 5 doesn’t get transcripted.
**********************
PowerShell transcript start
Start time:<PHONE_NUMBER>4858
**********************
Transcript started, output file is s2
1
2

4
**********************
PowerShell transcript end
End time:<PHONE_NUMBER>4858
**********************

Variation 2 – move the object emission to the beginning
start-transcript s3 -usemin
get-location
write-host "1"
write-output "2"
write-host "4"
write-output "5"
stop-transcript

We can see that the write-host happen before anything, and then the objects start to come out. The string output essentially forces the object to be rendered to the screen, but you’ll notice that the transcript contains only the output of Write-Host. That’s because those were piped to the formatting after the script turned off transcription.
PS> ./s3.ps1
Transcript started, output file is s3

1
4
Path
----
/Users/jimtru/src/projects/transcript
2
5
Transcript stopped, output file is /Users/jimtru/src/projects/transcript/s3

PS> cat s3

**********************
PowerShell transcript start
Start time:<PHONE_NUMBER>5142
**********************
Transcript started, output file is s3

1
4
**********************
PowerShell transcript end
End time:<PHONE_NUMBER>5142
**********************

Variation 3 – object emission at the end:
We can see that everything but the object is now in the transcript
PS> cat s4.ps1
start-transcript s4 -usemin
write-host "1"
write-output "2"
write-host "4"
write-output "5"
get-location
stop-transcript

Here’s the execution flow
PS> ./s4.ps1
Transcript started, output file is s4
1
2
4
5

Path
----
/Users/jimtru/src/projects/transcript
Transcript stopped, output file is /Users/jimtru/src/projects/transcript/s4

And the content of the transcript
**********************
PowerShell transcript start
Start time:<PHONE_NUMBER>5255
**********************
Transcript started, output file is s4
1
2
4
5

**********************
PowerShell transcript end
End time:<PHONE_NUMBER>5255
**********************

A Possible Way
Lastly, here’s a slight variation on the original, but now everything will be in the transcript. I’ve taken the code of interest and am calling the formatter forcefully via out-default. You’ll notice that the last Write-Host call is still out of order, that’s because of the short-circuiting of write-host which is a direct call into the host and does not go into the output stream.
start-transcript s5 -usemin
.{
    write-host "1"
    write-output "2"
    get-location
    write-host "4"
    write-output "5"
} | out-default
stop-transcript

Here’s the execution, followed by the transcript
PS> ./s5.ps1
Transcript started, output file is s5
1
2

4
Path
----
/Users/jimtru/src/projects/transcript
5

Transcript stopped, output file is /Users/jimtru/src/projects/transcript/s5

PS> cat s5
**********************
PowerShell transcript start
Start time:<PHONE_NUMBER>5701
**********************
Transcript started, output file is s5
1
2

4
Path
----
/Users/jimtru/src/projects/transcript
5

**********************
PowerShell transcript end
End time:<PHONE_NUMBER>5701
**********************

I suggest adding a new option. Allows it to output color documents

@JamesWTruher Thank you for the detailed reply.  Out-Default works great!   I ended up using the -Transcript flag so that the objects are still passed forward on the pipeline.
@he852100 I'll second this.  Color in transcripts would be awesome.

My one question to that is always going to be -- how? PS works with text files, not formatted documents. The next step up would perhaps be Markdown, which would be messier to read in the console, and still doesn't natively support color formatting. That should probably be a whole other issue discussion, though. 😉

My one question to that is always going to be -- how? PS works with text files, not formatted documents. The next step up would perhaps be Markdown, which would be messier to read in the console, and still doesn't natively support color formatting. That should probably be a whole other issue discussion, though. 😉

@PowerShell/powershell-committee reviewed this, we believe a complete solution for transcription (like the unix script command) would love to see the community build a new cmdlet (published to PSGallery) that uses ptty or on Windows grabbing the screen buffer, but the ask is out of scope for the current transcription framework.

Dear Microsoft - when are you going to fix this?  @SteveL-MSFT this is critical functionality - how is it "out of scope"?  It is critically important that bedrock Microsoft capabilities actually solve problems at scale and this is a huge gap

To complete the picture of the current problems and limitations:

Interactive prompts are never transcribed - unlike with the Unix script utility, you neither see the prompt string nor what the user typed.

#4645 describes duplicated output in transcripts and situationally changed behavior when transcript ion is used.

As for the Out-Default workaround for the issue at hand:

Given that we shouldn't promote use of Out-Default in user code, Out-Host is the better choice, but it is still a flawed workaround:

You lose the ability to capture any output from the script.
Due to #11134, stderr output from external programs will be missing from the transcript.

On Unix-like platforms, use of the script utility already is an option to bypass all these issues (albeit not from within  a script), while additionally providing:

capturing of VT sequences (ANSI escapes)
capturing of interactive prompt strings and what the user typed

However, the PSReadLine module doesn't play nice with the latter in Read-Host calls; e.g. (on Linux):
# Transcribe an interactive PowerShell user prompt.
# Save the transcript in file .\typescript
script -c 'pwsh -nop -c "read-host prompt"'

If you type abc when prompted, the transcript won't contain just string abc, but equivalent following, which makes the terminal go haywire when you cat the resulting file; note how each letter typed caused the inclusion of VT sequences and reprinting of all letters typed so far:
`e[?1h`e=prompt:·`e[6na`e[62;9Hab`e[62;9Habc

Just discovered that Start-Transcript typically captures little to no output from ROBOCOPY.

PSTranscriptAndRobocopy.zip
Would there be a workaround?

I see the problem in 7.1.0 (as you do), and also still in in 7.2.0-preview.1.
Appending | Out-Host is a workaround for PS Core (none needed for WinPS), though the formatting is a bit off.

I was playing with .Net Interactive notebooks & looking into this for why this issue with Notebooks occurs https://github.com/dotnet/interactive/issues/1430 as this is a crucial item that needs fixed before I can recommend to Jupyter Notebooks using .Net Interactive to users in production environments that will have org wide transcription enforced, & I would like to be able to recommend using them without needing to resort to a non-workable workaround cc @SteveL-MSFT

This is pretty disappointing, it's one of those things you expect to just work when you find it, and then you check your log file and it's got 20 lines out of tens of thousands.

Same problem when you try to run PowerShell 7 code with Start-Transcript from a PowerShell 5 session. You see the output in PowerShell 5, but when you check the log file that Start-Transcript output to, it is missing a lot of the output.

Any dev update on this? I might have stumbled over this error, just wondering if it was fixed in the meantime.

This issue still exists and it is worse than ever. It was not good in PS5 but in PS7 even worse.
Start-transcript can't literally be used
This is a crutial feature. Please fix it. This issue started before 2015.
PowerShell is great, Windows Terminal is great, but due this I will have to switch some third party solution like Moba Xterm which actually can log everthing without any issue.

@SteveL-MSFT - This issue is still prevalent. I can reproduce the Start-Transcript issue if the Invoke-RestMethod commandlet is called with a POST method.
In my case, the workaround of utilising | Out-Host (mentioned above) on PS 7.2.5 still does not produce any viable command invocation output (for monitoring/auditing) - whether the command succeeds or fails:
**********************
Command start time:<PHONE_NUMBER>0610
**********************
PS>TerminatingError(Invoke-RestMethod): "{ "statusCode": 401, "message": "Unauthorized. Access token is missing or invalid." }"

If I append -Verbose and -Debug on the Invoke-RestMethod command, then I lose the Invocation Header data (e.g.: Command start time:) from the transcript for the command - which makes it even harder to determine the details of the command that was run (when a failure doesn't occur):
VERBOSE: DELETE with 0-byte payload
VERBOSE: received 85-byte response of content type application/json
>> TerminatingError(Invoke-RestMethod): "{ "statusCode": 401, "message": "Unauthorized. Access token is missing or invalid." }"

As it appears that there hasn't been any traction on this - for quite some time - is it possible to help the community derive a work-around for the[se] issue[s], until it[they] can be addressed in the code-base?

I hope people understand that if this was easy to fix, we would have done it.  The transcription code is more than 10 years old and its design has limitations not easily addressed.  The robocopy example above is an example where the NativeCommandProcessor has an optimization where if a native command is at the end of the pipeline, then it doesn't read the stdout pipe and instead just has the exe send the output directly to the console.  In this case, transcription is not aware (since PowerShell is not aware) of any output.  Piping to a cmdlet works around this optimization.
It would actually be easier to create a script-like executable (perhaps called transcript.exe that does what script does which is start a new instance of the shell that ran it and read stdout/stderr/stdin and write that to a file while also passing it through to the shell.  Doing it within the shell is problematic due to output being "leaky".

Then what's the point of this command if the transcription cannot be relied on? This is just an extreme flaw for a crucial and basic cmdlet

if this was easy to fix, we would have done it

If it weren't vital functionality, why would the community want it? Your team only fixes easy problems?
If it can't be done, remove it.

If it can't be done, remove it.

I'd rather have PowerShell with limited transcript functionality than with none at all.

While I agree that Start-Transcript is fairly useless due to this problem and not capturing the output from executables, if anyone has a workaround for this problem, please post it here. A suitable workaround could include something like:

A new function such as recommended here: https://github.com/PowerShell/PowerShell/issues/10994#issuecomment-572306095; or
A new host process that can "tee" the output to file.

@SteveL-MSFT currently, the documentation for Start-Transcript says:

The transcript includes all command that the user types and all output that appears on the console.

Would it be possible to at least list the limitations of the current command, such as not capturing the output from executables in the documentation to save people a lot of time wondering why it's not working as documented?

It does capture executable output, but only 10 or so on hundreds. Since it looks like it works for a few lines test, I discovered after the fact that all my logs are worthless.

My understanding of the issue is that this is a race. If PowerShell doesn't "flush" output before Stop-Transcript is executed, the output gets lost. In my scripts, I think I'm seeing that sometimes output lands, and sometimes it's lost.
Regarding workarounds: is it possible to force PowerShell to flush? I would just do it before Stop-Transcript, problem solved?

Ok i just discovered the reason why the transcript for choco list -localonly -all saves literally 9 out of 151 lines of output....
And it saves absolutely nothing if i pipe to grep (choco list -localonly -all | grep -i a)

My understanding of the issue is that this is a race. If PowerShell doesn't "flush" output before Stop-Transcript is executed, the output gets lost. In my scripts, I think I'm seeing that sometimes output lands, and sometimes it's lost.
Regarding workarounds: is it possible to force PowerShell to flush? I would just do it before Stop-Transcript, problem solved?

Mmh that's not a bad idea, if that is really the culprit.. so far i tried the following but it didn't do anything, maybe someone knows something more?
PS>[console]::OpenStandardOutput().Flush()
PS>[console]::OpenStandardError().Flush()
PS>[console]::Out.Flush()
PS>[console]::Error.Flush()

Yesterday found out that Start-Transcript also does not capture the output from VScode command-line operations such as code --install-extension foo. One more case that makes it essentially useless...

This project claims to redirect all PowerShell output to the console to a transcript file...
https://github.com/dlwyatt/PowerShellLoggingModule
However, it hasn't been updated in a while and the latest release on PS Gallery isn't based on the latest source.
https://www.powershellgallery.com/packages/PowerShellLogging

is it fixed at least?

not fixed yet...???

This project claims to redirect all PowerShell console output to a transcript file...
https://github.com/dlwyatt/PowerShellLoggingModule
However, it hasn't been updated in a while and the latest release on PS Gallery isn't based on the latest source.
https://www.powershellgallery.com/packages/PowerShellLogging

 GitHub**GitHub - dlwyatt/PowerShellLoggingModule: Automatically capture and save PowerShell console output from a script (without the limitations and headaches of Start-Transcript)**Automatically capture and save PowerShell console output from a script (without the limitations and headaches of Start-Transcript) - GitHub - dlwyatt/PowerShellLoggingModule: Automatically capture ...

**PowerShellLogging 1.3.0**Captures PowerShell console output to a log file.

The about_PowerShellLogging file warns about this module breaking easily as it is using private members of the PowerShell classes

There do not appear to be many viable (actively maintained) workarounds on GitHub at all from what I can find, but of the few available, the above does appear to be in functioning condition and with the relatively highest level of engagement.  I haven't tried it yet but will report back once I do.

https://github.com/dlwyatt/PowerShellLoggingModule


add varodrig as member to kubeflow org

Resolve: https://github.com/kubeflow/internal-acls/issues/710
Contributions
PRs:
https://github.com/kubeflow/website/pull/3878
https://github.com/kubeflow/website/pull/3899
https://github.com/kubeflow/website/pull/3901
Issues created:
https://github.com/kubeflow/website/issues/3900
pytest output:

@hbelmiro @rimolive

waiting for @rimolive

+1
/lgtm

cc @terrytangyuan


[WIP] Test

Purpose
Describe the problem you want to address or the feature you want to implement.
Approach
Describe how your changes address the issue or implement the desired functionality in as much detail as possible.
References
Provide a link to the existing issue(s), if any.
Pre-Merge TODO

[ ] Write tests for your proposed changes
[ ] Make sure that existing tests do not fail

@testcafe-build-bot \retest

@testcafe-build-bot \restart

@testcafe-build-bot \retest