Apps with healthchecks from 2.0 are broken in 2.1

@bacongobbler
I have so far produced this twice with 2 separate applications.  The only fix so far for me was to destroy the application.
Deployment
Creating build... ...Error:
400 Bad Request
detail: public-v49-cmd (app::deploy): ('failed to create ReplicationController "public-v49-cmd" in Namespace "public": 422 status code 422\n{\'metadata\': {}, \'code\': 422, \'reason\': \'Invalid\', \'kind\': \'Status\', \'status\': \'Failure\', \'message\': \'ReplicationController "public-v49-cmd" is invalid: spec.template.spec.containers[0].livenessProbe.httpGet.port: Invalid value: "80": must be an IANA_SVC_NAME (at most 15 characters, matching regex [a-z0-9]([a-z0-9-]*[a-z0-9])*, it must contain at least one letter [a-z], and hyphens cannot be adjacent to other hyphens): e.g. "http"\', \'details\': {\'name\': \'public-v49-cmd\', \'causes\': [{\'message\': \'Invalid value: "80": must be an IANA_SVC_NAME (at most 15 characters, matching regex [a-z0-9]([a-z0-9-]*[a-z0-9])*, it must contain at least one letter [a-z], and hyphens cannot be adjacent to other hyphens): e.g. "http"\', \'reason\': \'FieldValueInvalid\', \'field\': \'spec.template.spec.containers[0].livenessProbe.httpGet.port\'}], \'kind\': \'ReplicationController\'}, \'apiVersion\': \'v1\'}', 'public-v49-cmd', 'public')

List
deis healthchecks:list -a public
=== public Healthchecks

--- Liveness
Initial Delay (seconds): 10
Timeout (seconds): 50
Period (seconds): 10
Success Threshold: 1
Failure Threshold: 3
Exec Probe: N/A
HTTP GET Probe: Path="/" Port=0 HTTPHeaders=[]
TCP Socket Probe: N/A

--- Readiness
No readiness probe configured.

Unset and set fail
deis healthchecks:unset liveness -a public
Removing healthchecks... Error: This action could not be completed due to a conflict.

Why would the port need to be an IANA_SERVICE_NAME? Gonna ping @helgi on this one for clues.

@bacongobbler @helgi fixed something prior that was related to I think ports being a string back prior to 2.0
If i look at my pods they are defined as
    Liveness:		http-get http://:80/ delay=10s timeout=50s period=10s #success=1 #failure=3
    Readiness:		http-get http://:80/ delay=10s timeout=50s period=10s #success=1 #failure=3

so it's odd that deis healthchecks:list says the Port is 0

Yeah ports have to be strings, otherwise kubernetes will think it is a named port

Ehh it had to be an integer, not a string

I'm guessing with the healthcheck changes @helgi port change may of gotten broken

But I wonder why it's affecting my situation and not others

so it's odd that deis healthchecks:list says the Port is 0

To explain this, the old legacy healthchecks do not require a port. It is "magically" obtained by inspecting the image internally before being deployed. The downside of this is when an application exposes multiple ports, the controller cannot determine which one to healthcheck, and the user cannot change this behaviour. It is now required for the user to add a port to any httpGet healthchecks to avoid this "magic logic". Being explicit in this case is better.
Since it is unavailable in the controller response, the CLI must parse the JSON object and return something so it displays zero.
In any case, #857 should resolve this regression.

@bacongobbler my app actually has the PORT environment variable set

#857 converts it to a proper int. It's old logic from release.get_port where in cases when the user has set PORT, it is returned as a string instead of an int. We missed the casting logic so that situation was missed out. If you didn't set PORT and the port number was inferred from the image, then this would not have occurred. Essentially this only happens in one specific edge case:

you have HEALTHCHECK_* environment variables set for healthchecks
you have manually set PORT

Those two conditions must be met in order to trigger this bug. As a temporary workaround, you can remove your HEALTHCHECK_* environment variables and move to deis healthchecks instead.

deis config:unset HEALTHCHECK_URL
Removing config... Error: Unknown Error (400): map[detail:public-v11-cmd (app::deploy): ('failed to failed to update Secret "public-v11-env" in Namespace "public": 400 Bad Request\n{\'status\': \'Failure\', \'code\': 400, \'message\': \'Secret in version "v1" cannot be handled as a Secret: [pos 264]: json: error decoding base64 binary \\\'/\\\': illegal base64 data at input byte 0\', \'reason\': \'BadRequest\', \'apiVersion\': \'v1\', \'metadata\': {}, \'kind\': \'Status\'}', 'public-v11-env', 'public')]


combine cra enhancements and cve issues that came in on 5/7/2021

On cra:

need to add support for PUBLIC_URL at build time
fix branch name is fixcra

fixed


arch: arm: userspace: don't subtract MPU guard from top of stack

ip register holds the stack_info.size (it is passed as argument
into z_arch_user_mode_enter(.)). We trust that the value of
stack_info.size contains the accurate size of the writable
stack buffer, above stack_info.start (as specified in kernel.h).
Therefore, we do not need to subtract any bytes for the MPU
stack guard. This allows us to clean-up one more occurrence of
CONFIG_MPU_REQUIRES_POWER_OF_TWO_ALIGNMENT in userspace.S.
Signed-off-by: Ioannis Glaropoulos<EMAIL_ADDRESS>

Yet another removal of the unwanted CONFIG_MPU_REQUIRES_POWER_OF_TWO_ALIGNMENT from arch/arm code. This seems to be actually a minor bug, eating up 32 bytes from the stack of a user thread.

@andrewboie please, take a quick look; do you think we should back-port this one?

Yet another removal of the unwanted CONFIG_MPU_REQUIRES_POWER_OF_TWO_ALIGNMENT from arch/arm code. This seems to be actually a minor bug, eating up 32 bytes from the stack of a user thread.

Yes, the mpu guard for thread stack has already been take care in z_new_thread when thread is setup.

The stack_info is under CONFIG_THREAD_STACK_INFO, we can see this in function z_new_thread_init, but I see several places using stack_info directly without CONFIG_THREAD_STACK_INFO wrapped like function z_arch_user_mode_enter, do I miss something?
@ioannisg

The stack_info is under CONFIG_THREAD_STACK_INFO, we can see this in function z_new_thread_init, but I see several places using stack_info directly without CONFIG_THREAD_STACK_INFO wrapped like function z_arch_user_mode_enter, do I miss something?
@ioannisg

@wentongwu For ARM, THREAD_STACK_INFO is selected under two cases

build with MPU support (ARM_MPU)
build with BUILTIN_STACK_GUARD support (ARMV8-M), not necessarily with MPU support.

If you see it being used outside these two cases, this is a (serious) bug.

The stack_info is under CONFIG_THREAD_STACK_INFO, we can see this in function z_new_thread_init, but I see several places using stack_info directly without CONFIG_THREAD_STACK_INFO wrapped like function z_arch_user_mode_enter, do I miss something?
@ioannisg

@wentongwu For ARM, THREAD_STACK_INFO is selected under two cases
* build with MPU support (ARM_MPU)

* build with BUILTIN_STACK_GUARD support (ARMV8-M), not necessarily with MPU support.

If you see it being used outside these two cases, this is a (serious) bug.

OK, thanks for the info.

@andrewboie could you review this minor patch, too?


Treat Anaconda environments as virtualenvs

The current behaviour when performing an installation (python setup.py install) in an Anaconda environment is to raise an error. Anaconda should be recognized as an acceptable implementation of python as it mimics virtualenv if managed properly.

I made a 180 deg turn and I'm now bullish on :snake: !

I made a 180 deg turn and I'm now bullish on :snake: !


Support for download explode

Similar to the build info version of spec files (https://www.jfrog.com/confluence/display/RTF/Using+File+Specs#UsingFileSpecs-DownloadSpecSchema) I would like to request the support for "explode" parameter also for the CLI version.
The overall rational is to have one spec file and allow the usage of the CLI tool for developer environment and the build info version in a Jenkins environment. thanks!

@MichaelSiggelkowRnS,
Version 1.14.0 has bee released and includes a new --explode option for the rt download command.
We'd appreciate your feedback for the new functionality.

Hai Just want to check that this --explode option will also preserve the symlink on downloading a zip from artifactory?.

@Dineshk77,
The explode option does nothing more than extracting an archive when it is download. The exploded archive structure and content should therefore be preserved.

@Dineshk77,
Please let us know if you see that the symlinks are not preserved or if you need further assistance.

@eyalbe4 Yes the symlinks are not preserved. I am trying to download a .zip from artifactory using the latest jfrog cli.
command used - jfrog rt dl --flat=true --explode=true --threads=30 source target
Package is downloaded and extracted perfectly to the mentioned target. However the symlinks weren't preserved. Please let me know if any other option has to be used. thanks.
OS - MAC.

@Dineshk77,
How was the zip created initially?

@eyalbe4 Zip file was created on the linux machine using the zip command. when I unzip using unzip command all the symlinks are preserved.

@eyalbe4 i am using jfrog 16.2, i have a zip with symlinks inside.
when i use the explode option symlinks are broken. if i unzip manually they work fine.
i tried using option "symlinks":"true" and  "validate-symlinks": "true" doesnt help.

I have also just discovered that downloading a tgz archive with explode=true doesn't preserve symlinks.
If I download it with explode=false and then extract the archive with tar it does preserve symlinks.

I didn't have issue with symlinks using jfrog CLI on Linux, however using rtDownload [1] I do have the problem.


GoogleApiClient not yet connected issue

Hi,
When clicking the "request updates" button in the app, I always get the toast "GoogleApiClient not yet connected. TryAgain."
I cloned the repo and installed as is on a Galaxy Note running Marshmallow 5.0. Couldn't find a fix yet, any ideas?

@hessmess the LocationUpdates sample has been updated, it no longer uses GoogleApiClient and should not have issues like this anymore.  Take a look!

"Accessing Google APIs with GoogleApiClient (deprecated)"
https://developers.google.com/android/guides/google-api-client
Does that mean building GoogleApiClient to access FusedLocationProviderClient is no longer needed?


doclets.io not picking up changes

I'm trying to progressively add documentation to my repository over at https://github.com/YoloDev/nitter using the add-to-doclets branch. However, doclets.io stopped showing my changes after a few updates, and now I can't seem to get it to work again. I've even tried deleting and recreating the branch, but it doesn't work. Please help.

For the add-to-doclets branch it is still working for me. But updates on other branches are no longer detected, and also detecting new branches only worked in a single case.

Hi! Thanks for using doclets... and sorry for the trouble.
I cloned your repo and the add-to-doclets branch works just fine for me. I also ran some changes in the README.md to see if the generated pages update. Everything worked as expected.
https://doclets.io/lipp/nitter/add-to-doclets/overview
However, your latest add-to-doclets branch commit is ahead/newer with respect to the doclets.io version. @Alxandr is your repo still enabled within doclets? If so, could you please check your repo webhook settings in github? There should be an entry for doclets.io service.
There were some fixes concerning the doc generator workqueue going on some days ago. But this shouldn't have any impact...
@tf per default master and add-to-doclets branches are enabled. .doclets.yml

I'm guessing the issue stems from me doing a forced update to the branch (which doclets really need to support). I did git commit --amend followed by git push -f. This makes the branches out of sync and then force-updates the one on github. So maybe your cloning code is breaking?

@Alxandr thanks for the details. I guess you are right...
Do you know, how to determine if the cloned repo got out-of-sync?
This is the code, which handles the checkout on push events (to help you get an idea what is going on right now...):
https://github.com/lipp/doclets/blob/master/lib/repo.js#L78

Quick googling gave me this: http://stackoverflow.com/a/3278427/213323 which is probably exactly what you need. Translating the bash-script to JS should also be fairly easy. If the branches has diverged git pull will fail as far as I know. Although, what you could (probably) do, which (I think) would work regardless is just do git fetch origin master followed by git checkout origin/master. Or even better, do the git fetch, followed by figuring out the SHA1 of origin/master and then do git checkout <SHA1>. This will put you in a detached HEAD. So it doesn't really much matter what you do/what is done. Run the build from there, publish it, and you can just repeat the process next time.

@lipp Ah, I forgot about that. I guess I got confused since I pushed a branch doc-mod and saw it appear in the branch list and after following the link it simply said I was missing the config file.
But when I push other branches now, they do not show up. I see a successful webhook call, though. Maybe I've hit some sort of maximal count of items in the branch list?

After further tests, I can confirm that this is mainly related to branches that have been force pushed. Still not completely sure why some branches did not show up in the overview. But for new branches with a config file, everything seems to work fine.
I guess repo.js should rather git fetch and git reset --hard origin/branch instead of trying to checkout the branch and pull.

@lipp for now, could you just make a button somewhere that "force updates" a branch? So that when it gets stuck we can get it up and working again? And we can look at bettering it later. I can probably get involved with helping, even though I violently disagree with the no-semicolon convention :-/

@Alxandr thanks for the offer. Your help is very welcomed 👍
However, I'm going in vacation for 3 weeks, so unfortunately I won't risk  to make any quick-changes.
I hope you can proceed with your project and return to doclets as soon as this issue gets resolved.

@Alxandr @tf just added @tf's improvement. Could you give it a try?

Seems to be working :+1:

Great! Thanks!!!


Add Compressed form components, color-picker, and combobox, and small button components and filter-button

Description
In an effort to save on real-estate and improve look and feel in OSD, form elements and buttons which do not have explicit sizing attributes need to be made small or compressed. In the future, when we revisit the typography and sizing of OUI as a whole, it would be beneficial if explicitly sized components were distinguishable from others. This PR introduced some aliases that apply those small or compressed sizing attributes as defaults to facilitate easy reversal in the future, especially considering that over 3000 changes will be made in OSD and plugins.
Check List

[ ] New functionality includes testing.
[ ] New functionality has been documented.
[ ] All tests pass

[ ] yarn lint
[ ] yarn test-unit

[x] Update CHANGELOG.md
[X] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Im not getting the full picture here. It looks like we are introducing new compressed components here but i dont see any aliasing. Also if this is a temporary change, can we mark them as experimental so that we can remove them without a breaking change?

Im not getting the full picture here. It looks like we are introducing new compressed components here ...

The new components would ease the task of locating and reworking the thousands of changes that are going into OSD and plugins for the upcoming typography changes.

... but i dont see any aliasing.

Aliases in OUI are created at build-time.
Also if this is a temporary change, can we mark them as experimental so that we can remove them without a breaking change?

Yes! Added @internal.

Just to validate, the long term goal would be for these variants not to exist and just to use existing component + prop, right?

Just to validate, the long term goal would be for these variants not to exist and just to use existing component + prop, right?

Yes.


Discord username

Hey guys, what is your discord username or groups to join you guys?

botallen.com/discord Btw there is big button of discord in Readme


SVG support

Does it support svg as well? Is there any demo with svg?

Nice point. Will create one. Should be not that hard.

Thanks!

Just tried  and it worked like a charm. So, go ahead with no worries.

Cool, thanks!
I'll try to use it with our svg-based product.

:+1: Just let me know if there are difficulties, will figure them out.


Test another VNC servers

It is probably possible to use other VNC servers in the same way as using x11vnc. It would be interesting to compare the performances.

We have another dev working on a wayvnc implementation...


[ai-text-analytics] Add ability to access HTTP layer response

Currently, there isn't any way in Text Analytics to access the HTTP layer response, as is possible in Form Recognizer or Storage or any other library.
We have a guideline about this here: https://azure.github.io/azure-sdk/typescript_design.html#ts-responses
But it seems we missed this in Text Analytics and need to add it to 5.1.0.

I will replace core-http with core-https and core-client which will enable the user to send a callback to access the raw response.


⚠ Thumbnails API Endpoint has degraded performance

In 96e5be3, Thumbnails API Endpoint (https://thumbnails.roblox.com/v1/assets?assetIds=82738847&format=Png&isCircular=false&size=30x30) experienced degraded performance:

HTTP code: 200
Response time: 1996 ms

Resolved: Thumbnails API Endpoint performance has improved in d3fdd29.


Build fixes

This fixes all current build errors and updates CI configuration to the latest nightly with stabilized async/await.

Arrrgh
user@localhost ~/http-service> cargo publish
failed to select a version for the requirement `http-service-hyper = "^0.3.1"`

user@localhost ~/h/http-service-hyper> cargo publish
failed to select a version for the requirement `http-service = "^0.3.1"`

Oh, maybe it needs to relax the development dependency version requirement (0.3.1 -> 0.3)?

You will probably need to delete the dev-dependencies to be able to publish.

Yeah, sounds like a case of rust-lang/cargo#4242

Looks like I don't have the rights to publish, so someone else has to do the honor.

I can publish in a few hours if no-one else gets there first.

Uploaded http-service-hyper and http-service-mock, @yoshuawuyts need to fix http-service-lambda to make it available to the maintainers team.


Change type in values.yaml comment

The values.yaml comment in opentelemetry-collector and opentelemetry-kube-stack charts improperly refer to k8sobjects receiver in singular form.
Current snippet (Bad)
# Adds the k8sobject receiver to the logs pipeline

Proposed snippet (Good)
# Adds the k8sobjects receiver to the logs pipeline

Since the receiver is called k8sobjects, it will be proper to call it that. Referring it in singular form, causes users like myself to add k8sobject (singular form) to config.service.pipelines.logs.receivers, resulting in errors.

I added a commit here #1451


feat: add new module to autoconfigure grafana cloud

This PR adds a new module to simplify connecting to Grafana cloud by only having to specify the stack name and token.

I've fixed the things called out, should all be ready to merge now!


Cleanup

This branch is forked from the https://github.com/stellar/laboratory/pull/50 PR. Merge that one before merging this one.
This removes a lot of unused files/code. Tested and working.

+1


Revert RUBY to END token in specs

I stumbled across these wrong occurrences of __RUBY__ in the specs.
They were caused by an overzealous substitution in
8f37b7f2f0f4b01c2afa83fffdf531dfb4dce057, where heredoc delimiters such
as END were replaced – even inside __END__.

Good catch. Thanks!


Add mobilenet edgetpu defs for exp, add ol mobilenet v1 back for comp…

…leteness / comparison

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.


ParseLiteralDecimalNumberStyle

I had errors parsing scientific formatted numbers. How about adding NumberStyles.AllowExponent to Parser?
private const NumberStyles ParseLiteralDecimalNumberStyle = NumberStyles.AllowLeadingSign | NumberStyles.AllowDecimalPoint | NumberStyles.AllowExponent;

These options are currently defined inside the Parser class (link) but are anot configurable.
Maybe we can add a specific configuration for that. Any help/PR is appreciated ;-)


Jupyter plot viewer blocks horizontal scrolling

Type: Bug
Clicking on a very wide matplotlib or seaborn plot in the interactive plot viewer will allow it to be viewed in detail, however whenever I wish the view the rightmost side of the plot, there is a limit to how far I can drag the plot over. Typically about half-way. This can be reproduced by producing a very wide/horizontal plot and attempting the view the far right side.
Extension version: 2023.8.1002311100
VS Code version: Code - Insiders 1.82.0-insider (Universal) (85dab33f18ea9e16a36609cd203e1f18b1d76e45, 2023-08-16T10:06:03.563Z)
OS version: Darwin arm64 23.0.0
Modes:
Remote OS version: Linux x64 6.2.11-060211-generic

System Info

Item
Value

CPUs
Apple M1 (8 x 24)

GPU Status
2d_canvas: enabledcanvas_oop_rasterization: enabled_ondirect_rendering_display_compositor: disabled_off_okgpu_compositing: enabledmultiple_raster_threads: enabled_onopengl: enabled_onrasterization: enabledraw_draw: disabled_off_okvideo_decode: enabledvideo_encode: enabledvulkan: disabled_offwebgl: enabledwebgl2: enabledwebgpu: enabled

Load (avg)
77, 68, 75

Memory (System)
16.00GB (0.04GB free)

Process Argv
--crash-reporter-id 0c3e08e7-ea47-425a-9275-aa898d1457f4

Screen Reader
no

VM
0%

Item
Value

Remote
SSH: lab

OS
Linux x64 6.2.11-060211-generic

CPUs
AMD Ryzen Threadripper 3960X 24-Core Processor (48 x 2194)

Memory (System)
251.54GB (236.31GB free)

VM
0%

Duplicate of https://github.com/microsoft/vscode-jupyter/issues/9349


Part 1.2: Choose Your Data Attributes

I have chosen Analytics Vidhya.
this website gives clear and concise steps to perform analysis.


bugfix (TCOMP-364) : upgrade to jetty 9 to have servlet 3.1 dependency

Please check if the PR fulfills these requirements

[X] The commit message follows Talend standard
[X] Tests for the changes have been added (for bug fixes / features)

What is the current behavior? (You can also link to an open issue here)
The oauth component use servlet 3.0 dependency.
What is the new behavior?
The oauth component use servlet 3.1 dependency.
Does this PR introduce a breaking change?

[ ] Yes
[X] No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information:
unit test added

Pull request test result: failure :x:

Will Jetty 9.2 compatible with Jetty dependency which comes from Spring/Spring Boot.
The idea is to align version of Jetty (and other dependencies) across modules in TCOMP (components repo and daikon)

Jetty 9.2 is compatible with spring boot 1.4.1.

Pull request test result: failure :x:

There are some osgi test failing, I'll look into it right now.

Pull request test result: success :star:


Convert screenshots of text to syntax highlighted text in README

Rather than use screenshots of text in the README, prefer using real text blocks surrounded in 3 backticks.  A picture might be worth 1,000 words, but a picture of 1,000 words isn't :)

Thank you for the advice this has been updated!


Allow the sample rate to be specified

AWS has a SampleRate parameter: http://docs.aws.amazon.com/polly/latest/dg/API_SynthesizeSpeech.html#polly-SynthesizeSpeech-request-SampleRate

closed by e00d24c


Links in C++ 2015 redistributable EULA are broken

The following link in the C++ 2015 redistributable EULA redirects to a MicrosoftDocs page which is a 404.

http://go.microsoft.com/fwlink/?LinkID=523763&clcid=0x409

It would be nice if the redirect is corrected.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 637a643b-3eb6-8a64-4979-ccfc07822681
Version Independent ID: 86434874-40d2-d1d0-5551-a60620fad426
Content: Redistributing Visual C++ Files
Content Source: docs/ide/redistributing-visual-cpp-files.md
Service: visual-cpp
GitHub Login: @corob-msft
Microsoft Alias: corob

Thanks for reporting this. This particular issue appears to effectively be a duplicate of issue #235, since the same fix has fixed it.


CLI Installing dependencies when there is none.

BUG: Netlify CLI failed to deploy static HTML site and downloading dependencies when there is none
Current Behavior? Throw's an error
3:00:58 PM: Build ready to start
3:01:10 PM: build-image version: 9e0f207a27642d0115b1ca97cd5e8cebbe492f63
3:01:10 PM: build-image tag: v3.3.2
3:01:10 PM: buildbot version: 75cd99f62ada9e21edea53208e8baf0eab85a045
3:01:11 PM: Fetching cached dependencies
3:01:11 PM: Starting to download cache of 255.0KB
3:01:11 PM: Finished downloading cache in 99.158042ms
3:01:11 PM: Starting to extract cache
3:01:11 PM: Failed to fetch cache, continuing with build
3:01:11 PM: Starting to prepare the repo for build
3:01:11 PM: No cached dependencies found. Cloning fresh repo
3:01:11 PM: git clone git@github.com:unStackOfficial/unstack.dev
3:01:13 PM: Preparing Git Reference pull/61/head
3:01:14 PM: Starting build script
3:01:14 PM: Installing dependencies
3:01:16 PM: Downloading and installing node v10.16.0...
3:01:17 PM: Downloading https://nodejs.org/dist/v10.16.0/node-v10.16.0-linux-x64.tar.xz...
3:01:17 PM:
########
3:01:17 PM:                                            12.1%
3:01:17 PM:
##########################################
3:01:17 PM: ##########################      94.9%
3:01:17 PM:
#########################
3:01:17 PM: ############################################### 100.0%
3:01:17 PM: Computing checksum with sha256sum
3:01:17 PM: Checksums matched!
3:01:20 PM: Now using node v10.16.0 (npm v6.9.0)
3:01:21 PM: Attempting ruby version 2.6.2, read from environment
3:01:22 PM: Using ruby version 2.6.2
3:01:22 PM: Using PHP version 5.6
3:01:22 PM: Started restoring cached node modules
3:01:22 PM: Finished restoring cached node modules
3:01:22 PM: Installing NPM modules using NPM version 6.9.0
3:01:24 PM: npm
3:01:24 PM: failed during stage 'building site': Build script returned non-zero exit code: 1
3:01:24 PM: ERR!
3:01:24 PM:  file /opt/build/repo/package.json

Steps to reproduce: Ran Netlify Dev
Expected behavior: Deploy to a live URL
OS: Windows
Node: v12

this error log doesnt make sense at all. are you able to share a link to the repo? also, netlify dev isn't for deploying to a live URL. are you sure you are even using the CLI here? this error log seems like it is from our build bot.

this error log doesnt make sense at all. are you able to share a link to the repo? also, netlify dev isn't for deploying to a live URL. are you sure you are even using the CLI here? this error log seems like it is from our build bot.

My bad @sw-yx I meant netlify deploy, It's kind of a private repo and that happened. So when pushed to GitHub repo deployed perfectly well and passes all test but the local does not instead, throws that error I copied from the Netlify dashboard. It made no sense to me also, that's why I decided to ask for help here... :)

Fixed!


Clean up GitHub Issue/PR labels to match other NeuroPoly projects

Note: This is mostly for to-do tracking so that already ongoing work is properly documented.

Each NeuroPoly project has a slightly different approach to issue/PR labeling. (SCT's current guidelines are on the Contributing: Labelling issues and pull requests page.)
There is some ongoing Slack discussion between projects to settle on a unified label convention for all the projects. The checklist below provides some ideas/tasks for work to do in the SCT repo to bring the labels more in line with other projects.

[ ] Add category: to the description of Category labels for easier filtering (dark purple, white text)
[ ] Rename SCT Function labels to be Context labels (light purple, dark text)

[ ] Add context: to the descriptions for easier filtering, and to match ADS labels
[ ] Create new labels for spinalcordtoolbox API sections

[ ] Remove card: labels, because they are rarely used

[ ] Turn card:DESIGN DISCUSSION into it's own label, perhaps needs-discussion, because this one is used!

[ ] Remove fix: labels, because they are rarely used
[ ] Consider removing other unused labels, such as regression or meta
[ ] Update the Wiki with new guidelines

Oftentimes I'm not sure which label to use when it is about refactoring, removing stuff. Eg #2914
Should we rename "enhancement" as "refactoring"? and include enhancement in refactoring?

@jcohenadad AxonDeepSeg uses this description for their enhancement category:

category: the change expands an existing functionality or refactoring

So, your intuition is correct. :smile:

My one question: is there an "enhancement" that wouldn't fall under refactoring?
I guess an improvement that couldn't be labelled refactoring would just be labelled feature instead, so I think this makes sense to me.

So, your intuition is on-point. Perhaps the name for the label could be clearer, though, as you point out.

actually, i was the one who edited the ADS label description this morning 😉 ; then i let Marie-Hélène know that she should contact you so we can harmonize this across projects

@jcohenadad On second thought, looking at the issues tagged with enhancement, there are a lot that wouldn't fit into refactoring. So, I think this should actually be 2 categories.

enhancement: Makes an improvement to an existing feature (including performance improvements)
refactoring: Improves the structure/organization without changing functionality

The difference being "does the user notice a change in results/functionality". If yes, enhancement, if no, refactoring.

Also, on the topic of category changes, I think there are a few other categories that could be added:

documentation-internal: To differentiate between <readthedocs/sourceforge/courses> issues and <internal dev docs/github wiki> issues
git/github: Replaces the meta label, which wasn't a category, but probably should have been.
CI: Replaces the travis label, which wasn't a category, but probably should have been. This also allows us to include GitHub Actions and not just Travis.

I have removed 3 labels:

regression: A subset of bug that had hardly been used.
question: Only 1 user has ever asked a question using an issue. For SCT, our users will typically ask on spinalcordmri.org forum, so this label is not as useful in our case.
help wanted: No open issues had this label, and previously, it had only been used on issues from 2014. This could be revived if we begin to see contributions from the developer community, but even in that case, good first issue serves a similar purpose for onboarding.

I have modified the wiki page (Labelling issues and pull requests) to reflect the recent changes.
The page now covers all of the labels in the project (with updated filtering links).

I'm wondering if testing should not be a category label (dark purple), but instead a context label (light purple).
The reason I think this is, testing is often combined with other categories. For example, I see enhancement + testing a lot (an improvement to a test) and bug + testing (an error in a test). That's why I think it might be better suited to a context label.

I'm wondering if testing should not be a category label (dark purple), but instead a context label (light purple).
The reason I think this is, testing is often combined with other categories. For example, I see enhancement + testing a lot (an improvement to a test) and bug + testing (an error in a test). That's why I think it might be better suited to a context label.
I've changed it for now, but this is easily reversible, so let me know if it doesn't fit well.

that makes perfect sense to me. +1

I've done all that I was hoping to do on SCT's end of things, so I'm closing this. But, further discussion should be had between maintainers of different NeuroPoly projects to coordinate differences in labelling choices.
I'll stay in contact with @mariehbourget regarding ADS and we can go from there. :)

Thank you @joshuacwnewton! tagging @po09i and @charleygros @andreanne-lemay so we can also port these awesome initiatives to shimming-toolbox and ivadomed


Another default value bug

Live Demo
https://github.com/pik/polymer-default-value-issues/blob/master/polymer-default-value-issues.html
git clone and polymer serve go to the demo page.
In the child element which features the bug the baseConfiguration is defined as:
        baseConfiguration: {
          type: String,
          value: null
        },

But when _setupConfigurationFromDefaults(defaults) observer is called, the value of baseConfiguration is undefined. Curiously modifying defaults from
        defaults: {
          type: Object,
          value: null
        },

to
        defaults: {
          type: Object,
        },

Makes the bug disappear. No idea why really, since defaults in each case is actually passed correctly to the observer.
Versions

Polymer: 1.6.1

Please take a look at this section of the docs: https://www.polymer-project.org/1.0/docs/devguide/observers#dependencies
In Polymer 1.x property defaults are "set" to the element one-by-one; as such, a common mistake is to write code that relies on the order that the initial configuration of properties is applied.  The key way to avoid this is to always declare the dependencies for all of the properties that an observer reads, which will guarantee that the observer doesn't run until all of its dependent properties have their initial values.
In your _setupConfigurationFromDefaults method, you are reading from this.baseConfiguration even though it was not declared as a dependency.  Thus, your code will produce a different result depending on whether defaults is set before or after baseConfiguration's default value of null.  And case in point, whether the property was bound or not does in fact change the order that the initial properties are set.
To fix your code, simply declare baseConfiguration as a dependency to _setupConfigurationFromDefaults (this is the best fix and a pattern you should incorporate everywhere): http://jsbin.com/xebece/1/edit?html,output (<-- couldn't verify on jsBin due to the current github outage, but did test locally)


use gamma-ui: shim out ui builder code

this is a breaking change
use https://github.com/goolord/gamma-ui-nvim for the rendering code, the thought is that i can use this code as a library to construct several different types of vim guis

there is an an extremely small performance regression on my machine, like an extra 0.5ms to source alpha. i'll see what i can do to get that down, but this could be a pretty big W if you install more than one plugin that uses alpha-ui

first result is HEAD/main, second result is HEAD/alpha-ui
i think the difference would be smaller/nonexistent if lua had first class autocmd

actually the difference is like .2 ms with more samples, which seems more in line with what i would expect

it's so difficult to tell what of this is coincidence, but compiling the lua to its bytecode in gamma-ui and in alpha-nvim seems to have resulted in some significant performance improvements

this is pretty meh atm. i will reopen this when i feel more motivated to make new plugins / when lua gets more first class support in neovim ~


Liquidity / market details

User Story
As a liquidity provider
I want to be able to see the current spread of liquidity, fee levels, margin requirement, LP share and APY
So that I can understand the spread of liquidity provided right now and where I might fit in
Acceptance Criteria

There is a way to interact with a market to view secondary information about the liquidity provided and visually indicated i.e. mouseover, arrow icon
I can see per LP - party address, time in market, GALPS, Committed liquidity, margin req., 24h fees, fee level, APY
There is a way to go back to the market list

Dashboard sketch for reference https://miro.com/app/board/uXjVOs_PBKk=/?moveToWidget=3458764531971937952&cot=14
Visual styles (only) can be used from this early version of a design https://www.figma.com/file/qgCd4r61Z1r3tUkxKehhmu/Website-Design-Updates?node-id=399%3A20530

Preview link: https://deploy-preview-1802--liquidity-provision-dashboard.netlify.app/

GALPS are now replaced with "Equity-like share".

GALPS are now replaced with "Equity-like share".

Is this a new title or does that change what the value should be as well?

https://github.com/vegaprotocol/frontend-monorepo/pull/1802 has been merged now. I'll start digging into the other missing details

I'm going to reopen this as there's some missing fields that I'm working on adding now. @pennyandrews shout if that's not the right thing to do.


Build is failing can't figure out why.

[ 54%] Performing update step for 'grpc_src'
-- Already at requested tag: v1.25.0
[ 55%] No patch step for 'grpc_src'
[ 55%] Performing configure step for 'grpc_src'
CMake Warning (dev) at /Volumes/Dev/Web3/XAHAU/xahaud/.nih_c/unix_makefiles/AppleClang_<IP_ADDRESS>30022/Debug/src/grpc_src-stamp/grpc_src-configure-Debug.cmake:7:
  Syntax Warning in cmake code at column 419

  Argument not separated from preceding token by whitespace.
This warning is for project developers.  Use -Wno-dev to suppress it.

-- grpc_src configure command succeeded.  See also /Volumes/Dev/Web3/XAHAU/xahaud/.nih_c/unix_makefiles/AppleClang_<IP_ADDRESS>30022/Debug/src/grpc_src-stamp/grpc_src-configure-*.log
[ 56%] Performing build step for 'grpc_src'
-- grpc_src build command succeeded.  See also /Volumes/Dev/Web3/XAHAU/xahaud/.nih_c/unix_makefiles/AppleClang_<IP_ADDRESS>30022/Debug/src/grpc_src-stamp/grpc_src-build-*.log
[ 57%] No install step for 'grpc_src'
[ 58%] No test step for 'grpc_src'
[ 59%] Completed 'grpc_src'
[ 59%] Built target grpc_src
make[1]: *** [CMakeFiles/rippled.dir/rule] Error 2
make: *** [rippled] Error 2

@dangell7 helped a bit due to build only really working on linux at the moment.
error: no viable conversion from returned value of type 'bool' to function return type 'std::strong_ordering'     return std::lexicographical_compare_three_way(
was the error it was tripping up on, that bing said even commenting out that bit still did not get me much further as then the next one popped up
error: invalid operands to binary expression ('const base_uint<128UL, void>' and 'const base_uint<128UL, void>')     return (lhs <=> rhs) == 0;
https://github.com/XRPLF/rippled/pull/4411
know back porting support on its way so prob just close this one out?

I encountered the same problem, but solved it by uncommenting L552-L574 in base_unit and commenting out L576-586.
https://github.com/Xahau/xahaud/blob/6b26045cbce373388c8cd7603968d5612f531c08/src/ripple/basics/base_uint.h#L552-L586
It could be a problem caused by the following PR
https://github.com/Xahau/xahaud/pull/374

Can someone confirm this is fixed now?

assume one needs to check the dev branch and latest from there its still failing for me.
/Volumes/Dev/Web3/XAHAU/xahaud/src/ripple/basics/impl/make_SSLContext.cpp:94:20: warning: 'RSA_new' is deprecated [-Wdeprecated-declarations]
        auto rsa = RSA_new();
                   ^
/opt/homebrew/opt/openssl@3/include/openssl/rsa.h:212:1: note: 'RSA_new' has been explicitly marked deprecated here
OSSL_DEPRECATEDIN_3_0 RSA *RSA_new(void);
^
/opt/homebrew/opt/openssl@3/include/openssl/macros.h:194:49: note: expanded from macro 'OSSL_DEPRECATEDIN_3_0'
#   define OSSL_DEPRECATEDIN_3_0                OSSL_DEPRECATED(3.0)
                                                ^
/opt/homebrew/opt/openssl@3/include/openssl/macros.h:62:52: note: expanded from macro 'OSSL_DEPRECATED'
#     define OSSL_DEPRECATED(since) __attribute__((deprecated))
                                                   ^
In file included from /Volumes/Dev/Web3/XAHAU/xahaud/build/CMakeFiles/rippled.dir/Unity/unity_8_cxx.cxx:19:
/Volumes/Dev/Web3/XAHAU/xahaud/src/ripple/basics/impl/make_SSLContext.cpp:99:13: warning: 'RSA_generate_key_ex' is deprecated [-Wdeprecated-declarations]
        if (RSA_generate_key_ex(rsa, defaultRSAKeyBits, bn, nullptr) != 1)
            ^
/opt/homebrew/opt/openssl@3/include/openssl/rsa.h:271:1: note: 'RSA_generate_key_ex' has been explicitly marked deprecated here
OSSL_DEPRECATEDIN_3_0 int RSA_generate_key_ex(RSA *rsa, int bits, BIGNUM *e,
^
/opt/homebrew/opt/openssl@3/include/openssl/macros.h:194:49: note: expanded from macro 'OSSL_DEPRECATEDIN_3_0'
#   define OSSL_DEPRECATEDIN_3_0                OSSL_DEPRECATED(3.0)
                                                ^
/opt/homebrew/opt/openssl@3/include/openssl/macros.h:62:52: note: expanded from macro 'OSSL_DEPRECATED'
#     define OSSL_DEPRECATED(since) __attribute__((deprecated))
                                                   ^
In file included from /Volumes/Dev/Web3/XAHAU/xahaud/build/CMakeFiles/rippled.dir/Unity/unity_8_cxx.cxx:19:
/Volumes/Dev/Web3/XAHAU/xahaud/src/ripple/basics/impl/make_SSLContext.cpp:115:13: warning: 'RSA_up_ref' is deprecated [-Wdeprecated-declarations]
        if (RSA_up_ref(defaultRSA) != 1)
            ^
/opt/homebrew/opt/openssl@3/include/openssl/rsa.h:306:1: note: 'RSA_up_ref' has been explicitly marked deprecated here
OSSL_DEPRECATEDIN_3_0 int RSA_up_ref(RSA *r);
^
/opt/homebrew/opt/openssl@3/include/openssl/macros.h:194:49: note: expanded from macro 'OSSL_DEPRECATEDIN_3_0'
#   define OSSL_DEPRECATEDIN_3_0                OSSL_DEPRECATED(3.0)
                                                ^
/opt/homebrew/opt/openssl@3/include/openssl/macros.h:62:52: note: expanded from macro 'OSSL_DEPRECATED'
#     define OSSL_DEPRECATED(since) __attribute__((deprecated))
                                                   ^
In file included from /Volumes/Dev/Web3/XAHAU/xahaud/build/CMakeFiles/rippled.dir/Unity/unity_8_cxx.cxx:19:
/Volumes/Dev/Web3/XAHAU/xahaud/src/ripple/basics/impl/make_SSLContext.cpp:119:14: warning: 'EVP_PKEY_assign' is deprecated [-Wdeprecated-declarations]
        if (!EVP_PKEY_assign_RSA(pkey, defaultRSA))
             ^
/opt/homebrew/opt/openssl@3/include/openssl/evp.h:501:41: note: expanded from macro 'EVP_PKEY_assign_RSA'
#  define EVP_PKEY_assign_RSA(pkey,rsa) EVP_PKEY_assign((pkey),EVP_PKEY_RSA,\
                                        ^
/opt/homebrew/opt/openssl@3/include/openssl/evp.h:1337:1: note: 'EVP_PKEY_assign' has been explicitly marked deprecated here
OSSL_DEPRECATEDIN_3_0
^
/opt/homebrew/opt/openssl@3/include/openssl/macros.h:194:49: note: expanded from macro 'OSSL_DEPRECATEDIN_3_0'
#   define OSSL_DEPRECATEDIN_3_0                OSSL_DEPRECATED(3.0)
                                                ^
/opt/homebrew/opt/openssl@3/include/openssl/macros.h:62:52: note: expanded from macro 'OSSL_DEPRECATED'
#     define OSSL_DEPRECATED(since) __attribute__((deprecated))
                                                   ^
In file included from /Volumes/Dev/Web3/XAHAU/xahaud/build/CMakeFiles/rippled.dir/Unity/unity_6_cxx.cxx:16:
/Volumes/Dev/Web3/XAHAU/xahaud/src/ripple/app/tx/impl/Escrow.cpp:449:47: warning: '&&' within '||' [-Wlogical-op-parentheses]
            ctx.tx.isFieldPresent(sfEscrowID) &&
            ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~
/Volumes/Dev/Web3/XAHAU/xahaud/src/ripple/app/tx/impl/Escrow.cpp:449:47: note: place parentheses around the '&&' expression to silence this warning
            ctx.tx.isFieldPresent(sfEscrowID) &&
                                              ^
            (
/Volumes/Dev/Web3/XAHAU/xahaud/src/ripple/app/tx/impl/Escrow.cpp:732:47: warning: '&&' within '||' [-Wlogical-op-parentheses]
            ctx.tx.isFieldPresent(sfEscrowID) &&
            ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~
/Volumes/Dev/Web3/XAHAU/xahaud/src/ripple/app/tx/impl/Escrow.cpp:732:47: note: place parentheses around the '&&' expression to silence this warning
            ctx.tx.isFieldPresent(sfEscrowID) &&
                                              ^
            (
In file included from /Volumes/Dev/Web3/XAHAU/xahaud/build/CMakeFiles/rippled.dir/Unity/unity_12_cxx.cxx:7:
/Volumes/Dev/Web3/XAHAU/xahaud/src/ripple/nodestore/impl/Shard.cpp:715:35: error: use of undeclared identifier 'XRP_LEDGER_EARLIEST_FEES'; did you mean 'XRP_LEDGER_EARLIEST_SEQ'?
            (ledger->info().seq < XRP_LEDGER_EARLIEST_FEES ||
                                  ^~~~~~~~~~~~~~~~~~~~~~~~
                                  XRP_LEDGER_EARLIEST_SEQ
/Applications/Xcode_14.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX13.3.sdk/usr/include/assert.h:99:25: note: expanded from macro 'assert'
    (__builtin_expect(!(e), 0) ? __assert_rtn(__func__, __ASSERT_FILE_NAME, __LINE__, #e) : (void)0)
                        ^
/Volumes/Dev/Web3/XAHAU/xahaud/src/ripple/protocol/SystemParameters.h:69:32: note: 'XRP_LEDGER_EARLIEST_SEQ' declared here
static constexpr std::uint32_t XRP_LEDGER_EARLIEST_SEQ{1U};
                               ^
In file included from /Volumes/Dev/Web3/XAHAU/xahaud/build/CMakeFiles/rippled.dir/Unity/unity_34_cxx.cxx:16:
/Volumes/Dev/Web3/XAHAU/xahaud/src/test/rpc/AccountNamespace_test.cpp:113:24: warning: unused variable 'key' [-Wunused-variable]
            auto const key = uint256::fromVoid(
                       ^
/Volumes/Dev/Web3/XAHAU/xahaud/src/test/rpc/AccountNamespace_test.cpp:129:24: warning: unused variable 'nons' [-Wunused-variable]
            auto const nons = uint256::fromVoid(
                       ^
In file included from /Volumes/Dev/Web3/XAHAU/xahaud/build/CMakeFiles/rippled.dir/Unity/unity_5_cxx.cxx:7:
In file included from /Volumes/Dev/Web3/XAHAU/xahaud/src/ripple/app/rdb/impl/RelationalDatabase.cpp:23:
/Volumes/Dev/Web3/XAHAU/xahaud/src/ripple/app/rdb/backend/RWDBDatabase.h:797:23: warning: unused variable 'queryLimit' [-Wunused-variable]
        std::uint32_t queryLimit = numberOfResults + 1;
                      ^
In file included from /Volumes/Dev/Web3/XAHAU/xahaud/build/CMakeFiles/rippled.dir/Unity/unity_23_cxx.cxx:25:
/Volumes/Dev/Web3/XAHAU/xahaud/src/test/app/SetHook_test.cpp:1095:20: warning: unused variable 'preOwnerCount' [-Wunused-variable]
        auto const preOwnerCount = (*env.le(alice))[sfOwnerCount];
                   ^
2 warnings generated.
/Volumes/Dev/Web3/XAHAU/xahaud/src/test/app/SetHook_test.cpp:5848:9: warning: unused variable 'checker_keylet' [-Wunused-variable]
        HASH_WASM(checker);
        ^
/Volumes/Dev/Web3/XAHAU/xahaud/src/test/app/SetHook_test.cpp:75:18: note: expanded from macro 'HASH_WASM'
    Keylet const x##_keylet = keylet::hookDefinition(x##_hash);
                 ^
<scratch space>:51:1: note: expanded from here
checker_keylet
^
In file included from /Volumes/Dev/Web3/XAHAU/xahaud/build/CMakeFiles/rippled.dir/Unity/unity_23_cxx.cxx:25:
/Volumes/Dev/Web3/XAHAU/xahaud/src/test/app/SetHook_test.cpp:6042:9: warning: unused variable 'pos_keylet' [-Wunused-variable]
        HASH_WASM(pos);
        ^
/Volumes/Dev/Web3/XAHAU/xahaud/src/test/app/SetHook_test.cpp:75:18: note: expanded from macro 'HASH_WASM'
    Keylet const x##_keylet = keylet::hookDefinition(x##_hash);
                 ^
<scratch space>:72:1: note: expanded from here
pos_keylet
^
In file included from /Volumes/Dev/Web3/XAHAU/xahaud/build/CMakeFiles/rippled.dir/Unity/unity_3_cxx.cxx:7:
/Volumes/Dev/Web3/XAHAU/xahaud/src/ripple/app/misc/SHAMapStoreImp.cpp:298:16: warning: unused variable 'isMem' [-Wunused-variable]
    bool const isMem = app_.config().mem_backend();
               ^
In file included from /Volumes/Dev/Web3/XAHAU/xahaud/build/CMakeFiles/rippled.dir/Unity/unity_23_cxx.cxx:25:
/Volumes/Dev/Web3/XAHAU/xahaud/src/test/app/SetHook_test.cpp:8367:9: warning: unused variable 'grantee_keylet' [-Wunused-variable]
        HASH_WASM(grantee);
        ^
/Volumes/Dev/Web3/XAHAU/xahaud/src/test/app/SetHook_test.cpp:75:18: note: expanded from macro 'HASH_WASM'
    Keylet const x##_keylet = keylet::hookDefinition(x##_hash);
                 ^
<scratch space>:15:1: note: expanded from here
grantee_keylet
^
In file included from /Volumes/Dev/Web3/XAHAU/xahaud/build/CMakeFiles/rippled.dir/Unity/unity_23_cxx.cxx:25:
/Volumes/Dev/Web3/XAHAU/xahaud/src/test/app/SetHook_test.cpp:8419:9: warning: unused variable 'grantor_keylet' [-Wunused-variable]
        HASH_WASM(grantor);
        ^
/Volumes/Dev/Web3/XAHAU/xahaud/src/test/app/SetHook_test.cpp:75:18: note: expanded from macro 'HASH_WASM'
    Keylet const x##_keylet = keylet::hookDefinition(x##_hash);
                 ^
<scratch space>:22:1: note: expanded from here
grantor_keylet
^
In file included from /Volumes/Dev/Web3/XAHAU/xahaud/build/CMakeFiles/rippled.dir/Unity/unity_23_cxx.cxx:25:
/Volumes/Dev/Web3/XAHAU/xahaud/src/test/app/SetHook_test.cpp:8681:9: warning: unused variable 'exhaustion_keylet' [-Wunused-variable]
        HASH_WASM(exhaustion);
        ^
/Volumes/Dev/Web3/XAHAU/xahaud/src/test/app/SetHook_test.cpp:75:18: note: expanded from macro 'HASH_WASM'
    Keylet const x##_keylet = keylet::hookDefinition(x##_hash);
                 ^
<scratch space>:71:1: note: expanded from here
exhaustion_keylet
^
In file included from /Volumes/Dev/Web3/XAHAU/xahaud/build/CMakeFiles/rippled.dir/Unity/unity_23_cxx.cxx:25:
/Volumes/Dev/Web3/XAHAU/xahaud/src/test/app/SetHook_test.cpp:9376:9: warning: unused variable 'exhaustion_keylet' [-Wunused-variable]
        HASH_WASM(exhaustion);
        ^
/Volumes/Dev/Web3/XAHAU/xahaud/src/test/app/SetHook_test.cpp:75:18: note: expanded from macro 'HASH_WASM'
    Keylet const x##_keylet = keylet::hookDefinition(x##_hash);
                 ^
<scratch space>:29:1: note: expanded from here
exhaustion_keylet
^
4 warnings generated.
In file included from /Volumes/Dev/Web3/XAHAU/xahaud/build/CMakeFiles/rippled.dir/Unity/unity_5_cxx.cxx:7:
In file included from /Volumes/Dev/Web3/XAHAU/xahaud/src/ripple/app/rdb/impl/RelationalDatabase.cpp:22:
/Volumes/Dev/Web3/XAHAU/xahaud/src/ripple/app/rdb/backend/FlatmapDatabase.h:55:19: warning: private field 'config_' is not used [-Wunused-private-field]
    Config const& config_;
                  ^
/Volumes/Dev/Web3/XAHAU/xahaud/src/ripple/app/rdb/backend/FlatmapDatabase.h:56:15: warning: private field 'jobQueue_' is not used [-Wunused-private-field]
    JobQueue& jobQueue_;
              ^
2 warnings generated.
1 error generated.
make[3]: *** [CMakeFiles/rippled.dir/Unity/unity_12_cxx.cxx.o] Error 1
make[3]: *** Waiting for unfinished jobs....
3 warnings generated.
7 warnings generated.
1 warning generated.
In file included from /Volumes/Dev/Web3/XAHAU/xahaud/build/CMakeFiles/rippled.dir/Unity/unity_16_cxx.cxx:37:
/Volumes/Dev/Web3/XAHAU/xahaud/src/ripple/rpc/handlers/ServerDefinitions.cpp:470:20: warning: returning reference to local temporary object [-Wreturn-stack-address]
            return uint256(
                   ^~~~~~~~
1 warning generated.
make[2]: *** [CMakeFiles/rippled.dir/all] Error 2
make[1]: *** [CMakeFiles/rippled.dir/rule] Error 2
make: *** [rippled] Error 2```

@shortthefomo can you try pulling this branch and building?
https://github.com/Xahau/xahaud/pull/397

using https://github.com/Xahau/xahaud/pull/397

awesome now its building for me !


Update validation

Here I update the validation analysis. I remake plots for publication and perform a power analysis on the validation set.
Here is what the output looks like (edited in GIMP):

In response to a reviewer comment, here is a power analysis figure showing the power to detect an effect using a one-sided t test (with observed effect size = 0.77):

The blue line indicates our sample size (n = 12) and the red line is power = 0.8.

What are you editing in GIMP? If it's just aligning plots in a grid, I think cowplot or gridExtra::arrangeGrob could do the trick?
In panel C, text labels are too small (unreadable). In publication ready figures, all text should be readable or it should be removed.
The power plot is too big (in terms of width and height). It shows a single curve, so could probably fit in a 3 by 3 inch image. Now it's probably double that at least? Always make figures as small as possible for their given content. Now with the figure, the tick labels and other text is too small when you zoom out to something more reasonable.
When making publication figures, always be cognizant of the max width supported by the journal (usually 7 inches) and make sure no visualizations exceed. Not an issue here, I don't think

What are you editing in GIMP? If it's just aligning plots in a grid, I think cowplot or gridExtra::arrangeGrob could do the trick?

I am adding in the western blot and letters referencing sub figures. I agree that life would be easier to arrange these figures in a grid.

In panel C, text labels are too small (unreadable). In publication ready figures, all text should be readable or it should be removed.

Got it. I enlarged the text in the update and moved the justification a bit.
Here is the update:

The power plot is too big (in terms of width and height). It shows a single curve, so could probably fit in a 3 by 3 inch image... Now with the figure, the tick labels and other text is too small when you zoom out to something more reasonable.

It was actually 3 x 4 - uploading the png must have made it look bigger? Either way, I think I like it better 3 x 3 and I made the the axis labels and ticks larger.


Update Merged annotation documentation

The event class is MergeEvent, not MergedEvent.

Integrate in master. Thanks @tsegismont !

You're welcome :)
Le 10 janv. 2017 3:07 PM, "Adrian Nistor"<EMAIL_ADDRESS>a
écrit :

Integrate in master. Thanks @tsegismont https://github.com/tsegismont !
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/infinispan/infinispan/pull/4752#issuecomment-271583699,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABbltnPupV7rvE4ejLJhjkn6NCr8TtKPks5rQ5CcgaJpZM4LfVRk
.


Create simple custom assertions

Added three custom assertions with examples:

BeDeployed
BeInLocation
BeInResourceGroup

Things being worked on/asking for feedback:

Unit Tests
Naming of assertions
Should these be advanced functions if they're somewhat internal?
Error handling/messaging (better descriptions)
Is #Requires -Module Pester needed?
File Structuring (will change with Marc's changes)

All Assertions work with added examples

Easier to just restart the pr


Diff while commiting

When creating a commit, it's handy to see at a glance what you are actually committing, a diff displayed at the bottom is the optimal solution.
Should also be optional, as it would probably add extra load time on larger commits.

Good idea.  I'll probably add a configurable threshold beyond which the text is cut off.


Introduce FTLB3 JIT to weight

After using Fuzzilli I noticed certain exploits in the past for B3 do exist, Using the options passed in JSCProfile.swift and using a regular jsc binary and also passing the --logJIT=true and --dumpDisassembly=true I noticed B3 was nowhere to found so I removed all the default Fuzzilli threshold flags and noticed B3 only triggered at 1000000 execution in regular jsc binary, with the flags Fuzzilli pass to jsc B3 only would trigger for me at 50000 increment loop.

Add this to JSCProfile.swift
fileprivate let ForceFTLB3CompilationGenerator = CodeGenerator("ForceFTLB3CompilationGenerator", input: .function()) { b, f in
guard let arguments = b.randCallArguments(for: f) else { return }
b.buildForLoop(b.loadInt(0), .lessThan, b.loadInt(50000), .Add, b.loadInt(1)) { _ in
    b.callFunction(f, withArgs: arguments)
}

}
and (ForceFTLB3CompilationGenerator, 5), to additionalCodeGenerators: WeightedList


Add Scorecards GitHub Action

Provide a detailed description of the proposed feature
Scorecards is a tool that runs dozens of automated security checks and reports them in the project's security dashboard. The tool checks for security vulnerabilities, such as dangerous workflows in GitHub Actions and non pinned dependencies. It also offers a badge that can be added to README to show your score.
What is the motivation for the feature?
Show to brew users and other open source projects that brew is engaged in making its software supply-chain secure. Since brew already follows good security best practices, Scorecards would be useful to help keep the best practices throughout contributions and to measure the security efforts to be displayed to the community.
How will the feature be relevant to at least 90% of Homebrew users?
Right now, it would be most relevant to show Homebrew users that brew is a secure software to consume. This would be done by adding Scorecards badge with the project score to README.
What alternatives to the feature have been considered?
The alternatives would be to do the security checks Scorecard performs manually or using a group of other tools. For example, StepSecurity is used to analyze GitHub Token permissions in Actions and would cover Scorecards Token-Permissions check. As far as I know, there are no tools that do all the same checks that Scorecard does or that "rates" security. Another alternative could be to highlight in README maybe what makes the software supply-chain secure, like informing GitHub Actions use least privilege permissions per job.

No problem!


Move to simdjson praser

Hi,
Thanks for the great library, I'm using this since 2015.
I'm suggesting to change the JSON praser to simdjson (https://github.com/simdjson/simdjson) as it is much faster (based on stats on the repo), the library has a python binding (https://github.com/TkTech/pysimdjson), so can you tell me the feasibility of doing so? and i can help of you like.
Thanks for the great library again.

Hi @mkalioby. Changing the default json implementation won't happen (compatibility assurances, extra dependency), however it is worth considering making the implementation swappable.

Thanks @rpkilby , how do you suggest to do that?


Set up login.gov in production

Sign up and get approval for login.gov in production
Set the /crossfeed/prod/LOGIN_GOV_JWT_KEY SSM variable with the new JWT key.

There are no technical barriers to this happening (crossfeed could be configured with login.gov right now if need be), so going to close this issue since we likely won't integrate with login.gov in the near term.


DuplicateReplaceException being raised unexpectedly

Describe the Bug
I've encountered something strange, and I'm not even sure whether it's a reddit error or a praw error.
I maintain a set of tools to navigate and keep track of the deeply nested threads at r/counting. As part of that I have a script running that automatically updates a directory of the threads, and yesterday it started failing with an error I've never seen before, namely a DuplicateReplaceException. I have recently updated the code, so I rolled back to a previous version, expecting the error to go away, but it didn't.
Digging in deeper, I was able to reproduce the error without referencing any of my existing code. In a fresh virtual environment with praw 7.6.1 installed this code:
import praw

reddit = praw.Reddit(
    client_id=XXXX,
    user_agent=XXXX,
    refresh_token=XXXX,
    client_secret=None,
)

comment = reddit.comment("j9euqfn")
comment.refresh()
replies = comment.replies
replies.replace_more(limit=None)

fails. Looking at replies.list() before I call replace more I see two comments (ids j9ev71v and j9evimq) and then a MoreComments object. If I add a print statement at praw.models.comment_forest:195 to see what comment is the immediate cause of the failure, I see comment id j9evimq, which is indeed already present in the replies.
Somewhere it seems that reddit is sending something that praw is not expecting.
Has anyone else experienced something similar? Is this a known issue with a known workaround?
Desired Result
No exception should be raised
Code to reproduce the bug
import praw

reddit = praw.Reddit(
    client_id=XXXX,
    user_agent=XXXX,
    refresh_token=XXXX,
    client_secret=None,
)

comment = reddit.comment("j9euqfn")
comment.refresh()
replies = comment.replies
replies.replace_more(limit=None)

The Reddit() initialization in my code example does not include the following parameters to prevent credential leakage:
client_secret, password, or refresh_token.

[X] Yes

Relevant Logs
Traceback (most recent call last):
  File "debug.py", line 15, in <module>
    replies.replace_more(limit=None)
  File ".venv/lib/python3.10/site-packages/praw/util/deprecate_args.py", line 43, in wrapped
    return func(**dict(zip(_old_args, args)), **kwargs)
  File ".venv/lib/python3.10/site-packages/praw/models/comment_forest.py", line 196, in replace_more
    self._insert_comment(comment)
  File ".venv/lib/python3.10/site-packages/praw/models/comment_forest.py", line 80, in _insert_comment
    raise DuplicateReplaceException
praw.exceptions.DuplicateReplaceException: A duplicate comment has been detected. Are you attempting to call 'replace_more_comments' more than once?

This code has previously worked as intended.
Yes
Operating System/Environment
Ubuntu 22.04.2
Python Version
Python 3.10.6
PRAW Version
7.6.1
Prawcore Version
2.3.0
Anything else?
No response

I still see the problem on comments that were made after the outage on the 21st. For example, comment j9svsj0, which was made earlier today.
I don't know the praw internals, so I'm not sure what the MoreComments object is supposed to look like before expansion. If I try to display it, I see <MoreComments count=0, children=[]>. Is that normal?

As an update, the problem is still present in a fresh install of praw 7.7.0

The problem is still occurring. It seems that for deep comment chains, reddit has started sometimes putting the "continue this thread" link at the bottom of the page (like this) instead of attached to the parent comment. This breaks the assumptions in replace_more


The Tree tree control can not be set up in the way of solt

The Tree tree control can not be set up in the way of solt

Tree can not be set up in the way of solt

can not be set up in the way of solt


Block Representation for Drag & Drop Project

Since we were planning to create blocks before implementing the coding part on the drag & drop project, we have to discuss the representation/structure of the blocks first.
Assume that a user adds a block on the visualizer using by dragging and dropping it. After that, the user will be able to edit the block's title, description, and other things.
so, for changing the title or description of the blocks in the visualizer after adding from the drag & drop panel we have two methods/approaches:

We can open an input box in place of the title or description by double-clicking on it,
and by clicking on the enter button, it will save that particular text to the local storage,
so users can change the title, description, and other details of the block by using this approach.

The second approach I found to be more appropriate in this case was to open a modal for that particular block, rather than opening an input box in place of each title and description.
In this way, the user can change all parameters regarding that particular block in one go.
By double clicking on the block, we can open the modal for that particular block.

so these are the approaches I came across, and I'm happy to create example diagrams if needed.
Please guide me through this, and let me know if I am going in the right direction with this.
Let me know, what do you all think about this?
cc: @magicmatatjahu

@wh0sumit I think that we should go with modal approach. Through the modal we can edit all the information and not just individual ones (as in the case of the first approach) - and also this will be generally easier to implement.


Regenerate R.java file from values/public.xml and values/strings.xml in Android

I'm working on a feature for jadx that would regenerate the gen/R.java file (and modify the other .java files to use 'labels', like R.string.stringName in methods like setText() and getString()) -- from the values/public.xml and values/strings.xml files recovered from Android .apk files.  (I assume that decompiling Android .apk files is a/the principal use of jadx.)
Would this be a feature you'd welcome in jadx?
The (Android) .java files frequently contain statements like:
setText(R.string.save_exists);

R.string.save_exists is defined in gen/R.java as:
public static final class string {
    public static final int save_exists=0x7f050033;
}

The code jadx reconstructs looks like:
this.view.setText(2131034163);

The jadx feature would find functions like setText(number,...) and getString(number) and replace the number with 'R.string.save_exists' -- and would append a comment to line containing the text of the string:
this.view.setText(save_exists);  // String: "A file with the same name already exists" 0x7f05033

This would make it much easier to understand what was going on in decompiled Android code.

Skylot, are you working on this sort of feature?  I see some recent work on loading resources from the resources.asrc file.

Sorry, I was very busy last weeks.
I already implement replacement of resources ids with appropriate resources names, but I don't add comment with values. For find value of some resource in jadx-gui I decode list of all resources with values (open "Resources->*.arsc file"), but it is temporal solution. I will make regeneration of strings.xml and other resources from .arsc file later.
About regenerate R file: I don't think it is really necessary, because if we replace all ids with names we don't need mapping from R class anymore, also R file will be rewritten if you try to rebuild android project.


WIP: Make maintainer scripts dir relative to the package being built.

So that specifying a workspace package with -p works (see #151).
I haven't attempted to make this PR neat and tidy yet as I'm not sure if it's the right way to go or not. In particular the changes to the test code are a bit hacky at present. I'm curious to see what @kornelski and @qwandor think of it. With this change cargo deb -p example and cd example ; cargo deb both find the maintainer scripts, i.e. the issue reported on #151 is "fixed".
My main concern with this is to understand whether or not it constitutes a change in current behaviour or not, assuming @kornelski doesn't throw it right out that is ;-)

Looks reasonable to me, though I haven't had a chance to try it yet.

Looks good to me. I think the scripts were always meant to be crate-relative, so the change is a bugfix.

I'll cleanup the PR and make it ready for final review then.

@kornelski: please review, thanks.

Hey @ximon18,
Thank you for your work! I've tested the PR with my project and I've noticed that the maintainer-scripts are only included if I specify the following (empty) section inside the Cargo.toml, as done in the mijia-home project:
[package.metadata.deb.systemd-units]

Perhaps I'm missing something, but shouldn't the maintainer scripts be included even without systemd-specific settings?

Hi @federico-terzi,
Without it present maintainer scripts are still packaged into the DEB archive but not systemd unit specific processing of those scripts occurs, i.e. no service or other systemd specific files are detected and no code blocks are injected into the maintainer scripts to control the systemd unit during package installation and uninstallation.
Note that you can also include the table in compact form, e.g.:
systemd-units = { enable = false }

The reason that the systemd specific behaviour is not activated by default can be traced back to this comment on the original PR:

I considered making this new behaviour the default, i.e. that cargo deb would be (ed: smart) enough to detect any systemd unit files in a debian subdirectory if present and to generate or augment maintainer scripts in debian and it would all just work. However, though perhaps this is not very likely, if someone had a debian directory containing systemd units that they did NOT want to be installed with the package (perhaps because the directory is shared between multiple packages or projects?) this new functionality would cause the package to be built differently than prior to this PR.

Thank you for the fix and the tests

Perhaps I'm missing something, but shouldn't the maintainer scripts be included even without systemd-specific settings?

@federico-terzi and @kornelski:  An example of why the systemd unit handling behavior isn't enabled automatically is regarding the rules for handling not found script files.
When the maintainer-scripts directory contains a service or other systemd supported file, the emulated Debian packaging logic requires that not found postinst, prerm or postrm files be generated.
If a user of cargo-deb had decided to control the systemd related behavior themselves with different logic than the Debian default, or had provided their own implementation prior to support for it existing in cargo-deb, the automatic addition of extra logic to their package when regenerating it using the latest cargo-deb could cause unwanted or unexpected changes in the behavior of their package at (un)install time.
If the cargo-deb owners (now just @kornelski ?) were to conclude that this is such a rare corner case and the impact on most users of being backward compatible is undesirable, we could of course decide to potentially break backward compatibility and diverge from the dh_installsystemd "official" Debian behavior by enabling the systemd related behavior by default, thereby making it easier for the majority use case, but I didn't and don't feel able to decide that on my own.
If that were to be done it should perhaps be mentioned in the release notes... except cargo-deb doesn't seem to have any...?

@ximon18 Thank you for the detailed explanation!


Support for React Native 0.72

Updating to RN 0.72 results in npm error
Could not resolve dependency:
npm ERR! peer<EMAIL_ADDRESS>|| ^0.67 || ^0.68 || ^0.69 || ^0.70 || ^0.71" from<EMAIL_ADDRESS>

I have this problem as well as I am using Expo SDK 49 which requires React Native 0.72.3


Unable to add volume/secret globally

Based on examples and source I was not able to find how to add emptyDir volume globally, so it is available for all tasks in the workflow. The same goes for the SecretVolume.
I was expecting I could add Resources under Workflow definition, but that is not the case.
Is there some solution to this or is it missing func?

Hello @bvidovic1! That is currently not supported in Hera but it would certainly be a great addition, especially if your use case would benefit from it! As a temporary workaround, one can add EmptyDir and SecretVolume to each task under Resources, as you alluded to!

Hi,
Thanks for the answer.
Yeah, volume definition can be pre-created and added within each task.
Global secrets and volumes would also be a great addition.
Cheers.

Should we re-open this?
Looks like in v4 we're back to the situation where there is no way of doing this (create a volume globally for a workflow). At least I could not find it by reading the examples and the code of workflow.py.
There was a PR for 3.x that added that capability, but the volumes keyword introduced there is not present anymore, and the new way of specifying resources seems to be only defined for Tasks, and not for Workflows.
How can I define a volume shared between all tasks in a workflow with v4?


feat(generator): use pageSizeHint as page size parameter

Description

add a method PagingMethod.IsPageSizeParameter() to check if a parameter is a page size parameter
add a method PagingMethod.NonPathDomainParameters() to provide input parameters for paging list methods to be generated
2.1 that method will hide the page size parameter defined in swagger
generating paging list method body, change to pass pagesSize of AsPages() method, instead of the page size parameter defined in swagger
3.1 also do the type conversion for string type of page size parameter defined in swagger
refactor to move some methods to better owning classes
add unit test cases and acceptance test case

AB#5583
Checklist
To ensure a quick review and merge, please ensure:

[ ] The PR has a understandable title and description explaining the why and what.
[ ] The PR is opened in draft if not ready for review yet.

If opened in draft, please allocate sufficient time (24 hours) after moving out of draft for review

[ ] The branch is recent enough to not have merge conflicts upon creation.

Ready to Land?

[ ] Build is completely green

Submissions with test failures require tracking issue and approval of a CODEOWNER

[ ] At least one +1 review by a CODEOWNER
[ ] All -1 reviews are confirmed resolved by the reviewer

Override/Marking reviews stale must be discussed with CODEOWNERS first

Rebase to fix branching issues

Update according to review comments

rebase against latest feature/v3
add missing commit regarding the refactoring of GetPathParameters and GetNonPathParameters.
remove type conversion for pageSizeHint
add warning when detecting a page-size-like parameter, but with wrong type
update readme.md of Storage service to overwrite the wrong type of maxpagesize
update test cases accordingly


bytte bakgrunnskart

Coverage decreased (-1.5%) to 21.144% when pulling ae8b7e0361f3f3492b6c232fbb1f1e85aae658f5 on feature/byttebakgrunnskart into 766a4735ca21b845f0eda2446bcc8f70c14b3bb6 on master.


Requests for deletion from Sign Bank

I see that (2h)DO-DO may have been automatically classified with DO-DO (athough it lists 0 occurrences).  However, that was an error,  (2h)DO-DO should just be DO-DO.  I will correct it in the collections if I find it, but (2h)DO-DO should be removed from the Sign Bank.
Also as I mentioned, WORK/BUSINESS should not be a main entry; I entered it in error.

(2h)DO-DO  has been removed from SignBank.

Fixed


Change the default path for CRUD helpers to be lower case

Pull Request Template
Description:
If the structure contains a capital letter the default path will contain also the capital letter. Since path are case sensitive only on some servers it creates confusion. To avoid it, the paths in the url's are converted to lower case by default.
Breaking Changes (if applicable):

on servers which are case sensitive and the provider published them case sensitive from the default it can create a breaking change.

Checklist:

[x] I have formatted my code using  goimport  and  golangci-lint.
[x] All new code is covered by unit tests.
[x] This PR does not decrease the overall code coverage.
[x] I have reviewed the code comments and documentation for clarity.

Thank you for your contribution!

@danysz Thankyou for your contribution!
Since you have corrected the code now, the tests written for it in method Test_getRestPath are breaking due to code changes.
Can you please fix them!

@danysz Still there are some failing tests. Could you please fix them ?

You can run these tests on local so that this doesn't become a back and forth task for you.

I only added the ":" so the content of the columns will be aligned in the
center to look good.
On Thu, 12 Dec 2024 at 06:21, Umang Mundhra @.***>
wrote:

@.**** requested changes on this pull request.
In pkg/gofr/datasource/README.md
https://github.com/gofr-dev/gofr/pull/1276#discussion_r1881359893:

+| Datasource     | Health-Check | Logs | Metrics | Traces | As Driver |
+|----------------|:------------:|:----:|:-------:|:------:|:---------:|
+| MySQL          | ✅         | ✅    | ✅    | ✅      |           |
+| REDIS          | ✅         | ✅    | ✅    | ✅      |           |
+| PostgreSQL     | ✅         | ✅    | ✅    | ✅      |           |
+| MongoDB        | ✅         | ✅    | ✅    |  ✅      | ✅         |
+| SQLite         | ✅         | ✅    | ✅    | ✅      |           |
+| BadgerDB       | ✅         | ✅    | ✅    |    ✅    | ✅         |
+| Cassandra      | ✅         | ✅    | ✅    |  ✅      | ✅         |
+| Clickhouse     |            | ✅    | ✅    |   ✅     | ✅         |
+| FTP            |            | ✅    |       |         | ✅         |
+| SFTP           |            | ✅    |       |          | ✅         |
+| Solr           |            | ✅    | ✅    |   ✅     |   ✅     |
+| DGraph         | ✅         | ✅    | ✅    |   ✅     |         |
+| Azure Eventhub |            | ✅    | ✅    |          |✅     |
@danysz https://github.com/danysz Please revert these changes.
—
Reply to this email directly, view it on GitHub
https://github.com/gofr-dev/gofr/pull/1276#pullrequestreview-2497573729,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAMXGQAB6Q42DLOTNHVBJ6L2FEFNJAVCNFSM6AAAAABTHC4QBWVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDIOJXGU3TGNZSHE
.
You are receiving this because you were mentioned.Message ID:
@.***>

--
Best regards
Daniel Szasz

@danysz i agree that you did the changes just to align the columns. But unintentionally you also changed the @ccoVeille changes in Azure EventHub and REDIS.
Telling to revert back them only

@danysz Can you please address the review comment left on your PR so that we can go ahead and merge it.

Hi, sorry for the delay but can someone approve the comment so it will be merged ?
Thanks


Added Stacksmith example app code

@beltran-rubo @james-w This PR transfers the example app code from https://github.com/rickspencer3/DaleCo to our tutorials repo


Fix postInstall name

Motivation
The link to the manual specifies that it should be postInstall, not postInstallPhase
Checklist

[x] Simple docs update

Thanks for fixing this!


VSIX install does not show up in experimental hive

Resolved by reset experimental hive and enable the extension... :)


Plan electricity in a time-slot

For some usages a search time-span always moving ahead on now is not the best option, e.g. charging a car over night.
In that case it would more optimal to give an end-time and a total amount of hours needed, maybe also a boolean if the hours given must be consecutive or can be split in sections.
One thing to consider that may interfere with current logic is that the fact that it currently has no persistent state data, meaning several hours ahead of end-time the best hours could be selected, but as moving closer to that time there is less to choose from and if it's not remembering how many hours already used it will eventually end up choosing all remaining.

Could it not do the calculations of lowes price at time 00:00 and then find it within the next 24H and stick to what hours it finds?


Reverse-engineered commands missing from documentation

Thanks for the nice project!
Here is information on missing commands that I discovered by dumping traffic from the official Windows-based GUI.
I may have a go at implementing some of these myself at some point, but here is the info so that it is available somewhere.
Write arbitrary waveform
Address can be from a01 to a15. Values are from 0 to 4095, 2048 = middle voltage. Actual voltage scale and offset is set in normal way.  Total 2048 values per waveform location.
Query: :a01=2048, ..(total 2048 values).. ,2048.
Response: :ok
Arbitrary waveform is selected as type 101 for a01 waveform ... 115 for a15.
Read arbitrary waveform
Address can be from b01 to b15.
Query: :b01=0.
Response: :b01=2048, ... (total 2048 values) .., 2048
Channel setting sync together
When sync is set to '1', both channels have the same config value.
Query: w54=0,0,0,0,0. Values in order: Freq, Waveform, Amplitude, Offset, Duty
Response: :ok
Frequency measurement function
Measures frequency input on Ext. In
Frequency measurement mode select: :w33=4.
Disable counter mode: :w32=0,0,0,0.
Gate time: :w37=99. value in 100th of seconds, e.g. 99 = 0.99 seconds.
Coupling: :w36=0. 0 for AC, 1 for DC
Mode: :w38=0. 0 to count frequency, 1 to measure period
Result reading: :r81=7. gives response of 8 values:
    :r81=12339990.  # Frequency in 0.1 Hz increments
    :r82=1783785447.
    :r83=15.
    :r84=40. # Pulse width?
    :r85=55.
    :r86=272.
    :r87=1334378.
    :r88=42. # Pulse width?

Pulse counter
Counter mode select: :w33=5.
Start counter: :w32=1,0,0,0.
Stop counter: :w32=0,0,0,0.
Get count: :r80=0., response :r80=12345. with the number of pulses.
Burst modulation
Burst count: :w49=1. number of bursts to send on trigger
Trigger mode: :w50=0. 0 = manual, 1 = CH2, 2 = Ext.In AC, 3 = Ext.In DC
Enable burst mode: :w32=1,0,0,1., disable :w32=0,0,0,0.
Sweep modulation
Start freq: :w40=1234. frequency in 0.01 Hz
Stop freq: :w41=1234. frequency in 0.01 Hz
Sweep time: :w42=100. time in 0.1 s
Direction: :w43=0 0 = Rise, 1 = Fall, 2 = Rise & Fall
Mode: :w44=0 0 = Linear, 1 = Logarithmic
Sweep channel: :w33=6 6 = CH1, 7 = CH2
Sweep enable: :w32=0,1,0,0., disable :w32=0,0,0,0.
Pulse modulation
Pulse width: :w45=1000,0. first number time, second number unit 0 = ns, 1 = us
Pulse period/cycle: w46=10000,0. first number time, second number unit 0 = ns, 1 = us
Pulse offset: :w47=100. value in percent, not sure how it relates to waveform offset
Pulse amplitude: :w48=500. value in 0.01 V.
Pulse enable: :w32=1,0,1,1. disable :w32=0,0,0,0.
Preset settings
Save preset settings: :w70=0. where value is slot number 0-15
Load preset settings: :w71=0. where value is slot number

Thank for the info :-)
I'll start with the implementation once I have a bit more time :-) (probably during the cold winter days)

There is also this project which may be an useful reference, but lacks a CLI tool and the API is a bit messy https://github.com/on1arf/jds6600_python

Indeed, the API is less Pythonic, and it lacks tests.
That's why I gave it a try, but I'm sure this project can be improved as well.


Join perf analysis

Suppressed by #616 , #663 and #623 additional information in the corresponding issue.


added index checks

Codecov Report
Patch coverage has no change and project coverage change: -1.15% :warning:

Comparison is base (614f6de) 97.25% compared to head (b82de85) 96.10%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #28      +/-   ##
==========================================
- Coverage   97.25%   96.10%   -1.15%
==========================================
  Files          14       14
  Lines         838      848      +10
==========================================
  Hits          815      815
- Misses         23       33      +10

Flag
Coverage Δ

unittests
96.10% <0.00%> (-1.15%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed
Coverage Δ

cf_pandas/accessor.py
83.12% <0.00%> (-5.55%)
:arrow_down:

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


The wallet receives and accepts connections, but the subsequent credential offer is never received/presented.

Credential Issuing services tested:

https://openvp-candy-dev.vonx.io/

Anchored on the CANdy Dev network.

https://openvp-issuer.apps.silver.devops.gov.bc.ca/

Anchored on Sovrin StagingNet

https://email-verification.vonx.io/

Anchored on Sovrin StagingNet

Steps to reproduce:

Browse to one of the above services and fill out the information to request the credential.
Using the BC Wallet, scan the resulting QR code.

Observed Behavior:

The connection offer is received and accepted automatically.
The expected credential offer is never presented (or perhaps never received).
The services (logs) indicate they have successfully sent the credential offer.

Expected Behavior:

The credential offer to be received and presented for acceptance.

Version Info:

BC Wallet Version: 0.0.1

AMA-RN Version: 0.1.0

Testing on iPhone 13 Pro

iOS Version 15.2

This is because I forgot to add the MEDIATOR_URL as an environment parameter to the build; its normally a hidden .env file on my laptop so just magically works. Will fix.

Fixed in BC Wallet 1.0.1 Build 25. Tested with Verified Email. Not there is an issue displaying credentials. Will look into it for the next meaningful build. Plz confirm this fixing your exiting issue.

I'm not seeing an update for BC Wallet 1.0.1 Build 25 in Test Flight.  It's only showing BC Wallet 1.0.1 Build 18.

Thanks for pushing the update.  I was able to collect and use the credentials openvp and openvp-candy credentials.


Allow sending Port to other threads

First of all, I am really impressed by this crate. Thanks a lot for your work!
I want to share the Port struct between multiple threads behind a Arc<Mutex<>>. Currently, this is not possible because PacketCallback is not Send:
https://github.com/stphnt/zproto/blob/a3b247f3365290457e487fc9058148b4fcac6a43/src/ascii/port.rs#L36
This small change would fix this:
pub type PacketCallback<'a> = Box<dyn FnMut(&[u8], Direction) + 'a  + Send + Sync>;

On the flip side, this would make the callback more strict, even if multithreading is not needed. Maybe there is a way to make Send and Sync optional trait bounds, but I couldn't figure out how to do it.
Would you be open for this change? I can also make a pull request, if you want.

Thanks, @xRetry! I'm glad you're able to make use of it. Also, thanks for submitting the issue.
I always intended for Ports to be shareable via Arc<Mutex<_>> but never had a need to do that personally (and I apparently didn't test it either, oops!). So I would definitely like to make this work.
However, I'd like to avoid making the single-threaded use cases harder. Optional trait bounds would be great, but, like you, I don't see an obvious way of doing that.
I'll think on this some more and see what options I can come up with/find. If you have any other ideas/solutions, please let me know.

Ok. I think I have a solution, though I haven't tested it yet.

The fundamental issue is that the compiler statically determines whether the port is Send or not, but I have explicitly erased all type information that would allow it to do so by declaring the callbacks with the form Box<dyn Trait>.
There is no way to make the Box<dyn Trait> either Send or !Send because that is determined statically and by making the type dyn Trait we have explicitly erased any information the compiler could use to determine if it is Send or not.
If the callback types were made to be type parameters, then the compiler would have the necessary information it needs to make the Port Send or not. However, that would change the type of the port from Port<'a, B> to Port<'a, B, C1, C2>, where C1 and C2 are the callback types.

I tried this initially, but it had poor ergonomics. 1) The compiler couldn't deduce the callback types if it wasn't ever set (a very common use case). 2) it makes he call sites for a Port verbose.

The ergonomics problems can likely be fixed by giving the callback type parameters default values and adding some convenient conversion methods, possibly also some type aliases.

I'll prototype this and see if it actually works.

This sounds promising. Seems simpler than trying to figure out optional trait bounds for a single callback.
I have also thought about it a bit more. Maybe it would work using an associated type to distinguish between both variants. Then, the callback function could determine the inner type of Port and switch between a single and multithreading state. I am not sure if this would actually work in practice, though.
Maybe a simpler solution would be to have two structs, Port and something like PortSend (this name sucks though), where both share the same core and only differ by the trait bound on the callback. It could potentially use your generic Port<'a, B, C1, C2> suggestion internally.
I will make some tests once I find the time, probably not before the weekend.

@xRetry I have implemented a potential fix. The code is in #158 and available on the branch sendable-port. When you have a moment, please try it out and see if it solves this issue for.

The change works in my project. Thanks a lot for your effort!
As far as I can tell, the only downside is, that the type signature gets quite verbose.
    port: Arc<Mutex<Port<'static, TcpStream, SendCallbacks<'static>>>>,

But you can always just use an alias, so it shouldn't be a problem.

Ya, I agree it gets long. I've added an alias for this: SendPort<'a, B>, so it should still be roughly equivalent to write as before.

This is fixed in v0.3.5, which I just published to crates.io.


Make --follow the default in OSS

If neither follow or unfollow is provided the default is to follow all the agents.
https://github.com/Ostorlab/ostorlab/assets/144013278/adc748d7-2a2f-4dd9-b7d9-9827cfb344d6

If unfollow is True, we don't follow any agent.
https://github.com/Ostorlab/ostorlab/assets/144013278/a4045251-419f-4aab-bcfb-ea45105ffc91

If follow is provided, we follow only the provided agents.
https://github.com/Ostorlab/ostorlab/assets/144013278/a99eb6b2-e797-4174-acab-997e79d645f0

Unit test?

I added some videos as a demonstration.


Stable Diffusion 1.5 and Stable Diffusion XL Tutorials

This update includes two parts:

New Popular Models Tutorial for Stable Diffusion
Updated RayServe deployment example based on Stable Diffusion v1.5

[ ] Clean up stale files in Python API Tutorial
[ ] Update docs in Python API Tutorial

If possible I would like to merge the Popular Models Tutorial for Stable Diffusion first and then complete the updates for the Python API portions as there is a tight deadline.

Walking through the tutorial, I get a free(): invalid pointer error for both 1.5 and XL. Did you encounter these as well by any chance?
It doesn't impact inferencing but it does impact teardown. I can try a fresh build tomorrow.

Walking through the tutorial, I get a free(): invalid pointer error for both 1.5 and XL at the end of build/server start. Did you encounter these as well by any chance?
It doesn't impact inferencing but it does impact teardown. I can try a fresh build tomorrow.

unfortunately its a known issue - I'll add section on limitations and known issues. For some reason torch or the diffusers library causes this even when they are just imports and nothing else.
Worth documenting though and probably we should get  to the bottom of it

Walking through the tutorial, I get a free(): invalid pointer error for both 1.5 and XL at the end of build/server start. Did you encounter these as well by any chance?

I'm ~50% sure this comes from some interaction with TensorRT Python API - I have seen this before in some other standalone cases involving TRT in python.


Fix typo

[ ] I have read freeCodeCamp's contribution guidelines.
[ ] My pull request has a descriptive title (not a vague title like Update index.md)
[ ] My pull request targets the master branch of freeCodeCamp.
[ ] None of my changes are plagiarized from another source without proper attribution.
[ ] My article does not contain shortened URLs or affiliate links.

If your pull request closes a GitHub issue, replace the XXXXX below with the issue number.
Closes #XXXXX

Thank you @ddmaness for your contribution and congratulations on your first PR merge to this repo! 🎉
Hope to see more contributions from you in the future.


How can I enable Apple SearchAds?

Report
Plugin Version
6.2.31
On what Platform are you having the issue?
ios
What did you do?
  appsFlyer.initSdk(
    {
      isDebug: false,
      devKey: APPS_FLYER_DEV_KEY,
      appId: APPS_FLYER_APP_ID,
      onInstallConversionDataListener: true,
      timeToWaitForATTUserAuthorization: 10,
    },...

appsFlyer.logEvent(
    eventName,
    eventValues...

What did you expect to happen?
Event to be logged as organic and to be logged for non-organic for Apple SearchAds
What happened instead?
All events logged as organic
Please provide any other relevant information.
Actually, I try to use AppsFlyer for Apple SearchAds data collection but I could not track nnon-organic data with this configuration. Is there any other configuration that I missed?

Hi @senolatac thank you for opening this issue.
try to follow this guide. if you still not succeed please contact our support team<EMAIL_ADDRESS>


Add ability to group alerting configuration

The current alerting configuration allows for some flexible configuration, however it's often desirable to define the same alerting standard for multiple services.
I'd propose something like the following:
alerting:
  pagerduty:
    integration-key: "********************************"
    templates:
      - name: twinnation_pager
        enabled: true
        failure-threshold: 3
        success-threshold: 5
        send-on-resolved: true
        description: "healthcheck failed 3 times in a row"

services:
  - name: twinnation_service_a
    url: "https://twinnation.org/health/a"
    interval: 30s
    alerts:
      - template: twinnation_pager
    conditions:
      - "[STATUS] == 200"
      - "[BODY].status == UP"
      - "[RESPONSE_TIME] < 300"

  - name: twinnation_service_b
    url: "https://twinnation.org/health/b"
    interval: 30s
    alerts:
      - template: twinnation_pager
    conditions:
      - "[STATUS] == 200"
      - "[BODY].status == UP"
      - "[RESPONSE_TIME] < 300"

I feel like having the option to specify both an alert configuration template in the provider configuration and have the ability to specify it directly on the service is a little too confusing.
Instead, I believe that having a "default" alerting configuration at the provider level would be a great idea.
The only parameter that would be required at the service level would be the type:
alerting:
  pagerduty:
    integration-key: "********************************"
    default:
      enabled: true
      failure-threshold: 3
      success-threshold: 5
      send-on-resolved: true
      description: "healthcheck failed 3 times in a row"

services:
  - name: example-service
    url: "https://twinnation.org/health"
    alerts:
      - type: pagerduty
    conditions:
      - "[STATUS] == 200"

Of course, it would also be possible to override the default configuration:
services:
  - name: example-service
    url: "https://twinnation.org/health"
    alerts:
      - type: pagerduty
        description: "everything is on fire"
    conditions:
      - "[STATUS] == 200"

What do you think?

Your proposal fits my use case perfectly.
However my only concern around just having a type is if a user wishes to have multiple different configurations for different types / priorities / flavours of service. Overriding the configuration seems like a more than reasonable solution for this. It may add more config but it does keep things simple.

Just merged the changes for this issue, should be available through the latest tag shortly.
@dchidell Would you mind giving it a try and letting me know if all works as expected?

Released in v2.6.0


fix(Page): Fail on Content Security Policy by detecting Log.entryAdded

A better solution to detect CSP errors than https://github.com/GoogleChrome/puppeteer/pull/1611
Since @paulirish 's idea is much better than mine, so I implemented it
If it looks ok, I'll close https://github.com/GoogleChrome/puppeteer/pull/1611
Also, thanks @JoelEinbinder @dios-david for comments!
Fixes: https://github.com/GoogleChrome/puppeteer/issues/1229

@aslushnikov
I need your help.

In order to link one to another, you'd need to label evaluation with unique sourceURL and match

By sourceURL you mean //# sourceURL= comment on the inserted script?
If so, I cannot use this for the following two reasons:

when adding a script directly with content like addScriptTag("alert(1);"), the sourceURL isn't there.
Log.entryAdded does not inform the content. It's something like this:

@aslushnikov
I need your help.

In order to link one to another, you'd need to label evaluation with unique sourceURL and match

By sourceURL you mean //# sourceURL= comment on the inserted script?
If so, I cannot use that for the following two reasons:

When adding a script tag directly with content like Page.addScriptTag("alert(1);"), the sourceURL isn't there.
Log.entryAdded does not inform the added content. Instead, it tells me something like this:

{ source: 'security',
  level: 'error',
  text: 'Refused to apply inline style because it violates the following Content Security Policy directive: "default-src \'self\'". Either the \'unsafe-inline\' keyword, a hash (\'sha256-F602irze5WpgKxQ4WBmbH1lheK/4Ejv/Vaxh9ajWedQ=\'), or a nonce (\'nonce-...\') is required to enable inline execution. Note also that \'style-src\' was not explicitly set, so \'default-src\' is used as a fallback.\n',
  timestamp:<PHONE_NUMBER>813.12,
  lineNumber: 5,
  stackTrace: { [ { functionName: 'addStyleContent',
       scriptId: '21',
       url: '',
       lineNumber: 5,
       columnNumber: 20 } ] }

One idea I came up with is to use functionName in the stack trace.
My implementation goes like this:
  async addStyleTag(options) {

    ...

    function addStyleContent(content, hash) {
      Object.defineProperty(addStyleContent, 'name', {value: `addStyleContent_${hash}`});
      const style = document.createElement('style');
      style.type = 'text/css';
      style.appendChild(document.createTextNode(content));
      document.head.appendChild(style);
      return style;
    }
  }

  ...

  async _evaluateHandle(pageFunction, content) {
    const context = await this._contextPromise;
    this._page._securityError = null;
    const hash = helper.sha256(content);
    const element = await context.evaluateHandle(pageFunction, content, hash);
    if (this._page._cspLog && hash === this._cspLog._securityError.hash)
      throw new Error(this._page. _cspLog.message);
    return element;
  }


Highlight Agility Colors - add colors

Is your feature request related to a problem? Please describe.
I'm always frustrated when I see an agility shortcut highlighted but I can't actually use it.
Describe the solution you'd like
Have it highlight a different color such as red if your agility is not high enough to use and the original green when you are able to use it. Then you can see right away if you can use it or not. Additionally, it might be nice to have the level requirement pop up with the text describing the shortcut. For example: "climb down spikey chain (61)" vs "climb down spikey chain" - what it currently says.

Duplicate #3754