rasa test nlu complains when domain is not available or invalid, when it shouldn't need it

Rasa version:
2.7.x
Rasa SDK version (if used & relevant):
Rasa X version (if used & relevant):
Python version:
Operating system (windows, osx, ...):
Issue:
When running rasa test nlu in a project repository where the domain lives somewhere other than domain.yml, it will compain about things not being in the domain. Note that this does not actually impede the NLU evaluation from running successfully.
Error (including full traceback):
/Users/ella/RasaHQ/rasa/rasa/shared/utils/io.py:97: UserWarning: Issue found in 'data/rules.yml':
Found intent 'greet' in stories which is not part of the domain.
  More info at https://rasa.com/docs/rasa/stories
/Users/ella/RasaHQ/rasa/rasa/shared/utils/io.py:97: UserWarning: Issue found in 'data/rules.yml':
Found intent 'thankyou' in stories which is not part of the domain.
  More info at https://rasa.com/docs/rasa/stories
/Users/ella/RasaHQ/rasa/rasa/shared/utils/io.py:97: UserWarning: Issue found in 'data/rules.yml':
Found intent 'bot_challenge' in stories which is not part of the domain.
  More info at https://rasa.com/docs/rasa/stories
/Users/ella/RasaHQ/rasa/rasa/shared/utils/io.py:97: UserWarning: Issue found in 'data/rules.yml':
Found intent 'chitchat' in stories which is not part of the domain.
  More info at https://rasa.com/docs/rasa/stories
/Users/ella/RasaHQ/rasa/rasa/shared/utils/io.py:97: UserWarning: Issue found in 'data/rules.yml':
Found intent 'request_restaurant' in stories which is not part of the domain.
  More info at https://rasa.com/docs/rasa/stories
/Users/ella/RasaHQ/rasa/rasa/shared/utils/io.py:97: UserWarning: Issue found in 'data/stories.yml':
Found intent 'request_restaurant' in stories which is not part of the domain.
  More info at https://rasa.com/docs/rasa/stories
/Users/ella/RasaHQ/rasa/rasa/shared/utils/io.py:97: UserWarning: Issue found in 'data/stories.yml':
Found intent 'stop' in stories which is not part of the domain.
  More info at https://rasa.com/docs/rasa/stories
/Users/ella/RasaHQ/rasa/rasa/shared/utils/io.py:97: UserWarning: Issue found in 'data/stories.yml':
Found intent 'affirm' in stories which is not part of the domain.
  More info at https://rasa.com/docs/rasa/stories
/Users/ella/RasaHQ/rasa/rasa/shared/utils/io.py:97: UserWarning: Issue found in 'data/stories.yml':
Found intent 'deny' in stories which is not part of the domain.
  More info at https://rasa.com/docs/rasa/stories

Command or request that led to error:
❯ rasa test nlu --cross-validation

Content of configuration file (config.yml) (if relevant):

Content of domain file (domain.yml) (if relevant):
Regular domain, but stowed inside of a test-domain folder instead of at ./domain.yml

To clarify -- it could need the domain if it uses the response selector! Maybe rasa test nlu should be smart enough to check the config for this component to decide if it needs the domain or not :)


valgrind problems in pure mode when reading version 1 QR code with quartile ecc level

Hi there,
today I want to report on two valgrind problems, wenn reading a "special" given QR code barcode.
I have added a basic script for valgrind usage into my repo
https://github.com/a3emdot/zintzxingcppdemo
so  one can easily use valgrind  when running my tests
cd zintzxingcppdemo
./ZintZXingCppDemoValgrind.sh
For building the project I used a Fedora installation with a properly setup developer installation.
The ./ZintZXingCppDemoValgrind.sh script drops a valgrind.log into ./build/local/src
The first relevant commit which lets only a single test alive
https://github.com/a3emdot/zintzxingcppdemo/commit/4a61f7e07dc9fe9b54e021c1fe361d7861c33590
results in valgrind-pure.log
The following commit which comments the line activating the 'pure' mode
https://github.com/a3emdot/zintzxingcppdemo/commit/7dc21a059a3e18ec73d2fe28706c6582eafe7658
results in valgrind-nopure.log
Observation:
As one can see in 'pure' mode we get two times
'Conditional jump or move depends on uninitialised value(s)'
Goal: A "clean" valgrind.log
I currently use the revisions
zint: https://github.com/zint/zint/commit/fae3e6d9d5263f71d5901453d7a8c0e2e1173209
zxing-cpp: https://github.com/zxing-cpp/zxing-cpp/commit/9a36d24e896b4f1f43544996e0f07f2434b4aa3b
I can only directly output zint outputs in .ppm format, but these can't be added here.
Hence I have converted the reproducer .ppm file into a .png image and attached that one.
Best regards
Andre
valgrind logs:
valgrind-pure.log
valgrind-nopure.log
QR code png image:

If I call valgrind ZXingReader -ispure <filename> with your provided png with the current HEAD revision, I don't get any valgrind errors, meaning I can't reproduce your problem. If you find more issues, please try to reproduce them with ZXingReader and provide a command line and a sample image that shows your issue. Thanks.

This one here is a really stripped down replacement for my main.cpp which doesn't show any problems under valgrind either.
The barcode is embedded via an character array. No Zint. and a very small main function. I will report if I make any progress.
main.cpp.txt

progress!
the image data has to be 180 degree rotated for showing the problem.
So here is a compilable minimal reproducer similar to the last one with with a barcode embedded via an character array.
main-180.cpp.txt
And here the relevant rotate barcode as test180.png

And here is my transcript with ZXingReader
[mauteand@localhost example]$ valgrind ./ZXingReader -ispure ~/tmp/test180.png
==4625== Memcheck, a memory error detector
==4625== Copyright (C) 2002-2022, and GNU GPL'd, by Julian Seward et al.
==4625== Using Valgrind-3.19.0 and LibVEX; rerun with -h for copyright info
==4625== Command: ./ZXingReader -ispure /home/user/tmp/test180.png
==4625==
==4625== Conditional jump or move depends on uninitialised value(s)
==4625==    at 0x4928F9D: ZXing::QRCode::DetectPureQR(ZXing::BitMatrix const&) (in /home/user/tmpzxingcpp/zxing-cpp/build/core/libZXing.so.2.1.0)
==4625==    by 0x493517A: ZXing::QRCode::Reader::decode(ZXing::BinaryBitmap const&) const (in /home/user/tmpzxingcpp/zxing-cpp/build/core/libZXing.so.2.1.0)
==4625==    by 0x489FCD5: ZXing::MultiFormatReader::read(ZXing::BinaryBitmap const&) const (in /home/user/tmpzxingcpp/zxing-cpp/build/core/libZXing.so.2.1.0)
==4625==    by 0x48A71BC: ZXing::ReadBarcodes(ZXing::ImageView const&, ZXing::DecodeHints const&) (in /home/user/tmpzxingcpp/zxing-cpp/build/core/libZXing.so.2.1.0)
==4625==    by 0x403B1C: main (in /home/user/tmpzxingcpp/zxing-cpp/build/example/ZXingReader)
==4625==
==4625== Conditional jump or move depends on uninitialised value(s)
==4625==    at 0x4929054: ZXing::QRCode::DetectPureQR(ZXing::BitMatrix const&) (in /home/user/tmpzxingcpp/zxing-cpp/build/core/libZXing.so.2.1.0)
==4625==    by 0x493517A: ZXing::QRCode::Reader::decode(ZXing::BinaryBitmap const&) const (in /home/user/tmpzxingcpp/zxing-cpp/build/core/libZXing.so.2.1.0)
==4625==    by 0x489FCD5: ZXing::MultiFormatReader::read(ZXing::BinaryBitmap const&) const (in /home/user/tmpzxingcpp/zxing-cpp/build/core/libZXing.so.2.1.0)
==4625==    by 0x48A71BC: ZXing::ReadBarcodes(ZXing::ImageView const&, ZXing::DecodeHints const&) (in /home/user/tmpzxingcpp/zxing-cpp/build/core/libZXing.so.2.1.0)
==4625==    by 0x403B1C: main (in /home/user/tmpzxingcpp/zxing-cpp/build/example/ZXingReader)
==4625==
No barcode found
==4625==
==4625== HEAP SUMMARY:
==4625==     in use at exit: 0 bytes in 0 blocks
==4625==   total heap usage: 122 allocs, 122 frees, 98,368 bytes allocated
==4625==
==4625== All heap blocks were freed -- no leaks are possible
==4625==
==4625== Use --track-origins=yes to see where uninitialised values come from
==4625== For lists of detected and suppressed errors, rerun with: -s
==4625== ERROR SUMMARY: 2 errors from 2 contexts (suppressed: 0 from 0)

Sorry to say, but I still can't reproduce your findings. Neither with ZXingReader nor with your main-180.cpp. Maybe a different compiler or optimization settings are to blame.
Can you maybe instruct valgrind to output more details, like a line number. The mentioned --track-origins=yes sound also helpful.

Also, to remove another potential source of error or misunderstanding: please make sure you perform your tests with the HEAD revision of zxing-cpp.

just now cloned from github and compiled
on a archlinux notebook and on a fedora 37 notebook using the default gcc compilers
we, co-worker and me, see the memory problems.
How may I help you further?
Could you tell us something on your development platform?
Are you savy with a Dockerfile if I provide one?

How may I help you further?

See above comment about valgrind options. Also, you could provide the cmake command line you used to setup your build.

Could you tell us something about your development platform?

Standard Ubuntu 23.04.

Do you know know to use a Dockerfile if I provide one?

That would only be the last resort ;).

Sorry no line numbers.
Looks like the problems happen within the release build.
I initially thought adding no build type parameter to the cmake parameters, would trigger a debug build.
But that is not the case here under Fedora 37.
I'm adding my run.log and the outputs of my cmake build runs for the debug and release builds.
run.log
build-1.log
build-2.log

After using the combination "gcc + optimizer + debug info" I found the problem. Thanks for your effort in hunting this down.

FYI. With my just installed fedora updated gcc-12.3.1 i can't reproduce the pre-patched situation anymore

clang-15 did not show it either but gcc-12.2.0 did and my understanding of c++ is congruent with this warning (std::array<int, 1> a; constructs an uninitialized int a[0]). So I believe this actually was a bug in the code.

I will try to check your fix together with my co-worker (archlinux, gcc 13.1.1 20230429)

I have just seen that my demo tool doesn''t expose the bug anymore.
But please don't ask about my shipped patch set :-(
Thank you very much, that worked for me
Andre


No readings are processed for the event, so ignore it

Please describe your problem in detail, if necessary, you can upload the log file through the attachment:
ekuiper flow type is: edgex
configuration group is:nats
listening topic is:edgex/events/device/device-virtual/#
The rule configuration is as follows

Nats topic subscribe content

Thanks for the description.  If you are experiencing difficulties receiving data, it is possible that there may be configuration issues in your deployment of EdgeX.

Close as no response. Feel free to reopen if you still have problems


Avoid linking with system libcrypto

Linking with system libcrypto.* takes out control on crypto library version. Which is potentially insecure. Library built in libcrypto-build/ shold be used instead.
Verified on Linux with -Wl,--verbose.
Before:
cc -Wl,--verbose -pedantic -Wall -Wimplicit -Wunused -Wcomment -Wchar-subscripts -Wuninitialized -Wshadow -Wcast-qual -Wcast-align -Wwrite-strings -Wstack-protector -fPIC -std=c99 -D_POSIX_C_SOURCE=200112L -fstack-protector-all -O2 -I../libcrypto-root/include/ -I../api/ -I../ -Wno-deprecated-declarations -Wno-unknown-pragmas -Wformat-security -D_FORTIFY_SOURCE=2 -I../../ -I../../api/ -I../../libcrypto-root/include/ -shared -L../../lib/ -lcrypto -lpthread -ls2n -o       libtests2n.so s2n_print_connection.o s2n_stuffer_hex.o
...
attempt to open ../../lib//libcrypto.so failed
attempt to open ../../lib//libcrypto.a failed
attempt to open /usr/lib/gcc/x86_64-redhat-linux/4.1.2/libcrypto.so failed
attempt to open /usr/lib/gcc/x86_64-redhat-linux/4.1.2/libcrypto.a failed
attempt to open /usr/lib/gcc/x86_64-redhat-linux/4.1.2/libcrypto.so failed
attempt to open /usr/lib/gcc/x86_64-redhat-linux/4.1.2/libcrypto.a failed
attempt to open /usr/lib/gcc/x86_64-redhat-linux/4.1.2/../../../../lib64/libcrypto.so succeeded
-lcrypto (/usr/lib/gcc/x86_64-redhat-linux/4.1.2/../../../../lib64/libcrypto.so)

After:
cc -Wl,--verbose -pedantic -Wall -Wimplicit -Wunused -Wcomment -Wchar-subscripts -Wuninitialized -Wshadow -Wcast-qual -Wcast-align -Wwrite-strings -Wstack-protector -fPIC -std=c99 -D_POSIX_C_SOURCE=200112L -fstack-protector-all -O2 -I../libcrypto-root/include/ -I../api/ -I../ -Wno-deprecated-declarations -Wno-unknown-pragmas -Wformat-security -D_FORTIFY_SOURCE=2 -I../../ -I../../api/ -I../../libcrypto-root/include/ -shared -L../../lib/ -L../../libcrypto-root/lib -lcrypto -lpthread -ls2n -o libtests2n.so s2n_print_connection.o s2n_stuffer_hex.o
...
attempt to open ../../lib//libcrypto.so failed
attempt to open ../../lib//libcrypto.a failed
attempt to open ../../libcrypto-root/lib/libcrypto.so failed
attempt to open ../../libcrypto-root/lib/libcrypto.a succeeded

I think something unexpected may be going on here. Per the build instructions (https://github.com/awslabs/s2n/blob/master/docs/USAGE-GUIDE.md) there should be a libcrypto.a in s2n/lib/ which is ../../lib/ in this context. Any idea why it might not be getting linked against?

Per instructions libcrypto.a is built inside libcrypto-root/ directory. There are no steps mentioned to copy libcrypto.a to ./lib. Makefiles do not seem to copy it over either. The library build links directly with ../libcrypto-root/lib/libcrypto.a (lib/Makefile:22).
However testlib and unit tests link with -lcrypto: tests/testlib/Makefile:24 and tests/unit/Makefile:30

You're right, my mistake; we used to copy libcrypto.a.

Dupe of https://github.com/awslabs/s2n/pull/93 which was merged this afternoon?

Correct - we meant to close this issue as it is resolved by your earlier pr.
Sent from my iPhone

On Jul 6, 2015, at 18:48, Benjamin Seidenberg<EMAIL_ADDRESS>wrote:
Dupe of #93 which was merged this afternoon?
—
Reply to this email directly or view it on GitHub.

closin g as a duplicate of #93


Specify Anaconda version process

It might be helpful to mention that the Anaconda version is Python 3.7 for the installation process.

Removed from install instructions


Provide warnings for Unused and duplicate CLI args

Description:
Ballerina runtime needs to provide warnings if user CLI args are unused during config variable loading.

Need to handle duplicate args as well.


Having graphics and time comments lead to an error

When time comments (e.g. from lichess games) are combined with graphical notations (like arrows and circles), this leads to the following notation on lichess:
1. e4 { First move } { [%cal Gd2d4] } { [%clk 0:02:00] }
This is shown in the Configuration Builder as error:

Offset: 38
PGN: 1. e4 { First move } { [%cal Gd2d4] } { [%clk 0:02:00] }
Expected "(", "*", "0-1", "0:1", "1-0", "1/2-1/2", "1:0", "O-O", "O-O-O", "x", [RNBQKP], [a-h], end of input, or integer but "{" found.

However, the following notation can be read:
1. e4 { First move } { [%cal Gd2d4] [%clk 0:02:00] }
Difference is, that there is only one annotation comment, that includes both arrow and time annotations.

Added the test case to the set of tests, works.


[Feature Request] New-GitlabGroup

1. Provide a general summary of the issue in the Title above
I would like to see a possibility to add a new group in the Gitlab.
Currently only Get-GitLabGroup is supported
2. Describe Your Environment
Operating System and PowerShell version:
PS5 Windows 2016
3. Expected Behavior
I would like to have a feature like New-GitLabGroup which creates a new group or subgroup
under the provided path.
Thanks!

Am looking into doing this, @mhackethal.

Robin, this would be a great addition. Let me know if you need anything!

Made pull request #198

Hey @robinmalik, @ngetchell, are we able to get these changes released to the PS gallery? I was using the gallery version of the module that doesn't have this functionality and ended up writing my own New-GitLabGroup before I saw it was in here already (Doh!).


add script for composer installation

composer should be a global tool, not project specific

not always
for example translators don't need globally accessible composer, but need it for producing reports with php build translation

@vchenin it's not argument for it.
Are you place PHPStorm or your other IDE/editor to project dir? Git? Other tools for project developing?

still this script does not belong to yii in this form. Add it to your project if you need it.
For translators we could enhance the build command so that it ensures it can run out of the box.

I already advance functionality of script, now it's more useful.
Now is possible to install composer globally:
sudo sh getcomposer.sh -g
or locally:
./getcomposer.sh -l
or with specified options:
./getcomposer.sh -o --filename=composer --version=1.0.0-alpha8


pending binding requests are removed from the queue after 500ms if the queue is full

Merged with 34ef65fcea0e14a864300de4ab715e700830c4cc thanks again @jjmaldonis :)


Kerberos: Change hard-coded port in krb5.conf to configurable with defaults to 749

We are installing CP-Ansible (latest 7.3.3) with kerberos on AWS Managed MS AD (https://docs.aws.amazon.com/directoryservice/latest/admin-guide/ms_ad_tutorial_setup_trust_prepare_mad.html)
Installation fails as it is not using the hard-coded port for the admin server (749) but managed MS AD.
Suggested improvement: Add variables for kerberos port(s) with defaults for the currently hard-coded values in krb5.conf.j2

PR was merged, thanks @wadhwa1 !


Add part on how to set the icon properly

I had to google and find some random forum entry to find out where to put the icon file to make it work. I thought it would make sense to share that information here too.

Thanks @bergjs
btw. I've added you to the collaborators team - you should be able to merge when others have reviewed? let me know if not possible :)


Update minor releases for driver to 3.11.5 and JUnit 4.13.2

I built the new JDBC and released under version 1.5. Feel free to download and set up a custom JDBC withing DataGrip.
It would take some time to test it in our test farm and make it public within DataGrip.


question about potential bug reports

Hi
We might have found some bugs in pdfminer.six, but they can only be replicated on some documents, for which we have several examples. However, we are not allowed to share the documents with anyone. How can we open an issue in this case? Creating a document to be able to replicate the bug is very hard, because we do not know what exactly is different about the documents giving issues.
Thanks!

Can't you extract an innocuous page of the document and replicate the bug?

You can open the pdf's with a text editor like atom, notepad++ or sublime and edit the content of the pdf. You could try to identify and remove the (possible binary) content you try to don't want to share.
Without an example pdf there is, indeed, not much that we can do.

Another thing you can do is to open an issue without an example pdf. This is not recommended because it makes it difficult to replicate. However, the error message might be enough to identify the root cause and fix it. Also, other people might recognize the bug and have a pdf available that they can share.
I'm closing this issue as there is nothing to do here. Feel free to reopen it if you have other specific questions about this topic.


Interpolate task progress

Expected Behaviour
The progress of tasks update every tick according to the speed of the machines.
Actual Behaviour
At the moment, the progress of tasks will only update at a specific interval (10 ticks) instead of per tick.

Implemented in #21


Fix mutation test

Follow up from #788
@benvinegar

Ah, yeah – at first I thought this was just an out of date comment, thanks.


JavaScript

#JavaScript
User Story
As a bootcamp student
I want the prework notes to be structured on a webpage
So that I can easily find and read the information
Acceptance Criteria
GIVEN a Prework Study Guide website
WHEN I view the study guide
Then I can see the four topics I learned listed along with a suggestion on what I should study first

Well done


[BUG] Frigate MQTT jpg and frigate/events

Describe the bug
It looks like mqtt topic frigate/events doesn't receive any mqtt jpg's.
We can change it to frigate/+/person/snapshot and then mqtt properly is processed. However, in this case Double Take doesn't get any mqtt event and doesn't pull any "latest" or "snapshot" from frigate. Also, in this case it does not update any sublabel in frigate.
Version of Double Take
X.X.X-SHA7
Expected behavior
To be able to receive mqtt jpg and also process API frigate snapshot and latest with sublabel update. Maybe subscribe to both topics?
Screenshots
If applicable, add screenshots to help explain your problem.
Hardware

Architecture or platform: amd64
OS: Ubuntu
Browser (if applicable) n.a
Docker image (if applicable) HA Addon

Additional context
Add any other context about the problem here.

fixed in latest beta. as a workaround, you can add to config you cameras manually:
frigate:
  cameras:
    - your_camera_1
    - your_camera_2

Sorry for being a pest, but how this workaround is supposed to work? I have one camera passed to DoubleTake, and the issue is with mqtt not working together with snaphots/latest...

This looks like it's still an issue. Switching back to jakowenko's version and I get detections via MQTT, using your fork I never get a detection from mqtt.

Absolutely not an issue.
Take a look at pics

what build are you using? It just absolutely refused to work on latest for me, but switching to jakowenko's version and it works perfectly.


Redis Plugin Issue

Trying to confifure Redis plugin, but receiving the below message -
Starting newrelic_redis_agent service...
[Tue Mar 31 09:20:46 UTC 2015] Agent Redis is at version 1.0.1
NOAUTH Authentication required.
[Tue Mar 31 09:20:46 UTC 2015] Gathered 0 statistics
How do I supply the password to the plugin?

Have you tried the full URL schema in the config file?
agents:
  redis:
    url: redis://:p4ssw0rd@<IP_ADDRESS>:6380

Yes, I tried these

This one did not work, got "URI::InvalidURIError"

agents:
redis:
url: redis://:p4ssw0rd@IP:6379

This one gave a new error -

agents:
redis:
url: redis://p4ssw0rd@IP:6379
Starting newrelic_redis_agent service...
[Wed Apr 01 04:00:49 UTC 2015] Agent Redis is at version 1.0.1
getaddrinfo: Name or service not known
[Wed Apr 01 04:00:49 UTC 2015] Gathered 0 statistics
Let me give you our set up
We have 2 servers - 1 for application where we have New Relic
configured to capture statistics. This server also has redis
configured. The second server has the database.
On Wed, Apr 1, 2015 at 3:21 AM, Ken J<EMAIL_ADDRESS>wrote:

Have you tried the full URL schema in the config file?
agents:
redis:
url: redis://:p4ssw0rd@<IP_ADDRESS>:6380
—
Reply to this email directly or view it on GitHub
https://github.com/kenjij/newrelic_redis_plugin/issues/8#issuecomment-88261541
.

--
Regards,
Ravi Shankara
Pramata Knowledge Solutions (Pvt) Ltd
<EMAIL_ADDRESS>+91<PHONE_NUMBER>

I had success with this so it's probably your environment.
You do need the : before the password. Double check your URL string. Might be good to check if your ruby and gems need updates.
If you want to do further troubleshooting yourself, try this with irb. This is the exact script I ran for testing.
require 'redis'
redis = Redis.new(:url => "redis://:password@<IP_ADDRESS>:6379")
redis.info

Had the same issue, if you have special characters in your password, you need to encode it with any url encoder tool, such as https://meyerweb.com/eric/tools/dencoder/

how to start newrelic redis plugin agent


Undocumented: method group conversion

The fixer Apply method group conversion preferences appears in the VS2022 list, but it is not documented on this page.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: faebd126-53cd-1a98-bf75-38225933b0f2
Version Independent ID: 4340fcba-6779-68d2-6c51-2ae37123dc26
Content: Code style options and code cleanup - Visual Studio (Windows)
Content Source: docs/ide/code-styles-and-code-cleanup.md
Product: visual-studio-windows
Technology: vs-ide-general
GitHub Login: @Mikejo5000
Microsoft Alias: mikejo

@HughWarrington -- Hugh, thank you for your feedback.  Please consider these resources:

Visual Studio on Microsoft Q&A
Visual Studio MSDN Forum
Stack Overflow
Reddit

@Mikejo5000 -- Mike, please look into this issue.

@mikadumont Mika, can you help identify what CA rules are associated with Apply method group conversion preferences?

Why do you have to close old issues to prioritise newer ones?


RYA-221 Upgraded to Geomesa 1.3.0-m1

Description
Upgraded to Geomesa 1.3.0-m1
Tests
no new tests
Links
Jira
Checklist

[ ] Code Review
[ ] Squash Commits

People To Review
@pujav65

looks good, about to merge


Reworded the means section

This should be easier to read.
(Also, test what kinds of events a post-merge PR triggers.)

[+Needs:Evaluation][+Needs:Merge][-Prio:High] First and third should work, second should fail.

The following autolabelling commands failed:
+Needs:Merge - not authorized

The following autolabelling commands failed:
+Needs:Merge - not authorized

Another commit did more and better work of this.


move gh-pages to docs/ folder

https://github.com/blog/2228-simpler-github-pages-publishing

@gagern I remember you had some concerns about moving the .gif that's in the gh-pages branch into the main branch, is that correct?  I was thinking of moving that file to S3 so that it doesn't have to live in the main repo.

Yes, @kevinbarabash, I had some minor concern wrt. repo size. Not a problem for a few GIFs now. Things will become problematic if at some point we decide that we want a gallery of one hunderd high resolution renderings comparing engines, or something of this kind. That would force developers to download stuff they never use. But even that would be preferable to having images deployed using yet another technology. So if you are positive about moving docs, I'd say leave the images in. That way we can at least collaborate on docs the same way we do for sources, without having to learn additional tools and granting additional permissions.

We could ask people to make pull requests against the gh-pages branch.  Another option is to create a separate repo for the web page... this doesn't seem to offer much benefit from using gh-pages b/c it would require a separate checkout.  I think for let's continue to use gh-pages consider the number of changes to have been negligible and I don't foresee many pull requests to that branch.


[Theme] Request for Zenburn

Only one thing missing here , Zenburn!

I've implemented Zenburn color scheme for Midnight Lizard.

If you like how it looks you can support us by buying it here.
There will be a json file that you can add to Midnight Lizard by following this instruction.
PS: Then you can even resell it to someone else.


Should not assert unsupported response capabbility in spdm_set_data()

REF: #205
Move it to server init function.
Signed-off-by: yi1 li<EMAIL_ADDRESS>

Requester and responder use same bit to indicate supported capabilities, such:
#define SPDM_GET_CAPABILITIES_REQUEST_FLAGSHANDSHAKE_IN_THE_CLEAR_CAP BIT15
#define SPDM_GET_CAPABILITIESRESPONSE_FLAGS_HANDSHAKE_IN_THE_CLEAR_CAP BIT15
it is my bad that treat it as different thing just according name, this is a wrong patch. :(


Is there a better way to provide test-data for modules than we currently have, with the two stage process.

Just a thought (not exactly connected to this issue), but would it be easier to have a test-datasets-modules repository?. I find it a little clunky to have to push to a specific branch for modules.


fix(ffe-form): Increase top margin on ffe-radio-switch

This commit introduces margin on top of the ffe-radio-switch
giving it the same visual distance between the label and the input
control that radio-button-input-group has.
Fixes #349

Coverage remained the same at 80.486% when pulling<PHONE_NUMBER>4b4c6857d996ae2cece3c9955ddc6c on ivarni:349-more-space-for-radio-switch into ea116814162be4a0a0b10d48b71da4a3f76d5e8f on SpareBank1:develop.


lums/tmp/teo/kmeans

This PR manually reapplies the various commits in the diverged descendants of teo/kmeans that led to such a disaster in PR #130:

Started with d085f66 (?)
Updated C++ kmeans and kmeans++ was completed in commit e5e3690
Merged main (37c9c9b?) into e5e3690
Merged 0f73373 into e5e3690
Rename e5e3690 to be lums/tmp/teo/kmeans

Updates since d085f66:

Added code in kmeans to reassign centroids that have small (including empty) partitions.  There is now a member variable reassign_ratio_ of the kmeans_index class that will reassign partitions that have size smaller than reassign_ratio_ times the size of the largest partition.  The default value of reassign_ratio_ is 0.025 (the ratio of largest to smallest partition will be bounded by a factor of 40).

For each centroid c_i to be reassigned, we choose the vector in the training set with the i'th largest score (i.e., the vector farthest away from its own centroid).
This helps quite a bit in the case of random initialization.  It does not help as much in the case of kmeans++ initialization because the centroids are already well-distributed.
Also tried reassignment with random vector, but that did not work as well as reassigning most distance vector.

Added code in kmeans to check for convergence.  At each iteration it measures how much the centroids have changed since the previous iteration and compares that to the total "potential" of all the centroids.  If the delta is less than a tolerance times the total, the kmeans iteration breaks.
Created numerous unit tests for various components of the library used by kmeans_index
Updated fixed_min_heap to take a comparison function objects (to be able to create fixed max heaps, e.g.)
Created qv_partition_with_scores to provide a scores vector to be used in reassignment.

There are a few todos:

Parallelize the loop over all thetraining_set vectors in kmeans (Partitions are, well, partitioned among threads.  Every thread loops over the entire training_set but only processes vectors from its designated set of partitions.)
Implement greedy kmeans++ algorithm, which uses multiple candidate centroids at each iteration and chooses the one that most decreases the potential.  This approach is what scikit_learn uses and is reported in the literature to be better than plain kmeans++.

Random initialization:
sklearn score: 6.619185447692871
tiledb score: 5.118894100189209
K-means++:
sklearn score: 3.9469563961029053
tiledb score: 4.516618251800537

Random initialization:
sklearn score: 6.619184494018555
tiledb score: 5.32197380065918
K-means++:
sklearn score: 3.9469563961029053
tiledb score: 4.792552471160889

Random initialization:
sklearn score: 6.619185447692871
tiledb score: 5.255888938903809
K-means++:
sklearn score: 3.9469563961029053
tiledb score: 4.764191150665283


Unable to load the mat file and the format mat file to be saved

I am going to load a normal ''.mat" file in the torch. But it has following eror:
Segmentation fault: 11
And I am trying to re-save the data in the matlab with compatible format, but I found that the command in the "test" directory is a bit confusing, the command "save -mat7-binary 'test.mat' a" has made me confused. Does anyone know how to save the ".mat" file correctly so that I can load it in the torch?
Thank you so much.

I am not sure what format exactly this package support, I use the same file name "a" in the matlab when I save data, it works.
I close to this issue.


Cool concept, but no longer seems to work.

Options to render and download do not appear, nor do brush colors. Are there any fixes planned with this?

Here are my instructions to install an updated, working version. Tested it just now, it's working :smile:
https://github.com/ben174/git-draw/pull/12#issuecomment-737366020

You can try https://github.com/Annihil/github-spray

You can try https://github.com/Annihil/github-spray


Download icon indigo

can you add a screenshot?

@akegan ^

please also check to make sure you don't inadvertently update the color of any other buttons


Add Linter and Formatter for Python Files in CI/CD

As we discussed here: https://github.com/kubeflow/training-operator/pull/1907#discussion_r1321085930, we need to add script to our CI/CD that uses black and flake8 to verify Python files.
Similar to our checks for Go: https://github.com/kubeflow/training-operator/blob/master/.github/workflows/test-go.yaml#L32.
/help

/good-first-issue

/lifecycle frozen


fix: patch eslint module resolution

:tada: This PR is included in version 13.12.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


[BUG] esteem-mobile v2.1.0 The app displays error when server is set at steemd.previx.io

Project Information
Repository: https://github.com/esteemapp/esteem-mobile
Project Name: esteem-mobile
Expected behaviour
The app may have got successfully connected when I set the server at steemd.previx.io.
In order to check this is not network problem ,I set the server at api.steemit.com ,it got successfully connected.
Actual behaviour
When I set the the server at steemd.previx.io, the app displays the message "connection failed".
How to reproduce
1-Download the application
2- Go to the setting > server
3- Set server at steemd.previx.io
4- see bug (Connection failed message will be displayed)
Browser/App version: v2.1.0
Operating system: 7.1.2
Smartphone: redmi 5A
Recording Of The Bug
https://youtu.be/xoqwTRg-Ygk
My Github Account
https://github.com/peerzadaaabid

Close this... Meaning the server is not available


[CP Staging] Revert "Feature: add loading indicator when ReconnectApp is running"

Reverts Expensify/App#48772
Context https://expensify.slack.com/archives/C02NK2DQWUX/p1730894208049459
Fixed Issues
$ https://github.com/Expensify/App/issues/52099
$ https://github.com/Expensify/App/issues/52101
$ https://github.com/Expensify/App/issues/52106
$ https://github.com/Expensify/App/issues/52108
$ https://github.com/Expensify/App/issues/52110
$ https://github.com/Expensify/App/issues/52111
$ https://github.com/Expensify/App/issues/52113
Tests
Tested here https://expensify.slack.com/archives/C02NK2DQWUX/p1730906247478619?thread_ts=1730894208.049459&cid=C02NK2DQWUX
cc @nkdengineer @srikarparsi @getusha

Wow 7 Issues!

Maybe it's a mistake when I update the animation that breaks other places using animated components. Then many issues appear.

Reviewer Checklist

[ ] I have verified the author checklist is complete (all boxes are checked off).
[ ] I verified the correct issue is linked in the ### Fixed Issues section above
[ ] I verified testing steps are clear and they cover the changes made in this PR

[ ] I verified the steps for local testing are in the Tests section
[ ] I verified the steps for Staging and/or Production testing are in the QA steps section
[ ] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[ ] I checked that screenshots or videos are included for tests on all platforms
[ ] I included screenshots or videos for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

[ ] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[ ] I verified proper code patterns were followed (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[ ] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[ ] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[ ] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I verified that this PR follows the guidelines as stated in the Review Guidelines
[ ] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] If a new component is created I verified that:

[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[ ] If any new file was added I verified that:

[ ] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn't already exist
[ ] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)

[ ] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[ ] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[ ] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[ ] I verified that all the inputs inside a form are aligned with each other.
[ ] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[ ] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[ ] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[ ] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

Ignoring author checklist, lets get this merged


Relicense from GPL-2.0 to BSD-3

For consistency with https://github.com/ami-iit/bipedal-locomotion-framework/pull/550 .

Actually we should probably also cleanup the code headers, let's put this in draft.

Actually we should probably also cleanup the code headers, let's put this in draft.

Done, PR is ready for review and merge. @GiulioRomualdi @S-Dafarra


Manage mailbox auditing

This article states:

To retrieve mailbox audit log entries for users without E5 licenses, you can:

Manually enable mailbox auditing on individual mailboxes (run the command, Set-Mailbox -Identity [MailboxIdentity] -AuditEnabled $true). After you do this, you can use audit log searches in the Microsoft 365 compliance center or via the Office 365 Management Activity API."

Does this still have to be done if at the organizational level we have mailbox auditing enabled as per this section?:

Although mailbox audit logging on by default is enabled for all organizations, only users with E5 licenses will return mailbox audit log events in audit log searches in the Microsoft 365 compliance center or via the Office 365 Management Activity API by default."

It seems contradictory to state that its enabled for all organizations by default, yet action is required on my part to enable as a non E5 customer.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: b1aac99b-5c65-74d3-7610-b7ba4fcac493
Version Independent ID: a0b2ab87-7d52-3429-630e-6b7a316b5f23
Content: Manage mailbox auditing - Microsoft 365 Compliance
Content Source: microsoft-365/compliance/enable-mailbox-auditing.md
Service: o365-seccomp
GitHub Login: @chrisda
Microsoft Alias: chrisda

@Blake-nisius Hope this comment is helpful for you. If you see a documentation update is required, please feel free to open an issue for the same. We proceed here to close it. Thanks for taking out some time to open the issue. Appreciate and encourage you to do the same in future also.


Update psalm/plugin-symfony

Q
A

Bug fix?
no

New feature?
no

Deprecations?
no

Tickets
N/A

License
MIT

Prevent the build from failing thanks to https://github.com/psalm/psalm-plugin-symfony/pull/296

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
51

Relevant Lines:
51

💛  - Coveralls


Create File Share

@gnehapk @nnDarshan @brainfunked @mcarrano @japplewhite
In reviewing comments on the Create File Share UX design (https://redhat.invisionapp.com/share/Q78YMAVDJ#/screens/217726640), there were comments that we need to ask user to input the # of replica sets (in the case of distributed replicated volume type) or # of subvolumes (in the case of distributed dispersed / EC volume type).
In thinking about this and looking at the gluster CLI, the user today never has to specify the replica set or subvolumes, so why should we make user do this in the UI.  It is not expected behavior.  Note: we did this in the past (old Gluster console) to reduce some of the business logic implementation work.
To be more specific, here are the CLI commands to create the volumes for the 2 different volume types:
Distributed Replicate CLI command/example (4-node distributed replicated volume with a 2-way mirror):
gluster volume create test-volume replica 2 transport tcp server1:/brick1 server2:/brick2 server3:/brick3 server4:/brick4
Distributed Dispersed CLI command:
gluster volume create disperse  [redundancy ] [transport tcp | rdma | tcp,rdma] [list of bricks]
Thus, IMHO, Tendrl should automatically determine the replica sets / subvolumes based on the volume type and # of nodes in the Gluster trusted storage pool.
Additionally, Tendrl needs to include business or validation logic to ensure the following in bricks being used in the replica set / subvolumes -- this includes and is not limited to the following:

For distributed replicated, ensure replica set members (bricks) are not placed on the same node
For distributed replicated, an even number of bricks must be used
For distributed replicated, the number of bricks in a volume must be must be multiple of the replica count (2 or 3 depending on 2-way or 3-way distributed replicated)
Minimum number of bricks gets derived based on replica count and number of nodes in the Gluster trusted storage pool.

If 2-way, 4 nodes, then # bricks min is 2
If 2-way, 6 nodes, then # bricks min is 6
If 3-way, 6 nodes, then # bricks min is 6

For EC (distributed dispersed), refer to https://access.redhat.com/documentation/en-US/Red_Hat_Storage/3.1/html/Administration_Guide/chap-Recommended-Configuration_Dispersed.html to derive the rules needed.

Also note that we should look at the old Gluster console and Heketi for the logic as this has already been implemented previously.
Note: The ideal user flow in the UI for setting up a volume would be as follows:

user picks volume type (along with specifying other volume attributes, e.g. volume name, cluster if not known, protocols, etc.)
user picks bricks to use
System (Tendrl) automatically distributes bricks into replica sets / subvolumes and ensures sufficient # bricks are satisfied and properly distributed between the replica sets / sub volumes, and shows/previews them to the user the layout and lets user know when additional bricks are required (if insufficient bricks selected), insufficient diversity of bricks (if bricks are not coming from all the different nodes), etc.

@julienlim I think that automatic specification of parameters for gluster volume creation is a great feature but only as a default setting in a volume creation form. From this text it isn't clear to me if you want to hide majority of settings for volume creation away from user entirely. Also restrictions for number of bricks is a great thing but maybe it would be good if there was some global setting or a checkbox in the form that allows user to try unsupported configurations.

@mcarrano  @julienlim  The reason its not needed in cli is, user would be providing the brick in multiples of replica count or in multiples of 6/11/12 (in case of EC). If not given in multiples cli refuses to create volume.
But in case of UI as portrayed in: https://redhat.invisionapp.com/share/Q78YMAVDJ#/screens/217726637 and https://redhat.invisionapp.com/share/Q78YMAVDJ#/screens/217726637. UI code needs to show buckets of replica sets or sub volumes, where user drops individual bricks... If user provides # replica sets or # subvolumes before hand, UI can clearly have those many # of buckets...Without this number UI will have to either show a long list of buckets or limit the number of buckets to 2 and show new buckets as and when user fills available buckets.
Please provide your thoughts

@julienlim In the validation logic that is mentioned in https://github.com/Tendrl/dashboard/issues/190#issuecomment-285788853. Second bullet says "For distributed replicated, an even number of bricks must be used". But in case of 3way replicated volume with 3 replica sets, the total bricks needed is 9 right ?

@julienlim Can you please elaborate bullet 4?

@gnehapk @nnDarshan @brainfunked @mcarrano @japplewhite @fbalak
In the CLI (and heketi), the replica sets and subvolumes are derived automatically by Gluster based on the # of bricks being used an # replicas.
For example, replica set = # bricks / # replicas, and the resulting number cannot be a fraction.
Per Ben England, in a Gluster volume, DHT uses replica sets as subvolumes, so the more replica sets in a DHT volume, the more throughput you can achieve.
Asking a user to specify replica sets (or subvolumes) is probably not a good thing as it could potentially reduce throughput if user opts for a lower number unless we tell users how to correctly calculate the value of replica sets / subvolumes themselves.
So here are a few ways to address this in the UI:
(1) Allow user to specify # Replica Sets / # Subvolumes, and hope user knows how to calculate this.  This avoids System having to perform this calculation but can potentially lead to poor Gluster (throughput) performance.  Note: We should provide adequate guidance, i.e. infotip and/or documentation, on how to do so.  If we go down this route, then defaulting to 2 makes sense and we somehow need users to adjust this to avoid performance penalties.
(2) Match the Gluster CLI in that user specifies # bricks, and System generates the Replica sets / subvolumes automatically, and System will "intelligently" distribute the bricks to the replica set / subvolume aligned with best practices (e.g. bricks in the replica set not from the same node).
(3) Allow user to specify # Bricks per Replica Sets / # Bricks per Subvolumes, and hope user knows how to calculate this.  This avoids System having to perform this calculation but can potentially lead to poor Gluster (throughput) performance.  Note: We should provide adequate guidance, i.e. infotip and/or documentation, on how to do so.  I believe this is what was done previously in the old Gluster console.
In all approaches, System will need to validate against best practices and flag issues for user to resolve (e.g. insufficient bricks, insufficient distribution amongst the nodes, multiples of replica count or in multiples of 6/11/12 (in case of EC), etc.)
I still lean towards Approach #2, and we can adjust the design accordingly.  Thoughts?
=====
@nnDarshan - Refering to "@julienlim In the validation logic that is mentioned in #190 (comment). Second bullet says "For distributed replicated, an even number of bricks must be used". But in case of 3way replicated volume with 3 replica sets, the total bricks needed is 9 right ?"
For distribute replicated, it always have to be in multiples of the # of replicas.  If you plan to have 3 replicas and 9 bricks, then the replica set is as follows:
replica set = # bricks / # replicas
= 9 / 3
= 3
"For distributed replicated, an even number of bricks must be used" statement is not correct (I was thinking of an example when I wrote that statement, and thank you for your attention to detail.

IMO the best approach is already implemented by Heketi:

Only provide the information necessary (replica count, EC profile)
Let "the system" decide which bricks to use based on the information provided
Additionally: Leverage our GUI advantage over Console and display which bricks on hosts we use

IMO we should not ask the user to list each single brick manually that should be used for the storage. In my experience a lot of users have only 1-3 volumes in a storage pool and always use all bricks for all volumes.

@cloudbehl Could you sum up the state of this issue? I mean, short description of what one can take away from this. Thank you.


Animate keyboard keys upon release

I'm opening this pull request so that you can take a look at these changes and decide if you like them.
Previously you were drawing just one shape for each key then changing it to either the active or inactive, and then applying the border. In order to have the animation show up in the right place, though, I had to break those out into separate steps each and draw them all. That is why I moved the Setting_Keyboard_Shape switch to the SetNextShape() method.
I used scale multipliers to apply my desired animation. Then in the Update() method I scale those down linearly to a min value of zero.
Do you think there would be value in implementing some other animation types besides linear?
Do you have any ideas for other things to animate?
I was going to start taking a look at possibly implementing this for gamepad gas/brake. Do you think it might make sense there?

I'm not sure how this would work for gamepad (or any other future visualizations, eg. wheel, if desired) and I'd rather have something that's the same between all of them.
The Thing::Update() method is actually a good refactor that would be able to make g_dt go away, which might be a good thing to have in itself, as a separate thing.
To answer the animations question, yeah, if this were the way to go, I'd probably want to have multiple kinds of easing functions aside from just linear, to make it a bit less jarring.

Easing functions! That was the phrase I couldnt think of last night. Yeah, more than linear would be cool.
As a keyboard player, I developed this for keyboard without looking at gamepad code. But I agree looking at it now that it doesnt all translate that simply.
I would be happy to open another pull request with just the Thing::Update refactor but i see some other existing pull requests in the area of acceleration and I dont want to cause merge conflicts if i dont have to. What do you think?

That's a good point, I'll follow up on #27.


Wiki latest link error

https://github.com/d3/d3/wiki has a link to the latest version in the instaling section. This points too https://unpkg.com/d3/build/ which appears to forward too<EMAIL_ADDRESS>but the output on the page is:
Not found<EMAIL_ADDRESS>

Fixed. The current instructions are here: https://github.com/d3/d3/blob/main/README.md#installing


Move isDeleteAllItemsModalVisible and isCopyItemsVisible into App/ItemsPage State

Commit: https://github.com/johneastman/todo/commit/60a7fadbf9e1761ee23dc1551bb98937c20122ff


Feature Request: (mabye) make this Plugin more useable if the Project is not a java project/ doesnt have source sets.

Hello.
So A bit of context: I am pulling artifacts together, so they can be put in a native (outside of gradle) installer.
I am doing this using a configuration, and adding the dependencies to the configuration.
Now I still need to add the extraJavaModuleInfo to project, or else I will untransformed jars without jpms infos and that wont work.
However the plugin currently only registers itself with configurations that are related to sourceSets my configurations isnt related to one..
After skimming through the code it seems there is an Attribute "javaModules" of type Boolean, so I thought maybe i can use that.

val gimme by configurations.registering{
    isCanBeConsumed=false
    attributes{
        attribute(Attribute.of("javaModule", Boolean::class.java),true )

Howerver that gives me
Build file 'G:\development\java21\blub\zInstaller\Setup-JournalReportingTool2\External-Artifacts\build.gradle.kts' line: 9

Could not create domain object 'gimme' (Configuration)
> Unexpected type for attribute 'javaModule' provided. Expected a value of type boolean but found a value of type java.lang.Boolean.

And it seems like kotlins boolean handling is an absolute nightmare and there is no way to get a  correct primitive java boolean... as a workaround i am gonna try to add an empty dummy sourceset tomorrow and see if that gets me somewhere .
Best regards

Hi, I'll give more feedback on this later.
In general, the type you need to use for the attribute in Kotlin is Boolean::class.javaObjectType.
Hope this helps.

Ah many thanks, cant believe i spend like an hour trying all kind of ai generenated nonsense to get this boolan nonsense to work, but couldnt find this syntax ;)

Ok I got my setup running, but probably would recommend my aproach; it can be a bit confusing how gradle handles variant selection slightly different than "normal"

And now I also got the usecase that my project actually is a java project, but because it implecetly activates itself for all source sets, it also also integrates itself with source set that will break and cant easily migrate. As a workaround i can split my project, but its a bit akward.

For reference - the topic is currently documented in the README:
https://github.com/gradlex-org/extra-java-module-info#how-do-i-deactivate-the-plugin-functionality-for-a-certain-classpath
As this issue shows, it's quite awkward to use, especially because of the Boolean::class.javaObjectType attribute.
I think the plugin extension could offer an easier DSL/API for this. Something like:
extraJavaModuleInfo {
  deactivateForSourceSet(sourceSets.test)
  deactivateForConfiguration(configurations.annotationProcessor)
  activateForConfiguration(configurations.myOwn)
}


feat: add sleep option

add thread sleep to delay screenshot, make it can shot some dialog
Issue: https://github.com/waycrate/wayshot/issues/62
I think it will be ok

and I want to update the deps also

Superceded by #71 and #72


Deploy as Cloudflare Worker

Currently the rum collector only support deployment to Fastly Compute@Edge.
We should support Cloudflare Workers as a target too. Via hedy we should be able to deploy to either.

Progress... with this command I can manually deploy the rum collector to Cloudflare:
 npx hedy --build --verbose --deploy --target cloudflare --arch node --arch edge --cloudflare-email<EMAIL_ADDRESS>--cloudflare-account-id abc --update-package true --directory /.../temp --entryFile ~/clones/helix-rum-collector/src/index.mjs --cloudflare-auth yyy --name rum-collector --package.name bosschae --externals fastly:logger

I have some, yes.
Do we need any changes in the code other than the endpoint?

@chicharr I don't think there is any other changes needed. Just an endpoint change.

Closing this issue as done. @chicharr if more work is needed just open a new issue 😄


fix URL state when using base href

should be safer than https://github.com/omines/datatables-bundle/pull/29
Using window.location.hash = ... and window.location.search = ... also work but that changing browser history

Yep, this ought to be safe, thanks!


Added new version of chartmuseum

What

Use aws s3 as storage
Use gce as storage
Support Ingress
Support Ingress Annotations
Support Deployment and Replica Annotations

Why

Chartmuseum use aws s3 as backend, nice to have chart support that
Chartmuseum use gce as backend, nice to have chart support that
Ingress useful for host using, access restriction by path
Ingress annotations allow to use kube-lego chart for ssl encryption
Deployment and Replica annotations allow to use kube2iam (kube2iam chart) to provide access to s3

Thank you for contributing to kubernetes/charts. Before you submit this PR we'd like to
make sure you are aware of our technical requirements and best practices:

https://github.com/kubernetes/charts/blob/master/CONTRIBUTING.md#technical-requirements
https://github.com/kubernetes/helm/tree/master/docs/chart_best_practices

For a quick overview across what we will look at reviewing your PR, please read
our review guidelines:

https://github.com/kubernetes/charts/blob/master/REVIEW_GUIDELINES.md

Following our best practices right from the start will accelerate the review process and
help get your PR merged quicker.
When updates to your PR are requested, please add new commits and do not squash the
history. This will make it easier to identify new changes. The PR will be squashed
anyways when it is merged. Thanks.

/assign @viglesiasce

cc: @jdolitsky

/ok-to-test

/ok-to-test

@goruha Can you please sign the CLA. This pull request cannot be merged until that happens. There are details in a previous comment (from a bot) on how to do that.

@mattfarina I am waiting cloudposse would be registered as company there.
Tomorrow should be done

/assign @goruha

CLA signed

@jdolitsky I addressed all comments to PR

@jdolitsky can we merge it?

/approve


Add logic script

Adds boolean logic script: treats ain and din as 2 boolean inputs, outputs AND/OR/XOR/NAND/NOR/XNOR operations on outputs 1-6

Nice work, thanks!


revert "remove code duplication (#648)"

With this change, we need to specify the imports in pyinstaller spec
file, so leave as is.

LGTM!


Scan wifi and display "SUSI Smart speaker" if present

Feature
Scan the neighboring wifi networks and display the ones that have the name of the SUSI Smart Speaker. The name here does not matter, the functionality must be implemented.
Corresponding Android issue: https://github.com/fossasia/susi_android/issues/1420
Would you like to work on the issue?
Yes

Some useful articles:

https://github.com/uxmstudio/LANScanner
https://forums.developer.apple.com/thread/39204
https://github.com/mavris/MMLanScan
https://mobiarch.wordpress.com/2016/11/02/working-with-nehotspothelper/

By research, I found that:
It is NOT possible in iOS to scan all nearby SSID. We can only get currently connected wifi SSID.


Hardware button event listeners not working from hidden webViews

When using event listeners in Android like document.addEventListener("menubutton", myCallbackFn, false); from non active webViews it doesn't work. It works fine however from the current active webView, but it stops working as soon you push or replace with a new layer.

Thanks for the report!

From my POV the logical and right way to manage the listeners is to put them on the drawer webView that is always loaded in background, but this doesn't work right now.

Any updates on this issue?

Hello??


Wrapping and text size in responsive design

Hi, I'd like to thank you first of all for this wonderful plugin. I'm using it a lot now and I think it was very well designed.
I'm currently struggling however with dynamic text wrapping and size in notes. I'm trying to make a chart responsive to the size of it parent. For this I resize and re-position a lot of elements on the window resize event. For my annotations to remain visible I need to change both the wrap length and the font size of the notes.
But the interaction between the wrapping function and the font-size is obscure to me. It seems like it's computing the line height based on the font-size it can find before displaying the annotations (which makes sense). But given that d3.js only allows us to change inline style properties of existing elements, one needs to draw the annotations once to be able to set their font size, before redrawing them with the new wrap length and position.
At least this what I understand at the moment (after several hours trying to figure out a solution, so bear with me if what I wrote doesn't make sense).
Would it be possible to define the font-size in the annotation data instead (in the note, in addition to wrap length) ? This way all dynamic changes are to be made in the annotations' data, and when the annotations are re-draw the note is properly displayed.

Thanks for the feedback. It is computing the line height based on the font-size. I hadn't thought of putting the font-size in the annotation data.
I'll try to put together a small example to test out this case, let me know if you have anything like this put together already that I could use for testing. I'll let you know what conclusions I come to.
Thanks!

I believe this is fixed in the latest version 1.13.0 please let me know if you have any issues with the rendering positioning after upgrading.
Thanks,
Susie

Thanks Susie, I'll give it a try will provide feedback here.

Hi Susie, I'm stuck too and just adjusted my code to work like you suggest, but to no avail.  I can't get my test label to wrap, using wrapSplitter, textWrap, etc.
https://observablehq.com/@pablo-mayrgundter/map-regional-with-click-callback
I'd appreciate any help!  Loving the annotation library :)


fix: inject esm plugin in nuxt environment

There should be no need to inject a CJS plugin as Nuxt will already be transpiling files in .nuxt - and this way, we can be compatible with nuxt-vite 🥳
If you'd like, I can also make this properly esm/pnp compatible by adding exports field in package.json and using require.resolve, but didn't want to conflate the issues.

Hey thanks for the contribution @danielroe!
I haven't used the exports in package.json yet. I'd love to know what's wrong/bad about my current approach and how it can be improved. Feel free to open another PR!


Crash on launch with no Azure tools installed

Environment
Windows build number: 10.0.18362.0
Windows Terminal version (if applicable): Custom build, b84a073

Any other software?

Steps to reproduce

On a system that does not have any Azure tools or components installed, fetch commit b84a073.
Clean and then rebuild the solution
Rename profiles.json to profiles.json.old (not sure if this is important, but when I update to a new build of Terminal I like to start with a completely fresh profiles.json and merge in all my customizations)
Attempt to launch Windows Terminal

Expected behavior
Terminal launches 😄
Actual behavior
Terminal crashes ☹
Ironically, it's crashing while trying to determine whether Azure stuff is in fact installed.  The exact line that's crashing is apparently in a generated file (...\src\cascadia\TerminalApp\lib\Generated Files\winrt\base.h) where it calls WINRT_RoGetActivationFactory and unexpectedly gets ERROR_MOD_NOT_FOUND (0x8007007e).  Going up the stack ultimately leads to this line: https://github.com/microsoft/terminal/blob/0df02343f13059640f57042b8c1d8c113ac4bae5/src/cascadia/TerminalApp/AzureCloudShellGenerator.cpp#L34
Everything further down the stack than that line appears to be in generated code, so I guess it's possible that generation isn't going well. But I would expect the build process I use to pretty much rule that out since it always starts with a completely fresh checkout (no local changes at all) and a complete clean and rebuild of everything.  I have also tried with a completely new, fresh clone (rather than updating an existing clone) with the same results.

This looks suspiciously similar to (bug number where Visual Studio 2019 Update 3 was broken), but that has since been fixed. It’s looking for a DLL that the packaging project has conveniently forgotten to place in the package.
Fortunately, it’s not about having any azure tools installed :)
Can you share some more info about your environment? What VS version are you using, and can you share a Detailed or Diagnostic level build log?

(That was #2625. Sorry, I’m on my phone :))

Thanks for the quick response!  My Visual Studio version is 16.3.0 Preview 1.  I didn't previously realize I was using a preview version, so I guess that might be related.  I can try to switch to a released version and see if that helps.
I've also attached the diagnostic level build log (zipped for file size).  It's in two parts because the build actually doesn't succeed the first time.  When I build from a fresh checkout it builds for a while then errors out with:
Severity	Code	Description	Project	File	Line	Suppression State
Error	MSB3272	There was a problem reading the implementation file "C:\Users\zb\stuff\Terminal\x64\Release\TerminalAppLib\TerminalAppLib.lib". "Unable to read beyond the end of the stream."	LocalTests_TerminalApp	C:\Program Files (x86)\Microsoft Visual Studio\2019\Preview\MSBuild\Current\Bin\Microsoft.Common.CurrentVersion.targets	2106

Starting an incremental build at that point then succeeds.  This has been happening since well before yesterday so I don't think it's the problem, but it might be.
Output-Build.zip

I just had a chance to look at #2625 and yeah, this definitely looks highly similar, although oddly my build does include the fix for that one.

It definitely looks like the same issue from the logs. Have you tried after "preview 1"?

Updating to Preview 4 did indeed fix it. Sorry for the noise 😄


Question regarding tunnels

Okay so theres no way to ask a question without opening another issue here, but I have a question regarding the tunnel you create when you setup your server.
So obviously creating it and using it on one is straight forward, but do you have to create a new one for each new server (lets say I want to create a US server and then a UK one)
Would I be able to use the same tunnel on two servers at once?

nvm I figured out the answer. Yes you do need multiple tunnels


Add more cuSolver APIs for dense linear solver

This PR wraps more cuSolver APIs mainly for dense linear solver.

Jenkins, test this please.

Jenkins CI test (for commit 1b103d1409704bfd2105098e2c893a776a12ebb3, target branch master) succeeded!

Just for completion, any reason to have no <t>potri?

The reason not exposing <t>potri with this PR is that those are relatively new APIs and added in CUDA 10.1.  I will add these version dependent APIs in different PR.

For similar reason, potrfBatched and potrsBatched are not exposed with this PR.

The reason not exposing potri with this PR is that those are relatively new APIs and added in CUDA 10.1. I will add these version dependent APIs in different PR.

That makes sense. Thanks.

Jenkins, test this please.

Jenkins CI test (for commit b288d4cd2e32e152495ee46e4e42f6ee365d1e98, target branch master) failed with status FAILURE.

CI failures because of new NumPy 1.17. Please wait before they will be resolved.

Would you rebase this on the latest master? It should work well with NumPy 1.17.

Jenkins, test this please.

Jenkins CI test (for commit b288d4cd2e32e152495ee46e4e42f6ee365d1e98, target branch master) succeeded!

LGTM!


Update to go 1.17

Description
In order to get smaller binaries, we should upgrade to go 1.17.
ping @moadibfr 😉 check the quote below

go mod download

When go mod download is invoked without arguments, it will no longer save sums for downloaded module content to go.sum. It may still make changes to go.mod and go.sum needed to load the build list. This is the same as the behavior in Go 1.15. To save sums for all modules, use go mod download all.

Things to check:

[ ] We should check if it will work with homebrew

References:

https://twitter.com/kelseyhightower/status/1427400588900241410
https://golang.org/doc/go1.17

What's the homebrew concern?

What's the homebrew concern?

not sure but it might have been about the availability of the go version I think there was some delay with new go version in homebrew at some point ?

Don't we ship a compiled binary to homebrew though, without a brew-dependency on the go package?

Don't we ship a compiled binary to homebrew though, without a brew-dependency on the go package?

Nope, homebrew is building binary on their side. So we should be sure that we can build with go 1.17 on homebrew.

oh, today I learned, thanks! I should have read the packaging properly before making that assumption.

Like many pkg managers, they need to take responsibilities on binary they ship to the world.
Allowing people to send their own binary can lead to potential malicious binaries injected in the repo if you know what I mean.
For example if the snyk supply chain is compromised, brew binaries will not be affected.
I think this is subject to debate, and this is more a question about who you want to trust.
Personally I prefer choose explicitly which GPG key I trust in a granular way than trusting a whole pkg manager that build its binaries in a blackbox.
I like trusting explicitly driftctl release key and then check binary signatures on my device.

From what I understand, the go formula we use to build the binary in Homebrew uses Go 1.17. I guess we can safely upgrade to 1.17 then.


docz failed to parse html tags in component

I have a component that render a <header> tag but when I launch docz I got this
ERROR in ./src/components/SiteHeader/index.js 5:2
Module parse failed: Unexpected token (5:2)
You may need an appropriate loader to handle this file type, currently no loaders are configured to process this file. See https://webpack.js.org/concepts#loaders
|
| const SiteHeader = () => (
>   <header>
|     <Link to="/">Accueil</Link>
|     <Link to="/projects">Projets</Link>
 @ ./docs/SiteHeader.mdx 18:0-54 68:79-89
 @ ./.docz/app/imports.js
 @ ./.docz/app/root.jsx
 @ ./.docz/app/index.jsx
 @ multi ./node_modules/docz-core/node_modules/react-dev-utils/webpackHotDevClient.js ./.docz/app/index.jsx

Can you provide us with your doczrc.js here, thanks!

Here it is
export default {
  src: './docs/',
  files: '*.mdx',
  debug: true,
  ignore: ['node_modules/**/*.js']
};

@sixclones , sorry for the late reply, for some reasons, I didn't get any notifications for this thread. The problem is your config file src. If you look at the doc on the website, it says: src: Define the source folder of your components. Only the files in this folder will be parsed. Every file out of this folder will not be found.. It seems your source files are under ./src, not ./docs


Selecting a model subset (via fetches) leads to NPE when @EntityViewInheritance is involved

I don't have a simple reproducer for this but the situation is roughly following:

EV A contains (possibly deeply nested) a collection of EV B which has @EntityViewInheritance defined
I create an EntityViewSetting with fetches which don't contain the Bs collection
I apply the setting to the CB and fetch resultList

Expected: The query executes ok.
Actual: NPE in https://github.com/Blazebit/blaze-persistence/blob/08793f4ab72cd57762bb6d222ad1fa9421f23e22/entity-view/impl/src/main/java/com/blazebit/persistence/view/impl/objectbuilder/transformator/TupleTransformatorFactory.java#L135
Details: The classMappingIndex not present in the tuple corresponds to a "class type" select expression related to the Bs collection. That's why I think it's related to @EntityViewInheritance

Update: There's a crude fix/workaround https://github.com/Blazebit/blaze-persistence/pull/1723


docs: update README.md

What type of PR is this?
/kind documentation
What this PR does / why we need it:
Update links and references in README.md
Does this PR introduce a user-facing change?:

NONE

/approve


Run analyze job on linux

Improves perf and should avoid file locking issues with Defender.

Why do you think this improves performance? From a quick look at https://dev.azure.com/azure-sdk/public/_build/results?buildId=228621&view=logs&j=b70e5e73-bbb6-5567-0939-8415943fadb9 ran on windows and you run they are both about 5 mins so I'm not sure this improves performance.

Compared to this one PR build, I'm seeing an average difference of ~1min. But perf wasn't the driving motivation here. Reliability was. File locking issues on Windows because of Defender and MSSense are - were, after I worked around so many issues with advice from the Defender suite team - one of the biggest error causes for VS Setup.


jsk_common: 2.2.11-1 in 'melodic/distribution.yaml' [bloom]

Increasing version of package(s) in repository jsk_common to 2.2.11-1:

upstream repository: https://github.com/jsk-ros-pkg/jsk_common
release repository: https://github.com/tork-a/jsk_common-release.git
distro file: melodic/distribution.yaml
bloom version: 0.9.3
previous version for package: 2.2.10-0

dynamic_tf_publisher
* Fix for noetic build (#1648 <https://github.com/jsk-ros-pkg/jsk_common/issues/1648>)

    * fix for python3, except, print ....
    * upgrade package.xml to format=3

* Update package name so it does not produce extra lines in rospack list (#1625 <https://github.com/jsk-ros-pkg/jsk_common/issues/1625>)
* Contributors: J-Rojas, Kei Okada

image_view2
* fix for noetic build (#1648 <https://github.com/jsk-ros-pkg/jsk_common/issues/1648>)

    * fox for opencv4
    * remove signals from find_package(Boost COMPONENTS ...)
    * migrate to noetic with ROS_PYTHON_VERSION=2/3, use multiple ROS distro strategy http://wiki.ros.org/noetic/Migration
    * upgrade package.xml to format=3

* Add sample code for image_view2f( #1646 <https://github.com/jsk-ros-pkg/jsk_common/issues/1646>)
* Contributors: Kei Okada, Naoya Yamaguchi, Shingo Kitagawa

jsk_common
* upgrade package.xml to format=3 for noetic (#1648 <https://github.com/jsk-ros-pkg/jsk_common/issues/1648>)
* Contributors: Kei Okada

jsk_data
* [jsk_data] Add common rosbag_record and play file for fetch (#1611 <https://github.com/jsk-ros-pkg/jsk_common/issues/1611>)

    * enable to give rosbag option to fetch_play.sh like pr2_play.sh
    * add option to launch rqt_bag and rviz in fetch_play.launch
    * [jsk_data/CMakeLists.txt] Add roslaunch_add_file_check for fetch's launch files
    * [jsk_data] Add fetch_play.sh
    * [jsk_data] Add fetch_play and fetch_record.launch

* use xdg-open for ubuntu16.04 and above (#1638 <https://github.com/jsk-ros-pkg/jsk_common/issues/1638>)
* [jsk_data/common_record.launch] Add tf_static recordf( #1641 <https://github.com/jsk-ros-pkg/jsk_common/issues/1641>)
* Fix for noetic build (#1648 <https://github.com/jsk-ros-pkg/jsk_common/issues/1648>)

    * fix for python3, except, print ....
    * pytho3 dislike d in regrex, src/test_topic_published.py:50:37: W605 invalid escape sequence 'd'
    * jsk_data/tests/test_data_collection_server.py use python3 as interpreter

      python code under scripts/ installed with catkin_python_install as http://wiki.ros.org/UsingPython3/SourceCodeChanges, to dynamically change shebangs on install timeThis installs tests/test_data_collection_server.py under CATKIN_PACKAGE_SHARE/tests, which outputs
      ```
      $ rosrun jsk_data test_data_collection_server.py
      [rosrun] You have chosen a non-unique executable, please pick one of the following:
      1) /home/user/devel/share/jsk_data/tests/test_data_collection_server.py
      2) /home/user/src/jsk_common/jsk_data/tests/test_data_collection_server.py
      ```
      we can ignore this message
    * fix jsk_data/src/jsk_data/cli.py:57:44: E741 ambiguous variable name 'l'
    * migrate to noetic with ROS_PYTHON_VERSION=2/3, use multiple ROS distro strategy http://wiki.ros.org/noetic/Migration
    * upgrade package.xml to format=3
    * use distutils.spawn

* Fix download_data.py for Python3f( #1637 <https://github.com/jsk-ros-pkg/jsk_common/issues/1637>)
* [jsk_data] Skip extracting files which already existf( #1626 <https://github.com/jsk-ros-pkg/jsk_common/issues/1626>)

    * Print message when skip extracting
    * Use isinstance() for checking file type
    * Skip extracting files which already exist

* pr2_play.launch: support indigo ( #1620 <https://github.com/jsk-ros-pkg/jsk_common/issues/1620>)
* [download_data.py] generate error log when downloaded fils's md5 is incorrect (#1610 <https://github.com/jsk-ros-pkg/jsk_common/issues/1610>)
* Contributors: Yuki Furuta, Kei Okada, Kentaro Wada, Naoya Yamaguchi, Shingo Kitagawa, Yuto Uchimi, Iori Yanokura

jsk_network_tools
* Fix for noetic buid (#1648 <https://github.com/jsk-ros-pkg/jsk_common/issues/1648>)

    * fix jsk_network_tools for python3
    * jsk_network_tools: set queue_size=1
    * fix for python3, except, print ....
    * upgrade package.xml to format=3

* [network_status.py] add queue_size (#1642 <https://github.com/jsk-ros-pkg/jsk_common/issues/1642>)
* Contributors: Kei Okada, Naoki Hiraoka, Shingo Kitagawa

jsk_tilt_laser
* Fix for noetic build (#1648 <https://github.com/jsk-ros-pkg/jsk_common/issues/1648>)

    * fix for python3, except, print ....
    * upgrade package.xml to format=3

* Contributors: Kei Okada

jsk_tools
* Fix for noetic build (#1648 <https://github.com/jsk-ros-pkg/jsk_common/issues/1648>)

    * fix for python3, except, print ....
    * jsk_tools: fix for python3
    * pytho3 dislike d in regrex, src/test_topic_published.py:50:37: W605 invalid escape sequence 'd'
    * python3 need to use a in dict, instead of dict.has_key(a)
    * fix print(), Exception as e for python3
    * migrate to noetic with ROS_PYTHON_VERSION=2/3, use multiple ROS distro strategy http://wiki.ros.org/noetic/Migration
    * upgrade package.xml to format=3

* fix failure on finally clause (#1645 <https://github.com/jsk-ros-pkg/jsk_common/issues/1645>)
* Add debian in generate_deb_status_table.pyf( #1633 <https://github.com/jsk-ros-pkg/jsk_common/issues/1633>)
* write comment on how to generate deb status section. (#1631 <https://github.com/jsk-ros-pkg/jsk_common/issues/1631>)

    * remove --rosdistro-from and --rosdistro-to, get current active rosdistro list from index file
    * write comment on how to generate deb status section.  https://stackoverflow.com/questions/4823468/comments-in-markdown

* [jsk_tools] Add --ping-trials option to roscore_regardless.py (#1632 <https://github.com/jsk-ros-pkg/jsk_common/issues/1632>)

    * Sometimes ping is not stable. --ping-trials option enables roscore_regardless.py to verify host computer of rosmaster is alive by multi-times ping commands.

* [jsk_tools] Show voltage in battery_capacity_summary.py (#1628 <https://github.com/jsk-ros-pkg/jsk_common/issues/1628>)

    * Fix output format in battery_capacity_summary.py
    * Show voltage as well in battery_capacity_summary.py
    * Show unit of full/remaining capacity in battery_capacity_summary.py

* [jsk_tools/roscore_regardless.py] Do not send SIGTERM before roslaunch sends SIGTERMf( #1627 <https://github.com/jsk-ros-pkg/jsk_common/issues/1627>)

    * Add option to change timeout duration to escalate signals

* [jsk_tools] Add --timeout option to roscore_regardless.py ( #1622 <https://github.com/jsk-ros-pkg/jsk_common/issues/1622>)

    * Add --timeout option to change timeout duration of ping command towards rosmaster computer.
    * --timeout option defaults to 10 seconds.

* battery_capacity_summary.py: fix order of columns (#1619 <https://github.com/jsk-ros-pkg/jsk_common/issues/1619>)
* Contributors: Yuki Furuta, Kei Okada, Ryohei Ueda, Shingo Kitagawa, Yuto Uchimi

jsk_topic_tools
* [jsk_topic_tools] check nodelet version>=1.9.10 (#1647 <https://github.com/jsk-ros-pkg/jsk_common/issues/1647>)
* [jsk_topic_tools/scripts/pose_stamped_publisher.py] fix orientation bug (#1649 <https://github.com/jsk-ros-pkg/jsk_common/issues/1649>)
* Fix for noetic build (#1648 <https://github.com/jsk-ros-pkg/jsk_common/issues/1648>)

    * fix for python3, except, print ....
    * fix print(), Exception as e for python3
    * fox for boost 1.67 (20.04)
    * migrate to noetic with ROS_PYTHON_VERSION=2/3, use multiple ROS distro strategy http://wiki.ros.org/noetic/Migration
    * upgrade package.xml to format=3

* call ros::param::get before set not to overwrite (#1643 <https://github.com/jsk-ros-pkg/jsk_common/issues/1643>)

    * run test_standalone_complexed_nodelet.test
    * add test code for standalone_complexed_nodelet
    * call ros::param::get before set not to overwrite

* [jsk_topic_tools/SynchronizedThrottle] Reset sync policy in destructor (#1640 <https://github.com/jsk-ros-pkg/jsk_common/issues/1640>)
* [jsk_topic_tools] import _pickle as pickle for python3 (#1636 <https://github.com/jsk-ros-pkg/jsk_common/issues/1636>)

    * add comment in log_utils
    * import _pickle as pickle for python3, cpickle is no more used in python3

* add SoundRequest.volume for kinetic (#1635 <https://github.com/jsk-ros-pkg/jsk_common/issues/1635>)
* Create tf.TransformListener before run timerf( #1634 <https://github.com/jsk-ros-pkg/jsk_common/issues/1634>)

    * Assign listener varaible before run timer and the callback in order, not to lookup listener variable before it is assigned.

* [jsk_tools] Add --ping-trials option to roscore_regardless.pyf( #1632 <https://github.com/jsk-ros-pkg/jsk_common/issues/1632>)

    * Sometimes ping is not stable. --ping-trials option enables roscore_regardless.py to verify host computer of rosmaster is alive by multi-times ping commands.

* [deprecated_relay] print warning message only when relayed topic is subscribed (#1624 <https://github.com/jsk-ros-pkg/jsk_common/issues/1624>)

    * print warn only when the msg is subscribed
    * print warn only once in starting

* [jsk_tools] Add --timeout option to roscore_regardless.py (#1622 <https://github.com/jsk-ros-pkg/jsk_common/issues/1622>)
* standalone_complexed_nodelet: add params key for each nodelet (#1614 <https://github.com/jsk-ros-pkg/jsk_common/issues/1614>)

    * Add --timeout option to change timeout duration of ping command towards rosmaster computer.
    * --timeout option defaults to 10 seconds.

* jsk_nodelet: fix overwritting find_package(boost) (#1618 <https://github.com/jsk-ros-pkg/jsk_common/issues/1618>)
* synchronized_throttle: add some more infos (#1615 <https://github.com/jsk-ros-pkg/jsk_common/issues/1615>)
* stealth_relay_nodelet: fix error double free or corruption (fasttop) (#1613 <https://github.com/jsk-ros-pkg/jsk_common/issues/1613>)

    * update standalone_complexed_nodelet sample launch
    * standalone_complexed_ndoelet: support params tag

* Contributors: Furushchev, Kei Okada, Ryo Koyama, Ryohei Ueda, Shingo Kitagawa, Yuki Furuta, Iory Yanokura

multi_map_server
* migrate to noetic with ROS_PYTHON_VERSION=2/3, use multiple ROS distro strategy http://wiki.ros.org/noetic/Migration (#1648 <https://github.com/jsk-ros-pkg/jsk_common/issues/1648>)

    * upgrade package.xml to format=3

* Contributors: Kei Okada

virtual_force_publisher
* upgrade package.xml to format=3 (#1648 <https://github.com/jsk-ros-pkg/jsk_common/issues/1648>)
* Contributors: Kei Okada

@hidmic Some package uses Apache but others uses BSD, so I think is is not appropriate to add the license file to top-level of source repository.
http://wiki.ros.org/jsk_tools?distro=melodic
http://wiki.ros.org/jsk_topic_tools?distro=melodic

@hidmic Some package uses Apache but others uses BSD, so I think is is not appropriate to add the license file to top-level of source repository.

I think you can either add a license file to each package subfolder, or a top level license file listing all the licenses that are used in the repo like here.
You could also split them in a LICENSE.bsd LICENSE.apache, and have an extra LICENSE file explaining which packages are licensed under which license.


[Extensibility Request] local to global Codeunit 5407 "Prod. Order Status Management" - MatrOrCapConsumpExists

Hello, we need the following currently Internal procedure to be set as Global. Can you please check this? Thank you!
[Extensibility Request] Codeunit 5407 "Prod. Order Status Management" - Procedure from Internal to Global
local procedure MatrOrCapConsumpExists(ProdOrderLine: Record "Prod. Order Line") EntriesExist: Boolean
    var
        ItemLedgEntry: Record "Item Ledger Entry";
        CapLedgEntry: Record "Capacity Ledger Entry";
        IsHandled: Boolean;
    begin
        IsHandled := false;
        OnBeforeMatrOrCapConsumpExists(ProdOrderLine, EntriesExist, IsHandled);
        if IsHandled then
            exit(EntriesExist);

        ItemLedgEntry.SetCurrentKey("Order Type", "Order No.", "Order Line No.");
        ItemLedgEntry.SetRange("Order Type", ItemLedgEntry."Order Type"::Production);
        ItemLedgEntry.SetRange("Order No.", ProdOrderLine."Prod. Order No.");
        ItemLedgEntry.SetRange("Order Line No.", ProdOrderLine."Line No.");
        ItemLedgEntry.SetRange("Entry Type", ItemLedgEntry."Entry Type"::Consumption);
        if not ItemLedgEntry.IsEmpty() then
            exit(true);

        CapLedgEntry.SetCurrentKey("Order Type", "Order No.", "Order Line No.", "Routing No.", "Routing Reference No.");
        CapLedgEntry.SetRange("Order Type", CapLedgEntry."Order Type"::Production);
        CapLedgEntry.SetRange("Order No.", ProdOrderLine."Prod. Order No.");
        CapLedgEntry.SetRange("Order Line No.", ProdOrderLine."Line No.");
        CapLedgEntry.SetRange("Routing No.", ProdOrderLine."Routing No.");
        CapLedgEntry.SetRange("Routing Reference No.", ProdOrderLine."Routing Reference No.");
        exit(not CapLedgEntry.IsEmpty);
    end;

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.
Build ID: 40912.


[release-1.3] Make sure aud from SDS JWT is Citadel

This is an automated cherry-pick of #16666

@istio-testing: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-istioctl-k8s-presubmit-tests-release-1.3
5d0fc4bb8e79041a4b28f577da004d4ff05b67e4
link
/test integ-istioctl-k8s-presubmit-tests-release-1.3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test integ-istioctl-k8s-presubmit-tests-release-1.3


0.92.0: compile error

BG: Arch Linux + gcc-d-13.2.1-3  ldc-3:1.34.0-1

Makefile

make
gdc -Wall --release -O -c LexerImpl.d
/usr/lib/gcc/x86_64-pc-linux-gnu/13.2.1/include/d/std/format/internal/write.d:143:13: Error：no property ‘yycode_’ for type ‘Parser.Parser.SymbolKind’
  143 |     U val = obj;    // Extracting alias this may be impure/system/may-throw
      |             ^
/usr/lib/gcc/x86_64-pc-linux-gnu/13.2.1/include/d/std/format/write.d:1239:20: Error：template instance ‘std.format.internal.write.formatValueImpl!(LockingTextWriter, SymbolKind, char)’ error instantiating
 1239 |     formatValueImpl(w, val, f);
      |                    ^
/usr/lib/gcc/x86_64-pc-linux-gnu/13.2.1/include/d/std/format/write.d:632:28: Note：instantiated from here: ‘formatValue!(LockingTextWriter, SymbolKind, char)’
  632 |                 formatValue(w, args[i], spec);
      |                            ^
/usr/lib/gcc/x86_64-pc-linux-gnu/13.2.1/include/d/std/stdio.d:1723:35: 附注：instantiated from here: ‘formattedWrite!(LockingTextWriter, char, SymbolKind)’
 1723 |                     formattedWrite(w, "%s", arg);
      |                                   ^
LexerImpl.d:191:29: Note：instantiated from here: ‘write!(string, SymbolKind)’
  191 |                 stderr.write((i == 0 ? "(EXPECTED " : " OR "), arg[i]);
      |                             ^
/usr/lib/gcc/x86_64-pc-linux-gnu/13.2.1/include/d/std/stdio.d:1769:14: 错误：template instance ‘std.stdio.File.write!(string, SymbolKind, string, char)’ error instantiating
 1769 |         write(args, '\n');
      |              ^
LexerImpl.d:195:23: Note：instantiated from here: ‘writeln!(string, SymbolKind, string)’
  195 |         stderr.writeln(" INSTEAD OF ", lookahead, ")");
      |                       ^
make: *** [Makefile:16：LexerImpl.o] Error 1

Makefile.llvm

/usr/lib/gcc/x86_64-pc-linux-gnu/13.2.1/include/d/std/format/internal/write.d:143:13: Error：no property ‘yycode_’ for type ‘Parser.Parser.SymbolKind’
  143 |     U val = obj;    // Extracting alias this may be impure/system/may-throw
      |             ^
/usr/lib/gcc/x86_64-pc-linux-gnu/13.2.1/include/d/std/format/write.d:1239:20: Error：template instance ‘std.format.internal.write.formatValueImpl!(LockingTextWriter, SymbolKind, char)’ error instantiating
 1239 |     formatValueImpl(w, val, f);
      |                    ^
/usr/lib/gcc/x86_64-pc-linux-gnu/13.2.1/include/d/std/format/write.d:632:28: Note：instantiated from here: ‘formatValue!(LockingTextWriter, SymbolKind, char)’
  632 |                 formatValue(w, args[i], spec);
      |                            ^
/usr/lib/gcc/x86_64-pc-linux-gnu/13.2.1/include/d/std/stdio.d:1723:35: Note：instantiated from here: ‘formattedWrite!(LockingTextWriter, char, SymbolKind)’
 1723 |                     formattedWrite(w, "%s", arg);
      |                                   ^
LexerImpl.d:191:29: Note：instantiated from here: ‘write!(string, SymbolKind)’
  191 |                 stderr.write((i == 0 ? "(EXPECTED " : " OR "), arg[i]);
      |                             ^
/usr/lib/gcc/x86_64-pc-linux-gnu/13.2.1/include/d/std/stdio.d:1769:14: 错误：template instance ‘std.stdio.File.write!(string, SymbolKind, string, char)’ error instantiating
 1769 |         write(args, '\n');
      |              ^
LexerImpl.d:195:23: Note：instantiated from here: ‘writeln!(string, SymbolKind, string)’
  195 |         stderr.writeln(" INSTEAD OF ", lookahead, ")");

I think this is a symptom of not having patched the bison D skeleton file correctly (as per the ReadMe), which affects Parser.d and then shows up when compiling LexerImpl.d.
Please could you try the following, which will omit the bison invocation:
cp -f autogen/Parser.d .
touch Parser.d
make # -f Makefile.llvm

Okay, my fault, thanks. Great Project

I package dbasic on AUR

That's interesting. Currently, the only known bug is the "double free" error described on the 0.92.0 release page. This may be due to a pointer of arrays (DIM L$(50)) not being correctly zeroized due to an optimization, which may itself be solvable using store volatile ... zeroinitializer ... in the LLVM code.
Also, I'm beginning to think that the unused functions of basic_lib.c are not being stripped out of the final executable; this might be enabled by adding dso_local to all of the function prototypes in Target.d. (I'm not particularly knowledgeable about LLVM IR.)
Any other ideas for improvements are always welcome, and I'll keep an eye on your fork.


Some remarks about the file 'about_Plaster_CreatingAManifest.help.md'

LONG DESCRIPTION
"This topic serves to document the existing manifest schema, currently version 0.4, ..."
May be add a link to the .xsd file ?
Metadata
Explain how works the versionning in Plaster: https://github.com/PowerShell/Plaster/issues/89
Parameters
Explain the behavoir of the 'store' parameter.
Typo in "Parameter Type: Text" the last example is wrong :
Enter the version number for the module (1.0.0):
to
Enter the version number for the module (0.1.0):
Content :
"file - Specify one or more files to copy under the destination folder."
Explain the constraint : we can not copy outside the destination folder
note: we must use 'TemplateFile' to preserve the original encoding
       <!-- We must use Encoding attribut : Powershell do not preserve the original encoding -->
    <templateFile source='DirectoriesProject\**'  destination='' encoding='UTF8'/>

"templateFile - Specify one or more template files to copy and expand under the destination folder."
May be add a example here. We must use ' * ' or '**' ?
Content element: XXX
Condition is empty (todo ?)
TODO: Talk about the Plaster parameters.
Explain where $Plaster_xx variables comes from (dynamics parameters).
Explicit note : All variables can be used in a Plaster manifest.
Content element: Modify
"original - The original text, or regular expression match to replace."
Must be escaped the simple text : 'C:\Temp' or 'C:\\Temp' ?
Question : The  '(?s)' option must be allways specified ?
Content element: RequireModule
May be add recommendation ?
See Best practice
7. ALWAYS use three digits for versions (i.e. 5.0.0, not 5.0)

Thanks @LaurentDardenne, I'll continue my docs branch to expand on this feedback and make this about file better.

note: we must use 'TemplateFile' to preserve the original encoding

Interesting. I was under the impression that the existing encoding was preserved if no encoding was specified, but since Plaster is opening and saving the file, I can see how that would happen. Do you know what the default is if you do not specify an encoding? I imagine it would be UTF-8?

Question : The '(?s)' option must be allways specified ?

I'm not sure. I don't think I'm entirely sure how that works, I didn't think it was valid regex, but it appears to match any prefix to your intended match. I'll do some testing to educate myself :).

note: we must use 'TemplateFile' to preserve the original encoding

<file> now preserves the original encoding because it never does anything to the file other than copy it.  <templateFile> was created specifically to address this problem i.e. the only files specified as a <templateFile> are the files that have substitution placeholders that need to be substituted.  For these files we allow the user to specify the encoding the want the written file to use.
The default encoding is Default which for the Set-Content cmdlet is ASCII.  I'm open to changing this but if we do UTF-8 some (Linux) folks will complain that it has a BOM and others would complain it doesn't.  :-)

Must be escaped the simple text : 'C:\Temp' or 'C:\Temp' ?

Yes, you have to escape the backslash because the text represents a regex pattern that will be evaluated against the text of the file.

Question : The '(?s)' option must be allways specified ?

Only use (?[smi]) if you need to override PowerShell's regex default behavior.  (?s) means that . matches every char including \n.  This is how you can write a regex to span multiple lines.

Closed with PR #179.