Nanopolish phase-reads gives segmentation fault on reads basecalled with albacore 2.1.1

Hi Jared,
I'm having an issue with phase-reads. I was getting segfaults in call-methylation on version 0.8.1 when I changed basecallers, and while the methylation calling is now fixed in 0.8.5, I get a reliable segfault every time I run phase-reads.
% nanopolish phase-reads -r albacore_2.1.1.fastq -b albacore_2.1.1.fastq.minimap2.sorted.bam -g GRCm38_68.fa CAST_EiJ.mgp.v5.snps.dbSNP142.vcf > albacore_2.1.1.fastq.phased.sam
3a55009f-2780-4461-b8e0-a3fa5bd924c2 1:3000002-3000734 6
Segmentation fault (core dumped)

Same thing happens with a BAM aligned by either minimap2 or bwa. Error replicates on different flowcells, and on every subdivision of a BAM split into sections of 10,000 reads.
Thanks,
Scott

Can you provide a backtrace from gdb?

Sure thing. Backtrace is below.
(gdb) run
[...]
Program received signal SIGSEGV, Segmentation fault.
0x00000000004a7c17 in profile_hmm_score_r9(HMMInputSequence const&, HMMInputData const&, unsigned int) ()
    at src/hmm/nanopolish_profile_hmm_r9.cpp:31
31          uint32_t n_kmers = sequence.length() - k + 1;
Missing separate debuginfos, use: debuginfo-install glibc-2.12-1.132.el6.x86_64
(gdb) bt
#0  0x00000000004a7c17 in profile_hmm_score_r9(HMMInputSequence const&, HMMInputData const&, unsigned int) ()
    at src/hmm/nanopolish_profile_hmm_r9.cpp:31
#1  0x0000000000468933 in phase_single_read(ReadDB const&, __faidx_t const*, std::vector<Variant, std::allocator<Variant> > const&, htsFile*, bam_hdr_t const*, bam1_t const*, unsigned long, int, int) () at src/nanopolish_phase_reads.cpp:281
#2  0x000000000046f727 in std::_Function_handler<void ()(bam_hdr_t const*, bam1_t const*, unsigned long, int, int), std::_Bind<void (*()(std::reference_wrapper<ReadDB>, std::reference_wrapper<__faidx_t*>, std::reference_wrapper<std::vector<Variant, std::allocator<Variant> > >, htsFile*, std::_Placeholder<1>, std::_Placeholder<2>, std::_Placeholder<3>, std::_Placeholder<4>, std::_Placeholder<5>))(ReadDB const&, __faidx_t const*, std::vector<Variant, std::allocator<Variant> > const&, htsFile*, bam_hdr_t const*, bam1_t const*, unsigned long, int, int)> >::_M_invoke(std::_Any_data const&, bam_hdr_t const*, bam1_t const*, unsigned long, int, int) ()
    at /wehisan/general/system/bioinf-software/bioinfsoftware/gcc/gcc-4.8.2/include/c++/4.8.2/functional:1296
#3  0x00000000004accf0 in BamProcessor::parallel_run ()
    at /wehisan/general/system/bioinf-software/bioinfsoftware/gcc/gcc-4.8.2/include/c++/4.8.2/functional:2464
#4  0x00000000004ad099 in BamProcessor::parallel_run(std::function<void ()(bam_hdr_t const*, bam1_t const*, unsigned long, int, int)>) ()
    at src/common/nanopolish_bam_processor.cpp:101
#5  0x000000000046d344 in phase_reads_main(int, char**) () at src/nanopolish_phase_reads.cpp:380
#6  0x000000000041789a in main () at /wehisan/general/system/bioinf-software/bioinfsoftware/gcc/gcc-4.8.2/include/c++/4.8.2/functional:2464

I can ask sysadmin to install the extra debuginfo if it's helpful.

Could you try do a clean rebuild (make clean && make) just to make sure this isn't a build error?

Same issue again. Also repeats on a different server running CentOS 7 and gcc 6.3.0 (what I showed you was CentOS 6 and gcc 4.8.2).


Moloquent VS laravel-mongodb ( laravel passport )

Hi,
Alright. I'm a little bit confused. I tried to google but with no luck. What is the difference between these two repos having in mind that both are maintained by jenssegers if I'm right?
I'm trying to use laravel passport with MongoDB. Moloquent ( https://github.com/moloquent/moloquent ): there is some provider for such purposes however in this repo there is nothing about it.
Thanks.

The moloquent repository you mentioned is not maintained by me.

Ok, thanks for clarifying things up. Please feel free to close this issue since I was misled. In case anything about passport I will create new one.

Probably makes sense to add Passport support here as well :)

Sure, I'm open for contribution just need some research. :)

@jenssegers any update about the Passport support?

@JoeyHoutenbos I believe there is no possible solution to integrate passport without modifying directly it's own files, since all models are extending elequent. I have forked passport repo and added configuration feature to be able set own models it worked like a charm and I'm using it on my projects without any problems. However my pull request to official repo was rejected. My fork: https://github.com/deividaspetraitis/passport

@deividaspetraitis , this fork has an Service Provider which fixes the problems: https://moloquent.github.io/master/#passport

@deividaspetraitis Can you link me to your PR?

@JoeyHoutenbos well, they just merged passports source with moloquent source since as I mentioned you can't integrate passport with MongoDB without modifying directly it's source.
@jenssegers please see: https://github.com/laravel/passport/pull/306

@deividaspetraitis I see what you mean. Is there any reason not to solve this problem using the method provided by Moloquent?
@jenssegers Would be awesome to have Passport support as soon as possible, so maybe you can help us out?

The main reason why I do not updated this issue is that changes must be made from passport side not from this package.
However in order to add default support of passport I think best way is to follow moloquent approach and include passport source to this package. However you will need to maintain two packages.

@jenssegers what do you think? In case such approach would be considered I could merge my repo and create a pull request.

Any news about this?
Thanks for the hard work, loving laravel-mongodb so far, but now I want to implement passport without altering passport files :/

@deividaspetraitis @Aragami23  you can use this version of repository if you are using laravel 5.3 with v1.0 branch https://github.com/azhard4int/passport/tree/1.0/src

@azhard4int  I would suggest update to laravel 5.4.. I've already fork version with models extending feature implemented here: https://github.com/deividaspetraitis/passport but thanks, maybe for others it will be useful!

@deividaspetraitis would you tell me how use your fork? base on composer document, I couldn't use it. Thanks.

@saman I would suggest to use it as a local package. I should notice that this package is not synchronized with latest repo at the moment but I will try to do that when have some free time.


Support for pushing app to Cloud Foundry Cluster

Original: Proposal: Support pushing app to Cloud Foundry Cluster - Google Groups
Expected Behavior
I think it would be nice to make a type parameter for Cluster Resource as well as Storage Resource.
If the type parameter is not set or set k8s, the cluster type is kubernetes.
If this parameter is set cf, the type is cloud foundry.
Additional Info
We discussed in Proposal: Support pushing app to Cloud Foundry Cluster - Google Groups.
Does this seem like a use case for resource extension rather than something that should be a first-class part of tekton pipelines itself?
https://groups.google.com/d/msg/tekton-dev/TWK5gpBCvBs/Xb-tH1YbFAAJ
I want to try to implement pushing cf app to cf cluster as soon as possible, but the proposal described in the link above is attractive.
So, I can not decide whether to implement ClusterResource for cf or wait for own resource types to become available...

@afrittoli What do you think?

This may be solved by Tekton Pipeline Resource Extensibility - Google Docs.
I'm looking forward to this feature.


az image builder create claims invalid JSON

Describe the bug
when running az image builder create, when passing a template JSON, the CLI always claims that the JSON is invalid.
To Reproduce
az image builder create -g $imageResourceGroup -n $TemplateName --image-template ImageTemplate.json
Same for any JSON - you can for example use this one: https://raw.githubusercontent.com/azure/azvmimagebuilder/master/quickquickstarts/0_Creating_a_Custom_Windows_Managed_Image/helloImageTemplateWin.json
(setting subscription etc. to valid values)
I tried with 10 different files - all same result and all are valid JSON.
Expected behavior
This should lead to the same resource creation as this:
az resource create --resource-group $imageResourceGroup --properties<EMAIL_ADDRESS>--is-full-object `
--resource-type Microsoft.VirtualMachineImages/imageTemplates -n $TemplateName
the az resource command works fine - passing in identical JSON.
Environment summary
az cli 2.25.0 on Windows 10

Compute

The issue is coming from encoding. This command requires ascii encoding whereas az resource create takes any.

@bweissman Yes, I would like to ask what is the specific error message? Is it accurate?

The error message says it's invalid JSON. One might argue if encoding really qualifies as invalid.
Ideally, this command would also accept the same encodings as "az resource create".
Otherwise, it should go to the docs which encoding(s) are supported.

Any update on this?


Replace $ with jQuery for noConflict mode

When jQuery is in noConflict mode, the $ operator can be claimed by other frameworks (ProtoType, MooTools). To avoid JS errors, jQuery plugins should not use $ but jQuery instead.

Hey, thanks for this.
Future versions (i.e. if the project uses other js libs, too) should be based on this.


fix(wrapper): adding support for callbackWaitsForEmptyEventLoop

:tada: This PR is included in version 1.6.3 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


append to table with DATETIME column with generated schema

Steps to reproduce

Create a table with a DATETIME (not TIMESTAMP) column outside of pandas(-gbq).
Attempt to append a dataframe with datetime data to that table.

Code example
import datetime

import google.cloud.bigquery
import pandas
import pandas_gbq

destination = "swast-scratch.my_dataset.pandas_datetime_20211222"
bqclient = google.cloud.bigquery.Client()
table = google.cloud.bigquery.Table(
    destination,
    schema=[
        google.cloud.bigquery.SchemaField("row_num", "INTEGER"),
        google.cloud.bigquery.SchemaField("some_datetime", "DATETIME"),
    ]
)
table.expires = (
    datetime.datetime.now(tz=datetime.timezone.utc)
    + datetime.timedelta(days=1)
)
bqclient.create_table(table, exists_ok=True)

df = pandas.DataFrame(
    {
        "row_num": [1, 2, 3],
        "some_datetime": [
            datetime.datetime(2021, 12, 22, 10, 11, 12),
            datetime.datetime(2011, 11, 11, 10, 11, 12),
            datetime.datetime(2000, 1, 2, 3, 4, 5),
        ]
    }
)
pandas_gbq.to_gbq(df, destination, if_exists="append")

Stack trace
(dev-3.9) ➜  scratch python 2021/12-pandas-gbq-datetime/upload_datetime.py
Traceback (most recent call last):
  File "/Users/swast/src/scratch/2021/12-pandas-gbq-datetime/upload_datetime.py", line 33, in <module>
    pandas_gbq.to_gbq(df, destination, if_exists="append")
  File "/Users/swast/src/github.com/googleapis/python-bigquery-pandas/pandas_gbq/gbq.py", line 1129, in to_gbq
    raise InvalidSchema(
pandas_gbq.gbq.InvalidSchema: Please verify that the structure and data types in the DataFrame match the schema of the destination table.

Currently, this failure happens locally due to generated schema != server-side schema. Even without that client-side check, I think this failure could still happen with api_method="load_csv", as it also uses the generated schema if one is not provided.

Actually, there is a workaround. The user can manually specify a schema if they want DATETIME instead of TIMESTAMP.
...
pandas_gbq.to_gbq(
    df,
    destination,
    if_exists="append",
    table_schema=[
        {"name": "row_num", "type": "INTEGER"},
        {"name": "some_datetime", "type": "DATETIME"},
    ]
)

I might change this to a Feature Request, as I believe this is a known way of dealing with the ambiguity between TIMESTAMP and DATETIME.

+1 for DateTime support instead of just Timestamp. Currently all my DateTime columns are being uploaded as Timestamps with the to_gbq function unless I specify the column is of type 'DATETIME' with the table_schema argument.

This should be working now with pandas datetime64 dtypes by looking for a timezone. If a timezone is present, use TIMESTAMP, otherwise use DATETIME.
Still needs a follow-up to do the same for ArrowDtype (needed for bigframes).


Issue@1773

Changed the rounded amounts on expenses email to their actual amounts as requested in #1773

Thanks for contributing @Gbahdeyboh! We usually don't commit the package-lock.json if the PR doesn't change any dependency.
Also can you change the title of the PR to have something more accurate?
Thanks!

Thanks for the feedback, i made a new PR that i think resolves the monetary amounts being rounded issue.
https://github.com/opencollective/opencollective-api/pull/2392
Please kindly review.

Closing in favor of https://github.com/opencollective/opencollective-api/pull/2392


"Attempting to add already-known thread" constantly occurs when debugging multi-threaded python app

[severity:I’m unable to use this version]
Occurs randomly while debugging. When it occurs, debugging session is terminated and the task is killed. Seen 50+ times. No known way to get around.
Doesn’t need to be paused to reproduce, however single stepping seems to make the bug much more likely to occur.
Simplest way to reproduce is basic multithreading code such as:
def NextTask(...):
        def WorkerThread(pOpen, stdin):
            if stdin is not None:
                stdin = stdin.encode("utf-8")

            (o, e) = pOpen.communicate(stdin)

            if o is not None:
                self.outputstdOut = o.decode("utf-8")
            if e is not None:
                self.outputstdErr = e.decode("utf-8")

            if self.outputLock.locked():  # In case we timed out...
                self.outputLock.release()

        t = Thread(target=WorkerThread, args=(pOpen, stdIn))

        self.bgThread = t

        t.start()```

RunDebuggerToThisLine()
StartPressingF10()
NextTask(subprocess.POpen(...),...))
GoodLuckEverGettingHere()```

Associated work item: https://dev.azure.com/devdiv/DevDiv/_workitems/edit/1752703

Would it be possible to get a self-contained repro? It's not clear to me what all the ... are supposed to be in the snippet above.
Also, is this by chance remotely debugging code that is running on Linux or macOS?


Create InsertIgnore

i think thats missing :)

I am thinking if this is too MySQL specific and too small of a change to warrant a new class. What will happen when I try to run this on PostgreSQL or any of the other adapters this library is supposed to support? For things like Sequence which is database specific, that goes into a Feature namespace, which augments standard SQL. Then, if a generic command has multiple ways of doing it across engines, there is a driver specific override. Currently, this solution falls into neither. I just have to know InsertIgnore is bad in anything other than MySQL. Which is a reasonable assumption - I would not think of it unless I knew the engine. However, this is still pretty generic, and modification is small enough to an already mostly existing feature that perhaps its more useful to make into an API property.
$insert = new Insert();
$insert->ignoreDuplicate(true);
Then, this can be done at any engine level without knowledge of exactly what needs to be done, descriptive, and easy to document. IgnoreDuplicate can adjust specification based on true/false. In MySQL it would be as easy str_replac-ing after INSERT (then I can come around to do other engines later), and unit test will be easy to add too.


Doesnt automatically closing Bracket and Quote

This is a little bit strange, only in .mcfunction, the closing bracket and quote don't close automatically. I'm using the latest version of visual studio code and the extension. I'm also already try to set the "Automatic closing brackets" and "Automatic closing quotes" to always

This has been reported before in #16, but we couldn't reproduce it. Could you please make sure that the language is set to mcfunction in the bottom-right corner of your VS Code when opening a mcfunction file?

Oh. It works again. I didn't do anything except downloading the syntax highlighting.

This happened to me today, and it was fixed after I disabled and re-enabled the extension several times. At some point, the extension created a .datapack folder I had never seen before in my project. So I think this problem is related to the extension failing to create the .datapack folder and therefore not loading properly.


Fix disks output.

Running iohyve disks guestname  will return the disks and how much the zvol takes up with snapshots and all, instead of using the volsize property.

Closing thanks to @skarekrow


Make 5 test sets with 50% random samples of Fan ∩ Norris

Since we are doing random sampling (without replacement), I suggest using a bigger proportion. 50%.

For @MatthewJA education:
http://sebastianraschka.com/blog/2016/model-evaluation-selection-part2.html

Done; do you want me to put the test set data somewhere so we're all on the same page or are you happy to generate it if you need it?

@jbanfield needs to decide this. For the publication, it is probably useful to have a file with indices that we can add as an appendix.

Okay. We should probably have some procedure for storing all of the data used somewhere so that results are easily reproducible.


KAFKA-17520: backport Align ducktape version in tests/docker/Dockerfile and tests/setup.py to 3.9 branch

Jira: https://issues.apache.org/jira/browse/KAFKA-17520
I run e2e on 3.9 branch, is has error about ModuleNotFoundError: No module named psutil
That ducktape 0.12 is released (https://github.com/confluentinc/ducktape/releases/tag/v0.12.0), and it requires psutil now (https://github.com/confluentinc/ducktape/commit/33447b6e3a867deec6c5835631d1b1d22d3fea21)
So we should backport KAFKA-17520 to 3.9
After fix it I can run e2e test in my local on branch 3.9

Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

@m1a2st Could you please revise the title? this is a backport of #17240

I modify the title to backport to 3.9 branch

@m1a2st could you please file PR for 3.8 also? 3.9 is in RC so we need to wait @cmccabe to take a look.

@chia7712, I will file PR to 3.8 and 3.7 as this comments

It does seem quite bad that we had the version "floating" for so long. I suppose this will make a lot of older Apache Kafka releases non-reproducible (at least in theory, I don't know how much has changed in ducktape recently.)
I think we should also change the Dockerfile to use requirements.txt... perhaps by creating a virtualenv. It makes more sense to do that in a follow-up PR, though.

I think we should also change the Dockerfile to use requirements.txt... perhaps by creating a virtualenv. It makes more sense to do that in a follow-up PR, though.

open https://issues.apache.org/jira/browse/KAFKA-17791 to trace it.


Restored workflow_call trigger to fix relrease workflow

#580  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @CatChen and the rest of your teammates on  Graphite


[WIP] builder experiment: make all soma_joinid start from 1

Closing this since it's fortunately not needed, but, the code diff may be of future interest


Get tagUID and writeData at the same time

How could i get tagUID and write data at the same time ?

Hi @moweex-mobile , sorry for the late response.
Please use latest v2.1.2 with following sample code:
import NfcManager, {NfcTech, Ndef} from 'react-native-nfc-manager';

...

if (Platform.OS === 'ios') {
  // NOTICE: iOS won't give us UID when using Ndef tech
  await NfcManager.requestTechnology([NfcTech.MifareIOS, NfcTech.Iso15693IOS, NfcTech.IsoDep]);
} else {
  NfcAndroidUI.emit('OPEN');
  await NfcManager.requestTechnology(NfcTech.Ndef);
}

const tag = await NfcManager.getTag();
console.warn('tag', tag); // tag.id is the UID

let bytes = Ndef.encodeMessage([
  Ndef.textRecord(value),
]);
await NfcManager.writeNdefMessage(bytes);

...

Thanks!

Thanks


Error while using Nivo charts into ipyreact components

I just found ipyreact and I love the idea, thanks!
However, I want to create widgets with the popular react charting library,  Nivo, so I just picked up the first bar chart example:
%%react -n my_widget -d
import * as React from "react";
import ReactDom from 'react-dom'
import ReactIs from 'react-is'
import Nivo from '@nivo/core'
import {ResponsiveBar} from '@nivo/bar'

// make sure parent container have a defined height when using
// responsive component, otherwise height will be 0 and
// no chart will be rendered.
// website examples showcase many properties,
// you'll often use just a few of them.
export default function BarChart({   /* see data tab */}) {

  return (
    <div style={{height: '500px'}} >
        <ResponsiveBar
          data={data}
          keys={[
            'hot dog',
            'burger',
            'sandwich',
            'kebab',
            'fries',
            'donut'
          ]}
          indexBy="country"
          margin={{top: 50, right: 130, bottom: 50, left: 60}}
          padding={0.3}
          valueScale={{type: 'linear'}}
          indexScale={{type: 'band', round: true}}
          colors={{scheme: 'nivo'}}
          defs={[
            {
              id: 'dots',
              type: 'patternDots',
              background: 'inherit',
              color: '#38bcb2',
              size: 4,
              padding: 1,
              stagger: true
            },
            {
              id: 'lines',
              type: 'patternLines',
              background: 'inherit',
              color: '#eed312',
              rotation: -45,
              lineWidth: 6,
              spacing: 10
            }
          ]}
          fill={[
            {
              match: {
                id: 'fries'
              },
              id: 'dots'
            },
            {
              match: {
                id: 'sandwich'
              },
              id: 'lines'
            }
          ]}
          borderColor={{
            from: 'color',
            modifiers: [
              [
                'darker',
                1.6
              ]
            ]
          }}
          axisTop={null}
          axisRight={null}
          axisBottom={{
            tickSize: 5,
            tickPadding: 5,
            tickRotation: 0,
            legend: 'country',
            legendPosition: 'middle',
            legendOffset: 32
          }}
          axisLeft={{
            tickSize: 5,
            tickPadding: 5,
            tickRotation: 0,
            legend: 'food',
            legendPosition: 'middle',
            legendOffset: -40
          }}
          labelSkipWidth={12}
          labelSkipHeight={12}
          labelTextColor={{
            from: 'color',
            modifiers: [
              [
                'darker',
                1.6
              ]
            ]
          }}
          legends={[
            {
              dataFrom: 'keys',
              anchor: 'bottom-right',
              direction: 'column',
              justify: false,
              translateX: 120,
              translateY: 0,
              itemsSpacing: 2,
              itemWidth: 100,
              itemHeight: 20,
              itemDirection: 'left-to-right',
              itemOpacity: 0.85,
              symbolSize: 20,
              effects: [
                {
                  on: 'hover',
                  style: {
                    itemOpacity: 1
                  }
                }
              ]
            }
          ]}
          role="application"
          ariaLabel="Nivo bar chart demo"
          barAriaLabel={e => e.id + ": " + e.formattedValue + " in country: " + e.indexValue}
        />
  </div>
  )
}

const data = [
  {
    "country": "AD",
    "hot dog": 115,
    "hot dogColor": "hsl(168, 70%, 50%)",
    "burger": 127,
    "burgerColor": "hsl(214, 70%, 50%)",
    "sandwich": 36,
    "sandwichColor": "hsl(291, 70%, 50%)",
    "kebab": 47,
    "kebabColor": "hsl(43, 70%, 50%)",
    "fries": 37,
    "friesColor": "hsl(79, 70%, 50%)",
    "donut": 95,
    "donutColor": "hsl(229, 70%, 50%)"
  },
  {
    "country": "AE",
    "hot dog": 104,
    "hot dogColor": "hsl(237, 70%, 50%)",
    "burger": 65,
    "burgerColor": "hsl(335, 70%, 50%)",
    "sandwich": 63,
    "sandwichColor": "hsl(316, 70%, 50%)",
    "kebab": 9,
    "kebabColor": "hsl(353, 70%, 50%)",
    "fries": 118,
    "friesColor": "hsl(49, 70%, 50%)",
    "donut": 184,
    "donutColor": "hsl(350, 70%, 50%)"
  },
  {
    "country": "AF",
    "hot dog": 24,
    "hot dogColor": "hsl(209, 70%, 50%)",
    "burger": 137,
    "burgerColor": "hsl(143, 70%, 50%)",
    "sandwich": 145,
    "sandwichColor": "hsl(349, 70%, 50%)",
    "kebab": 107,
    "kebabColor": "hsl(256, 70%, 50%)",
    "fries": 195,
    "friesColor": "hsl(9, 70%, 50%)",
    "donut": 106,
    "donutColor": "hsl(292, 70%, 50%)"
  },
  {
    "country": "AG",
    "hot dog": 64,
    "hot dogColor": "hsl(93, 70%, 50%)",
    "burger": 119,
    "burgerColor": "hsl(255, 70%, 50%)",
    "sandwich": 102,
    "sandwichColor": "hsl(37, 70%, 50%)",
    "kebab": 168,
    "kebabColor": "hsl(154, 70%, 50%)",
    "fries": 72,
    "friesColor": "hsl(326, 70%, 50%)",
    "donut": 143,
    "donutColor": "hsl(107, 70%, 50%)"
  },
  {
    "country": "AI",
    "hot dog": 66,
    "hot dogColor": "hsl(26, 70%, 50%)",
    "burger": 135,
    "burgerColor": "hsl(41, 70%, 50%)",
    "sandwich": 178,
    "sandwichColor": "hsl(95, 70%, 50%)",
    "kebab": 139,
    "kebabColor": "hsl(132, 70%, 50%)",
    "fries": 61,
    "friesColor": "hsl(121, 70%, 50%)",
    "donut": 150,
    "donutColor": "hsl(118, 70%, 50%)"
  },
  {
    "country": "AL",
    "hot dog": 100,
    "hot dogColor": "hsl(65, 70%, 50%)",
    "burger": 2,
    "burgerColor": "hsl(287, 70%, 50%)",
    "sandwich": 106,
    "sandwichColor": "hsl(101, 70%, 50%)",
    "kebab": 81,
    "kebabColor": "hsl(7, 70%, 50%)",
    "fries": 36,
    "friesColor": "hsl(246, 70%, 50%)",
    "donut": 97,
    "donutColor": "hsl(75, 70%, 50%)"
  },
  {
    "country": "AM",
    "hot dog": 118,
    "hot dogColor": "hsl(151, 70%, 50%)",
    "burger": 64,
    "burgerColor": "hsl(119, 70%, 50%)",
    "sandwich": 158,
    "sandwichColor": "hsl(118, 70%, 50%)",
    "kebab": 105,
    "kebabColor": "hsl(141, 70%, 50%)",
    "fries": 14,
    "friesColor": "hsl(13, 70%, 50%)",
    "donut": 92,
    "donutColor": "hsl(235, 70%, 50%)"
  }
]

But I am getting an error inside my Jupyter Notebook:
The requested module 'blob:http://localhost:8889/25266369-4067-4a11-a49e-2fcfd1acf21c' does not provide an export named 'isString'
I'm currently using Nivo charts in React/Nextjs applications and would greatly appreciate assistance in integrating them with ipyreact as well. Thank you!

Thanks you!
Hmm, I could give you some hints. If you search the network tab for that blob, you can see that it belongs to lodash. Maybe if you make a smaller example that uses lodash, and see if you can find if there maybe is an issue with lodash and the CDN that is being used https://github.com/esm-dev/esm.sh
I hope that helps you debug this!

So the problem is Nivo doesn't support ESM yet because of a lack of interest. I tried to create my own bundled module with Rollup to publish as a separate ESM, but I got the same error during the build. Later, I will try to make one from the source code, but until then, I will close this issue.

I’m ok with supporting different bundles, what would you propose, umd?


Fix and reenable NewArray.swift.gyb

@swift-ci Please test

Build failed
Swift Test OS X Platform
Git Sha - ab280f4a5fb5c38c7cc199213e101500666a3f74

Build failed
Swift Test Linux Platform
Git Sha - ab280f4a5fb5c38c7cc199213e101500666a3f74

@swift-ci Please test

Build failed
Swift Test Linux Platform
Git Sha - ab280f4a5fb5c38c7cc199213e101500666a3f74

Build failed
Swift Test OS X Platform
Git Sha - ab280f4a5fb5c38c7cc199213e101500666a3f74

@swift-ci Please test Windows

Tagging @airspeedswift because they disabled this originally.

@swift-ci Please test Windows

⛵


feat: custom tag key

PyTorch and PaddlePaddle tuners should also accept this argument, I think the Evaluator too

Thanks. I will add it.

BTW, a preprocess function could also be applied to do this job.
def preprocess(doc: Document)
    doc.tags['finetuner_tag'] = doc.tags['custom_tag']
    return doc

@florian-hoenicke let's develop new features in finetuner.fit

Okay, I'll move the pr


Implement Login Page(WIP)

Changes

Add checkbox module(CheckBox.elm)
Change login page design(same with example design)
Add index.css

Modularization of basic components like checkbox and textbox, is unnecessary.

The detail attributes of components in other pages may differ from the modular one.
(ex-placeholder, id, class, ...)
So it does not reduce the lines of code.

Modularizing case by case is more proper.
(ex-usernameField : (sth) -> Html Msg, passwordField : (sth) -> Html Msg)

Rejected by #54


Use case for Notifications

Notifications could be useful for event based actions for OneView environment.  What are our use cases for it?   Shall we start by implementing the ability to read the notifications.

Hi @wenlock,
Code support for this fix is provided and will be available from next release.


Migrating AWS S3 SDK to v2

As reported at https://github.com/slackapi/java-slack-sdk/pull/1168#pullrequestreview-2474523299, our optional dependency AWS S3 client SDK must be migraded to its v2 by the end of 2025.
Both groupId and artifactId are different:
-            <groupId>com.amazonaws</groupId>
-            <artifactId>aws-java-sdk-s3</artifactId>
+            <groupId>software.amazon.awssdk</groupId>
+            <artifactId>s3</artifactId>

Here is a version range example:
-        <aws.s3.version>[1.12.62,1.13.0)</aws.s3.version>
+        <aws.s3.version>[2.29.24,3)</aws.s3.version>

V2 is fully source-code incompatible, so this work requires rewriting the modules relying on the AWS SDK plus testing the behavior is still the same. It seems there is no need to migrate "aws-lambda-java-core" to something new this time.
See also:

https://docs.aws.amazon.com/sdk-for-java/latest/developer-guide/migration.html
https://docs.aws.amazon.com/sdk-for-java/latest/developer-guide/migration-service-changes.html
https://docs.aws.amazon.com/sdk-for-java/latest/developer-guide/migration-client-credentials.html
https://docs.aws.amazon.com/lambda/latest/dg/lambda-java.html

We may want to try the migration tool if it works well for us:

https://docs.aws.amazon.com/sdk-for-java/latest/developer-guide/migration-tool.html

Category (place an x in each of the [ ])

[x] bolt (Bolt for Java)
[x] bolt-{sub modules} (Bolt for Java - optional modules)
[ ] slack-api-client (Slack API Clients)
[ ] slack-api-model (Slack API Data Models)
[ ] slack-api-*-kotlin-extension (Kotlin Extensions for Slack API Clients)
[ ] slack-app-backend (The primitive layer of Bolt for Java)

Requirements
Please make sure if this topic is specific to this SDK. For general questions/issues about Slack API platform or its server-side, could you submit questions at https://my.slack.com/help/requests/new instead. :bow:
Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you agree to those rules.

So to change only dependicies or other code also

Thanks for your interest! but I started working on this. Hope we can work together for future tasks

Current Limitations of Migration Tools: https://docs.aws.amazon.com/sdk-for-java/latest/developer-guide/migration-tool.html#migration-tool-limitations


Validation errors

Hi!
Is there any way to get information about validation errors from the API? Right now, I'm just receiving a 422 error when trying to add a debit to a customer, with no further explanation:
Besepa::Customer.find(id).add_debit("XXXXXXX", "XXXXXX", "My description", 10000, "2014-05-10", nil, nil)
# => Besepa::Errors::InvalidResourceError: (Status 422) invalid_resource (El recurso no se puedo guardar porque falló alguna de las validaciones)

Both customer and bank_account exist.
Thanks!

Well, I think I solved it: there is a validation for collect_at date being greater than today.
Anyway, I think a more verbose error would be a nice to have.


Opencensus support in go-redis with a wrapper

Is your feature request related to a problem? Please describe.
Currently there is a fork of https://github.com/go-redis/redis with opencensus integration in https://github.com/opencensus-integrations/redis. However, this fork has not seen activity in several months, and is already some versions behind the upstream version.
The nature of the changes also make it unlikely that they will be merged upstream. I've tried backporting the new stuff but there are several conflicts and it looks like an uphill battle.
Describe the solution you'd like
I think the best way to support the go-redis driver is with a wrapper around it's interface. Are there plans to do this?

@edevil thank you filing this issue!
Unfortunately OpenCensus Go isn't for integrations and I got feedback from various folks that the better direction is to make a wrapper instead as you've noticed. We just need to find the time to work on it. If you'd like, we can collaborate it and I can help with code review, otherwise yes I plan on rolling a wrapper out but I just have a lot currently on my backlog.
I'll close this issue since that's an issue for a different repo but let's keep the conversation active on that repo or via email and collaboration.

@edevil now I recall I actually worked on a wrapper about 8 months ago as recommended by goredis/redis in https://github.com/orijtech/go-opencensus-integrations/blob/da8b4420d3d3e41250e3dc1d87cf5449d6af1670/ocredis/example_test.go#L40-L103
func Example_NewClient() {
	// Just some pre-requisites to demo the interaction
	// between OpenCensus and the integration.
	trace.ApplyConfig(trace.Config{DefaultSampler: trace.AlwaysSample()})
	trace.RegisterExporter(pe)
	defer trace.UnregisterExporter(pe)

	// Create and use the client
	client := ocredis.NewClient(context.Background(), ":6379")
	if _, err := client.HSet("programs", "space", 1961).Result(); err != nil {
		log.Fatalf("HSet error: %v", err)
	}
}

or
func Example_PerCommandTracer() {
	// Just some pre-requisites to demo the interaction
	// between OpenCensus and the integration.
	trace.ApplyConfig(trace.Config{DefaultSampler: trace.AlwaysSample()})
	trace.RegisterExporter(pe)
	defer trace.UnregisterExporter(pe)

	client := redis.NewClient(&redis.Options{Addr: ":6379"})
	client.WrapProcess(ocredis.PerCommandTracer(context.Background()))
	_, err := client.HMSet("names", map[string]interface{}{
		"space": 1961, "tracing": "OpenCensus",
		"monitoring": "OpenCensus",
	}).Result()
	if err != nil {
		log.Fatalf("Failed to HMSet: %v", err)
	}
}

which provides the wrapper -- so basically this is already implemented.
However, I personally found that I couldn't get annotations from it hence went to the full instrumentation.

@odeke-em Got it. But which is the correct repo to discuss this?

@edevil I just commented as you were typing that we actually have what you are looking for, the implemented wrapper https://github.com/orijtech/go-opencensus-integrations/tree/master/ocredis :)

Thanks!

@odeke-em The downside of using WrapProcess() is that you cannot pass a context per-command, right? In situations in which you have a shared long-lived redis client that you use multiple times while servicing a request it is not possible to attach the spans to the request's context.

@odeke-em A middle-ground that I found was to use the WrapProcess() approach you showed and then create a copy of the redis client per-request:
func WrapClient(ctx context.Context, origClient *redis.Client) *redis.Client {
	client := origClient.WithContext(ctx)
	client.WrapProcess(PerCommandTracer(client.Context()))
	return client
}

	client := common.WrapClient(ctx, genericRedisClient)
	result, err := client.Get(key).Result()

@edevil nice! Could you please file an issue or send a PR to https://github.com/orijtech/go-opencensus-integrations. I am currently doing a retouch to ensure that we don't encounter any problems of discovery but also ensure everyone can use them easily.


[FEATURE] Environment variable check on mac installation having DOCKER_HOST set

I was just installing Docker on my Mac and had some trouble connecting to the daemon.
(Everything is solved now)
It would be a great feature if the installer checked whether the DOCKER_HOST env variable is set to something that would make docker unable to connect to the new local docker environment - at least a notice would be great.

I think this will be hard to do, because having an environment variable set could be a valid configuration (for example, I have docker for Mac installed locally, but sometimes connect to a remote daemon)
Anyway, can you post this issue in the Docker for Mac beta forums? Docker for Mac, is a separate project, and doesn't use this issue tracker
https://forums.docker.com/c/docker-for-mac


Add workflow to publish pypi package

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (2775e88) to head (1c6c658).

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #78   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files           55        55
  Lines         1130      1130
  Branches        85        85
=========================================
  Hits          1130      1130

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


[DO NOT MERGE][azure-template-cpp, azure-template2-cpp] Validating vcpkg release automation 2

[azure-template-cpp] Update to 1.0.0-beta.28
This PR demonstrates releasing 2 packages to the same PR. Except for an issue with log4cpp (link) (an unrelated package) in CI, the ports pass CI.
Additionally pulling locally from https://github.com/azure-sdk/vcpkg/tree/djurek-test-vcpkg-multi-release-12, bootstrapping vcpkg, and building the ports succeeds.
CI for vcpkg: https://dev.azure.com/vcpkg/public/_build/results?buildId=49217&view=results

Is there someone on the vcpkg team that can help us with the CI issue?
We're seeing the following failure for log4cpp which is not related to any of the publishing automation work we're doing in the Azure SDK.
...
OK: b592e9dd5ab7aa6c1b46e0d23e0d31093edd73ca	zstd -> 1.4.5#1
OK: 9e180d152b886a9b45cc03c36fadaee8968d79d1	zstr -> 1.0.4
OK: d7761651d4c426d0322f52d5508b5beb66af6c9d	zxing-cpp -> 3.3.3#8
OK: a27e395ffb6b0c8329228b3df9c3af8fd19c1b44	zydis -> 3.1.0-1
OK: b3300f003099d2e0597453a90fa1df903b6b5c56	zyre -> 2019-07-07-1
OK: 7cdcdf231074be830e74ba4c498b9b34ba50b94a	zziplib -> 0.13.71#1
Found the following errors:
Error: While reading versions for port log4cpp from file: C:\a\1\s\versions\l-\log4cpp.json
       Version `2.9.1#4` was not found in versions file.
       Run:

           vcpkg x-add-version log4cpp

       to add the new port version.

@BillyONeal, @ras0219-msft can you please help us understand and work around the issue we are seeing. Thanks!

/azp run

There was a bad merge to master which has since been fixed; sorry for the inconvenience!


graceful_controller: 0.4.7-1 in 'noetic/distribution.yaml' [bloom]

Increasing version of package(s) in repository graceful_controller to 0.4.7-1:

upstream repository: https://github.com/mikeferguson/graceful_controller.git
release repository: https://github.com/mikeferguson/graceful_controller-gbp.git
distro file: noetic/distribution.yaml
bloom version: 0.11.2
previous version for package: 0.4.6-1

graceful_controller

No changes

graceful_controller_ros
* generate linear movements if final in-place rotation is infeasible (#67 <https://github.com/mikeferguson/graceful_controller/issues/67>)
* Contributors: Michael Ferguson

Holding for Noetic sync


Solve errors for angular 1.4 in layercontrol

This changes improve the performance in layercontrol
Layer Control example:
http://tombatossals.github.io/angular-leaflet-directive/examples/0000-viewer.html#/controls/custom-layer-control-example

LGTM


Branch update test parser

Update Test in QuickCacheParser that is forgotten.

Codecov Report

Merging #87 into master will increase coverage by 0.23%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master      #87      +/-   ##
============================================
+ Coverage     54.07%   54.31%   +0.23%
- Complexity      396      399       +3
============================================
  Files            86       86
  Lines          1716     1716
  Branches        197      197
============================================
+ Hits            928      932       +4
+ Misses          708      704       -4
  Partials         80       80

Impacted Files
Coverage Δ
Complexity Δ

...java/quickcache/logic/parser/QuickCacheParser.java
66.66% <0.00%> (+4.76%)
10.00% <0.00%> (+1.00%)

...ava/quickcache/logic/parser/EditCommandParser.java
78.12% <0.00%> (+6.25%)
8.00% <0.00%> (+1.00%)

src/main/java/quickcache/model/flashcard/Tag.java
72.72% <0.00%> (+9.09%)
5.00% <0.00%> (+1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 38b518c...b459a32. Read the comment docs.


check data aggregation across regions

Add a function to check whether the 'World' timeseries data is equal to the timeseries data of all regions.

solved by #88

closing as implemented


Enable-RemoteDesktop - Add RDP NLA Switch

RDP NLA (Network Level Authentication)  Switch Added as this was blocking RDP access when left enabled and no NLA configured.

Besides the comment above, this is great to have.

thanks a bunch! FYI: I ended up changing the name of the parameter and made it a switch


"build\host\outputs\apk\app-debug.apk" does not exist

Thanks for the feedback! If your issue is related to the Flutter framework itself,
please open an issue at
github.com/flutter/flutter.
Steps to Reproduce
after upgrade flutter to 3.7.0,
I can run a flutter application successfully,
but while running a flutter module project, i got the error :
√  Built build\host\outputs\apk\debug\app-debug.apk.
"build\host\outputs\apk\app-debug.apk" does not exist.
Error launching application on sdk gphone64 x86 64.
Version info
Doctor summary (to see all details, run flutter doctor -v):
[✓] Flutter (Channel stable, 3.7.1, on Microsoft Windows [Version 10.0.22000.1455], locale zh-CN)
[✓] Windows Version (Installed version of Windows is version 10 or higher)
[✓] Android toolchain - develop for Android devices (Android SDK version 33.0.1)
[✓] Chrome - develop for the web
[✗] Visual Studio - develop for Windows
✗ Visual Studio not installed; this is necessary for Windows development.
Download at https://visualstudio.microsoft.com/downloads/.
Please install the "Desktop development with C++" workload, including all of its default components
[✓] Android Studio (version 2022.1)
[✓] Connected device (4 available)
[✓] HTTP Host Availability
flutter plugin version: 72.0.2

Closing this issue as a duplicated issue that you filed at https://github.com/flutter/flutter/issues/119896. Please check the referred issue for more information.


fix variable names in remap_pipeline

Fix a bug in remap_pipeline.jl

Thanks!

bors r+

bors r-

bors r+


HBASE-24419 Normalizer merge plans should consider more than 2 regions when possible

The core change here is to the loop in SimpleRegionNormalizer#computeMergeNormalizationPlans. It's a nested loop that walks the table's region chain once, looking for contiguous sequences of regions that meet the criteria for merge. The outer loop tracks the starting point of the next sequence, the inner loop looks for the end of that sequence. A single sequence becomes an instance of MergeNormalizationPlan.
Pay mind only to the commit for this JIRA. This PR depends on HBASE-24628/#2454 and will need rebased once that one lands.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m  8s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 22s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
5m  1s
master passed

+1 :green_heart:
checkstyle
1m 44s
master passed

+1 :green_heart:
spotbugs
3m 21s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 14s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
4m 32s
the patch passed

-0 :warning:
checkstyle
0m 25s
hbase-common: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

-0 :warning:
checkstyle
1m 19s
hbase-server: The patch generated 6 new + 145 unchanged - 7 fixed = 151 total (was 152)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
15m  2s
Patch does not cause any errors with Hadoop 3.1.2 3.2.1.

+1 :green_heart:
spotbugs
3m 36s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 25s
The patch does not generate ASF License warnings.

46m 42s

Subsystem
Report/Notes

Docker
Client=19.03.13 Server=19.03.13 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2490/1/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2490

Optional Tests
dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle

uname
Linux 5ac66cf7cfbd 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 3b91a15183

checkstyle
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2490/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-common.txt

checkstyle
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2490/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt

Max. process+thread count
84 (vs. ulimit of 30000)

modules
C: hbase-common hbase-server U: .

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 17s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
4m 25s
the patch passed

+1 :green_heart:
compile
1m 43s
the patch passed

+1 :green_heart:
javac
1m 43s
the patch passed

+1 :green_heart:
shadedjars
7m  9s
patch has no errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m 19s
hbase-common in the patch failed.

-0 :warning:
javadoc
0m 44s
hbase-server in the patch failed.

_ Other Tests _

+1 :green_heart:
unit
1m 48s
hbase-common in the patch passed.

-1 :x:
unit
134m 12s
hbase-server in the patch failed.

168m 46s

Subsystem
Report/Notes

Docker
Client=19.03.13 Server=19.03.13 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2490/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2490

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 37ed8c4be7ac 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 3b91a15183

Default Java
2020-01-14

javadoc
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2490/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-common.txt

javadoc
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2490/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt

javadoc
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2490/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-common.txt

javadoc
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2490/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt

unit
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2490/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2490/1/testReport/

Max. process+thread count
3950 (vs. ulimit of 30000)

modules
C: hbase-common hbase-server U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2490/1/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 26s
Docker mode activated.

-0 :warning:
yetus
0m  4s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 27s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
6m 37s
master passed

+1 :green_heart:
compile
1m 56s
master passed

+1 :green_heart:
shadedjars
12m 11s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m 53s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 24s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
7m  4s
the patch passed

+1 :green_heart:
compile
2m 27s
the patch passed

+1 :green_heart:
javac
2m 27s
the patch passed

+1 :green_heart:
shadedjars
12m  9s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m 43s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
2m 30s
hbase-common in the patch passed.

-1 :x:
unit
283m 40s
hbase-server in the patch failed.

337m 24s

Subsystem
Report/Notes

Docker
Client=19.03.13 Server=19.03.13 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2490/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2490

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux a80372a1c248 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 3b91a15183

Default Java
1.8.0_232

unit
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2490/1/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2490/1/testReport/

Max. process+thread count
2756 (vs. ulimit of 30000)

modules
C: hbase-common hbase-server U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2490/1/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Hey @saintstack most of your comments here should be over on #2454 , where the refactoring happened.

How they relate @ndimiduk ? Should this be closed? I can move over but seems like you getting good review there. Saw this and saw it lonely so started in....

How they relate @ndimiduk ? Should this be closed? I can move over but seems like you getting good review there. Saw this and saw it lonely so started in....

From the description of this pr:

Pay mind only to the commit for this JIRA. This PR depends on HBASE-24628/#2454 and will need rebased once that one lands.

Sorry. Missed that. Compared the JIRAs. Let me move over.

Now that HBASE-24628/#2454 is merged, this should be easier to review. Rebased.

Left some additional notes for reviewers.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 45s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 23s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
5m  2s
master passed

+1 :green_heart:
checkstyle
1m 51s
master passed

+1 :green_heart:
spotbugs
3m 32s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 13s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
4m 46s
the patch passed

-0 :warning:
checkstyle
0m 28s
hbase-common: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

-0 :warning:
checkstyle
1m 21s
hbase-server: The patch generated 4 new + 0 unchanged - 0 fixed = 4 total (was 0)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
26m  6s
Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.

+1 :green_heart:
spotbugs
3m 52s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 26s
The patch does not generate ASF License warnings.

60m 10s

Subsystem
Report/Notes

Docker
Client=19.03.13 Server=19.03.13 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2490/2/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2490

Optional Tests
dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle

uname
Linux 8411351eb630 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 665a8767a0

checkstyle
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2490/2/artifact/yetus-general-check/output/diff-checkstyle-hbase-common.txt

checkstyle
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2490/2/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt

Max. process+thread count
85 (vs. ulimit of 30000)

modules
C: hbase-common hbase-server U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2490/2/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 28s
Docker mode activated.

-0 :warning:
yetus
0m  4s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 22s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
4m 13s
master passed

+1 :green_heart:
compile
1m 31s
master passed

+1 :green_heart:
shadedjars
6m 34s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m  5s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 17s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
4m  3s
the patch passed

+1 :green_heart:
compile
1m 29s
the patch passed

+1 :green_heart:
javac
1m 29s
the patch passed

+1 :green_heart:
shadedjars
6m 39s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m  3s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
1m 33s
hbase-common in the patch passed.

-1 :x:
unit
127m 37s
hbase-server in the patch failed.

159m 26s

Subsystem
Report/Notes

Docker
Client=19.03.13 Server=19.03.13 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2490/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2490

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 78bf0df0f501 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 665a8767a0

Default Java
2020-01-14

unit
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2490/2/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2490/2/testReport/

Max. process+thread count
4729 (vs. ulimit of 30000)

modules
C: hbase-common hbase-server U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2490/2/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m  4s
Docker mode activated.

-0 :warning:
yetus
0m  4s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 22s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 40s
master passed

+1 :green_heart:
compile
1m 21s
master passed

+1 :green_heart:
shadedjars
6m 36s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m  0s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 17s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 31s
the patch passed

+1 :green_heart:
compile
1m 21s
the patch passed

+1 :green_heart:
javac
1m 21s
the patch passed

+1 :green_heart:
shadedjars
6m 34s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 59s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
1m 31s
hbase-common in the patch passed.

+1 :green_heart:
unit
143m  9s
hbase-server in the patch passed.

173m 53s

Subsystem
Report/Notes

Docker
Client=19.03.13 Server=19.03.13 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2490/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2490

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 1792a614b3e0 4.15.0-65-generic #74-Ubuntu SMP Tue Sep 17 17:06:04 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 665a8767a0

Default Java
1.8.0_232

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2490/2/testReport/

Max. process+thread count
4076 (vs. ulimit of 30000)

modules
C: hbase-common hbase-server U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2490/2/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m  5s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 28s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 55s
master passed

+1 :green_heart:
checkstyle
1m 32s
master passed

+1 :green_heart:
spotbugs
2m 47s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 11s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 50s
the patch passed

-0 :warning:
checkstyle
0m 22s
hbase-common: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

-0 :warning:
checkstyle
1m 10s
hbase-server: The patch generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
18m 52s
Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.

+1 :green_heart:
spotbugs
3m 12s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 22s
The patch does not generate ASF License warnings.

45m 48s

Subsystem
Report/Notes

Docker
Client=19.03.13 Server=19.03.13 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2490/3/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2490

Optional Tests
dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle

uname
Linux bd18df8d2cfb 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 665a8767a0

checkstyle
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2490/3/artifact/yetus-general-check/output/diff-checkstyle-hbase-common.txt

checkstyle
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2490/3/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt

Max. process+thread count
84 (vs. ulimit of 30000)

modules
C: hbase-common hbase-server U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2490/3/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 27s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 14s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 57s
master passed

+1 :green_heart:
compile
1m 31s
master passed

+1 :green_heart:
shadedjars
6m 38s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m  4s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 15s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
4m  2s
the patch passed

+1 :green_heart:
compile
1m 31s
the patch passed

+1 :green_heart:
javac
1m 31s
the patch passed

+1 :green_heart:
shadedjars
6m 38s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m  3s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
1m 32s
hbase-common in the patch passed.

+1 :green_heart:
unit
133m 52s
hbase-server in the patch passed.

164m 58s

Subsystem
Report/Notes

Docker
Client=19.03.13 Server=19.03.13 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2490/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2490

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 60543d67fab6 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 665a8767a0

Default Java
2020-01-14

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2490/3/testReport/

Max. process+thread count
4803 (vs. ulimit of 30000)

modules
C: hbase-common hbase-server U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2490/3/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m  4s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 14s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 25s
master passed

+1 :green_heart:
compile
1m 20s
master passed

+1 :green_heart:
shadedjars
6m 36s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 59s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 16s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 28s
the patch passed

+1 :green_heart:
compile
1m 18s
the patch passed

+1 :green_heart:
javac
1m 18s
the patch passed

+1 :green_heart:
shadedjars
6m 30s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 58s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
1m 30s
hbase-common in the patch passed.

+1 :green_heart:
unit
140m 19s
hbase-server in the patch passed.

170m 21s

Subsystem
Report/Notes

Docker
Client=19.03.13 Server=19.03.13 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2490/3/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2490

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 2d01283f28ab 4.15.0-65-generic #74-Ubuntu SMP Tue Sep 17 17:06:04 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 665a8767a0

Default Java
1.8.0_232

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2490/3/testReport/

Max. process+thread count
4051 (vs. ulimit of 30000)

modules
C: hbase-common hbase-server U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2490/3/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Rebase and address checkstyle nits.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 28s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 30s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
4m 21s
master passed

+1 :green_heart:
checkstyle
1m 39s
master passed

+1 :green_heart:
spotbugs
2m 54s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 12s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
4m  7s
the patch passed

+1 :green_heart:
checkstyle
1m 40s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
19m 13s
Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.

+1 :green_heart:
spotbugs
3m 21s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 22s
The patch does not generate ASF License warnings.

47m 59s

Subsystem
Report/Notes

Docker
Client=19.03.13 Server=19.03.13 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2490/4/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2490

Optional Tests
dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle

uname
Linux 86d65c00cba9 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / c28220522d

Max. process+thread count
84 (vs. ulimit of 30000)

modules
C: hbase-common hbase-server U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2490/4/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 31s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 27s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
4m  2s
master passed

+1 :green_heart:
compile
1m 31s
master passed

+1 :green_heart:
shadedjars
6m 30s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m  3s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 15s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 58s
the patch passed

+1 :green_heart:
compile
1m 35s
the patch passed

+1 :green_heart:
javac
1m 35s
the patch passed

+1 :green_heart:
shadedjars
6m 38s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m  4s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
1m 32s
hbase-common in the patch passed.

+1 :green_heart:
unit
132m  8s
hbase-server in the patch passed.

164m 44s

Subsystem
Report/Notes

Docker
Client=19.03.13 Server=19.03.13 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2490/4/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2490

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 7ee3b777a7ee 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / c28220522d

Default Java
2020-01-14

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2490/4/testReport/

Max. process+thread count
4603 (vs. ulimit of 30000)

modules
C: hbase-common hbase-server U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2490/4/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 28s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 23s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 41s
master passed

+1 :green_heart:
compile
1m 23s
master passed

+1 :green_heart:
shadedjars
6m 43s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 59s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 16s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 33s
the patch passed

+1 :green_heart:
compile
1m 24s
the patch passed

+1 :green_heart:
javac
1m 24s
the patch passed

+1 :green_heart:
shadedjars
6m 32s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 59s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
1m 22s
hbase-common in the patch passed.

+1 :green_heart:
unit
140m 11s
hbase-server in the patch passed.

170m 24s

Subsystem
Report/Notes

Docker
Client=19.03.13 Server=19.03.13 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2490/4/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2490

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux f401c3625c38 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / c28220522d

Default Java
1.8.0_232

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2490/4/testReport/

Max. process+thread count
3998 (vs. ulimit of 30000)

modules
C: hbase-common hbase-server U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2490/4/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Bump.
The last build-bot run was all greens, I'm not sure why the GitHub status didn't update.

Rebased.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m  3s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 27s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 55s
master passed

+1 :green_heart:
checkstyle
1m 35s
master passed

+1 :green_heart:
spotbugs
2m 50s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 12s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 48s
the patch passed

+1 :green_heart:
checkstyle
1m 34s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
18m 50s
Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.

+1 :green_heart:
spotbugs
3m  7s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 21s
The patch does not generate ASF License warnings.

45m 41s

Subsystem
Report/Notes

Docker
Client=19.03.13 Server=19.03.13 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2490/6/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2490

Optional Tests
dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle

uname
Linux 9055bedec6e2 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 2cd5f914af

Max. process+thread count
84 (vs. ulimit of 30000)

modules
C: hbase-common hbase-server U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2490/6/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 47s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 24s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
4m 16s
master passed

+1 :green_heart:
compile
1m 32s
master passed

+1 :green_heart:
shadedjars
6m 41s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m  5s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 16s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
4m  2s
the patch passed

+1 :green_heart:
compile
1m 34s
the patch passed

+1 :green_heart:
javac
1m 34s
the patch passed

+1 :green_heart:
shadedjars
6m 34s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m  5s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
1m 34s
hbase-common in the patch passed.

-1 :x:
unit
138m 11s
hbase-server in the patch failed.

171m 14s

Subsystem
Report/Notes

Docker
Client=19.03.13 Server=19.03.13 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2490/6/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2490

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 5f729e279f26 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 2cd5f914af

Default Java
2020-01-14

unit
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2490/6/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2490/6/testReport/

Max. process+thread count
4762 (vs. ulimit of 30000)

modules
C: hbase-common hbase-server U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2490/6/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m  4s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 29s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 31s
master passed

+1 :green_heart:
compile
1m 19s
master passed

+1 :green_heart:
shadedjars
6m 27s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m  2s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 16s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 26s
the patch passed

+1 :green_heart:
compile
1m 19s
the patch passed

+1 :green_heart:
javac
1m 19s
the patch passed

+1 :green_heart:
shadedjars
6m 27s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 58s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
1m 30s
hbase-common in the patch passed.

+1 :green_heart:
unit
146m 57s
hbase-server in the patch passed.

177m 14s

Subsystem
Report/Notes

Docker
Client=19.03.13 Server=19.03.13 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2490/6/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2490

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 8016496bc4bf 4.15.0-65-generic #74-Ubuntu SMP Tue Sep 17 17:06:04 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 2cd5f914af

Default Java
1.8.0_232

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2490/6/testReport/

Max. process+thread count
4341 (vs. ulimit of 30000)

modules
C: hbase-common hbase-server U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2490/6/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m  8s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 28s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
4m  4s
master passed

+1 :green_heart:
checkstyle
1m 42s
master passed

+1 :green_heart:
spotbugs
3m 17s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 13s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
4m 16s
the patch passed

+1 :green_heart:
checkstyle
1m 40s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
19m 33s
Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.

+1 :green_heart:
spotbugs
3m 13s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 21s
The patch does not generate ASF License warnings.

48m 11s

Subsystem
Report/Notes

Docker
Client=19.03.13 Server=19.03.13 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2490/7/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2490

Optional Tests
dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle

uname
Linux a7990961c13f 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 259fe1984a

Max. process+thread count
84 (vs. ulimit of 30000)

modules
C: hbase-common hbase-server U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2490/7/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 22s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 27s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
4m 34s
master passed

+1 :green_heart:
compile
1m 47s
master passed

+1 :green_heart:
shadedjars
6m 48s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m  2s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 17s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 59s
the patch passed

+1 :green_heart:
compile
1m 31s
the patch passed

+1 :green_heart:
javac
1m 31s
the patch passed

+1 :green_heart:
shadedjars
6m 39s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m  5s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
1m 33s
hbase-common in the patch passed.

+1 :green_heart:
unit
135m 36s
hbase-server in the patch passed.

169m  9s

Subsystem
Report/Notes

Docker
Client=19.03.13 Server=19.03.13 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2490/7/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2490

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux f16918938d8d 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 259fe1984a

Default Java
2020-01-14

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2490/7/testReport/

Max. process+thread count
4807 (vs. ulimit of 30000)

modules
C: hbase-common hbase-server U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2490/7/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m  9s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 22s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 39s
master passed

+1 :green_heart:
compile
1m 19s
master passed

+1 :green_heart:
shadedjars
6m 35s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m  0s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 16s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 30s
the patch passed

+1 :green_heart:
compile
1m 20s
the patch passed

+1 :green_heart:
javac
1m 20s
the patch passed

+1 :green_heart:
shadedjars
6m 35s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 58s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
1m 31s
hbase-common in the patch passed.

+1 :green_heart:
unit
146m 58s
hbase-server in the patch passed.

177m 28s

Subsystem
Report/Notes

Docker
Client=19.03.13 Server=19.03.13 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2490/7/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2490

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 1eaa5f30ffd7 4.15.0-65-generic #74-Ubuntu SMP Tue Sep 17 17:06:04 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 259fe1984a

Default Java
1.8.0_232

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2490/7/testReport/

Max. process+thread count
4348 (vs. ulimit of 30000)

modules
C: hbase-common hbase-server U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2490/7/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.


PII scrubbing YAML tool

For various scenarios, its useful to get information about a users configuration. However, users often don't want to provide it as it may contain confidential information. It would be useful to have a tool that takes these configs and scrubs identifiable information. This would be especially useful when analyzing scaling/perf issues, as we can get an exact dump of their cluster state.
How I envision this is to have a schema aware tool, which would block out any custom fields in the yaml. Ideally, it would also maintain referential integrity. For example
apiVersion: networking.istio.io/v1beta1
kind: VirtualService
metadata:
  name: reviews-route
spec:
  hosts:
  - reviews.prod.svc.cluster.local
  http:
  - match:
    - sourceLabels:
        env: prod
    route:
    - destination:
        host: reviews.prod.svc.cluster.local
        subset: v1

would be come
apiVersion: networking.istio.io/v1beta1
kind: VirtualService
metadata:
  name: lorem-ipsum
spec:
  hosts:
  - dolorsitamet
  http:
  - match:
    - sourceLabels:
        consectetur: adipiscing
    route:
    - destination:
        host: dolorsitamet # NOTE!! this matches "hosts" above
        subset: foobar

Things to note:

reviews is replaced with the same string in all referenced locations.
We are also not just simply changing values; see the env field which is part of a map[string]string, where we replace the key and the value

cc @ostromart might be related to your support-ability work

not stale

I think its a  cool idea but not really seen much demand in Istio


cmd/go: test -v does not output text from log.Println when package is passed

Please answer these questions before submitting your issue. Thanks!
What version of Go are you using (go version)?
go 1.9
Does this issue reproduce with the latest release?
Yes
What operating system and processor architecture are you using (go env)?
darwin/amd64 and windows/amd64
What did you do?
Run go test -v with package as argument for the below test
package stringutil

import "testing"
import "log"

func TestMe(t *testing.T) {
	log.Println("logging")
}

What did you expect to see?
The text from the log.Println statement
What did you see instead?
In Windows, the text from the log.Println statement gets output to stdout
In Mac, the text from the log.Println statement does NOT get output to stdout
go test on the other hand (without passing the package) does output the text from the log.Println statement even without the -v flag

Please show us the exact commands that you run.  When I put the file you describe in $GOPATH/src/issue22113/x_test.go and run go test -v issue22113, I see this:
=== RUN   TestMe
2017/10/02 12:56:48 logging
--- PASS: TestMe (0.00s)
PASS
ok  	issue22113	0.038s

That is, the log.Println output does appear.  It's perhaps worth noting that it does not appear on standard output; it appears on standard error.  That is because the log package's standard logger outputs to standard error by default.

@ianlancetaylor My mistake.
I had another copy of the same project in the default GOPATH for go 1.9 on my Mac which did not have the log statements. That was the package being run.
Sorry for the trouble.

is there a way to store the output of go test command ? I am only interested in the end result, may be
just "pass" or "fail"


Fails to run after successful first attempt.

I was able to run it for a full year. Then it automatically closed after finishing (I'm assuming that's the intended behavior).
But when I tried it for another run on another year, it automatically closes just as it starts scanning.
on w10 btw

I was able to login. Not sure what happened, but it seems to be working now after few hours.

So i was able to replicate..
i tried running for all available year. It was running fine at first until it autoclosed.
Then when i tried rerunning, it closes as soon as it complete all the parameters.
I can login to mbasic all these time btw.

It should also work in Windows.


Implement C# project setting validators for Paratext-y project settings

User Story
As a user or developer, I want Paratext project settings so that I can know things about the project like which books are available, whether the project is editable, etc.
Description
We need to be able to provide project settings for Paratext projects. These projects are served from the dotnet data provider process. As such, we need to provide project settings validators for ParatextStandard project settings from C#.
Add validators for the ProjectSettingTypes in extensions\src\usfm-data-provider\index.d.ts via C#.

Here's some UI from PT9 showing the places in Paratext which determine how checks are run:
Project settings:

Inventories:

Add static function RegisterValidator to ProjectSettingsService.cs.
That function should call PapiClient:RegisterRequestHandler. Pass in extensionProjectSettingValidator: for the request type.
Wait on RegisterRequestHandler to return before returning back to the caller.
Test

https://github.com/paranext/paranext-core/pull/882


OpenGL crash on AVD running 6.0

Nothing special. Surprised this hasn't been noticed - or is it a problem with my system somehow?
Using Intel Atom x86 in emulator, running a generic 1080p Android 6.0 instance.
Added library, added following code:
addSlide(new agency.tango.materialintroscreen.SlideFragmentBuilder()
				.backgroundColor(R.color.wizard_bg_brown)
                .buttonsColor(R.color.wizard_button_pink)
                .title("Want more?")
                .description("Go on")
                .build());

App doesn't get an FC, but just silently dies, with this in the log:
11-14 17:27:01.825  1526  2644 I ActivityManager: Start proc 2887:com.cosmicdan.reptracker/u0a54 for activity com.cosmicdan.reptracker/.Main
11-14 17:27:01.848  2887  2887 W System  : ClassLoader referenced unknown path: /data/app/com.cosmicdan.reptracker-1/lib/x86
11-14 17:27:01.910  1187  1439 E SurfaceFlinger: ro.sf.lcd_density must be defined as a build property
11-14 17:27:01.927  2462  2567 E Surface : getSlotFromBufferLocked: unknown buffer: 0xae0cd8a0
11-14 17:27:01.944  2887  2901 I OpenGLRenderer: Initialized EGL, version 1.4
11-14 17:27:02.084  1187  1187 E EGL_emulation: tid 1187: eglCreateSyncKHR(1315): error 0x3004 (EGL_BAD_ATTRIBUTE)
11-14 17:27:02.158  1526  2645 W InputMethodManagerService: Focus gain on non-focused client com.android.internal.view.IInputMethodClient$Stub$Proxy@be8acfa (uid=10054 pid=2887)
11-14 17:27:02.212  2887  2901 E Surface : getSlotFromBufferLocked: unknown buffer: 0xb2882230
11-14 17:27:02.218  1526  1708 W InputMethodManagerService: Window already focused, ignoring focus gain of: com.android.internal.view.IInputMethodClient$Stub$Proxy@f1051b4 attribute=null, token = android.os.BinderProxy@ff888c6
11-14 17:27:02.758  2462  2567 W OpenGLRenderer: Incorrectly called buildLayer on View: ShortcutAndWidgetContainer, destroying layer...
11-14 17:27:02.758  2462  2567 W OpenGLRenderer: Incorrectly called buildLayer on View: ShortcutAndWidgetContainer, destroying layer...

A google search turned up a mention of a problem that could be related - a crash only in Marshmallow when trying to do a transition animation on a fragment - but I tried the following code to fix it, as the top stackoverflow reply hinted...
getWindow().getDecorView().setLayerType(View.LAYER_TYPE_SOFTWARE, null);

...to no avail.
I was really looking forward to using this :(

Tried it on an emulator running 5.1.1 and the result is the same.
I have no idea what I'm doing wrong!

Sorry for the triple comment, just some extra testing:
I disabled "Host GPU acceleration" and also tested on a real phone running Marshmallow 6.0. In both those cases I no longer see the original OpenGL error, however it still silently dies with no relevant log output.

Well I'm out of ideas, I can't wait around for this to be fixed sadly.
Good luck with this issue and project.

Well I kept at it, started fresh and put it into a new Activity instead of trying to use it in an existing fragment (where the parent Activity extended MaterialIntroActivity).
I should have followed the instructions of course, but it was very strange that I had no errors at all.
Anyway, thanks for the great library!


Multi-GPU issues

Here's another bug on Oobabooga's project that is unresolved...
https://github.com/oobabooga/text-generation-webui/issues/2923
I realized that the ExLlama team may have a solution....
So thought I'd cross post this issue on this project, in case you've not seen.
Here's the guide I wrote to get everything working on AMD kit...
https://github.com/nktice/AMD-AI
Models load fine when it is only on one card, here are some results :
https://github.com/nktice/AMD-AI/blob/main/SallyAIRiddle.md
Multi-card loading only spits out gibberish, here's an example :
pha golden Riv. Jcatred (ProcSN proc Dre -:// Mindly means for the and in a Nich říct Forest Rav Rav fran fran fran gaz Agrcastle castleasiacliordinate advers Mem advers Basibenkooor paste Singapore refugeermeanny intellectualsafe Shakespe contempor Mallmanual Quantmousektr Ge Mil shadownehfdzekADmobile Und Euenf Next Dominbuchcock Infoengo Hann NAT ]] Ferr' -.-- -,-

    ason, rang,-, –-

(,,

--,.,

alter

,-

(

-on,-.

I,- .

1

V

V. film-

N

    –on.,on,.

(, for.

and of- is. . and –on, –,. and

In in

film school and I on and with and I ":

.

` andon util –

Bug in hip or rocm. On nvidia it's working to split. Other bug is OOM if you can't properly dispatch the model so it doesn't run out during inference.

In the thread mentioned Nvidia does not work, and does the same thing.
https://github.com/oobabooga/text-generation-webui/issues/2923

Bug in hip or rocm. On nvidia it's working to split. Other bug is OOM if you can't properly dispatch the model so it doesn't run out during inference.

Thanks for your reply... I've raised the issue on HIPs github support thread :
https://github.com/ROCm-Developer-Tools/HIP/issues/3331

Thanks for your reply, and your excellent coding, it's great when it works...
I looked into this, and had trouble finding how to do such a thing...
Whereas such features would be good to have options through their interface, I have requested Oobabooga add features so it can be done :
https://github.com/oobabooga/text-generation-webui/issues/3912

Yep, torch.empty isn't supposed to clear the data, which could cause problems if you're incorrectly assuming that an empty tensor is the same as a zeros tensor, but I think I've been mindful enough of the distinction.
--gpu_peer_fix is only a kludge to work around a particular bug in Torch (or CUDA, or the NVIDIA driver, or whatever the case may be). So it's not really a solution or anything, more a diagnostic tool, and the solution would be filing a bug report upstream if that flag fixes something that shouldn't be broken.
I'm thinking another thing to explore would be the use of at::cuda::OptionalCUDAGuard to ensure that the correct CUDA device is selected on entry to each of the extension functions. If that doesn't get properly HIPified, it could lead to ROCm working correctly on single-GPU setups but failing (perhaps even sporadically) on multi-GPU setups.

Thanks for your replies... I have been thinking of this, so I'll mention it.
Another issue, that is somewhat related to model loading
is cache and other memory that is involved in handling models...
So for example, forum commenters noted to use split settings
that leave lots of room for caching and memory use around models -
As model tokens, caching, and management bits consume lots of space.
[ bigger the model, the more is used for tokens, and index info... ]
I am wondering if there is a loader option to describe these bits
[ Command line option, benchmark tool parameter, or something like that... ]
so one can predict the whole memory footprint a model will use?
Related to this, instead of splitting model across GPUs,
is it practical to have supporting features on another card?
This would allow for maximizing model size loaded on one card
so as to avoid an issue like I'm having splitting up model,
using 2nd card, ( or perhaps the system RAM ) for caching / tokens.
As tokens go up, supplemental memory could be more helpful.

Cache and state has to reside on the same device as the associated weights. You can't do CUDA operations across devices, and while you could store just the cache on a separate device, it would be slower than just swapping it to system RAM, which is still slow enough to be kind of useless.

Guess, I forgot to answer here, this is the same issue as #173 which was fixed upstream and will be available in next ROCm version.
Note that exllama v2 is also affected and this could have easily been fixed locally in exllama with a small hack like it was done in llama.cpp, but I didn't have the hardware to test.

I can now report, that using latest drivers, it seems to work now.
As in I can load a model cross-GPUs and it's responsive.
[ ROCm 6.0 , torch==2.3.0.dev20240118+rocm6.0 ]