Newly created files don't belong to typescript project on MacOS

Bug Report
🔎 Search Terms
Maybe ts, vscode, file is not part of ts project, newly created?
🕗 Version & Regression Information
Tested on the following typescript versions:

4.5.0-dev.20210904
4.4.2
4.4.1-rc
4.3.5

vscode version: 1.60.0
⏯ Playground Link
https://github.com/yifanwww/ts-bug-repo
This is a very simple project...
🙁 Actual behavior
Open that project via vscode(whatever open folder directly or open the workspace file).
Open the file src/index.ts to get tsserver started, then create a new file src/test.ts.
There should be an error cannot be compiled under '--isolatedModules' because it is considered a global script file. Add an import, export, or an empty 'export {}' statement to make it a module.ts(1208), but actually it got no error.
Execute vscode command Typescript: Go to Project Configuration, a panel appears with info File is not part of a Typescript project. Click here to learn more.
In that new ts file, no auto-completion and no auto-import to use the function fn which is declared in src/index.ts.
I have to restart tsserver or reload vscode.
I have checked these issues but still don't know how to solve this problem.

https://github.com/microsoft/TypeScript/issues/43290
https://github.com/microsoft/TypeScript/issues/36532
https://github.com/microsoft/TypeScript/issues/35794
https://github.com/microsoft/TypeScript/issues/33564

This bug never happens on my win laptop, but does always happen on my mac laptop.
🙂 Expected behavior
The file gets added into the existing typescript project.
BTW, If you need tsserver.log, please tell me how to get it.

Hello,
I have exactly same issue but on Linux, but i have found the problem and an temporary solution.
The problem come from include property in tsconfig.json when that property is set to folder or too ambigu in that case src(but this is same if is set to src/**/*).

Thanks.

@orblazer Thanks a lot, seems this temporary solution works for me.

Hmm, I can’t reproduce this. I’m on macOS 12.1 Beta, VS Code 1.63.0-insider, and TypeScript 4.4.2 (also tried latest nightly). How are you creating/opening the new file test.ts in your repro instructions? If this is still happening for you, can you post a TS Server log (instructions)? Thanks!

@andrewbranch
I usually click this button to create a new file, name it and then save it.

I'm now on macOS 11.6.1, VSCode 1.63.2, and TypeScript 4.5.4, that problem still occurs to me.
I will try to get a tsserver log.

@andrewbranch
BTW, I read the tsconfig reference again (https://www.typescriptlang.org/tsconfig#include).
I want to know is it allowed to set the include option without any glob patterns, like "include": ["src"]?
It seems that "include": ["src"] and "include": ["src/**/*"] behave the same on my win but not on my mac.

I'm also seeing the same issue for the last few... weeks?

Thanks!
If anyone is trying this workaround, I recommend restarting VSCode rather than just restarting the TypeScript server. That helped it stick for me.

It seems that "include": ["src"] and "include": ["src/**/*"] behave the same on my win but not on my mac.

I thought these were the same. And I still can’t reproduce the issue. @lgarron are you still able to reproduce this if you revert changing the glob format?
Another issue about glob weirdness, though perhaps ultimately unrelated: #46788

@andrewbranch
Hello, here are my tsserver logs https://gist.github.com/yifanwww/f06c9ee62260140f0cca0433bab457c7
There are two files tsserver-1.log and tsserver-2.log, the first one was generated when includes was set as src, and the other one was generated when includes was set as src/**/*. Seems there are huge differences.

The first difference comes from line 42+, tsserver-2 will watch /ts-bug-repo/src while tsserver-1 won't do that.

So when I created test.ts and opened it, tsserver-2 knew it but tsserver-1 only knew that I opened a new file.
Then... I don't know what does the other difference mean.

I thought these were the same. And I still can’t reproduce the issue. @lgarron are you still able to reproduce this if you revert changing the glob format?

Indeed:

Create a new file ⇒ recognized.
Remove the globs and restart VSCode.
Create a new file (adjacent to the last time) ⇒ NOT recognized. 🧐

For what it's worth, I'm also able to repro in Codespaces using https://github.com/cubing/cubing.js/tree/exclude-glob-for-ts45721
src/sites/experiments.cubing.net/cubing.js/stub/index.ts supports autocompletion:

If I create a file at src/sites/experiments.cubing.net/cubing.js/stub/index2.ts, it does not:

If I go back to a commit with the globs and restart the TS server, then it works again. So it's quite reproducible for our repo.

I can reproduce in Codespaces and have traced the likely root cause down to the huge differences between file watching on Linux vs. other OSes. This does not explain your observations of it being broken on macOS, which I still can’t reproduce 🤔

Actually, to clarify, in Codespaces I’m seeing the bad behavior all the time. I haven’t yet seen why this would depend on the glob format.

Discovered with much help from @lgarron that there is an issue when the absolute path to an include pattern contains a . character. @yifanwww, does your repo or any ancestor directory have a .?

@andrewbranch No . character in the repo but yup the home directory in my mac has a . character, that is my name fan.yi.

Welp, that’s why your repro was not a repro for me 😅 Fixed at #47418

This problem seems to have returned in the latest version of TypeScript and VSCode.

This problem seems to have returned in the latest version of TypeScript and VSCode.

It is indeed.
The only fix is to restart TS Server manually, which is not ideal.
Version: 1.85.1 (Universal)
Commit: 0ee08df0cf4527e40edc9aa28f4b5bd38bbff2b2
Date: 2023-12-13T09:48:06.308Z
Electron: 25.9.7
ElectronBuildId: 25551756
Chromium: 114.0.5735.289
Node.js: 18.15.0
V8: <IP_ADDRESS>-electron.0
OS: Darwin arm64 21.6.0

There are many reasons this can happen and it depends a lot on your configuration. Please log new issues(s) with concrete repro steps.


Parameter to MergeFrom() must be instance of same class

I get
Traceback (most recent call last):
  File "/home/jmugan/Dropbox/consulting/Billenote/billenote/src/experimental/gale_langchain_vertex_ai.py", line 8, in <module>
    structured_llm = llm.with_structured_output(AnswerWithJustification)
  File "/home/jmugan/anaconda3/lib/python3.8/site-packages/langchain_google_vertexai/chat_models.py", line 1101, in with_structured_output
    llm = self.bind_tools([schema], tool_choice=self._is_gemini_advanced)
  File "/home/jmugan/anaconda3/lib/python3.8/site-packages/langchain_google_vertexai/chat_models.py", line 1138, in bind_tools
    vertexai_tool = _format_to_gapic_tool(tools)
  File "/home/jmugan/anaconda3/lib/python3.8/site-packages/langchain_google_vertexai/functions_utils.py", line 231, in _format_to_gapic_tool
    gapic_tool.function_declarations.append(fd)
TypeError: Parameter to MergeFrom() must be instance of same class: expected google.cloud.aiplatform.v1beta1.FunctionDeclaration got FunctionDeclaration.

from
from langchain_google_vertexai import ChatVertexAI
class AnswerWithJustification(BaseModel):
    '''An answer to the user question along with justification for the answer.'''
    answer: str
    justification: str
llm = ChatVertexAI(model="gemini-pro", temperature=0)
structured_llm = llm.with_structured_output(AnswerWithJustification)
response = structured_llm.invoke("What weighs more a pound of bricks or a pound of feathers")
print(response.content)

Probably a version mismatch with protobuf silliness. I did pip install -U on everything I could think of. Any suggestions?

Hey @jmugan,
I just did a clean install in the new venv and can't replicate this issue:
python3 -m venv venv
source venv/bin/activate
pip install -U langchain-google-vertexai

python3 240.py
answer='A pound of bricks and a pound of feathers weigh the same.' justification='They both weigh one pound.'

Also, there are two things that could be improved:

llm.with_structured_output(AnswerWithJustification).invoke("text") will return you the instance of AnswerWithJustification, so response.content will fail, as AnswerWithJustification doesn't have content field.
It's always better to use explicit model version like gemini-1.0-pro-002 https://cloud.google.com/vertex-ai/generative-ai/docs/learn/model-versioning#stable-version

So the code will look like this:
from langchain_google_vertexai import ChatVertexAI
from langchain_core.pydantic_v1 import BaseModel

class AnswerWithJustification(BaseModel):
    '''An answer to the user question along with justification for the answer.'''
    answer: str
    justification: str
llm = ChatVertexAI(model="gemini-1.0-pro-002", temperature=0)
structured_llm = llm.with_structured_output(AnswerWithJustification)
response = structured_llm.invoke("What weighs more a pound of bricks or a pound of feathers")
print(response)

That code gives me the same error. In a new environment it runs with no problem, but I'm trying to use it in an existing environment. So there must be something with the compiling of the protobuf. It needs to be recompiled somehow with a new version of some library, but I can't figure out which one. I don't know why Google loves protobuf so much.

Maybe try pip uninstall libraries in question (incl. google-cloud-aiplatform) from your env first and then install them again.
Closing it for now, since it doesn't look the issue is on the integration side.


Enable packaging with packager.io

Not sure if you'd be interested, but you can enable automatic RPM and DEB packaging directly from this GitHub repository, using https://packager.io and the configuration provided in this PR.
I launched the packaging process on my branch for all distributions and it went fine: https://packager.io/gh/pkgr/chef-runner/install?bid=4#centos-6-chef-runner. Execution also appears to be fine, though I haven't tested anything other than:
$ chef-runner --version
chef-runner v0.9.0.dev linux/amd64 go1.4.1

Let me know what you think!

Hey @crohr,
That looks pretty cool. I'm wondering how I can access artifacts after building? Is there some API? Or maybe even automated pushing to https://packagecloud.io/mlafeldt/chef-runner?

Hi Mathias,
No API yet, but I'm working on it. Would webhooks be sufficient for a start, so that you get notified of new artefacts?
Official integration with packagecloud is not planned at the moment, as we’re also providing hosting and installation instructions for the generated packages. However we will add post-packaging hooks so you may use that to push the packages elsewhere once they’ve been generated.

On 2 Feb 2015, at 14:33, Mathias Lafeldt<EMAIL_ADDRESS>wrote:
Hey @crohr https://github.com/crohr,
That looks pretty cool. I'm wondering how I can access artifacts after building? Is there some API? Or maybe even automated pushing to https://packagecloud.io/mlafeldt/chef-runner https://packagecloud.io/mlafeldt/chef-runner?
—
Reply to this email directly or view it on GitHub https://github.com/mlafeldt/chef-runner/pull/49#issuecomment-72466539.

Thanks for the PR and the explanations. I'll go with my solution for now, mainly because I know exactly what it does and I can push to whatever repo I want.


Adding in a cwl tool for cnvkit

@chrisamiller That option is for cnvkit segment, and the one included in this file is cnvkit batch. I'm going to rename the tool to make this clear in case we decide to incorporate segment or any others later on.

Weird batch is just a wrapper and calls segment internally, so it seems like there oughta be a way to pass params down to the sub-steps.  Checking the code, though, there is not, so yeah, okay. I withdraw my comment!


Add feature : Show recent projects on HomeActivity

Can we have some recent projects/drafts show up on HomeActivity?
We have Saved Projects and My Drafts section for this purpose but I feel when a user is building on a large application it is more intuitive to have their projects show up on app launch.
So maybe we could have recent 2 saved projects and recent 2 drafts show up on HomeActivity.
@croozeus @opticod your views on this ?

@opticod @croozeus IMO It would be a good idea. I am working on this.

Hey @anuradhagupta345 I have actually started working on this and waiting for comments from maintainers. I will let you know if I need any help. Thanks!

@archie94 @anuradhagupta345 . Whoever fells good can proceed. Its good to add it. I would love to make it  optional too. Next step is simple, just add a checkbox in app settings fragment  preference (checked to show; unchecked to hide)

@opticod Sure thing ! :+1:


Pass parameters in overlay url (eg xyz layer)

i want to do something like this
      greecepng: {
        name: 'utfGreecePng',
        type: 'xyz',
        url: '/api/maps/{z}/{x}/{y}.png?param1={param1}&param2={param2}&param3={param3}',
        visible: true,
        layerOptions: {
          param1: '',
          param2: '',
          param3: '',
        }
      },

In leaflet documentation it says that this is possible , but whatever i do i cant accomplish that.
I tried on moveend event of map to :
remove the layer from map to force directive to readdit
update the layer object with the parameters.
but whatever i do parameters dont pass in the query in my server.
Is there any solution to that?

Please, we need an example documenting the issue:
https://github.com/tombatossals/angular-leaflet-directive/wiki/MCVE
I'm closing this as it's old and lot of things changed lately. Please reopen if needed


Add integration tests for Mesos+AWS (and maybe others)

Multi-node Mesos tests will be implemented by autoscaling,

See #600


Document LICENSE file Exclusions for incubator-openwhisk-runtime-php

Please use this issue to document directories/files (by extension) or individual files we have decided will not require a LICENSE header because it falls under an allowed Apache category (see https://www.apache.org/legal/src-headers.html)
for example:

config file
data file
test file
generated file
etc.

I suggest to add below files to excluded file list, because they are configuration files with few creativity.
  openwhisk-runtime-php/tests/src/test/resources/application.conf
  openwhisk-runtime-php/ansible/environments/local/group_vars/all
  openwhisk-runtime-php/ansible/environments/local/hosts

Vincent merged PR https://github.com/apache/incubator-openwhisk-runtime-php/pull/13#event-1579337468
@daisy-ycguo after this merge, do all files we determined need LICENSE headers have them?  Are there any exclusions that we need to list on markdown here?

@mrutkows After https://github.com/apache/incubator-openwhisk-runtime-php/pull/13#event-1579337468 is merged, all files have headers except the exclusions in markdown file. The license header of this repo is clear now.

merged https://github.com/apache/incubator-openwhisk-runtime-php/pull/13#event-1579337468


DesktopApps Support

Hello! I'm really interested in your project because it was challenging for me to find something similar. Most plugins are focused on Spotify, which is not what I was looking for. I wanted to ask if it's possible to implement support for desktop applications, specifically Tidal, Aimp, and MusicBee? Alternatively, is it possible to make the plugin work through Last.fm?

Thank you for such a quick response. Yes, Last.fm would be a good alternative, but unfortunately, there may be some delays. I suppose the current plugin works almost instantaneously, which is fantastic. I really appreciate the excellent work you've done.

Last.fm receives track information from the scrobbler after some time to take into account the tracks you've actually listened to, rather than just skipped over. Depending on the application, this can take anywhere from 10 to 60+ seconds.

I'll have to look into last.fm as I know next to nothing about it.

Last.fm is a music website that allows you to track and discover new music. It keeps a record of the music you listen to and provides personalized recommendations based on your listening history.

If it's not a music "player", I'm not sure I can actually use it to display media information in WebNowPlaying

Scrobbling is the process by which information about the track you're listening to on your device is sent to Last.fm's servers. To enable scrobbling, you need to install the Last.fm scrobbler on your device and log in to your Last.fm account through it.
When you start playing a track, the scrobbler tracks information about it and sends it to Last.fm's servers. Last.fm analyzes this information and adds the track to your library, as well as uses it to provide personalized recommendations.
To ensure scrobbling works correctly, the track must be played for at least 30 seconds and played in full (not skipped or missed). It's also important that the track's name and artist are correct, otherwise the track information may be scrobbled incorrectly.

So how would you imagine last.fm working with WebNowPlaying? WNP is normally used for real-time status displays and to control the playing media from Rainmeter, etc. by pausing, setting volume, etc.

Also, for playing local music files, I used to use winamp but since that isn't WebNowPlaying compatible I switched to using (Navidrome)[https://github.com/navidrome/navidrome].
It's basically a self-hosted music streaming server, and since it's accessible via a web-ui it works with wnp.

LMK if this has been resolved for you or if you need anything else, otherwise I'll close this issue (as you reacted with hooray)

I just think that there is no possibility to connect browser capture with desktop streaming services (except spotify) for obs like this. So its should be just another way to do it. Btw, another question. There few apps wich sending same info about what you listening too to Discord from your desktop streaming services. Could it be used for such capture?

I think WebNowPlaying will continue to only work for browser-based media, with the exception of Spotify. I'm sorry.
Perhaps in the future I might add basic media detection via Windows APIs as a fallback.
If that happens, I'll comment here to let you know if I don't forget :)

I will actually add support for native apis pretty soon, at least for windows.
Could you tell me if the players you're using show up in the media control panel / the popup you get when changing volume etc.?
If they do, then WNP will be able to read it.
If not, some players have plugins to make them work with windows.

@Solomag tagged you just in case :)

Hey, thats really cool! Im using Tidal as analog of Spotify, AIMP and MusicBee.

Not sure what that means!
Does it report back to windows?

@Solomag I just tried it myself now.
(Talking about the new method I'm adding of course, so it won't work for you until I update it once all is done)
Tidal works out of the box.
Spotify works out of the box.
AIMP works with this plugin
MusicBee works with this plugin

Thats amazing! How can I support you? And yep, I was saying about Windows. And when update will be available? Btw, I had those plugins already installed =)

@Solomag not sure what you mean by supporting me.
The update might still take another.. maybe a week?
It's part of a much bigger update concerning all WebNowPlaying projects you can see on my profile.
I can't risk breaking anything so it'll depend on if I discover any more bugs during testing.

I meant with money or participating in beta-test.

@Solomag
I haven't thought about public beta testing yet and I'm not sure I'll ever do them as I'd probably only release beta builds when they're in a stable state anyway.
As for donations, I do have a paypal if you insist.

@Solomag Just thought I'd give you an update.
I've ran into quite a lot of issues with making this new change work for the Rainmeter adapter. I'm pretty sure it'd already work with OBS but the Rainmeter adapter is my main priority.
Sorry this is taking so long.

Checked update, not working with Tidal, AIMP, MusicBee.
Re-installed script from start, works in browser, not seeing desktop apps. Closing browser just gave N/A-N/A In the same time. Droptop plugin seen my Tidal. Also closed droptop, same problem. All plugins for AIMP/MusicBee been re-instaled.
System Win 11 Pro 22H2

I wasn't clear enough, sorry.
I have stuff working locally, I haven't updated anything yet.
I'll only update it once I'm done with all adapters.

Ok, waiting for it

Should be all done!
Check the latest release ^^
Please let me know if you run into any issues using it, it's almost impossible for me to test all possible scenarios.

Both the changelog and the README state to update pywnp

Huh? I didn't get it. Wdym?

Remember to update pywnp via pip install --upgrade pywnp

Phew, glad it worked!! DM me on discord: keifufu#0727


Always set content-length

Not setting it makes some clients unhappy.

I do understand the reason to come up with this fix, but I would suggest another way to fix it. Either we remove the None part from the function argument, or we add a check in both the .bytes() and .array() method, that adds a content-length of 0 if it is not yet set and if no Transfer-Encoding: chunked header is set. In this case the Content-Length header must be omitted.

@mfelsche i think that the "send no body" helper methods that work with content length of None (or would work with such a change) are a big boon. For something like a one shot redirect, one shouldn't have to supply bytes. I'm not sure what the best way to accomplish is while playing nice with chunked content. This seems relatively small, do you have time to take over?

I can take this over and try to ensure that all responses created have a content-length header, unless they are chunked.

awesome. thanks @mfelsche. i am sure you will do a better job than i would.


Clean mapping_ar.py mesh updated check

Requires fix in mapping API; i.e. only merge with new release.

Alternatively there could be a functions like meshUpdated() -> bool that has many if X: return false and in the end return true.


Makes sqrt more accurate by adding an extra iteration

Just curious, since very similar code exists in p_invsqrt_f32, can you quantify the increase in accuracy with this change?

@warrenm Not much, but when I was using the original code for square rooting for my code for the standard deviation function, I got quite an inaccurate result.
The original square root code got me about 0.9 when I tried and calculate the standard deviation of {1, 2, 3} as opposed to the correct result of 1 which I obtained with 3 iterations
Also, the code does work using Newton's method I believe, which converges quite significantly more accurately with each iterations.

There is no guarantee that any function will converge in 2 3 or n iterations. There should be a loop with a stop criteria, maybe the value changed by less then 1% from the last iteration.

Hmmm, the question is should you make it use the SSE instruction set?
Should PAL be compatible with machines that don't have SSE?

I think we are going to have ifdefs or different files for each architecture. I don't know for sure.
The performance gain that sse and others instruction sets have is big enough to force us to use them.

Alright, I think I'll start work on that. I'll add an ifndef into the headers for the SSE instruction set and optimise the functions to use that. I think I'll do this on separate branch and PR though as this isn't something that's exclusive to sqrt.

Although regarding looping until convergence, could that possibly result in the function taking far too long to execute? I think there should be a limit on iterations but stop iterating if it already converges before it reaches that limit.

@HenryJia I think it depends on the purpose of the library. If you look the original implementation of the Fast Inverse Square Root youll see they use one/two newton iteration because we woulnd be able to notice the diference in a game.
As you tried to apply the function to statistics, the precision was not enough for you, but 3 iterations did it.
However, if you are trying to simulate some physical fenomena and want to publish a paper, you need the best precision possible, maybe ten iterations wont be enought. I think its up to @aolofsson to define which way we should follow.


Handle grouped short-name parameters

Grouped parameters should be supported.
For example -abc should be equivalent to -a -b -c.

This issue is being closed as wontfix per #12.


Documentation issue: Typo

Describe the bug
https://bunit.egilhansen.com/docs/test-doubles/faking-auth.html#roles
On the above page, the first note does not make sense:
If your inherits directly from bUnit's TestContext as described in Writing Tests in C# for Blazor Components, then you need to call the AddTestAuthorization() method like so: this.AddTestAuthorization().
Example:
See above
Expected behavior:
Clear and concise documentation

Good catch. Let me see if I can make it more clear.

Is this better:

If your test class inherits directly from bUnit's xref:Bunit.TestContext, as described in [xref:writing-csharp-tests#remove-boilerplate-code-from-tests], then you need to call the AddTestAuthorization() method on this, since AddTestAuthorization() is an extension method, otherwise it wont be available. E.g.: this.AddTestAuthorization().

@egil ,
Looks great!


Type Accordion

@saramarcondes 👍 from me! I just had a question about one of the types:

// packages/components/src/Accordion/useAccordion.js
/** @type {import('zustand').UseStore} */

Are we not able to import @wp-g2/substate? (and substate and "infer" zustand, if that's even the right word for it, haha)

Are we not able to import @wp-g2/substate? (and substate and "infer" zustand, if that's even the right word for it, haha)

Unfortunately to do that we would have to re-export all of the types from zustand (the same way that @wordpress/element does for React's types). I don't see any value in maintaining that and there's nothing lost as far as I can tell by importing directly from zustand. Even in @wordpress/components we import from react rather than @wordpress/element for React's types.


Update connect-query-go.md

Replace
tsql := "INSERT INTO TestSchema.Employees (Name, Location) VALUES (@Name, @Location); select convert(bigint, SCOPE_IDENTITY());"
with
tsql := "INSERT INTO TestSchema.Employees (Name, Location) VALUES (@Name, @Location); "
tsql += select isNull(SCOPE_IDENTITY(), -1);"
Premise:-

One cannot assume that insert succeeded and we have a valid scope_identity

if insert failed, then scope_identity will be null

Attempt to fetch later on and cast to int64, will subsequently fail
var newID int64
err = row.Scan(&newID)

@DanielAdeniji : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@David-Engel - Hi, would you review this proposed update to your article?
Thanks.

#sign-off

Thanks!


Parent URI points to an invalid devfile

/area documentation
Which area this documentation change is related to?

/area api
Issue details

What mistake did you find / what is missing in the documentation?
The parent URI example that's given in our docs points to a v1.0 devfile.  This will cause a validation error because the mandatory schemaVersion is missing.   Please update the docs to include this URI instead https://raw.githubusercontent.com/odo-devfiles/registry/master/devfiles/nodejs/devfile.yaml

Please update the docs to include this URI instead https://raw.githubusercontent.com/odo-devfiles/registry/master/devfiles/nodejs/devfile.yaml

Slight nitpick, we shouldn't link to that repo any more since it's deprecated, the devfile from devfile/registry should be used instead: https://raw.githubusercontent.com/devfile/registry/main/stacks/nodejs/devfile.yaml

Thanks, Kim for locating this concern :)
Where in our docs to we link to https://raw.githubusercontent.com/eclipse/che-devfile-registry/master/devfiles/nodejs/devfile.yaml ?
I am going through our docs now and am not seeing where we link to this sample yaml.

Hi Jake,  it's in our parent devfile topic: https://docs.devfile.io/devfile/2.0.0/user-guide/refering-to-a-parent-devfile-in-a-devfile.html, example 2

Thanks, Kim, for the clarification!
Please see the new PR, #82, that I just made for this issue. If it's only a simple URI change, we should be good to go ahead and merge, thanks!

Thanks, Kim, for the clarification!
Please see the new PR, #82, that I just made for this issue. If it's only a simple URI change, we should be good to go ahead and merge, thanks!

Thanks @jc-berger , is the PR link incorrect?

@kim-tsao lol, not it's not. It linked to PR 82 in API, not the Doc repo.
Use this link for the doc PR that fixes the URI, thanks!
https://github.com/devfile/docs/pull/82

@jc-berger the URL update looks good but I should have noticed this other error before.  Can you please remove id from this example?  The spec says you can only specify oneof id, uri, or kubernetes

@kim-tsao , nice catch and sure thing. I think you're looking at 2.1 and not 2.2 Alpha. I don't see id in the example in our referring to parent doc. See the screenshots of the published doc and my PR.

Basically, I think the id has already been removed, phew!

@jc-berger you're right, I was looking at an older spec (v2.0.0).  Is it possible to update that version?

@kim-tsao, honestly, I don't know. I simply always specify that I'm on the latest version when I look at docs. I'll often make the mistake of looking at the outdated version.
We can ask at our team call tomorrow!


Add rsae sha384 sha512

Description

Enable rsa_pss_rsae_sha{256,384,512} support.
Add mbedtls_pk_sign_ext . only available when MBEDTLS_USE_PSA_CRYPTO is enabled.
Add unit tests for mbedtls_pk_sign_ext , not finished.

Current code is not thread-safe. we should add a thread-safe version
Status
READY

#5571 implement similar function rsa_sign_wrap , and it is ready for merge. Add #5571 as preceding PR for this.

I rebased and re-org this PR. Remove all commits not in final version.
Please re-review

@bensze01 Still ok on your side following Jerry's last commit ?


Add logic to import a machine from its extractedConfig field

@cjellick created an issue in rancherio/go-machine-service
Add logic to re-import a machine from it's extractedConfig field if that machine doesn't exist on disk.
This will allow to recover from situations where we've lost the go-machine-service's underlying disk (where docker-machine maintains state). This will also allow us to ultimately support mutli-host go-machine-service

@will-chan This one will be needed when we hammer out a fully functional HA setup for Rancher.
Where does that put it? Is it needed for beta or GA?


Update README with the link to the Telegram bot

Added a link to the Telegram bot and improved the formatting in the README.md file as requested in Issue #15

please check now @Harish-2003


Filters: Convert fieldCache object hash to a Map

fieldCache object was using HTMLNodes as keys, which get converted to strings, which aren't unique across instances of HTMLNodes, leading to some values overwriting others. Maps are restricted to strings as keys, which solves the issue (all credit to @wpears)
Changes

Convert fieldCache object to Map.

Testing

gulp test:unit should pass.
gulp clean && gulp build and test adding and applying a filter, like on /about-us/newsroom/

On hold pending merging of https://github.com/cfpb/cfgov-refresh/pull/4733


feat: add box apis

https://algorand.github.io/js-algorand-sdk/classes/Algodv2.html#getApplicationBoxByName

@youraerials
what have you learned about box storage recently?
is there an obvious way to wrap the api for use by Algonaut?


Ultra hard mode?

This code is amazing and has been very customizable to get a lot of data regarding starting words for multiple word sets, however, some sites require (or just some players like to play) in "ultra hard" mode, which, unlike regular hard mode, requires the user to also move yellows, and to not include any previous gray letters, I have been looking through the code to try to modify it to do this and I know it has something to do with the okhard function, but am not sure how to modify it for this purpose.
Any help or guidance you can give would be greatly appreciated!

Hi gwstaten. Thank you for your kind words. You are right, morally you just have to alter okhard() to return sc[j][i]==s, which enforces that new guesses are compatible with previous colour scores, but to make that work you also need to pre-calculate colour score values (fill the table sc[][]) for guess words as well as hidden words. Anyway, I added an option -U to do this in the last commit. I hope it's the behaviour you expected.

"Ultra hard" mode implemented.


Revert support for some pattern matches

Now, instead of checking for constructor and arg matching, all symbols
in a given pattern match to the entire expression provided to it. This
is necessary for the reasons provided in unsupported.md.
This is the "soft" version, where only patterns that actually depend on
the symbol are genericized.

See #2


adding get policy endpoint

Fixing https://github.com/spulec/moto/issues/2600

Coverage decreased (-0.02%) to 93.738% when pulling 625f28c88205994f59c42b4245fae54aa948c433 on mwaaas:fix/get_policy into 502957f1f9560cb6dff75271e6812498f4ff7bba on spulec:master.

Coverage decreased (-0.02%) to 93.738% when pulling 625f28c88205994f59c42b4245fae54aa948c433 on mwaaas:fix/get_policy into 502957f1f9560cb6dff75271e6812498f4ff7bba on spulec:master.


using a list/tuple of jitted functions

I'd like to be able to call an arbitrary list of jitted functions inside a function:
from numba import jit

@jit
def func(a):
    return a

functions = (func, func)

@jit(nopython=True)
def aggregate_func(a):
    for f in functions:
        f(a)

aggregate_func(0)

But I get the following error:
Truncated Traceback (Use C-c C-x to view full TB):
/home/dcole/py3env/lib/python3.5/site-packages/numba/typeinfer.py in resolve_value_type(self, inst, val)
    959         except ValueError as e:
    960             msg = str(e)
--> 961         raise TypingError(msg, loc=inst.loc)
    962
    963     def typeof_arg(self, inst, target, arg):

TypingError: Failed at nopython (nopython frontend)
Untyped global name 'functions': cannot determine Numba type of <class 'tuple'>
File "<ipython-input-30-bd470e6412ee>", line 11

OTOH, if I create the functions tuple inside the aggregate_func it works as expected:
@jit(nopython=True)
def aggregate_func(a):
    functions = (func, func)
    for f in functions:
        f(a)

Also, if the tuple consists of non identical functions, it fails again:
from numba import jit

@jit
def func(a):
    return a

@jit
def gfunc(a):
    return a

@jit(nopython=True)
def aggregate_func(a):
    functions = (func, func, func, gfunc)
    for f in functions:
        f(a)

aggregate_func(0)

But with a different error:
Truncated Traceback (Use C-c C-x to view full TB):
/home/dcole/py3env/lib/python3.5/site-packages/numba/typeinfer.py in propagate(self, raise_errors)
    765         if errors:
    766             if raise_errors:
--> 767                 raise errors[0]
    768             else:
    769                 return errors

TypingError: Failed at nopython (nopython frontend)
Internal error at <numba.typeinfer.CallConstraint object at 0x7feb72c56320>:
--%<-----------------------------------------------------------------
Traceback (most recent call last):
  File "/home/dcole/py3env/lib/python3.5/site-packages/numba/errors.py", line 243, in new_error_context
    yield
  File "/home/dcole/py3env/lib/python3.5/site-packages/numba/typeinfer.py", line 377, in __call__
    fnty = typevars[self.func].getone()
  File "/home/dcole/py3env/lib/python3.5/site-packages/numba/typeinfer.py", line 97, in getone
    assert self.type is not None
AssertionError

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/home/dcole/py3env/lib/python3.5/site-packages/numba/typeinfer.py", line 128, in propagate
    constraint(typeinfer)
  File "/home/dcole/py3env/lib/python3.5/site-packages/numba/typeinfer.py", line 379, in __call__
    self.resolve(typeinfer, typevars, fnty)
  File "/usr/lib/python3.5/contextlib.py", line 77, in __exit__
    self.gen.throw(type, value, traceback)
  File "/home/dcole/py3env/lib/python3.5/site-packages/numba/errors.py", line 249, in new_error_context
    six.reraise(type(newerr), newerr, sys.exc_info()[2])
  File "/home/dcole/py3env/lib/python3.5/site-packages/numba/six.py", line 658, in reraise
    raise value.with_traceback(tb)
  File "/home/dcole/py3env/lib/python3.5/site-packages/numba/errors.py", line 243, in new_error_context
    yield
  File "/home/dcole/py3env/lib/python3.5/site-packages/numba/typeinfer.py", line 377, in __call__
    fnty = typevars[self.func].getone()
  File "/home/dcole/py3env/lib/python3.5/site-packages/numba/typeinfer.py", line 97, in getone
    assert self.type is not None
numba.errors.InternalError:
[1] During: typing of call at <ipython-input-37-5cfd7eaa5b15> (18)
--%<-----------------------------------------------------------------

File "<ipython-input-37-5cfd7eaa5b15>", line 18

I'm guessing this simply isn't supported, so:

Is there an inherent reason why this can't be supported?
If not, can you please give me some general direction in how to make it happen and I'd try to implement it myself?

Function type is not a first class, yet.  Both the type system and runtime system do not handle first class function objects.  Functions must be statically known in the compiler.
There's a workaround though.  In the code below, I made a chain combinator that recursively builds a new function from the given list of functions.  The chain combinator must be used outside of numba.jit.  If your usecase accepts functions being defined separately first, this should help:
from numba import njit

@njit
def ident(x):
    return x

def chain(fs, inner=ident):
    head, tail = fs[-1], fs[:-1]

    @njit
    def wrap(x):
        return head(inner(x))

    if tail:
        return chain(tail, wrap)
    else:
        return wrap

@njit
def foo(x):
    return x + 1.2

@njit
def bar(x):
    return x * 2

# must be used outside of the jit
foobar = chain((foo, bar))
foobarfoo = chain((foo, bar, foo))

def test():
    return foobar(3), foobarfoo(3)

print(test())

A interesting thing happened at:

Thanks a lot @sklam !
I'm guessing it's not simple to make function types first class. Hopefully that would happen sometime soon.

@seibert is this something that could be solved on its own or can it only be done after having function types? in either case, how long do you think it would take for a knowledgeable dev to do it?


Not working in recent Unity

This seems kinda nice but doesn't show any fields or buttons for properties in Unity 2019.3.15.
Only the "External Objects" field is there and "Edit Text" button appears (clicking it doesn't change anything).
I've tried looking at it and it parses the file, recursively goes through it and also calls GUI.Button here and there. Changing a few of those to GUILayout shows buttons but with a wrong layout of course. Did the way GUI.Button etc. work change in the mean time, or rather the way rects have to be calculated?

you should call before draw any property
EditorGUILayout.GetControlRect();


DEVOPS-565: cannot find merge base when target branch is ahead

DEVOPS-565 - simplify code to list modified files for pre-commit
fetch --depth
instead of --deepen

with the original workflow code, I cannot reproduce issue from: https://github.com/MiraGeoscience/InSight/actions/runs/11845097612/job/33009802485?pr=5108
I do get the same error message if using --depth instead of --deepen
I could confirm also that origin repo is the MiraGeoscience repo and not the fork.

closing as I cannot reproduce, and fix is not a good one anyway


HTTP connection: send PSR-7 Response object

Is there any way to write a PSR-7 Response object into the connection?
Something like this:
    public function onMessage($connection, $request)
    {
        $response = new \Laminas\Diactoros\Response\JsonResponse($request->post('data'), 200);
        $connection->send($response);
    }

($response is standard PSR-7 ResponseInterface, which can be retrieved from any other way, like guzzle request)

I understand that there are not enough methods in the protocol, but there may already be ready-made wrappers or some way to do this.
It would be nice to be able to convert PSR-7 Response to Workerman Response object like Response::fromPSR7($response)

\Workerman\Protocols\Http\Response
    /**
     * @param \Psr\Http\Message\ResponseInterface $response
     * @return static
     */
    public static function fromPSR7($response) {
        return new static($response->getStatusCode(), $response->getHeaders(), $response->getBody());
    }

https://github.com/walkor/workerman/issues/51#issuecomment-684685099
Hope this link will help you.


Lint against unexpected cfgs in [target.'cfg(...)']

What does this PR try to resolve?
Since https://github.com/rust-lang/cargo/pull/13571, we now lint by default on unexpected cfgs in Rust code, but one area that is missing are cfg expressions in Cargo.toml and .cargo/config.toml. This PR address this missing piece by (unstably) introducing -Zcheck-target-cfgs based on rustc --print=check-cfg.
The feature voluntarily does not always follow RUSTFLAGS (to avoid mistakes with one-off and for consistency) but instead follows Rust unexpected_cfgs lint configuration:
[target.'cfg(foo)'.dependencies] # will not get linted about
cfg-if = "1.0"

[lints.rust.unexpected_cfgs]
level = "warn"
check-cfg = ['cfg(foo)'] # because it's mark as expected here

In terms of implementation, one global --print=check-cfg is retrieved and fetched, packages that have their own check-cfg inputs have each their own --print=check-cfg, otherwise the expected cfgs will get mixed up. Each --print=check-cfg is cached and only done if necessary.
How should we test and review this PR?
As asked I tried putting everything into small commits, they may not reflect the de-coupling possible as they follow the implementation but they are still IMO very useful. However I strongly recommand doing a first-pass of the complete diff first.
In terms of tests, I added some combinations that I though would be useful, I can add more if desired.
Additional information
Documentation for --print=check-cfg. It was one of motivation of the compiler MCP https://github.com/rust-lang/compiler-team/issues/743.
r? @epage

This probably could have used a conversation with the Cargo team first to ensure alignment with where we are going with lints.  If there are questions about the direction I'm pointing this towards, feel free to reach out!

:umbrella: The latest upstream changes (presumably #14630) made this pull request unmergeable. Please resolve the merge conflicts.

:umbrella: The latest upstream changes (presumably #14137) made this pull request unmergeable. Please resolve the merge conflicts.

:umbrella: The latest upstream changes (presumably #14752) made this pull request unmergeable. Please resolve the merge conflicts.

:umbrella: The latest upstream changes (presumably ed31dad4307145f82a17eebe56a17a4d801a3382) made this pull request unmergeable. Please resolve the merge conflicts.

:umbrella: The latest upstream changes (presumably 88edf01fe39d6d15c8e15dbf4ea478661b7b85e3) made this pull request unmergeable. Please resolve the merge conflicts.

:umbrella: The latest upstream changes (presumably 10c255ad07766377c269058d40405bc17d79b50e) made this pull request unmergeable. Please resolve the merge conflicts.


feat: Platform integration tests

Still WIP!

[ ] Add tests to play audio simultaneously

@luanpotter would you mind, checking the ios / macos implementation. It seems like position is not reset to the start of the audio sample.
https://github.com/bluefireteam/audioplayers/runs/6922921075?check_suite_focus=true#step:8:326
Thank you :)

@Gustl22 thanks for all the contributions!
I tested ios/macos locally. The issue apparently is that calling setSource is causing the audio do start playing, even before resume is called.
So when you try to check the position on the position tab, it is actually the end position.
I will am looking at why and exploring a fix!

This should fix it! https://github.com/bluefireteam/audioplayers/pull/1206
I ran the test locally on macos with that change. It only thing that did not work was the m3u8 stream, but I suspect might be a compat issue? Does that even work normally?
btw -- can't stress this enough --, these tests are awesome!

Nice thank you for taking care of that!
Unfortunately I don't know which file formats are supported on iOS / Mac (if you mean that by "working normaply".
But it also doesn't work for web and the according test can be easily disabled via
hasPlaylistSourceType :)


Enabling other container tools then docker

I find this script highly useful. As we are also using other docker cmd capable tools out there, like Podman or Finch, I want to adapt the script to be able to supply a docker/oci capable tool here.
I tested with docker the import export. However the save / load does not yet work, as the output of "$CONTAINER ps -lq" exists only in docker and Podman has others.
Still the base is working.

Also I found there was a typo in your latest script @Guiorgy
It was in the fulldirname function.

Any update on the review?
@Guiorgy, @BretFisher

We probably should wait for someone to test this on Finch just in case before considering merging, less we want a repeat of ;& ;P

I can try this one on finch, have it running as well. I'll need to plan this in, so maybe 1-2 days.

@Guiorgy It seems that the readlink call with option -m is not supported, and it looks like doing it mit -f solves the problem.
https://stackoverflow.com/questions/59895/how-do-i-get-the-directory-where-a-bash-script-is-located-from-within-the-script

@Guiorgy : I did with the latest version do a test with Finch and Podman on macOS 14.7.1 on a MacBook Pro M1 Pro.
Can you test on a linux system whether it works there with finch and podman as well?

From man pages:

The -f option found in many implementations was not included, as the realpath utility provides equivalent functionality with a choice of behaviors.
The realpath utility was added in preference to a -f option found in some implementations of the readlink utility ...

Can you try realpath instead? Might be better to use that.
Also, please refrain from modifications that fall outside the intent of this PR, like #!/bin/bash -> #!/usr/bin/env bash. Than should be a separate PR, so Bret can choose whether to include a subset of the changes.

Any upate here?


Interrupts on Cortex-M do not work with CONFIG_MULTITHREADING=n

Describe the bug
When CONFIG_MULTITHREADING=n then interrupts are initially disabled (see bug #8393) when they are enabled then usage fault happens immediately (seems that it happens during returning from interrupt).
To Reproduce
Steps to reproduce the behavior:

modify hello_world:

void main(void)
{
        /* enable interrupts */
	irq_unlock(0);
	printk("Hello World! %s\n", CONFIG_BOARD);
        /* wait for interrupt coming from LF clock being started. */
	k_busy_wait(1000000);

}

prj.conf:
CONFIG_MULTITHREADING=n
CONFIG_LOG=y

buid and run. I used nrf52840dk_nrf52840 board
See error

*** Booting Zephyr OS build zephyr-v2.3.0-979-ga043d48c5472  ***
[00:00:02.426,116] <err> os: ***** USAGE FAULT *****
[00:00:02.426,116] <err> os:   Illegal load of EXC_RETURN into PC
[00:00:02.426,116] <err> os: r0/a1:  0x00000004  r1/a2:  0x00000001  r2/a3:  0x00000001
[00:00:02.426,116] <err> os: r3/a4:  0x00000000 r12/ip:  0x00000020 r14/lr:  0x000029db
[00:00:02.426,116] <err> os:  xpsr:  0x00000000
[00:00:02.426,147] <err> os: Faulting instruction address (r15/pc): 0xe000ed00
[00:00:02.426,147] <err> os: >>> ZEPHYR FATAL ERROR 0: CPU exception on CPU 0
[00:00:02.426,147] <err> os: Current thread: 0x00000000 (unknown)
[00:00:03.378,143] <err> os: Halting system

Expected behavior
No error should appear.
Impact
Interrupts cannot be used when multithreading is off. User cannot use any driver (even out of tree which does not use kernel synchronization apis).
Environment (please complete the following information):

Commit a043d48c54726082521f3e335d807dc649cc02f3

Note that #26372 was probably failing because of that, too (apart from kernel API usage).

@nordic-krch what is the root cause of the usage fault? won't CONFIG_LOG=y require multithreading by default? could you test with something that doesn't require threads at all? Because I remember that I was able to enable interrupts with irq_lock(0) and then use interrupts without a problem with multithreading disabled.

I was seeing the same issue yesterday when trying to use I2C functions from main() without a separate thread whilst creating/integrating a driver, trace is as follows:
*** Booting Zephyr OS build zephyr-v2.0.0-8735-g2f1d9dded535  ***
[00:00:00.009,857] \1b[1;31m<err> os: ***** USAGE FAULT *****\1b[0m
[00:00:00.015,533] \1b[1;31m<err> os:   Illegal load of EXC_RETURN into PC\1b[0m
[00:00:00.022,308] \1b[1;31m<err> os: r0/a1:  0xb672b501  r1/a2:  0x6a104a0b  r2/a3:  0xbf1e2800\1b[0m
[00:00:00.031,005] \1b[1;31m<err> os: r3/a4:  0x62112100 r12/ip:  0xf9c2f007 r14/lr:  0xf3efb662\1b[0m
[00:00:00.039,703] \1b[1;31m<err> os:  xpsr:  0xea4f0000\1b[0m
[00:00:00.044,952] \1b[1;31m<err> os: Faulting instruction address (r15/pc): 0xf1a08005\1b[0m
[00:00:00.052,856] \1b[1;31m<err> os: >>> ZEPHYR FATAL ERROR 0: CPU exception on CPU 0\1b[0m
[00:00:00.060,699] \1b[1;31m<err> os: Current thread: 0x00000000 (unknown)\1b[0m
[00:00:00.067,474] \1b[1;31m<err> os: Halting system\1b[0m

@carlescufi with CONFIG_LOG_MINIMAL=y i see the same issue and I think that error comes from clock interrupt (when LF clock is ready). Could it be serial recovery turns on multithreading?

@carlescufi with CONFIG_LOG_MINIMAL=y i see the same issue and I think that error comes from clock interrupt (when LF clock is ready). Could it be serial recovery turns on multithreading?

No, it does not. I just checked: disabled logging and built with CONFIG_MCUBOOT_SERIAL and CONFIG_MULTITHREADING remains disabled.

@de-nordic and @nvlsianpu can you confirm that serial recovery is fully functional in mcuboot and that it keeps CONFIG_MULTITHREADING disabled?

@carlescufi  I will look at this today and let you know.

@carlescufi the CONFIG_MULTITHREADING is still disabled, but serial recovery does not work with latest master commit (75949f470f56161e1c6708193384d5e4d32f3f2f at the time I am writing this).
I have enabled it for test purposes and then it worked.
Tested on nrf52840dk_nrf52840.

@de-nordic thanks.

I have enabled it for test purposes and then it worked.
You mean you enabled CONFIG_MULTITHREADING right?

In this case, I think we need to find out whether it's GPIO or UART that are making use of multithreading, or if it's something else entirely.

In this case, I think we need to find out whether it's GPIO or UART that are making use of multithreading, or if it's something else entirely.

@carlescufi do you want me to check it?

In this case, I think we need to find out whether it's GPIO or UART that are making use of multithreading, or if it's something else entirely.

@carlescufi do you want me to check it?

Sure, yes please @de-nordic since we are at it.

@nordic-krch this commit introduced the regression.

Waiting for @nordic-krch input on the  https://github.com/zephyrproject-rtos/zephyr/commit/2881df3d0cb329452fbe32da6f9b368a82366888, but I am afraid that the change might have uncovered the issue rather than introduce it.
I have tried to pinpoint exact location where the failt is triggered, in mcuboot, and I have found out that it would happen (for me) on second invocation of boot_serial_start:595, call f->read(...), but when I have tried to step it (si) in gdb disassembly, I could basically put rock on the enter key and the issue would never happen.

@carlescufi @de-nordic @nordic-krch This issue caught my attention and I took a quick deeper look. I think the problem lies in incorrect configuration of stack pointer registers when CONFIG_MULTITHREADING is disabled.
Thread mode is configured to use PSP here:
https://github.com/zephyrproject-rtos/zephyr/blob/3bc6c555a51888b5996d06f68f7b65892a9c79e2/arch/arm/core/aarch32/cortex_m/reset.S#L95-L98
Because further initialization is done this way:
https://github.com/zephyrproject-rtos/zephyr/blob/7d90812f265c0d23bad904434cef9c1616ba08ad/kernel/init.c#L475-L479
PSP is not reconfigured to the top of the main stack by this code that is called from switch_to_main_thread():
https://github.com/zephyrproject-rtos/zephyr/blob/4c673395718e862949a6c153214662fbc92cd479/arch/arm/core/aarch32/thread.c#L430-L438
and after initialization is finished, PSP points to the same stack as MSP, just a little below MSP. Then, if an interrupt routine uses the stack (pointed by MSP) more intensively, it can overwrite the values stacked there on the exception entry (using PSP) and the return from exception may fail in various ways (most likely with UsageFault). But if all interrupt routines don't use too much stack, everything can work correctly for quite a long time. As @de-nordic already signaled:

Waiting for @nordic-krch input on the 2881df3, but I am afraid that the change might have uncovered the issue rather than introduce it.

And it seems this issue may occur on all Cortex-M SoCs. I'm not sure who would be the best person to look at this problem.

@anangl thanks for the extensive analysis!

And it seems this issue may occur on all Cortex-M SoCs. I'm not sure who would be the best person to look at this problem.

@ioannisg should be able to look at this.

@anangl thanks!

@anangl thanks for the study you did - it's half of the work already :)

Using #27136 on current master I've confirmed broken CONFIG_MULTITHREADING=n support on:

nucleo_l476rg (program dies after BOOT_BANNER)
nrf52840dk_nrf52840 (program runs, but once interrupt fires everything stops)
frdm_k64f (program dies after BOOT_BANNER)

Clearly CONFIG_MULTITHREADING=n is a poorly tested configuration, and the failure is not Nordic-specific.
With this patch using master button test (and default CONFIG_MULTITHREADING=y) all platforms pass.
With #27136 (CONFIG_MULTITHREADING=n) this PR on current master all platforms pass, so functional checks look good.  Review incoming.

Hi
I am having the same problem with STM32L072 + SX1276 (Zephyr /samples/subsys/lorawan/class_a
[00:00:00.200,000]  sx127x: SX127x version 0x12 found
[00:00:00.302,000]  lorawan_class_a: Joining network over OTAA
[00:00:00.315,000]  os: ***** HARD FAULT *****
[00:00:00.315,000]  os: r0/a1:  0x000000fd  r1/a2:  0x000000f4  r2/a3:  0x00000041
[00:00:00.315,000]  os: r3/a4:  0x000000f1 r12/ip:  0x000000ae r14/lr:  0x00000098
[00:00:00.315,000]  os:  xpsr:  0x00000000
[00:00:00.315,000]  os: Faulting instruction address (r15/pc): 0x00000046
[00:00:00.315,000]  os: >>> ZEPHYR FATAL ERROR 0: CPU exception on CPU 0
[00:00:00.315,000]  os: Current thread: 0x20000740 (unknown)
[00:00:00.379,000]  os: Halting system

@tcpipchip You are probably trashing memory

yes, looks stack memory!

memory trashing solved! Stack size redefined on prj.conf
Do you know how to define the SUB-BANDS of AU915 ?
int lorawan_set_datarate(enum lorawan_datarate dr)
Right ?
Thanks!


Good First Issue - Update Footer Styling

Description
Using the header as a reference, style the footer to look the same.
Add any placeholder content you see fit.

Hi @Curtis-Thomas,
I will add to this shortly.
Thank you. 🙏

Hi @Curtis-Thomas,
Added myself to the contributors
https://github.com/Curtis-Thomas/free-api-list-with-react/pull/49


Combine bugzilla queries to speed up startup

query all known bugs for each feature
query all dependencies received for the bugs from 1st. query

@wfwalker has experience using the bugzilla search API, as it fails by default when hitting secure bugs.

Resolved by #150


High P-Code's CBRANCH is often incorrect

Discussed in https://github.com/NationalSecurityAgency/ghidra/discussions/4944
Describe the bug
As stated in an earlier issue, the CBRANCH instruction often has incorrect arguments. The problem is also described in more detail in Section 3 of this article.
To Reproduce
Please refer to this issue
Expected behavior
From a conversation with the Ghidra team and the earlier issue, it seems like this is intended behavior. I myself find it puzzling that this choice has been made. I think it would be good to further discuss this issue. At the very least, the documentation should be updated with a warning that the CBRANCH instruction's arguments are unreliable.

ActionNormalizeBranches of action name "normalizebranches" does pcode transformation in-place in a way the reporter of above issues suspect that the transformed pcode is a bit odd and need to be addressed.
But that's not true. and the referenced article doesn't even address which extra information of high pcode handled in decompiler even the author mentioned it. Kinda weird in some perspective like `Who benefits from omitting such non-trivial breakthrough?'
I want to name extra information added in high pcode as clever trick and I think those tricks found in the source code is reasonable trade-off for addressing complexity of tasks in a tolerable range.
In this point, I think the title of this issue is better to renamed as "Rework decompiler to get rid of extra information of high pcode thoroughly to match the definition of referenced paper"

I'm not sure I understand your comment @homes410 . Perhaps a code example further clarifies the issues with CBRANCH I've run into.
100000f10
(unique, 0xd300, 1) INT_SLESS (const, 0x2, 4) , (register, 0x38, 4)
(unique, 0x10000052, 4) COPY (register, 0x38, 4)
 ---  CBRANCH (ram, 0x100000f37, 1) , (unique, 0xd300, 1)
100000f37
(stack, 0xffffffffffffffec, 4) COPY (const, 0x0, 4)
...

In the high P-Code above, the CBRANCH will always jump to block 100000f37, if the condition holds, or due to fall though. Looking at Ghidra's control flow information, for this example it is actually the case that if the condition does not hold, we should jump to block 100000f99. As described in the paper, I've also seen cases where the true branch is incorrect.
I'm in no way trying to get rid of information, or requesting that Ghidra adheres to any definition that I made. I think it is important that users are aware of the fact that the CBRANCH might display unexpected addresses.

This should certainly be clarified in our documentation.
Just to verify:  the issue is only with the inputs to the CBRANCH op?  The  corresponding branch in the C code produced by the decompiler is correct?

I'm going to close this ticket and treat the issue as a special case of #4945


As a receptionist, I want to enqueue a patient based on his NRIC so that I don't have to scroll through the displayed patient list to look for patient's index.

is this a user story or a task or feature?


Obj Inspector - Nav tree filter drop down too narrow

Currently the filter  combo box is to narrow and cuts off the names of the objects to filter

Fixed in 2021.3.12


Hello, friend!I used a pre-deployment term -- Visualize - ranks. Why did the test report a failure of query_flip and Gallery_flip

Do you know what it is?thank you

File "train_multi.py", line 132, in main
performance, dm.return_testdataset_by_name(name),
File "E:\jpf\ABD-Net.next-master\ABD-Net.next-master\torchreid\data_manager.py", line 33, in return_testdataset_by_name
self.testdataset_dict[name]['query_flip'], self.testdataset_dict[name]['gallery_flip']
KeyError: 'query_flip'

Hi friend.
I refer to the answer in our supplement https://openaccess.thecvf.com/content_ICCV_2019/supplemental/Chen_ABD-Net_Attentive_but_ICCV_2019_supplemental.pdf. (The last paragraph of the section2.)
I also attach it here:
During testing, the images are re-sized to 384 × 128 and augmented only with normalization.
Thanks for your interest!


Update sbt-izumi to 0.0.87

Updates io.7mind.izumi.sbt:sbt-izumi from 0.0.83 to 0.0.87.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Files still referring to the old version number
The following files still refer to the old version number (0.0.83).
You might want to review and update them manually.
build.sbt
project/Deps.sc

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "io.7mind.izumi.sbt", artifactId = "sbt-izumi" } ]

labels: sbt-plugin-update, early-semver-major, semver-spec-patch, old-version-remains

Superseded by #299.


[Error126] Module not found- windows OS issue

Expected Behavior
Can launch bot
Actual Behavior
On windows OS throws:

Traceback (most recent call last):
File "C:\Users\Kert\Desktop\PokemonGo-Bot-dev\PokemonGo-Bot-dev\pokecli.py", line 501, in
main()
File "C:\Users\Kert\Desktop\PokemonGo-Bot-dev\PokemonGo-Bot-dev\pokecli.py", line 130, in main
report_summary(bot)
File "C:\Users\Kert\Desktop\PokemonGo-Bot-dev\PokemonGo-Bot-dev\pokecli.py", line 139, in report_summary
metrics.capture_stats()
File "C:\Users\Kert\Desktop\PokemonGo-Bot-dev\PokemonGo-Bot-dev\pokemongo_bot\metrics.py", line 76, in capture_stats
response_dict = request.call()
File "C:\Users\Kert\Desktop\PokemonGo-Bot-dev\PokemonGo-Bot-dev\pokemongo_bot\api_wrapper.py", line 106, in call
result = self._call()
File "C:\Users\Kert\Desktop\PokemonGo-Bot-dev\PokemonGo-Bot-dev\pokemongo_bot\api_wrapper.py", line 63, in _call
return PGoApiRequest.call(self)
File "c:\users\kert\desktop\pokemongo-bot-dev\pokemongo-bot-dev\src\pgoapi\pgoapi\pgoapi.py", line 210, in call
request.activate_signature(lib_path)
File "c:\users\kert\desktop\pokemongo-bot-dev\pokemongo-bot-dev\src\pgoapi\pgoapi\rpc_api.py", line 85, in activate_signature
self.signature_lib = ctypes.cdll.LoadLibrary(lib_path)
File "C:\Python27\lib\ctypes_init.py", line 440, in LoadLibrary
return self.dlltype(name)
File "C:\Python27\lib\ctypes_init.py", line 362, in init
self._handle = _dlopen(self._name, mode)
WindowsError: [Error 126] The specified module could not be found

Steps to Reproduce
Run pokecli.py on windows 10
Other Information
Was working ok with old API

#2780


add support for mongodb+srv URIs and TLS

Proposed changes:

adds support for mongodb+srv:// URIs, simply by adding dnspython

Fixes #3971 and #2968

Status (please check what you already did):

[x] made PR ready for code review
[x] updated the changelog

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Awesome! Thank very much for this PR, I'll ask @wochinge for a review as he knows much more about Docker than I do.

thanks for your pr @ortsaCniveK !

alright, it's updated @wochinge :smile:

awesome! and a changelog update would be great! then we are done 🎈 🎉

Added to 1.1.17, didn't quite make the cut for 1.1.16 :grin:

@wochinge Just double checked and was having trouble with connecting to mongodb using the new URIs, but it seems the requirements.txt changes were overwritten -- did you need me to update the PR?

@ortsaCniveK Super weird, why this is not there any more 💥 Even checked git blame, but nothing there. @tmbo Any idea what happened here?

Yes found it: regression got accidentally introduced in this PR https://github.com/RasaHQ/rasa/pull/4020/files - we need to readd to requirements.

In any case, this should really be changed in setup.py as well


Process all output lines from modules with interval property

Suppose my custom module is based on a long-running script.  will show-up in waybar, I will never see "answer: 42".
If I remove the interval property, then waybar correctly shows "loading..." and then changes to "answer: 42", but it expects my script to loop in itself.
Even if I wrap my script in while true; do .....; sleep 1200; done, then I would not be able to refresh it manually via pkill.
I would expect that waybar processes all lines containing JSON output when I have the interval property, not only the first line.

Should be good with #634, you must use restart-interval instead of interval.
Can you try?

Thanks for your work!
Running latest master, with the above config but restart-interval instead of interval I'm consistently getting a coredump of waybar process at the end of sleep 5s. So at first waybar shows "loading..." for five seconds, then crashes.
Process 1646602 (waybar) of user 1000 dumped core.

Stack trace of thread 1646979:
#0  0x00007f012327fce5 raise (libc.so.6 + 0x3bce5)
#1  0x00007f0123269857 abort (libc.so.6 + 0x25857)
#2  0x00007f012362481d _ZN9__gnu_cxx27__verbose_terminate_handlerEv (libstdc++.so.6 + 0x9681d)
#3  0x00007f01236312ca _ZN10__cxxabiv111__terminateEPFvvE (libstdc++.so.6 + 0xa32ca)
#4  0x00007f0123631337 _ZSt9terminatev (libstdc++.so.6 + 0xa3337)
#5  0x00007f012363159e __cxa_throw (libstdc++.so.6 + 0xa359e)
#6  0x00007f012362444c _Znwm (libstdc++.so.6 + 0x9644c)
#7  0x000055914fce91ee _ZNSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEE12_M_constructIPcEEvT_S7_St20forward_iterator_tag (waybar + 0x3c1ee)
#8  0x000055914fd0402b n/a (waybar + 0x5702b)
#9  0x000055914fcea641 n/a (waybar + 0x3d641)
#10 0x00007f012365db24 execute_native_thread_routine (libstdc++.so.6 + 0xcfb24)
#11 0x00007f012341346f start_thread (libpthread.so.0 + 0x946f)
#12 0x00007f01233433d3 __clone (libc.so.6 + 0xff3d3)

Stack trace of thread 1646602:
#0  0x00007f01239872c1 g_signal_emit_valist (libgobject-2.0.so.0 + 0x232c1)
#1  0x00007f01239886b0 g_signal_emit (libgobject-2.0.so.0 + 0x246b0)
#2  0x00007f0123fcc2be n/a (libgtk-3.so.0 + 0x35c2be)
#3  0x00007f01239870a0 g_signal_emit_valist (libgobject-2.0.so.0 + 0x230a0)
#4  0x00007f01239886b0 g_signal_emit (libgobject-2.0.so.0 + 0x246b0)
#5  0x00007f0123c0703b n/a (libgdk-3.so.0 + 0x9103b)
#6  0x00007f0123c1597c n/a (libgdk-3.so.0 + 0x9f97c)
#7  0x00007f01238a2684 n/a (libglib-2.0.so.0 + 0x66684)
#8  0x00007f01238a788f g_main_context_dispatch (libglib-2.0.so.0 + 0x6b88f)
#9  0x00007f01238a9831 n/a (libglib-2.0.so.0 + 0x6d831)
#10 0x00007f01238a9871 g_main_context_iteration (libglib-2.0.so.0 + 0x6d871)
#11 0x00007f0123a602de g_application_run (libgio-2.0.so.0 + 0x9d2de)
#12 0x000055914fcd5d68 n/a (waybar + 0x28d68)
#13 0x000055914fcd4cc7 main (waybar + 0x27cc7)
#14 0x00007f012326b023 __libc_start_main (libc.so.6 + 0x27023)
#15 0x000055914fcd6c8e n/a (waybar + 0x29c8e)

Stack trace of thread 1646621:
#0  0x00007f0123338abf __poll (libc.so.6 + 0xf4abf)
#1  0x00007f01238a97a0 n/a (libglib-2.0.so.0 + 0x6d7a0)
#2  0x00007f01238a9871 g_main_context_iteration (libglib-2.0.so.0 + 0x6d871)
#3  0x00007f01238a98c2 n/a (libglib-2.0.so.0 + 0x6d8c2)
#4  0x00007f0123880e71 n/a (libglib-2.0.so.0 + 0x44e71)
#5  0x00007f012341346f start_thread (libpthread.so.0 + 0x946f)
#6  0x00007f01233433d3 __clone (libc.so.6 + 0xff3d3)

Stack trace of thread 1646976:
#0  0x00007f012341d9bc recv (libpthread.so.0 + 0x139bc)
#1  0x000055914fd22fb0 n/a (waybar + 0x75fb0)
#2  0x000055914fd23674 n/a (waybar + 0x76674)
#3  0x000055914fd23d55 n/a (waybar + 0x76d55)
#4  0x000055914fcea641 n/a (waybar + 0x3d641)
#5  0x00007f012365db24 execute_native_thread_routine (libstdc++.so.6 + 0xcfb24)
#6  0x00007f012341346f start_thread (libpthread.so.0 + 0x946f)
#7  0x00007f01233433d3 __clone (libc.so.6 + 0xff3d3)

Stack trace of thread 1646622:
#0  0x00007f012333df8d syscall (libc.so.6 + 0xf9f8d)
#1  0x00007f012385913b g_cond_wait_until (libglib-2.0.so.0 + 0x1d13b)
#2  0x00007f01238d87e3 n/a (libglib-2.0.so.0 + 0x9c7e3)
#3  0x00007f01238d89d4 g_async_queue_timeout_pop (libglib-2.0.so.0 + 0x9c9d4)
#4  0x00007f012387e58a n/a (libglib-2.0.so.0 + 0x4258a)
#5  0x00007f0123880e71 n/a (libglib-2.0.so.0 + 0x44e71)
#6  0x00007f012341346f start_thread (libpthread.so.0 + 0x946f)
#7  0x00007f01233433d3 __clone (libc.so.6 + 0xff3d3)

Stack trace of thread 1646624:
#0  0x00007f0123338abf __poll (libc.so.6 + 0xf4abf)
#1  0x00007f01238a97a0 n/a (libglib-2.0.so.0 + 0x6d7a0)
#2  0x00007f01238a9871 g_main_context_iteration (libglib-2.0.so.0 + 0x6d871)
#3  0x00007f0124bd7e5e n/a (libdconfsettings.so + 0x4e5e)
#4  0x00007f0123880e71 n/a (libglib-2.0.so.0 + 0x44e71)
#5  0x00007f012341346f start_thread (libpthread.so.0 + 0x946f)
#6  0x00007f01233433d3 __clone (libc.so.6 + 0xff3d3)

Stack trace of thread 1646975:
#0  0x00007f012341d9bc recv (libpthread.so.0 + 0x139bc)
#1  0x000055914fd22fb0 n/a (waybar + 0x75fb0)
#2  0x000055914fd23674 n/a (waybar + 0x76674)
#3  0x000055914fd28605 n/a (waybar + 0x7b605)
#4  0x000055914fcea641 n/a (waybar + 0x3d641)
#5  0x00007f012365db24 execute_native_thread_routine (libstdc++.so.6 + 0xcfb24)
#6  0x00007f012341346f start_thread (libpthread.so.0 + 0x946f)
#7  0x00007f01233433d3 __clone (libc.so.6 + 0xff3d3)

Stack trace of thread 1646623:
#0  0x00007f0123338abf __poll (libc.so.6 + 0xf4abf)
#1  0x00007f01238a97a0 n/a (libglib-2.0.so.0 + 0x6d7a0)
#2  0x00007f01238aa843 g_main_loop_run (libglib-2.0.so.0 + 0x6e843)
#3  0x00007f0123a1cdf8 n/a (libgio-2.0.so.0 + 0x59df8)
#4  0x00007f0123880e71 n/a (libglib-2.0.so.0 + 0x44e71)
#5  0x00007f012341346f start_thread (libpthread.so.0 + 0x946f)
#6  0x00007f01233433d3 __clone (libc.so.6 + 0xff3d3)

Can you retry with my latest commit?
Otherwise, if it still doesn't work, you'll have to wait, cause i can't test right now 😄

It still segfaults when the script finishes 🙂
#!/bin/sh

printf '{"text":"1"}\n'
sleep 3s

printf '{"text":"2"}\n'
sleep 3s

printf '{"text":"3"}\n'

Will show 1, then 2, then segfault.
I'll wait, no worries 😉 Thank you so much for your help!

Restart interval fixed on master 7b4ded306b5e2d2123811578395e304f56f9eb66 😃

Thanks! It's better, but unfortunately my full example from the first message is not working entirely as expected.
I'll paste here the snippets again, to include e.g. introduction of restart-interval:
"custom/task": {
  "exec": "waybar-task",
  "return-type": "json",
  "signal": 9,
  "on-click-right": "pkill -RTMIN+9 -x waybar",
  "restart-interval": 15
},

#!/bin/sh

printf '{"text":"loading..."}\n'

sleep 5s # simulates some long-running job...

printf '{"text":"done"}\n'

sleep 5s # simulates some long-running job...

printf '{"text":"very done"}\n'

When I launch waybar, it indeed shows "loading" for 5s, then changes to "done" for another 5s, and then finally becomes "very done". However after 5s I expect it to restart, to change again to "loading" - this doesn't happen, it just gets stuck on "very done".
Furthermore, if I right click on the module to force refresh, it will first go to "loading" again, then to "done", and then instead of going to "very done" it will just crash, and in the waybar logs I will receive the following:
[2020-05-24 22:33:58.313] [error] task stopped unexpectedly, is it endless?

I also encountered this issue.
Looking at the code, I think restart-interval is implemented incorrectly. I would expect it to work in the following way:
1. task is executed and each output gets displayed on the bar
2. task is done -> thread sleeps for $restart-interval seconds
3. after sleeping, task is restarted

The way it actually works right now is:
1. task is executed and each output gets displayed on the bar
2. task is done -> task is immediately restarted, while the thread sleeps for $restart-interval seconds and not actually reading the task output
3. after sleeping, the task output is read again, only using the latest output and skipping all the that were printed while the thread slept

Maybe I'm missing something, but the current implementation doesn't make sense to me. I think both @maximbaz and me expect it to have the implementation I mentioned first.
@Alexays Let me know if I'm correct here or if I'm missing something. I'd be happy to make a pull request to fix this.

Yeah you right @tamirzb, I must have made a mistake somewhere.
If you can do a PR go ahead, otherwise i'll check it soon 😃

Thank you, I confirm that it works perfectly well now 👍


add a ServiceMonitor to scrape RedPanda metrics

Fixes #149

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

not sure what to do with the failed check... ?

It's not a required check. It fails if there are any changes to the values files to ensure no accidental changes are merged.
Looks good, thanks!


[Breaking all] Gestalt v7 re-integration....

Contains
Re-integration gestaltv7
Changing engine module to package module.
Update gestalt to 7.0.5
Update gson to 2.8.5
Update TeraNui to 2.0.0
To be continiue...
Fixes #2445
Testing

Run Client [ ]
Run Server [ ]
Mix modules - source, binary, downloadable in from server, downloadable from maven [ ]
Check overrides/deltas assets. [ ]
Check everything :(

Outstanding before merging

[X] Engine compiles and runs.
[ ] Reimplement in-game module downloading.
[ ] Check and fix from server module downloading.
[ ] Check and fix Assets.
[ ] Check and fix module loading.
[ ] Check and fix whitelist.
[ ] Check and fix assets reloading.
[ ] Check and fix assets disposables.
[ ] Check and fix
[ ] Fix tests.
[ ] Update module space

Linked PRs
https://github.com/MovingBlocks/TeraNUI/pull/27

Why was moving things from org.terasology to org.terasology.engine necessary? It'll probably conflict with every other PR un a way that'll be awkward to fix, and the majority of module PRs too, and it makes it harder to find the actual changes in this PR to review it. Github isn't even able to detect the files a moved. Is there really no other way to do this?

Why was moving things from org.terasology to org.terasology.engine necessary? It'll probably conflict with every other PR in a way that'll be awkward to fix, and the majority of module PRs too, and it makes it harder to find the actual changes in this PR to review it. Github isn't even able to detect the files a moved. Is there really no other way to do this?

Gestalt v7 haven't classpath modules now (which works via detects ProtectedDomain of module.txt file).
Gestalt v7 uses packageModule now. It is more clean solution, really.
If I move package module back - then all classes(module's too) will be owned by engine.
I will mark changes in PRs.
99% chages not harmles and not affect functionality.

oh geez, how am I going to review this. I'm guessing it'll be a matter of looking at some specific commits, instead of the whole batch, and/or doing a diff of some specific sub-packages?
suggestions of which packages to look at? Just as a wild guess based on what I think gestalt does: persistence, reflection, core.module? anything else?

Commit still works :D
Functional changes:
https://github.com/MovingBlocks/Terasology/pull/4144/files#diff-d068a678d72605ebbfab1729d1d8df29   -  module
https://github.com/MovingBlocks/Terasology/pull/4144/files#diff-f79fded56bde13b73bbe93b818ff82f0R116-R145 - assets registering ( also several places with this chages )
https://github.com/MovingBlocks/Terasology/pull/4144/files#diff-873dc4d71db70d570c73ef0cb16a8731 - don't remove reflections after jar and reflections creates after classes ( modules)
https://github.com/MovingBlocks/Terasology/pull/4144/files#diff-1d22d9382cea237552a9f1e8e4485485 - don't remove reflections after jar and reflections creates after classes ( engine)
https://github.com/MovingBlocks/Terasology/pull/4144/files#diff-67cbca108af193bf1168895cb5237cfb - reimplement ModuleListDownloader (gestalt removed BaseModule and change ModuleMetadataJsonAdapater)
https://github.com/MovingBlocks/Terasology/pull/4144/files#diff-3e66f8ef304d0b5861aa3140ee518680 - remove ShrinkWrapFileSystem (Gestalt works only with Files instead Paths now - android compabality) (P.S. assets registring too)
https://github.com/MovingBlocks/Terasology/pull/4144/files#diff-1a57b96a1b0e27812cb3ca32cd8c8415R161-R162 - autoReload assets on EnvironmentSwitch - assetManager AutoReloadableAssetManager.
https://github.com/MovingBlocks/Terasology/pull/4144/commits/3e3faafd94fca0d5600e7bc15f5ef62df6a58dfa - nui syntetic module
https://github.com/MovingBlocks/Terasology/pull/4144/commits/b95028be2eaf96b8c9320663930f5b70142043bb - fix nui in UI assets
https://github.com/MovingBlocks/Terasology/pull/4144/files#diff-4e37f88c0233a3735d64003821a290baR119 - Replace module.IsSourceModule to this. gestaltv7 haven't this property.
https://github.com/MovingBlocks/Terasology/pull/4144/files#diff-9a8352c29b8e1414f20de160f54c8795 - Unittest package module now.


Contruct + Call Signature for Child React Components in TypeScript JSX

Can someone give a real world gist or example for how to legitimately link up a child component using a similar stack to what is provided in the ReactReduxSpa JavaScript Services Sample?
I am currently hitting errors of not having a construct or call signature no matter how I go about it.
Addressing those errors in some hacky ways, I am then hitting errors when exporting and nowhere does it [in the documentation] display a simple example of the proper usage of 'export default' or otherwise to truly export the child component for use with a parent.
In reference to the documentation here: https://www.typescriptlang.org/docs/handbook/jsx.html
I keep going in circles and since this is such a specific use case I figured I'd add an issue here.

Embarrassingly simple syntax issues. I should have been paying more attention to higher level component structures supplied in the project. Word to the wise though if coming from regular ES6 JS like I am, and definitely a novice with TypeScript...
Child components (classes) should be given the 'export' keyword straight away on the class instantiation. I guess thru all the spots I was reading I never caught on to this being the approach.
The following runs fine as a child to the map function.. (with different & appropriate props provided down obviously)
Map function:

Child component

Hopefully this helps someone else in the future. Not all of us are crushing it yet with this stack, to me this can fight against the next JS TS dotnetcore React/Redux novice's syntax error.


Keep acrylic effects even when unfocused

What feature or improvement do you think would benefit Files?
Right now, when Files loses focus, it loses the acrylic effect and disables all effects for a flat color, it feels very jarring. (right is focused, left is unfocused)

It would be good to have a feature to preserve the applied background effect even when unfocused.
Requirements

Adjusting the behaviour of the background rendering to apply the effect when unfocused

Files Version
<IP_ADDRESS>
Windows Version
10.0.22631.4169
Comments
No response

It is worth noting, this is currently the default and recommended way Acrylic works for performance reasons.

It is worth noting, this is currently the default and recommended way Acrylic works for performance reasons.

I do understand this aspect, i think having an option about it could be the best way to go about it. like a boolean toggle

I don't think we're going to the undocumented world. There isn't an official way to reenable. As @mdtauk mentioned this is disabled because of performance and battery aspects.

I don't think we're going to the undocumented world. There isn't an official way to reenable. As @mdtauk mentioned this is disabled because of performance and battery aspects.

It would require abandoning the official way to handle it, and may not be compatible with Mica - even though it is technically possible as evidenced by Windows Terminal.

Yair has spoken on this https://github.com/files-community/Files/issues/3200#issuecomment-764373382

Our position remains consistent with issue #3200. While we are not opposed to the idea in principle, the change would need to be implemented by the WinUI team. We encourage you to share your feedback with Microsoft through the Feedback Hub and the WinUI GitHub repository.


Move Slingshot to a new Meteor organization: slingshot

Embrace the community and have all awesome slingshot packages under one roof!

edgee:slingshot -> slingshot:core
NEW PACKAGE!? -> slingshot:s3
NEW PACKAGE!? -> slingshot:google-cloud
NEW FUTURE PACKAGE!? -> slingshot:dropbox
NEW FUTURE PACKAGE!? -> slingshot:box
NEW FUTURE PACKAGE!? -> slingshot:sharepoint
NEW FUTURE PACKAGE!? -> slingshot:drupal
ryanswrt:autoform-slingshot -> slingshot:autoform

And from the different service provider packages we could give better detailed instructions for each service, like s3 differs somewhat from google-cloud I imagine.
The repos could still link to the original author, or you could create a new github organisation like CollectionFS.
Btw, you should check out the new version of ryanswrt:autoform-slingshot – It has some large improvements!

I already made a branch for splitting the package into its services: #105
Making a meteor account for slingshot, makes a lot of sense. Will see about making it happen.

Awesome! Great!!


Urgent need for another download link

Could anyone share this data with me by another link or download manner?
The current link always fails after downloading for serval hours.

I have already changed three servers to download this data, and it always fails.

Hello, can you solve this problem now?
That link is invalid now.
Do you find another download link?
Thanks!

Thank you for your interest.
Could you try to manually extract the features from MSCOCO/Flickr, following https://github.com/kuanghuei/SCAN#data-pre-processing-optional
That works for me.


Hide card when there is no warning

Hi, first of all, thanks for this very nice card! :)
Is your feature request related to a problem? Please describe.
No problem, just something that would be useful for me :)
Describe the solution you'd like
Currently, the card is always shown. When there is no warning, it is shown with the text "No warning".
I would personally prefer the card to be hidden when there is no warning, and only to be shown, when there is a warning.
In the best case, this would just be optionally configurable, for example by a config parameter "show_only_on_warnings" or "hide_when_no_warning" or similar.

Hey, I have this feature done on the https://github.com/MrBartusek/MeteoalarmCard/tree/hide-when-no-warning branch but it seems like home assistant applies a small margin to all cards and I'm not sure if that can be removed in any way:

I'll keep this issue open for now till me or someone else comes up with a solution for that.

HA conditional card or https://github.com/thomasloven/lovelace-state-switch? Can not test now as Meteoalarm integration shows unavailable for a month already :-(
Best, JR

This is now a part of https://github.com/MrBartusek/MeteoalarmCard/releases/tag/v1.12.0. Thanks for the suggestion!


Discover behavious from a non-leader node (raft)

When clicking Clusters -> discover from a non-leader node GUI, Feeding any data into the hostname:port box and hitting submit button will cause the "processing" wheel icon to appear and basically hang in there forever.
Maybe show a message saying discovery has to run from leader node instead?
Also would be nice to have some indication on the GUI saying if we are executing from a leader or not.

One answer and one good news for you:
answer
On a non-leader raft node you're supposed to see an icon of an eye, as in:

This indicates you're in read-only mode. And most operations are not permitted. Seems like I missed on disabling the discovery.
Good news
You're two days late for the party. This - https://github.com/github/orchestrator/pull/408 - will make non-leader nodes proxy your request to the leader node.
last question
How did you come to access the non-leader node, anyway? The recommendation is to use a proxy in front of all nodes to only direct traffic to the leader: https://github.com/github/orchestrator/blob/master/docs/raft.md#proxy

On a non-leader raft node you're supposed to see an icon of an eye, as in:
This indicates you're in read-only mode. And most operations are not permitted. Seems like I missed on disabling the discovery.

Thank you for the heads up, I hadn't noticed this. Yes, the discovery is still allowed.

You're two days late for the party. This - #408 - will make non-leader nodes proxy your request to the leader node.

That's great news!

How did you come to access the non-leader node, anyway?

This is a test setup I am running to try different things, so I don't have a proxy in front. I was testing the raft failover and the leader role switched over, and I didn't notice and tried to add a cluster through a node that wasn't leader anymore :)

This is a test setup I am running to try different things, so I don't have a proxy in front. I was testing the raft failover and the leader role switched over, and I didn't notice and tried to add a cluster through a node that wasn't leader anymore :)

OK, so technically you were not following documentation and I should just tell you to please adhere to the docs:

You should only send requests to the leader node.

Agreed! thanks

https://github.com/github/orchestrator/pull/408 is merged, so I'm closing this issue.
Expect a release early next week.


feat: dir_display_limit

New feature to limit the number of directories to display.
Especially useful when working with something like Spring Boot, where just the directory name takes more than 50% of my screen real estate.

Changed the type to integer and added ellipsis symbol to indicate that the directories have been split. Also unsure how to handle the protocol prefix. Do you have any ideas?

Honestly, it's been a while since I used this plugin myself. So just be sure that nothing breaks.
Cases that I recommend testing:

Relative file paths (especially when there is a ./some.txt or ../some.txt)
Absolute file paths (they should have a / entry at the beginning)
URLs should have a http:// entry at the beginning (http is just an example it should handle any given schema like tcp://, https://, or mycustomschema://)


Depend on package.json's electron

So you don't have to define dependencies both in package.json and gulpfile.js

Thanks, this looks great.


Incorrect annotations for the wrapped functions.

You used cast(Awaitable[T], run_in_executor) to annotate the wrapped functions, but this is unfortunately incorrect. The function objects themselves are not awaitable; calling the function returns an awaitable. The T generic typevar instead captures the arguments and the return value for the callable, presenting as if the functions in aiofiles are awaitables that produce the argument list + return value when awaited on.
The pylance type checker therefore reports an error when I use await aioshutil.rmtree(path):
Object of type "Awaitable[(path: StrOrBytesPath, ignore_errors: bool = ..., onerror: _OnErrorCallback | None = ...) -> None]" is not callable.
Before PEP 612 your only option was to use was a type var for the return value only, leaving the arguments for the callable set to ...:
T = TypeVar("T")

def sync_to_async(func: Callable[..., T]) -> Callable[..., Awaitable[T]]:
    @wraps(func)
    async def run_in_executor(*args, **kwargs) -> T:
        loop = asyncio.get_event_loop()
        pfunc = partial(func, *args, **kwargs)
        return await loop.run_in_executor(None, pfunc)

    return cast(Callable[..., Awaitable[T]], run_in_executor)

This would essentially turn off type checking for the arguments of the wrapped function, but at least the type checker would know that there is an async function involved.
With PEP 612 having landed, you can now use the ParamSpec() object, which has the added advantage of dropping the need for a cast:
try:
    from typing import ParamSpec
except ImportError:
    # Python 3.9 and earlier
    from typing_extensions import ParamSpec

P = ParamSpec("P")
R = TypeVar("R")

def sync_to_async(func: Callable[P, R]) -> Callable[P, Awaitable[R]]:
    @wraps(func)
    async def run_in_executor(*args: P.args, **kwargs: P.kwargs) -> R:
        loop = asyncio.get_event_loop()
        pfunc = partial(func, *args, **kwargs)
        return await loop.run_in_executor(None, pfunc)

    return run_in_executor

This does require that typing-extensions is added as a project dependency for Python versions before 3.10:
# in setup.py
    install_requires=["typing-extensions;python_version<'3.10'"],

I'll make a PR to fix this.

Thanks for the bug report and PR!


Cm update

Update base jobs
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: abhay-krishna
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [abhay-krishna]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@abhay-krishna: Updated the job-config configmap in namespace default at cluster default using the following files:

key builder-base-postsubmits.yaml using file jobs/aws/eks-distro-build-tooling/builder-base-postsubmits.yaml
key eks-distro-base-postsubmits.yaml using file jobs/aws/eks-distro-build-tooling/eks-distro-base-postsubmits.yaml

In response to this:

Update base jobs
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.


CSD02 mandatory tests

This PR includes the additional mandatory tests from CSD02.

Fixes #4
Fixes #7

@domachine Do you have a small script that imports the library and validates a file against one test? That would help me to test some edge cases of the implementation.
Just from looking at the code I couldn't spot anything obvious...

@domachine Do you have a small script that imports the library and validates a file against one test? That would help me to test some edge cases of the implementation.
Just from looking at the code I couldn't spot anything obvious...

Yes, I can throw one together. But if you want, you could add these edge cases to the documentTests.js file to include them in the test-suite. Just copy and paste the JSON into the content field. Since JSON is also valid JS, no changes are needed.

Yes, I can throw one together.

I wouldn't mind if you could do that. I would like to use that in the TC's repo to make sure the example files fail the right tests...

Yes, I can throw one together.

I wouldn't mind if you could do that. I would like to use that in the TC's repo to make sure the example files fail the right tests...

Here is a git-patch. Save it on your disk and run git apply <patch-file-path> from within the csaf-validator-lib repo. Then you can run the script using the following command: ./scripts/runTest.js <doc-file> mandatoryTest_6_1_1. mandatoryTest_6_1_1 is a sample here. You can insert any test name from lib/mandatoryTests.js, lib/optionalTests.js, lib/schemaTests.js and lib/schemaTests.js.
run_test_script.patch

Alright I addressed the issues and rebased the history.

Just a minor wording change suggested...

Fixed 🙂


Rally screenshot tests

After the official alpha release announcement @JoseAlcerreca told us there was an opportunity to implement screenshot testing support in Jetpack Compose. Today I've finished the development of the feature and I've prepared a branch just to show you how any android developer could use this testing strategy to test their Compose components using Shot.
I do not expect this branch to be merged in this repository. I understand Shot is a tool you did not create, and you do not want to maintain in this repo. Feel free to close the PR if you want. However, I think this PR can be useful to gather some feedback about different testing strategies in Jetpack Compose.
Inside this PR you'll find the following changes:

Some bash scripts needed to initialize the same emulator the CI environment will use to verify the screenshots and the developer will use to record them.
Changes in the CI configuration to be able to start the emulator and run the screenshot tests.
A bunch of .png files with the screenshots recorded during the execution of our screenshot tests.
Changes needed to configure Shot in this project.
Screenshot tests for the following components: AccountsBody, AnimatedCircle, BillsBody, OverviewBody, RallyApp, and RallyTopAppBar.
In the case of AnimatedCircle, I've replaced the usage of the old screenshot testing tool with this new one which handles screenshots automatically for yow.

Apart from the coverage added there was some stuff I could not implement using screenshot testing:

I couldn't add coverage to the RallyAlertDialog component. onRoot method throws an exception whenever you try to invoke it with the dialog as the only component being part of the test. I don't know why this happens, but there is an exception thrown whenever you invoke onRoot complaining about two items being the root of the hierarchy.
It could be great if we could take a long screenshot with a bigger screen size so we don't have to scroll the view to the bottom in order to take a screenshot of a view with a long scroll. However, this is impossible with the current API. This is something we can do with regular android Views, but not supported for now in Compose.
The rule createComposeRule throws an exception if you try to invoke setContent more than once. This doesn't let us take more than one screenshot per test for different components. This is a pity, most of the tests we are going to write could use a custom screenshot name and be recorded inside the same test starting the activity only once and rendering different component instances. If we were able to do this, this could be a huge performance improvement in tests' execution time because we wouldn't need to start the activity once per test.
There are no examples in this branch, but this testing strategy is fully compatible with any mocking library you want to use in case there are some components with dependencies you want to test.

You can find more information in Shot's repository or the blog post we wrote about it.
I've already signed the CLA in case it is necessary. Thank you all for your hard work in Jetpack Compose. You are doing it great! 🔝

Hey Pedro, this looks promising but I think it would make more sense in the Shot repo. The official samples are definitively not the place for them :)
Can we move the conversation somewhere else?

@JoseAlcerreca wherever you think it's helpful 😃


anaconda, python2 & pyspark

I installed rdkit using conda:
conda create -c rdkit -n my-rdkit-env rdkit python=2.7 then I installed pyspark.
However running spark application (local mode), results in warning:
depickling from a version number (9.0) that is higher than our version (7.2)
The warning seems that it is coming from a call to zipWithIndex of pyspark, however a similar function is already called previously with no warning.
I am running in ubuntu 16.04

We'll need more information here but this error doesn't appear to be coming from rdkit.


Atomic CSS Modules

hey @chibicode, great article.
thanks for writing and sharing it.
we've been doing some experiments with Atomic CSS and CSS Modules recently.
you may like this post:
https://medium.com/yplan-eng/atomic-css-modules-cb44d5993b27
have a nice day!

Thanks @MicheleBertoli! I actually have "Recommended" that article on Medium in the past. I just linked it at the bottom of the page. Looking forward to seeing the library open being sourced!


LinkedIn API app requires a Linkedin Company Page

I was trying to create my own API key to test LinkedIn services but it requieres a Linkedin Company Page associated to the App.
"The LinkedIn Company Page you select will be associated with your app. Verification can be done by a Page Admin. Please note this cannot be a member profile page. Learn more"
The app can be registered here
Maybe @csharpfritz could create a MyTagg company page and authorize the API keys that we can create and use for development.

I have created a TagzApp company and page that we can use for this provider

Docs to consider:
Authentication to the LinkedIn APIs:
https://learn.microsoft.com/linkedin/shared/authentication/client-credentials-flow?context=linkedin%2Fcontext

This looks like it might be deeper and more difficult to deliver as LinkedIn does not appear to provide a native 'search' API


Fixed skewed drawing issue

Q
A

Bug fix?
Yes

New sample?
No

Related issues?
fixes #29

What's in this Pull Request?

Primary SVG line was drawing from 50,50 to 60,0 which caused the circles to not align correctly. Switched the line to go from 50,50 to 50,0 (straight vertical)
Removed debugMode
Added $schema
Added minimum and maximum values to drawing logic to prevent weird issues with negative percents and incorrect drawing of 100% values (issue #29)

thx Chris, appreciated.