File-based caching in _session very likely broken

Describe the bug
From looking at the code at https://github.com/Azure/azure-cli/blob/dev/src/azure-cli-core/azure/cli/core/_session.py#L46, I think the following is incorrect and won't expire as expected:
if st.st_mtime + max_age < time.clock():
    self.save()

time.clock() is "wall-clock seconds elapsed since the first call to this function" which is definitely not what was intended. time.time() is likely what you want.
This was first discovered in a port of this code into the vsts-python-api project (see https://github.com/Microsoft/vsts-python-api/issues/111)

//cc @troydai

Interesting. This particular line of code hasn't been changed since it was added 3 years ago. And this is the first time it is mentioned. And you're probably right.

Is it not an issue probably because we rarely set the max_age

Also, the call to time.clock() makes this incompatible with Python 3.8.
https://docs.python.org/3.7/library/time.html#time.clock

Deprecated since version 3.3, will be removed in version 3.8

This appears to be fixed in #10777

Can we close it?

I have fixed this issue in PR https://github.com/Azure/azure-cli/pull/10777


fcm token not available on first load react native (android)

"react-native": "0.55.4",
"react-native-fcm": "^14.1.3",
All Android  devices

after install the apk the app dont get fcm token
only after close the app and open again everything is fine.
FCM.getFCMToken().then(token => {
console.log("TOKEN (getFCMToken)", token);
//send to the server
});
FCM.on('FCMTokenRefreshed', token => {
  console.log("tokewn", token);
      //send to the server
});

please help :)

do you have same issue in debug mode?

@evollu on the emulator i dont have this problem

@evollu in release build getting same issues
after install the apk the app dont get token it giving null and then after relaunch the app getting token
is there any other thing to do or am i doing wrong any thing, because in debug build its working perfectly fine.
Please help

it takes a while to get firebase token. i wonder if it could be a firebase bug

Okk but now what should I do to handle this condition

listen on FCM.on('FCMTokenRefreshed', token => { and call FCM.getFcmToken on app start. The token should be there eventually.
You can save the token in storage for future compare to see if it actually changed

Ok i will try it and let you know if its works or not,
Thank you for help

@evollu Thank you very much, its working fine in release build.

@Seemapadiya I am facing the same issue. Could you please share code snippet?

@Udbhav12  previously  i was used this method on my app start and its working fine in debug
FCM.getFCMToken().then(token => {
console.log("FCM >>>token>>" + token)
});
For the release build issues i have to implement this method on app start
FCM.on('FCMTokenRefreshed', token => {
console.log('FCMTokenRefreshed',token);
});
if we didn't find token in FCM.on method but i have always get token in this method FCM.on('FCMTokenRefreshed', token => {})

@Seemapadiya Did you save parameter token in FCM.on('FCMTokenRefreshed', token => {}) and FCM.getFCMToken() to store?
Example:
FCM.on('FCMTokenRefreshed', token => {
    AsyncStorage.setItem('NOTIFICATION_TOKEN', token);
});

FCM.getFCMToken().then(token => {
   AsyncStorage.setItem('NOTIFICATION_TOKEN', token);
});

Yes direct store in to my model class


Can't use @http progress option when uploading a file to S3.

Trying to pass this
            '@http' => [
                'progress' => function(){
                        ...
                 }
           ]
   ]

as 3-rd param to \League\Flysystem\AwsS3v3\AwsS3Adapter::upload method (actually write() but doesn't matter). Using Laravel as a wrapper for this, 3-rd param
$result = \Storage::disk('s3')->put()

Since '@http' doesn't exist in $metaOptions array and \League\Flysystem\AwsS3v3\AwsS3Adapter::getOptionsFromConfig doesn't pass this option to S3 Client, I can't use this S3 feature. Please advice what to do.
https://stackoverflow.com/questions/10187653/php-s3-upload-progress

@frankdejonge Would this still be desired within this repo? Ran into a use case where I need this and don't wanna bother rewriting the entire stream abstraction in my application. If so, I'm going to take a stab at it

@slaughter550 Did you finally do it?

@slaughter550 Did you finally do it?


IT IS EXTREAMLY UNPREFESSIONAL TO MAKE A REALEASE ON HTML CODE!


Panic for: 'GL_INVALID_ENUM in CreateShader(type)'

The full panic message:
neikos@celestias-palace ~/p/r/bloqs> cargo run                                                                        < 101
     Running `target/bloqs`
thread 'glium rendering thread' panicked at 'Debug message with high or medium severity: `GL_INVALID_ENUM in CreateShader(type)`.
Please report this error: https://github.com/tomaka/glium/issues', /home/neikos/.cargo/git/checkouts/glium-cee1c79709e4d1bd/master/src/lib.rs:1679
thread '<main>' panicked at 'called `Result::unwrap()` on an `Err` value: RecvError', /home/rustbuild/src/rust-buildbot/slave/nightly-dist-rustc-linux/build/src/libcore/result.rs:743
thread '<main>' panicked at 'called `Result::unwrap()` on an `Err` value: "SendError(..)"', /home/rustbuild/src/rust-buildbot/slave/nightly-dist-rustc-linux/build/src/libcore/result.rs:743
stack backtrace:
   1:     0x7f3fb90d3a00 - sys::backtrace::write::h49b06c4e5fa1765dZTA
   2:     0x7f3fb90e6ce0 - failure::on_fail::h128a61ca90111ec2JFJ
   3:     0x7f3fb90c7110 - rt::unwind::begin_unwind_inner::h142cc6242e7988934jJ
   4:     0x7f3fb90c7c20 - rt::unwind::begin_unwind_fmt::h9f6d3c7c640c0421AiJ
   5:     0x7f3fb90e6c00 - rust_begin_unwind
   6:     0x7f3fb9111d60 - panicking::panic_fmt::h21faf6f60b06c77cSvw
   7:     0x7f3fb8f48b00 - result::Result<T, E>::unwrap::h9973605888421199388
   8:     0x7f3fb8f6bc60 - context::Context::exec::h5691806902112660613
   9:     0x7f3fb8f6bbf0 - program::Shader.Drop::drop::h69a661d47cbc9de6MVb
  10:     0x7f3fb8f75d10 - program..Shader::glue_drop.47209::hdaea61c331f08e91
  11:     0x7f3fb8f75510 - vec::Vec<T>.Drop::drop::h7714566669021697601
  12:     0x7f3fb8f754e0 - collections..vec..Vec<program..Shader>::glue_drop.47206::h69557029b08d62be
  13:     0x7f3fb8f72760 - program::Program::from_source_impl::h50ebb5f0c0f30fd0zfc
  14:     0x7f3fb8f15d60 - program::Program::new::h2802733595079189804
  15:     0x7f3fb8ede4b0 - main::hc77c6503431c4754Cba
  16:     0x7f3fb90eb590 - rust_try_inner
  17:     0x7f3fb90eb580 - rust_try
  18:     0x7f3fb90e8890 - rt::lang_start::h61cf7984fd279964KzJ
  19:     0x7f3fb8ede990 - main
  20:     0x7f3fb7d2e710 - __libc_start_main
  21:     0x7f3fb8ede380 - _start
  22:                0x0 - <unknown>
thread panicked while panicking. aborting.
An unknown error occurred

To learn more, run the command again with --verbose.

neikos@celestias-palace ~/p/r/bloqs> rustc -V                                                                         < 101
rustc 1.0.0-nightly (3ef8ff1f8 2015-02-12 00:38:24 +0000)

I used the tesselation example. This does not happen for the other examples (so far)

Thanks!
It's bug a when calling CreateShader. Instead of properly checking whether the hardware supports tessellation shaders, glium just calls the function and checks the return type.

That's what I figured, but since it explicitly tells to open an issue I went ahead with that.

Also, it seems to panic as it hits the geometry shader, which is probably the same problem, but just to be sure.


Frontpage info blocks

I would like frontpage blocks like the examples below but in our style, with the inform below (this is a brainstorm from me, please feel free to contribute other information you think might be useful).
This is the give the explorer a real authority weight upon first landing.

[x] Finalized Blocks

[x] Signed Extrinsics ?

[x] Accounts

[x] Transactions

[ ] #37

[ ] #38

[ ] #35

[ ] #36

Token Supply
Ideally this would be a single donut chart with 21m being thefull circle, then circulating supply taking up 23% and then staked supply taking up 88% of that 23%. The box would need to have those values clear on display (value AND %)

Max Supply (21m)
Circulating Supply (4.9m + % - taken from chain)
Staked Supply (4.36m + % of circulating taken from chain)

WIP

@mogmachine


add @testing-library/jest-dom

Codecov Report

Merging #269 (4bfd8da) into main (32b7d08) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #269   +/-   ##
=======================================
  Coverage   96.34%   96.34%
=======================================
  Files          28       28
  Lines         301      301
  Branches       67       67
=======================================
  Hits          290      290
  Misses         11       11

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 32b7d08...4bfd8da. Read the comment docs.


Refresh Fragment inside ViewPager

Hi, I have Swipe Tab Layout and it has 21 tabs. I use only one Fragment for each Tab. I want to refresh the fragment where any tab is selected. How do I do that? Thanks.

Based on Guesses:

Derive your Pager_adapter class as -- extends FragmentStatePagerAdapter (FragmentStatePagerAdapter destroys and creates them anew as they are shifted in and out of view.)
Make sure you are not calling setRetainInstance(true) in any of your  Fragments, else they won't be recreated.
Add viewPager.setOffscreenPageLimit(0);
create the structure as Activity -> Fragment -> ViewPager -> Nested Fragments

src: http://stackoverflow.com/a/29100155/5876080
PS: Try posting in stackoverflow as well.

Thank you @ibtehaz-shawon I'll try. If it don't work I am gonna write again :) Thanks.


Power Toys icon missing after updating to Windows 11 24H2

Microsoft PowerToys version
0.81.1
Installation method
Microsoft Store
Running as admin
Yes
Area(s) with issue?
General
Steps to reproduce
After installing Windows 11 24H2 the power Toys icon is not showing in tray. I have to open Power Toys to select options and configuration. Tried switching off/on at startup in the setup.  Uninstalled and installed again (this time from Store). The icon shows but disappears when system is restarted. Power Toys is not listed under programs that run at startup. The functions of Power Toys that I use seem to work ok.
✔ Expected Behavior
Power Toys accesible in Tray.
❌ Actual Behavior
Icon not showing. Power Toys is not listed as program that runs at startup. The option is selected when I manually run Power Toys.
Other Software
Windows 11 Pro 24H2 26100.863 Insider Release Preview.

This is a duplicate of #33128

The is still an issue for me on 0.82.1.


Support JHipster v8 release

@pascalgrimaud, can we add some bounty on this ticket?

@vishal423 : done

@vishal423 do you want some help migrating to v8?

@mshima, It would be really helpful if you can take up this ticket.

@mshima, are you planning to continue on this ticket?

@vishal423 I cannot take the lead on this.
The differences on the implementation makes difficult for me.
This blueprint ci is heavy on docker,  it creates an image and uses it everywhere.
Others blueprints supports generate-sample and is easy to reproduce ci samples.
jhipster-(entity-audit/micronaut/quarkus/nhipster/ionic) generate-samples # select the sample
npm ci:frontend:test
npm ci:backend:test

You can use the v8 branch to help you migrate and let me know if you need some help.

closing as most of the upgrade issues have been resolved

@mshima, please do claim half of the bounty as your initial PR helped on few tricky upgrade parts.
cc: @pascalgrimaud

I'm increasing the bounty so it will be better to share, @vishal423 and @mshima

Thanks @pascalgrimaud

@pascalgrimaud  bounty claimed https://opencollective.com/generator-jhipster/expenses/199462

@mshima, please do claim half of the bounty as your initial PR helped on few tricky upgrade parts.
cc: @pascalgrimaud

Sorry for the late response I’ve missed it.
Thanks @vishal423 glad it helped, let me know if you need and assistance to migrate to any other version.
Thanks @pascalgrimaud

@vishal423 : approved
@mshima : you're welcome, it's deserved :-)

@DanielFran bounty claimed https://opencollective.com/generator-jhipster/expenses/203357.

@mshima : approved

@pascalgrimaud thanks.


Confusion about Resource-Requirement

In the Page:https://github.com/Microsoft/pai/wiki/Resource-Requirement
It said:
For cluster installation, each PAI-Worker reserve 16G memory for OS and K8S, memory for user jobs is total_mem - 16g.
According to the Master/Worker column in the table, the worker's memory requirement is about 5.5G?
Most of the items in the table are memory requirements of the master. How much memory does the master actually save for OS and k8s?
Is this 16G just a requirement for K8S and os? Does it exclude the need for openpai services?

@hao1939 Hao, would you help on updating this wiki page? Thanks.

Here's case:
Total = Reserved + User
Reserved = os + k8s + pai + safe gap.

@hao1939 Is Master and worker Reserved the same size? Thanks！

No, master node is fully reserved for os + k8s + PAI.


Update USState.java

Fix spacing.

Thank you. Vermont isn't used in the problem statement so this should not affect the outcome.


Some usability suggestions

Hello, I have used Syncplay a few times to watch movies with my friends during quarantine. I think it's a great piece of software! But I have noticed that there are a few things about the UI that always confuses people. In this issue I will put some potential fixes for these issues.
This is what people see when first starting Syncplay:

Server address: Would it be possible to give the servers friendly names? Port numbers are hard to recognize. It would be easy if I could just tell my friends "We are on server Pluto" or something like that.
Path to media player: Most people don't know where their media player is installed. The Browse button stands out more than the drop down menu, so people are not noticing that it's there. It would be better to show a radio button list of installed media players with their icons. And add a button on the side to select a custom media player path. Also, since mpv is free and open source, would it be possible to bundle it with this software so people don't have to install it separately?
Path to video: It's easier to select this from the playlist when you're already in the room, doesn't have to be in the settings menu if it were up to me.
Player arguments: Most people don't know what this means and don't need it either. This could be moved to the Misc menu to remove clutter.

Then there's a button "Run Syncplay". Isn't Syncplay already running? I'd put something like "Join room" on this button instead.
So you click "Run Syncplay" and you see this:

Selecting a video to play: It's a lot of work to make sure everyone has the same media file. To work around this I usually upload the video I want to watch to my own webserver. Then I use the File > Open media stream URL option to add it to the player. It's never clear that you can click the URL next to my username to play the same video. It would be handy if the same video is always selected for everyone in the room. Just use the first item in the playlist for that.
Enable shared playlists: Isn't the point of this software to watch videos together? Why would you want to turn this off? I'd move this option to a drop-down menu to reduce clutter.
Open media file / stream URL: These options are tucked away in the File menu, while these are arguably the most important functions of the software. I would add a text field above the playlist (where the shared playlists button is now) where you can paste an URL / path and press Enter to add it to the playlist. This would make it instantly clear to people how you can add videos to the playlist.

I hope this isn't too overwhelming. Do whatever you want with my feedback :)

Your screenshot doesn't show what users see when first running Syncplay - the "Show more settings" is off by default, which presents much more streamlined interface. Notably this hides both player arguments and path to video.
Server names are very plain hostname and optional port and have dropdown pre-populated with servers we host ourselves (until recently there was no pre-populated list at all). When it comes to aliases I'd say that they would be much more confusing than what's there now. Especially given that Syncplay has been using this way of referring to servers for almost a decade by now.
Path to media player should in most circumstances automatically populate itself with sane default. So there should be no need to touch it in first place. I'm obviously biased by familiarity with existing interface, but I don't really see the dropdown/browse button as confusing. It's also pretty standard for file dialogs across various operating systems.
When it comes to the "main" interface I generally have quite different workflow. For example I basically never use File -> Open, but instead either drag and drop files/links to the playlist area or start Syncplay by selecting "Open with..." from context menu of a video file. I switch files either by clicking on them on the playlist or by dragging them into the player window itself. That said I could see valid reasons for adding some buttons next to the playlist window.
Ability to enable/disable shared playlists is there mostly for historical reasons - for pretty long time it was a somewhat wonky feature. Even now it doesn't work perfectly. Originally it made a lot of sense to have ability to turn it on/off at a glance. If we were to add some controls to the playlist interface I would probably still be in favor of leaving it there.
As a side note - most of the UX decisions were made after decent amount of deliberation so there almost always is some decent reason why every bit of it is the way it is. That said the interface likely has accumulated a bit of cruft over the years. On another hand though - what currently is there tends to work well enough, so nobody from core developers is really bothered to spend a lot of effort on changing it.

Hi, thanks for your suggestions. I don't see any of your proposed changes as likely to be implemented for the reasons Dan said. However, it is possible that a few improvements inspired by your suggestions could be helpful. These are:

Adding the playlist options as a section to the menu bar
Adding buttons for "Set Media Directories", "Add File(s)", "Add URL(s)" beneath the playlist

The former suggestion I think has no downsides. The letter adds clutter, but does make the most obvious options for Syncplay available. The new buttons could be something which people could choose to disable if they wished, in the same way that the playback and auto-play buttons can be toggled.
When you talk about people being confused, are you talking about your own experience of people being confused or seeing others be confused, or are you talking about a theoretical person being confused? Also, did the people who are confused read the guide at https://syncplay.pl/guide/client/ and how quickly did they figure things out?
I'll comment on some of your suggestions.

This is what people see when first starting Syncplay:

As Dan says, this is not what people see why they first start Syncplay.

Server address: Would it be possible to give the servers friendly names? Port numbers are hard to recognize. It would be easy if I could just tell my friends "We are on server Pluto" or something like that.

If we change system then this would be confusing with anyone still using old versions, or people who already advertised their server based on a port. It is also unclear how it would work with the CLI, and it might be harder to copy and paste. By using IP and port we are following a convention based on standards, and anything else could be confusing.

Path to media player: Most people don't know where their media player is installed.
The Browse button stands out more than the drop down menu, so people are not noticing that it's there. It would be better to show a radio button list of installed media players with their icons. And add a button on the side to select a custom media player path.

Syncplay is designed to automatically locate media players in their default directories. If you know of any paths we missed then let us know. Choosing the player via the path is in line with what we do for CLI mode, and if we had to diverge then that could make things overly complicated. This set-up also allows people to have multiple versions of a media players without issue (e.g. the stable and development versions of mpv).

Also, since mpv is free and open source, would it be possible to bundle it with this software so people don't have to install it separately?

If we install is, then we have to update it - so that then becomes an additional maintenance burden for us. Also, just because two pieces of software are open source does not mean their licenses are compatible (although I think mpv's is compatible with Syncplay last I checked).

Path to video: It's easier to select this from the playlist when you're already in the room, doesn't have to be in the settings menu if it were up to me.

That's why it's not visible by default.

Player arguments: Most people don't know what this means and don't need it either. This could be moved to the Misc menu to remove clutter.

Again, that is why this is not visible by default (unless you choose to open a file with Syncplay). For those who do use it, we want it to be prominent so people know what options are currently set. Putting it under misc is confusing because these are per-player arguments.

Then there's a button "Run Syncplay". Isn't Syncplay already running? I'd put something like "Join room" on this button instead.

It is arguably the Syncplay configuration window which is running, not the main Syncplay client. We could change the text, but we already have the text we have and existing users are already used to it. Being in the bottom right hand corner should make it obvious that this is the "Let's go" button.

Selecting a video to play: It's a lot of work to make sure everyone has the same media file. To work around this I usually upload the video I want to watch to my own webserver. Then I use the File > Open media stream URL option to add it to the player. It's never clear that you can click the URL next to my username to play the same video. It would be handy if the same video is always selected for everyone in the room. Just use the first item in the playlist for that.

I never use File -> Open Media (or the media open option of my media player for that matter) and very rarely double click on names, I nearly always just add media to the playlist which will auto-play it. I occasionally drag a file into my player to load it. The double click feature was implemented before the shared playlist feature existed, and is now mostly redundant.

Enable shared playlists: Isn't the point of this software to watch videos together? Why would you want to turn this off? I'd move this option to a drop-down menu to reduce clutter.

If it turns out you have a bad copy of a video then you can disable the shared playlist to manually switch to an alternative version of the video without it automatically switching back. You can then quickly turn it back on. It doesn't actually take up any space, and people are already be used to it in its current location.

Open media file / stream URL: These options are tucked away in the File menu, while these are arguably the most important functions of the software. I would add a text field above the playlist (where the shared playlists button is now) where you can paste an URL / path and press Enter to add it to the playlist. This would make it instantly clear to people how you can add videos to the playlist.

I hardly ever open media, I add files/URLs to the playlist instead. People who want to add stuff can do so via the /qa command in the chat box as per https://syncplay.pl/guide/client/


[amcrest] extract service handler to reduce cognitive complexity

Proposed change

This PR improves the code quality by reducing the cognitive complexity of the setup function for the amcrest integration
Type of change

[ ] Dependency upgrade
[ ] Bugfix (non-breaking change which fixes an issue)
[ ] New integration (thank you!)
[ ] New feature (which adds functionality to an existing integration)
[ ] Deprecation (breaking change to happen in the future)
[ ] Breaking change (fix/feature causing existing functionality to break)
[x] Code quality improvements to existing code or addition of tests

Additional information

Checklist

[ ] The code change is tested and works locally.
[ ] Local tests pass. Your PR cannot be merged unless tests pass
[ ] There is no commented out code in this PR.
[ ] I have followed the development checklist
[ ] I have followed the perfect PR recommendations
[ ] The code has been formatted using Black (black --fast homeassistant tests)
[ ] Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

[ ] Documentation added/updated for www.home-assistant.io

If the code communicates with devices, web services, or third-party tools:

[ ] The manifest file has all fields filled out correctly.
Updated and included derived files by running: python3 -m script.hassfest.
[ ] New or updated dependencies have been added to requirements_all.txt.
Updated by running python3 -m script.gen_requirements_all.
[ ] For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
[ ] Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

[ ] I have reviewed two other open pull requests in this repository.

Not sure how this refactoring is supposed to help maintainability.


net::ERR_INSUFFICIENT_RESOURCES with many files in precache

Hi,
I have a webapp project with many pictures (average 10000, 5Go) and I would like to have a offline capacity at start. So, I initialize my staticFileGlobs with all pictures.
It works fine with 5000 pictures but with 10000, I have 5000 errors like that :
GET http://localhost:8080/index.html?sw-precache=0c563970c0e2bcb7d00c6c6accbee96f net::ERR_INSUFFICIENT_RESOURCES
I use chrome/OSX
Thanks

sw-precache will create a service worker that downloads, caches, and keeps up to date any local resources that are picked up during build time. Does 5Go mean you have 5 gigabytes of pictures that are being picked up during your local build?
Chrome will, once the device-specific storage limits are reached, start returning errors like the one you're seeing. And just in general, it's a really unfriendly approach to have anyone who visits your site once start downloading gigabytes of pictures.
You should rethink your strategy here, and not use sw-precache to pick up all those files. A combination of sw-precache to pick up the files that are important to display your web app's UI—the "App Shell"—along with a sensible runtime caching strategy for dynamic content would make sense. You can use the runtimeCaching option for setting up that strategy, or implement it yourself and then call importScripts on the additional code.

Yes, I have 5gb of pictures (I work on an 3D webapp).
This app have to available offline quickly, fully and without that the user browses all.
It's not a traditionnal public webapp but a way to distribute and update easily.
So, yes even if it's not friendly it's wanted to download 5GB at beginning.
I don't understand really "net::ERR_INSUFFICIENT_RESOURCES", I think this error is due to many http get in same time ? If yes, is it possible to make a batch ?
Or, else I put just import files in staticFileGlobs, other files in runtimeCaching and prefetch manually with importScripts right ? But it's a pity, because it's almost the same thing that to put all in staticFileGlobs. no ?

I'm not sure whether net::ERR_INSUFFICIENT_RESOURCES is an error due to limits imposed by the Cache Storage API or due to memory pressure.
I'll reopen this to investigate at some point down the line whether there are any benefits to batching the fetch/cache operations into instead of attempting them all at once, but given that it might not be possible to support this use case efficiently, it's not a high priority right now.
Feel free to experiment using the service worker and Cache Storage APIs directly and see if you're able to accomplish what you're attempting.

With lodash you can do something like this.  I had to add a timeout between my batched requests though.
      fetch('/reporter/current_user')
      .then(response => response.json())
      .then(files => _.chunk(files, 100).map(cache.addAll))
      .catch(error => console.log(`Error caching file: ${error}`));

I got same issue in vue js

I was having this issue with this PWA: https://porrasta-cfb21.firebaseapp.com/ which caches 200+ files.
It was not happening in Desktop computers, only in mobile. A Nexus 6p with Android 8 had no problem but many others did, including a Samsung S7 edge Android 7 and Chrome dev
Batching fetch/cache every 20 reqs solved it:
self.addEventListener('install', function(event) {
  event.waitUntil(
    caches.open(cacheName).then(function(cache) {
      return setOfCachedUrls(cache).then(async function(cachedUrls) {
        const cacheKeys = Array.from(urlsToCacheKeys.values());
        const chunckSize = 20;
        const cacheKeysChunks = new Array(Math.ceil(cacheKeys.length / chunckSize)).fill().map(_ => {
          return cacheKeys.splice(0, chunckSize);
        });
        for (let cacheKeys of cacheKeysChunks) {
          await Promise.all(
            cacheKeys.map(function(cacheKey) {
              // If we don't have a key matching url in the cache already, add it.
              if (!cachedUrls.has(cacheKey)) {
                var request = new Request(cacheKey, {credentials: 'same-origin'});
                return fetch(request).then(function(response) {
                  // Bail out of installation unless we get back a 200 OK for
                  // every request.
                  if (!response.ok) {
                    throw new Error('Request for ' + cacheKey + ' returned a ' +
                      'response with status ' + response.status);
                  }

                  return cleanResponse(response).then(function(responseToCache) {
                    return cache.put(cacheKey, responseToCache);
                  });
                });
              }
            })
          );
        }
      });
    }).then(function() {

      // Force the SW to transition from installing -> active state
      return self.skipWaiting();

    })
  );
});

omg you are the MAN

Hi, I got the same error running a parallel Cypress regression within a docker image, but in my local (out of docker) I'm able to run more parallel regression without any issue. Do you know what can I tweak in my docker file to solve the resources issue?

I was having this issue with this PWA: https://porrasta-cfb21.firebaseapp.com/ which caches 200+ files.
It was not happening in Desktop computers, only in mobile. A Nexus 6p with Android 8 had no problem but many others did, including a Samsung S7 edge Android 7 and Chrome dev
Batching fetch/cache every 20 reqs solved it:
self.addEventListener('install', function(event) {

..>     })

});

Great approach and solution! May I ask, if there is a purpose for the file hashes? Did not found any evaluation in your service-worker. Thx 👍


No values prop on MultiSelect?

I'm trying to setup a redux-form wrapper for react-selectize see:
http://redux-form.com/5.2.5/#/faq/custom-component?_k=7m8dyf
So far this is working great for SimpleSelect because it offers the value prop which I can pass in the dynamic redux-form field value.
It doesn't work with MultiSelect as there's no prop for the 'live' value of the input. Looking at the source it appears MultiSelect had a values prop that looks like it should work but is commented out
http://redux-form.com/5.2.5/#/faq/custom-component?_k=7m8dyf
Could I restore that prop? or is there more to the story?

the values prop for MultiSelect is there (just like the value prop for SimpleSelect), it is a controlled prop, here is a codepen illustrating how it can be used (react-selectize@2.0.2):
http://codepen.io/furqanZafar/pen/xOVzBd
Note: the values prop expects an array instead of a single item

Thanks @furqanZafar

@furqanZafar actually I think there is a bug here. if you check your codepen. You can not select an additional option form the multiselect drop down. Try selecting the two or three options. This is the same behavior I was seeing. It appears that setting values prop breaks the change handler?

@kevzettler values prop is a controlled prop as I mentioned earlier, much like the value prop of an <intpu/> element, i.e. onValuesChange you have to update the state of the parent component which in turn would update the values prop (illustrated by this pen http://codepen.io/furqanZafar/pen/xOVzBd)


Failed on creating SharePointFx webpart on fetch data

Detailed msg as below when I create Fx webpart with command "yo @microsoft/sharepoint", on the step of "fetch metadata from.........", is there anyway can fetch those metadata offline?
npm ERR! Windows_NT 6.1.7601
npm ERR! argv "C:\Program Files\nodejs\node.exe" "C:\Program Files\nodejs\node_modules\npm\bin\npm-cli.js" "install" "--cache-min" "86400"
npm ERR! node v6.11.0
npm ERR! npm  v3.10.10
npm ERR! shasum check failed for C:\Users\chris.gao\AppData\Local\Temp\npm-49564-86968284\registry.npmjs.org_40microsoft\sp-core-library-\sp-core-library-1.1.0.tgz
npm ERR! Expected: 9197a8dc8d2c502fd087cc7e70e1540a723e8cfe
npm ERR! Actual:   c7c0cc06aa5d7ca7f9a48d66fa4b38304eaa92cc
npm ERR! From<EMAIL_ADDRESS>npm ERR!
npm ERR! If you need help, you may report this error at:
npm ERR!     https://github.com/npm/npm/issues

Can you try doing NPM install again.  You cannot do that offline because you need to download the packages.

If you are still having this problem please open a new thread.

Still has error but create project successfully when I switch to Node.js 8.4.0
gyp ERR!  Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>postinstall script.
npm ERR! This is probably not a problem with npm. There is likely additional log
ging output above.
npm ERR!      C:\Users\chris.gao\AppData\Roaming\npm-cache_logs\2017-09-07T09_05
_48_579Z-debug.log
  _=+#####!

###########|       .----------------------------------------.
###/    (##|(@)    |            Congratulations!            |
######|   \   |  Solution spx-web-part-01 is created.  |
###/   /###|   (@) |     Run gulp serve to play with it!    |
#######  ##|   /   '----------------------------------------'
/##|(@)
###########|
**=+####!

Is there any specific reason you want to use Node.js v8? SharePoint Framework officially supports the LTS version which currently is v6.


Improve group-varint benchmark to reproduce value distribution of wikbigall.

Instead of using a fixed number of bits per value, the group-varint benchmark now tries to reproduce the distribution of the number of bits per values that can be observed on tail postings of wikibigall.

Looks good to me, Thank you @jpountz . otherwise i'm a bit curious that byteArrayReadGroupVInt  is so much faster than byteBufferReadGroupVInt.


[Accessibility]A11y_VSCode_CommandPalette_keyboard: after clicking on "Tab" key the opened "CommandPalette" get closed

Environment Details:
VSCode Version : 1.24.0
OS Version : MAC OS HighSierra10.13.5
Additional Details:
Keyboard,MAS3.2.1
Repro Steps:
1.Navigate to Settings icon in Activity Bar->Press Enter->Select "Command Palette" from dropdown.
2.Click on "Tab" key.
3.Observed that,after clicking on "Tab" key then opened "Command Palette" get closed.
Actual:
When user click on "Tab" key then opened "Command Palette" get closed.
Expected:
When user click on "Tab" key then focus should goes on expanded dropdown values instead of closing the opened "Command Palette".
Recommendations:
Refer below link which is repository of bug fixes code snippets:
https://microsoft.sharepoint.com/teams/msenable/mas/Pages/browse-fixes.aspx
User Impact:
User will get confused on which key the proper action will performed
MAS Reference:
MAS3.2.1: https://microsoft.sharepoint.com/:w:/r/teams/msenable/_layouts/15/WopiFrame.aspx?sourcedoc={a4bbd37d-ee11-485e-b5c8-0539f0ac94b2}
Attachment For Reference:
[Accessibility]A11y_VSCode_CommandPalette_Keyboard.pptx
Does this issue occur when all extensions are disabled?: Yes

/duplicate #51850


Wrap each_child/children_if & each_clip/clip_if instead of reimplementing

Right now, the bindings reimplement eachChild/eachClip.
This PR introduces these functions in the C++ core (each_child renamed to children_if & each_clip renamed to clip_if). Also, these functions return std::vector instead of iterators.
We should wrap these functions to maintain consistency.
The OTIO dependency with this change was landed in #20

@KarthikRIyer can I start working on this issue?

Yes!


Histogram Update method throws an indexing exception

Need to resolve this in the PlottingLibrary, which is currently located on Perforce.

https://github.com/HydrologicEngineeringCenter/HEC-FDA/pull/175#discussion_r746878051

What is the status of this issue?


Fix: The loading progress continues to display progress even after all parallel tasks have completed

Issue
We had a logic to show and hide the loading progress in BaseViewModel automatically. It was made to control showing and hiding the loading progress automatically for parallel tasks, such as parallel API calls at the screen loading time. Unfortunately, the current logic does not work stably, and it can not hide the loading when two of the tasks are finished at the same time.
👉  The loading progress continues to display progress even after all parallel tasks have completed

Parallel API calls log

I/okhttp.OkHttpClient: --> GET http://<IP_ADDRESS>:3001/api/v1/documents/1116/routes
I/okhttp.OkHttpClient: x-mock-response-id: 18834730-2a3b4099-2d46-413e-8316-fe01ceb0c606
I/okhttp.OkHttpClient: DeviceID: 86cdf0440136bf29
I/okhttp.OkHttpClient: Authorization: Bearer xyz
I/okhttp.OkHttpClient: --> END GET
I/okhttp.OkHttpClient: --> GET http://<IP_ADDRESS>:3001/api/v1/documents/1116/reason-codes
I/okhttp.OkHttpClient: x-mock-response-id: 18834730-8662fe2e-f6b8-4ffc-bd74-7161062eea0d
I/okhttp.OkHttpClient: DeviceID: 86cdf0440136bf29
I/okhttp.OkHttpClient: Authorization: Bearer xyz
I/okhttp.OkHttpClient: --> END GET
I/okhttp.OkHttpClient: <-- 200 OK http://<IP_ADDRESS>:3001/api/v1/documents/1116/routes (1039ms)
I/okhttp.OkHttpClient: Content-Type: application/json; charset=utf-8
I/okhttp.OkHttpClient: Content-Length: 1270
I/okhttp.OkHttpClient: Date: Tue, 11 Apr 2023 04:13:43 GMT
I/okhttp.OkHttpClient: Connection: keep-alive
I/okhttp.OkHttpClient: Keep-Alive: timeout=5
I/okhttp.OkHttpClient: <-- 200 OK http://<IP_ADDRESS>:3001/api/v1/documents/1116/reason-codes (1035ms)
I/okhttp.OkHttpClient: Content-Type: application/json; charset=utf-8
I/okhttp.OkHttpClient: Content-Length: 2811
I/okhttp.OkHttpClient: Date: Tue, 11 Apr 2023 04:13:43 GMT
I/okhttp.OkHttpClient: Connection: keep-alive
I/okhttp.OkHttpClient: Keep-Alive: timeout=5
I/okhttp.OkHttpClient: {
I/okhttp.OkHttpClient:   ...
I/okhttp.OkHttpClient: }
I/okhttp.OkHttpClient: <-- END HTTP (1270-byte body)
I/okhttp.OkHttpClient: {
I/okhttp.OkHttpClient:   ...
I/okhttp.OkHttpClient: }
I/okhttp.OkHttpClient: <-- END HTTP (2811-byte body)

Expected
The loading progress should be hidden once all API calls have been completed, regardless of whether they were successful or failed.
Steps to reproduce

Having a logic in ViewModel with parallel tasks, such as multiple API calls.
Binding the loading from isLoading StateFlow.
Re-check carefully multiple times.

Superseded by https://github.com/nimblehq/android-templates/issues/576


Updated dependencies + webpack plugin replacement for sed native-shim backtick modifier.

Ooh, it's probably not! I actually an not that familiar with node, so
didn't realize that was built in
On Feb 24, 2017 6:10 PM, "Trey Shugart"<EMAIL_ADDRESS>wrote:

@treshugart commented on this pull request.
In package.json
https://github.com/skatejs/web-components/pull/43#discussion_r103059155:

 "es6-promise": "^4.0.5",

 "object.assign": "^4.0.4"

},
"devDependencies": {
"cz-conventional-changelog": "1",

"fs": "^0.0.1-security",

Why is this needed over just using the standard node fs module?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/skatejs/web-components/pull/43#pullrequestreview-23839291,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAXylruc_dyeo7d3QVl8Q1O31-WV3hcJks5rf3F-gaJpZM4MLxtb
.

Btw, I considered using nf to do a more straightforward replacement of the shell stuff, but decided to go this more drawn out way.


Disable/Enable specific logging levels

Hi!
Great simple logger! 👍 👍
A future enhancement might be to allow configuring which log levels are enabled versus just a single dev/no-dev mode.

@nkoterba
Thank you!
I'm sorry to reply too slowly.I will add to the next version


update: stacklokbot without [bot]

Summary
Provide a brief overview of the changes and the issue being addressed.
Explain the rationale and any background necessary for understanding the changes.
List dependencies required by this change, if any.
Fixes https://github.com/stacklok/minder/issues/2392
Seems like stacklokbot[bot] is not being recognised as a bot by github.author so we are trying this approach instead.
Change Type
Mark the type of change your PR introduces:

[x] Bug fix (resolves an issue without affecting existing features)
[ ] Feature (adds new functionality without breaking changes)
[ ] Breaking change (may impact existing functionalities or require documentation updates)
[ ] Documentation (updates or additions to documentation)

Testing
Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.
No testing needed.
Review Checklist:

[x] Reviewed my own code for quality and clarity.
[ ] Added comments to complex or tricky code sections.
[ ] Updated any affected documentation.
[ ] Included tests that validate the fix or feature.
[ ] Checked that related changes are merged.

coverage: 36.323% (+0.03%) from 36.293%
when pulling 08ba99d60c5fb00f783a31e54ee80561b710dfcf on fix-workflow-syntax-if
into ecc15fdecd86670a7451b123990ad05eec935f03 on main.


Automated cherry pick of #4513: fix: 腾讯云不支持描述字段参数

Cherry pick of #4513 on release/2.11.
#4513: fix: 腾讯云不支持描述字段参数

Codecov Report

:exclamation: No coverage uploaded for pull request base (release/2.11@84932be). Click here to learn what that means.
The diff coverage is n/a.

@@              Coverage Diff               @@
##             release/2.11   #4518   +/-   ##
==============================================
  Coverage                ?    7.1%
==============================================
  Files                   ?     480
  Lines                   ?   78137
  Branches                ?       0
==============================================
  Hits                    ?    5554
  Misses                  ?   72117
  Partials                ?     466

Flag
Coverage Δ

#aFlag
7.1% <ø> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 84932be...29c3c02. Read the comment docs.

/lgtm

/approve


[Facebook Adapter] Add Handover Protocol Support

Proposed Changes
This PR will:

Add the classes and/or methods to handle Handover Protocol events in the Facebook Adapter.
Make changes in the existing sample bot project to use handover.
Add a second bot to pass control between both samples.

Details

Added Microsoft.Bot.Builder.Adapters.Facebook.SecondaryTestBot project.

Microsoft.Bot.Builder.Adapters.Facebook.TestBot renamed to Microsoft.Bot.Builder.Adapters.Facebook.PrimaryTestBot.

Added classes FacebookPassThreadControl, FacebookRequestThreadControl, FacebookTakeThreadControl, FacebookThreadControl to represent new Facebook data models.

Added class HandoverConstants to hold common values to be shared among adapter and bots.

Modified unit tests to reflect new changes.

Pull Request Test Coverage Report for Build 89287

0 of 0   changed or added relevant lines in 0 files are covered.
41 unchanged lines in 8 files lost coverage.
Overall coverage increased (+0.7%) to 77.482%

Files with Coverage Reduction
New Missed Lines
%

/libraries/Microsoft.Bot.Builder/Adapters/TestFlow.cs
1
77.17%

/libraries/Microsoft.Bot.Builder.Dialogs/Prompts/OAuthPrompt.cs
1
54.8%

/libraries/Microsoft.Bot.Builder.Azure/CosmosDbStorageOptions.cs
2
50.0%

/libraries/Microsoft.Bot.Builder.Dialogs/ObjectPath.cs
2
80.15%

/libraries/Microsoft.Bot.Builder/MemoryTranscriptStore.cs
2
86.09%

/libraries/Adapters/Microsoft.Bot.Builder.Adapters.Facebook/FacebookAdapter.cs
4
93.65%

/libraries/Adapters/Microsoft.Bot.Builder.Adapters.Facebook/FacebookHelper.cs
4
69.66%

/libraries/Adapters/Microsoft.Bot.Builder.Adapters.Facebook/FacebookClientWrapper.cs
25
71.26%

Totals

Change from base Build 88872:
0.7%

Covered Lines:
5829

Relevant Lines:
7523

💛  - Coveralls

:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.dll compared against version 4.5.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.AI.Luis.dll compared against version 4.5.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.AI.QnA.dll compared against version 4.5.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.ApplicationInsights.dll compared against version 4.5.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.Azure.dll compared against version 4.5.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.Dialogs.dll compared against version 4.5.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.TemplateManager.dll compared against version 4.5.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Configuration.dll compared against version 4.5.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Connector.dll compared against version 4.5.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Schema.dll compared against version 4.5.3

@Aliandi When you get a moment, could you fix the merge conflicts?
@garypretty Could you take a look and review when you've got a chance?

On it @cleemullins!

Hey @Aliandi If you could prioritize the review of #2953 that would be appreciated.  I am then going to review this PR later today.  Ideally I would like to get both merged today or tomorrow morning latest. Thanks.

@garypretty yes! We've approved it just now and and we are looking into this conflicts now

:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.dll compared against version 4.5.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.AI.Luis.dll compared against version 4.5.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.AI.QnA.dll compared against version 4.5.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.ApplicationInsights.dll compared against version 4.5.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.Azure.dll compared against version 4.5.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.Dialogs.dll compared against version 4.5.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.TemplateManager.dll compared against version 4.5.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Configuration.dll compared against version 4.5.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Connector.dll compared against version 4.5.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Schema.dll compared against version 4.5.3

:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.dll compared against version 4.5.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.AI.Luis.dll compared against version 4.5.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.AI.QnA.dll compared against version 4.5.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.ApplicationInsights.dll compared against version 4.5.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.Azure.dll compared against version 4.5.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.Dialogs.dll compared against version 4.5.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.TemplateManager.dll compared against version 4.5.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Configuration.dll compared against version 4.5.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Connector.dll compared against version 4.5.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Schema.dll compared against version 4.5.3

@Aliandi Thanks.  PR https://github.com/microsoft/botbuilder-dotnet/pull/2953 is getting merged shortly.  So probably a good idea to pull those changes in too.  Once the merge conflicts are resolved I will do my review tonight or first thing tomorrow with the goal being to merge this tomorrow also.

@Aliandi PR #2953 has now been merged so you can pull from master again now to get the latest changes. There should not be too many conflicts. Thanks.

@garypretty we've been looking into the merge conflicts and we are having some issues with the build. We'll have this fixed first thing tomorrow.

Thanks @Aliandi - sounds good.  Please prioritise this as soon as possible today.  I am out of office for the next 2 weeks, so it is critical we get this merged in the next few hours.  I'll do another quick pass once the latest bits from master have been merged in.

@garypretty we are having some issues with the transpassing from one bot to another after the merge, we are trying to fix it, we'll let you know as soon as that's done

@aliandi thanks. The PR looks good to me once you have fixed the issue. Let me know once done and I will do a last pass and merge. 👍

:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.dll compared against version 4.5.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.AI.Luis.dll compared against version 4.5.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.AI.QnA.dll compared against version 4.5.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.ApplicationInsights.dll compared against version 4.5.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.Azure.dll compared against version 4.5.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.Dialogs.dll compared against version 4.5.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.TemplateManager.dll compared against version 4.5.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Configuration.dll compared against version 4.5.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Connector.dll compared against version 4.5.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Schema.dll compared against version 4.5.3

@garypretty we are done here! Everything is working fine.

@Aliandi Thanks! I'll take a look shortly.

:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.dll compared against version 4.5.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.AI.Luis.dll compared against version 4.5.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.AI.QnA.dll compared against version 4.5.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.ApplicationInsights.dll compared against version 4.5.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.Azure.dll compared against version 4.5.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.Dialogs.dll compared against version 4.5.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.TemplateManager.dll compared against version 4.5.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Configuration.dll compared against version 4.5.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Connector.dll compared against version 4.5.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Schema.dll compared against version 4.5.3


⚠ Bofrost.be has degraded performance

In 7fce680, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 1358 ms

Resolved: Bofrost.be performance has improved in 8ad2cb0 after 21 minutes.


Don't install python2-setuptools

We recently bumped the base image to F35 and there's no python2-setuptools in F35.
So we can either remove it or base sandcastle image on F34.
It was originally added as a reaction to @bocekm's #49.
Michal, do you still need it? I don't see it in convert2rhel's .packit.yaml

You're correct, we don't use setuptools or create_tarball_command anymore, you can drop the F34. Thanks for informing me though ;)

@bocekm thanks for the info. Do I understand it correctly that you don't need python2 either so I can remove it as well?

We run git archive to create the tarball and then rpmbuild -bs to create the srpm - see the srpm build log. (@TomasTomecek correct me if I'm wrong)

that's true
I'm assuming such SRPM could be built on both py2 and py3. We can try that once merging here.


python312Packages.plexapi: 4.15.12 -> 4.15.13

Diff: https://github.com/pkkid/python-plexapi/compare/refs/tags/4.15.12...4.15.13
Changelog: https://github.com/pkkid/python-plexapi/releases/tag/4.15.13
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 312835 run on x86_64-linux 1

8 packages built:

home-assistant-component-tests.cast
home-assistant-component-tests.plex
home-assistant-component-tests.sonos
python311Packages.plexapi
python311Packages.plexapi.dist
python312Packages.plexapi
python312Packages.plexapi.dist
tauon


Make it easy for developers to pair client side and server side data.

Expose the uuid to the client.  (both versions)

I'm wondering how we could expose the UUID in the legacy protocol. Maybe @pboothe has ideas?

For the legacy protocol, my idea is: don't touch it, and migrate the client who wants this feature to NDT7.
Why do you need the UUID in the legacy client Matt?

Fixed in #186

Then, can we close this?


docs: need docs for npm + bundler usage

Version

tui-editor  v1.0.1
Test Environment

chrome win10*64
Current Behavior

// html
<div id="editSection">
    </div>
    <script src="./index.js"></script>

// js
var Editor = require('tui-editor');
require('tui-editor/dist/tui-editor-extScrollSync.js');
//require('tui-editor/dist/tui-editor.css');
//require('tui-editor/dist/tui-editor-contents.css');
//require('codemirror/lib/codemirror.css')
//require('highlight.js/styles/github.css');
var editor = new Editor({
    el: document.querySelector('#editSection'),
    initialEditType: 'markdown',
    previewStyle: 'vertical',
    height: '300px',
    exts: ['scrollSync'],
    useCommandShortcut: true,
});

Expected Behavior

docs example Basic
When I don't use this.
require('tui-editor/dist/tui-editor.css');
require('tui-editor/dist/tui-editor-contents.css');
require('codemirror/lib/codemirror.css')

I cant use online edit markdown editor and  ui style is disordered

Couldn't you at least note in the quick start guide in the readme, that you need to import the styles seperately? The readme gives the impression that all you need to do is import/require the npm module, but when the styles are missing it gives the impression that the editor just doesn't work..

@ViggoV yup. I should update.
Bah It’s realy tons of works to do.
I’ll update when I go to work tomorrow.
You can sen me a PR If you want.


feat(tooltip): add menuoffset prop

Small changes to Tooltip

Changes direction proptypes to PropTypes.oneOf(['bottom', 'top', 'left', 'right'])
Adds in menuOffset prop to ensure Tooltip is always positioned correctly. Usage is as follows:

<Tooltip triggerText="Tooltip - no icon" menuOffset={{left: 10, top: 30}}>

Related to https://github.com/carbon-design-system/carbon-components-react/issues/390#issuecomment-349335529

direction="right" default positioning is off. I think the default value of menuOffset.left may be putting the floatingMenu too far over.

@tw15egan If you don't have time to work out the bugs, let me know and I can help.

@DmitriWolf if you have time to improve this PR that would be great

@tw15egan Do you have a way of developing locally with npm link or do you only develop with Storybook?


Use relative paths for data_files in setup.cfg

pip install doesn't work with absolute paths
Follows-up https://github.com/kubernetes-incubator/kubespray/pull/2170
Signed-off-by: Bogdan Dobrelya<EMAIL_ADDRESS>

ci test this

@mattymo @flaper87 PTAL

How to test
From a venv, the commands should properly install/generate a package containing right $VENV/{etc,usr/share}/ paths:
$ python setup.py bdist_rpm && rpm2cpio dist/kubespray-2.5.1.dev103-1.noarch.rpm | cpio -idmv
$ pip install git+https://github.com/kubernetes-incubator/kubespray


set app insights key when running web locally

After removing VITE_APPLICATIONINSIGHTS_CONNECTION_STRING from the bicep outpus (because there is already APPLICATIONINSIGHTS_CONNECTION_STRING), we need to create the mapping to a VITE env var to launch locally
fix: https://github.com/Azure/azure-dev/issues/3646
fix: https://github.com/Azure/azure-dev/issues/3644

Repoman Generation Results
Repoman pushed changes to remotes for the following projects:
Project: todo-csharp-cosmos-sql
Remote: azure-samples-staging
Branch: pr/3653
You can initialize this project with:
azd init -t Azure-Samples/todo-csharp-cosmos-sql -b pr/3653

View Changes | Compare Changes

Project: todo-csharp-sql-swa-func
Remote: azure-samples-staging
Branch: pr/3653
You can initialize this project with:
azd init -t Azure-Samples/todo-csharp-sql-swa-func -b pr/3653

View Changes | Compare Changes

Project: todo-csharp-sql
Remote: azure-samples-staging
Branch: pr/3653
You can initialize this project with:
azd init -t Azure-Samples/todo-csharp-sql -b pr/3653

View Changes | Compare Changes

Project: todo-java-mongo-aca
Remote: azure-samples-staging
Branch: pr/3653
You can initialize this project with:
azd init -t Azure-Samples/todo-java-mongo-aca -b pr/3653

View Changes | Compare Changes

Project: todo-java-mongo
Remote: azure-samples-staging
Branch: pr/3653
You can initialize this project with:
azd init -t Azure-Samples/todo-java-mongo -b pr/3653

View Changes | Compare Changes

Project: todo-java-postgresql-terraform
Remote: azure-samples-staging
Branch: pr/3653
You can initialize this project with:
azd init -t Azure-Samples/todo-java-postgresql-terraform -b pr/3653

View Changes | Compare Changes

Project: todo-nodejs-mongo-aca
Remote: azure-samples-staging
Branch: pr/3653
You can initialize this project with:
azd init -t Azure-Samples/todo-nodejs-mongo-aca -b pr/3653

View Changes | Compare Changes

Project: todo-nodejs-mongo-aks
Remote: azure-samples-staging
Branch: pr/3653
You can initialize this project with:
azd init -t Azure-Samples/todo-nodejs-mongo-aks -b pr/3653

View Changes | Compare Changes

Project: todo-nodejs-mongo-swa-func
Remote: azure-samples-staging
Branch: pr/3653
You can initialize this project with:
azd init -t Azure-Samples/todo-nodejs-mongo-swa-func -b pr/3653

View Changes | Compare Changes

Project: todo-nodejs-mongo
Remote: azure-samples-staging
Branch: pr/3653
You can initialize this project with:
azd init -t Azure-Samples/todo-nodejs-mongo -b pr/3653

View Changes | Compare Changes

Project: todo-nodejs-mongo-terraform
Remote: azure-samples-staging
Branch: pr/3653
You can initialize this project with:
azd init -t Azure-Samples/todo-nodejs-mongo-terraform -b pr/3653

View Changes | Compare Changes

Project: todo-python-mongo-aca
Remote: azure-samples-staging
Branch: pr/3653
You can initialize this project with:
azd init -t Azure-Samples/todo-python-mongo-aca -b pr/3653

View Changes | Compare Changes

Project: todo-python-mongo-swa-func
Remote: azure-samples-staging
Branch: pr/3653
You can initialize this project with:
azd init -t Azure-Samples/todo-python-mongo-swa-func -b pr/3653

View Changes | Compare Changes

Project: todo-python-mongo
Remote: azure-samples-staging
Branch: pr/3653
You can initialize this project with:
azd init -t Azure-Samples/todo-python-mongo -b pr/3653

View Changes | Compare Changes

Project: todo-python-mongo-terraform
Remote: azure-samples-staging
Branch: pr/3653
You can initialize this project with:
azd init -t Azure-Samples/todo-python-mongo-terraform -b pr/3653

View Changes | Compare Changes

/check-enforcer override


Support optional minerID in K2 PoW input

Motivation
Closes #4656
Changes
Adds an optional minerID that created the k2 pow (k2 pow creator id) to post proving and verifying.
Reasoning for making it optional
In order to be able to test in on a real network (devnet-401) pre-genesis. For genesis we will set post-minerid-in-k2-pow-since-epoch = 0 and later remove the config field along with branches in code.
Test Plan

existing UTs
systests
devnet-401 (set post-minerid-in-k2-pow-since-epoch to the epoch near in the future)

bors try

bors try

bors merge

bors merge

flaky TestCache_Account_Add_NonceTooSmall (https://github.com/spacemeshos/go-spacemesh/issues/4074)
bors merge


update to LTS 2.89.1

fixes https://github.com/openshift/jenkins/issues/439

lgtm

didn't pick up the new rhel rpm.  discussing with @smunilla

[test]

Package jenkins.noarch 0:2.73.3-1.el7 will be installed

still getting 2.73.

[test]

updated this to use 2.89.2, rhel is picking it up as well.
[merge]


Navbar - Implement CSS for About Us link

Requirements

The About us Page should be positioned and styled matching the wireframe below
Page and Link should be responsive

Wireframe reference

For anyone interested in working on this issue, just wanted to note that the wireframe about isn't specifically for the About Us page. We would like a link added to the nav bar that says About Us and a very simple page created with that as the title.

We're looking for work about padding / margins and gridding, not so much font or other design choices

Hi guys ! Just to make sure I understand everything as this is my very first collaboration:

So basically, I just need to style the About Us link in the Nav Bar ? Or do I also style the entire About Us page according to the picture style?
Can I decide the padding/margin as long it kinda looks like the picture or do you have specific numbers to follow ?

Thanks Ann and well-noted :)


WIP - Dan/2023/09/navigator cleanup

Motivation
Hygiene, housekeeping, documentation.

Codecov Report
Patch coverage has no change and project coverage change: +0.22% :tada:

Comparison is base (539f0c1) 99.77% compared to head (de19a48) 100.00%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #1280      +/-   ##
===========================================
+ Coverage   99.77%   100.00%   +0.22%
===========================================
  Files          22        22
  Lines        1361      1266      -95
  Branches      220       220
===========================================
- Hits         1358      1266      -92
+ Misses          3         0       -3

Flag
Coverage Δ

foundry
?

production
100.00% <ø> (ø)

reference
100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.
see 12 files with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Add worker declaration support in the new parser

Description:
Refer: https://ballerina.io/spec/lang/2020R1/#block-function-body

Added with #22805


Add stackoverflow search into web-search plugin

This is already present on the frontend-search plugin.


samples: net: sockets: Reinstate POSIX Makefiles.

All current socket samples as one of the points show portability to
POSIX platforms, and provide POSIX makefiles to let user build such
a version of application easily. These Makefiles were lost during
CMake conversion.
Signed-off-by: Paul Sokolovsky<EMAIL_ADDRESS>

The location of generated files like response_big.html.bin.inc changed from KBuild to CMake.
I was not aware that the Makefile.posix build system existed and was assuming that the file was at that location.
The generated files are now placed in ${BUILD_DIR}/[..]/include/generated

I don't see the point of the Makefiles really. The source is so easy to build.
Can't we just document
gcc src/socket_dumb_http.c && ./a.out
?
Maybe there is something I am not seeing.

Fixed the build issue. https://github.com/zephyrproject-rtos/zephyr/pull/4915

Can't we just document

It's already documented to use "make -f Makefile.posix".
Thanks for approving!

recheck


Write article in knowledge base about authentication

Please write an article in knowledge base about authentication.

How to create a user
How to create access tokens
How to attach access tokens to API calls
Read / write permissions for templates - what is possible without token, what needs a token

finished alpha version

Nice, thank you!


Wicket Viewer throws error when JDO Application Identity is used

To reproduce:
mvn archetype:generate  \
    -D archetypeGroupId=org.apache.isis.archetype \
    -D archetypeArtifactId=helloworld-archetype \
    -D archetypeVersion=2.0.0-M1 \
    -D groupId=com.mycompany \
    -D artifactId=myapp \
    -D version=1.0-SNAPSHOT \
    -B

apply attached patch file to HelloWorldObject.java
add attached HelloWorldPrimaryKey.java to same same folder
mvn clean jetty:run
navigate to http://localhost:8080/wicket and go to Swagger-UI
create a HelloWorldObject via Swagger-UI.  note there are no errors and object properties are returned
look up the HelloWorldObject you just created via the Wicket Viewer's web page Hello World Objects menu.
Error is thrown.
HelloWorldObject-breaks-wicket.zip

Hi all, this Issue is supposed to be tracked at Apache Isis (Jira) if need be. I'll not answer here but at the Isis user mailing-list.


[feature request] hub browse open pull request

I think it makes sense to open a pull request instead of a branch if pull request is available

That makes sense. Please follow existing threads about this: #1650 #897 #867


Adding an originFile parameter to DataviewApi#evaluate.

If the originFile parameter is included, a new EvaluationContext and associated LinkHandler will be created and used, instead of the default one with a base path of "".
This is a potential fix for #1930; want to make sure I'm going the right direction before going any further with this.

Looks good to me.


Ability to scan both way when cursor parameter is used on /blocks

What would you like to be added:
Ability to scan both way when cursor parameter is used on /blocks.
Why is this needed:
Currently, if we access https://defiscan.live/blocks?cursors=1000, we can only use right arrow to access https://defiscan.live/blocks?cursors=1000%2C950 but clicking on left arrow brings back to https://defiscan.live/blocks.
What is expected:
Expected to be able to scan both way with right arrow going towards 0 and left arrow towards highest block.

I think this issue can be closed @fuxingloh


Banknote Dataset

ML-Crate Repository (Proposing new issue)
:red_circle: Project Title : Banknote Dataset
:red_circle: Aim :  To predict whether a given banknote is authentic given a number of measures taken from a photograph.
:red_circle: Dataset : https://www.kaggle.com/ritesaluja/bank-note-authentication-uci-data
:red_circle: Approach : Try to use 3-4 algorithms to implement the models and compare all the algorithms to find out the best fitted algorithm for the model by checking the accuracy scores. Also do not forget to do a exploratory data analysis before creating any model.
Hello, ML-Crate contributors, this issue is only for the contribution purposes and allocated only to the participants of SWOC 2.0 Open Source Program.

📍 Follow the Guidelines to Contribute in the Project :

You need to create a separate folder named as the Project Title.
Inside that folder, there will be four main components.

Images - To store the required images.
Dataset - To store the dataset or, information/source about the dataset.
Model - To store the machine learning model you've created using the dataset.
requirements.txt - This file will contain the required packages/libraries to run the project in other machines.

Inside the Model folder, the README.md file must be filled up properly, with proper visualizations and conclusions.
A Demo Project has been created to guide you about the whole structure of presenting the Project in this repository. Here's the link of the Demo Project - https://github.com/abhisheks008/ML-Crate/tree/main/Project-Demo-Folder

:red_circle::yellow_circle: Points to Note :

The issues will be assigned on a first come first serve basis, 1 Issue == 1 PR.
"Issue Title" and "PR Title should be the same. Include issue number along with it.
Follow Contributing Guidelines & Code of Conduct before start Contributing.
This issue is only for 'SWOC' contributors of 'ML-Crate' project.

:white_check_mark: To be Mentioned while taking the issue :

Full name :
GitHub Profile Link :
Participant ID :
Approach for this Project :
Are you a participant of SWOC 2.0?

[ ] YES
[ ]  No

Happy Contributing 🚀
All the best. Enjoy your open source journey ahead. 😎

Full name : Sankalp Srivastava
GitHub Profile Link : www.github.com/sankalp-srivastava
Participant ID : 857
Approach for this Project : EDA and creating different models and comparing them.
Are you a participant of SWOC 2.0?
[x] YES
[ ] NO
I am having my end sem exams happening right now so I would need 7-10 days of time for this issue.


fix: manage enum plus number

Status
READY
Description
Minus number was managed for enum but not plus numbers (for instance for calling codes).
Todos

[x] Tests
[ ] Documentation
[ ] Changelog Entry (unreleased)

thanks 🎉


New version: open-source-labs.ReacType version 21.0.0

Pull request has been created with komac v2.2.1 :rocket:
Microsoft Reviewers: Open in CodeFlow

Automatic Validation ended with:

2024-06-20T14:47:59.1936505Z ##[error]Manifest Validation Failed
2024-06-20T14:48:04.2407799Z ##[section]Finishing: Validate Manifest

(Automated response - build 886.)


Bugfix: in the dashboard the "Is Active" search no more broken

In a query, used for searching active vouchers in the dashboard, the name
of the filtered fields was wrong.

@mvantellingen I reordered the import blocks to cpmply to PIP8.
Regarding the unit test... is it really necessary? The bug was simply a field name misspelled in a filter.

Bump! :smile:

@pdonadeo we should make sure we never break it again, so that's why we need a unittest ;-)
I'll try to look at it later, and merge this now. Thanks :-)

@mvantellingen thanks for merging the patch. I have to admit that the problem with unit test, in this case, is that I'm not able to write one, so... thanks again.


How to set Image for Points plotted on Line Chart ?

I want to set drawable image for the points on line graph.
but right now, i can only set Point Color by line.setPointColor(Color.RED);
I want something like this.
line.setPointbackgroundDrawable(R.Drawable.image);

Sorry, it is not supported. You will have to do it yourself or use other library.


CASMINST-5942: Modify NCN image customization procedure to be more flexible

Description
The 1.3 procedure for customizing NCN images is written assuming that the S3 paths for the images will always be of the form k8s/<version>/<artifact> or ceph/<version>/<artifact>. However, that will only be the case the first time the images are customized. As part of the customization process, the new images being used will have their S3 paths of the form <IMS ID>/<artifact>. Because of this, the procedures as written do not work for those re-customizations of images that had been previously customized.
This PR modifies the procedures to be more general, not making an assumption about which form the S3 path must take. Almost all of this involves just changing the initial step to identify and download the NCN image artifacts. Minor changes are needed to other parts of the procedure to reflect some of the changes made in that earlier step.
I manually tested the updates steps in isolation, but I have not had the opportunity to test the full procedure on an installed system. However, given the limited scope of the changes, I believe the risk is tolerable.
In addition to the above, I also did some minor linting work, including adding some links back to the glossary for some of the acronyms that previously had not been defined on the page.

Checklist

[X] If I added any command snippets, the steps they belong to follow the prompt conventions (see example).
[X] If I added a new directory, I also updated .github/CODEOWNERS with the corresponding team in Cray-HPE.
[X] My commits or Pull-Request Title contain my JIRA information, or I do not have a JIRA.

@don-bahls-hpe please review when you have the opportunity, to make sure that this addresses your concerns.


Swarm test error in CI

Got thsi error during CI run - https://ci.vmware.run/vmware/docker-volume-vsphere/397
2017/06/07 12:44:13 Failed to invoke command [docker volume inspect  --format '{{index .Status.status}}' swarm_test_volume_1496839264]: exit status 1
2017/06/07 12:44:13 Sleep for 2 seconds
2017/06/07 12:44:16 Failed to invoke command [docker volume inspect  --format '{{index .Status.status}}' swarm_test_volume_1496839264]: exit status 1
2017/06/07 12:44:16 Sleep for 2 seconds
2017/06/07 12:44:18 Failed to invoke command [docker volume inspect  --format '{{index .Status.status}}' swarm_test_volume_1496839264]: exit status 1
2017/06/07 12:44:18 Sleep for 2 seconds
2017/06/07 12:44:21 Failed to invoke command [docker volume inspect  --format '{{index .Status.status}}' swarm_test_volume_1496839264]: exit status 1
2017/06/07 12:44:21 Sleep for 2 seconds
2017/06/07 12:44:23 Failed to invoke command [docker volume inspect  --format '{{index .Status.status}}' swarm_test_volume_1496839264]: exit status 1
2017/06/07 12:44:23 Timed out to poll status

FAIL: swarm_test.go:91: SwarmTestSuite.TestDockerSwarm
swarm_test.go:141:
c.Assert(status, Equals, true, Commentf("Volume %s is still attached", s.volumeName))
... obtained bool = false
... expected bool = true
... Volume swarm_test_volume_1496839264 is still attached
2017/06/07 12:44:23 Destroying volume [swarm_test_volume_1496839264]

I guess @shaominchen is taking care of this one as part of #1368.
@shaominchen Please confirm.

Yes, in PR #1368 we are increasing the timeout value from 1 min to 2 mins.


update cancer predisposition

Closes #6515
This update is based on the ClinGen Hereditary Cancer Gene Curation Expert Panel Spreadsheet: https://docs.google.com/spreadsheets/d/100Cg6PF9iFPV6AEFB2SIAlCAPRWrTJLR/edit#gid=1863365376

@nicolevasilevsky could you please review this when you have a moment? Thank you!


UnicodeDecodeError

OS: windows 10 Pro
Python:  3.6.0 Anaconda

$  pip install rainbowstream
Collecting rainbowstream
Using cached rainbowstream-1.3.7.tar.gz
Complete output from command python setup.py egg_info:
Traceback (most recent call last):
File "", line 1, in
File "C:\Users\avathar\AppData\Local\Temp\pip-build-jgzg70k4\rainbowstream\setup.py", line 44, in
long_description=open("./README.rst", "r").read(),
File "C:\Users\avathar\Anaconda3\lib\encodings\cp1252.py", line 23, in decode
return codecs.charmap_decode(input,self.errors,decoding_table)[0]
UnicodeDecodeError: 'charmap' codec can't decode byte 0x9d in position 2868: character maps to

I am getting the exact same error on Windows 10. My final line has a little more info on it:
 UnicodeDecodeError: 'charmap' codec can't decode byte 0x9d in position 2868: character maps to <undefined>


videocore::iOS::AACEncode release build

I use the sample application for demo purpose. When i build the app in release, after the RTMP stream is about to publishing (code : NetStream.Publish.Start RTMPStatus: 9) the app is crashing because of the AACEncode.
In VCSimpleSession:
m_aacEncoder = std::make_sharedvideocore::iOS::AACEncode(self.audioSampleRate, self.audioChannelCount);
I use Nginx for RTMP.
Strange, but in debug mode it works perfectly.
What could be the problem?
Here is the full trace:
#0	0x000000019a35658c in __pthread_kill ()
#1	0x000000019a3d916c in pthread_kill ()
#2	0x000000019a2ea888 in __abort ()
#3	0x000000019a2eb118 in __stack_chk_fail ()
#4	0x0000000100131dcc in AACEncode at /Users/tamas/Development//Pods/VideoCore/transforms/iOS/AACEncode.cpp:135
#5	0x000000010014b608 in __libcpp_compressed_pair_imp<std::__1::allocatorvideocore::iOS::AACEncode &, float &&, int &&, 0, 0, 1> [inlined] at /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../lib/c++/v1/memory:2096
#6	0x000000010014b5f4 in __compressed_pair<std::__1::allocatorvideocore::iOS::AACEncode &, float &&, int &&> [inlined] at /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../lib/c++/v1/memory:2362
#7	0x000000010014b5f4 in __shared_weak_count [inlined] at /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../lib/c++/v1/memory:2362
#8	0x000000010014b5f4 in __shared_ptr_emplace<float, int> [inlined] at /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../lib/c++/v1/memory:3698
#9	0x000000010014b5e0 in __shared_ptr_emplace<float, int> [inlined] at /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../lib/c++/v1/memory:3698
#10	0x000000010014b5e0 in std::__1::shared_ptrvideocore::iOS::AACEncode std::__1::shared_ptrvideocore::iOS::AACEncode::make_shared<float, int>(float&&, int&&) at /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../lib/c++/v1/memory:4271
#11	0x000000010014a1fc in std::__1::enable_if<!(is_arrayvideocore::iOS::AACEncode::value), std::__1::shared_ptrvideocore::iOS::AACEncode >::type std::__1::make_shared<videocore::iOS::AACEncode, float, int>(float&&, int&&) [inlined] at /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../lib/c++/v1/memory:4630
#12	0x000000010014a1f8 in -[VCSimpleSession addEncodersAndPacketizers] at /Users/tamas/Development/Pods/VideoCore/api/iOS/VCSimpleSession.mm:533
#13	0x000000019a240014 in _dispatch_call_block_and_release ()
#14	0x000000019a23ffd4 in _dispatch_client_callout ()
#15	0x000000019a2464a8 in _dispatch_queue_drain ()
#16	0x000000019a2424c0 in _dispatch_queue_invoke ()
#17	0x000000019a2470f4 in _dispatch_root_queue_drain ()
#18	0x000000019a2474fc in _dispatch_worker_thread2 ()
#19	0x000000019a3d56bc in _pthread_wqthread ()
Many thanks!
Tamas

Hi, sorry but I have same problem, I place a breakpoint and it appears that m_aacEncoder is nullptr, someone have an idea please ?

My App is Crash when start the streaming ,The Break point is iOS::AACEncode to shown the scope of that line it is Crash. Please Help me.!


InfluxDB e2e tests are unstable

The e2e tests keep failing very often on the main build and in nightly run, mostly due to influxdb server is not ready.
Logs:
2021-01-12T01:28:54.5321013Z >>> scalers/influxdb.test.ts.log <<<
2021-01-12T01:28:54.5321417Z
2021-01-12T01:28:54.5321853Z namespace/influxdb created
2021-01-12T01:28:54.5322472Z statefulset.apps/influxdb created
2021-01-12T01:28:54.5323071Z service/influxdb created
2021-01-12T01:28:54.5323520Z false
2021-01-12T01:28:54.5323882Z false
2021-01-12T01:28:54.5324239Z false
2021-01-12T01:28:54.5324583Z false
2021-01-12T01:28:54.5325134Z false
2021-01-12T01:28:54.5325516Z false
2021-01-12T01:28:54.5327162Z false
2021-01-12T01:28:54.5327561Z false
2021-01-12T01:28:54.5327947Z false
2021-01-12T01:28:54.5328330Z false
2021-01-12T01:28:54.5328716Z false
2021-01-12T01:28:54.5329082Z false
2021-01-12T01:28:54.5329464Z false
2021-01-12T01:28:54.5329847Z false
2021-01-12T01:28:54.5330230Z false
2021-01-12T01:28:54.5330613Z false
2021-01-12T01:28:54.5331000Z false
2021-01-12T01:28:54.5331381Z false
2021-01-12T01:28:54.5332146Z   ✖ before hook Influxdb is not in a ready state
2021-01-12T01:28:54.5332783Z namespace "influxdb" deleted
2021-01-12T01:28:54.5333640Z   ✖ 1 test remaining in scalers/influxdb.test.ts
2021-01-12T01:28:54.5334193Z
2021-01-12T01:28:54.5334587Z   1 hook failed
2021-01-12T01:28:54.5334876Z
2021-01-12T01:28:54.5335267Z   before hook
2021-01-12T01:28:54.5335555Z
2021-01-12T01:28:54.5336127Z   /__w/keda/keda/tests/scalers/influxdb.test.ts:69
2021-01-12T01:28:54.5336588Z
2021-01-12T01:28:54.5337016Z    68:
2021-01-12T01:28:54.5337904Z    69:     t.is('true', influxdbStatus, 'Influxdb is not in a ready state')
2021-01-12T01:28:54.5338585Z    70: })
2021-01-12T01:28:54.5338985Z
2021-01-12T01:28:54.5339412Z   Influxdb is not in a ready state
2021-01-12T01:28:54.5339743Z
2021-01-12T01:28:54.5340135Z   Difference:
2021-01-12T01:28:54.5340586Z
2021-01-12T01:28:54.5341092Z   - 'true'
2021-01-12T01:28:54.5341619Z   + 'false'
2021-01-12T01:28:54.5341894Z

@yquansah would you mind looking at this please?

@yquansah would you mind looking at this please?

@zroubalik Yes I can definitely take a look, thanks for addressing this. I wonder why it's taking so long for it to become ready.

@zroubalik Yes I can definitely take a look, thanks for addressing this. I wonder why it's taking so long for it to become ready.

@yquansah bear in mind that we are running a lot of e2e tests in parallel (currently 10) on the same cluster.

@yquansah bear in mind that we are running a lot of e2e tests in parallel (currently 10) on the same cluster.

@zroubalik Ahh I see. Okay i'll fidget around with this. But the problem is evident which is that the instance is failing to become ready. Other than that, the tests should work.

@zroubalik Ahh I see. Okay i'll fidget around with this. But the problem is evident which is that the instance is failing to become ready. Other than that, the tests should work.

@zroubalik I'll have some time to work on this this week. To try reproduce should i just run the run-all.sh script?

@zroubalik I'll have some time to work on this this week. To try reproduce should i just run the run-all.sh script?

@yquansah cool! Yeah you can use that or  make e2e-test-local
FYI, the azure related tests are expected to fail, since you don't have all the credentials.

@yquansah cool! Yeah you can use that or  make e2e-test-local
FYI, the azure related tests are expected to fail, since you don't have all the credentials.

@zroubalik e2e-test-local is not running for me. Doesn't seem to be any status output either.

@zroubalik e2e-test-local is not running for me. Doesn't seem to be any status output either.

If you look into the Makefile, you can see that's just a wrapper around:
npm install --prefix tests
./tests/run-all.sh

These should work for you.

If you look into the Makefile, you can see that's just a wrapper around:
npm install --prefix tests
./tests/run-all.sh

These should work for you.


Version Packages

This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.
Releases
<EMAIL_ADDRESS>Patch Changes

#2437 1f933505 Thanks @thomasheyenbrock! - Move preffity query functionality to editor context in @graphiql/react

#2435 89f0244f Thanks @thomasheyenbrock! - Move the logic for deriving operation facts from the current query to @graphiql/react and store these facts as properties on the query editor instance

#2437 1f933505 Thanks @thomasheyenbrock! - Move copy query functionality to editor context in @graphiql/react

#2437 1f933505 Thanks @thomasheyenbrock! - Move merge query functionality to editor context in @graphiql/react

#2436 3e5295f0 Thanks @thomasheyenbrock! - Inline logic for clicking a reference to open the docs and remove the onClickReference and onHintInformationRender props of the editor components and hooks

#2436 3e5295f0 Thanks @thomasheyenbrock! - Move visibility state for doc explorer from graphiql to the explorer context in @graphiql/react

Updated dependencies [89f0244f, 1f933505, 89f0244f, 1f933505, 1f933505, 3e5295f0, 3e5295f0]:

<EMAIL_ADDRESS>

<EMAIL_ADDRESS>Patch Changes

#2435 89f0244f Thanks @thomasheyenbrock! - Fix deriving default values for editors from storage

#2437 1f933505 Thanks @thomasheyenbrock! - Move preffity query functionality to editor context in @graphiql/react

#2435 89f0244f Thanks @thomasheyenbrock! - Move the logic for deriving operation facts from the current query to @graphiql/react and store these facts as properties on the query editor instance

#2437 1f933505 Thanks @thomasheyenbrock! - Move copy query functionality to editor context in @graphiql/react

#2437 1f933505 Thanks @thomasheyenbrock! - Move merge query functionality to editor context in @graphiql/react

#2436 3e5295f0 Thanks @thomasheyenbrock! - Inline logic for clicking a reference to open the docs and remove the onClickReference and onHintInformationRender props of the editor components and hooks

#2436 3e5295f0 Thanks @thomasheyenbrock! - Move visibility state for doc explorer from graphiql to the explorer context in @graphiql/react

This would be ready to go from my side! I'm aiming at releasing this on Sunday evening (May 29, 2022), just don't wanna do it right before the weekend if sth breaks 🙃 If we wanna get sth else released that is more urgent, then feel free to merge!


Solved LC Qs

Solved the problem of Cat and Mouse-2 using DP

Solved N-queens sets problem as well


No wrapping of wind data around date line

The wind visualization doesn't wrap around the date line properly. We probably need to work out how to make the shaders do the job.

Fixed by #10.


Compile with closure flag results in smaller js

Is there a reason that mozjpeg was not compiled with the closure flag? It results for me in a JS file that is about 21kb instead of 44kb. I had no problems in running the code.
In build.sh
...
emcc \
  --bind \
  --closure 1 \
  ${OPTIMIZE} \

...

Interesting! I didn't even know about that flag. I should add that to most of your build script.s

I read the optipng Makefile now and had the same idea! Building with --closure 1 it shrinks the JS from 108K to 46K. I opened #728, if that makes sense, then other codecs might benefit too.

Shipped!


Add flag --web-root for serving UI (w/ code example)

edit: removed potentially confusing language that was given as an example, not a fixed implementation detail
ollama serve --web-root ./ollama-webui/

Serve /api/* to the API
For all other requests, return results from the web server
If the --web-root flag is given, serve that directory for static files (index.html, etc)
If --web-root is not given, (optionally) serve an embedded filesystem (i.e. a help page)

Here's a tested, working example:
# serves ./documentation/
go run main.go

# serves ./customui/
go run main.go --web-root ./customui/

main.go
webui/index.html
customui/index.html

package main

import (
	"embed"
	"flag"
	"fmt"
	"io/fs"
	"net/http"
	"os"
)

//go:embed webui/*
var defaultWebRoot embed.FS

func main() {
	var webRoot string
	flag.StringVar(&webRoot, "web-root", "", "serve the given GPT API Web Client")
	flag.Parse()

	mux := http.NewServeMux()

	apiHandler := func(w http.ResponseWriter, r *http.Request) {
		fmt.Fprint(w, "This is the API route.")
	}

	mux.HandleFunc("/api/", apiHandler)

	var webRootHandler http.Handler
	if len(webRoot) > 0 {
		webRootFs := http.Dir(webRoot)
		webRootHandler = http.FileServer(webRootFs)
	} else {
		webRootFs, err := fs.Sub(defaultWebRoot, "webui")
		if err != nil {
			// panic only because this should be impossible
			panic(err)
		}
		webRootHttpFs := http.FS(webRootFs)
		webRootHandler = http.FileServer(webRootHttpFs)
	}
	mux.Handle("/", webRootHandler)

	port := os.Getenv("PORT")
	if len(port) == 0 {
		port = "8080"
	}
	addr := "<IP_ADDRESS>:" + port

	fmt.Println("Serving on ", addr)
	http.ListenAndServe(addr, mux)
}

This would be added right around here:
https://github.com/jmorganca/ollama/blob/ccff9ca09c1fb6709ba4456f0285b97bd5db9599/server/routes.go#L644
The best approach would probably be to change routes.go to return an http-compatible router, and handle the non-API related boilerplate up in the cmd.go rather that sending the TCP listener down into layers that really don't need to be aware of TCP.

@jmorganca if I create the PR for this will you accept it?

@mchiang0610 ^^

We're not currently planning on embedding a UI into the project. There are plenty of community projects that add a UI which can be integrated into ollama quickly and easily. See https://github.com/jmorganca/ollama#community-integrations

@mxyng I think you got this confused with another issue.
This is issue is NOT about embedding a UI.
This is about exposing the existing file server so that an alternative directory can be user-selected as the default page.
Could you please reopen for discussion on this topic?

Sorry if I misunderstood but I'm not sure what "existing Go file server" you're referring to. There's no such server I'm aware of. Moreover, serving user defined files isn't what ollama is designed for and implementing this feature will be counter to ollama's core goals.
For these reasons, I'm going to keep this issue closed.

Hi @coolaj86! Thanks so much for this issue. To add to @mxyng's comment, it would be really hard to support all configurations of file servers (e.g. headers, routing etc) to support all the different UIs built on Ollama. Are there changes to the API or ollama serve command that could help solve any compatibility issues with UIs (or make them easier to run/deploy together)?

@jmorganca literally just using the default built-in Go webserver with the existing Gin router is enough.
All of those other things can be left to web proxies and whatnot.
I'm just saying to make it accessible so that anyone can just plop in an index.html and start playing around - without needing to co figure CORS or reverse proxy or start a system service or orchestration layer.
Sure, some people will want to develop things that are very complex and won't work that way -, but I just want to be able to show this off without someone feeling like they have to be a docker expert just to get a page up with a prompt and have that "wow, this can run on my computer - I can build something with this" experience.
As you've probably notice here and in other repos' issues, it's a huge barrier to entry for inexperienced devs that has no technical requirement to be there.


AssemblyDependencyResolver not using nuget package storage

I'm using the AssemblyDependencyResolver for some kind of framework. With .Net 5.0 the AssemblyDependencyResolver based on my plugin's path (new AssemblyDependencyResolver(plugInPath)) hold the nuget package storages (e.g. C:\Users\[user]\.nuget\packages\microsoft.entityframeworkcore\6.0.0-preview.7.21378.4) in it's internal _assemblyPaths. Now all assemblies point to the assemblies path itself (plugInPath) where they actually aren't located. Is this a misbehavior?

If someone else is having this issue right now: adding a property ground <CopyLocalLockFileAssemblies>true</CopyLocalLockFileAssemblies> in the project currently solves this by actually copying all the packages in the output dir. But I'd rather like them to be linked correctly 👍


Use explicit rhel7 version

Using rhel7 only doesn't have to correspond with what we expect (latest rhel7), so we need to be more explicit here.

this is failing because rhel7 is actually the tag we use on our AMI that does the docker build, it's an internal version of the rhel7 image that has subscription certs added so the yum install commands will work.
we'll need to update our AMI process to create a rhel7.1 tag if you want this to succeed in our build system, but even that you're not actually going to be getting something that's necessarily based on rhel7.1.

So, from my PoV, correct FROM rhel7 is important for users rebuilding the image themselves and they should simply use rhel7.1 provided by RH. As for the CI, I think we should be fine with even fake rhel7.1, if that's something you propose..

btw is there a reason we don't want to just pick up whatever rhel7 points to?  (i assume someday rhel7 will pick up rhel7.2, for example).  is that a bad thing?

The reason is that it just doesn't work this way :) I was told that rhel7:latest may point to rhel7.1 or rhel7.2, depending on build order, one of them every-time.

that's terrifying :)

ami has been updated to have a rhel7.1 image.  [test]


Can't add forestry still recipes

This shows up in NEI and stuff but doesn't actually work:
// XP & Mob Essence Conversions
mods.forestry.Still.addRecipe(50, <liquid:xpjuice> * 25, <liquid:mobessence> * 83);
mods.forestry.Still.addRecipe(50, <liquid:mobessence> * 83, <liquid:xpjuice> * 25);

Which version do you use?

ModTweaker 2-0.8.1
forestry_1.7.10-<IP_ADDRESS>

Can you try it with version 0.8 because many thinks like thaumcraft not working in this version.

and please post the corresponding from minetweaker.log

Can't reproduce this bug with ModTweaker2-0.8.2 and forestry_1.7.10-<IP_ADDRESS>1.

Usually if it shows up in nei, but doesn't work, it is user error. since nei is simply reading and displaying.  maybe you put the wrong stuff in. also as @Zixxl said, can't reproduce.


Add RTOMax settings

Description
For this to work, you'll need https://github.com/pion/sctp/pull/303 to get sctp level support for configurable rtoMAX
Adding RTOMax to SettingEngine and passing it on when creating an sctp Client. This will allow low-bandwidth time critical apps to limit the retransmission timeout and better perform under congestion.
Reference issue
https://github.com/pion/sctp/issues/181

Sorry this took so long @daonb merging now!