RC1 Dynamic change color of buttons does not remove older color class

Short description of the problem:
I have a button that changes color :
<button ion-button            outline="{{!button.selected && button.value !== value}}"           color="{{(button.selected || button.value === value) ? button.value : 'dark'}}"           (click)="setValue(button.value)">     {{button.text}}   </button>
when button.value changes the button does change color, but if I change it again the first css class is not removed and it takes more importance as the OUTLINE one.
What behavior are you expecting?
When the color changes all css classes about color should be removed and then add then new one
Steps to reproduce:

Create a page with 3 buttons, with dynamic color (color="value") and outline, Value must be in color scss variables
Change value clicking on buttons
Look that buttons that are not selected keep the first color

<button ion-button
          outline="{{!button.selected && button.value !== value}}"
          color="{{(button.selected || button.value === value) ? button.value : 'dark'}}"
          (click)="setValue(button.value)">
    {{button.text}}
  </button>

Other information: (e.g. stacktraces, related issues, suggestions how to fix, stackoverflow links, forum links, etc)
https://forum.ionicframework.com/t/changing-button-color-or-icon-dynamically/37675/43
Which Ionic Version? 1.x or 2.x
2.0-RC1
Plunker that shows an example of your issue
For Ionic 1 issues - http://plnkr.co/edit/Xo1QyAUx35ny1Xf9ODHx?p=preview
For Ionic 2 issues - http://plnkr.co/edit/me3Uk0GKWVRhZWU0usad?p=preview
Run ionic info from terminal/cmd prompt: (paste output below)
Cordova CLI: 6.3.1
Gulp version:  CLI version 1.2.1
Gulp local:
Ionic Framework Version: 2.0.0-rc.1
Ionic CLI Version: 2.1.1
Ionic App Lib Version: 2.1.1
Ionic App Scripts Version: 0.0.36
ios-deploy version: 1.8.7
ios-sim version: 5.0.8
OS: Mac OS X Sierra
Node Version: v6.0.0
Xcode version: Xcode 8.0 Build version 8A218a

Use angular 2 input syntax:
<button ion-button
          [outline]="!button.selected && button.value !== value"
          [color]="(button.selected || button.value === value) ? button.value : 'dark'"
          (click)="setValue(button.value)">
    {{button.text}}
  </button>

Thanks for the quick response, the notation is better that way but the result is the same.
I detected that the problem is the combination of dynamic outline and color. Because they both have their own css colo classes.
For example:
button-ios-regular (regular is a color)
button-outline-ios-dark
So the button keeps both classes.

Hey @fmaceachen, could you provide me with what you are changing the values to? We have a test here that I am not able to reproduce it with: https://github.com/driftyco/ionic/blob/master/src/components/button/test/dynamic/main.html
If you could provide the code for your setValue function that would be helpful. Thanks!

I have 3 buttons with 3 colors:
$colors: (
        primary:    #1e5799,
        secondary:  #467302,
        danger:     #FF1210,
        light:      #f4f4f4,
        dark:       #222,
        favorite:   #69BB7B,
        warning:    #FF9938,

        bueno:      #69BB7B,
        regular:    #FF9938,
        malo:       #f53d3d,
        undefined:  #f4f4f4
);

the value changes to a string 'bueno' 'regular' 'malo'

@brandyscarney  Check on this, on the Home page, https://github.com/fmaceachen/buttons-color-test
There you can reproduce the same that is happening to me.
Regards

Thanks for the repo! I was able to reproduce it. So the issue here is definitely that the solid color class isn't being removed when it goes back to outline and dark. As a workaround for your specific issue, you can move your variables before the dark one:
$colors: (

  primary:    #327eff,
  secondary:  #32db64,
  danger:     #f53d3d,
  light:      #f4f4f4,

  bueno:      #69BB7B,
  regular:    #FF9938,
  malo:       #f53d3d

  dark:       #222,

)

That way the dark outline class will take priority over the solid color one.

@brandyscarney Thanks for the workaround, haven't figured out that color order affects the final css.

Thanks to PR https://github.com/driftyco/ionic/pull/9114 this has been fixed. I released a nightly version of the framework<EMAIL_ADDRESS>with this fix, could you try it out and let me know if you find any issues?
npm install --save ionic-angular@nightly

Thanks!


Update build/README.md to note memory requirements for boot2docker.

Updates build/README.md to note memory requirements for building with boot2docker. See: https://github.com/GoogleCloudPlatform/kubernetes/issues/11852

LGTM

Assuming shippable is still flaking seeing as this only changes a readme.


Key "inVersion" for Object groups

Key "inVersion" for all Object groups, so that the frontend knows which object groups are deleteable and which not.
Delete Button in frontend can be disabled if this key is true.

Fixed in 1e59498a8c124267f6e4354fb34d94be7d909d11


Slide is not centering

I'm unable to centre the slide image to take an even space between the left/right arrows:

render() {
    const items = this.props;

    const settings = {
      dots: true,
      infinite: false,
      speed: 500,
      fade: true,
    };

    return (

        { items.length && <Slider {...settings}>
          { items.map((entry, index) => (

          ))}
        </Slider> }

    );
  }

// css.container compiles to:
.container {
    padding: 3rem;
    max-width: 960px;
    margin: 0 auto;
}

Adding centerMode: true completely breaks it by showing all images as dispay:block; and opacity:0; so it takes up space vertically.
When you resize the browser it snaps into place and everything centers/works flawlessly. So, looks like its not doing something its meant to on initialise?

from my point of view the slick-track is wrong calculated. I try to div in that calculation.

I'm seeing centerMode={true} with centerPadding break the slider by showing multiple (vertical) rows of images too

If anyone has any problem like this anymore, please consider creating a demo on codesandbox and reopening the issue or creating a new one.

According to @chellberg I'v noticed it happens when the wrapping element have a width set. Setting centerPadding to 0px fixes the problem that the carousel has two rows.
https://codesandbox.io/s/0mzw0k4x7w

This is 2024 and I don't want anyone to wrap their head around this issue.
The trick is using afterChange.
    const settings = {
        className: "center slider variable-width slick-gradient",
        centerMode: true,
        infinite: true,
        slidesToShow: 1,
        speed: 100,
        rows: 1,
        slidesPerRow: 1,
        arrows: false,
        centerPadding: "100px",
        beforeChange: (_oldIndex, newIndex) => {
            // ...
        },
        afterChange: (currentIndex) => {
            // Select the element with the class 'slick-track'
            var element = document.querySelector('.slick-track');

            // Get the current transform value
            var currentTransform = getComputedStyle(element).transform;

            // Extract the x translation value. The match function attempts to find the numbers in the matrix transform, which are separated by commas.
            // The matrix format is matrix(a, b, c, d, tx, ty) where tx is our x translation.
            // If the transform is in the translate3d format, it should still match correctly.
            var match = currentTransform.match(/matrix\(([^,]+),([^,]+),([^,]+),([^,]+),([^,]+)/);

            if (match) {
                var currentX = parseFloat(match[5]); // Get the x translation value

                // Calculate the new x value by adding 45
                var newX = currentX + 45;

                // Set the new transform value
                element.style.transform = 'translate3d(' + newX + 'px, 0px, 0px)';
            } else {
                console.log("Could not parse the current transform value.");
            }
        },
        variableWidth: true,
    };

Consider to follow me if this solves your issue. :D


fix(util) Add support for obsolete HTTP date formats

Update http_date_to_dt to support obsolete date formats per RFC 7231.
Fixes #255

I will rebase this when #495 is merged, as I am pretty sure they conflict.

@mcmasterathl when you have time, could you rebase your change? Thanks!

Yup, was working on that right now actually.

@jmvrbanac All set

:+1: LGTM

I think we could optimize this a little bit, but that can be done in another patch.


feat: Output index.vhs.js to allow this to use Video.js+VHS

This PR uses webpack env commands and alias options to output a separate index.vhs.js file that can be used with a default video.js import and thus working with VHS. The default export will continue using hls.js.
The npm run build command will output both files. npm run dev will run with hls.js and npm run dev:vhs will run with vhs.
A next step, which probably should come in a separate PR is to integrate tech/hls.js with videojs-contrib-quality-levels.
~This is a WIP PR to switch videojs-mux-kit to use VHS. This is a minimal set of changes. I think it would be nice to be able to set up alternate builds that will use VHS or hls.js.~

I've created a PR based off of this that integrates hls.js with contrib-quality-levels https://github.com/gkatsev/videojs-mux-kit/pull/1

I've updated the README to include how to import the new file and also add a note on how to get access to the live demo page.

maybe we update player_software_version to be: 0.7.0-hls.js or 0.7.0-vhs? That way from the Mux Data side of things we can see how the two different builds perform.

Something like that definitely is a good idea to do. Should it be the player_software_version or maybe player_software_name?

Is there a tech option in Mux data that could be set instead? Not really sure what's the best option.

@gkatsev mux metadata guide is here: https://docs.mux.com/guides/data/make-your-data-actionable-with-metadata
Yeah, I could see it going in player_software_name, I don't feel strongly between that one or player_software_version

@dylanjha didn't see anything more appropriate. Decided to append it to the player-software-name as that seems a bit more appropriate to me.

One small detail, otherwise QA is good and we should get this merged then follow up with a release!


fluentd emitter plugin v1

Signed-off-by: Sahil Suneja<EMAIL_ADDRESS>

Codecov Report

Merging #230 into master will not impact coverage by -0.97%.

@@            Coverage Diff             @@
##           master     #230      +/-   ##
==========================================
- Coverage   89.82%   88.85%   -0.97%
==========================================
  Files          90       91       +1
  Lines        3313     3366      +53
==========================================
+ Hits         2976     2991      +15
- Misses        337      375      +38

Impacted Files
Coverage Δ

crawler/plugins/emitters/fluentd_emitter.py
28.3% <28.3%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e0dc13...fe71dd7. Read the comment docs.

DO NOT MERGE, tests TODO.!

Ok, good to merge, tests included.


Highlight smarts

Changes to rdkit_easy functions for rendering chemical structures to allow user to specify a substructure or SMARTS pattern to be highlighted in the rendering.

I added a test notebook to the directory test/integrative/highlight_smarts; it's self-explanatory. I'm not sure how you would do an automated test for this feature.


Omit latest Pandas version

Omit latest Pandas ver

@dsherry think I need to specify graphviz version for the circleci tests as well. It's pulling 0.16 as we don't specify any version rn.
https://app.circleci.com/pipelines/github/alteryx/evalml/8385/workflows/7fd82183-536b-458a-b130-cb0696beeae3/jobs/96840/steps

@jeremyliweishih yep you beat me to it :) https://github.com/alteryx/evalml/blob/main/.circleci/config.yml#L154


Add cmake-based native training example.

Nice! So is the plan to delete the IREE-side one? We should set up some CI or something for this (maybe just a nightly run). I think Ben's template had some CI hookups as well.

Yeah, I guess the makefile approach wasn't preferred, and Ben's template lets us do cmake.
Added a nightly test script.


Fetch logged in user information

Since we're using HA's new auth, it would be great to have access to the current logged in user within TileBoard. I'm thinking I could use the logged in user to determine what pages or layout I want to use (giving each tablet its own HA user). A means of logging out or switching the account would also be useful for troubleshooting/developing.
It looks like sending "auth/current_user" over the websocket will return the needed information. If it could be accessed in config.js under something like this.user that would be awesome.

A wiki page on this would be great, once you get it going.

hey @cgarwood  i saw you have a git with your hass config. would you please consider one for your tileboard config.js too?

Is it possible to use different config variables for different users? In a similar way to the example of showing a different config for mobile and non-mobile devices:
if(/[?&]mobile/.test(location.search)) {
   var CONFIG = {/*mobile config*/};
}
else {
   var CONFIG = {/*non-mobile config*/};
}

It is not straightforward as API calls are made at later stage and are async.

Ok, thanks, I've found a workaround for now, I'm just using a different copy of tileboard within my www folder for each user.
I guess if the HA devs implement the 'permissions' feature mentioned here:

Permissions. Using the same user and context features, we will also be able to limit access to entities to users.

Then having different layouts/tileboards for different users would be possible without multiple tileboard folders.

Why not just separate config files?

I did try multiple config variables, using the mobile example in the wiki to try and get seperate tileboards to mobile and non mobile devices, but it didn't work for me. I used this as my basis for my config file:
if(/[?&]mobile/.test(location.search)) {
   var CONFIG = {/*mobile config*/};
}
else {
   var CONFIG = {/*non-mobile config*/};
}

In order to get my mobile page I would go to:
http://hassos.local:8123/local/tileboard/index.html?mobile
I would then get the login screen for HomeAssistant, where I would enter my login and password.
After logging in, it redirects my browser to:
http://hassos.local:8123/local/tileboard/index.html?oauth=1&code=xxxxx
which then gives me the non-mobile config, as seems to be removing the '?mobile' from the url once I log in.
If I manually change the url to
http://hassos.local:8123/local/tileboard/index.html?oauth=1&code=xxxxx&mobile
then it does give me the mobile version of my tileboard, however doing this using a Kiosk type browser on a mobile device can be difficult or impossible.
If there is a better way to do this some sort of fix then that would be great. :)

@DeviousPenguin fixed (i suppose)
Btw, we already have a method Api.getUser(callback)

Btw, we already have a method Api.getUser(callback)

Thanks, I didn't know about this, is there an example of 'Api.getUser(callback)' being used somewhere? I'd quite like to try it out. Would 'this.apiRequest.getUser(callback)' be needed now?

Some things have changed since the previous comment. Now the Api object will be exposed as this.api in your functions. So you will have to use this.api.getUser([callback]).
It will work as soon as #309 is merged.

Ok, I'll wait until #309 is merged and see if I can get it work, thanks.

Just a quick follow up to this, I've managed to get the basics working OK after pulling the latest commits.
Here's a simple example of how to show the logged in user as a Popup on connection:
// in the config:

 onReady: function () {
    this.api.getUser(User_Callback)
  },

// have this function in the config also, but not in the CONFIG variable:
function User_Callback(object) {
  // console.log(object);
  // console.log(object.result.name);
  if(!CONFIG.ignoreErrors) Noty.addObject({
    type: Noty.SUCCESS,
    title: 'Connection Successful',
    message: ("Connected as " + object.result.name),
    lifetime: 2,
  });
}

Now I'm going to see if I can give different users different page layouts.


[SPARK-33596][SS] NPE when there is no watermark metrics

What changes were proposed in this pull request?
add check if there is watermark metrics or not
Why are the changes needed?
NPE when there is no watermark metrics, make some UT flaky.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Existing UTs.

cc @HeartSaVioR

Test build #131969 has started for PR 30545 at commit c9c4978.

can not reproduce again, close first

Build finished.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/36568/

Test build #131969 has finished for PR 30545 at commit c9c4978.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Build finished.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/131969/


When debug is invoked from a rails console (via irb), when typing a ) character, the debugger and console crashes

Your environment

ruby -v: ruby 3.1.0p0 (2021-12-25 revision fb4df44d16)
rdbg -v: 1.4.0
rails -v: <IP_ADDRESS>

Describe the bug
When in a rails console, if you then enter into a debug session (debugger in the console, or anywhere in code that is executed in console) and type the character ), the debugger crashes along with the rails console.
Stack Trace below:
To Reproduce

Enter into a rails console (rails console)
Invoke a debug session: (debugger)
Type right parenthesis character: )

Expected behavior
Expect the character to show up and the console to not force close out
Stack Trace
irb(main):001:0> debugger
[1, 1] in (irb)
=>   1| debugger
=>#0	<main> at (irb):1
  #1	[C] Kernel#eval at ~/.rbenv/versions/3.1.0/lib/ruby/3.1.0/irb/workspace.rb:119
  # and 27 frames (use `bt' command for all frames)
(rdbg) )=> mainuby **THIS IS THE LINE WHICH BREAKS**

irb(main):002:0> #<Thread:0x000000010aa64950@DEBUGGER__::SESSION@server .../.rbenv/versions/3.1.0/lib/ruby/gems/3.1.0/gems/debug-1.4.0/lib/debug/session.rb:148 run> terminated with exception (report_on_exception is true):
.../.rbenv/versions/3.1.0/lib/ruby/gems/3.1.0/gems/debug-1.4.0/lib/debug/console.rb:55:in `block in readline_setup': unmatched close parenthesis: /\\A)/ (RegexpError)
	from .../.rbenv/versions/3.1.0/lib/ruby/gems/3.1.0/gems/reline-0.3.1/lib/reline/line_editor.rb:1677:in `call_completion_proc_with_checking_args'
	from .../.rbenv/versions/3.1.0/lib/ruby/gems/3.1.0/gems/reline-0.3.1/lib/reline/line_editor.rb:543:in `call_completion_proc_with_checking_args'
	from .../.rbenv/versions/3.1.0/lib/ruby/gems/3.1.0/gems/reline-0.3.1/lib/reline.rb:226:in `block in <class:Core>'
	from .../.rbenv/versions/3.1.0/lib/ruby/gems/3.1.0/gems/reline-0.3.1/lib/reline/line_editor.rb:588:in `instance_exec'
	from .../.rbenv/versions/3.1.0/lib/ruby/gems/3.1.0/gems/reline-0.3.1/lib/reline/line_editor.rb:588:in `call'
	from .../.rbenv/versions/3.1.0/lib/ruby/gems/3.1.0/gems/reline-0.3.1/lib/reline/line_editor.rb:623:in `call'
	from .../.rbenv/versions/3.1.0/lib/ruby/gems/3.1.0/gems/reline-0.3.1/lib/reline/line_editor.rb:667:in `render_each_dialog'
	from .../.rbenv/versions/3.1.0/lib/ruby/gems/3.1.0/gems/reline-0.3.1/lib/reline/line_editor.rb:651:in `block in render_dialog'
	from .../.rbenv/versions/3.1.0/lib/ruby/gems/3.1.0/gems/reline-0.3.1/lib/reline/line_editor.rb:650:in `each'
	from .../.rbenv/versions/3.1.0/lib/ruby/gems/3.1.0/gems/reline-0.3.1/lib/reline/line_editor.rb:650:in `render_dialog'
	from .../.rbenv/versions/3.1.0/lib/ruby/gems/3.1.0/gems/reline-0.3.1/lib/reline/line_editor.rb:510:in `rerender'
	from .../.rbenv/versions/3.1.0/lib/ruby/gems/3.1.0/gems/reline-0.3.1/lib/reline.rb:330:in `block (3 levels) in inner_readline'
	from .../.rbenv/versions/3.1.0/lib/ruby/gems/3.1.0/gems/reline-0.3.1/lib/reline.rb:328:in `each'
	from .../.rbenv/versions/3.1.0/lib/ruby/gems/3.1.0/gems/reline-0.3.1/lib/reline.rb:328:in `block (2 levels) in inner_readline'
	from .../.rbenv/versions/3.1.0/lib/ruby/gems/3.1.0/gems/reline-0.3.1/lib/reline.rb:403:in `block in read_io'
	from .../.rbenv/versions/3.1.0/lib/ruby/gems/3.1.0/gems/reline-0.3.1/lib/reline.rb:373:in `loop'
	from .../.rbenv/versions/3.1.0/lib/ruby/gems/3.1.0/gems/reline-0.3.1/lib/reline.rb:373:in `read_io'
	from .../.rbenv/versions/3.1.0/lib/ruby/gems/3.1.0/gems/reline-0.3.1/lib/reline.rb:326:in `block in inner_readline'
	from .../.rbenv/versions/3.1.0/lib/ruby/gems/3.1.0/gems/reline-0.3.1/lib/reline.rb:324:in `loop'
	from .../.rbenv/versions/3.1.0/lib/ruby/gems/3.1.0/gems/reline-0.3.1/lib/reline.rb:324:in `inner_readline'
	from .../.rbenv/versions/3.1.0/lib/ruby/gems/3.1.0/gems/reline-0.3.1/lib/reline.rb:254:in `readmultiline'
	from .../.rbenv/versions/3.1.0/lib/ruby/3.1.0/forwardable.rb:238:in `readmultiline'
	from .../.rbenv/versions/3.1.0/lib/ruby/gems/3.1.0/gems/debug-1.4.0/lib/debug/console.rb:101:in `block in readline'
	from .../.rbenv/versions/3.1.0/lib/ruby/gems/3.1.0/gems/debug-1.4.0/lib/debug/console.rb:82:in `readline_setup'
	from .../.rbenv/versions/3.1.0/lib/ruby/gems/3.1.0/gems/debug-1.4.0/lib/debug/console.rb:100:in `readline'
	from .../.rbenv/versions/3.1.0/lib/ruby/gems/3.1.0/gems/debug-1.4.0/lib/debug/local.rb:72:in `block in readline'
	from .../.rbenv/versions/3.1.0/lib/ruby/gems/3.1.0/gems/debug-1.4.0/lib/debug/local.rb:84:in `block in setup_interrupt'
	from .../.rbenv/versions/3.1.0/lib/ruby/gems/3.1.0/gems/debug-1.4.0/lib/debug/session.rb:1689:in `intercept_trap_sigint'
	from .../.rbenv/versions/3.1.0/lib/ruby/gems/3.1.0/gems/debug-1.4.0/lib/debug/local.rb:77:in `setup_interrupt'
	from .../.rbenv/versions/3.1.0/lib/ruby/gems/3.1.0/gems/debug-1.4.0/lib/debug/local.rb:71:in `readline'
	from .../.rbenv/versions/3.1.0/lib/ruby/gems/3.1.0/gems/debug-1.4.0/lib/debug/session.rb:373:in `wait_command'
	from .../.rbenv/versions/3.1.0/lib/ruby/gems/3.1.0/gems/debug-1.4.0/lib/debug/session.rb:333:in `block in wait_command_loop'
	from .../.rbenv/versions/3.1.0/lib/ruby/gems/3.1.0/gems/debug-1.4.0/lib/debug/session.rb:332:in `loop'
	from .../.rbenv/versions/3.1.0/lib/ruby/gems/3.1.0/gems/debug-1.4.0/lib/debug/session.rb:332:in `wait_command_loop'
	from .../.rbenv/versions/3.1.0/lib/ruby/gems/3.1.0/gems/debug-1.4.0/lib/debug/session.rb:254:in `process_event'
	from .../.rbenv/versions/3.1.0/lib/ruby/gems/3.1.0/gems/debug-1.4.0/lib/debug/session.rb:198:in `session_server_main'
	from .../.rbenv/versions/3.1.0/lib/ruby/gems/3.1.0/gems/debug-1.4.0/lib/debug/session.rb:168:in `block in activate'
.../.rbenv/versions/3.1.0/lib/ruby/gems/3.1.0/gems/debug-1.4.0/lib/debug/console.rb:55:in `block in readline_setup': unmatched close parenthesis: /\\A)/ (RegexpError)
	from .../.rbenv/versions/3.1.0/lib/ruby/gems/3.1.0/gems/reline-0.3.1/lib/reline/line_editor.rb:1677:in `call_completion_proc_with_checking_args'
	from .../.rbenv/versions/3.1.0/lib/ruby/gems/3.1.0/gems/reline-0.3.1/lib/reline/line_editor.rb:543:in `call_completion_proc_with_checking_args'
	from .../.rbenv/versions/3.1.0/lib/ruby/gems/3.1.0/gems/reline-0.3.1/lib/reline.rb:226:in `block in <class:Core>'
	from .../.rbenv/versions/3.1.0/lib/ruby/gems/3.1.0/gems/reline-0.3.1/lib/reline/line_editor.rb:588:in `instance_exec'
	from .../.rbenv/versions/3.1.0/lib/ruby/gems/3.1.0/gems/reline-0.3.1/lib/reline/line_editor.rb:588:in `call'
	from .../.rbenv/versions/3.1.0/lib/ruby/gems/3.1.0/gems/reline-0.3.1/lib/reline/line_editor.rb:623:in `call'
	from .../.rbenv/versions/3.1.0/lib/ruby/gems/3.1.0/gems/reline-0.3.1/lib/reline/line_editor.rb:667:in `render_each_dialog'
	from .../.rbenv/versions/3.1.0/lib/ruby/gems/3.1.0/gems/reline-0.3.1/lib/reline/line_editor.rb:651:in `block in render_dialog'
	from .../.rbenv/versions/3.1.0/lib/ruby/gems/3.1.0/gems/reline-0.3.1/lib/reline/line_editor.rb:650:in `each'
	from .../.rbenv/versions/3.1.0/lib/ruby/gems/3.1.0/gems/reline-0.3.1/lib/reline/line_editor.rb:650:in `render_dialog'
	from .../.rbenv/versions/3.1.0/lib/ruby/gems/3.1.0/gems/reline-0.3.1/lib/reline/line_editor.rb:510:in `rerender'
	from .../.rbenv/versions/3.1.0/lib/ruby/gems/3.1.0/gems/reline-0.3.1/lib/reline.rb:330:in `block (3 levels) in inner_readline'
	from .../.rbenv/versions/3.1.0/lib/ruby/gems/3.1.0/gems/reline-0.3.1/lib/reline.rb:328:in `each'
	from .../.rbenv/versions/3.1.0/lib/ruby/gems/3.1.0/gems/reline-0.3.1/lib/reline.rb:328:in `block (2 levels) in inner_readline'
	from .../.rbenv/versions/3.1.0/lib/ruby/gems/3.1.0/gems/reline-0.3.1/lib/reline.rb:403:in `block in read_io'
	from .../.rbenv/versions/3.1.0/lib/ruby/gems/3.1.0/gems/reline-0.3.1/lib/reline.rb:373:in `loop'
	from .../.rbenv/versions/3.1.0/lib/ruby/gems/3.1.0/gems/reline-0.3.1/lib/reline.rb:373:in `read_io'
	from .../.rbenv/versions/3.1.0/lib/ruby/gems/3.1.0/gems/reline-0.3.1/lib/reline.rb:326:in `block in inner_readline'
	from .../.rbenv/versions/3.1.0/lib/ruby/gems/3.1.0/gems/reline-0.3.1/lib/reline.rb:324:in `loop'
	from .../.rbenv/versions/3.1.0/lib/ruby/gems/3.1.0/gems/reline-0.3.1/lib/reline.rb:324:in `inner_readline'
	from .../.rbenv/versions/3.1.0/lib/ruby/gems/3.1.0/gems/reline-0.3.1/lib/reline.rb:254:in `readmultiline'
	from .../.rbenv/versions/3.1.0/lib/ruby/3.1.0/forwardable.rb:238:in `readmultiline'
	from .../.rbenv/versions/3.1.0/lib/ruby/gems/3.1.0/gems/debug-1.4.0/lib/debug/console.rb:101:in `block in readline'
	from .../.rbenv/versions/3.1.0/lib/ruby/gems/3.1.0/gems/debug-1.4.0/lib/debug/console.rb:82:in `readline_setup'
	from .../.rbenv/versions/3.1.0/lib/ruby/gems/3.1.0/gems/debug-1.4.0/lib/debug/console.rb:100:in `readline'
	from .../.rbenv/versions/3.1.0/lib/ruby/gems/3.1.0/gems/debug-1.4.0/lib/debug/local.rb:72:in `block in readline'
	from .../.rbenv/versions/3.1.0/lib/ruby/gems/3.1.0/gems/debug-1.4.0/lib/debug/local.rb:84:in `block in setup_interrupt'
	from .../.rbenv/versions/3.1.0/lib/ruby/gems/3.1.0/gems/debug-1.4.0/lib/debug/session.rb:1689:in `intercept_trap_sigint'
	from .../.rbenv/versions/3.1.0/lib/ruby/gems/3.1.0/gems/debug-1.4.0/lib/debug/local.rb:77:in `setup_interrupt'
	from .../.rbenv/versions/3.1.0/lib/ruby/gems/3.1.0/gems/debug-1.4.0/lib/debug/local.rb:71:in `readline'
	from .../.rbenv/versions/3.1.0/lib/ruby/gems/3.1.0/gems/debug-1.4.0/lib/debug/session.rb:373:in `wait_command'
	from .../.rbenv/versions/3.1.0/lib/ruby/gems/3.1.0/gems/debug-1.4.0/lib/debug/session.rb:333:in `block in wait_command_loop'
	from .../.rbenv/versions/3.1.0/lib/ruby/gems/3.1.0/gems/debug-1.4.0/lib/debug/session.rb:332:in `loop'
	from .../.rbenv/versions/3.1.0/lib/ruby/gems/3.1.0/gems/debug-1.4.0/lib/debug/session.rb:332:in `wait_command_loop'
	from .../.rbenv/versions/3.1.0/lib/ruby/gems/3.1.0/gems/debug-1.4.0/lib/debug/session.rb:254:in `process_event'
	from .../.rbenv/versions/3.1.0/lib/ruby/gems/3.1.0/gems/debug-1.4.0/lib/debug/session.rb:198:in `session_server_main'
	from .../.rbenv/versions/3.1.0/lib/ruby/gems/3.1.0/gems/debug-1.4.0/lib/debug/session.rb:168:in `block in activate'

Thank you!

@st0012 There seems to be quite a few fixes on master. When can we expect a new release?

In March this year. Sorry for absent.


Added bTorrent's wss tracker

Nice - just a few questions.
Where is this tracker hosted? Can you guarantee reasonable uptime?

The tracker is hosted on my personal dedicated server. Hosted on PA, US. I can guarantee over 99% uptime.
Worst case escenario I have another dedicated server in Miami available to take over.
Both hosted in datacenters with supposedly 99.99% uptime and 100% uptime SLA.

Sounds good – just wanted to make sure this wasn't on some free heroku instance. Thanks for chipping in and running a tracker!


API: Add support for system/environment varaibles for the properties keys

People want to have properties for different environments in the same configuration-file:

https://github.com/matteobaccan/owner/issues/274
https://github.com/matteobaccan/owner/issues/281

Solution is: system/environment varaibles support in keys ( similarly to #28)
e.g.:
#default
host=
port=

#development
dev.host=
dev.port=

#staging
staging.host=
staging.port=

#prod
prod.host=
prod.port=

source-interface:
@Config public interface MyServer {
    @Key("{env}.host") URL host();
    @Key("{env}.port") int port();
}

or
@Config @Prefix("{env}") public interface MyServer {
    URL host();
    int port();
}

Warning:

If the system/environment varaibles not exists, empty-string should be used as the value.
start/end/multiple points should be "trimmed".

system property value
key config
resulting key

dev
{env}.host
dev.host

{env}.host
host

dev
server.{env}.host
server.dev.host

server.{env}.host
server.host

done.


Desktop. DropdownMenu. Ripple effect doesn't end if we move a pressed mouse outside of popup

Compose 0.5.0-build229
import androidx.compose.desktop.Window
import androidx.compose.material.Button
import androidx.compose.material.DropdownMenu
import androidx.compose.material.DropdownMenuItem
import androidx.compose.material.MaterialTheme
import androidx.compose.material.Text
import androidx.compose.runtime.getValue
import androidx.compose.runtime.mutableStateOf
import androidx.compose.runtime.remember
import androidx.compose.runtime.setValue

fun main() = Window {
    MaterialTheme {
        var expandedState by remember { mutableStateOf(false) }
        Button(onClick = { expandedState = !expandedState }) {
            Text("Menu")
        }
        DropdownMenu(expanded = expandedState, onDismissRequest = { expandedState = false }) {
            DropdownMenuItem({}) {}
        }
    }
}

Press mouse button down on the item
Move mouse outside of the popup
Release mouse button

Expected:
Ripple effect ends when we move outside of the item
Actual:
Ripple effect stays
https://user-images.githubusercontent.com/5963351/124123598-28cb1900-da80-11eb-8c16-8fd19fe30e87.mp4

Should be fixed in 1.0.0-rc3

Please check the following ticket on YouTrack for follow-ups to this issue. GitHub issues will be closed in the coming weeks.


Always close files after requests

Summary
This PR ensures that any files used in requests will be closed once the request finishes, instead of keeping them open until they are garbage collected.
Not closing files is technically not an issue in most cases, as CPython already closes files when they're garbage collected, usually once the ref count drops to zero. However, this behavior might be different in alternative implementations, and it's also just good practice in general.
Checklist

[x] If code changes were made then they have been tested

[ ] I have updated the documentation to reflect the changes
[x] I have formatted the code properly by running black .

[x] This PR fixes an issue
[ ] This PR adds something new (e.g. new method or parameters)
[ ] This PR is a breaking change (e.g. methods or parameters removed/renamed)
[ ] This PR is not a code change (e.g. documentation, README, ...)

An additional comment, forgot to mention that in the PR:
It should be a safe change, since files are already being closed in a similar fashion at some points, e.g. https://github.com/DisnakeDev/disnake/blob/master/disnake/abc.py#L1428

Some weird stuff going on in file.py...

Yup. The issue is that aiohttp closes files once they're done writing:
https://github.com/aio-libs/aiohttp/blob/3.7/aiohttp/payload.py#L299
This broke dpy's retry logic, since it would seek back to the start of the files on each attempt.
The workaround was to stub the original close() method and take care of closing the files manually:
https://github.com/Rapptz/discord.py/commit/5e65ec978cf278fefcc5586e2df732bc7a8bed4e
https://github.com/Rapptz/discord.py/blob/master/discord/abc.py#L1418-L1420
Although now I'm wondering why files aren't just being closed in request() itself, instead of at its callsites...

Although now I'm wondering why files aren't just being closed in request() itself, instead of at its callsites...

Alright, doing that seems to work, but I'd rather not risk it and break something down the line. The current implementation in the PR is fine, and works basically the same way, albeit with repeated code.

Why isn't this merged yet?


Left menu separators

Visually, it would be very helpful to use some separators on the left menu considering there are so many items.  See attached.  This gives some visual separation between the governance menu items and the others.

done this one , it's in the dev version by now. will go to production(version without :9009) soon with some other changes. by now check the separators at:
http://bitshares-explorer.io:9009/#/dashboard

cool.  it's definitely an improvement.  the more visually distinct the separator is, the better!

added the separators to the distribution version (http://bitshares-explorer.io), closing the issue.


Allow to download without unpacking

With
{"source": {"only_download": true, "uri": "https://d26ekeud912fhb.cloudfront.net/bosh-stemcell/aws/light-bosh-stemcell-2969-aws-xen-hvm-ubuntu-trusty-go_agent.tgz"}}

The file would be downloaded into
destination/light-bosh-stemcell-2969-aws-xen-hvm-ubuntu-trusty-go_agent.tgz

You may want the bosh-io-stemcell resource instead (based on your example). The archive resource is primarily used for fly execute.
See https://github.com/concourse/bosh-io-stemcell-resource

@vito my example was just an example. :)

Gonna close this since this resource is really only meant for fly execute and shouldn't need any source configuration really. Thanks for the PR though!


Snapshot version causing Build failure from Central Maven Repo

Plugin name and version
azure-functions-maven-plugin: 1.2.0
Plugin configuration in your pom.xml
<properties>
    <azure.functions.maven.plugin.version>1.2.0</azure.functions.maven.plugin.version>
      <azure.functions.java.library.version>1.2.0</azure.functions.java.library.version>
 </properties>
.....
<plugin>
 <groupId>com.microsoft.azure</groupId>
 <artifactId>azure-functions-maven-plugin</artifactId>
 <version>${azure.functions.maven.plugin.version}</version>
</plugin>

Expected behavior
We should be able to download all dependencies from Central Maven Repo
Actual behavior
Maven build is failing as given Plugin referring a parent with SNAPSHOT version, which does not exist in Central Maven Repo.
Steps to reproduce the problem
http://central.maven.org/maven2/com/microsoft/azure/azure-functions-maven-plugin/1.2.0/azure-functions-maven-plugin-1.2.0.pom
We are unable to connect to OSS due to enterprise issues.  When we only have Central Maven,  we are unable to use azure-functions-maven-plugin and run build.
Please update necessary versions and publish them to Central Repo.
Thanks

@anumalasri  Thanks for your report, we have released new version of Function Plugin and Plugin lib, all snapshot dependency has been removed in our repo, but some of our dependency may still depend on libs with SNAPSHOT version, please have a test whether function plugin could work now.

Closed as all dependencies has been updated to stable versions.


Adds local e2e to CI.

Description
Adds local e2e to CI.
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #2102
Checklist
Please make sure you've  completed the relevant tasks for this PR, out of the following list:

[ ] Code compiles correctly
[ ] Created/updated tests
[ ] Unit tests passing
[ ] End-to-end tests passing
[ ] Extended the documentation / Created issue in the https://github.com/dapr/docs/ repo: dapr/docs#[issue number]
[ ] Specification has been updated / Created issue in the https://github.com/dapr/docs/ repo: dapr/docs#[issue number]
[ ] Provided sample for the feature / Created issue in the https://github.com/dapr/docs/ repo: dapr/docs#[issue number]

The e2e test ran for over 2 hrs. So only cancelled it.

I recommend using the KinD solution from #2144 instead.


Create a playbook for updating the LIVD table

Is your feature request related to a problem? Please describe.
Create a playbook markdown file that outlines how to update the LIVD table
Background
LVID table tracks new devices as well as changes in the status of a device as it goes from EUA to regular authorization. While new devices are easy to handle, changes in the status of a device can lead to change in the information in the M or O column of a device. Since senders could be using an old device-id value, the change of this table could lead to a broken feed.
Describe the solution you'd like

Where to get the LIVD table
Conversion process
Checks that are needed
Testing of the popular (in use) devices

Waiting for review. Change request to PR submitted.

@RickHawesUSDS to review.

@jorg3lopez please update based on current progress

@jorg3lopez to work on today.


Add waypoints list and add stop button

Details

Fixed Issues

$ https://github.com/Expensify/App/issues/22700
PROPOSAL: N/A
Tests

Sign in with an @expensifail.com account
Click the green plus, request money
Click the distance tab
Verify that you see start and stop waypoints only, and an add stop button
Click add stop
Verify a stop is added
Add two more stops for a total of 5
Verify the bottom waypoint is fading out
Scroll down to the bottom
Verify the bottom waypoint is not faded
Close the modal
Click the green plus, request money
Verify the distance tab is still selected and there are 5 waypoints

[ ] Verify that no errors appear in the JS console

Offline tests

Sign in then go offline and run the tests above
QA Steps

Same as tests

[ ] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

https://github.com/Expensify/App/assets/26260477/32db0fc6-0408-4d5c-8312-85e1b0bb4b71

Mobile Web - Chrome

https://github.com/Expensify/App/assets/26260477/09214c73-14ef-4413-ac13-fb69ae287ad6

Mobile Web - Safari

https://github.com/Expensify/App/assets/26260477/0ddd1250-7c2a-45e1-a9d8-513add154925

Desktop

https://github.com/Expensify/App/assets/26260477/4ceb2b8c-299f-4916-8058-2cb4a74ba616

iOS

https://github.com/Expensify/App/assets/26260477/cd5552d9-320e-4076-8a9d-fca2f53146f2

Android

https://github.com/Expensify/App/assets/26260477/ee1c6f56-c0b0-4c0b-840b-aa75eb4c7f30

@shawnborton may I please have an early review of this? Here's what I have so far. Do you have any recommendations?
May I please also have the following icons as .svg files? The "hamburger" Expensicon for the drag handles on the waypoints and the Maki icon "marker". I think we should use a filled white dot for the start waypoint, (or maybe a white circle), the gray dot for the stops, and a gray (or red?) marker for the finish. I think it's nice to be able to match them up between the waypoints in the list and the icons on the map in the future.
https://github.com/Expensify/App/assets/26260477/535778a9-dd0e-4595-84c6-1dc3c44d693c
Oooh I think it looks a bit better with a gradient from transparent to the background color vs black.
https://github.com/Expensify/App/assets/26260477/85ebd652-96eb-450a-bb26-d709074d78a4

Will work on getting the icons now.
A couple of questions in the meantime:

If there is no map, why does this only take up half of the screen height?
For the icons you requested, I'll give them all to you in pure black and then we can control colors via styling
For the "Add Stop" button, the icon in the button should use our icon color
The top tabs are not updated to match our latest styles. I think @AndrewGable updated these recently with the SmartScan project.

Also, looks like you are using the wrong icon for drag handles in your mocks - we have an icon for drag handles already:

Here are the icons you need though: distanceicons.zip
You can use the dot indicator icon that already exists for the circle.

Let's try without modifying the icon size so we can keep them all consistent at 20x20. If we need to make a new dot indicator (smaller), we totally can. But let's first go with consistency.

Ok I added the new icons and it's looking pretty good. I want to differentiate the start waypoint from the stops based on the icon. The white filled circle doesn't really work because that's the color when an icon is hovered.

Would you please send me a circle icon that's like the dot indicator but unfilled? I think that would look good for the start icon, matching the color of the others.

Here is an unfilled version: Uploading dot-indicator-unfilled.svg.zip…
Still curious to see how this all works in the full flow though, so let me know when you have some screenshots ready for review!

Note: remember to do this https://github.com/Expensify/App/pull/23048#issuecomment-1670135062

@neil-marcellini Do we need @expensifail.com or any beta to test this?

Yes see step 1, or enable all betas locally.

Assigning C+ from Slack for #urgency

Reviewer Checklist

[x] I have verified the author checklist is complete (all boxes are checked off).
[x] I verified the correct issue is linked in the ### Fixed Issues section above
[x] I verified testing steps are clear and they cover the changes made in this PR

[x] I verified the steps for local testing are in the Tests section
[x] I verified the steps for Staging and/or Production testing are in the QA steps section
[x] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[x] I checked that screenshots or videos are included for tests on all platforms
[x] I included screenshots or videos for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[x] I verified proper code patterns were followed (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I verified that this PR follows the guidelines as stated in the Review Guidelines
[x] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[ ] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web & Desktop
https://github.com/Expensify/App/assets/85645967/912fc893-289e-4381-8ea1-db71f98f458c
Offline
https://github.com/Expensify/App/assets/85645967/8c5d8bcf-5014-4ed9-9cd7-d1bceca0c278

Mobile Web - Chrome & Mobile Web - Safari
https://github.com/Expensify/App/assets/85645967/0a68b5e1-2f9e-4691-8944-303f56ef2b1e

iOS

Android

@neil-marcellini
Fade-out shade looks different on mWeb Safari

@neil-marcellini bump!

👀

Fade-out shade looks different on iOS

I don't know if that's a large enough difference to be worth investigating and fixing it right now. I would like to leave it as is. Maybe we do a follow up though if it's a problem? What do you think @shawnborton?

Are the drag handles supposed to be green? I had this from our mockups:

Yeah I saw that the mockup is different but I think it makes sense to change in this use case.

I would think all standard icons use our default icon color. I could see giving the waypoint icons a slightly different color to make them look a bit different since they are more like labels and less like icon buttons though.

The drag handle icon is passed to the menu item component without specifying an iconFill so it is using the default color in the context of that component.
https://github.com/Expensify/App/blob/58f6ab586c07b28ddcc779c98fdcf3dc51950c19/src/components/DistanceRequest.js#L112-L119
In the component we set the color based on the user's interaction, and that's fairly complicated. Overall I think we should leave the drag handle icons with their color based on the interaction on it. I think it makes sense to set a static color on the waypoint icons because they aren't interactive.
https://github.com/Expensify/App/blob/8131df576b10bd4ff2b89d4affd1a4b717f1cfd3/src/components/MenuItem.js#L164-L177
Do you agree with that or do you think about it differently @shawnborton?

Thanks for the feedback. I responded to everything here and I would appreciate another review.

Fade-out shade looks different on iOS

I don't know if that's a large enough difference to be worth investigating and fixing it right now. I would like to leave it as is. Maybe we do a follow up though if it's a problem? What do you think @shawnborton?

@neil-marcellini We should have a follow-up for this, as it is inconsistent something that we need to address. It's not pressing here but let's just create an issue ourselves to save some bounty on reporting, thanks!

Do you agree with that or do you think about it differently

I think that makes sense, but do you have updated screenshots I can review? Again, I think the drag handles should just use our standard icon color and we can make the waypoint icons use something else.

I created a follow up issue here to have the fade out shade addressed https://github.com/Expensify/App/issues/24447 along with the other NAB comments that Santhosh-Sellavel left.
I'm going to merge this since it seems like the concerns are addressed except for the color of the drag handles. I'll then address the drag handles color change in my PR and ideally get that merged today so it should be live at the same time.
This just allows me to unblock the other PRs that are held on this since we're still aiming to get this done by a deadline but should not affect design quality

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/thienlnam in version: 1.3.54-0 🚀

platform
result

🤖 android 🤖
failure ❌

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅

🚀 Deployed to staging by https://github.com/thienlnam in version: 1.3.54-0 🚀

platform
result

🤖 android 🤖
failure ❌

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/yuwenmemon in version: 1.3.54-13 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Prop validation prevent correct rendering of components in async situations

When I tried to restrict the component's props to a specific type but the data is not already set or correct (like undefined or different from the expected type), the component doesn't render properly even if in the future the data is filled with proper values (typically an async call to other resources).
Example of this situation in this jsfiddle

This is working as intended as far as I can tell, because you are initially passing down items as '', which is a string and is indeed a wrong type.
Just give the parent items the initial value of an empty array and it works properly: https://jsfiddle.net/yyx990803/fgsw9ssu/30/


replace JSON search results by HTML and fix issues in service_flask.py

Added welcome page with url="/".
Added error page when searching.
Added results page with JINJA templates.

Can you check what this error is and rebase:
Traceback (most recent call last):
  File "/home/sandeeppanku/anaconda3/envs/hpr/lib/python3.7/site-packages/flask/app.py", line 2328, in __call__
    return self.wsgi_app(environ, start_response)
  File "/home/sandeeppanku/anaconda3/envs/hpr/lib/python3.7/site-packages/flask/app.py", line 2314, in wsgi_app
    response = self.handle_exception(e)
  File "/home/sandeeppanku/anaconda3/envs/hpr/lib/python3.7/site-packages/flask/app.py", line 1760, in handle_exception
    reraise(exc_type, exc_value, tb)
  File "/home/sandeeppanku/anaconda3/envs/hpr/lib/python3.7/site-packages/flask/_compat.py", line 36, in reraise
    raise value
  File "/home/sandeeppanku/anaconda3/envs/hpr/lib/python3.7/site-packages/flask/app.py", line 2311, in wsgi_app
    response = self.full_dispatch_request()
  File "/home/sandeeppanku/anaconda3/envs/hpr/lib/python3.7/site-packages/flask/app.py", line 1834, in full_dispatch_request
    rv = self.handle_user_exception(e)
  File "/home/sandeeppanku/anaconda3/envs/hpr/lib/python3.7/site-packages/flask/app.py", line 1737, in handle_user_exception
    reraise(exc_type, exc_value, tb)
  File "/home/sandeeppanku/anaconda3/envs/hpr/lib/python3.7/site-packages/flask/_compat.py", line 36, in reraise
    raise value
  File "/home/sandeeppanku/anaconda3/envs/hpr/lib/python3.7/site-packages/flask/app.py", line 1832, in full_dispatch_request
    rv = self.dispatch_request()
  File "/home/sandeeppanku/anaconda3/envs/hpr/lib/python3.7/site-packages/flask/app.py", line 1818, in dispatch_request
    return self.view_functions[rule.endpoint](**req.view_args)
  File "/home/sandeeppanku/Public/Code/Autocomplete-System/service_flask.py", line 28, in autocomplete
    search_result = server.search(params.get('term'))
  File "/home/sandeeppanku/Public/Code/Autocomplete-System/src/Server.py", line 316, in search
    raise TypeError("{} is not a string".format(search_term))
TypeError: None is not a string
2019-06-30 21:40:57,877 - werkzeug - INFO - <IP_ADDRESS> - - [30/Jun/2019 21:40:57] "GET /search?__debugger__=yes&cmd=resource&f=style.css HTTP/1.1" 200 -
2019-06-30 21:40:57,879 - werkzeug - INFO - <IP_ADDRESS> - - [30/Jun/2019 21:40:57] "GET /search?__debugger__=yes&cmd=resource&f=jquery.js HTTP/1.1" 200 -
2019-06-30 21:40:57,879 - werkzeug - INFO - <IP_ADDRESS> - - [30/Jun/2019 21:40:57] "GET /search?__debugger__=yes&cmd=resource&f=debugger.js HTTP/1.1" 200 -
2019-06-30 21:40:57,911 - werkzeug - INFO - <IP_ADDRESS> - - [30/Jun/2019 21:40:57] "GET /search?__debugger__=yes&cmd=resource&f=console.png HTTP/1.1" 200 -
2019-06-30 21:40:57,953 - werkzeug - INFO - <IP_ADDRESS> - - [30/Jun/2019 21:40:57] "GET /search?__debugger__=yes&cmd=resource&f=console.png HTTP/1.1" 200 -
2019-06-30 21:41:42,995 - werkzeug - INFO - <IP_ADDRESS> - - [30/Jun/2019 21:41:42] "GET / HTTP/1.1" 404 -
2019-06-30 21:41:47,478 - werkzeug - INFO - <IP_ADDRESS> - - [30/Jun/2019 21:41:47] "GET /search HTTP/1.1" 500

The above error occurs at - http://localhost:5001/search

Looks good on dev


Make pappus library

Arduino header file and cpp file (Arduino library)

Add humanReadableTimestamp function to pappus library

Based off this library -> https://learn.adafruit.com/adafruit-rfm69hcw-and-rfm96-rfm95-rfm98-lora-packet-padio-breakouts/advanced-circuitpython-library-usage-2


Standardize usage of webmachine dependency

These are the dependencies changes for the sigv4 work.  Assumes merged erlang22 and license scout + erlcloud dep PRs.
This PR is part of a broader effort to replace AWS sigv2 with sigv4, encompassing modifications to oc_erchef, bookshelf, mini_s3, erlcloud, pedant clients, and other systems. In brief, the erlcloud library was wired-in to oc-erchef and bookshelf via mini_s3. oc-erchef was modified to generate sigv4 requests. bookshelf was modified to accept sigv4 requests. A host of issues were solved pertaining to host headers and ports, expiration windows, ipv6, etc. Finally, new unit tests exercising various aspects of newly-added functionality were added.
verify:
https://buildkite.com/chef/chef-chef-server-master-verify/builds/2321#497a69af-b34a-4499-993d-8de819cdd079
adhoc:
https://buildkite.com/chef/chef-chef-server-master-omnibus-adhoc/builds/1604#8099f688-112c-49de-b1ae-b364e2bf3bef

Looks like the deps updates are not related to erlang 22, so these also can be done as a separate PR independent of the sig_v4 changes.

The webmachine dep is good to keep consistent with the other erland apps and chef-mover. The sha brings erlang 22 changes.


100% of a thread CPU usage while downloading export templates

Godot version
3.3.2 Stable (from website)
System information
Archlinux, Intel based Laptop
Issue description
When downloading export templates Godot consumes 100% CPU

I would not expect waiting for a file to download to take much processing power.
Steps to reproduce
Go to the export template manager, and start downloading the export templates.
Minimal reproduction project
No response

https://github.com/godotengine/godot/pull/48902 might help with this once it's cherry-picked to the 3.x branch.

Duplicate of https://github.com/godotengine/godot/issues/35868.


Error code gotten in one of 20 parts

Hello,
Earlier today I submitted a 20 smaller CSV parts to the Prosit server. 19 of them worked very fast in fine without any problems. However, for the seventh part (Task ID C73B76C2B33D44D1DDBE6F19582546E3) I got the following error code:
An error occured. Status code: 2
Error log
keyboard_arrow_down
2022-01-27 13:46:09.734102: W tensorflow/stream_executor/platform/default/dso_loader.cc:64] Could not load dynamic library 'libcudart.so.11.0'; dlerror: libcudart.so.11.0: cannot open shared object file: No such file or directory 2022-01-27 13:46:09.734136: I tensorflow/stream_executor/cuda/cudart_stub.cc:29] Ignore above cudart dlerror if you do not have a GPU set up on your machine. Traceback (most recent call last): File "/usr/local/lib/python3.8/runpy.py", line 194, in _run_module_as_main return _run_code(code, main_globals, None, File "/usr/local/lib/python3.8/runpy.py", line 87, in _run_code exec(code, run_globals) File "/root/oktoberfest/main.py", line 8, in  main() File "/root/oktoberfest/oktoberfest.py", line 35, in main run_oktoberfest(args.search_dir, args.config_path) File "/root/oktoberfest/oktoberfest.py", line 160, in run_oktoberfest generate_spectral_lib(search_dir, config_path) File "/root/oktoberfest/oktoberfest.py", line 88, in generate_spectral_lib spec_library.library.spectra_data['MASS'] = spec_library.library.spectra_data['MODIFIED_SEQUENCE'].apply( File "/usr/local/lib/python3.8/site-packages/pandas/core/series.py", line 4357, in apply return SeriesApply(self, func, convert_dtype, args, kwargs).apply() File "/usr/local/lib/python3.8/site-packages/pandas/core/apply.py", line 1043, in apply return self.apply_standard() File "/usr/local/lib/python3.8/site-packages/pandas/core/apply.py", line 1098, in apply_standard mapped = lib.map_infer( File "pandas/_libs/lib.pyx", line 2859, in pandas.libs.lib.map_infer File "/root/oktoberfest/oktoberfest.py", line 89, in  lambda x: compute_peptide_mass(x)) File "/usr/local/lib/python3.8/site-packages/fundamentals/fragments.py", line 84, in compute_peptide_mass forward_sum += constants.AA_MASSES[peptide_sequence[i]] # sum left to right KeyError: '' make: *** [/oktoberfest/Makefile:23: run_oktoberfest] Error 2
I am rather confused, as all other parts worked fine. Could you help me?
Thank you very much in advance,
Philip

Hey Philip,
This is because in this file you have couple of peptides with _ inside the sequence and we can't read such a character. I am not sure what it is supposed to be but you can remove these sequences and then it should work.
Fyi we are supporting bigger csv files now so you don't have to split them anymore.
Best,
Wassim


Restrict behavior of callable classes - analyzer implementation

This is the analyzer component of meta-bug #32152.  See the meta-bug for details.

not quite ready to send out, but I'm working on this in https://dart-review.googlesource.com/c/sdk/+/45141

Marking as P1 since it is the last checkbox on P1 bug #31638, which in turn is the last checkbox on P1 bug #31640.


New package: Jontio.Jaero version <IP_ADDRESS>

Pull request has been created with komac v2.2.1 :rocket:
Resolves: https://github.com/microsoft/winget-pkgs/issues/111381
Microsoft Reviewers: Open in CodeFlow

Verify:

Automatic Validation ended with:

Executable C:\Users\validator\AppData\Local\Microsoft\WinGet\Links\JAERO.exe returned exit code: -1073741515

Automated error analysis suggests -1073741515 may mean STATUS_DLL_NOT_FOUND - possibly due to a dependency on Microsoft.VCRedist.2015+.x64 (or .x86).
(Automated response - build 881.)

@wingetbot waivers Add Validation-Executable-Error


Work around SwiftPM build regression affecting packages with C++ targets

This is a workaround to the SwiftPM issue being fixed here:
https://github.com/apple/swift-package-manager/pull/7267

@swift-ci please test

No longer relevant, the SwiftPM bug was fixed!


Can't switch Metamask to testnet

Also in brave when I try to connect to metamask it launches the brave wallet instead.

The Tezos MetaMask Snap does not support testnets for now. It may be added at a later stage.


Precentage Values Displaying Incorrectly (Decimal Placement Error)

Issue
When using the app on the latest public version, percentage values seemingly have the decimal placed at an incorrect point leading the percentages to display incorrectly.
Screenshot

@L3monP3pp3r what is the locale you're using this on?

@dend I'm using English (South Africa)

Thanks @L3monP3pp3r - I will need to take a look and see how this works in a VM.


Default values prevent AKS from upgrading Kubernetes version and node image

PodDisruptionBudget prevents cluster from upgrading when controller.replicaCount = 1. I would like to suggest you to change controller.replicaCount default value to 2.

Makes sense, thanks for sharing. I'd however add a PodDisruptionBudget only if minAvailable is between 1 and replicas-1, what do you think? #73 implements that approach.

Should be solved in the next controller releases. Closing.

Thank you. I think adding a PodDisruptionBudget only if minAvailable is between 1 and replicas-1 is a good idea.


Support canceling the slow path while copying ParsedFiles

Support canceling the slow path while copying ParsedFiles
Motivation

Copying ParsedFiles can take over a second, so this change improves latency.
Test plan

See included automated tests.

Good questions. I'll get some data after a meeting and get back to you. I might want to make this check more finegrained.

The check adds no measurable overhead. I changed it to be more responsive after making some measurements.


I encountered some problems during the installation. The error report is as follows. Please help me.

I encountered some problems during the installation. The error report is as follows. Please help me.
$ echo $CGO_ENABLED
1
$ echo $CC
gcc
$ go get github.com/wasmerio/go-ext-wasm/wasmer
# github.com/wasmerio/go-ext-wasm/wasmer
wasmerio/go-ext-wasm/wasmer/bridge.go:145: cannot use arity (type C.uint32_t) as type C.uint in argument to _Cfunc_wasmer_import_func_params
wasmerio/go-ext-wasm/wasmer/bridge.go:172: cannot use arity (type C.uint32_t) as type C.uint in argument to _Cfunc_wasmer_import_func_returns
wasmerio/go-ext-wasm/wasmer/bridge.go:304: cannot use C.uint(len(imports)) (type C.uint) as type C.uint32_t in argument to func literal
wasmerio/go-ext-wasm/wasmer/bridge.go:320: cannot use (*C.uchar)(wasmBytes) (type *C.uchar) as type *C.uint8_t in argument to func literal
wasmerio/go-ext-wasm/wasmer/bridge.go:321: cannot use C.uint(wasmBytesLength) (type C.uint) as type C.uint32_t in argument to func literal
wasmerio/go-ext-wasm/wasmer/bridge.go:555: cannot use (*C.uchar)(wasmBytes) (type *C.uchar) as type *C.uint8_t in argument to func literal
wasmerio/go-ext-wasm/wasmer/bridge.go:556: cannot use C.uint(wasmBytesLength) (type C.uint) as type C.uint32_t in argument to func literal
wasmerio/go-ext-wasm/wasmer/bridge.go:685: cannot use C.uint(serializedModuleBytesLength) (type C.uint) as type C.uint32_t in argument to func literal
wasmerio/go-ext-wasm/wasmer/bridge.go:691: cannot use (*C.uchar)(wasmBytes) (type *C.uchar) as type *C.uint8_t in argument to _Cfunc_wasmer_validate
wasmerio/go-ext-wasm/wasmer/bridge.go:692: cannot use C.uint(wasmBytesLength) (type C.uint) as type C.uint32_t in argument to _Cfunc_wasmer_validate
wasmerio/go-ext-wasm/wasmer/bridge.go:692: too many errors

Thanks for the report.
What's your OS? What's your Go version?

Thanks for the report.
What's your OS? What's your Go version?

Thank you for your reply. My operating system and go version are as follows.
$ uname -a
Linux ubuntu 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 10:58:50 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
$ go version
go version go1.9.2 linux/amd64

Thanks for the report.
What's your OS? What's your Go version?

The problem was solved by changing to another version of the system and go, thanks!
$ cat /etc/lsb-release
DISTRIB_ID=Ubuntu
DISTRIB_RELEASE=16.04
DISTRIB_CODENAME=xenial
DISTRIB_DESCRIPTION="Ubuntu 16.04.6 LTS"
$ uname -a
Linux fenghm 4.15.0-45-generic #48~16.04.1-Ubuntu SMP Tue Jan 29 18:03:48 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
$ go version
go version go1.13.10 linux/amd64

We expect Go 1.13 at least :-).


Boom file

I think boom file is incorrect / incomplete.

Why?

Why?

More of a request then an issue hehe, the "Supplier and ref" is missing.

You can buy components wherever you want Digikey.com, lcsc.com.... right now it's hard to find components in one place.

Added manufacturer's part numbers for important parts only. for resistors and LEDs there are sizes and values.

I've attempted to upload this to PCBway and have them assemble. It would appear they are having issues with your formatting. The assembly step has been in audit for hours with no response from PCBway.
Any suggestions?

I think they need to check components' stock disponibility..... so wait until the audit ends "It can take 24+ hours"

They are having issues with designators and part numbers on the last 3 items.
They also asked about the battery but I can purchase separate.

30

1

Fresnel lens   for AS312
Aliexpress

31

1

433/868/915Mhz Spring   Antenna90d
Aliexpress

32

1
MY-AA-04
MYOUNG MY-AA-04 AA   Battery Holder
C2979179

T-B2W582299A-5sets-MailBox_Guard_Boom(2023-12-16).xls

30,31 You need to buy from Ali and hand solder, 32 from LCSC need to be hand-soldered on the back side of the PCB.   PS: how much do they want for full assembly + shipping? is the difference very big? compared to my store?

I know those need to be hand soldered but hoping if I just added that note, they could just throw them in the box (save me on cost since I don't need batches of 10+).
I started this with 5 units but I only need 1. They are the same cost 1 vs 5 accept when it comes to the individual parts. So If I take it back down to 1 assembled and shipped, I think I'm looking at $48-$50 US. Right now I'm just getting quotes.
I'd much rather just purchase from you since it is your design and I like helping the little guy but with yours + shipping + and EU conversion, it's $70 just for one unit without anything else. I was going to spend over $100 for a mailbox sensor.

868Mhz version tested + shipping is 65.45 USD / 433 is 61 USD. For me no difference whether you pay for an assembly service or buy a directly from my shop. The main thing for me is that you liked the project! if you have any questions about the setup, open a discussion, good luck 👍


Why pesq is always activate?

when using config of visqol, why pesq is mentioned?
no matter which config I try, there's always
WARNING:root:Using the discrete_speech_metrics package for evaluation
WARNING:root:Using the PESQ package for evaluation

Thanks for the note! We import all functional API in the base versa/__init__.py for future functional support. Therefore, all the packages will pass an import check (usually done very fast) when using versa each time.
But yeah, this information would be annoying. We will try to clean it in our next major update!


New tag comments-waitlist needs description and pretty name

The email management page needs to have a description added for a few tags, or the tags not not be made public.

Didn't we agree new tags won't be public? I'll make sure this is filed. But I'm pretty sure comments-waitlist was set to non public.
@kauffj, do we want users to be able to unsub from the comments waitlist?

Maybe, but I did not make any changes. The real solution is to adjust the user interface to allow people to set these fields. I created an PR for our APIs to make sure the default behavior is to make new tags not public and not user addable.

But I'm pretty sure comments-waitlist was set to non public.

It was, but I made it public because @seanyesmunt needs this tag manageable from the edit API. In order for it to be manageable it needs to be a public tag.

I just (crudely) made it stop rendering tags without descriptions (https://github.com/lbryio/lbry.io/commit/bc1dbacf75b2b63dffe99eaa2ddbd975656f1400).
@lbryio/growth members, public tags will no longer show up on editing email unless descriptions have explicitly been set in the website codebase
@tiger5226 could you file a tag in internal-apis to make relevant tag and api-forms changes so that this can stop being hard-coded in lbry.io?

Will do

I'm closing this, since I don't think we actually want this tag visible.


Arrow masks not working

I assign mcv_leftArrowMask and mcvRightArrowMask on the view, but it still displays with the default arrow drawables. Upon checking the code, the method setupChildren() is called at the bottom of the constructor, which is after the custom arrow mask drawables have been set. This means the custom ones are overwritten with the default ones.
This must have been changed in the most recent release, as it worked fine before I updated to latest version of the library. Tried looking through the commit history, but didn't find the commit that caused this.

I have this bug too

I have this bug too (only when setting masks via XML: via Java code works fine).

Fixed in v1.4.2


[BUG] No title on subItems throws config lint warning

Environment
Self-Hosted (Docker)
System
linux x86_64 Ubuntu 22.04.4 LTS, Docker 24.0.7
Version
2.1.2, 2.1.1
Describe the problem
Docs state a title is optional: https://dashy.to/docs/pages-and-sections/#sub-items
However, getting this config warning with no title: /sections/7/items/5 must have required property 'title'
Problem code example:
      - title: Example Item
      - subItems:
          - title: Example Sub Item

However, config warning disappears when adding a title to subitems:
      - title: Example Item
      - title: example subitems title
        subItems:
          - title: Example Sub Item

I've actually been ignoring it for a few months now (issue occurs on 2.1.1 at the very least), but getting annoyed at looking at it now.
Additional info
2024-03-18T08:18:22.500590069Z yarn run v1.22.19

2024-03-18T08:18:22.576549794Z $ NODE_OPTIONS=--openssl-legacy-provider npm-run-all --parallel watch-config start

2024-03-18T08:18:23.106316566Z $ node server

2024-03-18T08:18:23.106621277Z $ node services/watch-for-changes

2024-03-18T08:18:23.173066370Z [OUTPUT] When '../public/conf.yml' is updated, a rebuild will be triggered.

2024-03-18T08:18:23.173105552Z

2024-03-18T08:18:23.173112661Z

2024-03-18T08:18:23.504759508Z

2024-03-18T08:18:23.504785509Z Checking config file against schema...

2024-03-18T08:18:23.656632249Z

2024-03-18T08:18:23.656667184Z ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━

2024-03-18T08:18:23.656675358Z   Warning: 1 issue found in config file

2024-03-18T08:18:23.656680291Z ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━

2024-03-18T08:18:23.656685318Z 1. /sections/7/items/5 must have required property 'title'

2024-03-18T08:18:23.656703939Z

2024-03-18T08:18:23.671485743Z

2024-03-18T08:18:23.671511992Z

2024-03-18T08:18:23.671518129Z  ██████╗  █████╗ ███████╗██╗  ██╗██╗   ██╗

2024-03-18T08:18:23.671523716Z  ██╔══██╗██╔══██╗██╔════╝██║  ██║╚██╗ ██╔╝

2024-03-18T08:18:23.671528643Z  ██║  ██║███████║███████╗███████║ ╚████╔╝

2024-03-18T08:18:23.671533493Z  ██║  ██║██╔══██║╚════██║██╔══██║  ╚██╔╝

2024-03-18T08:18:23.671538597Z  ██████╔╝██║  ██║███████║██║  ██║   ██║

2024-03-18T08:18:23.671543572Z  ╚═════╝ ╚═╝  ╚═╝╚══════╝╚═╝  ╚═╝   ╚═╝

2024-03-18T08:18:23.671548431Z

2024-03-18T08:18:23.671553173Z *******************************************************************************************

2024-03-18T08:18:23.671557949Z Welcome to Dashy! 🚀

2024-03-18T08:18:23.671562800Z Your new dashboard is now up and running with Docker

2024-03-18T08:18:23.671567637Z *******************************************************************************************

2024-03-18T08:18:23.671572336Z

2024-03-18T08:18:23.676861475Z 🔐 HTTPS server successfully started (port: 8443 of container)

2024-03-18T08:18:23.935130690Z

2024-03-18T08:18:23.935158694Z Using Dashy V-2.1.2. Update Check Complete

2024-03-18T08:18:23.935277008Z ✅ Dashy is Up-to-Date

2024-03-18T08:18:23.935302838Z

Please tick the boxes

[X] You have explained the issue clearly, and included all relevant info
[X] You are using a supported version of Dashy
[X] You've checked that this issue hasn't already been raised
[X] You've checked the docs and troubleshooting guide
[X] You agree to the code of conduct

yeah the second one definitely matches the schema. if you're modifying the yml in vscode you can add this line to the top of the file to get intelisense for the options as well as the wonderful red squiggles with the error message. the schema really should just be published so this step isnt necessary.
# yaml-language-server: $schema=https://raw.githubusercontent.com/Lissy93/dashy/master/src/utils/ConfigSchema.json

Sub-items do not need a title.
The warning you're seeing is actually due to a small error in your config, the sub-items need to be nested under a parent item. Here's an example: https://github.com/Lissy93/dashy/blob/HEAD/docs/pages-and-sections.md#sub-items


Update README.md

Solves issue #31 by adding custom Logo for Unity Library to README.md

with github light mode, its not visible,
https://github.com/xXxT0SHIIIxXx/UnityLibrary

thanks!


Cleanup table markdown so it renders correctly

The markdown in the table was wrong so it was rendering as raw text.

@mike-r-mclaughlin – there was actually an extraneous j in the table contents which was causing this issue – I have fixed it in #5675!


Add pre-commit as optional developer tool

This PR adds pre-commit and associated configuration. This is more or less a tool for installing git hooks that check flake8 and black before committing. When used, this helps prevent follow up commits for formatting changes with black or correcting complaints from flake8.
There is also a configuration for installing hooks for checking that the commit message conforms to conventional commits.
It is possible to use the pre-commit hooks (flake8 and black) without the commit-msg hooks (commitlint) and vice-versa. Contributors can also ignore pre-commit altogether -- this is purely opt-in and must be explicitly installed.
Pre-commit is a pretty widely used tool in the python community and is analogous to husky in the javascript community. I've had these configuration files hanging out in my local fork of the ACA-Py repo and have been happily using them for more than a year.

Codecov Report

Merging #1671 (3812a8e) into main (3774e85) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1671   +/-   ##
=======================================
  Coverage   95.50%   95.50%
=======================================
  Files         528      528
  Lines       32766    32766
=======================================
  Hits        31293    31293
  Misses       1473     1473


Discuss default role value

Discuss what value to give (by default) and how that will work with authorization flow

Roles are managed by auth0 now.


Add fullnameOverride to chart

Add a fullnameOverride value to override kube-keepalived-vip.fullname function. This function is copied from the latest _helpers.tpl generated by helm create

Coverage remained the same at 17.005% when pulling 52f13c9d1abb8d647903f9911ed5205ad4ddc235 on steven-sheehy:master into ee6f96a13c636187e9989ba8e3cd3e279b823b0c on aledbf:master.

@steven-sheehy thanks!


multi-chain receptor input & noncontinuous pdb truncating for memory efficient design

Hi all,
Thank you very much for your hard work; this is a beautiful thing. I have two questions that I'm trying to address simultaneously.

I am trying to design a small binder (8-20 resi) into a pocket formed by a heterodimer. Assuming I had access to a large-memory GPU, how would I specify the hotspots a1, a2, a3 on chain A and b1, b2, b3 on chain B (panel A)?

Much of this heterodimer is unneccesary. I'd like to cut away large chunks of chain A and chain B, and provide BindCraft with, effectively, a shortened receptor (panel B) such that my workstation GPU (16 GB 4080) can handle this job. Chain A is continuous and easy to work with; the receptor surface of chain B is noncontinuous and has 3 separate chunks. In an effort to circumnavigate the issue in point 1, I combined this receptor into a single PDB (panel C) and renumbered it continuously and with a uniform chain ID. However, when I do this and design a binder against the new hotspots (orange residues, C), it significantly distorts the receptor, I think in an attempt to try and fold the receptor surface as if it was a single continuous protein. Panels D and E highlight one example of this happening, where the design is in light blue and the "hack-n-slash" receptor is in orange/white. Panel F highlights a second example of the exact same thing in purple. How might I fix the receptor surface such that:
2.1) I'm providing BindCraft with only the essential receptor residues so that my GPU can process the job (a 16 GB 4080 can handle approximately a 60 resi system) without residue coordinate distortion?
2.2) If I can't completely fix the residue coordinates in chain B (cyan, noncontinuous, panel B) can I break up chain B into chain B (6 resi long), chain C (7 resi long), and chain D (9 resi long), then specify several receptor chains and their respective hotspots on those chains in the input json file?

Thank you preemptively!
Kind regards,
Jacob

Hey Jacob,
The hotspots can be specified as 'A1,A4,A5,B2,B4,B9,B12' etc.
So the complex doesn't look too big, I personally would not cut it, because little pieces like that can still move and the movement might be too significant if not stabilised by the rest of the backbone. Unforunately the chunks you indicate are a bit too small to stabilise I think. Perhaps in your case it makes more sense to use RFdiffusion?
Alternatively, you can run it on the colab with colab pro and run it without trimming.

Hi Martin,
Thanks! I could have sworn I tried that before reaching out and it didn't work - very likely user error since it's running now. Thank you!
I am in a fortunate position where I can experimentally test many many peptides (~1,000) - I would ideally like to test a myriad of the binder generation schemes that have come out. This is off topic w.r.t BindCraft, but after generating say 1,000 peptide backbones, when do you use ProteinMPNN and AlphaFold to verify the binders (similar to Sergey's colab notebook https://colab.research.google.com/github/sokrypton/ColabDesign/blob/v1.1.1/rf/examples/diffusion.ipynb) vs when do you use the dl_binder_design by Bennet (https://github.com/nrbennet/dl_binder_design)?

As far as I know Bennett uses the same strategy of AF2 filtering, just not MPNN, but cannot say as I never used it. The only other good alternative right now is to use RFdiffusion+MPNN+AF2

Thank you for your input!

Coming back to this issue because it's related to one I've been curious about. For many proteins, the binding site of interest is made up of non continuous regions of the chain (ex. AAs 1-100, 200-300, and 900-1000). In PyMol you can select all residues within a certain distance of a feature (ex. select br. ChainA within 5.0 of ChainB), to generate a non continuous PDB file (see example pymol screenshot below) composed of a surface region. This functions as an input to BindCraft, and outputted target structures have good alignments to their full length "ground truth" experimentally derived structures.
What are your thoughts regarding this strategy in general? It's very appealing in that the speedups can be significant. In contrast to the above user, I did not renumber the chains, the non continuous domains are larger, and did not observe major deviations from the "true" structure when modeling. I do have some concerns about how this might impact the validation rate down the line though (both experimentally and the in silico filtering).

It really depends. If you trim in a way that exposes protien cores, it's probably not gonna go down well and binders will try to cover it. But in principle there are many different ways one can generate the input structure and trimming like this is totally legit

Makes sense, thanks. Avoiding exposing the protein core was actually the original motivation (other than speed ups) for doing this. In that for some targets a continuous trim (ex. AAs 1-200) will get you the right surface, but expose a core. Whereas a non continuous trim using "within X" (ex. AAs 1-200, and also 300-350) will have both the surface and a partial section of the core behind it. Anecdotally this has helped keep my designed proteins at the right spot, as opposed to falling into a "pseudo pocket" created by the trimming.

We've also done it, works fine :)


Help......can't import the node after updata today.

Traceback (most recent call last):
File "H:\ComfyUI-qiuye\ComfyUI\nodes.py", line 2001, in load_custom_node
module_spec.loader.exec_module(module)
File "", line 940, in exec_module
File "", line 241, in call_with_frames_removed
File "H:\ComfyUI-qiuye\ComfyUI\custom_nodes\ComfyUI-CogVideoXWrapper_init.py", line 1, in
from .nodes import NODE_CLASS_MAPPINGS, NODE_DISPLAY_NAME_MAPPINGS
File "H:\ComfyUI-qiuye\ComfyUI\custom_nodes\ComfyUI-CogVideoXWrapper\nodes.py", line 18, in
from diffusers.schedulers import (
ImportError: cannot import name 'CogVideoXDDIMScheduler' from 'diffusers.schedulers' (H:\ComfyUI-qiuye\ComfyUI.ext\Lib\site-packages\diffusers\schedulers_init_.py)
Cannot import H:\ComfyUI-qiuye\ComfyUI\custom_nodes\ComfyUI-CogVideoXWrapper module for custom nodes: cannot import name 'CogVideoXDDIMScheduler' from 'diffusers.schedulers' (H:\ComfyUI-qiuye\ComfyUI.ext\Lib\site-packages\diffusers\schedulers_init_.py)

After what update? That error suggests your diffusers version is too old.


1.21.0 | 1.22.0 | 1.23.0 : Analyzing /Users/me/myproject/KafkaConsumer.kt led to an exception

Observed Behavior
I am currently updating a Spring Boot Application from 3.0.1 to 3.1.3
if I use plugin version "1.21.0" OR "1.22.0" following Error occures
Execution failed for task ':detekt'.
> Analyzing /Users/me/myproject/KafkaConsumer.kt led to an exception.
  Location: io.gitlab.arturbosch.detekt.rules.bugs.ImplicitDefaultLocale.checkStringFormatting(ImplicitDefaultLocale.kt:70)
  The original exception message was: 'org.jetbrains.kotlin.psi.KtExpression org.jetbrains.kotlin.resolve.calls.util.CallUtilKt.getCalleeExpressionIfAny(org.jetbrains.kotlin.psi.KtElement)'
  Running detekt '1.22.0' on Java '17.0.7+7' on OS 'Mac OS X'
  If the exception message does not help, please feel free to create an issue on our GitHub page.

if I use plugin id("io.gitlab.arturbosch.detekt") version "1.23.0"
detekt was compiled with Kotlin 1.8.21 but is currently running with 1.8.22.

Steps to Reproduce
# build.gradle.kts
plugins {
 id("io.gitlab.arturbosch.detekt") version "1.22.0"
}

detekt {
    ignoreFailures = true
    config.setFrom(files(System.getenv("DETEKT_CONFIG") ?: "config/detekt/detekt.yml"))
}

My ENV
detekt '1.21.0' on  Java '17.0.7+7' on OS 'Mac OS X'
detekt '1.22.0' on  Java '17.0.7+7' on OS 'Mac OS X'
detekt '1.23.0' on  Java '17.0.7+7' on OS 'Mac OS X'
Question
I found this solution which works with "1.23.0" but I saw that it will download kotlin 1.8.21 additionally?
Therefore it will slowdown our CI pipelines.
Is there an other solution for this?
project.afterEvaluate {
    configurations["detekt"].resolutionStrategy.eachDependency {
        if (requested.group == "org.jetbrains.kotlin") {
            useVersion("1.8.21")
        }
    }
}

It would be nice to have a parallel release with Spring Boot or all Kotlin Versions

There's not much we can do here, see https://github.com/detekt/detekt/issues/6198#issuecomment-1700332653
Also see a comment near the end of that thread from one of the Spring Dependency Management Gradle plugin maintainers saying that's the best workaround for now.


Rust setup

Created the cargo project and updated the .gitignore file. Can you check that everything looks good @jadynlaila?

This plan is cancelled.


Unit Test functionality

This is to provide unit test functionality to include

Run Project Tests
Run Focused Test
Display Test Result/Reports

May want to consider test as discussed:

https://docs.python-guide.org/writing/tests/

Maybe interaction via https://tox.wiki/en/latest/

May also want to integrate with https://coverage.readthedocs.io


OCM-3795: Adding http tokens default to terraform state

Verified with the build from the branch. Works as expected
/lgtm

/approve


Sm/strict mode

requires https://github.com/salesforcecli/plugin-source/pull/756
for xNUT purposes, uses https://github.com/salesforcecli/plugin-deploy-retrieve/pull/571.

What does this PR do?
resolve some errors that TS strict null checks complain about
breaking:

make directoryName a required prop on metadataType

other api changes
adds generics on CS.deploy() and metadataApiDeploy to pass to the generic methods on metadataTransfer so that the deploy.id is properly typed (clients won't have to figure out if it's undefined).
What issues does this PR fix or reference?
@W-12671663@

All these changes were reviewed and tested in later PRs (e.g. 905) so closing this.


Decide on RPC protocol library for Delegate servers

Same as Hydra uses, maybe?

So we decided to use Network.Websockets, same as Hydra node.


Clean up chai http promises

Coverage remained the same at 98.135% when pulling f60453691972c6bc385dbc131aac9247e0a593e3 on chai-http-fix into e1aff7c14c299e0e593f99309c25d542d88d8dbe on master.


vs. Tune Trainable API?

Hi guys.
How is this library different from Tune Trainable?
https://ray.readthedocs.io/en/latest/tune-usage.html
It seems like they offer the same ability to distribute computation, early stopping, checkpointing and even hyperparameter search, etc...
Just looking for some comments. Thanks.

many ways!
Lightning is a platform... this means we integrate with any other AI related project.

If you look through the issues we are adding support for Ray distributed in lightning for those who want to use ray (ie: tune, etc can add features to lightning without getting you locked into any particular approach.
we support other approaches for hyperparameter search like tune, hydra, optuna, etc...
we’re a research platform, not just a trainer. ie: we also allow TPU training, 16 bit precision, automatic research tricks like backpropagation through time, etc...
we are just a way to organize pytorch code, so there’s no new framework to learn or anything.

But overall, you can think of ray as a way to do hyperparameter search and another way of doing distributed (ie: gradient syncing, etc).  In lightning we support dp, ddp, ddp2 and soon ray. To use any of these you don’t  have to change your lightning code:
Trainer(distributed_backend="ray|ddp|dp”)


add read_visium mention to spatial tutorial

Thanks for adding spatial support to Scanpy.
Added an extra line to the data import bit of the tutorial that points readers to your read_visium() function. I didn't know how to actually import my own data when reading the tutorial, and I ended up having to go into the datasets source code to find out how you load it, so seems like it would be handy for future readers.

thank, you, looks good!


Can't change express plural handle after it has been created

I created an express object (one to many) and realized that I had spaces in my plural handle. I corrected it so that it had underscores instead. None of the magic methods would work. After completely starting over from scratch and doing it correctly the first time, everything worked as expected. This leads me to believe there is a bug if you'd like change the plural handle but can't. I'm using Concrete5 8.5.4.

Yeah, I could see this. If you create the entity with a particular plural handle, create the association, THEN change the plural handle you'll have problems. This could probably be fixed by just rescanning the association objects that exist under the hood any time an entity is updated and we detect that either the handle or the plural handle has changed.


Optimizing the chunk size using devtool

Issues: https://issues.redhat.com/browse/RHSTOR-6134
BZ: https://bugzilla.redhat.com/show_bug.cgi?id=2290675

/test odf-console-e2e-aws

@GowthamShanmugam if we are planning to backport this PR to 4.16.z can we remove hashing and other unrelated changes from this PR and add them to https://github.com/red-hat-storage/odf-console/pull/1525 instead ?? Let's keep this PR short with only what's needed (devTool part), wdyt ??
In case this is 4.17 onwards fix then we are good.

@GowthamShanmugam if we are planning to backport this PR to 4.16.z can we remove hashing and other unrelated changes from this PR and add them to #1525 instead ?? Let's keep this PR short with only what's needed (devTool part), wdyt ??
In case this is 4.17 onwards fix then we are good.

ack, that's a good suggestion

/approve
/lgtm

/cherry-pick release-4.17

/cherry-pick release-4.17-compatibility

/cherry-pick release-4.16

/cherry-pick release-4.16-compatibility

/test odf-console-e2e-aws


"Lower delegation amount and stay with current pool" changes target pool

Bug Description
The new pool is used instead of your current pool.
Steps to Reproduce

Delegate to pool A with x CCD
Try to delegate to pool B, where x CCD will bring the pool over one of the two caps.
The popup "Current delegation amount too large" is shown. Click on "Lower delegation amount and stay with current pool".
Change the amount to be <= the limit for the new pool.

The limit pool B is shown, which is quite useful

Click Continue
Look at the target pool in the transaction summary shown

Expected Result
Target: A, since we are staying in the current pool and lowering the delegated amount
Actual Result
Target: B
The transaction subsequently fails with "Stake is above maximum threshold", because it tries to move to B instead of staying with A.
Versions

Software Version: 3.0.0
OS: Android
Mobile device: Huawei

Verified with the Android MW version 3.0.11 (95)