Qprof step 10 (work in progress)

VER-90918
JIRA https://jira.verticacorp.com/jira/browse/VER-90918

Add the query events report to qprof.py
Add some tests for qprof.py, including some small test fixtures

TODO

Update the docstring for query events - it is missing pieces
Add a test that actually tests query events ;)

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Jason Slaunwhite seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

@jslaunwhite-microfocus - Please add Copyright statement at the beginning of each file. you can refer to any existing file.

@jslaunwhite-microfocus please use the latest version of black to format your code.
@vikash018 please look closely at the tests to see if it follows your logic.
I will now look at the main code.

@jslaunwhite-microfocus - Please add Copyright statement at the beginning of each file. you can refer to any existing file.

Fixed with 6be2d6b9e481e99cf776e779d299234c227c1382

@jslaunwhite-microfocus please use the latest version of black to format your code. @vikash018 please look closely at the tests to see if it follows your logic. I will now look at the main code.

Fixed with e76f71c56d7526719ad6ff1d38c0d9aa95afd572

@afard @vikash018 @mail4umar - I have addressed all of the comment. The checks are queued and waiting to run. Can you please take another look and let me know if there is more that I should do prior to merge?

@jslaunwhite-microfocus I've made the modifications (test + docstrings - now it looks good except something). For some reasons your test is failing because it did not connect to the server (no available connection).
BESIDES: I prefer one class test for all QUERYPROFILER:
@vikash018 can you please set up a call with @jslaunwhite-microfocus to see how you can together correct the test file. Be sure to have something consistent. It is preferable to change the overall structure to have 1 class for the QueryProfiler objects tests and to do ALL the tests under that class.

@jslaunwhite-microfocus I've made the modifications (test + docstrings - now it looks good except something). For some reasons your test is failing because it did not connect to the server (no available connection).

Yes, I see this failure, and it surprises me. I'll investigate again with @afard  and @vikash018 .

BESIDES: I prefer one class test for all QUERYPROFILER:

@vikash018 can you please set up a call with @jslaunwhite-microfocus to see how you can together correct the test file. Be sure to have something consistent. It is preferable to change the overall structure to have 1 class for the QueryProfiler objects tests and to do ALL the tests under that class.

Can you tell me about what you mean by "one class test"? I'm happy to do whatever the standard is. This PR adds a small test for part of the query profiler. I was planning to add more small tests as we go along. I was planning to add each test as a function, either in test_qprof_simple.py file or in another file in this directory. That's how I've seen other tests handled before, and I thought that was the structure of tests_new/

Can you tell me about what you mean by "one class test"? I'm happy to do whatever the standard is. This PR adds a small test for part of the query profiler. I was planning to add more small tests as we go along. I was planning to add each test as a function, either in test_qprof_simple.py file or in another file in this directory. That's how I've seen other tests handled before, and I thought that was the structure of tests_new/

Nevermind, I see the changes that @oualib pushed. The comment makes sense with that example. Sure, I can organize things that way

Can you tell me about what you mean by "one class test"? I'm happy to do whatever the standard is. This PR adds a small test for part of the query profiler. I was planning to add more small tests as we go along. I was planning to add each test as a function, either in test_qprof_simple.py file or in another file in this directory. That's how I've seen other tests handled before, and I thought that was the structure of tests_new/

Nevermind, I see the changes that @oualib pushed. The comment makes sense with that example. Sure, I can organize things that way

I am not the Unit Test master but @vikash018 can confirm.
Also @vikash018 can you please write a RST file with an example on how you expect test files to be organised?

@oualib -- test 3.11 was failing before, and it is passing now. I hope the other tests pass soon. What will be the next steps to move this forward?

@oualib -- test 3.11 was failing before, and it is passing now. I hope the other tests pass soon. What will be the next steps to move this forward?

@oualib @afard and @mail4umar and @vikash018  - all checks passed, I think this is ready to merge. Just need a review.

Thank you! I am very glad to have this merged.


[BUG] "I don't care" are using wrong sequence in "Start" state

When performing emote "I don't care", this emote are wrongly use the "Start" sequence from "Jubi slide".

Oh shoot, I noticed this myself earlier, but I thought I fixed this. Thanks! I will get this fixed soon.

Fixed in latest version.


update gh CLI to latest version

Description
Actually GitHub runner 'ubuntu latest' claims using the latest gh CLI version:
gh is already the newest version (2.0.0).

Please update it to version v2.1
Virtual environments affected

[ ] Ubuntu 16.04
[ ] Ubuntu 18.04
[X] Ubuntu 20.04
[ ] macOS 10.15
[ ] macOS 11
[ ] Windows Server 2016
[ ] Windows Server 2019
[ ] Windows Server 2022

Image version and build link
https://github.com/cli/cli/releases/tag/v2.1.0
Is it regression?
No response
Expected behavior
No response
Actual behavior
unknown flag: --head
Usage:  gh pr list [flags]
Flags:
-a, --assignee string   Filter by assignee
-A, --author string     Filter by author
-B, --base string       Filter by base branch
-q, --jq expression     Filter JSON output using a jq expression
--json fields       Output JSON with the specified fields
-l, --label strings     Filter by labels
-L, --limit int         Maximum number of items to fetch (default 30)
-S, --search query      Search pull requests with query
-s, --state string      Filter by state: {open|closed|merged|all} (default "open")
-t, --template string   Format JSON output using a Go template
-w, --web               Open the browser to list the pull requests
Repro steps
Running the following command fails to get open pull request of a head branch fails:
> gh pr list --state open --head branch_name

Hello @akramdhiabii. Thank you for your report. We install latest available GitHub CLI at the moment. Newest version should be available with the next week's image rollout. I'll post an update message.


[KCNH1 associated disorder/KCNH1]

Preferred gene-related syndrome label: KCNH1 associated disorder
For example: NAA10-related syndrome
Synonyms: none
Parent term (use OLS, or your favorite ontology browser): Unsure
Definition: Any neurodevelopmental disorder in which the cause of the disease is a mutation in the KCNH1 gene. Variants in KCNH1 cause significant neurodevelopmental disabilities that lie along a phenotypic spectrum ranging from non-syndromic to syndromic. The most common phenotypes associated with variants in KCNH1 include intellectual disability, seizures, hypotonia, absence or hypoplasia of nails, and gingival enlargement. Hypoplastic terminal phalanges of fingers and toes, proximal placement and long thumb, and long toes present less frequently.
Please write the definition in the format: Any [parent class] in which the cause of the disease is a mutation in the [gene name] gene. For example: Any congenital myopathy in which the cause of the disease is a mutation in the TPM3 gene.
**Definition source (Please give PubMed ID, if applicable, in format PMID:#######): PMIDs: 25915598, 25420144, 33811134
Children terms (if applicable) Should any existing terms be re-classified as children underneath this new proposed term?: Yes, Zimmerman-Laband syndrome 1 (MONDO:0024526) and Temple-Baraitser syndrome (MONDO:0012735) should be child terms of this new term. There is no distinct phenotypic difference, mechanism of disease (GoF), or inheritance pattern (AD) between these two disease entities. Additionally, the term "ID with or without epilepsy without the distinctive feature of ZLS/TBS" has also been associated with variants in this gene in the literature (PMID: 33811134) however, I don't think that term is available in Mondo. There are recurrent variants across all three disease entities leading us to believe this is likely a spectrum of disease.
Your nano-attribution (ORCID) or URL for a working group: https://clinicalgenome.org/affiliation/40006/
If you don't have an ORCID, you can sign up for one here

Hi @tibingaman we already have this term in Mondo:
https://www.ebi.ac.uk/ols/ontologies/mondo/terms?iri=http%3A%2F%2Fpurl.obolibrary.org%2Fobo%2FMONDO_0100124
Would you like any changes to the existing term?


Can't use Redis sort by external keys feature

I'm using Redix 0.9.2 version, Elixir 1.8.
I can't use Redis sort by external keys feature, as described in the link: https://redis.io/commands/sort. The command SORT mylist BY weight_* works when performed directly on redis-cli.
But Redix gives me empty results:
iex(40)> Redix.command(:redix, ["SORT", "mylist BY weight_*"])
{:ok, []}
iex(41)> Redix.command(:redix, ["SORT", "mylist", "BY weight_*"])
{:error, %Redix.Error{message: "ERR syntax error"}}

Any ideas about this issue?

Redix.command(Verk.Redis, ["SORT", "mylist", "BY", "weight_*"]) should do exactly what you want.
The arguments must be separated as items inside the list

Exactly as @edgurgel said :).


How to decompress  SeeingThroughFogCompressed

I have downloaded the files 01 to 18, how should I unpack them？
My file directory is as follows：
SeeingThroughFogCompressed.z01  SeeingThroughFogCompressed.z08  SeeingThroughFogCompressed.z15
SeeingThroughFogCompressed.z02  SeeingThroughFogCompressed.z09  SeeingThroughFogCompressed.z16
SeeingThroughFogCompressed.z03  SeeingThroughFogCompressed.z10  SeeingThroughFogCompressed.z17
SeeingThroughFogCompressed.z04  SeeingThroughFogCompressed.z11  SeeingThroughFogCompressed.z18
SeeingThroughFogCompressed.z05  SeeingThroughFogCompressed.z12  SeeingThroughFogCompressed.zip
SeeingThroughFogCompressed.z06  SeeingThroughFogCompressed.z13
SeeingThroughFogCompressed.z07  SeeingThroughFogCompressed.z14

Hi,
sorry to hear that you have problems downloading. I was able to reproduce your error and have forwarded the error message. Hope to come back to you as soon as this issue is resolved.
Best,
Mario

Hi,I also have problems when downloading these files. When I click on these files, they download failed after only a few minutes.

Hi @sysuzgg,
can you please elaborate more on your error. Did you get any error message? I was not able to reproduce the error.
Are you downloading from within a corporate/university environment? Can you try to download one single file after another? Can you try to logout of your VPN before starting your download?

Hi @MarioBijelic ,
I download within an university environment. And I did download one by one. And I logout my VPN before starting my download.

Hi @MarioBijelic ,
I download within an university environment. And I did download one by  one. And I logout my VPN before starting my download.    Can you upload your dataset on Baidu Yunpan or Google Drive or e-mail me with @.*** My mailbox can receive 1T of data. and I only need foggy dataset.
------------------ Original ------------------
From: @.>;
Send time: Tuesday, Jul 26, 2022 5:04 PM
@.>;
@.>; @.>;
Subject:  Re: [princeton-computational-imaging/SeeingThroughFog] How to decompress  SeeingThroughFogCompressed (Issue #55)
Hi @sysuzgg,
can you please elaborate more on your error. Did you get any error message? I was not able to reproduce the error.
Are you downloading from within a corporate/university environment? Can you try to download one single file after another? Can you try to logout of your VPN before starting your download?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID: @.***>

Hi @MarioBijelic, I got the same error as @sysuzgg reported. If possible, could you send me the files to my email (kimchuorok@gmail.com)?

Hi @sysuzgg @soyeongkim ,
the issue can be circumvented using firefox on all platforms and right clicking the link. Then you can select "Save as" to download the content without opening it in another window. Hope this helps for now.
Best,
Mario

My solution
zip -s- SeeingThroughFogCompressed.zip -O zip_file_full.zip
unzip zip_file_full.zip


update ProxyAdmin arbitrum

ProxyAdmin ownership was recently transfered
new admin multisig:
https://gnosis-safe.io/app/#/safes/0xC234E41AE2cb00311956Aa7109fC801ae8c80941/balances
actual tx:
https://etherscan.io/tx/0x82bbf286308b29154881f489b6832f17a2677e1598606ab7203dab5a3140b816

The change did occur, but the PR is incorrect. The L2BEAT config does not include information about who the owner of those proxies is.

Closing this as no update should happen in the configuration


Allow components which are not "leaf" children in the class hierarchy

In working on #1989, @freddyaboulton suggested that we make TargetImputer a subclass of SimpleImputer. Unfortunately, when looking for viable components in _get_subclasses, _get_subclasses will only collect classes that are at the very bottom of the hierarchy. For example:
ComponentBase --> Transformer --> SimpleImputer # will only grab SimpleImputer

The issue is, if we subclass SimpleImputer, we will have access to TargetImputer, but SimpleImputer will no longer be found by EvalML as a useable component:
ComponentBase --> Transformer --> SimpleImputer --> TargetImputer
# will only grab TargetImputer, SimpleImputer is no longer a leaf

I believe the original intent is to not grab classes that are not useful (ex: Transformer), but this is a problem if we want to build upon useful components to create new ones.
Original comment here: https://github.com/alteryx/evalml/pull/1989#discussion_r599894996

Options:
1.) Have the TargetImputer use the SimpleImputer.
2.) Don't define TargetImputer component, but instead apply the SimpleImputer to the target.
3.) Delete _get_subclasses() in favor of static list of components. (preferred)
4.) Make _get_subclasses() smarter.
Next step: schedule a discussion to decide how to go about doing this.

My opinion is that we shouldn't change anything unless we want to make inheritance of non base classes a more common pattern in our codebase. We currently don't do that so building a system to allow for that seems premature to me.
This issue isn't blocking the target imputer or any short-term work we have ahead of us and the current system for identifying subclasses "works". If we really want 3 then that's another story hehe and I'd be down to hear arguments for it but I don't think there's a need to do it.
And if we wanted to leverage the SimpleImputer in the TargetImputer in the future we can use composition over inheritance, which I think is what option 1 is referring to.

Agreed with @freddyaboulton here, also worth noting that we defined _get_subclasses() in the first place because keeping track of a static list of components was a bit tedious / frustrating as we were adding more and more components. If we go for 3, it might make more sense to keep _get_subclasses() but also keep a list of "exceptions" such as the SimpleImputer / TargetImputer case, so that they're included, but other components such as the Transformer are still excluded.

@angela97lin Do you think we can close this? I think we agree that we don't need to make changes to _get_subclasses to enable development of the TargetImputer/other components.

@freddyaboulton Sure, we haven't really made inheritance of non base classes a more common pattern in our codebase. Perhaps we can reopen and revisit when/if we actually have a use case again :)


Merge _apply_mt and _apply_st for maintainability

This PR merges _apply_mt and _apply_st for better maintainability.
Even when parallelism==1, this PR will spawn another process.
This doesn't sound computationally efficient, but should be fine because parallelism==1 means that the task itself is small.
This is a rework of #347.

I still have to figure out the reason for

Coverage decreased (-13.6%) to 68.964%

Now I found it.

Code executed by worker pools or child processes is not tracked.

https://stackoverflow.com/questions/28297497/python-code-coverage-and-multiprocessing


fix: multigoal linter should not flag tactics that do nothing

When a tactic does not change the list of goals, the multigoal linter was giving incorrect error messages such as
There are 2 unclosed goals before 'change ...' and
at least one remaining goal afterwards.
Please focus on the current goal, for instance
using `·` (typed as "\.").

This PR adjusts the condition to allow all tactics that operate on one goal and result in zero or more goals. It also makes the error message more precise, for example
warning: The following tactic starts with 2 goals and
ends with 1 goal, 1 of which is not operated on.
  exact .intro
Please focus on the current goal, for instance
using `·` (typed as "\.").

This looks great to me, thanks!
I wonder whether some of the exceptions can now be removed: maybe adaptation_note, sleep_heartbeats, subst_vars?  I have not tested these, though!

Kyle, while looking at the test, I realized that it still had the "old" workaround of setting the nested linter options and for this reason, the test that you added was not actually linted.  I removed the workaround and now everything should be actually linted more directly!

bors merge


PyCharm - Python3.9 - SpeechRecognition Import Statement

Hello
I am a newbie and am using:

Python 3.9
PyCharm
SpeechRecognition

As I try to write my code, the import statement remains unresolved (import speech_recognition as sr).
I tried installing speech_recognition by using the command (pip install SpeechRecognition). Even after installation, I am still getting the same error.
I checked the folder "site-packages" and it does show a folder "speech_recognition" with numerous files within it.
Any ideas?
Thanks
Deepak

If I run "python -m speech_recognition", it seems to work as it gives the error
"Traceback (most recent call last):
File "D:\TECHEXP\software\Conda\lib\site-packages\speech_recognition_init_.py", line 107, in get_pyaudio
import pyaudio
ModuleNotFoundError: No module named 'pyaudio'"

you have to install pyaudio i guess you have install speech_recognition btw you can find https://pypi.org/project/PyAudio/ here!!


Problem while deploying into kubernetes in EKS using helm , kubernetes version >= 1.16.0

Expected behavior
helm repo add streamnative https://charts.streamnative.io
helm repo update
helm install pulsar-storage-provisioner streamnative/local-storage-provisioner
Should be successful
Tell us what should happen
Actual behavior
bash-3.2$ helm install local-storage-provisioner streamnative/local-storage-provisioner --namespace mynamespace
Error: unable to build kubernetes objects from release manifest: unable to recognize "": no matches for kind "DaemonSet" in version "extensions/v1beta1"
Tell us what happens instead
Steps to reproduce
You can run above command in Kubernetes version >= 1.16.0, we will get this issue
How can we reproduce the issue
System configuration
Pulsar version: x.y
Doesn't matter which pulsar version it is.

Work around for this issue is to download from github:
bash-3.2$ git clone git@github.com:streamnative/charts.git
Cloning into 'charts'...
bash-3.2$ ls
charts
bash-3.2$ ls charts
LICENSE		charts		docs		hack		license_test.go
README.md	ct.yaml		examples	images		scripts
bash-3.2$ helm install pulsar-storage-provisioner $PWD/charts/charts/local-storage-provisioner
NAME: pulsar-storage-provisioner
LAST DEPLOYED: Wed Jul 28 19:31:24 2021
NAMESPACE: default
STATUS: deployed
REVISION: 1
TEST SUITE: None

I try to use the helm pull streamnative/local-storage-provisioner --untar to download this charts, I found that this charts uses extensions/v1beta1,  we need to update this charts in https://charts.streamnative.io.

The issue had no activity for 30 days, mark with Stale label.


APM-313824 add exception throttling

This is incomplete - the throttling logic is there and I added caller names to metadata-engine log calls and any error() or exception()  calls. The problem is that LoggingContest's log function is called over 100 times in the project seemingly without obvious distinction between kinds of calls. Me looking through all of them to decide which to throttle and which not would be counterproductive as well as possibly full of mistakes. My question is if someone could maybe take over this PR/branch to finish it or is it maybe not worth the time at all?

Changed approach from caller to message key, cause when using *args argument, caller argument was added to a message.
Moved throttling message dict to LoggingContext class. Message occurrences are now counted per LoggingContext instance.  LoggingContext is created for every function run, so occurrences are in a single function run context.
Changed logging to throttled for exceptions and errors, which may have a lot of occurrences.

after your changes script generate_metadata.py starts failing on:
Failed to map units: {'By.s', 'GiBy.s', 'GBy.s'}


feat(bootstrap): add support for metrics with cluster_id labels

Adds tag extraction logic for *_cluster_id labels to the envoy bootstrap.
This PR will enable labeling Istio metrics with source and destination clusters. This, in turn, will allow breaking down cross-cluster traffic in dashboards and alerts.
Related PR: https://github.com/istio/proxy/pull/2805
[X] Policies and Telemetry

@douglas-reid: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
cc468f1ea81cb26d072544c7401b11b49e588255
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@douglas-reid: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
cc468f1ea81cb26d072544c7401b11b49e588255
link
/test unit-tests_istio

integ-distroless-k8s-tests_istio
cc468f1ea81cb26d072544c7401b11b49e588255
link
/test integ-distroless-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@douglas-reid: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
cc468f1ea81cb26d072544c7401b11b49e588255
link
/test unit-tests_istio

integ-distroless-k8s-tests_istio
cc468f1ea81cb26d072544c7401b11b49e588255
link
/test integ-distroless-k8s-tests_istio

integ-galley-k8s-tests_istio
cc468f1ea81cb26d072544c7401b11b49e588255
link
/test integ-galley-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@douglas-reid: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
cc468f1ea81cb26d072544c7401b11b49e588255
link
/test unit-tests_istio

integ-distroless-k8s-tests_istio
cc468f1ea81cb26d072544c7401b11b49e588255
link
/test integ-distroless-k8s-tests_istio

integ-galley-k8s-tests_istio
cc468f1ea81cb26d072544c7401b11b49e588255
link
/test integ-galley-k8s-tests_istio

integ-local-tests_istio
cc468f1ea81cb26d072544c7401b11b49e588255
link
/test integ-local-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@douglas-reid: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
cc468f1ea81cb26d072544c7401b11b49e588255
link
/test unit-tests_istio

integ-distroless-k8s-tests_istio
cc468f1ea81cb26d072544c7401b11b49e588255
link
/test integ-distroless-k8s-tests_istio

integ-galley-k8s-tests_istio
cc468f1ea81cb26d072544c7401b11b49e588255
link
/test integ-galley-k8s-tests_istio

integ-local-tests_istio
cc468f1ea81cb26d072544c7401b11b49e588255
link
/test integ-local-tests_istio

integ-conformance-k8s-tests_istio
cc468f1ea81cb26d072544c7401b11b49e588255
link
/test integ-conformance-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@douglas-reid: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
cc468f1ea81cb26d072544c7401b11b49e588255
link
/test unit-tests_istio

integ-distroless-k8s-tests_istio
cc468f1ea81cb26d072544c7401b11b49e588255
link
/test integ-distroless-k8s-tests_istio

integ-galley-k8s-tests_istio
cc468f1ea81cb26d072544c7401b11b49e588255
link
/test integ-galley-k8s-tests_istio

integ-local-tests_istio
cc468f1ea81cb26d072544c7401b11b49e588255
link
/test integ-local-tests_istio

integ-conformance-k8s-tests_istio
cc468f1ea81cb26d072544c7401b11b49e588255
link
/test integ-conformance-k8s-tests_istio

integ-multicluster-k8s-tests_istio
cc468f1ea81cb26d072544c7401b11b49e588255
link
/test integ-multicluster-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@douglas-reid: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-distroless-k8s-tests_istio
cc468f1ea81cb26d072544c7401b11b49e588255
link
/test integ-distroless-k8s-tests_istio

integ-galley-k8s-tests_istio
cc468f1ea81cb26d072544c7401b11b49e588255
link
/test integ-galley-k8s-tests_istio

integ-local-tests_istio
cc468f1ea81cb26d072544c7401b11b49e588255
link
/test integ-local-tests_istio

integ-multicluster-k8s-tests_istio
cc468f1ea81cb26d072544c7401b11b49e588255
link
/test integ-multicluster-k8s-tests_istio

unit-tests_istio
5ce08d63c151825b1436d986d9beeecbf4bdcfdf
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test unit-tests_istio

@douglas-reid: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
5ce08d63c151825b1436d986d9beeecbf4bdcfdf
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


Remove Bitfield

In preparation for EIP-7495, Bitfield has been moved to the ethereum_ssz crate.
This PR removes it and simply re-exports it from the ethereum_ssz crate.
Relevant PR: https://github.com/sigp/ethereum_ssz/pull/25

Now that sigp/ethereum_ssz#25 is merged, we just need a release, then I can update this PR to refer to it.


Driver performance degradation on Rails 4.2

Our test suite runs in 19 minutes instead of 3 since we've upgraded to Rails 4.2.1 from 4.1.9
The javascript driver performance is the main culprit here. For instance, on 4.1.9 the first css selector find returns in 0.7 seconds, but on 4.2.1 it returns in 11+ seconds. Sometimes the RJS request takes longer than 5 seconds to evaluate on the capybara-webkit client (Rails actually renders and returns it in under 10ms).
We were able to reliably recreate this performance degradation across multiple OS X machines.
We're using Ruby 2.2.1

Is this problem reproducible using Selenium or another JavaScript driver?
Can you attach a :webkit_debug log of a slow scenario?

Poltergeist behaves pretty much the same. It's originally a little slower on 4.1 and an order of magnitude slower on 4.2.
Our benchmark cucumber story runs in 1 minute seconds on 4.1 and in 4 minutes 27 seconds on 4.2
Here's the debug log for both runs: https://gist.github.com/rwz/baedf8d802ad7e14c82d

@rwz I just released 1.5.2. The 1.5 series includes some cache changes which may improve performance. Can you give the latest release a try?

I'm going to close this, as I believe the performance issues will be resolved by caching improvements. Please comment again if you're still seeing a regression between versions.


ConsulPropertySourceLocatorTests.propertyLoadedAndUpdated fails locally

When running the build locally on OSX ConsulPropertySourceLocatorTests.propertyLoadedAndUpdated fails.  Here is what I do

Run docker-compose up
Run ./mvnw clean package

My guess is it's an old consul version. https://hub.docker.com/r/progrium/consul/~/dockerfile/ Running locally (brew install consul) and it works ok.

I'm reopening this because the README instructs the user to use docker-compose.  We either need to update the docker-compose file or change the instructions in the README

I fixed the docker compse file so that docker-compose works again, why reopen?

@spencergibb sorry, it wasnt clear to me that you fixed it by your comment.

My comment was just why it was broken, then my commit fixed it.

I didnt see the commit ;)


Make the HDMI2USB work when using a or1k soft-cpu rather than the lm32 version

MiSoC current supports two soft CPUs (https://m-labs.hk/gateware.html);

CPU options:

LatticeMico32, modified to include an optional MMU (experimental).
mor1kx, a better OpenRISC implementation.

The reasons for us currently choose the lm32 soft-cpu over the or1k soft-cpu where;

lm32 doesn't require patching gcc
lm32 is slightly smaller in resource requirements than the or1k
lm32 is the default option in MiSoC :)

However, the or1k seems like it has more people developing for it compared to the lm32. There seem to be more advanced Linux ports for example. Having or1k support would enable us to try and capture some of that effort.

FYI - @shenki

WIP stuff here -> https://github.com/mithro/HDMI2USB-misoc-firmware/tree/or1k
binutils and gcc for or1k have been added (and are the same version as lm32 versions) to conda https://github.com/timvideos/conda-hdmi2usb-packages
Added the base target to build for or1k - see example at https://travis-ci.org/mithro/HDMI2USB-misoc-firmware/builds/120395735
gateware and firmware compile for the base target but have not been tested at all.

That seems fine, on my side I'm going to continue working on #229 next week. With these two points solved we will have a good basis for GSoC and to continue work on the firmware.

My WIP branch is slowly getting there. Hopefully with #257 we will be able to figure out why the firmware is locking up.

This is working now with the "Exception Stack Size Fix":

LiteX - https://github.com/enjoy-digital/litex/pull/31 - https://github.com/enjoy-digital/litex/commit/b1b6a741702a7ca1bf5b021f7f8504784a26aa19
misoc - https://github.com/m-labs/misoc/pull/56 - https://github.com/m-labs/misoc/pull/56/commits/98dd745548319242399e8ff1e7137dbb73e3cb21

Yay!

Fixed!


Delete Pod specific VF resource cache from Podwatch controller, when a Pod gets deleted.

When a Pod gets deleted and recreated, secondary network configuration fails due to misconfigured VF resource cache. Pod specific VF resource must be cleared, when a Pod gets deleted everything.
NOTE: Upon Pod creation, Podwatch controller will build a VF resource cache, if the Pod annotates to configure SRIOV based secondary network interfaces.
Signed-off-by: Arunkumar Velayutham<EMAIL_ADDRESS>

@jianjuns looks like a test commit got accidently push (while I was addressing the git issue last week). fix it now.

/test-e2e

/test-networkpolicy

/test-conformance


bower                        ENOTFOUND Package keystonejs not found

bower install keystonejs --save

bower                        ENOTFOUND Package keystonejs not found

😢

Should be registered now.


how to put icon on the left side without using leftIcon in AppBar

I already assigned Logo for the leftIcon property and I wanted to put the RrDrawer IconKey="menu" on the left side of the leftIcon. Is that possible to do?
return
           <AppBar
                title={this.props.siteTitle}
                leftIcon={<LogoUrl />}
            >
                <RrDrawer iconKey="menu"/>

            </AppBar> ;

You could put a  containing both  and  in leftIcon no?
Another option could be putting the logo in the title (it's not in the documentation but title can also take an Element) and use leftIcon for RrDrawer.

thanks @alexjf! I just used the div and played it in style.
<div className={style.app}>
                <Links />
                <AppBar
                    title={this.props.siteTitle}
                    leftIcon={<LogoUrl />}
                >
                    <RrUserCard userName={this.props.friendlyUserName} userRole={this.props.userRole} />
                </AppBar>
            </div>

style.scss
.app{
    float: left;
    left: 20px;
    top: 18px;
    display: block;
    z-index: 11;
    position: absolute;
}


Epic 7.71 Syllabus Generator

Pull Request - Epic 7.71 Syllabus Generator
Summary
This pull request introduces major enhancements to the syllabus generator feature in the Kai backend project. The updated functionality enables educators to create comprehensive syllabi tailored to specific classes by providing details such as grade level, subject, syllabus type, and instructions. This AI-driven tool now supports downloadable PDF and Word formats and integrates a meme generator to add relevant visuals, making the process more engaging and enjoyable for educators and students.
Changes

Sorting Parameter Enhancement: Added sorting by grade level, subject, and context-keyword section to ensure the generated syllabi are highly relevant and organized.
PDF/Word Downloadable Feature: Enabled the option to download syllabi in PDF and Word formats for easier distribution.
Meme Scraper Integration: Integrated a meme generator using the Reddit API to incorporate relevant memes, enhancing the visual appeal of the syllabi.
Prompting Structure & Context: Developed six distinct prompts for various syllabus components, improving the coherence and accuracy of the generated outputs.
OOP Design: Refactored the code by introducing a SyllabusGenerator class to encapsulate all functions, resulting in cleaner and more reusable code.
Testing Enhancements: Added a search class for external answer verification and improved schema consistency by manually extracting JSON objects when necessary.
Additional Parameters: Introduced Syllabus_type and keywords parameters, later replaced with an instructions field for greater flexibility.

Testing

Unit Tests: Conducted extensive unit tests to ensure that returned strings from the LLM are in the intended format, focusing on flexibility and quality.
Integration Testing: Verified the overall functionality of the syllabus generation process, ensuring it meets the specified requirements.
Meme Generator Testing: Tested the meme generator integration using the Reddit API to ensure relevant and appropriate images are retrieved.

Results
The enhancements introduced in this pull request significantly improve the dynamic, personalized, and aligned nature of the syllabus generation process. The final output is a detailed syllabus that covers all necessary components, tailored to the specific needs of educators based on grade, subject, syllabus type, and instructions.
Notes

Model Hallucination Risk: The LLM model has a probability of generating responses that may not conform to the expected format. The structured outputs feature in the OpenAI ChatGPT model can be used to mitigate this risk.
Retrieval-Augmented Generation (RAG): Future improvements could include integrating a RAG approach, which would involve searching a dedicated database of syllabi to enhance the relevance and accuracy of the generated content.

How to Test

Environment Variables:

Create a programmable search engine and a Reddit account.
Set the following variables in the .env file:SEARCH_ENGINE_ID
API_KEY
NAME
PASSWORD
CLIENT_ID
CLIENT_SECRET
USER_AGENT

Install Dependencies:pip install -r requirements.txt

Navigate to the Syllabus Generator:cd app/features/syllabus_generator

Run the Tests:pytest tests/

Run the Application Locally:uvicorn app.main:app --reload

Docker Setup:docker build -t kai_ai .
docker run -d -p 8000:8000 kai_ai

Screenshots

Closed due inactivity


Scala 3: Dollar identifier is incorrectly tokenized as MacroSplicedIndent

Steps to reproduce:
val dotty = {
  implicit val D = dialects.Dotty
  "map($ => $.a)".tokenize.get.map { t =>
    t.productPrefix -> t.syntax
  }
}

val scala2 = {
  implicit val D = dialects.Scala213
  "map($ => $.a)".tokenize.get.map { t =>
    t.productPrefix -> t.syntax
  }
}

In the Dotty example, $ is tokenized as MacroSplicedIndent while it's Ident in the Scala 2 example. I expected the tokenizer to emit Ident in both examples. cc/ @kpbochenek

Thanks for finding this! I wonder if we could just check if the next token is { or ident, but not sure how to properly do it inside the tokenizer.


module.exports may be a promise.

In features list has point - module.exports may be a promise.
Sorry if I my question will be odd but what this mean and how this works.
I try
module.exports = async function () {
    const aaa = await bbb();
    return {
       data() {
            return {};
       }
    }
}

but this not works. Can you comment on how I can use this feature.

fixed in v1.3.6 (issue #54)


added workflow deploy npmjs registry

Signed-off-by: Antonio Mendoza Pérez<EMAIL_ADDRESS>Many thanks for submitting your Pull Request :heart:!
What this PR does / why we need it:
close #87
Special notes for reviewers:
I have changed the package version because there is already a package published with 0.6 version, my mistake testing the deployment workflow from my repo
The secret with name NODE_AUTH_TOKEN is already setup in this repository.
Additional information (if needed):

I think version patching should be done via CI/CD I think (based on the tag + latest published version for instance). Maybe semantic release could also be of use ?

that would be great @JBBianchi
for now I am changing the package json to version 1.0.0 and create a release branch and release from that branch.
I am adding a property "schemaVersion" to the package.json to keep working the "tools:download-schemas" functionality

Don't you think we should follow the specification version. We could have to branches/tags/ version:
Main / 0.7 -> npm 0.7.x
0.6 / 0.6 -> npm 0.6.x
When the specs goes to v1.0.0:
Main / 1.0 -> npm 1.0.x
0.7 / 0.7 -> npm 0.7.x
0.6 / 0.6 -> npm 0.6.x
Idk if it makes sense

IMO, it's the easier for the dev that have to choose a version. Let's say his company have a workflow running on v1.2 but the spec is at v2.1, if the SDK packages follow the same versioning, it's easy to pick the right one. If not, then it's a bit difficult to know which version of the SDK correspond to which version of the spec.

That is a good point, but if look into the go and java sdks (not the .net sdk)  they have different versions of the spec.
Dev only have to look into the documentation to figure out what version to use.

Software (SDK / Synapse) released do not have to follow the spec releases numbers at all.
I think also following java / go sdk and coming up with your own release numbers based on best practices for your sdk type would be great.

@JBBianchi we have these mapping tables - https://github.com/serverlessworkflow/sdk-java#status
This is nice cause in case there are any bugs we find out after the release we can just release like a 1.0.1 from the 1.0.x release branch with the backported fix
Regarding the easy to pick up - the DSL mandates the "schemaVersion" property and in SDKs validators we should check if that version matches the sdk release that is being used. wdyt?

Regarding the easy to pick up - the DSL mandates the "specVersion" property and in SDKs validators we should check if that version matches the sdk release that is being used. wdyt?

👍
@tsurdilo  this is from 0.7 spec version, isn't it?

@antmendoza ahhh yes ..i forgot about that :) sorry

@antmendoza i think for 0.6 you can assume it is 0.6 spec version, don't think anyone is writing dsl using any prior releases anyways. Yeah starting with 0.7 we will be able to validate based on specVersion param

It makes sense for the sdk to have it's own version in the way that if the surface api changes, the minor version (or even major if breaking) is affected following the semver guidelines. I just felt it was easier to identify which sdk version support which spec version but it's not mandatory, the compatibility table should work as well.


feat(dependencies): upgrade @angular/material to beta.3.

Description
Upgrade covalent to use and leverage the latest material.
What's included?

fix(theming): update theming to point to the correct path
fix(layout): properly style md-sidenav without the cdk-focus-trap element.
fix(chips): replace [dividerColor] with [color] in md-input-container

Test Steps

[ ] ng serve
[ ] Test the app

General Tests for Every PR

[ ] ng serve --aot still works.
[ ] npm run lint passes.
[ ] npm test passes and code coverage is not lower.
[ ] npm run build still works.

The eagle has landed so to speak :) And evidently we are back to importing components on an "as needed" basis.

It would be great if there are independent imports of the material modules rather than MaterialModule as a whole given that the MaterialModule is deprecated

@asaph26 we probably will deprecate CovalentCoreModule too, so we push people to import only what they need.


refactor: orb tools 11 migration

Orb tools 11 migration with major changes incoming.
This will not be released immediately more PRs will follow this one.
Removed:
echo y | serverless --org "$SERVERLESS_ORB_ORG_NAME" --app "$SERVERLESS_ORB_APP_NAME"

Why?
This line when testing this refactor resulted in this error. In searching for this CLI command in the serverless framework docs, I was not able to find any reference to this --org --app style command, and I believe it may potentially be deprecated at this time. Running serverless -h will show no such options are documented.
Error:
Attempted to run an interactive setup in non TTY environment.
If that's intended, run with the SLS_INTERACTIVE_SETUP_ENABLE=1 environment variable

The test here will show that these are not needed for deployment.

It appears their original purpose may have aided in creating a new project if one had not existed, and this should be rare and likely not encouraged.
In a future PR I will remove these parameters before we release a major update.

Your development orb has been published. It will expire in 30 days.
You can preview what this will look like on the CircleCI Orb Registry at the following link:
https://circleci.com/developer/orbs/orb/circleci/serverless-framework?version=dev:f4530874c6cd9698a04b893ae1bee9a4e5e56fd0

Your development orb has been published. It will expire in 30 days.
You can preview what this will look like on the CircleCI Orb Registry at the following link:
https://circleci.com/developer/orbs/orb/circleci/serverless-framework?version=dev:f4530874c6cd9698a04b893ae1bee9a4e5e56fd0

Your development orb has been published. It will expire in 30 days.
You can preview what this will look like on the CircleCI Orb Registry at the following link:
https://circleci.com/developer/orbs/orb/circleci/serverless-framework?version=dev:b0f121071e4c463940242efc10c550b2b81982a7

Your development orb has been published. It will expire in 30 days.
You can preview what this will look like on the CircleCI Orb Registry at the following link:
https://circleci.com/developer/orbs/orb/circleci/serverless-framework?version=dev:6b75b19082d51ae23c6ed4894cf9fa52e810e437

Your development orb has been published. It will expire in 30 days.
You can preview what this will look like on the CircleCI Orb Registry at the following link:
https://circleci.com/developer/orbs/orb/circleci/serverless-framework?version=dev:198694449b36455f7a1893fe3c265118ae767c8d

Your development orb has been published. It will expire in 30 days.
You can preview what this will look like on the CircleCI Orb Registry at the following link:
https://circleci.com/developer/orbs/orb/circleci/serverless-framework?version=dev:96c123cc0151d229f66425e9fe149c9078bc5f59

Your development orb has been published. It will expire in 30 days.
You can preview what this will look like on the CircleCI Orb Registry at the following link:
https://circleci.com/developer/orbs/orb/circleci/serverless-framework?version=dev:ebb4a777860b1edcff9672f6a5b6583a666cc430


Add maven dependency to an image

It would be nice to include a maven dependency to an image in the build images mojo.
F.ex org.example:awesome-app:1.0:war
Should leverage aether to resolve artifacts.

Added pull request #100 to implement this.


(googlechrome) error 1722 at install

Checklist

[X] I have verified that this is the correct repository, and the package is maintained by the chocolatey-community user.
[X] I have verified that this is happening in the latest available version of the package.

Chocolatey Version
2.4.0
Chocolatey License
None
Package Version
131.0.6778.86
Current Behaviour
Chrome fails to install with generic error 1722. Freshly downloaded googlechromestandaloneenterprisex64.msi worked as expected.
Expected Behaviour
Chrome installs successfully
Steps To Reproduce

Using Ansible, install Google Chrome via Chocolatey on Windows Server 2022, OR
In Windows Server 2022, install Google Chrome via Chocolatey

Environment
- Operating System: Microsoft Windows NT 10.0.20348.0
- PowerShell Version: 5.1.20348.2849
- Shell:

Chocolatey Log
https://gist.github.com/billy-stellar/52b1687b4a18f22dcc339ddaf8b51254

Anything else?
Is this due to the version mismatch? A new version was released today. Using latest versions of Ansible AAP. This worked yesterday. Same issue and error code when running 'choco install googlechrome --ignore-checksums' interactively.

I am getting the same error on Windows 11 22H2 with chocolatey and googlechrome.

Also being reported in the comments of the package: http://disq.us/p/3189rfn

I saw the same popup Girts mentions (on the Choco site) - I assume he's not talking about UAC, but Chrome pops up a window when uninstalling asking what to do with browser data. I don't see that when doing a fresh install (no Chrome installed) and getting the 1722 error.
This might be helpful: if I try to install Chrome using the .msi downloaded my Chocolatey, I get the same 1722 error! Is the download being corrupted in some way?

Checking the hashes, they're the same compared to one downloaded interactively.
On Windows 10 22H2, I don't have any issue installing Chrome with Chocolatey. However, I do get a UAC prompt when using an Admin PowerShell.
And for some juice... I think this is Google's issue/change. When I download interactively using the same URL in the Chocolatey script (https://dl.google.com/dl/chrome/install/googlechromestandaloneenterprise64.msi) I get the same 1722.
If I download using this URL (https://chromeenterprise.google/download/?platform=WIN64_MSI&channel=stable), I can install just fine! Comparing hashes, they do not match. That URL redirects to below. Can we test with that URL? I'm not sure if that will change with each version, however.
Good URL, but might have too much info, like version:
https://dl.google.com/tag/s/appguid%3D{8A69D345-D564-463C-AFF1-A69D9E530F96}%26iid%3D{A9905483-CFC9-3864-721B-7479F381002E}%26lang%3Den%26browser%3D5%26usagestats%3D0%26appname%3DGoogle%2520Chrome%26needsadmin%3Dtrue%26ap%3Dx64-stable-statsdef_0%26brand%3DGCOM/dl/chrome/install/googlechromestandaloneenterprise64.msi
The iid can be removed:
https://dl.google.com/tag/s/appguid%3D{8A69D345-D564-463C-AFF1-A69D9E530F96}%26lang%3Den%26browser%3D5%26usagestats%3D0%26appname%3DGoogle%2520Chrome%26needsadmin%3Dtrue%26ap%3Dx64-stable-statsdef_0%26brand%3DGCOM/dl/chrome/install/googlechromestandaloneenterprise64.msi
To reiterate, when I download using the URLs above, I can install the MSI. If I use the https://dl.google.com/dl/chrome/install/googlechromestandaloneenterprise64.msi URL, I get error 1722.

@GraphicHealer do you have any insight on this issue, or ability to test with a different URL?

@GraphicHealer do you have any insight on this issue, or ability to test with a different URL?

I am so sorry  but I am very confused. I have not touched Chocolatey in over a year... Lol

Here's a related issue w/ a fix: https://issuetracker.google.com/issues/382108340#comment17

@GraphicHealer do you have any insight on this issue, or ability to test with a different URL?

I am so sorry but I am very confused. I have not touched Chocolatey in over a year... Lol

haha sorry, I just saw that you had last modified the URLs. I don't have any experience creating and testing packages or I'd do a pull request.
Thanks @dandunckelman

Sorry for all the noise, everyone! Sounds like Google will be fixing it on Dec 10 and a fix is not needed here (unless we need a backup URL to download from if an error is detected 👀)


[draft/proposal] create passiveSection option for NavigationAccordion

When working with content and NavigationAccordion, we use the page's hierarchy to populate the navigation. There are cases, especially in very big documents, that the page's hierarchy doesn't always match with how we want to present the navigation.
This PR proposes adding an optional feature to enable small headings within a section:

These headings do not link to content and only exist to help group together content.
These passive headings allow us to surface the most important headings.

In the example below, we would ordinarily need to make "Methods and events" and "Properties" the h2s on the page, but that would place the other headings as h3s, which are hidden until the user scrolls to that section. The h3s are actually the most compelling content, so by adding this passiveSection feature, we can help organize the content without sacrificing with how we're marking up the page:

How to test

QA checklist

[ ] No errors logged to console.
[ ] Accessibility score in Chrome DevTools Audit/Lighthouse is 100% with Lighthouse version: #.#.#.
[ ] Component is accessible at mobile-size viewport.
[ ] Component is accessible at tablet-size viewport.
[ ] Component is accessible at laptop-size viewport.
[ ] Component is accessible at big-monitor-size viewport.
[ ] Create a PR in a site repo, copy the component, and test it. Push to staging and let the reviewer know they can also test the component there.

Open the test cases app locally on:

[ ] Chrome, no errors logged to console.
[ ] Firefox, no errors logged to console.
[ ] Safari, no errors logged to console.
[ ] Edge, no errors logged to console.
[ ] IE11, no errors logged to console.
[ ] Mobile Safari, no errors logged to console.
[ ] Android Chrome, no errors logged to console.

I don't think we need this anymore


Variable '${defaultBuildTask}' not reliably found

Recently I'm seeing this problem in Insiders:
When debugging a plain "hello world" extension, sometimes the ${defaultBuildTask} does not resolve to the default task defined in tasks.json:
{
	"type": "npm",
	"script": "watch",
	"problemMatcher": "$tsc-watch",
	"isBackground": true,
	"presentation": {
		"reveal": "never"
	},
	"group": {
		"kind": "build",
		"isDefault": true
	}
}

Instead the npm scripts from the package.json are shown in a Quickpick:

Restarting VS Code does not help, but changing a single character in the tasks.json or launch.json fixes the problem.

@meganrogge the task service contributes the variable defaultBuildTask here: https://github.com/microsoft/vscode/blob/49de874e5fcf25df4aa84cc0f2e00a2f40bea223/src/vs/workbench/contrib/tasks/browser/abstractTaskService.ts#L298-L299

When I Run Task, I see that the default build task isn't in the dropdown for about 10 seconds

could be the root cause: https://github.com/microsoft/vscode/issues/157814

Yes, the 10 second delay could explain the problem. And my workaround "to change a single character in tasks.json or launch.json" only helps because it takes longer than 10 seconds...

what's odd is I don't see this happening in oss, only insider's

I am actually no longer able to reproduce the issue I mentioned above and it's working for me in an extension 🤔. @weinand a gif would be super helpful if possible

@weinand are you still able to repro?

@meganrogge in today's Insiders I'm no longer able to reproduce the issue.

great, pls reopen this if you see it again

Marking as not-reproducible


Fix typos in search

This simply addresses a small typo in EnSearch. I'll land immediately.

:+1:


How many grocery stores have a Divvy station nearby?

Another problem we can solve with Turf.js.

Hey Steven, I added a "turf-tests" branch, so I can show you what I'm trying to do with turf.  Right now I'm struggling with iterating through the list of groceries to use them as comparison points in turf.  For example, in the console right now I can access the latitude of the grocery store at index 0 of the groceriesGeojson feature list by typing in "groceriesGeojson.features[0].properties.LATITUDE".  But when I try to use this information in the code, groceriesGeojson always turns up as undefined.  Is there a better way of interacting with this data?

@guillermokrh checkout my latest commit to turf-tests. I experimented with turf and divvy and was able to iterate through all the divvy stations and create 0.2 mile buffer regions using turf. This technique could probably be mimicked for the grocery stores.

Thanks Gino I'll check it out!

@zorostang Can you show me tomorrow? I'm gonna be coding tomorrow with you guys, something I haven't done for weeks because of...distractions at Hack Night.

Done. @guillermokrh made it so the number would be calculated and then printed it to the console. See another issue for the next step.

Done. @guillermokrh made it so the number would be calculated and then printed it to the console. See another issue for the next step.


Cannot drag tauri app window on MacOS when titleBarStyle is set to Overlay

Describe the bug
On MacOS Sonoma, I cannot move the application window of my tauri app when titleBarStyle is set to Overlay:
tauri.conf.json
 "windows": [
      {
        "title": "tauri-app",
        "width": 800,
        "height": 600,
        "titleBarStyle": "Overlay"
      }
    ]

Reproduction

Generate a minimal tauri app (accept all default values)
npm create tauri-app@latest

Run npm install in tauri-app
cd tauri-app
npm install

Edit src-tauri/tauri.conf.json and add titleBarStyle: Overlay to the windows property section:

"windows": [
      {
        "title": "tauri-app",
        "width": 800,
        "height": 600,
        "titleBarStyle": "Overlay"
      }
    ],

Run tauri app
npm run tauri dev

Faulty behaviour: The application window cannot be moved.
Expected behavior
Expected behaviour: The application window can be moved.
Full tauri info output
npm run tauri info

><EMAIL_ADDRESS>tauri
> tauri info

[⚠] Environment
    - OS: Mac OS 14.4.1 X64
    ✔ Xcode Command Line Tools: installed
    ✔ rustc: 1.75.0 (82e1608df 2023-12-21) (Homebrew)
    ✔ cargo: 1.75.0
    ⚠ rustup: not installed!
      If you have rust installed some other way, we recommend uninstalling it
      then use rustup instead. Visit https://rustup.rs/
    ⚠ Rust toolchain: couldn't be detected!
      Maybe you don't have rustup installed? if so, Visit https://rustup.rs/
    - node: 21.5.0
    - npm: 10.2.4

[-] Packages
    - tauri [RUST]: 1 (no lockfile)
    - tauri-build [RUST]: no manifest (no lockfile)
    - wry [RUST]: no manifest (no lockfile)
    - tao [RUST]: no manifest (no lockfile)
    - @tauri-apps/api [NPM]: 1.5.3
    - @tauri-apps/cli [NPM]: 1.5.11

[-] App
    - build-type: bundle
    - CSP: unset
    - distDir: ../dist
    - devPath: http://localhost:1420/
    - bundler: Vite

Stack trace
No response
Additional context
No response

This might be related to https://github.com/tauri-apps/tauri/issues/4316

This might be related to 4316

Maybe, did you add the data-tauri-drag-region attribute the issue was talking about to your titlebar-ish element? Just making sure cause you didn't mention it, but it is required to be able to move your app.


BibIndex: infinite loop in beautify_range_list

Fixes infinite loop in beautify_range_list() function that
was triggered in particular conditions.

Signed-off-by: Samuele Kaplun<EMAIL_ADDRESS>

Closed by #3725.


Fix blimp tests

@igor-krawczuk might have something to say about this?

I don't think so? I got knocked out by health issues a while ago and have been trying to sort out my day job enough to have time to rejoin the discord and properly contribute to eleuther projects

@igor-krawczuk Oops! Wrong Igor. I meant to tag @igor0.
Sorry to hear about your health problems :( I hope things aren’t too bad.

@leogao2: any more info about what's broken with blimp tests? Did they just start failing all of a sudden?


bower support

adding the bower support
adding the bower.json
update the files in README.md
update the files in doc

@chikara-chen  :+1: nice work , please have a look my pr , let me know if you need any changes

@kasiriveni 😆Today is Thanksgiving Day, thanks for your pull request. But actually, it's unnecessary to support bower since then npm is more powerfull.

@chikara-chen i saw lot of react-component support client side also, that why i create a new feature


Selected text highlight remains after clear_screen (cmd+k)

When I select text to copy/paste and then clear the screen, the text is gone but the highlighted portion of the screen is still there.
Steps to reproduce:

select some text to copy it

hit cmd+k to execute clear_screen

Since you mention command, I suppose you're on a Mac. I just tried it on a MacBook Pro 14 inches (running MacOS 14.6.1) and couldn't reproduce the bug.
Thought I'd mention it for the developers, since it does not seem to happen for everyone.
Cheers

I was able to consistently reproduce this issue. Reproduction steps:

Select an area.
Trigger a clear_screen (You can use this keybinding: keybind = cmd+k=clear_screen).
The selected area is still highlighted.


#6 views

Dear Reviewer,

In this PR I followed the instructions of Blog app - Views:

Created the views for the URL-s
Added some styling

The root route shows the logo, yes, but all the routes work perfectly. Otherwise I wouldn't have been able to style it properly.

The root route shows the logo, yes, but all the routes work perfectly. Otherwise I wouldn't have been able to style it properly.

Hello @MattGomb ,
This is well noted but I wasn't able to access the functionalities as a get a blank screen. Kindly resubmit maybe another reviewer will be able to access it.
Thank you for understanding.
Project Image

@Whoistolu Thanks, i already submitted for another review.
I think you probably had to add some users and posts and comments for them to be visible

some snaps that might be helpful:

@Whoistolu Thanks, i already submitted for another review.
I think you probably had to add some users and posts and comments for them to be visible

That's correct. I actually created two users. I hope the next reviewer gets the database well-populated. I do not know why it didn’t work with me, hence my reason for invalidation since I could not test the functionalities.
Thank you Matt.

@Whoistolu Thank you for your patience and thoroughness!

@Whoistolu Thank you for your patience and thoroughness!

You are welcome Matt.
Best of luck and happy coding!

@codepantha Can you please send me the link where the part how to link other views is covered in the material for this milestone?

@codepantha Thanks for all the suggestions, and the keen eye, all the required changes are implemented!


Strip out MultiQC boilerplate code

I noticed that all of the CI tests ended with a warning:
WARN: [nf-core/diaproteomics] Could not attach MultiQC report to summary email

..which I thought was odd, as this pipeline doesn't run MultiQC. So I went through the pipeline code and stripped out all mentions of MultiQC.
This might make the tests fail. We'll see. Can maybe skip some if necessary.
PR checklist

[x] This comment contains a description of changes (with reason).
[ ] If you've fixed a bug or added code that should be tested, add tests!

[ ] If you've added a new tool - add to the software_versions process and a regex to scrape_software_versions.py
[ ] If you've added a new tool - have you followed the pipeline conventions in the contribution docs
[ ] If necessary, also make a PR on the nf-core/diaproteomics branch on the nf-core/test-datasets repository.

[ ] Make sure your code lints (nf-core lint .).
[ ] Ensure the test suite passes (nextflow run . -profile test,docker).
[ ] Usage Documentation in docs/usage.md is updated.
[ ] Output Documentation in docs/output.md is updated.
[ ] CHANGELOG.md is updated.
[ ] README.md is updated (including new tool citations and authors/contributors).

Explanations for a few general things I just changed in main.nf

Replace Sample with sample - Groovy assumes variables that begin with capitals are classes. It usually doesn't make any difference, but I get paranoid that it can have unexpected side-effects. So I never start a variable name with a capital letter.
Consistent indentation - we will probably get around to adding a lint test for this one day, so figured I may as well fix it up now. And it keeps my inner nerd happy 🤓
No need for \\ on the final line of a multi-line command
I usually break multi-line commands after the initial command and then use a single level of indentation for the arguments

I find this easier to read, less whitespace - also indentation is then standard irrespective of command name

If <= 3 arguments, I stick to a single line for the command


create a header-only version

As wished in http://www.reddit.com/r/cpp/comments/2rbhn3/json_for_modern_c_what_if_json_was_part_of_modern/cnelnzq:

I think this would be fare more useful as a header only library. I'm down for sending a PR with the change if you are.

And as I wrote:

Good idea! But I think it would be more useful if there would be a script that reads the source files json.cc and json.h and creates a header-only version. That way, both approaches can be followed at the same time.

It can improve compile time when precompiled headers are used and allows easy include only usage. The cpp file always has to be supplied to the compiler (which is mostly done by build tools that assume everything in one root) and therefore encourages adding the source directly in projects instead of just pulling them from a central include path.
Unfortunatly the cpp world has no ultimate solution to dependencies, packaging, etc. so I don't know if this is an advantage for others.

Have you already seen biicode ? They are really active in bringing a dependency solution for C++.

I've seen it and it seems pretty cool, but I don't want to rely on proprietary tools. I couldn't find a statement about escrow or plans for worst case.

@PaulFreund - could you check if the file header_only/json.h suits your needs?

Should we really push the generated header only version to the repository? It's a generated file similar to a binary and should be hosted somewhere else.

I thought about it and thought the way Catch are doing it is reasonable. In the end, creating the header requires tools such as cat and sed. While they may be standard on some machines, they are not for Windows. Once the code is reasonably stable, one could think about using GitHub's release feature.
@Teemperor, what do you think?

I think a release on Github from time to time is the best solution right now. It's just slightly more work compared to pushing the header file to git and it keeps the repository clean.
If we want this automated, we could also just run the header generation on a external server and serve it over HTTPS (or use the Github API to create releases).

Apart from the issue of how to publish the header-only version, I think we are done here.

Sorry for the late reply. Unfortunately just copying header and source together won't be enough. While free functions could be inlined, the member functions that are defined outside of their class declarations can't.
From my point of view there are only upsides for developing the library completely header only but I understand that it might also be a matter of taste.

Thanks @PaulFreund for your reply.
As I have no experience in creating a header-only version, I assumed that copying the sources would be enough. Can you give me more insights why this is not sufficient or point me to sources that explain how to do this properly?

you'll get duplicated symbols if you include it more than once

You are right. I did not check for a case where the header is included in several files. :-(

:+1: for header only version.

:+1: for header-only version. I'm very happy with this library but I had to do my own temporary patching (inlining) so that I could use it in my own header-only libraries.

Fixed in latest commit: the class is now header-only.

:clap:


Improve ICrossChainSync

Describe the feature request
From Jeff:
The only on-chain thing that would make life easier is it if the TaikoL2/L1 contracts that implement ICrossChainSync had a way to see what block number a blockHash was synced in.
because right now i need to index every CrossChainSync event and then find out ,otherwise, i am waiting for "latest" headers to be synced and it takes a long time.
and i dont believe there is an on-chain way to look up
blockHashToWhatBlockItWasSyncedIn[l1BlockHash] ?
Describe alternatives you've considered
Description of the alternatives you've considered here.
Additional context
Additional context here.

@cyberhorsey please take a look at this PR and let me know if it is what you want.

Considered done.


WIP: Jenkinsfile: use env-var DOCKER_REGISTRY instead of hard-coding

Docker registry is used via hard-coded uuid value that is specific to
CI jenkins system, thus limiting Jenkinsfile to be functional
in this Jenkins system only where this UUID is defined.
We can make Jenkinsfile more generic by using a variable.
This variable needs to be provided by Jenkins instance.

note that first CI run is expected to fail, as I did not add that variable in Jenkins yet. One step at a time...

I added DOCKER_REGISTRY in Jenkins and triggered re-test, started running, good.

I added another commit adding -i option to top. The idea is that -i should show meaningful lines, and we can stop cutting hard-coded 20 lines, which will mostly  show many irrelevant lines.

Taking away WIP, ready for merging


Either make the shared service registry thread-safe, or document/enforce that it shouldn't be used from tasks

We were periodically seeing some of our builds hang with CPU usage, and tracked it down to code that ran in the daemon process with the following stacktrace, on several threads:
	at java.util.TreeMap.getEntry(java.base@11.0.5/TreeMap.java:357)
	at java.util.TreeMap.get(java.base@11.0.5/TreeMap.java:277)
	at org.gradle.api.internal.DefaultNamedDomainObjectCollection$UnfilteredIndex.get(DefaultNamedDomainObjectCollection.java:594)
	at org.gradle.api.internal.DefaultNamedDomainObjectCollection.findByNameWithoutRules(DefaultNamedDomainObjectCollection.java:311)
	at org.gradle.api.internal.DefaultNamedDomainObjectCollection.findByName(DefaultNamedDomainObjectCollection.java:288)
	at org.gradle.api.services.internal.DefaultBuildServicesRegistry.registerIfAbsent(DefaultBuildServicesRegistry.java:95)
	at com.palantir.gradle.conjure.GradleExecUtils.exec(GradleExecUtils.java:32)
	at com.palantir.gradle.conjure.CompileIrTask.generate(CompileIrTask.java:135)
	...

In fact, we saw this stacktrace on seven different threads, with a corresponding 700% CPU usage. The problem with the plugin code is that it was trying to register a shared service during task execution time.
As-is, the Gradle shared services registry (project.getGradle().getSharedServices()) is not thread-safe, and if used from multiple threads it can fail in a way that results in an infinite loop. (This is a possible outcome of concurrent unsynchronized edits to a TreeMap, according to this blog post: https://ivoanjo.me/blog/2018/07/21/writing-to-a-java-treemap-concurrently-can-lead-to-an-infinite-loop-during-reads/)
In other words, these register calls should only be made during the Gradle configuration process, not during task execution.
The current build services documentation (as of 7.0.2) does guide the user through the correct way of setting up a shared service, but it doesn't explicitly warn not to use this during task execution (i.e. for caching purposes), which may be appealing due to being much simpler code.
Some possible improvements to avoid people running into this in the future:

Make the registry thread-safe. (If configuration-in-parallel is in Gradle's future, this might be the best option.)
Throw an exception if the user tries to add to the registry during the wrong phase of the build, or otherwise prevent its use. (Might need to wait for a major-version release, but a warning could be added immediately.)
Point out in the documentation that this is a problem. (Might be hard to find.)

I can try to create a public repro if it would be helpful.

FTR: Registering a shared build service has been made thread-safe in de745540d69e659dc7e10827076664d5938d2f3a.

Closing per #20204.


Remove Data Observatory v1

NOTE: this can not be merged/deployed until March 31st

Thanks for the review. Regarding the columns drop, I would make this in a different step (in the future). I've created a ticket with the code of the migration: https://app.clubhouse.io/cartoteam/story/145308/add-migration-to-drop-old-do-columns.

Thanks for the review @VictorVelarde.
I'll clean these entries from the application config:

data_library_deps.js
data_library.js
data_library.css


bevy_render: Fix Quad flip

Objective
The documentation was unclear but it seemed like it was intended to only flip the texture coordinates of the quad. However, it was also swapping the vertex positions, which resulted in inverted winding order so the front became a back face, and the normal was pointing into the face instead of out of it.
Solution

This change makes the only difference the UVs being horizontally flipped.

bors r+


error compiling "undefined reference to `SpotifyPEM'

I want to run your code, but it wont run.
I get 2 errors..

Hi, sorry for confusion.
I intentionally removed one file and I forgot to write an explanation.

To create this file, you need following file/information:

root CA PEM file for Spotify API (api.spotify.com). I usually use FireFox to download it, like: https://www.youtube.com/watch?v=GzPJxEo1HSo
clientID as Spotify App. Sign-up as Spotify developer and create your own app to obtain client ID: https://developer.spotify.com/dashboard

In addition, you have to set redirect URI on your Spotify App as following:

I wrote an article how it works (in Japanese), but not prepared README or guide yet. I will make time to do that.
https://note.com/njrecalls/n/n5f3e35186f46


Improve Open Database Object search

Is your feature request related to a problem? Please describe.
When handling multiple schemas, it's easier to open data objects and filter/match by schema than to remember the specific object/table one is looking for.

We also cannot search for functions, only procedures.
Describe the solution you'd like
When searching database objects, we'd like the search to match the keyword to schemas and show objects that are part of said schema. Functions should also be matched.
Describe alternatives you've considered
None at the moment.

Thanks for the request


Add command line arg to force specific SNI

This fixes an SNI issue in reverse proxy mode.
Steps to reproduce the problem:

Start a reverse proxy instance that connects to an HTTPS endpoint using SNI:
mitmproxy -R https://www.example.com --setheader :~q:Host:www.example.com
Open https://localhost:8080/ in a web browser

What is the expected behavior?
mitmproxy should use the domain www.example.com to negotiate SNI with the server.
What went wrong?
mitmproxy instead sends no SNI value to the server, and the request fails with the following error: Cannot establish TLS with www.example.com:443 (sni: None): TlsException('Cannot validate certificate hostname without SNI',)
How does this PR fix the issue?
This PR adds a --server-sni flag that allows you to specify an SNI value that should always be used. Thus, you can fix the original problem above by adding the new flag: mitmproxy -R https://www.example.com --setheader :~q:Host:www.example.com --server-sni www.example.com.

Hope this is helpful! Happy to make adjustments if you think there's a better way to address this problem :)

Thanks for the fantastic PR! :smiley:
Now this looks like we pretty much always just want to send "www.example.com" as the SNI in reverse proxy mode. Do you think it would make sense to just make that the default behaviour in reverse proxy mode, no matter what the client sends (we could add a flag to disable that if we ever need to)? It'd be great if things would just work out of the box. :)

@mhils Makes sense to me! My only concern is that that might be a breaking change for existing users, if for some reason they were depending on the original SNI value passed via the original request. The docs for overwriting the Host header imply that there are use cases where you'd want to pass through the original Host header, and I'm unclear if the same is true for SNI.
All that said, if we're not worried about a breaking change, then I think the ideal behavior for reverse proxy mode would actually be to use "www.example.com" as both the default SNI value AND the default Host header. I imagine that's the desired behavior for 99% of users, but I'm new to this, so it's always possible that I'm missing some important use cases. Thoughts?

All that said, if we're not worried about a breaking change, then I think the ideal behavior for reverse proxy mode would actually be to use "www.example.com" as both the default SNI value AND the default Host header. I imagine that's the desired behavior for 99% of users, but I'm new to this, so it's always possible that I'm missing some important use cases. Thoughts?

I completely agree on this - in fact, I was about to mention that in the review, but then decided to keep this PR simple for now. :-)
I'd be more than happy to merge a PR for SNI and/or the Host header (ideally separate PRs, there shouldn't be an overlap). Let me know if there's anything I can help you with, you're also more than welcome to join us on Slack! :smiley:

@mhils Updated! I believe this should behave as expected, though if I've misunderstood how self.server_conn works, just let me know. I'll look into making a separate PR to handle the Host header in reverse proxy mode as well 👍

Updated again! Thanks for the suggestions.

Awesome. Thanks again for the great PR and the fast turnaround time! 🍰 🙌 😊


Incorrect command to install pylint using pip on Ubuntu 16.04.6

Issue Type: Bug
Steps

Install the python extension by Microsoft
Create new file
Save the file as hello.py

Expected

A popup will appear suggesting to install pylint
On accepting the request pylint installation using pip will be initiated on terminal

Actual
On accepting the request following command got trigger which was not executed successfully
$ sudo apt install python3-pip/usr/bin/python3 -m pip install -U pylint --user
[sudo] password for saikat: ****
E: Command line option 'U' [from -U] is not understood in combination with the other options.

Extension version: 2019.2.5558
VS Code version: Code 1.32.3 (a3db5be9b5c6ba46bb7555ec5d60178ecc2eaae4, 2019-03-14T23:38:49.842Z)
OS version: Linux x64 4.15.0-46-generic

System Info

Item
Value

CPUs
Intel(R) Core(TM) i3-4130 CPU @ 3.40GHz (4 x 2832)

GPU Status
2d_canvas: enabledchecker_imaging: disabled_offflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onnative_gpu_memory_buffers: disabled_softwarerasterization: disabled_softwaresurface_synchronization: enabled_onvideo_decode: unavailable_offwebgl: enabledwebgl2: enabled

Load (avg)
1, 0, 0

Memory (System)
7.68GB (3.14GB free)

Process Argv

Screen Reader
no

VM
0%

Unable to reproduce, hence closing the issue.


Unpredictable behavior

Hello. Is it possible to define a value field like const PROGMEM with your library? Respectively it is possible to use but the device then does not predict my behavior - it does not work .. Me it does not work ..
const PROGMEM uint8_t pinValues[] = {B10101010}; // not worked!!

I do not think this is an issue with the library, nor is there any unpredicted behavior.
StackOverflow C++

Did you try to test it?
static const uint8_t PROGMEM pinValues [] = {...};
I think you should know. In any case, I encountered it yesterday while working with your library. I did not play any more, I removed const static PROGMEM and everything works as well. Otherwise, the behavior was the following: either the flames of the light were extinguished, not one or the LEDs flashed randomly ...

Maybe related to this
Quote
const dataType variableName[] PROGMEM = {}; // use this form
const PROGMEM dataType variableName[] = {}; // or this one
const dataType PROGMEM variableName[] = {}; // not this one


feat(docs): Reorganize the issues since they are a mess with frontend and backends being mixed together

Done


[BUG] Rendering branch crashes in Vulkan

Bug description:
There are many crashes when using the next effects in vulkan. Here is a list

Bloom crash on startup - image provided
Sharpen crash when used - crash in ezDescriptorSetPoolVulkan::UpdateDescriptorSet
Chromatic Aberration crash when used before tonemapping - crash in ezDescriptorSetPoolVulkan::UpdateDescriptorSet
Debanding crash when used - crash in ezDescriptorSetPoolVulkan::UpdateDescriptorSet

Screenshots:
Bloom crash on startup

Dev-branch commit hash:
All tested in rendering branch pre FXAA

Hi @PlasmaDev5, unless for the chromatic aberration pass it's really weird for me to see that all the other passes are broken on Vulkan, since I've only used the RHI to implement these passes... Maybe the use of compute shaders?
Can you please show me the stacktrace? I'm not able to use the Vulkan renderer on my computer, the renderer is not able to initialize properly, but I can use Vulkan in games and other engines... I didn't had a look at the reason since it's still in development by the EZ team.
For the Chromatic Aberration pass you should use it after the Tonemapping pass. I plan to update the Tonemapping pass to add more algorithms and also use a compute shader instead of a fragment shader. But for it to work now you can make a quick hack in the TonemapPass.cpp file at line 80 to change:
outputs[m_PinOutput.m_uiOutputIndex].SetAsRenderTarget(pColorInput->m_uiWidth, pColorInput->m_uiHeight, desc.m_Format);

By:
outputs[m_PinOutput.m_uiOutputIndex].SetAsRenderTarget(pColorInput->m_uiWidth, pColorInput->m_uiHeight, ezGALResourceFormat::RGBAHalf);

The Post FX passes in our current render pipeline looks like this:

I used it after tonemapping in DX11 and ended with a black screen.
I removed the MSAA stuff from the pass

If i go straight from Tonemapp to FramePass it all works correctly
if i go to any other of the new passes it ends with a black screen

Pulled latest, works in DX11. will give a breakdown of the vulkan issues in the coming days


[Bug]: Ballerina bindgen not support for custom maven repositories.

Description
When bindgen  ava code which contains dependencies from custom maven repository. it's not retrieve from there due to hardcoded repositories.
https://github.com/ballerina-platform/ballerina-lang/blob/master/misc/maven-resolver/src/main/java/org/ballerinalang/maven/MavenResolver.java#L80-L87
Steps to Reproduce
No response
Affected Version(s)
2201.3.0
OS, DB, other environment details and versions
UBUNTU
Related area
-> Other Area
Related issue(s) (optional)
No response
Suggested label(s) (optional)
No response
Suggested assignee(s) (optional)
No response

This is fixed in following PR
https://github.com/ballerina-platform/ballerina-lang/pull/39659


Docker: Optimize build by reordering and grouping some statements

Description
Resolves: #3248
Groupes and Reorders Docker Statements for better build performance

lower number of layers (smaller build)
often changing things last

How Has This Been Tested?

[x] Ran Dockerfile
[x] Ran dev.Dockerfile with scripts/dev.sh

Checklist

[x] The PR is tagged with proper labels (bug, enhancement, feature, documentation)
[x] I have performed a self-review of my own code
[x] I have added unit tests that prove my fix is effective or that my feature works; not needed
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation; not needed

cc: @wangxiaoyou1993

cc: @dy46

thanks for doing this @christopherscholz! how did you determine the package versions to install?

thanks for doing this @christopherscholz! how did you determine the package versions to install?

I just checked at runtime. Once for amd64 and arm64. Both seem to use the same versions
apt list --installed
pip list

Hey I reverted this PR because the docker build was failing for someone on the team due to version not exists errors. I'll try testing it a bit more, but just wanted to let you know why it was reverted.


[Bug] stylebot doesn't work on some github "json" page

for example, this one "https://github.com/9999years/cloudy-calculator/blob/master/src/manifest.json"
neither v2 or v3 works.
I love stylebot.

I am able to load stylebot and customize css on that page. When you say it doesn't work, does stylebot not open at all? Or you are not able to apply specific CSS? Detailed reproduction steps will be helpful. Thanks

this may be similar to an issue I'm having with wiki's whose page name ends in ".json". If I rename the wiki to something like "... .json file" stylebot makes the changes desired.


[WIP] Auth tests

Fixes: #2042

@timabbott, do these LDAP tests work? There is this LDAP testter available as well for testing LDAP.

For LDAP tests, I think something like https://pypi.python.org/pypi/fakeldap/0.5.1 would be a lot better, since that would avoid adding a dependency on a test Java server.  With that, we could write some really nice tests that test the overall flow with some fake data.
Also, re: JWT, I'm not sure why you're removing the signature-related code; I would have expected that code to be required (but involve more test setup than you seem to have done so far).  See https://jwt.io/introduction/ for details on JWT signatures.

For LDAP tests, I think something like https://pypi.python.org/pypi/fakeldap/0.5.1 would be a lot better, since that would avoid adding a dependency on a test Java server. With that, we could write some really nice tests that test the overall flow with some fake data.

Yeah, this looks good.

Also, re: JWT, I'm not sure why you're removing the signature-related code; I would have expected that code to be required (but involve more test setup than you seem to have done so far). See https://jwt.io/introduction/ for details on JWT signatures.

The decode function verifies the signature itself. The option which enables that was missing, I have added that.

Mostly done. FakeLDAP is not working in Python 3 so I'll have to update it.

PR to upgrade fakeldap: https://github.com/30loops/fakeldap/pull/6

I still need to add subdomains related tests for JWT and LDAP.

This is looking great!  I merged the first two commits, after fixing a small Python 3 compatibility error (changing "Let's get started" to not have a unicode-style "..." in it).

@timabbott , please review.
(BTW, the build passes on in my dev env but is failing on Travis. Is there some problem with Travis or some problem with this PR?)

The mypy errors are your issue, but test-backend mysteriously started failing on master last night with:
Running zerver.tests.test_subs.SubscriptionAPITest.test_multi_user_subscription
Traceback (most recent call last):
  File "/home/travis/build/zulip/zulip/zerver/lib/test_runner.py", line 129, in run_test
    test_method()
  File "/home/travis/build/zulip/zulip/zerver/tests/test_subs.py", line 1355, in test_multi_user_subscription
    self.assertEqual(len(add_peer_event['users']), 13)
  File "/usr/lib/python3.4/unittest/case.py", line 797, in assertEqual
    assertion_func(first, second, msg=msg)
  File "/usr/lib/python3.4/unittest/case.py", line 790, in _baseAssertEqual
    raise self.failureException(msg)
AssertionError: 15 != 13

we're investigating.

@timabbott, fixed the mypy errors.

Cool, I fixed master being broken, so if you rebase this should pass (assuming your code has no unknown issues).

@timabbott, done.

@timabbott, thanks for the feedback. Please review.

Cool, posted a couple more comments; otherwise looks good!

@timabbott, done.

Awesome, these look great!  Merged, after fixing 2 things:

ZulipLDAPUserPopulator was imported twice
Some of the fixes for the "Add LDAP tests" commit were in the "Add ZulipLDAPUserPopulator test." commit, so I moved them into the proper place.

Huge thanks for doing this @umairwaheed!  We found a bug in our auth code, and now can be much more confident about future changes to it.


BUG- Sections not appearing in Taipy Studio view

Description
Data Nodes, Tasks, Pipelines, and Scenarios sections are not appearing in Taipy Studio Config sidebar.
How to reproduce

Have the up-to-date VS Code installed (1.77.2)
Install the latest Taipy Studio version

Expected behavior
Data Nodes, Tasks, Pipelines, and Scenarios sections should appear as before.
Screenshots

Runtime environment
Please specify relevant indications.

OS: Windows 11
Visual Studio Code version: 1.77.2
Taipy Studio Config version: 1.0.2

https://code.visualstudio.com/api/references/when-clause-contexts#comparison-operators


Key Guardians: Recover your Account (1/2)

User flow for Account Recovery
Describe the solution you'd like
When the user wants to recover their account, they can do so by selecting
"Lost your Key, Recover your account here" from the Main Menu.

Once the user selects this option, they will be taken to a screen with an input field where they can enter their Username.

If the user account has been found then a card with the User's Full Name. Selecting this card will Begin the recover process.

Additional context
Add any other context or screenshots about the feature request here.

@n13 I guess this is already implemented 😅 same for part 2 https://github.com/JoinSEEDS/seeds_light_wallet/issues/795 if so could  you close them?


MDA SPUR feedback

fixes https://issues.redhat.com/browse/ADVISOR-1774

sticky title

details page, status -> last matched

remove code editor titles

remove code editor double scrolls

sentence case filters

Codecov Report

Merging #9 (567d6a9) into master (692031d) will not change coverage.
The diff coverage is 0.00%.

@@          Coverage Diff           @@
##           master      #9   +/-   ##
======================================
  Coverage    0.00%   0.00%
======================================
  Files          28      28
  Lines         257     257
  Branches       72      72
======================================
  Misses        244     244
  Partials       13      13

Impacted Files
Coverage Δ

src/Components/CodeEditor/CodeEditor.js
0.00% <0.00%> (ø)

src/Components/SigDetailsTable/SigDetailsTable.js
0.00% <0.00%> (ø)

src/Components/SigTable/SigTable.js
0.00% <ø> (ø)

src/Routes/Signatures/Details.js
0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 692031d...567d6a9. Read the comment docs.


documentation for v0.3.0

Make it sense to revert the PR #653 since the v0.3.0 is released?

/cc: @anusha94 can you please have a look?

Hey @curx, the docs have been updated for v0.3.0 release features. Thanks for highlighting this.


[Feature Request] Share the data between host and apps

Background
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
Proposal
Describe the solution you'd like, better to provide some pseudo code.
Additional context
Add any other context or screenshots about the feature request here.

Wrong location, I am just forker.


'website' wants to store files on this device

I'm having an issue whereby I cant access the selectors I'm after to scrape unless I click on the 'allow' button. However, their does not seem to be a way to do this in puppeteer.

I found a similar topic on Chrome Drivers Users google groups forum here
And with that in mind tried using the following to do the 'unlimited - storage' argument but it didn't work.
Is there a way around this currently in Puppeteer?
   const browser = await puppeteer.launch({headless: false},{args:['--unlimited-storage']});     const page = await browser.newPage();

Duplicate of https://github.com/GoogleChrome/puppeteer/issues/846

This is still an issue for me because I can't find the permission (https://pptr.dev/#?product=Puppeteer&version=master&show=api-browsercontextoverridepermissionsorigin-permissions) related to FileSystem API Storage


Changes in chemicals page in guidebook

About the PR
Added pages to each category of chemicals under the "Chemicals" tab
Why / Balance
I didn't like how I always need to scroll down in the chemical's tab to look for a chemical I need so I added pages for them. Makes it easier to find something you need. No more infinite scrolling in the chemicals tab!
Technical details
Moved the chemicals stuff from "shiftsandjobs.yml" to its own "chemicals.yml" file, added "Chemical Tabs" folder that contains added .xml files for the pages.
Media

[X] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

Changelog

:cl:

add: Added pages for each categories from the chemical page in the guidebook, no more infinite scrolling when looking up certain chemicals.

If there's any other issues, please tell! I'll fix em right away while I have time.

My review comment about "Medicine" vs "Medicinal" still isn't solved.

My review comment about "Medicine" vs "Medicinal" still isn't solved.

ok I uhh... tried to make sure that the ID for Medicine in the Chemicals Tab is much more uhh... distinct I think is the word or much more uhh... specific.


Fix the extra black portion visibl while scrolling in right direction.

Hey, I would like to contribute, please assign me this issue!
thank you


15.09 linux bumps

@edolstra @rbvermaa @domenkozar Opening a PR because I'm not sure if we want to cherry-pick all of these commits individually or bunch them together manually. Let me know either way and I will merge when tested.

Well, I'll push for now, if I did it wrong let me know.

I think this way is fine.


Feature dual transports

This PR updates CR transports in order to allow multiple radios and add multiradio apps

Draft removed

Draft removed

This PR is ready to be merged now, as it has been successfully tested within the crazyflie_demo environment for Foxy.
Migration to RCLC is still pending and should be addressed in a different PR.


Options declared under a freeformType don't have declaration locations

Describe the bug
See the unstable manual: the services.wordpress.<name>.* options aren't declared by any file (it's actually <unknown-file>, but that's stripped at some point).
I think this is most likely because they are declared inside a freeformType:
https://github.com/NixOS/nixpkgs/blob/44b0d80303d55c38210785a474e92a7e01e133c3/nixos/modules/services/web-apps/wordpress.nix#L271
but I don't know the module system well enough to troubleshoot this.
Additional context
This was causing the https://search.nixos.org unstable channel import to fail because of an IndexError which should be fixed by https://github.com/NixOS/nixos-search/pull/330.
Notify maintainers
This is an issue of the module system, so pinging @Infinisil @nbp @edolstra

Fixed with https://github.com/NixOS/nixpkgs/pull/149689, thanks for the report!


Any support for multi language?

such as Chinese, japanese, etc.

No not planned at the moment, sorry.


BetweenFilter and multiple years

So, as we are aproaching new year, it would be great to see this example get updated, because we might actually have 2 different years, as we are close to new year.
Or actually in general it would be great to have :)
$start = new DateTime('2019-10-22');
$end = new DateTime('2020-05-22');
$country = 'Italy';

$numberOfHolidaysBetweenDates = 0;
$currentYear = $start->format('Y');
while($currentYear <= $end->format('Y')) {
    $holidays = Yasumi\Yasumi::create($country, $currentYear);
    $numberOfHolidays = $holidays->between(
        $start,
        $end
    );
    $numberOfHolidaysBetweenDates += $numberOfHolidays->count();
    $currentYear++;
}

Is there any better method?

Good question. Actually Yasumi is still tied to a single year so your example is I am afraid the best one. See also the discussion here: https://github.com/azuyalabs/yasumi/issues/131
Neither myself nor anyone has yet investigated this further. I don't expect this will be picked up anytime soon.


[TEVA-2740] rework of filters ui mainly to remove accordions

code still to refine and some JS tests to add - but need to get review env available
https://dfedigital.atlassian.net/browse/TEVA-2740

the sonarcloud fail on this is out dated but not rerunning for some reason...


add restore functionality

adds the inverse functions of soft delete by setting deleted_at field to nil

the reasoning for writing this is bc, i cannot locate the restore function in the codebase, can you tell me which file it is located in? also the reasoning i named it soft_restore is to follow the naming schema of the codebase and to prevent code clashes from other using librarys that might have the restore function defined.


[Wallet]: Leap Wallet

Leap wallet is supporting all Cosmos chains (In SwapKit's case Gaia and Kujira), and will have support for MAYAChain in the next few weeks.
Relevant docs
https://docs.leapwallet.io/cosmos/for-dapps-connect-to-leap/add-leap-to-existing-keplr-integration
https://docs.leapwallet.io/cosmos/for-dapps-connect-to-leap/add-leap-to-a-new-dapp

Cosmostation is similar..:
https://docs.cosmostation.io/extension/integration/cosmos/integrate-keplr
https://docs.cosmostation.io/extension/integration/cosmos/integrate-cosmjs

Leap supports THORChain now as well^


helm delete returns error when template contains leading comment

Certain comments in the templates YAML can break helm delete.
Repro template:
# some comment that breaks helm delete
---
kind: NetworkPolicy
apiVersion: networking.k8s.io/v1
metadata:
  name: somenp
spec:
  podSelector:
    matchLabels:
      label-key: bar
  ingress:
  - ports:
    - port: 8080
    from:
    - podSelector:
        matchLabels:
         key: value

helm install works fine.
But when I do "helm delete", I get:
Error: deletion completed with 1 error(s): release "undercooked-dragon": object "" not found, skipping delete
helm ls shows that the release is gone, but still the return code is 1. So this is bad when running helm delete in a script.
When I remove the comment, helm delete doesn't show the error and the return code is 0.

Output of helm version:
Client: &version.Version{SemVer:"v2.14.0", GitCommit:"05811b84a3f93603dd6c2fcfe57944dfa7ab7fd0", GitTreeState:"clean"}
Server: &version.Version{SemVer:"v2.14.0", GitCommit:"05811b84a3f93603dd6c2fcfe57944dfa7ab7fd0", GitTreeState:"clean"}
Output of kubectl version:
Client Version: version.Info{Major:"1", Minor:"11", GitVersion:"v1.11.8", GitCommit:"4e209c9383fa00631d124c8adcc011d617339b3c", GitTreeState:"clean", BuildDate:"2019-02-28T18:49:34Z", GoVersion:"go1.10.8", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"11", GitVersion:"v1.11.9", GitCommit:"16236ce91790d4c75b79f6ce96841db1c843e7d2", GitTreeState:"clean", BuildDate:"2019-03-25T06:30:48Z", GoVersion:"go1.10.8", Compiler:"gc", Platform:"linux/amd64"}
Cloud Provider/Platform (AKS, GKE, Minikube etc.):
AKS

Verified. It seems that it only breaks if it has both a separator "---" and a comment
As a workaround for now, you can remove the "---" line

Still happens. I'm using https://github.com/hashicorp/vault-helm
It does not have any "---" in templates, only comments. I don't think removing all comments is really a possible workaround here.

Hi, @vkukk - apologies for the slow reply and thanks for this report. I am no longer able to duplicate this issue in Helm 3 (with the example you provided and with the Vault chart), so I am closing this issue as no longer present. Please let us know if you can reproduce it in Helm 3; thanks.