Release Checklist 1.19

Issues in Release

[x] #3091 update quota usage internal endpoint fails when username contains special character @hyi
[x] #3065 Cannot copy any web app resource @sblack-usu
[x] #2812 Resource Landing Page: Add Readme Functionality @Maurier
[x] #2569 P2 Composite Res: New layout for Aggregation-level metadata on composite resource landing page @Maurier
[x] #2763 Resource Landing Page: Modify Related Resources @Maurier
[x] #2810 Resource Landing Page: Reorganize Elements For Clarity and Easier Access @Maurier
[x] #2813 Resource Landing Page: File Metadata View @Maurier
[x] #2924 Resource Landing Page: File Browser List View Formatting off for Long File Names @Maurier
[x] #3022 "hidden" buttons on resource landing page are "pressed" by web spiders @Maurier
[x] #2988 Tooltip inconsistency on profile page @engineSound
[x] #2992 HydroShare reference timeseries validation requires method link url @pkdash
[x] #3137 Unzipping does not work on 1.19 candidate release
[x] #3141 Resource specific metadata getting cutoff

Beta Deployment

[x] Diff RC to master to identify and manually make changes in the following files:

hsctl
config/hydroshare-config.yaml
hydroshare/local_settings.py
hydroshare/settings.py
nginx/config-files/hydroshare-ssl-nginx.conf.template
scripts/templates/docker-compose.template

[x] Deployed to Beta
[NA] check_resource beta results match current www results
[x] Review the search and discovery pages
[x] Create a new user and update profile
[x] Create iROD account, test connection and delete iROD account
[x] Create a new resource, check sharing/permission settings, delete new resource
[x] Developers test around issues
[x] QA testing around issues
[x] Stakeholders approval

Production Deployment

[ ] Deployed to Production

Make manual changes to files identified in Beta Deployment

[ ] Maps API key is correct and maps are displaying correctly
[NA] check_resource www results match pre-deployment www results
[ ] Review the search and discovery pages
[ ] Create a new user and update profile
[ ] Create iROD account, test connection and delete iROD account
[ ] Create a new resource, check sharing/permission settings, delete new resource
[ ] Developers test around issue

Notes relevant to deployment

Resource Landing Page redesign!

I found it extremely difficult to make something public after its requirements were met. I was in a hurry to make the test and after meeting all requirements for public, the resource could not be made public. I had to redisplay the page to make it public.

@alvacouch I felt your pain that you had to refresh the page. Was it easier to you in the previous release?

@alvacouch and @engineSound - I just tried on beta, and setting a resource as public or private does not require a page refresh. It does require using the Manage Access window. We have consolidated all access/permission functionality on that one window so it is all in one place. There obviously may be a little bit of confusion for some users who were used to finding the public/private buttons in the middle of the page.

I really like the redesign!
However, I found it difficult to download resource content. I eventually figured it out (with help from Liza), but we might want to make this a bit more obvious since its a very common action.

As someone not as familiar with the product, I scrambled for about 30 seconds then the icon caught my eye. Somewhat agree, but it was intuitive enough...
On Feb 6, 2019, at 4:15 PM, Tony Castronova <notifications<EMAIL_ADDRESS>wrote:
I really like the redesign!
However, I found it difficult to download resource content. I eventually figured it out (with help from Liza), but we might want to make this a bit more obvious since its a very common action.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHubhttps://github.com/hydroshare/hydroshare/issues/3102#issuecomment-461190014, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ArS3ThN-AsEPGJjyOrVo6-JXfzYLqcb3ks5vK0XbgaJpZM4aW_Bx.

10-15 seconds more like it.
On Feb 6, 2019, at 4:19 PM, cuahsimarko <notifications<EMAIL_ADDRESS>wrote:
As someone not as familiar with the product, I scrambled for about 30 seconds then the icon caught my eye. Somewhat agree, but it was intuitive enough...
On Feb 6, 2019, at 4:15 PM, Tony Castronova <notifications@github.commailto:notifications<EMAIL_ADDRESS>wrote:
I really like the redesign!
However, I found it difficult to download resource content. I eventually figured it out (with help from Liza), but we might want to make this a bit more obvious since its a very common action.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHubhttps://github.com/hydroshare/hydroshare/issues/3102#issuecomment-461190014, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ArS3ThN-AsEPGJjyOrVo6-JXfzYLqcb3ks5vK0XbgaJpZM4aW_Bx.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHubhttps://github.com/hydroshare/hydroshare/issues/3102#issuecomment-461191716, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ArS3TpGOSomSBdlsBuiaDdecSfiguG68ks5vK0b1gaJpZM4aW_Bx.

This icon doesn't really scream "download" to me:

Yeah maybe text labels
On Feb 6, 2019, at 4:21 PM, Tony Castronova <notifications<EMAIL_ADDRESS>wrote:
This icon doesn't really scream "download" to me: [image] https://user-images.githubusercontent.com/4822372/52374430-3ef95a00-2a2b-11e9-8cb6-946218b1a3bf.png
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHubhttps://github.com/hydroshare/hydroshare/issues/3102#issuecomment-461192416, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ArS3ThNzm8AO7Gr3_Rn1NQH0fLBLr9Beks5vK0dqgaJpZM4aW_Bx.

I created a resource consisting of 2 python scripts and 4 raster tifs. The python scripts simply load the rasters and create a plot. https://beta.hydroshare.org/resource/3867d7662ea34974a8bb12faf5d84ed6/

Upload these data to HydroShare. Metadata from the rasters are extracted and their resource type is set to "Geographic Raster"

Download the content as a zipped bagit archive and notice that each raster is in its own directory, unlike when the data was uploaded.

Running the script produces an error because uploading the data to HydroShare has changed the paths to the rasters. This could cause problems with users, because they will not notice that their files have been moved into folders. Additionally, they won't find out that things are broken until someone else tries to user their data.

I tried to fix this by  "Removing Content Type" for each raster in HydroShare. This removes the content type association but keeps each raster file in separate directories.  There is currently no way to move a file into its parent directory, which is one way to fix this broken paths.
I'm not sure how to best solve this problem, but I'm worried that this could cause serious problems with modeling and jupyter-related resources.

@Castronova - moving files between directories can be done via cut and paste.
FYI - this is not an issue with the 1.19 release. This behavior (putting raster content in its own folder) was introduced with phase 2 of composite resource some time ago.

@cuahsimarko - the download buttons do have hover text.

I think the issue is that the automatic extraction of metadata that changes file paths without asking the user.

@engineSound @sblack-usu
I did the following:

create a new resource.
and then, without refreshing the page:
save an abstract.
save keywords.
dump a document into the resource.

And then the public button was greyed out and could not be pressed.
I haven't tried this in previous releases. I was actually testing dynamic discovery indexing, which works.

@Maurier - Not a deal killer, but there's some spacing issues on the edit coverage element. The set spatial coverage from content files button is too close to the longitude box, and there's too much vertical space between that and the temporal coverage element. I see that the start date and end date expand if I make the window wider, so maybe they need to stay below the map, but you could put end date below start date instead of on the same line and then move them up so we aren't taking up so much vertical space.

@horsburgh I have pending pull requests for this and some minor issues that we could consider including. Some of these were issues I found during testing of the beta deployment.
#3110 #3112 #3111 #3109 #3108 #3106
@sblack-usu Let me know what you think.

@Maurier - OK. I'm still just kicking tires a bit on the beta deployment while helping Liza with some documentation. Glad to know you've already caught this.

@engineSound @sblack-usu
I did the following:

create a new resource.
and then, without refreshing the page:
save an abstract.
save keywords.
Open sharing icon. Can't select public, asks that a document be uploaded.
Close sharing page.
Upload a document  (now requirements are met)
And then the public button was greyed out and could not be pressed. It was pressable after a refresh.

I haven't tried this in previous releases. I was actually testing dynamic discovery indexing, which works.

I will be addressing this today. I was able to reproduce it as described above.

If they're minor issues that you can live with for a week or two, I'd rather push these small issues until the next release.  We should really only consider hotfixes if they're fixing an issue that is a dealbreaker with the release at this point.

In that case we could include thse ones as a hotfixes: #3110 #3111

I agreed with @sblack-usu. These things can be marked as known issues when we notify users. As I am aware of, many software releases have this practice. @Lizabrazil please take a note on this when email to users. We can release a patch in a week or so.

@Maurier, Both of those have minor in the titles.  @horsburgh what do you think?  I prefer avoid hotfixes this late in the game if possible.

@alvacouch - I tested again and the UI is working as expected. I think we both forgot to add a title to the resource.
One thing I noticed though, the warning on top describing what's needed to make the resource public goes away as soon as one fills in any metadata. It should persist until all required metadata has been added.

@Maurier and @sblack-usu - the world is not ending today. So, unless people find bugs that are pretty bad, we should deploy this to production and then do the minor fixes after. Better to not risk breaking something that has already been tested by "fixing" something hastily.

@sblack-usu These two issues correspond to some of my pending PRs and were not finished in time for this release.

#2638 Edit to text on My Resources @Maurier
#2765 zip file/folder name suggestion and auto-select not working @Maurier

@Maurier - Thanks, I've removed those two tickets from the checklist

See issue #3127.  It is a regression.  If we go ahead with this deploy we need to fast track an unzipping fix.

@dtarb - I think you meant #3137 not #3127.

Correct #3137

Only thing I noticed which hasn't been reported is (cosmetic) #3140.  If we support IE11, then I have a number of bugs to add, but even then they don't hold up deployment in my opinion.

It seems resource specific metadata is not getting displayed properly (getting cutoff on the left side) in both view and edit modes for resource types like Time Series, Multidimensional, Geographic Feature, Geographic Raster. Here is an example of the problem:

@hydrocheck Does it work on edge browser?
I think we support IE11. Adding @Lizabrazil , do we have a data point that indicates the percentage of IE 11 users? This helps us scale the impact of the cosmetic issues.

Looks like in just the past week we have had 24 users using IE11. Overall IE is the 4th most common browser that our users use (looking back just this month).

I'm looking into an easy implementation that detects the type of browser being used and if unsupported, it displays a banner to the user that we may not support your current browser and to please upgrade.

@engineSound No, I currently do not test Edge.  Firefox, Chrome, and IE11 seem to give more bang for the buck.  The idea being that if it works all on all three, it probably works on Edge, but I wouldn't say the reverse is true - for Firefox, Chrome, and Edge (e.g. IE11 bugs are unlikely to surface using those three browsers).  Could of course add to the number of browsers used, but that leads to massive increases in testing time.
@Lizabrazil Keep me posted on the IE11 decision.  Showing a message does seem like a good approach, since I would suspect IE11 users probably have another browser installed.  IE11 is still supported by Microsoft and is the most recent (last) version of IE, FYI.  If you are looking at browser usage data anyway @Lizabrazil, I would be curious to know Safari usage.  I tend to avoid Safari testing, except for some exceptional cases.

Liza, where can i see the statistics for the browser use, is it google analytics?

Yes, Google Analytics

https://analytics.google.com/analytics/web/#/report-home/a74322358w116039831p121330771
Under Audience>Technology
I think this is public but let me know if anyone needs access granted.

@hydrocheck Looks like safari is second most commonly used.

A few different options here and i'm sure there are many more:
https://browser-update.org/
http://outdatedbrowser.com/en/how

@Lizabrazil looks like https://analytics.google.com/analytics/web/#/report-home/a74322358w116039831p121330771  is not public, could you add Dave, Martin, Tony, myself, any others?  Thanks.  Here is a screen cap:

I just checked and my account doesn't have permissions to give others access. I think @Castronova has admin rights?

Okay thanks.  @Castronova consider making @Lizabrazil an admin for future requests.  Thanks.


Add Black and Light theme

Created this theme for my Octopress blog and brought it with me when I switched to Hugo.

Hello @davidhampgonsalves,
thank you very much for sharing this theme with the Hugo community. Let's take the last steps before merging it:

please use the https protocol in the remote url. Earlier, users reported issues when cloning with ssh (due to firewall rules etc).
make sure, the screenshots in images have the required dimensions
which license are you using? The root folder contains the GPL license, the exampleSite folder the MIT license
please remove the empty strings in the tags and feature array. Otherwise, the theme site generates empty labels.

Regards,
Digitalcraftsman

Done, thanks for reviewing.

Now everything looks fine. Your theme should be listed soon on the theme site.
Have a nice day :smile:


[e2e]: go push main config-noldflags slsa3

Repo: https://github.com/slsa-framework/example-package/tree/main
Run: https://github.com/slsa-framework/example-package/actions/runs/8548697144
Workflow file: https://github.com/slsa-framework/example-package/tree/main/.github/workflows/e2e.go.push.main.config-noldflags.slsa3.yml
Workflow runs: https://github.com/slsa-framework/example-package/actions/workflows/e2e.go.push.main.config-noldflags.slsa3.yml
Trigger: push
Branch: main
Date: Thu Apr  4 03:10:45 UTC 2024

Repo: https://github.com/slsa-framework/example-package/tree/main
Run: https://github.com/slsa-framework/example-package/actions/runs/8564410975
Workflow file: https://github.com/slsa-framework/example-package/tree/main/.github/workflows/e2e.go.push.main.config-noldflags.slsa3.yml
Workflow runs: https://github.com/slsa-framework/example-package/actions/workflows/e2e.go.push.main.config-noldflags.slsa3.yml
Trigger: push
Branch: main
Date: Fri Apr  5 03:10:06 UTC 2024
Tests are passing now. Closing this issue.


Coverage Test Showing 0% on DBT v1.0.0

dbt-coverage showing inaccurate result since always showing 0% test coverage.
Total                                                  0/11387   0.0%

Hey @nurtantioquidar, thanks for reporting the issue. I can reproduce it on the sample jaffle_shop project.


Improve CI inspired by oclif

https://oclif.io/

Mainly the idea of testing for various node versions.


Refactor wrong int types to string types & update tests

What to do
Refactor wrong int types into string types in the Company struct.
Background
The current hubspot API returns the company response with different field types than what is described in the company struct
Acceptance criteria

@RomanSter
Thank you for putting up PR.
This issue has already been reported and a fix has been merged. (https://github.com/belong-inc/go-hubspot/pull/29)
We apologize for the inconvenience, but please wait for the next version, which will be released soon, or use the current main branch.


Add if statement to ensure there is coin in player inventory

Description
-Declared variable playerGold and set to zero.
-Checked if there was a coin index in player inventory.
-If true -> continue normal function by setting playerGold to that quantity.
-else -> playerGold remains at zero and chat returns insufficient funds warning.
Related Issue
https://github.com/delaford/game/issues/77
Motivation and Context
Allows the player to understand why nothing is happening when they are trying to purchase an item.
How Has This Been Tested?
-I attempted to purchase items from both vendors with no gold in my inventory. This resulted in desired behavior.
-I ensured you could still purchase items when you DO have gold in your inventory (initially this didn't work because I set playerGold as a const, changed to let for expected behavior).
-No changes to other code that I am aware of.
Types of change

[X] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)

Wow. Sorry about all the reverts. Had a git meltdown. lol

If you could fix the conflicts, that'd be great. I cannot seem to do it via the GitHub UI. Weird. Thank you so much!

Im not able to see any conflicts.

Oh I see

Got it.

Thank you! You rock! :-D


Bug: Stubbed Teleport does not update reactively

Describe the bug

Ref: https://github.com/vuejs/test-utils/issues/798#issuecomment-1513197973
To Reproduce

Here: https://github.com/vuejs/test-utils/issues/798#issuecomment-1513197973
Expected behavior

Should update count to 1.
Related information:

Additional context

@lmiller1990, I've successfully reproduced the behavior from my reproduction repo in the teleport automated test and pushed it to a forked branch (so you can see).
After some digging, I suspect it has to do with the slots variable passed into the setup() function not being reactive. The Vue docs note that attrs and slots are not reactive (which I just learned). I also suspect Evan's comment in this thread might be related to the test-utils situation; the stubComponentsTransformer uses slots to make the stub.
I need to come back to this later. I thought I'd share my findings in case someone else or you get a clever idea.

Having issues myself as well, so here to keep an eye on the progress resolving this issue

Dropping by here again - any updates on this?


Add local and global hooks for check current activity

Very often add active class not enough. For example for Bootstrap navigation panel, you should add class to a parent element. Why listen to history not enough too? Your route can contain params and you can't easily compare current location path and route path.
Extend RouterLink not possible because your route path can accessible from many URLs.
I know current solution a little hacky but maybe right now it's better than nothing.
I hope this project still active and will be the best solution for Svelte.

For example, https://github.com/TehShrike/svelte-state-renderer exist very useful function:
"asr.stateIsActive" it solves most of the problems with navigations.


MINOR: Remove deprecation and exception throw in ProcessorRecordContext#hashcode

Something I noticed while working on a new feature -- this class has deprecated its hashcode and actually goes so far as to throw an exception if/when it's invoked. The deprecation note claims this is because the class is mutable, but I don't actually see this happening anywhere in the code. The reference to this object is modified during processing (by the ProcessorContext), but the object itself has no setters and all fields are private.
Given the deprecation was years ago, I'm guessing we simply changed from mutating the actual record context object to mutating the reference stored by the ProcessorContext sometime in the past few years, and forgot to remove this deprecation/exception

@ableegoldman I had a quick look at the code and theoretically ProcessorRecordContext is mutable because headers() returns a reference to the object of Headers stored internally. With recordContext.headers().remove("myHeader") the headers in an instance of ProcessorRecordContext can be modified.
Said that, I have no idea whether this was the reason for the deprecation.

What Bruno says. Git history if you friend :)
https://github.com/apache/kafka/pull/6602/files#r278810522
I think we should keep the code as-is and close this PR w/o merging (or add some more detailed comment to explain why the code is this way better).

Ah, thanks for the reality check guys -- I always forget about Headers being mutable 😞
Glad John deprecated the method way back when since the deprecation warning was how I first noticed this (and I was using it in a collection, albeit indirectly). That said, clearly the javadocs could do with a bit more elaboration on why it's mutable.  Why is it mutable?? Seems very silly to me
Though I'm sure there is (or at least was) a reason...
Anyways, pushed the update with just a docs change instead. Give it a +1 when you have a minute

Well 1 of the 4 JDK builds was aborted for some unknown but the other 3 builds completed with only unrelated test failures.
Given this is literally only touching on javadocs and error message strings, I'm going to make a judgement call and say it's probably safe to merge and definitely not the cause of the one build being aborted early
Thanks for the extra pair of eyes to unravel this "mystery" for me lol. Should always check the original PR for comments when something doesn't make sense...my bad for being lazy here in the initial PR.


Enums and interfaces do not have definitions in quick info/tooltips

The issue might be related to this one, but mine is not about version 3.0, and is not solely about imports.
Search Terms

enum, description, definition, pop-up, tooltip, vs code, interface, suggestion
Suggestion

Hovering over enums and interfaces, should show their definition, i.e. I have this enum (or an interface):
enum enumName {
    ONE = 1;
    TWO = 2;
    THREE = 3;
}

If I hover over this enum, wherever I use it (whether it is imported to another file or used locally where it is declared), I would like to see what this enum is all about (essentially what are the properties).
This is what I see right now when I hover over enums or interfaces:

As a workaround, I currently need to add this type of JSDoc comments right above the enum declaration.
/** Props:
*    @param ONE 1;
*    @param TWO 2;
*    @param THREE 3;
*/

Which yields to:

Use Cases

This feature would save time & effort.
The shortcoming of the current approach is that either need to add ${2+numberOfEnumProperties} lines of comments or go to the file, where enum is declared, locate the enum there and then familiarize myself with its properties.
Examples

Checklist
I am not that experienced to be able to answer the questions below.

[ ] This wouldn't be a breaking change in existing TypeScript / JavaScript code
[ ] This wouldn't change the runtime behavior of existing JavaScript code
[ ] This could be implemented without emitting different JS based on the types of the expressions
[ ] This isn't a runtime feature (e.g. new expression-level syntax)

Also, if I have interface, which extends another interface:
interface One {
    one: number;
}

interface Two extends One {
    two: string;
}

And I use interface Two somewhere and hover over it, I will get the same dull description as I got on the second screenshot in the initial post with interfaceName.

I agree. hovering over a type name to get a pop-up with the same text is rather useless. we can do better.

Just adding on to this. I find it really annoying that the type information for interfaces and enums are basically useless.
It also affects all the IDEs when they display the definitions. See this one for JetBrains IDE's: https://youtrack.jetbrains.com/oauth?state=%2Fissue%2FWEB-44531

Could someone point out where in the code base these definitions are created, and especially where the Types one are vs the Interface.
Then maybe someone from the community can take a look at actioning this.

My tactic for figuring out stuff like this is to enable TSServer logging, perform the action you're interested in, then see what requests were made:
    {"seq":270,"type":"request","command":"quickinfo","arguments":{"file":"/Users/ortatherox/dev/typescript/new-website/packages/sandbox/src/typeAcquisition.ts","line":15,"offset":15}}

So this request is a quickinfo - a search I the codebase finds getQuickInfoAtPosition - which is where the code starts - my bet, the code you're looking for is in SymbolDisplay.getSymbolDisplayPartsDocumentationAndSymbolKind`.

Any updates on this?


Dont merge! first shot at exporting fetchTranscripts function (doesn't work yet)

I added a fix to this branch. steps
a) removed unneeded exports from package.json
b) removed async component (not allowed in non react-server-components) and replaced with a useEffect
c) displays a slice of the results from fetchTranscripts in the component


NOJIRA: Update resource-server - rel-4-3-patches

Improves logging and adds font awesome 4.7.

Coverage decreased (-0.004%) to 22.869% when pulling 360bb17679412c84a7a193cd718adea0de9daae3 on ChristianMurphy:patch-2 into d529ae51435c580bfa84d5325f1764f09554a951 on Jasig:rel-4-3-patches.


Update and sync some global styles

What
While working on updating the backer dashboard, I felt it necessary to separately update the entire app to match the new design in terms of navigation bar and background colors. As we keep going forward with new designs, it will be easier to start from a place where colors are in sync.
The main changes here are a white background for navigation bars and a white background color for screens that are not table view or collection view controllers. The table/collection view controllers have been updated to have a white foreground color and a darker grey background color. Navigation titles are now black.
I'd like to get the navigation bar border image to be the same across the app (grey_500), but for the sake of time, am keeping the default shadow for now.
Note: Still have to run past @maggieKSR but wanted to get the code and screenshots out for review.

i've just updated the borderButtonStyle with a darker border as that was the main problematic change. when circle passes, will merge!


backward/forward compatibility functest

Implement backward and forward compabile functional tests. We want to test that kubevirt-template-validator works nicely with kubevirts whose version is older and newer than the version of client-go built-in in the server.
To do so, we intentionally deploy a version of kubevirt older than the one we have client-go for.
Then we update to the same version, and we run the tests again
Then we update to the newer version, and we run the tests again.
The alternative would be to build three different minishift setups with the aformentioned kubevirt versions. That would be cleaner, but we will have a very high risk to have false negative tests because of github API throttling - this actually happened testing an earlier PR.

blocked on https://github.com/kubevirt/kubevirt/issues/2533

https://github.com/kubevirt/kubevirt/issues/2533 is not really an issue and we have a good (and reasonnably clean) workaround.

/cc @ksimon1 @msivak

Thanks @ksimon1


Naming conflict with shoulda matchers

have_and_belong_to_many(:association_name) has naming conflict with should amatchers. All other matchers have aliases - which is great! I can use both shoulda matchers and mongoid-rspec matchers.
Here is missing alias: https://github.com/mongoid-rspec/mongoid-rspec/blob/master/lib/matchers/associations.rb#L321-L323

My temporary solution: Mongoid::Matchers::Associations.send(:alias_method, :related_and_belong_to_many, :have_and_belong_to_many)


All implicitly derived inputs to subclassed Models must be tf.Tensors (found SparseTensor)

System information

Have I written custom code (as opposed to using a stock example script provided in TensorFlow): no
OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Mac OS X 10.14
Mobile device (e.g. iPhone 8, Pixel 2, Samsung Galaxy) if the issue happens on mobile device: no
TensorFlow installed from (source or binary): binary
TensorFlow version (use command below): ('v1.12.1-2821-gc5b8e15064', '2.0.0-dev20190527')
Python version: 2.7
Bazel version (if compiling from source): no
GCC/Compiler version (if compiling from source): no
CUDA/cuDNN version: no
GPU model and memory: no

Describe the current behavior
Exception raises when trying to feed Sparse/Ragged tensors to keras model.fit().
But that is an ordinary pipeline for Estimators.
Besides, method mentioned in error (self._add_inputs) does not exist in TF source code.
Describe the expected behavior
Sparse and Ragged tensors should be acceptable input for keras models.
Code to reproduce the issue
import numpy as np
import tensorflow as tf

FEATURES_DIM = 5
_randoms = np.random.random((10, 32, FEATURES_DIM))

# # This is my wish: ragged input to sequence feature column
# features = tf.RaggedTensor.from_tensor(_randoms, ragged_rank=1)
# labels = tf.reduce_sum(tf.expand_dims(features, axis=-2), axis=-1)

# This is what should work right now
_indexes = tf.where(tf.not_equal(_randoms, 0.0))
_values = tf.gather_nd(_randoms, _indexes)
features = tf.SparseTensor(_indexes, _values, _randoms.shape)
labels = tf.sparse.reduce_sum(features, axis=-1, keepdims=True)

dataset = tf.data.Dataset \
    .from_tensor_slices(({'features': features}, labels)) \
    .batch(32)

class MyModel(tf.keras.Model):
    def __init__(self):
        super(MyModel, self).__init__()
        self.features = tf.keras.experimental.SequenceFeatures([
            tf.feature_column.sequence_numeric_column('features', shape=(FEATURES_DIM,))
        ])
        self.dense_1 = tf.keras.layers.TimeDistributed(tf.keras.layers.Dense(32, activation='relu'))
        self.dense_2 = tf.keras.layers.TimeDistributed(tf.keras.layers.Dense(1))

    def call(self, inputs):
        outputs = self.features(inputs)
        outputs = self.dense_1(outputs)
        outputs = self.dense_2(outputs)

        return outputs

    def compute_output_shape(self, input_shape):
        shape = tf.TensorShape(input_shape).as_list()
        shape[-1] = 1

        return tf.TensorShape(shape)

model = MyModel()
model.compile(optimizer='Adam', loss='mse')
model.fit_generator(dataset, epochs=5)

Other info / logs
Epoch 1/5
---------------------------------------------------------------------------
ValueError                                Traceback (most recent call last)
<ipython-input-37-1cf666c5a52e> in <module>()
     40 model = MyModel()
     41 model.compile(optimizer='Adam', loss='mse')
---> 42 model.fit_generator(dataset, epochs=5)

/usr/local/lib/python2.7/site-packages/tensorflow/python/keras/engine/training.pyc in fit_generator(self, generator, steps_per_epoch, epochs, verbose, callbacks, validation_data, validation_steps, validation_freq, class_weight, max_queue_size, workers, use_multiprocessing, shuffle, initial_epoch)
   1175         shuffle=shuffle,
   1176         initial_epoch=initial_epoch,
-> 1177         steps_name='steps_per_epoch')
   1178
   1179   def evaluate_generator(self,

/usr/local/lib/python2.7/site-packages/tensorflow/python/keras/engine/training_generator.pyc in model_iteration(model, data, steps_per_epoch, epochs, verbose, callbacks, validation_data, validation_steps, validation_freq, class_weight, max_queue_size, workers, use_multiprocessing, shuffle, initial_epoch, mode, batch_size, steps_name, **kwargs)
    262
    263       is_deferred = not model._is_compiled
--> 264       batch_outs = batch_function(*batch_data)
    265       if not isinstance(batch_outs, list):
    266         batch_outs = [batch_outs]

/usr/local/lib/python2.7/site-packages/tensorflow/python/keras/engine/training.pyc in train_on_batch(self, x, y, sample_weight, class_weight, reset_metrics)
    895     x, y, sample_weights = self._standardize_user_data(
    896         x, y, sample_weight=sample_weight, class_weight=class_weight,
--> 897         extract_tensors_from_dataset=True)
    898
    899     # If `self._distribution_strategy` is True, then we are in a replica context

/usr/local/lib/python2.7/site-packages/tensorflow/python/keras/engine/training.pyc in _standardize_user_data(self, x, y, sample_weight, class_weight, batch_size, check_steps, steps_name, steps, validation_split, shuffle, extract_tensors_from_dataset)
   2341               'tf.Tensors (found %s). To add non-tf.Tensor inputs, please call '
   2342               'self._add_inputs(tf.keras.Input/SparseInput/RaggedInput (etc)) '
-> 2343               'in your subclassed Model object.' % (input_tensor,))
   2344
   2345       # Build the model using the retrieved inputs (value or symbolic).

ValueError: All implicitly derived inputs to subclassed Models must be tf.Tensors (found SparseTensor(indices=tf.Tensor(
[[ 0  0  0]
 [ 0  0  1]
 [ 0  0  2]
 ...
 [ 9 31  2]
 [ 9 31  3]
 [ 9 31  4]], shape=(1600, 3), dtype=int64), values=tf.Tensor([0.76254113 0.44757111 0.9459519  ... 0.64881651 0.2802026  0.79660244], shape=(1600,), dtype=float64), dense_shape=tf.Tensor([32 32  5], shape=(3,), dtype=int64))). To add non-tf.Tensor inputs, please call self._add_inputs(tf.keras.Input/SparseInput/RaggedInput (etc)) in your subclassed Model object.

@shkarupa-alex It looks code snippet is incomplete. Can you please provide complete code to reproduce the reported issue. Thanks!

@shkarupa-alex It looks code snippet is incomplete. Can you please provide complete code to reproduce the reported issue. Thanks!

You're right, mistake found.
Code in first message updated.

@shkarupa-alex Thanks for updating. Now, I am able to reproduce the issue. Thanks!

Hi @shkarupa-alex,
This error is occurring because we can't yet infer the shape of CompositeTensor inputs for subclassed Models. To get around it, please create a tf.keras.Input(..., sparse=True) in your init, and call self._add_inputs([my_input]). This will allow us to properly shape-check the input object.

@markomernick
shkarupa-alex already said "Besides, method mentioned in error (self._add_inputs) does not exist in TF source code".

@markomernick
shkarupa-alex already said "Besides, method mentioned in error (self._add_inputs) does not exist in TF source code".

Forget about this method.
Using tf.keras.Input(..., sparse=True) as input placeholder do the trick.

I have a similar problem where one of the features is a tf.sparse.SparseTensor. As the it is said above, self._add_inputs does not exist. In the snippet
class M(tf.keras.Model):
  def __init__(self):
    super(M, self).__init__()
    ...
    self._features = tf.keras.layers.DenseFeatures([...])

  def call(self, inputs):
    # inputs is a dict of sparse tensors.
    layer = self._features(inputs)
    ...
     return prediction

What is the best way to make the code work considering that self._add_inputs does not exist?

Thanks for the issue. This code now works in the latest nightly (note that SequenceFeatures returns a list of features):
import numpy as np
import tensorflow as tf

FEATURES_DIM = 5
_randoms = np.random.random((10, 32, FEATURES_DIM))

# # This is my wish: ragged input to sequence feature column
# features = tf.RaggedTensor.from_tensor(_randoms, ragged_rank=1)
# labels = tf.reduce_sum(tf.expand_dims(features, axis=-2), axis=-1)

# This is what should work right now
_indexes = tf.where(tf.not_equal(_randoms, 0.0))
_values = tf.gather_nd(_randoms, _indexes)
features = tf.SparseTensor(_indexes, _values, _randoms.shape)
labels = tf.sparse.reduce_sum(features, axis=-1, keepdims=True)

dataset = tf.data.Dataset \
    .from_tensor_slices(({'features': features}, labels)) \
    .batch(32)

class MyModel(tf.keras.Model):
    def __init__(self):
        super(MyModel, self).__init__()
        self.features = tf.keras.experimental.SequenceFeatures([
            tf.feature_column.sequence_numeric_column('features', shape=(FEATURES_DIM,))
        ])
        self.dense_1 = tf.keras.layers.TimeDistributed(tf.keras.layers.Dense(32, activation='relu'))
        self.dense_2 = tf.keras.layers.TimeDistributed(tf.keras.layers.Dense(1))

    def call(self, inputs):
        outputs = self.features(inputs)
        outputs = self.dense_1(outputs[0])
        outputs = self.dense_2(outputs)

        return outputs

model = MyModel()
model.compile(optimizer='Adam', loss='mse')
model.fit_generator(dataset, epochs=5)


Version upgrade is failing dfareporting APIs

Environment details

google-api-python-client version: 2.91.0

Steps to reproduce

Create a virtual environment with version 2.91.0
Run a dfareporting API get() call with an entity id specified in integer --> 'int' object is not iterable error shows up
Change the version back to 2.90.0
Re-Run a dfareporting API get() call with an entity id specified in integer --> script will run successfully

Code example
import google.auth
from google.auth import impersonated_credentials
from google.oauth2 import service_account
from googleapiclient import discovery

default_credentials, project_id = google.auth.default()
credentials = impersonated_credentials.Credentials(
    source_credentials=default_credentials,
    target_principal="{service_account_email}",
    target_scopes=["https://www.googleapis.com/auth/dfatrafficking"]
)
dcm = discovery.build("dfareporting", "v4", credentials=credentials)
response = dcm.creatives().get(profileId="{profile_id}",id=000000).execute()

Stack trace
File "/usr/local/lib/python3.10/dist-packages/googleapiclient/discovery.py", line 1071, in method
    for pvalue in pvalues:
TypeError: 'int' object is not iterable

I encountered similar issue as well. I solved this error by changing the data type from integer to string.
Before
response = dcm.creatives().get(profileId="{profile_id}",id=000000).execute()
After
response = dcm.creatives().get(profileId="{profile_id}",id="000000").execute()


undoActivate from HasActiveFlag not working

$this->save() shouldn't be after $this->setAttribute('is_active', false);?
https://github.com/cybercog/laravel-eloquent-flag/blob/504bbd7e16d33c0eed12441cec51f3e92d8a50a1/src/Traits/Classic/HasActiveFlagHelpers.php#L41-L47

v5.1.1 has been released.
Now I see that tests are written incorrectly. We are not taking fresh records before assertions.


Effect of Sinatra's show_exceptions on catch-all exception handling

I'm trying to integrate a Padrino 0.12.4 app with raygun.io, an exception handling SaaS. I've gotten it to work in a development environment, but not production.
The setup in app.rb:
class App < Padrino::Application
  use ActiveRecord::ConnectionAdapters::ConnectionManagement
  register Padrino::Rendering
  register Padrino::Mailer
  register Padrino::Helpers
  # ... etcetera

  require 'raygun4ruby'
  Raygun.setup do |config|
    config.api_key = "api key"
    config.enable_reporting = true
  end
  use Raygun::Middleware::RackExceptionInterceptor
end

The exception to be raised (on hitting /):
get :index do
  # .. snip setting some vars
  raise "lala"
  # .. snip some more code
  render :home, layout: "homepage"
end

And this is why I think Sinatra's show_exceptions setting is causing the problem - the exception not being passed to Raygun's Rack middleware. The only reason I'm asking here instead of Sinatra's repo is because I'm not using pure Sinatra, so I presume I will be bounced back here to start over :).
# WORKING example in development environment, no modification of raise_errors or show_exceptions from their defaults, Padrino 0.12.4
puts settings.raise_errors  # false
puts settings.show_exceptions  # true

# WORKING example in development environment, Padrino 0.12.4
set :raise_errors, true
puts settings.raise_errors  # true
puts settings.show_exceptions  # true

# BROKEN example in development environment - exception not passed to middleware, Padrino 0.12.4
set :show_exceptions, false
puts settings.raise_errors  # false
puts settings.show_exceptions  # false

# BROKEN example in development environment - exception not passed to middleware, Padrino 0.12.4
set :raise_errors, true
set :show_exceptions, false
puts settings.raise_errors  # true
puts settings.show_exceptions  # false

I did also read #1666 but putting use Raygun::Middleware::RackExceptionInterceptor and the setup code first in config.ru (without wrapping it in a padrino application class) doesn't do the trick - the exception is still not passed to the raygun middelware.
Here is an example of the raygun tracking not working in RACK_ENV=production (because show_exceptions is set to false, I surmise): http://pastebin.com/q0gB0rmg
I think this really shouldn't be this difficult, the problem is probably that I had 0 experience with Rack middleware until I met with this problem. Any advice on getting exceptions handled by the middleware in production is greatly appreciated!

Closing as looks solved.


Ported 3_rosserial_rviz to 3_microros_rviz

Port all scripts to support ROS2 and micro-ROS
Update CMakeLists and Kconfig.projbuild for the same
Update README.md for new instructions
Include LICENSE

This PR has merge conflicts, will update the branch from my side will draft a PR


merge package from arlac77/npm-package-template

package.json

chore(package<EMAIL_ADDRESS>chore(scripts): cover@#overwrite c8 --temp-directory build/coverage ava && c8 report -r lcov --temp-directory build/coverage
chore(package): add nyc from template
docs(package): remove keyword null
chore(package): set $.ava.require='esm' as in template
chore(package): set $.ava.files='tests/-test.js,tests/-test.mjs' as in template
chore(package): set $.ava.extensions='js,mjs' as in template

Codecov Report

Merging #615 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #615   +/-   ##
=======================================
  Coverage   92.63%   92.63%
=======================================
  Files           7        7
  Lines        1073     1073
=======================================
  Hits          994      994
  Misses         79       79

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e4be28e...ae6d2ee. Read the comment docs.

Coverage remained the same at 89.502% when pulling ae6d2eebc7ce946fef254ae712765c7ed372dc01 on template-sync-1 into e4be28e34ebdf69f575eb79538ab75a72e64f494 on master.

:tada: This PR is included in version 4.17.2 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


--no-configured-files should not update current_version

bump-my-version version: 0.5.1.dev6 from https://github.com/callowayproject/bump-my-version/pull/23
Python version: 3.11.4
Operating System: macOS 13.4

Description
When invoking the CLI with the --no-configured-files, I always ends up with the current_version tracked by bump-my-version being updated in its configuration file.
Instead, I expect the current_version to be left as-is, as the description of --no-configured-files seems to imply: Only replace the version in files specified on the command line.
What I Did
Here I try to search and replace strings in the ./.github/workflows/autofix.yaml file:
$ bump-my-version bump --verbose --no-configured-files --search "/workflows/main/" --replace "/workflows/v{current_version}/" patch ./.github/workflows/autofix.yaml
Starting BumpVersion 0.5.1.dev6
Reading config file pyproject.toml:
Specified version (2.17.5) does not match last tagged version (2.17.4)
Parsing version '2.17.5' using regexp '(?P<major>\d+)\.(?P<minor>\d+)\.(?P<patch>\d+)'
Parsed the following values: major=2, minor=17, patch=5
Attempting to increment part 'patch'
Values are now: major=2, minor=17, patch=6
New version will be '2.17.6'
Asserting files ./.github/workflows/autofix.yaml contain the version string...
Found '/workflows/main/' in ./.github/workflows/autofix.yaml at line 54:           https://raw.githubusercontent.com/kdeldycke/workflows/main/requirements.txt
Changing file ./.github/workflows/autofix.yaml:
*** before ./.github/workflows/autofix.yaml
--- after ./.github/workflows/autofix.yaml
***************
*** 52,65 ****
        - name: Install Poetry
          run: >
            python -m pip install --requirement
!           https://raw.githubusercontent.com/kdeldycke/workflows/main/requirements.txt
        - name: Project metadata
          id: project-metadata
          env:
            GITHUB_CONTEXT: ${{ toJSON(github) }}
          run: >
            python -c "$(curl -fsSL
!           https://raw.githubusercontent.com/kdeldycke/workflows/main/.github/metadata.py)"

    format-python:
      name: Format Python
--- 52,65 ----
        - name: Install Poetry
          run: >
            python -m pip install --requirement
!           https://raw.githubusercontent.com/kdeldycke/workflows/v2.17.5/requirements.txt
        - name: Project metadata
          id: project-metadata
          env:
            GITHUB_CONTEXT: ${{ toJSON(github) }}
          run: >
            python -c "$(curl -fsSL
!           https://raw.githubusercontent.com/kdeldycke/workflows/v2.17.5/.github/metadata.py)"

    format-python:
      name: Format Python
***************
*** 78,84 ****
        - name: Install ruff, black, blacken-docs, autopep8 and docformatter
          run: >
            python -m pip install --requirement
!           https://raw.githubusercontent.com/kdeldycke/workflows/main/requirements.txt
        - name: Run Ruff
          # --select=ALL - Autofix everything.
          #   Includes rules in the nursery, a collection of newer lints that are still under development.
--- 78,84 ----
        - name: Install ruff, black, blacken-docs, autopep8 and docformatter
          run: >
            python -m pip install --requirement
!           https://raw.githubusercontent.com/kdeldycke/workflows/v2.17.5/requirements.txt
        - name: Run Ruff
          # --select=ALL - Autofix everything.
          #   Includes rules in the nursery, a collection of newer lints that are still under development.
***************
*** 157,163 ****
        - name: Install mdformat
          run: >
            python -m pip install --requirement
!           https://raw.githubusercontent.com/kdeldycke/workflows/main/requirements.txt
        - name: Install shfmt
          run: |
            sudo apt install --yes shfmt
--- 157,163 ----
        - name: Install mdformat
          run: >
            python -m pip install --requirement
!           https://raw.githubusercontent.com/kdeldycke/workflows/v2.17.5/requirements.txt
        - name: Install shfmt
          run: |
            sudo apt install --yes shfmt
Writing to config file pyproject.toml:
*** before pyproject.toml
--- after pyproject.toml
***************
*** 1,5 ****
  [tool.bumpversion]
! current_version = "2.17.5"
  allow_dirty = true

  [[tool.bumpversion.files]]
--- 1,5 ----
  [tool.bumpversion]
! current_version = "2.17.6"
  allow_dirty = true

  [[tool.bumpversion.files]]
Would not commit
Would not tag since we are not committing

This perfectly does the job I'm expecting it to do. 💪
With one exception: I did not expected the current_version in my pyproject.toml file to be updated.
I have to admit this might be confusing, as I actually provided the patch part to the command line. Maybe that was because I am trying to use bump-my-version as a kind of search & replace tool, but augmented with its version management? Thinking of it maybe what I'm trying to so is the equivalent of the bump subcommand, without the effective increment of the version internally tracked by bump-my-version.
So all in all, how should we qualify this use-case?

as a new option to bump subcommand (like --no-increment)?
as a new replace subcommand (i.e. same as bump without the automatic increment)?
as a change in behavior for the --no-configured-files option?

Now thinking of it, maybe this will simply be solved while addressing https://github.com/callowayproject/bump-my-version/issues/19 , or at least be made more clear and explicit by the decoupling of version increment and search & replace.
In the current state of things #23 is not enough to address this use case. I'll revisit this issue at the first hint of progress on #19.

Revisiting this issue with 0.7.0, which has the exact same behaviour as reported initially.
But for my particular use case, the new replace subcommand while solve this issue for me once #34 is addressed.

Version 0.7.1 was just released and fixes #34
Let me know if your issue is fixed and we can close this or more is required.

For the record, the new and clean form of invokation to cover my use case is, since 0.7.1:
$ bump-my-version replace --verbose --no-configured-files --search "/workflows/main/" --replace "/workflows/v{current_version}/" ./.github/workflows/autofix.yaml


[CONTROLLER/CLOUD] fixes logging panic

This PR is for:

Server

Fixes logging panic
Steps to reproduce the bug
Changes to fix the bug
Affected branches

main

Checklist

[ ] Added unit test to verify the fix.
[ ] Verified eBPF program runs successfully on linux 4.14.x.
[ ] Verified eBPF program runs successfully on linux 4.19.x.
[ ] Verified eBPF program runs successfully on linux 5.2.x.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.zhengya seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


3.0.100 - preview5 OAuth functions not found

While attempting a Twitter login to via the native Twitter package [Microsoft.AspNetCore.Authentication.Twitter" Version="2.2.0"]
I received the following error upon successful callback:

MissingMethodException: Method not found: 'Void Microsoft.AspNetCore.Authentication.OAuth.Claims.ClaimAction.Run(Newtonsoft.Json.Linq.JObject, System.Security.Claims.ClaimsIdentity, System.String)'.

Twitter login was configured using the following snippet as taken from the guide here

services.AddAuthentication().AddTwitter(options =>                 {                     options.ConsumerKey = Configuration["Twitter:API_KEY"];                     options.ConsumerSecret = Configuration["Twitter:APP_SECRET"];                 });

Also when using the package [AspNet.Security.OAuth.Instagram" Version="2.0.1"] I received the folliwing error:

MissingMethodException: Method not found: 'Void Microsoft.AspNetCore.Authentication.OAuth.OAuthCreatingTicketContext..ctor(System.Security.Claims.ClaimsPrincipal, Microsoft.AspNetCore.Authentication.AuthenticationProperties, Microsoft.AspNetCore.Http.HttpContext, Microsoft.AspNetCore.Authentication.AuthenticationScheme, Microsoft.AspNetCore.Authentication.OAuth.OAuthOptions, System.Net.Http.HttpClient, Microsoft.AspNetCore.Authentication.OAuth.OAuthTokenResponse, Newtonsoft.Json.Linq.JObject)'.

Instagram Configuration:
.AddInstagram(options =>                 {                     options.ClientId = Configuration["Instagram:CLIENT_ID"];                     options.ClientSecret = Configuration["Instagram:APP_SECRET"];                      });
Both configurations correctly load the external login page as well as respond to the appropriate callback. The issue seems to be with handling the callback request.

This was my fault. My nuget wasn't set to allow previews and so I didn't get the latest twitter and OAuth packages.

how to set the nuget to allow previews? Can you teach me?

Installing and updating pre-release packages
By default, NuGet does not include pre-release versions when working with packages, but you can change this behavior as follows:
Package Manager UI in Visual Studio: In the Manage NuGet Packages UI, check the Include prerelease box:
The Include prerelease checkbox in Visual Studio
Setting or clearing this box will refresh the Package Manager UI and the list of available versions you can install.
Package Manager Console: Use the -IncludePrerelease switch with the Find-Package, Get-Package, Install-Package, Sync-Package, and Update-Package commands. Refer to the PowerShell Reference.
NuGet CLI: Use the -prerelease switch with the install, update, delete, and mirror commands. Refer to the NuGet CLI reference
Reference: https://docs.microsoft.com/en-us/nuget/create-packages/prerelease-packages

how to set the nuget to allow previews? Can you teach me?
Here is the error info
MissingMethodException: Method not found: 'Void Microsoft.AspNetCore.Authentication.OAuth.Claims.ClaimAction.Run(Newtonsoft.Json.Linq.JObject, System.Security.Claims.ClaimsIdentity, System.String)'

Installing and updating pre-release packages
By default, NuGet does not include pre-release versions when working with packages, but you can change this behavior as follows:
Package Manager UI in Visual Studio: In the Manage NuGet Packages UI, check the Include prerelease box:
The Include prerelease checkbox in Visual Studio
Setting or clearing this box will refresh the Package Manager UI and the list of available versions you can install.
Package Manager Console: Use the -IncludePrerelease switch with the Find-Package, Get-Package, Install-Package, Sync-Package, and Update-Package commands. Refer to the PowerShell Reference.
NuGet CLI: Use the -prerelease switch with the install, update, delete, and mirror commands. Refer to the NuGet CLI reference
Reference: https://docs.microsoft.com/en-us/nuget/create-packages/prerelease-packages


selftest fails for FreeBSD

$uname -a:
FreeBSD cr81 9.2-STABLE FreeBSD 9.2-STABLE #0

phantomjs --version
1.9.2

casperjs --version
1.1.0-beta3

casperjs selftest
FAIL 985 tests executed in 30.636s, 982 passed, 3 failed, 0 dubious, 5 skipped.
Details for the 3 failed tests:

In /root/casperjs/tests/suites/casper/formfill.js:134
multiple forms
assertUrlMatch: Casper.fill() handles multiple forms
In /root/casperjs/tests/suites/casper/formfill.js:157
field array
assertUrlMatch: Casper.fill() handles array syntax field names
In /root/casperjs/tests/suites/casper/navigation.js:38
Form Submittal updates the response
assertUrlMatch: URL matches form action

Please re-check against current master and re-open if you still encounter the issue.


Limit Gox parallel to 4

So it looks like Gox tried to get the number of CPU and uses that to set its parallel values.  Turns out they likely have a bug running in docker as its setting it to 35 which I am guessing is maybe the host machine CPU.  Limit it to 4 should reduce the amount of CPU and Memory it eats up.

The final commit needs to to have [semver: <major || minor || patch>] <rest of commit msg> otherwise the push to prod will fail.

The final commit needs to to have [semver: <major || minor || patch>] <rest of commit msg> otherwise the push to prod will fail.

Thanks for that reminder, any chance the team has consider adding a github action or something to verify this during the PR phase?  I know I got burned by this last time I touched golang-orb


Remove unnecessary fields from progress events for performance

This change removes the category from progress and progress
complete events. They are never used in logging because the
category from the start event is used for generated log messages.
Similarly, the timestamp is removed from progress events as it's
never used.
Finally, the description for progress complete events is never
used.
All of these reduce the serialization burden of a now much-larger
number of progress events, resulting in improved performance.
Context
This is intended to improve results for the "abi change on largeJavaMultiProject" performance scenario
CI Build
Contributor Checklist

[x] Provide integration tests (under <subproject>/src/integTest) to verify changes from a user perspective
[x] Provide unit tests (under <subproject>/src/test) to verify logic
[ ] Update User Guide, DSL Reference, and Javadoc for public-facing changes
[x] Ensure that tests pass locally: ./gradlew quickCheck <impacted-subproject>:check

Gradle Core Team Checklist

[x] Verify design and implementation
[ ] Verify test coverage and CI build status
[x] Verify documentation including proper use of @since and @Incubating annotations for all public APIs

This has passed stage 3 and perf tests. Just waiting for stage 4 to merge: https://builds.gradle.org/viewQueued.html?itemId=2958769

Merged with 7c79baf43b376e5a325f8dd236c4a5be728592f1


Ability to fine-tune postion/size

In dynamicSpot, you have the possibility to adjust the size/position of dynamic island pixel by pixel thanks to buttons and not only slider and know the actual value of it.
It would be nice to have this in Smart Edge, where it's difficult to have the pixel perfect size with the slider only.
e.g. dynamicSpot

Fixed in new version


Flag & delete UIActivity objects and UIActivityItemSource for basic content/comment classes

This also adds the ModelActivities subspec to our pod.
Not ready for merge yet.

:+1:


Phantom Root Directory

It creates phantom root-pointing directory when reading a disk, and persistent through the serialisation

confirmed: after fresh disk export, root directory does not contain "root" entry

confirmed: phantom entry always comes after the original entries in binary (which means we're reading 4 bytes longer than should be, maybe...)

FIXED:
VDUtil.kt, at line 90:
- (0..entryData.size / 4).forEach {
+ (0..entryData.size / 4 - 1).forEach {


Do we once again need to use --report-csv together with --report-path

In an erlier version --report-csv was not needed wen using --report-path. Or am i dreaming?

Just forget about that. It was just my bad. --report-csv is not needed wen using --report-path.


Sync Action

We are missing the rad sync command but maybe we want to run it automatically after a successful comment or reaction etc.
@gsaslis

@Stelios123 let's start with a manual command.


Move Store interfaces to Store namespace

We could move this into a Store assembly...  this poses the question of whether we should name the EF package... Microsoft.AspNet.Identity.Store.EntityFramework
Microsoft.AspNet.Identity
Microsoft.AspNet.Identity.Store
Microsoft.Aspnet.Identity.Store.EntityFramework
...
@divega

We discussed and decided that we are not doing this given that it feels incomplete without moving the types to a separate package and that doesn't seem to add much value (similar to the Abstractions package).


Add Behavioral Treatment Services as a dataset

Mental health services and substance abuse treatments are essential for vulnerable, low-income populations and can often be the biggest factor in helping people move out of poverty.
We should include this dataset to support the theme of health equity-- widening the definition of health care to include behavioral health.
https://findtreatment.samhsa.gov/

States to observe: Nevada, Alabama and Oklahoma have the highest Opioid claim rates according to: http://urbanobservatory.maps.arcgis.com/apps/Cascade/index.html?appid=f86499d99e4340b68229eaccfb02b29f


Allow group curators to resend group invitation email.

Coverage increased (+0.4%) to 92.407% when pulling a342623a09692204e7fe3db7800665b5e63ae40c on johngian:1258997 into c3a07fd835e3b6c8d5857146c179ab38458fb313 on mozilla:master.

Please change the PR and commit titles. Although group admin can do what you are describing, this functionality aims mainly group curators.

r+wc :+1:

Coverage increased (+0.4%) to 92.421% when pulling 38b6fe648239bfc2085e4d9e64f0e2dc7db141fd on johngian:1258997 into ea68426febf8777ab7bec4ed5bfd95511d7fdf6d on mozilla:master.


OverflowException on Array.sum and + typo on Operators.Checked

This OverflowException is actually undocumented behavior on Array.sumBy, List.sum, List.sumBy, Seq.sum, and Seq.sumBy as well, but I'd prefer if everyone agrees on one of those before someone might have to edit all these files multiple times.
I'm making two assumptions here, on things I technically don't know: that overflow behavior is defined and that its implementation via Operators.Checked is part of this defined behavior. This feels like the most economical way to define and document the exact throwing behavior and aligns with the F# library's usual policy of avoiding breaking changes. If this is wrong, please tell me how I can determine what things are supposed to do, because if I'm editing the only documentation I know, I'm effectively specifying the correct behavior.
When adding links, I ran across the + operator being called - in the Operators.Checked module doc, so I fixed this as well. (I see someone just fixed the equivalent issue on the "normal" operators. :) )
The other changes should be minor, they're only to regularize formatting.

@ReedCopsey IIRC I encountered two files with a different convention on this one. I then checked the current consensus and found that the Chicago Manual of Style is now recommending that punctuation "should appear in the same font (...) as the enclosing text".
I don't remember which file I compared to though; I was checking files from other places since the typography on the ones in the vicinity of this one seemed obviously broken in similar ways (e.g. the output formatting in all-bold concatenated text). I didn't check many others since it didn't seem like something even 1% of readers would care about, so I simply followed the typographic recommendation.
I could just leave the colons alone in the future. But I just now added another PR in which I didn't... read this a moment too late. ;)

@dend This LGTM.  @Vandroiy Opened #122 re: your comments about colon placement and bold.

Looking at this again, I have no idea how to properly format exceptions and headings. I hope this is okay, but it's not at all consistent with the (mostly broken) docs of other functions. See issue #123

Merging. Thanks @Vandroiy @ReedCopsey


[Suggestion] [Pixiv] Missing gallery type "manga" search on Pixiv.

Bug description
Grabber now can search only illust types of posts and galleries. Many galleries marked as "manga: are just missing from batch download and search tab.
Steps to reproduce
example:
user:12998
artworks/70833317 - is missed from search results (should be on page 4 now near artworks/70743824 in search results).
Expected behavior
Add selector for search fileds, maybe:
user:12998 illust_types:all or pure user:12998 - search all
user:12998 illust_types:illust - search illustrations galleries only
user:12998 illust_types:manga - search manga galleries only
user:12998 illust_types:ugoria - search ugoria animations only
As temporary fix and getting both manga and illust types of galleries for the current version of Grabber it is possible to comment this line in model.js for Pixiv:
illustParams.push("type=illust");

It seems working, thanks.
Can you look on https://github.com/Bionus/imgbrd-grabber/issues/2535 too ?


Configure SQL Server Container on Docker Persistence does not work!

Following in Configure SQL Server container images on Docker
Host Operating System:  Microsoft Windows 10 Pro : Version	10.0.18363 Build 18363
Docker Info :  Docker Desktop community version <IP_ADDRESS>(45183)
Command
docker run -e "ACCEPT_EULA=Y" -e "MSSQL_SA_PASSWORD=Compl3xPassw0rd" -p 1433:1433 -v sqldata:/var/opt/mssql/data -d mcr.microsoft.com/mssql/server:2019-GA-ubuntu-16.04
Error  from Docker logs command
SQL Server 2019 will run as non-root by default.
This container is running as user mssql.
To learn more visit https://go.microsoft.com/fwlink/?linkid=2099216.
2020-05-12 16:09:53.24 Server      Setup step is copying system data file 'C:\templatedata\master.mdf' to '/var/opt/mssql/data/master.mdf'.
2020-05-12 16:09:53.28 Server      ERROR: Setup FAILED copying system data file 'C:\templatedata\master.mdf' to '/var/opt/mssql/data/master.mdf':  2(The system cannot find the file specified.)
ERROR: BootstrapSystemDataDirectories() failure (HRESULT 0x80070002)

@c0dingarchit3ct -- Ahmed, thank you for your feedback.  Please consider these resources:

DBA Stack Exchange
Stack Overflow

You are welcome to add this issue here:

SQL Server Feedback

I am closing this issue now.  You are welcome to @ mention me for any followup.
We hope to hear from you again.


4 generate lookup tables

for this PR to be approved,all the 'test plans' need to be moved into github comments instead

need to consolidate the plans and make them make sense, run in sim or on a beamline

from conversation with @iain-hall I figured that a couple of different kinds of alignment were mixed up in the code here. Will adjust on Monday the 19th

adjusted, still need more in-person chat with the scientist to perfect the alignment definition

will inviestigate today

manual steps:
setup steps:

set filter B to be in line diode mode
filter A must be at the right size so that the reading from the current is below 20. it's best if between 2 and 18 ? - or decide for which element which. the smaller the filter, the bigger the current, some kind of exponential. must be discrete. attenuator as a name

XFAS community uses Ev for initial energy and inverse angstorms for final energy
not going through all the elements at each run, it's per user run.
that is at the moment, we could do all the elemnts at the start of the run.
the monochromator Bragg angle corresponds to the element - energies to excite the metallic orbitals of
harmonics are learned empirically, about the relationship
Silicon111 is the monochromator where every element has a dedicated harmonic - the lower Z elements are at lower harmonics
higher Z elements are at a higher harmonics.
Monochromator has both the crystal and the energy
Mo has highest energy, so at the highest harmonic - 19
if we know that someone will use Ga scan, the beamline stuff know to cover the given energy
easier for humans to read this angle start, angle end as energy in eV.
usually 1 element has 1 edge
element AND edge as the scan arguments
for GDA the energy space is discretized into gears - harmonics? maybe the insertion device or optics teams?
so during the alignment we pause the conversion between harmonics and energies.
physical order:
idgap (unudlator) -> Bragg angle ->
scanning proper

scan goes to the first angle/energy - starting position using the exiisting lookup table, to start off.
mm on x and reading is some energy on Y microAmps diode reading. peak fitting
we create pairings of angle /element energy to idgap
we get a 3 d pricture which is reduced into 2d by just getting the peaks, which is a discrete representation of a monotonic relatinoship between Bragg angle and the idgap.

/dls/science/groups/i18/lookuptable/Fe_Co_Ni_Aug24.txt  - so three elements next to one another, all 3 under the same harmonic
physcial cleanup stage

moving the d7 filter a and filter b back

calculation stage - in IDL

not quite linear - we get function parameters and then it updates the part of a bigger harmonic file  - for a given chunk.

when running the script, generous with the range, so that it's updated generously.

there is also alignment of perpendicular gap is similar.
a number of energies, very simia

Gaussian fitting vs peak fitting. maybe there was an option to use it, rather than the peak, possible other

sources of issues when running manually:

saturation
if the original idgap is so far out of the scan

right now for one element - maybe 10 minutes
saturation is usually quick, if it works right, scanning takes most of the time, IDL is quick, sat

if all automatic, twice a week - elements for a specific user
otherwise the whole energy range at the end of the run.
19 harmonics? 10 minutes each - 3 hours? or more maybe, adding more point.
so either at the beginning of the experiment, or at the end of it.
need full beam for the, startup beam is full beam too, it's all good.

@iain-hall the narrowed down version of the i18 code is in the plans/align_idgap.py file.
Much of the logic might go into the dodal undulator device, I hope to figure out more in the Friday meeting


[FEATURE] [control plane][FE] display running api adapter/standard version /kraken version/upgrading status in the UI

As a control plane user, I would like to understand the following information regarding the following information

running api adapter name
standard version
kraken version
mapping template upgrading status

url
/system-info
request
curl -X 'GET' \
  {{baseUrl}}/system-info' \
  -H 'accept: application/json' \
  -H 'Authorization: Bearer '

responses
{
  "code": 200,
  "message": "OK",
  "data": {
    "id": "1bba3aa0-6f40-4974-8e77-59674227f783",
    "createdAt": "2024-10-15T05:14:56.363035Z",
    "updatedAt": "2024-10-29T07:01:21.530939Z",
    "controlProductVersion": "V1.0",
    "stageProductVersion": "V1.5.1",
    "productionProductVersion": "V1.5.1",
    "controlAppVersion": "0.285.0",  // control plane kraken version which will show up in the tooltip
    "productKey": "mef.sonata",
    "productSpec": "grace", // standard version
    "key": "CONTROL_PLANE",
    "status": "RUNNING",  //upgrading status, mapping template upgrading status
    "productionAppVersion": "0.284.0",  // production data plane kraken version which will show up in the UI and tooltip
    "stageAppVersion": "0.284.0" //stage data plane kraken version which will show up in the tooltip
  }
}

status enum
CONTROL_PLANE_UPGRADING,
CONTROL_PLANE_UPGRADE_DONE,
STAGE_UPGRADING,
STAGE_UPGRADE_DONE,
PRODUCTION_UPGRADING,
RUNNING

@kuangxiang20240501 besides productKey, can we have productName with value of MEF LSO Sonata returned by BE? So that FE can pick it up, thanks.
Yeah,  I will reafactor the the code to support the case
Another thing is that can we support streaming data of this info as it impacts user's behavior significantly in the portal?
The front end can perform long polling to obtain the latest status where needed. The back end needs to bury points in multiple places to trigger push, which will lead to code coupling.

add productName in response

@james-tran-3005 discussed with @kuangxiang20240501 , since control users number are very limited in real case, we suggested using polling per 1 minute in FE to refresh the data.


Support for maths symbols

Describe the solution you'd like
A clear and concise description of what you want to happen.
Lots of maths characters would be useful for teachers:  fractions, operators, etc

Hello. I am sorry it is not planned for now (cf the README: https://github.com/damienleroy/PowerAccent#known-problems).
But be sure we are working of a solution, but it is a longterm work. Some things has to be done before thinking about this feature.
I should may explain the plan somewhere though.
Hope you understand. Thanks for your patience :)


NameError: name 'AtomicInt' is not defined

I am using CentOS 6.6, Python 2.6.6 and latest aliyuncli, the following error occurs when I use any aliyuncli command:
[root@56f20fb23c74 /]# aliyuncli configure
Traceback (most recent call last):
File "/usr/bin/aliyuncli", line 7, in
from aliyuncli.aliyuncli import main
File "/usr/lib/python2.6/site-packages/aliyuncli/aliyuncli.py", line 25, in
import aliyunCliMain
File "/usr/lib/python2.6/site-packages/aliyuncli/aliyunCliMain.py", line 21, in
import aliyunOpenApiData
File "/usr/lib/python2.6/site-packages/aliyuncli/aliyunOpenApiData.py", line 22, in
import aliyunExtensionCliHandler
File "/usr/lib/python2.6/site-packages/aliyuncli/aliyunExtensionCliHandler.py", line 24, in
import advance.userProfileHandler
File "/usr/lib/python2.6/site-packages/aliyuncli/advance/userProfileHandler.py", line 5, in
import aliyunExtensionCliHandler
File "/usr/lib/python2.6/site-packages/aliyuncli/aliyunExtensionCliHandler.py", line 22, in
import aliyunCliHelp
File "/usr/lib/python2.6/site-packages/aliyuncli/aliyunCliHelp.py", line 20, in
import aliyunOpenApiData
File "/usr/lib/python2.6/site-packages/aliyuncli/aliyunOpenApiData.py", line 47, in
import ossadp.ossHandler
File "/usr/lib/python2.6/site-packages/aliyuncli/ossadp/ossHandler.py", line 44, in
TOTAL_PUT = AtomicInt()
NameError: name 'AtomicInt' is not defined

We have released a new command line tool for OSS operation.  Please access https://github.com/aliyun/ossutil for the OSS CLI tool.
The latest version of aliyuncli will display advice for switching to the tool when OSS operation sub-command is typed.


Taylorr/buffer get improvement

I meant to make this one :)
This fixes https://github.com/libcsp/libcsp/issues/385 by setting the length field of the gotten buffer before return.
This changes the definition of csp_buffer_get to explicitly return a csp_packet_t *. The docs say it returns a csp_packet_t * and everywhere in the code treats it as a csp_packet_t * yet it was declared with void * return.

Thank you very much for the contribution. The change has been merged into my working branch, and another pull request opened for that merge.


Milestone management

This PR implements some of the idea about milestones listed in #971.
In the task view page, instead of having:

Links: list of link labels and their related tasks + time tracking per task
Subtasks: list of subtasks + time tracking per subtask
Time tracking

we now have:

Milestone: list of tasks that targets this milestone + time tracking per task + total time tracking
Each task is displayed as a collapsed colored card, like in the board view
A click on a task id displays the "dropdown menu", like in the board view (see second commit)
Subtask: no change
Time tracking: no change
Links: a more simple list of link labels and their related tasks (without "is a milestone of")

The result is:

I separate this in 2 commits:

"Add special section for milestone in task view" only adds the milestone views
The "progress bar" use the color of the current task
The algorithm to compute the progress bar is: SUM_all tasks( min(time spent, time estimated) ) / SUM_all taks(time estimated)
"Enable dropdown menu for other page than board" adds the task dropdown menu to the milestone view.
To implement that, I had to update all popover views to manage properly the redirection. Because the current behaviour is: ajax => redirect to board, otherwise redirect to task view. Now we can choose were to redirect after an update through a popover page. So, normally, we can now add the task dropdown menu in the listing view, calendar view (and the future roadmap view?) quite easily.

Can you make a separate pull-request for the task milestone view and the dropdown menu? that will be easier to review. Thanks.

Ok, I will create a PR for dropdown menu only. I have another idea for the milestone view, which may fit better with "your" vision of task link. I will need some time to work on it.


Support for special characters

When I tried to edit my post using teblr, it shows error if there is any special characters such as a single quote (').
UnicodeEncodeError: 'ascii' codec can't encode character u'\u2019' in position 300: ordinal not in range(128)

That was because I forgot to encode data into unicode. Fixed now!


Dual-license with more mature license

The Unlicense is known among software lawyers for being a bit sketchy. Large companies are advised by their lawyers that they can't afford to take Unlicensed software seriously. This is a big shame, because the Unlicense stands for something very significant and we should take strides to improve its legal status, but in the meantime, one could do with a workaround. I suggest the MIT license be used.
LICENSE.txt

Great idea, should have been MIT from the start, thanks!

 You're so keen on following mainstream propaganda and all this "license" garbage.

You're so keen on following mainstream propaganda and all this "license" garbage.

 You're so keen on following mainstream propaganda and all this "license" garbage.


Creating pull request for 10.21105.joss.02102

If this looks good then :shipit:

@whedon accept deposit=true


Compilation of pybind11 drivers fails with compiler crash on Ubuntu 18.04 with gcc 7.5.0

I am trying to install celerite2 using pip (version=20.2.3) with python3.7 on an Ubuntu18.04 machine, however I get the following error when pip is trying to build wheels for celerite2:
ERROR: Failed building wheel for celerite2
Failed to build celerite2
ERROR: Could not build wheels for celerite2 which use PEP 517 and cannot be installed directly
Thanks,
Tom

Hi! This package hasn't really been officially released yet so expect some rough edges (isn't that always true)!
Can you give me some more details?

I expect that you're installing from source (by cloning from GitHub), but can you give the specific steps you're executing.
Also: can you add the -v argument to the pip call and share the output in a gist or something? The current error is not sufficient to diagnose.

Hi,
Completely understandable :)
Of course, I'm installing from the GitHub clone: pip install git+https://github.com/dfm/celerite2.git
Here's the gist: https://gist.github.com/ThomasGWilson/4a4821a28b6ed6739284d6d1a19c44d4
Cheers,
Tom

That gist doesn't seem to be complete (it doesn't have the error!), but I can see an issue. It won't be possible to install from source like that. Instead you should follow the steps here: https://celerite2.readthedocs.io/en/latest/user/install/#from-source With the added note that you'll need to include --recursive in the git clone step. Give that a try and send along the error if it fails again.

Hi,
That gist is >3000 lines so the error was beyond the truncation point. Here is the full previous report (https://gist.githubusercontent.com/ThomasGWilson/4a4821a28b6ed6739284d6d1a19c44d4/raw/fe433cb75589e2c980b30ab829fc3bc764dc31c3/gistfile1.txt)
Thanks! I've installed via the steps you recommended, however I'm getting a similar error. Here is the full report (https://gist.githubusercontent.com/ThomasGWilson/29b1399905ff8e8ef4779a4733ba836c/raw/86575a1a70b0033aceff0bba77e74189211bbd34/gistfile1.txt)
The common error here seems to be an issue with one of the gcc arguments:
gcc -pthread -B /home/tom/anaconda3/compiler_compat -Wl,--sysroot=/ -Wsign-compare -DNDEBUG -g -fwrapv -O3 -Wall -Wstrict-prototypes -fPIC -Ic++/include -Ic++/vendor/eigen -Ipython/celerite2 -I/tmp/pip-build-env-2mpwi2p9/overlay/lib/python3.7/site-packages/numpy/core/include -I/tmp/pip-build-env-2mpwi2p9/overlay/lib/python3.7/site-packages/pybind11/include -I/tmp/pip-build-env-2mpwi2p9/overlay/lib/python3.7/site-packages/pybind11/include -I/home/tom/anaconda3/include/python3.7m -c python/celerite2/driver.cpp -o build/temp.linux-x86_64-3.7/python/celerite2/driver.o -DVERSION_INFO="0.0.1rc2.dev18+gfabb85c" -std=c++17 -fvisibility=hidden
cc1plus: warning: command line option ‘-Wstrict-prototypes’ is valid for C/ObjC but not for C++
gcc: internal compiler error: Killed (program cc1plus)
Please submit a full bug report,
with preprocessed source if appropriate.
See <file:///usr/share/doc/gcc-7/README.Bugs> for instructions.
error: command 'gcc' failed with exit status 4

For completeness I have gcc version 7.5.0 installed.

Good thanks. That suggests to me that your compiler is running out of RAM or something. Compiling these extensions can be pretty heavy! I'm not sure that I can do too much to diagnose this from here, but we can keep this open to re-investigate later.
In your case, I'd probably recommend trying the pre-compiled binaries unless you have a good argument for avoiding them (or if you're running into issues with them):
python -m pip install celerite2==0.0.1rc1

Nothing has changed (except documentation) since that release candidate.

Hi Dan,
Thanks, that has worked!
Cheers,
Tom


performance

[x] support passive event listeners
[ ] load only a small window out of infinite number of rows and columns
[ ] try preview / commit two phase resizing for performance and to avoid scroll snap jank issues
[x] alternately try switching off scroll snap during resize dragging

inspire by the sproutcore big data demo for how to do the infinite https://showcase.sproutcore.com/#demos/Big Data Lists


chore(main): release 2.1.0

:robot: I have created a release beep boop
2.1.0 (2024-07-23)
Features

load: add support for OB16 ICEFRAC output field (ea193fa)

This PR was generated with Release Please. See documentation.

:robot: Created releases:

v2.1.0
:sunflower:


University of Richmond

Official site: www.richmond.edu
Computer Science Major: https://cs.richmond.edu/
Reference to University email domain: https://spidertechnet.richmond.edu/TDClient/1955/Portal/Requests/ServiceDet?ID=35411

@eleda77 Thank you for your patience while waiting for a review and processing your request. Pull request merged. Please start applying for JetBrains educational subscription at https://www.jetbrains.com/shop/eform/students in an hour, to allow the changes to propagate through JetBrains systems.


Update grpcio version to 1.68.0

Can someone help resolve the failed commit checks please? It seems to be a configuration problem, the build is failing as the Open API key environment variable is not present.


dyld error Library not loaded: @rpath/SQLite.framework/Versions/A/SQLite

Build Information
mac os x Version 10.13.6 (17G65)
Xcode Version 9.4.1 (9F2000)
sqlite.swift version 0.11.4 - manual installation
(Bundle id: com.stephencelis.SQLite, Version 0.11.4)
integrated into project by adding the SQLite.xcodeproj file into my newly created Xcode project and then added the SQLite mac os x framework to the target
General guidelines
I was attempting to create a simple project using the SQLite framework for mac os x by:
(1) create new swift mac os x project
(2) add the SQLite.xcodeproj file by dragging it into the project
(3) add the SQLite mac os x framework from it in the project target settings
(4) create simple class which contained "import SQLite" line as well as simple code to:
create Connection object
select entries from a table in the db
print the column values from these rows
(5) the program executed without any problems in the Xcode IDE and produced the expected results
(6) I then built an app from this project via the Product -> Build For -> Profiling option
(7) When I then executed the Release version of the app I got the dyld error referred to above. Some additional message from the error report:
Dyld Error Message:
Library not loaded: @rpath/SQLite.framework/Versions/A/SQLite
Referenced from: /Users/USER/Library/Developer/Xcode/DerivedData/SqlXC1-copihclaeeyfyigvfzzjirbgvjzs/Build/Products/Release/SqlXC1.app/Contents/MacOS/SqlXC1
Reason: image not found

Was able to resolve this problem by adding theSQlite Mac OS X framework to the project's embedded binaries section.

issue closed


Use pylance client if pylance client is available/enabled.

If Pylance claims it supports client by itself, this change will let python core extension to let pylance to handle language client.

Make sure to bump the engine version to latest on both the extensions.

Closing this as blocked on https://github.com/microsoft/vscode-python/issues/20002 . That is a meta issue tracking progress on the Jupyter <-> Python <-> (Pylance, Jedi, ...) communication.
there might be changes to this design. so for now I am closing this.


Suggestion: make clear that instances calling Await are unsafe

There are a few uses of Await in typeclass instances provided by util: Eq and Comonad for Future and Rerunnable.
I suspect the Eq instances are only intended for testing, in which case they could just be moved into test.  I'm not sure what the Comonad instances are for at all - I can't envisage a use for them personally.
So my initial suggestion is:

move the Eq instances into test
move the Comonad instances into an unsafe or maybe alleycats subpackage with some docs to make it clear to the user what they're getting into (alternative option: just remove them)

I would be happy to do the gruntwork if a change is agreed on.

My reasoning here was that none of the Eq or Comonad instances are implicit (so I wouldn't even call them "instances" personally—I'd think of them more as helper methods), and if I remember correctly they all require an explicitly-provided duration.
So in order to put an Await-using instance into scope, you have to define your own implicit calling these methods, and to think about what duration you want to provide. In my view that's a high enough bar for intentionality—you definitely can shoot yourself in the foot, but you have to go through a couple of non-trivial steps to do it.
I'm not strongly opposed to moving them, but I do think they can be useful in situations where you just want to run some stuff in the REPL or a script, and I'd prefer just to add "unsafe" to the method names if there are concerns that they could be misused accidentally.

Makes sense.  How about some docs - I'll write some up with your suggested use cases if you like?
Out of curiosity, do you just use Comonad as a convenience for calling extract (once the instance is in scope), or do you do something more advanced with it?

@dangerousben I think I've also only used Comonad instances in tests (where it's sometimes practical for abstracting over contexts) or the REPL.


Cannot checkout this repo on windows because of : character in path

git will report error with:
error: invalid path 'tools/bookrunner/configs/books/Rust by Example/Custom Types/Enums/Testcase: linked-list/5.props'

Hi @crlf0710 , thanks for the issue! I'll see if we can rename the bookrunner examples somehow to avoid this error.

Resolving because #3123 removed all .props files.


Release 0.4.0

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

Oops! Forgot that conda-forge is so automated now that I don't need to open a PR here!


feat: activate identity provider on specific url path

PR Type

[ ] Bugfix
[ x ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no API changes)
[ ] Build-related changes
[ ] CI-related changes
[ ] Documentation content changes
[ ] Application / infrastructure changes
[ ] Other:
What Is the Current Behavior?
Currently the PWA can only be setup with one active identity provider. The PWA should be configured for specific identity providers in such a way, that these are active, when the PWA is rendered with a specific url path. The punchout identity provider should be used, when the 'punchout' feature is active and the PWA is initially loaded with /punchout.
Issue Number: Closes #
What Is the New Behavior?
The activeOnPath property is introduced for the IdentityProviderImplementor interface. When the current url path matches the configured value, then the new identity provider is used. If no url path has a match with the available identity providers, then the old behavior is used.
Furthermore all identity provider guards and interceptors are adapted to wait until a active identity provider is found.
Does this PR Introduce a Breaking Change?

[ ] Yes
[ x ] No
Other Information
AB#88708

🥇

There is still a problem:

Login as punchout user, e.g. localhost:4201/punchout?USERNAME=ociuser@test.intershop.de&PASSWORD=!InterShop00!&HOOK_URL=https://punchoutcommerce.com/tools/oci-roundtrip-return
Logout
Go to Login Page
An error page occurs:


⚠ ClamAV has degraded performance

In 258f489, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 79 ms

Resolved: ClamAV performance has improved in a43a1ee.


Issue 250 complete permission checks

Fixes #250

Ensures you're an admin user to view/edit users
Ensures you're an admin user to view/edit agencies
Fixes editing users so that it works rather than just editing yourself
Adds factory girl and request specs for validating permissions.

Note that I've added the factories all into a single file.  This is recommended by the folks from thoughtbot and is something that I'm finding I enjoy.

I added comments in the code.  Overall looks great!  Thanks for adding all the request specs and adding FactoryGirl was a must!  :smiley:

@lamplus I'm leaving you in charge of merging in all pull requests, since you are the maintainer of the repo.

@lamplus pushed a few more commits here that should address @joedean's comments.


Adds "can't determine value for sysroot"

rust-lang/rust#16229
This issue happens on a chroot without proc, sys and dev mounted.
So this scripts sets up a debian chroot using debootstrap and copies the
rustc into the jail.
This cannot run on the container infrastructure of Travis, so the tests will become slower when merged.

I'm using this to test the script on Travis. I will squash those later.

Amazing, thanks!


Desc field for Opcode 0x129 is confusing

Hey, danhedron of OpenRW noticed that one of the commands had confusing descriptions.
Affected GTA III version
Affected GTA VC version
The XML portion in question is
        <Arg Type="INT" Desc="Ped type" Entity="CAR"/>
        <Arg Type="INT" Desc="Model ID" Enum="PEDTYPE"/>
        <Arg Type="INT" Desc="Car/vehicle" Enum="CARPEDMODEL"/>

where a mismatch between Desc and Entity / Enum occurs.

        <Arg Type="INT" Desc="Car/vehicle type" Entity="CAR"/>
        <Arg Type="INT" Desc="Ped" Enum="PEDTYPE"/>
        <Arg Type="INT" Desc="Model ID" Enum="CARPEDMODEL"/>

is probably better.
Note that the GTA SA version of the command is less complete so the problem doesn't exist there yet.

Fixed by #43


Linter expects invalid syntax for multiline generics

Bug Report

TSLint version: 4.0.3
TypeScript version: 2.0.10
Running TSLint via: any

TypeScript code being linted
// Makes more sense with long signatures that exceed the line length limit.
function fn<
    A extends Object,
    B extends Object  // tslint error here
>(a: A, b: B) {
    return [a, b];
}

with tslint.json configuration:
{
    "extends": "tslint:recommended",
    "rules": {
        "variable-name": [
            true,
            "ban-keywords",
            "allow-pascal-case"
        ],
        "object-literal-sort-keys": false,
        "only-arrow-functions": false,
        "interface-name": [true, "never-prefix"]
    }
}

Actual behavior
tslint demands a trailing comma on the last item of the multiline generic declaration. A trailing comma there would be syntactically invalid (TS1009).
Expected behavior
Trailing comma should not be expected.

duplicate of https://github.com/palantir/tslint/pull/1775


Use GetType().Name to resolve types between the .Net Core and .Net Framework rather than the session key

Summary
In our multi-tenant application we often use a computed value for the session key.  This makes it impossible to setup the keys for the JsonSessionSerializerOptions in advance.  Also sometimes developers add types like List<string>, int, etc... into session state with keys that only one controller is aware of.
Motivation and goals
My goal is to identity the correct type in both the .Net Framework and .Net Core applications and unless there is some other compelling reason not to use the Type.Name property would it be possible for there to be an implementation that uses a unique string identifier for each type? Also this approach seems like it would require fewer registrations vs using session keys.  For example any keys representing string values would only have to be registered once.
In scope
Using the Type.Name would be simple but using a unique string identifier would require a bit more work.  In either case when using either (Type.Name or a unique string identifier)  the ISessionSerializer implementation would have to include that value in the BinaryReader/BinaryWriter implementation.
Out of scope
N/A
Risks / unknowns
No idea if this was previously tried and rejected.
Examples
    .AddTypeNameJsonSessionSerializer(options => {
        options.KnownTypeNames.Add(typeof(int).Name, typeof(int));
        options.KnownTypeNames.Add(typeof(SessionDemoModel).Name, typeof(SessionDemoModel));
        options.KnownTypeNames.Add(typeof(List<string>).Name, typeof(List<string>));
    })

when using the name of the type I had to add three additional classes to my POC but I did not have to change the interfaces only the implementation.
public class TypeNameSerializerOptions

internal partial class TypeNameBinarySessionSerializer : ISessionSerializer

internal partial class TypeNameJsonSessionKeySerializer : ISessionKeySerializer

Otherwise the other big changes were in
class TypeNameBinarySessionSerializer
    public void Write(ISessionState state, BinaryWriter writer)

                    typeName = obj.GetType().Name;
                    if (_serializer.TrySerialize(typeName, obj, out var result))
                    {
                        writer.Write7BitEncodedInt(result.Length);
                        writer.Write(typeName);
                        writer.Write(result);
                    }
class BinaryReaderSerializedSessionState : ISessionState
             Constructor
                var key = reader.ReadString();
                var length = reader.Read7BitEncodedInt();
                var typeName = reader.ReadString();
                var bytes = reader.ReadBytes(length);

                if (serializer.TryDeserialize(typeName, bytes, out var result))
                {
                    if (result is not null)
                    {
                        this[key] = result;
                    }
                }
modification of public static ISystemWebAdapterRemoteServerAppBuilder AddSessionServer(this ISystemWebAdapterRemoteServerAppBuilder builder, Action<RemoteAppSessionStateServerOptions>? configureRemote = null)

        builder.Services.AddSingleton<ISessionSerializer, TypeNameBinarySessionSerializer>();

POC.zip

Have you tried a custom ISessionKeySerializer implementation? It allows you to specify the serialization/deserialization for any key (including non-deterministic keys).

I just took a look at your zip file and see that you do have a custom ISessionKeySerializer. I'm not sure you need to do anything with the ISessionSerializer interface - you should be able to just encode what you want in the key serializer. If there's a limitation there, please let us know.
This is not something we will want to ship with the adapters. Your design is very similar to BinaryFormatterSerializer which has been deprecated/removed from .NET 7+. However, you're welcome to implement the interface however you want for your own code/packages :)

I just took a look at your zip file and see that you do have a custom ISessionKeySerializer. I'm not sure you need to do anything with the ISessionSerializer interface - you should be able to just encode what you want in the key serializer. If there's a limitation there, please let us know.
I don't believe this is something we will want to ship with the adapters. Your design is very similar to BinaryFormatterSerializer which has been deprecated/removed from .NET 7+. However, you're welcome to implement the interface however you want for your own code/packages :)

If I did not do anything with the ISessionSerializer interface but I had to replace the BinaryFormatterSerializer implementation so that I could pass the typename between the .NET framework and the .NET 6 applications or am I missing something?

I looked at the BinarySessionSerializer again and there is a suggestion that might help with this situation.  If the ISessionKeySerializer interface was modified to pass in the BinaryWriter and BinaryReader then the ISessionKeySerializer implementation could write out the Byte[], Length,  as well as the typeName and the same with reading the data.  Then all of the code changes could be isolated to the ISessionKeySerializer implementation.  Thoughts?

If the ISessionKeySerializer interface was modified to pass in the BinaryWriter and BinaryReader then the ISessionKeySerializer

Not everything would need the writer/reader. Also, changing the interface is a breaking change. There may be ways to allow for implementations that would like the writer/reader, but not sure if the pay off would be worth it. However, why not create one yourself on a per-key basis? They can be pooled with ObjectPool<> if you're worried about the allocations. That way you can write/read whatever you want to

@bmukes I'm going to close this issue - if it turns out to be insufficient, please reopen or create a new issue!