Node.js v22.2 causes ng build hangs up

Command
build
Is this a regression?

[ ] Yes, this behavior used to work in the previous version

The previous version in which this bug was not present was
No response
Description
When the Node.js version is v22.2.0 (released on 2024-05-15), the ng build command hangs up. Node.js v22.1.0 doesn't.
Angular CLI is not supporting that version of Node.js officially, but on Firebase App Hosting, the build environment is using Node.js v22.2 today by default. So it is an easy situation for developers to get stumped.
My workaround is to set engines.node field in package.json as "20". App Hosting builder can determine the Node.js version to install.
Minimal Reproduction

set Node.js version to v22.2.0
ng new on @angular/cli@latest (v17.3.7)
ng build
print Building... and never finished.

Exception or Error
No response
Your Environment
Angular CLI: 17.3.7
Node: 22.2.0 (Unsupported)
Package Manager: pnpm 8.15.6
OS: darwin arm64

Angular: 17.3.9
... animations, common, compiler, compiler-cli, core, forms
... platform-browser, platform-browser-dynamic, platform-server
... router

Package                         Version
---------------------------------------------------------
@angular-devkit/architect       0.1703.7
@angular-devkit/build-angular   17.3.7
@angular-devkit/core            17.3.7
@angular-devkit/schematics      17.3.7
@angular/cli                    17.3.7
@angular/ssr                    17.3.7
@schematics/angular             17.3.7
rxjs                            7.8.1
typescript                      5.4.5
zone.js                         0.14.6

Warning: The current version of Node (22.2.0) is not supported by Angular.

Anything else relevant?
No response

Does this repro using Angular 18 RCs?

@JoostK Yes, it reproduces the same situation even after ng update @angular/core @angular/cli --next
Angular CLI: 18.0.0-rc.3
Node: 22.2.0
Package Manager: pnpm 8.15.6
OS: darwin arm64

Angular: 18.0.0-rc.3
... animations, cli, common, compiler, compiler-cli, core, forms
... platform-browser, platform-browser-dynamic, platform-server
... router, ssr

Package                         Version
---------------------------------------------------------
@angular-devkit/architect       0.1800.0-rc.3
@angular-devkit/build-angular   18.0.0-rc.3
@angular-devkit/core            18.0.0-rc.3
@angular-devkit/schematics      18.0.0-rc.3
@schematics/angular             18.0.0-rc.3
rxjs                            7.8.1
typescript                      5.4.5
zone.js                         0.14.6

Unfortunately, this is a regression introduced by Node.js, and it's not something we can address on our end. For more details, see: Node.js Issue #53097.

It seems that the "regression" was intentional from Node.js' perspective. Unfortunately, this breaking behaviour happened in a minor version of Node.js, We will need to put in some work to address it on our end as it's not as trivial to solve.

There has been a revert in Node.js that will fix this in their next release. See: https://github.com/nodejs/TSC/issues/1566#issuecomment-2143907186 for more information.


tests, storage/restore: Remove a redundant prompt login

What this PR does / why we need it:
A redundant VM console prompt login has been removed. It caused some flakes in the tests, when the second login was attempted.
Although for the Fedora guest, detecting a login should have been supported, it seems that from time to time the detection is not working as expected. Reducing double logins may help reduce the flakes a bit.
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Special notes for your reviewer:
Release note:
NONE

/test pull-kubevirt-e2e-k8s-1.23-sig-storage
/test pull-kubevirt-e2e-k8s-1.24-sig-storage
/test pull-kubevirt-e2e-k8s-1.25-sig-storage

change: Rebase

/lgtm

/approve
/retest


2 search forms, 1 result section "Uncaught TypeError: Cannot read property 'query' of undefined"

I followed the tutorial in the wiki, but unfortunately I keep getting the same error over and over.
I have this in my html:

                    <form role="search" method="get" class="search-form" action="#">
                        <input class="search-field">
                        <input class="search-submit" type="submit" value="Search">
                    </form>

            <form role="search" method="get" class="search-form" action="#">
                <input class="search-field-nav">
                <input class="search-submit" type="submit" value="Search">
            </form>

This in my javascript:
var searchField = $(".search-field").ghostHunter({
    onKeyUp: true,
    info_template: `<p>{{amount}} posts found</p>`,
    result_template: `<a id='gh-{{ref}}' class='gh-search-item' href='{{link}}'><div class="gh-search-item-content"><h2>{{title}}</h2><h4>{{pubDate}}</h4></div></a>`,
    results: "#results"
});

$('.search-field-nav').on('keyup', function(event) {
    $('.search-field').prop('value', event.target.value);
    $('.search-field').trigger('keyup');
});

I get this error on .search-field-nav, while .search-field is working fine:
Uncaught TypeError: Cannot read property 'query' of undefined
I don't see what I'm doing wrong. Is this a bug or am I doing something wrong?
EDIT:
It does work, but I need to search in .search-field before using .search-field-nav in order for it not to give the error.
When I use .search-field-nav first, it gives the error.

this is a quick fix if you want:
--- a/assets/ghostHunter/src/ghosthunter.js
+++ b/assets/ghostHunter/src/ghosthunter.js
@@ -253,7 +253,7 @@

+                       self = this
                        lastTimeoutID = setTimeout(function() {
                                // Query strategy is lifted from comments on a lunr.js issue: https://github.com/olivernn/lunr.js/issues/256
                                var thingsFound = [];
@@ -285,7 +299,7 @@
                                        // Fetch a list of matches for each term.
                                        var v = valueSplit[i];
                                        if (!v) continue;
-                                       thingsFound.push(this.index.query(function (q) {
+                                       thingsFound.push(self.index.query(function (q) {

thingsFound.push(self.index.query(function (q) {

I tried that, but unfortunately I still get the same result:

It's a diff.
The red means you should replace it with the green.
So you need the variable self before lastTimeoutID = ...

Yes I got that. I just wasn't sure about the first 2 lines. Anyway it doesn't work for me :s


Add a Gitter chat badge to README.md

jotorren/ra-ng now has a Chat Room on Gitter
@jotorren has just created a chat room. You can visit it here: https://gitter.im/ra-ng/Lobby.
This pull-request adds this badge to your README.md:

If my aim is a little off, please let me know.
Happy chatting.
PS: Click here if you would prefer not to receive automatic pull-requests from Gitter in future.

Badge added


io.reactivex:rxjava:1.X - J2ObjC continuous build

Reactive Extensions for the JVM – a library for composing asynchronous and event-based programs using observable sequences for the Java VM.
@benjchristensen, @zsxwing, @akarnokd - FYI for you all - no need to take action. This concerns supporting translation of the RxJava library to Objective-C such that it can be used on iOS. This issue is specifically for testing the translation as part of a continuous build using Google's Java to Objective-C conversion tool, known as "J2ObjC".
Since you're using the Netflix Nebula testing framework. I'd suggest looking at the newly release Gradle TestKit which was heavily influenced by Nebula:
https://docs.gradle.org/2.6-rc-1/userguide/test_kit.html
@advayDev1 - What's easier about RxJava is that it already uses a Gradle Build. Since the 2.0 release isn't finalized, I'd suggest supporting the 1.0.14 release. It also has the benefit of having no external dependencies except for testing:
From their 1.0.14 build.gradle: https://github.com/ReactiveX/RxJava/blob/v1.0.14/build.gradle
buildscript {
  repositories { jcenter() }
  dependencies { classpath 'com.netflix.nebula:gradle-rxjava-project-plugin:2.2.3' }
}

description = 'RxJava: Reactive Extensions for the JVM – a library for composing asynchronous and event-based programs using observable sequences for the Java VM.'

apply plugin: 'rxjava-project'
apply plugin: 'java'

dependencies {
    testCompile 'junit:junit-dep:4.10'
    testCompile 'org.mockito:mockito-core:1.8.5'
}
...

Sounds great. How will you manage the unsafe/regular distinction in our code? If not too much burden, I'd like to know how well the 2.0 branch translates to Objective-C (in its current state).

Someone was trying to use RxJava and reported a crash with sun.misc.Unsafe
https://groups.google.com/forum/#!searchin/j2objc-discuss/RxJava/j2objc-discuss/LjunwVJs2O0/gV5sMU08EwAJ
Quoting @tomball:
"Please retry with the very latest source. Keith recently updated
sun.misc.Unsafe
https://github.com/google/j2objc/commits/master/jre_emul/Classes/sun/misc/Unsafe.java
to
use c11 atomic intrinsics, which should make that class both more correct
and stable."
I'll ping the thread to ask if the problem was resolved. We really need to
get all the unit tests running as well if you want to have confidence in
the output.
On Thu, Oct 1, 2015 at 12:05 AM David Karnok<EMAIL_ADDRESS>wrote:

Sounds great. How will you manage the unsafe/regular distinction in our
code? If not too much burden, I'd like to know how well the 2.0 branch
translates to Objective-C (in its current state).
—
Reply to this email directly or view it on GitHub
https://github.com/j2objc-contrib/j2objc-common-libs-e2e-test/issues/43#issuecomment-144639261
.


Auto line-wrapping in Markdown blocks to ease documentation

Environment

Elixir & Erlang/OTP versions:  1.13.0 (compiled with Erlang/OTP 24)
Operating system: Unbuntu 18.04
How have you started Livebook: livebook CLI
Livebook version: 0.5.2

Current behavior
Typing text in a Markdown block will keep it on a single line, until explicitly typing the return key. Either scrollbar appears and paragraph texts are truncated in the viewport, or you have to format yourself and add line breaks.
Expected behavior
Documentation should be as smooth as possible. Typing here on Github also wraps automatically to a new line. Once you add manual line breaks it is a chore to manage them when adding or removing text. If you don't add line breaks you have to manually scroll to find the proper insertion points.
TL;DR do as Github and many other other markdown editors do, and take the burden of line wrapping of the technical writer's shoulders :)

@josevalim we support Alt + z for toggling wrapping, would it make sense to have wrapping enabled by default for Markdown specifically?

Is Alt + z something that should work already? I tried it to no avail (standard en-US keyboard, and US locale, UTF-8). To me defaulting to wrapping enabled would make a lot of sense (much more so than not wrapping by default).

It should work while within an editor. Alternatively you can right-click and it should show a menu like this:

Note that it applies per editor though.

@josevalim I think it makes sense to wrap Markdown, because it doesn't matter when rendering, but I don't think we should apply the same rule to code, no?

I don't like to wrap Markdown though, because it makes the source ugly. I am fine with whatever default but we should make swapping easier. :)

Ah good point, yeah. We could try to wrap paragraph content when persisting, not sure if that's the best idea though? Otherwise I'm ok with a global wrapping config, but if it applies to all editors, then we should keep it disabled by default.

We could also have two options: one for text and one for code.

@jonatanklosko wrote:

Alternatively you can right-click and it should show a menu like this

No, unfortunately there's no word wrapping option in the menu.

@aschrijver ah, it's on main, but the latest release doesn't have it :)

Maybe - just brainstorming - a 'Code block' could be a separate inclusion entry to choose from, just like 'Markdown' and 'Section'. And then with 'Elixir' being a special code-block (and possibly the default lang that's chosen), but with potentially other languages becoming similarly executable codepen.io-style inline.
Then in code blocks you must explicitly enter carriage return / newlines, while markdown blocks allows typing text in one flow as people expect when working in most document editors and markdown tools.

"Code block" is already unambiguous, though there may be other editor instances with code like SQL. The configuration is only really relevant for Markdown, I think there's no good reason to wrap regular code (apart from very specific instances, where it can be enabled temporarily with the shortcut).

A configuration exclusively for wrapping Markdown then works for me (and we can default to true).


Units do not conform to SI, IEC standards

From Wikipedia:

Note that:

Bytes are capital B
In SI, kilobyte is kB (lowercase k)

So it should be along the lines of:

SI: ['B', 'kB', 'MB', 'GB', 'TB', 'PB', 'EB', 'ZB', 'YB']
IEC: ['B', 'KiB', 'MiB', 'GiB', 'TiB', 'PiB', 'EiB', 'ZiB', 'YiB']
JEDEC: ['B', 'KB', 'MB', 'GB', 'TB', 'PB', 'EB', 'ZB', 'YB']

You are right, can help me give me a pr?

https://github.com/hustcc/filesize.js/commit/09ed44a49602f8c00a351f85382e88e46a1895d6

@hustcc Has this change been released to NPM? The latest version (v2.0.0) still uses lowercase b.

@workmanw I ended up updating / using this instead: https://github.com/mvasilkov/human-readable

@mvasilkov Thanks for the quick response!


fix: path to rule file in README

This fixes the link to the supported rule in the README.

@All-contributors please add @bennettdams for docs


Fix dark mode flash

Bug Report
Description
When dark mode is enabled, the light mode color scheme flashes momentarily until the JavaScript is rendered and adds the necessary classes to the page.
Possible solution
Handle theme-related scripts in the <head> so that they are rendered before the page loads.
See:

https://stackoverflow.com/a/63033934
https://stackoverflow.com/a/71800065

This may simply be updated on the example templates as well as the documentation pages.


Remove "or available on this machine" from GemNotFound error in --path mode

Closes #4854.
@RochesterinNYC @indirect @segiddins

@homu delegate=RochesterinNYC

:v: @RochesterinNYC can now approve this pull request

@b-ggs some specs seem to be failing. Looks like spec/commands/lock_spec.rb:88 was also asserting on "available on this machine"

I've already tried rebasing from master, but still keeps failing on that one spec - which is odd, since I didn't even touch anything related to that spec.

@RochesterinNYC Could you re-run the specs for this? It might be an issue on Travis' end.
Failures:
  1) bundler plugin install shows proper message when gem in not found in the source
     Failure/Error: expect(out).to include("Could not find")

       expected "Fetching source index from file:/home/travis/build/bundler/bundler/tmp/gems/remote1/\nCould not locate Gemfile or .bundle/ directory" to include "Could not find"
       Diff:
       @@ -1,2 +1,3 @@
       -Could not find
       +Fetching source index from file:/home/travis/build/bundler/bundler/tmp/gems/remote1/
       +Could not locate Gemfile or .bundle/ directory

Restarting the tests on Travis...

For some reason, running Bundler.app_cache.exist? breaks something, causing the failure.

Still looking, but is there any other way to check if cache exists?

@b-ggs it just looks like a different error message is being printed for the one test now, so the expectation can likely just be updated

@b-ggs ping?


Release request of SDK (for net), for respective stable version of swagger "2023-12-30"

Please do not merge this PR now, please consider it in draft.
Reason: I can see a modification in autorest.md to remove operation "OperationProgress_Get". But, we need this in stable version "2023-12-30".


R-click cell menu does not allow inline breakpoint unless paused on breakpoint

Applies To

[X] Notebooks (.ipynb files)
[ ] Interactive Window and/or Cell Scripts (.py files with #%% markers)

What happened?
When debugging a cell a breakpoint can halt execution.
Inline breakpoints permit breaking at steps not associated with a line.
These can only be applied, when paused, in a menu i.e. the option is not present.
Note that the shortcut can still apply a working inline breakpoint when not in an active debug.
This appears to be a UI only problem the breakpoints work as expected once applied by either method.
VS Code Version
1.79.2
Jupyter Extension Version
v2023.5.1101742258
Jupyter logs
No response
Coding Language and Runtime Version
No response
Language Extension Version (if applicable)
No response
Anaconda Version (if applicable)
No response
Running Jupyter locally or remotely?
Remote

Sorry for never getting back to you on this, please can you let us know if you are still running into this issue.
Btw, please do update to the latest version of VS Code, Jupyter and Python extensions.

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.
Happy Coding!


Lazy initialization for the FAISS library

Allow the faiss_knn_wrapper to always be imported (even if faiss is not installed) - so that docs can be built. new function "is_available" checks if faiss is installed. Fix #111

Not sure if there is a fix for the issue identified by Codacy. We need to try importing faiss to know if it is available, but then we don't do anything with this import.

I think we can leave like that for now. I have no idea if there is a fix for that.


Error: Trunk already exist in cache when initializing a node

Describe the Bug:

A trunk initializing conflict was observed when the controller was adding a node and initializing its trunk resources. Looks like the node was failed to be initialized for some reason and removed by the controller. During the other attempts adding the node, the trunk interface was successfully initialized and added into cache. Afterwards the other attempt tried to create and add a trunk interface for the same node again. Since the cache uses node name as key for trunk resource, the attempt failed the node was failed to be initialized. Without correctly removing the trunk record in cache, reconciling keeps failing initializing the node resource and resulted in no pods with SGP feature can be created in the node.
Observed Behavior:
Pods using the Security Group for Pods feature can not be created successfully due to the error in VPC CNI log.
{"level":"info","ts":"2022-07-12T21:59:50.620Z","caller":"rpc/rpc.pb.go:713","msg":"Send AddNetworkReply: failed to get Branch ENI resource"}

The node has correct capacity and allocable branch ENIs and trunk ENI attached.
The failing pods have request/limit branch ENI annotated but don't have branch interface network annotation added.
Expected Behavior:
The node should be added into managed pool successfully even some type of race/conflict occurs. The node's trunk/branch interfaces resources should be successfully initialized. Pods scheduled to the node should have their branch network resource annotation added successfully.
How to reproduce it (as minimally and precisely as possible):
N/A. This could be caused by rare race condition between routines or incorrect fallback when a conflict was encountered.
Additional Context:
{"level":"info","timestamp":"2022-07-11T13:09:28.873Z","logger":"node validation webhook","msg":"update request received from aws-node","node":"ip-x-x-x-x.us-west-2.compute.internal"}
{"level":"info","timestamp":"2022-07-11T17:58:28.121Z","logger":"node manager","msg":"node removed from data store","node name":"ip-x-x-x-x.us-west-2.compute.internal","request":"delete"}
{"level":"info","timestamp":"2022-07-11T17:58:28.122Z","logger":"controllers.Node","msg":"deleted the node from manager","node":"/ip-x-x-x-x.us-west-2.compute.internal"}
{"level":"info","timestamp":"2022-07-11T18:05:34.315Z","logger":"controllers.Node","msg":"adding node","node":"/ip-x-x-x-x.us-west-2.compute.internal"}
{"level":"info","timestamp":"2022-07-11T18:05:57.309Z","logger":"node manager","msg":"node was previously un-managed, will be added as managed node now","node name":"ip-x-x-x-x.us-west-2.compute.internal","request":"update"}
{"level":"error","timestamp":"2022-07-11T18:38:28.359Z","logger":"node manager","msg":"removing the node from cache as it failed to initialize","node":"ip-x-x-x-x.us-west-2.compute.internal","operation":"Init","error":"failed to load instance details: failed to find instance i-xxxxxxxxxx details from EC2 API","stacktrace":"github.com/aws/amazon-vpc-resource-controller-k8s/pkg/node/manager.(*manager).performAsyncOperation\n\t/workspace/pkg/node/manager/manager.go:307\ngithub.com/aws/amazon-vpc-resource-controller-k8s/pkg/worker.(*worker).processNextItem\n\t/workspace/pkg/worker/worker.go:147\ngithub.com/aws/amazon-vpc-resource-controller-k8s/pkg/worker.(*worker).runWorker\n\t/workspace/pkg/worker/worker.go:132"}
{"level":"info","timestamp":"2022-07-11T18:41:20.846Z","logger":"controllers.Node","msg":"adding node","node":"/ip-x-x-x-x.us-west-2.compute.internal"}
{"level":"info","timestamp":"2022-07-11T18:41:20.846Z","logger":"node manager","msg":"node added as a managed node","node name":"ip-x-x-x-x.us-west-2.compute.internal","request":"add"}
{"level":"info","timestamp":"2022-07-11T18:42:37.930Z","logger":"node manager.node resource handler","msg":"node is not initialized yet, will not advertise the capacity","node name":"ip-x-x-x-x.us-west-2.compute.internal"}
{"level":"info","timestamp":"2022-07-11T18:42:42.470Z","logger":"branch eni provider","msg":"created a new trunk interface","node name":"ip-x-x-x-x.us-west-2.compute.internal","request":"initialize","instance ID":{},"trunk id":"eni-xxxxxxxxx"}
{"level":"info","timestamp":"2022-07-11T18:42:42.470Z","logger":"branch eni provider","msg":"trunk added to cache successfully","node":"ip-x-x-x-x.us-west-2.compute.internal"}
{"level":"error","timestamp":"2022-07-11T18:42:53.725Z","logger":"branch eni provider","msg":"trunk already exist in cache","node":"ip-x-x-x-x.us-west-2.compute.internal","error":"trunk eni already exist in cache","stacktrace":"github.com/aws/amazon-vpc-resource-controller-k8s/pkg/provider/branch.(*branchENIProvider).addTrunkToCache\n\t/workspace/pkg/provider/branch/provider.go:421\ngithub.com/aws/amazon-vpc-resource-controller-k8s/pkg/provider/branch.(*branchENIProvider).InitResource\n\t/workspace/pkg/provider/branch/provider.go:172\ngithub.com/aws/amazon-vpc-resource-controller-k8s/pkg/node.(*node).InitResources\n\t/workspace/pkg/node/node.go:130\ngithub.com/aws/amazon-vpc-resource-controller-k8s/pkg/node/manager.(*manager).performAsyncOperation\n\t/workspace/pkg/node/manager/manager.go:305\ngithub.com/aws/amazon-vpc-resource-controller-k8s/pkg/worker.(*worker).processNextItem\n\t/workspace/pkg/worker/worker.go:147\ngithub.com/aws/amazon-vpc-resource-controller-k8s/pkg/worker.(*worker).runWorker\n\t/workspace/pkg/worker/worker.go:132"}
{"level":"error","timestamp":"2022-07-11T18:42:53.725Z","logger":"node manager.node resource handler","msg":"failed to init resource","node name":"ip-x-x-x-x.us-west-2.compute.internal","error":"trunk eni already exist in cache","stacktrace":"github.com/aws/amazon-vpc-resource-controller-k8s/pkg/node.(*node).InitResources\n\t/workspace/pkg/node/node.go:145\ngithub.com/aws/amazon-vpc-resource-controller-k8s/pkg/node/manager.(*manager).performAsyncOperation\n\t/workspace/pkg/node/manager/manager.go:305\ngithub.com/aws/amazon-vpc-resource-controller-k8s/pkg/worker.(*worker).processNextItem\n\t/workspace/pkg/worker/worker.go:147\ngithub.com/aws/amazon-vpc-resource-controller-k8s/pkg/worker.(*worker).runWorker\n\t/workspace/pkg/worker/worker.go:132"}
{"level":"error","timestamp":"2022-07-11T18:42:53.725Z","logger":"node manager","msg":"removing the node from cache as it failed to initialize","node":"ip-x-x-x-x.us-west-2.compute.internal","operation":"Init","error":"failed to init resources: trunk eni already exist in cache","stacktrace":"github.com/aws/amazon-vpc-resource-controller-k8s/pkg/node/manager.(*manager).performAsyncOperation\n\t/workspace/pkg/node/manager/manager.go:307\ngithub.com/aws/amazon-vpc-resource-controller-k8s/pkg/worker.(*worker).processNextItem\n\t/workspace/pkg/worker/worker.go:147\ngithub.com/aws/amazon-vpc-resource-controller-k8s/pkg/worker.(*worker).runWorker\n\t/workspace/pkg/worker/worker.go:132"}

Environment:

Kubernetes version (use kubectl version): EKS 1.21
CNI Version: v1.11.0
OS (Linux/Windows): Linux

Possibly fixed in #289?


Publishing to several destinations

I'm using sbt-s3-resolver plugin to publish artefacts to out company's S3 repository. Additionally I want to publish to Bintray, but so far I can't figure out how to do both.
My default configuration sets publishTo setting to an S3 resolver, so when I run publish it uploads artefacts to S3. Then I'm trying to run bintray::publish and unfortunately it runs same S3-publishing again.
Setting publishTo seems to be correct:
> show publishTo
[info] Some(Raw(snapshots.era7.com S3 publishing bucket))
> show bintray::publishTo
[info] Some(Raw(Bintray-Maven-Publish-ohnosequences-maven-ivy-s3-resolver))

But I think that bintray::publish just delegates to *::publish:
> inspect bintray::publish
[info] Task: Unit
[info] Description:
[info] 	Publishes artifacts to a repository.
[info] Provided by:
[info] 	{file:/Users/laughedelic/dev/ohnosequences/ivy-s3-resolver/}ivy-s3-resolver/*:publish
[info] Defined at:
[info] 	(bintray.BintrayPlugin) BintrayPlugin.scala:122
[info] Delegates:
[info] 	*:bintray::publish
[info] 	*:publish
[info] 	{.}/*:bintray::publish
[info] 	{.}/*:publish
[info] 	*/*:bintray::publish
[info] 	*/*:publish
[info] Related:
[info] 	*:publish

Also, I see that here publish as defined in bintray plugin depends on publishTask(publishConfiguration, deliver):
https://github.com/sbt/sbt-bintray/blob/master/src/main/scala/BintrayPlugin.scala#L133-L136
Maybe publishConfiguration should be somehow scoped there more precisely?

My main questions is: is it possible to use default publish with one resolver and bintray::publish (or whatever equivalent task) with another resolver? Is there a scoping problem in the plugin or am I doing something wrong?

OK, so I realised that this is a more general issue and solved it by writing a plugin that can publish to  several repositories: sbt-publish-more. This issue can be closed.


[Icon Request] Support for Nestjs

Nestjs is a nodejs framework based on angular modular architecture, (also built with ts ❤), so it would require the same work as Angular projects as there are kind of the same extensions.

[x] I'm sure this issue is not a duplicate.

[x] I want to create an icon request

Type: extension

Icon Name: name

Sample original Icon:

Extensions:

*.controller.ts
*.module.ts
*.service.ts
*.guard.ts
*.pipe.ts
*.decorator.ts
*.interceptor.ts
*.filter.ts
*.gateway.ts
*.adapter.ts
*.middleware.ts

Filenames: nestconfig.json

Language ids: *ts* or *js*

More info: docs

@kamilmysliwiec I think this could be nice for vscode user. Also, did I missed / added extensions ? e.g. I was unsure about .entity.ts as this is more coupled to typeorm
edit: Also do you have svg available ?

I got my hands on the SVG icon.

Nice ! By the way does the logic behind reloading icons like you do for angular projects needs a serious amount of work to support other kind of projects like this one ?
If yes I could help but I won't have much time until 2018.

It requires knowledge of how PAD and our i18n service work. So I guess if you haven't familiarized yourself yet with the codebase then it's quite an amount.

This framework is awesome btw

@JimiC Have you done any progress with this icon request? I am willing to do some work on it ❤ (Angular Fan here).

This requires PAD (project auto detection) knowledge so I wouldn't recommend getting involved.


The type of file changed after I rename some file

When I rename some files, the file type will change to "file" instead of the original file type. Please consider solving it. I have to open the native win 10 file explorer every time I need to rename some file. Thanks a lot.

Happens if you have the option to show the file extension disabled

Duplicate of #873


cf set-env suggests restage without app name

Command
$ cf set-env myapp SOME_ENV_VALUE http://<IP_ADDRESS>:8080
Setting env variable 'SOME_ENV_VALUE' to 'http://<IP_ADDRESS>:8080' for app myapp in org someorg / space somespace as someuser...
OK
TIP: Use 'cf restage' to ensure your env variable changes take effect

CLI Version
cf version 6.16.1+924508c-2016-02-26
Issue
It would be great if instead of cf restage it would say cf restage myapp. I've seen this when I push an app and it fails and suggests I do cf logs myapp --recent.

Thanks for the suggestion! I'll ask the team to take a look.
Regards,
Dies Koper
CF CLI PM

We have added supported for this in cf CLI 6.19.0, released today. Thanks again for the suggestion!
https://github.com/cloudfoundry/cli#downloads
Regards,
Dies Koper
CF CLI PM


Update request: Librewolf 130.0 → 131.0.2-1 (NixOS Unstable)

Package name: Librewolf
Latest released version: 131.0.2-1

Current version on the unstable channel: 130.0-3
Current version on the stable/release channel: 131.0.2-1

Librewolf is on v130 for NixOS/Nixpkgs unstable while it's on 131 for stable. This is a problem as Librewolf/Firefox 131.0.2 fixes the critical vulnerability CVE-2024-9680.

[x] Checked the nixpkgs pull requests

Notify maintainers @dotlambda @squalus

Note for maintainers: Please tag this issue in your PR.

Add a :+1: reaction to issues you find important.

https://github.com/NixOS/nixpkgs/pull/347598

#347598

I'm rather confused as that appears to show on Nixpkgs 24.05 but not unstable, why?

https://nixpk.gs/pr-tracker.html?pr=347598
https://wiki.nixos.org/wiki/Channel_branches#Channel_update_process

Gotcha, sorry new to nixos.


Fix test severity to warn for PLUTO when running compile_python_reqs

PLUTO build fails when compiling python reqs (example #1216) because of incorrect dbt test severity. This PR changes severity from error to warn for python reqs builds.
Reference for GHA syntax used in the fix.

@sf-dcp Just confirming my understanding: This is the case where we've written a test that detected an issue, but not yet fixed the underlying issue? (e.g. incorrect BBL counts)
If so, I'm wondering if we should set the TEST_SEVERITY at the level of the nightly_qa/compile_python_reqs jobs.
Or maybe we could set a different severity for tests that are expected to fail in DBT via use of a different env var. I'm thinking that if we had some override env var in our builds like IGNORE_EXPECTED_FAILING_DBT_DE_CHECKS, we could engineer things in DBT so that:

Manual Builds of PLUTO fail until the issue is resolved.

Which would be the best of both worlds. Curious @damonmcc 's thoughts

Yes, your understanding is correct: this env variable is to set severity level when running dbt tests.
Note that this variable sets severity level for the whole dbt project; i.e. it applies to all tests. For instances where we want some tests to fail regardless, we can override their severity level by modifying the test's cofig object.
The tests I wrote so far don't need to fail actual builds in nightly qa and compile python requirements. We discussed it here.
I would prefer to keep this env var at pluto build job as it so PLUTO test config can be found in one place.


Mao "continuous mode" ("Dauermodus") for Opener to a state topic and to binaryState

Currently there appears to be no way to enable or disable "continuous mode" ("Dauermodus") for the Opener. Also when "continuous mode" is enabled, the "lock" created for the Opener is still shown in a "locked" state.

Hi,
You can enable or disable CM (continuous mode) by sending the "activatCM" and "deactivateCM" commands. You're right this isn't yet reflected in the state, because of the strange way the bluetooth API signals this. Instead of changing the state it sets some bit somewhere else to show that CM is active - this could be easily mapped though by the ESP to reflect it in the state.

Ah, thanks I must have overread that in the documentation. Too me, ideally there would be a separate state topic for CM itself (which should be mapped to HA autodiscovery as a configuration switch) and it should be reflected in the binaryState of the lock to accurately reflect whether the controlled door is "(ring to) open".

I think it still has to be handled via commands, because it interacts with the other commands ... for example writing "activateRTO" should disable CM if active.
If it appears as a seperate topic, it would imply this should work:

activate RTO
activate CM
deactivate CM
device switches back to RTO because it was active before

What would actually happen though it would switch back to "locked", which isn't very intuititive.

Are you sure this is the way it works? I set CM via the official app and then activated and deactivated RTO via unlocking the lock entity in HA -  CM was still active when I checked in the app.

Not a 100% :D. I'll do some reverse engineering to see how the firmware really behaves - it's not clearly stated in the documentation.

With the latest release it's not at least shown in the state node, and the binary state is updated accordingly. I'll have to see about adding a sensor, the API is quite confusing about this. It seems the NUKI App can indeed update CM and RTO independently.

Would it maybe be better to map the behavior of the HA lock entity to enabling/disabling CM instead of RTO (which has a maximum duration of 1 hour) for the lock/unlock services?


Example read and write data?

Hi everyone,
i would like to use this module to send and receive data between a raspberry pi and an arduino using hm-11 ble module.
I can find peripheral without problem and connect to it, but i've some problem with data transfer.
I've to use readHandle and writeHandle, it is right?
Thanks in advance!

Here is an example how I handled reading and writing characteristics:
characteristic.read(function (error, data) {});
                    characteristic.on('read', function (data, isNotification) {
                        \\ data is read
                    }.bind(this));

characteristic.write(payload, false, function (error) {
                            if (!error) {
                            \\ write succesfull
                            } else {
                              \\ write unsuccessfull
                            }
                        }.bind(this));

Hope this helps to give you a general direction. Key is to discover your characteristics before reading/writing operations

@ManuelOverdijk thanks for helping out!
@simar88 here are some resources:

wiki:
https://github.com/sandeepmistry/noble/wiki/Getting-started#reading-a-characteristic
https://github.com/sandeepmistry/noble/wiki/Getting-started#getting-notified-on-characteristic-value-change
code for other modules which maybe similar to the HM-11
https://github.com/shokai/blendmicro-node
https://github.com/xorbit/node-hm-ble
https://github.com/bbx10/node-cc2540
https://github.com/bbx10/node-nRF8001

P.S.: Gittter is perfect for questions like this - https://gitter.im/sandeepmistry/noble

Hi @sandeepmistry @ManuelOverdijk thanks for yours reply!
I'll try some things suggested in these day becuase i'm migrating from the NRF8001 library to some other because i'm changing BLE module.
NRF8001 node.js module works very well but not with hm-11, so i need to try other solutions.
Since it's very simple, event driven and based on noble i thought that also it has the same simplicity of implementation but i've seen some difference.
Thanks again for your help!

@simar88 I wouldn't expect the modules I linked to, to work as is with the hm-11. You'll need to modify to match the advertisement and UUID's that are in the firmware you are running.

So i need an explanation about charateristics. To use them i have to discorver peripheral and then loop through services and then loop through charateristics. It's right?

Yes. See this for an explanation: https://epxx.co/artigos/bluetooth_gatt.html


Add pointer events none to summary header to fix google tag manager events

Will resolve #508

  Pointer events need to be turned off on all elements within the summary


Update these code samples to work with SDK 12.2.0

The methods and functions in 12.2.0 are nicer than the methods in 11.0.0. It's the little things, like the nrf_drv_timer_ms_to_ticks method for example.
Could we update all of these sample apps to work with 12.2.0? Is there a reason that we should not do that? I've bought some legacy nRF51822 devices; I know that they are technically deprecated parts but they are excellently priced and should be possible to use to get the job done so I want to try and use the latest SDK with them if possible.

Examples updated for SDK 12.2.0.


Moving while growing causes issues.

If you move during the growing animation there is a high chance you can be teleported into the void. Sometimes only a couple of hundred blocks into the void but other times extremely large into the negative.

 Lastest version.

Received similar report on curse, I'll take a look, thanks for your input :)

Strange.....  i have never experinced it....

Nah I'm experiencing it all the time when I'm big
Also when you're small and land onto ground there is a little bumping effect
Still trying to find how to fix that all btw

Happens to me too


Resolve Slow HTTP POST vulnerability

Current versions of Callimachus have been determined to be susceptible to the "Slow HTTP POST vulnerability":
https://community.qualys.com/blogs/securitylabs/2011/07/07/identifying-slow-http-attack-vulnerabilities-on-web-applications
Adjust the timeouts on our connections to avoid this vulnerability.

If the request body buffer is empty (after the grace period of 10s) the TCP connection is closed. The grace period is reset whenever the request body buffer is reduced from full capacity.
This should allow the server to take its time reading the request body, but not permit the client to force it to doing so.


Allow to bypass validation checks for publishBlockV2

When creating blocks locally, most of the gossip checks would have already been covered by the process of creating the block itself (at least in Teku), so it makes sense to add an option to bypass validation checks altogether and publish the block immediately. This way there would be no additional delays (even if small) of broadcasting the block to the network when using v2 for publishing.

When creating blocks locally, most of the gossip checks would have already been covered by the process of creating the block itself (at least in Teku)

This is only true if the block is published via the same beacon node that created it, in which case running gossip validation again does not make much sense. In a multi node setup, does this mean the validator client would have to keep track of which node produces the block and to which it is published, and set broadcast_validation accordingly?
In Lodestar, we already skip gossip validation if the block is published to the same beacon node but it's not decided by the validator client but rather the beacon node which has a cache of produced block roots, and if it was produced locally, we skip gossip validation.

When creating blocks locally, most of the gossip checks would have already been covered by the process of creating the block itself (at least in Teku)

This is only true if the block is published via the same beacon node that created it, in which case running gossip validation again does not make much sense. In a multi node setup, does this mean the validator client would have to keep track of which node produces the block and to which it is published, and set broadcast_validation accordingly?
In Lodestar, we already skip gossip validation if the block is published to the same beacon node but it's not decided by the validator client but rather the beacon node which has a cache of produced block roots, and if it was produced locally, we skip gossip validation.

I agree skipping validation in the beacon node which created it is the valid scenario in this case. But I can argue that it also makes sense in a multi-node setup. The beacon node which created the block would have already published the block, so if for some reason, other beacon nodes fail the gossip validation, the result would be that the block would just be propagated bit slower and they can get downscored a little bit in those rare cases. Ultimately, I think it's nice to have the option to not do any validation on the VC level. Since it's not a default option, clients can choose to use it however they want.

What is the magnitude of these validation delays?

In Lighthouse I'm pretty sure the delay from gossip verification is trivial (around ~5ms). For us it was the code complexity of adding gossip verification and dealing with duplicate caches that was hard. But we can't remove this complexity while gossip verification is an option, so IMO we may as well keep it by default
Also open to adding the no_verification param if it is beneficial in clients. I think we just need to know if we're hunting performance or simplicity

Ditto nimbus, it's (very) fast and nowadays just part of the "incoming external data" flow that applies to anything going out on gossip (and into the block database) whether that be re-broadcasting or rest-based data - even if a flag was added, it is likely we would do the checks anyway simply because it's more simple this way and provides a cheap bug safety net.

What is the magnitude of these validation delays?

In Teku, gossip validation seem to average around ~11ms. But occasionally, there are some outliers which take longer. For us specifically, for local blocks, we would like to skip it altogether and would be cleaner to do on the VC side. But if for other clients, there is no value in having an option to do no validation for this endpoint, I am happy to implement similar functionality as Lodestar that @nflaig mentioned.

For us specifically, for local blocks, we would like to skip it altogether and would be cleaner to do on the VC side. But if for other clients, there is no value in having an option to do no validation for this endpoint, I am happy to implement similar functionality as Lodestar that @nflaig mentioned.

Imo doesn't hurt to have this option, even though we will not be using this in production, we had a use case for it during testing and Lodestar already supports a none value, it can only be configured internally right now and not via CLI. If we keep gossip as default, I don't see an issue other than clients not supporting it right now, if we wanna be strict about it would require to bump the api, but that seems a bit overkill to me.

For us specifically, for local blocks, we would like to skip it altogether and would be cleaner to do on the VC side. But if for other clients, there is no value in having an option to do no validation for this endpoint, I am happy to implement similar functionality as Lodestar that @nflaig mentioned.

Imo doesn't hurt to have this option, even though we will not be using this in production, we had a use case for it during testing and Lodestar already supports a none value, it can only be configured internally right now and not via CLI. If we keep gossip as default, I don't see an issue other than clients not supporting it right now, if we wanna be strict about it would require to bump the api, but that seems a bit overkill to me.

I like none better than no_validation. Modified the PR.

Imo doesn't hurt to have this option, even though we will not be using this in production, we had a use case for it during testing and Lodestar already supports a none value, it can only be configured internally right now and not via CLI. If we keep gossip as default, I don't see an issue other than clients not supporting it right now, if we wanna be strict about it would require to bump the api, but that seems a bit overkill to me.

What's the utility of specifying an option only useful for internal testing as part of the beacon API?
Also, to Jacek's point, a bit more concretely, Nimbus routes all these functions through (for those who might want to see details) routeSignedBeaconBlock, which does this validation as an integral part of block sending, separately from the specifics of any given beacon API function. While it's possible to adds a bypass of this, it would indeed complicate the funnel-everything-into-uniform-processing design for little apparent gain.
So far this PR seems surprisingly unmotivated by specific scenarios or use cases to warrant this, and handwaving about, well it's harmless or not that complicated ("I don't see an issue other than clients not supporting it right now") still creates a situation where there's an eventual expectation to implement this.
I'll be a bit more pointed: even if it's 20ms or 30ms, say, why are people waiting to send blocks late enough any of this matters?
(If it's because that's what MEV timing game players want, well.)

So far this PR seems surprisingly unmotivated by specific scenarios or use cases to warrant this, and handwaving about, well it's harmless or not that complicated ("I don't see an issue other than clients not supporting it right now") still creates a situation where there's an eventual expectation to implement this.

I didn't wanna imply "not that complicated" to implement, from this PR, it seems for Teku it would be lower complexity to adopt it via query param instead of implementing something like Lodestar. For Nimbus, it seems higher complexity which is totally fair. That's why we have this discussion, to get a better picture / different perspectives and trade offs.

I'll be a bit more pointed: even if it's 20ms or 30ms, say, why are people waiting to send blocks late enough any of this matters?

I am not running Teku in my setup right now, but if I were I would like my locally built blocks to be gossiped faster if there is no clear downside to it. We shouldn't avoid optimizations to local block building just because most of the network is using MEV-boost, there are still a lot of people (especially solo stakers) which do not use it or have really high min-bid, and for those, reducing the internal latency is even more important as they might not have the best internet connection.

One of the main inspirations for us was that v1 would eventually be deprecated and we want to keep the same functionality as of today for locally created blocks whilst still using v2 (Teku VC still uses v1).

One of the main inspirations for us was that v1 would eventually be deprecated and we want to keep the same functionality as of today for locally created blocks whilst still using v2 (Teku VC still uses v1).

Can't speak to specifics of non-Nimbus implementations on how exactly the validation is handled here, but https://ethereum.github.io/beacon-APIs/?urls.primaryName=v2.5.0#/Beacon/publishBlock states that:

Instructs the beacon node to broadcast a newly signed beacon block to the beacon network, to be included in the beacon chain. A success response (20x) indicates that the block passed gossip validation and was successfully broadcast onto the network. The beacon node is also expected to integrate the block into state, but may broadcast it before doing so, so as to aid timely delivery of the block. Should the block fail full validation, a separate success response code (202) is used to indicate that the block was successfully broadcast but failed integration. After Deneb, this additionally instructs the beacon node to broadcast all given blobs.

Emphases added.
As specified, publishBlock (V1, retroactively) already involves validation. Some BNs may broadcast it before doing so, but that's framed as a non-default, optional behavior.

Thanks all for the good feedback! We internally started the conversation on this topic several times, without reaching an actual decision. But reading throughout the thread I'm know lean to not having this option but instead leave the BN to responsible for eventual optimizations (like caching ala Lodestar implementation @nflaig).
Question: how you deal with [IGNORE] The block is not from a future slot rule? Are you considering this as a gossip validation failure? It won't be a problem if we add the "local built blocks cache", but in a multi-BN scenario, if VC deals only with lagging BNs it might lose the proposal.
My current feeling is to leave it as a validation failure (current teku behaviour). In general all IGNORE are considered failure with the exception of "already seen block".

Thanks for the discussion all. :) We will implement similar functionality as Lodestar, so none validation option wouldn't be necessary. If at some point, clients find it could be useful, we can always refer to this PR. Closing for now.


removed: variables for skipping install in favor of tags

Using a variable to skip installation is redundant because the same result can be achieved with tags. Tags already provide the flexibility to skip the installation or other sections of the roles, such as configuration tasks.

Should we add something to the docs about this?

Not sure, it's fairly standard practice to use tags in ansible. I added a assert task to the preflight which instructs users to use --skip-tags instead of the variable if they have the variable defined.

superseded by #425


POET logo

Could anyone please send me the original copy of the POET logo (as seen in the 'Overall Architecture' section of the readme).
I have resumed development on this project and would like to use the logo. I've been advised that @dongxuDX you were the main developer, your help would be appreciated.

Hi @PouriaSterling,
Sorry for the late response. Please find the pic you requested in the attached.

Please be aware that the logo is due to @sabiipoks. I did nothing here.
Enjoy.

Hi @PouriaSterling,
Sorry for the late response. Please send me a mail at<EMAIL_ADDRESS>I shall send you the file requested.
Also, please be advised that the logo is due to @sabiipoks. I did nothing here.
Cheers.


fix(tactic/gptf/backends/openai): detect windows and escape json for curl

LGTM, thanks Alex!

LGTM, thanks Alex!


accessibilityHelpContent view API proposal

wip https://github.com/microsoft/vscode/issues/209855

@mjbvz should I wait on the implementation until this is discussed/approved/merged next week?

You can merge api proposals before discussion as long as they are properly gated with the checkProposedApi calls


Move typing notification throttle back to 2s

@mmaxim @chrisnojima
Mike noticed that the server-side setTyping notification multiplied in March 2018 and asked for an explanation.  I checked that the throttle's still working, and discovered that the chat refactor in 93298a3c39c40 (merged March 8) lowered the throttle from every two seconds to every one second.
We don't have to merge this PR to move it back -- maybe the explanation of what happened is sufficient.  @mmaxim can decide.

I wonder why codecov thinks there are coverage changes.

I think the report generation is a bit flakey. Individual tests timeout which confuses codecov


Embed option

I don't really understand what the "embed" option does. Could you explain that one?

Embeds in Discord have different markdown parsing (custom link text). You need to set that option to get the correct output for embeds.

Ah thanks a lot... Maybe explain that a bit better in the README?


custom-function-metadata should not use fs in parseTree

Expected behavior
parseTree should be exported independently without references to fs.
i.e. there should be a file called parseTree.ts that only includes parseTree code and does not include generateCustomFunctionMetadata

I think what is needed here is to rename generate.ts to parseTree.ts, and then move generateCustomFunctionsMetadata() to a new generate.ts file. Then main.ts can export from both generate.ts and parseTree.ts.

Isn't this the main part of what @wandyezj existing PR is trying to do or am I missing something?

This was fixed by @akrantz


Plot label and figure description are too close in the C19 Data Portal overview tab

We agreed on removing the titles from the plots


Ability to regenerate sdkconfig.defaults programmatically (IDFGH-6546)

Is your feature request related to a problem? Please describe.
I would like to regenerate some sdkconfig.defaults file.
Currently I remove sdkconfig. copy the right sdkconfig.defaults file, idf.py menuconfig and press d to save the new regenerated default.
Maybe I can automate it with expect. Or maybe there is already a way and I don't know about it.
Describe the solution you'd like
idf.py refresh_default_config
Describe alternatives you've considered
I could try with using expect and control idf.py menuconfig programmatically that way but it seems a bit of a hack
Alternatively it would be nice if in the build directory there was a generated default file anytime idf.py build or idf.py app is called.

I think this was recently implemented by @dobairoland in https://github.com/espressif/esp-idf/commit/5118dd7cf39041eb0aabd1cdfceb5726cedac137. Could you please give idf.py save-defconfig a try, if you are using the recent master branch?

@igrr this looks exactly like what I need!
Unfortunately we only use stable releases, right now we are on 4.3.2 waiting for 4.4 - I guess we'll have to wait for a later release that will include this but that's fine! thank you very much for pointing this to me! Shall I close the issue or? cheers

Yes @greenaddress. This will be available starting with v5.0. However, you can cherry-pick the commit into your ESP-IDF copy and use it. It should not break your stable release.


Revert "Welcome! Let's resolve a conflict"

Reverts holy-motors/merge-conflicts#1
Something is wrong

Please review


Bug plotly embed

this PR removes the editable button from plotly chart for the url embed into src

I don't see any update to the drag preview image. Did that have the edit option or not?

@rgerstenberger odd, it seems to work fine on my end. Not showing up for me.


added a couple of challenge ideas

I added  two possible challenges. Both of them originally used jQuery, but could be completed without it. The second one I added (100px box) came directly from a code test for a job.

:+1:


Issues when making libpostal work with C#

Hi!
I tried making libpostal work with C#, but after compilation of libpostal into a dll and trying to load it via C# code it shows this error:
Could not copy the file libpostal.dll because it was not found
I wasnt able to find anything on the web about this error.
Let me know how to fix it.

Hi,
Have you seen this...
https://github.com/mapo80/LibPostalNet
Think this could help you.
Phil


Document multiple attach points for probes

There isn't mention of comma separated lists of attach points. It's a
pretty handy feature so we should document it.

ok thanks


Combined Unis does not get canceled if one of them emits a failure

Hi, i was trying to execute some concurrent calls and found an unexpected behaviour. In the JavaDoc of  UniAndGroupIterable<O> unis(java.lang.Iterable<? extends Uni<?>> unis) in class UniZip it is written:

The produced Uni fires a failure event if one of the Unis fires a failure. This will cause the other Uni to be cancelled, expect if UniAndGroupIterable.collectFailures() is invoked which delay the failure event until all Unis have fires an item or failure event.

But i found that when i combine some unis without calling collectFailures() and one of them fails the rest of them are not cancelled and continue the execution.
I made a simple naive test that should reproduce the issue
package it.cabel.ecltitoli;

import io.smallrye.mutiny.Uni;
import org.junit.jupiter.api.Test;

import java.util.*;
import java.util.function.Function;

public class TestUniCombineAll {

    @Test
    void test() {

        List<Uni<Object>> emitters = new ArrayList<>();

        for (int i = 0; i < 10; i++) {
            int finalI = i;
            Uni<Object> emitter = Uni.createFrom().emitter(uniEmitter -> {
                safeSleep(finalI * 100);
                System.out.println("Complete " + finalI);
                uniEmitter.complete(finalI);
            });
            emitters.add(emitter);

        }

        emitters.add(Uni.createFrom().emitter(uniEmitter -> {
            safeSleep(350);
            System.out.println("Fail!!!");
            uniEmitter.fail(new Exception("This is a test failure"));
        }));

        Collections.shuffle(emitters);

        Uni.combine().all().unis(emitters)
            .combinedWith(Object.class, Function.identity())
            .subscribe().with(
                completed -> System.out.println("Completed " + completed.size()),
                fail -> System.out.println("Failed: " + fail.getMessage())
           );

    }

    private void safeSleep(int millis) {
        try {
            Thread.sleep(millis);
        }
        catch (InterruptedException e) {
            e.printStackTrace();
        }
    }
}

And if you run it a few times the output is similar to this (it may change a litle bit due to Collection.shuffle randomness)
Complete 5
Complete 4
Complete 0
Complete 8
Complete 1
Complete 7
Fail!!!
Failed: This is a test failure
Complete 2
Complete 3
Complete 6
Complete 9

Maybe there is something that i'm missing but i was expecting that after a failure all the remaining unis (the one that are still sleeping when the failure occurs) are canceled.
Is this a bug or maybe i'm doing something wrong? The mutiny library that i'm using is the one that comes with quarkus 2.2.1.Final ( i think it is version 1.0.0).

I haven't been able to reproduce this behaviour with the following quick and dirty extrapolation test case:
@RepeatedTest(100)
    void reproducer_677() {
        List<Uni<Integer>> unis = new ArrayList<>();

        for (int i = 0; i < 20; i++) {
            int finalI = i;
            Uni.createFrom().emitter(uniEmitter -> {
                safeSleep(finalI * 100);
                System.out.println("Complete " + finalI);
                uniEmitter.complete(finalI);
            });
        }

        unis.add(Uni.createFrom().emitter(uniEmitter -> {
            safeSleep(350);
            System.out.println("Fail!!!");
            uniEmitter.fail(new Exception("This is a test failure"));
        }));

        Collections.shuffle(unis);

        AtomicBoolean success = new AtomicBoolean();
        AtomicBoolean failed = new AtomicBoolean();
        Uni.combine().all().unis(unis)
                .combinedWith(Object.class, Function.identity())
                .subscribe().with(
                        completed -> {
                            success.set(true);
                            System.out.println("Completed " + completed.size());
                        },
                        fail -> {
                            failed.set(true);
                            System.out.println("Failed: " + fail.getMessage());
                        }
                );

        assertThat(success).isFalse();
        assertThat(failed).isTrue();
    }

    private void safeSleep(int millis) {
        try {
            Thread.sleep(millis);
        } catch (InterruptedException e) {
            e.printStackTrace();
        }
    }

The combination is consistently failed.
I suspect that you intended to run concurrent operations, but please note that everything is being executed on the same (subscription) thread. So each Uni blocks the thread to sleep, then passes the torch to the next Uni that sleeps, etc.

Hi @jponge maybe i explained myself wrong but even in my previous example the overall combination fails: when i subscribe after a while i receive a failure event that gets printed with the fail -> System.out.println("Failed: " + fail.getMessage()) lambda passed as second parameter to the subscribe() method. My concern was more on the fact that the operations that are blocked when the failure event is emitted are not canceled automatically and continue to execute.
I know that is a bad practice but if the concurrent tasks performs operation like a heavy computation, in the case of a failure all the remaining computation, succesfull or not, are "wasted". Is there any way to achieve this behaviour?

I haven't seen the blocked operations print anything when I ran it. Perhaps you were using an older version?


Quesnelia updates for acquisitions

Includes an new section - additional topics (not sure if weighted appropriately).

All set!
Molly Driscoll, MLIS
Sr. FOLIO Training Specialist
<EMAIL_ADDRESS>Mobile:<PHONE_NUMBER>
Visit EBSCO Academyhttps://connect.ebsco.com/s/academy and experience in-depth, complimentary, on-demand elearning opportunities, including personalized elearning paths!
She/her/hers
Twitterhttps://twitter.com/EBSCO | Facebookhttps://www.facebook.com/EBSCOInfoServices | LinkedInhttps://www.linkedin.com/company/ebsco-information-services | Instagramhttps://www.instagram.com/ebscoinformationservices/?hl=en | YouTubehttp://www.youtube.com/user/ebscopublishing | EBSCOposthttps://www.ebsco.com/blog
Download the EBSCO Mobile App from Google Playhttps://play.google.com/store/apps/details?id=com.ebsco.ebscomobile or the App Storehttps://apps.apple.com/us/app/ebsco-mobile/id1473281170
This message and its contents are confidential. If you received this message in error, do not use or rely upon it. Instead, please inform the sender and then delete it.
From: julianladisch @.>
Sent: Tuesday, May 14, 2024 10:46 AM
To: folio-org/docs @.>
Cc: Molly Driscoll @.>; Author @.>
Subject: Re: [folio-org/docs] Quesnelia updates for acquisitions (PR #356)
CAUTION: External E-mail
@julianladisch commented on this pull request.

In content/en/docs/Acquisitions/Finance/_index.mdhttps://github.com/folio-org/docs/pull/356#discussion_r1600177397:

@@ -155,16 +157,46 @@ Funds show information regarding an ongoing ledger with a budget for the current

Code (required). User-created, based on name. The code must be unique. It is recommended to use alphanumeric and intuitive codes.

Ledger (required). Select the ledger associated with the fund. A fund may only be associated with a single ledger.

Status (required). Select the status of the fund: Active, Frozen, or Inactive. Active means the fund is ongoing, Frozen means the fund has been put on pause, and Inactive means the fund is no longer in use. Note: The fund must be active to successfully open an order or for an invoice to be fully paid.

-*   Type. A category to describe the fund. Fiscal year rollover of funds is often defined by fund type, so definition of the type values should consider fiscal year rollover requirements. For example, endowment, or restricted. For more information about creating fund types, see [Settings > Finance > Fund types]({{< ref "/settings_finance.md#settings--finance--fund-types" >}}). Funds that are not assigned a fund type will be grouped under No fund type at fiscal year rollover.
-*   Acquisition units. If you only want particular users within certain acquisition units to be able to edit the fund, enter or select the Acquisition units from the drop-down list. You can select multiple units. If blank, any users with the appropriate permissions are allowed to edit the fund's information. For more information, see [Settings > Acquisition units]({{< ref "/settings_acquisition_units.md" >}}). PLease note: if the assigned acquisition unit restricts view, the fund will be filtered out of the selection list that appears in Fund distribution accordions on purchase order lines and invoices. Users will only be able to apply funds that are "public" or with which they share an acquisition unit.
+*   Currency. This field is prefilled based on the currency associated with the fiscal year when the fiscal year was created. For more information, see [Creating a Fiscal Year] (#creating-a-fiscal-year).
Can you remove the space between ] and ( to make the link work?

Reply to this email directly, view it on GitHubhttps://github.com/folio-org/docs/pull/356#pullrequestreview-2055633945, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AQHA5QTTFZXOZHPX3GSNX43ZCIPSLAVCNFSM6AAAAABGT23B4GVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDANJVGYZTGOJUGU.
You are receiving this because you authored the thread.Message ID: @.***>

All set!
Molly Driscoll, MLIS
Sr. FOLIO Training Specialist
<EMAIL_ADDRESS>Mobile:<PHONE_NUMBER>
Visit EBSCO Academyhttps://connect.ebsco.com/s/academy and experience in-depth, complimentary, on-demand elearning opportunities, including personalized elearning paths!
She/her/hers
Twitterhttps://twitter.com/EBSCO | Facebookhttps://www.facebook.com/EBSCOInfoServices | LinkedInhttps://www.linkedin.com/company/ebsco-information-services | Instagramhttps://www.instagram.com/ebscoinformationservices/?hl=en | YouTubehttp://www.youtube.com/user/ebscopublishing | EBSCOposthttps://www.ebsco.com/blog
Download the EBSCO Mobile App from Google Playhttps://play.google.com/store/apps/details?id=com.ebsco.ebscomobile or the App Storehttps://apps.apple.com/us/app/ebsco-mobile/id1473281170
This message and its contents are confidential. If you received this message in error, do not use or rely upon it. Instead, please inform the sender and then delete it.
From: julianladisch @.>
Sent: Tuesday, May 14, 2024 10:46 AM
To: folio-org/docs @.>
Cc: Molly Driscoll @.>; Author @.>
Subject: Re: [folio-org/docs] Quesnelia updates for acquisitions (PR #356)
CAUTION: External E-mail
@julianladisch commented on this pull request.

In content/en/docs/Acquisitions/Finance/_index.mdhttps://github.com/folio-org/docs/pull/356#discussion_r1600177713:

-#### Creating a new budget

+To add a location:
+1. Click Add location.
+2. Use the Search & filter options to locate the location(s) you wish to restrict fund usage to.
+3. Check the box(es) next to the location(s) you wish to restrict.
+4. Click Save.

+To remove a location:
+1. Click the X to the right of the location you wish to remove.

+To unassign all locations:
+1. Click Unassign all locations.
+Note: If you would like to unrestrict the fund, be sure to also uncheck Restrict use by location in the Fund information accordion.

+### Donor information
+Funds can be associated with donors who may have provided the money allocated to the fund's budget. Donor records are created within the Organizations app. For more information, see [Creating an Organization] (../acquisitions/organizations/#creating-an-organization). When a donor is associated with a fund, and that fund is applied to a purchase order line (POL) as a fund distribution, the donor information is automatically added to the POL. It can be subsequently removed, if not required or desired.
Can you remove the space between ] and ( to make the link work?

Reply to this email directly, view it on GitHubhttps://github.com/folio-org/docs/pull/356#pullrequestreview-2055634401, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AQHA5QS4CMFJMQYXEIBZR4TZCIPS3AVCNFSM6AAAAABGT23B4GVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDANJVGYZTINBQGE.
You are receiving this because you authored the thread.Message ID: @.***>

All set!
Molly Driscoll, MLIS
Sr. FOLIO Training Specialist
<EMAIL_ADDRESS>Mobile:<PHONE_NUMBER>
Visit EBSCO Academyhttps://connect.ebsco.com/s/academy and experience in-depth, complimentary, on-demand elearning opportunities, including personalized elearning paths!
She/her/hers
Twitterhttps://twitter.com/EBSCO | Facebookhttps://www.facebook.com/EBSCOInfoServices | LinkedInhttps://www.linkedin.com/company/ebsco-information-services | Instagramhttps://www.instagram.com/ebscoinformationservices/?hl=en | YouTubehttp://www.youtube.com/user/ebscopublishing | EBSCOposthttps://www.ebsco.com/blog
Download the EBSCO Mobile App from Google Playhttps://play.google.com/store/apps/details?id=com.ebsco.ebscomobile or the App Storehttps://apps.apple.com/us/app/ebsco-mobile/id1473281170
This message and its contents are confidential. If you received this message in error, do not use or rely upon it. Instead, please inform the sender and then delete it.
From: julianladisch @.>
Sent: Tuesday, May 14, 2024 10:46 AM
To: folio-org/docs @.>
Cc: Molly Driscoll @.>; Author @.>
Subject: Re: [folio-org/docs] Quesnelia updates for acquisitions (PR #356)
CAUTION: External E-mail
@julianladisch commented on this pull request.

In content/en/docs/Export Manager/_index.mdhttps://github.com/folio-org/docs/pull/356#discussion_r1600178207:

@@ -32,6 +32,8 @@ The Export manager app allows users to view export logs and reports initiated fr

eHoldings

MARC authority

+Note: MARC authority exports are limited to the [reports related to MARC authorities] (../metadata/inventory/marcauthority/#reporting). If exporting MARC authority records, the export can be accessed in the Data export logs. For more information, see [Exporting MARC authority records] (../metadata/inventory/marcauthority/#exporting-marc-authority-records).
Can you remove the space between ] and ( to make the two links work?

Reply to this email directly, view it on GitHubhttps://github.com/folio-org/docs/pull/356#pullrequestreview-2055635274, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AQHA5QSFCYHVZAEQXPKTBYDZCIPT7AVCNFSM6AAAAABGT23B4GVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDANJVGYZTKMRXGQ.
You are receiving this because you authored the thread.Message ID: @.***>

Fixed
Molly Driscoll, MLIS
Sr. FOLIO Training Specialist
<EMAIL_ADDRESS>Mobile:<PHONE_NUMBER>
Visit EBSCO Academyhttps://connect.ebsco.com/s/academy and experience in-depth, complimentary, on-demand elearning opportunities, including personalized elearning paths!
She/her/hers
Twitterhttps://twitter.com/EBSCO | Facebookhttps://www.facebook.com/EBSCOInfoServices | LinkedInhttps://www.linkedin.com/company/ebsco-information-services | Instagramhttps://www.instagram.com/ebscoinformationservices/?hl=en | YouTubehttp://www.youtube.com/user/ebscopublishing | EBSCOposthttps://www.ebsco.com/blog
Download the EBSCO Mobile App from Google Playhttps://play.google.com/store/apps/details?id=com.ebsco.ebscomobile or the App Storehttps://apps.apple.com/us/app/ebsco-mobile/id1473281170
This message and its contents are confidential. If you received this message in error, do not use or rely upon it. Instead, please inform the sender and then delete it.
From: julianladisch @.>
Sent: Tuesday, May 14, 2024 10:53 AM
To: folio-org/docs @.>
Cc: Molly Driscoll @.>; Author @.>
Subject: Re: [folio-org/docs] Quesnelia updates for acquisitions (PR #356)
CAUTION: External E-mail
@julianladisch commented on this pull request.

In content/en/docs/Settings/Settings_invoices/Settings_invoices.mdhttps://github.com/folio-org/docs/pull/356#discussion_r1600190115:

+*   Settings (Invoices): Batch group usernames and passwords: view. This permission allows the user to view FTP/SFTP authentication credntials entered in Settings > Invoices > Batch group configuration.

+*   Settings (Invoices): Batch group usernames and passwords: view and edit. This permission allows the user to view and edit FTP/SFTP authentication credntials entered in Settings > Invoices > Batch group configuration.
Both links should be (#settings--invoices--batch-group-configuration/)

Reply to this email directly, view it on GitHubhttps://github.com/folio-org/docs/pull/356#pullrequestreview-2055655429, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AQHA5QRMYC7DJ4DMHQF4CXLZCIQNZAVCNFSM6AAAAABGT23B4GVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDANJVGY2TKNBSHE.
You are receiving this because you authored the thread.Message ID: @.***>

fixed
Molly Driscoll, MLIS
Sr. FOLIO Training Specialist
<EMAIL_ADDRESS>Mobile:<PHONE_NUMBER>
Visit EBSCO Academyhttps://connect.ebsco.com/s/academy and experience in-depth, complimentary, on-demand elearning opportunities, including personalized elearning paths!
She/her/hers
Twitterhttps://twitter.com/EBSCO | Facebookhttps://www.facebook.com/EBSCOInfoServices | LinkedInhttps://www.linkedin.com/company/ebsco-information-services | Instagramhttps://www.instagram.com/ebscoinformationservices/?hl=en | YouTubehttp://www.youtube.com/user/ebscopublishing | EBSCOposthttps://www.ebsco.com/blog
Download the EBSCO Mobile App from Google Playhttps://play.google.com/store/apps/details?id=com.ebsco.ebscomobile or the App Storehttps://apps.apple.com/us/app/ebsco-mobile/id1473281170
This message and its contents are confidential. If you received this message in error, do not use or rely upon it. Instead, please inform the sender and then delete it.
From: julianladisch @.>
Sent: Tuesday, May 14, 2024 11:47 AM
To: folio-org/docs @.>
Cc: Molly Driscoll @.>; Author @.>
Subject: Re: [folio-org/docs] Quesnelia updates for acquisitions (PR #356)
CAUTION: External E-mail
@julianladisch commented on this pull request.

In content/en/docs/Acquisitions/Orders/_index.mdhttps://github.com/folio-org/docs/pull/356#discussion_r1600274042:

@@ -1572,12 +1661,12 @@ To change the Inventory instance connection for a purchase order line, follow th

In the PO Line details pane, click Actions > Receive. The order line opens in the Receiving app.

-3. Follow the steps as outlined in the Receiving app documentation.
+3. Follow the steps as outlined in the Receiving app documentation.
The old link works properly: https://quesnelia.docs.folio.org/docs/acquisitions/orders/#receiving-an-order-line
The new link is a broken link.

Reply to this email directly, view it on GitHubhttps://github.com/folio-org/docs/pull/356#pullrequestreview-2055798909, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AQHA5QVZ24KIKQIZTR7CANTZCIWWNAVCNFSM6AAAAABGT23B4GVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDANJVG44TQOJQHE.
You are receiving this because you authored the thread.Message ID: @.***>

fixed
Molly Driscoll, MLIS
Sr. FOLIO Training Specialist
<EMAIL_ADDRESS>Mobile:<PHONE_NUMBER>
Visit EBSCO Academyhttps://connect.ebsco.com/s/academy and experience in-depth, complimentary, on-demand elearning opportunities, including personalized elearning paths!
She/her/hers
Twitterhttps://twitter.com/EBSCO | Facebookhttps://www.facebook.com/EBSCOInfoServices | LinkedInhttps://www.linkedin.com/company/ebsco-information-services | Instagramhttps://www.instagram.com/ebscoinformationservices/?hl=en | YouTubehttp://www.youtube.com/user/ebscopublishing | EBSCOposthttps://www.ebsco.com/blog
Download the EBSCO Mobile App from Google Playhttps://play.google.com/store/apps/details?id=com.ebsco.ebscomobile or the App Storehttps://apps.apple.com/us/app/ebsco-mobile/id1473281170
This message and its contents are confidential. If you received this message in error, do not use or rely upon it. Instead, please inform the sender and then delete it.
From: julianladisch @.>
Sent: Tuesday, May 14, 2024 11:46 AM
To: folio-org/docs @.>
Cc: Molly Driscoll @.>; Author @.>
Subject: Re: [folio-org/docs] Quesnelia updates for acquisitions (PR #356)
CAUTION: External E-mail
@julianladisch commented on this pull request.

In content/en/docs/Acquisitions/Orders/_index.mdhttps://github.com/folio-org/docs/pull/356#discussion_r1600272446:

-If the PO Line has been linked to an Agreement line in the Agreements app, a Linked Agreement Lines section will display in the PO Line details pane containing information about the linked Agreement Line.  See Agreements > Adding a PO line to an agreement line for more information.

+If the PO Line has been linked to an Agreement line in the Agreements app, a Linked Agreement Lines section will display in the PO Line details pane containing information about the linked Agreement Line.  See Agreements > Adding a PO line to an agreement line for more information.
The old link works properly: https://quesnelia.docs.folio.org/docs/acquisitions/orders/#related-agreements
The new link is a broken link.

Reply to this email directly, view it on GitHubhttps://github.com/folio-org/docs/pull/356#pullrequestreview-2055796464, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AQHA5QS7GXND5V4ALNZMPKTZCIWSLAVCNFSM6AAAAABGT23B4GVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDANJVG44TMNBWGQ.
You are receiving this because you authored the thread.Message ID: @.***>

fixed
Molly Driscoll, MLIS
Sr. FOLIO Training Specialist
<EMAIL_ADDRESS>Mobile:<PHONE_NUMBER>
Visit EBSCO Academyhttps://connect.ebsco.com/s/academy and experience in-depth, complimentary, on-demand elearning opportunities, including personalized elearning paths!
She/her/hers
Twitterhttps://twitter.com/EBSCO | Facebookhttps://www.facebook.com/EBSCOInfoServices | LinkedInhttps://www.linkedin.com/company/ebsco-information-services | Instagramhttps://www.instagram.com/ebscoinformationservices/?hl=en | YouTubehttp://www.youtube.com/user/ebscopublishing | EBSCOposthttps://www.ebsco.com/blog
Download the EBSCO Mobile App from Google Playhttps://play.google.com/store/apps/details?id=com.ebsco.ebscomobile or the App Storehttps://apps.apple.com/us/app/ebsco-mobile/id1473281170
This message and its contents are confidential. If you received this message in error, do not use or rely upon it. Instead, please inform the sender and then delete it.
From: julianladisch @.>
Sent: Tuesday, May 14, 2024 11:41 AM
To: folio-org/docs @.>
Cc: Molly Driscoll @.>; Author @.>
Subject: Re: [folio-org/docs] Quesnelia updates for acquisitions (PR #356)
CAUTION: External E-mail
@julianladisch commented on this pull request.

In content/en/docs/Acquisitions/Orders/_index.mdhttps://github.com/folio-org/docs/pull/356#discussion_r1600266028:

@@ -902,11 +959,12 @@ Note: If the Package checkbox is selected for the purchase orde

Physical unit price. The price of the physical unit. Required if the Order format is Physical, P/E mix, or Other.

Quantity physical. The number of items you are ordering. Required if the Order format is Physical, P/E mix, or Other.

Additional cost. Any additional costs for the item.

-*   Currency. Select the Currency of the item from the drop-down list. The default value is stored in Tenant settings as the primary currency. For more information, see [Settings > Tenant > Language and localization]({{< ref "/settings_tenant.md#settings--tenant--language-and-localization" >}}). Note: When an order is opened, the system creates an encumbrance transaction on the current budget for the fund selected in the fund distribution section of the order.  If the currency of the PO line is different than the budget currency, the encumbrance will display on the budget as a converted amount.  The budget currency is set to the Tenant currency value at the time the [Finance > Fiscal year]({{< ref "finance#fiscal-year-information" >}}) record is created; therefore, if the Tenant currency value is updated, any budgets created prior to the update will still operate based on the Tenant currency that existed when the Fiscal year associated with the budget was created.
-*   Current exchange rate.  This value will display after the POL is saved. The system automatically retrieves the current currency exchange rate using the Java Money API that retrieves and convert currencies using the European Central Bank (ECB) as the source.
+*   Currency. Select the Currency of the item from the drop-down list. The default value is stored in Tenant settings as the primary currency. For more information, see Settings > Tenant > Language and localization. Note: When an order is opened, the system creates an encumbrance transaction on the current budget for the fund selected in the fund distribution section of the order. If the currency of the PO line is different than the budget currency, the encumbrance will display on the budget as a converted amount.  The budget currency is set to the Tenant currency value at the time the Finance > Fiscal year record is created; therefore, if the Tenant currency value is updated, any budgets created prior to the update will still operate based on the Tenant currency that existed when the Fiscal year associated with the budget was created.
Broken link because the number of ../ is too small. Or (for the second link) remove acquisitions/.

Reply to this email directly, view it on GitHubhttps://github.com/folio-org/docs/pull/356#pullrequestreview-2055785785, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AQHA5QSZAYUERHLR4MFTP43ZCIWCTAVCNFSM6AAAAABGT23B4GVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDANJVG44DKNZYGU.
You are receiving this because you authored the thread.Message ID: @.***>

All set
Molly Driscoll, MLIS
Sr. FOLIO Training Specialist
<EMAIL_ADDRESS>Mobile:<PHONE_NUMBER>
Visit EBSCO Academyhttps://connect.ebsco.com/s/academy and experience in-depth, complimentary, on-demand elearning opportunities, including personalized elearning paths!
She/her/hers
Twitterhttps://twitter.com/EBSCO | Facebookhttps://www.facebook.com/EBSCOInfoServices | LinkedInhttps://www.linkedin.com/company/ebsco-information-services | Instagramhttps://www.instagram.com/ebscoinformationservices/?hl=en | YouTubehttp://www.youtube.com/user/ebscopublishing | EBSCOposthttps://www.ebsco.com/blog
Download the EBSCO Mobile App from Google Playhttps://play.google.com/store/apps/details?id=com.ebsco.ebscomobile or the App Storehttps://apps.apple.com/us/app/ebsco-mobile/id1473281170
This message and its contents are confidential. If you received this message in error, do not use or rely upon it. Instead, please inform the sender and then delete it.
From: julianladisch @.>
Sent: Tuesday, May 14, 2024 11:41 AM
To: folio-org/docs @.>
Cc: Molly Driscoll @.>; Author @.>
Subject: Re: [folio-org/docs] Quesnelia updates for acquisitions (PR #356)
CAUTION: External E-mail
@julianladisch commented on this pull request.

In content/en/docs/Acquisitions/Orders/_index.mdhttps://github.com/folio-org/docs/pull/356#discussion_r1600264618:

Collection. If the item is part of a collection, select the Collection checkbox.

Receiving workflow. Select a value from the drop down list to manage behavior in the Receiving app.  Select Synchronized order and receipt quantity to keep the order quantity and the number of pieces to be received in sync. When the order is opened, the system will generate Receiving app pieces based on the quantity value on the purchase order line. Updating the quantity on the order will update the number of pieces to be received and updates in the Receiving app will update the order.  Select Independent order and receipt quantity if you need to create an unpredictable quantity of Receiving pieces, such as for an ongoing order.  Note: In prior system releases, this field was a checkbox named "Manually add pieces for receiving."

Cancellation description. A note about the cancellation.

Line description. A description of the purchase order line.

Tags. Select or enter any tags you want to assign to the order line in the box.

+## Donor information
+The Donor information accordion can be used to capture information about a donor related to the order line. The donor information will be autofilled on the oder if the fund selected in the [Fund distribution] (#fund-distribution) accordion is associated with a donor.
Please remove the space between ] and ( to make the link work.

Reply to this email directly, view it on GitHubhttps://github.com/folio-org/docs/pull/356#pullrequestreview-2055783653, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AQHA5QQP7VTTFCQ3O5VD7CTZCIV7FAVCNFSM6AAAAABGT23B4GVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDANJVG44DGNRVGM.
You are receiving this because you authored the thread.Message ID: @.***>

All set!
Molly Driscoll, MLIS
Sr. FOLIO Training Specialist
<EMAIL_ADDRESS>Mobile:<PHONE_NUMBER>
Visit EBSCO Academyhttps://connect.ebsco.com/s/academy and experience in-depth, complimentary, on-demand elearning opportunities, including personalized elearning paths!
She/her/hers
Twitterhttps://twitter.com/EBSCO | Facebookhttps://www.facebook.com/EBSCOInfoServices | LinkedInhttps://www.linkedin.com/company/ebsco-information-services | Instagramhttps://www.instagram.com/ebscoinformationservices/?hl=en | YouTubehttp://www.youtube.com/user/ebscopublishing | EBSCOposthttps://www.ebsco.com/blog
Download the EBSCO Mobile App from Google Playhttps://play.google.com/store/apps/details?id=com.ebsco.ebscomobile or the App Storehttps://apps.apple.com/us/app/ebsco-mobile/id1473281170
This message and its contents are confidential. If you received this message in error, do not use or rely upon it. Instead, please inform the sender and then delete it.
From: julianladisch @.>
Sent: Tuesday, May 14, 2024 11:39 AM
To: folio-org/docs @.>
Cc: Molly Driscoll @.>; Author @.>
Subject: Re: [folio-org/docs] Quesnelia updates for acquisitions (PR #356)
CAUTION: External E-mail
@julianladisch commented on this pull request.

In content/en/docs/Acquisitions/Orders/_index.mdhttps://github.com/folio-org/docs/pull/356#discussion_r1600262763:

Receiving note. Enter any notes about receiving the item. The notes display in the Receiving app for this order line.

-*   Must acknowledge receiving note.  Check this box to enable the receiving note to popup in the Receving app when the user clicks to receive the title.  See Receiving > Receive
+*   Must acknowledge receiving note.  Check this box to enable the receiving note to popup in the Receving app when the user clicks to receive the title.  See Receiving > Receiving a piece
Broken link because the number of ../ is too small. Or remove acquisitions/.

Reply to this email directly, view it on GitHubhttps://github.com/folio-org/docs/pull/356#pullrequestreview-2055780777, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AQHA5QT5MGYVEXRSMAQWFYLZCIV2JAVCNFSM6AAAAABGT23B4GVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDANJVG44DANZXG4.
You are receiving this because you authored the thread.Message ID: @.***>

All set
Molly Driscoll, MLIS
Sr. FOLIO Training Specialist
<EMAIL_ADDRESS>Mobile:<PHONE_NUMBER>
Visit EBSCO Academyhttps://connect.ebsco.com/s/academy and experience in-depth, complimentary, on-demand elearning opportunities, including personalized elearning paths!
She/her/hers
Twitterhttps://twitter.com/EBSCO | Facebookhttps://www.facebook.com/EBSCOInfoServices | LinkedInhttps://www.linkedin.com/company/ebsco-information-services | Instagramhttps://www.instagram.com/ebscoinformationservices/?hl=en | YouTubehttp://www.youtube.com/user/ebscopublishing | EBSCOposthttps://www.ebsco.com/blog
Download the EBSCO Mobile App from Google Playhttps://play.google.com/store/apps/details?id=com.ebsco.ebscomobile or the App Storehttps://apps.apple.com/us/app/ebsco-mobile/id1473281170
This message and its contents are confidential. If you received this message in error, do not use or rely upon it. Instead, please inform the sender and then delete it.
From: julianladisch @.>
Sent: Tuesday, May 14, 2024 11:44 AM
To: folio-org/docs @.>
Cc: Molly Driscoll @.>; Author @.>
Subject: Re: [folio-org/docs] Quesnelia updates for acquisitions (PR #356)
CAUTION: External E-mail
@julianladisch commented on this pull request.

In content/en/docs/Acquisitions/Orders/_index.mdhttps://github.com/folio-org/docs/pull/356#discussion_r1600270171:

-*   Approval plan. Order lines acquired through an approval plan.
-*   Demand driven acquisitions (DDA). Order lines acquired through DDA.
-*   Depository. Order lines acquired through a depository arrangement, such as for government publications.
-*   Evidence based acquisitions (EBA). Order lines acquired through EBA.
-*   Exchange. Order lines acquired through an exchange with another library or institution.
-Free
-*   Gift. Order line for materials granted to the library as a gift.
-*   Internal transfer. Order lines acquired through internal transfer.
-*   Membership.  Order lines acquired through membership.
-*   Other. Order lines acquired by some other method not listed.
-*   Purchase. Order lines purchased by methods such as email or EDI.
-*   Purchase at vendor system. Order lines purchased through an external vendor system, such as a website.
-*   Technical. Order lines to track payments for technical expenses such as service orders or vendor processing fees. This value could also be used for items that have migrated from an external system.
+In the Search & filter pane, click Acquisition method and select any applicable filters. Values are configured in [Settings > Orders > Acquisition methods] (../settings/settings_orders/settings_orders/#settings--orders--general--acquisition-methods).
Broken link because the number of ../ is too small and because the space between ] and ( needs to be removed.

Reply to this email directly, view it on GitHubhttps://github.com/folio-org/docs/pull/356#pullrequestreview-2055792789, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AQHA5QT3DRGGMMQJEWSAOVTZCIWMRAVCNFSM6AAAAABGT23B4GVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDANJVG44TENZYHE.
You are receiving this because you authored the thread.Message ID: @.***>

All set
Molly Driscoll, MLIS
Sr. FOLIO Training Specialist
<EMAIL_ADDRESS>Mobile:<PHONE_NUMBER>
Visit EBSCO Academyhttps://connect.ebsco.com/s/academy and experience in-depth, complimentary, on-demand elearning opportunities, including personalized elearning paths!
She/her/hers
Twitterhttps://twitter.com/EBSCO | Facebookhttps://www.facebook.com/EBSCOInfoServices | LinkedInhttps://www.linkedin.com/company/ebsco-information-services | Instagramhttps://www.instagram.com/ebscoinformationservices/?hl=en | YouTubehttp://www.youtube.com/user/ebscopublishing | EBSCOposthttps://www.ebsco.com/blog
Download the EBSCO Mobile App from Google Playhttps://play.google.com/store/apps/details?id=com.ebsco.ebscomobile or the App Storehttps://apps.apple.com/us/app/ebsco-mobile/id1473281170
This message and its contents are confidential. If you received this message in error, do not use or rely upon it. Instead, please inform the sender and then delete it.
From: julianladisch @.>
Sent: Tuesday, May 14, 2024 11:44 AM
To: folio-org/docs @.>
Cc: Molly Driscoll @.>; Author @.>
Subject: Re: [folio-org/docs] Quesnelia updates for acquisitions (PR #356)
CAUTION: External E-mail
@julianladisch commented on this pull request.

In content/en/docs/Acquisitions/Orders/_index.mdhttps://github.com/folio-org/docs/pull/356#discussion_r1600269435:

@@ -1129,15 +1185,15 @@ To search for order lines by purchase order number prefix, follow these steps.

Suffix
-To search for order lines by purchase order number suffix, follow these steps.  For more information about creating Suffix values, see [Settings > Orders > Suffixes]({{< ref "/settings_orders.md#settings--orders--suffixes" >}}).
+To search for order lines by purchase order number suffix, follow these steps.  For more information about creating Suffix values, see Settings > Orders > Suffixes.
Broken link because the number of ../ is too small.

Reply to this email directly, view it on GitHubhttps://github.com/folio-org/docs/pull/356#pullrequestreview-2055791503, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AQHA5QT3KAWZY6GMCEWD2XTZCIWKXAVCNFSM6AAAAABGT23B4GVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDANJVG44TCNJQGM.
You are receiving this because you authored the thread.Message ID: @.***>

All set
Molly Driscoll, MLIS
Sr. FOLIO Training Specialist
<EMAIL_ADDRESS>Mobile:<PHONE_NUMBER>
Visit EBSCO Academyhttps://connect.ebsco.com/s/academy and experience in-depth, complimentary, on-demand elearning opportunities, including personalized elearning paths!
She/her/hers
Twitterhttps://twitter.com/EBSCO | Facebookhttps://www.facebook.com/EBSCOInfoServices | LinkedInhttps://www.linkedin.com/company/ebsco-information-services | Instagramhttps://www.instagram.com/ebscoinformationservices/?hl=en | YouTubehttp://www.youtube.com/user/ebscopublishing | EBSCOposthttps://www.ebsco.com/blog
Download the EBSCO Mobile App from Google Playhttps://play.google.com/store/apps/details?id=com.ebsco.ebscomobile or the App Storehttps://apps.apple.com/us/app/ebsco-mobile/id1473281170
This message and its contents are confidential. If you received this message in error, do not use or rely upon it. Instead, please inform the sender and then delete it.
From: julianladisch @.>
Sent: Tuesday, May 14, 2024 11:44 AM
To: folio-org/docs @.>
Cc: Molly Driscoll @.>; Author @.>
Subject: Re: [folio-org/docs] Quesnelia updates for acquisitions (PR #356)
CAUTION: External E-mail
@julianladisch commented on this pull request.

In content/en/docs/Acquisitions/Orders/_index.mdhttps://github.com/folio-org/docs/pull/356#discussion_r1600269303:

@@ -1120,7 +1176,7 @@ In the Search & filter pane, click Payment status and select any applica

Prefix
-To search for order lines by purchase order number prefix, follow these steps.  For more information about creating Prefix values, see [Settings > Orders > Prefixes]({{< ref "/settings_orders.md#settings--orders--prefixes" >}})
+To search for order lines by purchase order number prefix, follow these steps.  For more information about creating Prefix values, see Settings > Orders > Prefixes
Broken link because the number of ../ is too small.

Reply to this email directly, view it on GitHubhttps://github.com/folio-org/docs/pull/356#pullrequestreview-2055791248, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AQHA5QS5KYA6A2XH4EDEQA3ZCIWKPAVCNFSM6AAAAABGT23B4GVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDANJVG44TCMRUHA.
You are receiving this because you authored the thread.Message ID: @.***>

All set
Molly Driscoll, MLIS
Sr. FOLIO Training Specialist
<EMAIL_ADDRESS>Mobile:<PHONE_NUMBER>
Visit EBSCO Academyhttps://connect.ebsco.com/s/academy and experience in-depth, complimentary, on-demand elearning opportunities, including personalized elearning paths!
She/her/hers
Twitterhttps://twitter.com/EBSCO | Facebookhttps://www.facebook.com/EBSCOInfoServices | LinkedInhttps://www.linkedin.com/company/ebsco-information-services | Instagramhttps://www.instagram.com/ebscoinformationservices/?hl=en | YouTubehttp://www.youtube.com/user/ebscopublishing | EBSCOposthttps://www.ebsco.com/blog
Download the EBSCO Mobile App from Google Playhttps://play.google.com/store/apps/details?id=com.ebsco.ebscomobile or the App Storehttps://apps.apple.com/us/app/ebsco-mobile/id1473281170
This message and its contents are confidential. If you received this message in error, do not use or rely upon it. Instead, please inform the sender and then delete it.
From: julianladisch @.>
Sent: Tuesday, May 14, 2024 11:43 AM
To: folio-org/docs @.>
Cc: Molly Driscoll @.>; Author @.>
Subject: Re: [folio-org/docs] Quesnelia updates for acquisitions (PR #356)
CAUTION: External E-mail
@julianladisch commented on this pull request.

In content/en/docs/Acquisitions/Orders/_index.mdhttps://github.com/folio-org/docs/pull/356#discussion_r1600268715:

@@ -1085,7 +1141,7 @@ You can search for order lines in the Search & filter pane. Order lines is s

Product ID. The Product ID of the item.

Product ID ISBN. The ISBN of the item.

-You can also search for order lines by selecting any of the filters in the Search & filter pane.  See the sections below for more information.
+You can also search for order lines by selecting any of the filters in the Search & filter pane.  See the sections below for more information. Note: additional filter options may be visible to users if custom fileds have been configured in [Setting > Orders > Custom fields] (../settings/settings_orders/settings_orders/#settings--orders--general--customfields).
Broken link because the number of ../ is too small and because the space between ] and ( needs to be removed.

Reply to this email directly, view it on GitHubhttps://github.com/folio-org/docs/pull/356#pullrequestreview-2055789987, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AQHA5QVCN2D7VD5NHX3RUF3ZCIWJNAVCNFSM6AAAAABGT23B4GVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDANJVG44DSOJYG4.
You are receiving this because you authored the thread.Message ID: @.***>

All set
Molly Driscoll, MLIS
Sr. FOLIO Training Specialist
<EMAIL_ADDRESS>Mobile:<PHONE_NUMBER>
Visit EBSCO Academyhttps://connect.ebsco.com/s/academy and experience in-depth, complimentary, on-demand elearning opportunities, including personalized elearning paths!
She/her/hers
Twitterhttps://twitter.com/EBSCO | Facebookhttps://www.facebook.com/EBSCOInfoServices | LinkedInhttps://www.linkedin.com/company/ebsco-information-services | Instagramhttps://www.instagram.com/ebscoinformationservices/?hl=en | YouTubehttp://www.youtube.com/user/ebscopublishing | EBSCOposthttps://www.ebsco.com/blog
Download the EBSCO Mobile App from Google Playhttps://play.google.com/store/apps/details?id=com.ebsco.ebscomobile or the App Storehttps://apps.apple.com/us/app/ebsco-mobile/id1473281170
This message and its contents are confidential. If you received this message in error, do not use or rely upon it. Instead, please inform the sender and then delete it.
From: julianladisch @.>
Sent: Tuesday, May 14, 2024 11:43 AM
To: folio-org/docs @.>
Cc: Molly Driscoll @.>; Author @.>
Subject: Re: [folio-org/docs] Quesnelia updates for acquisitions (PR #356)
CAUTION: External E-mail
@julianladisch commented on this pull request.

In content/en/docs/Acquisitions/Orders/_index.mdhttps://github.com/folio-org/docs/pull/356#discussion_r1600268309:

Material type. The type of material.

+### Custom fields
+The Custom fields section appears only if it is configured in the Settings > Orders app. For information on configuring the Custom fields section, see [Setting > Orders > Custom fields] (../settings/settings_orders/settings_orders/#settings--orders--general--customfields).
Broken link because the number of ../ is too small and because the space between ] and ( needs to be removed.

Reply to this email directly, view it on GitHubhttps://github.com/folio-org/docs/pull/356#pullrequestreview-2055789252, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AQHA5QUF2F255O7WIJZ5CVLZCIWILAVCNFSM6AAAAABGT23B4GVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDANJVG44DSMRVGI.
You are receiving this because you authored the thread.Message ID: @.***>