fixes windows composite key: #102 - add composite key

#102 - Text input yields Key::Unknown on windows_term using alt

Okay, what is a composite key and how is it related to macos and ubuntu?

As stated in the linked issue, the composite key does not really exist. It also does not relate to linux. The mapping is more for the Alt key - however, calling it Key::Alt seemed misleading as the mapping within winapi seems to be incorrect as well (it points to the Menu key instead).
The issue is that the windows term generates Key::Unknown + Key::Char events when using this technique. (You should be able to reproduce this by using altGr + / to create a ¿ character). This causes dialoguer to crash.

If you check https://docs.microsoft.com/en-us/windows/win32/inputdev/virtual-key-codes, VK_MENU is ALT key. So, instead of composite, let's put Key::Alt

Then I misunderstood that. I will use Key::Alt then instead. Thank you very much!


Discord phone number deleted

After I used the provided method to delete messages I got an email saying
Your phone number ***********0 was recently removed from this account and added to a different Discord account.
Please note that your phone number can only be linked to one Discord account at a time.
When I try to add my phone number back I get a text back saying an existing discord account is already using this number. Please remove it before it can be used with a new account.
I have no idea what account it went to and i cant add my phone number back to my account

The script is clean, as explained here:
https://github.com/victornpb/deleteDiscordMessages#about-running-code-on-your-console
I even read through it myself to be sure, and it's clean.
Your phone number issues were caused by something else and is just a coincidence. Has nothing to do with this script, if you installed the clean code from the official places listed on the front page of this project.


chore: add a few focusing dots 3

More missing cdots found by the multiGoal linter (#12339).

bors merge


compiler.es5.js:1690 Uncaught Error: Can't resolve all parameters for TourAnchorMdMenuDirective:

What is causing this error?  What build process are you using? What versions of angular material and ngx-tour-md-menu are you using?


Visibility masks

Hi,
Thanks for sharing this work, it is really interesting.
Can you please share the code to reproduce the visibility masks? I couldn't find it on NeRFBusters code base, but I saw you mentioned that you did reproduce the masks.
Thanks,
Leo

Hi,
please take a look at their experiments README, I believe the visibility masks will be generated through running the experiment for pseudo_gt models.


Node.js Foundation Community Committee Meeting 2019-09-19

Time
UTC Thu 19-Sep-2019 16:00 (04:00 PM):

Timezone
Date/Time

US / Pacific
Thu 19-Sep-2019 09:00 (09:00 AM)

US / Mountain
Thu 19-Sep-2019 10:00 (10:00 AM)

US / Central
Thu 19-Sep-2019 11:00 (11:00 AM)

US / Eastern
Thu 19-Sep-2019 12:00 (12:00 PM)

London
Thu 19-Sep-2019 17:00 (05:00 PM)

Amsterdam
Thu 19-Sep-2019 18:00 (06:00 PM)

Moscow
Thu 19-Sep-2019 19:00 (07:00 PM)

Chennai
Thu 19-Sep-2019 21:30 (09:30 PM)

Hangzhou
Fri 20-Sep-2019 00:00 (12:00 AM)

Tokyo
Fri 20-Sep-2019 01:00 (01:00 AM)

Sydney
Fri 20-Sep-2019 02:00 (02:00 AM)

Or in your local time:

http://www.timeanddate.com/worldclock/fixedtime.html?msg=Node.js+Foundation+Community Committee+Meeting+2019-09-19&iso=20190919T16
or http://www.wolframalpha.com/input/?i=04PM+UTC%2C+Sep+19%2C+2019+in+local+time

Links

Minutes Google Doc: https://docs.google.com/document/d/1z3okIz7GlwjLhRDAuA7IpXsyKUDBenmR4fEwJnRA3Vw/edit

Agenda
Extracted from cc-agenda labelled issues and pull requests from the nodejs org prior to the meeting.
nodejs/admin

Moderation team recertification #408

nodejs/community-committee

Community Committee Chairperson Self Nominations #518
Towards less conflicts from biases/assumptions in communication styles/conventions #507
Charter Update to Reflect New OpenJS Foundation #526
Node.js Social Media Community Collaboration #444
Node.js Collection – Next Steps #439

Invited

CommComm Members: @nodejs/community-committee

Observers/Guests
Feel free to follow along on the YouTube live stream, or attend meeting as a guest
by calling in to Zoom, using the links below. If you will be attending as a guest,
please comment on this issue to let us know you'll be joining.
Notes
The agenda comes from issues labelled with cc-agenda across all of the repositories in the nodejs org. Please label any additional issues that should be on the agenda before the meeting starts.
Joining the meeting

Link for participants: https://zoom.us/j/527273462
For those who just want to watch: https://www.youtube.com/channel/UCQPYJluYC_sn_Qz_XE-YbTQ

Invitees
Please use the following emoji reactions in this post to indicate your
availability.

:+1: - Attending
:-1: - Not attending
:confused: - Not sure yet

Updated to add #526


Fixed  Python Notebook Examples

I'm excited to share some updates I've made to the Python notebook examples. While browsing through the existing examples because of #224, I noticed a few issues that had to be fixed.
Along with correcting typos, updating for the latest mlpack API changes as well as some other bug fixes, I've ensured all python notebooks are now fully functional by running and fixing each one :)
Once I have some more time, I plan to extend these fixes to the notebooks in other languages too.

@rcurtin Yes, I encountered a slight issue with SSL verification while requesting lab.mlpack.org. The error I ran into was: URLError: <urlopen error [SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed: unable to get local issuer certificate (_ssl.c:1007)>.
My current approach is a workaround to this problem. However, I agree that the ideal solution would be to update the SSL certificate on the website.

Haven't seen it yet, but I’ll definitely check it out on your recommendation when I have the chance ;)

View entire conversation on ReviewNB

I went through and added the datasets to datasets.mlpack.org, so now we can use that instead to avoid the SSL error.  Can you make those changes?  If so I think this is good to go. :+1:

@rcurtin I removed all SSL certificate exceptions, tested it, and everything seems to be working fine now :)

Thanks again @MarkFischinger! :+1:


_reboot overwrites $btn-primary-color var

found another reboot overwrite issue. i can not set any color for $btn-primary-color var. it will be overwritten by reboot with color: inherit

This one's tough, but if you have a button without an href we assume different behaviors (as does the browser). For example, href-less links have no cursor change on hover in most browsers. If you need a button that doesn't function as a link, please use a <button> element.

Adding to that, the selector you're seeing is intentional. See the comment in our Reboot file:
// And undo these styles for placeholder links/named anchors (without href)
// which have not been made explicitly keyboard-focusable (without tabindex).
// It would be more straightforward to just use a[href] in previous block, but that
// causes specificity issues in many other styles that are too complex to fix.
// See https://github.com/twbs/bootstrap/issues/19402

hey @mdo you are absolutely right. i just add href attribute and its fine for me. sorry for the issue


react-native-google-fit fails in RN 60

I created a new project with react-native 0.60.0-rc.1 which now does auto linking and implements AndroidX.  It is still a bit buggy but I've got a working app in both android and ios.  After doing yarn add react-native-google-fit and trying to run the app in android I've had a number of problems.
On the AndroidX side all instances of
import android.support.annotation.NonNull;
import android.support.annotation.Nullable;

needed to be changed to
import androidx.annotation.NonNull;
import androidx.annotation.Nullable;

Additionally, the GoogleFitPackage is now added to a dynamically created file android/app/build/generated/rncli/src/main/java/com/facebok/react/PackageList.java but is missing the arg BuildConfig.APPLICATION_ID.
PackageList.java
../

public ArrayList<ReactPackage> getPackages() {
  return new ArrayList<>(Arrays.<ReactPackage>asList(
    new MainReactPackage(),
    new ReactNativeFirebaseAppPackage(),new ReactNativeFirebaseAuthPackage(),new RNGestureHandlerPackage(),new GoogleFitPackage()
  ));
}

MainApplication.java
@Override
  protected List<ReactPackage> getPackages() {
    @SuppressWarnings("UnnecessaryLocalVariable")
    List<ReactPackage> packages = new PackageList(this).getPackages();
    // Packages that cannot be autolinked yet can be added manually here, for example:
    // packages.add(new MyReactNativePackage());
    return packages;
  }

Unfortunately if I try manually adding new GoogleFitPackage(BuildConfig.APPLICATION_ID) to getPackages in MainApplication it is overridden by PackageList.
No issues with react-native run-ios - though all I've done is add import GoogleFit, { Scopes } from 'react-native-google-fit';.

@spasecadet I was able to make this work by adding the library as an exception to react-native.config.js, as explained here https://github.com/react-native-community/cli/blob/master/docs/autolinking.md
This way the library is not autolinked and PackageList doesn't override the package.

@spasecadet I was able to make this work by adding the library as an exception to react-native.config.js, as explained here https://github.com/react-native-community/cli/blob/master/docs/autolinking.md
This way the library is not autolinked and PackageList doesn't override the package.

@spasecadet  Did this worked for you?

Hey guys. If some1 has a working solution - please share, I'll document it. Thanks!

@plahteenlahti thanks for the suggestion, I haven't got it working yet for myself. I've tired:
yarn add react-native-google-fit
react-native unlink react-native-google-fit

Then added a react-native.config.js file inside ./node_modules/react-native-google-fit with this code:
// react-native.config.js
module.exports = {
  dependencies: {
    'react-native-google-fit': {
      platforms: {
        android: null, // disable Android platform, other platforms will still autolink if provided
      },
    },
  },
};

Then added to MainApplication.java
packages.add(new GoogleFitPackage(BuildConfig.APPLICATION_ID));
Then
react-native link react-native-google-fit
I also tried doing this without the react-native link step and just used the manual installation for google fit and that hasn't worked either, I still get the same error in PackageList.java
error: constructor GoogleFitPackage in class GoogleFitPackage cannot be applied to given types;
      new GoogleFitPackage(),
      ^
  required: String
  found: no arguments
  reason: actual and formal argument lists differ in length
1 error

What steps did you follow to make it work?

Ok I misunderstood the react-native.config.js file.  I added that file to the root of my application with the same code as above and it appears to be working now.  However, I would not consider this a long-term solution since it doesn't really take advantage of autolinking and requires extra steps to get this working.  I'm not clear on whether or not settings can be configured within this package that enable the use of PackageList.java.  I posted a question here: https://github.com/react-native-community/cli/issues/599.

I got a response on my question above (https://github.com/react-native-community/cli/issues/599) and the solution that allows autolinking to work is (first remove react-native-google-fit if it is already installed) to add a react-native.config.js file to your app root, with these contents:
module.exports = {
  dependencies: {
    'react-native-google-fit': {
      platforms: {
        android: {
          packageInstance: "new GoogleFitPackage(BuildConfig.APPLICATION_ID)",
        },
      },
    },
  },
};

save
Then
yarn add react-native-google-fit
This allows autolinking to work and PackageList.java instantiates the package the correct way.  This solution should ultimately be included in the package itself and I've submitted a PR to add it.  Note, I have NOT tested this for RN <60.  I suspect it will not cause any problems because I believe using react-native.config.js is new to RN 60, but again, this is untested.

@StasDoskalenko This package still needs to be updated to AndroidX which includes changing all of these:
import android.support.annotation.NonNull;
import android.support.annotation.Nullable;

to
import androidx.annotation.NonNull;
import androidx.annotation.Nullable;

in

CalorieHistory.java
DistanceHistory.java
GoogleFitManager.java
StepHistory.java
StepCounter.java
StepSensor.java
RecordingApi.java
ActivityHistory.java

However that WILL cause RN <60 to break so for now users can install jetifier and run npx jetify after installing react-native-google-fit for RN >=60.

@spasecadet sure. thank you for this

Any progress on this?

Is there any update on this? I've followed the steps in the description but my builds in appcenter are still failing. I'm on react-native 0.60.4 and assumed jetifier would run automatically (which it does I think). However, I was still getting build issues so I added npx jetifier to the postinstall script in my package.json and it is still failing

Sorry, I managed to resolve the builds by trying various different solutions

Added npx jetifier to the postinstall
Change tooling version of android

buildscript {
    ext {
        buildToolsVersion = "29.0.0"
        minSdkVersion = 16
        compileSdkVersion = 29
        targetSdkVersion = 29
        supportLibVersion = "28.0.0"
        googlePlayServicesAuthVersion = "16.0.1"
    }
}


Siren

Siren - Notify users when a new version of your app is available and prompt them to upgrade. :large_orange_diamond:

@ArtSabintsev do you know on what category we could add?

Same one as Harpy (https://github.com/vsouza/awesome-ios#app-store)
App Store category :)

@ArtSabintsev thanks for helping out, and good job on the cool lib! 👍

Thank you!


More intelligent properties on slices involving stacks

Is your feature request related to a problem? Please describe.
I have some Expressions that involve slices (cvxpy.atoms.affine.index.index) and stacks (vstack, hstack, potentially bmat). Currently when interrogating some property of the Expression, for example is_constant(), all Expressions in the (sub-)tree are inspected, however where slices are involved, some sub Expressions may not be relevant and could be ignored to yield more accurate answers. For example:
import cvxpy as cp

x_const = cp.Constant([1, 2, 3])
x_var = cp.Variable(2)

x = cp.hstack([x_const, x_var])

x[0].is_constant()  # returns False

I would argue x[0].is_constant() should return True, however currently it does not because cp.Expression.is_constant() checks whether all(arg.is_constant() for arg in self.args) so in this instance all the constituents in the hstack must be constant for any single element slice to be identified as constant.
Describe the solution you'd like
I would like x[0].is_constant() to return True in the above 😃 and [elem.is_constant() for elem in x] to return [True, True, True, False, False].
In general for this to happen I assume slices / indexes should only considered the sections of Expressions they need to in order to determine their properties.
Describe alternatives you've considered
From a quick look through the source I can't see an easy way of implementing this 😕
Potentially cvxpy.atoms.affine.index.index could parse its entire Expression tree and slice it before storing its args. So for the above and slices involving only the first three elements would only store the x_const expression in their args. Slices covering elements from the first 3 and the last 2 would store both x_const and x_var, etc.
Other options involving all Expressions being able to return only their subexpressions covered by a slice seem less attractive.
Additional context
I appreciate such a feature might not be simple to implement and is not core to the functionality or performance of the library, but it would be useful and I'd welcome any discussion 😄

To add some context, CVX supports expressions with mixed curvatures, which is more aligned with this feature request. CVXPY initially supported expressions with mixed curvatures but that support was removed because it seemed like too much overhead relative to the benefit. But maybe there is a more efficient approach than what was tried before.


feat: add naming-convention rules

upgrades @typescript-eslint dependencies to 3.10.1
removes deprecated + deleted rules (see 3.x release notes)
adds naming-convention rule

I made a POC repo  with these rules configured if anyone wants to play with the new settings. I’d appreciate another set of eyes for anything I missed as regards the removal of the leading underscore enforcement (since it's supported with naming-convention).

@jthomerson, doesn't look like I can assign reviewers, so pinging you for review

@jthomerson, doesn't look like I can assign reviewers, so pinging you for review

@pbredenberg good start. Can you make a first pass at suggesting what we need to do (based on the comment I just left), and then discuss with me and @onebytegone?

@pbredenberg good start. Can you make a first pass at suggesting what we need to do (based on the comment I just left), and then discuss with me and @onebytegone?

Thanks, good suggestions @jthomerson I'll take a look at DPS.

Thanks, good suggestions @jthomerson I'll take a look at DPS.

Closing in favor of #89


Validate Container Images with OCI Specification

I encountered https://github.com/opencontainers/image-spec/issues/738 which already requests for a tool which can validate a provided container image if it meets the OCI specification.
But the development of the tools in the GitHub Repository seems to have halted for the past 2-3 years.
Is it safe and up to date to use the tools defined in this issue to perform $subject? Or do we have any new recommendations?
Suggested Assignee
@cyphar

Closing this issue as I have opened it in the incorrect repository.


Read default eosio key from config.ini in addition to command line

Verified.
Used --eosio-key parameter when starting the wallet and create a new wallet. The new wallet has the key specified after --eosio-key imported by default.


Names and DOBs of living non-members are added to the bio when Auto Bio is used

Describe the bug
When Auto Bio is used, it will fill in the full names and complete dates of birth of children, siblings, etc even when the data is from profiles of living non-members.
I'm not sure if you want to consider that a bug, as the comment added by auto bio reminds the user to review and edit the changes made by auto bio.

extension v1.8.5 on Firefox 115.0.2

I see most of this was implemented. Thanks!
I'm usering 1.8.8 now.
When I try it on my bio, some info still gets filled in with auto bio, such as my full name and DOB (going by this image, which says which info should be private, based on my profile privacy settings).

Fixed.


It's better to share scripts about the training process.

A rough look at the code you provided, no training-related scripts were found.

can please show the  training-related scripts ?


selection file conversion failed

Running any esgpull convert for this selection file ends with an error:
`
(esgpull) -bash-4.2$ esgpull convert 2023-02-09_*******.txt --graph
2023-04-11 10:51:48]  ERROR     root
Traceback (most recent call last):
File "/gpfscmip/gpfsdata/esgf/miniconda/envs/esgpull/lib/python3.11/site-packages/esgpull/tui.py", line 154, in logging
yield
File "/gpfscmip/gpfsdata/esgf/miniconda/envs/esgpull/lib/python3.11/site-packages/esgpull/cli/convert.py", line 237, in convert
graph = convert_file(path)
^^^^^^^^^^^^^^^^^^
File "/gpfscmip/gpfsdata/esgf/miniconda/envs/esgpull/lib/python3.11/site-packages/esgpull/cli/convert.py", line 121, in convert_file
query.tags = result.name[0]
^^^^^^^^^^
File "/gpfscmip/gpfsdata/esgf/miniconda/envs/esgpull/lib/python3.11/site-packages/sqlalchemy/orm/attributes.py", line 528, in set
self.impl.set(
File "/gpfscmip/gpfsdata/esgf/miniconda/envs/esgpull/lib/python3.11/site-packages/sqlalchemy/orm/attributes.py", line 1919, in set
raise TypeError(
TypeError: Incompatible collection type: str is not list-like
`
to replicate selection file in question :
mip_era=CMIP6
source_id=CESM2 CMCC-ESM2 CanESM5-CanOE GISS-E2-1-G UKESM1-0-LL
experiment_id=piControl
#variant_label=r1i1p1f1
frequency=mon
variable_id=phydiat mlotstmax tos si no3 dfe vo psl

It seems that this file (filename = areacella_fx_FGOALS-g2_lgm_r0i0p0.nc) has no checksum nor checksum_type attributes in the synda CMIP5 database you are importing, and those are currently required by esgpull.
The query ran by esgpull on the ESGF search API confirms that the 2 attributes are also missing from the file's metadata: https://esgf-node.ipsl.upmc.fr/esg-search/search?type=File&offset=0&limit=1&format=application%2Fsolr%2Bjson&fields=*&query=title%3Aareacella_fx_FGOALS-g2_lgm_r0i0p0.nc&distrib=true&latest=true&retracted=false
I am guessing synda used the same query to fill its database at the time this file was added.
Now if I increase the limit parameter for this query (numFound tells us 4 replicas exist in this case), checksum and checksum_type do exist in the next 3 replicas' metadata.
Knowing this, 2 things could be done during import to handle missing information:

look up the metadata from all replicas for each incomplete file and use the most complete one, but I don't know if we can guarantee there will always be at least one index node with the full metadata,
skip files with incomplete metadata from the imported database

The first solution might look more complete but it could seriously slow down the import procedure, and does not guarantee missing info will be filled, while the 2nd solution is easy to set up but will definitely introduce divergence between the filesystem and database.

The issue cannot be replicated with the selection you provided since it comes from the first line (commented email address I suppose) which is used as a tag for the query produced with the conversion.
It comes from a regression introduced with a change on how Query instances are created (9acf164f88a31476f5f87b8847c7f1cd46f7d3b0).
The issue is now fixed with 3d9ae0d3665f89b1e703a9b6af996e7b82f00856 and I bumped the version to 0.3.8.


Made modifier key optional and adding support for more than just single alphnumeric keycodes

Following up on https://github.com/louisnw01/lightweight-charts-python/issues/113
Here is my proposed fix. I had to move the order of the arguments. Let me know your thoughts. If you are cool with the changes Ill add the updates to the documentation in this PR
Usage
chart.hotkey('Space', pause_event)
chart.hotkey('ArrowRight', move_forward_event, modifier_key='shift')
chart.hotkey((1, 2, 3), print_key, modifier_key='shift')

Changes

made modifier key optional
handle multi character key names

Hey @jamesbaber1,
Just to note there is a new version out as of today so you will need to rebase the branch.
I think this is a great idea. Simplicity is key though, but it seems like you've achieved that.
I do want to keep the parameter order the same, so no modifer key could also be implemented as:
def hotkey(self, modifier_key: Literal['ctrl', 'alt', 'shift', 'meta', None],
               keys: Union[str, tuple, int], func: callable):

chart.hotkey(None, 'A')

with the func parameter being last in keeping with the style of the rest of the library.
I can think of a lot of other non alphanumeric keys that people may use ([];’\,./§)
Definitely looking good though!
Louis

I'm trying to think if there was a reason why I didn't use event event.key; that appears to register all keys whether they are alphanumeric or not, which might simplify this.

Ok so I updated and played around with the event.key

Seems to be the literal character from the key press. So I see why you didn't use is with the modifiers since a key combo like SHIFT+1 would equal !.
I tweaked the logic to switch the condition based on whether a modifier is being used or not and revert the arg order change.
Usage
chart.hotkey(None, ' ', pause_event)
chart.hotkey(None, 'ArrowRight', move_forward_event)
chart.hotkey('shift', (1, 2, 3), print_key)

I tested these examples above
Notice 'SpaceBar' is now ' '
Let me know what you think. Thanks


Sudoku Solver

Description
Write a program to solve a Sudoku puzzle by filling the empty cells.
A sudoku solution must satisfy all of the following rules:

Each of the digits 1-9 must occur exactly once in each row.
Each of the digits 1-9 must occur exactly once in each column.
Each of the digits 1-9 must occur exactly once in each of the 9 3x3 sub-boxes of the grid.

@aaryahjolia  Hello sir,can you please assign this issue to me

Hey @Shweta2024 , It's nice to see the project title and your enthusiasm to contribute to this repo.
Currently, We are not accepting any Projects based on DSA.
If we open up projects section, You'll be informed in future.
Hope you have a great day!


Support NumPy .npy format

See https://numpy.org/devdocs/reference/generated/numpy.lib.format.html for details.
Used by, for example, https://zenodo.org/record/4476506#.YBLo9NbTVH4. See also #1080!
This should be straightforward to implement. Essentially the raw reader, just that the shape and dtype can be read from the header, and data has a small offset for the header.
This could be a good starting point into developing a file format reader, i.e. "good second issue".

Duplocate of #222, closing in favor of that!


chore(lint): enable nonamedreturns linter

enable nonamedreturns linter
fix code which was highlighted by nonamedreturns

Fixes #708

@allnil
thanks.
right now, we have 2 PIPs (PIP-8,PIP-9) that we've implemented them/we're implementing them so you're changes will make conflict with existing PRs etc...
maybe merging your PR takes a bit more time but we will merge it as soon as possible.

@allnil Thank you. We hope to see you more on Pactus.
Join us on Discord, where we discuss core development further.


Claim provider to add user logged in organization ID and name to ID token

Purpose

$subject

closing with PR https://github.com/wso2-enterprise/identity-org-mgt-connector/pull/119


remove v1beta1 folder move AMM proto files

to allow easy build with  ts-client

also remove PoolId and Sender from QuerySwapExactAmountInRequest


Fix unix pipe transport 'repr' methods (issue #314)

This PR is a fix proposal for the following issue:

#314 connect_read_pipe causes "Exception ignored in:" on program exit.

It includes a test method to reproduce the original issue.

LGTM, can we merge this?

LGTM, I'll merge it later today.

Pushed in 39b87620dbaf6278170c083401e2ae3e7601ff18

Thanks, Vincent!

Committed in CPython in https://hg.python.org/cpython/rev/d4facabab91a

Great! I guess the issue #314 should be closed now?

Yep ;)


Deploy Error - Your Apple ID account is attached to other iTunes providers

I get an error on “Your Apple ID account is attached to other iTunes providers. You will need to specify which provider you intend to submit content to by using the -itc_provider command. Please contact us if you have questions or need help. (1627)”.
I don’t understand at all.
I added Team ID and Team Name. In Application Loader it works perfectly. Please help!

Hi @yadits ,
This seems to be a duplicate of https://discuss.bitrise.io/t/deploy-to-itunes-connect-error/4774
I'll close this here, please contribute to the discussion at https://discuss.bitrise.io/t/deploy-to-itunes-connect-error/4774 ! Thanks and Happy Building! :)

Why did you close this? I'm am the one who opened the discussion in Bitrise and was told to open an issue here. I know that that I'm not using the same username - since it was already taken.
Anyway, I need an answer this still doesn't work!

Hi @yadits ,
sorry for the inconveniences!
Could you please have a look at my answer on discuss: https://discuss.bitrise.io/t/deploy-to-itunes-connect-error/4774/11?u=godreikrisztian

It works, thanks a lot. I needed to write --itc_provider TEAM_ID

Thanks for reporting @yadits ! :)

Thanks for the info!
Just closing this issue as it is resolved now. Feel free to open a new issue if you still encounter any issues!


gitg: use wrapGAppsHook, pull in dconf

Motivation for this change
I don't wanna resize the window every time I open gitg. Also wrapGAppsHook seems pretty cool I guess.
Things done

[ ] Tested using sandboxing
(nix.useChroot on NixOS,
or option build-use-chroot in nix.conf
on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] OS X
[ ] Linux

[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

Without dconf, gitg doesn't remember preferences such as window size.

Looks good to me.


menu: add answermode command

This will fix #776

@seamus-45 many thanks for writing the code for this command :)


[Information Request] PASS2 control file identification.

Do we have any identification (file name) for PASS2 control statements used to generate C0F system (loaded off cpcp.tap tape image), or should we rather hunt one on original Siggy-format tapes? Want to compare this vs original system images available on bitsavers.org (need to hunt for FRES too) and hopefully bostrap more recent version of CP-V.

$PASS2 restored from CPCP tape is commented as generating C0P system:

                                                                *

   C0P OPERATING SYSTEM FOR ANDREWS UNIVERSITY                  *

                                                                *

Which seems in line with tape naming ( CPCx => C0x ). Analogously $PASS2CPCO.:SYS contains control for C0O, yet system we start reports as C0F:
...
8:             GJOB 9DIAG,:SYS ERR
6:             ONLINE =   0
6:             BATCH  =   0
6:             FRI, FEB 17,'78 C0F
...
So it keeps me wondering, -11 also gives good impression how $PASS2.:SYS on #00B0 tape (file name c00b.tap on Bitsavers) would look. Thanks for sharing good news re F00, I won't lie, hoping to stumble on EDMS someday, though just being able to review all SDS9xx Bitsavers tapes (looking like archived in CP-V FSAVE format of all things) is also something to hold to.
JK

Then would you like to close this issue?

I can, yet I wonder if you'll be interested in keeping it open as a channel of discusion on system generation topics. Hopefully more people will find this system interesting

I think it will be better to address individual system topics as separate explicit issues.


Sliding along and off flat faces leaves previous contacts stuck in the contact list.

Godot Version:
v3.2.2.stable
Branch:
3.x
Issue Description:
Sometimes when you slide the flat face of a shape off another shapes, contacts from that collision remain permanently stuck in the contact list. I say 'sometimes' because there are instances where it doesn't happen. But for the most part it's pretty consistent. The old contacts will continue to build up with each slide off until the limit of contacts_reported has been reached.
See example .gif below (contacts_reported is set to 2):

As you can see, normal detachments work as expected. It's only those moving on the axis parallel to collision that have issues. I've only encountered this problem with flat faces (i.e. RectShape, PolygonShape, and flat sides of CapsuleShape). Curved faces are fine (i.e. CircleShape and curved sides of CapsuleShape). Interestingly, get_colliding_bodies() does not suffer and continues to work correctly.
Steps to reproduce:
Open the minimal reproduction project, turn on 'Visible Collision Shapes' and run the main scene. WASD moves the left box. Arrow keys move the right one. The labels in the top left corner show the results of get_contact_count() and get_colliding_bodies() for the former. Push the two boxes together so that they're colliding. Then move either along the parallel colliding axis until the faces no longer touch. Do this multiple times.
Minimal reproduction project:
Phantom.Contacts.Test.zip

Just realized in the gif. The lower label is meant to say get_colliding_bodies().

Looks like it may be a bug with the way that contacts from box2d are buffered. Still looking for the exact root of the issue.

In the original implementation, I missed a case in which the b2PointState in PreSolve swaps indices (I assumed add/remove are in the same index). This resulted in a previously tracked contact being overwritten, preventing it from ever being removed.

Thanks for the bug report :)


Memory leak with regex

Hi,

I'm using the latest version (1.0.1) of your component with Vapor 3.
As you can see I have an issue with the 'matchingStrings'. For some reason I do not know the regex would take memory but would not release it later.

May be you can read this article: Regular Expressions without NSRegularExpression

You can also take a look at this component: Regex - A pure Swift NFA implementation of a regular expression engine

@TofPlay I'm using this library... Would that leak be an issue I would need to worry about? Maybe you have a fork if @malcommac doesn't have a fix?


How to run the app?

I'm not a very coding intensive person, although I do grasp the majority of concepts and ideas, but I can not for the life of me find a way to run this thing. There's no assistance through googling MultiFunPlayer, nor is there anything pertaining this in the Readme, other than "run the application". Some help would be greatly appreciated here.

I found my own answer lol, took me a whole 3 minutes of further searching on here to find it. I would just throw something into the Readme for the master directing whoever reads it to the actual folder, since that's where I got hung up at thinking it was the files needed, just a link would do just in case.


[Issue] When trying to generate a component hierarchy, I get an error about max call stack size exceeded

When trying to generate a component hierarchy, I get an error about max call stack size exceeded.
Here is the VS code notification message:

Error loading webview: Error: Could not register service worker: InvalidStateError: Failed to register a ServiceWorker: The document is in an invalid state..

A stack overflow is usually caused by some recursive code, but there are no recursive code in the Angular Tools extension. And the error occurred in the webview which indicates an issue with the vis-network Javascript component.
So I have updated the vis-network component to the latest version and I hope that solves the issue.
Please update to v1.12.0 of the vscode-angulartools extension and see if the update solves the issue.


Use Eclipse Collections' primitive HashSet IntHashSet

ConnectedComponents leans heavily on HashSet<Integer> but it is bloated and slow. Eclipse Collections has a faster primitive IntHashSet. This PR swaps out HashSet<Integer> for IntHashSet. Performance improvement for larger images is on the order of 20%
//With IntHashSet
Particle labelling finished in 56 ms
Particle labelling finished in 53 ms
Particle labelling finished in 58 ms
Particle labelling finished in 43 ms
Particle labelling finished in 51 ms
Particle labelling finished in 222 ms
Particle labelling finished in 225 ms
Particle labelling finished in 258 ms
Particle labelling finished in 198 ms
Particle labelling finished in 253 ms
Particle labelling finished in 1156 ms
Particle labelling finished in 833 ms
Particle labelling finished in 1006 ms
Particle labelling finished in 758 ms
Particle labelling finished in 931 ms
Particle labelling finished in 10807 ms
Particle labelling finished in 11290 ms
Particle labelling finished in 9787 ms
Particle labelling finished in 10237 ms
Particle labelling finished in 9911 ms
Particle labelling finished in 83828 ms
Particle labelling finished in 75762 ms
Particle labelling finished in 75234 ms
Particle labelling finished in 64712 ms
Particle labelling finished in 67332 ms
//bonej-7.0.1
Particle labelling finished in 53 ms
Particle labelling finished in 48 ms
Particle labelling finished in 68 ms
Particle labelling finished in 55 ms
Particle labelling finished in 70 ms
Particle labelling finished in 237 ms
Particle labelling finished in 214 ms
Particle labelling finished in 239 ms
Particle labelling finished in 208 ms
Particle labelling finished in 182 ms
Particle labelling finished in 1021 ms
Particle labelling finished in 1077 ms
Particle labelling finished in 1359 ms
Particle labelling finished in 1346 ms
Particle labelling finished in 1257 ms
Particle labelling finished in 14164 ms
Particle labelling finished in 15563 ms
Particle labelling finished in 11314 ms
Particle labelling finished in 12564 ms
Particle labelling finished in 11975 ms
Particle labelling finished in 90115 ms
Particle labelling finished in 101046 ms
Particle labelling finished in 84493 ms
Particle labelling finished in 93437 ms
Particle labelling finished in 84424 ms

Looks good. @mdoube There was some kind of hiccup on the Travis build for 94a4761, but when I ran it again it passed. Seems to be passing now too.

Benchmarking for loop style change:
//old-style for (int i = 0; i < max; i++)
Particle labelling finished in 51 ms
Particle labelling finished in 47 ms
Particle labelling finished in 66 ms
Particle labelling finished in 50 ms
Particle labelling finished in 62 ms
Particle labelling finished in 263 ms
Particle labelling finished in 242 ms
Particle labelling finished in 222 ms
Particle labelling finished in 184 ms
Particle labelling finished in 225 ms
Particle labelling finished in 988 ms
Particle labelling finished in 1070 ms
Particle labelling finished in 862 ms
Particle labelling finished in 899 ms
Particle labelling finished in 934 ms
Particle labelling finished in 11788 ms
Particle labelling finished in 11796 ms
Particle labelling finished in 10078 ms
Particle labelling finished in 10078 ms
Particle labelling finished in 9192 ms
//for (final int val : array) style loops
Particle labelling finished in 53 ms
Particle labelling finished in 60 ms
Particle labelling finished in 52 ms
Particle labelling finished in 48 ms
Particle labelling finished in 51 ms
Particle labelling finished in 179 ms
Particle labelling finished in 182 ms
Particle labelling finished in 216 ms
Particle labelling finished in 195 ms
Particle labelling finished in 216 ms
Particle labelling finished in 1026 ms
Particle labelling finished in 1052 ms
Particle labelling finished in 974 ms
Particle labelling finished in 973 ms
Particle labelling finished in 822 ms
Particle labelling finished in 10627 ms
Particle labelling finished in 10757 ms
Particle labelling finished in 9247 ms
Particle labelling finished in 9230 ms
Particle labelling finished in 9243 ms


[Snyk] Upgrade aws-sdk from 2.673.0 to 2.828.0

Snyk has created this PR to upgrade aws-sdk from 2.673.0 to 2.828.0.

:information_source: Keep your dependencies up-to-date. This makes it easier to fix existing vulnerabilities and to more quickly identify and fix newly disclosed vulnerabilities when they affect your project.

The recommended version is 158 versions ahead of your current version.
The recommended version was released 24 days ago, on 2021-01-14.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open upgrade PRs.
For more information:
🧐 View latest project report
🛠 Adjust upgrade PR settings
🔕 Ignore this dependency or unsubscribe from future upgrade PRs

Coverage remained the same at 99.383% when pulling abb220f18de31c76c07a86746a9b5961d59594a5 on snyk-upgrade-5846c1e88fdb7bf95496f60f1050e671 into 87dbeef9deaabbc23130cc563ef54f13021f5a57 on master.


Add performance testing

Given that we've now had our first proper performance bug (kak_decomposition being very slow), I think it's time that we added some kind of performance benchmarking process that can be run by the continuous integration scripts.
On another project, the way I did this was by decorating tests with a "performance goal" like this:
@perf_goal(avg_micros=50, args=[cirq.random_unitary_matrix()])
def test_kak_decomposition(matrix):
    return cirq.kak_decomposition(matrix)

And the test would fail if the code ran slower than the goal (and warn if it ran significantly faster than the goal). One particularly nice aspect of this approach is that the decorator can use the expected time to decide how many repetitions to perform, in order to balance statistical noise against total running time.
Overall, this issue involves:

Implementing the @perf_goal decorator (or some other mechanism for specifying performance tests)
Coming up with a convention for where we put performance tests (e.g. file_name_perf.py)
Hacking pytest's test discovery to ignore/include performance tests as appropriate, etc.
Checking that the performance of code running on Travis-CI is actually stable enough for this to be meaningful (that being said, we don't really need high precision measurements; this is just to put pressure against gradual decay).

A particularly tricky issue here is that performance bugs introduced by PR A may start causing flaky failures in PRs B-Z. It's not clear that we should block merging due to performance bugs, but then it's also not clear how we incentivize actually fixing the issues.

Can we have CirqBot create a new issue for every performance test that fails? Maybe for each pull request that breaks performance tests as there could be too many issues created with the first approach.

That's a decent idea. Test performance on PRs, but only really test it on master commits and when one of the tests starts failing open an issue (or update existing issue).

Assuming that the assert statement is in the decorator, If
@perf_goal(avg_micros=50, args=[cirq.random_unitary_matrix()])
def test_kak_decomposition(matrix):
    return cirq.kak_decomposition(matrix)

fails, pytest will show that it failed in the decorator instead of in test_kak_decomposition(). How do you get around that?

Assuming that the assert statement is in the decorator, If
@perf_goal(avg_micros=50, args=[cirq.random_unitary_matrix()])
def test_kak_decomposition(matrix):
    return cirq.kak_decomposition(matrix)

fails, pytest will show that it failed in the decorator instead of in test_kak_decomposition(). How do you get around that?

The decorator should produce a new test method that performs the actual testing. The new test method can also output stats such as what time was actually measured (since you usually want to hover somewhere around half of the goal due to statistical noise).

Something like this:
def perf_goal(avg_micros=0, ...):
    def decorate(func):
        def wrapped():
                assert duration(func, ...) < goal

        return wrapped
    return decorate

After some thought, I believe that using pytest-benchmark: https://pytest-benchmark.readthedocs.io/en/latest/ is better than rolling our own solution. The recent pull request calls benchmark() with our tests; which could mean slower build times. This begs the question: Do we want to run the benchmarks on every build? We could separate the benchmark tests and run them occasionally (once a week?). This could be done by passing --benchmark-skip(skip running any tests that contain benchmarks.) to pytest-benchmark on regular builds.
Addressing the comparisons, pytest-benchmark generates a .benchmarks/ which contains information about the performance of the benchmarks in the form of .json when provided with a --benchmark-autosave.  This data can be compared with with future builds using --benchmark-compare. Travis doesn't persist this data, so we will need to post it to a cloud storage and wget it when needed.

@Strilanc Having a file_perf_test.py will  (almost) duplicate code. For example:
decompositions_test.py
def test_kak_decomposition(target):
    kak = cirq.kak_decomposition(target)
    np.testing.assert_allclose(cirq.unitary(kak), target, atol=1e-8)

decompositions_perf_test.py
def test_kak_decomposition(target, benchmark):
    kak = benchmark(cirq.kak_decomposition, target)
    np.testing.assert_allclose(cirq.unitary(kak), target, atol=1e-8)

Is that fine?

Yes, that's fine.

We now have performance tests, right?  Should this be closed?

Not yet. The current implementation is not reliable because we don't persist performance data between builds. What we need to do is upload the .jsons that are generated to a remote location so we may reference them and implement a script that creates an issue if incremental  benchmark results fall below a threshold

OK so now it looks like we have this working checking for regressions.  Close?

@vtomole probably in a week or two we'll have a GCP project where we will be able to store these files, and I will be able to add you as a collaborator - are you interested in finishing this work then?

Currently, we have a bunch of performance tests using pytest-benchmark and the goal is to have an infrastructure where performance tests can be visualised across commits so that it is easy to monitor the trends across commits. (something similar to https://pv.github.io/numpy-bench/)
To achieve this, we can consider one of the following two options:
Airspeed Velocity
Project Link: https://github.com/airspeed-velocity/asv
High Level Overview

ASV is a performance benchmarking tool, similar to pytest-benchmarks.
We need to write performance tests in a specific format that asv recognises and it will plot nice interactive charts across commits.
We can use a custom webserver (eg: hosted on gcp) or github pages for visualisation.

Pros

Widely used & highly configurable. Eg: https://pv.github.io/numpy-bench/ (corresponding tests: https://github.com/numpy/numpy/tree/master/benchmarks/benchmarks)
Nice interactive charts out of the box.

Cons

We would need to port the already written performance tests from pytest-benchmark to asv.
Would take relatively longer to setup the configs.

Continuous Benchmark Github Actions
Project Link: https://github.com/marketplace/actions/continuous-benchmark
High Level Overview

A simple github actions that will run the existing pytest-benchmark tests, store the output in github pages branch and show plots across commits.
Example charts: https://rhysd.github.io/github-action-benchmark/dev/bench/

Pros

Quick and easy to protype and deploy. Eg: Sample prototype for cirq: https://tanujkhattar.github.io/Cirq/dev/bench/
Supports pytest-benchmarks so no need to rewrite existing tests.

Cons

Not sure whether pytest-benchmarks is sufficient for our usecase (??)
Out of the box charts are not as pretty as asv :)

I was looking into Airspeed Velocity for this before other things stole my time so i'm a bit biased towards it. I  still vote for it cause the charts look so much better than the Github actions charts. Those pretty charts are worth the bigger investment! Please bring this up at the Sync and be sure to show the Airspeed charts :grinning:.

On thing I love about ASV is that it makes it easy to see a long history of the repo with the thumbnail charts (e.g the numpy one has the first commit from 2015 - though it is not the oldest commit, they started in 2005 or something?)
Did you explore how you could do that with the github action benchmark?
One aspect is to know the current performance, but it would be important to see the trends over time. Is it just a matter of running a job that generates the json data historically? I guess we'll have to do that for ASV as well.

Generating historical data and plotting it is something that we'll have to figure out for the both the approaches. Once setup, both the approaches would automatically generate the performance data for every commit on master and show the numbers on the plots over time.
For github actions, they have a max-items-in-chart parameter that can be used to control how much history we want to preserve for each chart. Also, for github actions, charts are rendered using Chart.js and it should be possible to modify the index.html to render better charts using the same data, if needed.
The bigger question probably is that which one of pytest-benchmarks or asv do we want to use as a testing framework.


Unneccesary dashes in the UI

When you click New Job in the UI it shows dashes (-) for the NAME and COMMAND fields. If you don't remove the dash from COMMAND your Chronos job fails (e.g. sleep 10 vs -sleep 10). Also, if the dash is meant to denote required field, then its missing from the OWNER(S) field, which seems to also be required.

This tripped me up at first as well. If it is supposed to denote a required field, it would be better to reflect that in the field's label with an asterisk or something.


Certification tests cannot be run in dev container, windows or WSL

Expected Behavior
Documented Dapr developer environments should support all related developer activities including running certification tests.
As a min bar, there probably needs to be some additional documentation around the dev experience for writing and running certification tests (analogous to tests/conformance/README.md perhaps) that calls out the supported platforms.
Actual Behavior
The tests/certification/flow/network component for network interruption tests relies on github.com/tylertreat/comcast/throttler that basically wraps calls to linux CLI tools such as tc, dnctl etc. The library is unsupported on Windows, and is unable to find the appropriate qdisc in a containerized/virtualized environment (devcontainer or WSL).
Steps to Reproduce the Problem
Run any certification test using the InterruptNetwork function in the components-contrib devcontainer, or on Windows in native shell or WSL.
Release Note

RELEASE NOTE:

@pkedy if you're writing docs for the certification tests, just call this out and this can probably be parked as by-design.


Check for empty proxy hosts

Describe the bug
We're seeing the following issue in our logs which I've tracked down to EnvironmentProxySelector
Caused by: aws.smithy.kotlin.runtime.ClientException: Could not parse http.proxyHost="", http.proxyPort="0" into a valid proxy URL
Expected behavior
Ideally the EnvironmentProxySelector would check the length of the proxy host before attempting to use it, like DefaultProxySelector does here
Current behavior
If SQS detects an value for proxy_host, even if it's empty, it will attempt to use it and the connection will fail.
Steps to Reproduce
I'm not entirely sure how this is being set in the wild, but we've been able to reproduce it by setting the property before initialising the SQS client
System.setProperty("http.proxyHost", "")
Possible Solution
Check the length of the host value before using the proxy settings
Context
No response
Smithy-Kotlin version
1.25
Platform (JVM/JS/Native)
JVM
Operating system and version
Android 8/9/10

Hi @ScottRoo, thanks for the bug report. I've merged a PR to address empty/blank proxy hosts and it should be available in tomorrow's aws-sdk-kotlin release v1.2.28.

Amazing, thanks for the quick turnaround @ianbotsf


VQ-GAN could not use GPU for training

I trained the VQ-GAN, but the GPU are not used for acceleration. Could you tell me why?
the training command is following:
CUDA_VISIBLE_DEVICES=1 python main.py -b configs/brats_vqgan.yaml -t True --gpus 0

But the memory of gpu does not change.

hi, i want konw do you use seg data? original spade module seems need label (seg) data.


Complete comparison with SOTA methods

Hello
How are you?
Thanks for contributing to this project.
I found that your method was compared with ONLY yolov5, yolov6, yolox of SOTA light-weight object detectors.
Can we see the comparison with yolov7 and yolov8 too?

What is the difference between two diagrams?

ap50: 50%重合度阈值下的准确度（工业界更看重这个）
ap50:95：50%、55%、...、95%重合度阈值下的准确度的平均数（学术上更看重这个）

请问作者，文中的AP50是否等于MAP50？


Missing Moon Icon

First of all, I want to say I love your project! I'm currently working on adding dark and light mode functionality to my app. However, I noticed that the Moon icon, which is essential for toggling between the modes, is missing from the available icons.
Would it be possible to add a Moon icon to the library? It would be incredibly helpful for implementing a seamless user experience in my app.
Thank you for your amazing work and for considering this feature request! 😊

thank you for your words 🫶
moon icon added! d7c42e29edf7ae0e5f46fa6456ed09bfd17a55f3

No worries, if you want you can check on Heroicons website to find some icons you forgot. 👍🏼

No worries, if you want you can check on Heroicons website to find some icons you forgot. 👍🏼

thanks!


fix helm chart cannot upgrade issue

What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:

Fixes #200
Special notes for your reviewer:

Codecov Report

Merging #202 (2968c3c) into main (388f98a) will not change coverage.
The diff coverage is n/a.

:exclamation: Current head 2968c3c differs from pull request most recent head f42948d. Consider uploading reports for the commit f42948d to get more accurate results

@@          Coverage Diff          @@
##            main    #202   +/-   ##
=====================================
  Coverage   7.97%   7.97%
=====================================
  Files         29      29
  Lines       3837    3837
=====================================
  Hits         306     306
  Misses      3508    3508
  Partials      23      23

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 388f98a...f42948d. Read the comment docs.


Resource loading should be done differently

There sould be a single class to do all lexemes loading, and a single class to do all texts loading.
class ParsedVocabulary {
  ParsedWords(Collection<InputStream> sources) {
    this.sources = sources;
  }
  @Lazy Map<String, Lexeme> lexemes() {
    // Functional pipeline that constructs lexemes from source markup
  }
}

class ParsedTextuary {
  ParsedTextuary(Collection<InputStream> sources) {
    this.sources = sources;
  }

  @Lazy Map<String, TextWithPlaceholders> texts() {
    // Functional pipeline that constructs texts with placeholders from source markup
  }
}

Replaced with #54


[Proposal] Using Gymnasium instead of Gym

Proposal
Can we adopt Gymnasium instead of Gym? Both on package requirement and in Readme.md?
Motivation
Gym will not maintained anymore.

The team that has been maintaining Gym since 2021 has moved all future development to Gymnasium, a drop in replacement for Gym (import gymnasium as gym), and this repo isn't planned to receive any future updates. Please consider switching over to Gymnasium as you're able to do so.

Pitch
Substitute  import gym  with
import gymnasium as gym

in the following contexts:

Readme.md
Site documentation
Any code example
package requirements

@justinjfu

Hi,
As mentioned in the Readme, D4RL is currently being decommissioned and transferred to Gymnasium-robotics and Minari. Therefore, it is not intended to update D4RL itself, but it is being kept around for legacy/reproducibility purposes.
I hope this clears up any confusion. If you have any questions please let me know.

Everything clear, thanks :)


Ensure SRP BN_mod_exp follows the constant time path

SRP_Calc_client_key calls BN_mod_exp with private data. However it was
not setting BN_FLG_CONSTTIME and therefore not using the constant time
implementation. This could be exploited in a side channel attack to
recover the password.
Since the attack is local host only this is outside of the current OpenSSL
threat model and therefore no CVE is assigned.
Thanks to Mohammed Sabt and Daniel De Almeida Braga for reporting this
issue.

1.1.1 version in #13889

1.1.1 version in #13889

Pushed. Thanks.

Pushed. Thanks.

reference to ubuntu bug report https://bugs.launchpad.net/ubuntu/+source/openssl/+bug/1915906


Fixed #30865 -- Fixed documentation for DATABASES['OPTIONS'] not passed ed for dbshell

Some of the DATABASES['OPTIONS'] were not passed to the dbshell, added the documentation pointing
the same.
Signed-off-by: Farhaan Bukhsh<EMAIL_ADDRESS>

Thanks a lot @codingjoe for the review, I will try to improve the wording and put in an example. Your review means a lot and thanks again for encouraging me.

@codingjoe  can you please have a look when you get some time, thanks in advance, also I left a comment on the ticket about isolation level option, if you could have a look at that too it will be great. 😄

@farhaanbukhsh Welcome aboard :boat:

@felixxm thanks a ton :smile: , can you point me to next ticket that I can pick up? Any specific ticket you have in mind. I am on IRC by the nick fhackdroid. :smile:

@farhaanbukhsh you can always review existing patches 😉


Display the account balance at the main page

Base on research most of the people log in to CPF account to check their balance.
Work need to be done,

Display account balance in graphic image on the main page.

Merged in jj branch.
Commit: 0079a76126bbecc25423faf800c404c8bc78a754

Merged in jj branch.
Commit: 0079a76126bbecc25423faf800c404c8bc78a754


Please release in the Shopware Store for 6.4.8.x

Question
Please release in the Shopware Store for 6.4.8.x

Hi there, I would also like to know when it will be ready for sw 6.4.8.x ?

Should be now


Error: Table has no Columns

Goals
I wanted to use RealmSwift to store and load my model data.
Expected Results
I expected my example model object to be stored
Actual Results
I got the error: Terminating app due to uncaught exception 'RLMException', reason: 'Table has no columns'
Steps to Reproduce
create an data model and let it inherit from Object. Now try to store it.
Code Sample
see this pastebin
In the code sample you can see that i have many fields. So there is no reason for the "no columns" error.
Version of Realm and Tooling
Realm version: 1.1.0
Xcode version: 8.0
iOS/OSX version: 10.11.5

Most properties of Swift classes that you wish Realm to persist must be declared with the dynamic modifier to allow Realm to manage them. See the Property Cheatsheet in the Realm Swift documentation for a quick overview of how to declare properties of various types.

dynamic var id: Int64! Property cannot be marked dynamic because its type cannot be represented in Objective-C

Ok Thank you. That solve the first problem. But another problem appeared.
I changed everything to dynamic. Now i get another error:
fatal error: init(realm:schema:) has not been implemented
There is also nothing mentioned about that in the setup and go documentation. How should i implement this method?

RealmDemo[2494:552449] *** Terminating app due to uncaught exception 'RLMException', reason: 'Table has no columns'
*** First throw call stack:
(
0   CoreFoundation                      0x0000000104c3134b __exceptionPreprocess + 171
1   libobjc.A.dylib                     0x000000010469221e objc_exception_throw + 48
2   RealmDemo                           0x000000010378e098 _ZL18createRowForObjectRK12RLMClassInfo + 136
3   RealmDemo                           0x000000010378c9be _ZL23createOrGetRowForObjectIU8__strongU13block_pointerFP11objc_objectP11RLMPropertyEEmRK12RLMClassInfoT_bPb + 526
4   RealmDemo                           0x000000010378b48a RLMCreateObjectInRealmWithValue + 2570
5   RealmDemo                           0x000000010377839a +[RLMObject createInRealm:withValue:] + 138
6   RealmDemo                           0x000000010365f759 __29-[ViewController viewDidLoad]_block_invoke + 137
7   RealmDemo                           0x00000001038a8e66 -[RLMRealm transactionWithBlock:error:] + 86
8   RealmDemo                           0x00000001038a8dce -[RLMRealm transactionWithBlock:] + 62
9   RealmDemo                           0x000000010365f658 -[ViewController viewDidLoad] + 888
10  UIKit                               0x00000001052eac99 -[UIViewController loadViewIfRequired] + 1258
11  UIKit                               0x00000001052eb0cc -[UIViewController view] + 27
12  UIKit                               0x00000001051b4c51 -[UIWindow addRootViewControllerViewIfPossible] + 71
13  UIKit                               0x00000001051b53a2 -[UIWindow _setHidden:forced:] + 293
14  UIKit                               0x00000001051c8cb5 -[UIWindow makeKeyAndVisible] + 42
15  UIKit                               0x0000000105141c89 -[UIApplication _callInitializationDelegatesForMainScene:transitionContext:] + 4818
16  UIKit                               0x0000000105147de9 -[UIApplication _runWithMainScene:transitionContext:completion:] + 1731
17  UIKit                               0x0000000105144f69 -[UIApplication workspaceDidEndTransaction:] + 188
18  FrontBoardServices                  0x00000001080e6723 FBSSERIALQUEUE_IS_CALLING_OUT_TO_A_BLOCK + 24
19  FrontBoardServices                  0x00000001080e659c -[FBSSerialQueue _performNext] + 189
20  FrontBoardServices                  0x00000001080e6925 -[FBSSerialQueue _performNextFromRunLoopSource] + 45
21  CoreFoundation                      0x0000000104bd6311 CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE0_PERFORM_FUNCTION + 17
22  CoreFoundation                      0x0000000104bbb59c __CFRunLoopDoSources0 + 556
23  CoreFoundation                      0x0000000104bbaa86 __CFRunLoopRun + 918
24  CoreFoundation                      0x0000000104bba494 CFRunLoopRunSpecific + 420
25  UIKit                               0x00000001051437e6 -[UIApplication _run] + 434
26  UIKit                               0x0000000105149964 UIApplicationMain + 159
27  RealmDemo                           0x000000010365fc0f main + 111
28  libdyld.dylib                       0x0000000106b2068d start + 1
)
libc++abi.dylib: terminating with uncaught exception of type NSException

and i have the same trouble,i have the subclass of RLMObject,when I call RLMRealm *realm = [RLMRealm defaultRealm];,crashed.appreciate your answer

@luchaoqun123 this is an issue that's been closed for several weeks. Please open a new issue with more information and steps to reproduce.

@jpsim OK


Add files via upload

Added portuguese school named Escola Profissional Bento de Jesus Caraça

@leo-snczki First stage of verification passed, official domain for Escola Profissional Bento de Jesus Caraça is alunos.epbjc.pt as far as I verified. This is just an informational note. Pull request is still in the review. I appreciate your patience while waiting for the final decision.

@leo-snczki Thank you for your patience while waiting for a review and processing your request. Pull request merged.
Please start requesting the licenses in about an hour, to let the changes to propagate through our system.

Thanks! It is already working!


Update all dependencies

Not updating gulp-typescript because we're on the latest non-alpha release.

Only autorest is left. I'm unable to run it on any of my machines either on master or after updating, so I'm reluctant to change it.
Node types shouldn't go up because we only support Node 10.


How to space between  nodes without using hierarchical ?

Hello , i have a large graph , so when i set the option hierarchical in options layout my graph becomes not visible enough , that's why i decided to not use hierarchical and let it like normal . I want just to put some space between nodes . Is there any way to set nodes space without getting through hierarchical property ?
Here is my options :
            `         var options = {
                     width:  '100%',
                      height: '100%',
                     layout: {
                       randomSeed:1,

                      },
                edges: {
                    arrows: {
                        to: {
                            enabled: true
                        }
                    },
                    smooth: {
                        enabled: false,
                        type: 'continuous'
                    }
                },

                physics: {
                    enabled:false ,
                },

            };`

Hi @asmakhalfallah2018,
you can fire physics manually to place the nodes by calling network.stabilize(). This way you can take advantage of all the things physics can do without enabling it:
const options = {
  edges: {
    length: 400 // Longer edges between nodes.
  },
  physics: {
    // Even though it's disabled the options still apply to network.stabilize().
    enabled: false,
    solver: "repulsion",
    repulsion: {
      nodeDistance: 400 // Put more distance between the nodes.
    }
  }
};

// Create the network.
const network = new vis.Network(container, data, options);

// Run physics once to space out the nodes.
network.stabilize();

thanks @Thomaash  . It works

this doesnt work


Return key to regenerate graph only works after double-tap when cursor is not at the end of the query field

Steps to reproduce:

Enter and run a query in a notebook (e.g. sum(rate(microservices_demo_user_request_count[5m])) by (name))
Press enter
Note the query runs as a graph
Move cursor back and edit the query, leaving your cursor in the middle (e.g. change name to method)
Press enter
Note, the graph has not updated
Press enter again
Note, the graph has now updated.

Expected behaviour:
The graph should update when I press enter the first time, even when not at the end of the query.

Thanks Paul; this is a known issue (weaveworks/service-ui#545), I'll try and bubble it up with @davkal.

This issue was moved to weaveworks/service-ui#789


Missing U turn validator

From https://github.com/osmlab/osmlint/issues/264
Result: https://gist.github.com/anonymous/9f96466f3c79ec039f63dccc04389103
It may take 5 min processing for USA in a 8 core computer.
execute.
osmlint missinguturn  usa.mbtiles > output.json
osmlinth -t output.json --type Point > output-point.js
osmlinth -g output-point.js > output-point.geojson

cc. @karenzshea


fixing bug on scs warmstart

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Coverage increased (+0.02%) to 82.7% when pulling 49ac8fcf23d6e3150156c8679c60de5da8edf1b1 on enzobusseti:master into 4eacd25519ed3bc8e13edd4d10c784d3447097e2 on cvxgrp:master.

Coverage increased (+0.02%) to 82.7% when pulling 49ac8fcf23d6e3150156c8679c60de5da8edf1b1 on enzobusseti:master into 4eacd25519ed3bc8e13edd4d10c784d3447097e2 on cvxgrp:master.

Coverage increased (+0.02%) to 82.7% when pulling 49ac8fcf23d6e3150156c8679c60de5da8edf1b1 on enzobusseti:master into 4eacd25519ed3bc8e13edd4d10c784d3447097e2 on cvxgrp:master.

Coverage increased (+0.02%) to 82.7% when pulling 49ac8fcf23d6e3150156c8679c60de5da8edf1b1 on enzobusseti:master into 4eacd25519ed3bc8e13edd4d10c784d3447097e2 on cvxgrp:master.

Thanks!


codecov shield?

Theoritically a badge for C projects could work but haven't spotted any around

If someone has seen any, please comment or PR :)


Allow custom captions on data source

Is there a way this plugin can be used when using data source? See https://photoswipe.com/data-sources/. If so please provide an example.
It looks like this plugin requres PhotoSwipeLighbox object, but we also make it run for PhotoSwipe one?

yes, you may use captionContent option
captionContent: (slide) => {
  console.log(slide.data);
  return slide.data.myCaption;
}

assuming slide data is something like:
{
  src: 'image.jpg',
  width: 300,
  height: 300,
  myCaption: 'caption text'
}

It looks like this plugin requres PhotoSwipeLighbox object, but we also make it run for PhotoSwipe one?

For now - no, but I'll probably allow it in future versions, feel free to submit pr too.

Thanks!


Issue#40 - Dechat Services

The dechat services have been fully documented.

The documentation is good, but somewhy tests aren't passing.
Once we manage to make Travis pass, we can merge.

Ready to go


Build break on Registry types

I don't know how this is building in Azure Pipelines. The SignService is targeting netcoreapp3.1 but not referencing the Microsoft.Win32.Registry package. So local builds fail with this:
Utils\mansign2.cs(877,27): error CS0103: The name 'Registry' does not exist in the current context [D:\git\SignService\src\SignService\SignService.csproj] Utils\mansign2.cs(881,33): error CS0103: The name 'RegistryValueKind' does not exist in the current context [D:\git\SignService\src\SignService\SignService.csproj]
Utils\mansign2.cs(881,68): error CS0103: The name 'RegistryValueKind' does not exist in the current context [D:\git\SignService\src\SignService\SignService.csproj]

Is this really a configuration fail on my part somehow?
I'd like to send a PR that fixes the build break on my machine. I'd just feel better knowing how it works for anybody else.

This is because of a bug in the 302 SDK.

I stand corrected. It does fail in Azure Pipelines before my fix.


Specialize keyname from str to enum in storage

Hello,
According to the spec here:
https://msdn.microsoft.com/en-us/library/azure/mt163567.aspx
keyName can only be the string key1 or key2.
Then this should be an enum and not a string.
Please tell me if I can enhance this!
Thank you!

@emgerner-msft thoughts on this?

In the next version of the library we will be moving to key name having more possible values. Therefore we are not making this an enum and leaving it as a string. Thanks though!

Thank you! I give up this then ;)


Sync with rust HEAD (525aa610)

This will not compile on stable because of the unstable ?...

@marcusklaas That would be nice to update that PR to current rustc, hopefully fixing https://github.com/serde-rs/aster/pull/77 and then https://github.com/servo/rust-layers/pull/234

Actually trying that in https://github.com/serde-rs/syntex/pull/43

:umbrella: The latest upstream changes (presumably #44) made this pull request unmergeable. Please resolve the merge conflicts.

Thanks for this! I ended up merging a separate implementation though.


Enable running the e2e tests in parallel groups

@henderiw mentioned on a call that he runs some things in parallel. I think we can do that in the general test runs. This implements it.
/hold

Rebased

/hold cancel
This is working now. We can try updating the Prow job to execute with the parallel mode.

Maybe we have to set a meeting to discuss this. Testing things in parallel have several considerations about dependencies and log messages. Another thing to consider is to isolate every test, having a setup and teardown methods can be useful.
This metric can help us to prioritize some tests

Yeah, understood. Just trying to cut the time for e2e. I think this cuts it pretty substantially (maybe ~50%).

Yeah, understood. Just trying to cut the time for e2e. I think this cuts it pretty substantially (maybe ~50%).

By the way, this PR does not enable this by default - you still have to call the tests with a special parameter to get parallel behavior.

Yeah, understood. Just trying to cut the time for e2e. I think this cuts it pretty substantially (maybe ~50%).

By the way, this PR does not enable this by default - you still have to call the tests with a special parameter to get parallel behavior.

That's fine, maybe we should start collecting some metrics to have better understanding of where to improve.

BTW, it's amazing to finally see e2e in green

Agreed!!!

rebased

This is a quick overview of the e2e execution

Action
Time

Sandbox creation
759 secs

Deploy regional workload cluster
235 secs

Deploy edge clusters
730 secs

Deploy free5gc-cp to regional workload cluster
112 secs

Deploy free5gc operator to all workload clusters
152 secs

Deploy free5gc UPF to edge clusters
358 secs

Deploy free5gc AMF and SMF to regional clusters
307 secs

Deploy ueransim to edge clusters
371 secs

Vertically Scale free5gc UPF in Edge Clusters
291 secs

Vertically Scale free5gc SMF in Regional Clusters
26 secs

Last couple failures have been this flake: Internal error occurred: error applying patch: conflict: fragment line does not match src line. I think https://github.com/GoogleContainerTools/kpt/pull/3993 will fix this issue. I am running Nephio e2e tests with that build of Porch now.

@electrocucaracha taking your table and mapping it to the groups:

Group
Action
Time

n/a
Sandbox creation
759 secs

A
Deploy regional workload cluster
235 secs

A
Deploy edge clusters
730 secs

B
Deploy free5gc-cp to regional workload cluster
112 secs

B
Deploy free5gc operator to all workload clusters
152 secs

B
Deploy free5gc UPF to edge clusters
358 secs

B
Deploy free5gc AMF and SMF to regional clusters
307 secs

C
Deploy ueransim to edge clusters
371 secs

D
Vertically Scale free5gc UPF in Edge Clusters
291 secs

E
Vertically Scale free5gc SMF in Regional Clusters
26 secs

Roughly speaking, we should expect the times for each group to be the same as the max test time for the group. So in Group A we save 235 seconds, in Group B we save 112 + 152 + 307 = 571 seconds for a total savings of just over 10 minutes.

Roughly speaking, we should expect the times for each group to be the same as the max test time for the group. So in Group A we save 235 seconds, in Group B we save 112 + 152 + 307 = 571 seconds for a total savings of just over 10 minutes.

Makes sense, I'm trying to get some Ansible metrics to understand which task is consuming most of time

rebased

Not sure this is worth the complexity. Going to close it, we can revisit if we change think it will bring a big benefit.
/close


crypto/tls: TLS connections use small buffer size that results in small syscalls and ignore HTTP client transport buffer sizes

What version of Go are you using (go version)?

$ go version

`go1.16 darwin/amd6`

Does this issue reproduce with the latest release?
Yes.

I'm using this library: https://github.com/google/go-cloud to read files from S3 in a streaming fashion.
I noticed that a lot of time was being spent in syscalls:

I was aware of this issue: https://github.com/golang/go/issues/22618
So I tuned my http client read/write buffer transport sizes to be 256kib instead of 64kib but this had no impact on time spent in syscalls which made me suspicious that somehow the way the reads were being performed that reads were not actually being buffered as I expected.
I wrote a small program to download a file from S3 in a streaming fashion using large 1mib reads, like this:
stream, err := store.GetStream(ctx, *bucket, *path)
if err != nil {
    log.Fatalf("error getting: %s, err: %v", *path, err)
}
defer stream.Close()

buf := make([]byte, 1<<20)
    for {
        n, err := bufio.NewReaderSize(stream, 1<<20).Read(buf)
        if err == io.EOF {
            break
        }
        if err != nil {
            log.Fatal(err)
        }
	fmt.Println("n:", n)
}

I couldn't get dtrace to work properly on OS X, but luckily my application uses a custom dialer for setting write/read deadlines on every socket read so I was able to instrument the actual socket read sizes like this:
func (d *deadlineConn) Read(p []byte) (int, error) {
	d.Conn.SetReadDeadline(time.Now().Add(d.readDeadline))
	fmt.Println("read size", len(p))
	n, err := d.Conn.Read(p)
	err = maybeWrapErr(err)
	return n, err
}

What did you expect to see?
Large syscall reads (in the range of 256KiB)
What did you see instead?
Extremely small sys call reads:
read size 52398
n: 16384
n: 1024
n: 16384
n: 1024
n: 16384
n: 1024
read size 52398
n: 16384
n: 1024
read size 28361
read size 26929
n: 16384
n: 1024
n: 16384
read size 5449
n: 1024
read size 56415
read size 47823
n: 16384
n: 1024
n: 16384
read size 23479

What did you do after?
I made a small change in tls.go to instantiate the TLS client with a much larger rawInput buffer:
// Client returns a new TLS client side connection
// using conn as the underlying transport.
// The config cannot be nil: users must set either ServerName or
// InsecureSkipVerify in the config.
func Client(conn net.Conn, config *Config) *Conn {
	c := &Conn{
		rawInput: *bytes.NewBuffer(make([]byte, 0, 1<<20)),
		conn:     conn,
		config:   config,
		isClient: true,
	}
	c.handshakeFn = c.clientHandshake
	return c
}

As expected I began to observe much larger syscall reads:
read size 1034019
read size 1024035
read size 1022603
read size 1003987
read size 993963
read size 991099
read size 985371
read size 982507
read size 981075
read size 965323
read size 963891
read size 955299
read size 945275
read size 935251

I haven't tried deploying my fork to production, and measuring performance on my laptop is not interesting since I have a terrible connection to S3, but I think its well understood that a 10x increase in syscalls (especially with such a small read size of 64kib) has a dramatic impact on performance.
Proposal
I'm not 100% sure what the best approach is here, but I think we should do something since this issue means that streaming large amounts of data over TLS is much more CPU intensive than it needs to be which is a big deal for applications that process large volumes of data over the network like distributed databases.
The tls package already has a Config struct. It seems like it would be straightforward to add buffer size configuration there like has already been done for the HTTP transport. In addition, it seems reasonable that the HTTP client transport buffer sizes should be automatically propagated as the values for the TLS buffer size if the user doesn't specify a specific override.

Ok so to test my theory in production I wrote a custom TLS dialer that does some crazy unsafe stuff:
func (d *deadlineDialer) DialTLSContext(ctx context.Context, network, addr string) (c net.Conn, err error) {
	defer func() {
		if err != nil {
			err = maybeWrapErr(err)
		}
	}()

	var firstTLSHost string
	if firstTLSHost, _, err = net.SplitHostPort(addr); err != nil {
		return nil, err
	}

	cfg := &tls.Config{}
	cfg.ServerName = firstTLSHost

	trace := httptrace.ContextClientTrace(ctx)

	plainConn, err := d.dialer.DialContext(ctx, network, addr)
	if err != nil {
		return nil, err
	}

	tlsConn := tls.Client(plainConn, cfg)
	increaseTLSBufferSizeUnsafely(tlsConn)

	errc := make(chan error, 2)
	var timer *time.Timer // for canceling TLS handshake
	if d := transport.TLSHandshakeTimeout; d != 0 {
		timer = time.AfterFunc(d, func() {
			errc <- errs.NewRetryableError(errors.New("TLS handshake timeout"))
		})
	}
	go func() {
		if trace != nil && trace.TLSHandshakeStart != nil {
			trace.TLSHandshakeStart()
		}
		err := tlsConn.Handshake()
		if timer != nil {
			timer.Stop()
		}
		errc <- err
	}()
	if err := <-errc; err != nil {
		plainConn.Close()
		if trace != nil && trace.TLSHandshakeDone != nil {
			trace.TLSHandshakeDone(tls.ConnectionState{}, err)
		}
		return nil, err
	}
	cs := tlsConn.ConnectionState()
	if trace != nil && trace.TLSHandshakeDone != nil {
		trace.TLSHandshakeDone(cs, nil)
	}

        return tlsConn, nil
}

func increaseTLSBufferSizeUnsafely(tlsConn *tls.Conn) {
	var (
		pointerVal = reflect.ValueOf(tlsConn)
		val        = reflect.Indirect(pointerVal)
		member     = val.FieldByName("rawInput")
		ptrToY     = unsafe.Pointer(member.UnsafeAddr())
		realPtrToY = (*bytes.Buffer)(ptrToY)
	)
	*realPtrToY = *bytes.NewBuffer(make([]byte, 0, defaultHTTPTransportBufferSize))
}

After I deployed my service using the new dialer and a 256kib buffer size, all the time spent in syscalls more or less completely disappeared from my profiles.

CC @FiloSottile, @katiehockman, @rolandshoemaker, @kevinburke via owners.

+1 on this! Our database downloads new partitions to serve from S3 while it is serving reads, and we are considering rewriting our downloader component in a different language as these 4GB downloads must be squeezed through the syscall pipe that is at most 64KB wide due to the way Conn.rawInput works.
read syscall return values:
@bytes:
(..., 0)           87559 |@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@|
[0]                 1629 |                                                    |
[1]                 1287 |                                                    |
[2, 4)               103 |                                                    |
[4, 8)                54 |                                                    |
[8, 16)              464 |                                                    |
[16, 32)             121 |                                                    |
[32, 64)             134 |                                                    |
[64, 128)            213 |                                                    |
[128, 256)           666 |                                                    |
[256, 512)           608 |                                                    |
[512, 1K)            948 |                                                    |
[1K, 2K)            4310 |@@                                                  |
[2K, 4K)            6920 |@@@@                                                |
[4K, 8K)           25991 |@@@@@@@@@@@@@@@                                     |
[8K, 16K)          46532 |@@@@@@@@@@@@@@@@@@@@@@@@@@@                         |
[16K, 32K)         42064 |@@@@@@@@@@@@@@@@@@@@@@@@                            |
[32K, 64K)         16326 |@@@@@@@@@                                           |
[64K, 128K)          160 |                                                    |
[128K, 256K)           3 |                                                    |
[256K, 512K)           1 |                                                    |
[512K, 1M)             2 |                                                    |

Dupe of #20420.

Dupe of #20420.

I think it's related but not a dupe. #20420 is about negotiating over the protocol smaller individual records to reduce (the peer's) memory requirements. This is about reading from the wire more than one record at a time to reduce syscall overhead.

@FiloSottile what needs to happen to get this out of the backlog?  Is the proposal acceptable and a PR along those lines would be accepted?

Was refactoring some code and found a link to this issue above an extremely ugly hack I introduced to work around it :P Would be awesome to see this proposal accepted or an alternative proposed!

We obviously didn't get to this for 1.20 (sorry), but it is something on my radar to look at in 1.21.

Thanks for the workaround @richardartoul, I just used it as well. Any chance we can get this investigated for the next Go release?

Bump on this one; it seems the unsafe workaround hack mentioned in the issue is proliferating in the wild!

Any chance of pushing this improvement in the official release?

Note that growing the rawInput buffer is in tension with https://github.com/golang/go/issues/43563.

To expand a little: rawInput is currently designed to grow up to the maximum supported record size, such that we only hold a single max size record in the buffer at a time. This is nice because idle connections only consume at most one max size record worth of memory, but if the server is writing multiple records to the wire at a time, we will incur read overhead for each record.
We could massively grow the buffer, such that it can hold many records per read, but we would incur significant memory penalty for idle connections (bytes.Buffer can only grow, it cannot shrink). Similarly we could increase the max size of records, but we'd have the same problem.
It seems like the ideal solution is to increase the maximum size of rawInput, and use a sync.Pool of buffers (or, use the fancy new internal/weak package) to let large unused buffers to be garbage collected when they are no longer being used, gaining the performance win of recording multiple records at once, without the memory hit of keeping a bunch of large buffers sitting around when connections go idle.


Unable to generate 42cursus badge

This bug seems to occur only for 42yerevan users and only if it tries to generate a 42cursus badge.
C Piscine:

42cursus:

@all-contributors please add @aabajyan for code, bug


chore: add a script to automate nightly adaptation prs

The intention is to gradually add automation to this script (so on the happy path of no merge conflicts it all happens by itself, in CI even).
bors merge


Can it supports Visual Studio 2017?

Can it supports Visual Studio 2017?

No, this particular extension is for VS 2015 only.
However, VS 2017 now has built-in outlining capabilities, so this extension is no longer needed.


Mouse Events on Window Instead of DOM

cc @offirgolan
Closes https://github.com/alphasights/ember-scrollable/issues/59

Adding event listeners to window object
Instead of document.body, this allows for the mousemove being tracked even
outside of browser window, similar to how native browsers work.
If you drag and move the mouse outside of the browser window,
the scrollbar should still scroll until you mouseup

@nem-jmalatin let me know if this behaves as you expect.

@alexander-alvarez is this good to merge? Changes look good to me.

On my side yeah

🔔  @nem-jmalatin

@alexander-alvarez can you resolve these conflicts? I'll merge this and make a new release.

@offirgolan g2g


Geocoder.Providers.GoogleMaps query fails

with:
{:error, nil}
OpenStreetMaps works as expected

More details? Did you set up an API key?

I don't. Not so long ago API key was an option, now is neccesary as I read on Google site.
I close issue.


TEN-109 SA Blue Interrupt Page - view with basic controller

2 unit tests in your controller spec are current failing.


Error while converting from IR to CNTK (leaky_relu and upsampling2d)

Platform : win 10
Python version: 3.5.2
Source framework with version : keras with tensorflow 1.7.0 on CPU
Destination framework with version : CNTK 2.4 on CPU
Running scripts:
1. Convert the pre-trained model files to intermediate representation
$ mmtoir -f keras -w yolo.h5 -o yolov3
2. Convert the IR files to CNTK models
$ mmtocode -f cntk -d converted_cntk.py -n yolov3.pb -w yolov3.npy
Description:
Converted trained model yolo.h5 from Keras -> IR.
Got an error while converting from IR->CNTK.
The error while running the second command is at link: https://pastebin.com/pxBVmj10

Hi @almeida29 , does your keras yolo model come from YAD2K?

Hi kitstar

We took a pretrained model from Darknet: https://pjreddie.com/darknet/yolo/
We used the following project to convert yolov3 to keras: https://github.com/qqwweee/keras-yolo3
wget https://pjreddie.com/media/files/yolov3.weights
python convert.py yolov3.cfg yolov3.weights model_data/yolo.h5

Thanks.

Thanks @almeida29. We will try it. And did you test the inference correction after conversion?

Hi Kitstar
We didn't do inference correction as we were trying to get the model in cntk and then run the inference in the cntk framework.
Thanks.

Hi @almeida29 , please check the newest code. leaky_relu and upsampling2d is added to CNTK emitter. Here is readme. Thanks!

Hi, please try newest code
pip install -U git+https://github.com/Microsoft/MMdnn.git@master

Darknet related code hasn't been merged to offical release.

Hi @almeida29 .  Please try newest code. A small fix on py3 darknet parser. Thanks.

Thanks Kitstar.
The above command worked for me. The next step was to convert IR to CNTK

@almeida29   Have you install cntk in your python3?

Thanks @kitstar, I installed cntk in python3 and now am getting the following error while trying to save the cntk model:
(3point6) C:\Users\TestSystem>mmtomodel -f cntk -in cntk_yolov3_converted -iw darknet_yolov3.npy -o cntk_yolo_v3.dnn
Selected CPU as the process wide default device.
c:\users\TestSystem\appdata\local\programs\python\python36\lib\site-packages\cntk\core.py:82: RuntimeWarning: data is not C contiguous; rearrange your data/computation to avoid costly data conversions
RuntimeWarning)
Traceback (most recent call last):
File "C:\Users\TestSystem\AppData\Local\Programs\Python\Python36\Scripts\mmtomodel-script.py", line 11, in
load_entry_point('mmdnn==0.1.4', 'console_scripts', 'mmtomodel')()
File "c:\users\TestSystem\appdata\local\programs\python\python36\lib\site-packages\mmdnn\conversion_script\dump_code.py", line 67, in _main
ret = dump_code(args.framework, args.inputNetwork, args.inputWeight, args.outputModel)
File "c:\users\TestSystem\appdata\local\programs\python\python36\lib\site-packages\mmdnn\conversion_script\dump_code.py", line 28, in dump_code
save_model(MainModel, network_filepath, weight_filepath, dump_filepath)
File "c:\users\TestSystem\appdata\local\programs\python\python36\lib\site-packages\mmdnn\conversion\cntk\saver.py", line 3, in save_model
model.save(dump_filepath)
AttributeError: 'tuple' object has no attribute 'save'

Hi @almeida29
The outputs consist of there results in shape of ((1, 13, 13, 255), (1, 26, 26, 255), (1, 52, 52, 255), so it's a tuple.
You need to follow these steps:
mmtocode -f cntk -n xxx.pb -w xxx.npy -d cntk_yolov3_converted.py
python -m mmdnn.conversion.examples.cntk.imagenet_test -n cntk_yolov3_converted.py -w xxx.npy -i mmdnn/conversion/examples/data/dog.jpg -s darknet -p yolov3 --detect test
You can save the outputs file(*.npy) as the README

Hi @namizzz, I am looking to get the CNTK model as I eventually want to convert it to an ONNX model.
Is there a way to use mmtomodel script to do the conversion to CNTK .dnn model?

Hi @almeida29 , you can submit this issue to CNTK repo to see if there is a solution. Or we are working on ONNX Emitter and ping you if it is done. Thanks.

hi @almeida29，  I have the same problem as you. Have you succeeded in converting. dnn?

@whatlearn if it is still actual. In file with path which is printed in error such as "File "D:\Users\Paul\AppData\Local\Programs\Python\Python36\lib\site-packages\mmdnn\conversion\examples\cntk\imagenet_test.py"" try to change line 53 from self.model.save(path) to C.combine(self.model).save(path). It has solved my problem (just for yolov3 model).

@elevir  Thank you, but I want convert to YOLOv2, I will try your method


Branch update userguide

Codecov Report

Merging #187 (d10043c) into master (1bee1e9) will increase coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master     #187      +/-   ##
============================================
+ Coverage     47.68%   47.70%   +0.01%
  Complexity      501      501
============================================
  Files           110      110
  Lines          2483     2482       -1
  Branches        247      247
============================================
  Hits           1184     1184
+ Misses         1234     1233       -1
  Partials         65       65

Impacted Files
Coverage Δ

src/main/java/seedu/address/MainApp.java
0.00% <ø> (ø)

...in/java/seedu/address/model/person/Occupation.java
72.00% <ø> (ø)

.../seedu/address/logic/commands/EmailAllCommand.java
0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Discarding many changes in SCM fails with ENAMETOOLONG

VSCode Version: 1.11.0
OS Version: Win10

Steps to Reproduce:

Create very many  trackable changes in git.
Press 'Discard All Changes' action in the viewlet.
-> Git: spawn ENAMETOOLONG (see screenshot below)
Expectation: undo for all works with no errors, or user-friendly message presented what went wrong.

git checkout . works fine in the terminal though

please fix it quickly

To keep the number of issues in our inbox on a manageable level, we're closing issues that have been on the backlog for a long time but haven't gained traction: We look at the number of votes the issue has received and the number of duplicates issues filed.
Thanks for your understanding. Happy coding!


Linear approach explanation

Hey @leonidk, really interesting work! I am trying to understand your paper/implementation better, could you explain/derive how the "linear" approach is obtained from maximizing the Mahlanobis distance?

Here's a derivation. I guess the paper is a little sloppy in that it assumes the rays start at the origin. But the more general version (and the one in the code) is this:


Refresh images with better quality, caption them, minor lang edits

Codecov Report

Merging #249 (9ee2ef5) into master (6dda6b7) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #249   +/-   ##
=========================================
  Coverage     64.52%   64.52%
  Complexity      651      651
=========================================
  Files           117      117
  Lines          2692     2692
  Branches        277      277
=========================================
  Hits           1737     1737
  Misses          847      847
  Partials        108      108

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6dda6b7...9ee2ef5. Read the comment docs.


Pytorch version

Thank you for sharing excellent work!
I am wondering which version the code uses.
Thank you!

Thank you for your kind reply!

Thank you for your kind reply!


Add support for 16 bit PNGs to be used as normal maps for high resolution

Related to: https://forum.playcanvas.com/t/16-bit-normal-maps-how-to-get-them-in/5340
Some users are having issues with 8 bit PNG and 'stepping'. Being able to use 16 bit PNGs would help a lot

I agree with what @guycalledfrank says in the thread:

Browsers don’t load 16-bit precision data from PNGs at all. Nothing engine can do here. Suggestion: use geometry for large curved surfaces. Use normal maps for finer details.

You could potentially use some JS PNG decoder to get the data out, but this isn't something we'd be likely to add to the core engine repo (even as an example). Closing.


Corrected few file formats

Description
This PR fixes few file formats that would not be picked up automatically by editor
Related Issue
#484
Checklist

[x] I read and understood the contributing guide as well as the code of conduct
[x] My changes generate no new warnings
[x] My code builds and runs on my machine
[x] I documented my code
[x] Review requested

Screenshots

@austincondiff Sorry tagging here, can't assign reviewer


Fix SafetyNet attestation verification, add unit tests

Related to #153, SafetyNet attestation verification broke when System.IdentityModel.Tokens.Jwt was updated.  Fixed in similar fashion.

Refactor SafetyNet attestation verification

Add SafetyNet attestation verification unit tests

All 172 conformance tests pass with conformance tool version 1.3.4.


Update country codes

This adds the United States Minor Outlying Islands, and updates Swaziland to Eswatini.
It should be merged in conjunction with the matching client PR.
https://github.com/OpenBazaar/openbazaar-desktop/pull/1562

Coverage remained the same at 34.875% when pulling b183b30a1832930e0043b2298679684bacbb5f82 on UpdateCountryCodes into 24474a6b8428c0c549dedaac4e49aa70986ae1a7 on master.


⚠ Bofrost.be has degraded performance

In 1762408, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 1508 ms

Resolved: Bofrost.be performance has improved in 1156476.


Add CI Pod deployment

Improvements:

CI Pod deployment of following containers:

Elasticsearch
Kiabana
Grafana
JupyterLab
Nginx
Flask

@RobertKrawitz, thx for your reviewing.
I have updated all your comments


images: Always install "selinux-policy-targeted"

rpm-plugin-selinux which is pulled by default in images can fail
if no SELINUX policy is installed or found. This causes users to
run into issues with dnf, which surpresses the error messages and
instead complains about "failing to obtain the transaction lock",
which is unrelated to the issue.
With the default SELINUX policy set to "targeted" without having
the targeted context files causes the system to be in an
inconsistent state.
A fix for RPM to propagate the error message has been pushed in
https://github.com/rpm-software-management/rpm/commit/8cbe8baf9c
There has been proposed a selinux-policy fix to check for config
file's consistency and install the proper policy if not.
https://src.fedoraproject.org/rpms/selinux-policy/pull-request/15
This should be available in the F31 image, therefore I am leaving
it out from the f31/extra-packages list.

aha, I see. Thanks!


Fixing typo

Correcting a quick typo

Ah drats, I think its a default one in VSCode or some extension I've installed. I'm not likely to be able to fix this up until this evening if anyone could pick this up

Ah drats, I think its a default one in VSCode or some extension I've installed. I'm not likely to be able to fix this up until this evening if anyone could pick this up

Yep, no probs Liam, I'll get on this now :-)


Fix aave cli reference

npm doesn't have aave-cli. I've updated the refrence so this tool works.

superseded by #133


Only gather test coverage data in Jenkins CI build

There's not much point in running this by default in development, especially as it slows the build down. This commit means you have to define the TEST_COVERAGE environment variable if you want to gather coverage data in your development environment. However, the data will be gathered by default in the Jenkins CI build.
c.f. alphagov/smart-answers@0c23a273195c3e2ec73880697c61cf9c75027ff3

@chrisroos: Thanks.
Rebasing against master and force-pushing in preparation for merging.


⚠ SceneTime has degraded performance

In 9a1a922, SceneTime ($ST) experienced degraded performance:

HTTP code: 200
Response time: 1831 ms

Resolved: SceneTime performance has improved in caf6a0b after 8 minutes.


Add end_training/destroy_pg to everything and unpin numpy

What does this PR do?
Some more spring cleaning. Adds end_training/state.destroy_process_group() everywhere we need to in our examples, and unpins numpy as things look to be fine from what I can tell
Fixes #3027
Before submitting

[ ] This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
[x] Did you read the contributor guideline,
Pull Request section?
[ ] Was this discussed/approved via a Github issue or the forum? Please add a link
to it if that's the case.
[ ] Did you make sure to update the documentation with your changes? Here are the
documentation guidelines, and
here are tips on formatting docstrings.
[ ] Did you write any new necessary tests?

Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.
@SunMarc

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@muellerzr Do you know if numpy 2.0 now also works with PyTorch < v2.4?

In my very quick test, it looks like yes it's fine (ran the accelerate tests from 2.3 and 2.2

Nice, good to know. It sounded like older releases would not work

Older releases not supporting NumPy 2.0 is expected and will not be fixed as per the usual policy we have on old releases patching.

https://github.com/pytorch/pytorch/issues/ 128860

Since we don't have a "base" requirement for 2.0, we don't force people to upgrade.