Handle rotated, skewed or flipped GeoTIFF tile grids

Fixes #15294
Fixes #15370
Fixes #15428
Uses rotated/skewed/flipped variants of projections to handle GeoTIFF tile grids with rotation, skew or flip specified by ModelTransformation.
See https://deploy-preview-15402--ol-site.netlify.app/en/latest/examples/cog-modeltransformation.html
Uses a local alternative to https://github.com/geotiffjs/geotiff.js/pull/403 which could be removed if the replacement https://github.com/geotiffjs/geotiff.js/pull/413 (with corrected Y axis scale) is merged.  The code could be further simplified if https://github.com/geotiffjs/geotiff.js/pull/414 is merged.

Ready for review as I do not have any files small enough to use for a rendering test.  The Projection setMatrix method should work equally well for a rotated ImageStatic, etc. but I have not documented that as part of the API.

@mike-000 Thanks for this! I'm happy to provide more test files, though the smallest I have is ~80MB.

@loganwilliams There is a large selection of open data available via https://radiantearth.github.io/stac-browser/#/external/s3.us-west-2.amazonaws.com/umbra-open-data-catalog/stac/catalog.json typically around that size suitable for use in examples but too big to use as local test data.  I have now found a reduced version of the file used in the example at https://github.com/GeoTIFF/test-data which is under 4MB so might be suitable for another rendering test.

This is really great, thanks for your work on it @mike-000. Hope it gets merged soon.

@ahocevar  This is ready for further review.  Workarounds have been removed in favour of the latest geotiff.js methods.  The handling of matrixes in projections now uses entire transform functions (in series if necessary) instead of very inefficiently extracting a single coordinate transform from a projection transform function to use in a new transform function.  This has made the rendering noticeably faster.  In many cases (as in the two examples and current tests) the matrix transform is independent of projection transforms and could potentially be cached and/or used directly, e.g.
  if ((!sourceTransform || !destinationTransform) && !transformFunc) {
    return sourceTransform || destinationTransform;
  }

although I suspect there would be little further performance gain from this.
Matrix and projection transforms used in series will be needed for generic viewers such as attempted in https://radiantearth.github.io/stac-browser/#/external/s3.us-west-2.amazonaws.com/umbra-open-data-catalog/stac/2023/2023-02/2023-02-12/6d584f33-0489-47dd-9412-14d2c83532fc/6d584f33-0489-47dd-9412-14d2c83532fc.json where the rotated UTM is further transformed to 3857 as in  https://jsfiddle.net/w4qxs50k/ - a test is still needed for that (potentially using an ImageStatic as in https://github.com/openlayers/openlayers/issues/7255#issuecomment-1912131950).

Separating matrix and projection transforms has the potential for double reprojection.  I would regard the image as being in a rotated version of a standard projection - in the example case a UTM projection - defined by a standard projection code and a rotation matrix, so to render it in for example EPSG:3857 only one reprojection should be needed (no reprojection of reproj tiles) the transform function being a combination of the UTM to 3857 transform and the matrix transform which can be easily done by getTransformFromProjections using only its current two parameters (and if source and destination codes are the same only the matrix is used).  Having the overall projection defined by a code in the projection and a matrix in the source would be difficult for the current renderer to manage.
Similarly the technique could be used for KML ground overlays, by regarding them as being in rotated/scaled version of EPSG:4326, they could be easily rendered in any view projection which has a transform to EPSG:4326.
But I do think setting a matrix on a projection object should not be exposed in the API, it should be done only inside the GeoTIFF source code (and potentially inside a ground overlay parser) to avoid any future breaking changes.

I agree that a single transform of raster data is preferable. But still, this can be done in ol/DataTile, if the ReporjDataTile is configured with a transform and a projection.

A solution which is not specific to DataTile would be preferable, so it could be easily reused elsewhere, e.g. as part of a fix for #4949/#7255 where rotation transforms can be combined projection transforms without the need to maintain large numbers of individual transforms for multiple projection code/rotation permutations.
Also reprojection inevitably reduces the output quality, sometimes as in #15579 that can be unacceptable, so it would nice to allow the view to be in the tiles native projection and reproject any less important background or vector data.  Currently getView() returns a standard projection familiar to the user, and the fact that the source may have a non-standard projection with the same code is not documented, but for best quality that can be used as the view projection as in https://jsfiddle.net/jo9wav6y/ something I think should be retained and documented.

@mike-000 To make it easier for me to review, please answer one question: in Projection, is it now either matrix or transform function, or both? If both, then how does that work exactly?

@mike-000 Thanks for the explanation. I wish it was the other way, i.e. either numeric transform or matrix transform. Now that it's not like that, what exactly does

getTransformFromProjections considers the proj4 transform between the codes together with each of the transform matrixes (if present) to return a complete transform between any pair of projections.

mean?
I stell feel that in this case, registering transforms with transform functions (without ol/proj/proj4) that do whatever you do now to achieve the rotation, skew or flip or whatever.

what exactly does

getTransformFromProjections considers the proj4 transform between the codes together with each of the transform matrixes (if present) to return a complete transform between any pair of projections.

mean?

The process necessary to display a rotated or flipped UTM projection tile grid as in the example or in #15923 in a generic viewer such as  http://app.geotiff.io/ which uses a global projection (or in some cases the opposite as in https://jsfiddle.net/jo9wav6y/ to reproject a background such as OSM to the camera projection).  When the source is loaded we know its projection code and ModelTransformation, but we do not know the view projection and may need look up the source projection proj4 definition to obtain that part of the transform.  The adjustments for ModelTransformation do not need a lookup and can easily be added on demand.

Well, like you're saying - the whole transform needed here is a "process", not a matter of projection. If you manage to change your pull request to do the transform with a chain of transform functions (i.e. a process) instead of trying to squeeze this into Projection, I'll review again.

So how do you propose to do that?  Since all methods which take a source projection and destination projection eventually call getTransformFromProjections that seems the obvious place to do it.  If the matrix is not included in the projection then each method which takes source and destination projection would also need source and destination matrix options.

I can answer that once I fully understand what you're aiming for, which is not the case. So one more question: why are you saying the transform matrix is applied after reprojecting? I would think that if a GeoTIFF is rotated, skewed or flipped, that applying a transform matrix would be the first thing to do. Then we're done, unless the result is still in a different projection than the View. If so, a source -> view projection transform will be applied.

Yes, that is the problem situation.  Consider an OpenLayers version of https://app.geotiff.io/ where the code might include
register(proj4);
const map = new Map({
  target: 'map',
  layers: [
    new TileLayer({
      source: new OSM(),
    }),
  ],
  view: new View({
    center: [0, 0],
    zoom: 0,
  }),
});

// call this when URL is entered in form

function addGeoTIFF(url) {
  const cogSource = new GeoTIFF({
    sources: [{url: url}],
  });

  cogSource
    .getView()
    .then((viewConfig) =>
      fromEPSGCode(viewConfig.projection.getCode()).then(() => {
        map.getView().fit(
          transformExtent(
            viewConfig.extent,
            viewConfig.projection,
            map.getView().getProjection(),
          ),
        );
        map.addlayer(
          new TileLayer({
            source: cogSource,
          }),
        );
      })
    );
}

To avoid reprojecting a reprojection, which would affect output quality, the tiles should be reprojected directly from the rotated UTM projection to the view projection - the overall transform for doing that is obtained by combining the matrix and proj4 transforms (only the proj4 transform is cached, transform functions for a matrix are easy to create as required).
That is more complex than in the example where only the matrix transform is used to reproject the tiles (to an unrotated reprojection tile grid) and the proj4 transform is only needed to reproject the background OSM to UTM.

Ok, so the matrix transform comes first, then the projection transform. So once you have a transform function that combines both, you don't have to create a transformed canvas from a transformed canvas. Try to think less in what we currently have (i.e. Projection), think more in what would make most sense.
For example, a renderer could get data from a source, obtain a transform matrix from the source, get the projection from the view, and then do what we currently call "reprojection" using a function that combines the matrix transform and the reprojection transform functions.

I would consider the projection with matrix to be a projection in its own right as a tile grid must be aligned with the source projection axes, so it does make sense to me.  And as noted above

If the matrix is not included in the projection then each method which takes source and destination projection would also need source and destination matrix options.

so any other method is likely to be more complex to implement (especially for something which will be relatively uncommon) and if done at renderer level would not be reusable for other layer types (e.g. a KML GroundOverlay could be easily implemented as an ImageStatic in a scaled and rotated EPSG:4326 based projection and reprojected into any view projection with minimal additional effect).
Also it would be desirable to be able use the rotated source projection directly at times as in https://jsfiddle.net/jo9wav6y/ as any reprojection will affect output quality and in a rotated version of a COG such as in #15579 changing the pixel alignment would make the output even more meaningless than the unwanted resizing of pixels.

Again, I'm not talking about multiple transforms on a canvas. Just chaining of transform functions. And my suggestion is to separate affine transforms (source matrix transform) from projections (source to view projection). An API for the user could look like this:
new Source({
  projection: sourceProjection,
  transform: transformMatrix, // transform data into source projection
});

For GeoTIFF, both can of course be determined from the GeoTIFF metadata.

Why make it unnecessarily complicated for the rendererers?  getTransformFromProjections is already chaining transforms, and it does that using the two existing parameters which can now contain both the code for the projection and the transform matrix.

We should aim for making it easy for the users. I don't see where this would make it more complicated in the renderer code.
The problem with your approach is that projections work based on a projection code lookup. And with an arbitrary matrix in addition to a projection that can uniquely be identified by a code, we get into a situation where we need to set up a code (or a projection object) for each transform+projection combination.

Yes, we need new projection objects for custom projections - before each call to setMatrix() the projection on which is based needs to be cloned (ol/source/GeoTIFF does that).  I do not see any problem with that as long as setMatrix() is not exposed in the API, but maybe a non-API createProjectionWithMatrix method would be safer?

I think I have made valid suggestions and also shown a way how these could be implemented. Please let's bury your selected approach of trying to squeeze all that into Projection objects.

Your proposal works well when the source is reprojected to another projection, e.g. UTM source with a rotation matrix reprojected to 3857.   The matrix needs to be passed to ReprojDataTile and on to Triangulation to be included in the transformInv.  Ideally it should also be passed to calculateSourceExtentResolution and getPointResolution in case the matrix has significant scaling.  But when attempting to use reprojection with the same projection (source with matrix and view without matrix) it starts getting messy.  A reprojection must be forced in getTile() if the source has a matrix, but if the same getTile() is called from ReprojDataTile it must return a source tile and not recursively create reproj tiles.  I managed that but still cannot get any output.  I suspect the need for separate caches, tile grid and gutters for source and reproj tiles, indexed by projection object uid, may be the problem.

Maybe some things can be simplified along the way:

Reprojected tiles in view projection can use a standard tile grid
Reprojected tiles in view projection do not need gutters
Tiles in view projection are cached by the renderer since #15905, so no need to keep a lookup of caches by projection in the source any more.

It sounds like that would resolve most or your issues.

Yes, I have it mostly working now, by taking the source transform matrix into account in getTileGridForProjection, getTileCacheForProjection and getGutterForProjection.  One of the test samples is not rendering the full extent, which I don't understand as the overall transform should be the same regardless of where the components are obtained from:

Yes, I have it mostly working now, by taking the source transform matrix into account in getTileGridForProjection, getTileCacheForProjection and getGutterForProjection.

Interesting. Would you mind sharing your code? I'm unable to come up with a reason why the transform would matter for the view projection.

Replaced by #15962/#15988


Enhancement Request: Tray icon double click

Brief summary of your request
Double Click
Request details
Is it posible to add a double click future to the tray icon so it opens the window? I now have to click with right mouse: and select SHOW WINDOW.
Anything else?
not yet !

@CMTriX
No problem.  It will be in the next release.
Would you have time to update Strings.nl-NL.xaml in the Languages Folder?
Thanks,
Tim

Yes thnx. Going to translate tomorow.

Translation updated.

I've released the version with your enhancement request and your translation updates. Thanks a lot.
Tim


Datepicker

The date picker should now be working in the public exposures tab.

In the day-of-the-week heading, Sunday is missing, and also at the end of the week


Use posixpath in MongoDB YCSB benchmark

The benchmark incorrectly uses os.path when it should use posixpath. Fix
this bug.
In addition to the unit tests, I have verified that I can actually run a MongoDB benchmark with this patch.

@ehankland @hildrum PTAL

LGTM.


[BUG] Search for someone didn't work

Description
I'm actually on the live demo website and whenever  click on the start button it displays a page with searching... without displaying anything else
Screenshots

The app latest version isn't hosted yet because of this bug #71 I updated the about so people will know this app isn't functioning yet

so how can i help you to fix this bug ? In the version of the project i have i can't even send messages

so how can i help you to fix this bug ? In the version of the project i have i can't even send messages

As I said it's not hosted, so you have to clone it and all


Black menu bar

The typetools and video tools apps both show a full menu of TN options.
I think it’s best right away to limit those options to the “type Network” at the far left, which provides access to the Tn home page.
Can this be done easily and quickly?

I've removed them from both. Our host Webfaction seems to have changed something about their DNS setup, so I am seeing a lot of security warnings and other errors. Will clear that up today.

Thank you.
On Jul 8, 2019, at 1:07 PM, Chris Lewis<EMAIL_ADDRESS>wrote:
I've removed them from both. Our host Webfaction seems to have changed something about their DNS setup, so I am seeing a lot of security warnings and other errors. Will clear that up today.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.


Support GameNetworkingSockets 1.3.0

Tried updating the library today and it seems like the connection between client and server just times out when connecting to a locally started  server.
I think this has to do with the changes to locking and threading made in that release, but I am not familiar enough with the soldat codebase to know how to best fix this (error messages say something about likely thread starvation, so seems to check out).

Thanks for checking out the new version so quickly. The release notes say that the open source headers are now compatible with the Steamworks SDK headers, but there are still some preprocessor directives in GameNetworkingSockets.pas which are specific to the open source version. I guess they're not required anymore, as when I took them out everything seemed to work. I'll investigate a little more thoroughly then make a PR.

I should give an update on this. It wasn't that bad to get v1.3.0 working with 64 bit Linux and Windows, but when I tried it on 32 bit builds it failed. Then I tried v1.2.0 on 32 bit builds and it also failed, so there is some problem with GNS on 32 bit builds. Also, the v1.3.0 release notes say it is compatible with Steamworks 1.51 but the Steam bindings in Soldat are for Steamworks 1.50. We should update both at the same time, but I haven't touched the steam code yet so I'm waiting until I get around to that to update this.


Cannot save certificate

Hi, there.
I tried to have nginx automatically renew the certificate using jrcs / letsencrypt-nginx-proxy-companion , but failed.
docker-compose.yml is described as follows.
docker-compose.yml
version: "2"
services:
  nginx-proxy:
    image: jwilder/nginx-proxy:latest
    container_name: nginx-proxy
    privileged: true
    ports:
      - 80:80
      - 443:443
    volumes:
      - ./certs:/etc/nginx/certs:ro
      - ./log:/var/log/nginx
      - ./my_proxy.conf:/etc/nginx/conf.d/my_proxy.conf
      - /var/run/docker.sock:/tmp/docker.sock:ro
      - /etc/nginx/vhost.d
      - /usr/share/nginx/html
    restart: always
    networks:
      - ssl_proxy

  nginx-letsencrypt:
    image: jrcs/letsencrypt-nginx-proxy-companion
    container_name: letsencrypt-nginx
    privileged: true
    volumes:
      - ./certs:/etc/nginx/certs:rw
      - /var/run/docker.sock:/var/run/docker.sock:ro
    volumes_from:
      - nginx-proxy
    restart: always
    networks:
      - ssl_proxy

networks:
  ssl_proxy:
    external: true

When started with docker-comonent up, the following error appeared.
Traceback (most recent call last):
  File "/usr/lib/python3.8/site-packages/simp_le.py", line 1601, in main
    return main_with_exceptions(cli_args)
  File "/usr/lib/python3.8/site-packages/simp_le.py", line 1585, in main_with_exceptions
    persist_new_data(args, existing_data)
  File "/usr/lib/python3.8/site-packages/simp_le.py", line 1443, in persist_new_data
    client = registered_client(
  File "/usr/lib/python3.8/site-packages/simp_le.py", line 1377, in registered_client
    directory = messages.Directory.from_json(net.get(args.server).json())
  File "/usr/lib/python3.8/site-packages/acme/client.py", line 1141, in get
    self._send_request('GET', url, **kwargs), content_type=content_type)
  File "/usr/lib/python3.8/site-packages/acme/client.py", line 1091, in _send_request
    response = self.session.request(method, url, *args, **kwargs)
  File "/usr/lib/python3.8/site-packages/requests/sessions.py", line 530, in request
    resp = self.send(prep, **send_kwargs)
  File "/usr/lib/python3.8/site-packages/requests/sessions.py", line 643, in send
    r = adapter.send(request, **kwargs)
  File "/usr/lib/python3.8/site-packages/requests/adapters.py", line 516, in send
    raise ConnectionError(e, request=request)
requests.exceptions.ConnectionError: HTTPSConnectionPool(host='acme-v02.api.letsencrypt.org', port=443): Max retries exceeded with url: /directory (Caused by NewConnectionError('<urllib3.connection.VerifiedHTTPSConnection object at 0x7fd49d601070>: Failed to establish a new connection: [Errno -3] Try again'))

Unhandled error has happened, traceback is above

Debugging tips: -v improves output verbosity. Help is available under --help.

The latest version of letsencrypt-nginx-proxy-companion image is used.
Can anyone help me to renew my certificate automatically?

Hi.
It looks like your container can't reach https://acme-v02.api.letsencrypt.org
Let's say your Let's Encrypt companion container is running and its name is le-companion. The following command will execute curl from "within" the container:
docker exec le-companion curl -v https://acme-v02.api.letsencrypt.org/directory
Could you try and report the result ?

Thank you for reply.
The result of running curl inside the container.
$ sudo docker exec letsencrypt-nginx curl -v https://acme-v02.api.letsencrypt.org/directory
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
  0     0    0     0    0     0      0      0 --:--:--  0:00:02 --:--:--     0*   Trying <IP_ADDRESS>:443...
* TCP_NODELAY set
* Connected to acme-v02.api.letsencrypt.org (<IP_ADDRESS>) port 443 (#0)
* ALPN, offering h2
* ALPN, offering http/1.1
* successfully set certificate verify locations:
*   CAfile: /etc/ssl/certs/ca-certificates.crt
  CApath: none
} [5 bytes data]
* TLSv1.3 (OUT), TLS handshake, Client hello (1):
} [512 bytes data]
* TLSv1.3 (IN), TLS handshake, Server hello (2):
{ [102 bytes data]
  0     0    0     0    0     0      0      0 --:--:--  0:00:03 --:--:--     0* TLSv1.2 (IN), TLS handshake, Certificate (11):
{ [2938 bytes data]
* TLSv1.2 (IN), TLS handshake, Server key exchange (12):
{ [333 bytes data]
* TLSv1.2 (IN), TLS handshake, Server finished (14):
{ [4 bytes data]
* TLSv1.2 (OUT), TLS handshake, Client key exchange (16):
} [70 bytes data]
* TLSv1.2 (OUT), TLS change cipher, Change cipher spec (1):
} [1 bytes data]
* TLSv1.2 (OUT), TLS handshake, Finished (20):
} [16 bytes data]
* TLSv1.2 (IN), TLS handshake, Finished (20):
{ [16 bytes data]
* SSL connection using TLSv1.2 / ECDHE-RSA-AES256-GCM-SHA384
* ALPN, server accepted to use h2
* Server certificate:
*  subject: CN=acme-v01.api.letsencrypt.org
*  start date: Apr  7 02:20:06 2020 GMT
*  expire date: Jul  6 02:20:06 2020 GMT
*  subjectAltName: host "acme-v02.api.letsencrypt.org" matched cert's "acme-v02.api.letsencrypt.org"
*  issuer: C=US; O=Let's Encrypt; CN=Let's Encrypt Authority X3
*  SSL certificate verify ok.
* Using HTTP2, server supports multi-use
* Connection state changed (HTTP/2 confirmed)
* Copying HTTP/2 data in stream buffer to connection buffer after upgrade: len=0
} [5 bytes data]
* Using Stream ID: 1 (easy handle 0x55f00aaa01c0)
} [5 bytes data]
> GET /directory HTTP/2
> Host: acme-v02.api.letsencrypt.org
> user-agent: curl/7.67.0
> accept: */*
>
{ [5 bytes data]
* Connection state changed (MAX_CONCURRENT_STREAMS == 128)!
} [5 bytes data]
< HTTP/2 200
< server: nginx
< date: Tue, 07 Apr 2020 03:36:53 GMT
< content-type: application/json
< content-length: 658
< cache-control: public, max-age=0, no-cache
< x-frame-options: DENY
< strict-transport-security: max-age=604800
<
{ [658 bytes data]
100   658  100   658    0     0    196      0  0:00:03  0:00:03 --:--:--   196
* Connection #0 to host acme-v02.api.letsencrypt.org left intact
{
  "iXBY6tjWjR4": "https://community.letsencrypt.org/t/adding-random-entries-to-the-directory/33417",
  "keyChange": "https://acme-v02.api.letsencrypt.org/acme/key-change",
  "meta": {
    "caaIdentities": [
      "letsencrypt.org"
    ],
    "termsOfService": "https://letsencrypt.org/documents/LE-SA-v1.2-November-15-2017.pdf",
    "website": "https://letsencrypt.org"
  },
  "newAccount": "https://acme-v02.api.letsencrypt.org/acme/new-acct",
  "newNonce": "https://acme-v02.api.letsencrypt.org/acme/new-nonce",
  "newOrder": "https://acme-v02.api.letsencrypt.org/acme/new-order",
  "revokeCert": "https://acme-v02.api.letsencrypt.org/acme/revoke-cert"

@yuri-hattori are you still experiencing this issue ?

Inactive issue, closing.


pkg/datapath/linux/route: remove darwin stubs

Follow-up from #10824.
We should remove darwin stubs from this package and move them to e.g. pkg/datapath/unimplemnted/route, then have a wrapper package that selects the implementation, so that consuming packages just use the wrapper.

Adding good-first-issue label, since with GOOS=darwin it should be easy enough to iterate on an implementation along the lines of the proposal here. It may take a bit of refactoring under the pkg/datapath area, so could be useful for a go programmer to upskill on this area of the Cilium codebase.

Is anyone still working on this issue? Can I be assigned? Thanks

Hi @clemenkok , thanks for the offer! I'm not sure about the scope of the task at this point in time but I would encourage submitting some PRs and in the PR description you can reference this issue so others can find the submissions.


Rustup for rust-lang/rust#79951

cc https://github.com/rust-lang/rust/issues/81467

You need to update the rust-version file.

You need to update the rust-version file.

Ah, thanks for pointing out!

Ah, thanks for pointing out!

And the code looks better than before -- thanks. :-)
@bors r+

And the code looks better than before -- thanks. :-)
@bors r+

:pushpin: Commit 53612ece7c167395719b03a3e60d8105fa1babd1 has been approved by RalfJung

:pushpin: Commit 53612ece7c167395719b03a3e60d8105fa1babd1 has been approved by RalfJung

:hourglass: Testing commit 53612ece7c167395719b03a3e60d8105fa1babd1 with merge 099e0a166154bb34544b5b073e79e45b459ba624...

:hourglass: Testing commit 53612ece7c167395719b03a3e60d8105fa1babd1 with merge 099e0a166154bb34544b5b073e79e45b459ba624...

:sunny: Test successful - checks-actions
Approved by: RalfJung
Pushing 099e0a166154bb34544b5b073e79e45b459ba624 to master...

:sunny: Test successful - checks-actions
Approved by: RalfJung
Pushing 099e0a166154bb34544b5b073e79e45b459ba624 to master...


help options in the wizard

I met someone today who suggested these things, which I think are great ideas:

information hover overs next to tools (such as quantification, composite operations, etc.) to help users know which is the best fit for them
a little help box to lead the user to resources when they open a tray, such as leading them to the new lesson on CartoCSS when they open the css tray, or same with sql

He said don't go the clippy direction:

Working on this on the new editor!


chore: add contributors section to readme

closes #31
Need help
@akexorcist Can you follow steps 1 and 2 from this page to set up all-contributors.
This PR is step 3 of the page. I added a badge to the top of the README as well.

@all-contributors please add @siriwatknp for contribution

@all-contributors please add @siriwatknp for doc

All done krub 🙏


Image shrinking

Implementation of the same using opencv.

Implementation of the same using opencv.

I want to work on this issue under GSSoC'21. Kindly assign this issue to me. @geekquad


Repo sync for protected CLA branch

The pull request is created from master637644710907008903 to master to fix git push error for protected CLA branch

@ghogen : Thanks for your contribution! The author(s) have been notified to review your proposed change.


Unable to create wallet (save encrypted file on disk)

Describe the bug
When using the Linux build on Ubuntu I get the error "Unable to write encrypted keys to filesystem.". Doesn't matter if I'm running as a user or as sudo. I also tried storing it in other directories. The key alias cannot be reused though.
To Reproduce
Steps to reproduce the behavior:

Open app in Ubuntu
Click "Don't have a wallet yet? Create on here!"
Browse to the directory and name the file, add a unique key alias and keystore password. Name the wallet "Main".
Click "Create"

Expected behavior
I expected the key store to be saved on disk and that the wallet would open and give me the address and funds.
Desktop (please complete the following information):

OS: Ubuntu 20.10
Browser Not relevant
Version 1.2.0

Update to the latest version. v2.0 and greater do not use key alias.


Add some repo tests

Coverage increased (+0.3%) to 97.489% when pulling 288d69511056e21faef84ff620c574e64ec3e168 on msabramo:add_some_repo_tests into e0b36381f0f84610103026cc8c89d818c27e21f2 on sepulworld:master.

Coverage increased (+0.3%) to 97.493% when pulling 2a4d5d7de082ed3f644035132940fd98e371604a on msabramo:add_some_repo_tests into e0b36381f0f84610103026cc8c89d818c27e21f2 on sepulworld:master.

Coverage increased (+0.3%) to 97.493% when pulling f6d24714ab4fbd5b01eb24f686ab21074617f576 on msabramo:add_some_repo_tests into e0b36381f0f84610103026cc8c89d818c27e21f2 on sepulworld:master.


fix error strings be capitalized

What this PR does / why we need it:
According to Golang coding convention, error strings should not be capitalized.

Can one of the admins verify this patch?

Please sign your commits following these rules:
https://github.com/moby/moby/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:
$ git clone -b "fix-error-string" git@github.com:vanduc95/notary.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.

The test failures are because the tests check the error messages and so need fixes for the capitalisation too.


Ch10 cannot create repositories

Information
The problem arises in chapter:

[ ] Introduction
[ ] Text Classification
[ ] Transformer Anatomy
[ ] Multilingual Named Entity Recognition
[ ] Text Generation
[ ] Summarization
[ ] Question Answering
[ ] Making Transformers Efficient in Production
[ ] Dealing with Few to No Labels
[ X] Training Transformers from Scratch
[ ] Future Directions

Describe the bug
 In the section **Adding Datasets to the HuggingFace Hub**, after I logged in the HuggingFace account, I could not create repositories using this line of code:
huggingface-cli repo create --type dataset --organization transformersbook codeparrot-train
Instead, I got this error:
403 Client Error: Forbidden for url: https://huggingface.co/api/repos/create (Request ID: hsKOgZ5w0izNyONWMl-wl) - You don't have the rights to create a dataset under this namespace {"error":"You don't have the rights to create a dataset under this namespace"}
Wondering if anyone else has encountered this issue.

just omit the --organization flag.    (since you don't own that namespace)


Tapping modal backdrops on mobile can trigger close multiple times

Current Behavior
When on mobile, multiple queued modals close at one (the current and the next one) if just tapping on the backdrop.
Reproduction / Steps To Reproduce
Use the queued modals Button from the docs on a touchscreen-enabled device
Anything else?
video

the user's finger can remain on the backdrop for long enough that it triggers the close event twice.

Seems weird to me - it only occurs when you don't hold your finger and just tap.

I just looked into this and this is actually happening because we are reacting to mousedown and touchstart so tapping on Android, for example, would trigger both.
to solve this we only need event.preventDefault(); in the onBackdropInteraction.
I would be happy to fix it if this was the best solution.


Some fortunes cause speech bubble problems

% fortune -m "McCoy, "The Menagerie" 2>/dev/null | sed -e '/%/d'
Blast medicine anyway!  We've learned to tie into every organ in the
human body but one.  The brain!
-- McCoy, "The Menagerie", stardate 3012.4
Piping this into tewisay causes a bad speech bubble.
This happens for a bunch of other fortunes:
The relative importance of files depends on their cost in terms of the
human effort needed to regenerate them.
-- T.A. Dolotta
I think this is caused by tab width being different than expected.

That's definitely the issue; piping the fortune through perl -e'while(<>){$_ =~ s/\t/   /g; print;}' fixes it.


Transformations on file paths not caching

Because of the isinstance(stim, Stim) check in the memoization code, transformations on file paths (strings) are not caching. This is because memoization wraps .transform but the file path is converted into a Stim within .transform. The fix may be as easy as adding something like or isinstance(stim, string_types).

Makes sense. isinstance takes a tuple as the second arg, so isinstance(stim, (Stim, string_types)) should take care of it.


Team Leaders don't work (without RBAC?)

Bug description

As a Team Leader visiting the Users, Teams and Roles screens produces a red "Failure, Unauthorised" toast.
The roles screen does not list the roles that are visible to the Administrator.
The users screen does not show any users, not even the users in my own team.
the Add User feature is disabled as there are no teams, not even my own team that I am a leader of, to select.
Selecting my own team in the Teams screen shows 0 leaders, 0 total team members, even when there are other members and leaders.

Expected behavior
With or without RBAC I expect Team Leaders to be able to access the "Users" screens without access errors.
And as only Roles is restricted to the RBAC extension, I would expect that Team Leaders should be able to access all the functionality available on Users and Teams without restriction including viewing and adding team members.
Conversely, the only power currently available to Team Leaders - to delete the Team - I believe should be restricted to Administrators.
Steps to reproduce the issue:

As an Administrator go to Settings>Users and add a new user.
As an Administrator go to Settings>Users>Teams and add a new Team, selecting the new user as a Team Leader.
Log out, and log in as the User.
Visit the Users, Teams and Roles screens and attempt to use their functions.

Technical details:

Portainer version: 1.22.2
Docker version (managed by Portainer): 19.3
Platform (windows/linux): RHEL

Hi there @chrisbecke , thank you for taking the time to report this to us. It seems there is an issue with UAC and Team leader. Testing of team leader is not currently part of our release testing plan, so I have let my team know to add this.
FYI there is an existing issue with team leaders & external authentication which you can see here: #3139. There was also a discussion on whether the feature should be depreciated or not, #2922 this has since been closed as the overall opinion of the community was to keep it.
Feel free to leave a comment on either if you wish :)

Reproduced on 1.23.2.

Closed as this has now been addressed by https://github.com/portainer/portainer/issues/7093


[loc][Query][DevDiv] Translatability of Code

Hi, we have a question from our translator. Can you help please?
Source:
Please restart Code before reinstalling {0}.
File Name:
src\vs\platform\extensionManagement\node\extensionManagementService.nls.resx
Resource ID:
".resx", 0; "restartCode"
Query:
Is Code translatable?	Cristina Carrasco	6/9/2016 9:18:45 AM

No, it's not. Should we extract it?

Hi, thanks for your reply. I think it's fine for the moment. I let the translators know.


JS: Reserved keyword as function name leads to syntax errors

Description
When formatting JavaScript code with functions named like keywords, a space is inserted between the name and the opening (. This leads to broken code.
Using keywords as function names is not ideal, but apparently the case for Polymer, see https://github.com/brackets-beautify/brackets-beautify/issues/262 (and https://github.com/Hirse/brackets-beautify/issues/26).
Input
The code looked like this before beautification:
import('file.js');

Expected Output
The code should have looked like this after beautification:
import('file.js');

Actual Output
The  code actually looked like this after beautification:
import ('file.js');

See #1393
Already in the next version.

Awesome, no wonder I couldn't find it in the list of open issues. :+1:
That is the same user that reported the bug in my repos, but didn't link them. :disappointed:


Match values for >= etc

Currently Match only allows for exact matches like 3 or Gold.
Support for operators like >, <, >= etc would be great as well as the support for variables and formulas.
Added the request for this functionality following a slack mailthread.

@maheshika Can we move this issue https://github.com/ballerina-platform/ballerina-spec as this is a feature request to the language.


Add Gokarna theme

Thanks for the theme submission, @526avijitgupta. Your theme should appear soon on www.themes.gohugo.io.


Update the endpoint initialization view to only support local Docker/Kubernetes and agent options

We'll want to support local Docker/Kubernetes as well as the agent options only in the endpoint initialization view.
Other types of endpoint (ACI, remote Docker) will still be supported via the endpoint creation view.

I want to add a remote Docker endpoint only, but it's not letting me skip the initialzation view. I don't have any local endpoint to manage.
I have installed portainer on kubernetes using official helm chart.

@piyush94 we're aware of that and we'll add a way to start Portainer without having to initialize any endpoint.


Upgrades: Master nodes are being deemed successfully upgraded without actually checking

The play that validates the control plane is running after all master nodes have run. The problem here is that the version file is being updated on a master node without actually checking that the upgrade on the node was successful.
We need to ensure that a given master node was upgraded successfully before updating the version file. This might be achieved by running the control plane validation play on that node, or by any other means available.

Closed via #308


Add an option to skip response formatting in Content/Admin API SDKs

Currently the content/admin api SDKs format the response that is received from the API.
We'd like to add a "format response" boolean option to the SDKs so that consumers have the option to skip formatting and receive the raw data that is returned from the API.
Our initial use-case for this is a tool that can automatically generate request/response documentation for our API.

@kevinansfield  So the the fix should allow something like:
const api = new GhostContentAPI({
url: 'your URL',
key: 'your key,
version: "v2",
formatResponse: true/false
})
so the option formatted option can be passed along with these options and should default to true

@Robogeek95.. i agree with you on this...then we can just check the for config.formatResponse to know how the response will come ..weather formatted or not formatted

@kevinansfield @ErisDS where would be the right place to dig for a possible fix would be somewhere here


App Name

Ideas?

mrn #1

twtr?

Since the main advantage of this app is that it is a shorter version of Twitter, I like twtr. But how does one say that? Maybe we could call it Shortr? Or Updatr?

Chirp.  Since its one word its not a tweet its a chirp.

Tweeter.... the more accurate version of twitter

Holla

TalkAt.... because life is about talking at people. Talking with them is too much work

WORD (playoff of the app called YO, but in this case, it's a WORD)

What about "Word Up"... the ratchets will love it. By the way do we have a target market or nah?

Whapsatt. Like Whatsapp, but you're whapping people with your words.

28

Chatter

ChitChat

WYRDS GONE WYLD

ChitChad

Chadder

SmallTalk

Parley

WORD!!!!!!!!!!!!!!!!!!!!!!
Blurp
Foo
Bizz
Buzz
?queso?

BUFFALO WYLD WYRDS

Que? So?

jaja

@meBro

caption

gorjeo

skype

pío

Name suggestions end at 10AM!  I will be making a poll we can vote on after 10AM.

grunt <this one actually makes sense

whoppr - a la http://wac.450f.edgecastcdn.net/80450F/b1017online.com/files/2013/03/robin-eggs-instagram.jpg

TA1K (like Talk but one word, get it?)

Uno

snack

Oon  --- (which is the phonetic pronunciation of "une" which is "one" in french)

bump

The name that won the voting was @meBro so this issue can be closed.

Still need to remove all mentions of "minitwit"


Create validator class for proven headers and make Consensus Manager use it. + Tests.

Add new logic to the chain tree: proven headers should be validated for up to coinstakeAge headers from the fork point.
If we advance consensus on the same chain we should check if there are any headers withing the coinstakeAge from the consensus tip and if there are- validate them.

We should try to avoid making changes that are specific to PH in the low level consensus code.

Possibly create a PosChainedHeader that will store the PH class.
This can then be sent in to CM (and CHT)

Depends on https://github.com/stratisproject/StratisBitcoinFullNode/issues/1790

A comment I have on this is that we may not need to create new Validator for CM but add new rules that manage the validation of PH

Don't create validator, just update set of rules in the rules engine for the headers validation on PoS networks


Add two more test to show usage of And and Or

Codecov Report

Merging #57 into master will increase coverage by 0.05%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master      #57      +/-   ##
============================================
+ Coverage     78.32%   78.38%   +0.05%
- Complexity      646      647       +1
============================================
  Files            85       85
  Lines          1832     1832
  Branches        158      158
============================================
+ Hits           1435     1436       +1
+ Misses          268      267       -1
  Partials        129      129

Impacted Files
Coverage Δ
Complexity Δ

src/org/smof/collection/AbstractChildQuery.java
100% <0%> (+14.28%)
3% <0%> (+1%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc4fff8...50bf732. Read the comment docs.


03/13 Review Ticket Sanika

College Board MC 3 Corrections
Score: 47/50
2.2 Lesson Notes and Hacks (at bottom)

[x] Completed notes and questions throughout lesson
[x] Added text to an image related to CPT using PIL
[x] Changed image to negative colors using numpy

2.3 Lesson Notes and Hacks (at bottom)

[x] Created my own dataset using census data, related to AP Stats
[x] File is called transport.json
[x] Mean, mode, max, min, and median of dataset ages

2.7+

CB (47/50)
.9, implemented own images, also inverted one of them
.9 on 2.3 hacks, interacting with the code and implemented her own data that involves transport
good job on the collegeboard quiz, one thing for next time is you could link the resources you used to help you and add the 2.2-2.3 hacks into your cpt project!

2.2 (.9):

Clear and well-written notes and observations. Clear answer to all questions.
Experimented with different aspects of PIL and IPython
Hacks are completed

2.3 (.9):

Clear and well-written notes and observations. Clear answer to all questions.
Experimented with different aspects of PIL and IPython
Hacks are completed
MCQ (+.9):

Well written reflection

Score of 47/50

Score: +2.7


Intellisense not working for react-native

VSCode Version: Code 1.16.0 (787b31c0474e6165390b5a5989c9619e3e16f953, 2017-09-06T16:12:42.401Z)
OS Version: Darwin x64 16.7.0
Extensions:

Extension
Author (truncated)
Version

EditorConfig
Edi
0.10.1

vscode-docker
Pet
0.0.16

code-settings-sync
Sha
2.8.3

npm-intellisense
chr
1.3.0

path-intellisense
chr
1.4.2

open-html-in-browser
cod
0.1.21

gitignore
cod
0.5.0

vscode-eslint
dba
1.3.1

githistory
don
0.2.3

python
don
0.7.0

vscode-npm-script
eg2
0.2.1

prettier-vscode
esb
0.23.1

auto-close-tag
for
0.5.0

vscode-nuget-package-manager
jmr
1.1.4

mssql
ms-
1.1.0

vscode-mongodb
ms-
0.0.1

cpptools
ms-
0.12.4

csharp
ms-
1.12.1

mono-debug
ms-
0.15.7

debugger-for-chrome
msj
3.3.0

color-highlight
nau
2.3.0

vscode-icons
rob
7.12.0

vscode-react-native
vsm
0.4.1

Steps to Reproduce:
. Create react native app:

Making sure VSCode is not already open, launch from new app:

No react native intellisense:

However intellisense for react itself works:

Reproduces without extensions: Yes

Hm, I'm unable to reproduce this:

If you run go to definition on Linking, does it open a d.t.s file? If you add /// @ts-check to the very top of the file to enable type checking, do you see any errors reported in the file?

So it turns out I did not have the d.ts definitions for react-native. I didn't think I would have to do this manually since I don't have to for react or many other npm installed libraries but I guess apps created with react-native init command don't include typescript type definition files but instead rely on the Flow type annotations within the npm installed library. After running npm install @types/react-native --save-dev I have the intellisense available to me. I also noticed there is a vscode extension for using Flow, but it seemed like that had more involved setup. I'm wondering if this is just something everyone else is aware of or is this a recent change? Are others choosing to install Flow and the associated vscode plugin to get this to work?

The typings should be downloaded automatically since you are working in JavaScript: https://code.visualstudio.com/Docs/languages/javascript#_automatic-type-acquisition
Did you ever see a message in the VSCode status bar about typings install failing? Have you configured a custom "typescript.tsdk" setting in VSCode?
You can also check the typings installer logs:

Set "typescript.tsserver.log": "verbose" in your user settings
Restart VSCode and open the js file again
Wait 10 seconds or so
Run the TypeScript: Open TS Server Log command in VSCode
This should open a folder with a file called ti-xxx.log

That ti-xxx.log file has info about automatic typings installation. Look for any error messages in this file (they would probably be near the top)

I do not have a custom setting for typescript.tsdk nor am i getting a vscode status bar about the install failing (at least none that I noticed). However checking the log as you instructed I do see an error at the end having to do with the npm package<EMAIL_ADDRESS>
npm install #1 took: 1378 ms
stdout:
stderr: npm ERR! code ETARGET
npm ERR! notarget No matching version found for<EMAIL_ADDRESS>npm ERR! notarget In most cases you or one of your dependencies are requesting
npm ERR! notarget a package version that doesn't exist.

npm ERR!      /Users/donkeytronkilla/.npm/_logs/2017-09-15T04_00_17_439Z-debug.log

install request failed, marking packages as missing to prevent repeated requests: ["react-native","react-test-renderer","big-integer","denodeify","isomorphic-fetch","qs","ua-parser-js"]
Sending response: {"kind":"event::endInstallTypes","eventId":1,"projectName":"/Users/donkeytronkilla/Development/test2/jsconfig.json","packagesToInstall":["@types/react-native@ts2.5","@types/react-test-renderer@ts2.5","@types/big-integer@ts2.5","@types/denodeify@ts2.5","@types/isomorphic-fetch@ts2.5","@types/qs@ts2.5","@types/ua-parser-js@ts2.5"],"installSuccess":false,"typingsInstallerVersion":"2.5.2"}
Response has been sent.

I am getting the same thing you are
`stderr: npm ERR! Darwin 16.7.0
npm ERR! argv "/Users/Mel/.nvm/versions/node/v7.10.1/bin/node" "/Users/Mel/.nvm/versions/node/v7.10.1/bin/npm" "install" "--ignore-scripts" "<EMAIL_ADDRESS>"<EMAIL_ADDRESS>"<EMAIL_ADDRESS>"<EMAIL_ADDRESS>"<EMAIL_ADDRESS>"<EMAIL_ADDRESS>"<EMAIL_ADDRESS>"<EMAIL_ADDRESS>"<EMAIL_ADDRESS>"<EMAIL_ADDRESS>"<EMAIL_ADDRESS>"<EMAIL_ADDRESS>"<EMAIL_ADDRESS>"--save-dev" "--user-agent=typesInstaller/2.5.2"
npm ERR! node v7.10.1
npm ERR! npm  v4.2.0
npm ERR! code ETARGET
npm ERR! notarget No compatible version found<EMAIL_ADDRESS>npm ERR! notarget Valid install targets:
npm ERR! notarget 0.0.15-alpha, 0.0.16-alpha, 0.0.21-alpha, 0.0.22-alpha, 0.0.23-alpha, 0.0.24-alpha, 0.0.25-alpha, 0.0.26-alpha, 0.0.27-alpha, 0.0.28, 0.0.29, 0.0.30, 0.0.31
npm ERR! notarget
npm ERR! notarget This is most likely not a problem with npm itself.
npm ERR! notarget In most cases you or one of your dependencies are requesting
npm ERR! notarget a package version that doesn't exist.
npm ERR! Please include the following file with any support request:
npm ERR!     /Users/Mel/.npm/_logs/2017-09-21T15_46_36_376Z-debug.log
install request failed, marking packages as missing to prevent repeated requests: ["lodash","react","react-native","jest","react-test-renderer","async","big-integer","denodeify","isomorphic-fetch","qs","sprintf","superagent","ua-parser-js"]
Sending response: {"kind":"event::endInstallTypes","eventId":1,"projectName":"/Users/Mel/Documents/Projects/shade51/jsconfig.json","packagesToInstall":["@types/lodash@ts2.5","@types/react@ts2.5","@types/react-native@ts2.5","@types/jest@ts2.5","@types/react-test-renderer@ts2.5","@types/async@ts2.5","@types/big-integer@ts2.5","@types/denodeify@ts2.5","@types/isomorphic-fetch@ts2.5","@types/qs@ts2.5","@types/sprintf@ts2.5","@types/superagent@ts2.5","@types/ua-parser-js@ts2.5"],"installSuccess":false,"typingsInstallerVersion":"2.5.2"}
Response has been sent.
`

This has been bothering me for a while.

@andy-ms Can you please take a look at these typings installer logs errors

@mjbvz Looks like we forgot to tag the new version on NPM. Should be fixed now. Made an issue #19375.

Thanks @andy-ms! Closing this as upstream


Finish setting up test infrastructure

On the chrome side
Launching electron works well, and it's travis-friendly, using the same trick as electron's own tests to communicate to command-line.
Still have to figure out how to test React components, might steal a thing or two from Jest? But gave up on using it out-of-the-box (too slow & doesn't integrate with electron afaict)
On the remote side
This one is pretty trivial, just haven't settled on a test framework yet - I'd like to keep them as close to the chrome tests as possible.

Almost done! Will tackle #5 before attacking remote-side tests

For browser-less tests, ava seems like the best option available


Enable verbosity in the makefile easily

Signed-off-by: Israel Blancas<EMAIL_ADDRESS>Which problem is this PR solving?
Resolves #1546
Short description of the changes
Add the VERBOSE variable to the Makefile to allow enabling a verbose mode.
Usage example:
$ make build
Formatting code...
pkg/deployment/all_in_one.go
make gobuild
make[1]: Entering directory '/home/iblancas/gopath/src/github.com/jaeger-operator'
Building...
make[1]: Leaving directory '/home/iblancas/gopath/src/github.com/jaeger-operator'

$ make build VERBOSE=1
>>>> Formatting code...
GOPATH=/home/iblancas/gopath .ci/format.sh
make gobuild
make[1]: Entering directory '/home/iblancas/gopath/src/github.com/jaeger-operator'
>>>> Building...
GOOS= GOARCH= CGO_ENABLED=0 GO111MODULE=on go build -o ""build/_output/bin"/jaeger-operator" -ldflags "-X "github.com/jaegertracing/jaeger-operator/pkg/version".version="v1.25.0-3-gbde42334" -X "github.com/jaegertracing/jaeger-operator/pkg/version".buildDate=2021-09-02T15:06:00Z -X "github.com/jaegertracing/jaeger-operator/pkg/version".defaultJaeger="1.25.0""
GOOS= GOARCH= CGO_ENABLED=0 GO111MODULE=on go test -c ./test/e2e/...
make[1]: Leaving directory '/home/iblancas/gopath/src/github.com/jaeger-operator'

Merge conflicts solved

This looks good, but is in conflict again , sorry :(
Can you resolve the conflicts please?

@rubenvp8510 don't worry :) I'll fix them!

Fixed!


Remove trailing whitespace

Some projects consider this a must, and will disallow commits to be submitted which contain trailing whitespace (the Linux kernel is an example project where trailing whitespace isn't permitted).  Other projects see whitespace cleanup as simply nit-picking.  Either way, I thought I'd bring it to your attention and fix the issue just in case you'd like it to be fixed.
This PR is submitted in the hope that it is useful.  If you would like anything changed, please just let me know and I'll be happy to update and resubmit as necessary.

Oh, thanks a lot! I have set up my editor to do this from now on.


Try creating new Remix project using grunge stack but the cli freeze after asking me want to run verify build/tests/etc script

Have you experienced this bug with the latest version of the template?
yes
Steps to Reproduce
1./ Open PowerShell
2./ Run npx create-remix@latest
3./ Select options as the image below

Expected Behavior
The cli should proceed to the next step after I type 'N' and hit enter for Do you want to run the build/tests/etc to verify things are setup properly?
Actual Behavior
The cli freezed

hey @Senbonzakura1234 i've not seen this behavior in my testing, did you by chance hit 'Enter' after typing 'N'?

hey @Senbonzakura1234 i've not seen this behavior in my testing, did you by chance hit 'Enter' after typing 'N'?

Yes i did, i'm pretty sure i did because i see the pointer was under the question line

hey @Senbonzakura1234 i've not seen this behavior in my testing, did you by chance hit 'Enter' after typing 'N'?

hey @Senbonzakura1234 i've not seen this behavior in my testing, did you by chance hit 'Enter' after typing 'N'?

Yes i did, i'm pretty sure i did because i see the pointer was under the question line. It should showing some loading text but it didn't and the whole cli paused at that point, it didnt close or throw any errors

And actually even if i type "y" and press enter, the result still the same, it didnt proceed to run those build/test script that the cli mentioned.

huh weird, ok, in my windows instance i can reproduce this now 🤔 but it does make it through if i hit Enter twice - taking a look

huh weird, ok, in my windows instance i can reproduce this now 🤔 but it does make it through if i hit Enter twice - taking a look

Damm, it's true that hit enter twice work, should i close this issue?

huh weird, ok, in my windows instance i can reproduce this now 🤔 but it does make it through if i hit Enter twice - taking a look

oh heck it's still have bug, take a look at this

Despite i type "y", when i hit the enter 2nd time, it seems the cli consume it as a No, and ignore my 1st input.


Process get killed tensorflow.python.ops.signal.window_ops.hann_window

Click to expand!
Issue Type
Bug
Have you reproduced the bug with TF nightly?
Yes
Source
binary
Tensorflow Version
2.10.0
Custom Code
Yes
OS Platform and Distribution
Ubuntu 22.04
Mobile device
No response
Python version
3.9
Bazel version
No response
GCC/Compiler version
No response
CUDA/cuDNN version
No response
GPU model and memory
No response
Current Behaviour?
Very large input argument.

Standalone code to reproduce the issue
import tensorflow as tf
import numpy as np
from tensorflow.python.ops.signal import window_ops
try:
  try:
    with tf.device('/CPU'):
      arg_0 =<PHONE_NUMBER>51
      periodic = False
      dtype = tf.float64
      out = window_ops.hann_window(arg_0,periodic=periodic,dtype=dtype,)
  except Exception as e:
    print("Error:"+str(e))
  try:
    with tf.device('/GPU:0'):
      dtype = tf.float64
      window_ops.hann_window(arg_0,periodic=periodic,dtype=dtype,)
  except Exception as e:
    print("Error:"+str(e))
except Exception as e:
  print("Error:"+str(e))

### Relevant log output

```shell
2023-01-21 12:56:28.727252: I tensorflow/core/platform/cpu_feature_guard.cc:193] This TensorFlow binary is optimized with oneAPI Deep Neural Network Library (oneDNN) to use the following CPU instructions in performance-critical operations:  AVX2 FMA
To enable them in other operations, rebuild TensorFlow with the appropriate compiler flags.
2023-01-21 12:56:28.846144: E tensorflow/stream_executor/cuda/cuda_blas.cc:2981] Unable to register cuBLAS factory: Attempting to register factory for plugin cuBLAS when one has already been registered
2023-01-21 12:56:29.407955: W tensorflow/stream_executor/platform/default/dso_loader.cc:64] Could not load dynamic library 'libnvinfer.so.7'; dlerror: libnvinfer.so.7: cannot open shared object file: No such file or directory; LD_LIBRARY_PATH: :/lib/
2023-01-21 12:56:29.408152: W tensorflow/stream_executor/platform/default/dso_loader.cc:64] Could not load dynamic library 'libnvinfer_plugin.so.7'; dlerror: libnvinfer_plugin.so.7: cannot open shared object file: No such file or directory; LD_LIBRARY_PATH: :/lib/
2023-01-21 12:56:29.408161: W tensorflow/compiler/tf2tensorrt/utils/py_utils.cc:38] TF-TRT Warning: Cannot dlopen some TensorRT libraries. If you would like to use Nvidia GPU with TensorRT, please make sure the missing libraries mentioned above are installed properly.
2023-01-21 12:56:30.003853: I tensorflow/stream_executor/cuda/cuda_gpu_executor.cc:980] successful NUMA node read from SysFS had negative value (-1), but there must be at least one NUMA node, so returning NUMA node zero
2023-01-21 12:56:30.032131: W tensorflow/stream_executor/platform/default/dso_loader.cc:64] Could not load dynamic library 'libcudnn.so.8'; dlerror: libcudnn.so.8: cannot open shared object file: No such file or directory; LD_LIBRARY_PATH: :/lib/
2023-01-21 12:56:30.032148: W tensorflow/core/common_runtime/gpu/gpu_device.cc:1934] Cannot dlopen some GPU libraries. Please make sure the missing libraries mentioned above are installed properly if you would like to use GPU. Follow the guide at https://www.tensorflow.org/install/gpu for how to download and setup the required libraries for your platform.
Skipping registering GPU devices...
2023-01-21 12:56:30.032397: I tensorflow/core/platform/cpu_feature_guard.cc:193] This TensorFlow binary is optimized with oneAPI Deep Neural Network Library (oneDNN) to use the following CPU instructions in performance-critical operations:  AVX2 FMA
To enable them in other operations, rebuild TensorFlow with the appropriate compiler flags.
2023-01-21 12:56:30.053099: W tensorflow/core/framework/cpu_allocator_impl.cc:82] Allocation of<PHONE_NUMBER> exceeds 10% of free system memory.
2023-01-21 12:56:30.731465: W tensorflow/core/framework/cpu_allocator_impl.cc:82] Allocation of<PHONE_NUMBER> exceeds 10% of free system memory.
2023-01-21 12:56:31.418647: W tensorflow/core/framework/cpu_allocator_impl.cc:82] Allocation of<PHONE_NUMBER> exceeds 10% of free system memory.
2023-01-21 12:56:32.072936: W tensorflow/core/framework/cpu_allocator_impl.cc:82] Allocation of<PHONE_NUMBER> exceeds 10% of free system memory.
2023-01-21 12:56:33.361915: W tensorflow/core/framework/cpu_allocator_impl.cc:82] Allocation of<PHONE_NUMBER> exceeds 10% of free system memory.
Killed

</details>

Clear OOM, not a vuln


Lay out foundation for proprietary level format including tools.

[ ] API specification (modular / extendable design)
[ ] Layout foundation for level editor; decide on what widget toolkit to use
[ ] External utilities for converting already existing formats

BSP Versions

IBSP23 (Quake)
IBSP38 (Quake 2)
IBSP46 (Quake 3)
VBSP (Half-Life 2, Team Fortress 2, SiN Episodes)
VBSP17 (VTMB)

Other

VMF
T3D
MAP
Research LithTech level format
http://www.shamusyoung.com/twentysidedtale/?p=4759
http://www.gamers.org/dhs/helpdocs/dmsp1666.html

Goals have changed dramatically since I raised this, killing it now.


Norsk tipping permissionboundary

Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Merged in other MR! Thanks for the contribution!


hnix doesn't build on nixos-unstable

Describe the bug
nix-shell -p haskellPackages.hnix
results in
copying path '/nix/store/cgwj1yggbds25slahdjklc8lh0kfbl7i-haskell-src-meta-0.8.5' from 'https://cache.nixos.org'...
building '/nix/store/zf9kvw36yn5z9sl491l3fc2bjbrxv7zx-regex-tdfa-text-<IP_ADDRESS>.drv'...
building '/nix/store/qhbc5q28szp95d5bvamnx4z3lzhlvbj3-these-0.7.6.drv'...
copying path '/nix/store/07mrkw1hw8yr9vi7yhnqzfpaihvb8m6s-tasty-hspec-<IP_ADDRESS>' from 'https://cache.nixos.org'...
setupCompilerEnvironmentPhase
Build with /nix/store/34mx8khxgbf4nhi3lqsbysq5w38pbfbd-ghc-8.8.2.
unpacking sources
unpacking source archive /nix/store/zqwk4fb0ycr8s8jbwzwawclj1q9cha3x-regex-tdfa-text-<IP_ADDRESS>.tar.gz
source root is regex-tdfa-text-<IP_ADDRESS>
setting SOURCE_DATE_EPOCH to timestamp<PHONE_NUMBER> of file regex-tdfa-text-<IP_ADDRESS>/Text/Regex/TDFA/Text/Lazy.hs
patching sources
Replace Cabal file with edited version from mirror://hackage/regex-tdfa-text-<IP_ADDRESS>/revision/1.cabal.
compileBuildDriverPhase
setupCompileFlags: -package-db=/build/setup-package.conf.d -j4 -threaded
[1 of 1] Compiling Main             ( Setup.lhs, /build/Main.o )
setupCompilerEnvironmentPhase
Build with /nix/store/34mx8khxgbf4nhi3lqsbysq5w38pbfbd-ghc-8.8.2.
Linking Setup ...
copying path '/nix/store/1flg5rfxjrr1slg4878vijvn9fpqhzvf-interpolate-0.2.0' from 'https://cache.nixos.org'...
unpacking sources
unpacking source archive /nix/store/ql1vm9zx9zh9kcc77rfdr36a3xh73hww-these-0.7.6.tar.gz
source root is these-0.7.6
setting SOURCE_DATE_EPOCH to timestamp<PHONE_NUMBER> of file these-0.7.6/these.cabal
patching sources
Run jailbreak-cabal to lift version restrictions on build inputs.
compileBuildDriverPhase
setupCompileFlags: -package-db=/build/setup-package.conf.d -j4 -threaded
[1 of 1] Compiling Main             ( Setup.hs, /build/Main.o )
Linking Setup ...
configuring
configureFlags: --verbose --prefix=/nix/store/rbpsxlm082dpiv8r39fl1ac5zq1yb767-regex-tdfa-text-<IP_ADDRESS> --libdir=$prefix/lib/$compiler --libsubdir=$abi/$libname --docdir=/nix/store/chfppam99a9amy7r4ziazdi18v89h8iw-regex-tdfa-text-<IP_ADDRESS>-doc/share/doc/regex-tdfa-text-<IP_ADDRESS> --with-gcc=gcc --package-db=/build/package.conf.d --ghc-option=-j4 --disable-split-objs --enable-library-profiling --profiling-detail=exported-functions --disable-profiling --enable-shared --disable-coverage --enable-static --disable-executable-dynamic --enable-tests --disable-benchmarks --enable-library-vanilla --disable-library-for-ghci --ghc-option=-split-sections --extra-lib-dirs=/nix/store/wxwzrhjxpzznkxky64965af43l98bjji-ncurses-6.1-20190112/lib --extra-lib-dirs=/nix/store/bxqxy5lnj6cp3lmfw1j0q42ss3b8zgaj-libffi-3.3/lib --extra-lib-dirs=/nix/store/llkj5hw3mnv67cqc69hxysngr74a524g-gmp-6.2.0/lib
Using Parsec parser
Configuring regex-tdfa-text-<IP_ADDRESS>...
CallStack (from HasCallStack):
  die', called at libraries/Cabal/Cabal/Distribution/Simple/Configure.hs:1022:20 in Cabal-<IP_ADDRESS>:Distribution.Simple.Configure
  configureFinalizedPackage, called at libraries/Cabal/Cabal/Distribution/Simple/Configure.hs:475:12 in Cabal-<IP_ADDRESS>:Distribution.Simple.Configure
  configure, called at libraries/Cabal/Cabal/Distribution/Simple.hs:625:20 in Cabal-<IP_ADDRESS>:Distribution.Simple
  confHook, called at libraries/Cabal/Cabal/Distribution/Simple/UserHooks.hs:65:5 in Cabal-<IP_ADDRESS>:Distribution.Simple.UserHooks
  configureAction, called at libraries/Cabal/Cabal/Distribution/Simple.hs:180:19 in Cabal-<IP_ADDRESS>:Distribution.Simple
  defaultMainHelper, called at libraries/Cabal/Cabal/Distribution/Simple.hs:116:27 in Cabal-<IP_ADDRESS>:Distribution.Simple
  defaultMain, called at Setup.lhs:3:10 in main:Main
Setup: Encountered missing or private dependencies:
regex-base <0.94

builder for '/nix/store/zf9kvw36yn5z9sl491l3fc2bjbrxv7zx-regex-tdfa-text-<IP_ADDRESS>.drv' failed with exit code 1
cannot build derivation '/nix/store/wrwqp82q7azdsh6kn8x7r0abl1a4sz58-hnix-0.6.1.drv': 1 dependencies couldn't be built
error: build of '/nix/store/wrwqp82q7azdsh6kn8x7r0abl1a4sz58-hnix-0.6.1.drv' failed

Metadata

system: "x86_64-linux"
host os: Linux 5.4.23, NixOS, 20.09pre215947.82b54d49066 (Nightingale)
multi-user?: yes
sandbox: yes
version: nix-env (Nix) 2.3.3
channels(philipp): ""
channels(root): ""
nixpkgs: /nix/store/w8s6mcva9z073fqf6v1jmj6dhjjl0w5f-source

Maintainer information:
# a list of nixpkgs attributes affected by the problem
attribute:
# a list of nixos modules affected by the problem
module:

@pmiddend Thanks for reporting this.
We'd appreciate a PR fixing this, although it might be easiest just to get upstream to release a version that supports a newer regex-base.
Also, getting hnix in Stackage would help prevent this problem in the future.

At latest zurihac, I tried to take a look getting this into stackage with @sboehler - see https://github.com/haskell-nix/hnix/issues/494 and https://github.com/haskell-nix/hnix/pull/504.
TLDR: we need to get a pure haskell hashing library into stackage first, as cryptonite is a no-no (due to GHCJS).

@flokli if you're interested in getting hnix into Stackage, you can probably just send a PR to Stackage adding libraries like hashing, monadlist, and ref-tf.
As long as those libraries already build in stackage nightly, this is normally a pretty easy process.
If those libraries don't already build in Stackage nightly, you'll have to send PRs updating them, and then get the maintainer to make a release to Hackage.

I'm all for fixing this properly, but is there any way to fix this purely in nixpkgs? For now, I mean.

I'm probably not the right person to do this. I don't use hnix, and am not that involved in the Haskell ecosystem either.

@pmiddend From the error message, it appears that regex-tdfa-text depends on an older version of regex-base.
There are a couple possible ways to fix this.  Some of these may not work depending on the package:

Jailbreak regex-tdfa-text so it uses a later version of regex-base.
Get upstream to release a newer version of regex-tdfa-text so that it is compatible with the version of regex-base in nixpkgs.

Btw. with the latest nixos-unstable, I now get
Setup: Encountered missing or private dependencies:
pretty-show >=1.9.5 && <1.10

Feel free to use https://github.com/sorki/hnix-overlay meanwhile

Builds with unstable since https://github.com/NixOS/nixpkgs/commit/c054bc60f7a1b3d24090e2b0395293fcf4e279a8, unbroken in https://github.com/NixOS/nixpkgs/commit/c9b67ee802360d33c617cce8ea5501f6c2b60396


Mixed box load into case

Now there's single box load into case.
Can mixed box loading?

Heterogeneous loading of cases will soon be available.
Regards,


[5.8] Minimized mode should display less content

Explanation: Removing unneeded content originally displayed for documentation pages for minimized mode
Scope: Small changes made to conditionally display content on the documentation page.
Issue: rdar://103149476
Risk: Small risk for regressions of contents displayed on Documentation pages
Testing: Tested for regressions via existing unit tests, added new unit tests for the minimized mode.
Reviewer: @mportiz08
Original PR: #498

@swift-ci test


Add CookieStore access from Clients

This pull request is similar #859 but solves the problem in a different way.
It should solve #874, #613, and #767.
I added two methods on the clients returning a lock of the cookie store (wasm target is not supported).
I also implemented function aliases on the custom CookieStore struct of this crate (it will be easier to use).

I am going to revert the commits and start again with the new design suggested by @seanmonstar.

@Mubelotix are you going to resume this PR? Otherwise i can implement this feature.
And snapshots are better i guess because thats how chrome extensions etc also work. Like when we ask cookies they gets snapshot version.

@shirshak55 I will but it could take a lot of time. I am not sure I will do it in the near future. Feel free to open a new PR. I will close this one, at least for a moment.


doraemon slide puzzle game

fixes #715
make doraemon with the help of 9 pieces

Please refer the documentation. Checks have failed

Please refer the documentation. Checks have failed

Please merge my PR ...2 days left


Ugrade JQuery Version

Because JQuery-1.11.2 is from 2014 an has several security issues like cross-site-scripting. It would be nice to update it so we can use the generated html report safely.
At least should be used jQuery 3.5.0 or the latest possible stable version of jQuery.
Version of Archi
4.10
Archi Plug-ins
coArchi-0.8.7
Operating System
Windows 10 Version 10.0.19044 Build 19044
Expected Behaviour
No security vulnerabilities in through an old jQuery
Actual Behaviour
A security Scan reveiled that the used version of jQuery is too old and has too much security issues
Steps to Reproduce the Behaviour
Use the latest version of Archimate and generate a html report. The jQuery version in the folder lib/jquery/js is from 2014 with version 1.11.2.

Thanks for the report. Are you cable to provide a PR with the updated jQuery files?

"It would be nice to update it"
If only it were as simple as that. A whole bunch of other stuff doesn't work as a result. I'm investigating.
(If only Archi was Open Source, someone might be able to help and contribute a fix...)

I'm investigating.

I would suggest not to investigate...

A security Scan reveiled that the used version of jQuery is too old and has too much security issues
It would be nice to update it so we can use the generated html report safely.

And how many of these security issues affect a static website ? For example, cross-site-scripting is not a risk in such context because there's no backend or database to attack. Moreover, such reports are intended to be share internally through an intranet and not to be freely accessible over internet. Could you please provide a more detailed risk analysis?

If only Archi was Open Source, someone might be able to help and contribute a fix...

Yes, if someone is willing to provide a PR which doesn't break any of the other part of the report (embedded AlaSQL Database, filtering of the model tree, queries...) then of course we can merge it, but for the time being, I thing we have other priorities (Archi 5 and coArchi 2), and I'm planing to update the HTML report only when I'll be able to redesign it completely.

If only Archi was Open Source, someone might be able to help and contribute a fix..

I can try to update jquery, but it would take some time because I have to understand how to test it first.

I've got a branch with updated jQuery and other stuff which works. Am investigating the zoom slider not working on IE

IE is not supported anymore by windows and is dead, I think time spending with IE is not necessary (I can be wrong here)

IE is not supported anymore by windows and is dead, I think time spending with IE is not necessary (I can be wrong here)

Archi uses the internal browser component for the HTML report preview. On Windows, by default, this is IE11, or Edge in IE mode. I have set an option in Archi to use Edge but this is off by default and some Windows 10 users don't have the Edge Runtime installed.

I've fixed the outstanding issues. There's a new branch jQuery and commit  that needs to be tested.

I tested it as far as I could and it seems that everything works like before. No Issues found on the generated website an its behaviour.

I tested it as far as I could and it seems that everything works like before. No Issues found on the generated website an its behaviour.

Thanks for testing. When using Preview HTML report this is written to the console:
context [/modelreport /expandFolder /_sub2 /classesFromProperties /_sub3] 1:25 no such template: /IGNORE_ERROR_Id
I need to investigate the cause of that.

I need to investigate the cause of that.

Actually this is unrelated to the later version of jQuery.

I'll commit the updated JQuery branch for Archi 5 beta 2 and see if any issues arise.

This is in Archi 5 beta 2

Closing. Will re-open if there are any further issues.


AutoPr-CognitiveServices.Personalizer-dwaijam-REST Spec PrNumber 5827

Closing since Rest spec PR is closed


Add UNIQ token

为确保 Token Profile 的顺利通过，务必逐一确保以下检查项并补充项目资料：
.json 及 .png 文件检查项

[ ] logo 尺寸：120*120 px
[ ] logo 背景：透明
[ ] 代币有至少一笔成功的转账记录
[ ] 此项对于 ERC-20 项目方：合约地址有大小写（做 checksum）
[ ] .json 和 .png 文件名一致（包括大小写）

项目资料：
官方公告：
团队背景：
项目基本情况：
媒体报道：
收录的交易所：
转账所需 Gas Limit（对 ERC-20 项目方）：（默认为 60000）

Please check the following to ensure a successful verification of Token Profile
.json and .png document checklists

[ x] logo dimensions: 120*120 px
[ x] logo background: Transparent
[ x] At least one transaction on the token contract
[ x] For ERC-20 project teams: Upper and lower capitalized alphabets in token address (For checksum purposes)
[ x] Same document name for both .json and .png (Including capitalization)

Project background:
The Uniqson Artificial Intelligence is a big data blockchain system which utilizes UniqCoins that can be used for restaurants, payment of bills, e-commerce, and travel
Official announcement: https://uniqinternational.com/uniqcoin/
Project team background: https://uniqinternational.com/about-us/
Project basic information: The Uniqson Artificial Intelligence, or UAI, is an adaptive learning technology, built into the UBBS, a proprietary data network developed by Uniqson Analytics International. Basically, it enables marketers to instantly act on changes in audience behavior to improve marketing relevance and results. Now enhanced with blockchain, it is not only secure but the data obtained is much more valuable due to its structural integrity and immense inputs. This makes the data on UBBS the perfect source for analysis and comprehension.
Media publications: https://uniqinternational.com/mining-contract/
Tradeable exchanges: NA
Recommended Gas Limit (For ERC-20 project teams) for transaction: (Default is 60,000)

Welcome to recommend imToken 2.0 to your token holders to manage their token.


Client side error: .env has no default export

When I run npm start at the client side, I get this error:
ERROR in environments/environment.ts:6:8 - error TS1192: Module '"/home/Project/tp/client/src/environments/.env"' has no default export.
6 import env from './.env';
~~~
environments/environment.prod.ts:2:8 - error TS1192: Module '"/home/Project/tp/client/src/environments/.env"' has no default export.
2 import env from './.env';
~~~
** Angular Live Development Server is listening on localhost:4200, open your browser on http://localhost:4200/ **
ℹ ｢wdm｣: Failed to compile.

But the contents of the .env file seem to be correct:
export const env: { [s: string]: (string | null); } = {
'npm_package_version': '1.0.0'
};

Fixed with PR #33
cc: @coooolers

I did following and it worked for me.
import {env} from './.env';

Thanks


🔥 remove research site, django-hosts, etc.

@madprime this removes the research.openhumans.org pages and associated views and forms.
Neither of us noticed, but the research site is currently returning a 500 error so this is probably safe to merge. :)

Current coverage is 87.31%

Merging #440 into master will increase coverage by +0.49% as of 5908bd5

@@            master    #440   diff @@
======================================
  Files          223     220     -3
  Stmts         9879    9750   -129
  Branches         0       0
  Methods
======================================
- Hit           8577    8513    -64
  Partial          0       0
+ Missed        1302    1237    -65

Review entire Coverage Diff as of 5908bd5

Powered by Codecov. Updated on successful CI builds.


checkcommitreadiness return always false for approvals

Hi there,
I'm trying to setup chaincode on fabric 2.2, but, I dont'know why, approvals are always setted to false when I run peer lifecycle chaincode checkcommitreadiness:
this is my approveformyorg:
peer lifecycle chaincode approveformyorg -o orderer.example.com:7050 --cafile $ORDERER_CA --channelID mychannel --name newc --version 1.0 --init-required --package-id $CONTRACTS_PACKAGE_ID --sequence 1 --signature-policy 'OR("Org1MSP.peer", "Org2MSP.peer")' --collections-config /opt/gopath/src/github.com/chaincode/collections/collections_config.json

and its output:
txid [376e4c1d55d4cffa08e4d6f3f9032ae21f54e6fd78f8ac1e406037988143b4a9] committed with status (VALID) at peer0.contracts.example.com:7051

this is my checkcommitreadiness:
peer lifecycle chaincode checkcommitreadiness -o orderer.example.com:7050 --cafile $ORDERER_CA --channelID mychannel --name newc --version 1.0 --init-required --sequence 1 --output json --signature-policy 'OR("Org1MSP.peer", "Org2MSP.peer")' --collections-config /opt/gopath/src/github.com/chaincode/collections/collections_config.json

when I run the above command the output is always:
{
        "approvals": {
                "Org2MSP": false,
                "Customer": false,
                "Org1MSP": false
        }
}

why?
Any suggestion is welcome. Thanks in advance

I'm facing the same issue. It looks like that running peer lifecycle chaincode approveformyorg without the --init-required flag works just fine. Maybe it's a legacy API? I mean, for versions lower than 2.x?

I'm not able to reproduce, it works for me.
--init-required must either be absent or present in both the approveformyorg and checkcommitreadiness calls. In the example above it is present in both, so it should return true.

Are there any updates regarding this issue? I both used removed and added --init-required flag, but still returning false for all of my organizations. It only works when I removed the --collections-config flag. I think this is related to updating the chaincode definition with collections config.

I'm facing the same issue and cannot commit it

The same here, but I could commit. It is very strange. I put screenshot of my checkcommitreadiness and chaincode querycommitted:

@Koosha-E-Khorasani
In order to further investigate this issue, could you provide the series of chaincode lifecycle commands you executed? Specifically, I'd like to see the commands for approveformyorg, checkcommitreadiness, and querycommitted, along with the flags you used for each. This information will be invaluable for reproducing the situation and identifying the cause.

@satota2 sorry for the delay! I followed this for the chaincode installation.

installing chain code:
peer lifecycle chaincode install basic.tar.gz

approve

peer lifecycle chaincode approveformyorg -o host.docker.internal:7041 --ordererTLSHostnameOverride host.docker.internal --channelID channel1 --name basic_1.0 --version 1.0 --package-id  $CC_PACKAGE_ID  --sequence 1 --tls --cafile ../org1/peer1/tls-msp/tlscacerts/tls-0-0-0-0-7052.pem

commit readiness

peer lifecycle chaincode commit -o host.docker.internal:7041 --ordererTLSHostnameOverride host.docker.internal --channelID channel1 --name basic --version 1.0 --sequence 1 --tls --cafile ../org1/peer1/tls-msp/tlscacerts/tls-0-0-0-0-7052.pem  --peerAddresses host.docker.internal:7061 --tlsRootCertFiles ../org1/peer1/tls-msp/tlscacerts/tls-0-0-0-0-7052.pem --peerAddresses host.docker.internal:7071 --tlsRootCertFiles ../org1/peer1/tls-msp/tlscacerts/tls-0-0-0-0-7052.pem

querycommited

peer lifecycle chaincode querycommitted --channelID channel1 --name basic --cafile ../org1/peer1/tls-msp/tlscacerts/tls-0-0-0-0-7052.pem

@Koosha-E-Khorasani
Thank you for sharing the information.
Upon reviewing the commands you've shared, I noticed that the value for the chaincode name (--name) in approveformyorg seems to be different from what is used in other commands; it's basic_1.0. It's important to maintain consistency in the chaincode definition parameters specified in approveformyorg, commitreadiness, and commit.
Would the issue be resolved if we change the name value in approveformyorg to basic?

@satota2  Thank you for mentioning that.
Thats a typo. It happened as I got commands from my command line history and I installed multiple chain codes. I edited them. In process of installing, I used right chain code name and I faced the problem I mentioned (As you can see in the screenshots above, they all belong to basic chaincode). Thus, it does not resolve when you use chain code name basic in all of commands.

@Koosha-E-Khorasani Thank you for your information.
I tried this instruction on my local environment but I'm not able to reproduce the problem.
To get a more detailed understanding of the situation, you can execute the following commands:
Switch to Org1, then run:
peer lifecycle chaincode queryapproved --channelID channel1 --name basic --output json
Switch to Org2, then run:
peer lifecycle chaincode queryapproved --channelID channel1 --name basic --output json
By running these commands, you should be able to obtain the latest approved chaincode definition for each organization. This can be useful for troubleshooting. The output will look something like this:
{
        "sequence": 2,
        "version": "2.0",
        "endorsement_plugin": "escc",
        "validation_plugin": "vscc",
        "validation_parameter": "EiAvQ2hhbm5lbC9BcHBsaWNhdGlvbi9FbmRvcnNlbWVudA==",
        "collections": {},
        "source": {
                "Type": {
                        "LocalPackage": {
                                "package_id": "basic_2.0:30934b6d6e068f10ae0257713bba946cad2352d0e3f75513d203e6ae066d82e1"
                        }
                }
        }
}

I am having the same issue, what's the solution??

@dc-atos-dev and anybody else hitting the issue... please post the approved chaincode definition known to each org as suggested above at https://github.com/hyperledger/fabric/issues/3330#issuecomment-1705106470.
The approved chaincode definitions can then be evaluated to determine if there is a difference between the orgs.
Reminder, to switch between orgs you can use environment variables as mentioned in tutorial at https://hyperledger-fabric.readthedocs.io/en/latest/deploy_chaincode.html, e.g.:
export CORE_PEER_LOCALMSPID="Org2MSP"
export CORE_PEER_TLS_ROOTCERT_FILE=${PWD}/organizations/peerOrganizations/org2.example.com/peers/peer0.org2.example.com/tls/ca.crt
export<EMAIL_ADDRESS>export CORE_PEER_ADDRESS=localhost:9051

Hi @denyeart
This is the ouput for ORG1:
ariuserbip@bippreproductionservices:~/fabric$ docker exec cli peer lifecycle chaincode queryapproved --channelID mychannel --name vdr --output json {         "sequence": 1,         "version": "1.0",         "endorsement_plugin": "escc",         "validation_plugin": "vscc",         "validation_parameter": "CiwSDBIKCAESAggAEgIIARoNEgsKB09yZzFNU1AQAxoNEgsKB09yZzJNU1AQAw==",         "collections": {                 "config": [                         {                                 "Payload": {                                         "StaticCollectionConfig": {                                                 "name": "didDocCollection",                                                 "member_orgs_policy": {                                                         "Payload": {                                                                 "SignaturePolicy": {                                                                         "rule": {                                                                                "Type": {                                                                                "NOutOf": {                                                                                "n": 1,                                                                                "rules": [                                                                                {                                                                                "Type": {                                                                                "SignedBy": 0                                                                                }                                                                                },                                                                                {                                                                                "Type": {                                                                                "SignedBy": 1                                                                                }                                                                                }                                                                                ]                                                                                }                                                                                }                                                                         },                                                                         "identities": [                                                                                {                                                                                "principal": "CgdPcmcxTVNQ"                                                                                },                                                                                {                                                                                "principal": "CgdPcmcyTVNQ"                                                                                }                                                                         ]                                                                 }                                                         }                                                 },                                                 "maximum_peer_count": 1,                                                 "member_only_read": true,                                                 "member_only_write": true,                                                 "endorsement_policy": {                                                         "Type": {                                                                 "SignaturePolicy": {                                                                         "rule": {                                                                                "Type": {                                                                                "NOutOf": {                                                                                "n": 1,                                                                                "rules": [                                                                                {                                                                                "Type": {                                                                                "SignedBy": 0                                                                                }                                                                                },                                                                                {                                                                                "Type": {                                                                                "SignedBy": 1                                                                                }                                                                                }                                                                                ]                                                                                }                                                                                }                                                                         },                                                                         "identities": [                                                                                {                                                                                "principal": "CgdPcmcxTVNQ"                                                                                },                                                                                {                                                                                "principal": "CgdPcmcyTVNQ"                                                                                }                                                                         ]                                                                 }                                                         }                                                 }                                         }                                 }                         }                 ]         },         "init_required": true,         "source": {                 "Type": {                         "LocalPackage": {                                 "package_id": "vdr:298182c83facca0e4613aa1e31824cb642a6a5a5aa3f99d8ee39bc502376129f"                         }                 }         } }
Org2:
ariuserbip@bippreproductionservices:~/fabric$ docker exec -e<EMAIL_ADDRESS>-e CORE_PEER_ADDRESS=peer0.org2.example.com:9051 -e CORE_PEER_LOCALMSPID="Org2MSP" -e CORE_PEER_TLS_ROOTCERT_FILE=/opt/gopath/src/github.com/hyperledger/fabric/peer/crypto/peerOrganizations/org2.example.com/peers/peer0.org2.example.com/tls/ca.crt cli peer lifecycle chaincode queryapproved --channelID mychannel --name vdr --output json {         "sequence": 1,         "version": "1.0",         "endorsement_plugin": "escc",         "validation_plugin": "vscc",         "validation_parameter": "CiwSDBIKCAESAggAEgIIARoNEgsKB09yZzFNU1AQAxoNEgsKB09yZzJNU1AQAw==",         "collections": {                 "config": [                         {                                 "Payload": {                                         "StaticCollectionConfig": {                                                 "name": "didDocCollection",                                                 "member_orgs_policy": {                                                         "Payload": {                                                                 "SignaturePolicy": {                                                                         "rule": {                                                                                "Type": {                                                                                "NOutOf": {                                                                                "n": 1,                                                                                "rules": [                                                                                {                                                                                "Type": {                                                                                "SignedBy": 0                                                                                }                                                                                },                                                                                {                                                                                "Type": {                                                                                "SignedBy": 1                                                                                }                                                                                }                                                                                ]                                                                                }                                                                                }                                                                         },                                                                         "identities": [                                                                                {                                                                                "principal": "CgdPcmcxTVNQ"                                                                                },                                                                                {                                                                                "principal": "CgdPcmcyTVNQ"                                                                                }                                                                         ]                                                                 }                                                         }                                                 },                                                 "maximum_peer_count": 1,                                                 "member_only_read": true,                                                 "member_only_write": true,                                                 "endorsement_policy": {                                                         "Type": {                                                                 "SignaturePolicy": {                                                                         "rule": {                                                                                "Type": {                                                                                "NOutOf": {                                                                                "n": 1,                                                                                "rules": [                                                                                {                                                                                "Type": {                                                                                "SignedBy": 0                                                                                }                                                                                },                                                                                {                                                                                "Type": {                                                                                "SignedBy": 1                                                                                }                                                                                }                                                                                ]                                                                                }                                                                                }                                                                         },                                                                         "identities": [                                                                                {                                                                                "principal": "CgdPcmcxTVNQ"                                                                                },                                                                                {                                                                                "principal": "CgdPcmcyTVNQ"                                                                                }                                                                         ]                                                                 }                                                         }                                                 }                                         }                                 }                         }                 ]         },         "init_required": true,         "source": {                 "Type": {                         "LocalPackage": {                                 "package_id": "vdr:298182c83facca0e4613aa1e31824cb642a6a5a5aa3f99d8ee39bc502376129f"                         }                 }         } }     Comparing them, The presence of identical configurations suggests that both ORG1 and Org2 have approved the same chaincode definition.

@dc-atos-dev
Certainly, it does look like both ORG1 and Org2 have approved the same chaincode definition, making root cause analysis challenging. Could you possibly share the execution flags and output results from the time you ran the failing commitreadiness command? It might help us pinpoint the issue. It might provide some insights for troubleshooting.

I tried all of the above suggested solutions, none of them work. This is so frustrating!!!

I already figured out it, we need to add --signature-policy at both the approveformyorg and checkcommitreadiness step.


test with real IdPs

Currently this package is confirmed to work the idp.spid.gov.it:9443 identity provider.
We need to test it with real idps.

I have added the spid-laravel package, and was also able to test using the idp.spid.gov.it:9443
but since a while it is not possible to authenticate using the same. Any idea why is that happening?

Hi @i1990jain,
for testing purposes please refer to https://github.com/italia/spid-testenv2 and no more to idp.spid.gov.it:9443 (not officially supported).
Additionally consider that this package will be soon updated to use https://github.com/italia/spid-php-lib/ and drop any other external dependency.


Indented comments don't get continued lines indented

Describe the bug
Indented comments don't wrap onto indented new lines in rust. Seems to be ok in the lua plugin.

OK: cc executable found. Selected from { vim.NIL, "cc", "gcc", "clang", "cl" }
OK: Neovim was compiled with tree-sitter runtime ABI version 13 (required >=13). Parsers must be compatible with runtime ABI.

 This repository is just the parser, which is then used by Neovim to provide things like auto-indent. Can you reopen this on the Neovim or nvim-treesitter repo?

I think you're describing a Neovim issue here? This repository is just the parser, which is then used by Neovim to provide things like auto-indent. Can you reopen this on the Neovim or nvim-treesitter repo?

I'm unsure if it's one of those: the treesitter-lua and c++ modules appear to have working indentation in this situation, by comparison, which led me to believe it's a rust grammar specific issue. I was initially going to file this on nvim-treesitter but reconsidered on the basis of it being seemingly language specific.
Is there any debug info I could get that might be helpful?

It may be a language-specific issue inside of nvim-treesitter? Not all language-specific logic is contained in this repository: just the parser itself.


Update the DG for add feature

Just a heads up, I've made my UML diagrams follow a similar format to yours. I think it's probably good that documentation looks standardized after all. Let me know if that's fine.