Isn't there anyway not to reset when it reached 100%

Sorry, there is no such place that I could ask about this. so I post it here.
I would like to show various data through this framework, however it keeps being reset.
on my project I used timer.scheduled to get some animation.
there is 2 integers I have set
for example
private var progress: UInt8 = 0
var totalAmount:Int = 28000
var paidAmount:Int = 8000
@IBOutlet private weak var storyboardCircularProgress1: KYCircularProgress!
@IBOutlet private weak var progressLabel: UILabel!
override func viewDidLoad() {
    super.viewDidLoad()

    configureStoryboardProgress1()
    updateProgress()
}

private func configureStoryboardProgress1() {
    storyboardCircularProgress1.colors = [.purple, .purple, .purple]
    storyboardCircularProgress1.progressChanged {
        (progress: Double, circularProgress: KYCircularProgress) in
        self.progressLabel.text = String.init(format: "%.0f", progress * 100.0) + "%"
    }
    storyboardCircularProgress1.
}

@objc private func updateProgress() {
    progress = progress &+ 2
    let normalizedProgress = Double(progress) / Double(UInt8.max)
    storyboardCircularProgress1.progress = normalizedProgress
    if progress == 255
    {

    }
    if progress < UInt8(Double(paidAmount) / Double(totalAmount) * 255)
    {
        self.addTime()
    }
}

func addTime()
{
    Timer.scheduledTimer(timeInterval: 0.01, target: self, selector: #selector(updateProgress), userInfo: nil, repeats: false)
}

}
the animation showed 30% whiles it's about 29.6% that's great however, when I set
var totalAmount:Int = 28000
var paidAmount:Int = 0
the result will be 1% that's weird and also
var totalAmount:Int = 28000
var paidAmount:Int = 28000
then the result keeps being reset and animation goes forever like your demo.
I really wish that I could use the framework for my project, it's really simple and nice but I'm not capable enough to fix this problem. Hope you could kindly guide me to right path.
Thanks million in advance.

Sorry my fault :( I figured it out by myself.


Simplification rewrites for elementwise unary minus (additive inverse)

DaphneDSL supports the elementwise additive inverse through the typical unary minus operator:
X = [1.1, 2.2, 3.3];
print(-X);

Internally, this operation is represented as a EwMinusOp in DaphneIR.
Task: This task is to add typical simplifications of this operation to the DAPHNE compiler, such as:

Constant folding: Expressions like -123 could be evaluated at compile-time.
Static rewrites: E.g., --x to x.

Overall, such simplications can make the IR simpler and more readable, unlock further simplifications of consuming operations, and reduce the computational effort at run-time.
Hints:

Get familiar with canonicalization and constant folding in MLIR.
Have a look at the existing implementations of such simplifications for other DaphneIR operations in src/ir/daphneir/DaphneDialect.cpp.

Hello, please assign me to this issue and #775 .

Thanks for your interest. Sure, go ahead!


Replace deprecated leftShift(Closure) method

Issue: The Task.leftShift(Closure) method has been deprecated and is scheduled to be removed in Gradle 5.0.
Fix: Use Task.doLast(Action) instead.
Resolves: https://github.com/signalapp/gradle-witness/issues/22

@moxie0 Can this be merged?


SDL shall not put RC applications to HMI level NONE when user disables RC in HMI

Fixes #2173
https://github.com/smartdevicelink/sdl_evolution/blob/master/proposals/0181-keep-rc-app-hmi-level-when-disable-rc.md
This PR is [ready] for review.
Testing Plan
test set: https://github.com/smartdevicelink/sdl_atf_test_scripts/blob/fix/rc_disabling/test_sets/rc_CLIMATE_RADIO.txt
PR for scripts: https://github.com/smartdevicelink/sdl_atf_test_scripts/pull/1979
Summary
Fix behavior in case when RC functionality is disabled from HMI
CLA

[x] I have signed the CLA

Please update OnRemoteControlSettings_disablingRC.png, in which it says app1 cannot be activated while RC functionality is disabled on HMI, which shall be removed.
When RC disabled, we still allow activate RC applications.

@yang1070 Fixed 6aefc8cceb726f9c756c5b5feb902dc66d911286

@yang1070 Updated f994b74


[BUG] getSubmissions with query arg has no effect

Environment
Please provide as many details as you can:

Hosting type

[] Form.io
[x ] Local deployment

Version: 1.50.0 Docker image built locally

formio/react-app-starterkit@8511dd2743

Formio.js version: 4.0.0-rc.21
Frontend framework: = react-formio 4.0.0-rc.18 e5718c5af8

Browser: N/A
Browser version: N/A

Steps to Reproduce

create a form and some submissions, e.g. Person with components name (Text Field) and age (Number)
modify react-app-starterkit and create a component like react-app-starterkit/src/views/Form/Item/Submission/List.js which uses a SubmissionGrid with such a mapDispatchToProps:

const mapDispatchToProps = (dispatch, ownProps) => {
  return {
    getSubmissions: (page, query) =>  dispatch(getSubmissions('submissions', page, { "data.age__gt": 40 } , ownProps.match.params.formId))},

add a route for it in src/App.js

Expected behavior
When the component mounts, getSubmissions should retrieve only those Person instances with age > 40.
Observed behavior
All Person instances are loaded.
Example
cf. above

I hope this is the correct interpretation of this part of the README (emphasis mine):
submissions
...
Actions

Name
Parameters
Description

getSubmissions
name: string, page: integer, params: object, formId: string
Fetch a list of submissions from the server. params is a query object to filter the submissions.

Thanks for finding this. We intended this all along but somehow missed combining the query. I'll get it merged in the next build.

Thanks for your quick reply. I have just opened #244 which is very similar. Will push a PR for that one shortly.


Rewrite ajax module to use abortable fetch

Feature Request
The ajax module is currently built on top of XHR. IIUC, this is because fetch did not initially support cancellation (and maybe also for browser support?). However, fetch does not support cancellation.
There might be benefits to using fetch under the hood instead of XHR. One that I've just stumbled across is, when using XHR, there is no way to reliably detect network errors, whereas with fetch there is.
Is this something we should consider? Or perhaps it should exist in user land.

Dupe of https://github.com/ReactiveX/rxjs/issues/4128. We have long term plan but not able to polyfill abortcontroller makes whole rewrite will take time to happen. My userland module https://github.com/kwonoj/oxid/issues/71 plan to have it in userlans first.

Related: abortable-rx allows you to use fetch inside switchMap https://github.com/felixfbecker/abortable-rx/tree/0b60bfc80e61904e720f99e9ca8c662c72dc4f51#using-fetch-inside-switchmap

This is achieved, closing. Each issue may need to be filed separately if found.


drop clusterautoscaler-v1.25

Kubernetes v1.25 is no longer supported by Gardener, thus remove reference to corresponding clusterautoscaler version.
How to categorize this PR?

/area delivery
/kind cleanup
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note:

drop clusterautoscaler-v1.25, which corresponds to deprecated k8s v1.25. With this change, Gardener landscapes will no longer be able to provision shoot-clusters running on k8s v1.25.

1.25 is still supported by Gardener, see

https://github.com/gardener/gardener/blob/9cbfbf9fa9209efd4cdfdbdb45a48955a2c168d6/pkg/utils/validation/kubernetesversion/version.go#L16
https://github.com/gardener/gardener/blob/9cbfbf9fa9209efd4cdfdbdb45a48955a2c168d6/docs/usage/supported_k8s_versions.md?plain=1#L17-L19

1.25 is still supported by Gardener, see

https://github.com/gardener/gardener/blob/9cbfbf9fa9209efd4cdfdbdb45a48955a2c168d6/pkg/utils/validation/kubernetesversion/version.go#L16
https://github.com/gardener/gardener/blob/9cbfbf9fa9209efd4cdfdbdb45a48955a2c168d6/docs/usage/supported_k8s_versions.md?plain=1#L17-L19

I see. In that case, I will close this pull-request. We will, however, need to release patch-versions of clusterautoscaler v1.25 + v1.26 in that case.

#10339 will remove the support for 1.25 and 1.26, which is planned to happen in October, can we keep using the current images until then?

We still require support for kubernetes version 1.26. We have a product that is working to become compatible with version 1.27, but it's still a work in progress.


[Refactor Flask I] Break up top-level

replaces #791

Hmm.. Looks like the module is missing in the PyInstaller build

replaced by many others


Fix Downloads/Subjobs not showing App Name

This job is not a subjob a.k.a parallel job, its just a download job
Fix Downloads/Subjobs not showing App Name as per the screenshot

Checkjob for that job id 5e989b832dd34ccf152fd3f4 is
{'authstrat': 'kbaseworkspace',
 'created':<PHONE_NUMBER>000,
 'finished':<PHONE_NUMBER>630,
 'job_id': '5e989b832dd34ccf152fd3f4',
 'job_input': {'app_id': 'AssemblyUtil.export_assembly_as_fasta',
               'method': 'AssemblyUtil.export_assembly_as_fasta',
               'narrative_cell_info': {},
               'params': [{'input_ref': '60101/3'}],
               'parent_job_id': 'None',
               'requirements': {'clientgroup': 'njs',
                                'cpu': 4,
                                'disk': 100,
                                'memory': 23000},
               'service_ver': 'release',
               'source_ws_objects': []},
 'job_output': {'id': '5e989b832dd34ccf152fd3f4',
                'result': [{'shock_id': '295bebc7-9fda-4d28-b59a-169fa0b9d314'}],
                'version': '1.1'},
 'queued':<PHONE_NUMBER>576,
 'running':<PHONE_NUMBER>631,
 'scheduler_id': '335189',
 'scheduler_type': 'condor',
 'status': 'completed',
 'updated':<PHONE_NUMBER>630,
 'user': 'bsadkhin'}

I see, this isn't detected as an export job, so it default to "unknown" job type. I'm working on a fix.

This should be much improved, at about
https://github.com/kbase/kbase-ui-plugin-job-browser2/commit/3c83b202bb21445eec0ddf3b6516f3d2d8281098
The fix is both front end and the back end bff. For non-narrative jobs, app column does not render a link, since there is no catalog view for non-narrative methods. The method is displayed without a link.


feat: support staking

:tada: This PR is included in version 1.0.0-dev.4 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


[AutoPR dns/resource-manager] Move DNS to use the common definition for resource groups

Created to sync https://github.com/Azure/azure-rest-api-specs/pull/3219

(message created by the CI based on PR content)

This PR has been merged into https://github.com/Azure/azure-sdk-for-python/pull/2728


confused about tgt_seq and gold, please give me some help

First, thanks for your share code. I got little confused about tgt_seq in Transformer.forward method(Models.py)
tgt_seq, tgt_pos = tgt_seq[:, :-1], tgt_pos[:, :-1]
can you tell me why did you discard the last char in sequence y ?   Is it related to the below code ?
gold = tgt_seq[:, 1:]
Any help will be appreciated !

Because of the BOS and EOS tokens, I think.

So the input sentence of tgt_seq is like [BOS, word1, word2, ..., PAD, PAD, ..., EOS]?

tgt_seq is like [BOS, word1, ..., PAD,..., PAD]; gold is like [word1, word2, ... EOS, PAD,..., PAD]

Thanks for your reply. But in Models.py, https://github.com/jadore801120/attention-is-all-you-need-pytorch/blob/20f355eb655bad40195ae302b9d8036716be9a23/transformer/Models.py#L202
tgt_seq, tgt_pos = tgt_seq[:, :-1], tgt_pos[:, :-1]

If tgt_seq is like [BOS, word1, ..., PAD,..., PAD]; why should I delete the last word in tgt_seq.

delete the last word so it looks like [BOS, word1, ..., PAD,..., PAD]

Thanks for your clear explanation. I'm new in neural machine translation. I wonder whether it is a convention to encode the tgt_seq as  [BOS, word1, ..., PAD,..., PAD, EOS]. I think  [BOS, word1, ..., EOS, PAD,..., PAD] is also OK.

should be [BOS, word1, ..., EOS, PAD,..., PAD]. tgt_seq = tgt_seq[:, :-1] is incorrect.

I am still confused about     tgt_seq, tgt_pos = tgt_seq[:, :-1], tgt_pos[:, :-1]，   the tgt_seq is like [BOS, word1, ..., PAD,..., PAD]，why i should delete the last word PAD，what‘s the meaning of it？

Because only the first len(tgt_seq) - 1 words are significant. The decoder takes [BOS, word1_gt, word2_gt, ...] as input and output [word1_pred, word2_pred, ...]. In other words, the maximum length of the decoder's output should be len(tgt_seq) - 1.
Besides, I made an experiment about two tgt_seq encodings. In the first model, the tgt_seq is like [BOS, word1, ..., EOS, PAD,...,PAD]; In the second model, the tgt_seq is like [BOS, word1, word2,..., PAD, ...PAD,EOS]. The second model is worse than the first one.

As decoder input, we won't decode at the  position, since we've finished generating as soon as we generate , So, decoding lengths are actual lengths - 1, so tgt_seq, tgt_pos = tgt_seq[:, :-1], tgt_pos[:, :-1]. The last word of decoder input should be , not .


feat: Added typescript support

Added typescript support to the GraphQL Mesh NX plugin

Codecov Report

Merging #1 (5366edf) into main (c7faedf) will decrease coverage by 11.91%.
The diff coverage is 70.96%.

:exclamation: Current head 5366edf differs from pull request most recent head b1dcddf. Consider uploading reports for the commit b1dcddf to get more accurate results

@@             Coverage Diff             @@
##             main       #1       +/-   ##
===========================================
- Coverage   91.54%   79.62%   -11.92%
===========================================
  Files           3        3
  Lines          71      108       +37
  Branches       13       24       +11
===========================================
+ Hits           65       86       +21
- Misses          4       14       +10
- Partials        2        8        +6

Impacted Files
Coverage Δ

...phql-mesh/src/generators/graphql-mesh/generator.ts
81.81% <50.00%> (-4.85%)
:arrow_down:

...kages/graphql-mesh/src/executors/build/executor.ts
75.75% <72.41%> (-18.00%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c7faedf...b1dcddf. Read the comment docs.


Close Method will crash if client hide the component because of value selection

HI,
I use the autocomplete component to select a value from a list. After the selection i hide the autocomplete component. In this case a "cannot call blur() of null" will rise in the close method because the input field isn't present anymore.
So I moved the component updates in front of the firing of "change" notification.
Kristian

Thanks for this useful change 👍


[HU] Migrate errors

To be merged after https://github.com/home-assistant/intents/pull/1906

@v1k70rk4 👀👀👀 https://github.com/home-assistant/intents/pull/1906#issuecomment-1921932383

I saw :) lovely

All the no_device changed (back) into no_entity
well, I almost went to eat :D but fixed.

@jlpouffier These have also changed:
DUPLICATE_ENTITIES = "duplicate_entities"
"""More than one entity matched with the same name."""
DUPLICATE_ENTITIES_IN_AREA = "duplicate_entities_in_area"
"""More than one entity in an area matched with the same name."""


UPM Refactoring

This PR includes a refactoring for UPM specifications, placing the Package into a the Packages Folder.
Notable changes:

README.html removed, README.md added
CHANGELOG.md added
Documentation~/com.dbrizov.naughtyattributes.md added
.samples.json added

This PR follows up on the changes introduced in #203, since the changelog is relatively hefty. I'm going to follow up all other PRs  from this version.
Package Validator:

I like my folder structure, and won't be mergin this


<EMAIL_ADDRESS>LGPL-2.1-only curation

The license file shows that it's LGPL (and there are other curations that effect).

I'm going to update this PR to use the existing Paramiko curation file.


Remove the Stage trait

Remove the Stage trait to simplify internals, and make further work on #1375 and adjacent tasks easier. Startup schedules, which were the only place where the api was used have been moved to a separate field in App.

Given that this "reels in" useful functionality in preparation for a new design, I think I'd want an actual plan for what that design is prior to merging this. Otherwise how do we know whether or not these changes are enabling the right things?
I'm also not convinced that these changes make future changes much easier. Anything that changes how stages work will need to touch the majority of these lines again.

The next step moving forward would most likely be to relocate run criteria storage and eventually evaluation into Schedule, resolving issues around not being able to use a state from multiple stages, and having hard sync points within blocks controlled by run criteria. @Ratysz might have further insight here.
I'm pretty confident having a locked-in stage topology will make moving run criteria to a central location easier, which is why I'm doing this PR first. We could postpone until more work is done, but that might lead to a rather bloated PR that's tricky to review.

I think existence of trait Stage is largely incosequential for all changes up to the one that deprecates stages as a concept. We'll have to contend with them one way or another up until we remove them entirely, trait or not.

Closed in favor of waiting for bigger changes with #2801


[dependably] update Misk monthly

Updating Misk daily is a useless chore. This adjusts it to be monthly instead.

@dependabot info


Test durations are inaccurate in for certain concurrent tests

Do you want to request a feature or report a bug?
bug
What is the current behavior?
test.concurrent does not produce correct test durations. See MVP in
https://repl.it/@kachkaev/concurrent-test-durations-in-jest
What is the expected behavior?
  works concurrently - 0.1 seconds per test
    ✓ concurrent #0 (100ms) <-- ok
    ✓ concurrent #1 (100ms) <-- currently incorrect (≈0-2ms)
    ✓ concurrent #2 (100ms) <-- currently incorrect (≈0-2ms)
    ✓ concurrent #3 (100ms) <-- currently incorrect (≈0-2ms)
    ✓ concurrent #4 (100ms) <-- currently incorrect (≈0-2ms)
  sequential tests - 0.2 seconds per test
    ✓ sequential #0 (200ms) <-- ok
    ✓ sequential #1 (200ms) <-- ok
    ✓ sequential #2 (200ms) <-- ok
    ✓ sequential #3 (200ms) <-- ok
    ✓ sequential #4 (200ms) <-- ok
  concurrent tests - 2 seconds per test
    ✓ concurrent again #0 (2000ms) <-- currently incorrect (≈1000ms), see footnote
    ✓ concurrent again #1 (2000ms) <-- currently incorrect (≈0-2ms)
    ✓ concurrent again #2 (2000ms) <-- currently incorrect (≈0-2ms)
    ✓ concurrent again #3 (2000ms) <-- currently incorrect (≈0-2ms)
    ✓ concurrent again #4 (2000ms) <-- currently incorrect (≈0-2ms)

---
1000ms = expected 2000ms - time to run previous sequential tests (5 * 100ms = 1000ms)

Looks like the a variable that stores start time is being reused by other tests and this causes incorrect durations.

test.concurrent is still somewhat experimental (the reason it's not documented), but a PR fixing it would be appreciated 🙂

It seems this is now working correctly, based on running the repl.it.

Seemingly most of the test events emitted by jest-circus are wrong for concurrent tests, as internally even though the original test is run concurrently, all events are fired and timing generated as if the tests run sequentially. Ref: https://github.com/facebook/jest/blob/master/packages/jest-circus/src/legacy-code-todo-rewrite/jestAdapterInit.ts#L89
Looks like the implementation of concurrency at least for the moment looks hackish, unfortunately. I guess it would require a bigger refactor within jest-circus to support concurrency properly, though I am not sure as my knowledge about the codebase is very slim. Will have a look at this over the next days


Special characters in password causing login failure

Describe the bug
When there are special characters in password in connection string, It fails with login failed. We do use many special characters in password, not sure which exact character is causing failures
To Reproduce
Try using password like @-(^-d:ec1/$P;~L=,#''e:L;8Nd*{)o2Xcj=~R);U-[5c/7z in connection string
Expected behavior
Login should pass because password is correct
Further technical details
SQL Server version: SQL Server 2017
Operating system: RHEL

Yeah i have noticed the same problem. It seems to be caused by the function: splitConnectionStringURL which uses the url.Parse() from net/url to parse the dsn. url.Parse() expects that the browser to correctly escape characters.
The workaround (that is working for me), is to url-encode the password like: 1234#!456 is encoded to: 123%23%21456
Now the DB connection is created with the correct password:  1234#!456


Added ReadYamlSequence and other puzzles

PR for #64
Added ReadYamlSequence, did some refactorings and added some puzzles

Coverage decreased (-0.7%) to 79.673% when pulling 78d65cd72f0f1ca536db1b28aa02f398e1904f75 on 64 into 46fa488fef3b2e6e8efa061123de85a07ddfb307 on master.

Coverage decreased (-0.7%) to 79.673% when pulling 72a51d9846a714eb7e04f355000472306f33085b on 64 into 46fa488fef3b2e6e8efa061123de85a07ddfb307 on master.

@rultor please merge

@rultor please merge

@amihaiemil OK, I'll try to merge now. You can check the progress of the merge here

@rultor please merge

@amihaiemil Done! FYI, the full log is here (took me 1min)


Fix issues related to enabling repositories

This pull request fixes two issues:

In CentOS 8.3, the HighAvailability repository got renamed to ha. I updated the role to reflect that.
Tasks for enabling repositories have been extracted to separate files. This way, tasks for new platform/version can be added in the same way as variable files.

@tomjelinek I fixed the tox test issues - please rebase and repush your PR

[citest bad]

fedora 32 fails - is this a known problem?

There seem to be dependency issues related to fence-agents packages. Those packages are out of my scope. I asked fence-agents maintainer to take a look at it and let us know what may be the problem.


@conda-forge-admin, please add bot automerge

Hi! This is the friendly automated conda-forge-webservice.
I just wanted to let you know that I added bot automerge in conda-forge/libiio-feedstock#5.


WIP Refactor/typescript

This PR is for refactoring the project to use TypeScript. Additional scripts, tools, and dependencies were added to support this change.
This PR is still in progress.

Codecov Report

Merging #63 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master    #63   +/-   ##
=====================================
  Coverage     100%   100%
=====================================
  Files          20     19    -1
  Lines         184    208   +24
  Branches       24     29    +5
=====================================
+ Hits          184    208   +24

Impacted Files
Coverage Δ

src/cli/__fixtures__/invalid-config-order.js
100% <ø> (ø)

src/cli/__fixtures__/invalid-config.js
100% <ø> (ø)

src/cli/__fixtures__/valid-config-order.js
100% <ø> (ø)

src/index.ts
100% <100%> (ø)

src/defaults/index.ts
100% <100%> (ø)

src/utils/object.ts
100% <100%> (ø)

scripts/snapshot-serializers-ansi.ts
100% <100%> (ø)

src/defaults/transformations.ts
100% <100%> (ø)

src/cli/config-schema.ts
100% <100%> (ø)

src/cli/error.ts
100% <100%> (ø)

... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e86f1c6...997b02a. Read the comment docs.

Closing in favor of #64


Fix build with current nightly

https://travis-ci.org/github/srijs/deps.rs/builds/679829855 shows this working, but the Travis integration appears to be broken

Hi there, thank you for your PR!
The project is now in the process of becoming maintained again. Parts of #44 solved the issue you addressed with your Pull Request, so I will close this. Thank you nonetheless for your input! If you want, we'll be happy to welcome you as contributor to the project. Just give us a heads up at #40!

The project is now in the process of becoming maintained again. Parts of #44 solved the issue you addressed with your Pull Request, so I will close this. Thank you nonetheless for your input! If you want, we'll be happy to welcome you as contributor to the project. Just give us a heads up at #40!

I won't have time to contribute overall, but thanks. I've just submitted a new PR updating various links to the new org https://github.com/deps-rs/deps.rs/pull/47


[Inspector] "Hey there!" message :)

https://github.com/BabylonJS/Babylon.js/blob/57c1a3019bc2b2f645a5f16025541bea1c13fcbc/inspector/src/Inspector.ts#L379
I think it's not a big deal, but this Coucou! stay visible once popup is opened :-D

My bad, it was a test when I tried to fix Edge version. I thought I rejected this change.
Will fix it asap !!!

Coucou!

PR done.
Will be fixed with the next nightly build :)

At least it wasn't the classic "Toto" :)


fix(carousel): pagination carousel - accessibility improvements

Related carousel: Carousel with Pagination
In this PR are fixes related to the feedback which we got from Rekha when I tried fix application mode for the carousel with pagination.

Issue: Index numbers (1 of 4) are read twice as you down arrow through the carousel item.
Fix: add  aria-hidden="true" on the text

2.1 Issue: The first and the last item in the carousel are not read when the prev/next button is pressed in browse mode.
2.2 https://github.com/microsoft/fluent-ui-react/issues/2224
Fix: moving focusing the next/previous paddle to generic function, which is call always, even when "onclick" is executed...

Issue: Should there be focus on the entire carousel control and the left/right buttons?  Seems redundant and adds more keyboard stops
Fix: change the behavior that for carousel without the "tab" navigation there will be tabindex=-1 on CarouselItem

Issue: Carousel itself should have a label property defined.  The roledescription is set to “Carousel” so label can be “Portrait collection” for this example
Fix: added prop aria-label to be able label the carousel

Issue:  https://github.com/microsoft/fluent-ui-react/issues/2225
Fix: was decided that if reader will narrate "carousel" user will know how to use keyboard to rotate through the carousel
For this reason to narrate "carousel" in application mode was added additional props(role, aria-label,aria-roledescription) into "itemsContainer" in "carouselBehavior.ts".
Now there is role "group". After more testing could be change for "region". For me region was not narrating "carousel" in focus mode for NVDA.

Issue:  Programmatically Prev/Next buttons are outside carousel container so it will likely confuse the user.  Carousel container element should include all elements within carousel.
Fix: apply region only for "Carousel with Pagination", provide there proper label and roledescription.  Fix is in "carouselBehavior.ts" for "root" slot.

Added a few comments @kolaps33


fix(view): fix the variable name in src/view/02_dynamic_attributes.md

Hi! I just started reading this book, and I think the variable name in this code snippet is wrong. The let statement uses x and set_x as variable names, but inside the view micro, x, and set_count are used.
This PR changed x to count and set_x to set_count to keep the consistency with previous code snippets.

Fair, thanks!


add amitshukla, moxiegirl and nishanttotla to the MAINTAINERS file

Add @amitshukla as curator as he's currently helping us triaging issues
Add @moxiegirl as docs maintainer she should have me there already!
Add @nishanttotla as maintainer
ping @docker/swarm-maintainers
ping @thaJeztah
:tada: :balloon:

LGTM. :tada: :tada:

Yay thanks @vieux 😄😄😄
LGTM.

LGTM :tada: :tada:

LGTM

LGTM
Congrats !!

Yay! LGTM

LGTM :+1:

LGTM

LGTM

Awesome, welcome!


Error install and use demos in Ubuntu..

Hi, i'm donwload files on this repo and install components whit composer but at to use i'm have this error...
[Mon Nov 14 12:34:43.990354 2016] [:error] [pid 2855] [client <IP_ADDRESS>:51173] PHP Fatal error:  Namespace declaration statement has to be the very first statement in the script in /var/www/html/mail/php-sparkpost-master/examples/message-events/get_message_events.php on line 3
i'm not apply change's in code.
Please help us
Thanks

Hi @dxnydlc can you try to install the library using composer instead of downloading and let us know if you have the same issue?

Hi @dxnydlc I'm going to go ahead and close this out. Feel free to re-open if you continue to experience issues.

Danke!
Dany De la Cruz.
2016-12-02 9:20 GMT-05:00 Richard Leland<EMAIL_ADDRESS>
Hi @dxnydlc https://github.com/dxnydlc I'm going to go ahead and close
this out. Feel free to re-open if you continue to experience issues.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/SparkPost/php-sparkpost/issues/157#issuecomment-264464115,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ADHkaXYsXW58IZsdxxu6YRtjoMSjZ_6Yks5rECk-gaJpZM4KxmLS
.


hard code in eval.py

hi folks,
kindly ask why there are some hard codes in line: 180 ~ 194 here ?
https://github.com/OSU-NLP-Group/TravelPlanner/blob/main/evaluation/eval.py#L180
is there any specific consideration ?
can I change it to this below, on my local, which also applies for train set_type ?
    query_data_list_  = load_dataset('osunlp/TravelPlanner',set_type)[set_type]
    query_data_list = [x for x in query_data_list_][:len(tested_plans)]

    result['Delivery Rate'] = delivery_cnt / query_data_list.num_rows
    result['Commonsense Constraint Micro Pass Rate'] = constraint_dis_record['commonsense']['pass'] / constraint_dis_record['commonsense']['total']
    result['Commonsense Constraint Macro Pass Rate'] = final_commonsense_cnt / query_data_list.num_rows
    result['Hard Constraint Micro Pass Rate'] = constraint_dis_record['hard']['pass'] / constraint_dis_record['hard']['total']
    result['Hard Constraint Macro Pass Rate'] = final_hardConstraint_cnt / query_data_list.num_rows
    result['Final Pass Rate'] = final_all_cnt / query_data_list.num_rows

thanks a lot.

Hi,
If I remember correctly, they were introduced to address inaccuracies caused by failed deliveries during evaluation.
Apologies for the oversight on training set evaluation support; we're working to add this feature ASAP. In the meantime, you can use these temporary hard-coded values for training set: 45, 360, 45, 105, 45, 45.

@hsaest
thanks a lot.
added the block on my side:
    elif set_type == 'train':
        result['Delivery Rate'] = delivery_cnt / 45
        result['Commonsense Constraint Micro Pass Rate'] = constraint_dis_record['commonsense']['pass'] / 360
        result['Commonsense Constraint Macro Pass Rate'] = final_commonsense_cnt / 45
        result['Hard Constraint Micro Pass Rate'] = constraint_dis_record['hard']['pass'] / 105
        result['Hard Constraint Macro Pass Rate'] = final_hardConstraint_cnt / 45
        result['Final Pass Rate'] = final_all_cnt / 45


How can i make it so an image flashes on the screen when i miss a note?

Describe your problem here.
As the title says. I want to make it so a vignette surrounds the screen when you miss a note so appreciateit looks like you're taking damage. However, I don't know how I would code that, but I would apprciate it if someone could walk me through it.
Are you modding a build from source or with Lua?
Lua
What is your build target?
Windows x64
Did you edit anything in this build? If so, mention or summarize your changes.
No response

Image Must Be 1280x720px
Image Must Be In Your Mods Image Folder
LUA Code Must Be In Your Song's Chart Folder (Data > Your Song)
`function ImageFlash()
cancelTween('Flash')
makeLuaSprite('thecoolsprite', 'yourcustompnglol', 0, 0)
setObjectCamera('thecoolsprite', 'other')
addLuaSprite('thecoolsprite', true)
doTweenAlpha('Flash', 'thecoolsprite', 0, 0.5)
end
function noteMiss()
ImageFlash()
end
function noteMissPress()
ImageFlash()
end`


Connect-PnPOnline : Exception has been thrown by the target of an invocation.

Category

[ ] Question
[X ] Bug
[ ] Enhancement
I was able to work with Connect-PnPOnline -url https://tenant.sharepoint.com/ -Credentials $crds until this morning, and PnP version was 3.13.1909.0. But when started seeing the above error, tried to updated to latest version, 3.18. 2002.0, still same error.

Expected or Desired Behavior
It should connect to the tenant without error.
Observed Behavior
P.S - Replaced the tenant name.
Connect-PnPOnline : Exception has been thrown by the target of an invocation.
At line:1 char:1

Connect-PnPOnline -url https://tenant.sharepoint.com

    + CategoryInfo          : NotSpecified: (:) [Connect-PnPOnline], TargetInvocationException
    + FullyQualifiedErrorId : System.Reflection.TargetInvocationException,SharePointPnP.PowerShell.Commands.Base.Conne
   ctOnline

#### Steps to Reproduce

Open PowerShell Window and type in the below command
Connect-PnPOnline -url https://tenant.sharepoint.com

#### Submission

Thanks for your contribution! Sharing is caring.

Thank you for the comment. However, this question isn't specific to the Starter Kit. The best place for this issue would be in the PnP PowerShell Repository.


Change learning rate var name and type

$theta param in Phpml\NeuralNetwork is used as a learning rate constant. For what I know in machine learning theta are usually the parameters we are estimating.
I've also changed its type to float as this var values are usually lower than 1.

Thanks.


Technical requirements for cyberCon0

Good case is probably 0x

https://github.com/cyberacademia/cyberevents/commit/94a1eb7624af1604a983c44d38ddcf27afaef1d4


[Bug] [CDC-SqlServer] Not support SqlServer type 'datetimeoffset'

Search before asking

[X] I had searched in the issues and found no similar issues.

What happened
CREATE DATABASE column_type_test;
USE column_type_test;
EXEC sys.sp_cdc_enable_db;

CREATE TABLE full_types (
    val_datetimeoffset datetimeoffset(4),
);

Not support SqlServer type datetimeoffset .

Related issues:

Not support SqlServer type timestamp: #5449
Not support SqlServer type varbinary: #5544

SeaTunnel Version
dev
SeaTunnel Config
env {
  # You can set engine configuration here
  execution.parallelism = 1
  job.mode = "STREAMING"
  execution.checkpoint.interval = 5000
}

source {
  SqlServer-CDC {
    result_table_name = "tbl"
    username = "****"
    password = "*******"
    database-names = ["column_type_test"]
    table-names = ["column_type_test.dbo.full_types"]
    base-url = "jdbc:sqlserver://localhost:1433;databaseName=column_type_test"
  }
}

transform {
}

sink {
  console {
    source_table_name = "tbl"
  }
}

Running Command
example

Error Exception
2023-09-09 13:49:27,298 INFO  com.hazelcast.core.LifecycleService - [localhost]:5801 [seatunnel-473233] [5.1] [localhost]:5801 is SHUTDOWN
2023-09-09 13:49:27,298 INFO  org.apache.seatunnel.core.starter.seatunnel.command.ClientExecuteCommand - Closed HazelcastInstance ......
2023-09-09 13:49:27,298 ERROR org.apache.seatunnel.core.starter.SeaTunnel -

===============================================================================

2023-09-09 13:49:27,298 ERROR org.apache.seatunnel.core.starter.SeaTunnel - Fatal Error,

2023-09-09 13:49:27,298 ERROR org.apache.seatunnel.core.starter.SeaTunnel - Please submit bug report in https://github.com/apache/seatunnel/issues

2023-09-09 13:49:27,298 ERROR org.apache.seatunnel.core.starter.SeaTunnel - Reason:SeaTunnel job executed failed

2023-09-09 13:49:27,301 ERROR org.apache.seatunnel.core.starter.SeaTunnel - Exception StackTrace:org.apache.seatunnel.core.starter.exception.CommandExecuteException: SeaTunnel job executed failed
	at org.apache.seatunnel.core.starter.seatunnel.command.ClientExecuteCommand.execute(ClientExecuteCommand.java:190)
	at org.apache.seatunnel.core.starter.SeaTunnel.run(SeaTunnel.java:40)
	at org.apache.seatunnel.example.engine.SeaTunnelEngineExample.main(SeaTunnelEngineExample.java:43)
Caused by: java.lang.UnsupportedOperationException: Don't support SqlSever type 'datetimeoffset' yet, jdbcType:'-155'.
	at org.apache.seatunnel.connectors.seatunnel.cdc.sqlserver.source.utils.SqlServerTypeUtils.convertFromColumn(SqlServerTypeUtils.java:74)
	at java.base/java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:195)
	at java.base/java.util.ArrayList$ArrayListSpliterator.forEachRemaining(ArrayList.java:1655)
	at java.base/java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:484)
	at java.base/java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:474)
	at java.base/java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:550)
	at java.base/java.util.stream.AbstractPipeline.evaluateToArrayNode(AbstractPipeline.java:260)
	at java.base/java.util.stream.ReferencePipeline.toArray(ReferencePipeline.java:517)
	at org.apache.seatunnel.connectors.seatunnel.cdc.sqlserver.source.utils.SqlServerTypeUtils.convertFromTable(SqlServerTypeUtils.java:88)
	at org.apache.seatunnel.connectors.seatunnel.cdc.sqlserver.source.source.SqlServerIncrementalSource.createDebeziumDeserializationSchema(SqlServerIncrementalSource.java:125)
	at org.apache.seatunnel.connectors.cdc.base.source.IncrementalSource.prepare(IncrementalSource.java:119)
	at org.apache.seatunnel.engine.core.parse.JobConfigParser.parseSource(JobConfigParser.java:85)
	at org.apache.seatunnel.engine.core.parse.MultipleTableJobConfigParser.parseSource(MultipleTableJobConfigParser.java:317)
	at org.apache.seatunnel.engine.core.parse.MultipleTableJobConfigParser.parse(MultipleTableJobConfigParser.java:179)
	at org.apache.seatunnel.engine.core.job.AbstractJobEnvironment.getLogicalDag(AbstractJobEnvironment.java:109)
	at org.apache.seatunnel.engine.client.job.JobExecutionEnvironment.execute(JobExecutionEnvironment.java:73)
	at org.apache.seatunnel.core.starter.seatunnel.command.ClientExecuteCommand.execute(ClientExecuteCommand.java:142)
	... 2 more

Zeta or Flink or Spark Version
zeta
Java or Scala Version
No response
Screenshots
No response
Are you willing to submit PR?

[ ] Yes I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

Yes, It's a bug.

If patch has not been repaired, would you be willing to assign the problem to me? I'm not sure anyone is fixing it right now
@EricJoy2048 @hailin0 @CheneyYin @Carl-Zhou-CN

If patch has not been repaired, would you be willing to assign the problem to me? I'm not sure anyone is fixing it right now
@EricJoy2048 @hailin0 @CheneyYin @Carl-Zhou-CN

I am not fixing.

If patch has not been repaired, would you be willing to assign the problem to me? I'm not sure anyone is fixing it right now
@EricJoy2048 @hailin0 @CheneyYin @Carl-Zhou-CN

I am not fixing.
Seconds reply Nice


Fix issue with carried over applications not being able to add jobs

Context
Currently, if a candidate with work experience carries over their application, they're unable to add another job due to this bit of code.

The button only appears if they've indicated they can provide work history.
This is currently affecting 128 candidates (although just 1 zendesk ticket)

Changes proposed in this pull request

Set the work_history_status enum to can_complete if they have provided a work history
Backfill the work_history_status enum for carried over applications

Guidance to review
We should probably have a look at this flow again at some point because the logic seems a bit janky. But we don't really have time atm.
Things to check

[x] This code does not rely on migrations in the same Pull Request
[x] If this code includes a migration adding or changing columns, it also backfills existing records for consistency
[x] API release notes have been updated if necessary
[x] Required environment variables have been updated added to the Azure KeyVault

sorry I missed this, thanks @davidgisbey ⭐ !


Use more appropriate asserts

Always use XCTAssertEqualObjects when comparing objects for equality. XCTAssertEqual was causing some issues with NSIndexPath equality on 32 bit architectures (possibly because 64-bit architectures pool instances that are equal?)

Current coverage is 93.43% (diff: 100%)

Merging #259 into master will increase coverage by 0.07%

@@             master       #259   diff @@
==========================================
  Files            72         72
  Lines          5015       5015
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
+ Hits           4682       4686     +4
+ Misses          333        329     -4
  Partials          0          0

Powered by Codecov. Last update b9852cb...bb26062

@spotify/objc-dev

@JohnSundell : I would assume that by default we'd want to be checking object equality in tests, unless we have a requirement that something returns the same instance under certain conditions. Only then would we want to test the actual instances.
The NSIndexPath case is a good example - on some platforms (for some reason) calls to factory methods will return different instances, and on other platforms they return the same instance (I haven't verified this, but it's one explanation for what's happening). Ultimately though, it shouldn't matter, as long as we use object equality, not instance equality as isEqualTo: will take care of all the differences for us.
Only fixing the cases with NSIndexPath because we know there are problems with that right now seems a bit broken, as the same issue could arise with other classes in future OS releases (as an example).

@cerihughes NSIndexPaths of two elements are tagged pointers on 64-bit systems. Same sort of fun happens with short strings.

@cerihughes I’m in favor of the changes made in this PR. Unless we explicitly want to check that two objects are the same instance we should use XCTAssertEqualObjects(obj1, obj2, desc, …).
Further I think we should, like you’re doing here, use XCTAssertTrue() with a description (or comment) when we actually want to check for instance equality. I’d also be fine with adding a function or macro like HUBAssertEqualInstances(ins1, ins2, desc, …) to make the code more self-explanatory.


Incorrect packaging Grading terminated.

Anyone received a compilation error of
"Incorrect packaging
Grading terminated."
on codecrunch for the project?
My code runs on my device but the Codecrunch tests gives me that error. How do I avoid that?

Did you try compiling the code on your device with javac -d . *.java as well as ensuring that all files except Main1-5.java has package cs2030.simulator at the top?

I also had the same issue for days. Look at #156. Each file should use LF instead of CRLF. Also don't submit Main.java

Thanks all! The above suggestions worked :)


Add a button that would bring up the emoji row

Currently, emoji row always stays on top of the message input bar. Add an emoji icon (button) next to the image picker that would bring up the emoji row instead of always having it on the top.
Messaging page route: /chat/<link>
Ref component file:
https://github.com/muke1908/chat-e2ee/blob/544f2c6fde6c2d50f3c4ad6c7e1ea3862a80d6ab/client/src/components/Messaging/NewMessageForm.js#L30

Can I work on this?

@Heisenberg399  sure!

hey , i am just starting with open source contributions and would love to work on this issue , is this issue still open ?

@salonigoyal2309 sure!
Most likely @Heisenberg399 is not working on it.

hi @Heisenberg399 ! can you confirm the above?

Yes @salonigoyal2309  you can go ahead...I am busy with my exams.

@all-contribtors please add @salonigoyal2309 for code

@all-contributors please add @salonigoyal2309 for code


questions about terms for IEDB

Hi, I work on the Immune Epitope Database (www.iedb.org) and we are working with the Human disease ontology (DO) to create formal logical definitions for food allergic diseases. In this process, we are using several PO terms, but a few terms that we need are missing or are causing us trouble. I want to ask if the needed terms and or edits are within your scope before making formal term requests. We understand that correct plant biology may not align with the commonly used medical terms, but maybe you can suggest ways for us to deal with this or another ontology that may be better suited to our needs?

fruit	PO_0009001: for this term, nut and grain are synonyms. We want to logically define fruit, nut and grain allergies as separate diseases based upon the allergy being to a different PO term. Is it possible to split the term or make more specific child terms?
vegetable: this term does not exist in PO, but we want to logically define vegetable allergy as a disease. Is this term something that PO could add?
legume: this term does not exist in PO, but we want to logically define a legume allergy. Is this term something that PO could add?
cereal and pseudocereal: these are terms used to group foods allergens, but I am not sure if they have any basis in botany? Do you think they are reasonable terms or should we try different terms?
thanks very much. we appreciate your ontology!
-Randi

I think you want some kind of intermediate product or food ontology, that can in turn be linked to PO (or CHEBI, or ENVO, ...). cc @pbuttigieg

Interesting timing - I'm about to enter a call about creating a food ontology which seems more appropriate for your requests, @rvita. ENVO does indeed have several food terms, but a fully fledged food ontology would be a better intermediary between needs like yours and anatomy or other such ontologies.
If there's urgency, we can certainly add the classes and definitions you need to ENVO (we do, after all, have zebra milk in there) and then surrender them to a food ontology when it emerges.

Hi thanks, looking at ENVO, it already has quite a few of the terms we need. So we would be happy if you could add 'vegetable food product' 'nut food product' and 'legume food product' for now and we can later move to the food ontology. Because of the food allergic diseases, we have been looking into several classifications of food and would be interested in sharing what we are using when the time comes. We will want to know when to switch from ENVO to the new ontology. If the foods will have roles, being allergenic may be a useful one to have. Should I switch to the ENVO term tracker?
-Randi

Because of the food allergic diseases, we have been looking into several classifications of food and would be interested in sharing what we are using when the time comes.

This overlaps with our current (nascent) efforts. It would be good to syncronise!

If the foods will have roles, being allergenic may be a useful one to have.

Yes, absolutely.

Should I switch to the ENVO term tracker?

Probably best, I've created an issue here: https://github.com/EnvironmentOntology/envo/issues/284

Hi Randi,
Thanks for your interest in the Plant Ontology.  I have been following this discussion with interest, especially about the development of a food ontology.
Here are comments on your questions:

fruit PO_0009001: for this term, nut and grain are synonyms. We want to logically define fruit, nut and grain allergies as separate diseases based upon the allergy being to a different PO term. Is it possible to split the term or make more specific child terms?

This is something we have discussed and it is a possibility- I also think it would be useful.  I suggest you open a separate issue on this tracker.

vegetable: this term does not exist in PO, but we want to logically define vegetable allergy as a disease. Is this term something that PO could add?

This is a bit problematic for the PO, as it is more of a grouping term than an actual plant structure. So I think it would better in the food ontology.  It is generally defined as any edible part of a plant, that is not involved in reproduction.

legume: this term does not exist in PO, but we want to logically define a legume allergy. Is this term something that PO could add?
This is a taxonomic classification- we would reference it using the NCBI Taxonomy ID: 3803.

cereal and pseudocereal: these are terms used to group foods allergens, but I am not sure if they have any basis in botany? Do you think they are reasonable terms or should we try different terms?
thanks very much. we appreciate your ontology!

In the PO we would call a cereal grain a "caryopsis" while the pseudocereals are actually seeds so they are botanically distinct.
I hope this was helpful!
Laurel


Is @1.8.4 the latest non-hooks build available?  And, what are we missing out on?  Phonegap Build

PhoneGap Build works really well for building, but does not support hooks, and I assume they never will because they say hooks are unsupported due to security reasons.  So, those of us using phonegap build are stuck with 1.8.4.  Is there any newer build that 1.8.4 without hooks that is still being maintained?  Also, what important features are we missing out on by still using 1.8.4?  I've read there have been ios 10 improvements in 1.9.x but I'm not sure if they are critical.

@uj 1.9.x stream does not need any hooks for iOS or Android. I strongly suggest using the 1.9.x stream for apps supporting iOS 10.
The 2.0.x stream currently needs hooks be we're working on it.


Date methods missing support for negative arguments

Methods of the Date object such as setDate officially allow negative arguments, but this isn't currently supported by web-sys.

Is this still available? If so I would like to take a stab at it. Initially my thinking is this is just a type update for the affected methods which should be straightforward but a breaking change.


The manifest.json

After playing around a bit more with #56 this is a working manifest.json file for the plugin manager with working support for:

x86_64-linux
x86_64-darwin (aka macos)
aarch64-darwin (aka macos sillicon)
x86_64-windows
x86-windows

Tested and so far working nicely:

Got the github workflow working for building ltreesitter and all supported parsers using the meson stuff, was a pain to initially create the manifest.json but that is the price to pay for cross distribution of binaries I guess.

not sure why you're building the parsers on your fork when I already have a builds repo specifically for that, but good work! if you want to pr the manifest I'd merge


Move Traversing utils to detekt-rules-documentation

These are only used in a couple of rules. Checking visibility should also be done on a descriptor rather than the declaration, but I didn't make that change as these rules currently don't use type resolution.

Warnings

:warning:
It looks like this PR contains functional changes without a corresponding test.

  Generated by :no_entry_sign: dangerJS against c9f62d82cdd526fe3bda7ed7d48a39014335acde


CLI command to set config options

As discussed in https://github.com/djmitche/taskchampion/discussions/152
It would help with writing good user-guides to have a CLI which can set config options, maybe something like
task config set sync-server-origin http://example.com

or maybe more locally specific
task sync set-url http://example.com

or something along those lines.
Justification being that "run this command to set the server" is a lot friendly than "edit the config at [platform dependent location], then in this section, add the line [...etc]"
Git is a good reference for this - e.g the commands for setting name/email are presented in error messages from git itself, remote URL's are presented by hosting services like Github.

This seems quite common.  I think we'd need to pick another config language, though -- I don't think the YAML parser preserves enough state (comments, whitespace) to "edit" a file without losing the user's formatting.  I think TOML can do this?  At least, cargo add edited my Cargo.toml without losing comments..  And TOML seems to be getting more popular as a config format.

I'm in favour of using something which isn't YAML (popular but giant spec leading to things like this website to help people with how to format a multi-line string, among many other issues)
TOML would be my vote, although for how widely use it is I found the main toml crate surprisingly under-developed - I don't think it currently supports preserving comments, and I've run in to other things like it being sensitive to the order fields are defined. cargo-edit seems to use this toml_edit crate instead
I have also looked into ron which seems interesting, as is hcl - although the former is fairly Rust-only, and the latter hasn't really caught on (and now I think about it, I'm not sure I found a Rust implementation of it.. so.. probably not too useful a suggestion!). There is also https://github.com/google/json5format which is JSON with support for preserving comments and some other changes, but seems quite early stages
Possibly toml_edit with the hope we can switch to the main toml crate someday when https://github.com/alexcrichton/toml-rs/issues/83 gets more attention?

TOML sounds like a good balance. Given how central configuration is, do you think this can be added as early as in v0.4.0?

Yes, that makes sense.


Preprocessing error: joblib.externals.loky.process_executor.BrokenProcessPool: A process in the executor was terminated abruptly, the pool is not usable anymore

When I run the preprocessing step - the job always fail at this step
(after processing 64,000 questions)
Has anybody else faced this issue?
[Parallel(n_jobs=8)]: Batch computation too slow (2.0377s.) Setting batch_size=2.
exception calling callback for <Future at 0x7f3526427e48 state=finished raised BrokenProcessPool>
Traceback (most recent call last):
  File "/root/anaconda3/envs/local_nmt/lib/python3.5/site-packages/joblib/externals/loky/_base.py", line 322, in _invoke_callbacks
    callback(self)
  File "/root/anaconda3/envs/local_nmt/lib/python3.5/site-packages/joblib/parallel.py", line 375, in __call__
    self.parallel.dispatch_next()
  File "/root/anaconda3/envs/local_nmt/lib/python3.5/site-packages/joblib/parallel.py", line 797, in dispatch_next
    if not self.dispatch_one_batch(self._original_iterator):
  File "/root/anaconda3/envs/local_nmt/lib/python3.5/site-packages/joblib/parallel.py", line 825, in dispatch_one_batch
    self._dispatch(tasks)
  File "/root/anaconda3/envs/local_nmt/lib/python3.5/site-packages/joblib/parallel.py", line 782, in _dispatch
    job = self._backend.apply_async(batch, callback=cb)
  File "/root/anaconda3/envs/local_nmt/lib/python3.5/site-packages/joblib/_parallel_backends.py", line 506, in apply_async
    future = self._workers.submit(SafeFunction(func))
  File "/root/anaconda3/envs/local_nmt/lib/python3.5/site-packages/joblib/externals/loky/reusable_executor.py", line 151, in submit
    fn, *args, **kwargs)
  File "/root/anaconda3/envs/local_nmt/lib/python3.5/site-packages/joblib/externals/loky/process_executor.py", line 990, in submit
    raise BrokenProcessPool(self._flags.broken)
joblib.externals.loky.process_executor.BrokenProcessPool: A process in the executor was terminated abruptly, the pool is not usable anymore.

Any ideas @kimiyoung?

One possibility is that you're running out of memory at a certain step. Could you try reducing the number of parallel workers (in the Parallel call) and/or monitoring your RAM usage when this happens?

Hi Peng,
you are right! When I check the top I see a sharp fall in memory available.
top - 11:40:25 up 2 days, 18:35,  4 users,  load average: 7.09, 7.56, 7.13
Tasks:  32 total,   3 running,  29 sleeping,   0 stopped,   0 zombie
%Cpu(s):  7.6 us,  2.6 sy,  0.0 ni, 89.8 id,  0.0 wa,  0.0 hi,  0.0 si,  0.0 st
KiB Mem : 33554432 total,       40 free, 33520996 used,    33396 buff/cache
KiB Swap:        0 total,        0 free,        0 used.       40 avail Mem

I tried running it with parallelism 2
outputs = Parallel(n_jobs=2, verbose=10)(delayed(_process_article)(article, config) for article in data) - but it still fails!
Surprisingly, when I run it mac - it is much slower but it does not get killed and gets through the whole preprocessing. My Mac only has 8 cores. Whereas the gpu machine looks like this
CPU(s):                80
Thread(s) per core:    2
Core(s) per socket:    20
Socket(s):             2

In that case I would probably try something larger than 2 but smaller than the original number of jobs you tried originally (that failed) -- that should probably give a good balance between speed and memory usage!
Closing for now since we have identified the issue, feel free to reopen/open a new issue if something else in preprocessing fails for you!


Clarify steps for VNet upgrade from standard to premium.

Clarify steps for VNet upgrade from standard to premium. You do not add any information, leave blank, the networking, advanced, tags sections when upgrading a Vnet workspace from standard to premium. Adding a note or clarification about upgrading default and VNet workspaces and steps will help make the documentation clearer.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: ffe20a92-15f7-ef03-3038-e30ea0c97ad5
Version Independent ID: 854ae140-2107-5b1b-8289-710b2f7a7887
Content: Manage your subscription - Azure Databricks
Content Source: databricks/administration-guide/account-settings/account.md
Service: azure-databricks
GitHub Login: @mssaperla
Microsoft Alias: saperla

@wpcarroll  -
Thanks for the feedback! We have assigned the issue to the content author to further review this and update the document as appropriate.
@mssaperla , @leifbro - Could you please review this feedback and update the doc as needed - Thank you

Thanks for your dedication to our documentation. Unfortunately, we have been unable to review your issue and apologize for the delayed response. The requested updates have not yet been made. The timeline for resolution varies based on resourcing. We've created an internal work item (DOC-7018) to incorporate your suggestions. We are closing this issue for now, but feel free to comment here as necessary.
#please-close

#please-close


Fix GRPC in JavaScript

This PR is broken, and needs code adjustments! @horacioh Need your help with that! Also, please add somewhere in the repo the information I'll be explaining here, if you think it could be useful in the future.
The problem is that the official GRPC codegen tooling for JavaScript is not very good. That's why we use ts-proto which seems like most people use anyway. And ts-proto is agnostic to the actual RPC implementation.
This PR changes some of the ts-proto code generations flags, to generate more generic types, and also uses a different wrapper library called nice-grpc which supports both GRPC and GRPC-Web protocols.
So, first of all, it's important to understand that these are two different protocols. They are actually served on different ports by our backend (GRPC-Web is on 55001, and GRPC is on 55002). So here is where the wrapper functions that we have, and the singleton client falls apart a little bit, because we'd have to use different addresses depending on the environment.
To be clean, there's no way to GRPC protocol in the browser, only GRPC-Web. And technically we could be using GRPC-Web in NodeJS, but none of the existing libraries let us do that, so we have to use GRPC.
Here's an example on how to instantiate any of the generated client instances depending on the environment
import {createChannel, createClient} from "nice-grpc" // use "nice-grpc-web" for the browser!
import {DaemonDefinition, DaemonClient} from<EMAIL_ADDRESS>
// Use the correct port depending on the environment!
// Reuse the channel for all instances of different APIs.
const ch = createChannel("http://localhost:55001")

// Due to some TypeScript magic that I'm not familiar with,
// apparently you have to specify the type on the variable.
// Otherwise you can't invoke the methods correctly.
// And all generated clientes work the same, each would have
// *Definition and *Client types defined, and are created
// in the same way by calling createClient function.
const daemon: DaemonClient = createClient(DaemonDefinition, ch)

// With this nice-grpc library there's no need to call .fromPartial anymore,
// as objects are being casted under the hood. I guess having the
// wrapper functions for each API call now makes a bit less sense.
// Ideally, I think we should have no global client instances
// laying around, and explicitly created them at the top-level
// of the app, and pass them around.
// In React I guess using context would help.
const info = await daemon.getInfo({})

// It's important to reuse the channel, and the client instances
// between calls, so creating an instance for every call is
// something that we should be avoiding.

Related: https://github.com/mintterteam/mintter/pull/1291
Closes: https://github.com/mintterteam/mintter/issues/1288

Fixed using connect-web codegen in master.


662 site apportionment unit tests for create_category_df()

Pull Request submission
I wrote some unit tests to make sure the create_category_df function in site_apportionment.py works correctly. These tests check that the function creates a DataFrame with:

Product group codes
Numerical values (like the dummy headcount and dummy_211 columns)
All other textual values, including the imp_marker column
It excludes the following columns: instance, postcode, and the percentage column (603)
It handles situations like duplicate codes and removes rows with a bad status.

Closes or fixes

Detail the ticket(s) you are closing with this PR
Closes RDRP-662

Code

[ ] Code runs The code runs on my machine and/or CDSW
[ ] Conflicts resolved There are no conflicts (I have performed a rebase if necessary)
[ ] Requirements My/our code functions according to the requirements of the ticket
[ ] Dependencies I have updated the environment yaml so it includes any new libraries I have used
[ ] Configuration file updated any high level parameters that the user may interact with have been put into the config file (and imported to the script)
[ ] Clean Code

[ ] Code is as PEP 8 compliant as I can humanly make it
[ ] Code passess flake8 linting check
[ ] Code adheres to DRY

[ ] Type hints All new functions have type hints

Documentation
Any new code includes all the following forms of documentation:

[ ] Function Documentation Docstrings within the function(s')/methods have been created

[ ] Includes Args and returns for all major functions
[ ] The docstring details data types

[ ] Updated Documentation: User and/or developer working doc has been updated

Data

[ ] All data needed to run this script is available in Dev/Test
[ ] All data is excluded from this pull request
[ ] Secrets checker pre-commit passes

Testing

[ ] Unit tests Unit tests have been created and are passing or a new ticket to create tests has been created

Peer Review Section

[ ] All requirements install from (updated) environment.yaml
[ ] Documentation has been created and is clear - check the working document
[ ] Doctrings (Google format) have been created and accurately describe the function's functionality
[ ] Unit tests pass, or if not present a new ticket to create tests has been created
[ ] Code runs The code runs on reviewer's machine and/or CDSW

Final approval (post-review)
The author has responded to my review and made changes to my satisfaction.

[ ] I recommend merging this request.

Review comments
Insert detailed comments here!
These might include, but not exclusively:

bugs that need fixing (does it work as expected? and does it work with other code
that it is likely to interact with?)
alternative methods (could it be written more efficiently or with more clarity?)
documentation improvements (does the documentation reflect how the code actually works?)
additional tests that should be implemented (do the tests effectively assure that it
works correctly?)
code style improvements (could the code be written more clearly?)
Do the changes represent a change in functionality so the version number should increase? Start a discussion if so.
As a review you can generates the same outputs from running the code

Your suggestions should be tailored to the code that you are reviewing.
Be critical and clear, but not mean. Ask questions and set actions.

Tests completed elsewhere


ci: cleanup a bit

Cleaning up a little. setup-minconda has moved. GHA has added a new feature that allows the default shell to be set.
You still have way too many quotes on things that don't need them. :P
(But you are okay to put the contents of run: in without quotes?...)

Yeah, because the rules for YAML string escapes are complicated and I got burned by one of them. (I don't remember what it was, but there are things like yes meaning true unless it's quoted.) I wanted to make sure that everything was being interpreted as I thought it was because I was having troubles.
Multiline YAML strings are a safer encoding—only a deindent closes the quote.
But thanks for updating the setup! Do you foresee any other changes or can I merge it like this?

Not all your run's are multiline, though. Generally ": " is the most common issue for an unquoted string. uses, branches, urls, etc are always safe. Totally up to you, though :)
Nope, as long as it passed (it did), it's safe to merge. If you wanted to move a little of the
conda config --add channels conda-forge
conda update -n base -c defaults conda

up into the action options:
channels: conda-forge

Then you can just conda list / conda info to get some logging information, but you shouldn't need further configuration, just install lines. Conda is set to update itself whenever it installs packages.

Applied the minor cleanup I mentioned above, seems to be fine.

Okay, thanks. I'll merge it now.


[Fix] renamed 'dns' to 'dsn'.

Sentry/Raven use term DSN

@waqasajaz thank you so much for noticing this! Just merged it, should be published in a second 🙂

:tada: This PR is included in version 1.2.2 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Add support for selfhosted habitica installations

https://habitica.com is hard wired in the code. It would be nice to be able to use this tool with self hosted habitica installations.
Places the URL is hard wired:

API_URI_BASE in api.py and
HABITICA_TASKS_PAGE in core.py
load_netrc() (core.py) should use a domain given as option or found in .netrc

That's a really great point - I wasn't aware folk were doing that! This is definitely on the TODO list.

Fixed! Thanks to @Lertsenem for most of the changes.


Canonical repository

Hej, I'm trying to understand what the relationship is between this repository located under zefchain/bcs and diem/bcs. While this one seems to be the source for the crate published to crates.io the diem one doesn't mention this fork and has a divergent history from what I can tell. Would you mind clarifying?

We're a few ex-Facebookers and original authors of BCS maintaining this crate because we need it for our projects. I didn't know about the other repository until recently.

Thanks for the clarification.


Standardized trainer: Leave cab-fitting loss on all the time?

Instead of having cab modeling/fit_cab be an option, perhaps it should just be on all the time.
Pros:

Simpler. "It just works".
You can always use bin/train/main.py to customize and not use it if you want.
Can roll it back if something else goes wrong.

Cons:

Harder to tell if the model includes a cab.
Slower training, esp on macOS that doesn't support the MRSTFT ops (though perhaps this could be worked around better than today). One quote I got was that it's a 4-5x difference.
Slightly higher ESRs, usually.

Seeking other insights about this--what other considerations are there?

This would severely impact training on macOS with Apple Silicon due to the lack of support for MRSTFT loss on the accelerator.
I'm not going to ship this until I can improve the situation there. However, once that's fixed, I'll ship this (and users who want it back can use an extension)

Gathering info on my MacBook Pro (late 2020 M1)

With cab_fit off: 17 sec/epoch
On: 22 sec/epoch (+5 secs)

In the worst case where some later-gen processor is as fast as an nVIDIA GPU (e.g. 2 secs/iter), adding 5 seconds would be about a 3x slowdown...not good.
I'm going to make a separate issue to improve the MRSTFT loss and see if we can minimize how much has to be done off-MPS.


Metadata exchange double injected causing disruption

Bug Description
When user upgrade control plane in place from 1.11 to 1.12, since 1.12 control plane injects tcp metadata exchange filter regardless of the version, 1.11 proxy will have TCP Mx filter double injected. When a double injected 1.11 talks to 1.12 proxy (which only have one tcp mx injected), the metadata will leak to the application, because metadata will be sent twice by 1.11 proxy, but only one chunk of metadata will be drained by the 1.12 peer.
Version
1.12

Additional Information
No response

cc @rolandkool

How does that happen?

If the cluster is upgraded from 1.11 to 1.12, 1.11 proxy will be injected twice: one from EnvoyFilter and one from istiod.

Thanks, understood

Curious, didn't we test upgrade when 1.12 released


[ATHENE] Create Teletan Authorization

Release Version: 0.5.3
The verification server implements an API endpoint for generating a teletan ("/tan/teletan"). The documentation specifies that this should only be possible for medical employees. We could not find the authorization mechanism in the code, did we miss something or is it not yet implemented?
We just want to make sure this will be implemented, as a teletan enables an adversary to upload forged diagnosis keys to induce false positives, defeating the purpose of the system.

Pls check the PR Feat: JWT implementation for the teleTAN request #134 will meet the requirement.
Needs only to be reviewed and merged.

The merge is planned after the final infrastructure issues are ready


VoidPaste not working on iOS Safari

Describe the bug
VoidPaste not working
To Reproduce
Steps to reproduce the behavior:

Enable VoidPaste
Try to paste image link

Expected behavior
A link wrapped with image tag appears on the field.
Desktop (please complete the following information):

Browser: iOS Safari
Version 1.3.1

Additional context
The exec function used to insert the clipboard to selection might have been deprecated and removed in Safari.

I might have had something else copied. Closing the issue.


Can't add a new node to Rancher

Hi
I have installed Rancher successfully on a Ubuntu 16.04 VirtualBox VM.
Now I like to add my first Host. I can't see any error. But the new Host don't appear in the Rancher UI.

INFO: Running Agent Registration Process, CATTLE_URL=http://<IP_ADDRESS>:8080/v1
INFO: Attempting to connect to: http://<IP_ADDRESS>:8080/v1
INFO: http://<IP_ADDRESS>:8080/v1 is accessible
INFO: Configured Host Registration URL info: CATTLE_URL=http://<IP_ADDRESS>:8080/v1 ENV_URL=http://<IP_ADDRESS>:8080/v1
INFO: Inspecting host capabilities
INFO: Boot2Docker: false
INFO: Host writable: true
INFO: Token: xxxxxxxx
INFO: Running registration
INFO: Printing Environment
INFO: ENV: CATTLE_ACCESS_KEY=05EAA3D605D7EEEFD5CD
INFO: ENV: CATTLE_HOME=/var/lib/cattle
INFO: ENV: CATTLE_REGISTRATION_ACCESS_KEY=registrationToken
INFO: ENV: CATTLE_REGISTRATION_SECRET_KEY=xxxxxxx
INFO: ENV: CATTLE_SECRET_KEY=xxxxxxx
INFO: ENV: CATTLE_URL=http://<IP_ADDRESS>:8080/v1
INFO: ENV: DETECTED_CATTLE_AGENT_IP=<IP_ADDRESS>
INFO: ENV: RANCHER_AGENT_IMAGE=rancher/agent:v1.2.11
INFO: Launched Rancher Agent: 31d0f4f4d89a3820317019d91bac87139b431575d4770a19c66d8bb26bbea335
user@rannode1:~$

16 minutes ago
api.register.create
None
Default
register: 1go1

Host Registration<IP_ADDRESS>

Useful
Info

Versions
Rancher v1.6.20 Cattle: v0.183.60 UI: v1.6.45

Access
Disabled

Orchestration
Cattle

Route
admin-tab.audit-logs

What is going wrong?

Can you share the output of docker logs 31d0f4

Strange
On both Servers:
sudo docker logs 31d0f4
[sudo] Passwort für user:
Error: No such container: 31d0f4

Can you run the command to add the host, it will end with:
INFO: Launched Rancher Agent: xxx

And then check the logs of the id that is launched (xxx in this example)?

Let us know when you can provide the info requested so we can investigate.


add v3 to go mod

Coverage remained the same at 100.0% when pulling 8c74f3f0664f31a8222ed8df3de32157f9301067 on mod into 677216dba13910293283dc589d6d5a06686deaa1 on master.


Svpi110 repo info

What does this PR do?
Adds new CR SPIAccessCheck with url to the repository, controller checks if repository is public, if user has any tokens for it and write info about repo into SPIAccessCheck status. Controller removes CR after some period of time.
TODO:

configurable delete time
tests
prepare samples

Screenshot/screencast of this PR

What issues does this PR fix or reference?

https://issues.redhat.com/browse/SVPI-110
How to test this PR?

operator image quay.io/mvala/spi-operator:svpi110-repoInfo
apiVersion: appstudio.redhat.com/v1beta1
kind: SPIAccessCheck
metadata:
  name: spiaccesscheck-sample
spec:
  repoUrl: "<github-repo-url>"

create CR ^.
Try:

public repo
private repo without existing SPIAccessToken in the namespace
private repo with existing SPIAccessToken in the namespace
operator should remove SPIAccessCheck CR after 30 minutes (default, configurable with accessCheckTtl in config.yaml)

CRs removed after timeout

@sparkoo are there plans to support access check for quay.io URLs?

yes, but not in the scope of this PR. I don't think there's even jira issue for that. Can you please create one in SVPI project if you need it?


[v2] Change Connection.Type to be a string and add ProviderType

Description
This is a cherry-pick of #154 for the v2 branch, which is based off 082613d60f1ef601de93cd0eaeb294ba3ea8e998. There's a lot of commits in main not yet ready to be released as a new version.
The difference this PR has over #154 is that it includes #138 as well, because that also touches connection type.
Documentation
Does this require changes to the WorkOS Docs? E.g. the API Reference or code snippets need updates.
[x] Yes

If yes, link a related docs PR and add a docs maintainer as a reviewer. Their approval is required.

Closing this in favor of #154. main will be made release ready so we won't need to open this v2.x branch.


api: Drop parse() function from Config

This function is not needed in rust and it is mostly a convenience for
other languages. Instead move this chunk in the appropriate bindings.

Coverage increased (+0.09%) to 82.876% when pulling f8e50b648fb4cb6b5bb95fc73c1985a8d0afb996 on kodabb:remove-parse-from-config into d884fd6693075aa384e7e0d7e69d6fe8b2440619 on xiph:master.


Join the first and second line of a C comment

Hi, I have noticed the extension does not join the first and second line of C-style comments as it does not recognize the first line starting with "/*".
Here is a fix that I have applied and am using locally.

This looks good, thank you! May you please add a test to joinLines.test.js?

Added. Can you check they work on your side? I don't have npm or the test framework on my end.
Actually I was looking at setting up continuous integration on the repo. Github suggests Deno but I'm not familiar with TS or JS testing.

Cheers, waiting for the updated extension in VS Code ;)


logo.png contains copyrighted material without license to redistribute

Hi,
if you have a look inside it:
identify -verbose logo.png
you'll see it contains
  Profiles:
    Profile-icc: 3144 bytes
      Description: sRGB IEC61966-2.1
      Manufacturer: IEC http://www.iec.ch
      Model: IEC 61966-2.1 Default RGB colour space - sRGB
      Copyright: Copyright (c) 1998 Hewlett-Packard Company

The copyrighted ICC profile has no license, hence you can't know if you're allowed to redistribute that file or not.
You can either edit the file, or just remove it.

LOL
Seriously?
Need to check if Photoshop save for web works that way...

Quoting Michal Stefanow (2017-04-20 15:43:01)

LOL
Seriously?

Yes.  We are way past April 1st.

Need to check if Photoshop save for web works that way...

I believe one of the very features of the "save for web" functionality
is to (convert to sRGB colorspace, and) strip ICC profiles.  Because the
aim is to optimize for web where sRGB is the default.

Jonas

--

Jonas Smedegaard - idealist & Internet-arkitekt
Tlf.: +45 40843136  Website: http://dr.jones.dk/

[x] quote me freely  [ ] ask before reusing  [ ] keep private


bug: button no-animation doesn't work when button apply style of translate-x or translate-y

What version of daisyUI are you using?
4.4.19
Which browsers are you seeing the problem on?
Chrome
Reproduction URL
https://play.tailwindcss.com/oSX5TWmUqW
Describe your issue
As mentioned Tailwind Play url:
<button class="btn no-animation translate-y-1/2">Should no animation</button>

no-animation class disables the animations from daisyUI, not your custom transforms.
Since both scale (used by daisyUI for button press) and translate from your utility class are CSS transforms, your translate-y-1/2 class works on default state but not on focus.
You can use this: translate-y-1/2 focus:active:translate-y-1/2: https://play.tailwindcss.com/mLKCQYQLMG

Thank you and appreciate your help.


Always handle observable errors

There's a bug in RxJS that breaks hot observables if one subscriber ignores errors (see https://github.com/ReactiveX/rxjs/issues/2145 ), which is causing #308. This patch fixes it by always handling observable errors (handling errors is a good idea anyway).
Fixes #308

Nice, thanks


close #19 to remove the movies from the database create api endpoints

Remove the movies from the database create api endpoints

Exposed Endpoint working.


Incorrect join condition generation on nested join

CrateDB version
5.3/5.4/5.5
Problem description
The query returns no the correct result.
Steps to Reproduce

Follow https://github.com/crate/crate-benchmarks/tree/master/join-order-benchmark to setup the dataset.
Run the first Query 01a.sql from the Benchmark:

SELECT MIN(mc.note) AS production_note,
       MIN(t.title) AS movie_title,
       MIN(t.production_year) AS movie_year
FROM company_type AS ct,
     info_type AS it,
     movie_companies AS mc,
     movie_info_idx AS mi_idx,
     title AS t
WHERE ct.kind = 'production companies'
  AND it.info = 'top 250 rank'
  AND mc.note NOT LIKE '%(as Metro-Goldwyn-Mayer Pictures)%'
  AND (mc.note LIKE '%(co-production)%'
       OR mc.note LIKE '%(presents)%')
  AND ct.id = mc.company_type_id
  AND t.id = mc.movie_id
  AND t.id = mi_idx.movie_id
  AND mc.movie_id = mi_idx.movie_id
  AND it.id = mi_idx.info_type_id;

Actual Result
+-----------------+-------------+------------+
| production_note | movie_title | movie_year |
+-----------------+-------------+------------+
|            NULL |        NULL |       NULL |
+-----------------+-------------+------------+

Expected Result
+---------------------------------------------------+-------------------+------------+
| production_note                                   |       movie_title | movie_year |
+---------------------------------------------------+-------------------+------------+
|(A Warner Bros.-First National Picture) (presents) |A Clockwork Orange |      1934.0|
+---------------------------------------------------+-------------------+------------+

More insights:
If we look at the Query plan of the query:
+-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
| QUERY PLAN                                                                                |
+-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
| Eval[min(note) AS production_note, min(title) AS movie_title, min(production_year) AS movie_year] (rows=1)                                                                                |
|   └ HashAggregate[min(note), min(title), min(production_year)] (rows=1)                                                                                |
|     └ HashJoin[(id = info_type_id)] (rows=0)                                                                                |
|       ├ Eval[note, title, production_year, info_type_id] (rows=0)                                                                                |
|       │  └ HashJoin[((movie_id = movie_id) AND (id = movie_id))] (rows=0) <-  This join condition is the problem                                                                                |
|       │    ├ Rename[movie_id, info_type_id] AS mi_idx (rows=1380035)                                                                                |
|       │    │  └ Collect[doc.movie_info_idx | [movie_id, info_type_id] | true] (rows=1380035)                                                                                |
|       │    └ Eval[note, title, production_year, movie_id, id] (rows=5)                                                                                |
|       │      └ HashJoin[(id = movie_id)] (rows=5)                                                                                |
|       │        ├ Rename[title, production_year, id] AS t (rows=2493312)                                                                                |
|       │        │  └ Collect[doc.title | [title, production_year, id] | true] (rows=2493312)                                                                                |
|       │        └ Eval[note, movie_id] (rows=435072)                                                                                |
|       │          └ HashJoin[(id = company_type_id)] (rows=435072)                                                                                |
|       │            ├ Rename[note, company_type_id, movie_id] AS mc (rows=1740289)                                                                                |
|       │            │  └ Collect[doc.movie_companies | [note, company_type_id, movie_id] | ((NOT (note LIKE '%(as Metro-Goldwyn-Mayer Pictures)%')) AND ((note LIKE '%(co-production)%') OR (note LIKE '%(presents)%')))] (rows=1740289) |
|       │            └ Rename[id] AS ct (rows=1)                                                                                |
|       │              └ Collect[doc.company_type | [id] | (kind = 'production companies')] (rows=1)                                                                                |
|       └ Rename[id] AS it (rows=1)                                                                                |
|         └ Collect[doc.info_type | [id] | (info = 'top 250 rank')] (rows=1)                                                                                |
+-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+

The wrongly generated join condition HashJoin[((movie_id = movie_id) AND (id = movie_id))] by commit https://github.com/crate/crate/commit/bf6e15652586cac9a3d45bb379be19e2dd5dd91c causes the problem. Reverting this commit generates the following plan which then returns the correct result.

+-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
| QUERY PLAN                                                                                |
+------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
| Eval[min(note) AS production_note, min(title) AS movie_title, min(production_year) AS movie_year] (rows=1)                                                                                |
|   └ HashAggregate[min(note), min(title), min(production_year)] (rows=1)                                                                                |
|     └ HashJoin[(id = info_type_id)] (rows=unknown)                                                                                |
|       ├ HashJoin[(movie_id = movie_id)] (rows=unknown)                                                                                |
|       │  ├ HashJoin[(id = movie_id)] (rows=unknown)                                                                                |
|       │  │  ├ HashJoin[(id = company_type_id)] (rows=unknown)                                                                                |
|       │  │  │  ├ Rename[id] AS ct (rows=unknown)                                                                                |
|       │  │  │  │  └ Collect[doc.company_type | [id] | (kind = 'production companies')] (rows=unknown)                                                                                |
|       │  │  │  └ Rename[note, company_type_id, movie_id] AS mc (rows=unknown)                                                                                |
|       │  │  │    └ Collect[doc.movie_companies | [note, company_type_id, movie_id] | ((NOT (note LIKE '%(as Metro-Goldwyn-Mayer Pictures)%')) AND ((note LIKE '%(co-production)%') OR (note LIKE '%(presents)%')))] (rows=unknown) |
|       │  │  └ Rename[title, production_year, id] AS t (rows=unknown)                                                                                |
|       │  │    └ Collect[doc.title | [title, production_year, id] | true] (rows=unknown)                                                                                |
|       │  └ Rename[movie_id, info_type_id] AS mi_idx (rows=unknown)                                                                                |
|       │    └ Collect[doc.movie_info_idx | [movie_id, info_type_id] | true] (rows=unknown)                                                                                |
|       └ Rename[id] AS it (rows=unknown)                                                                                |
|         └ Collect[doc.info_type | [id] | (info = 'top 250 rank')] (rows=unknown)                                                                                |
+------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+

Just checked this against 5.3 and the bug is present there as well.

Hi
I am Chitrank, and I am currently pursuing MS in CS at UT Austin.
As part of my course project, I have to work on addressing a specific issue or bug within a defined timeframe, with the goal of creating a Pull Request (PR) to contribute to the project's development. Given the significance of this project, I am seeking assistance and guidance from experienced contributors such as yourself.
I have identified a set of issues that align with my project's objectives, and I believe that your expertise and insights would be immensely valuable in helping me understand and resolve these challenges effectively.
Kind regards,
Chitrank

This is reduced version of the query which causes the problem:
create table t1(a int);
create table t2(b int, c int);
create table t3(d int);
create table t4(e int);

insert into t1 values (1);
insert into t2 values (1,2);
insert into t3 values (2);
insert into t4 values (2);

SELECT *
        FROM t1,
             t2,
             t3,
             t4
        WHERE t1.a = t2.b
          AND t4.e = t2.c
          AND t4.e = t3.d
          AND t2.c = t3.d;

Psql:
 a | b | c | d | e
---+---+---+---+---
 1 | 1 | 2 | 2 | 2

CrateDB:
 | a | b | c | d | e |
 +---+---+---+---+---+
 +---+---+---+---+---+

explain SELECT *
        FROM t1,
             t2,
             t3,
             t4
        WHERE t1.a = t2.b
          AND t4.e = t2.c
          AND t4.e = t3.d
          AND t2.c = t3.d;

Psql:
  Join (t4.e = t2.c)
    Join (t3.d = t4.e)
               Scan: t3.d
               Scan: t4.e
         -Join(t2.b = t1.a)
                     Scan: t2.b
                     Scan: t1.a

CrateDB:
+--------------------------------------------------------------------------------+
| QUERY PLAN                                                                     |
+--------------------------------------------------------------------------------+
| Eval[a, b, c, d, e] (rows=unknown)                                             |
|   └ HashJoin[((doc.t2.c = doc.t3.d) AND (doc.t4.e = doc.t3.d))] (rows=unknown) |
|     ├ HashJoin[(doc.t4.e = doc.t2.c)] (rows=unknown)                           |
|     │  ├ HashJoin[(doc.t1.a = doc.t2.b)] (rows=unknown)                        |
|     │  │  ├ Collect[doc.t1 | [a] | true] (rows=unknown)                        |
|     │  │  └ Collect[doc.t2 | [b, c] | true] (rows=unknown)                     |
|     │  └ Collect[doc.t4 | [e] | true] (rows=unknown)                           |
|     └ Collect[doc.t3 | [d] | true] (rows=unknown)                              |
+--------------------------------------------------------------------------------+

The problem is in the hash join implementation. If i run the query with nestedloop joins it works:
+------------------------------------------------------------------+
| QUERY PLAN                                                       |
+------------------------------------------------------------------+
| Eval[a, b, c, d, e] (rows=unknown)                               |
|   └ NestedLoopJoin[INNER | ((c = d) AND (e = d))] (rows=unknown) |
|     ├ NestedLoopJoin[INNER | (e = c)] (rows=unknown)             |
|     │  ├ NestedLoopJoin[INNER | (a = b)] (rows=unknown)          |
|     │  │  ├ Collect[doc.t1 | [a] | true] (rows=unknown)          |
|     │  │  └ Collect[doc.t2 | [b, c] | true] (rows=unknown)       |
|     │  └ Collect[doc.t4 | [e] | true] (rows=unknown)             |
|     └ Collect[doc.t3 | [d] | true] (rows=unknown)                |
+------------------------------------------------------------------+

+---+---+---+---+---+
| a | b | c | d | e |
+---+---+---+---+---+
| 1 | 1 | 2 | 2 | 2 |
+---+---+---+---+---+

create table t1(a int);
create table t2(b int);
create table t3(c int);

insert into t1 values (1);
insert into t2 values (1);
insert into t4 values (1);

SELECT * FROM t1,t2, t3 WHERE t3.c = t1.a AND t3.c = t2.b AND t1.a = t2.b;

+---+---+---+
| a | b | c |
+---+---+---+
+---+---+---+

SET enable_hashjoin=false;

+---+---+---+
| a | b | c |
+---+---+---+
| 1 | 1 | 1 |
+---+---+---+


RHOAIENG-8517: Implement unit tests for kuberay, kueue, notebook and kubeflow alerts

Description
This pr adds support for unit tests for the kuberay, kueue, kubeflow controller and ODH notebook controller alerts
How Has This Been Tested?
cd tests/prometheus_unit_tests

# Use yq to pull the alert definitions out of the larger config file
yq '.data."rhods-dashboard-alerting.rules"' ../../config/monitoring/prometheus/apps/prometheus-configs.yaml > dashboard_alerts.yaml && yq '.data."model-mesh-alerting.rules"' ../../config/monitoring/prometheus/apps/prometheus-configs.yaml > model_mesh_alerts.yaml && yq '.data."trustyai-alerting.rules"' ../../config/monitoring/prometheus/apps/prometheus-configs.yaml > trustyai_alerts.yaml && yq '.data."odh-model-controller-alerting.rules"' ../../config/monitoring/prometheus/apps/prometheus-configs.yaml > model_controller_alerts.yaml && yq '.data."workbenches-alerting.rules"' ../../config/monitoring/prometheus/apps/prometheus-configs.yaml > workbenches_alerts.yaml && yq '.data."data-science-pipelines-operator-alerting.rules"' ../../config/monitoring/prometheus/apps/prometheus-configs.yaml > data_science_pipelines_operator_alerts.yaml && yq '.data."kserve-alerting.rules"' ../../config/monitoring/prometheus/apps/prometheus-configs.yaml > kserve_alerts.yaml && yq '.data."kueue-alerting.rules"' ../../config/monitoring/prometheus/apps/prometheus-configs.yaml > kueue_alerts.yaml && yq '.data."ray-alerting.rules"' ../../config/monitoring/prometheus/apps/prometheus-configs.yaml > kuberay_alerts.yaml

# Run the unit tests
promtool test rules *_unit_tests.yaml

Screenshot or short clip

Merge criteria

[x] You have read the contributors guide.
[x] Commit messages are meaningful - have a clear and concise summary and detailed explanation of what was changed and why.
[x] Pull Request contains a description of the solution, a link to the JIRA issue, and to any dependent or related Pull Request.
[x] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
[x] The developer has manually tested the changes and verified that the changes work

/ok-to-test

/lgtm

jira ticket in description


Stored Procedure returned status code is not extracted immediately when calling through QueryContext

Given a procedure that returns both a status code and a recordset, e.g.
ALTER procedure [dbo].[LoadConfigs]
as
set nocount on

select
	[IdConfig],
	[Value]
from dbo.Config

return 101

called as
var rs mssql.ReturnStatus
rows, err := db.QueryContext(ctx, "theproc", &rs)

if err != nil {
	return err
}

if rs != 0 {
	return errors.New("SP returned non-zero status")
}

for rows.Next() {
	err = rows.Scan(&val)
	//Do stuff with val
}

we are expecting that the return status will be set immediately after QueryContext returns with no errors (based on the implementation in mssql.go, processQueryResponse())
What we are observing is that the return status remains zero because processQueryResponse() breaks its parsing of tokens as soon as it encounters a []columnStruct token.
Note: Return status is then filled by Rows.Next() when it encounters a Return Status token.

It is not a bug. You'd better get error from Rows.Error() after Rows.Next()


Analyzer+VSCode macro surprising caching

I ran this one by Konstantin and he suggested that it looks like an analyzer plugin issue. @scheglov
@DanTup what do you think, please?
Long story follows ;)

I am experimenting with making changes to
pkg/_fe_analyzer_shared/lib/src/macros/api/exceptions.dart
and viewing the JSON macro in VSCode
tests/language/macros/json
--I make a change to inject a string into all diagnostics
  DiagnosticException(Diagnostic diagnostic)
      : diagnostic = Diagnostic(
            DiagnosticMessage(diagnostic.message.message + '***10***'),
            diagnostic.severity);

then check the diagnostics in json_serializable_diagnostic_test.dart, so it's easy to see if the macro was rebuilt or not.
The symptom I am able to get to is that if I make an edit (outside VSCode!) to change the string, e.g. '10' -> '11', the diagnostic in VSCode does not change, even if I force the macro to rerun by changing json_serializable_diagnostic_test.dart.
To "unstick" it I tried removing ~/.dartServer and killing all dart processes, but that didn't work. It only worked to restart VSCode.
Then I find it hard to get into the "stuck" state again :) ... normally it reacts fine to my external changes. But, I think I found the trigger.
It's when I have pkg/_fe_analyzer_shared also opened in the same VSCode project, then make a change there to exceptions.dart, then close it, then make changes to the file outside VSCode.
My guess is that for the macro build exceptions.dart then gets pinned at the version of the file that was opened in VSCode, ignoring my external changes to it, until I restart VSCode.

@davidmorgan are you able to give precise steps for me to repro this? Starting with exactly which folders you have open and exactly what files you're modifying? (if the code isn't committed, you could send me a patch or push to Gerrit/GH and I'll pull from there).
Can you also confirm whether the file you're modifying outside of VS Code is still open in VS Code, and if so whether you see it reload the updated contents after the external modification?

I think I understood what you were doing, but I was unable to reproduce the issue. I opened the file in notepad and made changes and saved, and both the file and the diagnostics updated immediately in VS Code.
https://github.com/dart-lang/sdk/assets/1078012/41ce63ce-2a19-4504-b114-0a4d18dca3a7
I tried various combinations (updating in VS Code first, having the file closed, etc.) but nothing seemed to trigger the issue you're seeing except for having unsaved changes in the file in VS Code, but that's expected (since when you have an unsaved file in VS Code, VS Codes buffer is what the analyzer is using, and not what is on disk).
Am I doing something differently to you? Could you provide detailed steps that I can use to try to repro?
I was testing with the following SDK (this is the version of the analyzer that's running):
Dart SDK version: 3.4.0-edge.94e653fe0e26d5a4fd4b905517ec38d0b44d122e (main) (Tue Feb 27 08:07:00 2024 +0000) on "windows_x64"
And I was opening pkg/_fe_analyzer_shared and tests/language/macros/json in the workspace from SDK commit 94e653fe0e2

Odd.. Please do let me know if you see it again (ideally with steps to repro if you can)! :)

👍