I downloaded microsoft vs code but due to some issues kept reinstalling it again and again and now suddenly while deleting vs code through 'unins000' some files including "code" couldnt be deleted and a pop up said that these files can be deleted manually but when i tried to delete them  it said that it couldnt be deleted because the files open in microsoft visual studio code and thus like this 4 files are now in the folder which i am unable to delete. i have tried downloading vs code again and merging it with previous folder but that didnt did any thing. Pls help as i am unable to find any soln for it anywhere

Does this issue occur when all extensions are disabled?: Yes/No

VS Code Version:
OS Version:

Steps to Reproduce:

Does this issue occur when all extensions are disabled?: Yes/No
no extension was disabled

VS Code Version: 1.66.2
OS Version:

Steps to Reproduce:

Closing as the issue is unclear
Please follow this guide to submit a proper issue report. This should include:

What are you trying to do?
What went wrong?
Steps to reproduce the problem


COUVIS_0058 and 0059 have bad FILE_SPECIFICATION_NAME

Volumes COUVIS_0058 and COUVIS_0059 have lower case "data" in the FILE_SPECIFICATION_NAME while all other volumes have upper case "DATA".

Note we are working around this in the import pipeline by forcing the FILE_SPEC to be upper case.


[FEATURE] Breadcrumb feature could be added

Description

A Breadcrumb feature could be added as shown in the screenshot as it improves user navigation across the whole website.
It adds more professionalism and user can easily navigate through the pages.
Please assign me to this issue under GSSoC'23
Screenshots
No response

hey @Arnabdaz could you please look over the feature and assign me so that I could PR at the earliest?

we do not have so many pages to breadcrumb and it would also affect the design

Sure! I will close this issue then.


SV-1398 Update mapping to trim options

Added trimming to the mapping of options.

This is covered in #107 🤔 and has a dependabot bump as well 💪🏻

This is covered in #107 🤔 and has a dependabot bump as well 💪🏻

Added in the Dependabot bump 👍


Deny changing workspace id label

What does this PR do?
This PR denies changing:

workspace id label in pods/deployment metadata
workspace id label/creator annotation in deployment.spec.template.metadata

In addition, this PR refactors webhook files and packages.
There is separated commit that classes hierarchy
WebhookHandler:
ResourceValidator ResourceMutator
Personally I like the look with it, let me know if you don't and we can discuss and revert it.
What issues does this PR fix or reference?
eclipse/che#16252
Is it tested? How?

kc apply -f ./samples/cloud-shell.yaml
kc get workspace -o=yaml | grep creator
kc edit deployment workspace .... #tried to modify creator, workspace id in metadata and template, made sure that they are restored if omitted.
kc edit pod workspace .... #tried to modify creator, workspace id in metadata, made sure that they are restored if omitted.
kc exec -ti workspace ... -c dev sh # as admin and creator, admin is not able to attach

retested after changes are applied


cups-googlecloudprint: init at 20160502

Motivation for this change
Add support for Google Cloud Print in CUPS, using https://github.com/simoncadman/CUPS-Cloud-Print / https://www.niftiestsoftware.com/cups-cloud-print/
cc @samueldr
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[x] Fits CONTRIBUTING.md.

Success on aarch64-linux (full log)
Attempted: cups-googlecloudprint
Partial log (click to expand)
/nix/store/anzl3xx9mxq460w9disj6r7cb21my7j3-cups-googlecloudprint-20160502/share/cloudprint-cups/refreshtokens.py: interpreter directive changed from " /bin/sh" to "/nix/store/017xymp5i03qzigafnfx7sgf6602gmzq-bash-4.4-p23/bin/sh"
/nix/store/anzl3xx9mxq460w9disj6r7cb21my7j3-cups-googlecloudprint-20160502/share/cloudprint-cups/listcloudprinters.py: interpreter directive changed from " /bin/sh" to "/nix/store/017xymp5i03qzigafnfx7sgf6602gmzq-bash-4.4-p23/bin/sh"
/nix/store/anzl3xx9mxq460w9disj6r7cb21my7j3-cups-googlecloudprint-20160502/share/cloudprint-cups/dynamicppd.py: interpreter directive changed from " /bin/sh" to "/nix/store/017xymp5i03qzigafnfx7sgf6602gmzq-bash-4.4-p23/bin/sh"
/nix/store/anzl3xx9mxq460w9disj6r7cb21my7j3-cups-googlecloudprint-20160502/share/cloudprint-cups/deleteaccount.py: interpreter directive changed from " /bin/sh" to "/nix/store/017xymp5i03qzigafnfx7sgf6602gmzq-bash-4.4-p23/bin/sh"
/nix/store/anzl3xx9mxq460w9disj6r7cb21my7j3-cups-googlecloudprint-20160502/share/cloudprint-cups/backend.py: interpreter directive changed from " /bin/sh" to "/nix/store/017xymp5i03qzigafnfx7sgf6602gmzq-bash-4.4-p23/bin/sh"
/nix/store/anzl3xx9mxq460w9disj6r7cb21my7j3-cups-googlecloudprint-20160502/share/cloudprint-cups/testing/listdrivefiles.py: interpreter directive changed from " /bin/sh" to "/nix/store/017xymp5i03qzigafnfx7sgf6602gmzq-bash-4.4-p23/bin/sh"
/nix/store/anzl3xx9mxq460w9disj6r7cb21my7j3-cups-googlecloudprint-20160502/share/cloudprint-cups/testing/remove-test.sh: interpreter directive changed from " /bin/bash" to "/nix/store/017xymp5i03qzigafnfx7sgf6602gmzq-bash-4.4-p23/bin/bash"
/nix/store/anzl3xx9mxq460w9disj6r7cb21my7j3-cups-googlecloudprint-20160502/share/cloudprint-cups/testing/full-test.sh: interpreter directive changed from " /bin/bash" to "/nix/store/017xymp5i03qzigafnfx7sgf6602gmzq-bash-4.4-p23/bin/bash"
checking for references to /build in /nix/store/anzl3xx9mxq460w9disj6r7cb21my7j3-cups-googlecloudprint-20160502...
/nix/store/anzl3xx9mxq460w9disj6r7cb21my7j3-cups-googlecloudprint-20160502

Failure on x86_64-darwin (full log)
Attempted: cups-googlecloudprint
Partial log (click to expand)
/nix/store/zyyw7qxpj1yri8xdasbm68ix3hwmly85-coreutils-8.30/bin/install -c -m 755 ./testing/listdrivefiles.py /nix/store/8nrc60szgg5ghxpmyc8nd8qlsjbpfgka-cups-googlecloudprint-20160502/share/cloudprint-cups/testing/
/nix/store/zyyw7qxpj1yri8xdasbm68ix3hwmly85-coreutils-8.30/bin/install -c -m 644 ./testing/testfiles/* /nix/store/8nrc60szgg5ghxpmyc8nd8qlsjbpfgka-cups-googlecloudprint-20160502/share/cloudprint-cups/testing/testfiles/
/nix/store/zyyw7qxpj1yri8xdasbm68ix3hwmly85-coreutils-8.30/bin/install -c -m 644 ./selinux/* /nix/store/8nrc60szgg5ghxpmyc8nd8qlsjbpfgka-cups-googlecloudprint-20160502/share/cloudprint-cups/selinux/
/nix/store/zyyw7qxpj1yri8xdasbm68ix3hwmly85-coreutils-8.30/bin/install -c -m 644 ./oauth2client/*.py /nix/store/8nrc60szgg5ghxpmyc8nd8qlsjbpfgka-cups-googlecloudprint-20160502/share/cloudprint-cups/oauth2client/
mkdir -p /Library/LaunchDaemons/
/nix/store/zyyw7qxpj1yri8xdasbm68ix3hwmly85-coreutils-8.30/bin/install -c -m 644 ./launchd/* /Library/LaunchDaemons/
install: cannot create regular file '/Library/LaunchDaemons/cupscloudprint.plist': Permission denied
make: *** [Makefile:34: install] Error 1
builder for '/nix/store/ly5gbqashma0x14fw6rrbsgz8dqgnl8h-cups-googlecloudprint-20160502.drv' failed with exit code 2
error: build of '/nix/store/ly5gbqashma0x14fw6rrbsgz8dqgnl8h-cups-googlecloudprint-20160502.drv' failed

Success on x86_64-linux (full log)
Attempted: cups-googlecloudprint
Partial log (click to expand)
/nix/store/rjsmphnh3i847anzr8djhiyabzd2icpn-cups-googlecloudprint-20160502/share/cloudprint-cups/upgrade.py: interpreter directive changed from " /bin/sh" to "/nix/store/nii7pk6pv4x4as7vsxbvwyzjn67vax6r-bash-4.4-p23/bin/sh"
/nix/store/rjsmphnh3i847anzr8djhiyabzd2icpn-cups-googlecloudprint-20160502/share/cloudprint-cups/refreshtokens.py: interpreter directive changed from " /bin/sh" to "/nix/store/nii7pk6pv4x4as7vsxbvwyzjn67vax6r-bash-4.4-p23/bin/sh"
/nix/store/rjsmphnh3i847anzr8djhiyabzd2icpn-cups-googlecloudprint-20160502/share/cloudprint-cups/testing/listdrivefiles.py: interpreter directive changed from " /bin/sh" to "/nix/store/nii7pk6pv4x4as7vsxbvwyzjn67vax6r-bash-4.4-p23/bin/sh"
/nix/store/rjsmphnh3i847anzr8djhiyabzd2icpn-cups-googlecloudprint-20160502/share/cloudprint-cups/testing/remove-test.sh: interpreter directive changed from " /bin/bash" to "/nix/store/nii7pk6pv4x4as7vsxbvwyzjn67vax6r-bash-4.4-p23/bin/bash"
/nix/store/rjsmphnh3i847anzr8djhiyabzd2icpn-cups-googlecloudprint-20160502/share/cloudprint-cups/testing/full-test.sh: interpreter directive changed from " /bin/bash" to "/nix/store/nii7pk6pv4x4as7vsxbvwyzjn67vax6r-bash-4.4-p23/bin/bash"
/nix/store/rjsmphnh3i847anzr8djhiyabzd2icpn-cups-googlecloudprint-20160502/share/cloudprint-cups/setupcloudprint.py: interpreter directive changed from " /bin/sh" to "/nix/store/nii7pk6pv4x4as7vsxbvwyzjn67vax6r-bash-4.4-p23/bin/sh"
/nix/store/rjsmphnh3i847anzr8djhiyabzd2icpn-cups-googlecloudprint-20160502/share/cloudprint-cups/deleteaccount.py: interpreter directive changed from " /bin/sh" to "/nix/store/nii7pk6pv4x4as7vsxbvwyzjn67vax6r-bash-4.4-p23/bin/sh"
/nix/store/rjsmphnh3i847anzr8djhiyabzd2icpn-cups-googlecloudprint-20160502/share/cloudprint-cups/dynamicppd.py: interpreter directive changed from " /bin/sh" to "/nix/store/nii7pk6pv4x4as7vsxbvwyzjn67vax6r-bash-4.4-p23/bin/sh"
checking for references to /build in /nix/store/rjsmphnh3i847anzr8djhiyabzd2icpn-cups-googlecloudprint-20160502...
/nix/store/rjsmphnh3i847anzr8djhiyabzd2icpn-cups-googlecloudprint-20160502

Success on aarch64-linux (full log)
Attempted: cups-googlecloudprint
Partial log (click to expand)
/nix/store/anzl3xx9mxq460w9disj6r7cb21my7j3-cups-googlecloudprint-20160502

No attempt on x86_64-darwin (full log)
The following builds were skipped because they don't evaluate on x86_64-darwin: cups-googlecloudprint
Partial log (click to expand)

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

Success on x86_64-linux (full log)
Attempted: cups-googlecloudprint
Partial log (click to expand)
/nix/store/rjsmphnh3i847anzr8djhiyabzd2icpn-cups-googlecloudprint-20160502/share/cloudprint-cups/deleteaccount.py: interpreter directive changed from " /bin/sh" to "/nix/store/nii7pk6pv4x4as7vsxbvwyzjn67vax6r-bash-4.4-p23/bin/sh"
/nix/store/rjsmphnh3i847anzr8djhiyabzd2icpn-cups-googlecloudprint-20160502/share/cloudprint-cups/dynamicppd.py: interpreter directive changed from " /bin/sh" to "/nix/store/nii7pk6pv4x4as7vsxbvwyzjn67vax6r-bash-4.4-p23/bin/sh"
/nix/store/rjsmphnh3i847anzr8djhiyabzd2icpn-cups-googlecloudprint-20160502/share/cloudprint-cups/testing/remove-test.sh: interpreter directive changed from " /bin/bash" to "/nix/store/nii7pk6pv4x4as7vsxbvwyzjn67vax6r-bash-4.4-p23/bin/bash"
/nix/store/rjsmphnh3i847anzr8djhiyabzd2icpn-cups-googlecloudprint-20160502/share/cloudprint-cups/testing/full-test.sh: interpreter directive changed from " /bin/bash" to "/nix/store/nii7pk6pv4x4as7vsxbvwyzjn67vax6r-bash-4.4-p23/bin/bash"
/nix/store/rjsmphnh3i847anzr8djhiyabzd2icpn-cups-googlecloudprint-20160502/share/cloudprint-cups/testing/listdrivefiles.py: interpreter directive changed from " /bin/sh" to "/nix/store/nii7pk6pv4x4as7vsxbvwyzjn67vax6r-bash-4.4-p23/bin/sh"
/nix/store/rjsmphnh3i847anzr8djhiyabzd2icpn-cups-googlecloudprint-20160502/share/cloudprint-cups/backend.py: interpreter directive changed from " /bin/sh" to "/nix/store/nii7pk6pv4x4as7vsxbvwyzjn67vax6r-bash-4.4-p23/bin/sh"
/nix/store/rjsmphnh3i847anzr8djhiyabzd2icpn-cups-googlecloudprint-20160502/lib/cups/driver/.cupscloudprint-wrapped: interpreter directive changed from " /bin/sh" to "/nix/store/nii7pk6pv4x4as7vsxbvwyzjn67vax6r-bash-4.4-p23/bin/sh"
/nix/store/rjsmphnh3i847anzr8djhiyabzd2icpn-cups-googlecloudprint-20160502/lib/cups/backend/.gcp-wrapped: interpreter directive changed from " /bin/sh" to "/nix/store/nii7pk6pv4x4as7vsxbvwyzjn67vax6r-bash-4.4-p23/bin/sh"
checking for references to /build in /nix/store/rjsmphnh3i847anzr8djhiyabzd2icpn-cups-googlecloudprint-20160502...
/nix/store/rjsmphnh3i847anzr8djhiyabzd2icpn-cups-googlecloudprint-20160502

Will merge in a day or so if no feedback.


WIP: dates/times

So much has changed since #49 that I've decided to start over.

This is super out of date and unlikely to end up going into this project, so I'm going to close it. We can always reopen later as time and interest allows.


Add a keepalive of 30s to the client

AWS NAT Gateways close connections after 5 minutes of inactivity; that scenario can happen when doing a helm upgrade --wait on a chart with many replicas.
Fixes #3182
Builds on top of #3101

I signed it

This caused so far inexplicable client timeouts as described in https://github.com/kubernetes/helm/issues/3409#issuecomment-364296473. Any ideas why that might be the case?

Hmm, normally sending keepalive connections will help the connection from closing, not cause it to close. https://github.com/kubernetes/helm/issues/3182 was the original motivator for this PR, which was to help solve the same issue you're seeing in #3409.

@benlangfeld Which kind of envs are you seeing that on? So we can debug it further.
 After doing a keepalive it went away. @bacongobbler described it pretty well.

@helgi I see it on minikube and GKE. In my case, I have a post-install hook. The Helm client closes the connection prematurely and exits with an error while Tiller is still busy waiting for the hook to finish. The overall deployment succeeds on the server-side but the client exits with an error which is problematic for a CI environment.

@cmdshepard What is the error message you are seeing?

@helgi Error: Transport is closing

@cmdshepard Do you have the timings around that? such as this always happens at 240s, 300s, 30, etc

@helgi I have downgraded since, from my CI logs, looks like the client exit occurs about 180s from the time that helm upgrade is called. Hope this is helpful

@helgi
$ time helm install stable/spinnaker --name spinnaker -f values-personal.yaml --wait --timeout 3600 --debug
[debug] Created tunnel using local port: '37517'

[debug] SERVER: "<IP_ADDRESS>:37517"

[debug] Original chart version: ""
[debug] Fetched stable/spinnaker to /home/jjyooi/.helm/cache/archive/spinnaker-0.3.12.tgz

[debug] CHART PATH: /home/user/.helm/cache/archive/spinnaker-0.3.12.tgz

Error: transport is closing

real	3m31.836s
user	0m0.432s
sys	0m0.034s

(AWS stack created using kops)

Full details, including a minimal reproduction, are on the issue I referenced.

This is fixed by https://github.com/kubernetes/helm/pull/3482.


Access token logging

"A best practice is to set the web server's logging settings to prevent logging access tokens."
Would be useful to clarify how to configure logging to log requests except for the ones containing tokens. They appear in Info log level.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 8af11946-ea05-3be2-6fa1-c4c01aa76d8c
Version Independent ID: 58e87eb0-240b-ab00-c5f4-32a0ab2e0028
Content: Security considerations in ASP.NET Core SignalR
Content Source: aspnetcore/signalr/security.md
Product: aspnet-core
GitHub Login: @tdykstra
Microsoft Alias: anurse

What field are they being logged from? This is why we don't log request headers or body by default. Is it in the query?

@Tratcher Yes, the token is present in the query string.

@anurse this is problematic advice as we don't actually provide a way to do it in our stack.

This would likely have to be done with a post-processor then. Or we need to provide the functionality. SignalR's access tokens are in the query string, and users should know that, hence why the comment is there.

@blowdart

Filed https://github.com/aspnet/Docs/pull/9440 to add some clarity.

@anurse what's left to be done in this issue?

I don't think there is anything still to be done.


docs: added jvs docs

fix #278

Hold until we finish https://github.com/abcxyz/lumberjack/issues/280 and https://github.com/abcxyz/lumberjack/issues/283

Hold until we finish #280 and #283

@yolocs, this PR is ready for another round of review.


Mosquitto can't connect to Home Assistant

Just set up the Mosquitto add-on with the following config:
{
  "plain": true,
  "plain_websockets": true,
  "ssl": true,
  "ssl_websockets": true,
  "anonymous": false,
  "logins": [
    {
      "username": "user",
      "password": "pass"
    }
  ],
  "customize": {
    "active": false,
    "folder": "mosquitto"
  },
  "certfile": "fullchain.pem",
  "keyfile": "privkey.pem"
}

Corresponding Home Assistant config is as follows:
mqtt:
  broker: core-mosquitto
  username: user
  password: pass

My MQTT BRUH node's serial connection shows a successful connection to the MQTT broker and reporting information, but as soon as that happens, the Home Assistant logs show: Disconnected from MQTT (1). Trying to reconnect in 1 s every second and Mosquitto add-on's log shows Socket error on client <unknown>, disconnecting. The same errors show up if I restart Mosquitto with my sensor set up in configuration.yaml, but without the BRUH node plugged in.
I've tried every combination of true/false I can in the Mosquitto add-on config, same result every time.

@heytcass, Having the same issue with a similar configuration! Getting:
New connection from #.#.#.# on port 1883.
Socket error on client , disconnecting.
Did you find a solution??

Some problem, have you solved?


Use fcm for upstream

Update the domain used for sending upstream messages to @fcm.googleapis.com instead of @gcm.googleapis.com.

@kroikie LGTM, squash and merge whenever,


Prevent error when used with angular-animate <1.4 (Fixes #1415)

Fixes https://github.com/angular-ui/ui-select/issues/1415

Could anybody please merge this MR?

Is there an earlier version that doesn't have this issue?

0.13.2 and before but these have other issues with ng-animate (see https://github.com/angular-ui/ui-select/commit/9db0a198ab3b3d1a66463f5bbd1f95ef5e0483aa)

Could anyone review and possibly merge this PR?

Hm, it's bad to know that this fix works but nobody wants to merge - that's not good :(

@wesleycho Do you have permissions to publish updates to Bower? I only have permissions to publish changes to npm ATM.

Bower automatically publishes on new tag push.
I could potentially offer a bit of assistance in general - I merged this only because it looked correct, and I have prior experience with ngAnimate through my involvement in UI Bootstrap (and got bothered to merge it).
Project looks like it could use a lot of dev work though...but I guess this is a whole issue in itself.

Yeah that is correct! @deeg has offered to help and the project would also benefit greatly from @user378230's direct help, as he's already proven to be a great help advising others on their PRs and replying to issues. I must not have access because I haven't been invited to the actual UI team organization yet (can you invite me)?

Done! Let me know if you didn't get the invite or if there's anything else I can do here.

I'd be happy to tidy up the issue log if given the relevant permissions :)

@user378230 I've made you a contributor! Please keep in mind that we don't want to throw every perceivable feature and config option at the project and let it become something it was not intended to be. There are a ton of PRs, which if added, would add unwanted kludge and minutia to the project.


Attrubited title on buttons support

I added several methods to create MGSwipeButton with attributed string in its title in addition to the plain string.
So, with
+(instancetype) buttonWithTitle:(NSString *) title backgroundColor:(UIColor *) color
there will be
+(instancetype) buttonWithAttributedTitle:(NSAttributedString *) title backgroundColor:(UIColor *) color
that sets attributed text on button's titleLabel. And so on for the rest convenience constructors.

Added the flag stretchToScreenWidth so action buttons will take whole width of the screen, and divide it in even parts.
Default value if NO, as it was.

Hi,
Thanks for the pull request. I won't merge because stretchToScreenWidth property can be easily replicated by developers using existing properties.
    if (direction == MGSwipeDirectionLeftToRight) {
        expansionSettings.buttonIndex = data.leftExpandableIndex;
        expansionSettings.fillOnTrigger = NO;
        NSArray * buttons = [self createLeftButtons:data.leftButtonsCount];

        //stretchToScreenWidth
        cell.allowsButtonsWithDifferentWidth = YES;
        for (MGSwipeButton * btn in buttons) {
            btn.buttonWidth = _tableView.bounds.size.width/buttons.count;
        }

        return buttons;
    }

@MortimerGoro Okay, but what about initializers with attributed strings?


Add proper documentation

Include Docstring documentation before each function for better dev documentation later on.
Example:
"""
function_name(var::Type, var::Type)
Description of the function
"""

Added Docstring documentation to all currently available methods.


[IPCT1-717] - update thumbnail return

This PR fixes [IPCT1-717] at https://impactmarket.atlassian.net/browse/IPCT1-717
Changes
Update services that return thumbnails.
Tests
all tests running

@obernardovieira changes on v2/stories reverted. Could you please validate again?


Make light sources and shapes work

This gets four more example files to pass. Annotations are next on my list. In the process of stretching the override system even further with a new slot I decided to refactor the entries into instances of a small new dataclass for better readability.

Codecov Report

Merging #17 into master will increase coverage by 0.26%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #17      +/-   ##
==========================================
+ Coverage   95.20%   95.46%   +0.26%
==========================================
  Files           1        1
  Lines         396      419      +23
==========================================
+ Hits          377      400      +23
  Misses         19       19

Impacted Files
Coverage Δ

src/ome_autogen.py
95.46% <100.00%> (+0.26%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee9966e...959da6e. Read the comment docs.

Yes, ship it! :shipit:


Function name conflicts with LinearAlgebra.dot and StaticArrays.similar_type; neither package is a dependency but they are semantically compatible

CliffordNumbers.jl defines two functions with names that conflict with those of already existing packages which are not dependencies, even though they are semantically compatible:

CliffordNumbers.dot, which calculates the dot product of multivectors, conflicts with LinearAlgebra.dot.
CliffordNumbers.similar_type, which generates types similar to a given type, conflicts with StaticArrays.similar_type.

The latter is solved by not exporting CliffordNumbers.similar_type. At the moment, CliffordNumbers.dot is exported, but it may make sense to not export it for the time being: in part because left and right contractions are usually favored over dot products for their more regular properties, and I'd like to encourage users to use those functions instead.
However, I'd like these functions to be exported when the package is loaded without either running into name conflicts with these packages or requiring a dependency on them. This may not be straightforward, and may even require some of this functionality to be placed in metapackages. Hopefully this can be accomplished using package extensions.

Update: I think I'm going to partially fix this in version 0.2 through package extensions that provide the relevant methods to functions from StaticArraysCore and LinearAlgebra.
This won't resolve the issue of these functions not being exported when only this package is loaded, but they will be available if the listed packages or anything depending on them is loaded.

One other issue I found was CliffordNumbers.normalize and LinearAlgebra.normalize. That'll also be included in the package extension, but that means it will not be immediately available for use.

This issue was fixed with #29


This looks like unused field.

https://github.com/Genymobile/scrcpy/blob/master/app/src/stream.h#L17

:+1:
It was wrongly introduced by e6e011baafa9641a1d2b4419f36ef1dc975d479a.
Fixed by 71fda2374c4aff2d2d818995998f7d69a9ad4ed6


Changing congestion control algorithm in quic-go and Ubuntu

Hello everyone.
I’m currently using the latest release of quic-go.
For experimental purpose, I need to configure quic-go’s congestion control algorithm (CCA) to match with one Ubuntu 20.04 is using. I have some questions about this.
1. Changing Ubuntu’s CCA
Ubuntu runs CUBIC as its default CCA. After running sysctl net.ipv4.tcp_available_congestion_control, I found that there is a reno entry. I wonder if this reno is the New Reno currently implemented in quic-go?
I tried to search about enabling New Reno on Ubuntu but so far the answer in this link is the only source I could find that says reno  is New Reno. So I’m not so sure about it. Do you have any idea?
2. Changing quic-go’s CCA to CUBIC
Going through the issues and commits, I found out that quic-go used CUBIC before changing to New Reno (fccdb1c558ec7643ab44877e568ca3d2e2226cc6). Based on this, I tried to set the parameter at line 116 in /internal/ackhandler/send_packet_handler.go to false, expecting it would go back to use CUBIC.
https://github.com/lucas-clemente/quic-go/blob/bd9b085c7405f3aa2ddf42854bc965c3f6aa75d5/internal/ackhandler/sent_packet_handler.go#L112-L118
I wonder if it is possible to do so? Will it influence other components?
Thank you very much.

After changing /internal/ackhandler/sent_packet_handler.go and checking the congestion windows, it think that it definitely is not a good option at all.
So, what is left is whether reno in linux is the New Reno algorithm.

We only implement New Reno. If there are references to Cubic in the code, it's because we took Chromium's CC implementation a few years ago, but there hasn't been any work on maintaining, updating or benchmarking it, and we also might have removed bits and pieces from it since.


feat(dgeni audit): add more keys to the api-list

Changes

Add more keys to the api-list, this exposes the status of all api elements.
The output is located in ts/api-list.json and js/api-list.json, this only happens when a new build is made.

Notes
api-list.json is the file that's used to create the list located at https://angular.io/docs/ts/latest/api/ (and in javascript). Since I've only made additions (and not changed previous key-value pairs), the api doc should remain unaffected. Specifically api-list.js will use the key-value pairs to generate the list for the api doc.
@naomiblack @petebacondarwin

merged, live!


[Bugfix] Fix safety checks failure by adding base_agent/documents/internal/ to version control

Description
Fixes safety test failures caused by adding auth to downloading protected resources.
The cause for failure is that safety.txt was not downloaded to the right place, because base_agent/documents/internal/ was not tracked as a directory. Git does not track empty directories, and base_agent/documents/internal/* path was under our .gitignore. To fix, I added a .gitkeep and the internal folder to version control.
Fixes # (issue)
#243 #311 (note CI was passing due to bug introduced in previous commits)
Please check the options that are relevant.

[x] Bug fix (non-breaking change that fixes an issue)
[ ] Proposes a change (non-breaking change that isn't necessarily a bug)
[ ] Refactor
[ ] New feature (non-breaking change that adds a new functionality)
[ ] Breaking change (fix or feature that would break some existing functionality downstream)
[ ] This is a unit test
[ ] Documentation only change
[ ] Datasets Release
[ ] Models Release

Type of requested review

[ ] I want a thorough review of the implementation.
[x] I want a high level review.
[ ] I want a deep design review.

would it make sense instead to have the download script create the directory? I'll let you make the call, approving this one.

That works too, and would be a more general solution. I'm using pkg_resources to load documents though, so it wouldn't have much advantage here.


Any good solution for 180 video?

360 video now well supported by framework, but if 180 video is played, two same 180 video will be displayed within tag "Viro360Video".
The spliced lines between two images were annoying.Any good solution for this, how can I replace one with a 180 image?

Hi @manbod,
would you please tell us whether the 180° video player is part of your roadmap? If yes, could you please tell us when it is planned to be released? Thanks a lot.
Regards,
newbot23

@newbot23 we can add this to our backlog. Will update this issue once we have a timeframe. It might be a couple months because the next couple releases are pretty packed and we need to evaluate this feature. Do you have a sample 180 video you can send us that we can use as testing (dmoon@viromedia.com)? Also, what cameras are you using to take 180 video just so we can research more.

Thanks for the additional info. We do support stereoscopic images and video (see stereo mode under ViroVideo or ViroImage). I think that is what Google means when they say 3D. So you should be able to play your 180 video via the texture.


Change imports for xcontent

Description
XContent was refactored from org.opensearch.common to org.opensearch.core in the OpenSearch repository.  This PR makes the appropriate adjustments to accomodate this change.
Issues Resolved
https://github.com/opensearch-project/opensearch-sdk-java/issues/481
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Codecov Report

Merging #482 (8b53960) into main (b68bf20) will not change coverage.
The diff coverage is n/a.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@            Coverage Diff            @@
##               main     #482   +/-   ##
=========================================
  Coverage     66.17%   66.17%
  Complexity      186      186
=========================================
  Files            35       35
  Lines           813      813
  Branches         24       24
=========================================
  Hits            538      538
  Misses          264      264
  Partials         11       11

Impacted Files
Coverage Δ

src/main/java/org/opensearch/sdk/Extension.java
100.00% <ø> (ø)

...main/java/org/opensearch/sdk/ExtensionsRunner.java
70.76% <ø> (ø)

...a/org/opensearch/sdk/SDKNamedXContentRegistry.java
100.00% <ø> (ø)

.../main/java/org/opensearch/sdk/SearchExtension.java
15.09% <ø> (ø)

...ch/sdk/sample/helloworld/rest/RestHelloAction.java
85.10% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


It is not backing up my SMS. It says there is no message to do it, but there is

I just installed SMS Backup+ 1.5.11 in a phone, to backup a single SMS message to an IMAP mail server. It did not work. The phone has two chip slots. The was received by the visiting chip, in the second slot, just for a "battery just died, call needed, no charger around" quick emergency.
Expected behaviour
The program sends the SMS to the email account configured.
Actual behaviour
The program says it is done, and there is nothing to backup.
Steps to reproduce the behaviour

Have a working chip with some messages INSIDE it, but space to store a few more. Call this chip.b

Have a phone with 2 chip slots, the first occupied by a chip that was deativated for a lack of use (maybe this is not needed, can be the same as no chip in slot 1). Call this chip.a

With the normal steps, put the chip.b inside the phone.

Send a message to chip.b

Observe the message was stored in the system, and not in the chip, as possible

Install (if needed) and configure SMS Backup+ to use an IMAP mail account to back up, and enable log

Open the "Messages" application, and see the SMS sent in step 4 is there.

Open SMS Backup+ and ask it to backup

See that it says "Done" and "there were items to backup".

Information about the phone:

Android 6.0
Motorola phone, model "Motorola G (2ª generation)"
SMS Backup+ 1.5.11
Messaging app -> what should  I write here???

For a few days, I can keep the phone the way it is now. And I can give you more information or make tests to solve the problem, with your help. This is something that should help, since the possible situation to trigger the problem is unclear, with some details possibly harder to find (I think).

I have similar issue.
It used to work fine. But I deleted all "SMS" mails from my gmail, because I wanted to restart backup (I only wan't to backup conversations from a certain group). But from when I did that it says there's nothing to backup, even though there's no backups left on my gmail.

Solved, found a "restore" button on the main menu. After restoring it backups again!!

@duritia unforunately support for dual SIM phones is currently incomplete; the app can only process the call details and SMSes from the primary SIM.
@jberkel I'm quite keen to fix this as I now have a dual-SIM phone myself.

@alst74 is yours a dual-SIM phone? If not then your earlier problem is probably not connected to this issue.


Create requirements.txt

Thanks a lot for the PR, I really appreciate it! However, let me put this together on the actual chapters -- I haven't added everything yet and there will be some stuff to clean up after finishing the final chapters. I hope you don't mind me closing this right now, but since I have already almost everything set up locally, it would be easier for me to close this pull request and "push" a commit of the files I already have. Once everything is in shape, I would definitely appreciate any future pull requests or other suggestions :)

Sure..


Local pull request success status testing

Docs Build status updates of commit de37e9a:
:clock10: Pending: waiting for processors (15 builds ahead of you)
:warning: Docs Build is busy, currently there are 15 builds ahead of this one, for more information you can view the Build queue graph on the Docs Portal.

Docs Build status updates of commit de37e9a:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

E2E_DocsBranch_Dynamic/index.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel


Wrong type inferred for array of tuples

TypeScript Version:  3.1.6

Search Terms:
array tuple inference inferred argument
Code
let x = [["a", [1]]];

function f(arg: [string, number[]][]) {
}

f(x);

// If I declare x's type directly like this then it works:
// let x: [string, number[]][] = [["a", [1]]];

Expected behavior:
No error
Actual behavior:
Error:
Error:(352, 3) TS2345: Argument of type '(string | number[])[][]' is not assignable to parameter of type '[string, number[]][]'.
  Type '(string | number[])[]' is not assignable to type '[string, number[]]'.
    Property '0' is missing in type '(string | number[])[]'.

Playground Link:
Link

Duplicate of https://github.com/Microsoft/TypeScript/issues/16389

Also see my comment here.

I see, thank you for the quick response!


[VideoConferenceMute] tracker for idea/enhancement

Future improvements for 0.36 code base

[ ] Improve the media format selection logic or allow manual selection (see https://github.com/microsoft/PowerToys/issues/7944#issuecomment-810393141 and https://github.com/microsoft/PowerToys/issues/9267)
[ ] Update scenarios: the filter may be in use by an app while the uninstall/install is executed.

[ ] uninstalling while VCM is used in a browser app (e.g. Teams, Meet)
[ ] uninstalling while VCM is used in a desktop app (e.g. Teams, Skype)

Other ideas/improvements
Uncategorized:

Push-to-talk extension to Mic mute https://github.com/microsoft/PowerToys/issues/6308
Prevent driver install https://github.com/microsoft/PowerToys/issues/6395
Mute speakers when muting webcam and microphone in video conferencing https://github.com/microsoft/PowerToys/issues/8524

Toolbar:

Add the ability to move the toolbar by dragging it around https://github.com/microsoft/PowerToys/issues/6763
Option to show toolbar when the mic is unmuted https://github.com/microsoft/PowerToys/issues/6374#issuecomment-693464482
Add a close button to the toolbar https://github.com/microsoft/PowerToys/issues/6374#issuecomment-693464482
When toolbar is shown right upper alignment sold be more to left https://github.com/microsoft/PowerToys/issues/6296
Add Camera selection to Toolbar https://github.com/microsoft/PowerToys/issues/6831
Place buttons/toolbar in systray https://github.com/microsoft/PowerToys/issues/8297
Display toolbar on ONLY second monitor https://github.com/microsoft/PowerToys/issues/6980
Allow hiding the Video Conference Mute Toolbar https://github.com/microsoft/PowerToys/issues/8705

Status:

Play sound when muting/unmuting microphone https://github.com/microsoft/PowerToys/issues/6332
Status to systray https://github.com/microsoft/PowerToys/issues/6389
Show a frame around the screen that indicate if audio/video is enabled independently of the application used https://github.com/microsoft/PowerToys/issues/6362

HotKeys:

Allow setting hotkeys for "on" and "off" (rather than toggle) for mic mute and camera mute https://github.com/microsoft/PowerToys/issues/7185
Webcam switcher with shortcuts https://github.com/microsoft/PowerToys/issues/8501

Camera:

Remember external cameras when re-connecting it https://github.com/microsoft/PowerToys/issues/6439

Image overlay:

~Show overlay image preview in settings https://github.com/microsoft/PowerToys/issues/6314~
Provide default overlay https://github.com/microsoft/PowerToys/issues/6314#issuecomment-686401452
Use last frame option https://github.com/microsoft/PowerToys/issues/6292
Show video clip or loop https://github.com/microsoft/PowerToys/issues/7363

An option to hide the mic/cam notification after X seconds, even if they are disabled, should be useful.
I always keep them disabled and only enable them when I need them.

An option to hide the mic/cam toolbar when neither are in use would be nice.

@samliddicott
that is already tracked in https://github.com/microsoft/PowerToys/issues/6246 since it's a bug.

@enricogior thanks for the quick response, but I don't think it's a bug and I don't think it is tracked in #6246
There is a feature that works which is to hide the toolbar when both are unmuted.
I'm talking about a feature to hide the toolbar when neither are in use.
If I'm not conferencing and no-one is spying on me, then I don't need to see the toolbar blocking up my screens.
It's when they are in use that the visual option to mute would be good.

@samliddicott

If I'm not conferencing and no-one is spying on me, then I don't need to see the toolbar blocking up my screens.

That is a bug.

Let me configure the global hotkeys. Win+N is the default to open a OneNote Quick Note.

An option to show the toolbar when the microphone is unmuted, instead when it's muted. As muted microphone is my preferable option.
A close button on the toolbar if "Hide toolbar when both camera and microphone are muted/unmuted" is not checked.

I would like the toolbar options to be available as SysTray icons instead, which toggle image and mute state when single-clicked.

If we keep the toolbar it should be free-floating and moveable to any location desired on any monitor. Current options are too limiting.

Idea - Hand/gesture tracking (cut) as an optional trigger to toggle the video and audio or other gestures (hand-raise) within Teams.

Feature request - Option to hide system tray icon with a keyboard shortcut to reopen settings

@daaeed
this issue is specific of the VideoConferenceMute. Also, the request you made is already tracked https://github.com/microsoft/PowerToys/issues/765

It would be helpful if you could categorize the issues in the descriptions into "completed", "in progress", "started"

There is no planned work for these enhancement at the moment. So we don't need to add overhead to manage this list.
The only one completed has been strikethrough-ed.

Question: Why do we still use odd version numbers for PowerToys excluding VCM and even numbers including VCM? This doesn't feel right, because that's not really how version numbers are supposed to be used. I think that, when VCM is stable and developed (looking at the list in the body of this issue), it may just as well be included all together. And then continue with 0.26, 0.27 and so on.
Also, I just read this comment  with the idea to make individual PowerToys as plug-ins, so they can be installed only when needed. I know that will be a huge cost, but just saying I like the idea. At least - possibly - only for VCM. That way VCM is stil optional/extra, but without the weird work-around regarding the version numbers.
(CC: @crutkas)

@Jay-o-Way There is not a rule how version numbers should be used.
For example GIMP has the system: all even numers are public releases and all uneven are beta releases. (Or the other way around i'm not sure)
In the future there will be diffrent release channels, so things will chanhe then. But for now I would keep it as it is at the moment

@Jay-o-Way @Aaron-Junker
this is a tracker not an issue for open discussion, please help keeping this issue on topic.

Idea: Firefox used to have a mini toolbar - with just two buttons - too, when the camera is in use. Now they moved these two things to the systray. Maybe we can "borrow" that idea?

@Jay-o-Way
this is the tracker, open a new issue and we will add it to the tracker.
Thanks.

(I see you mentioned 6980 twice in the body of the issue) 🤭

On a 4K display, the VCM toolbar is pretty small - it doesn't seem to take into account the scaling set in display properties. Would be great if it could scale with the scaling factor in W10, and also if it could have transparency so that it does not block content behind it completely.

Future improvements for 0.36 code base

[ ]  Improve the media format selection logic or allow manual selection (see Use DirectShow filter instead MF custom media source for the VD #7944 (comment) and Drop in framerate when using Video Conference virtual camera #9267)

[ ]  Update scenarios: the filter may be in use by an app while the uninstall/install is executed.

[ ]  uninstalling while VCM is used in a browser app (e.g. Teams, Meet)
[ ]  uninstalling while VCM is used in a desktop app (e.g. Teams, Skype)

Other ideas/improvements
Uncategorized:

Push-to-talk extension to Mic mute Push-to-talk extenstion to Mic mute #6308
Prevent driver install Ability to prevent driver install with PowerToys Video Conference feature #6395
Mute speakers when muting webcam and microphone in video conferencing Mute speakers when muting webcam and microphone in video conferencing #8524

Toolbar:

Add the ability to move the toolbar by dragging it around [Feature Request] [VideoConference] Add the ability to move the Video Conference Toolbar by dragging it around #6763
Option to show toolbar when the mic is unmuted [VideoConferenceMute] tracker for idea/enhancement #6374 (comment)
Add a close button to the toolbar [VideoConferenceMute] tracker for idea/enhancement #6374 (comment)
When toolbar is shown right upper alignment sold be more to left [Vid Conf] When toolbar is shown right upper alignment sold be more to left #6296
Add Camera selection to Toolbar [VideoConferenceMute] Add Camera selection to Toolbar #6831
Place buttons/toolbar in systray [VCM] place buttons/toolbar in systray #8297
Display toolbar on ONLY second monitor [VideoConferenceMute] Display toolbar on ONLY second monitor #6980
Allow hiding the Video Conference Mute Toolbar Allow hiding the Video Conference Mute Toolbar #8705

Status:

Play sound when muting/unmuting microphone [Play sound when muting/unmuting microphone Feature Request for Video Conference Mute) #6332
Status to systray [Videoconference] [Feature idea] Status to systray #6389
Show a frame around the screen that indicate if audio/video is enabled independently of the application used [Video Conference] Show a frame arround the screen that indicate if audio/video is enabled independently of the application used. #6362

HotKeys:

Allow setting hotkeys for "on" and "off" (rather than toggle) for mic mute and camera mute Video Conference: allow setting hotkeys for "on" and "off" (rather than toggle) for mic mute and camera mute  #7185
Webcam switcher with shortcuts [VideoConferenceMute] Webcam switcher with shortcuts #8501

Camera:

Remember external cameras when re-connecting it [Video Conference] External Camera connected to Surface Docking #6439

Image overlay:

~Show overlay image preview in settings [Video conference] Show overlay image preview in settings #6314~
Provide default overlay [Video conference] Show overlay image preview in settings #6314 (comment)
Use last frame option [Vid Conf] - Use last frame option #6292
Show video clip or loop Video Conference - show video clip or loop #7363


fix: track src being removed bug

I ran into this issue where the thumbnails track src was being removed because of a race condition.
the forceHiddenThumbnails was called twice before the setTimeout callback so it ended up setting an empty src.
let me know if that doesn't make sense.

pretty confused because I'm not reproducing it anymore on player.style. gonna close it until it pops up again


Improve our CI/CD pipeline to add a Dev stage

As a developer
I need to have a better CI/CD pipeline
So that I spend even less time worrying about things that's not coding
Details and Assumptions

Dev stage should automatically deploy our app in a Dev environment only if the nosetests from Build stage passes.
Can append -dev to the dev instance

Acceptance Criteria
Given we have set up a dev stage
And our app passes nosetests
When we make new commit on main branch in GitHub
Then IBM Cloud automatically deploys an instance of our app in a development environment

No PR attached but this is done: dev instance running at: https://nyu-shopcart-service-sp2203-dev.us-south.cf.appdomain.cloud
Have set up CI/CD to automatically build test and deploy to dev instance whenever main branch is updated.
Production instance which will use https://nyu-shopcart-service-sp2203.us-south.cf.appdomain.cloud are to be set up in the last 2 stages of CI/CD in separate stories


[DX] add a note on wrong npm version if that's the case

Just spent a bunch of time debugging why my deploys are not working and lamda sizes are 0.00 mb. Turns out npm somehow reverted to version 5.6. Would be nice to have a warning for cases like that.
Thanks!

yea I super agree; will look at adding this in the next release

fixed!


Update get_datasets.py add polars engine

This should help increase the speed of getting the datasets. With pandas it is pretty slow.

I kind of feel like we should just get rid of the csv files and turn them into parquet files and rewrite this so we use less memory and also load them more quickly in both pandas and polars. But we can discuss if there is a preference for keeping these as csv for some reason. It just is less effecient.


AwsSolutions-DOC5 Does not go away after enabling audit logs

General Issue
I keep getting AwsSolutions-DOC5 as an error after enabling audit logs
The Question
I keep getting the error AwsSolutions-DOC5 and I am not sure how to get rid of the error. CDK code put in other information.
cdk-nag version
2.27.114
Language
Typescript
Other information
Hi,
This is my CDK code to create a documentdb database I keep getting this error:
[Error at /document-db-stack/Database/Resource] AwsSolutions-DOC5[LogExport::authenticate]: The Document DB cluster does not have authenticate, createIndex, and dropCollection Log Exports enabled. This allows operators to use CloudWatch to view logs to help diagnose problems in the database. The events recorded by the AWS DocumentDB audit logs include successful and failed authentication attempts, creating indexes or dropping a collection in a database within the DocumentDB cluster.This is a granular rule that returns individual findings that can be suppressed with 'appliesTo'. The findings are in the format 'LogExport::' for exported logs. Example: appliesTo: ['LogExport::authenticate'].
I think I added the audit logs but the error does not go away. I hope this is the right place to ask for help. If not I am sorry!
import {Stack, StackProps} from 'aws-cdk-lib';
import {Construct} from 'constructs';
import * as ec2 from 'aws-cdk-lib/aws-ec2';
import * as docdb from 'aws-cdk-lib/aws-docdb';
import * as cdk from 'aws-cdk-lib';
import * as logs from 'aws-cdk-lib/aws-logs';
import * as secretsmanager from 'aws-cdk-lib/aws-secretsmanager';

interface DocumentDBStackProps extends StackProps {
  vpc: ec2.Vpc;
}

export class DocumentDBStack extends Stack {
  public readonly secretName: string;
  public readonly dbClusterName: string;
  public docmentDBSecurityGroup: ec2.SecurityGroup;
  public readonly databasePort: number;
  constructor(scope: Construct, id: string, props: DocumentDBStackProps) {
    super(scope, id, props);

    const documentDBParameterGroup = new docdb.ClusterParameterGroup(this, 'Parameter-Group', {
      family: 'docdb5.0',
      parameters: {
        tls: 'disabled',
        audit_logs: 'all',
      },
      dbClusterParameterGroupName: 'Parameter-Group',
      description: 'Parameter group to disable TLS and enable audit logs',
    });

    this.docmentDBSecurityGroup = new ec2.SecurityGroup(this, 'docmentDBSecurityGroup', {
      vpc: props.vpc,
      allowAllOutbound: true,
      description: 'Cluster Security Group',
    });

    const userName = 'userName';
    this.secretName = 'test/documentDB';
    this.dbClusterName = 'testdb';
    this.databasePort = 28000;

    // DocDB Cluster
    const docdbCluster = new docdb.DatabaseCluster(this, 'Database', {
      masterUser: {
        username: userName, // NOTE: 'admin' is reserved by DocumentDB
        excludeCharacters: '"+&*^#@(){$}:|/,?-\'%$[]<>_;`.=~\\', // optional, defaults to the set "\"@/" and is also used for eventually created rotations
        secretName: this.secretName, // optional, if you prefer to specify the secret name
      },
      parameterGroup: documentDBParameterGroup,
      instanceType: ec2.InstanceType.of(ec2.InstanceClass.T3, ec2.InstanceSize.MEDIUM),
      vpcSubnets: {
        subnetType: ec2.SubnetType.PRIVATE_ISOLATED,
      },
      vpc: props.vpc,
      exportAuditLogsToCloudWatch: true,
      dbClusterName: this.dbClusterName,
      deletionProtection: true,
      instances: 1,
      port: this.databasePort,
      securityGroup: this.docmentDBSecurityGroup,
      backup: {
        retention: cdk.Duration.days(30),
      },
      cloudWatchLogsRetention: logs.RetentionDays.INFINITE,
      enablePerformanceInsights: false,
      preferredMaintenanceWindow: 'sat:04:00-sat:04:30',
      removalPolicy: cdk.RemovalPolicy.RETAIN,
      storageEncrypted: true,
    });

    const secret = docdbCluster.secret;

    if(secret === undefined) {
      throw new Error('Secret is undefined');
    }

    secret.addRotationSchedule('RotationSchedule', {
      automaticallyAfter: cdk.Duration.days(1),
      hostedRotation: secretsmanager.HostedRotation.mongoDbSingleUser({
        vpc: props.vpc,
        vpcSubnets: {
          subnetType: ec2.SubnetType.PRIVATE_ISOLATED,
        },
        excludeCharacters: '"+&*^#@(){$}:|/,?-\'%$[]<>_;`.=~\\',
      }),
    });
  }
}

This is what  a compliant CfnDBCluster should look like.
      new CfnDBCluster(stack, 'rDatabaseCluster', {
        masterUsername: SecretValue.secretsManager('foo').toString(),
        masterUserPassword: SecretValue.secretsManager('bar').toString(),
        enableCloudwatchLogsExports: [
          'authenticate',
          'createIndex',
          'dropCollection',
        ],
      });

It doesn't look like the L2 construct enableAuditLogsToCloudWatch covers this use case.
You'll have to use a property override + suppression to remediate the issue.
I suggest opening up a feature request on the cdk repo to have this resolved in the L2


coreAliasing breaks local variables named Map, Symbol, etc

var Map = 5;
console.log('should be 6', ++Map);

If you compile it with the coreAliasing transform, it becomes this:
"use strict";

var _interopRequire = function (obj) {
  return obj && (obj["default"] || obj);
};

var _core = _interopRequire(require("core-js/library"));

var Map = 5;
console.log("should be 6", ++_core.Map);

and outputs "should be 6 NaN" instead.
It's a bit esoteric of an example, but turning on coreAliasing in a project of mine caused tons of things to break because I had a function named "Symbol" that differed from ES6's, and my own locally-defined (not a global) Map polyfill which supported using immutable objects as keys, and now 6to5's polyfilled Symbol and Map were used instead of the local variables.

Fixed as of 2.13.7, thanks!


Add cards per booster functionality

Added cards per booster functionality as there are cubes that vary in pack size.

Thank you for your contribution!
Since this setting is only used for cubes, it should be part of the Custom Card List section and disabled when custom sheets are in use. I can merge this and make these changes myself if that's ok with you.

That 100% works for me.
The goal was to have a UI element after using "Import from CubeCobra" To allow setting cards in the pack.
I'm happy if it's just disabled until it's actually needed.


381-fix-hic

Fixes #381

@adamjtaylor looks like that last PR came from my fork. All fixed for now!

@aditigopalan not urgent but just checking if you had any questions about the requested changes.

@aditigopalan not urgent but just checking if you had any questions about the requested changes.

Not at the moment!


Donate sats forwarded to anon

Description
Fix #1232 by donating any sats forwarded to anon.
Diff of item_act function:
@@ -61,6 +61,11 @@ BEGIN
             UPDATE users
             SET msats = msats + fwd_msats, "stackedMsats" = "stackedMsats" + fwd_msats
             WHERE id = fwd_entry."userId";
+
+            IF fwd_entry."userId" = 27 THEN
+                -- anon forwards go to rewards as donations
+                PERFORM donate((fwd_msats / 1000)::INTEGER, "fwd_entry"."userId");
+            END IF;
         END LOOP;

         -- Give OP any remaining msats after forwards have been applied

Additional Context
I initially wanted to include anon forwards in anon's stack in rewards. However, after looking in the code and considering the required changes, I think it's better to simply show them as donations.
I considered following approaches:
1. no changes to rewards query
In item_act, pretend that anon was zapped instead of adding forwarded sats to anon's balance. This would mean adding a row to ItemAct. But this would then mean that for anon forwards, three ItemAct rows are inserted (2x TIP + FEE) with their msats sum being higher than the zap itself. This might break some assumptions in queries but decreasing the amount of msats for the original TIP might as well.
So this approach seems to complicated for this requirement.
2. changes to rewards query
We could add a column  forwarded to the Donations table. Donations as part of anon forwards are marked with forwarded whereas normal donations are not. We then query the rows with forwarded set separately as part of anon's stack in the rewards query. This is a lot simpler but adds a column to Donations for something very specific.
Checklist
Are your changes backwards compatible? Please answer below:
Yes

Did you QA this? Could we deploy this straight to production? Please answer below:
tACK 3ca6fe1e

Tested zaps and custom zaps from custodial balance, from attached wallet and as anon
Tested replying as stacker and anon, editing as stacker
Tested posting as stacker and anon

For frontend changes: Tested on mobile? Please answer below:

Did you introduce any new environment variables? If so, call them out explicitly here:
No

Only 5016 sats were forwarded to anon:
SELECT SUM(msats * pct / 100) FROM "ItemForward"
JOIN "Item" ON "Item"."id" = "ItemForward"."itemId"
WHERE "ItemForward"."userId" = 27;

-- returns 5,015,980 as of today

Since anon zaps were included in rewards, rewards only missed these 5k sats.

Closing because this conflicts with #1195 so we will wait for #1195


refactor!(key_signature): rewrite keys method to return a Map

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 4 (100.0%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
1059

Relevant Lines:
1059

💛  - Coveralls


(FunctionClauseError) no function clause matching in Ecto.Schema.do_load/4

Hi!
I create in my collection unique index, after that insert raise error:
** (FunctionClauseError) no function clause matching in Ecto.Schema.do_load/4
    (ecto) lib/ecto/schema.ex:1171: Ecto.Schema.do_load(%Crawler.MongoLinks{__meta__: #Ecto.Schema.Metadata<:built, "links">, id: nil, link: nil}, %{id: :binary_id, link: :string}, {false, {:unique, "link"}}, #Function<21.13591161/2 in Ecto.Repo.Schema.postprocess/5>)
    (ecto) lib/ecto/schema.ex:1161: Ecto.Schema.__load__/6

My Schema:
defmodule Crawler.MongoLinks do
  use Ecto.Schema
  import Ecto.Changeset

  @primary_key {:id, :binary_id, autogenerate: true}
  schema "links" do
      field :link, :string
  end

  def changeset(link, params \\ %{}) do
      link
          |> cast(params, [:link])
          |> validate_required([:link])
#          |> unique_constraint(:link)
  end
end

What ecto version are you using? What mongodb_ecto version? What mongodb version?
Could you also show the code that actually triggers the error?

:ecto, "2.0.6", "9dcbf819c2a77f67a66b83739b7fcc00b71aaf6c100016db4f798930fa4cfd47"
"mongodb_ecto": {:git, "https://github.com/michalmuskala/mongodb_ecto", "95f70999ddfbd0bc54958799cf0d4a9aa93b2b82", [branch: "ecto-2"]}
"mongodb": {:git, "https://github.com/ericmj/mongodb.git", "af98466040e368f4e7bd7da4f29f52641ddf30ac", [branch: "master"]},
def handle_cast({:put, links}, state) do
    Crawler.MongoRepo.insert_all(
	Crawler.MongoLinks, (for link <- links, do: %{link: link})
    )
    {:noreply, state}
end

It looks like it is failing because of the unique constraint. Specifically, it looks like one of your links has the value of nil (which, unlike SQL, Mongo will raise an error on for unique indexes) which is already stored in Mongo. Using insert_all/3 does not take advantage of your changeset/2 functions. It is meant to be a low level "just put data in my database" kind of tool.
Unfortunately, if you want to handle duplicate data gracefully, you are probably going to want to do something along the lines of this
def handle_cast({:put, links}, state) do
  for link <- links do
    %Crawler.MongoLinks{}
    |> Crawler.MongoLinks.changeset(%{link: link})
    |> Crawler.MongoRepo.insert()
  end
end

This is unfortunate as it will call the database N times where N is the number of links you are trying to insert. The real problem is that Mongo doesn't really support transactions, so this adapter does not support Repo.transaction which means you cannot use Ecto.Multi.
With that being said, it may be possible to put something in place (again, even though Mongo doesn't truly support transactions) that would allow a limited use of Ecto.Multi. But that would need to be looked into.

Tnx! You code is work! But why my version did not work?
defmodule Crawler.MongoLinks do
  use Ecto.Schema
  import Ecto.Changeset

  @primary_key {:id, :binary_id, autogenerate: true}
  schema "links" do
      field :link, :string
  end

  def changeset(link, params \\ %{}) do
      link
          |> cast(params, [:link])
          |> validate_required([:link])
          |> validate_format(:link, ~r/\/[^\/]+/)
          |> validate_length(:link, min: 1)
          |> unique_constraint(:link)
  end
end

recs =
    Enum.uniq(links)
    |> Enum.filter(fn (link) ->
        Crawler.MongoLinks.changeset(%Crawler.Links{}, %{link: link}).valid?
    end)
    |> Enum.map(fn link -> %{link: link}  end)

Crawler.MongoRepo.insert_all(Crawler.MongoLinks, recs)

Are you absolutely positive that is the query that is being run? When I run a very similar query, I get a different logged result.
Repo.one(from u in MyApp.User, where: u.email ==<EMAIL_ADDRESS>select: count("*"))
[debug] QUERY OK db=11.8ms
COMMAND [count: "users", query: %{email<EMAIL_ADDRESS>[]
1

If you run that exact query in iex, what do you see?

This is my error. I am write Crawler.Repo.one(q) > 0 instead of  Crawler.MongoRepo.one(q) > 0
Tnx!


special case when width / height < 0 (not 1)

Rect should be drawn to the left when width/height < 0 (not < 1).
Without this change, in cases where the viewport is such that a rectangle can have width / height < 1, the box will not be drawn correctly.
See this example:
https://codepen.io/jluxenberg/pen/ZyejWd

Thank you very much! And sorry for the delay


Plugin is not working in 1.19+ servers with ProtocolLib installed

I think it is related to this: https://github.com/dmulloy2/ProtocolLib/issues/2268
Nothing changes: motd, sample and everything else remains minecraft default when protocollib is added to the server

Maybe because protocollib is overriding the motd. We cannot solve this.


Game over crashing the game

Describe your bug here.
The game just crashes when you die in a song, i even tried importing mods that already run on the psych version this is built off of and they still crash
Command Prompt/Terminal logs (required)
.

Are you modding a build from source or with Lua?
Lua
What is your build target?
Windows
Did you edit anything in this build? If so, mention or summarize your changes.
no

nvm lol

actually yeah it still happens


Allow multiply output types and add new output type "ast".

Now options.output may be an array of supported output types. Output types is:

parser
source
ast (new)

If output types are an array, buildParser returns object whose keys are array elements, and values -- the appropriate results of generation.

I have two questions:

Why would you like to add the ast output type?
Why would you like to produce multiple outputs?

I have the command prompt utility for parsing some input just giving input and grammar. When debugging possibility of import of grammar I needed to see both AST, and the source code of the generated parser -- therefore I added opportunity for one pass to generate all necessary information.
Except that AST can it is useful in the analysis of grammar, for example when making IDE.

If you want multiple things returned from the parse, you can construct and return an object in the starting rule action with all of the things you need (including the AST you constructed) as that object's properties.

If you want multiple things returned from the parse, you can construct and return an object in the starting rule action with all of the things you need (including the AST you constructed) as that object's properties.

For this purpose the grammar shall be in a special way prepared that is impossible in case of foreign grammars. Besides, unless any reasons for obvious feature are required? If it not evolution, what then?

@Mingun The use case you describe is valid, but it’s developer-centric (as opposed to user-centric) and not common enough to warrant complicating the public API.
The API extensions you propose also don’t feel right to me for two reasons:

They expose what a developer-level API (the AST format) in user-level function (PEG.buildParser). I think it’s better to have it somewhat hidden and accessible only via plugins.
They replace a simple input → output workflow with something more complicated without a significant gain.

It’s fairly easy to accomplish your goals without the extensions:

You can teach PEG.js to produce the AST as an output by writing a simple plugin which would replace code generation compiler passes with something close to a no-op.
Similarly, you can write a plugin to produce multiple outputs when desired. Or simply run PEG.buildParser multiple times.

Given all the above I’m closing the PR.

They expose what a developer-level API (the AST format) in user-level function (PEG.buildParser). I think it’s better to have it somewhat hidden and accessible only via plugins.

Hmm... but users of PEGjs is developers, so, developer-level === user-level, are not it?

It’s fairly easy to accomplish your goals without the extensions:

Yes, it is possible, but users which the developers using PEGjs for the analysis of grammar will find it less convenient than if this function was realized directly in library.

Hmm... but users of PEGjs is developers, so, developer-level === user-level, are not it?

By user, I mean someone who wants to use PEG.js to write a grammar, generate a parser, and mostly forget about it. By developer, I mean someone who wants to use it in more advanced ways or to extend it.
Needs of these two groups are very different. And there are much more users than developers.

It’s fairly easy to accomplish your goals without the extensions:

Yes, it is possible, but users which the developers using PEGjs for the analysis of grammar will find it less convenient than if this function was realized directly in library.

Yes, but this has to be balanced with simplicity for users.

By user, I mean someone who wants to use PEG.js to write a grammar, generate a parser, and mostly forget about it.

In that case enough cli utility will be it, they at all won't invoke PEG.buildParser, or perhaps even won't know at all that it is a js-script.

Yes, but this has to be balanced with simplicity for users.

How extension of option will affect complexity for users? You say that it is necessary for them only generate parser, and it doesn't require supply any options and doesn't even call PEG.buildParser because they will be use cli utility.

By developer, I mean someone who wants to use it in more advanced ways or to extend it.

I think, 'more advanced way' will often demand access to AST, and for perfomance -- opportunity to receive as much as possible information for one call. For example, I have grammars, building parser on which takes 30 seconds and more. So, repeated calls to PEG.buildParser for different kinds of output thus are unacceptable, and creation of a special plug-in only complicates use, but doesn't simplify it.
I agree that uncommon things, like support of a new language for actions or a new type of a output, have to be implemented in plug-ins, but useful simple things which are already implemented, but have no public simple API, must be provided by the library, I think.

By user, I mean someone who wants to use PEG.js to write a grammar, generate a parser, and mostly forget about it.

In that case enough cli utility will be it, they at all won't invoke PEG.buildParser, or perhaps even won't know at all that it is a js-script.

Judging by incoming e-mails, issues, etc. many users use the JavaScript API.

Yes, but this has to be balanced with simplicity for users.

How extension of option will affect complexity for users? You say that it is necessary for them only generate parser, and it doesn't require supply any options and doesn't even call PEG.buildParser because they will be use cli utility.

It would complicate the documentation (which users pretty much have to read) and make the API surface bigger (think of a content of a tooltip offered by some IDE for PEG.buildParser arguments — assuming the IDE has e.g. a solid TypeScript PEG.js API definition available).
Also, I try to make the CLI functionally equivalent to the JavaScript API so at least the ast output type would have to be supported there (multiple outputs probably wouldn’t make sense).

For example, I have grammars, building parser on which takes 30 seconds and more. So, repeated calls to PEG.buildParser for different kinds of output thus are unacceptable, and creation of a special plug-in only complicates use, but doesn't simplify it.

Performance problems of this nature isn’t a reason to change the API but to optimize the generator performance.

I agree that uncommon things, like support of a new language for actions or a new type of a output, have to be implemented in plug-ins, but useful simple things which are already implemented, but have no public simple API, must be provided by the library, I think.

And I disagree :-)
(This is my last comment on this topic.)