Don't write out the cabal file if it matches the old one

The motivation behind this change is avoid the --force option from triggering an unnecessary reload of ghcid if nothing changed.
The context is that at work we use hpack --force to correct manual edits that users might make to the .cabal file, and we run hpack --force whenever users enter our Nix shell.  If a user uses direnv on top of that then hpack --force runs every time they cd to the project directory.
However, suppose that they load ghcid in one window and then cd to the project directory in another window.  This causes hpack --force to run and even if nothing changed the mwb.cabal file is touched which causes ghcid to reload (which is expensive).  This change fixes that.

Note that I could also structure this to check if the new/old cabal files are textually identical instead of the abstract syntax being identical.  However, that would be a slightly more invasive change so I wanted to propose this first to solicit feedback.

we run hpack --force whenever users enter our Nix shell.

What is the reason that you use --force in the first place? If you can remove the --force option then I think things would already work for your use case.
Do you have a modification hash in the degenerated .cabal file? If yes, then run hpack --no-hash --force once to get rid of it. After that hpack should work just fine, even with manual modifications and without --force.
Or is it, that you use different versions of hpack across the team?

Note that I could also structure this to check if the new/old cabal files are textually identical instead of the abstract syntax being identical.

Yes, if we do anything here, then we would want textual comparison. But please hold back for a second.  This code is already more complicated than it should be. We might want to remove support for modification hashes (and possibly even the hpack min version check) first, before doing anything here.

@Gabriella439 please take a look at https://github.com/sol/hpack/pull/557.  Does this work for you?

Yeah, #557 looks good to me.  To answer your prior question, we would use --force so that if the user made any manual modification to the .cabal file then we'd correct and override that modification.

#560


wdio-electron-service does not work when contextIsolation is false

which, most likely, it is still true when rephrased like ' wdio-electron-service cannot be used for most of the existing (big) projects' or
'wdio-electron-service can be used only on new electron projects'
If I try to use wdio-electron-service with contextIsolation: false, I get an error like 'contextBridge needs contextIsolation to be true' and nothing works.
This is happening because the below code uses contextBridge
https://github.com/webdriverio-community/wdio-electron-service/blob/main/src/preload.ts
But if I put contextIsolation: true for getting wdio-electron-service to work I get another error like 'require function not defined' and nothing works. This is happening because I have an existing project where the require function is needed and this project cannot be easily updated as per the latest Electron security best practices (this will be done but it will take a longer period of time to migrate all the existing code).
I understand that the newer versions of Electron, for security reasons, strongly recommends having contextIsolation:true and this is good for new projects but for older and bigger projects it takes more effort to update all the existing code which means that many times people will use contextIsolation:false for such projects.
I believe that wdio-electron-service should work no matter if contextIsolation:true or contextIsolation:false since your library should enable people to use webdriver.io in electron no matter if contextIsolation:true or contextIsolation:false (people will use this flag not because they want to but because for existing projects, they have no other choice).

@distributev Thanks for your report, however I have limited time to maintain this service and whilst I am sympathetic to legacy uses of Electron - contextIsolation has been defaulted to true in Electron since v12 and the Electron security guidelines exist for a reason.  I'm happy to accept PRs which address this concern as long as they cover both use cases, which should be forthcoming fairly soon if as you say, "most of the existing (big) projects" are explicitly switching this security feature off.


Add-AzureRmMetricAlertRule: Should parameter 'description' be mandatory?

Add-AzureRmMetricAlertRule parameter Description is mandatory but creating an alert (classic) within the azure portal is not mandatory.
This means in the scenario of copying an existing rule where there is no description (i.e. it was created without a description within the portal) fails parameter validation for the cmdlet given the properties are mapped.
GET THE RULE
$rule = Get-AzureRmAlertRule -ResourceGroupName $RG
RE ADD THE RULE
    Add-AzureRmMetricAlertRule `
        -ResourceGroupName $RG `
        -TargetResourceId $rule.Condition.DataSource.ResourceUri `
        -Location $rule.Location `
        -Name $rule.AlertRuleResourceName `
        -Description $rule.Description ` <-- This is null, causing validation to fail
        -MetricName $rule.Condition.DataSource.MetricName `
        -Operator $rule.Condition.OperatorProperty `
        -Threshold $rule.Condition.Threshold `
        -WindowSize $rule.Condition.WindowSize `
        -TimeAggregationOperator $rule.Condition.TimeAggregation

This looks like a product bug/reference issue. Can you please file a ticket on the engineering product? https://github.com/azure/azure-powershell/issues/


bootstrap-vcpkg should not rebuild vcpkg if nothing has changed

bootstrap-vcpkg always rebuilds vcpg executable
Port updates and source-code  of vcpkg are in the same repository. Our build-system is updating the repository regularly and sometimes vcpkg is not working anymore. It seems like vcpkg source-code has changed and a rebuild is needed. Therefore we added the bootstrap-vcpkg script to the build. This solved the out-of-date problem but now vcpkg is rebuild very often.
Proposed solution
Just rebuild vcpkg if the repository has changed.
Describe alternatives you've considered
Store the has of the repository and run bootstrap-vcpkg only if the hash has changed.

Related: #13738.

Since vcpkg published binary executable on Windows, this issue just related to non-Windows.


AdyenCheckout is blocking in Safari V14

Describe the bug
The AdyenCheckout function is blocking the web. This behavior is happening only in Safari V14, but looks fine in Chrome, Firefox or Safari V16 and the payments can be done correctly.
This behavior appears in local and in the production webapp.
To Reproduce
Go to webapp where this function is applied.
Expected behavior
The AdyenCheckout component is working correctly
Screenshots

Smartphone (please complete the following information):

OS: iPhone 12 mini
Browser Safari
Version 14.3

I can't reproduce this issue @sonegs . I tested with iPhone 12 mini and iPhone 12 Pro Max, Safari 14.3 . It works as expected.
I opened the https://www.mystoredemo.io/#/ and performed the checkout without any issue.
Did you check the errors in the browser in the dev tools? Please check and share, so we can investigate further

I tested in other devices too, and I couldn't manage to reproduce the issue.
I am using Browserstack for that, which simulates using real devices

iPhone 11 v13.3
iPhone 11 Pro Max v14
iPhone 14 v14.7

I am not sure how to reproduce this!

Looks like a problem related with the sandbox paypal environment. I have check it in the PROD environment with a physical device and the problem is not appeared. @longyulongyu @ribeiroguilherme


Varnish 4.0 incompatibility

This vmod doesn't compile on 4.0. Either it should be made compatible with 4.0, or its minimum requirement of 4.1 should be made explicit. Right now the build fails ungracefully: https://gist.github.com/gi11es/5b55347a9888596fda74

Hi. This is on purpose.
Please upgrade to the latest version of Varnish Cache.

Did you read the body of my issue? I'm fully aware that the current code is incompatible. But this version dependency isn't documented anywhere. It's not even mentioned in the README. Hence there is no way to know that this is intentional.

Hi.
You're right, it isn't very well explained. I've added a note of it now.
Thanks for bringing it to our attention.

@lkarsten If we want to restrict it to >= 4.1 and trunk I have a patch.
Alternatively I could check if the define is present.

Adding a configure check sounds good.
We should apply it to vmod-example first, probably?

But wouldn't this restrict the example vmod unnecessarily?  My understanding of the example vmod is that it should be generic.  It should be the author who decides what the minimum requirements are.

I don't see an issue here; this is just another versioning check, like sufficiently new pcre or libmemcache.
Add a comment on the preceeding line saying how to disable it.

If we were to add it I think it'd make more sense to have it disabled by default.
People are not based their project in Varnish (pcre) or a specific vmod (memcached).
That said I don't particularly mind as long as we address the requirement in heere.

Closing, the VMOD now lives in varnish-modules.


Fix unit tests

Fix GetUnreadMessagesCountWithTimeoutUseCase unit tests.
Also, downgrade the Mockito version for UI tests to be able to run them on API 24.
MOB-1996

!merge


Colour Palette Generator

@orchetect I have an interesting idea. I am not sure if it is feasible with our tool. This idea is inspired by ShotDeck.
In ShotDeck, all the images have a colour palette generated dynamically.

I wonder if we can achieve something similar. It could be something like --enable-colour-palette. Once enable the tool would analyse the dominant colours from image and append the colour palette it to the bottom of the image. We can add options, on how maybe palette it should generator.
For example -

I found some open source projects that does this.
https://github.com/bd452/swift-vibrant
https://github.com/yamoridon/ColorThiefSwift
https://github.com/elliotekj/distil
https://github.com/Boris-Em/ColorKit
Use cases -

Referencing during colour grading
Cinematography and Shot List Database

Image post-processing aside from the existing text labelling capabilities of MarkersExtractor is kind of outside the scope of the core purpose of MarkersExtractor. The library already has a lot of parameters and not enough unit testing as is to even check a small fraction of them currently. I would like to avoid adding optional features that could be accomplished by other means.
For your own use, conceivably a dedicated CLI tool must exist (perhaps at one of those repos) that can modify image files with these swatches. If it doesn't accept a folder or multiple files via command line arguments, a simple bash script could iterate through all image files in the output folder after MarkersExtractor runs.
If you're intent on adding post-processing like this to Marker Data then perhaps one of these libraries could be integrated in the application instead of MarkersExtractor itself.

Image post-processing aside from the existing text labelling capabilities of MarkersExtractor is kind of outside the scope of the core purpose of MarkersExtractor. The library already has a lot of parameters and not enough unit testing as is to even check a small fraction of them currently. I would like to avoid adding optional features that could be accomplished by other means.

No doubt it would be a cool and productive feature. Yes, it does seems outside the scope of our MarkersExtractor library.

If you're intent on adding post-processing like this to Marker Data then perhaps one of these libraries could be integrated in the application instead of MarkersExtractor itself.

Having a post-processing method for Marker Data could be one way to add this feature. I can look into this at some point once Marker Data is release to public.

If you want to pursue that, go ahead. But this would be a low priority feature for MarkersExtractor as there are many more pressing issues.

If you want to pursue that, go ahead. But this would be a low priority feature for MarkersExtractor as there are many more pressing issues.

Absolutely!


Blacklist subs and users

Several users have requested the bot doesn't run on subreddits or for their posts.
Create new files blacklist_subs.txt and blacklist_users.txt house all blacklisted users and subs.

Unless we want to work on stronger message and comment checking, this needs to be a manual process.
I don't want the bot deciding what is and isn't appropriate for this context.


untested warning for is_subscription

Hi, I'm getting an untested warning for PayPalStandardBase.is_subcription()
paypal.standard.models:286: This method (or branch) is not covered by automated tests. It is therefore very vulnerable to being accidentally broken by future versions of django-paypal. Please contribute tests to ensure future functionality!

The method itself is just one line:
    def is_subscription(self):
        warn_untested()
        return len(self.subscr_id) > 0

So I wonder what kind of test would be needed for this. Or if it's pointing to the more generic subscription logic?

Hi, @newearthmartin I am new to this repo and interested. Is this something I can look into and try solving or was it fixed? and Is there any contributing guide?

@spookylukey care to answer to this new contributor @VinneyJ ?

Thanks a lot, @spookylukey let me dive in and check it out.


Attribution for TileLayer

The attribution for TileLayer(source: XYZ) doesn't display at Map.
Attribution seems to not forwarded from Layer to Map.
ol v. 6.1.1 building via webpack.
To Reproduce
Add TileLayer source: XYZ to map.
let osm = new TileLayer({
  title: 'OSM',
  source: new XYZ({
    url: 'http://local_server/mapy/tiles//{z}/{x}/{y}.png'
  }),
  description: 'OpenStreetMap',
  baseLayer: true,
  visible: true,
  attributions: ['© autors - OpenStreetMap']
});

let watercolor= new TileLayer({
    title: 'Watercolor',
    source: new Stamen({
      layer: 'watercolor',
      displayInLayerSwitcher: true
    }),
    description: 'Mapa renderowana jako akwarela',
    baseLayer: true,
    visible: false
});

let map = new Map({
  target: 'map',
  layers: [osm, watercolor],
  view: new View({
    center: [2577400.0, 7006750.0],
    zoom: 14
  }),
  controls: defaultControls().extend([scaleline, attribution])
});

But Tilelayer as Stamen is proper display with default attributions.

Problem is with handed set XYZ source, I think.

Expected behavior
Fix display atribution from TileLayer(source: XYZ).

Hi @Bear4, you need to set the attributions to the source instead of the layer

Thanks!


AM/PM?

Any way to do AM / PM? Instead of 24 hour military time?

https://github.com/EmilYo/HSDatePickerViewController/issues/3


High TTFB

On a fresh laravel app, response is fine.
However, after adding this to a tailwind-themed app, my TimeToFirstByte is above 2seconds.
I tried to just make a basic modal, no model-queries, just plain.
I'm currently using Laravel 8 with custom theme using TailwindCSS + JIT.
Not sure how to debug the network-transfer part, but chrome dev-tools only points to
laravel-ui-modal
Duration4.67 s (4.67 s network transfer + 0.47 ms resource loading)

So once the open-modal link is clicked, it takes at least 4 seconds before it actually shows.
I could be doing something wrong but not sure how to determine more and address this.
Also, apologies if this is not the right place to write this, and point me to the appropriate channel. Thanks

Hi @blhi-jed
I would recommend installing something like Clockwork to figure out what is going on under the hood and see what is causing the latency issue. Given it works fine with a fresh Laravel installation, the issue must be created by a different third-party package.

I was thinking maybe if there where multiple components setup for the modal in once instance of a page, like in a loop, or on any part of the page, e.g. a modal in the header, or somewhere else, but ok i will investigate and let you know. Thanks for the clockwork link, my first time to see this, will report back.

Closing this issue, for now, let me know if the cause is related to this package.

hi @PhiloNL i found the cause, and it was the blade-icons package not being cached. This is irrelevant to your package.
I didn't notice that blade-icons had a caching function.
Livewire-UI modal is awesome. Thank you.

Hi @blhi-jed glad you found the issue. I'm happy to hear you like the Livewire UI modal 😄


Editing cells is not working well.

Sometimes I have to click 4 times to end up in the cell to edit the cell. Sometimes, when the cursor appears the cell gets deactivated for no obvious reason and has to be selected again. Is that normal or is there rather something wrong with my setup?
I use 'editor'='input' in the column definition.

Have you registered any other callbacks?
If you look at
https://github.com/preftech/dash-tabulator/blob/2e7ff92d4446c79a05e6dd71d01593a1aa0eafc6/src/lib/components/DashTabulator.react.js#L68
In order to make cellEdit work I have to disable rendering using
this.shouldRerender = false;

Otherwise render() will redraw the object on the screen and interrupt the editor interface.

Have you registered any other callbacks?
If you look at
https://github.com/preftech/dash-tabulator/blob/2e7ff92d4446c79a05e6dd71d01593a1aa0eafc6/src/lib/components/DashTabulator.react.js#L68
In order to make cellEdit work I have to disable rendering using
this.shouldRerender = false;

Otherwise render() will redraw the object on the screen and interrupt the editor interface.

Just noticed #26 this might be caused by having an older version of dash-tabulator
Try upgrading first
pip install dash-tabulator -U

Just noticed #26 this might be caused by having an older version of dash-tabulator
Try upgrading first
pip install dash-tabulator -U

Ok, works much better!!

Ok, works much better!!


binn_map() and binn_create(BINN_MAP) create different outputs

This code produces hex output: e10f02000000022001000000032001
uint8_t out[1000];
binn* obj = binn_map();
binn_map_set_int16(obj, 2, 1);
binn_map_set_int16(obj, 3, 1);
memcpy(out, binn_ptr(obj), binn_size(obj)); //  << the said output

However, this code produces the following hex output: 306000009dc8e10f02000000022001
uint8_t out[1000];
binn obj[1];
binn_create(obj, BINN_MAP, 1000, out);
binn_map_set_int16(obj, 2, 1);
binn_map_set_int16(obj, 3, 1);
// now the out[] contains the said output

The consequence:
// in the first case
binn_load((void*)out); // << works
binn_load((void*)(out + 6)); // << fails

// in the second case
binn_load((void*)out); // << fails
binn_load((void*)(out + 6)); // << works

From the outputs I see the data is arranged in different order:
1: e10f02000000022001000000032001
2: 306000009dc8e10f02000000022001
Is that normal? If so, how could one know when the data starts without calling binn_load() twice?

Hi mannol
To get the content of the binn we must always use the binn_ptr function. In your second example you are not using it.
Note that the binn header in the serialized data output has a variable size depending on the amount of data it has inside, so the binn_ptr function will return a pointer inside the buffer that don't need to be the start of the buffer.
In your example the binn_ptr will return a pointer to out + 6 (as you have tried bellow. Good catch!). The initial bytes are  not used in this case.
You should not use (out + 6) too. Always use the start of the buffer, either the one returned by the binn_ptr function or a copy of the returned buffer in another app.
There are some usage examples here in the repo.

So the second example should be something like:
uint8_t out[1000];
binn obj[1];
binn_create(obj, BINN_MAP, 1000, out);
binn_map_set_int16(obj, 2, 1);
binn_map_set_int16(obj, 3, 1);
do_something(binn_ptr(obj), binn_size(obj));
binn_free(obj);

OK. Notice also that you don't need to use the binn_load function.
The read functions can read values directly from the serialized buffer.
Example:
...
char *buffer = binn_ptr(map);
short value = binn_map_int16(buffer, 2);
...

@kroggen That's interesting. Is the map/object key lookup in linear complexity?

Yep, it uses a linear search so the binn code is simpler and smaller.


vulnerability  Problems

IMPORTANT: Be sure to replace all template sections {{ like this }} or your issue may be discarded.
Overview
the components in 9.0.0 whl package has many vulnerabilities.
openjpeg 2.3.1 (The latest is 2.4.0 you can upate to 2.4.0 to fix)
CVE-2020-8112
CVE-2020-27844
CVE-2020-27823
CVE-2020-27814
CVE-2020-6851
CVE-2020-15389
CVE-2020-27843
CVE-2019-12973
CVE-2020-27841
CVE-2020-27824
CVE-2020-27845
CVE-2020-27842

ffmpeg 4.3.3
CVE-2020-35965
CVE-2021-38291

gnutls 3.6.16
CVE-2021-20232
CVE-2021-20231

libgmp 6.2.1
CVE-2021-43618

wavpack 5.3.0
CVE-2020-35738

Expected behavior
Clear or update some components to the latest one
Investigation
{{ What you did to isolate the problem. }}
Reproduction
{{ Steps to reproduce the behavior. If the problem is media specific, include a link to it. Only send media that you have the rights to. }}
Versions

OS: linux
PyAV runtime: 9.0.0

Research
I have done the following:

[x] Checked the PyAV documentation
[x] Searched on Google
[x] Searched on Stack Overflow
[x] Looked through old GitHub issues
[x] Asked on PyAV Gitter
[x] ... and waited 72 hours for a response.

Hi @wqh17101 thanks for reporting this. Could I ask how you compiled this list, as I'd be keen to integrate this into CI?

openjpeg : PR is here https://github.com/PyAV-Org/pyav-ffmpeg/pull/45
gnutls: PR is here https://github.com/PyAV-Org/pyav-ffmpeg/pull/46
wavpack: PR is here https://github.com/PyAV-Org/pyav-ffmpeg/pull/47
gmp: there doesn't seem to be a more recent version?
ffmpeg: this one's going to be trickier, we have some CI issues with FFmpeg 4.4.x see #876

Something like https://github.com/intel/cve-bin-tool.
And when will this PR be merged and release a new version.

What PR are you talking about? Each PR takes about 12 hours for CI to complete.
I can already see the gnutls change breaks the build so it's unlikely to be merged without further work. I don't have PRs for GMP (you didn't reply: what's a non vulnerable version) or for ffmpeg

You can get some information at https://nvd.nist.gov/vuln/detail/CVE-2021-38291. Just replace the CVE code in the url.
For ffmpeg 4.4.x can fix CVE-2020-35965 ,maybe also can fix CVE-2021-38291
For  GMP ,the latest is 6.2.1 , so there is no way now to fix. But for the detail ,CVE-2021-43618 only can be triggered on  32-bit platforms.
For gnutls , 3.7.1 and above can fix CVE-2021-20232,CVE-2021-20231.
Also you can make a issue to GMP or ffmpeg to confirm the detail. All the things above is my conclusions from NVD page.

Update:

gmp: PR is here https://github.com/PyAV-Org/pyav-ffmpeg/pull/49 (I applied a patch since there doesn't yet seem to be a release with the fix)
ffmpeg: I don't think the FFmpeg version we use (4.3.3) has the two vulnerabilities you mentioned. Grab a source tarball and examine libavcodec/exr.c and you'll see the fixes are already present

I'm letting CI run but should be able to get fixed wheels in PyPI soon.

@jlaine awesome, i think you can list this in the doc about your componets and vulnerabilities


[Feat][CI] Enable markdownlint and typos in Graphar Doc workflow

Describe the enhancement requested
In the workflows/docs. yml file, there are some TODO item has not been completed. Someone needs to complete these TODO items.
here
Component(s)
Continuous Integration

Hi, @ywh555hhh, Do you want to help to implement the feature?

I can try, but I may not start until next week. This week, I am preparing the application for CLI for GraphAr project

I can try, but I may not start until next week. This week, I am preparing the application for CLI for GraphAr project

Thanks very much. This is not urgent issue so it'ok to work on your own schedule and feel free to ask if you have any question.


docs(project): add note on audit fixes

Let's add it to https://github.com/camunda/camunda-modeler/blob/ea73385ec8a151b95f876f9cbb3b11776637e887/docs/.project/PATCH_RELEASE_TEMPLATE.md too

I also added it to the current Issue: https://github.com/camunda/camunda-modeler/issues/3919

@barmac Added to patch via https://github.com/camunda/camunda-modeler/pull/3930/commits/72902dcae05d32b46b4ff0a31f44dbec64353bc9, too.


versionbot merged without tagging in special case

To reproduce:
Have a PR in a non-mergeable state, select ready to merge, v-bot then tags and commits new tags. Then force push the rebased master so it is mergeable, vbot then merged and deletes branch.
See here: https://github.com/resin-io-modules/resin-components/pull/100

I think this might be down to the fact that none of the VB status checks were 'Required' on the repo, but I'll see if I can recreate it at some point! Thanks Craig!


Don't repeat _initBody definition

Would you be open to a PR to avoid the duplication between here https://github.com/github/fetch/blob/master/fetch.js#L129 and here https://github.com/github/fetch/blob/master/fetch.js#L178, or is there a good reason for it?

It's not duplicated, it's inside an if/else clause...

The difference is an additional check for support.blob here https://github.com/github/fetch/blob/master/fetch.js#L133 but from what I can tell this patch would cover both cases. There's no reason to have similar blocks of code in here twice when it can live in one place.

Yep, and _initBody checks for support.blob internally anyway before it
tries to create a blob
On Mon, 4 May 2015 at 3:02 pm Matt King<EMAIL_ADDRESS>wrote:

The difference is an additional check for support.blob here
https://github.com/github/fetch/blob/master/fetch.js#L133 but from what I
can tell this patch would cover both cases. There's no reason to have
similar blocks of code in here twice when it can live in one place.
—
Reply to this email directly or view it on GitHub
https://github.com/github/fetch/issues/135#issuecomment-98716044.

is there a good reason for it?

The second clause defines support for IEs that don't support blob.


Can't use NFS as persistent storage

Hi,
I am trying to use an NFS share for persistent storage. I have make sure it is writable and accessible. But everytime I deploy a workload using the volume, I got this error message:
I0506 18:07:22.164449       1 event.go:218] Event(v1.ObjectReference{Kind:"PersistentVolumeClaim", Namespace:"labms", Name:"emby", UID:"60e24e20-5138-11e8-a46b-bac507c4c848", APIVersion:"v1", ResourceVersion:"127960", FieldPath:""}): type: 'Warning' reason: 'VolumeMismatch' Cannot bind to requested volume "embyvol01": incompatible accessMode

Useful
Info

Versions
Rancher v2.0.0 UI: v2.0.41

Access
local admin

Route
authenticated.cluster.storage.persistent-volumes.index

This UI issue has been fixed. Please try rancher/rancher:v2.0.4


Add proto validation for Providers

Summary
Ref https://github.com/stacklok/minder-stories/issues/94
Change Type
Mark the type of change your PR introduces:

[x] Bug fix (resolves an issue without affecting existing features)
[ ] Feature (adds new functionality without breaking changes)
[ ] Breaking change (may impact existing functionalities or require documentation updates)
[ ] Documentation (updates or additions to documentation)
[ ] Refactoring or test improvements (no bug fixes or new functionality)

Testing
Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.
Review Checklist:

[x] Reviewed my own code for quality and clarity.
[ ] Added comments to complex or tricky code sections.
[ ] Updated any affected documentation.
[ ] Included tests that validate the fix or feature.
[ ] Checked that related changes are merged.

coverage: 54.773% (+0.003%) from 54.77%
when pulling 8b695e6bd551791496849eef5ee7d54b357f85f5 on validate-prov
into 67bd38d9a35e26a19041c1084a4f0be91c06ea82 on main.


When salsah-gui:guiOrder is not define for a property, the property is not displayed

Describe the bug
When salsah-gui:guiOrder, which should ideally be defined for each property is not define, then the property is not displayed at all, which is very strange because you can see the actual property displayed as a search criteria in the advanced search. And if you select this property, you will even see it displayed in the search results. But it disappears once you open a resource.
To Reproduce Steps to reproduce the behavior:

See the screenshot 1 for the advanced search criteria to reduce the bug.
Check the results in screenshot 2.
See the actual resource displayed without the property in screenshot 3.

OPTIONAL: Expected behavior
In Salsah 1.5, the properties are displayed anyway without paying attention to their order. I think this is the correct behaviour: not every project will use knora-app, or knora-ui to build a GUI. I don't think they will bother to define each salsah-gui:guiOrder in their ontologies, so I think these properties should be displayd anyway.
Screenshots

The same resource in Salsah 1.5

Desktop (please complete the following information):

OS: macOS 10.14.6 (18G103), French
Browser Firefox
Version 70.01.1

Additional context
Add any other context about the problem here.

this issue has been moved to YouTrack: DSP-349


Define profile specific sub-property of dct:subject

Problem statement
The generic property dct:subject is used for specific code list "Topic categories in accordance with EN ISO 19115"
(see B.6.8.1 Topic category and keyword in datasets and dataset series).

Correct assignment of usage notes, labels and required code lists rather difficult, as well as validation
not in line with guidelines of SEMIC Style Guide

Reuse of a property with terminological adaptations or
Reuse of a property with semantic adaptations.

Even more problematic in a cross-profile environment - incompatible requirements can be easily made

Proposal
Introduce subproperty of dct:subject geodcatap:topicCategory for "Topic categories in accordance with EN ISO 19115" code list.

Posponed until the next webinar

For info, currently, in Flanders (Vlaanderen) the categorisations ISO category, INSPIRE theme and GEMET concept are mapped to a dct:subject subproperty for datasets:

property
URI
GeoDCAT-AP
GeoDCAT-AP Vlaanderen

ISO Categorie
http://data.vlaanderen.be/ns/metadata-dcat#ISO-categorie
dct:subject
subproperty dct:subject

INSPIRE thema
http://data.vlaanderen.be/ns/metadata-dcat#INSPIRE-thema
dcat:theme
subproperty dct:subject

GEMET concept
http://data.vlaanderen.be/ns/metadata-dcat#GEMET-concept
dcat:theme
subproperty dct:subject

We had a discussion about this issue (Czech Office for Surveying, Mapping and Cadastre and Czech Environmental Information Agency) and we agree with the proposal - to create new subproperty of dct:subject.


Required fields and browser validation

Apparently, when a textarea having the required attribute is powered by TinyMCE, browser validation (Firefox tested) is preventing form submission, as the textarea itself is considered empty by the browser.
This can be workarounded by using TinyMCE(attrs={'required': False}) as widget definition in the Django form. I've also seen some JS snippets trying to fix this.
Is this something django-tinymce should force doing?

I just wanted to add that I think I'm having a similar issue, described here:http://stackoverflow.com/questions/40662092/form-stopped-saving-to-database-after-textfield-was-changed-to-htmlfield
And unfortunately, using the 'required': False attribute did not help in my case...

I also eventually had to subclass the widget:
class TinyMCEWidget(TinyMCE):
    def use_required_attribute(self, *args):
        return False

Thank you very much, this does the trick.

+1


Enable VSCode Debugger for CloudFunction Development

We want to add VSCode settings so that developers can use VSCode's debugger function when developing "CloudFunctions"
This makes it easier for developers to identify the cause of problems and speeds up development.
If you agree, please approve the associated pull request.
Improvement details

Added debug configuration file for VSCode
Added ESBuid settings to enable debugging during development

LFG🚀


Lightbox bugs out with captions if any images lack "alt" attribute.

It's all there in the comments, though I'm unsure if it's also caused by an interaction with other functions. Basically, if any image is missing the "alt" attribute, the images will begin to "stack" as you move from one to the next.
EDIT: The above does NOT happen if the image has an empty alt attribute; however, the caption text persists rather than be replaced with an empty caption.

Thanks for the report, I can reproduce it, will look into it.


Bundle size increased from 7.3kb to 10.8kb in v1.6.2

This could be related to the dev dependencies being updated.

1.6.1<EMAIL_ADDRESS>1.6.2<EMAIL_ADDRESS>

Hi, I saw this was closed as completed but it's still the case with the latest version, which is c. 11.5KB. If you remove the useBuiltIns from the babel config it drops to 8.3KB, but compiles to es5 fine as far as I and es5-validator can see. If you also remove the legacy IE plugins and the uglifyOptions, then it drops to just under 8KB. That's over 30% smaller. I don't understand what useBuiltIns is doing - all it seems to end up doing is adding additional unnecessary polyfills and a lot of webpack boilerplate.


Error Auth with Google after update to 4.0.0-rc.1

Version info

Angular: 4.0.0
Firebase: 4.1.3
AngularFire: 4.0.0-rc.1
Other (e.g. Ionic/Cordova, Node, browser, operating system):
How to reproduce these conditions
Steps to set up and reproduce

Google Auth configured
Trying to authenticate with Google, will give an error

Sample data and security rules
<-- include/attach/link to some json sample data (or provide credentials to a sanitized, test Firebase project) -->
Debug output
{
 "error": {
  "errors": [
   {
    "domain": "global",
    "reason": "invalid",
    "message": "Error getting access token from GOOGLE_OIDC, request is: https://www.googleapis.com/oauth2/v3/token?grant_type=authorization_code&client_id=17398024509-4jghn3qqgeug06td1h77ms9cbn2u0da5.apps.googleusercontent.com&code=4/qviOJqMDYZq9BvwoUDRdPsmO9cxDr9I-tvKxlwQeIGI&redirect_uri=https://cf-studio.firebaseapp.com/__/auth/handler, response is: OAuth2TokenResponse{params: error=invalid_client&error_description=Unauthorized, httpMetadata: HttpMetadata{status=401, cachePolicy=NO_CACHE, cacheDuration=null, staleWhileRevalidate=null, filename=null, lastModified=null, headers=HTTP/1.1 200 OK\r\n\r\n, cookieList=[]}}"
   }
  ],
  "code": 400,
  "message": "Error getting access token from GOOGLE_OIDC, request is: https://www.googleapis.com/oauth2/v3/token?grant_type=authorization_code&client_id=17398024509-4jghn3qqgeug06td1h77ms9cbn2u0da5.apps.googleusercontent.com&code=4/qviOJqMDYZq9BvwoUDRdPsmO9cxDr9I-tvKxlwQeIGI&redirect_uri=https://cf-studio.firebaseapp.com/__/auth/handler, response is: OAuth2TokenResponse{params: error=invalid_client&error_description=Unauthorized, httpMetadata: HttpMetadata{status=401, cachePolicy=NO_CACHE, cacheDuration=null, staleWhileRevalidate=null, filename=null, lastModified=null, headers=HTTP/1.1 200 OK\r\n\r\n, cookieList=[]}}"
 }
}

Expected behavior
User should be authenticated successfully

@kobvel AngularFire2 simply gives you a initialize authentication object. If authentication isn't it's highly unlikely it's due to the library since you're using the core Firebase SDK. I recommend posting this on stackoverflow with more code to help the context of the problem.

Were you able to figure it out? I am stuck on the same thing!

@jamesdaniels no, I did not. And my Question was kindly closed

@jamesdaniels  I was able to fix it
Go to authentication tab in firebase console and under Google authentication there will be option to setup Web SDK configuration, setup that and you are good to go
Don't forget to the origin uri and redirect uri correctly


your full dataset

how to get your full dataset, is it available now?

@varrella , did you find the dataset in the end?

@varrella , did you find the dataset in the end?

No.

@fabrizioschiano No.

@sxontheway, can you please share the full dataset?


Get Ip from HTTP_X_FORWARDED_FOR if present, to handle proxies

Hi @ericgreenmix, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!
The agreement was validated by .NET Foundation and real humans are currently evaluating your PR.
TTYL, DNFBOT;

how does the iis integration mw do this?

Yeah, I think you are right about this. Got it working as middleware instead. That does seem like a better place. closing

Hi @ericgreenmix just wondering is this required, I was hoping that the framework set the RemoteIpAddress if that header or any of the other forward headers where used. What about all the other ones?
        //// "HTTP_X_COMING_FROM"
        //// "HTTP_X_FORWARDED_FOR"
        //// "HTTP_X_FORWARDED"
        //// "HTTP_X_REAL_IP"
        //// "HTTP_VIA"
        //// "HTTP_COMING_FROM"
        //// "HTTP_FORWARDED_FOR"
        //// "HTTP_FORWARDED"
        //// "HTTP_FROM"
        //// "HTTP_PROXY_CONNECTION"
        //// "CLIENT_IP"
        //// "FORWARDED"

Greetings Damien

We found with our nginx proxy to kestrel, we had to do the following...
app.Use(async (httpcontext, next) =>
{
    if (httpcontext.Request.Headers.ContainsKey("X-Forwarded-For"))
    {
        httpcontext.Connection.RemoteIpAddress = IPAddress.Parse(httpcontext.Request.Headers["X-Forwarded-For"]);
    }
    await next();
});

Ok thanks, wondering if this is a bug or per intention, IIS sets this


feat: create RLP::encode method

Feature Request
For computing the eth address of a contract, we need to compute the RLP::encode(deployer_address, deployer_nonce) and then hash it, and take the 20 least significant bytes.
Describe the Feature Request
Implement RLP::encode
Describe Preferred Solution
Related Code
The RLP library made by @Quentash
Additional Context
If the feature request is approved, would you be willing to submit a PR?
(Help can be provided if you need assistance submitting a PR)

[ ] Yes
[ ] No

Can I get this one?


Hide add button

Simple front-end change to hide_add_button. Someone else wrote the authentication line, so I am simply pushing this front-end change again.
fixes #216

This should fix it


Remove author name and website link

The GitHub repository link is sufficient.

It is not really harming anything. You don't gain anything by removing it instead the space will just stay empty.

The URL https://pedroborg.es/ causes NET::ERR_CERT_DATE_INVALID in Chrome.

ERR_CERT_DATE_INVALID

Sounds like the website is not maintained then cause that should not be out of date.

It has been like that for 4 years.


Support running tests from keyboard

It would be nice if current test can be invoked from keyboard instead of codelens only.
Basically context requires two options like: Run current test, Run current test class.
This https://github.com/Microsoft/vscode/issues/41579 could implement feature, but dunno when (if never) it will be implemented to vscode.

Thanks @savpek. We're tracking this feature with https://github.com/OmniSharp/omnisharp-vscode/issues/421.


responsive image

not really an issue, more of a question.
is baseline set up to handle responsive imaging? if not, what do you recommend?

"Responsive "(as in sizing images to fit) is supported using the image class and a wrapping element (eg. ). True responsive image handling will be a thing when srcset is fully baked.


K8sServicesTest Checks ClusterIP Connectivity Checks service on same node, K8sServicesTest Checks service across nodes Tests NodePort (kube-proxy)

Seems like these two tests usually flake together.
https://jenkins.cilium.io/job/Ginkgo-CI-Tests-Pipeline/10110/
https://jenkins.cilium.io/job/Ginkgo-CI-Tests-Pipeline/10116/

@nebril Please post the content of the failure in the PR description and ideally include the zip/tar from CI so that we can see what kind of failure this is later on.
If you know what this failure is, feel free to reopen and add additional detail. Closing for now.


Public key import functions are not const fns

I want to embed keys directly into the binary, already-imported and ready to go, but since (in my specific case) RsaPublicKey::from_public_key_pem is not a const fn, I can't call it from a static context.
Perhaps this is because FromPublicKey is a trait. Maybe RsaPublicKey could expose non-trait methods for importing (which could then be const fns), and the trait methods could delegate to those.
Being unable to import public keys statically is a real disappointment. :(

What you’re suggesting would require an entire const fn PEM decoder as well as a const fn ASN.1 DER decoder.
What is the issue with embedding the key as a str or [u8] and then decoding it when you need it?

What is the issue with embedding the key as a str or [u8] and then decoding it when you need it?

This can panic at runtime when I know that the keys I'm embedding are 100% valid. Regardless of that (suppose I use unwrap_unchecked) it still has to do PEM decoding at runtime that could have been performed at compile time.

Is there an issue with converting the existing one to const?

Yes, that would be a herculean effort, everything from the decoders to replacing the current heap-allocated bignum representation (which is planned, as it were)
The current decoder heavily leverages traits for pretty much everything in the decoding process, and as such it wouldn’t make much sense until const impl lands.

After we migrate to crypto-bigint it should be possible to parse key files in build script, retrieve binary representation of n and e, and finally initialize RsaPublicKey as a constant using included bytes from the build script. I think (but not sure) that it should be possible to constify RsaPublicKey::new after the migration and since it's now possible to unwrap in const fns, it should satisfy your requirements, albeit in a somewhat roundabout way.

@newpavlov That sounds like it would work just fine. LMK when you've migrated and I'll give it a go. Thanks!

I'll close this with the suggestion of embedding the DER-encoded PKCS#1/SPKI public for now.
As @newpavlov mentioned, it will take a migration to crypto-bigint to make this possible. But also, when we do that it will likely involve using generics/traits so that we can support both stack-allocated and heap-allocated big integers, so I don't see something like this working without const impl.
Perhaps we could make some very basic functionality work with const fn inherent methods, like a from_const_components method or something, but again that's in a hypothetical future where we've migrated to crypto-bigint.
tl;dr: any solution here seems somewhat distant


SSL error for creating token using FormData

Hey @basdijkstra ,
Newer version is throwing errors while creating a token using FormData

Hey @bheemreddy181, can you please include a test with your bug reports that I can use to reproduce this behaviour? Without that it's impossible to see what happens here.

Also, what happens when you disable SSL checks using RelaxedHttpsValidation() ?
https://github.com/basdijkstra/rest-assured-net/wiki/Usage-Guide#disabling-ssl-checks

Ok I will create a test and share it with you. It might take some more time to get back. Thanks

Hey @bheemreddy181, can you please include a test with your bug reports that I can use to reproduce this behaviour? Without that it's impossible to see what happens here.

The OuAth2 token generation data is pretty private, I am not in a position to share the example at this point. But it works with  .RelaxedHttpsValidation() added.

OK, that’s what I expected. Is that enough of an answer for you right now?

I am surprised from what changed from before to now are we always expected to set RelaxedHttpsValidation() all the time ?

Well what changed is that with RelaxedHttpsValidation() you essentially told the HttpClient to allow untrusted certificates. I got the idea from here: https://stackoverflow.com/questions/12553277/allowing-untrusted-ssl-certificates-with-httpclient
The original REST Assured in Java does much the same thing by the way: https://github.com/rest-assured/rest-assured/wiki/Usage#ssl
I’m not saying you should use this setting all the time, but it’s one way to deal with SSL. If this isn’t OK for you or you want more fine grained control, can I please ask you to open another issue with your specific requirements?

Sure I can create one. This worked before without setting ssl setup.


🌈 Colors 🌈

Give the output some colors.

Not much we can colorize though :). Or do you want a fancy rainbow style nyan cat kinda output?

You could give some style to the names and time, and the spinner.

Good idea! If someone comes up with a nice color scheme, PR welcome :).


SocketHandler class not found when running on Laravel 5.5

Using Laravel 5.5 and "orchestra/debug": "3.5.x@dev"
Adding Profiler::start(); in the AppServiceProvider results in a the following Exception when running the application:
Error: Class 'Orchestra\Debug\SocketHandler' not found

Fixes via 085d554


gitlab: 11.5.1 -> 11.5.4

Motivation for this change
This bumps gitlab-(ce,ee) from 11.5.1 to 11.5.4, fixing CVE-2018-19856 and CVE-2018-20144
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Assured whether relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

@GrahamcOfBorg test gitlab

@globin @GrahamcOfBorg vm tests still seem to be broken - ran them locally - went through.
Noticed a

gitlab# Both Deployment and its :status machine have defined a different default for "status". Use only one or the other for defining defaults to avoid unexpected behaviors.

warning, not sure if this was there before already or not.


The tutorial on using replit needs to be updated

When I follow the Replit tutorial, setting guissImports to false failed to run.
import flet as ft

def main(page: ft.Page):
  t = ft.Text(value="Hello")
  page.controls.append(t)
  page.update()

ft.app(target=main, view=ft.AppView.WEB_BROWSER)

But I found a way to set it up
# Stops the packager from installing packages when running the Repl
disableInstallBeforeRun = true

# Stops the packager from guessing and auto-installing packages, but it still runs to install packages when running the Repl
disableGuessImports = true

Thanks!
It has been updated: https://github.com/flet-dev/website/pull/211


test gav-paymaster with benchmarking v1 syntax

Don't merge, just testing gav's branch with the v1 syntax to see if we get different weights

bot bench $ pallet dev pallet_salary


Billing V5.0 increases apk size by 8MB compared to V4

Hey thanks for the update to billing V5, it works perfectly!
Just a small issue i noticed that when i use billing V5 compared to the previous V4 the size of the compiled apk is increased by approx 8mb
is anyone else having the same effect? Thanks

Hi,
Without changing anything to your app, try to build the apk again using the latest v4 version of the library, to see if the memory increase is really from here.
The library .aar file is just 61KB.

Hi, so without changing anything within the app other then V4 and V5 billing...this is the outcome
APK with V4 - 9,140 KB
APK with V5 - 17,544 KB

Problem solved, please compile your project with the latest version: implementation 'com.github.moisoni97:google-inapp-billing:1.1.0'.

Looks good!


[ENHANCE] Everytime let go of slider on weights to admin dashboard it requires a transaction

should have some type of update button, makes it trigger an on chain request if you let go on wrong number

Closing this as it will be resolved in https://github.com/PotLock/nadabot-app/issues/109


Allow CORS from everywhere

This should fix #265 ^^
Even if it should be better to use a Middleware such as https://github.com/britg/sinatra-cross_origin, quick & easy fix, thanks @ste.

Thanks for the contribution!
I don't want to allow all origins at everything all the time for everybody because it's a potential security hole. MailCatcher runs on a known port, so if I can get a visitor to come to a malicious page where I control javascript and probe port 1080 then I can start controlling your MailCatcher instance, and potentially probe for and exploit vulnerabilities.
Maybe if it were opt-in?

Is there a separate fix for this ? looks dead


Error Occurs When Importing N/compress and N/dataset Modules

Is your feature request related to a problem? Please describe.
When importing the N/compress module, an error occurs. Additionally, N/dataset is also not supported. I will provide detailed explanations about this issue.
Describe the solution you'd like
I would like the N/compress and N/dataset modules to be integrated correctly into eslint-plugin-suitescript and fixed to prevent errors from occurring.
Describe alternatives you've considered
As an alternative solution to resolve the issue, I have considered whether any specific procedures or configurations are required to work around the problem in the current code, but I couldn't find a solution.

@acdvs
Is it acceptable for me to address this issue on my end?

@tomo-local Not sure when I'll get around to adding these modules, but you're welcome to submit a PR.

@acdvs
I created the pr. Could you please confirm?


Preview6: Dictionary bound to ListBox or ItemsControl not shown

Describe the bug
I have a ListBox or ItemsControl in a View and Items property binds to a Dictionary in the ViewModel. The Dictionary is populated in the ViewModel code and optionally RaisePropertyChanged(nameof(DictionaryProperty)) is called in case Dictionary is populated/changed after ctor.
To Reproduce
Steps to reproduce the behavior. Please note that this is a very simple example not using DataTemplate to show Key and Value of DictionaryItem, but issue occurs regardless of that.
View:
<ListBox Items="{Binding TestList}" />
ViewModel:
private Dictionary<string, string> _testList = new() { {"Foo", "Bar"} };
public Dictionary<string, string> TestList => _testList;

Expected behavior
Dictionary items shall show in ListBox.
Desktop (please complete the following information):

OS: Windows 10 21H2
Version 11.0.0.-preview6

Additional context
Was working in preview5 and previous. Binding to DataGrid, it is still working.

There is a change in preview6, you should bind to ItemsSource.

Thanks a lot. It is working. Issue which is not an Issue can be closed.


Tables inside figures cannot break across pages anymore

Description
Before typst 0.12, I could have a table inside a figure that would break across pages if it was too long to fit. Now, the overflowing content just gets smashed into the final row.
Minor edit was made to simplify the example further.

This code reproduces the example.
#figure(
  table(
	  columns: 2,
	  [*Amount*], [*Ingredient*],
	  [360g], [Baking flour],
	  [250g], [Butter (room temp.)],
	  [150g], [Brown sugar],
	  [100g], [Cane sugar],
	  [100g], [70% cocoa chocolate],
	  [100g], [35-40% cocoa chocolate],
	  [2], [Eggs],
	  [Pinch], [Salt],
	  [Drizzle], [Vanilla extract],
	  [360g], [Baking flour],
	  [250g], [Butter (room temp.)],
	  [150g], [Brown sugar],
	  [100g], [Cane sugar],
	  [100g], [70% cocoa chocolate],
	  [100g], [35-40% cocoa chocolate],
	  [2], [Eggs],
	  [Pinch], [Salt],
	  [Drizzle], [Vanilla extract],
	  [360g], [Baking flour],
	  [250g], [Butter (room temp.)],
	  [150g], [Brown sugar],
	  [100g], [Cane sugar],
	  [100g], [70% cocoa chocolate],
	  [100g], [35-40% cocoa chocolate],
	  [2], [Eggs],
	  [Pinch], [Salt],
	  [Drizzle], [Vanilla extract],
	  [360g], [Baking flour],
	  [250g], [Butter (room temp.)],
	  [150g], [Brown sugar],
	  [100g], [Cane sugar],
	  [100g], [70% cocoa chocolate],
	  [100g], [35-40% cocoa chocolate],
	  [2], [Eggs],
	  [Pinch], [Salt],
	  [Drizzle], [Vanilla extract],
	  [360g], [Baking flour],
	  [250g], [Butter (room temp.)],
	  [150g], [Brown sugar],
	  [100g], [Cane sugar],
	  [100g], [70% cocoa chocolate],
	  [100g], [35-40% cocoa chocolate],
	  [2], [Eggs],
	  [Pinch], [Salt],
	  [Drizzle], [Vanilla extract],
	  [360g], [Baking flour],
	  [250g], [Butter (room temp.)],
	  [150g], [Brown sugar],
	  [100g], [Cane sugar],
	  [100g], [70% cocoa chocolate],
	  [100g], [35-40% cocoa chocolate],
	  [2], [Eggs],
	  [Pinch], [Salt],
	  [Drizzle], [Vanilla extract],
  ),
  caption: [An example figure]
)

Reproduction URL
No response
Operating system
Windows
Typst version

[X] I am using the latest version of Typst

Figures were always unbreakable by default. The solution is outlined here: https://typst.app/docs/reference/model/figure#figure-behaviour
It's likely you had a show rule such as #show figure: it => it.body, which was broken until 0.11. You'll have to explicitly use the solution above.

All correct, and the solution works fine, thank you!


Triage corretto jdk8u/jdk11u xlinux sanity.openjdk test failures

Corretto has its own test pipelines now, see the top-level targets that are launched at the end of these build pipelines:

jdk11u:
https://ci.adoptopenjdk.net/job/build-scripts/job/jobs/job/jdk11u/job/jdk11u-linux-x64-corretto/27/console
sanity.system : passes
extended.system : passes
sanity.perf (running as functional tests) : passes
sanity.openjdk : 10 test cases failing

jdk8u:
sanity.system : passes
extended.system : passes
special.functional : passes
sanity.openjdk : 7 test cases failing
Need to triage the test failures, identify which are already reported and report any new ones to the correct repo for fixing.

If the build pipelines are pulling jdk source from https://github.com/corretto/corretto-11 (which looks like may be the case if look at the console output of a build run and not a jdk11u mirror as the adopt builds use), test pipelines should be pulling test material from the same repo (with matching tag/SHA as is used by the build, https://github.com/corretto/corretto-11/tree/develop/src/test).
This issue is a request to pass enough info to test pipelines so they know where to pull test material from.

Looks like openjdk-build uses BUILD_CONFIGURATION [    "VARIANT" ] =
"corretto", to choose correto repo, similar to openj9 extension repo.:
  # Location of Extensions for OpenJ9 project
  if [[ "${BUILD_CONFIG[BUILD_VARIANT]}" == "${BUILD_VARIANT_OPENJ9}" ]]; then
    suffix="ibmruntimes/openj9-openjdk-${BUILD_CONFIG[OPENJDK_CORE_VERSION]}"
  elif [[ "${BUILD_CONFIG[BUILD_VARIANT]}" == "${BUILD_VARIANT_SAP}" ]]; then
    # TODO need to map versions to SAP branches going forwards
    # sapmachine10 is the current branch for OpenJDK10 mainline
    # (equivalent to jdk/jdk10 on hotspot)
    suffix="SAP/SapMachine"
  elif [[ "${BUILD_CONFIG[BUILD_VARIANT]}" == "${BUILD_VARIANT_CORRETTO}" ]]; then
    suffix="corretto/corretto-${BUILD_CONFIG[OPENJDK_CORE_VERSION]:3}"
  else
    suffix="adoptopenjdk/openjdk-${BUILD_CONFIG[OPENJDK_FOREST_NAME]}"
  fi

https://github.com/AdoptOpenJDK/openjdk-build/blob/master/configureBuild.sh#L150
And corretto's default branch is develop. If tests for hotspot also work for corretto simply passing that build information to test pipeline should be good (Though may need extra parameter for test pipeline).

related to https://github.com/AdoptOpenJDK/openjdk-build/issues/1674#issuecomment-655724014, https://github.com/AdoptOpenJDK/openjdk-tests/issues/1872

The information is set by shell script setRepository() set Branch(). That is  dynamically generated and consumed by build jdk process. Jenkins pipeline has no idea about those generated information. In this way developers can also build jdk natively on the local system (no jenkins needed).
I think there are a few solutions, all of them have cons and pros.

Duplicate this logic in jenkins pipeline so build and downstream builds can also consume it. ( For now it seems only test builds need it. If it is the case the logic can be limited to runTests()).

cons: redundant

Store the generated OPENJDK BUILD CONFIGURATION as Properties Files so downstream builds can consume those information.

19:39:29  # ============================
19:39:29  # OPENJDK BUILD CONFIGURATION:
19:39:29  # ============================
19:39:29  BUILD_CONFIG[ADOPT_PATCHES]="true"
19:39:29  BUILD_CONFIG[BRANCH]="develop"
19:39:29  BUILD_CONFIG[BUILD_FULL_NAME]="linux-x86_64--server-release"
19:39:29  BUILD_CONFIG[BUILD_VARIANT]="corretto"
19:39:29  BUILD_CONFIG[CLEAN_DOCKER_BUILD]="false"

cons: may need to update script, which is unnecessary for local run.

Add some default variable yaml file to set those information

cons: redundant?

Passing build args to test builds and test build need to generate those information using a similar logic.

cons: anything update, both openjdk build project and openjdk-tests project need to be updated.

I will just choose option1 as this change will limit to runtest pipeline code, which won't affect other pipeline or underline base script.


correct vaadin-grid id

It should be material-grid.
https://github.com/vaadin/vaadin-material-theme/blob/master/vaadin-grid.html#L5
Not sure it is can create problems later on -

Thanks, good catch! A simple copy-paste error I made in a hurry 😊


[sival,testplans] Set si_stage to NA for non-sival tests

Add suitable comments explaining the reason some tests are not feasible or needed for sival.

CI failures are unrelated, will merge

@rswarbrick there is a document authored by @johngt that describes si_stage labels: https://docs.google.com/document/d/1yM9Cgmg8brP8EkOJO0EmTGThUfmGMr2oDQS2rZDy_yM/edit#heading=h.4zd9jtpd2s6x


Container start failed: fork/exec operation not permitted on Centos7

Hi,
I was trying to run this project using a Non root account under Centos 7, but I got this error below
[vagrant@localhost unc]$ go run main.go container.go
FATA[0000] Container start failed: fork/exec /tmp/go-build875495572/command-line-arguments/_obj/exe/main: operation not permitted
exit status 1

I think it might be related to the capability settings in the OS, but I have no idea what to look for,  I am wondering if you know anything about this?

@woosley you might want to check that your kernel supports user namespaces: there should be /proc/self/ns/user file.
Also, you need to check that there is 1 in /proc/sys/kernel/unprivileged_userns_clone and Y in /sys/module/user_namespace/parameters/enabled.
You can check that it works with unshare -U also.
Thanks!

the user namespace is enabled by this:
grubby --args="user_namespace.enable=1" --update-kernel="$(grubby --default-kernel)"

unshare -U works
[vagrant@localhost unc]$ unshare -U
[nfsnobody@localhost unc]$

but it might not related to user namespace. I commented CLONE_NEWUSER in the code, still got the same error

@woosley you can try to run with strace -f to see which syscall is problematic. Underlying of exec.Cmd is quite complicated and involve many moving parts and each of them might be broken :(

today I tried some other unshare options, it seems that on Centos 7, there are some permission setting blocking user to do namespace clone?
[vagrant@localhost unc]$ unshare -Um
unshare: unshare failed: Operation not permitted
[vagrant@localhost unc]$ unshare -Ui
[nfsnobody@localhost unc]$ logout
[vagrant@localhost unc]$ unshare -Uu
[nfsnobody@localhost unc]$ logout
[vagrant@localhost unc]$ unshare -Un
[nfsnobody@localhost unc]$ logout
[vagrant@localhost unc]$ unshare -p
unshare: unshare failed: Operation not permitted

@woosley yeap, looks like mount namespace is forbidden to do unprivileged. That might be related to fact that there was a pretty serious vulnerability with user and mount namespaces in certain kernel versions.
All namespace work for me in Ubuntu 16.04 with kernel 4.10 if that helps.


Audit ES Translation of html5-and-css.json

Thanks to @vtamara for the corrections!
Closes #6501

Few corrections. Good translation @justinian336 !

I guess this one is done, @bugron.

@justinian336 @vtamara thank you, merged!


Feature Request - Integrate Retina.sh ~> Capture Feature in AKS VS Code Extension.

💡☕ Proposal for a feature to integration Retina.sh - Capture command for Network Packets. - https://retina.sh
Enable Network Observability, AKS Dev Experience, as part of this here is proposal enabling Retina.sh Capture feature vis VsCode Extension.
Retina capture command allows the user to capture network traffic and metadata for the capture target, and then send the capture file to the location by Output Configuration.
To conceptualise this aspects specifically for this proposal.

cc: @peterbom, @sprab, @gambtho fyi...
How/ What / Where:
Given we have now few network diagnostic / user experience / dev-ops / runoffs experience, we should bundle this into dedicated men-item with submenu options of:

Collect TCP-Dump (Linux support) (Already present in vscode)
Deploy/Undeploy and Use Inspector Gadget Commands like Trace, profile et. al. (ebpf goodness) (Already present in vscode)
Retina.sh -> Distributed Network Capture (Intent for this proposal)

Implementation level raw detail:
Capture Details:
Retina Capture allows users to capture network traffic/metadata for the specified Nodes/Pods.
Captures are on-demand and can be output to the host filesystem, a storage blob, etc.
More detail here: https://retina.sh/docs/captures/
Steps to install:
Vscode first will download latest release - we can leverage similar mechiains,m we do for Inspector Gadget tool from this: https://retina.sh/docs/installation/cli
Option 1 aka download binaries from there: https://github.com/microsoft/retina/releases/tag/v0.0.1
Open Question: Currently I only see the Linux node support only and kubectl-retina-linux-amd64  - so is this one for all operating system? or other OS will come as time will go?

https://retina.sh/docs/captures/cli - Once we have the gadget we can then run it like kubectl retina .. command

Scenarios It will benefit:
// To Do...
Thanks.

I'm keen to aim towards (not immediately, but as a future ideal) an experience where the user flow goes something like:

scenario (e.g. networking problem)

action (e.g. packet capture)

tool for performing that action (e.g. tcpdump or retina capture).

Does that fit with your thoughts, @sprab?
I have concerns about the entry point being the specific tool we're using, because that feels like the reverse flow, and can lead to user confusion around which tool they should be using.
Obviously we need to find ways to work towards that end goal in manageable chunks of work, and it is not realistic at this stage to build a scenario-based diagnostics tool that abstracts away the tooling.
But I think keeping the end goal in mind is important, because we need to track whether we're moving towards it or away from it, and I worry that putting the tools (like retina) as the entrypoints to the experience will create more work for us in the future.
My preference at this stage would be to incorporate retina into the existing tcp dump experience. That way, we have at least part of the scenario->action->tool flow:

action (packet capture)

tool (retina / tcpdump)

That would also minimize the risk of causing confusion for users: "why do I have two commands for running packet captures?"

@peterbom - the network troubleshooting workflows is not a replacement of tcpdump.  IMHO we should preserve the tcpdump tool as is to allow customers to capture traces and analyze them.  The networking troubleshooting scenario would leverage the tcpdump and/or retina.
The workflow that I am thinking of is (soon I will provide a pictorial workflow of this) to first create problem identifiers viz. missing udr, custom dns servers, nsg changes, route changes, firewall changes etc and then combine/order them in a workflow to narrow down.  We can then list the scenarios and the order in which these tools can be run.

I agree with @sprab here, Retina distributed captures is not trying to replace tcpdump, instead it is making it extremely intuitive to use kubernetes language for packet capturing interested traffic in multiple nodes at once. For example:
kubectl retina capture create --host-path /mnt/capture --namespace default --pod-selectors="k8s-app=kube-dns" --namespace-selectors="kubernetes.io/metadata.name=kube-system"

Retina will figure out on which nodes the pods with kube-dns (corens) label in namespace kube-system are running, what are their IPs and will simultaneously start a capture in all those nodes with those interested IPs, this was rest of the traffic is untouched and secure, admin gets all the relevant captures from all nodes at once with single click, and admin will not have to time it together by running different terminals at once.

@sprab:

network troubleshooting workflows is not a replacement of tcpdump

I agree - I was thinking it would include, but not be limited to, packet capture (using tcpdump and/or Retina). But the overall network troubleshooting project is more of a future thing, and we're hoping to incorporate Retina in the shorter term. Am I getting this right?
@vakalapa:

Retina distributed captures is not trying to replace tcpdump

I'm actually not totally sure about this. You say:

instead it is making it extremely intuitive to use kubernetes language for packet capturing interested traffic in multiple nodes at once

That's exactly what we've been trying to achieve with the tcpdump functionality (although not very well with the multiple nodes part). I see a lot of overlap here, and Retina looks to me as if it provides almost a superset of what we've already built.

more platforms for kubectl-retina published in the latest release https://github.com/microsoft/retina/releases/tag/v0.0.2
we will also be adding to Krew https://github.com/microsoft/retina/issues/108

Short term use case scenarios:
Customer Scenario1 -  VSCode One Click: Collect Distributed Capture - Day 0
Issue: Intermittent connectivity issues from external to the application running within a pod.
Customer is unclear of where the problem lies within the AKS cluster.
Support is asking the customer to run tcp capture along with other network statistics while the issue is happening.

Customer: Do I have to run all these commands from within a Node/Pod? Could you please help me do that?
Support: I will share them in an email and run them when the issue is happening?
Customer:  The issue happens so quick that before I could run all these commands the issue might disappear not allowing us to capture the required traces/logs?  Is there an easy way to do this with a script or something similar?
Support: We can leverage VSCode extension which will allow you to capture all these traces/logs in a single click and save you lot of time and effort in capturing and sharing the logs with us.
Customer:  Great, let me run them and share the traces/logs with you :)
Customer Scenario2 -  Analyze the kube-proxy behaviour on a particular node using IPTables output from Retina
Customer runs a one click operation from the VSCode extension to capture the required trace/logs from targeted node/pod to analyze.


not working with pytorch 0.4

Any plan to update?

Yeah, I will try to do next week.

I gave it a try and found the loss not decreasing beyond 1.5 for the first copying example.. It was the same for pytorch 0.2 aswell.

I have gotten it to work with pytorch 0.4 up until and including the copying example. It required inserting a few .item() and .float() calls. Would you like a PR?

Yep, its as simple as @vthorsteinsson mentioned until first example atleast. Jumping between pytorch versions, I missed the dim parameter in softmax.

@vthorsteinsson  would it be possible to have your "corrections"?

@srush Any updates on how to fix things for PyTorch 0.4? Have been stuck on this for quite some time, thank you!

Many may have already solved it. But for those who face the same issue with the toy problem, I fixed the error by changing SimpleLossCompute and runEpoch, mostly due to the tensor norm, which has to be changed to FloatTensor from LongTensor:
class SimpleLossCompute:
    "A simple loss compute and train function."
    def __init__(self, generator, criterion, opt=None):
        self.generator = generator
        self.criterion = criterion
        self.opt = opt

    def __call__(self, x, y, norm):
        x = self.generator(x)
        loss = self.criterion(x.contiguous().view(-1, x.size(-1)), y.contiguous().view(-1)) / norm.float()
        loss.backward()
        if self.opt is not None:
            self.opt.step()
            self.opt.optimizer.zero_grad()
        return loss.data[0] * norm.float().item()

The run_epoch function can be fixed accordingly by casting things like batch.ntokens to FloatTensor

@richielo Thx. I find that I do not use norm.item(), this may cause creating the parameter multiple times.
And I also replace loss.data[0] with loss.item(), I guess this is more stable without any warnings.
Anyway, thx for your warm help.

@DaoD Oh yes, I missed that too! Glad that you figured it out 👍

Any updates on this? I've fixed some fixes, but many others are still required...

@davidalbertonogueira you can refer to my repository.
https://github.com/DaoD/annotated-transformer/tree/master/src
Hope this can help you.

I forked you repo. But get the result below:
Process finished with exit code 136 (interrupted by signal 8: SIGFPE)
Do you know why?

@davidalbertonogueira you can refer to my repository.
https://github.com/DaoD/annotated-transformer/tree/master/src
Hope this can help you.

I forked you repo. But get the result below:
Process finished with exit code 136 (interrupted by signal 8: SIGFPE)
Do you know why?

It seems that there is something wrong with the float point.
I made a little change in the run_epoch(), then the problem is solved:
total_tokens += batch.ntokens.float()
tokens += batch.ntokens.float()

@QianhuiWu hi, it looks like there is a "divide by zero" error.
I guess it would happen when 'total_tokens = 0'. And I think there should be a check in the function run_epoch().
But, the parameter 'total_tokens' and 'tokens' are the number of tokens in the epoch, thus should be integers. I'm confused why this can be fixed by setting them as float numbers.

@vthorsteinsson @srush @QianhuiWu @shehel @teucer @DaoD @eraoul @ictnlp-wshugen
Please try and look into this issue:
https://github.com/harvardnlp/annotated-transformer/issues/28
Need help in running it on pytorch 1.0.1.post2

I'm still getting the same error when using the code from ictnlp-wshugen above. Here's the full error (note: I'm using python 3.7.1 on Windows, pytorch 1.0.0, CUDA 9.0.)
Error: Expected tensor for argument #1 'indices' to have scalar type Long; but got torch.IntTensor instead (while checking arguments for embedding)
python first.py
C:\Users\ernichol\AppData\Local\Continuum\anaconda3\envs\pytorch\lib\site-packages\torch\nn\_reduction.py:49: UserWarning: size_average and reduce args will be deprecated, please use reduction='sum' instead.
  warnings.warn(warning.format(ret))
Traceback (most recent call last):
  File "first.py", line 58, in <module>
    run_epoch(data_gen(V, 30, 20), model, SimpleLossCompute(model.generator, criterion, model_opt))
  File "C:\Users\ernichol\OneDrive - Microsoft\code\pytorch\transformer\refactored-annotated-transformer_codes-master\transformer\flow.py", line 54, in run_epoch
    out = model.forward(batch.src, batch.trg, batch.src_mask, batch.trg_mask)
  File "C:\Users\ernichol\OneDrive - Microsoft\code\pytorch\transformer\refactored-annotated-transformer_codes-master\transformer\encoder_decoder.py", line 24, in forward
    return self.decode(self.encode(src, src_mask), src_mask, tgt, tgt_mask)
  File "C:\Users\ernichol\OneDrive - Microsoft\code\pytorch\transformer\refactored-annotated-transformer_codes-master\transformer\encoder_decoder.py", line 27, in encode
    return self.encoder(self.src_embed(src), src_mask)
  File "C:\Users\ernichol\AppData\Local\Continuum\anaconda3\envs\pytorch\lib\site-packages\torch\nn\modules\module.py", line 489, in __call__
    result = self.forward(*input, **kwargs)
  File "C:\Users\ernichol\AppData\Local\Continuum\anaconda3\envs\pytorch\lib\site-packages\torch\nn\modules\container.py", line 92, in forward
    input = module(input)
  File "C:\Users\ernichol\AppData\Local\Continuum\anaconda3\envs\pytorch\lib\site-packages\torch\nn\modules\module.py", line 489, in __call__
    result = self.forward(*input, **kwargs)
  File "C:\Users\ernichol\OneDrive - Microsoft\code\pytorch\transformer\refactored-annotated-transformer_codes-master\transformer\embeddings.py", line 16, in forward
    return self.lut(x) * math.sqrt(self.d_model)
  File "C:\Users\ernichol\AppData\Local\Continuum\anaconda3\envs\pytorch\lib\site-packages\torch\nn\modules\module.py", line 489, in __call__
    result = self.forward(*input, **kwargs)
  File "C:\Users\ernichol\AppData\Local\Continuum\anaconda3\envs\pytorch\lib\site-packages\torch\nn\modules\sparse.py", line 118, in forward
    self.norm_type, self.scale_grad_by_freq, self.sparse)
  File "C:\Users\ernichol\AppData\Local\Continuum\anaconda3\envs\pytorch\lib\site-packages\torch\nn\functional.py", line 1454, in embedding
    return torch.embedding(weight, input, padding_idx, scale_grad_by_freq, sparse)
RuntimeError: Expected tensor for argument #1 'indices' to have scalar type Long; but got torch.IntTensor instead (while checking arguments for embedding)

OK, the problem occurs in Windows Platform, now I make it runnable in Windows.
you can update the code or see the change �ictnlp-wshugen/annotated-transformer_codes@ffe3bcc

Well, I've tried your work. Everything is going well running on single GPU.
But when I trained it on multi-GPU, condition would be like this https://github.com/harvardnlp/annotated-transformer/issues/16. Do you have any solution about it?

@davidalbertonogueira you can refer to my repository.
https://github.com/DaoD/annotated-transformer/tree/master/src
Hope this can help you.

I forked you repo. But get the result below:
Process finished with exit code 136 (interrupted by signal 8: SIGFPE)
Do you know why?

It seems that there is something wrong with the float point.
I made a little change in the run_epoch(), then the problem is solved:
total_tokens += batch.ntokens.float()
tokens += batch.ntokens.float()

thank you for your sharing code!

I'm still getting the same error when using the code from ictnlp-wshugen above. Here's the full error (note: I'm using python 3.7.1 on Windows, pytorch 1.0.0, CUDA 9.0.)
Error: Expected tensor for argument #1 'indices' to have scalar type Long; but got torch.IntTensor instead (while checking arguments for embedding)
python first.py
C:\Users\ernichol\AppData\Local\Continuum\anaconda3\envs\pytorch\lib\site-packages\torch\nn\_reduction.py:49: UserWarning: size_average and reduce args will be deprecated, please use reduction='sum' instead.
  warnings.warn(warning.format(ret))
Traceback (most recent call last):
  File "first.py", line 58, in <module>
    run_epoch(data_gen(V, 30, 20), model, SimpleLossCompute(model.generator, criterion, model_opt))
  File "C:\Users\ernichol\OneDrive - Microsoft\code\pytorch\transformer\refactored-annotated-transformer_codes-master\transformer\flow.py", line 54, in run_epoch
    out = model.forward(batch.src, batch.trg, batch.src_mask, batch.trg_mask)
  File "C:\Users\ernichol\OneDrive - Microsoft\code\pytorch\transformer\refactored-annotated-transformer_codes-master\transformer\encoder_decoder.py", line 24, in forward
    return self.decode(self.encode(src, src_mask), src_mask, tgt, tgt_mask)
  File "C:\Users\ernichol\OneDrive - Microsoft\code\pytorch\transformer\refactored-annotated-transformer_codes-master\transformer\encoder_decoder.py", line 27, in encode
    return self.encoder(self.src_embed(src), src_mask)
  File "C:\Users\ernichol\AppData\Local\Continuum\anaconda3\envs\pytorch\lib\site-packages\torch\nn\modules\module.py", line 489, in __call__
    result = self.forward(*input, **kwargs)
  File "C:\Users\ernichol\AppData\Local\Continuum\anaconda3\envs\pytorch\lib\site-packages\torch\nn\modules\container.py", line 92, in forward
    input = module(input)
  File "C:\Users\ernichol\AppData\Local\Continuum\anaconda3\envs\pytorch\lib\site-packages\torch\nn\modules\module.py", line 489, in __call__
    result = self.forward(*input, **kwargs)
  File "C:\Users\ernichol\OneDrive - Microsoft\code\pytorch\transformer\refactored-annotated-transformer_codes-master\transformer\embeddings.py", line 16, in forward
    return self.lut(x) * math.sqrt(self.d_model)
  File "C:\Users\ernichol\AppData\Local\Continuum\anaconda3\envs\pytorch\lib\site-packages\torch\nn\modules\module.py", line 489, in __call__
    result = self.forward(*input, **kwargs)
  File "C:\Users\ernichol\AppData\Local\Continuum\anaconda3\envs\pytorch\lib\site-packages\torch\nn\modules\sparse.py", line 118, in forward
    self.norm_type, self.scale_grad_by_freq, self.sparse)
  File "C:\Users\ernichol\AppData\Local\Continuum\anaconda3\envs\pytorch\lib\site-packages\torch\nn\functional.py", line 1454, in embedding
    return torch.embedding(weight, input, padding_idx, scale_grad_by_freq, sparse)
RuntimeError: Expected tensor for argument #1 'indices' to have scalar type Long; but got torch.IntTensor instead (while checking arguments for embedding)

OK, the problem occurs in Windows Platform, now I make it runnable in Windows.
you can update the code or see the change �ictnlp-wshugen/annotated-transformer_codes@ffe3bcc

Well, I've tried your work. Everything is going well running on single GPU. But when I trained it on multi-GPU, condition would be like this #16. Do you have any solution about it?

Hi, could you mind sharing how to run it on a single gpu? I keep getting a CUDA out of memory error (using Google Colab)


[Docs Error]Docs difference in different languages

There're code blocks errors in different version docs.

The en version must be right, link
The zh version isn't right, link. It DOES NOT make sense.
I guess it might be something wrong with the order of code blocks

I suspect this was solved at some point, right?

Sorry for the long delay! 🙈  I wanted to personally address each issue/PR and they piled up through time, but now I'm checking each one in order.


Converting a line of text into a list item breaks the text after the first word

Context
Converting a line of text into a list item
Process
Place the cursor at the beginning of a line. Press the "Add a bulleted list" button in the toolbar.
Current result
When converting a line of text into a list:

adds the -  in front of the current line
breaks the line after the first word

Expected result

adds the -  in front of the current line and doesn't introduce new lines

Example

Possible Fix
I'm planning to look into this and raise a pull request, but I was wondering if there is a reason for having the current behaviour.

This is fixed in 1.0.1! Apologies for the delay. Thanks for the report.


using fish instead of bash causing problems

I've been using slimux for half a year now and I love it. Until recently I've been using bash as my default shell, but now I have really been enjoying fish (friendly interactive shell). I have found a problem whereby within a fish shell I start tmux, create two panes, open vim in the top pane and my repl in the bottom pane, I send the first line and hence select the bottom pane, but it appears in the top pane! The lines of vim get send back to vim and not to the repl!
If I repeat the above procedure from bash it works fine. Does anyone know what could cause this?
Thanks :)

Hmm, can you describe more of your environment?  I just installed fish (cool shell by the way, I hadn't tried it before) and didn't see this behavior.  I'm running ViM 7.4 on Arch Linux (technically in a chroot via chroagh).  Does the problem still occur if you have bash as your default shell, but switch to fish (both for launching tmux and in the top pane when you launch vim)?

Fish is cool, especially with oh-my-fish :) I'm running fedora 22 with vim 7.4.827. I can confirm the problem does not arise when bash is my default shell but switch to fish prior to launching tmux.

ok, so the reason for this is that fish doesn't support "||" which we use in the commands to fetch the panes; I'll give it a shot to implement this using filter instead of grep in vimscript.

Try running :set shell=/bin/sh (or add it to your vimrc) before issuing any Slimux commands.

That worked :) thank you


Add: flutter build ios [--[no-]simulator]

This allows the user to build an iOS application bundle from the command line even if no device is attached to the workstation.

cc @devoncarew

lgtm w/ some naming questions

@devoncarew another look?

missed the 2nd review, but added some comments -

Addressing. I also found a couple of other issues as I was adding a Travis bot for this. Will send another PR.


Refactored Match table

Changed Match_result table to Match
Added "status" column to log if match is in progress or finished
Added a route to update the status of the match

Match is a reserved SQL keyword, reverting back


Error - You have not specified the listen interface

Hi Team,
I'm trying to set proxy settings for keycloak but every time I pass my settings through command line, I receive error - "You have not specified the listen interface". Following is my setting -
keycloak-proxy \ --discovery-url=https://accounts.google.com/.well-known/openid-configuration \ --client-id=318822166127-poit5i1r151v6gohvc2kq4rljqbn13ph.apps.googleusercontent.com \ --client-secret=2nmtYkzhSBNeZE0iRHMpx2pU \  --resources="uri=/*" \ --verbose=true
[error] you have not specified the listening interface
Kindly look into this and tell me where I'm doing wrong.
Note - the above is just for testing. On using the actual proxy setting also shows the same error message.

Hi @gpkm1469 ... you need to set the interface for the proxy to listen on i.e. --listen :10443  as no default value it set for this ..

I'm gonna mark the issue as close .. but feel free to reopen is the suggestion above doesn't work


Bump version to 0.61.0

Bumping Gestalt version to 0.61.0

Deploy preview for gestalt ready!
Built with commit 146c9922d8ee0c29207425752ee16eb541a86af3
https://deploy-preview-91--gestalt.netlify.com


Notion of a Turn?

What is the notion of a turn supposed to be?
Is a turn supposed to represent the same work, but repeated to have more measurements?
Or is a turn supposed to represent different work plans, and having multiple allows to judge whether performance is stable for similar but not identical "work plans"?
It it is the first, I would assume we need to reset random number generates, and possibly any kind of expanding data structure for each turn.

It is the latter :)

Thanks


Reduce allocations on GraphQL hot paths

👋  I was investigating memory consumption from a GraphQL perspective and I found a few places I thought might be improved. In my benchmark, this improved the total memory consumption by 11% (17% of objects):
- Total allocated: 1809805 bytes (15888 objects)
+ Total allocated: 1601789 bytes (13174 objects)
  Total retained:  0 bytes (0 objects)

  allocated memory by gem
  -----------------------------------
-  1003824  opentelemetry-sdk-1.3.1
+   795648  opentelemetry-sdk-1.3.1
    381029  graphql-2.1.6
    194512  opentelemetry-api-1.2.3
    189656  opentelemetry-instrumentation-graphql-0.26.7
     35952  other
      4288  racc-1.7.3
       368  logger
       136  monitor
        40  set

otel_bench.rb

require "bundler/inline"

gemfile(false) do
  source "https://rubygems.org"
  gem "graphql", "2.1.6"
  gem "opentelemetry-sdk" # , path: "~/code/opentelemetry-ruby/sdk"
  gem "opentelemetry-api" # , path: "~/code/opentelemetry-ruby/api"
  gem "opentelemetry-instrumentation-graphql" # , path: "~/code/opentelemetry-ruby-contrib/instrumentation/graphql"
  gem "benchmark-ips"
  gem "memory_profiler"
  gem "stackprof"
end

class MySchema < GraphQL::Schema
  DATA = {
    "5" => {
      name: "Beatrix Potter",
    },
    "6" => {
      name: "J.R.R. Tolkien"
    },
    "10" => {
      title: "The Tale of Squirrel Nutkin",
      author_id: "5",
      recommended_book_ids: ["11", "12"],
    },
    "11" => {
      title: "The Tale of Ginger and Pickles",
      author_id: "5",
      recommended_book_ids: ["10", "12"],
    },
    "12" => {
      title: "The Tale of Mr. Tod",
      author_id: "5",
      recommended_book_ids: ["11", "10"],
    },
    "21" => {
      title: "The Hobbit",
      author_id: "6",
      recommended_book_ids: ["22", "23", "24", "25", "26", "27"],
    },
    "22" => {
      title: "The Fellowship of the Ring",
      author_id: "6",
      recommended_book_ids: ["21", "23", "24", "25", "26", "27"],
    },
    "23" => {
      title: "The Two Towers",
      author_id: "6",
      recommended_book_ids: ["22", "21", "24", "25", "26", "27"],
    },
    "24" => {
      title: "The Return of the King",
      author_id: "6",
      recommended_book_ids: ["22", "23", "21", "25", "26", "27"],
    },
    "25" => {
      title: "The Silmarillion",
      author_id: "6",
      recommended_book_ids: ["22", "23", "24", "21", "26", "27"],
    },
    "26" => {
      title: "The Adventures of Tom Bombadil",
      author_id: "6",
      recommended_book_ids: ["21", "22", "23", "24", "25", "27"]
    },
    "27" => {
      title: "Leaf by Niggle",
      author_id: "6",
      recommended_book_ids: ["21", "22", "23", "24", "25", "26"]
    }
  }

  module Node
    include GraphQL::Schema::Interface
    field :id, ID
  end

  class Author < GraphQL::Schema::Object
    def self.authorized?(obj, ctx)
      -> { true }
    end
    implements Node
    field :name, String
    field :books, ["MySchema::Book"]

    def books
      author_id = DATA.find { |(id, auth)| auth == object }.first
      DATA.each_value.select { |d| d[:author_id] == author_id }
    end
  end

  class Book < GraphQL::Schema::Object
    implements Node
    field :title, String
    field :author, Author
    field :recommended_books, [Book]

    def author
      DATA[object[:author_id]]
    end

    def recommended_books
      object[:recommended_book_ids].map { |id| -> { DATA[id] } }
    end
  end

  class Query < GraphQL::Schema::Object
    field :node, Node do
      argument :id, ID
    end

    def node(id:)
      DATA[id]
    end
  end

  query(Query)

  orphan_types(Book, Author)

  def self.resolve_type(type, obj, ctx)
    if obj.key?(:name)
      Author
    elsif obj.key?(:title)
      Book
    else
      raise "Unknown object: #{obj.inspect}"
    end
  end

  lazy_resolve(Proc, :call)
end

OpenTelemetry::SDK.configure do |c|
  c.use 'OpenTelemetry::Instrumentation::GraphQL', {
    schemas: [MySchema],
    # enable_platform_field maps to the execute_field and execute_field_lazy keys
    enable_platform_field: true,
    # enable_platform_authorized maps to the authorized and authorized_lazy keys
    enable_platform_authorized: true,
    # enable_platform_resolve_type maps to the resolve_type and resolve_type_lazy keys
    enable_platform_resolve_type: true,
  }
end

# puts MySchema.to_definition

small_query_str = <<-GRAPHQL
query {
  node(id: "10") {
    __typename
    ... on Book {
      title
      author {
        __typename
        name
      }
      recommendedBooks {
        __typename
        title
      }
    }
  }
}
GRAPHQL

large_query_str = <<-GRAPHQL
{
  node(id: "6") {
    ... on Author {
      name
      books {
        title
        recommendedBooks {
          title
          author { name }
          recommendedBooks { title }
        }
      }
    }
  }
}
GRAPHQL

# pp MySchema.execute(small_query_str).to_h
# pp MySchema.execute(large_query_str).to_h

Benchmark.ips do |x|
  x.report("small query") { MySchema.execute(small_query_str) }
  x.report("large query") { MySchema.execute(large_query_str) }
end

query_str = large_query_str

puts "\n\n\n"

result = StackProf.run(mode: :wall, interval: 1) do
  MySchema.execute(query_str)
end
report = StackProf::Report.new(result)
File.open("tmp/otel_query.dump", "wb+") { |f| report.print_dump(f) }
report.print_text

report = MemoryProfiler.report do
  MySchema.execute(query_str)
end
puts "\n\n\n"
report.pretty_print

Good call on break to return, thanks!


Put Package.swift in latest release

Recently Swift Package Manager is integrated into Xcode and it requires each tag to have Package.swift file. Release a new version (like 1.2.1) will be great.

This can all be done in the GitHub UI like so: https://github.com/jeffd/fuse-swift/releases

I'm not sure at all if it's related to that but... I added the following to my Package.swift:
.package(url: "https://github.com/krisk/fuse-swift.git", .branch("master")),

The package seems to be added just fine according to Xcode, but I cannot seem to find any content from the package (import Fuse fails with No such module 'Fuse')


Some exceptions not reported

Some of my exceptions are not being logged/reported.
After a bit of digging on v1.0.0-beta3 \Dingo\Api\Http\Middleware\Request@handle has a try catch which is what reports the exception as long as an exception is thrown and the exception is not in my $dontReport in \App\Exceptions\Handler.
However the sendRequestThroughRouter eventually calls \Dingo\Api\Routing\Router@dispatch which also has a try catch but this does not report. I am guessing this is where the problem is.
What would you suggest, removing the try catch from \Dingo\Api\Routing\Router@dispatch or adding $this->app['Dingo\Api\Contract\Debug\ExceptionHandler']->report($exception) into the catch?

Indeed reporting should be done there. Pushed a fix.

Great Thanks!


[CT-385] Limit catalog generation to specific relations

Context: https://github.com/dbt-labs/dbt-spark/issues/228, https://github.com/dbt-labs/dbt-spark/issues/296
Currently, catalog generation uses the same SQL as cache population: show table extended in <databasename> like '*'. There are good reasons to want to change this query:

to be faster during cache population
to be more targeted during catalog generation, and avoid grabbing metadata for irrelevant tables

Proposal
I think the change here will look like:

Decoupling the methods/macros used for cache population + catalog generation (currently both call list_relations_without_caching)
Including information about specific relation names (rather than just schema names) from _get_catalog_schemas
Passing those specific relation names into the new catalog macro, for use in the like rel_1|rel_2|rel_3|... predicate (rather than just like '*')

https://github.com/dbt-labs/dbt-spark/blob/d7f1d38d0dcf272dc0e513db4eeada0c08c407f5/dbt/adapters/spark/impl.py#L292
https://github.com/dbt-labs/dbt-spark/blob/d7f1d38d0dcf272dc0e513db4eeada0c08c407f5/dbt/adapters/spark/impl.py#L323
Alternative
Revisit the change in #160. Before that change, we had to run describe extended for every single table. While generally much slower, that approach had some advantages:

The output was consistent across file types (#295)
It includes column-level comments
If only documenting a single table from a massive schema, it's faster to describe that one table than show many tables in the schema (hopefully solved by the refinement proposed in this issue)

After reading #228 I propose to reopen the issue and implement like rel_1|rel_2|rel_3|... predicate: In our case show table extended in {{ relation }} like '*' leads to failing dbt docs generate due to the fact that dbt does not have access rights to all objects in the source schema.
As I can see, this demands changes not only in _get_cache_schemas() but also in schema_relation in list_relations()
https://github.com/dbt-labs/dbt-core/blob/7872f6a67087b08e377cb580248a70355c6c3c76/core/dbt/adapters/base/impl.py#L741
I think I'll test changes it and will propose a merge thereafter.


Disable no-descending-specificity

This rule is usually but not always right.


Re-register contributed book commands when new extension loaded

Fixes https://github.com/microsoft/azuredatastudio/issues/13402
Also adding in awaits so we're sure that the context is updated correctly when unregistering/registering the commands (no race conditions)

Pull Request Test Coverage Report for Build 362194755

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 41.183%

Totals

Change from base Build 362188942:
0.0%

Covered Lines:
21760

Relevant Lines:
48495

💛  - Coveralls


Index trait should provide get(&self, key: &Q) -> Option<&V>

Or a similar trait should exist and be provided by the standard indexable collections.

Or maybe there is a generic way to do this with indexable collections already, in which case it would be nice to see it documented alongside Index.

Or a Contains trait with contains(&self, key: &Q) -> bool can be used to similar effect.

See #1679.

Will https://github.com/rust-lang/rfcs/pull/1679 / https://github.com/rust-lang/rust/issues/35729 apply for BTreeMap and friends? It is unclear to me at first reading since the discussion there is in terms of slices.


302 moved permanetly

When I translating json object its not translating in cmd its showing for request body302 moved permanently and bad request

Hi @shashika18923 ,
which source are you using from the list below?

Libre
Argos
Google
Bing

That should be a temporary error from the service.

I too saw this with 1.6.3 and posted yesterday a note here.  it is not resolved, for me at least, as you can see.  And 1.6.4 results in the "--" errors.

@israel-kochava hi,
please check the comment here
more info in readme


fix black actions

Description
fix empty files for black command
Changes
black action

Codecov Report
Base: 74.38% // Head: 74.38% // No change to project coverage :thumbsup:

Coverage data is based on head (17aaff6) compared to base (637f4f9).
Patch has no changes to coverable lines.

Additional details and impacted files
@@             Coverage Diff              @@
##           development     #634   +/-   ##
============================================
  Coverage        74.38%   74.38%
============================================
  Files               79       79
  Lines             3962     3962
============================================
  Hits              2947     2947
  Misses            1015     1015

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Update entities when provisioning config files

Description
This PR changes the behavior of the provisioning service to update entities instead of recreating them. This is needed to ensure that the correct connector lifecycle events are triggered.
A big chunk of the code changes in this PR constitutes new tests and refactoring of existing tests.
Fixes #962
Quick checks:

[X] I have followed the Code Guidelines.
[X] There is no other pull request for the same update/change.
[X] I have written unit tests.
[ ] I have made sure that the PR is of reasonable size and can be easily reviewed.

@hariso @maha-hajja I rebased the branch on top of main, the commits added since your review start with https://github.com/ConduitIO/conduit/pull/968/commits/3f1aaadea08f1b4c1295c3b07f50fd1f5e8e65a5.


Change this.$newArticle

this.$newArticle is already a jQuery object. Not sure if this will fix lonelyplanet/destinations-next#754.

I'd be surprised if this fixes it TBH.

I don't think it will. I've found where the issue is coming from, but can't reproduce it.

:+1:

Let's give this a whirl for a while and see what happens.


The .autoboobs, .autohentai and autobutts arent working

The repeating system doesnt repeat anything. I type .autohentai 30 and nothing happens for hours.
pls help an yes it is an nsfw channel.

Next time, ask on our support server.


feat(importpath): Add option.stripPackageName

Add a stripPackageName: true option to the importpath plugin to allow stripping the package name from the import path.
This is useful for projects that have custom module resolvers where you want to be able to replace the whole path.

@BKcore Thanks!
Please update README
https://github.com/esdoc/esdoc-plugins/blob/master/esdoc-importpath-plugin/README.md#config

@h13i32maru Updated!


Extend youtube shortcode to support playlists

The player will load the first video of the playlist by default.
The playlist is available in the YouTube player menu (top left).
I’m not sure if this is the best way to code the template.
I declare $path, and then determine the subpath in an if else block, and append the adequate autoplay query parameter if necessary.

@Kissaki,
Can you provide documentation from Youtube that stand-alone videos will never has an ID that starts with PL?