Logical Interconnect API300 Support

Description
Implementation of the logical interconnect for API300 support.
Issues Resolved
#103
Check List

[x] New functionality includes testing.

[x] All tests pass ($ rake test).

[ ] New functionality has been documented in the README if applicable.

[x] New functionality has been thoroughly documented in the examples (please include helpful comments).

[x] Changes are documented in the CHANGELOG.

To perform the Logical Interconnect tests, it was necessary to change some tests, such as enclosure-group, logical-interconnect-group and logical-enclosure.

@fgbulsoni I ran the tests. For C7000 executed successfully. For synergy executed successfully, but sometimes the test for update_settings failed. I think it's due to inconsistent device.

PR is facing conflicts post the merge of PR #110 , CHANGELOG.md should be reviewed to fix conflicts.

@fgbulsoni Fixed merge conflicts.

@fgbulsoni review changes fixed.


Best approach, validate nested attr

I have dynamic nested attrs i need to validate.  A custom validator would be ideal.  I want to retrieve the required attrs from a service and check that each nested attr has a value.
How would i manually validate when a nested attr is updated?
title: {   en: '',   fr: '',   de: '' }

@rossjha I don't know if it's the same case, but the API I'm using has some fields like post.titles that returns an object like the one you mentioned: { pt: 'Olá, Mundo!', en: 'Hello, World!' }.
So, when I'm creating a post, I have an <input> for each title translation. The tricky part is that I don't have the languages list beforehand. I have to look the post.titles property and, for each key, create the validations dynamically. That's how I've solved it:
// app/components/post-form.js

import Component from '@ember/component';
import { validator } from 'ember-cp-validations';
import buildDynamicValidations from 'my-app/utils/build-dynamic-validations';

const Validations = {
  'post.publishedAt': [
    validator('presence', {
      presence: true
    })
  ],
  'post.titles.@eachKey': [
    validator('presence', {
      presence: true
    })
  ],
  'post.bodies.@eachKey': [
    validator('presence', {
      presence: true
    })
  ]
};

export default Component.extend({
  init() {
    this._super(...arguments);
    this.reopen(buildDynamicValidations(this, Validations));
  },

  // ...
});

The 'post.titles.@eachKey' and '.post.bodies.@eachKey' notation means that the validations will not be applied to post.titles nor post.bodies, but to each of their keys instead. Which means post.titles.pt, post.titles.en, post.bodies.pt and post.bodies.pt.
This notation is something that I came up with because I have this logic spread throughout my hole app, and this way I can reduce the repeated code.
// app/utils/build-dynamic-validations.js

function buildDynamicValidations(scope, validationsMap) {
  let validations = {};
  let propertiesToValidate = Object.keys(validationsMap);

  propertiesToValidate.forEach((fullPropertyPath) => {
    let propertyValidations = validationsMap[fullPropertyPath];
    let shouldApplyValidationsNestedProperties = fullPropertyPath.endsWith('.@eachKey');

    if (shouldApplyValidationsNestedProperties) {
      let [propertyPath] = fullPropertyPath.split('.@eachKey');
      let nestedPropertiesToValidate = Object.keys(get(scope, propertyPath));

      nestedPropertiesToValidate.forEach((key) => {
        validations[`${propertyPath}.${key}`] = propertyValidations;
      });
    } else {
      validations[fullPropertyPath] = propertyValidations;
    }
  });

  return buildValidations(validations);
}

I'm planning to detect every string that end of variations of<EMAIL_ADDRESS>so I can have more meaningful descriptions:
const Validations = {
  'post.titles.@eachTranslation': [
    validator('presence', {
      presence: true
    })
  ],

  'someListsOrganizedBySomeIdentifier.@eachList': [
    validator('length', {
      min: 1
    })
  ],
};

@offirgolan Do you think this notation of .@eachKey is something that other people could benefit from? 🤔 I did it inspired by the computed property notation for array properties.

@rossjha I'm closing the issue because it's quite old. Feel free to reopen if you still need help.


new localisation formatter breaks previews

if anywhere in any preview able file a localization formatter is used the preview breaks.
This is because the localization formatter uses the syntax of
custom_effect_tooltip = <format_type>|<loc> the | breaks it as it seens as an invalid token.

Fixed in v0.12.2.


Load data into Aerie from UI

Checked for duplicates
Yes - I've already checked
Alternatives considered
Yes - and alternatives don't suffice
Related problems
I'm frustrated when I want to see some time-series data in Aerie, but I don't want to edit Java.
Describe the feature request
I need or want to be able to upload time-series data and add it to views in a plan like any other resource.  If this were spreadsheet data, I'd like multiple resources to be created using the header for names; for example the first row has resource names, the first column is a time value, and the other columns are each values for a resource.
The data could be uploaded once and reused for different mission models and plans.
A bonus would be if it could be used for activities, too.
A bonus would be if I didn't have to worry about the time format or even the file format.  For example, as an alternative to timestamp formats, durations could be offsets from the plan start.  CSVs, Excel, JSON, and different simple text formats might all be supported.  The idea is that the user doesn't need to do any cleaning.
Joe Guinn has given me this request three times.

For the initial implementation lets limit the scope to

The json format already supported by our graphQL schema
CSV matching the format in our docs example, optionally with the time column in UTC

We discussed the first implementation of CSV support in Slack today. Unlike JSON files, CSV files can't easily contain a schema or other metadata describing the format, so we decided to enforce these restrictions on CSV file uploads:

CSVs will only support numeric profiles, ie. we will assume the following type/schema for all CSV uploads:"type": "discrete",
"schema": { "type": "real" },

The CSV will be assumed to have a header with column names
The time column must be named time_utc and will allow only the following timestamp formats: 2024-183T00:00:00 or 2024-07-01T11:40:55.219Z.
The start time of the dataset will be defined as the minimum time value in the time_utc column
Any datasets requiring more flexibility than this should just use JSON files for import

CSVs will uploaded to a particular plan. On upload, the user will have the option to associate the dataset with (only) the currently selected simulation dataset.

Any reason we can't support a profile with enumerated states as strings? That seems like it could also be a common use case.


Make sparse the default mode in AttractorsViaRecurrences

I added a test comparing the two versions for Lorenz84. It is currently failing because the versions give slightly different results:
E.g. Dict(2 => 0.246, -1 => 0.003, 3 => 0.211, 1 => 0.54) for sparse versus Dict(2 => 0.222, -1 => 0.003, 3 => 0.219, 1 => 0.556) for nonsparse.
Should I relax the restrictions such that the tests pass?

There are still two unrelated errors: one related to trajectory_continuous and another caused by an outdated Entropies.jl version used in these tests, which doesnt have Renyi().

@KalelR for future reference: never "merge" requests via merge commit. Always choose "Squash and merge". There is a dropdown arrow in the merge button that allows the squash version. Always do squash.

Ah, ok! Sorry, will do!


Ignore parent path NoSuchFileException when localPageStore delete pageId

What changes are proposed in this pull request?
LocalPageStore delete pageId cloud ignore parent path NoSuchFileException when parent path is deleted by other thread in a benign race
Why are the changes needed?
[fix  #16250]
Does this PR introduce any user facing changes?
None.

alluxio-bot, check this please

alluxio-bot, merge this please.

alluxio-bot, merge this please.


fix: narrow smart contract wallets accounts

Description
See screenshots below - the current behaviour in develop is 100% wrong and lost funds waiting to happen as we disable smart contracts safety.
Given an EVM addy that's a smart contract, it may only be a smart contract on one chain, not many, e.g two Gnosis safes over two EVM chains, with two diff addies:

Note there is only one for Avalanche and one for Ethereum here but I could just as well create as many as I want - one sc wallet requires one separate wc connection. In effect, one sc wallet connected through wcv2 will always have an account on a single chain only.
This PR fixes the current accounts derivation by bailing on all other chains if a smart contract address is found for one, making things nice and safe.
Pull Request Type

[x] :bug: Bug fix (Non-breaking Change: Fixes an issue)
[ ] :hammer_and_wrench: Chore (Non-breaking Change: Doc updates, pkg upgrades, typos, etc..)
[ ] :nail_care: New Feature (Breaking/Non-breaking Change)

Issue (if applicable)

closes https://github.com/shapeshift/web/issues/7496

Risk

High Risk PRs Require 2 approvals

What protocols, transaction types or contract interactions might be affected by this PR?

Theoretically very very low - only touches WCV2 as a wallet, and smart contracts addresses specifically. Though since this lives in the EVM accounts derivation utils, effectively high-risk.
Testing

Create a Gnosis Safe on any chain of your liking
Connect to said safe via WC as a wallet
Ensure the only AccountId present is the one for your safe's chain

Engineering

^

Operations

^

Screenshots (if applicable)
develop (right) vs. this diff

Any ideas why I see every assets while using a fresh avalanche safe wallet account?

@NeOMakinG just tested with a safe on Ethereum:

And a safe on Avalanche:

And both are correctly showing only one account. If you can consistently repro this with a full cache clear, happy to debug this together!

I have been able to reproduce:

First connect the SC wallet on develop, wait for all accounts to load
Checkout this branch, connect the same SC wallet, you'll see the full list loaded while this PR assume we should only load the supported chain

This is a cache issue, meaning that even if we merge and release this PR, our users might have a big list of accounts already loaded and might result in funds lost
This hasn't been introduced by this PR but we should take care of it as long as users funds could be lost

I have been able to reproduce:

First connect the SC wallet on develop, wait for all accounts to load
Checkout this branch, connect the same SC wallet, you'll see the full list loaded while this PR assume we should only load the supported chain

This is a cache issue, meaning that even if we merge and release this PR, our users might have a big list of accounts already loaded and might result in funds lost
This hasn't been introduced by this PR but we should take care of it as long as users funds could be lost

Very nice catch @NeOMakinG! While I originally thought this was a hollistic issue (well... it kind of is in a way) with us keeping stale accounts from other wallets, this is indeed a simple cache busting migration scenario, with the root cause laying in <AppContext />'s requestedAccountIds - another bug related to the account management follow-up and wrong reactivity we sometimes encounter. This loosely relates to https://github.com/shapeshift/web/issues/7214.
Fixed in f9ccf7b86:

Before migration:

After migration


Parameters do not respect quotation

When I pass a parameter that contains spaces in the value, those are treated as separate parameters and the latter part is dropped silently. This is somewhat expected (except for the silent part):
@bot run task MODE=something other
 map[MODE:something,]

If I try to quote the parameter to include the space (also happens with single quotes), the quotes are ignored and the parameter value is still split:
@bot run task MODE="something other"
 map[MODE:"something,]

I would expect the quotation to be preserved in parameters but I could also work with it being split if it takes the contents of the quoted section as-is:
@bot run task MODE="something other"
 map[MODE:"something other",]
 map[MODE:something other,] # alternatively

I've also found that these tests https://github.com/ifosch/synthetic/blob/master/pkg/job_control/jenkins_test.go#L27-L89 are actually broken. The way it's written, these lines https://github.com/ifosch/synthetic/blob/master/pkg/job_control/jenkins_test.go#L72-L86 are only tested when there is a mismatch between between an error was expected but not triggered.
I have a commit locally reflowing the tests for better readability and to exercise all return values in all test cases and I'll upload it in the PR I'm writing trying to solve this issue.

The issue comes from https://github.com/ifosch/synthetic/blob/master/pkg/job_control/jenkins.go#L29 as it's using a helper from the slack package to tokenize the arguments, and that does not respect quotations. I'm thinking of adding a tokenizer helper that respects quotations and avoid the helper from slack package (moving responsability over parsing the commands to the jenkins package). Would that be a good approach?
I haven't fully grasped the command parsing but it seems to be split between different components and it's hard for me to trace it into a single piece.

There's a couple details about the way parsing is distributed I don't really follow. Why does jobcontrol receive the command parameter, when it's only used to remove it from the parameters? If that's already been captured can't we prevent supplying it to the consumers? Or can't we let the consumers figure out which command it is? I haven't tried to follow the program end-to-end yet.


We have a lot of transactions stuck on the chain with below < 1 tx fee.

@shibe2 @langerhans We are in the situation where we have txs that are unconfirmed on the chain with the fee below 1.
It seems that we can't use bumpfee for the transactions that already went out and sitting unconfirmed on chain. How would you recommend to get those tx confirmed?
example: https://dogechain.info/tx/38be6b764da587333892bdbb0f20561f9ba2880f50d50ec3ce77bbae0660f8be
We also have large number of transactions stuck in the mempool with the fee below 1. What should we do with the txs stuck in the mempool?
After we upgrade to the 1.14.2, what happens to the transactions in the mempool? Is it going to reload?

@ara1313 As I said, I believe, such transaction should be eventually confirmed. You can try things like CPFP, re-sending coins with appropriate fee, sending transactions directly to miners.
Maybe come to Dogecoin Discord or reddit where more active Dogecoiners may be available to help you.

Your tx will not be confirmed unless it gets relayed to a miner node AND they include it.
CPFP does not work in this case, because the child tx only gets accepted by nodes that have the parent (eg nodes that were directly connected to yours) but if the parent did not propagate, the child ends up being a spend of an invalid utxo and thus will not be relayed far. So currently if the transaction does not get directly relayed to a miner node by the originating node, this solution does not work.
Mempool expiry time is currently defaulting to 2 weeks, so most nodes will keep your tx in their mempool for that long. I realize that that's very non-optimal 😕

Re-sending is more viable, especially since you seem to re-use your change address. What you could do (with Dogecoin core, examples are for a linux dogecoind):

Dump all your txs into a backup, eg:

dogecoin-cli getrawmempool |jq -r '.[]' |xargs -n 1 dogecoin-cli getrawtransaction >> my_mempool.txt

Make note of all the peers your node is currently connected to with dogecoin-cli getpeerinfo, those will have your tx in mempool and will not accept replacement tx.

Delete your local mempool, eg: rm ~/.dogecoin/mempool.dat
If you run with wallet enabled and those tx were made by the wallet and not by sendrawtransaction, restart your node with zapwallet, eg: dogecoind -zapwallettx, otherwise just restart the node.
Add some additional nodes (you can manually discover some with dig seed.multidoge.org)
For each of the backed-up tx that are yours, adjust the fee and resend. Manually, that would be:

count the bytes
adjust the fee, eg: dogecoin-tx <tx_hex> delout=<change output index number> outaddr=<new change>:<change addr>
re-sign it with dogecoin-cli signrawtransaction <tx_hex> null '["<privatekey_wif>"]'
check if the new byte count does not exceed the fee paid
resend it with dogecoin-cli sendrawtransaction <signed_tx_hex>

If you have a lot of re-spent change outputs (the example you have shown doesn't respend, but do consider this) it may be quicker to create a new (set of) tx instead of step 7. If you're unsure about the fee needed, RBF opt-in works (by setting a sequence number < 0xffffffff - 1 on your tx inputs)

@patricklodder If CPFP is supported at all, it is possible to send both the stuck and child transaction directly to miners.

If CPFP is supported at all, it is possible to send both the stuck and child transaction directly to miners.

If you have a way to do that, yes. If you're chaining tx (new change address per tx) it may be easier that way, if you're not, it's probably more work and creating a new tx with sufficient fee is then probably the easiest way forward.

@patricklodder Thanks for the detailed response.  Three questions.
It sounds like there is a way to push these through if someone could point us to a miner that we could pay to include them?  Is this true?  Do they just have to use an older version of the daemon so it can accept v3 blocks?
If we did use sendrawtransaction, what's the easiest way to just delete all the 0 confirmed transactions? In the past in situations like this, we've had to dump all the keys, reimport, rescan to get to a clean state.
Once we remove all the tx's from the wallet, we can just requeue and resend them all with the correct fee; the concern is during the 2 week its in the mempool, some of them somehow get mined and included at which point, we have double paid someone.  I really want to avoid having to figure out all the inputs and creating a transaction just to doublespend them to avoid this situation.

@richiela
Block version is unrelated to fee policy. And also, mining with older version will not get transactions confirmed, the block will be rejected by other miners, I think.
If you used sendrawtransaction and it's not in the node's wallet, you just have to update to latest version of Dogecoin Core and delete mempool.dat.

So what’s the best way to get the current transactions mined?  I’m happy to pay for the hash but need to understand what to ask for.

Miner can decrease minrelaytxfee. Hopefully it will work.

It sounds like there is a way to push these through if someone could point us to a miner that we could pay to include them? Is this true?

This is possible and true, yes.

Do they just have to use an older version of the daemon so it can accept v3 blocks?

No, that's not needed. At the most you'd need to create a "payment transaction" on the top that will re-spend all your change outputs from the currently stuck transactions and pay the agreed fee.

If we did use sendrawtransaction, what's the easiest way to just delete all the 0 confirmed transactions? In the past in situations like this, we've had to dump all the keys, reimport, rescan to get to a clean state.

Step 1,3,4 and 5 that I outlined above are sufficient for that. You don't need to dump and reimport keys, -zapwallettx, has the desired outcome (that your unconfirmed wallet transactions are removed.)

Once we remove all the tx's from the wallet, we can just requeue and resend them all with the correct fee; the concern is during the 2 week its in the mempool, some of them somehow get mined and included at which point, we have double paid someone. I really want to avoid having to figure out all the inputs and creating a transaction just to doublespend them to avoid this situation.

You'd have to re-spend the inputs to be sure. I see how this can cause work, perhaps we can make a small script that takes a txid list in, and re-spends them, to automate this. May be of use for others as well.

Miner can decrease minrelaytxfee. Hopefully it will work.

If the miner just submits the tx to the node(s) that create the block templates, this should be enough.

Anyone have any contacts with mining pools?  i've been trying to each out to no avail.

Anyone have any contacts with mining pools? i've been trying to reach out to a few but to no no avail.

We're trying to get in contact with a few

@richiela If you have not resolved your issue, the upcoming release ( that should be out by the end of the week at the latest) will likely help you resolve your issue.

Miner can decrease minrelaytxfee. Hopefully it will work.

minrelaytxfee will be set to 1/1000 of its current value, so .001 DOGE, furthermore there was a bug with minrelaytxfee that has been fixed in 1.14.4, so you may set this fee higher and it will do the right thing in all scenarios.
@patricklodder @rnicoll @michilumin We can close this one.


Type breakdown

Added an English-language breakdown for the first polymorphically typed function introduced in the language lab.

This included unintended commits. Rebased and submitted new PR #116.


Write documentation

gettingStarted.adoc and introduction.adoc are still TODO

added some basic docs in b4a3c62239729ec8d189026b83df033ba0515081

Every repository contains a repository.adoc entry linking to the repo:
https://github.com/micronaut-projects/micronaut-security/blob/master/src/main/docs/guide/repository.adoc
and a releaseHistory
https://github.com/micronaut-projects/micronaut-security/blob/master/src/main/docs/guide/releaseHistory.adoc
and toc.yml is:
introduction:
  title: Introduction
releaseHistory: Release History
....
....
....
....
repository: Repository


Create 3209.json

its the german version

Hello,
Thank you for your contribution
I have pushed the translation file to the Test version of the world ( https://vrchat.com/home/world/wrld_e5237774-f905-495d-a97c-ba22a36b2249 ), but not the live version for now:
Due to the number of translated languages, I had to update the language selection panel to increase its capacity because it could not show up in the live version of the world; in turn, I had to update the world from Unity 2019 to Unity 2022, which isn't a small change, so it's going to stay as the Test version for a while until I'm better convinced the game is stable.


No posible to propagate for dates in the past with HighAccuracyTLEPredictor

As it is implemented now,  HighAccuracyTLEPredictor always uses the TLE closest to now(), dispate the propagation date requested.
https://github.com/satellogic/orbit-predictor/blob/master/orbit_predictor/accuratepredictor.py#L98-L105

cc @fisadev

Updated link:
https://github.com/satellogic/orbit-predictor/blob/ca67e2e859932938627ed24e5cbf58c887cd99c0/orbit_predictor/predictors/accurate.py#L97-L104


Only publish diagnostics if the client supports it.

Fixes issue #16.

The patch works, but I didn't like to write the code dealing with fetching the client capability to call Workspace#compile twice (on workspace init and on doc/save), any reasons why the Workspace object doesn't have an instance variable for the current Server object?

@hugopl Thanks for the PR, and sorry for the delay! 👍
@Sija Thanks for the review 👌

any reasons why the Workspace object doesn't have an instance variable for the current Server object?

Not really, I think I wanted to separate concerns when I began writing the code but as the Server & Workspace are tied anyway it does not really matter much. I'm fine with a bit of repetition.

@hugopl Thanks for the PR, and sorry for the delay! 👍
@Sija Thanks for the review 👌

any reasons why the Workspace object doesn't have an instance variable for the current Server object?

Not really, I think I wanted to separate concerns when I began writing the code but as the Server & Workspace are tied anyway it does not really matter much. I'm fine with a bit of repetition.


avoid corrupting tailing stream

Weee, it appears https://github.com/drone/drone-exec/pull/25 does not work as expected (or maybe as expected). While it doesn't do any additional harm, it seems very unlikely it will function as we discard the previously read bytes we also have a good chance of losing the headers that make StdCopy function.
Builds will instead fail with:
[error] Error streaming docker logs for docker.registry.com/team/image:tag. Unrecognized input header
[info] build failed (exit code 255)

To avoid re-outputting all of the run, we can instead resume and only grab the previous 1 line when starting the tail. This means we might miss some lines or duplicate a single line. The upside is the build will possibly resume instead of being marked fail.

Deployed this internally last night by using https://github.com/drone/drone/pull/1471. There's been a hundred-ish builds without a docker logs related error. We aren't using debug mode so we could just be lucky but I'm hopeful it's resuming as expected.

@macb thanks for testing this out. I really like the use of tail here ... great way to solve this problem

As a follow up to this, I repeatedly ran a build with debug turned on and was able to trigger the issue and the resume worked as expected.


Why data import for composition-data.txt not working? 0 record imported

mbp15a_u14dev:~/git/reactcms/site$ cat data/composition-data.txt
{
    "name":"composition",
    "module":    {
        "name": {
            "type": "string"
        },
        "description": {
            "type": "string"
        },
        "filename": {
            "type": "string"
        },
        "data": {
            "type": "object",
            "subtype": {
                "type": "json"
            }
        },
        "status": {
            "type": "string"
        },
        "create_date": {
            "type": "date"
        }
    },
    "count":1,
    "items": [{
        "name": "sidenav",
        "description": "sidenav composition",
        "filename": "sidenav.html",
        "data": [
            { "name":"r1c1", "description":"top", "width":12 },
            { "name":"r2c1", "description":"side", "width":4 },
            { "name":"r2c2", "description":"main", "width":8 },
            { "name":"r3c1", "description":"footer", "width":12 }
        ]
    }]
}

mbp15a_u14dev:~/git/reactcms/site$ node cmd.js initdb; node cmd.js import
remove announcement
remove article
remove composition
remove file
remove item
remove layout
remove linkset
remove page
remove user
----- initdb is done. -----
imported: (0) to module() from ./data/.gitkeep
imported: (0) to module(admin) from ./data/admin-data.txt
imported: (0) to module(announcement) from ./data/announcement-data.txt
imported: (8) to module(article) from ./data/article-data.txt
imported: (0) to module(component) from ./data/component-data.txt
imported: (0) to module(composition) from ./data/composition-data.txt
imported: (0) to module(file) from ./data/file-data.txt
imported: (0) to module(item) from ./data/item-data.txt
imported: (0) to module(layout) from ./data/layout-data.txt
imported: (1) to module(linkset) from ./data/linkset-data.txt
imported: (7) to module(page) from ./data/page-data.txt
imported: (3) to module(user) from ./data/user-data.txt
imported: (0) to module(web) from ./data/web-data.txt
----- import finished. -----

The import script try to read from ./data/.gitkeep, this file should be skipped in importing.

Fixed. The data field should be array, not object.

Only import *.txt now.
Jin
2015-04-25 9:18 GMT+08:00 leapon<EMAIL_ADDRESS>
Fixed. The data field should be array, not object.
—
Reply to this email directly or view it on GitHub
https://github.com/leapon/reactcms/issues/92#issuecomment-96117494.


Triage deny conn store

Signed-off-by: heanlan<EMAIL_ADDRESS>

Codecov Report

Merging #42 (836afd8) into main (bd82ef6) will decrease coverage by 20.92%.
The diff coverage is 31.57%.

@@             Coverage Diff             @@
##             main      #42       +/-   ##
===========================================
- Coverage   64.67%   43.74%   -20.93%
===========================================
  Files         278      210       -68
  Lines       39363    35734     -3629
===========================================
- Hits        25457    15632     -9825
- Misses      11945    18968     +7023
+ Partials     1961     1134      -827

Flag
Coverage Δ

kind-e2e-tests
?

unit-tests
43.74% <31.57%> (-0.09%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...ntroller/networkpolicy/networkpolicy_controller.go
53.94% <0.00%> (-17.11%)
:arrow_down:

pkg/agent/controller/networkpolicy/packetin.go
0.00% <0.00%> (-66.91%)
:arrow_down:

pkg/agent/openflow/packetin.go
0.00% <0.00%> (-63.64%)
:arrow_down:

...agent/flowexporter/connections/deny_connections.go
35.43% <22.72%> (-48.48%)
:arrow_down:

pkg/agent/flowexporter/connections/connections.go
49.45% <100.00%> (-28.58%)
:arrow_down:

.../flowexporter/connections/conntrack_connections.go
46.79% <100.00%> (-33.50%)
:arrow_down:

pkg/agent/flowexporter/exporter/exporter.go
49.50% <100.00%> (-22.03%)
:arrow_down:

.../agent/flowexporter/priorityqueue/priorityqueue.go
49.36% <100.00%> (-43.04%)
:arrow_down:

pkg/ovs/openflow/default.go
0.00% <0.00%> (-100.00%)
:arrow_down:

pkg/util/runtime/runtime.go
0.00% <0.00%> (-100.00%)
:arrow_down:

... and 202 more


Create governance document

The current QuTiP admin team (@quantshah, @BoxiLi, @ajgpitch, @Ericgig, @nwlambert, and @nathanshammah) has been working on a governance model and document in the past few months. We'd like to propose this to the broader QuTiP community of contributors and users. The main takeaway is that QuTiP has grown enormously in use in the past few years, thanks to the work of its creators, @jrjohansson and @nonhermitian, and a devoted group of core developers (among whose: @arnelg, @cgranade and many others), as well as now, over 80 contributors to the main qutip/qutip repository, as well as all the help on qutip-notebooks, qutip-doc, and qutip.github.io as well as the other packages that are now being spin out in the QuTiP Github organization to avoid feature creeps. Not to mention all the help provided in Qutip's google group, a forum for bugs, physics questions and research ideas. Over the years, the QuTiP project has enabled a large ecosystem of supported libraries, such as Krotov (cc @goerz and others), pyEPR (cc @zlatko-minev), scqubits (cc @jkochNU), and many others.
With this governance model, we'd like to keep doing what we're doing, with the support, since 2018, of @NumFOCUS, which supports scientific open source projects, and, from now on, the additional support of @unitaryfund, a non-profit that supports open-source projects in quantum technologies.
Below we reproduce a governance document that we will add to a new repository at github.com/qutip/governance. We are looking forward to help the growth of the user community, engage it with code contributions and bug reports, and make this awesome scientific open-source project even more sustainable. We will update all related information at github.com/qutip/governance, on QuTiP website's news section (http://qutip.org/news.html) and on the QuTiP google group (https://groups.google.com/forum/#!forum/qutip).
Timeline regarding governance talks:

April 2018: QuTiP Joins NumFOCUS as an Affiliated Project (and since then participates in Google Summer of Code).
September 2018:  a slide presentation is shared among lead developers with ideas on QuTiP development and governance. (Link)
February 2019: The first QuTiP developers workshop is held in RIKEN, Wako, Japan, to discuss development and roadmap (Link)
2019-2020: Seminars given in USA, Asia, and Europe about QuTiP and how the users community can get more engaged, collecting feedback on the package and project.
April-May 2020: Discussions for governance creation are revamped
May-August 2020: First draft document created and circulated among core developers and project creators.
Fall 2020: Feedback from NumFOCUS, Unitary Fund, update on the governance document.

Accepted @ajgpitch comment and edited from "fiscally sponsored" to "affiliated" project of Unitary Fund as per related discussion. We approved the document already, but having the PR reviewed & approved on Github by @ajgpitch @quantshah @nwlambert @BoxiLi @Ericgig would be nice.

Thank you all, just merged!


Remove legacy protocol from logserver

FYI @toregge @arnej27959

All applications in hosted Vespa (except those on 6.330) are now using the RPC protocol. What we remove first, legacy protocol in logd or logserver, should not matter afaik.

@arnej27959 Feel free to merge if necessary.


How does it differ from ZIM?

I had installed ZIM a while ago and just discovered oh my zsh and installed it too.
How do they relate? They both seem to improve ZSH and Oh My ZSH seems more advanced.

It seems zim is a derived version of zprezto, with a bigger focus on speed. Compared to OMZ is a faster framework but with less plugins. Take a look at both to see what's available on each one.
To be honest, I hadn't heard of zim before.


Is this a MS official tool?

I'm not very clear after reading README

No, it is not supported by Microsoft. We should probably update the usage agreement. @paolosalvatori, who works at Microsoft, initially created the tool as a Microsoft sample so I guess the license agreement is left from that time.

The tool is provided under Apache license: you can find the license in the main folder: https://github.com/paolosalvatori/ServiceBusExplorer/blob/develop/LICENSE.txt 😃


Fix: sets option flow config_entry explicitly [deprecation warning]

Fixes #4

Thanks!

https://github.com/AlexxIT/HassDiagnostics/releases/tag/v1.1.0


lm not converged!!

I plan to compare the results of fast gicp matching,
but I find that the results in my dataset are not very good, and there are problems with convergence.
Please help me analyze the reasons.
target:513658[pts] source:12879[pts]
--- fgicp_st ---
setinputtarget time:224.558[msec]
single:4930.35[msec] fitness_score:4.94828
--- fgicp_mt ---
setinputtarget time:216.625[msec]
single:970.577[msec] fitness_score:4.95613
--- vgicp_st ---
setinputtarget time:232.753[msec]
single:3645.91[msec] fitness_score:5.14035
--- vgicp_mt ---
setinputtarget time:241.628[msec]
single:832.951[msec] fitness_score:5.14035
--- vgicp_cuda (parallel_kdtree) ---
setinputtarget time:449.569[msec]
lm not converged!!
single:325.198[msec] fitness_score:5.18139
--- vgicp_cuda (gpu_bruteforce) ---
setinputtarget time:7665.43[msec]
single:323.909[msec] fitness_score:6.46557
--- vgicp_cuda (gpu_rbf_kernel) ---
setinputtarget time:8621.8[msec]
lm not converged!!
single:303.051[msec] fitness_score:4.98786
Here is my test set:
test.zip

Does the problem happen with only GPU-based methods?

Yes,but I focus on GPU-based.

I'm not sure but the cause can be that the target has too many points. The GPU implementations use single-precision floating points for fast computation and can suffer from a large mount of points. Try downsampling or cropping to reduce the number of points.

Thanks for your advice. I'll try it.


Allow the log file to be shared by multiple processes

Implemented a "shared" option to utilize existing shared file functionality in RollingFileSink

@masonkmeyer @mattbeatty Looks good! Thanks, guys!


[SPARK-24935][SQL][2.3] fix Hive UDAF with two aggregation buffers

What changes were proposed in this pull request?
backport https://github.com/apache/spark/pull/24144 and https://github.com/apache/spark/pull/24459 to 2.3.
How was this patch tested?
existing tests

cc @gatorsmile

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/10447/
Test PASSed.

Test build #105159 has started for PR 24539 at commit f16ff36.

+1

Test build #105159 has finished for PR 24539 at commit f16ff36.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
case class HiveUDAFBuffer(buf: AggregationBuffer, canDoMerge: Boolean)

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/105159/
Test PASSed.


Can't run application with docker

Try run in docker console: docker pull ekholabs/face-classifier
Returns: Using default tag: latest
Error response from daemon: pull access denied for ekholabs/face-classifier, repository does not exist or may require 'docker login': denied: requested access to the resource is denied
In console i'm successfully logged in

same here

Hello guys, try docker pull stephwag/face-classifier. It works for me.


Datepicker value mutating fix

Here is a gist which fixes the warnig and adds iconsFont property so you can use glyphicon or fa (Font awesome)
Also removes the default width ... works better with bootstrap grid
Also fixes window.removeEventListner typo
https://gist.github.com/purepear/df5fb8a6cc862071bb07ca5d059a0ade

I don't touched too much the code of datepicker but please update to the last version and make a pull request, I'll check it.


How works minRangeDate and maxRangeDate in Instance object.

How minRangeDate and maxRangeDate work on Instance object.

@albertIng86 please be clearer in your question


Expose Further TLS Options on ClientOptions

Is your feature request related to a problem or challenge? Please describe what you are trying to do.

Currently we only provide https://docs.rs/object_store/latest/object_store/struct.ClientOptions.html#method.with_allow_invalid_certificates
Some use-cases may be using an internal CA
Describe the solution you'd like

We should expose a mechanism to allow providing certificates. Generally we avoid exposing reqwest types, but a newtype wrapper of https://docs.rs/reqwest/latest/reqwest/tls/struct.Certificate.html should be fairly straightforward
Describe alternatives you've considered

Additional context

Hi,
I wanna code this feature. As I understand, the preferred solution is to have a new type struct UserCertificate(reqwest::tls::Certificate) and a method fn with_certificate(self, cert: UserCertificate) -> Self on struct ClientOptions, which eventually gets supplied to the underlying reqwest client while building.
Also, proper constructors on UserCertificate.
Is my understanding correct?

Hi, it's been a while and I couldn't manage time to get back to this.
I've created a PR making necessary changes. Please let me know if everything's in order, or suggestions if any changes are needed.


tests: pwm: Add test suite with GPIO loopback

Add PWM test suite which uses GPIO as loopback input to check the programmed timings.
Used for devices which don't have CC available.

We should probably align here since we have two PRs implementing gpio loopback for pwms https://github.com/zephyrproject-rtos/zephyr/pull/82485 :)

We should probably align here since we have two PRs implementing gpio loopback for pwms #82485 :)

hi @bjarki-andreasen, looks like we have a duplicate indeed :)
I wouldn't mind favouring either of them, how should we proceed?
Looks like so far this PR has more coverage in the tests (duty cycle tests, including 0 and 100%).

We should probably align here since we have two PRs implementing gpio loopback for pwms #82485 :)

hi @bjarki-andreasen, looks like we have a duplicate indeed :) I wouldn't mind favouring either of them, how should we proceed? Looks like so far this PR has more coverage in the tests (duty cycle tests, including 0 and 100%).

Your PR was created first, so it will take precedence unless you decide otherwise, I have asked the author of https://github.com/zephyrproject-rtos/zephyr/pull/82485 to review this one, I'm sure we can get something great out of it :)

We should probably align here since we have two PRs implementing gpio loopback for pwms #82485 :)

hi @bjarki-andreasen, looks like we have a duplicate indeed :) I wouldn't mind favouring either of them, how should we proceed? Looks like so far this PR has more coverage in the tests (duty cycle tests, including 0 and 100%).

Pinging @nordic-pikr as PR owner. Would you review this one?

Hi, I'm actually quite busy, I'm afraid I won't be able to do a review until the new year, at first glance, looks better than mine :)

@raffarost I think we can make it ready then.

thank you for your valuable comments! I hope to have addressed them properly.
I removed test-cases related to duty 100%+ as the API already does the check.
I'm still unsure about DEFAULT_PWM_PORT. It could go to Kconfig but there's also pwms which could define channel, period and flags. It can get confusing because of the Kconfigs for cycle and nsec settings and the test case for inverted signal, so I'd lean to adding it to Kconfig instead.


multiple threads

Dear Giulio,
How to use gfastats software with multiple threads?
I'm looking forward to your reply.
Best,
Du

Hi Du,
sorry for the late reply. Gfastats will automatically detect the threads available in your machine and try to use them all. You can also specify a number with the --threads or -j option.
Hope this helps!

Dear Giulio,
Thanks for your useful reply.
Best,
Du


Compilation fails for text-generation-benchmark

I'm getting this error when I try to compile text-generation-benchmark
#11 326.6    Compiling tokenizers v0.13.3
#11 329.9    Compiling text-generation-benchmark v0.1.0 (/app/text-generation-inference/benchmark)
#11 330.2 error[E0063]: missing field `max_tokens` in initializer of `Batch`
#11 330.2    --> src/generation.rs:142:17
#11 330.2     |
#11 330.2 142 |     let batch = Batch {
#11 330.2     |                 ^^^^^ missing `max_tokens`
#11 330.2
#11 330.3 For more information about this error, try `rustc --explain E0063`.
#11 330.3 error: could not compile `text-generation-benchmark` due to previous error
#11 330.3 warning: build failed, waiting for other jobs to finish...

I can't find where Batch is defined so no idea if the bug is justified.
Note: I messed around a bit with the code to get things to run with my setup (base image nvcr.io/nvidia/pytorch:23.03-py3 with python 3.8, bigcode transformers instead of @OlivierDehaene 's fork):
https://github.com/jlamypoirier/text-generation-inference/pull/1
https://github.com/bigcode-project/bigcode-inference-benchmark/pull/22

I see this addition from yesterday, could it be the problem?
https://github.com/huggingface/text-generation-inference/blame/main/server/text_generation_server/models/causal_lm.py#L50

Fixed on main.

Thanks!


Create route for getting analysis data

Description
For the home page we need to implement routes for getting the analysis data of the dashboard -

Data source disterbution.
Sentiment over time.
Trending keywords.
Weekly action items - Title, Done?, moreData.

DoD

[ ] We have route for getting the data needed for the home page.

@yoavrichter30 Weekly action items should be in a different issue


Fix Kubernetes Installation and Dependencies

Changes should allow developers to install and use K8 v1.31.0 instead of v1.19.0

lgtm


Unsubscribe link

Are unsubscribe links supported in some fashion?

@jaybeecave Not supported but I think the use case is common and could be integrated. Do you want to make a PR ?

Cool, ill try to get to it.


[Feature Request / Idea]: Use XDG Base Directory Specification by default

Suggestion / Feature Request
The shellclear/ and .shellclear/ directories unnecessarily pollute users' home directory.
The XDGBDS defines where these files should be placed with environment variables in order to avoid this.

The XDG Base Directory Specification is based on the following concepts:

There is a single base directory relative to which user-specific data files should be written. This directory is defined by the environment variable $XDG_DATA_HOME.

There is a single base directory relative to which user-specific configuration files should be written. This directory is defined by the environment variable $XDG_CONFIG_HOME.

There is a single base directory relative to which user-specific state data should be written. This directory is defined by the environment variable $XDG_STATE_HOME.

There is a single base directory relative to which user-specific executable files may be written.

There is a set of preference ordered base directories relative to which data files should be searched. This set of directories is defined by the environment variable $XDG_DATA_DIRS.

There is a set of preference ordered base directories relative to which configuration files should be searched. This set of directories is defined by the environment variable $XDG_CONFIG_DIRS.

There is a single base directory relative to which user-specific non-essential (cached) data should be written. This directory is defined by the environment variable $XDG_CACHE_HOME.

There is a single base directory relative to which user-specific runtime files and other file objects should be placed. This directory is defined by the environment variable $XDG_RUNTIME_DIR.

All paths set in these environment variables must be absolute. If an implementation encounters a relative path in any of these variables it should consider the path invalid and ignore it.

Hey @JacobTravers, thanks for reporting this issue.
Just to make sure that i understand, you suggestion is to manage the .shellclear in $XDG_CACHE_HOME instead of $HOME ?

Correct, so it should check first if $XDG_CACHE_HOME exists, if so it would use $XDG_CACHE_HOME/shellclear and if not it would fall back to .shellclear.
As for shellclear/, I might be mistaken but I believe there was an empty shellclear/ directory created in $HOME when I installed this with cargo install --git, but I'm not sure what data would have been there or how it would fit into the XDGBDS. It may have been a typo.

@kaplanelad can i work on it?

Sure @boaz-quotient Thank you.
In shellclear i'm using dirs crates. in this lib you have the function config_dir that already taking the $XDG_CONFIG_HOME with a default.
Please note that we need to support the old version, which means if the user already has the config file in $HOME path, we need to take it first
Thanks again


Port 2283 error

I installed the node, opened ports 2281 2282 2283. but when I start it gives me this error:
On the grafana website I see the connection but there are no gossip connections and no sync attempts.  how can I solve this problem?  I do it on my PC

Hey @Rrepl-ch, most home networks route your traffic via a NAT gateway. In short: this allows you to make outbound connections, but not receive inbound connections.
In order for hubs to work properly, they need to reachable from a public IP address. There are ways you can set up your home router to expose a specific host+port to the public internet, but it's highly dependent on your router, ISP, etc.
We recommend running a hub on a cloud infrastructure provider (AWS, GCP, etc.) so that you don't need to fiddle with your home network settings. Hope this helps!


feat(build): improve testing

Auto run tests with npm run test.watch and provides source maps for both spec and app files.
Fix #1180
Fix #1193

👍


Add pre-publish validation steps for nuget package

[ ] Verify binaries and packages are signed
[ ] Verify the package name matches our guidelines
[ ] Verify that we are not shipping Debug binaries
[ ] Verify we have a package description
[ ] Verify that we have a link to the project
[ ] Verify the package dependencies are allowed. In particular for our track 2 packages there is a limited set of dependencies we allow, we want to ensure we don't accidently depend on something we shouldn't.

Note that most of these are automatically handled by the nature of our primary release pipeline but we don't do any verification in our partner release pipelines and so this is more about that validation.

@chidozieononiwu, pretty sure we do most of these things already. We've had some partners request that we double check that we are doing all of the things in this list in .NET releases.

Hi @weshaggard, we deeply appreciate your input into this project. Regrettably, this issue has remained inactive for over 2 years, leading us to the decision to close it. We've implemented this policy to maintain the relevance of our issue queue and facilitate easier navigation for new contributors. If you still believe this topic requires attention, please feel free to create a new issue, referencing this one. Thank you for your understanding and ongoing support.


[MRG] make cell_response.write more robust

I was just trying to use this with Michael Hines and realized that it throws an error for a regular string. I think it should instead append the trial index instead of throwing an error.

Codecov Report

Merging #456 (2f6813e) into master (ad06968) will decrease coverage by 0.01%.
The diff coverage is 84.61%.

@@            Coverage Diff             @@
##           master     #456      +/-   ##
==========================================
- Coverage   88.51%   88.49%   -0.02%
==========================================
  Files          18       18
  Lines        3316     3328      +12
==========================================
+ Hits         2935     2945      +10
- Misses        381      383       +2

Impacted Files
Coverage Δ

hnn_core/cell_response.py
84.44% <84.61%> (-0.08%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad06968...2f6813e. Read the comment docs.

any reviews or comments @cjayb @ntolley @rythorpe ?

I made the writing more verbose to not surprise the user: https://github.com/jonescompneurolab/hnn-core/pull/456/commits/cd144701ad0911889dd1441956ebc6537d91253a
Let me know if you're fine with this @rythorpe or you prefer the other option

I made the writing more verbose to not surprise the user: cd14470
Let me know if you're fine with this @rythorpe or you prefer the other option

This is a good solution, thanks @jasmainak!


License of code files in the docs, esp. "ie10-viewport-bug-workaround.js"

I understand that the docs are licensed under CC-BY 3.0. However, this is unfortunate for the code portions of the docs.
Especially the file ie10-viewport-bug-workaround.js should IMHO be relicensed to MIT, as it is useful/necessary to handle the edge case of IE 10 on Win 8.
The code snippet in the file is also embedded in the docs without any licence statement. Of course, as it is part of the docs there, it would be subject to the CC-BY license, too. But, extending this logic, you would force all example code snippets to adapt the CC license, which would be absurd.
So, maybe it would make sense to put the example code from the docs under the MIT license.
Disclaimer: IANAL.

CC: @mdo

Woof, that's a doozy. Maybe @caniszczyk can weigh in. I'd love to simplify to one license.
However, relicensing the docs would be a pretty big undertaking I think. We'd need contact every contributor and ask their permission like we do with the move to MIT in v3. And we had @juthilo's help for that, too :).

In the particular case of ie10-viewport-bug-workaround.js, it should be feasible since only me and @XhmikosR have touched that code.

@mdo: I think that, for now, would be sufficient to relicense ie10-viewport-bug-workaround.js.
In the long run, I don't think that the entire documentation has to be relicensed, only certain code parts … code snippets and example templates. If these are used as starting points by developers, the resulting code will be subject to CC-BY. Or will it? For non-lawyers such as myself it's difficult to understand the implications of reusing CC-BY'd code, especially of merging it with other code.

Fine by me too.
I'd prefer one license for myself but for docs it make sense to use CC...
On May 14, 2015 1:08 PM, "Alex Günsche"<EMAIL_ADDRESS>wrote:

@mdo https://github.com/mdo: I think that, for now, would be sufficient
to relicense ie10-viewport-bug-workaround.js.
In the long run, I don't think that the entire documentation has to be
relicensed, only certain code parts … code snippets and example templates
http://getbootstrap.com/getting-started/#examples. If these are used as
starting points by developers, the resulting code will be subject to CC-BY.
Or will it? For non-lawyers such as myself it's difficult to understand the
implications of reusing CC-BY'd code, especially of merging it with other
code.
—
Reply to this email directly or view it on GitHub
https://github.com/twbs/bootstrap/issues/16470#issuecomment-101992054.

Cool, let's get that file at least changed then, and we can address the other parts.
All the code snippets are largely part of what Bootstrap provides in it's MIT-licensed code—our HTML, CSS, and JS. Based on that, perhaps we could just add a FAQ or two to the license page clarifying this?


Merging PR 758 blog post

Description
publishing 'Introducing open-source Kubernetes Operator for OpenSearch' blog post
Issues Resolved
N/A
Check List

[ x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the BSD-3-Clause License.

Now live! thanks again @shahar35 https://opensearch.org/blog/technical-post/2022/04/launching-open-source-operator-for-openSearch/


Unable to run notebooks due to kernel crash

Environment data

VS Code version:
Version : 1.59.0-insider (user setup)
Commit : 0f22f2d343e33b03e8033d1083513072f58ece21
Date : 2021-07-29T05:13:10.735Z
Jupyter Extension version (available under the Extensions sidebar): v2021.8.1077987658
Python Extension version (available under the Extensions sidebar): v2021.7.1060902895
OS (Windows | Mac | Linux distro) and version: Windows
Python and/or Anaconda version: 3.9.6
Type of virtual environment used (N/A | venv | virtualenv | conda | ...): none
Jupyter server running: Local

Expected behaviour
I'd like to run notebooks or interactive windows
Actual behaviour
While connecting to the kernel, I get the following error:
Info 2021-07-29 15:57:07: KernelProcess Exit Exit - 1 Traceback (most recent call last):
  File "C:\Users\raymondzhao\AppData\Local\Programs\Python\Python39\lib\runpy.py", line 197, in _run_module_as_main
    return _run_code(code, main_globals, None,
  File "C:\Users\raymondzhao\AppData\Local\Programs\Python\Python39\lib\runpy.py", line 87, in _run_code
    exec(code, run_globals)
  File "C:\Users\raymondzhao\AppData\Roaming\Python\Python39\site-packages\ipykernel_launcher.py", line 15, in <module>
    from ipykernel import kernelapp as app
  File "C:\Users\raymondzhao\AppData\Roaming\Python\Python39\site-packages\ipykernel\kernelapp.py", line 38, in <module>
    from .iostream import IOPubThread
  File "C:\Users\raymondzhao\AppData\Roaming\Python\Python39\site-packages\ipykernel\iostream.py", line 27, in <module>
    from jupyter_client.session import extract_header
  File "C:\Users\raymondzhao\AppData\Roaming\Python\Python39\site-packages\jupyter_client\session.py", line 41, in <module>
    from jupyter_client.jsonutil import extract_dates, squash_dates, date_default
  File "C:\Users\raymondzhao\AppData\Roaming\Python\Python39\site-packages\jupyter_client\jsonutil.py", line 10, in <module>
    from dateutil.parser import parse as _dateutil_parse
  File "C:\Users\raymondzhao\AppData\Roaming\Python\Python39\site-packages\dateutil\parser\__init__.py", line 2, in <module>
    from ._parser import parse, parser, parserinfo, ParserError
  File "C:\Users\raymondzhao\AppData\Roaming\Python\Python39\site-packages\dateutil\parser\_parser.py", line 45, in <module>
    from decimal import Decimal
  File "C:\Users\raymondzhao\AppData\Local\Programs\Python\Python39\lib\decimal.py", line 3, in <module>
    from _decimal import *
AttributeError: module 'numbers' has no attribute 'Number'

Steps to reproduce:

Run a notebook cell or an interactive cell in a Python file

Hi @rzhao271, are you running code to connect to the kernel? The "AttributeError: module 'numbers' has no attribute 'Number'" makes me think you are running code to connect to the kernel. Could you provide a screen recording of what you are doing when you get this error please?

TIL having a numbers.py file in the workspace is a bad idea 👀
Thanks @joyceerhl!


Deploy frontend to github pages

Right now we run the frontend code in a nodejs container on our server.
This isn't technically necessary. We could instead compile an optimized build and deploy a static app to Github Pages, pointing it to our API. That'd reduce load on our end.

I... don't think we want to do this; it's simpler to just run this on our own infra for now.


Make DateAttributedFormatStyleTests.testSettingLocale time zone independent

In JST (GMT+9) the date will be 2021-04-13 00:04:32, so the tests would fail.
Kudos to @norio-nomura

@swift-ci test

@itingliu Thanks for your review! I don't have the commit access for this repository, so could you please merge this?


Fixes #25. Return 403 when forbidden instead of 500

This introduces a forbidden exception to issue #25 which I think is distinctly different from #7.  From what I can tell, all the place here are 403s and not 401s

thx for your contribution


fs.existsSync is not a function

Hello,
Working on a Node + onoff project. Trying to create a simple LED function, but I am receiving an error that I can't find a way to fix. my code :
var LED = new Gpio(4, 'out'); //use GPIO pin 4, and specify that it is output
var blinkInterval = setInterval(blinkLED, 250); //run the blinkLED function every 250ms
function blinkLED() { //function to start blinking
  if (LED.readSync() === 0) { //check the pin state, if the state is 0 (or off)
    LED.writeSync(1); //set pin state to 1 (turn LED on)
  } else {
    LED.writeSync(0); //set pin state to 0 (turn LED off)
  }
}
function endBlink() { //function to stop blinking
  clearInterval(blinkInterval); // Stop blink intervals
  LED.writeSync(0); // Turn LED off
  LED.unexport(); // Unexport GPIO to free resources
}
setTimeout(endBlink, 5000); //stop blinking after 5 seconds

Error :
TypeError: fs.existsSync is not a function
    at exportGpio (onoff.js?b64a:16)
    at new Gpio (onoff.js?b64a:172)

Node version 10.10.0. The LED works fine with a python script.

I just tried the following program with Node v10.10.0 and it works fine for me.
var Gpio = require('onoff').Gpio;
var LED = new Gpio(17, 'out'); //use GPIO pin 4, and specify that it is output
var blinkInterval = setInterval(blinkLED, 250); //run the blinkLED function every 250ms
function blinkLED() { //function to start blinking
  if (LED.readSync() === 0) { //check the pin state, if the state is 0 (or off)
    LED.writeSync(1); //set pin state to 1 (turn LED on)
  } else {
    LED.writeSync(0); //set pin state to 0 (turn LED off)
  }
}
function endBlink() { //function to stop blinking
  clearInterval(blinkInterval); // Stop blink intervals
  LED.writeSync(0); // Turn LED off
  LED.unexport(); // Unexport GPIO to free resources
}
setTimeout(endBlink, 5000); //stop blinking after 5 seconds

The LED blinks for 5 seconds and then the program gracefully terminates as is to be expected. Two modifications were made to the program. GPIO17 was used in place of GPIO4 and the following line was added to the program:
var Gpio = require('onoff').Gpio;

How come this line was missing from the program you posted?
Is anything else missing from the code you posted?
Is there something special about the way require is handled on your system?
What is the output of the following program on your system:
var fs = require('fs');
console.log(fs.existsSync);

Hers's the output that I see with Node v10.10.0 on a Raspberry Pi:
[Function: existsSync]

Sorry, left that line out accidentally. I tried it with a few GPIO pin numbers, 4 and 17 included. Printing fs.existsSync gave me 'undefined' . Everything is pretty much stock settings in terms of webpack. There is something wrong in my app since I have the same exact output on my Windows machine as well as the Pi, not sure what.

Printing fs.existsSync gave me 'undefined'

Are you running the program from the command line using a command like node yorrAppName.js? If not, I wouldn't expect it to work.

Everything is pretty much stock settings in terms of webpack.

What is webpack being used for? I thought webpack was for bundling JavaScript files for usage in a browser. Why is it being used here? Note that onoff is not suitable for usage in a browser.

Oh that's the problem then. I was not aware it does not support browsers. Apologies! Could you point me to the right direction then? Thanks!

I'd suggest taking a look at a tutorial about using Node.js in general or using Node.js on a Raspberry Pi. For example, this tutorial explains how to use Node.js and onoff on a Raspberry Pi.
I'm going to go ahead and close this issue as there doesn't appear to be a problem with onoff.


Use SLF4J logger instead of DefaultLog

In the latest Maven nightly version the DefaultLog class has been renamed.
This makes nightly tests fail as we use the DefaultLog class here https://github.com/gradle/gradle-enterprise-build-config-samples/blob/d389428132f95a713eaaafdf2c6d43c81bde84fb/common-custom-user-data-maven-extension/src/main/java/com/gradle/GroovyScriptUserData.java#L46
We propose to use the SLF4J logger instead as this is stable, but this would mean that some users might have issues as this is a breaking change as the API of the DefaultLog is different.

Can you please also ask @marcphilipp for review. See also my question here.

I'm also in favor of #166.


Last error code cannot be accessed

I have seen that you can access now from SQLite::Statement the last status. Why isn't there a method in SQLite::Database to get the last status / error code (,either)? This is useful in case you want to detect the reason in case an exception is raised and the exception handler has no access to the statement.
BTW: There is a method to get the last error message but not the status.

Sorry for the very unusual delay, I was busy with my family and other projects!
I've looked into this and decided to clean up the Statement class. I will remove the mLastStatus that is not always correct, and add an errcode() method (both to Database and Statement classes)

Hi Sébastien,
thanks for the fix!
Regards,
Hartwig

Am 08.03.2015 um 12:20 schrieb Sébastien Rombauts<EMAIL_ADDRESS>Sorry for the very unusual delay, I was busy with my family and other projects!
I've looked into this and decided to clean up the Statement class. I will remove the mLastStatus that is not always correct, and add an errcode() method (both to Database and Statement classes)
—
Reply to this email directly or view it on GitHub https://github.com/SRombauts/SQLiteCpp/issues/37#issuecomment-77744057.


Concretely choose a dataset to work with

Regarding the clean dataset:

There are 708 components with a Norris SWIRE cross-identification that have a corresponding Franzen component;
Of these, 608 components have a named SWIRE cross-identification;
Of these, 385 have an S/Sp ratio < 1 (compact);
Of these, 382 have a unique SWIRE cross-identification;
Of these, 341 have a Zooniverse ID;
Of these, 337 have an RGZ SWIRE cross-identification;
Of these, 329 have a unique Zooniverse ID.

#242


Simplify Message vs DefaultMessage

Right now, it's a bit of a mess. The Message type sometimes has to be used, sometimes we need to use DefaultMessage. Same with NoArgMessage(s); all this just to make the type system happy so that dangerous combinations are not used.
This comes down to Bound messages (using with()) and the fact that some messages will deliver an Array, some others a scalar and there is no way to know which is which at runtime.
In order to fix this, we can abandon Arrays and declare multi arg Messages like so :
const message = Message<number, MouseEvent>('click')

Fixed in 0.28.0


Do not call filter-shipping-methods webhook for non-editable orders

I want to merge this change because it removes the sync webhook call for filter-shipping-methods, when the order is not editable.

Impact

[ ] New migrations
[ ] New/Updated API fields or mutations
[ ] Deprecated API fields or mutations
[ ] Removed API types, fields, or mutations

Docs

[ ] Link to documentation:

Pull Request Checklist

[ ] Privileged queries and mutations are either absent or guarded by proper permission checks
[ ] Database queries are optimized and the number of queries is constant
[ ] Database migrations are either absent or optimized for zero downtime
[ ] The changes are covered by test cases
[ ] All new fields/inputs/mutations have proper labels added (ADDED_IN_X, PREVIEW_FEATURE, etc.)
[ ] All migrations have proper dependencies
[ ] All indexes are added concurrently in migrations
[ ] All RunSql and RunPython migrations have revert option defined

Is this documented?

@maarcingebala  added: https://github.com/saleor/saleor-docs/pull/1281


Hawkular integration: Initial commit.

Added new class for Hawkular REST API methods. Created new method in rest_client to return JSON only.

Coverage increased (+0.04%) to 27.482% when pulling 9e418eecc25709624153c90b16d8a3d7bede3e57 on hhovsepy:hawkular_integration into 69a8fc3bf8a7280f7cf3a5e264ef89ccd746845f on RedHatQE:master.

Lint report for commit 9e418eecc25709624153c90b16d8a3d7bede3e57:
mgmtsystem/hawkular.py:

:bangbang: Line 28:1: E302 expected 2 blank lines, found 1
:heavy_exclamation_mark: Line 28:24: W291 trailing whitespace
:heavy_exclamation_mark: Line 34:51: W291 trailing whitespace
:heavy_exclamation_mark: Line 35:49: W291 trailing whitespace
:bangbang: Line 41:48: E226 missing whitespace around arithmetic operator
:bangbang: Line 41:61: E226 missing whitespace around arithmetic operator
:bangbang: Line 41:79: E226 missing whitespace around arithmetic operator
:bangbang: Line 41:92: E226 missing whitespace around arithmetic operator
:bangbang: Line 41:101: E501 line too long (105 > 100 characters)
:heavy_exclamation_mark: Line 51:36: W291 trailing whitespace
:bangbang: Line 52:101: E501 line too long (120 > 100 characters)
:heavy_exclamation_mark: Line 55:1: W293 blank line contains whitespace
:bangbang: Line 59:48: E226 missing whitespace around arithmetic operator
:bangbang: Line 59:61: E226 missing whitespace around arithmetic operator
:heavy_exclamation_mark: Line 64:1: W293 blank line contains whitespace
:bangbang: Line 68:48: E226 missing whitespace around arithmetic operator
:bangbang: Line 68:61: E226 missing whitespace around arithmetic operator
:bangbang: Line 68:79: E226 missing whitespace around arithmetic operator
:bangbang: Line 68:92: E226 missing whitespace around arithmetic operator
:bangbang: Line 68:101: E501 line too long (105 > 100 characters)

Please, rectify these issues :smirk: .
CFME QE Bot

OK fixing.

Updated and squashed.

Lint report for commit 8693c508d1f9139782e5cb037bbc5dfe3e37b27f:
Everything seems all right :smile: .
CFME QE Bot

Coverage increased (+0.04%) to 27.482% when pulling 8693c508d1f9139782e5cb037bbc5dfe3e37b27f on hhovsepy:hawkular_integration into 69a8fc3bf8a7280f7cf3a5e264ef89ccd746845f on RedHatQE:master.

I believe this also needs something like this https://github.com/RedHatQE/mgmtsystem/blob/master/mgmtsystem/openstack.py#L67 to make the integration iwth provider code in cfme_tests seamless.

Lint report for commit f97a2d15ef5fb41f85f0ebb7eb46263343318597:
Everything seems all right :smile: .
CFME QE Bot

@mfalesni nice catches, thank you :) :+1:
changed squashed

Changes Unknown when pulling 58ca1d1b35df26e809dbaa6aff07866841a1f40d on hhovsepy:hawkular_integration into ** on RedHatQE:master**.

changed squashed

Lint report for commit 58ca1d1b35df26e809dbaa6aff07866841a1f40d:
Everything seems all right :smile: .
CFME QE Bot

rebased

Lint report for commit 1364e04aae8066ff7ed9361a878391e080e44ea9:
Everything seems all right :smile: .
CFME QE Bot

@psav What do you say? I think from the code POV it looks OK.
@hhovsepy Did you test it against some hawkular provider? Or can you pass us some credentials to some hawkular (via IRC) so we can try it on our own?

@mfalesni I have locally created test case, will send it to you, not sure about committing it

Looks good to me @mfalesni

@psav Hayk sent me the test case and it seems to work correctly. Merge and release? :)

:)

and please let us know how to have the release to be used locally in cfme_tests


Use oc adm prune renderedmachineconfigs to remove older machine configs

#875

/retest

/retest

/cherry-pick master

Tested the bundle and it now have only single machine config for master and worker which doesn't have pull secret information.


Rename ios bundle

This PR contains a number of edits (mostly having to do with renaming the app bundle) required to get the app into the iOS store.

I believe there's one more case change eduwallet.xcworkspace → eduWallet.xcworkspace (may just be a case-insensitive problem on my os), but after updating that, I was able to build the app.

@sethduffin - thanks! Merging.


Add command line for opening file & specifying version to open with

Describe the solution you'd like
It looks like the only command line arguments are for json encoding? I'd like to specify the path to a uasset file & version needed to open with on command line.
Additional context
Something like:
uassetgui.exe open path/to/file.uasset VER_UE4_22

Command line arguments for opening files have existed since day 1; see Form1.cs. Added support for specifying version in 365e1cc


Move plugin definition locally

What this PR does / why we need it

This moves the PluginDescriptor and some helper functions to be light
weight, locally defined interfaces with the community-edition repo.
Details for the Release Notes (PLEASE PROVIDE)
Fixes: https://github.com/vmware-tanzu/community-edition/issues/2811

NONE

Describe testing done for PR

Built plugins locally with make build-install-plugins-local.
Special notes for your reviewer

As part of this work, let's be sure to add a tracker issue to the TCE repo, stating what's needed to move back to framework and capture details of why we did this (for future forgetfulness).
Let's then link it to track https://github.com/vmware-tanzu/tanzu-framework/issues/1476 and update https://github.com/vmware-tanzu/tanzu-framework/issues/1476 to include details of what we did to work around this near term. Let's be sure to express we'd like to go back to referencing framework.

I added this this fixes https://github.com/vmware-tanzu/community-edition/issues/2811 and assigned it to @stmcginnis

Hmm, I don't think I tried that specific target. Will investigate today.

Updated PR to point to our next branch while we are waiting for v0.10.0 to finalize.


How to use short query

I tried to test with short query, but I get it. why 0 Operations..

use complex query, I can "Successfully generated 100 database validation parameters"

Hi @shikeno You need to enable both the complex queries and updates as well to run short queries.
(This is a limitation of the driver that could be fixed but we never gave it much priority.)

嗨@shikeno 您需要同时启用复杂查询和更新以运行短查询。 （这是可以修复的驱动程序限制，但我们从未给予它太多优先级。）

Thanks for your explaination  : )


feat(cli): change generate --prefix option type from Boolean to string

Use ng g c foo --prefix='bar' or ng g d foo --prefix='bar' in order to use
another prefix than the one defined by default in angular-cli.json apps[0].prefix
Any other options (--no-prefix or --prefix, without any value, using the default one in angular-cli.json) still work as expected and documented.
Tslint rules "directive-selector" and "component-selector" can accept any array of prefix, and is therefore compatible with this approach.
This could be a first solution to #3452.

This is my first PR on angular-cli, and I don't understand for now why CI is not passing ... If someone could tell me what should I do to correct this ... Thanks.

@noelmace CI broke due to something else but it should be fixed soon in https://github.com/angular/angular-cli/pull/3465.
@Brocco can you review?

Thanks @noelmace!!!


WeakRefStringArray: make eltype respect Missing

Enhances #17 so that WeakRefStringArray allows missing iff
the underlying WeakRefString Array allows missing.
Should fix the eltypes of the dataframes returned by CSV.jl.
Needs tests.

I've tried to fix 0.7 adding ncodeunits(), but there's another error when calling WeakRefStringArray(data::Vector{UInt8}, A::Array{Union{WeakRefString{UInt8}, Missing}, N}) ctor, which I don't understand.
Looks like the ctor doesn't recognize it should support Missing.
This doesn't happen on 0.6 and I don't have a working 0.7 setup.

Closing in favor of #21 (hope you don't mind that I stole several bits from here though 😃 )

@quinnj Sure, no problem

As noted on #21, I think we still need this.


Bluetooth device name on iOS is not updated

I am developing a bluetooth device which my app should connect to. During testing, I changed the name of my bluetooth device. On Android, it works absolutely fine and as expected. However, as iOS always does things differently, it does not work.  In fact, iOS caches bluetooth names according to this SO answer. The author mentions a different approach  of getting the real (updated) name which could be used here. What do you think?

I think this is either a duplicate of, or closely related to, #143.
In either case, yes, we need to make some changes there to make the uncached name available.
We've been swamped with some deadlines lately, but I hope to be able to put some more time to Kable in the coming weeks.

Alright, I'll close this issue in favor of #143. Thanks!


docker.pull() does not have callback as the last param, so it needs to be manually promisified

Dockerode's pull has these params:
Docker.prototype.pull = function(repoTag, opts, callback, auth) { ... }

So callback is not last.  This means it can't be automatically promisified.
This code seems to work:
Promise.fromCallback(function(callback) {
    return docker.pull(repoTag, opts, callback, auth);
})

I'm assuming you'd have to add a manual exception in index.js, like you do already for getContainer() and getImage().  Does that sound right?  I can make a PR if that's helpful.

Please make a PR.
I stopped using dockerode-bluebird in favour of docker-cli-js.


RFM - lili

I DON'T Want To Become The Maintainer

[x] I have followed the Package Triage Process and I do NOT want to become maintainer of the package;
[x] There is no existing open maintainer request for this package;

Checklist

[x] Issue title starts with 'RFM - '

Existing Package Details
Package URL: https://chocolatey.org/packages/lili
Package source URL: https://github.com/dtgm/chocolatey-packages/tree/master/automatic/_output/lili/2.9.4
Date the maintainer was contacted (in YYYY-MM-DD): 2021-12-13
How the maintainer was contacted: Contacted via Email

Hello, Lili has been abandoned, https://www.linuxliveusb.com/fr/blog/frontpage
So, it's not required to be updated anymore.
Have a nice day.


CNF-14862: Configure AlertManager to send alerts

Add a webhook receiver to AlertManager configuration so that alarm server is notified to the internal endpoint.

/cc @browsell

/approve
will make any follow up changes as needed to AM config but I think we can get started with building on top of this!


Research ReactFlow library to replace DMN Editor canvas

Research the ReactFlow [1] library as possible candidate to replace the actual DMN Editor canvas.
[1] https://reactflow.dev/

At this point I can say that the research phase is done. The new React-based DMN Editor is almost ready to be shared with a wider audience, missing just some minor details about editing Edges and Waypoints. Of course, full parity with the current DMN Editor is not going to be reached at this time, and more iterations will have to be done.
ReactFlow is an amazing library, with a vibrant community and excellent code and documentation. I was able to use the majority of the features ReactFlow provides to solve problems that exist on the DMN Editor diagram editing.
ReactFlow is being renamed to XYFlow, which will require us to make some changes pretty soon.
Stay tuned for updates here:

#439


Install instructions not up to date

##Note
Up date instructions for latest release.
Describe the bug
A clear and concise description of what the bug is.
Logs
Please provide a log file from the directory %USERPROFILE%\Documents\Captain of Industry\Logs

Hi, what are you calling out as not up to date? You didn't include any specifics about what you view as wrong in your issue. As far as I am aware current instructions are correct.

Closing as ticket has insufficient detail.

The path you provided is actually equivalent to the path in the mod instructions. You can validate this by pasting that path provided in the instructions into your folder address bar and seeing where it takes you. This path is dynamic so we use features of windows which represent that path dynamically.


Blog post

From staging to prod

@janhoy apparently there are conflicts, not sure why this could happen?
Also I noticed that It didn't squash the commits from the blog pull request, is it something we don't do for the site?
Normally it does it automatically for the solr code

Resolved!

hi @janhoy  when are we supposed to see the changes online?
I took a look this morning and it's not there yet?

hi @janhoy when are we supposed to see the changes online? I took a look this morning and it's not there yet?

https://solr.apache.org/blog.html


Create a smoke test for installers

Would like to design/create a smoke test consisting of several basic checks to be run or triggered at the end of the installer jobs to verify the installers are sane.
Related to https://github.com/AdoptOpenJDK/TSC/issues/151 and https://github.com/AdoptOpenJDK/openjdk-tests/issues/1421

Did we speak about automated/scripted smoke test here ? or just a manual check-list ?

Ok, I was speeking about the MSI installer :) for wich we have no test beside the Wix smoke.exe

Smoke | Runs validation checks on .msi or .msm files.

I don't know well testcontainers but it seems not usable to validate MSI on Windows container

https://www.testcontainers.org/supported_docker_environment/windows/
Windows Container on Windows (WCOW)
WCOW is currently not supported, since Testcontainers uses auxiliary Linux containers for certain tasks and Docker for >Windows does not support hybrid engine mode at the time of writing.

And as MSI install depends on a Windows service "Windows Installer" I think it will probably not be a good candidate for containerization
PS: we don't have Jenkinsfile either now for the msi installer

There was some experimentation to make TestContainers work with that thing that's built into Windows Server 2016 and newer. Theoretically, it should work if you disable the auxiliary containers (we have to do the same on Linux because not every arcane architecture is currently being supported by TestContainers). I'd be surprised if it's not possible to install an MSI on a Windows container, but considering that the container support in Windows is a strange beast 🤷
There are two possible alternatives: Using docker commands directly (was briefly considered for Linux; so basically issuing shell commands with docker exec against the running container and evaluating the output) or using Vagrant with VMs (very slow because you have to start a new VM for every test to have a reliable environment, especially registry).
The biggest challenge is going to be macOS because macOS doesn't like to be automated or virtualized. I see two workable solutions: Use Vagrant + Parallels Desktop Pro (the edition that supports linked clones for fast startup) or try https://veertu.com/anka-build/.
I wanted to commission some projects to get this done for all platforms. But there's zero interest. I find that topic interesting, but it needs organizational support that doesn't exist either. So I gave up.

FYI @sophia-guo

Boilerplate to build upon for a test with a container on Windows:
$container = docker run --rm -d -t mcr.microsoft.com/windows/servercore:ltsc2019
docker cp "C:\Users\Administrator\Downloads\OpenJDK11U-jdk_x64_windows_hotspot_11.0.11_9.msi" "${container}:C:\Users\Administrator\OpenJDK11U-jdk_x64_windows_hotspot_11.0.11_9.msi"
docker exec -it $container powershell -command "Start-Process C:\Windows\System32\msiexec.exe -ArgumentList @('/i C:\Users\Administrator\OpenJDK11U-jdk_x64_windows_hotspot_11.0.11_9.msi', 'INSTALLLEVEL=1') -Wait"
docker exec -it $container powershell -command "java -version"
docker kill $container

Those 5 lines copy a local MSI into a container (for example, generated by the build process), install it (you have to wait for the installation to complete, therefore Start-Process instead of invoking msiexec directly), run java -versionand remove the container afterwards. That follows what the tests for the Linux packages do, too. Instead of runningjava -version`, you can do other things (like querying the registry) and inspect the output to stdout. I'd write a Java class that wraps the Docker commands with ProcessBuilder and forget about TestContainers (possibly for Linux, too). Because:

We don't need most of the functionality that TestContainers brings to the table (like connecting to MySQL, for example) or having fancy wait commands.
By having to disable all auxiliary containers, we're not better off than if we run everything ourselves. If the JVM gets killed, a container might stay around. TestContainers fixes this by having an auxiliary container (Ryuk) that removes stale containers. If we disable Ryuk, we're back on square one.
TestContainers has some problems I discovered while developing tests, for example weird wrapping of stdout or not being able to copy moderately sized files without huge amounts of RAM. docker cp is significantly more efficient. This could be fixed, but seems like a lot of work.
TestContainers brings still some dependencies on native code AFAIK. Considering the state of the Windows on ARM ecosystem, I wouldn't hold my breath to wait for everything to get ready. This is also the reason I'd use Java instead of my usual msbuild/C#/VS Studio combo when working with MSIs because there's no VS Studio yet for Windows on ARM as far as I know and testing needs to happen on the target platform.
Being not dependant on TestContainers on Linux might be an advantage, too, especially considering the recent push for podman on some distributions where it's hard to get Docker to work (podman is still no drop-in replacement for Docker when it comes to TestContainers).

One thing I noticed while working with Docker on Windows: It seems slow (might be caused by that machine I used that was running on OpenStack). Using Vagrant with a performant virtual machine manager might be as fast. There's even a Hyper-V plug-in for Vagrant. The big advantage of using Vagrant: We'd have a UI. This would allow to examine the graphical installer which might be of interest.


Disable ios screen rotation in device health check

The test beds should get quarantined if the screen rotation is enabled. Android check has been available in https://github.com/flutter/cocoon/pull/1532. We need to do the same for ios phones.

#123195 133314


Hide tab fade until text overflows with sizing-shrink and close-button-left/off (fix #45728)

Moved the padding-right into the label text, which should hide the tab fade while there aren't enough tabs to fill the tab bar (or until a tab gets the .dirty class) #45728

@Dari-K good stuff 👍


Add --style option for style related fixes

Currently, dartfix has two conflated rolls:

Language upgrade fixes:

Converting classes used as mixins to use the new mixin syntax
Moving named constructor type arguments from the name to the type

Stylistic code changes:

Converting double literals to int literals where applicable

While the latter is good, the primary roll of dartfix is the former, and currently there is no way to upgrade without applying the stylistic changes. As I see it, there are two ways we can address this:

Only apply stylistic code changes if a new --style option is supplied.
This is similar to dartfmt --fix

Apply stylistic code changes unless a new --upgrade option is supplied.

Maybe generalize this a bit further and differentiate between required updates and suggested updates?


Document prefix usage for collections more clearly

There should be a small section describing prefixes for storage collections and why they are important. Motivation based on question in zulip "I was wondering if anyone could explain the mechanics (why/deep-dive) we need to use unique prefixes in collections in the near-sdk? (e.g.: in RUST, LookupMap<K,V>::new(b"r" ... etc prefix = b"r")
Thanks!"
Quick answer:
So the storage layer of the NEAR runtime operates on key/value pairs which are bytes (&[u8]). When you are doing a lookup with LookupMap for example the byte string that will be used for the lookup will be a concatenation of the prefix and the key serialized to bytes ().
You need unique prefixes because there will be collisions and each structure will be reading, writing, and overwriting the same keys in storage, causing inconsistencies and unintended behaviour.
To document:

What a prefix means and why it is necessary to be unique
Basic usage with links to the trait IntoStorageKey rustdocs
Usage with enums and more complicated data types: BorshStorageKey derive

This is now explained, with a whole example on how the prefix is then reflected in the state


Same sense of meaning SW_STRAP

Separate commits and separate pull requests!?

;-) sry
was my mistake.
want make one pull request with 2 edit files.
but could not add the second edit to the other file to the one pull request
Still has to practice pull request
best wishes
rudi ;-)

Thanks for this, Rudi. I've squashed this commit with the one from #366 and added them to our internal review & merge queue.

Cherry-picked in  f4c4787, thanks again!


(PUP-4751) Optimize & Secure safe_posix_fork

Before this, on POSIX systems, each time we execute a command, it forks a new process and this one will close inherited file descriptors by looping between 3 and 256 although there is more than 256 possible file descriptors. It's not safe and it's really slow.
Now, we try to list open file descriptors by reading "/proc/self/fd" and close the ones we don't want. This will fallback to the original method if it can't find "/proc/self/fd".

I've added a test when /proc/self/fd doesn't exists

CLA signed by all contributors.

@peterhuene Specs now stubs Dir.foreach and it was already checking for FileDescriptors 0, 1, 2


[WIP] Carrierwave file storage

Defaults to carrierwave with file system storage if Cloudinary is not configured.

#355


Set up CI with Azure Pipelines

[skip ci]

Q
A

Bug fix?
no - yes?

New feature?
no - yes?

New sample?
no - yes?

Related issues?
fixes #X, partially #Y, mentioned in #Z

What's in this Pull Request?

Please describe the changes in this PR. Sample description or details around bugs which are being fixed.
(DELETE THIS PARAGRAPH AFTER READING)

Guidance

Please update this PR information accordingly. We'll use this as part of our release notes in monthly communications.
Please target your PR to dev branch. Released documents are in master branch.
(DELETE THIS PARAGRAPH AFTER READING)

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: shaktismishra sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

Closing due to lack of details and CLA not being signed.


Is there some way to disable the key binding for showing "Bazel Problems" window

Currently, when I press Ctrl-X followed by Ctrl-B this pops up the "Bazel Problems" view pane. However, I already have this shortcut configured in my IntelliJ Keymap and the plugin seems to override this key binding. Also, the shortcut for the Bazel plugin doesn't itself show up in the Keymap, so I can't figure out how to disable it. Is there some way to disable this shortcut or at least configure it to be something else in the plugin?

I can't reproduce the issue you're describing. I'm also not aware that that there was a default shortcut for it.
In any case, "Bazel Problems" is a tool window and thus can use IntelliJ's built-in mechanism for keyboard shortcuts. If you go to IntelliJ's keymap in the settings, look for "Bazel Problems" under "Tool Windows".


Update kind-projector to 0.12.0

Updates org.typelevel:kind-projector from 0.11.3 to 0.12.0.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.typelevel", artifactId = "kind-projector" } ]

labels: library-update, semver-minor

Codecov Report

Merging #214 (51919e8) into master (7617dfe) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #214   +/-   ##
=======================================
  Coverage   94.57%   94.57%
=======================================
  Files          35       35
  Lines         221      221
  Branches       10       10
=======================================
  Hits          209      209
  Misses         12       12

Flag
Coverage Δ

unittests
94.57% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7617dfe...51919e8. Read the comment docs.

Superseded by #218.


update coding style (discuss/vote) for unused arguments

quoting https://github.com/openssl/openssl/pull/2270#issuecomment-274941918:
It would probably be appropriate to mention this in coding style... I'd also argue that last sentence in chapter 6 could be relaxed to permit _unused suffix or unused_ prefix in function implementation. Though there is bunch of cases where additional pre-/suffix doesn't formally conflict with the last sentence of the chapter 6. Cases when static methods get implemented and don't require all the arguments...

Or in other words. Last paragraph of Chapter 6: Functions currently reads

In function prototypes, include parameter names with their data types.
Although this is not required by the C language, it is preferred in OpenSSL
because it is a simple way to add valuable information for the reader.
The name in the prototype declaration should match the name in the function
definition.

And suggestion is to add something in following spirit. Unused arguments may have _unused suffix in definition [which is likely to be more common in methods and callback implementations]. Unused arguments should be "short-circuited" early in function body by casting them to (void).

moved to https://github.com/openssl/web/issues/48


Vue-router doesn't react on browser history back and forward

Version
3.6.5
Reproduction link
I can't provide it since I don't know how to stably reproduce the issue. Hope on some magical guess only.
Steps to reproduce
I have no idea how to reproduce it, even with my application I can't stably reproduce the issue. A couple of days ago I upgraded vue-router from 3.1.3 to 3.6.5 together with vue upgrade from 2.6.4 to 2.7.13. Also, I can see the issue only with the production build.
When the issue takes place, navigation guards beforeEach, beforeResolve, afterEach are not triggered.
⚠ I noticed that I can stably reproduce the issue in new tab of browser, after refresh issue is not repeated, I will try to make a reproduction project.
What is expected?
Vue-router always reacts on browser history back.
What is actually happening?
In some circumstances, vue-router stops reacting to browser history back, but <router-link>s (and hence router.push) continue working.

Any ideas?

Well... I finally noticed that router becomes broken because of our internal logic related to the locale URL prefix. So closing the issue...


remove force_static from componentregistry module

Summary:
changelog: [interna]
force_static doesn't need to be in here, let's remove it.
I change one module per diff. It makes it easier to land it and pinpoint where build failures are coming from.
Reviewed By: javache
Differential Revision: D56632286

Merged as https://github.com/facebook/react-native/commit/bb2c13af5372856cf3f4222ad6543d4698919dbc


TODOs in this repo should point to useful github issues

PhET has a policy that TODOs in production code are tied to a github issue to help in scheduling their work. This policy was created after many TODOs were created without a corresponding github issue associated with them in this repo. Never the less, this code is still production code, and TODOs should adhere to this philosophy. I'll mark TODOs in this repo to this issue now, but this should NOT be a catch all, work should be done to handle, triage, schedule and fix the work outlined by the TODOs in this repo (it is production code!).
(see work done in https://github.com/phetsims/tasks/issues/1129 also)

Also adding that additional TODOs should not be created that point to this issue.  And there are currently 325 TODOs that point to this issue.


Use [u8; 16] instead of u128 for representing Val::V128

When troubleshooting WAST test failures, it was difficult to determine what was different between the expected V128 pattern (e.g. [0, 1, 2...]) and the giant integer contained in Val::V128. There are multiple ways to make this more user-friendly, but this change does so by changing the contained type of Val::V128 to the easier to read [u8; 16].

I am not married to this proposal: we could instead add a pretty-printer to wrap Vals and print the Val::V128 variants as either hex or converted by to_le_bytes(). Even better would be to figure out what the lane types of the V128 are supposed to be and print as that. I'll close this and try one of those approaches if someone has a strong opinion (or really any opinion 😄) but this at least makes it easier to troubleshoot why tests are failing.

Oh seeing this I remember now that https://github.com/bytecodealliance/wasmtime/pull/689 shows that we're wavering back and forth on this. That was motivated by https://github.com/bytecodealliance/wasmtime/commit/3d69e04659a9dade78fa80a76e69e3f1b9d1af07#r36326017, so @joshtriplett would you mind helping to weigh in here?

A few different considerations:

Does the change here impact code generation? Do we get better assembly code by shifting values out of a u128 than we get by offsetting into a slice and extracting bytes?
For debugging, can we improve the debugging prints of the V128 to make it easier to see the individual components? (For instance, showing it in hex, providing _ between each 32-bit value, etc?)
How would this interact with the actual use of full u128 values in Rust and WebAssembly?

* Does the change here impact code generation? Do we get better assembly code by shifting values out of a u128 than we get by offsetting into a slice and extracting bytes?

This should not impact Cranelift codegen; this is an internal detail for the boxing of values used in Wasmtime (e.g. if a user passes in a V128 from the CLI somehow it would be stored internally as either [u8; 16] or u128 (depending on what we decide) for the brief time before it is passed in to the compiled code.

* For debugging, can we improve the debugging prints of the V128 to make it easier to see the individual components? (For instance, showing it in hex, providing _ between each 32-bit value, etc?) Looking at a [u8; 16] doesn't necessarily make it easy to "see" a u32 or u64 either.

I think this is actually the better long-term solution. Lazily, I didn't really want to implement this but looking into it a bit it seems like we could coerce the V128 to look like whatever the V128Pattern from wast looks like. Let me try that instead of this approach.

How would this interact with the actual use of full u128 values in Rust and WebAssembly?

I don't really see how it does. It seemed to me like a very internal detail to boxed values but I could be missing something.

If this doesn't have any performance impact, I have no objection. But if the primary concern is debugging, I think it's worth trying a simple change to our debugging prints first.

Closing, see https://github.com/bytecodealliance/wasmtime/issues/1681.


Color picker doesn't want to appear in .html files

VSCode Version: 1.15.1
OS Version: win7x64

Good feature. But it appears only in .css files. Not in .html files inside tag <style></style>
Can somebody fix it?

duplicate of #32611