Ladda is not initialized if the component is mounted with loading = true

Hello,
I've noticed that if I render <LaddaButton loading={true} /> it won't show the spinner. However if I render it with false and then change it to true it shows correctly. Is this a ladda issue?
Thank you.

I think this commit https://github.com/jsdir/react-ladda/commit/a48a20c08cf5a781335eb4a3b88f7f4851616cc5 had fixed this problem, could you check again with the latest version?


Superscript text doesn't begin with the right character

Steps to reproduce
Run the attached code on Mac
Expected results
The word "Hello" is regular, and the word "World" is superscript.
Actual results
The text "HelloW" is regular, and the word "orld" is superscript.
Code sample
Code sample
import 'package:flutter/material.dart';

void main() {
  runApp(const ReproApp());
}

class ReproApp extends StatelessWidget {
  const ReproApp({super.key});

  @override
  Widget build(BuildContext context) {
    return const MaterialApp(
      home: Scaffold(
        body: Center(
          child: Padding(
            padding: EdgeInsets.all(96),
            child: Text.rich(
              TextSpan(
                text: "Hello",
                children: [
                  TextSpan(
                    text: "World",
                    style: TextStyle(
                      fontFeatures: [FontFeature.superscripts()],
                    ),
                  )
                ],
              ),
            ),
          ),
        ),
      ),
    );
  }
}

Screenshots or Video

Screenshots / Video demonstration

Logs
No response
Flutter Doctor output
Doctor output
Framework • revision 761747bfc5 (3 weeks ago) • 2024-06-05 22:15:13 +0200
Engine • revision edd8546116
Tools • Dart 3.4.3 • DevTools 2.34.3

CC @justinmc

Thank you for the report!
Additional tests:

On Android app, it behaves as Web's (canvaskit renderer): superscript is not applied (similar to https://github.com/flutter/flutter/issues/150743).

On iOS app, it behaves as on macOS app (as described on the original comment)

flutter doctor -v (stable and master)
[✓] Flutter (Channel stable, 3.22.2, on macOS 14.1 23B74 darwin-x64, locale en-VN)
    • Flutter version 3.22.2 on channel stable at /Users/huynq/Documents/GitHub/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 761747bfc5 (31 hours ago), 2024-06-05 22:15:13 +0200
    • Engine revision edd8546116
    • Dart version 3.4.3
    • DevTools version 2.34.3

[✓] Android toolchain - develop for Android devices (Android SDK version 34.0.0)
    • Android SDK at /Users/huynq/Library/Android/sdk
    • Platform android-34, build-tools 34.0.0
    • ANDROID_HOME = /Users/huynq/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jbr/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 17.0.10+0-17.0.10b1087.21-11572160)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 15.3)
    • Xcode at /Applications/Xcode15.3.app/Contents/Developer
    • Build 15E204a
    • CocoaPods version 1.15.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2023.3)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • android-studio-dir = /Applications/Android Studio.app/
    • Java version OpenJDK Runtime Environment (build 17.0.10+0-17.0.10b1087.21-11572160)

[✓] VS Code (version 1.89.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.90.0

[✓] Connected device (3 available)
    • iPhone (mobile) • d9a94afe2b649fef56ba0bfeb052f0f2a7dae95e • ios            • iOS 15.8 19H370
    • macOS (desktop) • macos                                    • darwin-x64     • macOS 14.1 23B74 darwin-x64
    • Chrome (web)    • chrome                                   • web-javascript • Google Chrome 125.0.6422.142

[✓] Network resources
    • All expected network resources are available.

• No issues found!

[!] Flutter (Channel master, 3.23.0-13.0.pre.300, on macOS 14.1 23B74 darwin-x64, locale en-VN)
    • Flutter version 3.23.0-13.0.pre.300 on channel master at /Users/huynq/Documents/GitHub/flutter_master
    ! Warning: `flutter` on your path resolves to /Users/huynq/Documents/GitHub/flutter/bin/flutter, which is not inside your current Flutter SDK checkout at /Users/huynq/Documents/GitHub/flutter_master. Consider adding /Users/huynq/Documents/GitHub/flutter_master/bin to the front of your path.
    ! Warning: `dart` on your path resolves to /Users/huynq/Documents/GitHub/flutter/bin/dart, which is not inside your current Flutter SDK checkout at /Users/huynq/Documents/GitHub/flutter_master. Consider adding /Users/huynq/Documents/GitHub/flutter_master/bin to the front of your path.
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 1cb003b8fb (28 hours ago), 2024-06-22 16:41:39 -0700
    • Engine revision 33415c6ee7
    • Dart version 3.5.0 (build 3.5.0-288.0.dev)
    • DevTools version 2.36.0
    • If those were intentional, you can disregard the above warnings; however it is recommended to use "git" directly to perform update checks and upgrades.

[✓] Android toolchain - develop for Android devices (Android SDK version 34.0.0)
    • Android SDK at /Users/huynq/Library/Android/sdk
    • Platform android-34, build-tools 34.0.0
    • ANDROID_HOME = /Users/huynq/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jbr/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 17.0.10+0-17.0.10b1087.21-11572160)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 15.3)
    • Xcode at /Applications/Xcode15.3.app/Contents/Developer
    • Build 15E204a
    • CocoaPods version 1.15.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2023.3)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • android-studio-dir = /Applications/Android Studio.app/
    • Java version OpenJDK Runtime Environment (build 17.0.10+0-17.0.10b1087.21-11572160)

[✓] VS Code (version 1.90.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.90.0

[✓] Connected device (2 available)
    • macOS (desktop) • macos  • darwin-x64     • macOS 14.1 23B74 darwin-x64
    • Chrome (web)    • chrome • web-javascript • Google Chrome 126.0.6478.63

[✓] Network resources
    • All expected network resources are available.

! Doctor found issues in 1 category.


Homepage widgets leave unpleasant space above them

The widgets(on clicking e.g. Home in navigation bar) at home page appear a little lower in Academic Theme. That is they leave an empty space above them which is unpleasant to see. Secondly speed of showing up the widgets is slower. Is there any work around for both these issues? I have checked StackOverflow but to no avail.
Below the file Low_appear.png shows the problem:

Whereas the right appearance is like this:

If I understand correctly, this is by design. However, Academic is open source and the style is fully customisable - please refer to the Academic documentation.


assoc returns a narrower type than what is passed

Summary
assoc sometimes returns a more narrow type than what is passed to it. Since assoc never removes props, this feels wrong from a type perspective. I would expect assoc to only add or modify props, never remove.
In the example below, a complex type with 2 props is typed as Record<'flag', bool> after passing through assoc
Dependencies

<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>
Example

Link to codesandbox

import { assoc } from "ramda";

type OriginalType = {
  name: string;
  flag: boolean;
};

function takesAnOriginalType(original: OriginalType) {
  console.log(original);
}

const array: OriginalType[] = [{ name: "test", flag: true }];

const mapped = array.map(assoc("flag", false));

takesAnOriginalType(mapped);
                    ^^^^^^

Error
const mapped: Record<"flag", boolean>[]
Argument of type 'Record<"flag", boolean>[]' is not assignable to parameter of type 'OriginalType'.
  Type 'Record<"flag", boolean>[]' is missing the following properties from type 'OriginalType': name, flagts(2345)

I've actually been working on this but had yet to push the branch up. I made a draft MR for you: https://github.com/ramda/types/pull/37
I still have a bunch of testing to do for the different overloads, but it does solve your issue
Using your example: https://tsplay.dev/mqxg2N

Wow, impressive - fixed the issue before it was even opened!! 👏🏻 👏🏻 👏🏻
Thank you for the diligent and speedy work!

@ericyd The original MR that I referenced to fix your issue had Breaking changes and I was forced to leave hanging since we're still debating on if we want to merge it or not
Prompted by another issue, I just put up a new MR that is non-breaking but also fixes your issue: https://github.com/ramda/types/pull/100
Sorry for letting this issue hang for so long

Wow I just re-read my original bug report and the code snippet I provided is not even an accurate representation of the issue 🤣
Anyway, no worries on the delay. As things go, I was laid off from the job where I used ramda a bunch and now my new company uses lodash 🙄
Thanks for your dedication to this project 🙇🏻 Ramda is great and these types make it even better!


LibWeb+WebContent: make Skia backend a compile-time option

Similar in spirit to how the GPU graphics backend can be controlled by ENABLE_ACCELERATED_GRAPHICS, this pull request adds a CMake option to en-/disable the Skia graphics backend (ENABLE_SKIA, default ON).
This is more consistent and makes Ladybird easier to build, because Skia is quite complicated to build and link Ladybird against.
Further, I assume, disabling Skia makes Ladybird easier to port to less-common CPU architectures or big-endian platforms (Skia officially does not support big-endian byte order).
The --enable-skia-painting command line option is kept in place, but does not do anything other than to print a warning on stderr when used on a build with Skia disabled.

The non-skia backend will be removed in the future, so I don't think this is a reasonable path forward.

right, the long-term plan is to remove CPU painter (LibGfx) and GPU painter (LibAccelGfx) making Skia the default.


feat: add timeout on save_image

Description
Fixes FL-1725
How has this been tested?

Checklist

[x] changelog was updated with notable changes
[ ] documentation was updated

/e2e --tests sdk,substrafl,mnist,camelyon

End to end tests: :hourglass_flowing_sand: STARTING

/e2e --tests sdk,substrafl,mnist,camelyon

End to end tests: :hourglass_flowing_sand: STARTING

/e2e --tests doc --refs substra-documentation=chore/bump-dependencies

End to end tests: :hourglass_flowing_sand: STARTING


中文汉字展示效果不佳（The effect of displaying Chinese characters is not good） 如图所示

As shown in the figure

What? You just show a screenshot of your desktop image - how is it related to Maccy? I really don't get it.

I think OP is expecting to see the actual chinese characters in the search result instead of the character codes.

I'm looking at the screenshot and it shows a desktop. @pekcheey Can you elaborate?

I think the OP wants to say Maccy should display the filename as-is (IBV产品培训-0122.pptx), not its encoded form (IBV%E4%BA%A7%E5%93%81%E5%9F%B9%E8%AE%AD-0122.pptx).

@p0deje Thanks for the quick fix!


Modified the code to specify a list of http response codes to be skipped for riemann logging

Modified the code specify a set of http response codes instead of skipping all client errors.

Have modified based on review comment .
Corresponding change in broker now - https://github.com/cloudfoundry-incubator/service-fabrik-broker/pull/132/files .
Please review and merge.


Add a flash abstraction layer

This commit adds a flash abstraction layer enabling multiple backing stores to be used.
This change is a precursor to enabling file-based pnor devices and enabled multiple backing stores to be used without recompiling a binary.
When VIRTUAL_PNOR is enabled, the backing store defaults to the vpnor device unless valid mtd device is specified. This is to maintain compatibility with the previous implementation.
Signed-off-by: Evan Lojewski<EMAIL_ADDRESS>

Please note that there has been minimal testing with VPNOR enabled. When enabled, the code is able to compile and can still use /dev/mtd* if specified.
I do not have a vpnor system setup, and so cannot test that vpnor still works.
Please let me know what changes / improvements you'd like.
Once this is merged, I will update the file-based pnor backing support to work with these changes.
Finally, once file-based pnor is enabled, work can be done to enable on-the-fly switching from one backing store to another via mboxctl.

Sounds good. There are some things that I don'r like with the changes as is, so I may still make some modifications, but please do suggest any changes / improvements.

I'm not sure about the flash_hal data structure having things like the lpc reset + protocol version code in it, since those aren't directly related to the flash.
It may make sense to make a mtd folder for the mtd specific code like the vpnor code (then adding a file backing folder in the next pull request)
I currently have the flash_hal structure inside of mctx instead of as a pointer as it makes things slightly more efficient, it may be better to have a separate structure for each backing store and just update one pointer.
It likely makes sense to add some additional error checking to make sure all entries in the flash hal are populated before using them.

Let me know what you think about the above / other options.

You've pretty much covered my concerns with your bullet points.

I'm not sure about the flash_hal data structure having things like the lpc reset + protocol version code in it, since those aren't directly related to the flash.

Agreed, these should be separate.

It may make sense to make a mtd folder for the mtd specific code like the vpnor code (then adding a file backing folder in the next pull request)

Yeah, I haven't thought about this enough yet. We'll see how it plays out.

I currently have the flash_hal structure inside of mctx instead of as a pointer as it makes things slightly more efficient, it may be better to have a separate structure for each backing store and just update one pointer.

I feel that just updating the one pointer is a lot neater, and that the performance penalty taken isn't going to be significant in the overall scheme of things. Lets do that please.
Also I'm hesitant to have the struct named 'flash_hal', as the 'h' in 'hal' is going to become incorrect when we have the file-based backend. How about "data_source" or "backend"?

It likely makes sense to add some additional error checking to make sure all entries in the flash hal are populated before using them.

Lets just assert() it, that way it gets out of the road in releases. The test cases should cover the setup.

So I've had a bit more of a think about the issue with protocol_negotiate_version(). We had different implementations for the mtd and vpnor backends so the vpnor backend could hijack .create_window of struct protocol_ops. Really this was done so the parameters of the request could be validated and an error could be returned if necessary in the case of the vpnor backend.
The history of this is that up until recently there was only one transport (the mailbox), two protocol implementations (v1 and v2) and one backend (mtd). Then the second backend, the virtual pnor, was introduced, which required the validation. As there were now two backends and two protocol implementations the place of least effort to override the create_window() behaviour was in the transport  (mailbox) interface as it was the one remaining choke-point.
Recently the DBus transport was introduced which removed the choke-point that was previously present, and we need consistent behaviour between the mailbox and DBus interfaces, so the dumb choice was to simply push the hijacking down a layer, to be done on protocol level.
Reflecting now on all of this, we never had the right solution. With your work in the pull request here I think it's become a bit clearer to me that we need a .validate function member of what is currently struct flash_hal. By doing that, we shift the code that's currently in the vpnor create_window() implementation to where it really belongs, which is in the backend. Implementations of create_window() would look something like:
if (ctx->flash.validate) {
    rc = ctx->flash->validate(offset, size);
    if (rc < 0)
        return rc;
}
/* Setup the window according to parameters */
...
}

Currently for the mtd backend we could just set validate to NULL and implement it for vpnor, moving the vpnor's current validation checks out from create_window(), which should allow us to unify create_window() with the mtd backend's implementation. Further, v3 of the protocol describes a flash locking capability, which would perfectly fit the validate() concept - i.e. we check if the requested window intersects any locked flash blocks and return an error if so. The create_window() implementation would remain a general fit even under this requirement, as the details are buried in the validate() call on the backend.
Are you happy to rework the change along these lines?

Adding a validate function seems perfectly reasonable and like a good option. I've just been reworking to rename flash_hal to backend, and I'll push the changes once I'm done. After that I can update it to use a validate function to remove protocol negotiate.

I've update the code with a number of changes including the validate change.
Please take a look at it and let me know if any other changes are needed.

Great, trying to find time to look at this.

Okay, I think we're going to have to follow the OpenBMC process a bit more closely with this series. It's a bit more messing around. I've been trying to avoid it to avoid putting you off @meklort, however I pulled down your changes and ran into some build breakages locally. They also need a rebase against the tip of master to resolve some (trivial) merge conflicts.
The proper OpenBMC process is to push patches to our Gerrit instance:
https://gerrit.openbmc-project.xyz/
The process you'll need to follow is documented here:
https://github.com/openbmc/docs/blob/master/CONTRIBUTING.md#submitting-changes-via-gerrit-server
Note that you've already signed the CLA, so ignore that part.

OK, i prefer to use gerrit anyway, so not a problem.

@meklort sorry it's taking a long time to get these patches in, but your push to gerrit is still failing CI. Do you have time to clean that up? Alternatively I can pick up where you've left off.

Alright, I'll have a poke around when I've got a moment.

Pull request has been reviewed on gerrit and merged in with commits
f1e547c74563d59f60d918c6fa673bb8cee6e669 and a042978b03c91ca3a716e99f313ef5cda42820ba
Making as closed.

Thanks for persisting @meklort !


Add fullscreen console

Have an activity which shows scrollable fullscreen console

This PR was released with 0.22.1


WIP: let's see how 21.1.0 is going

Hi @Gcenx ,
Apparently, 21.1.0 builds without changes compared to 21.0.0.
Would there be anything to be changed / Are there any relevant new features to be activated?

The one new feature we should are about would already be covered by gnutls deps aka gmp is bow used for some additional encryption that isn’t covered by gnutls.

@dasmy did you want to do anything else to this?

@dasmy did you want to do anything else to this?

@Gcenx, nothing to add - just wanted to disable building 21.0.0 as we only are only building one minor per major version.
Apart from that I went down the rabbit hole of testing this build with Quantum Odyssey (https://www.quarksinteractive.com) but failed due to
0160:err:winediag:wined3d_spirv_shader_backend_init_vk Wine was built without libvkd3d-shader support.

This is clearly not a blocker as non-3D software seems to work pretty well, but a bit disappointing :-)


Duplex documentation is terribly wrong

On this page, I read:

With regular HTTP calls the request always completes sending before the response may begin receiving.

Wrong. Where in any HTTP-related specification will you find a single word on timing? Or the definition of a "regular" request for that matter. The idea that HTTP is a synchronous one-to-one protocol is a complete fallacy.
RFC 7230 §5.6:

[HTTP] relies on the order of response arrival to correspond exactly to the order in which requests are made on the same connection.

Your page continues:

With duplex the request and response may be interleaved! That is, request body bytes may be sent after response headers or body bytes have been received.

Erm, there's one read/input stream and one write/output stream. They're like, separate. So the word "interleaved" is quite misleading.

only web servers that are specially designed for this nonstandard interaction will use [duplex-thing]

"Specially?" "Nonstandard interaction"? Gosh, to be real honest, I have a feeling the author of this page smoked crack or something. The client can pretty much count the number of requests made on a connection, the n:th response is the response to the n:th request - or, sync up and wait for both request/response to complete before initiating the next exchange over the same connection. It's that simple. And like I said, the request and response are transmitted on completely different streams.
The server can start writing a response back before receiving the full request and there's absolutely nothing "nonstandard" or weird about it. In fact, quite the expected case when it comes to many error codes, like 413 (Payload Too Large), or do you think the server should consume a 999 terabyte large request first before responding in a decade from now telling the client "yeah I was waiting for you to complete before letting you know I was consuming all bytes but didn't really care about them"?
I know a lot of servers out there are pretty shitty, hence why I rolled my own actually (called NoMagicHTTP). The server is fully asynchronous and what some kids would call "reactive". It exposes request bytes to application code immediately on arrival and will start writing response bytes back as soon as possible. There's like zero "waiting times" or hiccups with this server. Point is that it's well tested and I've never had any issues at all.
I don't even know what you are talking about. And how exactly did you plan on telling the server that the client is using/accepting "non-regular duplex-thing supported exchanges"? lol the whole idea is quite preposterous to be honest.
And so with that said, I can bet the implementation probably isn't working much better lol. I think that you should probably completely remove the idea of "duplex" from all documentation and likewise from the codebase, and write a correct implementation instead.
EDIT: Here, I found a good SO answer that is probably way more pedagogic than what I am =) And, he uses your favorite "duplex" word lol.

Separate from the technical merits, the tone of your message isn't really helpful here.

I have a feeling the author of this page smoked crack or something.
I can bet the implementation probably isn't working much better lol

Please tone it down and treat the author of this code with some respect.

For the technical discussions, I think the code documentation you reference, generally describes the OkHttp implementation logic.
Having implemented a similar duplex implementation in another networking framework, similar to the gRPC usecase, my experience was that in almost all situations clients, server libraries and proxies (reverse proxies etc) fail to handle the duplex case cleanly. It needed specific client, server and knowledge of the path between.
I don't personally believe this is a priority right now because it's an uncommon use case.  OkHttp doesn't seek to change the HTTP landscape by implementing an all powerful client for any and all use cases.  My own view is that OkHttp does best when it implements real world standards, simply and compatibly. The OkHttpClient API and semantics mean that we do send the request before reading the body in most cases.
Also given https://github.com/square/okhttp/pull/6295, we already read the error response if they come because of the server terminating the request.
Is there a specific failure case you can show us to help us understand what is not working for you, and if there is a suitable fix (not likely an entire rewrite).

 It means my first instinct is to close & block.
Point taken that this isn't a limitation of the protocol; merely a limitation/feature of this particular client.
The on-the-wire behavior of isDuplex() is the same as without. By using this feature the caller is now responsible for processing two streams concurrently and not in serial.
It’s a common implementation strategy, required because HTTP insists servers send the status code before sending any response body bytes. Confirming that a request was processed successfully usually requires reading it to completion!
We're in good company with the terminology. gRPC docs and implementations use the word duplex to indicate that using the streams in serial is insufficient.
https://grpc.io/docs/what-is-grpc/faq/#why-is-grpc-betterworse-than-rest
Next Steps
What we should describe is that in its regular operation, OkHttp doesn't start reading the response until it finishes writing the request.
We can improve the docs to emphasize the caller’s concurrency is what changes, not the protocol.

Ah, I see what you are saying.
Firstly, thank you so much for your response. "Being on crack" is a humorous metaphor for what otherwise best can be described as slur:

Because the encoding of interleaved data is not well-defined for HTTP/1, duplex request bodies may only be used with HTTP/2.

Like, what! I mean I was having my morning coffee and almost choke lol. It's just that I was expecting so much more from a public HTTP library, and I am overall pretty much against spreading misinformation. A whole page not just with plain incorrect things but was also pretty slurry (I write slurry too!!, feel free to criticize and I will thank you for the time and energy spent). Anyways, ... I am really not the best at expressing myself, I am so sorry!
Really appreciate the response. I understand better now what you are trying to do. Although again, it really should not matter at all. Well, "should". You wrote:

in almost all situations clients, server libraries and proxies (reverse proxies etc) fail to handle the duplex case cleanly

Sounds like this had nothing to do with HTTP? I am very eager to hear if you have a real HTTP-related example of when and how concurrent writing on two different streams broke the HTTP chain.
Me, I was trying to understand how to do a HTTP/1.1 chunked request and stumbled onto the "Duplex" docs hahaha. I have understood I can probably hack the RequestBody.contentLength() to return -1, but there appears to be no public API for streaming the request body. This is off-topic of course, I will keep looking a little bit. Just for your info, the background.

Me, I was trying to understand how to do a HTTP/1.1 chunked request and stumbled onto the "Duplex" docs hahaha. I have understood I can probably hack the RequestBody.contentLength() to return -1, but there appears to be no public API for streaming the request body. This is off-topic of course, I will keep looking a little bit. Just for your info, the background.

Look into BridgeInterceptor
      val contentLength = body.contentLength()
      if (contentLength != -1L) {
        requestBuilder.header("Content-Length", contentLength.toString())
        requestBuilder.removeHeader("Transfer-Encoding")
      } else {
        requestBuilder.header("Transfer-Encoding", "chunked")
        requestBuilder.removeHeader("Content-Length")
      }
    }

And Http1ExchangeCodec
  private val Request.isChunked: Boolean
      get() = "chunked".equals(header("Transfer-Encoding"), ignoreCase = true)

Just saw this old doc on Reddit that also talks about duplex as a term of art here.
https://datatracker.ietf.org/doc/html/draft-zhu-http-fullduplex

I understand the teams position that bi-directional, chunked transfer encoding for http/1.1 is ill defined. I myself have an API that is written this way, and an iOS implementation that works perfectly fine. I've also tested with other libraries in other languages and they all perform as expected.
But for whatever reason, I can find no method of doing this on Android no matter which library. ok http is my preferred library.
Is there anything that I can do to make this work on http/1.1? I would upgrade my server to http2 to see if that allows it to work with the current "isDuplex" method of overriding the request body, but then that would mean that I could not run local instances of this API for debugging purposes (at least I found no easy way to get https working locally via my stack, which is golang for the backend and vue frontend which I run locally using 'npm run serve' which produces an http (not https) server. It would be trivial to get the production server running http2 though).
I am desperate! @yschimke seems to possibly have an idea but I am unsure where to start or if finessing ok http to do this is even possible.

I was able to get it working with netty. Would still prefer to have it working via okhttp!


Input confusion when ActionPlanner works with substep

Describe the bug
Input will show up in state. And then it will not be captured correctly into substep for action planner.
For example, for function name below, workspaceName could not be passed with correct input. It will get input from upstream. For example, user intent in chatapp.
We need to do custom coding to make it work.
public string GetDatasetName(string workspaceName)
User intent: I want to retrieve the names of datasets within a Power BI workspace named High_Memory.
{"state":[{"Key":"INPUT","Value":"High_Memory"}],"steps":[{"state":[{"Key":"INPUT","Value":""}],"steps":[],"parameters":[{"Key":"INPUT","Value":""}],"outputs":[],"next_step_index":0,"name":"GetDatasetName","skill_name":"PowerBI","description":"Return dataset name of my power bi workspace"}],"parameters":[{"Key":"INPUT","Value":""}],"outputs":[],"next_step_index":0,"name":"","skill_name":"Microsoft.SemanticKernel.Planning.Plan","description":"User intent: I want to retrieve the names of datasets within a Power BI workspace named High_Memory."}
To Reproduce
Steps to reproduce the behavior:

Go to '...'
Click on '....'
Scroll down to '....'
See error

Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):

OS: [e.g. Windows]
IDE: [e.g. Visual Studio, VS Code]
NuGet Package Version [e.g. 0.1.0]

Additional context
Add any other context about the problem here.

This problem might comes from a general design issue. Need a contract between skills.

This is related to #998 right @poweihuang0817 ?

yes, related

This seems like an ActionPlanner bug. It is placing SoP_High_Memory into the Plan.State which gets overridden by the input when the plan is executed (Yes, proceed). LIke SequentialPlanner, this should be a Parameter on the step where this should be input.
https://github.com/microsoft/semantic-kernel/blob/f1448c9a0759947256af7f4c6b940c9eab06ea91/dotnet/src/Extensions/Planning.ActionPlanner/ActionPlanner.cs#L127


Computed property don't receive component's instance as first argument in SSR

Version
2.5.17
Reproduction link
https://github.com/sqal/vue-ssr-bug-reproduction
Steps to reproduce

Clone, install dependencies
run npm run ssr:serve

What is expected?
Should render the app.
What is actually happening?
When you start the server you should see that application throws following error: Cannot read property '$store' of undefined. This happens because in SSR computed property don't receive component's instance as the first argument, therefore I cannot access $store property. I am not sure if this is a bug or not, I think it is because i could not find anything about in vue or vue-ssr docs. I would appreciate if someone could clarify this issue. Thank you :)

I was sure I opened an issue or PR about this but apparently I didn't 😆

Test


Overlay shadow breaks in square browser

Rebass looks awesome!
I noticed a small bug when trying out the components in Storybook. The overlay background does not cover the entire screen if your bowser window is more or less square. It seems the cause is that the border radius extends to the box-shadow used to create the dimmed overlay background, leaving awkward uncovered areas in the corners.
Removing the border radius or increasing the shadow spread fixes the problem.

Yeah I'd consider that overlay effect a little experimental. There were issues rendering larger shadows in Safari so that whole component probably needs to be rethought

Closing this out since there have been some changes in v2, but feel free to open a new issue if this is still an issue


Difficulty in using angular-translate for translating select dropdown options

Hi,
Though I have posted this issue on the actual project but since it's related to angular-translate, I think asking community over here makes sense.
Actual issue link:
https://github.com/jseppi/angular-dropdowns/issues/56
Can anone please give me some idea of how to get it done ?
Thanks

Some basic suggestions as I don'T know the complete setup of your app and I'm in a hurry:

try shifting the whole  $scope.ddSelectOptions to the "then..." block of the async response
check if $translate.instant might help depending on your translation language setup / loader setup

$translate.instant worked like a charm. Just want to confirm, there is no issue in using $translate.instant in place of regular $translate which return a promise. Is there any situation where I should avoid using $translate.instant() ?
Thanks

$translate.instant(key) returns the current information (regardless it's correct), but $translate(key) returns a promise proxy which waits for the correct key for the current situation (see for fallbacks, current loading translations, ...)

I'll close this in forward, the issue was solved I think. Ok?


random_idxs = random_idxs + 257 ?

Hello, thank you for your work!
I have a small question:
In the loss. py file at line 9, why do you do
random_idxs = random_idxs + 257 please ?

Hi Gaslen, this is a good question. The reason is that we randomly select pixels except those on boundaries.
If you check line 8, you can see the range we randomly select pixels is (h-2) x (w-2)(let's say inner region). Therefore, we need to "+257" to transfer coordinates in the inner region to the whole 256 x 256 image.
The reason we don't consider pixels on boundaries is to simplify the following calculation (line 48 -55). Otherwise, these lines can be super complicated

Ok, I understand! Thank you for the quick answer :)


Remove Vagrant in favor of Test Kitchen

There are too many problems with the vagrant-berkshelf plugin and Chef upstream prefers Test Kitchen. Let's be like Chef.

:+1:


Add support for the STAT table.

https://learn.microsoft.com/en-us/typography/opentype/spec/stat
This PR adds support for parsing the STAT table and its related data types.  It's a pretty simple table but as in #87 the issues of testing and API design deserve some consideration.
Additionally, should this be placed behind a feature?

Thanks! Looks pretty good to me.

It looks like we can update the table in the readme.
https://github.com/RazrFalcon/ttf-parser?tab=readme-ov-file#alternatives

Ok, 1.51 compatibility is broken, but we're good otherwise.

Ok – I've rolled up a few other minor changes. I've also set up a few functions to abstract over getting the value and flags. If that seems in scope for this PR I can push those as well.

If that seems in scope for this PR I can push those as well.

Sure, let's take a look.

I'm not sure how far down the rabbit hole it's worth going with providing a higher level API.  What I've exposed so far should be useful for both dynamic (e.g. name_id) and non-dynamic (e.g. contains) fonts.
For instance:
fn is_stat_italic() -> bool {
  if let Some(stat) = face.tables().stat {
    if let Some(subtable) = stat.subtable_for_axis(Tag::from_bytes(b"ital"), None) {
      if subtable.contains(Fixed(1.0)) {
        return true;
      }
    }
  }

  return false
}

fn is_bold() -> bool {
  if let Some(stat) = face.tables().stat {
    if let Some(subtable) = stat.subtable_for_axis(Tag::from_bytes(b"wght"), None) {
      if let Some(value) = subtable.value() {
        let named_weight = Weight::from(value.0 as u16);
        if named_weight == Weight::Bold {
          return true;
        }
      }
    }
  }

  return false
}

If you think it's good enough I'm fine with merging it.

Works for me.


Document named arguments as adverbs

Problem or new feature
Named arguments can also be used as adverbs outside the parentheses:
sub foo( $bar, :$n) { return "$bar and $n" };
say foo( "Hey"):n; # OUTPUT: «Hey and True␤»

Suggestions
Document them including examples.

Closed in 4eb8081


Convert uses of @unchecked Sendable to checked Sendable.

@unchecked Sendable disables (most) concurrency checking on types to which it is applied. We have a couple of types, FileHandle and Locked, that use it because they are internally concurrency-safe but use lower-level types that cannot prove their safety to the concurrency checker at compile time.
This PR changes those types to use our dedicated UncheckedSendable wrapper to wrap their corresponding unsendable stored properties. This means that the types themselves can be Sendable rather than @unchecked Sendable, so we can still get concurrency checking for their code and storage that doesn't directly touch the unchecked stored properties.
Checklist:

[ ] Code and documentation should follow the style of the Style Guide.
[ ] If public symbols are renamed or modified, DocC references should be updated.

@swift-ci please test


/etc/sssd/sssd.conf file permission issue

Tasks for RHEL-07-040180, RHEL-07-040190 & RHEL-07-040200 set the /etc/sssd/sssd.conf file permissions to 0644. This is not a supported configuration for sssd and prevents the service from starting with the following error message:
sssd[sssd]: Cannot read config file /etc/sssd/sssd.conf. Please check that the file is accessible only by the owner and owned by root.root
Setting the permissions back to 0600 allows the service to start.

Hi @dpbowen
Thank you for taking the time to raise this issue. I have raised the PR #366 and will hopefully be merged over the next couple of days.
uk-bolly

Addressed in PR #366


Fine-tuning with CLIP and accuracy decreases?

Has anyone tried to use CLIP fine-tuning as part of a larger model? I am getting some strange issues with accuracy jumping up to around 20% and then... dropping.  I cannot tell if this is just an issue with my model setup, or something I'm doing with the CLIP fine-tuning. The model uses the CLIP image embeddings for both images, concatenates them, then passes them through a few FC layers to get an output the same size as the CLIP text embedding. I use a CrossEntropy loss on the cosine measurements between the output and existing caption embeddings I have (and follow the advice from other posts about changing the weight types for CLIP finetuning).
        convert_models_to_fp32(clip_model)
        clip_opt.step()
        clip.model.convert_weights(clip_model)

I don't know how much detail is needed to showcase the issue I'm having, but I'm curious if anyone else has run into issues of accuracy decreasing when trying to fine-tune the CLIP embeddings

HI! I am also trying to do CLIP fine-tuning. I am wondering how you get the accuracy metrics since when I trained it, I could only see the loss, but it seems many people could also plot accuracy...

hello, i also want to train the CLIP. How you train it ?

HI! I am also trying to do CLIP fine-tuning. I am wondering how you get the accuracy metrics since when I trained it, I could only see the loss, but it seems many people could also plot accuracy...

@dongyun-kim-arch by evaluating it's zero-shot classification accuracy.

Has anyone tried to use CLIP fine-tuning as part of a larger model? I am getting some strange issues with accuracy jumping up to around 20% and then... dropping. I cannot tell if this is just an issue with my model setup, or something I'm doing with the CLIP fine-tuning. The model uses the CLIP image embeddings for both images, concatenates them, then passes them through a few FC layers to get an output the same size as the CLIP text embedding. I use a CrossEntropy loss on the cosine measurements between the output and existing caption embeddings I have (and follow the advice from other posts about changing the weight types for CLIP finetuning).
        convert_models_to_fp32(clip_model)
        clip_opt.step()
        clip.model.convert_weights(clip_model)

I don't know how much detail is needed to showcase the issue I'm having, but I'm curious if anyone else has run into issues of accuracy decreasing when trying to fine-tune the CLIP embeddings

@oh-livia I am also facing similar issue, the accuracy keeps on dropping even after trying various learning rates and gradient accumulation steps. Did you find any solution for this?


'use supress' really suppresses everything

Setting the "log politics" to use supress suppresses the hsdev startup message with the version number and port number. That completely disables SublimeHaskell's ability to operate. Suggest printing to stdout instead of using simple-log.
"log politics" always gets a smile from people who see it, because they expect "policies", not "politics".
Also, suggest "suppress" (two "p"-s), since that's the correct spelling. You'll have to keep the current "supress" for backward compatibility.

Thanks, I'll release new version of simple-log without "politics" :)
And also will update hsdev

Suggest printing to stdout
You're right

@mvoidex: I'd leave "politics" well enough alone. It's actually an interesting joke that works on multiple levels, whether you're a native English speaker or not. Keep the funny!

@bscottm, I mean, I'm already preparing new version, and it doesn't have "politics" anymore :)

@mvoidex: I didn't mean for you to remove "politics". I thought it was very funny and so do a lot of my colleagues. Keep the politics! :-)

Just add a flag "--kneeslappers" where all occurrences of policies are rewritten as politics......   😈

I meant that it had been removed before you've created this issue
So its gone now :(
simple-log-0.8.2: only levels left: one of trace, debug, info, warning, error, fatal
hsdev-<IP_ADDRESS>: commands start and listen now accepts --log-level instead of --log-config and --config with with log level, it also sends Server started at port 4567 to stdout


Fix covariance detection

Oh, haha, I only noticed now that this commit was also part of #45. Please take a look there for some review.


Inform user when assigned resource change state

What feature do you want to see added?
As user who reserve a resource I want be inform when the status changes:

other person unreserve my resource
resource is reassign to other user
resource shall be locked (via job). This is helpful, when user locks resource for very long time and other jobs are blocked.

This might works only for users with valid email.
It shall be also implemented a extension point here, to allow other plugins contribute here (Teams notification, Slack ...)
Upstream changes
No response

We shall provide 2 properties in LRM.
Boolean callBackOnResourceAcquired(String resourceName)
Groovy expression returned true when the resource might be acquired. Ex

send mail to jenkins administrator
check if the user is ,permitted, to reserve resource by name convention.
or what ever.
It shall be start on reservation, lock or queue event

callBackOnResourceReleased(String resourceName)
Groovy expression called approximately after resource is released


Very noticeable stutter / lag when adding children to scene tree.

Godot version
4.0
System information
Windows 10, Forward+, i5-10400
Issue description
adding children to the scene tree results in a noticeable stutter in increase in frametime.

(all those spikes are when adding children)
Steps to reproduce
just add a child of a loaded instance using add_child()
Minimal reproduction project
N/A

@caliber06 Please upload a minimal reproduction project to make this easier to troubleshoot.

Have the same problem. Windows 10, i3-7130u, igpu. Stutter is really noticable. In 3.x there was no such problem. Problem may be in rendering side, because exist only while using compatibility renderer.

What is the child?
Is it a scene that has not been displayed on screen before this moment? (shader compilation)
Is it the same exact object being re-instanced on all of those spikes?
Does the object have any scripts attached?
Does the lag occur if you unattach and reattach the object from the scene tree? You should test on the same and subsequent frames. Use call_deferred for the latter.

just add a child of a loaded instance using add_child()

So it is not occuring when the object is instanced with .new() or load(). You already have an instance ready to go, eg created in _ready() and only when you add_child() it stutters? Or are you instancing the object and adding it to the tree all in one function? If so, test them independently.

Very noticeable stutter / lag when adding children to scene tree

What is stuttering? Is it just the blue ticks on the chart? These are insignificant, all about 1/60th of a second. Or does the whole engine seize? Does the mouse cursor move during the lag?

the objects are being instanced and added at the same time. the packedscene that is being instanced has a script attached, which is a child class of a parent. I have tested instancing the object in _ready() and instancing it later on, same issue. The large AND small spikes on the graph are when adding children. The entire game freezes when adding objects to the scene tree like this. I won't be able to add a minimum-reproduction project until tomorrow.

Does the instanced object have a shader material on it? Does placing a permanent instance of the object in the scene fix the problem when the new ones are instantiated?

I notices the same problem also. Godot 3.5.2(in GDScript and C#) is more stable and faster on adding and queuefree() the children nodes.

If you can compile from source, try using a C++ profiler on a debug build to see what's taking the most time.

If you can compile from source or use a precompiled debug build, try using a C++ profiler on a debug build to see what's taking the most time.
Edit: Please also test #75627 🙂

I should learn all this checkout , patch, branch etc2 from github first.


geozero-shp release

Released on crates.io. Solves #230

we ought to figure out how to stop this dependency hell...  (just venting)

Just working on #187 to improve on that.


Health globe does not work for warlock

Thank you for making this addon. Amazing great job!
There is one issue. Health globe does not work for warlock. It is grey and does not change while been damaged. Mana globe is blue but does not change neither. For other classes, I tested with druid, monk and paladin, they works fine.
I am using 1.1.26-release and Traditional Chinese zh-TW client.

I'm not able to reproduce this, at least not here. It's working fine on warlocks I've tested on both the blizzard and private realms. So I'm thinking this might be differences with the Chinese WoW client, since I know quite a few things are different there. Like skeletons have skin, piles of bones in the world aren't there and so on. So it might be some different things in the addon API too.
Can you do me a favor and type the following in-game if possible, and then post a screenshot of the result? It's supposed to print a list of the class name in English, and in capital letters. This is how we identify classes in addons. If something is different there, that's what I need to change. :)
/run for c in pairs(RAID_CLASS_COLORS) do print(c) end

I'll keep searching for any info on my own regardless of the result, though. We'll figure it out! :)


Added custom random functions

Related to: #45 #37

Without looking at the implementation of a Faker function that uses randomness, it is not clear which random function will be used in the end.

How about putting each of them in the docs? It's rare case from my opinion, so if someone doing this, I assume that he/she knows what they are doing.

I feel like all functions using some kind of randomness should all pass a single point - they should all end up to a single random function that is configurable.

Not sure how I feel about this one, on one the hand it's simple, on the other I'm not sure it'll keep all flexibility. Also, I don't think I have an idea how to pass all of them through a single function, probably I can try with first 3, but have no idea what to do with random bytes.

all 4 functions should be implemented

I haven't tested, but I believe you can set only one of them and the rest will be taken from package env.

allow the user to assign a single module that implements a behaviour that requires the 4 random functions to exist

This sounds like a good alternative, we also can provide default implementations, so only needed will be overridden.
Definetely random/1 not needed and can be implemented in random_between/1,2.

Why not just use Enum.random/1 and Enum.take_random/2? Wouldn't that be much simpler?

Hey, while upgrading to elixir 1.5 / erl 20.1, this is the last library that we use that emits warnings. Can we have some movement on this PR?
I'd be glad to pitch in if you can use me.

@hauleth it will be, but it relies on new OTP/Elixir versions, seeds and less customizable.

@igas Enum.random and  Enum.take_random have been part of Elixir's standard lib since 1.1, which came out in September 2015. Also, with the move from :random to :rand, you're going to break everyone not running on erlang >= 18, which came out around the same time.

@scohen fair point about versions, we already support 1.3+ due to dates etc, so we could use it, I guess.
@tobyhinloopen can you please take a look at last commit and give feedback?


Day256

Resolves #528.

Pull Request Test Coverage Report for Build 1002

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build 1000:
0.0%

Covered Lines:
5

Relevant Lines:
5

💛  - Coveralls


prepare sphinx documentation

fixes #20

should revise the conf.py file as other projects in the bluesky framework

sphinx build now reporting:
loading intersphinx inventory from http://docs.python.org/objects.inv...
intersphinx inventory has moved: http://docs.python.org/objects.inv -> https://docs.python.org/3/objects.inv


Cherrypick 23226 for v7.9

Summary
Cherrypick of https://github.com/mattermost/mattermost/pull/23226 for 7.9
Server PR - https://github.com/mattermost/mattermost/pull/23869
Ticket Link
https://mattermost.atlassian.net/browse/MM-52541
Release Note
NONE

/update-branch


Audio emitter multiple references to same asset bugfix

This fixes the bug where changing the parent of an entity with an audio emitter component referencing the same sound asset multiple times would cause a crash.
PR Details
Previously when the parent of such an entity was changed, there would be a crash because detach would be called on the same SoundBase object for each corresponding key in Sounds. Now, when an entry is removed from Sounds in AudioEmitterComponent, the corresponding SoundBase is only detached if there are no other keys referencing it in Sounds.
Description
This is accomplished by maintaining a dictionary mapping each SoundBase to its set of keys in Sounds, and only detaching a SoundBase when its set of Sound keys is empty. This implementation still keeps just one AudioEmitterSoundController per SoundBase.
Related Issue
https://github.com/stride3d/stride/issues/2024
Motivation and Context
Users may occasionally want the same sound asset to have multiple references from the same audio emitter (especially during early game development), so Stride should allow it instead of crashing unexpectedly when a parent of the object is set during runtime.
Types of changes

[ ] Docs change / refactoring / dependency upgrade
[ x ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist

[ ] My change requires a change to the documentation.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.
[ x ] I have built and run the editor to try this change out.

Looks good, thanks again @ComputerSmoke ! Just a small question, it looks like you've used a hashset purposefully here, can you quickly go over why that is compared to a Dictionary<SoundBase, int> which would be incremented on add and decremented on remove regardless of the key, and would call detach when zero ?
I can see the behavior of both differing when the same key and sound is used multiple times.
One minor nitpick would be to remove the key after detaching;
if (SoundKeys[sound].Count == 0)
{
   DetachSound(sound);
   SoundKeys.Remove(sound);
}

@Eideren I thought it was possible for the same key / sound to have two Add events in a row, but on investigating this I see that it is not (setting an existing key calls Remove before Add, and you can't call Add on a key that is already in the set). Counting instead of keeping track of each key should therefore have the same effect as the hash set, so I've changed the implementation to use the counting method you described.
I've also added that key removal for 0 values.

Wondering if that needs thread-safety guarantees (for instance using a lock). Can this code be called from multiple threads or are all sound-related logic always executed from the same (main?) thread?

The user could modify Sounds from any thread, but since it's a TrackingDictionary (which isn't thread safe since it's backed by a Dictionary), so anything modifying it in the current code must already be responsible for avoiding concurrent changes to Sounds.
The other place where this code is called is AttachToProcessor and DetachFromProcessor, but both call the Attach and Detach methods which can modify SoundToController, another Dictionary.
Assuming Attach/Detach for components doesn't collide, the case where something might go wrong is if user code modifies Sounds or calls Attach/Detach while AttachToProcessor is being called. I don't know if such a situation is possible, but if it is then it should be equally unsafe with and without these changes.
Not that we shouldn't add thread safety to anything, but there might already be some more generally implemented for this sort of thing?

Yep it would be nice, but adding thread safety in would be out of scope for this PR I would think, thanks again @ComputerSmoke !


🐞[Bug]: add hover effect to appoint a doctor button

Is there an existing issue for this?

[X] I have searched the existing issues

Describe the bug
the image is having hover effects, but the buttons does not have any hover effects
Expected behavior
Change color of button on hovering
Add ScreenShots
No response
What browsers are you seeing the problem on?
No response
Record

[X] I have read the Contributing Guidelines
[X] I'm a GSSOC'24 contributor
[X] I have starred the repository

@varshith257

@varshith257 can you review it


RoyalRender: Minor enhancements

Enhancement

ability to set context with environment variables directly for rr_control publishing plugin
configurable review generation for collecting job in rr_control publishing plugin

How to test
You can disable adding review flag on collected sequences in the Settings project_settings/royalrender/publish/CollectSequencesFromJob/review
If you set AVALON_ASSET, AVALON_TASK, AVALON_PROJECT, AVALON_APP_NAME, publishing script runned from rr_control shouldn't ask for context. For testing purposes you can do it directly in win__rrControl.bat, adding those lines before launching:
set "AVALON_ASSET=s010"
set "AVALON_TASK=lighting"
set "AVALON_PROJECT=ondra_playground_CML"
set "AVALON_APP_NAME=maya/2020"

Please revert last commit which renames the folder, merge develop, then do the rename.
Don't forget to change royal_render to royalrender in openpype\modules\base.py - variable: DEFAULT_OPENPYPE_MODULES.


[SPARK-29641][PYTHON][CORE] Stage Level Sched: Add python api's and tests

What changes were proposed in this pull request?

As part of the Stage level scheduling features, add the Python api's to set resource profiles.
This also adds the functionality to properly apply the pyspark memory configuration when specified in the ResourceProfile. The pyspark memory configuration is being passed in the task local properties. This was an easy way to get it to the PythonRunner that needs it. I modeled this off how the barrier task scheduling is passing the addresses. As part of this I added in the JavaRDD api's because those are needed by python.
Why are the changes needed?

python api for this feature
Does this PR introduce any user-facing change?

Yes adds the java and python apis for user to specify a ResourceProfile to use stage level scheduling.
How was this patch tested?

unit tests and manually tested on yarn. Tests also run to verify it errors properly on standalone and local mode where its not yet supported.

Test build #120650 has started for PR 28085 at commit 2b515c8.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25351/
Test PASSed.

Test build #120650 has finished for PR 28085 at commit 2b515c8.

This patch fails Python style tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/120650/
Test FAILed.

Test build #120651 has started for PR 28085 at commit a052427.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25352/
Test PASSed.

Test build #120651 has finished for PR 28085 at commit a052427.

This patch fails Python style tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/120651/
Test FAILed.

Test build #120653 has started for PR 28085 at commit 6a90fbe.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25353/
Test PASSed.

Test build #120653 has finished for PR 28085 at commit 6a90fbe.

This patch fails from timeout after a configured wait of 400m.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/120653/
Test FAILed.

test this please

Test build #120677 has started for PR 28085 at commit 6a90fbe.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25376/
Test PASSed.

Test build #120677 has finished for PR 28085 at commit 6a90fbe.

This patch fails from timeout after a configured wait of 400m.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/120677/
Test FAILed.

the tests are timing out running these:
-- Gauges ----------------------------------------------------------------------
master.aliveWorkers
4/1/20 12:13:40 PM =============================================================
-- Gauges ----------------------------------------------------------------------
master.aliveWorkers
4/1/20 12:33:40 PM =============================================================
-- Gauges ----------------------------------------------------------------------
master.aliveWorkers
4/1/20 12:53:40 PM =============================================================
I'm not sure what those tests are from. @dongjoon-hyun would you happen to know?

Ur, is this consistent failure on this PR? Let me check.

Retest this please.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25390/
Test PASSed.

Test build #120692 has started for PR 28085 at commit 6a90fbe.

Test build #120693 has started for PR 28085 at commit 2d754f7.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25392/
Test PASSed.

Test build #120692 has finished for PR 28085 at commit 6a90fbe.

This patch fails from timeout after a configured wait of 400m.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/120692/
Test FAILed.

Test build #120693 has finished for PR 28085 at commit 2d754f7.

This patch fails from timeout after a configured wait of 400m.
This patch merges cleanly.
This patch adds no public classes.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/120693/
Test FAILed.

Test build #120723 has started for PR 28085 at commit 1071f40.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25421/
Test PASSed.

The running Jenkins job still seems to fail.
-- Gauges ----------------------------------------------------------------------
master.aliveWorkers
4/2/20 9:15:05 AM ==============================================================

For now, I have no clue~, @tgravescs .

do you know which test is outputting that?

Test build #120723 has finished for PR 28085 at commit 1071f40.

This patch fails from timeout after a configured wait of 400m.
This patch merges cleanly.
This patch adds no public classes.

Test build #120877 has started for PR 28085 at commit e81a480.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25569/
Test PASSed.

Test build #120877 has finished for PR 28085 at commit e81a480.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/120877/
Test FAILed.

fyi - still addresses a few of the comments.

Test build #120881 has started for PR 28085 at commit ae8e312.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25573/
Test PASSed.

Test build #120881 has finished for PR 28085 at commit ae8e312.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/120881/
Test FAILed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25631/
Test PASSed.

I still need to look at the javaapiSuite, otherwise think I addressed all the comments

Test build #120939 has started for PR 28085 at commit 32bca95.

Test build #120939 has finished for PR 28085 at commit 32bca95.

This patch fails PySpark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/120939/
Test FAILed.

Test build #120976 has started for PR 28085 at commit 3e15ed9.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25667/
Test PASSed.

Test build #120976 has finished for PR 28085 at commit 3e15ed9.

This patch fails PySpark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/120976/
Test FAILed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25669/
Test PASSed.

Test build #120978 has started for PR 28085 at commit c3c885a.

Test build #120978 has finished for PR 28085 at commit c3c885a.

This patch fails PySpark pip packaging tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
class WorkerMemoryTest(unittest.TestCase):

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/120978/
Test FAILed.

looks like I need to udpate packaging scripts now that we have resource module

Test build #120985 has started for PR 28085 at commit 3562539.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25676/
Test PASSed.

Test build #120985 has finished for PR 28085 at commit 3562539.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/120985/
Test PASSed.

Test build #121339 has started for PR 28085 at commit bf1a215.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/26022/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/26023/
Test PASSed.

Test build #121340 has started for PR 28085 at commit 62cb02c.

Test build #121340 has finished for PR 28085 at commit 62cb02c.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/121340/
Test FAILed.

Test build #121339 has finished for PR 28085 at commit bf1a215.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/121339/
Test PASSed.

Test build #121377 has started for PR 28085 at commit a6e9ac2.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/26060/
Test PASSed.

@HyukjinKwon I believe I addressed all your comments. I made it so the python classes can be called before SparkContext creation with the exception of the ResourceProfile.id function.

Test build #121377 has finished for PR 28085 at commit a6e9ac2.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/121377/
Test FAILed.

test this please

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/26066/
Test PASSed.

Test build #121383 has started for PR 28085 at commit a6e9ac2.

Test build #121383 has finished for PR 28085 at commit a6e9ac2.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/121383/
Test PASSed.

That's nice, thanks @tgravescs for addressing my comments.

Looks pretty fine to me. I will do a final review and leave my sign-off within few days.

I am basically ok with change now. But I'm not good at python so it's still depends on @HyukjinKwon .

Test build #121535 has started for PR 28085 at commit 528094c.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/26218/
Test PASSed.

Test build #121535 has finished for PR 28085 at commit 528094c.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/121535/
Test PASSed.

looks like resource pyspark test ran now. Let me know if I missed anything with that.
Starting test(pypy): pyspark.resource.tests.test_resources
Finished test(pypy): pyspark.profiler (8s)
Starting test(pypy): pyspark.serializers
Finished test(pypy): pyspark.resource.tests.test_resources (6s)

retest this please

Test build #121604 has started for PR 28085 at commit 528094c.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/26283/
Test PASSed.

Test build #121604 has finished for PR 28085 at commit 528094c.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/121604/
Test PASSed.

Test build #121624 has started for PR 28085 at commit 89be02e.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/26304/
Test PASSed.

Test build #121627 has started for PR 28085 at commit 354fb0c.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/26306/
Test PASSed.

Test build #121624 has finished for PR 28085 at commit 89be02e.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/121624/
Test FAILed.

Test build #121627 has finished for PR 28085 at commit 354fb0c.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/121627/
Test PASSed.

Merged to master.
Thank you @tgravescs.


How do I show my imodel files in an offline environment using imodeljs?

I don't want to use the user authorization module provided in the project to access the imodel files published in the cloud. I need to use imodejs to access the imodel files on my own server, but I haven't seen the relevant code instance in the project description. Could you please provide the relevant technical materials?thank you

Hi @DarrenWen,
iModel.js offers the snapshot iModel which is a static point-in-time representation of a state of an iModel. Snapshot iModels don't require user authentication, and are meant for archival or data transfer purposes. You could use them for your case, but we highly recommend using the iModelHub for managing your iModels and preserving the integrity of your digital twin.
Initial documentation on snapshot iModels will be added in the next push. I will post a link here when its available.
Thanks,
Roop

Hi @sainiroop,
Thank you very much for your reply. I would like to know when the next version will be pushed. Is there any specific plan?

@DarrenWen the lastest version was pushed last week (iModel.js 1.1) and the documentation @sainiroop alluded to is here.
We're working on better messaging and a stable regular release cadence that is more transparent and predictable so stay tuned for announcements in the coming weeks...
If you have any issues with the snapshot API or documentation, please open those in the iModel.js repository.
Thanks!


Custom Logo Only Works For Default Styling

If I'm using a custom logo, it doesn't display if I use the flat-square or plastic style. Some examples:
No Style Specified

Flat Style Specified

Flat-Square Style Specified

Plastic Style Specified

Attempted to fix it here https://github.com/badges/shields/pull/677

So is it fixed?

Fixed in flat-square via #677. Still a problem in plastic.

Fixed plastic style badges via #1161
Closing as all badges now support logo's.
If you feel this issue has not been resolved feel free to re-open.


Add documentation on non-Windows machines

I was reading until I got to #reverse-engineer-your-model, and I don't know how to do the equivalent on a mac. Please add documentation to support more than just Windows.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 998197fe-077b-acee-c91c-12f074359e9e
Version Independent ID: 7542e87e-8f99-9b91-6df1-6983776ad1d2
Content: Get started on ASP.NET Core - existing database - EF Core
Content Source: entity-framework/core/get-started/aspnetcore/existing-db.md
Product: entity-framework
Technology: entity-framework-core
GitHub Login: @rowanmiller
Microsoft Alias: divega

Superseded by #481


gorm is converting times with time zones to UTC before saving

It seems that gorm is converting local times to UTC when writing to my database but the time object in golang has the correct timezone and the field is a timestamp with time zone. Is this expected behavior?
Something like this ...
timezone, _ := time.LoadLocation("Europe/Berlin")
future := time.Now().In(timezone).Add(24 * time.Hour)
log.Printf("future: %+v", future)
streak.ExpiresAt = &future
conn.Debug().Omit(clause.Associations).Save(&streak)

This outputs:
future: 2022-09-22 00:00:00 +0200 CEST

And the query
UPDATE "lesson_streaks" SET "user_id"='34193e38-1e61-11ed-8941-8a6a814de1b1',"expires_at"='2022-09-22 00:00:00' WHERE "id" = 'c17dcc04-28e2-11ed-a750-8a6a814de1b1'

So it's converting to UTC but I want this is the local timezone because it's a future event and if the UTC offset changes during a daylight savings event, it will be inaccurate.

I'm still having issues getting the gorm playground up and running

Here you need to modify the DSN configuration，refer to https://github.com/go-sql-driver/mysql#loc


can't login after successful installation (on vbox)

tested on vbox - maybe that script is not compatible with this?
XDM displayed ok shortly after boot , but when I am entering my credentials (no matter if root or the user -> they both can login via console) goes back to the XDM.

It should work fine under vbox.
Which desktop environment are you using?
Also see https://github.com/outpaddling/desktop-installer/issues/8.

thanks , its icewm and the "test" desktop during the setup opened without any issue.
I ve checked the #8 , not that related to my issue, I do have the XDM , and I start the WM via startx when I login from console login. I may ditch the XDM at all no big deal...

Try commenting out the sysctl line in /usr/local/etc/xsession.desktop-installer.
Looks like the VBoxClient --display option has been deprecated.
This should allow the WM to start from XDM, but resizing the VBox window probably won't work.

Actually try replacing VBoxClient --display with VBoxClient --vmsvga.  With this my ICEWM desktop resizes successfully.

ah this works! thanks!

Good to hear.  Committed <IP_ADDRESS> to ports with this fix.

vmsvga

If guest additions are installed, you should probably refrain from using VMSVGA.

Interesting.  Seems to work fine, but I'll investigate further.

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=254266#c7

Thanks - note that what we're referring to here is running "VBoxClient --vmsvga" from Xsession to enable resizing with the VBoxVGA or VBoxSVGA devices, not selecting the VMSVGA device in the VM settings.  Interestingly this seems to work fine with VBoxVGA, though VBoxSVGA is probably a better choice based on the PR discussion.  Desktop-installer currently only does this with the basic window managers currently supported; ICEWM, FluxBox, WindowMaker, all of which passed basic resize testing using VBoxVGA.  This is not necessary for desktop environments such as XFCE, KDE, etc.

Thanks for the work! Looks like FBSD's bug (vbox drivers) as without the XDM the icewm starts (from the console I mean)

https://github.com/outpaddling/desktop-installer/issues/10#issuecomment-841691915
Thanks,

… "VBoxClient --vmsvga" from Xsession to enable resizing with the VBoxVGA or VBoxSVGA devices …

sorry for overlooking the context.
(I need to familiarise myself with desktop-installer capabilities.)


Plan consolidated API for TokenDetectionController + DetectTokensController

Look into how TokenDetectionController (from this repo) is being used in the mobile app (including the patches for this controller in mobile) and how DetectTokensController is being used in the extension, and determine an API for a combined controller that satisfies the requirements that extension and mobile have.

Consolidated TokenDetectionController API

Note: remove all properties from TokenDetection{Config,State} and use private class fields instead.

Constructor

interval (optional)
chainId (required)
messenger (required)

Fields

disabled: replace with KeyringController active state?

super.#intervalLength

intervalId

chainId

selectedAddress

isDetectionEnabledFromPreference

isDetectionEnabledForNetwork

Callbacks for communicating with BaseControllerV1 controllers:

onPreferenceStateChange
getBalancesInSingleCall
addDetectedTokens
getTokensState
getPreferencesState

Methods

super.{g,s}etIntervalLength
start()
stop()
detectTokens (merge: detectNewTokens())

Rename as _executePoll()?
Refactor - extract methods:

updateTokens()
getTokensToDetectSlices()
safelyExecute()

@throws: MetaMask - DetectTokensController single call balance fetch failed
Add this.trackMetaMetricsEvent call

getCorrectChainId() (merge: getChainIdFromNetworkStore())

add

extension:

#registerKeyringHandlers()
isActive()
trackMetaMetricsEvent()

mobile:

updateTokensName: (tokenList) => tokensController.updateTokensName(tokenList)

const { tokens } = this.getTokensState();
...
if (tokens.length && !tokens[0].name) {
	this.updateTokensName(tokenList);
}

remove

core:

startPolling()
stopPolling()

extension:

interval accessors
tokenList setter
restartTokenDetection(): use start(), stop() calls instead

Is this essentially blocked by https://github.com/MetaMask/core/issues/3625? Would you need to revisit this once that's merged?

Any changes to the TokenDetectionController API that are made in #3625 will need to be reflected here as well, but it doesn't look like there will be any significant departures from what I have right now.
Mostly I need a sign-off on the plan in the comment above before I can get started on #3626. That can wait until after #3625 is merged, though.

It is good that you've noted some of the ways that each implementation captures data internally, but the list is fairly large for what is a small controller. I wonder if it would be better to list the public API that we want to have rather than all of the private properties and methods that are present. How we end up storing data internally or refactoring the logic, we can decide when we create the consolidated version, but I don't know if that's important for now.
Here's what I see as the public API:

Everything from BaseController and StaticIntervalPollingController (we can't change this, so it stays)

name instance property
metadata instance property
state getter
setIntervalLength
getIntervalLength
startPollingByNetworkClientId
stopAllPolling
stopPollingByPollingToken
onPollingCompleteByNetworkClientId
_executePoll (not part of the public API, but something that needs to be implemented)

detectTokens (or detectNewTokens — whatever we want to call it)

That said, I know I'm sort of changing the purpose of this ticket, but in addition to reviewing the public API, perhaps we should also take this time to audit the behavior between the three implementations as well, and capture a list of differences there. When creating a consolidated version of the controller I imagine we'll want to do some refactoring, so we'll want to make sure we preserve any nuances.
I see you've done this a bit already: you've alluded to the fact that DetectTokensController (extension implementation) keeps track of the locked/unlocked state of the wallet, and calls the method to detect tokens when the wallet is unlocked, and refuses to detect tokens when it's locked.
Besides this, it looks like there may be other slight differences in the constructor in TokenDetectionController vs. DetectTokensController. Specifically, in TokenDetectionController, when TokenListController state changes, the method to detect tokens is called only when the tokens collection is non-empty; but in DetectTokensController, it's always called.
Also, detectTokens in TokenDetectionController is slightly different from detectNewTokens in DetectTokensController:

Whereas TokenDetectionController caches the selected chain and whether or not it supports token detection, DetectTokensController reads the selected chain every time it's called
Whereas TokenDetectionController aborts if token detection has been disabled in preferences, DetectTokensController does not abort if token detection has been disabled in preferences but the current chain is mainnet; instead, a static list of tokens is used as the base (so as not to make any additional network requests?).
Whereas TokenDetectionController calls TokensController.addDetectedTokens with the tokens from TokenListController's tokenList collection which are not in TokensController's tokens collection, not in TokensController's ignoredTokens collection, and have a non-zero balance, DetectTokensController goes one step further and excludes tokens which are already in TokensController's detectedTokens collection.

Between what you've noted and what I've noted, I imagine we probably have enough to go on, but if you find any other differences feel free to add them here.
I'll let you close this ticket when you feel you have enough information to proceed to #3626.

Some notes on current direction:

Constructor

Follow detectTokensController usage of restartTokenDetection instead of detectTokens
Subscribe to AccountsController:selectedAccountChange event
Avoid triggering TokenListController:stateChange for empty tokens list

Replace #disabled checks with isActive
detectTokens:

tokens-controller: apply messenger pattern

Subscribe to tokens-controller: maintain cache of ignoredTokens, detectedTokens
Exclude tokens already in detectedTokens list from detectTokens logic

If isTokenDetectionInactiveInMainnet is true: early exit (handled by #isDetectionEnabledFromPreferences).

OR copy logic for generating static mainnet token list? reach out to mobile team on importance of handling this case explicitly.

Accept _trackMetaMetricsEvent callback

Generate and pass eventTokensDetails

throw error block is handled by _safelyExecute()

restartTokenDetection

triggers detectTokens and resets interval length to default
all other logic moved into detectTokens


Passive and active "skills"

Should help make the game deeper and more interesting. Skills will be gained in battles and with evolutions.

Passive skills were added somewhere. Active skills will be moved to a new version of the game, I believe... closing for now.


Factor out current implementation of compute_ik_opt from PinocchioIKSolver to UnderactuatedIKSolver and make PinocchioIKSolver more generic.

🚀 Feature
Addresses comments in #76 re:niche use-case of optimizing for only 5 joints.
Motivation
Makes PinocchioIKSolver more generic for use across Stretch stack.

Resolved in https://github.com/facebookresearch/home-robot/pull/76/commits/bf372659833973bcc528541a3711eb7ce1e54716


Added SCONS to vcpkg_find_acquire_program

See: http://scons.org
I have a port I would like to submit which uses scons (which in
turn uses the python interpreter already provided). This change
makes SCONS usable for vcpkg_execute_required_process.

Thanks!


Arm version of uuu?

Hi, guys,
I installed lava dispatcher on my Raspberry Pi device, I want to know can we use lava uuu action from arm device?
BR
David

It should work.  If met issue, let me know

Hi @nxpfrankli,
I got an error when I try to flash image on the Macbook (M2 silicon),
is there any suggestion for me to fix it?


dockerize the build of genesis live CDs

@tumblr/systems @roymarantz @defect @Primer42 @maddalab This will make building genesis live CDs easier, by dockerizing the dependencies.

Of note: there is an issue where a newer version (SL7's version) of livecd creator will fail to build genesis, complaining Error creating Live CD : Unable to run ['/usr/bin/firewall-offline-cmd', '--disabled']!.

LGTM

@Primer42 have you tested this? I would feel better with someone else running thru my docs and ensuring a bootable image was created. Also, hello!

@byxorna - I tested that it built the images. I haven't tested that the images work yet. I was going to do that next.

Also, hello!

@Primer42 can you please merge this?

Sorry for the delay @byxorna - I'll have automated builds up on the docker hub soon too.


about training

Hello，thank for you code release. Does the provided training script perform LoRA fine-tuning or full parameter training after execution?

Hello, thanks for your interests. The provided training scripts perform LoRA fine-tuning.

Hello, thanks for your interests. The provided training scripts perform LoRA fine-tuning.

ok, I get it, thank you


Trigger CI

Debugging CI failures from #1579.

:books: Documentation preview :books:: https://poliastro--1580.org.readthedocs.build/en/1580/

This is the offending line:
https://github.com/numpy/numpy/blob/e47cbb69bebf36007c3ea009aee03e4bfe3b3f3d/numpy/__init__.pyi#L636

Tried python_version = 3.8 and python_version = 3.10 and looks like in both cases the Python 3.10 pipeline fails. Unfortunately I won't have time to investigate this in the coming days.

Closing this as the pipeline is healthy again.


bug: @ionic/angular 5.0.6 and 5.0.7 - ion-input laggy response on iOS

Bug Report
Ionic version:

[x] 5.x
Current behavior:

Reactive form is slow to respond when user taps an input fields on iOS (not Android). Noticeable delay between tapping on field and cursor appearing
Expected behavior:

Cursor appears in tapped field immediately.
Steps to reproduce:

Install demo app from GitHub link below
cd into folder
npm install
ionic serve
Open Developer Tools in Google Chrome
Toggle device toolbar
Choose an iOS device
Refresh page and tap on any input field (select fields work fine)
Choose an Android device
Refresh page and tap on any input field

Related code:
A sample application is available via GitHub: https://github.com/RichardPilbery/ionic_angular_lag_issue
Other information:
Reverting the @ionic/angular version back to 5.0.5 resolves the issue.
Ionic info:

Ionic:

   Ionic CLI                     : 6.4.0 (/usr/local/lib/node_modules/@ionic/cli)
   Ionic Framework               : @ionic/angular 5.0.7
   @angular-devkit/build-angular : 0.803.26
   @angular-devkit/schematics    : 8.3.26
   @angular/cli                  : 8.3.26
   @ionic/angular-toolkit        : 2.2.0

Capacitor:

   Capacitor CLI   : 1.5.0
   @capacitor/core : 1.5.0

Utility:

   cordova-res : not installed
   native-run  : not installed

System:

   NodeJS : v12.4.0 (/usr/local/bin/node)
   npm    : 6.9.0
   OS     : macOS Mojave

Thanks for the issue. This issue has already been resolved and a fix will be available in an upcoming release of Ionic Framework.

@liamdebeasi Are you going to link any additional information about this fix to this issue? We have no way of tracking this fix otherwise.

PR that fixes the issue: https://github.com/ionic-team/ionic/pull/20987
Original issue reporting the bug: https://github.com/ionic-team/ionic/issues/20922

When the fix ships, we will mention it in our CHANGELOG file along with a link to the commit and #20922. We will also mention it on our Releases Page.


Added the gradient for arctan2

Added the gradient of arctan2 for jvp and vjp. Also included a binary ops test for the arctan2 function.

Beautiful, thanks! It's so satisfying to see both forward- and reverse-mode added and auto-tested!


mac-6 is low on disk space.

Type of Request
bug
Infrastructure Environment
LUCI, Github, Cocoon scheduler, Autosubmit, etc...
What is happening?
mac-6 is low on disk space.

Steps to reproduce
Step 1:
Step 2:
..
Step n:
Expected results
I expect to see X when Y is finished.

@yusuf-goog,
mac-6 is low on disk space.  Is there any files can remove under /Users/swarming to free disk space?
Thanks.

cleaned up some temp dirs and system is now back to operation.


Allow compatibility with Vite >= v.3.x.x

What?
Solves this issue https://github.com/pd4d10/vite-plugin-svgr/issues/37

closes #37


fix ovn-ic blacklist not work on ipv6

Hi @changluyi , I opened a bug in LP about this problem.
https://bugs.launchpad.net/ubuntu/+source/ovn/+bug/2046804
Have you written tests in the OVN testsuite to validate regressions here?

Hey, we tested this patch and it works fine. Do you know when it will be added to upstream?

Hey, we tested this patch and it works fine. Do you know when it will be added to upstream?

Unfortunately we cannot apply this patch until the author signs off (Developer's Certificate of Origin,), please see my comment above.  The documentation section for submitting patches is available here:
https://docs.ovn.org/en/latest/internals/contributing/submitting-patches.html#tags
It would also be nice if this change had a unit test to make sure this doesn't break in the future.
Thanks,
Dumitru

@rbartzen @dceara unfortunately the only person who can provide a Signed-off-by tag is @changluyi .  So, if the author doesn't respond the only option would be to write a new patch and send it out from your name.  The code in this PR cannot be used as it is copyrighted by default (not a legal advice :D ).  If you do not trust yourself to not plagiarize the code in this PR as you already looked at it, describe the issue to someone else and ask them to write a fix without looking at this PR. :)

Closing this in favor of https://github.com/ovn-org/ovn/commit/78750699ab195a1b2c48fbab8546ed0651b05de4


Decide how to ignore tracks in degradations

We will ignore them in our model input and output, but how should we handle them in the degradations?
For example, can join_notes join across tracks (this would be "ignoring")?

We've decided that the degradations will still handle tracks if given, and we will keep the column, but for initial release, the csv loading will flatten all notes to track 0.


remove grafana: BUG-60332

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Can one of the admins verify this patch?


Generic lookups for object allocator and array allocaor

Generic lookups for object allocator and array allocator.

Changes has been reviewed by @MichalStrehovsky #

@dotnet-bot test OSX Debug and CoreCLR tests


Fix: Do logout on GitHub token expiration

Fixes #63

Not able to add comments showing not a collaborator

Not able to add comments. Shows not a collaborator


Notes on things that could be changed in the future

Some notes on things that could be changed in future releases of the PLB.

P38

Difference in chair conformation in unsaturated ring which can lead to sampling problems
In the future: run A-->B; B-->A transformations for such a ligand pair to see whether there is slow convergence/whether the conformation has an impact on the DDG.

SHP2

NH2 for 21 ligands pointing in one direction, in different direction for 1 ligand
Potentially change this in the future

PTP1B

Ligand lig_20669_2qbr not same pose as Xray ligand in 2qbr

Could be overlaid onto crystallographic ligand in the future

Ligands lig_20667_2qbp and lig_23486 and lig_23484 very similar structure, but different pose

Could be overlaid better in the future


Merge PR #23 into s2a-master branch

PR #23 was approved by @yihuazhang; this PR merged the branch into s2a-hs-client-2 into the feature branch s2a-hs-client. Due to several recent merges into s2a-master, there were several merge conflicts when I attempted to then merge s2a-hs-client-2 into s2a-master. This PR fixes those merge conflicts.
There should be no functional changes between this PR and PR #23.

Thanks for the quick review @yihuazhang!
Squashing and merging now.


Should check if the user already logged in when Auth.login()

If user already logged in, we should just say

{username} already logged in, have fun. If you want to login to another account, please run jina auth logout first

or something like that.
We can also provide an option -f --force which can allow users login forcely.
@delgermurun Any thoughts on this?

I agree. We need it.

https://github.com/jina-ai/auth/blob/0f6eafc83c8abea3b30ab92f4bb6c26c2143a870/auth/api.py#L5
We can add prompt=login to this line. This will suggest the Identity provider prompt user for authorization again.
Instead of implicitly granting access to current logged-in user.
hubble.login(prompt=login)

https://github.com/jina-ai/auth/blob/0f6eafc83c8abea3b30ab92f4bb6c26c2143a870/auth/api.py#L5 We can add prompt=login to this line. This will suggest the Identity provider prompt user for authorization again. Instead of implicitly granting access to current logged-in user. hubble.login(prompt=login)

Done


Revert file: confirmation prompt

The file>revert command should prompt for confirmation before doing so.

Fixed in 725fd32921be6976f4a4e26a3989fa4bb640bd3f


consistent labels for woman* / women* / Frau(en)* / female speaker(s)* / speakerinnen*

sometimes there is an asterisk indicating/highlighting the term and linking to the definition in the footer (which is still not available on all pages). unify that and mark all used terms with an asterisk.

done


Workload list page & Create is broken

Date - 3/19
Steps:

Go to workloads

Results:  page is blank and error in console:
vue.runtime.esm.js:1888 TypeError: Cannot read property 'slice' of undefined

Try to create a workload
Error - { "kind": "Status", "apiVersion": "v1", "metadata": {}, "status": "Failure", "message": "the server could not find the requested resource", "reason": "NotFound", "details": {}, "code": 404 }

Fixed


Api for syncing Resource information

Description
We need to expose an api in access management so Resource Registry can update the central metadata information in access management database
Additional Information
No response
Tasks

[x] Expose API with minal Resource model
[x] Integrate with db to update the resource metadata table in access management
[x] Update resource registry to call this API when creating and updating resource

Acceptance Criterias

[x] Possible for Resource Registry to call to create and update resource info in access management
[x] When resource registry changes or created resource, this is synced with access management

Verified through test migration run in both AT and TT environments. Closing issue