Spelling mistake in getter/setter method of mQClientFactory

Please describe the issue you observed:

There should be spelling getMqClientFactory or getMQClientFactory

Please tell us about your environment:
4.9.2

fix by pr #3581

Merge

This method is public and now break compatibility.
Can we rollback it?

@duhenglucky @RongtongJin

�It seems that no relevant interface is exposed to the user

no, we use it in our project.

it's better to add a new method like ”getClientFactory“  and make the current "getmQClientFactory" deprecated.


no-commented-out-code marks jsdoc

Jsdoc is getting marked as invalid if there is no @params or the return type isn't void.
    /**
     * @return {void}
     */
    okayVoid(): void {
        return;
    }

    /**
     * @param {Object} items
     * @return {string}
     */
    okayParams(items: Object): string {
        return '';
    }

    /**
     * @return {Object}
     */
    notOkay(): Object {
        return {};
    }

Thanks for reporting this issue! Submitting a Pull Request with a failing test case would be great. Here is the applicable file for tests: https://github.com/Glavin001/tslint-clean-code/blob/master/src/tests/NoCommentedOutCodeRuleTests.ts
If you're feeling up to the challenge of fixing the problem, too, here is the applicable file for the rule itself: https://github.com/Glavin001/tslint-clean-code/blob/master/src/noCommentedOutCodeRule.ts
Thanks in advance for contributing!

Related: // TODO:  is also false-flagged

I'd like to take a shot at this! :-)


Minor: Add new Extended ClickBench benchmark queries

Which issue does this PR close?
Part https://github.com/apache/arrow-datafusion/issues/5472
Rationale for this change
We don't have great benchmark coverage for COUNT(DISTINCT <String>) where the lengths of the strings are small. This came up as part of https://github.com/apache/arrow-datafusion/pull/8849
What changes are included in this PR?

Add two new queries in "extended" clickbench suite: (see #8861) that cover count distinct for short string columns

Are these changes tested?
I tested them manually
Are there any user-facing changes?
No, this is benchmark only

@Dandandan  / @andygrove  I wonder if you would have time to quickly review this PR (mostly docs + 2 queries) so I can run benchmarks on https://github.com/apache/arrow-datafusion/pull/8849 against main?

Thank you @tustvold


Password Protected Blogs: Login form & settings design

Main issue: https://github.com/TryGhost/Ghost/issues/4993

The password protected blogs feature has two pieces of design work needed to complete it:

The design for the login page, which is going to live at /private/
The spec/design for the location of the password and message inputs somewhere in the settings panel.

1.
Centered horizontally and vertically. Should be able to re-use some styles from new install screen. 36px heading. Wrapper max-width 400px.

2.

^ Generate simple random password each time this feature is switched on/off

@ErisDS @JohnONolan Do you want me to take care of this in #4993?

Styles up in #5255 - couple of other small changes:

[ ] This can go straight into the bottom of settings/general and out of labs
[ ] Currently it breaks if you press "enter" instead of save (it should just work)
[ ] It would be cool to generate a random, pronounceable password by default (it should change each time the feature is turned on/off)

I'll get right on that @johnonolan

@ErisDS @JohnONolan I just realized something. There needs to be some documentation on how to customize the password.hbs file in themes, given that it needs a form that sends info back to the server in specific format.

@acburdine with regards to documentation, I opened #5265 which makes some small changes to how the password.hbs template works, including renaming it to private.hbs to match the route. I'll update the theme docs for 0.6.3 to cover how all this works :)

Reopening this as it needs the design fixed up for Zelda.


Add a parameter to adjust number of decimals for other referentials

Actually, only UD referential have a parameter to adjust decimals numbers. It could be great to add this for other referentials.

The decimals are already applied to all referentials. But it makes no sense in the quantitative view because ther are only integers.

I have a doubt about the fact that decimals are already applied to all referentials. Decimals makes sense in quantitative view with scientific display. For instance, 1.78987 TMB –> 1.78 TMB.
By the way, I can't open preference window, it crash:
  File "/home/moul/Documents/cutecoin/build/src/cutecoin/gui/mainwindow.py", line 194, in open_preferences_dialog
    dialog = PreferencesDialog(self.app)
  File "/home/moul/Documents/cutecoin/build/src/cutecoin/gui/preferences.py", line 60, in __init__
    self.combox_proxytype.setCurrentText(self.app.preferences.get('proxy_type', "HTTP"))
AttributeError: 'PreferencesDialog' object has no attribute 'combox_proxytype'
Traceback (most recent call last):
  File "/home/moul/Documents/cutecoin/build/src/cutecoin/gui/mainwindow.py", line 194, in open_preferences_dialog
    dialog = PreferencesDialog(self.app)
  File "/home/moul/Documents/cutecoin/build/src/cutecoin/gui/preferences.py", line 60, in __init__
    self.combox_proxytype.setCurrentText(self.app.preferences.get('proxy_type', "HTTP"))
AttributeError: 'PreferencesDialog' object has no attribute 'combox_proxytype'

Should be fixed !

Thanks :dart:


[Bug]: ELBv2 Provider v1.5.0+ LBListener 'panic'

Is there an existing issue for this?

[X] I have searched the existing issues

Affected Resource(s)
elbv2.aws.upbound.io/v1beta1, Kind=LBListener
Resource MRs required to reproduce the bug
---
apiVersion: elbv2.aws.upbound.io/v1beta1
kind: LBListener
metadata:
  name: https
spec:
  deletionPolicy: Delete
  forProvider:
    region: us-east-1
    protocol: TCP
    port: 443
    defaultAction:
      - type: forward
        targetGroupArn: validTargetGroupArn
    loadBalancerArn: validLoadBalancerArn

Steps to Reproduce
Deploy elbv2.aws.upbound.io/v1beta1 LB, LBTargetGroup and LBListener with v1.4.0 is successful.
Bump elbv2 Provider version to v1.5.0 or v1.6.0, an Observed a panic: value is null is logged
What happened?
After bumping version from v1.4.0 to v1.5.0+, the following is logged for existing LBListener:
2024-06-10T18:41:57Z	DEBUG	provider-aws	Observing the external resource	{"uid": "838a6eb0-7742-4b8c-ab9f-2163e6a7290b", "name": "use1-sandbox-primary-internal-j6h86-6xnx2", "gvk": "elbv2.aws.upbound.io/v1beta1, Kind=LBListener"}
E0610 18:41:57.677193       1 runtime.go:77] Observed a panic: value is null
goroutine 3841 [running]:
k8s.io/apimachinery/pkg/util/runtime.logPanic({0x134f03a0, 0x1936c980})
	k8s.io/apimachinery@v0.29.4/pkg/util/runtime/runtime.go:75 +0x85
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Reconcile.func1()
	sigs.k8s.io/controller-runtime@v0.17.3/pkg/internal/controller/controller.go:108 +0xb2
panic({0x134f03a0?, 0x1936c980?})
	runtime/panic.go:770 +0x132
github.com/hashicorp/go-cty/cty.Value.LengthInt({{{0x195976d8?, 0xc00bdb2290?}}, {0x0?, 0x0?}})
	github.com/hashicorp/go-cty@v1.4.1-0.20200723130312-85980079f637/cty/value_ops.go:989 +0x258
github.com/hashicorp/terraform-provider-aws/internal/service/elbv2.flattenLbForwardActionOneOf({{{0x195976d8?, 0xc00bdb22e0?}}, {0x130d90a0?, 0xc00bce7d10?}}, 0x0, {{0xc00c7f38e0, 0x7}, 0x0, 0x0, 0x0, ...}, ...)
	github.com/hashicorp/terraform-provider-aws@v0.0.0-00010101000000-000000000000/internal/service/elbv2/listener.go:1036 +0x1de
github.com/hashicorp/terraform-provider-aws/internal/service/elbv2.flattenLbForwardAction(0xc00d1e8400, {0x16800240, 0xe}, 0x0, {{0xc00c7f38e0, 0x7}, 0x0, 0x0, 0x0, 0xc0052f3b30, ...}, ...)
	github.com/hashicorp/terraform-provider-aws@v0.0.0-00010101000000-000000000000/internal/service/elbv2/listener.go:1014 +0x22b
github.com/hashicorp/terraform-provider-aws/internal/service/elbv2.flattenLbListenerActions(0xc00d1e8400, {0x16800240, 0xe}, {0xc00cce80f0?, 0x1, 0x41a085?})
	github.com/hashicorp/terraform-provider-aws@v0.0.0-00010101000000-000000000000/internal/service/elbv2/listener.go:979 +0x2c5
github.com/hashicorp/terraform-provider-aws/internal/service/elbv2.resourceListenerRead({0x19596cf8, 0xc005270d20}, 0xc00d1e8400, {0x167734a0?, 0xc00271c000?})
	github.com/hashicorp/terraform-provider-aws@v0.0.0-00010101000000-000000000000/internal/service/elbv2/listener.go:535 +0x5db
github.com/hashicorp/terraform-provider-aws/internal/provider.New.(*wrappedResource).Read.interceptedHandler[...].func9(0xc00d1e8400?, {0x167734a0?, 0xc00271c000})
	github.com/hashicorp/terraform-provider-aws@v0.0.0-00010101000000-000000000000/internal/provider/intercept.go:113 +0x283
github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema.(*Resource).read(0x19596da0?, {0x19596da0?, 0xc00ce11490?}, 0xd?, {0x167734a0?, 0xc00271c000?})
	github.com/hashicorp/terraform-plugin-sdk/v2@v2.33.0/helper/schema/resource.go:790 +0x7a
github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema.(*Resource).RefreshWithoutUpgrade(0xc001e25b20, {0x19596da0, 0xc00ce11490}, 0xc00198c820, {0x167734a0, 0xc00271c000})
	github.com/hashicorp/terraform-plugin-sdk/v2@v2.33.0/helper/schema/resource.go:1089 +0x529
github.com/crossplane/upjet/pkg/controller.(*terraformPluginSDKExternal).Observe(0xc00ba9ddc0, {0x19596da0, 0xc00ce11490}, {0x1969ab10, 0xc00cd0d508})
	github.com/crossplane/upjet@v1.4.0/pkg/controller/external_tfpluginsdk.go:472 +0x173
github.com/crossplane/upjet/pkg/controller.(*terraformPluginSDKAsyncExternal).Observe(0xc00d23c1e0, {0x19596da0, 0xc00ce11490}, {0x1969ab10, 0xc00cd0d508})
	github.com/crossplane/upjet@v1.4.0/pkg/controller/external_async_tfpluginsdk.go:127 +0xc5
github.com/crossplane/crossplane-runtime/pkg/reconciler/managed.(*Reconciler).Reconcile(0xc00a9b2f00, {0x19596cf8, 0xc005085440}, {{{0x0, 0x0}, {0xc0070bc690, 0x29}}})
	github.com/crossplane/crossplane-runtime@v1.16.0-rc.2.0.20240510094504-3f697876fa57/pkg/reconciler/managed/reconciler.go:914 +0x2150
github.com/crossplane/crossplane-runtime/pkg/ratelimiter.(*Reconciler).Reconcile(0xc006636640, {0x19596cf8, 0xc005085440}, {{{0x0?, 0x5?}, {0xc0070bc690?, 0xc00cb99d10?}}})
	github.com/crossplane/crossplane-runtime@v1.16.0-rc.2.0.20240510094504-3f697876fa57/pkg/ratelimiter/reconciler.go:54 +0x151
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Reconcile(0x195b60d8?, {0x19596cf8?, 0xc005085440?}, {{{0x0?, 0xb?}, {0xc0070bc690?, 0x0?}}})
	sigs.k8s.io/controller-runtime@v0.17.3/pkg/internal/controller/controller.go:119 +0xb7
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).reconcileHandler(0xc0065aee60, {0x19596d30, 0xc0013d3b80}, {0x15172980, 0xc00ce0f2e0})
	sigs.k8s.io/controller-runtime@v0.17.3/pkg/internal/controller/controller.go:316 +0x3bc
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem(0xc0065aee60, {0x19596d30, 0xc0013d3b80})
	sigs.k8s.io/controller-runtime@v0.17.3/pkg/internal/controller/controller.go:266 +0x1be
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func2.2()
	sigs.k8s.io/controller-runtime@v0.17.3/pkg/internal/controller/controller.go:227 +0x79
created by sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func2 in goroutine 3650
	sigs.k8s.io/controller-runtime@v0.17.3/pkg/internal/controller/controller.go:223 +0x50c

When attempting to create a new Listener with elbv2 v1.5.0, Listeners are created correctly and associated with Load-Balancer, but the following status is eventually returned:
status:
  atProvider: {}
  conditions:
    - lastTransitionTime: '2024-06-10T18:52:32Z'
      reason: Creating
      status: 'False'
      type: Ready
    - lastTransitionTime: '2024-06-10T18:54:30Z'
      message: >-
        cannot patch the managed resource via server-side apply:
        LBListener.elbv2.aws.upbound.io
        "use1-sandbox-primary-internal-j6h86-nv9z8" is invalid: spec: Invalid
        value: "object": spec.forProvider.defaultAction is a required parameter
      reason: ReconcileError
      status: 'False'
      type: Synced
    - lastTransitionTime: '2024-06-10T18:54:30Z'
      message: >-
        async create failed: failed to create the resource: [{0 creating ELBv2
        Listener (): operation error Elastic Load Balancing v2: CreateListener,
        https response error StatusCode: 400, RequestID:
        677dd570-2c5f-4a16-9644-44ce704005f7, api error ValidationError: The
        input parameters provided are not supported  []}]
      reason: AsyncCreateFailure
      status: 'False'
      type: LastAsyncOperation

Relevant Error Output Snippet
No response
Crossplane Version
1.16.0
Provider Version
1.5.0
Kubernetes Version
No response
Kubernetes Distribution
No response
Additional Info
No response

@turkenf , it appears to still be an issue after updating the provider to v1.7.0.

Adding voice to this issue.  It also occurs in 1.6.0 and 1.6.1 as well.

Yes, I have also encountered this problem and don't know what to do，Looking forward to the next version resolving this issue.
version:
xpkg.upbound.io/upbound/provider-aws-elbv2:v1.9.0
xpkg.upbound.io/crossplane/crossplane:v1.16.0

Hello folks,
Thank you for your comments on this issue. It can be reproduced with provider version v1.9.0. I will take a deeper look as soon as possible.

@turkenf maybe this helps: https://github.com/pulumi/pulumi-aws/issues/3429

I'm seeing the same thing with the following setup:
% kubectl get providers
NAME                          INSTALLED   HEALTHY   PACKAGE                                                    AGE
provider-aws-autoscaling      True        True      xpkg.upbound.io/upbound/provider-aws-autoscaling:v1.10.0   57d
provider-aws-ec2              True        True      xpkg.upbound.io/upbound/provider-aws-ec2:v1.10.0           58d
provider-aws-ecr              True        True      xpkg.upbound.io/upbound/provider-aws-ecr:v1.10.0           22d
provider-aws-elbv2            True        True      xpkg.upbound.io/upbound/provider-aws-elbv2:v1.10.0         44h
provider-aws-iam              True        True      xpkg.upbound.io/upbound/provider-aws-iam:v1.10.0           63d
provider-aws-kms              True        True      xpkg.upbound.io/upbound/provider-aws-kms:v1.10.0           22d
provider-aws-s3               True        True      xpkg.upbound.io/upbound/provider-aws-s3:v1.10.0            64d
upbound-provider-family-aws   True        True      xpkg.upbound.io/upbound/provider-family-aws:v1.10.0        64d

Here is the resource I create:
apiVersion: elbv2.aws.upbound.io/v1beta2
kind: LBListener
metadata:
  labels:
    environment: dev
    name: dev-us-east-1-private-consul-nlb-tcp-8500
    region: us-east-1
    subnet-type: private
    vpc-name: dev-us-east-1
  name: dev-us-east-1-private-consul-nlb-tcp-8500
spec:
  forProvider:
    defaultAction:
    - targetGroupArnSelector:
        matchLabels:
          environment: dev
          name: dev-us-east-1-private-consul-nlb-tcp-8500
          region: us-east-1
          subnet-type: private
          vpc-name: dev-us-east-1
      type: forward
    loadBalancerArnSelector:
      matchLabels:
        environment: dev
        name: dev-us-east-1-private-consul-nlb
        region: us-east-1
        subnet-type: private
        vpc-name: dev-us-east-1
    port: 8500
    protocol: TCP
    region: us-east-1

As soon as that resource is applied, the elbv2 provider panics:
{"level":"info","ts":"2024-08-02T16:20:10Z","logger":"provider-aws","msg":"Beta feature enabled","flag":"EnableBetaManagementPolicies"}
panic: value is null

goroutine 31497 [running]:
github.com/hashicorp/go-cty/cty.Value.LengthInt({{{0x1c4c14b8?, 0xc0036bc0f0?}}, {0x0?, 0x0?}})
	github.com/hashicorp/go-cty@v1.4.1-0.20200723130312-85980079f637/cty/value_ops.go:989 +0x258
github.com/hashicorp/terraform-provider-aws/internal/service/elbv2.flattenLbForwardActionOneOf({{{0x1c4c14b8?, 0xc0036bc110?}}, {0x15724ee0?, 0xc003583848?}}, 0x0, {{0xc0047809c0, 0x7}, 0x0, 0x0, 0x0, ...}, ...)
	github.com/hashicorp/terraform-provider-aws@v0.0.0-00010101000000-000000000000/internal/service/elbv2/listener.go:1038 +0x1de
github.com/hashicorp/terraform-provider-aws/internal/service/elbv2.flattenLbForwardAction(0xc003c39600, {0x1944aa1c, 0xe}, 0x0, {{0xc0047809c0, 0x7}, 0x0, 0x0, 0x0, 0xc004c855c0, ...}, ...)
	github.com/hashicorp/terraform-provider-aws@v0.0.0-00010101000000-000000000000/internal/service/elbv2/listener.go:1016 +0x22b
github.com/hashicorp/terraform-provider-aws/internal/service/elbv2.flattenLbListenerActions(0xc003c39600, {0x1944aa1c, 0xe}, {0xc0011a66e0?, 0x1, 0xc00abb58ad?})
	github.com/hashicorp/terraform-provider-aws@v0.0.0-00010101000000-000000000000/internal/service/elbv2/listener.go:981 +0x2c5
github.com/hashicorp/terraform-provider-aws/internal/service/elbv2.resourceListenerRead({0x1c4c0ad8, 0xc007773b60}, 0xc003c39600, {0x193bb340?, 0xc00411d6c0?})
	github.com/hashicorp/terraform-provider-aws@v0.0.0-00010101000000-000000000000/internal/service/elbv2/listener.go:537 +0x5db
github.com/hashicorp/terraform-provider-aws/internal/service/elbv2.resourceListenerCreate({0x1c4c0ad8, 0xc007773b60}, 0xc003c39600, {0x193bb340, 0xc00411d6c0})
	github.com/hashicorp/terraform-provider-aws@v0.0.0-00010101000000-000000000000/internal/service/elbv2/listener.go:508 +0x11f3
github.com/hashicorp/terraform-provider-aws/internal/provider.New.(*wrappedResource).Create.interceptedHandler[...].func8(0xc003c39600?, {0x193bb340?, 0xc00411d6c0})
	github.com/hashicorp/terraform-provider-aws@v0.0.0-00010101000000-000000000000/internal/provider/intercept.go:113 +0x283
github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema.(*Resource).create(0x1c4c0b80?, {0x1c4c0b80?, 0xc00380b650?}, 0xd?, {0x193bb340?, 0xc00411d6c0?})
	github.com/hashicorp/terraform-plugin-sdk/v2@v2.34.0/helper/schema/resource.go:801 +0x7a
github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema.(*Resource).Apply(0xc00207e460, {0x1c4c0b80, 0xc00380b650}, 0x0, 0xc000311900, {0x193bb340, 0xc00411d6c0})
	github.com/hashicorp/terraform-plugin-sdk/v2@v2.34.0/helper/schema/resource.go:937 +0xa89
github.com/crossplane/upjet/pkg/controller.(*terraformPluginSDKExternal).Create(0xc0045c0c40, {0x1c4c0b80, 0xc00380b650}, {0x1c5f4a60, 0xc002d82f08})
	github.com/crossplane/upjet@v1.4.1-0.20240612123927-37c7f4e91d57/pkg/controller/external_tfpluginsdk.go:592 +0xdd
github.com/crossplane/upjet/pkg/controller.(*terraformPluginSDKAsyncExternal).Create.func1()
	github.com/crossplane/upjet@v1.4.1-0.20240612123927-37c7f4e91d57/pkg/controller/external_async_tfpluginsdk.go:149 +0x145
created by github.com/crossplane/upjet/pkg/controller.(*terraformPluginSDKAsyncExternal).Create in goroutine 3779
	github.com/crossplane/upjet@v1.4.1-0.20240612123927-37c7f4e91d57/pkg/controller/external_async_tfpluginsdk.go:145 +0x14c

Once it panics, I can't actually describe the resource because the webhook isn't running anymore. The listener does get created on the AWS side though, so I think this isn't a bug on terraform but on whatever is processing the response from terraform - maybe not understanding that a field is nullable if the action is a forward action?
Note that the first example on the docs here is also broken - if you omit the protocol, crossplane won't apply the resource - but then adding the protocol (as shown in the last example) fails with the aforementioned panic.

This issue seems related - I wonder if this maybe has to do with block handling somehow?

Based on the documentation, I tried changing the defaultAction to this and don't get an error but it also doesn't apply:
apiVersion: elbv2.aws.upbound.io/v1beta2
kind: LBListener
metadata:
  labels:
    environment: dev
    name: dev-us-east-1-private-consul-nlb-tcp-8500
    region: us-east-1
    subnet-type: private
    vpc-name: dev-us-east-1
  name: dev-us-east-1-private-consul-nlb-tcp-8500
spec:
  forProvider:
    defaultAction:
    - forward:
        stickiness:
          duration: 1
          enabled: false
        targetGroup:
        - arnSelector:
            matchLabels:
              environment: dev
              name: dev-us-east-1-private-consul-nlb-tcp-8500
              region: us-east-1
              subnet-type: private
              vpc-name: dev-us-east-1
          weight: 0
      type: forward
    loadBalancerArnSelector:
      matchLabels:
        environment: dev
        name: dev-us-east-1-private-consul-nlb
        region: us-east-1
        subnet-type: private
        vpc-name: dev-us-east-1
    port: 8500
    protocol: TCP
    region: us-east-1

The error is the following:
    Message:               async create failed: failed to create the resource: [{0 creating ELBv2 Listener (arn:aws:elasticloadbalancing:us-east-1:ACCOUNT_ID:loadbalancer/net/dev-us-east-1-private-consul-nlb/SOME_ID): operation error Elastic Load Balancing v2: CreateListener, https response error StatusCode: 400, RequestID: SOME_REQUEST_ID, api error ValidationError: You cannot specify a target group weight on load balancers of type 'network'  []}]

If anyone knows of a good way to disable sending a weight parameter when the load balancer type is network, I can test that out and see if this workaround works.

Digging into the weight issue, I believe thats an upstream bug due to how it handles the forward property, so likely the workaround of using the forward property isn't viable until that is fixed upstream.

Hello folks, thank you for your interest. I dug into this issue a bit:
The problem seems to be caused by spec.forProvider.defaultAction.forward being null, as you stated. We started to encounter this problem after bumping the terraform provider from 5.31.0 to 5.50.0. Terraform released this change with 5.36.0. Adding a null check here might solve the problem, but when I create the resource with the same configuration with terraform, I don't encounter any problems. And in the tfstate file, the forward field is "forward": [],. I think we are somehow setting the empty list fields to null or nil values. I will meet with the team to determine how we can proceed in resolving this issue and update you.
Also, as @jetersen mentioned, Pulumi has faced the same issue, and they have fixed it in the bridge provider.

I downgraded the provider to v1.3.0 to avoid this error until the issue is resolved.

@ayanevbg why not v1.4.0? The change was introduced in #1315, which came in v1.5.0.

Note: downgrading may not be useful if you are using other providers to interact with the elbv2 provider. In my case, I need the Attachment kind from provider-aws-autoscaling, and that requires elbv2.aws.upbound.io/v1beta2, but the v1.4.0 release of provider-aws-elbv2 only supports elbv2.aws.upbound.io/v1beta1.

Does it apply the resource and hold it's state though?

No, it does not.  As of v1.13.0, while the panic no longer crashes the pod, the resources do not apply. In stead you get a simple little warning in the logs:
crossplane elbv2.aws.upbound.io/v1beta1 LBlistener error create failed: async create failed: recovered from panic: value is null

I'm assuming the null value is from the "forward" variable as mentioned.

We are also experiencing this issue with v1.13.1. In our case, the pod no longer goes into a CrashLoopBackOff state. However, we observe that while the load balancer listener is created, it fails to reconcile properly.
Status:
  At Provider:
  Conditions:
    Last Transition Time:  2024-09-19T06:14:28Z
    Reason:                Creating
    Status:                False
    Type:                  Ready
    Last Transition Time:  2024-09-19T06:14:28Z
    Message:               create failed: async create failed: recovered from panic: value is null
    Reason:                ReconcileError
    Status:                False
    Type:                  Synced
    Last Transition Time:  2024-09-19T06:14:28Z
    Message:               async create failed: recovered from panic: value is null
    Reason:                AsyncCreateFailure
    Status:                False
    Type:                  LastAsyncOperation
Events:
  Type     Reason                        Age                 From                                                   Message
  ----     ------                        ----                ----                                                   -------
  Normal   CreatedExternalResource       12m                 managed/elbv2.aws.upbound.io/v1beta1, kind=lblistener  Successfully requested creation of external resource
  Normal   PendingExternalResource       12m (x5 over 12m)   managed/elbv2.aws.upbound.io/v1beta1, kind=lblistener  Waiting for external resource existence to be confirmed
  Warning  CannotCreateExternalResource  30s (x13 over 12m)  managed/elbv2.aws.upbound.io/v1beta1, kind=lblistener  async create failed: recovered from panic: value is null

Did someone tried to specify the targetGroupArn via: https://marketplace.upbound.io/providers/upbound/provider-aws-elbv2/v1.14.0/resources/elbv2.aws.upbound.io/LBListener/v1beta1#doc:spec-forProvider-defaultAction-forward-targetGroup
https://marketplace.upbound.io/providers/upbound/provider-aws-elbv2/v1.14.0/resources/elbv2.aws.upbound.io/LBListener/v1beta1#doc:spec-forProvider-defaultAction-forward-targetGroup-arn
Instead of
https://marketplace.upbound.io/providers/upbound/provider-aws-elbv2/v1.14.0/resources/elbv2.aws.upbound.io/LBListener/v1beta1#doc:spec-forProvider-defaultAction-targetGroupArn

Yes that also doesn't work, it throws an error saying invalid value,
Spec:
  Deletion Policy:  Delete
  For Provider:
    Default Action:
      Forward:
        Target Group:
          Arn Ref:
            Name:  lb-target-group
    Load Balancer Arn Ref:
      Name:    control-plane-lb
    Port:      6443
    Protocol:  TCP
    Region:    us-west-2
    Tags:
      Crossplane - Kind:            lblistener.elbv2.aws.upbound.io
      Crossplane - Name:            control-plane-lb-listener
      Crossplane - Providerconfig:  dev
  Init Provider:
  Management Policies:
    *
  Provider Config Ref:
    Name:  dev
Status:
  At Provider:
  Conditions:
    Last Transition Time:  2024-10-03T23:53:31Z
    Message:               cannot patch the managed resource via server-side apply: LBListener.elbv2.aws.upbound.io "control-plane-lb-listener" is invalid: [spec.forProvider.defaultAction[0].type: Invalid value: "null": spec.forProvider.defaultAction[0].type in body must be of type string: "null", <nil>: Invalid value: "null": some validation rules were not checked because the object was invalid; correct the existing errors to complete validation]
    Reason:                ReconcileError
    Status:                False
    Type:                  Synced
Events:
  Type     Reason                           Age               From                                                   Message
  ----     ------                           ----              ----                                                   -------
  Warning  CannotResolveResourceReferences  5s (x6 over 34s)  managed/elbv2.aws.upbound.io/v1beta1, kind=lblistener  cannot patch the managed resource via server-side apply: LBListener.elbv2.aws.upbound.io "control-plane-lb-listener" is invalid: [spec.forProvider.defaultAction[0].type: Invalid value: "null": spec.forProvider.defaultAction[0].type in body must be of type string: "null", <nil>: Invalid value: "null": some validation rules were not checked because the object was invalid; correct the existing errors to complete validation]

The invalid value error suggests to add type key in the first element, so I did try that
Spec:
  Deletion Policy:  Delete
  For Provider:
    Default Action:
      Forward:
        Target Group:
          Arn:  arn:aws:elasticloadbalancing:us-west-2:xxx:targetgroup/lb-target-group/xxx
          Arn Ref:
            Name:  lb-target-group
      Type:        forward

managed/elbv2.aws.upbound.io/v1beta1, kind=lblistener  async create failed: failed to create the resource: [{0 creating ELBv2 Listener (arn:aws:elasticloadbalancing:us-west-2:xxx:loadbalancer/net/control-plane-lb/xxx): operation error Elastic Load Balancing v2: CreateListener, https response error StatusCode: 400, RequestID: 9073c8f5-21ff-4d14-afd2-25108550ed13, api error ValidationError: You cannot specify a target group weight on load balancers of type 'network'  []}]

The most recent merge looks to have resulted in 1.15 ... has anyone tested that yet?

This issue is under active development. There were changes upstream in Terraform that is causing this behavior and we've identified the root cause. We'll likely have a fix ready for this in next week's release.

1.16 has now been released and this issue closed.  Anyone else test this yet?  I guess Ill do it ...


Canceled operation causes log message with HTTP 500 and stack dump

tl;dr
An operation (in this case, a zed delete that's canceled mid-way through) generates a log message that users may interpret as more severe than it actually is.
Details
Repro is with Zed commit 59b72d8.
This issue became apparent when helping the community zync user with what led to opening #4934. We'd just advised them of the workaround described there that snapshot files could safely be deleted by hand. However, given they were working in a production environment, they took an understandably a conservative approach of closely watching the zed serve log to confirm that things looked healthy, and that's when they spotted something unrelated that made them pause and ask us for guidance. In their own words:

I started my file cleanup but I found errors on Zed Serve v1.11 . this error is repeated frequently and it is before I started my clean up.
2023-12-14T14:33:30.786393327-05:00 {"level":"warn","ts":1702582410.7858477,"logger":"core","msg":"Error","request_id":"2ZXxk5BJMRFXl3e4ZX5XJ8dtaXa","status":500,"error":"context canceled","stacktrace":"[github.com/brimdata/zed/service.(*ResponseWriter).Error](http://github.com/brimdata/zed/service.(*ResponseWriter).Error)\n\t/go/pkg/mod/github.com/brimdata/zed@v1.11.1/service/request.go:261\[ngithub.com/brimdata/zed/service.handleDelete](http://ngithub.com/brimdata/zed/service.handleDelete)\n\t/go/pkg/mod/github.com/brimdata/zed@v1.11.1/service/handlers.go:555\[ngithub.com/brimdata/zed/service.(*Core).authhandle.(*Core).handler.func2](http://ngithub.com/brimdata/zed/service.(*Core).authhandle.(*Core).handler.func2)\n\t/go/pkg/mod/github.com/brimdata/zed@v1.11.1/service/core.go:194\nnet/http.HandlerFunc.ServeHTTP\n\t/usr/local/go/src/net/http/server.go:2136\[ngithub.com/rs/cors.(*Cors).Handler-fm.(*Cors).Handler.func1](http://ngithub.com/rs/cors.(*Cors).Handler-fm.(*Cors).Handler.func1)\n\t/go/pkg/mod/github.com/rs/cors@v1.8.0/cors.go:219\nnet/http.HandlerFunc.ServeHTTP\n\t/usr/local/go/src/net/http/server.go:2136\[ngithub.com/brimdata/zed/service.NewCore.panicCatchMiddleware.func6.1](http://ngithub.com/brimdata/zed/service.NewCore.panicCatchMiddleware.func6.1)\n\t/go/pkg/mod/github.com/brimdata/zed@v1.11.1/service/middleware.go:92\nnet/http.HandlerFunc.ServeHTTP\n\t/usr/local/go/src/net/http/server.go:2136\[ngithub.com/brimdata/zed/service.NewCore.accessLogMiddleware.func5.1](http://ngithub.com/brimdata/zed/service.NewCore.accessLogMiddleware.func5.1)\n\t/go/pkg/mod/github.com/brimdata/zed@v1.11.1/service/middleware.go:72\nnet/http.HandlerFunc.ServeHTTP\n\t/usr/local/go/src/net/http/server.go:2136\[ngithub.com/brimdata/zed/service.NewCore.requestIDMiddleware.func4.1](http://ngithub.com/brimdata/zed/service.NewCore.requestIDMiddleware.func4.1)\n\t/go/pkg/mod/github.com/brimdata/zed@v1.11.1/service/middleware.go:28\nnet/http.HandlerFunc.ServeHTTP\n\t/usr/local/go/src/net/http/server.go:2136\[ngithub.com/gorilla/mux.(*Router).ServeHTTP](http://ngithub.com/gorilla/mux.(*Router).ServeHTTP)\n\t/go/pkg/mod/github.com/gorilla/mux@v1.7.5-0.20200711200521-98cb6bf42e08/mux.go:210\[ngithub.com/brimdata/zed/service.(*Core).ServeHTTP](http://ngithub.com/brimdata/zed/service.(*Core).ServeHTTP)\n\t/go/pkg/mod/github.com/brimdata/zed@v1.11.1/service/core.go:240\nnet/http.serverHandler.ServeHTTP\n\t/usr/local/go/src/net/http/server.go:2938\nnet/http.(*conn).serve\n\t/usr/local/go/src/net/http/server.go:2009"}

As the ones that know the code, we're able to look at this and identify it as benign: It's an indication of a canceled HTTP request that was issued through the Zed lake API. Picking apart the stack trace we see the reference to handleDelete, so that indicates it's related to a call to the /delete endpoint. However, it's probably not reasonable to ask users to piece this together on their own. Instead, the fact it's an HTTP 500 reported as an Error at warn level with a stack trace makes it look potentially concerning. It's therefore unsurprising that a conservative/production user might stop at this point and ask for our guidance before proceeding, which slows them down operationally.
I don't know the feasibility of being able to catch this specific case of a benign cancel of an operation in progress, but if possible what comes to mind instead would be:

A log message at less severe level (info?)
Flagged with a msg other than Error
Perhaps without the stack trace

Repro
To repro the what the user saw, I start a zed serve and then use the record-poster tool to create 10k commits. I then initiate a zed delete and hit Control-C right after it starts.
$ ./record-poster.py --exitafter 10000
Posting: {"ts": "2023-12-15T20:00:20.210423Z", "message": "twinner"}
Posting: {"ts": "2023-12-15T20:00:20.215971Z", "message": "irresponsible erythropoietic palaeodendrologist corruptible isochromatic oleostearin overword"}

$ zed -version
Version: v1.11.1-27-g59b72d88

$ zed delete -where "ts != null"
^CPost "http://localhost:9867/pool/2ZaqDnpZYArdlkXe9e5Z2J1oWCd/branch/main/delete": interrupted

The final two log messages generated by zed serve show the HTTP 500 followed by the Request completed message for the same request_id.
$ tail -2 zed.out
{"level":"warn","ts":1702670554.204098,"logger":"core","msg":"Error","request_id":"2ZaqUDme4vwLQp4bOvK6EFUcg1i","status":500,"error":"context canceled","stacktrace":"github.com/brimdata/zed/service.(*ResponseWriter).Error\n\t/Users/phil/work/zed/service/request.go:261\ngithub.com/brimdata/zed/service.handleDelete\n\t/Users/phil/work/zed/service/handlers.go:555\ngithub.com/brimdata/zed/service.(*Core).authhandle.(*Core).handler.func2\n\t/Users/phil/work/zed/service/core.go:194\nnet/http.HandlerFunc.ServeHTTP\n\t/usr/local/opt/go/libexec/src/net/http/server.go:2136\ngithub.com/rs/cors.(*Cors).Handler-fm.(*Cors).Handler.func1\n\t/Users/phil/.go/pkg/mod/github.com/rs/cors@v1.8.0/cors.go:219\nnet/http.HandlerFunc.ServeHTTP\n\t/usr/local/opt/go/libexec/src/net/http/server.go:2136\ngithub.com/brimdata/zed/service.NewCore.panicCatchMiddleware.func6.1\n\t/Users/phil/work/zed/service/middleware.go:92\nnet/http.HandlerFunc.ServeHTTP\n\t/usr/local/opt/go/libexec/src/net/http/server.go:2136\ngithub.com/brimdata/zed/service.NewCore.accessLogMiddleware.func5.1\n\t/Users/phil/work/zed/service/middleware.go:72\nnet/http.HandlerFunc.ServeHTTP\n\t/usr/local/opt/go/libexec/src/net/http/server.go:2136\ngithub.com/brimdata/zed/service.NewCore.requestIDMiddleware.func4.1\n\t/Users/phil/work/zed/service/middleware.go:28\nnet/http.HandlerFunc.ServeHTTP\n\t/usr/local/opt/go/libexec/src/net/http/server.go:2136\ngithub.com/gorilla/mux.(*Router).ServeHTTP\n\t/Users/phil/.go/pkg/mod/github.com/gorilla/mux@v1.7.5-0.20200711200521-98cb6bf42e08/mux.go:210\ngithub.com/brimdata/zed/service.(*Core).ServeHTTP\n\t/Users/phil/work/zed/service/core.go:240\nnet/http.serverHandler.ServeHTTP\n\t/usr/local/opt/go/libexec/src/net/http/server.go:2938\nnet/http.(*conn).serve\n\t/usr/local/opt/go/libexec/src/net/http/server.go:2009"}
{"level":"info","ts":1702670554.204285,"logger":"http.access","msg":"Request completed","request_id":"2ZaqUDme4vwLQp4bOvK6EFUcg1i","host":"localhost:9867","method":"POST","proto":"HTTP/1.1","remote_addr":"[::1]:50385","request_content_length":-1,"url":"/pool/2ZaqDnpZYArdlkXe9e5Z2J1oWCd/branch/main/delete","elapsed":2.771991085,"response_content_length":65,"status_code":500}

Verified in Zed commit 4c7de04.
Repeating the repro step above:
$ zed -version
Version: v1.11.1-30-g4c7de042

$ zed delete -where "ts != null"
^CPost "http://localhost:9867/pool/2ZmtNDsfgsJyKRqubxhQzxOtk3V/branch/main/delete": interrupted

The "context canceled" message generated in the zed serve log (the first of two below) is now at info level, is no longer described as an "error", and doesn't include a stack trace.
{"level":"info","ts":1703039146.638428,"logger":"core","msg":"Request context canceled","request_id":"2ZmtaLeDfB1qwrm8NXmDCDdsLw0"}
{"level":"info","ts":1703039146.6384661,"logger":"http.access","msg":"Request completed","request_id":"2ZmtaLeDfB1qwrm8NXmDCDdsLw0","host":"localhost:9867","method":"POST","proto":"HTTP/1.1","remote_addr":"[::1]:55952","request_content_length":-1,"url":"/pool/2ZmtNDsfgsJyKRqubxhQzxOtk3V/branch/main/delete","elapsed":2.494228793,"response_content_length":0,"status_code":200}

Thanks @nwt!


5 entities became unavailable, already tried restarting and updating the addon

affected entities:
Battery Power -- sensor.oig_2106232048_batt_batt_comp_p
Boiler - Current Energy (CBB) -- sensor.oig_2106232048_boiler_current_cbb_w
Boiler - Current Energy (Computed) -- sensor.oig_2106232048_boiler_current_w
Boiler - Today Energy -- sensor.oig_2106232048_boiler_day_w
CBB - Consumption Energy (Computed) -- sensor.oig_2106232048_cbb_consumption_w
Accompanying error logs:
Logger: homeassistant.components.sensor
Source: helpers/entity_platform.py:595
integration: Sensor (documentation, issues)
First occurred: September 27, 2024 at 2:18:06 AM (1 occurrences)
Last logged: September 27, 2024 at 2:18:06 AM
Error adding entity sensor.oig_2106232048_batt_batt_comp_p for domain sensor with platform oig_cloud
Traceback (most recent call last):
  File "/usr/src/homeassistant/homeassistant/helpers/entity_platform.py", line 595, in _async_add_entities
    await coro
  File "/usr/src/homeassistant/homeassistant/helpers/entity_platform.py", line 909, in _async_add_entity
    await entity.add_to_platform_finish()
  File "/usr/src/homeassistant/homeassistant/helpers/entity.py", line 1365, in add_to_platform_finish
    await self.async_added_to_hass()
  File "/config/custom_components/oig_cloud/oig_cloud_sensor.py", line 32, in async_added_to_hass
    self._handle_coordinator_update()
  File "/config/custom_components/oig_cloud/oig_cloud_sensor.py", line 26, in _handle_coordinator_update
    self.async_write_ha_state()
  File "/usr/src/homeassistant/homeassistant/helpers/entity.py", line 1005, in async_write_ha_state
    self._async_write_ha_state()
  File "/usr/src/homeassistant/homeassistant/helpers/entity.py", line 1130, in _async_write_ha_state
    self.__async_calculate_state()
  File "/usr/src/homeassistant/homeassistant/helpers/entity.py", line 1067, in __async_calculate_state
    state = self._stringify_state(available)
            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/src/homeassistant/homeassistant/helpers/entity.py", line 1011, in _stringify_state
    if (state := self.state) is None:
                 ^^^^^^^^^^
  File "/config/custom_components/oig_cloud/oig_cloud_computed_sensor.py", line 48, in state
    return float(pv_data["batt"]["bat_i"] * pv_data["batt"]["bat_v"] * -1)
                 ~~~~~~~~~~~~~~~^^^^^^^^^
KeyError: 'bat_i'

Logger: homeassistant
Source: custom_components/oig_cloud/oig_cloud_computed_sensor.py:48
integration: OIG Cloud (Čez Battery Box) (documentation, issues)
First occurred: September 27, 2024 at 2:19:06 AM (5031 occurrences)
Last logged: 2:31:48 PM
Error doing job: Task exception was never retrieved (None)
Traceback (most recent call last):
  File "/usr/src/homeassistant/homeassistant/helpers/update_coordinator.py", line 258, in _handle_refresh_interval
    await self._async_refresh(log_failures=True, scheduled=True)
  File "/usr/src/homeassistant/homeassistant/helpers/update_coordinator.py", line 453, in _async_refresh
    self.async_update_listeners()
  File "/usr/src/homeassistant/homeassistant/helpers/update_coordinator.py", line 168, in async_update_listeners
    update_callback()
  File "/config/custom_components/oig_cloud/oig_cloud_sensor.py", line 26, in _handle_coordinator_update
    self.async_write_ha_state()
  File "/usr/src/homeassistant/homeassistant/helpers/entity.py", line 1005, in async_write_ha_state
    self._async_write_ha_state()
  File "/usr/src/homeassistant/homeassistant/helpers/entity.py", line 1130, in _async_write_ha_state
    self.__async_calculate_state()
  File "/usr/src/homeassistant/homeassistant/helpers/entity.py", line 1067, in __async_calculate_state
    state = self._stringify_state(available)
            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/src/homeassistant/homeassistant/helpers/entity.py", line 1011, in _stringify_state
    if (state := self.state) is None:
                 ^^^^^^^^^^
  File "/config/custom_components/oig_cloud/oig_cloud_computed_sensor.py", line 48, in state
    return float(pv_data["batt"]["bat_i"] * pv_data["batt"]["bat_v"] * -1)
                 ~~~~~~~~~~~~~~~^^^^^^^^^
KeyError: 'bat_i'

Partially resolved in next release. Some values were removed by OIG though.

thanks for the good work


Add decrease-key methods

According to the original paper on pairing heaps, page 114, the decrease-key operation is implemented as follows. First, change the priority of the node whose key is to be decreased to have the new priority. If its priority is still greater than its parent (or if it's the root of the tree), you are done. Otherwise, cut the link from that node to its parent, then use the merge operation to combine the original heap with the subtree that was just cut from that tree.


Update upstream chart to v2.1.2

Hopefully the upstream version fixes https://github.com/cvmfs-contrib/cvmfs-csi/issues/70 so even though it's introducing a temporary values change (see https://github.com/cvmfs-contrib/cvmfs-csi/issues/64 and https://github.com/CloudVE/galaxy-cvmfs-csi-helm/pull/20), I believe it's worth it at least to run the tool tests for a while and observe the behavior.
Tested this with the Galaxy Helm chart and the changes worked as expected.

I'll go ahead and merge this and update the tool tests to see how they do over the weekend.


Demo App: custom3d_glows.rs - could not find ShaderVersion in egui_demo_lib

Hi, I am trying to build the demo app on my laptop and downloading all the dependencies using the Cargo.toml defined there. I amended the toml fille so that it downloads the dependencies from crates.io rather than referencing a local folder, by dropping the path parameter.
However, I get an error when compiling:
error[E0433]: failed to resolve: could not find ShaderVersion in egui_glow
--> src\apps\custom3d_glow.rs:94:41
|
94 |         let shader_version = egui_glow::ShaderVersion::get(gl);
|                                         ^^^^^^^^^^^^^ could not find ShaderVersion in egui_glow
The method doesn't appear to be there.. but I was able to compile it in the past using the content of the crates folder from GitHub as a dependency, is there something wrong in the egui_glow version on crates.io?

egui_glow 0.19.x doesn't expose ShaderVersion as public API (it's private API).

If you want to look at the code that is compatible with 0.19.0, you need to look at https://github.com/emilk/egui/blob/0.19.0/crates/egui_demo_app/src/apps/custom3d_glow.rs instead of https://github.com/emilk/egui/blob/master/crates/egui_demo_app/src/apps/custom3d_glow.rs


Add localization for German and Italian

KeyboardKit Pro adds support for German and Italian, but KeyboardKit currently has no localizations for these locales.

Localized content has been added for German and Italian.


🖐2024-08-16T12:00/13:00+09:00 UN Smart Maps Pacific and Strategy Meetup

https://discord.gg/YnvEFbsU?event=1232467613070786631

Sorry, I could not make it to the meetup. 😞


Ignores disabled semantic version check

In the settings of maintenerd I have:
semver:
    enabled: false

But still some PRs get flagged as needing sem ver specification, see niosus/EasyClangComplete#346 for an example.
Thanks so much for such a cool tool!

Hey @niosus!  It looks like the semver selection boxes disappeared from that PR.  Did you make a configuration change, or did it simply remove the selection after you updated the PR?

Hey @divmain
Sorry for late response. The box was never there in the first place, see config file. That is precisely the issue. I decided that I will not be needing the semver check in the PRs to my repo, so I have removed that part from the config. However, the check is still there implicitly and by default the non-showing box is in an unchecked state.

Ah, I misunderstood.  You're saying that the box is disabled, but the check is still enabled.  Thanks for the clarification - that should not be too difficult to fix.

Yep, exactly. Thanks so much for this tool :+1:


not working in ios

The flutter toggle tab is not wroking in iPhone. The Tab bar is displayed as expected, but when clicked the function "selectedLabelIndex" is not called. It is working fine on android though. Please help me find a fix.

The flutter toggle tab is not wroking in iPhone. The Tab bar is displayed as expected, but when clicked the function "selectedLabelIndex" is not called. It is working fine on android though. Please help me find a fix.

Can you provide the video related this issue?
Thanks

Can you post a code snippet @SanchaiAhilan ?
For me the latest version is working. Maybe you are missing on a setState to refresh the ui?

The problem is not with the ToggleTab. The issue was with using multiple scaffolds in stack in iOS


yum update PYCURL ERROR 22 on Docker Testing

Description
I followed the curl ... sh instructions to get the Docker Testing repository setup. I get an error when I do yum update. I am behind a web proxy.
Steps to reproduce the issue:

curl -fsSL https://test.docker.com/ | sh
yum update

Describe the results you received:
> yum update
Loaded plugins: fastestmirror
Setting up Update Process
Loading mirror speeds from cached hostfile
 * base: mirror.scalabledns.com
 * epel: mirror.oss.ou.edu
 * extras: centos.mirrors.wvstateu.edu
 * updates: mirror.oss.ou.edu
https://yum.dockerproject.org/repo/testing/centos/6/repodata/repomd.xml: [Errno 14] PYCURL ERROR 22 - "The requested URL returned error: 403 Forbidden"
Trying other mirror.
To address this issue please refer to the below knowledge base article

https://access.redhat.com/solutions/69319

If above article doesn't help to resolve this issue please open a ticket with Red Hat Support.

Error: Cannot retrieve repository metadata (repomd.xml) for repository: docker-testing-repo. Please verify its path and try again

Additional information you deem important (e.g. issue happens only occasionally):
> cat /etc/yum.repos.d/docker-testing.repo
[docker-testing-repo]
name=Docker testing Repository
baseurl=https://yum.dockerproject.org/repo/testing/centos/6
enabled=1
gpgcheck=1
gpgkey=https://yum.dockerproject.org/gpg

I tried replicing https with http but I got the same result. The Docker Main repository works fine.
cat /etc/yum.repos.d/docker-main.repo
[docker-main-repo]
name=Docker main Repository
baseurl=https://yum.dockerproject.org/repo/main/centos/6
enabled=1
gpgcheck=1
gpgkey=https://yum.dockerproject.org/gpg

Additional environment details (AWS, VirtualBox, physical, etc.):
Phisical machine.
> cat /etc/centos-release
CentOS release 6.8 (Final)
> uname -a
Linux ... 2.6.32-642.el6.x86_64 #1 SMP Tue May 10 17:27:01 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux

this is expected;Docker support for RHEL 6 and CentOS 6 ended 2 years ago; the laters version of docker released for that was docker 1.7.1
please upgrade to a newer version of CentOS, and kernel 3.10 or above
I'll close this issue because this is expected, but feel free to continue the conversation


Fixed importBuffer,  now checking new API result

The Sevdesk API saveVoucher seems to have changed in the last couple of days. It now returns a sub-property called voucher instead of returning the document object at top level.
This little change fixes the current implementation. Tests are green again.

No longer required or wanted by the others of this package.


Without any api key

Can I use this library without keys? Because gpt has a free version, can I use the same?

No, you can run llm with olllama.
Gpt keys should be taken from OpenAI dashboard


feat(di): allow controllers to be scoped to environment

Information

Type
Breaking change

Feature
No

Allow controllers to be scoped to an environment.
import {Get} from "@tsed/schema";
import {Controller} from "@tsed/di";

@Controller({
  path: "local",
  environments: ["development"]
})
export class LocalCtrl {
  @Get()
  index(): string {
    return [];
  }
}

Todos

[X] Tests
[X] Coverage
[X] Example
[X] Documentation

Hello @abenerd
it's a really good idea ! But your option is limited to the controller decorator and it would be great to have it for any kind of provider :). I suggest you to perform the filter implementation on DI level directly.
So to do that:

Edit the Provider model and add the environments property: https://github.com/tsedio/tsed/blob/production/packages/di/src/common/domain/Provider.ts
Edit ProviderOpts and add the environments property: https://github.com/tsedio/tsed/blob/production/packages/di/src/common/interfaces/ProviderOpts.ts
Filter mounted controller: https://github.com/tsedio/tsed/blob/production/packages/di/src/common/utils/resolveControllers.ts#L50

export function resolveControllers(settings: Partial<TsED.Configuration>): TokenRoute[] {
  const providers = lookupProperties.flatMap((property) => getTokens(settings[property]));

   /// get env from settings
  const env = settings.env

  /// filter this list
  return [...resolveRecursively(providers), ...providers].filter((provider) => !!provider.route) as any[];
}

Update createContainer implementation to take a env parameter to filter providers:

https://github.com/tsedio/tsed/blob/79b855d1374c18a86b39653381fe162d7413f3c8/packages/di/src/common/services/InjectorService.ts#L314C1-L314C41
https://github.com/tsedio/tsed/blob/79b855d1374c18a86b39653381fe162d7413f3c8/packages/di/src/node/services/DITest.ts#L54

Implementation: https://github.com/tsedio/tsed/blob/production/packages/di/src/common/utils/createContainer.ts#L5
export function createContainer(rootModule?: Type<any>) {
 // GlobalProviders.entries() => returns Provider
  const container = new Container(GlobalProviders.entries());

  if (rootModule) { // can be removed because there is no usage of rootModule signature in the code base (I check on tsed/cli also
    container.delete(rootModule);
  }

  return container;
}

Suggested:
import {Env} from "@tsed/core"
export function createContainer(env?: Env) { //or settings: DIConfiguration ?
  /// change the code implementation to
}

To cover all this, we can do a test as follows:
@Controller({path: "/", environments: [Env.DEV]})
class MyController {
}

describe('Test env', () => {
   describe('Env = DEV', ()=> {
     beforeEach(() => PlatformTest.create({env: Env.DEV})
     afterEach(() => Platform.reset())

     it('should return the MyController provider', () => {
         expect(PlatformTest.injector.get(MyController)).toBeInstanceof(MyController)
     })
   })

    describe('Env = PROD', ()=> {
       beforeEach(() => PlatformTest.create({env: Env.PROD})
       afterEach(() => Platform.reset())

       it('should return the MyController provider', () => {
          expect(PlatformTest.injector.get(MyController)).not.toBeDefined()
      })
    })
})

See you :)

You're right that would be even better!
In your snippets you're using the Env Enum, I would actually like to avoid that and use a simple string to give people more control over what their environments are called, names like staging, and super-cute-cats would not be possible with that. @Romakita

Yes you can use a simple string type instead of enum ;)


[New Feature] Punto: Layout switcher

Description
Changes the layout of selected text to the opposite one and additionally changes the keyboard layout to a target one
Supports switch between ABC-Russian layouts
Screencast

Checklist

[x] I read the extension guidelines
[x] I read the documentation about publishing
[x] I ran npm run build and tested this distribution build in Raycast
[x] I checked that files in the assets folder are used by the extension itself
[x] I checked that assets used by the README are placed outside of the metadata folder

Hi @pernielsentikaer! Thank you for the review.
There is nothing new and unknown in this binary. I just took the one which is already reviewed and accepted within another extension
https://github.com/raycast/extensions/tree/main/extensions/keyboard-layout-switcher/assets


fix: memory leak when frequent rebuild in watch mode

Codecov Report

Merging #2365 into dev will decrease coverage by 1.6%.
The diff coverage is 100%.

@@           Coverage Diff            @@
##            dev    #2365      +/-   ##
========================================
- Coverage   100%   98.39%   -1.61%
========================================
  Files        15       15
  Lines       987      996       +9
========================================
- Hits        987      980       -7
- Misses        0       16      +16

Impacted Files
Coverage Δ

lib/builder/webpack/base.config.js
100% <ø> (ø)
:arrow_up:

lib/builder/webpack/server.config.js
100% <ø> (ø)
:arrow_up:

lib/common/utils.js
100% <100%> (ø)
:arrow_up:

lib/builder/builder.js
100% <100%> (ø)
:arrow_up:

lib/core/renderer.js
93.3% <0%> (-6.7%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b9cd1b...eeb7dfe. Read the comment docs.


[snack-sdk][website] track events by uuid

Why
We'd like to anonymize events by removing mentions of account name or username to hit GDPR specs. This converts snack tracking id to uuid.
How
needs to be landed after this PR for www to have /snack/save return uuid.
Grabbed the UUID from the saved snack response and populated the analytics id with it.
Test Plan
Ran some test events locally to confirm the id had updated.

Ok so, just to confirm: uuid will be added, next to the current id. So people working with Snack (through SDK or as partners) won't need to move over to uuid, right? Or does the backend PR also have changes to only allow uuid?

Ok so, just to confirm: uuid will be added, next to the current id. So people working with Snack (through SDK or as partners) won't need to move over to uuid, right? Or does the backend PR also have changes to only allow uuid?

the backend pr adds the new uuid field, so this pr will only function after it has landed. otherwise everything should work as it always has (i didn't remove any functionality)

@byCedric looking at the runtime code - seems there is some logging direct to amplitude I'll handle in a later PR. It doesn't use snack full name / id so it is a separate issue from what this PR is addressing.

could not figure out how to get typedoc to work as it used to. going to leave that for another PR. just added the docs updates by hand for now


Add note to define communication channel to report security issues [skip ci]

Signed-off-by: Rodny Molina<EMAIL_ADDRESS>

Thanks, had missed that one. Done.


add React 17 to peerDependencies

This should fix issue 79

Thank you, I will release this soon.

4.0.5


feat: remove examples examples

This has never worked so let's remove it.

Codecov Report

Merging #450 (d29c55b) into master (ac0938e) will decrease coverage by 0.04%.
Report is 6 commits behind head on master.
The diff coverage is n/a.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
@@            Coverage Diff             @@
##           master     #450      +/-   ##
==========================================
- Coverage   81.27%   81.23%   -0.04%
==========================================
  Files          39       39
  Lines         865      874       +9
  Branches      149      153       +4
==========================================
+ Hits          703      710       +7
- Misses        162      164       +2

see 2 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Unused PROJECTROLES_ADMIN_OWNER env var set for environments

This was deprecated in SODAR Core v0.5.0 and removed completely in v0.5.1. Should use PROJECTROLES_DEFAULT_ADMIN instead.

Removed.


Port user tests from test_models [OSF-7574]

Purpose
Port part of test_models
Changes

Port user tests from test_models
Fix bugs
Add _is_loaded for MODM compatibility

Side effects
None expected
Ticket
OSF-7574

Personal TCI build passed, merging


??= fails to promote variable whose type is a nullable type parameter

The following code has a compile-time error at (2) ("A value of type 'T?' can't be returned from a function with return type 'T' because 'T?' is nullable and 'T' isn't."):
class C<T> {
  T f(T? t, T u) {
    t ??= u; // (1)
    return t; // (2)
  }
}

main() {}

It seems like the null-aware assignment at (1) should promote the type of t from T? to T, but apparently this isn't happening.

The promotion of t to NonNull(T?) = NonNull(T) should work.
The most reasonable explanation if it doesn't make t non-nullable would be that the bound of T is dynamic, because NonNull(dynamic) is dynamic again, so the type of t goes from T (with bound dynamic) to T & dynamic.
But in null-safe code, the implicit bound of an unbounded type variable should be Object?.

Generics
The default bound of generic type parameters is treated as Object?.

The words "treated as" are weasel words. Be, or be not.
The bound is Object?.
If this is the explanation, we have a bug around default bounds.

The promotion of t to NonNull(T?) = NonNull(T) should work.
So (I decided after checking that it wasn't my first guess) it's probably about unifying T and T & Object. The promotion chain of t is (T?, T & Object), so it cannot be demoted to T. When assigning T to it, it demotes all the way back to T?.

I dug into the implementation and confirmed that this is indeed what's happening.
I think we should consider, in future versions of Dart, extending the notion of "type of interest" so that for a variable of type T?, both T and T & Object will automatically be considered types of interest. That would have allowed t ??= u to automatically promote t from T? to T.
Since this would require a language change (which theoretically could break existing code), I'll move this issue to the language repo for further discussion.


deployment template exposes TCP instead of UDP

deployment template exposes TCP container ports instead of UDP.
        ports:
        - containerPort: 2456
          name: game1
        - containerPort: 2457
          name: game2
        - containerPort: 2458
          name: game3

Should be
        ports:
        - containerPort: 2456
          protocol: UDP
          name: game1
        - containerPort: 2457
          protocol: UDP
          name: game2
        - containerPort: 2458
          protocol: UDP
          name: game3

@darkcloud784 Thanks for pointing this out; however, if you look at the service we are exposing UDP there:
apiVersion: v1
kind: Service
metadata:
  name: valheim-server
spec:
  ports:
  - name: game1
    port: 2456
    targetPort: 2456
    protocol: UDP
  - name: game2
    port: 2457
    targetPort: 2457
    protocol: UDP
  - name: game3
    port: 2458
    targetPort: 2458
    protocol: UDP
  type: {{ .Values.networking.serviceType }}
  selector:
    app: valheim-server

Is there any drawback to not specifying it in the deployment?
Feel free to PR the change if you've tested it out and it works, I'm in favour of being more verbose.


Proposal for proper top type

Right now there are three interesting types for unknown values:
never can be assigned to anything, but nothing can be assigned to it
any can be assigned to anything and anything can be assigned to it
unknown can't be assigned to anything, but everything can be assigned to it
In type theory terms, never is a bottom, unknown is a top and any is something you don't usually see, but is really handy for a language like TS.
Here are the properties for never and any, aside from the abovementioned ones:
(A ranges over all types, including null and undefined, but excluding never, any, {} and unknown itself)
A | never = A
A & never = never
never extends A ? true : false = true
A | any = any
A & any = any
any extends A ? true : false = true | false
Now, I've been using type unknown = {} | null | undefined as my top, like most people. It works mostly fine for assignment, but it fails when it comes to unions, intersections and conditionals. For a proper top type, I need the following properties:
A | unknown = unknown
A & unknown = A
unknown extends A ? true : false = false
Can we get a type in the language called unknown that fits these properties? Another name that might work would be all, but I think that's confusing, as the properties it has would confuse people (it's not immediately clear why A & all = A in that case.
It's become clear to me as of late, I shouldn't use any in my code at all, except when I'm absolutely sure I want to turn off type checking. The problem is, a lot of the cases where I use any, it's because I need a top type. Especially intersections are hard to deal with, without a top type.

Difference between this at #10715 ?

I'll have a read through, cursory scanning seems to indicate it's a similar concept, but not quite the same. My unknown is exactly the same as {}, but with the following properties:

isn't separate from defined and null, even under strict null rules
properly erases under intersection
properly absorbs under union

Here's an example of why {} doesn't behave correctly under these rules either:
type Test<T> = T extends infer U
    ? U extends number ? true : false
    : never;

type ThisShouldBeFalse = Test<number | {}>;

I've run into this peculiarity more than once and it takes quite a bit of digging to figure out the distributive properties of conditionals interact with a union of {} somewhere. Moreover, if we have this proper top type, we could also use it when infer fails. Currently it returns {}, which is how these weird unions tend to happen in the first place.

Okay, after reading through the other proposal, it seems like it's a case of and-and. The other proposal assumes something top-like exists and then specifies how it acts under flow-checking. In other words, this proposal makes the other one possible.

In your examples does A range over all types? I'm not sure I follow the property:

unknown extends A ? true : false = false

what if A = unknown? I would expect that to return true.

@jack-williams
A ranges over all types, including null and undefined, but excluding never, any, {} and unknown itself.
For the excluded cases and how they interact with each other, it's not always clear. In some cases it is, but I refer you to things like any extends never ? true : false; (try guessing what the result of that one is!).
The specific case you mention is simple, because it has to match what {} does. It's true like you suspected.

For the property unknown extends A ? true : false = false, to what extent are your current issues caused by conditional type distribution?

To a very small extent. I'm currently using type unknown = {} | null | undefined, which just plain doesn't act correctly under either union, intersection or conditional, even without type distribution. When it comes to just using type unknown = {}, obviously the first issue is that it excludes null and undefined, which causes a huge mess all over the place. I've been trying to fix one such case today, where I've just spent 5 hours fiddling with extremely arcane errors, because I have to manually figure out at each call site whether to include or exclude null | undefined in my mapped types, etc.
Excluding the null issue, {} will act fine, except under type distribution. The real issue is the null/undefined cases, although I personally think {}'s interaction under union/intersection is broken too and type distribution just causes that issue to pop up in remote areas of your codebase unexpectedly.

It seems like Ryan's comment does indeed include all properties. It's not in the proposal and it's very far down the page, so I didn't see that post yet.

I'll summarize my thoughts, cross-post them to the other issue and close this one. If anyone disagrees, I'll reopen this one.


Sample and How to for new version

Is there possibility to have new sample and how to document as old one not applicable for new version.

The https://github.com/verhas/License3jRepl program is an interactive REPL application around License3j that utilizes all the functionalities. If you look at the code you can see how it creates keys, loads keys, signs licenses, or verifies licenses.


cannot login even with simplest example

Running this
docker run --name cronicle --hostname localhost -p 3012:3012 intelliops/cronicle:latest
Boots up the image but the browser cannot login. We see the "Waiting for master server" for some time and then the frame just looks white.

I've bumped the version to 0.8.29 hoping that this would be related but the behaviour above still happens.

I made my own dockerfile and its working now... @nicholasamorim let me know if u want it

@iwalucas Can you paste here? Even if only to help diagnosing this dockerfile

the entrypoint.sh is the same....

RUN apk add --no-cache git curl wget perl bash perl-pathtools tar \
             procps tini

RUN curl -s https://raw.githubusercontent.com/jhuckaby/Cronicle/master/bin/install.js | node

COPY        entrypoint.sh /entrypoint.sh

EXPOSE     3012

# data volume is also configured in entrypoint.sh
VOLUME     ["/opt/cronicle/data", "/opt/cronicle/logs", "/opt/cronicle/plugins"]

CMD        ["./entrypoint.sh"]```

@iwalucas Yours work, yes.
This seems to be the offending line on this dockerfile:
ENV        CRONICLE_socket_io_transports '["polling", "websocket"]'

If this line is removed, it works. Making it be empty or ["websocket"] only doesn't work neither.

maybe we could do a PR to fix this

I would say so yes. Cronicle's doc states about those two values together: "please only do this if you know exactly what you are doing, and why".
I'd still like to hear @belsander take on the matter, though.

I forked this repo on my account.... I needed to install python3 anyway so will wait for @belsander to let us know what the problem is about so I can have a better setup

Cronicle project actually states they do not accept arrays as envvars:

Almost every configuration property can be overridden using this environment variable syntax.


Powershell 5.1

I have a requirement to use a Powershell module that will only run on Powershell 5.1. I have used Send-MailkitMessage successfully in Powershell 7, but have not been able to get it to work in PS 5.1. I noticed 3.2 said support for Windows Powershell which I think is what I need, but I cannot get it to work.
When I use the regular install-module, I get version 3.1, and it gets an error on line 85 of Send-Mailkitmessage.psm1:
$Client.Connect($SMTPServer, $Port, ($UseSecureConnectionIfAvailable.IsPresent ? [MailKit.Security.SecureSocketOptions]::Auto : [MailKit.Security.SecureSocketOptions]::None))
It chokes on the question mark. I tried using the Install-module with the -Allowprerelease option, but it tells me that the option is invalid. Can you tell me how to get this done, or how to fix the problem statement so it will work in version 3.1?

Hi @MihaIvan,
Yes version 3.1 is going to fail for you since it doesn't support Windows PowerShell.
We need to get the prerelease version working.
Here's what I see when I use Windows PowerShell:

Can you imitate the screenshot and upload one of your own if it fails?

PS C:\Users\MikeL> $PSVersionTable
Name                           Value

PSVersion                      5.1.19041.1320
PSEdition                      Desktop
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0...}
BuildVersion                   10.0.19041.1320
CLRVersion                     4.0.30319.42000
WSManStackVersion              3.0
PSRemotingProtocolVersion      2.3
SerializationVersion           <IP_ADDRESS>
PS C:\Users\MikeL> install-module -name "Send-MailKitMessage" -AllowPrerelease
Install-Module : A parameter cannot be found that matches parameter name 'AllowPrerelease'.
At line:1 char:44

install-module -name "Send-MailKitMessage" -AllowPrerelease

                                       ~~~~~~~~~~~~~~~~

CategoryInfo          : InvalidArgument: (:) [Install-Module], ParameterBindingException
FullyQualifiedErrorId : NamedParameterNotFound,Install-Module

PS C:\Users\MikeL>

Hi @MihaIvan,
Like in #28 that isn't a Send-MailKit error message, that's a PowerShell error message.
If you Google "Install-Module : A parameter cannot be found that matches parameter name 'AllowPrerelease'." you will find solutions that relate to updating PowerShell Get, ie Update-Module PowerShellGet -Force.
Try working in that direction and if you have a Send-MailKitMessage problem open another issue.


Implement OTIO to SVG adapter

Closes #519
Squashed version of #649

Codecov Report

Merging #1038 (4664d4a) into master (0682256) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1038      +/-   ##
==========================================
- Coverage   79.30%   79.30%   -0.01%
==========================================
  Files         113      113
  Lines        6098     6102       +4
==========================================
+ Hits         4836     4839       +3
- Misses       1262     1263       +1

Flag
Coverage Δ

unittests
79.30% <ø> (-0.01%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...ybind11/include/pybind11/detail/type_caster_base.h
64.18% <0.00%> (-0.34%)
:arrow_down:

src/deps/pybind11/include/pybind11/attr.h
76.92% <0.00%> (ø)

src/deps/pybind11/include/pybind11/cast.h
85.03% <0.00%> (ø)

src/deps/pybind11/include/pybind11/detail/init.h
100.00% <0.00%> (ø)

src/deps/pybind11/include/pybind11/detail/common.h
66.66% <0.00%> (ø)

src/deps/pybind11/include/pybind11/pybind11.h
77.83% <0.00%> (+0.07%)
:arrow_up:

src/deps/pybind11/include/pybind11/pytypes.h
81.73% <0.00%> (+0.08%)
:arrow_up:

src/deps/pybind11/include/pybind11/detail/class.h
73.40% <0.00%> (+0.08%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0682256...4664d4a. Read the comment docs.


Added Support for additional ARGS

https://issues.redhat.com/browse/SRVKP-5895
Basically, we need to add a way to allow users to add various flags/arguments for skopeo copy command & we have added the support for this using ARGS parameter.

/test osp-114-ocp-416-e2e

/test osp-115-ocp-416-e2e


Bugfix: revised command timeouts

Proposed changes
Changes how Promise delay timeouts are calculated.
Allows the default Promise delay for commands to be user configurable.
Fixes problem described here: https://github.com/twitch-apis/twitch-js/issues/111
Types of changes

[x] Bugfix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)

Checklist

[x] I have read the CONTRIBUTING doc
[x] My PR is named according to CONTRIBUTING doc
[x] Lint and unit tests pass locally with my changes
I have added tests that prove my fix is effective or that my feature works
[x] I have added necessary documentation (if appropriate)
[x] Any dependent changes have been merged and published in downstream modules

Further comments
This is my first attempt at a pull request. Let me know if I'm doing anything wrong.
A default of 600ms really means that the Promise will race for 600ms in addition to the current server latency.
Resolves #111

I'll take a look at v2 too when I get a chance. But I can't seem to figure out what this means:

Yeah, I contacted GitHub support about it.
Until then, you can push an empty commit to your branch to re-trigger the status checks:
$ git commit --allow-empty -m "Trigger status checks"
$ git push

Sweet it worked! 1.2.13-pre.0 is up 🎉

The build works fine. However, I have identified a bug in the way currentLatency is being calculated that is causing it to essentially always be 0. (It's dividing by 1000 when it shouldn't be, so when latency is 1 second, it would report 1 instead of 1000...) I'll do another PR for this and it should be good.


buf_ring details

There should probably be a statement about how a pbuf_ring can't be completely full because then it looks completely empty. The buf_ring advance can't add the entire size of the ring for example.
And when a buf_ring is unregistered, what happens to operations that were inflight for the same buf_ring?

The pbuf rings work just like the SQ/CQ rings - the masking is done when indexing, not when the head/tail is incremented. Which means you can tell the difference between totally full (abs(tail - head) == size) and empty (tail == head).

I think I was looking at it from the kernel's perspective that it wouldn't even have seen the tail move if a ring went from empty to completely full, but if it is rewriting the index or length field, I guess it can tell. Sorry for the noise.


Replace cl_queue_properties_khr with cl_command_queue_properties

test_conformance/api/test_queue_properties.cpp uses a cl_queue_properties_khr value to query CL_DEVICE_QUEUE_PROPERTIES, however this should be a cl_command_queue_properties typed variable.
Fixes issue #1640

Merging as discussed in the October 3rd teleconference.


ext: hal: make microchip HAL a zephyr module

Move Microchip hal to its own git repo:
https://github.com/zephyrproject-rtos/hal_microchip
and use west.
Signed-off-by: Anas Nashif<EMAIL_ADDRESS>

@scottwcpg lets discuss how are going to test it.

We need to resolve https://github.com/zephyrproject-rtos/zephyr/pull/18497.

We need to resolve #18497.

not needed, as this is for a PR targeting 2.1


HTTP TRACE Method still returning request information

What version of UAA are you running?
{"version":"76.5.0"} deployed, but also on the latest develop branch
How are you deploying the UAA?
I am deploying the UAA locally only using gradlew, but it is reproducible in our bosh deployment
What did you do?
This is a followup to #2125 and #2129
When calling any endpoint of the UAA with an HTTP Trace method, I do not get the desired result back from the UAA.
What did you expect to see? What goal are you trying to achieve with the UAA?
I was expecting to get a 405 error and either no content or an 405 error page.
What did you see instead?
I get a 405 response code, but the Body of the response is still returning the complete HTTP request that was send to the UAA - including e.g. all headers that were added  in between.
As there is no need to have this information returned by the UAA and the details could contain information that should not be shown to the caller (e.g. internal IPs or other information that was added for the UAA), the UAA should not return this information to the caller.

@tack-sap agree with you, can you please open a PR ?


Why not add Classes/Files/LOC count as well?

Why not make this a universal tool for counting all ?

This tool operates on Android DEX files, thus is not aware of source code (and thus files or lines). More generally, this is a specialized tool meant to deal with the DEX method count limit, so counting other things doesn't seem like an appropriate extension.


Button add friend does not disappear

When a user sends a friend request, the button is still there.
{if $is_friend_enabled AND $is_logged AND !$is_own_profile}
<button href="{befriend_link}" type="button" class="btn btn-success btn-sm">{lang 'Add Friend'}</button>
{/if}

I need a variable, which when the request for friendship was sent, the button will not be there anymore

Thanks for mentioning it @spike99 :tada:
I've fixed it. Patch: https://github.com/pH7Software/pH7-Social-Dating-CMS/commit/a9023557bbb4860538e2d3bd4c50b74fd499b09f

If user X send friend request to user Y, and user Y does not respond to the request of friendship and enter to user X profile, he have "add friend" if user Y send a request. they will be friends 2 times in friends list

Thanks for mentioning it @spike99 🎉
I've fixed it. Patch: a902355

can it be repaired?

https://github.com/pH7Software/pH7-Social-Dating-CMS/issues/504#issuecomment-481679899


differential privacy of numpy.histogramdd

in mwem.py, np.histogramdd is called from def _histogram_from_data_attributes.
As it uses the original data to create bins, shouldn't the identification of bin edges be randomized too in order to guarantee Differential Privacy?

Thanks for flagging this.  Our intention is for MWEM to only ever receive categorical columns, with the categories provided externally.  The way the code is currently written, it's not actually trying to discretize continuous values; it's just treating all columns as if they are integer-coded categorical and giving each category its own bin.  IOW, the assumption is that the data are categorical, with categories being like (0, 1, 2, ...).  This approach creates risk in at least two ways.  First, if the caller has some external category encoding for integers where not all integers map to categories (e.g. the data dictionary specifies categories [1,2, 4]) the histogram we create will have spurious categories.  Second, if the caller doesn't realize these are meant to be categories, it could result in some leakage and poor utility.
We are intending to fix both of these in the next month by refactoring the way we pass the data to the synthesizers.  You can see the proposal here, please let us know if you have any feedback: https://github.com/opendp/smartnoise-sdk/issues/467
I will keep this issue open until that PR is merged

MWEM now uses a LabelTransformer for all categorical columns by default, so all categorical columns are stored in integer indices starting at zero.  Continuous values are binned externally by the TableTransformer, using privacy budget to infer approximate bounds if bounds are not provided.


[CARBONDATA-2321] Fix for selection of partion column after concurrent load fails randomly

Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:

[ ] Any interfaces changed? No

[ ] Any backward compatibility impacted? No

[ ] Document update required? No

[ ] Testing done
Please provide details on
- Whether new unit test cases have been added or why no new tests are required? No, Test Manually
- How it is tested? Please attach test report.
- Is it a performance related change? Please attach the performance test report.
- Any additional information to help reviewers in testing this change.

[ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

Build Failed with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder/3638/

Build Failed  with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/4861/

Build Success with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder/3639/

SDV Build Success , Please check CI http://<IP_ADDRESS>:8080/job/ApacheSDVTests/4330/

Build Failed with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder/3682/

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/4905/

retest this please

Build Success with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder/3712/

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/4931/

LGTM


add the wizard robes from adventure time

it fits the theme of the wizards growing stronger after tons of meditation

Not familiar with the original source and already worried about the massive amount of robes already in the game, but will shelve for now and come back if I decide to make more standalone gear!


Failing test cases for multiple schemas and inheritance

When trying the wsdl2py on a rather complex .NET Soap Service, I stumbled into a few unhandled constructions. Attached a PR containing two failing test cases. I've named the file test_X as unittest2/nose2 cannot autodiscover the tests otherwise.

Thank you very much for your contributions. For nose2 I added a custom ".nose2.cfg" as I really like to keep the '..._test.py' pattern.


MainMenu fails to display alternative languages for linked pages or routes when used with wagtail-modeltranslation

I recently extended wagtail-modeltranslation to cover MainMenuItem and FlatMenuItem so as to allow for multilingual menu items.
This presented a couple of challenges, first the Wagtail admin interface to menu items needs to be extended manually to allow for the additional fields with translations.
However, the bigger problem seems to be that the wagtailmenus code doesn't seem to recognize the additional language(s) for items linking to pages. For example, menu items that don't have a manual title set only show the page title in the default language (even if the page has multiple languages set). As well, the relative_url method in wagtailmenus/models.py doesn't recognize the non-default language routes. Specifically the url variable is never filled in those cases. I've manually set url to self.link_page.get_url_parts()[2] when in the non-default language which is what the existing code does when in the default language:
        try:
            url = self.link_page.relative_url(current_site)
        except AttributeError:
            url = self.link_url

This is a bit of a hack around the actual problem, although I'm not quite sure why relative_url doesn't return the proper value, or why menu_text ignores the alternative languages available. Oddly enough, it seemed to actually work better when the MenuItems weren't registered with modeltranslation.
In the meantime, I'm working around this by manually setting page_titles for each of the menu items that link to Wagtail pages.

Hi @dwasyl. It's always tricky territory when trying to account for combinations of third-party apps that devs may or may not be using. Right now, I would say it's not our responsibility to make these two apps work in combination. We cannot do that for any app that developers choose to use, the changes will likely complicate the code, and plus knows what changes wagtail-modeltranslation might make in future that could break wagtailmenus if we try to account for it? As soon as we say it's compatible, that's something that needs to be maintained, which is something I'm not in a position to promise.
Whether you solve this problem by extending bits of wagtailmenus, or copying bits out of the app and into your project, or create your own wagtail-modeltranslation compatible fork, that's up to you (If you did take the fork option, it would be great if you could share a link here to help others with same problem!), but it's not something intend to account for in this project at this time. Maybe if that app gets added to wagtail core, I'd reconsider (at least then there'll be some guarantees of stability).

Thanks @ababic, I don't disagree with not going to much efforts to integrate third party apps, just the way it is failing struck me as something that shouldn't be happening. I will continue to play with both apps to see if I can't figure out a better quick fix than my patch job.

It sounds to me like there are 3 problems.
The first is the modeladmin models and the CMS side of things, which it sounds like you've sorted.
The second,  is making the menu tags aware of the current/preferred language, so that they know which URLs on text values they have to identify for display.
The third is figuring out which methods you need to be calling on page models / menu item models to be getting the correct URLs and text for menu items. For page URLs, I'm guessing you'll be need to pass the current/preferred language as well as the current site to whatever method gives you those URLs. That likely won't be the 'relative url' method, and you'll likely also need to deal only with 'specific' objects, rather than just 'Page'  objects for every item, which will likely hinder performance. For the page title, I don't really know, other than there's likely to be a method that you need to pass the desired language to, rather than just using the title field.
Sorry I can't really help any further.

Don't worry, you've done more than enough. In theory Django should take care of 1 and 2, which it seems to most of the time.
Regarding 3, you're quite right, except the way modeltranslation was originally designed is that it overrides everything so in theory there are no special functions required. That said I did trace things back a bit further and have discovered that when you access a Site's root page via the Site object it disregards the language as activated in Django, but when you access the page directly it obeys it. i.e.:
If you've activated "fr":
HomePage.objects.all()[2].url_path returns u'/homepage-fr/' (that HomePage object being set as root object for a site)
Whereas:
Site.objects.select_related('root_page').order_by('-root_page__url_path')[0].root_page.url_path returns u'/homepage-default/' (ignoring the activate Django language).
and in the same light:
MainMenuItem.objects.all()[1].link_page.url_path returns u'/homepage-default/' rather than the path that gets delivered by accessing the object directly.
Anyway, this part of it seems not to be a menus problem but something more deeply routed between wagtail and modeltranslation that causes the relative_url and url_path of both wagtailmenus and proper to return the wrong value depending on how it's access. Didn't add to this issue looking for affix, but figured at least documenting the problem might help someone else in the future.

Hi @dwasyl. In your latest post, it looks like you're calling url_path on just vanilla Page objects in the last two examples, but a HomePage object in the first - which is likely why you're seeing different results. You should to use Page's specific property to access the most specific object (in this case a HomePage), then call url_path on that.

Hey - thank you so much for that suggestion, it definitely put me on the right track and now menu/translation/wagtail all play nicely together. Even led to me sorting out a problem with RoutablePageMixins.
The problem I mentioned here was modeltranslation missing the usage of .specific in a few functions.

No worries, I'm glad it helped. Multi-table inheritance trips everybody up
at some point :)
On 26 Aug 2016 07:13, "dwasyl"<EMAIL_ADDRESS>wrote:
Hey - thank you so much for that suggestion, it definitely put me on the
right track and now menu/translation/wagtail all play nicely together. Even
led to me sorting out a problem with RoutablePageMixins.
The problem I mentioned here was modeltranslation missing the usage of
.specific in a few functions.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/rkhleics/wagtailmenus/issues/30#issuecomment-242639061,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AHa1BI4K123HgK1-rjJo0h6wKSJCN3scks5qjoP2gaJpZM4JszqX
.

Truly does, one thing I found, that if you could make the small change to wagtailmenus would help. Line 119 of models.py def menu_text, on the next line adding a specific fixed up the Page's only showing the  original language choice, and it shouldn't have any negative impact anywhere.
            return self.link_text or self.link_page.title becomes
            return self.link_text or self.link_page.specific.title
I'd submit a PR, but since it's 9 characters I figured easier to just pass it by you.

I am happy to have found this "issue". At least now I know someone had a problem similiar to mine. I arrived here after I spent some time (with no success) trying to make FlatMenu.heading translatable using wagtail-modeltranslation.
I could create heading_it and heading_en, but I didn't find a way to show these fields (instead of the original one) in the panel like it happens with other Page models patched by wagtail modeltranslation.
If I'll find a solution I won't miss to post it here.

@pyMan I actually think this might be a modeltranslation problem rather than something else. To get menu items translated I had to patch modeltranslation so that it would recognize models other than Page objects. For me, this was menuitems (from wagtailmenus), and site (from wagtail). Presumably you'll need to add the actual menus to it as well.
Not sure if it helps, it's one of the commits in my fork of modeltranslation.

@dwasyl I initially tried to patch wagtail-modeltranslation like you did just to trigger WagtailTranslator on FlatMenu, but something wasn't working in the right way.
Moreover I don't like this solution because it "breaks" wagtail-modeltranslation. I mean it's more or less a situation like the one described by @ababic who didn't want to tie strictly wagtailmenus and wagtail-modeltranslation.
So this seems a solution to work for me:
translation.py
@register(FlatMenu)
class FlatMenuTR(TranslationOptions):
    fields = ['heading']

# Patch panels to show translated fields instead of the original one
# We need an explicit patch because this model is not a subclass of Page (wagtail-modeltranslation won't see it)
for _field_to_translate in ["heading"]:
    _offset = -1
    for _fieldpanel in FlatMenu.panels[0].children:
        _offset += 1
        if _field_to_translate == _fieldpanel.field_name :
            _new_children = list(FlatMenu.panels[0].children)
            del _new_children[_offset]
            for isocode, description in settings.LANGUAGES[::-1] :
                _new_children.insert(_offset, FieldPanel('%s_%s' % (_field_to_translate, isocode)))
            FlatMenu.panels[0].children = tuple(_new_children)
            break
    else :
        raise Exception, "Field to translate not found: '%s'" % _field_to_translate

The fields heading_it and heading_en are created as expected when registering them for translation. The problem was how to render them on since wagtail-modeltranslation doesn't come to action here: I need to patch FlatMenu.panels by myself showing them and hiding the original one.

Hi @dwasyl. Apologies for not replying to your ask from August:

return self.link_text or self.link_page.title becomes return self.link_text or self.link_page.specific.title

I couldn't make this so, because it would force additional queries/processing for every single menu item linking to a page, and in most cases the specific page isn't needed to get the title. Instead, I've made it so that if you use one of the appropriate use_specific options with the {% main_menu %} or {% flat_menu %} tags, menu_item.link_page actually gets temporarily replaced with the specific page after it's been fetched, and only when needed.


Chrome: unable to sort by drag-and-drop

Setup

Chrome 56.0.2924.87
Redmine 3.3.2

Repeat

Login as admin
Navigate to Administration -> Issue Statuses
Click green verticle bi-directional arrow
Attempt to drag and drop status into new position in the list

This problem exists for other areas where drag-and-drop sorting is used.
Workaround

Use Firefox 51.0.1
Use IE 11

Hmm , this is strange , cos it`s working for me . Chrome 56.0.2924.87

Chrome's Developer Tools shows the follow errors when I navigate to pages with this drag-and-drop sorting functionality. On the Administration page, I first navigated to the Issue Statues page, then to the Trackers page. Below is a screen-capture of the browser's console:

For the Trackers page, the place of the error in the HTML is:
 <script>
//<![CDATA[

  $(function() { $("table.trackers tbody").positionedItems(); });

//]]>

</script>

Firefox shows no errors in its console when I navigate to those same pages.
It's odd that we have the same versions of Chrome but are having different user experiences.

FYI, my environment copied out of the Information page of Redmine is:
Environment:
  Redmine version                3.3.2.stable
  Ruby version                   2.1.9-p490 (2016-03-30) [x86_64-linux-gnu]
  Rails version                  <IP_ADDRESS>
  Environment                    production
  Database adapter               PostgreSQL
SCM:
  Subversion                     1.8.8
  Darcs                          2.8.4
  Mercurial                      2.8.2
  Cvs                            1.12.13
  Bazaar                         2.7.0
  Git                            2.11.0
  Filesystem
Redmine plugins:
  redmine_agile                  1.4.2
  redmine_checklists             3.1.3
  redmine_monitoring_controlling 0.1.1

OK i see . you have issues , but i think this issues is not related to this theme. or any other theme ...

I just tried to do this on my other laptop that is running Chrome 56.0.2924.76 and everything worked as expected. This issue isn't related to your plugin.

This might be caused by a browser plugin, e.g. an ad blocker or something like that.

Just in case anyone encounters this, refreshing the cache on that (Ctrl + F5) solved the issue.


Extension is not responding after installation

I've been trying to get the extension to work like your readme screen share. The only thing that seems to happen is the Hack Language Extension is available but, adding invalid syntax or hovering over function calls are responsive. I also don't see the code coverage percentage in the footer section. I've tried setting the hack.clientPath and no difference. I disabled all extensions besides this and nothing as well.
Im using a mac book pro with Sierra 10.12.5. I've installed hhvm 3.20 via homebrew.
hhvm --version

Any suggestions

Has to do with my local homebrew hhvm setup created a ticket here


Added a paper by David Yermack.

Sorry, this is not in the schema used on the repository and it's missing the JSON extension (which is why the CI did not complain about this before).


Create an ADR for the scaffolding

Created a first draft need some reviews on to make format is clear and concise and in correct order


experts based on Phi 3 model with PEFT library

Hello,
Thank you for your interesting research work.
I have 10 experts trained based on the Phi 3 model (datasets selected based on paper cluttering). I have used the TRL and PEFT libraries for training, ensuring the checkpoint structures are suitable for these libraries.
In training the experts, I used LoRA in 4-bit quantized mode. Additionally, I utilized the o and kqv attention in each layer during training.
I would like to know how I can use your code to execute Arrow for merging these experts for each token in every model layer.
I have some errors in the code.
please explain step by step. I am a beginner in this field.
Thank you, and I would appreciate your response.

@pclucas14 can you help with this issue?
I also have a PR that creates a library compatible with our library out of PEFT adapters, maybe we can merge that and write an example on how to run Arrow using experts trained with TRL and PEFT
Thank you

@AliEdalat would you be able to share with us the name of your PEFT adapters?

Hey @sordonia,
I'm @AliEdalat's teammate, and have implemented the Arrow algorithm for our project using the PEFT library, achieving promising results. To do this, I modified the forward path in the bnb.py file (since we use QLoRA in our workflow) and made adjustments to methods in the peft_model.py file, along with some other PEFT library files.
I thought you might be interested in a dedicated PEFT adapter for the Arrow algorithm, similar to existing ones likePoly and MHR. Let me know if you'd like any help on this!
Thanks!

It'd be great! Do you plan to open a PR into PEFT? I'd be willing to help

It'd be great! Do you plan to open a PR into PEFT? I'd be willing to help

Yes, I'd be glad to contribute!
@sordonia
Which branch should I open a PR on?

Just to clarify my understanding: you are planning to PR your work into the huggingface PEFT library, right? Or into MTTL library?

Just to clarify my understanding: you are planning to PR your work into the huggingface PEFT library, right? Or into MTTL library?

Yes! HuggingFace PEFT library.
I initially asked about the branch because I thought there might already be a feature request for implementing Arrow in PEFT. Should I go ahead and open a feature request for this, or would you prefer to handle it?
(Sorry for any ambiguity!)

Just to clarify my understanding: you are planning to PR your work into the huggingface PEFT library, right? Or into MTTL library?

Yes! HuggingFace PEFT library.
I initially asked about the branch because I thought there might already be a feature request for implementing Arrow in PEFT. Should I go ahead and open a feature request for this, or would you prefer to handle it?
(Sorry for any ambiguity!)

Hi,
Super exciting to hear you are getting nice results! Please go ahead and PR into PEFT. I am happy to help if needed, but you probably have a better intuition on how PEFT works than us :)

Yes please go ahead an open a feature request, we can jump in the PR when needed!

(we merged our own PEFT support in examples/create_arrow_model.py curious if it works with your PEFT experts :)

@sordonia @pclucas14 I'll do it for sure. However, I need to first make sure my code can almost reproduce the result on the zero-shot datasets, like Piqa, as you wrote on the paper.
Furthermore, I think I need to refactor the code, so the Arrow can be added as a Tuner Class in the PEFT library, similar to Polytropon and π-Tuning.

@TheTahaaa how is it going? :)

Hey @sordonia!
I’ve tested my implementation of the Arrow algorithm on the benchmarks from your paper (PIQA, BOOLQ, etc.) using the Phi3 model, and the results were quite promising, confirming that the algorithm works well.
I was just about to start working on the PR—so thanks for the reminder! 😁
Apologies for the delay; we only have access to a single RTX 3090 (24GB), which made testing the algorithm on the benchmark datasets a bit challenging.

Awesome!! I am really looking forward to know more about the setting and no problem at all, I was just curious so I pinged, let me know the progress and how we can help

I'll definitely keep you updated on the progress and share more details about the setting soon.
To make things more transparent and easier to follow, I was thinking we could set up this on Git. That way, you can easily track changes and progress as we go.
Let me know if that works for you, and I’d be happy to set it up!

sure! thanks

Hi @sordonia,
I’ve forked the PEFT repository and added you to the repo. Before we dive in, I think it would be helpful to align on the approach we’ll take to implement this, as there seem to be at least two possible ways to proceed.
What’s the best way to get in touch to discuss this—email or another platform? Let me know what works best for you!