Fix README.md missing paren

Codecov Report

Merging #1089 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #1089      +/-   ##
============================================
- Coverage     81.74%   81.73%   -0.02%
  Complexity     1174     1174
============================================
  Files           184      184
  Lines          5512     5512
  Branches        510      510
============================================
- Hits           4506     4505       -1
  Misses          871      871
- Partials        135      136       +1

Impacted Files
Coverage Δ
Complexity Δ

...census/implcore/trace/export/SpanExporterImpl.java
96.77% <0%> (-1.62%)
7% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b6fb9bb...e202116. Read the comment docs.


Remove use of Oxford commas

@davemachado we don't need to use Oxford commas in any of these descriptions 👍

works for me, thanks! 😄

Boo! What do you have against added clarity in run-in lists?

Consistency 😂


Added esdoc

Added esdoc as proposed in #42  issue.

Saved the libraries in dev dependencies instead.
Added both documentations to CONTRIBUTING.md file since USAGE.md didn't exist.

Let me know if there should be any corrections.
Closes: #42

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Should be ok now.

W00t!

Hello @maxtotterman,Thanks again for the PR! We want to show our appreciation by sending                                              you some swag. Could you please fill out                                              this form so we can send it to you? Thanks!                                             Team SendGrid DX


Omit effects-free conditional constructs from control flow graph

With this PR we optimize control flow graph construction to omit conditional constructs that have no control flow effects.

@typescript-bot test it

@typescript-bot test it

@typescript-bot user test this
@typescript-bot perf test this faster

@jakebailey Any idea why we're seeing the test failure here https://github.com/microsoft/TypeScript/pull/58013#issuecomment-2030786044? I can't reproduce it locally.

I was out yesterday; will take a look at this shortly.

Also, I modified this PR to force hasFlowEffects to always be true, and the error count went back to the one on main, so it's definitely some behavior change in the PR (somehow).

@jakebailey Yeah, sorry, I see what's going on now. What confused me is that we used to issue two errors, and now we only issue one, but the errors have the exact same location. The missing error is an effect of optimizing away part of the control flow graph, causing us to not call getEffectsSignature, the method that resolves signatures in control flow analysis. For a variety of reasons we can't use the regular (and more complex) signature resolution in CFA, and the CFA resolution reports nullable errors slightly differently. Anyway, the error that went away is just a (differently worded) duplicate, so there's no problem here.

Now that we've sorted out the missing error, I think this is ready for a review.


iOS sample project SDBSampleTask not found

commit: f1d61b250c8eed196362c7be09fc5a8949af4cc3

Task.h is also not found in iOS project.
Is Task.h file generated by j2objc or written by native objc code?

I found Task.h in xcode derived data


sfcgal: update patch to build process from upstream

Things done
This updates the patch to build correctly sfcgal_config, which in turn is necessary to build postgis with sfcgal support (in the next PR ;-)).

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

@fqidz this is https://gitlab.com/sfcgal/SFCGAL/-/merge_requests/384, so we need to keep the patch until next release.
I also took the opportunity to add the @NixOS/geospatial team to the list of maintainers if you don't mind :-)

nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review pr 366648

x86_64-linux

:white_check_mark: 1 package built:

sfcgal


Advanced search operator

For example an OR operator for matching multiple conditions, I often want to compare the usage of multiple programs.

interesting, thank you.. will consider supporting that somehow (will see if we can come up with some better experience though)

@egoist but still you can achieve something similar by pinning two or more processes and comparing

@Abdenasser that's right, i didn't know that. but a search keyword would be easier and better for one-off usage

will think about it, but not a priority for now.. thank you @egoist


Setting up Sync Endpoint on Digital Ocean

When I run a file script_to_run.sh from the console of a digital ocean droplet, at the end I get:
'this node is not a swarm manager. Use "docker swarm init" or "docker swarm join" to connect this node to swarm and try again'
After I get that error, when I run "docker swam init", I get:
'Error response from daemon: could not choose an IP address to advertise since this system has multiple addresses on interface eth0 (<IP_ADDRESS> and <IP_ADDRESS>) - specify one with --advertise-addr'
Specifying the public IP address explicitly in the script and running the script again works.

@Goodiec Did this issue prove to be transitory and fix itself? If so, can we close this issue?

Yes, it can be closed.


16 jun21 dendrogram update

Some markers are missing in https://github.com/obophenotype/brain_data_standards_ontologies/blob/dosdp_based_pipeline/src/patterns/data/bds/ensmusg_data.tsv such as ensembl:ENSMUSG00000100851 and ensembl:ENSMUSG00000096972
I will commit missing markers and then merge.

Ah I just checked - must have gotten removed in the time, ill make the changes :)

oh wait, those are NS-forest markers arent they? think its related to issue #93

@shawntanzk  we have a new issue: "Node CS202002013_70 exists both in dendrogram and nomenclature of the taxonomy: CCN202002013"


ldap: Move query_ldap() to zproject/backends.py and add complete coverage.

Followup project to #11789.

Nice, merged, thanks @HarshitOnGitHub!


ion-navbar buttons can overlap ion-title

Ionic version:  (check one with "x")
[ ] 1.x
[x] 2.x
I'm submitting a ...  (check one with "x")
[x] bug report
[ ] feature request
[ ] support request => Please do not submit support requests here, use one of these channels: https://forum.ionicframework.com/ or http://ionicworldwide.herokuapp.com/
Current behavior:
If you have a long `iontitle' , and a (semi-)long button text, it will overlap with the ' ion-title'

Expected behavior:
ion-buttons in ion-navbar should probably have a max width and be truncated/ellipsed, just like ion-title is.
Steps to reproduce:
Repo: https://github.com/biesbjerg/6228-ionic-keyboard-issues
Don't mind the repo name - just reusing it from a previous issue that are now fixed :-)
Related code:
<ion-header>
	<ion-navbar>
		<ion-title>This is a the greatest song in the world... tribute</ion-title>
		<ion-buttons left>
			<button ion-button icon-left>
				<ion-icon name="list"></ion-icon>
				Back
			</button>
		</ion-buttons>
		<ion-buttons right>
			<button ion-button icon-left>
				<ion-icon name="list"></ion-icon>
				Go to Playlist
			</button>
		</ion-buttons>
	</ion-navbar>
</ion-header>

Ionic info: (run ionic info from a terminal/cmd prompt and paste output below):
Cordova CLI: 6.4.0
Ionic Framework Version: 2.0.0-rc.3-201612021933 (also tested 20161206xxxx)
Ionic CLI Version: 2.1.14
Ionic App Lib Version: 2.1.7
Ionic App Scripts Version: 0.0.45
ios-deploy version: 1.9.0
ios-sim version: 5.0.12
OS: macOS Sierra
Node Version: v6.9.1
Xcode version: Xcode 8.1 Build version 8B62

Hello, thanks for opening an issue with u! I am going to close this issue as a duplicate of https://github.com/driftyco/ionic/issues/5036.


Optionally create password stores as git submodules instead of clones

When managing its home directory as a git project it would be great if gopass could optionally create git submodules so that we can easily commit the whole gopass configuration (`~/.config/gopass/config.yml + ~/.password-store*).

I'm not sure if this makes sense given how easy it is to clone a set of existing password stores and managing the config is something that should be done in a user's dotfiles not inside the password-store repository, otherwise you get into a chicken and egg situation.

@espoelstra maybe the configuration file could contain the remote url for each mount so that we could have a command that could recreate the ~/.password-store* directories. The thing is that I could add ~/.config/gopass/config.yml to my dotfiles repo, but I'd still miss the information of the remotes.

Interesting idea, feel free to work on that. I'm not keen on working with git submodules again ;)

Actually if the config file contains the remote url, maybe there is no need for submodules. Gopass could automatically clone the repo if it does not exists.

That sounds reasonable. We can probably do that.

This would be great. This featuer plus #872 would allow to manage the config file in one's dotfile git repo and reconstruct all password stores dynamically without having to run gopass clone.

We'll look into it. #872 might be a little tricky because we assume to work with absolute paths in a lot of places and this might take some effort to untangle.


dmesg -T / --ctime human readable timestamps

A UI option to resolve times from boot (0) in human readable formats & using the current uptime to estimate starting time / date would be well appreciated.
Given the native limitation with dmesg not supporting the paramters: -T, --ctime: Print human-readable timestamps this could be a great workp-around making the tool even more useful.

@aphorise, 8c9aba5

It looks fantastic!

Hey @gSpotx2f thank you! - this now make both default Kernel Log and yours useful.


Allow setting a label on executors/policies

Adding this as an issue so that we can come back to this idea: https://github.com/STEllAR-GROUP/hpx/pull/5267#pullrequestreview-623941366.
It may be preferable to allow setting labels on executors/properties instead of functions like this:
hpx::transform_reduce(hpx::prefer(hpx::execution::par, hpx::label("my transform_reduce")), ...);

I'm not sure what the best order of preference would be for the various annotations (i.e. if function annotations or executor annotations should take preference).

Closed by #5341.


fix for #193

... gemspec sets rails-version to 3.2, it works without the task there.
Also includes bugfix for resource_controller

It can't merge this in, since there is this questionable commit which changes the ressources controller behavior. See https://github.com/magiclabs/alchemy_cms/pull/194#commitcomment-1014008
Could you make a branch out of the 0067ea8 commit and just send this, please?

I cherrypicked the rake routes commit and therefore closing this pull request.
@masche842 please let us talk about your change for the ressources controller. I really doubt that we need this, because it works like expected without your change.


update synonyms and def for MONDO:0020066 'Ehlers-Danlos syndrome'

per @pnrobinson
https://monarchinitiative.org/disease/MONDO:0020066#overview
AKA:  Cutis hyperelastica, elastic skin
=> I do not think these are good AKAs!!
def: An inherited connective tissue disorder characterized by loose and fragile skin and joint hypermobility.
This is also not a great definition.

Bad Synonyms: report source [here DOID, which seems to have gotten them via SNOMED], report proposed action: (e.g. [a] demote EXACT->RELATED; [b] add a DEPRECATED axiom [c] retire the axiom).
In this case I think c is best. Here we change the AP from synonym to excluded_synonym
Def: Also report source [here NCIT]. Let's create a better one and propagate it back to NCIT and ORDO [which currently lacks a def]

made syn 'Cutis hyperelastica, elastic skin' for MONDO:0020066 'Ehlers-Danlos syndrome' an excluded synonym (in PR...)

I think this addresses everything.
@cmungall when you say 'Also report source [here NCIT]' - is there something else I should do, or is suggesting the new def to NCIT what you meant?

Yes, you can see we have an axiom annotation on the def indicating it came from NCIT. If we think the NCIT def can be improved on then we can communicate this back to them so everyone wins


Filter conflicting files

Mod contains two files that conflict with each other. Mod uses an RPM IVA as default but it says in the Readme.txt:

For non-Raster Prop Monitor IVA copy and replace the folders inside "Stock IVA" to the mod location.

So filter out the StockIVA and add a dependency for RPM untill the author has fixed this. @politas already mentioned this to the author on the forums.

Yep, probably should have done this when I added it earlier.


Make the app 100% Redux

We currently use an hybrid between Vanilla Flux and Redux for state management, and we have problems passing a huge number of props through all the children components. I would like we move everything to a more Redux way, especially about the dispatch thing.

[ ] Dispatches, the Redux way?
[x] "real" Presentational and Container Components with connect and mapStateToProps
[x] Initial state in reducers

http://redux.js.org/docs/basics/UsageWithReact.html#presentational-and-container-components
http://redux.js.org/docs/advanced/UsageWithReactRouter.html

I'd add:

[ ] Make store shape map to reducers so we can use combineReducers

poke #370

[ ] calling getState is a hack

So apparently it's not, I've seen some stuff from Dan Abramov where he says it is perfectly fine
https://stackoverflow.com/questions/35667249/accessing-redux-state-in-an-action-creator#35674575

Why player is in state anyway?

I think you are confusing the Player lib and the Player reducer

Could be worthwhile: https://github.com/rematch/rematch

Looks great, I will give it a try!


useSession type not working properly

Describe the bug
The type for the useSession (on the frontend) is not working properly, it display data as never, the code works as expected returning the session and user data.
To Reproduce
Steps to reproduce the behavior:

Setup the auth client on react
Use the useSession in any component
Try to access any property from data inside useSession

Expected behavior
The session type to display user and session information
Screenshots

Desktop (please complete the following information):

OS: windows 10
Browser [e.g. chrome, safari] (not applicable)
Version [e.g. 22] 1.0.18

could you please share what plugins you're using on the client?

@Bekacru no plugins

I'm thinking it may be a typescript config, will try to debug this


Impossible trust

There is no end to end encryption.
Microsoft knows and stores everything you type and share in teams (why does this page say Skype?)

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 33613b2d-d607-ec47-1254-ae540d07ad59
Version Independent ID: aba728f0-0d3c-73fd-c7fe-68e69b6a753f
Content: Security guide for Microsoft Teams - Microsoft Teams
Content Source: Teams/teams-security-guide.md
Service: msteams
GitHub Login: @MSFTTracyP
Microsoft Alias: tracyp

Thank you for submitting feedback.
I think the best way forward is if you open a service ticket in your tenant so this can get resolved ASAP. Based on the outcome let me know if it is something that can be called out in the docs.
Please follow this link to contact support for business products:https://docs.microsoft.com/office365/admin/contact-support-for-business-products
Please keep us posted here on the resolution so we can feed whatever information you discover into the content.


Where do you think OWASP Glue should fit into?

OWASP Glue aims to ease the process of integrating exciting security tools into CI. I think it worth adding it - but I'm not sure under which tools category it should be.

cool, sending a PR :)


Is there a simple minimized standalone?

I need to use it just for a simple landing page. Is there a standalone dist js (without npm)?

dist.zip
There you go

https://cdnjs.com/libraries/exceljs


Add same function of this service for the recording device

As the title says, Can you make same function of the service for recording device, Thanks a lot!

Hello, yes, I think it is possible.

Any update for changing the Recording device? I can confirm that the latest release only works for Default Output.
Recording/input devices on the other hand are still separate.

Added support for microphones in latest beta release. Will close this after merging the pull request.
https://github.com/BarsikV/CommunicationDeviceSwitcherService/releases/tag/2.0.3-beta


Keep ".git" file in in --cleanDestinationDir

Ignore files specifically called ".git" in order to preserve submodule information for Git post-1.7.8 (which seems to be the point things changed from having an entire “.git” directory inside the submodule to having a “.git” file pointing to a gitdir outside of the submodule)
This should restore what I believe was the intended behaviour of #3202 and fix the issue for pojebunny in #4546
See #3202 and #4546

If this is a feature request, and you feel that it is still relevant and valuable, please tell us why.
This issue will automatically be closed in the near future if no further activity occurs. Thank you for all your contributions.

I don't currently use Hugo but I believe this PR still adds value for other users attempting to use submodules with recent versions of Git.

Same issue here. The .git file should be preserved imo

I don't remember any of the context around why I opened this. However...

gohugoio/hugo#3210 shows that there was a separate command added called cleanDestinationDirKeepDotFolders which
This command is not documented, and if I'm reading the current master code correctly it is part of the regular cleanDestinationDir functionality since ~2017 - so I don't know why I ever even opened this...

Exactly, it leaves the dirs intact but clears .git, .gitignore, etc.
I'm having the public folder as a git submodule and it for instance also has a README.md file which would be nice to keep.
Custom regex filter settings would be ideal here I suppose, but ignoring dot-files is already a big help.

I didn't know .git could be a file -- we can check for that, but we're not making this more complicated than that.

https://github.com/spf13/fsync/pull/10
This seems related, might it already be possible?

I didn't know .git could be a file -- we can check for that, but we're not making this more complicated than that.

Honestly, I don't remember all the details of this. But I think it was related to me wanting to pull in a remote theme without committing it in its entirety to my Hugo repo.
That seemed (at the time at least) like a sensible thing to do because it meant updating the theme was just a change of reference, and I think the way I achieved that was by having a theme subdirectory or something similar in my output directory, which was a submodule reference (this somehow turned into a .git file inside the theme subdir, though I don't fully understand/remember why). So when the output directory was being cleared, I actually wanted that submodule reference to remain so that once the output step was finished I could pull the theme from its remote reference into my output directory and then rsync --delete the whole thing up to a webserver.
It was a very, very early exploration into rudimentary CI/CD for me at the time. It may no longer make sense, and I don't use Hugo anymore, which is why I just let the PR expire at the second time of asking instead of being an ass and trying to force a change through that I didn't need anymore.

any update?

This would still be pertinent, though the codebase has changed quite a bit since this PR was opened. The code now lives in /commands/hugobuilder.go. I could open my own PR if needed, though I don't have a Go environment ready and never contributed here.
		syncer.DeleteFilter = func(f os.FileInfo) bool {
-			return f.IsDir() && strings.HasPrefix(f.Name(), ".")
+			return strings.HasPrefix(f.Name(), ".")
		}

I ran into this issue when I found an old site of mine whose public folder contained a redundant clone of the same repository but with the gh-pages branch always checked out. This is precisely what a git worktree is for, I probably just didn't know at the time. I ran this command to replace the redundant clone with a worktree:
rm -rf public && git worktree add public gh-pages

This had the effect of replacing the public/.git folder with a .git file. I knew --cleanDestinationDir left public/.git alone before so I was surprised when it got deleted now that it was a file instead of a folder. I believe this should be fixed for consistency, though I'm not sure if there are people who rely on the current behavior. Still, I found some workarounds for now:

git worktree repair public to recreate the .git file
git worktree lock public to avoid accidental pruning if Hugo deletes the .git file in the future
copy the .git file to the static folder, and make sure not to run git commands within that folder


Possible logic mistake on Kirki_Field class

Issue description:
I was reading through Kirki's code to try to find out another problem (#1425)  I'm having, and I found this piece of code:
		if ( is_array( $config_id ) && empty( $args ) ) {
			$args = $config_id;
			$this->kirki_config = 'global';
		}
		$this->kirki_config = trim( esc_attr( $config_id ) );

(class-kirki-field.php, line 320)
It seems to me that this logic may cause errors if one do what it's actually trying to prevent.
The if statement is verifying if only$args are being passed (no config_id), and set the $this->kirki_config = 'global', but then, when it leaves the if statement, it reasign $this->kirki_config to the output of trim( esc_attr( $config_id ) ), which in the case the user didn't pass it, will be an array and will output an error.
Possible fix would be to put an elsestatement there
		if ( is_array( $config_id ) && empty( $args ) ) {
			$args = $config_id;
			$this->kirki_config = 'global';
		} else {
		    $this->kirki_config = trim( esc_attr( $config_id ) );
		}

I didn't test it, but that'd probably do the trick.
I'd put a PR for it, but I didn't see anybody doing PRs here beside the plugin authors and I'm not sure the proper way to do that. So let me know the guidelines for it, if it's possible
Version used:
(Did you try using the develop branch from github? There's a chance your issue has already been adressed there)
3.0.5
edit: same thing on 3.0.6

Good catch! Fixed, will be included in 3.0.7 which will be released later today.
Thanks!


GaussianNB_StandardScaler.ipynb Added

hey jay,
overall codes looks good.
following changes are required:

remove the output for installation process.
reduce the text size for title standard Scaler and for reference,near model section .
remove blank code cell in the bottom

Removed the output for every cell and resized the text wherever mentioned.

Dont remove output from all the cells, just remove it for the pip command cell

Removed Output and made mentioned changes.


Show the total trial numbers that nni has tried in WebUI

this number is very useful, will show this number on WebUI very soon :)

Already supported in NNI v0.3.x. close it.


Unrecognized input: rs

To restart npm-watch I tried to input nodemon's "rs", but it is not recognized:
[nodemon] starting `npm.cmd run -s build:client`
[nodemon] clean exit - waiting for changes before restart
rs
Unrecognized input: rs

Corresponding watch entry is:
    "build:client": {
      "patterns": [
        "client"
      ],
      "extensions": "ts",
      "delay": 1000
    },

Is there a way to restart watch without resorting to kill everything and relaunch?
Thanks for clarifying!
mario

pushing a fix, thank you for reporting


Find in files not working as expected

I'm using VSCode sometimes to search in logfiles. Basically this is very comfortable. Since one of the last updates the function is no longer working as expected. I'm running
Version: 1.40.2 (user setup)
Commit: f359dd6
Date: 2019-11-25T14:54:45.096Z
Electron: 6.1.5
Chrome: 76.0.3809.146
Node.js: 12.4.0
V8: 7.6.303.31-electron.0
OS: Windows_NT x64 10.0.17134
To reproduce the issue:

Navigate in Windows Explorer to the folder of the log files.
Right click and select "Open with Code"
Open search dialog with CTRL + SHIFT + F
Enter search phrase in search box and press enter
The search starts but presents no results.
There are no options like "Match Case", "Match Whole Word" or "Use Regular Expression" activated.
The field for "files to include" is empty.
The field for "files to exclude" is empty.
The settings for "Files: Exclude" and "Search: Exclude" are the default settings.

The couple of files I'm searching are really plain text files.
They have extensions like ".pro", ".log", ".loge", ".logf", ".logk" or ".err".
The content is definitely available in one of these files.
A crosscheck with Notepad++ found the pattern.
When the file is opened in VSC, the file-search will find all occurences in this file.
The concrete file has a file name like "file.name.pro" - there is more than one dot in the filename.
The issue is reproducible with all extensions disabled.
Is there a way to provide some kind of logfile for analysis?
Best regards
Jochen
PS: This issue is proposed by @egamma as comment in #85356.

@ThirtySomething this is great information but please file a separate issue, it is not clear that it is the same issue.

I figured out that the issue has been caused by network problems in our company.


[Help] Converting Zlinky_TIC quirk to a quirk v2

This is issue is request for help. I hope we can have a conversation about how to convert an existing quirk into a quirk v2. I could not find existing issue related to that.  I also hope documenting my steps here can help other developper during their conversion.
Following the PR #3448, @TheJulianJES suggested to convert the quirk for Zlinky_TIC into a quirk v2.
The proposed modification is to replace the signature for Fw 14.0 with
(
    QuirkBuilder(LIXEE, "ZLinky_TIC")
    .replaces(ZLinkyTICManufacturerCluster)
    .add_to_registry()
)

Looking at the log it does not look like it's working
2024-10-24 11:30:49.307 DEBUG (MainThread) [zha.application.discovery] Discovering entities for endpoint: 00:15:8d:00:05:be:83:47-1
2024-10-24 11:30:49.307 DEBUG (MainThread) [zha.application.discovery] 'button' platform -> 'IdentifyButton' using ['identify']
2024-10-24 11:30:49.307 DEBUG (MainThread) [zha.application.discovery] 'sensor' platform -> 'Tier1SmartEnergySummation' using ['smartenergy_metering']
2024-10-24 11:30:49.307 DEBUG (MainThread) [zha.application.discovery] 'sensor' platform -> 'Tier2SmartEnergySummation' using ['smartenergy_metering']
2024-10-24 11:30:49.307 DEBUG (MainThread) [zha.application.discovery] 'sensor' platform -> 'Tier3SmartEnergySummation' using ['smartenergy_metering']
2024-10-24 11:30:49.307 DEBUG (MainThread) [zha.application.discovery] 'sensor' platform -> 'Tier4SmartEnergySummation' using ['smartenergy_metering']
2024-10-24 11:30:49.307 DEBUG (MainThread) [zha.application.discovery] 'sensor' platform -> 'Tier5SmartEnergySummation' using ['smartenergy_metering']
2024-10-24 11:30:49.307 DEBUG (MainThread) [zha.application.discovery] 'sensor' platform -> 'Tier6SmartEnergySummation' using ['smartenergy_metering']
2024-10-24 11:30:49.307 DEBUG (MainThread) [zha.application.discovery] 'sensor' platform -> 'Battery' using ['power']
2024-10-24 11:30:49.307 DEBUG (MainThread) [zha.application.discovery] 'sensor' platform -> 'ElectricalMeasurementApparentPower' using ['electrical_measurement']
2024-10-24 11:30:49.307 DEBUG (MainThread) [zha.application.discovery] 'sensor' platform -> 'ElectricalMeasurementRMSCurrent' using ['electrical_measurement']
2024-10-24 11:30:49.308 DEBUG (MainThread) [zha.application.discovery] 'sensor' platform -> 'ElectricalMeasurementRMSVoltage' using ['electrical_measurement']
2024-10-24 11:30:49.308 DEBUG (MainThread) [zha.application.discovery] 'sensor' platform -> 'ElectricalMeasurementFrequency' using ['electrical_measurement']
2024-10-24 11:30:49.308 DEBUG (MainThread) [zha.application.discovery] 'sensor' platform -> 'ElectricalMeasurementPowerFactor' using ['electrical_measurement']
2024-10-24 11:30:49.308 DEBUG (MainThread) [zha.application.discovery] 'sensor' platform -> 'SmartEnergySummationReceived' using ['smartenergy_metering']
2024-10-24 11:30:49.308 DEBUG (MainThread) [zha.application.discovery] 'sensor' platform -> 'RSSISensor' using ['basic']
2024-10-24 11:30:49.308 DEBUG (MainThread) [zha.application.discovery] 'sensor' platform -> 'LQISensor' using ['basic']
2024-10-24 11:30:49.308 DEBUG (MainThread) [zha.application.discovery] 'sensor' platform -> 'PolledElectricalMeasurement' using ['electrical_measurement']
2024-10-24 11:30:49.308 DEBUG (MainThread) [zha.application.discovery] 'sensor' platform -> 'PolledSmartEnergySummation' using ['smartenergy_metering']
2024-10-24 11:30:49.308 DEBUG (MainThread) [zha.application.discovery] 'update' platform -> 'FirmwareUpdateEntity' using ['ota']
2024-10-24 11:30:49.308 DEBUG (MainThread) [zha.zigbee.endpoint] Creating cluster handler for cluster id: 33 class: <class 'zha.zigbee.cluster_handlers.general.GreenPowerProxyClusterHandler'>
2024-10-24 11:30:49.308 DEBUG (MainThread) [zha.application.discovery] Discovering entities for endpoint: 00:15:8d:00:05:be:83:47-242
2024-10-24 11:30:49.308 DEBUG (MainThread) [zha.application.discovery] Discovering entities for device: 00:15:8d:00:05:be:83:47-LiXee ZLinky_TIC
2024-10-24 11:30:49.308 DEBUG (MainThread) [zha.application.discovery] Attempting to discover quirks v2 entities for device: 00:15:8d:00:05:be:83:47-LiXee ZLinky_TIC
2024-10-24 11:30:49.308 DEBUG (MainThread) [zha.application.discovery] Device: 00:15:8d:00:05:be:83:47-LiXee ZLinky_TIC does not expose any quirks v2 entities
2024-10-24 11:30:49.309 DEBUG (MainThread) [zha.application.gateway] [0xAC5D](LiXee ZLinky_TIC) restored as 'available', last seen: 0:03:54 ago, consider_unavailable_time: 7200 seconds
2024-10-24 11:30:49.309 DEBUG (MainThread) [zha.zigbee.endpoint] Creating cluster handler for cluster id: 0 class: <class 'zha.zigbee.cluster_handlers.general.BasicClusterHandler'>
2024-10-24 11:30:49.309 DEBUG (MainThread) [zha.zigbee.endpoint] Creating cluster handler for cluster id: 3 class: <class 'zha.zigbee.cluster_handlers.general.IdentifyClusterHandler'>
2024-10-24 11:30:49.309 DEBUG (MainThread) [zha.zigbee.endpoint] Creating cluster handler for cluster id: 32 class: <class 'zha.zigbee.cluster_handlers.general.PollControlClusterHandler'>
2024-10-24 11:30:49.309 DEBUG (MainThread) [zha.zigbee.endpoint] Creating cluster handler for cluster id: 4096 class: <class 'zha.zigbee.cluster_handlers.lightlink.LightLinkClusterHandler'>
2024-10-24 11:30:49.309 DEBUG (MainThread) [zha.zigbee.endpoint] Creating cluster handler for cluster id: 64599 class: <class 'zha.zigbee.cluster_handlers.ClusterHandler'>
2024-10-24 11:30:49.309 DEBUG (MainThread) [zha.zigbee.endpoint] Creating cluster handler for cluster id: 1 class: <class 'zha.zigbee.cluster_handlers.general.PowerConfigurationClusterHandler'>
2024-10-24 11:30:49.309 DEBUG (MainThread) [zha.application.discovery] Discovering entities for endpoint: 60:b6:47:ff:fe:fa:bd:6f-1
2024-10-24 11:30:49.309 DEBUG (MainThread) [zha.application.discovery] 'button' platform -> 'IdentifyButton' using ['identify']
2024-10-24 11:30:49.309 DEBUG (MainThread) [zha.application.discovery] 'sensor' platform -> 'Battery' using ['power']
2024-10-24 11:30:49.309 DEBUG (MainThread) [zha.application.discovery] 'sensor' platform -> 'RSSISensor' using ['basic']
2024-10-24 11:30:49.309 DEBUG (MainThread) [zha.application.discovery] 'sensor' platform -> 'LQISensor' using ['basic']
2024-10-24 11:30:49.310 DEBUG (MainThread) [zha.application.discovery] 'update' platform -> 'FirmwareUpdateEntity' using ['ota']

Although in HA it looks like the device is associated with my quirks v2:

So I'm a little confused by that line in the logs:
2024-10-24 11:30:49.308 DEBUG (MainThread) [zha.application.discovery] Device: 00:15:8d:00:05:be:83:47-LiXee ZLinky_TIC does not expose any quirks v2 entities

Ok, I figured out that if you don't define any entities in the quirkbuilder you get the message
2024-10-24 11:30:49.308 DEBUG (MainThread) [zha.application.discovery] Device: 00:15:8d:00:05:be:83:47-LiXee ZLinky_TIC does not expose any quirks v2 entities

After adding the sensor sensor the message is replaced
24-10-24 13:23:39.670 DEBUG (MainThread) [zha.application.discovery] Attempting to discover quirks v2 entities for device: 00:15:8d:00:05:be:83:47-LiXee ZLinky_TIC
2024-10-24 13:23:39.670 DEBUG (MainThread) [zha.application.discovery] 'sensor' platform -> 'Sensor' using ['smartenergy_metering']
2024-10-24 13:23:39.670 DEBUG (MainThread) [zha.application.gateway] [0xAC5D](LiXee ZLinky_TIC) restored as 'available', last seen: 0:00:50 ago, consider_unavailable_time: 7200 seconds

Now I can add a sensor and get value, but I did not manage to get the information properly displayed. I was expecting the translation_key parameter to be the sensor name string, but it does not work that way.
    .sensor(ElectricalMeasurement.AttributeDefs.active_power_max.name, ElectricalMeasurement.cluster_id,translation_key="Power Max")

The assoicated PR is #3456

You don't need to add any custom entities for a v2 quirk. It's just a debug message stating that none were added.
For just replacing a cluster, like the current v1, this should already be enough to replace all v1 quirks:
(
    QuirkBuilder(LIXEE, "ZLinky_TIC")
    .replaces(ZLinkyTICMetering)
    .replaces(ZLinkyTICManufacturerCluster)
    .add_to_registry()
)

But I see you already have that in your PR.

@TheJulianJES, thanks. I'm actually trying to extend the quirk as I convert it. The basic just works. Maybe you can help with the following.
Right now, I can't get around string I fetch from the zlinky_tic device being processed by the stringify mechanism. I'm not quite sure, because the code base is new to me, but it feels like an issue in the ZHA sensor handling.
I'm adding a sensor like that:
    .sensor(
        Basic.AttributeDefs.model.name,
        Basic.cluster_id,
        fallback_name="Model",
    )

The atrribute type is type=t.LimitedCharString(32) but the type seems to be ignore in ZHA sensor handling and eventully I get this error.
2024-10-28 10:38:43.407 ERROR (MainThread) [homeassistant.components.sensor] Error adding entity sensor.lixee_zlinky_tic_model for domain sensor with platform zha
Traceback (most recent call last):
  File "/usr/src/homeassistant/homeassistant/helpers/entity_platform.py", line 595, in _async_add_entities
    await coro
  File "/usr/src/homeassistant/homeassistant/helpers/entity_platform.py", line 909, in _async_add_entity
    await entity.add_to_platform_finish()
  File "/usr/src/homeassistant/homeassistant/helpers/entity.py", line 1366, in add_to_platform_finish
    self.async_write_ha_state()
  File "/usr/src/homeassistant/homeassistant/helpers/entity.py", line 1005, in async_write_ha_state
    self._async_write_ha_state()
  File "/usr/src/homeassistant/homeassistant/helpers/entity.py", line 1130, in _async_write_ha_state
    self.__async_calculate_state()
  File "/usr/src/homeassistant/homeassistant/helpers/entity.py", line 1067, in __async_calculate_state
    state = self._stringify_state(available)
            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/src/homeassistant/homeassistant/helpers/entity.py", line 1011, in _stringify_state
    if (state := self.state) is None:
                 ^^^^^^^^^^
  File "/usr/src/homeassistant/homeassistant/components/sensor/__init__.py", line 542, in state
    value = self.native_value
            ^^^^^^^^^^^^^^^^^
  File "/usr/src/homeassistant/homeassistant/components/zha/sensor.py", line 136, in native_value
    return self.entity_data.entity.native_value
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.12/site-packages/zha/application/platforms/sensor/__init__.py", line 249, in native_value
    return self.formatter(raw_state)
           ^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.12/site-packages/zha/application/platforms/sensor/__init__.py", line 271, in formatter
    float(value * self._multiplier) / self._divisor, self._decimals
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
ValueError: could not convert string to float: 'ZLinky_TIC'

String sensors aren't currently supported in ZHA, you can specify the sensor class via device_class, but only numeric and timestamps are currently supported. I don't even see a SensorDeviceClass  that would correspond to a string. That said, why are you trying to add a sensor for the model name?

String sensors aren't currently supported, you can specify the sensor class via device_class, but only numeric and timestamps are currently supported. I don't even see a SensorDeviceClass  that would correspond to a string. That said, why are you trying to add a sensor for the model name?

Thankls, that makes more sense with what I see.
I'm not trying to make a sensor from the model name. That was just an example. There are other ZCL attributes which report a string. For example, I get the current tarif applied by electricity supplier as a string from ZLIinky. I also have it as an integer and I can apply an enum on that one.

Thanks for all your work here! I am looking forward to using this for extracting the French EDF Tempo tariff information for today and tomorrow. That would be a good use case for strings, btw, since these are present in the TIC information as strings. An enum could work around this but then all user interfaces have to translate the enum to a string.

An enum could work around this but then all user interfaces have to translate the enum to a string.

Look in the PR, The enum is there for the current Tarrif.
Is this the one you would like to see in the sensor?


Milestone: Create Home, About and Quotes Page

In this milestone:
I have used react routing to create a single-page application for the three pages home, about, and quotes.

Hi @Kashif-Saleem-Ghuman 😊,
While you made a great effort in this project, I cannot proceed to review your code.
Invalid Code Review Request 🛑 💀
You have submitted a project, that missing key features, and future features sections in your readme, kindly add them and add 1-3 potential sentences for each section.
Your Code Review Request will be marked as invalid in your Dashboard, so please submit a new one once you are ready 🙏
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

Invalid Code Review Request does not count into the code reviews limit.

@omarsalem7  Thank you for the feedback. I have made changes and re submitting now.

@gemmen29 Thank you for approving my project and providing valuable feedback. I have made the correction.


cursor plugin: move plugin to separate directory

Coverage remained the same at 80.385% when pulling dfcad78e4ad95362959adce4512df174fd6572e9 on cursor-split into 043d138323b5f125d24d1729f029bc56f8c9fe23 on master.


Custom cursors

Is it possible to add custom cursors like osb/konduit has? Not a major update, but it just feels much better when your ingame cursor is different from normal mouse pointer.

Something like this i guess

Or different weapons like the godswords, d scim, etc.

http://www.rw-designer.com/cursor-set/runescape-jagex-animated-dragon- Please WE NEED THIS

I just want to clarify that I was referring to the cursors changing depending on what you hover over.

I was thinking you meant the cursors from rs where they would show an apple when you hover over food, sword for attack etc.

Custom .ani animated cursors now!!

The touchups on 2006/2010 client could really bring it to life. I still support this


Add a sample of creating your own specialized authorizationmessagehandler

Can we add a sample that instead of configuring the handler like this, creates a custom class? The idea is to follow the pattern for BaseAddressMessageHandler but for other origins:

Create a class
Extend AuthorizationMessageHandler
Create a constructor with any dependency you need
Call ConfigureHandler within the constructor
Register the handler as transient on DI
Call AddMessageHandler<CustomHandler> in the client configuration.

    return new HttpClient(sp.GetRequiredService<AuthorizationMessageHandler>()
        .ConfigureHandler(
            new [] { "https://www.example.com/base" },
            scopes: new[] { "example.read", "example.write" }))
        {
            BaseAddress = new Uri(builder.HostEnvironment.BaseAddress)
        };

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: f2cdb52c-843f-5944-429d-11ea821c1e22
Version Independent ID: 9c4f99ef-f070-b527-4efc-96a04798d9ef
Content: ASP.NET Core Blazor WebAssembly additional security scenarios
Content Source: aspnetcore/security/blazor/webassembly/additional-scenarios.md
Product: aspnet-core
Technology: aspnetcore-security
GitHub Login: @guardrex
Microsoft Alias: riande

@javiercn "add" and "instead of" don't jive ... which is it ... add a another example to what's shown or replace what's shown?

Add but make it the first example you show people or if you don't want both samples remove the existing one

Cool ... yeah ... I have a plan in place now to do this in two sub-sections there so that the dev can see both approaches. I'll place the custom class section first. I'll ping u for review on the PR, which should be up shortly.


Is there a JAVA ORM framework supporting TimeStream?

Hi, team! We are developing with TimeStream where we query data from Timestream and encapsulate the data to return to the client.
But now it is a little bit inconvenient to query and write data with TimeStream.
Is there a JAVA ORM framework supporting TimeStream like mybatis? Or do you have any other suggestions for developing?

@ibufu ,
If you can share a code sample (Please remove any confidential info), it can help us understand your use case
FYI - Here is a link to the Java code sample that you could take a look at
https://github.com/awslabs/amazon-timestream-tools/tree/mainline/sample_apps/javaV2


Pipelines: Update Cekit path

Many thanks for submitting your Pull Request :heart:!
Please make sure your PR meets the following requirements:

[ ] You have read the contributors' guide
[ ] Pull Request title is properly formatted: [KOGITO-XYZ] Subject
[ ] Pull Request contains a link to the JIRA issue
[ ] Pull Request contains a description of the issue
[ ] Pull Request does not include fixes for issues other than the main ticket
[ ] Your feature/bug fix has a unit test that verifies it
[ ] You've ran make before-pr and everything is working accordingly
[ ] You've tested the new feature/bug fix in an actual OpenShift cluster
[ ] You've added a RELEASE_NOTES.md entry regarding this change

How to retest this PR or trigger a specific build:

Run operator BDD testing
Please add comment: /jenkins test

Run RHPAM operator BDD testing
Please add comment: /jenkins RHPAM test

How to backport a pull request to a different branch?

In order to automatically create a backporting pull request please add one or more labels having the following format backport-<branch-name>, where <branch-name> is the name of the branch where the pull request must be backported to (e.g., backport-7.67.x to backport the original PR to the 7.67.x branch).

NOTE: backporting is an action aiming to move a change (usually a commit) from a branch (usually the main one) to another one, which is generally referring to a still maintained release branch. Keeping it simple: it is about to move a specific change or a set of them from one branch to another.

Once the original pull request is successfully merged, the automated action will create one backporting pull request per each label (with the previous format) that has been added.
If something goes wrong, the author will be notified and at this point a manual backporting is needed.

NOTE: this automated backporting is triggered whenever a pull request on main branch is labeled or closed, but both conditions must be satisfied to get the new PR created.

/jenkins RHPAM test

PR job #756 was: UNSTABLE
Possible explanation: This should be test failures
You can find test error logs here: https://jenkins-kogito-tools.kogito-cluster-0ad6762cc85bcef5745bb684498c2436-0000.us-south.containers.appdomain.cloud/job/kogito/job/kogito-operator-PR-check/756//artifact/test/logs/error/
Please look here: https://jenkins-kogito-tools.kogito-cluster-0ad6762cc85bcef5745bb684498c2436-0000.us-south.containers.appdomain.cloud/job/kogito/job/kogito-operator-PR-check/756/display/redirect
See console log:

Console Logs
                             FAIL	github.com/kiegroup/kogito-operator/test	3098.237sFAILTests finished with code 1-------- Pruning namespacesI0125 11:32:07.604649   73917 request.go:665] Waited for 1.003164398s due to client-side throttling, not priority and fairness, request: GET:https://<IP_ADDRESS>:443/apis/image.openshift.io/v1?timeout=32s{"level":"info","T":"2023-01-25T11:32:09.219Z","logger":"kogito-operator-system","msg":"Deleting namespace","namespace":"kogito-operator-system"}{"level":"error","T":"2023-01-25T11:32:09.235Z","logger":"kubernetes_client","msg":"Failed to delete resource.","name":"kogito-operator-system","error":"namespaces \"kogito-operator-system\" not found"}{"level":"error","T":"2023-01-25T11:32:09.236Z","logger":"main","msg":"Error in deleting namespace","error":"Cannot delete namespace kogito-operator-system: namespaces \"kogito-operator-system\" not found"}Pruning namespaces done./home/jenkins/agent/workspace/kogito/kogito-operator-PR-check/test-------- Delete stucked namespacesProjects deleted:-------- Clean Cluster operators--- Clean subscriptions in openshift-operatorsNo resources found in openshift-operators namespace.--- Clean clusterserviceversions in openshift-operatorsNo resources found in openshift-operators namespace.--- Clean subscriptions in operatorsNo resources found in operators namespace.--- Clean clusterserviceversions in operatorsNo resources found in operators namespace.-------- Clean dependencies CRDsDelete cluster crds grafanadashboards.integreatly.orgcustomresourcedefinition.apiextensions.k8s.io "grafanadashboards.integreatly.org" deletedDelete cluster crds grafanadatasources.integreatly.orgcustomresourcedefinition.apiextensions.k8s.io "grafanadatasources.integreatly.org" deletedDelete cluster crds grafanafolders.integreatly.orgcustomresourcedefinition.apiextensions.k8s.io "grafanafolders.integreatly.org" deletedDelete cluster crds grafananotificationchannels.integreatly.orgcustomresourcedefinition.apiextensions.k8s.io "grafananotificationchannels.integreatly.org" deletedDelete cluster crds grafanas.integreatly.orgcustomresourcedefinition.apiextensions.k8s.io "grafanas.integreatly.org" deletedDelete cluster crds backups.infinispan.orgcustomresourcedefinition.apiextensions.k8s.io "backups.infinispan.org" deletedDelete cluster crds batches.infinispan.orgcustomresourcedefinition.apiextensions.k8s.io "batches.infinispan.org" deletedDelete cluster crds caches.infinispan.orgcustomresourcedefinition.apiextensions.k8s.io "caches.infinispan.org" deletedDelete cluster crds infinispans.infinispan.orgcustomresourcedefinition.apiextensions.k8s.io "infinispans.infinispan.org" deletedDelete cluster crds restores.infinispan.orgcustomresourcedefinition.apiextensions.k8s.io "restores.infinispan.org" deletedDelete cluster crds kafkabridges.kafka.strimzi.iocustomresourcedefinition.apiextensions.k8s.io "kafkabridges.kafka.strimzi.io" deletedDelete cluster crds kafkaconnectors.kafka.strimzi.iocustomresourcedefinition.apiextensions.k8s.io "kafkaconnectors.kafka.strimzi.io" deletedDelete cluster crds kafkaconnects.kafka.strimzi.iocustomresourcedefinition.apiextensions.k8s.io "kafkaconnects.kafka.strimzi.io" deletedDelete cluster crds kafkamirrormaker2s.kafka.strimzi.iocustomresourcedefinition.apiextensions.k8s.io "kafkamirrormaker2s.kafka.strimzi.io" deletedDelete cluster crds kafkamirrormakers.kafka.strimzi.iocustomresourcedefinition.apiextensions.k8s.io "kafkamirrormakers.kafka.strimzi.io" deletedDelete cluster crds kafkarebalances.kafka.strimzi.iocustomresourcedefinition.apiextensions.k8s.io "kafkarebalances.kafka.strimzi.io" deletedDelete cluster crds kafkas.kafka.strimzi.iocustomresourcedefinition.apiextensions.k8s.io "kafkas.kafka.strimzi.io" deletedDelete cluster crds kafkatopics.kafka.strimzi.iocustomresourcedefinition.apiextensions.k8s.io "kafkatopics.kafka.strimzi.io" deletedDelete cluster crds kafkausers.kafka.strimzi.iocustomresourcedefinition.apiextensions.k8s.io "kafkausers.kafka.strimzi.io" deletedmake[2]: *** [Makefile:8: run-tests] Error 1make[2]: Leaving directory '/home/jenkins/agent/workspace/kogito/kogito-operator-PR-check/test'make[1]: *** [Makefile:16: run-smoke-tests] Error 2make[1]: Leaving directory '/home/jenkins/agent/workspace/kogito/kogito-operator-PR-check/test'make: *** [Makefile:345: run-smoke-tests] Error 2[Pipeline] sh+ rm -rf console.log[Pipeline] sh+ wget --no-check-certificate -qO - https://jenkins-kogito-tools.kogito-cluster-0ad6762cc85bcef5745bb684498c2436-0000.us-south.containers.appdomain.cloud/job/kogito/job/kogito-operator-PR-check/756/consoleText+ tail -n 100

Depends on https://github.com/kiegroup/kogito-images/pull/1403

/jenkins test

PR job #760 was: UNSTABLE
Possible explanation: This should be test failures
You can find test error logs here: https://jenkins-kogito-tools.kogito-cluster-0ad6762cc85bcef5745bb684498c2436-0000.us-south.containers.appdomain.cloud/job/kogito/job/kogito-operator-PR-check/760//artifact/test/logs/error/
Please look here: https://jenkins-kogito-tools.kogito-cluster-0ad6762cc85bcef5745bb684498c2436-0000.us-south.containers.appdomain.cloud/job/kogito/job/kogito-operator-PR-check/760/display/redirect
See console log:

Console Logs
{"level":"info","T":"2023-01-31T00:06:10.362Z","logger":"main.WARNING","msg":"Some services weren't uninstalled propertly from cluster, see error logs above"}                             FAIL	github.com/kiegroup/kogito-operator/test	2815.196sFAILTests finished with code 1-------- Pruning namespacesI0131 00:06:26.838112   55100 request.go:665] Waited for 1.048949577s due to client-side throttling, not priority and fairness, request: GET:https://<IP_ADDRESS>:443/apis/imageregistry.operator.openshift.io/v1?timeout=32s{"level":"info","T":"2023-01-31T00:06:28.424Z","logger":"kogito-operator-system","msg":"Deleting namespace","namespace":"kogito-operator-system"}{"level":"error","T":"2023-01-31T00:06:28.438Z","logger":"kubernetes_client","msg":"Failed to delete resource.","name":"kogito-operator-system","error":"namespaces \"kogito-operator-system\" not found"}{"level":"error","T":"2023-01-31T00:06:28.438Z","logger":"main","msg":"Error in deleting namespace","error":"Cannot delete namespace kogito-operator-system: namespaces \"kogito-operator-system\" not found"}Pruning namespaces done./home/jenkins/agent/workspace/kogito/kogito-operator-PR-check/test-------- Delete stucked namespacesProjects deleted:-------- Clean Cluster operators--- Clean subscriptions in openshift-operatorsNo resources found in openshift-operators namespace.--- Clean clusterserviceversions in openshift-operatorsNo resources found in openshift-operators namespace.--- Clean subscriptions in operatorsNo resources found in operators namespace.--- Clean clusterserviceversions in operatorsNo resources found in operators namespace.-------- Clean dependencies CRDsDelete cluster crds grafanadashboards.integreatly.orgcustomresourcedefinition.apiextensions.k8s.io "grafanadashboards.integreatly.org" deletedDelete cluster crds grafanadatasources.integreatly.orgcustomresourcedefinition.apiextensions.k8s.io "grafanadatasources.integreatly.org" deletedDelete cluster crds grafanafolders.integreatly.orgcustomresourcedefinition.apiextensions.k8s.io "grafanafolders.integreatly.org" deletedDelete cluster crds grafananotificationchannels.integreatly.orgcustomresourcedefinition.apiextensions.k8s.io "grafananotificationchannels.integreatly.org" deletedDelete cluster crds grafanas.integreatly.orgcustomresourcedefinition.apiextensions.k8s.io "grafanas.integreatly.org" deletedDelete cluster crds backups.infinispan.orgcustomresourcedefinition.apiextensions.k8s.io "backups.infinispan.org" deletedDelete cluster crds batches.infinispan.orgcustomresourcedefinition.apiextensions.k8s.io "batches.infinispan.org" deletedDelete cluster crds caches.infinispan.orgcustomresourcedefinition.apiextensions.k8s.io "caches.infinispan.org" deletedDelete cluster crds infinispans.infinispan.orgcustomresourcedefinition.apiextensions.k8s.io "infinispans.infinispan.org" deletedDelete cluster crds restores.infinispan.orgcustomresourcedefinition.apiextensions.k8s.io "restores.infinispan.org" deletedDelete cluster crds kafkabridges.kafka.strimzi.iocustomresourcedefinition.apiextensions.k8s.io "kafkabridges.kafka.strimzi.io" deletedDelete cluster crds kafkaconnectors.kafka.strimzi.iocustomresourcedefinition.apiextensions.k8s.io "kafkaconnectors.kafka.strimzi.io" deletedDelete cluster crds kafkaconnects.kafka.strimzi.iocustomresourcedefinition.apiextensions.k8s.io "kafkaconnects.kafka.strimzi.io" deletedDelete cluster crds kafkamirrormaker2s.kafka.strimzi.iocustomresourcedefinition.apiextensions.k8s.io "kafkamirrormaker2s.kafka.strimzi.io" deletedDelete cluster crds kafkamirrormakers.kafka.strimzi.iocustomresourcedefinition.apiextensions.k8s.io "kafkamirrormakers.kafka.strimzi.io" deletedDelete cluster crds kafkarebalances.kafka.strimzi.iocustomresourcedefinition.apiextensions.k8s.io "kafkarebalances.kafka.strimzi.io" deletedDelete cluster crds kafkas.kafka.strimzi.iocustomresourcedefinition.apiextensions.k8s.io "kafkas.kafka.strimzi.io" deletedDelete cluster crds kafkatopics.kafka.strimzi.iocustomresourcedefinition.apiextensions.k8s.io "kafkatopics.kafka.strimzi.io" deletedDelete cluster crds kafkausers.kafka.strimzi.iocustomresourcedefinition.apiextensions.k8s.io "kafkausers.kafka.strimzi.io" deletedmake[2]: *** [Makefile:8: run-tests] Error 1make[2]: Leaving directory '/home/jenkins/agent/workspace/kogito/kogito-operator-PR-check/test'make[1]: *** [Makefile:16: run-smoke-tests] Error 2make[1]: Leaving directory '/home/jenkins/agent/workspace/kogito/kogito-operator-PR-check/test'make: *** [Makefile:345: run-smoke-tests] Error 2[Pipeline] sh+ rm -rf console.log[Pipeline] sh

/jenkins test

PR job #761 was: UNSTABLE
Possible explanation: This should be test failures
You can find test error logs here: https://jenkins-kogito-tools.kogito-cluster-0ad6762cc85bcef5745bb684498c2436-0000.us-south.containers.appdomain.cloud/job/kogito/job/kogito-operator-PR-check/761//artifact/test/logs/error/
Please look here: https://jenkins-kogito-tools.kogito-cluster-0ad6762cc85bcef5745bb684498c2436-0000.us-south.containers.appdomain.cloud/job/kogito/job/kogito-operator-PR-check/761/display/redirect
See console log:

Console Logs
                             FAIL	github.com/kiegroup/kogito-operator/test	1934.321sFAILTests finished with code 1-------- Pruning namespacesI0131 07:52:47.803970   54735 request.go:665] Waited for 1.038186948s due to client-side throttling, not priority and fairness, request: GET:https://<IP_ADDRESS>:443/apis/template.openshift.io/v1?timeout=32s{"level":"info","T":"2023-01-31T07:52:49.369Z","logger":"kogito-operator-system","msg":"Deleting namespace","namespace":"kogito-operator-system"}{"level":"error","T":"2023-01-31T07:52:49.391Z","logger":"kubernetes_client","msg":"Failed to delete resource.","name":"kogito-operator-system","error":"namespaces \"kogito-operator-system\" not found"}{"level":"error","T":"2023-01-31T07:52:49.392Z","logger":"main","msg":"Error in deleting namespace","error":"Cannot delete namespace kogito-operator-system: namespaces \"kogito-operator-system\" not found"}Pruning namespaces done./home/jenkins/agent/workspace/kogito/kogito-operator-PR-check/test-------- Delete stucked namespacesProjects deleted:-------- Clean Cluster operators--- Clean subscriptions in openshift-operatorsNo resources found in openshift-operators namespace.--- Clean clusterserviceversions in openshift-operatorsNo resources found in openshift-operators namespace.--- Clean subscriptions in operatorsNo resources found in operators namespace.--- Clean clusterserviceversions in operatorsNo resources found in operators namespace.-------- Clean dependencies CRDsDelete cluster crds grafanadashboards.integreatly.orgcustomresourcedefinition.apiextensions.k8s.io "grafanadashboards.integreatly.org" deletedDelete cluster crds grafanadatasources.integreatly.orgcustomresourcedefinition.apiextensions.k8s.io "grafanadatasources.integreatly.org" deletedDelete cluster crds grafanafolders.integreatly.orgcustomresourcedefinition.apiextensions.k8s.io "grafanafolders.integreatly.org" deletedDelete cluster crds grafananotificationchannels.integreatly.orgcustomresourcedefinition.apiextensions.k8s.io "grafananotificationchannels.integreatly.org" deletedDelete cluster crds grafanas.integreatly.orgcustomresourcedefinition.apiextensions.k8s.io "grafanas.integreatly.org" deletedDelete cluster crds backups.infinispan.orgcustomresourcedefinition.apiextensions.k8s.io "backups.infinispan.org" deletedDelete cluster crds batches.infinispan.orgcustomresourcedefinition.apiextensions.k8s.io "batches.infinispan.org" deletedDelete cluster crds caches.infinispan.orgcustomresourcedefinition.apiextensions.k8s.io "caches.infinispan.org" deletedDelete cluster crds infinispans.infinispan.orgcustomresourcedefinition.apiextensions.k8s.io "infinispans.infinispan.org" deletedDelete cluster crds restores.infinispan.orgcustomresourcedefinition.apiextensions.k8s.io "restores.infinispan.org" deletedDelete cluster crds kafkabridges.kafka.strimzi.iocustomresourcedefinition.apiextensions.k8s.io "kafkabridges.kafka.strimzi.io" deletedDelete cluster crds kafkaconnectors.kafka.strimzi.iocustomresourcedefinition.apiextensions.k8s.io "kafkaconnectors.kafka.strimzi.io" deletedDelete cluster crds kafkaconnects.kafka.strimzi.iocustomresourcedefinition.apiextensions.k8s.io "kafkaconnects.kafka.strimzi.io" deletedDelete cluster crds kafkamirrormaker2s.kafka.strimzi.iocustomresourcedefinition.apiextensions.k8s.io "kafkamirrormaker2s.kafka.strimzi.io" deletedDelete cluster crds kafkamirrormakers.kafka.strimzi.iocustomresourcedefinition.apiextensions.k8s.io "kafkamirrormakers.kafka.strimzi.io" deletedDelete cluster crds kafkarebalances.kafka.strimzi.iocustomresourcedefinition.apiextensions.k8s.io "kafkarebalances.kafka.strimzi.io" deletedDelete cluster crds kafkas.kafka.strimzi.iocustomresourcedefinition.apiextensions.k8s.io "kafkas.kafka.strimzi.io" deletedDelete cluster crds kafkatopics.kafka.strimzi.iocustomresourcedefinition.apiextensions.k8s.io "kafkatopics.kafka.strimzi.io" deletedDelete cluster crds kafkausers.kafka.strimzi.iocustomresourcedefinition.apiextensions.k8s.io "kafkausers.kafka.strimzi.io" deletedmake[2]: *** [Makefile:8: run-tests] Error 1make[2]: Leaving directory '/home/jenkins/agent/workspace/kogito/kogito-operator-PR-check/test'make[1]: *** [Makefile:16: run-smoke-tests] Error 2make[1]: Leaving directory '/home/jenkins/agent/workspace/kogito/kogito-operator-PR-check/test'make: *** [Makefile:345: run-smoke-tests] Error 2[Pipeline] sh+ rm -rf console.log[Pipeline] sh+ wget --no-check-certificate -qO - https://jenkins-kogito-tools.kogito-cluster-0ad6762cc85bcef5745bb684498c2436-0000.us-south.containers.appdomain.cloud/job/kogito/job/kogito-operator-PR-check/761/consoleText+ tail -n 100


Automation: Added an extremely basic deployment for use in Jenkins.

Adds the deploy script.

@ksandom looks good. let's get this deployed today :)


<EMAIL_ADDRESS>Download failed

Installing openocd with scoop returns 403
{ ~ } » scoop install openocd
Installing 'openocd' (0.10.0) [64bit]
The remote server returned an error: (403) Forbidden.
URL http://www.freddiechopin.info/en/download/category/4-openocd?download=154%3Aopenocd-0.10.0#/dl.7z is not valid

While I'm able to download the file manually.

Yes, you're right. I had to check security app first. It prevented me to fetch the file


Drawing text disapear after window resize

Hi all,
When the renderer is created with SDL_RENDERER_ACCELERATED flag, the drawing text disapear after resizing the window.
Using the SDL_RENDERER_SOFTWARE flag, it works well.

Hi, I just found this library and came across the same issue.
If you edit this line 1185. It seems to work with the following flag which is 1.
    fc_has_render_target_support = (info.flags & SDL_RENDERER_SOFTWARE);
It will also work with flag of 8192.

Thansk. It works.
I simply disabled this flag :
fc_has_render_target_support = 0;

Changing breaks UTF-8.

You are right. UTF8 is broken :/

Line 978: if(!fc_has_render_target_support)
if(fc_has_render_target_support > 0)

No. UTF-8 is still broken.

Can you post a program that demonstrates this for further investigation?  Resizing a window shouldn't cause the context to be lost, as far as I understand, though fullscreening might.  If the context is lost, then textures would be dropped.  SDL can restore some textures, which might be what is happening here when comparing textures created with SDL_CreateTextureFromSurface() and textures created as render targets.  With a definite repro case, I can look further into this.
When disabling render targets like what was suggested above, you are losing the ability to render new glyphs onto the cache level textures at drawtime.  That's why UTF-8 would not work.  If you know which glyphs you will need, you can work around this by preloading them with FC_SetLoadingString().  It does seem like sometimes this might be desirable, so maybe we can add a function and manual setting for disabling render target support.

Ok, Here a minimal test case :
int main(int argc, char** argv)
{
  if (SDL_Init(SDL_INIT_VIDEO) != 0)
    return -1;

  if (TTF_Init())
    return -1;

  // This change nothing
  /*
  SDL_SetHint(SDL_HINT_RENDER_SCALE_QUALITY, "1");

  if (SDL_GL_SetSwapInterval(-1))
    SDL_GL_SetSwapInterval(1);
  */

  SDL_Window *_pWindow = SDL_CreateWindow("test window",
    SDL_WINDOWPOS_CENTERED, SDL_WINDOWPOS_CENTERED, 1280, 720,
    SDL_WINDOW_OPENGL | SDL_WINDOW_RESIZABLE | SDL_WINDOW_MAXIMIZED);
  if (!_pWindow)
    return -1;

  // Using this line makes the text disappear as soon as I resize the window
  // Removing the SDL_RENDERER_TARGETTEXTURE changes nothing
   SDL_Renderer *_pRenderer = SDL_CreateRenderer(_pWindow, -1, SDL_RENDERER_ACCELERATED | SDL_RENDERER_PRESENTVSYNC | SDL_RENDERER_TARGETTEXTURE);

   // Using this line makes things working right :)
   // Removing the SDL_RENDERER_TARGETTEXTURE changes nothing
   //SDL_Renderer *_pRenderer = SDL_CreateRenderer(_pWindow, -1, SDL_RENDERER_SOFTWARE | SDL_RENDERER_TARGETTEXTURE);

   // This changes nothing
   //SDL_SetRenderDrawBlendMode(_pRenderer, SDL_BLENDMODE_BLEND);

   // Create background
   FC_Font *_pFontTextHeader = FC_CreateFont();
   FC_LoadFont(_pFontTextHeader, _pRenderer, "res/header.ttf", 14, FC_MakeColor(200, 200, 200, 255), TTF_STYLE_NORMAL);

   int counter = 0;
   while (42)
   {
     SDL_Event ev;
     while (SDL_PollEvent(&ev))
     {
       if (ev.type == SDL_QUIT)
         return -2;
     }

     int windowWidth = SDL_GetWindowSurface(_pWindow)->w;
     int windowHeight = SDL_GetWindowSurface(_pWindow)->h;

     // Draw black background
     SDL_Rect recBg = { 0, 0, windowWidth, windowHeight };
     SDL_SetRenderDrawColor(_pRenderer, 0, 0, 0, 255);
     SDL_RenderFillRect(_pRenderer, &recBg);

     // Using test text with UTF8 symbol (°)
     FC_DrawAlign(_pFontTextHeader, _pRenderer, static_cast<float>(windowWidth / 2), static_cast<float>(windowHeight / 2), FC_ALIGN_CENTER, u8"°° %d °°", counter++);

     SDL_RenderPresent(_pRenderer);

     SDL_Delay(100);
   }

  return 0;
}

Can you post a program that demonstrates this for further investigation? Resizing a window shouldn't cause the context to be lost, as far as I understand, though fullscreening might.

I used your demo for my tests.

Add SDL_RENDERER_ACCELERATED for textures to disappear on resize with UTF-8 intact.

main.c 333  renderer = SDL_CreateRenderer(window, -1, SDL_RENDERER_PRESENTVSYNC | SDL_RENDERER_ACCELERATED);

A hack to fix resize but break UTF-8

SDL_FontCache.c 1185  fc_has_render_target_support = (info.flags & 0);

For information, I have this issue on Windows (10) with SDL2-2.0.12.x64 and SDL2_ttf-2.0.15.x64

Any news ?

I'm also getting the same error.

Got the same problem. Work around was to free the font FC_FreeFont, then recreate FC_CreateFont and load again FC_LoadFont on the window resise event SDL_WINDOWEVENT_SIZE_CHANGED.
Not ideal but can live with that.

Got the same problem. Work around was to free the font FC_FreeFont, then recreate FC_CreateFont and load again FC_LoadFont on the window resise event SDL_WINDOWEVENT_SIZE_CHANGED.
Not ideal but can live with that.

By the way, the problem is on windows 10, it works fine on Linux.

By the way, the problem is on windows 10, it works fine on Linux.

I have also had a report that on Windows resizing my game's window results in text disappearing.
I found this thread https://discourse.libsdl.org/t/sdl2-0-10-textures-disappearing-renderer-causing-error-when-resizing-window-with-a-render-target-texture/26598
which suggests using an SDL hint to use opengl instead of directX.

From the error message I assume it’s not using OpenGL but Direct3D, which is the default on Windows. It might be interesting to see if OpenGL behaves differently, which you can do by setting this hint before creating the renderer:
SDL_SetHint(SDL_HINT_RENDER_DRIVER, "opengl");

I add this line right before I created the renderer, and it seems to have resolved the issue for me (tested using Wine on my Ubuntu 20.04 system).

To fixe this issue under direct3d, you have to handle the SDL_RENDER_TARGETS_RESET SDL event type then call FC_ResetFontFromRendererReset() on your fonts objects.
Sometime d3d context asks for SDL_RENDER_TARGETS_RESET that require we recreate SDL_TEXTUREACCESS_TARGET textures.
The simplest solution is to keep all your font objects references to a global std::vector<FC_Font *> then 👍
  while (SDL_PollEvent(&ev))   {     if (ev.type == SDL_RENDER_TARGETS_RESET) {         for (FC_Font* font : _FC_FontList)             FC_ResetFontFromRendererReset(font, _pRenderer, SDL_RENDER_TARGETS_RESET);     }   }


Send team welcome chat message in bg

Put the chat send in the background. It took 800ms out of 2.2s for TeamAddMember in one instance.

Why did it take 800ms? That seems very high.

We'll see

Seems fine. The other PR passed and it doesn't send the chat at all, so nothing is testing this.


Improve logging, error handling, fix batch commitments

Add db methods to get all of the required info. Fix time limit issues
add batch command
scheduler types
upgrade polkadot deps
Update contract query method to allow for historic calls
Upgrade dependencies and tests
update batch
fix tests
Update contract addresses, ports to be non-default
Update contract address and use prosopo contract as dapp contract until dapp contracts can be built again
all tests working and newest version of contract updated in env files
update contract address
new contract address with all tests working
Workflow for provider tests
init submodules and checkout develop
dont use npm checkout commands
break down stagaes
add submodules flag to checkout part
use upgrade_deps branch, install packages
Try to get custom npm commands to run
cat package.json
upgrade checkout script and caching
checkout correct branch using ref tag
Try checking out branch
specify environment
run tests from provider
try environment and setup in one go
Try to cache the docker images
Add environment to setup
try to use workspaces package-lock
remove node caching
try to fix docker cache key
make sure we're on the right branch
don't try to copy artifacts
choose correct branch
change scripts repo
cat .env.development
checkout correct branches
hash files
git pull origin develop
checkout branch
docker ls
remove cat and change dir
remove test env var from package.json
try to change image cache key
ls contents of image cache folder
Try to cache node modules
Create manual node modules cache
remove the docker containers to prevent old providers from breaking tests
remove invalid key from node cache step
cd into home/workspaces
add debug for node cache step
remove run from cache step, add debug
try to work out which folder we're in
list dirs
Fix node cache path
ls workspaces
Cache .npm instead of node_modules
run all tests
Add install step back in
remove stopped containers
continue if no containers
Get provider working with new version of ink and substrate contracts node
improve sendFunds logging
improve DatabasePopulator logging
All tests passing

Closes #206

Closes  #14


Create 2021-12-06-addtokentocelowallet.md

Hello friends

thanks for this @vissequ! It looks like you added images using HTML. Can you update them to use markdown syntax? it is like a link in markdown with a ! before it, so ![alt text](https://link-to-image-location.com)


Manifest not compile

Information

Apktool Version (apktool -2.3.1) -
Operating System (Windows) -
APK From? (Other) -

Hello, i decode apk with new option,
apktool.jar d -s -r --force-manifest test.apk
and after change manifest and build with command
apktool.jar b D:\\test
app build success, manifest not compile,
how can i compile manifest ?

There is no support to individually compile/build an AndroidManifest.xml file. You can currently decode it (as-is), but you cannot build just that file.
This would be a feature request, which might not be possible as resources would be in the compiled state and thus not able to be read the resources needed for building a manifest file. Let me look into it.

it's very nice if this feature be implemented, most of the time wo only want to add android:debuggable="true" in to  label

it's very nice if this feature be implemented, most of the time wo only want to add android:debuggable="true" in to  label

it's very nice if this feature be implemented, most of the time wo only want to add android:debuggable="true" in to "application" label

it's very nice if this feature be implemented, most of the time we only want to add android:debuggable="true" in to "application" label

Any progress ? @iBotPeaches

@lkdevil Sorry no progress. Bugs tend to get priority over features and I have about 150 of them.

This is not possible and won't be. Apktool needs to decode resources, otherwise we will have resourceIds everywhere and that won't work. Sorry.
Closing.


fix: nested form inputs do not work

Related Issues
fixes https://github.com/descope/etc/issues/6958
Related PRs
https://github.com/descope/descope-js/issues/520
Description

fix nested form inputs do not work while supporting object form value
added test case

@Bars92 Why am I not seeing the updated lockfile in the Files Changed tab?

@tomerlichtash why do you need to see it? haven't changed anything in package file so i reverted the change

We moved these files,
now it's under packages/sdks/web-component/...
Sorry for the inconvenience

np @nirgur conflicts resolved automatically. is the deployment broken?

np @nirgur conflicts resolved automatically. is the deployment broken?

Yes, we do not have permission to change the Vercel projects

np @nirgur conflicts resolved automatically. is the deployment broken?

Yes, we do not have permission to change the Vercel projects

Fixed

@tomerlichtash you can re-approve


Synthetic dataset generation produces undesired Introductory Phrases with Bedrock LLM

[x] I checked the documentation and related resources and couldn't find an answer to my question.
Your Question
Hi, I'm trying to use this library for generating a synthetic dataset using the LLM and Bedrock embeddings, according to the section of the documentation titled: 'Using Amazon Bedrock'. What I'm noticing is that most of the generated questions have this form: 'Based on the feedback, here is a rewritten version of the question that incorporates the relevant context:..', or 'Based on the given context and keyphrase, here is a potential question:...', 'Based on the given context and keyphrase "X", a relevant question could be:.....'. Could someone help me understand how to avoid this behavior, so that I can obtain questions in a direct form, without these 'introductory parts'?

@dosu
TestsetGenerator(
    generator_llm=bedrock_model,
    critic_llm=bedrock_model,
    embeddings=bedrock_embeddings,
    docstore=docstore,
    prompts=[reasoning_question_prompt, multi_context_question_prompt]
)

I think passing prompts as argument in the TestsetGenerator constructor is not allowed as of now.

"After consulting the source code in ragas/testset/prompts.py, I noticed that some metaprompt instructions specify not to use the above introductory expression, but not all of them—for example, the seed_question_prompt or question_rewrite_prompt. This might be why I still get most of the questions beginning with 'Based on the feedback...' or similar sentences, can anyone help me out on that ?


block.put ignores CID argument

Hello, I'm having an issue where block.get is hanging and never returns the block.
Here's the example code:
const ipfsAPI = require('ipfs-api')
const CID = require('cids')
const multihashes = require('multihashes')
const crypto = require('crypto')

function sha256(data) {
  return crypto.createHash('sha256').update(data).digest()
}

const ipfs = ipfsAPI('localhost', '5001', {protocol: 'http'})
const buf = sha256('hello world!')
const mh = multihashes.encode(buf, 'sha2-256')
const cid = new CID(1, 'dag-cbor', mh)

console.log('cid', cid.toBaseEncodedString())

ipfs.repo.gc()
.then(() => {
  return ipfs.block.put(buf, cid)
  .then(block => {
    console.log('put', block.cid.toBaseEncodedString())

    // NEVER GETS CALLED!
    return ipfs.block.get(cid)
    .then(block => {
      // NEVER GETS CALLED!
      console.log('get', block._data.toString())
    })
    .catch(error => console.error(error))
  })
})

Output
cid zdpuAtJJwFer98hHGdt2UQdoF1We7vQuBXSTDKjorNkYovyzQ
put QmPdbXGenToPFzmxJyoVNAAfh5eKvnu2f8KzSx2J8jhwQP

It works using the CLI though:
$ ipfs repo gc

$ echo -n 'hello world!' | ipfs block put -f cbor
zdpuAtJJwFer98hHGdt2UQdoF1We7vQuBXSTDKjorNkYovyzQ

$ ipfs block get zdpuAtJJwFer98hHGdt2UQdoF1We7vQuBXSTDKjorNkYovyzQ
hello world!

Any help is appreciated, thanks.

It looks like the CID is being ignored in https://github.com/ipfs/js-ipfs-api/blob/master/src/block/put.js

It looks like the CID is being ignored

Yes and because of that, the block is being stored under a version 0 CID so you can't get it back using your version 1 CID - which explains the hanging.

Also, according to the spec the second arg should be an object with a cid property, not the CID itself.
https://github.com/ipfs/interface-ipfs-core/blob/master/SPEC/BLOCK.md#blockput

I'd like to give this a try.  New here, not sure what the process is for asking to be assigned to an issue.

@neodon that would be awesome, please send a PR! Would you mind also adding a test to https://github.com/ipfs/interface-ipfs-core/blob/master/js/src/block/put.js for this?
You need to use npm link to run the test you add against this repo. You should be able to tweak https://github.com/ipfs/js-ipfs-api/blob/master/test/interface.spec.js to run only the test you've added while you're developing.

@neodon did you get anywhere with this?

@alanshaw I've spent quite a bit of time digging through the layers in js-ipfs-api and js-ipfs.  Currently going through the go-ipfs implementation to get more context.  Any hints or insight would be helpful.  I can't seem to determine that js-ipfs-api actually supports setting a custom cid.

I took a look -- is the issue just that the CID is not being properly passed in the call of sendOneFile on line 29? Also the need to handle the different possible types of CID objects being passed into the function


Issue #133 Fixed ( Delete All Button and Empty Space )

The issue was with the delete all button which was there on screen even if the list was empty. The issue was fixed. A simple text is instead added to the empty space in the middle indicating if the list is empty or not.

Thank You


Offer optional support for protox in tonic-build

Feature Request
If I understand correctly, using https://github.com/andrewhickman/protox should make it possible to avoid the use of protoc binaries. It would be great if tonic-build offered built-in API (using a Cargo feature) to leverage protox for schema compilation.
Crates
tonic-build
Motivation
Avoid the need for installing protoc on developer systems and in build containers.
I'd be willing to implement this if there is a reasonable expectation that it would be accepted.
Alternatives
It is possible today to use protox directly, as documented in its README:
let file_descriptors = protox::compile(["root.proto"], ["."]).unwrap();

let file_descriptor_path = PathBuf::from(env::var_os("OUT_DIR").expect("OUT_DIR not set"))
    .join("file_descriptor_set.bin");
fs::write(&file_descriptor_path, file_descriptors.encode_to_vec()).unwrap();

tonic_build::Config::new()
    .file_descriptor_set_path(&file_descriptor_path)
    .skip_protoc_run()
    .compile_protos(["root.proto"], ["."])
    .unwrap();

Having this built-in seems like it would be a good deal more easy to use, and maybe eventually could become the default?
@andrewhickman any potential blockers from your side?

Sounds good to me 😃
It would also be nice to have a compile_fds function like in prost-build. That also allows the user to customize the protox compilation if necessary, and doesn't require a direct dependency on protox

@andrewhickman would you be interested in starting that work? I think id like to get a release out today but we can add these in both prost/tonic in a non-breaking way.

This sounds great.

https://github.com/andrewhickman/protox/issues/17 - added more complete instructions in this issue.


Added support for callback properties (#21)

Hey @kentcdodds, first of all, thanks for this great library, only stumbled upon it a few days ago but already it's truly been a godsend when implementing in-memory search/filtering functionality 😄
One lacking feature so far however has been support for callback properties. This is especially useful for  interfacing with libraries such as Immutable.js
I've updated the tests and documentation, take a look when you get the chance and let me know if there are any changes you'd like to be made :)
Cheers!

Current coverage is 100% (diff: 100%)

Merging #19 into master will not change coverage

@@           master   #19   diff @@
===================================
  Files           1     1
  Lines          76    78     +2
  Methods         0     0
  Messages        0     0
  Branches        0     0
===================================
+ Hits           76    78     +2
  Misses          0     0
  Partials        0     0

Powered by Codecov. Last update 5f37e2e...e79a6cd

:shipit:

Thanks!

Thanks so much for your help! I've added you as a collaborator on the project. Please make sure that you review the CONTRIBUTING.md file (specifically the bit about the commit messages and the git hooks) and familiarize yourself with the code of conduct (we're using the contributor covenant). You might also want to watch the repo to be notified when someone files an issue/PR. Please continue to make PRs as you feel the need (you can make your branches directly on the repo rather than your fork if you want). Thanks! And welcome to the team :)

Awesome, thank you! Already have a couple minor improvements in mind 😊


upgrade dependencies to angular 16

Make the lib compatible with Angular 16

Published version 8.0.0


add (factorial of a number using Big Integer in Java)

What kind of change does this PR introduce? (check at least one)

[ ] Bugfix
[x] New algorithm
[ ] Optimization in previous algorithms
[ ] Code style update
[ ] Refactor
[ ] Documentation
[ ] Other, please describe:

Briefly describe the changes in this PR
I have added Factorial of a Number using BigInteger in Java.

Other information:

Hi
@TawfikYasser, @cyberwizard1001, @aayushjain7
Please Review My PR.

@JayantGoel001 Nice work.

Thanks 😃


Dang-1761/search input no x when no text

JIRA
https://lobsters.atlassian.net/browse/DANG-1761

Description

Don't show the clear button in the search bar unless there is currently a search term in the input.  In order to preserve the space for the clear button I changed the cursor to pointer, gave the button 0 opacity, and it does nothing if clicked when there is no search term present.  If there is a search term, it has full opacity, a click pointer,  and the click function works.

exciting! let's also update the tests for this change?


When slides count less 4

3 slide when scrolling is strange effect

yes, I also found this issue, it annoy me, do you find the solution about it ?

I tried fix issue in this commit https://github.com/EL-shadow/Excolo-Slider/commit/6114797cb63acf0165f495c8879f6bfce47e9ede
in my fork

thank you for your reply
2015-01-30 20:23 GMT+08:00 EL-shadow<EMAIL_ADDRESS>
I tried fix issue in this commit EL-shadow@6114797
https://github.com/EL-shadow/Excolo-Slider/commit/6114797cb63acf0165f495c8879f6bfce47e9ede
in my fork
—
Reply to this email directly or view it on GitHub
https://github.com/Excolo/Excolo-Slider/issues/12#issuecomment-72193400.


feat: issue-162/commitizen-support

Introduces commitizen as a dev dependency
Adds commitizen to pre-commit hooks to check commits are conventional

Forgot to pull the main branch before starting on the new topic branch. Don't want to bring #151 with us!


Ensure that all HumanoidDescription changes get cloned first and then applied

Ensure that all HumanoidDescription changes get cloned first and then applied.
I've seen some functions not cloning the HumanoidDescription and instead directly modifying the HumanoidDescription from the player.
This can cause issues, especially if you're changing Idle or Run animations.

The proper way to do this is via humanoid:GetAppliedDescription()


Add Author on models

Update ModelsCommand.php to add Author through the files

What's your use case?

@barryvdh no feedback from author, I suggest to drop this PR 🤷♀

I guess this would make it easier to reset the phpdocs and keep tags, but I think this is a bit too specific.
Maybe we could reset only the docs that are added by us, not other tags.


XCode reports description of examples and a yellow warning for pending

Pending cases are now reported by XCode as yellow warning: not finished
#67 Warnings (yellow) for "pending" tests
Examples are now shown with full description using underscore instead of spaces
#69 "Run test case example" instead of meaningful description?
The XML output can now be generated by https://github.com/ciryon/OCUnit2JUnit
#84 JUnit-compatable XML output.

Thanks!

Thanks Paul. Feel free to add yourself to contrib file.

The warnings seem to show up inconsistently. It seems that Xcode isn't detecting that the test case doesn't finish on some runs. They also don't show up in the issues browser.
Also, I get a new level of indentation in the test results for each pending test. http://twitpic.com/8t8pqs

Yes, I see Xcode indents pending test cases incorrectly. I will see what can be done about that.
Issues browser shows only failing tests, which might be a good thing.
For me Xcode detects test cases that did not finish every run.

I'm not see those inconsistent reports now that I've upgraded to 4.3.1. Maybe it was an Xcode 4.3 bug.
I've pushed a commit with a different approach to creating the method names for the examples. I find all the underscores a little hard to read, so I've tried it with camel case. (SHA: 95f13053783e63a3303f476da82f22f78396029b)
At the very least, we need to strip illegal characters from the generated names. I had a '-1' in one of my descriptions and Xcode skipped the rest of the examples in the suite after encountering it.

I like it, reads better. Thank you

On #67, I've pushed an alternative approach (SHA: 7c0bd3dc1b065564bb9c23d47e56128e62926687). It puts the warnings in the build log, instead of the testing log, but they should up in the issues navigator. I don't really use pending tests myself, so I don't know if this is better or worse.