Loosen restriction on vmware-vra-gem version.

Version 1.5.0 of vmware-vra-gem has been released containing additional
fixes and support for different VM types.  The current gem version pin
in the gemspec is too restrictive.

:+1: :rocket: :cake: :+1:


lint/param-name-checker: duplication checker v1

I'll take a look a bit later.

@Quasilyte i have moved it to sepatate file.

Dat interfacer. :)

CI failed with decl can be go/ast.Node (interfacer). I think we could merge that.

@fexolm, yep.


Error when i want download

https://paste.sv-studios.net/2mrjS97xwB

Only the direct download of episodes works because of hcaptcha.


DeadlineExceeded : With almost no load , what to do

Thanks for stopping by to let us know something could be better!
PLEASE READ: If you have a support contract with Google, please create an issue in the support console instead of filing on GitHub. This will ensure a timely response.
Please run down the following list and make sure you've tried the usual "quick fixes":

Search the issues already opened: https://github.com/googleapis/google-cloud-dotnet/issues
Search Stack Overflow: http://stackoverflow.com/questions/tagged/google-cloud-platform+dotnet

If you are still having issues, please be sure to include as much information as possible:
Environment details

OS: Windows
.NET version: 6
Package name and version: Google Cloud Datastore v1 4.2

Steps to reproduce

its intermittent

Making sure to follow these steps will guarantee the quickest resolution possible.
Thanks!

I'm afraid we really don't have enough information to go on here - we don't know what operations you're trying, what your code looks like etc.
I'd note that the Google.Cloud.Datastore.V1 package is currently at 4.5.0 - I doubt that any changes in the last 9 months are relevant, but it's worth updating.
If you could provide more detail around which operation is timing out, what else you're doing, where the code is running (on GCP vs on-prem) etc, that would make it a lot easier to help you. If you can provide a minimal but complete console app that demonstrates the problem, that would be even better.

So are you saying you get the error on all of those operations? Or only some of them? Have you measured how long the call is active for before it fails? What's the network environment?
In terms of "what can be checked", basically whatever information you can provide to help us reproduce the matter, as well as timing information, would be useful.

It fails on some of the operations (not all) . Normally I will get the response immediately but some times  it takes time , and whenever it takes time , i will know the operation will fail with deadline exceeded , the same operation when is retried (i added a retry logic for deadine exceeded)  and it will work the next time, but issue is - this exception is thrown when there is almost no load , what if the load increases , will it happen more .

It fails on some of the operations (not all)

So which does it fail on, and which does it not fail on? Have you tried to reproduce this in a simple console app? You've said it's intermittent - how often are you seeing it?
I can't comment on what will happen under more load - that's not really a matter of what the client libraries do; you'd need to follow one of the routes on the Datastore Support page for more information about that.

Closing due to lack of information. If we get more information to help us reproduce, we can reopen this.


Add scrollToCursor configuration option rel: #103 #11

This was just a little enhancement that I thought would be desired, on new installs, or old installs, it should not have any effect on behavior unless the user chooses the option.

So, what's missing for this to be merged?

:+1:


Network failure on OneSignal.logoutEmail()

I've successfully registered an user e-mail after login using OneSignal.setEmail(email, callback), but when I call OneSignal.logoutEmail(callback) the following error is returned: Failed due to network failure. Will retry on next sync.. It doesn't seem to exist a network problem, otherwise .setEmail() wouldn't work. I'm using the following versions:
"react-native": "0.51.1"
"react-native-onesignal": "3.1.4"

@vgeorge Is this an issue with iOS or Android or both? Are using the latest 3.1.4 OneSignal React Native SDK?

@jkasten2 I've tested only on Android. If you mean "3.1.4 OneSignal React Native SDK" as this module  3.1.4 version, yes, this is the version.

@vgeorge if you see this issue again please let me know, otherwise I've been unable to reproduce it.


Add Windows functional tests

What this PR does / why we need it:
This PR adds the build_windows_containerdisks.sh script, which uses libvirt to run fully automated installations of OSes and packages them as containerdisks. It also adds functional tests for all supported OSes.
The following OSes are supported:

Windows 10
Windows 11
Windows Server 2016
Windows Server 2019
Windows Server 2022

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Special notes for your reviewer:
Release note:

None

Thanks for your work and the clarifications!
/lgtm

/override pull-common-instancetypes-kubevirt-functest
There is something borked in Prow.

/lgtm

Great job!

/cherry-pick release-0.4


Instagram call checkpoint for this action!

Instagram call checkpoint for this action!
how to fix this

+1
I have the same problem

+2
I have the same problem
Plz help

+3
I have also the same problem... When I try to authorize the app it looks like Instagram doesn't allow it.
Please if anyone that have this problem could solve it.

+4
I have the same problem..

I disable the account for about three hours and i still couldn't sign in.


fix(git): simplify and generalise "symlinked .git directory" check

This handles repo-managed working copies, and should be generic enough to handle most other cases (unless the symlink points to a child of an ancestor).

I haven't seen any false positives with this, including the case if the root of the working tree is a symlink.
See #900 for the PR that implemented the original check.

DO NOT SUBMIT THIS PR until I have tested this with Git worktrees. I have a suspicion that this will result in incorrect behaviour with them...

I just tested it with a worktree and it seems to work fine. Apologies for the false alarm - I haven't used worktrees before, so I wasn't sure about how things are handled in them...

Thanks!
This PR feels a bit risky, but from my (limited) testing it should be okay. I'll keep an eye out for any issues relating to this.


uiState is not updated properly after calling setUiState

🐛 Bug description
After calling manually setUiState from my custom menu component, the uiState object is not reflecting the change in the onStateChange event listener in the middleware.
🔍 Bug reproduction
https://codesandbox.io/s/svelte-forked-13ymr
On the above sandbox click on an entry in the custom menu. Check the console output (or URL params) to see the value of uiState object which is not reflecting the latest setUiState call. Actually it's always reflecting the previous value set.

Probably a duplicate of #4421

Hello @jonadeline ,
Thanks for the report! Indeed yours seems similar to #4421
Sorry for taking too long to get back to you. I will take a look at this as soon as possible and keep you updated.

Hey @jonadeline! You can see in that sandbox that setUiState works with HierarchicalMenu.
Steps

Click on the input
Select the "in Computers & Tablets" item
Notice that the category is refined

I didn't dig into your code but here are a few things that you can look for:

Is the correct attribute refined?
Is the UI state updated with the right value? (It should be of the format { hierarchicalMenu: { attribute: ['lvl0', 'lvl1'] } }
Is your Svelte app re-rendering on this UI state change?

So I don't think this is related to ##4421.

Bonjour François,

Yes the correct attribute is refined and the search results match what the user has selected.
The UI State format is alright but the value is not good when I console.log in the middleware. I get the previous value of the attribute. So the URL params are wrong and I'm not able to highlight the current category in my menu (as my code is based on the uistate value)
Yes,  I enabled the reactivity in my menu component whenever the uistate change in order to highlight the right category.

Hi @francoischalifour,
By any chance did you check my sandbox code ?
Im still struggling with this and didnt find any good workaround at the moment.
Merci !

Hi @francoischalifour,
By any chance did you check my sandbox code ?
Im still struggling with this and didnt find any good workaround at the moment.
Merci !

Hi! We're doing a round of clean up in this repository. This issue seems not to have generated much activity lately. Is it still relevant?


Object of class Illuminate\Foundation\Application could not be converted to string

Bug description
When running, in yet unknown conditions, an error occurs.
PHP Fatal Error: Uncaught Error: Object of class Illuminate\Foundation\Application could not be converted to string in Command line code:6
To Reproduce
Run a tinker console window
Expected behavior
The error should not have appeared and output following my code in
Screenshots
None
Environment (please complete the following information):

IDE & Version: PHPStorm 2020.2.1
PHP Version: 7.4
Interpreter Type: Docker
Laravel Version: 7.3.0
Tinker version: 2.3.0

Additional context
It seems to work with docker run, but not with docker exec in one of my projects.

I can also confirm it only happens if docker exec is used.

I can also confirm it only happens if docker exec is used.

Thanks! That helps.
Now to find out why :P

The script does $app = require_once(__DIR__ . '/bootstrap/app.php'); and for some reason, passing that into a docker exec from PhpStorm makes php think it needs to parse it to a string. For some reason I think this is a bug within PHPStorm and how they pass it to the CLI.

Hello! Testing again your plugin after you resolved https://github.com/Roboroads/laravel-tinker/issues/46 I now face this issue.
PHP Fatal error:  Uncaught Error: Object of class Illuminate\Foundation\Application could not be converted to string in Command line code:8
Stack trace:
#0 {main}
  thrown in Command line code on line 8
255

As I said on the other issue, I'm working on Windows with a Sail environment. The cli interpreter seems fine to me, as well as the path maping. If you need more informations, please ask.

Yes, this is not fixed as said in the release notes:

This does not fix the "string conversion" error found when using docker exec. You still have to use docker run for now.

I found a way to proof to JetBrains this is also a double-dollar-escaping bug.
"[docker-compose://[/home/robbin/Robbox/Werkmap/Wereldrestaurant Puur/project-panda/docker-compose.yml]:service-php/]:php" -dxdebug.mode=debug -dxdebug.client_port=9000 -dxdebug.client_host=<IP_ADDRESS> -r eval('var_dump('.chr(36).'argv[1]);'); "$x = 123;"
string(10) "$$x = 123;"

Sent this to JB - might get fixed in 2022.2 ^^

JB 2022.2 fixes this. Closing.

Tested with 2022.3 and still sees this as a problem, running app inside a docker container
// Laravel Tinker started at 2022-09-07 20:02:39
Fatal error: Uncaught Error: Object of class Illuminate\Foundation\Application could not be converted to string in Command line code:8
Stack trace:
#0 {main}
thrown in Command line code on line 8
ERROR: 255
*** Execution finished ***

@hertzelarmengolbf You might want to check your version again. 2022.3 is not out yet, not even as beta :P


Pre/Post deploy script hangs

Just updated the pre post deployment script with the latest changes from this article. The version we were using is from around november 2019 and that version works perfectly.
Updated to the latest version of the script and now our CD pipeline hangs during pre deployment. Had to revert to the previous version, since there is a bug in the newly updated powershell script.
Please fix and update

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 1e22e4d6-366f-fbf8-e141-8905ca7ab7ae
Version Independent ID: 5be2acf2-66e7-cadf-6666-5a85a65b9771
Content: Continuous integration and delivery in Azure Data Factory - Azure Data Factory
Content Source: articles/data-factory/continuous-integration-deployment.md
Service: data-factory
GitHub Login: @djpmsft
Microsoft Alias: daperlov

At which step was it hanging?

It hangs during pre-deployment in the while loop. It succesfully disabled one trigger out of 10ish, then it just hangs.

This looks like this may be better handled as part of a support case. Would it be possible to open it there?
Otherwise could you provide the trace correlation id, or at the very least the trigger name, factory name, region, and approximate time when the timeout occurred
cc @KranthiPakala-MSFT

Thanks for your inputs @djpmsft.
@mikanyg For deeper investigation and immediate assistance, If you have a support plan you may file a support ticket, else could you please send an email to<EMAIL_ADDRESS>with the below details, so that we can create a one-time-free support ticket for you to work closely on this matter.
Email subject: <Attn - Kranthi : GitHub issue Title>
Thread URL:
Subscription ID:
Other details: <Please provide the trace correlation id, or at the very least the trigger name, factory name, region, and approximate time when the timeout occurred>

@mikanyg Any update on this issue?

Just send an email to<EMAIL_ADDRESS>with detailed information. We are currently using the original script version from 2019.

Hi @mikanyg , thanks for sharing the details.
@djpmsft Here is the SR# -<PHONE_NUMBER>01987 for this case.
Since we have a SR to track this case, we will now proceed to close this thread. If there are further questions regarding this matter, please tag me in your reply and reopen the issue. We will gladly continue the discussion.

@mikanyg , I'm having the same problem. how did you solve yours?

Same here

Hey- have made a fix for the issue- please find the sections below.

Replace the current "$predeployment -eq $true" block with this

if ($predeployment -eq $true) {
#Stop all triggers
Write-Host "Stopping deployed triggers"
$triggerstostop | Sort-Object Name | ForEach-Object {
Write-host "Disabling trigger " $_
Stop-AzDataFactoryV2Trigger -ResourceGroupName $ResourceGroupName -DataFactoryName $DataFactoryName -Name $_ -Force
}
}

Still on post deployment section on the last 'Start active triggers' section you will need to replace with this-
#Start active triggers - after cleanup efforts
$activeTriggerNames = $triggersTemplate | Where-Object { $.properties.runtimeState -eq "Started" -and ($.properties.pipelines.Count -gt 0 -or $.properties.pipeline.pipelineReference -ne $null)} | ForEach-Object {$.name.Substring(37, $.name.Length-40)}
Write-Host "Starting active triggers"
$activeTriggerNames | ForEach-Object {
Write-host "Enabling trigger " $
While (!(Start-AzDataFactoryV2Trigger -ResourceGroupName $ResourceGroupName -DataFactoryName $DataFactoryName -Name $_ -Force -ErrorAction SilentlyContinue)) {
Sleep -Seconds 5
}
}

Hope this helps

The change above works after the underscore problems are fixed - the underscores are missed in a few places.


Not loading components

Describe the bug
After update to 0.3.3 doesn't load components anymore
Screenshots

package.json contains
  "main": "dist/carousel.js",
  "module": "dist/carousel.es.js",

If you're using Nuxt, it prefers the value in main.
Temp workaround is to specify the full path of the module.
import { Carousel, Slide, Pagination, Navigation } from 'vue3-carousel/dist/carousel.es.js'

If you're using Nuxt, it prefers the value in main.
Temp workaround is to specify the full path of the module.

import { Carousel, Slide, Pagination, Navigation } from 'vue3-carousel/dist/carousel.es.js'

Yeah that's what I did. Thanks anyway!

I'm also encountering the same issue in a Nuxt 3 environment. By specifying the full path of the module, runtime errors are avoided, but I'm unable to fetch the type information, leading to import errors in TypeScript. This might be a basic question, but could anyone provide a solution to this problem?

I'm also encountering the same issue in a Nuxt 3 environment. By specifying the full path of the module, runtime errors are avoided, but I'm unable to fetch the type information, leading to import errors in TypeScript. This might be a basic question, but could anyone provide a solution to this problem?

There is a problem if use it in Typescript:
Could not find a declaration file for module 'vue3-carousel/dist/carousel.es.js'. 'node_modules/vue3-carousel/dist/carousel.es.js' implicitly has an 'any' type.
  Try `npm i --save-dev @types/vue3-carousel` if it exists or add a new declaration (.d.ts) file containing `declare module 'vue3-carousel/dist/carousel.es.js';`


Debug install fails with no diagnostics if 'dotnet --info' doesn't return the RID

Repro steps:

Install older build of .NET CLI (build 2202 seems to work)
Install VS Code+C# extension
Try to restore debugger

Result:
Error saying "Error while installing .NET Core Debugger" whenever I open VS Code with the extension installed. When I hit the "View Log" button next to it, nothing happens (no log opens).
Notes:
On the following line, we will throw an error if the dotnet --info doesn't return the RID:
https://github.com/OmniSharp/omnisharp-vscode/blob/master/src/coreclr-debug/util.ts#L137
But the error from the exception is dropped on the floor here:
https://github.com/OmniSharp/omnisharp-vscode/blob/master/src/coreclr-debug/main.ts#L89
Suggested changes:

Write the call and output from dotnet --info to the log
Write the error message to the log

@MattGertz I know you were asking about upgrade testing. Do you care enough about this scenario that you would want to take the fix, or should we move this to RTM?

RTM, and we can educate in the interim.

Fixed for post-RC2


Instance Classification

Is your feature request related to a problem? Please describe.
Using the OpenStack API a list of instances is retrieved. The list includes instances created by Kubernikus as well as other VMs. That list is fed into an external system (Tennable.io) for analysis.  It should be possible to identify which instances were created by Kubernikus.
Describe the solution you'd like
Kubernikus should set a label on the instance.
Kubernikus should periodically check and reapply label.
Kubernikus should apply labels to already existing instances without recreating the instance.
Describe alternatives you've considered
A suitable alternative would be a naming convention. e.g. a prefix for the instance name like kubernikus--#CLUSTER--$POOL--$ID. Though this probably requires to recreate existing instances.

Done and Depoyed


Update concepts-workbooks.md (Typo "flexible server"→"Flexible Server")

https://github.com/MicrosoftDocs/azure-databases-docs/blob/main/articles/mysql/flexible-server/concepts-workbooks.md #PingMSFTDocs

@code-sidd
Can you review the proposed changes?
Important: When the changes are ready for publication, adding a #sign-off comment is the best way to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@code-sidd - related #12

@hyoshioka0128 - Please review my suggested change and resolve the merge conflict in the file.


Error updating plugin (node:32011)

get this error at starting hyper

Have the same issue.

Yup. The issue still remains on Linux Mint 19.3 (Cinnamon 4.4.8 / Linux 5.4.0-42-generic).

@bolex222 it's because the dependencies are outdated. Especially babel and webpack. I've made a PR to update them and the errors are taken care of. The plugin works with the latest version of Hyper.
However, I don't know if this project is still being maintained.
If you want to you can clone my master fork into ~.hyper_plugins/local/, run yarn and then yarn run build and add 'hyperline' to localPlugins array in the hyper.js config file.
I'm on Ubuntu 20.04 but I believe it should work for others using latest Hyper.
My pull request: #195

Thx @emmanuelnk! hope your PR will be accepted

I'm on Ubuntu 20.04 but I believe it should work for others using latest Hyper.
My pull request: #195

@emmanuelnk - Great work ;-)

Works perfectly on Mint 20 LTS.


Flaky test: TestExec: expected "success\n", got ""

https://github.com/containerd/nerdctl/runs/6202046578?check_suite_focus=true
=== CONT  TestExec
    exec_test.go:34: assertion failed: error is not nil: expected "success\n", got ""
--- FAIL: TestExec (0.85s)

Potentially regression in #1014 (unconfirmed)

Also see this happen:
https://github.com/containerd/nerdctl/runs/7300392623?check_suite_focus=true#step:6:839
=== CONT  TestExecWithDoubleDash
    exec_test.go:46: assertion failed: error is not nil: expected "success\n", got ""

https://github.com/containerd/nerdctl/runs/7300393595?check_suite_focus=true#step:5:915
=== CONT  TestRunCgroupV2
    run_cgroup_linux_test.go:110: assertion failed: error is not nil: expected "42000 100000\n44040192\n44040192\n42\n77\n0-1\n0\n", got ""

seems all these cases happen when exec on a -d container,  might be exec before the container process start? @AkihiroSuda


Setting Poetry Version

Docker needs a specific Poetry Version.
This will standardize versioning between Docker and the codebase
Make sure you have tested all your changes on your local set up before opening PRs!
Changes Done
[Describe the changes implemented]
Why?
[What problem is this PR addressing?]

Add any relevant issue links

Testing
[How did you test your chagnes?]

This section is very important and a PR should not be approved without proper test details
Please include a summary of unit tests for these changes

NEXT TIME FOLLOW THE PR TEMPLATE


Memory issue : After typing just one char more than set count

Say if i need only 4 char OTP.  While by human error i touched 5th char, it gives memory issue and crashes

Have this addtional condition check for self.text.length > _count in updateText functionn
- (void)updateText {     if (_count < 1 || self.text.length > _count) {         return;     }


docs: Added documentation for forms in React, covering controlled/uncontrolled components, validation, and submissions.

📑 Description
Covered everything for the React Forms page by modifying the forms.mdx and added corresponding to that 2 folders in codes > forms.
✅ Checklist

[x] I have made corresponding changes that follow the style of this project.

🔗 Related Issue(s)

Fixes #28
🚀 Types of changes

[x] Documentation update (docs for this project)

📸 Screenshots (if applicable)

💬 Additional Comments (if applicable)

Hi, Can you please add the 'Hacktoberfest-accepted' and 'gssoc-extended' labels to this ?

Hey @Shrey0610 ,
Thank you for your valuable contribution, but we are sorry to say that currently we support only hacktoberfest.

Thank You!

Hey @Shrey0610 , Thank you for your valuable contribution, but we are sorry to say that currently we support only hacktoberfest.

It's ok, thank you, I'll try to add other's docs in some time.

Hey @Shrey0610 , Thank you for your valuable contribution, but we are sorry to say that currently we support only hacktoberfest.

It's ok, thank you, I'll try to add other's docs in some time.

Sure!


Code parsing error

Line 10: The method attack() requires an argument.
It's got one though.

Hi, sorry about that. I fixed it, but please let me know if you see any more problems.


Casmpet 6173 main

Summary and Scope
Removed switches from the cray-certmanager chart and extraArgs that seem to be causing issues when ran through loftsman.
Issues and Related PRs
List and characterize relationship to Jira/Github issues and other pull requests. Be sure to list dependencies.

Resolves [issue id](issue link)
Change will also be needed in <insert branch name here>
Future work required by [issue id](issue link)
Documentation changes required in [issue id](issue link)
Merge with/before/after <insert PR URL here>

Testing
List the environments in which these changes were tested.
Tested on:

<development system>
Local development environment
Virtual Shasta

Test description:
How were the changes tested and success verified? If schema changes were part of this change, how were those handled in your upgrade/downgrade testing?

Were the install/upgrade-based validation checks/tests run (goss tests/install-validation doc)?
Were continuous integration tests run? If not, why?
Was upgrade tested? If not, why?
Was downgrade tested? If not, why?
Were new tests (or test issues/Jiras) created for this change?

Risks and Mitigations
Are there known issues with these changes? Any other special considerations?
Pull Request Checklist

[x] Version number(s) incremented, if applicable
[ ] Copyrights updated
[ ] License file intact
[ ] Target branch correct
[ ] CHANGELOG.md updated
[ ] Testing is appropriate and complete, if applicable
[ ] HPC Product Announcement prepared, if applicable

Found one other quick fix and rebased the pr. Was "missing quotes around false" in a pod annotation label.


providerDomain is empty in invite URL

We should fix this issue twice:

make sure our JS code gets the non-empty token and providerDomain strings
if our JS code is unable to get both of them as non-empty strings, an error should be displayed instead of displaying the broken invite URL

Fixed in both the sciencemesh and the oc-10-take-2 branch


Remove audio & video methods from post

Sorry, I'm rushing before RC to try to get rid of things that I would really don't want to see anymore in Timber and that's my last chance to introduce breaking changes 🙂
Feel free to disagree of course ;)
Issue
Those methods do not really make sense. Since Post is kind of a DTO object, it should not extract html content from post_content. Theoretically, this would mean we could have some methods like paragraphs() or headings().
Solution
Remove them.
Impact
Yes, methods aren't available anymore.
Usage Changes
No more {{ post.audio }} or {{ post.video }}
Considerations
If users asks for these, we could introduce more generic filters to extract some HTML from content.

Coverage: 88.602% (-0.02%) from 88.623% when pulling 0847681e9e6c5c5ae89f7483dbfc395cf2cc6744 on 2.x-remove-audio-video into 3d6bb88abf90eb54dc3f234be9c394a71f58fd63 on 2.x.


Soul Lantern, Netherite Ingot, and Netherite Axe are all 32x31 pixels in the Natural Texture Pack

Barely noticeable, but it's there.

Will be fixed in the next release


Implement Signed Distance Fields for 2D shaders

SDF Support

2D Occluder Polygons now have the option to become geometry to generate the SDF
New functions added to 2D shaders:

vec2 screen_uv_to_sdf(vec2 screen_uv);
vec2 sdf_to_screen_uv(vec2 sdf_pos);
float texture_sdf(vec2 sdf_pos);
vec2 texture_sdf_normal(vec2 sdf_pos);

SDF operates in screen-relative global coordinates (pre-canvas transform), so its easy to measure distances in your shaders, as they use the same units as your game.
Example:
The following shader allows to make long drop shadows.

Code:
shader_type canvas_item;
render_mode unshaded;

uniform vec4 color : hint_color;
uniform float angle : hint_range(0,360);
uniform float len : hint_range(0,1000) = 300;
uniform float fade_margin : hint_range(0,100) = 5;

void fragment() {

	float ang_rad = angle * 3.1416 / 360.0;
	vec2 dir = vec2(sin(ang_rad),cos(ang_rad));
	float max_dist = len;
	vec2 at = screen_uv_to_sdf(SCREEN_UV);
	float accum = 0.0;

	while(accum < max_dist) {
	    float d = texture_sdf(at);
	    accum+=d;
	    if (d < 0.01) {
	        break;
	    }
	    at += d * dir;
	}
	float alpha = 1.0-min(1.0,accum/max_dist);
	if (accum < fade_margin) {
		alpha *= max(0.0,accum / fade_margin);
	}

	COLOR = vec4(color.rgb,alpha * color.a);
}

TODO
In the future it may be possible to optionally toggle a canvaslayer for sdf generation, so its not only limited to occluder polygons, but this will most likely have an increased cost, given rendering the screen oversized (like 1.x to 2.x the margins) is required to have useful SDFs (and this also requires more shader variants compiled). Most likely post 4.0 material.

Can this implementation also be used to smooth edges of vector shapes?

@starry-abyss no, while it is possible to convert vector shapes to SDF to some extent (and I would like to work on that at some point), that is something entirely different.

Thanks!

Will there be any documentation/sample/demo in the Godot's docs explaining SDFs for newbies, and also - their potential use cases?

@dreamsComeTrue Yes, we will work on docs and demos once the API is finalized. Expect them close to release.


Added missing types to the PhpdocTypesFixer

I've picked from https://github.com/phpDocumentor/TypeResolver/blob/0.5.0/src/TypeResolver.php#L47 the types that we missed. I'll also need to send back to them the types they missed.

tests are missing. I don't like features/bugfixes passing without touching tests

Sure, can add more tests. I don't think our existing tests cover that whole array as is anyway, but sure, can add more tests.

Will do tomorrow, will need to pull down the code to my laptop.

Thank you @GrahamCampbell.


 has a few bugs

I have gone through these following points

[X] Check latest documentation: https://docs.nativebase.io/
[X] Check for existing open/closed issues for a possible duplicate before creating a new issue: https://github.com/GeekyAnts/NativeBase/issues
[X] Use the latest NativeBase release: https://github.com/GeekyAnts/NativeBase/releases
X] Check examples from NativeBase KitchenSink https://github.com/GeekyAnts/NativeBase-KitchenSink
[X] For discussion purpose make use of NativeBase Slack: http://slack.nativebase.io/
[X] For queries related to theme, check Theme Variables from Docs and live NativeBase Theme Editor http://nativebase.io/customizer/

Issue Description

node, npm, react-native, react and native-base version, expo version if used, xcode version
Current/Master
I've been trying to adjust the  component with a floating label prop and font size changes. During the process, I've seen some bugs (and ended up creating a new Item component)
1- Do not use type.displayName. Strings are mangled during production builds and names will be not the same.
https://github.com/GeekyAnts/NativeBase/blob/master/src/basic/Item.js#L105
https://github.com/GeekyAnts/NativeBase/blob/master/src/basic/Item.js#L170
https://github.com/GeekyAnts/NativeBase/blob/master/src/basic/Item.js#L249
2- Font size (for me at least) isn't working, looks like this hardcoded 15 is the culprit:
https://github.com/GeekyAnts/NativeBase/blob/master/src/basic/Item.js#L403
3- Overall, the animation to top/bottom really only works fine with the default library styles, any change to fonts or sizes will make it pretty much broken (too much floating to top, bottom, etc.). I'm not sure how to fix this globally and being backwards compatible, but I suggest not hardcoding the values at the Input component and neither at the related Input styles class.
Here are a few suggestions:

use inputFontSize and contentPadding from variables to decide how much to animate to top
do the same for the Item['.floatingLabel'] style. It is currently very hackish with lots of magic heights, top, margins, etc, it could be much simpler.

Hi @cristianoccazinsp , please provide snack for the same. It will be easy for us to reproduce the issue.

I've tweaked quite a few styles and components in the project I'm using this library, so I'm not sure if a snack will work with the original's library code.
I can provide the code for the components and styles I've updated, but that might be too much code.  I also had some issues with the latest updates to footer/content (related to SafeAreaView and rotation) so I also had to customize those.

Hi @cristianoccazinsp , please update to latest native-base v2.13.14 . Let us know if the issue still persists?

Hello @hanykumar , thanks for the update, but we are using our own  component now alongside a fork of the library to resolve other issues.

Closing for now.
Thanks


fix fix and optimize iceberg v2 reader

Proposed changes
Issue Number: close #xxx
Problem summary
Describe your changes.
Checklist(Required)

Does it affect the original behavior:

[ ] Yes
[x] No
[ ] I don't know

Has unit tests been added:

[ ] Yes
[x] No
[ ] No Need

Has document been added or modified:

[ ] Yes
[x] No
[ ] No Need

Does it need to update dependencies:

[ ] Yes
[x] No

Are there any changes that cannot be rolled back:

[ ] Yes (If Yes, please explain WHY)
[x] No

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 34.72 seconds
load time: 631 seconds
storage size:<PHONE_NUMBER>6 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20221222163637_clickbench_pr_67492.html


Merlin autocomplete not updated for polymorphic variants.

of keyword has been removed from Reason. But merlin still shows it.
cc @jordwalke

This should simply be a matter of deleting the of keyword in the outcome printer. Marking as good first task.


buffer: add offset param

This looks fine; just curious, do you plan to actually rely on this for something?

Yes its important for updating a portion of a buffer

This looks fine; just curious, do you plan to actually rely on this for something?

Yes its important for updating a portion of a buffer

Yeah I understand; my question was whether you actually use that feature or not yet.

This looks fine; just curious, do you plan to actually rely on this for something?

Yes its important for updating a portion of a buffer

Yeah I understand; my question was whether you actually use that feature or not yet.

I don't believe I'm using it yet...  I think we need some logic at a higher level to see which portion of the buffer has changed, or expose this to the user at the node API level


DPL-058-01: Versioned API

Closes: #394
Decided it was best to start with the Crawler API since it's much smaller and lets us focus on the architecture of the solution.  The V1 blueprint is the only one at the moment and gets served at both https://crawler-url.sanger/cherrypick-test-data and also at https://crawler-url.sanger/v1/cherrypick-test-data.
In practice I will update the URL being used by Lighthouse and then I'll drop the unversioned endpoint.
When adding a /v2/ API, the common logic for the existing endpoint can go in another module that isn't decorated.  Each of the two blueprints (v1 and v2) can then call that common module to keep things clean.  If the new endpoint is significantly different, then the logic flow can be directed as needed from these blueprints.

Looks good, only thought is the use of "cherrypicker", could it be "cherrypick" to be consistent?

Thanks @harrietc52 .  I think I'll not rename it at this stage.  It's been cherrypicker in the module names since just after I started working on Crawler and not relevant to the change I'm making here.  The endpoints are at least cherrypick-test-data.  I didn't know enough about the naming preferences when I started a couple weeks back.


Setup Travis build

Should close #3
Example of the build: https://travis-ci.org/crystal-community/bluetooth/builds/440098299

Build probably has got stuck. I will check it again later.

@veelenga It's ok, current specs fails because the BLE part get stuck, I'll fix that in a sec, I'll remote the specs for it until we can understand why it wont work.

@veelenga wait... does the CI testing ENV even have a BT device?
maybe it makes no sense to run spec and just see if everything compiles + ameba etc..

@bararchy what needs to be done to setup the app/tests? Do you use some Bluetooth emulator?


How to use this repo to do syntax highlighting?

Are there any resource/tutorial on how to do markdown syntax highlighting by using this package?

I too am looking for ways to use swift-markdown for syntax highlighting. Believe once markup.range is able to give absolute index one can build this. This is added as a feature request already

MarkdownView can highlight with SwiftUI.


Document transitive dependency exclusion

Users of this library would normally want to exclude the unused HTTP client libraries brought in by the AWS SDK so they don't interfere with anything.
This should work, right?
"software.amazon.awssdk" % "sns" % AwsSdk2Version excludeAll (
          ExclusionRule("software.amazon.awssdk", "netty-nio-client"),
          ExclusionRule(organization = "io.netty"),
          ExclusionRule("org.apache.httpcomponents", "httpclient")
),

This looks good to me.
In the build.sbt (in this repo) I exclude netty-nio-client (in the test dependencies), because of how Service Loading works for the AWS (async) clients. Otherwise you need to explicitly declare which implementation to use as the underlying http provider for the aws client.
I have not excluded "org.apache.httpcomponents", "httpclient". This would be for a cleaner Classpath I guess?!
I had a quick look in my local Classpath and did a quick test. For me it even works to exclude "software.amazon.awssdk", "apache-client". This will get rid of some more (I guess) unnecessary dependencies. I haven't checked in Alpakka though.

Great, excluding the apache-client makes it even slimmer. As a library provider you need to be very strict with pulling in dependencies, especially widely used once may interfere with other user code.
In Alpakka I go with this now:
        "software.amazon.awssdk" % "sns" % AwsSdk2Version excludeAll // ApacheV2
        (
          ExclusionRule("software.amazon.awssdk", "apache-client"),
          ExclusionRule("software.amazon.awssdk", "netty-nio-client")
        ),
        // overriding AWS SDK version to avoid https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2019-12086
        "com.fasterxml.jackson.core" % "jackson-databind" % "2.9.9",

Yes, I understand this! :+1:
Can the issue be closed?

I thought it might be an idea to add this information to the readme of this project.

Yes, you are right. This is a good idea. As soon as you depend on a specific service (s3, sqs), you potentially have this issue, which you can run into.

@ennru, do you want to add something or is it what you had expected?

All users will want to exclude "software.amazon.awssdk", "apache-client", right?
You choose this library to use Akka HTTP instead.

Yes, I think users can also exclude "software.amazon.awssdk", "apache-client", but this is more optional I would think. Whereas the included Netty client can cause trouble as both (Netty and Akka-http) are implementations for the async http client.
I can put it as an additional optional step to further trim the class path.

@ennru, I added an additional section. Can you check 3051fbe?

Sure, that's great.


[Feature] Big Query integration

Summary
Another user requested for Big Query integration. I've heard this a few times.

closing this in favour of #3129 because there's more action going on there


Implement a New User Interface

Related Issue*
Closes https://github.com/mahaveergurjar/Chatbot/issues/33
Description
This PR introduces a new user interface design and several improvements to the chat section. Below are the key changes:

New Input Section: Redesigned the input area for improved user experience.
Background Color: Updated the background color to match the new design theme.
Chat Bubble Colors: Changed the color scheme for both user and bot chat messages to enhance readability and aesthetics.
Send Icon Update: Removed the old send icon and replaced it with a new, modern icon.
File Icon Update:  Replaced the old file icon with a more updated version for better visual consistency.
Header Update: Made adjustments to the header design to align with the new UI style.
Image Preview Fix: Resolved issues with image preview functionality, ensuring proper display of images in the chat.

Screenshot Section

Thanks


Chat performance

Codecov Report

Merging #107 (6e2e88b) into master (9be4815) will decrease coverage by 0.02%.
The diff coverage is 27.69%.

@@            Coverage Diff             @@
##           master     #107      +/-   ##
==========================================
- Coverage   30.66%   30.63%   -0.03%
==========================================
  Files          67       67
  Lines       13668    13697      +29
  Branches      212      213       +1
==========================================
+ Hits         4191     4196       +5
- Misses       9265     9288      +23
- Partials      212      213       +1

Impacted Files
Coverage Δ

src/clj/skylobby/fx/channel.clj
14.97% <0.00%> (ø)

src/clj/skylobby/fx/ext.clj
40.65% <14.28%> (-2.20%)
:arrow_down:

src/clj/skylobby/fx/rich_text.clj
48.71% <37.50%> (-7.81%)
:arrow_down:

src/clj/skylobby/fx/console.clj
31.57% <100.00%> (-4.14%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9be4815...6e2e88b. Read the comment docs.


Cannot set :raise_errors => false in a request when client has it set to true

If the client is set to :raise_errors => true, then specific requests cannot override that value.
Use case: GoogleDocs API normally just returns data, but in some cases (e.g. resumable upload protocol) I need to access the exact error to know what to do next.
https://github.com/intridea/oauth2/blob/master/lib/oauth2/client.rb#L107:
raise e if opts[:raise_errors] || options[:raise_errors]

should be:
raise e if opts.fetch(:raise_errors, options[:raise_errors])

or
raise e if opts.has_key?(:raise_errors) ? opts[:raise_errors] : options[:raise_errors])

so it does not fallback with a false value.

I wanted to know what error I got from Google as well, so I monkeypatched it to raise errors regardless.
# https://github.com/intridea/oauth2/blob/master/lib/oauth2/client.rb#L107
raise e #if opts[:raise_errors] || options[:raise_errors]

Not ideal, but it helped greatly.


Flex does not center the node and node does not respond to height change in window.

In version "0.11.2"
I wanted to place an image in the centre and keep its height 100% of the window and width proportional to the height (keep the aspect)
This is the equivalent of flex in CSS.
<!DOCTYPE html>

    <meta charset="UTF-8">
    <title>Title</title>

but the behaviour in Bevy is different:
use bevy::prelude::*;

fn setup_camera(mut commands: Commands) {
    commands.spawn(Camera2dBundle::default());
}

fn setup_ui(mut commands: Commands, asset_server: Res<AssetServer>) {
    commands
        .spawn(NodeBundle {
            style: Style {
                height: Val::Vh(100.0),
                display: Display::Flex,
                align_items: AlignItems::Center,
                justify_content: JustifyContent::Center,
                ..default()
            },
            ..default()
        })
        .with_children(|parent| {
            parent.spawn(ImageBundle {
                style: Style {
                    height: Val::Percent(100.0),
                    width: Val::Auto,
                    ..default()
                },
                image: UiImage::new(asset_server.load("ui/main-menu.png")),
                ..default()
            });
        });
}

fn main() {
    App::new()
        .add_plugins(DefaultPlugins)
        .add_systems(Startup, setup_camera)
        .add_systems(Startup, setup_ui)
        .run();
}

Can you reproduce this on this branch? https://github.com/bevyengine/bevy/pull/9637

I can reproduce this on top of #9637 (I have to add width: Val::Vw(100.0), to the outer node to account for the changes in #9637 and make the outer node fill the width of the screen).
Adding an explicit aspect_ratio: Some(1.0) style (replace 1.0 with the actual aspect ratio of your image) produces the behaviour which I believe you want / are expecting. But for some reason the image's inherent aspect ratio doesn't seem have any effect on it's final size/position.

Hmm... interestingly it also does seem to work if the parent node is Display::Grid (with justify_items: JustifyItems::Center, set)

This is indeed a Taffy bug. Fix incoming.

@Hossein-Noroozpour Taffy v0.3.14 has been released with a fix for this issue. You can get the fix by running cargo update.


check IE11 support

see https://github.com/gravitystorm/openstreetmap-carto/issues/1630#issuecomment-244412874

I don't know if you're aware of it, but there are free (as in beer) Windows virtual machines for testing different MSIE versions:
https://developer.microsoft.com/en-us/microsoft-edge/tools/vms/

@Ircama: IE11 should now work, can you double-check it please?

@Ircama: IE11 should now work, can you double-check it please?

It works fine now.
Thanks and congrats for this tool


Enable audio build on Windows with CUDA

With this PR, audio could be build on Windows with CUDA now.
It's from https://github.com/pytorch/audio/pull/1777
I've verified it locally.

@mthrok
Did you miss removing something related in this commit.
https://github.com/pytorch/audio/commit/0f82217914c84f02ceab3d35ffdf2c2296836eda#diff-1e7de1ae2d059d21e1dd75d5812d5a34b0222cef273b7c3a2af62eb747f9d20a

without this, there's one error locally.

cc @malfet

@mthrok
Did you miss removing something related in this commit.
0f82217#diff-1e7de1ae2d059d21e1dd75d5812d5a34b0222cef273b7c3a2af62eb747f9d20a

without this, there's one error locally.

cc @malfet

The deletion itself is as-intended. The option was removed because libtorchaudio should be built all the time. libtorchaudio is where all the C++ implementation that do not require libpython dependency is placed.
What I might have missed is to check if the extension .dll is/should be recognized by setuptools.
The logic there is that;

python setup.py build_ext invokes the compilation of extension module, expecting torchaudio._torchaudio and torchaudio.lib.libtorchaudio.
cmake builds libtorchaudio and _torchaudio.
For Linux and macOS they are libtorchaudio.so and _torchaudio.so. For Windows _torchaudio has to have pyd extension but I am not sure about libtorchaudio as it is C++ library without any Python component.
python setup.py install picks up the compiled modules from build directory and place it in the installation location.
Your error indicates that setuptools expect the libtorchaudio to have extension .pyd but, currently CMake produces libtorchaudio.dll thus setuptools cannot find libtorchaudio.

I am not sure what's the right fix for Windows, but one way it might work is to set the extension of libtorchaudio to pyd as well. You can try adding this for libtorchaudio here, then change this line from dll to pyd.

I am not sure what's the right fix for Windows, but one way it might work is to set the extension of libtorchaudio to pyd as well. You can try adding this for libtorchaudio here, then change this line from dll to pyd.

Thanks @mthrok . It works now. I've submitted another PR https://github.com/pytorch/audio/pull/1788 for these change.
Once #1788 is merged, It can  be merged.


Convert to strict mode (through test/unit/specs/store).

Convert all files below (and any new ones in the relevant directories) to strict mode by adding "use strict" as the first line and correct any strict mode violations that occur as a result.
test/unit/specs/components/govern/ChartVotes.spec.js
test/unit/specs/components/govern/LiProposal.spec.js
test/unit/specs/components/staking/LiDelegate.spec.js
test/unit/specs/components/staking/PageBond.spec.js
test/unit/specs/components/staking/PageStaking.spec.js
test/unit/specs/components/staking/PageValidator.spec.js
test/unit/specs/components/staking/PanelSort.spec.js
test/unit/specs/components/wallet/PageSend.spec.js
test/unit/specs/components/wallet/PageTransactions.spec.js
test/unit/specs/components/wallet/PageWallet.spec.js
test/unit/specs/components/wallet/TmModalSendConfirmation.spec.js
test/unit/specs/lcdClient.spec.js
test/unit/specs/lcdClientMock.spec.js
test/unit/specs/main.spec.js
test/unit/specs/node.spec.js
test/unit/specs/releasePullRequest.js
test/unit/specs/root.spec.js
test/unit/specs/routes.spec.js
test/unit/specs/rpcWrapper.spec.js
test/unit/specs/rpcWrapperMock.spec.js
test/unit/specs/scripts/num.spec.js
test/unit/specs/scripts/tx-utils.spec.js
test/unit/specs/store/blockchain.spec.js
test/unit/specs/store/delegates.spec.js
test/unit/specs/store/delegation.spec.js
test/unit/specs/store/filters.spec.js
test/unit/specs/store/index.spec.js
test/unit/specs/store/json/txs.js
test/unit/specs/store/node.spec.js
test/unit/specs/store/notification.spec.js
test/unit/specs/store/onboarding.spec.js
test/unit/specs/store/send.spec.js
test/unit/specs/store/store.spec.js
test/unit/specs/store/themes.spec.js
test/unit/specs/store/user.spec.js
test/unit/specs/store/validators.spec.js
test/unit/specs/store/wallet.spec.js

See #1051.


"Half of band width" in a Vega expression?

I'm working on a bar chart, and I want to place the labels at 90 degrees, in the center of each bar.  This expression will get me the left edge of a bar:
{"scale": "x", field: "data.xvar"}

and this one will get me half the width of the bars:
{"scale": "x", band: true, "mult": 0.5}

but I don't know how to combine them.  I tried on a lark to stuff each expression into the offset property of the other, but that doesn't work.
What's the right way to do this?  Thanks!

From @jheer:

Labels often require both "anchor" positions and subsequent offsets. That is why they have dx and dy properties.

"X": {"scale": "x", "field": "data.xvar"},
"dx": {"scale": "x", "band": true, "mult": 0.5}

Et voila!
-jeff

Thanks!  This is very useful info.
One more question.  I am trying to render bar chart labels at an angle, to display all of them without smashing them together, while not rendering them completely sideways.  It seems I can't combine the dx property with angle in the way that I want:  When I say angle is 45 and dx is, e.g., 10, what happens is, the text is first rotated, then moved through a "local" dx of 10.  What I really want is for the text to move to the right by 10, and then rotate through the requested angle.  Is there any way to do that?
I hope this made sense :).


I like the functionality, but it's making vim slow.

This seems to make my vim slow, especially on bigger files. Why might that be?
Is it updating on every cursor/line movement?

Once @tarruda's NeoVim has a nice GUI made with Atom or something similarly customizeable, these rendering can be moved there.


Provisioning Error (OSX)

Unknown error: GPG error: exit status 2

Hello, can you do keybase log send from command line (or Keybase Shell if on Windows)? Thank you

np, 20947cb41647f8bd87093f2b1c

Is this during login?

Correct

Can you try to log in from command line? Command is keybase login.

My apologies, the issue is on "One-time shell to GPG" not on the login step

Nevermind, a restart seem to have cleared the issue. Possible issues is not handling delays on connections due to little snitch time to approve the window. Or possible delay on GnuPG/MacGPG2 key signing.

The logs suggested at some GPG problem.
▶ [DEBU keybase gpg_cli.go:336] 22f gpg: problem with the agent: Timeout
▶ [DEBU keybase gpg_cli.go:336] 231 gpg: signing failed: Operation cancelled

the GPG situation is not perfect, sometimes this happens because GPG_TTY not being set correctly by Keybase when shelling out. I'm glad your issue is resolved, though!

👍


Reduce size of container

Use  Archlinux or Alpine linux rather then full blown ubuntu

I made it with Debian, only 333MB
REPOSITORY          TAG                 IMAGE ID            CREATED             VIRTUAL SIZE
sydops/pdf2htmlEX        latest       d136351dfbf3        14 minutes ago      333.1 MB

Dockerfile is here.
https://github.com/SydOps/pdf2htmlEX_docker/blob/master/Dockerfile

Greate, Do you want to make that into a pull request?

I am not sure. It is totally new re-write Dockerfile, insatll pdf2htmlEX directly as software package.
It will be better to keep it as seperate docker image.


[FLINK-31882][sql-client] Fix sql client can't show result for DELETE statement when delete is pushed down

What is the purpose of the change
To fix sql client can't show result for DELETE statement when delete is pushed down
Brief change log
Check the ModifyOperation is DeleteFromFilterOperation or not  in OperationExecutor#callModifyOperations,
if it's DeleteFromFilterOperation, return the result directly without getting the JobClient.
Verifying this change
Added test in flink-table/flink-sql-client/src/test/resources/sql/delete.q.
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (yes / no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
The serializers: (yes / no / don't know)
The runtime per-record code paths (performance sensitive): (yes / no / don't know)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / no / don't know)
The S3 file system connector: (yes / no / don't know)

Documentation

Does this pull request introduce a new feature? (yes / no)
If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

cc @fsk119

@flinkbot run azure

@flinkbot run azure

@flinkbot run azure


[$2000] cursor moves from right to left while opening search page

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

click on search icon
check the cursor

Expected Result:
cursor should not move
Actual Result:
cursor moves from right to left
Workaround:
unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[x] iOS / Safari
[ ] MacOS / Chrome / Safari
[ ] MacOS / Desktop

Version Number: 1.2.78-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:
https://user-images.githubusercontent.com/43996225/222875041-6fa38053-3aee-4d76-8f75-584517af1ef3.MP4
https://user-images.githubusercontent.com/43996225/222875077-f211dd15-fda4-4519-b4e7-29cd9f6045fc.MP4
Expensify/Expensify Issue URL:
Issue reported by: @hungvu193
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1674752439760209
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~0182cdb9e9ea4b8d61
Upwork Job ID:<PHONE_NUMBER>118607360
Last Price Increase: 2023-05-17

Triggered auto assignment to @isabelastisser (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

Bug0 Triage Checklist (Main S/O)

[ ] This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
[ ] This bug is not a duplicate report (check E/App issues and #expensify-bugs)

If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead

[ ] This bug is reproducible using the reproduction steps in the OP. S/O

If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
If the reproduction steps aren't clear and you determine the correct steps, please update the OP.

[ ] This issue is filled out as thoroughly and clearly as possible

Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.

[ ] I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

Not overdue; I was assigned this while I was OOO. I will review this today.

Job added to Upwork: https://www.upwork.com/jobs/~0182cdb9e9ea4b8d61

I think Callstack could look into this one

Triggered auto assignment to Contributor Plus for review of internal employee PR - @mananjadhav (Internal)

Proposal
Please re-state the problem that we are trying to solve in this issue.
Cursor moves from right to left while opening search page.
What is the root cause of that problem?
Whenever search page open it will load OptionsSelector as shown below:
https://github.com/Expensify/App/blob/f95292aa3facb205df5afb2c57b9a14eac8db61d/src/pages/SearchPage.js#L180-L192
Eventually it will load BaseOptionsSelector component, and set text input focus during componentDidMount as shown here.
https://github.com/Expensify/App/blob/f95292aa3facb205df5afb2c57b9a14eac8db61d/src/components/OptionsSelector/BaseOptionsSelector.js#L102-L106
As we are not passing shouldDelayFocus props to OptionsSelector so it will set text input focus immediately as soon as component load.
What changes do you think we should make in order to solve the problem?
We have to pass shouldDelayFocus props to OptionsSelector component. i.e Add code within src/pages/SearchPage.js file as shown below:
<OptionsSelector
      ...
      shouldDelayFocus // ** ADD THIS ***
/>

What alternative solutions did you explore? (Optional)
None

Current assignee @isabelastisser is eligible for the External assigner, not assigning anyone new.

Making this external to handle the proposals

Proposal
Please re-state the problem that we are trying to solve in this issue.
Cursor moves from right to left while opening search page.
What is the root cause of that problem?
Whenever search page open it will load OptionsSelector as shown below:
https://github.com/Expensify/App/blob/f95292aa3facb205df5afb2c57b9a14eac8db61d/src/pages/SearchPage.js#L180-L192
Eventually it will load BaseOptionsSelector component, and set text input focus during componentDidMount as shown here.
https://github.com/Expensify/App/blob/f95292aa3facb205df5afb2c57b9a14eac8db61d/src/components/OptionsSelector/BaseOptionsSelector.js#L102-L106
As we are not passing shouldDelayFocus props to OptionsSelector so it will set text input focus immediately as soon as component load.
What changes do you think we should make in order to solve the problem?
We have to pass shouldDelayFocus props to OptionsSelector component. i.e Add code within src/pages/SearchPage.js file as shown below:
<OptionsSelector
      ...
      shouldDelayFocus // ** ADD THIS ***
/>

What alternative solutions did you explore? (Optional)
None

HI all, just checking, you want cursor be invisible while search window moves to the left or you want cursor stay to the left and move at the same time as search window loves?

📣 @mozai25! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.

Format:
Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

@stitesExpensify @isabelastisser we're working on the Search focus in https://github.com/Expensify/App/issues/15276. I went through the comment history, and considering it has some promising proposals, I think we should put this on Hold. I feel this would get resolved with the linked issue.

Cool, put this on hold, thanks!

Not overdue, on hold!

On hold!

@mananjadhav, @isabelastisser, @stitesExpensify Eep! 4 days overdue now. Issues have feelings too...

On hold, not overdue.

on hold, not overdue.

Hold

still on hold.

On hold!

still on hold!

not overdue, on hold!

Looks like that other issue is deployed, so this is now off hold!

I'll test this today and make sure that this is fixed, otherwise I will add the help wanted label

Doesn't look like this is fixed :/
https://user-images.githubusercontent.com/42391420/234969383-e71599d7-3f06-47f3-8b01-3375a47d36c4.mp4

@stitesExpensify my proposal  https://github.com/Expensify/App/issues/15660#issuecomment-1458378032 above will solve this issue.

Moving this to Daily, @mananjadhav do we have a good proposal?

Hi @mananjadhav , do you have an update? Thanks!

I don't think we should be using shouldDelayedFocus. Looking for better proposals.

Sounds good, @mananjadhav !

Not overdue, waiting for more proposals!

Not overdue, waiting for more proposals!

@mananjadhav @stitesExpensify, how could we find more proposals quickly? This issue was opened a while ago!

Let's start by doubling the bounty, hopefully that will draw some more interest

I am currently unable to reproduce this on the main branch. Looks like it may have been fixed at some point.
https://github.com/Expensify/App/assets/4160319/9c6541bf-08d9-41f9-975a-a677956ec0e7

Unable to reproduce it! @stitesExpensify can you please confirm that I can pay the issue reporter (@hungvu193) and the C+  (@mananjadhav) and close the issue? Thanks!

Yeah I can't reproduce it either. I tried on different devices.  I think we can close this one out.

Issue not reproducible during KI retests. (First week)

@mananjadhav I hired you in Upwork, please accept it and I will process the payment.
@hungvu193 what's your Upwork profile? I can't seem to find you there. Here's the job post.

@isabelastisser I was just going to comment here, could you please confirm the amount for the C+ review? I think I received an offer for 1000$, which I don't think is valid. I think we should follow the 25% rule for the payout, effectively 500$. Link to the document for your reference.

@isabelastisser oops I couldn't access the link. Nevermind here's my upwork link: https://www.upwork.com/freelancers/~01ff54c35a1f76441a

We are all set here!


rp/uart: use lockfree ringbuffer.

This gets rid of another PeripheralMutex usage.
Extracted out of #980

Thanks for the feedback! Added docs, tests, comments explaining the atomic orderings.
bors r+


Shift+Cmnd+P does not find the decode

Installed on a Mac as per instructions.

I am having the same issue.
It was working for me last month, but recently it seems like the plugin is not being loaded.

Thanks for reporting it. Since there were no new releases, something has probably changed in Arduino IDE. Can you provide details? What OS? What is the Arduino IDE version? You can get the logs from the IDE and attach them to this issue.
Please search the official Arduino forum on how to get the IDE logs: https://forum.arduino.cc/c/software/ide-2-x/93.

OS: macOS 13.6.7
Arduino IDE: 2.3.2
I am attaching the beginning of the logs generated by Arduino IDE during launch, rather than the entire set of logs (which contain sensitive information).
I believe I am attaching the relevant portion of the logs.
vegasje@vegasje-MacBook-Air-22 ~ % "/Applications/Arduino IDE.app/Contents/MacOS/Arduino IDE"
Arduino IDE 2.3.2
Checking for frontend application configuration customizations. Module path: /Applications/Arduino IDE.app/Contents/Resources/app/lib/backend/electron-main.js, destination 'package.json': /Applications/Arduino IDE.app/Contents/Resources/app/package.json
Setting 'theia.frontend.config.appVersion' application configuration value to: "2.3.2" (type of string)
Setting 'theia.frontend.config.cliVersion' application configuration value to: "0.35.3" (type of string)
Setting 'theia.frontend.config.buildDate' application configuration value to: "2024-02-20T09:53:59.281Z" (type of string)
Frontend application configuration after modifications: {"applicationName":"Arduino IDE","defaultTheme":{"light":"arduino-theme","dark":"arduino-theme-dark"},"defaultIconTheme":"none","electron":{"windowOptions":{}},"defaultLocale":"","validatePreferencesSchema":false,"preferences":{"window.title":"${rootName}${activeEditorShort}${appName}","files.autoSave":"afterDelay","editor.minimap.enabled":false,"editor.tabSize":2,"editor.scrollBeyondLastLine":false,"editor.quickSuggestions":{"other":false,"comments":false,"strings":false},"editor.maxTokenizationLineLength":500,"editor.bracketPairColorization.enabled":false,"breadcrumbs.enabled":false,"workbench.tree.renderIndentGuides":"none","explorer.compactFolders":false},"appVersion":"2.3.2","cliVersion":"0.35.3","buildDate":"2024-02-20T09:53:59.281Z"}
Starting backend process. PID: 25948
Using browser-only version of superagent in non-browser environment
Configuration directory URI: 'file:///Users/vegasje/.arduinoIDE'
Configuring to accept webviews on '^.+\.webview\..+$' hostname.
2024-07-15T16:48:03.349Z root INFO Backend Object.initialize: 2.2 ms [Finished 0.281 s after backend start]
2024-07-15T16:48:03.351Z root INFO Backend Object.configure: 1.8 ms [Finished 0.281 s after backend start]
2024-07-15T16:48:03.351Z root INFO Backend s.onStart: 0.8 ms [Finished 0.281 s after backend start]
2024-07-15T16:48:03.351Z root INFO Backend s.configure: 0.1 ms [Finished 0.294 s after backend start]
2024-07-15T16:48:03.352Z root INFO Backend d.onStart: 0.1 ms [Finished 0.294 s after backend start]
2024-07-15T16:48:03.352Z root INFO Backend d.configure: 0.0 ms [Finished 0.295 s after backend start]
2024-07-15T16:48:03.352Z root INFO Backend d.initialize: 13.1 ms [Finished 0.295 s after backend start]
2024-07-15T16:48:03.352Z root INFO Backend c.onStart: 0.1 ms [Finished 0.295 s after backend start]
2024-07-15T16:48:03.352Z root INFO Backend a.configure: 2.0 ms [Finished 0.297 s after backend start]
2024-07-15T16:48:03.353Z config INFO >>> Initializing CLI configuration...
2024-07-15T16:48:03.353Z root INFO Backend c.initialize: 0.3 ms [Finished 0.297 s after backend start]
2024-07-15T16:48:03.353Z root INFO Backend R.onStart: 0.4 ms [Finished 0.297 s after backend start]
2024-07-15T16:48:03.353Z config INFO Loading CLI configuration from /Users/vegasje/.arduinoIDE/arduino-cli.yaml...
2024-07-15T16:48:03.353Z daemon INFO Starting daemon from /Applications/Arduino IDE.app/Contents/Resources/app/lib/backend/resources/arduino-cli...
2024-07-15T16:48:03.353Z root INFO Backend a.initialize: 0.2 ms [Finished 0.297 s after backend start]
2024-07-15T16:48:03.353Z root INFO Backend w.onStart: 0.5 ms [Finished 0.298 s after backend start]
2024-07-15T16:48:03.353Z root INFO Backend r.configure: 0.7 ms [Finished 0.298 s after backend start]
2024-07-15T16:48:03.354Z discovery-log INFO start
2024-07-15T16:48:03.354Z discovery-log INFO start new deferred
2024-07-15T16:48:03.354Z root INFO Backend d.initialize: 0.1 ms [Finished 0.298 s after backend start]
2024-07-15T16:48:03.354Z root INFO Backend y.onStart: 0.7 ms [Finished 0.299 s after backend start]
2024-07-15T16:48:03.354Z root INFO Backend r.configure: 0.6 ms [Finished 0.299 s after backend start]
2024-07-15T16:48:03.354Z root INFO Backend a.onStart: 0.2 ms [Finished 0.299 s after backend start]
2024-07-15T16:48:03.354Z root INFO Backend h.configure: 0.2 ms [Finished 0.299 s after backend start]
2024-07-15T16:48:03.354Z root INFO Backend s.configure: 0.0 ms [Finished 0.299 s after backend start]
2024-07-15T16:48:03.354Z root INFO Backend l.configure: 0.0 ms [Finished 0.299 s after backend start]
2024-07-15T16:48:03.355Z root INFO Theia app listening on http://<IP_ADDRESS>:64007.
2024-07-15T16:48:03.355Z root INFO Finished starting backend application: 1.2 ms [Finished 0.300 s after backend start]
2024-07-15T16:48:03.355Z root WARN The local plugin referenced by local-dir:/Users/vegasje/.arduinoIDE/extensions does not exist.
2024-07-15T16:48:03.357Z config INFO Loaded CLI configuration: {"board_manager":{"additional_urls":["https://espressif.github.io/arduino-esp32/package_esp32_index.json"]},"build_cache":{"compilations_before_purge":10,"ttl":"720h0m0s"},"daemon":{"port":"50051"},"directories":{"builtin":{"libraries":"/Users/vegasje/Library/Arduino15/libraries"},"data":"/Users/vegasje/Library/Arduino15","downloads":"/Users/vegasje/Library/Arduino15/staging","user":"/Users/vegasje/Programming/Arduino"},"library":{"enable_unsafe_install":false},"locale":"en","logging":{"file":"","format":"text","level":"info"},"metrics":{"addr":":9090","enabled":true},"output":{"no_color":false},"sketch":{"always_export_binaries":false},"updater":{"enable_notification":true}}
2024-07-15T16:48:03.357Z config INFO 'directories.data' and 'directories.user' are set in the CLI configuration model.
2024-07-15T16:48:03.357Z config INFO Loaded the CLI configuration.
2024-07-15T16:48:03.358Z root INFO [esp-exception-decoder-1.0.2.vsix]: trying to decompress into "/private/var/folders/sn/752fhytn69q9m5fjqqg44s340000gn/T/vscode-unpacked/esp-exception-decoder-1.0.2.vsix"...
2024-07-15T16:48:03.360Z root INFO [esp-exception-decoder-1.0.2.vsix]: already found
2024-07-15T16:48:03.361Z config INFO Mapped the CLI configuration: {"dataDirUri":"file:///Users/vegasje/Library/Arduino15","sketchDirUri":"file:///Users/vegasje/Programming/Arduino","additionalUrls":["https://espressif.github.io/arduino-esp32/package_esp32_index.json"],"network":"none","locale":"en"}
2024-07-15T16:48:03.361Z config INFO Validating the CLI configuration...
2024-07-15T16:48:03.361Z root ERROR Failed to load plugin dependencies from '/private/var/folders/sn/752fhytn69q9m5fjqqg44s340000gn/T/vscode-unpacked/esp-exception-decoder-1.0.2.vsix' path Error: ENOENT: no such file or directory, open '/private/var/folders/sn/752fhytn69q9m5fjqqg44s340000gn/T/vscode-unpacked/esp-exception-decoder-1.0.2.vsix/package.json'
2024-07-15T16:48:03.366Z config INFO The CLI config is valid.
2024-07-15T16:48:03.366Z config INFO <<< Initialized the CLI configuration.
2024-07-15T16:48:03.372Z root INFO Resolve plugins list: 19.2 ms [Finished 0.318 s after backend start]
...

Thank you!
Please delete the corrupted folder from your temp location and restart the Arduino IDE:
rm -rf /private/var/folders/sn/752fhytn69q9m5fjqqg44s340000gn/T/vscode-unpacked/esp-exception-decoder-1.0.2.vsix

This process should resolve the issue. Please let me know if it was successful. I encountered a problem with my local setup and found that removing the folder from the temporary location resolved the issue.

This could be a bug in the [Theia version] (https://theia-ide.org/) of the Arduino IDE. When a VS Code extension is installed as a VSIX (dropped into the plugins folder), Theia framework attempts to extract the VSIX into a temporary location and runs the JavaScript code from there. A VSIX is essentially a ZIP file containing JavaScript files. If the temporary target location of the VSIX already exists, the framework will not attempt to extract it again, assuming it's already there. However, it seems that this logic has flaws. Even though the folder exists, it may be empty, possibly due to the operating system cleaning it up. This situation occurs in the temporary folder.
I will leave this issue open for visibility, but it's not a bug in the exception decoder.

I can confirm that deleting the temporary folder has resolved the issue.

Hi, same problem here using W10 and Arduino IDE 2.3.3
Any idea if there is such temporary folder in W10?
Thanks

Hi @hipotenusa

Any idea if there is such temporary folder in W10?

It is here:
C:\Users\<username>\AppData\Local\Temp\vscode-unpacked

(where <username> is your Windows username)

❗ If looking for it with your file manager or command line, note that the AppData folder is hidden by default. On Windows "File Explorer", you can make it visible by opening the "View" menu, then checking the box next to "☐ Hidden items".


result

Thank you very much for your work. I am unable to fully reproduce the results described in the paper using the provided checkpoint. The results for the car are very close to those reported in the paper, however, there are significant discrepancies for the cyclist, van, and pedestrian categories.I don't know where the problem lies.If you could reply, I would be extremely grateful.

Hello, thanks for your this news. The results are reproduced on RTX 3070. We find that different  devices may exhibit different results using the same environment. We attribute this phenomenon to the code. Please kindly refer to our new code of P2P, where the code is not sensitive to the device.
聂佳浩
@.***
签名由 网易灵犀办公 定制
---- Replied Message ----
From lengmianlaotang @.> Date 09/10/2024 16:47 To haooozi/GLT-T @.> Cc Subscribed @.***> Subject [haooozi/GLT-T] result (Issue #3)
Thank you very much for your work. I am unable to fully reproduce the results described in the paper using the provided checkpoint. The results for the car are very close to those reported in the paper, however, there are significant discrepancies for the cyclist, van, and pedestrian categories.If you could reply, I would be extremely grateful.
image.png (view on web)
image.png (view on web)
image.png (view on web)
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: @.***>


Release 1.1.5

Placeholder for the 1.1.5 release.

This will include the fix for #233 at the least.

@jsirois Can we get PR #227 in as well? Pants had to go back to using pex 1.1.2 due to #226.

@ewang yup - I'll get that merged in shortly.  Thanks for pointing it out.

I'd like to shoot for a Thursday April 21st (tomorrow) release.  This will allow for a pants upgrade to pick up the fix for #226 prior to their weekly release.

I'd like to get #224 too.  I might drop my nits on @KatieLucas-Grapeshot's PR to get that fix in if she doesn't have time to respond.

Noting that this release also includes the fix for #220.
That should wrap it up.  I'll prepare the CHANGELOG, wait for CIs to go green and release.

Released:
https://github.com/pantsbuild/pex/releases/tag/v1.1.5
https://pypi.python.org/pypi/pex/1.1.5


Style Search bar

I've styled the search bar after the links as seen in the header.

Looks nice! I'll merge this in.


Removed uses-sdk from manifest

Fixes bug #357

Merged similar commit.  Yours was first, but didn't realized that until was too late. Anyway, thanks for you contribution!


Loosen dependency requirements and remove most overrides.

Coverage remained the same at 84.101% when pulling f4b158643b918018505fa768dbb8857939e8fe8f on remove-most-overrides into 23c8542d88192b398622736f99cc940426e4a50f on master.


Internal server error when elastic is not available

Currently if code and issues are indexed to elastic and elasticsearch server is not available it should:

[ ] pause indexers (code and issue) and keep not indexed items in queue until elastic is again available otherwise index get's out of sync with database/code
[ ] not show 500 error when searching but some more user readable error about functionality currently not available

I guess it should have been fixed. The newly written queue can push the failed items back to the queue.


Added example data for identities, names and addresses

Added example data for identities, names and address. Can be used to build stubs for testing

maybe rename data to example-data for clarity

ok I'm merging this and we can tweak it after the fact with some readmes


How to run service

"elogank/lol-replay-downloader": "1.1.@dev",
Vesion "1.1.@dev" it not exist.
And how to run observer-silex ?
Thanks You

Hello @nhoxzunbmt,
Where does the version 1.1@dev is needed ?
You have to create a VHost on the web/index.php file and all routes are available here : https://github.com/EloGank/lol-replay-observer-silex/blob/master/src/EloGank/Replay/Observer/Controller/ObserverController.php

"elogank/lol-replay-downloader": "1.1.@dev" is needed for https://packagist.org/packages/elogank/lol-replay-observer. But as @nhoxzunbmt said it does not exist. How can I resolve this issue?

Hello @phphil,
Replace the version with 1.2.*@dev and it will do the job :)

This is the first time I'm using composer. if I understand correctly composer gets the requirements from packagist. How do I change this requirement from 1.1.@dev to  1.2.@dev?

Oh, sorry.
I updated myself the version in the composer.json of the repo https://packagist.org/packages/elogank/lol-replay-observer.
Simply run a composer install and it will be good :)


Adapter functions are undefined

I'm trying to set up socket.io-redis for a kubernetes deployment, but something is wrong with the configuration. It is partially working, in that I can see socket.io messages in redis using redis-cli PSUBSCRIBE, but I don't have access to any of socket.io-redis' functions.
io.of('/').adapter.sockets(), io.of('/').adapter.allRooms() and every other function that should be available upon the successful configuration of socket.io-redis is undefined. My configuration is below.
const app = require('express')();
const server = require('http').createServer(app);
const io = require('socket.io')(server, {transports: ['websocket']});
const redisAdapter = require('socket.io-redis');
io.adapter(redisAdapter({port: 6379, host: '<IP_ADDRESS>'}));

Redis PSUBSCRIBE logs
1) "pmessage"
2) "*socket.io*"
3) "socket.io#/#"
4) "\x93\xa6MLcXhU\x83\xa4type\x02\xa4data\x92\xa4test\xactest data 66\xa3nsp\xa1/\x82\xa5rooms\x90\xa5flags\x80"

I am using socket.io 2.3.0 and socket.io-redis 5.4.0 which should be compatible according to the docs. Node version is v14.2.0.

RedisAdapter.clients() was renamed to RedisAdapter.sockets() in the 6.0.0 release.
Please see here for the documentation of the 5.4.0 version.

RedisAdapter.clients() was renamed to RedisAdapter.sockets() in the 6.0.0 release.
Please see here for the documentation of the 5.4.0 version.

Yeah, that's it. It just never occurred to me that the entire api would be different across versions. Thanks for your help!

Yeah, that's it. It just never occurred to me that the entire api would be different across versions. Thanks for your help!


Inter Explorer 11 Issue

Hello All,
IE 11 not loading mp3 files when no plugin install on browser.

@chiragvels Is this still an issue?

Closing this issue since no answer has been posted in more than 2 weeks. If you'd like to reopen this, let us know. Thanks!


Adds javadoc.jar and sources.jar generation to this maven project.

All is well.

All is well.

All is well.

This pull request makes the build fail.

All is well.

All is well.

All is well.

SonarQube analysis reported 21 issues:

 2 critical
 2 major
 17 minor

Watch the comments in this conversation to review them.
Note: the following issues could not be reported as comments because they are located on lines that are not displayed in this pull request:

 Make this line start at column 3.
 Make this line start at column 3.
 Make this line start at column 3.
 Make this line start at column 3.
 Tab characters found (this is the first occurrence)
 Make this line start at column 3.
 Make this line start at column 3.
 Make this line start at column 3.
 Make this line start at column 3.
 Make this line start at column 3.
... 9 more

All is well.

@Sander3003 This issue has been resolved. See https://github.com/SmartSocietyServices/Webapps/issues/146

@kevinsmeets Works nice!


fix reverse check for nary relations

Codecov Report
Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 95.89%. Comparing base (c2cdd6d) to head (74a9871).

Files
Patch %
Lines

...taskmodules/re_text_classification_with_indices.py
0.00%
1 Missing :warning:

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #90   +/-   ##
=======================================
  Coverage   95.89%   95.89%
=======================================
  Files          55       55
  Lines        3926     3926
=======================================
  Hits         3765     3765
  Misses        161      161

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Sponsorship / Donations

Hello,
The company I work for is organizing a donation wave to support projects/teams that are doing a tremendous job helping out the open source community. Orbit-Mvi it's one of these, no doubt.
I've talked already with @mattmook on slack, but I'll leave this "issue" open to better track it's progress.
Are you open for donations/sponsorship?
Regards

Any update? @mattmook @Rosomack

For a status update, everything has been submitted to GitHub but currently awaiting approval.

Just been approved, so PR awaiting @Rosomack approval for the link to become active.

Hello,
The donation was made! 🎊
We want to create a wave of support that can grow as it moves forward in time, allowing companies and individuals to participate within their scale and possibilities. And that’s why we’ve created the Open Source Donation Wave.
Please feel free to share it to hopefully widen the range of this initiative and start a movement that could create a ripple donation effect 😃.
Best regards, and thank you for Orbit-Mvi once again.


OCP4 Migration - Migrate operational components

Describe the issue
after migrating the pipeline, we will also need to migrate the other ops components and data, in all environments:

[ ] backup container
[x] audit log backup (done as part of sso initial migration)
[x] k6 testing (tested in ocp4 sandbox)
[x] keycloak admin scripts (also tested in ocp4 sandbox)
[ ] update RC webhook URLs from pathfinder to developer!

Definition of done

components spin up in ocp4 and data migrated

are the RC webhook urls only in sysdig?

are the RC webhook urls only in sysdig?

sysdig webhook adjusted

sysdig webhook adjusted


Proposal: Make NavigationView more friendly with data binding and implicit navigation

Proposal: Make NavigationView more friendly with data binding and implicit navigation
Summary
Currently, the NavigationView control only manages the navigation menu, but not the actual content navigation. You suggested to use it as a replacement of Pivot, but it lacks the core feature.
The SettingItem property is also very unfriendly with binding.
Rationale

User will want to just specify the relationship between menu items and contents, not bothering with the navigation code, which is usually just several common patterns.
User will want to handle setting item like other items.

Scope

Capability
Priority

User can just specify type on each navigation element, and the navigation and back button will just work.
Must

User can also construct the content, instead of using type.
Must

The selected menu item get tracked when the frame is navigated by other action.
Should

When selecting setting item, the SelectedItem property don't necessarily the item container.
Should

The NavigationView gets a Frame without opt-in.
Won't

Important Notes
Make SettingItem settable can solve its issue and may harm little to consumers, but requires implementation change.
Allowing using navigation transition without Frame can help the manually constructed scenario.
Open Questions
The typed scenario is friendly with Frame and manually constructed scenario requires ContentPresenter. Can they introduce more complexity?

Actually, problem is Frame's API. NavigationView just has to consider these limitations and provide events for custom behaviors instead of some convenient APIs.
If Frame would use bindable Page property, or if it would expose commands instead of Navigate(), GoBack() and GoForward() methods, things would be much simplier.
As far as I understood, SettingItem is old property intended for compatibility with original UWP version of NavigationView, and now it normally should be placed in FooterMenuItems.

As far as I understood, SettingItem is old property intended for compatibility with original UWP version of NavigationView, and now it normally should be placed in FooterMenuItems.

Agree. If the team also agree this, there should be documentation about SettingItem is unfriendly to binding and suggest not to use it.

Well, NavigationView lets you use any content loader. It's not just for Frame so it shouldn't be that way. This flexibility allows you to use a WebView or FlipView for example. I have built a control that does something similar to what these issues want which also lets you specify content inline just like Pivot but Back navigation doesn't work with ContentPresenter so it needs to manually. Maybe WinUI could add a separate control that inherits from NavigationView and adds automatic navigation (no need to handle ItemInvoked/SelectionChanged and back button just works and you can just specify the content you want when you select a specific item.

Well, NavigationView lets you use any content loader. It's not just for Frame so it shouldn't be that way.

Yes, then it's not convenient when I do want to use the most common patterns.

WinUI could add a separate control that inherits from NavigationView

This can be an alternate solution of this proposal. Anyway, this proposal means that there should be some control for this.

@anawishnoff and @YuliKl

I've tried to do something similar in my own library. Basically, there's a custom class that inherits from WinUI NavigationView which handles ItemInvoked + SelectionChanged internally and based on the invoked item, it tries to navigate (there's also a custom class that inherits from NavigationViewItem which has a property to set the content to show when invoked). There are a few downsides to the approach:

For items that it doesn't know how to navigate, there's no way to handle it manually.
Since you specify the content in the property, it will be loaded in the visual tree even before it's needed.
Extending the title bar with a custom title bar becomes harder as you don't have direct access to the internal ContentPresenter used by the control.

https://learn.microsoft.com/windows/communitytoolkit/controls/switchpresenter from the Windows Community Toolkit is handy for these scenarios as well. Easy to bind to SelectedItem and look at a Tag or some other property and use it to display different page instances.


Add encrypted SSH deployment key

This should now complete the auto-deploy setup :)
Thanks a lot to @CyberShadow for encrypting the ssh key!

@wilzbach OK, merge this whenever you have the time to troubleshoot anything that might go wrong due to merging this :)

OK, merge this whenever you have the time to troubleshoot anything that might go wrong due to merging this :)

I don't have merge rights here, but would have time to troubleshoot atm ;-)
Could you please merge this and https://github.com/dlang/dconf.org/pull/152 to check whether it's working?

Doesn't look like it. Permission errors.

Okay the good news: seems like make, the SSH login via the encrypted worked, but rsync complains about permission errors:
rsync: mkstemp "/usr/local/www/dconf.org/data/2016/talks/.schadek.pdf.DRIzXE" failed: Permission denied (13)
rsync: mkstemp "/usr/local/www/dconf.org/data/2016/talks/.schveighoffer.html.6eBRkx" failed: Permission denied (13)
rsync: mkstemp "/usr/local/www/dconf.org/data/2016/talks/.schveighoffer.pdf.mkIThZ" failed: Permission denied (13)
rsync: mkstemp "/usr/local/www/dconf.org/data/2016/talks/.sechet.html.nElOmz" failed: Permission denied (13)
rsync: mkstemp "/usr/local/www/dconf.org/data/2016/talks/.sechet.pptx.mi9ohY" failed: Permission denied (13)
rsync: mkstemp "/usr/local/www/dconf.org/data/2016/talks/.smith.html.aettwf" failed: Permission denied (13)
rsync: mkstemp "/usr/local/www/dconf.org/data/2016/talks/.smith.pdf.vLbqXa" failed: Permission denied (13)
rsync: mkstemp "/usr/local/www/dconf.org/data/2016/talks/.thaut.html.zsAwqI" failed: Permission denied (13)
rsync: mkstemp "/usr/local/www/dconf.org/data/2016/talks/.thaut.pdf.y4uFm9" failed: Permission denied (13)
rsync: mkstemp "/usr/local/www/dconf.org/data/2016/talks/.watson.html.PeXZbq" failed: Permission denied (13)
rsync: mkstemp "/usr/local/www/dconf.org/data/2016/talks/.watson.pptx.0aSgTo" failed: Permission denied (13)
rsync: mkstemp "/usr/local/www/dconf.org/data/2016/talks/.zvibel.html.nINv41" failed: Permission denied (13)
rsync: mkstemp "/usr/local/www/dconf.org/data/2016/talks/.zvibel.pdf.0Strwb" failed: Permission denied (13)
rsync: mkstemp "/usr/local/www/dconf.org/data/2017/.contact.html.KdOHZw" failed: Permission denied (13)
rsync: mkstemp "/usr/local/www/dconf.org/data/2017/.index.html.7Uca8i" failed: Permission denied (13)
rsync: mkstemp "/usr/local/www/dconf.org/data/2017/.registration.html.KKaLOk" failed: Permission denied (13)
rsync: mkstemp "/usr/local/www/dconf.org/data/2017/.thankyou.html.9kEHyL" failed: Permission denied (13)
rsync: mkstemp "/usr/local/www/dconf.org/data/2017/.venue.html.L1vRYM" failed: Permission denied (13)
rsync: mkstemp "/usr/local/www/dconf.org/data/2017/schedule/.index.html.L6P0mc" failed: Permission denied (13)
rsync: mkstemp "/usr/local/www/dconf.org/data/2017/speakers/.index.html.IbCyyf" failed: Permission denied (13)
``

ls -l 2017
-rw-r--r--  1 dconf.org dconf.org  3920 Mar  3 17:56 contact.html
drwxr-xr-x  2 dconf.org dconf.org     4 Mar  3 17:56 images
drwxr-xr-x  2 dconf.org dconf.org     3 Mar  3 17:56 includes
-rw-r--r--  1 dconf.org dconf.org  6487 Mar  3 17:56 index.html
-rw-r--r--  1 dconf.org dconf.org  7155 Mar  3 17:56 registration.html
drwxr-xr-x  2 dconf.org dconf.org     3 Mar  3 17:56 schedule
drwxr-xr-x  2 dconf.org dconf.org     3 Mar  3 17:56 speakers
-rw-r--r--  1 dconf.org dconf.org  3698 Mar  3 17:56 thankyou.html
-rw-r--r--  1 dconf.org dconf.org  4615 Mar  3 17:56 venue.html

How about a `chmod -R g+w`?


Wrong story opened under best sorting

Hi, I am learning to implement a router through this example cuz I cannot find a built-in one in sauron. When I open your online demo, it is StorySorting::Top by default. If I switch it to any other sorting and click on the link to open the story or user. It will show the corresponding one in Top sorting in terms of position.
Please let me know if there is a way to fix this. Thank you!

@bryan824 this is an issue with rearranged nodes with keys, where keyed item is being reused when the DOM changes. This hasn't been handled it.
As for the case with hackernews example, Top sorting and best Sorting will most likely have story items that is common to both Sorting.
There is a test that shows this case. It is currently annotated with #[should_panic]. The algorithm that handles all the diffing in keyed elements in found in here
I have been experimenting with a few algorithm to solve it but it messes with other cases, which would yields a lot of failing test.

Thank you so much for the reply. I checked your second-to-last commit, it seems like adding "key" attribute back will fix the issue but I saw you added a bug label. Does it mean the future fix should not use "key" attribute?

This has now been fixed at version 0.49.0 of sauron with the use of new diffing algorithm for keyed elements in mt-dom 0.19.0 with this commit

Related fixed issue: https://github.com/ivanceras/sauron/issues/63


Model ID won't update

Referring to a closed issue #178
I seem to be experiencing the same issue:

I've deleted the device in Z2M, and restarted Z2M. None of it seems to fix the problem. When I make changes to the firmware (e.g. add an input), they do show up in Z2M.
I've also let it validate that the hex file is correct, and that seems to be the case:

I bumped into one more thing.... When exporting the converter and opening the file, I still see the old name (ptvo.switch).

Could it be that this is part of the issue?
Also, using the custom converter in Z2M, I think it's still not triggered because of the lack of another modelID
Originally posted by @phalox in https://github.com/ptvoinfo/zigbee-configurable-firmware/issues/178#issuecomment-1703841926

@phalox Hi,

Delete device in Z2M.
Stop Z2M.
Delete coordinator_backup.json in the "data" folder.
Start Z2M.
Join the device again.

Great, that seems to have solved it!

What would be your recommended development process? When playing around with different settings, adding & removing sensors etc, this seems a little tedious. I also found it challenging to debug zigbee issues. Often it's a matter of reflashing/repowering, but I'd love some more visibility.

Unfortunately, Z2M is not friendly for DIY :). I use the same procedure while testing/