chore: fixing dependencies again

This PR is a partial revert of #1067 due to some errors on compilation of sdk and types, and few errors on modules resolutions. It puts back the devDependencies inside the packages and apps and clean up the root package.json.

@jurevans just rebased to main and I can't reproduce the null error anymore

@jurevans just rebased to main and I can't reproduce the null error anymore

Yep, it's working perfectly now!


Unit/Integration test framework.

For our unit test framework we're going to use React Testing Library which helps to create solid, light unit tests (and eventually integration tests) which we have confidence with.
As we have discussed, Cypress could be used for end to end tests.

It'll be interesting to see where we draw the line between our react-testing-library tests and Cypress tests. Even if some of them are redundant it would be nice to have the React-level tests to prevent regressions immediately since they run in CI in this repo, and the Cypress browser-level tests to make sure things really work in a real app image.


[Solution] Fix the compiling error in Ubuntu 16.04

If anyone is facing a similar problem as below:
      -- The C compiler identification is GNU 5.4.0
      -- The CXX compiler identification is GNU 5.4.0
      -- Check for working C compiler: /usr/bin/cc
      -- Check for working C compiler: /usr/bin/cc -- works
      -- Detecting C compiler ABI info
      -- Detecting C compiler ABI info - done
      -- Detecting C compile features
      -- Detecting C compile features - done
      -- Check for working CXX compiler: /usr/bin/c++
      -- Check for working CXX compiler: /usr/bin/c++ -- works
      -- Detecting CXX compiler ABI info
      -- Detecting CXX compiler ABI info - done
      -- Detecting CXX compile features
      -- Detecting CXX compile features - done
      -- Found OpenGL: /usr/lib/x86_64-linux-gnu/libOpenGL.so
      -- Found EGL: /usr/lib/x86_64-linux-gnu/libEGL.so
      -- Found SDL2_image: /usr/lib/x86_64-linux-gnu/libSDL2_image.so
      -- Found SDL2_ttf: /usr/lib/x86_64-linux-gnu/libSDL2_ttf.so
      -- Found SDL2_gfx: /usr/lib/x86_64-linux-gnu/libSDL2_gfx.so (found version "1.0.1")
      -- Found PythonLibs: /usr/local/lib/libpython3.6m.so (found suitable version "3.5.2", minimum required is "3")
      Using Python: 3.5 ================================================================= /usr/include/python3.5m, /usr/lib/x86_64-linux-gnu/libpython3.5m.so
      Using Python: 3.5
      -- Boost version: 1.65.1
      -- Found the following Boost libraries:
      --   python35
      Using Boost.Python: python35
      -- Looking for pthread.h
      -- Looking for pthread.h - found
      -- Looking for pthread_create
      -- Looking for pthread_create - not found
      -- Looking for pthread_create in pthreads
      -- Looking for pthread_create in pthreads - not found
      -- Looking for pthread_create in pthread
      -- Looking for pthread_create in pthread - found
      -- Found Threads: TRUE
      -- Boost version: 1.65.1
      -- Found the following Boost libraries:
      --   thread
      --   system
      --   filesystem
      --   python35
      --   chrono
      --   date_time
      --   atomic
      -- Configuring done
      CMake Error at CMakeLists.txt:183 (add_library):
        Target "game" links to item "-L/usr/lib/x86_64-linux-gnu -lSDL2 " which has
        leading or trailing whitespace.  This is now an error according to policy
        CMP0004.

      -- Generating done
      -- Build files have been written to: /home/hxt/rl_dir/env/football/third_party/gfootball_engine
      gfootball/build_game_engine.sh: line 30: pushd: third_party/gfootball_engine: No such file or directory
      error: Google Research Football compilation failed
      [end of output]

  note: This error originates from a subprocess, and is likely not a problem with pip.
  ERROR: Can't roll back gfootball; was not uninstalled
error: legacy-install-failure

× Encountered error while trying to install package.
╰─> gfootball

note: This is an issue with the package mentioned above, not pip.
hint: See above for output from the failure.

print the LIBRARIES variable of third_party/gfootball_engine/CMakeLists.txt and modify the incorrect path in LIBRARIES could fix this issue.

As an example, in my unbuntu 16.04 server:
(1) before this line:
target_link_libraries(${OUTPUT_LIB_NAME} ${LIBRARIES})
I print the value of LIBRARIES and get:
gamelib;menulib;datalib;blunted2;Boost::filesystem;Boost::system;Boost::thread;Boost::python35;/usr/lib/x86_64-linux-gnu/libpython3.5m.so;/usr/lib/x86_64-linux-gnu/libSDL2_image.so;/usr/lib/x86_64-linux-gnu/libSDL2_ttf.so;/usr/lib/x86_64-linux-gnu/libSDL2_gfx.so;-L/usr/lib/x86_64-linux-gnu  -lSDL2;/usr/lib/x86_64-linux-gnu/libEGL.so;/usr/lib/x86_64-linux-gnu/libOpenGL.so;/usr/lib/x86_64-linux-gnu/libOpenGL.so;/usr/lib/x86_64-linux-gnu/libGLX.so;/usr/lib/x86_64-linux-gnu/libGLU.so
(2) I see -L/usr/lib/x86_64-linux-gnu  -lSDL2; is incorrect.
Then, I set the path to the corrected one:
set(LIBRARIES "gamelib;menulib;datalib;blunted2;Boost::filesystem;Boost::system;Boost::thread;Boost::python35;/usr/lib/x86_64-linux-gnu/libpython3.5m.so;/usr/lib/x86_64-linux-gnu/libSDL2_image.so;/usr/lib/x86_64-linux-gnu/libSDL2_ttf.so;/usr/lib/x86_64-linux-gnu/libSDL2_gfx.so;-lSDL2;/usr/lib/x86_64-linux-gnu/libEGL.so.1;/usr/lib/x86_64-linux-gnu/libOpenGL.so;/usr/lib/x86_64-linux-gnu/libOpenGL.so;/usr/lib/x86_64-linux-gnu/libGLX.so;/usr/lib/x86_64-linux-gnu/libGLU.so")
After modifying the path, I successfully install the gfootball.

Hi, I have the same problem as you, but I don't know CMake very well, can you please give some more detailed instructions? About how to print variables and where to modify the path？


Text-based file for translations, and autogeneration of .js locale files

Having a text-based CSV (rather the binary .ods) file for the translation will make easier the tracking, editing and merging of that file in the future. I added also a python script to generate the .js files from the translation CSV file

Have you tested whether the .js files generated by your py script play well with the rest of the app?

In terms of content, there are keys in the /i18n/locales files that are not present in the translation file, keys related to the BCI part. I'll add all those additional keys to the table. Then we can test how the auto-generated .js behave

The translation CSV file was updated to take into account new labels. I'm having some issues installing watchman to be able to deploy the app here. Can someone compile and run the app using the autogenrated .js files?

I can take care of that


Error after upgrading from 1.0.7 to 1.0.8: database prefix information being lost

This might be a bit vague but I believe it's to do with the batching functionality here https://github.com/absinthe-graphql/dataloader/pull/93 (which is what I upgraded to get).
My app uses Postgres schemas for multi-tenancy, and in 1.0.7 this worked fine. As far as I can tell, I haven't needed to manually specify the schema for Dataloader anywhere - my Absinthe resolvers use the correct prefix (eg. loading data using Repo.one(query, prefix: "my_prefix"), and then Dataloader magically does the rest.
Upon upgrading to 1.0.8 for the new lateral join queries, now the database prefix information is missing when preloading data (and thus erroring because the default schema has no data in it).
If there's any more information I can provide, please let me know!

Fixed by #107


device library plus key

Hey, i have the new device library plus key, it's static, if anyone is interested I can post it here.

Please do

@realazizk ? :)

I did upgrade library and rekordbox, working fine with old key


Missing sample json config files break colab demo

Hello!
Just read your blogpost and ~50% of the way through the colab demo, and I have to say that so far it looks like this project has the potential to be profoundly clarifying in how it simplifies & abstracts various pieces of key experiment logic that otherwise suffers from unnecessary complexity. As a PhD student who has had to refactor my whole experimental configuration workflow more times than I would like to admit to even myself, I'm super excited to try out your logger!
I'd also like to commend you for how to-the-point your choice of explanatory examples were for the blogpost. Too many frameworks fill their docs with a bunch of overly-simplistic toy problems and fail to bridge the gap between these and a real experimental situation (e.g. the elegant layout of your multi-seed, multi-config experiment
That said, my experience working through your demo was interrupted once I reached the section "Log Different Random Seeds for Same Configuration". It seems this code cell references a file called "config_1.json", which doesnt exist. While I'm sure I could figure out a simple json file with 1-2 example items, this kind of guesswork distracts immensely from the otherwise very elegant flow from simple to complex that you've set up. I also assume your target audience stretches further than experienced coders, so providing a simple demo config file to reduce the time from reading->coding seems worthwhile.
tldr; the colab needs 1-2 demo config json files

Dear Jacob,
Thank you very much for the kind words and bringing this up. I have just fixed the issue in the notebook. I forgot that you need to download the configuration files if the notebook is executed from a Colab VM. Sorry for the inconvenience. Please let me know if you have any other recommendations/feature requests that could make your life easier.
@ configuration-file-layout: As long as your configuration file is a .json or .yaml the logger will load, copy it and internally store the resulting dictionary. Alternatively, I added a feature so that you can also explicitly provide a dictionary (with arbitrary nesting) as an input to the logger:
log = MLELogger(time_to_track=['num_updates', 'num_epochs'],
                what_to_track=['train_loss', 'test_loss'],
                experiment_dir="experiment_dir/",
                model_type='torch',
                config_dict={"lrate": 0.01,
                             "momentum": 0.9})

The logger will then instead store the dictionary. But you are right, I will add a note about this somewhere.
Have a great Friday and again thank you,
Rob


Azd Release on Mar/08 - Manual Testing

Starting 3rd March. Based on pending PR's and builds containing all features required for release.

Regression tests.
Testing for new features i.e., AKS Template, GH CLI removal, VS Code workspace view etc.

@rajeshkamal5050 What do AKS Template and VS Code workspace view refer to?

@rajeshkamal5050 Finished the Azd Release on Mar/08 - Manual Testing, we filed three new issues #1685,  #1686 and #1687. Please review.


Fix double kebabs in Workflows

Fixes https://github.com/ManageIQ/approval-ui/issues/27
Description
Fixes double kebabs in Workflows table
Before

After

@Hyperkid123

Codecov Report

Merging #28 into master will not change coverage.
The diff coverage is 0%.

@@           Coverage Diff           @@
##           master      #28   +/-   ##
=======================================
  Coverage   37.43%   37.43%
=======================================
  Files          46       46
  Lines         398      398
  Branches       41       41
=======================================
  Hits          149      149
  Misses        221      221
  Partials       28       28

Impacted Files
Coverage Δ

src/smart-components/workflow/workflows.js
0% <0%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f1dcc90...3466e00. Read the comment docs.


fix TARGET_OS_IPHONE missing, cause error on Xcode6.x

fix TARGET_OS_IPHONE missing, cause error on Xcode6.x

Please see the changelog for 2.6. Thanks!


Cannot Disable Antimalware Service Executable

Despite turning everything off in the security settings (real time protection, cloud-delivery, auto sample submission and tamper protection), the windows defender antivirus keeps running and taking device memory (and sometimes a lot of CPU as well). There's no guides on the Microsoft support on how to disable the service or kill the process and security policies prevent even Admins from turning off the service.
After reading this documentation I realized there seems to be some sort of passive mode but no information on how to disable it.
I understand that disabling security might be a risk for most users, but not presenting a way to turn it off will only make users rely on third party solutions that have high risk.  As a user I have the right to choose what software will run in my operational system and because of my type of work, every bit of memory is very important for my workflow.
Can someone please provide a guide on how to REALLY stop the windows defender antivirus, since all safe guides and tools that I could find online don't work after the last updates?
Thanks

@rafaelcastrocouto Thank you for your feedback. You are right, If you are enrolled in Microsoft Defender for Endpoint and you are using a third-party antimalware product, then the passive mode is enabled which cannot be disabled (unless you are on windows server 2016). But this tabular column gives you details about Microsoft Defender Antivirus state - https://docs.microsoft.com/en-us/microsoft-365/security/defender-endpoint/microsoft-defender-antivirus-compatibility?view=o365-worldwide#antivirus-and-microsoft-defender-for-endpoint
Note that all of this is automatic and no changes can be done by the end-user to move the status of Microsoft Defender Antivirus.
Hope this helps!
Thanks
Sri

Thanks for the response @msbemba
I did NOT enrolled into Microsoft Defender Endpoint, my machine is a Samsung notebook that has the default windows 10 installation. I do not use or want to use any type of third-party product nor do I want to use the Microsoft Defender. I just want to turn it off and keep my machine resources for my needs.
If a user is able to turn it off on windows server 2016, seems to me like the Microsoft company is intentionally blocking me from turning their app off in other versions. This clearly represents product tying since I'm not obligated to use any kind of anti-virus in order for Windows operational system to work.
"... no changes can be done by the end-user to move the status of Microsoft Defender Antivirus."
This is unacceptable and there's no technical argument to sustain this.
If not, it's very likely that a bunch of new hacks will pop up just like this old ones:
https://www.alitajran.com/turn-off-windows-defender-in-windows-10-permanently/
https://superuser.com/questions/947873/disable-windows-defender-in-windows-10
https://superuser.com/questions/1054257/how-do-i-kill-antimalware-service-executable
https://www.download3k.com/articles/How-to-Turn-Off-Windows-Defender-Permanently-in-Windows-10-01350
... and remember, their existence only make your software less secure.
I really hope you guys are good people and will help me and other users to use their devices as they see fit.

@rafaelcastrocouto Thank you for your feedback. This issue looks unique since you don't have Defender endpoint enfolled. I'd recommend you contact our Microsoft Support line or raise a support ticket via the need help option on the M365 admin center.
@yogkumgit  There are no changes in the document as this document applies only to Microsoft defender for endpoint.
Thanks
Sri

After 2 hours talking to Microsoft support, I was NOT able to make this process stop.
They indicated me to do the following but none worked:

Kill the process in task manager (not allowed)
Add a registry with DisableAntiSpyware in hklm\software\policies\microsoft\windows defender (don't work)
Disable scans in windows scheduler (don't work)
Stop the windows defender services (not allowed)
Add MsMpEng.exe to the exclusion list (don't work)

Can someone plz help me stop this process from running?

@msbemba  Thank you very much for the contribution and sharing this explanation. @rafaelcastrocouto  Considering the nature of the issue, as advised, please open a service ticket in your tenant and follow with them for the resolution. We proceed here to close it as here we are limited to documentation issues and improvements.
We will be very happy if you can share the outcome or resolution with us if you see documentation update is required. We will certainly update this documentation with that valuable information. Thanks again, for taking out some time to open the issue. Appreciate and encourage you to do the same in future also.

It is very simple to do. Jusg disable kernel mode driver and that is all.

@ValZapod can you help me? how can I disable it?

Reboot in safe mode and then do this https://superuser.com/a/947898/1033761
Works in windows 11.

Thanks for the fast reply but there was no gpedit.msc in my windows. I downloaded and got gpedit to work but it does NOT show 'Windows Defender' inside 'Windows Components' group.
Is there a way to fix this or should I try the CLI ?

You cannot use gpedit.
In safe mode:
HKEY_LOCAL_MACHINE\SYSTEM\CurrentControlSet\Services.
Look for services starting with "wd" that have "Windows Defender" in the Description value. A possibly incomplete list is: wdboot, wdfilter, wdnisdrv, wdnissvc, windefend.
Change the Start value for each service to 0x4 (hex 4, decimal 4).
Reboot to normal mode.

Did that, now windows won't boot anymore. Great now I gotta format my drive 🙎♂

now I gotta format my drive

I know how to do it without windows and yet do not know how to restore bootloader? Are you trolling?

sorry, not trolling at all. just losing my patience with a problem that didn't existed til the latest updates that enforced this antivirus.
I'm not an expert (specially in boot stuff) so this is kind of a headache for sure.
I have no idea how and where to access and undo windows reg data. Any help is welcome at this point.

specially in boot stuff) so this is kind of a headache for sure.

Does it bluescreen on boot? On what stage? Because it must boot.

You should have also set to 4 the Sence service there. Totaly forgot.

it does boot but windows keeps failing and restarting even in safe/prompt mode

Try to reboot holding shift it will allow you to go to EUFI recovery where you will have access to command prompt and then just use a command to set Start of Sense to 4 too.

Finnally I was able to open the prompt ... can you help me with the command to change that value?

command to change that value?

reg add "HKLM\System\CurrentControlSet\Services\Sense" /v "Start" /t REG_DWORD /d "4" /f

That didn't work. The new added reg is there but it's still rebooting. I tryed to undo the previous modifications but on the prompt reg query seems like all those services were deleted from the registry

like all those services were deleted from the registry

They are just not visable to normal user, only to system.

thx for your help. i'm guessing i cant sudo in windows 😅

I've just factory reset the PC  ... no programs, nothing. And windows defender is disabled.
STILL the antimalware is the number one in the memory list

Did you turn off real time protection? Ehat about UAC? Without it you will not be able to do anything. You can also try this (disable inheritence hack on whole WinDefend app). Again, here the first hack with disabling kernel mode drivers worked perfectly yesterday. Why does it start rebooting in your case I have no idea. I also have secureboot on all the time and stuff. So very strange.
This will of course still load the kernel mode drivers so worse idea, but whatever: https://lazyadmin.nl/win-11/turn-off-windows-defender-windows-11-permanently/

I'm on windows 10 home edition ... that won't work.

that won't work.

What?

For all of those that have the same struggle here's how I solved:
1st: Install "Update for Windows 10 x64 based Systems (KB4480730)" - this seems to be required and will make a lot of things work as they shoud in the other tutorials
2nd: Install "Defender Control" - https://www.sordum.org/9480/defender-control-v2-0/ - since I was tired of playing around with the registry with no success I tried this one and it worked as a charm
As always users gotta rely on 3rth party software to fix Microsoft mistakes.

For all of those that have the same struggle here's how I solved:
1st: Install "Update for Windows 10 x64 based Systems (KB4480730)" - this seems to be required and will make a lot of things work as they shoud in the other tutorials
2nd: Install "Defender Control" - https://www.sordum.org/9480/defender-control-v2-0/ - since I was tired of playing around with the registry with no success I tried this one and it worked as a charm
As always users gotta rely on 3rth party software to fix Microsoft mistakes.

I made an account just to thank you. Holy hell does that ~200-300mb of memory make a big difference in a lot of applications/games and the fact that it's no longer using every ounce of my HDD activity anytime I access ANYTHING from that drive is miraculous.

For all of those that have the same struggle here's how I solved:
1st: Install "Update for Windows 10 x64 based Systems (KB4480730)" - this seems to be required and will make a lot of things work as they shoud in the other tutorials
2nd: Install "Defender Control" - https://www.sordum.org/9480/defender-control-v2-0/ - since I was tired of playing around with the registry with no success I tried this one and it worked as a charm
As always users gotta rely on 3rth party software to fix Microsoft mistakes.

Thank you very much for this.....

Used defender control 2.1, and it works in 22H2.

Hello, I have the same issue, is it possible to be a litlle be more detailed in the process of solving this issue as I do not completly understand. Thanks in advance! this issue is really annoyin

For all of those that have the same struggle here's how I solved:
1st: Install "Update for Windows 10 x64 based Systems (KB4480730)" - this seems to be required and will make a lot of things work as they shoud in the other tutorials
2nd: Install "Defender Control" - https://www.sordum.org/9480/defender-control-v2-0/ - since I was tired of playing around with the registry with no success I tried this one and it worked as a charm
As always users gotta rely on 3rth party software to fix Microsoft mistakes.

Can u help me with more details/steps for how to manage this ? thx

Did you install https://www.sordum.org/9480/defender-control-v2-0/
It is very simple after that.

oh, my concern was where i get the win upd, but i tried without and it seemed to work perfectly. Thank you so much for this fix.


feat: generation

Closes partially #542
Summary of Changes

added an implementation of the generator
enabled tests for the generator (and removed the dummy test)
fixed an error related to constant expressions of integers being interpreted as floats
fixed an error where test files were read in an incorrect order
added a generation test for lists and maps
removed varargs from existing tests

@lars-reimann There are still some uncovered lines or branches left. They are fallback code (e.g. throwing exceptions for unknown nodes) and should not be hit in the normal code generation flow, and therefore can not be tested with generation tests.
What would you suggest, to solve that problem?

@lars-reimann There are still some uncovered lines or branches left. They are fallback code (e.g. throwing exceptions for unknown nodes) and should not be hit in the normal code generation flow, and therefore can not be tested with generation tests. What would you suggest, to solve that problem?

Add comments to those lines to selectively ignore them for coverage computation:
/* c8 ignore next */
const a = 1;

/* c8 ignore next 2 */
const b = 2;
const c = 3;

/* c8 ignore start */
if (false) {
    // ...
}
/* c8 ignore stop*/

:tada: This PR is included in version 0.2.0 :tada:
The release is available on:

Visual Studio Marketplace
GitHub release

Your semantic-release bot :package::rocket:


v2 feature: Expose constructor of MapInputSource type

Checklist

[x] Are you running the latest v2 release? The list of releases is here.
[x] Did you check the manual for your release? The v2 manual is here
[x] Did you perform a search about this feature? Here's the Github guide about searching.

What problem does this solve?
There is a problem is on creating a custom input source that should implement all Input SourceContext methods instead of extending with current realization.
Solution description
To fix this problem, suggesting to add a constructor to the current MapInputSource type. I will open PR in a few minutes.
Describe alternatives you've considered
It possible to implement all methods of InputSourceContext interface but in general, it would be the same or very close to methods from MapInputSource type.

Should be resolved already.


Simplify module structure (redundant re-exports)

Simplifies the module structure and closes #771.
Changes
TLDR:

Every symbol lives in exactly one module (+ optionally the prelude)
No symbols except modules at gdnative crate root (not even macros)
Some module renamings for clarification
No semantic changes -- may break imports however

Detailed list:

Change gdnative::object

Now official home for Ref, TRef etc.
Move several verifying traits: object -> object::bounds
Move/rename gdnative::thread_access -> gdnative::object::ownership
Move/rename gdnative::ref_kind -> gdnative::object::memory

Change gdnative::core_types

No more nested modules
Move gdnative::GodotError to gdnative::object::GodotError

Change gdnative::nativescript

Rename init -> export
Rename profiling -> profiler
export and user_data no longer re-exported to nativescript
class now private, symbols re-exported to nativescript
Macro profile_sig! now in profiler
Improve documentation + fix doc tests

Add gdnative::macros

replaces crate root for godot_init! etc.

Add gdnative::derive

contains derive macros and macro attributes

Document feature flags in lib.rs and Variant

Changes so far:

Avoid many duplicate module paths for core_type
Clean up most of gdnative::object

Move Ref, TRef etc. from top-level namespace
Rename thread_access -> ownership (but leaving symbol names for now)
Rename ref_kind -> memory
Add object::bounds with all the implementation details, so they don't pollute object

Move derive macros from top-level to gdnative::derive

The above are not yet 100% done, needs some double-checking.
Tasks left for consideration:

[ ] Move Instance/RefInstance from nativescript to object, so they're next to Ref/TRef.
[ ] Check if nativescript can be organized better -- and is its name helpful?
[ ] What do do with global macros like godot_init, godot_error etc.
[ ] Lots of symbols are #[doc(hidden)] but maybe part of the API; others are implementation details but public.
Hide symbols which the user doesn't get into contact with.
[ ] Decide if deprecation of a handful symbols (like gdnative::Ref, gdnative::NativeScript) is useful, or not.
For non-type symbols, this would possibly require code duplication...
[ ] Go through prelude symbols and check if their inclusion is justified

Thanks a lot for your feedback!

What do do with global macros like godot_init, godot_error etc.

These might be a good candidate for a macros module. (Not sure 100% where they are currently)

Currently they're in top-level gdnative module. I agree a nested module might make sense. I don't really see them fit in one of object, nativescript, api or core_types.
Maybe godot_init! can be re-exported in the prelude. The others don't seem very common.

Lots of symbols are #[doc(hidden)] but maybe part of the API; others are implementation details but public.
Hide symbols which the user doesn't get into contact with.
Decide if deprecation of a handful symbols (like gdnative::Ref, gdnative::NativeScript) is useful, or not.

Both of the above are great ideas. Is this referring only to the re-export?

Yes, I wouldn't change/deprecate any functionality as part of this PR, just module names.

For non-type symbols, this would possibly require code duplication...

Which non-type symbols are you specifically considering here? Some code duplication is inevitable, but we could probably manage it by clever use of the include! macro.

Macros/macro attributes like gdnative::NativeClass, gdnative::methods or traits like gdnative::NewRef, for example.

Go through prelude symbols and check if their inclusion is justified

This sounds like a good idea, if you would like to ping me on a review, I'd be happy to run through the list and give my thoughts on each item.

If you have the time, that would be nice!
All the bindings types should definitely stay there, as well as the core types. Probably makes sense to keep important members of object module, too. Maybe with macros, we could be more selective (definitely keep all the common derive-related symbols though).

bors try

Windows CI workers did not start -- let's try again.
bors r+


add outbounds only

this is a great job, thanks for share it.
please add outbounds only, that shows outbounds json and delete any extra data from json

Hello, can you give me an example of input and ouput for your issue?
thanks


Do not error on 260 character name additional fix

Per feedback on the issue, the reported issue in #11009 also impacts
the ForwardToDeadLetterMessagesTo property as well as the same fields
in QueueDescription.

Refactor ForwardTo logic into CheckValidQueueName
Add unit tests for ForwardDeadLetteredMessagesTo
Add unit tests for QueueDescriptionTests

fixes #11009

Can one of the admins verify this patch?


Move highlighting code to highlight.c file

Move the highlighting related code from syntax.c to highlight.c.

Codecov Report

Merging #4674 into master will decrease coverage by 0.23%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4674      +/-   ##
==========================================
- Coverage   81.38%   81.14%   -0.24%
==========================================
  Files         113      114       +1
  Lines      145122   145109      -13
==========================================
- Hits       118102   117750     -352
- Misses      27020    27359     +339

Impacted Files
Coverage Δ

src/highlight.c
77.87% <ø> (ø)

src/syntax.c
82.3% <ø> (+1.07%)
:arrow_up:

src/libvterm/src/unicode.c
87.17% <0%> (-7.7%)
:arrow_down:

src/sound.c
87.67% <0%> (-6.85%)
:arrow_down:

src/libvterm/src/mouse.c
92.85% <0%> (-3.58%)
:arrow_down:

src/xxd/xxd.c
73.44% <0%> (-1.36%)
:arrow_down:

src/usercmd.c
93.47% <0%> (-1.23%)
:arrow_down:

src/term.c
78.3% <0%> (-0.87%)
:arrow_down:

src/libvterm/src/termscreen.c
90.25% <0%> (-0.85%)
:arrow_down:

src/tag.c
77.67% <0%> (-0.84%)
:arrow_down:

... and 47 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b8be54d...84bbb96. Read the comment docs.

Yegappan wrote:

Move the highlighting related code from syntax.c to highlight.c.
You can view, comment on, or merge this pull request online at:
https://github.com/vim/vim/pull/4674
-- Commit Summary --

Move highlighting code to highlight.c file

-- File Changes --
M Filelist (2)
M src/Make_cyg_ming.mak (1)
M src/Make_morph.mak (1)
M src/Make_mvc.mak (4)
M src/Make_vms.mms (33)
M src/Makefile (10)
M src/README.md (1)
M src/globals.h (10)
A src/highlight.c (3580)
M src/proto.h (1)
A src/proto/highlight.pro (43)
M src/proto/syntax.pro (40)
M src/structs.h (52)
M src/syntax.c (3637)

Thanks.
On top of this, it would be good to keep hl_group_T and highlight_ga
local to highlight.c.  This will require some functions to have the few
places in syntax.c that access highlight_ga to get the info.
E.g. in a few places it only uses the number of IDs, that can be
obtained with a function.  And other places only use the name.
Perhaps some pieces of code can be moved over.
--
BROTHER MAYNARD: Armaments Chapter Two Verses Nine to Twenty One.
ANOTHER MONK:    And St.  Attila raised his hand grenade up on high saying "O
Lord bless this thy hand grenade that with it thou mayest
blow thine enemies to tiny bits, in thy mercy. "and the Lord
did grin and people did feast upon the lambs and sloths and
carp and anchovies and orang-utans and breakfast cereals and
fruit bats and...
BROTHER MAYNARD: Skip a bit brother ...
"Monty Python and the Holy Grail" PYTHON (MONTY) PICTURES LTD
/// Bram Moolenaar --<EMAIL_ADDRESS>-- http://www.Moolenaar.net   \
///        sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \
\\  an exciting new programming language -- http://www.Zimbu.org        ///
\\            help me help AIDS victims -- http://ICCF-Holland.org    ///


The case of 415 invisible cyano genomes

See attached

I'm not exactly sure why, but in the database both terrabacteria group and cyanobacteria group both appear to be 'no rank' and I think that is messing this up.

Confirmed that these groups are both classified as "no rank" at NCBI, http://www.ncbi.nlm.nih.gov/Taxonomy/Browser/wwwtax.cgi?mode=Info&id=1798711&lvl=3&lin=f&keep=1&srchmode=1&unlock.
I'm not exactly sure how to resolve this problem, handing off to Maulik

Fixed


For how long does Azure maintain the resource GUIDs?

Hi,
Imagine the following scenario -

A role is removed from the resource group for a particular user who leaves the organization after 4 days post the completion of this role removal.
We query the principal ID contained in this Deletion message say like 90 days after using this API - https://docs.microsoft.com/en-us/rest/api/authorization/roleassignments/getbyid

Till how long can we expect that Azure will return results for these IDs?
Thanks,
Pranav

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 0ada336b-a759-5a30-919c-9473ce0840e3
Version Independent ID: 5551959e-b7dc-2f45-4bb3-1212bae8e921
Content: Overview of the Azure Activity Log
Content Source: articles/azure-monitor/platform/activity-logs-overview.md
Service: azure-monitor
Sub-service: logs
GitHub Login: @johnkemnetz
Microsoft Alias: johnkem

Very Good question, @blueelvis. We are investigating and will provide a response soon.

@msvijayn , @johnkemnetz  - any input on the above question?

@nkiest - for questions pertaining to activity log

This is a question for the owner of /rest/api/authorization/roleassignments/getbyid, which I believe is authorization service. The activity log will contain this roleID for 93 days. The question is how long you can do a cross reference to look them up who that roleID was.
This is more a question on https://docs.microsoft.com/en-us/rest/api/authorization/roleassignments/getbyid page, rather than this one.

@nkiest @femsulu - Can you me with someone on the Authorization service? On that page, I don't see any way to provide feedback or raise a bug.
Will Activity Log contain all the entries for 93 days and is same across all services or are there any differences?

The schema can be slightly different across different categories and sources, but they are all kept for 90 (sorry, not 93), per https://docs.microsoft.com/en-us/azure/azure-monitor/platform/archive-activity-log

@nkiest - Is it possible to add this information (That logs are stored for 90 days in Activity Logs) in that same documentation link which you mentioned?
Also, could you please connect me with someone on the Authorization Team who manages that REST API so that I could get the doubts cleared? Thanks!

adding @tfitzmac to see if he has any contact on the Authorization team.
@blueelvis this content already covers log retention and is easily discoverable on the public domain. Any reason why would prefer it to be linked to the originally referenced doc?

@femsulu - I think the link you provided is un-related. This information would be helpful because it tells that the activity log itself stores the data only for 90 days. The retention using Storage accounts or Event Hubs is a separate topic. If this information is already out there, please provide me with a link to it.
Otherwise, I would be happy to submit a PR to add a one liner to the doc stating this :)

Agreed, I was kinda surprised that this doc did not mention 90 day retention anywhere. Feel free to make the change.
From: Pranav<EMAIL_ADDRESS>Sent: Thursday, April 11, 2019 3:33 AM
To: MicrosoftDocs/azure-docs<EMAIL_ADDRESS>Cc: Nick Kiest<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [MicrosoftDocs/azure-docs] For how long does Azure maintain the resource GUIDs? (#28976)
@femsuluhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Ffemsulu&data=02|01|Nick.Kiest%40microsoft.com|5b3435395ea041b9fb4f08d6be690911|72f988bf86f141af91ab2d7cd011db47|1|0|636905755664382764&sdata=41gEp%2F3FtviYfSxwU5VFMegrCy%2F5%2Bqaiv7WDJ4XzQbM%3D&reserved=0 - I think the link you provided is un-related. This information would be helpful because it tells that the activity log itself stores the data only for 90 days. The retention using Storage accounts or Event Hubs is a separate topic. If this information is already out there, please provide me with a link to it.
Otherwise, I would be happy to submit a PR to add a one liner to the doc stating this :)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoftDocs%2Fazure-docs%2Fissues%2F28976%23issuecomment-482061051&data=02|01|Nick.Kiest%40microsoft.com|5b3435395ea041b9fb4f08d6be690911|72f988bf86f141af91ab2d7cd011db47|1|0|636905755664392759&sdata=%2B01OMSvhqn2vUUYo80oXdrGiqg%2BZtm%2BClUMYUMhgass%3D&reserved=0, or mute the threadhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FABHlzIBy7tkpcHJ_yKlsSFzw7o3DYRYIks5vfw9LgaJpZM4ch8pE&data=02|01|Nick.Kiest%40microsoft.com|5b3435395ea041b9fb4f08d6be690911|72f988bf86f141af91ab2d7cd011db47|1|0|636905755664392759&sdata=CtXPh1Uk5cvrINwIgCo5NlbPL0ozwHUu1d6rFNUK30Q%3D&reserved=0.

@nkiest - I have created the PR over here - https://github.com/MicrosoftDocs/azure-docs/pull/29277 . It adds a note in the section to query the activity log in Azure Portal.
@femsulu @tfitzmac - Could you please connect me with someone from the Authorization team to get the above questions answered?

thanks @blueelvis.  Please send mail to<EMAIL_ADDRESS>include a link to this thread for context and we will work offline to get you in contact with a SME on the Authorization team.
@nkiest please note the PR #29277 for review and approval.
Closing this Issue in GitHub

@femsulu - Thanks! I just sent out the email containing the details about this and referred to this issue. The new change looks good as well.


Possible to keep things in the memory?

Hi Lion,
We are now integrating the whole workflow. For example, we want to combine signal processing(for both observed and synthetic) and window selection together. During the processing, we don't want any I/Os. To be more specific, we want the workflow to read in the raw data(one observed and one synthetic asdf file) at the very beginning, process them and select windows. After window selections, only the windows are written out.
Currently, I am using "process" function in the asdf_data_set.py. However, there is one argument called output_filename:
def process(self, process_function, output_filename, tag_map,
                traceback_limit=3, **kwargs):

meaning currently implementation requires to write the processed files out. However, if possible, my preferred way would be keep things in the memory.  I am guessing if so, it is even against the basic implementation of the asdf, right? Cause when you initialize the "read", it is not even read the whole thing into the memory. So there is not such a thing called "keep all the things in the memory".
Or I am thinking about another option would be modify the process function. So the process function would take one observed and one synthetic, and walked all the way down to window selection. I think that might be the right and possible way.

If my words get you confused here, I will just illustrate a little more:
For example, you have two files, one raw observed asdf and one raw synthetic asdf. You want to process them and select windows. There are two ways of doing so:

process the whole observed asdf(but keep all things in the memory), process the whole synthetic asdf(and keep things in the memory), and select windows(for traces in the memory). The advantage of this is to make my code modulelized so I can simply ensemble different parts together. But dis-advantage is this method might be not applicable to the currently asdf implementation.
modify the process_function, to make it incorporate all the procedures. I think if so, it is possible to implement. But disadvantage is this will make the process_function so big and not very user-friendly?

Sorry to bring it up so late. I looked through the code and found if so, it might involves a lot of changes in the code.

I am guessing if so, it is even against the basic implementation of the asdf, right?
Cause when you initialize the "read", it is not even read the whole thing into the memory. So there is not such a thing called "keep things in the memory".
Or I am thinking about another option would be modify the process function. So the process function would take one observed and one synthetic, and walked all the way down to window selection. I think that might be the right and possible way.

Hi Wenjie,
you should be able to do this with the already existing process_two_files_without_parallel_output() method.
http://seismicdata.github.io/pyasdf/parallel_processing.html#process-two-files-without-parallel-output-method
No need to add anything else I think.

modify the process_function, to make it incorporate all the procedures. I think if so, it is possible to implement. But disadvantage is this will make the process_function so big and not very user-friendly?

I guess my suggestions also applies to that fear of your's but just split it up in a couple of functions and you should be more than fine.
Let me know if there is some roadblock in that approach and we can certainly add something else as well if required.
Cheers!
Lion

Hi Lion,
I ensembled an example for the preprocessing workflow based on your suggestion, using process_two_files_without_parallel_output() method.
This example includes:

observed signal processing
synthetic singal processing
window selection
adjoint source constructor

I uploaded the file here(this is just an example and it is not yet 100% complete). But it delievers what we have been discussed.
A bit concern about this way is we have two many in-place function definition. The major reason for that is we need to define some variables outside the function and the argument list is pretty limited for process function passing into the process_two_files_without_parallel_output()
Sorry, I named it proc_combo.py.txt for uploading. Please rename it to *.py.
proc_combo.py.txt

Hi Wenjie,
yea that is actually an intended design choice. Otherwise the process()/process_two_files_without_parallel_output() methods would have very awkward function signatures.
Python has reasonable support for functional programming, in this case closures and function currying. You are using closures: the function definitions you make bind the outside variables and thus the function can see them.
An alternative would be to use functools.partial for function currying/partial application in Python. Your example could look like this:

from functools import partial

def combo_func(obsd_station_group, synt_station_group,
              process_obsd_function, process_synt_function, window_function,
              adjoint_source):
    ...

results = obsd_ds.process_two_files_without_parallel_output(
    synt_ds, partial(combo_func,
                     process_obsd_function=process_obsd_function,
                     process_synt_function=process_synt_function,
                     window_function=window_function
                     adjoint_source=adjoint_source))

Using either allows to write a well structure program.

Thanks for the suggestion. I will use the functools.partial
:+1:


Added default props to html.js per issue #58

I don't have a lot of context here so I went with some pretty generic defaults, let me know if you'd like one or more of them to be more specific

@jmartin84 Thank you for your contribution, and your pull request is merged. If you like this project, please don't hesitate to star it.
Close #58


Release 3.12.1 lists on website not not available via Github

The release notes for v3.12 state that there is a v3.12.1 version with links to downloads but which end in 404 errors.  https://docs.projectcalico.org/archive/v3.12/release-notes/
There are also no releases or tags in the github repo to account for this version.
Expected Behavior

Existing links in the documentation would provide access to download that version software (v3.12.1).
Current Behavior

Links end in 404 errors.  No release v3.12.1 exists in Github.
Possible Solution

N/a
Steps to Reproduce (for bugs)

Visit release notes page, click on "release archive" for v3.12.1.
Context

My main question is which version is considered the most stable for basic CNI (no network policy, no BGP usage) with K8s 1.17+?
Your Environment

N/a

Thank you for bringing that to our attention.
Going to https://docs.projectcalico.org/introduction/ will take you to the latest docs, install options, notes for the latest release. The current version is v3.13.3 and what we would suggest for any new install.
There are no Calico installation options that do not provide network policy but the default is allow all traffic.
'no BGP usage', BGP is the default and typically is not a problem. I would suggest you start with a default install in a test environment and then possibly consider different installation/configuration options.

@tmjd Thank you.


php7.2 install error

7.2 is as of yet untested. Travis just added support for 7.2.0 a couple of weeks ago, however I am aware of some compatibility issues between 7.0, 7.1 and 7.2 which will also need to be examined.


refact: Cleaned Up Args Handling and Added Tests

Modified DetermineRemote to be more robust by getting default remoteName from git config and also validate each remoteName input
Refactored main.go in gittuf-git
Resolved symbolic link with LookPath
Added Tests for all three functions of args handling

heads up: experimental has been rebased / force pushed to


[fix] [MLflow Task plugin] Sometimes errors are reported using preset algorithms (#10986)

Purpose of the pull request
close: #10986
Brief change log

Modify the download method of the project （Change from Python Git mode to direct Git Clone）

This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:

Codecov Report

Merging #10987 (37db040) into dev (7196b12) will decrease coverage by 0.00%.
The diff coverage is 66.66%.

@@             Coverage Diff              @@
##                dev   #10987      +/-   ##
============================================
- Coverage     40.35%   40.34%   -0.01%
  Complexity     4865     4865
============================================
  Files           943      943
  Lines         37027    37030       +3
  Branches       4062     4061       -1
============================================
- Hits          14941    14939       -2
- Misses        20583    20589       +6
+ Partials       1503     1502       -1

Impacted Files
Coverage Δ

...nscheduler/plugin/task/mlflow/MlflowConstants.java
0.00% <ø> (ø)

...olphinscheduler/plugin/task/mlflow/MlflowTask.java
60.39% <66.66%> (+1.21%)
:arrow_up:

...olphinscheduler/rpc/remote/NettyServerHandler.java
69.04% <0.00%> (-11.91%)
:arrow_down:

...er/master/dispatch/host/assign/RandomSelector.java
77.77% <0.00%> (-5.56%)
:arrow_down:

...dolphinscheduler/remote/future/ResponseFuture.java
83.60% <0.00%> (+1.63%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7196b12...37db040. Read the comment docs.


About reproduce the result in this paper

Hi, I read this paper a few weeks ago, I want to implement IRT, I read several paper but still don't know how to implement it. So I download this project to see how the code were organized. First I wanted to reproduce the result, but when I run
rnn_prof irt assistments skill_builder_data_big.txt --onepo \ --drop-duplicates --no-remove-skill-nans --num-folds 5 \ --item-id-col problem_id --concept-id-col single
The system warned that "rnn_prof is not an internal or external command". So I want to know what mistake I have made, and how can I reproduce this result.

Hi! That probably means that you didn't install the package. The easiest way to get everything going (assuming you're using a POSIX-like system such as MacOS, Linux, or Cygwin) is to:

Make sure you're using python 2.7 (this won't work with python 3, sorry!),
Make sure you have tox installed (pip install tox), then
In the root folder of the repository, run tox, then
Run source .tox/py27/bin/activate.

Then all the commands should work.
Best,
Kevin


Try to reopen Redis pub-sub connection on failure

#2414

Looks good to me :)

Will drop draft status when I've tested it, this is the theoretical fix - I want to do it once and properly.

Ready for additional reviewing.

Thanks!


Include Resource files option failing

When choosing the Include Resource files option and setting it up as the tooltip describes, the following error always occurs:
2017-06-07T17:23:36.1946565Z ##[error]System.Management.Automation.ParameterBindingException: A positional parameter cannot be found that accepts argument '+'.

I believe line 233 should be:
$props = New-Object "System.Collections.Generic.List[$type.Property]";

We take a look tomorrow. Might be indeed line 233.
Op 7 jun. 2017 8:10 p.m. schreef "Nick"<EMAIL_ADDRESS>I believe line 233 should be:
$props = New-Object "System.Collections.Generic.List[$type.Property]";
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/tobania/VSTS.Extension.SqlReportingServices/issues/12#issuecomment-306878885,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AEcni9nNRBMX8jv3yv5JOcZIaFkhVpMdks5sBuelgaJpZM4NzCby
.

@DevSlick  Can you verify that the last change did resolve this?  I have changed all the new-objects where i use the $type variable as you stated (which was correct by the way) :)

Yes. I can verify that the fix does work.

Lovely :) thanks!


Overture Tiles ECR Repository

Is your feature request related to a problem? Please describe
The Overture Tiles image is currently hosted in the Protomaps ECR repository: protomaps/overture-tiles. Overture should likely manage the repository and process for publishing new versions of the overture tiles image.
Describe the solution you'd like

Addition to Overture Tiles CDK which creates an ECR image repository owned by Overture.
Documentation for the process for publishing new versions of the overture tiles image.

I imagine it would be like:

provision an ECR repository using CDK, pointing at the image name overture-tiles/latest
use the AWS web console to authenticate your Docker client with the ECR repository
Most code changes can happen with docker push ...

Is there any higher-level automation possible with CDK around this workflow?

Those are the steps I had in mind as well.
Higher level automation is possible, but not via an officially supported construct - https://github.com/aws/aws-cdk/issues/12597. I think manually publishing the image for now is best.

Marking this as complete.


Restore Anaconda packages for Windows

conda-build packages are currently disabled.
Lately, conda-build doesn't like AppVeyor's environment. Python 3.8 support for Anaconda is also lacking at the moment.
Since the number of downloads for the conda packages is very small compared to the PyPI packages, this is a low priority item.
If you need support for conda packages, let your voice be heard here and I'll handle it manually for the time being.

Conda packages restored on Linux and macOS.
Building conda packages for Windows still has issues on AppVeyor (and some of my local Windows installations). To fix this, it would probably take more time than I'm willing to invest on this right now.
Note that normal PyPI/pip wheels are working normally if it wasn't clear by the message on the original post.

It's a good idea to revisit this later, providing a conda-forge recipe. Conda-forge dropped 32-bit packages a while ago, but providing DSS_Python and OpenDSSDirect.py on conda-forge is valuable. The 32-bit packages would still be available on PyPI (they're useful especially for testing).
For me, conda itself has been kind of a letdown the past few years. I imagined the commercial interest doesn't align well with it. The Anaconda.org repositories frequently have issues, reported both for DSS_Python (most people download it from PyPI anyway) and NILMTK (the recommended install method is conda due to the dependencies).
Conda-build, specifically, is really bad on Windows. Even if I can build normal/wheel packages easily on Windows, conda-build craps itself on the minimum unexpected thing that Anaconda didn't expect. There are many unresolved tickets with no useful feedback, some for multiple years.
Some third-party projects like Mamba (replaces the conda installation tool) and Boa (replaces conda-build) might help things.
To alleviate things and save my time, I'll investigate conda-forge tooling and settings since it should reduce the maintenance of conda-packages here. If successful, might be worth to officially submit the packages to the conda-forge repository.

The main task was done for v0.10.7. Moved the conda-forge part to #33.

The main task was done for v0.10.7. Moved the conda-forge part to #33.


Introduce direct reference for data.stack-utils in package.json

As of now, we are introducing a direct reference to the main branch of the data.stack-utils repository. This change is necessary to incorporate and test new features in data.stack-utils. After thorough testing, we will release the latest changes and update the package.json with the appropriate release reference.

@jugnu-appveen


Enable Regex Parsing?

How do I enable the new regex parsing feature? Do I have to use the source code or is there a way to do it with v1.3.0 as compiled? Right now the SignalLineParser, at least, is not using the regex parsing by default. I've found that some DBC files will not parse properly. For example, if there is no space between the signal name and the ":" character then an exception is thrown. A quick test with an online regex tester shows that this issue won't happen with the regex parsing. Would be nice if Parser.ParseFromPath or similar methods had a parameter that allowed the caller to specify whether to parse using regex.

Hi,
regex parsing is enabled by default in verssion 1.3.0, if it is failing there is a bug in the regex we are using.
Please provide an example of failing parsing, so we can tesst and fix.
Thanks
A

Hi,
we double checked, you are right SsignalLineParser is still using the legacy parsing, not the regex based one. Thiss is a leftover, we will release ASAP a fixed version.

Would be nice if Parser.ParseFromPath or similar methods had a parameter that allowed the caller to specify whether to parse using regex.

We won't do this, we prefer to keep it simple and use regex by default everywhere as the only parsing strategy.
In the future, if we ever introduce a new different parsing strategy, we will allow user to select which one to use.
Sorry for the inconvenience
A

Hi,
released in version 1.3.1 alreay available on nuget.org
Cheers
A

Thanks for the prompt fix!


Server compile end up with error on debian

$go version
go version go1.21.5 linux/amd64

$ go build -o ssh3-server cli/server/main.go
# ssh3/linux_server
linux_server/authorized_identities.go:39:50: undefined: linux_util.User
linux_server/authorized_identities.go:131:37: undefined: linux_util.User
linux_server/authorized_identities.go:171:53: undefined: linux_util.User
linux_server/auth.go:80:25: undefined: linux_util.UserPasswordAuthentication
linux_server/handlers.go:51:27: undefined: linux_util.GetUser

This is because building the server requires CGO_ENABLED=1 when building. If it is not set, it will ignore files with import "C" in it, causing the error above.
If you hae gcc installed, you should be able to install the server doing the following:
go build -o ssh3-server cli/server/main.go

Thanks for filing the issue ! I'll update the README.


Increase code coverage

Increase code coverage (a little)
Add comments to exported types/methods
Minor fixes

Codecov Report

Merging #43 (64b05ef) into main (162d5f2) will increase coverage by 6.27%.
The diff coverage is 31.42%.

@@            Coverage Diff             @@
##             main      #43      +/-   ##
==========================================
+ Coverage   63.42%   69.69%   +6.27%
==========================================
  Files          23       23
  Lines        2373     2346      -27
==========================================
+ Hits         1505     1635     +130
+ Misses        758      593     -165
- Partials      110      118       +8

Impacted Files
Coverage Δ

auth.go
88.67% <ø> (ø)

client.go
64.91% <ø> (+12.28%)
:arrow_up:

config.go
0.00% <0.00%> (ø)

execution.go
74.19% <ø> (+6.59%)
:arrow_up:

gateway.go
54.54% <ø> (ø)

instrumentation.go
100.00% <ø> (ø)

introspection.go
68.96% <ø> (ø)

merge.go
93.54% <ø> (ø)

metrics.go
0.00% <ø> (ø)

middleware.go
85.24% <ø> (ø)

... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 162d5f2...64b05ef. Read the comment docs.


[Question] Where is the smart data?

I have the plugin working and sending back data for my disks and services, all fine, but I can't find any entities or where I would find the smart data ?

Taking a poke around the code, there also seems to be code for returning the list of plugins, which I also don't have any entities for. I'm guessing things have gradually broken as OMV got upgraded and the plugin didn't keep up.

for smart data, you have to enable them in integration configuration.

Hi @tomaae  - I found the smart data in the end, I was just not looking in the right place.
One thing I noticed is that there is not a disk attribute for 'overallstatus', which is what I really want, but its clearly coming through in the API calls, because I can see it in the payload when using debug logs.
I have tried adding "overallstatus", to the list of attributes at line 45 of the line sensor_types.py as part of the DEVICE_ATTRIBUTES_DISK list, and then restarted home assistant, but the attribute never appears. I'm not sure what I am doing wrong.

you need to define it in controller to process that data.

Thanks @tomaae.
I'm getting the overallstatus now, and have written up how I did it here:-
https://community.home-assistant.io/t/openmediavault-integration/189310/156

I've also added power on hours, the instructions for which are very similar to the above and can be found here:-
https://community.home-assistant.io/t/openmediavault-integration/189310/158


Code for Llama-7b and Mistral

Hey guys, amazing work!
is there an easy way to update your code to use it on mistral or llama-2-7b-chat-hf?
I tried llama-2 but it did not work.
Thanks!

The current code is adapted to llama-2-7b-chat-hf. You should first generate the corresponding draft model based on search.ipynb, and then use evaluate_sum.ipynb to evaluate it.


Small freeze when stopping timer

Performance of the windows app has improved a lot over the last few weeks.
One of the things that still causes a small (but noticeable) freeze is stopping the timer.
From my analysis, stopping the time entry causes the following chain of events to happen:
DisplayTimeEntryList
    OnTimeEntryList

DisplayTimeEntryAutocomplete
    OnTimeEntryAutocomplete

DisplayMinitimerAutocomplete
    OnMinitimerAutocomplete

    OnStoppedTimerState (appears BEFORE the ui:D:Display.. line for some reason)
DisplayTimerState

    OnDisplayUnsyncedItems (no ui:D:Display.. call or similar appears in log)

These all happen on the same thread that called the Stop() function originally.
Most of the parts take very little time (0-5ms each, with OnStoppedTimerState at 15ms).
The real performance problem seems to arise from the sync at the end of it in some fashion. There seems to be a 180ms delay between DisplayTimerState and OnDisplayUnsyncedItems.
Do we know what causes this delay?
Proposed solutions:
In the ui:

make the Stop() call async. Pretty straight forward, and might just work. Might also cause there to be visible lag between the click and the various updates of the ui (might still be better than freeze?).

In the lib:
2. return after OnStoppedTimerState and do whatever needs 180ms on another thread, and call the syncing from there.
3. get rid of whatever needs 180ms.
Thoughts?

Needs lib investigation @tanel

Seems we have rewrote the stop part and sync is always done in separate thread.


[BUG] minimize doesn't behave as expected

It looks like Simple Calendar is overriding Application's minimize in a very non-standard way. It basically makes it impossible to programmatically minimize it since calling minimize behaves as a toggle instead of actually minimizing it.
Is there a correct way to minimize the calendar that doesn't toggle it back and forth?

The minimize of the calendar toggles the view between the full calendar and the compact calendar view.
It can't be minimized to just a title bar.

I've got a mod for pf1. Its goal is to make it so that templates follow the actual pf1 rules (so things like "circle templates must be placed on a grid intersection, cones must originate from a token, and other quality of life improvements for templates). One of the things I do is that when someone uses an Item that creates a template, I minimize all of the windows that are currently maximized so that the player can see the scene.
Essentially it's something like this
const windows = Object.values(ui.windows).filter((x) => !x._minimized);
await Promise.all(windows.map((x) => x.minimize()));

// code for placing template

await Promise.all(windows.map((x) => x.maximize()));

But when the window for Simple Calendar exists, its !_minimized is always true. This makes it so that I call minimize and then it toggles between the small/full view whenever someone places a template.
I've got a workaround right now that I'm not super fond of, so I was wondering if you have any suggestions on the best way to work Simple Calendar into this flow

I thought about this more and have changed my mind. I have updated the minimize and maximize functions for the calendar app to behave as you would expect while keeping the toggle between compact and full when the header is double clicked.
Version 2.4.12 will have this update.

Awesome, greatly appreciated <3


Spring boot properties jndiName ==> jndi-name

Pull Request Test Coverage Report for Build 7927

1 of 1 (100.0%)  changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 55.014%

Totals

Change from base Build 7926:
0.0%

Covered Lines:
8651

Relevant Lines:
15725

💛  - Coveralls


Fix AttributeNames for sqs.receive_message

Fixes #3607

Codecov Report

Merging #3736 (0b04d9a) into master (6da8dc0) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #3736   +/-   ##
=======================================
  Coverage   94.78%   94.79%
=======================================
  Files         437      437
  Lines       47905    47920   +15
=======================================
+ Hits        45408    45425   +17
+ Misses       2497     2495    -2

Flag
Coverage Δ

servertests
56.14% <76.47%> (+<0.01%)
:arrow_up:

unittests
94.65% <100.00%> (+<0.01%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

moto/sqs/responses.py
95.40% <100.00%> (+0.25%)
:arrow_up:

moto/iam/models.py
95.27% <0.00%> (+0.14%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6da8dc0...0b04d9a. Read the comment docs.

@bblommers please have a look regarding the parameterized tests.

#3751 after the fix is merged, this is good to go!

This is now part of moto >= 2.0.2.dev5


Scala Common Enrich: calculated derived_tstamp_local

As in, the derived_tstamp in local time. Useful for understanding e.g. what daypart the user was in when an event occurred.

Need further tickets for Redshift, Postgres etc.
Depends on: #1550

Migrated to https://github.com/snowplow/enrich/issues/149


Question: TS lint error when used with nuxt-ts

Hi:
My store looks like this store/index.ts:
export const state = () => ({
  version: DEFAULT_APP_VERSION as string,
  loggedIn: false,
  userId: null as number | null,
  userName: null as string | null,
  userIdentity: null as string | null,
  userRole: null as UserRole | null,
  userMunicipios: [] as string[],
  busy: false,
  lastRequestedPath: null as string | null
});

type RootState = ReturnType<typeof state>;

export const getters = getterTree(state, {
  getVersion: (state) => state.version,
  isLoggedIn: (state) => state.loggedIn,
  getUserId: (state) => state.userId,
  getUserName: (state) => state.userName,
  getUserIdentity: (state) => state.userIdentity,
  getUserRole: (state) => state.userRole,
  getUserMunicipios: (state) => state.userMunicipios,
  isBusy: (state) => state.busy,
  getLastRequestedPath: (state) => state.lastRequestedPath
});
...
...
export const accessorType = getAccessorType({
  state,
  getters,
  mutations,
  actions
});

I have the following on index.d.ts:
import { accessorType } from "@/store";

declare module "vue/types/vue" {
  interface Vue {
    $accessor: typeof accessorType;
  }
}

declare module "@nuxt/types" {
  interface NuxtAppOptions {
    $accessor: typeof accessorType;
  }
}

On my component layout/default.vue:
<script lang="ts">
import { defineComponent, computed, ref, reactive } from "@vue/composition-api";
export default defineComponent({
  name: "default",
  setup(_props, { root }) {
    const title = computed(() => root.$accessor.getVersion);
    const version = computed(() => root.$accessor.getVersion);
    const loggedIn = computed(() => root.$accessor.isLoggedIn);
    return {
      title,
      version ,
      loggedIn
    };
  }
});

yarn build (nuxt-ts build) and yarn dev (nuxt-ts) works but my IDE (Intellij 2020.2) shows previous error, how can I remove the error, any idea?
yarn --version: 1.22.4
node --version: v12.18.3
vue --version: @vue/cli 4.5.3
yarn list nuxt<EMAIL_ADDRESS>yarn list @vue/composition-api<EMAIL_ADDRESS>

@userquin I typically see this error if there is a problem in a type declaration file (might not be index.d.ts) - such as attempting to augment an interface in a non-module file (i.e. without importing something else).
Alternatively, it might be something specific to Intellij that I won't be able to help with.
Could you provide a reproduction? That might help narrow down the issue.

@danielroe thx, last update of intellij just works (was reproducible on 2020.2 but not on 2020.2.1), so I think this was an issue on intellj

@userquin Glad things are sorted!


[BUG] Engine Image Reference Count way too high

Describe the bug (🐛 if you encounter this issue)
I updated from v1.4.1 to  v1.4.2 today.
After opening the webpage, I saw all volumes also needs to be updated to the new engine.
Followed this guide and they all upgraded successfully.
At the last step it mentions deleting the old "engine image".
unable to delete engine image: unable to delete the engine image while being used
When I go on this page, the ref count is at 356 (!) What are they?
I only have 12 volumes in my cluster. 3 replicats for each.
I could understand having to restart the pods where the volumes are mounted, but I don't understand where that huge number comes from. Seems like a leftover ref count that did not decrease properly.
I have the same issue with Instance Manager Image, version 1.4.1 remained with refcounts (3 / 4 and 5 respectively) while the ones under 1.4.2 seems to shows 12 on all nodes, which should be the proper number, so they did transfer correctly. For this section we can click the instance manager name and see the volumes, the same is indeed present in both version.
Expected behavior
Ref count drop to 0 so I can delete the old image.
Environment

Longhorn version: 1.4.2
Installation method (e.g. Rancher Catalog App/Helm/Kubectl): Helm
Kubernetes distro (e.g. RKE/K3s/EKS/OpenShift) and version: microk8s 1.26.4

Number of management node in the cluster: 3
Number of worker node in the cluster: 0

Node config

OS type and version: Ubuntu 22
CPU per node: 2
Memory per node: 10gb
Disk type(e.g. SSD/NVMe): sas
Network bandwidth between the nodes:

Underlying Infrastructure (e.g. on AWS/GCE, EKS/GKE, VMWare/KVM, Baremetal): VMWare
Number of Longhorn volumes in the cluster: 12

closed in favor of #5902


[Issue from React Navigation] Re-render previous screen when navigate to new screen.

This is bug from react navigation in early 2. version.
Sorry i can create a new expo. You can use your example to test.
react-navigation-fluid-transitions: 0.2.2
react-navigation: 2.2.0
react-native: 0.55.4

Hi, @ducpt2 - thanks for the issue, unfortunately I need a reproduction to be able to test to avoid spending all my time building reproductions.

Sr but it can use your simple source to test.
Only simple Navigate from screen 1 to screen 2. Screen 1 will re-render. That all!
I love your work. Thank you so much.

Ok, it needs to be rendered to calculate positions and sizes - do you see any performance degradation or other problems related to rerendering?

@chrfalch if i using react-native-map, the view will re-render, it will back to first position when user came in Map. And if i have too much Marker, the problem will come.
Thank you for your quick response.

Ok, so if you can create a simple example on Expo with a map and some markers I can look into it :)

@chrfalch  Let me try. I'm not work with expo... :(
If you can add my skype can i send you my zip code? Or mail pls?
Really want to help.

You can try zipping it down, but I will not be able to test this if it is your complete app - I need a small reproduction that exhibits this case only.

Yeah i will create a simple zip code. First, let me try expo :)
skype: ducft2511
mail<EMAIL_ADDRESS>

@chrfalch sr i can't create an expo. Can you contact with one of my connection(skype, mail)? And i will send you my zip code.

You should be able to attach it to the issue, just make sure the zip is small ;-)

Closing due to inactivity.


fix: disable hotkeys on swap form inputs

Fixes issue with hotkey triggering on ticker input on /swap

Hey thanks for that, got it in as part of some other substantial changes so closing this one.


Support highlights in Resource Monitor`s admin log

Setting: Config.adminloghighlights

Can't you just highlight on the text itself?

See http://logs.psim.us:8080/<super_secret_room>/2015-09/2015-09-29.html#20:46

I mean, you can add the text in the monitorlog to your personal highlight list

That would allow false positives and false negatives for the notifications (consider that highlights' lists are global), but it's up to you.

I would rather not have something like this in core. In theory, it should be easy enough to mod ResourceMonitor directly in Config if it's that big of a problem.

Hmmm yea... I suppose resmonitor's logging system is already specific enough.
I don't think it's very important to keep track of Config implementation, so I'm closing.


Drone takes off unstably

I just started using this library with my ar drone 1.0 and whenever I type takeoff() in the terminal the drone would take off but it would go everywhere and it wouldn't have a stabilized hover which I find really weird, what could be the problem ?

Before taking off, try doing a "flat trim" by running ftrim() and see if that makes a difference.

Oh I fixed this already , got it to work properly, all you had to do was reset the drone and it flies like normal again lol to anyone that has this problem

Thanks tho wiseman

Glad to hear you figured it out!


If enabled in Chrome I can't view some PDF files

I just get a blank screen when I view a PDF if this is enabled.

Thank you for reporting this issue!
I just tried accessing http://www.orimi.com/pdf-test.pdf and that rendered fine for me with the extension enabled. Does that also render blank for you? If not, then could you provide a URL to a PDF that reproduces the issue? Also, do you have any other extensions enabled and could you go to http://www.whatsmybrowser.org/ and share your URL, so I can see exactly what OS/version that you're using?

http://www.nanaimo.ca/assets/Departments/Building~Inspection/Publications~and~Forms/Building Stats 2015.pdf this was the most recent PDF I had issues with. I disabled all my extensions one by one until it worked.
The Test Link loaded once for me blank but a ctrl+F5 let it load. It's been hard to repeat on most PDF's till I found the above link and it was 100% of the time failed.
http://whatsmybrowser.org/b/FTG6A9J
I'm going to disable all my addons and isolate it after I post this.

Thank you for your time. I'm going to be closing this issue as I found that Chrome PDF gets flaky with multiple addons enabled. No single  Addon caused the issue but it looks like combinations of addons caused trouble. JWT Just seemed to be the one that in my list kicked me over the limit.
http://imgur.com/a/yuEbH

Thanks for letting me know about this! I actually created a new issue for this to minimize the likelyhood of this happening. See #8.


PendingGroup doesn't clean up that causes proxy can't start bootstraping or grouping

Version : Beta 1.0
In the following case, proxy can't start bootstraping or grouping.
Currently cleanUpOldestExpiredPendingGroup is in signalDissolve that only check the length of expiredWorkingGroupIds.
If there is no expiredWorkingGroup then it would not clean up expired pending group.
|WorkingGroupSize :0
|ExpiredGroupSize :0
|PendingGroupSize :3
|PendingNodeSize  :138
Suggestion:
CleanupExpiredPendingGroup needs a separate guardian function .

Fixed in 1bc08ab95abf9abe62212cbaaef237e5215ed5e3


Apollo support

Is possible to add Apollo  library support ?
If add chuck to interceptors, Apollo broken parse.

@duanniston  yes this library support Apollo as well.

@Ashok-Varma @jgilfelt No I am using chuck along with apollo but calls are not getting recorded. Previously when we were using simple rest apis it used to work fine.

@debajyotibasak Do you have a project to share that I can take a look?
This library is no longer maintained and I'm taking care of a fork of it: https://github.com/chuckerTeam/chucker
I'd love to add Apollo support to it.


Recorder/Replay system?

How plausible would it be to get a replay system similar to how Nvidia's Instant Replay works?
Pressing a hotkey would save the last 1-10 minutes of gameplay.
Temporary files cleaned out regularly.
Seems like a massive project, but would make this client great.

I closed similar issues in past, implementing our own video recorder is simply unreal, just use existing software that does it better.

You can use OBS for this.


Fix compile errors

Some import paths were not compatible with python3.6
The g++ compiler on MacOS installed through Homebrew seems to rely on MacOS SDK built with clang, for which __unused is a reserved word (an attribute), therefore variables cannot be named __unused.

@tbennun @acalotoiu Thank you for the review. I am not an authorized user for this project, so merging is blocked.


Pretrained model of BebyGAN for upsacling factor 2 and 3

Please provide us the pretrained model of BebyGAN for upsacling factors 2 and 3.

Sorry. Following previous work, we only conducted experiments on the x4 setting.

@fenglinglwb Is it possible to train the model for upscaling factors 2 and 3 on our own?

Sure. You could first train an RRDB backbone using L1 loss for initialization, and then train the initialized model using GAN loss.

@fenglinglwb Thank you so much for your prompt reply. What changes do we need to make to the training code if we want to train the model on our own dataset?


CUDA tests: reduce managed memory allocation to 0.1 * GPU RAM

0.5 * GPU RAM can allocate a sizeable proportion of system memory, which can cause stability issues. This change reduces the proportion of GPU memory allocated to 0.1 to make testing more resilient.
This may be involved in Issue #6371.
@stuartarchibald Could you try this on the buildfarm to see if any issues occur with this change please?

Note: The fail is just a Conda HTTP 500 error.

Thanks for the patch.
Buildfarm ID: numba_smoketest_cuda_123

Buildfarm ID: numba_smoketest_cuda_123

This failed. Segfault. Windows 64bit, Python 3.8, NumPy 1.17, CUDA 9.0. numba.cuda.tests.cudapy.test_multithreads.TheMultiThreadCompiling, self.assertEqual(p.exitcode, 0) fails as p.exitcode is 0xC0000005.
Same as 1. on https://github.com/numba/numba/issues/6371 but with different packages involved.


framebuffer

References:

https://www.rpi4os.com/part5-framebuffer/

I have to find a new way to run make run. Currently, I run make run on Asahi Linux while I connect from iPadOS to it using SSH, but it can't show a window.
Alternatives:

Using VNC

https://wiki.archlinux.org/title/QEMU#VNC

Using UTM
Using X11 forwarding

I chose VNC. My environment is a little bit special, so I don't intend to add the following steps to README.md.
(Fedora Asahi Remix 40)

Install dependencies

doas dnf install pixman-devel

Build QEMU again with VNC enabled

./configure --enable-vnc
make -j8
doas make install

Modify Makefile-       $(QEMU) -machine raspi4b -kernel $(IMG) -serial stdio
+       $(QEMU) -machine raspi4b -kernel $(IMG) -serial stdio -display vnc=<IP_ADDRESS>:0

Run make run
Connect to <IP address>:5900 from a VNC client (e.g. Screens or RealVNC Viewer)

https://github.com/kkebo/swift_os/wiki/Debugging-with-VNC


Wrong OS version in node pool leads to ambigious error message

A wrong OS Version in the node pool will fail the provisioning of the SKE-Cluster but will show a ambigious/misleading error message.
The OS version 3602.2.1 does not exist.
resource "stackit_ske_cluster" "cluster" {
  project_id         = var.stackit_project_id
  name               = "example"
  kubernetes_version = "1.26"
  node_pools         = [
    {
      name               = "pool-reg-t04"
      machine_type       = "g1.2" # 2 CPU, 8 GB RAM
      # this os version doesnt exist anymore
      os_version         = "3602.2.1"
      minimum            = "1"
      maximum            = "5"
      max_surge          = "1"
      availability_zones = ["eu01-3"]
      volume_size        = 30
      volume_type        = "storage_premium_perf1"
    }
  ]
}

module.ske_cluster.stackit_ske_cluster.cluster: Creating...
╷
│ Error: Error creating/updating cluster
│
│   with module.ske_cluster.stackit_ske_cluster.cluster,
│   on modules/ske_cluster/main.tf line 1, in resource "stackit_ske_cluster" "cluster":
│    1: resource "stackit_ske_cluster" "cluster" {
│
│ Calling API: 400 Bad Request, status code 400, Body:
│ {"code":"InvalidArgument","message":"invalid input: cluster with name
│ \"example\"","details":""}

I would expect to receive a error message indicating that the OS version does not exist.

Hi @robertadesso1, thanks for opening the issue.
We have this in our backlog and will work on it soon.

This enhancement has been done in the latest version of the provider v0.18.0


Updated the standalone example with the latest docker version

I started to the test Kafka Lag Exporter against a Confluent Cluster and failed with some strange timeout and EOF exceptions. It turned out that the docker was not up to date in the run-docker.sh. I updated the docker image version and also added another cluster example with sasl support (not sure if it's generally interesting xd).

Hi @judomu,
Thank you for your contribution! We really value the time you've taken to put this together.
Before we proceed with reviewing this pull request, please sign the Lightbend Contributors License Agreement:
https://www.lightbend.com/contribute/cla

Thanks. I'll update the release script to update the version too.


Update go.mod

This makes the package installable via go install

`o, yes that's right. I missed that during the move.
Would you please update the other files ?

@mloiseleur done!

Thanks !


Add close() method to connectionPool so connections are closed when origins are reloaded

We were missing a ConnectionPool.close() method that will close open connections when an origins file is reloaded.
We are just invoking Connection::close() without modifying the metrics as, in most cases (except when the origin is removed), they would be overridden by the new SimpleConnectionPool for that origin server. We can discuss this to see what's the best way to implement it.
We can also discuss what's the best meaningful test we can implement. I guess we could add a global counter for the tota number of connections opened / closed (not per origin but global!). We might also have to locate all the code paths that should trigger a pool closure  and add assertions for those in unit tests.
Of course, this PR does not prevent us from leaving connections pool that hadn't been returned to the pool (they are not in "availableConnections") at the moment the pool was closed.

Hi @dvlato this PR doesn't have any effect unless the pool consumer calls the close() method.
We need to check the following pool consumers:

BackendServicesProxy & OriginsInventory
HostProxy
ProxyToBackend class

Going forward, the HostProxy is the only class that will survive our refactored Styx Core. The other two/three will disappear. Hopefully soon.

Of course, this PR does not prevent us from leaving connections pool that hadn't been returned to the pool (they are not in "availableConnections") at the moment the pool was closed.

I suggest: Add a closed flag in the connection pool. Set it true when the pool is closed. Then in the returnConnection check the flag and close the returned connection when the pool is closed:
    public boolean returnConnection(Connection connection) {
        borrowedCount.decrementAndGet();

        // This is the new bit:
        if (closed) {
           connection.close();
        }

        if (connection.isConnected()) {
            queueNewConnection(connection);
        }
        return false;
    }

Travis fails due to check style error:
[ERROR] src/main/java/com/hotels/styx/client/connectionpool/SimpleConnectionPool.java:[99,29] (whitespace) ParenPad: '(' is followed by whitespace.


Hint: For Loop var should not be field

This issue was originally filed by<EMAIL_ADDRESS>
What steps will reproduce the problem?

create fields: var id="Hello"; var list=["Blubb"];
have a loop: for (id in list){}
notice that id is now "Blubb"

What is the expected output? What do you see instead?
The code works as programmed. It however is questionable whether any reasonable developer would ever want to write such code. It is more likely that this may happen by accident. It should produce an error, unless I am missing some really important use-case.
This becomes even more annoying when it is used in for example a polymer element where you are not directly seeing id in your code..
What version of the product are you using? On what operating system?
Dart Editor version 1.2.0.dev_03_02 (DEV)
Dart SDK version 1.2.0-dev.3.2

Sounds like this could have false positives, when people rely on this "feature." Maybe an "analyzer-linter" instead?


Kedrain Monta Swann court case

Someone has requested help on a data project:
Submission notes
Looking for information on Kedrain Monta Swann cases and lawsuits.
Location
Orange County
Requirements
Court case
How to help
Leave a comment if you'd like to help. Do you have ideas, questions, or need any more information to get started?

Found 3 unrelated cases searching for the alleged shooter https://portal-nc.tylertech.cloud/Portal/
Granted by finding the docket numbers via "inmate search", and calling the courthouse who confirmed the case could be accessed only in person.


Callback for node each

My English is bad.
I propose to add the call callback function for  node each.

I think this covered in v2.0, check out develop branch README and events section.

In v2 you can use the onNodeRendered callback, a new lifecycle event triggered after each node has finished rendering updates.


issue 271 true | IContainChainsOptions

passing an object implementing IContainChainsOptions instead of a boolean seems to solve a small type error

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot

Thanks for the PR! BTW - Which version of TypeScript caught this?

or was it a runtime error?

It was a compile error, caught by typescript 2.4 AFAIK,
well, To be frank, I just started typescript a few days ago. I think it was on typescript 2.4.x , failed with this error, I think I downgraded to 2.1.6 and then it compiled ^^
Right now, clean build from my fork and this repo master branch, upgraded nodejs to 8.1, new folder, typescript installed seems to be 2.4.1 and the only build failure seems to be this one. Still trying to get the hang of this (I'm more of a python or C# expert)


Adding custom attributes to applications

Description:
API Manager 2.2.0 does not have the capability of accepting user-defined attributes through applications. There might be some instances where users need to add custom attributes against applications.
Suggested Labels:
Features, APIM 2.2.x WUM Update
Suggested Assignees:
N/A
Affected Product Version: 2.2.0
OS, DB, other environment details and versions:  N/A
Steps to reproduce:
N/A
Related Issues:

Please find user story document in [1].
[1] https://docs.google.com/document/d/18OMI3sjHETOcKfQ5fldm4Inf4gsU1TxDrhfs2l9GfhI/edit?usp=sharing

Please find the documentation for this feature in [1].
[1] https://docs.google.com/document/d/13vloz2Kwa7PlkJquSTM0cxfR5ZCWnn64lpAe-SpUXjo/edit?usp=sharing

Fixed with https://github.com/wso2/carbon-apimgt/pull/5392.


Typing issue

How do you use Sentry?
Sentry Saas (sentry.io)
Version
1.32.0
Steps to Reproduce
In the following snippet i am changing a super signature with a subclass, using mypy or any other static type checker this is mark as an error, but when the sentry decorator is added (as in the example) the error is hidden.
import sentry_sdk

class A:
    def foo(self, bar: int) -> int:
        return bar

class B(A):
    @sentry_sdk.trace
    def foo(self, bar: str) -> str:
        return bar

The issue is in the following lines:
https://github.com/getsentry/sentry-python/blob/085595b5f02931a3268c2de2a58b6986f3766d75/sentry_sdk/tracing.py#L958-L959
the decorator is changing the signature of both input and output to Any. This is not the expected behavior since the function will not actually be changed. And because the original signature expects integers, but the overriden one expects strings (which are not compatible) but when type checking the checker all it sees is "any" then because int is part of any is not giving any error when it should.
This can be easily fix by using a TypeVar in this case, like so:
from typing import TypeVar

T = TypeVar("T")

def trace(func=None):
    # type: (T) -> T

Expected Result
Type checker (like mypy) complains that the signature is not correct
Actual Result
Type checker (like mypy) doesn't complain at all, the bug is hidden

Hey @agusdmb, thanks for reporting this. I imagine the challenge here (and maybe the reason why we went with Any here) is to do this in a way that's compatible with all Python versions we currently support (2.7, 3.5-3.11).

Hey @agusdmb, thanks for reporting this. I imagine the challenge here (and maybe the reason why we went with Any here) is to do this in a way that's compatible with all Python versions we currently support (2.7, 3.5-3.11).

im not sure if this would work on python 2.7 (which is deprecated now, i couldn't find in the documentation about the TypeVar) however:

it will certainly work for python 3.5 an above
there is plenty of usages of TypeVar in some other modules so i guess it wouldn't be a problem for python 2.7 (https://github.com/search?q=repo%3Agetsentry%2Fsentry-python typevar&type=code)

let me know if im missing something or if you need anything else from me.
BTW, this is how i "fixed" it for my usage:
from typing import Any, Callable, TypeVar

import sentry_sdk

F = TypeVar("F", bound=Callable[..., Any])

def trace(func: F) -> F:
    return sentry_sdk.trace(func)  # type: ignore[no-any-return]

i am now using that trace instead of the sentry one

this might not seem like a big issue, but here at Nebuly we have the whole code base type hinted, and we recently started using sentry to find get more insight from different issues, but in some cases loosing the type hint caused more issues than the ones it helped discover with the traces

im not sure if this would work on python 2.7 (which is deprecated now, i couldn't find in the documentation about the TypeVar) however:

it will certainly work for python 3.5 an above
there is plenty of usages of TypeVar in some other modules so i guess it wouldn't be a problem for python 2.7 (https://github.com/search?q=repo%3Agetsentry%2Fsentry-python typevar&type=code)

Thanks for investigating, you're right, one of the occurrences, for instance, is in the WSGI integration, which is used across all Python versions, so looks like we're not as strict about type hints as I thought. Which makes sense, since in 2.7 typing was a rather niche thing, unlike now, so it's mostly important it works in newer versions.
In that case, your TypeVar suggestion sounds good!

let me know if im missing something or if you need anything else from me.

All good!
We probably won't get around to doing this soon, but PRs are very much appreciated -- I'll mark this as good first issue so that more folks see it and maybe someone has time to look into it earlier than we would.

@sentrivana ok great to hear that
i have considered opening a PR but i wanted to make sure the change was welcome before investing time on it... i can give it a try in the coming days
thanks


It always open either PlayStore

This is code in my app always opens Instagram in the Play Store.
AppLink.maybeOpenURL("com.whatsapp", { appName: "Whatsapp", appStoreId: "", playStoreId: "com.whatsapp" })

Please what could I be doing wrong

What you probably want, is an Intent launcher like Expo's IntentLauncherAndroid API => https://docs.expo.io/versions/latest/sdk/intent-launcher.html
Using that will open the Whatsapp Android activity without attempting to access a specific route/action.
The first parameter, url is for deep linking into an app. To do that, you'd need a Whatsapp specific url like whatsapp://send?text=helloworld.
I have no idea why Instagram would be opening, by the way.
I hope I helped a bit!

@fiber-god Sorry. I meant to say whatsapp not instagram.
With respect to the Expo IntentLauncherAndroid, what is required is ACTION_VIEW, but as it stands, Expo does not have it.
Thanks for your help

Expo's intent actions are actually just pure strings, so even if it doesn't have something you need already defined, you can still use it by passing in the intent string you need. https://github.com/expo/expo-sdk/blob/master/src/IntentLauncherAndroid.js#L81

See the constant value here: https://developer.android.com/reference/android/content/Intent.html#ACTION_VIEW

If you want, you could submit a PR adding that ACTION_VIEW intent here: https://github.com/expo/expo-sdk/blob/master/src/IntentLauncherAndroid.js

@fiber-god I tried the ACTION_VIEW,
here is the code I used
await IntentLauncherAndroid.startActivityAsync(IntentLauncherAndroid.ACTION_VIEW)

and this is exception I got
 [Unhandled promise rejection: Error: Specified activity was empty]
- node_modules/react-native/Libraries/BatchedBridge/NativeModules.js:123:42 in createErrorFromErrorData
- node_modules/react-native/Libraries/BatchedBridge/NativeModules.js:80:57 in <unknown>
- ... 5 more stack frames from framework internals

In this page, ACTION_VIEW is missing

Here's what you want, I can confirm it works: ```
AppLink.maybeOpenURL('whatsapp://send', {
appName: 'WhatsApp',
appStoreId: '',
playStoreId: 'com.whatsapp',
});

@smithaitufe does this solve your issue?

Nope. I will close it tonight once I find a solution and I will report back

Maybe you simply don't have Whatsapp installed on your device? The code I proposed seems to fulfill your needs, opening Whatsapp right?


Assignment 2 submission

What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)
Completion of survey creation for A2
What did you learn from the changes you have made?
Considerations for inclusivity, ethics, privacy, etc., when creating a survey
Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?
n/a
Were there any challenges? If so, what issue(s) did you face? How did you overcome it?
n/a
How were these changes tested?
n/a
A reference to a related issue in your repository (if applicable)
n/a
Checklist

[x] I can confirm that my changes are working as intended

A2: PASS
It would be best if you add answers to select from on your questionnaire (i.e part a-d). This will prevent you from collecting data and answers with a lot of variability.


[React incubation] fixing browse routing

This regression was introduced by https://github.com/linkedin/datahub/pull/2060
Checklist

[x] The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
[x] Links to related issues (if applicable)
[x] Tests for the changes have been added/updated (if applicable)
[x] Docs related to the changes have been added/updated (if applicable)

I'm confused as to how this wasn't caught in the previous PR. Is the application not throwing the typescript error when you try to build it?

I'm confused as to how this wasn't caught in the previous PR. Is the application not throwing the typescript error when you try to build it?

@cptran777 you're correct- it does throw a typescript error on build. Not sure exactly how it snuck in, it rode along in the last commit https://github.com/linkedin/datahub/pull/2060/commits/c79fb8b724fb8e96c6a4092991313faba3c958ff. We're going to set up some basic CI soon so issues like this won't be able to sneak by due to human error in the future.

@cptran777 you're correct- it does throw a typescript error on build. Not sure exactly how it snuck in, it rode along in the last commit https://github.com/linkedin/datahub/pull/2060/commits/c79fb8b724fb8e96c6a4092991313faba3c958ff. We're going to set up some basic CI soon so issues like this won't be able to sneak by due to human error in the future.

There's a build-and-test action that runs on every commit of every PR and just runs ./gradlew build. Which, afaik, builds everything, right?
https://github.com/linkedin/datahub/blob/master/.github/workflows/build-and-test.yml

There's a build-and-test action that runs on every commit of every PR and just runs ./gradlew build. Which, afaik, builds everything, right?
https://github.com/linkedin/datahub/blob/master/.github/workflows/build-and-test.yml

@jplaisted thanks for directing me to that. In that case we have two options

extend the build task to build the react app as well. Upsides: we dont need to add a new action. Downsides: if the react app CI breaks, it affects non-react prs

create a new action parallel to build-and-test that only runs on changes to datahub-frontend-react. Upsides: breakages in react won't affect non-react prs. Downsides: we have two CI actions.

Thoughts?

@jplaisted thanks for directing me to that. In that case we have two options

extend the build task to build the react app as well. Upsides: we dont need to add a new action. Downsides: if the react app CI breaks, it affects non-react prs

create a new action parallel to build-and-test that only runs on changes to datahub-frontend-react. Upsides: breakages in react won't affect non-react prs. Downsides: we have two CI actions.

Thoughts?

My 2c : let's not allow the react app to be broken.
So include the react app in the main gradle build.

My 2c : let's not allow the react app to be broken.
So include the react app in the main gradle build.

To be clear with gradle just add it to the settings.gradle file. It'll include it as a submodule, knowing it should build it and also treat it as a module in intellij, etc

To be clear with gradle just add it to the settings.gradle file. It'll include it as a submodule, knowing it should build it and also treat it as a module in intellij, etc

I agree, that even in incubation if there's such an obvious issue as "the react app doesn't build properly" that should prevent a PR from being merged.

I agree, that even in incubation if there's such an obvious issue as "the react app doesn't build properly" that should prevent a PR from being merged.

@jplaisted great- will do that in a followup.

@jplaisted great- will do that in a followup.

@gabe-lyons Maybe add it to this PR, so we know this PR is safe to merge ;)

@gabe-lyons Maybe add it to this PR, so we know this PR is safe to merge ;)

@shirshanka good idea- added

@shirshanka good idea- added

@cptran777 removed 👍

@cptran777 removed 👍