Issue #323 iPad support for multi-video

The pull Includes:

A new param to force iPad but not force Android/Chrome into native HLS

iPad supports single video in HLS.js but multi-video event requires native HLS

Android/Chrome returns maybe for native HLS support, but throws error when it tries

Using "forceNative" will override the "forceNativeForIOS" value and force all that can be forced to use native HLS
-- Using "forNativeForIOS" will only force IOS platforms to use native HLS

A utility to detect iPad and iOS (non-optimal, but works in our live testing)
removal of deprecated HLS config params
patch for seeking outside of video duration at the end of the video, and start of the video
patch for setting value-less HTML attributes (muted, playsinline, autoplay)
Add the content name ('presenter', 'presentation', 'other', etc) to debug logs

Native HLS support was implemented only for iOS, because in this case it is not supported by Media Source Extensions (iPadOS is supported).
The forceNative parameter was implemented due to your request, but I can't identify any case where it is better to use the native version, could you explain it to me? I don't like at all how the HLS player is getting, it started quite simple, and now we are adding a lot of patches. From my experience with Paella 6, this is not a good idea.
As for iPad detection, the problem with the UserAgent stems from the fact that Safari is configured by default to display desktop web as of iPadOS 16. If the user disables this option, the iPad detection code you added stops working. I don't like to add such hacks that tend to fail when an operating system update is released.
But the problem is not related to the userAgent, but that the volume APIs are not available. So I would choose to detect if the volume APIs are available. I am finishing a function that detect this case independently of the platform. The idea is to create an audio element in JavaScript, modify the volume and query if it has changed. It is not as simple as it sounds, because sometimes the response is asynchronous, so you have to implement this function by capturing the volumechanged event, but with the tests I am doing it seems to work fine. This new function will be available as a utility inside the VideoPlugin

The motivation for this patch

iPad will play a single video event, but will fail to load the videos on a multi video event (the second load video await never returns)
Android/Chrome fails if forceNative =  true.

This patch resolves the above by adding extra param to only force iOS devices, like iPad, to play native, which stops the Android/Chrome from attempting native.

I have not been able to find any example of multi stream videos failing on iPad with HLS, at least in our servers. Sometimes we have detected that it fails, but it has always been related with problems with the video. In that cases, the problem is not solved using the native player. I have also not been able to replicate the failure you say with iPad videos returning negative times.
Here are some examples of our OpenCast service:
https://engage.videoapuntes.upv.es/paella7/ui/watch.html?id=bcce8190-1012-11ee-9f15-7b8970428ebd
https://engage.videoapuntes.upv.es/paella7/ui/watch.html?id=9f4fc780-5b6e-11ee-b12b-6f298397837a
https://engage.videoapuntes.upv.es/paella7/ui/watch.html?id=3531ff40-48df-11ee-87d0-2b62c15b0638
This is the HLS example in paella player site:
https://paellaplayer.upv.es/#/demos/hls-multiquality
Maybe you should check your streaming server configuration. You can also try to modify the hls.js library configuration, but I'm afraid that I won't be able to help you with HLS configuration issues.
As for Android, completely removing forcing to native mode would eliminate the problem, because in the previous version without forcing hls.js was always given priority.

That UPV links plays Ok in iPad per our QA team. I'm closing this ticket for upstream. We'll retest with our workaround on the next UPV major upgrade.


add state to chainStore

Description
I need to be able to retrieve state by state_root
Acceptance Criteria

addState(state_root, state)
getState(state_root)

closed by #376


Better Topological Sort

This also should fix any bugs relating to loops, hopefully

This PR is superseded by #69.


TypeScript ACVM Simulator Caller

Pending LOAD function
Joss Getting Alvaro's help
MOST IMPORTANT, respond to the two LOAD opcodes

This issue is replaced with:

https://github.com/noir-lang/noir/issues/1236
https://github.com/noir-lang/noir/issues/1237


Sample Names do not appear in allocated Report column

Win10, Squid3-1.8.4
I have assigned my Sample names as follows, and this is all good.

What I am hoping for is that in my 'UnknownsReportPerSquid2.5' CSV, these Sample Names (precisely as ticked, with no assumptions about delimiters or character-counts) will appear in the dedicated 'Sample' column. Sadly, that column is currently blank:

Oops, forgot the SQUID file:
170111_GA6357_Sq3-184.zip

Fixed in v1.8.5 - to be released.


Fixing Category Icons on Blog

Fixing category icons on the blog.
Additions

Added new categories with their appropriate icons

Removals

Removed old category names

Changes

Made a small change to action-log/index.html to fix #511

Testing

Visit /blog/ to see it in action
This macro is also being used at /activity-log/, so test that page too.

Review

@anselmbradford
@sebworks
@jimmynotjim

Preview

Preview this PR without the whitespace changes
Notes

A lot of the posts don't have new categories and look blank like this. From my understanding, this is a longer-term issue and outside of the scope of the review.

sigh I don't know why it decided to pull in old commits like that. Closing and re-opening in a bit.


document tradestudy of flight software frameworks

Candidates can include:

F Prime
KubOS

Minimal deliverable:

[ ] should be an asciidoc file in at root directory, e.g., flight-software-tradestudy.adoc
[ ] should include a table with headers: criteria, weights, and candidates


[FEATURE] Imported folder(s) to playable playlist(s)

Currently if I were to wish to listen to my entire catalogue of music I'd have to manually go through each folder and enter the albums and add the tracks manually to playlist.
I wish to be able to just enter the folder and play directly from it, or at least convert it into a playlist. If this were to end up being too difficult there is still a way to at least hasten the playlist creation, and that is to allow you to add an entire album to a playlist as the menu already exists for individual tracks.

Hello @crackheadakira
I've encountered this issue when using the app myself and I plan to do something about it. I was thinking of ... adding an option somewhere to play a whole folder and everything under it (including subfolders) and another for converting or adding a folder or album into a playlist.
Keep an eye out for the next release. There's also some other great features and improvements planned.

Done ✅✅ ... available in next release.


ACCUMULO-4392: Expose metrics2 JVM metrics

Create process name from system property -Dapp and instance from -Daccumulo.service.instance if applicable
By passing the process name to JVMMetrics, it will add this tag to its MetricsRegistry and this tag will be added to all created metrics, allowing metrics consumers to deconflict JVM metrics from different service instances

FYI - used commit from ACCUMULO-4693 since the changes were the same.

Can one of the admins verify this patch?

@billoley
Okay, I'm merging this now. Since the implementation changed a bit in each commit, I'm going to squash it down and clean up the log message, so the commit logs aren't confusingly describing the implementations before the final one.
Thanks for the contribution! I hadn't realized this, but this looks like your first contribution to the Apache Accumulo project. If you'd like to be added to the contributors list at https://accumulo.apache.org/people , please file a pull request to update  https://github.com/apache/accumulo-website/blob/master/pages/people.md (or just let me know the details you'd want included here, and I can update the site for you).
Also, if you have a JIRA username, let me know what that is, so I can add you as a contributor there and so I can assign the https://issues.apache.org/jira/browse/ACCUMULO-4392 to you. Once added as a contributor in JIRA, you'll be able to self-assign issues, if you find any in the future you want to work on.

Closing this, as it was already merged as part of #291


Simplify #if preprocessor statements

While the #if preprocessor directive is powerful it can play havoc with source analysis tools, syntax highlighters and semantic code analysis when used to build fragments of statements that would otherwise be invalid.
This becomes more important as online analysis tools take off such as GitHub's C# support for semantic code features we've been working on over at https://github.com/tree-sitter/tree-sitter-c-sharp and with the rise of lightweight code editors such as VS Code that do not have a complete compiler at their disposal.
By simply restructuring these#if fragments we can make them lightweight-friendly allowing syntax highlighter and analysis tools to deal with them correctly.
There are only three places in the JSON.Net source code where partial-code fragments were in #if directives, they are:

SerializationErrorHandlingTests - easily solved with a dangling , between the sections
TextFixtureBase.cs - split the two possible functions out and is now much easier to read as well
JsonReader.cs - moved the #if outside of the if statement

Here is a screenshot from VSCode showing it struggling with TextFixtureBase:

Guessing this isn't going to be merged, closing it out.


Path collisions because of casings

Issue
What is the issue?
I just cloned the repository on Mac. I received the following warning during cloning:
warning: the following paths have collided (e.g. case-sensitive paths
on a case-insensitive filesystem) and only one from the same
colliding group is in the working tree:

  'cres/Limit size and number of uploaded files.yaml'
  'cres/limit size and number of uploaded files.yaml'
  'cres/Log access to sensitive data.yaml'
  'cres/log access to sensitive data.yaml'
  'cres/Secure communication.yaml'
  'cres/secure communication.yaml'
  'cres/Secure User Management.yaml'
  'cres/Secure user management.yaml'

e.g.

cres/Limit size and number of uploaded files.yaml, and
cres/limit size and number of uploaded files.yaml

Expected Behaviour
All files have unique paths irrespective of casing.
Actual Behaviour
Not all files have unique paths irrespective of casing.
Steps to reproduce
Run gh repo clone OWASP/common-requirement-enumeration on a Mac.

thanks for that, seems we have old files in the /cre/ folder i'll clean them up

this has been fixed for months, sorry for not closing it


Turn this into a real JS package

These changes turn this project into a first-class JS package! These changes include:

A new package.json
A build script which can be run through npm
A README section with an example of importing + running package modules
A README section about building minified JS
Updates all absolute imports to be relative so that they can be packaged

Probably a good question for discussion:

[ ] Is play.core the right name for this package if it gets published to NPM?

Love this project!

Hello, and thank you for your effort!
I'm not a fan of node and node packages in general so this won’t get merged.
I also wanted to avoid a double documentation in form of README and the manual, that’s why the readme is just a link to the full documentation. But you are right; the standalone / install / build section need to be expanded.
I added a MAKEFILE for minifying, even if it relies on globally installed npm packages it could quickly be adapted to local paths or to alternate build systems.
Unfortunately for now I can’t change the import paths as they are used on the playground as well: ES6 modules are loaded trough a hack for the live-code environment; but this might change with dynamic module imports which I didn't have te time to check – yet.
Again, thank you for the inputs!

I think the ability to distribute can only help. Why not do this? We could contribute and help you get the paths updated without breaking the playground. This is a seriously cool tool. Not being able to use it as a dependency makes it a bit odd in today's world and hard to maintain the project that is using it. Hope you take that into account and move to merge this.


Weapon Rolling Refactor in v1.1.9 Improperly Implemented

Describe the bug
As I understand it, weapon rolls were intended to have been significantly overhauled with the latest release. If the screenshots shown on PR69 are indeed the new expected behavior of weapon rolls, the implementation seems to have gone wrong.
The challenge dice icons in the chat are now excessively large. In previous versions as well as the PR69 screenshots, the dice are of a smaller size consistent with other dice rolls in Foundry.
The format of the screenshot shown in on PR69 is also not reflected in the current version. The character portrait and item image are both missing. The weapon qualities shown in the chat roll are also not present.
Finally, despite the item ID attribute being listed in included in the script, it is still not being included in the chat message. Instead of the item ID, the weapon roll contains "flavor text" with no usable information for Maestro or other such modules.
As far as I can tell, this is because what is being placed in the chat is not using the "generic item template" defined in roll.js, which is where data-item-id can be found, as well as the tags field which I believe should contain the weapon qualities.
To Reproduce
Steps to reproduce the behavior:

Create actor with type: character
Add an item under "weapons" category of character's belongings, with a damage of at least 1 challenge die
Roll the weapon
See result in chat messages. Inspect HTML element of the roll for confirmation of missing attributes.

Expected behavior
Weapon rolls should contain more information, including ID attributes and quality tags, as well as weapon and actor images, per the 1.1.9 release notes and screenshots shown in relevant pull requests. Presumably meant to use generic item roll rather than attribute roll.
Screenshots
Expected Weapon Roll:

Weapon Roll in 1.1.9:

Screenshot of the Weapon Roll HTML Element in 1.1.9:

At the end of the day I am acting under the assumption that the screenshots from PR69 are indeed indicative of the expected behavior in this version of the system. My programming expertise is also borderline nonexistent, so there is a good deal of supposition in this report, but hopefully it contains enough information for someone more capable than I to properly diagnose and solve the issues listed here.

Yeah that's not how it should look, this is a regression mistake pulled in from the upgrade changes. Let me see what I can do to get it back.

Yeah I've looked into this a bit more, there was a major refactor that I didn't notice had been done with the last upgrade that killed this functionality. It'll take me a bit to get it back (mostly cause I haven't looked at this code in a while) but I really want it back.

This should be fixed in the upcoming release for 1.1.10, currently is on the develop branch, the dice image is still a little large but the Id is being passed again, the properties are on the card again, and mostly appears to be returned to the older style. I'm on my laptop on a trip at the moment so I can't actually test against my normal setup but I think this should achieve the big asks here.
If there is anything else that I might have missed in your report, feel free to reply to this and/or re-open the issue and I'd be happy to take a look again! Thanks for the bug report and being so helpful with the info you gave!


Brightcom adapter: remove adapters

🏷 Type of documentation

[x] other

📋 Checklist

[x] Related pull requests in prebid.js or server are linked -> Paste link in this list or reference it on the PR itself

I've initiated a pull request to remove two adapters, Brightcom and BrightcomSSP, in the next major release. This is in line with our ongoing rebranding efforts and related to the next pull request https://github.com/prebid/Prebid.js/pull/10924

@prBigBrother usually we keep old adapters in the docs and you can add a disclaimer for the version since when the adapter is not available anymore and what should be used instead.
This makes it possible that old users still find the docs. Ultimately it's your decision, if you want to leave as few traces as possible and remove it for example if the old adapter will stop working entirely.


get_table_rows gets confused with all numeric account name

Works as expected.  Note, the account name (the 'scope') is alphanumeric like most other accounts:

$ curl --data '{"json":true,"code":"eosio.token","scope":"geydcmrxg4ge","table":"accounts"}' 'https://api.eosio.cr/v1/chain/get_table_rows'
{"rows":[{"balance":"0.1007 EOS"}],"more":false}

Possible bug, this account exists but did not return a balance record like the account above.  Note, the account name is all numeric:

$ curl --data '{"json":true,"code":"eosio.token","scope":"112233445511","table":"accounts"}' 'https://api.eosio.cr/v1/chain/get_table_rows'
{"rows":[],"more":false}

To verify, this account does exist and has a balance:

$ curl --data '{"account_name":"112233445511"}' 'https://api.eosio.cr/v1/chain/get_account'
{"account_name":"112233445511","head_block_num":15868066,"head_block_time":"2018-09-11T14:16:30.000","privileged":false,"last_code_update":"1970-01-01T00:00:00.000","created":"2018-06-19T17:26:45.000","core_liquid_balance":"0.0001 EOS","ram_quota":8149,"net_weight":1000,"cpu_weight":1000,"net_limit":{"used":0,"available":68388,"max":68388},"cpu_limit":{"used":0,"available":12652,"max":12652},"ram_usage":2996,"permissions":[{"perm_name":"active","parent":"owner","required_auth":{"threshold":1,"keys":[{"key":"EOS8H489DAGcEQdy8N4P2p7ubDFZxdX66DQQzxszEyG9WVEfgD4nu","weight":1}],"accounts":[],"waits":[]}},{"perm_name":"owner","parent":"","required_auth":{"threshold":1,"keys":[{"key":"EOS6kiq5qxqgLGMVqFtyWdfpPyLaUk7KrxAQwoBETf2AG4mxN8GpC","weight":1}],"accounts":[],"waits":[]}}],"total_resources":{"owner":"112233445511","net_weight":"0.1000 EOS","cpu_weight":"0.1000 EOS","ram_bytes":8149},"self_delegated_bandwidth":null,"refund_request":null,"voter_info":null}

Note that the correct balance is returned if the workaround is applied:
curl --data '{"json":true,"code":"eosio.token","scope":"<PHONE_NUMBER>11","table":"accounts"}' 'https://api.eosio.cr/v1/chain/get_table_rows'

{"rows":[{"balance":"0.0001 EOS"}],"more":false}

This is a parsing problem with JSON.  Account names are representations of 64 bit numeric identities, which the parsing code will default to when it sees a purely numeric value.  The workaround forces interpretation in string form.  Javascript parsers are typically loose, interpreting "112233445511" numerically to be "helpful".  The fc library used by EOS.IO follows that precedent rather than strictly interpreting only<PHONE_NUMBER>11 numerically.
This is a known limitation, and at present there are no plans to switch to strict parsing.


Capture errors from file close operation

This is to address issue outlined in https://github.com/fluxcd/pkg/issues/174. I am following the second recommendation from the blog to capture potential error from file close operation.

The only issue I see here is that you're not using the named return variables so the error would not be handled.
In this particular case would it be better to open the file in read only mode? It seems like the Close issue is around writing the file and here there doesn't appear to be any writes happening with the file.


Performance Issue

There's a noticeable spike in performance at regular intervals of about every 15 frames for me. I'm testing using the sender scene included in the demo.
Here's a snapshot of the profiler with four senders.

Which becomes much more apparent with eight senders. I'd expect a general drop in framerate, but this is more of a stuttering effect.

Which Unity version and graphics card?

Unity 5.3.3 and NVIDIA GeForce 750M, I've got access to a 980ti and a 780 if you'd like some further testing done.


KOGITO-8979 - Data Index Infinispan persistence addon

Assembly:

https://github.com/kiegroup/kogito-runtimes/pull/3209
https://github.com/kiegroup/kogito-apps/pull/1853

(tests) - kogito-runtimes job #3142 was: UNSTABLE
Possible explanation: This should be test failures

Reproducer
export BUILD_MVN_OPTS_CURRENT=-T 1C -Dvalidate-formatting -Prun-code-coverage
build-chain build cross_pr -f 'https://raw.githubusercontent.com/kiegroup/kogito-pipelines/main/.ci/pull-request-config.yaml' -o 'bc' -p kiegroup/kogito-runtimes -u https://github.com/kiegroup/kogito-runtimes/pull/3209 --skipParallelCheckout
NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution

Please look here: https://eng-jenkins-csb-business-automation.apps.ocp-c1.prod.psi.redhat.com/job/KIE/job/kogito/job/main/job/pullrequest/job/kogito-runtimes.tests.kogito-runtimes/3142/display/redirect
Test results:

PASSED: 3369
FAILED: 1

Those are the test failures:

org.kie.kogito.persistence.kafka.KafkaProcessInstancesIT.testFindByIdReadMode
expected: 5 but was: 0

Jenkins rerun kogito-runtimes tests


add BuildConfig docs and example

This commit adds the documentation and example for using
OpenShift BuildConfigs in Kedge

@cdrage @kadel made the changes, PTAL!

LGTM


fix for a bug introduced with media support in #8413

fix for a bug introduced with media support in #8413
data may be None if twitter data property not present in configuration
  File "./homeassistant/components/notify/twitter.py", line 63, in send_message
    media = data.get(ATTR_MEDIA)

Hi,
I am still getting an exception
Traceback (most recent call last):
  File "/usr/lib/python3.5/asyncio/tasks.py", line 241, in _step
    result = coro.throw(exc)
  File "/srv/hass/lib/python3.5/site-packages/homeassistant/core.py", line 1023, in _event_to_service_call
    yield from service_handler.func(service_call)
  File "/srv/hass/lib/python3.5/site-packages/homeassistant/components/notify/__init__.py", line 136, in async_notify_message
    yield from notify_service.async_send_message(**kwargs)
  File "/usr/lib/python3.5/asyncio/futures.py", line 361, in __iter__
    yield self  # This tells Task to wait for completion.
  File "/usr/lib/python3.5/asyncio/tasks.py", line 296, in _wakeup
    future.result()
  File "/usr/lib/python3.5/asyncio/futures.py", line 274, in result
    raise self._exception
  File "/usr/lib/python3.5/concurrent/futures/thread.py", line 55, in run
    result = self.fn(*self.args, **self.kwargs)
  File "/srv/hass/lib/python3.5/site-packages/homeassistant/components/notify/twitter.py", line 63, in send_message
    media = data.get(ATTR_MEDIA)
AttributeError: 'NoneType' object has no attribute 'get'

I had assumed this PR would take care of it. Should I open a new issue?


Cannot read property 'id' of undefined

Steps to Reproduce:

open empty window
open debug viewlet
open explorer
add 1 folder
add 1 folder
remove 1 folder
remove 1 folder

		Cannot read property 'id' of undefined: TypeError: Cannot read property 'id' of undefined
		    at DebugViewlet.ViewsViewlet.updateViewStateSize (file:///Users/bpasero/Development/Microsoft/monaco/out/vs/workbench/browser/parts/views/viewsViewlet.js:520:57)
		    at DebugViewlet.ViewsViewlet.updateViews (file:///Users/bpasero/Development/Microsoft/monaco/out/vs/workbench/browser/parts/views/viewsViewlet.js:359:46)
		    at DebugViewlet.ViewsViewlet.onViewsDeregistered (file:///Users/bpasero/Development/Microsoft/monaco/out/vs/workbench/browser/parts/views/viewsViewlet.js:308:25)
		    at CallbackList.invoke (file:///Users/bpasero/Development/Microsoft/monaco/out/vs/base/common/callbackList.js:35:39)
		    at Emitter.fire (file:///Users/bpasero/Development/Microsoft/monaco/out/vs/base/common/event.js:91:40)
		    at class_1.exports.ViewsRegistry.class_1.deregisterViews (file:///Users/bpasero/Development/Microsoft/monaco/out/vs/workbench/browser/parts/views/viewsRegistry.js:74:39)
		    at ExplorerViewlet.registerViews (file:///Users/bpasero/Development/Microsoft/monaco/out/vs/workbench/parts/files/browser/explorerViewlet.js:139:47)
		    at file:///Users/bpasero/Development/Microsoft/monaco/out/vs/workbench/parts/files/browser/explorerViewlet.js:88:105
		    at CallbackList.invoke (file:///Users/bpasero/Development/Microsoft/monaco/out/vs/base/common/callbackList.js:35:39)
		    at Emitter.fire (file:///Users/bpasero/Development/Microsoft/monaco/out/vs/base/common/event.js:91:40)

This is coming from the viewsViewlet an undefined view is being passed as seen in the picture. Forwarding to @joaomoreno

Seems to be independent of my refactoring and more about how the ViewsViewlet works.

#36227

@bpasero


Ionic2 RC.0 third party scss libraries not found after live compilation

From @peterpeterparker on October 2, 2016 9:33
Hi,
I added some third party scss libraries in my application.
To accomplish that:

"npm install"
override sass.config.js to include these scripts.
add "@include" in my app.component.scss

Works fine.
I only face one problem. When I'm running the server ("ionic serve"), if I make any changes to my scss files, the server gonna recompile the sass files but it isn't able, seems so, to find these third party scss files anymore. For example, the recompilation results could be:
[11:26:15]  Sass Error: line: 85, column: 1
File to import not found or unreadable: _bourbon.scss
Parent style sheet: /Users/me/Documents/projects/myproject/src/app/app.component.scss

Therefore, each time I make a scss change I've to start my server again, which isn't really convenient.
Could that be fixed?
Copied from original issue: driftyco/ionic#8401

Going to group this in with #42
Thanks


WIP: fiddle Parallel fail test

The test wants to make sure other tests don't run once the contrived failure in one of the two threads is triggered.
Add Depends() to set up dependency so taskmaster doesn't schedule one of the two "later" jobs earlier.
This is kind of a shot in the dark: since the test doesn't fail consistently, failure to trigger doesn't prove anything.
Signed-off-by: Mats Wichmann<EMAIL_ADDRESS>Contributor Checklist:

[ ] I have created a new test or updated the unit tests to cover the new/changed functionality.
[ ] I have updated CHANGES.txt (and read the README.rst)
[ ] I have updated the appropriate documentation

Okay, ditching this one, it provided no lasting value.

Okay, ditching this one, it provided no lasting value.

Okay, ditching this one, it provided no lasting value.

Okay, ditching this one, it provided no lasting value.


Add pyproject.toml for Custom Node Registry

Hey! My name is Robin and I'm from comfy-org! We would love to have you join the Comfy Registry, a public collection of custom nodes which lets authors publish nodes by version and automate testing against existing workflows.
Eventually, the registry will be integrated as a backend for the UI-manager where all nodes will go through a security scan. Nodes that pass these checks will have a verification flag (✅) beside their name on the UI-manager. Feel free to read up more on the registry here
Action Required:

[x] Go to the registry. Login and create a publisher id (everything after the @ sign on your registry profile).
[x] Add the publisher id into the pyproject.toml file.
[x] Merge the separate Github Actions PR, then merge this PR.

If you want to publish the node manually, install the cli by running pip install comfy-cli, then run comfy node publish
Otherwise, if you have any questions, please message me on discord at robinken or join our server!

action done followed the instruction.Thanks


Initial implementation

what

Scaffolding for distribution of helmfiles with docker

why

We're decomposing helmfiles from geodesic so that it can be versioned independently

https://github.com/cloudposse/geodesic/issues/203


Vector extension encoding conflicts

I am working on implementing vector extension draft on a GNU toolchain. So far, I was able to successfully implement the complete draft; however, I had to improvise in couple of issues that I discover throughout the process.
The first issue was op_code encoding. The op_code chosen for most vector operation conflict with JAL. Although we can tell most instructions apart through bit 14, VMADD, VMSUB, VNMADD, and VNMSUB all have definite conflict with JAL. Also, op_code for all vector memory operations just mirror that of the float-point memory operations.
It seems that the opcode assignment were made as fillers? For now, I have used three of the reserved standard opcodes for vector-op, vector-load, and vector-store. I think that is not what the intent going forward; sacrificing three standard op-code extensions seems too much. But, for now, until the draft becomes more concrete, this would unblock my work.
The second issue is just a mere question: Would the immediate fields used in the draft be the same going forward? I am curious because the immediate field for load/store seems too small to encode anything useful and most likely the compiler will end-up filling it with zeros. Maybe it makes sense to make the immediate some multiple of a constant and/or it would be an upper-immediate?

The encoding does not conflict, because MADD etc. require that m={1,2,3}. JALR corresponds to the case m=0. However, this encoding is temporary, and a revamped one will be released in the next month or so. Sorry for the confusion.

I see. So, m can't be all zeros. Great!
However, does this mean that the loads/store are conflicting with floating-point loads and stores? I understand it is just temporary, I am just clarifying if I am reading the current encoding correctly.
Thanks!!

The floating-point loads/stores have funct3 <= 4, and the vector ones have funct3 > 4 (since m > 0).

Great! Thanks!
Is there any public mailing list/discussion forum that I can join to follow vector extension development?

Much of the discussion happens in the Vector task group within the RISC-V Foundation.  You can join the Foundation as an individual member to participate (https://store.riscv.org/collections/membership/products/individual-member-1)

Hi Andrew, Khalid is a PhD student in my research group. What would be the best way for an academic to get involved in the Vector task group? Is an individual member the right choice?

Hi Chris, good to know & nice to meet you, Khalid.
My understanding is that there are two equally valid options. Cornell, or
perhaps Cornell ECE or your research group, could join the Foundation as an
auditor, which costs $2500/year. This would allow anyone with that
affiliation to participate in the working groups where the sausage is made
(but does not connote voting rights, as do the pricier membership levels).
Some universities have chosen this option, and some have joined at the
voting levels of membership.
The other option is for individuals to join as individual members for
$99/year, with similar membership terms as the auditor level. The $99 can
be waived on a case-by-case basis for active open-source contributors.
On Tue, Sep 18, 2018 at 4:12 AM Christopher Batten<EMAIL_ADDRESS>wrote:

Hi Andrew, Khalid is a PhD student in my research group. What would be the
best way for an academic to get involved in the Vector task group? Is an
individual member the right choice?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/riscv/riscv-isa-manual/issues/227#issuecomment-422352686,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AA-7wpxui05riHt3JDff6JV9dfJU60Pkks5ucNUIgaJpZM4WtQG8
.

Thanks Andrew! I think for now maybe Khalid will join as an individual member so we can be more in the loop for the vector spec and then we will go from there.


Add in HRC logo

@beck410
Hey, Colby helped me understand a bit more about the underlying concept of bootstrap and helped me modify the basic column layout.  The way it looks now I actually like keeping the dropdown fixed, so if you want to omit that change go ahead.


feature request: how to find a model

What happened?
tfhub contains thousands of models, but its nearly impossible to find something unless user already knows which exact model he/she wants to use.
feature request:

add information on model publish date to model card
(see #810 for some history, this information was previously included but it was incorrect. and it seems now its gone completely)
implement sort by date / filter by date
implement sort by size / filter by size

Relevant code
n/a

Relevant log output
n/a

tensorflow_hub Version
0.13.0.dev (unstable development build)
TensorFlow Version
2.8 (latest stable release)
Other libraries
No response
Python Version
3.x
OS
Windows

Please check whether https://www.kaggle.com/models is helpful in that regard since they provide these filters.

@WGierke there is no sort by date nor by size, only filter by small/medium/large.
but either way, not sure if thats relevant - is tfhub going away in favor of kaggle?

It simply dosnt work


Warnings about conflicts in sidecar coming from istio proxy discovery

Hey,
Can you help me decipher:
2018-06-02T23:18:45.291668Z     warn    buildSidecarOutboundListeners: listener conflict (TCP current and new TCP) on <IP_ADDRESS>:9094, destination:outbound|9094||prometheus-alertmanager.istio-system.svc.cluster.local, current Listener: (0.0.
0.0_9094 name:"<IP_ADDRESS>_9094" address:<socket_address:<address:"<IP_ADDRESS>" port_value:9094 > > filter_chains:<filters:<name:"envoy.tcp_proxy" config:<fields:<key:"deprecated_v1" value:<bool_value:true > > fields:<key:"value" value:<struct_value:<fields:<key:"route_config" value:<struct_value:<fields:<key:"routes" value:<list_value:<values:<struct_value:<fields:<key:"cluster" value:<string_value:"outbound|9094||alertmanager.data-platform.svc.cluster.local" > > > > > > > > > > fields:<key:"stat_prefix" value:<string_value:"outbound|tcp|9094" > > > > > > > > deprecated_v1:<bind_to_port:<> > )

The service looks like this:
apiVersion: v1
kind: Service
metadata:
  annotations:
    prometheus.io/scrape: "false"
  creationTimestamp: 2018-06-02T14:04:36Z
  labels:
    app: prometheus-alertmanager
  name: prometheus-alertmanager
  namespace: istio-system
  resourceVersion: "7067439"
  selfLink: /api/v1/namespaces/istio-system/services/prometheus-alertmanager
  uid: e2167eeb-666d-11e8-83f4-42010aa400df
spec:
  clusterIP: None
  ports:
  - name: cluster
    port: 9094
    protocol: TCP
    targetPort: 9094
  selector:
    app: prometheus-alertmanager
  sessionAffinity: None
  type: ClusterIP
status:
  loadBalancer: {}

The deployment looks like this:
        name: prometheus-alertmanager
        ports:
        - containerPort: 9093
          protocol: TCP
        - containerPort: 9094
          name: frontend
          protocol: TCP

We have another alert-manager in a different namespace, with the same names for things?

Closing this as my ports were wrong, which has made the error go away.

@Stono I'm running into this problem too, could you tell how did you solve it?

@themez please see https://github.com/istio/istio/issues/5992 which the isito team are working on
In the interim ensure all your ports are uniquely named across all services


PEP 8 Fix

Makes the code PEP 8 compliant.

@agarwalrounak Thanks for this PR, we'll get a review on it! Can we send you some LBC as appreciation?

@agarwalrounak there is already a pylint check done for PEP8 compliance on every commit (and it passes). Can you propose changes to setup.cfg in a separate PR instead, for things that you think aren't currently being checked but should be checked.


npm install error

Hello, I have tried to install react-sketch app, but got below error, don't know how to resolve it, please help it.

How to reproduce:
git clone https://github.com/airbnb/react-sketchapp.git
cd react-sketchapp/examples/basic-setup && npm install
Sketch version:
Sketch 50
Mac version:
10.13.4

It also says
xcode-select: error: tool 'xcodebuild' requires XCode, but active developer directory '/Library/Developer/CommandLineTools' is a command line tools instance

Google spits out this, maybe it's helpful? https://github.com/nodejs/node-gyp/issues/569
(I am in no way an expert there, but looks like that could solve the issue :) )


rust-doh causing HTTP 502 (Bad Gateway)

Hi,
our setup:
nginx -> rust-doh -> unbound
In a small fraction (~1 out of 1000 queries) nginx returns the HTTP 502 response code which suggests that rust-doh had an issue with the request and returned something unexpected.
We never see HTTP 502 response codes when using
https://github.com/facebookexperimental/doh-proxy
Since apparently there are no rust-doh logs (#11) it is hard to further debug this.

You also run a public DoH server using rust-doh, how often do you see that error code (if you also have nginx)?
How can we debug this further?

version: 0.1.15

The proxy never returns a 502 response code. But it enforces timeouts, so that clients don't wait forever. There is also a maximum number of simultaneous connections (512, by default).
When one of these limits is reached, the proxy will close the connection, probably leading to a 502 response code generated by Nginx.
Try increasing these limits to see if it helps. But then you also need to make sure that you are not going to hit system limits, such as the file descriptor limits.
I also run the DoH servers behind Nginx, but I don't log.

I've a slightly better understanding now but further digging is needed and help is welcome. :)
nginx config
Let's start with some excerpts from the nginx config to better understand the logs:
log_format minimaldns_upstream '$time_iso8601 $status $upstream_status $upstream_addr $geoip_country_code';

upstream rust_doh_backend {
	server <IP_ADDRESS>:3000;
	server <IP_ADDRESS>:3001;
}

two types of HTTP 502 log events
We observed two type of log entries related to HTTP 502:
a)
2019-05-26T16:04:06+02:00 502 502 <IP_ADDRESS>:3000 -

same for the instance on port 3001.
They occur rarely but consistently.
b)
2019-05-26T15:57:14+02:00 502 502 rust_doh_backend -

They occurred even less frequently than (a) but when they happen they came at a high number at once.
https://nginx.org/en/docs/http/ngx_http_upstream_module.html#var_upstream_addr explains the difference of the upstream_addr value:

If a server cannot be selected, the variable keeps the name of the server group.

conclusion about type (b) log events
That means during type (b) events, nginx considered all two backends unavailable.
"failed" is defined in: https://nginx.org/en/docs/http/ngx_http_proxy_module.html#proxy_next_upstream
So by increasing max_fails to a value higher than 1 we can prevent type (b) events to tell nginx "try harder, don't give up so easily".
Now we need to find out more about type (a) log events. According to nginx, doh-proxy actually returned HTTP 502.

I assume I understand the issue better now.
This is expected:
curl  http://<IP_ADDRESS>:3000/query -v
* Expire in 0 ms for 6 (transfer 0x55664e118d00)
*   Trying <IP_ADDRESS>...
* TCP_NODELAY set
* Expire in 200 ms for 4 (transfer 0x55664e118d00)
* Connected to <IP_ADDRESS> (<IP_ADDRESS>) port 3000 (#0)
> GET /query HTTP/1.1
> Host: <IP_ADDRESS>:3000
> User-Agent: curl/7.64.0
> Accept: */*
>
< HTTP/1.1 400 Bad Request
< content-length: 0
< date: Fri, 31 May 2019 22:03:45 GMT
<
* Connection #0 to host <IP_ADDRESS> left intact

This is unexpected (no response at all):
curl -d "" http://<IP_ADDRESS>:3000/query -v
* Expire in 0 ms for 6 (transfer 0x562d8ddb4d00)
*   Trying <IP_ADDRESS>...
* TCP_NODELAY set
* Expire in 200 ms for 4 (transfer 0x562d8ddb4d00)
* Connected to <IP_ADDRESS> (<IP_ADDRESS>) port 3000 (#0)
> POST /query HTTP/1.1
> Host: <IP_ADDRESS>:3000
> User-Agent: curl/7.64.0
> Accept: */*
> Content-Length: 0
> Content-Type: application/x-www-form-urlencoded
>
* Empty reply from server
* Connection #0 to host <IP_ADDRESS> left intact
curl: (52) Empty reply from server

What do you think about returning 400 Bad Request in such cases of malformed requests instead of closing the connection directly?
For the upstream timeout case that currently also results in a closed connection:
What do you thing about returning 504 Gateway Timeout for cases where it reaches the 10 seconds timeout?
https://tools.ietf.org/html/rfc7231#section-6.6.5
This would be nice so we could tell these cases apart in the error stats.

de99e6a8b229e5dfc2940bdcfd0f9f8a2ca834af returns a 400 error code for POST queries (this was already the case for GET queries).
Returning something on a timeout seems to be too complicated for my knowledge of Rust and Tokio. The timeout is on the socket itself, and once it fires, the HTTP layer is not accessible any more.
Something I may revisit once async I/O in Rust stabilizes and becomes a bit more friendly.


Store job attempt in job payload & use Laravel's built-in queue worker

Fixes #14
Fixes #22
Change 1: Store job attempt in job payload
ApproximateReceiveCount should not be used when processing SQS jobs in Lambda, as it is very unreliable. See https://link.medium.com/uUkT2W9bTbb for more info.
This PR adds functionality to store the current attempt on the job payload, so we don't have to depend on ApproximateReceiveCount. This effectively means that the attempt value should be correctly set on every try. Because we can't update SQS messages, we always have to re-create a message, rather than releasing it back onto the queue.
This change will make $this->job->attempts() and descendants of it, ($maxExceptions, $tries), usable.
Change 2: Refactor workers
This PR also changes the queue worker to use the frameworks built-in worker, in favour of the purpose built worker from this package. Now that we don't have to deal with the ApproximateReceiveCount, there is not need to use our own worker class, and we should rather use the default one provided by Laravel. This also means that jobs are now processed by the same system used by queue:work and Laravel Horizon, limiting the changes between platforms.
Note that Laravel's queue worker expects a maintenance mode status. As this feature is not implemented in this package, the value is hardcoded to false. This effectively means that the queue worker will simple ignore any maintenance mode set. This is in line with earlier versions of this package, that also ignored the maintenance mode.

The code is 'backwards compatible' in the sense that the example worker.php remains identical. If you did not change that, all should continue working as usual.
The code is heavily inspired (and sometimes copied) from https://github.com/laravel/vapor-core/. Attributions were giving where due.

Hey @georgeboot, thanks for iterating on this following the first PR.
At the moment unfortunately I don't have enough time to spend a few days on this (I wish I could). I think the general approach makes sense, but there may be bigger changes to consider and explore (e.g. integrating with more Laravel Queues features, including #14 and #22). The target isn't 100% defined yet I believe. Additionally, the license issue is still a problem here and I think that needs to be carefully dealt with.
Given the time it requires, I think there are the following scenarios of what could happen:

someone (you or anyone else) creates an alternative to the Bref Bridge in a separate GitHub project (a word on warning: pay close attention the licenses)
in the future I get a direct reason to work on that topic, for example if one of my clients needs this, or if I need this in one of my projects
a company sponsors a Laravel Bridge 2.0 where we evaluate integrating with more features from Laravel Queues (get in touch to discuss this<EMAIL_ADDRESS>
In the meantime unfortunately, I don't see this topic moving forward much.

but there may be bigger changes to consider and explore (e.g. integrating with more Laravel Queues features, including #14 and #22)
Any clues which ones? #14 and #22 are dealt with in this PR. I'll be happy to implement them.

Additionally, the license issue is still a problem here and I think that needs to be carefully dealt with.
Can you please point me to a resource explaining how to do copyright attribution properly? This is all I could find online.

This is awesome! Any updates?

This is awesome! Any updates?

For now, you can use my fork. I've been using it in production without issues for couple of months now, so it's stable I guess.
I have some more things I usually add to my projects to make Bred behave more "Laravel-like" (if that is even a word).
I will probably create a separate package that will include all these things. People can than choose between bref/laravel-bridge and my package, depending on their needs and preferences.

I concur with @atymic, this is awesome., great work @georgeboot. Our purpose was being able to use $this->release() for Lambda messages that failed and wanted retrying later, which we can now.


Unhandled exception is not reported

I'm creating uwp app and added unhandledException handler in app.xaml.cs which looks like:
var bugsnag = new Bugsnag.Client(new Bugsnag.Configuration("{APP_KEY}"));
bugsnag.Notify(e.Exception, Bugsnag.Severity.Error);

But there is no errors in bugsnag dashboard. Is there any way to debug the problem?
Bugsnag version is 2.1.0.

@GDreyV unfortunately we don't currently support UWP applications. I spun up a test application to see if it would work and the application will not start due to our use of the System.Threading.Thread package which is not supported on UWP. I'll add a ticket to our roadmap to look into supporting UWP

@martin308 thanks for update. Just want to add some details for future. Really I found that some error were sent correctly to bugsnag. It seems like in most cases application was closed before bugsnag managed to send data.
Also references to netstandard2 force to use most recent windows version and target.

@GDreyV thanks for the additional information 🙏
Do you have a sample project that sends errors to Bugsnag? I couldn't get a basic UWP application to event start when initializing the bugsnag client as it tries to load the System.Threading dll which didn't exist.
The bugsnag nuget package does also have a netstandard13 implementation alongside netstandard2, is it not able to use that?

Really? I found that netstandard13 implementation is pretty old and available in version 1.
Here's the app to reproduce the problem: https://github.com/GDreyV/bugsnag-uwp-test

Thanks for putting that project together, I'll take a look as soon as I can!
I'm not sure what you mean in regards to the netstandard13 implementation. We only supported net35 and net45 in version 1 of the notifier.
We target the current code for net35, net45, netstandard13 and netstandard2. There is only minimal differences for the netstandard13 implementation where the required classes/functionality is not available. I'd love to get to the bottom of this if there is an issue with our nuget package

Maybe I'm doing something wrong but I'm using bugsnag version 2.1.0 (latest stable). If I change min target version to Build 15063 (which doesn't include netstandard2) and run the app with test call of Bugsnag.Notify I get error System.IO.FileNotFoundException: 'Could not load file or assembly 'System.Threading.Thread, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a'. The system cannot find the file specified.' As I understand Thread v.4 is part of netstandard2.


Migrate viewer functions from Javis to JavisNB

PR Checklist
If you are contributing to Javis.jl, please make sure you are able to check off each item on this list:

[x] Did I update CHANGELOG.md with whatever changes/features I added with this PR?
[x] Did I make sure to only change the part of the file where I introduced a new change/feature?
[ ] Did I cover all corner cases to be close to 100% test coverage (if applicable)?
[ ] Did I properly add Javis dependencies to the Project.toml + set an upper bound of the dependency (if applicable)?
[ ] Did I properly add test dependencies to the test directory (if applicable)?
[ ] Did I check relevant tutorials that may be affected by changes in this PR?
[x] Did I clearly articulate why this PR was made the way it was and how it was made?

Link to relevant issue(s)
Closes #
How did you address these issues with this PR? What methods did you use?
The idea is to move notebook viewers to JavisNB and change render in order to play well with the different package.
More details in this PR https://github.com/JuliaAnimators/JavisNB/pull/6 where the parallel work on JavisNB is done.

Codecov Report

Merging #451 (c1f655a) into master (c99ad54) will increase coverage by 0.20%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master     #451      +/-   ##
==========================================
+ Coverage   96.26%   96.47%   +0.20%
==========================================
  Files          36       35       -1
  Lines        1634     1617      -17
==========================================
- Hits         1573     1560      -13
+ Misses         61       57       -4

Impacted Files
Coverage Δ

src/Javis.jl
96.87% <0.00%> (+0.82%)
:arrow_up:

src/javis_viewer.jl
92.50% <ø> (+1.19%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c99ad54...c1f655a. Read the comment docs.

Done with my additions!
Looks great to me!
@gpucce feel free to merge this when ready. :)

Hey @gpucce , I went ahead and merged this branch.
If there were any more fixes needed, just let me know and we can make a new issue and PR.
Thanks for the awesome work here!


Support for multi-tenant architecture

I am building a saas like application in which each tenant has their own tenant databases. I have graphql server at my backend and on each request, the tenant database is dynamically selected from tenant id passed in authorization headers. I would like to know how I can differentiate dataloaders for each tenant. Say I have userLoader, so I can use userLoader.load('12') to load user with id '12'. But this same id can be present across all my tenants. So please let me know how to implement dataloader in a multi-tenant architecture.

@aniyanm You can instantiate one loader for each tenant.
It's up to you to set rules to handle the dispatch
userLoader.foo.load('12')
userLoader.bar.load('2')


Tesseract with Alfresco Communities

I configured already.  when I upload image to alfresco but txt file is empty.  I try manual run tesseract can convert image to txt file.

I am sorry but we do not provide support for 3rd party project


Allow the use of Faraday 2.x

We have a project that already contains Faraday 2.x.
This allows the use of Faraday 2.x and adds a fix for initializing the SDK when the config is not set.
Faraday 2 accepts a lambda function for Auth, which actually allows setting the API Key after initialization. Without the lambda function and in Faraday 1.x there's actually an issue where the new API key wouldn't be picked up anyway if the SDK is already initialized earlier without it.

Hi @scsmith, thank you for the contribution. Sorry this is taking longer than expected to be reviewed.
We'll get to it as soon as possible.

Hey @scsmith, thanks for updating the Faraday version. However, the api_key changes do not seem relevant for this PR. Could you revert those and keep only the Faraday related updates?

Closing this since #37 was merged.


Unable to build latest Ubuntu 18.04 image - "Could not open input file: composer-setup.php"

Describe the bug
I am trying to use Packer to build the latest Ubuntu 1804 image from /images/linux/ubuntu1804.json, but the installation is failing and Packer is aborting with this error:
azure-arm: The following NEW packages will be installed:
    azure-arm:   snmp
    azure-arm: 0 upgraded, 1 newly installed, 0 to remove and 30 not upgraded.
    azure-arm: Need to get 0 B/158 kB of archives.
    azure-arm: After this operation, 563 kB of additional disk space will be used.
    azure-arm: Selecting previously unselected package snmp.
    azure-arm: (Reading database ... 241772 files and directories currently installed.)
    azure-arm: Preparing to unpack .../snmp_5.7.3+dfsg-1.8ubuntu3.3_amd64.deb ...
    azure-arm: Unpacking snmp (5.7.3+dfsg-1.8ubuntu3.3) ...
    azure-arm: Setting up snmp (5.7.3+dfsg-1.8ubuntu3.3) ...
    azure-arm: Processing triggers for man-db (2.8.3-2ubuntu0.1) ...
    azure-arm: Installer corrupt
    azure-arm: Could not open input file: composer-setup.php

Virtual environments affected

[ ] macOS 10.15
[ ] Ubuntu 16.04 LTS
[x ] Ubuntu 18.04 LTS
[ ] Windows Server 2016 R2
[ ] Windows Server 2019

Expected behavior
A successful packer build to create the Ubuntu 1804 image
Actual behavior
An installation step fails and Packer aborts the build with this error:
azure-arm: The following NEW packages will be installed:
    azure-arm:   snmp
    azure-arm: 0 upgraded, 1 newly installed, 0 to remove and 30 not upgraded.
    azure-arm: Need to get 0 B/158 kB of archives.
    azure-arm: After this operation, 563 kB of additional disk space will be used.
    azure-arm: Selecting previously unselected package snmp.
    azure-arm: (Reading database ... 241772 files and directories currently installed.)
    azure-arm: Preparing to unpack .../snmp_5.7.3+dfsg-1.8ubuntu3.3_amd64.deb ...
    azure-arm: Unpacking snmp (5.7.3+dfsg-1.8ubuntu3.3) ...
    azure-arm: Setting up snmp (5.7.3+dfsg-1.8ubuntu3.3) ...
    azure-arm: Processing triggers for man-db (2.8.3-2ubuntu0.1) ...
    azure-arm: Installer corrupt
    azure-arm: Could not open input file: composer-setup.php

git pull master
cd images/linux
packer build --var-file=packer_vars.json ubuntu1804.json

Any thoughts or suggestions?

this applies to ubuntu 1604 as well.

Where do you get packer_vars.json from/what does it contain? Probably the variables that are used in ubuntu1804.json. I want to build this image to run azure devops tests locally.

@cubimon you can build it  on your own based on the parameters your packer is expecting. e.g. password

I believe this was addressed in #194.


Adds specific icon for each card

So far so good :)

Looks good. But your implementation is restricted to the client payments view only. If you check the codebase, you'll see the card component is reused in multiple places. Make sure the icons are visible everywhere.
Subscription Payment
Reservation Payment
Client Profile

as I spoke with Gabriela, for the payment pages, where we have a  tag with , we just remove the yellow icon and leave text only. The icons will be visible, for now, only in Contul meu -> Carduri

Looks good. you can merge it


Integration test improvements

POC Labjack script for Posifa flow sensor works
Integration test deployment script improved
Integration tests take parameters
More docs & notes on other redundant sensors we will be working with

@asmodai27 what do you mean by sanitize the variables? Like, do some sort of value validation in bash? I actually tried to make the bash script pretty agnostic of the actual tests themselves, so that there is less of a maintenance burden. Like, the test name is just the subset of the header file name, and any number of other tests could be added without changing anything in main or the bash script. Compiling is pretty fast, so if there are parameter type problems you get notified pretty quickly. And most importantly the compiler's errors will be informative and true, whereas hand-crafted validation routines might not correspond to what the compiler expects. My assumption is that whoever is using these tests is familiar with the content of the test code and is aware of what context those param values get pasted into.
Python script is really rough POC that spews out values. The only important thing is that it works. I'm just trying to get up to the point where we have functional pieces to play with, and then we will write some real scripts that integrate everything and actually test stuff.

What I mean by sanitize is check that they are correct before writing them. But I think you are right, the user here is a dev and should be able to read the compiler errors easily. If the compiler errors are hard to read (I haven't tried this so I wouldn't know) we can add a static assert in integration_test that spits out a message that is as clear as possible... Not sure whether this is necessary though.


Focus is lost after activating the finish button in the last step of the wizard using Safari

Describe the bug
[Test URL]
https://clarity-light-theme-v2-a6ykys.stackblitz.io
[WCAG 2.1 Guideline]
2.4.3 Focus Order
(Level A)
[Screen Reader/Browser]
Safari Version 13.0.3 (156<IP_ADDRESS>.4)/VoiceOver
[Description]
Focus is lost after activating the finish button in the last step of the wizard.
[User Impact]
Sighted keyboard-only users and non-sighted VoiceOver users using Safari may be confused when focus is lost.
[Recommendation]
Focus should go to the Toggle button when the wizard closes when using Safari as it does with other browsers. I do not know the root cause of this issue.
How to reproduce
Steps to reproduce the behavior:

Using the keyboard alone, or a screen reader, go to the Test URL
Activate the "Toggle" button
Complete all the steps in the wizard and activate the Finish button.
Observe that focus is lost
Repeat the previous steps with Safari/VoiceOver and observe that you do not hear anything after activating the Finish button.

Expected behavior
Focus should go to the Toggle button when the wizard closes when using Safari as it does with other browsers. I do not know the root cause of this issue.
Versions
App

Angular: Uknown
Node: : Uknown
Clarity: : Uknown

Device:

Type: Any
OS: Any
Browser: Any
Version: Any

Additional notes
NA

Safari isn't showing any focus indicators for me except on the Close button, which is very strange. I don't know the root of this one yet, but we aren't suppressing focus outline directly. Seems like we might have a Safari bug to contend with here.

Clarity cares deeply about accessibility, and we work with our accessibility team to identify and triage issues. We have an internal tracking system to identify and verify accessibility issues, which has captured this already. Some issues with Clarity Angular are difficult to solve without causing side effects or breaking changes, and we have to balance concerns with fixing issues and breaking changes. As we build out Clarity Core, we are able to address these root cause accessibility issues and recommend adopting the Clarity Core implementations as they become available. We are closing this issue as we have the issues tracked internally. Please follow our development and releases to see when we release relevant Clarity Core components to make this possible.


Calendar should only be editable by staff

Look into using the built-in permissions for this.

this will utilize the permission system. and editing the events should be its own page in a menu

I'd like to utilize FullCalendar's editing features for simple edits, like shifting the next club meeting by an hour. We'll have a more full-featured editing page that will handle recurring events, etc.


Adding about section

A about us section should be added . I can implement this, kindly assign this  under swoc'24

I can work on this issue and add a About Us section. Please assign this to me under SWOC'24


On using context.cleanup()

Hello maintainers.
In this particular file, I put context.cleanup() in all these functions.
Please, does it make sense to do so?
Thanks.

Not like this, the library cannot be used once context.cleanup() has been called, you should only do that when you don't need it anymore (or when your program is terminating.

Thanks @sstone


Improve check-gf-github

@m4rc1e Please could you add some docs to the gftools repo for the gftools check-gf-github command :)
The docstring in https://github.com/googlefonts/gftools/blob/main/bin/gftools-check-gf-github.py is OK but there's a bit more context and workflow steps to getting it set up that are latent/implied and it would be nice to make it clearer
Then, ideally, set up a Github Actions to run it regularly and post the results somewhere (maybe a new txt file once a month into the check-gf-github branch on this repo?) so we can just look up the info as needed :)

Going to close this since https://google.github.io/fonts/ now exists :-)


Handle exceptions that close the program

Some mild exceptions occur that automatically close program. This should be investigated and possibly resolved to inform the user of a problem without closing the program.

Mostly addressed in commit e09b9eee8102d0887e665e8e6c9ef1fec10f0cb2


Selected item for alternative component

Optionally provide a component key which overrides the default label text:
[{
  key: 5,
  label: 'Red Apples',
  component: <View style={{backgroundColor: 'red'}}><Text style={{color: 'white'}}>Red Apples custom component ☺</Text></View>
}]

selectedItemTextStyle not working for this one
do i need add another component for selected style ?
thanks

I believe that selectedItemTextStyle won't work for custom selector components.  Would you like to submit a PR to enable it?  I'm not sure how that would be done on a custom component though.

selectedItemTextStyle works for custom component but this is really bad that it distinguishes options on the basis of label and not on the key. So, if you have same options under different sections then they'll all be highlighted

Thanks for noticing that @deepankar14693 .  Please submit a PR to match based on key instead of label.


Not included Pods always displayed in report

I try to exclude my Pods folders in .xcovignore but frameworks associated with are still displayed in HTML. This is only a layout issue because these frameworks are not included in total coverage percent.
Maybe --exclude_target and --include_target should be more appropriated for this kind of purpose but it doesn't seem to be working as expected.
Indeed, I have no result when I do something like this :
xcov -w MyApp.xcworkspace -s 'SCHEME' --output_directory xcov_output --include_targets 'TARGET'.
Maybe I misunderstand something 🤔.

--include_targets is not really target name but name as it appears in report, issue solved.


UT-Fix Fix MTMV FE UT bugs

Proposed changes
Problem summary
Code in MTMVJobManagerTest.java sleep 5 seconds to wait the jobmanager generate task.
        Thread.sleep(5000L);
        Assertions.assertTrue(jobManager.getTaskManager().getAllHistory().size() > 1);

These will assert failed when running a heavy CI node.
So use a loop to wait the task to be generated.
Checklist(Required)

Does it affect the original behavior:

[ ] Yes
[x] No
[ ] I don't know

Has unit tests been added:

[x] Yes
[ ] No
[ ] No Need

Has document been added or modified:

[ ] Yes
[x] No
[ ] No Need

Does it need to update dependencies:

[ ] Yes
[x] No

Are there any changes that cannot be rolled back:

[ ] Yes (If Yes, please explain WHY)
[x] No

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 35.06 seconds
load time: 470 seconds
storage size:<PHONE_NUMBER>8 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230208094739_clickbench_pr_92192.html


Bug: Use of config Map confusing for users #360

(Originator of the issue) According to @mtamboli - I  agree that Champ would most likely use private registry and major change not a good idea being that late in the release cycle. So with that in mind, we can just improve this message The application stack, docker.io/kabanero/java-spring-boot2:0.3, in .appsody-config.yaml is active on this cluster and can be built. to indicate user that we ignoring the value defined in .appsody-config.yaml for this special case when using external route of internal registry and print the stack that is actually active and will be used.
(Owner if the issue) According to t Vijai:
@mtamboli yes I will make that change to the message and cut a new RC.

Created RC3 of pipelines with the fix.  Will wait for @mtamboli to test before closing.

@marikaj123 I checked

Git project config in .appsody-config.yaml...
VERSION = 0.3
STACK_IMAGE_REGISTRY = docker.io
PROJECT = kabanero
STACK_NAME = java-spring-boot2

WARNING - .appsody-config.yaml specifies different repository, docker.io, than what's configured in the config map, image-registry.openshift-image-registry.svc:5000, in the cluster.  Config map entry takes priority.  Using image-registry.openshift-image-registry.svc:5000 as the default stack registry.
RECONCILED_STACK_IMAGE_REGISTRY_HOST = image-registry.openshift-image-registry.svc:5000

.....

WARNING - A config map has been created on the cluster with the stack image registry information. The registry of the application stack, docker.io/kabanero/java-spring-boot2:0.3, specified in .appsody-config.yaml will be overridden by the registry configured in the config map, stack-image-registry-map.
Validation is performed using the image located in the image-registry.openshift-image-registry.svc:5000 registry that was configured in the config map.

The application stack, kabanero/java-spring-boot2:0.3, in .appsody-config.yaml is active on this cluster and can be built.

We can close this after the latest pipeline is picked up by the operator.

Closing the issue as it was verified successfully by SVT.


Add accessTokenExpiresIn field

A new response field access_token_expires_in was added to session, refresh and login/end endpoints. This PR is about adding that field to the responses of respective functions that call these endpoints.

After a token issuance this makes sense, but what about this scenario:

User logs in + SPA receives a value of 300
User reloads the page 60 seconds later
SPA restarts and should get a value of 240 - but does it still get a value of 300?

If so then we should avoid returning the value from the /session endpoint


Home Page - Performance

Task Description
Home page takes too long to load. Investigate and improve the performance. If we have to make a choice between response time and rich feature, we choose the former, especially on home page.

Timeline
We implement weekly sprint. This task is given a default of one week. You don't have to finish all requirements in this task, but please submit a Pull Request with whatever code change you have by 3/5. This helps us get the latest development status and plan the next sprint efficiently.

This issue was moved to Code4SocialGood/c4sg-web#35


Pre-register data with PowerShell directly into StrongAuthenticationUserDetails

Hi,
I was about to pre-register our employees phone numbers and emails into Azure AD thinking it would only be able to be seen by Global Admins based on issue #26720 but after performing the commands to set the MobilePhone and AlternateEmailAddress on a single user I found that any standard user in the organisation could see this information.
Is there a way I can write directly using PowerShell to the StrongAuthenticationUserDetails.PhoneNumber and StrongAuthenticationUserDetails.Email as these are locked down to Global Admins and bypass the MobilePhone and AlternateEmailAddresses fields that can be read by all users in the organisation?
Kind Regards,
Gavin

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: aae83fda-27b9-edca-1b59-1140de4cc3f5
Version Independent ID: c93eb84b-f04b-de03-f3f5-57d4672b0559
Content: Azure AD SSPR data requirements - Azure Active Directory
Content Source: articles/active-directory/authentication/howto-sspr-authenticationdata.md
Service: active-directory
Sub-service: authentication
GitHub Login: @MicrosoftGuyJFlo
Microsoft Alias: joflore

@GavinEke Thank you for your query. We will investigate and update further.

Where do you see this information visible from a user perspective. Can you be more specific?

PowerShell, add.portal.azure.com, Graph API take your pick.
Simple to reproduce create 2 user accounts both with no directory roles assigned set the information on one shown in article, log into the 2nd and view the information with no Global Admin or additional access required.
Example 1: 2 PowerShell windows. Top window logged in as a Global Admin setting the command, Bottom window logged in as TestUser2 which has no administrative role just standard permissions.

Example 2: Account logged in as TestUser2 again no administrative role just standard permissions, can see the data.

Thanks Gavin. This helps and yes, this is a security flaw. Hopefully it gets resolved soon. I was more concerned about it showing up in OAB but both Examples are equally significant.

I haven't actually checked GAL or OAB but I believe the OfficePhone and MobliePhone attributes are mapped from here. I have no concern about the office phone being available to all staff but mobile phone and alternative email address is a huge privacy and security concern to us and I am sure others.

@GavinEke I am afraid it is currently not possible to populate the strongauthneitcationinfo details with PS directly. This is a widely requested feature and I would recommend voting for this here.
A possible solution here is locking down the Azure portal, however, this will not prevent users from accessing the data through PS.
If the end users register directly, this information is directly saved in the strongauthennticationinfo and is not visible to end users.

@GavinEke We will now proceed to close this thread. If you have further questions, please tag me in the comments and I will gladly continue the conversation.


useQwikTable(options) causes vite to crash in dev mode

TanStack Table version
v8.15.3
Framework/Library version
Qwik 0.0.44
Describe the bug and the steps to reproduce it
Tried using @tanstack/qwik-table in my hobby Qwik/Qwik City project. Vite throws the following error and crashes.
QWIK ERROR Code(20) https://github.com/BuilderIO/qwik/blob/main/packages/qwik/src/core/error/error.ts#L28 Error: Code(20) https://github.com/BuilderIO/qwik/blob/main/packages/qwik/src/core/error/error.ts#L28

Following the Github link above, it looks related to an incorrect use of use* hooks. Linked docs: https://qwik.dev/docs/components/tasks/#use-method-rules
I've attached a Stackblitz environment reproducing the issue.
Your Minimal, Reproducible Example - (Sandbox Highly Recommended)
https://stackblitz.com/edit/vitejs-vite-r68rwq?file=src%2Froutes%2Findex.tsx
Screenshots or Videos (Optional)
No response
Do you intend to try to help solve this bug with your own PR?
No, because I do not know how
Terms & Code of Conduct

[X] I agree to follow this project's Code of Conduct
[X] I understand that if my bug cannot be reliable reproduced in a debuggable environment, it will probably not be fixed and this issue may even be closed.

One more piece of information - I tried copy-pasting the hook from Github, and it's now working from my copy of the code. Perhaps the issue is with the build? Like something with the Rollup config?

Does this only happen in Qwik City?

No, I tested it using the component library which does not use Qwik City and got the same issue :(

Does this only happen in Qwik City?

I also try to copy and paste the hook inside my project. and it seems to be working stably...

So if I understand correctly, we're only able to currently support a TanStack Qwik Table adapter with certain vite settings.


incorrect English grammar means unclear explanation

"...on behalf of the user account which claims are provided in the User member..."
Not clear what that means.  Possibly "... on behalf of the user account in the User member..." and related to the claims requested on the call, but since I can't understand the original statement, I don't know.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 712b76af-89ea-f3a8-1efc-eef633348d92
Version Independent ID: 8e15c5d3-3129-889f-587d-34f30a6d4de0
Content: ITokenAcquisition.GetAccessTokenForUserAsync Method (Microsoft.Identity.Web) - Azure for .NET Developers
Content Source: xml/Microsoft.Identity.Web/ITokenAcquisition.xml
Service: active-directory
GitHub Login: @rloutlaw
Microsoft Alias: routlaw

This issue has been transferred to the repository where the Microsoft.Identity.Web package is maintained as #1325.


Meta tags not updated until theme changed

Issue Summary
After publishing a post without Facebook or Twitter card images, adding a new Facebook or Twitter card image will not show up in Twitter Card Validator or Facebook Share Debugger until the blog theme is changed.
To Reproduce

Post something with a regular post image (I did this with a png), but without custom Twitter or Facebook images
Update post with custom Twitter or Facebook images (jpg)
Refresh post and/or purge caches (any number of times), look at the post's meta tags, which still show meta tags with a link to the regular post image
Switch blog theme in Design (e.g. from custom theme -> Casper)
Look at the post's meta tags, which show meta tags with new post images
Switch blog theme back to original theme

Expected result:

upon adding custom post images, meta tags in post are updated.

Technical details:

Cloudflare caches were purged, post URL was refreshed many times
Custom theme was used, however the new/correct meta tags showed up after switching back to it so its not theme related
Ghost Version: 3.20.0
Node Version: whatever is on ghost.org hosting
Browser/OS: whatever is on ghost.org hosting
Database: whatever is on ghost.org hosting

Optional additional feature
Facebook Share Debugger threw errors on jpg image used, which was solved by making smaller image. Feature suggestion: throw error if Facebook card image uploaded via Ghost is too large / not right format for Facebook.

Hi there! If you're having any issue with a Ghost(Pro) site, please drop us an email on<EMAIL_ADDRESS>and we'll be more than happy to give you a hand directly :slight_smile: This is not a bug 🐛


Fix Penn Treebank corpus reader please

Following the nltk docs on corpus API, I wanted to use nltk to parse a copy of full Penn Treebank corpus. I unzipped the required directories "brown" and "wsj" into /home/tastyminerals/nltk_data/corpora/ptb dir as was stated in the docs. The unzipped files were all lowercased and I had to rename them because ptb corpus reader expects them to be all in uppercase (this issue was reported btw).
After that I am trying to extract a parse tree from a particular file. Using, again, the example from the docs.
from nltk.corpus import treebank, ptb
treebank.parsed_sents('wsj_0003.mrg')[0])   # notice lowecase filename
> Tree('S', [Tree('S-TPC-1', [Tree('NP-SBJ', [Tree('NP', [Tree('NP'...

Works well, for the sample treebank included with nltk.
However, trying to perform the same operation with ptb fails.
ptb.parsed_sents('WSJ_0003.MRG')[0])  # notice the uppercase because we had to rename them
> No such file or directory: '/home/tastyminerals/nltk_data/corpora/ptb/WSJ_0003.MRG'

Well of course there is no such file, the file is in ptb/WSJ/00/WSJ_0003.MRG.
Why does ptb is not aware of the Penn Treebank directory structure? Moreover, why is it case sensitive in the first place? This needs to be fixed. The docs also need to be updated accordingly.

I would be happy to review a PR for a full treebank corpus reader – long overdue to have proper support!


Prebuilt binaries using GitHub Actions

I've been working on GHA as a side project and think it would be useful to add prebuilt binaries automatically to reference designs. Some background and design designs:

Separate yml files means we can target different flavors of RTOSes and/or different toolchains (ex. build_ncs.yml)
Runs on pushes to main, semver tags or PRs
Runs in a VM for speed
Runs a test matrix across target Zephyr SDKs and boards
Uses board name as binary name. This is to keep consistent names across build for later automation
Bundles .bin and .elf in zip with a unique name per run

Future enhancement planned are using git describe in ZIP name, manual running of actions & Containers for more reproducible builds.
Closes #53

Sounds good! Do you want to merge or should I? I don't think I've merged anything in our Org in some time 👴

Hahah, then there is no time like the present, please do the honors!


Modifying densenet weight during transfer learning

The code on densenet model is copying all weight instead of just the required one when someone tries to do transfer learning and intending to adjust how many layers to freeze, I've found the solution which looks a bit hacks and it ran after loading the model, I've submitted a PR #721  that just allow future work to just modify it however they want without searching or debugging it, it's also throwing a deprecated warning when loading the model

Hi,
As I discussed in #721, I think that it's best to keep it like that for now, and let the users write their own function if they want only parts of the model to be loaded.
I'm closing this issue, but let me know if you disagree


AM is using an unreleased version of the client library

Hi,
As i continue to prepare a new package of AM for Debian, I have found another issue: it does not compile with the latest release of client_golang.
At this stage I don't know if I should package HEAD of client_golang, as I fear breaking other users of the library, or try to patch AM to use the older version. Does anybody know if the changes in the library are fully backwards-compatible?
In any case, it seems very counter-intuitive that the client lib has a release process, but its sister projects are ignoring it.

Per https://github.com/prometheus/client_golang/issues/344 that library does not have a formal release process, and you should use master. It sounds like we should get the AM on the newer version.
@beorn7

Thanks @brian-brazil, I had missed that, and was misled by the existence of older releases.
I will see of updating the package for client_golang, hopefully I won t break the rest of the ecosystem :/
BTW, AM is already using a fairly recent commit, according to vendor.json.

Yes, just pin to a recent commit for now. There are still many moving parts. In June, we should be ready with that 0.9 "release" which is planned to be something meaningful to pin to (including 0.9.x to get bugfixes), while the next iteration will be pretty breaking.

This has been fixed: https://github.com/prometheus/alertmanager/blob/8e861c646bf67599a1704fc843c6a94d519ce312/go.mod#L24


Added images

Added images to the documentation to help point out the guide.

I Rachel Irabor, have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
Sent from Outlook for iOShttps://aka.ms/o0ukef

From: microsoft-github-policy-service[bot] @.>
Sent: Wednesday, June 26, 2024 7:01 PM
To: MicrosoftDocs/dynamics-365-customer-engagement @.>
Cc: Rachel Irabor @.>; Mention @.>
Subject: Re: [MicrosoftDocs/dynamics-365-customer-engagement] Added images (PR #3293)
@Uchemenahttps://github.com/Uchemena please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
@microsoft-github-policy-service agree [company="{your company}"]
Options:

(default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.

@microsoft-github-policy-service agree

(when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.

@microsoft-github-policy-service agree company="Microsoft"
Contributor License Agreement
Contribution License Agreement
This Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
and conveys certain license rights to Microsoft Corporation and its affiliates (“Microsoft”) for Your
contributions to Microsoft open source projects. This Agreement is effective as of the latest signature
date below.

Definitions.
“Code” means the computer software code, whether in human-readable or machine-executable form,
that is delivered by You to Microsoft under this Agreement.
“Project” means any of the projects owned or managed by Microsoft and offered under a license
approved by the Open Source Initiative (www.opensource.orghttp://www.opensource.org).
“Submit” is the act of uploading, submitting, transmitting, or distributing code or other content to any
Project, including but not limited to communication on electronic mailing lists, source code control
systems, and issue tracking systems that are managed by, or on behalf of, the Project for the purpose of
discussing and improving that Project, but excluding communication that is conspicuously marked or
otherwise designated in writing by You as “Not a Submission.”
“Submission” means the Code and any other copyrightable material Submitted by You, including any
associated comments and documentation.
Your Submission. You must agree to the terms of this Agreement before making a Submission to any
Project. This Agreement covers any and all Submissions that You, now or in the future (except as
described in Section 4 below), Submit to any Project.
Originality of Work. You represent that each of Your Submissions is entirely Your original work.
Should You wish to Submit materials that are not Your original work, You may Submit them separately
to the Project if You (a) retain all copyright and license information that was in the materials as You
received them, (b) in the description accompanying Your Submission, include the phrase “Submission
containing materials of a third party:” followed by the names of the third party and any licenses or other
restrictions of which You are aware, and (c) follow any other instructions in the Project’s written
guidelines concerning Submissions.
Your Employer. References to “employer” in this Agreement include Your employer or anyone else
for whom You are acting in making Your Submission, e.g. as a contractor, vendor, or agent. If Your
Submission is made in the course of Your work for an employer or Your employer has intellectual
property rights in Your Submission by contract or applicable law, You must secure permission from Your
employer to make the Submission before signing this Agreement. In that case, the term “You” in this
Agreement will refer to You and the employer collectively. If You change employers in the future and
desire to Submit additional Submissions for the new employer, then You agree to sign a new Agreement
and secure permission from the new employer before Submitting those Submissions.
Licenses.

Copyright License. You grant Microsoft, and those who receive the Submission directly or
indirectly from Microsoft, a perpetual, worldwide, non-exclusive, royalty-free, irrevocable license in the
Submission to reproduce, prepare derivative works of, publicly display, publicly perform, and distribute
the Submission and such derivative works, and to sublicense any or all of the foregoing rights to third
parties.
Patent License. You grant Microsoft, and those who receive the Submission directly or
indirectly from Microsoft, a perpetual, worldwide, non-exclusive, royalty-free, irrevocable license under
Your patent claims that are necessarily infringed by the Submission or the combination of the
Submission with the Project to which it was Submitted to make, have made, use, offer to sell, sell and
import or otherwise dispose of the Submission alone or with the Project.
Other Rights Reserved. Each party reserves all rights not expressly granted in this Agreement.
No additional licenses or rights whatsoever (including, without limitation, any implied licenses) are
granted by implication, exhaustion, estoppel or otherwise.

Representations and Warranties. You represent that You are legally entitled to grant the above
licenses. You represent that each of Your Submissions is entirely Your original work (except as You may
have disclosed under Section 3). You represent that You have secured permission from Your employer to
make the Submission in cases where Your Submission is made in the course of Your work for Your
employer or Your employer has intellectual property rights in Your Submission by contract or applicable
law. If You are signing this Agreement on behalf of Your employer, You represent and warrant that You
have the necessary authority to bind the listed employer to the obligations contained in this Agreement.
You are not expected to provide support for Your Submission, unless You choose to do so. UNLESS
REQUIRED BY APPLICABLE LAW OR AGREED TO IN WRITING, AND EXCEPT FOR THE WARRANTIES
EXPRESSLY STATED IN SECTIONS 3, 4, AND 6, THE SUBMISSION PROVIDED UNDER THIS AGREEMENT IS
PROVIDED WITHOUT WARRANTY OF ANY KIND, INCLUDING, BUT NOT LIMITED TO, ANY WARRANTY OF
NONINFRINGEMENT, MERCHANTABILITY, OR FITNESS FOR A PARTICULAR PURPOSE.
Notice to Microsoft. You agree to notify Microsoft in writing of any facts or circumstances of which
You later become aware that would make Your representations in this Agreement inaccurate in any
respect.
Information about Submissions. You agree that contributions to Projects and information about
contributions may be maintained indefinitely and disclosed publicly, including Your name and other
information that You submit with Your Submission.
Governing Law/Jurisdiction. This Agreement is governed by the laws of the State of Washington, and
the parties consent to exclusive jurisdiction and venue in the federal courts sitting in King County,
Washington, unless no federal subject matter jurisdiction exists, in which case the parties consent to
exclusive jurisdiction and venue in the Superior Court of King County, Washington. The parties waive all
defenses of lack of personal jurisdiction and forum non-conveniens.
Entire Agreement/Assignment. This Agreement is the entire agreement between the parties, and
supersedes any and all prior agreements, understandings or communications, written or oral, between
the parties relating to the subject matter hereof. This Agreement may be assigned by Microsoft.

—
Reply to this email directly, view it on GitHubhttps://github.com/MicrosoftDocs/dynamics-365-customer-engagement/pull/3293#issuecomment-2192216127, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AXG6AS2OVZUSP77EOYZSJ3TZJLXUVAVCNFSM6AAAAABJ6IUWQ2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOJSGIYTMMJSG4.
You are receiving this because you were mentioned.Message ID: @.***>

@microsoft-github-policy-service agree
I Rachel Irabor, have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
Sent from Outlook for iOShttps://aka.ms/o0ukef

From: microsoft-github-policy-service[bot] @.>
Sent: Wednesday, June 26, 2024 7:09:15 PM
To: MicrosoftDocs/dynamics-365-customer-engagement @.>
Cc: Rachel Irabor @.>; Mention @.>
Subject: Re: [MicrosoftDocs/dynamics-365-customer-engagement] Added images (PR #3293)
@Uchemenahttps://github.com/Uchemena the command you issued was incorrect. Please try again.
Examples are:
@microsoft-github-policy-service agree
and
@microsoft-github-policy-service agree company="your company"
—
Reply to this email directly, view it on GitHubhttps://github.com/MicrosoftDocs/dynamics-365-customer-engagement/pull/3293#issuecomment-2192232858, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AXG6ASYGPEZMWVYHBWCTAE3ZJLYTXAVCNFSM6AAAAABJ6IUWQ2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOJSGIZTEOBVHA.
You are receiving this because you were mentioned.Message ID: @.***>


Bind bookshelf to "this" for registry methods

I'm using babel in a project which can change the the way certain functions are called internally. This is causing the registry plugin to fail to register models as it's finding that this is undefined here.
This PR makes use of bind to ensure that this is always bound to the bookshelf instance regardless of how it's called.

@dannymidnight If you'd still like this merged I need a better understanding of the use case. Sorry for the late response.

Hey @rhys-vdw, so this PR is about fixing a bug found when calling the model and collection methods  on the registry plugin in a different calling context as currently those methods are unsafely assuming that this is bound to the bookshelf object. My changeset makes that guarantee as seen in the test cases.
I'm assuming this bug would generally only ever be encountered when a project is using some kind of pre-compilation step which in my case (using babel) was causing this to be undefined.

@dannymidnight Why whould you call related without model instance? Are you referencing the related method in some array? Could you please provide an actual use case as JS?


Vxiong branch

npm install will do:

npm install
bower install

http://stackoverflow.com/questions/18875674/whats-the-difference-between-dependencies-devdependencies-and-peerdependencies
it looks like there would be no difference in our usage, so I deleted dependencies.

added more packages required by testing

Looks good. Ship it!


Does Franz work with Pop!_OS?

That's all, sorry couldn't find info.

This isn't an issue is it? It's a question you could answer yourself.

I only found this snap package in the making
https://forum.snapcraft.io/t/call-for-testing-franz/4132
Rambox has a snap package just saying, and yes I know it's not really an issue I just wanted some insight from people that may know, sorry for that!

PopOS is an ubuntu derivative, so the answer is yes. Just download the .deb from the website!

Yep! They're both debian, I was able to make it work. After using Rambox too I thought it would be cool to have an autocode feature for applying css to services but that's another matter, thanks for the reply.


Run template's own tests in GitHub workflow

Is comment in header of workflow useful ? I would not have let it there

Why limiting it to push on master and PR on master ? It could be done on all pushes ?

You tested different parts of the template in several jobs. Why not instantiating it only once and performing tests sequentially using steps ?

Why limiting it to push on master and PR on master ? It could be done on all pushes ?

Yes why not.

In job semantic_release, there is some dead code to remove

Removed.

You tested different parts of the template in several jobs. Why not instantiating it only once and performing tests sequentially using steps ?

They don't need one another so running them sequentially would make the whole build slower.

You tested different parts of the template in several jobs. Why not instantiating it only once and performing tests sequentially using steps ?

They don't need one another so running them sequentially would make the whole build slower.
@slequeux are you OK with this answer?

Ok for using more CPU for less build time

OK for me for a squash and merge


Allow co-recommenders to invite reviewers, issue decisions, and edit submission information in all PCIs

 Extend the TRELLO #509 (made for PCI) RR to all PCI

Reason for closure: Too complicated(due to conflict with a separate feature) - with a lot of potential silent bugs - and actually not very useful


first version

@hadican I think it is ready for publishing :)

@hadican I think It would be better if you separate the Docker Setup section into two sub-sections. One for building the image locally and using it. And one for using the ready image from Docker Hub. Current Readme (Docker Setup) starts with building the image locally and using it from Docker Hub.

Good point. 👍 I'll change it.


Integrated terminal resets scroll position to top when emacs is closed

Issue Type: Bug
Reopening of #62329
steps

In the intergrated terminal.
Run a command that generates more than one screen of content: ls -alF /dev/
Scroll to bottom
Now run emacs and then close emacs using ctrl+c ctrl+x

Bug
Terminal scroll position is sometimes reset to top of buffer

VS Code version: Code - Insiders 1.40.0-insider (86405ea23e3937316009fc27c9361deee66ffbf5, 2019-11-06T16:56:25.487Z)
OS version: Darwin x64 18.7.0

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-4770HQ CPU @ 2.20GHz (8 x 2200)

GPU Status
2d_canvas: enabledflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmetal: disabled_offmultiple_raster_threads: enabled_onoop_rasterization: disabled_offprotected_video_decode: unavailable_offrasterization: enabledskia_renderer: disabled_offsurface_control: disabled_offsurface_synchronization: enabled_onvideo_decode: enabledviz_display_compositor: enabled_onviz_hit_test_surface_layer: disabled_offwebgl: enabledwebgl2: enabled

Load (avg)
2, 2, 2

Memory (System)
16.00GB (0.02GB free)

Process Argv
-psn_0_1614218

Screen Reader
no

VM
22%

Can't repro 🙁 some things that might help diagnose:

Debug VS Code to see what's getting hitting hit. Calls to this when exiting would be particularly interesting https://github.com/xtermjs/xterm.js/blob/dd4eb7bdecf1c13748c27de65c7bc32d95e3d30e/src/Terminal.ts#L1027
Try repro in the xterm.js demo
Enable escape sequence logging and capture the entering emacs logs and exit emacs logs for both the case where it's fine and the case where the scroll is off.

Seems to happen most reliably when I run emacs as the git editor, but as the screenshot shows it can also happen for normal runs.
From debugging:
Normal case

scroll called with undefined
_onScroll called twice with _ignoreNextScrollEvent == true
scrollLines not called by _onScroll

Bugged case

scroll called with undefined
_onScroll called with _ignoreNextScrollEvent == true
_onScroll called again _ignoreNextScrollEvent == false
scrollLines called by _onScroll with -3145

_onScroll called again _ignoreNextScrollEvent == false
scrollLines called by _onScroll with -3145

That's definitely the problem, could you get the stacktrace for both of those?

Stacks look the same. Here _onScroll called with _ignoreNextScrollEvent === true ![Screen Shot 2019-11-08 at 3 07 03 PM](https://user-images.githubusercontent.com/12821956/68516644-72c31380-0239-11ea-82d3-7b45f28e4543.png) :
And with _ignoreNextScrollEvent === false:

It seems like a timing issue. Between the call to _innerRefresh which sets _ignoreNextScrollEvent  = true and _scroll, someone else is setting _ignoreNextScrollEvent = false. Here's one possible call sequences I see opening emacs in the bad case (true/false is the value of _ignoreNextScrollEvent ):

And from the good case:

For what it's worth, I also currently see this more often in insiders (vs OSS)

I don't use emacs or something, just run some tests which output a lot of stuff, then hide and unhide terminal - after a couple of moments I am on top of terminal. Scrolling it with a scrollbar to the bottom doesn't bring me to the last line, so I press enter

Yeah, I have to press enter to get to the bottom of the terminal. I can confirm that this is an issue with Linux and Windows (I see this on both), so it doesn't appear to be specific to any OS. This also happens with both native and remote development, so it is not specific to remote development (which I use a lot). For me, it starts happening after about an hour of use, and then becomes really frequent (almost every time I open the terminal). Its causing me to form a habitual response to just always press enter when I open the terminal :frowning_face:

Another repro: https://github.com/microsoft/vscode/issues/87477

The #87477 case seems to be a symptom of the TerminalPanel onDidChangeVisibility callback not triggering a setVisible call on the active terminal instance.
https://github.com/microsoft/vscode/blob/df48af1684713cb61c1efbe05a73d1494e1d294a/src/vs/workbench/contrib/terminal/browser/terminalPanel.ts#L98
The code to re-sync the the Terminal viewport and scrollbar is in the TerminalInstance setVisible method.
https://github.com/microsoft/vscode/blob/df48af1684713cb61c1efbe05a73d1494e1d294a/src/vs/workbench/contrib/terminal/browser/terminalInstance.ts#L904
I'm not sure if it's the same issue as the Emacs variation of the bug.


[New] Invite and kick user intents

This PR introduces these new intents

Invite User
Kick User

updating en-us model with latest intents should be in separate PR


chore(docs): fix broken link in readme.md

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 91.837%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
165

Relevant Lines:
179

💛  - Coveralls


[Tooltip] documentation and playground

Environment

Operating System: Darwin
Node Version:     v22.9.0
Nuxt Version:     3.13.2
CLI Version:      3.15.0
Nitro Version:    2.9.7
Package Manager<EMAIL_ADDRESS>Builder:          -
User Config:      -
Runtime Modules:  -
Build Modules:    -

Version
v3.0.0-alpha.7
Reproduction
https://ui3.nuxt.dev/components/tooltip
https://github.com/user-attachments/assets/70f0000e-8eeb-4ed2-98b1-576fa02b4806
Description
Tooltip does not appear in the correct position in the documentation and playground
Additional context
No response
Logs
No response

I tested locally and this seems solved on the main branch.

Related to https://github.com/unovue/radix-vue/issues/785.

Thanks @benjamincanac for the clarification.

Seems to have been fixed by https://github.com/nuxt/ui/pull/2642 when I go through deployments.


X-axis ticks are misplaced when using Bar chart with datetime x-axis.

I plotted a bar chart with datetime xaxis but the axis ticks are showing over wrong dates.
here is the codepen for the same
https://codepen.io/gauravgb21/pen/XWpeKNo
Below is the screenshot.

For this, you need to change xaxis.tickplacement to 'on', default is 'between'
https://apexcharts.com/docs/options/xaxis/#tickPlacement

xaxis.tickPlacement does not work for type datetime. Any other solutions for this?