Creating New Data Map, Nothing Appears after Naming

Describe the Bug with repro steps
Environment Information
Workstation: Windows 11 Version 23H2 Build 22631.3296
VS Code Version 1.88.0
Using Logic Apps Standard Extension v3.0.3
Reproduce Steps:
Step 1. Select Button "Create new data map"
Step 2. Pop Up will appear asking for Data Map Name, enter name
Nothing else happens, no ui loads.
Side note I am seeing an info popup saying "Validating Runtime Dependency: Function Runtime", I dont think this is related but adding as additional info incase its needed.
Screenshots or Videos
No response
Version
v3.0.2
Additional context
No response

Hi @WilliamDShiell I'm looking into your issue and so far I can't reproduce it. Could you attach a screenshot of what you see after you type in the name? Another thing that would be helpful is the text from "Output" in VSCode, and select 'Azure Logic Apps' from the dropdown, and you should see some logs there, or maybe an error message.

One thing to try- it is possible the extension is hanging somewhere when installing the Functions Runtime. As a possible fix, could you install that dependency separately? Please let me know if that helps, and we can work on making that experience better.

Can confirm functions extension is already installed.
New Error Message Appearing today, see screenshot. Any idea of the resolution steps here?

Hey @WilliamDShiell, which version of the Logic Apps Standard extension are you using? I can see two differences in the initial context of the issue.
The latest error that you are experiencing is due to the extension not being activated. Usually, the commands aren't exposed until the extension gets fully activated, and an issue during the activation will make all of them fail. Do you see any other error previous this one?

Hey @ccastrotrejo running version 3.0.3. Waited 20 minutes for extension to load and looks like we are back to the original behavior. Attaching screenshot of the terminal output set to Output the Azure Logic Apps Standard.
Same behavior as before:
Step1. Select Create new Data Map
Step2. Plug in value for map name and hit enter.
No changes to terminal output or anything noticable in VS Code. Is there anywhere in terminal other than output I should be looking for logs?

Hi @WilliamDShiell thanks for sharing your screenshot. I am still looking at what might be wrong with the installation of dependencies on your end. In the meantime could you please check if the following extension setting are configured as follow?

Auto Runtime Dependencies Path: Correct
Auto Runtime Dependencies Validation and Installation: Correct
Auto Start Azurite: Correct
Auto Start Design Time: Correct
Azurite Location Settings: Correct
Dotnet Binary Path: Correct
Func Core Tools Binary Path: Correct
Node JS Binary Path: Correct

Hi @WilliamDShiell, sorry for the delayed response. I don't see any other way that the extension initialization its failing besides the error from the screenshot above about the path not being sent correctly, I will keep investigation where this is happening. Please if this is still happening and if you see any other error, please let me know.
Also you can take a look at the console tab from the developer tools. To open it you can do the following

Ctrl+Shift+P -> will open the command palette
Type Toggle developers tool
Click in Console tab

Hey @ccastrotrejo,
Adding a few new error messages. Hoping this may help point to the issue:
Receive this message starting up VS Code when connected to proxies:

When disconnected to proxies receive this error message today:

Would it be worth it to do a complete uninstall of VS Code + Extensions and attempt again? Could either of these error messages help point to the root issue?

Adding Additional Screenshots, selecting Create new data map brings up the type name prompt but does nothing else, no new events appear in the console
Selecting Load existing data map brings up event in console "The "path" argument must be of type string, received undefined"

Ok, this makes more sense. Yeah I think it would not make anything worse uninstalling the extension, remove the dependencies folder and install it again. The request timeout error is showing up as it is taking longer to check the dependencies and download them, if you want to increase it in extensions settings that's also good.
So neither of the two commands show something in terms of the UI in vscode?

Other than the Create New opening up the box to name the map, neither of the buttons work.

Finished fresh install, still seeing the same issues. Is there anywhere else we can check for logs?

Hi @WilliamDShiell I heard from our Customer Support team, the issue got resolved. I will close the issue but wanted to write down the state of the issues found on this thread.

"The "path" argument must be of type string, received undefined" -> Reason of the issue is because a logic app project must be open in vscode in order to create and load the data map file. I will work on implementing an experience in which the user can open/create a project from it and update the official documentation.
'azureLogicAppsStandard.dataMap.createNewDataMap' not found -> Root cause of the issue is that the extension isn't getting activated properly, therefore all the commands get disable and unable to trigger. I still haven't found what is causing the extension to not get activated, but I will work on trying to repro it.


Moving node on screen changes the pattern

Version 0.93
Windows 10 (2004, Build 19041.572)
I'm not sure if this is a bug or not.  I loaded up the software and then loaded the example Mosaic material.
When I grab the Voronoi node and move it around, the texture changes as if the position of the on screen node affects it.  Is this be design?
Steps to reproduce:

Start Material Maker.
Open the example Mosaic material.
Grab the Voronoi node and just drag it around the screen.
Notice that the texture changes as you move the node around.

Yes it is a feature, moving random nodes rerolls their seed.
But it will soon be optional (it's very nice for small material graphs, but not when the graph becomes too big). Seeds will be rerolled when clicking on the "dice" button.


WinAscent is lower than font yMax

The latest released Roboto Mono and the one build from sources trigger the following fontbakery fail.
I assume we don’t want to change Roboto Mono’s font metrics and should ignore this fail.
Can you confirm?
🔥 FAIL: Checking OS/2 usWinAscent & usWinDescent.
com.google.fonts/check/family/win_ascent_and_descent
--- Rationale ---
A font's winAscent and winDescent values should be greater than the head
table's yMax, abs(yMin) values. If they are less than these values, clipping
can occur on Windows platforms
(https://github.com/RedHatBrand/Overpass/issues/33).
If the font includes tall/deep writing systems such as Arabic or Devanagari,
the winAscent and winDescent can be greater than the yMax and abs(yMin) to
accommodate vowel marks.
When the win Metrics are significantly greater than the upm, the linespacing
can appear too loose. To counteract this, enabling the OS/2 fsSelection bit 7
(Use_Typo_Metrics), will force Windows to use the OS/2 typo values instead.
This means the font developer can control the linespacing with the typo values,
whilst avoiding clipping by setting the win values to values greater than the
yMax and abs(yMin).
🔥 FAIL OS/2.usWinAscent value should be equal or greater than 2163, but got 2146 instead [code: ascent]

@m4rc1e

@m4rc1e
closing this Issue re: Roboto Mono font metrics.  I believe we agreed verbally that the font metrics should remain the same.


fix derivedDataPath test

Noticed this while investigating something else, Turns out it wasn't passing the param properly.

Looks good :+1:


bug:  Max context length automatically defaults to 4096 tokens

Jan version
0.5.8
Describe the Bug
https://discord.com/channels/1107178041848909847/1204617960615055401/1301375861282312235
For imported models only, Jan did try to fall back to hub model.json, so it uses the maximum number instead:

We need to find a better solution for this.
Steps to Reproduce
No response
Screenshots / Logs
No response
What is your OS?

[X] MacOS
[X] Windows
[X] Linux

Current:
The current default value = min(8192, max_model_context_length)
Where it should be:
Differentiate between model metadata and run settings:

Users can define model load parameters (both CLI and API, currently API is supported), default is the formula above.
Model.yaml should maintain GGUF metadata.

PS C:\WINDOWS\system32> cortex-nightly.exe models start tinyllama:gguf --ctx_len 1024
Start downloading..
model.gguf          100%[====================] 00m:00s 637.81 MB/637.81 MB
model.yml           100%[====================] 00m:00s 545.00 B/545.00 B
Model tinyllama:gguf downloaded successfully!
tinyllama:gguf model started successfully. Use `cortex-nightly.exe run tinyllama:gguf` for interactive chat shell
PS C:\WINDOWS\system32> cortex-nightly.exe ps
+-------------------+-----------+--------+-----------+---------------------------------+
| Model             | Engine    | RAM    | VRAM      | Up time                         |
+-------------------+-----------+--------+-----------+---------------------------------+
| tinyllama:1b-gguf | llama-cpp | 0.00 B | 636.18 MB | 2 hours, 14 minutes, 14 seconds |
+-------------------+-----------+--------+-----------+---------------------------------+
| tinyllama:gguf    | llama-cpp | 0.00 B | 636.18 MB | 4 minutes, 5 seconds            |
+-------------------+-----------+--------+-----------+---------------------------------+
PS C:\WINDOWS\system32> cortex-nightly.exe run tinyllama:gguf --ctx_len 1024
In order to exit, type `exit()`
>


SCP-2458: Extend InputField to include number inputs (using NumberFormat).

I tried several things before settling on this solution, which I think is quite neat - some of the other things I tried were certainly a lot more complicated... :sweat_smile: Explanations of the various things are in the comments.
I've thrown in a dummy number input in the contract setup card, just for testing. Don't look too closely at the contract setup card itself, which continues to be visually broken - making that look like the new designs is the very next thing on my list.
Here's a screenshot showing the dummy number input (but you probably need to try it for yourself to get the full idea):

Would it be possible to filter out the "e" character?

Hmm, that's funny - what browser were you using? In any case I think my second commit should have fixed this. Would you mind checking again?

Why do characters disappear from the left side?

Not sure what you mean by this. Can you give an example?

For ADA at least I don't think it is super convenient to have to type all the zeroes, if you just want 40 ADA for example. But I am a bit biased towards my implementation ofc :)

You don't have to type them - they're added for you automatically. Or have I misunderstood?

Also writing negative numbers seems a bit difficult

Good point, I forgot about negative numbers! :flushed: I've fixed that with another commit.

Would it be possible to filter out the "e" character?

Hmm, that's funny - what browser were you using? In any case I think my second commit should have fixed this. Would you mind checking again?

Why do characters disappear from the left side?

Not sure what you mean by this. Can you give an example?

For ADA at least I don't think it is super convenient to have to type all the zeroes, if you just want 40 ADA for example. But I am a bit biased towards my implementation ofc :)

You don't have to type them - they're added for you automatically. Or have I misunderstood?

Also writing negative numbers seems a bit difficult

Good point, I forgot about negative numbers!  I've fixed that with another commit.

I used chromium, I think, I will give it another try, maybe record

Yeah, @palas noticed the same problem with the functionality. Bugger. I'll fiddle around some more tomorrow and see if there's a fix, otherwise we may have to accept it has to be a string input. 😖

Okay, after banging my head against the wall for a bit, I have come up with a new solution.
The first thing to note is that I'm no longer formatting the number onValueInput or onKeyUp, but onBlur. It would be nice if we could format it as you type, but I can't see a way of doing that without the problem of the cursor jumping to the end of the input when you don't want it to. (There is Pablo's nifty technique with setSelectionRange, but that only works if it's a string input, and then you lose all the nice native number input support. I think getting the native number support is worth this price.)
The second thing is that I've identified the problem that showed up previously with very large numbers. It was the fault of the NumberFormatter that we're using in the Humanize module (there's a comment about it in this latest commit).
And finally, as I was doing this I suddenly remembered about the CSS focus-within selector. Just the thing for a nice CSS-only implementation of the div-as-input that's needed to get the styling right. :tada:

It seems quite robust now, but after trying really hard I managed to find another glitch:
When I write 0.00001 I get `0.100000'
I had the same problem, that is why I knew to try this.
Other than that there is just the CSS issue with the top line disappearing when you focus on the field

Phew, I think I've fixed it now. :sweat_smile:

Phew, I think I've fixed it now.

Bad news. I had almost given all hope but in the end I found another one 😎, if I write:
-0.001
The minus gets removed

Okay, I see what I did wrong there, and I've fixed that now. There is absolutely definitely no possible way you will ever find any more bugs in this implementation now. :grinning: Game on...


Add RSync -> RoleBinding dependencies in e2e tests

Add Repository.Exists(path) to avoid fatal errors from Delete in a Cleanup block
Fix TestComposition level-1 RootSync file location, so that it's correctly managed by level-0 and can depend on its RoleBinding
Add nomostest.SetDependencies to simplify annotation construction
Add TestMultiSyncs_Unstructured_MixedControl Cleanup to handle deletion ordering of dependencies between managed and unmanaged resources

/lgtm
/approve


chore: release main

:rocket: Automated Release
dev-dependencies-client: 6.0.4
6.0.4 (2024-09-19)
Bug Fixes

bump dependencies to latest minor (#417) (fc00a39)

Dependencies

The following workspace dependencies were updated

dependencies

@versini/dev-dependencies-common bumped to 4.1.7

dev-dependencies-common: 4.1.7
4.1.7 (2024-09-19)
Bug Fixes

bump dependencies to latest minor (#417) (fc00a39)

dev-dependencies-server: 5.1.7
5.1.7 (2024-09-19)
Bug Fixes

bump dependencies to latest minor (#417) (fc00a39)

Dependencies

The following workspace dependencies were updated

dependencies

@versini/dev-dependencies-common bumped to 4.1.7

dev-dependencies-types: 1.3.7
1.3.7 (2024-09-19)
Bug Fixes

bump dependencies to latest minor (#417) (fc00a39)

This PR was generated with Release Please. See documentation.

:robot: Created releases:

dev-dependencies-common-v4.1.7
dev-dependencies-client-v6.0.4
dev-dependencies-server-v5.1.7
dev-dependencies-types-v1.3.7
:sunflower:


Require doctrine/common version 2

concrete5 requires the Doctrine\Common\Persistence\Mapping\Driver\MappingDriverChain
class.
Until doctrine/common version 2.8.x, that class was included in the doctrine/common library itself.
From version 2.9.x and before version 3.0 of doctrine/common, that class has been moved to the doctrine/persistence package version 1.
Starting from doctrine/common version 3, that class has been removed from doctrine/persistence.
So, as long as we use that class, we have to use doctrine/common version 2.

It hasnt been removed just the namespace has been moved
https://github.com/doctrine/persistence/blob/master/lib/Doctrine/Persistence/Mapping/Driver/MappingDriverChain.php
Is there any other reason we cant just up date the namespace and use version 3?

Well, IMHO renaming a namespace is like deleting a class :wink:
I don't think that we can upgrade the code in v8:

doctrine/common v3 requires PHP 7.1 (concrete5 8 supports PHP 5.5)
 Doctrine\Persistence\Mapping\Driver\MappingDriverChain was first introduced in doctrine/persistence v1.3.3, (required by doctrine/common v2.13.0), which requires PHP 7.1

For sure we can think about switching from  Doctrine\Common\Persistence\Mapping\Driver\MappingDriverChain to  Doctrine\Persistence\Mapping\Driver\MappingDriverChain in concrete5 v9


A more helpful help

"help" command should not show the AddressBook-Level4 website. It should show our user guide. In fact, it is better if the help command can be accessed offline.

help COMMAND will open the help window and jump to the command usage of COMMAND.

@snehasp13 Try to do this first.

@potatowagon Can help do this?

ok


documentation UI adds dynamic query string literal to query

Context
"hapi-swagger": "^7.2.0"
{
        method: 'GET',
        path: '/users/{ids}',
        config: {
            handler: Users.getUsersById,
            tags: ['api'], // ADD THIS TAG
            validate: {
                query: {
                    ids: JS.Users.pick('id')
                }
            }
        }
    },

What result did you get?
request url contains "{ids}"

cant figure out why request url adds the "{ids}" in documentation UI

Hi this looks like JS.Users.pick('id') is referencing an object which is not a JOI type. It could be that it is a JOI type but in someway wrap in a native JavaScript object?
Without understanding  what JS.Users.pick('id') returns its hard to help. If you can debug the code and check that JS.Users.pick('id') is returning a JOI type, it should have the property isJoi: true

hey, so I removed the validate portion of the hapi route config, still not getting a dynamic path to work correctly.

trying to get as close as the doc example

Please reopen if issue persist in latest version.


get z-values

Please resubmit this pull request to berkeley159/project-gamma test branch instead of main branch. We are following this practice from now on. I'll close this pull request once you resubmit to the test branch.

I suggest renaming this file to something more meaningful like "network_analysis.py".

Closed because pull request has been resubmitted to test branch


[CX-RELEASE RELEVANT] Feature/tracefoss 604 update dashboard response

Do not merge until release is clarified!

Will be closed as the content is completly included in: https://github.com/catenax-ng/tx-traceability-foss/pull/789


Update fs2-core, fs2-io to 3.2.7

Updates

co.fs2:fs2-core
co.fs2:fs2-io

from 3.2.4 to 3.2.7.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "co.fs2" } ]

labels: library-update, early-semver-patch, semver-spec-patch, commit-count:1

Superseded by #665.

Superseded by #678.


Making sure the photoCursor is always closed

Sometimes the app would crash with the following error:
android.database.CursorWindowAllocationException: Cursor window could not be created from binder
The stacktrace points to ContactAccessorSdk5.java:910
According to this StackOverflow thread this is due to a cursor not being closed correctly. Indeed, if photoCursor.moveToFirst() returns true, photoCursor.close() was never called.
This patch tackles this case.

Yea, it fails for me too. Always, though.

This seems to occur with at least moderate consistency on Samsung Galaxy S5 devices running Android 5.x. I tested it on two different devices and both of them consistently crash and this error is thrown from at least one of the devices.

This close() is missing! This pr should be merged!

Tested, works fine. The JIRA issue: https://issues.apache.org/jira/browse/CB-9823
@gleerman, i'm going to merge this, but still want to ask you to file an Apache CLA as described here: http://www.apache.org/licenses/#clas


Usability of choose catalog/schema dialog

It would be great if you added an apply button to this dialog and text label to search box.
Something like that:

Not sure about that. This is a modeless dialog. You can choose schema by using double click or Enter. Click anywhere outside of this popup will close it. Adding standard dialog buttons may confuse users.
Moreover I'm thinking about making some other config dialogs the same..

It always confuses me when I open by mistake (when I understand, that I have to change database firstly) and do not want to choose the schema, but want to close it without any changes.
Probably it would be nice to combine schema selection dialog and database selection dialog, to exclude the case when the user wants to close it without any changes.
To my mind it's bad practice to click somewhere outside the window to close it.


API rework

The idea of this change is to further modularize the different components and help devs make less mistakes.
I've moved all Tracker.track* methods except the basic Tracker.track(TrackMe) one into a new class named TrackHelper which uses the builder pattern to guide devs through creating correct TrackMe's.
The entry to tracking any type of action is a static method on the TrackHelper object that takes only the required parameters. Optional parameters can then be chained to the object.
Examples:

TrackHelper.track().screen("/user/profile").with(tracker) would be the shorthand form for most cases.
Alternative: TrackMe trackMe = TrackHelper.track().screen("/user/profile").build() if we want to keep a TrackMe object for later.
We can also base our new objects on old ones: TrackHelper.track(oldTrackMe).goal(1).with(tracker)

I think this is much more readable, because we see what arguments we are setting, we can no longer accidentally switch e.g. quantity and revenue because both are integer values in a 5 parameter long method. Required parameters are obvious as they are part of the initial method you have to call to even reach other parameters and they don't take null as argument.
This is also allows more flexibility if we want to extend the API because rather than creating new methods with more and more parameters, we just add a one parameter method.

Still wanna improve the previous "QuickTrack" options to follow the same style.
Also want to see if we can better integrate CustomDimensions into this pattern.

@d4rken Good work :+1: , I like the new API. I think we should bump major version since there are some backward incompatible changes.

Good idea. I'll add a commit to this PR that increases the version.
After merging it into dev, we leave it there for a few days and then the current dev branch into master, as a v1.0.0 release?
I'm also getting closer to actually coding something for #16 but because it's all transparent changes, we could add something like that in a v1.1.0


add lhs for compile opt

#60  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @Angryrou and the rest of your teammates on  Graphite


Slate-bundled JS files generated as broken symlinks

Bug Description
As of 3.0.0-2, I am able to build and serve the documentation site successfully. However, there appears to be an error with several of the JS files from Slate that get generated, namely "imagesloaded.min.js", "jquery.min.js", and "lunr.min.js". The error seems to stem from the call to npx reslate init, where the code files that get generated are symlinks instead of the files themselves, and inspecting these symlinks reveals them to be broken. If I look in the "node_modules" directory for reslate, the source files for these files are broken symlinks as well.
The symlinks are copied to the output upon running npx reslate build, which results in several aspects of the final site not working properly. For example, the code snippet column shows the sample code from all languages at once, and clicking the language tabs does nothing.
Here is the directory of my API description after having only run npx reslate init (note the curled arrows by the aforementioned files indicating they are symlinks and inspecting the files results in a read error):

And here is the resulting web page (note the code samples for Ruby, Python, Shell, and JavaScript are all being displayed simultaneously):

And this is the console output from the web page (the errors regarding $ would be because the jQuery script isn't being loaded):
jquery.min.js:1 Failed to load resource: the server responded with a status of 404 (Not Found)
imagesloaded.min.js:1 Failed to load resource: the server responded with a status of 404 (Not Found)
lunr.min.js:1 Failed to load resource: the server responded with a status of 404 (Not Found)
jquery.highlight.js:46 Uncaught ReferenceError: jQuery is not defined
    at jquery.highlight.js:46
imagesloaded.min.js:1 Failed to load resource: the server responded with a status of 404 (Not Found)
lunr.min.js:1 Failed to load resource: the server responded with a status of 404 (Not Found)
lang.js:172 Uncaught ReferenceError: $ is not defined
    at lang.js:172
    at lang.js:180
search.js:36 Uncaught ReferenceError: $ is not defined
    at search.js:36
    at search.js:101
(index):32 Uncaught ReferenceError: $ is not defined
    at (index):32

I am running Ubuntu 18.04.5 via WSL2.

Is this still true for this report? If you could tell me what the following symlinks are trying to point to, from your project-dir/node_modules/reslate/source/slate/js/lib it would be helpful:
imagesloaded.min.js
jquery.min.js
lunr.min.js

I'd also like to know whether you used npm, yarn or pnpm to install reslate?

That is still true, though it's worth noting that if I try to run npm i reslate  in Windows itself the symlink files don't appear at all.
Running readlink on the symlinks within the node_modules source files results in the command exiting with an error code and no output. Running chase outputs the following:
> chase imagesloaded.min.js
chase: /**project-dir**/node_modules/reslate/node_modules/imagesloaded: No such file or directory

> chase jquery.min.js
chase: /**project-dir**/node_modules/reslate/node_modules/jquery/dist: No such file or directory

> chase lunr.min.js
chase: /**project-dir**/node_modules/reslate/node_modules/lunr: No such file or directory

I have been using npm. Specifically npm 6.14.8.

This should be fixed in<EMAIL_ADDRESS>which no longer uses symlinks for these files due to these cross-platform issues and 11ty support. Thanks again for the report.


Remove global functions

Also some minor style fixes.
fix #68

Coverage increased (+10.7%) to 57.455% when pulling df5f14d8c14cca5de1efcc5701cba4e247f93197 on tianyu-no-globals into b1682c69f688100030d5ca098ce4b6f634dc8737 on master.


Prototype transport for httpx

https://github.com/Azure/azure-sdk-for-python/issues/11279

Is this still planned?


Update copyright year in NOTICE

Spotted this one when creating https://github.com/docker/docker/pull/10938

LGTM

LGTM


[ownership] Add a frontend option -disable-ossa-opts to disable ossa based opts for benchmarking purposes.

FYI: @airspeedswift

@swift-ci smoke test and merge


Add post: Round 8 public beta placement school research findings

 User research with public beta placement schools

 Design history - Clair's UR with different types of schools


What is ddboolq in the evaluation? We cannot find the "ddboolq" task in lm-evaluation-harness.

We cannot find the "ddboolq" in lm-evaluation-harness.
We can only find the boolq task in the task list. And we run the boolq for the open-llama-3b, the result is different.

So want to know what is ddboolq in the evaluation?

Sorry that was a typo, and the task is boolq. We did our evaluation in JAX so there could be slide difference due to numerical precisions. Also please note that to correctly evaluate our model in lm-eval-harness, you need to change the lm-eval-harness code to avoid using the huggingface auto-converted fast tokenizer, as that tokenizer produces incorrect tokens sometimes. See this issue for more details.


python3Packages.adafruit-platformdetect: 3.2.0 -> 3.3.0

Motivation for this change
Update to latest upstream release 3.3.0
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[x] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 115433 run on x86_64-linux 1

2 packages built:

python38Packages.adafruit-platformdetect
python39Packages.adafruit-platformdetect

Result of nixpkgs-review pr 115433 at 1e5eae6f run on aarch64-linux 1

2 packages built:

python38Packages.adafruit-platformdetect
python39Packages.adafruit-platformdetect


Remove use of BufferReader within JsonReader to measure overhead

Attempting to use ReadOnlySequence<byte> directly to measure performance overhead of using BufferReader.
There is ~15% overhead of using BufferReader APIs rather than custom implementations and ReadOnlySequence<byte> directly.

BenchmarkDotNet=v<IP_ADDRESS>3-nightly, OS=Windows 10.0.17713
Intel Core i7-6700 CPU 3.40GHz (Skylake), 1 CPU, 8 logical and 4 physical cores
.NET Core SDK=3.0.100-alpha1-20180720-2
  [Host]     : .NET Core 2.1.2 (CoreCLR 4.6.26628.05, CoreFX 4.6.26629.01), 64bit RyuJIT
  DefaultJob : .NET Core 2.1.2 (CoreCLR 4.6.26628.05, CoreFX 4.6.26629.01), 64bit RyuJIT

Before:

Method
TestCase
Mean
Error
StdDev
Median
Gen 0
Allocated

ReaderSystemTextJsonLabMultiSpanSequenceEmptyLoop
BasicJson
1,149.8 ns
22.911 ns
47.315 ns
1,121.5 ns
0.0076
40 B

ReaderSystemTextJsonLabMultiSpanSequenceEmptyLoop
HelloWorld
353.3 ns
2.199 ns
1.950 ns
353.4 ns
0.0091
40 B

ReaderSystemTextJsonLabMultiSpanSequenceEmptyLoop
Json400B
1,500.5 ns
10.395 ns
9.215 ns
1,501.6 ns
0.0114
56 B

ReaderSystemTextJsonLabMultiSpanSequenceEmptyLoop
Json400KB
1,195,981.8 ns
7,753.480 ns
7,252.609 ns
1,197,271.0 ns
-
0 B

ReaderSystemTextJsonLabMultiSpanSequenceEmptyLoop
Json40KB
118,374.7 ns
449.618 ns
420.573 ns
118,243.9 ns
-
0 B

ReaderSystemTextJsonLabMultiSpanSequenceEmptyLoop
Json4KB
10,846.9 ns
95.483 ns
79.733 ns
10,830.6 ns
0.0916
416 B

After:

Method
TestCase
Mean
Error
StdDev
Median
Gen 0
Allocated

ReaderSystemTextJsonLabMultiSpanSequenceEmptyLoop
BasicJson
984.7 ns
19.435 ns
38.364 ns
969.8 ns
0.0076
40 B

ReaderSystemTextJsonLabMultiSpanSequenceEmptyLoop
HelloWorld
318.8 ns
1.730 ns
1.534 ns
318.2 ns
0.0091
40 B

ReaderSystemTextJsonLabMultiSpanSequenceEmptyLoop
Json400B
1,284.3 ns
11.059 ns
10.344 ns
1,281.8 ns
0.0114
56 B

ReaderSystemTextJsonLabMultiSpanSequenceEmptyLoop
Json400KB
1,048,252.0 ns
12,956.988 ns
11,486.031 ns
1,047,165.8 ns
-
0 B

ReaderSystemTextJsonLabMultiSpanSequenceEmptyLoop
Json40KB
102,040.0 ns
1,581.665 ns
1,320.762 ns
101,601.2 ns
-
0 B

ReaderSystemTextJsonLabMultiSpanSequenceEmptyLoop
Json4KB
9,351.8 ns
194.793 ns
346.245 ns
9,269.9 ns
0.0916
416 B

cc @JeremyKuhne, @AndyAyersMS

A few thoughts from my side, since I tried to tackle buffered reading/writing vs. reading/writing everything from only one buffer in SpanJson multiple times and below is the method, with which I came the closest to my goals (and still missed it)...
Let's assume a fairly well sized buffer, i.e. 4k for everything, nothing too small, everything above 1k is probably fine.
One of the possible goals is to get around large arrays, i.e LOH arrays, which is both important from a performance perspective and to keep memory in general in check. I will ignore the it's more performant to start parsing/writing the json before I have all the data faction for now, as this will only apply for huge sizes and the parsing/writing speed of Json isn't the problem on modern systems.
I imagine that most of these following is nothing new for you, but maybe it helps anyway.
What datatypes are affected?
Simple answer: String, a string has a dynamic length and we need the value from start to end.
This affects both json attribute names and the actual payloads.
I don't really know the maximum length of an c# identifier (theoretically it's apparently not limited), but Stack Overflow posts basically point to like 1000 chars and then Visual Studio will break.
For dictionaries I imagine that only a few rare cases if at all will serialize/deserialize arbitrary dictionaries with keys of such a size.
Everything else will fit in less than ~50 bytes (decimal/double values).
Anyway, most of the time, a 4k buffer will be plenty enough for one string.
What about arrays?
Handle them higher up in the call chain and not in the Reader/Writer.
What to do?
In my experiments, always using ReadOnlySequence hits the performance quite hard, resizing the buffer only in the string case and simply continue resizing it until everything fits was way better. @davidfowl has some thoughts about actually resizing buffers in ReadOnlySequence over in corefx, if I remember correctly.
For all other cases, consider the buffer as a window and slide it along.
When to do it?
Reading
SkipWhitespace, this method needs to be called before any parsing anyway, can move the window around (e.g. slide it further if the remaining length is < 50 bytes). Rare cases of purely empty buffers might apply here. Can be highly optimized with evil SSE/AVX code.
ReadString: Find the end, if it fails, slide the window to the beginning like above, if that fails again, resize buffer until it fits. Can be highly optimized with evil SSE/AVX code.
Writing
As soon as you need to grow your buffer, just flush the data to the underlying stream and set the offset to 0.
Performance
I enabled the code above only if the expected size of the json (SpanJson tracks the serialized/deserialized size of a type where possible) is above ~65k bytes (32k chars).
Reading
I was able to get within 3-5% of the everything in buffer case with the above method (I'm still not happy with that, because it's technically a  performance regression in SpanJson).
Writing
It beats the classical grow array method even for medium jsons, well below the LOH size, at around 40k bytes.

In my experiments, always using ReadOnlySequence hits the performance quite hard, resizing the buffer only in the string case and simply continue resizing it until everything fits was way better. @davidfowl has some thoughts about actually resizing buffers in ReadOnlySequence over in corefx, if I remember correctly.
For all other cases, consider the buffer as a window and slide it along.

That's definitely the case if you don't use the ReadOnlySequence<byte> as a carrier type. It should only ever be slow when you end up crossing the boundary and depending on the segment size (usually 2K or 4K), that should be rare. The BufferReader's intent was to be that super light stack only abstraction that basically does the "expose a Span at a time" style parsing but it possibly isn't as light as it should be (as this proves).


Portrait Position Overhaul

Putting in draft because I need some more space then tiny airplane table to make a test scene to check it, but letting others review. Also need to take a look at the RPG Mode functions to make sure they are current, which I haven't had the chance to try yet, as well as modify saving/loading for this change.  Also it requires interaction before continuing with the new event, I didn't have the chance to figure out how to make it immediately continue yet.
Re-attaches the portraits to the PortraitHolder CanvasLayer, which was originally intended but lost in the conversion from Godot 3.5 WIP to Godot 4. With those reattached, adds back in Z-Indexing on the portraits.
Additionally, adds a new event type,  DialogicPositionEvent. This event type allows for manipulating the positions themselves. With this, positions can be moved in a timeline, and new positions can be added. Position changes can either be made by relative or absolute position, and can either be immediate or a transition over time. Also it allows resetting all the positions back to their defaults, either from the original scene loaded, or from the initial addition of a position at runtime.
Additionally, adds a linear transition to the character Update as well, for smoothly transitioning a character to a new position. This should run in parallel to an animation, so they both happen as one action.
Other tweaks are creating a faster lookup dictionary for the positions, to simplify changing them, and storing the actual current position on the character node as a metatag for ease of lookup, as well as a new type for the Editor parts to allow larger numbers for the position updates. Also fixes #1120 and #1121.

Haven't tested anything yet, but I guess the positions should also be saved and loaded. I would be okay if we leave that for later, but then we need to make an issue about it.

alright everything seems to be working in tests


CI: The set-output command is deprecated and will be disabled soon

The set-output command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/Show less

Fixed in eb1f66dd7c5d6cdbd58d2f1d37311a182b99701b.


noarch, pypi, template

@conda-forge-admin please rerender

Hi! This is the friendly automated conda-forge-linting service.
I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.
Here's what I've got...
For recipe:

Recipe maintainers should be a json list.


Friend log notifies about non-existent entries

Same issue as #9 still occurring on a fresh install of the latest release.
https://user-images.githubusercontent.com/20784222/127083151-566907ef-fc0f-4e54-8a27-68e76b5aae50.mp4

Re-encoded video to hopefully work since Github didnt like the lat one.
https://user-images.githubusercontent.com/20784222/127083302-c5aef3a6-33a0-4fc3-8b4c-4b3962e5d3b2.mp4

Should be fixed with this https://github.com/Natsumi-sama/VRCX/commit/455d8e70ae885d0ee36379e47dfc708a800c8350


Doc links to code broken

Hey @koudelka!
The code links for a module lead the wrong github addresses. The github link navigates to:
1 (broken link) - https://github.com/koudelka/honeydew/blob/1.4.6/lib/honeydew.ex#L1
instead of
2 (correct link) - https://github.com/koudelka/honeydew/blob/v1.4.6/lib/honeydew.ex#L1
The second link contains v1.4.6 while the broken one uses 1.4.6. Looks like it might be the way the package was published to hex.pm

Hey @savtrip, thanks for the report!
Where exactly are you seeing that happening?

For example https://hexdocs.pm/honeydew/Honeydew.html#content
If you click the code icon in the top right corner it will take you to a github 404 page.


PersistedQueryNotFound on the DropCampaignDetails GQL operation

08:46:27: Fatal error encountered:
08:46:27:
08:46:27: Traceback (most recent call last):
08:46:27:   File "main.py", line 155, in main
08:46:27:   File "twitch.py", line 587, in run
08:46:27:   File "twitch.py", line 637, in _run
08:46:27:   File "twitch.py", line 1468, in fetch_inventory
08:46:27:   File "asyncio\tasks.py", line 571, in _wait_for_one
08:46:27:   File "twitch.py", line 1425, in fetch_campaigns
08:46:27:   File "twitch.py", line 1387, in gql_request
08:46:27: exceptions.GQLException: [{'message': 'PersistedQueryNotFound'}]
08:46:27:
08:46:27: Exiting...
08:46:28:
08:46:28: Application Terminated.
08:46:28: Close the window to exit the application.

Originally posted by @dragongrafdiscord in https://github.com/DevilXD/TwitchDropsMiner/issues/590#issuecomment-2482183055

alright could u write me a message here when there is a new dev build? :D

Still no hash change. This seems different than normal. We'll need to wait some more.
@dragongrafdiscord You can just "watch" this repo to receive updates for it. The "Watch" button is at the top of the repository's main page.

alr will try
hopefully the watch also works when custom for releases bc i dotn wana get notified for every each thing
also currently it seems to be running alr again...

and i still have a bit older dev build but as long as it works its alr for me (unless u add some nice features)

Having the same Issue. I realized, when there is a Campaign for Caliber Live, theres a 99% Guarantee it crashes. without the Game having an active campaign, its more like 70/30 Chance, however, it eventually will always crash.
That being said, when i use a forked Version of the Project that hasnt been updated in a while. It works fine, aside from the Issue that said older Miner doesnt recognize some Games having active Streams.

The hashes have been updated a while ago, so this should no longer be happening: https://github.com/DevilXD/TwitchDropsMiner/commit/2c5f56b33b49552a1784dc1e6320860b1c0a99ad


[GPT-74] Navbar: Mentorship Tab for Mobile

Mentorship does not open in new tab on mobile
From SyncLinear.com | GPT-74

This should ideally be fixed, but unfortunately it would require replacing the Ghost navigation with our own... which might not be a bad idea, but deferring till after beta launch.


Move global to PROD

This one is now done, but will add a new issue for global studio as that needs special treatment.

Global also done!


I can’t get it to work

I am sorry I am very stoopid and I can’t seem like to get this right. Where can I download the image for the path to get it to my project or have it locally downloaded would be best. Again not very smart
I am going to add a little thingy to this thread on my pc cause I am on my phone rn

from google_images_search import GoogleImagesSearch
gis = GoogleImagesSearch('My_Key', 'Search_engine_id')
define search params:
_search_params = {
'q': 'puppy',
'num': 10,
'safe': 'high',
'fileType': 'jpg',
'imgType': 'clipart',
'imgSize': 'HUGE',
'imgDominantColor': 'white',
'usageRights': 'cc_publicdomain'
}
this will only search for images:
gis.search(search_params=_search_params)
for image in gis.results():
image.download('/drive/my-drive') #what do i do here???<------- to like actually get it i am on windows also

I made my search engine google and i tried the program in powershell and it returned no images found i had only my api key and search engine number letter thing as envirormental variables and i was searching for puppies i feel there is no way there wasnt a single image.

nevermind i messed up some settings on my browser thanks so much

sorry i still cant download them automatically i feel so stupid rn
pls help when u can any1

hey @HalpINeedHalp. does it give you a error or anything that could hint to what may be wrong? Please include the current code that you are using and we will go from there

Sorry forgot to close it got something working that is good enough


Advanced simplification

For example:
Pa · m² -> N
J·s -> N

Idea: only apply simplifications that minimize the sum of the absolute value of all unit exponents.

@sharkdp  If I understood your conversation on reddit with doodle77 correctly: How about an explicit, unary simplification operator with a similar operator precedence like parentheses?

@sauer2 Yes, that would also be an option! Instead of the unary operator, I was thinking of something like "convert to SI" or "convert to base" with a syntax similar to the normal conversion operator
<expr> -> SI
<expr> -> base

@sauer2 How about a combination of automatic deduction as well as some sort of user-defined deduction guide?
For example, kgms^(-2) gets converted to N by default, but we can also provide a deduction guide.
Below is the format I was thinking of:
<unit to look for> [explicit] -> <unit to convert to>
kg*m*s^(-2) -> default // resets to automatic conversion
kg*m*s^(-2) -> delete // removes any conversion (same as kg*m*s^(-2) -> kg*m*s^(-2))
N -> kg*m*s^(-2) // converts N and all units equivalent to N to kg*m*s^(-2)
N explicit -> kg*m*s^(-2) // only converts N to kg*m*s^(-2), but not all equivalents.

@nimashoghi Sounds cool, but you probably want to adress @sharkdp .


ndslice.selection: improve coverage

let's improve mir's coverage!

Current coverage is 94.19%

Merging #60 into master will increase coverage by +0.27% as of 4fa61b1

@@            master     #60   diff @@
======================================
  Files            6       6
  Stmts         2173    2189    +16
  Branches         0       0
  Methods          0       0
======================================
+ Hit           2041    2062    +21
  Partial          0       0
+ Missed         132     127     -5

Review entire Coverage Diff as of 4fa61b1

Powered by Codecov. Updated on successful CI builds.

comments addressed - thanks for your input and feedback :)

Thank you for this PRs)

this should be rebased

rebased.


Add better mechanism for observing date, time zone changes

At the moment, the library offers a pretty simple mechanism to do that through BroadcastReceiver. When the view is attached to the screen it's enabled, when detached - disabled. It'd better if the library offers a better way to do it.
Move the logic out of the RangeCalendarView and disable the feature by default, because registering BroadcastReceiver and processing notifications about changes is not cheap. Instead, do it through a manager-like class that will do the following:
a) be Lifecycle-aware, so we won't constantly de/register the BroadcastReceiver when the view is on/off the screen. Anyway, there should be a way not to use Lifecycle, instead, manually un/register the BroadcastReceiver.
b) provide a way to enable/disable the observation of some properties (like observe time zone changes but not date ones)
Meanwhile, the RangeCalendarView should have a public API that would notify the calendar about these changes.

Implemented


adding pm test

combining pre-Fec BER/eSNR and Q-value into pm test.

Pull Request Functional Test Report for #2779 / c2ace5e14ad070ad9192718c411f1c9c891ab29d
Virtual Devices

Device
Test
Test Documentation
Job
Raw Log

Arista cEOS

TRANSCEIVER-6: Telemetry: 400ZR Optics PM (Q, Pre-FEC BER, ESNR) streaming

Cisco 8000E

TRANSCEIVER-6: Telemetry: 400ZR Optics PM (Q, Pre-FEC BER, ESNR) streaming

Cisco XRd

TRANSCEIVER-6: Telemetry: 400ZR Optics PM (Q, Pre-FEC BER, ESNR) streaming

Juniper ncPTX

TRANSCEIVER-6: Telemetry: 400ZR Optics PM (Q, Pre-FEC BER, ESNR) streaming

Nokia SR Linux

TRANSCEIVER-6: Telemetry: 400ZR Optics PM (Q, Pre-FEC BER, ESNR) streaming

Openconfig Lemming

TRANSCEIVER-6: Telemetry: 400ZR Optics PM (Q, Pre-FEC BER, ESNR) streaming

Hardware Devices

Device
Test
Test Documentation
Raw Log

Arista 7808

TRANSCEIVER-6: Telemetry: 400ZR Optics PM (Q, Pre-FEC BER, ESNR) streaming

Cisco 8808

TRANSCEIVER-6: Telemetry: 400ZR Optics PM (Q, Pre-FEC BER, ESNR) streaming

Juniper PTX10008

TRANSCEIVER-6: Telemetry: 400ZR Optics PM (Q, Pre-FEC BER, ESNR) streaming

Nokia 7250 IXR-10e

TRANSCEIVER-6: Telemetry: 400ZR Optics PM (Q, Pre-FEC BER, ESNR) streaming

Help

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 54.484%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
1847

Relevant Lines:
3390

💛  - Coveralls


Could not resolve dependency for React 18.2.0

Trying to use this package with the latest version of React (18.2.0) but cannot successfully run npm install.
package.json
"next-export-i18n": "^2.0.3",
"react": "18.2.0",
"react-dom": "18.2.0",

This is the error output in npm:
npm ERR! Could not resolve dependency:
npm ERR! peer<EMAIL_ADDRESS>from<EMAIL_ADDRESS>
npm ERR! node_modules/next-export-i18n
npm ERR<EMAIL_ADDRESS>from the root project
npm ERR!
npm ERR! Conflicting peer dependency<EMAIL_ADDRESS>npm ERR! node_modules/react
npm ERR!   peer<EMAIL_ADDRESS>from<EMAIL_ADDRESS>npm ERR!   node_modules/next-export-i18n
npm ERR<EMAIL_ADDRESS>from the root project

Looks like this is an issue with the dependencies of the project, but it's completely stopping the ability to run a simple npm install without --force .

Hello @martinkr, any news on this issue ?
I'm stuck...
Many thanks for your help


B 19888 estimate price int

Agility ticket
Summary
When the prime provides an estimated weight, we want to calculate the estimated price and store it on the service item in the pricing_estimate column.
To test:

Run make tasks_save_ghc_fuel_price_data
Create a shipment in the prime sim, and make a note of your requested pickup date and your estimated price.
Approve the shipment as the TOO.
Check the mto_service_items table and verify that prices exist for the initial 6 service items that get created upon TOO approval.
Go back to the prime sim
Update the shipment to have the same actual pickup and actual weight that you put down for the requested pickup and estimated weight.
After updating, create a payment request as the prime sim.
Make sure you use the shipment you created and updated - then add all the service items and submit the payment request.
As the TIO, review the payment request and compare the prices on that page to the values in the database.

A note on the tests - there is quite a bit of test setup data required to have all the inputs for every pricing function. The pricing functions I utilized already have pretty extensive tests written for them, so I don't see a need to retest them in the shipment approver tests.

Warnings

:warning:
This PR does not include changes to unit tests, even though it affects app code.

  Generated by :no_entry_sign: dangerJS against b59bacb8cde655db99bd57604296dac3855ada5d


Added link for Default Shortcuts in Help menu

That's one more approach to the original work of @zaksnet in PR  #39676

Perhaps version information should be fetched and put into the URL instead of stable?

Indeed, as @pycbouh says, we should probably use the major.minor version number to determine the documentation URL. That said, we don't have a 4.0 branch on the documentation repository yet, so we'd have to use latest on versions higher than 3.2 right now.

Changed from stable to latest

Was there a problem with implementing the major.minor scheme though? latest is only useful for those who compile master, for stable versions it is preferable to refer to the documentation related to that version. Someone using 3.2 wouldn't get much help reading the latest shortcut list and can even be confused by it.

Ok, I'll amend that with git version when I get back to PC today. I wasn't just sure which path we should follow on this 👍

The problem with using major.minor is that it won't work for the master branch, as we don't branch off the docs to 4.0 until 4.0 is ready to be released as stable.
So you'd have to parse VERSION_STATUS to see if it's "stable" to decide if you should use VERSION_MAJOR.VERSION_MINOR or point to latest... it's a bit overkill IMO but if you folks think it's important, why not.

I agree, that there is no simple solution here and that proper support for documentation versions feels like an overkill, but I just don't see a point in linking docs for a wrong version. One can argue that there is little chance that there are going to be huge changes to that article, but that cannot be proved.
Honestly, the original PR didn't give any good reason for including this link in the first place. What use-case is solved here? Do we need it even?
PS. On the upside, any solution for version resolution between the engine and the docs can be used for any link to the online documentation within the editor, not just by this link.

My initial feeling is also that I'm not sure why this page in particular should be linked in the editor menu and not several others, which would make the menu bloated.
Default Shortcuts can be found directly by browsing the Editor Settings, so all the information is readily available.
The page in the docs is convenient as an online reference and for search engines, and to give some extra context, but I'm not sure it warrants being in the Help menu.

@dreamsComeTrue Is this still desired? If so, it needs to be rebased and tested on the latest master branch. While there are no conflicts, rebasing is important so that reviewers can easily test the PR.

I don't think this is desired at all, as per discussion.

The online key reference is a bit more readable, but it's not very useful for people that work offline. Also it's not something you need to check really often. Only when you are beginning using Godot.
That said, and given discussion above, this PR needs a proposal.

Given the discussion above, I don't think this should be merged. Thanks for the contribution nonetheless!


AbortCompilationException doesn't include an error message

I had an exception thrown due to a "function redefintion" error, but no error message was reported out the the caller. See diagnostics.cpp:221
Also for the error "function redefinition" it'd be useful to include the function name in the message...
The error was due to missing include guards on a .hlsli file included from two different other include files.

The exception is usually thrown in cases where a code path is unimplemented/unhandled behavior, so the exact message isn’t always meant to be consumable by the user. Still, it would be good to include that but in the output anyway, to help isolate bugs.
In this case of course, the message should have been a real error.

PR #517 should have improved the messages we give when compilation is aborted, and those changes should be live in v0.10.13 and later.


Notifications app on ownCloud is not compatible with Sciencemesh app

Debugging with @Thirsa, we found ot that the notifications app is not compatible with Sciencemesh app and leads to the receiver not seeing the incoming share accept dialog.
1[Mon May 22 16:20:07.768699 2023] [php7:error] [pid 20787] [client <IP_ADDRESS>:40282] PHP Fatal error:  Declaration of OCA\\ScienceMesh\\Notifier\\ScienceMeshNotifier::prepare(OCP\\Notification\\INotification $notification, string $languageCode): OCP\\Notification\\INotification must be compatible with OCP\\Notification\\INotifier::prepare(OCP\\Notification\\INotification $notification, $languageCode) in /var/www/owncloud/apps/sciencemesh/lib/Notifier/ScienceMeshNotifier.php on line 72

https://github.com/pondersource/nc-sciencemesh/blob/6d99bd9ac84b0861d0127e5a91d70ca30c7cd6af/lib/Notifier/ScienceMeshNotifier.php#L72

after disabling notifications, the dialog shows up, but we are stuck with an endless loop of accept share pop ups.

I tried to reproduced the fatal error. It's not showing up.
Some possible reason for this case:
1- upgrade the app
2- recent commits
The issue still presists. checking the files to find out where INotification instance is calling to find the root cause.

Finally, I reproduced the error which is irrelavant to add share federated event:
1- The error is related to notification that sciencemesh tries to send via email
[Wed May 31 22:15:49.838361 2023] [php7:notice] [pid 257] [client <IP_ADDRESS>:49384] PHP Fatal error:  Declaration of OCA\\ScienceMesh\\Notifier\\ScienceMeshNotifier::prepare(OCP\\Notification\\INotification $notification, string $languageCode): OCP\\Notification\\INotification must be compatible with OCP\\Notification\\INotifier::prepare(OCP\\Notification\\INotification $notification, $languageCode) in /var/www/html/apps/sciencemesh/lib/Notifier/ScienceMeshNotifier.php on line 72

step to reproduce it:
1- share a file from oc1/nc1 to oc2
2- add new row in oc_notification table with this query

Trying to fix this first here.
Also there's still conflict between file federated app with notificaion app. Still checking to find the root cause.
Here's report for now:
in this section, it's using different structure to call the file accept popup. In notification app, I couldn't find anything like this. However, in this section it seems the notification fetched but it's always empty. I'm trying to find out where this object filled.

Find this
The notification app prevent to show the modal and notification app will add new row in the ring bell section on the header.
Checking why it's not add the row.

Methods are implemeneted to the StorageController
The links for accept/decline is not still working
find this as accept and this as decline. Still working on it.

As I checked with MohamadReza and Mahdi, It seems the header of curl request is similar to the request that normally we send through app without notification app.

The funny thing is that when we send a curl request to HTTP_ORIGIN as POST it doesn't read the params from Header Request and it reads from Query params!
Also, externalShares endpoint always return 200 if we decline/accept without any information.


create mass deployment

Description:

Create mass deployer package that deploys batch of vms according to a given configurations file

Changes

Add tfrobot package
Add tfrobot to lint, test and build workflows and goreleaser
Fix deployer skipping error problem in batch deploy in deployer
Fix deployer return error on only substrate.ErrAccountNotFound in deployer validation

Related Issues:

#604

Checklist

[x] Tests included
[x] Build pass
[x] Documentation
[x] Code format and docstring

Tested on batch of 100 vms and the deployment time is very good for now

Let's make sure to support mnemonic and network as env variables too please

I think this work is amazing. I am testing tfrobot and it works great!
I find that the confi.yaml example doesn't work on my end. Here's what works:
node_groups:
  - name: group_a
    nodes_count: 3 # amount of nodes to be found
    free_cpu: 2 # number of logical cores
    free_mru: 16384 # amount of memory in MB
    free_ssd: 100 # amount of ssd storage in GB
    free_hdd: 50 # amount of hdd storage in GB
    dedicated: false # are nodes dedicated
    pubip4: false # should the nodes have free ip v4
    pubip6: false # should the nodes have free ip v6
    certified: false # should the nodes be certified(if false the nodes could be certified of diyed)
    region: "europe" # region could be the name of the continents the nodes are located in (africa, americas, antarctic, antarctic ocean, asia, europe, oceania, polar)
vms:
  - name: examplevm
    vms_count: 5 # amount of vms with the same configurations
    node_group: group_a # the name of the predefined group of nodes
    cpu: 1 # number of logical cores
    mem: 256 # amount of memory in MB
    ssd: # list of ssd storage needed to be mounted to the vm
      - size: 5 # size in GB
        mount_point: /mnt/ssd
    pubip4: false
    pubip6: false
    flist: https://hub.grid.tf/tf-official-apps/base:latest.flist
    entry_point: /sbin/zinit init
    root_size: 0 # root size in GB
    ssh_key: example1 # the name of the predefined ssh key
ssh_keys: # map of ssh keys with key=name and value=the actual ssh key
  example1: ssh_key1
mnemonic: example-mnemonic # mnemonic of the user
network: dev # eg: main, test, qa, dev

Basically, there was a - mising in front of size:, and ssh_key: # map... should be ssh_keys: # map... (add an s to get the proper go type from types.go)

@Eslam-Nawara Once again, amazing work.
Do you think it is possible to add commands from tfcmd into tfrobot?
For example, to get contracts, and to delete contracts too.
Ideally, we could delete contracts in blocks.
Otherwise, users will end up using both tools for their deployments (tfrobot for mass deployments, tfcmd to delete and get contracts, for example). Which isn't bad, but it's less interesting in terms of UX.

Remaining work will be in another pr


Ambiguous init

Hey folks,
Trying to extend CGRect to be Decodable but running into an issue where the init is ambiguous.
extension CGRect: Decodable {

    public static func decode(json: JSON) -> Decoded<CGRect> {
        return curry(CGRect.init(x:y:width:height:))
            <^> json <| "x"
            <*> json <| "y"
            <*> json <| "width"
            <*> json <| "height"
    }
}

This produces the following error:
Ambiguous use of 'init(x:y:width:height:)'

I tried specifying the types to remove the ambiguity:
extension CGRect: Decodable {

    public static func decode(json: JSON) -> Decoded<CGRect> {
        return curry(CGRect.init(x:y:width:height:) as (CGFloat, CGFloat, CGFloat, CGFloat) -> ())
            <^> json <| "x"
            <*> json <| "y"
            <*> json <| "width"
            <*> json <| "height"
    }
}

Didn't work though, producing the following error:
Cannot invoke 'curry' with an argument list of type '((CGFloat, CGFloat, CGFloat, CGFloat) -> ())'

Is there something I am missing? 🤔
Cheers!

Figured it out, the return type was wrong!
Here's a working example:
extension CGFloat: Decodable {

    public static func decode(json: JSON) -> Decoded<CGFloat> {
        switch json {
        case let .Number(number):
            return pure(number as CGFloat)
        default:
            return .typeMismatch("CGFloat", actual: json)
        }
    }
}

extension CGRect: Decodable {

    public static func decode(json: JSON) -> Decoded<CGRect> {
        return curry(CGRect.init as (CGFloat, CGFloat, CGFloat, CGFloat) -> CGRect)
            <^> json <| "x"
            <*> json <| "y"
            <*> json <| "width"
            <*> json <| "height"
    }
}


Fix assets 1 5 17

Changes:

Fixes issue with non compiled assets that were added to the fuel gem
Fixes issues with original fuel implementation not allowing slug changes
Fixes issues with editing posts by updating routes to use the proper param

Testing:*
Load up the admin interface and make sure you can create and update posts.
Notes:
Kurt was having issues with the admin interface so I looked into it and found a few issues once it was integrated into schlep.
Trello Links:
https://trello.com/c/SnAXumR3/971-add-asset-precompile-to-fuel-gem-for-new-assets

@claycarpenter updated to original implementation. It was the nulling out of the @post.slug that was breaking it. Also the assets are needed for precompiling.

Looks good, thanks!


Nested node for server and client testing

Move the main function into runTest(). If RELATED_NODES is provided, the script will try to book it, then book LABEL matched node and run test. Otherwise, run test normally on LABEL.
Related: https://github.com/adoptium/aqa-tests/issues/2841
Signed-off-by: lanxia<EMAIL_ADDRESS>

@norbline could you also add a timeout check for waiting for RELATED_NODES? It means make https://github.com/adoptium/aqa-tests/pull/3364/files#diff-ebf20f64c486ae48bd60b965c555076519f9d5623789f4574467d3051bb530f7R171-R177 a function and call it at for LABEL and for RELATED_NODES.
Git clone this change, and you can update this PR directly. Once you are done, please add yourself as co-author. Please see
https://docs.github.com/en/pull-requests/committing-changes-to-your-project/creating-and-editing-commits/creating-a-commit-with-multiple-authors

@norbline please also test the following cases, once you are done:

Regular run without RELATED_NODES
Run with RELATED_NODES, check if both machines are booked
Run two Grinder with same RELATED_NODES and LABEL, check if the second job is waiting for the first job due to RELATED_NODES being busy
Run Machine-Reservation to make a node busy. Run 2nd Grinder with free RELATED_NODES and busy LABEL node. The test should start after the busy LABEL node is free.
Run Machine-Reservation to make a node busy. Run 2nd Grinder with busy RELATED_NODES and free LABEL node. The test should start after the busy RELATED_NODES node is free.
Run Machine-Reservation to make a node busy for > timeout. Run 2nd Grinder with busy RELATED_NODES and free LABEL node. The build should timeout.

Regular run without RELATED_NODES https://ci.adoptopenjdk.net/view/Test_grinder/job/Grinder/3716/

@llxia seems like I can not update this PR. Access denied

@norbline Thanks for testing. Let's merge this PR first, then you can open a new PR for the additional change.


[wil] Installing wil is incredibly slow

Is your feature request related to a problem? Please describe.
-- Using cached Microsoft-wil-v1.0.240803.1.tar.gz.
-- Cleaning sources at D:/d/vcpkg/buildtrees/wil/src/0.240803.1-02f2b37103.clean. Use --editable to skip cleaning for the packages you specify.
-- Extracting source D:/d/vcpkg/downloads/Microsoft-wil-v1.0.240803.1.tar.gz
-- Using source at D:/d/vcpkg/buildtrees/wil/src/0.240803.1-02f2b37103.clean
-- Found external ninja('1.12.1').
-- Configuring x64-windows

Stuck for over half an hour...
Proposed solution
None
Describe alternatives you've considered
No response
Additional context
No response

repro this issue on 2 machines.
Deleting %VCPKG_ROOT%\buildtrees\wil can solve.

Ok, the issue is solved, I will close this issue.


A Python shell that has all configuration loaded into the namespace

Not sure if trivial or useful.  :-)
But here's an example session:
$ pld-shell
Welcome to the palladium shell.  I've loaded your configuration for you,
and here's the variables you have access to:
{'__mode__': 'fit',
 'dataset_loader_test': <palladium.dataset.SQL object at 0x7f745dc19828>,
 'dataset_loader_train': <palladium.dataset.SQL object at 0x7f744c2f9400>,
 'load_data_decorators': [],
 'model': LinearRegression(copy_X=True, fit_intercept=True, n_jobs=1, normalize=True),
 'model_persister': <palladium.persistence.File object at 0x7f744c2f9390>}

>>> model
LinearRegression(copy_X=True, fit_intercept=True, n_jobs=1, normalize=True)

Coverage remained the same at 100.0% when pulling 9d64c321e81e42f873333327614681cf06708ebc on samsungaccelerator:feature-shell-command into 7ad551e9042ad1996d1d21872e2ce4d1b1b89454 on ottogroup:develop.

@dnouri: Is there any particular use case you have in mind? It might be helpful for debugging, but I am not sure if a simple pdb wouldn't do the same. Maybe some options would be nice (e.g., --fit fitting the model after loading the config or --devserver loading a model from the model persister). What do you think?
Can you use the shell history in a simple shell (not in emacs or alike)? I get something like "^[[A" in my default terminal.
docopt(list_cmd.doc, argv=argv) should be docopt(shell_cmd.doc, argv=argv)

@alattner: The use case I had in mind was running a prediction (so I'd still have to call the model_persister) and then plot the predictions against the actual values.
But I'm thinking firing up a Python shell and calling get_config() is easy enough.  But maybe add another issue where we add documentation on how to "load" model and environment in a shell to work with, e.g. in an IPython notebook.  Pretty easy but not obvious how to do it.


Kani does not support fat pointer comparison

RMC crashes on the core Rust test (src/test/ui/raw-fat-ptr.rs).
After minimizing:
trait a {}
fn main() {
  let b : &mut[ *const a] = &mut[];
  b.sort_by(| c, d | c.cmp(d))
}

thread 'rustc' panicked at 'BinaryOperation Expression does not typecheck Equal Expr { value: Symbol { identifier: "_RNvXs0_NtNtCsgWci0eQkB8o_4core3ptr9const_ptrPDNtCs8ZdcvQGSn7l_4test1aEL_NtNtB9_3cmp9PartialEq2eqBK_::1::var_3" }, typ: StructTag("tag-dyn a"), location: None } Expr { value: Symbol { identifier: "_RNvXs0_NtNtCsgWci0eQkB8o_4core3ptr9const_ptrPDNtCs8ZdcvQGSn7l_4test1aEL_NtNtB9_3cmp9PartialEq2eqBK_::1::var_4" }, typ: StructTag("tag-dyn a"), location: None }', compiler/rustc_codegen_llvm/src/gotoc/cbmc/goto_program/expr.rs:863:9
stack backtrace:
   0: rust_begin_unwind
             at ./library/std/src/panicking.rs:517:5
   1: std::panicking::begin_panic_fmt
             at ./library/std/src/panicking.rs:460:5
   2: rustc_codegen_llvm::gotoc::cbmc::goto_program::expr::Expr::binop
             at ./compiler/rustc_codegen_llvm/src/gotoc/cbmc/goto_program/expr.rs:863:9
   3: rustc_codegen_llvm::gotoc::cbmc::goto_program::expr::Expr::eq
             at ./compiler/rustc_codegen_llvm/src/gotoc/cbmc/goto_program/expr.rs:985:9
   4: rustc_codegen_llvm::gotoc::rvalue::<impl rustc_codegen_llvm::gotoc::metadata::GotocCtx>::codegen_comparison
             at ./compiler/rustc_codegen_llvm/src/gotoc/rvalue.rs:24:21
   5: rustc_codegen_llvm::gotoc::rvalue::<impl rustc_codegen_llvm::gotoc::metadata::GotocCtx>::codegen_rvalue_binary_op
             at ./compiler/rustc_codegen_llvm/src/gotoc/rvalue.rs:305:17
   6: rustc_codegen_llvm::gotoc::rvalue::<impl rustc_codegen_llvm::gotoc::metadata::GotocCtx>::codegen_rvalue
             at ./compiler/rustc_codegen_llvm/src/gotoc/rvalue.rs:373:59
   7: rustc_codegen_llvm::gotoc::statement::<impl rustc_codegen_llvm::gotoc::metadata::GotocCtx>::codegen_statement
             at ./compiler/rustc_codegen_llvm/src/gotoc/statement.rs:482:33
   8: rustc_codegen_llvm::gotoc::<impl rustc_codegen_llvm::gotoc::metadata::GotocCtx>::codegen_block
             at ./compiler/rustc_codegen_llvm/src/gotoc/mod.rs:124:32
   9: rustc_codegen_llvm::gotoc::<impl rustc_codegen_llvm::gotoc::metadata::GotocCtx>::codegen_function::{{closure}}
             at ./compiler/rustc_codegen_llvm/src/gotoc/mod.rs:295:71
  10: core::iter::traits::iterator::Iterator::for_each::call::{{closure}}
             at ./library/core/src/iter/traits/iterator.rs:730:29
  11: core::iter::adapters::map::map_fold::{{closure}}
             at ./library/core/src/iter/adapters/map.rs:84:21
  12: <core::iter::adapters::enumerate::Enumerate<I> as core::iter::traits::iterator::Iterator>::fold::enumerate::{{closure}}
             at ./library/core/src/iter/adapters/enumerate.rs:106:27
  13: core::iter::traits::iterator::Iterator::fold
             at ./library/core/src/iter/traits/iterator.rs:2170:21
  14: <core::iter::adapters::enumerate::Enumerate<I> as core::iter::traits::iterator::Iterator>::fold
             at ./library/core/src/iter/adapters/enumerate.rs:112:9
  15: <core::iter::adapters::map::Map<I,F> as core::iter::traits::iterator::Iterator>::fold
             at ./library/core/src/iter/adapters/map.rs:124:9
  16: core::iter::traits::iterator::Iterator::for_each
             at ./library/core/src/iter/traits/iterator.rs:733:9
  17: rustc_codegen_llvm::gotoc::<impl rustc_codegen_llvm::gotoc::metadata::GotocCtx>::codegen_function
             at ./compiler/rustc_codegen_llvm/src/gotoc/mod.rs:295:13
  18: <rustc_codegen_llvm::gotoc::GotocCodegenBackend as rustc_codegen_ssa::traits::backend::CodegenBackend>::codegen_crate::{{closure}}
             at ./compiler/rustc_codegen_llvm/src/gotoc/mod.rs:479:35
  19: rustc_codegen_llvm::gotoc::<impl rustc_codegen_llvm::gotoc::metadata::GotocCtx>::call_with_panic_debug_info::{{closure}}
             at ./compiler/rustc_codegen_llvm/src/gotoc/mod.rs:103:13
  20: std::thread::local::LocalKey<T>::try_with
             at ./library/std/src/thread/local.rs:399:16
  21: std::thread::local::LocalKey<T>::with
             at ./library/std/src/thread/local.rs:375:9
  22: rustc_codegen_llvm::gotoc::<impl rustc_codegen_llvm::gotoc::metadata::GotocCtx>::call_with_panic_debug_info
             at ./compiler/rustc_codegen_llvm/src/gotoc/mod.rs:101:9
  23: <rustc_codegen_llvm::gotoc::GotocCodegenBackend as rustc_codegen_ssa::traits::backend::CodegenBackend>::codegen_crate
             at ./compiler/rustc_codegen_llvm/src/gotoc/mod.rs:478:25
  24: rustc_interface::passes::start_codegen::{{closure}}
             at ./compiler/rustc_interface/src/passes.rs:1056:9
  25: rustc_data_structures::profiling::VerboseTimingGuard::run
             at ./compiler/rustc_data_structures/src/profiling.rs:611:9
  26: rustc_session::utils::<impl rustc_session::session::Session>::time
             at ./compiler/rustc_session/src/utils.rs:16:9
  27: rustc_interface::passes::start_codegen
             at ./compiler/rustc_interface/src/passes.rs:1055:19
  28: rustc_interface::queries::Queries::ongoing_codegen::{{closure}}::{{closure}}
             at ./compiler/rustc_interface/src/queries.rs:254:20
  29: rustc_interface::passes::QueryContext::enter::{{closure}}
             at ./compiler/rustc_interface/src/passes.rs:780:42
  30: rustc_middle::ty::context::tls::enter_context::{{closure}}
             at ./compiler/rustc_middle/src/ty/context.rs:1784:50
  31: rustc_middle::ty::context::tls::set_tlv
             at ./compiler/rustc_middle/src/ty/context.rs:1768:9
  32: rustc_middle::ty::context::tls::enter_context
             at ./compiler/rustc_middle/src/ty/context.rs:1784:9
  33: rustc_interface::passes::QueryContext::enter
             at ./compiler/rustc_interface/src/passes.rs:780:9
  34: rustc_interface::queries::Queries::ongoing_codegen::{{closure}}
             at ./compiler/rustc_interface/src/queries.rs:245:13
  35: rustc_interface::queries::Query<T>::compute
             at ./compiler/rustc_interface/src/queries.rs:38:28
  36: rustc_interface::queries::Queries::ongoing_codegen
             at ./compiler/rustc_interface/src/queries.rs:243:9
  37: rustc_driver::run_compiler::{{closure}}::{{closure}}
             at ./compiler/rustc_driver/src/lib.rs:407:13
  38: rustc_interface::queries::<impl rustc_interface::interface::Compiler>::enter
             at ./compiler/rustc_interface/src/queries.rs:394:19
  39: rustc_driver::run_compiler::{{closure}}
             at ./compiler/rustc_driver/src/lib.rs:312:22
  40: rustc_interface::interface::create_compiler_and_run::{{closure}}
             at ./compiler/rustc_interface/src/interface.rs:209:13
  41: rustc_span::with_source_map
             at ./compiler/rustc_span/src/lib.rs:911:5
  42: rustc_interface::interface::create_compiler_and_run
             at ./compiler/rustc_interface/src/interface.rs:203:5
  43: rustc_interface::interface::run_compiler::{{closure}}
             at ./compiler/rustc_interface/src/interface.rs:225:12
  44: rustc_interface::util::setup_callbacks_and_run_in_thread_pool_with_globals::{{closure}}::{{closure}}
             at ./compiler/rustc_interface/src/util.rs:157:13
  45: scoped_tls::ScopedKey<T>::set
             at /home/ubuntu/.cargo/registry/src/github.com-1ecc6299db9ec823/scoped-tls-1.0.0/src/lib.rs:137:9
  46: rustc_span::create_session_globals_then
             at ./compiler/rustc_span/src/lib.rs:105:5
  47: rustc_interface::util::setup_callbacks_and_run_in_thread_pool_with_globals::{{closure}}
             at ./compiler/rustc_interface/src/util.rs:155:9
  48: rustc_interface::util::scoped_thread::{{closure}}
             at ./compiler/rustc_interface/src/util.rs:130:24
note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.

error: internal compiler error: unexpected panic

note: the compiler unexpectedly panicked. this is a bug.

note: we would appreciate a bug report: https://github.com/rust-lang/rust/issues/new?labels=C-bug%2C+I-ICE%2C+T-compiler&template=ice.md

note: rustc 1.56.0-dev running on x86_64-unknown-linux-gnu

note: compiler flags: -Z codegen-backend=gotoc -Z symbol-mangling-version=v0 -Z symbol_table_passes=

query stack during panic:
end of query stack

[RMC] current codegen item: codegen_function: std::ptr::const_ptr::<impl std::cmp::PartialEq for *const T>::eq

RMC unexpectedly panicked during code generation.

If you are seeing this message, please file an issue here instead of on the Rust compiler: https://github.com/model-checking/rmc/issues/new?labels=bug&template=bug_report.md
warning: 2 warnings emitted

Note to myself: We need to compare the data field and, potentially, the metadata. Need to double check the latter.

https://doc.rust-lang.org/std/ptr/fn.eq.html

Lowering the priority since this has been mitigated.

I'm looking into this issue right now, but it is still not clear to me what the actual semantics of pointer comparison is for Rust. Even for thin pointers it isn't clear.
Interesting enough, the standard library does support Eq and Ord of raw pointers and the compiler behavior is somewhat deterministic (not clear if the LLVM portion is though).  I'll keep digging.
Here are some interesting references:

https://github.com/rust-lang/unsafe-code-guidelines/issues/239
https://github.com/rust-lang/rfcs/pull/1135
https://rust-lang.github.io/rfcs/1135-raw-pointer-comparisons.html

From this discussion in the zulip tlang channel, it seems that pointers with the same provenance, we should be able to do the following:

Compare concrete address for data pointers and thin pointers.

However, the vtable pointer has a few caveats.

It will only have the same provenance if they point to the same vtable.
In theory, vtable may have different addresses even if they represent the same type. That may happen when each pointer is created in a different compilation units (see this issue for more details).

So I propose the following solution.

For now, we add support to fat pointers that represent slice and fail for vtable pointers.
We create an issue to implement vtable pointer comparison but only implement that if there is a real need, since this operation is not stable, users should probably avoid them.
. If we do want to implement vtable comparison, we should use their concrete address and add non-determinism via uninterpreted functions (See http://www.cprover.org/cprover-manual/modeling/nondeterminism/).

We should also defer implementing comparison between pointers with different provenance. This behavior is also not well defined.


Converting scaled_dot_product_attention to DotProductAttention

Hi!
I am testing out TransformerEngine's attention implementation, but I'm not getting numerical parity.
This means I cannot use this layer in my LLM because the weights I'm loading perform worse with it.
Here's the script I'm using:
import math

import torch

B = 1
nh = 8
T = 128
hs = 64

with torch.device("cuda"):
    q = torch.rand(B, nh, T, hs)
    k = torch.rand(B, nh, T, hs)
    v = torch.rand(B, nh, T, hs)
    mask = torch.tril(torch.ones((T, T), dtype=torch.bool)).unsqueeze(0).unsqueeze(0)
scale = 1 / math.sqrt(hs)

y1 = torch.nn.functional.scaled_dot_product_attention(q, k, v, mask, scale=scale, is_causal=False, dropout_p=0.0)

att = (q @ k.transpose(-2, -1)) * scale
att = torch.masked_fill(att, ~mask, torch.finfo(att.dtype).min)
att = torch.nn.functional.softmax(att, dim=-1)
y2 = att @ v  # (B, nh, T, T) x (B, nh, T, hs) -> (B, nh, T, hs)

print(y1.mean(), y2.mean())
torch.testing.assert_close(y1, y2)

from transformer_engine.pytorch import DotProductAttention

att = DotProductAttention(num_attention_heads=nh, kv_channels=hs, attention_dropout=.0, attn_mask_type="padding")
# requires (T, B, nh, hs)
q = q.permute(2, 0, 1, 3)
k = k.permute(2, 0, 1, 3)
v = v.permute(2, 0, 1, 3)
y3 = att(q, k, v, mask)

y1 = y1.permute(3, 0, 1, 2).reshape(T, B, -1)
print(y1.mean(), y3.mean())
torch.testing.assert_close(y1, y3)

Output:
tensor(0.4994, device='cuda:0') tensor(0.4994, device='cuda:0')
tensor(0.4994, device='cuda:0') tensor(0.4993, device='cuda:0')
Traceback (most recent call last):
  File "kk.py", line 38, in <module>
    torch.testing.assert_close(y1, y3)
  File "/home/carlos/venv/lib/python3.8/site-packages/torch/testing/_comparison.py", line 1511, in assert_close
    raise error_metas[0].to_error(msg)
AssertionError: Tensor-likes are not close!

Mismatched elements: 65525 / 65536 (100.0%)
Greatest absolute difference: 0.6001713275909424 at index (86, 0, 256) (up to 1e-05 allowed)
Greatest relative difference: 2020.320556640625 at index (126, 0, 425) (up to 1.3e-06 allowed)

Thanks!

Hi @carmocca , I think you might've missed a couple of things in the script. This should be able to fix it:

import torch

B = 1
nh = 8
T = 128
hs = 64

with torch.device("cuda"):
    q = torch.rand(B, nh, T, hs)
    k = torch.rand(B, nh, T, hs)
    v = torch.rand(B, nh, T, hs)
    mask = torch.tril(torch.ones((T, T), dtype=torch.bool)).unsqueeze(0).unsqueeze(0)
scale = 1 / math.sqrt(hs)

#y1 = torch.nn.functional.scaled_dot_product_attention(q, k, v, mask, scale=scale, is_causal=False, dropout_p=0.0)

att = (q @ k.transpose(-2, -1)) * scale
att = torch.masked_fill(att, ~mask, torch.finfo(att.dtype).min)
att = torch.nn.functional.softmax(att, dim=-1)
y2 = att @ v  # (B, nh, T, T) x (B, nh, T, hs) -> (B, nh, T, hs)

#print(y1.mean(), y2.mean())
#torch.testing.assert_close(y1, y2)

from transformer_engine.pytorch import DotProductAttention

att = DotProductAttention(num_attention_heads=nh, kv_channels=hs, attention_dropout=.0, attn_mask_type="padding")
# requires (T, B, nh, hs)
q = q.permute(2, 0, 1, 3)
k = k.permute(2, 0, 1, 3)
v = v.permute(2, 0, 1, 3)
y3 = att(q, k, v, ~mask)

#y1 = y1.permute(3, 0, 1, 2).reshape(T, B, -1)
y2 = y2.permute(2, 0, 1, 3).reshape(T, B, -1)
print(y2.mean(), y3.mean())
torch.testing.assert_close(y2, y3)

Results:
tensor(0.5008, device='cuda:0') tensor(0.5008, device='cuda:0')

I didn't test y1 but based on your previous test, y1 should be equal to y2.

You are totally right.  Thanks


Replace breakpad-sys with Rust

The original motivation for this repo/crate(s) was to replace our dependency on the significantly heavier combination of sentry-native and sentry-contrib-native with a smaller and simpler way to capture and report native crashes, which it does well as we have been using it for almost half a year now with no issues.
However, any C++ is too much C++, especially when it gets in the way of our development, namely in the case of wanting to compile with musl libc so that can have small static binaries for services running in docker containers that support crash reporting still, but is screwed up due to Breakpad's use of C++.
A significant amount of the Breakpad code is just the usual C++ shenanigans of having custom string functions and guid creation and blah blah, stuff that we don't need in Rust or have excellent crates for, as well as a lot of code dedicated for platforms that we will never care about (wtf still runs Solaris!?) leaving the actual code that needs to be ported to Rust to be quite small, at least relative to the total amount of source in Breakpad.

Linking https://github.com/getsentry/symbolic/issues/375 as this issue also includes minidump generation on the platforms we (currently) care about.

Now that https://github.com/EmbarkStudios/crash-handling exists we can create a pure Rust implementation to integrate crash handling with Sentry and completely get rid of the C++ mess in Breakpad.

In addition, we ideally would just have our own simpler implementation of the sentry sdk that is capable of sending over data to the crash handler process so that things like tags, breadcrumbs, etc are automatically added to crash events, as, unfortunately, this is not really doable with the official sentry sdk itself in a good way.


Using 2 computers - Distributed Tensorflow

Copied from: http://stackoverflow.com/questions/35824742/tensorflow-distributed-assing-devices
I recently installed the version of tensorflow for distributed computers. From the trend: https://github.com/tensorflow/tensorflow/tree/master/tensorflow/core/distributed_runtime , i tried to implemented multiples gpus at multiples computers, and also looking at "https://stackoverflow.com/questions/34439045/tensorflow-setup-for-distributed-computing" found a white paper for some additional specifications. I can run the server and a worker on 2 different computers with 2 and 1 gpu, and using the session gprc, allocate and run the program on remote or local mode. i ran locally tensorflow in the remote computer with:
bazel-bin/tensorflow/core/distributed_runtime/rpc/grpc_tensorflow_server \
--cluster_spec='local|localhost:2500' --job_name=local --task_id=0 &

and for using on the server
bazel-bin/tensorflow/core/distributed_runtime/rpc/grpc_tensorflow_server \
--cluster_spec='worker|<IP_ADDRESS>:2500,prs|<IP_ADDRESS>:2500' --job_name=worker --task_id=0 \
--job_name=prs --task_id=0 &

However, when i try to specify the device for running on 2 computers at the same time the python show me the error:
 Could not satisfy explicit device specification '/job:worker/task:0'
when i use
with tf.device("/job:prs/task:0/device:gpu:0"):
  x = tf.placeholder(tf.float32, [None, 784], name='x-input')
  W = tf.Variable(tf.zeros([784, 10]), name='weights')
with tf.device("/job:prs/task:0/device:gpu:1"):
  b = tf.Variable(tf.zeros([10], name='bias'))
# Use a name scope to organize nodes in the graph visualizer
with tf.device("/job:worker/task:0/device:gpu:0"):
  with tf.name_scope('Wx_b'):
    y = tf.nn.softmax(tf.matmul(x, W) + b)

or even changing the name of job. So I am wondering if it is required to Add a New Device (https://stackoverflow.com/questions/35213172/add-a-new-device-in-tensorflow) or probably i am doing something wrong with the initialization of the cluster.
Best Regards

All servers in the same cluster must be initialized with the same cluster_spec I think. On one computer you might do
bazel-bin/tensorflow/core/distributed_runtime/rpc/grpc_tensorflow_server \
--cluster_spec='worker|<IP_ADDRESS>:2500,prs|<IP_ADDRESS>:2500' --job_name=worker --task_id=0 &

and the other
bazel-bin/tensorflow/core/distributed_runtime/rpc/grpc_tensorflow_server \
--cluster_spec='worker|<IP_ADDRESS>:2500,prs|<IP_ADDRESS>:2500' --job_name=prs --task_id=0 &

@Fhrozen did @sbyma's solution fix your problem?

@sbyma thanks for the help. Yes, it fix my problem. Just wondering two things:
First:
I got that warning in both computers, but even that i can make a distributed training.
Could not find channel for target: /job:prs/replica:0/task:0
Second:
I could not target directly to the gpus using:
with tf.device("/job:worker/task:0/gpu:1"):
Since In the second computer has 2 gpus and tensorflow create the devices with bazel i supposed that i can target directly to the gpu also change the gpu with device:gpu:0 ... 1 or device:0 and could not make run.
Any help. If it is possible send a pm, I will close the thread.
Regards

I have a question. If I have two machine, each of which has 4 GPUs. Can I target tasks directly using: with tf.device("/gpu:0"): to with tf.device("/gpu:7"). Thanks~

I installed tensorflow from source, version 10
bazel-bin/tensorflow/core/distributed_runtime/rpc/ --cluster_spec='local|localhost:2500' --job_name=local --task_id=0 &
 libgrpc_channel.pic.a              libgrpc_remote_master.pic.lo       libgrpc_session.pic.lo             libgrpc_worker_service_impl.pic.a  _objs/
 libgrpc_master_service_impl.pic.a  libgrpc_remote_worker.pic.a        libgrpc_tensor_coding.pic.a        libgrpc_worker_service.pic.a
 libgrpc_master_service.pic.lo      libgrpc_server_lib.pic.lo          libgrpc_worker_cache.pic.a         librpc_rendezvous_mgr.pic.a

I don't have grpc_tensorflow_server in my rpc folder what should I do?


No Native iPad App

I see several of these issues coming up every six months or so. Just wanted to bring it back up :)

bump.

me too. Just allow ipad scrren size and rotation

Dupe of #8909 which as of writing has an open pull request.


[MIPS] support for MIPS_SoftFloat

Allows compiling for MIPS soft-float ABI targets.

They follow the ARM soft float version. For what is worth, druntime unittests are passing.


unable to install pyhelm - error in pygit

Hi,
trying to install pyhelm produces the following issue:
[root@QA-Machine orion]# pipenv install pyhelm
Installing pyhelm?
Looking in indexes: http://aeenexus3:8081/repository/PyPi-All/simple
Collecting pyhelm
Downloading http://aeenexus3:8081/repository/PyPi-All/packages/c1/53/bd8bf05de4cfdf4b7654b1651e697657e0a14fa428bb872f59d5f20aebef/pyhelm-0.0.1.dev39-py2-none-any.whl
Collecting grpcio-tools==1.1.3 (from pyhelm)
Downloading http://aeenexus3:8081/repository/PyPi-All/packages/43/3c/3778dd957253e7f4ff7da02efd9bdf1bfd5f809170245430b8613cc377c3/grpcio_tools-1.1.3-cp27-cp27m-manylinux1_x86_64.whl (19.3MB)
Collecting pygit2>=0.24.2 (from pyhelm)
Downloading http://aeenexus3:8081/repository/PyPi-All/packages/fe/48/f85a605b7337b5562dff902ba1a50d8f22d399e0b623d0c48363dc84fa81/pygit2-0.27.1.tar.gz (477kB)
Collecting protobuf==3.2.0 (from pyhelm)
Downloading http://aeenexus3:8081/repository/PyPi-All/packages/43/16/cdfe80080683b5a76ea489a516bb5859f1550476fdec9b20260987fa42c6/protobuf-3.2.0-py2.py3-none-any.whl (360kB)
Collecting requests==2.14.2 (from pyhelm)
Downloading http://aeenexus3:8081/repository/PyPi-All/packages/e4/b0/286e8a936158e5cc5791d5fa3bc4b1d5a7e1ff4e5b3f3766b63d8e97708a/requests-2.14.2-py2.py3-none-any.whl (560kB)
Collecting supermutes==0.2.5 (from pyhelm)
Collecting PyYAML==3.12 (from pyhelm)
Downloading http://aeenexus3:8081/repository/PyPi-All/packages/4a/85/db5a2df477072b2902b0eb892feb37d88ac635d36245a72a6a69b23b383a/PyYAML-3.12.tar.gz (253kB)
Collecting grpcio==1.1.3 (from pyhelm)
Downloading http://aeenexus3:8081/repository/PyPi-All/packages/ab/ca/ce0784be137d4ac2ca3ba6a8760190d007487f13fd70b1b0a0cab54e39d5/grpcio-1.1.3-cp27-cp27m-manylinux1_x86_64.whl (5.0MB)
Requirement already satisfied: cffi in ./.venv/lib/python2.7/site-packages (from pygit2>=0.24.2->pyhelm) (1.11.5)
Requirement already satisfied: six in ./.venv/lib/python2.7/site-packages (from pygit2>=0.24.2->pyhelm) (1.11.0)
Requirement already satisfied: setuptools in ./.venv/lib/python2.7/site-packages (from protobuf==3.2.0->pyhelm) (40.0.0)
Collecting futures>=2.2.0 (from grpcio==1.1.3->pyhelm)
Downloading http://aeenexus3:8081/repository/PyPi-All/packages/2d/99/b2c4e9d5a30f6471e410a146232b4118e697fa3ffc06d6a65efde84debd0/futures-3.2.0-py2-none-any.whl
Requirement already satisfied: enum34>=1.0.4 in ./.venv/lib/python2.7/site-packages (from grpcio==1.1.3->pyhelm) (1.1.6)
Requirement already satisfied: pycparser in ./.venv/lib/python2.7/site-packages (from cffi->pygit2>=0.24.2->pyhelm) (2.18)
Building wheels for collected packages: pygit2, PyYAML
Running setup.py bdist_wheel for pygit2: started
Running setup.py bdist_wheel for pygit2: finished with status 'error'
Running setup.py clean for pygit2
Running setup.py bdist_wheel for PyYAML: started
Running setup.py bdist_wheel for PyYAML: finished with status 'done'
Stored in directory: /root/.cache/pip/wheels/77/46/55/9c2501fdc1914400fbda88b72293ca0822364f9f1a9e313c38
Successfully built PyYAML
Failed to build pygit2
Installing collected packages: futures, protobuf, grpcio, grpcio-tools, pygit2, requests, supermutes, PyYAML, pyhelm
Running setup.py install for pygit2: started
Running setup.py install for pygit2: finished with status 'error'
Error:  An error occurred while installing pyhelm!
Failed building wheel for pygit2
Command "/root/PycharmProjects/orion/.venv/bin/python2.7 -u -c "import setuptools, tokenize;file='/tmp/pip-install-84J42Y/pygit2/setup.py';f=getattr(tokenize, 'open', open)(file);code=f.read().replace('\r\n', '\n');f.close();exec(compile(code, file, 'exec'))" install --record /tmp/pip-record-zzCLTo/install-record.txt --single-version-externally-managed --compile --install-headers /root/PycharmProjects/orion/.venv/include/site/python2.7/pygit2" failed with error code 1 in /tmp/pip-install-84J42Y/pygit2/
[root@QA-Machine orion]# pipenv install pyhelm
Installing pyhelm?
Looking in indexes: http://aeenexus3:8081/repository/PyPi-All/simple
Collecting pyhelm
Downloading http://aeenexus3:8081/repository/PyPi-All/packages/c1/53/bd8bf05de4cfdf4b7654b1651e697657e0a14fa428bb872f59d5f20aebef/pyhelm-0.0.1.dev39-py2-none-any.whl
Requirement already satisfied: grpcio-tools==1.1.3 in ./.venv/lib/python2.7/site-packages (from pyhelm) (1.1.3)
Collecting pygit2>=0.24.2 (from pyhelm)
Downloading http://aeenexus3:8081/repository/PyPi-All/packages/fe/48/f85a605b7337b5562dff902ba1a50d8f22d399e0b623d0c48363dc84fa81/pygit2-0.27.1.tar.gz (477kB)
Requirement already satisfied: protobuf==3.2.0 in ./.venv/lib/python2.7/site-packages (from pyhelm) (3.2.0)
Collecting requests==2.14.2 (from pyhelm)
Downloading http://aeenexus3:8081/repository/PyPi-All/packages/e4/b0/286e8a936158e5cc5791d5fa3bc4b1d5a7e1ff4e5b3f3766b63d8e97708a/requests-2.14.2-py2.py3-none-any.whl (560kB)
Collecting supermutes==0.2.5 (from pyhelm)
Collecting PyYAML==3.12 (from pyhelm)
Requirement already satisfied: grpcio==1.1.3 in ./.venv/lib/python2.7/site-packages (from pyhelm) (1.1.3)
Requirement already satisfied: cffi in ./.venv/lib/python2.7/site-packages (from pygit2>=0.24.2->pyhelm) (1.11.5)
Requirement already satisfied: six in ./.venv/lib/python2.7/site-packages (from pygit2>=0.24.2->pyhelm) (1.11.0)
Requirement already satisfied: setuptools in ./.venv/lib/python2.7/site-packages (from protobuf==3.2.0->pyhelm) (40.0.0)
Requirement already satisfied: futures>=2.2.0 in ./.venv/lib/python2.7/site-packages (from grpcio==1.1.3->pyhelm) (3.2.0)
Requirement already satisfied: enum34>=1.0.4 in ./.venv/lib/python2.7/site-packages (from grpcio==1.1.3->pyhelm) (1.1.6)
Requirement already satisfied: pycparser in ./.venv/lib/python2.7/site-packages (from cffi->pygit2>=0.24.2->pyhelm) (2.18)
Building wheels for collected packages: pygit2
Running setup.py bdist_wheel for pygit2: started
Running setup.py bdist_wheel for pygit2: finished with status 'error'
Running setup.py clean for pygit2
Failed to build pygit2
Installing collected packages: pygit2, requests, supermutes, PyYAML, pyhelm
Running setup.py install for pygit2: started
Running setup.py install for pygit2: finished with status 'error'
Error:  An error occurred while installing pyhelm!
Failed building wheel for pygit2
Command "/root/PycharmProjects/orion/.venv/bin/python2.7 -u -c "import setuptools, tokenize;file='/tmp/pip-install-DB_5PQ/pygit2/setup.py';f=getattr(tokenize, 'open', open)(file);code=f.read().replace('\r\n', '\n');f.close();exec(compile(code, file, 'exec'))" install --record /tmp/pip-record-wmTDT9/install-record.txt --single-version-externally-managed --compile --install-headers /root/PycharmProjects/orion/.venv/include/site/python2.7/pygit2" failed with error code 1 in /tmp/pip-install-DB_5PQ/pygit2/

What version of pyhelm are you trying to install? From your logs, it seems your trying to install it from a private pypi instance.
The latest pyhelm version doesn't depend on pygit2.

The version on pypi (0.0.2) is from November 13th, which as I verified, does not depend on pygit2.
The commits merged in afterwards are not part of a released version, yet. Are you missing any of them specifically?

Anyhow, I've uploaded version 0.0.3 to pypi. You're welcome to give it a try.

the issue is related to the way you are building your requirements.
bumping the versions will aid with it.
for example, pyyaml uses it pygit

pyyaml does not use pygit2. You're being vague - what are you suggesting here?
The output snippet you've attached here is obviously not up to date. Do you have a relevant output of an up-to-date version of pyhelm you're having trouble with?


Edit|Reset account password

Hi guy who reading this.
I got some problems with passwords, and i wanna Edit|Reset pass of player
How i can do it? Because /unregister  don't work
So i need help

Hi, @meshoksnega
Have you tried to use nlogin unregister <player> instead? (if you are using nLogin)

Let me try

Still have problem

I got Nlogin on my server

So @nickuc what i can do?

Hi, @meshoksnega
Try running on the console instead again.
nlogin unregister <player>

Trying so much times but it don't work
@nickuc

What appears if you just run nlogin in the console?

Idk how but it typing this

But i got all files with Nlogin

But when i typing this on server it works

Are you using some kind of proxy server? (Velocity, BungeeCord, Waterfall)

If yes, run this command on the proxy server instead.
If not, try removing the other plugins and leaving only nLogin installed and restarting the server.

Oh yes i'm using proxy😂
Bungeecord and in bungee console it work, thx so much


BUG:  list_contents.sh not writing file

Running list_content.sh in Android Studio gets weird error message.
Besides, we really want to run it on the emulated device, if necessary in an apk.

See how to remove special characters:
You can use tr to print only the printable characters from a string like below. Just use the below command on your input file.
tr -cd "[:print:]\n" < file1
The flag -d is meant to the delete the character sets defined in the arguments on the input stream, and -c is for complementing those (invert what's provided). So without -c the command would delete all printable characters from the input stream and using it complements it by removing the non-printable characters. We also keep the newline character \n to preserve the line endings in the input file. Removing it would just produce the final output in one big line.

Fixed


ish

sry johann, i dont know why but my keyboard just did some stranged things and created an issue independently!? i can't delete it, while i am not the owner of this repo. i am going to close this. awkward :(

Chill, all good. Haven't had the time yet to respond to your issues by the way. 😉


[auth-swift] OAuthProvider and OAuthCredential

Finish migrating OAuthProvider and OAuthCredential to Swift, including unit tests.
Some notes:

Unlike other providers, OAuthCredential has its own file because it is part of public API
Two non-public properties were added to the Auth class to help migrate the unit tests from mock-based testing
The ten OAuth flow tests were consolidated to a single function, with flags to control the different test behavior and checks

Going to merge it here. I'll address any comments in a subsequent PR.

And rebased the auth-swift branch with master after merging.


fix(postDetails,GraphQl-operations) : Inconsistency in GraphQL Query for Author Data

This PR Closes Issue
closes #
Description
I have made the necessary adjustments to correct the GraphQL query that retrieves author data from Hashnode's API. The changes are as follows:
-  In graphql.operations.ts: Added username and id to the queries that contain author.
-  In posts.ts : Added username and included id and username properties in the Author interface.
-  In post-details: Changed post.author.name to post.author.username.
What type of PR is this? (check all applicable)

[ ] 🅰 Feature
[ ] 🐛 Bug Fix
[ ] 📝 Documentation Update
[ ] 🎨 Style
[ ] 🧑💻 Code Refactor
[ ] 🔥 Performance Improvements
[ ] ✅ Test
[ ] 🤖 Build
[ ] 🔁 CI
[ ] 📦 Chore (Release)
[ ] ⏩ Revert

Mobile & Desktop Screenshots/Recordings
[Attach screenshots or recordings if applicable]
Steps to QA
Added to documentation?

[ ] 📜 README.md
[ ] 🙅 no documentation needed

[Optional] Post-deployment tasks
[Specify any post-deployment tasks that need to be performed]
[Optional] What gif best describes this PR or how it makes you feel?
[Embed gif or describe the feeling in plain text]

@cleancodecraft , Hello ! what do you think about the commit & pull request titles , should I adjust something ? thank you !


Added a new argument called key-properties

Fixes #5

Thanks for your contribution! I have a few comments.

Almost! Thanks for being patient.

Thanks again!