Remove man_made=courtyard from iD presets

While maybe man_made=courtyard has some uses, making it searchable in iD is causing problems

makes harder to discover how to create multipolygons (as mapper is likely to think that they solved problem how to map courtyards and used it instead of using multipolygon)
it is widely used by iD mappers for every single area inside buildings (and next to buildings), and promoting it use for every single inner area of multipolygon is a bad idea
it is typical to see it used in way mismatching supposed definition or what "courtyard" means
this tag is not needed, maybe except some extreme cases

See https://wiki.openstreetmap.org/wiki/Talk:Tag:man_made%3Dcourtyard
https://www.openstreetmap.org/way/850749107#map=19/25.46775/80.98729&layers=N

Ideally searching "courtyard" would show not a preset but quick info how to create multipolygon in iD as a top match (mini tutorial taking space as one of presents in preset search)

Ideally searching "courtyard" would show not a preset but quick info how to create multipolygon in iD as a top match (mini tutorial taking space as one of presents in preset search)

I really like the idea! I've created https://github.com/openstreetmap/iD/issues/8904 for it.

Though in meantime removing man_made=courtyard from preset would be an improvement in itself anyway.
Current use encouraged by iD is making map data worse, not better.

We could keep as a non-searchable preset, right?

My position is that OSM would benefit from elimination of that tag and supporting it is not helpful.
This may mismatch consensus, but https://wiki.openstreetmap.org/wiki/Talk:Tag:man_made%3Dcourtyard has no response and I have not seen any case where man_made=courtyard improved data and could not be replaced by superior tagging. And even if small amount of such uses exists, vast majority of uses and overall use is not helpful.

We could keep as a non-searchable preset, right?

That's how I ended up implementing it for now. (in the above linked commit I forgot to add the non-searchable preset, see d5fddc1db27693212d7a73e79ba0bb4d953b79a1).
Hmm, I guess dropping it could also be a good option. :thinking: The tag has 20k usages, though. And I did find some valid use cases, like for named courtyards, like this ones: https://www.openstreetmap.org/way/834022036, https://www.openstreetmap.org/way/624420818 or https://www.openstreetmap.org/way/85081255

The tag has 20k usages, though.

Vast majority as result of including it in iD.
https://www.openstreetmap.org/way/85081255 - here mapping as a pedestrian square and inner of building was sufficient, man_made=courtyard adds nothing
https://www.openstreetmap.org/way/834022036 - here courtyard is of a different shape (inner of a building) - I opened https://www.openstreetmap.org/note/3024641
https://www.openstreetmap.org/way/624420818 - nothing is really added by man_made=courtyard

If we’re sure that an explicit courtyard tag is meaningless and the confusion above is commonplace, maybe there should be a validator warning that can automatically turn the courtyard area into an inner member of a multipolygon relation. After all, the trick for merging an area with a closed way to form a multipolygon is not especially well-known, especially among JOSM users who’ve come to expect a less elegant process.

This tag isn't meaningless and I strongly disagree with Mateusz on this (see the Wiki discussion) - so please don't consider there being a consensus on this.
The validator idea (setting the man_made=courtyard as the inner relation) is a nice one. However, courtyards may sometimes be the enclosed space of several buildings. Therefore it is not always the inner relation of a multipolygon relation (unless you join several buildings into one relation - which doesn't seem correct).
There is nothing wrong with using a tag to describe a feature with more specificity. That's what tagging is all about. Remember, not all inner relations are, by default, courtyards.


fix(price-feeder): Parse multiple candles from OsmosisV2 response

Description

Fixes only old candle prices in the price-feeder for the OsmosisV2 API

closes: #87

Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...

[ ] included the correct type prefix in the PR title
[ ] added ! to the type prefix if API or client breaking change
[ ] added appropriate labels to the PR
[ ] targeted the correct branch (see PR Targeting)
[ ] provided a link to the relevant issue or specification
[ ] added a changelog entry to CHANGELOG.md
[ ] included comments for documenting Go code
[ ] updated the relevant documentation or specification
[ ] reviewed "Files changed" and left comments if necessary
[ ] confirmed all CI checks have passed

Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...

[ ] confirmed the correct type prefix in the PR title
[ ] confirmed all author checklist items have been addressed
[ ] reviewed state machine logic
[ ] reviewed API design and naming
[ ] reviewed documentation is accurate
[ ] reviewed tests and test coverage
[ ] manually tested (if applicable)

also @zarazan please remember to put in a backport label for api-compatible price-feeder fixes 🙏

Codecov Report

Merging #1615 (ee02716) into main (3650653) will decrease coverage by 0.40%.
The diff coverage is 26.73%.

@@            Coverage Diff             @@
##             main    #1615      +/-   ##
==========================================
- Coverage   55.47%   55.07%   -0.41%
==========================================
  Files          68       68
  Lines        6725     6825     +100
==========================================
+ Hits         3731     3759      +28
- Misses       2717     2785      +68
- Partials      277      281       +4

Impacted Files
Coverage Δ

x/oracle/types/keys.go
92.59% <ø> (ø)

x/oracle/types/msgs.go
87.36% <0.00%> (-2.85%)
:arrow_down:

x/oracle/types/query.pb.gw.go
0.00% <0.00%> (ø)

x/oracle/keeper/grpc_query.go
91.84% <69.23%> (-4.73%)
:arrow_down:


[BugBash][CLI]better report error if PrivateEndpoint connection specified while updating network rule

Is your feature request related to a problem? Please describe.
better report error if PrivateEndpoint connection specified while updating network rule.
Describe the solution you'd like
Try command az webpubsub network-rule update -g jw1111 -n jw2222 --connection-name --allow ClientConnection  Trace. Notify that the --connection-name is empty. So nothing gets updated. Suggest show a friendly warning message that a connection is required.
Additional context
Add any other context or screenshots about the feature request here.

https://github.com/Azure/azure-cli-extensions/pull/4049


The unknown token in the vocabulary of finetuned checkpoint breaks the prediction at inference time

When I fine-tune a llama3 model and save a checkpoint, it also saves a vocab.json file which is slightly different from vocab.json  of the base model because it contains the unknown token as the first token. It completely breaks the predictions at inference time, even at the step 0 of the finetuning. I manually replaced the merged model's vocab.json file with that of the main model and it fixed the problem.

yes there is an issue here: https://github.com/eole-nlp/eole/blob/main/eole/bin/convert/convert_HF.py#L203
this specials table is for llama2.
we need to make it different between llama2 and llama3

In fact you should not have the issue if you do not have a "tokenizer.model" file in the folder.
if there is NOT such a file then convert_HF will leverage the tokenizer.json and will not add these specials.
please check your folder and try again.

In which folder ?. The vocab.json of the checkpoint obtained with convert HF does not contain the unknown token, the vocab.json of the finetuned model does.

sorry in the case of llama3 I think you need to put in the config
default_specials=[]
because of this: https://github.com/eole-nlp/eole/blob/main/eole/config/data.py#L29

We have the mapping for eos, bos and pad tokens in convert_HF.py
https://github.com/eole-nlp/eole/blob/c74e495d9bf55f5c7b2b2968097c5c1e813a4d5c/eole/bin/convert/convert_HF.py#L892-L909
but what about the unknow token ? If I put default_tokens: []in the training config, the model wil be trained without the unknown token, right ? However the data could contain "new' symbols or emojis for instance.

If we want to handle unknown tokens without changing the vocabulary, shouldn't we use a "reserved token" ?

When the vocabulary does not contain the unknown token, unknown tokens are mapped to the first token.
https://github.com/eole-nlp/eole/blob/c74e495d9bf55f5c7b2b2968097c5c1e813a4d5c/eole/inputters/inputter.py#L51
For llama3 in corresponds to '!' which is not so bad. Unknown token are supposed to be rare, so we can put default_specials: [] in the training config, to prevent inserting new token at the beginning of the vocabulary.
However, using something else than default_specials: [] with pretrained models will always  create an offset in the vocabulary ids.
We should probably avoid doing this when fine-tuning with train_from without updating the vocabulary.

#63 should fix the issue that you have to set default_specials=[]


timers start stop

thats' not really a issue, but I have seen that you made your own implementation of the timers, and I see you cant start a timer with "self.timers.reg_event_timer" but I haven't found a simple solution to stop them, did I missed it? I have made a small patch, if you interested I can submit the pull request
https://github.com/zezadas/spock/commit/a59f048a0f0360782a529dbc78b8bed6215cb476
and then you can make something like
#start
t=self.timers.reg_event_timer(0.05, self.derp)
#stop
self.timers.timers.remove(self.timers.timers[t])

that was just a test, maybe we can create a structure that references a specific timer and the number on the list... I will think in a solution...

You schedule a timer for the number of runs you want it to go for. The correct way to implement a conditional timer is as such
timers.reg_event_timer(0.05, my_stupid_callback, 1)

def my_stupid_callback():
  #Do work
  if my_stupid_condition:
    timers.reg_event_timer(0.05, my_stupid_callback, 1)

I won't close this or mark it invalid but I do think this is a non-issue. Thoughts?

yes, it was just a feature I thought it was interesting.
In that solution you gone have a lot of timers, since the father timer will only be destroyed when the son as terminated

No, the first firing timer isn't a parent of the new event timer or anything like that. It will be cleaned out of the timer list when the next event tick rolls around. You would need (tens of?) thousands of timers for CPython to bat an eyelash at https://github.com/SpockBotMC/SpockBot/blob/master/spock/plugins/core/timer.py#L120-L127
Which isn't a use case that Spock realistically supports anyway

OK, thanks, I'm used to C, so this kind of things(recursions and concurrency) are not like I would code.

I don't like the fact that I had to implement my own timers, but Python sorely lacks anything for this use case really. As it is these are good enough because they place nicely with asynchronous sockets, our custom event loop, and most other event loops out there. We're always open to suggestions and improvements, but as things stand I like the current timers idioms. Closing


review SPR/YPR profile

A user noted that SPR/YPR profile was incomplete for a particular model and noted that it was not produced if the Hessian was NPD.
It is not produced for NPD Hessian because it is only produced after the Hessian step.  This is because it forces changes to selectivity so could interfere with gradients.  But global MSY calculations make similar changes and it is allowed to happen before the Hessian.  This situation needs review.
Also should review the code used to calculate the biology and selectivity for the profile. It should be same as the logic used to create biology and selectivity for the benchmark

I think this may be a relic issue that needs no action, but please check r4ss

Yes, this is no longer a problem, due to a change in ADMB (see https://github.com/admb-project/admb/issues/164).


Improve version.h.in processing in CMake

Search before asking

[X] I had searched in the issues and found no similar issues.

Motivation
Now the generated version.h by CMake is not comsistent with the previous Makefiles.
The version is now set in CMakeLists.txt#L20, we can remove it and read version in the Changelog file, so we do not need to change CMakeLists while a new version is released.
Solution
No response
Are you willing to submit a PR?

[X] I'm willing to submit a PR!

+1


Wrong parameter name for python_instance_main.py when using the TLS

In case of python function, the operator generates parameters for the python_instance_main.py. One of the arguments that the script takes is --tls_allow_insecure_connection, however operator generates --tls_allow_insecure instead, which prevents the python function from starting up.

the argparse of python allow abbrev by default, see: https://docs.python.org/3/library/argparse.html#allow-abbrev
so --tls_allow_inscure will be passed to --tls_allow_insecure_connection, we can even pass the --tls_allow to the python_instance_main.py

You are right with this abbrev. I finally found what is wrong:
Initially I was missing the tlsAllowInsecureConnection environment variable, which caused the issue in the execution of python_instance_main.py. The option --tls_allow_insecure expects also a value there.
However once the tlsAllowInsecureConnection environment variable was defined, it caused a problem one step before i.e. in execution of pulsar-admin --tls-allow-insecure $tlsAllowInsecureConnection
pulsar-admin doesn't expect the value after --tls-allow-insecure there. e.g.
./pulsar-admin --tls-allow-insecure false topics list public/default
Was passed main parameter 'false' but no main parameter was defined in your arg class

The same counts for --tls-enable-hostname-verification option. What needs to be done is to omit passing of $tlsAllowInsecureConnection and $tlsHostnameVerificationEnable values in the pulsar-admin call.

@rhollosy thanks for addressing!
it's a known issue: https://github.com/streamnative/function-mesh/issues/388, and it's already resolved by #414
could you try with FM v0.4.0, and use tlsConfig instead of tlsSecret to set tls related parameters? like below:
  pulsar:
    pulsarConfig: "YOUR-PULSAR-CONFIGMAP"
    tlsConfig:
      enabled: true
      allowInsecure: false
      hostnameVerification: true
      # certSecretName: the name of YOUR-TLS-TRUST-CERT-SECRET if you want to pass the `--tls-trust-cert-path`
      # certSecretKey: the key of your YOUR-TLS-TRUST-CERT-SECRET-NAME

we will update the related doc ASAP

@jiangpengcheng  thank you very much for the guidance. I upgraded to FM v0.4.0 like you suggested and reconfigured the Function. However it still didn't solve the issue. I noticed, that the generated command is different, now it contains this fragment:
--tls-allow-insecure ${tlsAllowInsecureConnection:-false} --tls-enable-hostname-verification ${tlsHostnameVerificationEnable:-true}

which means that the value of the environment variable or false is injected. I believe the values shouldn't be there, like I showed in the previous comment. Obviously I'm getting the same error.

did you still use the tlsSecret under the .spec.pulsar section?

sure I didn't. But you are right that it is related to this part of the configuration. Maybe there is something wrong with my FM installation or it is a different issue:
I prepared a YAML file:
spec:
  pulsar:
    authSecret: client-auth-secret
    pulsarConfig: prod01-pulsar-config
    tlsConfig:
      enabled: true
      allowInsecure: false
      hostnameVerification: true
      caSecretName: prod01-pulsar-ca-tls
      caSecretKey: ca.crt

then I applied it with oc apply -f tls-new-func.yaml, seemingly succesfuly.
When I looked back at the live configuration, the whole tlsConfig block was missing and only the authSecret and pulsarConfig items remained. I tried both creating the function from scratch and updating the existing function.
The operator is raising an error:
2022-08-02T07:41:08.322Z	ERROR	controllers.Function	error create or update statefulSet workload	{"namespace": "function-mesh-system", "name": "tls-new-func-function", "error": "Operation cannot be fulfilled on statefulsets.apps "tls-new-func-function": the object has been modified; please apply your changes to the latest version and try again"}
github.com/go-logr/zapr.(*zapLogger).Error
github.com/go-logr/zapr@v0.1.0/zapr.go:128
github.com/streamnative/function-mesh/controllers.(*FunctionReconciler).ApplyFunctionStatefulSet
github.com/streamnative/function-mesh/controllers/function.go:94
github.com/streamnative/function-mesh/controllers.(*FunctionReconciler).Reconcile
github.com/streamnative/function-mesh/controllers/function_controller.go:94
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).reconcileHandler
sigs.k8s.io/controller-runtime@v0.6.2/pkg/internal/controller/controller.go:235
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem
sigs.k8s.io/controller-runtime@v0.6.2/pkg/internal/controller/controller.go:209
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).worker
sigs.k8s.io/controller-runtime@v0.6.2/pkg/internal/controller/controller.go:188
k8s.io/apimachinery/pkg/util/wait.BackoffUntil.func1
k8s.io/apimachinery@v0.18.6/pkg/util/wait/wait.go:155
k8s.io/apimachinery/pkg/util/wait.BackoffUntil
k8s.io/apimachinery@v0.18.6/pkg/util/wait/wait.go:156
k8s.io/apimachinery/pkg/util/wait.JitterUntil
k8s.io/apimachinery@v0.18.6/pkg/util/wait/wait.go:133
k8s.io/apimachinery/pkg/util/wait.Until
k8s.io/apimachinery@v0.18.6/pkg/util/wait/wait.go:90
I'll keep trying. Thank you.

Sure I'm not using the tlsSecret anymore. But I found out that something is wrong on my side and I don't wanna misguide you. This is the excerpt of my spec.
spec:
  pulsar:
    authSecret: client-auth-secret
    pulsarConfig: prod01-pulsar-config
    tlsConfig:
      enabled: true
      allowInsecure: false
      hostnameVerification: true
      certSecretName: prod01-pulsar-ca-tls
      certSecretKey: ca.crt

I prepared the pristine yaml file and applied it with oc apply, seemingly everything was OK. Then I noticed operator raising errors. When I looked back at the live configuration, the whole tlsConfig block was missing. The operator produced this error log:
 2022-08-02T07:41:08.322Z	ERROR	controllers.Function	error create or update statefulSet workload	{"namespace": "function-mesh-system", "name": "tls-new-func-function", "error": "Operation cannot be fulfilled on statefulsets.apps \"tls-new-func-function\": the object has been modified; please apply your changes to the latest version and try again"}
github.com/go-logr/zapr.(*zapLogger).Error
	github.com/go-logr/zapr@v0.1.0/zapr.go:128
github.com/streamnative/function-mesh/controllers.(*FunctionReconciler).ApplyFunctionStatefulSet
	github.com/streamnative/function-mesh/controllers/function.go:94
github.com/streamnative/function-mesh/controllers.(*FunctionReconciler).Reconcile
	github.com/streamnative/function-mesh/controllers/function_controller.go:94
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).reconcileHandler
	sigs.k8s.io/controller-runtime@v0.6.2/pkg/internal/controller/controller.go:235
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem
	sigs.k8s.io/controller-runtime@v0.6.2/pkg/internal/controller/controller.go:209
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).worker
	sigs.k8s.io/controller-runtime@v0.6.2/pkg/internal/controller/controller.go:188
k8s.io/apimachinery/pkg/util/wait.BackoffUntil.func1
	k8s.io/apimachinery@v0.18.6/pkg/util/wait/wait.go:155
k8s.io/apimachinery/pkg/util/wait.BackoffUntil
	k8s.io/apimachinery@v0.18.6/pkg/util/wait/wait.go:156
k8s.io/apimachinery/pkg/util/wait.JitterUntil
	k8s.io/apimachinery@v0.18.6/pkg/util/wait/wait.go:133
k8s.io/apimachinery/pkg/util/wait.Until
	k8s.io/apimachinery@v0.18.6/pkg/util/wait/wait.go:90

I tried creating the function from scratch as well as updating an existing function.
I'll keep searching for an root cause. Thank you.

do you mean the kubectl get function tls-new-func-function -o yaml still using the tlsSecret config instead of the tlsConfig after you apply the new YAML? that looks strange, it's k8s' job to update the function.
and about the Operation cannot be fulfilled on statefulsets.apps error, I have faced it sometimes too, but it looks like doesn't cause any failures(anyway, this error should be fixed)

@rhollosy
could you please provide your YAML file after erasing sensitive info? I can try it in my local env

No, the oc get just gives me the configuration without the tlsConfig block. So it looks like this:
  pulsar:
    authSecret: client-auth-secret
    pulsarConfig: prod01-pulsar-config

This is the redacted spec:
apiVersion: compute.functionmesh.io/v1alpha1
kind: Function
metadata:
  name: tls-new-func
  namespace: function-mesh-system
spec:
  autoAck: true
  className: ExclamationFunction.ExclamationFunction
  clusterName: prod01
  forwardSourceMessageProperty: true
  input:
    topics:
    - persistent://public/default/pyinstance3
    typeClassName: '[B'
  logTopic: persistent://public/default/py-function-logs
  maxPendingAsyncRequests: 1000
  maxReplicas: 1
  name: tls-function-simple
  namespace: default
  output:
    topic: persistent://public/default/pyinstance4
    typeClassName: '[B'
  pod:
    serviceAccountName: function-worker
    volumes:
    - name: token-volume
      secret:
        items:
        - key: TOKEN
          path: token
        optional: false
        secretName: SOME_TOKEN_SECRET
  processingGuarantee: atleast_once
  pulsar:
    authSecret: client-auth-secret
    pulsarConfig: prod01-pulsar-config
    tlsConfig:
      enabled: true
      allowInsecure: false
      hostnameVerification: true
      certSecretName: prod01-pulsar-ca-tls
      certSecretKey: ca.crt
  python:
    py: ExclamationFunction.zip
    pyLocation: SOME_LINK
  replicas: 1
  resources:
    limits:
      cpu: 200m
      memory: 1100M
    requests:
      cpu: 100m
      memory: 1G
  secretsMap:
    OTEL_EXPORTER_JAEGER_AGENT_HOST:
      key: JAEGER_AGENT_HOSTNAME
      path: func-env-secret
    OTEL_EXPORTER_JAEGER_AGENT_PORT:
      key: JAEGER_AGENT_PORT
      path: func-env-secret
  tenant: public
  volumeMounts:
  - mountPath: /var/run/secrets/pulsar/auth-token
    name: token-volume

@jiangpengcheng please consider this closed. I found out that the automated argocd deployment didn't update the CRDs, so I have to fix that first. thank you for your support. I believe after fixing this issue, everything will work just fine.


Example in converters to show x:Bind to an ItemSource control

with two way compiled binding on SelectedItem. Also changed ChangeTypeConverter not to throw must implement IConvertible when converting back to System.Object

Many compliments.


Unable to execute wine-staging_ge-proton_8-25 in SteamOS

I'm getting below errors when executing the latest wine-staging_ge-proton_8-25 in Steam Deck desktop mode
(126)(deck@steamdeck Proton)$ ./wine-staging_ge-proton_8-25-x86_64.AppImage
/tmp/.mount_wine-sAlIciD/wrapper: line 24: syntax error near unexpected token done' /tmp/.mount_wine-sAlIciD/wrapper: line 24:  done'

should be fixed now update or redownload appimage.


Mattermost for Microsoft Teams plugin docs

The initial commit introduces the following proposed docs structure:

Admin install & setup for MS Teams Sync

Includes links to topics on installing the plugin & the embedded app

Configure plugin: Plugin config settings for MS Teams Sync

End user docs

@nat-gunner @emdecr 🚀

@cwarnermm Not blocking, but wondering if we'd consider adding a page to the Use Cases section for Unified or External Collaboration? We can talk about MM to MS teams, MM to Open-source Collaboration, MM to MM (Shared channels) and Guest accounts. Might be a good addition to increase visibility?

@wiersgallak - Very open to that approach!


Add CI for pull requests

E.g. Travis-CI has a free option for open source projects, and has a push-button setup process.

Yes. I use it for my other projects (https://github.com/sstur/react-rte). I'll set it up for this one also.

Done. Thx!


Sample Datasets

I can not download the Sample Datasets in China, even if I use VPN. Can other download channels be provided？

Hi @Zhaohuanfeng,
Could you connect to Google drive? Give it a try: https://drive.google.com/drive/folders/1RLlUKq8uiro6-5HY6m3lVcppJxYDuNAX?usp=share_link

Thank you very much. Now I can download the dataset！！！


⚠ HDBits has degraded performance

In 86d370d, HDBits ($HDB) experienced degraded performance:

HTTP code: 200
Response time: 2016 ms

Resolved: HDBits performance has improved in 29fcf26 after 18 minutes.


Auth popup gets blocked by a browser?

Hi and thanks for this great component! is there a way to make twitter auth work like on https://tweetdeck.twitter.com/ which means user is redirected on an auth page? because a regular popup gets blocked all the time by a browser

Do you use latest version v0.0.10? That shouldn't happen in latest version.

i've just updated and everything works, thanks


Some headers under Related Tasks are repeated

Under Related Tasks, all the following headers & their links are repeated:
To delete old rows from backup and restore history tables
To delete all rows for a specific database from backup and restore history tables
To view media header information
To view backup header information

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 759088b5-5531-93c4-bb7b-40407a61a07e
Version Independent ID: 3cd738de-043b-b777-9956-57f0f2c444a2
Content: Backup history & header - SQL Server
Content Source: docs/relational-databases/backup-restore/backup-history-and-header-information-sql-server.md
Product: sql
Technology: backup-restore
GitHub Login: @cawrites
Microsoft Alias: chadam

@engfob -- thank you for bringing these to our attention.  I am updating the article.

@engfob -- thank you for bringing these to our attention.  I am updating the article.

Thank you for your feedback.  I have updated the documentation and it should be live by tomorrow.

Thank you for your feedback.  I have updated the documentation and it should be live by tomorrow.


Feature/#33 bootstrap an accurate documentation structure

Related to FR https://github.com/hubblo-org/scaphandre/issues/33
Better documentation needed, with a structure.
Feedbacks appreciated. :)

Result available here: hubblo-org.github.io/scaphandre

Result available here: hubblo-org.github.io/scaphandre


http://avs24.biz/checkorder.html?iOrderID=169871&iTranNumber=30934&iDate=2019-02-25&iTime=00%3A00

Request type

[ ] Please close this issue, I accidentally submitted it without adding any details
[ ] New documentation
[x] Correction or update

Details

This does not appear to be an MDN issue. Maybe you are looking for https://webcompat.com/ ?


Pie chart sections all black iff one sections was once 100% (360 degrees)

Problem
If the chart once contains one section that takes up 100%, then after an update, pie slices will all be black.
To Reproduce

Create a chart with one PieChartSectionData that represents 100 percent
Then update the chart with multiple pie charts (say: two sections with each 50 percent)
The color of the slices of the pie chart will be black

Version
0.66.0
Potential root cause
With change 68cf161f2623cedda2bf1b51bef758cf62beb812, the blendMode is set to BlendMode.srcOut on the _sectionPaint if there is a slice that takes up 100%. Later, if there are multiple slices, the drawSection is using the same _sectionPaint with the altered blendMode.
I can confirm that the following code fixes the problem:

 void drawSection(
    PieChartSectionData section,
    Path sectionPath,
    CanvasWrapper canvasWrapper,
  ) {
    _sectionPaint
      ..setColorOrGradient(
        section.color,
        section.gradient,
        sectionPath.getBounds(),
      )
      ..blendMode = BlendMode.srcOver       <==== set blend mode to srcOver
      ..style = PaintingStyle.fill;
    canvasWrapper.drawPath(sectionPath, _sectionPaint);
  }

I have the same problem! Any solutions for this?

same issue here

same issue here

Yes, it is related to the code that you mentioned.
Thanks for your detailed issue.
The hotfix is landed on the main branch.
Stay tuned for a hotfix


Compatibility for recent XCode 7.0 GM seed and ElCapitan

XCode 7.0 GM not able load VVDocumenter plugin. Did anyone experience the same things? It work for XCode 7 beta though

I just seen issue at
https://github.com/onevcat/VVDocumenter-Xcode/pull/171
https://github.com/onevcat/VVDocumenter-Xcode/issues/162
I will try it out later at home and check if it resolve it

issue resolved with latest commit


[ISSUE#1908][MAS4.2.10][Focus Order - Add other service] With voiceover consolidated focus goes on "Key and Value".

Solves # 1908
Description
This pull request fixes the navigation with Voiceover through the key-value pair text fields in the Add other service ... dialog.
Now voiceover goes from the label key to its text field, then to the value label and then to its text field.
Changes made
We moved the labels used for the titles inside the first TextField element of the pairs, this way the label is associated with the input field it corresponds.
Also, we changed how the key-value pairs are displayed in the dialog, replacing a list for a table using rows as the tester suggested.
Finally, we made some changes to the styling to have the same visual representation as before. For this, we moved some style properties inside a new class to be used for the rows.
Testing
In the following recording, you can see Voiceover navigation as it should through the fields.

We separated the Key and Value in different columns, this way Voiceover navigate first through all the keys, and then through all the values, as you can see in the following gif.

Merged in PR# 2002


qcm fence wait loop timeout expired after kernel execution; PCIe atomics issue?

I'm currently using a system with
i7 4790K
MSI Z97 Krait
Vega FE in PCI_E_2 (x16 slot--manual lists PCI_E_2 and PCI_E_5 as x16, PCI-E Gen 3 selected in UEFI/BIOS)
On rocm 1.7, Ubuntu 16.04.4, 4.4.0-119, I notice that certain kernels   repeatably produce
qcm fence wait loop timeout expired
Unmapping queues failed.
The cp might be in an unrecoverable state due to an unsuccessful queues preemption
qcm fence wait loop timeout expired
Unmapping queues failed.

at which point other, previously working kernels will also fail. Only after a reboot do other kernels starting working again.
This message is also preceded with
amdgpu 0000:03:00.0: VM_L2_PROTECTION_FAULT_STATUS

although there other kernels that produce this message do not leave the system in an unrecoverable state.
Is this a PCIe atomics issue? (e.g., in #46) It appears that out of thousands of different kernels only a few will trigger this behavior; the majority do not leave the system in an unrecoverable state.

@eqy Can you try ROCm 1.8

@eqy with ROCm 1.7 if you put your GPU in PCI_E Gen 2 slot you would have a failure like this since PCe Gen 2 was not supported,   You can use ROCm 1.8 which remove this restriction


Question: customer rules in Nx repo?

I'm still way finding here, but does this plugin provide the ability to write custom Stylelint rules as an Nx library? I'm trying to figure out how to do this without publishing a custom rule to npm.

As I understand your question, you want to implement custom rules for a Nx Monorepo and use them only inside this monorepo?
It is possible to write your custom rules inside your Nx Monoprepo. You can follow the guide  to write a plugin and import it in your stylelint config.


add leftover tests from subtotals spec fix

Extra tests I wrote that didn't make it into #10743 before it got merged

LGTM.

LGTM.


[Cherry-Pick][3.1.0-prepare] Cherry-Pick OssOperator for Resource Center to 3.1.0

Purpose of the pull request

Cherry-Pick OssOperator for Resource Center to 3.1.0 #11708

Verify this pull request

Verified by manual tests.

Codecov Report

:exclamation: No coverage uploaded for pull request base (3.1.0-prepare@a2b3659). Click here to learn what that means.
The diff coverage is n/a.

@@               Coverage Diff                @@
##             3.1.0-prepare   #12094   +/-   ##
================================================
  Coverage                 ?   38.55%
  Complexity               ?     4009
================================================
  Files                    ?     1001
  Lines                    ?    36681
  Branches                 ?     4244
================================================
  Hits                     ?    14143
  Misses                   ?    20895
  Partials                 ?     1643

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

@caishunfeng Please take a look when available : )


Delay dirty state change event to next tick

Fix #40038. Content change event is delayed in 1000ms but dirty state change is still synchronous. At least we can postpone it to next tick, and then typing is not blocked by listeners (OpenEditorsView and Titlebar)
cc @isidorn

@rebornix -1 for this change, I do not understand how pushing the event handling out to the next tick is improving typing performance. After all at one point we pay the price of the time that is spend reacting to the state change event.
I would suggest to profile where we spend most time and fix the issue at the event handling area. Pushing something out that is expensive does not sound like a good solution to me.


other: update simpleclient, simpleclient_hotspot, ... from 0.12.0 to 0.14.1

Updates

io.prometheus:simpleclient
io.prometheus:simpleclient_hotspot
io.prometheus:simpleclient_httpserver

from 0.12.0 to 0.14.1.
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "io.prometheus" } ]

labels: library-update, early-semver-major, semver-spec-minor

Codecov Report

Merging #12 (d937278) into master (87967c4) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #12   +/-   ##
=======================================
  Coverage   98.64%   98.64%
=======================================
  Files          10       10
  Lines          74       74
  Branches        5        5
=======================================
  Hits           73       73
  Misses          1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 87967c4...d937278. Read the comment docs.


Update User Implement

Todo

Implement

[x] PUT /api/user

Todo

Test

[x] controller
[x] service
[x] ~repository~

Trouble Shooting
..
Response
{
  "user":{
    "email"<EMAIL_ADDRESS>    "bio": "I like to skateboard",
    "image": "https://i.stack.imgur.com/xHWG8.jpg"
  }
}
`

required
```text
email, username, password, image, bio

complete


Allow new histogram properties on visjzon

Right now we can pass to the histogram widget the column and number of bins.
It would be good to have more parameters to control the widget. From the proposal of @rochoa on https://github.com/CartoDB/deep-insights.js/issues/164#issuecomment-184658816 we could add this new options parameters, if not present the server will determine its value:

bins: number of bins in the main histogram
bins_zoomed: number of bins for the zoomed histogram
start/end: determines the initial range to filter for the main histogram.

cc @javisantana @javierarce @xavijam @viddo @alonsogarciapablo
See also https://github.com/CartoDB/cartodb.js/issues/1069#issuecomment-182750040

start/end attributes are somehow a must in latest PoCs, and we had them working in some past commit... :(

For reference of why it was removed, follow the trail of https://github.com/CartoDB/cartodb.js/pull/1173
If this is important we should give prio to solving this properly.

Not sure if it's important, but it's a case we are facing a lot: histograms with 24h per day range, 7 days a week, 100 percent values, or any other parameter with a fixed range in which you want to display even the empty bins.
Vg.:  gender distribution Women/total ratio in percent

It should go up to 100% but it cut at 83% because higher bins are empty. The data is centered around 50, but as the histogram ends at 83%, looks like the distribution isn't centered at 50%, but around 65%. It's a bit confusing.

I'm totally agree with @AbelVM, let's keep this in mind


Add ko.yml for waifu2x GUI

hello!
I did Korean translation for waifu2x GUI.
There is a reference image below.

We plan to add windows_package/docs/README_en.md soon.

same reason as before.


UU birdkeepertoby tournament

Hi @MaartenDJ27,
What exactly is your issue?

Oh I tried to make a teamspread here (for advice) but I didn't know how to make it work

You click in the main black area (see where it says "Paste something here!"), and paste in your team from Showdown or wherever. Then, in the sidebar, you can add a title and stuff if you like, and hit "Submit Paste".

Ah thanks I see it now, I just looked over the submit past button

No problem!


Introduce WT A11y Proposal 2023

The release of Windows Terminal has served as a way to reinvigorate the command-line ecosystem on Windows by providing a modern experience that is consistently updated. This experience has caused faster innovation in the Windows command-line ecosystem that can be seen across various areas like expanded virtual terminal sequence support and enhanced accessibility. Command-line apps can now leverage these innovations to create a better experience for the end-user.
Since accessibility is a very broad area, this document is intended to present recent innovations in the accessibility space for the command-line ecosystem. Furthermore, it will propose additional improvements that can be made alongside key stakeholders that could benefit from such changes.

Note to reader
If there are any features that would have a positive accessibility impact, mention them here. Accessibility comes in many different ways, so features outside of UI Automation deserve to be mentioned too.
Of course, we can add to this document as we come up with more ideas later too. 😉


Latest pypi version is still using the old camelCase interface?

When I call as_summarized_experiment() with the latest version of rds2py from PyPi, I get the following error:
TypeError: SummarizedExperiment.__init__() got an unexpected keyword argument 'rowData'

Which is strange because the version on PyPi is supposedly 0.3.1. But when I download the tarball from PyPi, I indeed see the old interface being used, e.g. in interface.py:
    if _cls == "SummarizedExperiment":
        return SummarizedExperiment(
            assays=robj_asys, rowData=robj_rowdata, colData=robj_coldata
        )

ahh, I recently changed from camelCase to snake_case for the underlying classes. If you don't mind can you install 0.2.14? I'll update this in the package requirements soon

I wound up getting into a dependency rabbit hole downgrading SummarizedExperiment, SingleCellExperiment, filebackedarray, etc, so decided to go with a different approach (reticulate) for converting my R/python objects this time.
The strange thing is the latest 0.3.1 tag of rds2py seems to use the correct interface (row_data instead of rowData), which makes me thing perhaps the wrong wheel was uploaded to pypi?

Hello, I would like to ask what status of this issue is? Today I experienced the same error. Change to 0.2.14 causes next problems with dependencies in different packages.

Thanks @jackkamm and @KatarzynaSzlachetka! Just pushed an update (0.3.2) and should hopefully fix this issue! Please let me know if it doesn't work for you!


Update REVIEWERS

LGTM - I'm in contact with Stat he made one pull request. @lamberta please add him to the list of reviewers if possible.


Collect stats on number of trailing user ops

"TreesLatest" perf event longs number of trailing ops:

                ops: snapshot.ops?.length ?? 0,

We need to continue doing it, but also log number of ops that are not system ops (see isSystemMessage()).
This will help us understand how much user content is there.
We need to port this change to the version of runtime that is currently shipping in Chapter1 & Whiteboard and deploy it there.

It sounds like Ch1 is on 0.58.1001, so that's the release we want to port changes to (and any releases after that, like)

@vladsud,  would this get what you want:
nonSysOps:  snapshot.ops?.filter((op) => !isSystemMessage(op)).length ?? 0,

Yep. Probably not as efficient as it could be (as it creates temp array), but that's probably fine

I could use a foreach instead and add a new variable to count ?

Do we need fixed in 0.55, 0.56, 0.57?
FFX is already on 0.58.1001 (I believe, worth double checking). If so, I do not think there is a need to have older releases.
Maybe 0.57 is Ok for someone who is a bit behind, but I'd probably not touch the older releases.

You mentioned Ch1 and Whiteboard (0.55) - For Ch1, we looked at this query that Navin shared with us:
union Office_Fluid_FluidRuntime*
| where Event_Time > ago(7d)
| join AllHostScenarioNamesExtended() on Data_hostScenarioName
| summarize count() by Chapter, Data_hostName, Data_runtimeVersion, Data_driverVersion, Data_loaderVersion

Please let me know if you still want >= 57 so I can proceed with the pipeline releases.

0.56 has the most usage, and driverVersion is what matters here. So yes, maybe 0.56 should be patched.
The part that I do not know is if apps can deploy hotfixes for old versions. I'll ask around

@NicholasCouri , I believe this issue should be closed (I'll track separately analyzing data)

Sure thing.


ECMPS March Beta: QA Module Regression Testing

At the ECMPS 2.0 ticket refinement meeting held on 2/13/24, Chris instructed us to close Uber Epics.


chore: fix vscode settings for working dirs

🔥 Summary
VS Code was painting red all over when open at the root of the project.   This is due to an incorrect working directory config in vscode settings.  This PR fixes that.

Seems like we have a vulnerability.  Will fix.


ccm: register do-nothing darvaza cloud provider

amended to use pointer receiver to allow for sync.Mutex

dropped unrelated commit, and renamed docs.go to doc.go


fix contributing links

closes #427
links now go to "contributing" instead of "contribute"

no problem :)


Radix Sort for C++ and JavaScrript (Winter of Code)

🚀 Feature
(A clear and concise description of what the feature is.)
Adding Radix sort algorithm for C++ and JavaScript.
Have you read the Contributing Guidelines on Pull Requests?
Yes
Pitch
(Please explain why this feature should be implemented and how it would be used.)
As an important algorithm to know, I will implement it efficiently with clear and concise commenting as well.
Please assign this issue to me.

@HarshCasper please assign this issue to me.

@KavirajSinghBhati  assigned

I am interested in this issue;
Kindly assign it to me.


Problem to Install pysrilm on Windows

I try to install pysrilm on windows. I have builded SRILM on windows by cygwin64
I edited setup.py accord donglixp:
extra_link_args=["-L" + SRILM_LIB_DIR, "-liconv"],
My command on  Cygwin64 Terminal:
python setup.py install build --compiler=mingw32
But i receive this error:
...
running install
running build
running build_ext
skipping 'srilm.cpp' Cython extension (up-to-date)
building 'srilm' extension
C:\cygwin64\bin\gcc.exe -mno-cygwin -mdll -O -Wall -IC:\cygwin64\srilm\include -IC:\Python27\include -IC:\Python27\PC -c srilm.cpp -o build\temp.win-amd64-2.7\Release\srilm.o -fopenmp
gcc: error: unrecognized command line option ‘-mno-cygwin’
error: command 'C:\cygwin64\bin\gcc.exe' failed with exit status 1
anyone have idea to solve?
Thank

Is your python itself compiled using cygwin? (If you're not sure, then check whether the Python variable sys.platform is "cygwin".)
If your Python is compiled using cygwin, then I dunno, I guess this is a bug in distutils, and I don't use windows or cygwin myself so I can't really help you beyond that :-/. Whoever built your python might have some suggestions.
If your Python is not compiled using cygwin, then this has no hope of working -- you can't mix cygwin and non-cygwin code. You need to use a mingw-w64 gcc to compile srilm and pysrilm, not cygwin gcc. I'd suggest trying Carl Kleffner's mingw-w64 builds and see if that helps: https://bitbucket.org/carlkl/mingw-w64-for-python/downloads
(They're also included with WinPython.)

My sys.platform is 'win32'. I don't have many knowledge about cygwin =(
I compiled srilm by cygwin according some tutorial. I'm trying recompile it by mingw-w64
Thank you very much.

Good luck!


LC-413: XOR and all-or-nothing stage conditions

This PR is an investigation into introducing new validation methods for stage configurations. Details on this can be found in this ticket: link. The first two have been implemented in this PR but they still have to be tested. The 3rd has not been done as of yet.

Closing as this ticket will not be implemented at this time, we are keeping the branch.


Corrected Readme

I just corrected a minor mistake in the Readme.

Thanks man! I configured my editor to use unix line endings now. ;)

Well the correction was more about an occurence of "js" being replaced by "css" in In the public/js folder" ☺

haha yes, but the line endings intrigued me :D

Well, should I submit a new pull request? Maybe cleaner with only one commit? Because the readme is still showing "js" instead of "css" :-)

Lol.  I'm sorry... I thought I merged it last time :) it should be merged now :) Thanks again!

You're welcome :-) Wish I can contribute something more useful next time! It's really a great navigation bar.


sistem error karena program api-ms-win-crt-runtime-11-1-0,dll

Problem encountered on https://dotnet.microsoft.com/learn/dotnet/hello-world-tutorial/create
Operating System: windows
Provide details about the problem you're experiencing. Include your operating system version, exact error message, code sample, and anything else that is relevant.

What version of Windows are you running on? You might be missing some dependencies listed on the previous page
https://dotnet.microsoft.com/learn/dotnet/hello-world-tutorial/install


fix package.json

Fix path of main in package.json
Add --copy-files in build script so that non js files are copied

:tada: This PR is included in version 6.0.1 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Changed the suffix of the interface files to .cfg

now respecting the family :) - needed for IPv6 configuration

Thank you for sticking to it.
But this seems the same as the last pull request. #6
The managed deletion should be changed as well to only touch *.cfg files.

My understanding is that the ability to touch or not other files is a plus. I have no need of such a feature, but just including every file '*' is just bad practive, INMO. People might want to keep backups and /not/ use network_manage_devices.
But looking at the code, I think this message has more characters now than that /enhancement/ :-)

I was about to send the patch since it's almost Xmas, but I'm not convinced: I like the idea of being able to use network_manage_devices to keep interfaces.d clean. Too bad if there were backups. If the idea is to preserve backups, then we should perform them ourselves and honor them the proper way. But this would not be a simple "find ... -name *.cfg" anymore.
I'll leave that to you.
-NT

I close this pull request, as no progress was made.


select box (Android browser)

Samsung S3 Mini (White) Android browser
Perhaps this is just how it is, but there is no arrow/affordance for the select box

Strangely enough, this appears to be default behavior. We're not setting or removing any user agent styles for select inputs... after some more testing, I found the android browser makes every select on the internet look like this (including bootstrap css).


Consider adding a version number to checklists

Currently, when checklists are shared around, there is no indication of when the checklist content was imported. For example, if an XLSX file is being passed around to bypass client-side restrictions on macros, the spreadsheet may contain outdated content depending on when it was generated.
Consider adding a version number or "Imported Date" to the pre-generated XLSX files and to the macro import checklist action.

@mbrat2005 This is a very good idea. We recently changed the structure of the Github action doing the automated translation, and now we are finally in a position to automatically add a timestamp to the metadata of the checklists after a push.

Hey @mbrat2005 is the current timestamping of the checklists enough?

Yes @erjosito, the import info looks great and should help! I'll close this issue, thanks for addressing it!


Created BinayakGiri.cpp

This is the solution for the problem minSubarray. The user can give the input and get the sum of minimum subarray

meets guidelines


Plugin not working

I have problems running the plugin. I use this cli. I have add
import { ImageLazyLoadModule, WebWorkerService } from "ng2-image-lazy-load";
  imports: [ // import Angular's modules
 ...
    ImageLazyLoadModule,
  ...
    }),
    ...
  ],

and (which I am not sure is this the problem)
WebWorkerService.workerUrl = '../assets/js/xhrWorker.js';
here. At the html of my Component I have only this:
<div imageLazyLoadArea>
    <div>
      <img [imageLazyLoadItem]="img" alt="{{ name }}">
    </div>
</div>

where "img" and "name" are @Inputs from parent Component. Does my mistake is way of import of xhrWorker.js file?
(I do have included)
import { BrowserModule } from '@angular/platform-browser';
import {HttpModule, Http} from '@angular/http';

I don't see any errors in console. Should I have to add anything in webpack?

@TeodorKolev did you try setting CSS or explicit height on the surrounding div or img?

Nope, but I did try using another plugin, which works

Excellent 👍


WASD to move, once you reach the flag, it will move on automatically to the next
Code
Check off the items that are true.

[x] The game was made using the Sprig editor.
[x] The game is placed in the in the /games directory.
[x] The code is significantly different from all other games in the Sprig gallery (except for games labeled "demo").
[x] The game runs without errors.
[x] The name of the file/game contains only alphanumeric characters, -s, or _s.
[x] The game name is not the same as the others from gallery

Image (If an image is used)

[ ] The image is in the /games/img directory.
[ ] The name of the image matches the name of your file.

Thanks for your PR!

Hi- I can't approve this because it's too similar to the maze game starter. You could qualify for the gallery by adding another game mechanic or two.

Alright, I added a game mechanic which is that there are coins which you have to collect before you are able to obtain the flag

I'm satisfied enough w/ this - congratz!  If you're a teenager, and you haven't already received one, please fill out this form to receive a Sprig device of your very own!  Additionally, swing by the #sprig channel in the Hack Club Slack to share your creation w/ others!


Do we need to make sure that the Technical Profile for Remediation is always called after the Technical Profile for Evaluation has been execute?

[Enter feedback here]
To remediate the risk successfully within the journey, make sure the Remediation technical profile is called after the Evaluation technical profile is executed. If Evaluation is invoked without Remediation, the risk state will be At risk.

Do we need to make sure that the Technical Profile for Remediation is always called after the Technical Profile for Evaluation has been execute?
Or should I call the Remediation Technical Profile only when Challenges are returned?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 1c73cf1e-1f14-6e21-ac23-682c9a2a30fb
Version Independent ID: bcd6680b-70d1-0440-e32e-bef79f5beb8a
Content: Add Conditional Access to a user flow in Azure AD B2C
Content Source: articles/active-directory-b2c/conditional-access-user-flow.md
Service: active-directory
Sub-service: conditional-access
GitHub Login: @msmimart
Microsoft Alias: mimart

Hello @takuyateraoka
Thanks for the feedback! We are currently investigating and will update you shortly.

@takuyateraoka
Thank you for your time and patience!
Based off our documentation the Remediation technical profile should always be called after the Evaluation technical profile, if you want to remediate the risk successfully within the journey.
During the Evaluation phase, the Conditional Access service evaluates sign-in events, and the outcome of this evaluation process indicates whether the sign-in should be granted or blocked. The Remediation phase that follows, will challenge the user with MFA. Once complete, Azure AD B2C informs Identity Protection that the identified sign-in threat has been remediated and by which method.
If you have any other questions, please let me know.
Thank you!

@JamesTran-MSFT Thanks for your answer.


Missing documentation of -o flags supported on push

Reading https://github.com/josh-project/josh/issues/950 I learned that there is a -o base flag. It is not mentioned in the docs, so would be good if the docs could be completed. Are there more flags like that? -o merge is mentioned in the importing guide.

Generally the docs are pretty lite on how to push changes from a 'partial clone' back to the main repo, in particular for workflows where one does not have direct push access to the main repo but needs to create a PR instead. When I push to the proxy, will it try to directly push that to the underlying repo? That is obviously not what I want with a PR workflow.

One way around that would be to do a github fork of the full main repo and do the PR there.

That's what we will have to do the the syncs back to the rustc monorepo then.
Would be nice if josh could be told 'the base is that other branch in that other repo over there', rather than having to have the base branch in the same repo as the one it will push to. Also forcing the use of the base even if the branch-to-push-to already exists would be useful.

There is something else going on with pushing that I do not understand... I am doing
git push http://localhost:8000/RalfJung/rust.git:subtree_prefix=75dd959a3a40eb5b4574f8d2e23aa6efbeb33573,src/tools/miri:/src/tools/miri.git -o base=master HEAD:mirisync-new

where mirisync-new does not exist yet. I am expecting a branch based off of the master in the remote. But instead the newly created branch is based off of a commit almost 2 weeks in the past, 8e3b9bca65d7d79a3b0e9c33fed8d8c93dd66041. There's nothing wrong with that as far as I can see, it's a perfectly fine sync, but it seems completely random -- I don't have a mental model for why josh picked that particular commit. Is that described anywhere?

That does indeed sound a bit strange. In particular since https://github.com/rust-lang/rust/commit/8e3b9bca65d7d79a3b0e9c33fed8d8c93dd66041 does not seem related to miri.
I will see if I can find an explanation tomorrow..

FTR, HEAD at that moment was rust-lang/miri@209318475c19f90f0214beb11b895a8b5e77bb0c.

Speaking of -o base, I noticed something odd. In my mental model of Josh, the following two are equivalent:

Pushing a given subrepo commit to a remote branch that currently has commit X
Pushing a given subrepo commit to a non-existent remote branch, and setting -o base=ref where ref currently has commit X

However, that is not what I am seeing in practice. I often see the first strategy fail with an error like
remote: josh-proxy
remote: response from upstream:
remote: To github.com:RalfJung/rust.git
remote:  ! [rejected]                JOSH_PUSH -> miri (non-fast-forward)
remote: error: failed to push some refs to 'github.com:RalfJung/rust.git'
remote: hint: Updates were rejected because a pushed branch tip is behind its remote
remote: hint: counterpart. Check out this branch and integrate the remote changes
remote: hint: (e.g. 'git pull ...') before pushing again.
remote: hint: See the 'Note about fast-forwards' in 'git push --help' for details.

but the second strategy still works fine in those situations. Is that expected behavior? This makes pushing a bit more annoying since I need to set up two branches (the base and the to-be-pushed-to branch). It might be worth at least documenting more clearly.

We have a case and when finding existing issue before creating one, we found this is relevant issue.
We want to import another project that is updating overtime to our monorepo.
The documentation at https://josh-project.github.io/josh/guide/importing.html is straight forward enough to use git push josh $ref -o merge, but in our case :
We want to use another project with specific branch, for example v2-latest branch (not main branch)
Our monorepo project use main branch and dont have v2-latest branch like another project. So ...
when we use git push josh $ref -o merge from local checkout of v2-latest to monorepo main it didnt work because we dont have v2-latest branch on monorepo.
the question is, how to import another project's specific branch to monorepo's main branch?


Mpi fix

@liamhuber I am able to reproduce your issue with the following repository https://github.com/jan-janssen/pyiron-md

@jan-janssen I will test whether these environmental variables resolve the issue.

The environmental variable solved the issue.

Thanks @jan-janssen and @muh-hassani!!!

I can confirm also my test repository works now fine, so we should be all set. Thanks @liamhuber for testing and identify this issue.


Kindom build modifier slider doesn't work

Describe the bug
Slider doesn't respond in UI, edit field ignores input. If value changed in settings.xml - doesn't affect on build time.
Version Info:

ToyBox Version: 1.4.7
OS: Windows
Version 10

Additional context
Tried 1.4.6 - the same.

there are two sliders, does the one closer to the bottom work?

Yes. It was me who wrote you on discord about this issue.

Fixed in 1.4.8


Evaluate mapping Emotions with Basic Needs

Basic needs are often the source of emotions.
Therefore, it might be a good idea to map emotions to basic needs and to educate about how to fulfill basic needs.
References

https://zfkd.ch/wie/
https://www.sociocracyforall.org/nvc-feelings-and-needs-list/

There are now two categories: positive and negative emotions.
Will investigate into this when the statistics for emotions and the possible call to action after that is coming.
This is basically a meta category to map the action onto the emotions.


[DO NOT MERGE] Testing job update

Please add a meaningful description for your change here

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Choose reviewer(s) and mention them in a comment (R: @username).
[ ] Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

run seed job

Run Seed Job

Run Java InfluxDbIO Performance Test

Run Java InfluxDbIO Performance Test

Run seed job

Run Java InfluxDbIO Performance Test

Run Java InfluxDbIO Performance Test

R: @apilloud


Support the generalization of basis state preparation

Before submitting
Please complete the following checklist when submitting a PR:

[ ] All new features must include a unit test.
If you've fixed a bug or added code that should be tested, add a test to the
tests directory!

[ ] All new functions and code must be clearly commented and documented.
If you do make documentation changes, make sure that the docs build and
render correctly by running make docs.

[ ] Ensure that the test suite passes, by running make test.

[ ] Add a new entry to the .github/CHANGELOG.md file, summarizing the
change, and including a link back to the PR.

[ ] Ensure that code is properly formatted by running make format.

When all the above are checked, delete everything above the dashed
line and fill in the pull request template.

Context:
PR https://github.com/PennyLaneAI/pennylane/pull/6021 removes code duplication for BasisEmbedding and BasisState. As the result BasisState doesn't decompose to BasisStatePreparation any more. This PR updates Python unit tests to support this generalization of basis state preparation.
Description of the Change:
Benefits:
Possible Drawbacks:
Related GitHub Issues:

@multiphaseCFD there are more things to fix in latest/latest :grimacing: I'll update the changelog right after getting latest/latest :green_circle:

@multiphaseCFD latest/latest :green_circle: :tada:

@vincentmr I've run them manually! But let's trigger them here too :+1:


uar-619-Individual-MO-residential-address-displayed-to-user

JIRA link
https://companieshouse.atlassian.net/browse/UAR-619
Change description
uar-619-Individual-MO-residential-address-displayed-to-user

Superseded by https://github.com/companieshouse/overseas-entities-web/pull/1060.


Karma Firefox Launcher Fails and Passes at the Same Time

I have a test that uses karma and karma-mocha. Using the Chrome launcher it works. However, the Firefox launcher fails.
Firefox 38.0.0 (Mac OS X 10.10) ItemBox component level event handlers should support onBlur FAILED
	Error: expected false to be truthy (/var/folders/gt/8h796z8x73s73cb2t239d2240000gn/T/d0b4e279a0759c5dfb303ffb28990ddf.browserify:98:0 <- node_modules/expect.js/index.js:96:0)

(note: I'm using karma-browserify, so the stack trace coming from Firefox is useless, Chrome is fine though)
When inspecting in the Firefox debug console, it shows all my debug statements and a message that the test passed.
"SUCCESS ItemBox component level event handlers should support onBlur" debug.html:35:0
"Skipped 0 tests"

I know the code works because when I interact with it in the debug tab of the karma launched firefox, the correct console messages appear.
Due to the nature of the code I'm using Mocha's done param and setTimeouts in the test, but that has is not a problem in other tests.
Does anybody have any idea why the inspector console says "SUCCESS" but the Terminal window says "FAILED"?
Note: I hope to reduce my code to a point I can post it here soon, but maybe in the meantime somebody can let me know if this is a known problem. I searched using google, and on the karma and karma-firefox-launcher issues section on GitHub. However, I came up empty on this particular bug.

I'm noticing something very similar -- I get 34 "failures" reported in the console (which pass on Chrome/PhantomJS) and inside the Firefox console all "failures" are passing.
I'm using karma, webpack, karma-firefox-launcher, and Jasmine.
I don't have a code sample off hand that can illustrate the issue, but I'm posting for visibility.


BUG: HandleJoin crashes when a user comes back

When a user QUITs and joins back, the following line crashes
https://github.com/SirCmpwn/ChatSharp/blob/master/ChatSharp/Handlers/ChannelHandlers.cs#L15
Attached is the log of the bot. A good solution would be to remove the user entirely from the user collection once he/she quits.
chatsharp_bot_log.txt

I mentioned the fix for this bug here: https://github.com/SirCmpwn/ChatSharp/pull/57#issuecomment-202685890

Has someone found a fix for that yet, or will there be an official one ?

This is a hard one to tackle. There are at least three different ways for storing the client's channel list: IrcClient.Channels, IrcClient.User.Channels and IrcClient.Users[User.Nick].Channels. I can think of two solutions: either all of these should be merged into a single one, or only one of them must exist while the other two have references to the channel list, instead of handling the channel list separately.

Let's not make breaking changes, but I'm all for unifying the stores.

OR, let's write unit tests.

@fahadash I spent a day and a half trying to fix this issue, with some results. I managed to fix the PART bug, but now there's another bug: when the client joins a channel with at least one user in it, it will throw trying to parse the other user's modes.
The reason for the PART bug was simple: the parted channel would be removed from the channel list before the PART message could be parsed.


Editor Viewport Camera has DOF blur enabled, should be toggleable

Godot version
Godot 4 Beta 3
System information
Windows 11/64, RTX 3070, Vulkan
Issue description
My editor viewport camera has a DOF blur which cannot be turned off unless use_physical_light_units is disabled in project settings. It's quite difficult to work up close with a blurry camera.
PLU disabled

PLU enabled

The editor viewport should be able to quickly turn blur on and off, and adjust physical camera settings (in the viewport settings), or just disable blur entirely.
Also the path rendering/lights_and_shadows/use_physical_light_units gives no indication it has anything to do with cameras or lenses, so it's not searchable for someone thinking about cameras & lenses. I think there should either be a new name (use physical_lights_and_cameras), or two settings use_physical_lights and use_physical_cameras if they need to be project settings.
(Also, I'd like to see the camera have the option to calculate changing DOF blur without changing exposure at all, but this can be a topic for another issue. I need to separate out the blur tracker into more separate issues. It's on my list.)
@clayjohn
Steps to reproduce
Enable use_physical_light_units.
Zoom close to an object with details to see the blur.
Minimal reproduction project
No response

Thanks for the report, it looks like I accidentally left a CameraAttributesPhysical in the editor default environment from when I was testing physical light units. DoF should definitely not be enabled with the editor Camera without the user specifically requesting it.


Fix double tap pressed event regression

closes https://github.com/godotengine/godot/issues/35655
please test it.
The double click was recognized as a pressed event.

Tested locally and I confirm it fixes #35655.

Thanks!

Cherry-picked for 3.2.1.


Add quiet mode and support for ignore patterns

https://github.com/tcort/markdown-link-check/issues/39

Regarding ignore patterns:
I have wrapped them into an object to allow future extensions. One example could be to scope a pattern to certain files via file globs.
Another reason could be to additionally allow the following:
{
    "ignorePatterns": [
        {
            pattern: "^http://example.net",
            reason: "Some justification why this sould be skipped."
        }
    ]
}

Also addresses #10 and #18.

Thanks for the patches. Published in v3.5.0.


Could vim.g.have_nerd_font be a local variable instead?

Describe the bug

:help have_nerd_font did not return any matches, so I assume that it is only used by kickstart itself? Or is this some convention to indirectly communicate with other plug-ins?
I am by no means a Lua expert, but from what I understand a local variable should work just fine?

Is there an important reason that  have_nerd_font has to be a  global vim variable?  If not, then I think using a global vim variable is confusing at best.
To Reproduce
NA
Desktop

OS:  NA
Terminal:  NA

Neovim Version
v0.10.0

It's a simple flag, and the name of the flag tell you exactly what the flag does.
What would help say?
"Do we have Nerd Fonts installed? (y/n)"
Sorry I guess I just don't understand the issue.

Sorry I guess I just don't understand the issue.

@feoh as per the issue title, my question is:  Could vim.g.have_nerd_font be a local variable instead?

Thank you. I understand the question, but I don't understand why :)
What advantages does this. change bring? What does it do for us? Why should we make it?

@feoh thanks for your attempt to help.  However:

You didn't answer my question.

From your "weaseling around", I assume that no, there's no important reason to use a global variable here.  Please correct me if I'm wrong.

If somebody uses a global variable then I assume that person has a good reason for doing so. You wouldn't just use global variables for no good reason, right? So when I try to understand what's going on here, there are two possibilities: (a) somebody used a global vim variable "by accident" or (b) there is some important reason that slipped my attention, or I'm missing the full picture somehow.
If it's (b) I would not want to miss the chance to deepen my understanding.  If it's (a) however and you don't wanna fix this then that's up to you, I'm not willing to argue over this.  Just don't be surprised if people are utterly puzzled.

Hi. I don't know what your native language is, but in English, using the word 'weasel' has some rather negative connotations.
Perhaps you might choose differently.
I don't know the answer to your question. If you want to make PR to change this, please do so, but as stated this isn't an issue that's actionable so I'm closing for now.


bug(mat-select): Select component options truncate when the option text doesn't contain any white spaces

Is this a regression?

[ ] Yes, this behavior used to work in the previous version

The previous version in which this bug was not present was
No response
Description
Since version 15, very long text options in a mat-select element are no longer truncated, but break onto multiple lines.
However, if you have no white spaces in the option text, then the option will truncate.
The expected behaviour is to have some consistency across all options, whether it be that they all truncate or they wrap onto multiple lines.
By inspecting the code it seems that options are using truncation applied to list items, with which they share the "mdc-list-item__primary-text" class

However, that is been overridden for options in a select element (the white-space: normal property below)

which is indeed causing options to wrap if too long, but not if they don't contain any white space.
Reproduction
This can be reproduced in the Angular Material Documentation by changing the text in any two options in dev tools https://v15.material.angular.io/components/select/examples

Expected Behavior
All options with long text, with or without white-spaces, should have a consistent behaviour, either truncate or wrap onto multiple lines.
Actual Behavior
Two different behaviours as described in the description above
Environment

Angular: 16.2.8
CDK/Material: 16.2.7
Browser(s): Chrome
Operating System (e.g. Windows, macOS, Ubuntu): Windows

@natechiarello I think this is the expected behaviour only.

@maruthumj if we are expecting the text o never truncate (as the comment says), then white-space won't be enough because in one case, when the text doesn't contain any white-space, it will truncate.
Are you saying that it is expected behaviour that options will break onto multiple line by default, but if the option text doesn't have any white spaces, then it is expected behaviour that the option truncates?

Hello @natechiarello ,
Thank you for reaching out. We need more information.

Expected Behavior All options with long text, with or without white-spaces, should have a consistent behaviour, either truncate or wrap onto multiple lines.

I do not know of any specific requirements that MatSelect has for truncation. I understand that different truncation may be appropriate depending on the application. We need more information to show what the requirements say the expected behavior should be :).
As a work-around, I believe you should be able to override styles to get the behavior you would like.
Without a clear requirement, I am not sure if action can be taken on this.
Do you know of anything in Material Design that specifies how truncation should be? Or, do you have a reference implementation? It would be helpful if there was something to show what truncation should in general.
Best Regards,
Zach

Neither Material Design documentations (versions 2 - https://m2.material.io/components/lists nor version 3 - https://m3.material.io/components/lists/overview) make it very clear. There doesn't seem to be a dedicated area defining what the expected behaviour should be for long text select items, and we see mixed behaviour in the screenshots they use. For example in version 2 they show truncation:

as well as multilines:

Similarly in version 3 we have truncation:

multilines:

and even a mix of both (truncation on second line):

Angular Material 15 supports Material Design version 2, so we should probably check against that for now. Given that there are no definitive guidelines on this, I guess both approaches could do, although it seems clear that a decision was taken to go from truncation to multilines from Angular Material version 14 to version 15, as shown in the screenshot below from the version 14 website https://v14.material.angular.io/components/select/examples

This bug fix request could be closed as long as this inconsistency was expected and not caused by mistake (by inconsistency I mean the different behaviour in version 15 between a very long select option with space which breaks onto multiple lines versus a very long select option without any spaces, which will get truncated, as described when I raised this item).
Hope this info helps.


Parameter counting API for Layer

Currently we can't easily know how many parameters Layer instance has.
It'll be useful for estimating model size.
Keras's Layer has this feature.
https://github.com/keras-team/keras/blob/c10d24959b0ad615a21e671b180a1b2466d77a2b/keras/engine/base_layer.py#L1105-L1123

This can be done once we flesh out the property wrapper solution for parameters (along the lines of #250).

I have been counting parameters based on how variables used to be updated in optimisers:
extension Layer {
    var parameterCount: Int {
        let floatKeyPaths = self.recursivelyAllWritableKeyPaths(to: Tensor<Float>.self)
        let doubleKeyPaths = self.recursivelyAllWritableKeyPaths(to: Tensor<Double>.self)
        var parameters = 0
        for kp in floatKeyPaths {
           parameters += self[keyPath: kp].shape.contiguousSize
        }
        for kp in doubleKeyPaths {
            parameters += self[keyPath: kp].shape.contiguousSize
        }
        return parameters
    }
}

Is there anything inherently wrong in doing it this way or is it just not ideal as more variable types get used?

One problem with this approach is duplication for each variable type as you mentioned. A bigger problem is that you might include tensors that are not parameters of a model, e.g. ones that are marked @noDerivative.

Thanks for explaining this Richard.

@mikowals @rxwei another problem is that you might not include tensors that are parameters. E.g., different data types or potentially, arrays of tensors (I believe this would not account for tensor arrays).

I'd like to work on this one. Could you please assign this to me? :slightly_smiling_face:


Changing Policy Scope

Hello,
I've been searching for a tutorial on how to work with overrides and haven't found one that goes into the basics of everything I want to know. The main thing I am working on now is changing the scope of a created policy; I just want it to be scoped to a group "Testing" and that is it. Changing the SmartGroupTemplate.xml doesn't seem to be affecting anything at all and I can't find where this scope would be changed (it just says "scope handled by JSS Importer").
I am sure this is a super basic question but any direction is appreciated.

Hello back!
So if I'm understanding you correctly, you just want the policy to be scoped to the Testing group? Not to a smart group that includes members of the Testing group who don't have the newest version of the application?
(If so, this means you will have a ton of policies available to those members of the testing group, and picking them apart visually in Self Service  may be troublesome).
But, if that's the case, in your override, make sure that the groups argument to JSSImporter has a single array item with a single key of "name" and string value of "Testing". As in
<key>groups</key>
<array>
    <dict>
        <key>name</key>
        <string>Testing</string>
   </dict>
</array>

I made the change you suggested and it doesn't seem to actually register. Here is the full Override:
<?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
<plist version="1.0">
<dict>
	<key>Identifier</key>
	<string>local.jss.AdobeFlashPlayer</string>
	<key>Input</key>
	<dict>
		<key>CATEGORY</key>
		<string>Digital Media</string>
		<key>GROUP_NAME</key>
		<string>AutoPKG-%NAME%-Test</string>
		<key>GROUP_TEMPLATE</key>
		<string>AdobeFlashPlayerSmartGroupTemplate.xml</string>
		<key>NAME</key>
		<string>AdobeFlashPlayer</string>
		<key>POLICY_CATEGORY</key>
		<string>Testing</string>
		<key>POLICY_TEMPLATE</key>
		<string>PolicyTemplate.xml</string>
		<key>SELF_SERVICE_DESCRIPTION</key>
		<string>Adobe Flash Player is freeware software for using content created on the Adobe Flash platform, including viewing multimedia, executing rich Internet applications, and streaming video and audio.</string>
		<key>SELF_SERVICE_ICON</key>
		<string>AdobeFlashPlayer.png</string>
		<key>groups</key>
			<array>
    			<dict>
        		<key>name</key>
        	<string>Testing</string>
   			</dict>
		</array>
	</dict>
	<key>ParentRecipe</key>
	<string>com.github.jss-recipes.jss.AdobeFlashPlayer</string>
</dict>
</plist>

Any ideas? I am sure it is really simple but I don't really know enough about the syntax of plists.

Using a static group would require changing the actual arguments to the JSSImporter processor. It is not something that can be done with an override. If you look at the recipe you're trying to override, the com.github.jss-recipes.jss.AdobeFlashPlayer, for example, look for the JSSImporter processor and its array of groups. You can copy this recipe and edit it to change the smart value to False and name it how you like.
Unfortunately this would potentially mean quite a bit of copying and manual editing of recipes. This also means that every time one of those recipes changes, you're going to have to update them manually. Those of us involved in the JSS-Recipes archive strongly feel that the Smart Group approach is the best use for most people. I would strongly encourage you to try to make use of the smart group as configured. It includes all computers that are members of the testing smart group and only offers the update to computers that do not have that version.
Barring that, I suppose the next easiest thing to do would be to still use the smart group, but edit the smart group template to ONLY include criteria for "Computer Group" "member of" "Testing". (This means trimming out the Application Name and Application Version criteria.

Hey @jshirle2! Did you give the above a try? Any feedback? Shall we close the issue?


feat: ensure single components for weights

I'm pinning to the specific commit in spopt for now - the tests pass locally, but clearly this isn't working on the remote ci.
We could cut a release of spopt and then remove the pinning?

the CI is installing from the yaml file, so it's not catching this pin, but doing an spopt release would be good

seems to be failing due to https://github.com/conda-forge/fontconfig-feedstock/issues/54
should be resolved shortly, i think


Corrects an issue: Server 2019 release notes - missing link

Restores a missing link to KB 4466511 in Server 2019 release notes

Thanks, @exchange12rocks !


Spring Cloud Kubernetes Secrets ProperySources Don't Use Active Profiles

Unlike the ConigMap PropertySource implementations (both Fabric8 and Kubernetes client), the Secrets PropertySource implementations don't take into account active profiles.  Seems like they should for the sake of consistency.

Yeah ran into it working on this pr
https://github.com/spring-cloud/spring-cloud-kubernetes/pull/881/files#diff-78b603db3110784f23a8f456fb8377306be36ae3856cfb37414a5dbcc96c4d3cR236

@ryanjbaxter can be closed, as supported was added


Hide help fix

Github Issue (if applicable): --
Trello Link (if applicable): --
Forum Link (if applicable): --
Explanation of Bugfix/Feature/Enhancement:
Moved feature to sauce. Fixed a bug where the user’s hide help setting wasn’t saved between YNAB refreshes.
Recommended Release Notes:
Bugfixes.

Github is being weird, and not showing the latest commit for some reason. I'm closing this and I'll re-open a new pull request.


Validate k8s 1.13 for 1.6

Need to add k8s 1.13 support for 1.6 release line. It should include support for Node Local DNS to address
https://github.com/rancher/rancher/issues/15718#issuecomment-443979606

@kinarashah is going to handle releasing k8s 1.13 binary and a first pass of rancher/kubernetes image
@superseb we should revise all the addons to see if it needs version bump up for k8s 1.13

For K8s 1.13, etcd2 backend was dropped. We will need to support etcd3 first before being able to support k8s 1.13 in 1.6:
Urgent Upgrade Notes
(No, really, you MUST do this before you upgrade)
Before upgrading to Kubernetes 1.13, you must keep the following in mind:

kube-apiserver
The deprecated etcd2 storage backend has been removed. Before upgrading a kube-apiserver using --storage-backend=etcd2, etcd v2 data must be migrated to the v3 storage backend, and kube-apiserver invocations changed to use --storage-backend=etcd3. Please consult the installation procedure used to set up etcd for specific migration instructions. Backups prior to upgrade are always a good practice, but since the etcd2 to etcd3 migration is not reversible, an etcd backup prior to migration is essential.

Due to the deprecated support of etcd v2 in k8s 1.13 and with the release of Rancher 2.0, development on v1.6 is only limited to critical bug fixes and security patches.


updating custom tab name instantly

Calling redrawtabline within the callback ensures that the new tab name is instantly visible after submitting
The current call outside the callback is not doing anything. So after a rename the old tab name is still visible until Neovim decides to redraw the tabline by itself

Thanks!


Use string.Create when building a new inbox string

Use a more idiomatic implementation for NewInbox and improve performance.

Method
Rev
Runtime
Mean
Error
StdDev
Gen0
Allocated

TryWriteNuid
Base
.NET 8.0
31.92 ns
0.672 ns
0.800 ns
-
-

TryWriteNuid
PR
.NET 8.0
30.66 ns
0.650 ns
1.171 ns
-
-

NewInbox_ShortPrefix
Base
.NET 8.0
59.64 ns
1.258 ns
1.921 ns
0.0612
128 B

NewInbox_ShortPrefix
PR
.NET 8.0
46.89 ns
0.945 ns
1.865 ns
0.0612
128 B

NewInbox_LongPrefix
Base
.NET 8.0
79.69 ns
1.674 ns
4.230 ns
0.1988
416 B

NewInbox_LongPrefix
PR
.NET 8.0
49.29 ns
1.052 ns
2.331 ns
0.0994
208 B

TryWriteNuid
Base
NativeAOT 8.0
27.82 ns
0.468 ns
0.520 ns
-
-

TryWriteNuid
PR
NativeAOT 8.0
26.19 ns
0.527 ns
0.467 ns
-
-

NewInbox_ShortPrefix
Base
NativeAOT 8.0
54.16 ns
0.955 ns
0.981 ns
0.0612
128 B

NewInbox_ShortPrefix
PR
NativeAOT 8.0
46.18 ns
0.925 ns
0.908 ns
0.0612
128 B

NewInbox_LongPrefix
Base
NativeAOT 8.0
71.15 ns
0.700 ns
0.621 ns
0.1988
416 B

NewInbox_LongPrefix
PR
NativeAOT 8.0
49.10 ns
0.748 ns
0.625 ns
0.0994
208 B

Looks like tests target .NET6/8 only. I think that the NETSTANDARD2_0 path works too, but I don't have a setup to test that 🤞
6299995a4a2d75c913d9bf8c858f61ae27d53960 is only tangentially related but I thought I could sneak it in.

@jasper-d

Looks like tests target .NET6/8 only. I think that the NETSTANDARD2_0 path works too, but I don't have a setup to test that 🤞

We have NATS.Client.Platform.Windows.Tests on Windows net481 runs as part of memory tests (since they were running on Windows host already): https://github.com/nats-io/nats.net.v2/actions/runs/9848378574/job/27205978145?pr=551#step:9:1

We have NATS.Client.Platform.Windows.Tests on Windows net481 runs as part of memory tests

Great, then it's covered :)
There are two other places I found that could be optimized in a similar way, but I'm not sure if they are hot enough to justify the #if hell and general lack of readability:
From 6f061898810a4fb923882ee8b4bb07ba77c3bbbc Mon Sep 17 00:00:00 2001
From: jasper-d<EMAIL_ADDRESS>Date: Wed, 10 Jul 2024 20:43:11 +0200
Subject: [PATCH] Allocate less

---
 src/NATS.Client.Core/Internal/NuidWriter.cs   | 15 ++++++----
 .../NatsJSContext.Consumers.cs                | 29 +++++++++++++++++--
 2 files changed, 36 insertions(+), 8 deletions(-)

diff --git a/src/NATS.Client.Core/Internal/NuidWriter.cs b/src/NATS.Client.Core/Internal/NuidWriter.cs
index e8a5785..30edeee 100644
--- a/src/NATS.Client.Core/Internal/NuidWriter.cs
+++ b/src/NATS.Client.Core/Internal/NuidWriter.cs
@@ -54,13 +54,16 @@ internal sealed class NuidWriter

     public static string NewNuid()
     {
-        Span<char> buffer = stackalloc char[22];
-        if (TryWriteNuid(buffer))
+#if NET6_0_OR_GREATER || NETSTANDARD2_1
+        return string.Create((int)NuidLength, default(object), (buffer, _) =>
         {
-            return buffer.ToString();
-        }
-
-        throw new InvalidOperationException("Internal error: can't generate nuid");
+            TryWriteNuid(buffer);
+        });
+#else
+        Span<char> buffer = stackalloc char[(int)NuidLength];
+        TryWriteNuid(buffer);
+        return buffer.ToString();
+#endif
     }

     private static bool TryWriteNuidCore(Span<char> buffer, Span<char> prefix, ulong sequential)
diff --git a/src/NATS.Client.JetStream/NatsJSContext.Consumers.cs b/src/NATS.Client.JetStream/NatsJSContext.Consumers.cs
index 45a7864..384d36d 100644
--- a/src/NATS.Client.JetStream/NatsJSContext.Consumers.cs
+++ b/src/NATS.Client.JetStream/NatsJSContext.Consumers.cs
@@ -1,3 +1,4 @@
+using System.Diagnostics;
 using System.Runtime.CompilerServices;
 using NATS.Client.Core.Internal;
 using NATS.Client.JetStream.Models;
@@ -228,8 +229,32 @@ public partial class NatsJSContext : INatsJSContext
             request.Config.FilterSubjects = opts.FilterSubjects;
         }

-        var name = NuidWriter.NewNuid();
-        var subject = $"{Opts.Prefix}.CONSUMER.CREATE.{stream}.{name}";
+#if NET6_0_OR_GREATER || NETSTANDARD2_1
+        // This could also be written like this to avoid the extra string alloc
+        // from NuidWriter.NewNuid at the costs of being ~2x as slow as
+        // string.Create.
+        //
+        // Span<char> nuid = stackalloc char[(int)NuidWriter.NuidLength];
+        // NuidWriter.TryWriteNuid(nuid);
+        // var subject = $"{Opts.Prefix}.CONSUMER.CREATE.{stream}.{nuid}";
+        const string consumerCreate = ".CONSUMER.CREATE.";
+        var len = consumerCreate.Length + (int)NuidWriter.NuidLength + stream.Length + Opts.Prefix.Length;
+
+        var subject = string.Create(len, (Opts.Prefix, stream), static (buffer, state) =>
+        {
+            state.Prefix.AsSpan().CopyTo(buffer);
+            var remaining = buffer.Slice(state.Prefix.Length);
+            consumerCreate.AsSpan().CopyTo(remaining);
+            remaining = remaining.Slice(consumerCreate.Length);
+            state.stream.AsSpan().CopyTo(remaining);
+            remaining = remaining.Slice(state.stream.Length);
+            var didWrite = NuidWriter.TryWriteNuid(remaining);
+            Debug.Assert(remaining.Length == NuidWriter.NuidLength, "remaining.Length == NuidWriter.NuidLength");
+        });
+#else
+        var nuid = NuidWriter.NewNuid();
+        var subject = $"{Opts.Prefix}.CONSUMER.CREATE.{stream}.{nuid}";
+#endif

         return JSRequestResponseAsync<ConsumerCreateRequest, ConsumerInfo>(
             subject: subject,
--
2.45.2

We have NATS.Client.Platform.Windows.Tests on Windows net481 runs as part of memory tests

Great, then it's covered :)

yeah I think so too ;)

There are two other places I found that could be optimized in a similar way, but I'm not sure if they are hot enough to justify the #if hell and general lack of readability:

I can't see them being on a hot path, maybe NewNuid() more than the consumer creation. (string.Create() is pretty cool btw) #ifs don't look too bad. it's up to you 💯

Let's keep it the way it is then. You'll have to maintain it.


Fix mispell and staticchek issues

This commit fixes issues found by
golangci-lint run --disable-all -E misspell
and golangci-lint run --disable-all -E staticcheck
Signed-off-by: Fred Rolland<EMAIL_ADDRESS>

lgtm


the thumt transformer model no implement early stopping to prevent overfitting?

the early stopping to prevent overfitting is very useful to train a NMT model,but I didn't found it in thumt transformer.

Early stopping can be achieved in two ways in THUMT:

When --validation <your validation source file> --references <your validation reference files> is set in training, THUMT will evaluate on the validation set periodically. The checkpoints that achieves highest BLEU scores on the validation set will be saved in the train/eval folder. (You can halt or resume the training whenever you want.)
Setting keep_checkpoint_max in parameters to reserve as many checkpoints as you want.


KeyError on slicing with datetime or pandas.Timestamp

related #6066 (on Float64Index too)
The 'KeyError' on slicing was discussed multiple times but I'm still not sure if the issue below is a bug or just my misunderstanding.
I'm experiencing 'KeyError' from time to time when I try to slice my dataframes with datetime or Timestamp objects, however slicing with strings works perfectly. I was unable to construct synthetic example with pandas.date_range, so I needed to upload the piece of real data where the issue appears:
https://www.dropbox.com/s/ibzbwqs35tiydyc/tmp.h5
df = pd.read_hdf('tmp.h5', 'data')
print df.head()

When I try to slice it with the pandas.Timestamp objects it results in 'KeyError':
tt1 = pd.Timestamp('2006-11-16 18:30:00')
tt2 = pd.Timestamp('2006-11-16 18:40:00')
print df.ix[tt1:tt2].head()

Same for datetime objects:
tt1 = pd.Timestamp('2006-11-16 18:30:00').to_datetime()
tt2 = pd.Timestamp('2006-11-16 18:40:00').to_datetime()
print df.ix[tt1:tt2].head()

However this slicing works perfectly:
tt1 = pd.Timestamp('2006-11-16 18:30:00').strftime('%Y-%m-%d %H:%M:%S')
tt2 = pd.Timestamp('2006-11-16 18:40:00').strftime('%Y-%m-%d %H:%M:%S')
print df[tt1:tt2].head()

Numpy version 1.8.0
Pandas version 0.13.0

Hi there, I know this issue is closed, since it's not a bug. I would argue, though, that the error message could point the user in the right direction (I googled the error message and it lead me here).

I second Kristian. And I'll provide a bit more context which can be helpful:
trimmed_series = series[event.startTime:event.endTime]

Which throws KeyError:<PHONE_NUMBER>000000000. Initially I thought that maybe event.endTime happens to be after the last index of series, and that maybe pandas isn't smart in dealing with out of bound errors. Obviously pandas does deal with this and it was the index not being sorted (which was a bug elsewhere in my code), which I found here. But it definitely isn't intuitive.

@leonsas @KristianHolsheimer
if you have a nice reproducible example, pls open a new issue (and xref this one). This is well-defined behavior. I closed this because its not a bug, though, it could/should be a ValueError with an even more informative error message.

As requested by @jreback, I hereby create a nice reproducible example:
import pandas as pd
index = pd.date_range('2016-10-29 23:00', '2016-10-30 3:00', freq='15T', tz='UTC')
index = index.tz_convert('Europe/Brussels').tz_localize(None)
ts = pd.Series(1, index=index)
ts.truncate(before='2016-1-1')

which raises:
KeyError:<PHONE_NUMBER>000000000L
In above example, the index is non-sorted due to the naive local time, comprising a switch from Summer to Winter time.
Interestingly, truncating with a time that is contained inside the index works fine (unless you choose a non-unique label of course):
ts.truncate(before='2016-10-30 1:30')

Thus, the behaviour is not really consistent, and to me that smells more like a bug rather than just throwing the right Error type...
Also, slicing the data as:
ts['2016-1-1':]

raises no error. And, of course, as pointed out above, the same is true for truncating the sorted series:
ts.sort_index().truncate(before='2016-1-1')

@kdebrab the only thing that would be nicer would be the actual KeyError message for a not-found label. (It should show it as a Timestamp). So would take a fix for that.
you can open a new issue, or push a PR if that works for you.

The truncate does just a slice under the hood, so the example of @kdebrab becomes:
In [12]: ts[pd.Timestamp('2016-1-1'):]
...
KeyError:<PHONE_NUMBER>000000000

So which raises an error, because you are slicing with a non-present value on a non-sorted index.
To give a more simple example for this:
In [33]: s = pd.Series(range(5), index=[1,2,3,2,4])

# works because '1' is present (and is unique), so unsortedness does not matter
In [34]: s.loc[1:]
Out[34]:
1    0
2    1
3    2
2    3
4    4
dtype: int64

# fails because '0' is not a label, because of unsortedness pandas cannot know how to handle this
In [35]: s.loc[0:]
...
KeyError: 0

I think it really be nice to have a better error message for this, as the difference between sorted/not-sorted can be very subtle, and with a sorted index, slicing with a non-present label is perfectly fine.
@jreback The only thing I don't directly find clear is why does the same example work with strings?
In [13]: ts['2016-1-1':]
Out[13]:
2016-10-30 01:00:00    1
2016-10-30 01:15:00    1
...
2016-10-30 03:45:00    1
2016-10-30 04:00:00    1
Freq: 15T, dtype: int64

Shouldn't this be equivalent to ts[pd.Timestamp('2016-1-1'):]? Or at least in the case of ts['2016-1-1 00:00:00':] (which also works) where it cannot be seen as partial string?

this works with strings because a string turns into partial timestamp indexing and thus is a slice, and hence works.
so maybe we ought to always make truncate a slice, then this will just work.

@jreback I thought partial strings only turned into a slice when the string has lower resolution than the series. In the case of ts['2016-1-1 00:00:00':] this is certainly not the case, and should be treated as a slice with an exact Timestamp?

In [7]: ts.index.resolution
Out[7]: 'minute'

so I think its always treated as a slice (in this example)

So this was never settled?
I think I will create a new bug for it as it just cost me almost an hour.


added info about using your own CA for IoT

I have found this feature to be in high demand from my customers, so wanted to add a link to it here

👍 Looks good! Thanks!


BUG: Search icon not visible and website logo missing from footer

Describe the bug
The search icon is not visible on the website, and the website logo is missing from the footer. This impacts user experience and the footer looks incomplete without the branding.
To Reproduce
Steps to reproduce the behavior:
• Go to the homepage of the website.
• Look for the search icon in the header or navigation bar.
• Scroll down to the bottom of the page.
• Observe the footer for the presence of the website logo.
Expected behavior
The search icon should be clearly visible and easily accessible in the header or navigation bar. The website logo should be prominently displayed in the footer to maintain brand consistency and enhance the visual appeal of the page.
Screenshots

Please assign this to me under gssoc

It is not reflecting due to proper deployment ...Its already been worked on
kindly Request to work on major problem and Drop your Discord id to get update through discord channel


CNCF conformance tests for Kubernetes v1.12 and v1.13

Kubernetes 1.14 will be released at 2019-03-25.
Until the date, we should run CNCF conformance tests for K8s 1.12 and 1.13. Once 1.14 was released, it would not be possible to do it for 1.12 any more.

Done.
https://github.com/cncf/k8s-conformance/pull/460
https://github.com/cncf/k8s-conformance/pull/461