Stop server bound to clean causes problems in a multi-module project with submodule dependencies

The StopServerMojo defines the following dependency resolution requirements: requiresDependencyResolution = ResolutionScope.COMPILE_PLUS_RUNTIME. It is also bound to the Maven clean goal.
This creates a problem in a multi-module project with submodules that depend on each other. When running mvn clean from a fresh environment, the dependency resolution that is done in the stop-server goal fails because the submodules have not been built or installed yet. This is fixed after the user runs mvn install so that the artifacts go into .m2, but I don't think we should be failing the first time.
@patricktiu Do you know what the reason is for the dependency resolution requirement? I saw from the Git Blame that you had modified that line last.

I think this is a bug. I reason we need the requiresDependencyResolution set is when the goal needs to get the dependency artifacts and stop-sever goal doesn't need to.

The same phenomenon seems to be true for the create-server target. So it would be great if someone could review/refactor the dependencies for the WLPServer-Lifecycle-targets

@patricktiu So you're saying that we should just remove requiresDependencyResolution from the stop-server goal?
I saw that you added all the requiresDependencyResolution parameters in this commit: https://github.com/WASdev/ci.maven/commit/ec142242d301d2980fa453a1ed44e6e9c47f1d9f. Can you explain the bug with using version ranges when requiresDependencyResolution is not set?

@patricktiu and @chyt : I would imagine all application and jsp mojos to require the dependency resolution, but not the server mojos. At the moment all server mojos contain the requiresDependencyResolution too.

To support the versionRange in install-server goal, we need to be able to get wlp runtime maven dependence.  To be able to resolve it in the install-server mojo, we need add the requiresDependencyResolution, but I may have over done it in other mojos, undeploy, server-status, clean-server, debug-server, dump-server, java-dump-server, run-server, start-server, stop-server, test-start-server, test-stop-server and uninstall-feature

@orebmann  I have tested again with install-server goal without requiresDependencyResolution, the plugin is still able to resolve the dependency version in both of these scenarios below. I agree with you that we can remove requiresDependencyResolution from all server goals.  I have PR to remove the requiresDependencyResolution from all server goals (reverting the changes from commit ec14224.
            <plugin>
                <groupId>net.wasdev.wlp.maven.plugins</groupId>
                <artifactId>liberty-maven-plugin</artifactId>
                <version>2.3-SNAPSHOT</version>
                <configuration>
                    <assemblyArtifact>
                        <groupId>io.openliberty</groupId>
                        <artifactId>openliberty-runtime</artifactId>
                        <version>[<IP_ADDRESS>,)</version>
                        <type>zip</type>
                    </assemblyArtifact>
                    <serverName>${project.artifactId}Server</serverName>
                    <configFile>src/main/liberty/config/server.xml</configFile>
                    <include>${packaging.type}</include>
                </configuration>
            </plugin>

or
    <dependencyManagement>
        <dependencies>
            <dependency>
                <groupId>io.openliberty</groupId>
                <artifactId>openliberty-runtime</artifactId>
                <version>[<IP_ADDRESS>,)</version>
                <type>zip</type>
                <scope>provided</scope>
            </dependency>
    </dependencies>
   ...
            <plugin>
                <groupId>net.wasdev.wlp.maven.plugins</groupId>
                <artifactId>liberty-maven-plugin</artifactId>
                <version>2.3-SNAPSHOT</version>
                <configuration>
                    <assemblyArtifact>
                        <groupId>io.openliberty</groupId>
                        <artifactId>openliberty-runtime</artifactId>
                        <type>zip</type>
                    </assemblyArtifact>
                    <serverName>${project.artifactId}Server</serverName>
                    <configFile>src/main/liberty/config/server.xml</configFile>
                    <include>${packaging.type}</include>
                </configuration>
            </plugin>
  ...

#325 is merged. @orebmann Can you compile the source locally and see if it fixes your issue? If so we can close this issue.

@chyt I did a short test with clean, stop-server, create-server - and those worked now in a multi-module project without dependencies to the subprojects

@orebmann What about with subproject dependencies?

@orebmann Can you respond to Charles last question? Can this issue be closed now?


Record the thrown error type for try? and try! in the AST

SILGen wants this so it knows what kind of error its going to end up with.

@swift-ci please smoke test


Legacy FE toolkit script for <details> conflicts with GOV.UK Frontend details script

What
Our details component JavaScript conflicts with the legacy FE toolkit JavaScript because the legacy script targets any <details> elements on the page instead of name spaced components. This means that our details component is styled correctly but doesn't open in IE11 if page also instantiates the toolkit details JavaScript.
We do this in the review app for testing purposes.
Why
We could fix this but the chances of this being a problem for service teams seem very low as it would most likely be in the midst of a service migrating to GOV.UK Frontend and having both the GOV.UK Frontend details and the legacy details instantiated on the same page.
Who needs to know about this
Developers only?

Closing as we're removing compatibility mode and we don't currently plan to fix this as we've seen no evidence of it affecting users.


[HOLD] Web - Emoji options/mention options are dismissed on scroll

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Open the app
Open any report
Type in large message to enable scroll
Type @email/phone for mention or :emoji_name for suggestion
Scroll in compose box and observe that cursor is focused at the end of text but mention/emoji suggestion options are closed

Expected Result:
App should not close emoji suggestion/mention options if focus is still on it
Actual Result:
App closes emoji suggestion/mention options on scroll in compose box even though focus is still at the end of text
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[x] MacOS / Chrome / Safari
[ ] MacOS / Desktop

Version Number: 1.3.33-4
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://github.com/Expensify/App/assets/93399543/fc3ec783-308c-4b6a-91e8-f9d3f5570308
https://github.com/Expensify/App/assets/93399543/22fb621e-a774-4471-b299-ad7c06990024
Expensify/Expensify Issue URL:
Issue reported by: GH handle - @dhanashree-sawant
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1687946592585669
View all open jobs on GitHub

This seems intentional and not a bug.
cc @MonilBhavsar

posted in slack clarifying about this flow

reviewing today and posting next steps!

This seems intentional and not a bug.
cc @MonilBhavsar

Sorry, could you please mention the context here?

Hmm, I think we would keep the option menu open. @MonilBhavsar would you agree??

I think current implementation is fine considering the suggestion modal is different element.
We can also go with the implementation like in slack - the modal stays open and overlays the compose box and scroll functionality is disabled while modal is open.
And, in this issue - https://github.com/Expensify/App/issues/16078 we're updating suggestion modals to work inline. So, I think we should keep it on HOLD for that issue.

We're also dealing with this issue  - https://github.com/Expensify/App/issues/15934 where the expected behavior is almost opposite. In that issue, modal stays open after sending the message and we want to close it 😅
We can find the solution that works for both cases

@MonilBhavsar just gut checking! 🙇♂

Yep, can be on HOLD and weekly.

I think https://github.com/Expensify/App/issues/15934 is something different. There, we're sending the message. Here though, we are not sending the message but just scrolling.

@allroundexperts agree, but I think technically they are same - We want to keep/remove focus on the suggestion modal while we're scrolling.

The behaviour here is also inconsistent. If you scroll the chat report, you'll notice that the menu remains open. But if you scroll the composer, the menu closes. I think we should either close the menu when scrolling anywhere or just show it regardless of the scroll. Second option makes more sense to me.

Hmm, To fix both issues and have consistency. I think we should simply disable scrolling when suggestion modal is open. Said other way, suggestion modal element and scroll should not be active or be able to have focus at the same time.

On hold

on hold

Hold

On hold! @MonilBhavsar any idea when we can remove the hold here?

hold!

holddddd

@dylanexpensify updated the title to reflect the parent issue

perfect, still hold

Reviewing!

@MonilBhavsar any updates? 🙇♂ ❤

bump @MonilBhavsar

Sorry, missed previous comment.
We're still holding this issue https://github.com/Expensify/App/issues/15934 on https://github.com/Expensify/App/issues/16078
So, this issue should be on HOLD for https://github.com/Expensify/App/issues/16078. We're waiting for reviews from react-native maintainers

still on hold

same ^

holding

same

holding

same

can still repro, but I don't think this is worth fixing now


Deploy

Did some basic stuff that you guys can see how we can go forward with it

here is my last pull request

how can I deploy it


Promotion Block images & Resizing

This logic on the promotion banner happens after the image is already loaded to the page. So the space isn't saved correctly  - and the maximum dimensions of the images isn't derived from the original image.
Rather than using a spreadsheet for the promotion source, which has limitations, what if we used a doc with promotion-entry blocks structured like:

Promotion Entry

Image
< img >

CTA
< link >

Start
< date >

End
< date >

We can still just link to the word doc and fetch the .plain.html to parse and render the random CTA.
@Kronnox - Thoughts?

Rather than using a spreadsheet for the promotion source, which has limitations, what if we used a doc with promotion-entry blocks structured like

@bstopp I specifically opted for the spreadsheet here, since I vaguely remember they wanted to able to schedule the promotions across the whole site, rather than only for a specific banner. We should ask them again. Another option I implemented in the past is using the spreadsheet to schedule the promotions and using independent word documents for the content, that get loaded as fragments.

This logic on the promotion banner happens after the image is already loaded to the page. So the space isn't saved correctly - and the maximum dimensions of the images isn't derived from the original image.

I'll have a second look on the logic. The way I had it before definitely loaded the original image size as well, but there's some optimization to be done.

Using a word doc instead, also avoids the issue of having to remember to publish all the images for each promotion, since they are self-contained in the word doc.


Add Google Tag Manager to this app

What problem does your feature solve?
This feature will allow SDF to add Google GA4 to the client. We will be able to track engagement and setup custom events on these domains without require future development support.
What would you like to see?
Add this code into the  tag on all pages
`

`
Add this code within the  tag throughout the site:
`

`
What alternatives are there?
Google 365 or Adobe Analytics but we are not using either of those platforms and GA4 is free

@TheLief For certain pages, we may need to add do not track tags. In the past, ran into a vulnerability where seedphrase in the URL where grab by third party analytics app. Need to check the codebase and add do not track tags on the appropriate pages. Moving this to Lab v2 issues.

Do not track:

sign transaction
create account page


Not working?

Hey really sorry to message you
But i have tried everything and i cant seem to get this prefab to work
Im using your demo scene but no damage is being Dealt everything seems to load in properly but when testing it even in game i no damage is given or received
no errors in console, using the latest vrcsdk, udon sharp ect

Ah yeah, unity fucked up the assignment of stuff on the hitboxes so they're
not communicating with the player health script, I'll push a fix out
On Thu, 23 Dec 2021, 17:46 Cart00nHead, @.***> wrote:

Hey really sorry to message you
But i have tried everything and i cant seem to get this prefab to work
Im using your demo scene but no damage is being Dealt everything seems to
load in properly but when testing it even in game i no damage is given or
received
no errors in console, using the latest vrcsdk, udon sharp ect
—
Reply to this email directly, view it on GitHub
https://github.com/Toly65/UdonCombatSystem/issues/3, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AVF6SJ4NWINGSPS4QR6CZL3USNN7JANCNFSM5KVHFCGQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>


Text after # in environment variables is ignored

Bug description
When passing an environment variable which contains a # to a container all the text behing the # is ignored.
Steps to reproduce the issue:

Set x#y as environment variables in a stack  (add it to docker-compose myEnv=${myEnv})
Start the stack
Look at the env's of the now running container/stack. It's just x the #y is missing
Print the env to the container logs, same happens here, so it's not just a UI bug

Technical details:

Portainer version: 2.11.0
Docker version (managed by Portainer): Docker version 20.10.12, build e91ed57
Platform (windows/linux): Raspbian GNU/Linux 10 (buster)
Command used to start Portainer:

docker-compose!
version: '3'
services:
portainer:
image: portainer/portainer-ce:latest
container_name: portainer
restart: unless-stopped
security_opt:
- no-new-privileges:true
volumes:
- /etc/localtime:/etc/localtime:ro
- /var/run/docker.sock:/var/run/docker.sock:ro
- /home/pi/docker/portainer-data:/data
ports:
- 9000:9000

Use Case: Using Portainer at Home.
Have you reviewed our technical documentation and knowledge base? Yes

Additional context
Since # are used for comments in yml files its probably just a wrong contains check then starts with.

Probably also good to know, when editing the env's in a container (and then replacing it) the variable is passed on as intended

@M123-dev
I can confirm the behaviour. Thanks for raising this.


Is there a way to ACL permissions while copying?

add the ACL to the params here
const params = {
      Bucket: destination.bucket,
      Key: destination.key,
      ACL:  'bucket-owner-full-control'
    }
s3.createMultipartUpload(params).promise()


[Fix-14049][dao] fix init sql and use on conflict do update in pg

Purpose of the pull request
fix #14049
fix #14048
fix #14047
Brief change log

fix dolphinscheduler_postgresql.sql
use databaseId choice sql in TriggerRelationMapper.xml

Verify this pull request
This pull request is code cleanup without any test coverage.

LGTM, wait for the CI

Codecov Report

Merging #14051 (7ec3bd1) into dev (0a02522) will decrease coverage by 0.02%.
The diff coverage is n/a.

:exclamation: Current head 7ec3bd1 differs from pull request most recent head ec28901. Consider uploading reports for the commit ec28901 to get more accurate results

@@             Coverage Diff              @@
##                dev   #14051      +/-   ##
============================================
- Coverage     38.20%   38.18%   -0.02%
+ Complexity     4434     4427       -7
============================================
  Files          1220     1220
  Lines         42706    42658      -48
  Branches       4735     4701      -34
============================================
- Hits          16314    16288      -26
+ Misses        24587    24568      -19
+ Partials       1805     1802       -3

see 38 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

restart the failed CI


⚠ Palworld Tunnel (Connection URL) has degraded performance

In 37d8e85, Palworld Tunnel (Connection URL) ($PG_PANEL/tstat.txt) experienced degraded performance:

HTTP code: 200
Response time: 40 ms

Resolved: Palworld Tunnel (Connection URL) performance has improved in 826838f after 11 minutes.


Start page changes (Greek) from research round 3

Now matches the Figma design, ready for UR round 4.

@cevangelougovcy let's hope this works!


Help, article.proto import user.proto, but no return user when i use application/json

Help, article.proto import user.proto, but no return user when i use application/json
and

article.proto

package article.v1;

option go_package = "github.com/hizhc/protobuf/go/article/v1";

import "user/v1/user.proto";

rpc Info(InfoRequest) returns (InfoResponse) {}

message InfoResponse {
  user.v1.User user = 1;
  Article article   = 2;
}

use grpc-web is ok

Client received: user: {
  id: 3
  username: kuan
  nickname: kuan
  phone:<PHONE_NUMBER>0
  email<EMAIL_ADDRESS>  gender: WOMAN
  status: NORMAL
}
article: {
  id: 3
  uid: 3
  title: title3
  content: content3
  status: NORMAL
}

grpcurl is ok

grpcurl -v -d '{"id": 3}'  -plaintext \
  localhost:8082 article.v1.ArticleService.Info

Resolved method descriptor:
rpc Info ( .article.v1.InfoRequest ) returns ( .article.v1.InfoResponse );

Request metadata to send:
(empty)

Response headers received:
content-type: application/grpc

Response contents:
{
  "user": {
    "id": "3",
    "username": "kuan",
    "nickname": "kuan",
    "phone": "17610769360",
    "email"<EMAIL_ADDRESS>    "gender": "WOMAN",
    "status": "NORMAL"
  },
  "article": {
    "id": "3",
    "uid": "3",
    "title": "title3",
    "content": "content3",
    "status": "NORMAL"
  }
}

Response trailers received:
(empty)
Sent 1 request and received 1 response

use application/json https is not

{"article":{"updated_at":0,"title":"title3","uid":3,"id":3,"category_id":0,"created_at":0,"status":"NORMAL","content":"content3"},"user":{}}

user is empty

run in docker

Hi @isfk,
Did you find the cause of the issue? If so, please share, as we have created an internal ticket to look into this.
Thanks!

@gszr sorry, I haven't found the reason yet.

@gszr  And, sometimes user is ok, but most of the time it's empty


8.0 update SignalR config: withServerTimeout, withKeepAliveInterval

Internal Review:  Version 8.0 Client Timeout and keep-alive Options section: .NET & JavaScript tabs
Fixes #29717
8.0 updates of SingnalR configuration for withServerTimeout and with withKeepAliveInterval.

Internal previews

📄 File
🔗 Preview link

aspnetcore/signalr/configuration.md
ASP.NET Core SignalR configuration

Thanks for the great feedback.  Sorry Brennan I had messed up the fix originally.  I will go ahead and merge.


Plotly barplot

Make barplots with plotly for results (now all the plots will render nicely).
Below see how it renders. To the left is the old behavior (still accessible when plotly=False: this is not a capture of the website but a capture of the "make" page with plotly=False, it is exactly as before even with the changes made to adapt with plotly). To the right is with plotly=True.

is it doable to put the "do not converge" inside the bar rather than overlapping at the top?

actually the second plot does what I had in mind. Why did you share 2 plots?

actually the second plot does what I had in mind. Why did you share 2 plots?

I showed two plots exactly because of the "Do not converge". Using the exact same way to get the coordinates of the text, sometimes it gets at the top and sometimes in the middle (which was what I first intended to do and still would like to do...)

Ok then let’s wait and try to fix it. If it is a pain we can postpone

Fixed it for plotly (and the code is simplified  by doing so).

And to finish, this fixes the "Did not converge" position with Matplotlib. It's all good now.

Codecov Report

Merging #126 (30cc71c) into master (e99b083) will decrease coverage by 0.68%.
The diff coverage is 60.46%.

@@            Coverage Diff             @@
##           master     #126      +/-   ##
==========================================
- Coverage   74.45%   73.76%   -0.69%
==========================================
  Files          28       28
  Lines        1190     1216      +26
  Branches      180      190      +10
==========================================
+ Hits          886      897      +11
- Misses        243      255      +12
- Partials       61       64       +3

also bonus you could see how to add the plotly plots to the website as explained in https://sphinx-gallery.github.io/dev/auto_examples/plot_9_plotly.html
but maybe for the next PR ;)

Sure, I'll look into that when I get the time to do so.

Failure is unrelated to the PR. It is caused by an update in celer master that will be removed from the CI in #131 .
Merging this one.

Failure is unrelated to the PR. It is caused by an update in celer master that will be removed from the CI in #131 .
Merging this one.


Refactor Duplicated Error Handling Code in Append Transaction Executions Response

Why
The current implementation contains repetitive code patterns for handling errors and generating responses in the AppendTransactionExecutionsResponse. This duplication makes the code harder to maintain, more error-prone, and less readable. By refactoring, we can improve code quality, maintainability, and readability.

We've shelved raft for now, closing.


[Compability Request] GregTech Community Edition Rubber Tree

I'd like to ask you for compability addon for GTCE rubber tree. Unfortunately I don't have any experience in mod making so I have no idea how to make that addon. Please let me know if it could be done, added to to-do or not at all, thank you!

Please see #443 for add-on requests. These shouldn’t be opened here.


Feature/dotnet test by project

Implements feature for issue #52 which allows users to run all test suites in the solution one-by-one, to force serial execution.
Additional notes:

Leveraged spawnSync from the child_process module vs. standard spawn, since we want to enforce the test runner to run each project in isolation instead of in parallel.

This method has a different signature which requires breaking out dotnet from each following argument or flag such as test, --no-build, etc.

Updated the original runBySolution method to include the coverage flags in the output message so we know 100% what command is being run by the CLI for any debugging purposes vs. running the dotnet command directly.
Added a ternary check for the signal arg in the spawn exit callback which was generally coming back null, which will default to the status code in the output message
Although originally noted in the issue, I did not write tests for the sake of time and due to CI not being setup yet. We can create an additional issue to back-fill tests once TravisCI is properly integrated.

@wintondeshong This should be ready for re-review. I added a --ci flag and modified the output to be streaming/captured depending on which mode you are in as we discussed the other day. Plus, some minor refactoring to pull the big callback into its own method and utilize map() instead.


Added NavigationTransitionInfo override to NavigationService.GoBack()

this is in response to Issue #1074
please check if I have done anything wrong.

Cool, I need you to not include the Help file, the Build.DLL, and I need to you to update the INavigationService definition. Also, you need to make the parameter optional. Not everyone will need info. Make sense?

made a new pull request
#1087


Support iOS simulator

When trying to build the NMSSH library for an iPad simulator we get the error
message:

ld: in /Users/daonb/src/NMSSH/NMSSH-iOS/Libraries/lib/libssh2.a(agent.o), building for iOS Simulator, but linking in object file built for iOS, for architecture arm64

Hello, I was going to take a jab at #3 because its issuehunt bounty seemed attractive. Having a look at that I have seen this issue and tried my hand at this and come up with how this would work with the involvement of iSSH2/NMSSHT7 and this repository.
Ionic, Capacitor et al. are kind of dead. I do not know if you are still maintaining this and if the bounty for #3 still holds.

Thanks for reaching out. The bounty still hold as I need this plugin to work on the simulator. You're right it involves NMSSHT7 which is also controlled by me and I'd welcome your PR.
I wonder what made you thing capacitor is dead? If anything it changes too rapidly and occasionally break their API.

I meant "dead" in the sense that it does not have the buzz it used to have. But let's not derail from the topic.
So here is the gist of the problem:

We are running into this problem mainly because of M1. Issue on iSSH2 (which creates the binaries for libssh2, libssl and libcrypto) here. The first step for a clean solution would be actually distinguishing here between iphoneos and iphonesimulator as two different platforms (as that is what they are). However, that might mean that instead of depending single archive files (such as this), we now might have to depend on xcframeworks as we live in a multiplatform/multiarchitecture world now.
Second leg of the problem is NMSST7 also has to be an xcframework that is easier as it is it is just a podfile + custom build script change.
The third leg is bringing these together in this plugin.

Have a look at this proposal and if you like it I can start working on this. If iSSH2 is not receptive to the change we want to make we can get the prebuilt xcframeworks from somewhere else or build them ourselves forking the library. How does it sound?
Cheers.

I've did some research and I'm not sure we can replace the podfile as capacitor needs it.

I think you have misunderstood me. podfile is necessary and okay. What is wrong is the original NMSSH library was vendoring binary files along with the library itself which is a horrible way to distribute software. I proposed to change that. Was busy with work. Will try to create an initial fix for the NMSSHT7 today.


Websocket sandbox test is flakey

description
The websocket test fail on some PRs for  no immediately discernible  reason
example failing logs (copied from slack)
2021-02-04T11:03:38.1149607Z > [tls] Interact with web socket ws -> ws
2021-02-04T11:03:38.3143654Z spawn docker run --rm -ti --network=host solsson/websocat ws://localhost:10000
2021-02-04T11:03:38.5956163Z websocat: WebSocketError: I/O failure
2021-02-04T11:03:38.5957714Z websocat: error running
2021-02-04T11:03:38.5967854Z HELO
2021-02-04T11:03:38.6510123Z send: spawn id exp3 not open
2021-02-04T11:03:38.6511546Z     while executing
2021-02-04T11:03:38.6512455Z "send \x03"
2021-02-04T11:03:38.6542212Z
2021-02-04T11:03:38.6543324Z > [tls] Cleanup (.)

PRs known to have failing tests #14907 #14915

possible related https://github.com/vi/websocat/issues/23#issuecomment-545410643


Add netlify for docs preview

I would like to add previews for doc changes just like we have it on the website.

@inventree/maintainer @inventree/triage thoughts?

Previews are available when posting PR no? RTD build provides a temporary URL

I did not know/remember that; thanks for the tip.


[Bug] name/class properties need to be validated [sf#30]

Reported by crazyinsomniac on 2003-07-01 20:18 UTC
A user
can enter anything for
Name:
Class:
properties.
They need to be validated.
At first I thought each generator
should register a validator somehow,
but that would get messy,
so I think we should just have universal validators
that only accept names matching
^[a-zA-Z][a-zA-Z0-9_]+$
I'm not sure if this can be done using
wxTextValidator (it doesn't look like you can specify
begins with this charlist)

Commented by agriggio on 2003-07-02 09:17 UTC
Logged In: YES
user_id=375945
I agree they need to be validated, but class should also
accept qualified (i.e. with package specification) names, so
the regex should be something like:
^[a-zA-Z][\w.:]+$ (untested)
As for wxValidators, I've never used them actually, but I'll
have a look.


Support namespaced operator config

Adds support for namespaced configs to EnsureOperatorConfigExists

I don't think this is a goal.  All the use-cases we have for our SLOs so far deal with either single items or highly privileged items.  If we go to unprivileged or many items, we won't be auto-creating anyway.


Added 'Windows 11' to the allowed list

Added 'Windows 11' alongside Windows 10 - I tested this functionality. #ATCP

@lukemurraynz : Thanks for your contribution! The author(s) have been notified to review your proposed change.

#label:"aq-pr-triaged"

#sign-off


downstream_sites = T in queryFlowlines()

For reasons unknown, when I run queryFlowlines() with dwn_flw = T, I'm receiving the error Error in FUN(X[[i]], ...) : !anyNA(x) is not TRUE which was running in recent weeks just fine. When I set dwn_flw = F I do not get that error. I have verified that every site in sites_sf has a lat/lon and verified that I'm using the same downstream sites as previously.
It's fine for now, because I'm building my parent-child table for downstream sites manually at the moment, but I am unable to download the downstream flowlines currently, which just creates less than ideal maps :)

@mackerman44 , do you have an example of which sites your using, or a snippet of code to share that would help me try to replicate that error?
-Kevin

@mackerman44 , can you also confirm what version of the nhdplusTools package you're running?

I also just made one fix to queryFlowlines() that was throwing an error when querying downstream flowlines when the buffer_dist was set to 0, which is the default. So that might be what was causing your error @mackerman44 . Could you doublecheck if the new function in the develop branch has fixed your issue?

@KevinSee I am using the sites_sf object within "data/configuration/sites_config_LGR_20231026.rda" in the mackerman44/SnakeRiverPopStatus repo.
load(here("data/configuration_files/site_config_LGR_20231026.rda"))
and running the following...
dwn_flw = T # do you want flowlines downstream of root site? Set to TRUE if you have downstream sites
nhd_list = queryFlowlines(sites_sf = sites_sf,
root_site_code = "LGR",
min_strm_order = 2,
dwnstrm_sites = dwn_flw,
dwn_min_stream_order_diff = 4)
And I am using version 1.0.0 of nhdPlusTools. I will update PITcleanr shortly and re-test.

@KevinSee Not sure what you did, but queryFlowlines() was able to download the flowlines downstream of LGR this morning, just fine. I'll leave this issue open for now in case you want to explore the issue a bit further using the sites_sf object in SnakeRiverPopStatus.

I don't think I have access to the SnakeRiverPopStatus repo, but I did use load this Rdata file from the SRB_OncorPopStatus repo:
data/configuration_files/site_config_LGR_20231012.rda, and I was able to download flowlines using the sites_sf object in there, including downstream ones. Based on that, I'm going to go ahead and close this issue.


Zafira: "Create" button looks active and has a green color when you create a user and enter invalid values in the registration fields

Expected result:
“Create” button looks inactive and has a gray color when you create a user and enter invalid values in the registration fields

Fixed


Code navigation for files under open project

It looks like Go To Definition  and similar features only works for files which are added to the MATLAB path. When I open a project at VSCode, not all my projects files are added to path at startup, and it is not possible for code navigation actions.

It would be nice to automatically add files under my open project into path for code navigation. A project root maybe detected by .git or MATLAB project folder.

Thanks for raising this request! I believe this is the same as #98, so I am closing this as a duplicate of that issue.


Implementation of generic storage equations

This PR is to summarize suggestions collected through discussions with @adrivinca and @JulianHunt4 in the issue https://github.com/iiasa/message_ix/issues/162 for representing storage equations explicitly in the model. The concept and parameters presented in this PR are illustrated in the picture below (for more info, please see the accompanying documentation in this PR):

This PR has done the following:

[x] Tests Added
[x] Documentation Added
[x] Description in RELEASE_NOTES.md Added

I created a document to illustrate the storage concept presented in this PR and discuss the new equations suggested to be added to the model. I put it under a "temporary" folder in the doc folder. Please feel free to put in the right place.

Thanks @behnam2015 for the PR, I only have some comments and suggestions on the GAMS side.
period_parameter_assignment.gms
I tried the model with different naming for the time elements (i.e non alphabetic order and with different numbers of letters) and there are two problems.
On the Python side, list(set(seasons_dict.keys())) is re-ordering the set alphabetically, this should not happen, so that one can have seasons like winter, summer and so on.
Fixing that (but I did it hard coding), then the new ordering is correct on the GAMS side.
However, I would suggest making time_seq a set and defining some basic sets that can be helpful in the future, such as first_time(time) last_time(time).
This is an example (not tested), but if we agree I can push changes to your branch:
Sets
first_time(time)
last_time(time)
;

first_time(time)$( ORD(time)$time_seq(time) = 1) = yes ;
last_time(time)$( ORD(time)$time_seq(time) = CARD(time_seq(time) ) = yes ;

* mapping of first and last time steps in a period AV
map_time_first_last(year_all,year_all2,time,time2)$( ( ORD(year_all) = ORD(year_all2)) AND
    first_time(time) AND  last_time(time) ) = yes;

Concerning STORAGE_CHANGE  equation, if the level_storage is always different from the normal commodity levels (e.g charger output = discharger input but different than charger input) then we don't need all the charger and discharger mappings and we can write a single line:
STORAGE_CHANGE(node,storage_tec,level,year,time)$( SUM( (mode,tec,commodity), map_tec_storage_level(node,tec,storage_tec,level,year,time) AND
    (map_tec_charge(node,tec,mode,commodity,level,year,time) OR map_tec_discharge(node,tec,mode,commodity,level,year,time) ) ) )..
* change in the content of storage in the examined timestep
    STORAGE_CHG(node,storage_tec,level,year,time) =E=
* increase in the content of storage due to the activity of charging technologies - decrease due to discharging
        SUM((location,vintage,mode,tec,commodity,time2)$(map_tec_lifetime(node,tec,vintage,year) AND ) AND map_tec_storage_level(node,tec,storage_tec,level,year,time) ),
      (  output(location,tec,vintage,year,mode,node,commodity,level,time2,time) - input(location,tec,vintage,year,mode,node,commodity,level,time2,time) ) * ACT(location,tec,vintage,year,mode,time) )

but if we don't want to be so strict, and keep a level of freedom, I think the current implementation is ok.
in STORAGE_BALANCE Eq the if condition should not be with storage_loss otherwise the equation does not work then no losses is defined, probably map_tec_storage_level works well
Finally bound_storage_up and lo have the should have the same indexes as the STORAGE variable.
So we should decide whether keeping the commodity index in STORAGE or removing it from the boundary parameters
if we agree on some of these points I can also contribute to the code

Thank @gidden for the feedback and useful suggestions. I will move the documentation to the GAMS files as soon as we are happy with the final equations.
As for STORAGE_EQUALITY, based on the feedback from you and others, I replaced this with an optional RELATION_STORAGE that can relate the content of storage between two time steps (and even between two periods). This is now represented as an inaquality to be more flexible (instead of equality). I will continue improving the PR if you have further thoughts.

Thanks a lot @adrivinca for feedback and suggestions. I try to address them one by one:

related to period_parameter_assignment and time_seq, I'm quite open if we decide to go for a set for adding the time order. Now, after removing `STORAGE_EQUALITY' we don't need to specify or map the first and last time steps anymore.
related to list(set(seasons_dict.keys())), the order doesn't affect the results, as the duration will be specified for each time step directly, and this is only for the test_storage.py. I modified the test to sort the time steps alphabetically, but if a user wants to use this test for declaring other time names, they should do that explicitly, and not through dict.keys().
related to 'STORAGE_BALANCE', it is now mapped based on map_tec_storage_level.
_ commodity was removed from the bounds and storage_loss.
Please have a look again and suggest improvements if needed.

Hi all - just getting back and catching up. @behnam2015, does this need another review now?

@gidden, nothing from my side, @adrivinca may want to suggest some additions.

Hi folks, it looks like we have some conflicts in the GAMS code. I would suggest @behnam2015 @adrivinca and @danielhuppmann decide whether this is worth trying to get into the next release or should be a first PR into master after the release is finalized. I'm happy either way if all agree.

Thanks @gidden! I rebased and resloved the GAMS related conflicts. Also I modified the equations for the following changes:

Shifting commodity between two sub-annual time steps that are only in one temporal level
Initialization of storage (adding free content at any time step needed), follwoing discussions with @adrivinca and @JulianHunt4

@danielhuppmann can you please take a look at the GAMS code here to make sure it is in line with our preferred style/syntax? Also, specifically at 90faefe which adjust test_legacy_scenario.py?

@khaeru, the tests in this PR fail because the new sets and parameters defined here are not initialized. Before rebasing this initialization was done in core.py. Should we wait for the PR ixmp#122 before refactoring the initialization here?

Rebased now that iiasa/ixmp#212 is merged.

@khaeru, thanks editing model.py for new sets and parameters in this PR. Looking at the failed tests, it seems whenever a scenario is cloned in tests, the test is failing. In other words, cloning doesn't include the initialization of new sets and parameters. Because of that the cloned scenario fails to solve. Have you tested this in ixmp.Model.initialize_items()?

Looking at the failed tests here, it seems whenever a scenario is cloned in a test, the test is failing. In other words, cloning a scenario doesn't include the initialization of new sets and parameters introduced in this PR through model.py. Because of that the cloned scenario fails to solve.

Thanks for investigating and diagnosing. That's a good catch.

Have you tested this behaviour in ixmp.Model.initialize_items()?

No. To explain, the message_ix.Scenario.clone behaviour is, for now, implemented in the closed-source Java code behind ixmp.JDBCBackend.
Intuitively (I think) cloning any Scenario (either ixmp.Scenario or message_ix.Scenario) should copy all of its contents.
However, the Java code (see here) does a lot of other stuff, most of which is not publicly documented. In the process, I worry that it may be using some internal/hidden list, and throwing away items (parameters) that are not in that list—such as the ones added by this PR.
This kind of issue is why we have #254. To use our analogy of the messy closet, I think you have identified that my pulling out iiasa/ixmp#212 caused something else to fall on the floor, which we must now pick up.
What I can do is:

Make a small, separate PR that tests whether the Java clone code is excluding some data.
Move the 'special' message_ix clone behaviour out of Java into Python, and then fix it so it doesn't do this.

@danielhuppmann and @zikolach know the Java code best, so might be able to confirm (1).

@khaeru thanks for the detailed reply. I may have missed something here. When this PR was made initially, it could pass the tests. At that time, the initialization of new items (sets and parameters) of this PR was handled in message_ix.core.py. The idea was that when initiating a MESSAGE scenario (either by loading an existing one and cloning, or creating a new one) a function in core.py would initialize the new items and scenario was solved without a problem. This meant to me the backend didn't filter any parameter/set names, as the GDX from the scenario was passed to GAMS with the new items. In fact, this function in core.py, now in model.py, for adding new items work as an interim solution until the PR is accepted. After accpeting PR, these new items cacn be added to any default list, either in python or backend, which is your concern I guess.

@khaeru, to address the remaining issues here, I still can't pass the tests in which a scenario is cloned. It seems the changes you suggested in message_ix.models.py under this PR, i.e., the initialization of new sets and parameters specific to this PR, is applied only when a new scenario is initialized. However, these new sets and parameters are not added to a scenario if cloned from an old one. This is the case in test_solve_legacy_scenario and test_macro. can you please have a look?

@khaeru, to address the remaining issues here, I still can't pass the tests in which a scenario is cloned. It seems the changes you suggested in message_ix.models.py under this PR, i.e., the initialization of new sets and parameters specific to this PR, is applied only when a new scenario is initialized. However, these new sets and parameters are not added to a scenario if cloned from an old one. This is the case in test_solve_legacy_scenario and test_macro. can you please have a look?

Yes, will do. Thanks for the summary!

FYI all, I rebased this branch on master and cleaned up duplicate commits. It's down from 77 to 39 commits.

thanks all for pushing this forward.
I went through the implementation again. form the GAMS point of view I think it is fine to merge.
Only have minor comments on things that perhaps could be simplify:

What is a practical use-case for the STORAGE_RELATION, has it ever been used and tested? if not, I would keep it out for the moment

does the mapping set map_tec_storage_level(node,tec,storage_tec,level,year,time) need to have all those dimensions? I think mapping sets should be as simple as possible, so if we map a technology to a level, are there reasons why this mapping would differ by node, year and time?
if not I would edit those sets, and check it does not break the if conditions.

I did not have time to work on a tutorial, but interested in it

Thanks @adrivinca for the review. I made some cleanup and removed some extra mappings.

I combined map_tec_storage_level with map_tec_storage and removed indexes of time and year. But it's useful to map storage technologies with the level and commodity of storage.
I removed extra sets and mappings, incl. charge_tec, discharge_tec, map_charge_tec, and map_discharge_tec.
I removed bound_storage_lo and _bound_storage_up, and related the state of charge of storage (STORAGE) to activity of the corresponding technology. This way we can use the available bounds in current formulation.
STORAGE_RELATION is used to relate the state of charge in two different time steps. It can be used, for example, to specify that the content at the last time step should be greater than 40% of initial value. The use of this parameter is optional.
I improved the documentation for clarity, and improved the tests to reflect these changes.

Per discussion in today's MESSAGE meeting:

[ ] @khaeru: address failure of test_legacy_version.
[ ] @francescolovat: review/copyedit documentation of new sets and parameters.

[ ] @khaeru: address failure of test_legacy_version.

@behnam-zakeri I had to make the modifications in iiasa/ixmp#315 in order to resolve this. Can you (1) please check that the code there, in combination with this branch, allows test_legacy_version to pass (it does for me), and (2) if so, leave an approving review there?
Thanks!

@behnam-zakeri I had to make the modifications in [iiasa/ixmp#315] ... Can you (1) please check that the code there, in combination with this branch, allows test_legacy_version to pass (it does for me), and (2) if so, leave an approving review there?

Thanks @khaeru for resolving this. Yes, both tests (storage and legacy) pass after these changes.

Unfortunately a test from message_ix/tests/test_tutorials.py::test_tutorial[austria_multiple_policies-answers] from the MacOS image is still failing

@francescolovat good catch—see further down at line 1827:
com.zaxxer.hikari.pool.HikariPool.PoolInitializationException: com.zaxxer.hikari.pool.HikariPool$PoolInitializationException: Failed to initialize pool: Database lock acquisition failure: lockFile: org.hsqldb.persist.LockFile@5035d5ba[file =/private/var/folders/nz/vv4_9tw56nv9k3tkvyszvwg80000gn/T/pytest-of-travis/pytest-0/localdb/default.lck, exists=true, locked=false, valid=false, ] method: checkHeartbeat read: 2020-04-30 15:54:05 heartbeat - read: -9763 ms.
com.zaxxer.hikari.pool.HikariPool.PoolInitializationException: com.zaxxer.hikari.pool.HikariPool$PoolInitializationException: Failed to initialize pool: Database lock acquisition failure: lockFile: org.hsqldb.persist.LockFile@5035d5ba[file =/private/var/folders/nz/vv4_9tw56nv9k3tkvyszvwg80000gn/T/pytest-of-travis/pytest-0/localdb/default.lck, exists=true, locked=false, valid=false, ] method: checkHeartbeat read: 2020-04-30 15:54:05 heartbeat - read: -9763 ms.

This is a failure in the Java database layer that happens randomly once in a while; it is spurious (doesn't signal a code error). I will restart this job.

Ok @khaeru thanks! 🙂

Thanks @francescolovat for organizing the documentation very nicely and @khaeru for imprving the model initialization workflow. I have no further additions or edits.


add org.stellar.sdk.CurrencyPairManageOfferOperation

Hacked/built the updated java stellar-jdk jar file and copied it into backend_api, see https://github.com/quantadex/backend_api/pull/9


Avoid storing the cache in some situations

Description
Fix existing tests
The run() function in src/restore.ts was run twice when a test is run. Once because lib/restore is imported into the test so it runs automatically, and once because the restore file is executed from the test.
Removed the wait commands. I think those were there to wait for the run() function which is imported through lib/restore to complete. Removing the import removes the need to wait.
Merged the two tests into one test. The save action requires that the restore action was already run once, othewise it doesn't find the buildcache binary. I think it is better to execute the restore code in the test, and avoid importing lib/restore. This is also doing the same thing as a real build would do, instead of running the save code in a "fake" restored state in the tests.
Avoid storing the cache in some situations
Avoid storing the cache if it is empty. This might be because the job failed to download the cache, or because the job was cancelled before downloading the cache. In this case, creating a new empty cache will ruin it for the next job.
Avoid storing the cache if there was no change. This improves the run time of the job and it also avoids storing multiple identical caches.
Add option to skip storing of caches. This can be used in jobs that are only run on PR branches, where the cache will never be used by anyone.

I just did some build performance / cache work recently so I'm recently sensitized to useless cache stores myself :smile:

https://github.com/ankidroid/Anki-Android/pull/11032
https://gist.github.com/mikehardy/f076172f3b28826898c55dc03fe202de

So I think the feature is worthwhile, yes

I think we may assume that actions/cache is working, so mocking sounds right, then you don't have to worry about external stuff, except the buildcache binary itself
unsure how to make buildcache return different stuff, I suppose you'd have to set up a specific cache directory for test that was clean/empty (and maybe run the clear + zero stats commands to verify) then do some trivial build to make sure first run was all miss, then run same trivial build to make sure it was all hit, and both were parsed?

Brainstorming warning, all ideas highly suspect. Your initial code was great though except my plea for testing ;-), so I'm guessing whatever you come up with will make sense...

prettier check tripped up on something :thinking:

prettier check tripped up on something 🤔

Fixed it

@johanblumenberg I'm really sorry this is such a slow process, I've been busy, and I really appreciate your patience. Looks like the build-test / build action is failing now :thinking: https://github.com/mikehardy/buildcache-action/runs/7046648693?check_suite_focus=true

@johanblumenberg I'm really sorry this is such a slow process, I've been busy, and I really appreciate your patience. Looks like the build-test / build action is failing now 🤔 https://github.com/mikehardy/buildcache-action/runs/7046648693?check_suite_focus=true

It runs OK when I run locally. I suspect that the problem might be that when running on github it will download the cache from the previous run, so it's not always running on a clean cache. But I haven't had time to look into it.

@mikehardy It looks like this is the failue:
    ENOENT: no such file or directory, mkdir '/home/runner/work/buildcache-action/buildcache-action/__tests__/runner/WORKSPACE'
      25 |   rimraf.sync(ghWorkspace)
      26 |
    > 27 |   fs.mkdirSync(ghWorkspace)
         |      ^
      28 | })

The __tests__/runner folder doesn't exist in a clean clone. I changed it to recursively create the folder.

Fantastic! developer to developer I feel like this was more arduous than it needed to be, with the testing issues prior to your work and then the slow responses - apologies for that but thanks for sticking with it. Packing this up for a release now!


IP Bind Error on v0.5.0.post1

Using the same forum.As I am encountering the same error on 0.5.0.post1 version.
I am launching  openai.api server using the following command and consistently seeing the IP-Bind error. It works on 0.4.2 version which is my current image. I am looking to upgrade to newer vllm version to access features/fixes that were failing on earlier version.
CMD="python -u -m vllm.entrypoints.openai.api_server \
        -- host <IP_ADDRESS> \
         --port $VLLM_PORT \
        --model $launch_model \
        --tensor-parallel-size $NUM_GPUS \
        --download-dir /data"

Error:
ERROR:    [Errno 98] error while attempting to bind on address ('<IP_ADDRESS>', 9000): address already in use

Appreciate any help  with this.
Originally posted by @pchunduru10 in https://github.com/vllm-project/vllm/issues/1141#issuecomment-2192256236

That port is already used. You need to change the value of VLLM_PORT .

I have tried bunch of different ports, none of them worked so far.

you can talk with your admin to see if there's any firewall rules

I am able to access them on 0.4.2, so wondering what has changed with 0.5.0 and post1 version. Since nothing on my side has changed wrt to firewall.

I am able to access them on 0.4.2, so wondering what has changed with 0.5.0 and post1 version. Since nothing on my side has changed wrt to firewall.

oh, VLLM_PORT is actually not the port the server will listen on, it is another environment variable that determines the port vllm uses for internal communication. see https://docs.vllm.ai/en/latest/serving/env_vars.html for details.
You need to change the env name.

Are the not the cli args for host and port  CLI-ARGS

--port is a cli arg
VLLM_PORT is a reserved env var used by vLLM.

I am setting a local env called VLLM_PORT in my docker container , so its essentially just passing the value to the VLLM instance/api-server, something like this:
python -u -m vllm.entrypoints.openai.api_server         --host <IP_ADDRESS>         --port 9000

the local env called VLLM_PORT conflicts with vLLM. please use another name.

Yes it worked ! So its the conflict with defined ENV name. Thanks much !

@youkaichao do you think we should update our internal ENV variable names to be a bit less likely to conflict with user environment variables?

e.g. something like VLLM_SYS_{EXISTING_NAME}

That's too much maintenance burden. I prefer to warn users that they should use another prefix to avoid conflict.

In case someone else runs into this on Kubernetes:
Don't name the service targeting your vLLM pods vllm as this is cause variables like VLLM_PORT to be set by the Kubelet
https://kubernetes.io/docs/concepts/services-networking/service/#environment-variables

@frittentheke thanks for the report, updated the doc at https://github.com/vllm-project/vllm/pull/5916

oh, VLLM_PORT is actually not the port the server will listen on, it is another environment variable that determines the port vllm uses for internal communication. see docs.vllm.ai/en/latest/serving/env_vars.html for details.
You need to change the env name.

Thank you @youkaichao. This saves my day.


Jis new layout fonts

Metanorma PR checklist

[ ] Breaking changes (list related PRs)
[ ] Documentation update required (create task for this)
[ ] External dependency introduced (documentation update need)
[ ] Gem with native library introduced

From the linked issue: @intelligent2013 , do we need to specify Noto Serif JP Bold explicitly? Just specifying Noto Serif JP should be fetching the entire family.

@opoudjis yes, you are right. Noto Serif JP is enough. Actually fontist installs both Regular and Both by the request Noto Serif JP. Initially, when I've started to add the required fonts, I've added the font Noto Serif JP ExtraLight and thought that each 'weight' should be added separaterely.
Ok, the fonts list updated in https://github.com/metanorma/metanorma-jis/pull/236.


updated some old libraries

upgraded deprecated libraries - bodyParser and method-override
upgraded to Font Awesome 4 which is issue #167

but I couldn't find any icons using font-awesome.

@hoony thanks - i'd somehow missed this. reviewing now.


CSL capitalisations

I have found a bug in the CSLs such that some records have first letter capitalisations or all caps in the title.
I am using the following CSL in our PrimoVE instance (Murdoch University, Australia):

apa-cv
chicago-author-date
chicago-note-bibliography
modern-language-association
australian-guide-to-legal-citation
vancouver
american-chemical society
ieee

Both books and articles are affected. The examples below are in APA, but I also checked them in the other citation styles and in most of them, the capitalisation of the title seems to be consistent and inherited from the source data (especially the all caps one).
Fisher, A. D., April, M. D., Naylor, J. F., Kotwal, R. S., & Schauer, S. G. (2021). The Battalion Aid Station—The Forgotten Frontier of the Army Health System During the Global War on Terrorism. Military Medicine. https://doi.org/10.1093/milmed/usab401
https://librarysearch.murdoch.edu.au/permalink/61MUN_INST/3bciql/cdi_proquest_miscellaneous_2582809655
Melanson, M., & Bower, M. (2011). THE ROLE OF THE ARMY NUCLEAR MEDICAL SCIENCE OFFICER IN THE GLOBAL WAR ON TERRORISM. Health Physics (1958), 101(1), S78–S78.
https://librarysearch.murdoch.edu.au/permalink/61MUN_INST/3bciql/cdi_proquest_miscellaneous_902382635
Moore, A. (2019). Empire’s Labor The Global Army That Supports U.S. Wars. Cornell University Press. https://doi.org/10.7591/9781501716393
https://librarysearch.murdoch.edu.au/permalink/61MUN_INST/1r6on8i/alma991005438684007891
Ramos, B., Miller, F. A., Brandão, T. R. S., Teixeira, P., & Silva, C. L. M. (2013). Fresh fruits and vegetables—An overview on applied methodologies to improve its quality and safety. Innovative Food Science & Emerging Technologies, 20, 1–15. https://doi.org/10.1016/j.ifset.2013.07.002
Schneid, F. C. (2012). The projection and limitations of imperial powers, 1618-1850. Brill.
https://librarysearch.murdoch.edu.au/permalink/61MUN_INST/1r6on8i/alma991005511866207891
For example, in APA, only the first letter of a title/subtitle should be capitalised, as well as proper nouns. However, as can be seen, there is a variety of outputs which indicates that the capitalisation script does not seem to be working consistently. In particular, for the last one on the list, the APA citation has only the first word capitalise, but the other styles (Chicago etc.) have every word capitalised.
I am not sure which version of citeproc-java is being used, but was referred here by Ex Libris. But you should be able to test in our live PrimoVE environment without a login as the citation system is open to the public.
Regards,
Bryan Chan
Librarian, Digital Applications
Library and Knowledge Services
Murdoch University

The APA style does not specify any text-case attribute for the title. You can see that yourself if you look at the source code and search for variable="title":
https://github.com/citation-style-language/styles/blob/master/apa.csl
None of the occurrences contain a text-case attribute. This means that citeproc-java will not do any text transformation and the title will be used as is.
I've double-checked this with Zotero, which can generate a citation preview for various styles. Here's the result:

As you can see, even in Zotero the title is used as is.
I'm closing this issue as it is not a bug. A proper title-case algorithm has already been implemented in the latest version of citeproc-java and it will be applied if there is a text-case attribute defined in the style. If you still experience problems with other styles, I recommend updating. The latest version works correctly according to the CSL specification.


Weapon Assets

Produce assets for two main currently planned weapons:

melee weapon
melee animation
ranged weapon
ranged weapon animation
ranged weapon projectile

Implemented


pyodbc.DataError: Conversion failed when converting da te and/or time from character string

I get the following error when I try to create a superuser. Following is the like of code that it tells me which has the error.
  File "D:\path\virtual_venv\lib\site-packages\django_pyodbc\base.py", line 489, in execute
    return self.cursor.execute(sql, params)
pyodbc.DataError: ('22007', '[22007] [Microsoft][ODBC SQL Server Driver][SQL Server]Conversion failed when converting da
te and/or time from character string. (241) (SQLExecDirectW)')

I hope someone can let me know the solution for this problem.

solved by querying raw request on model, works fine. Fix this would be useful


merge latest master to soroban-xdr-next-next

PR Checklist
PR Structure

[x] This PR has reasonably narrow scope (if not, break it down into smaller PRs).
[x] This PR avoids mixing refactoring changes with feature changes (split into two PRs
otherwise).
[x] This PR's title starts with name of package that is most changed in the PR, ex.
services/friendbot, or all or doc if the changes are broad or impact many
packages.

Thoroughness

[ ] This PR adds tests for the most critical parts of the new functionality or fixes.
[ ] I've updated any docs (developer docs, .md
files, etc... affected by this change). Take a look in the docs folder for a given service,
like this one.

Release planning

[ ] I've updated the relevant CHANGELOG (here for Horizon) if
needed with deprecations, added features, breaking changes, and DB schema changes.
[ ] I've decided if this PR requires a new major/minor version according to
semver, or if it's mainly a patch change. The PR is targeted at the next
release branch if it's not a patch change.

What
port latest master soroban next-next
Why
has minor fixes for pinning go versions.
Known limitations

not sure if the following is a merge conflict or not: ( taken from one of the GHA )
mock: Unexpected Method Call
-----------------------------

Begin(*context.emptyCtx)
		0: (*context.emptyCtx)(0xc000044198)

The closest call I have is:

Begin()

Provided 0 arguments, mocked for 1 arguments
Diff: 0: FAIL:  (*context.emptyCtx=context.Background) != (Missing)

goroutine 849 [running]:
github.com/stretchr/testify/mock.(*Mock).fail(0xc0000d6a00, {0x18c78f0, 0x6f}, {0xc00128a980, 0x4, 0x4})
	/home/runner/go/pkg/mod/github.com/stretchr/testify@v1.7.0/mock/mock.go:254 +0x1db
github.com/stretchr/testify/mock.(*Mock).MethodCalled(0xc0000d6a00, {0x24ab14a, 0x5}, {0xc001277670, 0x1, 0x1})
	/home/runner/go/pkg/mod/github.com/stretchr/testify@v1.7.0/mock/mock.go:411 +0x698
github.com/stretchr/testify/mock.(*Mock).Called(0x0?, {0xc001277670, 0x1, 0x1})
	/home/runner/go/pkg/mod/github.com/stretchr/testify@v1.7.0/mock/mock.go:383 +0x1a5
github.com/stellar/go/services/horizon/internal/ingest.(*mockDBQ).Begin(0xc0000d6a00, {0x22b0a10?, 0xc000044198})
	/home/runner/work/go/go/services/horizon/internal/ingest/main_test.go:307 +0xbb
github.com/stellar/go/services/horizon/internal/ingest.buildState.run({0x4a97fb?, 0x0?, 0x0?}, 0xc000134b40)
	/home/runner/work/go/go/services/horizon/internal/ingest/fsm.go:305 +0xbd1
github.com/stellar/go/services/horizon/internal/ingest.(*system).runStateMachine(0xc000134b40, {0x22b0218, 0xc000510cf8})
	/home/runner/work/go/go/services/horizon/internal/ingest/main.go:582 +0x450
github.com/stellar/go/services/horizon/internal/ingest.TestCurrentStateRaceCondition.func1()
	/home/runner/work/go/go/services/horizon/internal/ingest/main_test.go:267 +0x79
created by github.com/stellar/go/services/horizon/internal/ingest.TestCurrentStateRaceCondition
	/home/runner/work/go/go/services/horizon/internal/ingest/main_test.go:262 +0x776
FAIL	github.com/stellar/go/services/horizon/internal/ingest	11.027s


feat(ci): add depguard in golangci to avoid importing unacceptable packages

This PR adds a new linter rule called depguard which checks whether the packages imported in this project are acceptable. This PR should be merged after my earlier PRs because this PR does not modify any codes.
I want not to use github.com/pkg/error and io/ioutil anymore because they are deprecated.
All of github.com/pkg/error will be removed in the PR: https://github.com/Snowflake-Labs/terraform-provider-snowflake/pull/1360 .

@sfc-gh-swinkler
Please rerun this workflow after merging https://github.com/Snowflake-Labs/terraform-provider-snowflake/pull/1360 .

@mnagaa thank you for your contribution!


URL typo in README.MD

What happened:
The URL in

This repository houses the assets used to build Open Component Model website.

is broken, there is a t missing in software.
What you expected to happen:
a working link :-)
How to reproduce it (as minimally and precisely as possible):
Anything else we need to know:
Environment:

solved


Autorest Regen Preview to 3.0.0-alpha.20240124.2 by Dapeng Zhang from refs/pull/4155/merge

Triggered from https://github.com/Azure/autorest.csharp/pull/4155

API change check
API changes are not detected in this pull request.


Ability to filter and group Controls as in the UI

In Control Tower's UI, we can navigate through the Controls library and group them by Guidance, Framework, and more.
As the Controls API constantly evolves, the manual effort of capturing and grouping the global identifiers goes to waste very quickly.
I apologize if this is the incorrect forum, but can I get some guidance on how to accomplish the same grouping mechanism we get in the UI, so that I can confidently create flags in my TF code to say: enable strongly recommended controls, or enable API Gateway controls.
I looked for properties returned in the Controls APIs with no luck.
I work for a consulting company, and this request comes from the frustration of many clients by not being able to replicate the ease of the UI within the scalability of the IaC.
Thanks!!

I'm TOTALLY fine and not expecting to get these groupings in TF runtime. If I have to run a python script to capture JSON and transform that into TF locals, that would solve most problems.


[VERBOSE-2:ui_dart_state.cc(198)] Unhandled Exception: PlatformException(multiple_request, Cancelled by a second request, null, null)

final ImagePicker _picker = ImagePicker();
final XFile? image = await _picker.pickImage(source: ImageSource.gallery,
imageQuality: 100
);
[VERBOSE-2:ui_dart_state.cc(198)] Unhandled Exception: PlatformException(multiple_request, Cancelled by a second request, null, null)
#0      ImagePickerApi.pickImage (package:image_picker_ios/src/messages.g.dart:133:7)

#1      ImagePickerIOS.getImage (package:image_picker_ios/image_picker_ios.dart:168:26)

#2      _WidgetEcommerceImgItemState.imageGallery (package:ezee_click_report/screen/ecommerce/widget/eccom/wd_dialog_image_ecomm_items.dart:500:26)

[✓] Flutter (Channel stable, 3.0.1, on macOS 12.2 21D49 darwin-arm (Rosetta), locale en-EG)
• Flutter version 3.0.1 at /Users/tebalink/development/flutter
• Upstream repository https://github.com/flutter/flutter.git
• Framework revision fb57da5f94 (4 weeks ago), 2022-05-19 15:50:29 -0700
• Engine revision caaafc5604
• Dart version 2.17.1
• DevTools version 2.12.2
[✓] Android toolchain - develop for Android devices (Android SDK version 32.1.0-rc1)
• Android SDK at /Users/tebalink/Library/Android/sdk
• Platform android-32, build-tools 32.1.0-rc1
• Java binary at: /Applications/Android Studio.app/Contents/jre/Contents/Home/bin/java
• Java version OpenJDK Runtime Environment (build 11.0.12+0-b1504.28-7817840)
• All Android licenses accepted.
[✓] Xcode - develop for iOS and macOS (Xcode 13.2.1)
• Xcode at /Applications/Xcode.app/Contents/Developer
• CocoaPods version 1.11.2
[✗] Chrome - develop for the web (Cannot find Chrome executable at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome)
! Cannot find Chrome. Try setting CHROME_EXECUTABLE to a Chrome executable.
[✓] Android Studio (version 2021.2)
• Android Studio at /Applications/Android Studio.app/Contents
• Flutter plugin can be installed from:
🔨 https://plugins.jetbrains.com/plugin/9212-flutter
• Dart plugin can be installed from:
🔨 https://plugins.jetbrains.com/plugin/6351-dart
• Java version OpenJDK Runtime Environment (build 11.0.12+0-b1504.28-7817840)
[✓] Connected device (2 available)
• iPhone 11 Pro (mobile) • 6B213EEA-4794-4EF4-A07A-122E03C7F736 • ios          • com.apple.CoreSimulator.SimRuntime.iOS-15-2 (simulator)
• macOS (desktop)        • macos                                • darwin-arm64 • macOS 12.2 21D49 darwin-arm (Rosetta)
[✓] HTTP Host Availability
• All required HTTP hosts are available
! Doctor found issues in 1 category.
Process finished with exit code 0

Hi @s2yed,
There is a similar issue describing this case https://github.com/flutter/flutter/issues/82602, Please follow up there for further updates, Closing this issue as a duplicate. If you disagree feel free to write in the comments and we will reopen it.
Thank you.


incorrect directories

Using Azure Databricks, the connector dropped the file in the root tmp folder "/tmp/" but when accessing the file later it errored out with file not found because it was reading from "/dbfs/tmp/".

Can you try specifying the temp folder using tempLocation  option?
Something like
val df = spark.read.
            format("com.springml.spark.sftp").
            option("host", "SFTP_HOST").
            option("username", "SFTP_USER").
            option("password", "****").
            option("fileType", "csv").
            option("delimiter", ";").
            option("inferSchema", "true").
            option("tempLocation", "/dbfs/tmp/").
            load("/ftp/files/sample.csv")

That works, thanks!
From: samuel-pt<EMAIL_ADDRESS>Sent: Monday, May 28, 2018 12:29 AM
To: springml/spark-sftp<EMAIL_ADDRESS>Cc: Patano, Franco<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Subject: [EXTERNAL] Re: [springml/spark-sftp] incorrect directories (#23)
Can you try specifying the temp folder using tempLocation option?
Something like
val df = spark.read.
        format("com.springml.spark.sftp").

        option("host", "SFTP_HOST").

        option("username", "SFTP_USER").

        option("password", "****").

        option("fileType", "csv").

        option("delimiter", ";").

        option("inferSchema", "true").

        option("tempLocation", "/dbfs/tmp/").

        load("/ftp/files/sample.csv")

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/springml/spark-sftp/issues/23#issuecomment-392422964, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AltRIbSFlp4-twew3X_JxSqOWw6y5oX4ks5t24sBgaJpZM4UOJ4-.
This email is for the use of the intended recipient(s) only. If you have received this email in error, please notify the sender immediately and then delete it. If you are not the intended recipient, you must not keep, use, disclose, copy or distribute this email without the author's prior permission. We have taken precautions to minimize the risk of transmitting software viruses, but we advise you to carry out your own virus checks on any attachment to this message. We cannot accept liability for any loss or damage caused by software viruses. The information contained in this communication may be confidential and may be subject to the attorney-client privilege. If you are the intended recipient and you do not wish to receive similar electronic messages from us in the future then please respond to the sender to this effect.


Issues related to installation and working in anaconda

problems related to installation of netron,pylg,gluoncv (which is mentioned in requirements file) in anaconda

@THEFASHIONGEEK can you please look into this error?

@sinchubhat currently Monk doesn't support anaconda, Will be added in next release. If you are using Windows OS, you can install using
pip install -r Windows/requirements_cpu_windows.txt
pip install torch==1.2.0+cpu torchvision==0.4.0+cpu -f https://download.pytorch.org/whl/torch_stable.html
from command prompt.

@sinchubhat does the temporary solution mentioned by @THEFASHIONGEEK resolve the issues?

@sinchubhat
One thing can be done is install pip in ananconda by running conda install -c anaconda pip
Later you can install all those packages using pip

@abhi-kumar i installed the libraries using pip on Ubuntu OS and i  could run tutorial notebooks  from terminal (converted those .ipynb to .py files and ran them from terminal itself )

Closing due to inactivity


Could you use Vundle to manage plugins?

Because Vundle is easier to manage plugin updates, maybe adding Vundle support is better.

actually u can try vimplug, which is similar to vundle
however since it's possible to make vimplug/vundle work with pathogen, i suggest simply giving the github link of vimplug/vundle and allow users set them by themselves

you can see my .vimrc on https://github.com/xushaobo?tab=repositories , it use vundle based on yangyangwithgun's article.

yeah, pretty good
however, i still suggest u to try vim-plug ;D
im using pathogen + vimplug

@rundisR why do not use Neobundle,it contain all the function

@wsdjeg im used to use vim plug...recommended by a friend;D

i know ,because i need to lock to different commit and branch,so i am using the neobundle,also the plugin can compile other plugin

that's ok
actually it doesn't matter which one to use, everyone has their own choice and their reason
so i suppose that we only need to focus on plugin itslef instead of management

yes , i know maybe i use neobundle just because i meet it before vundle and plugen or other management tools!

OK, U get it, I use vundle in my article now.


Testing side bar loses focus when running tests

Issue Type: Bug

Behaviour

Diagnostic data

Python version (& distribution if applicable, e.g. Anaconda): 3.8.10
Type of virtual environment used (e.g. conda, venv, virtualenv, etc.): Venv
Value of the python.languageServer setting: Pylance

User Settings

defaultLS: {"defaultLSType":"Pylance"}

downloadLanguageServer: true

envFile: "<placeholder>"

venvPath: "<placeholder>"

venvFolders: "<placeholder>"

condaPath: "<placeholder>"

pipenvPath: "<placeholder>"

poetryPath: "<placeholder>"

languageServer: "Pylance"

linting
• enabled: true
• cwd: "<placeholder>"
• Flake8Args: "<placeholder>"
• flake8Enabled: false
• flake8Path: "<placeholder>"
• lintOnSave: true
• banditArgs: "<placeholder>"
• banditEnabled: false
• banditPath: "<placeholder>"
• mypyArgs: "<placeholder>"
• mypyEnabled: false
• mypyPath: "<placeholder>"
• pycodestyleArgs: "<placeholder>"
• pycodestyleEnabled: false
• pycodestylePath: "<placeholder>"
• prospectorArgs: "<placeholder>"
• prospectorEnabled: false
• prospectorPath: "<placeholder>"
• pydocstyleArgs: "<placeholder>"
• pydocstyleEnabled: false
• pydocstylePath: "<placeholder>"
• pylamaArgs: "<placeholder>"
• pylamaEnabled: false
• pylamaPath: "<placeholder>"
• pylintArgs: "<placeholder>"
• pylintPath: "<placeholder>"

sortImports
• args: "<placeholder>"
• path: "<placeholder>"

formatting
• autopep8Args: "<placeholder>"
• autopep8Path: "<placeholder>"
• provider: "black"
• blackArgs: "<placeholder>"
• blackPath: "<placeholder>"
• yapfArgs: "<placeholder>"
• yapfPath: "<placeholder>"

testing
• cwd: "<placeholder>"
• debugPort: 3000
• nosetestArgs: "<placeholder>"
• nosetestsEnabled: undefined
• nosetestPath: "<placeholder>"
• promptToConfigure: true
• pytestArgs: "<placeholder>"
• pytestEnabled: true
• pytestPath: "<placeholder>"
• unittestArgs: "<placeholder>"
• unittestEnabled: false
• autoTestDiscoverOnSaveEnabled: true

terminal
• activateEnvironment: true
• executeInFileDir: "<placeholder>"
• launchArgs: "<placeholder>"

experiments
• enabled: true
• optInto: []
• optOutFrom: []

tensorBoard
• logDirectory: "<placeholder>"

Extension version: 2022.5.11021002
VS Code version: Code 1.66.0 (e18005f0f1b33c29e81d732535d8c0e47cafb0b5, 2022-03-30T05:50:14.623Z)
OS version: Windows_NT x64 10.0.22000
Restricted Mode: No
Remote OS version: Linux x64 5.4.0-1074-azure

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-8665U CPU @ 1.90GHz (8 x 2112)

GPU Status
2d_canvas: enabledcanvas_oop_rasterization: disabled_offdirect_rendering_display_compositor: disabled_off_okgpu_compositing: enabledmultiple_raster_threads: enabled_onoop_rasterization: enabledopengl: enabled_onrasterization: enabledraw_draw: disabled_off_okskia_renderer: enabled_onvideo_decode: enabledvideo_encode: enabledvulkan: disabled_offwebgl: enabledwebgl2: enabled

Load (avg)
undefined

Memory (System)
15.75GB (3.76GB free)

Process Argv
--open-url --crash-reporter-id 19743aef-efc8-4a9b-8cc2-b4f978f2e564 -- vscode://github.codespaces/connect?name=brettcannon-wwbd-97vr992g55

Screen Reader
no

VM
0%

Item
Value

Remote
Codespaces

OS
Linux x64 5.4.0-1074-azure

CPUs
Intel(R) Xeon(R) Platinum 8272CL CPU @ 2.60GHz (4 x 2593)

Memory (System)
7.77GB (0.33GB free)

VM
0%

A/B Experiments
vsliv368:30146709
vsreu685:30147344
python383:30185418
vspor879:30202332
vspor708:30202333
vspor363:30204092
vswsl492cf:30256860
pythonvspyl392:30443607
pythontb:30283811
pythonvspyt551:30345470
pythonptprofiler:30281270
vsdfh931:30280409
vshan820:30294714
vstes263:30335439
pythondataviewer:30285071
vscod805cf:30301675
pythonvspyt200:30340761
binariesv615:30325510
bridge0708:30335490
bridge0723:30353136
vsaa593:30376534
vsc1dst:30438360
pythonvs932:30410667
wslgetstarted:30449410
pythonvsnew555:30457759
vscscmwlcmt:30465135
vscaat:30438848
pynewfile477:30463512

In my case "Testing" icon was gone after upgrae and I have manually drag "Test explorer" from "Explorer" panel onto sidebar.
After that, side bar was automatically switching to Explorer panel when running tests from icon near line number or from test tree - exactly as reported.
I resolved this problem by right clicking on "Testing" sidebar icon, and then selecting "Reset location".

I had this problem on upgrade to 1.68 from 1.64. The file explorer took the focus when starting tests from test explorer.
I can confirm that @BlackZork 's fix using Reset Location worked for me too.

This doesn't seem to be happening in the latest builds of VS Code, the behavior itself was likely an issue in the Test UI in core. Please let us know if this happens again.

This is still happening in VSCode 1.71.2 with Test Runner for Java v0.37.1

@nortakales If this is happening on Java please file it on the Jave extension. the issue with the UI itself should be filed on VS Code.


add support for custom headers

handle custom headers like so:
customHeaders: {
'SOME-CUSTOM-HEADER': true,
'SOME-OTHER-HEADER': 'lorem ipsum'
}

will be merged and published asap. thank you for providing a new PR

thanks again...published in<EMAIL_ADDRESS>


Added steps to contribute to this project

Kindly check the contribution.md and if it's okay and understandable  merge it.
If any help kindly contact me. Happy to help you !😇

@ManoBharathi93 Thanks for the PR 😀
But the file name is probably wrong. It should be CONTRIBUTING.md instead of  Contribution.md.
Also, It'll be better if you can add some emojis to it like README.md or LEARN.md

@ManoBharathi93 🤦♂
File name should be ,
CONTRIBUTING.md

@ManoBharathi93 LOL

@ManoBharathi93 the file name is wrong. It should be CONTRIBUTING.md
Neither Contribution.md nor Contribution.md.
Copy the actual filename:
CONTRIBUTING.md

@ManoBharathi93 Thank you for the contribution 🙏


willProduce loses @escaping annotation on closures

In some of the tests I am converting to use Mockable, the completion handler is stored in a local variable. This is not working as the willProduce producer does not mark the closure as @escaping, meaning it cannot be assiigned to a local variable.
example:
 let loyaltyProfileService = MockLoyaltyProfileService()
    var capturedCompletion: ((Result<LoyaltyProfile, Error>) -> Void)?
    given(loyaltyProfileService)
      .fetchLoyaltyProfile(completion: .any)
      .willProduce { completion in
        capturedCompletion = completion
      }

This results in an error: Assigning non-escaping parameter 'completion' to an @escaping closure

Thanks for the issue @swwol!
I prepared a PR to fix this in #71, will merge it shortly.


Rendering artifacts.

The current scanline renderer fails under certain scenarios. In particular it dislikes ray-hitting nodes between two curves.

It also fails on a wrongly winded curve (I suppose that's the reason for the long rectangle)

6566bec Seems to have finally fixed the issue. Closing for now.


Hierarchy applies to user actions

User Story
Manager should be able to act on behalf of directs

T-shirt size: S(mall), M(edium), L(arge)

User Story
"As a manager of approvers within NeXt, I will need the ability to edit roles/packs and modify delegations for my directs in case they have left the org or are otherwise unavailable -- to keep business moving at the speed of thought."

Description
We should be able to handle the situations where an approver is unexpectedly unavailable. V1 allows hierarchical approval of proposals but not things like editing roles/packs to change ownership or setting up/ extending/ending delegations.  For the short term, if someone leaves the org we can always get their passwords reset and give them to the manager so that they can log in as the owner and make these changes.  Perhaps the V2 feature of having a SysAdmin would take care of this issue.

Acceptance Criteria/Tests
TBD

migrated to new tmobile/sawtooth-next-directory repo


Add top stackers, spender, and cowboys to newsletter

Add the top 5 stackers, spenders, and cowboys to the newsletter script.
I added a couple of comments on the PR to help guide review.
Fixes #926

Summary by CodeRabbit

New Features

Enhanced user rankings with the ability to sort top users by spending.
Updated the newsletter script to include sections for top users and top cowboys, showcasing leaders in various categories.

Using it in today's newsletter. Works great!


Debugger: Add SVD Peripherals and prep for multi-core

This PR is part of a trio of PR's that depend on each other:

Debugger in probe-rs

Part I of preparing for multi-core support. This will require future PR's to complete.
Restructured source files - large files broken up into smaller units.
Support for loading CMSIS-SVD files and making peripheral values available to the VSCode extension.

VSCode extension

A draft version of the extension probe-rs-debugger-0.4.0.vsix is available to facilitate testing of these PR's.
Changes to launch.json configuration to support SVD Peripheral files and core specific configuration.
Updated various development dependencies.
Updated the Debug Adapter Protocol to version 1.55.1.

Documentation on probe.rs

Document changes to VSCode launch.json.
GIF to demonstrate how to navigate and monitor SVD Peripheral register values.

Note to reviewers: This PR started as simply adding SVD support. Then I realized it doesn't make sense to add all that functionality while disregarding that this is a core-specific capability. As a result I started adding essential logic to configure and handle core-specific settings. Then I realized that the source files were growing out of proportion, so I split them into smaller units. The result is this rather larger PR - I hope the new capability and cleaner source structure makes up for the pain of reviewing such a large PR.

@Yatekii I snuck in one more commit. My primary motivation is that it is a small change and by including it now, we can avoid having the extra overhead of an extra pair of vscode synchronized PR's later.


Documentation for SFS read from vcf

The documentation for reading from vcf uses
fs = moments.Spectrum.from_data_dict(data_dict)
but the function has three required arguments. We should explain how to use projections!
from_data_dict(data_dict, pop_ids, projections, mask_corners=True, polarized=True)

While at it, in "projections – list of sample sizes to project down to for each population.", be explicit about diploid vs haploid sample sizes.


[Request] brawl ex support

Many newer ssbb mods are based on brawl ex and it would be great if this otherwise amazing tool had support for it.

There's ongoing investigation happening here: https://smashboards.com/threads/brawlex-on-isos-current-progress.463109
BrawlBuilder itself won't be getting an automatic version of this, meaning you will have to hand-edit the files yourself if you want BrawlEx support. Althrough if your mod doesn't have too many custom characters i will consider editing it for you.

If a method for having BrawlEx load from disc instead of SD is found, then it could be added to the CodePatches.txt for BrawlBuilder. This is how P:M's Alternate Stage loader is fixed, by patching the loader code to redirect loads to the disc rather than SD card. Currently I don't have the time or really the assembly knowledge needed to figure out what parts of BrawlEx's gecko codes would need to be patched though.
If a different method of getting BrawlEx to work is found and documented (i.e. by modifying some other files) I could also look into having BrawlBuilder automatically perform the modifications.

If a method for having BrawlEx load from disc instead of SD is found, then it could be added to the CodePatches.txt for BrawlBuilder. This is how P:M's Alternate Stage loader is fixed, by patching the loader code to redirect loads to the disc rather than SD card. Currently I don't have the time or really the assembly knowledge needed to figure out what parts of BrawlEx's gecko codes would need to be patched though.
If a different method of getting BrawlEx to work is found and documented (i.e. by modifying some other files) I could also look into having BrawlBuilder automatically perform those modifications.

BrawlEx has no gecko codes, instead it's all done via a .rel file that moves around all the data needed.
If i were to make a full specification of the file, pointing where is which data type and the offset for each fighter slot, could you possibly add support for it in BrawlBuilder?  I imagine coding support for it wouldn't be terribly difficult compared to most other features you have in this ISO builder.
Something you should know, is that bx_fighter.rel is not the same file in Vanilla Brawl (and most other mods) versus Project M based mods, so do consider adding some sort of check to see which version you are editing.

Sorry for reopening this. Its been 3 years now.
So, has anyone found a way to make Brawl EX compatible?


Bugs in the version <IP_ADDRESS>

With the enabled mode of downloading the list of url they do not download at all, a text file with them is not created.
There used to be a bug when after adding hundreds of blogs to the program half of them at the start were shown as offline blogs, but after a while their status changed to online, in the next versions this bug was removed, at least this error is not reproduced on the version <IP_ADDRESS>. And in version <IP_ADDRESS>, this bug again appeared. And when the program changes the status of all offline blogs to online, then after the program is closed and reopened, their status is reset to offline status with a subsequent change to online.
Minor bug: when I enter into the program, I always see an error at the top "Could not restore UI setting".

If necessary, I can send a list of hundreds of blogs to the mail for testing.

You have to check above which kind of url you want. If you check download images and Download url list below there should be file in the blog folder names images_url.txt containing all image urls.
Its probably caused by the rate limiter and where/if I've added it should check for the blogs online state and postcount before adding it to the manager. These checks take time as they are limited thus might not end up filling the dispatcher too quickly.
Remove your Settings.xml in the AppData\Local\TumblThree folder. Maybe I've changed some localizations.

Thanks, now I understood how to download the list of URLs. I think it was not obvious how could download the list of URLs. Maybe you should add a hint in the pop-up message? And I also found one bug: when I select a group of blogs and in summary details view I select the mode downloading images and the list of URLs, the program does not download url lists anywhere. Only through a single mode the program downloads a list of links.

I probably forgot to set up the multi selection.
I won't do anything for the next three weeks either since I won't be here, so If you find anything else, just put it in here. I'll fix it later then.
Thanks for reporting!


Use the official OpenAPI specification to generate types

Discussed in https://github.com/unitycatalog/unitycatalog-ui/discussions/54

Originally posted by ognis1205 July 26, 2024
The URL paths, requests, and responses of the backend server to be used are strictly defined by the OpenAPI specification.
I think it is better to automatically generate TypeScript interfaces from OpenAPI and then define the paths as union types and the requests and responses as interfaces synchronized with the OpenAPI specification using utility types.
Additionally, rather than using fetch, if you use third-party libraries like axios and implement some utilities, you can implement everything in a type-safe manner with interfaces synchronized with OpenAPI in a single API.

@jamieknight-db
Thank you for filing the issue! Please feel free to assign it to me. Sorry for the late reply.

@ognis1205
I noticed I'm unable to create or visualize tables in the UI, and I noticed the creation of tables is not fully implemented. I'd imagine this is related to not generating interfaces from openapi.

Just curious what tool you were planning on using @ognis1205
Something along the lines of this?
https://github.com/openapi-ts/openapi-typescript/tree/main/packages/openapi-typescript

@everettVT

Just curious what tool you were planning on using @ognis1205

The implementation of client-related components around OpenAPI and gRPC is progressing in Python, Rust, TypeScript, and Java. Since it seems that OpenAPI Generator is being used for Java, Python, and Rust/OpenAPI, I thought of using OpenAPI Generator if there is consensus here. Personally, I initially planned to use openapi-typescript and define some utility types.

Something along the lines of this?
https://github.com/openapi-ts/openapi-typescript/tree/main/packages/openapi-typescript

Therefore, the implementation method you pointed out will be the baseline, but I intended to make the url-path, request, and response types more type-safe by enabling inference at compile(transpile) time.
If you are going to implement the CreateTable API and the auto-generation of the API interfaces, you can take this issue as well. Otherwise, just implementing the CreateTable API alone, please follow the conventional implementation.
Reference:
https://github.com/unitycatalog/unitycatalog/discussions/208#discussioncomment-10223757

Sounds like you are on the right path. I am new to contributing so feel free to proceed as you see fit.

@everettVT
Thank you for asking. If you have any advice, please feel free to let me know anytime.

As part of the migration, you can find the new issue at unitycatalog #431


Update PPP

Codecov Report

Merging #437 (4195adf) into master (cc99551) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #437   +/-   ##
=========================================
  Coverage     79.89%   79.89%
  Complexity     1069     1069
=========================================
  Files           136      136
  Lines          3208     3208
  Branches        430      430
=========================================
  Hits           2563     2563
  Misses          573      573
  Partials         72       72

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc99551...4195adf. Read the comment docs.


Implement Readiness timer for redeploy to non-ready mesh pods

Proposal
As a follow up to #286, it is possible that mesh pods may miss an event that would allow the configuration to be properly deployed.
Background
Since we removed retry queues for deployment, we should have a timer to check that deploys are done if a mesh pod isn't ready

In the meantime I would be grateful if you could perhaps provide a workaround?

@riker09, unfortunately there is no workaround, outside of restarting the controller pod, which will re-deploy the configuration.


PHP: Autoload failure for 'Grpc\InterceptorChannel'

What version of gRPC and what language are you using?
PHP, dev-master
What operating system (Linux, Windows, …) and version?
Linux (Debian 9)
What runtime / compiler are you using (e.g. python version or version of gcc)
n/a
What did you do?
I'm implementing an interceptor for PHP:
$channel = new Channel('localhost' . $this->port, [
     'credentials' => ChannelCredentials::createInsecure()
]);
$interceptor = new TraceInterceptor();

// raises class not found error in lib/Grpc/Interceptor.php:81
$channel = Interceptor::intercept($this->channel, $interceptor);

The Grpc\InterceptorChannel class is defined under lib/Grpc/Internal/InterceptorChannel.php but composer autoloading is looking for it under lib/Grpc/InterceptorChannel.php. The unit tests pass because the test file explicitly calls require on the lib/Grpc/Internal/InterceptorChannel.php file.
What did you expect to see?
No error message.
What did you see instead?
Error: Class 'Grpc\InterceptorChannel' not found
Anything else we should know about your project / environment?

If keep using require grpc/grpc with composer, the only solution I know is either move InterceptorChannel.php out of Internal/, or change the namespace of the InterceptorChannel from Grpc to Internal\Grpc.

PR #15399 is supposed to work. Can you please verify that? Thanks!

@ZhouyihaiDing The fix works. https://circleci.com/gh/census-instrumentation/opencensus-php/1583.
However, it's a bit of a bummer that there's no ChannelInterface because we do all supplying a channel instance through google/gax and google/cloud libraries and to document it, we have to document Channel|InterceptorChannel throughout all of the documentation and remove any type hinting for Channel arguments.
It's really hard to introduce the ChannelInterface with the C extension backwards-compatibility, but WDYT about making InterceptorChannel inherit from Channel (even though every method is replaced). Then we wouldn't need to make the documentation changes and if users only use the Interceptor::intercept factory, the details of the InterceptorChannel are hidden. Perhaps it's worth discussing offline with @michaelbausor and @stanley-cheung.

Closing as this issue is fixed in master.

Make InterceptorChannel extends \Grpc\Channel in PR #15413.

@ZhouyihaiDing You should also be able to restore the typehint for Channel here: https://github.com/grpc/grpc/blob/master/src/php/lib/Grpc/BaseStub.php#L43 and you shouldn't need to document InterceptorChannel or need is_a(InterceptorChannel)


Implemented dataset using pickle

I implemented PickleDataset that uses a simple file to store data and uses Pickle to serialize data. Users can use it to improve read performance.

Could you write a document and fix the test failure?

Thank you. I fixed it.

jenkins test this please

Jenkins CI test (for commit 9df3f5133a6f2fcbc7a2a4d06589c655c5f63f35, target branch master) failed with status FAILURE.
(For contributors, please wait until the reviewer confirms the details of the error.)

LGTM. @mitmul Can I merge it?

I'll merge it. @mitmul Reopen it if there is still a problem.

The chainer-doc test is failing.


crypto.discoveryKey API docs say "publicKey" but source has "tree" as argument

https://github.com/mafintosh/hypercore-crypto#hash--cryptodiscoverykeypublickey
https://github.com/mafintosh/hypercore-crypto/blob/09b09cfc80f6e0aa51e1dee1bab6e948ca5c6a60/index.js#L84

Typo, should be public key here

Fixed in master


fix(List): using pipe with async pipe on OnPush

To match the changes made to our {N} app 👍
https://github.com/NativeScript/sample-Groceries/pull/87

Merged with e8411a272976af8bac792033a315ec6887404aaf. Thanks yet again. This is another sign that I think I need to consider having these two apps in the same repo, perhaps with a certain tool 😎. Food for thought after the weekend. Have a good one!


[TF API] Make 'TensorShape.dimensions' be public and use element accessors.

Make shape dimensions be public so I can turn it into a tensor outside the stdlib module.
Change TensorShape.subscript to use _read and _modify accessors.

@swift-ci please test tensorflow


refactor size unit parser

Please check existing PR's before submitting your own. @jhscheer already has one up: https://github.com/uutils/coreutils/pull/2297. I do appreciate the work however, so if you have ideas to improve the size parsing, you can either comment there or wait until that gets merged and build from there.

this is my fault 🤦 . I will wait for it done.

Thanks!


use24HourTime option is causing ngForm to be invalid

Hi. Great plugin. I use it inside <form> with Angular Validation.
With use24HourTime option the AM/PM selector is hidden. And that's what I see in HTML:

It is hidden but it is also required and it has no default value, because of that my form is invalid.
{
  "$error": {
    "required": [
      {
        "$viewValue": null,
        "$validators": {},
        "$asyncValidators": {},
        "$parsers": [],
        "$formatters": [],
        "$viewChangeListeners": [
          null
        ],
        "$untouched": true,
        "$touched": false,
        "$pristine": true,
        "$dirty": false,
        "$valid": false,
        "$invalid": true,
        "$error": {
          "required": true
        },
        "$name": "HourType",
        "$options": null
      }
    ]
  },
  "$name": "$ctrl.form",
  "$dirty": true,
  "$pristine": false,
  "$valid": false,
  "$invalid": true,
  "$submitted": false,
....

Any way to fix this? Thanks.

I imagine an ng-if vs ng-show on those elements would do the trick though there is still another issue that the regex used to determine if the form is valid isn't 100% accurate.

@vincentjames501  could be solved by https://github.com/vincentjames501/angular-cron-gen/pull/49


Keep getting merge conflicts

When combining the dependabot PRs, keep getting merge conflicts, and the workflow is only able to pick one PR... I've observed this on many projects. However when updating library dependencies, the workflow works fine. So I'm getting this issue only on dependabot PRs.

I've added some logging, log for another run below
Run actions/github-script@v6
Pull for branch: update/sbt-wartremover-3.0.14
Pull for branch: update/scalafmt-core-3.7.3
Pull for branch: dependabot/github_actions/actions/setup-java-3.11.0
Branch matched prefix: dependabot/github_actions/actions/setup-java-3.11.0
Checking green status: dependabot/github_actions/actions/setup-java-3.11.0
Validating status: SUCCESS
Checking labels: dependabot/github_actions/actions/setup-java-3.11.0
Checking label: dependencies
Adding branch to array: dependabot/github_actions/actions/setup-java-3.11.0
Pull for branch: dependabot/github_actions/actions/checkout-3.5.0
Branch matched prefix: dependabot/github_actions/actions/checkout-3.5.0
Checking green status: dependabot/github_actions/actions/checkout-3.5.0
Validating status: SUCCESS
Checking labels: dependabot/github_actions/actions/checkout-3.5.0
Checking label: dependencies
Adding branch to array: dependabot/github_actions/actions/checkout-3.5.0
Pull for branch: update/sbt-wartremover-3.0.13
Pull for branch: update/mockito-scala-1.17.14
Pull for branch: update/logback-classic-1.4.6
Merged branch dependabot/github_actions/actions/setup-java-3.11.0
Failed to merge branch dependabot/github_actions/actions/checkout-3.5.0
ERROR: HttpError: refusing to allow a GitHub App to create or update workflow `.github/workflows/pull-request.yml` without `workflows` permission
Creating combined PR

Workflow requires a classic token with permissions: repo, workflow