Fix BCP79 reference

Fixes #4367

missed that the PR title wasn't in Conventional Commit format, so this won't get automatically credited in the next release.
Please remember to prefix the PR title with something like fix:


add more verbosity to error message

It's a very small PR but it addresses an issue I had recently. I would like to add more verbosity to the error message for config file. Then the user would be aware of the faulty arguments.

Thanks!


Pipeline passes even though e2e test fails

Expected Behavior
If an e2e test fails, the pipeline should also fail.
Actual Behavior
Test failure:

Pipeline passing:

Reference: https://github.com/dapr/js-sdk/runs/5299603320?check_suite_focus=true
Steps to Reproduce the Problem
Fail any e2e test

/assign


IMU (BNO055) doesn't return valid data immediately after initialization.

Perhaps this is more of a feature to be documented than an issue.
tl;dr After calling IMU.initialize (with a BNO055IMU), a brief delay is required before valid yaw angles can be obtained.
This regards use of the IMU interface with a BNO055IMU. Our understanding is that this device maintains heading data between opmode runs. For example, if the yaw is 30 degrees at the end of one opmode run, it will read 30 degrees at the beginning of the next (provided the device hasn't been moved and resetYaw hasn't been called).
In the initialization phase of our linear opmode (before waitForStart), we call the initialize method of IMU to set the LogoFacingDirection to RIGHT and the USBFacingDirection to FORWARD (in keeping with the actual orientation of the control hub on our robot).
If we then immediately call getRobotYawPitchRollAngles, we find that the yaw is zero, regardless of what it was at the end of the preceeding opmode. But, within some fraction of a second, if we call getRobotYawPitchRollAngles again, we get the yaw that was actually present at the end of the preceeding opmode.
Since we are doing this to set a headingOffset in our code, we find that we need to insert a brief delay (using an ElapsedTime) between the call to IMU.initialize and the first call to IMU.getRobotYawPitchRollAngles. We've found that as little as 300 ms delay works, but haven't tried shorter.

IMU initialization delays are noted here at ftc-docs.

After IMU.initialize(), for us it takes about 60 milliseconds to get a non-zero Yaw sample.
Here is the environment:

Thank you @ftcteam8397 for reporting this behavior!!!


⚠ ClamAV has degraded performance

In a20b72e, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 205 ms

Resolved: ClamAV performance has improved in 20ccf1c.


Fix for 0 as null in ext create modal

Description
Changes proposed in this pull request:

...
...
...

Related issue(s)
Closes #1576

/retest


Remove  io.ballerina.runtime.internal usages in http, grpc

Description:
Related issue - https://github.com/ballerina-platform/ballerina-standard-library/issues/4427

This can be closed now


EVP legacy code

The EVP-code is a mess! It has evolved over time accommodated all sorts of different versions. As a consequence, it is very difficult to read and allows only a small subset of yield-curves recently implemented (PR #421). It's time for a rewrite, because EVP is still a popular solver and potentially a good fall-back solution (if implemented and used properly) for large simulations. I have just coded a version in python and realised how simple the code can be if one chooses to neglect the original formulation and instead only implements mEVP and aEVP.
There are 2 options:

one could rewrite seaice_evp.F and remove the legacy part, thereby getting rid of this code altogether
one could have a second new evp-routine (maybe within the same file) that is used by default and the old code can still be turned with a new flag (SEAICE_ALLOW_EVP_LEGACY or similar).

Opinions?

I don't know much about EVP (and who is using it) so I would prefer solution (2), but it would not be difficult to convince me that (1) is good enough.

For option (2) I can imagine a rewrite of s/r seaice_evp like this:
     subroutine seaice_evp()
...
#ifdef SEAICE_EVP_LEGACY
      call seaice_evp_legacy()
#else
c     start new routine here
...
#endif
      return
      end
#ifdef SEAICE_EVP_LEGACY
      subroutine seaice_evp_legacy()
c    content of current seaice_evp routine
      ...
      return
      end
#endif

where "seaice_evp_legacy()" is the the current routine renamed. The only issue is the mess of parameters in "s/r seaice_readparms" that we would have to keep and deal with (warnings/errors/cannot be used together with feature "X"). A bit tedious but manageable ...
Also I am open for names (instead of "legacy"). And, of course, I would NOT document this cpp-flag.


Increment version for signalr releases

Increment package version after release of Azure.ResourceManager.SignalR

/check-enforcer override


DOS_Profile.application.stressBasedDetection.badActor - Use TLS patterns as part of host identification

Environment

Application Services Version: 3.34.0
BIG-IP Version: 15.1.5

Summary
There does not appear an option to enable the "Use TLS patterns as part of host identification" option when creating a DDoS Profile
https://clouddocs.f5.com/products/extensions/f5-appsvcs-extension/latest/refguide/schemaref/DOS_Profile.schema.json.html?highlight=stressbaseddetection#dos-profile-application-stressbaseddetection-badactor-object
acceleratedSignaturesEnabled | Enables signature detection before the connection establishment
detectionEnabled                       | Enables traffic behavior, server’s capacity learning, and anomaly   detection
mitigationMode                          | Specifies mitigation impact on suspicious bad actors/requests
signatureDetectionEnabled      | Enables request signature detection
tlsSignaturesEnabled                | Enables tls signature detection before the connection establishment
useApprovedSignaturesOnly    | Limits request signature detection to approved signatures only
Steps To Reproduce
Steps to reproduce the behavior:

Submit the following declaration:

{
    "class": "ADC",
    "schemaVersion": "3.34.0",
    "id": "DOS_Profile",
    "Sample_dos_01": {
        "class": "Tenant",
        "DOSApp": {
            "class": "Application",
            "Service": {
                "class": "Service_HTTP",
                "virtualAddresses": [
                    "<IP_ADDRESS>"
                ],
                "profileDOS": {
                    "use": "DOS_Profile2"
                }
            },
            "DOS_Profile2": {
                "class": "DOS_Profile",
                "application": {
                    "stressBasedDetection": {
                        "badActor": {
                            "detectionEnabled": true,
                            "mitigationMode": "standard",
                            "signatureDetectionEnabled": true,
                            "tlsSignaturesEnabled": true,
                            "useApprovedSignaturesOnly": false

                        },
                        "operationMode": "blocking",
                        "thresholdsMode": "automatic",
                        "escalationPeriod": 120,
                        "deEscalationPeriod": 7200,
                        "sourceIP": {
                            "rateLimitingEnabled": false
                        },
                        "url": {
                            "rateLimitingEnabled": false
                        }
                    }
                }
            }
        }
    }
}

Observe the following error response:

{
    "results": [
        {
            "code": 200,
            "message": "success",
            "lineCount": 19,
            "host": "localhost",
            "tenant": "Sample_dos_01",
            "runTime": 2854
        }
    ],
    "declaration": {
        "Sample_dos_01": {
            "class": "Tenant",
            "DOSApp": {
                "class": "Application",
                "Service": {
                    "class": "Service_HTTP",
                    "virtualAddresses": [
                        "<IP_ADDRESS>"
                    ],
                    "profileDOS": {
                        "use": "DOS_Profile2"
                    }
                },
                "DOS_Profile2": {
                    "class": "DOS_Profile",
                    "application": {
                        "stressBasedDetection": {
                            "badActor": {
                                "detectionEnabled": true,
                                "mitigationMode": "standard",
                                "signatureDetectionEnabled": true,
                                "tlsSignaturesEnabled": true,
                                "useApprovedSignaturesOnly": false
                            },
                            "operationMode": "blocking",
                            "thresholdsMode": "automatic",
                            "escalationPeriod": 120,
                            "deEscalationPeriod": 7200,
                            "sourceIP": {
                                "rateLimitingEnabled": false
                            },
                            "url": {
                                "rateLimitingEnabled": false
                            }
                        }
                    }
                }
            }
        },
        "class": "ADC",
        "schemaVersion": "3.34.0",
        "id": "DOS_Profile",
        "updateMode": "selective",
        "controls": {
            "archiveTimestamp": "2022-02-08T10:24:58.348Z"
        }
    }
}

Expected Behavior
Options to be able to use TLS fingerprinting to identify Bad Actor Hosts
Actual Behavior
No option available

@bwearp please can send me the required tmsh command you need to be added to AS3. Please contact me at<EMAIL_ADDRESS>


Simplify documentation for missing inputs

You can use @InputFiles instead to tell Gradle that it's okay if the file does not exist.

This is so much nicer :tada:

@bot-gradle test and merge please

OK, I've already triggered a build for you.


New Content Update Request: Add ATX events

Link where content currently exists
there are some atx events that are still not reflected
Updates you'd like to make
Add these events to the events list:
https://www.eventbrite.com/o/darlene-santoyo-andrea-cardona-18541630187

Hi, Can I take this up ?

@apsychogirl yep sure can

Hi, I had a little issue in finding the file where I need to update the list. Can you please help?

Yeah you can check out https://github.com/techqueria/website/pull/557 for an example of how to add a new event @apsychogirl


Appium installs WinAppDriver in the wrong location

I kept getting "message": "An unknown error occurred in the remote end while processing the command." until I fully uninstalled the WinAppDriver then installed it again from your github releases.  I noticed your installer places it in C:\Program Files (x86)\Windows Application Driver which works, but appium was placing it in C:\Program Files\Windows Application Driver.

Hi @lovettchris,
It is intended to be installed on that location only, and for the error have you enabled the developer mode?
also if you are using it in conjunction with Appium driver you need to install its driver from the Appium command line "Appium driver install......"
We have an already developed solution for the same, you can check it out over here "https://soliterata.com/".

Yep, I already checked developer mode is enabled, but Appium driver install.... is how I installed it the first time, but nothing would work.  I kept getting that error message until I manually uninstalled WinAppDriver, and installed your .msi which put it in C:\Program Files (x86) then appium magically started working properly.

yes, you need to have the win app driver installed, you are doing it correctly.


Enforce commit format

Enforce conventional commit format (https://www.conventionalcommits.org/)

Installed Probot based solution (https://probot.github.io/apps/semantic-pull-requests/)


feat: respect NO_COLOR env variable

Resolves https://github.com/scalameta/munit/issues/149
This PR makes use of the NO_COLOR environment variable, disabling all ansi escapes when NO_COLOR=1.
Example:
//> using scala "2.13.10"
//> using lib "org.scalameta::munit::1.0.0-SNAPSHOT" // published locally

class MyTests extends munit.FunSuite {
  test("foo") {
    assert(2 + 2 == 4)
  }
}

@valencik Thank you for taking a look!

As you can see in the mima run, this is causing some binary incompatibility issues.

Mima issues were solely caused by the removal of unused escapes from AnsiColors. This change is reverted now, CI should be passing

It's not clear to me why they changes to JUnitReporter.scala, Lines.scala, or Diff.scala are necessary.

These files had some string concatenations with direct inclusion of ansi codes. This PR refactors them to use Ansi Colors.c method instead. Please, let me know, if there is another way to ensure escape codes to be filtered while leaving these files untouched

Thank you again for this contribution!
Closing in favour of https://github.com/scalameta/munit/pull/703 which was able to minimize the diff nicely.


Fix typo: dumb_with_default_fk_name -> dump_with_default_fk_name

Coverage remained the same at 96.692% when pulling 525c5aeaa58cfae85eec882620a4dcbf8b6271cf on fix_typo into 021728f9ff31d35eb5b7f3ee113a7938f429e864 on v0.6.5.

Coverage remained the same at 96.692% when pulling 525c5aeaa58cfae85eec882620a4dcbf8b6271cf on fix_typo into 021728f9ff31d35eb5b7f3ee113a7938f429e864 on v0.6.5.

Coverage remained the same at 96.692% when pulling 525c5aeaa58cfae85eec882620a4dcbf8b6271cf on fix_typo into 021728f9ff31d35eb5b7f3ee113a7938f429e864 on v0.6.5.

Coverage remained the same at 96.692% when pulling 525c5aeaa58cfae85eec882620a4dcbf8b6271cf on fix_typo into 021728f9ff31d35eb5b7f3ee113a7938f429e864 on v0.6.5.

Coverage remained the same at 96.692% when pulling 525c5aeaa58cfae85eec882620a4dcbf8b6271cf on fix_typo into 021728f9ff31d35eb5b7f3ee113a7938f429e864 on v0.6.5.

Coverage remained the same at 96.692% when pulling 525c5aeaa58cfae85eec882620a4dcbf8b6271cf on fix_typo into 021728f9ff31d35eb5b7f3ee113a7938f429e864 on v0.6.5.


Allowing employees of a CLA-certified organization to commit code

The Unicode Consortium has CLAs on file from several companies.  Currently, we import usernames into the cla-assistant.io dashboard, and we have to manually keep that list updated with reality.  It might be nice if we could give cla-assistant a list of GitHub organizations whose employees are allowed to submit code, such that we don't have to manually maintain the list of individual usernames.
@srl295 @jefgen

Hi @sffc, thank you for reaching out to us. There is an allow list functionality in CLA Assistant and you can make use of it if you want to allow all the users in the GitHub organization to pass the CLA check.

@ibakshay How are organizations considered? This sounds like it would only cover forks that were in the organization's repo, not all members of an organization forking to their own repo?

This sounds like it would only cover forks that were in the organization's repo, not all members of an organization forking to their own repo?

Yes, this is how it works with "always allowed" organizations.
@tim-mc , do you think it would make sense to allow all members of the organization whether or not the fork is in the org or in the member's private space?

^ @sffc @jefgen otherwise this would require the fork to be https://github.com/microsoft/icu (ok that works for @jefgen! ) but does not help https://github.com/jefgen/icu

It might be nice if we could give cla-assistant a list of GitHub organizations whose employees are allowed to submit code, such that we don't have to manually maintain the list of individual usernames.

This would be a nice-to-have in our organisation as well.
The only concern I have – and I’m pretty sure, devs have thought about this – is when someone stops working for an organisation, but they were allowed to create a PR without the CLA check from their personal fork, while they were still at the org.

It might be nice if we could give cla-assistant a list of GitHub organizations whose employees are allowed to submit code, such that we don't have to manually maintain the list of individual usernames.

This would be a nice-to-have in our organisation as well.
The only concern I have – and I’m pretty sure, devs have thought about this – is when someone stops working for an organisation, but they were allowed to create a PR without the CLA check from their personal fork, while they were still at the org.

This is a definite issue—off-boarding.  Not everyone is quick to remove people from the public organizations.  But, the discussion just above is not about personal forks but organizational forks.  If you stop working for the organization, but are still allowed to create a PR under that organization, that's the fault of the organization for not properly removing your access.

Another point to consider is that some people belong to multiple orgs. The question is, how to define in which org's name the contributor is acting as he creates a PR from his own repo?

[…] If you stop working for the organization, but are still allowed to create a PR under that organization, that's the fault of the organization for not properly removing your access.

That’s for sure. And the onus can only be on the org itself here, the bot can’t second-guess whether an account is rightly or wrongly associated with the org.

This is a definite issue—off-boarding. Not everyone is quick to remove people from the public organizations. But, the discussion just above is not about personal forks but organizational forks.

In that case I misunderstood https://github.com/cla-assistant/cla-assistant/issues/597#issuecomment-658185092
To clarify, a nice-to-have for us would be that as long as I’m part of Liferay org, I don’t need to sign a CLA regardless if I create a PR from either https://github.com/liferay/* or https://github.com/silverhook/*

Another point to consider is that some people belong to multiple orgs. The question is, how to define in which org's name the contributor is acting as he creates a PR from his own fork?

That is a good question, yes.
A similar consideration is org vs private – it may be that an org is whitelisted, but the contributor has been contributing not in their work/org time, but that their contribution is actually their own copyright (perhaps even that they have a contract where the code they contribute is theirs, not the company’s). Then again, that may be quite a rare issue.

Another point to consider is that some people belong to multiple orgs. The question is, how to define in which org's name the contributor is acting as he creates a PR from his own fork?

This is already an unsolved problem. If I make a PR to a repo from my own fork, then sign off on it in the name of my company, then I go to another company and make another PR against the same repo, then it falsely believes I've already signed on behalf of the new company.

@stalebot This is still a major pain point.  Please don't close it.

If I make a PR to a repo from my own fork, then sign off on it in the name of my company, then I go to another company and make another PR against the same repo, then it falsely believes I've already signed on behalf of the new company.

My group encountered this problem recently.  Our case is very simple:

We want to exempt our own employees from having to sign our own company's CLA
Our employees are identified based on belonging to a GitHub organization
Exempting the organization works fine, unless the PR is from a personal fork
For an open source project, we prefer for people to use personal forks, so that they have the same experience as an external contributor.

Regarding #4, in the past I've seen cases where a bug was overlooked and caused friction for external contributors, because the project maintainers were not using forks, whereas external contributors were using forks.
The concern about "it falsely believes I've already signed on behalf of the new company" doesn't seem to be relevant to this scenario -- unless I'm missing something. (?)
Is the design that @silverhook proposed difficult to implement (maybe as an opt-in setting)? Or maybe there is some better way for us to exempt "everybody at our own company" (for example using a  GitHub team name)?

I fully agree that this would be a good feature to have, especially since it more or less allows "Company Contributor Licence Agreements (CCLA)" .
I think it makes sense to add it as an additional configuration field (instead of reusing the existing "Specify usernames to be always allowed") which is called something like "specify organizations which public members are always allowed to contribute".
We can then do an additional API request to check if that member is a public member (as for private membership we would need more scopes from the signee and thats not really feasible).
Optionally we can check as well for email domains (like @company.com) and accept all commits done by this domain as signed.
What do you think, would this cover your use case?
If not, please add what you would like to see.
I will try (no guarantee however) if I can get a PoC working for this in the next time.
Could look in the configuration like this:

to check if that member is a public member (as for private membership we would need more scopes from the signee and thats not really feasible).

Makes sense to me.
An organization should do its own api calls to make sure its members have public membership. (I think GitHub ought to prompt you when you are added, but anyway. )

The feature to exempt public members of an organization is now live on our staging system (https://k8s.cla-assistant.io/).
If you have a spare organization (don't use your productive ones), you can test it out there.
I will take some time this week to validate a few things and if everything looks good the change will hit production at the beginning of next week.


[Bug]: Token counter not working for RaptorPack

Bug Description
I recently conduced a few experiments using RaptorPack and everything looks fine. The only fallback is that the token counter is not working for the RaptorPack so that I cannot get an accurate metric on how many tokens are consumed. Neither the
embedding token counter or the llm counter works. The counter always remains 0.
I tried the following and it worked for me for a single llm with token counter as 10. I noticed that the token counter remains 0 if I change
token_counter = TokenCountingHandler(tokenizer=tiktoken.encoding_for_model("gpt-4-1106-preview").encode)
callbackManager = CallbackManager([token_counter])
llm=OpenAI(model="gpt-4-1106-preview", temperature=0, callback_manager=CallbackManager([token_counter]))
response = llm.complete("hello")
token_counter.total_llm_token_count

Did I use the callback manager and token counter in an incorrect way?
Version
0.10.6
Steps to Reproduce
import tiktoken
from llama_index.core.callbacks import CallbackManager, TokenCountingHandler
embedding_token_counter = TokenCountingHandler(tokenizer=tiktoken.encoding_for_model("text-embedding-ada-002").encode)
token_counter = TokenCountingHandler(tokenizer=tiktoken.encoding_for_model("gpt-3.5-turbo").encode)
callbackManager = CallbackManager([token_counter])
custom_pack_google_doc_tree = RaptorPack(
documents=llama_index_documents,
embed_model=OpenAIEmbedding(
model="text-embedding-ada-002",
callback_manager=CallbackManager([embedding_token_counter])
),  # used for embedding clusters
llm=OpenAI(model="gpt-3.5-turbo", temperature=0, callback_manager=callbackManager),  # used for generating summaries
vector_store=vector_store,  # used for storage
similarity_top_k=5,  # top k for each layer, or overall top-k for collapsed
mode="tree_traversal",  # sets default mode
transformations=[
SentenceSplitter(chunk_size=400, chunk_overlap=50)
],  # transformations applied for ingestion
summary_prompt=RAPTOR_SUMMARY_PROMPT,
)
Relevant Logs/Tracbacks
No response

Anyone has some idea what might be wrong?

We should probably be migrating the token counter to the instrumentation system imo


added option to disable Python or Matlab support

This can be used if do have Python/Matlab on your system but don't want to include support for it. This is useful if you have compilation or run-time errors  with one of them (e.g. because of mismatches shared libraries) and you don't need it.
Currently only passed to SIRF. Option names are DISABLE_Python etc, maybe better SIRF_DISABLE_Python` ?

The code seems fine to me, though I haven't tested it.
w.r.t. naming, it doesn't seem we have a SIRF_ policy on variable names passed to SIRF compilation. Does it make sense to add SIRF_DISABLE_Python or it is just very verbose?

it doesn't seem we have a SIRF_ policy on variable names passed to SIRF compilation.

I think we do...
can you please rename to SIRF_DISABLE... then? We can always have a general DISABLE then later on

I think we discussed that this functionality was missing. Anyone volunteering to fix this up and merge?

I've  updated this. Will probably merge soon. If anyone with with both MATLAB and Python wants to try, that'd be good.
Let' s postpone introducing SIRF_DISABLE_Python variables until we make a macro for it such that it will be easier to do this for all projects.


UML and Yang files renaming in preparation for renaming files, modules and attributes to follow Yang best practices

Renamed papyrus models Tapi & TapiModel to TapiCommon & TapiOverview
Renamed TAPI Yang files to follow Yang naming conventions
No other changes are made to the file content. This is to ensure that the current code is base-lined under new file names and will be followed by changes to content to fix module names, etc

Partial fix to #157


Analytics

We might want some analytics on the website.
Aragon One is using something like https://github.com/matomo-org/matomo (for their blog), which is a better alternative to Google Analytics. Open, self-hosted, GDPR etc. An online demo for it can be seen here demo.matomo.org. Although it seems like a big setup if we want to self-host it ourselves.
Maybe there are other nice alternatives?

We should add the same analytics for the blog ... I'm not a huge fan of GA obviously but I'm feeling like we could start with GA to avoid self hosting and all the related problems. Plus GA integration is super easy by default in ghost so ...

Using Google analytics for now but probably going to switch to Simple Analytics.


Introducing lift delete button

Continuation of #509
Implementation summary

Delete button in lift_table to remove lift from map and yam
Delete any lift cabin way point and any edges connected to said way point

The test failures seem mostly related to uncrustify, you should be able to reproduce with a local colcon test run

Right now the implementation is a nested if , to check for a lift_cabin property, then check if the lift name matches.
I am also worried on the situation where the lift cabin name is changed manually via the property panel which results in unsuccessful deletion of the vertex after deleting the lift.

Yap I know there are two nested if statements to make sure the lift matches, it's more a "what would happen if there was more than one lift with the requested lift_name?", the main other code path I linked would still work but this wouldn't because only the first waypoint would be cleaned up

Alright, what we can do is do remove the break and remove all the waypoints that fits the criteria.

Ah sorry last hurdle, we need commits to be signed https://docs.github.com/authentication/managing-commit-signature-verification/about-commit-signature-verification, can you do that and force-push to this PR?

Sorry, still trying to fumble around with the signature. Will get to it asap.

Thanks for iterating! (Sign offs can be painful the first time :) )


various fixes

trying to get scalafix and http4s green.
also seeing if we can enable more of sttp.
sequel to #786
fyi @adamw @rossabaker @olafurpg @alexandru

twitter-util green, scalafix green, jawn-0-11 green
[http4s] Processing subproject: blaze-core
...
[http4s] [error] /home/jenkins/workspace/scala-2.12.x-integrate-community-build/target-0.9.14/project-builds/http4s-16cf54f73637e8785f0e346206cfeaf67b573068/blaze-core/src/main/scala/org/http4s/blazecore/Http1Stage.scala:10:30: object parser is not a member of package org.http4s.blaze.http
[http4s] [error] import org.http4s.blaze.http.parser.BaseExceptions.ParserException
[http4s] [error]                              ^

[sttp] Processing subproject: monix
...
[sttp] [error] /home/jenkins/workspace/scala-2.12.x-integrate-community-build/target-0.9.14/project-builds/sttp-c40d23e4428ba1fa2c174fe4245a2b348c42b10b/implementations/monix/shared/src/main/scala/com/softwaremill/sttp/impl/monix/TaskMonadAsyncError.scala:18:19: missing parameter type
[sttp] [error]     Task.async { (_, cb) =>
[sttp] [error]                   ^
[sttp] [error] /home/jenkins/workspace/scala-2.12.x-integrate-community-build/target-0.9.14/project-builds/sttp-c40d23e4428ba1fa2c174fe4245a2b348c42b10b/implementations/monix/shared/src/main/scala/com/softwaremill/sttp/impl/monix/TaskMonadAsyncError.scala:18:22: missing parameter type

the sttp part of this was just a would-be-nice, so I've dropped that part
http4s isn't green yet, but I'm going to merge this regardless since everything here is an improvement. I'll take up http4s in another PR

@SethTisue I can add the missing type annotation, though I'm not sure if that's the goal of the community build - apparently you are using a different Scala compiler version, so maybe it's good that it fails comparing to the current stable one?


Add link to Github Issues on Contributing Documentation page

:mag: Description
Issue References 🔗

Good First Issues image links to the Github issues page while the image on Contributing Documentation does not.
Describe Your Solution 🔧
Added a link to https://github.com/apache/kyuubi/issues?q=is%3Aopen+is%3Aissue+label%3Akind%3Adocumentation to match the behaviour from good first issues
Types of changes :bookmark:

[ ] Bugfix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Test Plan 🧪
Behavior Without This Pull Request :coffin:
Behavior With This Pull Request :tada:
Related Unit Tests

Checklist 📝

[x] This patch was not authored or co-authored using Generative Tooling

Be nice. Be informative.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 0.00%. Comparing base (28a1c73) to head (3d54ce9).

Additional details and impacted files
@@          Coverage Diff           @@
##           master   #6514   +/-   ##
======================================
  Coverage    0.00%   0.00%
======================================
  Files         677     677
  Lines       41746   41746
  Branches     5706    5706
======================================
  Misses      41746   41746

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Thanks, merged to master


Failed to transform react-native-0.71.0-rc.0-debug.aar (com.facebook.react:react-native:0.71.0-rc.0) to match attributes

Description
I am working on my libraries example project, found here https://github.com/austinksmith/react-native-hamsters/tree/master/examples/HamstersJS , this project used to work perfectly fine and I have not made any changes to it since the last time I tested it (working at the time), now the project refuses to run on android with the following error.
BUILD FAILED in 3s

error Failed to install the app. Make sure you have the Android development environment set up: https://reactnative.dev/docs/environment-setup.
Error: Command failed: ./gradlew app:installDebug -PreactNativeDevServerPort=8081
Warning: Mapping new ns http://schemas.android.com/repository/android/common/02 to old ns http://schemas.android.com/repository/android/common/01
Warning: Mapping new ns http://schemas.android.com/repository/android/generic/02 to old ns http://schemas.android.com/repository/android/generic/01
Warning: Mapping new ns http://schemas.android.com/sdk/android/repo/addon2/02 to old ns http://schemas.android.com/sdk/android/repo/addon2/01
Warning: Mapping new ns http://schemas.android.com/sdk/android/repo/addon2/03 to old ns http://schemas.android.com/sdk/android/repo/addon2/01
Warning: Mapping new ns http://schemas.android.com/sdk/android/repo/repository2/02 to old ns http://schemas.android.com/sdk/android/repo/repository2/01
Warning: Mapping new ns http://schemas.android.com/sdk/android/repo/repository2/03 to old ns http://schemas.android.com/sdk/android/repo/repository2/01
Warning: Mapping new ns http://schemas.android.com/sdk/android/repo/sys-img2/03 to old ns http://schemas.android.com/sdk/android/repo/sys-img2/01
Warning: Mapping new ns http://schemas.android.com/sdk/android/repo/sys-img2/02 to old ns http://schemas.android.com/sdk/android/repo/sys-img2/01
Warning: unexpected element (uri:"", local:"base-extension"). Expected elements are <{}codename>,<{}layoutlib>,<{}api-level>

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':app:mergeDebugAssets'.
> Could not resolve all files for configuration ':app:debugRuntimeClasspath'.
   > Failed to transform react-native-0.71.0-rc.0-debug.aar (com.facebook.react:react-native:0.71.0-rc.0) to match attributes {artifactType=android-assets, com.android.build.api.attributes.BuildTypeAttr=debug, org.gradle.category=library, org.gradle.dependency.bundling=external, org.gradle.libraryelements=aar, org.gradle.status=release, org.gradle.usage=java-runtime}.
      > Execution failed for JetifyTransform: /home/computer/.gradle/caches/modules-2/files-2.1/com.facebook.react/react-native/0.71.0-rc.0/7a7f5a0af6ebd8eb94f7e5f7495e9d9684b4f543/react-native-0.71.0-rc.0-debug.aar.
         > Java heap space

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.

* Get more help at https://help.gradle.org

BUILD FAILED in 3s

    at makeError (/home/computer/Projects/react-native-hamsters/examples/HamstersJS/node_modules/execa/index.js:174:9)
    at /home/computer/Projects/react-native-hamsters/examples/HamstersJS/node_modules/execa/index.js:278:16
    at processTicksAndRejections (node:internal/process/task_queues:96:5)
    at async runOnAllDevices (/home/computer/Projects/react-native-hamsters/examples/HamstersJS/node_modules/@react-native-community/cli-platform-android/build/commands/runAndroid/runOnAllDevices.js:94:5)
    at async Command.handleAction (/home/computer/Projects/react-native-hamsters/examples/HamstersJS/node_modules/react-native/node_modules/@react-native-community/cli/build/index.js:186:9)
info Run CLI with --verbose flag for more details.

What would cause a previously working fine project to suddenly stop working without any changes being made? Was something changes up stream to cause builds to fail, is it pulling a file from somewhere? I am truly confused on this.
React Native Version
react-native-0.71.0-rc.0
Output of npx react-native info
System:
    OS: Linux 5.15 Ubuntu 20.04.6 LTS (Focal Fossa)
    CPU: (8) x64 Intel(R) Core(TM) i5-8300H CPU @ 2.30GHz
    Memory: 6.04 GB / 15.46 GB
    Shell: 5.0.17 - /bin/bash
  Binaries:
    Node: 16.15.1 - ~/.nvm/versions/node/v16.15.1/bin/node
    Yarn: 1.22.19 - ~/.nvm/versions/node/v16.15.1/bin/yarn
    npm: 9.1.2 - ~/.nvm/versions/node/v16.15.1/bin/npm
    Watchman: 20220605.192726.0 - /usr/local/bin/watchman
  SDKs:
    Android SDK:
      API Levels: 29, 30, 31, 32, 33
      Build Tools: 29.0.2, 29.0.3, 30.0.2, 30.0.3, 31.0.0, 32.0.0, 32.1.0
      System Images: android-29 | Google APIs Intel x86 Atom
      Android NDK: Not Found
  IDEs:
    Android Studio: Not Found
  Languages:
    Java: <IP_ADDRESS> - /usr/bin/javac
  npmPackages:
    @react-native-community/cli: Not Found
    react: 17.0.1 => 17.0.1
    react-native: 0.64.2 => 0.64.2
  npmGlobalPackages:
    *react-native*: Not Found

Steps to reproduce
Clone my example project repo, run npm install , then run npm start and npm run android
Snack, screenshot, or link to a repository
https://github.com/austinksmith/react-native-hamsters/tree/master/examples/HamstersJS

This is affected by:

https://github.com/facebook/react-native/issues/35210

I see your project is using 0.64.2, you would have to migrate to 0.64.4 or use the workaround script which is suggested in the issue I linked.


Where did you set is_train=False for batch_normalization op?

I tried to run your code with the command for  "run_gan_cifar10.py" on README.md (without changing any parameters) but failed to reproduce the performance in CIFAR-10 dataset (expected: 44.28% but mine shows around 33%). So, as a sanity check, I tried to train the code without the evaluation ops and evaluated over the final checkpoint. However, it gives even less performance than I expected. Thus, I look into the code but failed to find the place of providing "is_train=False"
https://github.com/whxbergkamp/RobustDL_GAN/blob/a5e1b69c17b2b371c6645c880aa85c776c501947/cifar10/adversarial_networks/models/resnet18_2.py#L248
for the batch_normalization operation during the evaluation phase
https://github.com/whxbergkamp/RobustDL_GAN/blob/a5e1b69c17b2b371c6645c880aa85c776c501947/cifar10/adversarial_networks/train_gan_cifar10.py#L5-L109
https://github.com/whxbergkamp/RobustDL_GAN/blob/a5e1b69c17b2b371c6645c880aa85c776c501947/cifar10/adversarial_networks/train_gan_cifar10.py#L288-L292
Could you take a look and share where did you feed is_train=False? It would be even better if you can share the checkpoint for the trained classifier.
Regards,
Yunseok

[Update] The author mentioned in Acknowledgement that this code is based on another repo, so I take a look into that repository also. In the original repository, they use another op to measure the performance of a generator, with 'is_training=False'. I put some links below for a better comparison.
https://github.com/LMescheder/TheNumericsOfGANs/blob/68d915fc01608e7f585af853a2aabeacbfa2d53f/consensus_gan/train.py#L26
https://github.com/LMescheder/TheNumericsOfGANs/blob/68d915fc01608e7f585af853a2aabeacbfa2d53f/consensus_gan/train.py#L108-L110

Could you share what version of Tensorflow you're running this on and your CUDA version? We will look into this.

Sure, I've tested with the following setting:
Tensorflow 1.13.1 CUDA 10.0 CNDNN 7.6
However, I'd like to note that feeding   'is_training=True/False'  is orthogonal to Tensorflow versioning issue. Please run the code with commenting out all the "test" operations as a sanity check. I marked them in below:
https://github.com/whxbergkamp/RobustDL_GAN/blob/a5e1b69c17b2b371c6645c880aa85c776c501947/cifar10/adversarial_networks/train_gan_cifar10.py#L288-L292
https://github.com/whxbergkamp/RobustDL_GAN/blob/a5e1b69c17b2b371c6645c880aa85c776c501947/cifar10/adversarial_networks/train_gan_cifar10.py#L330-L339

What is the weight_decay parameter used in your training? I just noticed the example command in the README uses 1E-4, which is not optimal. The default setting of 1E-5 in the file run_gan_cifar10.py should reproduce the results in the paper. I have also updated the README accordingly.

Yes, I've tested with weight decay 1E-4, so I tested with 1E-5 also now, but still failed to replicate.
Buy, the parameter setting is not seriously related with what I am asking. What I am asking is... "Because of no 'is_train=False' in the training code, the evaluation ops updates running variables (mean, var) from the test dataset, which is incorrect". So, please train your model WITHOUT your evaluation script (L330-339 of train_gan_cifar10.py) . and  evaluate your model SEPARATELY from your current 'train_gan_cifar10.py'.

Hi, I tested with the evaluation script, but with providing 'is_training=False' to the generator/discriminator in test scripts: https://github.com/whxbergkamp/RobustDL_GAN/blob/a5e1b69c17b2b371c6645c880aa85c776c501947/cifar10/adversarial_networks/train_gan_cifar10.py#L5-L109 .
Unfortunately. this case failed to replicate the performance on CIFAR10, once again. Please recheck your implementation and update the code accordingly.

Sorry for the late reply. Thanks for the information on your tests. We are looking into the issue, it might have to do with the decay parameter in batch norm.

Hello, any updates on this issue? Is the code wrong (including the results in the paper)?


[chore] Move ts-jest to dev dependencies

Having ts-jest in "dependencies" includes it in the published version of this package. As far as I can tell, this package is only using ts-jest for tests. So this PR moves it to devDependencies.
We use Hygen at Airbnb, and this is blocking us from updating jest to v25.1.0 due to an unmet peer dependency from this package.
<EMAIL_ADDRESS>/Users/sharmila_jesupaul/airlab/repos/airbnb-1
├─┬<EMAIL_ADDRESS>│ └──<EMAIL_ADDRESS>└──<EMAIL_ADDRESS>
npm ERR! peer dep missing: jest@>=24 <25, required by<EMAIL_ADDRESS>
@jondot

@jondot can you ptal?

@jondot Friendly bump here. We'd like to get off our internal fork and start using the mainline package again

@Whoaa512 @sharmilajesupaul sorry about that! I was busy starting my own company :) back to taking care of that now.

Thank you!


Remove not used imports

Description
after the pyupgrade command there were still some unused imports.
I noticed this because this build failed: https://jenkins.inmanta.com/job/docs/job/lsm-documentation-examples-verification/job/master/315/console
and had to make the same changes on lsm (https://github.com/inmanta/lsm/pull/675) than those that where made to the core doc. On lsm it complained about those imports
Self Check:
Strike through any lines that are not applicable (~~line~~) then check the box

[ ] Attached issue to pull request
[x] Changelog entry
[ ] Type annotations are present
[ ] Code is clear and sufficiently documented
[ ] No (preventable) type errors (check using make mypy or make mypy-diff)
[ ] Sufficient test cases (reproduces the bug/tests the requested feature)
[ ] Correct, in line with design
[ ] End user documentation is included or an issue is created for end-user documentation (add ref to issue here: )
[ ] If this PR fixes a race condition in the test suite, also push the fix to the relevant stable branche(s) (see test-fixes for more info)

Merged into branches master in a75c3a0555e225ecc1e1fd4561033e0bb79c84e6

Processing #6797.


[PTRun] app.dark.png not found

Microsoft PowerToys version
0.61.1
Running as admin

[ ] Yes

Area(s) with issue?
General
Steps to reproduce
I woke up my computer from suspend, logged in, and immediately saw the powertoys "something went wrong" popup.
Version: <IP_ADDRESS>
OS Version: Microsoft Windows NT 10.0.22000.0
IntPtr Length: 8
x64: True
Date: 8/11/2022 2:01:20 AM
Exception:
System.IO.FileNotFoundException: Could not find file 'C:\Program Files\PowerToys\modules\launcher\Images\app.dark.png'.
File name: 'C:\Program Files\PowerToys\modules\launcher\Images\app.dark.png'
at Microsoft.Win32.SafeHandles.SafeFileHandle.CreateFile(String fullPath, FileMode mode, FileAccess access, FileShare share, FileOptions options)
at Microsoft.Win32.SafeHandles.SafeFileHandle.Open(String fullPath, FileMode mode, FileAccess access, FileShare share, FileOptions options, Int64 preallocationSize)
at System.IO.Strategies.OSFileStreamStrategy..ctor(String path, FileMode mode, FileAccess access, FileShare share, FileOptions options, Int64 preallocationSize)
at System.IO.Strategies.FileStreamHelpers.ChooseStrategyCore(String path, FileMode mode, FileAccess access, FileShare share, FileOptions options, Int64 preallocationSize)
at System.IO.Strategies.FileStreamHelpers.ChooseStrategy(FileStream fileStream, String path, FileMode mode, FileAccess access, FileShare share, Int32 bufferSize, FileOptions options, Int64 preallocationSize)
at System.IO.FileStream..ctor(String path, FileMode mode, FileAccess access, FileShare share)
at System.Windows.Media.Imaging.BitmapDecoder.SetupDecoderFromUriOrStream(Uri uri, Stream stream, BitmapCacheOption cacheOption, Guid& clsId, Boolean& isOriginalWritable, Stream& uriStream, UnmanagedMemoryStream& unmanagedMemoryStream, SafeFileHandle& safeFilehandle)
at System.Windows.Media.Imaging.BitmapDecoder.CreateFromUriOrStream(Uri baseUri, Uri uri, Stream stream, BitmapCreateOptions createOptions, BitmapCacheOption cacheOption, RequestCachePolicy uriCachePolicy, Boolean insertInDecoderCache)
at System.Windows.Media.Imaging.BitmapImage.FinalizeCreation()
at System.Windows.Media.Imaging.BitmapImage.EndInit()
at System.Windows.Media.Imaging.BitmapImage..ctor(Uri uriSource, RequestCachePolicy uriCachePolicy)
at Wox.Infrastructure.Image.ImageLoader.Initialize(Theme theme)
at PowerLauncher.App.<>c__DisplayClass14_0.b__0()
at Wox.Infrastructure.Stopwatch.Normal(String message, Action action)
at PowerLauncher.App.OnStartup(Object sender, StartupEventArgs e)
at System.Windows.Application.OnStartup(StartupEventArgs e)
at System.Windows.Application.<.ctor>b__1_0(Object unused)
at System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Int32 numArgs)
at System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Int32 numArgs, Delegate catchHandler)
2022-08-11.txt
✔ Expected Behavior
No response
❌ Actual Behavior
No response
Other Software
No response

/dup #9742

Would you mind:
1 - Uninstall PowerToys.
2 - See if the PowerToys install directory (default: C:\Program Files\PowerToys) is still there. If it is, delete it manually.
3 - Install PowerToys.
Please let us know if this works for you.
/needinfo

Let's treat this issue as the new one for this. It looks like these files keep not being installed correctly for same cases up until 63.0.0 at least.

we took an approach with #21327.  We can't repro this inhouse but we clearly see this failure and somehow that file is getting cleaned up and not reinstalled. so we're testing out a different way to load the file

Issue is still present in PowerToys v0.68.0.
Copy of my comment from #24589 (duplicate of this issue):

I am getting the same exception on application start.
However, all the modules I am using seems to be working normally afterwards. I rarely use PowerLauncher / PowerToys Run. Some quick troubleshooting shows that manually selecting "Light" as app theme does not prevent the crash / exception. Disabling PowerToys Run removes the exception and error box on each login / app start.
Excerpt from log file:
[2023-03-06 11:08:59.9784] [INFO] [C:\a\_work\1\s\src\modules\launcher\PowerLauncher\App.xaml.cs::63]
Starting PowerToys Run with PID=3804

[2023-03-06 11:09:00.2110] [INFO] [C:\a\_work\1\s\src\modules\launcher\PowerLauncher\App.xaml.cs::74]
Runner pid=17336

[2023-03-06 11:09:04.8886] [INFO] [C:\a\_work\1\s\src\modules\launcher\PowerLauncher\App.xaml.cs::116]
On Startup.

[2023-03-06 11:09:06.4003] [FATAL]
## Exception

System.IO.FileNotFoundException: Could not find file 'C:\Program Files\PowerToys\modules\launcher\Images\app.dark.png'.
   Source: System.Private.CoreLib
   TargetAssembly: System.Private.CoreLib, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=7cec85d7bea7798e
   TargetModule: System.Private.CoreLib.dll
   TargetSite: Microsoft.Win32.SafeHandles.SafeFileHandle CreateFile(System.String, System.IO.FileMode, System.IO.FileAccess, System.IO.FileShare, System.IO.FileOptions)
   at Microsoft.Win32.SafeHandles.SafeFileHandle.CreateFile(String fullPath, FileMode mode, FileAccess access, FileShare share, FileOptions options)
   at Microsoft.Win32.SafeHandles.SafeFileHandle.Open(String fullPath, FileMode mode, FileAccess access, FileShare share, FileOptions options, Int64 preallocationSize, Nullable`1 unixCreateMode)
   at System.IO.Strategies.OSFileStreamStrategy..ctor(String path, FileMode mode, FileAccess access, FileShare share, FileOptions options, Int64 preallocationSize, Nullable`1 unixCreateMode)
   at System.IO.Strategies.FileStreamHelpers.ChooseStrategyCore(String path, FileMode mode, FileAccess access, FileShare share, FileOptions options, Int64 preallocationSize, Nullable`1 unixCreateMode)
   at System.IO.FileStream..ctor(String path, FileMode mode, FileAccess access, FileShare share)
   at System.Windows.Media.Imaging.BitmapDecoder.SetupDecoderFromUriOrStream(Uri uri, Stream stream, BitmapCacheOption cacheOption, Guid& clsId, Boolean& isOriginalWritable, Stream& uriStream, UnmanagedMemoryStream& unmanagedMemoryStream, SafeFileHandle& safeFilehandle)
   at System.Windows.Media.Imaging.BitmapDecoder.CreateFromUriOrStream(Uri baseUri, Uri uri, Stream stream, BitmapCreateOptions createOptions, BitmapCacheOption cacheOption, RequestCachePolicy uriCachePolicy, Boolean insertInDecoderCache)
   at System.Windows.Media.Imaging.BitmapImage.FinalizeCreation()
   at Wox.Infrastructure.Image.ImageLoader.Initialize(Theme theme)
   at PowerLauncher.App.<>c__DisplayClass19_0.<OnStartup>b__0()
   at Wox.Infrastructure.Stopwatch.Normal(String message, Action action)
   at PowerLauncher.App.OnStartup(Object sender, StartupEventArgs e)
   at System.Windows.Application.<.ctor>b__1_0(Object unused)
   at System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Int32 numArgs)
   at System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Int32 numArgs, Delegate catchHandler)

## Environment
* Command Line: "C:\Program Files\PowerToys\modules\launcher\PowerToys.PowerLauncher.dll" -powerToysPid 17336 --started-from-runner
* Timestamp: 03/06/2023 11:09:06
* Wox version: <IP_ADDRESS>
* OS Version: Microsoft Windows NT 10.0.22621.0
* IntPtr Length: 8
* x64: True
* CLR Version: 7.0.3
* Installed .NET Framework:
   * v2.0.50727 2.0.50727.4927 SP2
   * v3.0 3.0.30729.4926 SP2
   * v3.5 3.5.30729.4926 SP1
   * v4 Client 4.8.09032
   * v4 Full 4.8.09032
   * v4.0 Client <IP_ADDRESS>

Still happening in 0.70.0. In case you find this problem, you can fix it with this workaround (faster than reinstalling):

Download the file from the repo: https://github.com/microsoft/PowerToys/blob/main/src/modules/launcher/PowerLauncher/Images/app.dark.png
Copy it to Program Files\PowerToys\modules\launcher\Images\

This has been a "🤦" one to hunt down.
In reality, we don't even use the launcher app "app.dark.png" file for anything I'd consider useful. All we do with it is load it at startup into the cache assuming it'll be used generally by the plugins as the default icon and free the handle. However, we've changed it so that each plugin uses its own default icon so it seems like this is no longer useful. We still use "app_error.dark.png" and its light equivalent as the default error icon when we can't find an image or thumbnail.
So what was causing the file to remain locked? I've used sysinternals Process Explorer to understand the usage of the file and verified that indeed the process has a handle for the app.dark.png file 🤔 But only that file in the Images folder.
It turns out that MainWindow.xaml is using app.dark.png as the icon for the Window, which isn't even visible. I've never been able to replicate having that file locked past uninstall or closing the PowerLaunch app but it's possible that it might happen if there's some sort of debug tool listing windows and showing their icons? Hard to know at this point.
Anyway, the fix here seems to be to remove the window's icon, which isn't even visible, and just generally remove the files and their usage from the code, since it seems they're not used anymore. I'll do some more in depth tests to make sure and open a PR afterwards.

This has been fixed with 0.71


chore: go-demo-6 to 1.0.461

chore: Promote go-demo-6 to version 1.0.461

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers:
If they are not already assigned, you can assign the PR to them by writing /assign  in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Create popup UI to display most visited sites.

Is your feature request related to a problem? Please describe.
Currently, most visited sites shown in a normal div element. We can add popup in the top left side to see the most visited sites.
In this feature, design new UI and display those link as Hyperlinks with Title only
Additional context
This feature is on a top-sites branch
https://github.com/pprathameshmore/Achieve-Chrome-Extension/tree/top-sites
Current UI

Excepted UI

what do you want to achieve here

@amycruz97 Just show that list most visited sites in popup UI.

@amycruz97 Can you suggest any idea to show the most visited sites on this page. So can minimalist UI

Do you want the most visited sites in a day or a week or some particular number of days?

@tapish2000  No, just display which top-visited. These sites provide by browser API. Take a look at the top-sites branch

@pprathameshmore Sorry to be unclear, I was asking if you want to enlist the top-visited sites of the day or week or is it a continuous data. I will check the top-sites branch.

Hey, I had written a sample code there, Browser API will return the required data. No need the worry about other things. Just display properly.

Yeah, I got everything.
There should be a button at the top left corner named Links which will show a popup with most visited sites (taken from Browser API) when clicked. And you just want a good looking frontend for this.
I want to work on this. Can you assign the issue to me?

Yes go ahead

Hey @pprathameshmore, how is this?

Tell me if you want anything else in this. This is just a preview.

Yeah good to go!

@pprathameshmore Should I hardcode the links or can you tell me exactly from where to take the top sites' links.
This somewhat looks like this for now.

Create popup and display links.

For the links, do you want an option like + New Link (as in the figure above) where user can click and get a popup in which he can add a link or you want to use the API and get the most visited links from the browser and have a list displayed in this popup?

As per your choice you can implement. You can keep both features. Keep UI simple and clean.

@pprathameshmore Can you review this:

Actually, this will be this much longer according to what is returned by the chrome API. Is it fine?

Looks cool. Make a pull request.

@tapish2000 Can you make another PR?
Have seen you bug in the extension? When we trying to load a background image, the text gets hidden till the image gets loaded. but the problem is not with LINKS.

Try to load a new background image and open a new tab immediately. You will see the problem.


Update MD file on new branch 2017-35-18_07-12-56

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

split/updateTestRef.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


CoffeeCups in BoundsControlExamples have incorrect local space

Describe the bug
The local space of each CoffeeCup in the BoundsControlExamples scene is aligned to the World's space, so for example setting UseLocalSpaceForConstraint in Rotation Axis Constraint to true becomes meaningless.
To reproduce
Steps to reproduce the behavior:

Go to BoundsControlExamples.
Click on a CoffeeCup GameObject.
Notice how the coordinate system's gizmo on the object is aligned with the World's.
Repeat 2-3 a few times.

Expected behavior
My understanding is that the local coordinate system should be aligned to one face of the mesh.

I can't repro either, so that must be it, sorry about the hassle.


Implement a disconnect/1 function

I read through the specification, and on of the things missing is a way to shutdown a connection cleanly. This would entail sending a disconnect package to the server.
Because this is the place I go to over-engineer stuff I think about the following.

The disconnect/1 command should sit on Tortoise.Connection and it should take a client_id as an argument
When executed the disconnect will send a :shutdown status on the Tortoise.Events pubsub, which the inflight manager will receive—at which point it should stop accepting packages to track—in other words, the connection should stop accepting subscribe, unsubscribe and publish messages with QoS>0. Notice that QoS=0 packages will still be handled at this point, this is okay as there are no delivery guarantees for them anyways
The inflight manager will now complete the inflight messages (in reality there would be very few, but for some extremely slow connections this might make sense…). When the pending inflight messages has been handled it should somehow communicate to the rest of the system that we are ready for shutdown
We should send the disconnect command
The connection process should shut itself and its children down

I should consider sending errors such as {:error, :connection_terminating} messages to processes waiting response on inflight messages if they are not completed in a reasonable time. Also, processes that tries to put messages on the wire after the termination has started could get the same error.

For now I just cancel the inflight messages; perhaps it would be possible to fulfil the inflight messages while not accepting any new publishes and subscription. This could be a future improvement.


[3.x] Update all to new toolchains, add Linux arm64 and arm32 builds

Backport of #89 and #90, in sync with https://github.com/godotengine/build-containers/pull/135.
In the 3.x branch, the situation with arch and bits is very brittle, so we only add the explicit arch argument for the arm32/arm64 builds. x86_32 still relies on bits=32.
This would all be worth refactoring upstream like we did for 4.0, but it's a major undertaking and breaking change, which I'd prefer to avoid in 3.6.
For Linux builds, we move the strip calls to the link stage, as this
needs to be done with the arch-appropriate strip binary, so it's easier
done there. In master, we now let the compiler strip automatically
during the build if no debug symbols are requested, but this change
wasn't backported to 3.x.

Tested successfully for almost all platforms, I'm just battling some final issues with Linux arm32 (https://github.com/godotengine/godot/pull/87258, and it looks like our buildroot will need to change its config to enable NEON intrinsics).
This is meant to be used with 3.x-f39-mono-<IP_ADDRESS> containers built from https://github.com/godotengine/build-containers/pull/135.

Tested successfully.


exploitdb: 2022-03-08 -> 2022-03-09

Description of changes
update to 2022-03-09

Things done

Built on platform(s)

[X] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[X] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 163453 run on x86_64-linux 1

1 package built:

exploitdb


Clearing and reading the unread notifications

How can i read the unread notifications? If a notification is sent and user opens the app from app list instead of notification then how should i read(and/or clear) the notiifcation?

Hi @ashish-agarwal
could you please provide your updated  flutter doctor -v
and your flutter run --verbose?
Also, to better address the issue, would be helpful
if you could post a minimal code sample to reproduce the problem
Thank you


Updated Launcher Icon thanks to @hafizahmmed

😍 , thanks @hafizahmmed.  Feel free to PR any other changes if you still want to.

Ooops, forgot to commit the AndroidManifest.xml change.  Just pushed that to master here: https://github.com/handstandsam/ShoppingApp/commit/d5543f30d44bec85c562669a201887c9065ea4e1


"Multiple declarations" error when using types defined with typedef

I have types in my code that use typedef statements to specialize some of the standard container types.  I get a "Multiple declarations" error for to_json when I attempt to convert one of these to json so I can output them into a results file.
Example:
typdef vector<float> State;
typdef vector<float> Offset;

and I use it inside of other types like
struct Node {
    Offset offset;
    State state;
    float cost;
}

I tried defining a to_json instance for my Node type like so:
void to_json(json& j, const Node& n) {
    j = json{{"cost", n.cost}, {"state", n.state}, {"offset", n.offset}};
}

but I get an extremely verbose error telling me I have multiple declarations of the to_json instance.  It's similar to the error I would get when using the implicit conversion of n.state = j.at("state") without using get<vector<float>>().
I also tried explicitly copying the values to no avail.
void to_json(json& j, const Node& n) {
    vector<float> state = n.state;
    vector<float> offset = n.offset;
    j = json{{"offset", offset}, {"state", n.state}};
}

The full error message is really long but I can add it upon request.

I cannot reproduce the error. This code works (Clang):
#include "json.hpp"

using json = nlohmann::json;

typedef std::vector<float> State;
typedef std::vector<float> Offset;

struct Node {
    Offset offset;
    State state;
    float cost;
};

void to_json(json& j, const Node& n) {
    j = json{{"cost", n.cost}, {"state", n.state}, {"offset", n.offset}};
}

int main()
{
    Node n;
    n.offset = {1.1, 2.2, 3.3};
    n.state = {4.4, 5.5};
    n.cost = 47.11;

    json j = n;
    std::cout << std::setw(2) << j << std::endl;
}

Output:
{
  "cost": 47.1100006103516,
  "offset": [
    1.10000002384186,
    2.20000004768372,
    3.29999995231628
  ],
  "state": [
    4.40000009536743,
    5.5
  ]
}

Did you put the to_json implementation in a header file and not use the inline keyword?

@gregmarr that worked, thank you very much!  Is there any reason in particular that I have to use an inline statement?
Anyway, the error message has changed, I think I'm close to figuring it out now, I think it's just an issue with make not being able to find the definitions...

The reason for inline is that you're telling the compiler that you expect this definition to appear in multiple "translation units" and that it should eliminate all the extra definitions.

@gregmarr I've got everything working now, thank you so much!


Make it possible to send a DM to bots and to yourself when DMs are disabled

Even when DMs are disabled, you should still be able to send a DM to bots and to yourself. We broke something about this at some point, though. Currently, with a bot:

Replying to a message works fine.
Starting a new conversation looks like it won't work, but you can actually do it if you send with the keyboard (the button is disabled).

The tooltip on the disabled "Send" button also looks broken specifically when you're composing to a bot, probably because that button is actually supposed to be enabled, and we're in some weird intermediate state:

This bug is mainly because of the placement of check_posting_policy_for_compose_box method inside on_compose_select_recipient_update rather than update_on_recipient_change, which is causing it to update the posting policy of compose only when you change the things in recipient dropdown, and not when you update the sender.

CZO thread

@zulipbot claim


Save model in steps, (12 hours for an epoch) learner.fit_onecycle(8e-5, 1)

Hello Arun,
Fantastic job! I can't even save full one epoch, takes more than 12 hours for an epoch, how do I save and train more and save.
I read your FAQ, but I can't finish even one cycle training to save it in ktrain.get_predictor(model, preproc).save('/tmp/my_predictor')
I assume here preprocess = t.
I was hoping for at least saving steps, and half of an epoch.
I'm using your huggingface A3 example. My notebook is here.
Thank you.
Rakib, Bangladesh

Duplicate of #276

Hello:  This has been already requested as an enhancement.  That said, BERT is a large model that takes a long time to train and your training set has over 350K examples.  One of the advantages of pretrained models is that you can achieve good performance with a smaller training set.  For the time being, I would suggest sampling the dataset and seeing what performance you get.  There is probably some degree of redundancy in a dataset that large.


Callback option on error

What is your Test Scenario?
If one of my tests fail, i basically want to dump the browser console or network logs to see what went wrong.
What are you suggesting?
Add an option to allow us to add a callback for when an error occurs, then we can perform our debugging logic
What alternatives have you considered?
Print console in after each of the fixture but it doesn't call the after each when an error happens
Additional context
Sometimes my tests are failing inconsistently when my pipeline is running. I'm looking at the screenshot and there is an error message on screen but i have nothing else to work with. I can't reproduce the error on my computer and it only happens on the CI sometimes.

Hi,
Normally, TestCafe should execute the test.after method if tests fail. It isn't executed only if an error occurred in the test.before method. Could you please create a sample where the test.after is not called in a failed test and share it with us?
Another way to call some method when error occurs is to wrap problematic statements and assertions in a try/catch block.
Here is an example:
import { Selector } from 'testcafe';

fixture `Getting Started`
    .page `http://devexpress.github.io/testcafe/example`;

test('My first test', async t => {
    try {
         await t.click('#submit-button-invalid')
    }
    catch(e){
        console.log("error logged in try/catch");
        throw e
    }
}).after(async t => {
    console.log("error logged in test.after");

});

This sample prints both "error logged in try/catch" and "error logged in test.after" messages on my side.

Hi,
Normally, TestCafe should execute the test.after method if tests fail. It isn't executed only if an error occurred in the test.before method. Could you please create a sample where the test.after is not called in a failed test and share it with us?
Another way to call some method when error occurs is to wrap problematic statements and assertions in a try/catch block.
Here is an example:
import { Selector } from 'testcafe';

fixture `Getting Started`
    .page `http://devexpress.github.io/testcafe/example`;

test('My first test', async t => {
    try {
         await t.click('#submit-button-invalid')
    }
    catch(e){
        console.log("error logged in try/catch");
        throw e
    }
}).after(async t => {
    console.log("error logged in test.after");

});

This sample prints both "error logged in try/catch" and "error logged in test.after" messages on my side.

Hey
Just looked and yeah looks like the error is happening in my beforeEach where I try to navigate to a certain page then conduct the test there. So, i'm not getting anything printed, i guess i'll try to wrap my beforeEach in a try/catch but would make sense if afterEach is fired regardless of what happened in the before/beforeEach.
Thanks

Thank you for pointing this out. We'll discuss this with the team.


#68 Fixes failing concurrent test by relaxing ordering requirements

The ordering requirement is relaxed for order of log events produced by SingleNodes under tested CompositeNode.
Description
Created a new range Position constructor allowing specifying ranges and provide nodeLog.
Then applied for the test to allow any ordering of inner log entries.
Motivation and Context
Fixes #68
Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.

I hereby agree to the terms of the Knot.x Contributor License Agreement.

Please check Azure build.

It's weird - looks like they did not get refreshed/recompiled? I can see that all of the instances of Position class in this test turn out to be of type io.knotx.fragments.engine.FragmentEventLogVerifier$ExactPosition, whereas the code states that 3 out of 4 of them should be of type RangePosition.


Service integration

Current coverage is 37.35%

Merging #27 into master will not affect coverage as of 1449a06

@@            master     #27   diff @@
======================================
  Files          204     204
  Stmts        11013   11013
  Branches      1933    1933
  Methods          0       0
======================================
  Hit           4114    4114
  Partial        534     534
  Missed        6365    6365

Review entire Coverage Diff as of 1449a06

Powered by Codecov. Updated on successful CI builds.


IDENTITY-4099 Add audit logs to privileged operations - Workflow

Remove all the try - catch surrounding the listeners. Thats the beauty of this pattern; the business layer doesn't know to handle exceptions arising from the extensions; they just let it be throw outside the method.

In this one and all the workflow listeners, for any get methods' post listeners, can you pass the result of the do method also as the first final argument.


Help needed with mfa

Hello,
i am currently struggling with registering oidc client. Ive set up keycloak and followed the guide on how to set it up. Everything runs on local host:
https://nhas.github.io/wag-vpn.github.io/docs/guides/single_sign_on_with_keycloak/
It kinda works, when i connect via VPN and visit <IP_ADDRESS>:82, i get redirected to keycloak and log in with my credentials. Then keyclaok is set to redirect to the servers port 8080, which should be the MFA, but it get a 404 response? wag logs then show the following:
2024/02/02 09:52:18 user <IP_ADDRESS> registering with oidc
Strangely oidc is shown in wag management UI, but not shown as active when logging in with keycloak.
I am very new to wag and maybe i have set something up incorrectly, for references i added the config files and docker-compose:

Just a heads up you have leaked your keycloak admin password and wireguard private keys. So I am removing both files

Its also worth noting that I am trying to dial back on giving user support to folk unless there is a real bug involved due to time constraints :)

Thanks for the fast reply,
Yes, indeed. This is only running on local machine via VM without port forwarding, only for development and for production there will be set up new keys and also a PostgreSQL for keycloak. So i should be fine...
Browser redirection:
http://<IP_ADDRESS>:8080/authorise/oidc?state=****
keycloak logs:
2024-02-02 09:50:22,504 WARN  [org.keycloak.events] (executor-thread-33) type=LOGIN_ERROR, realmId=***, clientId=wag, userId=null, ipAddress=<IP_ADDRESS>, error=invalid_redirect_uri, redirect_uri=http://<IP_ADDRESS>:8080/authorise/oidc
Ok, thats understandable. I hope its a quick fix, otherwise feel free to close this issue and i hope i get it working.

My bad, this is an old one, now i runs these setting:

They are just not registered with mfa:

That means the registration process isn't marked as complete for some reason.
Are you able to log in with oidc?

Yes, maybe i have set the endpoint wrong, because currently i am redirecting to 8080, which is the port for the API where also users get registered? And if i read it right there should be a VPN endpoint where 2fa is made?
Flow i get in the url bar:
http://<IP_ADDRESS>:8080/authorise/oidc?state=76c8b353f7fbc947b9d50519e485527c&session_state=7aacea19-a44f-492e-a1a4-f69d0a581389&iss=http%3A%2F%2F<IP_ADDRESS>%3A86%2Frealms%2Fvpn&code=f0028bc4-689d-449c-b49a-254a88a64297.7aacea19-a44f-492e-a1a4-f69d0a581389.19ad0cc1-9527-43ef-b645-8c0695596b07
web response: 404 not found

I plan to address this issue throughout the week with the hope of resolving it. However, if it remains unresolved by Friday, I will close the issue...
Here's what's happening with the requests. Everything's fine until it tries to send the authenticated user flow to wag. Feel free to comment or not – I get that you're busy and your time is valuable.

Yeah that looks vaguely right to me at the moment. Im just gonna give it a test on the unstable branch, which is most certainly not ready for use.
However, it should roughly share the same code base as what you're running on

Yeah I just got a new cluster up and running and followed my own instructions. Seems to work fine for me.

{"IssuerURL":"http://<IP_ADDRESS>:8080/realms/test","ClientSecret":"","ClientID":"account","GroupsClaimName":"groups"}

Can you give me your wag logs on startup until new user registration?

For completeness, here is my wag config:
{
    "Socket": "/tmp/wag.sock",
    "NumberProxies": 0,
    "Proxied": false,
    "NAT": true,
    "HelpMail"<EMAIL_ADDRESS>    "Lockout": 5,
    "MaxSessionLifetimeMinutes": 2,
    "SessionInactivityTimeoutMinutes": 1,
    "DownloadConfigFileName": "wg0.conf",
    "ManagementUI": {
        "ListenAddress": "<IP_ADDRESS>:4433",
        "Enabled": true,
        "Debug": true
    },
    "Webserver": {
        "Public": {
            "ListenAddress": ":8081"
        },
        "Tunnel": {
            "Port": "8080"
        }
    },
    "Authenticators": {
        "DefaultMethod": "oidc",
        "Issuer": "<IP_ADDRESS>:8080",
        "Methods": [
            "oidc"
        ],
        "DomainURL": "http://<IP_ADDRESS>:8080",
        "OIDC": {
            "IssuerURL": "http://<IP_ADDRESS>:8080/realms/test",
            "ClientSecret": "",
            "ClientID": "account",
            "GroupsClaimName": "groups"
        },
        "PAM": {
            "ServiceName": ""
        }
    },
    "Wireguard": {
        "DevName": "wg1",
        "ListenPort": 53230,
        "PrivateKey": "",
        "Address": "<IP_ADDRESS>/24",
        "ServerPersistentKeepAlive": 0
    },
    "DatabaseLocation": "devices.db",
    "Acls": {
        "Groups": {
            "group:administrators": [
                "toaster",
                "tester"
            ],
            "group:nerds": [
                "toaster",
                "tester",
                "abc"
            ]
        },
        "Policies": {
            "*": {
                "Mfa": [
                    "<IP_ADDRESS>",
                    "<IP_ADDRESS>",
                    "<IP_ADDRESS>",
                    "<IP_ADDRESS>",
                    "<IP_ADDRESS>",
                    "<IP_ADDRESS>"
                ],
                "Allow": [
                    "<IP_ADDRESS>",
                    "google.com"
                ]
            },
            "group:administrators": {
                "Mfa": [
                    "<IP_ADDRESS>"
                ]
            },
            "group:nerds": {
                "Mfa": [
                    "<IP_ADDRESS>/32"
                ],
                "Allow": [
                    "<IP_ADDRESS>/32"
                ]
            },
            "tester": {
                "Mfa": [
                    "<IP_ADDRESS>/24",
                    "<IP_ADDRESS>/24"
                ],
                "Allow": [
                    "<IP_ADDRESS>/32"
                ]
            },
            "toaster": {
                "Allow": [
                    "<IP_ADDRESS>/32"
                ]
            }
        }
    }
}

Hello, thank you very much! It's working now. I'll be back soon with a quick rundown of what I had configured incorrectly and then close this issue, have a nice day :)

There was a configuration error in which I mistakenly set the IP address to my laptop's IP instead of the WireGuard server IP. The correct configuration should have been the IP address to the WireGuard server.
Here's the screenshot illustrating the incorrect configuration:

In the config.json, I only needed to set the IssuerUrl to my laptop's IP address; all other settings should be directed to the internal WireGuard server.
Here's the screenshot demonstrating the necessary adjustments:

For completion, heres my config.json
{
    "Socket": "/tmp/wag.sock",
    "Proxied": false,
    "NAT": true,
    "HelpMail"<EMAIL_ADDRESS>    "Lockout": 5,
    "ExternalAddress": "<IP_ADDRESS>",
    "MaxSessionLifetimeMinutes": 1440,
    "SessionInactivityTimeoutMinutes": 60,
    "DownloadConfigFileName": "wg0.conf",
    "ManagementUI": {
        "ListenAddress": ":4433",
        "Enabled": true
    },
    "Webserver": {
        "Public": {
            "ListenAddress": ":80"
        },
        "Tunnel": {
            "Port": "8080"
        }
    },
    "Authenticators": {
        "DefaultMethod": "oidc",
        "Issuer": "wag",
        "Methods": [
            "oidc"
        ],
        "DomainURL": "http://<IP_ADDRESS>:8080",
        "OIDC": {
            "IssuerURL": "http://<IP_ADDRESS>:86/realms/vpn",
            "ClientSecret": "<redacted>",
            "ClientID": "wag",
            "GroupsClaimName": "groups"
        },
        "PAM": {
            "ServiceName": ""
        }
    },
    "Wireguard": {
        "DevName": "wg0",
        "ListenPort": 8009,
        "PrivateKey": "<redacted>",
        "Address": "<IP_ADDRESS>/24",
        "MTU": 1420
    },
    "DatabaseLocation": "/data/devices.db",
    "Acls": {
        "Groups": {
            "group:test": [
                "erik"
            ]
        },
        "Policies": {
            "*": {
                "Allow": [
                    "<IP_ADDRESS>/24",
                    "<IP_ADDRESS>/32",
                    "<IP_ADDRESS>/24",
                    "<IP_ADDRESS>/32",
                    "<IP_ADDRESS>/24",
                    "<IP_ADDRESS>/24"
                ]
            }
        }
    }
}

Now everything works and i can authenticate users via keycloak, thank you very much for your help :)


Doc Update for Running application in other OS

Source command doesn't work for windows so to set all environment variable at once, creating a bash file using the .bat extension that contains a set of commands to set env variable required.

@re-Tick Please review this

LGTM. Thanks for highlighting

CLosing since this pr is no longer relevant


datakit-gh triggers on everything

The datakit-gh hook should only listen for Commits made.
Adding a comment to a PR shouldn't re-trigger a check.

I am not sure what you are referring too. You can select the events you send to it (currently PR changes and Status changes) in the webhook interface.

After discussing with @FrenchBen, it appears that the PR stream is updated on every modification of the PR (as we match the "last updated" field there). It would be better to check for SHA1 changes instead.


Checklist items are not in the same order as in Trello after adjusting order in Trello

Issue
I use checklists pretty extensively in Trello, and will reorder them quite a bit as I like to work top down. However, in the plugin view it looks like the checklist items are in order according to when they were added to the card.
Trello

You can see here I moved the item I added third to the second position
Obsidian

And you can see here that the order is still by when they were added
Expected Behavior
The checklist items should be in the same order as they appear in Trello
Versions
Obsidian: 0.12.18
Trello Plugin: 1.4.0

Fixed in v1.5.0.


'ViewContext' does not contain a definition for 'Controller'

For purposes of learning the new MVC 6 framework, I am in the process of converting a basic MVC 5 project to MVC 6. However, this project uses a few custom HtmlHelper extension methods, some of which use the Controller property of the htmlHelper's ViewContext to retrieve an UrlHelper instance to build an URL based on the passed 'action' and 'controller' parameters. This, however, produces the titular error message.
Was the omission of the Controller property an oversight or intentional, and if intentional, what do you suggest as workaround?

cc @rynowak

@dougbu @Eilon - should we expose IUrlHelper on IHtmlHelper?  I just wish there was a pattern for extension methods (e.g. on IHtmlHelper to get stuff from DI... I suppose an extension method can manually resolve the service, but that's not very pretty.

Regardless, IUrlHelper seems like the one missing piece here.
I'd say if you need more services than HtmlHelper uses you should extend and @inject, but we should have a low bar to write extension methods that do similar things to default HtmlHelper.

Agree end users don't need IUrlHelper hanging off IHtmlHelper. Already have a Url property injected in all IRazorPages.
But those writing IHtmlHelper extension methods are less likely to need an IUrlHelper than the IHtmlGenerator, which is the only place our helpers use an IUrlHelper.
What's most surprising to me is that IHtmlHelper exposes JavaScriptEncoder and UrlEncoder but not HtmlEncoder.

@rynowak you can't @inject if you want more than one component to replace the Html property. But then, that was always a problem even before @inject, so yeah just use @inject to add whatever made-up helpers...
@dougbu why would HTML helpers be any less likely to need URL helpers? That's probably the most common case. No one replaces IHtmlGenerator.

No one replaces IHtmlGenerator.

Agreed. But those extending IHtmlHelper have to get it from DI. That is, it's not exposed on IHtmlHelper.
Separately I dislike exposing IUrlHelper in IHtmlHelper because our IHtmlHelper implementation itself has no need of it. Exposing the IHtmlGenerator on IHtmlHelper and, perhaps, exposing IUrlHelper on IHtmlGenerator have no similar issues.

Not sure I understand. Are you saying someone writing an HTML helper needs IHtmlGenerator? I doubt that almost any helper would go through that effort...

Are you saying someone writing an HTML helper needs IHtmlGenerator? I doubt that almost any helper would go through that effort...

Using tried-and-true "if we need it, so will they" logic, those extending IHtmlHelper will definitely need the IHtmlGenerator. And, conversely, those extending IHtmlHelper probably won't need the IUrlHelper. If that logic doesn't hold water here, I got nothin.

@dougbu I don't immediately see the problem with, for example, exposing Controller, which has an IUrlHelper property, via the ViewContext, like it was before.

@dougbu I doubt anyone would write helpers like ours, because ours are just core fundamental input elements. Most helpers I've seen are more domain-specific, and don't re-use our stuff, or people just write their own stuff from scratch.

Is there any further development on the issue with accessing the controller?

@Halofreak1990 we mostly discussed IHtmlHelper extension methods in general. Were we correct you're less interested in the Controller instance than the IUrlHelper it exposes?
If yes, I recommend creating a brand new helper class over extending IHtmlHelper. That new class could be brought into a view using @inject. To get an IUrlHelper, include an IUrlHelperFactory parameter in its constructor and have the class implement IViewContextAware. Its Contextualize() method could invoke the factory to get the IUrlHelper you need. (Or, it could save the ViewContext for lazy-loading the helper later.)

@Halofreak1990 we mostly discussed IHtmlHelper extension methods in general. Were we correct you're less interested in the Controller instance than the IUrlHelper it exposes?
Yes. That's correct.

This issue is being closed because it has not been updated in 3 months.
We apologize if this causes any inconvenience. We ask that if you are still encountering this issue, please log a new issue with updated information and we will investigate.

Is there a workaround for the ViewContext.Controller in asp.net core? Could someone put a link here. I am migrating an application to core 2 and I have controllers with extension methods which i access from my views e.g if(ViewContext.Controller.HasRole("HRManager"){...}. I really need this to work and I can't seem to get any headway!

Hi, it looks like you are posting on a closed issue/PR/commit!
We're very likely to lose track of your bug/feedback/question unless you:

Open a new issue
Explain very clearly what you need help with
If you think you have found a bug, include detailed repro steps so that we can investigate the problem


Mention rules for using Godot classes in the readme

Closes #358.

@BastiaanOlij This looks good to merge.


Add support for gherkin formatter version 12.53.22 (along with versio…

Add support for gherkin formatter version 12.53.22 (along with version 12.53.19) - change the default glob to **/*OctaneGherkinResults.xml
The default glob was **/OctaneGherkinResults.xml. I added the extra * to support the new formatter version that creates unique file names with the OctaneGherkinResults.xml postfix.
Please Make sure these boxes are checked before submitting your pull request - Thanks ahead!

[V ] Proper pull request title - concise and clear for others.
[ V] Proper pull request short description - clear and concise (as it should appear in the Jira ticket) for other developers and users.
[ X] Proper Jira ticket - Number, Link in pull request description.
[V ] The PR can is merged on your machine without any conflicts.
[V ] The PR can is built on your machine without any (new) warnings.
[V ] The PR passed sanity tests by you / QA / DevTest / Good Samaritain.
[ X] Add unit tests with new features.
[X ] If you added any dependency to the POM - Please update @YafimK

approved for test build

@m-seldin moved it to Octane-latest

@sharonvardi Please create short java doc documentation for the class changes

done

@m-seldin can you please approve & merge?

approved to merge


[CODEOWNERS] Update Code Owners for sdk/communication

Added myself and Add azure-sdk-communication-code-reviewers to the reviewers

/check-enforcer override


add block producing explainer doc

resolves #8650
add block producing explainer documentation

There are more options added in 2.0.1+ to the producer plugin and others but these will be addressed in other PRs.

pls merge it as well I do not have privileges.


Add README to the gh-pages branch.

Adding cla: yes label, as the PR author is a googler at the time of this PR was created.


Problem with instance segmentation when resolution size is not square in C++ inference

Inference have no problem in 25602560 resolution, but error in 12802560.
models export to onnx’s input-shape is 1 3 1280 2560, and test in python infer success.

Inference have no problem in 2560_2560 resolution, but error in 1280_2560. models export to onnx’s input-shape is 1 3 1280 2560, and test in python infer success.

You should also modify the seg_h and seg_w to your own model size.
4x down sample


Uncomplete parts in the resource potential calcualtion

Move sewage potential calculation to the resource folder
Add natural gas resource potential to the resource folder
Documentation: the geothermal.py is used to calculate ground temperature, it is independent from the technology.

done in pull request i264


Double Tagging Vlan Id Issue OFBadActionErrorMsgVer13(xid=1700, code=BAD_ARGUMENT

Hi
I need to generate the double Vlan tag and install the flow rules in IPv4 such that when packet comes to the switch , switch will add the double Vlan tag in the Packet header.
We have tried the below combination of below EthType  value.
EthType.IPv4 and EthType.VLAN_FRAME for Inner Tag.
EthType.BRIDGING and EthType.Q_IN_Q for Outer Tag.
But we are getting  Exception :- OFBadActionErrorMsgVer13(xid=1700, code=BAD_ARGUMENT,
Could you please suggest

value for Inner and outer Vlan tag for IP4 (TCP) packets?

some steps or tutorial for vlan tag?

Code:-

ArrayList vlan_action = new ArrayList();
OFFlowAdd flowAdd ;
//Inner Tag
OFVlanVidMatch ofvlanInner = OFVlanVidMatch.ofVlan(2);
vlan_action.add( new OFActionsVer13().pushVlan(EthType.VLAN_FRAME) );
vlan_action.add( actions.buildSetField().setField( oxms.vlanVid(ofvlanInner) ).build() );
//Outer tag
OFVlanVidMatch ofvlanOuter = OFVlanVidMatch.ofVlan(1);
vlan_action.add( new OFActionsVer13().pushVlan(EthType.Q_IN_Q) );
vlan_action.add( actions.buildSetField().setField( oxms.vlanVid(ofvlanOuter) ).build() );
OFActionOutput output = actions.buildOutput()
.setMaxLen(0xFFffFFff)
.setPort(OFPort.of(2))
.build();
vlan_action.add(output);
flowAdd = offFactory.buildFlowAdd()
.setBufferId(OFBufferId.NO_BUFFER)
.setHardTimeout(3600)
.setIdleTimeout(10)
.setPriority(32768)
.setActions(vlan_action)
.setMatch(match)
.setOutPort( OFPort.ofInt(2) )
.build() ;
sw.write( flowAdd );

@kharegaurav75 Are you the folks who were mailing the developers list about this issue?
If you're using OVS, I don't believe OVS supports double tagging (QinQ).

Hi Ryan
i had opened the issue.
Now, I have closed the issue as the  switch does not support the double
tagging functionality
Thanks
Gaurav
On Fri, Oct 30, 2015 at 11:00 PM, Ryan Izard<EMAIL_ADDRESS>wrote:

@kharegaurav75 https://github.com/kharegaurav75 Are you the folks who
were mailing the developers list about this issue?
If you're using OVS, I don't believe OVS supports double tagging (QinQ).
—
Reply to this email directly or view it on GitHub
https://github.com/floodlight/floodlight/issues/600#issuecomment-152594889
.


Modularize core functionality, consolidate global state

Goals (tl;dr)

Modularize core functionality
Consolidate global state from non-core namespaces into core
Do all this while maintaining backwards compatibility

Goals (prose)
This is part of an attempt to consolidate state into re-frame.core so that other re-frame namespaces can be used in a more library-like manner. The goal is not to make this easy to use for regular re-frame users or even the default but rather step by step reduce how state is spread out across the codebase. Later on this should simplify the implementation of "multiple re-frame instances" and similar scenarios (e.g. devcards or using re-frame's eventloop/fx/cofx stuff with non-reagent projects).
There are a few critical pieces of state as far as I can see:

re-frame.registrar/registry for cofx event fx and sub
re-frame.router/event-queue FSM for processing events
re-frame.subs/query->reaction subscription cache
re-frame.db/app-db

Changes

The change done here moves the state from the re-frame.registry, re-frame.router, and re-frame.subs namespaces into re-frame.core and parameterizes the public API accordingly. Furthermore it turns the registry and subscription cache into a protocol and record similar to what's done in re-frame.router.
re-frame.db/app-db is still used directly as before.
re-frame.registrar has been renamed to re-frame.registry (why?)
Tests are passing but I'm not sure if the test suite is particularly expansive in the aspects affected by this change.
Example apps continue to work without modificaton

TBD

[x] Moving the subscriptions cache into the frame singleton is still TBD
[x] also the default interceptors used for reg-event-* should be provided as arguments when creating frames so that it is possible to create a frame without any interceptors.
[ ] there's some state in the tracing namespace that should potentially also become a part of a frame

This is looking positive. I think the thing that Mike and I have always wondered is how this looks/works in a real application. Would you be able to port the todomvc to pass a frame around to see how it looks?

@danielcompton The todomvc continues to work with these changes as the core API is maintained through the re-frame.core/the-frame singleton. Mike mentioned that he is eager to see how this passing around would work and that he'd like to hold off changes like this one before that part is worked out. The change presented here however isn't aiming to address that. Reagent doesn't provide a way to work with React's Context yet and I don't have any good ideas right now (besides childContext) for that part.
That said this change should make it a lot easier for everyone to experiment with their ideas around this problem which to me seems like a logical first step.

Ah of course, I see now.

This honestly looks like a ol' good refactoring, with no API changes, which is good. I have not go deep into the code but I'd like to try it in one of my apps and report back.

@danielcompton @arichiardi @mike-thompson-day8
I updated this PR against latest master and implemented a few more changes (notably around the subscription cache and default interceptors).
At this point I would appreciate feedback & suggestions to carry this further. Also just running one or two more complex app on this branch would be of great help to find bugs the tests didn't catch. If that happens I would be happy to extend the test suite as well.


thrift.py3.exceptions.TransportError

Hi, When I run the 'make eval' command, it comes to the following error.
Do you have any idea to fix it up?
File "/app/t5-unc/utils/picard_model_wrapper.py", line 200, in with_picard
asyncio.run(_init_picard(), debug=False)
File "/opt/conda/lib/python3.7/asyncio/runners.py", line 43, in run
return loop.run_until_complete(main)
File "/opt/conda/lib/python3.7/asyncio/base_events.py", line 587, in run_until_complete
return future.result()
File "/app/t5-unc/utils/picard_model_wrapper.py", line 127, in _init_picard
await _register_schema(db_id=db_id, db_info=db_info, picard_client=client)
File "/app/t5-unc/utils/picard_model_wrapper.py", line 133, in _register_schema
await picard_client.registerSQLSchema(db_id, sql_schema)
thrift.py3.exceptions.TransportError: (<TransportErrorType.UNKNOWN: 0>, 'Channel is !good()', 0, <TransportOptions.0: 0>)

Hi, that means that the picard backend is either not running (yet) or unresponsive. Does this happen reproducibly?

Ran into the same issue. I wasn't using the make file but running it with
docker run \
    -it \
    --rm \
    --user 13011:13011 \
    -p 8000:8000 \
    --mount type=bind,source=/Users/david/database,target=/database \
    --mount type=bind,source=/Users/david/transformers_cache,target=/transformers_cache \
    --mount type=bind,source=/Users/david/configs,target=/app/configs \
            tscholak/text-to-sql-eval:35f43caadadde292f84e83962fbe5320a65d338f	 \
    /bin/bash -c "python seq2seq/serve_seq2seq.py configs/serve.json"

trace
Traceback (most recent call last):
File "seq2seq/serve_seq2seq.py", line 151, in
main()
File "seq2seq/serve_seq2seq.py", line 97, in main
model = model_cls_wrapper(AutoModelForSeq2SeqLM).from_pretrained(
File "seq2seq/serve_seq2seq.py", line 91, in
model_cls=model_cls, picard_args=picard_args, tokenizer=tokenizer
File "/app/seq2seq/utils/picard_model_wrapper.py", line 199, in with_picard
asyncio.run(_init_picard(), debug=False)
File "/opt/conda/lib/python3.7/asyncio/runners.py", line 43, in run
return loop.run_until_complete(main)
File "/opt/conda/lib/python3.7/asyncio/base_events.py", line 587, in run_until_complete
return future.result()
File "/app/seq2seq/utils/picard_model_wrapper.py", line 127, in _init_picard
await _register_tokenizer(picard_client=client)
File "/app/seq2seq/utils/picard_model_wrapper.py", line 145, in _register_tokenizer
await picard_client.registerTokenizer(json_str)
thrift.py3.exceptions.TransportError: (<TransportErrorType.UNKNOWN: 0>, 'Channel is !good()', 0, <TransportOptions.0: 0>)

It happens when I use the UnifiedSKG code to train a t5-large model, and I copy the picard_model_wrapper into the UnifiedSKG code.
In my view, UnifiedSKG code is same as picard code.
So I can not understand why it happened.

Hi, author here. It is not enough to just copy the picard model wrapper. This wrapper is just one small piece in the picard parsing approach. There are library components and a picard executable as well. In most cases, I recommend using the eval image with your model, that is, rather than trying to take picard and put it somewhere else, bring what you have (e.g. a checkpoint) to this codebase and docker images. For most people, that approach is quicker and easier.

@david-seekai let me have a look.

Great thanks I'm using the GKE Container-Optimized OS.
https://cloud.google.com/container-optimized-os/docs/concepts/features-and-benefits
Let me know if I can help in anyway or if any other info is needed.

@tscholak yep, I do use the picard eval image as the docker environment.
I do try the bring the ckpt to this codebase, but I face a problem.
The same ckpt has the different performance between two codebase, for example, 68.5 em in UnifiedSKG, but 66.2 em in this codebase without picard mode.

I recommend comparing the generated outputs. if they are the same, then the issue is the evaluation. if they are not the same, then something is different about they are generated.

Yep, I compared the generated outputs and they are different.
I control the same package version, same input format, same function such as generate and evaluate.
But I still do not know why it happened. It is really confusing.

Hey! I'm reproducibly getting the same error using make prediction_output
Any ideas?

Hello, I fixed this problem by changing time.sleep(1) to 10 in line seq2seq/utils/picard_model_wrapper.py 95. I guess because the child process has not started successfully, the main process connected, so this error will be reported.


Does the (date) switcher still exist?

I am very confused. The docs indicate there is a date switcher command Periodic Notes: Show date switcher... but I do not see that command. In fact, I don't see any switcher commands?

Hi, the date switcher is still only in the beta version and I plan on releasing it soon. I'll add a "coming soon" note to the features that haven't been released just quite yet. Sorry for the confusion.

Got it. Thank you!