security of using this and avoid user modifying javascript to remove filters and see more data?

I want to have embed dashboard on my website that will change dynamically to show data only for the logged in user that is map with a elasticsearch field document like user_id.
But using this plugin looks like any can open browser tools and modify javascript method to change filter to * and view all data from all users.
Any method to avoid this?

Do you use x-pack or searchguard ?
(https://github.com/floragunncom/search-guard)

No, also i dont see how can that help, i dont want to have a login user/password in xpack for each different user i want to show data. I want to filter that in my application.

with xpack/searchguard i know i can define user/password and associate some filter but then my app will have to know all user/password in xpack right? and aslo can i have one dashboard shared across all users or i need to define dashboard again and again on every user/role in kibana.

I recommend  you to protect your elasticsearch index, otherwise the users can reach your kibana embedded url and navigate to kibana admin(5601 port) and then go to "dev tools" tab and there delete your index.
I have a question:
There is a different in kibana dashboard between two users for example different visualisation or the only different thing is the data?

no difference in dashboard, we want to use same dashboard, just data change across users logged into my website

So unfortunately, I think that kibana-API is not the plugin that you looking for, kibana API expose kibana(not elasticsearch) functionality like create visualisation dynamically, create index pattern dynamically etc.
As I understand your problem is how to expose specific data to specific user, it is not this plugin scope.
I have two suggestions:

create different index for each user, then in kibana embedded URL change the index pattern for specific user,in this solution you can use kibana-API plugin to create the index-pattern dynamically.
Like I said try use search-guard, I think it exactly what you looking for

ok, i understand. Thanks!


3D Scene I/O optimization and bugfixes

Change log
Optimizations

Added a cache to compute_metadata() to avoid recomputing metadata for repeated 3D asset paths

Bugfixes

Handle partial maps when updating Scene asset paths

Unit test added would previously fail but now succeeds as expected

should this be targeting release/v0.24.1 to go out with release/v1.7.1 or is this a develop-only bug?


Can edit comments in the admin portal once posted. Needs to be non-editable once posted.

[ ] Can edit comments in the admin portal once posted. Needs to be non-editable once posted.

Would you mind explaining the reason? I think it's nice to have an option to edit a comment.

We decided to let comments remain editable because comments are public-facing and need to be worded appropriately balancing transparency and security concerns.


Article: How to set up Eslint with Typescript in VS Code - missed suggestion to VSCode ext

https://github.com/Thesoreon/thesoreon.com/blob/0b197a720c8d0e49e8f7cc298485a831cf6e11d4/content/blog/how-to-set-up-eslint-with-typescript-in-vscode/index.mdx
Does Eslint works out of box for VS code or not? You should begin with kinda "shall we install an extension for ..."
cheer!

Hi, thanks for taking time to write the issue. This article of mine is quite outdated. I'll try to edit it or remove it (as ESLint support in VSCode is quite straightforward nowadays)


Cross-App Insights Resource Application Map

Does the Application Map support displaying information across multiple App Insights resources?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: bfc7b703-b823-5719-36de-0eeaf096b3ca
Version Independent ID: d85431d2-7253-80e9-9036-b62e2e230cca
Content: Application Map in Azure Application Insights - Azure Monitor
Content Source: articles/azure-monitor/app/app-map.md
Service: azure-monitor
Sub-service: application-insights
GitHub Login: @mrbullwinkle
Microsoft Alias: mbullwin

@bdschaap  Thank you for your question. The application map will indeed attempt to connect components that are in different App Insights workspaces.

Thanks.  Can you explain at a high level how this works?  I can understand it from a dependency perspective but it seems like that would only be for immediate dependencies.  However, immediate dependencies would not cover an app that makes a request to a service that then makes a request to another service.

The way you are thinking about things is correct. App Insights uses requests and immediate dependencies to put together the application map. So a UI and API that are in separate work spaces would get linked as the UI is making calls directly to the API. However, a couple of components that talk via Service Bus would not, as there is a layer in between.
The recommended way to setup App Insights is to use one instance per business system, using cloud roles to differentiate components. However, this isn't always possible based on other business requirements, which is why App Insights will attempt to work with data in different workspaces.
I'm going to close the ticket as there is nothing in the docs to be updated. If you have followup questions feel free to tag me in this thread, otherwise you can post questions to MSDN or Stack Overflow. We have employees active on those forums as well in addition to community members that will be able to help answer your questions.


try catch finally sendBadge

Move the sendBadge(format, badgeData); functions inside of finally blocks,
Don't know if there will be any performance differences, but should minimize the code base slightly.

Hey, wanted to say I'm willing to review this if you feel strongly about it.
I've been pushing back for a while on refactoring server.js, since we're about to rewrite all the services as they get broken out into separate modules a la #963. It uses async/await and the handlers return badgeData which basically means the existing logic will be used, but none of the existing structure.
Did you follow that PR? Now that it's merged we ought to open an issue to start discussing how to approach the rewrite. I did make a project but it doesn't have anything useful on it yet.
What are your thoughts?

Ah, completely forgot about that!
No worries, will close this PR.
Will be good to get that going, and a great time to add the currently missing tests too.

Thanks for understanding! And agreed!


[msal-node] Add getLogger and setLogger

This PR adds getLogger and setLogger functions to msal-node.

Coverage remained the same at 82.389% when pulling cbd0a9cc0b25aa6b077a6350c0aebeba7f41dbd8 on msal-node-set-logger into 36c6bc0bd6daba906f9d77bce31a543c137e3bf4 on dev.

Coverage remained the same at 82.389% when pulling cbd0a9cc0b25aa6b077a6350c0aebeba7f41dbd8 on msal-node-set-logger into 36c6bc0bd6daba906f9d77bce31a543c137e3bf4 on dev.


Duplicate data property in config.requirejsPaths

When a plugin and a seed share a name, configuration for requirejs has duplicate data property.

I would recommend people just don't name seeds and plugins w/ the same name... Would you prefer namespacing the components (plugins, etc)?

Sounds good to me. Users can add prefix or suffix if they want to use the same name.


cleanup_job condition is too restrictive

Ref: https://github.com/lyft/cartography/blob/ab04b205ee942700e352e5c8911d8a596c8c38d2/cartography/graph/cleanupbuilder.py#L148
Description:
Cleanup job requires that 'TargetNodeMatcher PropertyRefs in the sub_resource_relationship must have set_in_kwargs=True.'.
This condition is very restrictive and block cleanup for simple intel modules.
Ex:

Use an APIKey on Gandi
Retrieve organization (and organization id)
Pulling DNS Zones (and try to set DNSZone a sub-resource of the organization)
Pulling DNS Records (and try to set Records a sub-resource of the DNSZone)
You will not be able to cleanup DNSZone and DNZRecords due to the restriction

To Reproduce:
You can test this issue on #1235

pytest -vvv tests/integration/cartography/intel/gandi

Logs:
tgm = TargetNodeMatcher(name=item.registered_domain)

    def _validate_target_node_matcher_for_cleanup_job(tgm: TargetNodeMatcher):
        """
        Raises ValueError if a single PropertyRef in the given TargetNodeMatcher does not have set_in_kwargs=True.
        Auto cleanups require the sub resource target node matcher to have set_in_kwargs=True because the GraphJob
        class injects the sub resource id via a query kwarg parameter. See GraphJob and GraphStatement classes.
        This is a private function meant only to be called when we clean up the sub resource relationship.
        """
        tgm_asdict: Dict[str, PropertyRef] = asdict(tgm)

        for key, prop_ref in tgm_asdict.items():
            if not prop_ref.set_in_kwargs:
>               raise ValueError(
                    f"TargetNodeMatcher PropertyRefs in the sub_resource_relationship must have set_in_kwargs=True. "
                    f"{key} has set_in_kwargs=False, please check by reviewing the full stack trace to know which object"
                    f"this message was raised from. Debug information: PropertyRef name = {prop_ref.name}.",
                )
E               ValueError: TargetNodeMatcher PropertyRefs in the sub_resource_relationship must have set_in_kwargs=True. name has set_in_kwargs=False, please check by reviewing the full stack trace to know which objectthis message was raised from. Debug information: PropertyRef name = registered_domain.

cartography/graph/cleanupbuilder.py:159: ValueError

Here's why I restricted this.
In most cases, legacy Cartography modules have ingestion queries that use a keyword argument to identify the tenant. For example, here's AWS ECR identifying the owner account and here's GCP DNSZones identifying the owner project.
I wrote the querybuilder code as an abstraction around this. For example the parameters supplied to load() will look similar to how it did before where the tenant ID is specified as a kwarg:
https://github.com/lyft/cartography/blob/5c1aa119dad88bb2e934aee5bdcc77275f358ac7/cartography/intel/aws/emr.py#L67
and we tell the data model where to find that value here:
https://github.com/lyft/cartography/blob/5c1aa119dad88bb2e934aee5bdcc77275f358ac7/cartography/models/aws/emr.py#L48-L50
Theoretically, we could remove _validate_target_node_matcher_for_cleanup_job(), but I think having a specialized way to provide the tenant ID as a kwarg (as opposed to a key in the dict for other relationships) helps the module author be aware of tenant relationships. It's a very frustrating bug when cleanup jobs delete the assets in other tenants accidentally, so I'd like to keep this separated out.
I'm open to other thoughts and reconsidering but for the Gandi module and the Slack module, I don't think it's that much of a big lift to specify a kwarg to the tenant id in the call to load().

Oh, one more follow up on the examples you provided (those are very good call-outs):

Pulling DNS Zones (and try to set DNSZone a sub-resource of the organization)
Pulling DNS Records (and try to set Records a sub-resource of the DNSZone)
You will not be able to cleanup DNSZone and DNZRecords due to the restriction

When the data model refactor is done, I intend for all assets to have a relationship back to the owning tenant. Then automatic cleanups will work.

I'm catching myself going back and forth on whether this condition is too restrictive. @ramonpetgrave64 what do you think?

@achantavy, it's primarily a matter of defining the edge resource rather than restricting it or not.
With the definition you provided (i.e., the edge resource is the link between the tenant and all the elements of that tenant) to represent a tenant, a zone within it, and a record, I need:

Tenant -> Zone (with tenant ID in the kwargs)
Tenant -> Record (with tenant ID in the kwargs)
Zone -> Record (which is another relationship)
Without the tenant-record link, there's no auto-clean.

With a broader definition (i.e., the edge resource is any composition link between an element and a set of elements that compose it), we can limit it to:

Tenant -> Zone
Zone -> Record
The schema is simpler and seems more natural to me.

However, having security that prevents a "Root node" like a tenant from being deleted seems like a good idea, but perhaps it needs to be implemented differently.

I agree that having every item tie back to a tenant feels verbose, but I like it for consistency and keeping things organized especially in environments where there are multiple zones in multiple tenants with similar names.

Also agree that the way we have it now requiring all nodes be directly attached to a Tenant node does unintuitive at first. But it lets us write the load and cleanup queries in a reliable way. Still, we'd appreciate help to make the query builders more flexible.
Side note: As is, I have doubts if it will work well when a resource exists in multiple tenants, like with AWS IAM's foreign principals.

Side note: As is, I have doubts if it will work well when a resource exists in multiple tenants, like with AWS IAM's foreign principals.

I don't know of any examples of a resource belonging to multiple tenants. With AWS principals, a principal belongs to one tenant but can have trust relationships to another. Therefore there will still only be one tenant relationship.


ActiveRecord Single Table Inheritance search bug

When I need to make a search on STI ancestor (to get mixed results from all descendants) on one index (like in tests), I was usually getting error, because it makes 'find' from wrong class. Well, you can see it in tests.
Also it repaires one more bug: when you have two STI classes with separate indexes (like in default) and try to make a search like Tire.search('first_table_index,second_table_index', :load => true) { ... }, it also raises RecordNotFound.

Hi Andrew, thanks for taking your time to have a look into this. Sadly, this issue has been debated over and over -- please search the issues --, and there are now several patches trying to solve several problems related to this.
The thing is, I feel the codebase right now is too fragile to out it under more load. I like the way you're going in your patch, though, and will definitely look at it when doing some refactorings in February (hopefully).

@GearHead90 I like how you approach the problem, Andrew! I generally try to avoid ActiveSupport like a plague, but the group_by here works like a charm. I think this is a viable solution. I'll test it as the solution to "multi model searches" and will get back. Please ping me here or on IRC if I'll fail to do that in couple of weeks.


System Object Persistence Utility fails when attempting to create history.hist_stl_load_errors

CREATE TABLE IF NOT EXISTS history.hist_stl_load_errors (LIKE STL_LOAD_ERRORS); appears here:
https://github.com/awslabs/amazon-redshift-utils/blob/5c339b391b659e57c792eae5ab4435195751a6d4/src/SystemTablePersistence/lib/history_table_creation.sql#L3
That command, plus at least of one of the following ones (CREATE TABLE IF NOT EXISTS history.hist_stl_wlm_query (LIKE stl_wlm_query); fails because the argument to LIKE is a view rather than a table:
CREATE TABLE IF NOT EXISTS history.hist_stl_load_errors (LIKE STL_LOAD_ERRORS);
ERROR:  inherited relation "stl_load_errors" is not a table

A more-general question: I've run into a bunch of minor bugs and compatibility issues in the SystemPersistenceUtility CloudFormation stack that I've had to work around. These include

S3ConfigPath's AllowedPattern doesn't allow periods in bucket names (see https://github.com/awslabs/amazon-redshift-utils/issues/347#issuecomment-431107695):

https://github.com/awslabs/amazon-redshift-utils/blob/5c339b391b659e57c792eae5ab4435195751a6d4/src/SystemTablePersistence/deploy-systable-standalone.yaml#L35

KmsKeyARN's AllowedPattern has a forward slash rather than a colon before the 12-digit portion:

https://github.com/awslabs/amazon-redshift-utils/blob/5c339b391b659e57c792eae5ab4435195751a6d4/src/SystemTablePersistence/deploy-systable-standalone.yaml#L40

The Python runtime is python2.7, which AWS Lambda no longer supports:

https://github.com/awslabs/amazon-redshift-utils/blob/5c339b391b659e57c792eae5ab4435195751a6d4/src/SystemTablePersistence/deploy-systable-standalone.yaml#L59

It uses an old version of LambdaRedshiftRunner (1.4 instead of 1.5.1):

https://github.com/awslabs/amazon-redshift-utils/blob/5c339b391b659e57c792eae5ab4435195751a6d4/src/SystemTablePersistence/deploy-systable-standalone.yaml#L62
Is SystemPersistenceUtility being maintained? It looks as though substantive development ceased in late 2018. I'm wondering whether I should create separate issues for the problems I listed.

Hi, thanks for the summary. I have been looking into this and updating for Python3 as well as the view issues. Hope to have an update for this fairly soon.

Hi @patbl, can you try downloading the current versions and checking again? We have deployed fixes for the issue so that the SQL creates a table from the view, then uses that temporary table in the creation of the object. We have also updated the LambdaRedshiftRunner package, and lots of bug fixes! I will close this ticket, if you experience any of the same issues please let me know and we can reopen.


eth_sign: HOW TO?

Can't find anywhere how to perform the simplest of the transactions, an eth_sign. Could somebody please just complete this and show the rest how to do it? Let's say the documentation doesn't help with figuring it out :)
@gigajuwels
Thanks.

This is how my request class looks:
[RpcMethod("eth_sign")]
  public class EthSignRequest
  {
      [JsonProperty("id")]
      public int id { get; set; }
      [JsonProperty("jsonrpc")]
      public string jsonrpc { get; set; }
      [JsonProperty("method")]
      public string method { get; set; }
      [JsonProperty("params")]
      public string[] parameters { get; set; }

      public EthSignRequest(int id, string jsonrpc, string method, params string[] parameters)
      {
          this.id = id;
          this.jsonrpc = jsonrpc;
          this.method = method;
          this.parameters = parameters;
      }
  }

And this is how I create the request:
EthSignRequest request = new EthSignRequest(1, "jsonrpc", "eth_sign", new[] {address, message});

                string topic = _connectedData.Approval.Result.Topic;
                // Call the Request function and handle the Task<TR> result using async/await or ContinueWith or any other approach.
                Task<EthSignResult> requestTask = wcSignClient.Request<EthSignRequest, EthSignResult>(topic, request, chainId);
                await requestTask.ContinueWith(HandleRequestResult);

Finally this is the error I'm getting:

Can someone identify what I'm doing wrong?
Thanks in advance!

@gigajuwels any insights on this? thanks!

this worked for me
@dpradell-dev

Thank your for taking the time @nikitaessen! Tried exactly as you did but still getting the "invalid parameters" error. What version of WalletConnectUnity are you using? Thanks again!

Ok for everyone with this issue, @nikitaessen response is CORRECT but here's an important aclaration:
chainId needs to be passed as "ChainNamespace:ChainId", something like: "eip155:80001"


Try to fix permission check

Add parenthesis around permissions & (bitwise) to make JavaScript parse expressions correctly

#lgtm


Guide: Running Danger on multiple repos

Blocked by https://github.com/danger/danger/issues/249
But mainly a guide around how that works, and how you can get it set up. Reference plugins. Maybe some advice too.

https://github.com/danger/danger.systems/pull/27 covers this in two parts


Update the commandline/logs.md file to point to logging page

Need to point to the reference/logging page from the logs.md page as per comments on this PR: https://github.com/docker/docker/pull/11485/files#diff-bf81424845bcab2902c9809e30dfe6e0
Also should update the page to point that other drivers have other options

Hi!
Please read this important information about creating issues.
If you are reporting a new issue, make sure that we do not have any duplicates already open. You can ensure this by searching the issue list for this repository. If there is a duplicate, please close your issue and add a comment to the existing issue instead.
If you suspect your issue is a bug, please edit your issue description to include the BUG REPORT INFORMATION shown below. If you fail to provide this information within 7 days, we cannot debug your issue and will close it. We will, however, reopen it if you later provide the information.
This is an automated, informational response.
Thank you.
For more information about reporting issues, see https://github.com/docker/docker/blob/master/CONTRIBUTING.md#reporting-other-issues

BUG REPORT INFORMATION
Use the commands below to provide key information from your environment:
docker version:
docker info:
uname -a:
Provide additional environment details (AWS, VirtualBox, physical, etc.):
List the steps to reproduce the issue:
1.
2.
3.
Describe the results you received:
Describe the results you expected:
Provide additional info you think is important:
----------END REPORT ---------
#ENEEDMOREINFO

There is no more reference/logging.

Yup, there is, but it was moved to https://docs.docker.com/engine/admin/logging/overview/
let me open a PR


Updating README.md for issue #43

Adding verbiage to ReadMe explaining how to install Python2.7 compatible versions of matplotlib and numpy as OctoPrint does not currently ship with Python3.

Thanks, that should be helpful to some folks.


hash marks in terminal.integrated.defaultProfile descriptions

VS Code Version: 1.57.1
OS Version: Windows 10

Bring up the Settings JSON view.
There are trailing and leading # hash marks for the other setting references:
	// The default profile used on Linux. This setting will currently be ignored if either `terminal.integrated.shell.linux#` or `#terminal.integrated.shellArgs.linux` are set.
	"terminal.integrated.defaultProfile.linux": null,

	// The default profile used on macOS. This setting will currently be ignored if either `terminal.integrated.shell.osx#` or `#terminal.integrated.shellArgs.osx` are set.
	"terminal.integrated.defaultProfile.osx": null,

	// The default profile used on Windows. This setting will currently be ignored if either `terminal.integrated.shell.windows#` or `#terminal.integrated.shellArgs.windows` are set.
	"terminal.integrated.defaultProfile.windows": null,

The settings links are fine in the UI Settings editor.

@meganrogge Do you have any idea why those hash marks were added in the first place? I've seen them several times when a setting description references another setting.

I do not know. I suspect that was maybe at one time the way to emphasize text in markdown descriptions? We'd have to ask @Tyriar, which is why I've added him to this issue 😄

@meganrogge How did the description look in the Settings editor after your change. Were the settings references still links?

The links are now gone, which would normally be the wrong fix, but since the referenced settings are deprecated, the links don't work in 1.57.1. So just showing the referenced settings as inline code blocks, is probably the best experience.

Yes I thought it looked better with the change, though not ideal

The hashes enable linking between settings in the settings UI and it always looks kind of bad in the settings json, since it's deprecated I don't think it worked so this is fine 👌


Encrypt app private key in authentication response using app transit key

Closing this out, as this was implemented and merged back in October.


Introduce xsimd::batch_bool<T,A>::mask()

This method extracts an integer mask from a batch_bool, similar to _mm_move_mask*
Fix #753

@Yuhta : I'd greatly appreciate a review of that patch. And if that's not asking too much, if you could contribute the arm implementation, that would be great ;-)

Thanks @serge-sans-paille , I am busy these days but will find some time to look at this

@Yuhta will you be able to contribute the arm version? cc @JohanMabille


Stop using odgi's Python bindings in parse_data.py

This PR is probably not complete: I'm a little blocked by #114 but I've made some progress anyway.
Instead of taking the input graph and parsing as an odgi graph, I instead parse it as a GFA. Then, instead of using odgi to grab simple statistics such as the number of nodes, paths, and the most steps in a given path, I use a method in preprocess.
⚠ This is not done! ⚠
It needs, at least:

To be tested, once #114 is cleared.
Changes in the documentation, telling people to pass .gfa and not .og

(Eventually) closes #107.

@susan-garry I need to get on a synchronous call with you to figure out the symlink situation here. I've been trying for a little bit to pass exine a gfa instead of an og, but I'm new enough to the setup that I'm really quite turned around. Does tomorrow work?
If you'd like to tinker on your own, check out this branch and run make test from pollen/. The recipe has been minimized; I just need to get the exine code to "see" the graph. Right now I get FileNotFoundError: [Errno 2] No such file or directory: '../ex2.gfa' although the file is where I think it should be.

Hmm; I get a somewhat different set of errors when trying this out. To narrow in on a specific test, I ran:
$ turnt -vp test/depth/subset-paths/ex1.txt
$ odgi depth -i ../basic/ex1.og -d -s ex1.paths
#node.id	depth	depth.uniq
1	1	1
2	2	1
$ exine depth -a -r ../basic/ex1.gfa -s ex1.paths
Traceback (most recent call last):
[...]
  File "/Users/asampson/Library/Python/3.11/lib/python/site-packages/mygfa/mygfa.py", line 292, in parse
    assert False, f"unknown line marker {fields[0]}"
AssertionError: unknown line marker .

That is, the odgi environment works fine, and we crash with a somewhat mysterious error. That problem comes from here:
https://github.com/cucapra/pollen/blob/f5917a6207858994774abe2d85b06b802a2fab29/pollen_py/pollen/depth/parse_data.py#L27
Because Graph.parse expects an open file, not a filename. So that should be something like Graph.parse(open(filename)).

Ah I had that right in one spot but wrong in another. Thanks! Fixed!
Now we have a different set of issues, having to do with all the other uses of odgi-ey stuff that are in the file but are not used by calyx_depth. For a taste:

graph.get_step_count(node_h)
graph.get_path(step_h)
graph.for_each_step_on_handle(node_h, parse_step)
graph.for_each_handle(parse_node)
graph.get_path_name(path_h)

I would love a confirmation on this, but as I understand it, these are used to create a .data representation of the given graph, but are not used by calyx_depth.py to generate the Calyx accelerator itself. Only get_dimensions is used in the generation of the accelerator. Is that right?
I'm unsure about how to proceed.
Truly removing odgi from parse_data would mean supporting all these getters and itererators in mygfa. Is that worth our time? Should we instead:

Let parse_data use odgi.
Just lift the one non-odgi-pure-mygfa method get_dimensions somewhere up above
?

The result is that

calyx_depth can use get_dimensions and be free of odgi.
parse_data can continue to use odgi.

I would love a confirmation on this, but as I understand it, these are used to create a .data representation of the given graph, but are not used by calyx_depth.py to generate the Calyx accelerator itself. Only get_dimensions is used in the generation of the accelerator. Is that right?

This looks approximately correct to me, in the sense that the bulk of this happens in parse_data.py and not calyx_depth.py. (It also happens in python_depth.py. However, I don't think this is used anywhere currently—has it perhaps been subsumed by slow-odgi, and can we delete it now?)
In my ideal imagination of how this works, there are two parts of this Calyx-accelerator implementation:

A data converter, from GFA to JSON. This needs to look at the graph, obviously.
A hardware generator, which produces Calyx code. This should not look at the input graph. It may need some basic parameters like the number of steps per path or whatever, but these should be summarized in a small list of numbers.

Maybe @susan-garry could confirm whether this is the goal, or if something major prevents this idea from being possible?

Truly removing odgi from parse_data would mean supporting all these getters and itererators in mygfa. Is that worth our time? Should we instead: […] The result is that

calyx_depth can use get_dimensions and be free of odgi.
parse_data can continue to use odgi.

For the scope of this PR, let's just do this! That is, let's make the Calyx-generation thing odgi-free. The data-converter thing will remain odgi-dependent. Then we can tackle that in a future PR. Does this make sense, @anshumanmohan?
One silly question I have about this, however: I had it in my head that your new pollen_data_gen tool can produce the same JSON output as this existing parse_data module, which I believe is wired up to exine depth. Is that true? If so, we can just delete parse_data altogether as obsolete (again, in a different PR).

Great, all makes sense!
Yes, pollen_data_gen's depth-json-generation matches parse_data's depth-json-generation. At least for depth, we can do away with parse_data. I think we've kept parse_data around for two reasons, both flimsy:

just plain inertia
perceived speed (but this is vague: we have not benchmarked the two json-generators properly)

Cool. IMO let's not worry too much about speed—both tools are in the "slow" category because they are primarily in Python (while parse_data uses native code via odgi's Python bindings, it does so in a way where the inner loops are still Python). If we want something fast, we'll need a different approach. So with that in mind, I am even more in favor of deleting the old code instead of trying to port it to mygfa.

I have reverted all my changes to parse_data and simply copied a copy of the method get_dimensions from parse_data into calyx_depth. This copy of get_dimensions uses mygfa, not odgi. calyx_depth no longer calls parse_data at all.
This PR is now, in theory, dead simple.
What remains is a spot of exine engineering:

We need to pass a GFA to calyx_depth
We need to pass an OG to parse_data

I am having trouble with this and was hoping @susan-garry could help.

@susan-garry while this PR no longer closes #107 (it goes most of the way, but we also need #147 and #148), it does fully close #137, no? If so, please feel free to link it using the Development panel on the right and then merge!


Fix iOS crash when pasting large images and included other file types

Summary
Included support for pasting other file types like videos, pdf, office docs and the like.
For large images now the image gets resize accordingly to avoid exceeding the max file dimensions supported by the server.
Ticket Link
https://mattermost.atlassian.net/browse/MM-18891

Build Apps for PR label detected. Will generate the app if build succeeds (checks pass and no conflicts with base branch).

Build the App failed. See the logs for more information.

Build Apps for PR label detected. Will generate the app if build succeeds (checks pass and no conflicts with base branch).

Android build App: https://releases.mattermost.com/mattermost-mobile-pr/PR-3424/Mattermost_Beta.apk)
iOS build App: itms-services://?action=download-manifest&url=https://releases.mattermost.com/mattermost-mobile-pr/PR-3424/Mattermost_Beta.plist

Tested on iOS. Looks good - no crash. Large images resize and post without an error.
@ogi please check on Android. Thanks.

This is an iOS only PR


Bug fix for paging

The Headers property in response from Invoke-WebRequest is a dictionary from string to IEnumerable[string]
The previous code would always skip paging

👍


Only require a to address if enabled

It simplifies the configuration of applications that use this if we can provide whatever we retrieved from the relevant env. var as the value for the to email address and set 'enabled' => !empty($email). Unfortunately, it currently complains if no to is given, even if enabled is set to false.
https://github.com/silinternational/yii2-json-log-targets/blob/85a53f4c67ad18a03a9f5a3905df2f33b374c026/src/target/EmailServiceTarget.php#L57-L58

Adding to backlog.


python311Packages.tableauserverclient: 0.29 -> 0.30

Changelog: https://github.com/tableau/server-client-python/releases/tag/v0.30
Description of changes
Fix build  (https://hydra.nixos.org/build/246738380)

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 283873 run on x86_64-linux 1

8 packages built:

python311Packages.tabcmd
python311Packages.tabcmd.dist
python311Packages.tableauserverclient
python311Packages.tableauserverclient.dist
python312Packages.tabcmd
python312Packages.tabcmd.dist
python312Packages.tableauserverclient
python312Packages.tableauserverclient.dist


python: Why is -lncurses added to LIBS in python3-config?

Describe the bug
Why is -lncurses added to python3-config on Nix/NixOS but missing on other Linux distributions?
NixOS 21.11 gives
$ python3-config --libs
 -lpthread -ldl -lcrypt -lncurses -lutil -lm -lm

while, for example, on Debian 11 (which I believe comes with ncurses support) it is:
$ python3-config --libs
 -lcrypt -lpthread -ldl  -lutil -lm -lm

It seems to be caused by this line, but why is it done this way? (Locally, I removed the optionalString for ncurses and rebuilt python3, and indeed ncurses is removed from python3-config --libs output)
{
# ...
  CPPFLAGS = concatStringsSep " " (map (p: "-I${getDev p}/include") buildInputs);
  LDFLAGS = concatStringsSep " " (map (p: "-L${getLib p}/lib") buildInputs);
  LIBS = "${optionalString (!stdenv.isDarwin) "-lcrypt"} ${optionalString (ncurses != null) "-lncurses"}";
#                                                        \-------------------- why? -------------------/
}

CPPFLAGS and LDFLAGS are generated out of the buildInputs, but LIBS is not.
Note ncurses is conditionally added to buildInputs, so shouldn't the configure script detect ncurses link flags on its own?
Notify maintainers
Last edit in efbe87f3ef76 (2018) by @FRidh, but it seems to have first appeared in 27de56316 (2012, Python 3.2.3).
Metadata
[user@system:~]$ nix-shell -p nix-info --run "nix-info -m"
 - system: `"x86_64-linux"`
 - host os: `Linux 5.10.95, NixOS, 21.11 (Porcupine)`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.4`
 - channels(root): `"nixos-21.11.335733.f6ddd55d5f9"`
 - channels(user): `""`
 - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`

Can't reproduce, at least on Debian 10:
# nix-shell -I nixpkgs=channel:nixpkgs-unstable -p python3 --pure --run 'python3-config --libs'
 -lpthread -ldl -lcrypt -lncurses -lutil -lm -lm

Sorry, if what I wrote was misleading. I didn't mean Nix on Debian, but plain Debian:
$ sudo apt install python3-dev
$ python3-config --libs
 -lcrypt -lpthread -ldl  -lutil -lm -lm

I'm still interested into why Nix/NixOS require -lncurses but not other Linux distros.

https://github.com/NixOS/nixpkgs/pull/164524 is in staging


W[3]-Submission?

It looks like you have not created an issue for your submission. Please create an issue for all future project submissions following the steps in the submission guide.
:+1: Nice work! This primary challenge of this homework was to learn how to use AutoLayout to build adaptive UI's that work across many different screen sizes and orientations. If you haven't already, we recommend going back and running your homework again while rotating the device / simulator to ensure your AutoLayout constraints function as expected.
Some small comments:

Nice work specifying the Auto Layout constraints.
That would be nice is if you handled the "no results" case gracefully, as well as didn't show empty gray lines when there is only 1 result.
For now, you only search within the current restaurants. For this assignment, you have to call the api to search the restaurants.

We have a detailed Project 3 Feedback Guide which covers the best practices for implementing this assignment. Read through the feedback guide point-by-point to determine ways you might be able to improve your submission. You should consider going back and implementing these improvements as well. Keep in mind that one of the most important parts of iOS development is learning the correct patterns and conventions.
If you have any particular questions about the assignment or the feedback, feel free to reply here or email us at<EMAIL_ADDRESS>

Sorry, but yes I did open an issue. I also closed it. I just re-opened. Sorry, I thought that once it has a comment that would be it. Please reply to know if I am not allowed to close issues.

Oops. So sorry. I'm checking all the repos one more time to make sure I've already graded all submissions. I thought I haven't reviewed your homework 😭


Binary for FreeBSD 10.x(amd64) node 0.12

New style name for this file will be freebsd-x64-3.28.73
Maybe it could be beneficial to differentiate major FreeBSD versions, since FreeBSD up to 9 (inclusive) use GCC and libstdc++ runtime and FreeBSD 10 and later use clang and LLVM C++ libraries. But this version should be good for now.

@saper, glad to know that it worked out for you. :sunny:
For contribution, you will need to build the binary from the cloned node-sass repo:
# after forking node-sass repo on github
cd /tmp
git clone https://github.com/saper/node-sass recursive
cd node-sass
git submodule update --init --recursive
npm install
node scripts/build -f

You will find that vendor/ directory will have a subdirectory with new naming convention (like you mentioned).
Also, to solve the runtime issue, the best approach is always to build with the minimum version of libc. See the long conversation here: https://github.com/sass/node-sass/issues/517. So the oldest version of FreeBSD, which supports GCC v4.6+ will be the best to obtain maximum coverage.
Note that this is just one piece of the puzzle, we need to build against node.js v0.12 x64, v0.10 ia32/x64, io.js v1.4 ia32/x64 as well (which is possible using nvm and io.js) for fast version switching and given 32-bit toolkit is installed). :)

Thanks! I think you mean git clone --recursive :)
My goal was to provide something usable now for those running 2.0.1
Well FreeBSD does not really have the libc problem discussed in sass/node-sass#517 because libc is much more stable. We also have compatibility packages to to use the older libc if necessary but this does not seem to be the issue for anything than quite ancient systems.
The real issue which is coming soon to Linux is the C++ library. I would propose to introduce a check  for that in sass/node-sass#733
So I have rebuilt the binding according to your instructions:
https://gist.github.com/saper/d571c97391506c9334de
it actually produced identical binary as submitted and the tests seem to pass as well.

Yeah missed --. My bad. :)

My goal was to provide something usable now for those running 2.0.1

It is not possible, because we make a tagged release and once the release is build there is no way to inject files in it. Related discussion is going here: https://github.com/sass/node-sass/issues/712.
I think we should hold off until node-sass is ready.

Ah, I see. No problem. I have now automated builds running for gcc-based FreeBSD 8 (amd64 and i386) and for clang-based FreeBSD 10. Will try to support iojs as well. Closing for now, thanks!


Detected package downgrade Exception with GroupDocs.Viewer.UI.SelfHost.Api 6.0.11

Hi,
the following error will be thrown when using GroupDocs.Viewer.UI.SelfHost.Api 6.0.10 and 6.0.11 with a current (7.0.4) .NET Core Web App:
Error: Detected package downgrade: System.IO.FileSystem.Primitives from 4.3.0 to 4.0.1. Reference the package directly from the project to select a different version.
 ToSec.DataAccess -> GroupDocs.Viewer.UI.SelfHost.Api 6.0.11 -> Microsoft.AspNetCore.Mvc.Core 2.2.5 -> Microsoft.Extensions.DependencyModel 2.1.0 -> Microsoft.DotNet.PlatformAbstractions 2.1.0 -> System.IO.FileSystem 4.0.1 -> runtime.win.System.IO.FileSystem 4.3.0 -> System.IO.FileSystem.Primitives (>= 4.3.0)
 ToSec.DataAccess -> GroupDocs.Viewer.UI.SelfHost.Api 6.0.11 -> Microsoft.AspNetCore.Mvc.Core 2.2.5 -> Microsoft.Extensions.DependencyModel 2.1.0 -> Microsoft.DotNet.PlatformAbstractions 2.1.0 -> System.IO.FileSystem 4.0.1 -> System.IO.FileSystem.Primitives (>= 4.0.1)

This is a regression:  #19
Environment:

.NET Core version 7.0.4
GroupDocs.Viewer.UI version 6.0.11
Operative system: Win11
Others: VS 17.5.3

Hi, @ManuelHaas . Could you please attach .sln and .csproj files of the solution and the project ?

Hi, attached you will find the project file.
Project.csproj.txt

Hi, @ManuelHaas  It seems the problem with runtime package dependencies
System.IO.FileSystem 4.0.1 -> runtime.win.System.IO.FileSystem 4.3.0 -> System.IO.FileSystem.Primitives (>= 4.3.0)
System.IO.FileSystem 4.0.1 -> System.IO.FileSystem.Primitives (>= 4.0.1)
and NU1605 is not suppressed within solution
Plz try

suppress NU1605 (it is the default setting)

Thank you for the recommendations.
@1: I will not change the default settings because of the error.
@2: This is the workaround your colleague recommended the last time the problem occurred. I have set this temporarily.
However, the problem still does not occur with version 6.0.5. The error has only occurred since the update.

Hi, @ManuelHaas thank you for feedback. Could you please provide some sample project where I can reproduce the issue? Actually I've been trying to create some sample many times but all was working fine with the given project settings.

Hi, @vyacheslav-prokopenko I didn't know that the error had anything to do with my project settings. Here is the base project that is referenced by the other project (which I have already uploaded) that is causing the error.
base.csproj.txt

Hello, @ManuelHaas . Still can not reproduce the issue locally. Could you please help to reproduce with attached project (solution is located in ClassLibrary1 folder)
Base.zip

@ManuelHaas
Did you manage to resolve this issue?

@vladimir-litvinchik like last time I referenced System.IO.FileSystem.Primitives directly in the project. I assume the problem still exists. Unfortunately I don't have the time to create a sample project.

@ManuelHaas
Got it, thank you for the feedback.


Add optional support for serialization with Borsh

Think this can be closed now that #84 is merged.


mpack: fix up broken paths

Motivation for this change
mpack was trying to write to  /usr/tmp which ended badly on nixos.
Fixes #40483
@clefru, do you mind giving this a go?
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

Success on x86_64-linux (full log)
Attempted: mpack
Partial log (click to expand)
post-installation fixup
moving /nix/store/djaq753329njmxrdb27c0lp8g4bm9xi8-mpack-1.6/man to /nix/store/djaq753329njmxrdb27c0lp8g4bm9xi8-mpack-1.6/share/man
shrinking RPATHs of ELF executables and libraries in /nix/store/djaq753329njmxrdb27c0lp8g4bm9xi8-mpack-1.6
shrinking /nix/store/djaq753329njmxrdb27c0lp8g4bm9xi8-mpack-1.6/bin/mpack
shrinking /nix/store/djaq753329njmxrdb27c0lp8g4bm9xi8-mpack-1.6/bin/munpack
gzipping man pages under /nix/store/djaq753329njmxrdb27c0lp8g4bm9xi8-mpack-1.6/share/man/
strip is /nix/store/j75dgadrff2d1fyc4fczmcgqkid2imdx-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/djaq753329njmxrdb27c0lp8g4bm9xi8-mpack-1.6/bin
patching script interpreter paths in /nix/store/djaq753329njmxrdb27c0lp8g4bm9xi8-mpack-1.6
checking for references to /build in /nix/store/djaq753329njmxrdb27c0lp8g4bm9xi8-mpack-1.6...

Success on aarch64-linux (full log)
Attempted: mpack
Partial log (click to expand)
moving /nix/store/266q7kpnsa7whalf4hlrlxdk5lhs1cjx-mpack-1.6/man to /nix/store/266q7kpnsa7whalf4hlrlxdk5lhs1cjx-mpack-1.6/share/man
shrinking RPATHs of ELF executables and libraries in /nix/store/266q7kpnsa7whalf4hlrlxdk5lhs1cjx-mpack-1.6
shrinking /nix/store/266q7kpnsa7whalf4hlrlxdk5lhs1cjx-mpack-1.6/bin/munpack
shrinking /nix/store/266q7kpnsa7whalf4hlrlxdk5lhs1cjx-mpack-1.6/bin/mpack
gzipping man pages under /nix/store/266q7kpnsa7whalf4hlrlxdk5lhs1cjx-mpack-1.6/share/man/
strip is /nix/store/jk6j4lh9v5mvjdbdc35sj0zffhhf6s56-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/266q7kpnsa7whalf4hlrlxdk5lhs1cjx-mpack-1.6/bin
patching script interpreter paths in /nix/store/266q7kpnsa7whalf4hlrlxdk5lhs1cjx-mpack-1.6
checking for references to /build in /nix/store/266q7kpnsa7whalf4hlrlxdk5lhs1cjx-mpack-1.6...
/nix/store/266q7kpnsa7whalf4hlrlxdk5lhs1cjx-mpack-1.6

@peterhoeg: Thank you for your fix! This works for me:
openat(AT_FDCWD, "/tmp/mpackxerput", O_RDWR|O_CREAT|O_EXCL, 0644) = 4


Utilities

➕ New abbr
Criteria

Not an acronym (e.g. RAM, CPU, SQL) or a conventions (e.g. i, j, k).
Lowercase
Singular and neutral form.
Max 1 🟢 abbr

utilities • 🟢 utils

Pros

Cons

[x] I can handle the following pr related to this issue to add the new abbr.

To follow the "Singular and neutral form" rule shouldn't it be
utility • :green_circle: util ?

To follow the "Singular and neutral form" rule shouldn't it be utility • 🟢 util ?

Actually, it should be.
This makes me think also about the adjectives we add before. Shouldn't we convert them into nouns?

For example which ones do you mean?

Like those ones:
developer (noun) development (adj) (that could pass tho)
initialize (noun) initialization (adj)
selection (noun) selected (that's a verb...) (select's missing)
synchronous (noun) synchronize (verb)
Btw 'synchronous' is missing the dot.

initialize (noun) initialization (adj)

Isn't it

initialization: noun
initialized: adj
initialize: verb

selection: noun
selected: adj
select: verb

synchronization: noun
synchronous: adj
synchronize: verb

Anyway, I'm not entirely sure what "neutral form" means. I think we should agree on the preferred word-class. Noun seems the best to me, but as non native speaker I'm not familiar with the English grammar. :sweat_smile:

Btw 'synchronous' is missing the dot.

Fixed.

initialize (noun) initialization (adj)

Isn't it

initialization: noun
initialized: adj
initialize: verb

selection: noun
selected: adj
select: verb

synchronization: noun
synchronous: adj
synchronize: verb

Ops made some mistakes.

Anyway, I'm not entirely sure what "neutral form" means.

We should specify neutral as singular masculine and noun so that's neutral following how dictionaries do.

but as non native speaker I'm not familiar with the English grammar. :sweat_smile:

Neither am I. HAHAHA

Btw 'synchronous' is missing the dot.

I can't find it the README. We have only "asynchronous" which has a dot.

We should specify neutral as singular masculine and noun so that's neutral following how dictionaries do.

I'm ok with that. Especially if it's already a practice for dictionaries.

Btw 'synchronous' is missing the dot.
I can't find it the README. We have only "asynchronous" which has a dot.
[...]

Thanks,  seemingly I'm blind :slightly_smiling_face:

Added in #50


Output path

Hi Travis,
Your pipeline works pretty well!
But could you make it configurable for the output path?
Jingjing

Thanks for your report Jingjing! This should be fixed by https://github.com/twrightsman/quantify-RNA-pipeline/commit/17fc90036091e6db588dcf8c3b9309fd2f09cfc8.


Use global defaults if they exist upon invocation

Being able to define window._swalDefaults before swal is loaded in order to define defaults for swal on a page would be nice.
Perhaps we could add a line such as:
swal.setDefaults(window._swalDefaults || {});

Or build this in to use window._swalDefaults?
<script>window._swalDefaults = { ... };</script>
<script src="//some.com/path/to/sweetalert2.js"></script>

Not sure if there's some other way to do this without having to write the above line manually.
It'd be nice to have this for Lad to simplify things

@limonte I sent a pull request, can you please accept/merge/release new version to npm and ping me back?  thanks! ❤

Merged and released in v7.1.0, https://jsfiddle.net/ad3quksn/263/


Full Spawning urls scan

Currently we have urls scan implemented for first 100K rows here
We need to do it for full dataset but there could be some concerns:

Full scan could take too much time for big datasets (Like laion) and we have a task configured here that kills long running jobs that can prevent Full scan to do not finish
We have a response size validation here which can lead to a database error in case of having big content (Too much opt in/out urls) to store

Approach 1:
Run full dataset scan in one single job
Will need the following actions:

Implement custom timeout configurations to kill "long running jobs" i.e We could have a WORKER_MAX_JOB_DURATION_SECONDS value for split-opt-in-out-urls-scan Job set up to 10 hrs and for other jobs 20 min (as  it is currently)
Store the content response (or maybe only opt in/out urls list) in an external storage. It was suggested by @severo  to store it on a parquet file (see thread https://github.com/huggingface/datasets-server/pull/1044#discussion_r1173625223). I think it could be a good idea but will need to think where to store the file (Maybe https://datasets-server.huggingface.co/assets? Another branch in each repository like we actually do for parquets https://huggingface.co/datasets//tree/refs%2Fconvert%2Fparquet? )
In case we dont need yet to show the list of opt in/out urls, we can skip previous step and only store number of urls see sample: https://datasets-server.huggingface.co/opt-in-out-urls-scan?dataset=laion/laion2B-en&config=laion--laion2B-en&split=train

key
value

urls_columns
[…]

opt_in_urls
[]

opt_out_urls
[…]

num_opt_in_urls
0

num_opt_out_urls
1853

num_urls
100000

num_scanned_rows
100000

has_urls_columns
true

Approach 2:
Run full scan in separated Jobs and store results in separated cache entries
Will need the following actions:

Add support in current datasets-server architecture to have another level of granularity https://github.com/huggingface/datasets-server/blob/main/libs/libcommon/src/libcommon/processing_graph.py#L12 maybe "batch" that will have an start_row and an end_row or offset and limit. So we scan the dataset by batches and store its result in a cache entry for each batch. At the end we could have a "dataset" aggregated Job that will give us the summarized result of previous responses e.g:

Batch one:  offset:0 , limit:1000

key
value

urls_columns
[…]

opt_in_urls
[]

opt_out_urls
[…]

num_opt_in_urls
0

num_opt_out_urls
10

num_urls
1000

limit
1000

offset
0

Batch two:  offset:1000 , limit:1000

key
value

urls_columns
[…]

opt_in_urls
[]

opt_out_urls
[…]

num_opt_in_urls
4

num_opt_out_urls
5

num_urls
50

limit
1000

offset
1000

`
Aggregated response:
`

key
value

urls_columns
[…]

opt_in_urls
[]

opt_out_urls
[…]

num_opt_in_urls
4 (0 + 4)

num_opt_out_urls
15 (10 + 5)

num_urls
1050 = (1000 from batch one and 50 from batch two)

The only problem with this approach is that we could still have sometimes issues with db storage limitation (e.g a few opt in/out urls but really long text)

I would go for the first approach since it is the least invasive for our current architecture and also will solve the issue with mongodb limitation.
Let me know what do you think @huggingface/datasets-server
cc. @julien-c  I think the way we store the opt in/out urls list also depends on how we plan to show it in the viewer.
In the initial phase if it is not needed yet, we could start running full scan for all dataset but only store the counters.

Some comments:

Implement custom timeout configurations to kill "long running jobs" i.e We could have a WORKER_MAX_JOB_DURATION_SECONDS value for split-opt-in-out-urls-scan Job set up to 10 hrs and for other jobs 20 min (as it is currently)

We don't need specific code for that because we can dedicate pods to this job (with WORKER_ONLY_JOB_TYPES="split-opt-in-out-urls-scan") and set a specific value to WORKER_MAX_JOB_DURATION_SECONDS.

In the initial phase if it is not needed yet, we could start running full scan for all dataset but only store the counters.

I think we can do that for now, because anyway, we will need to refresh every entry regularly, maybe every month. Indeed:  the opted-in and opted-out URLs we store on our side will possibly be outdated when data from spawning.ai is updated.

cc. @julien-c I think the way we store the opt in/out urls list also depends on how we plan to show it in the viewer

@julien-c @gary149 we could have a specific cell display when the URL is opted-out or opted-in. what do you think? is it worth the effort for now?

I don't think we need to show the opt-outs in the viewer. We can imagine letting the dataset owner download a big CSV with all the opt-out URLs (and their location in the dataset). In that case I think we can do approach 1 indeed and save it on S3 somewhere ?
Maybe we can even ask dataset owners request it by email until we make a proper download button ?
(and I think it's more convenient for dataset owners to get a CSV instead of Parquet - without strong opinion though)
(it's also fine to have one single file since the URLs scanning job can run on one single process - since it's bounded by the API calls)

We don't need specific code for that because we can dedicate pods to this job (with WORKER_ONLY_JOB_TYPES="split-opt-in-out-urls-scan") and set a specific value to WORKER_MAX_JOB_DURATION_SECONDS.

Yes but we will have tp remove "all" worker https://github.com/huggingface/datasets-server/blob/main/chart/env/prod.yaml#L237 since it could include jobs from "split-opt-in-out-urls-scan" of specify the others runners without spawning one.

(and I think it's more convenient for dataset owners to get a CSV instead of Parquet - without strong opinion though)

Agree, maybe it will be simpler/friendly for the owner to get the information in csv

(it's also fine to have one single file since the URLs scanning job can run on one single process - since it's bounded by the API calls)

Agree, maybe one csv file with columns "url", "row_idx", "opt_in", "opt_out" as it is in Spawning response

Yes but we will have to remove "all" worker https://github.com/huggingface/datasets-server/blob/main/chart/env/prod.yaml#L237 since it could include jobs from "split-opt-in-out-urls-scan" of specify the others runners without spawning one.

Yes, you're right, I hadn't thought about it. Even so: I think it's ok

Full scan will be implemented initially for small datasets (Considering that a dataset is "small" when the server was able to get its parquet files in "refs/convert/parquet").
To achieve it, these steps are needed:

[ ] Implement partition granularity level in datasets-server --> In progress https://github.com/huggingface/datasets-server/pull/1213
[ ] Separate logic of image URL columns inspect from scanning --> In progress https://github.com/huggingface/datasets-server/pull/1256
[ ] Create step "partition-opt-in-out-urls-scan" to be a PartitionJobRunner and scan rows based on partition_start/end (Not sure if we will still read rows using datasets library in streaming mode or change reading from parquet files, wdyt @severo @lhoestq?)
[ ] Change step "split-opt-in-out-urls-scan" to "split-opt-in-out-urls-count" to only summarize partitions data into a split (Same as config-opt-in-out-urls-count and dataset-opt-in-out-urls-count)

@huggingface/datasets-server let me know if this sounds like a plan, note that probably "partitions" pattern could be used in the future when we need a "full dataset read".

I agree that it would be better to use parquet to get the URLs

sounds good to me !

keep open

keep open

Should we close? I don't think we will do it in the near future.

Closing. Feel free to reopen if it makes sense.


[Error]: Can MySQL be used as a replacement for PostgreSQL to store data?

What happened?
I want to try how to On-Premises Deployment of lakeFS。i am follow this docs and want to deploy by kubernetes，i change postgresql to mysql in value.yaml，like this：
secrets:   databaseConnectionString: mysql://root:xx@my-lakefs-db.rds.amazonaws.com:3306/lakefs   authEncryptSecretKey: <some random string> lakefsConfig: |   database:     type: mysql   blockstore:     type: s3     s3:       region: us-east-1   gateways:     s3:       domain_name: s3.lakefs.example.com
However, this configuration file value.yaml cannot start lakefs on k8s。
Error like this ： Failed to open KV store" func=cmd/lakefs/cmd.glob..func8 file="cmd/run.go:99" error="unknown driver: mysql

Expected Behavior
Expected Behavior:
How you expected thing to work.
lakeFS Version
v0.100.0
Deplyoment
No response
Affected Clients
No response
Relevant logs output
No response
Contact Details
<EMAIL_ADDRESS>

I had know why this  error . Lakefs did not support the mysql now. If developer want to mysql store metadata，they need to develop their own driver to use their own favorite database.  refer to this docs


Istanbul ignore not working on ES6 exports

It seems istanbul ignore (or next) is not working on export statements.

Are you using it through nyc? https://istanbul.js.org/docs/tutorials/es2015/

I ran into the same issue, and yes i am using nyc.
This doesn't work:
// istanbul ignore next
export function createKeys() {
  ...
}

This does work:
// istanbul ignore next
function createKeys() {
  ...
}

export {createKeys};

This worked just fine 😊
export /* istanbul ignore next */ function createKeys() {
  ...
}


take picture with a button click

related to #9 and camera software

When button is pressed camera now will take a picture and upload a corresponding time and gps location to a csv file along with the name of the picture

@jacobstasiewicz — I'm going to reopen this issue — can you post the code you are using to take the picture to the github repository in a new /camerasoftware directory)? After you commit the code, feel free to close again..


Fix IR remote source updates

Ref #115

Dirac remote updates are working properly. Only Source change doesn't trigger event updates.


angular2 rc5 integration

How to use in angular2 rc5? bootstrap model has been changed.
How to use with NgModule?

Hi @sbahmani, I still need to update this to Angular RC5, I hope to do it soon

Hi @Gbuomprisco , Thank You. I hope you do it soon :)

HI @sbahmani,
I published the version 0.2.2, with examples on integration with RC.5. From your point of view it doesn't change much, you only need to bootstrap the app in the new way and import the component in the container component.
The files in /demo show how to do it anyway, or the demo on Webpack Bin you find in the README.md 👍

Hi @Gbuomprisco , Thank you very much.

animation trigger expressions within the template that are assigned as an element attribute (e.g. @prop) are deprecated. Please use the Angular2 property binding syntax (e.g. [@prop]) when assigning properties.

// this is now deprecated

// do this instead

Hi, that should be fixed now :)

Thank you @Gbuomprisco , The warning disappear but still there is a error:
EXCEPTION: Error: Uncaught (in promise): Cannot read property 'toString' of null
platform-browser.umd.js:937 EXCEPTION: Error: Uncaught (in promise): Cannot read property 'toString' of nullBrowserDomAdapter.logError @ platform-browser.umd.js:937
platform-browser.umd.js:937 STACKTRACE:BrowserDomAdapter.logError @ platform-browser.umd.js:937
platform-browser.umd.js:937 Error: Uncaught (in promise): Cannot read property 'toString' of null
    at resolvePromise (zone.js:538)
    at resolvePromise (zone.js:523)
    at zone.js:571
    at ZoneDelegate.invokeTask (zone.js:356)
    at Object.onInvokeTask (core.umd.js:9236)
    at ZoneDelegate.invokeTask (zone.js:355)
    at Zone.runTask (zone.js:256)
    at drainMicroTaskQueue (zone.js:474)
    at XMLHttpRequest.ZoneTask.invoke (zone.js:426)BrowserDomAdapter.logError @ platform-browser.umd.js:937
zone.js:461 Unhandled Promise rejection: Cannot read property 'toString' of null ; Zone: angular ; Task: Promise.then ; Value: Cannot read property 'toString' of nullconsoleError @ zone.js:461
zone.js:463 Error: Uncaught (in promise): Cannot read property 'toString' of null(…)

I think in ng2-dropdown.bundle.js at this code  [@fade]=\"state.toString()\" state is null.

Thanks @sbahmani, I'll have a look soon. Hopefully this doesn't block you?

Thanks @Gbuomprisco , No it's OK but I confused with my errors and the error.

Sorry, It's not your bug, the bug occurred for  other RC5 change.
Thanks.

Cool, no worries 👍


CCHVAE's support for categorical features

Hello,
Many thanks for this great library.
I have a question: Does the current implementation of CCHVAE support categorical features?
If so, how should I set the number of nodes for the first layer (input layer) of the VAE (I mean for the vae_params['layers']? Should I set this value as the input length after one-hot encoding is applied?

Hi,
The current implementation of CCHVAE  supports binary categorical features. We are still working on support for categorical features with more categories. As far as I know, the CCHVAE implementation could be easily adapted to use multiple categories. (you would just need to adjust the sampling step, it might even already work)
Regarding the VAE, it's like you said. You set the input layer to the input length after one-hot encoding. Note that we are using "one-hot drop binary", such that for the binary categorical variables you drop one of the one-hot encoded columns. E.g. for sex, you have [sex_male, sex_female] where we drop the last column and are left with [sex_male].
Also there we some issues with CCHVAE, see https://github.com/carla-recourse/CARLA/issues/155. These should be fixed very soon (within a week) but keep that in mind.
Please let me know if anything is unclear or if you have other questions!

Thanks for your response.
Just one more question. Should scaling the continuous features and encoding the categorical features be applied before the factuals are passed to the get_counterfactuals method? Or are these prepossessing handled internally in the recourse method?
It would be great if you describe this process also for other recourse methods like Growing Sphere.

Thanks a lot for your response. I really appreciate your effort to provide an integrated library for algorithmic recourse.
Just, I wanted to let you know of a few minor issues, I noticed when using the library:

In the Examples section from the documentation, this link, in: factuals = dataset.raw.sample(10), df should be used instead of raw, as I think raw is not saved in the class.
I see in DataCatalog class, that the scaler is fit to the whole given dataset (df is passed to the fit_scaler function). Conceptually, it makes more sense to fit the scaler to the training data (df_train).
In GrowingSpheres method, in all the code, model.predict_proba function is used with a numpy array input. But, in check_counterfactuals function (called in line 80 of model.py), in the implementation of that, model.predict_proba is called with a dataframe input.

It's a bit difficult to say what the hyper-parameters should be. For example, for number of epochs it also depends on the learning rate and how large your dataset is. Based on what I have seen 5 epochs seems to do the job, but I would recommend you just try it out to make sure yourself by looking if the ELBO converges. That also holds  for any other hyper-parameters, they should be reasonable, but I would recommend trying different values for those as well.
The fix for the 155 problem should be done, so expect it will be added to the main branch today. (see PR https://github.com/carla-recourse/CARLA/pull/165 if you to see what changed)

Thanks a lot!

The PR is merged, and the issue should be fixed.


Only a single line of output produced when -logFile used.

Run
flyway info -logFile=foo.txt
The log file is created but a full copy of the log is not written to the file.

Fixed in v6.1.1


Improving performance of Rollup On Read

Adding metrics to ascertain the performance of rollups-on-reads.
Breaking up the cassandra calls and rollups into workloads of no more than ROLLUP_ON_READ_REPAIR_SIZE_PER_THREAD ranges.
The workloads are then run in parallel.

@shintasmith @ChandraAddala @VinnyQ

Updated the exception logging
Added more comments for the integration tests
Updated tests to verify the rolled up values as well as the keys

Other than the 2 questions above, I don't have any more comments. Lgtm +1

@usnavi :+1:

@ChandraAddala - updated the PR as per your comments.

+1


Unable to add remote image to nav_bar button

Hello. My nav_bar should show the logged_in user's picture on the right and clicking on it should open a Profile screen.
It works fine with a new user that has not uploaded a profile picture yet, and therefore It's using a local placeholder image, but when Auth.current_user["image"] contains an URL pointing to the user's profile image, it no longer works.
image_view = UIImageView.alloc.initWithFrame(CGRectMake(0, 0, 50, 50))
image_view.contentMode = UIViewContentModeScaleAspectFit
image_view.setImageWithURL(Auth.current_user["image"])

set_nav_bar_button :right,
  image: Auth.current_user["image"].nil? ? image.resource("icon_user_50x50.png") : image_view,
  action: :open_profile

But when a remote image exists, this code does not work properly. It shows the image, but nothing happens when it is tapped / clicked.
If I exchange this line:
image: Auth.current_user["image"].nil? ? image.resource("icon_user_50x50.png") : image_view,

for this one:
image: Auth.current_user["image"].nil? ? image.resource("icon_user_50x50.png") : image.from_view(image_view),

tapping / clicking works, but no image is shown.
Any help would be appreciated.

Fixed via https://github.com/infinitered/ProMotion/issues/789#issuecomment-234569620.


Support nvm ls installed

For extra scripting support, and should satisfy #55

Closing - ac9a52886dd3c9c3110fc6fb082f01a2dabc38b7 took care of this


document / provide recipe on how to use ember-cli proxies for local development

backstory
We use ember server --secure-proxy false --proxy https://<IP_ADDRESS>:4000 for local development. We proxy to a node.js application as our API server at port 4000. A few of our endpoints stream a downloaded file to the browser. When I switched to using ember serve, over a custom configured apache, these endpoint downloads failed locally.
main problem
I searched for about 6h on the "right" way to do this in my ember project. This surprised me as basic configuration in ember should be seamless. Additionally, I did not expect to have to override the default ember server behavior by defining a proxy using  ember g http-proxy my-download-path http:<IP_ADDRESS>:4000. If this tripped me up, I think it could scare other users away.  I think we need to capture how to do this and/or examples of using http proxies with ember-cli
solutions

Should this be a topic in the advanced use?
More general recipe somewhere else?

There is a bit on the -proxy flag at the end of developer tools section. That should be merged into the new content

Bit confused about what the proxy does. Is the only use case to be able to fetch('/data.json') in the app, and having that hit <IP_ADDRESS>:4000/data.json?
In that case, why not just fetch(${config.host}/data.json) and set the config in config/environment.js?


Tiny Whoop F3 Board not Working

I have recieved a Tiny Whoop Pro F3 board and other standard components for building a Tiny Whoop. I attached the camera vtx combo straight to the battery port, like I have done in the past with an Eachine E100 clone. But, when attached, Motor 1 doesn’t spin. I disconnected the camera, and tried flying the drone, and it flew. I have no idea why it is doing this. I then after attached the camera to the designated OSD ports, and it did the same thing. I tried lowering the motor rate down to 1000, and that led to each individual motor starting at different times when the camera was not attached. The motors are brand new. The batteries are brand new. Please someone help!!!!

please do not post here again


[BugFix] fix partial update char column miss padding

When partial update char column using column mode, miss padding, fix this.
What type of PR is this:

[x] BugFix
[ ] Feature
[ ] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Checklist:

[x] I have added test cases for my bug fix or my new feature
[ ] This pr will affect users' behaviors
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

[x] I have checked the version labels which the pr will be auto-backported to the target branch

[x] 3.1
[ ] 3.0
[ ] 2.5
[ ] 2.4

[FE PR Coverage Check]
:heart_eyes: pass : 0 / 0 (0%)

[FE PR Coverage Check]
:heart_eyes: pass : 0 / 0 (0%)

@Mergifyio backport branch-3.1


ci: shorten PR title lint message

This message was really tall, so make it a lot shorter.
Also, fix a bug where the username wasn't being passed to the
message function.

maybe you can wrap the list of valid scope into a expandable
<details>
<summary>title</summary>
list
...
</details>

?


jsdom: window.document.defaultView !== window

Describe the bug
I'm migrating tests from Jest to Vitest (both using jsdom) and stumbled upon this subtle difference between Jest and Vitest:
it("works", () => {
  console.log(
    "document.defaultView === window",
    document.defaultView === window
  );

  const element = document.createElement("div");
  document.body.appendChild(element);
  console.log(
    "element.ownerDocument.defaultView === window",
    element.ownerDocument.defaultView === window
  );
});

See https://github.com/molily/vitest-test2/blob/main/first.test.js
Output in vitest:
document.defaultView === window false
element.ownerDocument.defaultView === window false

Output in jest:
document.defaultView === window true
element.ownerDocument.defaultView === window true

In Vitest, window and document.defaultView are two different Window instances. I would expect both to point to the same object.

Why is this relevant? In my tests, I mock objects on window and expect that it affects all elements in the document.
My concrete test uses @testing-library/dom to fire an event on an element: https://github.com/molily/vitest-test2/blob/main/dom.test.js
I'm mocking window.PointerEvent since jsdom does not support it:
window.PointerEvent = PointerEventFake;

Then I use fireEvent from @testing-library/dom to dispatch an event. fireEvent uses element.ownerDocument.defaultView to get the associated Window object (source 1). It then creates an event using the constructor on this obtained Window instance (source 2). In Vitest, defaultView yields a different object than window, so @testing-library/dom does not find my PointerEvent mock.
A workaround would be to assign the mock on document.defaultView:
document.defaultView.PointerEvent = PointerEvent;

But this is obscure and most developers don't know what defaultView is (they shouldn't for this use case IMHO).
Is there a particular reason why [DOM node].defaultView isn't identical to window? Or am I doing anything wrong?
Reproduction
Example repo: https://github.com/molily/vitest-test2
npm run vitest

yields
stdout | first.test.js > works
document.defaultView === window false
element.ownerDocument.defaultView === window false

 ✓ first.test.js (1)
 ❯ dom.test.js (1)
   × works

⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯ Failed Tests 1 ⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯

 FAIL  dom.test.js > works
AssertionError: expected false to be true // Object.is equality
 ❯ dom.test.js:37:18
     35|   document.body.appendChild(element);
     36|   fireEvent.pointerDown(element, { pointerType: "mouse" });
     37|   expect(called).toBe(true);
       |                  ^
     38| });
     39|

  - Expected   "true"
  + Received   "false"

⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯[1/1]⎯

 Test Files  1 failed | 1 passed (2)
      Tests  1 failed | 1 passed (2)
   Start at  10:07:22
   Duration  691ms (transform 218ms, setup 0ms, collect 61ms, tests 11ms)

whereas
npm run jest

yields
 PASS  ./dom.test.js
  ● Console

    console.log
      mouse click!
      at HTMLDivElement.log (dom.test.js:31:15)

 PASS  ./first.test.js
  ● Console

    console.log
      document.defaultView === window true
      at Object.log (first.test.js:2:11)

    console.log
      element.ownerDocument.defaultView === window true
      at Object.log (first.test.js:9:11)

Test Suites: 2 passed, 2 total
Tests:       2 passed, 2 total
Snapshots:   0 total
Time:        0.482 s, estimated 1 s
Ran all test suites.

System Info
Node: 18.13.0
vitest: 0.27.1

Used Package Manager
npm
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
[X] The provided reproduction is a minimal reproducible example of the bug.

Thank you very much! 😻


validateSearch run multiple times even in other routes

Describe the bug
I'm having a strange behavior with one route. The validateSearch is running multiple times even in other routes.
In the images I have my route tree, the logs of validateSearch on other route match, and the validateSearch logs in the route that should validate the search.
As part from that, even my validateSearch is setting the default params if not present, they aren't showing in the url, same #1184
My route file:
const IndividualRecordSearchSchema = v.object({
  tab: v.fallback(v.enum_(TAB_KEYS), DEFAULT_TAB_KEY),
  // eslint-disable-next-line sort-keys
  subTab: v.fallback(v.enum_(SUB_TAB_KEYS), DEFAULT_SUB_TAB_KEY),
});

type IndividualRecordSearch = v.Output<typeof IndividualRecordSearchSchema>;

export const Route = createFileRoute('/_area-reservada/area-reservada/minhas-credenciacoes/ficha-individual')({
  component: () => <IndividualRecordPage />,
  loader: ({ context }) => {
    context.breadcrumbs = [
      {
        label: 'home',
        path: '/area-reservada',
      },
      {
        label: 'myAccreditations',
        path: '/area-reservada/minhas-credenciacoes/credenciacoes',
      },
      {
        label: 'individualRecord',
        path: '/area-reservada/minhas-credenciacoes/ficha-individual',
      },
    ];
  },
  validateSearch: (search: Record<string, unknown>): IndividualRecordSearch => {
    const parsed = v.parse(IndividualRecordSearchSchema, search);

    console.log('parsed >> ', parsed);

    return parsed;
  },
});

Your Example Website or App
https://stackblitz.com/edit/tanstack-router-r3gsvr?file=src%2Froutes%2F_layout%2F_layout-2%2Flayout-a.tsx
Steps to Reproduce the Bug or Issue
Navigating between pages in the sandbox, you can see the logs in the console.
Expected behavior
The validateSearch running only once on the route and never on other routes. As well as putting the search params in the url.
Screenshots or Videos

Platform

OS: macOS
Browser: Arc
Version: 1.28.4

Additional context
No response

I'm closing this in favour of tracking this in #1919 as it has a workable minimal reproduction to work off of.


The converter is not working.

The converter is not working. There is no \PowerToys\Currency Converter folder in the documents folder, as well as the alias.json association configuration file. Even if you create a file using this path and write to it, it still doesn't work. If you write the names of currencies in full, for example, then there is also silence, it does not output anything. M PT was downloaded from the MS Store

Hi, I am closing this issue due to inactivity. If you are still facing this issue then please feel free to reopen it.


delete redundancy code

remove hilofactory stuff from dragonbone.js, cause of there already exist in hiloFactory.js, and this hiloFactory.js will be compile into dragonbone.js when run gulp...

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Thanks!


perf-regression: write the report to disk

My understanding is that the final report is only written to the console. I have run the benchmark yesterday, but forgot about it and I have shut down the PC without copying the report. I wonder if it would be possible to write final report to disk for forgetful people like me?

I wonder whether it is possible to transform these numbers from the two version log files into the console report @aldettinger ?
Version       Requests  duration     Latency Avg  Stdev    Max       Requests/sec
2.13.0 JVM    4834089   600.016 s    12.38 ms     2.17 ms  327.16 ms 8056.60
2.13.1 JVM    4756800   600.016 s    12.58 ms     1.87 ms  295.70 ms 7927.79
2.13.0 Native 3311342   600.024 s    18.09 ms     3.19 ms  52.17 ms  5518.68
2.13.1 Native 3296267   600.023 s    18.17 ms     3.03 ms  55.84 ms  5493.57

Writing the report to file by default would definitely provide value. There are already log files produced, I would tend to think that the final report should be produced in yet another file.


Fix: Fixed the issue for missing ordinal in the appliedResource field

Description of your changes

Fixes #
https://github.com/Azure/k8s-work-api/issues/77
I have:

Changed the type of the Resource Identifier's ordinal to be mandatory.

This fixes the problem of ordinal not showing up on AppliedResources (due to ordinal == 0)
Also makes ordinal mandatory, which should also help reduce errors when manifests are created.

[x] Read and followed Caravel's Code of conduct.
[x] Run make reviewable to ensure this PR is ready for review.

How has this code been tested

Special notes for your reviewer

Clarification: Is there a reason why the ordinal doesn't show up when It's 0 ?

Is #90 fixing the e2e test failures ?

Clarification: Is there a reason why the ordinal doesn't show up when It's 0 ?, if it's mandatory does it show up now. Can you attach a screenshot if possible

I'm not 100% sure, but I think it was not showing up similar to why the Group isn't showing up for Service, Group is nil for service, similarly, having an ordinal of 0 may have caused it to think that it wasn't necessary to show it.


possibly omitted document object reference

Oh nice catch! Can you also compile rellax.min.js?? Thank you!


Optimize devcontainer environment

[x] Reduce image size (~3GB -> ~2GB).
[x] Improve build time through better caching
[x] Persist MySQL data. To purge, users can do this manually or simply recreate the Codespace.
[x] Add schema clean up function
[x] Set notebook kernel
[x] Cache docker images
[x] Update environment launch instructions

In light of the upcoming demo at Bonn University I'll merge as-is since it seems functional.


cross origin error: No 'Access-Control-Allow-Origin'

I have a really simple server and I'm getting an error redirecting to the spotify login page.
XMLHttpRequest cannot load https://accounts.spotify.com/authorize?response_type=code&redirect_uri=http…3000%2Fapi%2Fspotify%2Fcallback&client_id=0a7811639820446fb368f8a8a6dcc43e. No 'Access-Control-Allow-Origin' header is present on the requested resource. Origin 'http://localhost:3000' is therefore not allowed access.

I added URIs to my spotify app:

I added the config:
var passport = require('passport');
var SpotifyStrategy = require('passport-spotify').Strategy;
var creds = require('./credentials');

passport.use(new SpotifyStrategy({
    clientID: creds['spotify_client_id'],
    clientSecret: creds['spotify_client_secret'],
    callbackURL: "http://localhost:3000/api/spotify/callback"
  },
  function(accessToken, refreshToken, profile, done) {
    console.log(accessToken, refreshToken, profile, done);
  }
));

and routes:
	// API ROUTES
	// angular hits this
	apiRouter.get('/login', function(req, res, next){
		console.log('angular hit it');
		next();
	}, passport.authenticate('spotify'));

	// redirects to this
	apiRouter.get('/spotify/callback',
		function(req, res, next){
			console.log('angular hit it #2');
			next();
		},
		passport.authenticate('spotify', { failureRedirect: '/' }),
		function(req, res){
			console.log("got allllll the way!!!")
			// successful login
			res.redirect('/#/');
		});

	// angularjs catch all route
	router.get('/*', function(req, res) {
		res.sendFile(rootPath + 'public/index.html', { user: req.user });
	});

	app.use('/api', apiRouter);
	app.use('/', router);

and my server config:
// EXPRESS CONFIG
app.use(bodyParser.json());
app.use(cors());
app.use(methodOverride());
app.use(cookieParser());
app.use(passport.initialize());
app.use(express.static(__dirname + '/public'));

// ROUTES
require('./server/routes')(app);

require('./server/passportConfig');

I even tried the cors package. How do I allow the redirection to the spotify login page?
Again the error in the console is:
No 'Access-Control-Allow-Origin' header is present on the requested resource. Origin 'http://localhost:3000' is therefore not allowed access

okay very strange. I'm using angular on the frontend, I got rid of this error by going around angular.
Broken code:

Log in with Spotify

Working code:
Login  for realz

@jasonshark I think I know what the problem is. You are making an Ajax request when using $http.get to fetch /api/login. Your login endpoint then redirects to Spotify.
However, the Spotify authentication service doesn't allow you to authenticate using ajax request, since you need to redirect to Spotify and show the login form to the user through a regular page to which you navigate. That's why the second one does work.

ahh ha! thank you. Looking forward to having a comprehensive solution to angular-passport-spotify login soon. Will keep you posted. The redirects and the express middleware is tricky to me


Switch default encoding to gzip for now

GZip is significantly faster, so for now lets use that until brotli project gains some performance, and until we get proper after-compression caching.

https://github.com/maplibre/martin/blob/7107db5887f6233f3066077513978cbfe2757c46/martin/src/srv/tiles.rs#L200-L204
Seems this should be updated

https://github.com/maplibre/martin/blob/7107db5887f6233f3066077513978cbfe2757c46/martin/src/srv/tiles.rs#L281-L297
And more tests should be added here.

Thx @sharkAndshark!  Turns out it was never properly working -- it was always using the list of accepted encoding and ignored the order of the supported encodings... So we may have to rework that code.  I re-worked the tests and removed the confusing default, but this is currently broken. Will try to get back to it soonish

Hi @nyurik  I make a PR to this, Could you give it a review?


Alert problem

Hello. I solved previous problem and was running the program.
and there were some problems.
Question : the alert is made just once.
I want to sent alert everytime this program running.
I mean, if you see 'alert_frequency' in config.yml, you can see 'once' next to 'alert frequencey'.
but is there any way to change signal alert frequency?

You can try this fork: https://github.com/krypt0ra/station
It's under an active support and there are dozens of errors fixed and there is completed dockerization. If you will still have an issue there, just create a issue: https://github.com/krypt0ra/station/issues/new?assignees=alkhachatryan&labels=&projects=&template=bug_report.md&title=[BUG]


is it possible to import a custom sbt plugin from GitLab?

We created a custom sbt plugin which is on a repo on GitLab. We would like to import it from other projects.
It doesn't seem possible to add imports to the plugins.sbt file, which we could need to create the nl.zolotko.sbt.gitlab.GitlabCredentials.
import nl.zolotko.sbt.gitlab.GitlabCredentials
import nl.zolotko.sbt.gitlab.GitlabPlugin.autoImport.*

results in
import nl.zolotko.sbt.gitlab.GitlabCredentials
^
sbt.compiler.EvalException: Type error in expression

Ok found the issue.
You need to create project/project/plugins.sbt (the plugins config file for the meta-build). There you need to enable the plugins you need.
Then they can be used from the project/plugins.sbt


[Feature Fix] KeenIO Referrer Url parsing/Error fix

Purpose
Adds referrer url parsing in Keen IO uploads for better searching later on. Adds the pageview data on error for easier diagnostics.
Side Effects
None.

Resubmitting to 0.66


Always relies on floatingLabelStyle when FloatingLabelBehavior.always

Description
With this PR, when InputDecorator.floatingLabelBehavior is set to FloatingLabelBehavior.always the label style is always set to InputDecorator.floatingLabelStyle, previously InputDecorator.labelStyle was used when the field was not focused or was empty.
Related Issue
Fixes https://github.com/flutter/flutter/issues/147231
Tests
Adds 1 test for this particular issue and several missing tests.

I'll check on the google testing issues @bleroux.

@bleroux There is one test failure that i'm not too sure is expected or not. Before this change the prefix/prefixText would not show when the floatingLabelBehavior is set to FloatingLabelBehavior.always, and we unfocus the TextField. After this change the prefix/prefixText always shows when floatingLabelBehavior is set to FloatingLabelBehavior.always. Something similar also happens with suffix/suffixText. The main culprit is this block of code that builds the prefix and suffix https://github.com/flutter/flutter/blob/3b2bfc740f0dab7e8652bff80a9eadc87338c030/packages/flutter/lib/src/material/input_decorator.dart#L2178-L2198 . _AffixText depends on whether the label is floating to decide whether or not to visually show the prefix/suffix. Should the prefix/suffix always be displayed in this case? Let me know if this explanation was clear enough or if I can provide more context.

@Renzo-Olivares Many thanks for the detailed information.

I'm leaning towards the new behavior being the correct one, since I don't see a reason not to show the prefix if the label is floating.

I agree with you. I'm currently working on the M3 tests migration for prefix/suffix, I started looking closer at this behavior and I will post an update tomorrow to let you if I found anything that we missed.

@Renzo-Olivares
I had a closer look and I still fully agree with you on "since I don't see a reason not to show the prefix if the label is floating."
I have updated the PR with two tests related to that behavior (and I will probably add more on the PR I'm working on which goals is to migrate M3 tests related to prefix/suffix).


⁉ add trailinComma eslint config

⁉ WDYT

TASK:
Description, Motivation and Context

During https://github.com/adevinta/spark/pull/1308 our prettier rules had changed from es5 to all. Do you prefer the current default config or come back again to our lastest config but with the new prettier version?
https://prettier.io/docs/en/options.html#trailing-commas
Types of changes

[x] ⚙  Config

Screenshots - Animations

Dnt wrry about the patch

Since it is the new default since Prettier v3, I do not mind leaving this setting as is
However, if some people strongly oppose this and wish to revert back to es5, I will not oppose it 🤷

I don't have a strong opinion about trailing/no trailing commas, I just like that the rule is set.


How to enable Service Graph

I'm currently using this Helm chart to monitor our clusters but for can't seem to understand how to enable the Service Graph to display any data.
I have Alloy hooked up and pushing traces and metrics to Tempo and Prometheus in my Grafana Cloud instance.
Is it possible for someone here to help me out?
Below are my values for the Helm release.

values.yaml
  values:
    cluster:
      name: qa-cluster
    externalServices:
      loki:
        host: https://logs-prod-025.grafana.net
        basicAuth:
          username: "xx"
          password: xxx
      tempo:
        host: https://tempo-prod-18-prod-eu-north-0.grafana.net:443
        basicAuth:
          username: "xxx"
          password: xxx
      prometheus:
        host: https://prometheus-prod-39-prod-eu-north-0.grafana.net
        basicAuth:
          username: "xxx"
          password: xxx
    metrics:
      enabled: true
      cost:
        enabled: false
      extraMetricRelabelingRules: |-
        rule {
            source_labels = ["namespace"]
            regex = "^$|apps"
            action = "keep"
        }
      podMonitors:
        namespaces: [apps]
      probes:
        namespaces: [apps]
      serviceMonitors:
        namespaces: [apps]
    logs:
      enabled: true
      pod_logs:
        enabled: true
        discovery: "all"
        namespaces:
          - "apps"
      cluster_events:
        enabled: false
    traces:
      enabled: true
    opencost:
      enabled: false
    kube-state-metrics:
      enabled: false
    prometheus-node-exporter:
      enabled: false
    prometheus-operator-crds:
      enabled: true

It started working once I enabled kube-stte-metrics scraping.


Extension causes high cpu load

Zignd.html-css-class-completion-unresponsive.cpuprofile.txt

Issue Type: Performance
Extension Name: html-css-class-completion
Extension Version: 1.18.0
OS Version: Windows_NT x64 10.0.10586
VSCode version: 1.33.1

Find more details here: https://github.com/Microsoft/vscode/wiki/Explain:-extension-causes-high-cpu-load

Duplicate of #155. Also, it is missing the file you were expected to attach.


Mirror repo fails to sync

Gitea version (or commit ref): master (7b29780)
Git version: 2.7.4
Operating system: Ubuntu 16.04.3 LTS x64
Database (use [x]):

[x] PostgreSQL
[ ] MySQL
[ ] MSSQL
[ ] SQLite

Description
Please note, this might be a git issue, not a gitea issue, but I'm not sure. Initial migration went OK.
During the mirror synchronization is running, I see this at the log:
2018/02/19 17:15:49 [W] Failed to health check repository (/home/git/data/gitea-repositories/thirdparty/freeswitch.git): exit status 4 - error i
n commit 487128950df6ee433c131b5feaafe81ee86629f4: multipleAuthors: invalid format - multiple 'author' lines
error in commit 8574988c3a378b4d5861ecaeb0e958657635703b: multipleAuthors: invalid format - multiple 'author' lines

2018/02/19 17:20:36 [...odels/repo_mirror.go:258 SyncMirrors()] [E] Failed to synchronize tags to releases for repository: pushUpdateAddTag: Get
Tag: signal: killed

Repository is public, can be cloned from here: https://freeswitch.org/stash/scm/fs/freeswitch.git
I think it's hosted on Atlassian's BitBucket.
Screenshots

I was able to solve this by disabling the fsck for this one repository only since there is a new option for it now in the repository settings.


Update ch8_r1_gates_data.py

Updated n_qubits to num_qubits so as in accordance to https://qiskit.org/documentation/release_notes.html

Thanks @georgekorpas
Taking a look and test driving against up-to-date Qiskit.

Thanks much!


'contact' validation

The 'contact' field should be an object, according to https://github.com/OAI/OpenAPI-Specification/blob/master/versions/2.0.md#contact-object .
When I try to load a schema with the contacts defined as in the above documentation, I receive an exception.
(Is this the file to fix? https://github.com/pipermerriam/flex/blob/master/flex/loading/schema/info.py)

That is the correct file to fix.
Would you be willing to submit a PR changing that schema?


iOS: backup file not accessible for user

The full backup on an iOS device is working but the backup file is saved in a hidden place on the device without any option to transfer it to a safe place. That makes the use of an iPhone or iPad as a Byteball wallet quite risky.
I recommend to use something like the new Files app (introduced with iOS 11) where files are stored on iCloud but can easily transferred elsewhere if the user wishes to do so. More info on Apple's support site here: https://support.apple.com/en-us/HT206481

This has been fixed with v2.4.2


SelectQuestion is showing default option on update

When a item is updated the selectQuestion displayes the first value in the options list instead of the option that matches with item.
Steps to reproduce the behavior:

Go to any page containing a dropdown
Edit the item
Update the item

The SelectQuestion should go back to display whatever option matches the item.

resolved


Elasticsearch sink

Its mentioned in the README but I can't see any implementation where we can point the data to ES. I may have some time to help with this in the next few weeks for a PR. Where should I look to begin? Any pointers that will make implementing this easier?

There's no implementation of an ES reporter as yet, but yes a PR for this would be great 👍
I've implemented a reporter for InfluxDB that should help you get started

Ok, I'll take a look once I get our cluster up and running


curious about reason to use tf.eye

Hi, I ran in to u r code and it gives me a lot help. Thank you.
By the way, I just wonder why u use tf.eye for attention layer.
For many cases, attention layer is implemented by each attention cell and for loop.
tf.eye is okay for implement attention layer at once, but im still curious about why u use it.

Great to hear my code helped you! I like the tf.eye construction over a for loop for aesthetic reason, it is in my opinion easier to read this code.