feat: Allow empty dataframe

Fixes issue #678
Work in progress, need to modify tests.
Does this approach look good to you?
Worked on this with @spbail 😄

Really good that you're starting contributing to open source :) Feel free to ask if you're unsure about certain parts of the change or contribution process.
A few notes:

[test] As you mention, it would be good to have a dedicated test for n=0 (suggestion to add unit tests here: https://github.com/pandas-profiling/pandas-profiling/blob/develop/tests/unit/test_summary_algos.py)
[test] We would need another test to see if the rendered HTML makes sense.
[code] The if df.empty check can be removed entirely.

Hi Simon,
Thank you so much for your feedback and I followed your instructions to make some changes:

[test] As you mention, it would be good to have a dedicated test for n=0 (suggestion to add unit tests here: https://github.com/pandas-profiling/pandas-profiling/blob/develop/tests/unit/test_summary_algos.py)
[code] The if df.empty check can be removed entirely.

However, I have no idea how to create a test to check rendered HTML.
What do you think?

Making progress!
The unit tests should add cases for these functions (all affected by removing the exception):

get_table_stats (empty DataFrame)
describe_counts, describe_generic and describe_supported (empty Series)

I haven't tried running the HTML or Jupyter notebook widgets yet myself, but expect there are quite some parts that should be hidden/empty for empty DFs. We can explicitly test for them in the HTML/Notebooks. If you'd like some feedback, you can either upload a screenshot or the report for an empty dataframe here.
Another thing: you can add the change to the changelog of the next version (docsrc\source\pages\changelog\2_12_0.rst). You can put a summary, link to the issue and your github username (e.g. "contributed by @fwd2020-c")

Simon, I created the tests for describe_counts , describe_generic, describe_supported. They passed pytest but I am not very sure it is the right way to test describe_supported which is wrapped by a decorator.
get_table_stats needs arg of variable_stats, which is ,I guess, the output of describe_1d:
describe_1d(df, summarizer: BaseSummarizer, typeset: Unsupported)
I got an attribute error of "no attribute 'infer_type'"
Is it ok to provide me an example on how to solve this one?
Attached html report:
http://localhost:8888/view/empty_df_report.html

variable_stats is just a dictionary, you could start with an empty dict and add the testing keys needed.
You've shared a link to the file that only you can access. It should be possible to drag the html file to the comment section and github will upload it for you.

Simon, thank you so much! empty dictionary works! (Out of curiosity, how come empty dictionary can replace the arg of variable_stats: Previously calculated statistic on the DataFrame? 🤔)
http://localhost:8888/view/dragged_empty_df_report.html


Fix markdown syntax highlight in document

Remove SET in print statement to ensure  markdown syntax highlight is working properly.

@CastielWong : Thanks for your contribution! The author, @CarlRabeler, has been notified to review your proposed change.


Update GitHub issue template

Motivation:
The GitHub issue template asks for the SwiftLog version/commit hash.
This isn't the SwiftLog project.
Modifications:
Replace SwiftLog with SwiftCrypto in the issue template.
Result:
The GitHub issue template is more relevant to the project.

@swift-server-bot add to whitelist


Update OpenStack Terraform: Modules, Bastions, and New Floating IP config

Problem
The latest version of contrib/terraform/openstack doesn't work with current versions of OpenStack since the floating_ip property is no longer supported on the openstack_compute_instance_v2 resource. There are a few PRs and commits floating around the repo that fix this as well as some other issues with the OpenStack terraform. This PR pulls all of them together into a comprehensive update of this contrib.
Approach
This PR brings together some new approaches for provisioning OpenStack via terraform:

Nodes are all created in a private subnet
The configuration allows for the provisioning of a bastion node to allow access to private nodes inside the cluster
The configuration has been broken up into modules to make it easier to override the allocation of new floating IPs
Replace the obsolete floating_ip properties with openstack_compute_floatingip_associate_v2 resources
Cleaned up generated security groups
Fixed the generation of gluster nodes
Refreshed the README to bring everything up to date

PRs this is Based On

@bradbeam PR #1353 created the private network and bastion host
@manics PR #1837 refactored the terraform config into modules
@manics also fixed how the terraform.py script figures out the floating IP addresses of the hosts from the openstack_compute_floatingip_associate_v2 resources in 3e109be1640f6255bd0ce6b26324b7b239594811

How to test
Just check out the branch and follow the instructions in the README to construct desired kubernetes cluster in a current OpenStack installation

Signed CLA!

Thanks for pointing out the internal network and router name, @manics  . I updated the modules accordingly.

When ready, please merge under my CLA. Thank you

ci check this

@ArchiFleKs is there something I can do about the CI build? It failed on a user permission error.

@BenGalewsky I think we do not test OpenStack in the CI so there is no need to run it (correct me if i'm wrong @mattymo ?) so you need to wait for approval (I cannot do it on my end)

Thanks for that suggestion, @Atoms - I'm not sure what the exact use case for that will be, but it certainly smells better to not have those constants in the terraform config. Pushed a new commit to fix that.

I agree with @Atoms, I think it is better if they are empty by default. The
default is to use the gateway which is a Neutron router.
Most OpenStack deployment are using Neutron and the internal Network can do
the forwarding to upstream DNS service and still provide internal name
resolution for a given tenant.
Le mar. 28 nov. 2017 à 17:17, BenGalewsky<EMAIL_ADDRESS>a
écrit :

Thanks for that suggestion, @Atoms https://github.com/atoms - I'm not
sure what the exact use case for that will be, but it certainly smells
better to not have those constants in the terraform config. Pushed a new
commit to fix that.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/kubernetes-incubator/kubespray/pull/1958#issuecomment-347576417,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABN4qbFrGSCz759zWEZks6bbDUU0EUMWks5s7DI2gaJpZM4QaKRo
.

Fair enough, @ArchiFleKs - just revised the  commit to have  the default dns_nameservers set to  empty list

Thanks, there is no issue with terraform and passing an empty value? I'll
try to test this tommorow.
Le mar. 28 nov. 2017 à 17:50, BenGalewsky<EMAIL_ADDRESS>a
écrit :

Fair enough, @ArchiFleKs https://github.com/archifleks - just revised
the commit to have the default dns_nameservers set to empty list
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/kubernetes-incubator/kubespray/pull/1958#issuecomment-347587246,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABN4qTQ_Ssj1jgTge7i00ZnDc5rCyiecks5s7DnFgaJpZM4QaKRo
.

I've tested with and without dns_nameservers set, looks good to me.

@mattymo Can we merge this ?

@BenGalewsky I used to use this setup having other machines in the original subnet of the tenancy accessing machines inside the k8s cluster (for sending jobs for instance, redirecting traffic to services through reverse proxies, etc). How does this changes in the new setup with the introduced private subnetwork? What would I need to do to the machines in the original subnetwork (say 192.168.0.*) to access machines in the new private subnetwork where k8s cluster will live now? Thanks!

@pcm32 - I just provision the master with a public IP then you shouldn't need to do anything to access the master from your other subnet. By default, the Terraform config creates a security group that allows unlimited access to the master's IP address and port, so it doesn't matter where your other nodes are.

Thanks. Yes, through the public ip shouldn't be a problem, my issue is that I had cases in which I was accessing the other masters without floating IPs internally from the same tenancy... I want to avoid relying only on the master with public ip for provisioning internal services (I am indeed quite limited when it comes to public ips). Is there an easy work around for that? Would it be easy to make the additional private subnet optional in terraform?

Am I understanding this incorrectly, or this PR changes the behaviour to require an extra node entirely to be dedicated as a bastion. Doesn't this mean that now we need a floating ip for the bastion additionally to any other floating IPs previously needed? Could you comment @BenGalewsky? I'm sorry I didn't notice this PR earlier, I would have made comments in time. What was the problem of using a master as bastion itself as it used to work?

Looking into making private subnets optional, @pcm32

@pcm32 I think you should be able to use an existing network instead of having terraform create one. With the modularisation in this PR kubespray.tf is more an "default example" than a definitive Terraform configuration file since you may not want all modules.
If you include only the compute module, and provide the name of an existing network and router_id (should this actually be a network_id @BenGalewsky?) I think this should work

https://github.com/kubernetes-incubator/kubespray/blob/v2.4.0/contrib/terraform/openstack/kubespray.tf#L48
https://github.com/kubernetes-incubator/kubespray/blob/v2.4.0/contrib/terraform/openstack/kubespray.tf#L54


Hints Font weight is different for different tabs

Rewritten:   20171031
The FONT WEIGHT setting is ignored for certain web sites.
I think  this may have started when I disabled Saka Key to analyze a problem, executed some commands and reenabled SakaKey.  However, nothing changes it now.  Tried disabling/enabling SakaKey, restarting Firefox, rebooting my machine, amongst other things.   This is 100% reproducible.
I have noticed that I ONLY GET  "lightweight" FONTS ON CERTAIN EBAY SITES. (as if the Font Weight were 100 or so).

go to https://www.ebay.com/b/Vintage-Fiesta-China-Dinnerware/87/bn_16566437?_sop=10
There, with SakaKey option   FONT WEIGHT  = 900, the hint font is bold.  (My testing shows it doesn't matter what category I am in on Ebay.  Also, it does not matter if I am logged into Ebay or not.)

click the hint for any specific item.   The hints are now IGNORING THE FONT WEIGHT option.

Starting at the "top" of Ebay   (www.ebay.com) the font weight is respected, but once you get to  www.ebay.com/itm/...   or   www.ebay.com/usr/..  (and surely others lower levels), it is ignored.

Thanks for the report.  It's caused by page styles leaking through to hint elements.  This is probably Firefox only since the Chrome version of Saka Key uses Shadow DOM for strong style isolation.


use tr instead of gsub when possible

tr is over 5x faster than gsub. Also tr is the concise idiomatic method call you do for that kind of things

Let me make sure this is still valid and I'll try to get it merged. Sorry for the massive delay - haven't touched this gem in a bit due to work and other things eating up all my time.

@joncalhoun if you want I can remake this PR.


Fix: Dead loop parser if parse jsx content as normal js.

Description:

BREAKING CHANGE:

Related issue (if exists):
Fixed https://github.com/swc-project/swc/issues/6961

Will you work on this?

Related issue (if exists):

Yes, but I guess I would push forward this weekend, feel free to take over it if this issue has high priority.

No worries, it's not a high priority task 😄

Closing as this is fixed by https://github.com/swc-project/swc/issues/7189


Prepare for bveCVX emissions via treedistribution and emission schedules

At the end of this week, the techops multisig will execute a 24 hour tree distribution to emit some bveCVX bought from bribe money to holders of bveCVX.
Starting early next week.  All convex setts will start emitting bveCVX via tree distributions.
Things to confirm:
1:  bveCVX will be handled by emisisons and UI when distributed both via emissions schedules and treedistribution events.
2; all emissions to the bveCVX in the bveCVX LP are blacklisted

Confirmed - Tree distribution events are auto indexed and the new strategies have been added to the subgraph.  emissions schedules are confirmed as working as we're using them to distribute the bveCVX afrom the SPELL sale.


why

TypeError: fetch failed
at Object.fetch (node:internal/deps/undici/undici:11372:11)
at process.processTicksAndRejections (node:internal/process/task_queues:95:5) {
cause: _ConnectTimeoutError: Connect Timeout Error
at onConnectTimeout (node:internal/deps/undici/undici:6616:28)
at node:internal/deps/undici/undici:6574:50
at Immediate._onImmediate (node:internal/deps/undici/undici:6603:37)
at process.processImmediate (node:internal/timers:478:21)
at process.callbackTrampoline (node:internal/async_hooks:130:17) {
code: 'UND_ERR_CONNECT_TIMEOUT'
}
}

It seems a network issue?
#22 See here?

Yep, is probably a network error

这似乎是网络问题？ #22 看到这里了吗？

I don't know if this is a network issue, even if I use VPN, the API keys are all correct

是的，可能是网络错误

I don't know if this is a network issue, even if I use VPN, the API keys are all correct


Differentiated Tensors not Used in Graph

Hi,
I've used a modified version of your code. The modification is supposed to be just some refactors (assuming I've made no mistakes).
I ran it on MNIST and a simple network, and it worked. But when I tried to use it on Cifar10 with Resnet18_comp I got the following error (line 61 of hypergrad.py):
One of the differentiated Tensors appears to not have been used in the graph. Set allow_unused=True if this is the desired behavior.

Do you know what the reason might be?

Hi, have you solve this problem now? I face the same problem.

Hi, have you solve this problem now? I face the same problem.

Hi, unfortunately not.


pencil-to-slab collective for uneven data

Modify transposing subroutines using ALLTOALLW to accommodate uneven data distribution.
Steps:

create an array of MPI types subarray with the size of the non-uniform local subdomains.
save the extents which account for the non-uniformity of data distribution (passing lo_p(:), n_p(:), lo_s(:), n_s(:)).

this is now implemented!


How can I use the pretokenized jsonl file ?

I have pretokenized the proxy codes to speedup training. How can I use it during training? I  cannot see the config file to include the pretrained jsonl file.

Question 2:  For each epoch, the images are randomly cropped, so the corresponding proxy codes should be different from other epochs. So how can a pretokenized proxy code for an image link to all the epochs?

I add pretokenization: "PATH/pretokenized.jsonl" to config file and run, then got the error:
[rank6]:     global_step = train_one_epoch(config, logger, accelerator,
[rank6]:   File "/home/weixing/titok/utils/train_utils.py", line 353, in train_one_epoch
[rank6]:     raise ValueError(f"Not found valid keys: {batch.keys()}")
[rank6]: AttributeError: 'list' object has no attribute 'keys'
How can I run correctly?

Hi,
It seems that you are training tokenizer with the pretokenized jsonl? We have not tried that or supported that in the current codebase. You may need to add this part to the tokenizer training if you want to do that.

Hi,
It seems that you are training tokenizer with the pretokenized jsonl? We have not tried that or supported that in the current codebase. You may need to add this part to the tokenizer training if you want to do that.

Thanks so much for the reply! When pretokenized jsonl is not used, the input of stage 1 training include the image data, but when pretokenized jsonl is used, there are no images in the jsonl file, so how can the data in pretokenized jsonl file be trained ?

Hi,
It seems that you are training tokenizer with the pretokenized jsonl? We have not tried that or supported that in the current codebase. You may need to add this part to the tokenizer training if you want to do that.

Thanks so much for the reply! When pretokenized jsonl is not used, the input of stage 1 training include the image data, but when pretokenized jsonl is used, there are no images in the jsonl file, so how can the data in pretokenized jsonl file be trained ?

For TiTok stage1 training, the raw image input will be tokenized by the MaskGIT-VQGAN first so the reconstruction target is proxy codes. If you have a pretokenized jsonl, you can directly read the codes from the jsonl and thus skip this step, similar to what we did for generation (see the differences between the if else branch)

Hi,
It seems that you are training tokenizer with the pretokenized jsonl? We have not tried that or supported that in the current codebase. You may need to add this part to the tokenizer training if you want to do that.

Thanks so much for the reply! When pretokenized jsonl is not used, the input of stage 1 training include the image data, but when pretokenized jsonl is used, there are no images in the jsonl file, so how can the data in pretokenized jsonl file be trained ?

For TiTok stage1 training, the raw image input will be tokenized by the MaskGIT-VQGAN first so the reconstruction target is proxy codes. If you have a pretokenized jsonl, you can directly read the codes from the jsonl and thus skip this step, similar to what we did for generation (see the differences between the if else branch)

According to my tests, the pretokenization is more than 20 times faster than TiTok stage 1, if they are doing the same thing, why training the TiTok stage 1? Pretokenization should be the priority, am I right?

Hi,
It seems that you are training tokenizer with the pretokenized jsonl? We have not tried that or supported that in the current codebase. You may need to add this part to the tokenizer training if you want to do that.

Thanks so much for the reply! When pretokenized jsonl is not used, the input of stage 1 training include the image data, but when pretokenized jsonl is used, there are no images in the jsonl file, so how can the data in pretokenized jsonl file be trained ?

For TiTok stage1 training, the raw image input will be tokenized by the MaskGIT-VQGAN first so the reconstruction target is proxy codes. If you have a pretokenized jsonl, you can directly read the codes from the jsonl and thus skip this step, similar to what we did for generation (see the differences between the if else branch)

According to my tests, the pretokenization is more than 20 times faster than TiTok stage 1, if they are doing the same thing, why training the TiTok stage 1? Pretokenization should be the priority, am I right?

Pretokenization can speed up the training indeed. Since random crop is used for tokenizer training, the pretokenization may not give the exact same results compared to on-the-flight tokenization for tokenizer training. We have not tried applying pretokenization for TiTok training, but it should be fine if your dataset is large enough (or you include those different crops in the pretokenization jsonl as well)


Language Injection Support

Background: When using Smithy to define API GW integrations that directly integrate with other AWS services, like DynamoDB, it is common to use Velocity Template Language (VTL) in the RequestTemplate and/or ResponseTemplate to do processing of the user input before passing on to the service, or processing of the service return before passing it back to the caller. Generally in coding, having language constructs (SQL, JSON, VTL) embedded in a string is a poor experience since the editor just treats it as a string, so you forego things like syntax highlighting and auto-complete. IntelliJ has functionality to overcome this with Language Injection so that it knows where processing from another language can be done within a file.
Request: It would be helpful if the Smithy Plugin provided support for Language Injection, see Language Injection SDK so that VTL syntax highlighting could be done for content within RequestTemplate and ResponseTemplate fields at least. AWS may allow VTL in additional locations, these are just the two that I am using right now.

Looked into this briefly, injection host logic isn't too crazy, but it is a decent bit of work.
At a high level, the language injection host (e.g. a string literal in a Smithy file) has to support decoding the host literal while keeping track of where every decoded character resides in the encoded string, so that way IntelliJ can properly format/highlight/etc. using the decoded string as input but then transposing that onto the original host literal in the editor window.
The plugin has encoding/decoding logic already, but doesn't keep track of the index mapping. So would have to work through that.
I tested language injection on string literals without escaped characters and it worked perfectly fine (e.g. injecting regex for any @pattern trait values).


How to profile short lived application

I'm looking for way to stop profiling on JVM exit.
Profiler can be attached and started using -agentpath option on process start.
But how to stop it properly if JVM exits after few seconds without losing precious information?

If you specify the output filename (file=) and the output format (svg, collapsed, etc.) in the agent arguments, the profiler will automatically dump the collected data before the JVM exits.
E.g.
-agentpath:/path/to/libasyncProfiler.so=start,svg,file=/results/profile.svg

Also, the latest version from master has the output format autodetection, i.e. svg option is no longer needed if the filename ends with .svg.

Thanks, it worked.
I thought I tried this already, but looks like did something wrong.


AVRO-3955: [Rust] allow deserializer to decode enum string

What is the purpose of the change
This pull request allow to decode an avro enumeration from a previously encoded one.
Below, the example case to reproduce it.
    #[derive(PartialEq, Eq, Serialize, Deserialize, Debug)]
    pub struct StringEnum {
        pub source: String,
    }

    #[test]
    fn avro_xxxx_decode_enum() {
        let schema_content = r#"
{
  "name": "AccessLog",
  "namespace": "com.clevercloud.accesslogs.common.avro",
  "type": "record",
  "fields": [
    {
      "name": "source",
      "type": {
        "type": "enum",
        "name": "SourceType",
        "items": "string",
        "symbols": ["SOZU", "HAPROXY", "HAPROXY_TCP"]
      }
    }
  ]
}
"#;

        let schema = crate::Schema::parse_str(schema_content).unwrap();
        let data = StringEnum { source: "SOZU".to_string() };

        // encode into avro
        let value = crate::to_value(&data).unwrap();

        let mut buf = std::io::Cursor::new(crate::to_avro_datum(&schema, value).unwrap());

        // decode from avro
        let value = crate::from_avro_datum(&schema, &mut buf, None).unwrap();

        let decoded_data: StringEnum = crate::from_value(&value).unwrap();
        // :arrow_double_up: throw => Failed to deserialize Avro value into value: Expected a String|Bytes|Fixed|Uuid|Union, but got Enum(0, "SOZU")

        assert_eq!(decoded_data, data);
    }

Verifying this change
This change is already covered by existing tests on enums and a new test avro_xxxx_decode_enum.
Documentation

Does this pull request introduce a new feature? no
If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

Please create the Jira issue and update the PR title with it and the test method names!
I can update the commit messages when squash+merging the PR!

You will need to cargo fmt --all too.

Will do :)

@martin-g the issue is created and it is AVRO-3955.
I have updated the pull request as well with the issue identifier.

For some reason I cannot apply the suggestions from the Github UI ... I can do it later in the IDE!

I have updated the commit with your changes.
I think you could not edit the pull request as you have not the right to do it on my fork, but should be fine.

@martin-g can you click to trigger the ci?

Thank you for the contribution, @FlorentinDUBOIS !

My pleasure :tophat:! Thank you very much! :heart:


The question about size of the input image.

Thank you very much for your sharing!
The following error occurred when I entered an image size of 412*548:
in_feats = torch.cat(in_feats, dim=1)
RuntimeError: Sizes of tensors must match except in dimension 1. Expected size 102 but got size 103 for tensor number 1 in the list.
What is the reason for this problem？How should I predict dehaze images?
Looking forward to your reply！

Which model did you use？
When inferring, the input image is padded in line 56 in 'test.py'
input = pad_img(input, network.patch_size if hasattr(network, 'patch_size') else 16)

Which model did you use？ When inferring, the input image is padded in line 56 in 'test.py'
input = pad_img(input, network.patch_size if hasattr(network, 'patch_size') else 16)

I uesd gunet_d() model.

Which model did you use？ When inferring, the input image is padded in line 56 in 'test.py'
input = pad_img(input, network.patch_size if hasattr(network, 'patch_size') else 16)

thank you!  The problem is solved!

Glad to help you


Breaking change: timed no longer takes unit types and fix truncation of data

Fixes the issue with: https://github.com/ChristopherDavenport/epimetheus/issues/152
If you'd like me to keep the old methods around and make this new one and name it something instead of making a binary incompatible change let me know what you'd like to see happen and we can do it that way instead.

@ChristopherDavenport It looks like Summary has the same issue with how it's built.  Would you like me to do that in the same PR?


[numpy] fix mixed type backward

Description
attempt to fix issue regarding mixed type in binary op add, minus, true_divide, mod
#18022 #18084
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.

[ ] The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
[ ] Changes are complete (i.e. I finished coding on this PR)
[ ] All changes have test coverage:
Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
[ ] Code is well-documented:
For user-facing API changes, API doc string has been updated.
For new C++ functions in header files, their functionalities and arguments are documented.
For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
Check the API doc at https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
[ ] To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

[ ] Feature1, tests, (and when applicable, API doc)
[ ] Feature2, tests, (and when applicable, API doc)

Comments

If this change is a backward incompatible change, why must this change be made.
Interesting edge cases to note here

@mxnet-bot run ci [miscellaneous, windows-cpu, windows-gpu]

@mxnet-bot run ci [windows-cpu, windows-gpu]

@mxnet-bot run ci [unix-gpu]

LGTM. @yzhliu

Thanks @BenjaminCHEN2016 @hgt312


Replace text with icons in abilities menu

Replace this

with some icons.
(What about "end turn", "exit" and "deselect" buttons?)

wip:


Luau files are not recognized

https://luau-lang.org/

Ran into this issue earlier, thankfully @amaanq helped me out with it but I can definitely see this issue causing some confusion for people.

https://luau-lang.org/

Thanks, I'll include it and make a patch.
It appears this is a superset of Lua, thus I'll add plugins that load
the Lua plugins for now.  Can later be improved by adding Luau specific
rules.
--
This computer is so slow, it takes forever to execute and endless loop!
/// Bram Moolenaar -- @.*** -- http://www.Moolenaar.net   \
///                                                                      \
\\        sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ ///
\\            help me help AIDS victims -- http://ICCF-Holland.org    ///


PR merge conflict for solution and discussion page

while merging the discussion page and solutions pages there's a merge conflict

redacted


failed to download thai2rom-pytorch-attn-v0.1.tar

When attempting to use thai2rom engine for romanzation I end up with a 404.
This download url seems not to exist. I also tried it in the browser.
                "download_url": "https://raw.githubusercontent.com/artificiala/thai-romanization/master/notebook/thai2rom-pytorch-attn-v0.1.tar",
Cheers,

Thank you!

Thanks a lot :) that was quick !!!


button hover text color-yiq, wrong parameter

mixins/_buttons.scss
&:hover {     @include color-yiq($background); }
$background should be $active-background

Duplicate of #23514.


Sticky Controller

Make popped-out controller above all other windows

How long would it take to add a "pin" icon to the top right icons for window manipulation that toggles always on top behavior?

Is this better than the always sticky behaviour?
I reckon it could be the same amount of time, but we don’t have a custom title bar yet.


Add diff mocha conf to support kitty diff

Add diff mocha conf to support kitty diff
See:

https://sw.kovidgoyal.net/kitty/kittens/diff/
https://github.com/dracula/kitty/blob/master/diff.conf

This isn't really readable on my end…

I've played around with different colours, such as a 70% base 30% red/green mix, which is more readable.
Would you be willing to update this PR?

Please let me know which color need to update, I only copy the diff from dracula and edit some color from it.

I have changed some background colours for better readability, I'd happily merge this one if that's alright with you.
Regarding the changes in the author comment: I'll change the other ones to "Catppuccin Org" as well, once it's merged.

Oh yeah, and please do feel free to add yourself to the “Thanks to” section on the README, or let me know how you'd like to be credited.

Thanks for updating, you can merge if you want. It looks good on my machine!


GH-35594: [R][C++] Bump vendored date library

There was an issue with tzdb 0.4.0 and the shipped arrow tz.cpp.
This PR bumps the vendored version of the date library to commit cc4685a21e4a4fdae707ad1233c61bbaff241f93.

Closes: #35594

It seems like almost all of the files in https://github.com/apache/arrow/tree/main/cpp/src/arrow/vendored/datetime are from <date> so it might be worth updating all of them rather than just tz.cpp, just to keep everything in sync with upstream

Indeed, it seems there are a couple other changes to include:
$ git diff --stat 2e19c006e2218447ee31f864191859517603f59f cc4685a21e4a4fdae707ad1233c61bbaff241f93
 include/date/date.h         |   6 ++--
 include/date/iso_week.h     |  18 +++++++++---
 include/date/ptz.h          | 105 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++------
 include/date/tz.h           |   4 +--
 src/tz.cpp                  | 185 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++-------------------
 test/iso_week/year.pass.cpp |   3 ++
 test/testit                 |   6 ++++
 7 files changed, 282 insertions(+), 45 deletions(-)

I think I've got them all now

@github-actions crossbow submit test-r-versions


Dep optimization failed with error

vite v1.0.0-rc.8
[vite] Optimizable dependencies detected:
core-js, vite-tsconfig-paths, vue
[vite] Dep optimization failed with error:
Dependency vite-tsconfig-paths is attempting to import Node built-in module path.
This will not work in a browser environment.
Imported by: node_modules/vite-tsconfig-paths/dist/index.js
Tip:
Make sure your "dependencies" only include packages that you
intend to use in the browser. If it's a Node.js package, it
should be in "devDependencies".
If you do intend to use this dependency in the browser and the
dependency does not actually use these Node built-ins in the
browser, you can add the dependency (not the built-in) to the
"optimizeDeps.allowNodeBuiltins" option in vite.config.js.
If that results in a runtime error, then unfortunately the
package is not distributed in a web-friendly format. You should
open an issue in its repo, or look for a modern alternative.
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

Install it as a dev dependency


Add InReplyTo to PullRequestComment struct

In V3 of the GitHub API, pull request comments are created in two ways. The first way is to create a comment on a specific line of a file in a commit with the following parameters:

Name
Type
Description

body
string
Required. The text of the comment

commit_id
string
Required. The SHA of the commit to comment on.

path
string
Required. The relative path of the file to comment on.

position
integer
Required. The line index in the diff to comment on.

And the second way is through a reply to an existing comment with the following parameters:

Name
Type
Description

body
string
Required. The text of the comment

in_reply_to
integer
Required. The comment id to reply to.

This commit adds support for the second (or "Alternative Input" according to the GitHub docs) way.

cool, didn't know about that.  thanks!


Bug: PR always failing when raised

Error:
Review required
At least 1 approving review is required by reviewers with write access.

I couldn't understand why it is happening. The pipeline is working well on my side. I will check it again.

I couldn't understand why it is happening. The pipeline is working well on my side. I will check it again.

Sure thanks

Hi @yagizhanNY
For the GitHub action, i wanted to know why you have that deploy action being executed also for raising a PR, i think it should be just for merging into master right?
Correct me if i am wrong.

Hi @yagizhanNY, i also want to know about envManager.js file built. for ci/cd
How is that locating the src/environments folder if already present?
If not present the i think it's creating it, but upon creating it's giving me error (i am replicating it)
'/home/runner/work/Todo/todo/src/environments/environment.ts' is not a module

Yes, you are right. When we create a merge request to the master, it runs.

Hi @yagizhanNY, i also want to know about envManager.js file built. for ci/cd How is that locating the src/environments folder if already present?
If not present the i think it's creating it, but upon creating it's giving me error (i am replicating it)
'/home/runner/work/Todo/todo/src/environments/environment.ts' is not a module

I have a secret file under my GitHub secrets. This file same as an environment.ts file. I am keeping this file under the secrets because API key etc. must be secret. envManager.js file is for create env files when the pipeline is started to run. Normally, your env files must be include into .gitignore file so they shouldn't be existing when you create a merge request.

Hi @yagizhanNY, i also want to know about envManager.js file built. for ci/cd How is that locating the src/environments folder if already present?
If not present the i think it's creating it, but upon creating it's giving me error (i am replicating it)
'/home/runner/work/Todo/todo/src/environments/environment.ts' is not a module

I have a secret file under my GitHub secrets. This file same as an environment.ts file. I am keeping this file under the secrets because API key etc. must be secret. envManager.js file is for create env files when the pipeline is started to run. Normally, your env files must be include into .gitignore file so they shouldn't be existing when you create a merge request.

Can you elaborate a bit more on this?
I didn't understand the part when you say "file" is stored in github, is it just OpenAI key?
What i didn't understand is, all of the env files are being made upon push into master, ie environment.ts file is being created, but when i tried to replicate your process ie making envManager.js and then it would create src/environments folder and put in the environment files
but while doing this it errors out for me
'/home/runner/work/Todo/todo/src/environments/environment.ts' is not a module
it also says
Jobs:
Run node envManager.js
src does not exist, creating now... /home/runner/work/Todo/todo
environment.ts created successfully /home/runner/work/Todo/todo
undefined
Folder created successfully src/environments    /home/runner/work/Todo/todo
And because of the error above it's giving
Error: Error: src/app/services/todo.service.ts:4:29 - error TS2306: File '/home/runner/work/Todo/todo/src/environments/environment.ts' is not a module.
(not treating the file as a module i think), did you have any other changes
Actually, i am having src/environments/environment.ts being referenced in many files but since i am not pushing the env files to the repo, it's erroring out here.

I have updated the deploy.yml file. After now, pipeline won't executed when merge request is created.

I have updated the deploy.yml file. After now, pipeline won't executed when merge request is created.

Oh okay nice

I have updated the deploy.yml file. After now, pipeline won't executed when merge request is created.

Oh okay nice

Is there a way to remove the envmanager file and use some other approach?


Load flashcards

Write an API endpoint to get all the flashcards that a user needs to revise to day based on their due date

This is now completed


Pictures

https://github.com/uggla/bevy_university/blob/d1253bf1a1421e91fa5d87e5b07f7c8e8657aac8/slides/templates/bevy_university.html#L126
https://github.com/uggla/bevy_university/blob/d1253bf1a1421e91fa5d87e5b07f7c8e8657aac8/slides/templates/bevy_university.html#L163
I would like pictures of us.
It would be cool to have our faces on a Star Wars character. I'd like to be an empire officer.
I think that should not be too difficult to do with a deepfake, but I have not investigated it yet.
If you know how to do it it will be great.

I successfully tested the following service : https://pixlr.com/face-swap/ :

Do you want I manage the repo update ? (Send me photo in private)

Hey, cool. You look great as a empire officer !
I'm gonna send you a couple of picture, I let you imagine which character I could be. I hope an evil one, but not Jaba. :)

haha okay :)

@uggla ---> https://github.com/uggla/bevy_university/pull/6


made profile; intial commit

Issue, Bugfix or New Feature:
Related issue: Link to related issue.
Description
Describe your changes here.
Tasks

[x] Feature 1
[x] Feature 2
[ ] Feature 3

:warning:  Warning :warning:
Write down warnings here.

Didn't like what originally said. Made a few changes. Sorry for the inconvenience.


Frontend: Disallow entering non-numerical characters in token amount input

closes #1165
Slight refactoring to the Input component led to splitting the "focus on mount" behavior to its own reusable directive.

Thanks for the review!


Feature request: grammar / WHERE namespace extensions

Use case: Cypher supports a robust library for datetime analysis, among other extensions. While it is unrealistic to expect their integration here, it would be nice to allow python equivalents during queries. I envision something like this:
import pandas as pd
GrandCypher(g, namespace={"datetime": pd.to_datetime, ...}).run("""
MATCH (a) --> (b)
WHERE a.date < datetime("2024-01-01")
RETURN a.name
""")

Would love to hear your thoughts.

I was able to achieve something similar with this grammar modification:
%import python.expr_stmt -> python_expr

// Replaces current `where_clause` definition
where_clause: "where"i python_expr

And this implementation:
from lark.reconstruct import Reconstructor

...

class _CypherNamespace(dict):
    """
    dot.notation access to dictionary attributes, useful for enabling cypher filtering
    syntax like `m.born < to_datetime("1990")`
    """

    def __getattr__(self, attr):
        out = self.get(attr)
        if isinstance(out, dict):
            return type(self)(out)
        return out

    __setattr__ = dict.__setitem__
    __delattr__ = dict.__delitem__

_CypherGrammar = Lark(..., maybe_placeholders=False)
reconstructor = Reconstructor(_CypherGrammar)

# ... update these CypherTransformer methods
def where_clause(self, where_clause: list[Tree]):
    self.where_string = reconstructor.reconstruct(where_clause[0])

def _new_where_condition(cname_value_map: dict, target_graph: nx.DiGraph, _):
    if not self.where_string:
        return True, []
    eval_locals = {
        cname: _CypherNamespace(target_graph.nodes[value])
        for cname, value in cname_value_map.items()
    }
    result = eval(self.where_string, FILTER_EXPRESSION_GLOBALS, eval_locals)
    return result, [result]

Currently, it assumes a hard-coded list of globals that the user can update with their own values.
It was a fun intro to lark 🙂

@ntjess just wanted to pop in and tell you this looks so awesome — I need to take a closer look here (and in #59) but I'm unfortunately in the midst of my phd dissertation prooposal process and it's using up all my cycles for the next wee or so. But I love what you did here! I'm brainstorming about how we can integrate into the official codebase while keeping back-compat and vuln surface-area low!!


Inline evaluation doesn't work and hangs.

On Linux, inline evaluation hangs like the following:

This never evaluates. However, the non-inline functions of the extension work: there are no other issues. I am using the most recent version of the official VS Code with chez scheme 10.0

I've attempted to debug the issue on my end, but I was unable to start the debugger on the extension because I was missing the following:

/opt/visual-studio-code/resources/app/out/bootstrap-amd.js
/opt/visual-studio-code/resources/app/out/bootstrap-fork.js
I've never had this issue before, and I'm not sure if it's unique to this extension.

Thanks for your bug report. I'll try to reproduce it.
The bootstrap*.js files are something VS Code specific, but without them Code doesn't work at all?

I can't reproduce that on MacOS.
Could you please post the output of the OUTPUT tab, when switched to Chez Scheme REPL? It should say something like "Sent (+ 1 1) to REPL using command chezScheme.evalLastSexp"

Thanks for your bug report. I'll try to reproduce it.
The bootstrap*.js files are something VS Code specific, but without them Code doesn't work at all?

The plugin works when installed normally, but when I git clone and npm install then try the extension debugger on VS Code, it doesn't work.

I can't reproduce that on MacOS.
Could you please post the output of the OUTPUT tab, when switched to Chez Scheme REPL? It should say something like "Sent (+ 1 1) to REPL using command chezScheme.evalLastSexp"

There is no output, nor does it try to spawn a repl if it doesn't exist, when I try to do any inline evaluation. I'm not sure if it is sending anything anywhere at all. Other commands like macro expansion with Alt+Enter works just fine. I think it is just the inline evaluation that hangs.

There is no output, nor does it try to spawn a repl if it doesn't exist, when I try to do any inline evaluation. I'm not sure if it is sending anything anywhere at all. Other commands like macro expansion with Alt+Enter works just fine. I think it is just the inline evaluation that hangs.

I can reproduce the error in a Linux VM. Just to be sure: autocompletion and documentation on hover works for you, right?  Because these use the same "internal" REPL as the inline evaluation.

The plugin works when installed normally, but when I git clone and npm install then try the extension debugger on VS Code, it doesn't work. It does not start at all, and I get the dialog message box saying that I am possibly missing the two files I mentioned above and loader.js in that same directory (I do have this file).

Hmm, this sounds strange, I'll try to reproduce that in the Linux VM too.

You won't believe me!
Could it be that you are using the extension "TodoTree" from "Gruntfuggly"? After disabling this extension, everything works in my extension!
This is the stack-trace I got in the "OUTPUT" Tab of "Extension Host", which showed me the culprit:
[error] SyntaxError: Invalid flags: dsu
	at k (/home/roland/.vscode/extensions/gruntfuggly.todo-tree-0.0.226/dist/extension.js:114:74341)
	at Array.d (/home/roland/.vscode/extensions/gruntfuggly.todo-tree-0.0.226/dist/extension.js:114:3580)
	at Object.parse (/home/roland/.vscode/extensions/gruntfuggly.todo-tree-0.0.226/dist/extension.js:114:71938)
	at r.parse (/home/roland/.vscode/extensions/gruntfuggly.todo-tree-0.0.226/dist/extension.js:1:12692)
	at Object.parse (/home/roland/.vscode/extensions/gruntfuggly.todo-tree-0.0.226/dist/extension.js:114:415)
	at l (/home/roland/.vscode/extensions/gruntfuggly.todo-tree-0.0.226/dist/extension.js:52:165)
	at Array.get [as indices] (/home/roland/.vscode/extensions/gruntfuggly.todo-tree-0.0.226/dist/extension.js:52:2895)
	at Re (/home/roland/tmp/vscode-scheme-repl/out/extension.js:16:2643)
	at zr (/home/roland/tmp/vscode-scheme-repl/out/extension.js:16:210)
	at g (/home/roland/tmp/vscode-scheme-repl/out/extension.js:12:1237)
	at Y (/home/roland/tmp/vscode-scheme-repl/out/extension.js:16:2259)
	at vr (/home/roland/tmp/vscode-scheme-repl/out/extension.js:12:1338)
	at g (/home/roland/tmp/vscode-scheme-repl/out/extension.js:12:1070)
	at U (/home/roland/tmp/vscode-scheme-repl/out/extension.js:12:956)
	at Ne (/home/roland/tmp/vscode-scheme-repl/out/extension.js:25:918)
	at /home/roland/tmp/vscode-scheme-repl/out/extension.js:830:29871

Nope, it seems like a different error on my end

It seems similar to this issue
Maybe this can get fixed if I keep on disabling other extensions. I'll dig around.

There is no output, nor does it try to spawn a repl if it doesn't exist, when I try to do any inline evaluation. I'm not sure if it is sending anything anywhere at all. Other commands like macro expansion with Alt+Enter works just fine. I think it is just the inline evaluation that hangs.

I can reproduce the error in a Linux VM. Just to be sure: autocompletion and documentation on hover works for you, right? Because these use the same "internal" REPL as the inline evaluation.

The plugin works when installed normally, but when I git clone and npm install then try the extension debugger on VS Code, it doesn't work. It does not start at all, and I get the dialog message box saying that I am possibly missing the two files I mentioned above and loader.js in that same directory (I do have this file).

Hmm, this sounds strange, I'll try to reproduce that in the Linux VM too. [Edit] Yes, this happens for me too in the Linux VM, but works on MacOS.
You need to run
npm run bundle

to generate the extension in out/extension.js, after that, debugging works.

Yep, the hover and documentation are working fine. It's just the inline evaluation I think.

Ah, I see. A SIGPIPE means that the connection to the (internal) Scheme REPL has been closed. The question of course is why? And why only when sending something to evaluate and not when asking for completions or documentation?
As I can't do that myself, please add the following additional logging to the file src/evalREPL.ts, at line 322
https://github.com/Release-Candidate/vscode-scheme-repl/blob/main/src/evalREPL.ts#L322
     } else if (out.error) {
        env.outChannel.appendLine(
            `Error sending ${c.cfgSection}.${data.vscodeCommand}: ${out.error}`
        );

and wrap the whole function in a try ... catch.
The whole function should read:
async function evalSexp(
    env: h.Env,
    data: {
        editor: vscode.TextEditor;
        exp: {
            sexp: string;
            startLine: number;
            startCol: number;
        };
        range: vscode.Range;
        vscodeCommand: string;
    }
): Promise<void> {
    try {
        const out = await runREPLCommand(
            env.config,
            data.editor.document,
            data.exp.sexp
        );
        env.outChannel.appendLine(
            `Sent ${data.exp.sexp} to REPL using command ${c.cfgSection}.${data.vscodeCommand}`
        );
        if (out.stderr) {
            const errMsg = out.stderr.trim();
            decor.addEditorDecoration({
                editor: data.editor,
                evalDecoration: env.evalErrorDecoration,
                evalDecorations: env.evalErrorDecorations,
                range: data.range,
                text: errMsg,
            });
            decor.removeRange({
                decorations: env.evalDecorations,
                decoration: env.evalDecoration,
                editor: data.editor,
                range: data.range,
            });
        } else if (out.error) {
            env.outChannel.appendLine(
                `Error sending ${c.cfgSection}.${data.vscodeCommand}: ${out.error}`
            );
        } else {
            const match = out.stdout
                ? out.stdout.match(matchREPLResponse("(.+?)"))
                : "";
            const response = match ? match[1].trim() : "";
            decor.addEditorDecoration({
                editor: data.editor,
                evalDecoration: env.evalDecoration,
                evalDecorations: env.evalDecorations,
                range: data.range,
                text: response,
            });
            decor.removeRange({
                decorations: env.evalErrorDecorations,
                decoration: env.evalErrorDecoration,
                editor: data.editor,
                range: data.range,
            });
        }
    } catch (err) {
        env.outChannel.appendLine(
            `Error sending ${c.cfgSection}.${data.vscodeCommand}: ${
                (err as Error).message
            }`
        );
    }
}

Then you should see an error message in the "OUTPUT" tab of "Chez Scheme REPL".

I've copied the function definition over, and the error is very weird. That did not append anything to the out channel for both VS Code windows (the one running the debugger and the one being debugged).

However, now there is a new error popping up on the editor for ENOENT. It could be missing some intermediate file needed for the operation. Could you tell me how I could find where this is happening?

Sorry, I was looking at the wrong place.
Chez Scheme REPL starting.
Registered all commands
Extension startup finished.
Searching for completions of +
Completion error: spawn scheme ENOENT
using (filter
      (lambda (x)
        (cond
          [(symbol? x) (equal? "+" (substring (symbol->string x) 0 1))]
          [else #f]))
      (apropos-list "+" (interaction-environment)))
Got completions:
Sent (expand '(+ 1 1)) to REPL using command chezScheme.expandLastSexp
Sent (expand '(+ 1 1)) to REPL using command chezScheme.expandLastSexp
Sent (+ 1 1) to REPL using command chezScheme.evalLastSexp
Error sending chezScheme.evalLastSexp: spawn scheme ENOENT

Completion error: spawn scheme ENOENT

says that completions don't work either.
Is scheme the correct name of your Chez executable? But on the other hand, it works as interactive REPL. Is the scheme command in a special director, which isn't part of the "normal" Linux PATH?

Completion error: spawn scheme ENOENT

says that completions don't work either.
Is scheme the correct name of your Chez executable? But on the other hand, it works as interactive REPL. Is the scheme command in a special directory, which isn't part of the "normal" Linux PATH?
Can you please post the output of printenv PATH in the Console of VS Code? And add the output of the PATH to the program, by adding
env.outChannel.appendLine(`PATH: ${process.env.PATH}`);

To the beginning of evalSexp, so that it now is
async function evalSexp(
    env: h.Env,
    data: {
        editor: vscode.TextEditor;
        exp: {
            sexp: string;
            startLine: number;
            startCol: number;
        };
        range: vscode.Range;
        vscodeCommand: string;
    }
): Promise<void> {
    env.outChannel.appendLine(`PATH: ${process.env.PATH}`);
    try {
        const out = await runREPLCommand(
            env.config,
            data.editor.document,
            data.exp.sexp
        );
        env.outChannel.appendLine(
            `Sent ${data.exp.sexp} to REPL using command ${c.cfgSection}.${data.vscodeCommand}`
        );
        if (out.stderr) {
            const errMsg = out.stderr.trim();
            decor.addEditorDecoration({
                editor: data.editor,
                evalDecoration: env.evalErrorDecoration,
                evalDecorations: env.evalErrorDecorations,
                range: data.range,
                text: errMsg,
            });
            decor.removeRange({
                decorations: env.evalDecorations,
                decoration: env.evalDecoration,
                editor: data.editor,
                range: data.range,
            });
        } else if (out.error) {
            const errMsg = out.error.trim();
            env.outChannel.appendLine(
                `Error sending ${c.cfgSection}.${data.vscodeCommand}: ${errMsg}`
            );
            decor.addEditorDecoration({
                editor: data.editor,
                evalDecoration: env.evalErrorDecoration,
                evalDecorations: env.evalErrorDecorations,
                range: data.range,
                text: errMsg,
            });
            decor.removeRange({
                decorations: env.evalDecorations,
                decoration: env.evalDecoration,
                editor: data.editor,
                range: data.range,
            });
        } else {
            const match = out.stdout
                ? out.stdout.match(matchREPLResponse("(.+?)"))
                : "";
            const response = match ? match[1].trim() : "";
            decor.addEditorDecoration({
                editor: data.editor,
                evalDecoration: env.evalDecoration,
                evalDecorations: env.evalDecorations,
                range: data.range,
                text: response,
            });
            decor.removeRange({
                decorations: env.evalErrorDecorations,
                decoration: env.evalErrorDecoration,
                editor: data.editor,
                range: data.range,
            });
        }
    } catch (err) {
        env.outChannel.appendLine(
            `Error sending ${c.cfgSection}.${data.vscodeCommand}: ${
                (err as Error).message
            }`
        );
    }
}

With that we should be able to compare the PATHs for the two REPLs.

Installing chez from AUR added chez and chez-script in my PATH, and the way it was working originally, chez was aliased to scheme. I've also tried aliasing chez-script to scheme instead, which completely broke the extension. Is there a different executable I should use?

Ah, I understand now. I believe the extension does not work with an alias, and I would need to change the name of the executable to scheme. This makes it so that macroexpansion works but not the others since macroexpansion seems to work differently.
PATH: /usr/local/sbin:/usr/local/bin:/usr/bin:/usr/lib/jvm/default/bin:/usr/bin/site_perl:/usr/bin/vendor_perl:/usr/bin/core_perl
This is the PATH, and the second directory contains chez. It just assumes that chez exists in the PATH, not as an alias in the terminal.

No, chez or scheme are fine. You can set the name of the executable to use in the settings of Chez Scheme REPL, you could try it with chez instead of the default scheme, the settings name is chezScheme.schemePath.

Oh, of course. Yes, shell aliases only work if the command is send to a shell - which is the case in the interactive REPL. But spawn does not. So setting the command name to chez in the settings should solve the issue.

Thank you for your time. I should have looked at the extension settings closer. It might be helpful to add this in the description of the extension in case someone has a similar problem.
I also found a different error while testing this out:

It seems like you cannot use inline evaluation if the file doesn't exist yet. I was not sure if it was intended.

Actually I've just got the idea to check the Scheme executable at startup and display an error message if it doesn't work.
And you are right, it tries to send the whole file which doesn't work if it hasn't been saved yet.
Anyways, thank you very much for your time and help, without you I wouldn't have a chance to solve the problem!
I'm going to make a new version of the extension, so there will be an update in the not too distant future.


Error: 403 UnrecognizedClientException if the XRay Region is set to Jakarta (ap-southeast-3)

I am getting the following error in the xray daemonset pods deployed in ROSA, if the region I specified in the xray config yaml is "ap-southeast-3" (Jakarta).
2023-01-24T05:52:51Z [Error] Sending segment batch failed with: UnrecognizedClientException: 	status code: 403, request id: 59881ff1-a1c3-4f01-b812-2b1f0541cfe0
When I tried to specify other region such as ap-southeast-2 (Sydney) and ap-southeast-1 (Singapore), it's working and I can see the data/traces in the AWS X-Ray console.
This is the deployment guide I used, for your reference: rosa-xray

Hi @macirculado
Can you ensure that the "ap-southeast-3" region is enables in your aws account? It is one of the regions not enabled by default.

Hi @srprash Yes, the "ap-southeast-3" (Jakarta) region is already enabled in our AWS account. We have already deployed other AWS resources in that region.

Hi @macirculado Since we are triaging this issue internally, I am closing this one. Please feel free to reopen if you think the issue still pertains to the X-Ray Daemon and could be beneficial to the open-source community.
Thanks.


Link all meltano ... CLI code spans to relevant CLI docs

Migrated from GitLab: https://gitlab.com/meltano/meltano/-/issues/2303
Originally created by @DouweM on 2020-08-21 19:38:25

View 2 previous comments from the original issue on GitLab

@DouweM You initially opened this one -- is it still relevant? Was this about linking to help docs in the CLI?

@afolson This is about sections in the docs that refer to meltano foo without actually linking that to reference/command-line-interface#foo where the user can learn more. I think we should always link those command snippets, but that'd be something to automate or document explicit guidelines around, not something to do one-off.

@DouweM Ah perfect! Thanks.


avoid config.guess tab problem on Ubuntu [fix: #1402]

Since patching expands tabs to spaces (on Ubuntu?), avoid tab-stripping syntax.

Closing this in favor of https://github.com/flavorjones/mini_portile/pull/67

mini_portile2 2.1.0 contains the PR mentioned above; and this dependency has been added to Nokogiri master. I expect this to be fixed in v1.6.8 final when it drops.


DeviantArt downloads getting "null"

Ripme version: 1.7.87

Java version: 10.2.0

Operating system: Win 8.1

Exact URL you were trying to rip when the problem occurred:
https://www.deviantart.com/reiq/gallery/7806055/fan-art
Tried other galleries, got the same result.

Please include any additional information about how to reproduce the problem:
Apparently, it can't rip any DA galleries, all get "null" as result

Expected Behavior
Download the images from a specific gallery
Actual Behavior
Downloading https://www.deviantart.com/reiq/gallery/7806055/fan-art
Rip complete, saved to C:\Users\userr\Documents\reiq\rips\rips\deviantart_reiq_gallery_fan-art
null

Can confirm.  Getting same issue on Windows 10.

Can also confirm, having issue on Mac.
It looks like it's having problems retrieving a token and key from DA's login. Debugged and got a null pointer exception at
String token = form.select("input[name=\"validate_token\"]").first().attr("value");
form is declared as
Element form = doc.getElementById("login");
Looking for an element with id "login" on DA login page is returning a null value.

Same issue.

Same issue here, also.

Same issue.

Please help. We need someway to login through the ripme to access deviantart ID.

What about copying the cookies string from your browser?
I had been doing that with my RipMe v1.5.2 fork for a long time, since I needed to be logged in to get mature content and downloads, but the Eclipse update broke it.

I confirm the same error is happening to me.


Compile error on GHC 8 (base 4.9.0)

It first gives:
Configuring testing-feat-<IP_ADDRESS>...
Setup: At least the following dependencies are missing:
base >=4.5 && <=4.9, template-haskell >=2.5 && <2.11

After removing version constraints, it gives:
Test/Feat/Internals/Derive.hs:22:35: error:
    • Ambiguous type variable ‘m0’ arising from a use of ‘return’
      prevents the constraint ‘(Monad m0)’ from being solved.
      Probable fix: use a type annotation to specify what ‘m0’ should be.
      These potential instances exist:
        instance Monad (Either e) -- Defined in ‘Data.Either’
        instance Monad IO -- Defined in ‘GHC.Base’
        instance Monad Q -- Defined in ‘Language.Haskell.TH.Syntax’
        ...plus four others
        ...plus 9 instance involving out-of-scope typess
        (use -fprint-potential-instances to see them all)
    • In the expression:
        return
        $ case i of {
            TyConI (DataD cxt _ tvbs cons _) -> (cxt, map tvbName tvbs, cons)
            TyConI (NewtypeD cxt _ tvbs con _)
              -> (cxt, map tvbName tvbs, [con])
            _ -> error $ "Unexpected info: " ++ show (ppr i) }
      In the second argument of ‘(>>=)’, namely
        ‘\ i
           -> return
              $ case i of {
                  TyConI (DataD cxt _ tvbs cons _) -> (cxt, map tvbName tvbs, cons)
                  TyConI (NewtypeD cxt _ tvbs con _)
                    -> (cxt, map tvbName tvbs, [...])
                  _ -> error $ "Unexpected info: " ++ show (ppr i) }’
      In the expression:
        reify n
        >>=
          \ i
            -> return
               $ case i of {
                   TyConI (DataD cxt _ tvbs cons _) -> (cxt, map tvbName tvbs, cons)
                   TyConI (NewtypeD cxt _ tvbs con _)
                     -> (cxt, map tvbName tvbs, [...])
                   _ -> error $ "Unexpected info: " ++ show (ppr i) }

Test/Feat/Internals/Derive.hs:23:11: error:
    • The constructor ‘DataD’ should have 6 arguments, but has been given 5
    • In the pattern: DataD cxt _ tvbs cons _
      In the pattern: TyConI (DataD cxt _ tvbs cons _)
      In a case alternative:
          TyConI (DataD cxt _ tvbs cons _) -> (cxt, map tvbName tvbs, cons)

My environment:
$ ghc-pkg list
/nix/store/50ah8wdi7mazc2pirq0xal31gz8rjmpk-ghc-<IP_ADDRESS>60111/lib/ghc-<IP_ADDRESS>60111/package.conf.d
    Cabal-<IP_ADDRESS>
    QuickCheck-2.8.2
    array-<IP_ADDRESS>
    base-<IP_ADDRESS>
    binary-<IP_ADDRESS>
    bytestring-<IP_ADDRESS>
    containers-<IP_ADDRESS>
    deepseq-<IP_ADDRESS>
    directory-<IP_ADDRESS>
    filepath-<IP_ADDRESS>
    ghc-<IP_ADDRESS>60111
    ghc-boot-<IP_ADDRESS>60111
    ghc-prim-<IP_ADDRESS>
    ghci-<IP_ADDRESS>60111
    haskeline-<IP_ADDRESS>
    hoopl-<IP_ADDRESS>
    hpc-<IP_ADDRESS>
    integer-gmp-<IP_ADDRESS>
    mtl-2.2.1
    pretty-<IP_ADDRESS>
    primitive-<IP_ADDRESS>
    process-<IP_ADDRESS>
    random-1.1
    rts-1.0
    tagshare-0.0
    template-haskell-<IP_ADDRESS>
    terminfo-<IP_ADDRESS>
    tf-random-0.5
    time-1.6
    transformers-<IP_ADDRESS>
    unix-<IP_ADDRESS>
    xhtml-3000.2.1

$ ghc --version
The Glorious Glasgow Haskell Compilation System, version <IP_ADDRESS>60111

GHC 8 will be released soon, so it'll be great if you can fix this (language-ecmascript depends on this library and therefore many other packages).

The fix is quite trivial. I made it against latest released version (<IP_ADDRESS>).
https://github.com/phadej/testing-feat/compare/phadej:c8937a2190c13747422c2632d6d02e0b93ee8f36...phadej:ghc-8.0.1

Thanks! I uploaded the fixed version to Hackage.

(this can be closed I think)


solve error: No versions of github.com/micro/consistent met constraints

Go: go version go1.7.5 linux/amd64

OS: Linux 4.4.0-59-generic #80-Ubuntu SMP Fri Jan 6 17:47:47 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux

What I did: dep init

What I expected to see: generated manifest and lock files

What I saw instead: solve error: No versions of github.com/micro/consistent met constraints

Full error output was as follows:
➜  foobar git:(master) ✗ dep init
Cached github.com/cenkalti/backoff
Cached github.com/stretchr/testify
Cached gopkg.in/Masterminds/squirrel.v1
...
Cached github.com/mitchellh/hashstructure
Cached github.com/coreos/etcd
Cached github.com/lann/builder
solve error: No versions of github.com/micro/consistent met constraints:
        master: Could not introduce github.com/micro/consistent@master, as its subpackage github.com/micro/consistent does not contain usable Go code (*gps.LocalImportsError).. (Package is required by github.com/micro/go-os@master.)No versions of github.com/micro/consistent met constraints:
        master: Could not introduce github.com/micro/consistent@master, as its subpackage github.com/micro/consistent does not contain usable Go code (*gps.LocalImportsError).. (Package is required by<EMAIL_ADDRESS>
As a test, go get github.com/micro/consistent seems to work just fine.

Thanks for the detailed report! I'll have a look at github.com/micro/consistent - we have to use a custom implementation of go/parser for our static analysis, and it's an ongoing project.

Oh, yeah - the problem is the relative import: https://github.com/micro/consistent/blob/master/example_test.go#L8
Short term: if that import is fixed to be github.com/micro/consistent instead of ../consistent, then it should be fine.
Longer term: Relative imports...well, they sorta work within the go toolchain now, but support can be spotty. We have a harder, more global analysis problem to do than the existing go toolchain does, and discounting things like relative imports makes it a fair bit easier.

I'm gonna call this a wontfix, feel free to reopen if you think that's the wrong call.

Roger, thanks!


runtime: repair windows build

Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.

Resolves SR-NNNN.

The header dlfcn.h does not exist for windows targets, guard the including.
Correct the structure initializers which had the members inverted.  Finally,
include the required vector header.

@swift-ci please smoke test and merge

Thanks! was about to submit this myself :)


chore: Add lurk shard test

Fixes #259
Also addresses the nit from https://github.com/argumentcomputer/loam/pull/260#discussion_r1735229332
This PR does not try to generate a CryptoProof from the MachineProof since the former is in a private module, and exposing it might expose too much as pub we might not want to expose yet. It's extra annoying since tests/fib.rs is technically a separate crate so it couldn't just be pub(crate).
I've manually tested the conversion in the REPL, and indeed when there are multiple shards, all the shards have the same public values and the CryptoProof conversion works fine.

Closing for now -- will revisit later


Getting started Guide: How to start?

Describe the bug
Following the guide
https://capacitor-community-electron-docs-site.vercel.app/getting-started
It says use the script electron:start
I don't know how do that? in the electron folder there is no script like that
I also tried every combination with npx cap without luck
How can I even start it?
To Reproduce
Steps to reproduce the behavior:
Following all steps in https://capacitor-community-electron-docs-site.vercel.app/getting-started
Dependencies
"dependencies": {
"@angular/common": "~10.0.0",
"@angular/core": "~10.0.0",
"@angular/forms": "~10.0.0",
"@angular/platform-browser": "~10.0.0",
"@angular/platform-browser-dynamic": "~10.0.0",
"@angular/router": "~10.0.0",
"@capacitor-community/electron": "^1.2.3",
"@capacitor/core": "2.4.0",
"@ionic-native/core": "^5.0.0",
"@ionic-native/splash-screen": "^5.0.0",
"@ionic-native/status-bar": "^5.0.0",
"@ionic/angular": "^5.0.0",
"@ionic/storage": "^2.3.0",
"electron": "^9.2.1",
"ngx-electron": "^2.2.0",
"rxjs": "~6.5.5",
"tslib": "^2.0.0",
"zone.js": "~0.10.3"
},
Expected behavior
Electron starting as with the old way npx cap open electron
Desktop (please complete the following information):

OS: Windows 10 x64
Browser Firefox, but irrelevant as it does not open
Version 79.0

npx cap open electron should function with the community version from your web app directory.

Seems as if it then starts the old version
npx cap open electron
[warn] The electron platform is deprecated!
How's that electron:start script supposed to be used mentioned in the getting started guide?
It's a bit frustrating if the "hello world example does not work"

npx cap open electron

This should work
npx cap open @capacitor-community/electron

How's that electron:start script supposed to be used mentioned in the getting started guide?
It's a bit frustrating if the "hello world example" does not work

If you cd into the electron folder then the electron start script will work
npm run electron:start

Thank you!
Would you please add that to the quick start guide?
I can confirm both works!

New github pages docs reflects these changes


Stop special-casing the (very unlikely) "no /XObject found"-scenario, when parsing OPS.paintXObject operators, in PartialEvaluator.{getOperatorList, getTextContent}

Originally there weren't any (generally) good ways to handle errors gracefully, on the worker-side, however that's no longer the case and we can simply fallback to the existing ignoreErrors functionality instead.
Also, please note that the "no /XObject found"-scenario should be extremely unlikely in practice and would only occur in corrupt/broken documents.
Note that the PartialEvaluator.getOperatorList case is especially bad currently, since we'll simply (attempt to) send the data as-is to the main-thread. This is quite bad, since in a corrupt/broken document the data could contain anything and e.g. be unclonable (which would cause breaking errors).
Also, we're (obviously) not attempting to do anything with this "raw" OPS.paintXObject data on the main-thread and simply ensuring that we never send it definately seems like the correct approach.

/botio test

Nice find!


The links to the sections under How to Contribute are not working

Description of the bug:

The links to the sections under the "How to Contribute page" are not working, those under the heading "Contributing Guidelines for Colib Documentation".
Link refer to french version - "testing-your-github-pages-site-locally-with-jekyll"

To Reproduce:
Open colib.net
Go to About -> How to Contribute
Click on links under the heading "Contributing Guidelines for Colib Documentation".
Expected Behavior:
It should point to the expected sections
Screenshot1:

Screenshot2:

Issue is fixed


Access to sort_value column value

Greetings, I am trying to use sorted to order some questions inside a quiz, so far I have these two models:
class Quiz(models.Models):
    text = models.CharField(max_length=255)
    questions = SortedManyToManyField("Question")

class Question(models.Model):
    text = models.CharField(max_length=255)
    .
    .
    .

In my views I need to get the sorted_value column value but its not accessible. Question object has not sorted_value property. I used to have a property called "order", I removed but the migration created kept the field. But when I reorder questions inside admin,  the value which is changed is sort_value. I need to access this sort_value.

Hi, I think sortedm2m is not the right choice for your scenario. It is meant as a transparent replacement to Django's ManyToManyField.
Is a Question specific to one Quiz? In that case, you should use a ForeignKey(Quiz) on the Question model and add a order field there.
If a question might be part of multiple quizzes, then you would create an intermediary model like this one:
class Quiz(models.Models):
    text = models.CharField(max_length=255)
    questions = SortedManyToManyField("Question", through="QuizQuestion")

class Question(models.Model):
    text = models.CharField(max_length=255)

class QuizQuestion(models.Model):
    quiz = models.ForeignKey(Quiz)
    question = models.ForeignKey(Question)
    order = models.IntegerField()
    class Meta:
        ordering = ('order',)

That way you have total access to the ordering field and how questions will be ordered in the frontend.

Thanks for your response.


Upgrade PatternFly packages to 2021.09 prerelease versions to pull in various fixes

Resolves #256 by pulling in https://github.com/patternfly/patternfly-react/pull/6041.
Resolves #553 by pulling in https://github.com/patternfly/patternfly-react/pull/5991.
This PR upgrades our PF packages to the current prerelease tagged versions because we need<EMAIL_ADDRESS>or later to get these fixes in. PatternFly's next stable release is the week of August 4th, which is just after our "blockers only" deadline for 2.1.0. So if we backport this for 2.1.0 we should upgrade PF packages again to latest before the release so that we resolve any regressions introduced by these prerelease versions.
Both the issues we're solving here are harmless console warnings, however. We may just want to leave this one on the main branch until 2.2.0. @seanforyou23 @gildub I'm open to your thoughts on that.

Opened https://github.com/konveyor/forklift-ui/issues/713 to track the fact that we're on prerelease PF after this is merged.

After discussing with @seanforyou23 , closing this for now. Will open another upgrade PR once these fixes are in stable PF (early August).


OCPBUGS-25754: Add Snyk file to exclude vendor directory on scan

Hello! This is a PR to add a snyk file to exclude the vendors folder while scanning the repo. Thanks!

/approve
/lgtm

/cherry-pick release-4.15


merge package template from Kronos-Tools/npm-package-template

package.json

chore(devDependencies): update<EMAIL_ADDRESS>from template
chore(devDependencies): add<EMAIL_ADDRESS>from template
chore(devDependencies): add<EMAIL_ADDRESS>from template
chore(npm): delete config
docs(package): remove keyword null

Codecov Report

Merging #294 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #294   +/-   ##
=======================================
  Coverage   89.59%   89.59%
=======================================
  Files           1        1
  Lines         221      221
=======================================
  Hits          198      198
  Misses         23       23

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b15058d...66797cd. Read the comment docs.


docs: Updated CONTRIBUTING.md by adding PR naming template #1167

Related Issue
Closes #1167

Description

Added steps on how to create a pull request and mentioned all the naming conventions.
Screenshots

Checklist

[x] My code adheres to the established style guidelines of the project.
[ ] I have included comments in areas that may be difficult to understand.
[x] My changes have not introduced any new warnings.
[x] I have conducted a self-review of my code.

Make the changes in a bullet-point format and also review the documentation to include potential tags that can be used in the title during the pull request (PR) submission.
For example:
fix: , feat: , docs: , test: , chore: , ci: , perf: , refactor: , revert: , style: , data:


Add Github package to CI listing

Description of the Change
Add GitHub package in build-status.md.

Thanks! If you don't mind capitalizing the "H" in "GitHub," then I'll merge this once the release is final.

@BinaryMuse I renamed Github into GitHub!

Thanks!


Release for submission flow phase 1 (milestone 29)

[x] git pull - make sure local repository is up to date
[x] Polish changelog.md - get changelog ready for release
[x] git push - commit and push updated changelog
[x] Ensure all tests pass in GitHub actions
[x] git tag -a [TAGNAME]
[x] git push origin [TAGNAME]
[x] Follow steps to create a release on GitHub
[x] Add Unreleased to changelog.md
[x] If this is a release branch (not main), merge changes into main
[x] git push
[x] Deploy to tracebase.princeton.edu

See NPLC Admin Docs:TraceBase:New Release for more details

ssh tracebase-dev
sudo -iu tracebase
cd /var/www/tracebase
git status
git fetch origin --tags
git checkout tags/v3.1.0-beta -b v3.1.0-beta-branch
source /usr/local/tracebase/bin/activate
python -m pip install -U pip
python -m pip install -r requirements.txt
python manage.py migrate
exit
sudo apachectl graceful
exit

ssh tracebase
sudo -iu tracebase
cd /var/www/tracebase
git status
git fetch origin --tags
git checkout tags/v3.1.0-beta -b v3.1.0-beta-branch
source /usr/local/tracebase/bin/activate
python -m pip install -U pip
python -m pip install -r requirements.txt
python manage.py migrate
exit
sudo apachectl graceful
exit

Deployed on both dev and prod.


LMU Support

You create a nice tool for rf2, now i miss it for LMU :)
Do you think your tool can support LMU for the future?

Hey, you can find LMU support here:
https://github.com/tappi287/lmu_settings_widget

oh sry. my bad. Thx for your work ;)


Empty logs sign wrong root hash

Per @AGWA on https://groups.google.com/a/chromium.org/g/ct-policy/c/v9JzlbphYBs/m/-blS5vMtAgAJ

Note that all cryptographic operations (such as hashes and signatures)
are as specified by RFC 6962, so these APIs can be thought of as an
alternative encoding format for the same data

at least 10 Sunlight logs have produced STHs with a tree size of 0 and an all-zero root hash, while RFC 6962 specifies that the root hash of an empty tree is the SHA-256 hash of an empty string.

@mcpherrinm, are you looking for help with this? If so, I see two approaches:

fixup the hash of an empty tree prior to calling signTreeHead
copy and patch the logic of tlog.TreeHash to handle empty trees

The second approach would also need to handle construction of a new log within ctlog.CreateLog, so it seems like the first approach is simpler.
Would a PR be helpful?

I had a chat with Russ, and we're going to change golang.org/x/mod/sumdb/tlog upstream, to avoid ecosystem fragmentation on this.


bigquery: Export booleans as "t"/"f"

Historically, we have allows databases some flexibility in how they
exported Boolean values. PostgreSQL preferred "t"/"f", but BigQuery used
"true"/"false". This was generally safe because most databases have
smart boolean parsing.
But BigML CSV import maps booleans to CATEGORICAL values, which are
strings that must match exactly. So we need to standardize booleans on
t/f everywhere.
This is a "quick fix" patch that relies on existing test cases to make
sure that everything works. We will also need to add new test cases to
ensure standardized representations of as many values as possible, and
strictly document our interchange CSV format. But that can wait.

should you be similarly explicit in the Postgres driver? (even though we know for now it exports as t/f...)

We should strictly specify the representations of important scalar types, including both bool and date types, but not necessarily floats (which are trickier because of rounding and scientific notation). And we should write explicit test cases that ensure every relevant backend can import/export these as exact byte sequences.

also, are we going to break bigquery->bigquery roundtrips?

This patch passes the full existing dbcrossbar test suite. BigQuery could already import PostgreSQL-style booleans and vice versa.
This is the "fix it now and rely on existing tests" version of this patch, not the "create a rigorous standardization with tests" version. We need the later. But this patch is theoretically OK because any backend was already allowed to export "t"/"f". We're just changing which "legal" representation PostgreSQL uses.


Added missing documentation

Fix for #163

@xqq Any chances this might get merged?

I'm sorry that I have missed the notification of this pull request.
Thanks for your work! There's still some mistakes so I will merge it and fix them.

Thanks

Thanks

Refined https://github.com/Bilibili/flv.js/commit/f0b3fec859a18c03f08e7888940c2b331fb67ffa


Poor deprecated messages - types should almost never be displayed.

/** @deprecated - this is bad advice */
declare function crossTheStreams(): void

crossTheStreams()

Expected: 'crossTheStreams' is deprecated.
Actual: '(): void' is deprecated
Notice the type in place of the entity name, notice the lack of a period at the end.

I assume this isn't as simple as using signature.declaration.name.escapedText?
Like, signature.declaration could be JSDocSignature.
How would you get the function name from a JSDocSignature?

This should normally happen only with overloads.

Only if not every overload is deprecated. If all overloads are deprecated, showing the type doesn't help.

I assume this isn't as simple as using signature.declaration.name.escapedText?

It is better to use one of the various helpers for printing out the expression when a name is available. We've done this in a couple of places where we try to special case this when the invoked expression is an identifier/property access.

tryGetPropertyAccessOrIdentifierToString is one

getCalledExpressionName is also similar, but is weird in that it'll give a partial result if the expression gets a bit too complex (e.g. foo().bar.baz will give you bar.baz).
Probably what you want is just to do something even more basic where you try grabbing the name.text off a property access, the text off an Identifier, and stop there. Not sure of any other helper functions that do this, but I'm sure this isn't the only place.

I see getNameOfDeclaration, too

The declaration name isn't always useful because it might be anonymous, it might come from a default import. The most relevant name for this error message is the one that is being used locally.
Something useful might be to provide a related span linking back to where the deprecation comes from.

I have no clue what I'm doing but I tried something like this,
        function checkDeprecatedSignature(signature: Signature, node: CallLikeExpression) {
            if (signature.declaration && signature.declaration.flags & NodeFlags.Deprecated) {
                const suggestionNode = getDeprecatedSuggestionNode(node);
                const deprecation = getJSDocDeprecatedTag(signature.declaration);
                if (deprecation == undefined) {
                    errorOrSuggestion(/*isError*/ false, suggestionNode, Diagnostics._0_is_deprecated, signatureToString(signature));
                } else {
                    const diagnostic = createDiagnosticForNode(
                        suggestionNode,
                        Diagnostics._0_is_deprecated,
                        signatureToString(signature) + "lol"
                    );
                    addRelatedInfo(
                        diagnostic,
                        createDiagnosticForNode(deprecation, Diagnostics.The_implementation_signature_is_declared_here)
                    );
                    suggestionDiagnostics.add({ ...diagnostic, category: DiagnosticCategory.Suggestion });
                }
            }
        }

And got something like this,

(I know it's the wrong diagnostic lol)

(I should remove the "lol"),

But it's so fun!
Yeah, I don't know what the code currently looks like, but on the node, you should be able to getInvokedExpression and get the text using any of the methods I described above.

I noticed this doesn't produce the deprecation notice.

I think I've got it down,

@DanielRosenwasser
Is it normal for Symbol.declarations to be a non-empty array but for valueDeclaration to be undefined?
I assumed valueDeclaration was just a shorthand for declarations[0].
This happens in tests/cases/fourslash/jsdocDeprecated_suggestion1.ts
Smaller repro,
//a.ts
/** @deprecated */
export function bar() {

}

/** @deprecated */
export type QW = 3;

//b.ts
import { bar, QW } from './a';

The import of bar is fine. It has valueDeclaration set.
However, QW has declarations.length == 1 but valueDeclaration == undefined.

It also seems like tryGetPropertyAccessOrIdentifierToString() doesn't like namespaces + optional chains.
In tests/cases/fourslash/jsdocDeprecated_suggestion1.ts,
the line containing foo?.[[|"faff"|]]?.() trips up tryGetPropertyAccessOrIdentifierToString().
Minimal repro,
export namespace foo {
    /** @deprecated */
    export function faff() { }
}

foo?.["faff"]?.();

If you replace the namespace with a variable, it works.

Is it normal for Symbol.declarations to be a non-empty array but for valueDeclaration to be undefined?
I assumed valueDeclaration was just a shorthand for declarations[0].

Basically, As the name of valueDeclaration, Only existed when some symbol could be an value

It trips me up, though, because I see it declared as type Declaration, not Declaration|undefined.

It also doesn't make sense for a symbol to exist without a declaration, in my head.

First value declaration means first declaration of value
You can also find all declarations in the declarations  field

I see I had the wrong idea of what valueDeclaration was. It's conditionally set.


chore(main): release 0.14.0

:robot: I have created a release beep boop
0.14.0 (2024-07-04)
✨ New Features

UX-1121: Added ZetaProvider.base to allow for better developer experience (#123) (3cc79b0)
ZetaIcon component added (#121) (3b2ddef)

📈 Documentation

Update widget book theme (#126) (8d9d429)

🧪 Tests

Added test for ZetaIcon (3b2ddef)
Update golden tests for rounded state change (3cc79b0)

🧹 Miscellaneous Chores

Add rounded switch to example app (3cc79b0)

This PR was generated with Release Please. See documentation.

Also merge this https://github.com/ZebraDevs/zeta_flutter_template/pull/1


request: support deploying "stacks" via docker compose

Loving now (and Next.js, too). Thanks for all of the hard work.

[x] I have searched the issues of this repository and believe that this is not a duplicate.

 However, it would be amazing if you supported deploying a whole "stack" for an app via a set of docker-compose.yml (and similar) files.
Any plans to support such a scenario? It would be pretty amazing to have all of the load balancing and DNS handled by the standard Now stuff without having to resort to something like DigitalOcean and `docker-machine.

Please add this!

This issue was moved to zeit/now-cli#763


"health_check" not suitable   map of string required.

HI,
I'm using a Udemy course that uses this module, but I'm getting an error  when I do a Terraform Plan ..could this just be a formatting error? I am quite new at this, could someone point me on the right direction please.....what kinds of things should I be thinking about when trying to troubleshoot this kind of thing?
"The given value is not suitable for child module variable "health_check" defined at .terraform/modules/elb_http/variables.tf:70,1-24: map of string required.
This is my terraform code that references  it
module "elb_http" {

  source = "github.com/terraform-aws-modules/terraform-aws-elb.git"

  name = "elb1"

  internal = "false"

  subnets = ["subnet-a4a922cc", "subnet-8dcf0cf7"]

  security_groups = ["sg-07b2fc6c"]

  listener = [

    {

      instance_port = "80"

      instance_protocol = "HTTP"

      lb_port = "80"

      lb_protocol = "HTTP"

    },

  ]

  health_check = [

    {

      target = "HTTP:80/"

      interval = 30

      healthy_threshold = 2

      unhealthy_threshold = 2

      timeout = 5

    },

  ]

}

This is the variable in the module
variable "health_check" {
  description = "A health check block"
  type        = map(string)
}

by the way, the vendor for this Udemy is not good at getting back to you

Hi @andrewrotherham !
I don't know which Udemy course you are talking about.
As a tip for the person learning Terraform AWS modules - always look into examples folder in this repository for the 100% working code.
The solution to your problem is shown there - https://github.com/terraform-aws-modules/terraform-aws-elb/blob/master/examples/complete/main.tf#L111-L117

great! works a treat, thanks for that Anton, will always look at examples folder going forward. I suppose [ and ] are only for lists


[diffae][dataset not implemented error!]

Dear authors,
I have found that I met problem with diffae in executing python create_dataset.py --image_dir ./test_images/aligned_images/valid/ --out_dataset_dir ./test_images/ --shadow
The code snippet is

The error is, I guess may be your change some code of diffae, maybe you can upload the new diffae repo here so as to run the repo.
  File "/mnt/workspace/2023AW/11/relight/difareli_code/preprocess_scripts/Relighting_preprocessing_tools/diffae/experiment.py", line 182, in setup
    self.train_data = self.conf.make_dataset()
  File "/mnt/workspace/2023AW/11/relight/difareli_code/preprocess_scripts/Relighting_preprocessing_tools/diffae/config.py", line 311, in make_dataset
    raise NotImplementedError()

Maybe the config.py needed change?

Thank you very much.

have the same issue

have the same issue,too many errors in this repo

I replace
raise NotImplementedError()

with
return ImageDataset(
                folder=path or self.shadow_input_path,
                image_size=self.img_size,
                exts=['png'],
                **kwargs
            )

And it works.


Add Jack Lange to Contributors list

I'm quite elated about your pull request. I wanna evolve this project to addresses various problems faced by first-time contributors. I'd love to learn about your journey in open source community, the problems, pain points you had etc.
Could you explain how you felt when you went through the tutorial, made a pull request and learned that I merged it?
We’ve recently added Facebook share and tweet feature to our web app. Could you please go to https://roshanjossey.github.io/first-contributions/#social-share and share your first contribution to open source?
Also, check out projects with easy issues while you’re there.

The README in this repo was excellent. I had prior experience using git, but only for my own projects, never in collaboration. Thank you so much for such an excellent resource.

I’d urge you to continue contributing to other open source projects.
We also have a slack team to help/mentor people trying to contribute to open source projects.
You can join the team by going to https://goo.gl/PM1Jdh
Please share a link to your pull request in the slack group. That'll inspire everybody there


Add degree to radian conversion routines to Math

This issue was originally filed by<EMAIL_ADDRESS>
Math already has PI as a constant, it would be trivial to add some utility methods to convert between degrees and radians.
static num degToRad(num deg) => deg * (Math.PI / 180.0);
static num radToDeg(num rad) => rad * (180.0 / Math.PI);

Degrees are used by many developers to visualise and work with angular values. I believe to include a library to two additional "helper" functions that are expected by most developers seems a bit ridiculous. The other point here is that most trigonometric libraries include this functionality (including android). Important point if we consider we'd like developers to port their libraries to Dart and Flutter.
I'd like to propose that this ticket is reopened and the additions made. I am happy to PR them.

I don't know why such helpful methods haven't added yet, it just a bit of code.

how is this not just in the package


Migrate Windows JDK builds to Windows Server 2022

All, in order to begin the move away from Windows 2012 server for building JDKs, as 2012 is out of support in the near future, Im proposing to undertake a migration of the build processes to Windows Server 2022.
The current state of the builds/platforms is as follows:
JDK20 / JDK21 - Build On Windows Server 2022
JDK17 / JDK11 / JDK8 - Build On Windows Server 2012
Im currently proposing to move each of the 3 JDKs currently building on Windows Server 2012 to build on Windows Server 2022.
For each JDK version, I'll update the Jenkins config, perform a build on the new platform, and then run some test suites to ensure there are no issues before making these changes permanently.
I believe additional work may be required to move JDK8 to build on Windows Server 2022, but the above process should highlight any issues.
Once complete, I'll decommission some of the redundant build infrastructure from Jenkins etc as required.
Current Status:

Version
Arch
Build
Test
Pipeline
Status

17
x86_64
:heavy_check_mark:
:heavy_check_mark:
:hourglass_flowing_sand:
:hourglass_flowing_sand:

17
x86_32
:heavy_check_mark:
:heavy_check_mark:
:hourglass_flowing_sand:
:hourglass_flowing_sand:

11
x86_64
:heavy_check_mark:
:heavy_check_mark:
:hourglass_flowing_sand:
:hourglass_flowing_sand:

11
x86_32
:heavy_check_mark:
:heavy_check_mark:
:hourglass_flowing_sand:
:hourglass_flowing_sand:

8
x86_64
:heavy_check_mark:
:hourglass_flowing_sand:

:hourglass_flowing_sand:

8
x86_32
:heavy_check_mark:
:heavy_check_mark:
:hourglass_flowing_sand:
:hourglass_flowing_sand:

JDK8(32bit) single test failure
15- jdk_security4_2   outputFailed test cases: TEST: sun/security/krb5/auto/Unreachable.java Test results: passed: 133; error: 1

PR merged, message posted in slack/build channel.


Update .prettierrc

window环境，代码拉下来报警告
Delete ␍eslint

[x] I am sure that the code is update-to-date with the dev branch.

close #

Thanks for your pull request.
We have already fixed this prettier issue, please confirm that you have synchronized the latest upstream code.
https://github.com/dream-num/univer/blob/dev/.prettierrc#L7


Update Rabbitmq Multi-Handling

When using multiple connections, a timeout in one should not affect the sending of heartbeats in the others -- this is solved by using multiple channels instead.

It is getting a bit complex and hard to read though, and I wonder how much #56 would make this simpler. I guess that's for another time.

This is plan B


Insertion Sort in Python

Python program for implementation of Insertion Sort

create python folder in the SORTING folder then send the pr

create python folder in the SORTING folder then send the pr

Done Kindly Check.

great


how to remove sort option for selected items onload

when user selected some items that should be in user selected order only that is my requirement. but while saving items it is in user selected order but when selected items are loaded it is getting sorted which is not my requirement
eg: total items A,B,C,D,E
user selected order : B, E,C,A
onload selected list : A,B,C,E (which is not my requirement).
can any one help in this issue.

I have same issue.  The order of list appear only by alphabetic name asc..

I have same issue , items selected loaded with default order.
can any one help in this issue.

I have same issue , items selected loaded with default order.
can any one help in this issue.


New navigation

Fix #270 - add nearest widget navigation.

Coverage decreased (-0.2%) to 97.178% when pulling ad735bbf24a56cf15fad37829d24cf445825f98d on new_navigation into 5c322d4ad81c88cdcbb416571510b6c522bd8ecb on master.