Inconsistency between outputs from the same source code

Describe the bug
I have some weird inconsistency between the code I execute inside my application and the code I just type in chrome dev tools (within momentjs website)
The following code:
moment('1989-01-15').locale('pt-br').format('L')
gives me this output when I put into the console
output:
15/01/1989
which is exactly what I expect
But now here comes the magic, when I try to execute the same code inside CRA I have a different result.
output:
01/15/1989
To Reproduce
Steps to reproduce the behavior:

Create an app with create-react-app
Install momentjs
console.log this line of code moment('1989-01-15').locale('pt-br').format('L')'
Check the output

Expected behavior
My output to be in 'DD/MM/YYYY' format which for the current value is 01/15/1989
Screenshots
output from console

output from create react app

Desktop (please complete the following information):

OS: [Mac High Sierra ]
Browser [chrome]
Version [10.13.6]

Moment-specific environment
2.24.0
Please run the following code in your environment and include the output:
console.log((new Date()).toString())
Mon Apr 22 2019 10:55:58 GMT-0300 (Horário Padrão de Brasília)
console.log((new Date()).toLocaleString())
22/04/2019 10:55:58
console.log((new Date()).getTimezoneOffset())
180
console.log(navigator.userAgent)
Mozilla/5.0 (Macintosh; Intel Mac OS X 10_13_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/72.0.3626.121 Safari/537.36
console.log(moment.version)
moment doen't get exposed to the global context in a react app

This is probably caused by the webpack config excluding moment locales

Please re-open if you still have issues.


Remove arguments on run-ios/run-android commands

These information are already available (or can be inferred). Remove them to make the command simpler.

[ ] ios
[ ] andorid

run-ios/run-android will be getting some other command line arguments (build type: dev/prod and communication method) so better remove unnecessary ones soon.

Removed these commands on v2 as we can use react-native run-ios directly


Configure OTEL Collector to observe Internal Telemetry

Which problem is this PR solving?
This PR addresses a part of the issue #5633
Description of the changes
This is a Draft PR to achieve Observability Parity between V1 and V2 components by configuring OTEL Collector config files to initialise internal tracer and metrics
How was this change tested?
The changes were tested by running the following command:
make test

CI actions

Checklist

[x] I have read CONTRIBUTING_GUIDELINES.md
[x] I have signed all commits
[x] I have added unit tests for the new functionality
[x] I have run lint and test steps successfully

for jaeger: make lint test
for jaeger-ui: yarn lint and yarn test

The changes were tested by running the following command:
make test

How does doing that demonstrate that the changes result in desired behavior?

The changes were tested by running the following command:
make test

How does doing that demonstrate that the changes result in desired behavior?

It dosen't, just created a PR to check for github actions

@yurishkuro I think I have configured the tracer successfully as now when I am passing telset.TracerProvider instead of jTracer, the tests aren't failing anymore.

Can you provide evidence that the changes are working? Just passing CI only means it didn't break things, but we don't explicitly test for internally generated traces (we should , it would be a good e2e test, e.g. as part of all-in-one e2e we could check that the internal traces are generated for API queries)

Can you provide evidence that the changes are working? Just passing CI only means it didn't break things, but we don't explicitly test for internally generated traces (we should , it would be a good e2e test, e.g. as part of all-in-one e2e we could check that the internal traces are generated for API queries)

When I had configured telset with OTEL.TracerProvider instead of JTracer without any changes in configuration of yaml file the all-in-one V2 test getAPITrace fails because I think a no-op tracer is being provided but after the changes in the configuration file the test seems to be passing.
Apart from that I have no POC

@yurishkuro, as evident in the image attached below.
Port :8888 is also emitting all the same query metrics as V1 mentioned in the doc now 🥳

@Wise-Wizard a screenshot is good as anecdotal evidence, but we need to be more rigorous than that. Jaeger has a lot of different metrics, we cannot validate parity by eyeballing screenshots, we need a scripted diffing solution.

i have compared the metrics names emitted by Jaeger Query ... All of them are emitted in V2 scope as well.

How did you compare them all?

i have compared the metrics names emitted by Jaeger Query ... All of them are emitted in V2 scope as well.

How did you compare them all?

I just compared the names of the metrics side by side.
The difference is in the number of operations per metric name.

I just compared the names of the metrics side by side.

Can we use something like this instead? https://github.com/prometheus/prom2json
I would like to have scripted diffs, not just eyeballing verification.

I just compared the names of the metrics side by side.

Can we use something like this instead? https://github.com/prometheus/prom2json I would like to have scripted diffs, not just eyeballing verification.
Hi, I have created a tmp folder and added JSON file for each using prom2Json, PTAL at it and suggest the changes you need.
After that I can delete the folder and store the JSON locally to use it later for the migration guide.

I just compared the names of the metrics side by side.

Can we use something like this instead? https://github.com/prometheus/prom2json I would like to have scripted diffs, not just eyeballing verification.

Hi, I have created a tmp folder and added JSON file for each using prom2Json, PTAL at it and suggest the changes you need.
After that I can delete the folder and store the JSON locally to use it later for the migration guide.

We don't need to see the actual json files, but their diffs. Any thoughts on how to compare them? We don't care about the values, only names and labels. There are probably json diffing tools.

We don't need to see the actual json files, but their diffs. Any thoughts on how to compare them? We don't care about the values, only names and labels. There are probably json diffing tools.

Ok, will research about that and look for some tool to see the differences.
BY differences you also mean the jaeger_collector and jaeger_agent metrics names to be included right?

Hi, so I wrote a Python script to read the difference in metrics names in both the files and written the differences in names in difference.json file for comparison.
Please do take a look at the file.

Will do the changes

make sure to get the CI green, you have unit test failures, and I see new linter failures

make sure to get the CI green, you have unit test failures, and I see new linter failures

Done.


fs: add --ignore-case-sync for forced case insensitivity - fixes #2773

What is the purpose of this change?
This change adds the ability to prevent the clone/sync of duplicate files for which only the casings differs, regardless if the source/target file-systems have case-sensitive filesystems (e.g. most/all linux systems)
e.g. files "Application A.doc" and "application a.doc" are now treated as the same file if the flag is set.
Was the change discussed in an issue or in the forum before?
Issue link: https://github.com/ncw/rclone/issues/2773
Forum link: https://forum.rclone.org/t/copy-sync-how-to-ignore-casing-when-checking-for-duplicates/7715
Checklist

[X ] I have read the contribution guidelines.
[X ] I have added tests for all changes in this PR if appropriate.
[X ] I have added documentation for the changes if appropriate.

[X ] I'm done, this Pull Request is ready for review :-)

The code looks really good - thank you :-)
Can you have a go at writing a test?
I'd start with a test like this
https://github.com/ncw/rclone/blob/cff85f0b9551881be535a4847b56742451e6b476/fs/sync/sync_test.go#L1317
Create two files  with different cases one in local and one in remote and check the sync does what you expect with the flag set.

That looks great now - thank you.
I'll merge.
(Apologies for the slow turnaround!)


Appears differently locally and online

Hello. First of I would like to thank you for your awesome work. I am not a developer but I am in the process of learning. I noticed that the effects seem to be different when viewed locally, compared to the uploaded file.
The scripts I have included are as follows:

I also tried to change the values of dropRadius and perturbance in the jquery.ripples.js file but it doesn't seem to work when I upload the html file to my ftp server.  The changes take effect only when viewed locally.
Not even sure what to look for ㅠ.ㅠ
Thanks in advance!

It's just a guess, but have you made sure jquery.ripples.js is at the right place or that js/jquery.ripples.js is the correct path? You can open up your developer tools, open the "Network" tab, and see if the file actually loads correctly.

Yes it is loading correctly. I have the same structure both locally and on my ftp server and I get no errors when loading the script.

Ok, so I am kinda surprised that it does work locally but not remotely - usually it's the other way around... You don't get any errors in the console about disallowed access to images?
Can I test this out myself somewhere? Or maybe a minimal working example?

As a matter of fact I do get an error like that when I open the HTML file locally. My teacher said is probably irrelevant and I should ignore it. I guess that's not the case then... I do not get the error on the uploaded file though.
This is the error:
Access to Image at 'file:///E:/Projects/1004%20designs/img/bgimg.jpg' from origin 'null' has been blocked by CORS policy: Invalid response. Origin 'null' is therefore not allowed access.
I've assigned the background in my CSS file and not in HTML. Could that be a problem?
#wrapper{
position:relative;
width:100%;
height:100vh;
background:url(../img/bgimg.jpg) no-repeat center bottom;
background-size:cover;
}
The effect I am trying to do is the one that I see locally. Could you please advise me on how to resolve this issue or what I should be looking for?
Sorry for all the hassle...

Ok so I tried reading a bit about CORS before bugging you again and I replaced the local img file with the uploaded file as some people on stachoverflow suggested but I still get a similar error.
"Access to Image at 'http://hi5hli5ht.dothome.co.kr/img/bgimg.jpg' from origin 'null' has been blocked by CORS policy: No 'Access-Control-Allow-Origin' header is present on the requested resource. Origin 'null' is therefore not allowed access."
So basically you can check the site from http://hi5hli5ht.dothome.co.kr
The effect I am trying to go for is the one I see locally. A very subtle effect compared to the one that I see when I access the website from the URL. And whether I change the values of dropRadius and perturbance and re-upload the files (i even delete it from the ftp first and re-upload it instead of overwriting, just in case) the changes are not visible. (I reset the values now to the original ones)

Ah I get it now. The "broken" behaviour is what you want online.
Setting perturbance to 0 should give you a similar effect to what you get locally. Alternatively you can apply the effect to an element without background-image set. Like in your specific case you can add an extra element to
, and apply the effect to that element.
Something like this:

I have to admit I didn't try setting the value to 0 as I thought it would completely disable the effect. It looks much better now. Thanks a lot for your time and for all your hard work to make this plugin and reply to questions here^^


The connection has timed out

After #29 was resolved and I was able to install things I still haven't been able to actually get the UI working.
When I click the link to open the local IP address I get The connection has timed out. This happens both locally on my mac (with docker) and in gitpod (without docker).
I don't see any error messages.
Any pointers on debugging?
If you want to try in gitpod you can at https://gitpod.io/?editor=code#https://github.com/hayabhay/whisper-ui
Just make sure to install ffmpeg

On Gitpod I tried it and it ran fine.
Since it already spins up a container (and looks like it also installs packages from requirements.txt), I simply ran streamlit run app/01_🏠_Home.py and downloaded a video from YouTube.
(python version was 3.8)
If you got a connection timed out error, it could very likely be network issues during that time. Or, the video may have been too long. Do you know how long it was?

Closing this since it couldn't be reproduced. Feel free to re-open if things change.

confirmed it's working now


Support for 'events' and 'service checks' (DataDog statsd extension)

PR for #12
I hope it's welcome!

Could it be updated and merged? Events part is especially interesting for me.


fix: do not rename files on mmap failure

If NewTSMReader() fails because mmap fails, do not
rename the file, because the error is probably
caused by vm.max_map_count being too low
closes https://github.com/influxdata/influxdb/issues/23172

[X] Well-formatted commit messages
[X] Rebased/mergeable
[X] Tests pass

Looks like a good approach. Can we add a test for it somehow? Maybe dependency-inject a poisoned mmap implementation?


Help text: remove outdated information, fix spelling

The current help text (cheat.sh/:help) states that the supported programming languages are Go, Scala, Rust, Python, and PHP. This is a bit misleading as many more are supported, such as Haskell and Ruby. I think it's best to remove this paragraph, instead of exhaustively listing supported programming languages, as the list can easily become outdated and can already be found via cheat.sh/:list, but of course opinions are welcome.
Also fixes a capitalisation and spelling mistake.

There are still failing tests, but they are for files I did not edit, and seem to be the same as those failing on the latest commit to master (01e579176981356fb90d4aa58fea2d6c273a45a5).

Yes. Tests are actually using live cheatcheets, and when cheatsheet content or highlighting change, they may fail. There is also some problem with inconsistent behavior of ANSI highlighting module. It gives different codes for some reason.

Thank you for the changes @thezeroalpha and yes @abitrolly, the failures have nothing to do with your changes.


Box 4 Camera Settings do not retain themselves

Box 4 of our PC's does not keep camera settings when you manually update them. Error log below appeared once, but not consistently (even though error is consistent over multiple attempts). Camera settings revert to a over-exposed default where flies cannot be tracked well
error_log_box4_02_09_24.txt

*update, upon restarting margo, camera settings now retain manual adjustment.
am keeping this post in case error_log is useful for other issues per Box 4, since still cannot get adequate tracking on flies

I'm wondering if the camera got disconnected here. Margo doesn't really save the camera's settings. It reads the current values off of the camera when it boots up. Margo doesn't do much but write new property values to the camera if you ask it to. If the camera's settings are changed somehow (e.g. the camera loses connectivity and resets, windows re-detects the device, or the settings are changed elsewhere), Margo doesn't have much insight into that. That being said, I'm again seeing:
Error using undistortImage>parseInputs (line 112)
Expected Image to be nonempty.

That makes me suspicious that the camera is dropping frames or losing connectivity.


New utilities & docs - fade out, hover grow, border white fade, responsive positioning, and circle

This PR adds the following styles and corresponding docs to Primer:
Fade out animation
This is in github/github but not in Primer nor was it documented. (this will close https://github.com/github/design-systems/issues/424)
Hover-grow animation
This is a pattern used in many places, for example on Explore spotlights, our customers page, and even on our style guide homepage. Since it's used on so many different types of projects, I decided to put it in core utilties vs. marketing.
border-white-fade
Similar to border-black-fade, but to be used on dark backgrounds. I needed this on these video pages and it could also be used on marketing sites with dark backgrounds or components, such as the partner site.
Responsive Positioning
This is something I have needed on a few projects and added as custom CSS in github/github. For now I am leaving this in marketing only, but as we move forward with more responsive stuff in product we may want to move it over.
(note: I have never needed position-static, let alone a responsive version of it, so I left it out to prevent unnecessary CSS. Any objections to this or should responsive styles always have full parity with their non-responsive counterparts?)
.circle
Which adds a border-radius of 50%. This was brought up in this issue, and is needed in both marketing and product.
/cc @primer/ds-core

@sophshep I pulled this down and I don't want to publish storybook like this with all the garbled stories titles in the nav, and having everything under utilities makes it hard to navigate as well as super long. Did you and @shawnbot discuss any options for fixing this up? I can help with this next week if needed but wanted to check what you'd discussed first.

Did you and @shawnbot discuss any options for fixing this up? I can help with this next week if needed but wanted to check what you'd discussed first.

No, we didn't. I used the story mainly to test the components I wrote for the docs. Could we remove it from this PR and then fix separately when adding stories to all the other styles?

@broccolini I've updated storybook to manually add the new styles that are in this PR.


Software Requirements Specification

The SRS Document needs the following in it for demo 1
• Functional requirements
• Service Contracts
• Class diagram
• Quality requirements
• Trace-ability matrix


Postal code- draft

The field- postal code is blank. The error message should be as on this pic

ok


Could not be loaded because it contains native modules that were compiled for an earlier version of Atom

Same issue?
After updating Atom to 1.12.0, terminal window doesn't load, just has the blinking cursor with no prompt.
Tried rebuilding the package through Atom's UI and tried reinstalling terminal-plus.
No change in behaviour.
Atom 1.12.0
terminal-plus 0.14.5
macOS Sierra 10.12.1
Full error from the console:
 /Applications/Atom.app/Contents/Resources/app.asar/src/task.js:52 Module version mismatch. Expected 49, got 46. Error: Module version mismatch. Expected 49, got 46.
    at Error (native)
    at process.module.(anonymous function) [as dlopen] (ELECTRON_ASAR.js:168:20)
    at Object.Module._extensions..node (module.js:568:18)
    at Object.module.(anonymous function) [as .node] (ELECTRON_ASAR.js:168:20)
    at Module.load (module.js:458:32)
    at tryModuleLoad (module.js:417:12)
    at Function.Module._load (module.js:409:3)
    at Module.require (module.js:468:17)
    at require (internal/module.js:20:19)
    at Object.<anonymous> (/Users/udyux/.atom/packages/terminal-plus/node_modules/pty.js/lib/pty.js:17:9)
    at Module._compile (module.js:541:32)
    at Object.value [as .js] (/Applications/Atom.app/Contents/Resources/app.asar/src/compile-cache.js:201:21)
    at Module.load (module.js:458:32)
    at tryModuleLoad (module.js:417:12)
    at Function.Module._load (module.js:409:3)
    at Module.require (module.js:468:17)
    at require (internal/module.js:20:19)
    at Object.<anonymous> (/Users/udyux/.atom/packages/terminal-plus/node_modules/pty.js/index.js:2:18)
    at Module._compile (module.js:541:32)
    at Object.value [as .js] (/Applications/Atom.app/Contents/Resources/app.asar/src/compile-cache.js:201:21)
    at Module.load (module.js:458:32)
    at tryModuleLoad (module.js:417:12)
    at Function.Module._load (module.js:409:3)
    at Module.require (module.js:468:17)
    at require (internal/module.js:20:19)
    at Object.<anonymous> (/Users/udyux/.atom/packages/terminal-plus/lib/process.coffee:1:7)
    at Object.<anonymous> (/Users/udyux/.atom/packages/terminal-plus/lib/process.coffee:1:1)
    at Module._compile (module.js:541:32)
    at Object.value [as .coffee] (/Applications/Atom.app/Contents/Resources/app.asar/src/compile-cache.js:201:21)
    at Module.load (module.js:458:32)

This is affecting a lot of us... #367 #366 #365 #362 #361 #359 #357 #353 #352 #351
Until the developers get this fixed, there are some alternatives:
termination (shameless self-promotion) :wink:
tokamak-terminal
platformio-ide-terminal

After Atom Update 1.12.0, Just a blinking caret , does not show command prompt / directory location #383

Uninstall terminal-plus
apm install LarsKumbier/terminal-plus
Terminal's background-color  fix setting background-color: transparent; in standard.less (on Mac it's usually in ~/.atom/packages/terminal-plus/styles/themes/)
No idea if this works for Windows.


Failure to deploy production optimized build

I'm struggling to deploy even the free version of this template. I wanted to experiment with the free version before I purchased the Pro version, but I'm stuck on the free version so far :(
Here are the steps:

Download the template, unzip folder
Run npm install
Run npm start --> everything works fine
Run npm run build. This creates a build folder.
Deploy build folder to Firebase Hosting.
When I navigate to the URL I deployed to, I see the following error:

Uncaught SyntaxError: Unexpected token <: main.2eeed198.js:1 What's weird is that the linked JS
file is not a JS file but actually an HTML file. Any idea how to fix it? I haven't made any modifications, this is all on the basic template!

Hello @ismail-a-khan ,
Our team has not worked yet with firebase, we've only worked with github pages and heroku.
I've done some quick search on the internet and found numerous tutorials on how to deploy react app to firebase.
From my previous searches (searches product related), i've seen that tutorials from medium.com usually are good to follow, so i'm going to give you a tutorial from medium (once again, there are a lot of other tutorials):

medium tutorial
(the firebase stuff is right at the end (search for "woo , almost") and start reading from there.

Because today is Sunday, i am not at my desk to verify if this would work, so i'm going to wait for your response to see if everything works now.
Best, Manu.

Hi Manu,
Actually, I am having the same problem trying to deploy the free version of material dashboard on heroku, so if you know of a tutorial that can help me through it since your team has done it, I would appreciate it.  I have reached out to Heroku but they said this was an app issue and they cannot help.
Here's what I did, I cloned the material-dashboard free app from github
npm install
npm start //and it opens the app in the browser correctly.
heroku login credentials
heroku create // to prepare heroku space for the app
git add .
git commit
git push heroku master
heroku open
then it does open up the browser with the appname.herokuapp.com, and shows the ico file on the tab but the content window is blank, no app see.
Any idea where I went wrong? or if you know of a tutorial for me to follow, I'd appreciate it.
Danh Nguyen


Handle API errors properly.

After starting to remove the alerts and use the suggested window.onunhandledrejection, I actually reverted and suggest to tackle this later (and keep #136 open for this purpose). My goal in this PR was to

Raise errors on API errors (fetch doesn't do so)
Inform the user about those API errors which prevent the UI from functioning properly while recovering from the other ones.

I think that this is achieved by the PR and it's an improvement over what we've had before. Now I totally agree that there is more to be done about error handling in general than what's done here (

Replace alerts by a more subtle "Sorry, something went wrong page"
Make sure no errors go unnoticed by using window.onunhandledrejection at the top level of the application.
Looking into/implementing react error boundaries (https://reactjs.org/blog/2017/07/26/error-handling-in-react-16.html)
...

Yet I would prefer to tackle this later, also because this PR is holding back the other ones which depend on it.


Use LuxButton in more places

https://github.com/glow-xyz/nftoken/blob/8772abbee2117feba187696ade16d7ec87798767/docs/pages/index.tsx#L123-L129
Is there a better way of making <LuxButton /> large on desktop but small on mobile? This feels a bit hacky.

Is there a better way of making  large on desktop but small on mobile? This feels a bit hacky.

Unfortunately not

I tried testing the buttons here: https://nftoken-git-lux-button.luma-dev.com/
Let's make sure to test changes before deploying them, especially since this website is now live.

Oh no! I shot myself in the foot while moving over LuxButton. I need to bring over LuxLink which requires ExternalLink and ComponentsOverridesContext, which feels like it could be too much to bring over at the moment (especially introducing the context provider). Where do you think we should draw the line?

I think we don't want to bring over ComponentsOverridesContext but we can bring over LuxLink — does that work?

Looks like useComponentsOverrides provides Link and HOST. Would it make sense to stub useComponentsOverrides for now so it just returns Link from next/link and https://nftoken.so?

I don't think we should stub it, I think we should just put in Link and https://nftoken.so inline

I went through and tested, and all links should be working now!


add raw compability with react-native-windows

Libraries like react-native-canvas rely on react-native-webview to export the WebView. Unfortunalty for react-native-windows this won't work as an internal import can't be resolved.
This PR resolves the WebView to the original WebView provided with react-native-windows in order to give some compability which seem better to me than no compability :)
I saw this comment in the contribution guide: If you want to add another React Native platform to this repository, you will need to create another .flowconfig for it. Although I value testing things, I don't think it makes much sense to cover a pure export/import.

🤔 Removing .windows part would also fix basic compatibility (compile-time) with react-native-web 🙃

@sjchmiela that's smart. Might do it 😁

Yes, on the other hand I wanted to avoid problems with platforms that are not yet covered and do not have WebView exported. This in mind, would you also suggest to remove the file suffix?

Well importing something that does not exist should not crash, it would just be null right?

You're right. Will adjust this PR.

Because of the TS rewrite, I directly included this in my PR so you don't fight against merge conflicts


Fixup bookinfo trustdomain tests

The bookinfo-trustdomain tests are not completing and just hanging in the presubmit tests. Since it was marked as required, it was causing PRs to fail. We changed it to be non-required.
As a policy, all tests should run in the presubmit system for at least one week before being marked as required. This should give us a sense of its stability.
In addition, it needs to be registered with testgrid so that we can monitor its health:
https://k8s-testgrid.appspot.com/istio-presubmits.
This bug is to track:

Registration with TestGrid
Re-enabling it as required in the presubmit queue (after observation).

@c0d1ngm0nk3y, I am assigning this to you since it looks like you made a PR to enable this in test-infra. Please reassign if there is a better person that should handle this.

@ozevren I'm filling in, because @c0d1ngm0nk3y is out for a week.
I created a PR to register the new test with testgrid, it would be great if you could review it.

The test is now visible in  testgrid.

@wattli, @liminw I assume this falls in your area. Can you comment on where this test should land? If this needs to be a required presubmit gate, please follow up with the TOC.

@wattli @liminw please comment. Otherwise, I'll go ahead and close this bug.

This has been passing in presubmit for a while, only action left is to enable is as required

Or move to post-submit (or get it removed).
@c0d1ngm0nk3y will you be able to shepherd this?

@ozevren We discussed this within the team and we think post-submit should be fine. What do you think? Should we open a PR to move it?

post-submit sounds good.


Ensure that both min and max are updated

In the current implementation, there was a possibility that only min would be updated for rect coordinates and max would remain an incorrect -f64::MAX.
The above problem was solved by using if instead of else if.

Agree that it's good to have this version in general api
But for performance purpose I will do a duplicate of this version with unsafe prefix and will manualy preinit rect with empty or single point

@NailxSharipov  Thanks for merging the PR!
From what I understand, it appears that max is not updated when the x or y coordinates of the points in the path are monotonically decreasing, not just when the points in the path are less than 2 points.
For example, an array path like [(10.0, 0.0), (9.0, 10.0), (8.0, 10.0), (7.0, 0.0)] will never update max_x because the x coordinate is a monotonically decreasing sequence and in this case always satisfies self.min_x > point.x.
Therefore, I believe that the addition of the first point must update both min and max even if it is made unsafe.

Yes, you are correct.
But if we take a first point from a path and init rect with it, like:
let p0 = path[0];
let mut rect = Rect {min_x: p0.x, max_x: p0.x, min_y: p0.y, max_y: p0.y};

after it old implementation must work correct.


Improving widgets for take/drop

Pull Request Description
Related to #6410
Important Notes

Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:

[ ] The documentation has been updated, if necessary.
[ ] Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
[ ] All code follows the
Scala,
Java,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
All code has been tested:

[ ] Unit tests have been written where possible.
[ ] If GUI codebase was changed, the GUI was tested when built using ./run ide build.

Widget shows what the default values will be:

If no value is provided and no default - a more friendly error is displayed:

Updated after discussion:

Got the widgets on Text working as well:

btw. the default visualization for empty text is just empty square box - that is a bit confusing - looks as if the visualization has failed.

Added Range:

I used the defaults from Range.new definition.

I needed parent_type (now declaring_type) to be able to easily check if a provided constructor is associated with one of expected types (when we add a more helpful error message) or not (where we just throw type error).

Is declaring_type the goal or is "more helpful error message" when "throw(ing) type error" the goal? If the latter, shouldn't it rather be addressed by #6682 than extending Meta capabilities?


Bug: Duplicate field in display

I have three fileClasses which are transitive.  There is "base"

The second is "statuBase" (which is based on "base")

And there is "video" (which is based on "statusBase")

If I look at a video file properties, I see:

Note that there are two fileclass properties displayed.  I assume there should only be one.

Is the fileClass: video line duplicated in your frontmatter?

do you have a global fileClass defined with a "fileclass" field set in it?

I think the answer is no:

Ok then it's pure inheritance between classes. I'll add a setting to toggle "auto add fileclass in modal" that will hide this extra field if toggle off.
WDYT?

I think that would work.  The reason I explicitly add the fileclass field
is so I can have a list of the fileClasses in my vault to choose from.
I didn't realize that it was being automatically added.  If it creates a
selection list from the fileclass folder, then I'm happy just to eliminate
it from my fileclasses and let you do it automatically.
On Sat, Nov 25, 2023 at 12:08 PM mathieu @.***> wrote:

Ok then it's pure inheritance between classes. I'll add a setting to
toggle "auto add fileclass in modal" that will hide this extra field if
toggle off.
WDYT?
—
Reply to this email directly, view it on GitHub
https://github.com/mdelobelle/metadatamenu/issues/453#issuecomment-1826400451,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AA4V7S6BZ5V7RC44GL5243TYGI64NAVCNFSM6AAAAAA7ZTVEY6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMRWGQYDANBVGE
.
You are receiving this because you authored the thread.Message ID:
@.***>

The drawback of the "auto propose a fileClass value modifier" is that you'll have to set a fileclass first.
Your method is much more usefull IMO: every file is mapped with the generic fileclass that let's you choose the specific fileclass when the file is "empty".
This is a very good usage of global that I didn't event think about ! I think I'll get this idea  for my own vault ;)

Cheers
On Sat, Nov 25, 2023 at 12:51 PM mathieu @.***> wrote:

The drawback of the "auto propose a fileClass value modifier" is that
you'll have to set a fileclass first.
Your method is much more usefull IMO: every file is mapped with the
generic fileclass that let's you choose the specific fileclass when the
file is "empty".
This is a very good usage of global that I didn't event think about ! I
think I'll get this idea for my own vault ;)
—
Reply to this email directly, view it on GitHub
https://github.com/mdelobelle/metadatamenu/issues/453#issuecomment-1826407920,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AA4V7S3CRHVYYCZB3PDFTW3YGJD4PAVCNFSM6AAAAAA7ZTVEY6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMRWGQYDOOJSGA
.
You are receiving this because you authored the thread.Message ID:
@.***>

there is now an option to remove them in v0.6.4


Screw it, we're just going to commit to master

new main GUI
new viewerlist gui w/filter
new About GUI
fixed FFZ emotes
fixed window saving/loading
fixed channel by adding .equals

Will merge when I wake up.
Kinda figured since I do releases anyways, no need to bundle all the commits up, so we'll just use Master.


fix readme

while setting up the repo i accidentally cut text instead of
copying it from the readme

Pull Request Test Coverage Report for Build 541448739

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 92.929%

Totals

Change from base Build 541388085:
0.0%

Covered Lines:
460

Relevant Lines:
495

💛  - Coveralls


System.TypeInitializationException: The type initializer for 'Microsoft.Data.SqlClient.SNINativeMethodWrapper' threw an exception.

I have a new WinForms project that I recently upgraded from System.Data.SqlClient to Microsoft.Data.SqlClient.  Everything looks fine but now ClickOnce publishing does not work. After installing and running the app from ClickOnce, the error appears:
System.TypeInitializationException: The type initializer for 'Microsoft.Data.SqlClient.SNINativeMethodWrapper' threw an exception. ---> System.ComponentModel.Win32Exception: Failed to load C:\Users****\AppData\Local\Apps\2.0\L9RAAE32.69T\MHGY46EK.K6A\test..tion_6412cd1ba591f0ae_0001.0000_f22578eef1ecd8cb\x86\SNI.dll ---> System.ComponentModel.Win32Exception: The specified module could not be found
--- End of inner exception stack trace ---
at Microsoft.Data.SqlClient.SNINativeMethodWrapper..cctor()
--- End of inner exception stack trace ---
at Microsoft.Data.SqlClient.SNINativeMethodWrapper.UnmanagedIsTokenRestricted(IntPtr token, Boolean& isRestricted)
at Microsoft.Data.Win32NativeMethods.IsTokenRestrictedWrapper(IntPtr token)
at Microsoft.Data.ProviderBase.DbConnectionPoolIdentity.GetCurrent()
at Microsoft.Data.ProviderBase.DbConnectionPoolGroup.GetConnectionPool(DbConnectionFactory connectionFactory)
at Microsoft.Data.ProviderBase.DbConnectionFactory.GetConnectionPool(DbConnection owningObject, DbConnectionPoolGroup connectionPoolGroup)
at Microsoft.Data.ProviderBase.DbConnectionFactory.TryGetConnection(DbConnection owningConnection, TaskCompletionSource1 retry, DbConnectionOptions userOptions, DbConnectionInternal oldConnection, DbConnectionInternal& connection)    at Microsoft.Data.ProviderBase.DbConnectionInternal.TryOpenConnectionInternal(DbConnection outerConnection, DbConnectionFactory connectionFactory, TaskCompletionSource1 retry, DbConnectionOptions userOptions)
at Microsoft.Data.ProviderBase.DbConnectionClosed.TryOpenConnection(DbConnection outerConnection, DbConnectionFactory connectionFactory, TaskCompletionSource1 retry, DbConnectionOptions userOptions)    at Microsoft.Data.SqlClient.SqlConnection.TryOpenInner(TaskCompletionSource1 retry)
at Microsoft.Data.SqlClient.SqlConnection.TryOpen(TaskCompletionSource`1 retry)
at Microsoft.Data.SqlClient.SqlConnection.Open()
Things I have tried:
Update Nuget Packages (Microsoft.Data.SqlClient = 1.11 and Microsoft.Data.SqlClient.SNI = 1.11)
Change target configuration to x86 and republish
Include SNI.dll in project and Copy to Output Directory
Expected behavior
The app should install successfully from ClickOnce, and run successfully as it does from Visual Studio 2019.
Further technical details
Visual Studio 2019 16.4.5
Microsoft.Data.SqlClient version: 1.11.20045.2 (Nuget)
.NET target: WinForms Framework 4.7.2, Core 3.1
SQL Server version: SQL Server 2016 SP2 13.0.5337.0 (X64)
Operating system: Windows 10 Pro 64bit
stack_trace.txt

Possible duplicate of https://github.com/dotnet/SqlClient/issues/441


Merge pull request #1 from h6ah4i/master

pulling in new changes

Hi. This seems just a mistake, so I'll close it.


Bringing JOSS branch up to date with master

This branch is just copying the current master to JOSS because I accidentally created the JOSS branch from an old commit. Accepting because nothing should have changed.


New online popup, fix descriptions

Should be "create online" instead of "clone", also suggest just having "package" instead of "target package"

I have adapted the description analogous to the offline project. Does it fit?

Why is a new popup needed?

descriptions look good
no new popup is needed, just adjust the descriptions in the existing popup


ACME HTTP challenge should use router entry points

Do you want to request a feature or report a bug?
Feature
What did you expect to see?
tl;dr: Single entry point on ACME HTTP challenge does not mix well with multiple entry points on routers.
Currently, the ACME HTTP challenge supports a single entry point while routers can have any number of entry points assigned. This creates situations where certificates cannot be acquired or renewed because the verification request arrives at an unexpected entry point.
Consider the follow configuration:
[entryPoints]
  [entryPoints.https]
    address = "<IP_ADDRESS>:443"
  [entryPoints.https6]
    address = "[::1234]:443"

Now of course I want my services to be reachable with both IPv4 and IPv6. So my DNS name would have both A and AAAA records. The Traefik router would have these two entry points. All good! Almost.
Let’s Encrypt appears to prefer IPv6 if available. But I guess they would fall back to IPv4 like browsers do, so pretty quickly. That means I cannot really "pick the correct entry point".
One possible solution is to just use all port 80 entry points (ACME does not use other ports except when redirected to 443). The change could be as simple as removing the configuration option and adapting the following line to check for port 80 instead:
https://github.com/containous/traefik/blob/da8451c6373ce09cdfa0eedb770922cabf37426f/cmd/traefik/traefik.go#L266
Another possible solution is to simply support multiple entry points on the HTTP challenge configuration (and again adapting the line above). This was suggested pre-2.0 in #2710.
Both changes appear relatively small to me.
(I found that the TLS challenge works for me so this is not a priority.)

Hello,
This use case is a edge case of the HTTP challenge, and in this case the right challenge to use is the TLS challenge.
Handle this edge case will complicate all standard cases (99% of the cases)
So we will decline, thank you anyway.


Support for v3 hidden services

Problem/Motivation

As indicated in the addon logs and elsewhere in Tor software releases, v2 hidden services are deprecated and should be migrated to v3 before support for them is removed.

DEPRECATED: Onion service version 2 are deprecated. Please use version 3 which is the default now. Currently, version 2 is planned to be obsolete in the Tor version 0.4.6 stable series.

Expected behavior

The addon should create a v3 hidden service instead of a v2 hidden service.

Actual behavior

A v2 hidden service is created and there doesn't seem to be a config option to upgrade because the Tor config file is hard-coded to use v2.

Steps to reproduce

Install and start the addon. A v2 hidden service is created, followed shortly by a deprecation warning.

Proposed changes

The easiest fix would probably be to remove the HiddenServiceVersion 2 line from the hidden service config so new services will default to v3 and existing services can remain v2. I haven't yet investigated upgrade paths, but reinstalling the addon would be acceptable, IMO.

Thanks!

Not stale.


Exception On Empty Input Files

Madoop has an AssertionError in the prepare_input_files function when an input file is empty.

The expected behavior is to create/tolerate an empty input file.


Date processor to convert from epoch_milli or epoch_second

Is your feature request related to a problem? Please describe.
As a user with Events that have keys with epoch milli timestamps, "{ "timestamp":<PHONE_NUMBER>219 }, I would like to use the date processor to convert this timestamp to a date
Describe the solution you'd like
A new concept of built-in patterns for the date processor. So now, instead of just DateTimeFormatter patterns, the date processor will have a list of built in patterns such as epoch_milli or epoch_second. These patterns will work exactly the same as the regular date time patterns do. For example, the config will look like this
processor:
  - date:
        match:
           key: "timestamp"
           patterns: [ "epoch_milli", "epoch_second", "yyyy.MM.dd.hh.ss" ]

The date processor would first check if the timestamp is epoch milli, and if so it will convert it to a Date Time. If it wasn't found to be an epoch milli timestamp, then it will check for epoch_second, then finally the DateTime pattern.
Describe alternatives you've considered (Optional)
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.

Supporting "epoch_nano" would be great as well if you're about to support these because it's something that can happen as well and I couldn't find good processor to convert a Nano to Milli (truncate the last 6 digits basically).
I was able to use Opensearch Dev Console to tell it to handle the Epoch Time in milliseconds (OS doesn't support Nanos) this way but it would be great to be able to do that in the Date Processor instead:
PUT /my-index
{
  "mappings": {
    "properties": {
      "eventtime": {
        "type": "date",
        "format": "epoch_millis"
      }
    }
  }
}

Should the options be  epoch_milli_<timezone> , epoch_second_<timezone>? Otherwise how would the timezone info be derived?


[ADD] Onboarding screen

FYI:   Add onboarding screen
https://www.figma.com/design/puB2fsVpPrBx3Sup7gaa3v/Vultisig-App?node-id=1122-11412&t=BYliSYwLAjsadaO1-0
It only appears when user start the application for the first time , and when vault is empty


Fix missing and non-working parameters

range.slider's prettify param is a function that allows the user to customize the displayed values on the slider.
Currently, it's not being executed, since it's bound as a plain value.

I haven't tested all parameters yet, but as far as I could check, there are no breaking changes related to other params.
I feel this PR is good to go.

Thank you for your contribution!


added new input parameter event for custom valid function. This fixed #886

Dropdown throws an exception when I type into the custom validation field.

@hbowden This problem should be fixed with the PR

Tested and approved.


Model: some Flux fine-tunes can't be loaded due to weird tensor naming conventions.

A friend of mine had trouble loading a model called "Flux Unchained".
When loading the tensors for  the Unet, the logs were filled with:
[INFO ] model.cpp:1685 - unknown tensor 'model.diffusion_model.model.diffusion_model.[**tensor name here**]' in model file
for every single tensor in the model. Then when calling new_sd_ctx(), the logs are:
[ERROR] model.cpp:1729 - tensor 'model.diffusion_model.[**tensor name here**]' not in model file
So it looks like the model.diffusion_model. part of the tensor names got duplicated, but the model still somehow work in other inference backends (at least it works in comfyui).

use -m instead of --diffusion-model
also alternative hotfix https://github.com/leejet/stable-diffusion.cpp/pull/403 :laughing:

Ah I missed your PR because it's closed. Thanks!

I think it's worth doing at least something about it, maybe a warning in the logs to advise the user to use -m instead?

Yea, something needs to be done.


triangleMeshSurface.scad non-functional

It appears that triangleMeshSurface.scad is insoluble as written.

There are several functions commented out in the file. You'll have to un-comment one of them, or write your own.


Feature request: Ability to ignore whole directories inside pages

Is your feature request related to a problem? Please describe.
I have a detail page with a lot of information visualized in unique ways that only make sense to that page.
Because my components folder gets used for re-usable components, I have a subfolder in the same folder that route is located.
My pages folder looks a little something like this:
routes
- route-1
  - index.vue
  - -components
     - SomeComponentUniqueToThisRoute.vue
     - AnotherComponentUniqueToThisRoute.vue
- route-2
  - index.vue
  - -components
     - SomeComponentUniqueToThisRoute.vue
     - AnotherComponentUniqueToThisRoute.vue
     .....

if I now go to /route-2/-components/SomeComponentUniqueToThisRoute it loads that component, obviously, because Nuxt thinks it's a page.
In the documentation it says that I can already hide components by prefixing them with a -. But sadly this does not work on folders atm.
Describe the solution you'd like
I want nuxt to not generate routes from .vue files in folders prefixed with a - by default, without the help of .nuxtignore. Exactly like it already does for components.
All sub-folders and their .vue files should not be turned in to pages as well.
Describe alternatives you've considered
Having all components in my -components folder starting with a - would do the trick, but that is ugly and breaks vue's naming conventions.
I could also write a couple of .nuxtignore rules that exclude the folders, but my application has many (around 25) -components folders that I would have to exclude. It is also another thing I have to explain to people who help me with this project, which isn't ideal.

Hey 👋
I think the result is achievable with a single .nuxtignore rule:
/pages/**/-components/**
This should ignore all files in any nested -components folder somewhere inside the pages folder.

Hey 👋
I think the result is achievable with a single .nuxtignore rule:
/pages/**/-components/**
This should ignore all files in any nested -components folder somewhere inside the pages folder.

Hey 👋
I think the result is achievable with a single .nuxtignore rule:
/pages/**/-components/**
This should ignore all files in any nested -components folder somewhere inside the pages folder.
Could you give it a try?

Thanks for the response! I'll try it in a second. It seems better than my current solution of adding more ignore lines.
To me it is more about consistency. People joining me on the project always ask me why the same project structure does not work for them in a fresh nuxt project. I also have situations where I just want to have an entire folder of just pages hidden temporarily. Prefixing them and immediately being able to see why the pages/components are excluded in my three view seems better to me then than opening the .nuxtignore and hope I added enough * in the right places 😅
I also really dislike adding another .config or .ignorefile to my project root. As I'm only using the .nuxtignore for hiding my -components folders and obsolete pages, this would be a welcome change to me.

Hey 👋
I think the result is achievable with a single .nuxtignore rule:
/pages/**/-components/**
This should ignore all files in any nested -components folder somewhere inside the pages folder.
Could you give it a try?

Thanks for the response! I'll try it in a second. It seems better than my current solution of adding more ignore lines.
To me it is more about consistency. People joining me on the project always ask me why the same project structure does not work for them in a fresh nuxt project. I also have situations where I just want to have an entire folder of just pages hidden temporarily. Prefixing them and immediately being able to see why the pages/components are excluded in my three view seems better to me then than opening the .nuxtignore and hope I added enough * in the right places 😅
I also really dislike adding another .config or .ignorefile to my project root. As I'm only using the .nuxtignore for hiding my -components folders and obsolete pages, this would be a welcome change to me.

Default value for ignorePrefix is - in nuxt@2 but the ignore pattern we generate  is **/${options.ignorePrefix}*.* (it is prefix of file name not directory so pages/-foo/index.vue is mapped to /-foo route). We can update pattern but it would be a regression for projects using - for pages directory names that suddenly stops working. We might better doing this for nuxt3 alongside with rest of pages convention changes.

I also really dislike adding another .config or .ignorefile to my project root. As I'm only using the .nuxtignore for hiding my -components folders and obsolete pages, this would be a welcome change to me.

You can use ignore property in nuxt.config as well :)

Default value for ignorePrefix is - in nuxt@2 but the ignore pattern we generate  is **/${options.ignorePrefix}*.* (it is prefix of file name not directory so pages/-foo/index.vue is mapped to /-foo route). We can update pattern but it would be a regression for projects using - for pages directory names that suddenly stops working. We might better doing this for nuxt3 alongside with rest of pages convention changes.

I also really dislike adding another .config or .ignorefile to my project root. As I'm only using the .nuxtignore for hiding my -components folders and obsolete pages, this would be a welcome change to me.

You can use ignore property in nuxt.config as well :)

You can use ignore property in nuxt.config as well :)

I didn't know that! Definitely will do that tomorrow.

We can update pattern but it would be a regression for projects using - for pages directory names that suddenly stops working. We might better doing this for nuxt3 alongside with rest of pages convention changes.

I wonder how many projects actually have the - used in their folder names expecting it to work as it currently does. I don't know how far away nuxt 3.0 is from being released and production ready. Having this changed in >= 2.15 would be ideal for me. But i'm not the only one using nuxt and not a maintainer so imma leave it with you guys. I have 1 less config file so i'm happy for now haha.
Thanks for the quick responses!

You can use ignore property in nuxt.config as well :)

I didn't know that! Definitely will do that tomorrow.

We can update pattern but it would be a regression for projects using - for pages directory names that suddenly stops working. We might better doing this for nuxt3 alongside with rest of pages convention changes.

I wonder how many projects actually have the - used in their folder names expecting it to work as it currently does. I don't know how far away nuxt 3.0 is from being released and production ready. Having this changed in >= 2.15 would be ideal for me. But i'm not the only one using nuxt and not a maintainer so imma leave it with you guys. I have 1 less config file so i'm happy for now haha.
Thanks for the quick responses!

nuxt.config.js
router: {
  exclude: ['component/', 'directive/', 'store/', 'service/']
}

I‘m here
Gesendet von Yahoo Mail für iPhone
Am Samstag, März 6, 2021, 5:33 AM schrieb xianghongai<EMAIL_ADDRESS>nuxt.config.js
router: {
exclude: ['component/', 'directive/', 'store/', 'service/']
}
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

Need you a room or Money???
Gesendet von Yahoo Mail für iPhone
Am Samstag, März 6, 2021, 5:33 AM schrieb xianghongai<EMAIL_ADDRESS>nuxt.config.js
router: {
exclude: ['component/', 'directive/', 'store/', 'service/']
}
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

Bruh did a indian mail scammer really just invade this issue through email.

Bruh did a indian mail scammer really just invade this issue through email.

Hey😅, How did they do that?

Default value for ignorePrefix is - in nuxt@2 but the ignore pattern we generate is **/${options.ignorePrefix}*.* (it is prefix of file name not directory so pages/-foo/index.vue is mapped to /-foo route).

Ah, that's what's happening! I thought my directory prefixed with - was being ignored even in the dev build. I was about to make a feature request for another prefix for ignoring only in production builds. However, it seems it already behaves that way, just the prefix pattern is ignored on directories. This should probably be added to the docs.

The ability to ignore pages in general is not documented in the nuxt 3.0 documentation, just saying.

Closing this issue since it won't be added to nuxt 2. In nuxt 3 it appears everything is done through the nuxtignore file. Maybe you maintainers can consider processing other issues in this repository with the 3.0 tags :).


Huge fees in bigmerge-new branch

When playing with the old bigmerge branch I observed huge fees (like 10 times the actual transaction amount) being charged. Needs to be checked before we can ever merge to master.

Stale issue. Issue resolved in latest v4.22.X wllet. Update required (binaries here on github or download.reddcoin.com) Ticket marked done and closed.


PMID:11676925

decreased protein localization to telomeric heterochromatin during meiotic horsetail phase

there's no "meiotic horsetail phase" defined in GO, so the term name is
decreased protein localization to telomeric heterochromatin during horsetail movement FYPO:0004716
with "phase" in an exact synonym
also added a couple more for grouping
abnormal protein localization to heterochromatin during meiosis FYPO:0004717
abnormal protein localization to heterochromatin FYPO:0004718

edit file: eda798586221374f5f371d7909b88fbb0b447dd9
release: 162d1966777c2e2b8aa5cda6d562c1d2125afec1


[EN] Feedback for: /web/updates/2015/03/increasing-engagement-with-app-install-banners-in-chrome-for-android?hl=en

Typo: "recetent addtion" should be "recent addition"

Urgh. thanks will sort
On Tue, 29 Dec 2015, 22:15 Mark Dittmer<EMAIL_ADDRESS>wrote:

Typo: "recetent addtion" should be "recent addition"
—
Reply to this email directly or view it on GitHub
https://github.com/google/WebFundamentals/issues/2400.


refactor: enhance error handle

Enhance error handle, there are a lot of  snippets should  returns error instead of panic.

Codecov Report

Merging #206 into master will decrease coverage by 0.16%.
The diff coverage is 77.77%.

@@            Coverage Diff            @@
##           master    #206      +/-   ##
=========================================
- Coverage   88.76%   88.6%   -0.17%
=========================================
  Files           5       5
  Lines        1024    1027       +3
=========================================
+ Hits          909     910       +1
- Misses         72      73       +1
- Partials       43      44       +1

Impacted Files
Coverage Δ

parser.go
87.47% <77.77%> (-0.34%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dac684d...2436f3f. Read the comment docs.

Good!


Feat: alter needReinstall param of TestTask to pass reinstallation of uploaded app file

Linked GitHub issue ID: #
Pull Request Checklist

[X] Tests for the changes have been added (for bug fixes / features)
[X] Code compiles correctly with all tests are passed.
[X] I've read the contributing guide and followed the recommended practices.
[ ] Wikis or README have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?
If this introduces a breaking change for Hydra Lab users, please describe the impact and migration path.

[ ] Yes
[X] No

Pull Request Description
A few words to explain your changes:
Hydra Lab can pass reinstallation of uploaded app file.
Gradle plugin added param appVersion and altered param needReinstall.
How you tested it
Please make sure the change is tested, you can test it by adding UTs, do local test and share the screenshots, etc.
Locally enabled center/agent, and run gradle plugin locally. Result shows everything's fine.

Please check the type of change your PR introduces:

[ ] Bugfix
[X] Feature
[ ] Technical design
[ ] Build related changes
[ ] Refactoring (no functional changes, no api changes)
[ ] Code style update (formatting, renaming) or Documentation content changes
[ ] Other (please describe):

Feature UI screenshots or Technical design diagrams
If this is a relatively large or complex change, kick it off by drawing the tech design with PlantUML and explaining why you chose the solution you did and what alternatives you considered, etc...

Could you share why we need to change this?


Color columns not working outside of rows

It was working some versions ago, but with the current version colored columns aren't working when outside of a row.
You can see that in this fiddle http://jsfiddle.net/trigoesrodrigo/a8xjkuzn/2/
It also happens on the website http://semantic-ui.com/collections/grid.html#row-and-column-backgrounds

This is already fixed in 2.x. Part of the bug fixes that have yet to be backported.
http://jsfiddle.net/j5xc4vjy/


Script with Object parameter type

Just a simple code as below:
public class TestApp {
  @JSBody(params={"msg"}, script="console.log(msg);")
  public static native void test01(Object msg);

  @JSBody(params={"msg"}, script="console.log(msg);")
  public static native void test02(String msg);

  public static void main(String[] args) {
    test01("Hello");
    test02("Hello");
  }
}

I expect there are two 'Hello' messages showed in the console log. However, it is not.

My Chrome console shows something like:
jl_String1 {characters97: arraycls, hashCode98: 69609650, $id: 8}
Hello

My Firefox console shows something like:
Object { characters97: Object, hashCode98: 69609650, $id: 8 }
Hello

I am not sure this is a bug or not.
What's wrong with the method test01?

It's not valid to pass Objects to @JSBody methods, see here. I think that there is bug in TeaVM, so it does not report you about violation of this restriction.

That's not an error that code produced by TeaVM does not work. The problem is that TeaVM should have reported about wrong usage of JSBody annotation. I added this error reporting.


Updated version number

Updated assembly version to match nuget version

Hey,
So this applies to both this PR and the one for FParsec-Pipes.
.
We need to make the assembly version match the version that the NuGet packages will be bumped to, rather than the current version, since the end goal is to release new stuff on NuGet to make Rezoom.SQL work out of the box.
Back a couple years ago, you could have a .nuspec file that would set the NuGet pkg version to $version$ so it would automatically match the version in AssemblyInfo. That would be ideal, so the two don't have to be kept in sync manually going forward.
But for the time being, it would also be OK to just bump the version to 1.0.1 here and 1.1.1 in Pipes, and make sure it is changed both in AssemblyInfo and in the fsproj. At least, in FParsec-Pipes it is specified in the fsproj -- kkm000 did some work in this PR for that. Not sure if it is necessary to replicate that work here. I am going to go ahead and fix up the versions in the FParsec-Pipes repo since it seems quite clear how to proceed there.
Would you be interested in having direct push access to Rezoom and Rezoom.SQL?

Hi,
Noted. I'll bump up the version.
In my case, I just replaced the dlls in the .nuget folder after building :)
In the referenced PR, the library was updated to support 4.5 and .NET Standard 1.6. What is the minimum .NET Standard version you are looking since the others are 2.0?
Yes. I'll be interested in direct push access.

I went ahead and pushed a new NuGet package for FParsec-Pipes where both the pkg version and assembly version are 1.1.1.
You should also have received an invitation to collaborate both here and on Rezoom.SQL.

@rspeele With the version updated, can you create the new nuget packages so Rezoom.SQL takes a dependency on 1.1.1?


full screen support

Thanks for contribution!
There are some questions:

It’s better to git pull before pull request, otherwise may cause modify that not needed.
I found that you add the innerHeaderTopLength property, and comment as: the distance between header and root scrollview, but why should add it? (you can add the distance in header)
The innerHeaderTopLength property contain inner but mark as open, that's not a good way to name it.
Change COCOAPODS to a beta version is not a good idea.
Now, it’s version 2, you should merge to v2 branch.

Thank you for your response.
There has some question when UINavigationBar has hidden.
There is a distance between window top and scrollview.

You can look at the HomeViewController in the Example project, which demonstrates the hidden display of the navigationBar. But I don't see any problem with it.
"when UINavigationBar has hidden", it's a problem about safeArea, I had solved this problem. So I think innerHeaderTopLength is not necessary.
If you still have some questions, you can provide a demo about problem to me.

头部背景需要填充满,而不是留一个safe top height

目前的SegementSlide是可以支持『头部背景需要填充满』的，你需要继承TransparentSlideViewController来使用，而不是用SegementSlideViewController。如果TransparentSlideViewController的样式不满足你的需求，可以继承SegementSlideViewController来实现一个自定义类，该自定义类可以模仿TransparentSlideViewController的写法，如果需要『头部背景需要填充满』，请务必在自定义类的edgesForExtendedLayout属性中包含.top值。
另外，在该pull request申请之后的一段时间，我曾经为了移除仓库历史中的大资源文件而重写了机率，导致目前的pull request存在冲突，不能直接合并，如果今后有更好的建议，可以提交到当前版本的分支下，如：现在是v2分支。
建议commit以英文编写，保持国际化。
commit应该保持功能一致，如：no message应该属于WKWebView也需要响应内部点击事件,比如视频播放的一部分，应该合为一个。

OK


docs(api): specify unit of delay

Summary
I never remember if most tries to be smart and delayTime is in seconds, or if it's ms ...
This adds the unit on the delayTime argument of the delay operator in the api docs.

Done


Not listing all releases

Currently this action is not listing all releases, it only lists first page and hence wont delete all releases within a long lived repository with many releases.  Also would be nice to get the node version updated to 20 to get rid of the warning.
I could even do a PR to fix both of these, but is this action still maintained and will get a new release if I make the PR?

Yes! This repository is still maintained and welcome for PRs. Thank you for your interest to this action. I will handle any PRs quickly and publish a new release after testing.


Make the "files to include" and "files to exclude" text boxes able to show multiple lines of text, like the main search box.

Make the "files to include" and "files to exclude" text boxes able to show multiple lines of text, like the main search box. This would make it much easier to see which files you're limiting your search to, especially if you have several specific directories or file types you want to limit it to.
Search panel

Editor Search

This feature request has not yet received the 20 community upvotes it takes to make to our backlog. 10 days to go. To learn more about how we handle feature requests, please see our documentation.
Happy Coding!

Thank you for submitting your feature request and everyone who considered it! Unfortunately, this issue did not receive enough votes over the allotted time, and so we are closing the issue. PRs are welcome so you can create a PR that fixes this if you are passionate about getting this feature across the finish line. Thanks!


Download resources remove min width census

What is the context of this PR?
Same as #1425 for census branch

 Remove min width from checkbox when being used inside filters


An error occurred in setting up the environment

I set up the environment according to the installation manual. Every time I create a virtual environment, cudatoolkit11.7.0 will be downloaded automatically. However, my Linux cuda version is 11.6, running torchmd-train will report such an error, can you solve it? Thank you very much!

Does your Nvidia driver support Cuda11.7? Is it new enough? try to update
the driver
On Tue, Nov 1, 2022 at 2:30 AM mukui123 @.***> wrote:

I set up the environment according to the installation manual. Every time
I create a virtual environment, cudatoolkit11.7.0 will be downloaded
automatically. However, my Linux cuda version is 11.6, running
torchmd-train will report such an error, can you solve it? Thank you very
much!
[image: image]
https://user-images.githubusercontent.com/90401610/199138955-10601894-6a01-4726-8064-a5d70148822a.png
[image: image]
https://user-images.githubusercontent.com/90401610/199139051-72676bc8-ab33-4373-b456-0e6b95bc9246.png
—
Reply to this email directly, view it on GitHub
https://github.com/torchmd/torchmd-net/issues/145, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AB3KUOV6ONJVIUTLDSSKCVLWGBXE3ANCNFSM6AAAAAARTTYLCI
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

@giadefa I'm not sure that's a good idea. the rest of the packages it's pulled are for cuda 11.2 if you look at pytorch for example. It's probably better to force the installation of cudatoolkit 11.2 in this environment.
@mukui123 can you try conda install cudatoolkit=11.2 -c conda-forge?

Conda is supposed to check your driver and automatically pick the most recent toolkit compatible with it.  In practice, that doesn't work very well.  It often ends up picking a toolkit that's newer than your driver supports.  In that case, you need to force it to downgrade as @stefdoerr suggested.  We should add this to the documentation.

I have reinstalled the new version of cuda, but I still get an error when running torchmd-train, could you please help me check it? Thank you very much!
Traceback (most recent call last):
File "/home/wangchenyang/anaconda3/envs/torchmd-net/bin/torchmd-train", line 33, in
sys.exit(load_entry_point('torchmd-net', 'console_scripts', 'torchmd-train')())
File "/home/wangchenyang/torchmd-net/torchmdnet/scripts/train.py", line 113, in main
args = get_args()
File "/home/wangchenyang/torchmd-net/torchmdnet/scripts/train.py", line 65, in get_args
parser.add_argument('--prior-model', type=str, default=None, choices=priors.all, help='Which prior model to use')
AttributeError: module 'torchmdnet.priors' has no attribute 'all'


remove mistaken duplication of signal plot

As far as I can tell, there is no reason to plot the signal twice with different normalization. It seems to be an artifact from an earlier rebase (or something like that).

Right, its not a duplication but plotting the signal with its normalisation and once again just the pdf. I can't think of a use case for the latter, so we could drop it.


Research: compile TypeScript on-the-fly

Improve loader to compile single TypeScript file from .ts on-the-fly in memory but tests will use tsc for whole project

The typescript can incrementally compile files on-the-fly but the whole project needs to be in memory [of the compiler]. It is possible to compile a single file only if it doesn't have any dependencies (which is rarely the case).
The manual recompilation\trigger can be done via rich API of the tsc (as it is done by multiple IDE) or via tsc --watch automatically if the project structure is known to the tsc.


assign-default-security-groups fails in PEEK mode when creating new default security group

Hello team,
We are leveraging cf-mgmt 1.0.24 and it fails when trying to assign default security group to running/staging security groups.
2019/07/02 17:26:28 I0702 17:26:28.983786 11271 securitygroup.go:261] [dry-run]: creating securityGroup spring_cloud_services with contents [
  {
    "protocol": "tcp",
    "destination": "REMOVED",
    "ports": "REMOVED",
  }
]
******** './cf-mgmt-linux-1.0.24 assign-default-security-groups'
error: Running security group [spring_cloud_services] does not exist
******** FAILURE: Assign Default Security Groups Failure

This isn't a problem when running in COMMIT mode, as the create-security-groups function actually handles the creation.
Let me know if you need any more information and thanks!

Fixed with 1.0.30 (https://github.com/pivotalservices/cf-mgmt/releases/tag/v1.0.30)


feat: allow connecting to HTTP Git repositories

Fixes: #872
This adds support for connecting to Git repositories over an (insecure) HTTP wire as described in https://github.com/akuity/kargo/issues/872#issuecomment-1761972854, while taking into account the effect it would have on HTTP Helm repositories as observed in https://github.com/akuity/kargo/issues/872#issuecomment-1956378143.
Effectively, this means that connecting to any HTTP endpoint is now allowed as long as this does not require authentication. This includes "classic" Helm repositories served over HTTP, where basic authentication used to be supported in the past.

waiting for v0.5.0 🤞

tried the latest [0.4.1-unstable-20240223] but getting the below error
spec.promotionMechanisms.gitRepoUpdates[0].repoURL in body should match '^https://(\w+([\.-]\w+)*@)?\w+([\.-]\w+)*(:[\d]+)?(/.*)?$',

Yes, I installed a fresh Kargo helm installation after deleting old CRDs. Here is the extract from the new CRD installed.
repoURL:                           description: URL is the repository's URL. This is a required                             field.                           minLength: 1                           pattern: ^https?://(\w+([\.-]\w+)*@)?\w+([\.-]\w+)*(:[\d]+)?(/.*)?$

@geowalrus4gh what is the command you used to apply? Did you use kubectl or kargo CLI?

i used helm command to install.
helm upgrade --install kargo --create-namespace -n kargo oci://<harbor-url>/ghcr/akuity/kargo-charts-unstable/kargo --version 0.4.1-unstable-20240223 -f values.yaml --wait
I copied the crds from the github and applied, then it worked.
But now am getting an authentication failed error.
Also, there is a warning shown like this
time="2024-02-24T10:14:06Z" level=warning msg="refused to get credentials for insecure HTTP endpoint" freight=a508d8e8281d5b453cb4719f2e9f1b47c6f2afd9 namespace=sample-kargo promotion=dev.01hqd9q685kx5fmnw1t42jdcgf.a508d8e repoURL="http://bitbucket.company.com/scm/samp/sample-env.git" stage=dev
Does that mean, the repo secret for the http URL is not being read by kargo?

That is correct. It was a compromise we arrived at in order to support unsecured connections -- we won't pass credentials over them.

@krancour, How are you doing?
I didn't fully understand what that meant?!
if I want to use a HTTP git repo the Kargo Controller will not use the creds stored in the secret.
so how will it do a push to the remote!?

Hey @tal-hason, good to hear from you!

if I want to use a HTTP git repo the Kargo Controller will not use the creds stored in the secret.

Making sure you spotted the missing "S". (Easy to overlook.) This is strictly for HTTP and not HTTPS. Kargo is refusing to pass credentials over an unsecure connection.
Practically speaking, this shouldn't be much of a limitation. The only time I can think of where you would conceivably access a repo over an unsecure connection would be during local development, in which case you can just skip the creds entirely and configure the repo to allow pushes without authenticating.

Also, you don't have to pass the creds in the HTTP url.

Store it in the .gitconfig and in the .git-credentails and the git will use it.

Well, both of these are technically true. The credentials are passed as a header. And on an insecure connection the header is perfectly accessible to anyone or anything reading the request. This is exactly why the decision was made in the first place to disallow the use of creds over an unsecure connection. After even a single use, you have to assume the credentials could have been compromised.
At the time we made that decision, there was some precedent for it (or so we thought?), as we could recall kubectl disallowing the use of credentials over an unsecure connection. Just now, I've been searching for any reference to that and keep coming up empty-handed, perhaps partly because as far back as v1.22.0, unsecure connections to the API server aren't even possible. So if our recollection was correct, it was in the distant past and since then, if anything, Kubernetes has moved in a more dogmatically secure-by-default position.
Anyway -- that's all background.
We discussed at our team meeting this morning and all agreed that we will consider adding this as some kind of highly discouraged option in the future if we hear of more users / use cases that require this. Even as an opt-in, we don't want to relax security if this use case is an extreme outlier.
Please feel free to open a new issue. If the issue attracts a lot of attention, it will strengthen the case for this option to exist and may also accelerate the timeframe for getting it done.

@krancour ,thanks as always on the detailed answer 😃.
I can tell you the I going at least 3-4 customers that have the potential to work with Kargo that have unsecured git server, do to that their network is disconnected.
I understand the secure by design concept and constraints, but security at the end is the customer risk to take.
I will Open an issue and see what is what.


defaultValue used as entrySeparator

Do you want to request a feature or report a bug?
Bug
What is the current behavior?
Passing a default value for type array uses that value as the entry separator.
If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem via https://jsfiddle.net or similar.
Call decode with `decode('array', str_array', []);
What is the expected behavior?
['str', 'array']
Actual
['s', 't', 'r', '_', 'a', 'r', 'r', 'a', y']
Which versions of react-url-query, and which browser and OS are affected by this issue? Did this work in previous versions of react-url-query?
v1.2.0
Chrome
Not used before
Looks like https://github.com/pbeshai/react-url-query/blob/master/src/serialize.js#L292 is passing defaultValue into func https://github.com/pbeshai/react-url-query/blob/master/src/serialize.js#L140
I would expect the defaultValue to be returned from decode if the decodedValue === undefined. If you pass in [] it's using that as the entrySeparator

Good catch, I'll fix today.


When pan the map, I feel not smooth enough

I get the demo and run it , I used google Tile map , but I feel not smooth enough when I pan  the map.  feel delay and stuck 。How can I optimise  it ？ Thinks again.

mapjfx by itself does not support Google maps, how did you integrate that?

closed; cannot reproduce and have no further information


Make GrandpaBlockImport public

This PR makes the GrandpaBlockImport struct public in the sc-finality-grandpa crate.
I believe this change is correct because:

It makes GrandpaBlockImport consistent with PowBlockImport, AuraBlockImport, etc
The service.rs files in both the bin/node and the node template hold a reference to an instance of GrandpaBlockImport

quoting @tomaka from riot:

It's always a bug in the code to have private types in your public API. Unfortunately Rust doesn't really enforce that. If GrandpaBlockImport wasn't marked pub at all, Rust would complain for this specific reason.


GoSublime error: MarGo build failed

| GoSublime error: MarGo build failed
|                > This is possibly a bug or miss-configuration of your environment.
|                > For more help, please file an issue with the following build output
|                > at: https://github.com/DisposaBoy/GoSublime/issues/new
|                > or alternatively, you may send an email to<EMAIL_ADDRESS>|                >
|                >
|                > cmd: ['C:/Program Files (x86)/Go\\bin\\go.exe', 'build', '-tags', '', '-v', '-o', 'gosublime.margo_r18.04.19-1_go?.exe', 'gosublime/cmd/margo']
|                > stdout: |                >  |                >
|                > stderr: |                > gosublime/margo |                > net |                > gosublime/something-borrowed/types |                > gosublime/margo/meth/importpaths |                > vendor/golang_org/x/net/lex/httplex |                > crypto/x509 |                > net/textproto |                > mime/multipart |                > crypto/tls |                > net/http/httptrace |                > net/http |                > net/http/pprof |                > net/rpc |                > gosublime/something-borrowed/gocode |                > gosublime/cmd/margo_pkg |                > gosublime/cmd/margo |                > go install gosublime/cmd/margo: open gosublime.margo_r18.04.19-1_go?.exe: The filename, directory name, or volume label syntax is incorrect. |                >
|                > exception: None
|   install state: busy
| sublime.version: 3143
| sublime.channel: stable
|       about.ann: a18.04.19-1
|   about.version: r18.04.19-1
|         version: r18.04.19-1
|        platform: windows-x64
|            ~bin: ~\AppData\Roaming\Sublime Text 3\Packages\User\GoSublime\windows-x64\bin
|       margo.exe: ~bin\gosublime.margo_r18.04.19-1_go?.exe (missing)
|          go.exe: C:/Program Files (x86)/Go\bin\go.exe (ok)
|      go.version: go?
|          GOROOT: C:/Program Files (x86)/Go
|          GOPATH: E:/gowork;e:/gowork/goweb
|           GOBIN: (not set)
|       set.shell: []
|       env.shell:
|       shell.cmd: ['C:\Windows\system32\cmd.exe', '/C', '${CMD}']
|    sh.bootstrap:
|                > 	error building gosubl\sh-bootstrap.go: [WinError 740] 请求的操作需要提升。
|                > 	error running bin\gosubl-sh-bootstrap.exe: [WinError 740] 请求的操作需要提升。
|                > 	go version: (raw version string)
|                > 	shell bootstrap took 0.034s
|                >
Look this ,please!

IIUC, that error means something needs higher priviledges but I'm not a Windows user so I don't know why that would be the case.
Can you compile ...\AppData\Roaming\Sublime Text 3\Packages\GoSublime\gosubl\sh-bootstrap.go manually?

Getting similar error on my MacBook
| GoSublime error: MarGo build failed
|                > This is possibly a bug or miss-configuration of your environment.
|                > For more help, please file an issue with the following build output
|                > at: https://github.com/DisposaBoy/GoSublime/issues/new
|                > or alternatively, you may send an email to<EMAIL_ADDRESS>|                >
|                >
|                > cmd: `['/usr/local/bin/go', 'build', '-tags', '', '-v', '-o', 'gosublime.margo_r18.04.19-1_go1.10.exe', 'gosublime/cmd/margo']`
|                > stdout: `
|                >
|                > `
|                > stderr: `
|                > go: cannot find GOROOT directory: /usr/local/Cellar/go/1.10/libexec
|                > `
|                > exception: `None`
|   install state: busy
| sublime.version: 3143
| sublime.channel: stable
|       about.ann: a18.04.19-1
|   about.version: r18.04.19-1
|         version: r18.04.19-1
|        platform: osx-x64
|            ~bin: ~/Library/Application Support/Sublime Text 3/Packages/User/GoSublime/osx-x64/bin
|       margo.exe: ~bin/gosublime.margo_r18.04.19-1_go1.10.exe (missing)
|          go.exe: /usr/local/bin/go (ok)
|      go.version: go1.10
|          GOROOT: /usr/local/Cellar/go/1.10/libexec
|          GOPATH: ~/go
|           GOBIN: (not set)
|       set.shell: []
|       env.shell: /bin/zsh
|       shell.cmd: ['/bin/zsh', '-l', '-c', '${CMD}']
|    sh.bootstrap:
|                > 	GOPATH is not set... setting it to the default: ~/go
|                > 	using shell env GOPATH=~/go
|                > 	using shell env GOROOT=/usr/local/Cellar/go/1.10/libexec
|                > 	using shell env PATH=~/.rvm/gems/ruby-2.5.1/bin:~/.rvm/gems/ruby-2.5.1@global/bin:~/.rvm/rubies/ruby-2.5.1/bin:~/.cargo/bin:/usr/local/bin:/usr/bin:/bin:/usr/sbin:/sbin:/opt/X11/bin:/Applications/VMware Fusion.app/Contents/Public:/usr/local/share/dotnet:/usr/local/MacGPG2/bin:/Library/Frameworks/Mono.framework/Versions/Current/Commands:/Library/TeX/texbin:/Applications/Wireshark.app/Contents/MacOS:~/bin:~/go/bin:/usr/local/go/bin:/usr/local/opt/go/bin:~/.rvm/bin
|                > 	go version: `go1.10` (raw version string `go1.10`)
|                > 	shell bootstrap took 0.369s
|                >

@gmichokostas I think  that's a different issue. The line using shell env GOROOT= suggests that you're setting GOROOT and the error suggests you're setting it to the wrong value. If that's the case, the easiest fix is probably to stop setting it.

@DisposaBoy I don't set the GOROOT manually on my machine.
echo $GOROOT returns nothing but
go go env GOROOT
/usr/local/Cellar/go/1.10.1/libexec

Another issue that I can see from the error message is, I currently have install go version 1.10.1 but the message prints a wrong version (/usr/local/Cellar/go/1.10/libexec)

@gmichokostas Maybe you have multiple versions of Go installed?
The version as printed (raw version string go1.10) comes directly from runtime.Version() https://github.com/DisposaBoy/GoSublime/blob/master/gosubl/sh-bootstrap.go#L15

@DisposaBoy
package main

import (
	"fmt"
	"runtime"
)

func main() {
	fmt.Println(runtime.Version())
}

returns
go1.10.1

@DisposaBoy I've removed and reinstalled the package and now I don't get any errors anymore.
Thanks for your comments ✌

@gmichokostas I found the issue, it was because the binary wasn't re-compiled so it contained the old Go version. It should be fixed in the latest release.


Add ability to auth with login and password

Got working auth with mosquitto.

Thanks @pastukhov ! Could you remove the commented line before I merge it in? 👍

Done, please check.

Awesome, thanks @pastukhov!


feat(STONEINTG-881): update GCL once push snapshot is created for component

Update global component list once the push snapshot is created for component, don't wait for the successful integration test any more

Maintainers will complete the following section

[ ] Commit messages are descriptive enough (hints)
[ ] Code coverage from testing does not decrease and new code is covered (check the PR coverage on codecov)
[ ] Controllers diagrams are updated when PR changes controllers code  (if applicable)

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Please upload report for BASE (main@baf4328). Learn more about missing BASE report.

:exclamation: Current head 81a5713 differs from pull request most recent head e7c73bd
Please upload reports for the commit e7c73bd to get more accurate results.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #733   +/-   ##
=======================================
  Coverage        ?   72.39%
=======================================
  Files           ?       42
  Lines           ?     4017
  Branches        ?        0
=======================================
  Hits            ?     2908
  Misses          ?      806
  Partials        ?      303

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


User facing feedback when upload filesize exceeds cloudinary upload filesize

When an asset is uploaded which exceeds Cloudinary upload filesize limit, the only feedback on the craft ui is 'A server error occurred'. Don't know how feasible it is to pass the errors back to craft but would be great to be able to tell authors why the error occurred.

The plugin is unable to relay the error message thrown by the Cloudinary adapter because the error is hardcoded in Craft's flysystem  adapter. As a workaround, you can lower the maxUploadFileSize setting in Craft to match Cloudinary's size limit. This way, Craft will display an error message about the image exceeding the allowed size.


[Code health] Introduce enum to represent base map types in MapProvider

Replace int mapType

can i collaborate?

Sure, we'd be happy to have your contributions! Please be sure to sign the CLA before getting started:
https://cla.developers.google.com/clas
If you'd like to send a small draft PR for initial comment (maybe just add comments of what you plan to add where) please go ahead.

@shobhitagarwal1612 Iirc you already did this? If so please mark as closed.


Fixed an issue with lldp

hi,this is my pr!

oh,sorry,I have changed

run create-docker-image

@qinze118 Thanks for your PR. The switch/case on the type is required for compilation on ppc64le - the job skydive-create-docker-image is failing because of this.
Are you sure this PR really fixes your problem ? (and not any other side effect)

Running on linux(centos,ubuntu) is no problem, without considering other platforms, I added your condition again and i submmited, there is no problem with local operation,please verify.

Yes,Solved my problem, there is no problem in my system(centos,ubuntu), I think cross-platform should be separated, selectively compiled according to the system

@qinze118 Ok, I understand. In the original code was modifying a local variable... so it did nothing :-)
In fact, using separated files is required to properly fix the problem.  Could you please check if it fixes the problem. If this is ok for you, I'll merge it. Thanks !

run create-docker-image

Thanks,II tried to make the next modification to be compatible with multi-platform compilation problems, by modifying the pointer to bypass the type constraint, but I did not have a platform for ppc64le to test, please test it to see if it compiles.

@qinze118 Using seperate files as you suggested is cleaner so I'm not sure the second PR is required. If the first one works for you, I suggest we merge it.
We do have a job to test compilation on ppc64le (using cross compilation) but we don't have any platform to do the real testing so we can't be sure the second PR works :-/

@qinze118 @lebauce I'm going to merge this one as I prefer to have dedicated file per arch. Thanks


Is this project dead?

https://mobile.twitter.com/mweststrate/status/1040717913592918016 :wink:

No, it's just immutable

Haha!


Auto-Hide Thumbs in Fullscreen Mode (wordpress version)

Hi All,
I've Not Fount A Way/Parameter To Auto-Hide The Thumbinails When The User Switch To Full Screen Mode...
Is It Possible? I've Found That Can Be Done In The HTML Version But I'm Unable To Understand
Where I Can Make These Changes In The Wordpress Version Since The .js Is Protected...
It Will Be Nice To Have A Value In fotoramaDefaults.js Config File Like: auto-hide-tumb: true / false / fullscreen
Later...
enone

I solved this (same issue in #422). Quite easy, if you once know how to do it. The trick is to use the events! The following script should do the trick for every fotorama container:
$('.fotorama').each(function() {
        $(this).on('fotorama:fullscreenenter', function(e, fotorama) {
            fotorama.setOptions({
                nav: false,
            });
        });

        $(this).on('fotorama:fullscreenexit', function(e, fotorama) {
            fotorama.setOptions({
                nav: 'thumbs',
            });
        });
});