 backToInitial and tabBarOnPress interaction

Version

react-native-router-flux v4.0.0-beta.28
react-native v0.53.0

Actual behaviour
I've found that if the "backToInitial" property is set for Tabs, then any function defined for the "tabBarOnPress" property is not called.
Expected behaviour
After browsing through the source code a bit, I see that "backToInitial" itself is implemented as a function set to "tabBarOnPress".  I would have expected that any function users pass into the "tabBarOnPress" property be chained together with the "backToInitial" function if both "backToInitial" and "tabBarOnPress" are set for Tabs.
At the very least, the API documentation should notify users of the current behavior.

Created a fix for this, will make a PR.
See my repo here if you need the fix ASAP.

Please try to reproduce it with Example project and latest version 4.0.0-beta.40. Feel free to open if the issue still exists

PR for better documentation to avoid this confusion for other users is welcome. But yeah, looking at the code I saw that if you define backToInitial - it's not possible to define tabBarOnPress - and keeping both handlers might be even worst (and harder to debug). I believe a warning would be fine - telling the user that the tabBarOnPress defined will be overwritten due the backToInitial flag defined.

I am pushing a PR with this change - I believe it does not hurt. :-)


npm_installer fails if packages contains server_name, causing issue with pyright

nvim --version: NVIM v0.5.0-828-g0a95549d6
NVIM v0.5.0-828-g0a95549d6
Build type: RelWithDebInfo
LuaJIT 2.1.0-beta3
Compilation: /usr/bin/gcc-5 -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=1 -O2 -g -Og -g -Wall -Wextra -pedantic -Wno-unused-parameter -Wstrict-prototypes -std=gnu99 -Wshadow -Wconversion -Wmissing-prototypes -Wvla -fstack-protector-strong -fno-common -fdiagnostics-color=auto -DINCLUDE_GENERATED_DECLARATIONS -D_GNU_SOURCE -DNVIM_MSGPACK_HAS_FLOAT32 -DNVIM_UNIBI_HAS_VAR_FROM -DMIN_LOG_LEVEL=3 -I/home/travis/build/neovim/bot-ci/build/neovim/build/config -I/home/travis/build/neovim/bot-ci/build/neovim/src -I/home/travis/build/neovim/bot-ci/build/neovim/.deps/usr/include -I/usr/include -I/home/travis/build/neovim/bot-ci/build/neovim/build/src/nvim/auto -I/home/travis/build/neovim/bot-ci/build/neovim/build/include
Compiled by travis@travis-job-abaca5c2-51e7-4cf1-bc06-8cf3e644ab24

Features: +acl +iconv +tui
See ":help feature-compile"

   system vimrc file: "$VIM/sysinit.vim"
  fall-back for $VIM: "
/home/travis/build/neovim/bot-ci/build/neovim/build/nvim.AppDir/usr/share/nvim
"

Run :checkhealth for more info

:checkhealth result
health#lspconfig#check
========================================================================
## Checking language server protocol configuration
  - ERROR: pyright: The given command "pyright-langserver" is not executable.

health#gitmessenger#check
========================================================================
  - OK: +job is available to execute Git command
  - OK: Git command `git` is available: git version 2.28.0
  - OK: Floating window is available for popup window

health#floaterm#check
========================================================================
  - OK: Terminal feature is OK
  - OK: Floating window feature is OK
  - ERROR: nvr executable is not found, run `pip3 install neovim-remote` to install

health#nvim_treesitter#check
========================================================================
## Installation
  - OK: `git` executable found.
  - OK: `cc` executable found.

## c parser healthcheck
  - OK: c parser found.
  - OK: `highlights.scm` found.
  - OK: `locals.scm` found.
  - OK: `folds.scm` found.
  - WARNING: No `indents.scm` query found for c
    - ADVICE:
      - Open an issue at https://github.com/nvim-treesitter/nvim-treesitter

## teal parser healthcheck
  - OK: teal parser found.
  - OK: `highlights.scm` found.
  - OK: `locals.scm` found.
  - OK: `folds.scm` found.
  - WARNING: No `indents.scm` query found for teal
    - ADVICE:
      - Open an issue at https://github.com/nvim-treesitter/nvim-treesitter

## java parser healthcheck
  - OK: java parser found.
  - OK: `highlights.scm` found.
  - OK: `locals.scm` found.
  - WARNING: No `folds.scm` query found for java
    - ADVICE:
      - Open an issue at https://github.com/nvim-treesitter/nvim-treesitter
  - WARNING: No `indents.scm` query found for java
    - ADVICE:
      - Open an issue at https://github.com/nvim-treesitter/nvim-treesitter

## python parser healthcheck
  - OK: python parser found.
  - OK: `highlights.scm` found.
  - OK: `locals.scm` found.
  - OK: `folds.scm` found.
  - WARNING: No `indents.scm` query found for python
    - ADVICE:
      - Open an issue at https://github.com/nvim-treesitter/nvim-treesitter

## dart parser healthcheck
  - OK: dart parser found.
  - OK: `highlights.scm` found.
  - OK: `locals.scm` found.
  - WARNING: No `folds.scm` query found for dart
    - ADVICE:
      - Open an issue at https://github.com/nvim-treesitter/nvim-treesitter
  - WARNING: No `indents.scm` query found for dart
    - ADVICE:
      - Open an issue at https://github.com/nvim-treesitter/nvim-treesitter

## lua parser healthcheck
  - OK: lua parser found.
  - OK: `highlights.scm` found.
  - OK: `locals.scm` found.
  - OK: `folds.scm` found.
  - OK: `indents.scm` found.

## ocaml parser healthcheck
  - OK: ocaml parser found.
  - OK: `highlights.scm` found.
  - OK: `locals.scm` found.
  - OK: `folds.scm` found.
  - WARNING: No `indents.scm` query found for ocaml
    - ADVICE:
      - Open an issue at https://github.com/nvim-treesitter/nvim-treesitter

## go parser healthcheck
  - OK: go parser found.
  - OK: `highlights.scm` found.
  - OK: `locals.scm` found.
  - OK: `folds.scm` found.
  - WARNING: No `indents.scm` query found for go
    - ADVICE:
      - Open an issue at https://github.com/nvim-treesitter/nvim-treesitter

## json parser healthcheck
  - OK: json parser found.
  - OK: `highlights.scm` found.
  - WARNING: No `locals.scm` query found for json
    - ADVICE:
      - Open an issue at https://github.com/nvim-treesitter/nvim-treesitter
  - WARNING: No `folds.scm` query found for json
    - ADVICE:
      - Open an issue at https://github.com/nvim-treesitter/nvim-treesitter
  - WARNING: No `indents.scm` query found for json
    - ADVICE:
      - Open an issue at https://github.com/nvim-treesitter/nvim-treesitter

## jsdoc parser healthcheck
  - OK: jsdoc parser found.
  - OK: `highlights.scm` found.
  - WARNING: No `locals.scm` query found for jsdoc
    - ADVICE:
      - Open an issue at https://github.com/nvim-treesitter/nvim-treesitter
  - WARNING: No `folds.scm` query found for jsdoc
    - ADVICE:
      - Open an issue at https://github.com/nvim-treesitter/nvim-treesitter
  - WARNING: No `indents.scm` query found for jsdoc
    - ADVICE:
      - Open an issue at https://github.com/nvim-treesitter/nvim-treesitter

## php parser healthcheck
  - OK: php parser found.
  - OK: `highlights.scm` found.
  - OK: `locals.scm` found.
  - OK: `folds.scm` found.
  - WARNING: No `indents.scm` query found for php
    - ADVICE:
      - Open an issue at https://github.com/nvim-treesitter/nvim-treesitter

## html parser healthcheck
  - OK: html parser found.
  - OK: `highlights.scm` found.
  - OK: `locals.scm` found.
  - WARNING: No `folds.scm` query found for html
    - ADVICE:
      - Open an issue at https://github.com/nvim-treesitter/nvim-treesitter
  - WARNING: No `indents.scm` query found for html
    - ADVICE:
      - Open an issue at https://github.com/nvim-treesitter/nvim-treesitter

## typescript parser healthcheck
  - OK: typescript parser found.
  - OK: `highlights.scm` found.
  - OK: `locals.scm` found.
  - OK: `folds.scm` found.
  - WARNING: No `indents.scm` query found for typescript
    - ADVICE:
      - Open an issue at https://github.com/nvim-treesitter/nvim-treesitter

## fennel parser healthcheck
  - OK: fennel parser found.
  - OK: `highlights.scm` found.
  - OK: `locals.scm` found.
  - WARNING: No `folds.scm` query found for fennel
    - ADVICE:
      - Open an issue at https://github.com/nvim-treesitter/nvim-treesitter
  - WARNING: No `indents.scm` query found for fennel
    - ADVICE:
      - Open an issue at https://github.com/nvim-treesitter/nvim-treesitter

## query parser healthcheck
  - OK: query parser found.
  - OK: `highlights.scm` found.
  - OK: `locals.scm` found.
  - WARNING: No `folds.scm` query found for query
    - ADVICE:
      - Open an issue at https://github.com/nvim-treesitter/nvim-treesitter
  - WARNING: No `indents.scm` query found for query
    - ADVICE:
      - Open an issue at https://github.com/nvim-treesitter/nvim-treesitter

## cpp parser healthcheck
  - OK: cpp parser found.
  - OK: `highlights.scm` found.
  - OK: `locals.scm` found.
  - OK: `folds.scm` found.
  - WARNING: No `indents.scm` query found for cpp
    - ADVICE:
      - Open an issue at https://github.com/nvim-treesitter/nvim-treesitter

## regex parser healthcheck
  - OK: regex parser found.
  - OK: `highlights.scm` found.
  - WARNING: No `locals.scm` query found for regex
    - ADVICE:
      - Open an issue at https://github.com/nvim-treesitter/nvim-treesitter
  - WARNING: No `folds.scm` query found for regex
    - ADVICE:
      - Open an issue at https://github.com/nvim-treesitter/nvim-treesitter
  - WARNING: No `indents.scm` query found for regex
    - ADVICE:
      - Open an issue at https://github.com/nvim-treesitter/nvim-treesitter

## verilog parser healthcheck
  - OK: verilog parser found.
  - OK: `highlights.scm` found.
  - WARNING: No `locals.scm` query found for verilog
    - ADVICE:
      - Open an issue at https://github.com/nvim-treesitter/nvim-treesitter
  - WARNING: No `folds.scm` query found for verilog
    - ADVICE:
      - Open an issue at https://github.com/nvim-treesitter/nvim-treesitter
  - WARNING: No `indents.scm` query found for verilog
    - ADVICE:
      - Open an issue at https://github.com/nvim-treesitter/nvim-treesitter

## ruby parser healthcheck
  - OK: ruby parser found.
  - OK: `highlights.scm` found.
  - OK: `locals.scm` found.
  - WARNING: No `folds.scm` query found for ruby
    - ADVICE:
      - Open an issue at https://github.com/nvim-treesitter/nvim-treesitter
  - WARNING: No `indents.scm` query found for ruby
    - ADVICE:
      - Open an issue at https://github.com/nvim-treesitter/nvim-treesitter

## ocamllex parser healthcheck
  - OK: ocamllex parser found.
  - OK: `highlights.scm` found.
  - WARNING: No `locals.scm` query found for ocamllex
    - ADVICE:
      - Open an issue at https://github.com/nvim-treesitter/nvim-treesitter
  - WARNING: No `folds.scm` query found for ocamllex
    - ADVICE:
      - Open an issue at https://github.com/nvim-treesitter/nvim-treesitter
  - WARNING: No `indents.scm` query found for ocamllex
    - ADVICE:
      - Open an issue at https://github.com/nvim-treesitter/nvim-treesitter

## ql parser healthcheck
  - OK: ql parser found.
  - OK: `highlights.scm` found.
  - OK: `locals.scm` found.
  - WARNING: No `folds.scm` query found for ql
    - ADVICE:
      - Open an issue at https://github.com/nvim-treesitter/nvim-treesitter
  - WARNING: No `indents.scm` query found for ql
    - ADVICE:
      - Open an issue at https://github.com/nvim-treesitter/nvim-treesitter

## rust parser healthcheck
  - OK: rust parser found.
  - OK: `highlights.scm` found.
  - OK: `locals.scm` found.
  - WARNING: No `folds.scm` query found for rust
    - ADVICE:
      - Open an issue at https://github.com/nvim-treesitter/nvim-treesitter
  - WARNING: No `indents.scm` query found for rust
    - ADVICE:
      - Open an issue at https://github.com/nvim-treesitter/nvim-treesitter

## toml parser healthcheck
  - OK: toml parser found.
  - OK: `highlights.scm` found.
  - OK: `locals.scm` found.
  - WARNING: No `folds.scm` query found for toml
    - ADVICE:
      - Open an issue at https://github.com/nvim-treesitter/nvim-treesitter
  - WARNING: No `indents.scm` query found for toml
    - ADVICE:
      - Open an issue at https://github.com/nvim-treesitter/nvim-treesitter

## bash parser healthcheck
  - OK: bash parser found.
  - OK: `highlights.scm` found.
  - OK: `locals.scm` found.
  - WARNING: No `folds.scm` query found for bash
    - ADVICE:
      - Open an issue at https://github.com/nvim-treesitter/nvim-treesitter
  - WARNING: No `indents.scm` query found for bash
    - ADVICE:
      - Open an issue at https://github.com/nvim-treesitter/nvim-treesitter

## rst parser healthcheck
  - OK: rst parser found.
  - OK: `highlights.scm` found.
  - OK: `locals.scm` found.
  - WARNING: No `folds.scm` query found for rst
    - ADVICE:
      - Open an issue at https://github.com/nvim-treesitter/nvim-treesitter
  - WARNING: No `indents.scm` query found for rst
    - ADVICE:
      - Open an issue at https://github.com/nvim-treesitter/nvim-treesitter

## css parser healthcheck
  - OK: css parser found.
  - OK: `highlights.scm` found.
  - WARNING: No `locals.scm` query found for css
    - ADVICE:
      - Open an issue at https://github.com/nvim-treesitter/nvim-treesitter
  - WARNING: No `folds.scm` query found for css
    - ADVICE:
      - Open an issue at https://github.com/nvim-treesitter/nvim-treesitter
  - WARNING: No `indents.scm` query found for css
    - ADVICE:
      - Open an issue at https://github.com/nvim-treesitter/nvim-treesitter

## ocaml_interface parser healthcheck
  - OK: ocaml_interface parser found.
  - OK: `highlights.scm` found.
  - OK: `locals.scm` found.
  - OK: `folds.scm` found.
  - WARNING: No `indents.scm` query found for ocaml_interface
    - ADVICE:
      - Open an issue at https://github.com/nvim-treesitter/nvim-treesitter

## javascript parser healthcheck
  - OK: javascript parser found.
  - OK: `highlights.scm` found.
  - OK: `locals.scm` found.
  - OK: `folds.scm` found.
  - WARNING: No `indents.scm` query found for javascript
    - ADVICE:
      - Open an issue at https://github.com/nvim-treesitter/nvim-treesitter

## c_sharp parser healthcheck
  - OK: c_sharp parser found.
  - OK: `highlights.scm` found.
  - WARNING: No `locals.scm` query found for c_sharp
    - ADVICE:
      - Open an issue at https://github.com/nvim-treesitter/nvim-treesitter
  - WARNING: No `folds.scm` query found for c_sharp
    - ADVICE:
      - Open an issue at https://github.com/nvim-treesitter/nvim-treesitter
  - WARNING: No `indents.scm` query found for c_sharp
    - ADVICE:
      - Open an issue at https://github.com/nvim-treesitter/nvim-treesitter

health#completion_nvim#check
========================================================================
## general
  - OK: neovim version is supported

## completion source
  - OK: all completion source are valid

## snippet source
  - INFO: You haven't setup any snippet source.

health#nvim#check
========================================================================
## Configuration
  - OK: no issues found

## Performance
  - OK: Build type: RelWithDebInfo

## Remote Plugins
  - OK: Up to date

## terminal
  - INFO: key_backspace (kbs) terminfo entry: key_backspace=\177
  - INFO: key_dc (kdch1) terminfo entry: key_dc=\E[3~
  - INFO: $VTE_VERSION='6201'
  - INFO: $COLORTERM='truecolor'

health#provider#check
========================================================================
## Clipboard (optional)
  - OK: Clipboard tool found: wl-copy

## Python 2 provider (optional)
  - INFO: pyenv: Path: /var/home/kamal/.pyenv/libexec/pyenv
  - INFO: pyenv: Root: /var/home/kamal/.pyenv
  - WARNING: No Python executable found that can `import neovim`. Using the first available executable for diagnostics.
  - ERROR: Python provider error:
    - ADVICE:
      - provider/pythonx: Could not load Python 2:
          /usr/bin/python2 does not have the "neovim" module. :help |provider-python|
          /usr/bin/python2.7 does not have the "neovim" module. :help |provider-python|
          python2.6 not found in search path or not executable.
          /var/home/kamal/.pyenv/shims/python is Python 3.9 and cannot provide Python 2.
  - INFO: Executable: Not found

## Python 3 provider (optional)
  - INFO: pyenv: Path: /var/home/kamal/.pyenv/libexec/pyenv
  - INFO: pyenv: Root: /var/home/kamal/.pyenv
  - WARNING: No Python executable found that can `import neovim`. Using the first available executable for diagnostics.
  - ERROR: Python provider error:
    - ADVICE:
      - provider/pythonx: Could not load Python 3:
          /var/home/kamal/.pyenv/shims/python3 does not have the "neovim" module. :help |provider-python|
          python3.10 not found in search path or not executable.
          /usr/bin/python3.9 does not have the "neovim" module. :help |provider-python|
          /var/home/kamal/.pyenv/shims/python3.8 does not exist: pyenv: python3.8: command not found

          The `python3.8' command exists in these Python versions:
          3.8.6

          Note: See 'pyenv help global' for tips on allowing both
          python2 and python3 to be found.

          /var/home/kamal/.pyenv/shims/python3.7 does not exist: pyenv: python3.7: command not found

          The `python3.7' command exists in these Python versions:
          3.7.4
          3.7.6

          Note: See 'pyenv help global' for tips on allowing both
          python2 and python3 to be found.

          python3.6 not found in search path or not executable.
          /var/home/kamal/.pyenv/shims/python does not have the "neovim" module. :help |provider-python|
  - INFO: Executable: Not found

## Python virtualenv
  - OK: no $VIRTUAL_ENV

## Ruby provider (optional)
  - WARNING: `ruby` and `gem` must be in $PATH.
    - ADVICE:
      - Install Ruby and verify that `ruby` and `gem` commands work.

## Node.js provider (optional)
  - INFO: Node.js: v14.14.0
  - WARNING: Missing "neovim" npm (or yarn) package.
    - ADVICE:
      - Run in shell: npm install -g neovim
      - Run in shell (if you use yarn): yarn global add neovim

## Perl provider (optional)
  - ERROR: perl provider error:
    - ADVICE:
      - "Neovim::Ext" cpan module is not installed

nvim-lsp version(commit hash): 1f86bfd62d0ba78b0479373661be3fa13f1f8f35
What language server(If the problem is related to a specific language server): pyright
Operating system/version: Fedora 33
Terminal name/version: Gnome Terminal 3.38.1
$TERM: xterm-256color

How to reproduce the problem from neovim startup
:LspInstall pyright
Actual behaviour
Fails to install pyright with npm error ENOSELF:
Error: Refusing to install package with name "pyright" under a package
also called "pyright". Did you name your project the same
as the dependency you're installing?

Expected behaviour
Successfully installs pyright.

Musings
I don't think this is a problem with the pyright config, but rather with the npm installer. I think it should force the package name in package.json to be something different from the server_name.
Some ideas on how to do this:

ensure the server_name is not equal to any of the packages
modify the package.json generated by npm init -y to have a unique name
write out package.json ourselves instead of using npm init
just skip having a package.json altogether

Option 1 is easier: just append some deterministic or constant noise to the install_dir. Option 2 results in a cleaner filesystem hierarchy, but we're in the .cache directory so it probably doesn't matter. Option 3 is pretty clean. Option 4 actually works, which I did not expect:
$ cd $(mktemp -d)
$ npm install --no-package-lock --no-save pyright
npm WARN enoent ENOENT: no such file or directory, open '/tmp/tmp.MEzVJz5DN2/package.json'
npm WARN tmp.MEzVJz5DN2 No description
npm WARN tmp.MEzVJz5DN2 No repository field.
npm WARN tmp.MEzVJz5DN2 No README data
npm WARN tmp.MEzVJz5DN2 No license field.

+<EMAIL_ADDRESS>added 1 package from 1 contributor in 0.956s
found 0 vulnerabilities

$ ls
node_modules
$ node_modules/.bin/pyright --version
pyright 1.1.86

Closing because of #334.


Cook County, GA

We already have this source, but seems stale - maybe we should see if this is valuable?
Parcels and Addresses
http://www.sgrcmaps.com/arcgis/rest/services/Cook/CookParcels/MapServer

Here's some analysis.
Original static source
The original source is static and hosted by OA.  It has 11,318 entries, of which 6,629 have non-zero house number and non-zero-length house number and street.  The original source has to use regexes for house number and street.  Of those 6,629 entries, there are some with obviously invalid street names, like:

-83.3787498,31.0283441,6840,E COUNTY LINE & 6900 RD,,,,ga,,,0f122bbd3e27cc50
-83.3029372,31.0324168,11,BLOCK B LOT,,,,ga,,,42cbadd7f7be6c47

New ESRI source
The ESRI source has 8,319 entries, of which 8,292 have non-zero house number and non-zero-length house number and street.  I couldn't find any obvious invalid street names.
Conclusion
I'm calling this an improvement.


Send ETH to contract address.

Hi,
I need to send ETH to contract address..But am getting issue as failed to fetch gas estimate.
My code:
    let walletAddress = keystoreManager.addresses![0]

    let contractABI = Web3Utils.erc20ABI // Contract ABI
    let contractAddressVal = EthereumAddress(contractAddress)!
    let abiVersion = 2 // Contract ABI version
    let contract = web3Main.contract(contractABI, at: contractAddressVal, abiVersion: abiVersion)!
    let amount = Web3.Utils.parseToBigUInt(value, units: .eth)
    var options = TransactionOptions.defaultOptions
    options.value = amount
    options.from = walletAddress
    options.gasPrice = .manual(BigUInt("10000000000"))
    options.gasLimit = .manual(BigUInt("70000"))

    let tx = contract.write()!

    do {
        let transaction = try tx.send(password: "", transactionOptions: options)
        print("output", transaction)
    } catch(let err) {
      print("err", err)
    }

    Please help to sort this issue....

Please have a look documentation section about this case:
send-ether

Hi Please check below code

Convert receiver address into Ethereum string

                `let toaddress = EthereumAddress(self.receiverAddressString ?? "")`

Create web3 options

                `var sendTransactionIntermediateOptions = Web3Options.defaultOptions()`

Convert amount into BIGINT

                `let amountDouble = BigInt((Double(sendigTokenCount) ?? 1.0)*pow(10, 18))`
                `print("Total amount in double value : ", amountDouble)`

Convert amount in BigUInt

                `let amount = BigUInt.init(amountDouble)`

get gas price
let estimateGasPrice = try wInstance.eth.getGasPrice()                     guard let contractString = self.contractAddressString else {                         print("Unable to get contract address")                         return                     }

Create your contract address as EthereumAddress

               `let contractAddress = EthereumAddress(contractString)
                guard let eGasReult = self.estimatedGasResult else {
                    print("Unable to find gas")
                    return
                }`

Get nonce

                print("estimated gas : ", eGasReult)
                let fee = estimateGasPrice * eGasReult
                print("Is the Transaction fees ", fee)

                 adding
                 - sender address
                 - Gas Result
                 - Gas price
                 - amount

                `sendTransactionIntermediateOptions.from = senderEthAddress`
                `sendTransactionIntermediateOptions.gasLimit = eGasReult`
                `sendTransactionIntermediateOptions.gasPrice = estimateGasPrice`

Strat your Transaction with contract

                `var tokenTransactionIntermediate: TransactionIntermediate!`

tokenTransactionIntermediate = try wInstance.contract(Web3.Utils.yourABIString, at: contractAddress).method("transfer", args: toaddress, amount, options: sendTransactionIntermediateOptions)

thanks @ravi-ranjan-oodles  for the detailed comments.
It would be great if you can improve the documentation in this way. I would be happy to make a bounty for this task - just let me know if you are interested in (or make a PR)! 👍

Sure @skywinder, I am Interested updating the Documentation.

Hi, I have updated the documentation and made a pull request with the name
veer chauhan.
Hope for a bounty :D for this coming year :D
Thanks
Ravi Ranjan**Sr. Associate Consultant - Development
_______________________________________________________
https://www.oodlestechnologies.com/
+91<PHONE_NUMBER>live:.cid.ba8be0ea7047f0b5www.oodlestechnologies.com |
www.oodlesmarketing.com | www.oodlesstudio.comUnit No. 159, Tower B1, Spaze
I-Tech Park, Sector 49, Sohna Road, Gurgaon, India, 122018[image: Facebook
icon] https://www.linkedin.com/in/rranjanchchn/ [image: Youtbue icon]
https://www.facebook.com/OodlesTech [image: LinkedIn icon]
https://twitter.com/ciggret_hai
On Thu, Dec 31, 2020 at 12:48 PM Petr Korolev<EMAIL_ADDRESS>wrote:

thanks @ravi-ranjan-oodles https://github.com/ravi-ranjan-oodles for
the detailed comments.
It would be great if you can improve the documentation in this way. I
would be happy to make a bounty for this task - just let me know if you are
interested in (or make a PR)! 👍
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/matter-labs/web3swift/issues/259#issuecomment-752873551,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/APADMZHYVF5VRMPXIZGOTYTSXQQVJANCNFSM4MG4W2QA
.


Settings Dialog: aViewer becomes non-reponsive/hangs on Windows 7

aViewer becomes non-responsive if I open the Settings window and attempt to change any settings (see screenshot below):

The Windows dialog that appears has the following information about the error:

Description:
A problem caused this program to stop interacting with Windows.
Problem signature:
Problem Event Name:	AppHangB1
Application Name:	aViewer.exe
Application Version:	<IP_ADDRESS>
Application Timestamp:	58de0cda
Hang Signature:	bcc2
Hang Type:	0
OS Version:	6.1.76<IP_ADDRESS>.256.4
Locale ID:	1033
Additional Hang Signature 1:	bcc21320a354a490c52571a6d3952e86
Additional Hang Signature 2:	237a
Additional Hang Signature 3:	237acb176da410d9ef3397fa1ef5313a
Additional Hang Signature 4:	bcc2
Additional Hang Signature 5:	bcc21320a354a490c52571a6d3952e86
Additional Hang Signature 6:	237a
Additional Hang Signature 7:	237acb176da410d9ef3397fa1ef5313a
Read our privacy statement online:
http://go.microsoft.com/fwlink/?linkid=104288&clcid=0x0409
If the online privacy statement is not available, please read our privacy statement offline:
C:\WINDOWS\system32\en-US\erofflps.txt

Cannot repro on Windows 10. Just to check, could you unregister and reregister the DLL from that dialog, then close and reopen aViewer?

@patrickhlauke Unfortunately, for me on Windows 7, it seems to happen no matter what I do once the Settings window is opened.
I just tried to unregister the DLL. After I clicked the Unregister button with my mouse and then tried to click anywhere else in the window and the Settings window became non-responsive.

I forced aViewer to close, reopened and went to the Settings window, clicked the Register button with my mouse and then tried to click anywhere else in the window and the Settings window became non-responsive again.

I forced aViewer to close again, reopened and went to the Settings window and then immediately clicked the Cancel button. The Settings window did not close as expected and when I tried to click anywhere in the parent aViewer window then it again became non-responsive.

Same issue occurred if I tried to click the OK button immediately after opening the Settings window.
Same issue occurred if I open aViewer and just try tabbing with the keyboard into the interactive elements in the Settings window.

Fixed in 2.0.3


Update nl-NL.coffee

Some more translations for the dutch language.
Another merge request of the previous changes. We don't know what went wrong last time.

Thank you, @Justinschut


External JDBC user store as the primary user store of the OSIAM

Can we connect a external JDBC user store as the primary user store of OSIAM rather than using the internal one? If yes could you suggest me some documentation where I can follow to get it done?

Hello @Vindulamj,
At the moment the only connector we provide is one for LDAP. We don't really have plans to create one for external JDBC data stores, since we don't have the need for it. We would not not be opposed to add one to the project if you (or somebody else) came up with one, though.
Regards,
---Florian

Hi @wallner
Thanks for the quick info. Currently I am evaluating the OSIAM for a project. I will consider about what you have said.
Regards,
-Vindula

Hello @Vindulamj,
thank you for evaluating OSIAM, I'm closing this issue for now. Please don't hesitate to open another one any time.
Regards,
---Florian


building boundaries misshape

Not sure if this issue is just location specific. Or else a bigger issue - almost all these areas are messed up.

It just looks like the imagery is not aligned properly, and captured "off nadir" (at an angle).
The building footprints looks like they are carefully traced, so you should use the "Background Imagery" pane to see if there is another source of imagery in that area that better matches the data...
You can also choose the best imagery layer and manually offset it to match the existing data - scroll to the bottom of the imagery pane, and use the "Adjust Imagery Offset" widget to slide the imagery to a better offset.


Split spack software and libs

Checklist

[x] Developer's Guide has been updated
[ ] Documentation has been built locally and changes look as expected
[ ] Testing comment in the PR documents testing used to verify the changes

Testing
On Chrysalis, I did both Gnu and Intel test builds with spack, showing that they used the same software environment (built with Intel).  I used these environments to run:

the pr suite
the cosine bell tests with viz
the ISOMIP+ Ocean0 planar test at 4-km resolution (which tests ESMF)

All tests were successful.


Add version property

In order to check the library's version at runtime, it would be nice to have a version property, similar to how Vue does it

Done in v0.3.1

Thank you!

Keep 'em coming!


refactor/common_qa_speak

move the self.speak call to the skill class where it belongs
a companion PR should remove the hardcoded speak from core

core PR needs to go first so we can pin version here


Release new version of dependency-check plugin to avoid a dependency linked to CVE-2022-42889

Hello Guys,
We would like to know when the next release of Dependency Check Maven Plugin is planned ? We would like to have a release with apache-commons-text upgraded to 1.10.0 to avoid CVE-2022-42889.
thx, best regards

the release is in progress and will be available today.

thx for the quick reply & release !


add wchar string type

#include "log_sink_etw.c"

... and then I heard that it doesn't build in the gate, so I will be waiting until

comments here are addressed
the gate builds

ping me when I need to look at it again.

Refers to: v2/tests/log_sink_etw_ut/log_sink_etw_mocked.c:41 in 0ae1072. [](commit_id = 0ae1072057710a67eca9b455b8188bbe1ba23cf0, deletion_comment = False)


stop bot from creating a sticker from a sticker

so whenever a user sends a sticker in the group, the bot tries to generate a sticker for it.
it doesn't actually create a sticker from a sticker, but just that its bothersome
is there a way to stop it trying to create a sticker from  a sticker?

so i found a fix i guess here: #48 check in commits
changed my code to match and it doesnt generate a sticker when someone sends a sticker now.
closing off
sorry for the trouble


docs: add Dart/Flutter library setup documentation

Fixes #845

Good job, looking forward to it!

Hi, this PR is getting pretty close to done (just have a few pages left to write), so if you want to take a quick first look at the PR (since it is getting pretty massive), thoughts/recommendations would be welcome!
Here's what I have left to write before I would consider this PR done:

[ ] dart_only.md
[ ] flutter_wrapper.md
[ ] melos.md

In the future, it'd probably be a good idea for someone to make a mason brick to simplify the process of creating a library with FRB. A lot of the setup instructions documented here are boilerplate, but some also talk about how/why things work the way they do.

@fzyzcjy Ready for review!

In the future, it'd probably be a good idea for someone to make a mason brick to simplify the process of creating a library with FRB. A lot of the setup instructions documented here are boilerplate, but some also talk about how/why things work the way they do.

IIRC @Desdaemon has made a brick for the non-library case btw

@fzyzcjy Ready for review!

Reviewing!

@all-contributors please add @GregoryConrad  for doc

@all-contributors please add @GregoryConrad for code
(given that there are quite a bit of scripts in the doc - IMHO they should be categorized as code)


LoadReacCompNetwork importers

Adding support for loading reaction network from complex stoichiometric and complex incidence matrix.

hi @isaacsas , do these checks fail because on some issue with package dependency or something like using old versions ? I couldn't figure out what this is as i think test_mats.jl tests did pass

I will try to incorporate these changes soon!

hi @isaacsas , changed as per your suggestions.. please review !


[Input] Adornment overwrites width from fullWidth

[x] I have searched the issues of this repository and believe that this is not a duplicate.

Expected Behavior

Expecting fullWidth to make the input take up the full width of its container, even when it has the startAdornment property.
Current Behavior

Adornment overwrites the width property.

Steps to Reproduce (for bugs)

      <Input
        fullWidth
        startAdornment={<InputAdornment position="start"><SearchIcon /></InputAdornment>}
        placeholder="Input"
        disableUnderline
      />

This component would provide us an input where the width is set to auto by InputAdornment class.
Context

Your Environment

Tech
Version

Material-UI
1.0.0-beta.18

React
16

browser
Chrome

Duplicate of #8825


Correct Euler's totient function in all cases

It's obviously never good to have p == q, but when this happens we need
to compute the correct version of Euler's totient function. In fact when
phi(p•q) == phi(p) • phi(q) only when p and q are coprime.
phi(pk) = pk - p**(k-1)
So when p == q we have phi(p2) = p2 - p

This wikipedia page that explains this property is this.


[Fix]: Added Backticks to python version, as mentioned in the livestream (https://www.youtube.com/watch?v=_JjV9n-G-p0)

@all-contributors add @sreekaransrinath for docs

@all-contributors add @sreekaransrinath for docs


[TC-OCC-1.1] Script missed to validate the optional attributes in AttributeList.

Description:

[ ] TC-OCC-1.1 - In Step 4 Script missed to validate the optional attributes in AttributeList.

Steps to reproduce:
Step 4
Spec References:

https://github.com/CHIP-Specifications/connectedhomeip-spec/blob/master/src/app_clusters/OccupancySensing.adoc#5-attributes

Yaml - Script References:

https://github.com/project-chip/connectedhomeip/blob/master/src/app/tests/suites/certification/Test_TC_OCC_1_1.yaml

Additional Info:
Raised Test plan Issue for the same :- https://github.com/CHIP-Specifications/chip-test-plans/issues/2891
Once the Test plan is fixed script has to be updated

@Ashwinigrl fixed in PR 30869 please verify it and close the ticket.

Issue Fixed


Multiple docstrings reference geoarrow.rust.core instead of geoarrow.rust.io

There are a few places which mention importing functionality from geoarrow.rust.core which seems to have been moved to geoarrow.rust.io and this line that mentions the depreciated GeoTable.
I'd be happy to put in a PR to update the docstrings and remove the reference to GeoTable

Ah, thanks for the note! Yes, a PR to update those references would be greatly appreciated!


CurrentFwVersion missing from Aug 2020 release

What should the below values be for the latest firmware update?
Component10CurrentFwVersion updated to ?
Component20CurrentFwVersion updated to ?
Thanks!

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 4841f8c9-98e1-7d39-d4fc-39f034e9f534
Version Independent ID: 3df9714b-c602-0825-d70c-2971e37c1987
Content: Microsoft Surface Dock Firmware Update - Technical information for IT administrators - Surface
Content Source: surface/surface-dock-firmware-update.md
Product: w10
Technology: windows
GitHub Login: @greg-lindsay
Microsoft Alias: greglin

Seems to be a duplicate of #27

Seems to be a duplicate of #27


dataset and training issue

there is no src.scripts.generate_dataset under scripts to generate data , and when running python -m src.scripts.train_variability, it occurs that raise Exception("Raw File List Not Found"), which means there is no raw_files.txt under raw file, but i don't konw where to find it or how to generate, could you help me with these two problems, thanks!

Thank you for pointing this out! Should be fixed as of #5 .


UI Elements sometimes have holes?

Lately I've been noticing that some UI Elements (mainly chat & large HUD Elements) seems to have some sort of holes in them. I'm unsure if this is caused by playing with high resolution or if it's an issue with the mod's code. This only seems to mainly affect bold letters and/or large HUD Elements. When turning the mod off the issues were gone. And just if you need it: I'm playing with 2560x1440 Resolution.

Font smoothing set to 0% seems to fix it


Feature #17 sonar

SonarQube analysis reported 3 issues

 1 major
 2 minor

Watch the comments in this conversation to review them.
1 extra issue
Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

 intentiallyMadeMistakeForSonarToFindOut.java: Move this file to a named package.


Babel and ES6 Utilities Class

looks like the tests is actually failing, could you take a look? @seyeojumu
https://travis-ci.org/yahoo/guerilla/jobs/116933560

CLA is valid!

Unit test fixed. Please take a look and merge it maybe. :smile:

Made a couple changes based on information from here. Something to be aware of -- the tests seem to take much longer to run now; especially on v0.12.
Maybe we should probably re-organize the package.json a little bit -- create a build target so that the transpiling happens only once?

the tests does seem taking longer than before on travis, on my computer it seems fine.
do you mean we could check in the compiled javascript (from babel)?
in webstorm *-compiled.js.map and *-compiled.js would be generated if i set up a watcher.
but i felt like it is too webstorm-specific and i just ignored them.


Error: GetWinsize: inappropriate ioctl for device

Getting this error on a MIPS based device.

root@localhost:/usr/bin# gomtr <IP_ADDRESS>
Start: 2019-02-20 19:24:20.633342142 +0000 UTC m=+0.019848589
Error: GetWinsize: inappropriate ioctl for device
Error: GetWinsize: inappropriate ioctl for device
Error: GetWinsize: inappropriate ioctl for device
Error: GetWinsize: inappropriate ioctl for device
Error: GetWinsize: inappropriate ioctl for device
Error: GetWinsize: inappropriate ioctl for device
Error: GetWinsize: inappropriate ioctl for device
Error: GetWinsize: inappropriate ioctl for device
Error: GetWinsize: inappropriate ioctl for device
Error: GetWinsize: inappropriate ioctl for device
Error: GetWinsize: inappropriate ioctl for device
Error: GetWinsize: inappropriate ioctl for device
Error: GetWinsize: inappropriate ioctl for device
Error: GetWinsize: inappropriate ioctl for device
Error: GetWinsize: inappropriate ioctl for device
Error: GetWinsize: inappropriate ioctl for device
Error: GetWinsize: inappropriate ioctl for device
Error: GetWinsize: inappropriate ioctl for device
Error: GetWinsize: inappropriate ioctl for device
Error: GetWinsize: inappropriate ioctl for device
Error: GetWinsize: inappropriate ioctl for device
Error: GetWinsize: inappropriate ioctl for device
Error: GetWinsize: inappropriate ioctl for device
Error: GetWinsize: inappropriate ioctl for device
Error: GetWinsize: inappropriate ioctl for device
Error: GetWinsize: inappropriate ioctl for device
Error: GetWinsize: inappropriate ioctl for device
Error: GetWinsize: inappropriate ioctl for device
Error: GetWinsize: inappropriate ioctl for device

Think this was fixed in this patch:
https://github.com/buger/goterm/commit/2f70ee476a85f692e8d4265963c615d8a57652da
Edit:
I can confirm that updating buger/goterm and golang.org/x/sys/unix fixes the issue.

Okay, great. I'll update vendor ;)


Too many redirects with docker.elastic.co/kibana/kibana:5.4.0

I am just testing an elk setup for our logging system and running into some issue with the officially recommended image docker.elastic.co/kibana/kibana:5.4.0. I have a super simple Kubernetes setup, that starts the image behind a load balancer and when trying to access to service on it's IP address Chrome is giving me ERR_TOO_MANY_REDIRECTS. However if I switch back to the deprecated image hosted on docker kibana:5.4.0 all works fine. So I wonder, what is the difference between the two? And why is the new official image doing these redirects? (I am also seeing it tries to go to the path /login, which the docker hub image is not doing).

Hello @Globegitter ,
The docker.elastic.co images are prebundled with x-pack and as a result of that, x-pack security, among other features is enabled.
To take advantage of this you should be also running docker.elastic.co/elasticsearch/elasticsearch:5.4.0 in your cluster.
Relates: https://github.com/elastic/kibana-docker/issues/27

Hi @dliappis Thanks for the reply and yes, I am still using the hub.docker.com elasticsearch image. But since the issue really seems to lie with X-Pack I think this can be closed in favour of #27.

any clue to disable this broken feature quickly (maybe a ENV to set when docker run)?
I got:
➜  ~ http --header "http://localhost:5601/"
HTTP/1.1 302 Found
kbn-version: 5.4.1
location: /login?next=%2F

➜  ~ http --header "http://localhost:5601/login?next=%2F"
HTTP/1.1 302 Found
kbn-version: 5.4.1
location: /

How can we disable this **** broken x-pack feature ? (I see redirection from / to login to / to login etc...)

@ebuildy Are both elasticsearch and kibana from docker.elastic.co? Have you disabled x-pack on any of them?
Disabling xpack on elasticsearch requires passing: - xpack.security.enabled=true
Disabling xpack on kibana using env vars requires: - XPACK_SECURITY_ENABLED=true
See also https://github.com/elastic/kibana-docker/issues/27#issuecomment-296524205 on how to create a customized Kibana image without x-pack.

Yep sorry, this did the trick, thank you

update the
kibana.yml

elasticsearch.url:
server.host:
if you changed the password ..update here too
elasticsearch.username: "elastic"
elasticsearch.password: "changeme"

restart the kibana service


INTELGPU: Fix names duplication of generated supporting primitives fo…

…r Convolution* operations

Of course, I've checked that resnet20 is functional. It works.
But model cannot be trained because total_loss is equal nan after several iterations. The issue is in clDNN primitives and will be solved on clDNN side.


'bool' object has no attribute 'getitem'

Expected Behavior
Bot ran just fine for the past 12 hours. Now starting it results in an immediate crash.
Actual Behavior
[2016-07-28 07:18:22] [x] PokemonGO Bot v1.0
[2016-07-28 07:18:22] [x] Configuration initialized
[2016-07-28 07:18:22]
[2016-07-28 07:18:22] [x] Address found: Wapato Park
[2016-07-28 07:18:22] [x] Position in-game set as: (47.1962005, -122.4553895, 0.0)
[2016-07-28 07:18:22]
Traceback (most recent call last):
File "pokecli.py", line 220, in
main()
File "pokecli.py", line 206, in main
bot.start()
File "C:\Users\Joseph\PokemonGo-Bot\pokemongo_bot_init_.py", line 31, in start
self.setup_api()
File "C:\Users\Joseph\PokemonGo-Bot\pokemongo_bot_init.py", line 151, in _setup_api
player = response_dict['responses']['GET_PLAYER']['player_data']
TypeError: 'bool' object has no attribute 'getitem'
Steps to Reproduce
Just run the bot.
Other Information
OS: Windows 10
Git Commit: c7ab5b03cb93b5393bebbc383545a50e8519e57a

Servers are acting iffy. Already discussed in https://github.com/PokemonGoF/PokemonGo-Bot/issues/915
I have confirmed myself that writing a small script to keep retrying to login will eventually work.

The file I created didn't delete and I just had to delete it to make the bot work correctly.

Try this batch script:
@echo off
:begin
pokecli.py
timeout 180
goto begin

Then how am I able to log on from my mobile device?

@Messingaround2323 what file?

¯_(ツ)_/¯
Try the script for a while and see if it works for you like it did for myself.

I do have a batch script similar to yours. Only difference is mine sleeps for 5 instead of 180.

Disregard. There was a zombie cmd process running in the background I had to kill.


As a developper I want the random pop up box to no longer display

It seems that at random times the original developper of this app decided to include a random pop up box about purchasing the pro version of the Simple apps suits. This needs to be removed from the app since all of our tests are being screwed up.

Fixed in PR #29 by forking and modifying 'simple-commons' library.


first commit renato-souza

@naruto112 Please sign the Contributor License Agreement!
Click here to manually synchronize the status of this Pull Request.
See the FAQ for frequently asked questions.

ok

Congratulations on your first commit, but this change doesn't improve the guide.


NDRS-1010: Don't create a new era when we should shutdown for an upgrade.

https://casperlabs.atlassian.net/browse/NDRS-1010

It passed the utils/nctl/sh/scenarios/sync_upgrade_test.sh integration test.

bors r+


Update takeoff_and_land.cpp

‘Success’ is not a member of ‘mavsdk::Action::Result’
Modified to SUCCESS

Thanks for the pull request. Unfortunately, this is the wrong way round. If you are using the examples of this repo with the last installed release you need to use the master branch.
With the develop branch and the next release there are quite a few changes coming up due to the auto-generation of part of the C++ side from proto files.
Here are some of the changes described: https://github.com/mavlink/MAVSDK-docs/pull/191
Sorry for the confusion and we are working towards having a new release very soon.

Thanks for the pull request. Unfortunately, this is the wrong way round. If you are using the examples of this repo with the last installed release you need to use the master branch.
With the develop branch and the next release there are quite a few changes coming up due to the auto-generation of part of the C++ side from proto files.
Here are some of the changes described: mavlink/MAVSDK-docs#191
Sorry for the confusion and we are working towards having a new release very soon.

Thank you for your advice!


Running Backstage with only one Database

Hello,
we are evaluating Backstage for our Company. As we are in a very regulated Environment it is not possible for our technical Database Useres to create Databases.
So we get a Database from our DBAs and have to use this specific one.
Is there a way to setup Backstage to run with only one Database for all Plugins and Data?
And how can we configure this?
If this is not jet possible:

Is there some place that documents all DBs needed for the core implementation? So we can setup the corresponding amount of DBs
Please make it a feature request.
In stead of having a DB per Plugin the Tablenames could be prefixed with the Pluginnames.

Thanks for your help

Hmm, table names are not configurable unfortunately. However you can configure each plugin to use a different connection string here? https://backstage.io/docs/tutorials/configuring-plugin-databases so maybe they could also use the same db.
You can also use schemas instead of database by providing config in the app-config.yaml if that would help you instead?

@benjdlambert are there any docs or examples your aware of on the usage of schemas?

Hmm - I don't think that there is explicit docs on this unfortunately. But it's just config you can set in your app-config.yaml when using the pg client.
https://github.com/backstage/backstage/blob/master/packages/backend-common/config.d.ts#L86-L98

So your app-config.production.yaml or wherever you setup client: pg under the database key would look something like this:
  database:
    client: pg
    pluginDivisionMode: schema
    connection:
      host: ${POSTGRES_HOST}
      port: ${POSTGRES_PORT}
      user: ${POSTGRES_USER}
      password: ${POSTGRES_PASSWORD}
   ...

Thanks for this Informations. @benjdlambert pluginDivisionMode made the trick I needed 👍
Can this be added to the official Documentation?

I raised this: https://github.com/backstage/backstage/pull/13104


Support nested repos in non-repo project folder

Currently the gutter seems only to be working if the project root is a git repo. Please also support non-repo-root-folders with nested repos. I'm using this constellation at work because we have notes and other files which should not be in the (e.g. customer) repos.

Hmm.. this will be covered here, right? https://github.com/atom/atom/issues/2203

@oktayacikalin Saw this on a clean-up pass I'm doing. Yes, atom/atom#2203 is where this will get resolved. I'll close this Issue as duplicate. You may want to subscribe to the other Issue for updates.


[NRKTV] Added support for downloading series in their entirety.

Before submitting a pull request make sure you have:

[x] At least skimmed through adding new extractor tutorial and youtube-dl coding conventions sections
[x] Searched the bugtracker for similar pull requests

In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:

[x] I am the original author of this code and I am willing to release it under Unlicense

What is the purpose of your pull request?

[x] Improvement
[x] New extractor

Description of your pull request and other information
Added support for downloading series in their entirety (playlist download of series).
Added season_number and episode_number metadata extraction.
See #11571
If there are any issues preventing merging, please tell me what I did wrong, as this is my first time contributing to the project.

Squash commits.

Got some quick instructions for doing so handy?
On January 28, 2017 1:52:17 PM GMT+01:00, "Sergey M."<EMAIL_ADDRESS>wrote:

Squash commits.
--
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub:
https://github.com/rg3/youtube-dl/pull/11711#issuecomment-275846613

--
Sent from my Android device with K-9 Mail. Please excuse my brevity.

@dstftw like so?
For later reference; git rebase aka squash - http://stackoverflow.com/a/6934882/1035647

For later reference; git rebase aka squash

I'm well aware of that. Squashing is your responsibility.

@dstftw I am not familiar with the nuances of git, nor the desire to delete commit history just for the sake of compressing it. I clearly stated that this was my first time contributing to the project, and "squashing" of commits was not referred to anywhere in the guidelines provided. First time I heard of the term was your "Squash commits." - two weeks after contributing code to the project. A more friendly "Could you squash the commits?" would've been far preferable. I do realize that you likely have much work to do elsewhere, but if compressing into a single commit was the only blocker, I would've appreciated to know about this within a few days of my contribution - which was made to the project guidelines on best efforts and intentions, because this was functionality I desired, and thought others would find it useful also.
Your comments don't come off as particularly friendly, and does not really inspire to further contributions to the project. I have other improvements in mind, but might not bother submitting pull-requests if this is what I'll be meet with. Having this project being well maintained is in everyone's best interest, and having new and potential future contributors turned off the idea of contributing is a receipt for a slow project death. Please, just have a think about it.
The SO link was provided for later reference for myself or anyone else who might stumble upon this issue with the same question. It is clear that you knew what it was, as you where telling me to do it.
It is however not my responsibility to "squash" commits. I didn't have to do any of this. I did it for the love of a great tool, which I wanted to make better. I did however not have to provide those improvements back to the public or this project, I did so because I deeply believe in the concept of open-source, and in sharing with others.
As I understand source control, it is best practice to commit changes right after you've made them and have gotten it working. Not putting off the commits indefinitely, as that promotes commit messages as "I did stuff half a year ago, no idea what..", "asdf" (relevant XKCD; https://xkcd.com/1296/).
If "squashing" of commits is desirable, and required for accepting pull-requests, it should be noted in CONTRIBUTING.md, somewhere before "10. Finally, create a pull request. ..."
I hope that the above makes sense, and doesn't come off as too offensive.
Best Regards
Odd Stråbø / Oddstr13

Squashing is the basics of git and easily googleable. I assume anyone who file a PR to be able to use google. It's not possible to document just everything so you'll have to google something anyway.
Sorry about the unfriendly text if that hurt you so much. I'm minimizing my time spent on issues and reviewing so my messages are brief and concise (apart from some common phrases I have macros setup for).

I do realize that you likely have much work to do elsewhere, but if compressing into a single commit was the only blocker, I would've appreciated to know about this within a few days of my contribution

I did not look into it until 2 days ago. Sorry but I technically can't handle all the issues and reviews on time since this project is voluntary developed in spare time.

Your comments don't come off as particularly friendly, and does not really inspire to further contributions to the project. I have other improvements in mind, but might not bother submitting pull-requests if this is what I'll be meet with.

 But as for me such statement sounds more like you do not care about open source. If I want to contribute, I just contribute regardless of how I'm met or some other nonsense.

It is however not my responsibility to "squash" commits.

No, it's exactly your responsibility. Once you're contributing to the something, it's you responsibility to follow the coding conventions and guidelines and it's you responsibility to provide PR in a form that fits better for merge.

I didn't have to do any of this. I did it for the love of a great tool, which I wanted to make better. I did however not have to provide those improvements back to the public or this project, I did so because I deeply believe in the concept of open-source, and in sharing with others.

Well, you didn't have to publish it, yes. But once you decided to do so in a form of a PR you have to accept the rules and follow them.

If "squashing" of commits is desirable, and required for accepting pull-requests, it should be noted in CONTRIBUTING.md, somewhere before "10. Finally, create a pull request. ..."

It's not exactly that. It's desirable to have a commit per a feature or some ready functionality. On the other hand it's not desirable to have a mess of commits when one is fixing code according to review. Even in the latter case squashing is only desired in the end after everything or almost everything is fixed. There is no need to squash every time, otherwise it's impossible to track changes made during PR.

I would like to apologize for being a little grumpy.
I do see the need for being time efficient when it comes to issues on such a large project as this.
Is there any more work that needs to be done before this can be merged, or is everything good as it is right now?

PS C:\Dev\youtube-dl\master> py -3.5 .\test\test_all_urls.py
...F.............
======================================================================
FAIL: test_no_duplicates (__main__.TestAllURLsMatching)
----------------------------------------------------------------------
Traceback (most recent call last):
  File ".\test\test_all_urls.py", line 98, in test_no_duplicates
    '%s should not match URL %r . That URL belongs to %s.' % (type(ie).__name__, url, tc['name']))
AssertionError: True is not false : NRKTVSeriesIE should not match URL 'https://tv.nrk.no/serie/20-spoersmaal-tv/MUHH48000314/23-05-2014' . That URL belongs to NRKTV.

----------------------------------------------------------------------
Ran 17 tests in 13.054s

FAILED (failures=1)


Can't login to editor.p5js.org

Actual Behaviour
When typing in my username and password and pressing "Log In" on https://editor.p5js.org/login, I'm not redirected to a new page. Instead the "Log In" button is disabled, so I can't push it a second time, and nothing else happens.
I have included logs from JS console below together with a screenshot.
Expected Behaviour
Expecting that I'm getting logged in and redirected to the editor.
Steps to reproduce it

Open either Firefox (v. 89.0) or Safari (13.0.1)
Open https://editor.p5js.org/login
Enter your username and password
Click with the mouse on "Log In"

Screenshots of the issue
Screenshot attached, and error messages from JS console included below.

XHRGEThttps://editor.p5js.org/editor/session
[HTTP/3 404 Not Found 302ms]

GET
	https://editor.p5js.org/editor/session
Status404
Not Found
VersionHTTP/3
Transferred882 B (36 B size)
Referrer Policystrict-origin-when-cross-origin

    access-control-allow-credentials
    	true
    alt-svc
    	h3-27=":443"; ma=86400, h3-28=":443"; ma=86400, h3-29=":443"; ma=86400, h3=":443"; ma=86400
    cf-cache-status
    	DYNAMIC
    cf-ray
    	67663f2e0959735f-CPH
    content-length
    	36
    content-type
    	application/json; charset=utf-8
    date
    	Thu, 29 Jul 2021 12:10:55 GMT
    etag
    	W/"24-wRuFiqDiWqJZxk2aPimqOrIMcUA"
    expect-ct
    	max-age=604800, report-uri="https://report-uri.cloudflare.com/cdn-cgi/beacon/expect-ct"
    nel
    	{"report_to":"cf-nel","max_age":604800}
    report-to
    	{"endpoints":[{"url":"https:\/\/a.nel.cloudflare.com\/report\/v3?s=WZEN6%2BOn9MiL9TtxnJENWnjewWDWdpXw3Lthf3sd6NwaADkMZL3XgKlrGc6BwH6ZtbYECqmsvba%2BZ%2FRPGtQjb1fHG3eZ2ADKeGAY1ObfzBMquTyNh1fP2sSNGfFAQLdKwdQ%3D"}],"group":"cf-nel","max_age":604800}
    server
    	cloudflare
    vary
    	Origin
    via
    	1.1 google
    x-powered-by
    	Express

    Accept
    	application/json, text/plain, */*
    Accept-Encoding
    	gzip, deflate, br
    Accept-Language
    	da,en-US;q=0.7,en;q=0.3
    Alt-Used
    	editor.p5js.org
    Cache-Control
    	max-age=0
    Connection
    	keep-alive
    Cookie
    	sessionId=s%3AkuIfHn5p7eFJ2c3bI7jy6aj6XZwbYDhI.nfUd2ZVB1s1buxQLgoU%2ByVlIQxsjAfVtv%2F6WlhrJJHc
    Host
    	editor.p5js.org
    Referer
    	https://editor.p5js.org/login
    Sec-GPC
    	1
    TE
    	Trailers
    User-Agent
    	Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:89.0) Gecko/20100101 Firefox/89.0

XHRPOSThttps://editor.p5js.org/editor/login
[HTTP/3 401 Unauthorized 684ms]

POST
	https://editor.p5js.org/editor/login
Status401
Unauthorized
VersionHTTP/3
Transferred948 B (43 B size)
Referrer Policystrict-origin-when-cross-origin

    access-control-allow-credentials
    	true
    access-control-allow-origin
    	https://editor.p5js.org
    alt-svc
    	h3-27=":443"; ma=86400, h3-28=":443"; ma=86400, h3-29=":443"; ma=86400, h3=":443"; ma=86400
    cf-cache-status
    	DYNAMIC
    cf-ray
    	67663f480a51735f-CPH
    content-length
    	43
    content-type
    	application/json; charset=utf-8
    date
    	Thu, 29 Jul 2021 12:10:59 GMT
    etag
    	W/"2b-LNOPSj36zBLYs/FYlqqUmbnJGls"
    expect-ct
    	max-age=604800, report-uri="https://report-uri.cloudflare.com/cdn-cgi/beacon/expect-ct"
    nel
    	{"report_to":"cf-nel","max_age":604800}
    report-to
    	{"endpoints":[{"url":"https:\/\/a.nel.cloudflare.com\/report\/v3?s=f7lHCv2lzSrlFSvkabYzrx27T9n0vGnqGHD9TcJx%2FpLIdbfScZU9Czrr8uR%2BO8lWAMYRXGyuIIwZjH1iXXJxTwRTCZayguZ3RjbZYxvsxLx3CTzwlh%2Fgcg1keN%2FrNWNouiA%3D"}],"group":"cf-nel","max_age":604800}
    server
    	cloudflare
    vary
    	Origin
    via
    	1.1 google
    x-powered-by
    	Express

    Accept
    	application/json, text/plain, */*
    Accept-Encoding
    	gzip, deflate, br
    Accept-Language
    	da,en-US;q=0.7,en;q=0.3
    Alt-Used
    	editor.p5js.org
    Connection
    	keep-alive
    Content-Length
    	44
    Content-Type
    	application/json;charset=utf-8
    Cookie
    	sessionId=s%3AkuIfHn5p7eFJ2c3bI7jy6aj6XZwbYDhI.nfUd2ZVB1s1buxQLgoU%2ByVlIQxsjAfVtv%2F6WlhrJJHc
    Host
    	editor.p5js.org
    Origin
    	https://editor.p5js.org
    Referer
    	https://editor.p5js.org/login
    Sec-GPC
    	1
    TE
    	Trailers
    User-Agent
    	Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:89.0) Gecko/20100101 Firefox/89.0

Would you like to work on the issue?
No, I'm not able to, I'm sorry.

Same errors on Safari:

This is the repo for p5js.org while the code for the editor is maintained in a different repo so you might want to file it there instead. Thanks.

Okay, I have created a new issue over there and will close this one.


How about 1.4?

1.3 was released May, 2011. There have been 34 commits (as of now) since that release. Why not tag a 1.4 so we can take advantage of those without worrying about (unstable) changes to master?

I've tagged in a 1.3.1.
1.4 will probably involve me saying "enough with the old-IE support!" and dropping the VML paths.


Excluding on-premise entries from search results with Sharepoint search REST API?

Category

[x] Question
[ ] Typo
[ ] Additional article idea

Question
How do I exclude on-premise entries from my search results?
I'll need to do so for multiple clients, and since these are my client's tenants I can't add / modify their search settings.
Ideally I can add a keyword or tweak a flag when querying and the search API will exclude on-premise results from the response, but I can't identify any flags in https://docs.microsoft.com/en-us/sharepoint/dev/general-development/sharepoint-search-rest-api-overview that seem to do this.
If that's impossible,  I can also retrieve on-premise and Sharepoint Online results and then somehow filter out the on-premise results using some of the returned properties, but I don't know if there's a reliable way to do so for different tenants.
Environment details (development & target environment)

Target Environment: SharePoint Online
Additional details: The tenant is an on-premise and Sharepoint Online hybrid environment

What about filtering by domain? If the domain is *.SharePoint.com, it's SPO... otherwise it's on-prem?

NOT (IsExternalContent:1) should do the trick for hybrid crawled content. Docs at https://docs.microsoft.com/en-us/sharepoint/hybrid/configure-cloud-hybrid-searchroadmap#about-the-isexternalcontent-managed-property


Minor issue, format readme.

Delete extra space in Magic section, formatted.

Merged into #1255, thanks!


karate test with multipart/mixed

I upgraded the library version to 1.0.1, but I faced an issue.
I'm going to test an API that requires both multipart file and multipart files.
The scenario should be with the Content-Type = 'multipart/mixed'. However, it fails.
As shown in the below example, multipart/mixed is run with @mock-servlet-todo.
https://github.com/intuit/karate/blob/ae199b270b9f566847d275760d779456ff7d5289/karate-demo/src/test/java/demo/upload/upload.feature#L65
In 1.0.1, it does not work??

@yunjoopark it doesn't work for the mock-servlet - but should work fine in "normal" cases. anyway please follow this process: https://github.com/intuit/karate/wiki/How-to-Submit-an-Issue
we spent a lot of time asking users to try RC versions. you may need to continue using an old version - but contributing code and help speed up a release

Does multipart/mixed work?

@yunjoopark it is supposed to work. but maybe there is a bug. so the answer is "I don't know". the best thing you can do is follow the process in the link above so that we can fix the issue. does that make sense ?


WIP DNM Fix the kuttl zuul jobs

A few needed changes:

add the missing required manila-operator project;
fix the URL of the manila-operator-index generated
by the content-provider job.

Depends-On: https://github.com/openstack-k8s-operators/ci-framework/pull/2556

recheck

recheck

recheck

recheck

recheck

recheck


Scores on-chain always end in 5

We assumed the lines coming from rundown would always include .5 to avoid ties. As it turns out this isn't always true so we need to add that .5 when we receive scores from the link node.
Specifically, we increase the spread distance by .5. So a positive (or zero) spread becomes larger and a negative spread becomes smaller. So 4 becomes 4.5 and -6 becomes -6.5.
The total score will simply increase by 0.5.
Right now the UI adds 0.5 to the spread and total score. This will no longer be necessary.

[ ] Contract work
[ ] UI work

Clarification: The score will ONLY be altered when it would otherwise be a whole number. So 60 becomes 65 but 65 is unchanged.
I assume that a weird score like 61 is intentionally that way so it is not altered. The actual scores in games are for whole points so there should be no functional difference between a target spread 6.1 and one of 6.5


🚧 API: ReadableStreamGenericReader

Context
Specification: Streams
Specification interface: Interface ReadableStreamGenericReader
Additional documentation:

mdn docs
Cloudflare workers docs
Boa documentation

Expected TypeScript interface
TODO

@johnyob this one exist onto https://streams.spec.whatwg.org/ and used by readers, for example byob reader. But it wasn't referenced onto your excel.
I create the issue because I think you built the list from deno, but deno diverge from specification. Please close it if necessary cc @xavierm02

Valid internal component


Displays wrong currency symbol for angular-locale_es-mx.js

This locale displays € instead of the $ symbol which is the correct currency symbol for
the Mexican Peso

The currency symbol in Closure is correct (https://github.com/google/closure-library/blob/master/closure/goog/i18n/numberformatsymbols.js#L1258) maybe the Angular i18n generator is wrong.

We recently updated the locale files from the latest closure. It looks to me like the es-mx locale has the correct currency symbol now: https://github.com/angular/angular.js/blob/master/src/ngLocale/angular-locale_es-mx.js#L79

Great, I just need to figure out why CDNJS project is not getting the update. That's why I came here :smile:
Thank you

We have to do it manually when we notice that the closure project has released a new version.

Looks like CDNJS has not been updated with a recent version of Angular for years

I see, any good CDN to get Angular?

We publish all our releases to the Google CDN: For example: ajax.googleapis.com/ajax/libs/angularjs/1.4.2/angular.js


Renovate Development Board and Development Practices

Description
Since the inception of the Cotheca Project, GitHub has refined its Projects feature into a more robust Project Management suite. The current implementation of the Development practices remains practical, solid, and flexible. However, there have been some areas for the initial The Cotheca Docs Release milestone where it has been somewhat difficult to track progress. From a Project Management point of view, this is concerning. The truth is that I have not been able to keep up as much as I have wished on setting up this documentation resource. Obviously, that's part of the point of the whole Cotheca Project.
There are so many things that I want to accomplish for these code libraries, for both my open source work and for personal closed source work. But the Cotheca Project isn't just about the code.
While the Cotheca Project talks about making code reusable, the truth is that setting an organizational foundation is required for any projects, and that on its own is one of the points about the project. The bureaucratic side of Software Development is highly needed and should be in place in each organization. Any code author knows that in most organizations, that doesn't happen.
By pointing this out within an organization, you can even be marked or pointed out as the "inexperienced" junior who has no idea how the "real" world programs and has utopian ideas on how the world should work, but can't happen due to a huge amount of reasons. This is not necessarily true. It might be true that it is too late for such an organization, but not for development in general. Whether it is in the name of practicality or just the denial of handling the overwhelming requirements for a proactive and future-proof development, the truth is that most code authors decide to cut this cornerstone for better development. And the thing is that I do believe in those utopian practices because it's exactly the experience of working on my own old projects after a while where I have no idea why I did what I did (I mean, I get the logic and the code, but not the actual why), or other projects that, of course, I can read through the code and will be able to understand how it works, but the point is that with proper practices I could have gotten started right away by just looking at documentation, diagrams, or any other knowledge resources, and have a pretty solid idea of what needs to be achieved within minutes, instead of spending days on trying to understand it by reading the code or stepping through it in a debugger. Ironically, most of the people who embrace the "documentation is the code" mentality (without actual documentation or comments in the code) are the same kind of people who struggle to integrate common third-party systems or libraries and later complain about how inconvenient the poor documentation for such a system is.
Well, that's exactly what the Cotheca Docs project is trying to provide: a re-usable framework of practices to unburden the bureaucratic side of Project Management while establishing good practices for the Cotheca Project as an organization from the start, rather than start developing things that aren't going to work as universally as they could, for the rest of the Cotheca Project.
With that said, I want to make an example out of this open source project, on how taking the proper measures can be overwhelming as they are for a code author. Because, honestly, this is not what I picture the project to be stuck on for over a year, and there are so many projects that I would prefer to be programming, instead of acting all bureaucratic, but I do believe these are necessary steps for solid projects, at Cotheca, on my personal projects, and hopefully for other people. Hopefully, this project gets enough grip so all this time and effort that I've put into these documents help someone or some organization not spend a year on this, but rather a fraction of that time by just adjusting these documents to their taste, or even better, to help me improve mine in their process of establishing their own. Even if we don't agree on the methodology, I might be able to find value in their work and adopt it too, just in the same way they could have found value in some part of this methodology. That's what Cotheca is about.
Possible Solution(s)
Remove individual projects for sprints. That doesn't mean that we stop working in iterations, but rather, how we integrate this on multiple repositories at once and how we can break projects into multiple iterations. Originally the idea behind the "Sprint" GitHub projects, was to track how long something was idle, under development or took to be completed.
GitHub has improved drastically the features within its Projects features to do this more efficiently.
The development board is going to be the one project used, but will implement different views and integrate practices to be able to track development stages for multiple projects or repositories at once, while still being able to track other management-related KPIs to make progress measurable for anyone.
We are going to re-adjust The Cotheca Docs Release milestone dates to be more realistic to the amount of work that it requires. Originally, the Cotheca Docs were supposed to be an outline to follow for projects, but ever since October 25th, 2022. It has housed so many different useful things and reference resources and have expanded more on the kind of information that it hosts. That's improved my overall project management skills and has centralized some reference files like templates and other notes and practices that it's been highly useful to me, and it's still only at a fraction of it's first deliverable state. So, I rather finish it to it's 1.0.0 version before even trying to develop actual code.
These changes should make more approachable to accomplish the goal of having a foundational resource for any software project.
Objectives
Please specify what the finished feature should accomplish (one or more objectives):

[x] Create a feature branch 'feature-27-RenovateDevelopmentBoard' and link it to this issue.
[ ] #28

Status

Field name: Status
Field type: Single Select
Options:

"New" (re-use existing one if available)
This item hasn't been started.
"Blacklog" (re-use existing one if available)
This item is actively being worked on
"Done" (re-use existing one if available)
This item has been completed

Priority

Field name: Priority
Field Type: Single select
Options:

Urgent (re-use existing one if available)
High (re-use existing one if available)
Medium (re-use existing one if available)
Low (re-use existing one if available)

Size

Field name: Size
Field type: Single select
Options:

X-Large (re-use existing one if available)
Large (re-use existing one if available)
Medium (re-use existing one if available)
Small (re-use existing one if available)
Tiny (re-use existing one if available)

Category

Field name: Category
Field type: Single select
Options:

Product/Project Management (re-use existing one if available)
Feature (re-use existing one if available)
Bug (re-use existing one if available)
Support (re-use existing one if available)

Target Date

Field name: Target Date
Field type: Date

Start Date

Field name: Start Date
Field type: Date

Sprint
Field name: Sprint
Field type: Iteration
Iterations:

2-week long
Start on closest Monday when the Cotheca Docs project was first created
Add past sprints up to the present day
Add at least the iterations a year quarter period for future (planned) sprints

[ ] #29

Remove current view "By size"
Add "Current Sprint" view
A simplified view of what's planned for the sprint, whether is going to be worked on, it's being currently worked on, or what has been completed.
Renovate "Backlog" view
Re-use existing Backlog view. This view will display all of the PBI's and reflect their development state. We are no longer going to have individual sprint projects, but rather we will use the GitHub projects feature of "iterations" instead. The backlog should integrate this feature in a meaningful informative way.
Add "Sprint Blockers" view
A quick view of items that aren't blocked, but are blocking other items and are part of the current sprint.
Add "Roadmap" view
The historic map of how items are planned and resolved, pretty much timeline view of the Backlog
Renamed "By priority" view to "Prioritization"
Same concept as the existing view, but in a better way to organize multiple projects and this should be a helpful tool alongside the new "Unassigned Blockers" view to organize PBI's in more efficient way.
Add "Blockers" view
A simplified view of the existing blockers, not just for the sprint, but for the whole Cotheca project. This are the PBI items that have been identified as dependencies that need to be resolved in order to let other backlog items to be completed. This should help identify bottle necks and prevent further blockers. Also, this would help break down large PBI items into smaller tasks, along with the use of milestones, this should report an accurate state of a milestone, and provide a realistic outlook for the completion of the milestone.
Add "Unassigned Blockers" view
A simplified way to identify blockers that hasn't been assigned or isn't being worked on. The overall goal is to keep this on zero items.
Add "Unassigned" view
Pretty much the same as the "backlog" view, but showing items that haven't being assigned. This will always have new issues and are a way to help contributors to identify and take on tasks.

[ ] #30

Do not reference the old way of doing things

As matter of fact, let's remove any references to the old ways of doing things
Explain how to do things with the new methodology and how views are relevant for different tasks.

Updated development-related documentation

Update existing documentation on main branch
Update existing documentation on sub-branches

[ ] #31

Assign the Development Board to existing item's projects
Preserve old "Sprint" projects in existing items.
Assign the Start Date and Target Date for the projects based on their original sprint
Assign the latest sprint they fall into.

Merge into 'wip-1-InitialPractices' when completed. ** Do NOT merge into 'main' branch.  **

Additional Context
N/A

Blocked by:

#28
#29
#30
#31

By re-structured objectives, no longer blocked by:

#31

No longer blocked by any of:

#28
#29
#30
#31

The overall target of implementing a renewed Development Board has been achieved, since #30 is not necessarily a requirement for this issue. Issue will be closed.


GUAC Beta user service for SLSA/SBOM query service (CHIP)

A service to ingest SLSA/SBOM from the user and return results by querying the GraphQL API.
Include a set of services to help users (through a web interface), interact with GUAC.
Tracking within the repo, but this will likely be a "Chip" of GUAC.
Example UI Sketch
The GUAC Web UI

The GUAC results page with insights and navigable graph

UI is able to query for package and show a graph output. Various CLI and python scripts have been created to interact with the grapQL data.


Added force option to module:seed command

Right now, it's impossible to use the mode:seed command without interactions in a production environment.
The changes make it possible. :)

Thank you, very helpful indeed! 😄


NETOBSERV-971 Fix couple of CRD issues on zero-values

CRD cleanup / sanitizing
Find & fix a bunch of CRD issues where go zero-value was conflicting
with CRD default. The typical workaround is to use pointers or, for
lists and maps, remove "omitempty".
Add a test to help catch these issues
Found issues:

portNamings.enable (this was the original issue)
portNamings.portNames (could not set empty list)
ebpf.interfaces and excludeInterfaces (e.g. could not set empty exclusion
list)
processor.metrics.ignoreTags and disableAlerts (could not set empty
ignoreTags)
processor.enableKubeProbles, dropUnusedFields (could not set false)
processor.kafkaConsumerReplicas (could not set 0)
loki.maxRetries (could not set 0)
loki.staticLabels (could not set empty list)
plugin.register (could not set false)
plugin.replicas (could not set 0)
plugin.quickFilters (could not set empry list)

@OlivierCazade I reviewed the whole CRD ... which leads to a bigger pull request

/lgtm

/approve

/approve cancel

/label qe-approved

Rebased for merge
https://github.com/netobserv/network-observability-operator/compare/b30f2bfd2ecfb9ff6c16aa48f09bc46bfcd5c6d7..6948a3a20e1d128bfd9f7d1d003b1095795e786f

/approve


TypeError: Cannot read property 'callback' of undefined

Error message detail:
C:\Users\xxxxx\node_modules\redis\index.js:722     if (typeof command_obj.callback === 'function') {                            ^ TypeError: Cannot read property 'callback' of undefined     at normal_reply (C:\Users\xxxxx\node_modules\redis\index.js:722:28)     at RedisClient.return_reply (C:\Users\xxxxx\node_modules\redis\index.js:824:9)     at JavascriptRedisParser.returnReply (C:\Users\xxxxx\node_modules\redis\index.js:192:18)     at JavascriptRedisParser.execute (C:\Users\xxxxx\node_modules\redis-parser\lib\parser.js:574:12)     at Socket.<anonymous> (C:\Users\xxxxx\node_modules\redis\index.js:274:27)     at Socket.emit (events.js:189:13)     at addChunk (_stream_readable.js:284:12)     at readableAddChunk (_stream_readable.js:265:11)     at Socket.Readable.push (_stream_readable.js:220:10)     at TCP.onStreamRead [as onread] (internal/stream_base_commons.js:94:17)
Source code of redis client:
function normal_reply (self, reply) {     var command_obj = self.command_queue.shift();     if (typeof command_obj.callback === 'function') {         if (command_obj.command !== 'exec') {             reply = self.handle_reply(reply, command_obj.command, command_obj.buffer_args);         }         command_obj.callback(null, reply);     } else {         debug('No callback for reply');     } }
This error is happened occasionally, not all the time. I think maybe there's a bug, and should check command_obj when shift from comman queue.

Do you have this code in?
const redis = require('redis');
bluebird.promisifyAll(redis);

It is very hard to debug this. It should actually never happen. This indicates that the state is not correct anymore. Is there any way you are able to reliable trigger this error and do you have more information for me? Like a minimal code snipped, the node_redis version and the parser version, what commands you use and anything else that might be helpful to debug this.

I am also getting this error intermittently. In my case it seems that sometimes after calling "client.punsubcribe()" I am flooded with these errors until I restart the process.

"redis": "2.8.0"
node 10

Traceback is more or less identical to OP's, but for completeness:
TypeError: Cannot read property 'callback' of undefined
    at normal_reply (/snapshot/stream-node/node_modules/redis/index.js:722:28)
    at RedisClient.return_reply (/snapshot/stream-node/node_modules/redis/index.js:824:9)
    at JavascriptRedisParser.returnReply (/snapshot/stream-node/node_modules/redis/index.js:192:18)
    at JavascriptRedisParser.execute (/snapshot/stream-node/node_modules/redis-parser/lib/parser.js:574:12)
    at Socket.<anonymous> (/snapshot/stream-node/node_modules/redis/index.js:274:27)
    at Socket.emit (events.js:198:13)
    at addChunk (_stream_readable.js:287:12)
    at readableAddChunk (_stream_readable.js:268:11)
    at Socket.Readable.push (_stream_readable.js:223:10)
    at TCP.onStreamRead [as onread] (internal/stream_base_commons.js:94:17)

After running on debug mode I noticed that these errors track with connection gone from close event messages (as opposed to the more typical connection gone from end event I see during the normal idle process termination from the redis server)
redis 3.0.2 node 14.15.1, redis-parser 3


Call Tessel.setWiFiState with updated arguments

Currently, running t2 wifi --off returns the following output:
hipsterbrown:tessel-test (master) $ t2 wifi --off
INFO Looking for your Tessel...
INFO Connected to j5.
ERR! Error: Missing Wifi State: (empty).

This is due to the controller command not calling tessel.setWiFiState with the recently updated parameters.

Coverage remained the same at 79.689% when pulling 27303c03f6d1d43033a16a156f5ff542b623a3f6 on HipsterBrown:fix-wifi-state into c3bb56c280691fa40c155b19116c78a0453e384b on tessel:master.

Coverage remained the same at 79.719% when pulling 0007272b9a874750abbc0620683a6713929c29e8 on HipsterBrown:fix-wifi-state into 356a4aadb86a88b4d7dabdb068ea851ccc5fc6db on tessel:master.

Merged ddba290f86e80104121a276ea93ca2ea8c3a03f3


Await rewriteStorageUrl, log unhandled rejection

Coverage decreased (-0.03%) to 94.66% when pulling 1d5279e0240b6f1662b67dc391e53626f59a0943 on cody-unhandled-promise-rejection into 06795e10267e2929176a48902a0cf9a9462a5bec on main.


How to sign and send ERC20 token

I'm trying to send an ERC20 token using this SDK and I'm having some problems.  I am able to send ETH by signing and sending a raw transaction and it looks like to send an ERC20 token you pretty much do the same steps but you would attach the transfer method and parameters to the data property of the transaction.  The thing is I'm not exactly sure how to convert the contract method call into the Data data type.  Here is some of my code.
`//get gas price
        let tt = try Blockchain.shared().network.web3.eth.getGasPrice()
        gasPrice = BigUInt(Double(tt) * Double(1.40))
        transaction!.gasPrice = gasPrice!
        //get nonce
        let nonce = try Blockchain.shared().network.web3.eth.getTransactionCount(address: tx.from)
        transaction!.nonce = nonce

        var options = TransactionOptions.defaultOptions
        options.gasPrice = .manual(gasPrice!)
        options.from = EthereumAddress(wallet.address)
        options.value = amount
        options.nonce = .manual(nonce)

        let b = try contractAddress.method("transfer", parameters: [tx.to, amount] as [AnyObject], extraData: Data(), transactionOptions: options)`

How do I add the contract method to the transaction so I can sign and send?
`//send transaction
  try signTransaction(withWallet: wallet, transaction: &transaction!, fromAddress: tx.from)
    let _ = Blockchain.shared().network.web3.eth.sendRawTransactionPromise(transaction!)`

Excuse the forced unwrapping.
I tried
`
        var cc = try contract.method("transfer", parameters: [tx.to, amount] as! [AnyObject], extraData: Data(), transactionOptions: options)?.assemble()
        try signTransaction(withWallet: wallet, transaction: &cc!, fromAddress: tx.from)
        let b = try Blockchain.shared().network.web3.eth.sendRawTransactionPromise(cc!).wait()`

This transaction I can verify on the blockchain, but it is a transfer of 0eth to the erc20 contract address.  it doesn't actually transfer the token to the intended destination.
//
Found an old issue in the old repository that said to use the add the keystone and use the convience function
   ` guard let store: BIP32Keystore = BIP32Keystore(wallet.data) else {
            throw DError.Keys.keyStoreError
        }
        let keystoreManager = KeystoreManager([store])
        Blockchain.shared().network.web3.addKeystoreManager(keystoreManager)
        let result = try Blockchain.shared().network.web3.eth.sendERC20tokensWithKnownDecimals(tokenAddress: tokenAddress, from: tx.from, to: tx.to, amount: amount)?.sendPromise().wait()

        print(result)`

nodeError(desc: "The method eth_sendTransaction does not exist/is not available")
Is the error I received after doing that.  I traced the error to the keystore not being nil.  Is this a bug or am I doing something wrong?
I was doing something wrong.  I was saving the keystone to one instance and checking it on another.
new code looks like this.
`
                                         let web3 = Blockchain.shared().network.web3

                                          let keystoreManager = KeystoreManager([store])

                                         web3.addKeystoreManager(keystoreManager)

                                           let result = try web3.eth.sendERC20tokensWithKnownDecimals(tokenAddress: tokenAddress, from: tx.from, to: tx.to, amount: BigUInt(1))?.sendPromise(password: "", transactionOptions: nil).wait()
                   print(result) `

It sends and I can verify it on blockchain, but it doesn't transfer the token from one address to another.  Its a transaction for 0ether to the token contract address.

Ended up being an issue with the token I was using.


Removed scroll glow and fixed errors caused during build

Related Issue

Fixes #32

Proposed Changes

Removed scroll glow from the root file
Fixed errors causing build to fail

@D-Ajay-Kumar The code is good, but you solved another issue regarding the profile screen. I'll merge another PR regarding that. You can remove the other files regarding the profile and settings screen.

Yeah, those files were causing build to fail so I had to fix them to test run the app. How do I remove those files or the changes in those files?


getting all pinned messages from a chat

Is there a simpler way of getting all pinned messages from a chat without calling getChatHistory and going through each message and checking whether "isPinned" is set to true?
Thanks in advance

For this and similar queries searchChatMessages with appropriate filter is supposed to be used.

For this and similar queries searchChatMessages with appropriate filter is supposed to be used.

Great, thank you!


Show a progress bar on LabelModel.fit

Is your feature request related to a problem? Please describe.
When fitting a LabelModel with hundreds of labeling functions and thousands of datapoints, it can take several minutes to complete. When calling fit() on my LabelModel, I currently have no clue how many epochs were already processed nor an estimated ETA (even if verbose is set to True).
Describe the solution you'd like
When calling LabelModel().fit(), a tqdm progress bar would be displayed and updated after each epoch. This would at least be shown if verbose=True
Describe alternatives you've considered
time library and print statements
Additional context
Snorkel version: snorkel==0.9.6
Run in Jupyter lab

Is this possible?

Is this possible?


Add custom event listener to trigger handler manually.

Resolves #94. Use-case detailed there. Tests included.
Example:

item

And in your controller, when you need to manually trigger the scroll check:
$scope.$emit('anEventName')

We got there eventually. Build passes!

Even if we're adding too much attributes that seems great ! Thanks @neoeno

:+1: I did think that about the attributes actually! Couldn't think of an alternative though.
Would you like a PR for the docs?

If you can do it it'd be great !
Btw, I'll work on a 2.0 version where every issues is resolved and without so much attributes :)


Small fix for Orbiter v1.2.1

cicd: remove duplicate pre-commit check
fix: pre-serialize dag dict for jq

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 91.07%. Comparing base (6092f76) to head (ecb0f64).
Report is 20 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #16      +/-   ##
==========================================
+ Coverage   90.95%   91.07%   +0.12%
==========================================
  Files          13       13
  Lines         431      437       +6
==========================================
+ Hits          392      398       +6
  Misses         39       39

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Updating Toaster z-index

Description

Updating z-index of toaster so it shows on top of the rest of the page

Current State

Fixed State

👍


Do not rewrite on any namespaced destination tags

Currently we do not re-write exit_to tags when there is a destination tag present on ways.
This changeset makes the check even more conservative: we no longer re-write if there is any destination* tag present. Which includes destination:ref, destination:street or any other namespaced destination tag.
The reason for doing so is it's highly likely that the destination information is already present in the namespaced destination tag and we want to be conservative in these cases.
Ref. https://github.com/osmcode/libosmium/issues/210

@MoKob adapted - please have a look again and 👍 or 👎 the review.


Implicit FSharp.Core reference is not considered

Description
If I create new FSharp project, FSharp.Core library is referenced implicitly unless DisableImplicitFSharpCoreReference is set to true, but it isn't by default. Look for FSCorePackageVersion at \dotnet\sdk\5.0.101\FSharp\Microsoft.FSharp.NetSdk.props for details.
I will lose this reference by using paket for package restore after installing any package to the project.
Repro steps
Dotnet version: 5.0.101
Paket version: 5.257.0

Execute dotnet new console -lang F# -n Repro

Execute dotnet build
Reference to FSharp.Core is there yet. Check out contents of project.assets file in the obj folder, you'll see  "FSharp.Core/5.0.0" under the "libraries" node. Library is copied to bin folder and is present as reference in the output Repro.dll.

Execute paket init (Suppose that we have it globally)

Add any package to the .fsproj file. Let it be NewtonSoft.Json

Execute paket add NewtonSoft.Json
Create paket references file containing the only line, which is NewtonSoft.Json

Execute paket install
You'll see F# project Repro\Repro.fsproj does not reference FSharp.Core.

Execute dotnet build
FSharp.Core reference is gone: it's not present in project.assets anymore, it's not present in the newly generated Repro.fsproj.paket.props, it's not copied to the bin folder, but is still referenced by the generated dll, though could not be found.

Execute dotnet run
You'll see

Unhandled exception.
   Cannot print exception string because Exception.ToString() failed.

Instead of expected
Hello world from F#

Expected behavior
FSharp.Core package is referenced and copied to the bin folder.
Actual behavior
FSharp.Core is missing, causing runtime error.
Known workarounds
Add FSharp.Core manually by running paket add FSharp.Core and putting it to the project's paket.references file.

Just leaving this here in case somebody finds this issue and is facing the same cause that I did:
I had (because the dotnet paket init created it like this) this in my paket.dependencies:
source https://api.nuget.org/v3/index.json

storage: none
framework: netcoreapp3.1, netstandard2.0, netstandard2.1

Changing this to
source https://api.nuget.org/v3/index.json

storage: none
framework: auto-detect

made things work.

I'm just running into this very same issue and after being puzzled for a little while (I removed the FSharp.Core explicit references, but I kept having compile errors) I noticed this line in the .paket\Paket.Restore.targets files:
    <!-- Disable automagic references for F# DotNet SDK -->
    <!-- This will not do anything for other project types -->
    <!-- see https://github.com/fsharp/fslang-design/blob/master/tooling/FST-1002-fsharp-in-dotnet-sdk.md -->
    <DisableImplicitFSharpCoreReference>true</DisableImplicitFSharpCoreReference>
    <DisableImplicitSystemValueTupleReference>true</DisableImplicitSystemValueTupleReference>

This is probably because I created this project using the instructions of https://github.com/fsprojects/FSharp.TypeProviders.SDK/ (i.e. the "official" SDK for type providers), but those templates do not work well with VS 2022 (it just errors on loading the project). It also fixes the FSharp.Core version to 4.7-ish.
Removing it, only just lead to Paket putting it back. Not sure what's going on here or how to fix it... Sorry for blurring the thread with the comment, it's just in case someone has a solution or comes across the cause of this bug.


Fix tests, fix Celery, extend tests

@lnielsen As promised, here's the PR.

The first commit fixes a failure in the tests by sharing the application context between all tests.
The second introduces the feature I was interested in: compatibility with Celery + MessagePack.
The third does what you asked me to do: shows that there's limited support for attachments and dates.

@jacquerie Thanks a lot for fixing it. The change to send_email looks good to me. However, I'm surprised if the test with attachments works async (and, if it works then you could likely send a message through e.g. rabbitmq on a couple of MBs).
I think the PR is probably good as is, but we should add an issue to add async tests (e.g. Invenio-Indexer has some tests with RabbitMQ - https://github.com/inveniosoftware/invenio-indexer/blob/master/.travis.yml#L51)

Also, please amend copyright years in headers.

Also, please amend copyright years in headers.

:dancer:

Comments addressed and green. It remains to be seen if RabbitMQ + MessagePack + Attachments works, but if I understood it right it's a matter for another issue/PR.


Source Control Manager - Workspace

Does this issue occur when all extensions are disabled?: Yes/No

VS Code Version: 1.83.1
OS Version: Windows 11

Steps to Reproduce:

Open a workspace that has two git repos "dev" and "publish" both having a "project" subfolder:

{
    "folders": [
        {
            "name": "Dev",
            "path": "project"
        },
        {
            "name": "Publish",
            "path": "..\\publish\\project"
        }
    ]
}

Create in both project subfolders a file. Only the file created in the Publish folder is seen as a change from SCM but git correctly sees both.

@Ch41r05, are you able to reproduce the same behaviour in the latest Insiders release? Thanks!

@Ch41r05, are you able to reproduce the same behaviour in the latest Insiders release? Thanks!

Tested also on latest insiders realease, the problem is still occurring sadly.
git status sees the file as modified under the Dev folder, but only files modified in Publish folder show in git tracking in vscode

Thanks for reporting this issue! Unfortunately, it's hard for us to understand what issue you're seeing. Please help us out by providing a screen recording showing exactly what isn't working as expected. While we can work with most standard formats, .gif files are preferred as they are displayed inline on GitHub. You may find https://gifcap.dev helpful as a browser-based gif recording tool.
If the issue depends on keyboard input, you can help us by enabling screencast mode for the recording (Developer: Toggle Screencast Mode in the command palette). Lastly, please attach this file via the GitHub web interface as emailed responses will strip files out from the issue.
Happy coding!

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.
Happy Coding!