ServerInitializer blocks Tomcat startup for two minutes

When Tomcat starts up and finds an already deployed WAR file containing the Eureka server, the startup of this web application hangs for about two minutes after this log:
o.s.c.n.eureka.InstanceInfoFactory       : Setting initial instance status as: STARTING

After some debugging I found that starting the Eureka server also initializes the client in EurekaServerAutoConfiguration#peerAwareInstanceRegistry. Upon client initialization, a request is performed against the currently starting Eureka server. Tomcat seems to block such a request during its own startup, causing the application to pause for about two minutes. This does not happen when starting my application with "bootRun" or redeploying the WAR in Tomcat once it has been started.
I am using Tomcat 10.1.4, Spring Boot 3.0.0 and Spring Cloud Netflix 4.0.0.

Do you mean this line? https://github.com/spring-cloud/spring-cloud-netflix/blob/fa07416bd84e93f06f3a44ee5104b657cf911fa7/spring-cloud-netflix-eureka-server/src/main/java/org/springframework/cloud/netflix/eureka/server/EurekaServerAutoConfiguration.java#L202
Maybe there could be a property that you could set when deploying to a WAR? We don't test WAR deployment of eureka server.

If you would like us to look at this issue, please provide the requested information. If the information is not provided within the next 7 days this issue will be closed.

Do you mean this line?

Yes, exactly.

Maybe there could be a property that you could set when deploying to a WAR?

A property for Eureka would be great, since there does not seem a way to configure this behavior in Tomcat.

Thanks for the clarification, PRs welcom.

PR is open now.

PR is open now.

Further investigation showed that the initial idea does not fix the issue, therefore I closed the PR again. We will continue our investigation.

A new PR is open now which fixes the issue we are having. The "getApplications()" needs to be skipped both for the server and the client in our case.

It does not seem that the PR has been reviewed yet. Can you tell if this could happen soon? This is important for our Jakarta migration.

I created a new PR that is based on the current main branch (after the 4.1.0 release).
We would appreciate any feedback on this! Are there any issues preventing the PR from being merged?


23/3/2017 Feedback

Redo UI Component by today
Put recurring task in Model component
Write who wrote what in the documentation stuff
Good idea to show breakdown of each component in the same feature
Look into loading and save which might cause travisci (use tempfiles, etc.)
Create dummy file and load
partial search "y f" does not make sense, think of something to respond to that
Booking command does not update labels upon confirm
Have unmark instead of mark INCOMPLETED
Today should show the deadlines with tasks
" by " keyword omits other information
Shorten the length of lifelines in sequence diagrams

Find: does this kind of search make sense?
Documentation: update them, try to update UI one by tonight
Consider mark and unmark instead of mark completed/incomplete
what more useful information can you provide in the left panel?
Task title omitted location when date (by deadline) and location both provided
File a bug to Travis
Consider changing to Draw.io because it allows pointing to initialization of lifelines and ending lifelines (in line with CS2103 conventions)


Add some additional configuration options for DNS lookups

Great exporter - made it quite simple to start seeing flows on my network!
This PR enables a capability similar in spirit to the dashboard shown on the README. It allows for configuring DNS lookups differently between remote and local hosts as well as makes the IP address usable as the DNS name in the case a reverse lookup fails. This enables me to create a dashboard that shows overall packets per second in and out per host on the network (and with DHCP leases including reverse DNS records, it is much more clear what host is active).
Note: Although three new options have been added, all are configured by default to match the current behavior of the exporter to avoid surprises for users.

thanks @DRuggeri


added localStorage as a persistent option

This is also backwards-compatible, as it defaults to sessionStorage when opts.autoload is truthy but not "localStorage"

Nice! Thanks @SomeKittens! I don't have time right now, but if this isn't merged in 18 hours, you have my permission to flame me on twitter... @kentcdodds


Add DataFrame.explode/2

Hey folks!
With this one list processing becomes essentially complete IMO, as if there is no convenient list-specific function for some operation (like string trimming, or arithmetic operations), you can just explode the column, process the elements, and then aggregate them back into lists.
One thing that caught me by surprise while implementing this is that I assumed that passing multiple columns to explode would perform a cartesian-style expansion on the data frame, which is not the case. It instead matches the list elements one by one for each row of the exploded columns.
Since I can see how this can be a bit unexpected, I've addressed this behavior in the function docs. Let me know if you think it should be given more emphasis, or if you think it should force a different behavior.
Regarding the name, explode sounds nice and it matches exactly what happens in Polars, so I personally like it. It also gives us a nice error message for free when the list lengths don't match:
** (RuntimeError) Polars Error: lengths don't match: exploded columns must have matching element counts

The other name I could think of is unnest, which is the name of a similar operation in PostgreSQL, but the semantics are a bit different, and there would be extra work translating the error message. Let me know your thoughts on it!

:green_heart: :blue_heart: :purple_heart: :yellow_heart: :heart:


"Each class may only define one primary index" exception when only one field is annotated with @Index(unique = true, primary = true) in the entity

Entity
@NodeEntity(label = "Entity")
public abstract class BaseNodeEntity {
//region properties
protected Long id;
//endregion

//region constructors
public BaseNodeEntity() {
}
//endregion

//region Accessors
public Long getId() {
    return id;
}
//endregion

//region toString, hashCode, equals
@Override
public String toString() {
    return new ToStringBuilder(this)
            .append("id", id)
            .toString();
}
//endregion

}
@NodeEntity(label = "Resource")
public class ResourceEntity extends BaseNodeEntity {
//region properties
@Property
@Index(unique = true, primary = true)
private String name;

@Property
private ResourceType type;
//endregion

//region constructors
public ResourceEntity() {
    // Default for ogm
    this(null, null);
}

public ResourceEntity(final String name, final ResourceType type) {
    super();
    this.name = name;
    this.type = type;
}
//endregion

//region Properties getters and setters
public String getName() {
    return name;
}

public void setName(final String name) {
    this.name = name;
}

public ResourceType getType() {
    return type;
}

public void setType(final ResourceType type) {
    this.type = type;
}

//endregion

//region Equals, HashCode and ToString
@Override
public String toString() {
    return new ToStringBuilder(this)
            .appendSuper(super.toString())
            .append("name", name)
            .append("type", type)
            .toString();
}
//endregion

}
Stack trace
org.neo4j.ogm.session.Neo4jException: Each class may only define one primary index.\n\tat org.neo4j.ogm.metadata.ClassInfo.primaryIndexField(ClassInfo.java:1315)\n\tat org.neo4j.ogm.context.MappingContext.addNodeEntity(MappingContext.java:102)\n\tat org.neo4j.ogm.context.GraphEntityMapper.mapNodes(GraphEntityMapper.java:154)\n\tat org.neo4j.ogm.context.GraphEntityMapper.mapEntities(GraphEntityMapper.java:136)\n\tat org.neo4j.ogm.context.GraphEntityMapper.map(GraphEntityMapper.java:111)\n\tat org.neo4j.ogm.context.GraphEntityMapper.map(GraphEntityMapper.java:76)\n\tat org.neo4j.ogm.session.delegates.ExecuteQueriesDelegate.executeAndMap(ExecuteQueriesDelegate.java:118)\n\tat org.neo4j.ogm.session.delegates.ExecuteQueriesDelegate.query(ExecuteQueriesDelegate.java:90)\n\tat org.neo4j.ogm.session.delegates.ExecuteQueriesDelegate.queryForObject(ExecuteQueriesDelegate.java:64)\n\tat org.neo4j.ogm.session.Neo4jSession.queryForObject(Neo4jSession.java:382)\n\tat sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)\n\tat sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)\n\tat sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)\n\tat java.lang.reflect.Method.invoke(Method.java:498)\n\tat org.springframework.data.neo4j.transaction.SharedSessionCreator$SharedSessionInvocationHandler.invoke(SharedSessionCreator.java:131)\n\tat com.sun.proxy.$Proxy93.queryForObject(Unknown Source)\n\tat org.springframework.data.neo4j.repository.query.GraphRepositoryQuery.execute(GraphRepositoryQuery.java:97)\n\tat org.springframework.data.neo4j.repository.query.GraphRepositoryQuery.execute(GraphRepositoryQuery.java:65)\n\tat org.springframework.data.repository.core.support.RepositoryFactorySupport$QueryExecutorMethodInterceptor.doInvoke(RepositoryFactorySupport.java:483)\n\tat org.springframework.data.repository.core.support.RepositoryFactorySupport$QueryExecutorMethodInterceptor.invoke(RepositoryFactorySupport.java:461)\n\tat org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:179)\n\tat org.springframework.data.projection.DefaultMethodInvokingMethodInterceptor.invoke(DefaultMethodInvokingMethodInterceptor.java:56)\n\tat org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:179)\n\tat org.springframework.transaction.interceptor.TransactionInterceptor$1.proceedWithInvocation(TransactionInterceptor.java:99)\n\tat org.springframework.transaction.interceptor.TransactionAspectSupport.invokeWithinTransaction(TransactionAspectSupport.java:282)\n\tat org.springframework.transaction.interceptor.TransactionInterceptor.invoke(TransactionInterceptor.java:96)\n\tat org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:179)\n\tat org.springframework.dao.support.PersistenceExceptionTranslationInterceptor.invoke(PersistenceExceptionTranslationInterceptor.java:136)\n\tat org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:179)\n\tat org.springframework.aop.interceptor.ExposeInvocationInterceptor.invoke(ExposeInvocationInterceptor.java:92)\n\
Steps to Reproduce (for bugs)
There are no clear ways to reproduce. The behaviour seems non-deterministic.
Your Environment

OGM Version used: 2.1.5
Java Version used: 8
Neo4J Version used: 3.2.5

Looking at the code, this should not be possible unless new FIeldInfo() returns incorrect field mappings. Please set a breakpoint in ClassInfo line 1313 and check the ClassInfo fields for which class is being processed, as well as which two fields are being evaluated as id-fields. Maybe you have another class lying somewhere that is the actual cause of this problem?

I don't have much useful to add apart from Me Too. I get this error very rarely and can't work out a reliable way to reproduce. The class itself is fine, and it can happen once and then not again for weeks so it's not a classpath issue.
It's usually somewhere near server startup so perhaps there's a race somewhere building class info?

The problem is based on having the @Index annotation with primary=true in the implementing class and the Long id in the BaseNodeEntity. Both will try to be the primary id from Neo4j-OGM's point of view.
I just close this for now because there was not activity lately.

I'm not using BaseNodeEntity and the problem is definitely intermittent so not a problem with the annotations.
The above stack trace shows it happening on a query.
Could it be caused by multiple threads calling ClassInfo.primaryIndexField() at the same time (e.g. two queries happening for the first time on server startup)? primaryIndexField could be null and two thread try and set it, one of them wins and the other throws the exception.
Actually ignore me - I'm looking at 2.1.5 but I can see the code in master has changed and won't have the same problem.

Thanks for the reaction 👍
Yes, the class path scanning and parsing of classes was changed in 3.0.

Thanks for looking into this and sorry for a period of inactivity. I also forgot to mention that issue was not related to BaseNodeEntity Long id as in neo4j-ogm 2.1.5 it was required to have Long id even if you have a business key annotated as primary. And the issue in my case was appearing on only one environment out of 4. My assumption as well was that we have race conditions when multiple threads try to resolve index field by calling ClassInfo.primaryIndexField().
Additionally I can also confirm that after switching to ogm 3.1.2 mentioned error never occurs!


Adding Jess Ingrassillino's post about pycon 2017 finaid

@jess_ingrass i changed the markdown/yaml formatting because mynt was complaining. does the author_link and everything else look ok?

LGTM 👍

Looks like heroku is having issues - will rerun build & deploy once it stabilizes.

It's deployed! - go tweet about it @jessingrass @lorenamesa


shared memory using Jetson devices

in pushImg, we have to copy memory from cpu to gpu or device to device. for Jetson devices, such as AGX orin, can we save this step by leveraging shared memory.

Yeah, good idea, Will add this feature once we have time.

we won't develop this feature as this sample mainly guidance for QAT and deepstream deploy


Coin type 60 and ethSecp support for rollapp-wasm - ADR

should be based on this research: https://github.com/dymensionxyz/research/issues/389

ADR: https://www.notion.so/ADR-Standardization-of-Key-Generation-and-Signature-Verification-in-Rollapp-WASM-d6d67068c941468982cb3791c73b6a67?pvs=4


Modbus Flex Getter - Type Error: a is not a function

#120  Problem

( x) bug report => please search github for a similar issue or PR and test Modbus problems with the modbus-serial package before submitting
( x) unexpected behavior => please visit the Wiki before

Current behavior
Attempting to use Modbus flex Getter
Expected behavior
Expecting to get result from a single holding register FC3
Minimal reproduction of the problem with instructions
Basic single line setup.
Inject -> Function -> modbus glex getter -> debug
pulling single message from unitid 245
function:
fc: 3,
unitid: 245,
address: 0,
quantity: 1
console debug message:
2019-10-08T23:28:53.478Z modbus-serial TCP port: signal connect
2019-10-08T23:28:57.161Z modbus-serial { action: 'send tcp port',
data: <Buffer f5 04 00 00 00 01 24 be>,
buffer: <Buffer 00 01 00 00 00 06 f5 04 00 00 00 01>,
unitid: 245,
functionCode: 3,
transactionsId: 1 }
2019-10-08T23:28:57.167Z modbus-serial { action: 'receive tcp port strings',
data: <Buffer 00 01 00 00 00 05 f5 04 02 08 22> }
2019-10-08T23:28:57.169Z modbus-serial { action: 'parsed tcp port',
buffer: <Buffer f5 04 02 08 22 8f 3c>,
transactionId: 1 }
(node:17) UnhandledPromiseRejectionWarning: TypeError: a is not a function
at activateSending (/data/node_modules/node-red-contrib-modbus/modbus/maps/modbus-client.js:571:20)
at process._tickCallback (internal/process/next_tick.js:68:7)
(node:17) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). (rejection id: 4)
I parsed the received message and it is correct.

Node-RED v1.x?

I'm currently running 1.0.1

It is not v1.x compatible see #144


Home screen fix

Addresses #878

Fixed the top and bottom cutoff
Changed the background to accommodate the virtual scroll

@tananaev I've attached a video of how it looks now
https://user-images.githubusercontent.com/52928432/126792449-45722c5d-b303-4a01-a2d7-01b383dafb97.mov

@tananaev PR updated

Merged, thank you.


node-gyp rebuild error during npm install

System Darwin 18.5.0
node -v v12.1.0
node-gyp -v v3.8.0
npm 6.9.0
'npm install' errors when it reaches<EMAIL_ADDRESS>install:
(node-gyp rebuild > builderror.log) || (exit 0)
../csrc/addon.cc:10:40: error: no matching member function for call to 'ToObject'
Local inputBuffer = info[0]->ToObject();
/Users/stnaj/.node-gyp/12.1.0/include/node/v8.h:2532:44: note: candidate function not viable: requires single argument 'context', but no arguments were provided
V8_WARN_UNUSED_RESULT MaybeLocal ToObject(
^
/Users/stnaj/.node-gyp/12.1.0/include/node/v8.h:2546:35: note: candidate function not viable: requires single argument 'isolate', but no arguments were provided
Local ToObject(Isolate* isolate) const);
^
1 error generated.
make: *** [Release/obj.target/addon/csrc/addon.o] Error 1
gyp ERR! build error
gyp ERR! stack Error: make failed with exit code: 2
gyp ERR! stack at ChildProcess.onExit (/usr/local/lib/node_modules/npm/node_modules/node-gyp/lib/build.js:262:23)
gyp ERR! stack at ChildProcess.emit (events.js:196:13)
gyp ERR! stack at Process.ChildProcess._handle.onexit (internal/child_process.js:256:12)
gyp ERR! System Darwin 18.5.0
gyp ERR! command "/usr/local/Cellar/node/12.1.0/bin/node" "/usr/local/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js" "rebuild"
gyp ERR! cwd /Users/stnaj/Documents/Work/a2-clients/sites/604_cbaReferral/node_modules/ttf2woff2
gyp ERR! node -v v12.1.0
gyp ERR! node-gyp -v v3.8.0
gyp ERR! not ok

I submitted a SO: https://stackoverflow.com/questions/56138784/unable-to-install-scrypt-due-to-npm-install-crash. I am unable to get past this issue.

This is probably to do with version incompatibility - the version of the addon you're trying to compile isn't compatible with the version of Node you're trying to compile against. This is a very common thing when a new release line of Node comes out--the ecosystem needs to catch up. Node 12.1.0 is early into Node 12, so you (a) either need to be patient for the authors of the addon to catch up or (b) you need to update your dependencies, or get your dependencies to update their dependencies to compatible version. Or just downgrade your Node version and be patient.
If you're interacting with addon authors on these issues, encourage them to migrate to https://github.com/nodejs/node-addon-api which is intended to be a more stable API and ABI to compile against and should reduce these kinds of problems into the future.


New warnings

https://ci.appveyor.com/project/vitaut/cppformat/build/job/m20bbgeonx6yrewe

Fixed in https://github.com/cppformat/cppformat/commit/275d1ab4231cbe804d5be496374bbf96dc5a8818.

Need to find another way to fix warnings because of #139.

Fixed in https://github.com/cppformat/cppformat/commit/0e8fcd47a0248d102ad3aecae81d70b829f3014e.


AgentChat streaming API

Resolves #3969
Would be a simple way to integrate with UIs to show progress while executing a task, without getting into logging.
from autogen_ext.models import OpenAIChatCompletionClient
from autogen_agentchat.agents import AssistantAgent
from autogen_agentchat.teams import Swarm
from autogen_agentchat.task import MaxMessageTermination

model_client = OpenAIChatCompletionClient(model="gpt-4o")

agent1 = AssistantAgent(
    "Alice",
    model_client=model_client,
    handoffs=["Bob"],
    system_message="You are Alice and you only answer questions about yourself.",
)
agent2 = AssistantAgent(
    "Bob", model_client=model_client, system_message="You are Bob and your birthday is on 1st January."
)

team = Swarm([agent1, agent2])

stream = team.run_stream("What is bob's birthday?", termination_condition=MaxMessageTermination(3))
async for message in stream:
    print(message)

source='user' content="What is bob's birthday?"
source='Alice' content=[FunctionCall(id='call_4dzGXKkfpxZGXEVWNzptFjkH', arguments='{}', name='transfer_to_bob')]
source='Alice' content=[FunctionExecutionResult(content="Error: Expected return type <class 'inspect._empty'>, got <class 'str'>", call_id='call_4dzGXKkfpxZGXEVWNzptFjkH')]
source='Alice' target='Bob' content='Transferred to Bob, adopting the role of Bob immediately.'
source='Bob' content='My birthday is on 1st January.'
TaskResult(messages=[TextMessage(source='user', content="What is bob's birthday?"), ToolCallMessage(source='Alice', content=[FunctionCall(id='call_4dzGXKkfpxZGXEVWNzptFjkH', arguments='{}', name='transfer_to_bob')]), ToolCallResultMessage(source='Alice', content=[FunctionExecutionResult(content="Error: Expected return type <class 'inspect._empty'>, got <class 'str'>", call_id='call_4dzGXKkfpxZGXEVWNzptFjkH')]), HandoffMessage(source='Alice', target='Bob', content='Transferred to Bob, adopting the role of Bob immediately.'), TextMessage(source='Bob', content='My birthday is on 1st January.')])

Why is there an error in the execution result of Alice?

Why is there an error in the execution result of Alice?

This is a separate bug with auto generated handoff functions.

Looks great! Tested a few times, I'm not sure how I feel about the last message being TaskResult while everything else is consistent as message with source & content fields. Maybe if there is a way to have stream.messages and stream.task_result possibly? this is not necessary and just an optional thing completely

Python current doesn't support returning from async generator. A hack is to return value through exception. https://discuss.python.org/t/allow-return-statements-with-values-in-asynchronous-generators/66886/2


Help (-h) seems to have too many TABs

Some of the lines from phetch --help seem to have too many TABs:

Seen in 032c10d6ec38285e2657ab08599cc5983b39ec04.

That's what I get for trying to change sides in the "tabs vs spaces" war... I have switched back to the safety and comfort of manual padding with spaces: f90f4aef7ef83fc1a1eb234fbc77e67f7fc5bd0b Thank you!


[WIP] Use _del marker instead of straight deletion

Coverage increased (+0.02%) when pulling 586cffdc524ddaeec82ace7743c9e26c3aa1e731 on hardikj:secIndexes into 1b1d29bfa7378f7d90ae0f29d259f6ed4da4e901 on wikimedia:master.

@gwicke  what are your views on the comment https://github.com/wikimedia/restbase-cassandra/pull/54/files#diff-be228df81b99a384aa50ad50bde7fca0R578
do you want me  to just mark _del="time-uuid" for all indexes related to this table

@hardikj note that marking a row deleted is not as simple as it seems. First of all, you need to make sure this new behaviour does not conflict with the dropTable functionality, i.e. dropTable should not use _delete under the hood, since these are two distinct features. Next, do not forget that we encourage the usage of UPDATE on one and only one row in the table, meaning that attributes identifying the row must be present (unlike the current version where they are optional, implying a table drop). Finally, the tricky part are the index tables. You have to create a new record for the row being deleted, marking its _del column with the same timestamp.
Oh, yes, that also complicates retrieval (both of data and index keys). We have to be sure:

not to return a row marked as deleted (AFAIK, this works properly already)
pay attention to _del when retrieving info from index tables

Hope these notes help you :)

This looks good to me. Destructive deletion doesn't fit into our consistency / revisioning model. We filter on _del normally, although we should perform an audit (and make sure we have tests) to make sure that we do so everywhere.

I am wondering though whether we should reuse _put() for this. We already enforce the presence of index entries there, and should make sure that index updates happen.

This is actually a great idea. Then, what needs to be done is:

check the request parameters and compare them to the table's schema in order to ensure all of the index key fields have been provided (so as to be sure we are going to delete at most one row)
forward the request to _put() setting _del appropriately

We still need to check the marker during retrieval, but since there is already a check for that in _get(), that might be it.
@hardikj feel like finishing this up? :)

The first bullet (enforcing index keys to be defined) is actually already done when using _put().

Yeah, seem like like just handling it to _put() would be enough!

Coverage decreased (-0.17%) when pulling 620f8bff9c037fec76250175734e6435cf9521ae on hardikj:secIndexes into 1b1d29bfa7378f7d90ae0f29d259f6ed4da4e901 on wikimedia:master.

Coverage decreased (-0.17%) when pulling 620f8bff9c037fec76250175734e6435cf9521ae on hardikj:secIndexes into 1b1d29bfa7378f7d90ae0f29d259f6ed4da4e901 on wikimedia:master.

LGTM. It looks like we need some tests around this.


update supported groups for TLS

Please provide a description of this PR:
The underlying boringssl version used in envoy no longer supports CECPQ2 for TLS groups, and is upgraded to use X25519Kyber768Draft00. Reflect this usage accurately in Istio by removing CECPQ2, and enabling X25519Kyber768Draft00
The dependency of istio -> proxy -> envoy -> boringssl is the following:
Istio -> proxy : proxy SHA
Proxy -> envoy: envoy SHA
Envoy -> boringssl: boringssl version
BoringSSL - supported groups

Hi @navaneethrameshan. Thanks for your PR.
I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

/ok-to-test


Updated xWaitForADDomain.

Updated to make it compatible with systems that don't have the ActiveDirectory module installed, and to allow it to function with domains/forests that don't have a domain controller with Active Directory Web Services running.

I would want a unit test for this to verify we don't regress this functionality.
@iainbrighton @PlagueHO Comments
We need a summary of changes in the unreleased section of the readme.md

@TravisEz13 - I agree. We should be trying to implement unit tests for any resources where they are currently missing - every time an update is made. Also integration tests if possible (even if they are disabled from running by AppVeyor). But unit tests mainly.

A quick scan looks good!
Can the the domain test code not be refactored into another method as you have code duplication? It will also help with your unit tests as we can't mock .Net calls...

@iainbrighton I've moved the domain test code into the Get-TargetResource function. I'm still not sure how to write the pester test for the Get function. LIke you said, you can't mock the .Net call. Even if I were to put it in a new function, I would have to create a test for that function and still wouldn't be able to mock the .Net call.
Any ideas?

@corydwood based on your update, it sounds like you are on the right track.  Thanks

@corydwood Put the .Net call in a new function. We won't be able to test this function but it will then allow you to mock the function and test all the other logic in the Get and Test methods. Does this make sense?

@iainbrighton Yep. I've already updated it with that change and added the tests.

@iainbrighton @PlagueHO if there are no objections, I plan to merge this.

@TravisEz13 - LGTM. Thanks

LGTM too!

Thanks for the contribution!

When it will be merged into the master? I am having the same issue for Windows 2012 R2 -
VERBOSE: [RBW1201]: LCM:  [ Start  Set      ]  [[xWaitForADDomain]DscForestWait]
VERBOSE: [RBW1201]:                            [[xWaitForADDomain]DscForestWait] Checking for domain aws.local ...
VERBOSE: [RBW1201]:                            [[xWaitForADDomain]DscForestWait] Domain aws.local not found
VERBOSE: [RBW1201]:                            [[xWaitForADDomain]DscForestWait] Domain aws.local not found. Will retry
again after 30 sec
VERBOSE: [RBW1201]:                            [[xWaitForADDomain]DscForestWait] Checking for domain aws.local ...
VERBOSE: [RBW1201]:                            [[xWaitForADDomain]DscForestWait] Domain aws.local not found
VERBOSE: [RBW1201]:                            [[xWaitForADDomain]DscForestWait] Domain aws.local not found. Will retry
again after 30 sec
VERBOSE: [RBW1201]:                            [[xWaitForADDomain]DscForestWait] Checking for domain aws.local ...
VERBOSE: [RBW1201]:                            [[xWaitForADDomain]DscForestWait] Domain aws.local not found
VERBOSE: [RBW1201]:                            [[xWaitForADDomain]DscForestWait] Domain aws.local not found. Will retry
again after 30 sec
VERBOSE: [RBW1201]:                            [[xWaitForADDomain]DscForestWait] Checking for domain aws.local ...
VERBOSE: [RBW1201]:                            [[xWaitForADDomain]DscForestWait] Domain aws.local not found
VERBOSE: [RBW1201]:                            [[xWaitForADDomain]DscForestWait] Domain aws.local not found. Will retry
again after 30 sec
I got the reply running the command -
PS C:\Users\Administrator> Get-ADDomain -Identity aws.local -Credential
AllowedDNSSuffixes                 : {}
ChildDomains                       : {}
ComputersContainer                 : CN=Computers,DC=aws,DC=local
DeletedObjectsContainer            : CN=Deleted Objects,DC=aws,DC=local
DistinguishedName                  : DC=aws,DC=local
DNSRoot                            : aws.local
DomainControllersContainer         : OU=Domain Controllers,DC=aws,DC=local
DomainMode                         : Windows2012R2Domain
DomainSID                          : S-1-5-21-1995884071-2777307609-1748979365
ForeignSecurityPrincipalsContainer : CN=ForeignSecurityPrincipals,DC=aws,DC=local
Forest                             : aws.local
InfrastructureMaster               : xxx.aws.local
LastLogonReplicationInterval       :
LinkedGroupPolicyObjects           : {CN={31B2F340-016D-11D2-945F-00C04FB984F9},CN=Policies,CN=System,DC=aws,DC=local}
LostAndFoundContainer              : CN=LostAndFound,DC=aws,DC=local
ManagedBy                          :
Name                               : aws
NetBIOSName                        : aws
ObjectClass                        : domainDNS
ObjectGUID                         : c0f23d48-c0c3-4077-822e-382106315f69
ParentDomain                       :
PDCEmulator                        : xxx.aws.local
QuotasContainer                    : CN=NTDS Quotas,DC=aws,DC=local
ReadOnlyReplicaDirectoryServers    : {}
ReplicaDirectoryServers            : {rbw1201.aws.local}
RIDMaster                          : rbw1201.aws.local
SubordinateReferences              : {DC=ForestDnsZones,DC=aws,DC=local, DC=DomainDnsZones,DC=aws,DC=local,
CN=Configuration,DC=aws,DC=local}
SystemsContainer                   : CN=System,DC=aws,DC=local
UsersContainer                     : CN=Users,DC=aws,DC=local


Example script fails "auto_stop_idle.sh" - crontab

Hello,
I am launching a Sagemaker instance using Terraform. I attached it a lifecycle configuration including the file auto_stop_idle.sh so that it stops when idle.
I have managed to attach it but I think the crontab line in the bash file is incorrect:
(crontab -l 2>/dev/null; echo "5 * * * * /usr/bin/python $PWD/autostop.py --time $IDLE_TIME --ignore-connections") | crontab - (does nothing)
should be:
(crontab -l 2>/dev/null; echo "*/5 * * * * /usr/bin/python $PWD/autostop.py --time $IDLE_TIME --ignore-connections") | crontab - (works)
Should I consider making a PR ?

5 * * * * tells cron to run the python script at 5 minutes past the hour, so your notebook can only shut down at XX:05.
*/5 * * * * tells cron to run it every 5 minutes.
I think the latter is more appropriate, so yes you should submit a Pull Request.

Done, PR #42.

Merged PR #42


Add Preview to Livebookmarks

I use the preview window for one of my podcast to add the episode descriptions to the comment section of my podcast mp3s. Could you add a link to the RSS preview right after the link to RSS link home page (in the livebookmarks; first item) Or at least a way to get to back to the preview layout.
Also could you also prompt where to Add livebookmarks for each RSS feed rather than one default location? This way, I can change the title and where it will be placed all at once.
Thank you so much for this extension. I was stuck on Firefox 26.0.3 until I found this extension.

@LordSky00 For your specific feature request, you should be able to set the "Site URL" setting of each feed to the feed URL, and clicking on the "Open" link should work as expected.
If that doesn't work for you, please feel free to let me know :)


Allow more advanced programming via the template file

Unfortunately, your changes on PR #46 prevent the or function (and possibly also the and function) from working correctly:

1st change
2nd change

I have therefore restored (in this PR) the original version (my initial commit from PR #46).
I will admit that I do not entirely understand the logic behind removing the last argument in the or function.
However, it clearly seems to be the difference between a successful and an unsuccessful operation of the following HBS statement:
{{#ownFunctions}}
{{#if (or (eq visibility "public") (eq visibility "external"))}}
- `{{name}}({{args}})`
{{/if}}
{{/ownFunctions}}

In my original commit (as well as here), I have used the suggestion given in this highly-rated StackOverflow answer.
I believe that this piece of code has been pretty thoroughly tested, so I chose to use it exactly as is.
I don't mind changing it of course, given that you know how to do it without impacting the functionality.
Thanks
Update:
OK, I've figured this out (on the plane from Milan, hence the delay).
The last argument is a (non-empty) options object, which when evaluated as a Boolean, will always evaluate to true.
As such, it is meaningless in the case of every (in the and function), but harmful in the case of some (in the or function).
That is why it must be omitted in the or function.
For consistency (and also for good practice, since it is technically the right thing to do), I have also omitted it in the and function.
This time I left no room for assumptions and verified this (patch-3) against my local repo.

Thank you for figuring this out! I agree that it should be removed in and as well.

Released as 0.3.1.

Thank you for your quick release!


[colossalai/checkpoint_io/...] fix bug in load_state_dict_into_model; format error msg

📌 Checklist before creating the PR

[x] I have created an issue for this PR for traceability
[x] The title follows the standard format: [doc/gemini/tensor/...]: A concise description
[x] I have added relevant tags if possible for us to better distinguish different PRs
[ ] I have installed pre-commit: pip install pre-commit && pre-commit install

🚨 Issue number
fix #6019
📝 What does this PR do?

resolve issue: will raise an error on any unexpected_keys in strict loading
reformat the error message. The current code seems to expect a list rather than a string.

💥 Checklist before requesting a review

[x] I have linked my PR to an issue (instruction)
[x] My issue clearly describes the problem/feature/proposal, with diagrams/charts/table/code if possible
[x] I have performed a self-review of my code
[ ] I have added thorough tests.
[x] I have added docstrings for all the functions/methods I implemented

⭐ Do you enjoy contributing to Colossal-AI?

[x] 🌝 Yes, I do.
[ ] 🌚 No, I don't.

Tell us more if you don't enjoy contributing to Colossal-AI.

I have run the failed tests locally and it did not trigger any error.

We've updated environment of CI. Could you rebase the main branch and rerun the tests?

I rebase the change onto d38344


Failed to send email with special letters (ø, å, etc.) in the email, e.g<EMAIL_ADDRESS>

*** Error receiving message<EMAIL_ADDRESS><EMAIL_ADDRESS>...tml>\r\n"}
    Exception: "\xC3" from ASCII-8BIT to UTF-8
    Backtrace:
       /usr/local/lib/ruby/2.4.0/json/common.rb:224:in `encode'
       /usr/local/lib/ruby/2.4.0/json/common.rb:224:in `generate'
       /usr/local/lib/ruby/2.4.0/json/common.rb:224:in `generate'
       mailcatcher (0.6.5) lib/mail_catcher/mail.rb:44:in `add_message'
       mailcatcher (0.6.5) lib/mail_catcher/smtp.rb:46:in `receive_message'
       eventmachine (<IP_ADDRESS>) lib/em/protocols/smtpserver.rb:558:in `process_data_line'
       eventmachine (<IP_ADDRESS>) lib/em/protocols/smtpserver.rb:196:in `receive_line'
       eventmachine (<IP_ADDRESS>) lib/em/protocols/linetext2.rb:66:in `receive_data'
       eventmachine (<IP_ADDRESS>) lib/eventmachine.rb:193:in `run_machine'
       eventmachine (<IP_ADDRESS>) lib/eventmachine.rb:193:in `run'
       mailcatcher (0.6.5) lib/mail_catcher.rb:173:in `run!'
       mailcatcher (0.6.5) bin/mailcatcher:5:in `<top (required)>'
       /usr/local/bundle/bin/mailcatcher:23:in `load'
       /usr/local/bundle/bin/mailcatcher:23:in `<main>'

Correct, sorry — SMTP does not support utf8 by default, it is an extension, and mailcatcher does not implement this extension. Your smtp client should notice this, and encode the parameters properly. If it does not, you're not using a correctly implemented smtp client.


filter jobs by status and paginate

Codecov Report

Merging #304 (aaa04ef) into master (8ab8d95) will decrease coverage by 0.22%.
The diff coverage is 86.36%.

@@            Coverage Diff             @@
##           master     #304      +/-   ##
==========================================
- Coverage   84.33%   84.11%   -0.23%
==========================================
  Files          55       55
  Lines        4335     4349      +14
==========================================
+ Hits         3656     3658       +2
- Misses        679      691      +12

Impacted Files
Coverage Δ

quetz/jobs/api.py
91.25% <75.00%> (-0.54%)
:arrow_down:

quetz/dao.py
92.54% <100.00%> (+0.71%)
:arrow_up:

...s/versions/53f81aba78ce_use_biginteger_for_size.py
56.25% <0.00%> (-18.75%)
:arrow_down:

...ns/versions/30241b33d849_add_task_pending_state.py
80.00% <0.00%> (-13.34%)
:arrow_down:

...ons/a3ffa287d074_case_insensitive_channel_names.py
68.75% <0.00%> (-6.25%)
:arrow_down:

...ions/versions/8dfb7c4bfbd7_new_package_versions.py
82.35% <0.00%> (-5.89%)
:arrow_down:

...s/versions/8d1e9a9e0b1f_adding_download_metrics.py
72.22% <0.00%> (-5.56%)
:arrow_down:

quetz/database_extensions.py
56.36% <0.00%> (-3.64%)
:arrow_down:

quetz/testing/fixtures.py
96.94% <0.00%> (-2.30%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ab8d95...0c5a194. Read the comment docs.

Codecov Report

Merging #304 (aaa04ef) into master (8ab8d95) will decrease coverage by 0.22%.
The diff coverage is 86.36%.

@@            Coverage Diff             @@
##           master     #304      +/-   ##
==========================================
- Coverage   84.33%   84.11%   -0.23%
==========================================
  Files          55       55
  Lines        4335     4349      +14
==========================================
+ Hits         3656     3658       +2
- Misses        679      691      +12

Impacted Files
Coverage Δ

quetz/jobs/api.py
91.25% <75.00%> (-0.54%)
:arrow_down:

quetz/dao.py
92.54% <100.00%> (+0.71%)
:arrow_up:

...s/versions/53f81aba78ce_use_biginteger_for_size.py
56.25% <0.00%> (-18.75%)
:arrow_down:

...ns/versions/30241b33d849_add_task_pending_state.py
80.00% <0.00%> (-13.34%)
:arrow_down:

...ons/a3ffa287d074_case_insensitive_channel_names.py
68.75% <0.00%> (-6.25%)
:arrow_down:

...ions/versions/8dfb7c4bfbd7_new_package_versions.py
82.35% <0.00%> (-5.89%)
:arrow_down:

...s/versions/8d1e9a9e0b1f_adding_download_metrics.py
72.22% <0.00%> (-5.56%)
:arrow_down:

quetz/database_extensions.py
56.36% <0.00%> (-3.64%)
:arrow_down:

quetz/testing/fixtures.py
96.94% <0.00%> (-2.30%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ab8d95...0c5a194. Read the comment docs.


Expose adding files and folders in sql database projects

This exposes the addToProject() method in sql database projects in a d.ts file so that other extensions can easily add files and folders to a .sqlproj using the existing implementation in the sql database projects extension.
Here's an example of how to use this in another extension:
import * as sqldbproj from 'sqldbproj';

const api: sqldbproj.IExtension = vscode.extensions.getExtension(sqldbproj.extension.name).exports;
api.addToProject(vscode.Uri.file('/Project2/Project2.sqlproj'), ['/Project2/TestFolder', '/Project2/Table2.sql']);

Pull Request Test Coverage Report for Build 590824317

1 of 3 (33.33%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.001%) to 43.268%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

extensions/sql-database-projects/src/projectProvider/projectProvider.ts
1
3
33.33%

Totals

Change from base Build 590552607:
-0.001%

Covered Lines:
25007

Relevant Lines:
52981

💛  - Coveralls


getPath.py takes a really long time

It scans my C:\ drive and I have EFT installed on the F:\ drive. When I put the bot folder on F:\ then it didn't work after launching getPath.py. The ClickToStartWithCMD.bat just launched two windows and died. Any help?

Ight nvm it works


next_screen() iterates from the last displayable line to _lineCount instead of the first line

Describe the bug
When iterating through the selected lines on a screen with next_screen() (forward/backward same issue), the last selected line is the line at _lineCount, except this line doesn't actually exist - so the cursor disappears for one line.
To Reproduce
After noticing the bug I tried the J_scrolling_menu-example, with the following changes:

20x4 screen --> screen.set_displayLineCount(4);
I2C-library
Bug occures in the example as well. Simply execute the function and watch the cursor disappear for 1 iteration.

Related code
// to solve the bug, I replaced all occurances of "_lineCount" in the following functions in
//LiquidScreen.cpp. I did NOT check if this breaks something else.
void LiquidScreen::switch_focus(bool forward) {
print_me(reinterpret_cast<uintptr_t>(this));
do {
if (forward) {
if (_focus < _lineCount -1) {
_focus++;
if (_focus == _lineCount-1) {
break;
}
} else {
_focus = 0;
}
} else { //else (forward)
if (_focus == 0) {
_focus = _lineCount-1;
break;
} else {
_focus--;
}
} //else (forward)
} while (_p_liquidLine[_focus]->_focusable == false);
DEBUG(F("Focus switched to ")); DEBUGLN(_focus);
}
Version of the library
V1.5.1

I also noticed this issue. Can you make a pull request of your fix @DarioMaechler?

Can you make a pull request of your fix @DarioMaechler?

I turned it into pull request #39 It can be installed into platformio until this is released (or fixed differently) using:
lib_deps =
  LiquidMenu=https://github.com/thijstriemstra/LiquidMenu/archive/patch-1.zip

Can you review the pull request @VaSe7u?

Hello, @DarioMaechler and @thijstriemstra.
This is intended by design for the purely aesthetic purpose of not showing the focus indicator when it's not used.
However you are not the first people to find this behavior confusing, so I might add an option to enable/disable it.
Thank's for the input.

Thanks for the feedback.

This is intended by design for the purely aesthetic purpose

I see. I think the default should not be the aesthetic version since it's confusing IMO. An option sounds good though.

Thanks to both of you as well.
I agree with @thijstriemstra. Based on the method names and the comments in the declaration I find the behavior confusing as well. Small example illustrating the problem:

execute switch_focus(true) until get_focusedLine() == _lineCount. Works fine so far (the focus just isn't visible).

execute set_focusedLine(get_focusedLine()) --> this will return false and not work

In my logic the getter returns an illegal value if the setter for the same item won't accept that same value.

Hello and sorry for the delay.
I thought about it and I agree that hiding the indicator while iterating the focusable lines really is confusing and this is not an intuitive place to put that functionality in.
I decided to make this side effect compile time configurable though a define inside src/LiquidMenu_config.h:
https://github.com/VaSe7u/LiquidMenu/blob/5978667585b9ea3cbdfcff5316bcb5b89fd10215/src/LiquidMenu_config.h#L83
It defaults to enabled in order to keep backwards compatibility.
Thank you for the input and the help with the code modification needed.


Incorrect hierarchy in status subclasses

The On/Off Status hierarchy looks incorrect.

Problems:

This forms the following two cycles:

brick:On_Status --rdfs:subClassOf --> brick:On_Off_Status --rdfs:subClassOf --> brick:On_Status
brick:Off_Status --rdfs:subClassOf --> brick:On_Off_Status --rdfs:subClassOf --> brick:Off_Status

This makes these three classes (owl) equivalent to each other:

brick:On_Status
brick:Off_Status
brick:On_Off_Status

Good eye! This comes down to status.py line 201. I think it makes sense to adjust this so on_status and off_status are subclasses of on_off_status instead of the other way around. I'll submit a PR

I think it makes sense to adjust this so on_status and off_status are subclasses of on_off_status instead of the other way around. I'll submit a PR.

I was thinking the other way around for two reasons (probably a very absurd way of thinking):

I thought On_Status and Off_Status combine to form On_Off_Status.

I was expecting all the subclasses of brick:On_Off_Status to have the term On_Off_Status in it which brick:On_Status and brick:Off_Status don't. For instance:

brick:Cooling_On_Off_Status
brick:Humidification_On_Off_Status
brick:EconCycle_On_Off_Status
brick:Locally_On_Off_Status

You know, this isn't a bad design either! The trick is to choose the classes so that you're not accidentally inferring "across" elements of the hierarchy. I'm working on exploring both of these designs in a separate branch. My initial idea may not work as well, but I'll push one of them this afternoon so we can take a look at it. The design you just posted is essentially the original intended lattice; it may be best to just stick with that (but implement it properly, of course!)

@shreyasnagare let me know what you think of the fix!

@gtfierro That looks great!

Merged and fixed; thanks for your help :)


Chart window covers marker detail view

If a marker in the lower half of the screen is selected, the marker detail view opens (as expected), then the chart window opens (as expected) and covers up the marker detail view. Consider moving the marker to the new center of the remaining map view.

This issue has been fixed in the latest map handling update.


fix tests on Julia 0.7

Codecov Report

Merging #49 into master will increase coverage by 0.63%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master      #49      +/-   ##
==========================================
+ Coverage   94.63%   95.26%   +0.63%
==========================================
  Files           7        7
  Lines         671      676       +5
==========================================
+ Hits          635      644       +9
+ Misses         36       32       -4

Impacted Files
Coverage Δ

src/document.jl
99.13% <100%> (+0.01%)
:arrow_up:

src/node.jl
99.18% <100%> (+0.81%)
:arrow_up:

src/streamreader.jl
95.91% <100%> (+0.04%)
:arrow_up:

src/buffer.jl
100% <0%> (+14.28%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a2b90b2...2e88dca. Read the comment docs.


[arc flow] Add message that dependencies were updated, now it simply finishes work and users can be confused

Add message to reduce confusion that process is finished

LGTM


Missing configurations

Hi
Will you add in your GitHub all the configurations described in the Vingerha original GitHub ?
There are all necessary
Regards
Philippe

hello, can you make a PR to adapt the content ?


Kafka-2587:  Only notification handler will update the cache and all verifications will use waitUntilTrue.

@Parth-Brahmbhatt : Thanks for the patch. LGTM. Could you address the minor comments from Ismael?

comments addressed.


Fix(eos_cli_config_gen): community-list config order

Change Summary
Part of the various changes for getting output config to reflect config order on box.
Related Issue(s)
Fixes #1572
Component(s) name
arista.avd.<role-name>
Proposed changes

Reorder configuration generation of community list configuration
Add missing molecule tests

How to test

Checklist
User Checklist

N/A

Repository Checklist

[X] My code has been rebased from devel before I start
[X] I have read the CONTRIBUTING document.
[X] My change requires a change to the documentation and documentation have been updated accordingly.
[X] I have updated molecule CI testing accordingly. (check the box if not applicable)

Can we merge this now that there are 2 approvals?


CI: improve build CI with a step to upload into workflow artifacts

chatgpt
      - name: Upload PDF artifact
        uses: actions/upload-artifact@v2
        with:
          name: paper-pdf
          path: paper/source/paper.pdf

we do a lot of such things within datalad/git-annex, e.g. https://github.com/datalad/git-annex/actions/runs/5538542139 has it at the bottom

presumably fixed in 979ba07addff75bd2b496aaa652d76c69047f693


translate.service.use('client.edge')后翻译出错。

对于如下内容：
Massive ($\gtrsim9$ M$_\odot$) and very massive ($\gtrsim100$ M$_\odot$) stars are expected to release large amounts of energy and metal-enriched material throughout their relatively short lives. Their stellar winds may play an important role in the metal-enrichment during the formation of star clusters. With novel high-resolution hydrodynamical GRIFFIN-project simulations, we investigate the rapid recycling of stellar wind-material during the formation of massive star clusters up to $M_\mathrm{cluster}\sim2\times10^5$ M$_\odot$ in a low-metallicity dwarf galaxy starburst. The simulation realises new stars from a stellar initial mass function (IMF) between $0.08$ M$_\odot$ and $\sim400$ M$_\odot$and follows stellar winds, radiation and supernova-feedback of single massive stars with evolution tracks. Star clusters form on timescales less than $\sim5$ Myr, and their supernova-material is very inefficiently recycled. Stellar wind-material, however, is trapped in massive clusters resulting in the formation of stars self-enriched in Na, Al, and N within only a few Myr. Wind-enriched (second population) stars can be centrally concentrated in the most massive clusters ($\gtrsim10^4$ M$_\odot$) and the locked wind-material increases approximately as $M_\mathrm{cluster}^{2}$. These trends resemble the characteristics of observed second population stars in globular clusters. We fit scaling relations to the log-normal distributed wind-mass fractions and extrapolate to possible globular cluster progenitors of $M_\mathrm{cluster}=10^7$ M$_\odot$ to investigate whether a dominant second population could form. This can only happen if the IMF is well sampled, single massive stars produce at least a factor of a few more enriched winds e.g. through a top-heavy IMF, and a significant fraction of the first population (unenriched) stars is lost during cluster evolution.

切换translate.service.use('client.edge')后翻译会出错，不加这一行则正常。
大致的错误信息是：

似乎只要内容带美元符号$都不行

收到，我这边试一下啊，应该是特殊字符导致判断出了异常，我试试并修复一下，你可先使用不加  translate.service.use('client.edge') 这个的

嗯嗯，谢谢，我也可以翻译前手动replace一下，问题不大，主要是把bug反馈一下。
另外就是简单对比了一下，感觉微软的翻译相对准确一些，所以还是比较倾向于用微软的。

以修复这个问题，js可以先用这个  https://res.zvo.cn/translate/translate.js  这个已经更新了这个问题了

测了一下，似乎没问题了，什么时候正式上线呢？之前看到官网的消息，说2.18（昨天）正式上线v3，全面切换到微软的翻译来着？

是的，是已经上线了V3， 可以参考一下这个   https://mp.weixin.qq.com/s?__biz=MjM5OTEzNjE2NQ==&mid=2453011637&idx=1&sn=26082966eb6997150b4e0f6c30c64d75&chksm=b101427f8676cb69fda311c5c61e5b90eb8aebd27a07a691811192ba2109308d9f3431a1c8be&token=445477528&lang=zh_CN#rd
v2.x 升级 v3.0 的方式，可以参考：
http://translate.zvo.cn/43063.html
不过里面的cdn引入的js，你可以用https://res.zvo.cn/translate/translate.js ，这个要比链接里的七牛云提供的js要新

有空可以关注一下微信公众号  wangmarket  有更新我们也会再公众号推文


Colab is not working

Hello. Colab notebook: llama2-finetune-own-data is not working correctly!
In the code block:
from peft import LoraConfig, get_peft_model

config = LoraConfig(
    r=32,
    lora_alpha=64,
    target_modules=[
        "q_proj",
        "k_proj",
        "v_proj",
        "o_proj",
        "gate_proj",
        "up_proj",
        "down_proj",
        "lm_head",
    ],
    bias="none",
    lora_dropout=0.05,  # Conventional
    task_type="CAUSAL_LM",
)

model = get_peft_model(model, config)
print_trainable_parameters(model)

# Apply the accelerator. You can comment this out to remove the accelerator.
model = accelerator.prepare_model(model)

I'm getting the following error:
trainable params: 81108992 || all params:<PHONE_NUMBER> || trainable%: 2.264651559077991
---------------------------------------------------------------------------
TypeError                                 Traceback (most recent call last)
<ipython-input-22-09c3a8fb39e3> in <cell line: 25>()
     23
     24 # Apply the accelerator. You can comment this out to remove the accelerator.
---> 25 model = accelerator.prepare_model(model)

/usr/local/lib/python3.10/dist-packages/accelerate/accelerator.py in prepare_model(self, model, device_placement, evaluation_mode)
   1325             current_device_index = current_device.index if isinstance(current_device, torch.device) else current_device
   1326
-> 1327             if torch.device(current_device_index) != self.device:
   1328                 # if on the first device (GPU 0) we don't care
   1329                 if (self.device.index is not None) or (current_device_index != 0):

TypeError: device() received an invalid combination of arguments - got (NoneType), but expected one of:
 * (torch.device device)
      didn't match because some of the arguments have invalid types: (!NoneType!)
 * (str type, int index)

Any ideas?

The same issue! Does anyone have a solution to fix it?

@yukiarimo Change step 7 to
model = AutoModelForCausalLM.from_pretrained(base_model_id, quantization_config=bnb_config, device_map="auto")

@yukiarimo Change step 7 to model = AutoModelForCausalLM.from_pretrained(base_model_id, quantization_config=bnb_config, device_map="auto")

Thanks, I’ll try it today! By the way, do you know how to fine-tune Phi 3 vision with a text-only dataset? I tried, but it says 120 hours instead of 30 minutes as usual for LLaMA :(


Create testing pipeline

Create testing pipeline (integrated tests)

Is this what you were doing with Denisse and then have moved onto having the rest of us test? If so I'd say, done!


Design changes

suggestive design changes for media.buidlguidl.com

thanks for the comments

Hey, I think I resolved all the requests. Let me know please, if there is something missing.

Hey @mac11fish ! Yes, everything solved code-wise! Merging this. Thanks ;)
I see some little things (Design wise)

Here it seems like some space is missing? But I'll leave that to @andrealbiac for another PR
Thanks again!!

Hey I fixed that issue with the missing space, no problem.

also noticed a small issue with button text same color as button background. I fixed this issue. Will submit a new PR


Security: Domain wide delegation requires service account key to be available

Due to lack of functionality within the google python client API, the service account key is required for the use of domain wide delegation against GSuite when enumerating users and groups.
The technical reason is the requirement for creating a signature as part of the authentication workflow. However, Cloud IAM offer signBlob API to perform signature operations. Hence it should be possible to implement the workflow without requiring the service account key to be available to the code but rather having the code run under the service account's authority in GCE.
This would improve security as Forseti/Explain would be working with a single service account as the ambient authority of the GCE instance.

Fixed by #1399 by changing to use the google.auth library.


Maximum amount of activities I can read for a single feed via APIs ?

Maximum amount of activities I can read for a single feed via APIs ?
I am using Getstream for my system and starting with the Starter plan.
When I read a feed from API, Getstream API only returns up to 500 latest activities.
This number is too small to accept. I can't find any documentation from Getstream that mentions this problem.
You can check this repo to see my test results: getstream-e2e.
Thanks.

This is related to your plan and use-case, not the SDK so please contact to support.

This is related to your plan and use-case, not the SDK so please contact to support.

Thank you.


Test for a specific size instead of multiple of the share size

in the current cli integration test, we are checking to see that emitted events contain a multiple of the share size instead of checking for a direct size. We should update that test to check for a specific size.

can close as this was completed https://github.com/celestiaorg/celestia-app/blob/6b86e91eea1063c27c1ae461eddbe505f778df08/x/payment/client/testutil/integration_test.go#L118


Gets stuck when you paste text into shell

Occurs with both shell paste, and terminal paste from alacritty's config
Occurs regardless of whether oh-my-posh is enabled or not
You can't ctrl+c out, or even ctrl+d to close, you have to close the whole terminal instance
This seems to be specific to alacritty, it doesn't happen when using pwsh directly without a terminal, or when using wezterm
OS: Windows 10
Shell: PowerShell 7.3.0-preview.6
Terminal: alacritty 0.10.1 (2844606)

I've never used alacritty before but I don't seem to have this problem. You can try updating your PowerShell or you can try switching over to Windows Terminal.

Try pasting this on latest alacritty and latest pwsh preview  (while syntax-highlighting is enabled and imported already):
Import-Module syntax-highlighting

I just installed alacritty and I tried pasting Import-Module syntax-highlighting
(while syntax-highlighting is enabled and imported already) and I don't seem to run into any problems.

@digitalguy99 after a little more testing, it only seems to happen on the first command sent to the shell, if you do it after it no longer happens

ok no, even that's wrong, if I do it right after the launch of my terminal can reproduce pretty consistently, but sometimes it doesn't show

Not directly after launch, waited a bit: https://i.alienpls.org/xxo.apng
directly after launch: https://i.alienpls.org/kzZ.apng

Have you tried changing your oh-my-posh theme? Or testing this solution out?

Occurs regardless of whether oh-my-posh is enabled or not

Occurs regardless of whether oh-my-posh is enabled or not

What I'm saying is that, regardless if you are using oh-my-posh or not,  this solution uses a different approach in implementing the syntax-highlighting module. So, I think it'll be worth trying out.

@digitalguy99 yes this seems to fix the issue

Maybe pure shouldn't be marked with a ✅ here then.
So the issue is just that it doesn't play well with the oh-my-posh theme?

Maybe pure shouldn't be marked with a ✅ here then. So the issue is just that it doesn't play well with the oh-my-posh theme?

Yeah, that might be the issue.

@brian6932 Thank you for raising this issue, I've marked pure with an ❌.


Unhandled Exception in AuthRefreshTask

If AuthRefreshTask fails in anything except a NetworkException, it will cause the timer thread that runs it to die, and the exception won't be logged.
This seems to have happened to me (we sometimes have poor network connectivity to Symphony), and the tokens didn't refresh.
thanks,
Rob

commit<PHONE_NUMBER>281341d81cc6f54a0911a3cba70c83
This is now fixed and tested (unplugged network).
SNAPSHOT 1.1.5 published


doc-global-removal

Globals were being documented when they shouldn't - will add a link check for this.

Changes Unknown when pulling 7d4bc512332e8e350b32ab6f64cee99fd5780ac1 on doc-global-removal into ** on v3**.


do schemas need to be updated

There are several schemas here:
https://github.com/databio/bbconf/tree/dev/bbconf/schemas
I believe these are pipestat schemas. But when pipestat was updated, the schema definition changed.
bbconf has I believe been updated to use the new pipestat.
Are these schemas up-to-date?

This pipestat sachems were updated by @donaldcampbelljr , and I believe they are working and up-to-date

I believe I only updated the pipeline names but did not touch the actual schema fields as they were working during testing with the new pipestat. Pipestat should raise a schema error if the required keys are not present for complex types.

I thought the pipestat schema format changed like this:
https://github.com/pepkit/pipestat/issues/20

@donaldcampbelljr pipestat schemas are now json schemas, right?

Pipestat can accept either the old way or a JSON schema, yes.
However, after our discussion ~ last week, I realized we are still using types such as file and image within the JSON pipestat schema (and later converting them to be objects).
Therefore the schema is still not actually 100% JSON schema: https://json-schema.org/understanding-json-schema/reference/type

I thought we decided on doing:
type: object
object_type: file

that makes it a valid json-schema, but allows our type-specific treatment.

Close, but right now its:
type: file
object_type: file

Pipestat still uses the type field and if its an image or a file, recursively replaces that with title and path and changes the type to object.

Current bbconf example from dev:
pipeline_name: bedfile
samples:
  name:
    type: string
    description: BED file name
  genome:
    type: object
    description: genome assembly of the BED files
  bedfile:
    type: file
    pipestat_type: file
    label: bed
    description: BED file
  bigbedfile:
    type: file
    pipestat_type: file
    label: bigBed
    description: bigBed file

that's the old format, not a json schema at all

Yes, pipestat can accept either format currently. However, I'm just showing how the pipestat_type was implemented along with the original type.

We need to update those bbconf schemas to use the new format, and deprecate the old.
Issue raised: https://github.com/databio/bbconf/issues/32

The relevant issue in pipestat is: https://github.com/pepkit/pipestat/issues/85

Fixed in 0.4.0 release


improved version of python cmorization utilities

This is a quick one but needs testing by @ledm of WOA back again :grin: I improved the coordinate handling (more general handling now) and added key work args to the saver so that people can input fillvalues, attributes etc

aligned this to pr #895 since the changes in utilities.py are better suited to more general cases. I'd like to merge this asap so we can clean the clutter in our PR's a bit. The changes have been tested for a number of OBS models and they work a-ok (including the one in 895)


Morph Storage Component

Resolves #64.

Pull Request Test Coverage Report for Build 182

0 of 24 (0.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.7%) to 67.015%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/main/java/seedu/address/storage/AnakinStorageManager.java
0
24
0.0%

Totals

Change from base Build 175:
-0.7%

Covered Lines:
1475

Relevant Lines:
2201

💛  - Coveralls


Langeno/k8s plugin add table

Hey, I just made a Pull Request!

See https://github.com/backstage/backstage/issues/18471#issuecomment-1704292855.
This hopefully fixes said bug by adding an ID property to the Pods table.
Please cross-check this change if possible, as e.g. the warning mentioned in the bug still appear in the browser console.
However local tests have shown that the sidebar does not close anymore.
However tests had to be done with our local backstage setup, as I needed a working k8s cluster to connect to.
:heavy_check_mark: Checklist

[x] A changeset describing the change and affected packages. (more info)
[x] Added or updated documentation -> Changes are so minimal I see no need for this
[x] Tests for new functionality and regression tests for bug fixes -> I have no clue how to write a good regression test for this. Any hints welcome, I am willing to add one.
[x] Screenshots attached (for UI changes) -> UI did not change.
[x] All your commits have a Signed-off-by line in the message. (more info)

I will try to take a look at the failing pipelines somewhen this week. As already mentioned in the related bug ticket I am currently busy privately, so if someone else waits for the fix feel free to fix it yourself.

I won't have time this week but might next week if someone can pick up quicker

I am back in action next week, if we can keep this from getting stale until then it would be great. Sorry for the delays and inconvieniences.

Thanks for doing this fix! Looking forward to be able to use it because this bug makes the plugin somewhat unusable

So good and bad news:
I moved the change to the new file structure (which was put in place due to https://backstage.io/docs/architecture-decisions/adrs-adr011/ I assume) in a way that hopefully passes the CI pipeline.
However, this time I tried to test the changes using the backstage example app + our kubernets config (so I updated app-config.yaml and plugins/github-actions/examples/sample.yaml with the relevant values for our k8s cluster).
This way the bug was not reproducible on my end: Even without my changes both on master (so some version >v1.18.0) and v1.16.0 the "pod sidebar" stayed open.
So I was only able to confirm that my changes break nothing, but I am unsure if they still fix the reported bug.
I have yet to get our local backstage instance running with a locally modified kubernetes plugin version to really verify the fix works, which will take some time as we first would need to upgrade to v1.18.0 to get the new file structure from ADR 011.
Is there any tips&tricks how to setup a local version of the kubernetes plugin in an existing backstage instance? I can either use the example app (where everything is referenced by "workspace:^"), which as explained above doesn't show the issue OR use my own backstage instance (which references everything by version numbers ... so if I copy&paste the ~4 kubernetes plugins over, I have to go and replace all "workspace:^" references that are not for the other kubernetes plugin with version numbers by hand, which is very cumbersome and error prone)

@mclarke47 : Can we either merge this as is as this at least does not break any existing features (see comment above) or keep this from getting deleted until I can verify it in our company internal v1.18.0 environment (which will take 1-2 weeks more until it is available :/)


Removed lua compiler and scripts

In a previous commit, we switched to the Lua compiler (lualatex) and tried to implement the XML parser using Lua. In further testing, this totally didn't work, so we are using now latexmk again.

Since we need this to test the workflow from #1, the validation of this PR was done locally. All tests pass.


set-tsssecret fails for restricted secrets

When executing the following code I am getting errors for restricted secrets
Set-TssSecret -TssSession $SourceSession -HeartbeatEnabled:$false  -Id $secretid -comment "disabling heartbeat"
The server is reporting errors about needing comment
The remote server returned an error: (500) Internal Server Error. | The requested Secret requires a comment when viewed.

The PATCH endpoints used in the Set function do not provide any option to pass the restricted arguments. I am using a call to Get-TssSecret for three params (AutoChangeEnabled, AutoChangeNextPassword, and EnableInheritPermission) because the PUT /secrets/{id} has to be used.
Using Get call causes an additional audit entry since it is getting the password in plain text (view password audit or something). I don't want to add that for all the PATCH endpoints.
My plan right now is to add a part script for doing checkouts. It will call the POST /secrets/{id}/check-out but prior to that being used you have to create a view comment message using POST /secret-access-requests/secrets/{id}/view-comment. The part script will handle calling those two endpoints.


Fixed issue when startsWith() and endsWith() are passed a null value.

This problem actually showed up in some stick code because contentType was not checked for null before using strings.startsWith(). I thought it would be better to fix the code in the strings.js module.

This will return false when called with args ("", "") which is arguably false. Also, I'd say it's ok to expect the caller to make sure arguments are strings.

So, the stick code that can pass in a null ContentType value has to have that pre-check.


Password reset not working

When coming through the reset flow with a token, the confirmation validation fails even if both fields are the same.
Removing the 'confirmed' validation rule from the model itself gets around the issue, and still validates mismatched fields properly.

Fix included in v3.0.3
Thanks!


Unable to archive app

I got this issue when I try to archive my app integrated with WSTagsField framework. What can I do now? Do you have any solution for this?. It could be so helpful if you can solve the issue asap. Please let me know if any solution matches for this.

@TringRajagopal Are you using CocoaPods?

@ricardopereira Thanks for the response..! Actually I was not integrated with CocoaPods. As I needed some customisation to your WSTagsField according to my use case, I have just imported your class files and added few delegates into it.

@TringRajagopal If you imported the class files manually then I'm 100% sure that error shouldn't be happening. What steps did you do to import the swift files?


Performance issue in /dev/evaluators (by P3)

Hello! I've found a performance issue in estimator_classification.py: dataset.batch(batch_size)(line 51) should be called before dataset.map(augmentation, num_parallel_calls=8)(line 50), which could make your program more efficient.
Here is the tensorflow document to support it.
Besides, you need to check the function augmentation called in dataset.map(augmentation, num_parallel_calls=8) whether to be affected or not to make the changed code work properly. For example, if augmentation needs data with shape (x, y, z) as its input before fix, it would require data with shape (batch_size, x, y, z) after fix.
Looking forward to your reply. Btw, I am very glad to create a PR to fix it if you are too busy.

Hello, I'm looking forward to your reply~


apis/tenancy/ClusterWorkspaceTypes: defaulting and union type constraints for allowed children and parents

/lgtm
/approve

The types are still wrong.

/lgtm cancel
/hold
We can't default to any: true, since we will now be ensuring that:
clusterworkspacetype.tenancy.kcp.dev root:A allows children {any: false, types: {...}}
clusterworkspacetype.tenancy.kcp.dev root:B extends root:A, does not specify allowed chlidren

With this PR, root:B gets {any: true} defaulted, which is not a subset of root:A. What the user meant to do when not specifying the field was to inherit the restrictions from root:A, but with a defaulted field this is now impossible.
/cc @csams

@stevekuznetsov not sure the comment is already clarified in Slack. As written here I don't get it.
I can see how defaulting of the default is not desirably potentially. But for allowedParents and allowedChildren it's a noop. If we honor all invariants by the aliases, this will not restrict anything.
Note: we don't default any: true, we default {any: true, types: nil}. That's an important difference.

Replaced with https://github.com/kcp-dev/kcp/pull/1474


Training Details for A3C

Hi,
It is mentioned in the MeltingPot paper that "Every agent participated in every training episode, with each agent playing as exactly one player (selected randomly on each episode)." - Section 7 Experiments
But in A3C/IMPALA, the experience collection is de-coupled from the training loop. So how exactly the information about which agent was used to generate the experience for which player, is shared between the experience collection loop and training loop?
E.g. Let the agent-player mapping be as follows for a 2-player environment be

{"agent_1":"player_1", "agent_2":"player_2"} for first episode
{"agent_2":"player_1", "agent_2":"player_1"} for second episode

As the experience will be stored in a replay buffer, and multiple episodes can be sampled from the buffer together(depending on batch size), the agent-player mapping can vary for each example in the batch. How exactly is this being handled?
Possible options:

It doesn't matter which agent was used to collect the experience as we are anyways, passing the log_prob and applying v-trace, so the agent-player mapping in the experience collection and training loop is handled completely independently
Sample only a single episode at once, and batch it accordingly so that the agent-player mapping is consistent for that specific training step

Thanks
Kinal

At learning-time the asynchronous actor-critic baseline agent ("A3C") processes trajectories of it's own observations/actions only. So it doesn't need to know what player slot it was in.
Only OPRE saw coplayer observations during learning (but not during behavior), and it received a one-hot batch of vectors to tell it which slot was it's own perspective.

Thank you for your answer.
So if I understand correctly, even if mapping is {"agent_1":"player_1", "agent_2":"player_2"}  during the experience collection time, the policy-gradients can be calculated with a different mapping say {"agent_2":"player_1", "agent_2":"player_1"}?
(Note: here agent_* refers to the network being used to select an action or whose parameters are being updated using PG)
Is there any form of parameter-sharing being adopted? E.g., for CNN feature extraction.

I'm not sure what you mean about using a different mapping in the policy-gradient update. The mapping of agent to player slot is a behavior-time detail that is always irrelevant to the A3C/IMPALA agent:

Policies are conditioned only on their own observations. They have to infer the existence of co-players from their observations. (Decentralized execution).
In the A3C/IMPALA agent, the critic is conditioned only on the agent's own behavior-time observations so the exact behavior-time slot is irrelevant. It must also infer the existence of co-players. (Decentralized learning).

We did no parameter-sharing between agents, so they were only coupled by correlated experience from shared episodes (albeit from different perspectives).


refactor(router): add amount conversion framework to netcetera

Type of Change

[ ] Bugfix
[ ] New feature
[ ] Enhancement
[x] Refactoring
[ ] Dependency updates
[ ] Documentation
[ ] CI/CD

Description
Minor refactoring to standardize Netcetera connector to use the conversion framework to reduce potential inconsistencies in managing amounts fixes #5930
Checklist

[x] I formatted the code cargo +nightly fmt --all
[x] I addressed lints thrown by cargo clippy
[x] I reviewed the submitted code
[ ] I added unit tests for my changes where possible

Please run cargo +nightly fmt --all once and commit.

@hrithikesh026 review comments done!

Please run the following command to fix the formatting of this pr
cargo +nightly fmt

@deepanshu-iiitu sorry missed the formatting after the last refactor. Formatted the code now :)

@hrithikesh026 there was a compilation issue fixed it now

Hey @hex1c
Can you work on the above suggested changes

Hey @hex1c
Kindly look into the comments, and make the changes!

@deepanshu-iiitu made the changes kindly review it and let me know if there are any changes.


"Hello World"-example should match its spec ( Fixes #476 )

Hi,
I just started experimenting with swagger and followed the steps in the Readme.
When I generated a C#-Client for the "Hello World"-Example-Server, it wasn't working out of the box, because the server just returns "Hello, stranger" instead of "{ "message": "Hello, stranger" } as specified in the swagger-spec.
I first created an issue in the swagger-codegen-repo (see swagger-api/swagger-codegen#4816), which was the wrong place for reporting :)
This is only a minor bug I know, but the example should work out of the box. This pull request should make the example match its spec again. It should fix: #476

Sorry for all the commits. I had to fix every single file using the web frontend O:)


chore(examples): fix ESLint errors & warnings

@kentcdodds Apologies, I didn't see that you were assigned to this 😓

Thanks for managing this!


[BEAM-11689] Add public.nexus.pentaho.org to offline repositories.

This doesn't erase https://repo.spring.io/plugins-release because it is still used by Gradle plugins.
https://github.com/apache/beam/blob/280107a48d83a2c72c70a19a881f5789200818dc/buildSrc/build.gradle#L26-L34

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Choose reviewer(s) and mention them in a comment (R: @username).
[ ] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

R: @chamikaramj

R: @chamikaramj

LGTM. Thanks.

LGTM. Thanks.

Can you send a cherry-pick to 2.28.0 branch as well ?


Migrate from JBoss Jandex to SmallRye Jandex

As version JBoss Jandex 3.1.2 contains just a relocation pom, it is already utilizing the SmallRye Jandex.


[QUESTION] customer support agent

Describe the feature you'd like
How do you create a chain that acts as a customer support agent and is able to capture primary and secndary keys and writes json to a function to be used with an api for data CRUD. Also want to be able to summarize the conversation when completed and capture the sentiment and uses a tool to send an email with the conversation summary and sentiment attached.

for now flowise can't capture information from chat to be used for other operation yet. sounds like you have to use different chatflows to achieve what you're trying to do, also with chatbot builder like botpress/voiceflow

most likely we can achieve this using agentflow:


Incompatibility with NodeJS 11

This code works fine with node 10.x, but throws an exception on node 11.x :
const Paseto = require('paseto.js');

async function main() {
  const key = new Paseto.PrivateKey.V2();
  await key.inject(Buffer.from('/W17oWlDaX7DxqublK5QN+2I/EbpSrzhy0/rvGGydpmlz3Utp1onJ6oYxlxH0ZOWr6PC4UAHqn7AWCwuEUr9EA==', 'base64'));
  await key.protocol().sign("hello world", key);
}

main().catch(console.log);

Exception :
TypeError [ERR_INVALID_ARG_TYPE]: The "byteLength" argument must be of type number. Received type undefined
    at validateNumber (internal/validators.js:130:11)
    at checkNumberType (internal/buffer.js:42:3)
    at boundsError (internal/buffer.js:47:5)
    at Buffer.writeIntLE (internal/buffer.js:687:3)
    at Object.pae (/opt/data/simon/tmp/digisthesia/smarketoo-api/node_modules/paseto.js/lib/utils.js:158:15)
    at sodium.ready.then (/opt/data/simon/tmp/digisthesia/smarketoo-api/node_modules/paseto.js/lib/protocol/V2.js:246:30)

Looks like the size must now be explicitly passed.
Replacing writeIntLE by wirteInt32LE in utils.js fixes the issue, with all tests still passing.

Thanks, will try and find some time to get a fix up. It may take a few days, but I'm happy to merge a PR in the meantime.

Release 0.1.3 up on npm with the fix. Thanks a lot for the report + PR.

Hello @sjudson ,
As it's related to nodeJs 11, I have the following warning when installing  with npm :
gyp info spawn args [ 'BUILDTYPE=Release', '-C', 'build' ]
  CXX(target) Release/obj.target/extcrypto_addon/extcrypto/extcrypto.o
../extcrypto/extcrypto.cc:115:23: warning: 'Utf8Value' is deprecated: Use Isolate version [-Wdeprecated-declarations]
    String::Utf8Value ipem(pem);
                      ^
/Users/matthieu.rolla/.node-gyp/11.13.0/include/node/v8.h:2991:5: note: 'Utf8Value' has been explicitly marked deprecated here
    V8_DEPRECATED("Use Isolate version",
    ^
/Users/matthieu.rolla/.node-gyp/11.13.0/include/node/v8config.h:326:29: note: expanded from macro 'V8_DEPRECATED'
  declarator __attribute__((deprecated(message)))
                            ^
1 warning generated.
  SOLINK_MODULE(target) Release/extcrypto_addon.node
gyp info ok

node version :
$ node -v
v11.13.0

Just let me know if you prefer me to open a new issue.
Thanks.


[BUG] Very annoying config.json bug, currently have over 1500 config.json files

What operating system are you using?
Microsoft Windows [Version 10.0.14393]
What version of Nylas Mail are you using?
2.0.32
Bug?
Very much so
Is the issue related to a specific email provider (Gmail, Exchange, etc.)?
No, this is a nylas problem
Is the issue reproducible with a particular attachment, message, signature, etc?
Just keep Nylas loaded, and the errors keep rolling in.

Currently now at over 2500 config.json files.

Yea, this is annoying. A lot of people already reported too.


Fix Google Oauth

This may just be a settings thing but this is still broken!

See https://github.com/Scifabric/pybossa/issues/1672


documentation

Documentation is needed both for developing new avatars within the system and getting the chat bot set up with OAuth bearer tokens, etc.

Yup ! I personnally need this ! I've set up the bot and everything but I dont know where I need to go, to see the avatars

Should be https://localhost:5000/avatars/static/index.html, though the avatars system is being completely rewritten from scratch right now to use PhaserJS and will soon be a bit different.

The avatars system is going to be developed further under a standalone project. It's mostly ready, just needs more sprites added. It's already got feature parity with the current system, but needs no back-end code and runs entirely from static files. It still needs to be served over HTTP/S for fetch and dynamic import to work, but there's no code running on the server.
I have plans for splitting out the chat overlay in a similar fashion. By that point, there won't be much left of the bot at all. I will likely retire this project and just build front-end-only dynamic overlays that can be integrated with something like TAU.
Here's the new avatar system's home: https://github.com/haliphax/hxavatars


Add "config delete NAME" command

Description
Deletes a context from the config file. If the context is the current context, the current context is set to the first context in the config file. If the config file is empty after the delete, the current context  is set to the default context.
Note: This should be merged after https://github.com/cisco-open/fsoc/pull/165, on which it is based.
Type of Change

[ ] Bug Fix
[x] New Feature
[ ] Breaking Change
[ ] Refactor
[ ] Documentation
[ ] Other (please describe)

Codecov Report

Merging #166 (ceac41d) into main (e6f8400) will decrease coverage by 0.46%.
The diff coverage is 0.00%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
@@            Coverage Diff             @@
##             main     #166      +/-   ##
==========================================
- Coverage   31.67%   31.22%   -0.46%
==========================================
  Files          28       29       +1
  Lines        3643     3696      +53
==========================================
  Hits         1154     1154
- Misses       2398     2451      +53
  Partials       91       91

Impacted Files
Coverage Δ

cmd/config/config.go
26.90% <0.00%> (-1.60%)
:arrow_down:

cmd/config/delete.go
0.00% <0.00%> (ø)

This PR is replaced with #180 which just cherry-picks the deletion command and resolves merge conflicts.


Support file descriptor mapping

As brought up by @guybedford in https://github.com/nodejs/wasi/pull/24#issuecomment-536692167. uvwasi_init() should take an option for mapping file descriptors (like it currently supports mapping preopen directories). This will more effectively sandbox WASI applications from each other and their host environment.

Fixed in https://github.com/cjihrig/uvwasi/pull/16.


Latest Package.json showing version 0.0.0

Latest package.json is showing   "version": "0.0.0",
Is it a typo or intentionally updated?

Not sure what happened here, but it has since been fixed.


Is there a way to directly access one of the fields in tasks.fields in a Progress Bar?

Hi, first of all this library is really really great, thank you for the great work.
As for the subject of this post, I currently have a progress bar defined by:
progress_bar = Progress(
    "[blue]{task.description}",
    BarColumn(),
    "[progress.percentage]{task.percentage:>3.0f}%",
    TimeRemainingColumn(),
    "[yellow]{task.fields}",  # <-- relevant part
)
task = self.progress_bar.add_task(label, total=total_frames)

I am updating it with bar.update(self.task, advance=1, fps=f"{fps:.2f}") and it runs just fine, with the progress bar displaying my fps as part of a dict, which would look something like {'fps': '6.60'} at the end of the progress bar. This is a bit unsightly in my opinion, as I'd really prefer not to print it as a dict, with all its {s and 's. I would prefer to be able to chose exactly in what format my fields get printed in the progress bar.
Is there a way to chose exactly which field to show and with what format, without printing as a dict? I tried things like "[yellow]{task.fields.fps}fps" or "[yellow]{task.fields['fps']}fps" but it doesn't work.
If this is not the case of me missing something obvious, it would be great to have this as a feature as it would allow us to chose how our custom fields look like.
Thanks for the awesome library by the way!

Hi,
The progress class uses str.format to do the formatting, which uses a counter-intuitive way of doing dictionary lookups. Try "[yellow]{task.fields[fps]}"

Hi, thanks for answering, tried that but I get a KeyError: 'fps' error. If I remove the [fps] from your solution it works fine buy I get the whole dict  {'fps': 6.47}.

Have you given fps an initial value in add_task ?

No I hadn't. That fixed it! Thanks a lot! Closing the issue.

Sorry to revive this issue, but I have a short question and didn't think it was worth it creating another issue for it. Is it possible to use ipdb while displaying a progress bar? I am currently trying and failing as the progress bar seems to take control of the cursor and deletes any character I write in ipdb immediately after I type it. This makes it very hard to debug programs which use progress bars. Tried setting redirect_stderr and redirect_stdout to False but no dice.

Both are writing to stdout, so it might be a problem.
Possibly the refresh thread is making it worse. Try setting auto_refresh=False for testing

Perfect, that fixed it, thanks a lot again! I don't think I've ever seen a dev answer so quickly on such a large open source project, kudos!
PD: For anyone reading this issue, if you want ipdb or pdb to work with rich set:
redirect_stderr=False
redirect_stdout=False
auto_refresh=False

in your Progress() constructor, and refresh your progress bar manually in your update method by setting refresh=True there.


Add --volume-mode flag in image-upload to allow specifying volume mode

What this PR does / why we need it:
This Pull Request aims to introduce a volume-mode flag to allow specifying either filesystem or block volume modes in image-upload.
This behavior also marks the old block-volume flag as deprecated, which only allows specifying block mode.
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Special notes for your reviewer:
Unsure about the consequences of marking block-volume as deprecated. The flag is still usable and feels redundant since the new one allows both volume modes, but feel free to argue otherwise.
Release note:

Add --volume-mode flag in image-upload

/test pull-kubevirt-apidocs

/test pull-kubevirt-e2e-k8s-1.26-sig-storage

/approve

/lgtm


Improving performance for "Find All References" command

dotTrace log before fix:

dotTrace log after fix:

@Neverbirth please review this PR


Cleaning up spawn logic

Modifying spawn logic to not require a new flag, and eliminating a number of class fields and passing data as arguments instead.
Testing:

Verified that spawning works.
Verified that meditation results in spawning in the same location.
Verified that going back to the title screen and re-entering the game results in a new spawn location.

Git did some weird stuff with line endings in this commit. The only file that has changed is OuterWildsRandomSpeedrun.cs.


Update cruft

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 94.31%. Comparing base (e7bc00f) to head (be94dcd).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #344   +/-   ##
=======================================
  Coverage   94.31%   94.31%
=======================================
  Files           6        6
  Lines         299      299
=======================================
  Hits          282      282
  Misses         17       17

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


REQUIRE Edited.

Sorry for the noise with the PR's ! This must have been included in the previous PR #26 . Hoping this works !

I think this should work.

Merging this !


"NumTables" should be "numTables"

In the description of rangeShift, "NumTables" should be "numTables".

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 6a1bda96-a268-b684-6cea-9b0c7be6f24e
Version Independent ID: 36485fec-f05d-3984-6da8-ff2dd2799041
Content: OpenType font file - Typography
Content Source: typographydocs/opentype/spec/otff.md
Product: typography
GitHub Login: @PeterCon
Microsoft Alias: PeterCon

Changed for next version.


Update ru.yaml

This makes sense? we build this with all separated translated words, I don't know if makes sense in every language.

We also should translate "Russian rubles" to just рубль, right?

No, will fix
On Sat, Mar 19, 2022 at 15:34, Francisco Calderón @.***> wrote:

This makes sense? we build this with all separated translated words, I don't know if makes sense in every language.
photo_2022-03-19_11-32-30
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: @.***>

RUB
------- Original Message -------
On Saturday, March 19th, 2022 at 3:39 PM, Francisco Calderón @.***> wrote:

We also should translate "Russian rubles" to just рубль, right?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: @.***>

I can't find the ru.yaml file that I worked on yesterday... Should I do it again on my forked version and submit Pull Request? Can we better talk in Telegram? I'm @impalor
------- Original Message -------
On Saturday, March 19th, 2022 at 3:37 PM, Francisco Calderón @.***> wrote:

@grunch requested changes on this pull request.
there is a new string to be translated buyer_took_your_order
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: @.***>

PR fails (((
2s
Run npm test

<EMAIL_ADDRESS>test /home/runner/work/p2plnbot/p2plnbot
mocha --exit tests/

Telegram bot test
✔ should start (134ms)
✔ should return /sell help (112ms)
1) should create a /sell
✔ should return /buy help (109ms)
Testing lighting network
✔ Should create hold invoice
4 passing (601ms)
1 failing

Telegram bot test
should create a /sell:
AssertionError: expected 3 to equal 4

expected - actual

-3
+4
at Context. (tests/bot_test.js:79:41)

npm ERR! Test failed.  See above for more details.
Error: Process completed with exit code 1.

hang on, I think I figured out what to do
------- Original Message -------
On Saturday, March 19th, 2022 at 10:42 PM, impalor @.***> wrote:

I can't find the ru.yaml file that I worked on yesterday... Should I do it again on my forked version and submit Pull Request? Can we better talk in Telegram? I'm @impalor
------- Original Message -------
On Saturday, March 19th, 2022 at 3:37 PM, Francisco Calderón @.***> wrote:

@grunch requested changes on this pull request.
there is a new string to be translated buyer_took_your_order
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: @.***>

Please see if it works now

I fixed the file in PR, hope it will compile and make sense
On Sat, Mar 19, 2022 at 15:34, Francisco Calderón @.***> wrote:

This makes sense? we build this with all separated translated words, I don't know if makes sense in every language.
photo_2022-03-19_11-32-30
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: @.***>

You should work with the ru.yaml version on main branch, you need to update your p2plnbot repository to be even with main branch

I can't find the ru.yaml file that I worked on yesterday... Should I do it again on my forked version and submit Pull Request? Can we better talk in Telegram? I'm @impalor
------- Original Message -------
On Saturday, March 19th, 2022 at 3:37 PM, Francisco Calderón @.***> wrote:

@grunch requested changes on this pull request.
there is a new string to be translated buyer_took_your_order
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: @.***>

Did my update to PR not work? WilI look tomorrow, I’m in CET time zone...
On Sun, Mar 20, 2022 at 00:24, Francisco Calderón @.***> wrote:

You should work with the ru.yaml version on main branch, you need to update your p2plnbot repository to be even with main branch

I can't find the ru.yaml file that I worked on yesterday... Should I do it again on my forked version and submit Pull Request? Can we better talk in Telegram? I'm @.(https://github.com/impalor)
------- Original Message -------
On Saturday, March 19th, 2022 at 3:37 PM, Francisco Calderón @.> wrote:

@.***(https://github.com/grunch) requested changes on this pull request.
there is a new string to be translated buyer_took_your_order
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: @.***>

—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: @.***>

I can't merge this PR cause tests keep failing, I will add this fix in another commit


[Feedback] Feedback page should be a line item in the Settings tab

Dev Home version
No response
Windows build number
No response
Other software
No response
Steps to reproduce the bug
Description
Feedback currently has it's own entry point in the left nav. It should be grouped in under the settings entry point, as a line item in settings.
Expected result
No response
Actual result
No response
Included System Information
No response
Included Extensions Information
No response

May I take this one? I would like to start contributing and familiarizing myself with the codebase.

Hey @jaypey, thank you for the interest in contributing!  It's all yours!  Please feel free to reach out with any questions.

Hey @jaypey! Checking in on this, we're planning a release soon - would you still like to do this feature or shall we reassign? Thanks!

Hey @cinnamon-msft , unfortunately I've had problems building the project last week due to nuget packages that seemed locked behind an auth. I found #734 which seems related to my problem, but I haven't been able to resolve it yet.
I see that the milestone is due for June 16, could I get this week to work on it and update you then?