[Bug]: Autoupgrade nodes seems to lead to not ready nodes that need manual reboots

Description
I notice many nodes become NotReady and don't come back without manually rebooting them from the CLI or cloud console.
Kube.tf file
"kube-hetzner" {

  providers = {
    hcloud = hcloud
  }

  hcloud_token = var.hcloud_token
  source       = "kube-hetzner/kube-hetzner/hcloud"
  version      = "2.13.3"

  ssh_port           = 22242
  ssh_public_key     = file("~/.ssh/id_ed25519.pub")
  ssh_private_key    = file("~/.ssh/id_ed25519")
  ssh_max_auth_tries = 10

  network_region = "eu-central"

  control_plane_nodepools = [
    {
      name        = "master-0",
      server_type = "ccx13",
      location    = "hel1",
      labels      = [],
      taints      = [],
      count       = 1

      backups = true
    },
    {
      name        = "master-1",
      server_type = "ccx13",
      location    = "fsn1",
      labels      = [],
      taints      = [],
      count       = 1

      backups = true
    },
    {
      name        = "master-2",
      server_type = "ccx13",
      location    = "nbg1",
      labels      = [],
      taints      = [],
      count       = 1

      backups = true
    },
  ]

  agent_nodepools = [
    {
      name        = "large",
      server_type = "cpx31",
      location    = "fsn1",
      labels = [
        "nodepool.replaced.dev/name=large"
      ],
      taints          = [],
      count           = 10
      placement_group = "large"
      backups         = true
    },
    {
      name        = "longhorn",
      server_type = "ccx23",
      location    = "fsn1",
      labels = [
        "node.longhorn.io/create-default-disk=true",
        "nodepool.replaced.dev/name=longhorn"
      ],
      taints          = [],
      count           = 4
      placement_group = "longhorn"
      backups         = true
    },
    {
      name        = "egress",
      server_type = "cpx21",
      location    = "fsn1",
      labels = [
        "node.kubernetes.io/role=egress",
      ],
      taints = [
        "node.kubernetes.io/role=egress:NoSchedule"
      ],
      floating_ip     = true
      placement_group = "egress"
      count           = 1
    },
    {
      name        = "static",
      server_type = "ccx13",
      location    = "fsn1",
      labels = [
        "nodepool.replaced.dev/name=static"
      ],
      taints          = [],
      count           = 1
      placement_group = "static"
      backups         = true
      selinux         = false
    },
  ]

  # Add custom control plane configuration options here.
  # E.g to enable monitoring for etcd, proxy etc:
  # control_planes_custom_config = {
  #  etcd-expose-metrics = true,
  #  kube-controller-manager-arg = "bind-address=<IP_ADDRESS>",
  #  kube-proxy-arg ="metrics-bind-address=<IP_ADDRESS>",
  #  kube-scheduler-arg = "bind-address=<IP_ADDRESS>",
  # }

  k3s_registries = <<-EOT
    mirrors:
      registry.gitlab.com:
        endpoint:
        - "https://trow.replaced.dev"
        rewrite:
          "^gitlab-org/(.*)": "f/gitlab/gitlab-org/$1"
  EOT

  enable_wireguard = false

  load_balancer_type     = "lb11"
  load_balancer_location = "fsn1"

  load_balancer_disable_ipv6 = true

  load_balancer_health_check_interval = "5s"

  load_balancer_health_check_timeout = "3s"

  load_balancer_health_check_retries = 3

  autoscaler_nodepools = [
    {
      name        = "autoscaled-large"
      server_type = "cpx31"
      location    = "fsn1"
      labels = {
        "node.kubernetes.io/role" : "peak-workloads"
        "nodepool.replaced.dev/name" : "autoscaled-large"
      },
      taints    = []
      min_nodes = 1
      max_nodes = 5
    }
  ]
  autoscaler_labels = [
    "node.kubernetes.io/role=peak-workloads"
  ]

  cluster_autoscaler_image            = "registry.k8s.io/autoscaling/cluster-autoscaler"
  cluster_autoscaler_version          = "v1.27.3"
  cluster_autoscaler_log_level        = 4
  cluster_autoscaler_log_to_stderr    = true
  cluster_autoscaler_stderr_threshold = "WARNING"

  cluster_autoscaler_extra_args = [
    "--ignore-daemonsets-utilization=true",
    "--enforce-node-group-min-size=true",
    "--leader-elect=false"
  ]

  disable_hetzner_csi = false

  ingress_controller = "none"

  ingress_replica_count = 2

  enable_metrics_server = true

  allow_scheduling_on_control_plane = false

  automatically_upgrade_k3s = true

  automatically_upgrade_os = true

  enable_longhorn = true

  longhorn_namespace = "longhorn-system"

  longhorn_fstype = "ext4"

  longhorn_replica_count = 2

  # If you need more control over kured and the reboot behaviour, you can pass additional options to kured.
  # For example limiting reboots to certain timeframes. For all options see: https://kured.dev/docs/configuration/
  # The default options are: `--reboot-command=/usr/bin/systemctl reboot --pre-reboot-node-labels=kured=rebooting --post-reboot-node-labels=kured=done --period=5m`
  # Defaults can be overridden by using the same key.
  # kured_options = {
  #   "reboot-days": "su"
  #   "start-time": "3am"
  #   "end-time": "8am"
  #   "time-zone": "Local"
  # }

  initial_k3s_channel = "v1.27"

  cluster_name = "infra"

  use_cluster_name_in_node_name = true

  k3s_exec_agent_args = "--kubelet-arg kube-reserved=cpu=100m,memory=200Mi,ephemeral-storage=1Gi"

  restrict_outbound_traffic = false

  cni_plugin = "cilium"

  cilium_routing_mode = "native"

  cilium_egress_gateway_enabled = true

  disable_network_policy = true

  block_icmp_ping_in = true

  enable_cert_manager = false

  use_control_plane_lb = true

  control_plane_lb_type = "lb21"

  control_plane_lb_enable_public_interface = true

  cilium_values = <<EOT
ipam:
  mode: kubernetes
k8s:
  requireIPv4PodCIDR: true
kubeProxyReplacement: strict
routingMode: native
ipv4NativeRoutingCIDR: "<IP_ADDRESS>/8"
l7Proxy: false
endpointRoutes:
  enabled: true
loadBalancer:
  acceleration: native
bpf:
  masquerade: true
egressGateway:
  enabled: true
MTU: 1450
EOT

  longhorn_values = <<EOT
defaultSettings:
  createDefaultDiskLabeledNodes: true
  defaultDataPath: /var/lib/longhorn
  node-down-pod-deletion-policy: delete-both-statefulset-and-deployment-pod
  replicaAutoBalance: best-effort
  storageReservedPercentageForDefaultDisk: 15
persistence:
  defaultFsType: ext4
  defaultClassReplicaCount: 2
  defaultClass: false
  defaultNodeSelector:
    enable: true
    selector: "longhorn"
EOT

  enable_rancher = false

  extra_kustomize_parameters = {
    floating_ip            = "blah"
    tls_crt                = <<EOH
    ${data.google_secret_manager_secret_version.sealed-secrets-tls-crt.secret_data}
    EOH
    tls_key                = <<EOH
    ${data.google_secret_manager_secret_version.sealed-secrets-tls-key.secret_data}
    EOH
    cert_manager_values    = <<EOH
    prometheus:
      enabled: false
    serviceAccount:
      create: true
      name: cert-manager
    cainjector:
      enabled: true
    extraArgs:
    - --cluster-issuer-ambient-credentials=false
    - --issuer-ambient-credentials=false
    - --leader-elect=false
    installCRDs: true
    ingressShim:
      defaultIssuerKind: ClusterIssuer
      defaultIssuerName: google-dns-public-ca
    maxConcurrentChallenges: 60
    replicaCount: 1
    webhook:
      enabled: true
    EOH
    external_dns_values    = <<EOH
    google:
      project: blah
      serviceAccountSecret: google-dns-secrets
      serviceAccountSecretKey: key.json
    logLevel: info
    metrics:
      enabled: false
      serviceMonitor:
        enabled: false
    policy: sync
    registry: txt
    serviceAccount:
      create: true
      name: external-dns
    provider: google
    EOH
    gitlab_postgres_values = <<EOH
    fullnameOverride: "gitlab-postgres"
    image:
      registry: docker.io
      repository: bitnami/postgresql
      tag: 15.4.0-debian-11-r10
      digest: ""
    auth:
      enablePostgresUser: true
      username: "gitlab"
      database: "gitlab"
      existingSecret: "gitlab-secrets"
      secretKeys:
        adminPasswordKey: postgres-user-password
        userPasswordKey: postgres-gitlab-password
      usePasswordFiles: false
    architecture: standalone
    postgresqlDataDir: /postgresql/data
    postgresqlSharedPreloadLibraries: pgaudit
    shmVolume:
      enabled: true
      sizeLimit: 2Gi
    tls:
      enabled: false
    primary:
      name: primary
      pgHbaConfiguration: |-
        local all all trust
        host all all localhost trust
        host gitlab gitlab <IP_ADDRESS>/8 md5
      extendedConfiguration: |-
        max_connections = 300
      standby:
        enabled: false
      resources:
        limits:
          memory: 4Gi
          cpu: 4
        requests:
          memory: 4Gi
          cpu: 250m
      service:
        externalTrafficPolicy: Local
      persistence:
        enabled: true
        mountPath: /postgresql
        storageClass: "hcloud-durable"
        accessModes:
          - ReadWriteOnce
        size: 32Gi
      persistentVolumeClaimRetentionPolicy:
        enabled: true
        whenScaled: Retain
        whenDeleted: Retain
      podAnnotations:
        backup.velero.io/backup-volumes: data
    EOH
    ingress_nginx_values   = <<EOH
    commonLabels:
      team: shared-infra
    controller:
      admissionWebhooks:
        enabled: true
      affinity:
        podAntiAffinity:
          preferredDuringSchedulingIgnoredDuringExecution:
          - podAffinityTerm:
              labelSelector:
                matchExpressions:
                - key: app.kubernetes.io/name
                  operator: In
                  values:
                  - ingress-nginx
              topologyKey: kubernetes.io/hostname
            weight: 100
      autoscaling:
        enabled: false
      ingressClass: nginx
      ingressClassByName: false
      ingressClassResource:
        controllerValue: k8s.io/ingress-nginx
        default: true
        enabled: true
        name: nginx
      keda:
        enabled: false
      config:
        client-body-buffer-size: 10M
        disable-ipv6-dns: 'true'
        disable-ipv6: 'true'
        enable-brotli: 'false'
        enable-modsecurity: 'false'
        enable-ocsp: 'true'
        enable-opentracing: 'false'
        enable-underscores-in-headers: 'true'
        enable-vts-status: 'false'
        hsts-include-subdomains: 'true'
        hsts-max-age: '31536000'
        hsts-preload: 'true'
        hsts: 'true'
        ignore-invalid-headers: 'false'
        keep-alive: '60'
        log-format-escape-json: 'false'
        log-format-escape-none: 'false'
        nginx-status-ipv4-whitelist: '<IP_ADDRESS>,<IP_ADDRESS>/8'
        no-auth-locations: /.well-known/acme-challenge, /-/healthy, /health
        proxy-body-size: '0'
        proxy-buffering: 'off'
        proxy-connect-timeout: '60'
        proxy-next-upstream-timeout: '60'
        proxy-next-upstream-tries: '4'
        proxy-read-timeout: '60'
        proxy-request-buffering: 'off'
        proxy-send-timeout: '60'
        server-tokens: 'false'
        ssl-early-data: 'true'
        ssl-redirect: 'true'
        ssl-reject-handshake: 'true'
        use-gzip: 'true'
        use-http2: 'true'
      enableMimalloc: true
      image:
        digest: ''
      lifecycle:
        preStop:
          exec:
            command:
            - /wait-shutdown
      livenessProbe:
        httpGet:
          path: "/healthz"
          port: 10254
          scheme: HTTP
        failureThreshold: 5
        initialDelaySeconds: 10
        periodSeconds: 10
        successThreshold: 1
        timeoutSeconds: 1
      metrics:
        enabled: false
        serviceMonitor:
          enabled: false
      minAvailable: 1
      publishService:
        enabled: true
      replicaCount: 2
      resources:
        limits:
          memory: 1024Mi
        requests:
          cpu: 250m
          memory: 1024Mi
      service:
        enabled: true
        annotations:
          load-balancer.hetzner.cloud/disable-private-ingress: true
        externalTrafficPolicy: Local
      startupProbe:
        httpGet:
          path: "/healthz"
          port: 10254
          scheme: HTTP
        initialDelaySeconds: 5
        periodSeconds: 5
        timeoutSeconds: 2
        successThreshold: 1
        failureThreshold: 5
      terminationGracePeriodSeconds: 300
      useComponentLabel: true
    tcp:
      "22": "gitlab/gitlab-gitlab-shell:22"
    defaultBackend:
      enabled: true
    EOH
  }

  create_kubeconfig = true

  create_kustomization = false
}

Screenshots
No response
Platform
Linux

@sharkymcdongles No idea what could be happening, but I would suggest using our default cilium config instead. So remove cilium_values and try again.

This is a recurring issue I noticed over the last couple of weeks, still investigating. It's most likely something related to all of our custom networking + microos + hetzner. For the time being, disable autoupgrades.

And getting cilium to work well on Hetzner is super tricky, hence my above suggestion.

I took what is documented here:
https://github.com/kube-hetzner/terraform-hcloud-kube-hetzner/blob/master/README.md#examples
Sadly, given the hetzner IP blacklist bs, using an egressgateway is the only way to ensure the cluster works with autoscaling because many images are stored in ghcr and hetzner ips are randomly blocked there. It's also needed for things like SMTP since many SMTP providers also block hetzner IPs.
I will do some digging and see if maybe I can find out why this happens. I disabled autoupgrades now for both nodes and k3s yet some nodes still had the same behavior.
So I did some digging and it looks like it still tried to do an upgrade leading to the NotReady nodes situation again. When I change autoupgrades to off does it not reflect it for already provisioned nodes? Do I need to remove kured?
Checking the logs I see the upgrade runs then the CPU gets locked and NetworkManager gets stuck fully killing the networking for the node since it never recovers. I then see all these CPU stuck errors.
Mar 28 04:38:08 infra-large-btl kernel: watchdog: BUG: soft lockup - CPU#3 stuck for 26s! [NetworkManager:2151]
Mar 28 04:38:08 infra-large-btl kernel: Modules linked in: algif_hash af_alg ext4 mbcache jbd2 udp_diag inet_diag ip_set xt_CT cls_bpf sch_ingre>
Mar 28 04:38:08 infra-large-btl kernel:  xhci_pci xhci_pci_renesas libata aesni_intel xhci_hcd virtio_scsi crypto_simd sd_mod cryptd t10_pi sg u>
Mar 28 04:38:08 infra-large-btl kernel: CPU: 3 PID: 2151 Comm: NetworkManager Not tainted 6.7.2-1-default #1 openSUSE Tumbleweed e152b88f51363d1>
Mar 28 04:38:08 infra-large-btl kernel: Hardware name: Hetzner vServer/Standard PC (Q35 + ICH9, 2009), BIOS 20171111 11/11/2017
Mar 28 04:38:08 infra-large-btl kernel: RIP: 0010:virtnet_send_command+0x106/0x170 [virtio_net]
Mar 28 04:38:08 infra-large-btl kernel: Code: 74 24 48 e8 fc 6b b8 c6 85 c0 78 60 48 8b 7b 08 e8 0f 4c b8 c6 84 c0 75 11 eb 22 48 8b 7b 08 e8 20>
Mar 28 04:38:08 infra-large-btl kernel: RSP: 0018:ffffbf9c40853a08 EFLAGS: 00000246
Mar 28 04:38:08 infra-large-btl kernel: RAX:<PHONE_NUMBER>000000 RBX: ffff999ec1f229c0 RCX:<PHONE_NUMBER>000001
I am attaching my full log file from when this happened to see if maybe someone here can shine some light on it.
logs.txt
I wonder if maybe the networking can't handle autoupgrades or updates given my settings? No idea tbh, but it'd be nice if this were solved or someone knew. I will continue researching on my end, but I think more heads are better than 1.

It's possible. So try switching to default networking settings, remove cilium_values and see if it works better.

@sharkymcdongles Any updates, did the suggestion work?

@mysticaltech I haven't moved back to default cilium settings yet because I am working on a new way of handling images not pulling without the egress gateway. I am currently evaluating using a squid proxy as a replacement. Since disabling autoupgrades though I have had no further issues.

Ok, great! The proxy solution sounds awesome. Don't hesitate to share in due time if you see fit.
We are narrowing down the automated upgrade issues in other threads, so will close this one for now.


[Server] Multicluster: Feed back context persistence

Description
Meshery server now responds with the summary of persistence of k8s contexts. The response contains InsertedContexts, UpdatedContexts and ErroredContexts arrays containing k8s contexts that were inserted, updated and errored while inserting respectively.
To do:

[ ] Make corresponding snackbars for Inserted Contexts (green), Updated Contexts (yellow) and Errored Contexts (red) on the UI

This PR fixes #5873
Notes for Reviewers
Also review the corresponding PR in meshery cloud
Signed commits

[x] Yes, I signed my commits.

Codecov Report

Merging #5884 (c7de7fc) into master (aaec340) will decrease coverage by 4.38%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #5884      +/-   ##
==========================================
- Coverage   17.92%   13.54%   -4.39%
==========================================
  Files         107      107
  Lines        9924     9931       +7
==========================================
- Hits         1779     1345     -434
- Misses       7709     8296     +587
+ Partials      436      290     -146

Flag
Coverage Δ

gointegrationtests
?

unittests
13.54% <0.00%> (-0.01%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

handlers/error.go
0.00% <ø> (ø)

handlers/k8sconfig_handler.go
0.00% <0.00%> (ø)

mesheryctl/internal/cli/root/system/update.go
1.05% <0.00%> (-58.95%)
:arrow_down:

mesheryctl/internal/cli/root/system/start.go
1.88% <0.00%> (-55.19%)
:arrow_down:

mesheryctl/internal/cli/root/system/status.go
1.14% <0.00%> (-55.18%)
:arrow_down:

mesheryctl/internal/cli/root/system/restart.go
1.92% <0.00%> (-48.08%)
:arrow_down:

mesheryctl/internal/cli/root/system/stop.go
2.00% <0.00%> (-46.67%)
:arrow_down:

mesheryctl/internal/cli/root/system/logs.go
3.26% <0.00%> (-36.96%)
:arrow_down:

mesheryctl/internal/cli/root/system/check.go
1.03% <0.00%> (-23.03%)
:arrow_down:

mesheryctl/internal/cli/root/system/dashboard.go
1.70% <0.00%> (-9.41%)
:arrow_down:

... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df9eb35...c7de7fc. Read the comment docs.

@leecalcote Does this look okay? I can then move forward with making the snackbars

@AakashRaj20 do you think you can handle the UI part of this, or would you want to try a good first issue to start?
What we want are individual snackbars for each kubernetes context. The kubernetes contexts are returned by the server on uploding the kubeconfig. In this PR, the response has the format
{
"inserted_contexts": [],
"updated_contexts": [],
"errored_contexts": [],
}

Each context in those arrays has two feilds - name and server
we want to display both the name and the server in the snackbars for each context.
The color of the snackbars would be

Green for inserted_contexts (along with success message)
Yellow for updated_contexts (along with a message saying the context already existed)
Red for errored_contexts (along with a failure message)

@AakashRaj20 do you think you can handle the UI part of this, or would you want to try a good first issue to start?
What we want are individual snackbars for each kubernetes context. The kubernetes contexts are returned by the server as a response on uploding the kubeconfig. In this PR, the response has the format
{
"inserted_contexts": [],
"updated_contexts": [],
"errored_contexts": [],
}

Each context in those arrays has two fields - name and server we want to display both the name and the server in the snackbars for each context. The color of the snackbars would be

Green for inserted_contexts (along with success message)
Yellow for updated_contexts (along with a message saying the context already existed)
Red for errored_contexts (along with a failure message)

@YashKamboj, perhaps, you can knock this out?

@AakashRaj20 do you think you can handle the UI part of this, or would you want to try a good first issue to start?
What we want are individual snackbars for each kubernetes context. The kubernetes contexts are returned by the server as a response on uploding the kubeconfig. In this PR, the response has the format
{
"inserted_contexts": [],
"updated_contexts": [],
"errored_contexts": [],
}

Each context in those arrays has two fields - name and server we want to display both the name and the server in the snackbars for each context. The color of the snackbars would be

Green for inserted_contexts (along with success message)
Yellow for updated_contexts (along with a message saying the context already existed)
Red for errored_contexts (along with a failure message)

@YashKamboj, perhaps, you can knock this out?

Hey @leecalcote so sorry for the late reply I had my external labs for college if its still okay I can try the UI part in this issue or it can be a new issue.

@AakashRaj20, I understand. Have you contributed to Meshery UI previously? If not, have you compiled Meshery Server and Meshery UI?

@leecalcote Ok, i will tak a look into it

@YashKamboj Any updates on this?

@YashKamboj we’ll want to bump this to the top of your priority list.

Merge the PR in meshery-cloud before merging this one

@leecalcote This is also ready to be merged

Refreshing…

@leecalcote Ready to merge?

I missed this. SGTM


System disarmed unexpectedly

If I activate the Blink system via Home app, next time I open the app the system is deactivated.
plugin version: v1.0.0
homebridge version: v1.0.4
The plugin was successfully verified as new device before.

Facing the exact same problem here.  Activate switch in Home app and Blink system correctly arms. But go back into Home app and Blink switch now shows as disarmed, although the Blink system in actual fact remains armed.

I'm seeing this as well for just the "Systems". I'm investigating.

This PR fixes this problem. 1.0.1 should be out shortly
https://github.com/bartdorsey/homebridge-blinkcameras/pull/16


Column not found exception. I don't know why

This CSV file
`
"VarName";"TimeString";"VarValue";"Validity";"Time_ms"
"TT_TK-001";"31/07/2020 11:34:43";0;0;44043482447,9051
"TT_TK-001";"31/07/2020 11:35:14";0;0;44043482796,0532
"TT_TK-001";"31/07/2020 11:44:43";48,6292;1;44043489384,1204
"TT_TK-001";"31/07/2020 11:45:13";48,19878;1;44043489730,9259
"$RT_OFF$";"31/07/2020 11:45:26";0;2;44043489885,5324
"TT_TK-001";"31/07/2020 11:52:34";25,58232;1;44043494838,6111
"TT_TK-001";"31/07/2020 11:53:04";25,54253;1;44043495185,4977
"$RT_OFF$";"31/07/2020 11:53:12";0;2;44043495274,5602
"$RT_COUNT$";9;;;;
`
and this code
'
rapidcsv::Document doc(path_2_csv.generic_string().c_str(),
rapidcsv::LabelParams(0, 0),
rapidcsv::SeparatorParams(';'));
auto varname_vector    = doc.GetColumn("VarName");
'
throws that excepcion in rapidcsv.h line 512
template<typename T>
std::vector<T> GetColumn(const std::string& pColumnName) const
{
    const ssize_t columnIdx = GetColumnIdx(pColumnName);
    if (columnIdx < 0)
    {
        throw std::out_of_range("column not found: " + pColumnName);
    }
    return GetColumn<T>(columnIdx);
}

Do you know why?. Is it because of the last line?
Thanks

I think the problem occurs because by
rapidcsv::LabelParams(0, 0),
you define that the leftmost column contains row names instead of data.
When you instead use
rapidcsv::LabelParams(0, -1),
meaning "no row names" (which is the default), it should work.
Hope this helps you.

I did a quick test on my system, it works with your CSV. The last line is not a problem here.

You're right.
It wasn't clear to me the LabelParams value meaning.
Thaks a lot for this wonderful library.

Thanks @Sven-HP for helping with this 👍

Thaks a lot for this wonderful library.

Good to hear positive feedback. 👍


An exception occurred: KeyError 'messages'.

Settings from a $setting instance was not obtained hence forth the channel Id was removed from the list of channel it can interact with causing an issue because you can’t run code on null
Sent from my iPhone

On Jul 26, 2022, at 10:33 PM, hgartemis3515 @.***> wrote:

—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.

Closing with settings instance were not found causing the channel Id to be removed from the bot returning a null


iPadOS: cannot resize sidebar via touch

Refs: https://github.com/microsoft/vscode/issues/85990
I can not resize the sidebar sash easily, works fine for editor sashes. Maybe we should increase the size of the sashes when touch is enabled.

Agree, we can probably adding some affordance to the sash especially when the sash is being clicked.

I am no longer seeing this, seems to work fine now.


Add my GSoD proposal

Signed-off-by: Xiaoya Xia<EMAIL_ADDRESS>

I initiated this pr on GitHub, but it seems I got the wrong DCO format. I think I will close this one and submit a new PR.


Blank Touch Bar

Whenever I run TBS, it is completely blank and I am lost as to how to change that. Doesn't show any contextual buttons for apps, just sits there blank.
I tried to figure this out on my own, but when I searched for a solution, everyone just seemed to be talking about how it worked.
On iMac 2019 running Catalina 10.15.5. I did nothing beyond downloading and launching the app.

See: https://github.com/sindresorhus/touch-bar-simulator/issues/61
Does it work if you restart your computer?

FYI my app, Touché, suffers the same exact problem starting, I think, with 10.15.5.

Probably worth mentioning: in my tests the issue only occurs if the Mac in question does not have a Touch Bar itself. At least, it works on my late-2016 MacBook Pro, but I'm able to reproduce the bug easily on a Mac Mini.

@danielpunkass Sorry. I totally forgot to answer you on Slack. I wanted to test before answering and then obviously forgot.
I wonder if this is the same as https://github.com/sindresorhus/touch-bar-simulator/issues/61? On your Mac Mini does Touché not work at all, even after restarting the computer?

I don't think it's the same as #61 because as far as I have been able to tell the blank Touch Bar is new to 10.15.5. It sounds ike #61 has been around for a long time and it was not clear from the description if the touch bar is actually blank or not. It sounds like it's just not registering clicks in that case.
I just rebooted my Mac Mini and confirmed the Touch Bar is still blank. Have you confirmed the Touch Bar Simulator works on ANY 10.15.5 Mac that doesn't also have a hardware Touch Bar?

Works on My Machine™, Macbook Pro from 2015 (before the touch bar existed).

@ThatsJustCheesy Interesting! And this is on 10.15.5?

@danielpunkass Yup. To be specific, it's a MacbookPro12,1 (the 13-in) on 10.15.5.

I just tried on my MacBook Pro 2013 (without native Touch Bar) and Touch Bar Simulator is just black there.

@sindresorhus I'm glad you're able to reproduce it at least. I think in our Slack conversation I shared some preliminary thoughts about it. I'm really not sure though how hard it will be to fix, or even if it's possible.

I had the same issue but fixed it by restarting the system. Thanks

Same problem here with it loading blank. macOS 10.15.5.
The documentation's suggestion to restart your computer and never open XCode (without having to restart again) is quite disruptive and isn't exactly a net gain in terms of convenience for those of us who use XCode. Other issues (e.g. https://github.com/sindresorhus/touch-bar-simulator/issues/61) allude to the overall flakiness on Catalina.
If you're an XCode user on Catalina and looking for a convenient way to access the touch bar, the most convenient thing is to just leave XCode open in the background and access the touch bar from the Window menu.

So what is the solution for this issue?
The touch bar from xcode works fine, but when I open TBS, both touch bars(xcode touch bar and TBS) go to black.
I am running on a Mac mini with an M1 chip.

Seems like it only works for a couple of time until it don't, then you have to restart to make it work again.
This is the same on Big Sur and Monterey. DFRSetStatus set back to initial value also doesn't help. I suspect there're some changes in the private framework that might require you to call some additional function to free out resources? I'm happy to dig a bit into the binary but not sure of the outcome.

@danielpunkass It looks like you solved this. Care to share the answer, please? Thank you!

@pktmterenceg Give this project a look - does it work for you? If so maybe it will provide the clues to how to update this one if it's still not working. https://github.com/jslegendre/TouchBar-Simulator

@danielpunkass Thanks for the quick response!
Full confession: I'm not a Swift coder (yet?) and it appears that repo suffers from a change between Swift (n<4) to Swift (n>=4) which has broken the build there. (I'm struggling through it, but it appears to be around serialization protocols.) So, I can't (yet?) say whether or not it works for me.
However: I've looked at the two side by side, paying special attention to any of the work around _stream, SLSDFRDisplayStreamCreate(), and so on, but I haven't spotted a difference yet. I've also played with https://github.com/zydeco/TouchBarServer and https://github.com/steventroughtonsmith/TouchBarScreenshotter. As far as I can tell, though, they're all more or less doing the same thing. (Heck, maybe they even borrowed liberally from each other?)
And, as far as I can tell, they all exhibit the same "blank view" described in this thread.
Best I've done so far is that it appears that anything checking the status return of SLSDFRDisplayStreamCreate() (i.e., (status == kCGDisplayStreamFrameStatusFrameComplete) ) never executes. But as for why... I'm stumped.
With gratitude,
pktmterenceg

@pktmterenceg It's been a while now since I sorted through this junk and my code is kind of integrated with other app-specific stuff, otherwise I would just spell it out more plainly what needs to be done. Let me take a quick look at this project again and see if I can reproduce the blankness. If I can maybe I can submit a fix.

@pktmterenceg FYI I found this workaround posted by @sindresorhus and confirmed it gets around the serialization issues you were running into: https://github.com/sindresorhus/Defaults/blob/main/workaround.md

Ah, take a look at this file https://github.com/jslegendre/TouchBar-Simulator/blob/25f6404315c00d0c96987fd2d5221cf836a44a72/TouchBarSimulatorService/TouchBarSimulatorService.m
See how it uses the "TouchBarSimulatorCreate" function? I think that's the difference between Touché and Touch Bar SImulator now. I'm using that function if it exists, and falling back to the older mechanism using DFRSetStatus only for older systems. I think if you can figure out how to integrate a similar split in functionality with Touch Bar Simulator, where it uses the newer mechanism when available, it will be as reliable as Touché is now.

@pktmterenceg Did you try downloading and running the latest release from that linked project? It seems to work for me. Does it not work for you? I think that other project is an open source example of one that is working like Touché does, but maybe I'm missing something subtly wrong if it's not working for you. Here's a screenshot of it running on my Mac (M1 Max, 12.3 (21E230)):

@danielpunkass Thank you, again, for helping me dig in to this.
The release here https://sindresorhus.com/touch-bar-simulator/ does not work for me, but Touché does. Not sure what to make of that, really.
With gratitude,
pktmterenceg

@danielpunkass Thank you - great catch!
I had multiple "simulator" projects open, and didn't pay enough attention to which was "active". You were right - this one does work for me!
Now, hopefully, none of the things I want to change will break that! Haha!
Again, I'm very grateful to you for your help and time.
With gratitude,
pktmterenceg

Great to hear it's working! That should be an effective lead for anybody who gets time to pursue integrating an equivalent fix in this project.

@danielpunkass Thanks again.
Yes, I think I'm going to explore possible differences and make notes here in this thread for future explorers.
Warmly,
pktmterenceg

Hey guys. I know this has been quite a long discussion and some of you might already forgot about this, but here's "somewhat" a solution that definitely would work:

Try setting the status all the way from 0..<7 works if you've encountered problems like this.

I've found a - at least temporary - solution to the problem:
Right click the menu bar icon, turn "Hide and Show Automatically" on, then off.
This fixed it for me.

Closing as this app is now discontinued.


Add tbaa for Enzyme

Before submitting
Please complete the following checklist when submitting a PR:

[ ] All new functions and code must be clearly commented and documented.

[ ] Ensure that code is properly formatted by running make format.
The latest version of black and clang-format-14 are used in CI/CD to check formatting.

[ ] All new features must include a unit test.
Integration and frontend tests should be added to frontend/test,
Quantum dialect and MLIR tests should be added to mlir/test, and
Runtime tests should be added to runtime/tests.

When all the above are checked, delete everything above the dashed
line and fill in the pull request template.

Context:
Description of the Change:
Benefits:
Possible Drawbacks:
Related GitHub Issues:

[sc-48560]

[sc-67742]

Oops, I think Erick had already added same reviews as mine. Ignore mine lol.

Thanks Romain! LGTM 🚀


Intent : cricket score is added

cricket score intent is added please take a look

#27

Closing this PR since I have deleted this branch and will not be able resolve conflicts, I will be creating a separate PR for this issue.


disable parent breadcrumb if there is no index file

i just like menu animation when you click some item that has no index.md file inside it. but it this case it should have any other .md file. and this file has breadcrumb like parent1 > parent2 > any.md
as parent2 doesn't have index.md in it, shouldn't it be right to disable that link to prevent "Page Not Found" page?
and...if it's possible, how can i apply that?

Hi,
is it on the master or development branch ?
I thought I fixed this on the development branch

master. i checked development - yes, it's fixed. thank you


Rename IDelgatable to IDelegable

The adjective form of delegate is delegable, not delegatable. IDelegatable should be renamed to reflect this.
This is a breaking change, and all dependent libraries will need to be updated to use the new interface name.

https://github.com/Arlodotexe/OwlCore.ComponentModel/commit/a4a018d933186c08eefeb73b6f824b2fbc0b8ba5


After upgrade to 5.0.3, throws error "No form with ID  is currently rendered..."

On 5.0.2 it was fine. After update to 5.0.3. throws error with message:
Uncaught Error: No form with ID <formId> is currently rendered. If this call originated from within a template event or helper, you should call without passing a formId to avoid seeing this error
How can I fix it?

Can you post the whole stack trace? Are you calling something and passing in formId as it says?

Sure here is it.
AutoForm.viewForForm                                        autoform-api.js:900
AutoForm.templateInstanceForForm                            autoform-api.js:883
(anonymous function)                                        afFieldInput.js:72

I am not calling something. I think it initiated from https://github.com/aldeed/meteor-autoform/blob/master/components/afFieldInput/afFieldInput.js#L72

OK, this will be fixed when I fix #789

Okay. Thanks


Update paths.md - baseUrl is no longer required

The comment stated baseUrl was required when setting paths option, TS 4.1 release notes say this is no longer required: https://www.typescriptlang.org/docs/handbook/release-notes/typescript-4-1.html#paths-without-baseurl

@andrewbranch apologies for the ping but it looks like orta has moved on from TS and you're a recent contributor.
It looks like the automated checks on this PR are stuck, is there something you can do to get 'tests' to rerun for this PR? Otherwise, do I need to do something to resolve it (e.g. close and re-raise the PR)?

Thank you!


Static status methods (except bluetooth & motion)

Added the ability to get permission statuses (except bluetooth & motion) without creating a PermissionScope instance.
This prevents crashes, when trying to get a status from a different thread than the main thread, as it doesn't try to do any view stuff.

I also added jetbrains product files to the .gitignore.
Sorry for not keeping this separate.

Hi @retendo, some questions about the motivation for this:
How were you accessing this on a background thread where it was crashing? Does PermissionScope().statusLocationAlways() (or equivalent) not work for you?
And please remove the jetbrains ignores. These should be in your global git ignore, not in the ignores for any project you use.

There are a few reasons for static status checking methods:

Creating an instance of PermissionScope does a lot of view stuff, which shouldn't be done on not-the-main-thread, otherwise you get undefined behavior which can result in crashes. (It did for me)
Most of the status checking doesn't need an instance, so why use one?
Status checking definitely doesn't need any view stuff to be performed.

Can you send over an example that crashes when off the main thread? I'm interested if this is our own issue or something particular to native permissions requests.
I totally get where you're coming from in terms of what should and should not be a static. I'm just not sure that shoehorning it in like this is the right solution when (if we can not crash) can do it just as well without.


Running pub get in Flutter's material gallery app fails due to intl:extract_to_arb

here's the output that I see:
~/Code/flutter/examples/material_gallery[master] $ pub get
Resolving dependencies... (2.4s)
> mojo 0.4.10 (was 0.4.8) (0.4.12 available)
> mojo_apptest 0.2.14 (was 0.2.12) (0.2.16 available)
> mojo_sdk 0.2.9 (was 0.2.7) (0.2.11 available)
> mojo_services 0.4.12 (was 0.4.10) (0.4.14 available)
> mojom 0.2.14 (was 0.2.12) (0.2.16 available)
> sky_engine 0.0.87 (was 0.0.75)
> sky_services 0.0.87 (was 0.0.75)
> vector_math 1.4.6 (was 1.4.4)
Changed 8 dependencies!
Precompiling executables...
Loading source assets...
Failed to precompile intl:extract_to_arb:
Unhandled exception:
Load Error for "http://localhost:65112/extract_to_arb.dart": SocketException: OS Error: Operation timed out, errno = 60, address = localhost, port = 65113
#0      _asyncLoadErrorCallback (dart:_builtin:155)
#1      _asyncLoadError (dart:_builtin:566)
#2      _handleLoaderReply (dart:_builtin:383)
#3      _RawReceivePortImpl._handleMessage (dart:isolate-patch/isolate_patch.dart:148)
Failed to precompile intl:generate_from_arb:
Unhandled exception:
Load Error for "http://localhost:65112/generate_from_arb.dart": SocketException: OS Error: Operation timed out, errno = 60, address = localhost, port = 65114
#0      _asyncLoadErrorCallback (dart:_builtin:155)
#1      _asyncLoadError (dart:_builtin:566)
#2      _handleLoaderReply (dart:_builtin:383)
#3      _RawReceivePortImpl._handleMessage (dart:isolate-patch/isolate_patch.dart:148)

This is the version of intl that is in the pubspec.lock:
  intl:
    description: intl
    source: hosted
    version: "0.12.5"

Here's how to repro:

clone the flutter project https://github.com/flutter/flutter
cd examples/material_gallery
pub get

here's what I'm running:
~/Code/flutter/examples/material_gallery[master] $ dart --version
Dart VM version: 1.14.0-dev.7.2 (Wed Jan 20 10:50:44 2016) on "macos_x64"

cc @alan-knight thanks for checking it out, let me know if I can provide any other info.

It works fine for me running with a bleeding-edge version of pub. Maybe try a pub cache repair? Can you reproduce this on another machine?

Trying pub cache repair, and it's also failing. I think this is a network issue with localhost because many packages are timing out when trying to connect to the pub server.
Loading source assets...
Failed to precompile dev_compiler:edit_files:
Unhandled exception:
Load Error for "http://localhost:50477/edit_files.dart": SocketException: OS Error: Operation timed out, errno = 60, address = localhost, port = 50478
#0      _asyncLoadErrorCallback (dart:_builtin:155)
#1      _asyncLoadError (dart:_builtin:566)
#2      _handleLoaderReply (dart:_builtin:383)
#3      _RawReceivePortImpl._handleMessage (dart:isolate-patch/isolate_patch.dart:148)
Failed to precompile dev_compiler:devc:
Unhandled exception:
Load Error for "http://localhost:50477/devc.dart": SocketException: OS Error: Operation timed out, errno = 60, address = localhost, port = 50479
#0      _asyncLoadErrorCallback (dart:_builtin:155)
#1      _asyncLoadError (dart:_builtin:566)
#2      _handleLoaderReply (dart:_builtin:383)
#3      _RawReceivePortImpl._handleMessage (dart:isolate-patch/isolate_patch.dart:148)
Failed to reactivate dev_compiler 0.1.0 from git: Failed to precompile dev_compiler:edit_files:
Unhandled exception:
Load Error for "http://localhost:50477/edit_files.dart": SocketException: OS Error: Operation timed out, errno = 60, address = localhost, port = 50478
#0      _asyncLoadErrorCallback (dart:_builtin:155)
#1      _asyncLoadError (dart:_builtin:566)
#2      _handleLoaderReply (dart:_builtin:383)
#3      _RawReceivePortImpl._handleMessage (dart:isolate-patch/isolate_patch.dart:148)
Reactivating grinder 0.7.2...
Precompiling executables...
Loading source assets...
Failed to precompile grinder:grinder:
Unhandled exception:
Load Error for "http://localhost:50528/grinder.dart": SocketException: OS Error: Operation timed out, errno = 60, address = localhost, port = 50529
#0      _asyncLoadErrorCallback (dart:_builtin:155)
#1      _asyncLoadError (dart:_builtin:566)
#2      _handleLoaderReply (dart:_builtin:383)
#3      _RawReceivePortImpl._handleMessage (dart:isolate-patch/isolate_patch.dart:148)

@munificent @nex3 have yall seen this before? Surprised that I'm timing out connecting to localhost

Computers are awesome! I unplugged my monitor and USB keyboard/mouse from my laptop, and now my connections to localhost are fast.
Sorry for the noise.


archiveOldFileOnStartup is not present in the wiki, had to find it through an SO issue

The configuration option exists, but the File target wiki page does not list it.
The wiki page should list the configuration option.

Thanks,
The docs has been added to the wiki https://github.com/NLog/NLog/wiki/File-target
PS: You can also edit the wiki.


Fixes a clang static analyzer issue

EncodeTime preserves the present bit-pattern of the ULID being passed (as it should).
Because __uint128_t does not have a constructor, Create and CreateNowRandom were passing the reference to an un-initialised value — which the clang static analyzer complains about:
ulid_uint128.hh:45:19: The left operand of '&' is a garbage value

        ulid = t | (ulid & mask);
                    ~~~~ ^

The commit in this PR fixes the issue by initialising the values being passed by reference.

Thanks!


New User Registration Issue

Hello, thank you for your plugin :)
I am experiencing an issue with this option in the settings:

I am using the standard user registration form like this: https://craftcms.com/knowledge-base/front-end-user-accounts#registration-form
When I try to verify I can successfully complete the captcha, but the user object comes back with the following error:
Please verify you are human.
When I unchecked the box, I can register fine. I wasn't able to find too much relevant information in the logs, but here is the session variable:
$_SESSION = [
    '240364006149420517839f0929062b0b__flash' => [
        'notice' => -1
        'error' => -1
    ]
    'notice' => 'User registered.'
    'error' => 'Couldn’t save user.'
]

All right!
Which version of Craft CMS are you using?
Could you also list all the plugins enabled?
Thanks

Closing this issue due to the lack of informations.
Feel free to reopen it if you want to provide more context!


Created apolloClient utility to retrieve the apollo state in redux.

This PR resolves https://github.com/apollostack/react-apollo/issues/221.
It checks if the deprecated reduxRootKey property is set in the client and uses it. Otherwise it uses the new reduxRootSelector property of the client.
Also it adds the deprecation warning when reduxRootKey is used in the client.

@rricard this is the first attempt :)
I had to run typings command to make the types be recognised, but I also see it added a lot of files. Let me know if I have to revert for those files.

Another note, I had to fix apollo-client to 0.14.6 to get the version with the problem.

Thanks for the review.
About the tests, I am considering the testing the new function should be enough.
Suggestions where I can implement the test for the function?
About the CI, I will look into it, but think I may need help to understand what is wrong.

First for the typings, let's try to see if you revert your changes in typings/ what it does. The, re-npm install. It my still fail for you but may pass in the CI, in this case we should investigate your env!
Second, for the tests, yes just test the new function but try to cover the edge cases as much as possible. Since you created a new file for the function, try creating a new file, we'll move it around if that makes more sense!
Good luck!

@rricard Tested and fixed the CI. However I see #226 could be a cleaner alternative than this one.

However, what I like here is we add some tests. If you can get rid of the typings/ files and rebase it, I think we'll have something good.
@jbaxleyiii or @stubailo do you have a preference on this ?

@rricard done what you asked. I hope this is helpful.

I am not familiar with typescript either. The problem is that I could not find steps to set up the module for development. So I just run npm install ./node_modules/.bin/typing install (that is why the typings files added) to get started with the project.
About the CI I have the same error on my local machine when running npm run compile.
I tried also to run ./node_modules/.bin/typing install --production to update the definitions only for production modules, but the compilation still fails.
Here I am stuck. I have been trying to look for info to contribute with typescript, but nothing that helped to fix the CI problem.
Help wanted! :)

@rewop don't worry, they plan to migrate from typings to npm-based typing soon. I think we should wait for the opinion of someone else here!

closed for #226 but thank you for this PR!


New command: teams message restore

Usage
m365 teams message restore [options]
Description
Restores a deleted message from a channel in a Microsoft Teams team
Options

Option
Description

--teamId [teamId]
ID of the Microsoft Teams team. Specify either teamId or teamName but not both.

--teamName [teamName]
Name of the Microsoft Teams team. Specify either teamId or teamName but not both.

--channelId [channelId]
Channel ID of the Microsoft Teams team. Specify either channelId or channelName but not both.

--channelName [channelName]
Channel name of the Microsoft Teams team. Specify either channelId or channelName but not both.

-i, --id <id>
The ID of the Teams message.

Examples
Restores a deleted message by using IDs
m365 teams message restore --teamId 5f5d7b71-1161-44d8-bcc1-3da710eb4171 --channelId<EMAIL_ADDRESS>--id<PHONE_NUMBER>203

Restores a deleted message by using display names
m365 teams message restore --teamName Marketing --channelName Branding --id<PHONE_NUMBER>203

Default properties
No response
Additional Info
Remarks:

This command doesn't support application permissions, let's check for this

API: https://learn.microsoft.com/en-us/graph/api/chatmessage-undosoftdelete?view=graph-rest-1.0&tabs=http

LGTM 👍 Let's ship it 🚢

Hi There, can I give this a try? 😄


Unable to install v0.36.0 using install.sh

What happened:
install.sh script is not installing version 0.36.0 successfully. Debug shows that the file is not present?
 curl -sSfL https://raw.githubusercontent.com/anchore/syft/main/install.sh | sudo sh -s -- -d -b /usr/local/bin
anchore/syft info checking GitHub for latest tag
anchore/syft debug http_download https://github.com/anchore/syft/releases/latest
anchore/syft info found version: 0.36.0 for v0.36.0/linux/amd64
anchore/syft debug downloading files into /tmp/tmp.eN2cX5knQ2
anchore/syft debug http_download https://github.com/anchore/syft/releases/download/v0.36.0/syft_0.36.0_linux_amd64.tar.gz
anchore/syft debug http_download_curl received HTTP status 404

What you expected to happen:
install.sh script should install the version, as it did with 0.35.1:
curl -sSfL https://raw.githubusercontent.com/anchore/syft/main/install.sh | sudo sh -s -- -d v0.35.1 -b /usr/local/bin
anchore/syft info checking GitHub for tag 'v0.35.1'
anchore/syft debug http_download https://github.com/anchore/syft/releases/v0.35.1
anchore/syft info found version: 0.35.1 for v0.35.1/linux/amd64
anchore/syft debug downloading files into /tmp/tmp.RTyutIJ2Lb
anchore/syft debug http_download https://github.com/anchore/syft/releases/download/v0.35.1/syft_0.35.1_linux_amd64.tar.gz
anchore/syft debug http_download https://github.com/anchore/syft/releases/download/v0.35.1/syft_0.35.1_checksums.txt
anchore/syft info installed ./bin/syft

How to reproduce it (as minimally and precisely as possible):
curl -sSfL https://raw.githubusercontent.com/anchore/syft/main/install.sh | sudo sh -s -- -b /usr/local/bin
Anything else we need to know?:
Environment:

Output of syft version:
OS (e.g: cat /etc/os-release or similar):

Similar issue to #757. We'll release a patch in the morning with the replacement removed.


please take a look at changelog, and pick the version match your flutter sdk version

          > please take a look at changelog, and pick the version match your flutter sdk version

Version 8.0.2 is not flutter & dart version it's extended_image package version
Originally posted by @thirstyde in https://github.com/fluttercandies/extended_image/issues/644#issuecomment-1874831582

your :  extended_image: ^8.0.2
your flutter : flutter sdk: Flutter (Channel stable, 3.16.5, on Microsoft Windows [Version 10.0.19045.3803], locale en-IN)
changelog:


Server error when Azure Dev Deploy finished

Describe the issue:
Server error when Azure Dev Deploy finished.
Repro Steps:
Run command: bash ./test-templates.sh -c false -t <template_name> -b pr/551.
Error Message:

Through investigation, we found that it was caused by API service exception

Environment:
OS: Windows desktop, Linux Desktop, WSL ,Mac ,Codesapce and DevContainer.
Templates:
https://github.com/Azure-Samples/todo-nodejs-mongo-swa-func
https://github.com/Azure-Samples/todo-python-mongo-swa-func
Branch: pr/551
Expected behavior:
The api server is normal, and e2e test is pass.
@jongio for notification.

@jongio @madebygps did we make any changes to other templates as part of #551? any changes in your PR could cause this?

Yes, I will investigate.

@jongio We do the manual test about template (todo-python-mongo-swa-func and todo-python-mongo), also encountered the same error when Azure Dev Deploy finished.
Error:

Environment:
OS: Windows desktop
Templates:
https://github.com/Azure-Samples/todo-python-mongo-swa-func
https://github.com/Azure-Samples/todo-python-mongo
Branch: pr/892
Azd version: azd version 0.3.0-beta.3-daily.1921004 (commit e52ea013fede3560b90f4cf9d0a8e6d6ceac376a)

@jongio We do the manual test about template (todo-python-mongo), also encountered the same error when Azure Dev Deploy finished.
Error:

Environment:
OS: Windows desktop
Templates:
https://github.com/Azure-Samples/todo-python-mongo
Branch: pr/892
Azd version: azd version 0.3.0-beta.3-daily.1921004 (commit e52ea013fede3560b90f4cf9d0a8e6d6ceac376a)

Please try again with main.  If it fails, please leave it in failed state and provide me and @weikanglim with a link to the env.

@jongio - We have tried again with main, it is still unstable. When we execute the command bash ./test-templates.sh -c false -t todo-python-mongo, the playwright test failed. At this point, when we click the api site, it reported Application Error. After a period of time, the api service can be deployed successfully, and the error will not occur again when playwright test is executed again.
In summary, the error was caused by the api service is not deployed successfully yet, the playwright test is run first.

Can you try with a different region and see if you get the same error?

@jongio - We have tried with region East US, and get the same error. This time it was due to a failed deployment, you can reach from this link.
Template: https://github.com/Azure-Samples/todo-python-mongo
Branch: main
azd version: 0.3.0-beta.3-daily.1937328 (commit d18003a6799b545e4050544f9fa05f1eaedb0948)

The detector was extremely helpful. I found the following errors related to the docker container crashing:
File "<frozen importlib._bootstrap>", line 973, in _find_and_load_unlocked
2022-10-24T03:24:54.032196245Z ModuleNotFoundError:
No module named 'uvicorn'2022-10-24T03:24:54.032199945Z ]

What do you mean by the detector?

Could be related: https://github.com/Azure/azure-dev/issues/932

Not seeing these template failures in the pipelines. Might be a temporary region issue. Reopen if you see again.

@rajeshkamal5050, @jongio  - In today's test, the issue persists and occurs at a high rate.
OS: Windows desktop.
azd version: azd version 0.3.0-beta.6-pr.1947898 (commit a7b9ee6038c4ecbe8ddda4c0ba1acbd2ec208fc8)
branch: pr/996
templates:
https://github.com/azure-samples/todo-python-mongo
https://github.com/azure-samples/todo-csharp-cosmos-sql
https://github.com/Azure-Samples/todo-csharp-sql
https://github.com/Azure-Samples/todo-java-mongo
https://github.com/azure-samples/todo-nodejs-mongo

Fixed with #996


[REQUEST] - Passkeys input autofill (Conditional UI)

Is your feature request related to a problem? Please describe.
I'm always frustrated when I need to input again and again my email when I need sign-in. Enabling Passkey Autofill with mediation: "conditional" and autocomplete="username webauthn" on email input, helps that.
Describe the solution you'd like
Implements Conditional UI to enable Passkey autofill
Additional context
Sign in with a passkey through form autofill
Add passkeys to the browser autofill
Explainer: WebAuthn Conditional UI
Notify

@type1fool

@danielgpinheiro Thank you for opening this issue. I will review the links you provided and follow up.
One thing to consider is that the email is only required by the RegistrationComponent, and the AuthenticationComponent will allow the user to select any passkey registered to the domain. Is this mediation/autofill enhancement related to registering a new account or authenticating an existing one?

It looks like the conditional UI will be helpful for applications migrating from basic auth to Passkeys. I see the value in supporting this user experience, and I do agree that this feature should be on the roadmap.
WebauthnComponents is currently focussed on supporting Passkeys in applications with no prior authentication mechanism. The generators in particular assume no prior auth code is in the Phoenix app where they're being run. Integrating WebauthnComponents into apps with basic authentication is a goal of mine, though I expect it to be quite complex.
This issue has been added to the WebauthnComponents v1 project, and I will revisit conditional UI once I'm making progress with the basic auth integration.
Thank you. 💟

Hi, I created a PR to this feature: https://github.com/liveshowy/webauthn_components/pull/59


Upgrade to tokio_tungstenite 0.14.0 and adjust errors accordingly

Fixes #1
I also added another commit since I just noticed that. I hope you agree with that. If not, I can just remove it from this PR again.

I agree with publicly re-exporting hyper too :)

Released as 0.3.0. Thanks again!

Sweet, thank you!


Add /health endpoint

Return HTTP 200 when (whatever conditions) are met

Added https://github.com/conix-center/arena-account/commit/92e2002a7ec752ecd0f3f56ef3f4b8c53a4868b9


[WIP] Use the human-readable part for the prefix of addresses

Before applying Bech32 encoding, all the well-known addresses contain special prefixes used to identify them easily. But after applying that, we lost the prefixes because the Bech32 makes different names with the same Point value. So we are using the human-readable part for the prefix of addresses.
Part of #1878
Part of #1354
If there are any suggestions about modifying the prefixes of well-known addresses, like removing the gd part of each prefix, please let me know.

Need to check errors of CI builds.

#11 169.5 ldc2 failed with exit code -9. This may indicate that the process has run out of memory.

Yep, I think it doesn't like the new WKKeyData.

Hmm is it affecting faucet too?

#11 169.5 ldc2 failed with exit code -9. This may indicate that the process has run out of memory.

Yep, I think it doesn't like the new WKKeyData.

Hmm, I think so. Need to find another way or workaround.

I'm retrying other ways to solve the issues reviewers raised on this PR. I will request a whiteboard after retrying other ways and reorganizing my thoughts.

Ready for review.
I think Integration will fail because the newly added file 'WellKnownHRPs.din Agora is not added tofaucet` automatically.

Ping.

Ready for review.
I have managed for the Key module to refer WellKnownHRPs only in the unit tests.

As discussed with @linked0 , using HRP proved not to be a good idea, so this is superseded by #2008


Update style.css

Pull Request Checklist

[ ] I have added screenshots and videos to show the working of my code.
[ ] I have ensured that the screen size is set to 100% while making the video.
[ ] I have synced the latest fork with my local repository and resolved any conflicts.

Share the relevant screenshots what you have done

Resolve conflicts

Share screenshot before and after what you have done

Kindly refork and resync


Fix syn.js v0.15.0 input event must be fired synchronously

based on https://github.com/bitovi/syn/pull/196, fixes https://github.com/bitovi/syn/issues/120
input event must be synchronous per spec - https://w3c.github.io/uievents/#event-type-input
repro case: https://github.com/bitovi/syn/issues/120#issuecomment-1529794347

@mvorisek , do I understand correctly, that you're proposing the Syn library change to Mink, which isn't yet merged into the Syn library itself?


Add Cache Layer .. where?

Hi, the root docs say "Add a Cache layer" but none of the code and examples I could access have any implementation of the mentioned concept.
Sorry this isnt an issue and more a question, but I could not find any other Fourm to ask this either.
thanks

The cache is just part of the Diskv structure. You can control how big it is with CacheSizeMax.


fix: api_url concat

close #26

Thanks for the quick fix! I kinda hate raw string concat for this kind of thing, what do you think of a different solution:
You pass up "http://localhost/anthropic/" instead of "http://localhost/anthropic".
And then change this PR from "/v1/complete" to be "v1/complete"
I believe this should work?
>>> from urllib.parse import urljoin
>>> urljoin("http://localhost/anthropic/", "/v1/complete")
'http://localhost/v1/complete'
>>> urljoin("http://localhost/anthropic/", "v1/complete")
'http://localhost/anthropic/v1/complete'
>>> urljoin("http://localhost/anthropic", "v1/complete")
'http://localhost/v1/complete'

Thanks for the quick fix! I kinda hate raw string concat for this kind of thing, what do you think of a different solution: You pass up "http://localhost/anthropic/" instead of "http://localhost/anthropic". And then change this PR from "/v1/complete" to be "v1/complete"
I believe this should work?
>>> from urllib.parse import urljoin
>>> urljoin("http://localhost/anthropic/", "/v1/complete")
'http://localhost/v1/complete'
>>> urljoin("http://localhost/anthropic/", "v1/complete")
'http://localhost/anthropic/v1/complete'
>>> urljoin("http://localhost/anthropic", "v1/complete")
'http://localhost/v1/complete'

It works! Now I've changed my fixing plan.

any idea when this will get merged?


Token refresh with federation

When I use the SAS with authorization using an external identity provider (similar to the provided example), the SAS does not check, if the upstream access token is expired and does not perform a token refresh with the upstream provider.
This refresh would be necessary, when a SAS client uses the refresh_token flow. Currently, the SAS just does a token refresh for its client, but does not check, if the IDP authentication is still valid.
Of course, this might not be the responsibility of SAS. But how would I implement the token refresh? Should I do it with the OAuth2TokenCustomizer? Or is there a hook that I can use?

@michael-ylb

Of course, this might not be the responsibility of SAS

That's correct. This is not the responsibility of Spring Authorization Server but instead the responsibility of the consuming application and the way it configures the client to perform the federated login flow. The Federated Identity Sample is a minimal sample demonstrating how to configure federated identity. If you require refresh_token capability then you would need to configure the client in the sample.
Please see the Spring Security reference on Refresh Token as it demonstrates how to configure the client for refresh token.
As an FYI, questions are better suited to Stack Overflow. We prefer to use GitHub issues only for bugs and enhancements.


ERROR Error: Uncaught (in promise): ReferenceError: global is not defined

https://github.com/photonstorm/phaser/blob/000beb2bd0401494e2dc958916f42731e5663f7a/src/phaser.js#L88
I need to comment this line in order to make Phaser work in Chrome, I'm using Phaser 3.23.0

Why are you loading Phaser via a promise?

Why are you loading Phaser via a promise?

Hello, thanks for such a quick answer. I'm not loading Phaser via Promise, I'm loading it by using ES6 syntax with "import". To be more specific I'm using it from an Angular 10 project with Typescript. This error can be easily reproduced creating an Angular project from the scratch and then installing and importing Phaser.
This is how I import it:
import Phaser from 'phaser';
and then I instantiate it like this:
this.game = new Phaser.Game(config);
As I told before If I comment the line 88 it perfectly works. I'd like to know what is exactly that line doing to understand what's my issue. Thanks a lot in advance.

I suppose that line is redundant now.

Thank you for submitting this issue. We have fixed this and the fix has been pushed to the master branch. It will be part of the next release. If you get time to build and test it for yourself we would appreciate that.

Having now tested this, it breaks all imports of Phaser by removing this line. So I'm going to revert this change to make it work again.


[docs][Concurrency] Include required parameter in group docs

Description: A few snippets wrongly spelled snippets as try await withThrowingTaskGroup { group in, but we require being explicit about the group type like this: try await withThrowingTaskGroup(of: Void.self) { group in
Risk: Low, change is docs only
Review by: @DougGregor
Testing: CI testing, change is docs only
Original PR: https://github.com/apple/swift/pull/64933
Radar: rdar://111547369

@swift-ci please test


Connection aborted.', RemoteDisconnected('Remote end closed connection without response)

There is a probability of occasional errors when making consecutive requests. Increasing the delay after each request can reduce the likelihood of errors, but the connection still drops intermittently.
for example, use
for i in range(30):
driver.client.healthcheck()
Traceback (most recent call last):
File "/usr/local/lib/python3.12/site-packages/urllib3/connectionpool.py", line 715, in urlopen
httplib_response = self._make_request(
^^^^^^^^^^^^^^^^^^^
File "/usr/local/lib/python3.12/site-packages/urllib3/connectionpool.py", line 467, in _make_request
six.raise_from(e, None)
File "", line 3, in raise_from
File "/usr/local/lib/python3.12/site-packages/urllib3/connectionpool.py", line 462, in _make_request
httplib_response = conn.getresponse()
^^^^^^^^^^^^^^^^^^
File<EMAIL_ADDRESS>line 1428, in getresponse
response.begin()
File<EMAIL_ADDRESS>line 331, in begin
version, status, reason = self._read_status()
^^^^^^^^^^^^^^^^^^^
File<EMAIL_ADDRESS>line 300, in _read_status
raise RemoteDisconnected("Remote end closed connection without"
http.client.RemoteDisconnected: Remote end closed connection without response
During handling of the above exception, another exception occurred:

requests          2.29.0

may be requests version cause the problem?
requests          2.29.0
urllib3           1.26.19


youcompleteme: fix compilation

Replace --system-libclang with an explicit setting for the path to
nix libclang 3.9. Otherwise it will find system's libclang on darwin.

Remove clang/llvm from build inputs. This prevents ycm itself from
being compiled by clang 3.9. stdenv's standard compiler (gcc or
clang 3.7) will suffice.

Enable C++11 again as #16212 is caused by incopatibility between
clang 3.9 and libc++ 3.7, but we don't compile YCM with clang 3.9, so
this is not needed anymore.

Motivation for this change
Things done

[ ] Tested using sandboxing
(nix.useSandbox on NixOS,
or option build-use-sandbox in nix.conf
on non-NixOS)
Built on platform(s)

[ ] NixOS
[x] macOS
[ ] Linux

[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

Thanks!

Thanks!

Fixed by https://github.com/NixOS/nixpkgs/pull/21574


How do we get access token when authenticating using Auth0 or Okta (Help needed)

I tried setting up Auth0 and Okta for auth. I am unable to figure out how to fetch tokens post authentication. Could you please help me out.
Actually we wanted to show backstage components based on the user scope and roles. I have set my scopes in auth0 and okta. Facing issue on how to fetch scopes post authentication
Expected Behavior
Get access token and scopes post authentication

Simply call getAccessToken on the appropriate auth API! For example like this: https://github.com/backstage/backstage/blob/61fdfd70a3d29d4588144159e43f64572bcc743b/plugins/github-deployments/src/api/index.ts#L92

Closing as probably solved - please reopen and clarify if this is a mistake on my part.


Permission For /Class Reset

On my server, professions are locked in for that character; they will only reset upon death. I think a separate permission to enable or disable the /class reset command would be useful.

skillapi.class.reset: Allows the ability to give another user permission to use the /class reset command.

Coming soon in new dev builds.


Mac setup to connect to a MS SQL Server

Your wiki page - Mac setup to connect to a MS SQL Server works perfectly fine for IPV4 connections which is based on tsql -S myserver(IPV4 address - XXX.XXX.XXX.XXX) -U myuser -P mypassword.
But it doesnt work on connecting with specific IPV6 address where I used tsql -S myserver(IPV6 address - XXXX:XXXX:X:X::X:XXXX or http://[XXXX:XXXX:X:X::X]:XXXX) -U myuser -P mypassword.
Is there something which I need to do or am I missing something?

Hi Suresh,
If you have a tsql question, you're going to want to post that question elsewhere.  Perhaps a tsql forum.


Mixin of watch function into feathers service not working

Steps to reproduce
 app = feathers();
app.configure(feathersRx({               idField: '_id'     }));
 console.log(app.service('messages')) // No property watch() here!
System configuration
Browser Version:
Firefox Version 55 (Working on Chromium for me)
I've down some research and the problem seems to be related to the way Uberprotos implements mixin()  and the fact that FF defines Object.prototype.watch().

Awesome, thanks for the research!
This issue doesn't seem fixable upstream, so I've created a workaround for FF in #68. Confirmed working on FF 55 / Ubuntu.

Thanks for the quick fix.


React app just shows white screen

I have a react app built with CRA which works fine in the browser but only displays a white screen here. I added some static HTML to the index file and that works without an issue so it appears its just having issues running the react app.
The react app works fine in Chrome/FF/WebkitGtk (using https://github.com/zserge/webview) so my feeling is that it's something that isn't implemented in Ultralight but without seeing the console output its hard to say.
Is there any way we can get the console output from Ultralight? Like a debug flag or something?

What I did was manually edit muon.go to add
	return func(user_data unsafe.Pointer, caller ULView, source ULMessageSource, level ULMessageLevel, message ULString, line_number uint32, column_number uint32, source_id ULString) {
		s := unsafe.Pointer(UlStringGetData(message))
		sz := UlStringGetLength(message)
		wstr := (*[256]uint16)(s)[:sz:sz]

		out := utf16.Decode(wstr)
		fmt.Println(string(out))
	}
}```

and then in (window*) Start() on line 96 I added ```UlViewSetAddConsoleMessageCallback(w.view, loggingCallback(), nil)```


feat(servervalidationerror): adds a ServerValidationError

I've encountered in almost every project that interacts with an external API a need to return a validation error from the server action. Common example could be when creating a new record that has a unique key (for example email). The server action calls the API and get an error that the email already exists. I usually hacked this and returned a response from server action in similar format to:
{
  "success": false,
  "errors": {
    "email": "Email already exists"
  }
}

Then on client side, there's a need for an additional check on the returned data.
This PR aims to add a way for the user to trigger validationErrors output from the server action, instead of the described approach above, there's new function passed to the server action, that lets you trigger the valdiationErrors.
const input = z.object({
	email: z.string(),
});

export const registerUser = action(input, async ({ email }, _ctx, serverValidationError) => {
        const emailExists = await db.query.users.findFirst({ where: eq(users.email, email) });
	if (emailExists) {
		serverValidationError({
			email: ['Email already exists'],
		});
	}
});

On the client side, this will return:
{
  "validationErrors": {
    "email": ["Email already exists"]
  }
}

Which removes the need to do an additional check on the data, but you can rely on that if validationErrors and serverErrors are null, your server action succeeded.
Side note: I initially exported the ServerValidationError and wanted the user to throw it manually, but that would require passing typeof schema or schema to the error, to be able to hint possible validation error keys. The current approach with helper method doesn't require that, but I'm not 100% sold on it....

Hi @theboxer, thanks for your contribution. I think this is very useful and the optimal way to deal with custom validation errors set in server code execution. Though, I already implemented this pattern in all of my projects via the "native" way, which is using the validation library to do the job.
I closed an issue yesterday about the same problem, check out the comment I left there. I think this approach is pretty good already, but please let me know what you think about it. Thanks!

@TheEdoRan thanks for that example, I actually think that it make perfect sense to deal with the validation errors as natively as possible. I actually didn't think about the option to add new set of validation to the same schema server side and perform the db validation on this level. I will update my code to use this approach :)
However, not every project I run uses local data access and will be able to leverage the native schema. When I interact with the data through a remote crud API, it's impossible to do the check beforehand in the schema. I think this instance would be ideal for the proposed solution in this PR.
What do you think?

When I interact with the data through a remote crud API, it's impossible to do the check beforehand in the schema.

You can interact with external APIs in .superRefine() at the schema level, but the problem is that then there's no way to pass data to the action's server code function, so yeah, it's pretty limited in functionality.
I think your solution is great if the native way cannot be used. However, I also think that:

We need to merge schema validation errors from the validation library and custom ones set with serverValidationError;
We have to decide if it's better to put the serverValidationError function, along with other potential future util functions, in an object as the second or third argument of the action's server code function. Let me explain better:

if we decide that it's better to keep these util functions as the third argument of the action's server code function, the API would look like this one below. The only difference from your implementation is that these functions are in an object (see the curly braces):

export const registerUser = action(schema, async (input, ctx, { serverValidationError }) => {
  ...
});

if we instead decide that it's better to put these util functions in an object as the second argument of the action's server code function, the current API would break, because the second argument is currently reserved for the optional context data returned by the middleware() function, passed to createSafeActionClient() (if provided). The server code function would only have two arguments in this case, and the context would be placed in the same object as the util functions, in a property called ctx:

export const registerUser = action(schema, async (input, { serverValidationError, ctx }) => {
  ...
});

I still have to decide what the best approach is. First one could be included in version 6, since it only adds a feature and breaks nothing, second one with the breaking change would be included in version 7. Also, I think it's probably better to be a little more explicit and name this function something like setServerValidationErrors.
Please let me know what you think about this, and thank you for the patience.

You can interact with external APIs in .superRefine() at the schema level, but the problem is that then there's no way to pass data to the action's server code function

Even if this would be possible, I don't think it would be a good approach to do so, schema should be purely responsible for data validation and not calling API (by this I mean regular CUD endpoints, not specific endpoints for validation) and returning API's data as a side effect

We need to merge schema validation errors from the validation library and custom ones set with serverValidationError

I don't think this is a good idea. It would force you to send unvalidated data to the server action and then to the API endpoint.  I see the ServerValidationError as an extra validation step, that can't be performed with the schema itself and should only happen after the input passes the initial schema validation to ensure some level of integrity.

We have to decide if it's better to put the serverValidationError function, along with other potential future util functions, in an object as the second or third argument of the action's server code function.

I completely agree with this one, I added it as an extra argument, because I didn't want to break the BC. I do agree that it should be an object, as there may be another utils functions later on, like you mentioned. I'd also vote for v7 to merge it with context and have it as a second argument.
For the name, maybe it could be even more explicit as throwServerValidationErrors as it actually throws an error and exists the code (to avoid a mistakes with calling that function several times and expecting it'll execute them all).

Even if this would be possible, I don't think it would be a good approach to do so, schema should be purely responsible for data validation and not calling API (by this I mean regular CUD endpoints, not specific endpoints for validation) and returning API's data as a side effect

I mean, I don't see a huge problem with this approach, because it's just all server code in the end, but I understand your point of view, it could create some confusion. And as I said, data cannot be passed to the action's server code function, so it's pretty useless in most cases anyway.

I don't think this is a good idea. It would force you to send unvalidated data to the server action and then to the API endpoint.

Don't know why I didn't think about this. Yes, this is pretty terrible. If the server receives invalid data and we don't stop execution before reaching action's server code function, we would get invalid parsed input as the first argument of the action's server code function, so I absolutely agree with you.

I'd also vote for v7 to merge it with context and have it as a second argument.

Yes, I also think this is better.

For the name, maybe it could be even more explicit as throwServerValidationErrors as it actually throws an error and exists the code (to avoid a mistakes with calling that function several times and expecting it'll execute them all).

Hmm, yes, internally we throw a ServerValidationError, but externally we just return the validationErrors object to the user. So, the execution is stopped when the util function is called, but it's like Next.js redirect() or notFound() functions. The average user doesn't really know that an internal error is thrown to make them work. Maybe we could call it returnServerValidationErrors or just returnValidationErrors (since we already know that we're in the server scope and the errors we set with this function will populate the same validationErrors object that the schema parsing would set). Furthermore, the user shouldn't really be able to call this function several times in action's server code function, because if a function returns never (throws), the code below the function invocation is "grayed out", indicating that it can't run.
Lastly, I'm currently actively working on and thinking about the optimal way to solve #51. Once I find the right solution, I'll push the changes to the next branch, which is a pre-release channel, for the upcoming v7. I'll then update this PR base branch to next, since it introduces the breaking change we've already discussed about in the previous comments.
Please let me know what you think about all of this, and thank you again for you contribution!

I'd also vote for v7 to merge it with context and have it as a second argument.

I think I expressed this one in a wrong way. I wanted to say I'd love to see it in v6 as a third argument as it's fully BC and then for v7 I'd love to see it merged with the context. But if you want to go with just v7 I'm fine with that and can prepare the changes. Let me know.
I agree with the rest and went ahead and renamed the function to returnValidationErrors.
Let me know if there's something else I should update or add (like different example vs adjusting the login one)

But if you want to go with just v7 I'm fine with that and can prepare the changes. Let me know.

Yeah, I think this is the better solution, to hopefully avoid additional user confusion.

I agree with the rest and went ahead and renamed the function to returnValidationErrors.

Great!

Let me know if there's something else I should update or add (like different example vs adjusting the login one)

I'd say keep them as they are right now, since the new validationErrors object structure is implemented in next branch, and the main focus is to adapt the implementation for the new code. I'll now update the base branch of this PR from main to next, as these changes will land in v7. We'll also need to update the documentation once this feature is implemented. Thank you!

Rebased the PR with next branch and merged the utils & ctx

I'm working on your code and really want to implement this feature ASAP. Problem is, I don't know why but my editor (VS Code) doesn't gray out the code below returnValidationErrors. If instead I define a function that returns never in the same file and call it inside the action's server code function, it works as expected.
I even tried to define the type of returnValidationErrors inline, inside the Utils type:
type Utils<S extends Schema, Context> = {
  ctx: Context;
  returnValidationErrors: (validationErrors: ValidationErrors<S>) => never;
};

It still doesn't work, same behavior as your implementation that uses typeof. I guess this is a TypeScript problem, any ideas?

UPDATE: yes, this is a TypeScript bug (?).
I set up a new project with just a .ts file and without using next-safe-action, same behavior.

I also found out that if you don't destructure the object, it works as expected:

This isn't good. Maybe we should keep the util functions as the third argument of the action's server code function and tell users to avoid destructuring the object. I really don't like this, but I guess this is the only way we can implement this in a "good enough" way.

Ugh, I found few TS issues on GH that this is kind of expected behaviour - nothing for the destructing not working.....
We can also ditch this completely and go back to exposing the actual error class, so instead of calling utils function, you'd do:
throw new ServerValidationError<typeof schema>({
  username: {
    _errors: ['invalid']
  }
});

I exported a standalone function named returnValidationErrors. It requires passing a schema (even if it's not actually used in the function) to get inferred type safety. Action's server code function is back to just two arguments, parsedInput and optional ctx. I think this implementation is actually pretty good, since it doesn't introduce breaking changes and still preserves type safety. The only drawback is that you have to import the function every time you want to set custom validation errors, but it's not that big of a deal, at least in my opinion. Please let me know what you think about it.

I'm not sure if passing an unused var is better than passing the schema type, but not a huge deal. I like it and thank you!

I'm not sure if passing an unused var is better than passing the schema type

I agree that it's not a wonderful solution, but I think it's the least painful way to implement it, because you get:

Less noise than <typeof schema> every time you want to use it;
Enforced type safety. You could omit the generic type, but you can't omit the first argument of a function.

So while I understand that passing an argument that isn't actually used is not that great, I also think that in the end it provides the best DX for this use case.

Also, can this go to v6 as it doesn't break BC?

It could go in v6, but I prefer to keep this in the next release channel, since the returnValidationErrors() function uses ValidationErrors type to set errors with the new format (the one that emulates Zod's format() function). If we land this feature in v6, then users would also need to update all the returnValidationErrors() calls inside actions when version 7 will be released.
Once this PR is merged, though, you can install the lib with npm i next-safe-action@next to get this new feature, and future migration to stable version 7 will be as simple as reinstalling it using the main release channel.

I agree that it's not a wonderful solution, but I think it's the least painful way to implement it, because you get:

Less noise than  every time you want to use it;
Enforced type safety. You could omit the generic type, but you can't omit the first argument of a function.

So while I understand that passing an argument that isn't actually used is not that great, I also think that in the end it provides the best DX for this use case.

Fair point, I agree with that.

It could go in v6, but ...

Make sense, thanks :)

🎉


Introduce a flag to view cellery system logs

Purpose

By default, only show user component logs for the command cellery logs <insance-name> and introduce -s flag to view logs including cellery system logs

Goals

Fix sdk/issues/853

Codecov Report

Merging #859 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #859   +/-   ##
=======================================
  Coverage   53.45%   53.45%
=======================================
  Files          56       56
  Lines        2215     2215
  Branches      218      218
=======================================
  Hits         1184     1184
  Misses        980      980
  Partials       51       51

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 11545e9...3210837. Read the comment docs.

Completing the task 'Update logs command to support only showing component logs' in
wso2-cellery/cellery-tooling/issues/6


[FEATURE] [RFC] Create a new "Permissions Evaluator" UI when setting up a Role

Is your feature request related to a problem?
Connected to https://github.com/opensearch-project/security/issues/3381, when setting up a role, I would like to see what permissions this role needs to perform a certain set of actions.
What solution would you like?
A clear and concise description of what you want to happen.
What alternatives have you considered?
A clear and concise description of any alternative solutions or features you've considered.
Do you have any additional context?
Add any other context or screenshots about the feature request here.

[Triaging] Thanks for filing, @derek-ho! This one requires a bit more detailed UX before we can call it triaged.

This issue is not feasible for the time being so going to close. Please open a new issue if additional information can be added.


docs(api.md): fix docs/api.md

v1.3.0 is released.

Once this is in, I'll move the tag v1.3.0 onto this commit.
I'll automate this doc thing in a follow-up so that we don't have this issue in future.


DOCS: Improve Veraison Documentation

Please describe the problem
Need to have a clear and crisp documentation on Veraison Repository.
For this need to
(a) Agree on a format/template for organizing documentation
(b) Evaluate tools that can support the requirement!
(c) Generate suitable README.md and a Veraison Book which has document internals!
We have a rough agreement on (a) above.
For (b) and (c) Work will start in August post IETF Hackathon ( which is towards the end of July).

Closing as new issue tracked on docs repo, below:
https://github.com/veraison/docs/issues/23


implements AccessRule::module and fixes #4999

This should be implemented as partial matching on the controllerId instead.


Remove notebook deps from the core package

Pull Request Checklist:

[ ] This PR addresses an already opened issue (for bug fixes / features)

This PR fixes #xyz

[ ] (If applicable) Documentation has been added / updated (for bug fixes / features).
[ ] (If applicable) Tests have been added.
[x] HISTORY.rst has been updated (with summary of main changes).

[ ] Link to issue (:issue:number) and pull request (:pull:number) has been added.

What kind of change does this PR introduce?
This is something I noticed when implementing the translation. The package's setup.py asks for many dependencies it doesn't actually need. I feel all those I removed are indeed useful or even necessary for using figanos, but they are not dependencies per se as no code in the package itself makes use of them.
Most are actually needed when running the notebook though, so I added them to the requirements-doc.txt instead. I also re-ordered the environment.yml to reflect that.
Does this PR introduce a breaking change?
I hope not, we'll see in the build.
Other information:
My other PR makes use of xclim to get the "activated" locale, but I pushed a commit there to make this an optional import, so the two PRs should work together.

Hum, all notebook changes are from the pre-commit changes, it seems harmless.

Looks good!


Access Enchanter While Holding Shield

Describe the your request
Is it possible to make it so we can open the blaze enchanter's UI without having to first remove an equipped shield?

That's good!


CRUD for Firmware Image is not working

I don't know if it is a deployment problem or not, but I couldn't do any 'Firmware Image' operation.

Probably it was solved on last merged PR and will be working in the next baseline.


Data Augmentation

Hi Team,
Thanks for opensourcing the project. In the paper, one of the ablations study with data augmentation leads to performance drop. Can that be check from the current code ? If yes, please let me know how to do it. Thanks in Advance

Hi @amitbcp
You can turn off by setting
augment_data = false (this is for the token augmentation)
augment_coordinate = false (this is for the (pseudo-) image rotation and warping)
https://github.com/clovaai/spade/blob/a85574ceaa00f1878a23754f283aa66bc2daf082/configs/cord.1.5layers.train.yaml#L124-L125


update etcd to 3.5.15

It can be reviewed after https://github.com/pingcap/tidb-dashboard/pull/1709 merged

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

will we request to upgrade the etcd server? I thinks the client version should keep same with the server version we recommend to deploy.

will we request to upgrade the etcd server? I thinks the client version should keep same with the server version we recommend to deploy.

And the PD also need to upgrade etcd if it does. and the ectdctl binary in release artifacts.

will we request to upgrade the etcd server? I thinks the client version should keep same with the server version we recommend to deploy.

Yes, I am trying for it https://github.com/tikv/pd/pull/8441

/hold
it should merge to master after release-8.3 created.

/unhold
https://github.com/tikv/pd/tree/release-8.3 has been created cc @wuhuizuo
PTAL @baurine @mornyx


Single onError handler

I think there should only be one possible onError handler. It should be set be the application only, never by libraries. Currently we return an event identifier as well and can cancel it.
@trowski and @rdlowrey already agreed in chat, but just confirm that with a :+1:

If we're doing this I think that we should change the name so that it clearly operates in a different mechanism to the other on* methods.

It's still somehow an event. But I'd also be fine with setErrorHandler.

I'd like to note that I'm neither really in favor nor against it. I've not seen a need for multiple error handlers yet, but I might be wrong.
The only issue is that while we always can allow for multiple invocations of onError, we cannot restrict it later without major version bump.
onError in the LoopDriver though always should only accept one callable. (i.e. if we allow multiple onError callbackss, we'd just pass a closure from the Loop class which iterates over the list of callbacks).

I think it's a bad idea to have multiple handlers, because it's a last chance handler. Similar to the one in PHP. If that handler throws again, the event loop breaks and stops.

I principally agree with you; I'm just not sure whether there's really no need for it.
Hence it should be designed in a way that allows a change in a minor version (i.e. without BC break).

That's not possible.

Uhm… you want to allow to overwrite the handler (via Loop class)? I think that's a bad idea and encourages mistakes (accidental overwrite, people misunderstanding that it cannot be chained…)

You might want to unset it.

Don't think so. If you need to unset, also unset the whole loop then.

Maybe you want to set it in Aerys for startup and then let the user override it if he wants to log the errors himself.

You'd then provide your own way to the user to access the errors.

setErrorHandler is more explicit then onError for an error handler that only allows one listener, :+1: on this whole idea

There exists an unambigous a need for an event-loop-global error handler. We've felt this need most acutely in the aerys web server where an uncaught exception inside the event loop can bring down a server process. Indeed, that was the reason we first added the onError method to the amp reactor implementation. For the same reason set_exception_handler() is useful in web SAPI applications we need to be able to deal with scenarios that would otherwise end our application. In an async event-driven application the event loop is essentially its own VM environment inside the php process and it's critical to be able to deal with errors at the VM layer on a per-application basis.
As for nomenclature, I think it depends on whether we or not want to allow multiple handlers for such an event. If we want to allow users to register an arbitrary number of handlers then onError() likely makes sense. If one only then setErrorHandler()  seems more appropriate.

Submitted a PR as we seem to have achieved close to a consensus, copied from the PR:

There was some talk in the discussion about whether you would be able to enable/disable/reference/unreference this and treat it like other events.

This PR doesn't do that, because I think it raises a few complications (are error handlers automatically unreferenced?) that might lead to bugs and ultimately doesn't add any functionality.

If anyone disagrees with my assessment, feel free to thumbs down here and we'll move the discussion back to the issue.

Closed withj #45


[RDBMS] az postgres flexible-server replica create: Add support for --tags parameter

Related command
az postgres flexible-server replica create
Description
Add support for --tags parameter
Testing Guide
Manual testing
History Notes

[RDBMS] az postgres flexible-server replica create: Add support for --tags parameter

This checklist is used to make sure that common guidelines for a pull request are followed.

[X] The PR title and description has followed the guideline in Submitting Pull Requests.

[X] I adhere to the Command Guidelines.

[X] I adhere to the Error Handling Guidelines.

RDBMS

@evelyn-ys PR is good, please review

will review after current 10-08 release

@yonzhan @evelyn-ys do you mind reviewing this PR?

@mattboentoro Pls resolve conflicts

@evelyn-ys conflict resolved


refactor: few updates to have the functionality on-par with sentence-transformers and other minor updates

This PR adds

correct library name passed to HF hub
correct logic for local files only
updated dependency to correspond to newer feature
update target device since it's renamed since the 2.3.0 which we want to upgrade to

I locally ran the code for both local model and downloading from HF hub and it works well.

@BBC-Esq let me know if this PR makes sense to you, and you can merge it so it also gets to the main repo.

Sorry for the slow response.  I won't have time to review this due to work.  Are you able to push the lazy blokes at the Instructor repo to accept my pull request and then perhaps you can submit your modification?  Alternatively, I'm not sure if it's possible to simply submit your change to them directly even if they're lacy in accepting mine?  I'm not a programmer by trade!  Chat gpt 4 taught me!  ;-)

Hey, I just totally forgot about this dude.  My bad.  I'll take a look by tomorrow.  I had some personal stuff and work stuff and then this just flew by.  Nice to meet ya.


Move sockets to utils/handles

Move sockets.c and sockets.h to utils/handles and
the change the including path in the file that includes
sockets.h

#762


Add C implementation

#36

Thank you very much!
Merged in https://github.com/delight-im/ShortURL/commit/85601bbb9c49aa06b3b681a77b17f752fc05e836.


[Opensearch fails while performing bulk request for new index]

Describe the bug
While i try to do a bulk upload to the opensearch , it fails with error:
Exception in thread "main" java.io.IOException: Unable to parse response body for Response{requestLine=POST /_bulk?timeout=1m HTTP/1.1, host=http://localhost:9200, response=HTTP/1.1 200 OK}
To Reproduce
Steps to reproduce the behavior:

Opensearch rest
BulkResponse resp = client.bulk(bulk, RequestOptions.DEFAULT);
i tried even with client.bulkAsync(bulk, RequestOptions.DEFAULT, new ActionListener(){}
Error:
Exception in thread "main" java.io.IOException: Unable to parse response body for Response{requestLine=POST /_bulk?timeout=1m HTTP/1.1, host=http://localhost:9200, response=HTTP/1.1 200 OK}
at org.opensearch.client.RestHighLevelClient.internalPerformRequest(RestHighLevelClient.java:1781)
at org.opensearch.client.RestHighLevelClient.performRequest(RestHighLevelClient.java:1728)
at
org.opensearch.client.RestHighLevelClient.performRequestAndParseEntity(RestHighLevelClient.java:1696)
at org.opensearch.client.RestHighLevelClient.bulk(RestHighLevelClient.java:363)
at elasticsearch.Uploader.main(Uploader.java:77)

Expected behavior
i expect my bulk request  to be processed as it was there while i was using the elasticsearch instead of opensearch.
The same code works fine with elastcisearch and elasticsearch-rest-high-level-client:7.5.1
Plugins
Please list all plugins currently enabled.
Screenshots
Attaching the screenshot of the complete error.

Host/Environment (please complete the following information):

OS:  MacOS Monterey
Version : 12.5.1

Additional context
Add any other context about the problem here.

Could you provide more details related about your OpenSearch and Elasticsearch cluster versions? are you using elasticsearch-rest-high-level-client:7.5.1 to communicate with OpenSearch?

@anantsingh09 I can reopen. Sounds like client 1.3.0 <> server 1.3.0 works. Which combination of client/server doesn't?


Add a function that keeps the same distance from cursor to the camera.

Overview
Sometimes the target is too far away to make the cursor too small to see,and sometimes we want the cursor size to remain the same,that means keeps the same distance from the camera.
So I modified the Cursor. cs, added a bool variable 'IsCameraCursorDistance', and renamed the 'SurfaceCursorDistance' to 'CursorDistance', the 'IsCameraCursorDistance' control the 'CursorDistance' means the distance is from the Cursor to hit or  camera,the former retain the original function, and the latter can keep the Cursor size unchanged.
Then in the method UpdateCursorTransform(),I will calculate the cursor position based on 'IsCameraCursorDistance' and 'CursorDistance'.
Changes

Fixes: # .

Changed the base from master -> may18_dev as master does not receive direct checkins.

@67688FEA, Have you tried adding the FixedAngularSize script onto your cursor? that will keep it the same size visually without needing to change the distance.
Thanks!

@davidkline-ms Thanks for your advice!