Performance issues with metadata cache and go to definition for copybook

Describe the bug
I have a network share where I keep a large collection of copybooks that are shared among my projects, workspaces. This share is added in my coboleditor.copybookdirs as a UNC path \\FileServer\CopyBooks. Having this path in the settings significantly slows down the caching process and even worse the go to definition command.
From the attached javascript profile while the setting included the network share, it took ~30 seconds to resolve the go to definition command for a workspace that had already been fully cached and the cache contained the entry for the copybook I wanted to jump into. CPU-20200624T160153.894Z.cpuprofile.txt
Removing the network share from the settings fixed the problem, but now it can't go to my network copybooks.
To Reproduce

Add a potentially slow file system path to the  coboleditor.copybookdirs
Enable metadata cache
Process files in workspace
Ctrl+Click on a copybook COPY statement

Expected behavior
In a workspace that has a fully loaded cache, going to the definition of the copybook file should be very quick.
Screenshots

Desktop (please complete the following information):

OS: Windows
Version: Code 1.42.1, Extension: 6.3.11

What user & workspace settings are being used?:

coboleditor.copybookdirs contains Windows file share at end of list
coboleditor.cache_metadata on

Additional context
Not sure there's anything you can do about how long fs.exitsSync takes on network file systems, but maybe there's a workaround to give up on a file if takes long then a set amount of time.

Yeah, I'm working on some workarounds to copy things locally. It's a tad more complex than a simple copy, but I appreciate the robocopy suggestion.
In order to have a timeout or limit, you'd have to update the opencopybook API to use more async functions and/or promises for the definition provider. That way you can use the async API from fs and combine it with a promise that automatically rejects after a timeout:
function isFileAsync(sdir: string): Promise<boolean> {
	let timeout = new Promise<boolean>((_, reject) => setTimeout(() => reject("Timeout"), 500));
	let fileStat = require('util').promisify(fs.stat)(sdir).then(f => f.isFile());
	return Promise.race([timeout, fileStat]);
}

Let me see if I can put something together in a PR.

Hold off the PR (don't want to waste time), as it might clash with some changes.

option to drop all unc copybook dirs
feature to drop slow directories during extension setup

I should also say the changes to use file async are much more wide-spread in the code base, from the parsing, source definition, outline/symbol provider.
But more importantly, I would like to move away from using any 'fs' api, as this means the extension can only work the "file://" schema and ideally, it should work on all schemas, so a re-think is required to things differently... especially if the extension is to be used in browser-based hosting environments for the extension.

Can you please report back with more information using the latest version

I can confirm that the new setting does in-fact block my UNC share folder entry and keeps the extension host happily running at acceptable performance. Having that setting off (or while I was in some odd configuration state), still causes the extension to spin the CPU and trigger VS Code's extension performance warning.

The other thing, I did was to include a "quick" performance check while initializing the extension, so if an "isDirectory" takes more than 2seconds it drops it from the list of viable extensions (and says so).
I am considering removing the ability to reference any copybook directory that is not in the workspace, this way the use of the node fs api can be reduced to almost nothing, as I can then move back to using the vscode/workspace apis.
This would include static/directories & unc files.. aka anything outside the workspaces.

Taking out the ability to reference copybooks outside of the workspace would not be great because it would take away a feature that shared libraries provide. Leaving users to come up with their own packaging system to get things into each workspace.
I haven't dug into the flame graph is see what exactly is taking the most time. But if I had to guess, the UNC path is not slow for a single fs.stat request, rather, when you have it in loops that are executed over and over again with candidate paths (this copybook path with this or that extension). You're flooding the network with a bunch of stat requests that collectively take too much time for the share to handle in a timely manner.
I'm fine with manually trying to copy my copybook "packages" out of the UNC share, but it would not be great to have to do this for every workspace that I have. I'm sure I could work around it with symlinks, but it just adds more complexity.

I should clarify, I would also attempt to add the "direct" path into the workspace automatically, thus allowing a degree of automatic migration.

Just for reference, if you add the UNC directories to your workspace and remove them for them copybooks dir settings, is it better?

Just for reference, if you add the UNC directories to your workspace and remove them for them copybooks dir settings, is it better?

I don't know why I didn't think of that before. I think I was worried that it was cause the extension to start writing caches files to that directory (most users don't have write access) or try to process all the files in there, which is a lot.
Long story short: Added the path as a workspace folder and everything is still working quickly!

Option to migrate to "out of workspace" folders into the folder has been include and a warning message if an unc name is used.
Anyway, the later might be used now.
PS.  Glad you have a working solution.


check fee module locked and enable fee before refunding all fees

Description

Add check locked fee module and fee is enabled before refunding all fees

closes: #1321

Codecov Report

Merging #1341 (d749d8a) into main (7bb609c) will decrease coverage by 0.04%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #1341      +/-   ##
==========================================
- Coverage   80.27%   80.23%   -0.05%
==========================================
  Files         166      166
  Lines       12023    12029       +6
==========================================
  Hits         9652     9652
- Misses       1916     1920       +4
- Partials      455      457       +2

Impacted Files
Coverage Δ

modules/apps/29-fee/ibc_middleware.go
91.39% <0.00%> (-3.79%)
:arrow_down:

Just a couple more nits and then it's good to merge :)
Also, please add a changelog entry.

@seantking thanks for thorough reviewing. I updated !

@vuong177 thanks for the contribution :) You'll need to bring the pr up to date with main for it to be merged

@colin-axner thank you !


Adding in target property support for area objects

Hi, not much to this, just adding support for the target property as we needed it for a client. Sorry if I've done anything wrong, first time contributing for me.

Good idea, will add it soon.


refactor(client-services): signal manager status

copilot:all

Current dependencies on/for this PR:

main

PR #3120   👈

This comment was auto-generated by Graphite.


Plot large time series efficiently

Would be nice to be able to plot the time series in its entirety if possible.
Possible solutions would be using something like Bokeh, Datashader, HoloViz.

I've got a solution already working with dashapp using plotly. I can post on github later this week if people are interested.


Added very basic terraform fmt runner

I added a configuration option for terraform.formatOnSave and a little function running terraform fmt - with the input from the document.

[x] Make path to terraform configurable
[x] Something is broken in the way the content is updated, see the go plugin for inspiration
[x] Squash commits

Thoughts?

thanks for your contributions, I will push a new release to the vscode gallery later tonight after writing some changelog, do you mind if I mention you in the releasenotes?

the formatOnSave is kinda bad when you have Auto-Save on
is there a hook into editor.action.formatDocument that this could be executed on?


Performance Issues with Groups having many EPerson members

Describe the bug
I'm currently utilizing DSpace 7.5, where I've encountered a challenge. Within my system, there are approximately 1000 groups and 2000 members as epersons. One particular group contains 1300 members (epersons), while others have 50-100 members(epersons). When I attempt to search for the group with 1300 members (epersons) and one subgroup,  it takes a considerable amount of time to retrieve the results and when I click on edit it also takes 4-5 minutes to retrieve the current members (persons). I've also conducted tests using hal browser and found that the response time is significantly delayed.
The URL I use for this search is as follows:
/server/api/eperson/groups/6d2c20f0-f1b1-4ce2-b613-8c6816e9b90a/epersons
Even when I limit the search to just one result with the size=1 parameter:
/server/api/eperson/groups/6d2c20f0-f1b1-4ce2-b613-8c6816e9b90a/epersons?page=0&size=1, it still takes 3-4 minutes to receive a response. However, when I search for other groups with fewer members (50-100), the system performs smoothly.
I should mention that this issue is occurring in my local environment, using localhost:8080 and localhost:4000.
To Reproduce
Steps to reproduce the behavior:

Go to Access Control and click on Groups.
Then the Search group name in my case I have searched Students then it takes more than 4-5 minutes to retrieve the group(student).
After clicking on edit. again it takes 4-5 minutes to show Current Members.

Expected behavior
Since my other groups also require less time, it should consequently require less time.

@ashishkalekar : Thanks for creating this ticket with a clear explanation of what you are seeing.  I'll be bringing this to our next DSpace Developer's meeting (tomorrow) to make others aware and see if we can find a volunteer.  In the meantime, I've flagged this as high priority and pulled it over onto our 7.6.x maintenance board

the issue is related to this line:
https://github.com/DSpace/DSpace/blob/main/dspace-server-webapp/src/main/java/org/dspace/app/rest/repository/GroupEPersonLinkRepository.java#L48
all the members in the group are retrieved directly from our Entity data model object group.getMembers()
we will need to use a service to retrieve just the members that belong to the requested page.
We have something similar
https://github.com/DSpace/DSpace/blob/main/dspace-api/src/main/java/org/dspace/eperson/service/EPersonService.java#L248
but it is not paginated so an overloaded method is required with the corresponding real dao implementation

This PR that made the pagesize for the number of eperson and groups on the access control page configurable, may be related https://github.com/DSpace/dspace-angular/pull/1956

Claiming this, as I've had some time today to look at the issue. I think I understand what is going on & should have a PR ready early next week.

While the primary backend issues described in this PR are "fixed" by #9078, there are also frontend issues which I've summarized in https://github.com/DSpace/dspace-angular/issues/2512  Those will require a separate fix (which I'm also working on).

I now have a more "complete" fix to this issue and https://github.com/DSpace/dspace-angular/issues/2512:

(Additional) REST API Backend fixes: https://github.com/DSpace/DSpace/pull/9125
Angular UI fixes: https://github.com/DSpace/dspace-angular/pull/2545

The fixes are rather large because new REST Endpoints are required to fix the behavior of the Angular UI.  They are described in https://github.com/DSpace/RestContract/pull/241


GO:0045182 translation regulator activity parentage

GO:0090079    translation regulator activity, nucleic acid binding
has a direct parent to molecular function, but
GO:0045182 translation regulator activity
doesn't.
I think this is affecting our display (means that these appear as binding terms rather than MF terms)

Or, should these have has_part to binding? I'm still not sure how this works?

GO:0090079 translation regulator activity, nucleic acid binding
has a direct parent to molecular function

No it doesn't (assuming "has a direct parent to" means "has a direct is_a link to"). The diagram shows that GO:0090079 is is_a GO:0045182 and is_a GO:0003676 nucleic acid binding (is the latter what you meant?).
I wouldn't expect GO:0045182 to have is_a GO:0003676 because it's meant to encompass regulators that bind nucleic acid and ones that don't. It's possible that GO:0090079 should be connected to GO:0003676 by has_part instead of is_a, but that opens its own can of worms.

I was following the wrong link.


Updated on successful CI builds.


Workflow Templates

[x] 1 step (author -> editor <-> author <-> editor -> publish)
[x] Basic academic review ( author <->editor <->reviewer<->editor[ <->author <-> editor]->publish )
[x] Academic review with extra steps ( author <-> redaction review <-> language review <-> editor [ <->author <-> editor] <->reviewer<->editor[ <->author <-> editor]->publish )

As a feature implementation, these templates also can be extended to any journal by journal manager.


monado: upstream missing tooling in nativeBuildInputs

Description of changes
My understanding is that tooling that is required for development should be placed in nativeBuildInputs, even if it doesn't impact the build.
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Hmm. Not quite sure about this. Where have you read about this? :O

Hmm. Not quite sure about this. Where have you read about this? :O

I couldn't find much documentation for 'packages that are required for development but not for building' at all. In shell.nix, the only place that really makes makes sense to them it in is nativeBuildInputs. The proposed monado shell.nix file piggybacks off of nixpkgs for the buildInputs and nativeBuildInputs, since the maintainers are considering adding the shell.nix file but don't want to have to maintain it.
Is there a better place to put this?

I think this would fit in passthru but I am not sure if there is prior precedent to this.
I personally prefer to maintain my own out-of-tree flake for development purposes, if an upstream project is unwilling to include it in the repository.

I think this would fit in passthru but I am not sure if there is prior precedent to this.

Can you link me to the docs?

Any updates here?

CC @Scrumplex @expipiplus1 @prusnak; this is blocking an upstream MR

CC @Scrumplex @expipiplus1 @prusnak; this is blocking an upstream MR

How come? Link to MR?

How come? Link to MR?

https://gitlab.freedesktop.org/monado/monado/-/merge_requests/2152

How come? Link to MR?

https://gitlab.freedesktop.org/monado/monado/-/merge_requests/2152

This is just non-sense. Even upstream maintainers in the MR are confused.
I don't think we should add anything that is not directly required for building the package.

Actually, on reflection, several of these definitely should be in nativeBuildInputs

Actually, on reflection, several of these definitely should be in nativeBuildInputs

We only add things to nativeBuildInputs that are strictly required to build Monado. As it is right now, adding these dependencies doesn't really affect the build from what I can tell?

We only add things to nativeBuildInputs that are strictly required to build Monado. As it is right now, adding these dependencies doesn't really affect the build from what I can tell?

Yea. Just reverted that commit.

I am closing this. I don't think this makes any sense at all.


unable to run websocketd on Ubuntu 14.04

I extracted the websocketd-0.2.11-linux_amd64.zip onto my Ubuntu 14.04 server. Checked that the websocketd file was executable, it is when I check permissions with ll command. Although when I try to execute websocketd nothing happens. I am provided with "bash: .: websocketd: cannot execute binary file" error.
Please advise.

could you post result of your "uname -a" command?
Why do you use 0.2.11, not 0.2.12?
I could not repeat that on my 12.4 but who knows if there is special things about 14.4.. so I'd appreciate comments

Linux jvm-1 3.13.0-83-generic #127-Ubuntu SMP Fri Mar 11 00:25:37 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
I used 0.2.11 because that was the version I was linked to through the website's download section under linux 64-bit version. I missed the download link here on Github, although the website should also be updated.
I'll try 0.2.12 and reply with results...

@asergeyev I just tried the latest version, and still same issue. I'm hosting on Digital Ocean. Not sure if that is a factor, but shouldn't be. Maybe it's the way i'm trying to execute it? Shouldn't I be able to just extract the executable and in command link type " . websocketd " to execute it? Or am I doing this all wrong and i'm an ultra noob? lol

Oh, no, this is program, not bash script so you should do ./websocket

@asergeyev thanks for clearing this up... sorry for the trouble! I mostly use Linux to run LAMP server, and haven't ever used the ./ command to launch executable. You learn something new everyday! Thank you sir!

Done with this discussion I think.


Add unDraw

Hi there,
This is a great list of open-source illustrations.
Regards!

Hi, nice find!
Thanks for adding it


Hobbies

Fix styling in hobbies.js
// TODO: Add "Other noteworthy hobbies"
// TODO: Add "See More" & "See Less" buttons to the page to load more pictures
// TODO: Integrate "Portfolio in the navbar and Index.js page"
// TODO: Add some cool hover action to show details of picture

architecture,
maps,
linguistics,

communication styles:

metaphors, analogies to explain concepts
You have strong programming and analytical skills and you are able to communicate technical information through presentations to a non-technical audience.
You are resilient and are able to troubleshoot to resolve complex issues utilizing outside-the-box thinking and unique perspectives.
always seeking the opportunity to expand your abilities and perspective by working with diverse teams on challenging projects
building relationships with experts/leaders in different fields

May 2020:
Adventurous bc when I'm exploring film genres, falling down the YouTube rabbit-hole of history and science, and discovering new music on Spotify.
Most recently, my journey has bumped into a SWE Career Prep Fellowship (Feb'19), Intrapreneurial Self-Discovery (Jun'19), and an AR-startup API Internship (Sep'19). On a personal note, I am a native to sunny Los Angeles, CA, a soccer enthusiast, and an iPhoneography aficionado.

June 2020:
This summer, Ill be joinning  the Target Tech team as a Software Engineer Intern
In the upcoming weeks, I look forward to grow with my team, explore different virtual avenues, and create digital solutions!


Update GH Issue Templates

Enhancement Description
The issue templates in this repo are outdated.
Related Challenges
Copy the issue templates from the layer5io/meshery repo to this repo.

@aneeshnema would you mind giving this a go?

Sure!


Link in README gives 404

The link in the README file reads "neural_network", but the path in GitHub is "neural-network". This may seem unimportant for people arriving here via GitHub, but it's hard to find the right repository coming from rubydoc.

Also: the link for the Contributor Covenant is being treated as a local file

Excellent catch! Fixed both issues.
Thanks!


Debug Namespaces

Two Mac users and a Windows user could not get the Namespace to appear in the MLTE UI. However, a Linux user did get it working. Need to debug.

Closed by #332 (and #329 and #330)


Feat: Enable skip delete import tf resource when destroy

What would you like to be added?
Option skip delete imported tf resource when destroying release.
Why is this needed?
When the imported tf resource is still used by another release, we need to retain it so that the release using that resource can function properly.

@hoangndst  Thank you for your feedback! This is indeed a valuable suggestion! Are you interested in implementing this feature?

About this feature. I plan to add an IgnoreExternal field to the model Operator so from there the user can pass the command e.g. kusion destroy --ignore-external to the lower part to handle.
cc @SparkYuan looking for your view of this!

That much better


:recycle: Suggestions to replace the extname function

path.extname() should not be used for files with only an extension, as it will not be recognized as an extension.
There is currently no implementation of referencing ext in IdentityNode.fromRel(), but this is to prevent future bugs.
refer: https://nodejs.org/api/path.html#path_path_extname_path

Removed ext instead

:tada: This issue has been resolved in version 3.1.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


after zooming, new item cannot be add even if the red mark appears

After zooming, it is absolutely necessary to drop it on the red dot in order to drop a new item. So, new item cannot be add even if the red mark appears.

is this issue got solved already? when I am trying to add new element after zooming out, then the flow is getting scattered


vncviewer: Update to version 7.10.0

What type of Apps related PR is this? (check all applicable)

[ ] ✨ Add Manifest
[ ] ♻ Refactor
[x] 🐛 Bug Fix
[ ] 👷 Optimization
[ ] 🚩 Other

Description

Change the download url to fit with the new one
Remove the hash autoupdate section since it don't seems to exists/work anymore

Related Tickets & Documents
Fixes #133
[optional] What gif/emoji best describes this PR or how it makes you feel?
:alien: :fire: :bug:
Did you verify the followings
Add/Modify a description in the manifest?

[x] 👍 yes
[ ] 🙋 yes, but I need help
[ ] 🙅 no, because they aren't needed

Check URLs?

[x] 👍 yes
[ ] 🙋 yes, but I need help
[ ] 🙅 no, because they aren't needed

Update to the latest version?

[x] 👍 yes
[ ] 🙋 yes, but I need help
[ ] 🙅 no, because they aren't needed

Update Hashes?

[x] 👍 yes
[ ] 🙋 yes, but I need help
[ ] 🙅 no, because they aren't needed

Format the json manifest?

[x] 👍 yes
[ ] 🙋 yes, but I need help
[ ] 🙅 no, because they aren't needed

Did you identify extra steps
Notes in the manifest?

[ ] 👍 yes
[ ] 🙋 yes, but I need help
[x] 🙅 no, because they aren't needed

Application Dependencies?

[ ] 👍 yes
[ ] 🙋 yes, but I need help
[x] 🙅 no, because they aren't needed

Application Suggestions?

[ ] 👍 yes
[ ] 🙋 yes, but I need help
[x] 🙅 no, because they aren't needed

Pre-installation steps to perform?

[ ] 👍 yes
[ ] 🙋 yes, but I need help
[x] 🙅 no, because they aren't needed

Post-installation steps to perform?

[ ] 👍 yes
[ ] 🙋 yes, but I need help
[x] 🙅 no, because they aren't needed

File persistence to perform?

[ ] 👍 yes
[ ] 🙋 yes, but I need help
[x] 🙅 no, because they aren't needed

All changes look good.
Wait for review from human collaborators.
vncviewer

[x] Description
[x] License
[x] Hashes
[x] Checkver
[x] Autoupdate


Replace portknox logo

As animated GIF

Not sure we wanna allow gifs here. ;) Otherwise it’ll go crazy sooner or later. @tomneedham @jospoortvliet

@jancborchardt This is true. I believe we have one already so a decision needs to be made. Shall get this clarified in our new provider guidelines: https://github.com/owncloud/owncloud.org/commit/530c9989aa99ded1f74efa167a6aeb94f1f46806

Decision: We do not allow animated GIFs. :) (or APNGs for that matter …)

:)

Sorry @Gomez !


Correct spelling of Cocoapods in README

This pull requests corrects the spelling of CocoaPods 🤓
https://github.com/CocoaPods/shared_resources/tree/master/media
One day I’ll make a bot that looks through the READMEs of all Pods, looks to see if it uses “Cocoapods” and PRs “CocoaPods” :D— Ørta (@orta) February 10, 2016

Thanks! :)

:wink:


Tutorial

It has been asked that our tutorial also be made available in wiki form.
I'd like to implement a solution so that these can be managed from on centralized repo versus maintaing both a wiki and the railsgoat code base. Something to think about for the tuts branch (tutorial overhaul)

Have you thought of using Github's wiki feature for this. Here is the wiki for a project I worked on: https://github.com/PeaceCorps/medlink/wiki

I'm done porting the initial content that was in railsgoat to the wiki. Next, I'll submit a PR that has these tutorials removed from within the app (no sense in maintaining in two places).

https://github.com/OWASP/railsgoat/pull/197

Suggestions:

Change the ["a1", filenames to "a1-Injections", "a2" to "a2-Broken Authentication and Session Management", etc] in the right sidebar to match the TOC page.
Note the the sidebar sorts the entries so "a10" comes before "a2."

I've done a bit of that after getting your suggestion but I have to say - the wiki pages listing is terrible because I can't actually organize this into sub-directories. Or at least I've not found a way.

#a6e5ba63ccf57449a836e91ae96ddff95aa63f73 Fixes this


[Docker Desktop] Closing Settings and/or Troubleshoot screen should go back to the previous state

Tell us about your request
While following the get started tutorial, users might want to check out Settings and/or Troubleshoot icons in the top header bar (Since it is not disabled). If they intend to do that while the get started tutorial is being followed, clicking the close icon button should go back to the step the user was at during the get started the session.
Which service(s) is this request for?
Desktop
Tell us about the problem you're trying to solve. What are you trying to do, and why is it hard?
It's primarily a UX issue and if this continues to be this way users might either start over or skip the tutorial. I strongly think closing the Settings and/or Troubleshoot window should go back to the step the user was at.
Are you currently working around the issue?
N/A - But i could work on this change.
Additional context
N/A

Thanks for your feedback @pavan168. We'll be looking into fixing this as we continue to improve our desktop onboarding.

Thanks for your feedback @pavan168. We'll be looking into fixing this as we continue to improve our desktop onboarding.

Sure thing :) Will I be able to fix it and raise a PR?

The Desktop GUI is closed source so you won't be able to fix it at this time. We are currently looking at the fix and it should find its way into the next release. Thanks again for raising the issue


cannot find fonts

i am using propeller in my react app.
first i did npm i propellerkit and then import import 'propellerkit/scss/propeller.scss'; to app.jsx file.
i have solve this problem by copying fonts folder from dist to propellerkit.

Hello @bipinrajbhar ,
Glad to hear that you are using the library in your react app.
As per our understanding when you added the import 'propellerkit/scss/propeller.scss';line to app.jsx file you got an error for missing fonts which you have solved by copying the fonts folder.
Please let us know if our understanding is correct and that your issue is resolved.
Regards,
Monika

Yes @monika-digicorp


Disable upload in markdown editor public page

As of now, it is possible to upload images in the markdown editor. We should make it configurable if this is allowed, or not.
On the markdown editor filament component:
->disableToolbarButtons(['attachFiles'])

Hey @Cannonb4ll, My name is Saad, and I want to contribute to this Issue. It is my first issue on OpenSource, so Kindly bear with me on that part :)
I have a good amount of experience with PHP/Laravel, so I am feeling comfortable with the codebase.
(Btw I am new with filament and livewire)
I setup the project and did some research and found that I have to implement your suggested code in
Filename: app\Http\Livewire\Modals\Item\CreateItemModal.php on Line#70 to disable it When Submitting Item.
But on which condition we want to remove this ability, can you guide me on this please. For example: Except admin no one should able to upload image, or something allowed to individual user.

Hey @Cannonb4ll, My name is Saad, and I want to contribute to this Issue. It is my first issue on OpenSource, so Kindly bear with me on that part :)
I have a good amount of experience with PHP/Laravel, so I am feeling comfortable with the codebase.
(Btw I am new with filament and livewire)
~~I setup the project and did some research and found that I have to implement your suggested code in
Filename: app\Http\Livewire\Modals\Item\CreateItemModal.php on Line#70 to disable it When Submitting Item.~~
But on which condition we want to remove this ability, can you guide me on this please. For example: Except admin no one should able to upload image, or something allowed to individual user.
I think I got it wrong, I just viewed Admin area, so there is a whole settings area, I believe we need an option there to allow/disallow upload in markdown. Can you let me know what we refer as 'public page', Is Item single page where other user(s) can view item and comment on it considered as a public page?

Hey Saad!
Great to hear you want to contribute🥳
I'm not sure what you mean with public page and all, but what we want with this is a setting (toggle) inside the settings page that blocks the upload of files inside the markdown editor.
Let me know if you have any other questions!

I'm not sure what you mean with public page and all

It's inside the title of the issue "Disable upload in markdown editor public page"
Do we want to disable Upload of files inside all markdown editor instances found anywhere in the system by using that admin settings? or there may be any other case?

@msaadm Yes correct, in the frontend (not admin) it should be possible to block image uploads (you can drag and drop images inside the editor).
There's 2 places where you can find the editor:

Create item modal
Comment on items


Updated landing pages + removed links to landing pages

Current dependencies on/for this PR:

main

PR #5   👈

This stack of pull requests is managed by Graphite.


Add ghost graphics for all npcs from the 'Mulusi' tribe

Replace graphics of all npcs with following names:

Bulu Mulu
Dida Gula
Fula Gula
Furu Mulu
Mula Furla
Nuna Gula
Zulu Furla
Zulu Gula
Zulu Mulu

Affected maps:

Jaskinia Dzikich Kotów
Dzikie Pagórki
Osada Mulusów
Pradawne Wzgórze Przodków

All graphics have been modified by Karendar.

Thanks for the review. Is the code ok now?

Sorry for unnecessary commits, I tried to change the name of a commit I just pushed


Remove ibc rate limiting tests from github workflow

What is the purpose of the change
This PR removes IBC rate-limiting tests from our github workflow as IBC rate-limiting code was removed from the v12 branch so these tests are causing backports to fail
Brief Changelog

Remove ibc rate-limiting tests from workflow

Testing and Verifying
This change is a trivial rework / code cleanup without any test coverage.
Documentation and Release Note

Does this pull request introduce a new feature or user-facing behavior changes? (no)
Is a relevant changelog entry added to the Unreleased section in CHANGELOG.md? (no)
How is the feature or change documented? (not applicable)

Oops looks like carried a bunch of changes from main over, will open a new pr


itemSpacings and translation aren't updated properly if they are defined in the xml file.

While running tests itemSpacings and translation aren't updated properly if they are defined in the xml file.
SomeComponent.xml
<?xml version="1.0" encoding="utf-8" ?>
<component name="SomeComponent" extends="Node">
    <script type="text/brightscript" uri="pkg:/components/SomeComponent.brs" />
    <children>
        <LayoutGroup id="group"
            itemSpacings="[25]"
            layoutDirection="vert"
            translation="[100, 50]" >
        </LayoutGroup>
    </children>
</component>

SomeComponent.brs
sub init()
    group = m.top.findNode("group")
    print "group.itemspacings = " group.itemspacings
    print "group.layoutDirection = " group.layoutDirection
    print "group.translation = " group.translation
end sub

Actual result:
    group.itemspacings = <Component: roArray> = []
    group.layoutDirection =  vert
    group.translation = <Component: roArray> = []

Expected result:
    group.itemspacings = <Component: roArray> = [25]
    group.layoutDirection =  vert
    group.translation = <Component: roArray> = [100, 50]

width, height properties defined in the XML file aren't updated too.


[FEATURE] Improvement of flash message.

Problem
For now the flash message is displaying using bootstrap simple alert message. Particularly for this there is an ISSUE, that is it's not automatically disappeared, need to manually close it or simply refresh the page for closing this, his is very annoying and directly effect to the UX.
And also the flash message displaying very largely at the top of the screen with big size. That effect the UI of the Web site.
The Issue is here --->
https://github.com/user-attachments/assets/3cb4146e-16ca-4188-b293-104e2f3aa92d
Describe the solution you'd like
I want to replace this flash message with Bootstrap Toasts. For this the advantage is, it disappeared automatically after 5 second, You can also close it by clicking the close button on it, which is impact the User Experience directly because it's not directly placed on the website content, Just appeared on the screen corner and disappeared automatically.
Like this -->
https://github.com/user-attachments/assets/317f6ac0-cf14-436c-82de-b71b35997094
Could you please assign me this ISSUE. I want to work on this project.
Additional context
I am hacktober participant, Please add this tag also if you assign this to me..

Hey, someone is already working on the flash messages. Feel free to explore the project and create new issues!


using rootView instead of first child

https://github.com/yshrsmz/KeyboardVisibilityEvent/issues/61
Not sure this is the best solution but works for me

thanks, let's see how it goes ;)


[BUG] AcquireTokenSilentSupplier failed: Token not found in the cache

Describe the bug
Between msal4j versions 1.14.0 and 1.15.0 logging for AuthenticationErrorCode.CACHE_MISS has changed. I believe the change was accidental, resulting in additional (and potentially misleading) WARN messages being log.
Exception or Stack Trace
Our production system is logging "Execution of class com.microsoft.aad.msal4j.AcquireTokenSilentSupplier failed: Token not found in the cache" on "com.microsoft.aad.msal4j.ConfidentialClientApplication" logger (severity: WARN) every hour.
Expected behavior
Since cache miss simply triggers retrieval of a new token, I would expect this event (cache miss) to be logged with low severity. Preferably DEBUG level.
Setup (please complete the following information):

OS: linux
IDE: IntelliJ
Library/Libraries: msal4j-1.15.0-sources.jar
Java version: openjdk-21
App Server/Environment: N/A
Frameworks: N/A

Additional context
in msal4j-1.14.0 AuthenticationResultSupplier there was:
            if (exception.errorCode() != null && exception.errorCode().equalsIgnoreCase(AuthenticationErrorCode.CACHE_MISS)) {
                clientApplication.log.debug(logMessage, ex);
                return;
            }
            ...
            clientApplication.log.error(logMessage, ex);

logging CACHE_MISS on DEBUG level instead of ERROR.
in msal4j-1.15.0, there is only:
                clientApplication.log.warn(
                        LogHelper.createMessage(
                                String.format("Execution of %s failed: %s", this.getClass(), ex.getMessage()),
                                msalRequest.headers().getHeaderCorrelationIdValue()));

logging cache misses always on WARN level.

Hi @krysiuda, msal4j development and issue tracking happens in a separate git repo, here: https://github.com/AzureAD/microsoft-authentication-library-for-java.
I'll copy the issue over on your behalf and resolve this issue here as closed.

Closing issue.  New issue created here: https://github.com/AzureAD/microsoft-authentication-library-for-java/issues/833


Cannot Find File queries.train.small.tsv

Hi，
I was trying to train a BERT model for MS MARCO Passage Ranking. And according to the bash, there needs a ‘queries.train.small.tsv’ file. But I didn't find any download link on the MS MARCO website. Where can I get this file?
Thanks!

Hi,
You can just change the name of ‘queries.train.tsv’ to ‘queries.train.small.tsv’ or change the path to ‘queries.train.tsv’ file. What we need here is a tsv file that contains all training queries in the ‘trids_bm25_marco-10.tsv’ file :)
Kaitao

Thanks!


Allow to add custom HTML to be displayed in popup on click

From community:

my idea was to make an interactive map wiki, when you click on an item, it gives you details about this item, and what it is used for; a toggleable option below "Copy on click" called "Show descriptions" that, on click, if this option is enabled, will show a bubble with a description
"Show description on click"

any chance that we can add a context window when we select an object on the map.  this context window would pop up with an image or text or video.  for example if we single clicked on a soul orb it could pop up a context window with maybe a custom image attached that might show a screenshot or its location, or if we single clicked on an alter a context window could pop out with some text that could tell us that this trial has 2 waves or mobs and what qty and type of mobs spawn in each wave.

I second a context menu. Which'll be very useful when adding the treasure chests with fixed loot.

There was a concern voiced about sercurity if HTML was allowed, consider allowing only plain text or markdown.

Added in scope of 24ec2cb998914c6f10a0fab217fc84677aaaace1. One can add description on marker type or specific marker, they will be both combined in popup. Plain text, markdown, HTML with Bootstrap classes can be used.


extend/os/linux/keg_relocate: restore checking only GCC major versions

Only noticed this subtle behavioural change after merging. Let's restore the old comparison behaviour to avoid any unintended consequences (and use .major rather than .to_i to make it more obvious).

Review period skipped due to critical label.

👍🏻 thanks


OIDC sign in

create a session cookie (where the backend of the session stores an anti-forgery state token) and store redirect_uri if needed
direct traffic to authorization endpoint of OIDC
upon callback (via redirect_uri) from OIDC provider, retrieve ID token and create a authentication cookie
redirect to /authorize if needed

References

Google - OpenID Connect - Server flow
navigator.credentials
GetToken in authhelper/oauth in github.com/alexhokl/helper

Outstanding work

endpoint for callback from OIDC provider
issue of authentication cookie


SDP option to use blas-sys and lapack-sys

Here's a feature request ...
Is your feature request related to a problem? Please describe.
In https://github.com/RobotLocomotion/drake/issues/19449, I'm working to add Clarabel integration into Drake.  Most users of Drake use our pre-compiled binary releases instead of building from source.
As such, it is not practical for us to force a choice of BLAS/LAPACK at compile time.  Instead, we dynamically link to the libblas.so and liblapack.so (libblas.dylib and liblapack.dylib) from the user's operating system, so that their choice of the best BLAS for their own computer applications is respected.  It allows us to ship one binary release of Drake that can perform well on many different computers.
At the moment, it does not appear that Clarabel.rs or Clarabel.cpp offer a feature to use the system BLAS, which prevents us from extending our BLAS convention to Clarabel as well.
Describe the solution you'd like
See https://github.com/blas-lapack-rs/blas-lapack-rs.github.io/wiki for background.
The Cargo.toml as of 0.6.0 currently offers these features:
# enables blas/lapack for SDP support, with blas/lapack src unspecified
sdp = ["blas","lapack"]

# explicit configuration options for different blas flavours
sdp-accelerate = ["sdp", "blas-src/accelerate", "lapack-src/accelerate"]
sdp-netlib     = ["sdp", "blas-src/netlib", "lapack-src/netlib"]
sdp-openblas   = ["sdp", "blas-src/openblas", "lapack-src/openblas"]
sdp-mkl        = ["sdp", "blas-src/intel-mkl", "lapack-src/intel-mkl"]
sdp-r          = ["sdp", "blas-src/r", "lapack-src/r"]

I'd like to request a feature option to use the system blas, something like:
sdp-sys        = ["sdp", "blas-sys", "lapack-sys"]

I believe it also might require changes to src/algebra/dense/blas.rs etc to spell things a little differently.
Describe alternatives you've considered
I've been trying to prepare my own patches to accomplish this, but doing it with downstream patching it fairly awkward, and my unfamiliarity with Rust is slowing me down a bit.  Since I would plan to upstream the patches anyway, I thought I'd ask here to see if we could find a way to ship 0.7.0 with blas-sys out of the box.  Y'all might be able to do this more quickly than myself.

I am happy to try to support this but I am not clear exactly how it should work.  My understanding of the blas-sys and lapack-sys options is that they only provide an alternative style of interface to BLAS, i.e. "C-style" rather than "rust-style".
I think specifying something like
sdp-sys        = ["sdp", "blas-sys", "lapack-sys"]

would only really be promising that the C-style interface is there - it doesn't promise anything about linkage and doesn't go looking for any system-supplied library to load.
The other statuc options, e.g. "sdp-accelerate", just enable one of the BLAS sources for linking.   This is done by enabling additional compile-time options.
Example.
A possible model might be to handle access to some system installation in the way we do it in Python.   In that case we do not link to BLAS at all, but rather query back to Python and request function pointers for whichever BLAS functions Python is already using.   See here.
I don't have a strong feeling about the best way of doing this for Drake.   My suspicion is that if it were easy to dynamically link to some "system BLAS" as a standard features in the rust blas crate then this would already exist.   It may be very difficult to write a really general dynamically linked option that will always work.
I would therefore suggest that if Drake already knows about some system BLAS and can provide pointers to individual functions, then we write something like the Python loader mechanism for you.    That might also avoid issues with loading two different blas libraries at the same time.

Thanks for the feedback!  Let me explore a bit more on my end to see what might suit us best.

I found https://github.com/rust-ndarray/ndarray#how-to-enable-blas-integration which seems to indicate that openblas-src can be configured to use the system dynamic library.  I see if I can wrangle it (or something like it) to get it working.

Okay, I found a pretty good solution.  The Drake PR is https://github.com/RobotLocomotion/drake/pull/20475.
At the lowest layer, Rust is/was already calling into the normal BLAS (and LAPACK) ABI (e.g., dgemm_).  The additional capability that e.g. blas-src provides is to control how Rust links to the proper BLAS library (and if necessary, building that library from source).  Since in Drake we're not using Rust to create our executables, that part doesn't matter -- I don't need (or want) Rust to control that linking.  I can use my normal C++ linker to link to my normal (system) BLAS library alongside Clarabel.cpp, and everything works fine already.
The only change I needed to make to Clarabel.rs was to disable the instruction to use Rust to load the blas_src library that control the Rust linking.  Here's that patch:
[clarabel] Opt-out of Rust linking for BLAS/LAPACK

The blas_src and lapack_src crates are the Rust ecosystem's solution
for inversion of control when linking the BLAS and LAPACK libraries.
Library code refers to those crates and then the top-level Cargo file
of the ultimate application binary turns on a feature flag of those
crates that adds the right lines to the linker (and can also rebuild
BLAS and LAPACK from source, if necessary).

However, since Drake's ultimate "application" is to ship our own
shared library, we must not allow Rust to govern which libraries to
link. Thus, we need to delete the lines that perform the linking.

--- src/algebra/dense/blas.rs
+++ src/algebra/dense/blas.rs
@@ -8,8 +8,6 @@ cfg_if::cfg_if! {
     }
         else {
-        // standard imports via blas-lapack-rs crates
-        extern crate blas_src;
-        extern crate lapack_src;
+        // Use whatever shared libraries Drake provided.
         use lapack::*;
         use blas::*;
     }

That patch is pretty small so I don't mind at all to carry it locally within Drake indefinitely.  If you wanted to, though, I could imagine an upstream feature flag in Clarabel.rs that turned off those two lines, which would allow me to drop my patch, and might make it easier for other users in the future who encounter my same problem.
From my perspective though, Clarabel.rs basically already offers what I need, so I'm OK if you'd like to close this issue.
BTW There was also one tiny cleanup to Clarabel.cpp that I'll file separately.

I should also mention for the record that turning on Clarabel's sdp-netlib and then setting netlib-src.features = ["system"] in Cargo also mostly achieves the same result (of linking to the system BLAS, instead of building BLAS from source), but with a lot of extra clutter in the Cargo files.  The challenge there is that netlib has default features enabled of cblas and lapacke and tmg, which adds those extra shared libraries to the linker, but they are not provided (with those names) on Ubuntu.  (On Ubuntu, libcblas is not a separate library; is part of libblas.)  So for that to be a solution, we need to ensure default-features = false it used for netlib-src and that ends up being a lot of hassle, with changes to at least two (or more?) different Cargo files to support it.  For me at least, sidestepping blas-src entirely was much easier.  But if you wanted to pursue a Cargo-centric solution that your CMakeLists.txt could use to link the system BLAS, that would probably be the way to do it.


Feature fixes

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/mango-prb/325/
Test FAILed.

Waiting to merge in https://github.com/hammerlab/pileup.js/pull/450 before we merge this.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/mango-prb/333/
Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/mango-prb/335/
Test PASSed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/mango-prb/336/
Test FAILed.

Jenkins, retest this please.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/mango-prb/337/
Test PASSed.

Jenkins, test this please.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/mango-prb/338/
Test PASSed.


SW-5230 Ignore exclusions in site/zone/subzone areas

In the upcoming changes to support planting site editing, we're supposed to update
the site/zone/subzone area in hectares if an exclusion grows or shrinks. But we
were disregarding exclusions in the initial area calculations at site creation
time, which would have been inconsistent with the new behavior.
Internally, areas were being calculated as part of writing the site data to the
database, and the site/zone/subzone models were being intentionally constructed
with dummy values for their areas, meaning that newly-constructed models weren't
representative of the actual site data.
Move the area calculations into the model classes (or rather, the create
functions we use to construct new models) and make them take exclusions into
account.

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#1978  👈
#1977
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @sgrimm and the rest of your teammates on  Graphite

Merge activity

May 21, 7:49 PM EDT: @sgrimm started a stack merge that includes this pull request via Graphite.


One Persona_targeting with your archetype and methods of persuasion.

One Persona that represents one target customer that you are targeting with your archetype and methods of persuasion.

Alice - The Coffee Lover
Age: 21
Gender: Female
Education: University Student
Preferences
Values simplicity
Finds pleasure in everyday lifestyle
Enjoys her coffee
Enjoys the comfortable and simple setting
Lifestyle
Alice spends her afternoons studying or catching up with friends at a coffee shop while sipping her favorite cup of coffee and enjoying her favorite food. She likes to place orders online to support charitable organizations. Alice appreciates the friendly environment and always has a smile on her face.


⚠ Processors has degraded performance

In 45cc786, Processors ($STATUS_URL) experienced degraded performance:

HTTP code: 200
Response time: 89 ms

Resolved: Processors performance has improved in ada58d2.


Disabling sslv2, sslv3, TLSv1.0, TLSv1.1 for all the client application using OpenSSL 1.0.2k-fips.

We are trying to disable sslv2, sslv3, TLSv1.0, TLSv1.1 for all the client application( x11vnc, apache httpd) using OpenSSL 1.0.2k-fips. We already tried disabling these protocols from the client application side. For example, In httpd configuration files /etc/httpd/conf.d/ssl.conf and /etc/httpd/conf/httpd.conf we have disabled these deprecated protocols. However, we are unable to find any such configuration for x11vnc.
Hence we tried updating to openssl 1.1.1. By default for x11vnc and other client services, sslv2 and sslv3 got disabled. But, TLSv1.0 and TLSv1.1 protocols are still being used.

We don't want to manually update openssl 1.1.1 as it is part of centos 8 and we are using centos 7.8. Is there any way that we can disable deprecated ssl protocols while using openssl 1.0.2k-fips?
If we have to update to openssl 1.1.1, then how we can disable TLSv1.0 and TLSv1.1 protocols?

1.reference manual https://www.openssl.org/docs/man1.0.2/man3/SSL_CTX_new.html
2. reference manual https://www.openssl.org/docs/man1.1.1/man3/SSL_CTX_set_max_proto_version.html

The versions 1.0.2 and 1.1.1 are not supported anymore. Closing. If this is still an issue with currently supported releases, please open a new issue.


How do we sort a table by updated_at if we init it with None

This should be on stackoverflow, I assume.
Essentially, we want to sort by created_at when updated_at is None, and otherwise by updated_at and then zip both search results.
That's equivalent to sorting by updated_at if initializing updated_at with created_at (which is what I did before).

One note: Coalesce on columns from two tables seems to be slow for VARCHAR but not for TEXT in POSTGRES: https://dba.stackexchange.com/questions/297483/why-does-coalesce-prevent-the-use-of-an-index-on-a-varchar-but-not-on-a-text-co

Overall, there seems to be no reason benchmarking-related reason to choose option B over A: https://lamin.ai/docs/lndb-scale/examples/2022-09-28-timestamps
I'd hence suggest going with option A, given its pros.

Ok, let's choose option A :)

🙏
Let's see when we regret it. 😆


Palo Alto lack of spaces

Hi doc team,
I have a customer reporting that in step 2.6 in https://help.sumologic.com/docs/integrations/security-threat-detection/palo-alto-networks-9/#step-2-define-the-destination-for-the-logs that there should be a space in between the last parameter and the token (similarly to https://helpstaging.sumologic.com/07Sumo-Logic-Apps/22Security_and_Threat_Detection/Palo_Alto_Networks_9/Collect_logs_for_the_Palo_Alto_Networks_9_App#step-2-define-the-destination-for-the-logs|https://helpstaging.sumologic.com/07Sumo-Logic-Apps/22Security_and_Threat_Detection/Palo_[…]Networks_9/Collect_logs_for_the_Palo_Alto_Networks_9_App).
It looks like the new doc doesn’t have the space and/or has a new line in it. Can we please fix?
Slack Message

Duplicate


Tests fail on install

When I follow the installation instruction in the README, I get the following test failures:
-------------------------------------------------------
 T E S T S
-------------------------------------------------------
Running se.liu.ida.rdfstar.pgtools.conversion.RDFStar2TinkerpopPGTest
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.461 sec
Running se.liu.ida.rdfstar.pgtools.conversion.RDFStar2PGinCSVFormatTest
Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.014 sec
Running se.liu.ida.rdfstar.pgtools.conversion.PG2RDFStarTest
@prefix xsd: <http://www.w3.org/2001/XMLSchema#> .
_:v1 <name> "'marko' ;'polo'"^^xsd:string ;
     <age> "29 ;25"^^xsd:integer .
_:v2 <name> "lop"^^xsd:string ;
     <lang> "ja,va"^^xsd:string .
_:v4 <name> 'citat teecken "ser ut sa'^^xsd:string .
_:v3 <name> "fml"^^xsd:string ;
     <lang> 'ja"g";vi"ll "test"; sova typ;nu'^^xsd:string .
_:v5 <name> "Gunnar                   Stenson"^^xsd:string .
_:v6 <name> "'marko' ;'polo'"^^xsd:string ;
     <age> "29 ;25"^^xsd:integer .
_:v6 <lang> "ensak"^^xsd:string .
<<_:v1 <created> _:v2>> <weight> "0.4"^^xsd:double ;
                        <oldest> "0.8"^^xsd:double .
<<_:v1 <friends> _:v2>> <oldest> "0.7;0.2"^^xsd:double .
<<_:v2 <nagot> _:v1>> <weight> "bajs;kiss"^^xsd:double ;
                      <likes> "coolio"^^xsd:string .
_:v2 <ingenmeta> _:v1 .

[main] WARN org.apache.jena.riot - [line: 3, col: 12] Lexical form '29 ;25' not valid for datatype XSD integer
[main] WARN org.apache.jena.riot - [line: 11, col: 12] Lexical form '29 ;25' not valid for datatype XSD integer
[main] WARN org.apache.jena.riot - [line: 15, col: 34] Lexical form '0.7;0.2' not valid for datatype XSD double
[main] WARN org.apache.jena.riot - [line: 16, col: 32] Lexical form 'bajs;kiss' not valid for datatype XSD double
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.029 sec

Results :

Tests run: 7, Failures: 0, Errors: 0, Skipped: 0

If I understand correctly, these are problems with the upstream Jena library, rather than in your code proper.  Looking up my history, I do not see any errors with the installation and testing of RDFstarTools.
I'm afraid I'm not very knowledgeable about modern Java development, so I would need some direction to know how to investigate this any further. Thanks.

One more note, I was hoping for docs, so I tried mvn site.  I don't know if I should have expected this to work, but it failed with
[WARNING] Error injecting: org.apache.maven.report.projectinfo.CiManagementReport
java.lang.NoClassDefFoundError: org/apache/maven/doxia/siterenderer/DocumentContent

in case you are interested.
Also, it's not clear how to run the jar file that we have built.  Could you provide an example command line?


[x64] add new jax_default_precision flag

This is part of landing step 1 of #8178.
This adds a new jax_default_precision flag, which defaults to '64', and can be set to '32'. It controls the precision of dtypes.int_, dtypes.float_, jnp.int_, jnp.float_, etc. and by extension, controls the default precision of arrays created by functions like jnp.arange, jnp.linspace, jnp.argsort, etc.
This makes it such that the core change of #8180 will simply be to flip the default flag value to '32'. Having the flag available during the transition to this new default will allow a softer landing for teams affected by this change.

WDYT about calling it jax_default_dtype or jax_default_dtype_precision?  I'm just a little concerned with it getting confused with jax_default_matmul_preicision, in the sense that someone looking for the thing jax_default_matmult_precision controls might see jax_default_precision and assume it's what they're after. Both are about precision but it seems like mentioning dtype might make it a little more intuitive.

Thanks - renamed the flag to jax_default_dtype, though it's maybe a bit confusing ("32" isn't a dtype, after all). Maybe jax_default_typewidth? jax_default_dtype_bits?

Or maybe keep it as jax_default_dtype, but make the enumeration ['x32', 'x64'] to stick with our current nomenclature

You make good points! jax_default_dtype_bits seems kinda nice and thorough; no one's going to confuse that with matmul precision! I trust whatever you settle on.


Update installation instructions

Issue #, if available:
#1
Description of changes:
I had a similar error of #1 while trying to update scoop, saying The syntax of the command is incorrect. I try to debug it by adding some echo printouts aroung the file and returned < was unexpected at this time, which is the same as #1. And then I see the problem, for some reason, saving it from raw returns Unix (LF) line break type and not Windows (CR LF) line break type, setting line break type to that fixes it and the error does not happen anymore.
Updated installation instructions to reflect that and should prevent those errors from happening for new users.

thanks!


fix console error (google translate?)

maybe cause by chrome extension。
this is the relative url:
https://stackoverflow.com/questions/16145522/chrome-showing-error-as-refused-to-execute-inline-script-because-of-content-sec/16153913
https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Content-Security-Policy/script-src#examples-strict-dynamic
https://developers.google.com/web/fundamentals/security/csp?hl=zh_cn


Unpublish a record?

Nice library.
Is there a way to unpublish records?

Sadly this library is dead, development wise. There was no way to unpublish
a record, other than stopping the process.
On Wed, Mar 16, 2016 at 4:25 AM, Arne Jørgensen<EMAIL_ADDRESS>wrote:

Nice library.
Is there a way to unpublish records?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
https://github.com/davecheney/mdns/issues/14

Fair enough. I'll look around for alternatives. Thank you for your time.


Remove jQuery class from the project page

Switched from jQuery class functions to plain JavaScript classList
Tested the edit column modal functionality and it works as before

Let's backport this so that backport https://github.com/go-gitea/gitea/pull/30237 can be automatic.


Windows Wheel file doesn't exist for tensorflow_io_gcs_filesystem library for the latest version pip install tensorflow-io-gcs-filesystem==0.37.1.

Issue type
Bug
Have you reproduced the bug with TensorFlow Nightly?
Yes
Source
source
TensorFlow version
2.18.0
Custom code
Yes
OS platform and distribution
Windows
Mobile device
No response
Python version
3.10.0
Bazel version
No response
GCC/compiler version
No response
CUDA/cuDNN version
No response
GPU model and memory
No response
Current behavior?
if we install -> pip install tensorflow-io-gcs-filesystem==0.37.1 it will always download the wheel file of older version of tensorflow_io_gcs_filesystem-0.31.0-cp311-cp311-win_amd64.whl (1.5 MB view hashes)
It should be able to get a version corresponding to the latest version for windows also.
Standalone code to reproduce the issue
if we install -> pip install tensorflow-io-gcs-filesystem==0.37.1 it will always download the wheel file of older version of [tensorflow_io_gcs_filesystem-0.31.0-cp311-cp311-win_amd64.whl ](https://files.pythonhosted.org/packages/ac/4e/9566a313927be582ca99455a9523a097c7888fc819695bdc08415432b202/tensorflow_io_gcs_filesystem-0.31.0-cp311-cp311-win_amd64.whl)(1.5 MB [view hashes](https://pypi.org/project/tensorflow-io-gcs-filesystem/0.31.0/#copy-hash-modal-5a9e9ff6-6e95-4cec-940e-ae66d32efe0c))

Relevant log output
No response

@adarshbilimagga,
Looks like this issue is more related to Tensorflow-io. Could you please raise the issue in tensorflow-io from here for the quick resolution. Thank you!

Yes i had reported there but we didnt get any response - https://github.com/tensorflow/io/issues/2048.

same here

@adarshbilimagga,
As the issue is related to tensorflow-io, please check the update in the respective repo for the quick resolution and also tensorflow doesn't have control on the tf-io repo. Thank you!


Cleanup zap/repo/src-electron/generator/matter/darwin-framework-tool

The goal is to eventually cleanup the matter specific zap code to not have any state for eg in ClustersHelper.js
During this cleanup we want to do the following:

Go through the matter directory in this issue. See if these helpers can have code pushed to the backend sql queries.
See if the helpers can use any of the existing helper logic and can remove code redundancy
Add unit tests for each of the helpers listed
Make sure to have a CHIP/Zigbee repo branch that points to your changes and passes the CI on both places
Also if you can fix anything new apart from what is listed then fix those issues as well.

Closing all MatterZapCleanUp tagged issues since a majority of these have been resolved


Project setup and list structure

Create list structure according to spec from curriculum-javascript/todo-list/m1_list_structure.md
Preview:

https://htmlpreview.github.io/?https://github.com/yghoor/to-do-list/blob/project-setup-and-list-structure/dist/index.html

The memo readme also says it should be in production mode, but it looks like its in dev mode. Please check this as well

Fixed issues in latest branch before test branches


feat: add simple discussion feature for each task

The title should tell the whole story. All I did was adding a small discussion feature that will be available on every task page. Here's how it looks.

The UI isn't perfect though as this PR is focusing merely on the discussion feature. Thanks.

Thank you brudda!


[feature] Cassandra support

Hi, I saw Cassandra in future plan and I'd like to give it a shot, I got some questions before start writing the code.

The cassandra driver gocql does not implement database/sql interface, there is a thin wrapper. I think it might be better to write the wrapper in usql to reduce dependency
Cassandra's CQL has some differences with SQL, is there any SQL specific logic I need to be aware of (completion etc.)?

Cassandra does not have transaction, it does have batch, which is BEGIN, APPLY but no ROLLBACK

testing, it seems test is also in todo list

Any well written pull request creating a CQL driver would be welcomed. It's not high on my personal list of priorities, but this would be relatively easy to implement, by adding the proper driver entries. A bit of rewriting would be necessary, as the REPL code expects to work with the standard library's database packages/types, and as such could be quite a bit of work. An alternate approach would be to write a package that wraps the CQL driver and registers it as a Go database. Either approach would be roughly the same amount of work.

@at15 it seems there is a new-ish SQL compatible driver for CQL: https://github.com/MichaelS11/go-cql-driver
I found it only this morning, and finished adding initial Cassandra (well, CQL) support to usql just now.
Please test it out:
$ go get -u -tags most github.com/xo/usql
$ usql cassandra://cassandra@localhost/
error: cql: invalid username cassandra or password
Enter password:
Connected with driver cql (Cassandra 3.4.4)
Type "help" for help.

ca:cassandra@localhost=> select * from xxx.y;
                 my_id                 | first_name | last_name
+--------------------------------------+------------+-----------+
  52e01ecb-4a2f-4274-af46-8464f6032cc8 | aoeu       | test
(1 rows)

ca:cassandra@localhost=> drop keyspace xxx;
DROP KEYSPACE
ca:cassandra@localhost=>

It was a bit trickier to support this driver, but it's integrated. Let me know how it's working for you.

@kenshaw I got error from xo/usql/rline when build,  use vgo build -tags "cassandra" worked for me
# github.com/xo/usql/rline
rline/rline.go:134:15: l.Inst.Config.Output undefined (type *readline.Config has no field or method Output)
rline/rline.go:189:11: undefined: readline.NewCancelableStdin
rline/rline.go:197:20: unknown field 'HistorySearchFold' in struct literal of type readline.Config
rline/rline.go:204:22: unknown field 'FuncFilterInputRune' in struct literal of type readline.Config

It is caused by https://github.com/gohxs/readline, btw: the upstream of the fork is active again https://github.com/chzyer/readline/pull/121, maybe switch back to it?
I can connect to cassandra, but when I select something I only get 0 rows or no response and there is no error when I enter an query with syntax error, it might because I am using Cassandra 2.1, but when using gocql directly, things are working ...
cassandra@cqlsh:aaaa> show version
[cqlsh 5.0.1 | Cassandra <IP_ADDRESS>3 | CQL spec 3.2.1 | Native protocol v3

Please note you shouldn't  need to use dep. I've switched the project over to using vgo. If you did vgo build successfully, it would have placed the usql binary in the same directory. I'll take a look at the chzyer/readline project again, but I'm unlikely to switch it again -- I actually have a non-published, long-running branch of usql that has syntax completion that by necessity required me to write my own readline implementation. I'd probably focus on finishing that branch instead of switching back to the chzyer/readline.


Python: clean up old versions of packages

Issue description
Occasionally we add multiple versions of Python libraries because certain packages cannot use the current/latest version. Sometimes these older versions are left behind or upgrading to the latest version wasn't attempted. Let's check whether we still need all these old versions.
The following is a list of attributes that contain a version (thanks to @orivej) and that could be older versions.

[ ] amqp_1. Needed for kombu_3 which is needed for oslo which isn't maintained.
[ ] click_5. Needed for platformio. @mogorman (note that your handle doesn't match your GH name)
[ ] kombu_3. See amgp_1.
[x] beautifulsoup4. Upstream name.
[x] boto3. Upstream name
[x] deform2. Duplicate 63550e35fb4f4de3f0ecd6c294f62f2088826c4c
[x] gmpy2. Upstream name.
[x] pycurl2. Upstream name.
[x] pyparsing1. Used in mwlib. 6c467b7448c25d25ddbe9f7dec22303305386dbc
[ ] pyro3. Upstream name is Pyro. Package is only used by openopc
[ ] requests2. We should rename this to requests and see whether we can get rid of the current requests.
[x] tqdm4. a33f9b0ff0e59d642a57511037f01dc67f02922c
[ ] beautifulsoup_4_1_3. Only used by flexget. See https://github.com/NixOS/nixpkgs/pull/21636
[ ] dateutil_2_2 Only used by csvkit. @vrthra perhaps upgrade csvkit?
[ ] dateutil_1_5. Used by couple older packages.
[ ] dateutil_2_1. Only needed by flexget https://github.com/NixOS/nixpkgs/pull/21636
[ ] pathspec 0.3.4: Only used by pants. @copumpkin does pants really need this version? Looking at its setup.py it is very conservative with its dependencies.
[ ] django_1_9. @lsix I know this has been brought up before, but which versions are we going to keep again?
[ ] django_1_8
[ ] django_1_6
[x] lxml_3_5. Not used at all so lets get rid of it. d3cebfb907f71dfc2352ba2b6907cd406653abee
[x] mccabe_0_5. Not used at all so lets get rid of it. 12b2fbf7fb2a56ed0b156a22435da8262ea20b89
[ ] openpyxl_2_2_0_b1. @vrthra another dependency of csvkit.
[ ] pymongo_2_9_1. Used by eve and flask-pymongo. Both expressions don't seem to be maintained.
[ ] sqlalchemy8. Needed for two packages but its been broken for a long time. Let's remove it.
[ ] sqlalchemy_1_0. This will be the only version left.
[ ] zc_buildout2 @garbas which versions do we need?
[ ] zc_buildout221
[ ] zc_buildout171
[ ] zc_buildout152
[x] billiard_33. Not used. Let's remove it. 4847ef5428498f2978ef1b8acb6f9400ef828a1f
[ ] llfuse-0-41. Only used for attic. @bjornfor attic isn't maintained. Are we going to keep the expressions?
[ ] boto-230. Only used by gsutil which is an application with strict requirements. gsutil should probably be moved out of python-packages.nix along with its specific requirements.

@Denommus you've added the eve package in https://github.com/NixOS/nixpkgs/pull/12222. Could we get a eve upgrade so we can get rid of the older version of pymongo?

We can remove attic. Perhaps set meta.broken now and remove after next release?

@bjornfor do you think we have attic users that would choose to keep using this backup software even when its unmaintained and marked as broken? I highly doubt they would so I think we can just remove it right away.

@domenkozar @cillianderoiste does any of you still use almir? It depends on the broken sqlalchemy8 that I like to remove.

It doesn't build with sqlalchemy9?

@FRidh: I have no idea if there are attic users left, so I thought a deprecation period could be helpful (in case there are). I myself have moved to borgbackup, so for me personally you can remove it right now.

I guess it could help to collect per derivation download statistics from cache.nixos.org, if possible.

@domenkozar I couldn't get it to work with the latest version. Anyway, because it wasn't working anymore I decided to mark it as broken.

Sounds good.

Requarding Django : the ideal solution would be to only maintain Django-1.11, which is the last LTS release (since 1 month).

Django 1.9 is officially not maintained since april so it would make sense to drop it.
Django 1.6 is officially not maintained since april 2015 so we should drop it.
Django 1.10 will be maintained until the end of the year. It would be preferable to not have it in 17.09 since it will not be maintained for entire lifetime of this nixos release.
Django 1.8 will be maintained upstream until the end of 2018 so there is no objection keeping it.

I’ll have a look at the various versions that could be dropped, bet they have all been kept because they are referenced by other derivations. I’ll review this ASAP.

Django 1.9 is officially not maintained since april so it would make sense to drop it.
Django 1.8 will be maintained upstream until the end of 2018 so there is no objection keeping it.

django_hijack currently uses 1.9 (I don't use it, but hit an evaluation
problem). Is there an update for it, or should it use 1.8?

@7c6f434c django packages should always depend on django, not on a specific version. When one then wants to use the packages with a specific version of django they can override the django attribute

@7c6f434c django_hijack supports django 1.10. I was just checking if the current release supports django 1-11, but apparently not. We will have to wait until upstream brings support (or do it ourself).
I also saw that the PR I had for django-1.11 brings the evaluation problem. I am checking what I can do about that.

@lsix I think the evaluation and even build part is done now.
@FRidh the package in question doesn't support the default django at all.

@7c6f434c maybe add a note? If we start using specific versions of django we often end up with multiple versions in a closure.

django_hijack seems to be pretty good at failing when its closure
contains multiple versions.

I'm not sure who is using zcbuildout I'm not using it. I guess removing and keeping the latest would be a safe way to go forward.

@datakurre @chaoflow @cillianderoiste you were the last ones contributing to the zc.buildout expressions. Can we remove all but the latest versions?

@FRidh for pants, yes unfortunately the old pants will build fine with a newer pathspec but it'll fail at runtime. The moment they release 0.13 final (so we can get rid of the stable version) we can kill the old pathspec.

@FRidh what I'll do is move (as I said elsewhere) pants to its own file and then only keep the old pathspec in there, rather than in the global package set.

Will you cleanup pkgs/top-level/python-packages.nix too?

Expressions for Python libraries are supposed to be in pkgs/development/python-modules/<name>/default.nix.
buildPythonPackage should be replaced by callPackage

I would love to help on this, should I make PR incrementally while working on some packages and refer to this issue?

That should be mypackage = callPackage ../development/python-modules/mypackage/default.nix { };.
Please, go ahead. A commit per package and indeed a reference here would be helpful.

Closing this issue because basically all older packages have been (re)moved.


Objective-C support and customization

There won't be any Obj-C support in the foreseeable future. You can try these alternatives which are Obj-C based:
https://github.com/andreamazz/AMPopTip
https://github.com/chrismiles/CMPopTipView


--sqlite DBFILE option for exporting to SQLite

Unlike the other options this one will take an argument - the path to the SQLite database file to export to.

This may not work because the first positional argument, output_path is currently required and must be a directory.

Rather than wait until all records have been retrieved, I'm going to have the --sqlite option write batches of 100 records to the database as they arrive. This will allow you to run Datasette against the database and hit refresh to see the records coming in.

Will need to deal with weird column names - just hit an error against this generated SQL:
   [airtable_id] TEXT PRIMARY KEY,
   [ID] INTEGER,
   [Location] TEXT,
   [soft-dropped-column: Vaccines available?] TEXT,

An annoyance of the Airtable API is that it's not possible to distinguish many-to-one fields from many-to-many fields - a many-to-many shows up as values that are JSON lists with a single string in them.
I'm going to ignore that issue for the moment and just tolerate it.

Looks like that SQL error wasn't a problem after all - SQLite is apparently fine with columns called [soft-dropped-column: Vaccines available?]


a Daily Podcast Recommendation .

Story:
As a developer, I want to create endpoints for admins to curate and publish daily podcast recommendations so that all users can access these specially selected podcasts on their home page.
Acceptance Criteria:

[ ] Admins can select up to 10 podcasts for daily recommendations.
[ ] Allows admins to upload custom descriptions for each podcast to promote it .
[ ] Develop an endpoint for admins to create and submit these daily recommendations.
[ ] Develop an endpoint to retrieve the daily recommended podcasts.
[ ] Ensure that the daily recommendations are prominently displayed on the users' home page.
[ ] Implement security measures to ensure that only authorized admins can access the creation endpoint.

Demo Steps:

Demonstrate the admin interface for selecting podcasts and inputting custom descriptions .
Show the process of an admin using the endpoint to publish these recommendations.
Illustrate how users will see these daily recommendations on their home page.
Validate the security measures in place to prevent unauthorized access to the admin endpoint.

Potential Risks:

[ ] Risk of unauthorized access to the admin endpoint.
[ ] Potential performance issues with updating and displaying daily content to all users.

mockup of how it should like on the home page


about  dataset

I'm reproducing the results, but I can't download the data set of faceforensics + +. The running error says that I don't have access to the download website. So, could you please give me the downloaded dataset. I only need 4 kinds of manipulated data and original unmanipulated data under C23 and C40. could you send it to me after compression? I need your help, really.
my e-mail<EMAIL_ADDRESS>Thank you.

sorry, it will come down the problem about copyright. So I can not provid the daatset for you directly.


How to define short- and long-range interactions in this tool

Hello developer:
Sorry to disturb you & thank you for this amazing tool.
Now I have question about how to define short- and long-range interactions? Because I'm work on plant not animal and probably I need use different parameters for analysis Hi‑C data.
Best,
Han

Hi Han,
These are actually determined automatically based on compartments you provide. The short-range are those residing on diagonal, while long-range are those off-diagonal. Simply, the script finds stretches of compartments A and B and their intersects. The diagonal bits are becoming short-range, and their off-diagonal pairwise intersections are long-range. Please check Figure 1 in the original paper or supplemented illustrations on Github.
Mikhail


Issue #81 : Show FPS on the side of frame

This is wrt to the issue #81 : Showing FPS on the side of frame -

Importing of 2 additional packages in this python file - "datetime" and "imutils"
Added the  FPS to be displayed in the "main" function definition of this file

@akshitagupta15june This is wrt to the issue #81 : Showing FPS on the side of frame. I have briefly explained and done all the necessary changes. PR has been sent, Do merge it. Please guide me if there's anything wrong. Thank you.

@akshitagupta15june This is wrt to the issue #81 : Showing FPS on the side of frame. I have briefly explained and done all the necessary changes. PR has been sent, Do merge it. Please guide me if there's anything wrong. Thank you.

Hi @TanweerulHaque I just went through your this python file and figured out that you have used OpenCV as cv2 and cv somewhere. Please look at that. Use only cv2 or cv.

Hi @TanweerulHaque I just went through your this python file and figured out that you have used OpenCV as cv2 and cv somewhere. Please look at that. Use only cv2 or cv.

Sorry for the typo @q-viper . I have corrected it now. Thank you.

Sorry for the typo @q-viper . I have corrected it now. Thank you.

You have done right but please look at this article too.

You have done right but please look at this article too.

ok!
Thankyou so much @q-viper  mentor for reviewing the pr.
I am merging your pr @TanweerulHaque

ok!
Thankyou so much @q-viper  mentor for reviewing the pr.
I am merging your pr @TanweerulHaque


Reduce the default block size to 32 MB from 512 MB

Fix https://github.com/Alluxio/alluxio/issues/9394 by reducing block size to 32 MB

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/5222/
Test FAILed.

Jenkins, test this please

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/5224/
Test PASSed.

@calvinjia I checked my previous notes and I was recommending 64MB as block size for TPC-DS workloads using Spark. So updated the block size to 64MB

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/5323/
Test PASSed.

Ping @calvinjia

alluxio-bot, merge this please.


[BEAM-10976] Bundle finalization: E2E support

This is a continuation of the effort to add Bundle Finalization started in #16980
Summary of Overall Changes
Bundle finalization enables a DoFn to perform side effects after a runner has acknowledged that it has durably persisted the output. Right now, Java and Python support bundle finalization by allowing a user to register a callback function which is invoked when the runner acknowledges that it has persisted all output, but Go does not have any such support. This is part of a larger change to add support to the Go Sdk as outlined in this design doc.
Summary of Changes in this PR
I completed most of the execution changes in the last pr, leaving this PR to handle the user experience and plumbing the user's bundle finalization parameter through to the execution layer.
Additional testing done
On top of the units added, I also was able to run an E2E example on Dataflow (FWIW, only Dataflow currently has bundle finalization support). In that example, I hijacked the wordcount example and added a bundleFinalizer to write a file to persistent storage for each line that had at least 3 words (chosen pretty randomly to minimize the chances of collisions). I'll omit the whole sample since its long, but it produced a bunch of files like this:

This indeed ran after the other data was persisted.
I decided not to add an integration test because of the complexity involved. Because only the dataflow runner supports finalization, any integration test would require finding some way to (a) modify dataflow state and query that state (probably not a great option since it requires modifying a devs personal GCP account, and its not obvious what the best thing to do actually would be without knowing more about their config), (b) creating some sort of local endpoint for dataflow to talk back to (technically feasible, but definitely non-trivial - would also add significant complexity outside of what we're actually testing), or (c) using some 3rd party to communicate between the 2 (non-ideal since it adds an extra dependency that isn't part of what's being tested just for this scenario). I'm definitely open to doing this, but at the moment with the information I have it doesn't feel worth it.
Next Steps
After this, I'll update the documentation here to include an example https://github.com/apache/beam/blob/6438626c059c19ff9ca32cd834d0aa62253e531b/website/www/site/content/en/documentation/programming-guide.md#127-bundle-finalization-bundle-finalization

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Choose reviewer(s) and mention them in a comment (R: @username).
[x] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] Update CHANGES.md with noteworthy changes.
[x] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

@youngoli - would you be able to  review this change?
@damccorm - do you know why there is a large drop in code coverage diff?

do you know why there is a large drop in code coverage diff?

@aaltay I think its because out of 306 non-test lines changed, 188 are generated file changes. In particular, reflectx/calls.go is going from 0% coverage to 0% coverage, but its contributing 164 new untested lines. So unless I manually test the generated files (and I'd argue we should be testing the generation logic instead), the diff is guaranteed to drop. Looking at the per-file diff, I don't feel particularly bad about any of the changes.

do you know why there is a large drop in code coverage diff?

@aaltay I think its because out of 306 non-test lines changed, 188 are generated file changes. In particular, reflectx/calls.go is going from 0% coverage to 0% coverage, but its contributing 164 new untested lines. So unless I manually test the generated files (and I'd argue we should be testing the generation logic instead), the diff is guaranteed to drop. Looking at the per-file diff, I don't feel particularly bad about any of the changes.

I agree with you.
I guess it would make sense to not count generated files toward code coverage. (Neither a high priority, nor a blocker for this PR.)

Daniel, Please do keep in mind We Should Not submit this with a manually
changed generate pb.go file. The bot tagged you in after my review for some
reason.
On Fri, Mar 18, 2022, 7:09 PM Daniel Oliveira @.***>
wrote:

@.**** approved this pull request.
This looks good to me, with one small nit that I don't think is worth
blocking on. Let me know what you think of that suggestion and I can merge
after.
In sdks/go/pkg/beam/core/funcx/fn.go
https://github.com/apache/beam/pull/17045#discussion_r830423680:

@@ -415,7 +432,7 @@ func SubReturns(list []ReturnParam, indices ...int) []ReturnParam {
}

// The order of present parameters and return values must be as follows:
-// func(FnContext?, FnPane?, FnWindow?, FnEventTime?, FnType?, FnRTracker?, (FnValue, SideInput*)?, FnEmit*) (RetEventTime?, RetOutput?, RetError?)
+// func(FnContext?, FnPane?, FnWindow?, FnEventTime?, FnType?, FnRTracker?, FnBundleFinalization?, (FnValue, SideInput*)?, FnEmit*) (RetEventTime?, RetOutput?, RetError?)
Nit: Personally I think BundleFinalization should come before the
RTracker, because the restriction is basically part of the main input so I
feel it should come right before the main input. Not something I'd block
on, just preference.
—
Reply to this email directly, view it on GitHub
https://github.com/apache/beam/pull/17045#pullrequestreview-914956075,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ADKDOFKXTQTJ7YXFCGYE4LDVAUZNNANCNFSM5QHNRCRA
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you were mentioned.Message ID:
@.***>


feat: make fiat change non-breaking

High Level Overview of Change

Updates public API response to intelligently decide on ACH vs. FIAT
depending on whether the request is a 1.0 or 1.1 response.
Rolls forward the PayID protocol server version to 1.1.
Context of Change

Makes ACH -> FIAT addressDetailsType change non-breaking.
Type of Change

[x] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[x] Refactor (non-breaking change that only restructures code)
[x] Tests (You added tests for code that already exists, or your new feature included in this PR)
[ ] Documentation Updates
[ ] Release

Before / After

We know do some backwards compatibility stuff.
Test Plan

I fixed all existing tests, but need to add more test coverage now in a
subsequent PR.

v1.1.0 uses AchAddressDetails right? If so, I think it should be "if not v1.0.0 or v1.1.0, send FiatAddressDetails, otherwise send AchAddressDetails".  Could be wrong, but I think the way you have it squeezes the change into v1.1.0, making v1.1.0 backwards compatible with v1.0.0, not v1.2 backwards compatible with v1.1.0


Cancel request when a proxy request is interrupted

Fix #2567.
When proxing a request, if the user connection is broken, cancel the request.
Signed-off-by: Dong Chen<EMAIL_ADDRESS>

ping @docker/core-swarm-maintainers.

This issue will resolve an open bug in Eclipse Che - https://github.com/eclipse/che/issues/2962#issuecomment-269488994


Few symbols

Hi,
How to subscribe with websocket to many symbols at same time? For example, BTCUSD, ETHUSD, ....
  err = client.Ws.Public.OrderBook(ws_public_requests.OrderBook{
    InstID: "BTC-USD-SWAP",
    Channel: "books",
  }, obCh)

Thanks

I have fixed the issue in my fork: https://github.com/dyamin/go-okx
Additionally, I have submitted a PR to this repository


[Feature request] Archived threads need to be automatically skipped

When threads are archived by the owner or the moderator of the server, the thread cannot be archived.
The Undiscord userscript needs to automatically detect when the user's messages in a thread is archived and automatically skip them, without having to make an attempt to delete and give the user an error message.
At the end of the deletion, users should see if there are still messages left, as they usually do. Obviously the remaining undeleted messages would be from the archived threads, and the user would have an estimate how many messages they left in the server from those archived threads. Alternatively, the script could also state that there were messages that can't be deleted.
I've had many times the Undiscord userscript would try to delete a message, send me back an error message, move onto the next message, and repeat this pattern, making the deletion process a lot slower:

I would like the Undiscord userscript to skip archived threads entirely because messages from archived threads cannot be deleted.

Another reason: the Undiscord will keep retrying attempts to delete user messages that are in archived threads, making the program run for an infinite amount of time.

+1 this issue is a huge nuisance

+1 this issue needs immediate attention

+1 on this. Clogs up the deletion queue especially when 15/25 of search results are from archived threads then on next search pull from the api it requeues those archived posts so it's in a constant loop. Severely impacts deletions.


Windows support

This is the tracking issue to collect the needed steps in order to support windows as OS:

[x] make rustic compile on windows #11
[ ] treat non-unicode filenames and quoting of filenames (+link targets?) correctly
[ ] treat file permissions correctly
[ ] treat user/group correctly
[ ] treat special files (device,...) correctly
[x] handle paths (like C:...) in snapshots #510 and #542
[x] handle repo path containing a drive (like -r C:\path\to\repo) #495
[ ] handle links correctly
[ ] document windows behavior
[x] Correctly use a parent snapshot #542
[ ] Add VSS support (how others do it)
[ ] restore issues (e.g. #635)

Comment: It seems that Windows doesn't support non-UTF filenames, see https://learn.microsoft.com/en-us/windows/win32/intl/character-sets-used-in-file-names . This simplifies the filename + linkname issue a lot - we only need to handle the escaping in the unicode case...


SW-2261 Boundaries are always of type MultiPolygon

Previously, the API schema said that the boundary field on planting sites,
planting zones, and plots could be of any arbitrary geometry type. But internally,
the field is constrained to always be a multipolygon. Update the API to make
that constraint clear.
Most of the change here is updating the OpenAPI schema definitions for geometry
objects so that each one only allows a single value for its type field.

Current dependencies on/for this PR:

main

PR #820

PR #821

PR #822

PR #823

PR #824   👈

This comment was auto-generated by Graphite.


Modify the Installation with CocoaPods

The 'Usage' describes the latest version 6.0.2 and the 'Installation with CocoaPods' installs the version 5.2.0. So, if someone follows the tutor,  the Objc will not connect with javascript. The reason is here https://github.com/marcuswestin/WebViewJavascriptBridge/issues/266#issuecomment-280273386 .
Before your create your PR:
Please add tests for any new or changed functionality!
I have not modified any functionalities for your repo. What I have done is to modifying some infos in README.md.
Thanks.

Cool! I'll take a look at this and report back. Thanks for spotting that.

Thank you!


Update transparent-data-encryption-tde-overview.md

Proposed changes to clarify that TDE is enabled in SQL Managed Instance by default and how existing encrypted databases can be restored

@si-chan : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Thank you @si-chan! I'll approve this.
#sign-off


Fix #74: JasperReports 7.0.1

Fix #74: JasperReports 7.0.1

@gastaldi have all formats working now except PDF since that uses OpenLibrePDF.  That is tomorrow's problem 😄


WIP: Abstraction

The year_vec, month_vec, day_vec, and week_vec have common processes.
We will abstract them so that we can call them by changing only the parameters.
This makes it easy to create a vector representation such as "once every 2 weeks".
However, it may cause breaking changes.

Codecov Report
Base: 100.00% // Head: 100.00% // No change to project coverage :thumbsup:

Coverage data is based on head (ec11e3d) compared to base (5601b25).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff            @@
##              main        #6   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            2         2
  Lines           78        78
=========================================
  Hits            78        78

Flag
Coverage Δ

unittests
100.00% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Output from scripts not printed?

Is output from scripts intentionally not written to the command line?
I might be trying to be too clever. I have a version of Bynens's .osx script that I want to run via shell but allow user input to determine if it should continue because even though it's idempotent, it kills running apps and is excessive to run often. I tried this at the top of the file:
read -p "Run OS X defaults script (Y/n)? " -n 1 -r

if [[ ! $REPLY =~ ^[Y]$ ]]; then
  exit
fi

The script waits for input and correctly receives it, but the message from read is not printed.

Thanks for the feature, that looks great. I will try it out today.
I understand you intended to keep shell commands simple, and I would have seen that as a reasonable response. I was on the fence about requiring interaction to make the .osx run, and the alternative was to not include it in the install command.


Update meteorologist (2.0.4)

Thank you for the contribution. It was merged directly as a1c60e327551b1f87a5c44fac0e8a17bb57570da to keep commit history cleaner. Your contribution is still credited to you.


feat: added madrid livestream link

Displayed the Madrid livestream event on the website banner

/rtm

/rtm


Fix flake8 errors in Python Thrift sample.

I manually tested these on a new GCE instance. Note: The readme claims
the Thrift sample only works on GCE so I did not try to test on my
workstation.

LGTM


Update README.md

Regarding the collections package. In all ProjectManagement.java classes the toString method is included. However, the UML does not report that method in the diagrams. I included them to provide more clarity.

Thanks 👍


Create Loading component

Create a component to show the load state of the page.

@gabrielSeixas Can I do this one as well?

@gabrielSeixas Can I do this one as well?

Okay.

In case @pgsil wants to focus on some other issue. I would like to work on this one.


Temporarily disable the doc tests in the Windows CI

The Windows image in the pool now has a version of protobuf installed that does not work correctly with the rest of the build (it's too high).
To work around the issue, temporarily disable the doc tests.
Signed-off-by: Stella Stamenova<EMAIL_ADDRESS>

Assuming https://github.com/onnx/onnx-mlir/pull/1452 succeeds, this change won't be necessary at this point. Still TBD whether the protobuf change is successful in the online builds though.

#1452 went in, so this is not needed.


Upgrade React

At the moment I'm aware of one regression. You cannot click the links in the popovers that explain the various plugin installers because they close as soon as you stop hovering over the box.
Review @spicyj

I would really love to split this pull request up into smaller pieces, but it looks like each of the various libraries all depend upon having modern versions of each-other. If there is some portion of this can could be extracted into a separate pull request, I would love to be alerted.

Neat! Thanks.


UnhandledPromiseRejectionWarning: Error: Failed to parse changedFields

Hi,
I'm facing issues with the client.js, when is trying to change from HexToBin an error message is launched indicating 'bin.replaceAll is not a function'. I.E: bin = bin.replaceAll("0", "0000");
I'm working with the latest version 2.4.0 available.
Thanks,
Iosu.

Hi @itovarba, I managed to find a fix to the parsing of changed fields. Can you try the latest release v2.4.1?
Let me know if this doesn't address your issue and I can reopen this.

Thanks @pozil, It's working. Also I've been realized that I wasn't working with the latest node version.


The default answer for supabase db reset --linked should not be Y

Is your feature request related to a problem? Please describe.
I used the command supabase db reset --linked for the first time. I was suprised that the default answer is "Yes". In my opinion it should be "No" to at least prevent the reset when I accidently run the command and just pressed "enter".
Describe the solution you'd like
The line 54 in reset.go
if shouldReset := utils.PromptYesNo("Confirm resetting the remote database?", true, os.Stdin); !shouldReset {

sould become
if shouldReset := utils.PromptYesNo("Confirm resetting the remote database?", false, os.Stdin); !shouldReset {

Describe alternatives you've considered
No alternative

I totally agree with this one, destructive actions should never be authorized by default

Any plans to add --force or --yes to this command @sweatybridge? Trying to use it in github action to reset staging every night.

You can pipe yes / no to cli via stdin. For eg.
yes | supabase db reset --linked

We're piping yes now, but it does seem like a command-line arg is the right way.

Is there a better way to roll out breaking changes to core tools?

Perhaps the CLI can print the suggested replacement command on such breaking changes in the future. So at least it's more straightforward to fix any broken builds.
In this case, we had to fix it sooner than later to prevent more users from accidentally deleting prod data.

I made it into a new feature request: https://github.com/supabase/cli/issues/2341