bug feedback

Click to expand!
Issue Type
Bug
Have you reproduced the bug with TF nightly?
Yes
Source
source
Tensorflow Version
tf 2.5
Custom Code
Yes
OS Platform and Distribution
Windows 10 21H2 9044.2604
Mobile device
No response
Python version
3.7
Bazel version
No response
GCC/Compiler version
No response
CUDA/cuDNN version
11.6
GPU model and memory
No response
Current Behaviour?
A bug happened!
Operator MaxPool2D has no output for a long time and doesn't throw any Exception when kernel_size is greater than the height of input_data

Standalone code to reproduce the issue
import tensorflow as tf
import numpy as np

nums = 1
in_channels = 1
out_channels = 3
height = 1
width = 1
kernel_size = 3
stride = 2
pad_mode = 'valid'
tf_data = np.ones([nums, in_channels, height, width], float)
try:
    print(tf.keras.layers.MaxPool2D(pool_size=(kernel_size, kernel_size), strides=stride,
          padding=pad_mode,data_format='channels_first')(tf_data))
except BaseException as e:
    print(e)

Relevant log output
the code is always running without any output or exception

@seems666,
When I was trying to execute the mentioned code on tensorflow v2.11, the code was executed only one time and also the output was generated.

Also tf.keras.layers.MaxPool2D performs the Max pooling operation for 2D spatial data. Kindly find the gist of it here and you are using tensoflow v2.5 which was a bit old. So please try to install tensorflow v2.11 which is the latest stable version.
Thank you!

Got it, thank you very much!

@seems666,
Good to hear that your issue got resolved and thank you for the confirmation. So Could you please feel free to close this issue and If you need any further assistance please feel free to create a new issue. Thank you!


Separate cache for decoded JPEGs

In a lot of our examples we decode JPEGs on the fly. We want a RAM cache for decoded JPEGs, so we can quickly inspect them (e.g. hover to read pixel values). This is completely separate from a VRAM cache of uploaded textures.
Currently the two are combined in the weird ImageCache

Related: #1331


Zig version

Hey greenfork,
Can you list the zig version you are using to build kisa in the README somewhere, please?  I have tried head from today (0.9.0-dev.664+a8e8927c4) and 0.8.0 release but neither builds kisa.
For 0.8.0:
./src/main.zig:714:19: error: no member named 'sendFileToOpen' in struct 'Client'
.
.
.

And for 0.9.0-dev.664+a8e8927c4:
/home/wilsonk/krepyc/kisa/src/main.zig:597:13: error: unused local variable
.
.
.

Hi wilsonk! Yeah, that's a good idea, I updated readme https://github.com/greenfork/kisa#how-to-build. In short it is version 0.8.0 and you probably want to run zig build test. Let me know if you want to know something specific, I will be glad to help, you can hit me on discord or ask right here


fead: add Browser.disconnect method

I was surprised to see that playwright doesn't have this (https://github.com/microsoft/playwright/issues/4956). Looks like we'll have to defer to puppeteer's judgement here.

So it looks like Playwright does have a browser.connect() method, which could address the other part of the attached issue (resource disposal closing the browser instead of disconnecting)


Extensive code docs

Hey @ko1N I find this project very interesting and want to get involved with it. Since this is pretty advanced stuff, I was wondering if you had any suggestions for easy spots to jump in. (Bonus points if you're able to share blog post URLs or impatient-friendly docs on the concepts you're looking to implement.)


Fix outlook issue by changing the service URL

This solves https://github.com/ferdium/ferdium-recipes/issues/8.
We previously had two recipes for outlook (one normal, and another for 365) - does this change affect anything on that?

Also, since we are anyways editing this service recipe, could you please add the "outlook" as an alias in package.json?

I had a chance to try this on my client's outlook (that uses okta for SSO) - but, this change did not have any impact. Once Ferdium is closed and reopened, I was taken back to the okta sign-in page.

Please run pnpm run package - that will fail since the recipe version needs a bump in the corresponding package.json

This didn't fail... But it should, because I didn't upgrade the json version, yes.

Also, since we are anyways editing this service recipe, could you please add the "outlook" as an alias in package.json?
Next commit will have it.

I had a chance to try this on my client's outlook (that uses okta for SSO) - but, this change did not have any impact. Once Ferdium is closed and reopened, I was taken back to the okta sign-in page.
Should we close this PR, given the fact that the issue may be other?

Should we close this PR, given the fact that the issue may be other?

Yes, im not sure if this is a valid change - for the intended goal.
Also, the old url works similarly from my testing. So, I'm not sure about the need for this PR

Closing as per discussion with @SpecialAro


Remove 'using namespace std'

This is an internal code patch we're trying to push upstream, needed because of local differences to std.

ok this should be cleaned up now

Thanks!


Dynamic Links Unity sample not working for iOS

Hello, I was running the dynamic links unity sample for iOS and followed the exact steps written but the dynamic links are not showing up.
Here is my log in the Xcode just after starting the app:
`2018-01-27 16:44:25.027161+0530 arkit[2849:804939] [DYMTLInitPlatform] platform initialization successful
2018-01-27 16:44:25.115873+0530 arkit[2849:804898] -> registered mono modules 0x1013414f0
2018-01-27 16:44:25.296980+0530 arkit[2849:804898] [Accessibility] ****************** Loading GAX Client Bundle ****************
-> applicationDidFinishLaunching()
2018-01-27 16:44:25.492382+0530 arkit[2849:804898] Metal GPU Frame Capture Enabled
2018-01-27 16:44:25.494557+0530 arkit[2849:804898] Metal API Validation Disabled
2018-01-27 16:44:25.576444+0530 arkit[2849:804898] [MC] Lazy loading NSBundle MobileCoreServices.framework
2018-01-27 16:44:25.578067+0530 arkit[2849:804898] [MC] Loaded MobileCoreServices.framework
-> applicationDidBecomeActive()
GfxDevice: creating device client; threaded=1
Initializing Metal device caps: Apple A9 GPU
Initialize engine version: 2017.3.0f3 (a9f86dcd79df)
WARNING: Shader Unsupported: 'Hidden/BlitToDepth' - Pass '' has no vertex shader
WARNING: Shader Unsupported: 'Hidden/BlitToDepth' - Setting to default shader.
WARNING: Shader Unsupported: 'Hidden/BlitToDepth_MSAA' - Pass '' has no vertex shader
WARNING: Shader Unsupported: 'Hidden/BlitToDepth_MSAA' - Setting to default shader.
Main Thread Checker: UI API called on a background thread: -[UIApplication delegate]
PID: 2849, TID: 804944, Thread name: (none), Queue name: NSOperationQueue 0x1c42250e0 (QOS: UNSPECIFIED), QoS: 0
Backtrace:
4   arkit                               0x0000000100825314 UnityCurrentOrientation + 60
5   arkit                               0x0000000100812c28 __UnityCoreMotionStart_block_invoke + 108
6   Foundation                          0x0000000183d35ba0  + 16
7   Foundation                          0x0000000183c75894  + 72
8   Foundation                          0x0000000183c654c4  + 848
9   libdispatch.dylib                   0x0000000182cdea14  + 16
10  libdispatch.dylib                   0x0000000182ce6200  + 288
11  libdispatch.dylib                   0x0000000182cdea14  + 16
12  libdispatch.dylib                   0x0000000182ce6200  + 288
13  libdispatch.dylib                   0x0000000182ce60ac  + 104
14  Foundation                          0x0000000183d37878  + 376
15  libdispatch.dylib                   0x0000000182cdea14  + 16
16  libdispatch.dylib                   0x0000000182ce6f08  + 428
17  libdispatch.dylib                   0x0000000182ce580c  + 604
18  libdispatch.dylib                   0x0000000182cebcf4  + 600
19  libdispatch.dylib                   0x0000000182ceba38  + 120
20  libsystem_pthread.dylib             0x0000000182f8706c _pthread_wqthread + 1268
21  libsystem_pthread.dylib             0x0000000182f86b6c start_wqthread + 4
2018-01-27 16:44:26.064509+0530 arkit[2849:804944] [reports] Main Thread Checker: UI API called on a background thread: -[UIApplication delegate]
PID: 2849, TID: 804944, Thread name: (none), Queue name: NSOperationQueue 0x1c42250e0 (QOS: UNSPECIFIED), QoS: 0
Backtrace:
4   arkit                               0x0000000100825314 UnityCurrentOrientation + 60
5   arkit                               0x0000000100812c28 __UnityCoreMotionStart_block_invoke + 108
6   Foundation                          0x0000000183d35ba0  + 16
7   Foundation                          0x0000000183c75894  + 72
8   Foundation                          0x0000000183c654c4  + 848
9   libdispatch.dylib                   0x0000000182cdea14  + 16
10  libdispatch.dylib                   0x0000000182ce6200  + 288
11  libdispatch.dylib                   0x0000000182cdea14  + 16
12  libdispatch.dylib                   0x0000000182ce6200  + 288
13  libdispatch.dylib                   0x0000000182ce60ac  + 104
14  Foundation                          0x0000000183d37878  + 376
15  libdispatch.dylib                   0x0000000182cdea14  + 16
16  libdispatch.dylib                   0x0000000182ce6f08  + 428
17  libdispatch.dylib                   0x0000000182ce580c  + 604
18  libdispatch.dylib                   0x0000000182cebcf4  + 600
19  libdispatch.dylib                   0x0000000182ceba38  + 120
20  libsystem_pthread.dylib             0x0000000182f8706c _pthread_wqthread + 1268
21  libsystem_pthread.dylib             0x0000000182f86b6c start_wqthread + 4
Setting up 1 worker threads for Enlighten.
Thread -> id: 17096b000 -> priority: 1
UnloadTime: 1.007750 ms
2018-01-27 16:44:28.588321+0530 arkit[2849:805039] TIC Read Status [1:0x0]: 1:57
2018-01-27 16:44:28.588376+0530 arkit[2849:805039] TIC Read Status [1:0x0]: 1:57
2018-01-27 16:44:28.806583+0530 arkit[2849:804943] 4.8.1 - [Firebase/Analytics][I-ACS023007] Firebase Analytics v.40007000 started
2018-01-27 16:44:28.810564+0530 arkit[2849:804943] 4.8.1 - [Firebase/Analytics][I-ACS023008] To enable debug logging set the following application argument: -FIRAnalyticsDebugEnabled (see http://goo.gl/RfcP7r)
2018-01-27 16:44:28.959309+0530 arkit[2849:804945] [MC] System group container for systemgroup.com.apple.configurationprofiles path is /private/var/containers/Shared/SystemGroup/systemgroup.com.apple.configurationprofiles
2018-01-27 16:44:28.961536+0530 arkit[2849:804945] [MC] Reading from public effective user settings.
2018-01-27 16:44:29.121198+0530 arkit[2849:804935] TIC Read Status [4:0x0]: 1:57
2018-01-27 16:44:29.121258+0530 arkit[2849:804935] TIC Read Status [4:0x0]: 1:57
2018-01-27 16:44:31.813750+0530 arkit[2849:804945] TIC TCP Conn Failed [5:0x1c4169d80]: 12:8 Err(-65554)
2018-01-27 16:44:31.814693+0530 arkit[2849:804945] Task <18727D9D-4CCC-4DD3-9342-FFF08C5D06A6>.<2> HTTP load failed (error code: -1003 [12:8])
2018-01-27 16:44:31.815285+0530 arkit[2849:804945] Task <18727D9D-4CCC-4DD3-9342-FFF08C5D06A6>.<2> finished with error - code: -1003
`
**Here is log just after pressing the "Display long link" button: **
`Long dynamic link
UIHandler:DebugLog(String)
UIHandler:CreateAndDisplayLongLink()
UIHandler:GUIDisplayControls()
UIHandler:OnGUI()
(Filename: /Users/builduser/buildslave/unity/build/artifacts/generated/common/runtime/DebugBindings.gen.cpp Line: 51)
`

Wow! Someone else with the same problem. Any solutions yet? It's frustrating.

Hey all,
Sorry for the delay in getting back to you, I haven't had any luck reproducing the problem you are seeing, and nothing in the log really helps indicate the issue.
To help us narrow down what might be happening, what version of Unity are you using?  If you're using 2017 or higher, are you using the experimental .Net 4.6 support?
Something you can try is just prior to the call to FirebaseApp.CheckAndFixDependenciesAsync(), add the following line:
FirebaseApp.LogLevel = LogLevel.Verbose;
This makes it print out more information about what is happening with the initialization of Firebase, and might help pinpoint what is going wrong with that, if anything.
Also, have you tried using any of the other Firebase Unity SDKs?  If you can, trying a simpler one like Analytics would help indicate if it is a problem with Firebase as a whole, or just the Dynamic Links library.

@parthandroid @willartii any additional information on this?

Hi, it’s solved. Thanks :)
On Sat, 17 Feb 2018 at 6:09 AM, Stewart Miles<EMAIL_ADDRESS>wrote:

@parthandroid https://github.com/parthandroid @willartii
https://github.com/willartii any additional information on this?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/firebase/quickstart-unity/issues/133#issuecomment-366398628,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AI2Bafz5Ab4p_2b8K-Xna2h36TaQbgALks5tVh_VgaJpZM4RvQGb
.

@parthandroid anything you can share about what the problem was?  Perhaps we could update our documentation to make something more clear?


Allow to skip url parameter encoding for custom type

Currently, there is no way of using custom characters in URLs like proposed here (using ✓ for true and ✖ for false values). Every value is passed through encodeURIComponent() call here and there is no way to skip it. Custom types should have an ability to skip URL encoding when desired.
This is somehow related to https://github.com/angular-ui/ui-router/issues/1119.

This is implemented with raw types in 1.0.


Inheritance Support

If mocks and injections are repeated, I like to extract it to a base class. This way, I can repeat same dependencies for other tests without having to repeat. For example:
public abstract class ActivityTest {
    @Rule
    public final MyDaggerMockRule daggerMockRule = new MyDaggerMockRule();

    @Mock
    protected DependencyA mockDependencyA;

    @Named("s1")
    protected String s1 = "test_string_s1";

    @Named("s2")
    @InjectFromComponent
    protected String s2;
}

@RunWith(AndroidJUnit4.class)
@LargeTest
public class AnActivityTest extends ActivityTest {

    @Rule
    public ActivityTestRule<AnActivity> activityTestRule =
            new ActivityTestRule<>(AnActivity.class, true, false);

    @Mock
    DependencyB mockDependencyB;

    @Named("s3")
    @InjectFromComponent
    protected String s3;
    ...
}

Is this supposed to work already? I noticed that we get main app dependencies instead of the ones from defined in the test, particularly in the base class.
PS: This library saves me a lot of headache. Thank you.

Hi, it wasn't supposed to work but it's not difficult to add the support. I have already committed the new version, you can try it using the commit 59020907c0 as version in your gradle file.
Thanks for the suggestion!

@fabioCollini It works fine. Thanks for quickly fixing this.

@fabioCollini It works fine for @Mock annotation. I think it doesn't work for @InjectFromComponent annotation. Could you check?

You are right, I added the support for @InjectFromComponent annotated fields in base class in commit fe0c164dad. I'll release a new version soon.
Thanks again for your report

Works fine..


[Feature Request] Add usage example to NPM module description page at https://www.npmjs.com/package/microsoft-adaptivecards

Notes
The microsoft-adaptivecards module on NPM currently has no usage examples demonstrating how to use the module.
User Story
As a developer/user of Bot Framework Node SDK, I would like to be able to learn how to use the microsoft-adaptivecards module by reading a usage example on the NPM module description page.
Acceptance Criteria:
microsoft-adaptivecards description page on NPM contains at least one usage example.

This is updated now


Request for Place Name Gazetteer data fails

Describe the bug
When I go to the webpage for the Place Name Gazetteer dataset, I find a link to the dataset under the 'Resources' heading, marked as media type 'WFS', which I presume is Web Feature Service, which seems to be a protocol for carrying out operations on geographic data over the Web. When I click on this link, I get an XML file back describing an error: 'Could not determine geoserver request from http request org.geoserver.monitor.MonitorServletRequest@2c5b19d'.
Here's the full error:
<ows:ExceptionReport version="2.0.0" xsi:schemaLocation="http://www.opengis.net/ows/1.1 https://geo.spatialhub.scot/geoserver/schemas/ows/1.1.0/owsAll.xsd">
    <ows:Exception exceptionCode="MissingParameterValue" locator="request">
        <ows:ExceptionText>
            Could not determine geoserver request from http request org.geoserver.monitor.MonitorServletRequest@2c5b19d
        </ows:ExceptionText>
    </ows:Exception>
</ows:ExceptionReport>

To Reproduce
Steps to reproduce the behavior:

Go to the webpage for the Place Name Gazetteer dataset
Click on the link to the Place Name Gazetteer data

Expected behavior
Data is returned
Actual behaviour
Error is returned as detailed above
Hardware and software used

Device: Laptop
OS: Windows 10
Browser: Firefox 123.0.1

Hi @jcarstairs-scottlogic. Apologies for the delay in getting to this!
I've checked the license on the original dataset link and it appears that this dataset isn't actually open 😔. This means we probably shouldn't be listing it on opendata.scot.
I'll keep this issue open and have a look at filtering out datasets with this license type. Once I've implemented this the dataset should disappear from any future listings once a new sync is performed on our website.


[Feat]: UI card update

What feature?
You raised this issue

https://github.com/priyankarpal/ProjectsHut/issues/906#issue-1728633753
I wasnt able to comment so I'm writing here.
Im a GSSoc cntributor, please assign me this issue, I will resolve it
Here is my UI/UX profile for your reference if you want to check out my work https://github.com/engorgedspirit/UI-UX
Add screenshots
Add screenshots
Code of Conduct

[x] I agree to follow this project's Code of Conduct

hey @engorgedspirit you don't need to create an issue for this you will see the label status: ready for dev if the issue is ready.
Currently, that issue is not ready.


Reorganization of modules

Clean up and further refactor modules, and how everything is exported.

Replaced by  #52


[Feature Request] Make Update Fulfilment Status easily accessible

It'd be nice to have the Update Fulfilment Status select option more prominent and easily accessible in the Orders page/dashboard.
Scenario: I imagine in a busy online shop say a restaurant where there are many orders coming in, viewing orders and adjusting their status as they go through processing and finally shipping is central to the operation of the store.
Should this feature also be developed as an Addon or it'd be better if Community Store improved the UI/UX to streamline processing orders thereby simplifying the workflow instead of having to open each order individually to change its status.

I agree it's a little hidden towards the bottom of the order page. The challenge is that everyone is processing orders a bit differently, with some not even interested in changing that status - the paid status on the other hand might be more relevant to some.
I'm certainly open to improving the interface though, either through a PR or an example of how it should be.
But this is also a case where a custom built add-on to offer an interface specifically for your use-case might be the way to go. In the EasyPost add-on, I effectively did that - it adds a new dashboard page that lists orders, but with different buttons and info, specifically with the context of managing the shipping of the orders.
The added bonus is that you could use permissions to allow access to only that page by a staff member, if you wanted to stop them from doing other things (like refunding orders).
There's also the API add-on now too, that allows you to externally/programatically fetch order details, and update order statuses, so you could even build something completely outside of the concrete5 site.

I agree it's a little hidden towards the bottom of the order page. The challenge is that everyone is processing orders a bit differently, with some not even interested in changing that status - the paid status on the other hand might be more relevant to some.
I'm certainly open to improving the interface though, either through a PR or an example of how it should be.
But this is also a case where a custom built add-on to offer an interface specifically for your use-case might be the way to go. In the EasyPost add-on, I effectively did that - it adds a new dashboard page that lists orders, but with different buttons and info, specifically with the context of managing the shipping of the orders.
The added bonus is that you could use permissions to allow access to only that page by a staff member, if you wanted to stop them from doing other things (like refunding orders).
There's also the API add-on now too, that allows you to externally/programatically fetch order details, and update order statuses, so you could even build something completely outside of the concrete5 site.

Great! Thanks for the detailed explanation and ideas. I'll explore both the single page dashboard option and the API integration with an external application.
Had looked at video of the EasyPost add-on and it is quite impressive so will have a look at the code for inspiration on how to implement the dashboard page.

Great! Thanks for the detailed explanation and ideas. I'll explore both the single page dashboard option and the API integration with an external application.
Had looked at video of the EasyPost add-on and it is quite impressive so will have a look at the code for inspiration on how to implement the dashboard page.

I agree it's a little hidden towards the bottom of the order page. The challenge is that everyone is processing orders a bit differently, with some not even interested in changing that status - the paid status on the other hand might be more relevant to some.
I'm certainly open to improving the interface though, either through a PR or an example of how it should be.
But this is also a case where a custom built add-on to offer an interface specifically for your use-case might be the way to go. In the EasyPost add-on, I effectively did that - it adds a new dashboard page that lists orders, but with different buttons and info, specifically with the context of managing the shipping of the orders.
The added bonus is that you could use permissions to allow access to only that page by a staff member, if you wanted to stop them from doing other things (like refunding orders).
There's also the API add-on now too, that allows you to externally/programatically fetch order details, and update order statuses, so you could even build something completely outside of the concrete5 site.

Haven't thought this through but this is the idea I had in mind when opening the issue (see attached)

I agree it's a little hidden towards the bottom of the order page. The challenge is that everyone is processing orders a bit differently, with some not even interested in changing that status - the paid status on the other hand might be more relevant to some.
I'm certainly open to improving the interface though, either through a PR or an example of how it should be.
But this is also a case where a custom built add-on to offer an interface specifically for your use-case might be the way to go. In the EasyPost add-on, I effectively did that - it adds a new dashboard page that lists orders, but with different buttons and info, specifically with the context of managing the shipping of the orders.
The added bonus is that you could use permissions to allow access to only that page by a staff member, if you wanted to stop them from doing other things (like refunding orders).
There's also the API add-on now too, that allows you to externally/programatically fetch order details, and update order statuses, so you could even build something completely outside of the concrete5 site.

Haven't thought this through but this is the idea I had in mind when opening the issue (see attached)

That makes a lot of sense to me. There is also the comment field to consider, but perhaps that's not a concern, as someone can still go into the order to set one.
My only hesitation is the potential for orders to be mixed up, since there's not much detail apart from the name and number shown. When you go into the order you at least have the full order details in front of you, extra things to confirm that you're actually changing the status of the correct order.
I'm happy to receive a PR for this - I can add it to my list, but not sure when I'd be able to get to it.

I agree completely there's potential for mixing up the orders when there are so few details to distinguish between orders. Like I said I haven't thought deeply about this but I feel taking an order through the various fulfillment steps is something that could be useful to a lot of stores especially when coupled with the fulfillment notifications add-on for stores that don't have a way of tracking a customer's order - the customer can be easily be updated on the status of their order as it goes through the processing and shipping stages.
Since this status is something that may be changed severally for each individual order there's a need to make it front and center. It doesn't have to be a select option that can be changed directly on the page, a pencil icon next to the status would do. When the icon is clicked it would popup a dialog with the most relevant order details (simplified) and provide a control for changing the status thus allowing one to easily confirm the order, update the status and save upon closing the dialog - this dialog box could also have a provision for setting the comment field.


disable all addons upon reset to have clean uninstall and doesnt hang.

This PR will first disable all addons to cleanly remove addon resources created.
Prevents namespace stuck in terminating phase, when addons are cleanly disabled and removed.

address this issue: https://github.com/ubuntu/microk8s/issues/877

I have to update pip3 in the travis.yaml file pip3 install --upgrade pip, otherwise it kept failing when installing pytest

Ive modified microk8s.disable storage to include destroy-storage args.
If arg is not specified, it will not delete the filesystem.
microk8s.disable storage:destroy-storage

LGTM +1 thank you @balchua


Add exception handler for model server and Add ability to specify custom handler

What this PR does / why we need it:

Handles Model server shutdown properly when exception occured.
Provides a way to add custom exception handler to the event loop

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #3404
Type of changes
Please delete options that are not relevant.

[x] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Feature/Issue validation/testing:
Please describe the tests that you ran to verify your changes and relevant result summary. Provide instructions so it can be reproduced.
Please also list any relevant details for your test configuration.

[x] Test A
Before:

Traceback (most recent call last):
  File "/home/ubuntu/go/src/github.com/kserve/kserve/python/sklearnserver/sklearnserver/__main__.py", line 41, in <module>
    kserve.ModelServer(registered_models=SKLearnModelRepository(args.model_dir), workers=6).start(
  File "/home/ubuntu/go/src/github.com/kserve/kserve/python/kserve/kserve/model_server.py", line 229, in start
    asyncio.run(servers_task())
  File "/usr/lib/python3.10/asyncio/runners.py", line 44, in run
    return loop.run_until_complete(main)
  File "/usr/lib/python3.10/asyncio/base_events.py", line 646, in run_until_complete
    return future.result()
  File "/home/ubuntu/go/src/github.com/kserve/kserve/python/kserve/kserve/model_server.py", line 227, in servers_task
    await asyncio.gather(*servers)
  File "/home/ubuntu/go/src/github.com/kserve/kserve/python/kserve/kserve/model_server.py", line 214, in serve
    raise RuntimeError("Some Exception")
RuntimeError: Some Exception
Exception ignored in: <function Server.__del__ at 0x7f90add16170>
Traceback (most recent call last):
  File "/home/ubuntu/go/src/github.com/kserve/kserve/.venv/lib/python3.10/site-packages/grpc/aio/_server.py", line 185, in __del__
  File "src/python/grpcio/grpc/_cython/_cygrpc/aio/common.pyx.pxi", line 118, in grpc._cython.cygrpc.schedule_coro_threadsafe
  File "src/python/grpcio/grpc/_cython/_cygrpc/aio/common.pyx.pxi", line 110, in grpc._cython.cygrpc.schedule_coro_threadsafe
  File "/usr/lib/python3.10/asyncio/base_events.py", line 436, in create_task
  File "/usr/lib/python3.10/asyncio/base_events.py", line 515, in _check_closed
RuntimeError: Event loop is closed
sys:1: RuntimeWarning: coroutine 'AioServer.shutdown' was never awaited

After:
Traceback (most recent call last):
  File "/home/ubuntu/go/src/github.com/kserve/kserve/python/sklearnserver/sklearnserver/__main__.py", line 41, in <module>
    kserve.ModelServer(registered_models=SKLearnModelRepository(args.model_dir), workers=6).start(
  File "/home/ubuntu/go/src/github.com/kserve/kserve/python/kserve/kserve/model_server.py", line 224, in start
    asyncio.run(servers_task())
  File "/usr/lib/python3.10/asyncio/runners.py", line 44, in run
    return loop.run_until_complete(main)
  File "/usr/lib/python3.10/asyncio/base_events.py", line 646, in run_until_complete
    return future.result()
  File "/home/ubuntu/go/src/github.com/kserve/kserve/python/kserve/kserve/model_server.py", line 222, in servers_task
    await asyncio.gather(*servers)
  File "/home/ubuntu/go/src/github.com/kserve/kserve/python/kserve/kserve/model_server.py", line 209, in serve
    raise RuntimeError("Some Exception")
RuntimeError: Some Exception

Logs

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Checklist:

[ ] Have you added unit/e2e tests that prove your fix is effective or that this feature works?
[ ] Has code been commented, particularly in hard-to-understand areas?
[ ] Have you made corresponding changes to the documentation?

Release note:

Add exception handler for model server and Add ability to specify custom exception handler

@sivanantha321 : Possible to get a unit test case around this feature to test that custom exception handler is indeed getting added ?

@sivanantha321 : Possible to get a unit test case around this feature to test that custom exception handler is indeed getting added ?

I tried. But I am not able to get it to work.


Maybe unsound in ExtBytecode

hello, thank you for your contribution in this project, I am scanning the unsoundness problem in rust project.
I notice the following code:
pub struct ExtBytecode {
    pub base: Bytecode,
    pub instruction_pointer: *const u8,
}

impl Jumps for ExtBytecode {
   ..............................

    #[inline]
    fn opcode(&self) -> u8 {
        // SAFETY: `instruction_pointer` always point to bytecode.
        unsafe { *self.instruction_pointer }
    }
    ......................................
}

Considering that instruction_pointer is a pub field, I assume that users can directly manipulate this field. This potential situation could result in self.instruction_pointer being a null pointer, and directly dereferencing it might trigger undefined behavior (UB). For safety reasons, I felt it necessary to report this issue. If you have performed checks elsewhere that ensure this is safe, please don’t take offense at my raising this issue.
here is my Poc:
extern crate revm_interpreter;
extern crate revm_bytecode;

use std::ptr;
use revm_interpreter::{interpreter::ExtBytecode, interpreter_types::Jumps};
use revm_bytecode::Bytecode;

fn main() {
    let base_bytecode = Bytecode::default();

    let mut ext_bytecode = ExtBytecode::new(base_bytecode);

    let invalid_ptr:*const u8=ptr::null();
    ext_bytecode.instruction_pointer=invalid_ptr;

    ext_bytecode.opcode();
}

output:
PS E:\Github\lwz> cargo run
   Compiling lwz v0.1.0 (E:\Github\lwz)
    Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.59s
     Running `target\debug\lwz.exe`
error: process didn't exit successfully: `target\debug\lwz.exe` (exit code: 0xc0000005, STATUS_ACCESS_VIOLATION)

If there is no external using for ExtBytecode, maybe it should not be marked as pub, at least for its field should not be mark as pub.

This is a good point!


[Android] Allow non-ascii header values & add utf-8 filename fallback

Summary
Fix https://github.com/facebook/react-native/issues/31537: [Android] React Native strips non-ASCII characters from HTTP headers
Changelog

[Android] [Changed] - Allow non-ascii header values on Android and add utf-8 filename fallback in FormData
Test Plan

Clone the react-native repo.
Build the rn-tester app.
Prepare tests

Add android:usesCleartextTraffic="true" to AndroidManifest.xml
Use the following code as a server: const http = require('http');

 const requestListener = function (req, res) {
     // raw header value
     console.log(req.headers['content-disposition']);
     // nodejs assumes the header value is ISO-8859-1 encoded
     console.log(Buffer.from(req.headers['content-disposition'], 'latin1').toString('utf-8'));
     // decode encoded header value if it's sent as UTF-8
     console.log(decodeURI(req.headers['content-disposition']));
     res.writeHead(200);
     res.end();
 };

 const server = http.createServer(requestListener);
 server.listen(3000);

Run adb reverse tcp:3000 tcp:3000 to connect the 3000 port on the emulator if necessary.

Edit RNTesterAppShared.js to include test code:  useEffect(() => {
    fetch('http://localhost:3000/', {
      headers: {
        'Content-Type': 'multipart/form-data; charset=utf-8',
        'Content-Disposition': `attachment; filename*=utf-8''${encodeURI(
          'filename测试abc.jpg',
        )}`,
      },
    }).then(res => {
      console.log(res.ok);
    });
    fetch('http://localhost:3000/', {
      headers: {
        'Content-Type': 'multipart/form-data; charset=utf-8',
        'Content-Disposition': `attachment; filename="filename测试abc.jpg"`,
      },
    }).then(res => {
      console.log(res.ok);
    });
  }, []);

Both requests should succeed; without the fix, the second request received by the server will not have the utf-8 characters "测试" in the header value.

Hi @robertying, Thank you for doing this.
The filtering has been introduced by @dryganets in this PR https://github.com/facebook/react-native/pull/21231 4 years ago.
We are wondering whether this change could break some webservers that don’t understand the utf8- marker. @dryganets, could you help out with the review?

@cipolleschi Thanks for taking a look. The detail was discussed in this issue https://github.com/facebook/react-native/issues/31537 when I first opened it:

As I investigate, I find lines of code that should be responsible ebc89bf/ReactAndroid/src/main/java/com/facebook/react/modules/network/HeaderUtil.java.
These methods are to weaken okhttp's too strict rules on headers, but also bring this unwanted behavior.
FYI, okhttp has supported non-ASCII headers from https://github.com/square/okhttp/pull/4296.
These two stripping methods may need to be looked into and synced with the upstream to reflect okhttp's changes.
This change was brought by https://github.com/facebook/react-native/pull/21231 in response to the issue https://github.com/square/okhttp/issues/2802. The issue has been discussed in another one https://github.com/square/okhttp/issues/3876, which was fixed by https://github.com/square/okhttp/pull/4296.

As for whether it will break web servers, this usage is actually included in RFC 5987:

This specification suggests that a
parameter using the extended syntax takes precedence.  This would
allow producers to use both formats without breaking recipients that
do not understand the extended syntax yet.
Example:
 foo: bar; title="EURO exchange rates";
           title*=utf-8''%e2%82%ac%20exchange%20rates

There is also a note:

Note: at the time of this writing, many implementations failed to
ignore the form they do not understand, or prioritize the ASCII
form although the extended syntax was present.

The RFC was written in 2010 and I believe utf-8 support on the server side should be adequate now; and even if the server doesn't understand the extended syntax, it should be able to pick up the original filename as it used to.

@cipolleschi it seems we could move forward since Sergei has commented. Please let me know if there's anything else that needs addressing!

@robertying Sorry for the delay, busy days.
Can I ask two favours, first:

Could you go to https://app.circleci.com and log into their website? This should restart the CI pipelines. I know it is annoying, I'm working with them so that we can automate this step
Could you rebase onto main?

After that, when the CI is green, I can reimport it!
Thank you so much and sorry again for the delay.

@cipolleschi No problem! Appreciate the work you've been doing. I fixed some issue and all checks have passed.

Want to bump this PR.
@cipolleschi @cortinico would you mind importing this again to see how it behaves in internal builds?
The fix passed all external checks but the internal ones, making it impossible for me to find the problem myself.
This utf-8 fix, however, is important to developers in lots of non-English speaking countries and I wish it could be handled soon.
Thank you!

@cipolleschi would you mind importing the diff again? Want to see if there's any internal update that might have solved the linter issue. Thank you!

Hi @robertying, sorry for the long silence. We were discussing this feature internally and, while we are looking to try and understand what needs to be done to make it work, we were exploring alternatives.
Do you think would it be possible to make this feature an opt-in? 🤔
So, for example, if we switch a flag in the gradle.properties people can start using this feature.
How do you feel about that? This would make much easier to land this as we will be preserving the base default behavior (and internal system won't break) but supporting the use case presented here.

Hi @robertying, sorry for the long silence. We were discussing this feature internally and, while we are looking to try and understand what needs to be done to make it work, we were exploring alternatives.
Do you think would it be possible to make this feature an opt-in? 🤔
So, for example, if we switch a flag in the gradle.properties people can start using this feature.
How do you feel about that? This would make much easier to land this as we will be preserving the base default behavior (and internal system won't break) but supporting the use case presented here.

Thanks for writing this @cipolleschi. I agree this is the best approach for now before internal tests catch up.
I can try coming up with an improved fix. Cheers.

Since the usage of the new okhttp's method is inside React Native's network module, I can't think of a way for the downstream (apps that use RN) to simply change a flag to make it work.
Downstream either needs to switch to another build artifact (aar), or compile RN from source.
Do you have any suggestion as to how to achieve this in an easier way?

I'd compile from source.
The alternative is to replace the module with your's implementation.

If compiling from source, would it be better for people who need this feature to build from source themselves and consume artifacts?
If we add a flag and somehow switch to compiling from source when the flag is enabled, it requires the same if not more work to adopt this change than a custom build.

So, I investigated internally a bit and making it build from source is not a possibility.
Another approach we can take could be to use reflection: if the headersBuilder has the addUnsafeNonAscii we use it, otherwise, we fall back to the old behavior.
How do you feel about that. It would be maybe simpler to implement.

@cipolleschi great idea! I've updated the code. Can you try importing it to see how it goes internally?

@cipolleschi I don't see any changes you requested. Did you mean to have dedicated functions to check?
Also, I'm not sure how internal tests are still failing. 😅 I tested all these GitHub checks with a lower version of okhttp v3.11.0 and they all passed.

My bad, I probably closed the page before submitting the suggestions... 🤦
I added the comment now. We should cache what we can to avoid expensive operation. There could be potential multi-threading issues, so it could make sense to synchronize access on the new variables... But I'll first try this out.

@cipolleschi I see what you mean. In the meantime, can you check the linter error that was reported internally?

@robertying, there are some internal tests failing, but these are snapshot tests because we changed the layout of HTTP, so they will be easy to fix for me as soon as we have a final version of the diff.
If you can:

rebase and solve conflicts (we are making react-native a proper monorepo, so we moved a bunch of files. Now react-native Core codebase resides in react-native/packages/react-native. You can read more here)
add caching

I can fix the tests and try to land it.
Thank you so much for your patience.

@cipolleschi woohoo! All tests passed.
I used the static constructor to initialize the reflected method. Let me know if you think this is okay.

/rebase

I used the static constructor to initialize the reflected method. Let me know if you think this is okay.

Hello! Changes looks good to me, I'm not a Java expert really, but I think it make sense and it could work!

@cipolleschi Thanks! Also, usually the bot should have committed the code by now. Could you take a look  when you have time?

We are trying to understand if we can actually merge this. There could be performance implications in using reflection and the situation with OkHTTP is blocking other team internally, so we are trying to understand the best path forward.
I'm sorry if this is taking so long to merge. :(

We are trying to understand if we can actually merge this. There could be performance implications in using reflection and the situation with OkHTTP is blocking other team internally, so we are trying to understand the best path forward.
I'm sorry that this is taking so long to merge. :(

No worries. Please keep me posted.

@robertying sorry for the delay.
I'm looking into understanding how to handle the OkHTTP version internally so we can merge this. Just to set expectations, I don't believe we'll be able to merge this in the near future. I'll keep on investigating and get back to you once we have a plan forward.

@robertying sorry for the delay, but we were finally able to ship this change.

@robertying sorry for the delay, but we were finally able to ship this change.

@cortinico no worries! Appreciate that you revisited this change and had it merged!
Does this mean there's still an old okhttp version somewhere internal and we have to use reflections as a workaround?

Does this mean there's still an old okhttp version somewhere internal and we have to use reflections as a workaround?

Nope we were able to update the internal usages to OkHTTP 3.12.x

Ah I see! I just realized the commit imported was the original one without the reflection workaround, not the current changes listed in this PR. All good now. 👍


pull request for e2e test at 12/30/2016 17:15:12

:white_check_mark: Validation status: passed
For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


[Feature Request] MultiDiscreteTensorSpec in DQN

Currently, DQN modules and losses want to know
 action_space (str, optional): The action space to be considered.
            Must be one of
            ``"one-hot"``, ``"mult_one_hot"``, ``"binary"`` or ``"categorical"``.

We need to add multi categorical to this (MultiDiscreteTensorSpec) and make it work in the modules and losses.
Plus, would it be possible to drop this argument and infer it from the action spec?
It seems redundant to me that I need to feed my DQN loss both the spec and a string which repeats a part of the spec

This choice is aimed at making the loss usable without requiring any other class from the lib.
If we want to infer it from the policy which contains spec, we're asking the user to:

use the policy from torchrl
in turn use the spec from torchrl
in turn use the env from torchrl

That goes against the "adopt one component and not all" principle we any to achieve.
But we could accept a spec and a string in these classes though

could this be optional and if not present we attempt to look at the spec?

The question is also how do you fetch it when using a regular TensorDictSequential (not SafeSequential) which has no concept of action-spec.
I guess an informative error message like "you must either pass a spec, a string or a policy with a spec" could help...

Let's keep in mind that the use case we want to support is also DQLoss(nn.Module)
As long as this can be used without needing to learn anything about TensorDict I'm ok with whichever option.
Some time in the future I will do a tutorial "DQN (or else) without TensorDict" I think it'd be fun!

Yea something like that.
When you do not have the needed parameter, you try to find it as hard as you can and if in the end you do not find it you tell the user that error

So users of torch rl can avoid to use those parameters and external users just need to give them


ARROW-8951: [C++] Fix compiler warnings on gcc8 in release builds

constexpr seems to have done the trick

constexpr didn't work on older gcc so I moved the conversion table to time.cc. We shouldn't be hitting this conversion table on any performance sensitive code paths

+1

Isn't it used when casting between timestamp units?

The table is accessed outside of the conversion loop and then the parameters are passed to the ShiftTime function


Assets generation script

This is the assets gen transition script that'll create assets.json file for a given language's service directory or deeper (some Java libraries have their own pipelines and this will generate the json files for those as well).

I think this is super solid. Suggest renaming file to generate-assets-json.ps1 or transition-to-asset-sync.ps1 or the like, but I won't block on a rename.

Renamed to generate-assets-json.ps1 as per your suggestion.


Add aerospace shape design example to dqcp examples section

Python notebook developed with Akshay to highlight constrained minimization of a quasilinear objective function for an aerospace shape design example.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Thanks @dberkens! It'll be up on the website soon.


Support for encrypted unload?

Redshift has the option of doing an encrypted unload operation. Is that something that is on your roadmap, and if not, do you have a rough idea of how much work would be involved?
Edit: I've been looking into the code. I don't have much experience in scala, but it seems Parameters.scala would need to change to parse/validate the encryption parameter. Also, RedshiftRelation would need to know how to buildUnloadStmt with the encrypted parameter. Then there'd be a step missing before Conversions.scala which would actually decrypt the data before it can be converted, is this correct?
Overall, is this something that would be easily doable, or would it require significant refactoring?

It looks like you have a pretty good summary of the changes that would be necessary.

Then there'd be a step missing before Conversions.scala which would actually decrypt the data before it can be converted, is this correct?

Yep, I think this would be the tricky part. There are instructions on using this type of encryption directly with the AWS S3 SDK (see also https://aws.amazon.com/blogs/aws/client-side-data-encryption-using-the-aws-sdk-for-java/) but I don't think that's going to work when we're interacting with S3 via the Hadoop S3A or S3N filesystems.
I think this would work when using EMRFS to access S3, though: https://aws.amazon.com/about-aws/whats-new/2015/03/amazon-emr-support-for-amazon-s3-client-side-encryption-now-available/
So, in summary, I think this would take a bit of work.

Thank you for the quick reply. I'll find a workaround for now. Great job with the package BTW, this greatly simplifies interaction between redshift and spark.

Actually, I did think of one good workaround: given that our read path starts with a list of S3 file paths (read from a manifest (which isn't encrypted)), you could modify the actual S3 reading path to use the Amazon client rather than going through the Hadoop APIs. Here's the relevant part of the code: https://github.com/databricks/spark-redshift/blob/cba5eee1ab79ae8f0fa9e668373a54d2b5babf6b/src/main/scala/com/databricks/spark/redshift/RedshiftRelation.scala#L149
What you could do is to do something like sc.parallelize(filesToRead, filesToRead.length) and then use a mapPartitions call to create an AmazonS3EncryptionClient, read the file, decrypt the bytes, and pass them to the input format code (which you could extract and decouple from the Hadoop interfaces). Presumably the encrypted files aren't splittable by Hadoop anyways, so the fact that you'd be losing any benefits of FileInputFormat splitting (not sure if we're actually taking advantage of that, though).
This is a little complicated but I'm pretty sure that it would work.

Hi Josh,
I used S3N File system to write back data to S3. With the below configuration, I am able to use Spark Redshift encryption thus ensuring Encryption at Rest.
sc._jsc.hadoopConfiguration().set("fs.s3n.awsAccessKeyId", aws_access_key_id)
sc._jsc.hadoopConfiguration().set(
"fs.s3n.awsSecretAccessKey", aws_secret_access_key)
sc._jsc.hadoopConfiguration().set("fs.s3n.server-side-encryption-algorithm", "AES256")

Hi Josh,
Could you help me understand on how to ensure encryption in transit ?

I'm in the process of writing a README update for this. Here's my notes on the current encryption support:

Securing JDBC: The Redshift and Postgres JDBC drivers both support SSL. To enable SSL support,
first configure Java to add the required certificates by following the
Using SSL and Server Certificates in Java
instructions in the Redshift documentation. Then, follow the instructions in
JDBC Driver Configuration Options to add the appropriate SSL options
to the JDBC url that you use with this library.

Encrypting UNLOAD data stored in S3 (data stored when reading from Redshift): According to the Redshift documentation
on Unloading Data to S3,
"UNLOAD automatically encrypts data files using Amazon S3 server-side encryption (SSE-S3)."
Redshift also supports client-side encryption with a custom key
(see: Unloading Encrypted Data Files)
but this library currently lacks the capability to specify the required symmetric key.

Encrypting COPY data stored in S3 (data stored when writing to Redshift):
According to the Redshift documentation on
Loading Encrypted Data Files from Amazon S3:

You can use the COPY command to load data files that were uploaded to Amazon S3 using
server-side encryption with AWS-managed encryption keys (SSE-S3 or SSE-KMS), client-side
encryption, or both. COPY does not support Amazon S3 server-side encryption with a customer-supplied key (SSE-C)

To use this capability, you should configure your Hadoop S3 FileSystem to use encryption by
setting the appropriate configuration properties (which will vary depending on whether you
are using s3a, s3n, EMRFS, etc.).
Note that the MANIFEST file (a list of all files written) will not be encrypted.


feat: add Book entity and BookService

not yet fleshed out. can we discuss and keep working on this?

yep. I think having getBooks and addBook is enough for this PR. Everything else will be added whenever we need in future PR.


Add function to enable/disable shadows in Scene

Original report (archived issue) by Ian Chen (Bitbucket: Ian Chen, GitHub: iche033).

@iche033 do you remember the context for this issue?

I think it's referring to having an API like in classic for enabling / disabling all shadows: https://github.com/gazebosim/gazebo-classic/blob/391c4f2ca43b16cba0f9119e5d302fa697f2615c/gazebo/rendering/Scene.hh#L407


How can I use grunt-uncss with an AngularJS application?

I'm just having problems to use grunt-uncss with an AngularJS application. To don't repeat myself, I've posted an answer in the SO:
http://stackoverflow.com/questions/26638782/how-can-i-use-grunt-uncss-with-an-angularjs-application?noredirect=1#comment41884839_26638782
I'll appreciate any help.
Bernardo Pacheco

I know it's been quite some time since you posted this question - was the SO answer able to help at all?

Same here, I tried using both options.urls and passing in array of urls into files, but neither seem to actually be seeing a rendered version of the app because it is cutting out all nested/specific styles of directive templates that are added at runtime. I would love to see an example of this working on a large angular app that has alot of directives.

We use Uncss on our large Angular apps and it works fine, AFTER you add all of the Angular specific and dynamic styles to the ignore sheet. Once a week, though, we forget adn someoen has to add a new style or wildcard to the ignore.

Please ask upstream for more help.


Honour mandatory digest on private key in has_usable_cert() (1.1.1 backport of PR#7408)

Stop TLS from using digests that the EVP_PKEY tells us it doesn't support.
And stop the EC keys from lying about what they support, while we're at it.
Fixes #7348

Merged to 1.1.1:

abaa2311ad Stop marking default digest for EC keys as mandatory
6aca8d1a5f Honour mandatory digest on private key in has_usable_cert()

Thanks @dwmw2 !


fix server not initialized

@James-Sangalli great spotting! It has to set the server both before and after validation though. Have added a commit. If that looks good, feel free to rebase and merge.


Running SML in Galileo or Edison: Add introduction text

Task Description
Page: https://github.com/solettaproject/soletta/wiki/Running-SML-in-Galileo-or-Edison
Add an introductory text where we talk about why we have special steps for Galileo and Edison and briefly talk about the steps we are going to take to be able to run SML on those platforms.
Dependencies
None

done


move apiserver generation to script and verify

resolves #1193
fairly straightforward movement and conversion to a script.
remember to chmod +x your scripts so they are executable and runnable!

@MHBauer Can you help clear up for me something that I am missing in my understanding of how this is supposed to work? Let's say that someone makes a change to a types file and submits a PR without running the code generation. My understanding is that the desired behavior is that make verify will recognize that the generated file in the source tree does not match what the generated file should be given the changes to the types file. However, the verify target in the makefile depends on the .generate_files target. The .generate_files target re-creates the generated files if there are changes to the types file. Won't this cause the CI to always pass the verification even when the submitter neglected to generate the new files?


Ghostscript_Tiger.svg is not rendered properly on macOS

On iMac with Radeon GPU, the image rendered from cli is blocky with sketchy outlines. Line and Circle drawing is fine. Seems like the bezier path rendering is not functioning with MoltenVK (latest 1.2.154 Vulkan SDK).

That's interesting. Can you post a screenshot and repro steps for how to run it with MoltenVK? At this point, it could be just about anything - something I'm doing wrong in my code that just happens to work on NV+AMD+Intel, a mistranslation of the shader code into MSL (actually one of my top guesses), a bug in MoltenVK, etc. I think it would be useful to track it down.
Also, the more we're going to be running this on actual hardware, the more we need testing infrastructure to validate that the various pipeline stages are doing what they are supposed to. I have done a bit of this by hand (see the various mostly unused "dump" functions in cli.rs) but automation is most definitely possible.

The repro steps are straight building and running the cli test after installing latest vulkan sdk on Mac. The image.png shows

Will post any any findings as soon as I could pick up more coding details. : )

I tried it on my mac (MBP 13", running 10.15.5, Intel HD 640), and I didn't get any image, though the collatz example does work and I get meaningful validation reports when I fiddle with the code. One question - does #44 work any better? I did fix a bug in backdrops there.
Also, are you getting meaningful timestamp reports? All 0.000ms here.

One question - does #44 work any better? I did fix a bug in backdrops there.

Is that related to issue #23? I can't seem to find any backdrop changes in your #44, except for the right_edge removal. However, right_edge tracking was already dead code.

Yes, the missing indirection on the element index. I can see how that happened, the variable naming is very confusing. As I'm working on the code after being away from it for several months, I can see a number of ways code clarity can be improved.

9c0bdd664d21967282ed066c8208099ba7fa2524 started the rendering issues on macOS. The subgroup was enabled in the change. And looks like a translator issue in MoltenVK.

The blank image on intel GPU is one of the issue. Reproed on my Mac Mini 2018.

The reported issue on the blocky tiger svg rendering started from 9a8854, and it was good at 8d01aba23.

Thanks for looking into it, but those bisection results aren't super helpful, as 9a8854 is a pretty serious rewrite based on sort-middle, and I now consider the version before that to be something of a dead end.
I think tracking this down will require some fairly serious detective work, and a good step in that direction would be to add tests of individual stages, so we can at least track down which one of those is failing.

Close the issue with much design changes since the first report.
With ref to https://github.com/linebender/piet-gpu/pull/138: Beginnings of new element pipeline, the native metal backend support is now working and rendering the tiger.svg nicely. The original report was based on testing results from Vulkan port through MoltenVK. Though, it may be interesting to check whether Vulkan/MoltenVK works, that will be a separate topic.

Yes, it's valid to close, though #138 hasn't been merged yet (maybe I should just do that).
I'm also curious whether MoltenVK works, but just out of idle curiosity, I have no active plans to maintain that. I do suspect that shader translation issues / atomics are the main problems, though.


Prototype FTP Like Design

I think this is superceded by #7 if in relation to metadisk-gui, otherwise it seems like this would go with another project that is a demo application or reference for integrating with the metadisk-api


Add support for customizing progress bar rendering at method level

Change log

Adds an optional progress parameter to all methods that support rendering progress bars that allows for customizing progress bar rendering at the method level, overriding the default global fo.config.show_progress_bars setting
Adds support for passing a callback function via the progress parameter rather than rendering the builtin progress bar (see below for example usages)

Example usage
Explicit progress control
import fiftyone as fo
import fiftyone.zoo as foz

print(fo.config.show_progress_bars)  # True

# Don't render progress bars, despite global config default
dataset = foz.load_zoo_dataset("quickstart", progress=False)
dataset.compute_metadata(progress=False)

Custom progress callbacks
import fiftyone as fo
import fiftyone.zoo as foz

def print_progress(pb):
    if pb.complete:
        print("COMPLETE")
    else:
        print("PROGRESS: %0.3f" % pb.progress)

dataset = foz.load_zoo_dataset("cifar10", split="test")

# Print progress at 10 equally-spaced increments
progress = fo.report_progress(print_progress, n=10)
dataset.compute_metadata(progress=progress)

# Print progress every 0.5 seconds
progress = fo.report_progress(print_progress, dt=0.5)
dataset.compute_metadata(progress=progress, overwrite=True)

Usage in delegated operations

Merged into release/v0.23.3 instead in https://github.com/voxel51/fiftyone/pull/3979.


Do not reset index when setting metadata

I just noticed a problem when setting epochs.metadata. When I create an Epochs object with the default reject_by_annotation=True behavior, bad epochs will be dropped. This includes rows from the metadata, but notice that the index still reflects the original epochs numbering.
For example, let's say we only have 6 epochs in total, and epochs 1 and 3 are bad and therefore dropped. This leaves epochs 0, 2, 4, and 5. However, certain operations like mne.channels.combine_channels() seem to set the metadata again (this is something that I fixed recently, previously the metadata attribute would be dropped completely). This means that the index is reset, and in our example would be 0, 1, 2, and 3, because https://github.com/mne-tools/mne-python/blob/main/mne/utils/mixin.py#L405 sets reset_index=True, which in turn is used in https://github.com/mne-tools/mne-python/blob/main/mne/utils/mixin.py#L369.
I don't know if this affects other functions in addition to mne.channels.combine_channels(), so I wanted to ask how you would recommend fixing this. I assume this behavior is not intended, right? I don't quite understand why the index is always reset, is it because we always want to make a copy? If so, there are two options: (1) we can use df.copy() (maybe even df.copy(deep=True)), and (2) we don't automatically copy and leave it to the user to do the right thing.
I kind of tend to prefer (2), because without looking at the source it is basically impossible to figure out that epochs.metadata = df creates a copy (and currently resets the index), which is probably not what the user wants (and expects).
Thoughts?

Issue: #4823
PR: #4827
Not sure what to make of this. I'm not manually dropping rows, it's the Epochs initializer that does it, so the warning not to do that does not apply. So I'm not sure if the suggestion from #4823 has been implemented or not, and if so if and why it doesn't work here (maybe because there's no epochs.selection).


Cache mitigation (#47273)

Backport for https://github.com/rancher/rancher/issues/47981
Direct cherry-pick of the upstream fix

Closed in favour of https://github.com/rancher/rancher/pull/47967#pullrequestreview-2424895843


Pre-trained model & Inference

Where can I get the BERT pre-trained model that you used as you stated in your paper. I think you are referring to standard BERT trained by google research but I want to make sure. Also you haven't talked about inference in README, after training how can I do inference? Also where is that supplementary materials that you talked about in your thesis.
Thanks in advance

Yes，your guess is right. Actually [BERT,BASE].
And the inference method is like what we done in eval function. Check this part: f1_metric.
What we actually done is to construct entity-mask M for all possible entity-pairs, and calculate the average score on it and use threshold to decide if a certain relation exists or not.
What's more, leave those supplementary alone, they are all about the parameters, which are already inside this code as default values.


Add guidance about the width classes you should apply to specific text inputs like postcode

What is the context of this PR?

Updated content and added more detail about making inputs the appropriate width.
Changed input widths on postcodes to match max width of UK postcodes
Changed durations and dates macros to use the new number type width class

How to review

Check input component docs
Check durations and dates

 Issue #278: Add guidance about the width classes you should apply to specific text inputs like postcode


Automate global time series plots

Automate global time series plots. Resolves #26.

@golaz This is ready for review. I copied the output to https://web.lcrc.anl.gov/public/e3sm/diagnostic_output/ac.forsyth2/E3SM/v2/beta/2021_05_06_coupled_v2_test01.png.
I added the following section to the config file:
[global_time_series]
active = True
years = "1-100",
ts_num_years = 10
figstr=coupled_v2_test01
web_dir=/lcrc/group/e3sm/public_html/diagnostic_output/ac.forsyth2/E3SM/v2/beta/20210122.v2_test01.piControl.ne30pg2_EC30to60E2r2-1900_ICG.chrysalis
moc_file=mocTimeSeries_0001-0100.nc
experiment_name=20210122.v2_test01.piControl.chrysalis
ts_years = "1-50", "1-100",
climo_years ="21-50", "51-100",


can you benchmark this one?

function repeat(length, s){
  length = Math.max(0, length); //normalize
  return (new Array(length + 1)).join(s);
}

This module doesn't matter anymore as we now have the native String#repeat().


specify scope of system.leftline

The guidelines say about @system.leftline on <scoreDef>:

Indicates whether the staves are joined at the left by a continuous line. The default value is "true".

To me it's not completely clear what should happen to one-staff systems.
Normally single staves do not have a starting bar line, yet the default value is "true". If this attribute only applies to multi-staff systems, a single staff never could be drawn with a line at the beginning of the system.
We should drop the un-MEI-ish default value and better say

Indicates whether the system starts with a continuous line connecting all staves.

agreed

Agree aswell,
Maybe we should indicate that this also includes the case of a single-staff system?

On 27. Feb 2020, at 09:13, kepper<EMAIL_ADDRESS>wrote:
agreed
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/music-encoding/music-encoding/issues/649?email_source=notifications\u0026email_token=AASRLQNYLLSRZ54UTZNRET3RE5Y2HA5CNFSM4K4WAANKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOENDMBJA#issuecomment-591839396", "url": "https://github.com/music-encoding/music-encoding/issues/649?email_source=notifications\u0026email_token=AASRLQNYLLSRZ54UTZNRET3RE5Y2HA5CNFSM4K4WAANKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOENDMBJA#issuecomment-591839396", "name": "View Issue" }, "description": "View this Issue on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]


Recent changes in AutoGPT broke

https://github.com/Significant-Gravitas/Auto-GPT/pull/2982 removed autogpt.path_in_workspace, breaking attachments, as those make use of this

Thanks, I will take a look at this

Thanks again for the issue. https://github.com/riensen/Auto-GPT-Email-Plugin/commit/22f6e50a410ab3947fd44a59dc9cc904bbfb22b9 should address this.


Revert "include $CI_PIPELINE_ID in s3 cp filter"

Reverts DataDog/datadog-agent#23896
only dev pipelines include the pipeline ID in the MSI name.
https://datadoghq.atlassian.net/browse/WINA-703
https://datadoghq.atlassian.net/browse/CIREL-1970

/merge


feat: recursively searches for a Rukefile

Closes #16
Implementation
This solution only uses Rust standard library, powered by Ancestors, which is used to create an iterator that calls PathBuf::parent on each subsequent Iterator::next call.

Hey @kauefraga, I think that --file flag is still useful given bash scripts could use this to initialize Ruke on another's project Rukefile. What your thoughts, should we remove?

Nice point! I think we should keep it


signed binaries

Hi,
By chance, do you provide digital signed binaries (dlls) or do you plane to provide them in the futur?

I don't believe that we have any plans to provide signed binaries.
What platform(s) are you interested in?

We're mainly interested for windows dlls but also MacOS and Linux (not sure they support signed library).

I think that would have to be supported by the build system (b2)[https://www.bfgroup.xyz/b2/], on which I'm not an expert, but I don't think is there.
That said, the windows binary installers do get checksums applied to them before they are uploaded to the internet and those checksum files are signed with my GPG key. For example, this file for the 1.82 release.

We don't currently ship binaries for any platforms other than windows.


translations for {nick,chan,host}serv don't get loaded

It looks like right now, we manually load the irc strings and the help strings, but no others:
https://github.com/oragono/oragono/blob/93c17e6b980a3bc9a62880ab7dca6a119b93dd98/irc/config.go#L702
Let's systematize this a bit and move it into irc/languages instead of adding more clauses to irc/config.go.

https://github.com/oragono/oragono/blob/234d011c297cbe5f38ee987d86401f638d92b87b/irc/help.go#L687
This is a data race that we should fix while we're in the neighborhood.

There are some inconsistencies in the naming of language codes. In particular, ja_JP is spelled with an underscore where other language-country locales have a hyphen:
https://github.com/oragono/oragono/blob/234d011c297cbe5f38ee987d86401f638d92b87b/languages/ja-JP.lang.yaml#L3
Also, right now we can support exactly one of ro and ro-RO; it would be preferable if ro-RO were an alias for ro.

Current behavior is to send RPL_WHOISLANGUAGE with parameter en when the client has not explicitly negotiated languages:
:oragono.test 690 client target en :can speak these languages
Is this right?

Yeah I think this is correct, at least right now. We'll see whether anything more happens with the spec going forward


Values in "Additional Info Field" Can't Be Added to Contact fields that are Numeric Type

The 5 "Additional Info" fields are all Long Text Area type that are 1000 characters long.   However when we try to map the values in these fields to Contact records that have numeric values (such as HS Grad Year or Recruitment Year) using the new Custom Metadata mapping it is not possible to do this, as Long Text Area values are not able to be added to numeric type fields.
Possible solutions:

Create a "shadow" field of numeric type on Summit Events Registration object for each of the 5  "Additional Info" fields, and have the SummitEventsContactMatching trigger populate this field with values early in the running of that trigger so we have numeric values we can work with.

Add a "numeric field" checkbox for each of the 5 Additional Info fields on Summit Events object so the user can designate that they will be using numeric values in this field, and then have the SummitEventsContactMatching trigger use this to directly write values from this field to the Contact record.

Create a new "Additional Info" field that has numeric type and ask users to put their numeric questions in this field, this will allow us to map data from this field directly to numeric fields on Contact records in Salesforce.

This functionality was delivered by creating a "shadow" field of numeric type on Summit Events Registration object for each of the 5 "Additional Info" fields, and having the SummitEventsContactMatching trigger populate this field with values early in the running of that trigger so we have numeric values we can work with.


Support for adding additional items to release

Description
When generating a "release" (whether it be gitlab, github, or wherever), it would be nice to support uploading additional files to the release. Right now, it seems like only dist is supported (and that isn't fully cross platform based on #230)
Use cases
The immediate use case I have in mind is for building an internal tool and publishing the documentation alongside the versioned artifacts.
Possible implementation
All cloud source control systems have some concept of a "release" these days. Implementation will be hvcs specific.

As a workaround you can modify build_command to add your files to the dist folder; however I think this would cause the additional files to also be uploaded to PyPI.


Remove devtome from receiver.h and net.cpp

devtome.com seems abandoned and unmaintained. We should removed to mitigate the risk of failed blockchain syncs.

This is what I plan to do:
diff --git a/src/net.cpp b/src/net.cpp
index 5df25cf..ad58e86 100644
--- a/src/net.cpp
+++ b/src/net.cpp
@@ -1189,7 +1189,6 @@ void MapPort(bool)
 static const char *strMainNetDNSSeed[][14] = {
        {"public.txn.co.in", "dvc.public.txn.co.in"},
        {"21stcenturymoneytalk.org", "dvc-seed.21stcenturymoneytalk.org"},
-       {"devtome.com", "dvcstable01.devtome.com"},
        {"dvcnode.org", "dvcstable01.dvcnode.org"},
        {"dvcnode.org", "dvcstable02.dvcnode.org"},
        {"dvcnode.org", "dvcstable03.dvcnode.org"},
diff --git a/src/receiver.h b/src/receiver.h
index cce9bcd..0188611 100644
--- a/src/receiver.h
+++ b/src/receiver.h
@@ -585,7 +585,6 @@ string getStepText(const string& dataDirectory, const string& fileName, int heig
                        peerText += string("http://galaxies.mygamesonline.org/receiver.csv\n");
                        peerText += string("http://devcoinpool.btc-music.com/receiver/receiver.csv\n");
                        peerText += string("http://devcoinblockexplorer.info/receiver/receiver.csv\n");
-                       peerText += string("http://devtome.com/files/receiver.csv\n");
                        peerText += string("http://devcoin.darkgamex.ch/receiver.csv\n");
                        peerText += string("_endpeers\n");
                        stepText = getCommonOutputByText(peerText, string("0"));

11 days of silence. Good enough!
See: https://github.com/coinzen/devcoin/commit/456d56774d3b2d87ff25d5cec8df2f1a309124a1


Improve documentation for Lint/ShadowedException

After #10861 I figured we can improve the documentation for Lint/ShadowedException.

Before submitting the PR make sure the following are checked:

[x] The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
[x] Wrote good commit messages.
[ ] Commit message starts with [Fix #issue-number] (if the related issue exists).
[x] Feature branch is up-to-date with master (if not - rebase it).
[x] Squashed related commits together.
[ ] Added tests.
[x] Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
[ ] Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

Thanks!


Not working on dockerized app

Describe the bug
I have dockerized app on mac os. I did not buy it I'm just trying to if it fits my needs. When I try to use the app with tinker
`>>> ray("test");
=> Spatie\LaravelRay\Ray {#3506
+settings: Spatie\Ray\Settings\Settings {#173},
+uuid: "2986da46-a516-4b14-832a-745cdf10a272",
}

`
The ray apps captures nothing. I also created ray.php for docker config.
Versions
spatie/laravel-ray                 1.7.1   Easily debug Laravel apps
spatie/ray                         1.11.0  Debug with Ray to fix problems faster
PHP version:
PHP 8
Laravel version:
Laravel 8.22.1
.

Did you try any of the Docker hints in our docs?

Did you try any of the Docker hints in our docs?

I have docker v19.03.1,  so I can not add
    extra_hosts: # <-- this is required       - "host.docker.internal:host-gateway" # <-- this is required

I have docker v19.03.1,  so I can not add
    extra_hosts: # <-- this is required       - "host.docker.internal:host-gateway" # <-- this is required

Can you upgrade to the latest version of Docker?

Can you upgrade to the latest version of Docker?

I'm using docker-compose for it but it throws an error:
invalid IP address in add-host: "host-gateway"

I'm using docker-compose for it but it throws an error:
invalid IP address in add-host: "host-gateway"

I hope other docker users here can give you a hint on how to get it working

I hope other docker users here can give you a hint on how to get it working

I did everything on your document but there is a problem with the document I guess. I was thinking to buy it but there should be proper support for it if you are selling something.
"Other docker users" is not proper support.

I did everything on your document but there is a problem with the document I guess. I was thinking to buy it but there should be proper support for it if you are selling something.
"Other docker users" is not proper support.

Ok, closing this for now. I'm pretty sure the problem lies with configuration at your end.
Should you find a solution, let me know and I'll document it to help others.

Ok, closing this for now. I'm pretty sure the problem lies with configuration at your end.
Should you find a solution, let me know and I'll document it to help others.

I dont think you should sell this product because of lack of support. Since you closed the issue I dont think anyone will look at it.
Anyway hope you find a way to solve this support issue. Till then, I cant see any way to use this product for development and i wont recommend to anyone.

I dont think you should sell this product because of lack of support. Since you closed the issue I dont think anyone will look at it.
Anyway hope you find a way to solve this support issue. Till then, I cant see any way to use this product for development and i wont recommend to anyone.

I just upgraded docker engine and everything working fine with:
RAY_HOST=host.docker.internal
RAY_PORT=23517
Thanks

I just upgraded docker engine and everything working fine with:
RAY_HOST=host.docker.internal
RAY_PORT=23517
Thanks

In your docker compose file are you defining ports for your container? I needed to add the RAY_PORT (default 23517) to the definitions, e.g.
...
ports:
      - 23517
...


Move plugin outside of the nopCommerce solution

Change references to nopCommerce projects
Set build output directory to point into nopCommerce solution

Fixed


switch from legacy cmscloud to aldryn-snake

cmscloud.template_api was baked into the legacy v1 and v2 baseprojects. aldryn-snake is the publicly available version.

:+1:


Use build-args for dynamic docker build

Update the Dockerfiles to use build args for tool version and checksum value.
Opening this PR for feedback on the repo as a whole.
@mjdavies - here's some Docker for you to have fun with :-)

Good spot, the docs should have said build. I acutally think listing the docker compose commands are confusing given I'm using a makefile, so I have removed them.
Once the containers are built (using make all) you can run them like any other container. In each of the Dockerfiles (in the header) I have provided an example docker run ... for testing. Does that help?
Would there be any benefit writing a make test command?

I can run them like so
docker run -it onsdigital/jenkins-slave-sbt:0.13.13 /bin/bash
That starts them up ok, is that good enough?
Be good to document that though if it is

Ah, just spotted the examples :-)
Agreed on removing the docker-compose examples, if anyone wants to do that they can jump in and do it themselves.
All looks good to me Sion, I'll review and merge now.

Sorry, replying too speedily.
"Would there be any benefit writing a make test command?"
If we're going to be changing these builds, or adding builds, it probably does make sense to have a single command to run a test that all the containers build ok.
It would at least prove that any edited/uploaded code actually worked.
Think what Nigel would do!!


Use rustc_target for function call ABI compatibility check

@eddyb suggests to use something in https://doc.rust-lang.org/nightly/nightly-rustc/rustc_target/abi/call/index.html instead of https://github.com/rust-lang/rust/blob/c610be92e2925ab8e789efc835c88247e46c6cbf/src/librustc_mir/interpret/terminator/mod.rs#L191.
IRC log:
<eddyb> RalfJ: yeah you can basically emulate ABIs!
<eddyb> RalfJ: the PassMode variant must always match. direct (including pairs) must have the same layout primitive, cast must use the same register "shape", and indirect has no requirements
<eddyb> RalfJ: for direct I doubt you can have anything other than scalars, scalar pairs and vectors, and for at least the first two you can just reuse the miri value and change the type
<eddyb> RalfJ: for cast & indirect, you basically need to do a memcpy/union type-cast
<eddyb> if you want you can check that the size matches *but that's not actually required* (in terms of things working, that is)
<eddyb> RalfJ: especially if we'll get virtual calls with by-value self, it's gonna be indirect on both sides but one of the sides might only know the zero-sized unsized `dyn Trait` type, whereas the other has the full type
<eddyb> RalfJ: now this is still somewhat imprecise

Unfortunately I have no idea yet what all of that means. ;)

@eddyb has dropped some more hints at https://botbot.me/mozilla/rustc/2018-07-14/?msg=102084910&page=1

One annoyance is that there's some code stuck in rustc_codegen_llvm::abi that belongs somewhere in rustc::ty - I think rustc::ty::layout should be renamed to rustc::ty::abi and reexport + extend all of rustc_target::abi, but @irinagpopa has a WIP codegen PR I want to wait for first.
But once you have a FnType, you can just look at arguments/returns pairwise, and compare their PassModes for compatibility, instead of making assumptions based on type/layout.
This will even work across different extern "ABI"s! As long as the calling convention matches, that is.

So you're saying I can ignore the sig.abi at that point and just compare the arguments? Nice!

@eddyb So how do I go from FnSig to FnType?
Also, I likely still have to look at sig.abi for the RustCall ABI, right? I will never understand why closures are so complex, vs. just being desugared to dyn Fn{,Mut,Once}...

I will never understand why closures are so complex, vs. just being desugared to dyn Fn{,Mut,Once}...

Well, they're not dyn for performance reasons. And the hacks are in lieu of VG (variadic generics).

So how do I go from FnSig to FnType?

I'd start by grepping for FnType::. Ping me on IRC or Discord if you want more details.

Details seem to be https://github.com/rust-lang/rust/blob/63d66494aff57411bfec1dd2a3a5f1af900feab6/src/librustc_codegen_llvm/abi.rs#L363-L379
(I'd like them here so I know where to look if I need them again)

This code has been overhauled by https://github.com/rust-lang/rust/pull/53779 and is mostly sane now.


adding Postman collection of sample UMAPI calls  - fixes #58

This is fantastic and I think we should plan to get it merged.
One question - will this work with the Postman environment you can download from the developer console? When I installed your collection I couldn't figure out a way to merge them automatically. I just copied and pasted the stuff from the environment.

I do not know if you can merge between global environment variables and local collection variables.
Thing is, I embedded the "obtain access token" call from Developer Portal, but because the pre-request script was referencing the global variables, I modified the script to look for local collection variables  instead (pm.collectionVariables vs pm.environment) so that I could export the collection with collection variables. Also, I added the UMAPI_ prefix as well, just to be more clear on the purpose it is used for.

This is great! I was looking right now for exactly that collection - and initially did not find it.
Some Slack messages later, I was here.
Definitely a commit to be added!!

Thanks @lesavage ! That is super helpful! :)


Stricter left-to-right evaluation order

One of the nice things about Python is the predictable evaluation order of subexpressions. In a pure functional language without side effects, this is not much of an issue. Python is not that. Any expression could have an effect, and the order might matter. The Hissp compiler also relies on this fact.
Macros can rewrite expressions in any order they please. Some schools of thought hold that expressions should be used in the macro in the same order written. (Other don't care, perhaps because e.g., Scheme doesn't guarantee evaluation order in most cases.) This might not be feasible in all cases but should be doable most of the time. I apparently haven't been doing this consistently.  As I've moved examples around in the docs, I noticed cases where evaluation order might be surprising. I might want to fix that. I noticed this in the expansion for set! and realized it could be widespread, and thought I'd better write it down.
Off the top of my head, I can think of two options that would usually work. One is to take in the arguments in the most natural usage order. The other is to use them in argument order in a let, and then use the locals in whatever order is natural. This probably has negligible overhead in cases when I'm expanding to a let anyway, which is often. I'm not sure which is preferable. It might be a case-by-case judgement.

I wonder if I should also point this out in the docs somewhere, perhaps as part of a set of guidelines for writing macros well. On the other hand, if people tend to use Hissp in a pure functional style (doesn't really seem to be the case so far), then this doesn't really matter.

One case I've notice this being an issue is in -> and -<>> when writing ^#. It's currently implemented in terms of stack pops, which are mutations, and they occur in the reverse of the order written due to the way threading works. I feel like these should at least have a prominent warning.


lnrpc: return meaningful response instead of empty one

Change Description
Replaces https://github.com/lightningnetwork/lnd/pull/7476.
Fixes https://github.com/lightningnetwork/lnd/issues/7440.
An empty response looks confusing to new users on the command line, since it just prints:
{
}

Instead we return at least a "Status" field that contains a message about what happened.

Thanks for the reviews and sorry for the rookie CI mistakes. Should all be fixed now but will wait with re-requesting review until CI is green.


Want to add Contributing Guidelines file to the repo.

I have designed several guides and I saw the contributing guidelines is missing in your repo. If the project is for open source, it should definitely have a Contributing-Guidelines.md file.

Thanks!!!!!!!!!!!!!!!!


Add support for Throwable

When running PHPStan and Psalm on my projects and libraries, they complain that "You cannot catch a Psr\Cache\CacheException because it is not a Throwable".
This PR fixes that and keeps compatibility with PHP 5.
This is NOT a BC break since the intention of the interface has been clear in the doc block.

Exception interface for all exceptions thrown by an Implementing Library.

We can release this in a minor release if we wanted to.

Now that PHP 8 is out, we're going to release a v2 and v3 to add type hints anyway.  We can modify those to extend Throwable without touching the old PHP 5 version.  That's a cleaner approach than a conditional definition.

I agree with @Crell; that should be done following the bylaw: https://www.php-fig.org/bylaws/psr-evolution/

Secreataries: Please close this PR.

Thank you for the feedback. Im looking forward to the updates.


Wayland: implement touch events

The implementation was actually pretty straightforward.
Tested on my laptop (which has a touchscreen) with weston.

CI passes, nobody seems to have anything to say against it, I'll merge.


⚠ Samsung has degraded performance

In d04e859, Samsung (https://samsung.com) experienced degraded performance:

HTTP code: 200
Response time: 2499 ms

Resolved: Samsung performance has improved in c29ca95.


Correction for raw affiliation Department of Mechanics, Mechatronics and Commands, Moulay Ismail University, 15290 ENSAM،, Meknès 50500, Meknes, Fes-Meknes, 50000, MOROCCO

Correction needed for raw affiliation Department of Mechanics, Mechatronics and Commands, Moulay Ismail University, 15290 ENSAM،, Meknès 50500, Meknes, Fes-Meknes, 50000, MOROCCO
raw_affiliation_name: Department of Mechanics, Mechatronics and Commands, Moulay Ismail University, 15290 ENSAM،, Meknès 50500, Meknes, Fes-Meknes, 50000, MOROCCO
new_rors:
previous_rors: 018pp1107
works_examples: W4387823882
contact: 78358910bd907b3ee870c2a751eb7c9a:f410633a8fad38f6f3315899de @ ensam.eu

This issue was accepted and ingested by the OpenAlex team on 2024-10-09. The new affiliations should be visible within the next 7 days.


Dependency on sbt-dependency-graph may be hurting newcomers

Doing sbt update after cloning caused a weird stack trace, with this in its core:
[error] java.lang.NoClassDefFoundError: net/virtualvoid/sbt/graph/Plugin$

The reason seems to be, I have installed sbt-dependency-graph plugin system-wide, and it's having a version clash with the project's (newer) version.
I love sbt-dependency-graph. However, my practice has become, not to place it in project plugins unless it's actually used by the project in some way. I have installed it like this:
$ more ~/.sbt/0.13/plugins/plugins.sbt
// Note: 0.8.2 was giving problems, using earlier 0.7.5. AKa020316
//
// <<
// /Users/akauppi/.sbt/0.13/global.sbt:1: error: object Plugin is not a member of package net.virtualvoid.sbt.graph
// net.virtualvoid.sbt.graph.Plugin.graphSettings
// <<
//
addSbtPlugin("net.virtual-void" % "sbt-dependency-graph" % "0.7.5")

Hmm... Your project is having the newer 0.8.2 that hasn't worked for me, it seems.
Anyways, I commented out the lines in project/plugins.sbt and can now play with the project. :) Thanks for it!

Hi, glad you can use it and thanks for the heads up! 😀😀

Same error with 0.7.5:
[warn] There may be incompatibilities among your library dependencies.
[warn] Here are some of the libraries that were evicted:
[warn] 	* net.virtual-void:sbt-dependency-graph:0.7.5 -> 0.8.2
[warn] Run 'evicted' to see detailed eviction warnings
/Users/vasily/Code/halo-scala/build.sbt:19: error: object Plugin is not a member of package net.virtualvoid.sbt.graph
net.virtualvoid.sbt.graph.Plugin.graphSettings
                          ^
[error] Type error in expression

@vasily802 did you figure out how to resolve the above error?


rust-analyzer not attached to buffer on windows

Hi there, thanks for the plugin. I found the bug that rust lsp cannot load. If I do a fresh reinstall using :MasonInstall rust-analyzer, it can be loaded immediately. If I quit nvim and reopen the project, it will not load.
Another workaround is to do a manual setup of rust-analyzer using require('lsp-config').rust_analyzer.setup() and remove rust from lsp-setup.nvim.
Open the main.rs in the project, rust lsp cannot load.

Reinstall rust-analyzer using mason, lsp can be loaded.

Seems that using lsp-setup, the cmd for rust lsp is not correct.

Can you provide a reproducible minimal configuration?

Sure. https://github.com/TisnKu/rust-lsp-setup-repro

If I do a fresh reinstall using :MasonInstall rust-analyzer, it can be loaded immediately. If I quit nvim and reopen the project, it will not load.

It seems that mason doesn't install rust-analyzer automatically, or the installation fails.
You need to check if rust-analyzer is installed successfully. The following two commands may help you:

:Mason
:MasonLog

Sure. https://github.com/TisnKu/rust-lsp-setup-repro Plugins are in init.lua and lsp configs are in https://github.com/TisnKu/rust-lsp-setup-repro/blob/304929bb9a657e3af4688c5a13d406792429fb6d/after/plugin/lsp.lua.

I am not sure if we need to specify bundle_path

It is installed, just not attached to the buffer. Bundle_path is my random trial to fix the bug, the bug is the same with or without it.

Can you delete the rust-analyzer and restart neovim? Then check if mason will automatically install rust-analyzer.

BTW, on my mac, the same configuration works.

I did some tests for other lsps as well, taplo and rust-analyzer have the same issue,  tsserver and jsonls does not.

Sorry, I can't see that this is a problem with lsp-setup, lsp-setup just wraps mason, as you said, it is working on mac.

If I replace lsp-setup with require('lspconfig').rust_analyzer.setup {}, it works. Maybe it's a problem of mason-lspconfig

After some testing, I found that with only mason-lspconfig, it still works. So I modified the code of lsp-setup just like the example of mason-lspconfig, and it works:

It's kind of weird why order matters on windows.

I opened an issue for mason-lspconfig and owner confirmed that setup should be placed before setup_handler. Do you mind fixing it or accept PR?

I opened an issue for mason-lspconfig and owner confirmed that setup should be placed before setup_handler. Do you mind fixing it or accept PR?

Thanks, PRs are doubly welcome!


MetroUI Sidebar + Datatable = brokensidebar

On pages containing Sidebar and Dataflex table, after the datatable is reloaded with data,  the document height of page is incremented, but  the sidebar keeps using the original height value.

@olton  Hi, i have the same issue, check the screenshot bellow please :

How we can fix this CSS issue, please ?
Thx for your help :)

link to example please

I solved my problem doing the following code changes:
Original code with problem:

Code working:

@jeanblu Thx for this code, works great !


Error: ETIMEDOUT

Hey man, tks for sharing your project!
I have a problem to solve when I run npm start:
Error: ETIMEDOUT
at Timeout._onTimeout (C:\Users\victo\OneDrive\Documentos\Projects\triangle_arb\binance-triangle-arbitrage-master\node_modules\request\request.js:849:19)
at ontimeout (timers.js:436:11)
at tryOnTimeout (timers.js:300:5)
at listOnTimeout (timers.js:263:5)
at Timer.processTimers (timers.js:223:10)
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR<EMAIL_ADDRESS>start: node src/main/Main.js
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>start script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
I already update node and npm, reinstalled the project, but the issue persists.
node v11.15.0
npm v6.10.3
{
"KEYS": {
    "API": ****
    "SECRET": ****
},

"INVESTMENT": {
    "BASE": "BTC",
    "MIN": 0.0012,
    "MAX": 0.0020,
    "STEP": 0.0001
},

"TRADING": {
    "ENABLED": true,
    "EXECUTION_STRATEGY": "linear",
    "EXECUTION_TEMPLATE": ["BUY", "SELL", "BUY"],
    "EXECUTION_CAP": 0,
    "TAKER_FEE": 0.00,
    "PROFIT_THRESHOLD": 0.30,
    "AGE_THRESHOLD": 300,
    "WHITELIST": []
},

"HUD": {
    "ENABLED": true,
    "ARB_COUNT": 5
},

"LOG": {
    "LEVEL": "info",
    "PRETTY_PRINT": true
},

"DEPTH": {
    "SIZE": 50,
    "PRUNE": false,
    "INITIALIZATION_INTERVAL": 100
},

"CALCULATION_COOLDOWN": 250

}
Can you help me? Tks again!

Glad you appreciate the project!
If you wouldn't mind, let's discuss this in #77 as that is the same root issue


[Autocomplete] Fix blurOnSelect consistency for keyboard

[x] I have followed (at least) the PR section of the contributing guide.

Closes #20137
This PR allows blurOnSelect to work when using keyboard input. Prior to this PR, the popup would close, but the input field would not blur.

@alexbarkin Thanks, I was wondering about adding a new test case, but I believe the logic is simple enough not to require it.


MNMG - Initial Feature Branch

This PR will merge the initial changes required for MNMG into a feature branch to help track completion on the large list of issues required for MNMG.
This PR contains:

The initial NodeJS based control plane
Refactoring of resources
Creation of C++ components to match the Control Plane State
Startup/shutdown of resources using AsyncService

Closes #336
Closes #338

Merging without CI since this is a feature branch


BUG: only one handler is being called

If you register several handlers (not strictly the same) only the first defined is being called:
app.update.ts:
import { On, Start, Update } from 'nestjs-telegraf';
import { Context } from 'telegraf';

@Update()
export class MessageHandler {

  @Start()
  async start(ctx: Context) {
    await ctx.reply('start');
  }

  @On('message')
  async handler1(ctx: Context) {
    await ctx.reply('handler 1');
  }

  @On('message')
  async handler2(ctx: Context) {
    await ctx.reply('handler 2');
  }
}

Result:

I would expect that all these matching handlers will be called. Is it designed to behave like this? E.g.:
usr> /start
bot> start
bot> handler 1
bot> handler 2

Is it somehow related to https://github.com/bukhalo/nestjs-telegraf/pull/309 / https://github.com/bukhalo/nestjs-telegraf/pull/310?

@bukhalo could you please take a look at this one? I can update the docs after getting an answer is needed.


Fix capitalization of GitHub in docs header

Github → GitHub

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at<EMAIL_ADDRESS>Thanks!

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

Thanks