 What did you expect to happen?
Database prefix is not applied to the migrations table. If you want to customize the migrations table name, you should modify the migrations key on your app's ./config/database.php file.
https://github.com/laravel/laravel/blob/7216fa7e9a797227f303630d937a0722878b753b/config/database.php#L98-L109
Next time use more polite wording and try adding a better description of what is wrong and justify why do you think something is a bug. This is free software and a great part of the contributions are made by volunteers on their free time, be respectful.

In hasTable prefix is not needed and in create already there?
This is not a solution to the problem, it needs to dynamically change the prefix (multi tenant single database)

// $this->prefix == '123_'
DB::setTablePrefix($this->prefix);
$schema = DB::getSchemaBuilder();
$prefix = DB::getTablePrefix();
$schema->hasTable('migrations'); // Reality check is '123_migrations'
            $schema->create($prefix . 'migrations', function ($table) {  // create '123_migrations'
                $table->increments('id');
                $table->string('migration');
                $table->integer('batch');
            });

Why do you want a separate migration table for each prefix?
if you are storing all tables into the same database, won’t a single migration table suffice for you use case?
The migration will be aware of all tables with each prefix and you won’t have to manage changing the migration table name each time you want to run a new migration.
If you believe this is something that is justified to be added in the franework, send a PR proposing the change, or open a discussion thread to gather other opinions.
Current behavior is by design and therefore not a bug. Your use case is a feature request and not a bug report.

Hi there,
Thanks for reporting but it looks like this is a question which can be asked on a support channel. Please only use this issue tracker for reporting bugs with the library itself. If you have a question on how to use functionality provided by this repo you can try one of the following channels:

Laracasts Forums
Laravel.io Forums
StackOverflow
Discord
Larachat
IRC

However, this issue will not be locked and everyone is still free to discuss solutions to your problem!
Thanks.

@rodrigopedra Thanks for the explanation here, you are right about the migration as one table, although laravel probably does not have this correct function completely, so give another example:
    public function handle()
    {
        DB::setTablePrefix('test_');
        Artisan::call('migrate');
    }

This returns an error:
SQLSTATE[42S01]: Base table or view already exists: 1050 Table 'migrations' already exists (SQL: create table `migrations` (`id` int unsigned not null auto_increment primary key, `migration` varchar(191) not null, `batch` int not null) default character set utf8mb4 collate 'utf8mb4_unicode_ci')

@MrTomek
<?php

use Illuminate\Support\Facades\Artisan;
use Illuminate\Support\Facades\Config;
use Illuminate\Support\Facades\DB;

Artisan::command('local:test', function () {
    Artisan::call('db:wipe');

    $this->info('Migrating first');
    Config::set('database.connections.mysql.prefix', 'first_');
    DB::purge(); // recreate connection to apply new prefix
    Artisan::call('migrate');

    $this->info('Migrating second');
    Config::set('database.connections.mysql.prefix', 'second_');
    DB::purge(); // recreate connection to apply new prefix
    Artisan::call('migrate');
});


How to make auto complete address?

Hi. Is there any way to make auto complete address?

Have you tried this?

Thank for your reply. I still got error with Libraries method.
I use Jmelosegui.Mvc.Googlemap.<IP_ADDRESS>.
Thank you for you help.
On Fri, Mar 3, 2017 at 10:07 PM, Juan Manuel Elosegui <
<EMAIL_ADDRESS>wrote:

Closed #137 https://github.com/jmelosegui/GooglemapMvc/issues/137.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/jmelosegui/GooglemapMvc/issues/137#event-985520719,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ATo4_FyjX55wshuagQirvVNC9ikp0kCCks5riCyggaJpZM4MQd1k
.

please follow this instructions to get a version containing that feature.

Thank you again for your help. Could you help check this souce code?
MvcWithGoogelMap.rar
https://drive.google.com/file/d/0B2R9KbgqPdBHMFd4V3ZpMXZDRGc/view?usp=drive_web

On Wed, Mar 15, 2017 at 5:33 AM, Juan Manuel Elosegui <
<EMAIL_ADDRESS>wrote:

please follow this
https://github.com/jmelosegui/GooglemapMvc#self-service-releases
instructions to get a version containing that feature.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/jmelosegui/GooglemapMvc/issues/137#issuecomment-286582444,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ATo4_LCIZDrssT7TYCHcv869nNbvjidcks5rlxWygaJpZM4MQd1k
.


feat: suspense guard in data and error getters

Alternative to #168
Fixes #5
This PR isolates the suspense guarding into a function, which is then called in the data and error getters returned from useSWR.
This allows you to write your suspense useSWRs like this to avoid waterfalls;
function App () {
  const user = useSWR('/api/user')
  const movies = useSWR('/api/movies')

  return (

      Hi {user.data.name}, we have {movies.data.length} movies on the list.

  )
}

// OR

function App () {
  const userRequest = useSWR('/api/user')
  const moviesRequest = useSWR('/api/movies')
  const user = userRequest.data
  const movies = moviesRequest.data

  return (

      Hi {user.name}, we have {movies.length} movies on the list.

  )
}

This also allows for dependency fetching
const user = useSWR('/api/user')
const posts = useSWR('/api/posts')
// Accessing .data will throw during key evaluation, letting swr know it's not ready
const movies = useSWR(() => '/api/movies?id=' + user.data.id)

And it would also (mostly) be backwards compatible, since most usage uses deconstruction which will automatically call the data and/or error getters, preserving earlier functionality.
I believe this is a much cleaner interface than the other ones proposed. I've yet to test this completely, so it's mostly a proposal for now, feedback needed 😄

So even something like obj.data === undefined would trigger suspense?
We'd have to be very careful in cases where we don't want to suspend the page while it's fetching, IMO it seems less ergonomic than .read().

Suspense would still need to be explicitly enabled in the options. This PR only changes when it's thrown, if the option is enabled.

Ah I didn't notice that suspense: true is still needed (it's missing in the opening comment).
I think I'd still prefer .read():

the suspense setting wouldn't be needed anymore
.data type would still be T | undefined
.read() type would always be T

In our codebase we wrap swr in custom hooks like this example:
interface MyData {
  readonly id: number;
}

const key = 'key';

function useData() {
  return useSWR<MyData>(key);
}

function useDataWithSuspense() {
  const { data, ...rest } = useSWR<MyData>(key, { suspense: true });
  return { data: data!, ...rest };
}

function useDataMaybeWithSuspense(suspense = true) {
  return useSWR<MyData>(key, { suspense });
}

Because the suspense setting doesn't change the return type we always have to add type assertions when using suspense: true.
In case when suspense is controlled by the component like in useDataMaybeWithSuspense we have to be more careful about types.
A solution like .read() would be much more ergonomic for us, we'd only need the useData() above without having to worry about types.
Just my 2 cents.

Yep, I agree having a read function returned would be more explicit and probably self-documenting. I wanted to explore this option as the properties returned from useSWR already are getter functions, and would be a minimal change to a much-needed feature.
You could technically do pattern matching with the types
type SWRSuspenseHook<T> = (suspense: true) => { data: T }
type SWRNormalHook<T> = (suspense?: false) => { data?: T }

type SWRHook<T> = SWRSuspenseHook<T> | SWRNormalHook<T>

but good luck doing that with the complex types of the existing SWRHook type 😄


[RFC] container_lxc: handle xattrs

Signed-off-by: Christian Brauner<EMAIL_ADDRESS>

We'll also need a test for this I suspect as that's the kind of thing which may regress/break without anyone noticing for a long time :)


Ambiguous rules for 64-bit driver on Windows 10 with Secure Boot enabled

Hello,
This page is ambiguous about the signing requirements in a particular use-case: installing a 64-bit driver on Windows 10 with Secure Boot enabled. At the top of the page, we see this:
"Starting with new installations of Windows 10, version 1607, Windows will not load any new kernel mode drivers which are not signed by the Dev Portal."
but with the exception that:
"Cross-signed drivers are still permitted if any of the following are true:

...
Secure Boot is off."

But in the section titled "Signing a driver for earlier versions of Windows", we see a table that says when Secure Boot is enabled, a 64-bit driver must have a WHQL signature, which requires passing HLK/HCK tests.
It's not clear if this table only applies to Windows 7 and 8 — or to Windows 7, 8, and 10. If the former, then installing a 64-bit driver on Windows 10 with Secure Boot enabled requires attestation-signing the driver. If the latter, then installing a 64-bit driver on Windows 10 with Secure Boot enabled requires a WHQL signature. These are very different requirements.
Thanks for your attention to this!
Fran Litterio

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 1eb19d33-8f4c-f379-b645-938a746c5615
Version Independent ID: 8efb9fb4-1e9a-1a8a-994b-450495449e15
Content: Driver Signing Policy
Content Source: windows-driver-docs-pr/install/kernel-mode-code-signing-policy--windows-vista-and-later-.md
Service: unspecified
GitHub Login: @tedhudek
Microsoft Alias: windowsdriverdev

FYI, see this thread on this issue on the NTDEV mailing list. Peter Viscarola states that the table is in error when it says that a WHQL signature is required for a 64-bit driver on Windows 8.1 with Secure Boot enabled.
Fran Litterio

I have some updates for this that I will be adding soon.  Thanks @fpl9000 for bringing it to our attention.  Look for an update in the next couple days.

Note that @timrprobocom opened #451 to update the docs for this one.  Will update this issue once we get that one all set

Thanks, Ted. I would defer to @timrprobocom's input on this topic. He is a regular contributor to the NTDEV mailing list (operated by OSR). I'm just a programmer in the trenches trying to understand this stuff.

Hi @fpl9000 sorry but I apparently didn't close out this issue after we updated the related topic.  Maybe because I closed out #451 instead.  Anyway, https://docs.microsoft.com/windows-hardware/drivers/install/kernel-mode-code-signing-policy--windows-vista-and-later- is freshly overhauled, hopefully clearer.  Thanks again for the initial feedback!


Improve move command (and add rename command)

I was testing the move command today (with encrypted Amazon Cloud Drive), and I did try to move from Amazon Cloud inside Amazon Cloud itself. I tried to changed the folder name, only. But rclone started downloading and uploading everything all over.
So I realized two things:
1 - The move command is not working. If rclone was smarter it would simply rename the folder instead of trying to re-download everything.
2 - We are missing a rename command. This is especially useful for the encrypted backups, because  of the encrypted filenames. Otherwise we could simply use the cloud interface,given by the service provider, to rename each file and folder. But with encrypted version it is not possible since we don't know what name means what, and we don't know how to manually create encrypted names.

Sorry, just saw there was already people asking for that.

Try the latest beta - it fixes all those issues and adds the moveto command which can be used to rename things.


Aarch64 builds

Could you please publish ARM64 builds on the releases page? I want to also run musikcube on a Raspberry Pi with 64-bit OS.

+1 to this; nowadays ARM64 is becoming more popular on Linux, i.e. Asahilinux for Apple Silicon Mac hardware


⚠ Bofrost.be has degraded performance

In b11888c, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 1469 ms

Resolved: Bofrost.be performance has improved in c1d835f.


UrlDecode blob id in the header to suport blob name with non-ascii characters

We are trying to support all blob names in update ttl and signed url. In both operations, blob names will be provided by client in the http header. Blob names can have any characters so in order to pass the correct blob names to ambry frontend, client would have to url encode blob names with utf8 charset. Ambry frontend would also have to decode the blob names back its original characters.

Codecov Report
Patch coverage has no change and project coverage change: -55.44% :warning:

Comparison is base (ab579d1) 72.57% compared to head (b609712) 17.14%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@              Coverage Diff              @@
##             master    #2590       +/-   ##
=============================================
- Coverage     72.57%   17.14%   -55.44%
+ Complexity    11402     2883     -8519
=============================================
  Files           803      803
  Lines         64710    64731       +21
  Branches       7901     7902        +1
=============================================
- Hits          46965    11097    -35868
- Misses        15169    52817    +37648
+ Partials       2576      817     -1759

Files Changed
Coverage Δ

...c/main/java/com/github/ambry/rest/RequestPath.java
0.00% <0.00%> (-94.51%)
:arrow_down:

... and 628 files with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Visual feedback on PC not working

Hi, firstly, I absolutely love the addon. Thank you so much for all the work you put into creating and maintaining it! After one of the more recent Anki updates the visual feedback notifications disappeared completely. I tried reinstalling the addon and removing any other ones in case there was any interference happening, but to no avail. Any ideas on how I could fix that?

Thanks for letting me know! This will be fixed in a newer version of the addon.
For now, you can fix it by opening the anki addons page, clicking ankimote, then 'view addon files', and in the folder that pops up, replace __init__.py with the version linked here: https://gofile.io/d/SPHhzl

Now fixed in the latest version on ankiweb!


Doc error: assert_template has been extracted to a gem

I have used Controller Specs before but as it is recommended in the README I switched to Request Specs.
I'm using the examples here in the doc.
This test:
  it 'creates a shipment' do
      get new_shipment_path
      expect(response).to render_template(:new)
    end

Causes this error:
Failure/Error: expect(response).to render_template(:new)

     NoMethodError:
       assert_template has been extracted to a gem. To continue using it,
               add `gem 'rails-controller-testing'` to your Gemfile.

Should I add that gem or are the examples outdated?
Version: rspec-rails (3.6.1), rails 5.1.4

As it mentions, you should add the gem. The examples will then work as is.


Support more connected wallets of the same type

Looking into examples/hwi.rs it seems that only one connected wallet of a certain type is supported.
What needs to be done so the lib supports multiple connected devices of the same type?

Yes, it's one of our priorities for the next version of Liana (see https://github.com/wizardsardine/liana/issues/165). @edouardparis should tackle it this week.

@edouardparis i think this was addressed, can you confirm?

Actually it's not entirely supported in Liana yet @kloaec reports.

@edouardparis , looks like this has been addressed (https://twitter.com/KLoaec/status/1717491256664658297?t=6A-pyh8H5SxY_8XS98jRWw&s=19), right?


When a dropdown field that's rendered before fetching the option is pre-filled, it displays the value instead of the label

Reproduction
Repro
Describe the bug
If the options in a dropdown are fetched after the field is rendered, and there's an initial value on the field that's pre-filled (for example, when in an update page), the field displays the value of the option instead of the label.
Screencast from 05-15-2024 03:42:11 PM.webm
This also happens if the the initial value is not actually in the options.
Environment
• OS: Ubuntu
• Browser Firefox, Chrome
• Version 1.6.2

That would be correct, it does not know that the value to show is and after options it does not make any changes to the value itself.
You can write a simple plugin to maybe rerun the node.input(node._value) after options load.

Is there any update regarding this?


[Launcher] - Strings aren't localized

Looking at LauncherControl.xaml, has hardcoded strings which means other spots in the code are as well

looks to be done per team


RequestLogger to keep track of request/response timestamp

What is your Test Scenario?

My app makes a few requests and I would like to make sure these requests are made in the correct order and time interval.
What are you suggesting?

Currently the RequestLogger object in https://github.com/DevExpress/testcafe/blob/master/src/api/request-hooks/request-logger.js doesn't include a timestamp value when logging a request. I suggest we make these really small changes to loggedReq inside onRequest:
        const loggedReq = {
            id:        event._requestInfo.requestId,
            testRunId: event._requestInfo.sessionId,
            userAgent,
            request:   {
                timestamp: Date.now(), // <--- Only line of new code
                url:    event._requestInfo.url,
                method: event._requestInfo.method,
            }
        };

and inside onResponse:
        loggerReq.response            = {};
        loggerReq.response.statusCode = event.statusCode;
        loggerReq.response.timestamp = Date.now(); // <- Only line of new code

What alternatives have you considered?

There really isn't an elegant workaround for this issue.
Additional context

The feature is simple enough, and code location as well as suggested edits are both provided. Please leave me a message if you need further clarification.
I would be happy to take this ticket myself.

Thank you for sharing your idea with us. We will discuss it and consider implementing it in one of our future product updates.

@LavrovArtem Thanks a lot!

Any updates on this?

@orihomie This feature is not planned for the current sprint. We will consider implementing it in future releases.


Cannot build or generate with nuxt 3.4.3

I juste created a new project with Nuxt 3.4.3 and got error on build and generate
See this: https://stackblitz.com/edit/github-kv47kh
Run the npm run generate or npm run build
Shows:
 ERROR  Unexpected token (Note that you need plugins to import files that are not JavaScript)                                                             15:32:50
file: /home/projects/github-kv47kh/node_modules/@nuxt-themes/typography/components/global/ProseCodeInline.vue?vue&type=style&index=0&scoped=e2e5456a&lang.ts?inline&used:1:5
1: code{font-family:var(--typography-font-code);border-radius:var(--prose-code-inline-borderRadius);padding:var(--prose-...
        ^

 ERROR  Unexpected token (Note that you need plugins to import files that are not JavaScript)                                                             15:32:50

  at error (file://node_modules/rollup/dist/es/shared/node-entry.js:2150:30)
  at Module.error (file://node_modules/rollup/dist/es/shared/node-entry.js:13477:16)
  at Module.tryParse (file://node_modules/rollup/dist/es/shared/node-entry.js:14188:25)
  at Module.setSource (file://node_modules/rollup/dist/es/shared/node-entry.js:13790:39)
  at ModuleLoader.addModuleSource (file://node_modules/rollup/dist/es/shared/node-entry.js:23755:20)

Maybe something with Pinceau? I don't know how starts a investigation to help fix.

Hey, this has been fixed by Nuxt 3.5.0.
I'm closing this but feel free to re-open if you encounter it again!


Modified Admin Panel's Button

Made Admin Panel's button responsive and better looking. Also removed over-flowing of content in desktop and mobile version of the application.

@rowhitswami  can you please attach some screenshots of different pages that you changed.

This is the desktop version

This is mobile version with full responsiveness and hovering effect mached with theme color of the this application


sklearn.linear_model._coordinate_descent._alpha_grid does not have a normalize argument anymore

When running:
estimator = SGLCV(groups=groups
                  n_jobs=n_jobs,
                  random_state=rng,
                  suppress_solver_warnings=False,
                  l1_ratio=1,
                  normalize=True
                  )

estimator.fit(X,y)

I get the following error:
TypeError: _alpha_grid() got an unexpected keyword argument 'normalize'
I search for recent commits in sklearn, and with this commit, sklearn.linear_model._coordinate_descent._alpha_grid does not accept the normalize parameter anymore.

As written in the deprecation warnings with scikit-learn > 1.2:

normalize was deprecated in version 1.0 and will be removed in 1.2.

So with current version of groupyr would have to stick to scikit-learn >1.2

Thanks for raising this. I am working on this (and other dependency issues here: https://github.com/richford/groupyr/pull/79).

I believe this as well was resolved with #79 but we just never got around to closing the issue. Can you try with v0.3.2? Please feel free to reopen if I'm mistaken.


skywaling es data issue

Search before asking

[X] I had searched in the issues and found no similar feature requirement.

Description
i want learn about the detail of elasticseatch index data
Use case
i need search  data of es derectly not by skywaling UI,now i have two question:
1、what is the different of the index skywalking_log-xxx and skywalking_segment-xxxx
2、when i search the es data of skywalking_segment-xxxx ,the data result is encryptioned how can i get the original data
Related issues
no
Are you willing to submit a PR?

[ ] Yes I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

Explain this is not community responsibility. We only encourage you read data through APIs.


Add initial support for network policies

What does this PR change?
This PR introduces initial support for network policies
Does this PR relate to any other PRs?
Inspired by #56
How will this PR impact users?
Adds the ability to enable network policies simply by setting the field networkPolicies.enabled to true
Does this PR address any GitHub or Zendesk issues?
Closes #21
How was this PR tested?

kind version: v0.20.0
K8s version (both client and server): v1.27.3
Helm version: v3.13.2

Internal Prometheus

Repository: https://prometheus-community.github.io/helm-charts
Chart: prometheus
Release name: prometheus
Namespace: prometheus-system

OpenCost configuration

Using the defaults in charts/opencost/values.yaml
With networkPolicies.enabled set to true

Does this PR require changes to documentation?
Included within the PR, please review
Have you labeled this PR and its corresponding Issue as "next release" if it should be part of the next OpenCost release? If not, why not?
Not applicable to this Helm chart repository, I believe?

kind and Prometheus configuration

OpenCost Helm installation with default configuration

I propose let's keep this simple and we can refine the NetworkPolicy configuration options in future issues / PRs.

Just made the following changes to the Helm chart configuration:

Reverted opencost.prometheus.internal.servicePort --> opencost.prometheus.internal.port
Moved opencost.prometheus.internal.podPort --> networkPolicies.prometheus.port

Rationale:

Preserve original field name to retain backwards compatibility with existing OpenCost installations utilizing a custom opencost.prometheus.internal.port value
The pod port of in-cluster Prometheus is only relevant when network policies are enabled

Rest assured I tested the newest changes against both the default configuration and with network policies enabled, but feel free to verify the results independently.

Merged in https://github.com/opencost/opencost-helm-chart/pull/155
Thanks @DonaldKellett!


Remove Absolute Paths

Yo hit up this sick new code but I think you already fixed it on your own version.
you gotta commit and push your updates back to the github with "git add <changed files or "." for all files in the directory>" "git commit -m 'commit message' " and "git push" as long as your local repo is set up with a remote on the git repo.

Fix for Issue #1

Already fixed issue. Also bold of you to assume I have any idea how to do that from the pi, but mad cool regardless


nasm download mirrors are down

I.e building openssl3
-- Downloading https://www.nasm.us/pub/nasm/releasebuilds/2.15.05/win32/nasm-2.15.05-win32.zip;https://fossies.org/windows/misc/nasm-2.15.05-win32.zip -> nasm-2.15.05-win32.zip... ... https://fossies.org/windows/misc/nasm-2.15.05-win32.zip: failed: status code 410

Seems to be back up.


comparePatches running only last operation

I'm having an issue with diff.comparePatches. it seems only the last operation is being applied:
diff:
  comparePatches:
  - apiVersion: v1
    kind: Secret
    name: wildcard-production-tls
    namespace: proxy
    operations:
    - {"op":"remove", "path":"/data"}
    - {"op":"remove", "path":"/metadata/annotations"}

This gives the repo as Modified with the following patch:
{"data":{"tls.crt":"","tls.key":""}}
If I invert the order on the operations, this is the patch:
{"metadata":{"annotations":{"reflector.v1.k8s.emberstack.com/reflected-at":"","reflector.v1.k8s.emberstack.com/reflected-version":""}}}
Versions
Rancher 2.5.8 - Fleet 0.3.5
I'm not very familiar with Go, but it seems this line overrides the last operation for a given object:
https://github.com/rancher/fleet/blob/5a578473735455c3c7c7e8aceac1b931a3a60dce/modules/agent/pkg/deployer/normalizers/jsonpatch.go#L23

Rancher version v2.6.3
Reproduced the issue using the steps provided here.

Rancher version: v2.6.4-rc5
This is testable in this RC as the fleet version in it is v0.3.9-rc4 I will proceed to validate there.

I've tried the same steps I did in v2.6.3 to reproduce the issue but using now a v2.6.3-rc5 that's has packaged:

fleet-agent:v0.3.9-rc4
fleet:v0.3.9-rc4
fleet:v0.3.9-rc4

I couldn't see the Bundle transition into Modified state but now not even the first patch operation makes the cluster go into Modified I tried modifying in the following order:

spec.revisionHistoryLimit (from 5 to 6)
set spec.revisionHistoryLimit back to the original value (5) and modified spec.replicas from 3 to 2
set the original value of spec.replicas to 2
Modified both spec.revisionHistoryLimit and spec.replicas to 10 and 4 respectively
set both spec.revisionHistoryLimit and spec.replicas back to their original values.

In all cases I didn't see the Bundle go into a Modified state.

I've understood the opposite these patches are for ignoring the value changes as per clarification conversation with @aiyengar2  I am returning this back to test.

Rancher version: v2.6.4-rc5
Created a fork https://github.com/izaac/fleet-test and edited the 323280 branch for doing modifications tests on the repo side of things

Checked making changes to the ignored fields in the fleet.yaml which were the default spec.replicas and spec.revisionHistoryLimit No modification state as expected.
Commented out the first spec.replicas and changed it in the deployment that triggered a modifying state in the Bundle.
Made a change in the fleet while on modified state back to uncomenting the spec.replicas diff patch. Bundle went back to Active state as the change is ignored as expected as per the fleet.yaml
Introduced a third operation field - {"op": "remove", "path":"/spec/template/spec/containers/image"} to have more than two and to test a longer path and image changes which are commonly used.

This is meeting the expected criteria now as per https://github.com/rancher/rancher/issues/36247#issuecomment-1020301575 and the Bundle Diffs doc, closing.


Add main property to package.json

Cannot find module 'ng-pattern-restrict'
Browserify throws this error when it tries to require the module.

Thanks for your pull request! The changes look great!
Pay no attention to Travis, it seems that something may be broken with Selenium and SauceLabs. I'll take care of that later.


Provide min_binding_size when generating the Bind Group Layout Descriptor.

We should probably provide a min_binding_size for uniform buffer when generating the Bind Group Layout Descriptor.
wgpu::BindGroupLayoutEntry {
  binding: 0,
  visibility: wgpu::ShaderStages::VERTEX | wgpu::ShaderStages::FRAGMENT,
  ty: wgpu::BindingType::Buffer {
    ty: wgpu::BufferBindingType::Uniform,
    has_dynamic_offset: false,
    min_binding_size: NonZeroU64::new(std::mem::size_of::<gpu_data::BatchUniformBuffer>() as _),
  },
   count: None,
}

Comment from the man himself: https://matrix.to/#/!FZyQrssSlHEZqrYcOb:matrix.org/$8OeoKDnC8ZI4SDsAd0oXHiWRmSxhT-TWgctUYWmffKY?via=matrix.org&via=mozilla.org&via=envs.net

For binding layout entries, also might be useful to generate comments for each layout entry. This helps especially when correlating large number of bindings.


unable to find codeowners file

Error: HttpError: Not Found
Error trying to find CODEOWNERS file. Please set cwd properly.
Using the following code:
name: Codeowners merging
on:
pull_request_target: { types: [opened, synchronize] }
issue_comment: { types: [created] }
jobs:
auto-merge-bot:
runs-on: ubuntu-latest
steps:
  - uses: actions/checkout@v2
  - name: Run Codeowners merge check
    uses<EMAIL_ADDRESS>    env:
      GITHUB_TOKEN: ${{ secrets.PR_TOKEN }}
    with:
      cwd: "./github"

Console output:
Run<EMAIL_ADDRESS>with:
cwd: ./github
merge_method: squash
assign_reviewer: true
env:
GITHUB_TOKEN: ***
Error: HttpError: Not Found
Error trying to find CODEOWNERS file. Please set cwd properly.
Changed files: /stacks/data_eng/anita_pratt/base_tables/table_a/Pulumi.yaml
Found @anupamadas31 as owners of /stacks/data_eng/anita_pratt/base_tables/table_a/Pulumi.yaml
Elegible reviewers:
Arbitrary choosen  as assigned reviewer! PR assigned:<PHONE_NUMBER>740991
Assigned reviewer: . Sending welcome message!
Seems PR user is only owner. Will accept anyone to merge or approve.
Missing approvals for PR. Potential owners:
Error: PR cannot be merged
Setting labels: needs-lgtm
Removing label: merge-ready
Failed to remove label merge-ready
Removing label: needs-manual-merge
Failed to remove label needs-manual-merge
Removing label: lgtm
Failed to remove label lgtm
Removing label: needs-merge
Failed to remove label needs-merge

The cwd should probably be .github/ based on the concatenation here:
https://github.com/casassg/auto-merge-bot/blob/v0.3.6/index.js#L409
I tried that on my own repo, it still failed like yours is.


feat: add playwright scraper

cc @barjin, maybe you can reuse something from this

@B4nan could not add you as a reviewer 🤷♂
Updated the readme (as well as quite a few other things), tried to build on the platform - seems like all is good. There are some rough things to be polished in scraper tools, but seem to be working fine.
Using big playwright image and runs both chromium/firefox. Webkit has some issues with fingerprints for some reason. I guess if it's gonna be slow - in the future we could create Playwright scraper+chromium and separate with firefox one.

btw - I put some links to Apify SDK with sdk.apify.com so that we would not need to return to it, hopefully, I used the correct links (but I'll check it of course).

@B4nan so, apparently I fucked up package-lock on merging changes from master here: https://github.com/apify/apify-sdk-js/pull/26/commits/bff9f9e8e5ba164bb34de7134a87929dfa9479fa
Then I guess I re-generated it here https://github.com/apify/apify-sdk-js/pull/26/commits/3716dc3de2d469a542c42b3867f85a52d1d3f7f4 (not sure really, as tests were failing because of the version first, then because of the badly merged changes from master, I guess I just removed and npm installed everything again) and it screwed things up completely.
I compared the changes from this branch with master and tried to install everything/run the tests locally - it was fine when I noticed that the only difference is lock file and there's something off with it.
So yeah, I thought I am going crazy 🤯🤯🤯
But finally all green.

The thing with reinstalling I noticed some time ago - if you want to wipe node modules, lock file and reinstall, you also need to wipe the node modules folder inside packages/*. Dont ask me why, you know my stand on how dumb NPM is :D Just the fact that the yesterdays weirdness was resolved by doing yarn instead and checking its error logs is self explanatory :D

As for the previous comment (node modules wiping etc) - that would actually explain it - I was kinda thinking even how I ended up with that new lock file - as when I tried to wipe it and npm install fresh - it was still different - so yeah - must have left some node_modules in packages


Audit licensing of contributed code

Original issue: https://charm.cs.illinois.edu/redmine/issues/444

Scan your core modules for any third party code and examine the relevant licensing.  Report on what code you find and how its license impacts our Charm++ distribution practices.
Directories listed starting from src (everything above/aside is ours).
Fully Checked:

arch
QuickThreads
scripts
util (except for crc32)
xlat-i
xlatcpm
conv-core
conv-ccs
conv-ldb
conv-perf
ck-core
ck-ldb
ck-cp
ck-perf
ck-tune
langs
libs

Dirty

util/crc32
libs/ck-libs/datatransfer - Poorly written license that doesn't grant what it meant to from defunct Magic Software Company
ck-ldb/{tm_*,TreeMatchLB.*} - questionable, since Jeannot was not working for UIUC. Would need assignment paperwork.
conv-core/random.c - written by NCSA, so license from University may be fine.

Not fully checked:

conv-com
ck-com

Original date: 2014-03-18 22:26:49

No licensing issues found in Rth, Verbs, One-sided, bigsim, bignetsim.
Pami code has contributions from a third party (IBM), but they are not claimed under a licensing agreement distinct from the general one for Charm.

Original date: 2014-03-19 19:59:27

No issues in charmxi, charmc, QD, MSA, build, or tcharm. Added column on module ownership page to record this more succintly: https://wiki.engr.illinois.edu/display/ppl/Software+Module+Ownership

Original author: Abhishek Gupta
Original date: 2014-03-21 01:20:06

No issues in net, charmrun, and ccs.

Original author: Ehsan Totoni
Original date: 2014-03-23 16:13:57

No third party code in futures and BigSim.
A minor potential issue: BigSim uses the obsolete name "BlueGene" for some files and routines.
I assume the default parameters do not violate IBM's NDAs since they had been in the public repository for a long time.

Original date: 2014-03-23 21:25:47

CharmDebug: Gdb can be attached to PE's in CharmDebug. Gbd is under GPL licensing, I'm not quite sure about the impact of this.
Charj: (Charj is still distributed in the release.) It uses ANTLR framework for parser generator which has BSD license.

Original date: 2014-03-24 03:46:20

No issues in ldb, seed ldb, reductions, csd or location mgr.

Original date: 2014-03-24 16:31:20

Updated for pami, mpi, cth, topo, partitions, data transfer,  startup, interop.

Original date: 2014-03-24 17:46:02

No issues in FT framework.

Original author: Yanhua Sun
Original date: 2014-03-24 21:18:31

Checked for  gni, lrts, smp, tracing
lz4 compression algorithm:  BSD 2-Clause License

Original author: Akhil Langer
Original date: 2014-03-24 21:27:12

liveViz

uses Intel SSE library for SIMD (xmmintrin.h), which is part of GCC, GPL.
uses osl.h header, of whose origin I could not find. There is only one usage of it, to get the time.
uses jpeglib, which is available under GPL license
Open GL, seems to be free from license requirements http://www.opengl.org/about/#11

Original author: Lukasz Wesolowski
Original date: 2014-03-26 04:06:20

I think a significant amount of code in the charm repository is not assigned as a module to anyone. This includes conv-com, ck-com, large chunks of src/util and libs, and various files in all the other directories. In addition, there are the examples, tests, and docs directories.
By the way, ckhashtable.C has the following comment:
This is a simple Hashtable implementation, with the interface shamelessly stolen from java.util.Hashtable.

Original date: 2014-03-26 21:04:01

Akhil Langer wrote:

liveViz

uses Intel SSE library for SIMD (xmmintrin.h), which is part of GCC, GPL.

xmmintrin.h from GCC explicitly includes a 'GCC Runtime Library Exception' that covers our usage. Other compiler vendors provide their own version of this header, all similarly unrestrictive.

uses osl.h header, of whose origin I could not find. There is only one usage of it, to get the time.

I can't find this header. Note that it's only referenced under an #ifdef commented as "serial version". I'll assume "OSL" refers to Orion Sky Lawlor, who authored LiveViz. He authored the including code in 2004, apparently while still at UIUC (commit msg references ongoing thesis work), so we should own it anyway.

uses jpeglib, which is available under GPL license

There are two version of libjpeg. The version packaged as libjpeg8 on Ubuntu 12.04 is available under the Lesser/Library GPL, whose licensing terms are not contagious to programs linking against it. The version packaged as libjpeg62 on Ubuntu 12.04 has more BSD-like terms, with a notice provision saying

If only executable code is distributed, then the accompanying documentation must state that "this software is based in part on the work of the Independent JPEG Group"

So, at worst we need to include the notice text when shipping linked binaries.

Open GL, seems to be free from license requirements http://www.opengl.org/about/#11

This looks fine.

Original date: 2014-04-02 20:43:05

Checked src/arch in full, and all looks reasonably good.
Checked src/util in full. Our CRC32 implementation is copied verbatim from a source that does not provide an explicit license we can use. We would need to reimplement afresh, or get an appropriately free implementation of some other checksum algorithm, or simply remove the associated functionality.

Original date: 2014-04-03 18:45:38

Please review for code that looks like it might night have been written outside of PPL, and Google for original sources. Please also review git logs to look for references to import or copy from elsewhere. Variable and function names typically make good search terms.
Individual assignments from  src/conv-core:
Xiang done
cmibacktrace.c
debug-conv.c
debug-conv++.C
debug-conv.h
debug-conv++.h
msgq.h
-Yanhua- Eric Bohm done
cmidirect.h
cmidirectmanytomany.h
conv-onesided.c
conv-onesided.h
persistent.h
Eric Mikida done
conv-conds.c
convcore.c
cpthreads.c
cpthreads.h
msgcallbacks.c
msgmgr.c
Ronak done
conv-config.h
conv-counter.c
conv-cpath.h
cpath.c
cpuaffinity.c
fmain.f90
Nikhil done
conv-interoperate.c
conv-ooc.h
conv-qd.h
conv-trace.h
conv-cpm.h
cpm.c
Michael done
global-elfcopy.C (no issue)
global-elfgot.C  (no issue)
global-macho.C   (no issue)
global-nop.c     (no issue)
loadsym.c        GNU Lesser GPL v2.1 or later; (C)2001 Victor Zandy <zandy`cs.wisc.edu>
Ehsan done
quiescence.c
quiescence.h
random.c
conv-random.h
futures.c

Original date: 2014-04-03 18:55:32

Yanhua has been asked to review ck-perf.

Original date: 2014-04-03 19:12:04

Assignments from src/ck-core:
Akhil done
ckobjid.C
ckobjid.h
cksection.h
ckstream.h
cktiming.C
cktiming.h
objid.h
Abhishek done
debug-charm.C
debug-charm.h
debug-message.C
readonly.h
register.C
register.h
stats.h
tempo.C
tempo.ci
tempo.h
Bilge done
ckarray.C
ckarray.ci
ckarray.h
ckarrayindex.h
ckobjQ.C
ckobjQ.h
modifyScheduler.C
msgalloc.C
ckmarshall.ci
ckmessage.h
Lukasz done
charm-api.h
charmf.C
charmf.h
charm.h
charm++.h
ck.C
ck.h
middle-blue.h
middle-conv.h
middle.h
charmmod.f90
Harshitha done
ckcallback.C
ckcallback-ccs.h
ckcallback.ci
ckcallback.h
ckdirect.h
ckIgetControl.C
ckIgetControl.h
With this set of assignments, everyone's gotten something from the core to review. I'll start recycling names for libraries and other files.

Original author: Yanhua Sun
Original date: 2014-04-03 19:32:27

in ck-perf, when we output compressed logs, we need zlib library, which is GPU compatible

Original date: 2014-04-03 19:36:53

Assignments from ck-libs
Abhishek done
liveViz
liveViz3d
pythonCCS
Akhil done
barrier
sparseContiguousReducer
sparseReducer
multicast
Bilge done
amr
mblock
pmaf
Ehsan done
tmr
TMRC2D
taskGraph
Eric Bohm done
pencilfft
fftlib
pose
Harshitha done
ckloop
idxl
Michael done
fem
-partition.C makes use of metis which is Licensed under the Apache License, Version 2.0 (C) 1995-2013, Regents of the University of Minnesota
ifem   (no issues)
netfem (no issues)
ParFUM
-parallel_part.c uses ParMetis which has it's own license (C) Regents of the University of Minnesota
-ParFUM_internals includes mpi.h
ParFUM-Iterators
-ParFUM_Iterators.cc includes cuda.h and cuda_runtime.h (unsure of licensing issues)
ParFUM-Tops
-ParFUM_TOPS.cc includes cuda.h and cuda_runtime.h (unsure of licensing issues)
ParFUM-Tops-Dev
-ParFUM_TOPS.cc includes cuda.h and cuda_runtime.h (unsure of licensing issues)
Phil done
completion
irecv
armci
boomarray
Xiang done
collide
Yanhua
search
state_space_searchengine

Original author: Yanhua Sun
Original date: 2014-04-03 19:46:36

state space search engine inside  src/ has no issues.  Example of UTS is using code from other people, copy right by the authors

Original date: 2014-04-03 19:53:36

Nikhil: done
langs/bluegene
Bilge: done
langs/charj

Original date: 2014-04-03 19:55:31

Per Yanhua in #444-25, examples/charm++/state_space_searchengine/UnbalancedTreeSearch_SE/ needs to recover the AUTHORS and LICENSE file from the upstream UTS benchmark reference code. This is the only change necessary to comply with the stated terms of the MIT license.
Yanhua, could you please grab the original benchmark tarball and copy in the license information?

Original date: 2014-04-03 20:00:27

Ronak done
ck-cp
Eric Mikida
langs/f90charm
langs/jade
langs/pvmc
langs/sdag
langs/simplemsg
langs/streams

Original author: Ehsan Totoni
Original date: 2014-04-03 20:17:52

conv-core/random.c: the whole code is from NCSA.
No other issues in my assignments.

Original date: 2014-04-03 20:28:15

libs/{completion,irecv,armci,boomarray} are all fine once change 159 (BSD-ish license text for ARMCI) gets merge.

Original date: 2014-04-03 20:39:18

conv-core/{random.c,conv-random.h} have no apparent license beyond what the University/NCSA grant us. If the University fully represents NCSA's interest in that code, then we're fine, since they won't sue themself or its own licensees. The clarity of an explicit license would be ideal.

Original date: 2014-04-03 20:47:54

THe zlib license is wholly unrestrictive, and non-copyleft. GPL-compatible could be a problem for us (since GPL itself would be a problem), but that's not in play here.

Original author: Abhishek Gupta
Original date: 2014-04-03 20:54:42

LiveViz is already checked by Akhil.
pyhtonCCS looks fine except: In PythonCCS.h
// README: in order for this library to work, there should be a link
// from /usr/include/python to the current python include version
#include "./pythonIncludes.h"
which is a pyhton include file. I suppose there are no problems with Python include file since Python releases are open source and GPL-compatible.

Original author: Akhil Langer
Original date: 2014-04-03 20:58:14

Akhil
ckobjid.C - ok
ckobjid.h - ok
cksection.h - ok
ckstream.h - ok
cktiming.C - includes mambo.h which I could not figure out what it is. Also uses papi.h
cktiming.h - ok
objid.h - ok

Original date: 2014-04-03 21:01:34

pencilfft: ok
(contributed directly by Sameer Kumar, implicitly covered by the general Charm license like the pami machine source)
fftlib: ok
pose: ok

Original date: 2014-04-03 21:03:32

cmidirect.h: ok
cmidirectmanytomany.h: ok
(contributed by Sameer, IBM is fine with this sort of thing)
conv-onesided.c: ok
conv-onesided.h: ok
persistent.h: ok

Original author: Akhil Langer
Original date: 2014-04-03 21:13:33

Akhil
barrier: ok
sparseContiguousReducer: ok
sparseReducer - no included files, but some macro defs that need to be checked if they are written by us
multicast:ok

Original date: 2014-04-03 21:16:37

Just a note to everyone: GPL compatibility is neither necessary nor sufficient condition for our needs. You should be noting the exact license involved. You don't need to understand it in detail (I can follow up on them), but I need links or unambiguous names/references.

Original date: 2014-04-04 19:05:43

My assignments in conv-core and ck-cp all look fine, except for conv-counter.c's inclusion of papi.h.

Original date: 2014-04-04 19:20:47

PAPI is under a 3-clause BSD license, so it's fine.

Original author: Lukasz Wesolowski
Original date: 2014-04-06 21:57:01

Done with checking these files. The only issue I found is the inclusion of crc32.h in ck.C.
charm-api.h
charmf.C
charmf.h
charm.h
charm++.h
ck.C
ck.h
middle-blue.h
middle-conv.h
middle.h
charmmod.f90

Original date: 2014-04-07 14:50:33

Done checking and no issues found.
ckcallback.C
ckcallback-ccs.h
ckcallback.ci
ckcallback.h
ckdirect.h
ckIgetControl.C
ckIgetControl.h
ckloop
idxl

Original date: 2014-04-07 15:50:12

langs/bluegene - Clean
Charj - it describes a LICENSE of its own and is based on external BSD entities:
Portions of the Charj grammar are based on a Java 1.5 recognizer by Habelitz Software Developments. This recognizer is available at http://antlr.org/grammar/1207932239307/Java1_5Grammars and is governed by the following license... (BSD license type statement follows)
Portions of the Charj language are based on the Mantra language by Terence Parr. This software is available at http://www.linguamantra.org/ and is governed by the following license... (BSD license type statement follows)
The lib folder contains external jars - JSAP-2.1.jar	ant-antlr3.jar	antlr-3.2.jar

Original date: 2014-04-07 16:25:32

The Java Simple Argument Parser (JSAP) library that CharJ uses is under the LGPL. So, we need to keep a source archive of it available to offer in correspondence to the binary, but we're otherwise fine.

Original date: 2014-04-07 19:11:05

Done checking and no issues found in
cmibacktrace.c
debug-conv.c
debug-conv++.C
debug-conv.h
debug-conv++.h
msgq.h
collide

Original author: Abhishek Gupta
Original date: 2014-04-08 01:58:44

From ck-core, no issues in following files:
debug-charm.C ok
debug-charm.h ok
debug-message.C
readonly.h ok
register.C ok
register.h ok
stats.h  ok
tempo.C ok
tempo.ci ok
tempo.h ok

Original date: 2014-04-08 02:08:41

No issues in :
conv-interoperate.c
conv-ooc.h
conv-qd.h
conv-trace.h
conv-cpm.h
cpm.c

Original date: 2014-04-08 02:16:56

No issues found in ck-core:
ckarray.C
ckarray.ci
ckarray.h
ckarrayindex.h
ckobjQ.C
ckobjQ.h
modifyScheduler.C
msgalloc.C
ckmarshall.ci
ckmessage.h
No issues found in libs/ck-libs:
amr
mblock
pmaf

Original author: Abhishek Gupta
Original date: 2014-04-08 02:36:10

I rechecked CCS since I thought my earlier pass was very quick and may not have been thorough.
In ccs-auth.c,
SHA-1 message hash code is copied from somewhere. The comments say:
Implemented and placed in the public domain by Steve Reid
Collected by Wei Dai (http://www.eskimo.com/~weidai/cryptlib.html)
Adapted for Charm++ by Orion Sky Lawlor, olawlor`acm.org, 7/20/2001
I tried following the link and finding the original source but was not able to find it. In fact, somebody else copied the same code with the same comment (even mentioning Orion Sky Lawlor and Charm++)

Original date: 2014-04-08 02:44:47

http://sourceforge.net/p/cryptopp/code/HEAD/tree/trunk/c5/sha.cpp
That SHA1 code is indeed in the public domain, and thus free from copyright concerns.

Original author: Yanhua Sun
Original date: 2014-04-08 16:15:14

Yanhua Sun wrote:

state space search engine inside  src/ has no issues.  Example of UTS is using code from other people, copy right by the authors

Here is the license for UTS
Copyright (c) 2009 See AUTHORS file for copyright holders
Permission is hereby granted, free of charge, to any person
obtaining a copy of this software and associated documentation
files (the "Software"), to deal in the Software without
restriction, including without limitation the rights to use,
copy, modify, merge, publish, distribute, sublicense, and/or sell
copies of the Software, and to permit persons to whom the
Software is furnished to do so, subject to the following
conditions:

Original date: 2014-04-09 01:05:05

No issues found in conv-core:
conv-conds.c
convcore.c
cpthreads.c
cpthreads.h
msgcallbacks.c
msgmgr.c
No issues found in: langs/sdag, langs/simplemsg, langs/fortran90charm
Still looking into: langs/streams, langs/pvmc, langs/jade

Original date: 2014-04-09 19:19:20

Finished reading code in lang.
lang/streams: used by NAMD. Don't know if code was written by NAMD and used by Charm++ or vice versa.
Here's the code in NAMD: http://www.ks.uiuc.edu/Research/namd/doxygen/MStream_8h-source.html
Here's NAMD's license info: http://www.ks.uiuc.edu/Research/namd/2.9/ug/node1.html
lang/pvmc: Uses PVM (Parallel Virtual Machine) code. Couldn't find licensing info on their homepage, but according to Wikipedia "PVM is free software, released under both the BSD License and the GNU General Public License."
lang/jade: Jade uses the GNU Lesser General Public License. I think this code may also use either ANTLR or Groovy code. ANTLR is the BSD license. Groovy is the Apache 2.0 license.

Original date: 2014-04-09 19:41:40

Submitted a patch to ditch the lang/streams code, since it has been defunct since it was committed.
Submitted a patch to add appropriate license/attribution text for UTS example.
Double-checked PVM and Jade. PVM is under a generic permissive license, and also defunct. Jade is derived from a Java grammar that's in the public domain, and uses ANTLR to generate its compiler, which is also under a permissive license.
Everything that's not deprecated is thus checked as clean, modulo the listed problem cases.

Original date: 2014-04-11 20:53:27

The bits of math library code from Magic Software that were imported into the data transfer library seem to have been inherited and revised by a company now known as "Geometric Tools":http://www.geometrictools.com/ContactInformation/ContactInformation.html who release the current version of that code (heavily modified, only a bare resemblance is recognizable) under the very permissive Boost Software License. So, we could either rewrite to use that newer version, or ask them for permission to continue using the older version under the present Boost license, or leave it be on the assumption that if the new code is distributed under BSL, then they're not going to pursue questionably licensed users of the old code.

Original date: 2014-05-05 19:13:39

Existing issues are considered acceptable for release, and will be resolved subsequently.


Redundant add dataset information and dead link.

Alternatively, you can follow the steps to add a dataset and share a dataset in the documentation.

The add a dataset link gives 404 Error, and the share_dataset link can changed. I feel this information is redundant/deprecated now since we have a more detailed guide for "How to add a dataset?".

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.


How to deal with generichide and elementhide?

Sites that have generichide and elementhide filters don't get detected. Is there some way to detect these sites?

Currently with the V3, this is not possible.
It will use the V4 that can also test the HTTP request and check that the advertising scripts load properly.

Users are still bypassing everything using $generichide it's 7 month later. any luck?

I always confirms that it will never be implemented in the V3, because it requires very large changes. This is why I invite you to turn to the V4, which it supports HTTP detection that can solve this problem.


More intuitive Clone dialog

Choosing an empty folder should be easier (create one for the user?)

Made the dialog have more instruction, and it creates an empty folder for the repo.


Add YAMZ project listing to the MRC website

As suggested by Jane. https://cci.drexel.edu/mrc/research/

https://cci.drexel.edu/mrc/yamz-metadata-dictionary/
Updates will be ongoing


504 Gateway Time-out nginx/1.18.0 (Ubuntu)

Hi Soren,
Every time I run MINT after picking peaks, I get this error 504 Gateway Time-out nginx/1.18.0 (Ubuntu). Could you please fix it for me? I want to download the results from Promastigotes_spent_media workspace.
MINT version: 0.0.53 65.gd5fff28.dirty
OS: Linux-5.4.0-77-generic-x86_64-with-debian-10.10
Versions: ---

Hi,
I saw the peaklist has no values in the rt_min and rt_max columns. Something seems to be wrong with your peak picking.
When there is no value MINT extracts the whole chromatogram for each peak and file which is to much to store in memory for the small VM. Mint actually relies on rt_min and rt_max.

This is how your peaks look at the moment. Try to zoom in to the peak that you are actually interested in and set the rt_min and rt_max before you run Mint.

I just went through a few peaks and clicked on 'Set RT to current view' and this is how it looks like now:

I think if the rt_min and rt_max values are not set a default margin is displayed. If you set the RT values by clicking on Confirm RT you may click on the Find largest peak for all button. That should set the values for most peaks.


wasmprinter: fix nested module/component printing.

This commit fixes wasmprinter to properly skip over nested modules and
components when locating name sections in the current component.
Additionally, closing parens for non-empty functions and modules/components now appear on
a new line which makes it easier to spot where they close.

@alexcrichton sorry for the re-review. The setting of the "should we end on a newline flag" in print_code bugged me so I pushed up a new commit that simply tracks what lines groups start on and ends the group on a new line if the group itself spanned multiple lines.


Unable to mock Secrets Manager with ESM

Checklist

[X] I have read Caveats documentation and didn't find a solution for this problem there.

Bug description
Using ts-jest with experimental ESM support enabled, I am struggling to mock the SecretsManager.  I have been able to get other AWS services to mock properly in this same ecosystem, so I'm not sure what about SecretsManager is different.
(see Example 1 below)
This simple, all in one file test fails:
    expect(received).toBe(expected) // Object.is equality

    Expected: "test_secret"
    Received: undefined

      814 |     console.log(result);
      815 |
    > 816 |     expect(result).toBe("test_secret");
          |                    ^
      817 |   });
      818 | });
      819 |

It detects that the command was called but doesn't get the resolved value it should have.
When I try to use this in a real test, where the credentials are being pulled in a separate class that I'm testing, the test fails and I see the error "CredentialsProviderError: Could not load credentials from any providers":
(see example 2 below)
When you inspect the mock in this scenario, you'll see that the mock never registered any command being run (ie, secretsManagerMock.commandCalls(GetSecretValueCommand).length == 0).
I have also tried moving the mock creation code to a jest setup file as was suggested in this previous issue.  However, that didn't change this behavior at all.  The mock was not used unless it was declared in the same file with the actual invocation.
Reproduction
// Example 1:
import { mockClient } from "aws-sdk-client-mock";
import {
  SecretsManager,
  GetSecretValueCommand,
} from "@aws-sdk/client-secrets-manager";

const secretsManagerMock = mockClient(SecretsManager);

secretsManagerMock.on(GetSecretValueCommand).resolves({
  SecretString: "test_secret",
});

  it("Pulls credentials from the secrets manager", async () => {

    const client = new SecretsManager();
    const input = { SecretId: "test_api_key" };
    const result = await client.send(new GetSecretValueCommand(input));
    expect(secretsManagerMock.commandCalls(GetSecretValueCommand)).toHaveLength(
      1,
    );

    expect(result).toBe("test_secret");
  });

// Example 2:
module.test.ts
import { mockClient } from "aws-sdk-client-mock";
import {
  SecretsManager,
  GetSecretValueCommand,
} from "@aws-sdk/client-secrets-manager";

const secretsManagerMock = mockClient(SecretsManager);

secretsManagerMock.on(GetSecretValueCommand).resolves({
  SecretString: "test_secret",
});

// Import class after mock is created using dynamic top level awaited import

const TestModule = (await import("module.ts")).default;

it("Pulls credentials from the secrets manager", async () => {
  const mod = new TestModule();
  const result = await mod.run();
  expect(result).toBe("test_secret");
});

module.ts
import {
  SecretsManager,
  GetSecretValueCommand,
} from "@aws-sdk/client-secrets-manager";

export default class TestModule {
   async run() {

    const client = new SecretsManager();
    const input = { SecretId: "test_api_key" };
    const result = await client.send(new GetSecretValueCommand(input));
    return result.SecretString;
   }
}

Environment

Node version: v20.8.1
Testing lib and version: Jest:

    "@types/jest": "^29.5.5",
    "jest": "^29.7.0",
    "jest-mock-extended": "^3.0.6",
    "ts-jest": "^29.1.2",
    "jest-extended": "^4.0.2",

Typescript version: 5.3.3

AWS SDK v3 Client mock version:

AWS JS SDK libs and versions:

    "@aws-sdk/client-secrets-manager": "^3.543.0",
    "aws-sdk-client-mock-jest": "^3.0.1",

Hey, can you provide a small repo with a reproduction? With Jest setup for ESM and exact commands to run to get the error (npm install and npm test in the simplest scenario).

Should you be mocking
const secretsManagerMock = mockClient(SecretsManagerClient);
and not
const secretsManagerMock = mockClient(SecretsManager);?


Feat/node actions

I am going to close this for now as unplanned. Thanks for the contribution though @Emmanuel-Develops ! We appreciate it.


Selecting the sounds category in the sound flyout doesn't work

In v0.2 the selection of a sounds category does not work when all sounds are showing.

The selection depends on the title. I forgot to use the strings dictionary.


Update MetalLB configuration steps

Update MetalLB configuration steps:
Newer versions of MetalLB don't support in-line configuration via the Helm values file. MetalLB is now configured using Custom Resources.

@microsoft-github-policy-service agree [company="Domino's LLC"]

@sethmanheim
Can you review the proposed changes?
When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

#sign-off


Please Add mav-teleop-twist-keyboard package to be indexed in the rosdistro

Please Add This Package to be indexed in the rosdistro.
melodic mav-teleop-twist-keyboard
The source is here:
https://github.com/dobots/mav_teleop_twist_keyboard

Hi! Thank you for taking your time for running these tests. I was following the ros wiki on how to release a package. Point 2.2. "Adding a package to rosdistro" suggests to run the command rosdistro reformat distribution.yaml to fix any formatting errors. If I try to run this command I get the error message: rosdistro: command not found. On [ros answers - how to run rosdistro command](https://answers.ros.org/question/100556/how-to-run-rosdistro-command/) it is stated that rosdistro` is not used anymore. Could you please help with which command should I use to fix any formatting issues? Thank you in advance!

Could you please help with which command should I use to fix any formatting issues? Thank you in advance!

You can use the standalone rosdistro_reformat command which is part of the python3-rosdistro package. With this branch cloned locally you could run rosdistro_reformat index-v4.yaml to update distribution files that require reformatting.

Thank you for your answer!  I have found another tutorial for releasing a package, which is based on the tool called bloom: http://wiki.ros.org/bloom/Tutorials/FirstTimeRelease
In the last step of the tutorial, it notifies the build farm and creates a pull request so there is no need to edit the distribution.yaml file manually. I'll try to use that tool first. If I run into problems, I'll try your solution :)


Change location of WebRTC repository to external subfolder

At the moment the Native vcxprojs expect the WebRTC repository and its builds to be in the parent folder. It would be more correct to treat it as a submodule and place it in the external folder.

Fixed by d6c6992ade69014ecec3b4bd3987bc4dd28b7ce0


Update serilog to 4 and move batching to Serilog core

Related issiue: https://github.com/serilog-mssql/serilog-sinks-mssqlserver/issues/543#issue-2347936892
Update Serilog v3.1.1 to 4.0.0 https://github.com/serilog/serilog/releases/tag/v4.0.0
Update Microsoft.Data.SqlClient to 5.2.1
Remove dependency Serilog.Sinks.PeriodicBatching
PerioadingBatching moved to BatchingSink in serilog core. https://github.com/serilog/serilog/pull/2055

Hi @cancakar35!
Thank you for your PR! Serilog 4 update was already on our list. We really appreciate your contribution! :)

There is still the open question regarding the returned null on sink creation. Can you please look into this again?

There is still the open question regarding the returned null on sink creation. Can you please look into this again?

Additional info for that lines:
In serilog 4 this line added https://github.com/serilog/serilog/blob/8c82a50711fb20c6e31ffd60b585359aeb9336ed/src/Serilog/Configuration/LoggerSinkConfiguration.cs#L69
Now its throw ArgumentNullException if the logEventSink parameter null
Releated commit : https://github.com/serilog/serilog/pull/2055/commits/44c5e1563b4ee418b631cd65ab5d1ca08a9b8b14
So, I thought it made sense to return null as before, instead of let it throw exception. I didn't see any problems with this approach in tests.

What's blocking this PR currently?

This is my.last concern with this PR https://github.com/serilog-mssql/serilog-sinks-mssqlserver/pull/545#issuecomment-2249868768
We should not handle an exception and then  return null on sink creation. Instead the exception should be handled by the caller.
I wanted to play with it to better understand why @cancakar35 implemented this but I did not yet get around to do this. Sorry for that.
@cremor if you could investigate this, I would highly appreciate this. Ideally we could just remove the exception handler but if not we should find a better solution.

What's blocking this PR currently?

Microsoft.Data.SqlClient change hasn't been reverted yet.

@ckadluba I chose this approach because the unit tests were failing when we let it throw exception. If we can change the unit tests we can remove null returning.
@ad-eg-dk Please look into this pr: https://github.com/serilog-mssql/serilog-sinks-mssqlserver/pull/548 . If you have any problem , please open an issue.

Maybe there is some mock missing. I'll look into this as soon as I can.

I have fixed the unit tests and created a new PR #557. But there are further open questions which I will handle in the new PR.


A simple tutorial for C++ users

I'm the one who usually use C++, and I found that the tutorials for users who use C++ aren't enough. Especially there are some questions which ask how to start Caffe2 with C++.
So I made a simplest tutorial. It's a very simple document but I think it may can help some C++ users. Please check my pull request and leave your feedback. I'll check it.

Looks like this is Windows specific. Aaron, could you check how to make sure it fits best in the website?

Thank you @HWhale !!!


[[TEST]] Test previously-unverified behavior

Coverage remained the same at 100.0% when pulling 4b70e469128da446fb2c9267d04793dbefa42ad0 on jugglinmike:test-export into 70b6639c903685412247ac226d10c1a19cb4ecdd on jshint:master.


HTML documentation

Fixes #44

I actually haven't finished here (hence the "draft" status), but thanks for taking a look.
I would especially like your thoughts on this section https://github.com/data-apis/array-api-compat/pull/103/files#diff-ebbf0983decf5c6b5520f86b136672b0a044a778687a8813de4900f4f554d58eR7. Specifically, this paragraph, https://github.com/data-apis/array-api-compat/pull/103/files#diff-ebbf0983decf5c6b5520f86b136672b0a044a778687a8813de4900f4f554d58eR36-R40. I think it would be good to have a policy on what we will and won't include in this library. A lot of people have made suggestions for things that could go here which I personally feel would be out of scope (e.g., I'm hesitant on even #104, because it's outside the domain of the standard, and I'm really hesitant on suggestions to include things like additional helpers for functions that aren't in the standard).

Actually we should probably add a separate "Scope" section to the main part of the docs to make this really clear to everyone. But I want to make sure that we are in alignment about what is and isn't in scope for this package.

Actually we should probably add a separate "Scope" section to the main part of the docs to make this really clear to everyone. But I want to make sure that we are in alignment about what is and isn't in scope for this package.

I agree with the way you have written it now. That matches my current understanding of what we're accepting into array-api-compat. Maybe the one thing to add is that functions accepted for inclusion in the standard, but not yet merged into a draft version of the standard or in a released version, may already be added to array-api-compat.

I've added a section to the main page explaining the scope of the package https://github.com/data-apis/array-api-compat/pull/103/files#diff-b4d68dc855d0f9476d3f2ee343853bd21bf82ea9960d0cf06661baa244439dd6R124

This is ready for review. You can see the rendered HTML version at https://data-apis.org/array-api-compat/


unable to view all declarations

Login with the portal, selecting "Declrations to review" - only 2 declarations are shown (while 72 were registered already)

Click "Declarations", 5 are shown - select  "Show by 20" or "Show by 50" - nothing happens. Press F5 to page refresh - internal server error

@svetavedmed please test and try to reproduce on demo
@pzhuk related to pagination. Fixed on demo.

All declarations are shown on demo

@pzhuk it looks like it works on demo.


Synchronize with generator-jhipster master / v6.9.0

Some work to do:

[x] fix enums
[x] fix some strange eslint error / prettier
[x] fix flaky e2e tests
[x] update login regex - see https://github.com/jhipster/generator-jhipster/pull/11729
[x] bug with LocalDate - https://github.com/jhipster/generator-jhipster/issues/11734
[x] do the release

I'll add more items soon
Work already started here: https://github.com/jhipster/jhipster-vuejs/pull/604

Maybe it's not flaky e2e tests, as it always failed for the same entities. And only in prod profile.
Here one of them:
  FieldTestEntity e2e test
    ✓ should load FieldTestEntities
    Create flow
      ✓ should load create FieldTestEntity page
      ✓ should create and save FieldTestEntities (6359ms)
      Details, Update, Delete flow
        ✓ should load details FieldTestEntity page and fetch data
2020-05-08 09:03:33.006 ERROR 9244 --- [  XNIO-1 task-2] o.h.e.jdbc.batch.internal.BatchingBatch  : HHH000315: Exception executing batch [java.sql.BatchUpdateException: java.lang.NullPointerException], SQL: update field_test_entity set big_decimal_max_tom=?, big_decimal_min_tom=?, big_decimal_required_tom=?, boolean_required_tom=?, boolean_tom=?, byte_any_maxbytes_tom=?, byte_any_maxbytes_tom_content_type=?, byte_any_minbytes_tom=?, byte_any_minbytes_tom_content_type=?, byte_any_required_tom=?, byte_any_required_tom_content_type=?, byte_any_tom=?, byte_any_tom_content_type=?, byte_image_maxbytes_tom=?, byte_image_maxbytes_tom_content_type=?, byte_image_minbytes_tom=?, byte_image_minbytes_tom_content_type=?, byte_image_required_tom=?, byte_image_required_tom_content_type=?, byte_image_tom=?, byte_image_tom_content_type=?, byte_text_required_tom=?, byte_text_tom=?, double_max_tom=?, double_min_tom=?, double_required_tom=?, duration_required_tom=?, duration_tom=?, enum_required_tom=?, enum_tom=?, float_max_tom=?, float_min_tom=?, float_required_tom=?, float_tom=?, instant_required_tom=?, instant_tom=?, integer_max_tom=?, integer_min_tom=?, integer_required_tom=?, integer_tom=?, local_date_required_tom=?, local_date_tom=?, long_max_tom=?, long_min_tom=?, long_required_tom=?, long_tom=?, number_pattern_required_tom=?, number_pattern_tom=?, string_maxlength_tom=?, string_minlength_tom=?, string_pattern_tom=?, string_required_tom=?, string_tom=?, uuid_required_tom=?, uuid_tom=?, zoned_date_time_required_tom=?, zoned_date_time_tom=? where id=?
2020-05-08 09:03:33.013  WARN 9244 --- [  XNIO-1 task-2] o.h.engine.jdbc.spi.SqlExceptionHelper   : SQL Error: 0, SQLState: S1000
2020-05-08 09:03:33.013 ERROR 9244 --- [  XNIO-1 task-2] o.h.engine.jdbc.spi.SqlExceptionHelper   : java.lang.NullPointerException
        1) should load edit FieldTestEntity page, fetch data and update
        2) "after all" hook: ret for "should load edit FieldTestEntity page, fetch data and update"

Use constant for login regex from https://github.com/jhipster/generator-jhipster/pull/11729 to be applied on https://github.com/jhipster/jhipster-vuejs/commit/b15ceb1b7605c75f7d6393226952c5af2b4ae1ed

Thanks @DanielFran, I added it in the list

I added a new problem I found:

generate an entity with LocalDate
create an entry -> OK
update the entry -> KO

Ok, the bug with LocalDate comes from the backend, and is not related to Vue.js
Vue.js blueprint detected it because there are some e2e tests with update

@atomfrede : there is a last item about login regexp. Do you have time to have a look ? If not, I can try to do the same than https://github.com/jhipster/generator-jhipster/pull/11729

Just merged this https://github.com/jhipster/jhipster-vuejs/pull/615
Waiting the last login regexp and we will be able to release a new version of Vue.js blueprint

Will do. Sorry totally forgot to port it here.

Putting a bounty on this, for all the work done here.
@atomfrede : as discussed together, we'll share it
Just did some tests, now, I'm going to do the release

Closed with https://github.com/jhipster/jhipster-vuejs/releases/tag/v1.8.0

The sample has been updated too: https://github.com/jhipster/jhipster-sample-app-vuejs

Half of the bounty claimed at https://opencollective.com/generator-jhipster/expenses/18514
Don't forget yours, @atomfrede

Thank you very much @pascalgrimaud As always a pleasure to work with you!
Other half claimed at https://opencollective.com/generator-jhipster/expenses/18529


jupyterlab 0.34 notebook fails with irrefutable pattern

The kernel stops with this Exception, when e.g. print "3+4" is executed in a new Haskell notebook:
Header: {"username":"","version":"5.2","session":"00cb7855-80d1-48e4-9b8d-407ffee191dd","msg_id":"2f2f7c14-daae-4211-8d72-870728919a73","msg_type":"execute_request","date":"2018-08-26T19:53:01.644284Z"}
Content: {"silent":false,"store_history":true,"user_expressions":{},"allow_stdin":true,"stop_on_error":true,"code":"print \"3+4\""}
ihaskell: src/IHaskell/IPython/Message/Parser.hs:71:5-81: Irrefutable pattern failed for pattern Just metadataMap

It doesn't fail when a code console is used instead of the notebook.

in 0.33 the same message looks like this:
Header: {"username":"","version":"5.2","session":"07e2d0c9-5c42-4ca3-9a67-4d6310624b06","msg_id":"89477dd2-606a-42ed-9864-c975f034e807","msg_type":"execute_request","date":"2018-08-26T20:00:21.663497Z"}
Content: {"silent":false,"store_history":true,"user_expressions":{},"allow_stdin":true,"stop_on_error":true,"code":"print \"3+4\""}
Message: PublishStatus {header = MessageHeader {identifiers = ["07e2d0c9-5c42-4ca3-9a67-4d6310624b06"], parentHeader = Just (MessageHeader {identifiers = ["07e2d0c9-5c42-4ca3-9a67-4d6310624b06"], parentHeader = Nothing, metadata = fromList [], messageId = UUID {uuidToString = "89477dd2-606a-42ed-9864-c975f034e807"}, sessionId = UUID {uuidToString = "07e2d0c9-5c42-4ca3-9a67-4d6310624b06"}, username = "", msgType = ExecuteRequestMessage}), metadata = fromList [], messageId = UUID {uuidToString = "c3be2f2a-938d-426b-b442-327de3bc6fe9"}, sessionId = UUID {uuidToString = "07e2d0c9-5c42-4ca3-9a67-4d6310624b06"}, username = "", msgType = StatusMessage}, executionState = Busy}
Sent: "{\"execution_state\":\"busy\"}"
[...]

identified the issue:
    -- Get metadata as a simple map.
    Just metadataMap = decode $ Lazy.fromStrict metadata :: Maybe (Map Text Text)

metadata is decoded as a map of two strings. It fails because the metadata sent by the notebook is more complicated:
Meta: "{\"deletedCells\":[\"1828b11c-cc08-4ede-b4fd-c95762c642a2\"],\"cellId\":\"f5407137-5d25-4d3e-b415-311ffbcb4dd1\"}"

I'll look into this if there are no objections.

that's great! Some people at Munihac potentially wanted to have a look at this as well this weekend. So let us know where you are at. Feel free to contact me if you need some help as well. Maybe we'll have this finally fixed next week.

I had a quick look and it seems that the metadata is not actually used anywhere.
If I'm not missing anything, I wouldn't bother parsing the metadata field at all. And if we need some of its attributes down the line, we could parse the fields we need into a proper data type instead of a map.

To be more exact it's not used in IHaskell packages. I however use it and I've been bitten by that limitation. I think just changing it to Map Text Data.Aeson.Value will fix things


TypeError: (0 , _schemaUtils.default) is not a function

Hello!
I am getting the error below when I build my project with webpack. Any idea why this comes up?
webpack 5.60.0 compiled with 3 errors in 2095 ms Error: ModuleBuildError: Module build failed (from ./node_modules/css-url-loader/build/loader.js): TypeError: (0 , _schemaUtils.default) is not a function     at Object.loader (/Users/ziggyd/Desktop/MyApp/node_modules/css-url-loader/build/loader.js:77:28),ModuleBuildError: Module build failed (from ./node_modules/css-url-loader/build/loader.js):
Thanks!

any update?

Is this a webpack5 thing? That's what I'm using.


Add Linux process cgroup attribute

Fixes # https://github.com/open-telemetry/semantic-conventions/issues/1357
Changes
Please provide a brief description of the changes here.
Note: if the PR is touching an area that is not listed in the existing areas, or the area does not have sufficient domain experts coverage, the PR might be tagged as experts needed and move slowly until experts are identified.
Merge requirement checklist

[ ] CONTRIBUTING.md guidelines followed.
[ ] Change log entry added, according to the guidelines in When to add a changelog entry.

If your PR does not need a change log, start the PR title with [chore]

[ ] schema-next.yaml updated with changes to existing conventions.

@open-telemetry/semconv-system-approvers Could you take a look at this PR when you have a moment? Thanks!

Would you mind taking a look at the changelog error and fixing that?

This was a problem on main, updating the PR has now fixed it 👍

I love the idea of having cgroup identifiers at hand: in Kubernetes that means that the k8s.pod.ui, which is part of the cgroup identifier, is just one OTTL rule away :-)


Perf: Relational: SQL generation

Given it's per query execution, we should take a look and see if there are any low hanging fruit.

SQL is now cached.