e9s timeline improvements

(1) I'm not sure how I feel about the --1-- --2-- --3-- there, but it's super helpful to know when the attacks are happening to help with movement.  It would be extremely wordy (and probably not helpful) to list out the a/b ability names for each options.  Is this ok? Any other opinions?
(2) I removed auto attacks from the timeline because test timeline showed stuff like:
369.182: Matched entry: 369.2 Flood Of Obscurity (+0.018s)
377.353: Matched entry: 377.3 Particle Concentration (-0.053s)
385.413: Matched entry: 387.8 --sync-- (+2.387s)
399.640: Matched entry: 397.3 Phaser Unlimited 3 (-2.340s)
408.752: Matched entry: 411.1 --sync-- (+2.348s)
421.215: Matched entry: 418.9 Ground-Razing Particle Beam (-2.315s)
422.912: Matched entry: 425.2 --sync-- (+2.288s)
435.282: Matched entry: 433.0 Rejuvenating Balm (-2.282s)
444.625: Matched entry: 444.6 The Second Art Of Darkness (-0.025s)
453.283: Matched entry: 452.6 --sync-- (-0.683s)
460.707: Matched entry: 461.3 Devouring Dark (+0.593s)
466.341: Matched entry: 468.7 --sync-- (+2.359s)
479.096: Matched entry: 476.7 Empty Plane (-2.396s)

I think in general you can't trust autos to be super consistent.

(1) I'm not sure how I feel about the --1-- --2-- --3-- there, but it's super helpful to know when the attacks are happening to help with movement.  It would be extremely wordy (and probably not helpful) to list out the a/b ability names for each options.  Is this ok? Any other opinions?
(2) I removed auto attacks from the timeline because test timeline showed stuff like:
369.182: Matched entry: 369.2 Flood Of Obscurity (+0.018s)
377.353: Matched entry: 377.3 Particle Concentration (-0.053s)
385.413: Matched entry: 387.8 --sync-- (+2.387s)
399.640: Matched entry: 397.3 Phaser Unlimited 3 (-2.340s)
408.752: Matched entry: 411.1 --sync-- (+2.348s)
421.215: Matched entry: 418.9 Ground-Razing Particle Beam (-2.315s)
422.912: Matched entry: 425.2 --sync-- (+2.288s)
435.282: Matched entry: 433.0 Rejuvenating Balm (-2.282s)
444.625: Matched entry: 444.6 The Second Art Of Darkness (-0.025s)
453.283: Matched entry: 452.6 --sync-- (-0.683s)
460.707: Matched entry: 461.3 Devouring Dark (+0.593s)
466.341: Matched entry: 468.7 --sync-- (+2.359s)
479.096: Matched entry: 476.7 Empty Plane (-2.396s)

I think in general you can't trust autos to be super consistent.

cc @JLGarber @panicstevenson

cc @JLGarber @panicstevenson

(1) I'm not sure how I feel about the --1-- --2-- --3-- there, but it's super helpful to know when the attacks are happening to help with movement. It would be extremely wordy (and probably not helpful) to list out the a/b ability names for each options. Is this ok? Any other opinions?

This seems fine. Maybe "Phaser 1/Phaser 2/Phasaer 3", but honestly the plain numbers are probably better just for not needing translations.

I think in general you can't trust autos to be super consistent.

No, there will never be a guarantee where in the auto-attack cycle the boss will be pulled, so I don't think autos are useful except for making sure the timeline starts.

(1) I'm not sure how I feel about the --1-- --2-- --3-- there, but it's super helpful to know when the attacks are happening to help with movement. It would be extremely wordy (and probably not helpful) to list out the a/b ability names for each options. Is this ok? Any other opinions?

This seems fine. Maybe "Phaser 1/Phaser 2/Phasaer 3", but honestly the plain numbers are probably better just for not needing translations.

I think in general you can't trust autos to be super consistent.

No, there will never be a guarantee where in the auto-attack cycle the boss will be pulled, so I don't think autos are useful except for making sure the timeline starts.


Fluid pressure

Implement fluid pressure conversion, which was halfway there, and add a demo.
Needs #19.

I'm getting a test error while running the tests locally:
`developer@bb9:~/bridge_ws$ catkin_make run_tests_ros1_ign_bridge_rostest_test_ros1_subscriber.test
run_tests_ros1_ign_bridge_rostest_test_ign_subscriber.test   run_tests_ros1_ign_bridge_rostest_test_ros1_subscriber.test
developer@bb9:~/bridge_ws$ catkin_make run_tests_ros1_ign_bridge_rostest_test_ros1_subscriber.test
Base path: /home/developer/bridge_ws
Source space: /home/developer/bridge_ws/src
Build space: /home/developer/bridge_ws/build
Devel space: /home/developer/bridge_ws/devel
Install space: /home/developer/bridge_ws/install

Running command: "make cmake_check_build_system" in "/home/developer/bridge_ws/build"

Running command: "make run_tests_ros1_ign_bridge_rostest_test_ros1_subscriber.test -j12 -l12" in "/home/developer/bridge_ws/build"

[ 50%] Built target gtest
[100%] Built target test_ros1_subscriber
Scanning dependencies of target run_tests_ros1_ign_bridge_rostest_test_ros1_subscriber.test
-- run_tests.py: execute commands
/opt/ros/melodic/share/rostest/cmake/../../../bin/rostest --pkgdir=/home/developer/bridge_ws/src/ros1_ign_bridge/ros1_ign_bridge --package=ros1_ign_bridge --results-filename test_ros1_subscriber.xml --results-base-dir "/home/developer/bridge_ws/build/test_results" /home/developer/bridge_ws/src/ros1_ign_bridge/ros1_ign_bridge/test/ros1_subscriber.test
... logging to /home/developer/.ros/log/rostest-bb9-7808.log
[ROSUNIT] Outputting test results to /home/developer/bridge_ws/build/test_results/ros1_ign_bridge/rostest-test_ros1_subscriber.xml
[Testcase: testign_ros1] ... ERROR!
ERROR: max time [10.0s] allotted for test [ign_ros1] of type [ros1_ign_bridge/test_ros1_subscriber]
File "/usr/lib/python2.7/unittest/case.py", line 329, in run
testMethod()
File "/opt/ros/melodic/lib/python2.7/dist-packages/rostest/runner.py", line 148, in fn
self.test_parent.run_test(test)
File "/opt/ros/melodic/lib/python2.7/dist-packages/rostest/rostest_parent.py", line 132, in run_test
return self.runner.run_test(test)
File "/opt/ros/melodic/lib/python2.7/dist-packages/roslaunch/launch.py", line 689, in run_test
(test.time_limit, test.test_name, test.package, test.type))
[ROSTEST]-----------------------------------------------------------------------
SUMMARY

RESULT: FAIL
TESTS: 0
ERRORS: 1
FAILURES: 0

`

Tests should be fixed in e37a63c.


Feature Request - CopyFiles:v2

Feature Request
Environment

Server - VSTS

If using TFS on-premises, provide the version:

Agent - Hosted or Private:

private agent on target

Issue Description

Intermittently directories are not cleaned at times. A redeploy fixes this 98% of the time. I suggest adding a clean retry option allowing the clean process to try again if it fails 1 or n times.

doesn't see the role of "copy" can you elaborate on directories that are not cleaned up.  And why would copy own cleaning up?

CopyFiles is a task in VSTS. You are given the options as part of this task
to clean folder, overwrite, or flatten. Clean folder fails from time to
time for websites for directories like app_themes. This is almost always
related to sub directories. Upon inspection after a failure sub directories
still exist but are empty. The ability to re-apply the clean operation is
simply to mitigate the failure of the clean operation be 100% successful
during a deployment.
On Tue, Sep 18, 2018 at 10:34 PM Bryan MacFarlane<EMAIL_ADDRESS>wrote:

doesn't see the role of "copy" can you elaborate on directories that are
not cleaned up. And why would copy own cleaning up?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/Microsoft/vsts-tasks/issues/8338#issuecomment-422627819,
or mute the thread
https://github.com/notifications/unsubscribe-auth/APEoREsrHZoyTc_JiIeJ8XJlvMHEFPrFks5uca1LgaJpZM4WuMHE
.

when would we re-apply? On failure?  Always?

Retry on failure would work. If the task could confirm that the clean was
successful and re-try only if files remain that would be optimal.
On Tue, Sep 18, 2018 at 10:52 PM Bryan MacFarlane<EMAIL_ADDRESS>wrote:

when would we re-apply? On failure? Always?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/Microsoft/vsts-tasks/issues/8338#issuecomment-422631174,
or mute the thread
https://github.com/notifications/unsubscribe-auth/APEoRC5b4HfIJkw_9E1jz3MMlVen9tM9ks5ucbF-gaJpZM4WuMHE
.

well it breaks the entire deployment because they are dependent on each other. Then you have to redeploy. Another characteristic that occurs is this error:  "Unhandled: Failed rmRF: EPERM: operation not permitted,"  A redeploy fixes the file EPERM issue.

Is this sufficient or do you need dir specifics?

I found a solution to this but I still do not understand the root cause. The solution is to check clean and overwrite in the task options. I have tested this on 1 deployment release successfully. Assuming both options are separate operations, I fail to see how this resolves the issue.

This issue is stale because it has been open for a year with no activity. Remove the stale label or comment on the issue otherwise this will be closed in 5 days


python-wrapper: use makeBinaryWrapper

A "python" made with the wrapper is likely to be used as a shebang. On macOS,
this requires a binary rather than another shebang'd script.
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[x] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

Discussion: Should this only apply to darwin?

@GrahamcOfBorg build python38.tests python39.tests python310.tests


Your Plugin Failed error dialog is blocking the interface of the application and there is no way to clear or suppress it other than hitting report.  Bad UX

VSCode Version: Code 1.18.0 (dcee2202709a4f223185514b9275aa4229841aa7, 2017-11-08T12:32:39.870Z)
OS Version: Darwin x64 16.7.0
Extensions:

Extension
Author (truncated)
Version

vscode-docker
Pet
0.0.22

vscode-eslint
dba
1.4.3

gitlens
eam
6.1.1

vetur
oct
0.11.3

Steps to Reproduce:

Reproduces without extensions: Yes/No

https://imgur.com/a/jWktF

This error means that all TypeScript and JavaScript language features are broken. You can press escape to cancel out if you really don't want to report the issue.
To see what is causing the problem in the first place, please open the output panel and go to the TypeScript section. Are there any error messages in there?

Closing as not actionable without more information


TransformRigidityPenalty makes registration far slower

Hi,
I'm using elastix 5.0 built from source. I have found that if I use TransformRigidityPenalty then the registration takes much, much longer. Perhaps around ten times longer. I would really like to figure out if there's anyway to work around or fix this.

Hi @reynoldscem, this metric is indeed slow to execute especially for B-spline transformations with a lot of parameters. Accelerating it would take a good idea and a new (GPU) implementation.


Add meta descriptions to prepaid agreement pages

Add meta and Open Graph descriptions to individual prepaid agreement pages instead of the default description ("Our vision is a consumer finance marketplace that works for American consumers, responsible providers, and the economy as a whole.") that shows up on those pages now.
Additions

desc and og_desc blocks to the prepaid agreement detail page template

Testing

Fire up this branch and visit http://localhost:8000/data-research/prepaid-accounts/search-agreements/
Go to the detail page of any agreement listed there
View source on that page
Confirm that the meta and Open Graph descriptions are like "Download the most recent prepaid product agreement files for the {{ product.name }} issued by {{ product.issuer_name }}." where the {{ product.name }} and {{ product.issuer_name }} bits match up with the info on the page. So, for agreement 45540, for example, the description should say "Download the most recent prepaid product agreement files for the My Target Paycard issued by Sunrise Banks, National Association."

Notes

See GHE/CFGOV/platform/issues/3727 for the background on this one
Some agreement detail pages won't have a totally unique description. There are some agreements that have the same {{ product.name }} and {{ product.issuer_name }} but differ in the date the agreement was submitted or in one of the other fields. Those seem like outliers, though, and this change will give the vast majority of the agreement detail pages a unique description (and even ones with duplicate descriptions will still have a good, informative description).
I chatted with @sonnakim about the wording of the description, and she thought it sounded good. @virginiacc, how does that look to you as someone from the original team who knows a lot more about these agreements than I do?

Checklist

[x] PR has an informative and human-readable title
[x] Changes are limited to a single goal (no scope creep)
[x] Code can be automatically merged (no conflicts)
[x] Code follows the standards laid out in the CFPB development guidelines
[x] Passes all existing automated tests
[x] Any change in functionality is tested
[x] New functions are documented (with a description, list of inputs, and expected output)
[x] Placeholder code is flagged / future todos are captured in comments
[x] Visually tested in supported browsers and devices (see checklist below :point_down:)
[x] Project documentation has been updated
[x] Reviewers requested with the Reviewers tool :arrow_right:

Testing checklist
Browsers

[x] Chrome on desktop
[x] Firefox
[x] Safari on macOS
[x] Edge
[x] Internet Explorer 9, 10, and 11
[x] Safari on iOS
[x] Chrome on Android

Accessibility

[x] Keyboard friendly
[x] Screen reader friendly

Other

[x] Is useable without CSS
[x] Is useable without JS
[x] Flexible from small to large screens
[x] No linting errors or warnings
[x] JavaScript tests are passing

Ah, good call, @virginiacc. I removed the "most recent" phrase from the description, and I think that will be more universally applicable now. Looks like this one is good to merge now, which I'll do right now.


handle report previewing errors

When requesting the preview of a label template, the response type always is json (either with an error or with the path to a rendered pdf), but when requesting the preview of a report the axios response type is set to blob, because the PDF normally is directly returned as a blob. However if there are some errors, the server returns json format, but axios still parses this as a blob. This PR ensures that the error blob is first parsed as JSON and then the correct error is thrown to be handled by the TemplateEditor. Of course, this mess has to be changed along with some other things if we refactor the label/report API.
fixes #6705

Can you please add a todo in the section we should refactor and a note on. The refactor issue? Currently on mobile

@matmair there is already one, a bit above. Basically the complete function after this comment needs to be refactored then. And if there is previewing without saving on the API available the complete PdfPreview component needs a refactor.

@wolflu05 LGTM!
Also I finally fixed the CORS issues so that the netlify preview works well with the demo server again. It was an absolute nightmare to get running after the update to django 4.2...
Ref: https://github.com/inventree/InvenTree/pull/6712


[Doc Improvement][Grant tab device permission - SBS testing][2643046]

Updated the SBS for UI change and the steps.

Learn Build status updates of commit 0c915f3:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/assets/images/tab-device-permission/upload-custom-app-tab-device1.png
:white_check_mark:Succeeded
View

msteams-platform/sbs-tab-device-permissions.yml
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/sbs-tab-device-permissions.yml
87
9
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Learn Build status updates of commit 9699048:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/assets/images/tab-device-permission/upload-custom-app-tab-device1.png
:white_check_mark:Succeeded
View

msteams-platform/sbs-tab-device-permissions.yml
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

Learn Build status updates of commit 1844520:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/assets/images/tab-device-permission/upload-custom-app-tab-device1.png
:white_check_mark:Succeeded
View

msteams-platform/sbs-tab-device-permissions.yml
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel


added loader animation, to be improved

Hey @yuliia-n,
Something went wrong with the build.
TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.
View build log
TravisBuddy Request Identifier: e054ffa0-19c5-11ea-a744-67689bca182d


Fixes scalar type serialization

This adjusts the default GraphQL scalar types to correctly intake and output objects, and adds tests.
Fixes https://github.com/GraphQLSwift/GraphQL/issues/152

@ZirgVoice, do you mind checking whether this resolves the issue?

@NeedleInAJayStack Yes, that solved the problem.


Responsive Web Design

Can I do this?
I could Add some GSAP controls to it and give it a modern design if in specific part u need design u can specify

Sure, and
Resources for Guidance
Here are some resources that may be helpful as you contribute to CodeHarborHub:

https://www.codeharborhub.live/community/features
Docusaurus Documentation
Markdown Guide
MDX Documentation
Mermaid Documentation

Can U just tell me in which part these are needed as I will not be doing it in hero part much as it is already in a simple good shape

https://github.com/CodeHarborHub/codeharborhub/tree/main/docs/html/responsive-web-design

Sorry,
For the late response I was busy in other scheduled works
I will be contributing regularly from now

Hey @Ajay-Dhangar i have completed this issue please check the pull request #144


feat/example: editable comments plugin

simple javascript plugin for comments integration

r? @krishnaIndia
(maidsafe_highfive has picked a reviewer for you, use r? to override)


Two resources won't load if accessed through Apache's mod_proxy with a prefix

Wonderful program, thanks a lot!!!
I hope this was not already covered, I searched for the issues but couldn't find it.
I have installed HA in a virtual env and I plan to use it behind Apache's mod_proxy. Hence, all resources should be prefixed with the path (which is /ha/ in my case).
Here's the relevant part of my Apache virtual host declaration:
ProxyPass		/ha/	http://<IP_ADDRESS>:8123/
ProxyPassReverse	/ha/	http://<IP_ADDRESS>:8123/

The URL I use is a subfolder of my domain. All resources load but these two:

core-<hash>.js
manifest.json
These two resources are loaded straight from / instead of /ha/

Home Assistant release (hass --version):
0.47.0
Python release (python3 --version):
Python 3.4.2
Component/platform:
Debian 8 jessie
Description of problem:
When loading through apache and mod_proxy, two resources are loaded from the root (e.g. /) instead of the alias (e.g. /ha/)
Example:
Request URL:https://my.server.com/static/core-d4a7cb8c80c62b536764e0e81385f6aa.js
Request Method:GET
Status Code:404 Not Found
Remote Address:x.y.z.y:443
Referrer Policy:no-referrer-when-downgrade
Response Headers
view source

Expected:
The app should request /ha/static/core-d4a7cb8c80c62b536764e0e81385f6aa.js
Note that using a direct access to localhost:8123 or by using an SSH tunnel, it works fine.
Problem-relevant configuration.yaml entries and steps to reproduce:
http:
  base_url: https://my.server.com/ha/

Hmm, I think my Apache vhost conf is buggy. I'll try with mod_proxy and a dedicated subdomain instead. I will update this issue really soon.

I don't know what's wrong with using mod_proxy with a relative path but moving everything to a subdomain definitely fixed the issue.
I had to install mod_proxy_wstunnel and this, though:
ProxyPass		/	ws://<IP_ADDRESS>:8123/
ProxyPass		/	wss://<IP_ADDRESS>:8123/

It would be nice if you could review the current documentation for the Apache Proxy setup an perhaps add your modifications.

I did search the issues but did not search the doc, and I apologize for that.
Thanks


Typescript-bot shouldnt reply to a PR it opened

Fixes https://github.com/microsoft/TypeScript/issues/42803

Agree!


support null safety

I modified the library and make **### Pull reques**t made the adjustments
So that I updated the sdk and ### removed the old libraries and updated them
And I updated the source code to support ### Null Safety
And it became working for me, so I hope to merge my Pull request.
so to add this last edit to your code you can do this :

urwaypayment:
git:
url: https://github.com/osamamohammed98/Flutter_Plugin.git
ref: 82fe454

I modified the library and make **### Pull reques**t made the adjustments So that I updated the sdk and ### removed the old libraries and updated them And I updated the source code to support ### Null Safety And it became working for me, so I hope to merge my Pull request.
so to add this last edit to your code you can do this :

urwaypayment: git: url: https://github.com/osamamohammed98/Flutter_Plugin.git ref: [82fe454](https://github.com/URWAYios/Flutter_Plugin/commit/82fe454110c5a1cdf446f9595b918d88d70cca41)

This last modification works well


Support styled-components v6

Describe the bug
Update to Support Styled Components v-6 which is now supported in stuido-ui

There are also peer dependency warnings during installations


Feature: Embedded/docked DevTools

If you're using the app in fullscreen or fullscreen next to another window, opening DevTools will create a new popup window, separate from the app. This causes DevTools to show up in a different space on MacOS—which is very frustrating to work with. It would make more sense to see the DevTools inside the same window (or at least to have the choice, like you're used to in Chrome).
Case 1: You want to select a certain node inside of a frame, so you want to right-click it and go to "Inspect element", which takes you right to it in DevTools.
Case 2: You want the DevTools to just be open and available while you're working, so you can toggle a button on/off to display it.

Possible solution:
https://github.com/nwjs/nw.js/wiki/Devtools-jail-feature

Looks like this is possible in NWJS if you're trying to open DevTools for a specific WebView. This means the current iFrames would need to be switched to WebView. Not sure about the performance, functional differences. http://docs.nwjs.io/en/latest/References/webview Tag/


Rustup

bump Rust to latest HEAD

@bors r+

:pushpin: Commit ebe5a51336a2b948d100863c8bd8d813a86cce0b has been approved by RalfJung

:hourglass: Testing commit ebe5a51336a2b948d100863c8bd8d813a86cce0b with merge 3f27d8cad65445b2915f06d44b5dfc8f8c1152cc...

:sunny: Test successful - checks-travis, status-appveyor
Approved by: RalfJung
Pushing 3f27d8cad65445b2915f06d44b5dfc8f8c1152cc to master...


[MLIR] Fixed support for mixed data-types in stream-pipeline

This fixes the case where not all loads are pipelined but they have shared dependencies.

Hmm, still need to update the lit test a bit.

@zhanglx13 @scxiao  can you review.


Add myself to release team

Need this permission to manage releases.
Signed-off-by: terrytangyuan<EMAIL_ADDRESS>

/cc @jlewi

@jlewi Could you take a look at this to see if I have sufficient permissions to help out with v1.1 release?

/lgtm
/approve

@jlewi It seems like kubeflow/release-team is not synced with the members specified in org.yaml and I haven't been added to that team automatically. Could you look into it?


mkvtoolnix: 55.0.0 -> 56.0.0

Motivation for this change
Version bump
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[x] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 120522 at 60b30e4e run on x86_64-linux 1

3 packages built successfully:

mkvtoolnix
mkvtoolnix-cli
mpvScripts.convert

3 suggestions:

warning: missing-phase-hooks
installPhase should probably contain runHook preInstall and runHook postInstall.
Near pkgs/applications/video/mkvtoolnix/default.nix:38:3:
   |
38 |   installPhase = "drake install -j $NIX_BUILD_CORES";
   |   ^

warning: missing-phase-hooks
buildPhase should probably contain runHook preBuild and runHook postBuild.
Near pkgs/applications/video/mkvtoolnix/default.nix:37:3:
   |
37 |   buildPhase   = "drake -j $NIX_BUILD_CORES";
   |   ^

warning: build-tools-in-build-inputs
qt5.wrapQtAppsHook is a build tool so it likely goes to nativeBuildInputs, not buildInputs.
Near pkgs/applications/video/mkvtoolnix/default.nix:30:3:
   |
30 |   buildInputs = [
   |   ^


XML parsing error while opening

Debug log ID
QQ48C3PJ-euc/6.7.179-6
What happened?
I would like to open the BetterBibTex Preferences. But I get an error message
XML Parsing Error: undefined entity
Location: chrome://zotero-better-bibtex/content/preferences.xul
Line Number 425, Column 15:
--------------^
I have tried uninstalling and reinstalling the add-on. However, that did not solve the problem. The error message is the same.
Thank you for your support!

AA4PW592-euc/6.7.179-6
I got the same issue

Please try build 6148

That worked.
Many, many thanks for the prompt response to my problem!

That worked.
Many, many thanks for the prompt response to my problem!


Add support for protocol version J2602_1_1.0

Is your feature request related to a problem? Please describe.
I am working on a project where the LDF files use protocol version SAE J2602.
I cannot load the file without manual modification as follows:

Change the protocol version and language version to supported versions.

LIN_protocol_version = "J2602_1_1.0";
LIN_language_version = "J2602_3_1.0";

Remove lines with response_tolerance.

Describe the solution you'd like
I'd like to be able to parse the files without modification.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.

Released in 0.20.0


TurtleBot3 Home Service Challenge

Whilst doing the TurtleBot3 Home Service Challenge. https://emanual.robotis.com/docs/en/platform/turtlebot3/home_service_challenge/
@ <IP_ADDRESS>.
I am having the following error:

Remote PC side:
#!/bin/bash
argc=$#
args=("$@")
if [ 0 -eq $argc ]
then
echo "need to argument that host ip for ssh connection"
echo "Usage: $0 [ip address] ..."
exit 1
fi
for((index = 0; index < $#; index++ ))
do
ssh-keygen -R ${args[$index]}
ssh-keyscan ${args[$index]} >> ~/.ssh/known_hosts
done
Turtlebot3 side:
#!/bin/bash
#check if other turtlebot3_core is already running
is_running=ps ax | grep turtlebot3_core
IFS=' ' read -ra is_runnings <<< "$is_running"
process_name=${is_runnings[4]}
if [ ${process_name} == "python" ]
then
echo "other turtlebot3_core is already running."
exit 1
fi
source /opt/ros/kinetic/setup.bash
source ~/catkin_ws/devel/setup.bash
ip_address=hostname -I
ip_address_trim=${ip_address%% * }
ip_address_no_space="$(echo -e "${ip_address_trim}" | tr -d '[:space:]')"
export ROS_HOSTNAME=${ip_address_no_space}
export TURTLEBOT3_MODEL=waffle_pi
exec "$@"
Somebody can help?

Have you run belows from your Remote PC?
$ chmod +x ~/tb3_ssh_keygen
$ ~/tb3_ssh_keygen <IP_ADDRESS>

and the below from your Raspberry Pi on TurtleBot3?
$ chmod +x ~/env.bash

Did you get any warning or error messages when running the above?

[Remote PC]
Upper left:
$ roscore
[Pi]
Upper right:
$ roslaunch turtlebot3_bringup turtlebot3_robot.launch
[Remote PC]
Middle left:
$ export TURTLEBOT3_MODEL=${TB3_MODEL}
$ roslaunch turtlebot3_manipulation_description turtlebot3_manipulation_view.launch use_gui:=true
[Remote PC]
Middle right:
$ nano ~/tb3_ssh_keygen
$ chmod +x ~/tb3_ssh_keygen
$ ~/tb3_ssh_keygen <IP_ADDRESS>
[Pi]
Lower left:
$ nano ~/env.bash
$ chmod +x ~/env.bash
[Remote PC]
Lower right:
$ roslaunch turtlebot3_home_service_challenge_tools turtlebot3_pi_cam_remote.launch address:=<IP_ADDRESS>

when running the tb3_ssh_keygen command, you should use the IP address of TurtleBot3 SBC as below.
[Remote PC]
Middle right:
$ nano ~/tb3_ssh_keygen
$ chmod +x ~/tb3_ssh_keygen
$ ~/tb3_ssh_keygen <IP_ADDRESS>

Apologies in typing i put  ~/tb3_ssh_keygen <IP_ADDRESS>. However from the picture above it is clear that i have used ~/tb3_ssh_keygen <IP_ADDRESS>. Kindly check

@suyunas
I've tested with my Kinetic setup, but couldn't reproduce the issue.
Have you set the ROS_MASTER_URI and ROS_HOSTNAME for both Remote PC and Raspberry Pi?

nano ~/.bashrc configurations for Remote PC:
alias eb='nano ~/.bashrc'
alias sb='source ~/.bashrc'
alias gs='git status'
alias gp='git pull'
alias cw='cd ~/catkin_ws'
alias cs='cd ~/catkin_ws/src'
alias cm='cd ~/catkin_ws && catkin_make'
source /opt/ros/kinetic/setup.bash
source ~/catkin_ws/devel/setup.bash
export ROS_MASTER_URI=http://<IP_ADDRESS>:11311
export ROS_HOSTNAME=<IP_ADDRESS>
export TURTLEBOT3_MODEL=waffle_pi
TB3:
alias gp='git pull'
alias cw='cd ~/catkin_ws'
alias cs='cd ~/catkin_ws/src'
alias cm='cd ~/catkin_ws && catkin_make'
source /opt/ros/kinetic/setup.bash
source ~/catkin_ws/devel/setup.bash
export ROS_MASTER_URI=http://<IP_ADDRESS>:11311
export ROS_HOSTNAME=<IP_ADDRESS>

@suyunas
Your network configuration looks correct.

'Be sure Remote PC and TurtleBot3 are connected under the same IP'. This statement is a bit confusing on Home Service Challenge. how can we keep IP same for two separate devices?

Sorry about the confusion. This means to configure your IP address in the same IP range, such as 192.168.43.xxx
TB3 HSC is currently supported with Kinetic which runs on Ubuntu 16.04 or the provided Raspbian OS image from us.
Please try below command and let me know. This will copy the SSH key to TurtleBot3 SBC.
$ ssh-copy-id<EMAIL_ADDRESS>

can be seen in the middle right:

@suyunas Apologies for the delayed response. We have assembled a TF team to address OpenManipulator-x issues and are actively working on resolutions. Please note that we do not support EOL (End-of-Life) ROS versions; our support currently extends to Noetic and Humble versions. We kindly ask that you try again with the latest version. If the same issue arises, please feel free to resubmit it, and we will address it promptly.


Save report to file

Right now reqwise will print the report to the console. We should allow to keep the report in a file:
reqwise -o report.txt

@bregman-arie, Is this issue about capturing output from print statements and redirect them to output file as per users' choice ?
If so, existing functionality (which I have not gone thru' fully yet), should be retained as well (i.e. if there are print statement redirecting the output to standard console) ?

@mramanathan yes, if user specified '-o <output_file>' then the output of the logging lines (there is no use of print statements) should be also redirected to a file in addition to console output.
Thanks for the interest.

Hi @bregman-arie, I would like to tackle this issue with your guidance.

Hi @bregman-arie, I would like to tackle this issue with your guidance.

@bregman-arie I have done the fix. How do I run the modified code on local machine to test?

@bregman-arie  can i work on this?

@ShanikaEdiriweera sorry for the late reply. Missed the notification in mail.
Run with 'reqwise -o report.txt' and see if the file created. If yes, send a pull request and I'll merge it :)

@shreab373 sure! thank you :)

I still can run reqwise -o report.txt since issue #6 is still there.

@ShanikaEdiriweera did you run pip install -r requirements.txt from the repo itself?
pypi didn't have latest version. I updated it now.


use information_schema returns Unknown database 'information_schema'

What type of bug is this?
Unexpected error
What subsystems are affected?
Query Engine
Minimal reproduce step

Start a standalone instance
Connect via MySQL client or pg client
run use information_schema

What did you expect to see?
Database changed
What did you see instead?
ERROR 1102 (42000): Unknown database 'information_schema'
What operating system did you use?
doesn't matter
What version of GreptimeDB did you use?
main
Relevant log output and stack trace
No response

The bug related to https://github.com/GreptimeTeam/greptimedb/blob/627a3262735eaa490cee8dadf413b61a04948d16/src/frontend/src/instance.rs#L357-L364 @J0HN50N133  Would you like to take a look 👀

I've addressed the bug. Could I fix it later this weekend? The is_reserved_schema_name check should only be done when creating new database/schema.

duplicate #4762


Support projectId for cloud functions

I was following https://firebase.google.com/docs/firestore/solutions/schedule-export in order to export my firestore database, and I noticed that my projectId was undefined (resulting in TypeError: Cannot read property 'charCodeAt' of undefined from google-gax).
Don't know exactly when GCP_PROJECT is populated, but with this fix GCLOUD_PROJECT will be picked up for the cloud functions 🏄♂

@googlebot I fixed it

@michelepatrassi thanks!  This change LGTM.  I think GCP_PROJECT is outdated/unused but it's possible it's still set in some situations and this doesn't cause any harm.


Incremental improvements for migration docs

Some incremental improvements for migration docs:

Some introduction for where Otel comes from and why we provide oc & ot migration (copied some of your words @aabmass, hope that's OK :))
Also some words about jaeger (copied from the jaeger docs (cc @pavolloffay) & @jpkrohling blog post)
Linked to the spec for OpenCensus for now, not sure if this works in the long run and if we might need a separate migration guide like we have one for ot

Looks like there's another formatting push to make here 🙃

Looks like there's another formatting push to make here 🙃

@cartermp - the formatting seems file (the action is passing) -- unless I missed something. Were you referring to the link-check failure?


Upgrade bitshuffle to v0.3.1

This pr is along with https://github.com/kiyo-masui/bitshuffle/pull/58

OK. I'll build native libraries with bitshuffle 0.3.1

@maropu building native libraries for 64-bit cpu types fails. Could you check what is wrong?
$ make linux64                                                                   [10:45:26 Feb 06 2017]
docker run --rm -ti -v $PWD:/work xerial/centos5-linux-x86_64-pic bash -c 'make clean-native native OS_NAME=Linux OS_ARCH=x86_64'
Makefile.common:6: Set JAVA_HOME environment variable
/bin/sh: /bin/java: No such file or directory
/bin/sh: /bin/java: No such file or directory
/bin/sh: /bin/java: No such file or directory
find: invalid predicate `'
rm -rf target/snappy-1.1.4-Linux-x86_64
g++ -Ilib/inc_linux -I/include -O2 -fPIC -fvisibility=hidden -m64 -Ilib/include -Itarget/snappy-1.1.4 -Itarget/bitshuffle-0.3.1/src -c target/snappy-1.1.4/snappy-sinksource.cc -o target/snappy-1.1.4-Linux-x86_64/snappy-sinksource.o
g++ -Ilib/inc_linux -I/include -O2 -fPIC -fvisibility=hidden -m64 -Ilib/include -Itarget/snappy-1.1.4 -Itarget/bitshuffle-0.3.1/src -c target/snappy-1.1.4/snappy-stubs-internal.cc -o target/snappy-1.1.4-Linux-x86_64/snappy-stubs-internal.o
g++ -Ilib/inc_linux -I/include -O2 -fPIC -fvisibility=hidden -m64 -Ilib/include -Itarget/snappy-1.1.4 -Itarget/bitshuffle-0.3.1/src -c target/snappy-1.1.4/snappy.cc -o target/snappy-1.1.4-Linux-x86_64/snappy.o
g++ -Ilib/inc_linux -I/include -O2 -fPIC -fvisibility=hidden -m64 -Ilib/include -Itarget/snappy-1.1.4 -Itarget/bitshuffle-0.3.1/src -U__AVX2__ -msse2 -c target/bitshuffle-0.3.1/src/bitshuffle_core.c -o target/snappy-1.1.4-Linux-x86_64/bitshuffle_core.o
In file included from /usr/include/stdlib.h:438:0,
                 from target/bitshuffle-0.3.1/src/bitshuffle_core.h:42,
                 from target/bitshuffle-0.3.1/src/bitshuffle_core.c:12:
/usr/include/sys/types.h:198:1: error: conflicting declaration 'typedef long int int64_t'
 __intN_t (64, __DI__);
 ^
In file included from target/bitshuffle-0.3.1/src/bitshuffle_core.c:12:0:
target/bitshuffle-0.3.1/src/bitshuffle_core.h:39:31: error: 'int64_t' has a previous declaration as 'typedef long long int int64_t'
   typedef long long           int64_t;
                               ^
make: *** [target/snappy-1.1.4-Linux-x86_64/bitshuffle_core.o] Error 1
make: *** [linux64] Error 2

okay, I'll check.

okay, I checked this worked well in linux64.

Thanks! Merged in #164


adds back .form-text

This PR adds back .form-text css class.

deploy preview
closes https://github.com/twbs/bootstrap/issues/30477

@MartijnCuppens I would like to add a $form-text-color: $text-muted !default; too, what do you think?
Also, what should we do about docs? I think we should remove references about .help-block in v3 that comes from an older version.

@MartijnCuppens I would like to add a $form-text-color: $text-muted !default; too, what do you think?

Yup! A font size variable may also be appropriate, maybe a null font-style variable.

Also, what should we do about docs?

Use .form-text where needed.

I think we should remove references about .help-block in v3, text that comes from an older version docs.

Yup.

Tnks for feedback!
Updated & done. What do you think?

Could you add a font-style (default: null)?

Yep, just a sec.
Also I saw a glitch there on a var naming.

Done

Rebased


build: regenerate parser with tree-sitter v0.20.9

It turns out that using the latest treesitter version isn't automatically better. Closing.


add as packagist for public use via composer

Could you please add it to packgist.org so I can use it via composer require?

There is no need for packagist, for October plugins that published at marketplace.
try composer require reazzon/jwtauth-plugin

I know, but in this case I don't use the project linked to the marketplace.

Understood. Done.
https://packagist.org/packages/reazzon/jwtauth-plugin


global configuration

Add support for a configuration file that contains common configuration flags

https://github.com/microsoft/genaiscript/pull/858

VSCode still don't list global scripts

Right, that part still needs work.

Fixed in https://github.com/microsoft/genaiscript/pull/893

support added in 1.78.3


Create CODE_OF_CONDUCT.md

Adopted from contributor covenant

Codecov Report

Merging #17 (23d30f2) into master (1616f65) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master       #17   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            7         7
  Lines          193       193
=========================================
  Hits           193       193

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1616f65...23d30f2. Read the comment docs.


phpcbf is now deprecated, use php-codesniffer instead which contains both phpcs and phpcbf.

Describe the bug
After updating my flake.lock file on 02/27/2024 I'm unable to perform a nixos-rebuild without getting the error:
"phpcbf is now deprecated, use php-codesniffer instead which contains both phpcs and phpcbf"
I'm unable to see what is pulling this in so any advice on how to track this down would be helpful.
Steps To Reproduce
Steps to reproduce the behavior:

In a terminal, execute a "nix flake update".
Attempt a nixos-rebuild.

Expected behavior
I was expecting my system to rebuild without errors as I haven't changed anything since the last successful rebuild aside from my flake.lock file.
Screenshots

Metadata
Please run nix-shell -p nix-info --run "nix-info -m" and paste the result.

I am also having that issue. I can't even install packages now without nix-env

Did you try --show-trace?

duplicate of https://github.com/nix-community/nixvim/issues/1160

Thanks!  Sorry this was in the wrong place.  I realize it is technically a build error and not a bug, but I just couldn't pinpoint the responsible package.  I will try --show-trace with issues in the future.


[Feature] Improve ci trigger and cancel

Search before asking

[X] I searched in the issues and found nothing similar.

Motivation

Multiple commits of the same PR require cancellation of the previous testings
The master merged commits cannot cancel the previous testing

But #883 broke the requirement ②.
Solution
No response
Anything else?
No response
Are you willing to submit a PR?

[ ] I'm willing to submit a PR!

Assign to me, i will fix this error .

Here is what I use for my projects that can fix the issue:
# Concurrency strategy:
#   github.workflow: distinguish this workflow from others
#   github.event_name: distinguish `push` event from `pull_request` event
#   github.event.number: set to the number of the pull request if `pull_request` event
#   github.run_id: otherwise, it's a `push` or `schedule` event, only cancel if we rerun the workflow
#
# Reference:
#   https://docs.github.com/en/actions/using-jobs/using-concurrency
#   https://docs.github.com/en/actions/learn-github-actions/contexts#github-context
concurrency:
  group: ${{ github.workflow }}-${{ github.event_name }}-${{ github.event.number || github.run_id }}
  cancel-in-progress: true

Here is what I use for my projects that can fix the issue:
# Concurrency strategy:
#   github.workflow: distinguish this workflow from others
#   github.event_name: distinguish `push` event from `pull_request` event
#   github.event.number: set to the number of the pull request if `pull_request` event
#   github.run_id: otherwise, it's a `push` or `schedule` event, only cancel if we rerun the workflow
#
# Reference:
#   https://docs.github.com/en/actions/using-jobs/using-concurrency
#   https://docs.github.com/en/actions/learn-github-actions/contexts#github-context
concurrency:
  group: ${{ github.workflow }}-${{ github.event_name }}-${{ github.event.number || github.run_id }}
  cancel-in-progress: true

thanks for your suggestions, i will try this.


Update configure-storage-policy.md

Clarifications due to customer feedback

@thinkdavid : Thanks for your contribution! The author(s) have been notified to review your proposed change.


Add missing indices for dashboard #3175

external_sources.visualization_id
visualizations.permission_id

cc/ @javisantana @juanignaciosl

Frontend tests were OK :+1: (details)

:+1:

DIOS TE VA A PAGAR ESTE PR


Propose graduation to pre-prod maturity phase

I propose that we move this project to the pre-prod maturity level. I have been over the qualifications and believe that this project now meets the minimum bar.
@spiffe/ssc can you please review and take this move under consideration? I'm happy to provide links or answer questions.

LGTM

what's the hack folder for? https://github.com/spiffe/spire-controller-manager/blob/main/hack/boilerplate.go.txt . Something misbehaving for licensing / github?

It seems to be a convention adopted by various Kubernetes related projects. I'm not quite sure what the intended use is for but regardless need it for kubebuilder tooling to function.

Ubiquitous hacks. The ultimate sign of project maturity 😄
Everything else looks good to me for preprod 🎉


Watson API URL changed

I happen to stumble on a bug that is caused by incorrect Watson API address, perhaps because URL is migrated.
The code below is where the bug in the file com.ibm.personafusion.Config is, and the fix (that seems to work)
<---------------------CODE------------------------>
package com.ibm.personafusion;
import com.ibm.personafusion.db.CloudantClient;
public class Config
{
/** Cloudant **/
public static final int CLOUDANT_PORT = 443;
public static final String CLOUDANT_NAME = "talent-manager";

/** Watson User Modeling **/

public static final String WATSON_PROF_API =  "/v2/profile";
public static final String WATSON_VIZ_API = "/v2/visualize";

/* OLD
public static final String WATSON_PROF_API =  "/api/v2/profile";
public static final String WATSON_VIZ_API = "/api/v2/visualize";*/

public static CloudantClient cc = new CloudantClient();
/* Mobile Data Config */
public static final String MOBILE_DATA_APP_ID = "";
public static final String MOBILE_DATA_APP_SECRET = "";

}

@bookpbk If you see a bug and have a fix you should open a PR!


[CI] Handle Github Actions warning

Warning: The `save-state` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

Impacted plugins:

battila7/get-version-action@v2
<EMAIL_ADDRESS>https://github.com/criblio/appscope/pull/1137

Action Required

updating the GitHub runner software version used in self-hosted runners is necessary because on self-hosted runners are we missing the GITHUB_OUTPUT environment file commands
The version used by the self-hosted runners is 2.287.1
The version containing support for GITHUB_OUTPUT is 2.297.0
[Edit] Above was done.

The total number of warnings was reduced - the one remaining is coming from battila7/get-version-action@v2
https://github.com/criblio/appscope/actions/runs/3335215945
Summary view:

https://github.com/criblio/appscope/actions/runs/3339182866
Summary view:

Fixed in #1134


Preserve image input value after validation failed and returned to page

This feature can't be realized due to security issue, initializing file input with a certain file path is not supported by browsers due to security concern: If value of a file input is initialized with a certain file path, a website can potentially get a confidential document, for example, a password.txt file, from an user's computer. Consider the following example:
<input type="file" name="get-users-password-file" id="get-users-password-file" value="C:\password.txt" />

This issue is closed due to the reason above.


Use consistent max-width on HomeHero iPad

The type of this PR is: Bugfix
This PR resolves MX-405
Screenshots
Before

After

LGTM 🎉


[Not intended to land] Dummy benchmark for platform view scroll and ads banner

Not intended to land. Just a dummy benchmark while working on platform view performance issues.
Based on https://github.com/lucalooz/flutter_ads_list_perf from https://github.com/flutter/flutter/issues/129632, except that I don't use real AdMob (since it's a non-flutter-org repo).
Also I used 320x50 standard banner size, so I can fit 7-8 banners on screen, which should be enough (i guess?).
Feel free to use it when working on platform view performance.
Under devicelab, run
../../bin/dart bin/run.dart --local-engine=ios_profile_unopt --local-engine-host host_profile_unopt -t platform_views_scroll_perf_ios_ad_banners__timeline_summary

Closing in favor of https://github.com/flutter/flutter/pull/145224


Using 'excludedRooms' property in dungeons.yml excludes all cloned versions of that room.

For example if I had a room
forestcrypt_new_Burialchamber05:Darkwoods
And I add this to my dungeon
excludedRooms:forestcrypt_new_Burialchamber05
It also prevents the clone from being selected too.

Moved it to the expand_world main mod github, my bad, did issue in wrong place,


Clean-up model crate a bit

Flatten module structure (get rid of cfd.rs module)
Extract more sensible modules
Move tests out into "integration tests" so we can organise those into different files

@luckysori Can we close this as a result of #1439 and continue that work in a different issue?

Sure, let's do that!


Allow deployment with a single hostname

The requirement for wildcard hostnames and TLS certificates is causing problems. We should see if we can eliminate it, at least as an option. Possibilities are:

Using paths below the root URL, e.g. https://my.fp/configdb. The F+ services are supposed to support this, though I don't know if all the ServiceClient libraries implement it correctly. I don't know if third-party components like Grafana will support it.
Using ports. This would be crude, and would definitely require links (at minimum) from the new Admin interface.

Possibly a combination of the two might be needed.

This would be of interest for us with RR SMR, as it would allow access to the grafana dashboards without having to edit the hosts file of devices. Which is undesirable and even in the case of iPads impossible.
Users Story
End user should be able to access their data dashboards from a simple link on an unmodified device. Thus QR or other markers could be scanned in around the site to bring up relevant dashboards.


Feature: Add Support for Floatable Status Bar Content

Summary
This PR adds support for making the status bar content floatable.
Changes Made

Added settings for enabling/disabling the floating view.
Added a timeout option for when floating is enabled.

TODO
N/A
Motivation
The primary goal is to achieve a cleaner design.
Testing

Tested enabling and disabling the floating view.
Tested the visibility timeout when floating is enabled.

Screenshots/GIFs

https://github.com/user-attachments/assets/8d2e30b0-0804-47fd-83e2-f1a915762f4a
Checklist
Please ensure all of the following are completed before submitting the PR:

[x] Code has been tested and verified.
[x] Documentation has been updated to reflect the changes.
[x] All tests pass successfully.
[x] Code follows the project's coding guidelines and style.
[x] The branch is up-to-date with the latest changes from the main branch.
[x] Reviewed by at least one other contributor.

Related Issues
This PR addresses the following issue(s): N/A
Additional Notes
N/A

Thanks for submitting a pull request!
We will review it as soon as possible.

If no auto hide is set, it does not show never, you need to select it before you see never.

Moving                 Text("Never").tag(0) to top seems to resolve the issue for me.

Hey @nanashili,
Thanks for your contribution.
Your PR has been merged!
Your name will appear on https://auroraeditor.com/#contributors in a few moments, if you have contributed to the editor.
Thanks again for your contribution!
Kind Regards,
Aurora Editor Team.


physical-plan: Cast nested group values back to dictionary if necessary

Which issue does this PR close?
Closes https://github.com/apache/datafusion/issues/12542
Rationale for this change
Non-nested arrays were already being dictionary encoded again if the input was dictionary encoded, so this just replicates that behavior for structs and lists.
What changes are included in this PR?

Check whether there are any nested dictionaries to encode.
Encode arrays that have nested dictionaries appropriately.

Note this may not be conclusive, I've only included lists and structs since those are the cases/types that I need and that I'm most familiar with. I think it'd be nice to get these changes in though and handle any further cases in separate PRs.
Are these changes tested?
Yes, added a unit test that tests precisely the scenario that led me to opening the issue.
Are there any user-facing changes?
No, only a bug fix. If the queries didn't panic before it could have been a change in behavior, but since all queries of this sort panicked before it's purely a bug fix.
@alamb @tustvold @andygrove

Fixed all lints. Can you re-run tests?

BTW the code looks 👨🍳  to me -- once the CI passes I think this will be good to go
Also, once we have merged this CI runs on your future PR will run automaticallly

Huh weird, that last lint didn't fail for me locally, fixed it.

I'm really sorry, I think now it should truly be the last time that you need to re-run. I fixed it exactly the way clippy suggested.

Another thing that would make it slightly easier to review these PRs is if you pushed new commits rather than force pushing

All PRs get squash into a single commit on merge, so the commit history isn't preserved but makes it easy to see what has changed since the last revie

Got it!


Fix fix fe ut failed cause of getting statement context

Proposed changes
Problem:
fe ut failed cause of null pointer error
Cause:
fe ut getting statement context from connection context failed
Resolved:
add null pointer judgement

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall


Songs title needs to be truncated

**In smaller screens, the title of song becomes so large and makes the track card so big. **
To Reproduce
Steps to reproduce the behavior:

Add songs with big title
See error

Expected behavior
Truncated or trimmed text
Screenshots

Done!


[SUPPORT] Tinyint and small int data types

Currently, the avro schema does not support tinyint and smallint datatypes, but Hudi uses the avro schema as bridge of user DDL schema and parquet schema, we should fix that.

can you create a jira directly. and close the github issue.

issue created: https://issues.apache.org/jira/browse/HUDI-3608


Add Balena Block and update Icons

Resolves #11.

Codecov Report

Merging #20 (2469c75) into main (4009b57) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #20   +/-   ##
=======================================
  Coverage   55.42%   55.42%
=======================================
  Files          39       39
  Lines         415      415
  Branches       57       57
=======================================
  Hits          230      230
  Misses        170      170
  Partials       15       15

Impacted Files
Coverage Δ

...volkovlabs-balenaservice-panel/icons/container.tsx
66.66% <ø> (ø)

src/volkovlabs-balenaservice-panel/icons/image.tsx
66.66% <ø> (ø)

...c/volkovlabs-balenaservice-panel/icons/release.tsx
66.66% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4009b57...2469c75. Read the comment docs.


Short solution needed: "Logistic regression" (python-scikit-learn)

Please help us write most modern and shortest code solution for this issue:
Logistic regression (technology: python-scikit-learn)
Fast way
Just write the code solution in the comments.
Prefered way

Create pull request with a new code file inside inbox folder.
Don't forget to use comments explain solution.
Link to this issue in comments of pull request.

Logistic regression


Add code review gpt workflow

https://github.com/mattzcarey/code-review-gpt

@mkondratek what do we do with this one? 🤔

@mkondratek what do we do with this one? 🤔

idk. I had no time to retake a look. Let's leave it for a while. Maybe I will get a chance soon.

porządki pourlopowe


Fix misplaced access list and state db

How was it fixed?
Remove Message.access_list and replace Computation.state_db with Computation.vm_state.state_db
Cute Animal Picture

Just for helping me understand this PR, am I right that there exist three expressions:

Type-original: with computation.vm_state.state_db(read_only=True) as state_db means  state_db = computation.vm_state._chaindb.get_state_db(state_root, read_only=True)
Type-access-list: with computation.state_db(read_only=True) as state_db means with computation.vm_state._chaindb.get_state_db(state_root, read_only=True, access_listcomputation.msg.access_list) as state_db
Type-property: state_db = computation.vm_state.read_only_state_db means state_db = computation.vm_state._chaindb.get_state_dbstate_root, read_only=True)   # equals to Type-original with argument.

I recalled that you said you also would override @contextmanager def state_db(...) in sharding/vm_state.py, and it seems you changed your mind and decided to modify evm/vm/forks/sharding/computation.py?
If the two lines in evm/vm/forks/sharding/computation.py are the only place that we use Type-access-list expression, I think we can remove Type-access-list with Type-original because  Type-access-list doesn't explicitly indicate that it's with access_list, but that's just my opinion.

Sorry I forgot to update the description after pushing new commits.
After @hwwhww point out, I realize that Computation.state_db can not be removed(which is what I did before update - I replaced Computation.state_db with Computation.vm_state.state_db) because VMState.state_db in Sharding requires Computation.state_db to pass in access_list to it.
## /vm/forks/sharding/computation.py
def state_db(self):
    return self.vm_state.state_db(self.msg.access_list)

So the branch name is kind of misleading as no access_list and state_db is really misplaced. Sorry about that.
I keep the state_db in Computation.(In ShardingVM version it passes an extra access_list into vm_state.state_db). And then split state_db into read_only_state_db and mutable_state_db
One problem is that vm_state.read_only_state_db in ShardingVM is different from the one in other VMs. It's not made a property since it requires passing in an additional access_list argument.
## evm/vm_state.py
@property
    def read_only_state_db(self):
        return self._chaindb.get_state_db(self.state_root, read_only=True)

## usage
state_db = vm_state. read_only_state_db

## /vm/forks/sharding/vm_state.py
def read_only_state_db(self, access_list=None):
        return self._chaindb.get_state_db(
            self.state_root,
            read_only=True,
            access_list=access_list,
        )

## usage
state_db = vm_state. read_only_state_db()

@pipermerriam @hwwhww Kindly asking for a review again. Sorry for the trouble!

Makes sense.
For VMState.get_state_db, I will also have to update eth-tester as it currently uses vm_state.state_db.
Or continue using VMState.state_db instead?

Or continue using VMState.state_db instead?

No, we should change the API and then change eth-tester to use the new API.  I think we pinned eth-tester to an exact py-evm version so this shouldn't break things.

@pipermerriam sorry I might have missed something, but I still can't figure out how to get a read_only_state_db and a context managed mutable_state_db with only context managed vm_state.get_state_db
this is vm_state.get_state_db(…)
    @contextmanager
    def get_state_db(self, read_only):
        state = self._chaindb.get_state_db(
            self.state_root,
            read_only,
        )
        yield state
        ...

this is the computation.mutable_state_db(…) which is context manageable
    @property
    def mutable_state_db(self):
        return self.vm_state.get_state_db(read_only=False)

but for computation.read_only_state_db(…)
this will return a _GeneratorContextManager object just like mutable_state_db
    @property
    def read_only_state_db(self):
        return self.vm_state._chaindb.get_state_db(
            self.vm_state.state_root,
            read_only=True,
        )

if we use with statement, it will return the real state_db object, however it will be cleaned up by the time the state db is used.
    @property
    def read_only_state_db(self):
        with self.vm_state._chaindb.get_state_db(
            self.vm_state.state_root,
            read_only=True,
        )  as state_db:
            return state_db

@NIC619 I think you may be right that there may not be a good way to do this.  Can you explore what the minimal API we can get away with is?  Something that is ideally consistent with naming conventions and how it's used?  The Computation object could simply implement pass-through methods which delegate down to the VMState AIPs.
I have a feeling that a lot of the database access patterns are going to be refactored soon as I'm starting to see how they can be reworked in some ways to make all of this cleaner and less entangled.

@pipermerriam After re-evaluation, it seems to me that splitting state_db into read_only_state_db and mutable_state_db might not worth the effort.
To recap: the goal is to turn the read only state_db into a property so it does not need to be context managed. We do it by splitting state_db into read_only_state_db(a property) and mutable_state_db(context managed).
But this results in bloated *_state_db APIs.
(1) Computation.read_only_state_db and Computation.mutable_state_db are needed because access_list is added in Sharding and it is stored in Computation.msg. So unless we allow VMState to access access_list directly, we need Computation.*_state_db as an additional wrapper to pass in access_list.
(2) VMState.get_state_db is context managed and so Computation.read_only_state_db would also be context managed which fails our goal. Hence we still need two state_db APIs in VMState - VMState.read_only_state_db(a property) and VMState.mutable_state_db(context managed).
This will inevitably result in 8 *_state_db APIs in evm/computation.py , evm/vm_state.py, evm/vm/forks/sharding/computation.py and evm/vm/forks/sharding/vm_state.py.
Considering these trade-offs IMO it's not worth the effort to split the state_db.

That's fine.  I think we're going to be doing a significant refactor to most of this stuff in the near term future.  I'm fine leaving as-is, or doing whatever the minimal thing that's needed is.


Add a CONTRIBUTING file.

Ahh, just saw this in ./docs/contributing.md. For better compatibility with open source projects, should we be using ./CONTRIBUTING.md instead? Happy to merge these two, either way.

Ahh, just saw this in ./docs/contributing.md. For better compatibility with open source projects, should we be using ./CONTRIBUTING.md instead? Happy to merge these two, either way.

I think we want to keep the docs/contributing.md file around so that it still generates a page on the site https://brisk-docs.netlify.com/docs/contributing/
Maybe we could use the root CONTRIBUTING.md file as the source of truth, and make docs/contributing simply a transclude of the root file?

Maybe we could use the root CONTRIBUTING.md file as the source of truth, and make docs/contributing simply a transclude of the root file?

That's sort of what I was thinking. Happy to do that as part of this.

Hello!
Just thinking about this - this link won't work on the website. Can we remove it from the readme.md


Added completeness checking store

Description
The proto promises that all results will exist in the CAS when requested using the associated actions. However we currently allow stores to prune themselves which violates this condition, because the action cache and CAS are different. Therefore we need this completeness checking store to check that all results exist in the CAS before we allow the the action result to be returned to the client.
Fixes #358 #362
Type of change

[x] New feature (non-breaking change which adds functionality)

How Has This Been Tested?
Added test where all files are present in the cas causing completeness to succeed and another where the cas does not have all of the files causing completeness checking to fail.
Checklist

[x] Updated documentation if needed
[x] Tests added/amended
[x] bazel test //...  passes locally
[x] PR is contained in a single commit, using git amend see some docs

This change is

The algorithm is has_with_results does parallelize but may be sub-optimal based on how has checks of digests is done.


World Respawn Incorrect

I currently have Multiverse 2.2-AB running on my R3 Bukkit server with the following plugins running on the server:
MagicTorches, Plugman, ScheduledAnnouncer, VoxelSniper, Vault, Multiverse-Core, RemoteToolkitPlugin, StopTalkingAutoBan, VoxelUpdate, Craftpedia, vanish2, NoLagg, SkylandsPlus, Votifier, MobDisguise, CleanroomGenerator, WhoMode, SimpleBackup, MultiInv, Minequery, WorldEdit, Towny, VoxelMore, Multiverse-NetherPortals, PermissionsEx, Questionier, AutoRank, WorldGaurd, MCSL, iConomy, RealAdminTools, VoxelMimic, VoxelAir, NoCheat, Announcements, Herochat, FalseBookCore, VoxelPort, Essentials, AnCasino, Register, Permissions, FalseBookIC, Citizens, TownyChat, dynmap, Dynmap-WorldGaurd, Dynmap-Factions, HawkEye, Dynmap-CommandBook, ChestShop, Dynmap-Towny, dynmap-mobs
I know thats alot of plugins but the owner insist upon them, I am merely the tech, but for a while I set the spawn with /mvm set spawn and the world(Creo) had the correct respawn even on death, then one day I noticed that dynmap started reporting a ndifferent spawn location, and even i I set the respawn to a different world of the same world, players spawn in the middle of nowhere, but /mvtp Creo takes me to the right spot. Any ideas or suggestions?
EDIT: Forgot to add this http://pastie.org/private/ycgzn6k2i9fckjhqpwxdya
EDIT2: And heres the startup log http://pastie.org/3353527

Forgot to add this: http://pastie.org/private/ycgzn6k2i9fckjhqpwxdya

Well with the newest version of Essentials the EssentialsSpawn is in its own Jar file, that we don't even have uploaded to the server, so the spawn and setspawn commands dont work

Perhaps I misread.... Are you wanting players to spawn in a different world from the one they died in?

No, what happened is that like a week after being on the world (Creo), the Spawn reported on dynmap moved, and now if you do /mvspawn you go to the correct spot, but if you die, then you go to the wrong area, in the middle of someones old house actually :P but even if I do a /mvremove or /mvunload and reimport the world, and reset the spawn and respawn, it takes you to the same incorrect location upon death, and I don't think people would be happy with having to delete the world :/

I am not sure what could have caused this, or what to do about it, its just inconvenient to ask my players to do a /mvspawn everytime they die.

Please update to the 2.3-AB and see if that fixes anything. We fixed a lot of bugs in 2.3.


[BEAM-13115][Playground] Security – Mock Storage

Added mock storage via volume isolation with tmpfs for Beam Playground Backend.

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[x] Choose reviewer(s) and mention them in a comment (R: @username).
[x] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

R: @tvalentyn


Error returned differently depending on connection creation sequencing

Demonstration code: https://gist.github.com/otoolep/9b08999a14401ce62ba0b1106a36f8b5
I see QueryContext sometimes return an error, and sometimes not, depending on when a connection is created. If a connection to a database is created before a table is deleted SELECT * FROM foo encounters an error during row scan, and QueryContext does not return an error. If the connection to the database is created after the table is deleted, SELECT * FROM foo is returned by QueryContext.
Is this expected? If so, why?
$ ./simple 1
2021/08/04 09:01:30 rows.Err: no such table: foo
$ ./simple 2
2021/08/04 09:01:31 QueryContext2: no such table: foo

I this issue while debugging unit test failures for https://github.com/rqlite/rqlite/pull/842 and reduced it to (I think) the demonstration code above.

Does the issue also happen if you use a normal database file instead of memdb?
My guess is that SQLite is reading the original database schema at some point during the initial connection creation. In the first case, that was before the table was dropped, so it doesn't notice the problem until sqlite3_step runs. Meanwhile, in the second case, the original schema already didn't have the table, so sqlite3_prepare_v2 itself fails.
I'd be curious to see the results for the reverse situation - a table that gets added after the connection is created.
Also, as an unrelated side note, you should add _fk=1 to the DSN in your production code if you intend to use foreign keys, as SQLite does not enforce them by default.

Yes, happens with on-disk too: https://gist.github.com/otoolep/3b495661353f9e9be5230531aaff6b27

The reason I care about the difference is that the different behavior changes what rqlite HTTP API returns, and I don't want to change the API since that would be a breaking change. I can always work around this issue by modifying the API response to ensure it's the same as previous releases.

@rittneje -- I'm ok with closing this issue. My main concern was that I might have a bug in my code, but since I can reproduce in a simple example, maybe it's just the way SQLite works. I'm sure if we dug into the SQLite code itself we'd learn for sure. I can code around it.
I wonder if it's related to https://www.sqlite.org/c3ref/table_column_metadata.html, which implies some metadata associated with each connection.
This function causes all database schemas to be read from disk and parsed, if that has not already been done, and returns an error if any errors are encountered while loading the schema.


Add debugging information to flaky test

What was the end-user problem that led to this PR?
The problem was that last master build failed with a test failure I had never seen: https://travis-ci.org/bundler/bundler/jobs/538089338.
What was your diagnosis of the problem?
My diagnosis was that this failure is indeed order dependent, since it only appeared after enabling test suite randomization. BUT, this failure is not consistently reproducible.
What is your fix for the problem, implemented in this PR?
This PR does not fix the problem. It only adds some debugging information, so we have more information to figure this out when it happens again.
Why did you choose this fix out of the possible options?
I chose this ~fix~ change because it's no clear to me why this happened or how to fix it.

@bundlerbot r+

I’m a little worried that the let might cache the result of the select and produce unexpected results later, but it should work regardless for this particular test.

You are right, this kind of thing is better to compute every time you need it.
I actually saved it in a local variable initially, but then I thought that since this information was only relevant in the sad path, it was better to not compute it every time. However, after a second thought, I think you are right. Should I move it back to a local variable inside the test body?


Unhandled rejection Error: Cannot find module './aurelia-templating-resources/

I recently started facing an issue with running my Aurelia app without making any code changes. The error that i am facing in my development console is -- Unhandled rejection Error: Cannot find module './aurelia-templating-resources/compose' . Can anyone help me out with the same.
I have successfully run the npm update and npm install commands, It updated my bluebird dependency, but still facing with the same issue when having my aurelia-templating-resources dependency already existing in my package.json.

This looks like a problem with an earlier version of the webpack skeletons. All this should be solidly worked out in the latest skeletons.


[USER] GLADHOST

What is your company name?
GLADHOST
What is the focus of your company?
Web hosting
Please provide the URL to your company homepage:
https://gladhost.cloud
Please link us to a hosted copy of your company logo to include in the README:

Additional context

your logo is transparent and the Gladhost text is invisible on github's dark mode. If you prefer a white background, please upload a png to this issue and reopen it. otherwise, I'll assume the logo you provided is what you want to use.


Add experimental support for loading .safetensors models

As the title says, this PR adds experimental support for loading models in safetensors format; I call it experimental because, even if it technically works, I've noticed that rebuilding the pipeline a couple of times, for example by enabling/disabling ControlNet, causes RAM usage to increase considerably making it impractical for its use on low-end PCs.
Some other things to note in this PR:

Loading safetensors models only works in LCM-LoRA mode, I think it's the only mode where it makes sense.
LCM-LoRA mode was always considerably slower than plain LCM mode on my machine, about 50% slower, I always thought that it was a speed hit from the LCM-LoRA mode itself but I noticed that by commenting this line:
pipeline.unet.to(memory_format=torch.channels_last)
inference speed automatically became much better. Is there any particular reason why this line is used?.
By going further and always fusing the LCM-LoRA with the base model, inference speed in LCM-LoRA mode gets almost as fast as inference speed in plain LCM mode.

As the title says, this PR adds experimental support for loading models in safetensors format; I call it experimental because, even if it technically works, I've noticed that rebuilding the pipeline a couple of times, for example by enabling/disabling ControlNet, causes RAM usage to increase considerably making it impractical for its use on low-end PCs.
Some other things to note in this PR:

Loading safetensors models only works in LCM-LoRA mode, I think it's the only mode where it makes sense.
LCM-LoRA mode was always considerably slower than plain LCM mode on my machine, about 50% slower, I always thought that it was a speed hit from the LCM-LoRA mode itself but I noticed that by commenting this line:
pipeline.unet.to(memory_format=torch.channels_last)
inference speed automatically became much better. Is there any particular reason why this line is used?.
By going further and always fusing the LCM-LoRA with the base model, inference speed in LCM-LoRA mode gets almost as fast as inference speed in plain LCM mode.

@monstruosoft  I think we can keep the original workflow(auto download model from HF) as it is. We can add a setting like use_single_file_model and it will enable this single file workflow so it will not break any existing implementation.

pipe = pipeline_class(
TypeError: StableDiffusionPipeline.init() got an unexpected keyword argument 'text_encoder_2'
I tried to load sd_xl_base_1.0.safetensors
It loads fine the same model as diffusers
Am i missing something?

Sorry, should have mentioned that this PR works only for SD 1.5 models. A similar code should work for SDXL but unfortunately I can't run SDXL on my machine.

@monstruosoft Going to merge this PR


Thanks & Hi from the Steampipe team!

Hi @dihedron - Great to see you working on an OpenStack plugin for Steampipe!
Looks like you've made great progress, but please reach out in our Slack community if you have any questions about plugin development. We also have a checklist of plugin best practices you may find helpful.
We'd also love to collaborate with you to get this plugin reviewed & listed on the Steampipe Hub so people can find it, use it and hopefully contribute as well - I'm sure it will be useful for others! Let us know how we can help :-)

Cool, I've been working on many things related to Steampipe lately and I will surely reach out once my PoC has achieved the critical mass to become something that can be used outside of my limited use case. I'm glad to give back.

Sounds good - thanks!


[BEAM-6605] Deprecate TextIO.readAll and TextIO.ReadAll transform

I also rewrote code to depend directly on ReadFiles instead of ReadAll for consistency (but kept ReadAll in the unit tests so we notice if somehow it breaks).
R: @chamikaramj

Run Java TextIO Performance Test

LGTM. Thanks.


Dispatcher queue fix

Have dispatcher track the queue value rather than the time placed in queue.

Codecov Report

Merging #42 (f685386) into master (d967ad6) will increase coverage by 0.40%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #42      +/-   ##
==========================================
+ Coverage   60.90%   61.30%   +0.40%
==========================================
  Files         115      115
  Lines        9861     9863       +2
==========================================
+ Hits         6006     6047      +41
+ Misses       3855     3816      -39

Impacted Files
Coverage Δ

assemblyline/remote/datatypes/queues/priority.py
75.78% <100.00%> (+0.52%)
:arrow_up:

assemblyline/odm/randomizer.py
94.33% <0.00%> (-0.48%)
:arrow_down:

assemblyline/datasource/alert.py
92.30% <0.00%> (+3.84%)
:arrow_up:

assemblyline/common/backupmanager.py
76.34% <0.00%> (+16.18%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d967ad6...f685386. Read the comment docs.


BUG(demo-app): Drag and resize in custom handles example does not work well, it gets interrupted by the default browser drag action.

How to reproduce?
Open the custom-handles example and drag or resize and item.
Video of the bug:

Fix in https://github.com/katoid/angular-grid-layout/pull/122


RESEARCH: Technical Complexity of Implementing "Organize Favorites into Collections"

Description:
This research explores the technical complexity of implementing the "Organize Favorites" feature. Currently, residents can favorite Libraries and Videos, but not Helpful Links.
An additional challenge is to consider that libraries and videos have their own association table. Trying to represent them in the same “organized collection” may require us to find a way to support unstructured data.
The research should address:

How to handle the organization of multiple content types under a unified "Favorites" feature using collections.
The changes required to support collections that contain different content types.
Backend and frontend implications for categorizing favorites and displaying them in the resident dashboard.
Potential challenges related to data migration, performance, and scalability.

The outcome of this research will be a draft issue outlining a proposed implementation approach, including task breakdowns for development.
Note: If the scope is large, the work may be divided across multiple issues.
Tasks:
Understand Current State:

[ ]  Assess how favorites are currently stored

Association table for Favorite Videos & Libraries.
Nothing for Favorite Helpful Links.

[ ]  Assess how favorites are currently fetched and displayed in the resident dashboard.
[ ]  Research what database changes are needed to mix favorites into collections.
[ ]  Identify all of the places in the application that favoriting might be impacted.

Identify Potential Challenges:

Consider UI concerns for large collections (e.g., how would the UI react if there were 100 favorites in a single collection? 1000?)

Should we limit collection sizes?

Handling edge cases such as a content item (that has been favorited) getting hidden from residents or deleted from the database.

Acceptance Criteria:

A detailed draft GitHub issue is created, outlining the proposed approach for implementing "Organize Favorites into Collections" based on research findings.
The draft issue includes:

Database changes to support multiple content types
Backend and frontend development tasks with clear objectives.
Any identified risks and challenges related to performance, scalability, or data migration.

The research identifies potential dependencies that must be addressed before implementing this feature.

Outstanding Questions:

How will deletions or changes in the original content (e.g., a removed video) impact its associated favorite and category?
What performance considerations must be addressed for large-scale use cases (e.g., thousands of favorites across hundreds of residents)?
Are there potential concerns that will get raised about persisting values in open text (collection names)?
Should we add the user flows to this so that it can help guide the developer into thinking about how everything needs to be changed (e.g., where collections get named, how favorites are added to collections, etc.)

Known issues/dependencies to consider:

This is dependent on being able to favorite a page. Limiting it to collections and libraries is acceptable for now.
Main issue that comes up is allowing arbitrary user input introduces a surface area for risk.
One potential idea could be to have pre-defined collections (names, colored dots like Mac OS).


Discussion section

Writing as issue, but would prefer a discussion section.
How would I go about exposing multiple services?
Would I just add more
- CADDY_TARGET=hass:8123
- CADDY_TARGET=grafana:3000

Hey Pieter,
the way the docker system is setup is to ensure that every service has a separate hostname on the Tailscale network.
This requires a separate tailscale client for every service.
To expose multiple services, just duplicate the docker-compose section of the tailscale client in your local setup to spin up another instance.
For your reference, please see this ticket.
Regards,
Lieven

I've enabled discussions on the project, see https://github.com/hollie/tailscale-caddy-proxy/discussions/


mina deamon crash while following the installation

Hi,
First time trying to install mainet version on ubuntu 18.04 and I was running the deamon from the command line and just stopped it in order to continue the instructions mentioned on the website.
coda_crash_report_2021-04-19_11-11-04.213480.tar.gz

"Failure",
"IO error: While lock file: /home/forge/.mina-config/trust/LOCK: Resource temporarily unavailable"

Perhaps Daemon was not able to access the file-system at corresponding path.
Closing this one because of no activity for a long time and I hope that the most recent versions of Mina Daemon behave more stable for you.
Please feel free to report new issues should you face any.
Thank you.

https://github.com/MinaProtocol/mina/issues/8692


Install only one browser?

Is is possible to install only one browser using the playwright-driver? I don't need all three downloaded.
Thanks

Hi, not yet, we rely for that on an upstream issue: https://github.com/microsoft/playwright/issues/3866

Hi, that's great, thank you

@adeptedcase out of curiosity, what is your use case for Playwright for Go? Would help us to understand for building features etc.

@mxschmitt I've emailed you to explain what I'm doing

Status: Upstream API is now there, CLI arguments needs to be forwarded.

Is there a way to entirely avoid installing any browsers at all? I'm specifying my own via ExecutablePath. More info on my use case (and workaround) here.

@noperator not yet but let me implement something and then you can review the API.

@noperator I've created a PR #113. Let me know if you have suggestions there, thanks!


Fix crash when executing TubeTrailMesh.get_faces() with GLES3

Fixes #64122
SurfaceData.skin_data was not set.

Thanks!


Not able to set hostname to the sitemaps

@nuxtjs/sitemap: 5.0.5
nuxt: 3.9.1
The sitemap configuration:

sitemap: {
sitemaps: true,
autoI18n: false,
sources: ["/api/sitemap"],
},

This is producing the sitemaps but the hostname is different.

In the screenshot that I have attached, if you can see the hostname of app is different and the sitemap which are generated with the internal URLs. And the weird thing is, the internal url is repeated twice in the sitemap urls. I don't know why this is happening.
I am wondering if there is any way to add the hostname to the sitemaps.

@kishori-patil1 try adding the following to your nuxt.config.ts to add your hostname:
site: {
	url: process.env.BASE_URL, // url to your nuxt app
},

See: https://nuxtseo.com/sitemap/getting-started/installation

@Bakusedu Hi, I tried this. But still I am getting the similar output.
Well, I am setting the host when I run the application. so it is taking only that value.
Is there any other way where we can add the different/multi domain urls to the sitemap?

@Bakusedu @harlan-zw Hi, One thing I have observed that, the sources array in sitemap config object, it fetches the sitemaps from the external endpoints which are mentioned in the array.
So when I visit the /sitemap_index.xml, The request call gets hit. Now, I have all the data, but when I want to see, let's say 0-sitemap.xml, the request call again gets hit. In my understanding, this should not happen since you already have the data.
Can you please help me understanding the behaviour of sources config as well as can we add sources for each sitemap in Automatic chunking?

the config field "site.url " in nuxt.config is always prefixed in final sitemap links, but maybe it is not needed for all case.
On my case, we deploy one application with many  sub-domains.
solution1: remove site.url in nuxt.config.ts and return loc with full href in dynamic endpoint
solution2: need sitemap module to avoid to add site.url again when links already has "http" prefix.

can we pass the original H3Event to dynamic source fetch in  buildSitemap -> resolveSitemapSources -> fetchDataSource and proxy more headers like "host"

I have tried to replicate both issues here:

Absolute URLs getting prefixed with the site URL
Absolute URLs hostname getting stripped for the site path

I was not able to replicate either, please provide a Stackblitz reproduction if you'd like me to explore further. See https://nuxtseo.com/og-image/getting-started/stackblitz
If you have feature requests outside of these issues please make them as their own issue so they can be tracked and discussed properly.

I reproduce and check the link below.

The log in dynamic endpoint can only get 'localhost',
When i18n enabled, the returned urls are prefixed with site.url

https://stackblitz.com/edit/nuxt-starter-w4gkcw?file=server%2Fapi%2Fsitemap.ts

Thank you @chenyuncai, seems like this was a specific issue with absolute URLs in dynamic sources with i18n enabled.
Should be fixed in v5.1.5.


Allowing providers to be string in promptfooconfig.yaml

Here is part of my promptfooconfig.yaml:
---
prompts: [prompts.txt]
providers: [ollama:llama2:13b]

pre-commit's check-yaml is flagging my promptfooconfig.yaml's providers entry:
check yaml....................................................................Failed
- hook id: check-yaml
- exit code: 1

while scanning a plain scalar
  in "promptfooconfig.yaml", line 3, column 13
found unexpected ':'
  in "promptfooconfig.yaml", line 3, column 19

This can be fixed by making providers a string: providers: "[ollama:llama2:13b]".
However, when I do that, now promptfoo fails:
>  promptfoo eval
node:internal/modules/cjs/loader:1090
  const err = new Error(message);
              ^

Error: Cannot find module '/Users/user/code/repo/[ollama:llama2:13b]'
Require stack:
- /Users/user/.nvm/versions/node/v19.9.0/lib/node_modules/promptfoo/dist/src/providers.js
- /Users/user/.nvm/versions/node/v19.9.0/lib/node_modules/promptfoo/dist/src/main.js
    at Module._resolveFilename (node:internal/modules/cjs/loader:1090:15)
    at Module._load (node:internal/modules/cjs/loader:934:27)
    at Module.require (node:internal/modules/cjs/loader:1157:19)
    at require (node:internal/modules/helpers:119:18)
    at /Users/user/.nvm/versions/node/v19.9.0/lib/node_modules/promptfoo/dist/src/providers.js:200:132
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
    at async loadApiProvider (/Users/user/.nvm/versions/node/v19.9.0/lib/node_modules/promptfoo/dist/src/providers.js:200:32)
    at async loadApiProviders (/Users/user/.nvm/versions/node/v19.9.0/lib/node_modules/promptfoo/dist/src/providers.js:45:17)
    at async Command.<anonymous> (/Users/user/.nvm/versions/node/v19.9.0/lib/node_modules/promptfoo/dist/src/main.js:257:33) {
  code: 'MODULE_NOT_FOUND',
  requireStack: [
    '/Users/user/.nvm/versions/node/v19.9.0/lib/node_modules/promptfoo/dist/src/providers.js',
    '/Users/user/.nvm/versions/node/v19.9.0/lib/node_modules/promptfoo/dist/src/main.js'
  ]
}

Node.js v19.9.0

It would be cool if providers in YAML could be a string

Does it work with an array of strings?
providers: ["ollama:llama2:13b"]

Oh nice thinking 🚀  yeah that does work! Thanks for thinking outside of the box


potential revision to "Max. age selectivity" sensitivities

I would suggest a change in the sensitivity for "Max. age selectivity" sensitivities. As implemented, the dev_mnyr and dev_mxyr columns have been changed to match the range of ages in question (e.g. for Max. age selectivity 10, there are devs estimated for parameters AgeSel_P3_Fishery(1) to AgeSel_P11_Fishery(1) (corresponding to ages 2-10, with the P2 parameter for age 1 fixed as a reference value.
But the phase should also be changed to be positive so that the base value can be re-estimated, not just the deviations.
Also, the description in the text should implies that both the fishery and survey selectivity are estimated up to the Max. age in each case, which I think is a reasonable way to do this, so the phase for the survey selectivity parameters should also be adjusted to go to the same max.
There are definitely other ways to do this, but I think these changes would be more in line with what we have said we're doing.

Good catch Ian, I agree and can update these now.

I updated the max selectivity sensitivity model files on the google drive.  These will need to be copied over to your models folder.  They are:
2018.40.07_maxSel_Age5
2018.40.08_maxSel_Age7
2018.40.09_maxSel_Age10
And then you will have to build() again eventually to get the R.Data files updated for those three.
Ian, can you quickly confirm that I updated those control files in line with what your were thinking.

The control files look good to me. In commnit cb97135 I made 3 changes to the selectivity plots:

take off the header
change the fleet name from "Acoustic_Survey" to "Survey"
change the year represented from the final year (including deviations) to the baseline selectivity without deviations representing years up to 1991

The updated figure is shown below. To my eye, the base model in panel (a) remains the least strange looking of the set.

I noticed that the headers for last year said the selectivity was for 2016, so I was going to put 2017 into the caption. But then I saw that years=1966 is set in make.selex.plot() :
https://github.com/andrew-edwards/hake-assessment/blob/master/doc/r/r-functions/figures-selex.r
Ian, I think you put that in today, but doesn't it then use 1966 as the year in SSplotSelex()?
I tried setting years=end.yr-1  in the two commits that reference this Issue, and end up with the plot:

Panel (d) shows a large difference to Ian's above.
It's fiddly to further delve into the SSplotSelex() to look at numbers, so I just want to check which should be used.

And does it matter that we don't show the selectivites for the different values of phi? Maybe we should, and have a second figure?

Just to confirm - I did update the models folders as per Aaron's instructions above. Make sure we don't close this Issue until Chris confirms he has done so also.

I think the use of 1966 sets the selectivity to the average (before year specific devs are applied) so that the figure shows an 'on average' selectivity rather than one for any specific recent year which would be influenced by the time-varying nature of our selectivity.  I think the idea was that it shows a more on average picture of what selectivity would look like under the different max selectivity age sensitivities, rather than an individual year.
I wait for Ian to comment on this though...

Yes, 1966 could have been any year outside the range 1991-2017 where there is time-varying values. I think that showing a single year within the time-varying range could be misleading. However, perhaps there's value in showing a some of those years along with the average, along the lines of the plot below:

Sure, that graph seems reasonable to me.  We could do the same structure IF we end up showing something similar for alternative phi (and/or sigma-S) sensitivities.  Although, we already have the code built to run the mountains plot for sensitivity to phi (again if we plan to show those figures again) - maybe just in SRG presentation (?).

I like the last plots, and showing two years is good. Last year's assessment (the panel titles) did say they were for 2016, so that's why I was confused (and wanted to check) about the move to 1966.
If you can implement that would be great, thanks.

I've downloaded the new models and built with them. So, feel free to close when you want.

Commit de34987 was supposed to revise the plot as pasted above (with slightly lighter colors for the 2016 and 2017 lines). However, it just failed to work when I tested in the context of the full document, so don't merge my fork for the moment. I'll close this issue once I have it working and have edited the caption to match the revised plot.
I'm not 100% sure that the code is adequately general to work next year without some edits, but we'll deal with that if it crashes or looks funny.

Still can't figure out what I did wrong with the plot and why testing it outside of the document works fine but within it not. However, change is really low priority compared to other issues so I just reverted my edit and will come back to this after eating lunch and maybe focusing on other more important things. Will leave issue open to remind me to return at some point, assuming time allows.

The existing plot already addresses the original issue but I haven't given up on making the improvement discussed above. Keeping this issue open will remind me to revisit this.

I think I got this working now in commit 0effe2a. Figure should look like image below. Given bad track record of other recent change related to a figure (issue #374), I will leave the issue open until someone else confirms that the plot works for them.

Nice work on this Ian, I built the document and the plots appear exactly as yours do.

Excellent. Closing now.