now using the osgi enabled dependency replacement for non osgi libraries

This change needs a proper test if everything work as expected, since I'm not sure if the new libraries behave the same like the previously used ones.

Hi @Arcticwolf, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla.azure.com.

TTYL, AZPRBOT;

@Arcticwolf, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.
Thanks, AZPRBOT;

I'm wondering if we really want to make this library OSGi ready? Larger projects (e.g., Spring) have dropped OSGi support quite a while ago, and I am not too keen on all kinds of 'OSGi ready' dependencies in my non-OSGi projects.

I am also no friend of the applied changes since they will result in keeping an eye on many files after libraries changed. To underline @MikeN123 post here is a stackoverflow for this topic.

Of course this decision is not mine : ) If you don't want to have the library OSGi enabled, then this is ok too.
Just my two cents about OSGi: IMHO it is not true that larger projects in general go away from OSGi (e.g. almost everything in the Apache environment or the whole Eclipse universe). I know that Spring went away from OSGi but the other way round the OSGi world went step by step away from Spring, since Apache Blueprint is getting more and more a replacement of Spring which worked way more smoothly with OSGi. Naturally Blueprint went way better with OSGi, since it was designed with OSGi in mind : )

In my opinion, the only feasible solution would be a separate artifact, using a separate maven profile with the OSGi dependencies (or something like that, I'm no Maven expert). That way, the OSGi-specific dependencies can stay out of the build for non-OSGi users. It is also the way HttpClient handles it, apparently they use a separate OSGi project: https://svn.apache.org/repos/asf/httpcomponents/httpclient/tags/4.3.6/httpclient-osgi/

Looks like we have two -1s for this.  I like the idea of ews-java-api-osgi that is published from a fork whenever an ews-java-api released is published, but I don't have a lot of experience around this.
@evpaassen what's your take on this one?

Looks like we have two -1s for this. I like the idea of ews-java-api-osgi that is published from a fork whenever an ews-java-api released is published, but I don't have a lot of experience around this.

I never used OSGi, but I'm not keen on having OSGi-specific dependencies (like httpclient-osgi) in this library when not using OSGi. So I think there should be a OSGi-enabled fork indeed, which could be maintained by someone who is actually using OSGi or has sufficient experience with it.
I'd suggest backing out #98 for now.

I've reverted #98.  Will also close this PR.  @Arcticwolf I assume having a fork on github that builds OSGi compliant versions would address your needs.  However, let's keep any core improvements in the main repositories, and use that just for mixing in OSGi.  Thanks everyone.

We need an OSGi-ready version of this library. For now we've forked and done it ourselves, but given there was already a PR for this I imagine it will be requested in the future too. Given the changes were made, it seems a shame that they were reverted without a branch being made first!
The only thing required to make a project OSGi-ready is some extra entries in the manifest. In the case of httpclient, the artifact needs to change but as far as I know the osgi and non-osgi versions are interchangeable. 99% of projects don't have different artifacts for OSGi and non-OSGi and I can't see a reason why this project needs to keep them separate. Making something OSGi-ready does not stop it working in non-OSGi environments.
Once you've added a (quite simple) maven plugin, all the manifest entries are handled automatically so there's no extra files to maintain etc. The only other changes required are the httpcllient artifact names and the packaging type from jar to bundle. I've made and tested these changes on our fork. I can create a PR if you want

Making something OSGi-ready does not stop it working in non-OSGi environments.

It does, since we have more dependencies that require HttpClient, and thus I end up with multiple HttpClient versions on my class path.

OSGi or not, unless those other dependencies use exactly the same version of http client as this project, you should exclude one of the http clients to be sure about which one maven will put on your classpath. If this project was made osgi ready, then you might have to change the artifact that's excluded but that's the only difference.
NB, having many dependencies which each want a different version of httpclient was one of our main reasons for moving to OSGi.

Uhm, I'm not sure about your Maven, but our Gradle (and Maven too IIRC) do dependency version resolution, and simply pick the highest required version.


Error when trying to open links in markdown preview

Verifying https://github.com/microsoft/vscode/issues/26659
I opened the vscode-docs repo. I started with the markdown preview of identifiers.md.
When I click on the link to "language mode" in the second line of text, I get:

Unable to open 'overview.md': Unable to read file (Unknown (FileSystemError): Error: UNKNOWN: unknown error, stat '\file\d:\repos\Microsoft\vscode-docs\docs\languages\overview.md').

This happens for every local link in markdown previews. I didn't set any markdown preview settings.

The link described above is [language mode](/docs/languages/overview.md#changing-the-language-for-the-selected-file). I'm on Windows and this works in .md preview [test](test.md#hello-world).  So maybe it's the absolute path?


Limit the number of observations that can get mapped

Also includes a fix for config/puma.rb so it should work better with local systems.

Looks good, but I feel like locations/maps and names/maps may need the same limits. I've noticed these showing up in the logs too.
Thanks for these better puma defaults.


[Wallet] Celo Gold notification shown even if users have already exchanged

Expected Behavior
Celo Gold notification hidden once users have exchanged
Current Behavior
Celo Gold notification only hidden if it has been clicked

closed as not important

closed as not important


We need to understand how RDF is created from Django

@dtarb @pkdash @martinseul @horsburgh The discussion of referenced time series (issue #1571) yesterday exposed a rather important issue going forward. Of the team, only @horsburgh knows how RDF is generated from Django.  It would help greatly if the other parties involved (including myself, @pkdash, and @martinseul) know more about the algorithm for going from Django metadata to RDF.
@horsburgh: Could you give us some lessons?  Or, more presently, could you explain the rules by which you're creating the RDF for composite referenced time series from the Django you have?

@alvacouch - I worked with @pkdash on the implementation. As we have worked on different resource types, I have given him examples of how to encode various metadata items in the resourcemetadata.xml file. First we worked out how to do the standard Dublin Core elements and then we worked out how to do resource specific stuff, etc. The examples are validated using an RDF/XML validator to make sure they are syntactically correct and then Pabitra has done all of the coding and implementation for actually creating the XML file.  So - @pkdash is the resident expert on how the XML file gets generated.
The composite resource work is new.  And I'm still working with Pabitra to make sure metadata elements get written to the resourcemetadata.xml document for each file.  For the composite, referenced time series file type, I will take the final version of the JSON file, convert the necessary elements to an RDF/XML representation and embed it in the resourcemetadata.xml document so Pabitra knows what it should look like. Then, Pabitra will implement that.  But we still need to look at this in the context of what Pabitra has already done for the NetCDF file type and make sure we are being as consistent as possible across file types and also making sure that we don't do something dumb that precludes adding metadata from other files of other types.

@alvacouch
Refer to following link to see how the RDF/XML gets generated for core metadata:
https://github.com/hydroshare/hydroshare/blob/develop/hs_core/models.py#L2852
Refer to the following link to see an example of how resource specific (e.g., time series)  RDF/XM gets generated:
https://github.com/hydroshare/hydroshare/blob/develop/hs_app_timeseries/models.py#L792

@horsburgh @pkdash @alvacouch I'd like to close this but I'd like to make sure the knowledge ends up being disseminated to the team. We can either move it to the wiki or send it out via an email. What do you think?

@aphelionz I am OK with closing this.


Add minDepth

Initial checklist

[x] I read the support docs
[x] I read the contributing guide
[x] I agree to follow the code of conduct
[x] I searched issues and couldn’t find anything (or linked relevant results below)
[x] If applicable, I’ve added docs and tests

Description of changes
Add minDepth option and filter results accordingly.
Closes #74

Done in 7.1.0. Thank you!


Support for pipelines to be executed on Ray

Ray has some advantages over Kubeflow as data passing between workers is highly efficient (shared memory, Apache Arrow over Object Store) and support for a streaming model.
We need to evaluate if it makes sense to use the pipeline editor to directly submit Ray jobs or weather Ray can be part of a multi node/pod stage in a KF Pipeline (like a Spark stage for example)
The following video gives a very good overview
https://www.youtube.com/watch?v=CCL0ZkLl9ns

I believe this is similar to running a Python kernel on an image that has the  necessary artifacts to use PySpark to connect to Spark, just in this case being Ray. This wouldn’t have any specific requirements on Elyra, and from some initial investigations this seems to work today.
Please let me know if I missed anything, as I didn’t try Ray yet.

Let me try it...

Ray can be used within any notebook, therefore also using the pipeline editor to push work to KFP. When using a Ray cluster this has to be referenced from within the notebook - therefore no further work within Elyra is necessary

Ray can be used within any notebook, therefore also using the pipeline editor to push work to KFP. When using a Ray cluster this has to be referenced from within the notebook - therefore no further work within Elyra is necessary

Yes, we have also updated the covid-notebooks scenario to use Ray

Yes, we have also updated the covid-notebooks scenario to use Ray


Verify jwt without key id field

This change allows JWT-formatted VCs and VPs to be verified even when they don't have a "kid" field specified.
See https://github.com/spruceid/ssi/issues/478 for context.
I've been using this code in a forked version of ssi crate in my codebase for some time now, based on an earlier version of ssi crate.  I'm not able to run the cargo tests for ssi-vc crate (see https://github.com/spruceid/ssi/issues/521), but the vc-test-suite tests do pass.
Is there a full battery of tests that I can run, and if so, how?

Hi there, I sent in a signed CLA Oct 6, 2021.  But let me know if you need a new one for whatever reason.

I signed a new one, just in case it makes things easier.


Live update of translations of data items

When I set a translation like this:
v-bind:label="$t('message.website')"
Then the view is updated at once when I change the locale.
However, if I set a translation for a data item like this:
label: this.$t('message.labelimage')
Then the view is not updated when changing the locale. I have to reload the page to see the translation. Is there a way to have the view rerended automatically with new translations for data items too?

How is this related to vee-validate?

Well, I do not know if this inconsistent behaviour is caused by veeValidate code or not. The fact is, that it surprises me. One would expect data properties to be updated and rerendered as well when the locale is changed, but this does not happen in my setting.
I would like to know if this is the expected behaviour for veeValidate?

VeeValidate does not regenerate the already generated messages when the locale changes, however you could just trigger a validateAll call and it would generate them again in the new locale.
It was suggested before but never implemented, but could be with this PR #1007

Please excuse me. You are right, it is not related to vee-validate. I posted in the wrong github account. You can delete this post if you want.

don't worry about it 😄


Add pkg-dist build option to create flat distribution packages.

This change is mostly to support creating packages compatible with createOSXInstallerPackage (COSXIP) installs of Yosemite, which now requires additional packages to be flat distribution-style. The pkg-dist target will build a flat package (given USE_PKGBUILD=1) using the prep_pkg target and post-processed by the create_flatdist target, which uses productbuild --package MyFlat.pkg MyFlat_dist.pkg to output a flat distribution package to $PWD.

Thanks!


Synology-csi?

sorry for the noob question, but how would i go about modifying one of these to support the Synology-csi?

I summarized it to https://github.com/seaweedfs/seaweedfs-csi-driver/issues/98#issuecomment-1418283567 earlier.
How easy or hard it is depends on how Synology CSI is build. Reading all linked documentation and playing with some of those working examples most likely helps.
There is three simple examples here with CSI drivers which worked without changes.
More complex example is happening on https://github.com/hetznercloud/csi-driver/pull/376 because of challenges explained in https://github.com/hetznercloud/csi-driver/issues/374#issuecomment-1413740340


Added onClick event for ROverlay

Codecov Report
Patch coverage: 100.00% and no project coverage change.

Comparison is base (00f67c2) 98.88% compared to head (4be790a) 98.88%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #155   +/-   ##
=======================================
  Coverage   98.88%   98.88%
=======================================
  Files          74       74
  Lines        1430     1430
  Branches      222      222
=======================================
  Hits         1414     1414
  Misses         16       16

Impacted Files
Coverage Δ

src/ROverlay.tsx
100.00% <100.00%> (ø)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

@mmomtchev Could you say when next release is planned please?

It is done


⬆(mysql) upgrade mysql to version 8

Upgrade mysql from 5.6 to 8.0

Should we still keep mysql 6 in the CI alongside 8 since edX people are still running old versions of mysql?

Should we still keep mysql 6 in the CI alongside 8 since OpenEdX people are still running old versions of mysql?

Yes, we can have both versions running on CI.
@sampaccoud  Yesterday I forgot to add this issue https://github.com/openfun/richie/issues/1594

@sampaccoud  I've added the CI configuration for: test-back-mysql-5 and test-back-mysql-8.

@sampaccoud I think needs to be a repo administrator to click on the Rebase and merge button.
I've renamed the test-back-mysql to test-back-mysql-5 CI step, because of that the old test-back-mysql haven't run. So the Github don't allow me to click on the Rebase and merge button.


Offloaded pods repatriated after temporary glitch

What happened:
A temporary glitch caused all pods offloaded in a given namespace to be locally repatriated. Specifically, the liqo-controller-manager failed to contact the remote cluster during a periodic refresh of the namespace mappings (due to the capsule webhook not responding), and marked the corresponding entry in the namespacemap as Failed. This, in turn, caused the virtual kubelet to interrupt the reflection, and mark all offloaded pods as Failed (OffloadingAborted). Immediately, the entire process was re-executed and completed correctly, leading to the restart of the reflection process.
What you expected to happen:
Temporary errors should not lead to the repatriation of all resources, but should be addressed with controlled retries. The decision of the repatriation should be up to the virtual kubelet, according to its own timers (by default pods are removed from a NotReady node after 300 seconds.
How to reproduce it (as minimally and precisely as possible):

Install liqo on two clusters
Enable a namespace for offloading, and offload some pods
Cause the capsule webhook to not respond and observe the behavior during a periodic resync of the namespace controller

Anything else we need to know?:
Environment:

Liqo version: 0.3.2-beta.2
Kubernetes version (use kubectl version): 1.21
Cloud provider or hardware configuration: on-premise (kubeadm)
Network plugin and version: calico
Install tools: liqoctl
Others:

Closing, as addressed by #1131


Blueprint how can we ignore existing models?

Just starting a new project and blueprint is great.
I was able to setup the initial structure of my app within minutes 🔥
One question is how do I append additional models without overriding everything?
I assumed running blueprint:trace would cache the models generated so that running again with the additional models appended to draft.yaml would only generate the new model.
However it seems to override everything which is not ideal after editing each model.
Expected behaviour would be to ignore anything which is already in .blueprint then just add new model Bid for example.
models:
    Auction: {  }
    Buyer: {  }
    Category: {  }
    Item: {  }
    Price: {  }
    Seller: {  }
    User: { }
    UserProfile: {  }

Current workaround is to comment out the generated models in draft.yaml
Certainly not ideal hoping there is a better way? or perhaps I can create a PR at some point to ignore anything with has been previously generated by the build command?
Additionally are you planning support enum generation?
for example it would be useful to generate Enums based from the field.
buyer_status: enum:pending,paid,reviewed,refunded,cancelled,disputed,completed

The draft file is not cumulative. It's more of a scratch pad where you generate fresh ideas.


Set default instance profile

Tell us about your request
I would like to have the ability to set a default instance profile, making it optional when defining Provisioner objects.
Tell us about the problem you're trying to solve. What are you trying to do, and why is it hard?
When we deploy Karpenter using our pipeline, we use TF to create the dependencies (IAM roles, instance profile, etc.) and deploy Karpenter using a helm_release resource. It would be nice if I could pass in the created instance profile as an argument to make it the default profile. This will prevent the sharing of a magic/well-known name with our separate Helm chart that configures all of our tenant resources (has no access to this pipeline and its outputs).
Are you currently working around this issue?
Simply sharing the name of the profile and hoping for the best! 😆
Additional context
I do recognize that this is a provider specific field, but do see other env vars that are being passed in that are provider specific. So, I don't feel it'll muddy the waters too much asking for this in that regard.
Attachments
None

Community Note

Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
If you are interested in working on this issue or have submitted a pull request, please leave a comment

I'm completely supportive of this idea. We recently moved clusterName and clusterEndpoint from a CRD field to a binary flag. It should be straightforward to wire it up here: https://github.com/aws/karpenter/blob/a859cad1e3b3c5cc916f69bb2435198a3cd0af13/pkg/utils/options/options.go#L29.
We still need to have the ability to override InstanceProfile at the CRD level as there are use cases for running nodes with different roles in different provisioners. However, we can make this an optional field.
Is this something you'd be able to contribute?

Awesome! And yeah... makes sense to allow overrides at the CRD level as well.
I'll gladly contribute it. Just wanted to get the go-ahead before jumping in. I'll see if I can send something your way here soon!


Add integration test to prove search by title

This PR adds an integration test which shows that searching tickets by title works.
Original heartbeat was done on home controller. That had to be removed, since home controller now hosts the dashboard and has to be authenticates.
This PR adds heart beat on /heartbeat route so that we can continue monitoring our app.

LGTM

@FundingCircle/black-bat added heartbeat endpoint as part of this feature, please review

:do_not_litter:  Please don't merge until the branch ENG-665-search-for-apps-deployed-by-name is merged to master, so the inevitable merge conflicts can be handled in the shorter feature branch (ie. this one here).

needs rebasing


Add a toggle for Multi-cluster Pod-to-Pod connectivity

Add a toggle for Multi-cluster Pod-to-Pod connectivity in antrea-agent configuration. The Pod-to-Pod connectivity feature will be enabled when the toggle is set true and Pod CIDRs are provided in the Antrea Multi-cluster configuration.

@hjiajing please fix github check failure.

@luolanzone Thanks for the reminder. The Go / Verify docs and spelling failed because I didn't generate a new helm chart README.md. It works well now.
I think another PR will face the same problem, I'll fix it, too.

@hjiajing please help to resolve the manifest conflicts. thanks.

@luolanzone Thanks for the reminder, regenerated the manifest and resolved the conflict now.

/test-e2e
/test-networkpolicy

@hjiajing : some tests have been pending for long, and some (e.g. multicluster-e2e) are not shown on the PR. Please re-push the commit, and make sure the required tests are passed.

@jianjuns Thanks for the reminder, pe-pushed now.

/test-e2e
/test-networkpolicy

/test-multicluster-e2e

/test-all

/test-e2e
/test-multicluster-e2e

/test-multicluster-e2e


MSO VML bg and links inside...

when the links are inside the vml background in the mso they are shifted to the left. How can this be avoided?
1 photo mso desktop
2 photo  browser and other email clients

Padding left and right are applied both on right on Outlook withink a section with background image, you should remove it if you can.
There's not so much we ca do about this


Ensure webhooks are created only after github push is complete

Why
Potential fix for: https://github.com/openshiftio/openshift.io/issues/3742
According to the following comment by @piyush-garg the builds might be triggered twice intermittently due to the createWebHooks(...) method being called prior to the pushToGitRepository(...) method completing: https://github.com/openshiftio/openshift.io/issues/3742#issuecomment-447838579
Description
The solution implemented is a simple callback to listeners who are interested in knowing when the push has completed. Once the callback is called, the createWebHooks(...) method is invoked.
Was tested to ensure that everything continues to work normally. However, unsure if this will fix the issue as it has been proven difficult to reproduce locally:

Closes #3742
https://github.com/openshiftio/openshift.io/issues/3742
Checklist

[ ] I followed the contribution guidelines.
[ ] I created an issue and used it in the commit message.
[ ] I have built the project locally prior to submission with mvn clean install.
[ ] I kept a clean commit log (no unnecessary commits, no merge commits).
[ ] I am happy with my contribution.

Ike Plugins (test-keeper)
Thank you @tinakurian for this contribution!

It appears that no tests have been added or updated in this PR.
Automated tests give us confidence in shipping reliable software. Please add some as part of this change.
If you are an admin or the reviewer of this PR and you are sure that no test is needed then you can use the command /ok-without-tests as a comment to make the status green.
For more information please head over to official documentation. You can find there how to configure the plugin.

[ok-without-tests]

Thanks @piyush-garg i think it needs to be /ok-without-tests do you mind adding another comment?

/ok-without-tests

Hey @piyush-garg! It seems you tried to trigger /ok-without-tests command, but this will not have any effect due to insufficient permission. You have to be admin or requested reviewer or pull request approver, but not pull request creator for this command to take an effect.

@gastaldi It was to force a callback to be invoked when the push to github method completes. @piyush-garg was explaining that the push can take some time to finish and the webhooks call is intermittently made before the push is completed causing two builds to be triggered. See comment: https://github.com/openshiftio/openshift.io/issues/3742#issuecomment-447838579

@tinakurian I'm almost certain that this is already happening here, given that the crreateWebhook method is called after the pushToRepository method.

@tinakurian I'm almost certain that this is already happening here, given that the crreateWebhook method is called after the pushToRepository method.

Yeah, i wasn't confident in this change. I think the issue maybe is more with the library we are using. Perhaps it spawns a thread somewhere when it executes the push and it doesn't wait for a return from the thread. However, I did have a peek at the library code and couldn't really verify whether this is what was happening...

The Push happens using jGit, but I believe that it returns immediately once it finishes execution, no threads involved.  Maybe something in GitHub?

The Push happens using jGit, but I believe that it returns immediately once it finishes execution, no threads involved. Maybe something in GitHub?

@piyush-garg just mentioned an idea that may be more suitable - he was suggesting maybe checking that the code exists before we invoke the createWebHooks call? Would this be more reasonable?
@gastaldi is there another solution you had in mind? Or would this work?

@tinakurian what happens if you add a breakpoint after pushToRepository executes? Can you check if the sources are immediately available?

@tinakurian what happens if you add a breakpoint after pushToRepository executes? Can you check if the sources are immediately available?

I can check, my guess would be that they are, except maybe in the case where two builds are triggered. I haven't been able to reproduce this issue locally...
Do you think we could add logs to see what the source looks like when two builds are triggered in production?

@tinakurian sure, feel free to add some log statements there and I'll be happy to merge them ;)

What happens if you change OSIOMissionControl to the following order instead:

Create Repository
Configure Webhooks
Push code

@piyush-garg considering that the webhook is meant to be triggered everytime a PUSH happens, why the following order wouldn't be more appropriate?

Create Repository
Create Webhooks
Push code

Maybe the events registered in the webhook need to be reviewed?

@gastaldi @tinakurian
That's should be the process I think,

Create Repository
Create Webhooks
Push code and build get triggered

But the current process is

Create Repository
Push Code https://github.com/fabric8-launcher/launcher-backend/blob/master/addons/osio-addon/src/main/java/io/fabric8/launcher/osio/OsioLaunchMissionControl.java#L74
Create webhook https://github.com/fabric8-launcher/launcher-backend/blob/master/addons/osio-addon/src/main/java/io/fabric8/launcher/osio/OsioLaunchMissionControl.java#L77
Trigger build https://github.com/fabric8-launcher/launcher-backend/blob/master/addons/osio-addon/src/main/java/io/fabric8/launcher/osio/OsioLaunchMissionControl.java#L83

I don't know the reason why the process is like this.

This could have been my mistake when migrating from the legacy codebase.
@tinakurian mind closing this PR and opening a new one inverting the order to do the following and see what happens?

Create Repository
Create Webhooks
Push code

This could have been my mistake when migrating from the legacy codebase.
@tinakurian mind closing this PR and opening a new one inverting the order to do the following and see what happens?

Create Repository
Create Webhooks
Push code

Will do!


⚠ ClamAV has degraded performance

In 36c367f, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 209 ms

Resolved: ClamAV performance has improved in a64dafa.


Add sorting in File Browser

In order to allow sorting the File Browser by Name or Creation Date, adding a Sort button to the toolbar:

The Sort button opens this Action Sheet:

Sort by name:

Sort by creation date:

Thanks @matrush!


return aggregations for search all if use

use php-cs-fixer on class

I add code : (348-351)
    // If Use aggregations return an array with results and aggregations.
    if (isset($totalSearch['aggregations'])) {
        return array( 'results' => $results, 'aggregations' => $totalSearch['aggregations']);
    }

after refelxion => undo this modification is not useful.


Bandcamp no longer works

Previously, trying to play a whole album via the bot worked fine (like https://nightmargin.bandcamp.com/album/oneshot-soundtrack), but now the bot just skips over all the tracks as if they were empty.
Same thing happens if you try a single song (https://nightmargin.bandcamp.com/track/my-burden-is-light-2): it's shown in the queue with the correct time, but when it's up to play it just briefly edits the channel topic then skips to the next song. With a playlist the bot keeps editing the channel topic.

What platform are you on?

Ubuntu 16.04.3 LTS
Version 0.1.0 of the bot

Do the same links still work on Version 0.0.9? If not, then I don't believe it is something I can fix, it would either be an issue with lavaplayer or bandcamp does not support the same kind of streams anymore

The same links used to work on v0.1.0 before, I'll open up an issue on lavaplayer


inso cli scripting first pass

motivation: incrementally extend cli features to match app
aim: add the simplest possible implementation which will allow a header to be added by a pre request script, to be confirmed with a test which will rely upon on the script modifying the request

[x] proof of concept, copied from hidden-window.ts and wired up
[x] make requireInterceptor work, and use same abstraction as hidden-window
[x] test case for add header
[x] test case for require
[x] test case for send request

reviewer note
consider running bundle tests against build
consider refactoring opportunities
theres a high chance of future inconsistency with hidden window implementation
future work

post request
abstract into common implementation?
remove hidden-window implementation? could be a heavy lift due to async implementation, perhaps not for @ihexxa

The major contention of this pass

chance of drift in hidden window context implementation
slightly different execution context due to the promise handling

My preference would be to use matching execution contexts so that cli task execution results would always match the UI.
That would mean removing the hidden window executor and using a nodejs executor for both.


ddev import-db should drop all tables first

What happened (or feature request):
ddev import-db does not drop all tables before importing. This can lead to important problems for a few people. It should drop all tables.
What you expected to happen:
How to reproduce this:
Version: Please include the output of ddev version, docker version and the project's .ddev/config.yaml.
Anything else do we need to know:
Related source links or issues:
Please use a complexity rating of 1-5 (5 is high) for a feature request. (High complexity implies more PR planning)

There are use cases where you do not want to drop all tables. The primary one that comes to mind is for people working on imports or migrations. It's fairly common to have data in tables in the Drupal DB which are not managed by Drupal.
We may very well want to do this change anyway, but it's worth thinking through use cases where having additional tables is 'normal'

It's not unusual to have data in tables that is not managed by drupal. It is unusual to do an import-db action (in any environment0 that ends up with data other than that which was provided in the import tarball.
I've been bit really, really badly by environments that do this wrong. The worst is a failed upgrade which leaves the new tables in place and then you try to start over with a clean db. Then the upgrade fails because the unexpected tables are still there.

Sounds like maybe we could pick a default, and then add a flag to change it? e.g.: ddev import-db --no-drop or something to skip dropping tables?

Also, we had an issue where a ddev pull didn't successfully solve problems with a corrupted (or pre-mariadb 10.1) database. It really should. We should be building everything from scratch on a pull or import-db.
IMO people can import one table at a time with many techniques, and it's an unusual requirement; import-db should blow away everything (even system tables) and start from scratch.


Averaging: if all colors have the same channel set to NaN, it can cause a failure

We missed a case where if all values of a particular channel are undefined, we'll omit the colors from the average, and if we do, we can end up with a total of zero, and when we try and get the mean, we divide by zero :(.

The issue will be fixed in the next version. I wasn't planning on doing a minor release, but since we have to fix this bug, we might as well do a minor release with the new XYB color space as well.


Write a TypeScript program to find factorial of a number

Description
Write a TypeScript program to find factorial of a number
Factorial of N = N (N-1) (N-2) ... 1
Input  : 5
Output : 120

How to contribute

Save the solution in program/FindFactorialOfANumber.ts file
Add FindFactorialOfANumber.ts file in find-factorial-of-a-number folder

!assign

!assign


[Event Request] codeunit 7153 "Item Analysis Management"

Dear ALAppExtensions team,
On behalve of 4PS I would like to add an additional parameter to integration event 'OnAfterSetCommonFilters' used in procedure 'SetBufferFilters' in codeunit 7153 "Item Analysis Management";
procedure SetBufferFilters(CurrentAnalysisArea: Enum "Analysis Area Type"; var ItemStatisticsBuffer: Record "Item Statistics Buffer"; CurrentAnalysisViewCode: Code[10]; ItemFilter: Text; LocationFilter: Text; DateFilter: Text; Dim1Filter: Text; Dim2Filter: Text; Dim3Filter: Text; BudgetFilter: Text)
begin
    with ItemStatisticsBuffer do begin
        Reset();
        SetRange("Analysis Area Filter", CurrentAnalysisArea);
        SetRange("Analysis View Filter", CurrentAnalysisViewCode);

        if ItemFilter <> '' then
            SetFilter("Item Filter", ItemFilter);
        if LocationFilter <> '' then
            SetFilter("Location Filter", LocationFilter);
        if DateFilter <> '' then
            SetFilter("Date Filter", DateFilter);
        if Dim1Filter <> '' then
            SetFilter("Dimension 1 Filter", Dim1Filter);
        if Dim2Filter <> '' then
            SetFilter("Dimension 2 Filter", Dim2Filter);
        if Dim3Filter <> '' then
            SetFilter("Dimension 3 Filter", Dim3Filter);
        if BudgetFilter <> '' then
            SetFilter("Budget Filter", BudgetFilter);
    end;

    OnAfterSetCommonFilters(CurrentAnalysisArea, ItemStatisticsBuffer, *CurrentAnalysisViewCode*);
end;

[IntegrationEvent(false, false)]
local procedure OnAfterSetCommonFilters(CurrentAnalysisArea: Enum "Analysis Area Type"; var ItemStatisticsBuffer: Record "Item Statistics Buffer"; *CurrentAnalysisViewCode: Code[10]*)
begin
end;

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.


Update language for aliasing node_modules/.bin

To keep consistent with builder-react-app

LGTM!

I'll wait for the other PR to be approved before merging. Thanks!

@zachhale -- One comment, rest LGTM without re-review.


Allow running CLI without ATLAS_INIT_PROFILES_PATH

Enable the CLI to function without requiring the ATLAS_INIT_PROFILES_PATH environment variable by providing a default path. Improve error handling for missing environment variables and enhance logging for better visibility.

Codecov Report
Attention: Patch coverage is 70.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 51.90%. Comparing base (10f22af) to head (63131ce).

Files with missing lines
Patch %
Lines

py/atlas_init/settings/path.py
42.85%
4 Missing :warning:

py/atlas_init/settings/env_vars.py
75.00%
1 Missing and 1 partial :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #27      +/-   ##
==========================================
+ Coverage   51.84%   51.90%   +0.06%
==========================================
  Files          50       50
  Lines        5046     5053       +7
  Branches      672      674       +2
==========================================
+ Hits         2616     2623       +7
- Misses       2350     2351       +1
+ Partials       80       79       -1

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


refactor-WIP add specific classes for PUSH, PUBLIC_…

…VERION, CLEAR_TRANSACTION, DELETE tasks
Proposed changes
Issue Number: #19575
Problem summary
Describe your changes.
Checklist(Required)

[ ] Does it affect the original behavior
[ ] Has unit tests been added
[ ] Has document been added or modified
[ ] Does it need to update dependencies
[x] Is this PR support rollback (If NO, please explain WHY)

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall

run p0

run buildall

run buildall

run buildall

run buildall

run compile

run buildall

run buildall

run buildall

run buildall

run buildall

run buildall

run buildall

run buildall


Upgrade Qt to 5.13.x

iOS only - with Qt 5.11.x we have issues with the display notch and the bar at the bottom on the newer phones - both seem to get fixed when Input is built with 5.13

https://github.com/lutraconsulting/input/issues/476
https://github.com/lutraconsulting/input/issues/513

will update directly to 5.14.1


[Doc]: Docker+vllm+fastchat deploys multimodal large model Qwen2-vl-7b-instruct(docker+vllm+fastchat部署多模态大模型Qwen2-vl-7b-instruct)

📚 The doc issue
When testing using the following method, an error is reported, and the terminal log results are shown as follows:
curl -X POST http:(base) root@lxing:~# curl -X POST http://<IP_ADDRESS>:8000/v1/chat/completions
-H "Content-Type: application/json"
-d '{
"model": "Qwen2-VL-7B-Instruct",
"messages": [{"role": "user", "content": "你好！"}],
"temperature": 1.0,
"max_tokens": 100
}'
{"object":"error","message":"Internal Server Error","code":50001}
2024-11-22 02:50:27 | INFO | stdout | INFO:     <IP_ADDRESS>:55822 - "POST /model_details HTTP/1.1" 200 OK
2024-11-22 02:50:27 | INFO | stdout | INFO:     <IP_ADDRESS>:55838 - "POST /count_token HTTP/1.1" 200 OK
2024-11-22 02:50:27 | INFO | stdout | INFO:     <IP_ADDRESS>:55844 - "POST /worker_generate HTTP/1.1" 500 Internal Server Error
2024-11-22 02:50:27 | ERROR | stderr | ERROR:    Exception in ASGI application
2024-11-22 02:50:27 | ERROR | stderr | Traceback (most recent call last):
2024-11-22 02:50:27 | ERROR | stderr |   File "/app/miniconda3/envs/vllm/lib/python3.12/site-packages/uvicorn/protocols/http/httptools_impl.py", line 401, in run_asgi
2024-11-22 02:50:27 | ERROR | stderr |     result = await app(  # type: ignore[func-returns-value]
2024-11-22 02:50:27 | ERROR | stderr |              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
2024-11-22 02:50:27 | ERROR | stderr |   File "/app/miniconda3/envs/vllm/lib/python3.12/site-packages/uvicorn/middleware/proxy_headers.py", line 60, in call
2024-11-22 02:50:27 | ERROR | stderr |     return await self.app(scope, receive, send)
2024-11-22 02:50:27 | ERROR | stderr |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
2024-11-22 02:50:27 | ERROR | stderr |   File "/app/miniconda3/envs/vllm/lib/python3.12/site-packages/fastapi/applications.py", line 1054, in call
2024-11-22 02:50:27 | ERROR | stderr |     await super().call(scope, receive, send)
2024-11-22 02:50:27 | ERROR | stderr |   File "/app/miniconda3/envs/vllm/lib/python3.12/site-packages/starlette/applications.py", line 113, in call
2024-11-22 02:50:27 | ERROR | stderr |     await self.middleware_stack(scope, receive, send)
2024-11-22 02:50:27 | ERROR | stderr |   File "/app/miniconda3/envs/vllm/lib/python3.12/site-packages/starlette/middleware/errors.py", line 187, in call
2024-11-22 02:50:27 | ERROR | stderr |     raise exc
2024-11-22 02:50:27 | ERROR | stderr |   File "/app/miniconda3/envs/vllm/lib/python3.12/site-packages/starlette/middleware/errors.py", line 165, in call
2024-11-22 02:50:27 | ERROR | stderr |     await self.app(scope, receive, _send)
2024-11-22 02:50:27 | ERROR | stderr |   File "/app/miniconda3/envs/vllm/lib/python3.12/site-packages/starlette/middleware/exceptions.py", line 62, in call
2024-11-22 02:50:27 | ERROR | stderr |     await wrap_app_handling_exceptions(self.app, conn)(scope, receive, send)
2024-11-22 02:50:27 | ERROR | stderr |   File "/app/miniconda3/envs/vllm/lib/python3.12/site-packages/starlette/_exception_handler.py", line 53, in wrapped_app
2024-11-22 02:50:27 | ERROR | stderr |     raise exc
2024-11-22 02:50:27 | ERROR | stderr |   File "/app/miniconda3/envs/vllm/lib/python3.12/site-packages/starlette/_exception_handler.py", line 42, in wrapped_app
2024-11-22 02:50:27 | ERROR | stderr |     await app(scope, receive, sender)
2024-11-22 02:50:27 | ERROR | stderr |   File "/app/miniconda3/envs/vllm/lib/python3.12/site-packages/starlette/routing.py", line 715, in call
2024-11-22 02:50:27 | ERROR | stderr |     await self.middleware_stack(scope, receive, send)
2024-11-22 02:50:27 | ERROR | stderr |   File "/app/miniconda3/envs/vllm/lib/python3.12/site-packages/starlette/routing.py", line 735, in app
2024-11-22 02:50:27 | ERROR | stderr |     await route.handle(scope, receive, send)
2024-11-22 02:50:27 | ERROR | stderr |   File "/app/miniconda3/envs/vllm/lib/python3.12/site-packages/starlette/routing.py", line 288, in handle
2024-11-22 02:50:27 | ERROR | stderr |     await self.app(scope, receive, send)
2024-11-22 02:50:27 | ERROR | stderr |   File "/app/miniconda3/envs/vllm/lib/python3.12/site-packages/starlette/routing.py", line 76, in app
2024-11-22 02:50:27 | ERROR | stderr |     await wrap_app_handling_exceptions(app, request)(scope, receive, send)
2024-11-22 02:50:27 | ERROR | stderr |   File "/app/miniconda3/envs/vllm/lib/python3.12/site-packages/starlette/_exception_handler.py", line 53, in wrapped_app
2024-11-22 02:50:27 | ERROR | stderr |     raise exc
2024-11-22 02:50:27 | ERROR | stderr |   File "/app/miniconda3/envs/vllm/lib/python3.12/site-packages/starlette/_exception_handler.py", line 42, in wrapped_app
2024-11-22 02:50:27 | ERROR | stderr |     await app(scope, receive, sender)
2024-11-22 02:50:27 | ERROR | stderr |   File "/app/miniconda3/envs/vllm/lib/python3.12/site-packages/starlette/routing.py", line 73, in app
2024-11-22 02:50:27 | ERROR | stderr |     response = await f(request)
2024-11-22 02:50:27 | ERROR | stderr |                ^^^^^^^^^^^^^^^^
2024-11-22 02:50:27 | ERROR | stderr |   File "/app/miniconda3/envs/vllm/lib/python3.12/site-packages/fastapi/routing.py", line 301, in app
2024-11-22 02:50:27 | ERROR | stderr |     raw_response = await run_endpoint_function(
2024-11-22 02:50:27 | ERROR | stderr |                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
2024-11-22 02:50:27 | ERROR | stderr |   File "/app/miniconda3/envs/vllm/lib/python3.12/site-packages/fastapi/routing.py", line 212, in run_endpoint_function
2024-11-22 02:50:27 | ERROR | stderr |     return await dependant.call(**values)
2024-11-22 02:50:27 | ERROR | stderr |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
2024-11-22 02:50:27 | ERROR | stderr |   File "/app/miniconda3/envs/vllm/lib/python3.12/site-packages/fastchat/serve/vllm_worker.py", line 217, in api_generate
2024-11-22 02:50:27 | ERROR | stderr |     output = await worker.generate(params)
2024-11-22 02:50:27 | ERROR | stderr |              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
2024-11-22 02:50:27 | ERROR | stderr |   File "/app/miniconda3/envs/vllm/lib/python3.12/site-packages/fastchat/serve/vllm_worker.py", line 173, in generate
2024-11-22 02:50:27 | ERROR | stderr |     async for x in self.generate_stream(params):
2024-11-22 02:50:27 | ERROR | stderr |   File "/app/miniconda3/envs/vllm/lib/python3.12/site-packages/fastchat/serve/vllm_worker.py", line 106, in generate_stream
2024-11-22 02:50:27 | ERROR | stderr |     sampling_params = SamplingParams(
2024-11-22 02:50:27 | ERROR | stderr |                       ^^^^^^^^^^^^^^^
2024-11-22 02:50:27 | ERROR | stderr | TypeError: Unexpected keyword argument 'use_beam_search'
Suggest a potential alternative/fix
No response
Before submitting a new issue...

[X] Make sure you already searched for relevant issues, and asked the chatbot living at the bottom right corner of the documentation page, which can answer lots of frequently asked questions.

2024-11-22 02:50:27 | ERROR | stderr | File "/app/miniconda3/envs/vllm/lib/python3.12/site-packages/fastchat/serve/vllm_worker.py", line 106, in generate_stream
2024-11-22 02:50:27 | ERROR | stderr | sampling_params = SamplingParams(
2024-11-22 02:50:27 | ERROR | stderr | ^^^^^^^^^^^^^^^
2024-11-22 02:50:27 | ERROR | stderr | TypeError: Unexpected keyword argument 'use_beam_search'

This looks like an incompatibility between FastChat and vLLM versions.

If FastChat doesn't correctly specify vLLM dependency, please open an issue on their repo instead.

2024-11-22 02:50:27 | ERROR | stderr | File "/app/miniconda3/envs/vllm/lib/python3.12/site-packages/fastchat/serve/vllm_worker.py", line 106, in generate_stream
2024-11-22 02:50:27 | ERROR | stderr | sampling_params = SamplingParams(
2024-11-22 02:50:27 | ERROR | stderr | ^^^^^^^^^^^^^^^
2024-11-22 02:50:27 | ERROR | stderr | TypeError: Unexpected keyword argument 'use_beam_search'

This looks like an incompatibility between FastChat and vLLM versions.这看起来像是 FastChat 和 vLLM 版本之间的不兼容。

How should this problem be solved? Which versions are compatible between fastchat and vllm?

Since fastchat uses vLLM (rather than the other way around), I suggest looking at the dependencies defined on their repo and install the exact version they use.

Since fastchat uses vLLM (rather than the other way around), I suggest looking at the dependencies defined on their repo and install the exact version they use.由于 fastchat 使用 vLLM（而不是相反），我建议查看其存储库上定义的依赖项并安装他们使用的确切版本。

Thank you very much. I will give it a try


Is disk type=thin ignored for vsan in favor or vsan storage policy ?

Support Question
When trying to enable thin provisionning for vsan disks using persistent disk type=thin, I observe in vsphere UI that the disk isn't explicitely labelled as thin provisionning, despite the cpi vsphere api calls do indeed specify it
https://bosh.io/docs/vsphere-cpi/#disk-pools

type [String, optional]: Virtual disk type used for persistent disks: thick, thin, preallocated, eagerZeroedThick. Defaults to preallocated. Available in v12. Overrides the global default_disk_type.

Disk detail in UI

CPI disk log:
 <backing xsi:type="VirtualDiskFlatVer2BackingInfo">
  <fileName>[my-vsan-datastore-name]
    12e55064-f0ef-b748-1987-e20a67700087/Integration/disks/disk-7bc4322d-c54f-4c0d-bc3e-2c4873db179c.vmdk
  </fileName>
  <datastore type="Datastore">datastore-18</datastore>
  <backingObjectId>34aa8666-8486-446a-f404-e20a67700073</backingObjectId>
  <diskMode>independent_persistent</diskMode>
  <split>false</split>
  <writeThrough>false</writeThrough>
  <thinProvisioned>true</thinProvisioned>
  <eagerlyScrub>false</eagerlyScrub>
  <uuid>6000C295-de95-41db-306d-3628ce4aaf2f</uuid>
  <contentId>f1261bf083a0fcddc6d7216afffffffe</contentId>
  <digestEnabled>false</digestEnabled>
  <sharing>sharingNone</sharing>
</backing>

Is this the normal expected behavior from VSAN disks, and would a PR on bosh-docs be accepted to clarify scope of persistent disk types (i.e. ignored on vsan) ?

You can also reach out to us via:

Slack: http://cloudfoundry.slack.com/messages/bosh-cpi-dev

@klakin-pivotal, you have any thoughts on this?

@gberche-orange If you change the disk provisioning type to thick or eagerZeroedThick, does that change the VM storage policy of the related disk?
Given that it seems like we're passing through the instruction to thin provision the disk to vCenter, I wonder if this is a bug in the IAAS... whether a vCenter display bug, or a VSAN bug.


Fix path resolution in check_samplesheet

Before
Relative paths were resolved relative to a work directory parent
e.g. stuff/work/a1/c2/samplesheet.csv -> stuff/cineca.vcf.gz
This can be quite fragile if you change the default work directory location and is quite confusing behaviour.
It also breaks running the test profile from nextflow directly (nextflow run pgscatalog/pgsc_calc) with local files.
Now
The samplesheet path is resolved and relative genome paths are joined with the parent directory.
e.g. stuff/work/a1/c2/samplesheet.csv -> original_dir/samplesheet.csv -> original_dir/cineca.vcf.gz
New features:

Doesn't try to resolve remote paths (s3:// or https:// prefix), trust nextflow to handle this
Throw an error if you try to use insecure remote paths (http://)
Will allow support for running test profile offline with nextflow run pgscatalog/pgsc_calc and nextflow run main.nf

Closes #51

yes, I think it's simplest to merge and test offline 😄


Integrate Nebula into our setup

I've done some testing of ZeroTier, WireGuard, TailScale, Nebula,  and concluded that Nebula strikes a perfect balance between the ease of use, security, speed, and configuration flexibility. I'd like to make Nebula our default go-to solution for the desktop clients to cluster connections and node-to-node overlay networking.
Here is what needs to be done to get there:

Improve Nebula Control Plane REST API, and make it "production grade"
Improve Nebula service integration, and implement multi-tenancy on the Hoster node's end (as of now only a single service instance is supported, due to the hardcoded tunnel device name in our config implementation)
Make a cross-platform desktop app for an easy Windows, Linux and Mac integration
Implement a controller WebUI around the Nebula Control Plane REST API for ease of management (something similar to ZeroTier admin UI)
Online client status dashboard (Nebula doesn't have a mechanism to show this natively)
Ability to easily rotate the CA certificate, in case it has been leaked, hacked or if one of the clients was breached
Ability to add site-wide and client specific Nebula firewall rules (in case someone left the org and their access have to be blocked)
Logging system for Nebula Control Plane REST API to be able to audit who and when joined the network
Nebula service supervisor, to better integrate into the Hoster's service ecosystem

Closing this until "better times", as it requires a lot of time and effort to implement. Use ZeroTier/WireGuard for now please.


Setup and controllers

Changes in this PR:
I've added routes, actions, controllers, and views.
Additions:

routes:

users
users/id
users/id/posts
users/id/posts/id

controllers:

posts
users

views:

users:

index
show

posts

index
show

extras:

linters:

stylelint
rubocop

Thank you!


Performance implications of using JinjaX components

TL;DR
It is clear that JinjaX is not indented for use cases where performance is of any concern whatsoever. Its use in mbdb-app must be avoided until such time when JinjaX's performance is comparable to plain Jinja.
When I mostly finished the rewrite of the original record view code to make use of JinjaX components, I noticed severe performance degradation. A single page with a randomly generated MST record took 12 (twelve) seconds to render, a result that is clearly problematic. While the randomly generated records are quite large and I have been testing the JinjaX-ed rendering code on a considerably slower computer, I did not believe that this alone could explain the performance difference against the old code which rendered a page in about 1 second. Since the only real change was the move from Jinja macros to JinjaX components, I suspected JinjaX to be responsible. A rewrite of two "hot paths" away from JinjaX reduced the rendering time from 12 to about 4 seconds. This clearly pointed to a JinjaX-related issue.
To understand what was going on, I created a simple benchmark (see the attached archive). The benchmarking code renders a simple list-like HTML structure where each element of the list is rendered by a Jinja macro or a JinjaX component, respectively. Total time needed to create Jinja environment, JinjaX Catalog and to render the template is measured.
Plain Jinja performs like this:
$> ./main.py --loops 50000
$> Total time needed to run the render function: 0.22861504554748535 sec

This is a staggering difference compared to JinjaX
$> ./main.py --loops 50000 --jinjax
$> Total time needed to run the render function:  10.462630271911621 sec

This makes JinjaX about 45x slower than Jinja in this simple test.
Each JinjaX component must be backed by a separate file. When a JinjaX component is rendered, catalog.render() function is called for each "instance" of that component on a page. As one of the first steps, JinjaX reads the content of the backing file from disk. There is no caching involved anywhere so if a component is present 1000 times on a page, it's file will be open()ed, stat()ed, read() and close()d that many times. A crude hack to allow for caching of component files helped a bit:
$> ./main.py --loops 50000 --jinjax
$> Total time needed to run the render function:  8.518791198730469 sec

Another bottleneck is caused by JinjaX needing to calculate the path to each component file every time it renders it. The _get_component_path() queries the filesystem in a non-trivial loop, again making an unknown number of syscalls. Another crude hack to cache the paths showed that this constant path calculation is an even bigger problem than the constant re-reading of the component files.
$> ./main.py --loops 50000 --jinjax
$> Total time needed to run the render function:  4.333554983139038 sec

After that, there are no easy performance wins to be made. Jinja is fast because - as far as I understand - it compiles its templates to some kind of bytecode to avoid the expensive parsing. JinjaX appears to reparse components on every re-render.
jinjax_bench.zip

Thanks for doing the research on this!
Although this might be solved by using a bigger hammer in deployment (i.e.  CESNET infrastructure vs. PC hosting), it will be rather painful from development perspective I would say, as Biocev can't get admin rights so we basically have to run it locally for development.
@mirekys and @Alzpeta, do you have ideas how it could be improved or is this the price for switching to jinjaX?

Thanks @MadCatX for raising this issue and for your work on on benchmarking & profiling! You probably already have more knowledge into this topic than the two of us, I'm afraid :). I think this needs to be brought to attention of the library authors, they might have some ideas on how/where to improve rendering (if not, we might need to seriously consider falling back to original macros, atleast for complex pages like this, or we will need to dedicate some serious effort on deep understanding of the library & how it could be improved). Could you please raise an issue there & provide them with the benchmark? Even this info here could already help them to try to improve the library for everyone. Thanks a lot 👍

This can be imho easily fixed on our side just with a simple caching (in production, not when flask_debug is set). @Alzpeta - please have a look at it.

@mirekys Considering the activity on the JinjaX's GH repo, I appears than JinX is a project of a single person developed in spare time rather than a systematically developed thing. Therefore I'm afraid that we can't realistically expect much to be done in the performance front. If you'd like to raise an issue with JinX developer, by all means do so but I'm afraid that I personally won't have time to follow up on this.
@mesemus Caching may alleviate the worst of it but even the developer experience is very much affected by JinX. The reason why I noticed the problem in the first place was because every single refresh of the record view was taking noticeably more and more time as I was adding more items for display.
In mbdb-app I solved the immediate issue by going back to plain Jinja macros. Only the top-level components remain as JinX components.
I think we can close this as "investigated/known".


Roll engine 8dc3a4cde207..0a6aeb347000 (26 commits)

https://github.com/flutter/engine/compare/8dc3a4cde207...0a6aeb347000
git log 8dc3a4cde2075a4f5458fd0eb199627f5124508d..0a6aeb34700047d0cac168389b2d8aae1eff75a3 --no-merges --oneline
0a6aeb347 Roll src/third_party/skia 213aa46af167..176b214f91bc (2 commits) (flutter/engine#9100)
f2e22aa3c Roll src/third_party/skia 7730d7cb8fb2..213aa46af167 (3 commits) (flutter/engine#9098)
557db42ad Roll src/third_party/skia de7e074e8190..7730d7cb8fb2 (2 commits) (flutter/engine#9096)
64a4a0eaa Roll src/third_party/skia f06b6d5469a5..de7e074e8190 (1 commits) (flutter/engine#9094)
fdee6256a Roll src/third_party/skia 7e5a64f517e4..f06b6d5469a5 (2 commits) (flutter/engine#9093)
daf47f0b4 Roll src/third_party/skia dc01a84ae098..7e5a64f517e4 (1 commits) (flutter/engine#9092)
41e10f07f Fix internal break since listing contents can return null (flutter/engine#9078)
cf1b20318 Roll src/third_party/skia f33c95cd6f55..dc01a84ae098 (3 commits) (flutter/engine#9091)
2404cdc90 Rename macOS FLEPlugin* to FlutterPlugin* (flutter/engine#9074)
509a43fe2 Apply minor cleanups to Android embedding (flutter/engine#9088)
0a0f3305b Removed outdated deprecation comments (flutter/engine#9087)
a44cbbf49 Delete BSDiff sources (flutter/engine#9086)
0f1ff3bdb Correct typos, adopt US spellings (flutter/engine#9081)
651c90409 Use track-widget-creation transformer included in the sdk. (flutter/engine#9085)
cfa524fcd New Plugin API PR4: Adds Lifecycle support to the new plugin system. (flutter/engine#9049)
6b8ac18b8 Roll src/third_party/skia d9430297e74a..f33c95cd6f55 (5 commits) (flutter/engine#9082)
11408effd Update macOS podspec version requirement (flutter/engine#9077)
66c6ae48e Roll src/third_party/skia a4b837971c4b..d9430297e74a (30 commits) (flutter/engine#9080)
9151b377e Roll src/third_party/skia 9339a8a61af0..a4b837971c4b (34 commits) (flutter/engine#9076)
ee6a9c404 Fix unchecked operation warnings in FlutterMain (flutter/engine#9073)
333042cf3 Roll third_party/dart/tools/sdks to 2.3.0 (flutter/engine#9072)
01b8c078c Roll src/third_party/skia f77dbd04b926..9339a8a61af0 (12 commits) (flutter/engine#9065)
26b4fb57f Roll src/third_party/dart e3edfd36b2..ec4d48e241 (7 commits)
9d2d58a3c Add mouse button support to the macOS shell (flutter/engine#9054)
b17c0c6e6 Add a podspec for FlutterMacOS.framework (flutter/engine#9062)
82ccba303 libtxt: have GetRectsForRange(strut) fall back to tight bounds if layout isn't forcing use of the strut (flutter/engine#9058)
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff (cbracken@google.com), and stop
the roller if necessary.

Trybots failed. These were the failed builds: https://cirrus-ci.com/task/6326463867912192 , https://cirrus-ci.com/task/4510070658826240 , https://cirrus-ci.com/task/5200563961069568 , https://cirrus-ci.com/task/5622776426135552 , https://cirrus-ci.com/task/6748676332978176 , https://cirrus-ci.com/task/6185726379556864 , https://cirrus-ci.com/task/5059826472714240

Commit queue failed; closing this roll.


dub fails with --build-mode=allAtOnce, but succeeds with default

To reproduce:

Clone https://github.com/qznc/prema (revision 2ece73c at the time of writing)
dub build --force succeeds
dub build --build-mode=allAtOnce --force fails with lots of linker errors, like

../../../afs/info.uni-karlsruhe.de/user/zwinkau/.dub/packages/vibe-d-0.7.30/vibe-d/libvibe-d_core.a(libevent2_1f8c_5d7.o): In function `_D4vibe4core7drivers9libevent215Libevent2Driver6__ctorMFNbC4vibe4core6driver10DriverCoreZC4vibe4core7drivers9libevent215Libevent2Driver':
/data1/zwinkau/prema-dev/../../../afs/info.uni-karlsruhe.de/user/zwinkau/.dub/packages/vibe-d-0.7.30/vibe-d/source/vibe/core/drivers/libevent2.d:97: undefined reference to `event_set_mem_functions'
/data1/zwinkau/prema-dev/../../../afs/info.uni-karlsruhe.de/user/zwinkau/.dub/packages/vibe-d-0.7.30/vibe-d/source/vibe/core/drivers/libevent2.d:106: undefined reference to `evthread_set_lock_callbacks'

Am I using it wrong? The only documentation I found is that build-mode "Specifies the way the compiler and linker are invoked."

Looking at DUB's debug output, it appears that this might be an issue in DMD. The appropriate linker flags get passed to it (e.g. -L-levent), but it seems like they don't get passed on to the linker, or maybe in the wrong order (cf. --as-needed).


class.text is messed up bad

unless my mozilla is royally fubar'd then the class.text file repeats 3 times and is incomplete

What branch and filepath are you talking about?

ok to delete


inaccurate VQA score

When I finetune the model with VQAv2,
It produces a lower score than that proposed in the paper. (43%)
Can you explain where this difference comes from and how to fix it??

How many epochs did you run. Did you properly initialized the model weights?

10 epochs and I initialized with pre-trained TVLT weights from huggingface named TVLT.ckpt

Hi! I'm experiencing the same issue and have found no performance difference between randomly initialized models and pre-trained checkpoints.
So, one suspicion is there might be some problems in the initialization. Is there a way to check if the model is properly initialized?


Delete DBRefs when referenced document is removed.

Maybe this point has already been treated, but i can't find infos on it.
The thing is that i have two documents A and B.
A has a dbrefs containing B.
But B can be deleted.
What happens for A ?
Currently with the dev-master branch.
If i do a query retrieving A documents and B DBRefs is referencing a "non existing anymore" document, it obviously throw a documentnotfound error.
So how properly remove the dbrefs from the document ?
Could we create a referencedIn property for the Document Annotation ?
Thanks

+1 for this feature.
@smilesrg thanks for tips !

@jmikola @malarzm this issue has been opened since 2013... Maybe it's worth to implement it?

@smilesrg I won't have time in upcoming month as right now I'm focused on making 1.0 a real thing, however I can provide some help if it'd be needed (read as PR is welcome and feel free to ping me in case of troubles ;) ).
Two cents from me:

I think this should be an opt in feature
"Association dependencies are currently handled to some degree when calculating commit orders" is no longer true as we have removed commit order calculator.

Do you dnow that this feature is implemented by DoctrineExtensions ?
https://github.com/Atlantic18/DoctrineExtensions/blob/master/doc/reference_integrity.md

Cool! That takes feature off our plate then :)

:+1:


Changing search inputs value through clicking context menu doesn't send any browser .trigger()s

Meaning it's not possible to add a callback because there is no trigger to attach it to.
example:
http://i.imgur.com/MhtmW0e.gif
when you click on the suggested value, the 's value is changed using .val(), which doesn't send a .trigger() meaning you can't do something like $(input).on("change", function()). Please update the search to also add a trigger() when the val is being updated.
Thanks

theres a callback onSearchQuery which can be attached whenever a value is searched. There is also onSelect callback.

@jlukic It is labeled as Already Fixed shouldn't it be closed?

Yes, sorry the boards need a little pruning.

No problem, will try to help with that when I'm bored. :-)


Missing Observable#toPromise and Observable#just?

I'm using rxjs v. 5.0.0-beta.1 from npm, along with angular2 2.0.0-beta.0.
I see the definitions for toPromise and just in the TypeScript definition files, but I'm getting the following errors when trying to use them in the browser:
Uncaught TypeError: context.returnsObservable(...).just() is not a function(…)
Uncaught TypeError: context.returnsObservable(...).toPromise() is not a function(…)
My TypeScript class is importing observable-- I couldn't find anything else that I needed to import:

import { Observable } from 'rxjs/rx';

Am I missing something, or has this not been fully implemented, yet?

You may import Rx for module contains core operators like
import * as Rx from 'rxjs/rx';
Rx is out of box prepared module contains most of common operator for use.
In case of module Observable, it allows to import each individual operator you'd like to include instead of import everything at once, such as
import {Observable} from 'rxjs/Observable';
import 'rxjs/add/operator/map';

Observable.of(1,2,3).map(x => x + '!!!'); // etc

This (https://github.com/ReactiveX/RxJS#es6-via-npm) will gives brief explanations of importing it.
For operator just, you can use of.

@ps2goat , let me close this issue by module import is instructed and believe you can import either core module or separate module. If you're experiencing problems still with those, please feel freely reopen.

just operator  in rx4 was quite explicit and beautiful especially when uses just as "naked" factory:
let {just, of} = Rx.Observable

source$ = just(1) // is better than:
source$ = of(1)

import * as Rx from 'rxjs/rx'; did work for me.  It was just confusing that the typings said a method was there, but it really wasn't until I'd imported each extension (e.g., the * alias).

You are making the same mistake I, and hundreds of other actually made. Simple fix:
npm uninstall rxjs --save
npm install rx --save
There are two libraries on npm and it is quite misleading if you don't look carefully.
On npm:
rx relates to https://github.com/Reactive-Extensions/RxJS
rxjs relates to github.com/ReactiveX/RxJS
Feel free to send a message to jeffbcross and ask him to disclaim the difference between his lib and what I refer to as the official one. If he leaves this it will be a confusing fork in the road which will continue to impact others.

@J0NNYZER0 yes, the rx package is not this project.

That's very interesting, because @angular v2.1.0 depends on rxjs 5.0.0-beta.12 which is this project.
And it does seem to be lacking Observable#just.
Is there anything that could be used instead? Would of() with one element produce the same result?

@alobakov yes, Observable.of with one element is intended to replace just.


Diskspace health check

Added diskspace_health_check_flow.yaml + small changes.

why you added to rest_operations.yaml the namespace "lists.manipulation"?
check_availability should be a seprate file... at at has nothing to do with linux_ops, it should be a generic op of "compare int" or something likethat
did you check "df -Pkh | grep -v "Filesystem" | awk 'NR==1{print $5}'" with other linux machine (not ubuntu) ?
The change in docker_operations.yaml, is wrong, you will get only dangling images frrom it, but that not what we want, we need one step to get all images and a DIFFERENT step to get ONLY dangling images  . Please revert your change in this file, ADD a new operation with the cmd docker images -f dangling=true -q , and cuild a subflow from it
typo in diskspace_health_check_flow.yaml , in the flow name : diskspace_heath_check_flow
we need another flow output of how many docker images were actually deleted..
you need to resolve conflicts...

it was a mistake, changing back.
2.true, I was not sure where to put that though. I'll do that
3.no, I'll check.
4.5 6 7 - taking care of them

@TudorLesanHP can you fix merge conflicts ?

why did you merge this? isn't it the same as the one in content?


Import performance

Importing pacmap takes ~4.3 seconds on my machine (core I7/ 8th Generation, 40GB RAM, python 3.8.10). Since i want to include it in my package i overtake these 4.3 seconds into my package and delays everything by a lot.
Could you increase the import performance?
Timed with multiple runs of
python3 -m timeit -r 1 "import pacmap"

I made an investigation into the import process and on my machine it takes even longer to import (~10s). The tuna log doesn't say much about the root cause of the slow import, but I suppose the just in time compiler we used for the functions is the culprit. When you import pacmap, the functions will be compiled. I will try to fix this issue by caching some of the compiled function, which hopefully can reduce import latency.

The latest version on GitHub should be able to resolve this issue by reducing the import time to around 30%, and a release on PyPI will follow shortly. Closing this issue.


fix(examples): print all packages in package manager

This PR include the next small corrections related with the package manager example:

The packages counter in the progress bar is incorrect
The latest package is not printed

Before

After

Thanks for bumping this, @bubylou, and thanks so much for the fix here @Madh93! We meant to merge this one right when it came in.
@Madh93, do you mind rebasing this one on main? Once that's done we'll merge it in.


The heading says communicate between swarm service and standalone container but explanation is for communication between two standalone containers

File: network/network-tutorial-overlay.md

https://docs.docker.com/network/network-tutorial-overlay/#communicate-between-a-container-and-a-swarm-service
This mainly explains about running two alpine Linux containers attached to default bridge network with the ping  and ping  outputs.
Please update this with an example for standalone container and swarm service
Thanks
Sathya

same problem.
It's sad when read the official doc to learn docker network and find there are problems in the doc.


Could not resolve to contig ID

Hi,
Thanks for providing this tool and the exciting CUT&TAG-pro. When I try to run the example, it will raises an error 'thread 'main' panicked at 'Could not resolve to contig ID', src/fragment.rs:32:23'. The issue is gone when running chr1 only (via --onlyone).  I thought it fails to convert chromosome name to id, but I am not sure how to handle that.
The completed log message is ⬇
2021-10-13T16:29:51.946Z INFO  carina::file > Found File w/ tag "model" at "/home/scChromHMM/example1/model_2.txt"
2021-10-13T16:29:51.947Z INFO  schrom::hmm  > Read HMM model paramers: Found  { #states: 2, #assays: 3 }
2021-10-13T16:29:51.947Z INFO  carina::file > Found File w/ tag "common_cells" at "/home/scChromHMM/example1/cells.txt"
2021-10-13T16:29:51.952Z INFO  schrom::hmm  > Found 7201 cells in common assay, first cell=E2L1:AAACGCTGTAACCAGG
2021-10-13T16:29:51.955Z INFO  carina::file > Found File(s) w/ tag "anchors" at ["/home/scChromHMM/example1/k27ac.txt", "/home/scChromHMM/example1/k27me3.txt", "/home/scChromHMM/example1/k4me1.txt"]
2021-10-13T16:29:51.983Z INFO  schrom::hmm  > Found 3 assays with [19, 22, 32] cells and [2465, 3706, 3699] anchors
2021-10-13T16:29:51.984Z INFO  carina::file > Found File(s) w/ tag "fragments" at ["/home/scChromHMM/example1/h3k27ac_fragments.tsv.gz", "/home/scChromHMM/example1/h3k27me3_fragments.tsv.gz", "/home/scChromHMM/example1/h3k4me1_fragments.tsv.gz"]
2021-10-13T16:29:52.008Z INFO  schrom::hmm  > Found total 22 chromosomes
2021-10-13T16:29:52.008Z INFO  schrom::hmm  > Starting forward backward
thread 'main' panicked at 'Could not resolve to contig ID', src/fragment.rs:32:23
Thanks for any suggestions!

Hi,
Following up to see whether I can get some suggestions, thanks!

Hi @Xieeeee ,
Thanks for reaching out, your intuition is correct that it's failing to convert chromosome name to id, reason being, the tools is designed by default to work with all 22 chromosomes and when run with the test data it fails since test data has fragments from only chromosome 1. We added the flag --onlyone to inform the tool to perform segmentation on chromosome 1 only and that's why you don't see error when you run the tool with --onlyone flag. Hope it helps.

Hi @k3yavi ,
Really appreciate your answer. I will try running on my toy data soon and will let you know how it goes.
Cheers


Render only needed sortable items

fixes #1071, fixes #994, fixes #898 and probably fixes #943 and others
based on https://github.com/clauderic/dnd-kit/pull/1088 so all changes that were there are here as well
still re-renders all the sortable items if the passed items into context change. probably fixable as well, but I think this is already much better.
it was impossible to do without changes to the API and implementation:

getNewIndex is now passed to the context instead of useSortable
no more localStrategy, I couldn't find a use case that can't be solved in global strategy (I'm passing id there as well) if you know of one let me know
in useDroppable active is defined only if it's over the item
useSortable does not expose isSorting 'activeIndexandoverIndex`
in useSortable active is defined only for active and over items
in useSortable over is defined only for active and over items

all stories seem to work as before with a few changes.
added tests to verify which items are re-rendered
** I think that active and over names should be changed to explain if I am over some item or some item is over me
and strategy and getNewIndex should be connected, also animateLayoutChanges is very confusing

@clauderic is there hope for this PR? with some changes probably

@alissaVrk Can you publish this changes in npm as a custom modified dnd-kit package?

@bryanjtc how should I name it?

@hexwit The bug described above was a result of the typo, so adding items to the dependency array solves it.
The only major issue I'm experiencing now is related to the initial rendering of conditionally rendered items - e.g., you have two selectable tabs A and B, each conditionally rendering hundreds of sortable items when clicked. If you click on B, for instance, the initial render of the sortable items associated with that tab usually takes a long time, frequently freezing the app.
@alissaVrk You had mentioned the possibility of bringing further improvements to this already amazing contribution - any idea of what those could be or if you would be willing to implement some of them?
Besides unusual rendering, the extreme number of calls to some functions (i.e., collision detection) is also appalling.

@bryanjtc @tomasmenezes published this PR at @alissavrk/dnd-kit-sortable, @alissavrk/dnd-kit-core etc.
there is a sandbox that uses these versions
I did bump versions but didn't update the readme or anything else..
@tomasmenezes about further improvements, I don't remember exactly, one of them had to do with rendering all items on drop. but what is the point if it doesn't get merged?
I can probably recreate the list of API changes I thought would be nice
I guess we could create a new library based on this one, but I don't really understand how are people expected to find it :)

any update on this?

@clauderic I'd love to see this merged into a major version of dnd-kit. We're currently using it at my company and are having some rerendering issues related to DndContext. Thanks!

@alissaVrk Sounds amazing! There is still much to improve. Imo continuing this work is extremely meaningful as it has a huge measurable impact in the community's experience - especially regarding essential performance issues such as this one, that should be quickly addressed.
It is frustrating that this hasn't been officially acknowledged or merged, and a lot of others are echoing that sentiment judging by the amount of new posts about the lack of updates, contributions and future direction for the library. Maybe a proper fork or a new library (depending on the arch changes) are indeed the best way to move forward!

@alissaVrk Hello, can u help me? I use react + vite + ts and I got next error after npm i ur packages [plugin:vite:import-analysis] Failed to resolve entry for package "@alissavrk/dnd-kit-core". The package may have incorrect main/module/exports specified in its package.json.

@kirill2400 hi, sorry that it took me so long..
maybe you didn't install the core package
place take a look at the sandbox using this package

@kirill2400 hi, sorry that it took me so long.. maybe you didn't install the core package place take a look at the sandbox using this package

I have a similar problem with your package, apparently something is missing inside the package to make it work correctly with vite as I understand it
https://github.com/vitejs/vite/issues/7725

@alissaVrk @kirill2400 I've identified and "fixed" the issue with Vite.
The packages built and published get built under the name dist/dnd-kit-<package>.esm.js; however, in the published packages, the package.json points the module field to dist/<package>.esm.js.
To "fix" this, I have added the following yarn scripts to my project's package.json file:
"fix-dnd-kit-fork-accessibility": "json -I -f<EMAIL_ADDRESS>-e \"this.module=\\\"dist/dnd-kit-accessibility.esm.js\\\"\"",
"fix-dnd-kit-fork-core": "json -I -f<EMAIL_ADDRESS>-e \"this.module=\\\"dist/dnd-kit-core.esm.js\\\"\"",
"fix-dnd-kit-fork-modifiers": "json -I -f<EMAIL_ADDRESS>-e \"this.module=\\\"dist/dnd-kit-modifiers.esm.js\\\"\"",
"fix-dnd-kit-fork-sortable": "json -I -f<EMAIL_ADDRESS>-e \"this.module=\\\"dist/dnd-kit-sortable.esm.js\\\"\"",
"fix-dnd-kit-fork-utilities": "json -I -f<EMAIL_ADDRESS>-e \"this.module=\\\"dist/dnd-kit-utilities.esm.js\\\"\"",
"fix-dnd-kit-fork": "yarn fix-dnd-kit-fork-accessibility & yarn fix-dnd-kit-fork-core & yarn fix-dnd-kit-fork-modifiers & yarn fix-dnd-kit-fork-sortable & yarn fix-dnd-kit-fork-utilities"

By running yarn fix-dnd-kit-fork after installing the packages, all the package.json files will be correctly fixed for the accessibility, core, modifiers, sortable and utilities, and vite will work.
It's a hacky solution, but should do the trick until this gets oficially merged in, and you want to use this fork instead of the official dnd-kit release.

@alissaVrk btw, that performance issue I mentioned earlier in the thread is exemplified in this stress test sandbox. Simply changing the active window takes removeChild for a ride. The instance usually crashes when the console is active, and it doesn't seem like further memoization does much.

@tomasmenezes hi, sorry it took me so long (I'm not using this lib anywhere, and back to work :) ).
I have tested the new experimental branch. and it seems that this issue - that all items render regardless of memoization -  doesn't reproduce there.
so once it's production-ready things should be better

hi @alissaVrk, @tomasmenezes!
@alissaVrk are you using another library?

@clauderic, are there any reasons to not merge this PR (once conflicts are resolved) and release a new versions as an immediate fix for performance related issues that's been bugging the library for a while now?
I mean - assuming that the experimental branch production release date is probably not anywhere close (as it's barely an alpha), wouldn't that make sense to fix the issues for all the current users of the library? 🤔

Welp. It's been almost 3 months now, so I'll risk asking - was there any development on merging this branch?
I do not intend to sound ungrateful, but it feels as if fixing issues on the currently released versions of the library might have a bit higher priority than working on the experimental branch, as it directly affects many more people (as in - majority of library users) would it not?

I agree. This is a breaking issue that makes this library not production-ready for me, or anyone with a complex use case that requires rendering more than a few components.


Move up duplicated validator

Coverage increased (+0.5%) to 49.628% when pulling 082a792d1db0723d3fea5cf03b2da1c8b79f3a02 on sasha-kantoriz:a616519801943075_refactoring into ffe43d7962ad9c0b3f169e735259f83a278a5e96 on openprocurement:master.


Cleanup todo items

This resolves #485

Merged via https://github.com/spring-cloud/spring-cloud-stream/commit/c8154203058a5c1d046cc24ce772ecfb011f3dde


Add instructions for warming up the database.

ping @ldko @somexpert
We need to include an instruction on our READMEs for warming up the database when the project uses Docker Compose and MySQL.

:+1:

:+1:

:thumbsup:


Remove package-lock.json and clean up optional dependency handling

Optional deps should now be installed just be adding --install to commands that require it (which just calls npm install --no-save). sigh install  is gone. npm install/update will not remove optional deps.
Travis will no longer build at the lock version set, but that wasn't really gaining us anything anyway. I've added a logging command to list the top-level packages and their versions in case that ever matters.

One consequence of this is that we lose the version info for the optional packages. I don't think we actually care that much about this, and if we end up needing a specific version (most likely due to forking something) we can just make sigh handle it.

Sorry for delay, I just saw this. I support trying this out. Probably worth another PSA to team before you land it. I know you discussed it previously already.

No worries, I realise you weren't actually at work when I sent this :)
On Fri, 25 Oct 2019 at 06:41, Walter Korman<EMAIL_ADDRESS>wrote:

Sorry for delay, I just saw this. I support trying this out. Probably
worth another PSA to team before you land it. I know you discussed it
previously already.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/PolymerLabs/arcs/pull/3720?email_source=notifications&email_token=AIHN4TJ5CVM7PCMQC4SDBULQQH27ZA5CNFSM4I6LTVJKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOECGGOEY#issuecomment-546072339,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AIHN4TPBASHRS55OARXTTADQQH27ZANCNFSM4I6LTVJA
.


Fix test flakiness for cas provider

Fixes
Try to fix test flakiness:
[error]    If you're unsure why you're getting above error read on.
[error]    Due to the nature of the syntax above problem might occur because:
[error]    1. This exception *might* occur in wrongly written multi-threaded tests.
[error]       Please refer to Mockito FAQ on limitations of concurrency testing.
[error]    2. A spy is stubbed using when(spy.foo()).then() syntax. It is safer to stub spies -
[error]       - with doReturn|Throw() family of methods. More in javadocs for Mockito.spy() method. (CasProviderSpec.scala:100)
[error] play.silhouette.impl.providers.CasProviderSpec$$anon$8.<init>(CasProviderSpec.scala:100)

@Mergifyio backport 9.x


DocsArchive-<IP_ADDRESS>Auto archive content

Please don't merge this PR until target archive repo PR https://github.com/OPS-E2E-PPE/docs-archive-test-target/pull/74 is merged into live branch.
Auto archive content to https://github.com/OPS-E2E-PPE/docs-archive-test-target.git

Docs Build status updates of commit 0d3dc32:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

[Error]

Cannot sync git repo to specified commit because branch Archive_master_2019-09-25-06-38-49 has been deleted or has been force pushed: fatal: Couldn't find remote ref Archive_master_2019-09-25-06-38-49

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Why dependency on Jquery is needed???

Why is Jquery dependency needed for saas-ui. Can we get rid of this please?
Thanks

Could you give some more info, where did you find this? There isn't any direct dependency on Jquery.

Closing this for now.


Support negative stride

Add support for negative stride to FrameBuffer Slice.
Change data type of stride from size_t to ptrdiff_t.
Add support for negative stride in copyIntoFrameBuffer and copyFromFrameBuffer.
Add a new testNegativeStride test.
Fixes: #614
Signed-off-by: 胡玮文<EMAIL_ADDRESS>

CI now works in my fork. I've added the missing includes.

Hi all, anything I can do to push this PR forward?

@peterhillman ~ @huww98 has addressed my structural comments about the code. Have you had a chance to think about the negative stride issues that you brought up earlier? In my mind, I'm not quite picturing how the proposed MakeFlipped use case would look, since it would seem like you'd have to set up an incorrect positive stride and then heal it later. The advantage of the negative stride at construction is that the pointers are never in an unworkable state. But maybe I'm misunderstanding the construction suggested?

I think all those changes are good.
In addition, I'm suggesting we also add another 'Make' function to build a Slice object for reading flipped images: the caller passes the pointer to the first byte of their array, and it computes the correct base pointer for them, setting up the negative yStride. So the user would never need to compute a yStride, either positive or negative.
@kdt3rd added the static Make functions because computing the base pointer correctly is hard, particularly if there's a possibility of integer overflow, and I think it's harder still when you want to read images flipped. Code that gets this wrong would crash (or worse) when opening an image that has a dataWindow that doesn't match the displayWindow.

Ah, thank you, now I understand :)
@huww98 could we ask you to add the additional Make function please?

@peterhillman I agree that computing the base pointer for the user can be helpful. But should we defer that to another PR?
I think adding more 'Make' overload can result in a combination explosion in the future. Maybe we should just add two parameters (bool flipX, bool flipY) to the existing Make overload (Another ABI breaking change)? Or as I proposed before, Add some method like Slice::flipY() so:
auto slice = slice::Make(..., /*flipY=*/true);

is equivalent to
auto slice = slice::Make(...);
slice.flipY();

I just noticed https://github.com/AcademySoftwareFoundation/openexr/blob/55bdfd181200cc098ddd9f3919019250e1ba7ee6/src/lib/OpenEXR/ImfFrameBuffer.cpp#L72
Should I change it to yStride = (w / xSampling) * abs(xStride);?

I don't think Make() is useful with negative xStride or yStride, as currently implemented. Make() assumes it is provided with the pointer to the beginning of the user array (plus an offset to account for the channel index), and it computes the offset to pixel 0,0 for you, so the Slice is initialized correctly.
If we are happy with 'negative stride' implying the image will be flipped on read, The Make method might as well follow the same convention, which should mean new overloads or extra parameters aren't required to indicate flips. But it does need extra logic to test for negatives and get the pointer right.
I've not properly thought this through but the overload that takes a dataWindow could be passed negative strides to indicate flipping or flopping, and that would compute the correct base pointer for you, using dataWindow.max as well as dataWindow.min. It might also be possible to implement that in the "origin,width,height" overload, but perhaps that's more confusing, as it's not obvious which 'origin' it wants when the image is flipped, and whether width and height should also be negative. Perhaps it would be clearer if that overload stayed as it was, with unsigned strides, so it' doesn't support flipping.
Is it possible to implement Slice::flipY()? Slice doesn't know the size of the dataWindow, which is required to adjust the base pointer.
Usually Make is used something like frameBuffer.insert( "R" , Slice::Make(base,...))  so there's no elegant place to call flipY()

I would like the new semantic of Make with "negative stride" to be:

negative stride indicates flipped image
ptr points to the expected destination of the pixel at origin, so that I can just pass in dataWindow from header, strides and base pointer from NumPy to get the correct setting. (This is my motivation of this PR)
if any stride is passed as 0, then densely-packed non-flipped stride is assumed, that is yStride = (w / xSampling) * abs(xStride);
w and h are always positive so that dataWindow.max - dataWindow.min can always be passed in.

If we decide to add filpX and flipY parameters:

When flipY = true is passed, the semantic is constructing a slice as usual then flipping it. That is:

if (flipY) {
    ptr += yStride * (h - 1);
    yStride = -yStride;
}

So we can just pass in the pointer to the beginning of the user array and get a flipped slice.
I think this is simple for most use cases and easy to understand.

Is it possible to implement Slice::flipY()? Slice doesn't know the size of the dataWindow, which is required to adjust the base pointer.
Usually Make is used something like frameBuffer.insert( "R" , Slice::Make(base,...)) so there's no elegant place to call flipY()

Yes, we may need Slice::flipY(int64_t h). This may not be a good design.


JWT Expired when using withAuthRequired

For some reasons using withAuthRequired causes the API to respond with "JWT Expired" even though the session is refreshed.  Removing withAuthRequired solves the issue ( I checked that the user was loaded correct)

I am seeing this as well.

Can you share more context on your setup? Are you using it in API routes? Anywhere where I can see your code? Thanks.

It seems that there was a breaking change in 1.3.0 as I don't get this error in the previous version.

@thorwebdev Yes ofc :). It happens for me when I use it with the API endpoint. For example:
import {NextApiRequest, NextApiResponse} from "next";
import {getUser, supabaseServerClient, withAuthRequired} from "@supabase/supabase-auth-helpers/nextjs";
import {UserProfile} from "../../../models/user/user";

export default withAuthRequired(async function handleProfile(req: NextApiRequest, res: NextApiResponse) {
    const method = req.method
    const {user} = await getUser({req, res})
    const body = req.body as UserProfile

    if (method === "PUT") {
        const result = await supabaseServerClient({req, res})
            .from("profiles")
            .update(body).eq("user_id", user?.id)
            .single()
        res.json(result)
    }

    if (method === "GET") {
        const result = await supabaseServerClient({req, res})
            .from("profiles").select("*")
            .eq("user_id", user?.id)
            .single()

        res.json(result)
    }
})

If I remove the withAuthRequired  wrapper, then it works (by works I mean that the user from getuser is correctly read with the cookies)

Just to clarify: This issue happened after I updated the package to 1.3.0

I am seeing this issue as well and opened up chat on Discord about it in #help.

This should be fixed in https://github.com/supabase-community/supabase-auth-helpers/pull/92 can you upgrade and retry?


feat!: 237 revive cnvkit

Extends the panel_of_normals step to create a cnvkit reference based on exome of wgs normal samples
Updates & extends the cnvkit tool for the somatic_targeted_seq_cnv_calling.
Allows cnvkit as tool for the somatic_wgs_cnv_calling step

Note that the changes break the plots creation for the control_freec tool in the somatic_wgs_cnv_calling step. Following a discussion with Manuel, this step will need to be refurbished anyway, and possibly merged with the somatic_targeted_seq_cnv_calling step, which performs the same function for exome data.

Coverage: 85.037% (+0.4%) from 84.613% when pulling cae427d2035d8a301bdbba7609fb0ef9b6ece885 on 237-revive-cnvkit into 5ecad1a230a386b818cefb6484930b122496ce0c on main.


Donut mask

Thank you for your contribution to the Tomni package.
Before submitting/accepting this Pull Request, please make sure:
Contributor of code

[x] Functions are named based on Python naming conventions
[x] Explain how to run the code (docstring)
[x] Function is tested
[x] All needed package are in requirements.txt
[x] Requirements in setup.py are updated
[x] Version number is updated
[x] HISTORY.rst is updated
[x] New feature is added to README.md subsection Features

Reviewer

[ ] Functions are named based on Python naming conventions
[ ] The code is executed on another machine
[ ] Function is tested
[ ] Installing just the requirements.txt is enough to run the code
[ ] Requirements in setup.py are updated
[ ] Version number is updated
[ ] HISTORY.rst is updated
[ ] New feature is added to README.md subsection Features

maybe a bit late  but we should add the scf documentation in the readme.md


Js Callback

Is there a function where you can get a callback when a certain command is executed?
EDIT: Add a function to use the console as a normal console

No, there is no callback function after a command was executed, substantially because commands are sequential outputted strings, so please describe a use-case where a callback function could be useful.
And, what do you mean with Add a function to use the console as a normal console?

I mean if you can implement the function that you can type commands and get a callback.

Sorry but it is not much clear. If you mean making shell interactive – just like a text input – it is not what this library actually do, but I am open to accept pull request, indeed I invite you to contribute introducing new features like this.

Yeah, I might do it later but at the time I have no time for it😉


Taggle: Remove labels of categorical column histogram if there are too many groups

@zichner commented on Tue Nov 28 2017
If there are many categories in a categorical column, the histogram labels cannot be read (not even the first few characters):

In such a case, it would be better to hide the labels completely.

if there are too many categories, histograms doesn't make sense anymore. see also #341

an option for the side panel would be to add horizontal scroll bars and assign a minimum width for bins.

but isn't the main goal of a histogram to see all items? + it doesn't scale very well either. e.g in the KUK case we have a hierarchy with 15k categories by default + it doesn't work in the inline header histogram

the histogram in the side panel is also about filtering. and the hierarchical categorical is different.
if the histogram is scrollable you can still see everything - but just not at the same time (temporal partitioning) ;)


Fe: Login doesn't work

I'm unable to login to the frontend website using "Connect wallet"
I think Login might be a better word instead of "Connect wallet" because one of the sign in options before was Login with discord

Yeah the feature isn't actually setup, that button currently a placeholder. I'll hide it for now until that is added by #1417

https://github.com/webaverse/webaverse.com/commit/97fe8540494181369e3b61acc83610c687a76b32


Shit Bug on autoformatting for python when save !!!

The bug is annoying ,  and not fixed since last version .
The autoformat with black sometime not working
Shit ！

Environment data

VS Code version: XXX
Extension version (available under the Extensions sidebar): XXX
OS and version: XXX
Python version (& distribution if applicable, e.g. Anaconda): XXX
Type of virtual environment used (N/A | venv | virtualenv | conda | ...): XXX
Relevant/affected Python packages and their versions: XXX

Expected behaviour
XXX
Actual behaviour
XXX
Steps to reproduce:

XXX

Logs
Output for Python in the Output panel (View→Output, change the drop-down the upper-right of the Output panel to Python)
XXX

Output from Console under the Developer Tools panel (toggle Developer Tools on under Help; turn on source maps to make any tracebacks be useful by running Enable source map support for extension debugging)
XXX

I'm sorry you're experiencing some issues with the extension. Also do apologize for the fact that this wasn't resolved since the last release.
Please could you point me to the issue in the previous release, if it wasn't reported, then please do try to understand, we cannot fix anything if we're not aware of it.

Shit ！

Also, please do try to understand that we're trying to address a number of issues related to the extension and balance a number of feature requests as well for a very large number of users.
I'm closing this issue as you haven't provided any information about the issue, logs, environment information, etc.
Please do fill in the requested information and we'll be happy to reopen the issue and look into this.