RuntimeError: : Optimizer lost track of step count!

When I tried to continue training from a model with 100 step checkpoints, I modify the scrpits --train-iters  from 100 to 1500 and
add --load checkpoints/gpt2_0.8B  parameter which is consistent in the training process.  The checkpoint are loading success, but I got an error:
[2020-11-26 14:12:39,268] [INFO] [engine.py:1285:_load_checkpoint] rank: 1 loading checkpoint: checkpoints/gpt2_0.8B/100/mp_rank_01_model_states.pt
successfully loaded 2 ZeRO state_dicts for rank 0
successfully loaded 2 ZeRO state_dicts for rank 7
loading 2 zero partition checkpoints for rank 0
loading 2 zero partition checkpoints for rank 7
successfully loaded 2 ZeRO state_dicts for rank 4
successfully loaded 2 ZeRO state_dicts for rank 3
loading 2 zero partition checkpoints for rank 4
successfully loaded 2 ZeRO state_dicts for rank 5
successfully loaded 2 ZeRO state_dicts for rank 1
loading 2 zero partition checkpoints for rank 3
loading 2 zero partition checkpoints for rank 1
loading 2 zero partition checkpoints for rank 5
  successfully loaded checkpoints/gpt2_0.8B/100/mp_rank_01_model_states.pt
  successfully loaded checkpoints/gpt2_0.8B/100/mp_rank_00_model_states.pt
  successfully loaded checkpoints/gpt2_0.8B/100/mp_rank_03_model_states.pt
  successfully loaded checkpoints/gpt2_0.8B/100/mp_rank_02_model_states.pt
[2020-11-26 14:12:48,690] [INFO] [checkpointing.py:63:see_memory_usage] First Forward Begining
[2020-11-26 14:12:48,692] [INFO] [checkpointing.py:64:see_memory_usage] Memory Allocated 1.2926912307739258 GigaBytes
[2020-11-26 14:12:48,694] [INFO] [checkpointing.py:68:see_memory_usage] Max Memory Allocated 1.5387849807739258 GigaBytes
/opt/conda/lib/python3.8/site-packages/torch/cuda/memory.py:344: FutureWarning: torch.cuda.memory_cached has been renamed to torch.cuda.memory_reserved
  warnings.warn(
[2020-11-26 14:12:48,697] [INFO] [checkpointing.py:72:see_memory_usage] Cache Allocated 1.98828125 GigaBytes
/opt/conda/lib/python3.8/site-packages/torch/cuda/memory.py:352: FutureWarning: torch.cuda.max_memory_cached has been renamed to torch.cuda.max_memory_reserved
  warnings.warn(
[2020-11-26 14:12:48,698] [INFO] [checkpointing.py:76:see_memory_usage] Max cache Allocated 1.98828125 GigaBytes
[2020-11-26 14:12:48,698] [INFO] [checkpointing.py:357:forward] Activation Checkpointing Information
[2020-11-26 14:12:48,698] [INFO] [checkpointing.py:358:forward] ----Partition Activations True, CPU CHECKPOINTING True
[2020-11-26 14:12:48,698] [INFO] [checkpointing.py:361:forward] ----contiguous Memory Checkpointing True with 24 total layers
[2020-11-26 14:12:48,698] [INFO] [checkpointing.py:364:forward] ----Synchronization False
[2020-11-26 14:12:48,698] [INFO] [checkpointing.py:365:forward] ----Profiling False
Traceback (most recent call last):
  File "pretrain_gpt2.py", line 717, in <module>
Traceback (most recent call last):
  File "pretrain_gpt2.py", line 717, in <module>
Traceback (most recent call last):
Traceback (most recent call last):
  File "pretrain_gpt2.py", line 717, in <module>
  File "pretrain_gpt2.py", line 717, in <module>
Traceback (most recent call last):
  File "pretrain_gpt2.py", line 717, in <module>
Traceback (most recent call last):
  File "pretrain_gpt2.py", line 717, in <module>
Traceback (most recent call last):
  File "pretrain_gpt2.py", line 717, in <module>
Traceback (most recent call last):
  File "pretrain_gpt2.py", line 717, in <module>
    main()
  File "pretrain_gpt2.py", line 689, in main
            main()main()

main()main()  File "pretrain_gpt2.py", line 689, in main
  File "pretrain_gpt2.py", line 689, in main

  File "pretrain_gpt2.py", line 689, in main

          File "pretrain_gpt2.py", line 689, in main
main()    main()main()

  File "pretrain_gpt2.py", line 689, in main
  File "pretrain_gpt2.py", line 689, in main
  File "pretrain_gpt2.py", line 689, in main
    iteration, skipped = train(model, optimizer,
  File "pretrain_gpt2.py", line 413, in train
            iteration, skipped = train(model, optimizer,iteration, skipped = train(model, optimizer,iteration, skipped = train(model, optimizer,

  File "pretrain_gpt2.py", line 413, in train
  File "pretrain_gpt2.py", line 413, in train
  File "pretrain_gpt2.py", line 413, in train
        lm_loss, skipped_iter = train_step(train_data_iterator, model, optimizer, lr_scheduler, args, timers)iteration, skipped = train(model, optimizer,

  File "pretrain_gpt2.py", line 383, in train_step
  File "pretrain_gpt2.py", line 413, in train
    iteration, skipped = train(model, optimizer,
  File "pretrain_gpt2.py", line 413, in train
        iteration, skipped = train(model, optimizer,iteration, skipped = train(model, optimizer,

  File "pretrain_gpt2.py", line 413, in train
  File "pretrain_gpt2.py", line 413, in train
    lm_loss, skipped_iter = train_step(train_data_iterator, model, optimizer, lr_scheduler, args, timers)
lm_loss, skipped_iter = train_step(train_data_iterator, model, optimizer, lr_scheduler, args, timers)      File "pretrain_gpt2.py", line 383, in train_step

lm_loss, skipped_iter = train_step(train_data_iterator, model, optimizer, lr_scheduler, args, timers)  File "pretrain_gpt2.py", line 383, in train_step

  File "pretrain_gpt2.py", line 383, in train_step
    lm_loss, skipped_iter = train_step(train_data_iterator, model, optimizer, lr_scheduler, args, timers)
  File "pretrain_gpt2.py", line 383, in train_step
    model.step()
  File "/opt/conda/lib/python3.8/site-packages/deepspeed/runtime/engine.py", line 973, in step
    lm_loss, skipped_iter = train_step(train_data_iterator, model, optimizer, lr_scheduler, args, timers)
  File "pretrain_gpt2.py", line 383, in train_step
    model.step()
  File "/opt/conda/lib/python3.8/site-packages/deepspeed/runtime/engine.py", line 973, in step
        model.step()model.step()

  File "/opt/conda/lib/python3.8/site-packages/deepspeed/runtime/engine.py", line 973, in step
  File "/opt/conda/lib/python3.8/site-packages/deepspeed/runtime/engine.py", line 973, in step
        lm_loss, skipped_iter = train_step(train_data_iterator, model, optimizer, lr_scheduler, args, timers)lm_loss, skipped_iter = train_step(train_data_iterator, model, optimizer, lr_scheduler, args, timers)

      File "pretrain_gpt2.py", line 383, in train_step
  File "pretrain_gpt2.py", line 383, in train_step
model.step()
  File "/opt/conda/lib/python3.8/site-packages/deepspeed/runtime/engine.py", line 973, in step
    model.step()
  File "/opt/conda/lib/python3.8/site-packages/deepspeed/runtime/engine.py", line 973, in step
        model.step()model.step()

  File "/opt/conda/lib/python3.8/site-packages/deepspeed/runtime/engine.py", line 973, in step
  File "/opt/conda/lib/python3.8/site-packages/deepspeed/runtime/engine.py", line 973, in step
        self._take_model_step()self._take_model_step()

  File "/opt/conda/lib/python3.8/site-packages/deepspeed/runtime/engine.py", line 928, in _take_model_step
  File "/opt/conda/lib/python3.8/site-packages/deepspeed/runtime/engine.py", line 928, in _take_model_step
                self._take_model_step()self._take_model_step()self._take_model_step()self._take_model_step()

  File "/opt/conda/lib/python3.8/site-packages/deepspeed/runtime/engine.py", line 928, in _take_model_step
  File "/opt/conda/lib/python3.8/site-packages/deepspeed/runtime/engine.py", line 928, in _take_model_step
        self._take_model_step()  File "/opt/conda/lib/python3.8/site-packages/deepspeed/runtime/engine.py", line 928, in _take_model_step
  File "/opt/conda/lib/python3.8/site-packages/deepspeed/runtime/engine.py", line 928, in _take_model_step

self._take_model_step()
  File "/opt/conda/lib/python3.8/site-packages/deepspeed/runtime/engine.py", line 928, in _take_model_step
  File "/opt/conda/lib/python3.8/site-packages/deepspeed/runtime/engine.py", line 928, in _take_model_step
    self.optimizer.step()
      File "/opt/conda/lib/python3.8/site-packages/deepspeed/runtime/zero/stage2.py", line 1417, in step
self.optimizer.step()
  File "/opt/conda/lib/python3.8/site-packages/deepspeed/runtime/zero/stage2.py", line 1417, in step
    self.optimizer.step()
  File "/opt/conda/lib/python3.8/site-packages/deepspeed/runtime/zero/stage2.py", line 1417, in step
    self.optimizer.step()
  File "/opt/conda/lib/python3.8/site-packages/deepspeed/runtime/zero/stage2.py", line 1417, in step
        self.optimizer.step()self.optimizer.step()

  File "/opt/conda/lib/python3.8/site-packages/deepspeed/runtime/zero/stage2.py", line 1417, in step
  File "/opt/conda/lib/python3.8/site-packages/deepspeed/runtime/zero/stage2.py", line 1417, in step
        self.optimizer.step()self.optimizer.step()

  File "/opt/conda/lib/python3.8/site-packages/deepspeed/runtime/zero/stage2.py", line 1417, in step
  File "/opt/conda/lib/python3.8/site-packages/deepspeed/runtime/zero/stage2.py", line 1417, in step
    self.optimizer.step(fp16_param_groups=fp16_param_groups)
self.optimizer.step(fp16_param_groups=fp16_param_groups)
self.optimizer.step(fp16_param_groups=fp16_param_groups)
  File "/opt/conda/lib/python3.8/site-packages/torch/autograd/grad_mode.py", line 26, in decorate_context
  File "/opt/conda/lib/python3.8/site-packages/torch/autograd/grad_mode.py", line 26, in decorate_context
  File "/opt/conda/lib/python3.8/site-packages/torch/autograd/grad_mode.py", line 26, in decorate_context
            self.optimizer.step(fp16_param_groups=fp16_param_groups)self.optimizer.step(fp16_param_groups=fp16_param_groups)self.optimizer.step(fp16_param_groups=fp16_param_groups)

  File "/opt/conda/lib/python3.8/site-packages/torch/autograd/grad_mode.py", line 26, in decorate_context
  File "/opt/conda/lib/python3.8/site-packages/torch/autograd/grad_mode.py", line 26, in decorate_context
  File "/opt/conda/lib/python3.8/site-packages/torch/autograd/grad_mode.py", line 26, in decorate_context
        self.optimizer.step(fp16_param_groups=fp16_param_groups)self.optimizer.step(fp16_param_groups=fp16_param_groups)

  File "/opt/conda/lib/python3.8/site-packages/torch/autograd/grad_mode.py", line 26, in decorate_context
  File "/opt/conda/lib/python3.8/site-packages/torch/autograd/grad_mode.py", line 26, in decorate_context
    return func(*args, **kwargs)
        return func(*args, **kwargs)        return func(*args, **kwargs)return func(*args, **kwargs)  File "/opt/conda/lib/python3.8/site-packages/deepspeed/ops/adam/cpu_adam.py", line 117, in step
    return func(*args, **kwargs)
return func(*args, **kwargs)  File "/opt/conda/lib/python3.8/site-packages/deepspeed/ops/adam/cpu_adam.py", line 117, in step
return func(*args, **kwargs)

return func(*args, **kwargs)
  File "/opt/conda/lib/python3.8/site-packages/deepspeed/ops/adam/cpu_adam.py", line 117, in step

  File "/opt/conda/lib/python3.8/site-packages/deepspeed/ops/adam/cpu_adam.py", line 117, in step

  File "/opt/conda/lib/python3.8/site-packages/deepspeed/ops/adam/cpu_adam.py", line 117, in step
  File "/opt/conda/lib/python3.8/site-packages/deepspeed/ops/adam/cpu_adam.py", line 117, in step
  File "/opt/conda/lib/python3.8/site-packages/deepspeed/ops/adam/cpu_adam.py", line 117, in step
  File "/opt/conda/lib/python3.8/site-packages/deepspeed/ops/adam/cpu_adam.py", line 117, in step
        self.ds_opt_adam.adam_update_copy(self.ds_opt_adam.adam_update_copy(

            self.ds_opt_adam.adam_update_copy(self.ds_opt_adam.adam_update_copy(RuntimeErrorself.ds_opt_adam.adam_update_copy(        self.ds_opt_adam.adam_update_copy(

:
RuntimeErrorself.ds_opt_adam.adam_update_copy(self.ds_opt_adam.adam_update_copy(
Optimizer lost track of step count!
:

RuntimeErrorRuntimeErrorRuntimeErrorOptimizer lost track of step count!
:
RuntimeError: : Optimizer lost track of step count!
RuntimeErrorRuntimeError: : Optimizer lost track of step count!
Optimizer lost track of step count!

: Optimizer lost track of step count!
Optimizer lost track of step count!

Optimizer lost track of step count!

Does anybody know why that is?

Hi @hujian233
Thanks for reporting this issue. This is coming from the tracking issue of the cpu-adam optimizer step when you loaded the checkpoint from step 100. I pushed a fix in this PR: https://github.com/microsoft/DeepSpeed/pull/564
Please give it a try and let me know if the problem is solved.
Thanks.
Reza

Hello ！@RezaYazdaniAminabadi  @jeffra ，my docker enviroment is cuda11 and pytorch1.7，I used deepspeed/deepspeed:v034-jitops-torch170-cuda11 this image which is mention in [microsoft/DeepSpeed/issues/536]
I can modify the cpu_adam.h file, but I don't how to compile it. So it doesn't worked!
When I use the  just-in-time (JIT) ，it will report the following error:
Using /root/.cache/torch_extensions as PyTorch extensions root...
Creating extension directory /root/.cache/torch_extensions/cpu_adam...
Using /root/.cache/torch_extensions as PyTorch extensions root...
Detected CUDA files, patching ldflags
Emitting ninja build file /root/.cache/torch_extensions/cpu_adam/build.ninja...
Building extension module cpu_adam...
Allowing ninja to set a default number of workers... (overridable by setting the environment variable MAX_JOBS=N)
[1/3] /usr/local/cuda/bin/nvcc -DTORCH_EXTENSION_NAME=cpu_adam -DTORCH_API_INCLUDE_EXTENSION_H -I/opt/conda/lib/python3.8/site-packages/deepspeed/ops/csrc/includes -I/usr/local/cuda/include -isystem /opt/conda/lib/python3.8/site-packages/torch/include -isystem /opt/conda/lib/python3.8/site-packages/torch/include/torch/csrc/api/include -isystem /opt/conda/lib/python3.8/site-packages/torch/include/TH -isystem /opt/conda/lib/python3.8/site-packages/torch/include/THC -isystem /usr/local/cuda/include -isystem /opt/conda/include/python3.8 -D_GLIBCXX_USE_CXX11_ABI=0 -D__CUDA_NO_HALF_OPERATORS__ -D__CUDA_NO_HALF_CONVERSIONS__ -D__CUDA_NO_HALF2_OPERATORS__ --expt-relaxed-constexpr -gencode=arch=compute_86,code=sm_86 --compiler-options '-fPIC' -O3 --use_fast_math -std=c++14 -U__CUDA_NO_HALF_OPERATORS__ -U__CUDA_NO_HALF_CONVERSIONS__ -U__CUDA_NO_HALF2_OPERATORS__ -gencode arch=compute_86,code=compute_86 -c /opt/conda/lib/python3.8/site-packages/deepspeed/ops/csrc/adam/custom_cuda_kernel.cu -o custom_cuda_kernel.cuda.o
FAILED: custom_cuda_kernel.cuda.o
/usr/local/cuda/bin/nvcc -DTORCH_EXTENSION_NAME=cpu_adam -DTORCH_API_INCLUDE_EXTENSION_H -I/opt/conda/lib/python3.8/site-packages/deepspeed/ops/csrc/includes -I/usr/local/cuda/include -isystem /opt/conda/lib/python3.8/site-packages/torch/include -isystem /opt/conda/lib/python3.8/site-packages/torch/include/torch/csrc/api/include -isystem /opt/conda/lib/python3.8/site-packages/torch/include/TH -isystem /opt/conda/lib/python3.8/site-packages/torch/include/THC -isystem /usr/local/cuda/include -isystem /opt/conda/include/python3.8 -D_GLIBCXX_USE_CXX11_ABI=0 -D__CUDA_NO_HALF_OPERATORS__ -D__CUDA_NO_HALF_CONVERSIONS__ -D__CUDA_NO_HALF2_OPERATORS__ --expt-relaxed-constexpr -gencode=arch=compute_86,code=sm_86 --compiler-options '-fPIC' -O3 --use_fast_math -std=c++14 -U__CUDA_NO_HALF_OPERATORS__ -U__CUDA_NO_HALF_CONVERSIONS__ -U__CUDA_NO_HALF2_OPERATORS__ -gencode arch=compute_86,code=compute_86 -c /opt/conda/lib/python3.8/site-packages/deepspeed/ops/csrc/adam/custom_cuda_kernel.cu -o custom_cuda_kernel.cuda.o
nvcc fatal   : Unsupported gpu architecture 'compute_86'

...
Traceback (most recent call last):
  File "pretrain_gpt2.py", line 728, in <module>
    main()
  File "pretrain_gpt2.py", line 676, in main
    model, optimizer, lr_scheduler = setup_model_and_optimizer(args)
  File "pretrain_gpt2.py", line 170, in setup_model_and_optimizer
    model, optimizer, _, lr_scheduler = deepspeed.initialize(
  File "/opt/conda/lib/python3.8/site-packages/deepspeed/__init__.py", line 109, in initialize
    engine = DeepSpeedEngine(args=args,
  File "/opt/conda/lib/python3.8/site-packages/deepspeed/runtime/engine.py", line 181, in __init__
    self._configure_optimizer(optimizer, model_parameters)
  File "/opt/conda/lib/python3.8/site-packages/deepspeed/runtime/engine.py", line 590, in _configure_optimizer
    basic_optimizer = self._configure_basic_optimizer(model_parameters)
  File "/opt/conda/lib/python3.8/site-packages/deepspeed/runtime/engine.py", line 655, in _configure_basic_optimizer
    optimizer = DeepSpeedCPUAdam(model_parameters,
  File "/opt/conda/lib/python3.8/site-packages/deepspeed/ops/adam/cpu_adam.py", line 70, in __init__
    self.ds_opt_adam = CPUAdamBuilder().load()
  File "/opt/conda/lib/python3.8/site-packages/deepspeed/ops/op_builder/builder.py", line 156, in load
    return self.jit_load(verbose)
  File "/opt/conda/lib/python3.8/site-packages/deepspeed/ops/op_builder/builder.py", line 184, in jit_load
    op_module = load(
  File "/opt/conda/lib/python3.8/site-packages/torch/utils/cpp_extension.py", line 969, in load
    return _jit_compile(
  File "/opt/conda/lib/python3.8/site-packages/torch/utils/cpp_extension.py", line 1196, in _jit_compile
    return _import_module_from_library(name, build_directory, is_python_module)
  File "/opt/conda/lib/python3.8/site-packages/torch/utils/cpp_extension.py", line 1543, in _import_module_from_library
    file, path, description = imp.find_module(module_name, [path])
  File "/opt/conda/lib/python3.8/imp.py", line 296, in find_module
    raise ImportError(_ERR_MSG.format(name), name=name)
ImportError: No module named 'cpu_adam'

Hi @hujian233
We have already solved the issue for the CPU-Adam with loading the checkpointing in the github branch. For the compilation issue, @jeffra just pushed this PR (https://github.com/microsoft/DeepSpeed/pull/572) that will solve it too. Could you please check in the updated code when it's merged and try this again?
Thanks,
Reza

#572 is merged now. Please give it a try when you can @hujian233


[Bug]: Going back to a page caches results from previous run

Is there an existing issue for this?

[X] I have searched the existing issues

Current Behavior
Case 1: Query which does not run on page load on Page1.

I goto page1, trigger the query.  Data is loaded
Now I goto page 2
Come back to Page1, I have the data without triggering the query.

This is not expected behaviour.
Case 2: Query which runs on page load

You have to click a button to go to page 2,  the button uses navigate to with params
First load is fine
When you come back to page 1 and goto page 2 with different params, data matching the first request is shown momentarily

Steps To Reproduce

Create a page to show data from an API on button click.
Mark the api to not run on page load
Create another page
Goto page1->click the button->goto page 2->goto page 1

You will see data from previous API run though the api is not set to run on page load.
Environment
Production
Version
Cloud

@SatishGandham I suggest we not solve this now since it was done on user request as a perceived performance improvement. Maybe this can be a setting in the future or we can tackle this if a user complains?

@Nikhil-Nandagopal @SatishGandham .
I understand the priority. I am just a bit confused as in why other users have not complained. May be the approach I am following is different. If this is going to take time. Can I get to know a workaround wherein I can handle this ? Because I have 14 to 15 pages on my app and navigating between pages is going to be more than often. So if temporarily there is a workaround then please let me know. Thanks

@dsakaria16 thanks for reaching out here. I now understand that with navigation params this becomes a big issue because the page is showing the older data for the wrong navigation param. Re-opening this

@Nikhil-Nandagopal Thank you .

@ajinkyakulkarni @rohan-arthur when do we expect this to get resolved?

Solution: Clear all action data when switching a page.

@dsakaria16 we will take this up in the next week, will update ETA here when we have more details.


Use self hosted ip check URL

:tada: This PR is included in version 1.24.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Document NU1004 NuGet error code

There's no doc page for NU1004 NuGet log code.
The log code is related to locked file features.
https://github.com/NuGet/NuGet.Client/blob/af1a9a055f56131d753573bade4a2c2654440faa/src/NuGet.Core/NuGet.Common/Errors/NuGetLogCode.cs#L77

Dups in https://github.com/NuGet/docs.microsoft.com-nuget/issues/1257 and https://github.com/NuGet/docs.microsoft.com-nuget/issues/1441

Dups in https://github.com/NuGet/docs.microsoft.com-nuget/issues/1257 and https://github.com/NuGet/docs.microsoft.com-nuget/issues/1441


Support unicode ids in toc

I'd like to propose a change to the way slugify works in toc.py.
Currently, slugify uses ascii to encode/decode strings and as a result if a header only contains unicode characters the resulting id and href becomes the default #_1, #_2, etc.
Instead, as the HTML standard does not impose any particular restriction on the character set used for the id attribute (https://html.spec.whatwg.org/multipage/dom.html#the-id-attribute), I think it would be sensible to instead use utf-8 for encoding/decoding strings in slugify in order to better support international input.

To make this change would mean that many users existing links would break the next time they update to the latest version of Markdown. I'm not comfortable with that.
However, the added functionality has value. I see a few ways forward:

The existing option available to everyone is to provide the extension with your own slugify function. We don't need to change anything.
Provide this new functionality as an option which users can enable through the extensions configuration.

Providing a Unicode slugify wouldn't be a bad idea (we live in a Unicode world). I know pymdown-extensions provides a number of variants so users can just pick the one they like: https://facelessuser.github.io/pymdown-extensions/extras/slugs/#alternate-slugify. It probably wouldn't be a bad idea for Python Markdown to have an optional Unicode variant, and if people want something above and beyond that, they need to provide their own function or use a publicly available one.

@waylan @facelessuser Thank you for the quick feedback.
Indeed this change would introduce a noticeable breaking change. If possible, I'd like to implement option 2 since option 1 may not always be approachable for end users.
For instance, this functionality could be provided through a encoding: utf-8 configuration flag and having slugify accept it as an optional argument:
def slugify(value, separator, encoding='ascii')

If that sounds acceptable, I'll go ahead and implement the changes.

For instance, this functionality could be provided through a encoding: utf-8 configuration flag and having slugify accept it as an optional argument:

That is certainly one possible solution. Another might be to provide a separate slugify function which the user could pass into the slugify config option. Note that we document that any third party functions must accept two arguments value and separator. If we start passing a third option, that would break any existing third party functions. In other words, by simply providing a separate function, we don't change/break the existing API. Also, that keeps the number of ways to alter slugify at one.
In practice, defining two functions may not seem very DRY. Perhaps we could create a single function which accepts the third argument encoding and then have two wrappers which only accept  value and separator. On would call the base function with ascii and the other with utf-8.

@waylan
Got it. I went ahead and implemented the suggested changes. Please take a look.

Looks good. Now we need documentation.
Sent with GitHawk

@waylan Sorry for the delay. I've updated the documentation.

I would like to ask to add the slugify_encoding configuration parameter as the slugify parameter of function type cannot be loaded properly from the text configuration.
For backwards compatibility, when the configured encoding matches the default encoding, the extra argument may not be passed to the slugify() method.
Example:
DEFAULT_ENCODING = 'ascii'

def _slugify(value, separator, encoding=DEFAULT_ENCODING):
    value = unicodedata.normalize('NFKD', value).encode(encoding, 'ignore')
    value = re.sub(r'[^\w\s-]', '', value.decode(encoding)).strip().lower()
    return re.sub(r'[%s\s]+' % separator, separator, value)

def slugify(value, separator):
    """ Slugify a string, to make it URL friendly. """
    return _slugify(value, separator)

def slugify_unicode(value, separator):
    """ Slugify a string, to make it URL friendly. """
    return _slugify(value, separator, 'utf-8')

<...>
class TocTreeprocessor(Treeprocessor):
    def __init__(self, md, config):
        super().__init__(md)
<...>
        self.slugify = config["slugify"]
        self.slugify_encoding = config["slugify_encoding"]
        self.sep = config["separator"]
<...>

    def run(self, doc):
<...>
                # Do not override pre-existing ids
                if "id" not in el.attrib:
                    innertext = unescape(stashedHTML2text(text, self.md))
                    slugify_kwargs = {}
                    if self.slugify_encoding != DEFAULT_ENCODING:
                        slugify_kwargs['encoding'] = self.slugify_encoding
                    el.attrib["id"] = unique(self.slugify(innertext, self.sep, **slugify_kwargs), used_ids)

<...>
class TocExtension(Extension):

    TreeProcessorClass = TocTreeprocessor

    def __init__(self, **kwargs):
        self.config = {
<...>
            "slugify": [_slugify,
                        "Function to generate anchors based on header text - "
                        "Defaults to the headerid ext's slugify function."],
            "slugify_encoding": [DEFAULT_ENCODING,
                                 "If set to non-default, will use the custom "
                                 "slugify encoding"],
            'separator': ['-', 'Word separator. Defaults to "-".'],
<...>

I would like to ask to add the slugify_encoding configuration parameter as the slugify parameter of function type cannot be loaded properly from the text configuration.

Then don't use text configuration. In fact, our documentation shows preference for creating an instance of an extension in Python code. The text-based methods are only provided for backward compatibility. Even the CLI includes support for a -c/--extension_configs option which accepts a YAML config file. In your YAML file you can point at a Python function (!!python/name:markdown.extensions.toc.slugify_unicode).
I realize that this is more complicated for the user than setting a slugify_encoding setting. But I'm only interested in implementing one way to set the encoding. If you can provide an alternate solution that does that, I'll consider it. However, as we already support the option for the user to provide their own slugify function, I expect that any such solution would always be a second way to address the issue.
Finally, your suggested solution requires that a third parameter be passed to the slugify function. However, that would break any existing third party functions which only accept two parameters. To maintain backward compatibility, we can only pass two parameters to slugify, Therefore, there is no way to pass a slugify_encoding configuration option to the function without breaking existing users' custom functions.

@waylan did not know there is an option to point the function reference through YAML.
Thank you.

If an entry is added to the release notes, I'll merge this.


Document spmd_axis_name in jax.vmap

spmd_axis_name is missing from the jax.vmap docstring, but seems to be pretty valuable tool for explicitly controlling sharding.
Given that distributed arrays are built-in to jax.jit, it would be great to explain how to use this feature :)
cc @yashk2810

@mattjj Is this still experimental: https://github.com/google/jax/pull/11807#discussion_r941721276 ?

Still worth documenting (as experimental) since it is very helpful.


Internal server error in HASS configuration

The problem
Since this morning I get the following error message:
Retrying setup: 500, message='Internal Server Error', url=URL('https://account-link.nabucasa.com/refresh_token/senz')

Version of SENZ WiFi integration having the issue?
0.0.6
Version of Home Assistant Core having the issue?
2022.4.5
Anything in the logs that might be useful for us?
No response
Additional information
No response

Try to restart Homeassistant. You should then be asked to reauthenticate with the Senz server. If you still get this error it is likely a problem with the authentication server at Raychem/Senz.

Restarted Home Assistant a couple of time with no luck.

And no Reauthentication card on Configuration->Integrations??
As a final try, you could try to remove the integration and add it back.
FYI: There is an official integration for Senz in the pipeline for HA 2022.5. When it is released I will most likely stop maintaining this variant.

Removing it and adding it back worked. Thanks


Fix checkbox missing name prop when is not inside a form

Description
This primitive uses a button and when inside a form adds a input. The name was destructured from the component and passed only to the input.
Fix:

It was added the name prop to the button if the checkbox is not inside a form.

I think this is probably OK but I'm reconsidering how we handle our bubble fields which would negate the need here. Need to think through this a bit before I merge.


Nested jit annotations

I have code with a structure like the example below:
@numba.jit()
def test():
  state = 0

  @numba.jit(nopython=True)
  def sub(param):
    nonlocal state
    state += param

  for i in range(100):
    param = i # Assume this line is nopython incompatible code
    sub(param)

  print(state)

Because of the nonlocal state variable, the test function has to be jitted. Otherwise, I would just remove the first annotation because what really matters is the sub function. Therefore, I wanted to to enable the nopython mode for it, which unfortunately fails with an error:
  @numba.jit(nopython=True)
  ^
[1] During: lowering "$0.11 = make_function(name=$const0.10, code=<code object fast_sub at 0x0000028ABF11E6F0, file ".../scratches/scratch.py", line 89>, closure=$0.8, defaults=None)" at .../scratches/scratch.py (89)
-------------------------------------------------------------------------------

In the real code, there are lots of state variables. If there is no better solution, I will probably just use a list which I can pass around to share the state. Nested numba.jit annotations would be much more convenient though. What do you think?

Thanks for the report. On Numba 0.40.0, this seems to just work under nopython mode as closures are simply inlined:
from numba import njit

def test():
  state = 0

  def sub(param):
    nonlocal state
    state += param

  for i in range(100):
    param = i
    sub(param)

  print(state)

print(test())
print(njit()(test)())

output:
$python issue3332.py
4950
None
4950
None

If objectmode is forced it does fail with:
Numba encountered the use of a language feature it does not support in this context: <creating a function from a closure> (op code: make_function not supported). If the feature is explicitly supported it is likely that the result of the expression is being used in an unsupported manner.

File "issue3332.py", line 6:

  def sub(param):
  ^

I think this is a result of the looplifting pass running before the closure inlining pass, which means that if there's a closure present (make_function opcode) at looplift time the IR legalization will fail following the looplift transform reentering the pipeline with mutated IR from looplifting but with the illegal make_function present. Switching these passes around in the pipeline seems to fix it.

As to your actual query about state etc, Numba 0.40.0 has a new feature, objectmode contexts (run bits of nopython mode functions in objectmode), does this help your situation? http://numba.pydata.org/numba-doc/latest/user/withobjmode.html

@stuartarchibald I have just upgraded to 0.40.0, but still have the same problem. Have you seen that there is a second annotation on the sub function? Also, I cannot use nopython mode for the test function itself. I will have a look at objectmode later.

Yes, I saw that, it's currently illegal/unsupported behaviour, hence me removing it as it looked like it would inline fine under njit via the closure inlining pass, I guess your actual function won't do this hence the problem? It sounds like you want the opposite of what with objmode does in nopython mode, i.e. run the function in objectmode but use nopython mode a couple of places? If most of your function would compile under nopython mode then with objmode will probably help get the bits that won't work to run?

I was able to solve the problem with objmode. Just curious, why is it necessary to provide the return types when they can be figured out automatically for function arguments?
Also, I run into a limitation. I have a pandas data frame with different data types (floats and bools) for which I want to use the numpy array in the numba optimised code. numba.typeof isn't able to return a data type string for it. I guess mixed arrays are not supported yet, right?

One more idea. For my use case, the following pattern would be very useful:
def gen():
  while True:
    yield 1

@njit
def test():
  with objmode(g="object"):
    g = gen()

  while True:
    with objmode(val="int"):
      val = next(g)

    # Do something with val

The variable g could not be used inside the nopython code, but in other objmode sections.

One last question: Is it possible to return a list of arrays from objmode? I have tried List(array(float64, 1d, C)), list(array(float64, 1d, C)) and reflected list(array(float64, 1d, C)), but none worked.

Just curious, why is it necessary to provide the return types when they can be figured out automatically for function arguments?

Perhaps you may be running some function in object mode where type inference can't follow what would be returned? This is also an experimental feature, things may change :)

Also, I run into a limitation. I have a pandas data frame with different data types (floats and bools) for which I want to use the numpy array in the numba optimised code. numba.typeof isn't able to return a data type string for it. I guess mixed arrays are not supported yet, right?

Think this comes out as a NumPy array of dtype object, which is not supported. You could coerce the dataframe backing array into a dtype:
In [16]: d = pd.DataFrame(data = {'col1':[1., 2.], 'col2':[np.bool(1), np.bool(0)]})

In [17]: d.values.dtype
Out[17]: dtype('O')

In [18]: pd.DataFrame(d, dtype=np.float64).values.dtype
Out[18]: dtype('float64')

but this obviously incurs cost. Another option is to use the to_records() method on the DataFrame to get a NumPy recarray which may be recognised by Numba, again, cost incurred, not sure how efficient it'd be. It'd probably be most efficient to just partition your columns by type so that e.g. Numba would just see primitive types through the use of multiple args (one for each column/homogeneously typed data set).

One more idea. For my use case, the following pattern would be very useful:

Thanks, IIRC there are some plans on the horizon for thinking about pass through cases.

One last question: Is it possible to return a list or tuple of arrays from objmode? I have tried list(array(float64, 1d, C)), tuple(array(float64, 1d, C)), list(float64[:]), tuple(float64[:]) but none worked.

Is this the sort of thing you are after? :
from numba import njit, objmode
import numpy as np

@njit
def test():
    with objmode(val='List(float64[:])'):
        val = [np.arange(10.), np.ones(4)]
    return val

print(test())

or do you mean you want the return statement in the objmode block (not supported!)?

Makes all sense.

or do you mean you want the return statement in the objmode block (not supported!)?

No, this is exactly what I wanted. List(...) does not seem to be documented here. Therefore, I just tried to use whatever numba.typeof returned but this didn't work either. How can I figure out the type string which I have to use when it is missing in the documentation? Tuples, for example, would be interesting too.

hmmm, that should probably be documented, thanks for raising it, I've opened a ticket https://github.com/numba/numba/issues/3349. Basically, whatever string you write gets eval'd with numba.types as globals. So if you are looking for a type, that's the place to look. Here's a homogeneous 2-tuple of float64 1D arrays.
from numba import njit, objmode
import numpy as np

@njit
def test():
    with objmode(val='UniTuple(float64[:], 2)'):
        val = (np.arange(10.), np.ones(4))
    return val

print(test())

I see. Thank you very much for your excellent help!

No problem, thanks for using Numba :)

Sorry, I have one more question: It seems like to_records() is supported for my mixed array. At least I can pass such an array to a nopython function. The following should describe the array:
print(vals.shape)  # (10,)
print(vals.dtype)  # (numpy.record, [('index', '<i8'), ('a', '<f8'), ('b', '?')])
print(numba.typeof(vals))  # unaligned array(Record([('index', '<i8'), ('a', '<f8'), ('b', '|b1')]), 1d, C)
print(numba.from_dtype(vals.dtype))  # Record([('index', '<i8'), ('a', '<f8'), ('b', '|b1')])

I have tried again various type string combinations for objmode, but could not get it running. Would you mind explaining in more details, how I can determine the type string from the information above?

hmmm, this was hard. I'm not hugely familiar with the recarray impl in Numba so there may be a better way. Independent of this, the str const constraint makes it hard to deal with more advanced types, I'll raise this at the next core developer meeting (but also acknowledge that this is a new, under development and generally experimental feature).
from numba import njit, objmode, typeof, from_dtype, types, numpy_support
import numpy as np
from pandas import DataFrame

df = DataFrame(data = {'col1':[1., 2.], 'col2':[np.bool(1), np.bool(0)]})

pdrec = df.to_records()
dt = numpy_support.from_struct_dtype(pdrec.dtype)

def rec2str(rec):
    attrs = ['descr', 'fields', 'size', 'aligned']
    subsmap = {}
    for x in attrs:
        subsmap[x] = str(getattr(rec, x))
    subsmap['dtype'] = rec.dtype.descr
    template = "Record(\"{descr}\", {fields}, {size}, {aligned}, {dtype})"
    ret = template.format(**subsmap)
    # make sure it's valid
    eval(ret, {}, types.__dict__)
    return ret.replace('"','\\"')

# This gives the record type to paste in the `objmode` type annotation.
print("Formatted str const: %s" % rec2str(dt))

@njit
def test_record_get(recarr):
    with objmode(f="Record(\"[('index', '<i8'), ('col1', '<f8'), ('col2', '|b1')]\", {'index': (int64, 0), 'col1': (float64, 8), 'col2': (bool, 16)}, 17, False, [('index', '<i8'), ('col1', '<f8'), ('col2', '|b1')])"):
        f = recarr[1]
    return f

@njit
def test_record_slice(recarr):

    with objmode(g= "Array(Record(\"[('index', '<i8'), ('col1', '<f8'), ('col2', '|b1')]\", {'index': (int64, 0), 'col1': (float64, 8), 'col2': (bool, 16)}, 17, False, [('index', '<i8'), ('col1', '<f8'), ('col2', '|b1')]), 1, 'C')"):
        g = recarr[1:]
    return g

print(test_record_get(pdrec))
print(test_record_slice(pdrec))

ping @sklam any ideas for a better way?

(replying to https://github.com/numba/numba/issues/3332#issuecomment-425419877)
It's definitely too difficult to use.  This is where we need to do something like with objmode(g=typeof(recarra))

@sklam Yes, this would be useful (at first, I even thought that I could use the current numba.typeof for this). However, I still think, numba should just figure out the type by itself similar as for function arguments. Then users don't have to deal with it at all.


[Schemas]: Missing auto field for dashboard.VariableModel

version
11.3.x
Missing field.
Missing auto field for dashboard.VariableModel
Link to documentation.
https://grafana.com/docs/grafana/latest/dashboards/variables/add-template-variables/#add-an-interval-variable
Do you want to add any other information?
Hi!
Currently, it's not possible to set auto field for dashboard Interval variable. This is a handy default for a lot of our interval dashboard variable. Also, potentially unrelated, but the magic constant for the auto option is quite obscure and is $__auto_interval_min_interval, here is the part of the interval variable json
      {
        "allFormat": "glob",
        "auto": true,
        "auto_count": 40,
        "auto_min": "10s",
        "current": {
          "selected": false,
          "text": "auto",
          "value": "$__auto_interval_min_interval"
        }
}

Hey,
Thanks for reporting this! I started working on a fix in https://github.com/grafana/cog/pull/656 :)

A fix just landed in this repo :)

Thank you @K-Phoen !


Merge release-4.6.2-m6 back to 4.6.x

Purpose

Merge release-4.6.2-m6 back to 4.6.x

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.2 out of 3 committers have signed the CLA.:white_check_mark: ashensw:white_check_mark: AnuradhaSK:x: wso2-jenkins-botYou have signed the CLA already but the status is still pending? Let us recheck it.


How to use router when use https.createSever

this is my  code
const https = require('https')
const { run, send } = require('micro')

const cert = require('openssl-self-signed-certificate')

const PORT = process.env.PORT || 3443

const options = {
  key: cert.key,
  cert: cert.cert,
  passphrase: cert.passphrase
}

const microHttps = fn => https.createServer(options, (req, res) => run(req, res, fn))

const server = microHttps(async (req, res) => {
  send(res, 200, { encrypted: req.client.encrypted })
})

server.listen(PORT)
console.log(`Listening on https://localhost:${PORT}`)

from this example : https://github.com/zeit/micro/tree/master/examples/with-https
how to use router?

const http = require('http')
const { run, send } = require('micro')
const { router, get } = require('microrouter')

const PORT = process.env.PORT || 3000

const hello = async (req, res) =>
  send(res, 200, 'hello')

const hello2 = async (req, res) =>
  send(res, 200, 'hello2 !')

const microHttps = fn => http.createServer(router(
    get('/hello', hello),
    get('/hello2', hello2)
  ))

const server = microHttps(hello)

server.listen(PORT)
console.log(`Listening on https://localhost:${PORT}`)


Do not skip provider check for blast-sepolia-testnet

This chain is actively maintained. So it's better to not skip provider check for it.

Nice catch 👍🏻


Deprecate ChosenSelect

Codecov Report

Merging #886 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #886   +/-   ##
=======================================
  Coverage   99.76%   99.76%
=======================================
  Files         282      282
  Lines        7173     7173
  Branches     1757     1757
=======================================
  Hits         7156     7156
  Misses         17       17

Impacted Files
Coverage Δ

src/components/chosen/ChosenSelect.tsx
100% <ø> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b83a7af...1dfe45a. Read the comment docs.


change dots color?

Hi Ken,
Awesome plugin. Any chance for dots color setting?
Tried to change it in the slick-active class with no luck.

Hi,
I had the same issue and it didn't work just Setting the color css property like you would for text on the psuedo selector .
Instead I added this 2 rules on the li.slick-active:
background-color: transparent;
overflow: hidden;

This is what worked for me:
.slick-dots li button:before {
    color: orange;
  }

If you want a diifrent color for active dot
.slick-dots li.slick-active button:before {
    color:orange !important;
}

how to modify  dots in my project any way available?
pls sugges me...

The :before does not show up if the dots: true is set alone.  What other setting needs to change for this?

Hi !! first... thanks for this tool !!!! jajaja
I need help with this plugin in Angular, how can i change the color dots?
I tried change color from source code and i dont have any changes.
I tried make a new class for slick... and nothing.
Do you have any idea? :(

Hi !! first... thanks for this tool !!!! jajaja
I need help with this plugin in Angular, how can i change the color dots? I tried change color from source code and i dont have any changes. I tried make a new class for slick... and nothing.
Do you have any idea? :(

For Angular - I used SebastianGicquel's solution and put it in the styles.scss file for it to work.


Incorporate with firepath or any element specifier with firebug-lite?

Hi,
Can you please incorporate firebug-lite with firepath? Is this possible?
Any answers for this?

Firepath is an extension for Firebug (not Firebug Lite)
https://addons.mozilla.org/en-US/firefox/addon/firepath/
So, it isn't possible.
Honza

Thanks for your comments!!
Suggest me, how to evaluate my xpath,id is correct in IE Browser? Or any other evaluate option for IE Browser?

Try to open IE dev tools (F12), switch to the Console panel use XPathEvaluator (or slectNode/selectSingleNode) on the command line?
Honza


Text overlapping on 'community' page

On the community page Açık Yazılım Ağı text overlapping on the logo when the width>=768
page: 'https://acikyazilimagi.com/elements'

Could you please write the problem with screenshots so that it can be more clearly understood? I didn't fully grasp it because when I looked at it.

On current view
On 768x878

As you can see the Eser Ozvataf is overlapping. I hope I was able to explain the problem @Batuhandgenc

I actually discussed this with Eser in the early hours today. I experienced the same issue when connecting with Linux/Ubuntu using Chrome. Based on my brief experiences, I thought it was because the code wasn't contained in separate boxes.
However, in the screenshot Eser sent, there doesn't seem to be any problem.

Still, could you please let me know the version you are using and whether you are on Windows/Ubuntu/iOS?

I actually discussed this with Eser in the early hours today. I experienced the same issue when connecting with Linux/Ubuntu using Chrome. Based on my brief experiences, I thought it was because the code wasn't contained in separate boxes.
However, in the screenshot Eser sent, there doesn't seem to be any problem.

Still, could you please let me know the version you are using and whether you are on Windows/Ubuntu/iOS?

This is products page, i mean /elements could you please check it again?

I'm using Firefox 115.0.2 (64-bit) on my 1920x1080 Arch Linux laptop.

I faced the same issue with my 27" monitor (you can also see the overflow if you zoom out with the scroll wheel)
https://github.com/acikkaynak/aya-website/assets/54645034/c5a90395-aeda-4cca-8e66-37dec8847e7e
The easiest way to solve this problem is to use min-height not just height in here:
https://github.com/acikkaynak/aya-website/blob/main/packages/web/src/shared/components/profiles/widgets/cards.module.css#L16


ws: Accumulate surface frame callbacks until commit

Move code around to accumulate surface frame callback additions until changes are comitted to the surface, as intended according to the base Wayland protocol specification.
As a bonus, remove the auxiliar ViewBackend::FrameCallbackResource by passing a destruction callback to wl_resource_set_implementation() and using the internal wl_resource list link.

There are a few other surface operations which should also be queued on the nested compositor server side until the client issues a wl_surface_commit(). I would prefer to change one at a time, starting with this PR for the frame callbacks, and probably the next one would be Surface::bufferResource if the comments are positive 😃

I have rebased this on top of the changes introduced by #151 and applied the suggested code styling changes, PTAL.

Thanks @zdobersek 🙇🏼♂

Cherry-picked into the wpebackend-fdo-1.8 branch as commit ce4393e9348a6ac52f6cfa4a20b23c30851b6d22.


Support for NetStandard???

Hi Daniel, First of all I want to thank you about this great control, it has been very useful on my apps.
You'll see, I'm trying to migrate my PCL libraries to netStandard, but this control is not compatible with Net standard, so I want to ask you if you have in mind release a version compatible with that?
I'll really appreciate your comments. Thanks in advance.

I merged your PR, so we now have .NETStandard support. I'll release nuget containing fixes today :)

It's good to read that :) and know that I can help your awesome control library.
Thanks Daniel .


how to check the current auth status from swiftlocation ??

how to check the current auth status from swiftlocation ??

Thank you for your contribution.
A new rewritten version is available both on master and CocoaPods (marked as 3.0.0-beta). It requires iOS9 and Swift 4.
If you encounter any other problem feel free to open an issue; I'll close because with the new version its now invalid.
Current status can be obtained by calling CLLocationManager.authorizationStatus


Editor doesn't load the page content and can't save

I'm trying to use this package in my laravel project.
When I go to this link: http://<IP_ADDRESS>:8000/admin/pages/1/editor then the editor loads, but with a blank page. I getting an error in the console tab: The defination for plugin 'gjs-plugin-ckeditor' not found. I haven't changed anything in the config.
Page model:
<?php

namespace App\Models;

use Illuminate\Database\Eloquent\Factories\HasFactory;
use Illuminate\Database\Eloquent\Model;
use Dotlogics\Grapesjs\App\Traits\EditableTrait;
use Dotlogics\Grapesjs\App\Contracts\Editable;

class Page extends Model implements Editable
{
    use HasFactory, EditableTrait;

    protected $fillable = ['title', 'content', 'author', 'permalink', 'password', 'status'];

    protected $casts = [
        'password' => 'boolean',
    ];

}

I added use EditorTrait;and the editor method into the PageController :
public function editor(Request $request, Page $page)
    {
        return $this->show_gjs_editor($request, $page);
    }

And the route is  Route::get('pages/{page}/editor', [BackendPageController::class, 'editor']);
And I can't save what I doing in the editor because I get a 403 error if I click on the save button.
http://<IP_ADDRESS>:8000/laravel-grapesjs/App-Models-Page/1 403 (Forbidden)
You can see everything in the picture:

do you have gjs_data column on Page model ??

this column use to store the grapesjs data

Yes, I added it manually to the pages table as JSON type

@kadrian92  in your config see laravel-grapejs.php file and check for routes, disable the auth middleware and your 403 will be solved.

Hi Team, When i Render PHP file into grape JS Only php code is diplay


Adding auto_pull_interval to registry resource

Fix for issue https://github.com/aquasecurity/terraform-provider-aquasec/issues/158
When configuring automatic scan for registry integration, the console requires the auto_pull_interval value

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Can't compile following instructions from AppSpot

Have you read the FAQ and checked for duplicate open issues?:
Yes
What version of Shaka Player are you using?:
Latest from GitHub at the time of this post.
Can you reproduce the issue with our latest release version?:
I am using the latest..
Can you reproduce the issue with the latest code from master?:
I am using the latest from master..
Are you using the demo app or your own custom app?:
I am compiling..
If custom app, can you reproduce the issue using our demo app?:
N/A
What browser and OS are you using?:
Debian 9
What are the manifest and license server URIs?:
N/A
What did you do?
I tried compiling Shaka following these instructions: https://shaka-player-demo.appspot.com/docs/api/tutorial-welcome.html
What did you expect to happen?
I expected Shaka to compile.
What actually happened?
Shaka did not compile..
root@live:/usr/local/nginx/html/shaka-player/build# PRINT_ARGUMENTS=1 python2.7 all.py
[INFO] Generating Closure dependencies...
[INFO] /usr/bin/python2.7 third_party/closure/deps/depswriter.py "--root_with_prefix=lib ../../../lib" "--root_with_prefix=ui ../../../ui" "--root_with_prefix=third_party/closure ../../../third_party/closure" "--root_with_prefix=third_party/language-mapping-list ../../../third_party/language-mapping-list"
[INFO] npm -v
Traceback (most recent call last):
  File "all.py", line 122, in <module>
    shakaBuildHelpers.run_main(main)
  File "/usr/local/nginx/html/shaka-player/build/shakaBuildHelpers.py", line 312, in run_main
    sys.exit(main(sys.argv[1:]))
  File "all.py", line 70, in main
    if check.main(check_args) != 0:
  File "/usr/local/nginx/html/shaka-player/build/check.py", line 157, in main
    if not shakaBuildHelpers.update_node_modules():
  File "/usr/local/nginx/html/shaka-player/build/shakaBuildHelpers.py", line 278, in update_node_modules
    if _parse_version(version) < _parse_version('1.3.12'):
  File "/usr/local/nginx/html/shaka-player/build/shakaBuildHelpers.py", line 59, in _parse_version
    return tuple([int(i) for i in version.split('.')])
ValueError: invalid literal for int() with base 10: '0-next'

It looks like we can't handle the version number of your npm install.  Are you using a pre-release or compiled from source version of npm?  What is the output of npm --version?  Can you try with a release version of npm (e.g. 6.4.1).


Retrieve PowerShell version in PSVersionInfo using assembly informational version instead of FileVersionInfo

PR Summary
This PR changes PSVersionInfo static constructor to retrieve PowerShell version data from AssemblyInformationalVersionAttribute, instead of using FileVersionInfo class.
PR Context
This change is a first step towards making System.Management.Automation single-file-application-friendly ‒ without this PR, PSVersionInfo static constructor throws an exception when used in a single-file application due to Assembly.Location returning "" ‒ and provides a small performance boost at startup (which contributes a tiny bit to #14268) since it does not parse System.Management.Automation DLL to retrieve the version anymore.
Here is the performance of the two changed lines:

before PR: ~0,23ms
after PR: ~0,03ms (~7 times faster)

PR Checklist

[x] PR has a meaningful title
[x] Summarized changes
[x] Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
[x] This PR is ready to merge and is not Work in Progress.

If the PR is work in progress, please add the prefix WIP: or [ WIP ] to the beginning of the title (the WIP bot will keep its status check at Pending while the prefix is present) and remove the prefix when the PR is ready.

Breaking changes

[x] None
OR
[ ] Experimental feature(s) needed

[ ] Experimental feature name(s):

User-facing changes

[x] Not Applicable
OR
[ ] Documentation needed

[ ] Issue filed:

Testing - New and feature

[x] N/A or can only be tested interactively
OR
[ ] Make sure you've added a new test if existing tests do not effectively test the code changed

Tooling

[x] I have considered the user experience from a tooling perspective and don't believe tooling will be impacted.
OR
[ ] I have considered the user experience from a tooling perspective and enumerated concerns in the summary. This may include:

Impact on PowerShell Editor Services which is used in the PowerShell extension for VSCode (which runs in a different PS Host).
Impact on Completions (both in the console and in editors) - one of PowerShell's most powerful features.
Impact on PSScriptAnalyzer (which provides linting & formatting in the editor extensions).
Impact on EditorSyntax (which provides syntax highlighting with in VSCode, GitHub, and many other editors).

@Fs00 Thanks for your contribution!
I hope that we will soon be able to use .Net 6.0 Source Generators. So I'm going to refactor PSVersionInfo class and move all version constants to new GitInfo class. Later we will be able to generate it with a simple source generator and thereby remove all reflection overhead.
I will use your idea in follow PR.

@iSazonov Good to know.
Since it isn't sure when the refactoring with source generators will be done, could this PR be merged in the meantime? It would still be an improvement on the current situation and would allow me to test System.Management.Automation on single-file applications to see if there are any other issues.

Since it isn't sure when the refactoring with source generators will be done, could this PR be merged in the meantime?

I see with the PR PowerShell loads less assembles at startup - it is great perf improvement! I think we will merge the PR.

I see System.Diagnostics.FileVersionInfo.dll is still loaded on Windows in AmsiUtils.Init()
https://github.com/PowerShell/PowerShell/blob/ea3036dc6d5bcbd58ee2b3b1960a3647467d0801/src/System.Management.Automation/security/SecuritySupport.cs#L1355-L1357
@PaulHigin @TravisEz13 Do really need the FileVersionInfo.ProductVersion? Can we use the same approach as @Fs00 in the PR?

@Fs00 Thanks for your contribution!

@Fs00 Late to the party but please accept my gratitude for your efforts to bring PowerShell closer to single-file-application-friendly!


Ignore default-path-monitor in service monitors comparison

On netscaler cluster when a service has path monitoring enabled,
default-path-monitor is automatically bound to the service.
This change adds path monitor to the list of internal monitors
to ignore.

@giorgos-nikolopoulos This is a one line change to fix citrix_adc_service failing on netscaler cluster.

@giorgos-nikolopoulos @chiradeep Could you review this please? (issue #124)
This is a blocker for using citrix_adc_service on netscaler in clustered mode (not HA pair). The module currently fails as it tries (unexpectedly) to remove default-path-monitor from a service. Service on a clustered netscaler has always default path monitor attached and the module should ignore (skip) it in service sync function.

Fixed with #178


tests: lib: move p4workq to new ztest API

Move test lib/p4workp to use new ztest API.
Signed-off-by: li biao<EMAIL_ADDRESS>

Hi @1xlibiao , please fix the error of compliance check, thanks.

Hi @1xlibiao , please fix the error of compliance check, thanks.

ok,I'll do it as soon,thanks


dulwich: fall back to OpenSSH host config username/pw in asyncssh vendor

Should fix https://github.com/iterative/dvc/issues/7085

@skshetry is CI disabled for PRs purposely?

@pmrowla Please rebase.


service resource is incapable of managing the SSH service on Mac OS X

The Mac OS X provider for service does this super-smart thing where it globs across the system's LaunchDaemon directories for files that contain the service name. If more than one is found, it blows up with the following error:
Several plist files match service name. Please use full service name.

The problem is that I'm using the full service name, which is just ssh (see: /System/Library/LaunchDaemons/ssh.plist), and there's no way to get it to stop matching whatever it feels like in these directories. Maybe a two-step process would be a better approach, where it looks for an exact match before globbing all the things?

Hi, I am also running into the bug. As previously noted, the launchd provider plist scan is incorrect. It should go through all plists (in the specified directories), extract the label for each, and compare with the service name. The Label "contains a unique string that identifies your daemon to launchd." (docs). Therefore, the plist file names should be completely ignored (as their names are only a convention, not a strict rule), and it should (probably) fail on duplicate labels. FYI, the full service name for shh in launchd is: 'com.openssh.sshd'

@jtimberman ?

I'll look into this next week.

Adding some context:
$ sudo chef-apply -e 'service("ssh") { action [:enable, :start] }'
Recipe: (chef-apply cookbook)::(chef-apply recipe)
  * service[ssh] action enable
    * Several plist files match service name. Please use full service name.
    ================================================================================
    Error executing action `enable` on resource 'service[ssh]'
    ================================================================================

    Chef::Exceptions::Service
    -------------------------
    Several plist files match service name. Please use full service name.

    Resource Declaration:
    ---------------------
    # In /tmp/recipe-temporary-file20150218-299-15otrh7

      1: service("ssh") { action [:enable, :start] }

    Compiled Resource:
    ------------------
    # Declared in /tmp/recipe-temporary-file20150218-299-15otrh7:1:in `run_chef_recipe'

    service("ssh") do
      action [:enable, :start]
      supports {:restart=>false, :reload=>false, :status=>false}
      retries 0
      retry_delay 2
      guard_interpreter :default
      service_name "ssh"
      pattern "ssh"
      cookbook_name "(chef-apply cookbook)"
      recipe_name "(chef-apply recipe)"
    end

[2015-02-18T10:46:02-07:00] FATAL: Stacktrace dumped to /var/chef/cache/chef-stacktrace.out
[2015-02-18T10:46:02-07:00] FATAL: Chef::Exceptions::Service: service[ssh] ((chef-apply cookbook)::(chef-apply recipe) line 1) had an error: Chef::Exceptions::Service: Several plist files match service name. Please use full service name.

The stacktrace:
$ sudo cat /var/chef/cache/chef-stacktrace.out
Generated at 2015-02-18 10:46:02 -0700
Chef::Exceptions::Service: service[ssh] ((chef-apply cookbook)::(chef-apply recipe) line 1) had an error: Chef::Exceptions::Service: Several plist files match service name. Please use full service name.
/opt/chefdk/embedded/apps/chef/lib/chef/mixin/why_run.rb:241:in `run'
/opt/chefdk/embedded/apps/chef/lib/chef/mixin/why_run.rb:322:in `block in run'
/opt/chefdk/embedded/apps/chef/lib/chef/mixin/why_run.rb:321:in `each'
/opt/chefdk/embedded/apps/chef/lib/chef/mixin/why_run.rb:321:in `run'
/opt/chefdk/embedded/apps/chef/lib/chef/provider.rb:134:in `process_resource_requirements'
/opt/chefdk/embedded/apps/chef/lib/chef/provider.rb:111:in `run_action'
/opt/chefdk/embedded/apps/chef/lib/chef/resource.rb:648:in `run_action'
/opt/chefdk/embedded/apps/chef/lib/chef/runner.rb:49:in `run_action'
/opt/chefdk/embedded/apps/chef/lib/chef/runner.rb:81:in `block (2 levels) in converge'
/opt/chefdk/embedded/apps/chef/lib/chef/runner.rb:81:in `each'
/opt/chefdk/embedded/apps/chef/lib/chef/runner.rb:81:in `block in converge'
/opt/chefdk/embedded/apps/chef/lib/chef/resource_collection.rb:98:in `block in execute_each_resource'
/opt/chefdk/embedded/apps/chef/lib/chef/resource_collection/stepable_iterator.rb:116:in `call'
/opt/chefdk/embedded/apps/chef/lib/chef/resource_collection/stepable_iterator.rb:116:in `call_iterator_block'
/opt/chefdk/embedded/apps/chef/lib/chef/resource_collection/stepable_iterator.rb:85:in `step'
/opt/chefdk/embedded/apps/chef/lib/chef/resource_collection/stepable_iterator.rb:104:in `iterate'
/opt/chefdk/embedded/apps/chef/lib/chef/resource_collection/stepable_iterator.rb:55:in `each_with_index'
/opt/chefdk/embedded/apps/chef/lib/chef/resource_collection.rb:96:in `execute_each_resource'
/opt/chefdk/embedded/apps/chef/lib/chef/runner.rb:80:in `converge'
/opt/chefdk/embedded/apps/chef/lib/chef/application/apply.rb:144:in `run_chef_recipe'
/opt/chefdk/embedded/apps/chef/lib/chef/application/apply.rb:153:in `run_application'
/opt/chefdk/embedded/apps/chef/lib/chef/application/apply.rb:166:in `run'
/opt/chefdk/embedded/apps/chef/bin/chef-apply:25:in `<top (required)>'
/usr/bin/chef-apply:38:in `load'
/usr/bin/chef-apply:38:in `<main>'

Dropping off helpful links

https://developer.apple.com/library/mac/documentation/MacOSX/Conceptual/BPSystemStartup/Chapters/CreatingLaunchdJobs.html
https://github.com/chef/chef/blob/master/lib/chef/provider/service/macosx.rb

I have a simple change that might address this.
https://github.com/chef/chef/pull/3051

Is this still an issue now that #3051 was merged?

Paging @jgoldschrafe -

assuming #3051 fixed this


MLHR-1881 topic & zookeeper based offset manager for kafka0.8.2

Initial commit for preview & comments.
Clean-up, externalization & tests to follow soon.

@devtagare Please add the unit test. There are existing Kafka unit tests for reference.

@siyuanh please review.


fix: rend valus-istio-gateways.yaml miss cpu.targetAverageUtilization

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: andraxylia
If they are not already assigned, you can assign the PR to them by writing /assign @andraxylia in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

install/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

I signed it!


[MNT] Added deprecation warning for HCrystalBallForecaster

Reference Issues/PRs
I opened also an issue at hcrystalball repo so they are aware of it. Pinged Michal Chromcak on Slack but no response.
What does this implement/fix? Explain your changes.
Added deprecation warning

@MichalChromcak fyi


The script doesn't create a correct Standard_HC44rs cluster with Mellanox EDR InfiniBand

I need to run HPC applications (like LAMMPS) on a high bandwidth  but the cluster doesn't seems to be configured correctly.
Describe the bug

Mpi is not picking up Mellanox
LAMMPS doesn't scale as expected (lower performance over tcp)

To Reproduce
Steps to reproduce the behavior:

create a cluster using this config.json
mlx-fail.config.txt

setup the environment and  run
mpiexec.hydra  -f ${hostfile} -n 88 -ppn 44 ./lmp_intel_cpu_intelmpi -in in.intel.lc -v x 4 -v y 2 -v z 2 -pk intel 0 omp 1 -sf intel

Expected behavior

get the expected network bandwidth
Mlx provider should be detected and used:
[0] MPI startup(): libfabric provider: mlx
LAMMPS should scale on 2 or more nodes.

** Other details
created a cluster with OpenLogic:CentOS:7_7-gen2:latest
Used Standard_HC44rs for compute nodes
Used Standard_D8s_v3 for headnode
** Additional details
To try to grantee that Mellanox is installed and setup correctly, i tried to set the headnode to be Standard_HC44rs but it fails with the error bellow:

AN (Accelerated networking) is not available for HC. Please set "accelerated_networking": false for HC

@jithinjosepkl  in the config file i shared? Will that fix the interconnect issue?

Please follow this article to make IMPI pick the mlx provider.
Next update of CentOS HPC images will include IMPI 2019-U8, where you don't have to specify this environment parameter (picks up mlx provider by default).

@jithinjosepkl I would appreciate a working scenario as the cost is getting very high without us getting a job ran correctly.
I'm interested in Standard_HC44rs cluster with Mellanox and Gen2 VM
surprisingly the  OpenLogic:CentOS:7_7-gen2:latest image didn't come with any IMPI installed (It sounds like it get overridden maybe via the azurehpc scripts?). So i had to install IMPI manually .
When i setup the Mlx, i get an error because the interconnect is not installed/setup correctly:
[hpcadmin@headnode lammps-avx512]$ export FI_PROVIDER=mlx
[hpcadmin@headnode lammps-avx512]$ mpirun -n 2 -ppn 44 /opt/intel/psxe_runtime/linux/mpi/intel64/bin/IMB-MPI1 pingpong
[0] MPI startup(): Intel(R) MPI Library, Version 2019 Update 8  Build 20200624 (id: 4f16ad915)
[0] MPI startup(): Copyright (C) 2003-2020 Intel Corporation.  All rights reserved.
[0] MPI startup(): library kind: release
[0] MPI startup(): libfabric version: 1.10.1-impi
Abort(1091215) on node 0 (rank 0 in comm 0): Fatal error in PMPI_Init_thread: Other MPI error, error stack:
MPIR_Init_thread(136)........:
MPID_Init(1138)..............:
MPIDI_OFI_mpi_init_hook(1061): OFI addrinfo() failed (ofi_init.c:1061:MPIDI_OFI_mpi_init_hook:No data available)

The CentOS images do not contain any pre-installed OFED drivers and mpi libraries (including Intel MPI), try using the CentOS-HPC images instead (e.g OpenLogic:CentOS-HPC:7_7-gen2:latest). The CentOS-HPC images should be ready to go if you want to use Infiniband.

@garvct  I'm already using OpenLogic:CentOS-HPC:7_7-gen2:latest image. Please see my original post

@Smahane , based on your config file, you are using OpenLogic:CentOS:7_7-gen2:latest.
        "hpc_image": "OpenLogic:CentOS:7_7-gen2:latest",
You need OpenLogic:CentOS-HPC:7_7-gen2:latest image instead for the MPIs to be pre-installed.

Once you sort out your image, you can execute the IMB-MPI1 benchmark using the scripts in azurehpc/apps/imb-mpi. Examples of running IMB-MPI1 with different MPI libraries are provided.

@garvct and @jithinjosepkl thank you for pointing me out of this HPC image.

Should headnode have this image too?
Should I still set "accelerated_networking": false" ? And what does it mean?
any instructions of how to add my own post installation script to the config file?

@Smahane

The Headnode can have the HPC image too
Accelerated Networking is offloading TCP and will boost the frontend NIC, but is not available on all VM SKUs. See the public documentation here
You can add your own scripts by

Adding your scripts in the scripts directory where your config file is stored
Add a custom tag on the resources you want your scripts to be applied
In the install array add a section for each script you want to be applied, specify if sudo is required, and add params and deps files if needed

This worked.  Thank you everyone

Hello @xpillons @garvct and @jithinjosepkl . I ran LAMMPS on up to 8 nodes Standard_HC44rs but I'm having performance issues at 8 nodes:

I think one or more nodes are bad. Do you know of any smoke test or script that can help me check the nodes and detect which one is not working well?
the azhpc_install_config/install/11_node_healthchecks.log doesn't show any errors.
Thank you,

@Smahane you can use the MPI PingPong test, we have an example here https://github.com/Azure/azurehpc/tree/master/apps/imb-mpi


Mail

This is an update to our sendmail functionality.  Sendmail was stuffed in mail.subs.php and had quite a few paths through the code along with some recursion etc.
This PR breaks out (3) new classes to deal with what sendMail previously did.

BuildMail is a class that deals with crafting the proper email headers, handling any special PBE needs.   It also builds the actual email message bodies.   The (3) bodies consist of:

Plain text.  This is an ASCII only version as required by mime multipart.  This has control characters removed and any >127 ASCII characters are converted to #&123; entities to remain complaint.  If HTML was supplied it is stripped out, although it adds some newlines at the block level elements (</div> => "\n").
Encoded text.  This is a base64 encoded version of the message.  Any entities are changed into proper utf-8 characters then the result is base64 encoded always.  The old function would only base64 if >127 ASCII characters were found but I feel this is a unnecessary distinction and simply adds another execution path.  This is set as text/plain
Encoded text.  This is a quoted-printable version of the message.  It undergoes the same processing as above but the result is then QP encoded.  If HTML is provided it will set it as text/html otherwise text/plain.  This section would not appear at all in the old function unless you set and supplied HTML -or- if it was doing a hotmail fix.

The hotmail processing used only for at&t, bellsouth and comcast has been removed.

Mail class deals with the sending of what was created in BuildMail.  This will use php mail() or SMTP based on ACP settings.  Previously the mail() path was inside of sendmail and SMTP was its own function.  Lots of duplicate code between the two has now been removed and several issues resolved.  This function also takes care of the PBE code injection in to the various message bodies.

QueueMail breaks out the reduceQueue function.   Here again there was a lot of duplicate code that was consolidated as this uses the Mail class to send and take care of PBE etc.

There is a basic abstract class to set linebreaks, transport and other things common to the above (3) new classes.  Everything is now in the Mail namespace.  I left wrapper functions in Mail.subs.php so old calls still work.  Did I break anything? most likely ;)

Codecov Report

Merging #3610 (278071f) into development (0753124) will increase coverage by 0.54%.
The diff coverage is 41.90%.

@@                Coverage Diff                @@
##             development    #3610      +/-   ##
=================================================
+ Coverage          30.35%   30.90%   +0.54%
+ Complexity         15605    11690    -3915
=================================================
  Files                418      265     -153
  Lines              74453    49501   -24952
=================================================
- Hits               22601    15297    -7304
+ Misses             51852    34204   -17648

Impacted Files
Coverage Δ

sources/subs/Mail.subs.php
15.70% <5.00%> (-4.51%)
:arrow_down:

sources/ElkArte/Mail/Mail.php
18.05% <18.05%> (ø)

sources/ElkArte/Mail/BuildMail.php
60.41% <60.41%> (ø)

sources/ElkArte/Mail/BaseMail.php
81.57% <81.57%> (ø)

sources/ElkArte/Notifiers/AbstractNotifier.php
0.00% <0.00%> (-100.00%)
:arrow_down:

...urces/ElkArte/UrlGenerator/Standard/ParseQuery.php
0.00% <0.00%> (-100.00%)
:arrow_down:

sources/ElkArte/Controller/Profile.php
0.00% <0.00%> (-84.51%)
:arrow_down:

sources/subs/Menu.subs.php
14.53% <0.00%> (-84.31%)
:arrow_down:

sources/ElkArte/EventManager.php
6.34% <0.00%> (-79.37%)
:arrow_down:

...ces/ElkArte/AdminController/ManageMembergroups.php
1.88% <0.00%> (-75.63%)
:arrow_down:

... and 350 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1de4c04...278071f. Read the comment docs.

No comments, guess its OK to go !


improve error message

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

6 of 6 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.2%) to 83.659%

Totals

Change from base Build<PHONE_NUMBER>:
0.2%

Covered Lines:
343

Relevant Lines:
410

💛  - Coveralls


Random failed on page with pdfjs viewer

On the same page, if there is a pdfjs ( http://mozilla.github.io/pdf.js/ ) viewer in iframe, sweetalert randomly failed with no reason. (I repeat this action about 20 times, it failed 13 times).
I don't know which version I should provide for you. You can ask me if you need any further information.
Stack trace:
Cannot read property 'querySelector' of null (this line https://github.com/lipis/bootstrap-sweetalert/blob/master/lib/sweet-alert.js#L458 )
setParameters (this line https://github.com/lipis/bootstrap-sweetalert/blob/master/lib/sweet-alert.js#L458 )
window.sweetAlert.window.swal (this line https://github.com/lipis/bootstrap-sweetalert/blob/master/lib/sweet-alert.js#L258 )
My page js dependency
            'bower_components/jquery/dist/jquery.js',
            'bower_components/bootstrap/dist/js/bootstrap.js',
            'bower_components/wow/dist/wow.min.js',
            'bower_components/sticky-kit/jquery.sticky-kit.js',
            'bower_components/toastr/toastr.js',
            'bower_components/bootstrap-sweetalert/lib/sweet-alert.js',
            'bower_components/pace/pace.js',
            'bower_components/jquery-unveil/jquery.unveil.js',
            'bower_components/jquery-form/jquery.form.js',
            'bower_components/selectize/dist/js/standalone/selectize.js'
            'bower_components/FroalaWysiwygEditor/js/froala_editor.min.js',
            'bower_components/FroalaWysiwygEditor/js/langs/vi.js',
            'bower_components/FroalaWysiwygEditor/js/plugins/colors.min.js'

I know it is a heavy js page, but I don't have a clue why it fails randomly

@thangngoc89 Could you tell us if the issue is still present for the master branch version?

@alekitto I don't even remember why do I created this issue. So I close this now.


Debugging #73

Debugging #73

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

Hi! This is the friendly automated conda-forge-linting service.
I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.
Here's what I've got...
For recipe:

license_file entry is missing, but is required.

Hi! This is the friendly automated conda-forge-linting service.
I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.
Here's what I've got...
For recipe:

Failed to even lint the recipe, probably because of a conda-smithy bug :cry:. This likely indicates a problem in your meta.yaml, though. To get a traceback to help figure out what's going on, install conda-smithy and run conda smithy recipe-lint . from the recipe directory.

Hi! This is the friendly automated conda-forge-linting service.
I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.
Here's what I've got...
For recipe:

The recipe must have some tests.
license_file entry is missing, but is required.

Hi! This is the friendly automated conda-forge-linting service.
I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.
Here's what I've got...
For recipe:

The home item is expected in the about section.
The license item is expected in the about section.
The summary item is expected in the about section.
The recipe could do with some maintainers listed in the extra/recipe-maintainers section.
The recipe must have some tests.

Hi! This is the friendly automated conda-forge-linting service.
I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.
Here's what I've got...
For recipe:

The home item is expected in the about section.
The license item is expected in the about section.
The summary item is expected in the about section.
The recipe could do with some maintainers listed in the extra/recipe-maintainers section.
The recipe must have some tests.
The recipe must have a build/number section.

Hi! This is the friendly automated conda-forge-linting service.
I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.
Here's what I've got...
For recipe:

The home item is expected in the about section.
The license item is expected in the about section.
The summary item is expected in the about section.
The recipe could do with some maintainers listed in the extra/recipe-maintainers section.
The recipe must have some tests.

@conda-forge-admin, please rerender

Hi! This is the friendly automated conda-forge-webservice.
I tried to re-render for you but ran into some issues, please ping conda-forge/core for further assistance. You can also try re-rendering locally.

Turns out this is caused by https://github.com/conda-forge/gdk-pixbuf-feedstock/issues/13 interacting with these lines in conda-build.


[Bug] When the container widget is enlarged beyond the default page size and the child widgets positioning is breaking and the drag and drop is not visible

Description
Release - It is observed that when the container widget is enlarged beyond the default page size the child widgets positioning is breaking and also the drag and drop is not visible if the widgets are placed at the bottom of the container
Expected Result:
The child widgets positioning and the drag and drop should be visible when the container size is increased
Steps to reproduce the behaviour:
1.Launch appmsith app in the release environment
2.Drag and drop container widget
3.Increase the size of the container widget beyond the default canvas page size
4.Place widgets from top to bottom
5. Observe the widget positioning when placing at the bottom and check the visibility of drag and drop
Videolink:
https://loom.com/share/1722a456c7de463f80d91a9e4264bb51
Important Details:

Version: [11.3]
OS: [MacOS]
Browser [chrome, safari]
Environment [release]

@marks0351 This has been tested on release and marked as verified, you can go ahead and cherrypick this on prod. Once this is cherry picked we can do one round of sanity around this.


Add downsampling fastq files to < 1 GB (or whatever they determine that's way less than that)

closed and merged into #56


[cluster-test] Don't set RUST_BACKTRACE by default in container

It pollutes log quite a bit when set.
In case debugging is needed one can always override it with docker run -e RUST_BACKTRACE=1

@bors-libra r+

:pushpin: Commit 15b4922 has been approved by ankushagarwal

Added one more minor commit (it touches dockerfile, so including it in same PR)
@bors-libra r=ankushagarwal

:pushpin: Commit 68ebd9a has been approved by ankushagarwal

:hourglass: Testing commit 68ebd9ade44e9f13418a5b2f9081c1136333ba96 with merge 9a107352948a33d834f64745d62d8b0765b84f82...

:sunny: Test successful - checks-circle_commit_workflow
Approved by: ankushagarwal
Pushing 9a107352948a33d834f64745d62d8b0765b84f82 to master...


add text engines

Update the list of engine to get the latests engines: https://beta.openai.com/docs/engines/gpt-3

Yup that's what i did but its better to have these and now those engines are the default ones


[system] merge the composed css in breakpoint order (#16528)

[x] I have followed (at least) the PR section of the contributing guide.

See what you think.
At least you have a couple of tests which show you the problem (they will fail in the current css.js code)
Basically, the order of the keys in the output is dictated by either the order of the style functions passed tocompose or the props orders.
Also, note that deepEquals when comparing objects, does not verify the order of the keys, so I use Object.keys instead.


Add a constraint for filtering access terms.

Fixes https://github.com/jhu-idc/idc-isle-dc/issues/108.


Retry of JESTClient.execute

Hi All,
I am using JEST for Bulk insert and Bulk delete. Could you help to confirm whether the client.execute(...) have retry mechanism on failure or not.  let's say, in case it met any temporary error, it could sleep for 5 seconds and then retry the operation. and in case the operation fails more than 3 times, it will give up.
if we do not have above function, could we add in this feature?
best regards,
Zhifeng
----------------------------- below are my source code------------------
public void bulkInsert(String index, String type, List<Tuple2<String, String>> docs) throws Exception {
List actions = new LinkedList<>();
    for (Tuple2<String, String> doc : docs) {
        actions.add(new Index.Builder(doc._2()).id(doc._1()).build());
    }
    Bulk bulk = new Bulk.Builder()
            .defaultIndex(index)
            .defaultType(type)
            .addAction(actions)
            .build();
    BulkResult result = client.execute(bulk);
    if (!result.isSucceeded()) {
        throw new Exception(String.format("fail to send bulk for  index %s, type %s: %s", index, type, result.getErrorMessage()));
    }
}

@zhifengMaBeijing Jest itself doesn't retry failed requests but you could add a HttpRequestRetryHandler to the underlying Apache Http Client.
But be aware that this doesn't rotate through the server pool (if you have more than one Elasticsearch node) but simply sends the same request to the same node again.


GPIO: Add support for tri-state mode

Some use cases require switching a pin between output and floating mode on the fly. This is very inconvenient with the current API. The DWM1001 board support crate has an example that demonstrates this.
I believe the solution for this is to add a tri-state mode that implements the following trait:
pub trait TriStatePin {
    fn set_high(&mut self);
    fn set_low(&mut self);
    fn set_floating(&mut self);
}

Such an abstraction has been proposed before.
If we decide to implement this, we should submit the trait I suggested above to embedded-hal.

I see the use of this and would welcome an implementation.
Atm those functions do not alter the Pin type ofc, so forgive me the dumb question, but how can I, after, let's say a ::set_floating() of a Pin<Output> access a let's say ::is_low()? Also the generic type of that pin would not represent the actual pin state anymore after such a proposed TriStatePin operation if I understand everything right.
So do you think that is of no concern or do I missunderstand you?
If I understand everything correctly we maybe should rather return a converted Pin from the TriStatePin methods and make them consume self?

I think we'd need a separate tri-state mode that is distinct from input or output mode. So you'd call into_tri_state_pin, which gets you a Pin<TriState>, which would then make the methods above available.
The lack of compile-time state tracking within the tri-state mode is intended, and indeed, is the whole point of why I suggested this. See the example I linked for an example of the compile-time state tracking getting into the way.
The methods I propose only cover the use case from my example, which doesn't require is_low/is_high. A complete implementation would include those within the tri-state mode.


Translate templates to English and make example project

Master branch should be international and only include files in english.

Fixed.


Assertion fails for ImVector::operator

Hi!
I've been trying to use ImGuizmo for my project for quite some time now, and I keep on running into an assertion error in ImGui whenever ImGuizmo.BeginFrame(); is invoked.
I can't really figure out where to stick the error so here it is:
T& ImVector<T>::operator[](int) [with T = ImGuiViewportP*]: Assertion 'i >= 0 && i < Size' failed.
I don't get an error stack and I'm unsure if I can get one since I'm running C#.
ImGuizmo.BeginFrame is being invoked just after my ImGui backend invokes ImGui.NewFrame.
Please tell me if there's any more information needed :)

Managed to figure out GDB and narrowed it down to ImGui::GetMainViewport() being called within ImGuizmo::BeginFrame(). Time to figure out why that's asserting.

Seems to be an issue with the ImGuiContext having a 0-size Viewports array(or so I'd assume, since 0-indexing should only fail if the size is 0). Might have to move the issue to the main ImGui repo unless I'm missing something

Seems as if I call ImGui.GetMainViewport() from managed code it works without a hitch, and the managed code just calls down into ImGui::GetMainViewport so it's not an issue with ImGui from what I can tell. Reading into the code I'm not even able to find a trace of ImGui::GetMainViewport so I'm getting fairly confused now.

Figured out I never actually replaced the binaries(due to how .NET prioritizes .so files), so  now it's instead a SIGSEGV in ImGui::PushStyleColor/ImVector::push_back. We'll see how this goes heh.

All right, so I recompiled and linked cimguizmo and cimgui to the same ImGui binary, and managed to figure out a bit more using lldb. ImGui and ImGuizmo are using a context located at the same location, but for whatever reason it looks to be corrupt by the time ImGuizmo gets around to actually using it, which is where the issue comes from.
Strange...

I didn't really want to share binaries since copyright stuff makes it all complex, and there are a lot of test assets that I don't directly own, but I thought that sending binaries might just help(once this issue is resolved I'll delete the files from drive just to be sure)
https://drive.google.com/file/d/1Pklyyt6bdxtdKWKvxZUy1EBq1FgvByjs/view?usp=sharing

They might be compiling with different ideas of what an ImGuiContext is?
I am incredibly confused and would greatly appreciate some help
(lldb) expression ((ImGuiContext*)0x0000555555b1ea50)->Viewports
(ImVector<ImGuiViewportP *>) $5 = {
  Size = 1
  Capacity = 8
  Data = 0x0000555555b26aa0
}
(lldb) expression ((ImGuiContext*)GImGui)->Viewports
(ImVector<ImGuiViewportP *>) $6 = {
  Size = 1
  Capacity = 8
  Data = 0x0000555555b26aa0
}
(lldb) expression GImGui->Viewports
(ImVector<ImGuiViewportP *>) $7 = {
  Size = 0
  Capacity = 0
  Data = nullptr
}
(lldb) frame variable GImGui
(ImGuiContext *) ::GImGui = 0x0000555555b1ea50
(lldb) expression  GImGui == 0x0000555555b1ea50
(bool) $8 = true

Going slowly insane lol

I haven't been able to fully test it yet, but I finally got it to at least run!
What I had to do was to change the following lines in imgui_internal.h from
#ifndef IMGUI_DISABLE_OBSOLETE_KEYIO
        ActiveIdUsingNavInputMask = 0x00;
#endif

to
        ActiveIdUsingNavInputMask = 0x00;

So seems like it was just a silly compiler flag lol.
Happy to have this resolved!


chore(deps): upgrade dependencies

Upgrades project dependencies. See details in workflow run.

Automatically created by projen via the "upgrade-main" workflow

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (22b2dd9) 95.69% compared to head (36da3c2) 95.69%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #885   +/-   ##
=======================================
  Coverage   95.69%   95.69%
=======================================
  Files           1        1
  Lines         395      395
  Branches       53       53
=======================================
  Hits          378      378
  Misses         17       17

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Realtime Emotion recognition.

Realtime Emotion recognition using facial expressions analysis.

@akshitagupta15june Can you please assign me this issue?. I want to work on it.

I wish to work on this issue as part of SWOC.

ok assigned to u

Can I proceed with the same, I can do the work. I am an SWoC participant @akshitagupta15june  ??

Can I proceed with the same, I can do the work. I am an SWoC participant @akshitagupta15june  ??

hi @TanweerulHaque  i think @aditi-saxena-1206 is working on this.

hi @TanweerulHaque  i think @aditi-saxena-1206 is working on this.

Yeah I am. Just trying to get a better accuracy.
On Thu, 14 Jan 2021, 19:00 AKSHITA GUPTA<EMAIL_ADDRESS>wrote:

hi @TanweerulHaque https://github.com/TanweerulHaque i think
@aditi-saxena-1206 https://github.com/aditi-saxena-1206 is working on
this.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/akshitagupta15june/Face-X/issues/63#issuecomment-760197726,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AOOZDUNPFKE5TOUVDK5FX4LSZ3WYBANCNFSM4VMCS24A
.

Yeah I am. Just trying to get a better accuracy.
On Thu, 14 Jan 2021, 19:00 AKSHITA GUPTA<EMAIL_ADDRESS>wrote:

hi @TanweerulHaque https://github.com/TanweerulHaque i think
@aditi-saxena-1206 https://github.com/aditi-saxena-1206 is working on
this.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/akshitagupta15june/Face-X/issues/63#issuecomment-760197726,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AOOZDUNPFKE5TOUVDK5FX4LSZ3WYBANCNFSM4VMCS24A
.

Can I do it ?? @akshitagupta15june if it's still not done. I am an SwoC participant.

Can I do it ?? @akshitagupta15june if it's still not done. I am an SwoC participant.

I'm almost done with it. Will be adding it soon.
On Tue, 19 Jan 2021, 18:58 Tanweer<EMAIL_ADDRESS>wrote:

Can I do it ?? @akshitagupta15june https://github.com/akshitagupta15june
if it's still not done. I am an SwoC participant.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/akshitagupta15june/Face-X/issues/63#issuecomment-762838746,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AOOZDUPLOODBZTLLEOX2PB3S2WCJTANCNFSM4VMCS24A
.

I'm almost done with it. Will be adding it soon.
On Tue, 19 Jan 2021, 18:58 Tanweer<EMAIL_ADDRESS>wrote:

Can I do it ?? @akshitagupta15june https://github.com/akshitagupta15june
if it's still not done. I am an SwoC participant.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/akshitagupta15june/Face-X/issues/63#issuecomment-762838746,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AOOZDUPLOODBZTLLEOX2PB3S2WCJTANCNFSM4VMCS24A
.

Is this issue open??


[BUG] Krane is not compatible with Kubernetes 1.27, 1.25

Short issue description

Krane version:
OS (Linux/Mac/Windows..): Linux
Kubernetes version: 1.27.1, 1.25.8
Kubernetes distribution (e.g. GKE, EKS, ...):  local cluster kind
Krane works for me with this version v1.24.15, the upper version is the same error reported here
How can we reproduce the issue?
Similar to this another issue: https://github.com/appvia/krane/issues/297
Install krane inside Kubernetes-1.27 kind create cluster and run krane report --incluster inside the krane pod.
$ k -n krane exec -ti krane-76d95cc76-mfhxj -- bash
bash-5.1$ krane report --incluster
INFO: This may take several seconds to complete...
INFO: ERR Invalid graph operation on empty key. Graph `rbac-default` will be created.
error: HTTP status code 404, the server could not find the requested resource for GET https://kubernetes.default.svc/apis/policy/v1beta1.
bash-5.1$

Suggestions on how to fix the issue (OPTIONAL)

Thank for reporting the issue @krol3. Can you confirm whether you've installed krane using helm chart?
The issue above has been already addressed (#298), however, I can see that the release containing that fix hasn't been cut yet but should go out shortly. I'm going to close the issue for now.


Cell Descriptor File

Programing in a new cell is a process that is getting out of hand. Need a factory file like the entity one.

Check


Hard to compare table's data size

I was comparing the size of the data in the two tables to see which of the two tables was larger. I found the information I needed in the Info tab of the table, under the Table Stats section. One table had 132 MB and this was very clearly displayed, the other table displayed 78 213 KB, which equates to about 78 MB. I needed to do a calculation in my head to compare the sizes, couldn't do it with a quick glance.
First Table:

Second Table:

it's decided to switch to "normal" rule, where values above 1000 are displayed with another unit.


Support ES6 import statement in compiled files

Currently, having such a piece of code :
import foo from 'bar';

in any file compiled from sjs to js will make the compilation fail with an Escodegen error.
This is a problem that has been issued and fixed here https://github.com/estools/escodegen/issues/180 .
The fix has been part of Escodegen since the 1.4.0 version but sweet.js still relies on the 1.2.x version.
I have tried bumping the version number in package.json but there is an issue with the style code in sweet.js files :
/home/xxx/sweet.js/build/lib/sweet.js:47
function (root, factory) {
         ^
Warning: Unexpected token ( Use --force to continue.

The issue here is the whitespace between the function keyword and the arguments. This whitespace can be found in every function declaration I have looked at and as far as I know is not a really good practice. I can understand it breaks the parsing.
How should this be handled ?

I'm mass closing issues due to the release of 1.0 obviating lots of bugs. If you feel this issue is something we still need to address feel free to reopen.