Use micromamba in Github workflows

Changes
the miniconda action takes almost 3 minutes to setup mamba itself. So we switch to a preinstalled version of mamba.

since the setup with readthedocs and conda-forge is now quite stable I think we can also remove the final 3 steps of the build process (set package file env, actions/upload-artifact@v2, upload releases to dev label on Anaconda Cloud) for the conda build workflow @marscher 👍

nice, that would simplify things a lot.

The rtd_environment.yaml installs weldx in development mode via a relative path. However this does not seem to work within the Github action, because the working directory is outside of the source/working copy (but in the $HOME/micromamba/envs dir). I've opened up an issue upstream.

setup seems pretty fast now 🚀

The only thing missing for a fast doc building is to use multiple sphinx jobs #508

wondering why the pytest run is missing here 🤔


Add 1st batch of speaker photos & listings

Add listings to devent.toml
Add images to website/public/speakers

@tbenbow Thanks for the resizing. I am at least a decade out of date on frontend dev.
I assume this means we don't want people PR'ing their own speaker photos — or we could have them PR it, but I/team could handle resizing before merging. What tool are you using to resize?


Fix incompatible assemblies building issues

Remove reference to TwoWayIPCLib
Downgraded System.Text.Json package in Settings.Lib

Summary of the Pull Request
#2241

References

PR Checklist

[] Applies to #xxx
[] CLA signed. If not, go over here and sign the CLA
[] Tests added/passed
[] Requires documentation to be updated
[] I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

Just to confirm, what was the reason for the JSON lib version downgrade?

Just to confirm, what was the reason for the JSON lib version downgrade?

@niels9001 is experiencing crashes when building and running Settings.UI.exe from Visual Studio. One of the crashes he saw was caused because there are different versions of the System.Text.Json assembly referenced. This happens because Settings.UI.Runner is a .Net Core executable while Settings.UI.Lib is .Net Framework.
While .Net Core has built in System.Text.Json support, the .Net Framework class library has to consume it as a nuget package. What was happening was that the Json assemblies versions didn't match, so it lead  to crashes in runtime.
I have no idea yet why this lead to crashing in some PCs and not in others, but it was reported as a MSBuild warning when building Settings.UI.Runner.


Adding new Watcher's Eye variants

I copied these from the wiki, and for some reason the diff is showing the addition and removal of almost all of them.
I also added a checkbox to differentiate between a jewel from Uber Elder and one from just regular Elder.  I wasn't able to figure out how to hide the checkbox for other uniques without my code removing all of the variant section or leaving a blank, so I just disabled it to get this in.  I can remove that commit or at least the checkbox after this weekend if you'd rather wait on that piece until later.

I copied these from the wiki, and for some reason the diff is showing the addition and removal of almost all of them.
I also added a checkbox to differentiate between a jewel from Uber Elder and one from just regular Elder. I wasn't able to figure out how to hide the checkbox for other uniques without my code removing all of the variant section or leaving a blank, so I just disabled it to get this in. I can remove that commit or at least the checkbox after this weekend if you'd rather wait on that piece until later.

Greetings. But why checkbox? Why not just third select box for third "while affected by" row? If all select boxes are same -> only one row for watcher's eye - it is working now. Or (and?) make first "None" option as alternative to make this process less frustrating.

is there an idea on when this pull request will be merged?

@Openarl I know you're super busy with the Blight release at the moment, but I wanted to put this back on your radar. From my perspective this is a fairly low-risk and high-value change that many users would really appreciate.
Is there more to be done here or does it just need a keen review from a core maintainer? Anything I can do to help?


Zappa has support for Custom domain names?

I trying to configure using zappa my Custom domain names and API Mappings.
There's some way to achieve that?

See https://github.com/Miserlou/Zappa#ssl-certification
You may have to tweak the API Gateway Custom Domains a bit in the console as well.


fix(list): meta doesn't work with some element

Trailing with meta doesn't work with some Element.
For exemple, if I try to create a a list with some radiobutton (on the right) with this code :
<ListItem key={index}>
  <ListItemText primaryText={item} />
  <ListItemMeta meta={<Radio>
    <NativeRadioControl
      name={item}
      {...}
    />
  </Radio>} />
</ListItem>

The css class mdc-list-item__meta is not present in the source code, so the element is not placed on right.

@moog16 Hello,
How can I trigger a rebuild ? I'm not sure that my change makes a build error.
Thank you for your help,
Regards


Unnecessarily long function

The function kernel::runtime::ensure_loaded_correctly() has an unnecessarily long if statement that can be replaced with a more suitable function like kernel::compare_memory().

You're right. 🙂 Reason is ensure_loaded_correctly was introduced very early on before compare_memory was even a thing.

By the way, why haven't you been online on Discord for the past two days?

Trying to focus on work 😋


Restore 350.org

313c61c6a155dffad0e628dd90112443c65ed778

Link URL

https://350.org/
Description

Restore link to 350.org
Why it should be included to Sustainable-Earth (optional)
Checklist

[x] Only one item/change is in this pull request
[x] Addition in chronological order (bottom of category) or sorted by most recent date (for articles)
[x] It's in English

          1 Warning

:warning:
Found 1 link issue, a project collaborator will take care of these, thanks :)

Link issue by awesome_bot

Line
Status
Link

85
Error
http://wikifootprints.org/en/Main_Page  getaddrinfo: No address associated with hostname

  Generated by :no_entry_sign: Danger


Getting blank color on Linux

The get and set methods seem to work normally on windows, but on linux, the get method always returns a blank color.
As far as my understanding of the code goes, you seem to be initializing the BaseBitmap with a pointer to the Data array, so it can be a direct access to the pixels on the Bitmap, and that seems to be causing an issue with the Graphics.DrawImage method, which seems to not be drawing at all on the BaseBitmap when the code is ran on linux.
I'm using Ubuntu 20.04, and verified that If you just call DrawImage on a regular bitmap, it works as expected with no issues, but when creating a FastBitmap object, passing a Bitmap object as argument, the Data array is entirely comprised of zeros. If you use any of the set methods, it works just fine, which leads to DrawImage being the culprit.
I'm not sure if it's possible, but instead of getting the pointer of the Data array, and embedding in the BaseBitmap, do the opposite, get the Data array to point to the BaseBitmap internal data, that could be a solution, and also would remove the need to draw the image parameter on the BaseBitmap. But i'm not knowledgeable enough to know if that's a possibility. But I will try some other possible solutions in the mean time, while I wait for your answer.

I wonder if the pointer on linux isn't being set properly when initiating the BaseBitmap. I have a couple of things that I think will fail if you wanna check them out.

Does setting data using FastBitmap.Set(x, y) to the FastBitmap actually have a change on the BaseBitmap using BaseBitmap.GetPixel(x, y).
Do any of the other Graphics methods work like Graphics.FillRect?

If this assumtion is correct, maybe changing from .NET Standard 2.0 to .NET 5 might help if this issue was found on Microsoft's end.

I've updated the develop branch on my fork, to have more tests, which I believe should represent more accurate regular usage of the library, and at the same time, be easier to test with other instances of the FastBitmap object. I'm not entirely familiar with the usage of xUnit and if there was a better way to do the same.
On linux, the already existing tests, where you filled manually the Data array, all pass successfully. Tests using the Image constructor fail when trying to get the values. And tests using the Image constructor and manually setting each pixel afterwards on the FastBitmap object, all pass, except a new one where it verifies if the values reflect on the BaseBitmap.
Weirdly, some of the Tests using only the Image constructor, also fail on Windows, again, I'm not that used to xUnit, nor the int representation of argb values, but if I'm not mistaken, they are failing due to one returning signed ints, while the other one returns an unsigned representation, or something like that.
I've also verified manually if FillRect is changing anything on the Data array, and it isn't, even while using .NET 5, again, only on linux, on windows it's working correctly.
I was also thinking that it may have been something missing on linux, which may have been causing the issue in the first place, but not only the project where I was using your library, was deployed self contained, which should have all the dependencies on it. But now testing the library inside Rider directly on linux, should've not have any issues with missing dependencies, as far as I'm aware.
And I still haven't managed to think on a possible solution to this issue, that doesn't make it lose by a lot, the performance that it has, when it's working normally.

I discovered that some of the issues with the tests on windows, was due to me setting the coordinates on a wrong order. which corrected all issues with the tests on windows.
The solution was kind of what I mentioned at first, but instead, copying the data from the Image passed on the constructor, to the Data array, directly, while still keeping the original link to BaseBitmap.
All tests passed okay, benchmark showed around 22,000% increase in performance, it worked correctly on my project, so overall, everything seems to be ok now.

I have a Ubuntu 20.04 (LTS) instance working and created a new issue.


playbook is not really remote host compatible - tested with sno part

Hello!
Wanted to use SNO deploy from Fedora 34 machine to RHEL 8.5 host, but it always failed in Terraform part:
TASK [Use TF project to ensure pool and network are defined] **************************************************************************
fatal: [remote.host]: FAILED! => {"changed": false, "msg": "Path for Terraform project 'terraform/libvirt-resources' doesn't exist on this host - check the path and try again please."}
Local invocation works fine.
Used the sources from today.
Also I noticed I had to copy sno_vars.yml to cluster_vars.yml - otherwise my domain from sno_vars.yml was not being used. Instead default hetzner.lab was used.
Here is the whole install log:
[user@machine libvirt-ocp4-provisioner]$ ansible-playbook -i inventory  main-sno.yml
PLAY [This play ensures prerequisites are satisfied before installing] ****************************************************************
TASK [Gathering Facts] ****************************************************************************************************************
ok: [remote.host]
TASK [Check if distribution is supported] *********************************************************************************************
skipping: [remote.host]
TASK [fail] ***************************************************************************************************************************
skipping: [remote.host]
TASK [fail] ***************************************************************************************************************************
skipping: [remote.host]
TASK [Fail fast if bootstrap node doesn't meet minimum requirements] ******************************************************************
skipping: [remote.host]
TASK [Check for pullSecret variable and fail fast] ************************************************************************************
skipping: [remote.host]
PLAY [This play installs needed tools to provision infrastructure VMs] ****************************************************************
TASK [Gathering Facts] ****************************************************************************************************************
ok: [remote.host]
TASK [Install needed packages] ********************************************************************************************************
ok: [remote.host]
TASK [Install needed packages] ********************************************************************************************************
skipping: [remote.host]
TASK [Install needed packages] ********************************************************************************************************
skipping: [remote.host]
TASK [Install needed packages] ********************************************************************************************************
skipping: [remote.host]
TASK [Download and provision Terraform] ***********************************************************************************************
ok: [remote.host]
TASK [Virtualization services are enabled] ********************************************************************************************
ok: [remote.host]
TASK [Use TF project to ensure pool and network are defined] **************************************************************************
fatal: [remote.host]: FAILED! => {"changed": false, "msg": "Path for Terraform project 'terraform/libvirt-resources' doesn't exist on this host - check the path and try again please."}
PLAY RECAP ****************************************************************************************************************************
remote.host           : ok=5    changed=0    unreachable=0    failed=1    skipped=8    rescued=0    ignored=0

Thank you for reporting it. That was added before the provisioner created vms, there are a lot of potential issues (DNS and terraform being only a couple) to really support remote hosts.
Feel free to add your contribution to start implementing this feature in the future :)


DL4J error when running with fat jar

When running extractFromDirectory via an assembled fat jar, I'm getting this error:
18:12:13.419 [main] WARN  o.d.n.m.keras.utils.KerasModelUtils - Could not read keras backend used (no backend field found)

18:12:13.448 [main] WARN  o.d.n.m.k.l.e.KerasEmbedding - Masking in keras and DL4J work differently. We do not completely support mask_zero flag on Embedding layers. Zero Masking for the Embedding layer only works with unidirectional LSTM for now. If you want to have this behaviour for your imported model in DL4J, apply masking as a pre-processing step to your input.See https://deeplearning4j.org/usingrnns#masking for more on this.
Exception in thread "main" java.lang.ExceptionInInitializerError
	at org.deeplearning4j.nn.conf.dropout.Dropout.initializeHelper(Dropout.java:107)
	at org.deeplearning4j.nn.conf.dropout.Dropout.<init>(Dropout.java:100)
	at org.deeplearning4j.nn.conf.dropout.Dropout.<init>(Dropout.java:80)
	at org.deeplearning4j.nn.conf.layers.Layer$Builder.dropOut(Layer.java:257)
	at org.deeplearning4j.nn.modelimport.keras.layers.embeddings.KerasEmbedding.<init>(KerasEmbedding.java:125)
	at org.deeplearning4j.nn.modelimport.keras.utils.KerasLayerUtils.getKerasLayerFromConfig(KerasLayerUtils.java:258)
	at org.deeplearning4j.nn.modelimport.keras.KerasModel.prepareLayers(KerasModel.java:220)
	at org.deeplearning4j.nn.modelimport.keras.KerasModel.<init>(KerasModel.java:166)
	at org.deeplearning4j.nn.modelimport.keras.KerasModel.<init>(KerasModel.java:98)
	at org.deeplearning4j.nn.modelimport.keras.utils.KerasModelBuilder.buildModel(KerasModelBuilder.java:305)
	at org.deeplearning4j.nn.modelimport.keras.KerasModelImport.importKerasModelAndWeights(KerasModelImport.java:127)
	at org.clulab.timenorm.TemporalCharbasedParser.<init>(TemporalCharbasedParser.scala:56)
	at org.clulab.wm.eidos.EidosSystem$LoadableAttributes$.apply(EidosSystem.scala:164)
	at org.clulab.wm.eidos.EidosSystem.<init>(EidosSystem.scala:190)
	at org.clulab.wm.eidos.apps.ExtractFromDirectory$.delayedEndpoint$org$clulab$wm$eidos$apps$ExtractFromDirectory$1(ExtractFromDirectory.scala:13)
	at org.clulab.wm.eidos.apps.ExtractFromDirectory$delayedInit$body.apply(ExtractFromDirectory.scala:9)
	at scala.Function0.apply$mcV$sp(Function0.scala:34)
	at scala.Function0.apply$mcV$sp$(Function0.scala:34)
	at scala.runtime.AbstractFunction0.apply$mcV$sp(AbstractFunction0.scala:12)
	at scala.App.$anonfun$main$1$adapted(App.scala:76)
	at scala.collection.immutable.List.foreach(List.scala:389)
	at scala.App.main(App.scala:76)
	at scala.App.main$(App.scala:74)
	at org.clulab.wm.eidos.apps.ExtractFromDirectory$.main(ExtractFromDirectory.scala:9)
	at org.clulab.wm.eidos.apps.ExtractFromDirectory.main(ExtractFromDirectory.scala)
Caused by: java.lang.RuntimeException: org.nd4j.linalg.factory.Nd4jBackend$NoAvailableBackendException: Please ensure that you have an nd4j backend on your classpath. Please see: http://nd4j.org/getstarted.html
	at org.nd4j.linalg.factory.Nd4j.initContext(Nd4j.java:5449)
	at org.nd4j.linalg.factory.Nd4j.<clinit>(Nd4j.java:213)
	... 25 more
Caused by: org.nd4j.linalg.factory.Nd4jBackend$NoAvailableBackendException: Please ensure that you have an nd4j backend on your classpath. Please see: http://nd4j.org/getstarted.html
	at org.nd4j.linalg.factory.Nd4jBackend.load(Nd4jBackend.java:213)
	at org.nd4j.linalg.factory.Nd4j.initContext(Nd4j.java:5446)
	... 26 more

to reproduce, try
sbt -J-Xmx8G assembly
java -Xmx8G -cp target/scala-2.12/eidos-assembly-0.2.2-SNAPSHOT.jar org.clulab.wm.eidos.apps.ExtractFromDirectory /path/to/input /path/to/output

Also note that useTimeNorm is set to true in eidos.conf. Any ideas what the problem could be? I didn't have this issue a couple of weeks ago when I built the system.

Are you running the jar in the same system you built it?

Yes, using the same system

I also get the error if I do the assembly step rather than run straight from sbt.

@EgoLaparra, I'm hoping that you have some insight into this.  Does grepping for "Masking in keras and DL4J work differently. We do not completely support mask_zero flag on" in the source code help?

I'm afraid that sbt is having problems with some transitive dependency when assembling the fat jar. I'm trying to package eidos as a maven project to check this.

You probably noticed that eidos is using
addSbtPlugin("com.eed3si9n" % "sbt-assembly" % "0.14.6")
while the current version has been updated to 0.14.8.
I did recently change this code in build.sbt:
libraryDependencies ++= {
  val (major, minor) = CrossVersion.partialVersion(scalaVersion.value).get
  val timenorm = "timenorm-<IP_ADDRESS>" + (if (minor == 11) "_2.11.11" else "")

  Seq("com.github.clulab" % "timenorm" % timenorm exclude("org.slf4j", "slf4j-log4j12"))
}

It looks like I should have "if (minor.toInt == 11)".  Are you using Scala 2.11.11, @bgyori?

I have 2.12.4 on my Mac and 2.11.8 on my Debian

So, the jar built with maven works. I will try with sbt-onejar instead of sbt-assembly to check if the plugin is the problem.

Good work, everyone.


New CRD and CSV for v1.0.3

This is the final step to making a new STO release that support the new collectd metrics SmartGateway code.

I've tested this from source, but would like to retest with a full set of upstream builds.

 Produce a new SGO release that includes the new SG and bridge code

 Fix performance problems with NEW SG code

merge in master and CI will run correctly

merge in master and CI will run correctly

@pleimer Silly question, but isn't the point of CI that we test code BEFORE merging it to master?

merge in master and CI will run correctly

@pleimer Silly question, but isn't the point of CI that we test code BEFORE merging it to master?
Well, I had to make updates in ci.yml for it to work, so you could just copy it from master. Then, the workflow would be just what you said

merge in master and CI will run correctly

@pleimer Silly question, but isn't the point of CI that we test code BEFORE merging it to master?

I had to make updates in ci.yml for it to work, so you could just copy it from master. Then, the workflow would be just what you said.
The positive is there is no longer a requirement to log into CRC from the script and is therefore much more future proof

Ah okay, I see. Thanks a bunch!

Fixed scorecard paths and merged w/ master for more convincing CI and scorecard test.
[csibbitt@laptop service-telemetry-operator (csibbitt-944-new-sto-release) (⎈ |sto-scorecard/api-stfsg2-lab-upshift-rdu2-redhat-com:6443/kube:admin)]$ operator-sdk scorecard
INFO[0000] Using config file: /home/csibbitt/cloudops/service-telemetry-operator/.osdk-scorecard.yaml
basic:
        Spec Block Exists                  : pass
        Status Block Exists                : pass
        Writing into CRs has an effect     : pass
olm:
        Spec fields with descriptors       : pass
        Status fields with descriptors     : pass
        Provided APIs have validation      : pass
        Owned CRDs have resources listed   : pass
        CRs have at least 1 example        : pass

@leifmadsen told me to just merge this for now so we can accumulate changes and re-test before it hits master


Add API for accessing SATA SMART attributes thresholds

Adding API to get SATA SMART attributes thresholds since the smartctl allows to get them for SATA devices, but here I didn't find this possibility.

The specification around SATA/ATA is a bit confusing. The best I found is this doc
https://people.freebsd.org/~imp/asiabsdcon2015/works/d2161r5-ATAATAPI_Command_Set_-_3.pdf
Here is what is says about the checksum:
A.14.7 Checksum
The data structure checksum is the two’s complement of the sum of the first 511 bytes in the data structure. Each
byte shall be added with eight-bit unsigned arithmetic and overflow shall be ignored. The sum of all 512 bytes of
the data structure shall be zero.

so the algorithm would be something like
        var ch byte
	for i := 0; i < 512; i++ {
		ch = ch + respBuf[i]
	}
	if ch != 0 {
           return fmt.Errorf("invalid checksum for threshold data")
        }

on your host, since unfortunately I don't have another device with SATA SSD?

It is a good idea try to setup the integration tests shipped with this project. https://github.com/anatol/smart.go/blob/main/integration_test.go
it will require compiling your own kernel binary + userspace image. Here are sample instructions for Arch userspace https://github.com/anatol/vmtest/blob/master/docs/prepare_image.md (but you can use any other distro).


IOrderedSpecificationBuilder throwing InvalidCastException on upgrade from 5.2.0 to 6.0.0

Opened a new issue based on this: https://github.com/ardalis/Specification/issues/53#issuecomment-1040736218
public enum SortOrder { ASC, DESC }

public static IOrderedSpecificationBuilder<T> OrderBy<T>(
        this ISpecificationBuilder<T> specificationBuilder,
        Expression<Func<T, object>> orderExpression,
        SortOrder orderBy)
    {
        ((List<(Expression<Func<T, object>> OrderExpression, OrderTypeEnum OrderType)>)specificationBuilder
                .Specification.OrderExpressions)
            .Add(orderBy == SortOrder.DESC
                ? (orderExpression, OrderTypeEnum.OrderByDescending)
                : (orderExpression, OrderTypeEnum.OrderBy));

        var orderedSpecificationBuilder = new OrderedSpecificationBuilder<T>(specificationBuilder.Specification);
        return orderedSpecificationBuilder;
    }

Unable to cast object of type
'System.Collections.Generic.List`1[Ardalis.Specification.OrderExpressionInfo`1[Entities.Customer]]'
to type 'System.Collections.Generic.List`1[System.ValueTuple`2[System.Linq.Expressions.Expression`1[System.Func`2[Entities.Customer,System.Object]],Ardalis.Specification.OrderTypeEnum]]'.

@mjanofsky were you able to resolve this?

You can find the answer in this issue.

Thanks @fiseni simple fix!


added development script to launch the whole thing

Will add a new script launch-dev in the root that runs the satellite, groundstation, and front-end at the same time. Will also clean-up (i.e. kill the child processes) after it receives a SIGINT

Closes #127

This is an isolated change, will just merge


Consider allowing Punctuated to be indexed with a range

Use case from #rust: checking if the segments[..segments.len() - 1] prefix of a Path is equal to some specific prefix.

I've also hit a use case where I wanted to remove a variant from an enum, but Punctuated<Variant, Comma> doesn't support .remove(idx)

I am not planning to pursue this myself, but if someone else still has this use case, then I would be open to evaluating a PR.


add the ability to load all customizations from a config file.

(the real reason for all the previous commits :smile:). currently on top of #29.

@AntonioMeireles you just rock mate :)
now we are just left with attached storage problem

@AntonioMeireles question about cloud-config, can we just point to some cloud-config to use some local file? as using OS X apache it is not always handy

afaik i needs to be a valid (http) URL (as that is what CoreOS cloud-config machinery expects...). doesn't need to be apple's httpd. any webserver will do. fwiw it crossed my mind before to ship a small golang blob that would just http-serve the cloud-config but that looked to me as way over-engineering.

LGTM taking into account my comments on SSHKEY on #29


Add styles to img in the markdown file.

1. Set the img to have 100% max-width to make sure the image doesn't exceed the phone's screen width.
2. A typo fix in readme.

@mittsuu I am also thinking maybe you don't need to use boostrap for markdown previews because really we only need to style the markdowns. Bootstrap is an overhead for the small markdown files.
One alternative css library which only has minimum ccs code for GitHub markdown is: sindresorhus/github-markdown-css. It is pretty nice for styling GitHub markdown files. I tried that in your code, it works well. So you can have a look and let me know if it works for you, if it works for you, I can send another pull request. 😄

@mittsuu And one more comment. If the img max-width is not set to 100%, the large image's width will oversized the screen's width. To reproduce the problem without this 100% restriction, you can place freecodecamp README in your sample data.

Your fixed are nice.
It merged, thanks.


Unread markers

This PR introduces unread markers with animations whenever the read state changes for a message. Bundled into this PR is also:

Associated integration tests and docs on obtaining performance metrics from a physical device that I used to confirm the performance of the animation being used
A fix for animation state being lost when the number of items in the message list changes. This involved adding a unique key to every message as well as providing a findChildIndexCallback to StickyHeaderListView.builder.

Discussion related to design of this on CZO: https://chat.zulip.org/#narrow/stream/243-mobile-team/topic/flutter.3A.20unread.20marker
Fixes: #79

@gnprice Would appreciate a review of this while design discussions are still ongoing

@gnprice ready for the next round!

Cool, that looks good. Later today I'll plan to review the tests and the integration tests.

After some closer look I think we should do slight modification:

Clarifications
In the dark mode the blue bar is lighter than background and lighter than device screen border:

In the light mode the bar is darker than background, closer to the darkness of device screen border (black)
So the contrast is lower and it is hard to see such bar:

I suggest to put 1 px 60% white on top of such bar in the light mode:

This gives a better distinction for the light mode unread markers:

In the light mode the bar is darker than background, closer to the darkness of device screen border (black) So the contrast is lower and it is hard to see such bar: […]
I suggest to put 1 px 60% white on top of such bar in the light mode:

Great, thanks! That makes sense and I'll be interested to see it.
(We don't yet have dark mode in the Flutter app — that's #95 and is slated for the beta. @sirpengi for this PR, let's leave a TODO(#95) comment saying that extra 1px bar won't be there in dark mode, pointing to @terpimost's comment above. That way it'll be easy for us to see how to handle it when we sweep through for #95.)

Added the 1px 60% white border as specified and updated the screenshow in the top comment as well

@gnprice comments handled, and the design change from @terpimost included too!

@gnprice split off the integration tests bit to #349 as well as dealt with the other comments.

Thanks @sirpengi for the revision, and for all your work on this! Looks good; merging. I'll take a look at #349 next.


fix: allow batchId to be calculated for findUniqueOrThrow in json protocol

Currently batchId is only calculated for findUnqiue and not findUniqueOrThrow when using the json protocol.  The graphql protocol doesn't make this distinction.
There is another bug that prevents findUniqueOrThrow from being batched (see https://github.com/prisma/prisma-engines/pull/4014) but this should prevent a regression once that is resolved.

So, now, when engine PR is merged, I think we are ready to revisit this.
@hayes thanks a lot for both contributions! Could you allow edits from the maintainers on this PR? I'd like to add a couple of functional tests for this.
Alternatively, if you'd like to, you can add them yourself. I'd just copy this test and adjust it to use OrThrow version.

Edit's should be allowed.  I probably won't have time today to add tests, but could add them later this week, but also would love to see this merged, so definitely no need to wait on me

Thanks again for your contribution!
It is now merged in dev and will be available in next prisma release


OCM-3594 | Feat | Add rhRegion flag to rosa login command

Issue : https://issues.redhat.com/browse/OCM-3594
Changed

Add hidden flag rhRegion to rosa login command
Add list rh-region command to list regions
Add unit tests

Tested
This MR tweaks the rosa login --env resolution algorithm to try to reuse cfg.URL before falling back to "api.openshift.com". New --env resolution algorithm (from highest priority to lowest priority):

runtime --env cli arg (key found in URLAliases)
runtime --env cli arg (non-empty string)
[NEW] config file URL value (non-empty string)
sdk.DefaultURL

rosa list rh-region:

show discovery URL used
add optional --discovery-url flag with the same url resolution behavior as ocm login
display region name and its associated url rather than just region name

@tirthct What's the status of this one please? Do you intend to rebase and try to merge?
cheers,
Rob

@tirthct What's the status of this one please? Do you intend to rebase and try to merge?
cheers, Rob

Hey @robpblake, we have a PR under review https://github.com/openshift-online/ocm-cli/pull/599. Since the implementation would be similar here as well, I'll update this draft PR once that is approved/merged.

@tirthct What's the status of this one please? Do you intend to rebase and try to merge?
cheers, Rob

Hey @robpblake, we have a PR under review openshift-online/ocm-cli#599. Since the implementation would be similar here as well, I'll update this draft PR once that is approved/merged.

@robpblake This PR is ready for review

fyi this MR now maintains feature parity with what was recently added to the ocm-cli in https://issues.redhat.com/browse/OCM-3226. If we need to make rosa specific adaptations thats fine, but we'd like to keep the usage and implementation as similar as possible.

/ok-to-test

/retest

https://github.com/openshift/rosa/pull/1655#discussion_r1514389843
I think we don't have the shards file finalized yet, so we probably can. But that would require changes in ocm-sdk and ocm-cli.
Thoughts @macgregor ?

lgtm

/remove-approve

Not sure why approval was removed by @robpblake - hopefully he can let us know when he's back online

Not sure why approval was removed by @robpblake - hopefully he can let us know when he's back online

@hunterkepley I just wanted another member of the team to add their review. My +1 set it to auto-merge, so I removed approval to prevent that.
cheers,
Rob

/lgtm

/approve


VPN error

I'm trying to use ETV through a VPN container and am getting this error:

ts-node -r tsconfig-paths/register index.tsx

=== E+TV v4.1.3 starting ===
Error: listen EADDRINUSE: address already in use <IP_ADDRESS>:8000
at Server.setupListenHandle [as _listen2] (node:net:1817:16)

at listenInCluster (node:net:1865:12)

at doListen (node:net:2014:7)

at processTicksAndRejections (node:internal/process/task_queues:83:21) {

code: 'EADDRINUSE',
errno: -98,
syscall: 'listen',
address: '<IP_ADDRESS>',

port: 8000
}
I'm using Gluetun for the VPN. I have other containers going through the same VPN without issue and have port 8000 open on the VPN.

As a matter of principle I won't support running this with a VPN since bypassing geo-restrictions is the quickest way I'll get a cease & desist warning for this. So unfortunately you're on your own


Improve vim mode.

I'm going to improve the vim mode in a number of ways, including better syntax highlighting. Now is a good time to make any feature requests (beyond #575 and #589).

Sometimes when the error points to a line that needs scrolling, Vim fails to redraw the screen properly... how should I help debug?
Is it possible to make each message foldable?
Could we have some command as fancy as "check theorems and definitions to the current one as if Quit. was inserted after the current block"?
After implementing #589, some way to manually kill it.

I am not sure, but maybe it is cool to highlight the numerals...

Thanks! Regarding (1), @jonsterling has also reported this, although I'm not sure I've run into it myself. I can try adding a redraw and see if it helps.

An alternative to #589: shows that RedPRL has done the checking.

@favonia Is this the behavior you wanted with respect to foldable messages? (Check a RedPRL buffer and then type zM in the messages buffer.)

@cangiuli I was thinking about folding error messages when some are them are very long, but what you did is definitely great!

@favonia Try out :call CheckBufferToCursor(), which checks the buffer only up to the line that the cursor is on. You asked for a similar function but to the end of the "current block," but I'm not sure how to detect that. Do you have any suggestions? Is the current behavior useful?

@favonia I think I can also fold error messages, but I actually don't know how to produce very long error messages in RedPRL! Can you give me a hint about how? :)

I remember it's something of wrong sort of something. You can probably get one by screwing up one of the rewrites in the semi-simplicial types file.


🐞 Bug: [SignIn Page is Not Found]

Is there an existing issue for this?

[X] I have searched the existing issues.

Describe the bug
Issue Description:

The sign-in button on the  is not functioning as expected. When clicked, it does not redirect the user to the sign-in page, or the sign-in page is not accessible via the expected path.
Please investigate and address this issue to ensure proper navigation to the sign-in page.

Steps to Reproduce

go to https://circuitverse.netlify.app/simulatorvue
on this home page there is ** Sign In ** button
click on it. It will show you the page not found

Expected Behavior

when you click on the Sign In button it must show the sign Page
if user not have account then must give option for the registration

Screenshots

Is the faced issue/bug related to the Vue simulator?
Yes
Used Vue simulator with or without backend?
Without Backend
Is the bug present only on the dev server, the build, or both?
Both
Device Information
Os: MacOs
Browser: Safari

Additional Context
No response
Are you working on this issue?
Yes

you have to run the backend on port 3000 first then you will be able to access the sign in page

can i work on this issue


ci: Don't require skip-news if NEWS.rst changes

Until now we've been requiring every PR affect a file in the news/ directory or be labeled with skip-news. Also allow a PR to directly touch NEWS.rst instead.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 92.89%. Comparing base (457365a) to head (03ffe8a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #690      +/-   ##
==========================================
- Coverage   92.91%   92.89%   -0.02%
==========================================
  Files          95       95
  Lines       11475    11475
  Branches     2114     2114
==========================================
- Hits        10662    10660       -2
- Misses        813      815       +2

Flag
Coverage Δ

cpp
92.89% <ø> (-0.02%)
:arrow_down:

python_and_cython
92.89% <ø> (-0.02%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Feature: Add IPv6 dynamic reverse DNS update

A DHCPv4 DDNS option templates out the forward zone as well as the reverse zone (in-addr.arpa) for updating.
The DHCPv6 DDNS option only templates the forward zone, which means that PTR records are not added to DNS.
Feature request: Add the corresponding ip6.arpa reverse zones to the dhcpv6.conf, so IPv6 PTRs are also updated.

timeout due to inactivity


Duplicate foreign key generated after RC1 -> RC2 migration

Two simple models:
public abstract class TicketBatch
{
    [Key, DatabaseGenerated( DatabaseGeneratedOption.Identity )]
    public int Id { get; set; }
    public List<Ticket> Tickets { get; set; }
}

public class Ticket
{
    [Key, DatabaseGenerated( DatabaseGeneratedOption.None )]
    public Guid Guid { get; set; }

    public int TicketBatchId { get; set; }

    public TicketBatch TicketBatch { get; set; }
}

TicketBatch has two descendants that define only value (non-relationship) properties.
After manual migration of the project to 1.0.0-rc2-final, EF Core now wants to apply following in new migration:
migrationBuilder.AddColumn<int>(
            name: "TicketBatchId1",
            table: "Tickets",
            nullable: true);

migrationBuilder.CreateIndex(
            name: "IX_Tickets_TicketBatchId1",
            table: "Tickets",
            column: "TicketBatchId1");

When I explicitly state that the foreign key is TicketBatchId in ApplicationDbContext.OnModelCreating:
builder.Entity<Ticket>()
    .HasOne( t => t.TicketBatch )
    .WithMany( b => b.Tickets )
    .HasForeignKey( t => t.TicketBatchId );

then new column is not added. But that should not be necessary as conventions are followed.
Only similar issue I found is #5344 but I did not dig deeper.
Thanks!

Explicit configuration should not be required. The only reason Migration would generate a different FK because it did not find it in ModelSnapshot file. Can you share ModelSnapshot file from RC1 time if you have. (It gets re-written after adding new migration so the present one might be different).
ModelSnapshot file has changed over the time due to some bug fixes. I am not sure if the file from RC1 would work straight-forward with RC2.
@rowanmiller - Does the same file should work or Migrations/ModelSnapshot should be deleted while upgrading?

I think this is model building, not migrations. It looks like we are introducing a shadow FK for the relationship (TicketBatchId1) rather than using the one that should match by convention (TicketBatchId).
@beho can you share the complete model so that we can work out why it is doing this?

Is there a private channel I could use for handing over model sources ?

@beho feel free to email it thru (just include a reference to the issue #)

I am also having this problem. I migrated from RC1 to RC2, and I see a shadow FK in the generated queries in sql profiler. I have a large data model, but this problems seems to occur only for one of my tables.
I have a data model like this: Todo -|-----< Delegation
Also, if I try to create a new migration with the dotnet ef migrations add command, I get a .AddColumn<int>() trying to add the new shadow FK (TodoId1) to the Delegation table. In addition all the foreign keys are deleted and added again, all the primary keys are deleted and added again (this was a problem in RC1?) and all the tables are renamed (I know that this is supposed to happen when moving to EF Core).

@beho can you confirm that if you delete your RC1 migrations and then regenerate you get the correct thing?

@rowanmiller I didn't get the right thing after deleting RC1 migrations.

@rowanmiller I deleted both migrations and model snapshot but new clean-slate migration still contains both TicketBatchId and TicketBatchId1.

Thanks @beho for the full repro. In case it helps you workaround the issue, the Guid property on TicketBatch is what is triggering the behavior.
Here is a minimal repro:
using Microsoft.EntityFrameworkCore;
using System;
using System.Collections.Generic;
using System.ComponentModel.DataAnnotations;

namespace Repro5406
{
    public class TicketBatch
    {
        [Key]
        public int Id { get; set; }
        // if the Guid property is present a shadow TicketBatchId1 FK is added to Ticket
        // to support the one-to-many relationship
        public Guid Guid { get; set; }
        public List<Ticket> Tickets { get; set; }
    }

    public class Ticket
    {
        [Key]
        public Guid Guid { get; set; }

        public int TicketBatchId { get; set; }

        public TicketBatch TicketBatch { get; set; }
    }

   public class ApplicationDbContext: DbContext
	{

        public DbSet<TicketBatch> Batches { get; set; }

		public DbSet<Ticket> Tickets { get; set; }

        protected override void OnConfiguring(DbContextOptionsBuilder optionsBuilder)
        {
            optionsBuilder.UseSqlServer("Data Source=(localdb)\\mssqllocaldb;Initial Catalog=repro5406:Integrated Security=yes");
        }
    }
}

Assigning this to @smitpatel for investigation.

Issue here is matching properties:
Somewhere in past we decided that if for one-to-one relationship if both the sides have matching properties then it is ambiguity therefore we do not do anything with relationship. This later throws exception as principal/dependent side are not set for one-to-one relationship.
Though currently, this logic is being applied to one-to-many relationship also. For the case of one-to-many relationship, we leave relationship as is. Though this doesn't throw any exception and we end up with a relationship with shadow fk property in final model.
IMO, we should not take matching properties on both side as "ambiguity" for the case of one-to-many relationship since we already know what is principal side. @AndriySvyryd - thoughts?

We agreed this should be fixed in RTM with @smitpatel @bricelam and @ajcvickers.

@divega I'm having the same issue in production.
This is my relation:
modelBuilder.Entity<Consulta>(entity => {
                entity.Property(c => c.ConsultaId)
                    .ValueGeneratedOnAdd();
                entity.HasOne(c => c.Auto)
                .WithMany(a => a.Consultas)
                .OnDelete(Microsoft.EntityFrameworkCore.Metadata.DeleteBehavior.Restrict);
            });

And this is the table I'm getting:

Although, when I perform an insert, the field "AutoId" is filled with the proper FK and "AutoId1" is ignored and is always null.  Am I doing anything wrong or the bug haven't been fixed yet?

@jcmontes95 I am not sure it is exactly the same issue as the original. If this is happening with RTM bits, can you please create a new issue with a full repro?

@divega  Indeed, it is happening with RTM bits. I'll create the new issue with its repro soon.


react-i18next is not working?

Describe the bug
Toolbar shows as follows.

Desktop (please complete the following information):

OS: macOS Ventura 13.2
Browser Chrome 109.0.5414.119 (Official Build) (arm64), Firefox 109.0.1
Version
Node 18.12.1
vite 4.0.0
React 18.2.0

Typescript 4.9.4

I have been informed about this problem previously, it works perfectly fine when you run it in the local environment with storybook, however when it is installed and imported in an external project, it starts to be crushing.
I am very busy with my current projects, but I will try to take a look at it as soon as possible. During this time, I am open for any contributor to send a PR that can resolve this issue.
Thanks!

Version 0.5.0 is now released!
https://www.npmjs.com/package/verbum/v/0.5.0


Feat: intergration LarkSuite PluginTool

Describe what this PR does / why we need it
1.add LarkSuite Plugin to support query doc method.
Does this pull request fix one issue?
#98

Describe how you did it
1.add PluginTool
Describe how to verify it
Special notes for reviews

Please fix the conflict.

Please fix the conflict.

done


Adding  gocyclo to Linter

Signed-off-by: Ken Sipe<EMAIL_ADDRESS>Description of the change:
Add gocyclo to linter and ignoring the 4 violators.  We should limit or bring awareness of additional code that breaches gocyclo rules.
Motivation for the change:
Cleaner, better, stronger code
Checklist
If the pull request includes user-facing changes, extra documentation is required:

[ ] Add a new changelog fragment in changelog/fragments (see changelog/fragments/00-template.yaml)
[ ] Add or update relevant sections of the docs website in website/content/en/docs

@camilamacedo86  checking to see if it is worth adding more checkers.  There are 4 violators to gocyclo.
It may be worth addressing... This PR is to make sure no more code violates this rule without awareness requiring an explicit ignore in that future PR that might.

would there be an intent to fix the methods that currently violate the rule? What N is it set to fail at?

Hi @jberkhahn,

would there be an intent to fix the methods that currently violate the rule? What N is it set to fail at?

I added a comment for each case. See that a few of them will be solved when we are able to apply the changes that we have been planning already.
Regards the rule, by default it will raise the lint issue when a func has more than 20 lines (high complexity) which IMO should is 100%  reasonable since we should avoid this scenario and have the implementations properly encapsulated and with cohesion. All rules might have an exception, however, add the lint will at least ensure that we are very conscious about the new code changes in order to not end up with high complexity functions.

@jberkhahn et. al.
The default gocyclo is 30 without the ignores
./bin/golangci-lint --timeout 5m run
internal/ansible/watches/watches_test.go:105:1: cyclomatic complexity 31 of func `TestLoad` is high (> 30) (gocyclo)
func TestLoad(t *testing.T) {
^
internal/ansible/proxy/requestfactory/requestinfo.go:130:1: cyclomatic complexity 33 of func `(*RequestInfoFactory).NewRequestInfo` is high (> 30) (gocyclo)
func (r *RequestInfoFactory) NewRequestInfo(req *http.Request) (*RequestInfo, error) {
^
internal/ansible/controller/reconcile.go:66:1: cyclomatic complexity 42 of func `(*AnsibleOperatorReconciler).Reconcile` is high (> 30) (gocyclo)
func (r *AnsibleOperatorReconciler) Reconcile(request reconcile.Request) (reconcile.Result, error) {
^
internal/helm/controller/reconcile.go:68:1: cyclomatic complexity 34 of func `(HelmOperatorReconciler).Reconcile` is high (> 30) (gocyclo)
func (r HelmOperatorReconciler) Reconcile(request reconcile.Request) (reconcile.Result, error) {
^

Adding the todos identified in PR above

absolute! happy to help... just for clarity... the score (30) is a score not lines.   It is calc based on the following:
 1 is the base complexity of a function
+1 for each 'if', 'for', 'case', '&&' or '||'

The issue is the number of branch conditions within a function which makes the code harder to reason about...  higher numbers result in higher costs to maintain and increased likelihood to have bugs.
https://github.com/fzipp/gocyclo

@kensipe looks like merging your other PR caused a conflict in this one. Please rebase and I'll re-lgtm.

rebased

@jmrodri rebased and ready


How can I view the "Save" button in the upper toolbar ?

In previous versions of DBeaver (< 4.3.0) the save button

was visible in the upper toolbar. Currently in 4.3.2 version I use the CTRL+S shortcut (or "File/save" from the menu) but the button was usefull. There is a method to show this button in 4.3.2 version?
Thanks.

@roberto2357 Exactly. Save in results viewer toolbar saves only data changes. While pper save saves all editor changes (including data).

We can make a separate "upper" toolbar for basic editor actions. It will be hidden by default but can be enabled in perspective settings.

Yes, it's a good idea :-)
Thanks Serge.

Done.
This toolbar will be visible only for database editors.

Perhaps I'm dense, but I'm unable to enable this under 'Customize Perspective'. I can see it under the 'Edit Actions' toolbar, however attempting to check the box results in an error message "'Edit actions' cannot be made visible because all of its children are in unavailable action sets."


build: remove entryComponents from development apps

Since we're running the development apps with Ivy we no longer need to specify entryComponents.

I've addressed the feedback @devversion @jelbourn.


Virtual Office Hours: August 8 and August 21

vLLM Virtual Open Office Hours
We enjoyed seeing everyone at the previous office hours and got great feedback. These office hours are a virtual bi-weekly live event where you come to learn more about the vLLM project, how to contribute, and get help with your issues - with special topics and guests along the way.
Sign up here: https://neuralmagic.com/community-office-hours/
You can watch previous sessions on the YouTube playlist.
Dates:

August 8, 2024, at 2:00 PM EST (11:00 AM PST), Guest Topic: Multi-Modal Models in vLLM, by Roger Wang from Roblox

August 21, 2024, at 2:00 PM EST (11:00 AM PST), Guest Topic: vLLM on AMD GPUs and Google TPUs, by Woosuk Kwon from UC Berkeley

If there are any themes or topics you would like to see addressed, please comment below. We look forward to seeing you there!
Previous office hour issue: https://github.com/vllm-project/vllm/issues/5937

Hi, I'm highly interested in running vLLM on Google cloud TPU VMs, especially like TPUv4 pod slices like TPUv4-32.
is there any plan this office hour uploaded to youtube? :)

Sorry just saw it know , I had a question about the performance benchmark on TPUs, like what are the best practices does quantization  leads to more throughput.


Can you update your 'zip' dependency to 'rubyzip'?

I would like to use your gem but I am running into a lot of conflicts with the old dependency on 'zip' instead of 'rubyzip'.

Yeah, I'd be happy to make that switch.  It looks like the main difference is that zip supports Ruby 1.9.1 whereas rubyzip requires 1.9.2.  Our requirements for the neo4j.rb gems is 1.9.3 so we should be good there ;)
Let me take a minute and see what's required

Thanks! I would really appreciate it.

Ok, released 0.1.0 of neo4j-rake_tasks and 5.1.4 of neo4j-core (which just updates the version dependency for neo4j-rake_tasks).
Please reopen if that doesn't help!

This was perfect! Seriously thanks for responding so quickly!

Glad to help!


Simplified EC2 setup

Phase 1
Master:

single instance
runs etcd
has an EIP

Nodes:

TBC

Phase 2

easy to obtain kubeconfig file for local use
use EIP in PKI image creation (or consider approach which #112 would enable)

@mikedanese I have some WIP, but let's discuss first.

Also, I'm not intending to go full-on with jsonnet right now, as I mostly find sensible ways around getting things done in HCL... However, I am thinking that it'd make a lot of sense to use jsonnet for remapping cluster config object into Terraform module instantiation.

Is this #115 now?

It's a combination of #114 and #115, but both are WIP, so degrees of separation are to be discussed.


Dmesg reports the many interface description names in very long strings that don't fit in a row, this breaks the nice appearance of the interface list in the assignment menu.
The aestethics is one thing, but the real pain is that the interface list goes off screen by the time the menu asks for the WAN interface name, if there are many interfaces present. It's a real problem to choose from a list which is not visible anymore.
One fix is to maximize the length of the interface description to 48 chars.
The second fix (and also improvement for better overlooking when the list really goes off) is to print a small list of the interface names at each question. This is necessary because when somebody wants to assign the first interface to the last Optional port, the big list will be way off screen by then, and the name of it won't be visible.
This also makes it nice clean and straightforward.
The problem:

The fixes:

That looks good, but It would be good if you remove already selected interfaces from $ifsmalllist. If user choose em3 for WAN, it should not be present as an option for LAN and other ifs

updated patch to fulfill your request, now the list presented to the user only contains interfaces which are not assigned so far.

Instead of discussing non-existent localization (noone updates the gettext template, this won't ever get translated) -- could the installer get fixed (read - made usable)?! This yet again has conflicts now. 10 line fix. Sigh.

Resubmitted with printf() as #1925. Have a nice day.


Update comment for toolforge.org migration

The tool still works on the new domain, by the way, I just updated common.js with a newer language list.

Thanks! 🌟

Thanks for the quick merge and deploy! :)


Support for hostless URLs

I notice you're using full URLs in all examples. Symfony ESI will by default generate hostless URLs when generating the ESI include block:
https://symfony.com/doc/current/http_cache/esi.html
Are these supported?
Example:
<esi:include src="/_fragment?signature=..."/>

Hello @dkarlovi. It doesn't support the relative URLs yet but it could be supported with a check here https://github.com/darkweak/go-esi/blob/master/esi/include.go#L55.
The check could be like
// include.go
var rgStartsWithSlash = regexp.MustCompile("^/[^/].+")

//....

// L.55
if rgStartsWithSlash.MatchString(i.src) {
    // Get infos from req.URL
    i.src = req.URL.Scheme + req.URL.Host + i.src
}

Wouldn't it be faster to just check the first char, without a regex?

Either way, I'll try a PR with this, thanks for the pointers!

No because it could be //domain.com/something that is not valid but possible URL without scheme and we shouldn't prefix with the initial request scheme + host

If leading //, it doesn't need the scheme + host, else if leading / it does, maybe?

https://github.com/darkweak/go-esi/pull/6


Dabbling in the dark artssss..... 🐍

Some safe unsafe optimizations for vach ie writing to uninitialized memory. Also slight changes to the API, removing unnecessary Boxing and using &dyn instead. Also, a new benchmark to test how fast a new archive initializes.

Wait do not accept this PR
There is a bug where the consolidated_example test fails when the multithreaded feature is turned on

Fixed all bugs, the issue now is that doing any changes to the builder requires double editing


Reuse ActionView::TestCase for testing

This shuffles some things around and then replaces all the custom setup for ActionView::TestCase. — this means we can also use routes, helpers and other testing assertions.
Took me a while to figure out how to append to the view_paths 😅, figured it's worth the investment since this would be a more solid testing story — if we're shipping a TestCase to users eventually.

Are we running tests on Travis still? Looks like the CI build isn't showing up here.

Ended up pushing up some basic testing for the t overrides while we're here. Couldn't suss out how to test that the prefix doesn't leak to the next renders.

@kaspth The CI failures here appear to be real. Sorry, I should have set up CI on this repository sooner. I rebased this branch to remove a commit from main that I wanted to undo, which caused some conflicts in lib/nice_partials/helper.rb when rebasing. Maybe take a look there just to make sure I didn't mess anything up. (In retrospect I should have just added a new commit to revert the change... 🤦♂ )


[Fix-13247] [Master] Kill yarn job failed due to NPE exception

closing by #13247

Codecov Report

:exclamation: No coverage uploaded for pull request base (2.0.8-prepare@4515d31). Click here to learn what that means.
The diff coverage is n/a.

@@               Coverage Diff                @@
##             2.0.8-prepare   #13291   +/-   ##
================================================
  Coverage                 ?   20.70%
  Complexity               ?     1601
================================================
  Files                    ?      540
  Lines                    ?    23045
  Branches                 ?     2754
================================================
  Hits                     ?     4772
  Misses                   ?    17780
  Partials                 ?      493

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

Can you review this PR for me? @zhongjiajie @SbloodyS

Can you review this PR for me? @zhongjiajie @SbloodyS

@JinyLeeChina PTAL if you have time


Add CTAN integration

This adds basic support (version and license) for CTAN (TeX/LaTeX) package badges.

@espadrine are you interested in this PR?

@raphink Definitely! I'll try to review all the PRs in the coming days.

(I've now used === in all my PRs)

Splendid work! Thanks a lot!
I'll get around to the other PR tomorrow. Long day.

Great! I'll be looking forward to your reviewing the other PRs!


Drop support for Python 3.3

Python 3.3 has reached end-of-life: https://devguide.python.org/#status-of-python-branches (2017-09-29)

Thanks, @svisser!

Thanks for merging!


Enable x-envoy-external-address header in istio configuration.

Description
For logging proposes, the mothership reconciler needs to have access to the client IP for the API requests. Istio needs to be configured to populate the x-envoy-external-address with the correct value of the client IP.

Reasons

Logging requirements.

Attachments
https://www.envoyproxy.io/docs/envoy/latest/configuration/http/http_conn_man/headers#x-envoy-external-address

i think it become invalid since we are switching to lifecycle manager


feat: expand trace decoder tests

I need next to run locally cdk erigon to generate the input test data, as Cardona endpoint https://rpc.cardona.zkevm-rpc.com/ does not have enabled debug API.


Modifier keys don't override keys that are set by the Minecraft client

The modifier keys do override keys that you set by the mod, but for example, if you have the "C" key set for a mod to open up it's configuration menu by your client, and also have a command macro set to it with this mod with a modifier key, e.g. "Ctrl + C", the client will open the configuration for the mod, but won't run the command macro set by CMDKeybinds. Or, If you assign a command to something like the "W" key, then it will move the player, and run the command set by CMDKeybinds at the same time.
I'm wondering if this could be fixed so it can expand the amount of keys that can be used, regardless of how many mods you have using hotkeys.

I want to bump this issue, because I actually have the same! I'm just going to drop a comment here that I just added to the CurseForge page for the mod:

Firstly, I would like to thank you for this mod. It's a much simpler implementation than the (very) old mod that I was looking for a replacement for, but it does the job it claims to do.

I would like to request a potential feature, or perhaps a bug fix depending on how you look at it. I bind a lot of WorldEdit commands to my keys, and actually override some of my "main" keys. For example, I use [CTRL]+[W] for /ascend, so that I can quickly pop to a higher level without moving my fingers. The [W] key still functions normally as "move forward" when I am not pressing [CTRL] as a modifier, and when I do press [CTRL]+[W] together then the /ascend command executes successfully.

The issue I have is that the normal keybinding for [W] ("move forward") also executes at the same time. It would be wonderful to have an option in the macro menu for "Ignore Default Keybinds". This setting could be enabled on any defined macro, and would prevent the "normal" game keybinds from also firing after a macro is run. This would allow for a macro that is set up as "repeating" to override a normal movement or other common key when using a modifier key, without also causing the player to sprint off into the middle of nowhere.

Thanks again for the effort you put in to this mod!


17.10 artful and cloud-init

Attempted to spin up a container using artful from ubuntu-daily in order to do some testing in regards to netplan/cloud-init.  I noticed that there were no cloud-init files at the usual /var/lib/cloud/seed/nocloud-net, nor was there even a /var/lib/cloud directory.  Where did they go?

Seems fine here.

stgraber@castiana:~$ lxc launch ubuntu-daily:17.10 artful
Creating artful
Starting artful
stgraber@castiana:~$ lxc exec artful bash
root@artful:~# ps fauxww
USER       PID %CPU %MEM    VSZ   RSS TTY      STAT START   TIME COMMAND
root       122  0.0  0.0  21912  2492 ?        Ss   17:54   0:00 bash
root       229  0.0  0.0  42372  2228 ?        R+   17:54   0:00  \_ ps fauxww
root         1  0.0  0.0 154432  5796 ?        Ss   17:54   0:00 /sbin/init
root        52  0.0  0.0  41752  1908 ?        Ss   17:54   0:00 /lib/systemd/systemd-udevd
root        57  0.0  0.0  65120  6252 ?        Ss   17:54   0:00 /lib/systemd/systemd-journald
systemd+   118  0.0  0.0  74476  3368 ?        Ss   17:54   0:00 /lib/systemd/systemd-networkd
root       162  0.0  0.0  31672  1864 ?        Ss   17:54   0:00 /usr/sbin/cron -f
root       163  0.0  0.0  57016  3412 ?        Ss   17:54   0:00 /lib/systemd/systemd-logind
syslog     164  0.0  0.0 187036  2408 ?        Ssl  17:54   0:00 /usr/sbin/rsyslogd -n
root       166  0.0  0.0 287800  4284 ?        Ssl  17:54   0:00 /usr/lib/accountsservice/accounts-daemon
message+   167  0.0  0.0  47452  2428 ?        Ss   17:54   0:00 /usr/bin/dbus-daemon --system --address=systemd: --nofork --nopidfile --systemd-activation
systemd+   170  0.0  0.0  65584  3860 ?        Ss   17:54   0:00 /lib/systemd/systemd-resolved
root       174  0.0  0.0<PHONE_NUMBER>2 ?        Ssl  17:54   0:00 /usr/lib/snapd/snapd
daemon     175  0.0  0.0  28256  1592 ?        Ss   17:54   0:00 /usr/sbin/atd -f
root       176  0.0  0.0 288652  4308 ?        Ssl  17:54   0:00 /usr/lib/policykit-1/polkitd --no-debug
root       202  0.0  0.0  72504  2428 ?        S    17:54   0:00 (agetty)
root       205  0.0  0.0  72148  3660 ?        Ss   17:54   0:00 /usr/sbin/sshd -D
root       219  0.0  0.2<PHONE_NUMBER>0 ?        Rs   17:54   0:00 /usr/bin/python3 /usr/bin/cloud-init modules --mode=final
root       224  0.0  0.0   4608   608 ?        S    17:54   0:00  \_ /bin/sh -c tee -a /var/log/cloud-init-output.log
root       225  0.0  0.0   7876   636 ?        S    17:54   0:00      \_ tee -a /var/log/cloud-init-output.log
root@artful:~# ls -lh /var/lib/cloud/
data/      handlers/  instance/  instances/ scripts/   seed/      sem/
root@artful:~# ls -lh /var/lib/cloud/seed/
total 8.5K
drwxr-xr-x 2 root root 6 Oct 18 17:54 nocloud-net
root@artful:~# lsb_release -a
No LSB modules are available.
Distributor ID:	Ubuntu
Description:	Ubuntu 17.10
Release:	17.10
Codename:	artful
root@artful:~#

You used ubuntu-daily: and not images: right?

correct
lxc init ubuntu-daily:artful test -p default -p test
lxc start test
copy/pasted from cli history
cloud-init was there, but not the directories until I ran cloud-init init
now, went back, did it as a launch per your example, and it was there like yours, copied my history doing init then start, and it's missing again.  Did I miss something there?  Hasn't launch always just been init/start combined?  Always seemed to be that way for me before.

stgraber@castiana:~$ lxc init ubuntu-daily:17.10 artful
Creating artful
stgraber@castiana:~$ lxc start artful
lstgraber@castiana:~$ lxc exec artful bash
root@artful:~# ls -lh /var/lib/cloud/
data/      handlers/  instance/  instances/ scripts/   seed/      sem/
root@artful:~# ls -lh /var/lib/cloud/seed/
total 8.5K
drwxr-xr-x 2 root root 6 Oct 18 18:04 nocloud-net
root@artful:~# ls -lh /var/lib/cloud/seed/nocloud-net/
total 6.0K
-rw-r--r-- 1 root root  58 Oct 18 18:04 meta-data
-rw-r--r-- 1 root root 121 Oct 18 18:04 network-config
-rw-r--r-- 1 root root  18 Oct 18 18:04 user-data
-rw-r--r-- 1 root root  63 Oct 18 18:04 vendor-data
root@artful:~#

Alright, this is very weird.  Noticed the one thing I had different than you, was I was using ubuntu-daily:artful and you had ubuntu-daily:17.10.  And we had different results.  I switched to 17.10 as the name like yours, copy/paste, and of course worked.  Then tested again with init/start, using 17.10, it worked.  Went back to ubuntu-daily:artful, launch and init/start, both now working.    Also, did a lxc image list ubuntu-daily | grep artful.    Did it actually ignore the image server name, and use the previous artful that had been downloaded early today from images:?  Ubuntu-daily has 17.10, but not artful.  images: has artful, but not 17.10.

ubuntu-daily has the same image under various names, you can get the list with "lxc image info ubuntu-images:17.10"

17.10, 17.10/amd64, a, a/amd64, artful, artful/amd64, devel, devel/amd64 all point to the same thing in theory

Definately agreed.  Not sure why that happened.  It really seems as if my attempts prior to using 17.10 in place of artful, was really not wanting to give up the cached image from images.  Maybe I'll clear all the images from the server later today, and try it all over again to see if I can replicate it, if nothing else for my own sanity.  I'm still annoyed today from the whole 17.10 switching to netplan.  I'm sure there's a reason for it, but til find it, it's just new syntax to remembers.  And changing muscle memory for nano /etc/netw/in..  Yes, I love autocomplete.  Though cisco ios still has it beat, as I dont't even have to tab out the command for it to work.

Closing this as there doesn't appear to be an actual LXD issue. You may have had an older image that got returned from cache which had a busted cloud-init, that or cloud-init is randomly breaking somehow.

This issue should likely be reopened, as something is broken in the artful template.
I just created an artful container + many /etc/network files are missing + the /etc/network directory is never touched (using inotifywait at host level), when container spins up, so networking never comes online.
lxc init ubuntu:artful/amd64 net11-ubuntu-artful

Produces an /etc/network with is barely populated.
net11 # find /var/lib/lxd/containers/net11-ubuntu-artful/rootfs/etc/network
/var/lib/lxd/containers/net11-ubuntu-artful/rootfs/etc/network
/var/lib/lxd/containers/net11-ubuntu-artful/rootfs/etc/network/interfaces
/var/lib/lxd/containers/net11-ubuntu-artful/rootfs/etc/network/if-post-down.d
/var/lib/lxd/containers/net11-ubuntu-artful/rootfs/etc/network/if-post-down.d/vlan
/var/lib/lxd/containers/net11-ubuntu-artful/rootfs/etc/network/if-up.d
/var/lib/lxd/containers/net11-ubuntu-artful/rootfs/etc/network/if-up.d/ethtool
/var/lib/lxd/containers/net11-ubuntu-artful/rootfs/etc/network/if-up.d/openssh-server
/var/lib/lxd/containers/net11-ubuntu-artful/rootfs/etc/network/if-up.d/ip
/var/lib/lxd/containers/net11-ubuntu-artful/rootfs/etc/network/if-pre-up.d
/var/lib/lxd/containers/net11-ubuntu-artful/rootfs/etc/network/if-pre-up.d/vlan
/var/lib/lxd/containers/net11-ubuntu-artful/rootfs/etc/network/if-pre-up.d/ethtool

My host config...
net11 # lsb_release -a
No LSB modules are available.
Distributor ID:	Ubuntu
Description:	Ubuntu 17.04
Release:	17.04
Codename:	zesty

net11 # lxd --version
2.18

I've tried running cloud-init init as stated above. /etc/network still not referenced in container start sequence.

Deleted all cached images + regenerated container + same problem persists.

Arg... This does appear to be an artful-ism, because this works...
lxc init ubuntu-daily: net11-ubuntu-daily

/etc/network is populated correctly when using ubuntu-daily as the image.

@davidfavor FYI, in artful, /etc/network and the packages with ifconfig, etc, have been deprecated in favor of netplan and the "ip xxx" commands.  google or yahoo search for "artful netplan" will bring up quite a bit of info.  https://wiki.ubuntu.com/MigratingToNetplan

Thanks.
If you have any idea of how to bring up networking in an Artful container, please post instructions.
Haven't figured it out yet.

@davidfavor if you're using version 1 or version 2 for networking, http://cloudinit.readthedocs.io/en/latest/topics/network-config.html#network-configuration-sources, then it should work just fine.  If you're using ENI, I"m not quite sure, as I haven't tested with it.  Cloud-init should create cat /etc/netplan/50-cloud-init.yaml

I'm going to just open another issue about this, as likely this will trip up many people.
Take a look at the new issue + if post any examples of /etc/netplan .yaml files you have.
Thanks.

If you're using cloud-init, you won't write any /etc/netplan files.  Cloud-init does it for you automatically.  You just have to supply the network-config file as version 1 or version 2 format.  Cloud-init makes the file just like it did for /etc/network.  As for manually writing netplan, there's lots on the internet since it's been in ubuntu since 16.10.

I was googling and came across this discussion. Having a similar issue with 17.10 on a scaleway VPS which I run LXD on. I can create LXD containers at home on my Ubuntu Mate 17.10 desktop, but try as I might I can't on the scaleway server. 16.04 and 17.04 images are fine. I can even push these images. What happen is that a very scarcely populated container gets created with a few processes running (you can get a bash shell) but that is all. I've tried every combination of creating or launching a VPS and trying different variations (amd64 etc) to no avail. Pushing a working 17.10 to the scaleway server doesn't work either. You just get a sparce VPS which can't pull an IP address, and has to be forcibly shutdown. Not a big issue for me as I can continue working with 16.04, just noting for the developers of this excellent project. The scaleway instance is running 16.04 by the way with zfs via a loopback device


Fix build issue when using a Swift 5.8 compiler

We were unable to infer the base of the subscript with a Swift 5.8 compiler.

@swift-ci Please test


1138 - most severe accidents additional info table data

#1138
Table data is ready. Headline is not implemented yet

@ziv17 note that tests didn't passed - please check the Travis tests (pylint didn't pass)


Dependency iteratee failed to resolve after typesafe repo change

if you include reactivemongo in your project now you will get the following error when building
[FAILED     ] com.typesafe.play#play-iteratees_2.11;2.3.5!play-iteratees_2.11.jar:  (0ms)
[warn] ==== local: tried
[warn]   /Users/1110604/.ivy2/local/com.typesafe.play/play-iteratees_2.11/2.3.5/jars/play-iteratees_2.11.jar
[warn] ==== public: tried
[warn]   https://repo1.maven.org/maven2/com/typesafe/play/play-iteratees_2.11/2.3.5/play-iteratees_2.11-2.3.5.jar
[warn] ==== scalaz-bintray: tried
[warn]   http://dl.bintray.com/scalaz/releases/com/typesafe/play/play-iteratees_2.11/2.3.5/play-iteratees_2.11-2.3.5.jar
[warn] ==== typesafe-ivy-release: tried
[warn]   https://repo.typesafe.com/typesafe/ivy-release/com.typesafe.play/play-iteratees_2.11/2.3.5/jars/play-iteratees_2.11.jar
[info] downloading https://repo1.maven.org/maven2/org/reactivemongo/reactivemongo-bson_2.11/0.11.3/reactivemongo-bson_2.11-0.11.3.jar ...
[info] 	[SUCCESSFUL ] org.reactivemongo#reactivemongo-bson_2.11;0.11.3!reactivemongo-bson_2.11.jar (136ms)
[warn] 	::::::::::::::::::::::::::::::::::::::::::::::
[warn] 	::              FAILED DOWNLOADS            ::
[warn] 	:: ^ see resolution messages for details  ^ ::
[warn] 	::::::::::::::::::::::::::::::::::::::::::::::
[warn] 	:: com.typesafe.play#play-iteratees_2.11;2.3.5!play-iteratees_2.11.jar
[warn] 	::::::::::::::::::::::::::::::::::::::::::::::
```

Hi. There is currently an issue with the Typesafe resolver (not specific to ReactiveMongo). Please note that it's better to use the user MailingList for questions. Best regards.


Allow GCSTarget()'s for input and output.

This PR must mirror https://github.com/spotify/luigi/pull/1664 before merging.
For https://github.com/SkyTruth/benthos-pipeline/issues/522
This PR gives our internal branch the same changes that were submitted to https://github.com/spotify/luigi/pull/1664, which allows GCSTarget()'s as input and output for Hadoop jobs.
This is to help get us onto Luigi 2 and Hadoop 2 by way of cleaning up our Hadoop infrastructure first.  The changes in this PR should ultimately mirror what is merged from geowurster:hadoop-gcs so we can get the improvements on our internal Luigi 1 branch.

https://github.com/spotify/luigi/pull/1664 has been merged.

@enriquetuya @pwoods25443 Closing this so it doesn't show up in my https://github.com/pulls page.  Feel free to reopen if needed.


Use timestamp_tz type in microbatch delete DDL

resolves #https://github.com/dbt-labs/dbt-snowflake/issues/1256
docs dbt-labs/docs.getdbt.com/#

Problem

When specifying a timestamp like TIMESTAMP '2024-11-05 00:00:00+00:00', snowflake uses the system timezone, even if the timestamp has offsets. This causes issues in microbatch because the delete DDL statement is leveraging the TIMESTAMP typing, and is deleting the wrong records, potentially causing duplicate rows to be inserted.
Solution

explicitly use to_timestamp_tz when computing incremental predicates for microbatch DDL
update tests to explicitly have timezone_tz input types to UTC (as we recommend for microbatch inputs)

Checklist

[x] I have read the contributing guide and understand what's expected of me
[x] I have run this code in development and it appears to resolve the stated issue
[x] This PR includes tests, or tests are not required/relevant for this PR
[x] This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

New commit https://github.com/dbt-labs/dbt-snowflake/pull/1257/commits/238bae2809283186e37eb7a20c3d76c519d06169 just cleans up some extraneous configuration in test code, that was accidentally left in from development. No functional changes.


Cannot setup with socat

Version of the custom_component
amshan 2021.8.0
HA 2021.8.0
HW (/dev/ttyUSB0): https://www.aliexpress.com/item/32719562958.html?spm=a2g0s.9042311.0.0.c8314c4dpbv1pv
Add your logs here.
GUI configuration:
https://www.jottacloud.com/s/00643aade031e2a4226b56ba0c793a0c52c
Followed by:
2021-08-06 22:17:59 INFO (MainThread) [amshan.meter_connection[] SmartMeterFrameContentProtocol[3]: Smart meter connected to host <IP_ADDRESS> and port 1234

PS: no debug logs even with config:
logger:
  default: info
  logs:
    homeassistant.components.zwave_js: debug
    custom_components.amshan: debug

Describe the bug
Am i using socat wrong?  Ive tried multiple combinations but the component fails to succeed.
root@rpi-zero:~# socat /dev/ttyUSB0,b57600,rawer TCP-LISTEN:1234,reuseaddr
2021/08/06 22:14:00 socat[20415] E write(7, 0x196b2a8, 1): Broken pipe
root@rpi-zero:~# socat /dev/ttyUSB0,b115200,raw TCP-LISTEN:1234,reuseaddr
2021/08/06 22:14:30 socat[20486] E write(7, 0x19562a8, 1): Broken pipe
root@rpi-zero:~# socat -d tcp-listen:1234,fork /dev/ttyUSB0,raw,echo=0,b115200
2021/08/06 22:16:30 socat[20653] E write(6, 0x4842f0, 1): Broken pipe

Ok, so i got the socat done and component setup:
socat /dev/ttyUSB0,raw,echo=0 tcp-listen:8888,reuseaddr

Maybe put up this as an example for easier setup.
systemd example service:
[Unit]
Description=socat amshan usb

[Service]
Type=simple
ExecStart=/usr/bin/socat /dev/ttyUSB0,raw,echo=0 tcp-listen:8888,reuseaddr
Restart=always

[Install]
WantedBy=multi-user.target

I wonder what the purpose is? You can connect the integration selecting serial or TCP.

@toreamun The purpose of using socat is for connecting HA from one server to another raspberry pi with a usb MBUS to my HAN.
Still experiencing socat issues when setting up:
root@rpi-zero:~# /usr/bin/socat -d -d  /dev/ttyUSB0,raw,echo=0 tcp-listen:8888,reuseaddr
2021/08/07 21:22:40 socat[15264] N opening character device "/dev/ttyUSB0" for reading and writing
2021/08/07 21:22:40 socat[15264] N listening on AF=2 <IP_ADDRESS>:8888
2021/08/07 21:22:44 socat[15264] N accepting connection from AF=2 <IP_ADDRESS>:59514 on AF=2 <IP_ADDRESS>:8888
2021/08/07 21:22:44 socat[15264] N starting data transfer loop with FDs [5,5] and [7,7]
2021/08/07 21:22:56 socat[15264] N socket 2 (fd 7) is at EOF
2021/08/07 21:22:57 socat[15264] N exiting with status 0

This is when im hitting "Submit " in HA setup. Do you have another working example with socat?

I use ser2net running on a PI connected to a USB MBUS device to do the same.
Example /etc/ser2net.conf:
3001:raw:600:/dev/ttyUSB0:2400 8DATABITS EVEN 1STOPBIT
Then connect to your PI on port 3001 (in this example) directly from the Home Assistant integration setup.

Tried ser2net without luck;
2021-08-07 22:15:45 INFO (MainThread) [amshan.meter_connection] SmartMeterFrameContentProtocol[0]: Smart meter connected to host <IP_ADDRESS> and port 3001

Nothing more with debug logging fails on setup with the "unknown error occured" in HA gui.

I think ser2net close the connection immediately after connect if you are already connected to the port (like your telnet test). You may want to try to restart ser2net to reset any connections. The generic error message you got is used for all cases not specifically handled. More TCP/IP connection issues should have been handled...
Look for more log messages following the connect message.


refactor of json tag

Codecov Report

Merging #233 (ca8eddc) into v2.2.0 (19fb44b) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           v2.2.0     #233   +/-   ##
=======================================
  Coverage   66.11%   66.11%
=======================================
  Files          71       71
  Lines        5374     5374
=======================================
  Hits         3553     3553
  Misses       1334     1334
  Partials      487      487

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 19fb44b...43bc543. Read the comment docs.

Codecov Report

Merging #233 (ca8eddc) into v2.2.0 (19fb44b) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           v2.2.0     #233   +/-   ##
=======================================
  Coverage   66.11%   66.11%
=======================================
  Files          71       71
  Lines        5374     5374
=======================================
  Hits         3553     3553
  Misses       1334     1334
  Partials      487      487

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 19fb44b...43bc543. Read the comment docs.


Remove errant parentheses on README

Looks like a duplicate trailing parentheses on the markdown format for Ryan Murphy's link. This shows through on the page once rendered after Ryan's name; I would imagine that Ryan is anything but parenthetical.

Thanks!


Check that the GitHub standards report is actually working

Background

We have a report that provided information of GitHub standards compliance. However we don't really understand the numbers and want to check that the report is working.
Approach

Check report is working as expected
Acceptance Criteria

[ ] We know the report is working or have identified issues to fix.

Reference
How to write good user stories

Misc figures
Total public repos: 1504
Total public archived repos: 441
Total public forked repos: 127
Getting to the number we have on our report
Total public repos omiting all non-source (forks etc), locked & archive repos: 994
So to summarise, edge cases from the number on GitHub.com are as follows:

Archived repos are not included
Forked repos are not included
Locked repos are not included
Disabled repos are not included
Template repos are included (edited)


publish esphome+ardiuno to platform.io

Publishes the code to platform.io
Note to maintainers:
Before merging this you'll need to:create an environment named platformio_publish
and create a secret within that environment PLATFORMIO_TOKEN secret in github
the contents of that secret you can get from:
pio account register # if you don't already have an account
# verify the email
pio account login
pio account token

After this being merged, I'll update the yaml to reflect pulling in the library from the platform.io registry, and I'll also unpublish where its currently being published to:

https://registry.platformio.org/libraries/chrisns/LoctekMotion_IoT_esphome
https://registry.platformio.org/libraries/chrisns/LoctekMotion_IoT_arduino

would also be good to publish the raspi to pypi which I'd be happy to work on too if you like

Sorry for the late reply, to understand, what would be the benefit of this change?

Sorry for the late reply, to understand, what would be the benefit of this change?

Hey, no worries
Just allows for easier inclusion in config to refer to your c without having to copy and store it locally


streaming audio only

can anyone help me please to guide me how to separate audio and video streaming so i can stream audio only...

Hi alex4well,
Did you get any solution to stream audio only? Thanks

Hi everyone,
Thank you for your interest. This library is open to development. You can develop your own solution. If you have something to ask, you can mail with us. Mail address is here >><EMAIL_ADDRESS>

Closing this issue for the inactivity. Please feel free to re-open  if you are still interested in this issue.

i m still not finding a solution


Add default normalization rule

This is for #131, it adds the default normalization rule to add missing fields in the document. Few examples:
>>> schema = {'amount': {'type': 'integer'}, 'kind': {'type': 'string', 'default': 'purchase'}}
>>> v.validated({'amount': 1}, schema)
{'amount': 1, 'kind': 'purchase'}
>>> v.validated({'amount': 1, 'kind': 'other'}, schema)
{'amount': 1, 'kind': 'other'}
>>> v.validated({'amount': 1, 'kind': None}, schema)
{'amount': 1, 'kind': None}
>>> schema = {'thing': {'type': 'dict', 'schema': {'kind': {'type': 'string', 'default': 'purchase'}}
>>> v.validated({'thing': {}}, schema)
{'thing': {'kind': 'purchase'}}

Concerns and thoughts

If nullable is False, value is None and default is present, should we override the field with default or throw a validation error?
If default is a callable, should we run the callable and set the callable result? Do we need another option like default_is_callable that when is True we call the default value if is a callable and when is False we don't call anything? We also can always call the default value if is callable and if the user really want to set a function definition as a default value for the document, she could wrap it with a lambda function or something like that.

cool. cool. cool.
please also extend the documentation. your examples above a fine to be added as .. doctest::. maybe except the last.

If nullable is False, value is None and default is present, should we override the field with default or throw a validation error?

i tend to overriding a None. since nullable can still prevent it, it seems safe to me.

If default is a callable, should we run the callable and set the callable result?

what would be a usecase for that?
i can think of it like a method of a custom validator (thus with context access)? (like #102)

If nullable is False, value is None and default is present, should we override the field with default or throw a validation error?

I'd say that in this case the user explicitly wants a None for the field, so a validation error would probably be more appropriate (let the user know that's not allowed). If we replace it with a default value it might seem it has been accepted while it has not (I'm thinking Eve use case for example, where a client sends a payload to the remote REST API and gets it accepted - I'd probably want to know that None is not allowed).

If default is a callable, should we run the callable and set the callable result?

I'm unsure about this. As @funkyfuture says, there are other ways to achieve the same result already. I probably prefer a static default value.

If default is a callable, should we run the callable and set the callable result?

what would be a usecase for that?

I was particularly thinking in something like:
{'a_datetime': {'default': utcnow}}

Then if a_datetime is not present in the document, you set the utcnow result, not the callable.
But yeah, this over-complicate the feature and makes it more unintuitive. I really don't understand which other way you have to accomplish this, can you give an example?

Updates: added documentation and assertNormalizedEqual method.

Very nice. However this does not seem to work with lists of dictionaries.
schema = {
    'mylist': {
        'type': 'list',
        'schema': {
            'type': 'dict',
            'schema': {
                'customer': {'type': 'boolean', 'default': False},
                'name': {'type': 'string'}
            }
       }
    }
}

Blocks with: SchemaError: unknown rule 'customer' for field 'customer'

Then if a_datetime is not present in the document, you set the utcnow result, not the callable.

But yeah, this over-complicate the feature and makes it more unintuitive. I really don't understand which other way you have to accomplish this, can you give an example?

i don't think this is over-complicated. and i think that's an interesting use-case, so this may come up at some point anyway.
there is no other way to accomplish that now. i didn't mean that there exists one, but that it should be done like custom validation methods. that i could imagine yesterday as use-case, as it would allow context-sensitive defaults.

If we replace it with a default value it might seem it has been accepted while it has not ... I'd probably want to know that None is not allowed

what about the following:
field value is None, nullable=True -> default is ignored
field value is None, nullable=False -> field value is set to default value, an 'error' is emitted
in conjunction with an ability to ignore specific errors that'd allow flexible usage.

However this does not seem to work with lists of dictionaries.

i think that may be #168.

Let's do it this way:

field value is None, nullable=True -> default is ignored
field value is None, nullable=False -> an 'error' is emitted

For the record, I have a default implementation in Eve and I am looking forward to replace that one with this native Cerberus implementation.

@nicolaiarocci and Eve's default wouldn't touch a None, so my proposal would break it?
@dnohales concerning the non-static defaults: that could be achieved if coercing happened after setting defaults; so default would ensure that a field is present in a document and could be altered dynamically with a custom coerce method.
i'm curious about this question: are dynamic defaults still in the realm of normalization or is it generation of data? and thus, does it belong into a library with a focus on validation?

Errors should be show stoppers in my opinion. Especially so when reported by a validation tool. Furthermore, nullable = False is a very explicit and clear rule.
In Eve when Nullable=False we return an error and don't process the payload. If Nullable=True we accept the null. In both cases we ignore the default rule, which only kicks in when field is missing.

So, I updated the code. Let me know if you agree with the changes (specially the latest commit), since I see some discrepancies about the compatibility with Eve.

But yeah, I agree with @nicolaiarocci regarding the nullable matter.

Thanks!


Minor font deprecation warning

Got deprecation warnings on gosu version 0.14.5  relating to the font draw method.
DEPRECATION WARNING: draw is deprecated; use Font#draw_text or Font#draw_markup instead.
draw called from text_input.rb:76:in `draw'.

Oh right. Thanks 🙏


I found irreversible signal was trigger twice when replay !!!

I found that two places triggered the irreversible signal.
forkdatabase.cpp  fork_database::prune( const block_state_ptr& h )
auto itr = my->index.find( h->id );
if( itr != my->index.end() ) {
 irreversible(*itr);
 ilog("${bn} ${block}",("bn",h->block_num)("block",h->dpos_irreversible_blocknum));
 my->index.erase(itr);
}

controller.cpp  replay_push_block( const signed_block_ptr& b, controller::block_status s )
// on replay irreversible is not emitted by fork database, so emit it explicitly here
if( s == controller::block_status::irreversible ){
	emit( self.irreversible_block, new_header_state );
        ilog("${bn} ${block}",("bn",new_header_state->block_num)("block",new_header_state->dpos_irreversible_blocknum));
}

history_plugin.cpp
my->irreversible_block_connection.emplace(
	chain.irreversible_block.connect( [&]( const chain::block_state_ptr& bs ) {
	  ilog("${result}",("result",bs->block_num));
	} ));

so I add ilog to print.
In versione 1.6.0
I found that they all print log and history_plugin was print twice. so this comment will wrong, it will emit by fork database on replay.
In version 1.2.0
two place was all print log, but history_plugin was print once.  irreversible(*itr); was exec , but it doesn't work.

Thanks for the report. Verified signal called multiple times:
info  2019-02-21T13:50:55.009 thread-0  history_plugin.cpp:364        operator()           ] block 600, 000002582a96d0d231f383a7f6bb13586c989cb24e407d58de8a8ba777bb4b7f
info  2019-02-21T13:50:55.009 thread-0  history_plugin.cpp:364        operator()           ] block 602, 0000025af641e7df4c0c43d17d487e378f7f9235a52eee579c23214a70af284b
info  2019-02-21T13:50:55.009 thread-0  history_plugin.cpp:364        operator()           ] block 601, 00000259c8cb6b4307850f8f2a9553693d1775172e55296c5005e96dd5d8d0d3
info  2019-02-21T13:50:55.009 thread-0  history_plugin.cpp:364        operator()           ] block 603, 0000025b6dda0e6c3e7773a6314186b47f79d9ddc52e23c5dc9be418492439db
info  2019-02-21T13:50:55.009 thread-0  history_plugin.cpp:364        operator()           ] block 602, 0000025af641e7df4c0c43d17d487e378f7f9235a52eee579c23214a70af284b
info  2019-02-21T13:50:55.009 thread-0  history_plugin.cpp:364        operator()           ] block 604, 0000025c0d9f50b46a828cd18f1c20df843c933c986180f233b2de1f5a257805
info  2019-02-21T13:50:55.009 thread-0  history_plugin.cpp:364        operator()           ] block 603, 0000025b6dda0e6c3e7773a6314186b47f79d9ddc52e23c5dc9be418492439db
info  2019-02-21T13:50:55.009 thread-0  history_plugin.cpp:364        operator()           ] block 605, 0000025dcb4af3ba073ab957b5a9b95d6f3fd25ca114e9f98867e24af06b2f69
info  2019-02-21T13:50:55.009 thread-0  history_plugin.cpp:364        operator()           ] block 604, 0000025c0d9f50b46a828cd18f1c20df843c933c986180f233b2de1f5a257805
info  2019-02-21T13:50:55.010 thread-0  history_plugin.cpp:364        operator()           ] block 606, 0000025ef62135923ef59ba7c6833c09a051311e22f012f40d2000a368b047cd
info  2019-02-21T13:50:55.010 thread-0  history_plugin.cpp:364        operator()           ] block 605, 0000025dcb4af3ba073ab957b5a9b95d6f3fd25ca114e9f98867e24af06b2f69

PR #6624 has fixed this issue.

fyi, as tested, v1.7 do not solve issue

#6624 has not yet been merged to a release track branch.  It is not in v1.7.0-rc1.

Fixed in 1.8.


chore(deps): upgrade dev dependencies

Upgrades project dependencies. See details in workflow run.

Automatically created by projen via the "upgrade-dev-dependencies-k8s-28-main" workflow

⚪ Backport skipped
The pull request was not backported as there were no branches to backport to. If this is a mistake, please apply the desired version labels or run the backport tool manually.
Manual backport
To create the backport manually run:
backport --pr 4592

Questions ?
Please refer to the Backport tool documentation


janet: 1.16.1 -> 1.18.0

Motivation for this change
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[x] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Came across this when looking for Janet in Nixpkgs since I feel like doing some Advent of Code in it. Is there something mixed up in this PR? It only removes some maintainers and has nothing to do with Janet.

@cideM I originally intended to update Janet in Nixpkgs, but over time other obligations have not allowed me to work on this stuff. So I wanted to remove my name from maintainers but looks like I used wrong branch to push. I'll close this PR and open a new one for maintenaler removal.
Please feel free to take over Janet package maintenance in Nixpkgs if you can. Apologies for confusion.


[SPARK-50702][PYTHON] Refine the docstring of regexp_count, regexp_extract and regexp_extract_all

What changes were proposed in this pull request?
Refine the docstring for regexp_count, regexp_extract and regexp_extract_all.
Why are the changes needed?
to improve docs and test coverage
Does this PR introduce any user-facing change?
doc-only changes
How was this patch tested?
new doctests
Was this patch authored or co-authored using generative AI tooling?
no

cc @zhengruifeng


Allow the version of an artifact to be a variable

The following changes are introduced:

If a package is not found in one repo (status 404) try the next repo in config
Repos config name changed to .jip_config
If the version of an Artifact is a variable ${version} check the properties tag in the pom for the proper version

Thanks for the patch. But according to our travis CI, this change will break jip on 2.6 platform. I still hope we can support 2.6 if it's possible.

I changed some old % string formatting to .format, it's clearer to me. I just returned to the old formatting.

Thanks for the patch!

Thank you