merge package from arlac77/npm-package-template

package.json

chore(package<EMAIL_ADDRESS>chore(scripts): cover@#overwrite c8 --temp-directory build/coverage ava && c8 report -r lcov --temp-directory build/coverage
chore(package): add xo from template
chore(package): add nyc from template
chore(package): set $.ava.require='esm' as in template
chore(package): set $.ava.files='tests/-test.js,tests/-test.mjs' as in template
chore(package): set $.ava.extensions='js,mjs' as in template

Coverage remained the same at 97.619% when pulling a1841f078b902cd4856ef69b7f3bba1841dc3664 on template-sync-1 into 3c423030f7d9d705dcdda19905154e011511c3f4 on master.

Codecov Report

Merging #435 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           master   #435   +/-   ##
=====================================
  Coverage     100%   100%
=====================================
  Files           1      1
  Lines          29     29
=====================================
  Hits           29     29

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c42303...a1841f0. Read the comment docs.


Browser friendly lightweight distribution

Hello and thank you for a great product!
We use LightStep heavily on the server side of things in our node apps and would like to also enable tracing on the browser side to have the full stack covered. Is there an effort planned for making the browser builds lightweight, lazy loadable and friendly to the modern packaging tools to enable tree shaking?

Thanks for your comment. Is your question suggesting a change to what we already have in our https://github.com/lightstep/lightstep-tracer-javascript/tree/master/dist folder?
Doesn't directly answer your question: but I'd like to just point out some interesting work that's going on in OpenTelemetry project related to javascript tracing https://github.com/open-telemetry/opentelemetry-js
Feel free to jump on over there and have a look and bring your ideas to that community because Lightstep is also participating in that community to build cool new features!

Hi Andrew,
Thanks for a very quick response!

Thanks for your comment. Is your question suggesting a change to what we already have in our https://github.com/lightstep/lightstep-tracer-javascript/tree/master/dist folder?

Yes. The minimised bundle is 461 KB which is the reason for this issue :)

Doesn't directly answer your question: but I'd like to just point out some interesting work that's going on in OpenTelemetry project related to javascript tracing https://github.com/open-telemetry/opentelemetry-js

We are looking for a stable LightStep compatible tracer which is ready to be shipped to a busy website asap.

@peter-leonov no active plans to reduce the bundle size beyond what it is already with the strategies you have proposed initially in the description, but since this is open source you have possibilities available to you to create your own bundle (but not even sure if it can be minimized smaller).


Revert "Remove Redirect Causing Invalid URIs for Swagger UIs Server on / (#1043)"

This reverts commit a985d8c1340f80ab69b2b0e5de799df98d567732.

Closing based on https://github.com/juhaku/utoipa/pull/1155


Error: No such module: atom_browser_v8_util

VSCode Version: Code 1.6.1 (9e4e44c19e393803e2b05fe2323cf4ed7e36880e, 2016-10-13T16:21:53.542Z)
OS Version: Windows_NT ia32 6.1.7601
Extensions: no

exception:
stack: "Error: No such module: atom_browser_v8_util\n    at Error (native)\n    at process.atomBinding (d:\sample\node_modules\electron\dist\resources\electron.asar\common\init.js:5:20)\n    at Object. (d:\sample\node_modules\electron\dist\resources\electron.asar\browser\api\browser-window.js:6:24)\n    at Module._compile (module.js:556:32)\n    at Object.Module._extensions..js (module.js:565:10)\n    at Module.load (module.js:473:32)\n    at tryModuleLoad (module.js:432:12)\n    at Function.Module._load (module.js:424:3)\n    at Module.require (module.js:483:17)\n    at require (internal/module.js:20:19)"
.vscode.zip
package.zip
Steps to Reproduce:
1.open the folder
2. run or debug

Could you upgrade to the latest stable version 1.7.2 and see if the problem persists?

I have upgraded to 1.7.2, but the problem remains.
To my surprise, when I just changed the folder name from 'd:/sample' to 'd:/sample1', no exception thrown and everything seems well working. I tried times, and the folder name changing did trigger the exception exactly.
BTW, my Electron version is 1.4.3 and Node 4.6.1.

@zhiguan-hanks maybe a broken installation? can you uninstall and reinstall completely? also could you try to run from this zip folder to see if it changes something: https://az764295.vo.msecnd.net/stable/7ba55c5860b152d999dda59393ca3ebeb1b5c85f/VSCode-win32-1.7.2.zip

@bpasero I have tried to run from the zip you left, but it changed nothing.:-)

Hi @zhiguan-hanks, I also had this problem. I'm using VSCode 1.8.1 and it still happens. However, if I disable the check boxes All Exceptions and Uncaught Exceptions under Debug > Breakpoints, I can debug my application without problems.

Please report back if this still reproduces with our upcoming 1.9 release.


feat: lower default delete retention policies

Lower default delete retention policies to values set by default by Azure. Can be set to a higher value by using the relevant variables. Will save some cost by default.
Just a suggestion that I wanted to throw out for discussion 🙂

saving cost is usually a good thing 👍🏽 and its nice that we can still change the value to a higher number, i am all for it 👍🏽 ( waiting for other comments before approval, this way we can keep the discussion going)


Lazyload not working in app webview

In browser, it works, image begins loading when scrolled to , but in app(ios), the images all loaded  when web finished loading, without any scrolling.

It's app's problem, not lazyload.


Quiz Performance and Usability Improvements

Checklist

[x] I tested all changes and all related features with different users (student, tutor, instructor, admin) on the test server https://artemistest.ase.in.tum.de.

Motivation and Context
We had performance issues with quizzes due to many reloads and a full inbound WS queue due to slow communication in the outbound WS queue.
Description
We investigated the issues in more detail and significantly improved the performance of the quiz submission from a few milliseconds (sometimes hundreds of milliseconds) to a few microseconds. So without taking the time of the JSON serialization / deserialization into account, quiz submissions should be 1000x faster than previously 🥇
We changed the following:

[X] We removed the confirmation (outbound) WS message for quiz submissions to lower the stress of the outbound WS queue and make the submissions faster. This means automatic quiz submissions (i.e. when users change their answers in the quiz) are not confirmed any more. In case the client is connected via WS, we assume that saving worked correctly without problems. In case the client is disconnected via WS, automatic saving fails which is displayed. This change might slightly decrease the reliability of the automatic save mechanism.
[X] To deal better with cases, where the inbound WS queue is not empty, we now use a REST call, when the user clicks on Submit.
[X] We increased the grace period for quizzes, in case of delayed messages to the server, more quiz submissions will be counted
[X] We improved the caching of exercises to reduce the database impact in quiz submissions
[X] We use saveAll instead of a for loop and save to improve the database write performance when users have submitted their quiz answers
[X] We added a refresh button for visible quizzes without start date (that have not yet started). In case the quiz starts while the user is disconnected, the user can press the refresh button and does not have to reload the page
[X] We increased the font size for the Disconnect warning
[X] When a quiz is visible, but not yet started in the quiz participation page, it can happen that the client is disconnected from the server. In case the client is connected again, it should automatically refresh the page so that students don't miss the quiz in such cases
[X] Improve error handling when quiz submit does work. Currently, a generic message is shown in the client, this should be improved though

Additional code improvements:

[X] Fix the REST route for re-evaluate

Steps for Testing

Participate in live quizzes in different ways:

Start the quiz manually (instructor) while it is open (student) --> it should start automatically
1a) Do the same while being offline (student), go back online, the quiz should start automatically when you have reconnected
Start the quiz manually (instructor) while you are in the exercise list of the course (student) --> if you navigate into the quiz, it should start
Configure a quiz to start automatically (instructor) --> navigate in the quiz as student (it should start at the start time of the quiz)
3a) Do the same while being offline (student), go back online, the quiz should start automatically when you have reconnected

Try out different scenarios for disconnects:

Disconnect before the quiz starts and reconnect after quiz start
Disconnect during the quiz (keep changing answers) and reconnect before the quiz ends (the last version should be saved automatically then)
Disconnect during the quiz (keep changing answers) and reconnect after the quiz ends.
==> Check that the messages shown to the user make sense and include useful information.

Check other edge cases and inspect the network traffic so that no information is processed that the student should not see (e.g. answers to quiz questions before the quiz ends and quiz questions before the quiz starts)

Start the quiz manually (instructor) while it is open (student) --> it should start automatically
Works
1a) Do the same while being offline (student), go back online, the quiz should start automatically when you have reconnected
Did not work for me
Start the quiz manually (instructor) while you are in the exercise list of the course (student) --> if you navigate into the quiz, it should start
works
Configure a quiz to start automatically (instructor) --> navigate in the quiz as student (it should start at the start time of the quiz)
works
3a) Do the same while being offline (student), go back online, the quiz should start automatically when you have reconnected
Did not work for me
Further Notes: Resetting a quiz does not automatically update the view of the student. I do not know if this is intended behaviour

When specifying a start date for the Quiz exercise, the icon and the open button are missing in the student's view:

in contrast to:

Issues that occured when testing:

when I start the quiz connected, and change/ or don't change my answers during being disconnected and then reconnect after the quiz has ended I get the message "The quiz has ended and you have not participated" even though I answered before I disconnected. To see my results, I have to manually reload the page then.

when starting connected  and changing my answers during disconnection and then reconnect again before the quiz ends

the status of Connected (unsaved changes) is shown after reconnecting even though my changes have been updated in my result
When the quiz ends, I get the message "You have not participated in this Quiz" for a few seconds, before the page automatically displays my actual results

Further remarks:

the status of connected/disconnected takes quite some time to show the correct connection status

I found some issues.

When you create a quiz and set the status "visible" and the students are in the exercise list view, they don't receive and update without clicking the refresh button. However when a quiz is created with the status "hidden" and then the instructor clicks "set visible" the students receive an update without the need to click the refresh button.
When the student is on the exercise list view and the instructor starts a quiz a lot of error messages occur in the developer console
I tested this with two sessions on one PC(one in the normal browser and one in the private window) and with two PCs

When a student participates in a quiz he always receives "The quiz has ended and you have not participated. There are not results to display".

I received this message in the following scenarios:

normal participation without disconnect
participation with disconnect, but reconnect before the end of the quiz
participation with disconnect and reconnect after the end of the quiz
start the quiz and don't participate (which should be the only case were this message should occur)

Thanks for testing. I fixed the typescript bug (@F4lka Number 2). Now the message at the end of the quiz should also be correct (@F4lka Number 3).
I could not reproduce @F4lka Number 1.
@tessaRuckstuhl @Alexanderkrp could you please double check if your issues are resolved as well?
Regarding the slow change of the connection status. I guess this is browser specific. Chrome tends to react a bit slower than Safari. We cannot really change this behavior.
@stefanwaldhauser I did not have time to look into the 2 cases 1a and 3a that did not work for you.  Can you please double check if they still do not work?

I retested it again and it looks good to me. Great job
My issue number one:

Quiz creation, status: hidden, then click set visible => the exercise list of the student is updated

Quiz creation, status: visible => the exercise list of the student is not updated, only after clicking the refresh button

I retested it again and it looks good to me. Great job
My issue number one:

Quiz creation, status: hidden, then click set visible => the exercise list of the student is updated

Quiz creation, status: visible => the exercise list of the student is not updated, only after clicking the refresh button the exercise list will be updated and show the new quiz

Ok, (1) when the quiz is set to visible while editing it, this works. (2) When the quiz is set to visible during the creation, it does not work.
Case (1) is more important than case (2), but we can still fix this. Thanks

@F4lka this should be fixed in my latest commit. Please test again.
@stefanwaldhauser can you test again the offline behavior?

@stefanwaldhauser can you test again the offline behavior?

Sadly the offline behaviour does not work on my end.

@stefanwaldhauser I guess we are talking about a different offline behavior. I meant when the quiz is already visible (case 1: start time planned, case 2: click on start now) and the student has already opens the quiz participation page where Artemis promises to start the Quiz automatically:
then if you get disconnected and the quiz starts, the page should automatically reload when you reconnect so that the quiz starts automatically for the student.

First Issue: The correct message is shown now. I still have to reload the page manually to see my results though!
Second issue: This one's resolved, the correct message is shown now! 👍

First Issue: The correct message is shown now. I still have to reload the page manually to see my results though!
Second issue: This one's resolved, the correct message is shown now! 👍

I am not sure which case you exactly refer to. Could you add a screenshot or screencast. How long do you wait? It can take 5-20s until the page reloads automatically

I retested the functionality and all the issues i found are now fixed

Answering the quiz while being connected.

Then, disconnecting during the quiz.

Still disconnected, even after quiz has ended.

Reconnecting after quiz ended

No change, no results are shown (even after several of minutes)

@tessaRuckstuhl thanks for the details. Good find. This case is not yet supported, I’ll see if I can cover it easily

I tried reproducing the behaviour described by @tessaRuckstuhl, but I got a popup stating that the results could not be loaded:

I tried reproducing the behaviour described by @tessaRuckstuhl, but I got a popup stating that the results could not be loaded:

I actually got that too! If you simply click on Ok and wait anyways, the behaviour above should occur.

@sleiss seems your disconnect happened one second too late 😂

@krusche Nah, it just took some time until it recognized that the connection is gone :D
@tessaRuckstuhl If you also got that popup, I believe this is not that really high priority to fix now, as at least the student got informed that something went wrong

@krusche
While testing the option that the quiz is started manually by an instructor I got the following bug in some rare cases: When started I received the message that it started **now** , only on refreshing the page I was able to see the quiz.
@sleiss  can provide further detail on the bug from the view of an instrcutor.
We are not able to reproduce it reliably.

This is the view from the instructor (see that the start-time column changed, but the button did not disappear). As I hit the button, the view of the students got changed to the one @filip-gregurevic mentioned:

This is the view from the instructor (see that the start-time column changed, but the button did not disappear). As I hit the button, the view of the students got changed to the one @filip-gregurevic mentioned:

I also checked the console, there are no errors in the client.

Facing the same issue. A manual refresh is needed to see the updated status of the live quiz. Also, if we set the quiz to start automatically, the Instructor needs to manaully refresh the page to see the updated status of the quiz (from Not Released to 'Active') and again at the end of the quiz (from 'Active' to 'Closed'

I noticed the same issue.

@stefanwaldhauser I guess we are talking about a different offline behavior. I meant when the quiz is already visible (case 1: start time planned, case 2: click on start now) and the student has already opens the quiz participation page where Artemis promises to start the Quiz automatically:
then if you get disconnected and the quiz starts, the page should automatically reload when you reconnect so that the quiz starts automatically for the student.

Both of these cases work. Good job!

@filip-gregurevic @HanyaElhashemy @F4lka @madwau @Varnika-Tyagi
@krusche and I made a change and I was not able to reproduce it anymore. Can you also please try to reproduce it?
Thanks!

@krusche and I made a change and I was not able to reproduce it anymore. Can you also please try to reproduce it?
Thanks!

Automatic starting is working now, nice!

I'm getting this client error when the quiz has ended (the alert disappears but the results do not appear). Looks like it might be a problem with the particular quiz exercise I created?

@filip-gregurevic @HanyaElhashemy @F4lka @madwau @Varnika-Tyagi
@krusche and I made a change and I was not able to reproduce it anymore. Can you also please try to reproduce it?
Thanks!

Hey! The automatic refresh works for me now too.
One minor problem is that if we, as Instructor, specify the start time of a quiz and set it visible, the quiz starts on time (as expected) but the 'Start quiz now' button on the Exercises Dashboard is still clickable; and the Status of the Quiz is seen as 'Visible' and not 'Active'. (It goes away once we refresh the screen though, so, not a major issue, I think)

Note: Both the 'Start Quiz now' button and 'Edit' Option are clickable after the quiz has already automatically begun. However, they do not affect the running quiz at all.

If we click on 'Start Quiz Now' midway through the live quiz, nothing happens at the student's end  (i.e. the quiz still has 10/15/20 seconds remaining; as per the automatic start time) and the Status of the quiz changes to Active on the Instructor's Dashboard.

If we click the 'Start Quiz now' button after the quiz has ended, it automatically changes to 'Release for Practice' and sets the quiz status to 'Closed', so the functionality isn't hindered.

If we click on the 'Edit' button while the quiz is in progress, it opens the edit menu, but doesn't let us 'Save' any changes (as Status: Active).

All in all, no behaviour that impairs the quiz functionality, but it might be viable to set the 'Start Quiz Now' button to disable if a quiz has automatically started already.


Fumbling with takeLatest/takeLeading HelperWorkerParameters type

I often inject dependencies into the saga like this:
const dependencies = {foo: 'bar'}
takeLatest(ACTION_TYPE, workerFn, dependencies)

But dependencies type errors with:

Argument of type '[{ foo: string; }]' is not assignable to parameter of type 'never'

I dug into it and found that the ACTION_TYPE type is passed into HelperWorkerParameters like:
type HelperWorkerParameters<ActionType, Fn extends (...args: any[]) => any> = Last<Parameters<Fn>> extends ActionType
  ? AllButLast<Parameters<Fn>>
  : never

Which I'm having trouble understanding / make work. Does this mean that ActionType needs to be the last parameter in the additional arguments? That doesn't seem to make much sense to me--I'm a bit lost.
Thanks!

Also somewhat troubling is that I can't just escape-hatch it with
takeLatest(ACTION_TYPE, workerFn, dependencies as any)

Since it conflicts with the never type.

Ah, okay, I've found the issue.
type Dependencies = {foo: string}
const workerFn = (dependencies: Dependencies) => {}
takeLatest(ACTION_TYPE, workerFn, {foo: 'bar'})

Does NOT compile because workerFn does not include a second arg for the action being passed in.
const workerFn = (dependencies: Dependencies, action: ActionType) => {}

This works.

Add the Typescript error here in case it helps anyone searching for this problem:
Argument of type '[FooType]' is not assignable to parameter of type 'never'.

Nevertheless,  if I need a dependencies, but don't need an action in the workerFn(saga), then there is unused argument, that i must provide and type ...


Is there a list of the available timezones?

I am in the USA with timezone EST. I'm unsure what format the bot is expecting for the timezone.
I got it to work with America/Chicago - but it'd be helpful if there was more guidance on the format it was expecting

will keep you posted on that. But yes, indicating your region is the right way! Thanks!

https://en.wikipedia.org/wiki/List_of_tz_database_time_zones


Bug: Driver returns ray generation SBT record in closest hit programs

If I write a program like this:
struct RayGen {
  int one;
  int two;
};

struct ClosestHit {
  int three;
  int four;
};

[[vk::shader_record_ext]]
ConstantBuffer<RayGen> RGSBT;
[shader("raygeneration")]
void raygen()
{
  printf("raygen %d, %d\n", RGSBT.one, RGSBT.two);
  TraceRay(...);
}

[[vk::shader_record_ext]]
ConstantBuffer<ClosestHit > CHSBT;
[shader("closesthit")]
void closesthit(inout PayloadType payload)
{
  printf("closesthit %d, %d\n", CHSBT.three, CHSBT.four);
}

And then upload values 1 and 2 to the raygen SBT record, and then 3 and 4 to the closesthit SBT record, on NVIDIA cards, I correctly see

raygen 1 2
closesthit 3 4

but on AMD, I see

raygen 1 2
closesthit 1 2

For some reason, on AMD cards, the returned SBT record in all closest hits (at least on my RX 6750 XT) is incorrectly the raygen record's data...

Interestingly, trying another example codebase from here, https://github.com/Twinklebear/ChameleonRT/releases, I do not see this issue. So it appears to only happen under certain circumstances.

I forked Sascha Willem's Vulkan Examples repo, and added a little example which demonstrates how to use SBT record data. The target is called "raytracingsbtdata.
I have a PR open, but in the mean time the code for that can be found here: https://github.com/natevm/Vulkan
On NVIDIA cards, I correctly see this:

But on AMD cards, I see only red:

On AMD, the triangle in the center incorrectly receives the raygen record's SBT data.

discovering that I have a similar issue in the miss program, where the miss shader record returned by the AMD driver is actually the first raygen record's data.

I sort of wonder if AMD assumes the "MultiplierForGeometryContributionToHitGroupIndex" on a TraceRays is 0 when it isn't...

Was able to reproduce it on my RX 6800 (navi21)

Can someone look into this?


Fix null ref creating new subscription

Fixes null reference exception when creating a new subscription, introduced by commit 09aa1eb5d1b1606935a08dc03f0f071e5508018c .

It was not supposed to go to master 😞
@paolosalvatori we need to ensure that contributor PRs can only target develop.
Something to review when @ErikMogensen moves to GH Actions.


Feature : Support Nomad Task API

Nomad's Task API provides every task managed by Nomad with a Unix Domain Socket (UDS) to access the local agent's HTTP  API. Regardless of agent configuration the Task API does not require mTLS, but always requires authentication.
This would make it much easier when working with an mTLS enabled cluster :innocent: and IIRC only requires a newer version of the Nomad API client.
https://developer.hashicorp.com/nomad/api-docs/task-api
https://github.com/hashicorp/nomad/pull/16872

you coul try this build from main branch ghcr.io/ituoga/coredns-nomad:main

@blinkinglight Something seems off,  running the above image I get unsupported protocol scheme "unix" ...
service.nomad.:1053
CoreDNS-1.11.3
linux/amd64, go1.21.13, c742ec03f-dirty
[DEBUG] plugin/nomad: Looking up record for svc: dns namespace: default
[ERROR] plugin/nomad: getClientfailed querying self endpoint: Get "unix:///v1/agent/self?namespace=platform®ion=global": unsupported protocol scheme "unix"
[INFO] <IP_ADDRESS>:64739 - 57057 "A IN dns.default.service.nomad. udp 54 false 4096" NOERROR qr,aa,rd 43 0.00034716s

The corresponding Corefile  is :
service.nomad.:1053 {
    errors
    debug
    health
    log
    nomad {
      zone service.nomad
      address unix:///secrets/api.sock
      ttl 10
    }
}

@henrikjohansen Could you try without address, and set NOMAD_ADDR as env var instead (though I think nomad might do that by default?)

So I just tried this locally via a manually built coredns and it did work, I wonder if something is wonky with the build process so that it fetched the wrong nomad api client?

#5 has a working readme for the task api. I also fixed the Dockerfile so you can easily build this locally and test (till @blinkinglight merged it). I just verified it on a test machine.

api.sock requires token .
token [token]
address unix:///secrets/api.sock
and it works.

You shouldn't need to specify the token if you use the task file I have added to the readme (it passes the token as env var)
On Sun, Dec 1, 2024, at 17:15, M wrote:

api.sock requires token .
token [token]
address unix:///secrets/api.sock
and it works.
—
Reply to this email directly, view it on GitHub
https://github.com/ituoga/coredns-nomad/issues/3#issuecomment-2509913309,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAAT5C5Q7A5XRD6DKKA5UYD2DMY25AVCNFSM6AAAAABIZMBC4CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKMBZHEYTGMZQHE.
You are receiving this because you commented.Message ID:
@.***>

that works too. thank you @apollo13


DEVPROD-12026: Add execUser input field to distro settings page

DEVPROD-12026

Description
Add Exec User field to distro settings. The Exec User field can be blank.
Screenshots
I figured that the new field should be close to the SSH user. I could change the title to something like SSH & Process Configuration if that might make more sense.

Testing

Updated transformers.test.ts
Tests will fail due to backend PR not being merged yet

Evergreen PR

evergreen-ci/evergreen/pull/8511

I will wait until tomorrow for backend change to be deployed

Updated title and description to be a little nicer:


About SMAC maps

Hello, it's said in the paper that the experiment on SMAC was tested on "all 13 maps",(Figure 6).
However, $ python -m smac.bin.map_list, would return 38 maps.
Could you please let me know, which 13 maps did you used for the experiments in the paper.

Sorry for the inconvenience. The 13 maps we used include:

2s3z
3s5z
1c3s5z
5m_vs_6m
3s_vs_5z
2c_vs_64zg
10m_vs_12m
27m_vs_30m
3c_vs_100zg
5z_vs_1ul
1c3s5z_vs_1c3s6z
MMM2
MMM3

We put relevant information in our appendix. It seems that the camera-ready version of AAAI does not include the appendix. We are considering adding a additional link to it. Thanks for your interest to our paper!


Enable native MacOS slider to control position in track

Update the version of souvlaki to support MacOS media progress events, and take advantage of those events. Resolves part of https://github.com/jpochyla/psst/issues/350
Before:

After:

Updated the title and description, changes to Souvlaki have been merged and this PR is ready to go!


fix(editor): more "modern" tabline

As discussed in https://github.com/catppuccin/nvim/pull/760#pullrequestreview-2239840349
Before:

After:

That looks quite nice! I guess we need to fix the stylua failure before merging this PR.

The failure is unrelated, as it's also happening on main. If you push a fix to main, I'll merge it here


Add Travis-CI build for all PR / branches

start the ES Docker container
run the tests

I would exclude branch build, since there is already PR build.
This would save some :snowflake: :bear:
cf:

Ok, I disabled branch build :+1:


Bumping up eks-a release version

Description of changes:
Bumping up eks-a release version
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/lgtm
/approve


Swift 3

Thanks for a great repo, I use it in one of my apps.
This PR a Swift 3 update for the framework as well as the example project. Kept them as separate commits, hopefully that makes it easier for you to code review.
Have a great day.
Best regards
/Wilhelm

👍

This PR solves #73.
It would feel great if this could get merged @ariok.

Thanks for your work! I'm still OOO for my Honeymoon. I'll be back in a few days and I'll merge these commits.


TYPO in landing page

probably the usenamne should be username

I have submitted a PR #126 with necessary changes


Increase z-index or allow custom

Using tailwind's z-index classes doesn't really work since it only goes up to z-50.
Generally this should be okay, but some elements have a far greater z-index than this, but the modal should always be on top.
Increase the z-index to a larger number, perhaps 1000 to ensure it's always on top?
Could also add a prop to <ModalProvider /> to allow this to be overridden globally in case the user has z-indexes even greater than this.

From the tailwind docs you should just be able to add your own z-index value in the config and call it like a normal class:
// tailwind.config.js
  module.exports = {
    theme: {
      zIndex: {
        '0': 0,
       '10': 10,
       '20': 20,
       '30': 30,
       '40': 40,
       '50': 50,
       '25': 25,
       '50': 50,
       '75': 75,
       '100': 100,
        'auto': 'auto',
      }
    }
  }

I was doing something similar today but with grid-rows-{n}. Could be a quick fix. Happy to test in a PR if you like?

@damiensedgwick yeah could do that. Probably just need to add one that's a high number. Then still think adding a config option would be a good idea in case someone has another higher z-index element that they want to cover.
PR welcomed if you fancy it!

I've opened up a PR here #31

Fixed by https://github.com/mbrookson/react-simple-hook-modal/pull/32


Discontinuation of is-a-backend.dev & is-a-frontend.dev

On Jan 27, 2024, the is-a-backend.dev and is-a-frontend.dev domains will expire. They will not be renewed as they have not been used as much as it is worth it to keep renewing the domain names.
I would recommend either migrating your site over to is-a-fullstack.dev or another domain service (such as is-a.dev or Open Domains). We will also most likely not be renewing the freesubdomains.org domain name either. This will most likely not be replaced and the website, subdomain checker, etc will be archived or moved.
Please note, I will keep is-a-fullstack.dev however as it has many more subdomains on it than the others.
I appreciate everyone's support in making this hard decision.

In addition to this, I will be stopping all new is-a-backend.dev and is-a-frontend.dev registrations, existing subdomains will still work up until the domain expires.

In addition to this, I will be stopping all new is-a-backend.dev and is-a-frontend.dev registrations, existing subdomains will still work up until the domain expires.

the new devs don't want to just stay at one place, they all want to learn more skills and become full stack devs
I think this is a good move for both the users and you yourself
though I still recommend buying is-really.cool domain cuz it is really cool 💀
also you can merge the domain to other project like open domain's maybe?(just a suggestion)

though I still recommend buying is-really.cool domain cuz it is really cool 💀

I may consider it.

Both domains have expired and all files using them will be removed.


ENJOYING_THIS_PROJECT="SayThankYou"

Here is the place to say thank you to folk(s) who are working hard on this project.
« One of the greatest ways to show your appreciation to open source projects you enjoy is to open an issue that let people say thank you »
Disclaimer: I don't have any kind of connexion or personal interest with maintainers(s) of this project. Pure gratitude here.
Cheers!

This amazing simple project make my life easy! I use Travis (CI) and the CD part is made thanks to sheperd. I love it!
Manuy thanks!

Thanks! (And sorry for the late answer.)

TZhank you for developing this =) It's hardto find swarm-updating services out there =)

I just found about Watchtower this evening and, when I went to see if that worked on Swarm, found this. A couple of lines in Portainer and I have it up an running. Many thanks!

shameless advertising my service updating scripts, recently opened source.
https://github.com/shizunge/gantry
Would you like to give it a try?

I'm hoping this still works today and also thank you! I'm looking into understanding how to have shepherd only deploy and monitor services that have specific labels so I don't just deploy this and start rolling up updates of my hundreds of containers.

I want to apologize, while I need to clarify myself.
Firstly I must express thanks to the original author, as I used shepherd for a year, until recently it failed due to 'docker manifest' CLI errors.
I forked and was trying to fix this problem and other issues I encountered. However it became a huge refactor and not similar at all. I guess there is little chance to have that tremendous change merged.
People in this post and who unfortunately poked by me are definitely wonderful people, who cared the project, contributed to it, and wanted to make things better. I believe they deserve bug fixes, a working solution and relieve from anxiety of broken software. I was acting in good faith.
Apparently, I used a wrong approach by spamming I want to apologize to everyone affected.
Sincerely


how to find the smoking information?

I can find the smoking information from the Observation when I use  this command: ./run_synthea -p Num, but in this way I cannot find the metabolic patients, so I use ./run_synthea -p 10 -m metabolic*
and generate the metabolic patients records, but in this way I cannot find the smoking status information. can you please help me resolve it? THX!

hi, I have already resolved this problem.

Please see https://github.com/synthetichealth/synthea/wiki/The--M-Feature
Do not use the -m feature.

Rerun Synthea without -m.
cd /output/fhir
grep "smoking" *

it really helps me! thanks for your help!


Close down home and registration pages

Removes 2021 content from the home page and registration page, directs people to the newsletter on both, and removes the registration link from the header.
Home page:

Registration page:

Split into #8 and #9.


Add notes on how to use synth to crossbuild a armv6 repository.

Please review and correct as required.

Okay, I'll look at it in depth tomorrow.
FYI, synth supports aarch64 natively too.  GCC6-aux was fully ported to freebsd/ARM64 and I pushed the updates upstream to gcc.

Okay, I added a clarification line in 71b6b13daf9fce1e29b4575333d132d3d5260347 and also gave you credit for the entry.  Thanks!

I guess I'll need to issue a new tag so that Eric can update ports with a new release.


add dct:description where missing for top-level resources

dct:description values are output as top-of-page text for HTML + RDFa, they may be used for the UWLSWD index page.
( To do: List top-level resources missing descriptions. )

Some of the resources missing description values in the index, do have descriptions in the DataCite metadata files.
However, temp_index.xsl only grabs datacite:description values with xml:lang = 'en-US'.
<description>{datacite:descriptions/datacite:description[@xml:lang = 'en-US']}</description>
Not all of the datacite:description values have an xml:lang attribute, so they are not found during the transformation.

PROPOSED PLAN OF ACTION:

[ ] @briesenberg07 Update temp_index.xsl to grab all datacite:description values (we know, at this point, that all descriptions are English)
[ ] @briesenberg07 @cspayne @gerontakos Prior to writing the new index.xsl (which will sort using schema:disambiguatingDescription), correct lang tags in DataCite XML

Updated temp_index.xsl to fetch all datacite:description values, adding lang-tag to-dos to #65 . See also #26 .


Privacy Settings

Implement the privacy settings.
Users need to be able to:

make their accounts invisible to other general users(but not admins)
show or hide their address
show or hide their location

this is further along, but needs some tests to make sure @Pratt0923 's comments from above are true on The Grapevine (users index) and profile page (user show).


What's the purpose of .jobf files?

I see three points:

Exporting renamed class/field/method names. While they can do that, they are quite useless compared to the formats I added support for in #1505, since they can't handle comments, method args or method vars, and they include auto-generated names (why would you want to export them?).
Using them as some sort of "cache" for the auto-generated names. I don't think that's a good argument since these are generated just as fast as they are read from disk, and caching should be done in JADX's cache folder anyway.
Importing deobfuscation mappings. That's the only use case that justifies .jobf's existence IMO, since you can't do that easily otherwise. But since I'm currently working on mapping-io import support (as a follow up to #1505), which, as noted above, is much better as the formats can handle more features, this point also becomes obsolete.

So, why am I opening this issue? Well, since I'm already working on mapping-io import support, I would like to replace this mediocre file format and the stuff surrounding it. I'd like to have something similar to how Enigma handles it:

Import mappings via the GUI or via the--deobf-map-file launch parameter (renamed from --deobf-cfg-file)
Rename --deobf-cfg-file-mode to --deobf-map-file-mode and make the following adjustments:

Remove overwrite and ignore as they wouldn't do anything, since we won't automatically load files from the working dir anymore, the user now has to explicitly specify the file he wants to load
Rename read-or-save to read-and-autosave-every-change
Add read-and-autosave-before-closing, which will autosave the mappings only when the user exits the program / closes the project

Rework the internal rename tracking state management. We should have a static MemoryMappingTree somewhere from which we load mappings and to which we write mappings. This should ideally eventually replace the current  system of JadxCodeRenames and JadxCodeComments, but that will be work for another PR (my idea is to use Tiny v2 as a base, but add JADX's SsaVars into it somewhere so method vars entirely generated by the decompiler can still be handled). For the current PR though, these two systems will exist side by side.

What do you think?

include auto-generated names (why would you want to export them?)

That is the main reason why jobf was added: to keep aliases unchanged between different jadx version (changes in deobfuscator and jadx processing/decompilation). Also, it was handy to have a simple format for manual edit or scripting (some people implement their own deobfuscator this way). So jobf format will be kept in jadx for compatibility reasons anyway.

and caching should be done in JADX's cache folder anyway.

Hm. I actually can save jobf file in cache now, thanks! I disable saving jobf file by default, because people complain that such files pollute their folders, but now cache folders everywhere 😄
Maybe I should move all cache folders to some common system directory :thinking:... ok, that's another issue

Rework the internal rename tracking state management. We should have a static MemoryMappingTree ...

Jadx already have such place to store all data: RootNode and aliases stored in *Info classes (check this method).
I can add an easier to use plugin interface for that.

This should ideally eventually replace the current system of JadxCodeRenames and JadxCodeComments

I think this is a bad idea, because as your PR shown other formats can be hard to convert/apply for jadx internal structures, also these format don't support dex, and use java bytecode internal info. So I prefer to use jadx own implementation and file formats for keeping user and project data.

Rename --deobf-cfg-file-mode to --deobf-map-file-mode and make the following adjustments:

Well, rename cfg-file to map-file is fine, but this should be done in easy for migration way: keep both names and print deprecation warning if old version is used. And this is too much hassle, so I prefer not to do this.
Also, you want to remove overwrite but next add read-and-autosave-* which is same for me. And these option can be used than you reopen project (it will be nice to save path to map file into project) so jadx will load these files on open (so ignore can be useful to check code without applying mappings)
And ... looks like I reject all your ideas, so I will share my vision of these changes:

First we need to add new formats and only after some time we can discuss removing old formats
I want to keep only decompilation code in jadx-core so all not related new features should be added to external and optional modules (jadx-gui fine for now until plugin api not quite ready). In short: in jadx-gui do anything you want, but keep away from jadx-core :rofl:
For import mappings: new methods for adding custom jadx passes should be added (similar to #1482), so you can implement similar to RenameVisitor pass (pre-decomplation stage) and add it in jadx-gui, there you will have access to RootNode and all classes and methods. To access variables inside methods, you will need to add a pass similar to CodeRenameVisitor (decompilation stage pass).
These new passes can be added only if --deobf-map-file set or saved path in jadx project (i.e field deobfuscationMapFile set in JadxArgs)
Such approach will allow to load user renames and use deobfuscator at the same time.
Also, it will allow using these passes in jadx-cli after extraction into plugin module.

That is the main reason why jobf was added: to keep aliases unchanged between different jadx version

Interesting, I couldn't think of a reason why anybody would want this before, but you're right, it might be annoying if your workflow got disrupted by updating to a new JADX version with a different naming behavior, yup.

So jobf format will be kept in jadx for compatibility reasons anyway.

But only for the next few releases I hope? Because since we're already using mapping-io, it would be best to use format supported by it to reduce the maintainability burden. I'd suggest leaving .jobf import support in until the next major release (major releases allow breaking changes), but automatically export to a newer format.

Hm. I actually can save jobf file in cache now, thanks!

Good idea, yeah, it won't bother anyone in there. 😉 This would allow us to remove the --deobf-cfg-file and --deobf-cfg-file-mode arguments in the future, as it would just be a regular cache file without special value (users could place the file manually in the cache dir if they absolutely need a custom old version, but I don't think anyone would actually do that).
For the moment, this is what I'll do:

Keep --deobf-cfg-file for importing .jobf files (mark as deprecated with no replacement, since it will be moved to the cache dir)
Keep --deobf-cfg-file-mode (mark as deprecated with no replacement)
Add --renames-mapping-file for importing mapping-io supported formats (I avoided the work deobfuscation to avoid confusion with the automatic deobfuscation JADX can do)
Add --renames-mapping-file-mode (see my initial comment)

I think this is a bad idea, because as your PR shown other formats can be hard to convert/apply for jadx internal structures

I wouldn't say so, you would be able to use mappings from mapping-io just as easily as JadxCodeRename objects, you'd just have to structure the code a little differently compared to the current design (which I'm doing anyways now for my PR). And yes, the current mapping formats are all targeted towards Java bytecode, but as I already said, that doesn't prevent us from taking e.g. Tiny v2 and modifying it slightly to accommodate JADX's needs (would be like three or four little changes in the spec, we could name the format JadxTiny).

So I prefer to use jadx own implementation and file formats for keeping user and project data.

JADX's project data would be mostly unaltered, the only thing I'd like to do is moving the rename data out of the .jadx file and into a .jadxtiny mapping file, see above.
Maybe not such a good idea after all, I'll have to think about it.

And these option can be used than you reopen project (it will be nice to save path to map file into project)

Good idea!

In short: in jadx-gui do anything you want, but keep away from jadx-core 🤣

I'll try to stay away from modifying it as much as I can! 👍 Will auto-deobfuscation also be moved in to a plugin eventually?

For import mappings: new methods for adding custom jadx passes should be added [...]

Thanks for the tip! :) I'll open a PR once I've figured most of it out.

But only for the next few releases I hope? ... to reduce the maintainability burden

Why you want to remove everything? :joy:
There is no any burden to maintain stable and tested features, but it is a real nightmare to maintain new features (i.e. bugs everywhere) :rofl:

Will auto-deobfuscation also be moved into a plugin eventually?

Yes, I really want to do this, also this is a first candidate for scripting support (#1175), because current deobfuscation conditions hard to understand, and they don't support real world cases. Also, many people don't like new generated names because they don't make code easier to read. So main goal is to provide an easy way to change these functions. This can be a several bundled implementation, 3rd party plugins or user scripts.

Why you want to remove everything? 😂
There is no any burden to maintain stable and tested features, but it is a real nightmare to maintain new features (i.e. bugs everywhere) 🤣

Well, having to deal with only one library for reading/writing mapping files is certainly easier than having two ;) And since cache files aren't user-facing anyway, I don't really see a problem. mapping-io is used in many projects, so it certainly can be considered stable, and on top of that the new format would be intercompatible with other programs, which is always good to have 🙂

Also, many people don't like new generated names because they don't make code easier to read

Yeah, I was really confused when I first toggled this feature on in JADX, it didn't help in any capacity 😅 Being able to register custom naming plugins sounds great! Enigma does provide such an interface, maybe you can look at how it's handled there. Here's an example plugin: https://github.com/QuiltMC/quilt-enigma-plugin


Buttons higher than text-boxes

The buttons are higher than the text-boxes.

Any more context? Screenshot? jsfiddle?

I make a screenshop tomorrow, my laptop is in the office.

Hi,
the Screenshot: http://cl.ly/Def4
Browser: Google Chrome on Win7
Greetings

Version: 2.0

Check again now please—we merged in some major forms updates.

ok. the DropDown and the textbox is ok but the button is 1px higher

Is there any way you can share a jsfiddle?

Hi,
i have downloaded the newest version of bootstrap and it works now.
Thanks :)

Great, thanks!


Update cache key in CI jobs

Reason: some caches (i.e on the linux-arm64 runner grew to a huge size, around 3GB).

It didn't reduce the cache size on self-hosted arm runner


'LBaaS plugin upgrade' docs request

Need to document for customers how to transition from using LBaaSv1 to LBaaSv2.
requestor contact: Nicholas Menant

may need to work on this in support of #170

There is no way to 'upgrade' from LBaaSv1 to LBaaSv2 in OpenStack. LBaaSv1 objects cannot be migrated to LBaaSv2.


Better visual indicator that things are wrong

Summary of the new feature
Right now when there is an error of sort VSCode the only visual indicator is the red file with a problem

Or none at all until you run it and it's too late.
Proposed technical implementation details (optional)
It would be great to show line where the first (I guess only 1st problem is visible, not all of them but if more then one, it would be great to see all) problem is more or less occurring. I sometimes see red file and then I search for a missing comma on 1000 line script. It's often easier to press F5, and see where it terminates.

This is due to the PowerShell parser but the implementation of showing those squiggles is not in this repo, please raise either in https://github.com/PowerShell/vscode-powershell or https://github.com/PowerShell/PowerShellEditorServices


On dismiss of TapTargetView, recycler view scrolls

Version used:  1.13.3
Android version: Android-9
On dismiss of TapTargetView, recycler view scrolls automatically. Why is this happening ? How to resolve this issue ?
Why TapTargetView dismiss is affecting other UI elements ?

I've come across the same issue, if implemented the following temporary fix:
TapTargetView.Listener() {
    override fun onTargetDismissed(view: TapTargetView?, userInitiated: Boolean) {
        view?.visibility = View.GONE
        super.onTargetDismissed(view, userInitiated)
    }
}

Hope this works for you too.

It works! :)
Can you explain why it works pls :)

bad news, it doesn't work on android 8 😢


Bugfix - viewing user with unsynced permissions

In some circumstances a crash could occur when viewing a user with unsynced
permissions. The precise scenario in which this could occur is if the first
permission in the users permission list was unsynced, and later ones were
synced.
In theory this should never occur because all permissions are synced at
the same time. However the association from user to application_permissions is
unordered, so the order in which the records are returned from mysql when
reading them could change arbitrarily.
The fix here is to make the display code more robust to this possible scenario.
I've also refactored the view slightly so that it's clear that only the
<span> label class changes according to the sync_needed? status.
https://www.pivotaltracker.com/story/show/88500338

@vinayvinay, when you have a moment, could you take a look please?


labhub_test: Increase timeout to fix random CI failures

Default 5 sec timeout was causing unexpected random CI
failure.
Closes https://github.com/coala/corobo/issues/564
Reviewers Checklist

[ ] Appropriate logging is done.
[ ] Appropriate error responses.
[ ] Handle every possible exception.
[ ] Make sure there is a docstring in the command functions. Hint: Lookout for
botcmd and re_botcmd decorators.
[ ] See that 100% coverage is there.
[ ] See to it that mocking is not done where it is not necessary.

Because IGitt is making more that one requests while calling write_repositories method with an invalid token. That is sometimes taking more than 5secs and so the bot message queue is showing a queue.Empty exception as the response is delayed due to IGitt's requests.

fwiw, if this unbreaks the tree, I think it is an acceptable workaround if an issue is raised in IGittso that followup work is done to prevent it biting us again.

Travis tests have failed
Hey @nvzard,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

IGitt is doing its work as it is supposed to but it is making a second trial request because the token is invalid. This portion is handled by backoff https://pypi.org/project/backoff/ which makes the request function retry until some condition is met.

@nvzard , IGitt is causing this failure.  If you cant disable the 'feature' of IGitt causing this failure, then that is a problem in IGitt.  And please remove 'fix' from this commit message.  It hasnt fixed anything.  It has only obscured the problem, and it will bite us again another day.  This is a workaround at best. :P  A very useful workaround to get the builds working again, but we still need a solution to the problem.

50 char limit on commit shortlog.

ack https://github.com/coala/corobo/commit/2feedd67eac2af77c47ff44f1c6ff7a3c651615c

@gitmate-bot ff


v1 protocol for communication with BYO KV service

For compatibility reasons with Chrome and on-device auctions the bidding & auction service should support the v1 protocol with BYO KV service. Is this the case ?
How one can configure this service ? Normally it is an https endpoint like https://mykvservice.com/getvalues (below it is specified as  "dns:///..")
Existing terraform example config is here:
https://github.com/privacysandbox/bidding-auction-servers/blob/main/production/deploy/aws/terraform/environment/demo/buyer/buyer.tf#L30
  tee_kv_server_exists  = false
  tee_kv_server_domain  = "kv-${local.buyer_operator}-${local.environment}-appmesh-virtual-service.${local.buyer_root_domain}"
  tee_kv_server_address = "dns:///${local.tee_kv_server_domain}:50051"

B&A supports BYOS KV for Protected Audience only. You'd set the address for this for the buyer on Line 89, BUYER_KV_SERVER_ADDR, https://github.com/privacysandbox/bidding-auction-servers/blob/722e1542c262dddc3aaf41be7b6c159a38cefd0a/production/deploy/aws/terraform/environment/demo/buyer/buyer.tf#L89

OK. Thanks. My use case is protected audience.
So to sum it up:

tee_kv_server_domain  is the TEE KV service
BUYER_KV_SERVER_ADDR is the buyer BYO KV service  which receives queries with the v1 protocol (the same way as chrome sends requests)
both can coexist at the same time.

Can you confirm ?

At this moment the tee_kv_server_domain is for the TEE KV service used by Protected App Signals. It is not used for Protected Audience.
However, we did in the past seek feedback on BYOS+TKV coexisting so that--although not possible now--is an idea we would be happy to see interests.

OK. It is fine for now as we already have PA BYO KV server up and running and we will see at a later stage of testing for the TEE KV server.

Closing as resolved, reopen if necessary


Enable spring for zooming with touch gesture

Is there any way to enable spring when zooming by pinching (touch gesture)?
From what I have come across it seems to be a deliberate choice that spring is only enabled when dragging and not when zooming. I would like the zoom to be a bit smoother, as it is when scrolling with the mouse.
Furthermore I think this can alleviate issues I have with the image jumping when trying to zoom further in our out than the minZoomLevel or maxZoomLevel while having constrainDuringPan enabled. This jumping only happens when zooming with the pinch gesture and not when scrolling, leading me to believe that enabling the spring will fix it.
Best regards

It appears we don't expose a flag for turning on animations for pinch. Here's the code:
https://github.com/openseadragon/openseadragon/blob/master/src/viewer.js#L2956
That true at the end of the line means "immediately", i.e. no animation.
You might try changing it to false and building a fresh OSD to see if your hunch is correct.
There also doesn't appear to be any zoom version of constrainDuringPan, and zoom doesn't honor constrainDuringPan. Maybe what we need is a new constrainDuringZoom to help with this situation?

Thank you! This worked perfectly. The zoom became nice and smooth and the jumpiness disappeared.
I have another small issue similar to this. When i begin zooming while the image is still moving the image will appear 'jumpy' because it moves to the center of the pinch gesture instantly instead of gradually. I understand that this is probably intentional to make the interaction feels snappy, but a way to make this transition smooth would be great.
Again, thanks for the help!

Glad that helped! If you want to make a patch to expose that functionality through a flag, I'd be glad to have it.
As for the next jump you're seeing, perhaps try changing the true on the next line (panBy) to false?

@iangilman, Im trying to find some documentation or examples around what gestures OSD supports and how they can be modified.  Am i missing it?  I see the classes in the API documentation but am not sure if there are more illustrative examples somewhere.

@thatcher A good place to start is the various gestureSettings entries in http://openseadragon.github.io/docs/OpenSeadragon.html#.Options. We could definitely use some examples on the site though!


[Objectives] "Show current run in separate window" - Hotkeyable toggle

I have a hotkey setup to hide the main objectives window to have a look at past runs. Now I would like to setup another hotkey to only toggle the window for the current run.
Unfortunately this window shows all the time and needs to be toggled in the settings.
Another suitable solution would be to add an option to only display the current run window during a run and the run history otherwise.

Add ability to bind a hotkey to toggle an imgui window by name, e.g. /imgui toggle <window_name>

Uhm, I implemented that a year ago?

What he really wants is to have the current run in a separate window, as far as I can tell?

/tb [modulename] to toggle the main window of a module has been a thing for as long as I remember.

The left window is the main Objectives window, it shows a history of the current and all past runs. I have setup a hotkey that sends /tb objectives to toggle it
The middle window is the current run, it can only be toggled with the checkbox "Show current run in separate window" (see right window)

I want to setup a hotkey to toggle this middle window.


Fixed a problem with large values in packEnclose

I have added a test showing how packEnclose is failing with the x,y values above 1e5. It runs out of precision and throws an Error at line 46 during the front propagation.
I've added translation of the circles to encloseBasis3, so that the overall values are smaller.
The time complexity is intact. I had to update the expected result in the edge case test (precision change).
Thank you for the wonderful algorithm implementation!
Example
const circles = [
    { "x":<PHONE_NUMBER>532917, "y":<PHONE_NUMBER>573899, "r": 10 },
    { "x":<PHONE_NUMBER>781883, "y":<PHONE_NUMBER>7581244, "r": 10 },
    { "x":<PHONE_NUMBER>335791, "y":<PHONE_NUMBER>6245544, "r": 10 }
  ];
  assert.doesNotThrow(() => packEnclose(circles));

Looking good! Note that these should be named large values rather than big numbers (because of precedent).

@Fil I changed the wording


[GEARPUMP-213] build docs with MkDocs

build docs with MkDocs instead of Jekyll. MkDocs has a "readthedocs" theme which supports two-level table of contents sidebar. It's easier for users to navigate through the documentation. Here is a snapshot.

Current coverage is 71.09% (diff: 100%)

Merging #88 into master will increase coverage by 0.28%

@@             master        #88   diff @@
==========================================
  Files           178        178
  Lines          5903       5903
  Methods        5584       5398   -186
  Messages          0          0
  Branches        319        505   +186
==========================================
+ Hits           4180       4197    +17
+ Misses         1723       1706    -17
  Partials          0          0

Powered by Codecov. Last update 5cd5b93...9e13c1e

@whjiang @kkasravi @huafengw what do you think ?

I'm OK with this change.

+1 - though i haven't seen the output

+1.


Using K9.DEVELOPER_MODE in more places

I am using debug builds and I don't like the Debug / Clear message body context menu entry ;)

Thanks


Feature request: Glowstone/Sea Lantern/Shroomlight bits should glow

They randomly do, I've made glowing glowstone-covered-in-things blocks that randomly glow. I've not tested if the lights prevent spawns or are client only


Slope of a Line

Create a program to find the slope of a line given two points on the line. The program should go under the Algebra folder. Title the program SlopeOfALine.java.
Refer to the quadratic formula code to find out how to prompt users for data and use it accordingly.

Hi @Kyle-P,
Just created a pull-request for this.


Create a persistent volume for the public folder of the Community API

The community API made with strapi currently saves all the uploaded files to its /public folder.
But there is no Persistent Volume to make this directory persist even when the pods are updated or deleted, meaning that all the uploaded files are erased and not found when the pods are restarted, or recreated.

Volume mount was added to the configuration files here : https://github.com/AstroPlant/astroplant-k8s/commit/57b733d3e7d00bbb421d3c2924934130b9fd3cb6.


Reduce the retention period for old notifications from 3 months to 1 …

…week

Leaving MoJ so closing.


Subdomains support (for TweetDeck)

Hi, I do love this extension! It's pretty cool idea at all.
But I think I and other professional users usually use TweetDeck than twitter.com, so it would be cool if it also works in subdomains of twitter.com.

Thanks for your time & your work

Thank you so much to use this extension and give me this pull request!
I also think TweetDeck is important for so many users.
This is very nice pull request.
It looks great to me!
Thank you!


Warning message not displaying after pressing Cancel on Enter Your Pin screen

On iOS and app version 3.0.2

Looks like the EN strings moved around.
new location:  more.sections.app


Fix X10 commands for mochad light turn on

Description:
This commit attempts to address issues that a lot of people are having
with the x10 light component. Originally this was written to use the
xdim (extended dim) X10 command. However, not every X10 dimmer device
supports the xdim command. Additionally, it turns out the number of
dim/brighness levels the X10 device supports is device specific and
there is no way to detect this (given the mostly 1 way nature of X10)
To address these issues, this commit removes the usage of xdim and
instead relies on using the 'on' command and the 'dim' command. This
should work on all x10 light devices. In an attempt to address the
different dim/brightness levels supported by different devices this
commit also adds a new optional config value, 'brightness_levels', to
specify if it's either 32, 64, or 256. By default 32 levels are used
as this is the normal case and what is documented by mochad.
Related issue (if applicable):
Fixes #8943
Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.github.io#4214
Example entry for configuration.yaml (if applicable):
light:
  mochad:
    devices:
       - address: a1
         brightness_levels: 64

Checklist:

[x] Documentation added/updated in home-assistant.github.io
[x] Local tests with tox run successfully. Your PR cannot be merged unless tests pass
[x] Tests have been added to verify that the new code works.

Ok, I've updated the patch to try and handle all the different device cases properly. Let me know if I made an incorrect assumption about something again.


Don't work with a project from lobe, but work from Google Teachable Machine only

Hi, I tested this project, but I can't genarate compatible files from MS Lobe.
But I tested with an export from Google Teachable Machine and this works very well.
Steps :

Export a project from Lobe
Select the format "Tenserflow Saved Model"
execute the following command to convert the export for TenserFlow js:

tensorflowjs_converter --input_format=tf_saved_model --output_format=tfjs_graph_model . ./web-model

copy / paste the exported files in le directory public/model

Actual result :

an error message is display on the web page
the file metadata.json doesn't exist
the library "@teachablemachine/image" is used in the file Prediction.js

Expected result :

The labels who correspond to my webcam are displayed

My usage of tensorflowjs_converter is may be bad ?

Same here, im confused.

it looks like teachablemachine/image requires model in tfjs_layers_model format, but I have not find any way to convert exported model in tf_saved_model to it. I have tried to use tfjs_graph_model with tensorflow.js directly, but have failed (Argument 'x' passed to 'gather' must be numeric tensor, but got string tensor).

i can reproduce this error, with tfjs-node and the direct saved model its kind of work but i got wrong results.
i requested allready a tensorflow js Export direct from the lobe App #14

Thanks for this! We're looking into what's going on now. 😄

Is there an update on this?


Multiple changes to the settings screens

-> Moved strings that don't have to be translated (like version number, names, etc)
-> Redesigned the about screen layout
-> Settings screens are now affected by the selected theme
-> Reformatted and rearranged code

You're very good at creating very efficient code! Nice PR!

Thanks! :-) Before I create a new issue: Do you know why the action bar is missing in the about screen? I tried to get it back but I couldn't get it to work yet...

It's because the PreferenceScreen isn't abiding by any theme (which is fine). I don't think a Toolbar is needed there, anyway, I think

I don't know if you got my message. I replied to the notification email directly. I'll just post it again here.

have to disagree on that. The action bar - in my opinion - is an important part of Android design language. It tells me what screen I'm on and that I can go back from there via that backwards arrow. That's the case at least for the main PreferenceScreen.
Other than that, I think it looks weird for it to be there on the main PreferenceScreen but not on the about screen.
Just my two cents here. :-)

Good point about the back arrow actually. I'll look into getting the toolbar in the About screen. I'll get it fixed :) thanks for the reminder about the back arrow!


Text-generation, model set-up: torch.compile for attributes instead of models' types

What does this PR do?
It changes get_torch_compiled_model(model) function:
def get_torch_compiled_model(model, logger):
    # for model_type in ["gpt_bigcode", "mpt", "bloom", "gpt2"]
    if hasattr(model, 'transformer'):
        model.transformer = torch.compile(
            model.transformer, backend="hpu_backend", options={"keep_input_mutations": True}
        )
        ...
        ...

It’s hard-coded now by models' types, but we can hard-code it from attributes' point of view. I think this way can cover more models already supported for each attribute.
Please advise, if you know better way to remove hard-codes.
I did some manual testing for models with types the function covers.
Before submitting

[ ] This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
[ ] Did you make sure to update the documentation with your changes?
[ ] Did you write any new necessary tests?
Please, advise tests I need to run or a models list validated with --torch_compile option.

@regisss  please review.

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.


⚠ Fortnite has degraded performance

In c2e73a2, Fortnite (https://fortnite.com) experienced degraded performance:

HTTP code: 200
Response time: 1511 ms

Resolved: Fortnite performance has improved in 9d7aa9d.


how can eml2html be run?

hey barthez,
I just started working on a eml2html converter myself, but I would use yours instead for there's no reason to reinvent the wheel. I'm not familiar with ruby, and I don't get the program to run.
So when I run
../eml2html/bin/eml2html test.eml
in my linux terminal I get:
../eml2html/bin/eml2html test.eml /usr/lib/ruby/1.9.1/rubygems/custom_require.rb:36:in `require': cannot load such file -- eml2html (LoadError)
    from /usr/lib/ruby/1.9.1/rubygems/custom_require.rb:36:in `require'
    from ../eml2html/bin/eml2html:3:in `<main>'

Are there any prerequisites I need to be aware of?
Thanks.

okay, got it! Installed it via gem2.0 install eml2html
However, now it throws the following errors:
/var/lib/gems/2.0.0/gems/eml2html-0.0.2/lib/eml2html/converter.rb:97:in `block in replace_images_src': undefined method `name' for nil:NilClass (NoMethodError)
	from /var/lib/gems/2.0.0/gems/eml2html-0.0.2/lib/eml2html/converter.rb:95:in `gsub'
	from /var/lib/gems/2.0.0/gems/eml2html-0.0.2/lib/eml2html/converter.rb:95:in `replace_images_src'
	from /var/lib/gems/2.0.0/gems/eml2html-0.0.2/lib/eml2html/converter.rb:69:in `html_body'
	from /var/lib/gems/2.0.0/gems/eml2html-0.0.2/lib/eml2html/converter.rb:30:in `save_html'
	from /var/lib/gems/2.0.0/gems/eml2html-0.0.2/lib/eml2html/converter.rb:21:in `block in save_files!'
	from /var/lib/gems/2.0.0/gems/eml2html-0.0.2/lib/eml2html/converter.rb:20:in `each'
	from /var/lib/gems/2.0.0/gems/eml2html-0.0.2/lib/eml2html/converter.rb:20:in `save_files!'
	from /var/lib/gems/2.0.0/gems/eml2html-0.0.2/bin/eml2html:28:in `run!'
	from /var/lib/gems/2.0.0/gems/eml2html-0.0.2/bin/eml2html:33:in `<top (required)>'
	from /usr/local/bin/eml2html:23:in `load'
	from /usr/local/bin/eml2html:23:in `<main>'

I've run into the same error. It appears to be a bug.

This happens when an eml file has a body that has a cid that isn't included in the attachments.


Make MaximumRate and MinimumRate readonly

These are specified to be readonly in mpris and were accidently
implemented as readwrite.

Good catch, thanks!


Command /Developer/Platforms/iPhoneOS.platform/Developer/usr/bin/llvm-g++-4.2 failed with exit code 1

ld: warning: directory not found for option '-L/Sites/github/app/build/iphone/../../../../tmp/debug/build'
ld: warning: directory not found for option '-L/Sites/github/app/build/iphone/../../../../tmp/staticlib/build/Debug-iphonesimulator'
ld: warning: directory not found for option '-L/Sites/github/app/build/iphone/../../../tijs/TiCore/TiCore/build/Release-iphonesimulator'
ld: in /Users/xiaomacji/Library/Application Support/Titanium/modules/iphone/jp.msmc.tiimagefilters/0.1/libjp.msmc.tiimagefilters.a, file is universal but does not contain a(n) armv6 slice for architecture armv6
Command /Developer/Platforms/iPhoneOS.platform/Developer/usr/bin/llvm-g++-4.2 failed with exit code 1
Please tell me what to do?

this is issue of "Xcode 4.2 changes the standard architecture for compilation to just armv7"
http://wiki.appcelerator.org/display/guides/iOS+Module+Development+Guide#iOSModuleDevelopmentGuide-
I pushed updated project file.


chore(tags): Allow for lookup via ids vs. name in the API

SUMMARY

Previously we the API only supported queries using the names as way of querying tags, I've updated the API to now accept IDs (better pattern) to allow names to have commas. We discovered the issue in testing and took advantage the opportunity to refactor this piece of code, but also leaving tags param for backwards compatibility.
curl 'http://<IP_ADDRESS>:54647/api/v1/tag/get_objects/?tagIds=17,12,13' \
-X 'GET' \
-H 'Accept: application/json' \
# ...

TESTING INSTRUCTIONS

goto all entities page (http://<IP_ADDRESS>:8080/superset/all_entities)
see page render with new network call

ADDITIONAL INFORMATION

[ ] Has associated issue:
[ ] Required feature flags:
[ ] Changes UI
[ ] Includes DB Migration (follow approval process in SIP-59)

[ ] Migration is atomic, supports rollback & is backwards-compatible
[ ] Confirm DB migration upgrade and downgrade tested
[ ] Runtime estimates and downtime expectations provided

[ ] Introduces new feature or API
[ ] Removes existing feature or API

🏷 preset:2023.47


Fix invalid isPacked state when texture is released.

When the data is read back (unpacked) to CPU and texture is released, keeping
the isPacked flag leads to state when unpacked data is understood as packed.
Added a test that exposes the issue.
BUG

For repository owners only:
Please remember to apply all applicable tags to your pull request.
Tags: FEATURE, BREAKING, BUG, PERF, DEV, DOC, SECURITY
For more info see: https://github.com/tensorflow/tfjs/blob/master/DEVELOPMENT.md

This change is

@annxingyuan PTAL

Tests pass but there are issues:
13 12 2018 13:44:57.503:ERROR [reporter.browserlabs]: ✖ Could not update BrowserStack status
Error: 403 Forbidden (Rate Limit Exceeded)

Tests pass but there are issues:
13 12 2018 13:44:57.503:ERROR [reporter.browserlabs]: ✖ Could not update BrowserStack status
Error: 403 Forbidden (Rate Limit Exceeded)

CI issue fixed.

@astojilj
Ah - nice catch. Although I think it might make more sense to change the logic in compileAndRun - backend_webgl.ts:1879 - to the following: if texData.texture == null, then we want to set the isPacked bit to equal program.usesPackedTextures (no need for the if statement). Does that make sense?
Also I believe this unit test passes at head because the input tensor will be uploaded as a uniform. Could you also set the WEBGL_SIZE_UPLOAD_UNIFORM flag to 0 as part of the test setup?

Ah - nice catch. Although I think it might make more sense to change the logic in compileAndRun - backend_webgl.ts:1879 - to the following: if texData.texture == null, then we want to set the isPacked bit to equal program.usesPackedTextures (no need for the if statement). Does that make sense?

It is a matter of preference - because isPacked sounds like data is packed, and on the other places we don't check (isPacked && texData.texture != null) it looks like a loose end to me that is better to be fixed at the origin: where texture is released.

Also I believe this unit test passes at head because the input tensor will be uploaded as a uniform. Could you also set the WEBGL_SIZE_UPLOAD_UNIFORM flag to 0 as part of the test setup?

WEBGL_SIZE_UPLOAD_UNIFORM is set to 0 for all tests now so it fails without the patch. Good point - I'll set to 0 in this test.

The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter.

Is it because you pressed update branch and I merged upstream/master with that commit?
Is it OK to force push only squashed commit to fix this or you'd prefer other way?


add handler for exec local command

Hi @missedone.
Looks nice. Would you provide some content to the README file explaining the use case and an example of your commit?   I think a useful README it's the first thing to check in case of questions.

sure, will add example soon
yes, configmap PR goes #114 , and namespace filter PR goes #115

just rebased the PR, please review again, thx

I think it's a nice feature to have but needs some care. Can you fix conflicts?

sure, will resolve the conflicts.

conflicts resolved


Updating image tags in docs [dev branch]

Same as https://github.com/apache-spark-on-k8s/spark/pull/218 on dev branch

Forgot to merge this one in. Merging, since branch-2.1-kubernetes still points to the rc1 image.


Help with the project

This is not a feature request, nor a bug report, i simply want to somehow help the project in the coming two months.
Initially, i read the FAQ and the Support sites on mininet.org.
They told me to write to the mailing list, which i did:
Hi there,

i am a studying at the University of Stuttgart and as part of a lecture,
I'd like to help the Mininet project.
Is this the correct place to ask for some issues to help with or should
this rather go on the GitHub issue tracker?

Cheers,

The reply was
Hello,

here there are sometimes user questions, but no questions about the project
and its issues itself. So to help the project you may be better off on
github.

Best regards

so i guess i am asking here for something to help the project with.
I looked at issues with the 'good first issue' label, but there were none.
I looked at how the mininet vm is being generated and it looks like there is some improvement potential.
Could vagrant be an alternative here?
Does anybody have some other ideas about things i can help with that are not too big?

ah, right @lantz
maybe you have the watch filter "mentions and participating only".
the reason why you might have many emails for old issues and/or PRs is this issue;)

Normally I'd close this since it's not technically an issue, but resolving issues and PRs is actually really helpful.
I'll try to smash through some of your queue this week.
There are all kinds of things that can and should be improved, certainly, including some breakages on current debian/ubuntu.

Project is over, I'll stay around at least as long my issues/prs are closed in any way (merged/closed).


Pass student into StudentInfo and display information for specific student

Also needs to be routed properly

HarknessInfo --> student name --> StudentInfo OR add new harkness --> assessing harkness page (Harkness.vue) --> student name --> StudentInfo

This feature has been axed


Add definitions for Linux debug related MAGIC

This commit adds definitions for Linux debug related MAGIC to confirm if the filesystem for debug is mounted.
Signed-off-by: Kenta Tada<EMAIL_ADDRESS>

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @JohnTitor (or someone else) soon.
If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.
Please see the contribution instructions for more information.

@bors r+

:pushpin: Commit 8b68710f9487fe53e4ee2f59271fca2cf00d3336 has been approved by JohnTitor

:hourglass: Testing commit 8b68710f9487fe53e4ee2f59271fca2cf00d3336 with merge a400a973f5a4a135fa8efd724ab7e1293bda37bd...

:broken_heart: Test failed - checks-actions

Ugh, MIPS64 uses too many resources in normal testing as well.


Improve the implementation of JoinAll?

Recently some thought has gone into futures that eternally return Ready and thus never yield to the executor (#2047, #2053, #2130). Particularly concerned are combinators and collections. FuturesUnordered has already been updated to yield every so often.
JoinHandle is another collection that might never yield. Should we implement it with FuturesUnordered under the hood or should we add some counter to the implementation?

Using FuturesUnordered under the hood would make JoinAll itself pretty pointless, the only advantage it has over using FuturesUnordered is potentially lower overhead when used for a low number of futures (though I don't know if this has ever been benchmarked).
Unlike FuturesUnordered and Shared, JoinAll doesn't intercept the Waker, so it will not encounter the same issue of never yielding. It will poll each sub-future at most once per poll.

Looking at the code again, you are right. So I'll close this.


Financial Transaction endpoint

 (?) [6] Endpoint de FT no Ruby Client

:shipit: released on version 0.7.0


Phaser 2.4.8: problem with physics

Hello. I've got a problem with my game after updating to Phaser 2.4.8. Player falls through platforms and stucks in air. Here you can see it on the video: https://youtu.be/V4Z8LIkw-g4
I use Arcade physics. Phaser 2.4.7 works fine.

There is change in Arcade Physics in 2.4.8. Check visual debug for bodies if it is correctly positioned and also read this forum post if you find information on your issue: http://www.html5gamedevs.com/topic/22695-247-248-body-anchoring-any-migration-tips/

It seems that problem is related to body positioning after flipping sprite with scale.x *= -1. Is it a bug or sprite.scale is supposed to work this way now?

Thanks for submitting this issue. We have fixed this, and the fix has been pushed to the dev branch.


fix(Branche): Mise à jour des actions de checkout

Mise à jour des actions de checkout dans les fichiers close_issue.yml, pr_update.yml et release.yml pour utiliser la version 4 de actions/checkout.

This issue has been resolved in PR #10.

This issue has been resolved in PR #12.

:tada: This PR is included in version 1.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Support Markdown output format

The idea is to let people generate their tutorial in Markdown format, so they can just put it up on GitHub instead of having to set up a static website.
Which output format to build could be specified in leg.yml, or you could append the format to the output directory, like template-html/ and template-md/.
This might even become the default format, just because it's so simple. Syntax highlighting is done by GitHub (making leg doc's job way faster), and there's no CSS/HTML/layout/images to worry about.

This is mostly finished, will just need some tweaking later.


Timer lease is not released when shutting down the CLI

This comes from forum thread and I reproed it as well.

Create a timer function that runs every second
Run it
Close the CLI and run it again

Result: it can take up to 60 seconds for the timer to start kicking in
@fabiocav and @paulbatum think it happens because the CLI gets killed without having a chance to release the lease.

See also https://github.com/Azure/Azure-Functions/issues/281

Duplicate https://github.com/Azure/azure-functions-cli/issues/55


Fix "unable to fetch polls" in dashboard

Logging in into the dashboard after a while (an hour) results in an "unable to fetch polls" error.

Closing this since it's not reproducible now.


THRIFT-5274 - Thrift 0.13.0 does not work with JDK8

Thrift 0.13.0 does not work with JDK8, as it is compiled with JDK11. Even though the source version is JDK8, incorrect byte code is generated for various ByteBuffer methods, e.g.:
Exception in thread "TAsyncClientManager#SelectorThread 22" java.lang.NoSuchMethodError: java.nio.ByteBuffer.rewind()Ljava/nio/ByteBuffer;
The fix is to manually cast ByteBuffer to Buffer (or else switch to using the xenial docker image to create the release artifacts). See this task for more context: https://github.com/eclipse/jetty.project/issues/3244

Hi @zeshuai007 ,
Yes you can reproduce as follows:

git clone https://github.com/apache/camel
Edit parent/pom.xml and change libthrift-version from 0.12.0 to 0.13.0
mvn clean install -f parent/pom.xml
mvn clean install -f components/camel-thrift/pom.xml

If you run the last command with JDK11 it works perfectly, otherwise you start seeing the errors as above, e.g.:
Exception in thread "TAsyncClientManager#SelectorThread 27" java.lang.NoSuchMethodError: java.nio.ByteBuffer.rewind()Ljava/nio/ByteBuffer;
at org.apache.thrift.async.TAsyncMethodCall.doWritingRequestBody(TAsyncMethodCall.java:263)
at org.apache.thrift.async.TAsyncMethodCall.transition(TAsyncMethodCall.java:195)

@zeshuai007 Will this PR be considered for 0.14.0? Or can you at least make sure that released artifacts are built with Java 8 to avoid this problem?

A much simpler fix would be to add -release 8 to the javac command line when compiling with JDK9 and later.

A much simpler fix would be to add -release 8 to the javac command line when compiling with JDK9 and later.


updated banner links array

:warning: Validation status: warnings

File
Status
Preview URL
Details

advocates/index.html.yml
:warning:Warning
View
Details

advocates/index.yml
:warning:Warning
View
Details

FromYmlToTOC-INDEX.ps1
:white_check_mark:Succeeded

advocates/index.html.yml

[Warning] the value ProfileList is undefined for metadata pagetype

advocates/index.yml

[Warning] the value ProfileList is undefined for metadata pagetype

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Recursive partial imports

main.scss may @import _base.scss which @imports _reset.scss. Building _reset.scss will currently only go one level up and try to compile _base.scss.
When collecting files, keep a list to check for duplicate results from grep_r. Add new results and recursively search partials. Keep a list of partials searched, too, if you want to react to infinite loops.

Testing seems to show that this is working now.
This is the most difficult thing the plugin does. Unless this project significantly grows in size/scope, I'll leave testing to the users instead of unit tests.


Added Depth First Search Algorithm in C++

Your checklist for this pull request
🚨Please review the guidelines for contributing to this repository.

[x] Make sure your files are in the right folder!
[x] Make sure you add the extension of the file (.cpp, .python, .java, etc).
[x] If your code is a solution for a code problem, please tell which one.
[x] Make sure your code is working, test for a lot of cases.

Description
I have added depth first search algorithm in C++ in classical_algorithms folder .

Hey @larissalages , can you please review my PR and merge it under Hacktoberfest 2022 .

Also can you please assign hacktoberfest labels to it .


⚠ Buyfrom.io has degraded performance

In 49e53ed, Buyfrom.io ($BUYFROM_IO_URL) experienced degraded performance:

HTTP code: 200
Response time: 10924 ms

Resolved: Buyfrom.io performance has improved in eea3620.


boot failure due to SOC_RESERVE_MEMORY_REGION overlap (IDFGH-3931)

Environment

Development Kit:      none
Module or chip used:  ESP32-WROVER-B
IDF version (run git describe --tags to find it): v4.1 (but I have also checked with master; same issue)
Build System:         CMake
Compiler version (run xtensa-esp32-elf-gcc --version to find it): xtensa-esp32-elf-gcc (crosstool-NG esp-2020r2) 8.2.0
Operating System:    Linux
Using an IDE?: No
Power Supply:         external 5V

Problem Description
I am having a problem where the boot fails because something is reserving the entire memory region in the address space:
I (29) boot: ESP-IDF v4.1 2nd stage bootloader
I (29) boot: compile time 18:04:05
I (29) boot: chip revision: 1
I (30) qio_mode: Enabling default flash chip QIO
I (33) boot.esp32: SPI Speed      : 80MHz
I (35) boot.esp32: SPI Mode       : QIO
I (37) boot.esp32: SPI Flash Size : 16MB
I (40) boot: Enabling RNG early entropy source...
I (43) boot: Partition Table:
I (44) boot: ## Label            Usage          Type ST Offset   Length
I (48) boot:  0 nvs              WiFi data        01 02 0000d000 00004000
I (52) boot:  1 otadata          OTA data         01 00 00011000 00002000
I (55) boot:  2 phy_init         RF data          01 01 00013000 00001000
I (59) boot:  3 factory          factory app      00 00 00020000 00400000
I (63) boot:  4 ota_0            OTA app          00 10 00420000 00400000
I (67) boot:  5 ota_1            OTA app          00 11 00820000 00400000
I (70) boot:  6 storage          Unknown data     01 82 00c20000 00100000
I (74) boot:  7 auth             Unknown data     01 82 00d20000 00100000
I (78) boot:  8 nvs_key          NVS keys         01 04 00e20000 00001000
I (82) boot: End of partition table
I (84) boot: Defaulting to factory image
I (86) esp_image: segment 0: paddr=0x00020020 vaddr=0x3f400020 size=0x2090c (133388) map
I (137) esp_image: segment 1: paddr=0x00040934 vaddr=0x3ffbdb60 size=0x02a4c ( 10828) load
I (141) esp_image: segment 2: paddr=0x00043388 vaddr=0x40080000 size=0x00404 (  1028) load
0x40080000: _WindowOverflow4 at /home/jeremy/esp/esp-idf-v4.1/components/freertos/xtensa_vectors.S:1778

I (142) esp_image: segment 3: paddr=0x00043794 vaddr=0x40080404 size=0x0c884 ( 51332) load
I (165) esp_image: segment 4: paddr=0x00050020 vaddr=0x400d0020 size=0x614d8 (398552) map
0x400d0020: _stext at ??:?

I (303) esp_image: segment 5: paddr=0x000b1500 vaddr=0x4008cc88 size=0x05ce0 ( 23776) load
0x4008cc88: prvAddNewTaskToReadyList at /home/jeremy/esp/esp-idf-v4.1/components/freertos/tasks.c:1062

I (324) boot: Loaded app from partition at offset 0x20000
I (324) boot: Disabling RNG early entropy source...
I (324) psram: This chip is ESP32-D0WD
I (326) spiram: Found 64MBit SPI RAM device
I (329) spiram: SPI RAM mode: flash 80m sram 80m
I (331) spiram: PSRAM initialized, cache is in low/high (2-core) mode.
I (335) cpu_start: Pro cpu up.
I (337) cpu_start: Application information:
I (339) cpu_start: Project name:     esp32_christie_bbq
I (342) cpu_start: App version:      34e41ee-dirty
I (345) cpu_start: Compile time:     Sep  3 2020 18:02:32
I (348) cpu_start: ELF file SHA256:  73208bf173b92ccc...
I (351) cpu_start: ESP-IDF:          v4.1
I (353) cpu_start: Starting app cpu, entry point is 0x400816f8
0x400816f8: call_start_cpu1 at /home/jeremy/esp/esp-idf-v4.1/components/esp32/cpu_start.c:271

I (342) cpu_start: App cpu up.
I (856) spiram: SPI SRAM memory test OK
D (856) memory_layout: Checking 8 reserved memory ranges:
D (856) memory_layout: Reserved memory range 0x3f800000 - 0x40000000
E (859) memory_layout: SOC_RESERVE_MEMORY_REGION region range 0x3f800000 - 0x40000000 overlaps with 0x3ffae000 - 0x3ffae6e0
abort() was called at PC 0x400e1c2f on core 0
0x400e1c2f: s_prepare_reserved_regions at /home/jeremy/esp/esp-idf-v4.1/components/soc/src/memory_layout_utils.c:109
 (inlined by) soc_get_available_memory_regions at /home/jeremy/esp/esp-idf-v4.1/components/soc/src/memory_layout_utils.c:126

ELF file SHA256: 73208bf173b92ccc

Backtrace: 0x4008944b:0x3ffe34e0 0x400898e4:0x3ffe3510 0x400e1c2f:0x3ffe3540 0x400d5035:0x3ffe38a0 0x40081957:0x3ffe3c40 0x4007932a:0x3ffe3c80 |<-CORRUPTED
0x4008944b: invoke_abort at /home/jeremy/esp/esp-idf-v4.1/components/esp32/panic.c:159

0x400898e4: abort at /home/jeremy/esp/esp-idf-v4.1/components/esp32/panic.c:174

0x400e1c2f: s_prepare_reserved_regions at /home/jeremy/esp/esp-idf-v4.1/components/soc/src/memory_layout_utils.c:109
 (inlined by) soc_get_available_memory_regions at /home/jeremy/esp/esp-idf-v4.1/components/soc/src/memory_layout_utils.c:126

0x400d5035: heap_caps_init at /home/jeremy/esp/esp-idf-v4.1/components/heap/heap_caps_init.c:65

0x40081957: call_start_cpu0 at /home/jeremy/esp/esp-idf-v4.1/components/esp32/cpu_start.c:256

I seem to be having this exact problem: https://github.com/raphaelbs/esp32-cam-ai-thinker/issues/26 Even the addresses are exactly the same. But it seems there was no resolution, it just disappeared.
I unfortunately cannot attach my code, but I have attached the sdkconfig file.
sdkconfig.txt

I have been able to get this to fail with the hello world example. See attached.
overlap_error_test.zip

I have no idea how to explain this, but I have found there is a single Kconfig option causing this problem. If I set the config "Type of SPI RAM chip in use" to "Auto-detect", everything works fine. If I set it to "ESP-PSRAM64 or LY68L6400" then it crashes with the above error.

https://github.com/espressif/esp-idf/pull/5373

@jeremyherbert I was not able to get your "Auto-detect" fix to work for me.  Can you post your entire kconfig file?  There could be more than a couple of settings in play here.

Hi folks,
Apologies for the delay in merging the linked PR from @negativekelvin . We'll merge this ASAP.
In the meantime setting SPI RAM type to "Auto-detect" as mentioned should work.
@bill-orange if you're still having problems with this, could you please post some information about your hardware and the crash you are seeing/

Thank you for you offer of assistance.  It is likely that I am not implementing the SPI RAM type properly to form a fix.  I modified sdkconfig.default to include CONFIG_SPIRAM_TYPE_AUTO=y.  I suspect that was not what was needed,  here is the error.
D (1215) memory_layout: Checking 8 reserved memory ranges:␛[0m
D (1215) memory_layout: Reserved memory range 0x3f800000 - 0x40000000␛[0m
␛[0;31mE (1220) memory_layout: SOC_RESERVE_MEMORY_REGION region range 0x3f800000 - 0x40000000 overlaps with
0x3ffae000 - 0x3ffae6e0␛[0m
abort() was called at PC 0x400dc81b on core 0

ELF file SHA256: 1ecf195c45fe00f3

Backtrace: 0x40089370:0x3ffe34a0 0x4008981c:0x3ffe34d0 0x400dc81b:0x3ffe3500 0x400dc8c0:0x3ffe3540 0x400db895:0x3ffe3890 0x40082599:0x3ffe3c40 0x4007931a:0x3ffe3c80 |<-CORRUPTED

Rebooting...

I have been working the an AI-Thinker ESP32-CAM.  The only code I have tried to get working is the motion detect example here:

Any advice you can offer would be greatly appreciated.

Hi @bill-orange
It looks like your ESP32-CAM has an 8MB SPIRAM chip. I can't explain why enabling automatic detection hasn't fixed the problem though, maybe the sdkconfig.defaults change hasn't been applied and your project is still using a custom sdkconfig?
Could you please open menuconfig and manually check this value is set to Auto-detect in the menu?
https://docs.espressif.com/projects/esp-idf/en/stable/api-reference/kconfig.html#config-spiram-type

Your insight was correct sdkconfig.defaults changes were apparently not being applied.  I modified sdkconfig directly as follows:
#CONFIG_SPIRAM_SIZE=-1
CONFIG_SPIRAM_TYPE=Auto-detect
The memory crash is gone.  Commenting out the first line above seemed the be part of the magic.
Thanks!

Hello,
solved this like this:
in soc_memory_layout.c
#if CONFIG_SPIRAM_SIZE == -1
// Assume we need to reserve 4MB in the auto-detection case
#define RESERVE_SPIRAM_SIZE (4*1024*1024)
#elif CONFIG_SPIRAM_SIZE == (8*1024*1024)
// Assume we need to reserve 4MB in the case the 8MB SPIRAM is populated
#define RESERVE_SPIRAM_SIZE (4*1024*1024)
#else
#define RESERVE_SPIRAM_SIZE CONFIG_SPIRAM_SIZE
#endif


Mocha Tests ... Want them?

Hey Jed,
I've been working on a new project utilizing KeystoneJS for the first time, and have been leveraging a lot of the logic here for a lot of user management, etc...
With that, I've also set up a testing framework for Mocha and added near 100% test coverage for much of the bits I've used -- would you be interested in seeing that? I'm happy to pull everything I've done back together and open up a pull request to implement the test framework and test cases.

That would be fantastic @jhensley!