Configure Renovate

Welcome to Renovate! This is an onboarding PR to help you understand and configure settings before regular Pull Requests begin.
🚦 To activate Renovate, merge this Pull Request. To disable Renovate, simply close this Pull Request unmerged.

Detected Package Files

.github/workflows/build.yml (github-actions)
build.gradle (gradle)
gradle.properties (gradle)
settings.gradle (gradle)
gradle/wrapper/gradle-wrapper.properties (gradle-wrapper)

What to Expect
With your current configuration, Renovate will create 15 Pull Requests:

Update dependency com.google.jimfs:jimfs to v1.2

Schedule: ["at any time"]
Branch name: renovate/com.google.jimfs-jimfs-1.x
Merge into: master
Upgrade com.google.jimfs:jimfs to 1.2

Update dependency net.fabricmc:fabric-loader to v0.11.6

Schedule: ["at any time"]
Branch name: renovate/net.fabricmc-fabric-loader-0.x
Merge into: master
Upgrade net.fabricmc:fabric-loader to 0.11.6

Update dependency net.fabricmc:fabric-mixin-compile-extensions to v0.4.4

Schedule: ["at any time"]
Branch name: renovate/net.fabricmc-fabric-mixin-compile-extensions-0.x
Merge into: master
Upgrade net.fabricmc:fabric-mixin-compile-extensions to 0.4.4

Update dependency net.fabricmc:sponge-mixin to v0.9.4+mixin.0.8.2

Schedule: ["at any time"]
Branch name: renovate/net.fabricmc-sponge-mixin-0.x
Merge into: master
Upgrade net.fabricmc:sponge-mixin to 0.9.4+mixin.0.8.2

Update dependency fabric-loom:fabric-loom.gradle.plugin to v0.9.10

Schedule: ["at any time"]
Branch name: renovate/fabric-loom-fabric-loom.gradle.plugin-0.x
Merge into: master
Upgrade fabric-loom:fabric-loom.gradle.plugin to 0.9.10

Update dependency gradle to v6.9

Schedule: ["at any time"]
Branch name: renovate/gradle-6.x
Merge into: master
Upgrade gradle to 6.9

Update dependency net.fabricmc.fabric-api:fabric-api to v0.35.2+1.17

Schedule: ["at any time"]
Branch name: renovate/net.fabricmc.fabric-api-fabric-api-0.x
Merge into: master
Upgrade net.fabricmc.fabric-api:fabric-api to 0.35.2+1.17

Update dependency net.fabricmc:access-widener to v1.1.0

Schedule: ["at any time"]
Branch name: renovate/net.fabricmc-access-widener-1.x
Merge into: master
Upgrade net.fabricmc:access-widener to 1.1.0

Update dependency net.fabricmc:tiny-mappings-parser to v0.3.0+build.17

Schedule: ["at any time"]
Branch name: renovate/net.fabricmc-tiny-mappings-parser-0.x
Merge into: master
Upgrade net.fabricmc:tiny-mappings-parser to 0.3.0+build.17

Update dependency net.fabricmc:tiny-remapper to v0.4.2

Schedule: ["at any time"]
Branch name: renovate/net.fabricmc-tiny-remapper-0.x
Merge into: master
Upgrade net.fabricmc:tiny-remapper to 0.4.2

Update dependency net.fabricmc:yarn to v1.17.1-pre1+build.1

Schedule: ["at any time"]
Branch name: renovate/net.fabricmc-yarn-1.x
Merge into: master
Upgrade net.fabricmc:yarn to 1.17.1-pre1+build.1

Update actions/setup-java action to v2

Schedule: ["at any time"]
Branch name: renovate/actions-setup-java-2.x
Merge into: master
Upgrade actions/setup-java to v2

Update dependency gradle to v7

Schedule: ["at any time"]
Branch name: renovate/gradle-7.x
Merge into: master
Upgrade gradle to 7.1

Update dependency net.fabricmc:yarn to v20

Schedule: ["at any time"]
Branch name: renovate/net.fabricmc-yarn-20.x
Merge into: master
Upgrade net.fabricmc:yarn to 20w14infinite+build.4

Update dependency org.jetbrains:annotations to v21

Schedule: ["at any time"]
Branch name: renovate/org.jetbrains-annotations-21.x
Merge into: master
Upgrade org.jetbrains:annotations to 21.0.1

⚠ Dependency Lookup Warnings ⚠
Please correct - or verify that you can safely ignore - these lookup failures before you merge this PR.

Failed to look up dependency com.mojang:minecraft
Failed to look up dependency net_fabricmc_yarn_1_16_5_1_16_5_build_6_v2.net.fabricmc.fabric-api:fabric-api
Failed to look up dependency net_fabricmc_yarn_1_16_5_1_16_5_build_6_v2.net.fabricmc.fabric-api:fabric-api-lookup-api-v1
Failed to look up dependency net_fabricmc_yarn_1_16_5_1_16_5_build_6_v2.net.fabricmc.fabric-api:fabric-biome-api-v1
Failed to look up dependency net_fabricmc_yarn_1_16_5_1_16_5_build_6_v2.net.fabricmc.fabric-api:fabric-blockrenderlayer-v1
Failed to look up dependency net_fabricmc_yarn_1_16_5_1_16_5_build_6_v2.net.fabricmc.fabric-api:fabric-commands-v0
Failed to look up dependency net_fabricmc_yarn_1_16_5_1_16_5_build_6_v2.net.fabricmc.fabric-api:fabric-command-api-v1
Failed to look up dependency net_fabricmc_yarn_1_16_5_1_16_5_build_6_v2.net.fabricmc.fabric-api:fabric-containers-v0
Failed to look up dependency net_fabricmc_yarn_1_16_5_1_16_5_build_6_v2.net.fabricmc.fabric-api:fabric-content-registries-v0
Failed to look up dependency net_fabricmc_yarn_1_16_5_1_16_5_build_6_v2.net.fabricmc.fabric-api:fabric-crash-report-info-v1
Failed to look up dependency net_fabricmc_yarn_1_16_5_1_16_5_build_6_v2.net.fabricmc.fabric-api:fabric-dimensions-v1
Failed to look up dependency net_fabricmc_yarn_1_16_5_1_16_5_build_6_v2.net.fabricmc.fabric-api:fabric-entity-events-v1
Failed to look up dependency net_fabricmc_yarn_1_16_5_1_16_5_build_6_v2.net.fabricmc.fabric-api:fabric-events-interaction-v0
Failed to look up dependency net_fabricmc_yarn_1_16_5_1_16_5_build_6_v2.net.fabricmc.fabric-api:fabric-events-lifecycle-v0
Failed to look up dependency net_fabricmc_yarn_1_16_5_1_16_5_build_6_v2.net.fabricmc.fabric-api:fabric-game-rule-api-v1
Failed to look up dependency net_fabricmc_yarn_1_16_5_1_16_5_build_6_v2.net.fabricmc.fabric-api:fabric-item-api-v1
Failed to look up dependency net_fabricmc_yarn_1_16_5_1_16_5_build_6_v2.net.fabricmc.fabric-api:fabric-item-groups-v0
Failed to look up dependency net_fabricmc_yarn_1_16_5_1_16_5_build_6_v2.net.fabricmc.fabric-api:fabric-keybindings-v0
Failed to look up dependency net_fabricmc_yarn_1_16_5_1_16_5_build_6_v2.net.fabricmc.fabric-api:fabric-key-binding-api-v1
Failed to look up dependency net_fabricmc_yarn_1_16_5_1_16_5_build_6_v2.net.fabricmc.fabric-api:fabric-lifecycle-events-v1
Failed to look up dependency net_fabricmc_yarn_1_16_5_1_16_5_build_6_v2.net.fabricmc.fabric-api:fabric-loot-tables-v1
Failed to look up dependency net_fabricmc_yarn_1_16_5_1_16_5_build_6_v2.net.fabricmc.fabric-api:fabric-mining-levels-v0
Failed to look up dependency net_fabricmc_yarn_1_16_5_1_16_5_build_6_v2.net.fabricmc.fabric-api:fabric-models-v0
Failed to look up dependency net_fabricmc_yarn_1_16_5_1_16_5_build_6_v2.net.fabricmc.fabric-api:fabric-networking-blockentity-v0
Failed to look up dependency net_fabricmc_yarn_1_16_5_1_16_5_build_6_v2.net.fabricmc.fabric-api:fabric-networking-v0
Failed to look up dependency net_fabricmc_yarn_1_16_5_1_16_5_build_6_v2.net.fabricmc.fabric-api:fabric-object-builders-v0
Failed to look up dependency net_fabricmc_yarn_1_16_5_1_16_5_build_6_v2.net.fabricmc.fabric-api:fabric-particles-v1
Failed to look up dependency net_fabricmc_yarn_1_16_5_1_16_5_build_6_v2.net.fabricmc.fabric-api:fabric-registry-sync-v0
Failed to look up dependency net_fabricmc_yarn_1_16_5_1_16_5_build_6_v2.net.fabricmc.fabric-api:fabric-renderer-indigo
Failed to look up dependency net_fabricmc_yarn_1_16_5_1_16_5_build_6_v2.net.fabricmc.fabric-api:fabric-renderer-registries-v1
Failed to look up dependency net_fabricmc_yarn_1_16_5_1_16_5_build_6_v2.net.fabricmc.fabric-api:fabric-rendering-data-attachment-v1
Failed to look up dependency net_fabricmc_yarn_1_16_5_1_16_5_build_6_v2.net.fabricmc.fabric-api:fabric-rendering-fluids-v1
Failed to look up dependency net_fabricmc_yarn_1_16_5_1_16_5_build_6_v2.net.fabricmc.fabric-api:fabric-rendering-v0
Failed to look up dependency net_fabricmc_yarn_1_16_5_1_16_5_build_6_v2.net.fabricmc.fabric-api:fabric-screen-api-v1
Failed to look up dependency net_fabricmc_yarn_1_16_5_1_16_5_build_6_v2.net.fabricmc.fabric-api:fabric-screen-handler-api-v1
Failed to look up dependency net_fabricmc_yarn_1_16_5_1_16_5_build_6_v2.net.fabricmc.fabric-api:fabric-structure-api-v1
Failed to look up dependency net_fabricmc_yarn_1_16_5_1_16_5_build_6_v2.net.fabricmc.fabric-api:fabric-object-builder-api-v1
Failed to look up dependency net_fabricmc_yarn_1_16_5_1_16_5_build_6_v2.net.fabricmc.fabric-api:fabric-tool-attribute-api-v1
Failed to look up dependency net_fabricmc_yarn_1_16_5_1_16_5_build_6_v2.net.fabricmc.fabric-api:fabric-tag-extensions-v0
Failed to look up dependency net_fabricmc_yarn_1_16_5_1_16_5_build_6_v2.net.fabricmc.fabric-api:fabric-textures-v0
Failed to look up dependency net_fabricmc_yarn_1_16_5_1_16_5_build_6_v2.net.fabricmc.fabric-api:fabric-networking-api-v1
Failed to look up dependency net_fabricmc_yarn_1_16_5_1_16_5_build_6_v2.net.fabricmc.fabric-api:fabric-renderer-api-v1
Failed to look up dependency net_fabricmc_yarn_1_16_5_1_16_5_build_6_v2.net.fabricmc.fabric-api:fabric-rendering-v1
Failed to look up dependency net_fabricmc_yarn_1_16_5_1_16_5_build_6_v2.net.fabricmc.fabric-api:fabric-api-base
Failed to look up dependency net_fabricmc_yarn_1_16_5_1_16_5_build_6_v2.net.fabricmc.fabric-api:fabric-resource-loader-v0
Failed to look up dependency net_fabricmc_yarn_1_16_5_1_16_5_build_6_v2.net.fabricmc:fabric-loader

Files affected: build.gradle, gradle.properties, settings.gradle

❓ Got questions? Check out Renovate's Docs, particularly the Getting Started section.
If you need any further assistance then you can also request help here.

This PR has been generated by Renovate Bot.

Renovate is disabled
Renovate is disabled due to lack of config. If you wish to reenable it, you can either (a) commit a config file to your base branch, or (b) rename this closed PR to trigger a replacement onboarding PR.


DE i18n the localization docs

I18n the localization documentation

@mkorbi if you squash and force-push the commits in this PR, that should also nudge Prow / Tide / Netlify to retest it.

@bene2k1 fixed

/lgtm
/approve


RETRO/SPIKE: More active involvement upstream

For this ticket, we only needed For this ticket, we only needed a list of the communities we are and want to be involved - under the domain of model serving.
Currently, the list of upstream communities we are and should be active collaborating in are the following:

KServe - For KServe and ModelMesh projects.

This is the basic stack of model serving in ODH.
Indirectly, we may need to be involved on Istio and KNative communities. Perhaps, only as users (e.g. asking questions) and not as code contributors.

OpenVINO - Because of OVMS, which is the model server that is currently provided supported out of the box in OpenDataHub. Supported  model formats include Tensorflow, ONNX, PyTorch. It supports using Intel GPUs for inference, and also Intel CPUs.
Triton - This is NVIDIA's Inference server. Some of the supported model formats are TensorRT, TensorFlow, PyTorch, ONNX, OpenVINO. It supports using NVidia GPUs for inference, and can also use x86 ARM CPUs.
Caikit and TGIS - Since these seem to be a good choice for LLMs.


cocoon is using libs that are being deprecated soon

When running the dashboard locally with dashboard$ flutter run -d chrome --web-port=8080 we see the message:
Your client application uses libraries for user authentication or authorization that will soon be deprecated. See the Migration Guide for more information.

\cc @godofredoc @keyonghan  no idea what the timeline is, but something we should look at.

isn't this coming from google_sign_in package? Guess it is more about the package being updated than cocoon itself no?

Just found this issue. Please follow:

https://github.com/flutter/flutter/issues/88084

isn't this coming from google_sign_in package? Guess it is more about the package being updated than cocoon itself no?

After the google sign in plugin support, we also need to update cocoon to migrate js library follow: https://developers.google.com/identity/gsi/web/guides/migration#html_and_javascript

@keyonghan do you have any JS code that uses the JS library directly? If not, I think that the update to package:google_sign_in_web should suffice for Cocoon?

Yeah. Here it is: https://github.com/flutter/cocoon/blob/main/dashboard/web/index.html#L35

@keyonghan I don't think it is related. This is for analytics... It has to stay the same.

Aha, I see. AFAIK the only thing that is being deprecated from that file is the gapi.auth2 library, but other gapi libraries will continue working as normal. See this example where one of the new authentication flows is being used in conjunction with gapi.client.calendar: Working with the Google APIs JavaScript library.
One thing you can do in cocoon is follow this procedure to Identify affected code and testing (using the G_AUTH2_MIGRATION cookie), but I'm 99% sure the only offender is going to be the google_sign_in_web plugin.

Thanks all for the explanations! We will track https://github.com/flutter/flutter/issues/88084 and follow up from there.


Why us

Current coverage is 47.18%

Merging #151 into master will not affect coverage as of 99bf4e6

@@            master    #151   diff @@
======================================
  Files           18      18
  Stmts          284     284
  Branches         0       0
  Methods          0       0
======================================
  Hit            134     134
  Partial          0       0
  Missed         150     150

Review entire Coverage Diff as of 99bf4e6

Powered by Codecov. Updated on successful CI builds.


Cosmos: investor-cosmos module

We need an investor-cosmos module with all of the cosmos staking and unstaking functionality.
It will live next to the investor-yearn module.
Currently we dont know what the common interface for the investor modules will look like. Majorhayes was suggesting we should try to get a proof-of-concept working for cosmos before making the interface common between investor-yearn and investor-cosmos

no longer relevant after 3/23 meeting


Bootstrap 4 theme

Hi all,
I'm keen to contribute a Bootsrap 4 theme. Where do I begin? And anything I need to know before I start? Is it too soon for a BS4 theme? I'm on a project converting to BS4 and it would be beneficial to have this.
Cheers,

I'm thinking of rather adding an optional way of externalizing the theme templates. That way, anyone can implement their own flavor without incorporating it into ui-select

We also came here looking for a Bootstrap 4 theme 👍

+1

+1

I'm thinking of rather adding an optional way of externalizing the theme templates. That way, anyone can implement their own flavor without incorporating it into ui-select

@silentFred You can already do this, see src/uiSelectDirective.js#L9:
    templateUrl: function(tElement, tAttrs) {
      var theme = tAttrs.theme || uiSelectConfig.theme;
      return theme + (angular.isDefined(tAttrs.multiple) ? '/select-multiple.tpl.html' : '/select.tpl.html');
    }

Simply specify your own theme name (eg. bootstrap4 and it will load those templates).
You'll probably want to run the templates into the template cache as ui-select does in dist/select.js#L2376

Closing this as BS4 is still in alpha, I don't see much point to maintain against an unstable dependency.
PRs can still be submitted or better, open a new repo and provide a link. :smiley:

I started on a fork that is intended to support a Bootstrap 4 theme. https://github.com/bmontgomery/ui-select

Is anyone developing a bootstrap 4 theme as its in beta?

+1

I just added some css, cause js was toggling needed class!
.ui-select-bootstrap.open .dropdown-menu {   display: block; }

I started to work on a pure css adapter that intends to make bootstrap theme fully support Bootstrap v4. https://github.com/francisfontoura/angularjs.ui-select.bootstrap4.shim.css


fix CORS

What this PR does / why we need it:
Special notes for your reviewer:
If applicable:

[ ] this PR contains documentation
[ ] this PR contains unit tests
[ ] this PR has been tested for backwards compatibility

@itaijj Is this PR still needed on your end? I see that @joerunde added suggestions for how to make this configurable which we'll need implemented before merging. It also looks like we need to sort out the DCO failure still.

@itaijj This PR looks to have gone stale. I'm going to close it now, but we can revisit Joe's suggestions if you end up needing it in the future

I found a solution by inheritance from RuntimeHTTPServer, it also solves other issues with doing extra configs to fastAPI

Great! Glad that solution is a working path for you


Refactor solid

Current coverage is 53.27%

Branch #3 has no coverage reports uploaded yet.

No diff could be generated. No reports for master found.

Powered by Codecov. Updated on successful CI builds.


Node2D.edit_set_pivot should only set pivot not position of node

Operating system or device - Godot version:
v2.1.official.stable
edit_set_pivot moves node as well (tried with Sprite) but as I understand from the docs it should only move the pivot.

I looked at it but under the hood it just sets the offset and I think that's wrong, I think it should behave like the "click to change object's rotation pivot" tool.

First of all thank you for your report and sorry for the delay.
We released Godot 3.0 in January 2018 after 18 months of work, fixing many old issues either directly, or by obsoleting/replacing the features they were referring to.
We still have hundreds of issues whose relevance/reproducibility needs to be checked against the current stable version, and that's where you can help us.
Could you check if the issue that you described initially is still relevant/reproducible in Godot 3.0 or any newer version, and comment about it here?
For bug reports, please also make sure that the issue contains detailed steps to reproduce the bug and, if possible, a zipped project that can be used to reproduce it right away. This greatly speeds up debugging and bugfixing tasks for our contributors.
Our Bugsquad will review this issue more in-depth in 15 days, and potentially close it if its relevance could not be confirmed.
Thanks in advance.
Note: This message is being copy-pasted to many "stale" issues (90+ days without activity). It might happen that it is not meaningful for this specific issue or appears oblivious of the issue's context, if so please comment to notify the Bugsquad about it.

edit_set_pivot isn't available in v3 so I'll close this


Update README.md

Add some references!

Please add report generation papers on TMM, TMI, and MICCAI 2023, thanks!


How do you correctly subclass an Accelerator?

❓ Questions and Help
What is your question?
I am trying to subclass DDPCPUSpawnAccelerator for test purposes.
Trainer now has an accelerator argument for you to pass an accelerator object. On the other hand, the accelerator has a trainer argument. I asume the later can be initialized to None to avoid this chicken and egg issue.
However, the following snippet seems to get stuck.
Code
from pytorch_lightning import Trainer
from pytorch_lightning.accelerators import DDPCPUSpawnAccelerator
from pytorch_lightning.cluster_environments import TorchElasticEnvironment
from tests.base.boring_model import BoringModel

class TestAccelerator(DDPCPUSpawnAccelerator):
    def __init__(self, nprocs):
        super().__init__(None, nprocs, cluster_environment=TorchElasticEnvironment())

def test_accelerator(tmpdir):
    model = BoringModel()
    trainer = Trainer(
        default_root_dir=tmpdir,
        limit_train_batches=2,
        limit_val_batches=2,
        max_epochs=2,
        log_every_n_steps=1,
        weights_summary=None,
        accelerator=TestAccelerator(2)
    )
    trainer.fit(model)

What's your environment?

OS: Linux
Packaging: pip
Version: Master

Okay, the error was not passing also num_processes=2 to the Trainer. I thought it wasn't required with a custom accelerator.


Skyline: Fix case causing PathTooLongException to reach the exception web page

Show the message to the user instead to allow them to shorten the path

Looks good to me.
Before "SkylineWindow.HasFileToOpen" was added, we used to see a PathTooLongException in "SkylineWindow.OpenFile". It looks like your fix here will also prevent us from getting hitting the same error later on.


The SSID password has a maximum of 16 characters

Is it possible to increase the SSID password field to 24 characters?

@marfi44 Please check the new firmware (230523 and later)

Thank you for the quick response to changing the length of the SSID
password. However, the new version 230523 is unstable. After uploading
the firmware and connecting to IP: <IP_ADDRESS>, the connection still
disconnects after 2-3 seconds. Tested on D1 mini and D1 mini PRO boards
with the same result (ver.230419-client will be displayed on the WEB
page). The previous version 230420 runs correctly on both boards.
marfi44
Dňa 23. 5. 2023 o 8:57 Alexander napísal(a):

@marfi44 https://github.com/marfi44 Please check the new firmware
(230523 and later)
—
Reply to this email directly, view it on GitHub
https://github.com/alidonet/GC97_ESP/issues/4#issuecomment-1558645742,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AWMGP4BOOCMNHG7MQWRBCOLXHRNWFANCNFSM6AAAAAAYK2NGP4.
You are receiving this because you were mentioned.Message ID:
@.***>

@marfi44 As a workaround, you can use version 230523 to set up a right one SSID and after that perform the firmware rollback to the previous, stable version. The old version could work without any issues with a long SSID.
In fact, I didn't make any changes for the code itself, only for the main web-page, so I don't know that can be a reason for unstable work. In any case, I'll check it. Thanks for feedback.

The problem is the web-page itself (version 230523). At start-up, it won't hold the connection long enough for me to write out and send the SSID data. The old version is OK. Even the connection with the new web-page is problematic. It does not start immediately. I have to initialize it several times. The display image remains gray, not green with data, as in the previous version. The other pages are not pre-filled either (MQTT, port, ...). The WiFi connection (<IP_ADDRESS>) only manages to connect for a few seconds, then disconnects and can be reconnected for maybe 10 tries. And it is possible to connect to the web-page only sporadically.

@marfi44 I guess, it was a problem with build the firmware. I re-assembly the code and pushed it as 230525 (instead of 230523). Please try that version and let me know.
In case of issues, please send me details from the serial port logs (19200 baud speed), if this is possible for you. Thank you.

I tried the new firmware version 230525 with the same result. After uploading the firmware and connecting via WiFi to the AP 8266, the connection is maintained for about 2-3 seconds. Then it falls off and it is possible to connect again maybe in 20 attempts, but also only for a short time. All fields in the web page - Settings are empty.
GC97-xxxx and ESPxxx are shown as APs (ESPxxx cannot be connected here). I'm trying it without connecting to the GC97.
D1_mini.txt
D1_mini_Pro.txt

@marfi44 Thanks for feedback with logs: it's crashing and reboot due to RTE. I'll investigate it more and try to reproduce/fix it.

@marfi44 As a workaround: use the latest stable version 230420 and try to setup the settings manually as requests:
http://<IP_ADDRESS>/cmd/options?ssid=**SSID**&ssid_psw=**PSW**
where you need to replace xxx* parts with your credentials.
Please note that in case of saving the settings via web UI you'll probably need to do this request again since the SSID can be truncated. So you can set all other settings and update the SSID manually at the end.

Message ID: @.***>

I tried the new version 230526 - it works great, also MQTT (tried
without GC97 for now - I'll try it together at the weekend, but
probably won't be a problem here). Thank you very much for your
willingness.

😎


Fix minor issue in UG

PR linked to #86
Fix header formatting issues

Codecov Report

Merging #89 (4cf55e8) into master (a52bfe4) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master      #89   +/-   ##
=========================================
  Coverage     76.96%   76.96%
  Complexity      780      780
=========================================
  Files           114      114
  Lines          2301     2301
  Branches        264      264
=========================================
  Hits           1771     1771
  Misses          447      447
  Partials         83       83

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more


Use semantic grid

I was wondering if Milligram wouldn't become really really awesome if the grids were semantic like Bourbon neat for example. Instead of having to apply a CSS class the whole grid could be defined within the CSS. What do you think @cjpatoilo ?

@corsonr The idea seems to be great. We need to work to develop a better grid system without forgetting to make it as light as possible.

Are CSS Grids something to have in mind when developing the better grid system, @cjpatoilo?

@corsonr @franzejr Can you explain more for your ideas?
I plan to improve the grid system of the Milligram in the next major version.

Why not remove the grid component completely? You can easily do columns and grids through CSS grids. No point using flexbox and/or abusing classes like column-50.column-offset-25.

Why not remove the grid component completely? You can easily do columns and grids through CSS grids. No point using flexbox and/or abusing classes like column-50.column-offset-25.

Milligram provides a minimal setup of styles for a fast and clean starting point.

@jasny I agree that there is some reason in your words.
Today, use CSS Grid and Flexbox is very ease but I disagree about removing the grid component.
The grid component in Milligram does not cost many kb and the main motivation to keep this feature is to provide a minimal setup of styles for a fast and clean starting point.
So I can't see a legitimate reason to remove the grid component from Milligram.

Why not remove the grid component completely? You can easily do columns and grids through CSS grids. No point using flexbox and/or abusing classes like column-50.column-offset-25.

@jasny I agree that there is some reason in your words.
Today, use CSS Grid and Flexbox is very ease but I disagree about removing the grid component.
The grid component in Milligram does not cost many kb and the main motivation to keep this feature is to provide a minimal setup of styles for a fast and clean starting point.
So I can't see a legitimate reason to remove the grid component from Milligram.

Guys, for now, I will close this issue.
Please, feel free to reopen or open a new one.


Spike: Backstage theme customization

In our call with a customer we learned that making the dev portal match your brand will be important for adoption by our customers.
Let's look into the customization options for the look and feel. As a goal I propose:

Set logo, colors, and fonts for the Giant Swarm dev portal, to match the Giant Swarm branding.
Do this in a way that it gets enabled by the dev portal configuration and does not affect the default look of our Backstage app

More info: https://backstage.io/docs/getting-started/app-custom-theme/

I asked Marat about some guidelines, as I have no real insight regarding what colors we are using currently.


Support local OSX SDK

Toolchain setup
http_archive(
    name = "bazel-zig-cc",
    sha256 = "e9f82bfb74b3df5ca0e67f4d4989e7f1f7ce3386c295fd7fda881ab91f83e509",
    strip_prefix = "bazel-zig-cc-v1.0.1",
    urls = ["https://github.com/uber/bazel-zig-cc/archive/v1.0.1.tar.gz"],
)

load("@bazel-zig-cc//toolchain:defs.bzl", zig_toolchains = "toolchains")

zig_toolchains()

register_toolchains(
    "@zig_sdk//toolchain:linux_amd64_gnu.2.34",
    "@zig_sdk//toolchain:linux_arm64_gnu.2.34",
    "@zig_sdk//toolchain:darwin_amd64",
    "@zig_sdk//toolchain:darwin_arm64",
)

Error outputs
> bazel build @com_github_mattn_go_ieproxy//...
ERROR: /private/var/tmp/_bazel_sluongng/06e573a93bc2d6a9cad4ad41f00b4310/external/com_github_mattn_go_ieproxy/BUILD.bazel:57:8: GoCompilePkg external/com_github_mattn_go_ieproxy/go-ieproxy_test.internal.a failed: (Exit 1): builder failed: error executing command (from target @com_github_mattn_go_ieproxy//:go-ieproxy_test) bazel-out/darwin_arm64-opt-exec-2B5CBBC6/bin/external/go_sdk_darwin_arm64/builder_reset/builder compilepkg -sdk external/go_sdk_darwin_arm64 -installsuffix darwin_arm64 -src ... (remaining 73 arguments skipped)

Use --sandbox_debug to see verbose messages from the sandbox and retain the sandbox build root for debugging
buildbuddy/external/com_github_mattn_go_ieproxy/ieproxy_darwin.go:7:10: fatal error: 'CFNetwork/CFProxySupport.h' file not found
#include <CFNetwork/CFProxySupport.h>
         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.
compilepkg: error running subcommand external/go_sdk_darwin_arm64/pkg/tool/darwin_arm64/cgo: exit status 2

Gazelle generated build files
> cat /private/var/tmp/_bazel_sluongng/06e573a93bc2d6a9cad4ad41f00b4310/external/com_github_mattn_go_ieproxy/BUILD.bazel
load("@io_bazel_rules_go//go:def.bzl", "go_library", "go_test")

go_library(
    name = "go-ieproxy",
    srcs = [
        "ieproxy.go",
        "ieproxy_darwin.go",
        "ieproxy_unix.go",
        "ieproxy_windows.go",
        "kernel32_data_windows.go",
        "pac_darwin.go",
        "pac_unix.go",
        "pac_windows.go",
        "proxy_middleman.go",
        "proxy_middleman_darwin.go",
        "proxy_middleman_unix.go",
        "proxy_middleman_windows.go",
        "utils.go",
        "winhttp_data_windows.go",
    ],
    cgo = True,
    clinkopts = select({
        "@io_bazel_rules_go//go/platform:darwin": [
            "-framework CFNetwork",
            "-framework CoreFoundation",
        ],
        "@io_bazel_rules_go//go/platform:ios": [
            "-framework CFNetwork",
            "-framework CoreFoundation",
        ],
        "//conditions:default": [],
    }),
    importpath = "github.com/mattn/go-ieproxy",
    visibility = ["//visibility:public"],
    deps = select({
        "@io_bazel_rules_go//go/platform:darwin": [
            "@org_golang_x_net//http/httpproxy",
        ],
        "@io_bazel_rules_go//go/platform:ios": [
            "@org_golang_x_net//http/httpproxy",
        ],
        "@io_bazel_rules_go//go/platform:windows": [
            "@org_golang_x_net//http/httpproxy",
            "@org_golang_x_sys//windows",
            "@org_golang_x_sys//windows/registry",
        ],
        "//conditions:default": [],
    }),
)

alias(
    name = "go_default_library",
    actual = ":go-ieproxy",
    visibility = ["//visibility:public"],
)

go_test(
    name = "go-ieproxy_test",
    srcs = [
        "darwin_test.go",
        "example_test.go",
        "utils_test.go",
        "windows_test.go",
    ],
    embed = [":go-ieproxy"],
)

Bazel version is 6.0.0 on M1 Mac.
Using Grail's toolchain, the sysroot is set to OSX SDK dynamically with https://github.com/grailbio/bazel-toolchain/blob/069ee4e20ec605a6c76c1798658e17175b2eb35e/toolchain/internal/sysroot.bzl#L24-L39
Ultimately this should affect cxx_builtin_include_directories and builtin_sysroot attribute when call cc_common. create_cc_toolchain_config_info()

W are not planning to add support non-hermetic osx compilation with bazel-zig-cc. If we go with osx support, it needs to be hermetic.
The biggest problem is .tbd files, which are gray area (feel free to search for tbd in ziglang issues).
We are open, though, to support tbd files via a user-provided http_archive.

If there were some way of providing the sysroot it would be possible to set this up.

If there were some way of providing the sysroot it would be possible to set this up.

I have no idea. It's probably not too difficult, but I never tried. We did not get to the point to try it at Uber too.
If someone in the community needs it and implements support for this sysroot, we will review/accept the PR.

My research led me to rules_apple where cc_library could be linked like this https://github.com/bazelbuild/rules_apple/blob/master/test/starlark_tests/resources/kext_resources/BUILD
I have not tested whether this copt could be added to rules_go just yet, but if it could then that would solve my problem.
@motiejus how do you solve building application with transitive deps depending on MacOS libraries like this? Do you simply block these deps from being used at Uber entirely?

@motiejus how do you solve building application with transitive deps depending on MacOS libraries like this? Do you simply block these deps from being used at Uber entirely?

I have only (and by extension Uber) used zig c++ for building Linux targets; I have not built anything non-trivial for OSX with Darwin except the launcher, which does not need any more frameworks except CoreFoundation (thus trivial).
As for how to compile more OSX applications, here are the rough steps:

Background reading: https://github.com/ziglang/zig/issues/1349#issuecomment-1028332574
Implement ability to specify a Darwin sysroot (via http_archive?) and attach it to a particular Darwin toolchain.
Configure the Darwin toolchain to specify the right path to the sysroot, when invoked.

You are welcome to wait (Uber may get to it, but I can't promise anything; someone might as well do it too), implement this yourself or ask/pay someone in the community to implement it for you. Like I said before, if we get a patch that adds a .tbd sysroot support for Darwin targets, we will happily merge and maintain it.

[...] except the launcher, which does not need any more frameworks except CoreFoundation (thus trivial).

Is there something to do to have access to CoreFoundation? We recently updated our dependency on protobuf that since v22.0 depends on abseil that itself internally depends on CoreFoundation:
https://github.com/abseil/abseil-cpp/blob/4ff6968df3833b11f9ab063675126b1562b8b73b/absl/time/internal/cctz/BUILD.bazel#L56-L60
Since then, building any go_library that depends on google libraries that ship protos on a mac fails with that error:
/private/var/tmp/_bazel_user/b36a059997bad77ac57dde217c426f28/external/com_google_absl/absl/time/internal/cctz/BUILD.bazel:32:11: Compiling absl/time/internal/cctz/src/time_zone_lookup.cc [for tool] failed: (Exit 1): sandbox-exec failed: error executing command
  (cd /private/var/tmp/_bazel_user/b36a059997bad77ac57dde217c426f28/sandbox/darwin-sandbox/503/execroot/project && \
  exec env - \
    PATH=/bin:/usr/bin:/usr/local/bin \
    PWD=/proc/self/cwd \
    TMPDIR=/var/folders/jh/bh0m7pbj2nqc2b8f5v98sl900000gp/T/ \
  /usr/bin/sandbox-exec -f /private/var/tmp/_bazel_user/b36a059997bad77ac57dde217c426f28/sandbox/darwin-sandbox/503/sandbox.sb /var/tmp/_bazel_user/install/202e556d99f024ca401d77f7be1827ad/process-wrapper '--timeout=0' '--kill_delay=15' '--stats=/private/var/tmp/_bazel_user/b36a059997bad77ac57dde217c426f28/sandbox/darwin-sandbox/503/stats.out' external/zig_sdk/tools/aarch64-macos-none/c++ -MD -MF bazel-out/darwin_arm64-opt-exec-2B5CBBC6/bin/external/com_google_absl/absl/time/internal/cctz/_objs/time_zone/time_zone_lookup.d '-frandom-seed=bazel-out/darwin_arm64-opt-exec-2B5CBBC6/bin/external/com_google_absl/absl/time/internal/cctz/_objs/time_zone/time_zone_lookup.o' '-DBAZEL_CURRENT_REPOSITORY="com_google_absl"' -iquote external/com_google_absl -iquote bazel-out/darwin_arm64-opt-exec-2B5CBBC6/bin/external/com_google_absl -no-canonical-prefixes -Wno-builtin-macro-redefined '-D__DATE__="redacted"' '-D__TIMESTAMP__="redacted"' '-D__TIME__="redacted"' '-mcpu=apple_m1' -O2 -DNDEBUG -g0 -Werror -w -g0 -c external/com_google_absl/absl/time/internal/cctz/src/time_zone_lookup.cc -o bazel-out/darwin_arm64-opt-exec-2B5CBBC6/bin/external/com_google_absl/absl/time/internal/cctz/_objs/time_zone/time_zone_lookup.o)
external/com_google_absl/absl/time/internal/cctz/src/time_zone_lookup.cc:26:10: fatal error: 'CoreFoundation/CFTimeZone.h' file not found
#include <CoreFoundation/CFTimeZone.h>
         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.

Our zig_toolchain is configured following the Use case: always compile with zig cc instructions, so with a list of unconditionally added toolchains, and with BAZEL_DO_NOT_DETECT_CPP_TOOLCHAIN=1.
Is it possible to have such a setup working? Or is zig-cc not an option anymore?
I'm posting this question here, because it's related to the original issue, but please let me know if I should create a new one.

Is it possible to have such a setup working? Or is zig-cc not an option anymore?

I am honestly surprised you were able to compile a real binary to osx using hermetic_cc_toolchain. :)

I'm posting this question here, because it's related to the original issue, but please let me know if I should create a new one.

I'm afraid it won't be actionable, since osx target is not supported in hermetic_cc_toolchain until someone does the work and implements it.

I am honestly surprised you were able to compile a real binary to osx using hermetic_cc_toolchain. :)

Yes it worked perfectly for several month, up until that dependency on abseil got added. I guess I got lucky and my use case was quite trivial, haha.

I'm afraid it won't be actionable, since osx target is not supported in hermetic_cc_toolchain until someone does the work and implements it.

Ok that was my understanding, I was just curious if somehow it was different if the only dependency on OSX SDK was CoreFoundation, but I guess not.
Thank you @motiejus, that's some incredible work you've done there!

This comes up often. Reopening for visibility. Also see my comment in https://github.com/uber/hermetic_cc_toolchain/issues/104#issuecomment-1643816202

I have some updates on that front: https://github.com/ziglang/zig/issues/10299#issuecomment-2045669073
Also, here is a repo rule to download and unpack it:
load(
    "@bazel_tools//tools/build_defs/repo:utils.bzl",
    "get_auth",
    "patch",
    "workspace_and_buildfile",
)

def _http_pkg_archive_impl(rctx):
    if rctx.attr.build_file and rctx.attr.build_file_content:
        fail("Only one of build_file and build_file_content can be provided.")
    rctx.download(
        url = rctx.attr.urls,
        output = ".downloaded.pkg",
        sha256 = rctx.attr.sha256,
        canonical_id = " ".join(rctx.attr.urls),
        auth = get_auth(rctx, rctx.attr.urls),
    )

    res = rctx.execute(["/usr/sbin/pkgutil", "--expand-full", ".downloaded.pkg", "tmp"])
    if res.return_code != 0:
        fail("Failed to extract package: {}".format(res.stdout))
    rctx.delete(".downloaded.pkg")

    strip_prefix = "tmp/Payload/"
    if rctx.attr.strip_prefix:
        strip_prefix += rctx.attr.strip_prefix + "/"
    extracted = rctx.path(strip_prefix)
    if not extracted.is_dir or not extracted.exists:
        fail("Extracted package does not contain expected directory: {}".format(strip_prefix))
    entries = extracted.readdir(watch = "no")
    for entry in entries:
        rctx.execute(["mv", str(entry), entry.basename])
    rctx.delete(extracted)
    workspace_and_buildfile(rctx)
    patch(rctx)

http_pkg_archive = repository_rule(
    _http_pkg_archive_impl,
    attrs = {
        "urls": attr.string_list(mandatory = True),
        "sha256": attr.string(mandatory = True),
        "strip_prefix": attr.string(),
        "build_file": attr.label(allow_single_file = True),
        "build_file_content": attr.string(),
        "workspace_file": attr.label(allow_single_file = True),
        "workspace_file_content": attr.string(),
    },
)

I have looked into this briefly; looks like those .pkg files are just a xar format which can be extracted by
Download using this https://github.com/ziglang/zig/issues/10299#issuecomment-2045669073
Extract the .pkg archive using bsdtar toolchain
Extract the Payload using https://github.com/NiklasRosenstein/pbzx which needs be compiled from source
and pipe into bsdtar again using the cpio format to lay out files on disk.

However, i believe this sysroot repository rule can be built separately and should live in https://github.com/bazelbuild/rules_apple


time-generated-field

Documentation of the time-generated-field header should include two things:

A more clear explanation that time-generated-field header is NOT the actual time, but a reference to a field in the posted JSON
A remark that the field referenced CANNOT be named TimeGenerated (else it gets ignored by the API)

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 657b5b68-4c41-841a-1110-67b9c2049e39
Version Independent ID: 2237ca0e-c552-7ee8-97ae-7034e51241d9
Content: Azure Monitor HTTP Data Collector API - Azure Monitor
Content Source: articles/azure-monitor/logs/data-collector-api.md
Service: azure-monitor
Sub-service: logs
GitHub Login: @bwren
Microsoft Alias: bwren

Thanks for the feedback! I have assigned the issue to the doc author to update appropriately.

The description of the field does include "The name of a field in the data that contains the timestamp of the data item." I'll go ahead and make the comment in the sample code a bit more clear though because I agree it can be a little confusing.
#please-close


new lexer request: arm assembler

(Original issue 678 created by droiddev on 2011-07-11T14:20:08.097434+00:00)
Here is an examples of such highlight (using snippets from ida pro)
https://www.droid-developers.org/wiki/Secure_Services
https://www.droid-developers.org/wiki/CPCAP
here its source on PHP/Geshi http://paste.pocoo.org/show/436107/

(Original comment by tshatch on 2012-11-01T16:44:56.035577+00:00)
The pastebin entry is gone, but I don't think it would be much help since GeSHI is GPL.

I'm closing all requests for lexers/formatters without a patch/PR.


Clarify broker info as advised in #64182

Clarify broker info under Approved app as advised in #64182

@mzmaili : Thanks for your contribution! The author(s) have been notified to review your proposed change.

#sign-off


@discardableResult works with try and try!, but not try?

Description
No response
Reproduction
@discardableResult
func foo() throws -> Int {}

func test() {
  try? foo() // warning: result of 'try?' is unused [expression_unused_optional_try]
}

Expected behavior
No warning
Environment
Swift version 5.11-dev (Swift 11ef6e58d869783)
Additional information
No response

Hi, I think I can fix this. but in lib/Sema/TypeCheckStmt.cpp there was a commit from 9 years ago:

Always warn when 'try?' is discarded.
rdar://problem/22195906
Swift SVN r31090

(as as? as! are all treated as non-discardable, and I feel like it's reasonable if try? behaves like them.)
I also found another corner case with discardable computed member reference, not sure if it's a expected behavior:
struct S {
    var s: S {
        @discardableResult
        get {
            return self
        }
    }
}

24 │
25 │ func test() {
26 │     S().s
   │         ╰─ warning: expression of type 'S' is unused
27 │ }
28 │

there was a commit from 9 years ago:

Always warn when 'try?' is discarded.
rdar://problem/22195906
Swift SVN r31090

Apparently, that was supposed to mean "warn even if the call returns Void", perhaps to encourage error handling or explicit discarding. @discardableResult should override these rules.

I also found another corner case with discardable computed member reference, not sure if it's a expected behavior

Is that even a reasonable thing to do? Either way the current behavior is a bug. Could you report it?

If you made up you mind to work on an issue (not just take it for maybe later), please give us a clear cue and ask us — you can ask me — to assign you. You can always hand it back if plans change on your side. Otherwise, there is really nothing wrong with someone else showing up and making progress faster, which we know is demotivating.


data-disable="true" adds "disabled" to classList not as attribute

As in the title, the submit-button is only superficially marked as "disabled". It's still active as long as "disabled" is only added to the classList (<button type="submit" class="btn btn-default disabled">) and not as an attribute (<button type="submit" class="btn btn-default" disabled>).
Is that behaviour intended?

Right now, I'm using the following css-hack to make the button truly disabled:
.my-btn.disabled {
        pointer-events: none;
}

It's intentional. Making the button truly disabled leads to a bad user experience because the user might not realize why they can't submit the form. With the button still clickable, the form errors will be revealed when the user tries to submit.

that may be the case - but the docs should reflect that :-)


do something about bounded funs:

Type of Kernel.max/2:
      {:type, 803, :bounded_fun,
        [
          {:type, 803, :fun,
            [
              {:type, 803, :product, [{:var, 803, :first}, {:var, 803, :second}]},
              {:type, 803, :union, [{:var, 803, :first}, {:var, 803, :second}]}
            ]},
           [
             {:type, 803, :constraint,
              [
                {:atom, 803, :is_subtype},
                [{:var, 803, :first}, {:type, 803, :term, []}]
              ]},
             {:type, 803, :constraint,
              [
                {:atom, 803, :is_subtype},
                [{:var, 803, :second}, {:type, 803, :term, []}]
              ]}
           ]
         ]}

completed in 2c4f3e3


xcode build system broken

I am getting the error  'unsupported/Eigen/CXX11/Tensor' while trying to run camera example in iOS i do have Eigen installed on my mac..

Are you running the tensorflow/contrib/makefile build system or are you using one of the xcode projects?

i am using the xcode projects in this repo @jart

@jart  and this is the only error i get and also can i ask how do you manage to get a tensorflow repo into ios ive been struggling to do that..
Thanks
Aryan

Those xcode project files are in the contrib folder, so they are community supported. We don't have any automated regression tests that guarantee they stay correct. We also aren't able to test them manually when we make changes to our Bazel build.
It is likely that https://github.com/tensorflow/tensorflow/commit/65038b084059cf934df50fa86dba5b0e765f9d65 is what broke the xcode project definitions. Perhaps you could help us fix these files. I'm marking this issue as contributions welcome.

@petewarden

@NSAryan12 have you had success following the iOS build instructions here?
https://github.com/tensorflow/tensorflow/tree/master/tensorflow/contrib/makefile#ios
You'll need to run tensorflow/contrib/makefile/build_all_ios.sh before you can compile the Xcode example projects.

@petewarden /usr/local/Cellar/autoconf/2.69/bin/autoconf failed with exit status: 1 i get that error :(

when i do tensorflow/contrib/makefile/build_all_ios.sh

Can you give me the full console output you see after running the build_all_ios.sh script?

PROTOC = "protoc"
CC_PREFIX = ""
rm -rf /Users/Aryan/Documents/libs/tensorflow/tensorflow/contrib/makefile/gen
rm -rf tensorflow/core/util/version_info.cc
downloading http://bitbucket.org/eigen/eigen/get/97c1ebe6ccc2.tar.gz
downloading http://github.com/google/gemmlowp/archive/c0bacf11fb509a2cbe15a97362a2df067ffd57a2.tar.gz
downloading https://github.com/google/googletest/archive/release-1.8.0.tar.gz
downloading http://github.com/google/protobuf/archive/c2b3e70efd2038a54ef8973771ac58192885125e.tar.gz
downloading http://github.com/google/re2/archive/7bab3dc83df6a838cc004cc7a7f51d5fe1a427d5.tar.gz
download_dependencies.sh completed successfully.
++ dirname tensorflow/contrib/makefile/compile_ios_protobuf.sh
+ SCRIPT_DIR=tensorflow/contrib/makefile
+ source tensorflow/contrib/makefile/build_helper.subr
+ cd tensorflow/contrib/makefile
++ pwd
+ HOST_GENDIR=/Users/Aryan/documents/libs/tensorflow/tensorflow/contrib/makefile/gen/protobuf-host
+ mkdir -p /Users/Aryan/documents/libs/tensorflow/tensorflow/contrib/makefile/gen/protobuf-host
+ [[ ! -f ./downloads/protobuf/autogen.sh ]]
+ '[' 1 -gt 1 ']'
+ JOBS_COUNT=4
++ pwd
+ GENDIR=/Users/Aryan/documents/libs/tensorflow/tensorflow/contrib/makefile/gen/protobuf_ios/
+ LIBDIR=/Users/Aryan/documents/libs/tensorflow/tensorflow/contrib/makefile/gen/protobuf_ios/lib
+ mkdir -p /Users/Aryan/documents/libs/tensorflow/tensorflow/contrib/makefile/gen/protobuf_ios/lib
+ OSX_VERSION=darwin14.0.0
++ xcrun --sdk iphoneos --show-sdk-platform-path
+ IPHONEOS_PLATFORM=/Applications/Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform
++ xcrun --sdk iphoneos --show-sdk-path
+ IPHONEOS_SYSROOT=/Applications/Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/SDKs/iPhoneOS10.0.sdk
++ xcrun --sdk iphonesimulator --show-sdk-platform-path
+ IPHONESIMULATOR_PLATFORM=/Applications/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.platform
++ xcrun --sdk iphonesimulator --show-sdk-path
+ IPHONESIMULATOR_SYSROOT=/Applications/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator10.0.sdk
++ xcrun --sdk iphoneos --show-sdk-version
+ IOS_SDK_VERSION=10.0
+ MIN_SDK_VERSION=8.2
+ CFLAGS='-DNDEBUG -Os -pipe -fPIC -fno-exceptions'
+ CXXFLAGS='-DNDEBUG -Os -pipe -fPIC -fno-exceptions -std=c++11 -stdlib=libc++'
+ LDFLAGS=-stdlib=libc++
+ LIBS='-lc++ -lc++abi'
+ cd downloads/protobuf
+ PROTOC_PATH=/Users/Aryan/documents/libs/tensorflow/tensorflow/contrib/makefile/gen/protobuf-host/bin/protoc
+ [[ ! -f /Users/Aryan/documents/libs/tensorflow/tensorflow/contrib/makefile/gen/protobuf-host/bin/protoc ]]
+ echo 'protoc not found at /Users/Aryan/documents/libs/tensorflow/tensorflow/contrib/makefile/gen/protobuf-host/bin/protoc. Build it first.'
protoc not found at /Users/Aryan/documents/libs/tensorflow/tensorflow/contrib/makefile/gen/protobuf-host/bin/protoc. Build it first.
+ make_host_protoc /Users/Aryan/documents/libs/tensorflow/tensorflow/contrib/makefile/gen/protobuf-host
+ [[ ! -n /Users/Aryan/documents/libs/tensorflow/tensorflow/contrib/makefile/gen/protobuf-host ]]
+ HOST_GENDIR=/Users/Aryan/documents/libs/tensorflow/tensorflow/contrib/makefile/gen/protobuf-host
+ ./autogen.sh
Google Mock not present.  Fetching gmock-1.7.0 from the web...
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100   129    0   129    0     0    182      0 --:--:-- --:--:-- --:--:--   181
100  362k  100  362k    0     0   153k      0  0:00:02  0:00:02 --:--:--  353k
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100   129    0   129    0     0    188      0 --:--:-- --:--:-- --:--:--   188
100  618k  100  618k    0     0   207k      0  0:00:02  0:00:02 --:--:--  295k
+ autoreconf -f -i -Wall,no-obsolete
configure.ac:30: error: possibly undefined macro: AC_PROG_LIBTOOL
      If this token and others are legitimate, please use m4_pattern_allow.
      See the Autoconf documentation.
autoreconf: /usr/local/Cellar/autoconf/2.69/bin/autoconf failed with exit status: 1

@petewarden

Does running brew install libtool help? If so, we may need to update the documentation to include that.

Cool it worked but now i get an error saying #include "tensorflow/core/framework/types.pb.h" not found in the xcode project. @petewarden

Closing since the bug seems stale.  We're happy to accept pull requests with further xcode fixes.


Move graphql_transport_ws operations entirely into Task objects

Now both Context creation and validation of an opration (subscripton or single-result operation) are performed
on the worker task, freeing up the Websocket for other requests.
Note: This PR builds on top of #2699

Description
Previously both creating the context, and validating the request, were done on the same task which handles
infoming messages for the Websocket.  Both of these operations are async and can potentially take a long time.
Now they are performed on the worker background Task which is created to handle the operation.

Types of Changes

[x] Core
[ ] Bugfix
[ ] New feature
[x] Enhancement/optimization
[ ] Documentation

Issues Fixed or Closed by This PR
Checklist

[x] My code follows the code style of this project.
[x] My change requires a change to the documentation.
[x] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[x] I have added tests to cover my changes.
[x] I have tested the changes and verified that they work and don't break anything (as well as I can manage).

Thanks for adding the RELEASE.md file!

Here's a preview of the changelog:

Operations over graphql-transport-ws now create the Context and perform validation on
the worker Task, thus not blocking the websocket from accepting messages.

Here's the preview release card for twitter:

Here's the tweet text:
🆕 Release (next) is out! Thanks to @kristjanvalur for the PR 👏

Get it here 👉 https://github.com/strawberry-graphql/strawberry/releases/tag/(next)

No rush, just keeping things tidy :)

PR is updated but I cannot see from the codecov that there is any missing coverage for my changes.

This PR needs to be completely refactored because of the upstream changes.
The "context" and "root value" are now created in a different place, long before the task is created.  These really need to be evaluated in the context of the Task to not block the socket.  I will attempt to re-factor this again.

This PR needs to be completely refactored because of the upstream changes. The "context" and "root value" are now created in a different place, long before the task is created. These really need to be evaluated in the context of the Task to not block the socket. I will attempt to re-factor this again.

Hi Kristján, thanks for bringing this up again!
During a brief discussion of this PR at PyconIT earlier this year, I realized that the strawberry core devs I talked to generally perceive get_context and get_root_value as lightweight methods. After recent refactors, both methods are only being called once per WebSocket connection.
Based on the assumption that these operations are lightweight, we were less concerned about get_context/get_root_value than the request validation mentioned in this PR's description. Feel free to split the request validation optimization in a separate PR so that we do not delay the merging of either part of this PR by pondering the other.

Sounds good.   I'll leave the context/root as they are and rework this to just do the validation.

It appears that validation now happens in the task ,because the result_source is awaited inside the Task now.  So presumably, validation now happens on the thread.  Since context is now created once for each connection, this leaves nothing left for this PR to do.  All it could contribute is perhaps tests that validation does not block other messages for the connection.   I'm inclined to simply close this.

Actually, my tests as written for the old PR do indicate a discrepancy in validation handling for queries vs subscriptions.
I'll create a new PR with just the tests, showing the problem, without proposing a solution.

By the way, speaking of "context" being created once for each WS connection, I want to draw your attention to this bug: #1754

It appears that validation now happens in the task ,because the result_source is awaited inside the Task now. So presumably, validation now happens as part of that, in a separate Task. Since context is now created once for each connection, this leaves nothing left for this PR to do. All it could contribute is perhaps tests that validation does not block other messages for the connection. I'm inclined to simply close this.

Thanks for verifying! It looks like this was changed when extension support for subscriptions was added. Let's close this PR then.

Actually, my tests as written for the old PR do indicate a discrepancy in validation handling for queries vs subscriptions.
I'll create a new PR with just the tests, showing the problem, without proposing a solution.
see https://github.com/strawberry-graphql/strawberry/pull/3671. Please have a look at this and give me your opinion.

Thank you so much for highlighting that. I'll check the specs and the PR introducing this discrepancy again. It looks like something slipped through the review and had no proper tests.

By the way, speaking of "context" being created once for each WS connection, I want to draw your attention to this bug: https://github.com/strawberry-graphql/strawberry/issues/1754

:+1: Currently reading through it.


[docs] improve volumes.md

add a Note: Volumes' names in hostPath configuration must be different

ex: mydir & myfile

@ppborah It is obvious that volume names should be different
as it is going to be used for volumeMounts property in containers

Hey @dipankardas011, I agree!
Should we mention that volumeMounts.name property should be unique ?

Hey @dipankardas011, I agree! Should we mention that volumeMounts.name property should be unique ?

It is already unique as it is in a list format, when one or more volumeMounts are specified then name are taken for referencing

@dipankardas011, got you!
Just a last thought, what about explicitly mentioning it in docs ?
or should I close this PR ?

Let one of the reviewers comment

Netlify build failed with no particular reason.
@ppborah please (force-)push again to reflect review suggestions, then a new Netlify build will be triggered.

Hey @ppborah,
It's been a while since the last update, would you like to address issues in the previous comments so that we can move forward?

Apologies for the delay!
Sure, I will address the issues and make the required changes.

Hey @ppborah,
Thanks for purposing this PR. But since you didn't respond for a while, we have to close this PR now.
/close
Feel free to /reopen when you are ready to move forward.
(Note that please don't push anything while PR closed, or you won't be able to reopen it.)


aarch64 package has libz.so<1.2.7

libz.so < 1.2.7 has 4 CVE
CVE-2016-9840
CVE-2016-9841
CVE-2016-9842
CVE-2016-9843
install method:
pip install scipy==1.5.2
in aarch64 environment

Thanks @owen510754 . We don't ship libz.so but depend on it hence this needs to go to the environment maintainers.

FWIW, I do see ./scipy.libs/libz-faed9fd9.so.1.2.7 packaged in scipy-1.6.1-cp38-cp38-manylinux2014_aarch64.whl. The provision/packaging of necessary runtime deps is described in the PEPs related to the manylinux standards I think.
If I understand correctly, the libs get pulled in from the CentOS base image in use. Perhaps that makes it an upstream matter--Ralf would know more most likely.


Fix build with MinGW on windows

MinGW is used as the Windows ABI for Julia.
rustc creates DLL files without a lib prefix, which does not match the expectations of most tools in the MinGW world.
This PR tries to enable CI for this target, and fix the CMake build to pass the right arguments.
Contributor (creator of pull-request) checklist

[ ] Tests updated (for new features and bugfixes)?
[ ] Documentation updated (for new features)?
[ ] Issue referenced (for PRs that solve an issue)?

Reviewer checklist

[ ] CHANGELOG updated with public API or any other important changes?

📚 Documentation preview 📚: https://metatensor--441.org.readthedocs.build/en/441/

whoops, deleted the wrong branch


Refactor/commands to classes

Despite the large number of lines changed, all that has happened here is:

moved all _commands commands to classes

classes have been named based on the file the methods were in
One class to one file

Classes group commands in commands.py e.g. PreprocessorCommands inherits from all preprocessor classes
These classes are subsequently inherited by the existing Commands class.
This should not mean any changes to existing usage, and all tests pass unchanged post-refactor

This closes #506

Sorry for the delay in merging this.  We just had a baby and efficiency will be somewhat degraded.
Verified that the docs build locally (which was what I was worried about).

Well implemented.  Thanks!


About Missing Data (0 values)

There is a lot of missing data (those with value 0) in both datasets (METR-LA and PEMS-BAY). Did you adopt any interplolation approach (such as linear interplolation) to fill in these missing values?

Thanks for the question. We don't do specific imputation/interpolation in the data, instead observations with label/groundtruth being 0 are ignored in the calculation of both loss and metric.

Does a zero observation in METR-LA and PEMS-BAY always indicate missing values?
It could also mean the following:

No vehicle passed by in the 5min interval, so the recording is zero
There is a traffic jam due to which the cars are stuck and not moving, giving velocity zero

Moreover, why does a sensor fault always result in a zero value? The missing values should be presented in the data as NaN for clarity.


GAC behavior and location is different between .NET 4.0 and pre-4.0, affects BizTalk 2010

Need to use the newer Gacutil for BTS 2010 or maybe just for 4.0 assemblies.  Custom tasks to get GAC path also need to follow assembly version.

I think I have found part of the cause of my confusion, although I still think there are issues, I am convinced these issues surround the different versions of gacutil.

Using your BizTalk sample app when it is converted from VS 2008 to VS 2010 the conversion leaves the Components assembly at v3.5.  but changes the BizTalk assemblies to v4.0.

So when you do a deploy it does deploy correctly to BizTalk and gac's the BizTalk assemblies into C:\Windows\Microsoft.NET\assembly\GAC_MSIL, the Components assembly is gac'd into the c:\Windows\Assembly folder which again is correct for v3.5 assemblies.

If you run another BDF deploy all works fine, if however you run a BDF undeploy it does not remove the BizTalk assemblies from the gac but it does remove the components assembly, which is why I think there is an issue with gacutil, because it does a gacutil /u on BizTalk assemblies before doing a BTSTask RemoveApp, which is clearly not removing the BizTalk assemblies from the gac.

Now if you then change the sample app's Components assembly to v4.0 re-compile then do another BDF deploy you get the following error

DeployComponents:

Deploying components to GAC...

"C:\Program Files (x86)\Deployment Framework for BizTalk\5.0\Framework\DeployTools\gacutil.exe" /i "..\BizTalkSample.Components\bin\Debug\BizTalkSample.Components.dll"

Microsoft (R) .NET Global Assembly Cache Utility. Version 2.0.50727.42
Copyright (c) Microsoft Corporation. All rights reserved.

Failure adding assembly to the cache: This assembly is built by a runtime newer than the currently loaded runtime and cannot be loaded.

C:\Program Files (x86)\MSBuild\DeploymentFrameworkForBizTalk\5.0\BizTalkDeploymentFramework.targets(1229,5): error MSB3073: The command ""C:\Program Files (x86)\Deployment Framework for BizTalk\5.0\Framework\DeployTools\gacutil.exe" /i "..\BizTalkSample.Components\bin\Debug\BizTalkSample.Components.dll"" exited with code 1. [C:\Program Files (x86)\Deployment Framework for BizTalk\5.0\Samples\BizTalk2009\Advanced\BizTalkSample.Deployment\BizTalkSample.Deployment.btdfproj]

Done Building Project "C:\Program Files (x86)\Deployment Framework for BizTalk\5.0\Samples\BizTalk2009\Advanced\BizTalkSample.Deployment\BizTalkSample.Deployment.btdfproj" (Deploy target(s)) -- FAILED.

Build FAILED.

this again indicates an issue with gacutil.

Moving back to my intial problem, the reason for having a Components assembly set to v4.0 is I need to add a reference to our BizTalk Schemas project, which then forces me to make the Components assembly as v4.0 which results in the above error.

My workaround is to set IncludeComponents property to false run a BDF deploy then manually gac the components assembly using gacutil /i at the Windows 7 SDK command prompt, this successfully installs this into the proper gac @  C:\Windows\Microsoft.NET\assembly\GAC_MSIL along with the other BizTalk assemblies.

Once again sorry for such a long drawn out explanantion but I was really confused as to where (or if) there was an issue, but I am sure there is and it relates to the use of gacutil, and possibly BTSTask AddResource -option:GacOnAdd,....

Cheers
Jim
This work item was migrated from CodePlex
CodePlex work item ID: '7246'
Assigned to: 'tfabraham'
Vote count: '1'

[jmclay@9/16/2010]
In hindsight BTSTask AddResource ... -options:GacOnAdd,GacOnInstall... does in fact add assemblies correctly into BizTalk and into the gac.
BDF doesn't use BTSTask to add Component assemblies any reason why not?
What I didn't appreciatte is gacutil /i will replace a previously installed assembly in the gac so the issue of gacutil /u not removing assemblies form the gac is not that important i.e. if you then perform a BDF deploy it will update the latest built assemblies into the gac.
So as far as I can see if BDF used BTSTask to deploy Component assemblies then we would have a interm solution to the current issue, what do you think?

[tfabraham@9/17/2010]
I might be deploying an assortment of DLL's, some BizTalk, some custom, some third party, and not all should be added to BizTalk.  I really need to add them to the GAC separately from BizTalk.  To make matters worse, with 2010 I may be GAC'ing some 3.5 and some 4.0 DLL's, and I'll have to use two versions of GacUtil to accomplish that.

[UnknownUser@9/30/2010]

[UnknownUser@10/11/2010]

[UnknownUser@10/11/2010]
Resolved with changeset 50929.

[vlad_kirnishni@10/13/2010]
Tom,
I tried the fix in changeset 50929, but the build fails with the following error
"C:\Program Files (x86)\Deployment Framework for BizTalk\5.0\Framework\DeployTools\gacutil.exe"' is not recognized as an internal or external command
It looks to me this is caused by this code in BizTalkDeploymentFramework.targets
<CreateProperty Value="$(DeployTools)\gacutil.exe" Condition="'$(Gacutil)' == ''">
  <Output TaskParameter="Value" PropertyName="Gacutil" />
</CreateProperty>

When I changed  it to
<CreateProperty Value="$(DeployTools)\GacUtilFx4.exe" Condition="'$(Gacutil)' == ''">
  <Output TaskParameter="Value" PropertyName="Gacutil" />
</CreateProperty>

it worked for my solution, but I am not sure this is the right fix.
Your thoughts?
Thank you,
--Vlad

[tfabraham@10/13/2010]
Vlad, I'm guessing that you did not build the installer and install the build using the MSI, is that correct?  That and other things will not work properly if BTDF is not installed using the installer.
Thanks,
Tom

[UnknownUser@2/21/2013]

[UnknownUser@5/16/2013]


desktop embedding should send correct focus semantics actions

desktop screen readers has option to sync a11y focus with keyboard focus or not
macOS for example

Right now we only send a11y focus and framework assume it means keyboard focus see https://github.com/flutter/flutter/issues/149748
We should update the embedding so that it based on the settings to send appropriate semantics actions

@chunhtai since we're removing the team-desktop label, I'm going to reassign this to team-macos, but we'll likely need separate issues for Linux and Windows.


Use macos-12 in github actions

macos-10.15 is deprecated and will be removed at the end of next month
according to this announcement: https://github.blog/changelog/2022-07-20-github-actions-the-macos-10-15-actions-runner-image-is-being-deprecated-and-will-be-removed-by-8-30-22/
Use the newest available version macos-12 in github actions instead.

Looks like there is some issue with crates.io and rust / cargo 1.44.1. I'll try rerunning the pipeline tommorow.

@ogoffart I'm going to go ahead and merge this PR which also raises the MSRV to 1.46 in order to get the CI working again.


Advertise correct permissions in xAccess

xAccess is meant to advise SQLite whether it can read or write to a file depending on the permissions it asks for. At the moment it is only capable of telling it whether the file already exists.
xAccess should hook into the AWS ACL stuff and work out whether files are readable or writable as well.

I am tempted to do this a different way... even maybe "lie" in xAccess and fail later on. It's all based on my own experience, but...
... I don't think I've ever used ACLs to control access to a bucket/parts of a bucket, but always through IAM or bucket policies. Also, if locking down access in a bucket, I've never granted the ability to read an ACL, so I suspect there are too many cases where anything ACL-based would fail anyway.
So I think probably the best we can do is make sure 403s etc bubble up in some appropriate way, and make sure it's documented what permissions are needed on what object?

Actually, at least in the tests, it looks like the xAccess method isn't even called for the main database file (but only for the journal / wal)...

Yeah I put ACLs but perhaps that’s not right. I guess really it’s “we should make xAccess work however appropriate”. Maybe something around attempting to read/write a test file and catching any 403s?
Do the tests cover any case of reading from an existing db with a new connection obj? I could imagine that might stimulate some usage of xAccess.

Maybe something around attempting to read/write a test file and catching any 403s?

It crossed my mind as well... but I'm torn if it's worth it. A test file working doesn't mean that access to the other files would work, and then has the possibility of leaving the bucket a bit messy (say DELETE fails and leaves the test file), so there are more cases to deal with.

Do the tests cover any case of reading from an existing db with a new connection obj? I could imagine that might stimulate some usage of xAccess.

They do! https://github.com/uktrade/sqlite-s3vfs/blob/1006f2d95da432ceb283641950563fa157c7426e/test_sqlite_s3vfs.py#L98 and I still couldn't see it querying xAccess to see it the file exists. It just calls xRead on the main file, which returns 0 bytes if nothing exists.

I'm going to close this... I think the current behaviour, although imperfect, has the nice property that it's simple. There are too many edge cases of AWS permissions to address them all, and without a specific issue to address, tricky to know which are the most important in the real world
(Of course if a specific issue crops up/is thought to be likely to crop up, feel free to re-open)


how to create item with multiple dates

I want to create events with multiple dates like image.
is that possible?

This is not supported at the moment, and there are no immediate plans for it. Sorry.


Set disabled attribute for Tab item

Can I set disabled attribute for one of Tab items?

@corocoto Instead of passing a string for menuItem pass an object with the props you would like to set on the item. This is our shorthand API in SUIR. Pretty much any prop that accepts a string which also renders another component can also accept an object which can be used to set the props for that component instead of passing a string itself.
menuItem: {
  content: 'Tab Label',
  disabled: true
}

@brianespinosa, thanks a lot!


install: implement -C/--compare

GNU man pages says:
       -C, --compare
              compare  each  pair of source and destination files, and in some
              cases, do not modify the destination at all

Code is in
https://github.com/uutils/coreutils/blob/8337179454d0c952746a980ee37a32340f510a46/src/uu/install/src/install.rs
Tests in
https://github.com/uutils/coreutils/blob/8337179454d0c952746a980ee37a32340f510a46/tests/by-util/test_install.rs

Starting work on a patch.


FAT-6493: data-import tests fixing.

Purpose
Describe the purpose of the pull request.
Approach
How does this change fulfill the purpose?
TODOS and Open Questions

[ ] Use GitHub checklists. When solved, check the box and explain the answer.

Learning
Describe the research stage. Add links to blog posts, patterns, libraries or addons used to solve this problem.

That is not the only test we see this issue, please review other reports as well


Bump version of hive for new immutable field

see https://github.com/openshift/deadmanssnitch-operator/pull/96


Update JAX-WS RI to 2.2.10

This closes #8

This might be the same problem as described in https://github.com/mojohaus/jaxws-maven-plugin/issues/18

Thanks, but there is a bit more to update (e.g. ITs). I'll hanlde that as part of #8.


Update ssh key for Ikenna

Updating my SSH Key as a result for re-recreating my dev VM

:+1:
It might be worth putting a copy of the private key in ~/.ssh on your host machine as well, to avoid having to change it here every time.

@alexmuller lesson learnt.. cheers review 👍


subsurface: 4.8.2 -> 4.9.3

This bumps subsurface to the latest release, and applies a patch to make
it work with libgit2 v1.0.
Motivation for this change
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

I'd like to postpone this until https://github.com/Subsurface-divelog/subsurface/pull/2737 has been merged, and maybe a release has been done.

I'd like to postpone this until Subsurface-divelog/subsurface#2737 has been merged, and maybe a release has been done.

I just merged the PR, but a release isn't immediately forthcoming. I want us to finish some cylinder undo code before creating a 4.10 release... and then there's updates to the user manual, endless testing, etc... so this is several weeks away at best.

I fixed the off-by-one error in the original patch and added it to nixpkgs - this seemed preferrable over bumping to a WIP snapshot, or keeping subsurface broken till a release is done.
I know patches in nixpkgs are usually discouraged, but this one is really small, fixed in upstreams master in a nontrivial backportable fashion, and more understandable than something like this.
PTAL.


Remove call to Services.Repo.by_route_id

Summary of changes
Asana Ticket: No ticket, hotfix
** (exit) an exception was raised:
    ** (UndefinedFunctionError) function Services.Repo.by_route_id/1 is undefined (module Services.Repo is not available)
        Services.Repo.by_route_id("Red")
        (site) lib/site_web/controllers/schedule/line_controller.ex:69: SiteWeb.ScheduleController.LineController.assign_schedule_page_data/1
        (site) lib/site_web/controllers/schedule/line_controller.ex:35: SiteWeb.ScheduleController.LineController.show/2
        (site) lib/site_web/controllers/schedule/line_controller.ex:1: SiteWeb.ScheduleController.LineController.action/2
        (site) lib/site_web/controllers/schedule/line_controller.ex:1: SiteWeb.ScheduleController.LineController.phoenix_controller_pipeline/2
        (site) lib/site_web/endpoint.ex:1: SiteWeb.Endpoint.instrument/4
        (phoenix) lib/phoenix/router.ex:275: Phoenix.Router.__call__/1
        (site) lib/plug/error_handler.ex:64: SiteWeb.Router.call/2

I'm not sure what's causing this, but if we don't call this function it'll resolve the 500s that are preventing a deploy.

Assigned to: @NAME

closing in favor of https://github.com/mbta/dotcom/pull/78


Allow more method signatures in .Reflect()

Fixes #31

I think you might be able to use some of the new supported signatures in many test-services


Add function names to help profiling/printing of function.

I'm not sure about the integration with TF. This is useful when using Theano profiler. I think it would be great to have that upstream. What do you think?

It looks reasonable. You are not passing the name to theano.function?

I updated the PR.


Unable to use the same wildcard certificate on multiple IIS sites in automatic renewal.

Issue description
Hi, thank you for great software. I have one little improvement request (or maybe it is possible in some way).
In current version I'm unable to use the same wildcard certificate on multiple IIS sites in automatic renewal.
Let's say that I have 3 IIS sites, each have different bindings but in the same domain e.g
Site 1 a.xyz.com
Site 2 b.xyz.com
Site 3 c.xyz.com **
I want to issue a wildcard certificate for *.xyz.com and assign it to all 3 sites. The issue is that I cannot create the renewal in such way that it will replace the newly generated certificate on all 3 sites.
The most promising was the option "SAN certificate for all bindings of multiple IIS sites" so first I added to one of the sites *.xyz.com binding, than in the program I choose to take all sites and next exclude all bindings except *.xyz.com (leaving them all produce the AcmeProtocolException about redundant domain). So this work the cert is issued but the IIS sites are not updated with new cert (just the one that actually have *.xyz.com binding is updated on that single binding) and the intention would be to update with this wildcard cert all the sites that I selected before.
Thanks a lot for any suggestions.
Kind regards

I'm sure @WouterTinus  will correct me if i'm wrong, but I think that no matter what validation method you choose, when the renewal comes up, the IIS installation plugin will find all bindings that used the old cert, and update to the new cert.
So that means that I think you can run through the tool manually to generate the desired cert, then go into IIS and update your bindings that you want using the cert. The next renewal should put a new cert for all of those same bindings.

What @LBegnaud is all true.
The program itself is very conservative when it comes to changing bindings on initial setup. Basically it strives to make the least amount of changes to "match" the domains in the certificate, rather than changing as many as possible.
On renewal it is different though: then the logic is that if a binding was using the previously issued certificate, it should should start using the newly issued one.

Excellent, thank you for the info I made some test and all is working as described. So initially it allows only to select 1 binding regardless that other ones are also matching the certificate (wildcard) but after manual selecting the generated certificate on other sites the renewal is changing it on all sites.


Sentry

Are we sure in sentry user context we shouldn't send PrestaShop Account e-mail ? Merchant email used for connect to PrestaShop Account 🤔


ADD: diff:ignoreChildren and diff:ignoreAttributes description

Pull request description
Added diff:ignoreChildren and diff:ignoreAttributes missed description.
PR meta checklist

[x] Pull request is targeted at main branch for code
or targeted at stable branch for documentation that is live on bunit.dev.
[x] Pull request is linked to all related issues, if any.
[x] I have read the CONTRIBUTING.md document.

Code PR specific checklist

[x] My code follows the code style of this project and AspNetCore coding guidelines.
[x] My change requires a change to the documentation.

[x] I have updated the documentation accordingly.

[ ] I have updated the appropriate sub section in the CHANGELOG.md.
[ ] I have added, updated or removed tests to according to my changes.

[ ] All tests passed.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: grishat sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.


Fixed optElem causing OutOfMemoryError when combined with many

This was happening:
scala> many(optElem(c => c.some.filter(_.isLetter))).parseOnly("something")
java.lang.OutOfMemoryError: Java heap space

The problem is in the advance(s.tail.length) call inside optElem, where an advance(1) should be expected.

Huh, I wonder how this ever could have worked. Would you mind adding a testcase that shows many + optElem working correctly?

I've added a quite simple test inside CharacterTest, I don't know if it would be more correct putting it CombinatorTest, since it is using many. I'll do any change you think is necessary.

Awesome, thanks!


feat: transcript ratings are transitive

decreases number of required user ratings

:tada: This PR is included in version 0.396.0 :tada:
The release is available on:

npm package (@next dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Feature_Request:Implement a feature in the Contact Us section

Problem:
Users submitting queries or issues through the "Contact Us" form may not receive confirmation that their message has been received or know if it has been conveyed to management.
Solution:
Implement an automated email notification system to inform users that their message has been received and ensure that their query or issue is conveyed to the management's attention. Additionally, commit to responding to user inquiries within a specified timeframe.
Proposed Implementation:

Email Confirmation: Upon submission of the "Contact Us" form, users receive an automated email confirming receipt of their message. This email can include a reference number for tracking purposes.

Management Notification: Utilize an API to forward user messages directly to the management team's inbox or a designated email address. This ensures that user queries or issues are promptly brought to the attention of the relevant personnel.

Response Commitment: Establish a commitment to respond to user inquiries within a specified period, such as 24-48 hours. This ensures that users are kept informed and receive timely assistance.

Considered Alternatives:

Implementing a manual confirmation process where support staff manually confirm receipt of each user message.
Utilizing a ticketing system where users can track the status of their inquiries online.
Integrating a chatbot or live chat feature for immediate assistance and confirmation.

Demo:
A demonstration video showcasing the implementation of the proposed features can be found here.
Contribution Status:
This contribution is not associated with any open-source program currently. However, I'm willing to take ownership of this feature request and implement it.

Can I work on this feature under Gssoc'24 as a contributor

@GOKULGSECE This is really a very good issue. thanks for raising the issue . I am assigning you this issue. you can start working on this issue

@GOKULGSECE This is really a very good issue. thanks for raising the issue . I am assigning you this issue. you can start working on this issue

Thanks for assigning me @apu52

@apu52 I need the official mail of the website for further improvement of this issue

@apu52 As I need the mail id of the management of this project for proceeding my process

It's oke thanks for replying @apu
by today i will be sending you the pull request


Sequence diagram for Add/Delete event command fixed

Pull Request Test Coverage Report for Build 243

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 58.279%

Totals

Change from base Build 242:
0.0%

Covered Lines:
1260

Relevant Lines:
2162

💛  - Coveralls


Engine creator helper function

Add a helper function to create a virtual engine with a noisy simulator.

Are you going to expose this in the init files as well so that you don't have to specify the whole package?

Great points, ty. I think everything's fixed..

API looks nice to me. This could be a good candidate for wrapping in a cg.workflow.SimulatedProcessorRecord subclass as a follow-up.

@mpharrigan The CI checks are onto the trickery. How to best evade this?

all the test failures are about qiskit??? seems unrelated
for coverage: you can add
# coverage: ignore

to the block (may have to try exactly where to put it. test with check/pytest-changed-files-and-incremental-coverage

for the typecheck you can add it to the list of ignored 3rd party modules in mypy.ini

@dstrain115 does this LGTY?


Attempt to reintroduce commonmark behavior

Initial checklist

[x] I read the support docs
[x] I read the contributing guide
[x] I agree to follow the code of conduct
[x] I searched issues and couldn’t find anything (or linked relevant results below)  Previous issues on this issue were understandably rejected. I would like to introduce a configuration option for this change.
[ ] If applicable, I’ve added docs and tests (TODO: I am currently writing tests.)

Description of changes
This is a proof of concept to reintroduce CommonMark-style HTML blocks to MDX. I would like to request comments on these changes.
Currently, MDX parses

  content.

as

content.

The content within the tags is parsed as a paragraph, but this is often not wanted. CommonMark specifies this behavior to only occur if there is a blank line after the tag, as such:

content.

but this is needlessly restrictive when you want markdown syntax within flow elements.
This change introduces a configuration option to parse content within flow elements as inline markdown. Paragraph wrapping can be restored by adding a blank line, as in CommonMark.
Examples:

input ===================output ===================

  *Hello.*

  Hello.

*Test*

    Test

  Inline

 a

    Inline

  a

Configuration is done by setting preferInline (bad name, please advise) when creating the extension: mdxJsx({ acorn, acornOptions, addResult: true, preferInline: true }).
I am currently writing tests for this feature and will update the PR when I have good coverage.
I intend to maintain this patch set into the future because I am currently working on a project which wants this feature. I am opening this PR for the primary purpose of gathering feedback. If this feature is not wanted, please close this PR.
Finally, I would like to offer my sincere gratitude for the authors of micromark and related packages. Markdown truly is horrible to parse, and micromark makes everything so much easier.
Things that need fixing
This does not work because expressions are not handled: fixed hopefully

{'<'}

This does not work:
`<`

**<Test />**

Hi, @iczero .
You'd better to create a related issue first actually.

The current approach does not work. Will try another one.

See https://github.com/micromark/micromark-extension-mdx-jsx/issues/12#issuecomment-1875713767 for commentary on approach and ideas on how to (and not to) proceed.

The approach in this PR is fundamentally incorrect.


Cafe public IP -> public address

Since we're requiring the cafe to set a config variable containing it's publicly reachable IP, we may as well have it tag on http(s). This means the session's HttpAddr now contains http(s)://.
Note: I have not updated the demo cafes yet. Can do when mobile-side is ready.

Cool, i'll update mobile as soon as a rc release is out.


Lack of NoScript detection

There should be some kind of NoScript detection (and alerting to the user before running the browser test), for both the domain "bettertls.com" and the IPv4 address "<IP_ADDRESS>" being used …otherwise this leads to quite strange results ;-)

Good call! I've added a noscript notice to the landing page. I don't believe the site is loading any script from the IP address (it just submits AJAX requests against it), so I think that should do the trick.


Not serializable error for ServersideOutput

I have a function that receives input from two different sources, picks one of them, and then passes it to two outputs.
@app.callback(
    ServersideOutput('interface-state', 'data'),
    ServersideOutput('tag-table-input', 'data'),
    Input('data-source-state', 'modified_timestamp'),
    Input('flight-analyze-state', 'modified_timestamp'),
    State('data-source-state', 'data'),
    State('flight-analyze-state', 'data'),
)
def data_funnel(data_src_t, flight_t, data_src, flight):
    return data_src if data_src_t > flight_t else flight

Both inputs receive dictionaries with an object as a value that is not serializable. When the same object is passed from data-source-state, the output of this function complains about the object not being serializable. When it comes from flight-analyze-state it passes through without a problem! I pickle the object and pass a serializable value to the input then load the object and it works fine. Very confused about what is going on.
Here's the error:

Traceback (most recent call last):
File "C:\Users\MahdiHosseinali\miniconda3\envs\data\Lib\site-packages\dash_extensions\enrich.py", line 604, in decorated_function
unique_id = _get_cache_id(f, output, list(filtered_args), output.session_check)
File "C:\Users\MahdiHosseinali\miniconda3\envs\data\Lib\site-packages\dash_extensions\enrich.py", line 620, in get_cache_id
return hashlib.md5(json.dumps(all_args).encode()).hexdigest()
File "C:\Users\MahdiHosseinali\miniconda3\envs\data\Lib\json_init.py", line 231, in dumps
return _default_encoder.encode(obj)
File "C:\Users\MahdiHosseinali\miniconda3\envs\data\Lib\json\encoder.py", line 199, in encode
chunks = self.iterencode(o, _one_shot=True)
File "C:\Users\MahdiHosseinali\miniconda3\envs\data\Lib\json\encoder.py", line 257, in iterencode
return _iterencode(o, 0)
File "C:\Users\MahdiHosseinali\miniconda3\envs\data\Lib\json\encoder.py", line 179, in default
raise TypeError(f'Object of type {o.class.name} '
TypeError: Object of type rootDirectory is not JSON serializable

Hmm, that sounds weird. Are you able to make a small MWE that reproduces the error? Then I'll take a look at what is going on :)

I will close this issue for now. Please reopen and post an MWE if you still have issues on the latest release.

After updating to the latest version and a little change in my data-flow I didn't get the error anymore.


Remove deprecated things for the 1.65 release

Thanks for the pull request @kring!

:heavy_check_mark: Signed CLA found.

Reviewers, don't forget to make sure that:

[ ] Cesium Viewer works.
[ ] Works in 2D/CV.
[ ] Works (or fails gracefully) in IE11.

Looks good @kring!  I'll merge as soon as CI passes

@hpinkos I snuck in the Ion key change and the package.json version bump too, rather than creating a separate PR.


Hi， what is the meaning of “class SelfAttention(nn.Module)” in resnet.py ?!

Hi,
Thanks for your question. The self-attention is for attentive pooling across time frames. Details can be found in Sect. 3.2 of the reference below.
J. Monteiro, J. Alam, and T. H. Falk, “Generalized end-to-end detection of spoofing attacks to automatic speaker recognizers,” Computer Speech & Language, p. 101096, 2020.


Code coverage improvements in expr

Codecov Report

Merging #203 into master will increase coverage by 0.7%.
The diff coverage is 98%.

@@            Coverage Diff            @@
##           master     #203     +/-   ##
=========================================
+ Coverage   66.77%   67.47%   +0.7%
=========================================
  Files          84       84
  Lines       15709    15714      +5
=========================================
+ Hits        10489    10603    +114
+ Misses       4405     4297    -108
+ Partials      815      814      -1

Impacted Files
Coverage Δ

expr/funcs.go
100% <100%> (+42.1%)
:arrow_up:

expr/builtins/aggregations.go
100% <100%> (ø)
:arrow_up:

expr/include.go
100% <100%> (ø)
:arrow_up:

expr/node.go
54.52% <100%> (+9.5%)
:arrow_up:

rel/parse_sql.go
64.43% <100%> (+0.04%)
:arrow_up:

expr/parse.go
61.84% <66.66%> (+0.56%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 854f1ee...118043b. Read the comment docs.


Bitdefender Quarantining 3.10

Description
Bitdefender has been quarantining version 3.10 as saying it has "Generic.Dacic.3BE31090.A.70010B47" in the exe of the installer file.

What Platform / OS are you running?
Windows
What version are you running?
3.10
Anything in the logs or a references that might be useful?
No response
Additional information
No response


[BUG] SKLottieView: Animation is not shown in MAUI for custom components

Description
Im trying to use the SKLottieView with a Json-Animation. It works like expected if im using the SKLottieVIew directly in the xaml-page. But if i create an own compents which contains the same SKLottieView: the animation is not visible.
Both SKLottieView have the same properties and same animations.
The event handler for AnimationFailed is not called.
Any idea how i can solve this issue?
Ive added a sample project
Expected Behavior
The animation is shown
Actual Behavior
Animation is not shown
Basic Information

Detailed IDE/OS information (click to expand)

PASTE ANY DETAILED VERSION INFO HERE

Screenshots

Reproduction Link

AnimationMauiTest.zip

One workaround that worked for me was, wrapping the SKLottieView inside of a ContentView instead of directly inheriting SKLottieView.
Like this:
`
                   <controls:SKLottieView
                        Source="Assets/Animations/customloader_dark.json"
                        AnimationFailed="AnimationControl_OnAnimationFailed"
                        AnimationLoaded="AnimationControl_OnAnimationLoaded"
                        RepeatCount="-1"
                        IsVisible="True"
                        IsEnabled="True"
                        IsAnimationEnabled="True"
                        RepeatMode="Restart"
                        BackgroundColor="Grey"
                        HeightRequest="232"
                        WidthRequest="232"
                        HorizontalOptions="FillAndExpand"
                        VerticalOptions="FillAndExpand"/>

`


ctrl- commands should probably be cmd- commands on Mac

see title

I think I tried that one point and found that certain keybindings (e.g., Cmd+O) were being intercepted by the browser. Cf. the previous issue (#20) about keyboard shortcuts.
It's gonna be annoying but eventually someone will have to go through all the major browsers on all the major platforms and make sure we have keybindings that both work and are reasonably idiomatic.


Update README.md with local run prerequisites

In order to produce the PDF you need to install the playwright global tool and download the drivers for the most common browsers.
I'm adding some instructions on how to do it, to run the application locally.
Closes #3.

Inactive


Fix locking bug

returnAdaChangeAndFinalizeFees must be given allUtxos for balancing.
Closes # .
Pre-review checklist

[ ] All code has been formatted using our config (make format for Purescript, nixpkgs-fmt for Nix)
[ ] All Purescript imports are explicit, including constructors
[ ] All existing examples have been run locally against a fully-synced testnet node
[ ] The integration and unit tests have been run (npm run test) locally
[ ] The changelog has been updated under the ## Unreleased header, using the appropriate sub-headings (### Added, ### Removed, ### Fixed)

For context, quote:

Problem is that returnAdaChangeAndFinalizeFees didn't correctly balance because it didn't take locked Utxos into account, so I think it needs to be given allUtxos instead of availableUtxos


Bug corrections

As i was using, i passed insertFromTop = false, and it keeps putting on problem is 'insertFromTop ? insertFromTop : true' always goes to TRUE since, false arguments will fall on false statement on ternary operator witch was true;
and the other corrections is, since scope is created manually sometime angular does not update views, so it needs to be updated manually. and then show all toasts, it just happens if toasts are being spammed, but as i'm using it with socket notifications it would be a problem.
obs.: i did test it on JS compiled file directly but i hope you get the idea from my corrections.

Hi @LeonadoRivaldo Thanks for your contribution,
you said

insertFromTop : true' always goes to TRUE since, false arguments will fall on false statement on ternary operator witch was true;

Ternary operators are no special, they are just a shorthand for if-else statement. I guess the changes you made won't make any difference. If that still happens, it can be some other issue. I will look into it.
Also What version of Angular.js you are using?

Ah, there it is. The problem is I have been setting it to true. unintentionally when the condition fails 😅
args.insertFromTop = if args.insertFromTop then args.insertFromTop else true

it should be
args.insertFromTop = if args.insertFromTop then args.insertFromTop else false.

Since All I need is a boolean at last. I can do
args.insertFromTop = if args.insertFromTop then true else false.

Ah, there it is. The problem is I have been setting it to true. unintentionally when the condition fails 😅
args.insertFromTop = if args.insertFromTop then args.insertFromTop else true

it should be
args.insertFromTop = if args.insertFromTop then args.insertFromTop else false.

Since All I need is a boolean at last. I can do
args.insertFromTop = if args.insertFromTop then true else false.

oh i see, actualy i dont known much about coffescript, but i'm glad i could help, did you the view update error? i mean, that is not an actual error, but some times toasts do not apear, coz scope is not updating the view, and i'm using last angularjs version.  :)

Will release a patch today.

coz scope is not updating the view,

Are you sending toast messages from a callback?

@LeonadoRivaldo I have requested few changes. make the changes I will merge this. Follow Conventional https://github.com/angular/angular.js/blob/master/DEVELOPERS.md#commits. While you make a commit.

Released v2.0.1 which fixes the insertFromTop option.


Document how to compose with

It'd be great to have a documentation part on how author can use generator-karma in their own generators :)

FYI - I'm working on a generator that composes with generator-karma right now. I haven't pushed any code yet, but I've been using the repo to track my issues.
However, I'll need something implemented for #72 in order to complete it. I submitted #73, and  @eddiemonge, it would be good to get your thoughts on the discussion there so I can finalize and submit a solid PR.
Once I complete my generator, I can add docs here or at the very least a link to it as an example of how to compose with generator-karma.

@SBoudrias @eddiemonge
Now that #73 has been merged, I'm all set to publish my generator as soon as this repo bumps major and publishes a 1.0.0 release.
Then I can make a small PR here adding instructions to the README on how to compose with this generator. Basically calling composeWith() in a function with default priority in the run loop.

Hey @tomwayson, this generator is really poorly written. Would you be willing to update it to yeoman-generator 0.19.0 and use the new this.fs file helpers.
I'm scared in the state it is right now it'll be hard to get anyone to compose with this generator.

@SBoudrias, well, I am trying to compose with this generator so that's at least one person ;)
Looks like @alfonso-presa is already on this w/ #76.
At the very least I can make a few comments there as well as test it out in my generator that composes with this.

@tomwayson That would be great!


Add tracing to Rafter

Description
Add tracing to Asset Store.
Reasons
It will help us to monitor, debug and optimize Asset Store code.
Attachments

https://github.com/m00g3n/kyma/tree/cbs-tracing%23849

It is the same as #52