Bypass non-reducing partial aggregation

If a partial aggregation does not reduce data size even after increasing its memory, we stop doing it. Adds a toIntermediate method to GroupingSet and Aggregates. This translates a vector of raw input into a vector of accumulators, each initialized from the single input value on the row.
If toIntermediate is not defined for one or more of the aggregates, GroupingSet::toIntermediate makes temporary rows in the RowContainer and uses the regular Aggregate methods to make a single-value accumulator.
Fixes #3194

The test has intermediate aggregation. If intermediate aggregation, toIntermediate is no op. This therefore returns. No check is due here.
Intermediates abandom partial just like partial aggs do. Same code path after accumulation. Same code path in getOutput().
From: shiyu-bytedance @.>
Sent: Monday, April 17, 2023 7:35 PM
To: facebookincubator/velox @.>
Cc: oerling @.>; Mention @.>
Subject: Re: [facebookincubator/velox] Bypass non-reducing partial aggregation (PR #4588)
@shiyu-bytedance commented on this pull request.

In velox/exec/GroupingSet.cpp https://github.com/facebookincubator/velox/pull/4588#discussion_r1169427839 :

 allHaveToIntermediate_ = false;

}
}
if (!allHaveToIntermediate_) {
intermediateRows_ = table_->moveRows();
intermediateRows_->clear();
}
table_ = nullptr;
+}

+void GroupingSet::toIntermediate(

const RowVectorPtr& input,
RowVectorPtr& result) {
VELOX_CHECK(abandonedPartialAggregation_);
VELOX_CHECK(result.unique());
if (!isRawInput_) {

I think we should VELOX_CHECK(isRawInput) instead of returning because returning will mask the problem?
Secondarily, what about Step::kIntermediate aggregation? isRawInput_ would be false, but maybe still it can benefit from disable hashing.
—
Reply to this email directly, view it on GitHub https://github.com/facebookincubator/velox/pull/4588#pullrequestreview-1389180797 , or unsubscribe https://github.com/notifications/unsubscribe-auth/AKPPPT7HHSJAXQEK5ND44JLXBX4WFANCNFSM6AAAAAAW4IMK7Y .
You are receiving this because you were mentioned.Message ID: @.***>

Why not
From: shiyu-bytedance @.>
Sent: Monday, April 17, 2023 7:19 PM
To: facebookincubator/velox @.>
Cc: oerling @.>; Mention @.>
Subject: Re: [facebookincubator/velox] Bypass non-reducing partial aggregation (PR #4588)
@shiyu-bytedance commented on this pull request.

In velox/exec/GroupingSet.cpp https://github.com/facebookincubator/velox/pull/4588#discussion_r1169421152 :

@@ -714,6 +714,85 @@ void GroupingSet::updateRow(SpillMergeStream& input, char* FOLLY_NONNULL row) {
}
mergeSelection_.setValid(input.currentIndex(), false);
}
+void GroupingSet::abandonPartialAggregation() {

abandonedPartialAggregation_ = true;
allHaveToIntermediate_ = true;
for (auto& aggregate : aggregates_) {
if (!aggregate->supportsToIntermediate()) {

 allHaveToIntermediate_ = false;

}
}
if (!allHaveToIntermediate_) {
intermediateRows_ = table_->moveRows();

VELOX_CHECK_EQ(table_->numRows(), 0);?
—
Reply to this email directly, view it on GitHub https://github.com/facebookincubator/velox/pull/4588#pullrequestreview-1389171594 , or unsubscribe https://github.com/notifications/unsubscribe-auth/AKPPPT2EZ3X2RHDRA76YQM3XBX22VANCNFSM6AAAAAAW4IMK7Y .
You are receiving this because you were mentioned.Message ID: @.***>

No longer applicable, changed the criteria to quantitative.
From: Maria Basmanova @.>
Sent: Thursday, April 13, 2023 2:42 PM
To: facebookincubator/velox @.>
Cc: oerling @.>; Mention @.>
Subject: Re: [facebookincubator/velox] Bypass non-reducing partial aggregation (PR #4588)
@mbasmanova commented on this pull request.

In velox/functions/prestosql/aggregates/tests/AggregationTestBase.cpp https://github.com/facebookincubator/velox/pull/4588#discussion_r1166056400 :

if (!groupingKeys.empty() && allowInputShuffle_) {

SCOPED_TRACE("Run partial + final with abandon partial agg");
PlanBuilder builder(pool());
makeSource(builder);

core::PlanNodeId partialNodeId;
builder.partialAggregation(groupingKeys, aggregates)

   .capturePlanNodeId(partialNodeId)

   .finalAggregation();

if (!postAggregationProjections.empty()) {

 builder.project(postAggregationProjections);

}

AssertQueryBuilder queryBuilder(builder.planNode(), duckDbQueryRunner_);
queryBuilder.config(core::QueryConfig::kAbandonPartialAggregation, "true")

Should we also add a test that verifies that partial agg gets disabled when kAbandonPartialAggregation is false?
—
Reply to this email directly, view it on GitHub https://github.com/facebookincubator/velox/pull/4588#pullrequestreview-1384262320 , or unsubscribe https://github.com/notifications/unsubscribe-auth/AKPPPT527LHLWTTXEMPMV33XBBXJLANCNFSM6AAAAAAW4IMK7Y .
You are receiving this because you were mentioned.Message ID: @.***>


feat(theming): Add component specific variables

Theming - Components
Watson theme change requests can be found here: https://ibm.ent.box.com/file/179323525996
Changed
Accordion

Added variables so that the chevrons could align to the right, and other variables to ensure padding/margin stays consistent once swapped.

Checkbox

Added variable to change border-width. Also, removed our border-radius as this was incorrect according to @aagonzales

Content Switcher

Added variable to allow a user to remove left/right border, as well as set the border-radius on the end buttons.

Data Table

Added variable that allows a user to set the text-transform property on a table header

Modal

Added variable that allows a user to set the border-top property

Radio Button

Added variable to change border-width.

To Test:
Add these variables to styles.scss and see the differences.


Does the project go forward?

I have seen this:

Mailspring is a Nylas fork created by one of the apps original developers. It’s said to be ‘faster’ and ‘leaner’ than the version its based.

https://github.com/Foundry376/Mailspring

Mailspring is a separate fork of Nylas maintained by one of the ex-Nylas Mail devs. It is similar but different from this repo (NML). You can see more discussion on this repo on issue #52.
Mailspring has a closed source sync engine so those with privacy/trust concerns will still find use with NML. With that said, many people and devs will be shifting support to Mailspring as it may be potentially funded and faster than NML. However, despite the recent "release" of Mailspring, it isn't quite yet stable.
So take it as you will. There is a potential future that there will be two separate repos/projects.

Me quedo por aquí mejor


We need to ensure best-practice compatibility with ACES

We need to ensure we can run ACES once from the command line for a given task, and never need to reference it (or even have it supported or installed) in this repo directly. This will ensure greater flexibility over the possible systems one can use to generate task dataframes (e.g., ATLAS, PIC-SURE, etc.)

We rely on the meds-label schema ever since issue #55 was addressed, resolving this issue.


Pipeline start wizard

This PR provide  a very basic implementation of wizard UI using only TS and CSS.
Demo:

Fix: #310

Codecov Report

Merging #335 into master will decrease coverage by 1.36%.
The diff coverage is 22.58%.

@@            Coverage Diff             @@
##           master     #335      +/-   ##
==========================================
- Coverage   73.87%   72.51%   -1.37%
==========================================
  Files          46       47       +1
  Lines        3415     3500      +85
  Branches      635      640       +5
==========================================
+ Hits         2523     2538      +15
- Misses        892      962      +70

Impacted Files
Coverage Δ

src/tkn.ts
65.22% <0.00%> (-0.19%)
:arrow_down:

src/pipeline/wizard.ts
15.27% <15.27%> (ø)

src/tekton/pipeline.ts
63.15% <40.00%> (-5.03%)
:arrow_down:

src/extension.ts
90.34% <100.00%> (+0.06%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f8413a9...adc5a34. Read the comment docs.

The look and feel matches VSCode settings style much closer.
However, it feels like we could do something to clean up the multiple duplicate fields

@joshuawilson That ' multiple duplicate fields'  I add only for sample(to record demo) they do not exist on this PR code, sorry for confusion.

And to be clear @sudhirverma continue work on this

Why add complexity? Why ask them to refactor a 3rd time? Is there something wrong with the code?

Closing this PR as implemented in https://github.com/redhat-developer/vscode-tekton/pull/338


Replacing anonymous classes with lambdas.

With the addition of JAVA 8, it is advised to use lambdas over anonymous classes for implementation of functional interfaces.
Steps to reproduce:
NA
Add system logs:
NA
Expected behaviour:
It is better if lambdas are more frequently used. Major benefit being runtime invocation of lambdas leading to smaller APk (avoids compile-time creation of anonymous .class files).
Observed behaviour:
Instead of using anonymous classes it is better to switch to lambdas for implementing functional interfaces.
Device and Android version:
NA
Screenshots:
NA
Are you interested to work on this issue?
Yes

@samagra14 do you have any examples of where you would use this?

@Karljoones the best example is the implementation of various Callbacks. Currently, we are doing this
someObject.onPositive(new MaterialDialog.SingleButtonCallback() {
            @Override
            public void onClick(MaterialDialog dialog, DialogAction which) {
                logout();
            }
        })
        .onNegative(new MaterialDialog.SingleButtonCallback() {
            @Override
            public void onClick(MaterialDialog dialog, DialogAction which) {
                Toast.makeText(getApplicationContext(),"Cancelled",
                        Toast.LENGTH_SHORT).show();
            }
        }).show();

However this can be replaced by the code below
someObject.onPositive((dialog, which) -> logout())
        .onNegative((dialog, which) -> Toast.makeText(getApplicationContext(),"Cancelled",
                Toast.LENGTH_SHORT).show()).show();
                            break;
                        default:
                            break;}

**Short + Simple + Lower size **

I think that we should wait a little before jumping the gun on this, I would like to wait to see other peoples opinions. We are trying to close off older issues at the moment rather than starting to refactor the app.

Yeah sure :sweat_smile:

@Karljoones  I think we should focus on adding new features and solving existing bugs and after that we can move to refractoring. That's my opinion let hear from other people.

IntelliJ IDEA offers a code intention to suggest replacing anonymous classes with lambdas. I'd be willing to bet that your development environment can handle most of this work.


Activerecord 4 compatibility?

Is partitioned compatible with AR4? I couldn't find anything about it in docs or anywhere else.

After a ridiculously long delay, I've merged changes to support 4.0 and 4.1 to master.
4.0 is available both here and at rubygems.org with a version of 2.0.0
4.1 is available at head here.
1.3.5 is the last version supporting rails 3, 2.0 and higher are breaking changes.
There were new AR monkeypatches involved.  The less said the better.
It is unlikely that Fiksu will be actively maintaining this gem going forward.  I'm planning to tag master with a 2.1.0 tag (for rails 4.1) tomorrow and push that to rubygems.  I'm also planning to work on a branch to support 4.2 but I haven't started it yet.  I do not foresee Fiksu upgrading this gem for rails 5.0, so someone will likely have to fork this repo and do the upgrade work themselves.
I'm closing this out.  If someone wants rails 4.2 support, please open a separate issue.


Encryption doesn't happen on Connection

I installed pyexasol as described in "pyexasol/docs/ENCRYPTION.md". After initiating the connection to database with "encryption=True" option or specifying "encryption = True" in the config file, it still created a non-encrypted connection.
I am checking the encryption status in the exa_user_sessions system table.
Am I missing something here?

This is a bug in Exasol system view, which will be fixed soon.
Connection is actually encrypted.

You may double-check it by connection URL starting with "wss://" and by looking at traffic with any sniffer.

Thanks @wildraid! Do you know the version the fix is being targeted for?

@kamal-1 , please track track this ticket: https://www.exasol.com/support/browse/EXASOL-2507

@kamal-1 , please track track this ticket: https://www.exasol.com/support/browse/EXASOL-2507

Thanks!


Set up 'blog-posts' repo

At present, the posts sit in src/library/pages however I'd like all my blog sites to use a central posts repository so this should be set up and this site configured to use it to pull in posts.

 Complete Content tasks


6/24 PM Publish

Docs Build status updates of commit 5a1ac5c:
:clock10: Pending: waiting for processors (48 builds ahead of you)
:warning: Docs Build is busy, currently there are 48 builds ahead of this one, for more information you can view the Build queue graph on the Docs Portal.

Docs Build status updates of commit 5a1ac5c:
:clock10: Full build: the average full build time is 24 min(s) 11 sec(s), this is based on the last 134 build(s) for this repository.

Docs Build status updates of commit 5a1ac5c:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docfx.json
:white_check_mark:Succeeded

docs-conceptual/azps-2.3.2/create-azure-service-principal-azureps.md
:white_check_mark:Succeeded
View (azps-2.3.2)

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


CCIP token transfer tutorial revert error fix add more LINK for fee

Closing issues
https://github.com/smartcontractkit/documentation/issues/1407
Description
My CCIP token transfer expected to revert since the LINK fee increased.
Changes
Helps new users debug the CCIP transfer revert issue due to LINK fee increasing by giving them a warning.

Thanks @MarcusWentz for this PR!


Edited the "Resolution" section.

Added a further troubleshooting step in the "Resolution" section.

@DOMARS
I've fixed the typo and added the link as per your suggestion. Thank you for the feedback.


[Suggestion] Translate tutorials/text_search_engine.md into CN

Note: This repository is ONLY used to solve issues related to DOCS.
For other issues, please move to other repositories.

Is there anything that's missing or inappropriate in the docs? Please describe.
text_search_engine.md
Describe your suggestion
CN translation needed.
Additional reference
Provide any other reference docs or websites about your request.

hey can i work on this and also please elaborate the issue again if possible thankx

Hey @YiyunNi ,
I would like to work on this issue asap. Please assign it to me.

@YiyunNi could you assign this issue to me!

@aaditya9899 @iamartyaa Thank you both for your interest! I have updated this issue with more detailed instructions, please check it out and let me know if you still feel comfortable taking this issue.

I understood the issue. Please assign it to me @claireyuw .

/assign @iamartyaa


Feature request; Support for dual-stack in the controller

Background
Support for ipv4/ipv6 dual-stack as described in the dual-stack KEP is well on it's way. Phase 1 is already merged and will be in k8s 1.16. Phase 2 is partially implemented in PR https://github.com/kubernetes/kubernetes/pull/79386 which is currently under review. With this PR in place the services will have a new attribute serviceIPFamily which defines the ip family. Example;
apiVersion: v1
kind: Service
metadata:
  name: mconnect-ipv6
spec:
  serviceIPFamily: IPv6Service
  selector:
    app: mconnect
  ports:
  - port: 5001
  type: LoadBalancer

The serviceIPFamily can have values (names may change after the review);

ClusterDefault
IPv6Service
IPv4Service

The ClusterIP will be assigned from the selected family.
Feature request
The metallb controller must be extended to maintain pools for both ipv4 and ipv6 and assign loadBalancerIP depending on family of the ClusterIP (the serviceIPFamily should not be examined).
I know this issue is "ahead of time" but work can start now to be prepared when dual-stack is released in alpha. I think there are many metallb users that want to try dual-stack early (I am one).
I think the controller and speaker should be handled independently for dual-stack support. Also I think L2 and BGP mode in the speaker shall be handled independently. Dual-stack for L2 is probably not too difficult, but BGP in metallb does not currently support ipv6 so it will be a much harder task.

The controller is "family agnostic". It assigns ipv6 addresses if the pool is ipv6, even in an ipv4-only cluster;
# kubectl get svc
NAME           TYPE           CLUSTER-IP     EXTERNAL-IP   PORT(S)          AGE
coredns        ClusterIP      <IP_ADDRESS>       <none>        53/UDP,53/TCP    31s
kubernetes     ClusterIP      <IP_ADDRESS>       <none>        443/TCP          32s
mconnect       LoadBalancer   <IP_ADDRESS>    1000::        5001:31457/TCP   7s

This is not a bug and is very good for implementing dual-stack support.

Huge thank you for investigating how dual-stack support can work with MetalLB! This is exciting, I've wanted this feature since day 1 of MetalLB :)
Design
The design on the k8s side is interesting: I expected that 1 service could have multiple address families. In fact, if the KEP says 1 service == 1 family, that is much easier to implement in MetalLB, because we don't have to keep track of multiple assigned IPs. That's great!
I'm curious why you say assign loadBalancerIP depending on family of the ClusterIP (the serviceIPFamily should not be examined).. Why should we use the ClusterIP instead of the serviceIPFamily? I'm sure I'm just missing something obvious :)
I 100% agree with your implementation phases.
Controller
I see you've made great progress on the controller, I'll review that in a moment. I'm amused that right now, we assign an IPv6 LB IP even if the cluster is IPv4... I guess I didn't think about what happens if someone configures the controller like that :D
Speaker L2
L2 in the speaker... In theory it should just work! We already support NDP (IPv6's equivalent of ARP), and all the logic is there so the speaker should just go "oh, this is a v6 address, I'll use NDP!". Of course, the problem is, I haven't tested any of this and I still don't have automated testing, so there's probably some bugs here or there :).
Speaker BGP
BGP, we're missing a fairly big chunk. I think we can establish IPv6 BGP sessions at the TCP layer (i.e. announce IPv4 prefixes on a BGP session that's running over TCPv6). However, we do not have an implementation of MP-BGP address encoding. We tell the peer that we support v4 and v6 advertisements (because Quagga requires it)... But we use the "legacy" IP encoding format that only supports IPv4.
So, for BGP, the main work is implementing the message encoding described in https://tools.ietf.org/html/rfc4760 , and replacing the existing BGP message encoding completely (the RFC4760 format can express IPv4 and IPv6 addrs). And then there's probably a long tail of extra work to do elsewhere in the BGP stack, e.g. to correctly group IPs by family during announcements. I'm not actually sure about that, it depends a bit on the details of the RFC.

Another quick note: someone contacted me on Twitter and offered to implement MP-BGP. I need to get in touch with them and see if they're still interested, but that might be WIP as well!

The reason for not using serviceIPFamily is that we don't know the "Default" family. Not even kube-proxy knows it (at least not currently). I am working with dual-stack support for proxy-mode=ipvs and discussed it on slack.

I made a PR on ipv6-bgp some time ago; https://github.com/danderson/metallb/pull/329
The slogan is misleading, it is really a bgp-mp implementation. The structure may not be feasible, but the bit-manipulations for bgp can maybe be reused (it takes some time and tcpdump'ing to get right).

Aah, of course, I didn't think of the default family! It's a little bit weird I guess that we can't know what the service config means until some other controller does something... But oh well :). Okay, using ClusterIP makes sense then.
Oh right, your PR did some MP-BGP! Yes, the code in that PR will probably help a bunch. I feel bad for abandoning it like I did :(. Would you prefer to pick up that BGP PR again yourself, or focus on the controller and other parts of dual-stack? I have a volunteer for the MP-BGP stuff, and they can reuse your bit-twiddling functions, if you're okay with that.

And using ClusterIP makes the controller PR independent of the dual-stack PRs in k8s, so it can be merged anytime. Ahead of 1.16 even :smile:

I feel bad for abandoning it like I did :(

No worries :smile:  I enjoyed working with it. It was fun to do some protocol stuff again and I got to learn about BGB. We got requirements on BFD and other things that forced us to to a separate BGP thing anyway in the end.
I rather focus on the controller since we can't use the BGP part of speaker anyway. If I can find the time I will just start L2 with dual-stack and see if it works out-of-the-box.

L2 in the speaker... In theory it should just work!

It does :grin:
I used the (updated) manifests in the PR #466 and it just works as you said!
See more info in the PR #466.
So when k8s dual-stack is released, metallb will be ready for it :smiley:


Regen from new swagger and address some API changes

We are adopting new swagger changes. This is initial change from auto-gen. Will get sort of the everything in the following commits.

/azp run - java - search - tests

/azp run java - search - tests

/azp run java - search - ci

/azp run java - search - ci

/azp run java - search - ci

/azp run java - search - ci


Iceberg – Hidden Depths shows 110 ft with 190 ft to go. It should be 90 ft to go since Hidden Depths is 200 ft.

Fixed in v0.43.2


Migrate Uruguay holidays to holiday groups

Proposed change

This migrates Uruguay's holidays to the newer holiday_groups standard.
Type of change

[ ] New country/market holidays support (thank you!)
[ ] Supported country/market holidays update (calendar discrepancy fix, localization)
[x] Existing code/test/process quality improvement (best practice, cleanup, refactoring, optimization)
[ ] Dependency upgrade (version update)
[ ] Bugfix (non-breaking change which fixes an issue)
[ ] Breaking change (a code change causing existing functionality to break)
[ ] New feature (new python-holidays functionality in general)

Checklist

[x] I've followed the [contributing guidelines][contributing-guidelines]
[x] This PR is filed against beta branch of the repository
[x] This PR doesn't contain any merge conflicts and has clean commit history
[x] The code style looks good (make pre-commit)
[x] I've added tests to verify that the new code works and all tests pass locally (make test, make tox)
[x] The related [documentation][docs] has been added/updated (check off the box for free if no updates is required)

Coverage: 99.903% (+0.02%) from 99.884% when pulling 60773a41a4cbb9716516e0d87cc73d9581e54862 on PPsyrius:uy_holiday_group into 3cfcbd44715f903b71745aee7aed4565c19ebf0b on dr-prodigy:beta.


HDFS-15202 Boost short circuit cache (v2)

Added dfs.client.short.circuit.num param for improving HDFS-client's massive reading performance by create few instances ShortCircuit caches instead of one. It helps to avoid locks and lets CPU do job.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
26m 11s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  9s
No case conflicting files found.

+0 :ok:
markdownlint
0m  0s
markdownlint was not available.

+0 :ok:
jshint
0m  0s
jshint was not available.

+0 :ok:
shelldocs
0m  0s
Shelldocs was not available.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 4 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
0m 28s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
21m 35s
trunk passed

+1 :green_heart:
compile
18m  3s
trunk passed

+1 :green_heart:
checkstyle
3m  9s
trunk passed

+1 :green_heart:
mvnsite
18m 16s
trunk passed

+1 :green_heart:
shadedclient
15m 43s
branch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
5m 35s
trunk passed

+0 :ok:
spotbugs
32m  6s
Used deprecated FindBugs config; considering switching to SpotBugs.

+0 :ok:
findbugs
0m 17s
branch/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui no findbugs output file (findbugsXml.xml)

-1 :x:
findbugs
32m  0s
root in trunk has 4 extant findbugs warnings.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 10s
Maven dependency ordering for patch

-1 :x:
mvninstall
0m 13s
root in the patch failed.

-1 :x:
mvninstall
1m  1s
hadoop-hdfs in the patch failed.

-1 :x:
mvninstall
0m 12s
hadoop-yarn in the patch failed.

-1 :x:
compile
0m 13s
root in the patch failed.

-1 :x:
javac
0m 13s
root in the patch failed.

-0 :warning:
checkstyle
0m 13s
The patch fails to run checkstyle in root

-1 :x:
mvnsite
0m 13s
root in the patch failed.

+1 :green_heart:
shellcheck
0m  0s
There were no new shellcheck issues.

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
xml
0m  1s
The patch has no ill-formed XML file.

-1 :x:
shadedclient
0m 12s
patch has errors when building and testing our client artifacts.

-1 :x:
javadoc
0m 13s
root in the patch failed.

-1 :x:
findbugs
0m 13s
root in the patch failed.

-1 :x:
findbugs
0m 12s
hadoop-yarn in the patch failed.

_ Other Tests _

-1 :x:
unit
0m 13s
root in the patch failed.

+0 :ok:
asflicense
0m 13s
ASF License check generated no output?

160m 23s

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-2015/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2015

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle xml markdownlint jshint shellcheck shelldocs

uname
Linux 489db29f8ff3 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / d60496e6c66

Default Java
Private Build-1.8.0_252-8u252-b09-1~18.04-b09

findbugs
https://builds.apache.org/job/hadoop-multibranch/job/PR-2015/1/artifact/out/branch-findbugs-root-warnings.html

mvninstall
https://builds.apache.org/job/hadoop-multibranch/job/PR-2015/1/artifact/out/patch-mvninstall-root.txt

mvninstall
https://builds.apache.org/job/hadoop-multibranch/job/PR-2015/1/artifact/out/patch-mvninstall-hadoop-hdfs-project_hadoop-hdfs.txt

mvninstall
https://builds.apache.org/job/hadoop-multibranch/job/PR-2015/1/artifact/out/patch-mvninstall-hadoop-yarn-project_hadoop-yarn.txt

compile
https://builds.apache.org/job/hadoop-multibranch/job/PR-2015/1/artifact/out/patch-compile-root.txt

javac
https://builds.apache.org/job/hadoop-multibranch/job/PR-2015/1/artifact/out/patch-compile-root.txt

checkstyle
https://builds.apache.org/job/hadoop-multibranch/job/PR-2015/1/artifact/out/buildtool-patch-checkstyle-root.txt

mvnsite
https://builds.apache.org/job/hadoop-multibranch/job/PR-2015/1/artifact/out/patch-mvnsite-root.txt

javadoc
https://builds.apache.org/job/hadoop-multibranch/job/PR-2015/1/artifact/out/patch-javadoc-root.txt

findbugs
https://builds.apache.org/job/hadoop-multibranch/job/PR-2015/1/artifact/out/patch-findbugs-root.txt

findbugs
https://builds.apache.org/job/hadoop-multibranch/job/PR-2015/1/artifact/out/patch-findbugs-hadoop-yarn-project_hadoop-yarn.txt

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-2015/1/artifact/out/patch-unit-root.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-2015/1/testReport/

Max. process+thread count
312 (vs. ulimit of 5500)

modules
C: . hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-client hadoop-yarn-project/hadoop-yarn U: .

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-2015/1/console

versions
git=2.17.1 maven=3.6.0 shellcheck=0.4.6 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.


Update storage-blob-storage-tiers.md

Addresses https://github.com/MicrosoftDocs/azure-docs/issues/61602

@tamram : Thanks for your contribution! The author(s) have been notified to review your proposed change.


[stable/graylog] fix NOTES.txt for NodePort service type

What this PR does / why we need it:
fix NOTES.txt template name when NodePort is enabled.
Which issue this PR fixes

fixes #12867 #12807

Special notes for your reviewer:

check line number 60:131

Error: UPGRADE FAILED: render error in "graylog/templates/NOTES.txt": template: graylog/templates/NOTES.txt:60:131: executing "graylog/templates/NOTES.txt" at <{{template "fullname...>: template "fullname" not defined

/assign @kongz

/lgtm

/ok-to-test
/lgtm


Overriding environment variables with fig run

It is not possible to execute fig run [-e KEY=VAL...] SERVICE if there are any environment variables defined in the fig.yaml file.  Here's the end of the stack trace:
File "/fig/fig/cli/main.py", line 315, in run
    service.options['environment'][k] = v
TypeError: list indices must be integers, not unicode

This is on 1.0.1, but the same thing happens with the current version.  It seems that service.options['environment'] is instantiated as a list from the fig.yaml and main.py attempts to use it as a dictionary.  Probably the right thing to do would be to convert service.options['environment'] to a dictionary if it already exists, and then replace values if needed, or add new key/value pairs if they don't conflict.  I'm not really proficient enough in python to make a good PR, but if anyone wants I can give it a try.

Check out #927, I believe this is the same issue. There is a workaround described in that ticket, but it's still a bug that needs to be fixed.


Install odbc error

Hello,
I am trying to install the package but npm i odbc fail with the following message:

I am on Windows 10 , vs code 1.35.0, python 2.7, node v10.15.3
Thanks in advance for your time,
Best regards.

I think this is unrelated to node-odbc, but a compiling issue in windows.
You may look at this stackoverflow thread: https://stackoverflow.com/q/33183161/3290257

Prebuilt binaries should now be available for Windows for some previous and all future versions of this package, closing!


Could you please tell me how to get the embed_tfidf_weights.pkl

No description provided.

Hi，
I also encountered this problem. Has it been solved for you?

In dataset_VQA.py, we attach source code (in comment format) from line 317 to line 323 for creating the embed_tfidf_weights.pkl


[WIP] Fixing tests

Fixes #29
Signed-off-by: Miquel Sabaté Solà<EMAIL_ADDRESS>

I still have to look at the specific failures. I'll do it whenever I have the time, but my current commit already addresses most of the current issues.


[Copilot] New IsCapabilityRegisteredSaaS api

Summary
New api IsCapabilityRegisteredSaaS will check if a capability has been registered and specifically if it is on SaaS environment.
Work Item(s)
Fixes AB#544933

Are there downsides to also checking for SaaS rather than cleaner separation of concern and focusing only on registration check?
For example, if our registration system changes in the future (note: no plans to do so), then apps will lose the SaaS check.


sample data path optional

with a try except due to Iris ValueError raising if sample_data_path not configured

Coverage remained the same at 99.268% when pulling b651385a4e4b027b16b6912ce422ff88e70b1ede on marqh:sdp into 118c45c02f8d265b2e06c54092cf7989f25592b2 on SciTools:master.


Sveltekit integration: is not a valid SSR component

Juts started new project with Sveltekit, then installed Carbon components with
npm i -D carbon-components-svelte --save
Then started to code header
Then run the project and get:
Error: <Header> is not a valid SSR component. You may need to review your build config to ensure that dependencies are compiled, rather than imported as pre-compiled modules
Of course I kept node adapter on vite config.
Should I use static only?

Try installing it as a direct dependency, not a development dependency.

Interesting. Add it as direct dependency now leads to below error:
ReferenceError: module is not defined at /node_modules/clipboard-copy/index.js?v=4bcc2685:2:1
But if I build and start (npm run ...), then solution works..??!!
Project is public: https://github.com/myangga/carbonkit

You might need to clear the cache (rm -rf .svelte build) and restart the dev command.

So I removed cache but error still happened.
Found in my console that clipboard-copy has also SSR issue.
So I tried to install it as a dev dependency: npm i -D<EMAIL_ADDRESS>And now project is running (can see the page) with npm run dev but get a client error:
Uncaught SyntaxError: The requested module '/node_modules/carbon-components-svelte/node_modules/clipboard-copy/index.js?v=66d86bee' does not provide an export named 'default'

@myangga Perfect, thank you – I was able to reproduce the error.
It appears that clipboard-copy (added in<EMAIL_ADDRESS>does not support the ESM format.
Therefore, you will need to instruct vite to pre-bundle it.
In your svelte.config.js, can you add "clipboard-copy" to vite.optimizableDeps?
// svelte.config.cjs
const node = require('@sveltejs/adapter-node');
const pkg = require('./package.json');

module.exports = {
	kit: {
		adapter: node(),
		target: '#svelte',

		vite: {
+			optimizeDeps: {
+				include: ['clipboard-copy']
+			},
			ssr: {
				noExternal: Object.keys(pkg.dependencies || {})
			}
		}
	}
};

Awesome! Many thanks @metonym it works.

I included some more details about this in https://github.com/vitejs/vite/issues/3024

Thank you so much @metonym you saved my day! :D

It is no longer necessary to instruct vite to optimize clipboard-copy as of carbon-components-svelte version 0.39.
The clipboard-copy dependency has been removed.
Instead, CodeSnippet and CopyButton use the native, asynchronous Clipboard API to copy text. The functionality is exported as a prop so the user can override the behavior as needed.
Note: the clipboard.writeText API is not supported in IE 11 nor Safari iOS version 13.3 or lower. caniuse estimates that ~91% of global users use a browser compatible with the API.
Overriding default copy behavior
Override the default functionality through the copy prop.
<script>
  import copy from "clipboard-copy";
  import { CopyButton } from "carbon-components-svelte";
</script>

<CopyButton text="hello" copy={text => copy(text)} />

Preventing default copy behavior
Pass a "no-op" empty function to prevent the component from copying text at all.
<script>
  import { CopyButton } from "carbon-components-svelte";
</script>

<CopyButton text="hello" copy={() => {}} />

I still see this same error, with Sapper and Carbon components svelte version 0.39. It works with 0.26. I've removed the dev dependency and re-added carbon 0.39 as direct dependency, but the problem persists.

@benbucksch Can you provide the following so that I can reproduce the error?

SvelteKit version
components from carbon-components-svelte that you are using

@metonym Not SvelteKit, but Sapper 0.28.10
Components used:
Accordion
AccordionItem
Breadcrumb
BreadcrumbItem
Button
Checkbox
ClickableTile
Column
Content
DataTable
DataTableHeader
Dropdown
DropdownItem
Grid
Header
HeaderNav
HeaderNavItem
HeaderUtilities
Icon
Link
Loading
Modal
NumberInput
Row
SideNav
SideNavItems
SideNavLink
SkipToContent
Slider
Tab
TabContent
Tabs
TextInput
Toggle
Toolbar
ToolbarBatchActions


Support to 4Mb Devices

M5StickC and M5StickC Plus 1, that have only 4Mb of Flash Memory are not working, due to partitioning scheme.
Need testing to find the best configuration.

Added support to 4Mb devices by creating a custom partitioning system.
Left this way:
App0 -> 0,8Mb exclusive to Launcher binary
App1 -> 3Mb to install apps
spiffs -> 64kb for almost nothing
In these cases, when open launcher in App1, it shows a msg on screen and automatically rolls back to partition App0.


Update nightly-build workflow so that it does not report error if nightly build already exists

Currently nightly build workflow can be triggered either manually or triggered by the daily schedule. If it has been triggered manually, the daily scheduled execution will fail due to "File already exists" error, which leads to unnecessary inconvenience for developers.
It might be better to use avoid this situation by using Test PyPI to perform and check the upload first. See https://pypi.org/help/#file-name-reuse for more detail.

Fixed by #16


Xfail struct and array order by tests on Dataproc

Fixes #1541
to the point that the tests do not fail. I am triaging the actual issue in the mean time but this should help with the builds.

I assume you will work with Tim to enable for our dataproc builds to pass in the --runtime_env dataproc

Yes! :)

build

@NvTimLiu can we add the runtime env set to dataproc for the build? Thanks!


Doesn't install correctly Mac OS

I tried to install naturtag today 2020-07-21 on Mac OS. with pip. There seems to be some version issue with pyinaturalist that I don't understand. naturtag wants pyinaturalist v. 0.10.0.dev206, but when I run naturtag at the command line I get the following error:
ImportError: cannot import name 'get_observation_species_counts' from 'pyinaturalist.node_api' (/Users/alan/opt/anaconda3/lib/python3.7/site-packages/pyinaturalist/node_api.py)
I looked at various versions and it seems that get_observation_species_counts is not defined in pyinaturalist v. 0.10.0.dev206 but is defined in v. 0.11.0. I'm not a python programmer, and I am relatively clueless, so not sure if this is a bug or user error.

You're right, the pyinaturalist version pinned in the dev branch was out of date. It's been updated now. Thanks for reporting!

It appears that you need to require importlib-metadata too. Thanks for the rapid turn-around.

@alanterra Thanks! I must not have tested recently on python 3.7. importlib.metadata is part of the standard library as of python 3.8; I'll add a note about installing it for python 3.7. Thanks!
...Funny that a python 3.7 issue happened to come up in issue #37!


NPC Talents don't show until sheet opened twice

Since the alst update, whenever I open an NPC sheet for the first time, the Talents don't show. If I then close and reopen the sheet, they show. This happens on various browsers (I'm on Windows 11 and run Chrome/Opera/Firefox and have tested with all 3).
These are the modules I've got installed.

Hi, thanks for the report.

Can you please re-test with all of your modules disabled and confirm the issue persists
Can you please provide an example of an "NPC" with talents so I can attempt to replicate it?

Played around with the various modules and it seems to be tied to MinimalUI ( https://github.com/saif-ellafi/foundryvtt-minimal-ui )
Luckily not a module I criticallly need, so not a serious issues.


cannot folder expression - data connector & PostgreSQL ODBC

I want connect to Postgres ODBC data source with direct query enabled. So I took this sample project, https://github.com/Microsoft/DataConnectors/tree/master/samples/ODBC/SqlODBC, point Config_DriverName variable to "PostgreSQL Unicode(x64)" (name of my psqlODBC driver, version 03.51), and set ConnectionString based on a working ODBC DSN.
I am using Power BI Desktop, Version 2.61.5192.601 64-bit (August 2018), and there is no problem to add one table to my Power BI report. But whenever I put a column into a table (or any other viz), I got this error:
OLE DB or ODBC error: [Expression.Error] We couldn't fold the expression to the data source. Please try a simpler expression.
And it happened to any column, varchar, number or date.
Attached is PBI report and log files under Power BI Desktop\Traces directory.
Any help is appreciated.
Traces.zip
postgres odbc-data connector.zip
P.S. By "a working ODBC DSN" I meant I can connect to this ODBS DSN, import tables and render viz, within Power BI Desktop. But of course without direct query mode.

And here is the VS project:
SenturusDataConnector2.zip


Trigger text/wait

Re #71

better yet, made it a textarea so you can list multiple keywords easier


[TwP] Fallback to propagation context if span is None

https://github.com/getsentry/sentry-python/blob/master/sentry_sdk/scope.py#L608-L612
Instead of checking for has_tracing_enabled, I suggest we only check for an existing span on the scope, with a fallback on using the Propagation Context.
PHP for inspiration https://github.com/getsentry/sentry-php/blob/master/src/State/Scope.php#L382-L398

Fixed in the linked issue.


Exposure Logging Stopped and history lost

Avoid duplicates

[X] Bug is not mentioned in the FAQ
[X] Bug is specific for Android only, for general issues / questions that apply to iOS and Android please raise them in the documentation repository
[X] Bug is not already reported in another issue

Describe the bug
After opening the CWA app, EXPOSURE LOGGING was STOPPED and onboarding sequence was presented.
After completing the onboarding sequence, instead of seeing the Low Risk card, I am now seeing Unknown Risk status because CWA has not been active long enough.
Expected behaviour
Since I did not reset the app in any way I did not expect it to reset itself.
CWA should have shown me that it had been running all the time with a Low Risk result.
The Google exposure check log should have had a history of 14 days.
Steps to reproduce the issue
Open CWA.
This was a spontaneous reset, it is not normally reproducible.
Technical details

Mobile device: Samsung Galaxy A50 SM-A505FN
Android version: 10
CWA version: 1.5.0
Google Play services version: 20.39.15<PHONE_NUMBER>85812) beta version
Exposure Notification System version:<PHONE_NUMBER>0

Possible Fix
Monitor for similar reports and take action if other users report it as well.
Additional context

I have had CWA running for more than 14 days and on Monday Oct 19, 2020 I updated to 1.5.0.
I was enrolled on the Google Play services beta and although I have since left the beta there has been no new release available from the Google Play store, so I still have a beta version installed.
The exposure checks log has been cleared out and there is now just one entry from after the onboarding sequence was completed.
The device is not rooted, so I cannot see if the random IDs from the previous 14 days have been completely lost or not.
There were no error messages shown.

Internal Tracking ID: EXPOSUREAPP-3427

@d4rken is there any way that automatic recovery can be triggered without showing the dialog?

In https://github.com/corona-warn-app/cwa-app-android/issues/642#issuecomment-697226914 @Druidikaaa reported on Sept 23, 2020 being unexpectedly presented with the onboarding dialog with Android 10. Judging by the date, it would have been CWA 1.3.0 at the time.

Thanks for reporting @MikeMcC399 ,
I've created a Jira ticket (EXPOSUREAPP-3427) with the provided information and forwarded it to the developers.
Regards
CH

Corona-Warn-App Open Source Team

@d4rken is there any way that automatic recovery can be triggered without showing the dialog?

Not on 1.5.0, the routine does not trigger AFAIK. The error is very specific.
@MikeMcC399 Did you open the app after 1.5.0 successfully with your previous data intact at any point? Meaning, can we rule out that the state was already present on 1.3.0 and you only became aware after opening the app after the 1.5.0 update? While 1.5.0 will attempt to prevent the encryption issue #642 if the issue was present, before the upgrade, it would still be there on 1.5.0.

@d4rken

Did you open the app after 1.5.0 successfully with your previous data intact at any point? Meaning, can we rule out that the state was already present on 1.3.0 and you only became aware after opening the app after the 1.5.0 update? While 1.5.0 will attempt to prevent the encryption issue #642 if the issue was present, before the upgrade, it would still be there on 1.5.0.

Yes, this is a pure 1.5.0 issue and data was first intact with 1.5.0.
I updated to CWA 1.5.0 immediately after it was released on Monday, Oct 19, 2020 12:00 and I opened it at least once a day manually after that. On Friday, Oct 23, 2020 I had opened it during the day and it behaved normally. Then early evening I opened it again and noticed the issue that it had reset itself.
The exposure check log shows 3 checks in the past 14 days:
23.10.2020 18:04 (after I completed onboarding following the reset)
24.10.2020 02:20
25.10.2020 02:21

Closing this issue, since it has not happened to me again, and there have been no other similar reports since then.
The current version is now 1.5.1 rather than 1.5.0 when this issue was opened.


Add get/create/end poll endpoints

First part of Twitch changelog (2021‑05‑03)

Pull Request Test Coverage Report for Build 818311025

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.1%) to 95.916%

Totals

Change from base Build 783377138:
0.1%

Covered Lines:
916

Relevant Lines:
955

💛  - Coveralls


Socket io, fixes and cleanup

fixed create chat and addAuthHeader helper

create chat wasn't properly updating the store and erroring when accessing a chat upon its creation since there was no users arr being returned from the post request
removed the userId stuff from addAuthHeader since unnecessary - the JWT payload includes the user id and is therefore already accessible to the server if necessary
updated addAuthHeader so header always includes content-type and accept 'application/json' so that post requests are delivered correctly, i.e. with a non-empty request body

updated naming for fetch and actions (re: slack convo)
cleanup

Header was moved outside of ScrollView component, so that the header is actually sticky
removed unused imports

socket io for messages inc reactions

this is my first pass at this and i'm not totally sure how best this should be formatted. lmk what you think.

i tested it and it's really awesome!!
did you see a bunch of warning messages? i guess it's normal https://github.com/socketio/socket.io-client/issues/1290 and can be suppressed - https://stackoverflow.com/questions/53638667/unrecognized-websocket-connection-options-agent-permessagedeflate-pfx

i tested it and it's really awesome!!
did you see a bunch of warning messages? i guess it's normal socketio/socket.io-client#1290 and can be suppressed - https://stackoverflow.com/questions/53638667/unrecognized-websocket-connection-options-agent-permessagedeflate-pfx

thank you!
and yes, i knew i was forgetting to mention something. it's an expected warning. and as far as i know, there isn't a way to get rid of the warning, but there was at some point a way to silence the warning, but that doesn't work either - anymore at least. womp, womp.

pr just updated 👀to include socketio + redux handling for:

adding user to chat
removing user from chat (since we only allow a user to remove themselves from a chat rn, i added an add'tl action type for removing self from chat so we can perform a different update to the state/store for the user making the request)
closing socket connection if open upon user logout (on settings screen)

the related server-side changes are here

+1


Buffer size warnings with GCC 7.2

When compiling CFE with GCC version 7.2, some new warnings about possible buffer overflow appear in the CFE ES shell code.  For Example:
{{{
cfe/fsw/cfe-core/src/es/cfe_es_shell.c:293:83: error: ‘, Prnt App Name: ’ directive writing 17 bytes into a region of size between 6 and 55 [-Werror=format-overflow=]
sprintf(Line,"Task ID: %08d, Task Name: %20s, Prnt App ID: %08d, Prnt App Name: %20s\n"
}}}

Imported from trac issue 239.  Created by jphickey on 2018-05-21T14:24:12, last modified: 2019-07-03T13:15:28

Trac comment by jphickey on 2018-05-21 14:29:58:
On the system where this warning was found, OS_MAX_API_NAME is defined as 64 rather than 20, which means the default size of 128 for the Line buffer is no longer sufficient.
Proposed solution is to size the local buffer appropriately, AND use snprintf instead of sprintf, just in case.   Note that using snprintf does not squelch the warning, that is just to protect against actual overflow in the event that the warning was ignored or not enabled.
Code change is fairly simple.

Trac comment by jphickey on 2018-05-21 15:04:33:
Fix is ready for review in branch trac-239-fix-gcc72-format-warning commit [changeset:768e685]

Trac comment by jphickey on 2018-10-02 15:10:44:
Reviewed at 2018-10-02 CCB and merged into ic-ccb-20181002

Trac comment by jphickey on 2018-10-10 09:02:26:
Fix is now included in development branch

Trac comment by jphickey on 2018-10-02 16:32:56:
Confirmed that 32bit + 64bit builds are successful and all unit tests pass

Trac comment by jhageman on 2019-07-03 13:15:28:
Moved closed tickets targeting 6.6.1 to 6.7.0 end of summer release.


Issue when MPL drawing circuits - scale issue

Information

Qiskit Terra version: 0.8.0
Python version: 3.7.3
Operating system: OS X - Version 10.9.5

What is the current behavior?
By default if you have large names within the circuit, some of them will be out of the resultant diagram.
Steps to reproduce the problem
You need to put large names to the circuit elements. For example this code
https://github.com/Morcu/q-means/blob/master/visualizer.py
style = {'backgroundcolor': '#DFEAEC', 'showindex': False, 'displaycolor': {
'id': 'red', 'meas':'#0066DA', 'h': '#00DAA7', 'u3': '#EFFF1B'} }
qc.draw(output='mpl', style=style, reverse_bits= False,filename=circuit_file)
An example of the resultant circuit
https://github.com/Morcu/q-means/blob/master/circuit-without-scale.png
What is the expected behavior?
We think that by default the scale parameter should be set to include large name of the circuit elements.
style = {'backgroundcolor': '#DFEAEC', 'showindex': False, 'displaycolor': {
'id': 'red', 'meas':'#0066DA', 'h': '#00DAA7', 'u3': '#EFFF1B'} }
qc.draw(output='mpl', style=style, reverse_bits= False,filename=circuit_file,scale=1.2)
The resultant circuit should be like this
https://github.com/Morcu/q-means/blob/master/circuit-with-scale.png
Suggested solutions
By default the scale should be calculated according to the circuit larger names.

What is the expected behavior?

What is the expected enhancement?

Another example: #2779


Globs or multiple files in replacements

I'm converting my custom release scripts to this crate and I have replacements that apply to multiple files. My specific case is that I have snapshot tests for the help messages, and those include the version. So my custom scripts do this:
sed -E -i "s/watchexec(.exe)? $extver/watchexec\1 $newver/" cli/tests/snapshots/help__*

Disregarding the capture in the regex (see #418), replicating this in release.toml looks a bit like:
[[pre-release-replacements]]
file = "tests/snapshots/help__help_windows.snap"
# ...

[[pre-release-replacements]]
file = "tests/snapshots/help__help_unix.snap"
# ...

It's annoying to have to repeat this. I'd much rather do:
[[pre-release-replacements]]
file = "tests/snapshots/help__*.snap"
# ...

or maybe
[[pre-release-replacements]]
file = [
  "tests/snapshots/help__help_unix.snap",
  "tests/snapshots/help__help_windows.snap",
]
# ...

Looks like we have an existing issue for this. Closing in favor of https://github.com/crate-ci/cargo-release/issues/104


Upgrade to react-styleguidist 6.x

We've recently upgraded to React Styleguidist v6.0.24 and have noticed a small bug with Snapguidist around the colour changes on diffs:
Before

After

We're trying to pin down whether this was due to RSG only supporting Webpack 2 now, some Babel changes or something else entirely.
Everything else with Snapguidist seems to still be functioning perfectly (snapshots, diffs etc) -- it's just the colour that's dropped off.
Would love to raise a PR and help if you can point me in the right direction!

@MicheleBertoli Are you able to replicate this bug at all?

Hello @iamtyce thanks for opening this issue.
Sorry for the late answer, but I was abroad for a conference (JSCamp Romania).
I won't be able to repro this until tomorrow but please feel free to submit a PR, I'll be happy to review it.

@MicheleBertoli No worries, hope JSCamp was fun! 😁 I haven't been able to figure out the source of the issue but would love to see if you can pinpoint the problem..? I'll keep trying today and will comment here if I can find something out.

Thank you very much @iamtyce.
The issue has something to do with CodeMirror.
When it works (with an old version), the output is the following:

When it doesn't (current version), the output is the following:

Looks like you have the same issue: https://github.com/styleguidist/react-styleguidist/issues/611

@sapegin Thanks for figuring out the bug, much appreciated! I've updated rsg to 6.0.26 and can see I'm now using react-codemirror 2.0.0 but still have the missing CSS issue.
I'm still seeing the following (missing class) markup, too:
+ Received

@iamtyce It should be fixed in Snapguidist too — react-codemirror should be replaced with the latest react-codemirror2.

Ah, got it! I might raise a PR for @MicheleBertoli now 👍


Add tests to verify copy and add with environment substitution.

Also removed an unecessary check for length of flagArgs list.
Signed-off-by: Daniel J Walsh<EMAIL_ADDRESS>

@bparees I was working on tests when you merged the PR.  Here are the tests.

Added tests for https://github.com/openshift/imagebuilder/pull/149

/lgtm


update linters

We fix gometalinter version (and its linter versions) by using docker image. It seems some linters are old and not effective, maybe we should consider updating it.

bin/linter.sh script has been updated to no longer use a docker image and instead specific version of lint/vet/fmt


[ADDON] Windows node support

Is your feature request related to a problem? Please describe
No.
Describe the solution you'd like
Adding Windows worker node as a Self-Managed add-on.
Describe alternatives you've considered
No alternatives.
Additional context
Having a Self-Managed add-on such as:
// Self-managed Add-ons
        new blueprints.addons.WindowsSupport(),

To enable Windows Support a ConfigMap is needed to be added to the cluster: (VPC-Resource-Controller-ConfigMap):
apiVersion: v1
kind: ConfigMap
metadata:
  name: amazon-vpc-cni
  namespace: kube-system
data:
  enable-windows-ipam: "true"

Hi @marciogmorales did you intend to open this feature request for cdk-eks-blueprints?

Yes,
Let me open over there too.

this support is already provided today https://github.com/aws-ia/terraform-aws-eks-blueprints/blob/34921232356fb69b5a41094246d488c37c596d97/main.tf#L129


chromium: Build with VA-API but disable it by default

This makes it possible to enable VA-API without having to rebuild
Chromium.
Co-Authored-By: ElXreno<EMAIL_ADDRESS>Co-Authored-By: misuzu<EMAIL_ADDRESS>
Motivation for this change
Alternative implementation of #85076. Solves the VA-API part of #82443.
Advantages:

Doesn't require --ignore-gpu-blacklist, i.e. VA-API can be configured independently of other GPU features
Will explicitly break all existing VA-API setups (vs. silently). Bonus: We could add instructions via a throw statement.
Doesn't interfere with commandLineArgs. I.e. we don't accidentally enable VA-API if that argument is set.
Disadvantages:
More complex!

TODOs:

[x] Add a throw statement for useVaapi?
[x] Check the Ozone build (WIP). At least on M80 the build did fail (I wrote a possible fix, but for now it seems best to disable VA-API for Ozone).
[x] Add some documentation
[ ] Verify the build on AArch64
[ ] Update the NixOS wiki after this PR (documentation)

Tests:

[x] On a working VA-API setup
[ ] Without any VA-API drivers
[x] With XWayland (expected: VA-API doesn't work, depending on the driver)

enableVaapi = false: Works as expected

Only drawback: Additionally prints vaInitialize failed: unknown libva error
But: chrome://gpu now even shows the correct Video Decode information: Unavailable -> Software only. Hardware acceleration disabled

enableVaapi = true: Wrong VA information, but ok

The same as before, but chrome://gpu now incorrectly shows Video Decode: Hardware accelerated (despite the libva error and VA not actually working)

[ ] Optional: In a VM
[x] Invalid LIBVA_DRIVER_NAME value: Fallback to SW rendering (only wrong VA information shown, like in the second XWayland case)
[x] VA-API on radeon almost works now (at least on my old HD 6950) \o/

Was broken before, probably fixed in the meantime by a Mesa update
Update: There are some minor visual glitches left at the bottom of the screen but it's watchable (vs. completely visually broken as before)

Note: We could also add chromium-vaapi but I'd like to avoid that for now (as we're still experimenting with it).
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

For some reason I tought this was already enabled. I think we should build with va-api by default, it's pretty common feature.

I added some minor improvements but it's basically a refactoring except for the Ozone "fix" and added deprecation note via throw (but the derivations for chromium and chromium.override { enableVaapi = true; } remain unchanged).

@thefloweringash nearly forgot to ask: Could you test this on AArch64 to see if the build still works or if we have to disable VA-API there?

I'm not sure what to make of this.
On Aarch64 it does build and run, but the GPU thread crashes during startup and prints a backtrace including VADisplayState::Initialize. Inspecting chrome://gpu shows the following warning:

GPU process was unable to boot: GPU process crashed too many times with SwiftShader.
Disabled Features: all

Software webgl is no longer available. This happens even with the default chromium running with --disable-accelerated-video-decode --disable-accelerated-video-encode.
This could be a symptom of my particular graphics stack. I only have one graphical system to test this on at the moment and I'm using the panfrost driver which IIUC is still under active development.

@thefloweringash huge thanks for your testing, that's very helpful! As for AArch64 I decided to disable VA-API for now as I'm not sure if we could get this to work properly across all platforms or if we even package VA-API drivers for GPUs on ARM systems.
If you have time for it: Could you test the new version of this PR again (which would also cover #85360) to verify that the regressions are gone. The only difference for AArch64 should now be the additional --disable-accelerated-video-decode --disable-accelerated-video-encode flags (could be avoided as well but then we might risk enabling VA-API at runtime if we should build it for AArch64 in the future).

Note: I'll try to run some more tests on x86_64, seems like this change is more complicated than anticipated. I also realized that I did only test this on systems where I tested VA-API before and it's properly supported. I'll try to test the following cases as well:

Without any VA-API drivers
With XWayland (doesn't work, depending on the driver)
Optional: In a VM

Tested on aarch64: some browsing, youtube and software webgl are working. LGTM.

My testing on x86_64 didn't show any important regressions, let's hope this'll work well with any GPU+driver combination (at least for the default case with enableVaapi = false). Also this PR should at least avoid the regressions from the last PR since we disable VA-API at runtime by default for now.
I'll merge it now :tada:
Note: The last force-push was just to clean up the history (rebase+squashing - no other changes).

enableVaapidoes not seem to be passed to mkChromium

@offlinehacker that's intentional, it only affects the wrapper ;)


Config Server - Unable to load application properties

Hi Team,
We are experiencing an unusual issue with our config server. After upgrading our Spring Boot 2.7.12 and Spring Cloud versions 2021.0.7, our micro-services in Kubernetes are failing to start because the config server (3.1.7) is unable to load the application properties. Initially, we thought it was a one-time occurrence, but it has become a recurring problem. We have had to retry the application startup multiple times for the config server to successfully retrieve the properties. Despite checking the config server logs, we have not found any error messages. The config server was up and running.

Due to technical difficulties with version 17, we are unable to switch to Spring Boot 3.x.x at the moment.

Below is the error from the applications trying to connect to config server to load the properties:
2023-07-21 07:45:01.339  INFO 10796 --- [           main] c.c.c.ConfigServicePropertySourceLocator : Fetching config from server at : http://localhost:8888
2023-07-21 07:48:06.418  INFO 10796 --- [           main] c.c.c.ConfigServicePropertySourceLocator : Connect Timeout Exception on Url - http://localhost:8888. Will be trying the next url if available
2023-07-21 07:48:06.418  WARN 10796 --- [           main] c.c.c.ConfigServicePropertySourceLocator : Could not locate PropertySource: I/O error on GET request for "http://localhost:8888/test-assignment-process/fin-sit": Read timed out; nested exception is java.net.SocketTimeoutException: Read timed out
2023-07-21 07:48:06.420  INFO 10796 --- [           main] com.mutual.fin.CommonStepDefs          : The following 1 profile is active: "fin-sit"
2023-07-21 07:48:06.583  INFO 10796 --- [           main] o.s.cloud.context.scope.GenericScope     : BeanFactory id=f173beaa-62bd-3636-b713-bd549510b7f8
2023-07-21 07:48:06.625  WARN 10796 --- [           main] s.c.a.AnnotationConfigApplicationContext : Exception encountered during context initialization - cancelling refresh attempt: org.springframework.beans.factory.UnsatisfiedDependencyException: Error creating bean with name 'sessionContextStaticWrapper': Unsatisfied dependency expressed through field 'testProps'; nested exception is org.springframework.beans.factory.BeanCreationException: Error creating bean with name 'testProperties': Injection of autowired dependencies failed; nested exception is java.lang.IllegalArgumentException: Could not resolve placeholder 'fin.url' in value "${fin.url}"
2023-07-21 07:48:06.628  INFO 10796 --- [           main] ConditionEvaluationReportLoggingListener :

Error from the Jenkins:
+ curl http://localhost:8888/actuator/health
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
Cancelling nested steps due to timeout
Sending interrupt signal to process

<EMAIL_ADDRESS>line 1: 32723 Terminated

curl http://localhost:8888/actuator/health
script returned exit code 143

Could you provide any suggestions?

Just to be clear it is the confit server having the problems not the config client correct?  You provided the client logs in the issue.

Yes it is the config server..

So its the clients failing to load configuration from the config server, not the config server failing to load the configuration from the back end environment repository, correct?

So its the clients failing to load configuration from the config server, not the config server failing to load the configuration from the back end environment repository, correct?

Yes, thats correct.

So its not an error with the config server its an error with the config clients.
Could not locate PropertySource: I/O error on GET request for "http://localhost:8888/test-assignment-process/fin-sit": Read timed out; nested exception is java.net.SocketTimeoutException: Read timed out
There is not much to go on with the error above, but ultimately it seems like a network issue.  You said this only started happening after an upgrade, if you revert to the previous version does the problem go away?

So its not an error with the config server its an error with the config clients.
Could not locate PropertySource: I/O error on GET request for "http://localhost:8888/test-assignment-process/fin-sit": Read timed out; nested exception is java.net.SocketTimeoutException: Read timed out
There is not much to go on with the error above, but ultimately it seems like a network issue. You said this only started happening after an upgrade, if you revert to the previous version does the problem go away?

We dint try to revert to the old version, as we were thinking, if something can be done to make sure the client will be compatible with the new version.

Compatible? Are the config client and config server using different versions?

Unfortunately, we have combination of services that are using Spring versions < 2.5.x and that uses a config client of 3.0.X and few other services are inline with the config server spring boot version i.e 2.7.12

What version of Spring Cloud is the config server using?  What version(s) of Spring Cloud are you using in your clients?  In the example above with the failures, what version of Spring Cloud was that app using?

What version of Spring Cloud is the config server using? What version(s) of Spring Cloud are you using in your clients? In the example above with the failures, what version of Spring Cloud was that app using?

The Spring cloud for the config server is 2021.0.7 and few applications are using 2021.0.7 and few of them are using 2020.0.3. The failure is observed in the apps that are using cloud version as 2020.0.3

While its not something we would recommend, I dont see how this issue could be cause by using a 2021.0.x config server and a 2020.0.3 config client.  Like I said above the errors appear to be network related.  That said we no longer support 2020.0.x its end of life at this point.
Have you tried just making the request from within the same container yourself?  For example, curl http://localhost:8888/test-assignment-process/fin-sit?

While its not something we would recommend, I dont see how this issue could be cause by using a 2021.0.x config server and a 2020.0.3 config client. Like I said above the errors appear to be network related. That said we no longer support 2020.0.x its end of life at this point.
Have you tried just making the request from within the same container yourself? For example, curl http://localhost:8888/test-assignment-process/fin-sit?

We are thinking to move ahead and refactor our services to use 2021.0.x. When we encountered this error, which we are encountered even today, I did try to make the request from the service container, it failed, but from within the config server, it gave the expected result.

If it’s failing also using curl it’s not an issue with the config client, again this seems like a network issue outside of our control.

im issuing same problem my services canot fetch properties when i run compose.yml file

i was searching for 10 days stackoverflow,slack,udemy,google,youtube and nothing helps me .... how to solve this issue
version: '3.8'
services:
elasticsearch:
image: docker.elastic.co/elasticsearch/elasticsearch:8.11.1
ports:
- "9288:9288"
jms:
container_name: jms
image: vromero/activemq-artemis
ports:
- "8161:8161"
- "61616:61616"
zipkin:
container_name: zipkin
image: openzipkin/zipkin
ports:
- "9411:9411"
eureka:
container_name: eureka
image: sfgbeerworks/mscc-eureka-server
ports:
- "8761:8761"
config:
container_name: config
image: sfgbeerworks/mscc-cloud-config
ports:
- "8888:8888"
depends_on:
- eureka
environment:
EUREKA_CLIENT_SERVICEURL_DEFAULTZONE: http://username:password@eureka:8761/eureka/
EUREKA_INSTANCE_PREFER_IP_ADDRESS: 'true'
inventory:
container_name: inventory
image: sfgbeerworks/mscc-beer-inventory-service:latest
ports:
- "9501:9501"
depends_on:
- jms
- eureka
- config
environment:
EUREKA_CLIENT_SERVICEURL_DEFAULTZONE: http://username:password@eureka:8761/eureka/
EUREKA_INSTANCE_PREFER_IP_ADDRESS: 'true'
SPRING_ARTEMIS_HOST: jms
SPRING_DATASOURCE_URL: jdbc:mysql://host.docker.internal:3306/beer_inventory_2?useUnicode=true&characterEncoding=UTF-8
SPRING_PROFILES_ACTIVE: local-discovery,local
SPRING_CONFIG_IMPORT: optional:configserver:http://config:8888
SPRING_CLOUD_CONFIG_URI: http://config:8888
SPRING_CLOUD_CONFIG_PROFILE: local
SPRING_APPLICATION_NAME: inventory
restart: on-failure
beer:
container_name: beer
image: sfgbeerworks/mscc-beer-service:latest
ports:
- "9500:9500"
depends_on:
- jms
- eureka
- config
- inventory
environment:
EUREKA_CLIENT_SERVICEURL_DEFAULTZONE: http://username:password@eureka:8761/eureka/
EUREKA_INSTANCE_PREFER_IP_ADDRESS: 'true'
SPRING_ARTEMIS_HOST: jms
SPRING_DATASOURCE_URL: jdbc:mysql://host.docker.internal:3306/beer_service_2?useUnicode=true&characterEncoding=UTF-8
SPRING_PROFILES_ACTIVE: local-discovery,local
SFG_BEER_INVENTORY_SERVICE: http://inventory:9501
SFG_BEER_ORDER_SERVICE: http://order:9502
SPRING_CONFIG_IMPORT: optional:configserver:http://config:8888
SPRING_CLOUD_CONFIG_URI: http://config:8888
SPRING_CLOUD_CONFIG_PROFILE: local
SPRING_APPLICATION_NAME: beer-service
restart: on-failure
order:
container_name: order
image: sfgbeerworks/mscc-beer-order-service
ports:
- "9502:9502"
depends_on:
- jms
- eureka
- config
- beer
environment:
EUREKA_CLIENT_SERVICEURL_DEFAULTZONE: http://username:password@eureka:8761/eureka/
EUREKA_INSTANCE_PREFER_IP_ADDRESS: 'true'
SPRING_PROFILES_ACTIVE: local-discovery,local
SPRING_ARTEMIS_HOST: jms
SPRING_DATASOURCE_URL: jdbc:mysql://host.docker.internal:3306/beer_order_service_2?useUnicode=true&characterEncoding=UTF-8
SFG_BREWERY_BEER-SERVICE-HOST: http://beer:9500
SPRING_CONFIG_IMPORT: optional:configserver:http://config:8888
SPRING_CLOUD_CONFIG_URI: http://config:8888
SPRING_CLOUD_CONFIG_PROFILE: local
SPRING_APPLICATION_NAME: order
restart: on-failure
gateway:
image: sfgbeerworks/mscc-gateway
ports:
- "9090:9090"
depends_on:
- eureka
- config
- inventory
- beer
- order
environment:
EUREKA_CLIENT_SERVICEURL_DEFAULTZONE: http://username:password@eureka:8761/eureka/

when i check url in my browser it works perfecly fine and when i run everytihng localy outside of container it works fine

Please open another issue with a sample to reproduce the problem

Sorry when i create issue like this https://github.com/spring-cloud/spring-cloud-config/issues/2355 is it visible to everyone because no one answer me :) im just cuirous . thanks


Do not add liquid to the machine

I try to add liquid to the machine,such as Electrolysis machine,Liquid mixer and Liquid fuel generator.
But I cannot do it.

At least the liquid mixer block is adressed in #284 but i will look into the others as well.


[1.6.x] Fix whitespaces after else{...} and elseif{...} is not shown

The parser does not recognize whitespace after else {...} as a plain, so it is not showing.
Refs #711

Oh, I didn't notice the document. As you say, it has to be changed as the following. Thanks.
  *   elseCall : whitespaceNoBreak? "else" whitespaceNoBreak? expressionPart

Furthermore, I noticed that elseIfCall has the same bug as elseCall. I'll fix it too.
@(b: Boolean, b2: Boolean)
x@if(b) {ifbody} <-whitespace
x@if(b) {ifbody} else if(b2) {elseifbody} <-whitespace

scala> com.github.yousuketto.txt.sample(true, false)
val res0: play.twirl.api.TxtFormat.Appendable =
xifbody <-whitespace
xifbody<-whitespace

scala> com.github.yousuketto.txt.sample(false, false)
val res1: play.twirl.api.TxtFormat.Appendable =
x <-whitespace
x<-whitespace

scala> com.github.yousuketto.txt.sample(false, true)
val res2: play.twirl.api.TxtFormat.Appendable =
x <-whitespace
xelseifbody<-whitespace

I also fixed a bug in elseIfCall. If we need to split this pull request, I'll split it. Please let me know.

Perfect, thanks!

@Mergifyio backport main

Thanks! This is now included in just released twirl 1.6.3 and 2.0.2

https://github.com/playframework/twirl/releases/tag/1.6.3
https://github.com/playframework/twirl/releases/tag/2.0.2

It's so helpful. Thanks for releasing.


Cannot use automatic updates when installed remotely

Checklist

[X] I'm reporting a problem with Chatterino
[X] I've verified that I'm running the most recent nightly build or stable release
[X] I've looked for my problem on the wiki
[X] I've searched the issues and pull requests for similar looking reports

Describe your issue
If using an install on a networked drive, the Chatterino automatic updater fails to complete.
Screenshots
No response
OS and Chatterino Version
Chatterino 2.5.1 (commit eafcb941) built with Qt 6.5.0, MSVC 193833135 Running on Windows 11 Version 23H2, kernel: 10.0.22631

Thank you for reporting this issue. I believe there are not many of our contributors who have a network drive and are willing to spend the time to investigate this issue. I would be fine with declaring this use case as unsupported and requiring a local installation, and closing this ticket.

If you're looking for someone to assist in developing this feature, I'm a professional engineer of 20 years (mostly MSVC and .NET) and I'd be willing to give you a hand.

We welcome PRs - let us know if you run into any issues while working on this

Sure, I'll clone the repo locally and give it a look.


Improve ordering of fields of VPC router detail tab

The field we use most are now on the top:

name
state
hypervisor
link local ip
redundant state

The other fields are nice, but not needed most of the time.
Result:

Before:

I agree with this at first sight. so LGTM but is this debatable? that would inspire a requirement to have it conigurable or so, no? maybe this is not the place for that discussion but that doesn't keep me from starting it.

@DaanHoogland I debugged so many routers recently that I think it's fair to say this info on the top is most valuable :-) But feel free to disagree.

@remibergsma sounds like you got the tone of comment just right.

Made Simple - LGTM - Can we look at making these Fields configurable?

I agree that it would be nice for this to be configurable (in the future). But I will say that those 5 fields are also the ones we use religiously when in VR Hell ;-)
LGTM.

@swill this is a well tested UI change with several LGTM, can you(we) merge?

Yes, I think this is good.  I will add it to the list of merges I will do later today.


Beautify JS resources and use async/defer on JS

This commit does two main things. The first is that it takes a variety of JS
resources and leverage JSBeautifier (http://jsbeautifier.org/) to fix
indentation and misc spacing issues in JS resources.
Additionally this commit also leverages HTML5 'async' and 'defer' attributes for

Does this commit look good?

Ha, I thought that I merged it! I'll relook at it tomorrow and be sure to
merge.
On Nov 5, 2015 8:38 PM, "Osman Surkatty"<EMAIL_ADDRESS>wrote:

Does this commit look good?
—
Reply to this email directly or view it on GitHub
https://github.com/boknows/cFIREsim-open/pull/59#issuecomment-154258520.

Thank you :)


Slight Translation Error

In the german version, there is an small error in the introduction/explainer text for the ADD and SHL chips. It says that ADD "subtrahiert" 1 from the number, when instead it "addiert" 1.

fixed in 1.20. (That was easy.)

Thanks for the great work!


error when inside a ./subdirectory

~ gush i:take 1626                                  Luiss-MacBook-Pro [2:08:15]
 ! [NOTE] You did not set or provide an adapter-name for the repository-manager
 ! and/or issue-tracker.
 !
 ! Based on your Git remote "origin" Gush detected "github" is properly the
 ! correct adapter.
 ! But for future reference and better performance it is advised to run
 ! "core:init".

 ! [NOTE] You did not set or provided an organization and/or repository name.
 !
 ! Gush automatically detected the missing information.
 ! Org: "x" / repo: "x"
 ! But for future reference and better performance it is advised to run
 ! "core:init".

  [RuntimeException]
  error: pathspec 'x/master' did not match any file(s) known to git.

issue:take [-ra|--repo-adapter REPO-ADAPTER] [-o|--org ORG] [-r|--repo REPO] [-ia|--issue-adapter ISSUE-ADAPTER] [-io|--issue-org ISSUE-ORG] [-ip|--issue-project ISSUE-PROJECT] [--] <issue_number> [<base_branch>]

You can only run Git commands when you are in the root directory of the repository, the git checkout command cannot find the Git references.
We should give an error when running a Git command within a none-root/repository folder.
I actually wanted to do that already :laughing: but I did not find it a big problem :smirk:

yeah i know you can see how prolific gush makes me that i send PRs a lot so i guess it was a flurry or frenzy, for those cases :+1:

#446


Allow the use of a custom template

Hi,
I think that would be a good idea to allow the use of a custom template through .

Codecov Report

Merging #9 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master       #9   +/-   ##
=======================================
  Coverage   93.18%   93.18%
=======================================
  Files           5        5
  Lines         132      132
  Branches       19       19
=======================================
  Hits          123      123
  Misses          2        2
  Partials        7        7

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d08da11...5822d83. Read the comment docs.

This is doable with the current api by extending the menu component, you can see an example of how to do this in the test: https://github.com/mattlewis92/angular-text-input-autocomplete/blob/master/test/text-input-autocomplete.directive.spec.ts#L280-L287
Would happily accept a PR here to improve the docs!


Is there an equivalent to numpy fft.irfft?

Thank you to produce this library. Does it contain an equivalent to numpy fft.irfft? I did find the complex inverse.
https://numpy.org/doc/stable/reference/generated/numpy.fft.irfft.html
I am a C# programmer, so I understand how to convert from in-place to generating a new array.

Hi @FrankHileman, thank you for this question!
Presently no, FftSharp does not have an irfft function. I'd be happy to add one in though!
I would probably name it InverseReal() It could live alongside the ForwardReal() function:
https://github.com/swharden/FftSharp/blob/6f341bb1f33a7c99ad09470a9d81caf0a2471126/src/FftSharp/FFT.cs#L64-L74
If you wish to add this and create a pull request, I would be happy to merge it in and publish a new package with this feature

Hello @swharden, Thank you for the reply. I am still reading about how to convert an inverse complex method into an inverse real method, so I am not in a position to implement it immediately.

I will have a look if it can be based in this implementation:
https://github.com/hughpyle/inguz-DSPUtil/blob/master/Fourier.cs#L198

Maybe could be based on this implementation:
https://innovatiestudio.hku.nl/?p=1213


Gutenberg-web-scrapper

Description
Add a new web scrapper to scrape data from gutenberg website and save it in a JSON file
Related Issues
Issues #29
Changes Made
Add a new web scrapper to scrape data from gutenberg website and save it in a JSON file
Checklist
Please review and check the following before submitting your pull request:

[x] I have followed the project's coding conventions and guidelines
[x] I have tested my changes thoroughly
[x] I have added/updated relevant documentation
[x] My code follows best practices and is easy to understand
[x] I have added necessary test cases (if applicable)
[x] All existing tests are passing
[x] My changes do not introduce any new warnings or errors

@vigneshRamanathan3105 can u move the python file in to the scraper folder in the project

@neokd

I don't see a scraper folder do you want me to create a new folder  and move it there ?
and also I will be creating a new folder within "StoreHouse" and move my json into that.

If you sync the fork it will be under scripts/Scrapper


sendMessage doesn't send anything back

I very much appreciate your effort, but for each patch it still doesn't work somewhere else, so I'm switching to a much simpler solution (https://github.com/TommyBs/FBPHPMessengerBot). This very simple code worked immediately for text-only chat, which is what I need right now.
I doubt there's so much difference between PHP 5.5.9 and 5.6 that it would break the code.
Also a general advice is to not abstract the code so much. Verifying the Webhook is just this:
if (isset($_GET['hub_verify_token'])):
    if ($verify_token == $_GET['hub_verify_token']):
        echo $_GET['hub_challenge'];
        exit();
    endif;
endif;

This is 100% correct code, and there's no need for several levels of abstractions for such a simple thing.
Regards,
Anders

Thank you. Of course please use what suit you best. This code was intended mainly for my use, but why not share it with world? :) I caught a lot of bugs, so yay, hooray.
I like abstracting the code, but you don't have to. Your example work fine. Or you can use:
if ($bot->request->isSubscribe())
{
    if ($bot->request->verifyWebhookToken($webhookToken)):
        $bot->request->getChallenge();
        exit;
    }
}

So in my eyes it is not valid argument. If you wish you can do it many ways. But as I said, please use what suit you best.

This is off-topic, but related:
Have you also experienced that sending buttons don't work at all (whatever code is used).
I had no problem sending images via URL or images via file, but e.g. the following is simply ignored by Facebook, despite being correct according to the documentation. I set content-type correctly too. Anything you've seen?
{
    "recipient": {
        "id": "---------------------------"
    },
    "message": {
        "attachment": {
            "type": "template",
            "payload": {
                "template_type": "button",
                "text": "Where do you want to go?",
                "buttons": [
                    {
                        "type": "web_url",
                        "title": "Abiro",
                        "url": "http:\\/\\/abiro.com"
                    },
                    {
                        "type": "web_url",
                        "title": "CliqTags",
                        "url": "http:\\/\\/cliqtags.com"
                    },
                    {
                        "type": "web_url",
                        "title": "Twitizer",
                        "url": "http:\\/\\/twitizer.com"
                    },
                    {
                        "type": "web_url",
                        "title": "Google",
                        "url": "http:\\/\\/google.com"
                    }
                ]
            }
        }
    }
}

I solved the button problem: It only allows up to 3 buttons. Go figure.


Copy internal package to docker build context

The current build at HEAD is failing with
Step 9/14 : RUN CGO_ENABLED=0 GOOS=linux GOARCH=amd64 GO111MODULE=on go build -a -o manager main.go
 ---> Running in 3df6873e34bd
go: finding github.com/improbable-eng/etcd-cluster-operator/internal latest
go: finding github.com/improbable-eng/etcd-cluster-operator/internal/etcdenvvar latest
build command-line-arguments: cannot load github.com/improbable-eng/etcd-cluster-operator/internal/etcdenvvar: no matching versions for query "latest"

this is because we do not copy internal/ in to the container build context.
the docker build succeeds after applying this fix.
Successfully built 2a8a23ab3291
Successfully tagged etcd-operator:latest

😂
We should probably execute the Docker build in CI, and ideally publish the image tagged with the commit SHA up to Docker Hub or something.

@JamesLaverack yep certainly. in the short term the e2e tests will do a docker build for a sanity check


Added typescript in package.swift

Just adding it as a dependency does not make it work. Please check out this guide on how to add support for additional languages.


Virtual Scroll

I want to use viewer without paging. All pages ar shown in one canvas and use mause scroll to navigate in them. Is it have this propr.Thx .

This is not possible since react-pdf-js does not support virtual scroll


Font Size Option

Great little tool! an option to increase font size would be nice.

Done! If you have at least the 0.0.4 version you should be able to update from within the Zotero add-ons screen.


Create link checker for contributor urls

Overview
We need to know in an automated way when links don't resolve so we can update them manually.
Action Items
Product

[ ] Define the behaviour of the broken link
Product wants the script to run weekly and to open an issue which is a link report - MVP > everything is good or here are the broken links. Review post MVP.

Design
Development

[ ] First draft - Provide output of link checker for review to see how useful it will be.
[ ] Build link check in script
[ ] Run on schedule

Resources/Instructions
List of urls to check

Slack
Github
Meetup
Facebook
Website

@cnk
Progress:
Blockers:
Availability:
ETA:

This is for Organizations Links, right?

This is for Organizations Links, right?

@giosce Yes, its the links that will be listed on contributors card.

@giosce Yes, its the links that will be listed on contributors card.

Progress: None
Blockers: None
Availability: Limited for writing the code but if anyone (@giosce ?) wants to collaborate it will help move this along
ETA: Unsure.

Progress: None
Blockers: None
Availability: Limited for writing the code but if anyone (@giosce ?) wants to collaborate it will help move this along
ETA: Unsure.

Committed the first version of the script https://github.com/civictechindex/CTI-website-backend/pull/30
It needs to be run by hand and it records the results in a log file.
Next version(s) will record the results in the database (Link table itself) and run automatically.

Committed the first version of the script https://github.com/civictechindex/CTI-website-backend/pull/30
It needs to be run by hand and it records the results in a log file.
Next version(s) will record the results in the database (Link table itself) and run automatically.

OK so it looks like ALL the Twitter links are returning 400 - Bad Request. For now, I would suggest having your script skip all twitter links. I am also seeing a lot of 302s for Facebook so those may also need some special handling.
We will need to do some research to see if there is a way to automatically test Twitter links. Is there a header that allows us to test their validity (e.g. send UserAgent that doesn't look like a bot)? Or could we set up a twitter account for CTI and then create a Twitter developer app that could authenticate to make this requests?

OK so it looks like ALL the Twitter links are returning 400 - Bad Request. For now, I would suggest having your script skip all twitter links. I am also seeing a lot of 302s for Facebook so those may also need some special handling.
We will need to do some research to see if there is a way to automatically test Twitter links. Is there a header that allows us to test their validity (e.g. send UserAgent that doesn't look like a bot)? Or could we set up a twitter account for CTI and then create a Twitter developer app that could authenticate to make this requests?

I would say to merge the current code, it is already useful and with the database filter that I added it is possible to ignore the 400 and/or focus (manually) on the real problems. I have added also a "notes" field where one can type something to do or to know about one link.

I would say to merge the current code, it is already useful and with the database filter that I added it is possible to ignore the 400 and/or focus (manually) on the real problems. I have added also a "notes" field where one can type something to do or to know about one link.

@cnk will review PR and let us know when its ready.

@cnk will review PR and let us know when its ready.

@cnk will review tomorrow.

@cnk will review tomorrow.

PR https://github.com/civictechindex/CTI-website-backend/pull/30 still to be reviewed and merged.

PR https://github.com/civictechindex/CTI-website-backend/pull/30 still to be reviewed and merged.

Until PR 30 isn't merged I don't want to do any other backend work that can cause conflict.

Until PR 30 isn't merged I don't want to do any other backend work that can cause conflict.

@giosce Put in a PR that is a sum of the issues but doesn't address Facebook and Twitter.

@giosce Put in a PR that is a sum of the issues but doesn't address Facebook and Twitter.

We can close this issue, improvements will be handle through issue #284.


Identification pipeline

Fixes

Connects the HTML tag collector and agency identifier in the start of a data source identification pipeline

Description

In an effort to build out a fully automated system for identifying and cataloguing new data sources, this pipeline starts by checking potential new data sources against all those already in the database, then runs actually new sources through the HTML tag collector, and then checking the hostnames against those of the agencies in the database

Docs

Updated readmes for repo and tag collector

@mbodeantor I made the readme a little more detailed, since the .py file didn't have its own readme like the other scripts. I think the way it's structured makes sense.


Add jerryscript-ext/autorelease.h with JERRYX_VAL and JERRYX_UNUSED

As discussed/proposed here:
https://github.com/jerryscript-project/jerryscript/issues/1836
TODOs:

[ ] Add documentation

cc @jiangzidong @zherczeg @akosthekiss @LaszloLango

LGTM, please fix the coding-style issues.

OK, fixed the code style issues.

Any comments on the naming of the macros?
JERRYX_VAL and JERRYX_UNUSED don't really explain that they are "autoreleasing".
But adding AUTO or something to the name makes the macro pretty long...
Once the naming is decided, I'll add documentation.

I agree. The current names are not descriptive enough. I think adding the AUTO does not make it too long. Maybe AR would be a good acronym for autorelease.

Maybe it's not too long indeed...
Both JERRYX_AR_VAL / JERRYX_AUTO_VAL are still shorter compared to const jerry_value_t, which is what I would otherwise write...

OK, reviewed your comments.
Once the macro name is OK with everyone, I'll add some documentation to this PR.

@LaszloLango @akosthekiss @zherczeg how does it look now? Is the naming OK?
If so, I'll add some docs. Thanks.

I'm OK with the current name.

OK, updated and added docs.
Hopefully the additions to update-webpage.sh work.
I don't couldn't figure out how to build & test the site locally...
@jiangzidong feel free to "commandeer" this PR when I'm away coming 2 weeks.

@LaszloLango Ha, after several attempts, I found the way to let one doc link to another doc's symbol
- [jerry_value_t](../docs/02.API-REFERENCE.md#jerry_value_t)

@bzsolt Will these kind of references do work on the webpage too?
[jerry_value_t](../docs/02.API-REFERENCE.md#jerry_value_t)

@akosthekiss @bzsolt Could you please help review this patch?


[WIP] Improve service logging

actually I misnamed this branch, it should be 3636
https://atlassian.kbase.us/browse/KBASE-3636
TODO

[x] document and iron out the existing logging
[x] logging during normal shutdown
[x]  logging during OOM or other abnormal shutdown

Current coverage is 78.96%

Merging #172 into develop will decrease coverage by -0.59% as of dfe5cb0

@@            develop    #172   diff @@
=======================================
  Files            21      21
  Stmts          2930    2995    +65
  Branches          0       0
  Methods           0       0
=======================================
+ Hit            2331    2365    +34
  Partial           0       0
- Missed          599     630    +31

Review entire Coverage Diff as of dfe5cb0

Powered by Codecov. Updated on successful CI builds.


CC SEO Experiment

This change is

Online preview: http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/bdc18244f08576a339a2006ff83b52c0b34d1f39/
Edited pages:

v19.2/cockroachcloud/index.md
v19.2/index.md

Online preview: http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/db5e6aaf8dec118d176ca3302f07f7d2fd6fdaae/

Online preview: http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/977bad5085d4ca492676512ca49b0946afa3c173/
Edited pages:

v19.1/index.md
v19.2/index.md
v2.1/index.md
v20.1/index.md


Support validation without create the training dataset and dataloader

Describe your feature request
Current validation (config.EVAL is True) mode still create and load training dataset and dataloader, which is not flexible when users only have val set.
So main method needs support val mode without touching training set.
Describe the reference code or paper
N/A
Describe the possible solution
I have a fix in ViT model, which can be used to other classification model.
Please refer to commit 9a7c105 for details.

I'll fix it later.


Update pul_metadata_services to remove whitespace from PULFA titles

Coverage remained the same at 100.0% when pulling 886dc8d4408ed22e950bf7190ab7333007d63c17 on update_pul_metadata_services into 8650962b845fbdd6bd107a1bb1f254deacb13653 on master.


odd-unstable/even-stable style of versioning is dropped in Linux kernel

The file release_notes.txt mentions the following policy on versions:

Our SOFA starts with 1.0.0 version and follows the rule of Linux Kernel release.

However, such odd-unstable/even-stable style of versioning is already dropped by Linux kernel. Thus, it is not an effective role model to refer.

Thanks jserv, we will remove "and follows the rule of Linux Kernel release" at release_notes.txt


Expose "tag" property to custom remove component.

I'm implementing "strikethrough" tag removal, wherein the user hovers over an existing tag, and the text is styled with text-decoration: line-through and upon clicking the text, the tag is removed.
The easiest way to accomplish it is to style css the existing react tags, to not display the real tag text, and update https://github.com/prakhar1989/react-tags/blob/master/lib/Tag.js#L73 to pass in props.tag, thereby making it possible to display the tag text in the custom remove component.

  {label}
  <RemoveComponent className={props.classNames.remove} onClick={props.onDelete} tag={props.tag} />

import React from 'react';

export default class ReactTagStrikethroughRemoveComp extends React.Component {
  render() {
    return (

        {this.props.tag.text}

    );
  }
}

Please let me know if you would like to include this in your library and I will submit a pull request.
Here's the commit on my fork: https://github.com/ricksuggs/react-tags/commit/8583adb33dd9c2108d8810b2c860082e899d6260
Thanks.

PR #202 should resolve this.


Disk Space Environment Data overflows int reporting garbage negative numbers

https://github.com/MindscapeHQ/raygun4android/blob/master/src/main/java/com/mindscapehq/android/raygun4android/messages/RaygunEnvironmentMessage.java#L95
The Disk space calculations use an integer when it should be using a long.
Integer.MaxValue() is approx 23^1 - 1
A GigaByte is 2^30
So anything over 2 Gigs overflows
See:
https://developer.android.com/reference/android/os/StatFs.html#getAvailableBlocksLong()
https://developer.android.com/reference/android/os/StatFs.html#getBlockSizeLong()

Hey,
Thanks for raising this, you're quite correct that it should be a long. The reason this wasn't added before now is due to legacy support as the minimum API level of the provider is 9 (Gingerbread) and this API was only made available in 18. Gingerbread is fairly long in the tooth at this point and while we aim to not make breaking changes where possible and support the maximum amount of devices, this seems like a worthwhile change to make as devices these days have a lot more storage space than legacy devices.
I will do some research into current version adoption and the impact that changing the minimum API version to 18 will have. If this is acceptable (which most likely it will) I'll make the change and do a release using the new long methods for the environment variables.

If backwards compatibility is an issue, you might instead opt to simply cast the returned int's from the API calls to longs before multiplying them together,  as typically on android the returned values should not be large enough on their own to overflow int.

Any word on this?

Unfortunately it looks like legacy platform usage is still relatively common for < API 18 (Jellybean) - we're looking at 3% according to  https://developer.android.com/about/dashboards/index.html. From a figure of 1.4 B devices active last year 42 million is a lot to exclude, and as this is an upstream vendor library providing backwards compatibility and the widest range of device support is a priority. The backwards compatibility is for the minimum API level; using getAvailableBlocksLong() requires raising this to API 18 which excludes those 42 M devices.
This is unfortunate as accurate disk space would be nice but blocking the provider from use is rather undesirable and directly conflicts with one of our design goals for the providers. A major version bump is a possibility however this excludes older devices from future features and fixes and introduces maintenance overhead which we strive to avoid. We'd like to keep an eye on this and will hopefully be able to upgrade the minimum version when sub-18 usage is below or around 1%.
In the meantime this provider is easily built with mvn so an alternative is to clone the repository, bump the API version in the POM, change the two lines of code and build it with mvn install.
Sorry we don't have a better story around this currently, ideally next year we'll see some version uptick and we can revisit it in the mainline release then.