[bug]

Is there an existing issue for this?

[X] I have searched the existing issues

RainbowKit Version
1.0.4
wagmi Version
1.3.3
Current Behavior
Hi, Great Team.
Hope you are doing well.
I got an error when I was trying to disconnect Trust Wallet from RainbowKit.
I am developing a project using Next.js and I am using RainbowKit to connect wallet.
Connection behavior was done successfully, but when I was trying to disconnect Trust Wallet, I got this error.
Unhandled Runtime Error
TypeError: provider.removeListener is not a function
I have attached the screenshot of detailed error.
I tried to test on several websites such as rainbowkit demos but got same error.
Please take a look and and fix this issue asap.
Any helpful feedback is appreciated.
Thank you.

Expected Behavior
Let's say I want to change wallet in the platform from Trust wallet to Metamask.
Because of this error, I can't connect another wallet such as Meta Mask as the previous session is still alive.
Steps To Reproduce
No response
Link to Minimal Reproducible Example (CodeSandbox, StackBlitz, etc.)
https://walletconnect-hzhu.vercel.app/
Anything else?
No response

Having the same issue with
"@rainbow-me/rainbowkit": "^1.0.4",
"@wagmi/core": "^1.3.3",
"react": "^18.2.0",
"viem": "^1.2.9",
"wagmi": "^1.3.4",

Hi @meri-maki and @smartworlddev. This is a known issue that we have reported to the Trust Wallet team. Their ethereum providers seems to be doing something different than the standard implementation, causing this downstream issue. We are still awaiting a response from them. Closing in favor of #1259

0.12.17 and 1.0.5 are now available with a fix for this issue.


any other ways to download in the remote servers?

any other ways to download in the remote servers?
i can only download the dataset in the chrome

https://developers.google.com/web/updates/2015/05/replay-a-network-request-in-curl


Sort By Price | Events should also be sortable by their price value.

There are only two options for sorting the events:-

Lowest Likes.
Highest Likes.

There should also be an option "Sort by price value"
https://github.com/user-attachments/assets/05406b38-4519-4b4f-a024-ab50c3da38ef

@TejasNasre, could you please assign this to me.

updates ?

Will raise PR by 2am tonight

Fix #139

I will assign you make different PR For That

Okay @TejasNasre sir, I will fix this after getting free of college

I will assign you make different PR For That

@TejasNasre sir, this PR already fixed the issue #139.


[github] add permission to read namespaces to the github-webhook (#1172)

Fixes #1172
This PR grants the github-webhook service account permission to read namespaces
As this is my first contribution, I hope that I did not miss something. Looking forward to your feedback!

/ok-to-test

Based on https://github.com/knative/eventing-contrib/pull/1178 I´m assuming that the permission was applied by mistake to the controller instead of the webhook. Because of the PR is closed with reference to this one, I´m shamelessly stealing @tzununbekov work and include it here.
However I´m reducing the scope (e.g. removing create - I´m pretty sure the webhook does not need to be able to do that ;) ) and adding patch as suggested by lberk.

/approve
@lberk  for LGTM

/lgtm
/approve


Complete Progress Bar when first running the app

Hi, i  just used your progress Bar and it's working perfectly fine with iOS but  not with Android device.
Actually, in the correspondent page it shows completed then it comes back to 0 and continue progressing.  In the constructor i specified that progress= 0 .. Do you have any idea ? Thanks

+1
Here is a screenshot of when my component first renders.

`import React, { Component } from 'react'
import ProgressBar from 'react-native-progress/Bar'
class AnimatedProgressBar extends Component {
constructor() {
super()
this.state = { progress: 0 }
}
componentDidMount() {
	setTimeout(
		() => this.setState({ progress: this.props.progress }),
		1000
	)
}

render() {
	return (
		<ProgressBar
			style={{marginLeft: 'auto', marginRight: 'auto'}}
			height={this.props.height}
			width={this.props.width}
			progress={this.state.progress}
			borderRadius={0}
			color={this.props.color}
			unfilledColor={this.props.unfilledColor || 'transparent'}
		>
			{ this.props.children }
		</ProgressBar>
	)
}

}
export default AnimatedProgressBar`

+1

OK cannot reproduce it myself, but attempted to work around this issue in 3.3.0. Try it! 😄


Relationships are not synced for the datasync (Offix Datastore relies on them to get data)

ObjectDelta missing relationship fields.

/cc @ssd71
/cc @craicoverflow, @machi1990
Automatically generated comment to notify maintainers

FYI @kingsleyzissou - I need to fix that first to get over the required data in order to filter it.

This is down as a bug - but this was intended behaviour and a known limitation until now. Should it be a feat?

Delta should contain exactly the state of the database. I see it as bug but not problem to make it feature :D

That's fine, let us keep it as a bug.

Docs will also need to be updated to include relationships in delta object.

Hey could I work on this issue? Can you please provide some more details about what needs to be done?

Hey could I work on this issue? Can you please provide some more details about what needs to be done?

I think @kingsleyzissou worked on this issue and we could technically close it due to solution available outside graphback. @kingsleyzissou Please close if you are happy with this

I think @kingsleyzissou worked on this issue and we could technically close it due to solution available outside graphback. @kingsleyzissou Please close if you are happy with this

Yep, I'll close this issue

Yep, I'll close this issue


Galaxia UI-system initialization

Description
Implement design system module
Alternative solution
No response
Additional Information
No response

finished in #8


lychee.ui.Blueprint: Layouting Engine (relayout event)

The lychee.ui.Blueprint implementation is the point where we apply all the intelligent algorithms for automated positioning, resizing and layouting of sub-Entities or sub-Layers.
As the Blueprint itself is grid-based, all children of it have dimensions in grid-space and therefore may need an additional flex = {x,y} property that describes in which dimension the Entity can be resized on different layouting priorities.

Necessary Implementation (as lychee.ui.Element is implemented) requires the following features:

lychee.ui.Blueprint inherits from lychee.ui.Layer
setEntities, addEntity, removeEntity etc. needs to be overwritten, so that Blueprint only contains Element instances.
reshape event triggers reshape of children and positions them modulo x on the grid.

Important notes and behaviours:

Figure out grid width and grid height, based on a 32px grid
Resize children based on their width and height when they are added to the entities[] property, so the element.width = element.width * gridsize etc.

The priorization sketch algorithm so far seems to be working on paper:
var f    = Math.sqrt(element.width / element.height);
var prio = Math.sqrt(element.grid.x + f * element.grid.y);

The factor f might work better for overflowing row-wrap behaviour with a constant of Math.sqrt(2) because that will fix the rectangles vs. squares problem.

As of @874ca1373ecfc45d216da26be41877eee81a42c3 this has been implemented and is already integrated with the UI and event stack. There's a new lychee.effect.Event for that purpose of UI graph synchronizations.
Missing functionalities are so far:

padding to the right side has to be respected, so overflow will happen when element.position.x > bb_box - 32 (only left side is respected atm)
addEntity, setEntities, setEntity, removeEntity shall allow only lychee.ui.Element instances (because of necessary entity.order (priorization) functionality

The swipe functionality for the lychee.ui.Blueprint implementation arrives with issue #134 automatically.

As of @8ceb4888f2625f03f5102623b13eff776a8bcff1 this has now all been implemented.
Woohoo! :sparkles:


Missing Nova 4 badge on novapackage.com

The packages is not shown as Nova 4 compatible on https://novapackages.com/packages/norman-huth/nova-values-field

The version is extracted from composer require:
https://github.com/tighten/novapackages/blob/c5d1a4fdaa822706d29bee56f6758d21fc06b9fb/app/Jobs/SyncPackagePackagistData.php#L47-L50

@dmason30 Thanks, I opened a PR which add the dependency on "laravel/nova": "^4.0",

Thanks for the info. I wanted to revise the package once anyway. Then I will of course update the requirements at the same time

@dmason30 Are you sure there is nothing else ?
https://novapackages.com/packages/norman-huth/nova-values-field
Nova package see the new version and the laravel/nova ^4.0 requirement, but still no "Nova 4 compatible" tag on the listing.

Maybe it will take a while until it is updated there.
In my opinion, you could generally suggest Tighten  a refactor of the Novapackages site.
Especially due to the growing community and the differences between Nova Orion & Nova Sivler Surver could be made clearer and more comfortable.
Maybe also a snipped section or so. I have so much stuff lying around. But creating a package always costs time, maintenance and so on and is not worth it in every case....

@dmason30 Are you sure there is nothing else ? https://novapackages.com/packages/norman-huth/nova-values-field novapackages.com see the new version and the laravel/nova ^4.0 requirement, but still no "Nova 4 compatible" tag on the listing.

Checking their console they syn the data every 2-3 hours

Weird, I swear I was seeing the updated 1.0.2 version, published: 25min ago and nova version: ^4.0 this morning but now it's back to 1.0.1 and published: 5 months ago and no nova version. That's why I was supprised to not see the Nova 4 compatible tag.
I'll check back tomorrow, thanks !


Include .js.map file for production debugging

Please include a .js.map file for each minified .js file. This allows the minified code to be debugged by mapping it back to the original source file.

@marwahaha I am first time contributor, I would like to contribute to this issue. Can you help?

I'm not sure how to do this, but I would read about Source Map files.
https://www.html5rocks.com/en/tutorials/developertools/sourcemaps/
https://raygun.com/blog/getting-started-with-javascript-source-maps/

Ok cool, even I’ll look into it👍🏻And raise a PR!!

@marwahaha Please review the PR.

fixed in https://github.com/moment/moment/commit/4dfe59b576e5a67597fa7a95934fa9f123f62e1b


Extract Repositories from settings.gradle.kts

Currently, the Repositories must be hard coded twice, once in the settings.gradle.kts and once in nix. It would be nice if the nix expression could extract the Repositories used from the settings.gradle.kts

Using an IFD + Gradle init script should work. Here is a quick proof of concept:
gradle -q -I ./listRepositories.gradle listRepositories

// listRepositories.gradle
gradle.settingsEvaluated { settings ->
    rootProject {
        tasks.register("listRepositories") {
            doLast {
                settings.pluginManagement.repositories.forEach { repo ->
                    if(repo.url != null) println(repo.url)
                }
                settings.dependencyResolutionManagement.repositories.forEach { repo ->
                    if(repo.url != null) println(repo.url)
                }
            }
        }
    }
}


Funny Noisemaker Spam Not Working

Latest Version of Fedoraware:
Config used:
https://anonfiles.com/13Z178K6xf/MelonHead2000_fed
Description:
Noisemaker Spam Not Working
Steps to reproduce:
Just turn on the noisemaker spam and it won't spam the noisemaker
Steps to reproduce the behavior:
Misc

Enable Noisemaker Spam

Additional context
it is most likely working just not set in the button of the noisemaker spam

No it just doesn't work

There is something very weird about the servercmdkeyvalues thing

it's because before they added the new menu it was working just fine that's why i thought it was just some miss placing of something ( the noisemaker thing no being in the button to activate )


fix: better render invocation with scoped subscription

While I was working on #54, I noticed a slight unexpected behavior. A hook can call render function several times when another hook bails out.
Turns out we should use scope subscription instead. This PR fixes it and adds the test spec for the expected behavior.

https://codesandbox.io/s/damp-river-8tkvu
Checked the example in #46 still works.


TB.TempDir fails if test writes a file during cleanup

What version of Go are you using (go version)?

$ go version
go version go1.15.5 linux/amd64

Does this issue reproduce with the latest release?
Yes
What operating system and processor architecture are you using (go env)?
go env Output
$ go env
GO111MODULE="on"
GOARCH="amd64"
GOBIN=""
GOCACHE="/home/howardjohn/.cache/go-build"
GOENV="/home/howardjohn/.config/go/env"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOINSECURE=""
GOMODCACHE="/home/howardjohn/go/pkg/mod"
GONOPROXY=""
GONOSUMDB=""
GOOS="linux"
GOPATH="/home/howardjohn/go"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/usr/lib/go-1.15"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/usr/lib/go-1.15/pkg/tool/linux_amd64"
GCCGO="gccgo"
AR="ar"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD="/home/howardjohn/go/src/istio.io/istio/go.mod"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build890005715=/tmp/go-build -gno-record-gcc-switches"

What did you do?
func TestTest(t *testing.T) {
	d := t.TempDir()
	go func() {
		c := 0
		for {
			ioutil.WriteFile(filepath.Join(d, fmt.Sprint(c)), nil, 0600)
			c++
		}
	}()
	t.TempDir()
}

What did you expect to see?
Test passes. Alternatively, this caveat is sufficiently documented in t.TempDir and/or RemoveAll.
What did you see instead?
Test fails with: testing.go:915: TempDir RemoveAll cleanup: unlinkat /tmp/TestTest064788875/001: directory not empty
This happens about 50% of the time in this case. In the real world scenario I am actually trying to test, it happens about 0.001% of the time, which makes it quite frustrating.
A manual version of t.TempDir which ignores this error passes, for what its worth.
func TestManual(t *testing.T) {
	d, err := ioutil.TempDir("", "test")
	if err != nil {
		t.Fatal(err)
	}
	t.Cleanup(func() {
		if err := os.RemoveAll(d); err != nil {
			if err.(*os.PathError).Op != "unlinkat" {
				t.Errorf("TempDir RemoveAll cleanup: %v", err)
			}
		}
	})
	go func() {
		c := 0
		for {
			ioutil.WriteFile(filepath.Join(d, fmt.Sprint(c)), nil, 0600)
			c++
		}
	}()
}

I think I understand why it works this way, and unfortunately I don't see any great options here, so perhaps just some documentation around this is the best path forward.

Also, I think the obvious answer is "your test is bad", but I am not sure it is.  We even check goroutines for leaks after tests (using something like https://github.com/uber-go/goleak), so we don't just have spurious goroutines flying around. The problem is cancelling the context doesn't just immediately kill the goroutines, so they do a few last things until they finally realize the context has been cancelled (in this case, writing a file).
It seems in these cases they only way you can actually write a correct test is something that ensures that a write is not triggered after the context has been cancelled, which I believe would require a lock around the context cancel and the file writing, which is extremely heavy and bizarre to support a testing edge case. The other alternative is to use something like goleak and wait until there are no goroutines sticking around, and make sure that is done before TempDir() so it occurs first - and also remember to do it on each subtest.
So at first glance its obvious that writing a file after the test is complete is wrong, but I also don't think its clear how to not be wrong.

Also, I think the obvious answer is "your test is bad", but I am not sure it is.  We even check goroutines for leaks after tests (using something like https://github.com/uber-go/goleak), so we don't just have spurious goroutines flying around. The problem is cancelling the context doesn't just immediately kill the goroutines, so they do a few last things until they finally realize the context has been cancelled (in this case, writing a file).
It seems in these cases they only way you can actually write a correct test is something that ensures that a write is not triggered after the context has been cancelled, which I believe would require a lock around the context cancel and the file writing, which is extremely heavy and bizarre to support a testing edge case. The other alternative is to use something like goleak and wait until there are no goroutines sticking around, and make sure that is done before TempDir() so it occurs first - and also remember to do it on each subtest.
So at first glance its obvious that writing a file after the test is complete is wrong, but I also don't think its clear how to not be wrong.

Also, I think the obvious answer is "your test is bad", but I am not sure it is.

Your test is bad, I think, or else the API under test is. 😅
(See http://golang.org/wiki/CodeReviewComments#synchronous-functions.)

It seems in these cases they only way you can actually write a correct test is something that ensures that a write is not triggered after the context has been cancelled, which I believe would require a lock around the context cancel and the file writing, which is extremely heavy and bizarre to support a testing edge case.

No, it's fine to trigger writes after the context has been canceled. The important thing is to ensure that all writes have completed before the function that triggered the writes returns, regardless of whether the context is cancelled.

The other alternative is to use something like goleak and wait until there are no goroutines sticking around, and make sure that is done before TempDir() so it occurs first - and also remember to do it on each subtest.

I don't know what goleak is (maybe go.uber.org/goleak?), but your test should be waiting for all of the background goroutines to stop before its last Cleanup function returns. Otherwise, the behaviors of those goroutines can interfere with other tests — and, perhaps more importantly, benchmarks!

Also, I think the obvious answer is "your test is bad", but I am not sure it is.

Your test is bad, I think, or else the API under test is. 😅
(See http://golang.org/wiki/CodeReviewComments#synchronous-functions.)

It seems in these cases they only way you can actually write a correct test is something that ensures that a write is not triggered after the context has been cancelled, which I believe would require a lock around the context cancel and the file writing, which is extremely heavy and bizarre to support a testing edge case.

No, it's fine to trigger writes after the context has been canceled. The important thing is to ensure that all writes have completed before the function that triggered the writes returns, regardless of whether the context is cancelled.

The other alternative is to use something like goleak and wait until there are no goroutines sticking around, and make sure that is done before TempDir() so it occurs first - and also remember to do it on each subtest.

I don't know what goleak is (maybe go.uber.org/goleak?), but your test should be waiting for all of the background goroutines to stop before its last Cleanup function returns. Otherwise, the behaviors of those goroutines can interfere with other tests — and, perhaps more importantly, benchmarks!

Otherwise, the behaviors of those goroutines can interfere with other tests

That's fair, I think I would agree my test is bad after thinking about it more..
So likely this is just "a comment above TempDir would be helpful"

Otherwise, the behaviors of those goroutines can interfere with other tests

That's fair, I think I would agree my test is bad after thinking about it more..
So likely this is just "a comment above TempDir would be helpful"


Don't trim stacktrace for exceptions when running mvn test

Motivation:
The maven surefire plugin will trim stacktraces by default which makes these kind of use-less when trying to understand why an test failed because one was thrown.
Modifications:
Configure the plugin to not trim the stacktrace.
Result:
Easier to debug test-failures.

Noticed this while debugging some stuff that only fails on CI... Why this is not the default, I have no idea 👎


update typescript to generate type alias for implements IDictionary

This now uses the new TS magic to support the IDictionary trait that we translate to a recursive type alias.
Gets the search response failures down to 0 :smile_cat:

This now uses the new TS magic to support the IDictionary trait that we translate to a recursive type alias.
Gets the search response failures down to 0 :smile_cat:

can you add to the skip list the AdditionalProperties interface in the ts generator?
Done!

can you add to the skip list the AdditionalProperties interface in the ts generator?
Done!


Migrate firectl to its own repository

Note: This shouldn't be merged until the firectl repository is available.
Remove firectl itself from Makefile and the source tree
Update links where appropriate to reference the firectl repository
Signed-off-by: Noah Meyerhans<EMAIL_ADDRESS>By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Eh. Fail. This is merged.


HBASE-27746 Check if the file system supports storage policy before invoking setStoragePolicy()

Cherrypick the commit from master to branch-3.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 39s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
hbaseanti
0m  0s

Patch does not have any anti-patterns.

_ branch-3 Compile Tests _

+0 :ok:
mvndep
0m 17s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
4m 12s

branch-3 passed

+1 :green_heart:
compile
5m  8s

branch-3 passed

+1 :green_heart:
checkstyle
1m  0s

branch-3 passed

+1 :green_heart:
spotbugs
2m 38s

branch-3 passed

+1 :green_heart:
spotless
1m  0s

branch has no errors when running spotless:check.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 11s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
4m 14s

the patch passed

+1 :green_heart:
compile
4m 59s

the patch passed

+1 :green_heart:
javac
4m 59s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
1m 36s

the patch passed

+1 :green_heart:
spotbugs
3m 11s

the patch passed

+1 :green_heart:
hadoopcheck
12m  4s

Patch does not cause any errors with Hadoop 3.3.6 3.4.0.

+1 :green_heart:
spotless
0m 42s

patch has no errors when running spotless:check.

_ Other Tests _

+1 :green_heart:
asflicense
0m 18s

The patch does not generate ASF License warnings.

50m  9s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6170/1/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/6170

Optional Tests
dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless

uname
Linux cfb664f90f90 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-3 / 35b11ebae280ea8046a09808b80504ee3ede050a

Default Java
Eclipse Adoptium-17.0.11+9

Max. process+thread count
83 (vs. ulimit of 30000)

modules
C: hbase-common hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6170/1/console

versions
git=2.34.1 maven=3.9.8 spotbugs=4.7.3

Powered by
Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 27s

Docker mode activated.

-0 :warning:
yetus
0m  3s

Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck

_ Prechecks _

_ branch-3 Compile Tests _

+0 :ok:
mvndep
0m 10s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 13s

branch-3 passed

+1 :green_heart:
compile
1m 17s

branch-3 passed

+1 :green_heart:
javadoc
0m 43s

branch-3 passed

+1 :green_heart:
shadedjars
5m 49s

branch has no errors when building our shaded downstream artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 12s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 10s

the patch passed

+1 :green_heart:
compile
1m 16s

the patch passed

+1 :green_heart:
javac
1m 16s

the patch passed

+1 :green_heart:
javadoc
0m 41s

the patch passed

+1 :green_heart:
shadedjars
5m 46s

patch has no errors when building our shaded downstream artifacts.

_ Other Tests _

+1 :green_heart:
unit
2m 17s

hbase-common in the patch passed.

+1 :green_heart:
unit
215m 46s

hbase-server in the patch passed.

245m 39s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6170/1/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/6170

Optional Tests
javac javadoc unit compile shadedjars

uname
Linux 77200f7228da 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-3 / 35b11ebae280ea8046a09808b80504ee3ede050a

Default Java
Eclipse Adoptium-17.0.11+9

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6170/1/testReport/

Max. process+thread count
5352 (vs. ulimit of 30000)

modules
C: hbase-common hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6170/1/console

versions
git=2.34.1 maven=3.9.8

Powered by
Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.


feat(options): implement options

Status: Value based options (number (10), integer (4), boolean (5)) have been implemented
Checklist:

[x] Value based options
[ ] Object-ish options: User, Channel, ...
[ ] Attachments

Subcommands will follow in a later pr

builder pattern

flow of reading is disrupted

Rename CommandController -> CommandBuilder
Document CommandBuilder for tsdoc :)

Ready


vaadin-list-box

Spec document: https://docs.google.com/document/d/1VC2oyy_g1Zm2Ia2sOrQ6LcrkqZ7610uLxHOK0Gtz91Q/edit

What’s the team’s feeling, would it be feasible to extend paper-listbox and paper-item, or do we need to reimplement it ourselves (maybe use iron-menu-behavior at least)?

Implementation details:
API should be similar to that of <vaadin-tabs>:
<vaadin-listbox>
  <vaadin-item>foo</vaadin-item>
  <vaadin-item>bar</vaadin-item>
  <vaadin-item>baz</vaadin-item>
<vaadin-listbox>

Extract mixins from <vaadin-tabs> to a shared vaadin-nav-mixins /vaadin-nav /....
Create <vaadin-item> shared element (should be just a simple container for now)

Since not all lists are supposed to be horizontally aligned by default (and flaggable as vertical), the vertical property should not be part of the parent mixin. Drop the property from the shared list mixin and move the logic to the level where it's relevant.
Alternatively, change vertical property into orientation, that can be modified by the implementing element. This would be more lightweight a change but requires a modification to the public API.


SNMPv3 fails when using AES256

Tried to deploy SNMPv3 using AES256 and it didn't like it. Had to drop back to using AES128.
@i3149 as per our Slack chat

Can you ask they to try AES256C. This is Reeder-AES256 vs Blumenthal-AES256, might make a difference?
Else, #130 pulls in a lot of bug fixes around v3. Once this is merged, worth while trying again without changing the config.

As per troubleshooting convo, FR to support ISO-8859-1 (minimum) and preferably UTF8 for complex character sets.

As per customer and PR 130, this issue is resolved.


Uploading multiple files at once

is there any feature for uploading multiple images to one
like
https://uploadcare.com/docs/file_uploads/widget/multi_upload/

Thanks for opening this issue, @Prince444! Currently, multiple file uploads are not supported. However, in the upcoming release (December 2019), this will be supported.

Update: Uppload is a great way to let users upload profile pictures and other images. It's an image-first uploading widget, not a general-purpose file uploader. This is further validated by support for image previews, cropping, (and new image editing features like filters coming in v2), which is why supporting uploading multiple files at once is not a priority and will not be shipped in v2.
Here's what I'm thinking: We can easily support multiple uploads using the local service (i.e., selecting multiple files from your computer), but it's going to be more complex to show previews for multiple files and even more complex to have image editing for multiple files and then sending them to the server.
Maybe we can come up with a compromise where multiple files can be supported, but image effects will not work. Maybe we can have a property for multiple and then directly upload the selected files instead of the middle step of image previews and editing. For people who want to use Uppload as a general-purpose file uploader, this should work.
const uppload = new Uppload({
  multiple: true
});

I'll close this issue as soon as v2 is released.


Rename repo to integration-guides

Integrations-guides seems like an English mistake to me ;)
(also, asked the American at my side, she agrees)

Agreed, the double plural is redundant.

Doooooooone! Thanks guys! 😁


syntax highlighting - colours

Strings are highlighted in green, added lines are also green
suggest changing it to eg. purple(or something that is not one of red/yellow/green),

I'll have a look.

dont change the code just yet, would like to merge PR https://github.com/larshp/abapGit/pull/481 first, so we avoid a possible conflict

OK, there are also some small fixes from our side too. Will commit a bit later then.

pushed a fix to 475. But should be no conflicts with highlighter stuff

OK, got to this one ...
Well, if you don't mind I can just follow github style. It looks quite balanced

closing, does not seem to be a problem anymore


Win32: Disable non-client painting on borderless windows

Fixes an issue where a small title bar and window caption buttons were being painted after restoring a minimized undecorated window.
OS: Windows 10
GLFW: master branch
Steps to reproduce:
Repeatedly clicking the window's icon on the task bar will cause the window to alternate between minimized and restored. Prior to this change, restoring the window causes the following title bar and caption buttons to be rendered in the upper left hand corner of the window.

#include "GLFW/glfw3.h"

void key_callback(GLFWwindow* window, int key, int scancode, int action, int mods) {
    if (key == GLFW_KEY_ESCAPE) {
        glfwSetWindowShouldClose(window, GLFW_TRUE);
    }
}

int main() {
    glfwInit();
    glfwWindowHint(GLFW_DECORATED, GLFW_FALSE);
    GLFWwindow* window = glfwCreateWindow(800, 600, "GLFW Window", NULL, NULL);
    glfwSetKeyCallback(window, key_callback);
    while (!glfwWindowShouldClose(window)) {
        glfwWaitEvents();
    }
    glfwTerminate();
}

This also fixes some rendering issues when enabling the DWM drop shadow effect on a borderless window (which was the primary motivation; I want to draw my own window title bar).
In order to draw the drop shadow, the DWMNCRENDERINGPOLICY must be set to DWMNCRP_ENABLED when the window style doesn't indicate that a border should be drawn. Discarding both the WM_NCPAINT and WM_NCACTIVATE messages have been the only way that I've found that prevents all of the window chrome from ever being painted.
Example:
HWND hwnd = glfwGetWin32Window(window);
MARGINS margins = { 0 };
margins.cyTopHeight = 1;
DwmExtendFrameIntoClientArea(hWnd, &margins);
DWMNCRENDERINGPOLICY ncrp = DWMNCRP_ENABLED;
DwmSetWindowAttribute(hWnd, DWMWA_NCRENDERING_POLICY, &ncrp, sizeof(ncrp));

With this PR applied, the window will be fully transparent and the edges will have the drop shadow effect.
Without this PR applied, a border will be displayed with any variations of the MARGINS variable and will have some amount of border drawn on the edges or corners. The borders can be painted over, but they flicker when the window is resized (note that resizing is now handled by the app, and not by the window proc).

Thank you! This has been merged as 9ac9d7b85a224bb932f4a74912ddf5625a4eb110.


Request for app with ionic

Hi, great module. I used in my web app and work excelent. But, i want compilate my webapp with Ionic to make an app. And i want to detect if the aplication is launcher via App o via the browser of the phone. Which variable i can used to detect this? Is possible detect this?

Hi @vagostep,
Can you run the app under both conditions and print the UserAgent string?
Send me both strings and maybe we can come up with a way to distinguish.
Shahar.

Hi, the userAgent string that is print when i enter in the App (apk) is:
"Mozilla/5.0 (Linux; U; Android 4.0.4; es-ve; LT22i Build/ 6.1.1.B.1.54) AppleWebKit/534.30 (KHTML, like Gecko) Version/4.0 Mobile Safari/ 534.30"
and the userAgent string that is print when i enter via the phone browser (chrome) is:
"Mozilla/5.0 (Linux; U; Android 4.0.4; es-ve; LT22i Build/ 6.1.1.B.1.54) AppleWebKit/534.30 (KHTML, like Gecko) Version/4.0 Mobile Safari/ 534.30"
Is the same :$

The ng-device-detector uses the UserAgent to detect the device, os etc...
If there is no difference in the UA it will require some other way to detect.
Do you know of any other way to distinguish between them?
I don't know Ionic nor mobile enough to say if such a way exists but if you find it you can pretty easily incorporate it to the code - I could possibly help you there.

@srfrnk Sure! Thanks for the answer. I'll investigated more and find a solution for my need. Have a good day!!!

@vagostep I talked to my wife and she says Ionic has a way to configure the UA to be visible to the application code. If you can add a unique ID into the UA we can make it become detectable.
Specifically we can add a general UA addon for ionic like that:
'Ionic/#.#.#'
Where #.#.# is the ionic version.
Does that sound reasonable?
Can you test that it's possible?

@srfrnk Hi, i'll investigated that. But, I discovered that, when i'm the app, the variable $ window.document.URL starts with the string "file: ///" followed by a path that begins with "android_asset" whereas when entered by the browser, the string It starts with http: // or https: // I do not know if it is always standard, but it makes a lot of sense since the browser requests the page through that protocol, while the app loads it from its own directory. Do you think we could use this to detect if an app is being loaded locally or is a web page being requested?

The plug-in is designed to use UA to detect everything.
Introducing other sources is always possible but might break existing functionality and expose us to future problems - e.g. what if the UA is conflicting with what appears in UA etc..
The best course is using the UA to get what you need unless it is impossible for some reason.
I would even go further and sujest to the Ionic developers that they implement this UA as a standard since I guess many apps might benefit and they already implemented it internally as a feature so they did see the need. WDYT?

@srfrnk

Hello, I added to the UA 'Cordova / X.X.X' with the version of Cordova to use at the end of the UA. Using  that adds to the end of the string the value you want. I think that's what you meant.

10x - that looks great.
I will add that tomorrow.
Plus I want to check how complex it would be to add a feature for custom detection.
This way you could inject UA values through Cordoba / Ionic / whatever and then use the plug-in to detect.
Shahar.

@srfrnk yeah! thanks!! I'll be waiting to update :)

Please see latest release 4.0.0. Read the release comment to make sure it doesn't break stuff for you.


Test AWS Lambda layers locally using mocks

We have a Python example here.

Assigned and being worked.


#260 - changing wording of tag line and sync benefits between docs and frontpage

I synced up the benefits on the front page with the benefits listed on the issue and on the docs subpage. In doing so I've had to remove some of the other benefits that were on the front page  like browser compatibility. Let me know if you think these are still important to put on the front page or we can find somewhere else to put them too.
Main thinking behind this is to make sure the docs and front page are in sync, it's better to have a consistent message across pages IMO.

:+1:


ISPN-9440 Hibernate second level cache - Add native query test

ISPN-9440 Hibernate second level cache - Add native query test

Why the need for such a test? What is the difference in Hibernate code that leads to think that the second level cache would deal with such native query differently? I don't want to add more tests unless they are testing something not already covered from a second-level cache perspective. IOW, we're not trying to take all Hibernate features and run them as tests with second-level cache and see whether something fails... It just wouldn't scale.

If this test was covered somehow. I fine to close this PR

Queries are being tested, but I don't know whether native queries are somehow different from a second-level cache perspective. That's what I was hoping you'd look into ;)

Yep. I did it :)

createSQLQuery will invalidate all regions. If you would like to avoid that you can set addSynchronizedEntityClass.
Invalidation was covered in other tests.
I am closing this PR.

Thanks @diegolovison :)


Not working with insets

I got the insets, but when I paste this to the scss file, I cant get any result for my page, how is it working? Any help please

Hi, How are you accessing the insets in the SCSS file?
To use insets in SCSS you need to call SafeAreaController.injectCSSVariables() at the app initialisation as mentioned in the readme here, then you can use CSS variables exposed by the package like this
.myElement {
  padding-top: var(--safe-area-inset-top);
  padding-left: var(--safe-area-inset-left);
  padding-right: var(--safe-area-inset-right);
  padding-bottom: var(--safe-area-inset-bottom);
}

Let me know if it still doesn't work.

my SCSS
body {
margin: 0;
background-color: #fff!important;
padding-top: constant(--safe-area-inset-top)!important;
padding-left: constant(--safe-area-inset-left)!important;
padding-right: constant(--safe-area-inset-right)!important;
padding-bottom: constant(--safe-area-inset-bottom)!important;
}
in my app.component file, I initialize your methods
this.getSafeAreaInsets();
this.injectSafeAreaVariables();
i cant get any insets with capacitor, my project is capacitor + angular, not ionic, and i have not any solutions for this. Thanks

Can you please try var() instead of constant()?
like this
body {
  margin: 0;
  background-color: #fff!important;
  padding-top: var(--safe-area-inset-top)!important;
  padding-left: var(--safe-area-inset-left)!important;
  padding-right: var(--safe-area-inset-right)!important;
  padding-bottom: var(--safe-area-inset-bottom)!important;
}

As far as SafeAreaController.injectCSSVariables() method is being called, you should be able to access CSS variables.

Closing as I haven't got a follow up + I wasn't able to reproduce.
Feel free to comment or re-open if you can provide further details or if anyone is still having trouble accessing CSS variables 👍


BungeeCord-Problem

See my problem here: https://www.spigotmc.org/threads/bungeecord-mysql-permissionsex.170596/
I think it's a bug with PermissionsEx, but maybe I am just doing something wrong...
Now I tried to set "bungeecord" in every spigot.yml of my subservers to true and now NOTHING works anymore :(
The whole Permissions are gone now
I hope you can help
git-Spigot-e4d4710-e1ebe52 (MC: 1.8.8) (Implementing API version 1.8.8-R0.1-SNAPSHOT)
BungeeCord Build 1176
By the way: The PermissionsEx-Updater doesn't work right, but that's a smaller bug

Solved (Solution is in the thread, Link above)


[BUG] Viewing the new statistics page counts +1 views on profile

Description
While logged in, every time I go on the new statistics page, I notice the views count of my profile increases by 1.
Repro:

Login with GitHub
Find your profile on the search page (do not open it!)
Look at the views count
Open in a new tab the new statistics page
Go back to the tab on the search page, refresh, and search again for your profile (again, do not open it)

You will notice that the counter has increased by 1.
The repro steps are tricky but it's to avoid artificially increasing the count while reproducing the issue.
Screenshots
No response
Additional information
No response

Balastrong
I want to work on that can you please assign this task to me?

I am blocking this issue for the moment because when we read the profile from the API it does increment as a view. When we refactor this area with more database involvement we can look into this.

Balastrong
I want to work on that can you please assign this task to me?

@singhmohit14072002 only maintainers can assign an issue.  Also, please take a look at issues which have the label status: ready for dev

This was completed in the PR https://github.com/EddieHubCommunity/LinkFree/pull/5595

ok


There was an error loading the Microsoft Store: Microsoft Store load failed

Status
Available in

In preview
Windows 11 Insider Build 26248.5011

Dev Home version
1.1501.534.0
Dev Home Azure Extension version
No response
Windows build number
10.0.26248.5011
Other software
OS Build Version: 10.0.26248.5011.ge_current_directadept.240607-1942
.NET Version: .NET 8.0.8
Steps to reproduce the bug

Please restart your PC
Try load the Microsoft Store app

Expected result
Microsoft Store will work
Actual result
Could not load the Microsoft Store
Included System Information
CPU: 11th Gen Intel(R) Core(TM) i7-11370H @ 3.34GHz
Physical Memory: 32.02GB (11.19GB free)
Drive Storage: 114.19GB
Processor Architecture: x64

It sounds like the issue you're having is not related to Dev Home, so this isn't the correct place to open it. Please open your issue in Feedback Hub, and it will be seen by the right people to help.


Update API usage to clear deprecation warnings.

Paging @Glavin001:
I think I got all of the deprecations.  Please test these changes out, and merge & publish if they're satisfactory.
Thanks!

Published to v0.14.0
Thank you for the great help!


AWS S3 input capped at 1000 items

When the AWS S3 input is used without an SQS queue the input is meant to download every object within the bucket under a specified prefix. However, it appears as though the API is capped at 1,000 objects, so if the bucket exceeds that we lose data.
It looks as though the API now allows pagination when iterating keys, so we need to start using it.

Released: https://github.com/Jeffail/benthos/releases/tag/v0.34.8


Dynamically detect tenant id to handle tenant migration scenarios

Currently to authenticate against keyvault the code uses the tenantId
from the cloud config file. When the subscription tenant is being
migrated which is a common scenario, then at runtime the tenant id will become invalid (until fixed) resulting in
authz errors and outage. To prevent errors during tenant migration this change
dynamically detects the tenant id from the challenge response to avoid
outages.

merged, thank you for your contribution! and to all the reviewers as well :)


Köln Trinkwasser: Status

status still "in progress"?
@marcel12bell

no. is now finished. @soniaskhan  greetings from cologne!


TF controller update

Yes, a code need a little bit more love. Added Makefile target... Fixed code compilation.

make lint
staticcheck ./...
pkg/executor/main.go:76:2: this value of out is never used (SA4006)
make: *** [lint] Error 1

as of now, but I guess you are on it

@kuritka I understand your concern. it is quite hard to review during updates/upgrades. But at the same time IMO this is protects us from an internet connection being broken or upstream for module is gone for some reason.

@k0da in the early days of k8gb we also used /vendor and deprecated eventually deprecated this approach due to lot of inconveniences during upgrades and mess in the PRs . I strongly suggest to switch to clean go mod

@k0da good point here. If internet connectivity is the reason, then we should move to modules.  After go mod download the files being cached in  $GOPATH/pkg/mod/cache and being there until go mod clean. Compiler looks into that offline folder.
So from the local development compiling, it is equal. From the self-runner it is true. If data-center lost connection to the internet, the Go cannot create $GOPATH/pkg/mod/cache and compilation fails. But I think we can rely on the data-center connectivity.
Here are some reasons for /vendor

keep references next to the code, so when reference package dismiss, you still have access to package in the form you need. Someone has to solve this complication one day, anyway.
keep builds cheap, In case we build in the cloud and pay for traffic (the vendor folder may take hundreds of MB and downloading each time increase costs)
GO1.11,GO1.12 supported  modules preliminary so to be safe /vendor might be an option. But from the PR I see we switched to GO1.13 (maybe we can switch to GO1.15 if everything goes well).
quick builds, building cache is a time-consuming operation and we pay for run-time.

The problem I have with vendor except repo robustness are nightmare PR's and conflicts when bumping package versions. Also risk that new package download and IDE will change it by mistaken refactoring.
I think we should use vendor only in case we deal with some point I mentioned ahead (i.e. we pay for the traffic).
We can consider Go module proxy which may help in many scenarios.

We can consider Go module proxy which may help in many scenarios.
@k0da , @kuritka , afaik go uses https://proxy.golang.org by default, starting from 1.13

vendor dropped, staticcheck fixed, I'll leave errcheck errors for later.


"Stabilizing features" has broken links and unclear instructions

https://std-dev-guide.rust-lang.org/feature-lifecycle/stabilization.html has two links labeled "libs team reviewers" that lead to https://github.com/rust-lang/highfive/blob/master/highfive/configs/rust-lang/rust.json, which doesn't exist. It also says to "either ping @rust-lang/libs-api or leave a comment asking about the status of the feature", but it's not clear what "ping" means here; it seems to be distinct from "leav[ing] a comment", and even if it does mean leaving a comment with that tag in it, that doesn't appear to work (at least it doesn't get highlighted in the rendered comment like a user would be).

std-dev-guide.rust-lang.org/feature-lifecycle/stabilization.html has two links labeled "libs team reviewers" that lead to<EMAIL_ADDRESS>which doesn't exist.

Because we migrated to triagebot, it now lives on https://github.com/rust-lang/rust/blob/e5d46a5bdac3f19793297914d4ada432024fbe95/triagebot.toml#L459. It's just a left-over on the migration.

It also says to "either ping @rust-lang/libs-api or leave a comment asking about the status of the feature", but it's not clear what "ping" means here; it seems to be distinct from "leav[ing] a comment",

"ping" here means mentioning the team via a comment. Here's a formal definition: https://dictionary.cambridge.org/dictionary/english/ping

and even if it does mean leaving a comment with that tag in it, that doesn't appear to work (at least it doesn't get highlighted in the rendered comment like a user would be).

GitHub doesn't allow you to mention the team if you aren't a part of the organization. In such a case, you can leave a comment instead (that's why we wrote "either...").


feat(node): Support prebuilds of node 20 and 21

Just bumping the supported node versions to the latest node.

@almoghamdani Any chance we can get this merged?

Release v1.8.6 should now prebuilds for Node versions supporting N-API 5-9 (this includes the latest Node version) 😄


[PE-D][Tester A] Requirement of YEAR JOINED paratemer in User Guide is not the same as in the app

Describe the bug
In the User Guide, it states that requirement of YEAR JOINED paratemer is must be 4 digits. However, when input /add Ja Doe; 91234567<EMAIL_ADDRESS>12 Kent Ridge Dr; 1999; Finance, with 1999 meets the requirement, it shows error message.
To Reproduce
type /add Ja Doe; 91234567<EMAIL_ADDRESS>12 Kent Ridge Dr; 1999; Finance and press Enter in the command box
Expected behavior
Expected to accept the command as specified in the User Guide
Screenshots

Labels: severity.Low type.FunctionalityBug
original: fy17ohhh/ped#8

We'll change this!


Fix reproducible "Aw snap" crash

I have a reproducible case where I get the "Aw snap" every time I run the tests.
The fix deletes iframe on a timeout, avoiding walking back into a deleted iframe's stack.
My tests are async. This is my guess what the problem is:
ChildRunner.done deletes the iframe.
Right above it in the stack is eventListener for DOMContentLoaded for the iFrame. That frame is now gone, and 'this' points to the deleted window.
When ChildRunner.done returns, I crash immediately.
This is my test suite, also attached are the crash screenshots.
   suite('<pook-auth-ui>', function() {
      test('login mode', function() {
        assert.equal(el.mode, 'login');
      });
      test('login', function(done) {
        TestUtils.setInputValue(email, "b@totic.org");
        TestUtils.setInputValue(password, "12345678");
        el.loginClick(done);
      });
      test('forgotPassword', function(done) {
        TestUtils.setInputValue(
          el.shadowRoot.querySelector('[name=email]'),
          "b@totic.org");
        el.forgotPasswordClick(done);

Merged via https://github.com/Polymer/web-component-tester/commit/cbd8b560fa5849b789a9d083b69209aaa2a7cfdd


Unable to load DLL libSkiaSharp the specified module could not be found.

Description
Win Forms Application
Debug/Build Any/CPU
I installed DYMO.Connect.SDK v<IP_ADDRESS>. It auto installs SkiaSharp & SkiaSharp.Views v1.68.0 and other dependicies.
When I debug i can print labels just fine. However when I build the program and run it, i get the following error.
"Error
Unable to load DLL 'libSkiaSharp': the specified module could not be
found.(Exception from HRESULT: 0x8007007E)"
Code
                    Imports DymoSDK.Implementations
                    Dim dymoSDKLabel As DymoSDK.Implementations.DymoLabel

                    Private Sub PrintLabelButton_Click(sender As Object, e As EventArgs) Handles PrintLabelButton.Click
                    Dim gen As New QRCodeGenerator
                    Dim data = gen.CreateQrCode(sid, QRCodeGenerator.ECCLevel.Q)
                    Dim qrCode As New Base64QRCode(data)
                    Dim base64qrcode As String = qrCode.GetGraphic(20)
                    Dim LabelTextObject As DymoSDK.Interfaces.ILabelObject
                    Dim LabelQRObject As DymoSDK.Interfaces.ILabelObject
                    Dim SelectedPrinter As String = "DYMO LabelWriter 450"
                    Dim copies As Integer = 1
                    Dim barcodeGraphsQuality As Boolean = True
                    dymoSDKLabel = New DymoLabel()
                    dymoSDKLabel.LoadLabelFromFilePath("C:\Users\" & WindowsUsername &"\Documents\DOCS\test.dymo")
                    LabelTextObject = dymoSDKLabel.GetLabelObject("TextObject")
                    dymoSDKLabel.UpdateLabelObject(LabelTextObject, rowID)
                    LabelQRObject = dymoSDKLabel.GetLabelObject("ImageObject")
                    dymoSDKLabel.UpdateLabelObject(LabelQRObject, base64qrcode)
                    DymoPrinter.Instance.PrintLabel(dymoSDKLabel, SelectedPrinter, copies, barcodeGraphsQuality)
                    End Sub

Basic Information

Version with issue:
IDE:
Platform Target Frameworks:

Screenshots

Reproduction Link

Can you try upgrading SkiaSharp to v2? It should have a whole bunch of improvements for this.

I upgraded to V2.80.0.
I got the following error when attempting to install the Build application"+ Strong name signature not valid for this assembly OpenTK.GLControl.dll."

I am unable to reproduce.
I created a new VB forms app, added the nuget and ran some SkiaSharp code. Ran just fine for me.

Looks like error is coming from DYMO then.


Add runtime and RSS memory as seen by RabbitMQ

This has not been built/tested yet, I lack the capacity to do it at the moment.
cc @gerhard

So what is the plan there? do you want to wait for @gerhard's confirmation or I can go ahead and manually test it myself? Did you even figure out how to build this?

We did just before the end of the day, and it works.

:+1:

Thanks for all the merges!


Design the top-level table of contents / topics for source code playbook section

Determine what sections we should have
How they should be organized
Update the table of contents
https://github.com/microsoft/code-with-engineering-playbook/tree/master/source-control

[x] Contributing Guidelines

[x] Commit best practices (move from main README)
[x] Contributing to an existing repository
[x] Creating a new repository
[x] Merge strategies (previously: Commit history)
[x] Branch naming

[ ] Feature branching
[x] Release and versioning
[x] Working with secrets (move from git.md)
[ ] Git Guidance

[ ] The Basics

[ ] Cloning
[ ] Committing
[ ] Merging
[ ] Managing Remotes

[ ] Rolling back changes

[x] Reverting and deleting commits
[ ] Using the reflog

[x] Using submodules (previously: Multi service development and deployments)
[x] Stashing changes (previously: Stashing)
[x] Working with large files (previously: Working with images, video …)
[ ] Git tools and resources

Do we need to add GitOps ? Is this covered else where?


fix: fix gpu label test v0.36.x

Fixes #N/A
Description
Overrides nodeclass AMI to be AL2 for the GPU test since AL2023 GPU instances are unsupported on v0.36.x.
How was this change tested?
E2E
Does this change impact docs?

[ ] Yes, PR includes docs updates
[ ] Yes, issue opened: #
[x] No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>2
Details

0 of 0   changed or added relevant lines in 0 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage decreased (-0.01%) to 78.273%

Files with Coverage Reduction
New Missed Lines
%

pkg/providers/amifamily/ami.go
1
90.37%

Totals

Change from base Build<PHONE_NUMBER>5:
-0.01%

Covered Lines:
5685

Relevant Lines:
7263

💛  - Coveralls


Use Snakeyaml 2.0 version to patch vulnerability

Hi
allure-commandline 2.21.0 uses snakeyaml 1.33, which has the following vulnerability https://nvd.nist.gov/vuln/detail/CVE-2022-1471
Is it possible to upgrade to snakeyaml 2.0 to resolve this issue?
Thanks
Ashil

Fixed in 2.22.4


Create data documentation md file

This PR contains a markdown file containing documentation for the data model as well as the trait status transitions, along with a mermaid diagram and its source code. Closes #7 , closes #8
A consideration I have is that the table describing the trait statuses is very big and therefore the markdown required to output it is quite not user-friendly, so we might want to change the way we show that piece of information.
I also uploaded the png diagram to Imgur so that is stays permanently and that the link is small

Great, all comments addressed without further issues, merging this


Adds the download_to_path  keyword argument to the download method.

Edits smartfile/init.py

Adds a download_to_path keyword argument to explicitly specify a
path to write the downloaded file contents , if not given the file
will be written under the CWD + the file to download name.

Coverage decreased (-0.6%) to 69.6% when pulling 89a816a4fc30b562002b8b5c14189ad6b4afb52c on chaps:fix_download_file_path into c04d475d3672005f97222f3e08c4eb2c5aefa8a8 on smartfile:master.

Coverage decreased (-0.6%) to 69.6% when pulling 89a816a4fc30b562002b8b5c14189ad6b4afb52c on chaps:fix_download_file_path into c04d475d3672005f97222f3e08c4eb2c5aefa8a8 on smartfile:master.

Coverage decreased (-0.6%) to 69.6% when pulling 89a816a4fc30b562002b8b5c14189ad6b4afb52c on chaps:fix_download_file_path into c04d475d3672005f97222f3e08c4eb2c5aefa8a8 on smartfile:master.

Good change @chaps Thanks


Add rule for planning-portal session-variant homepage

The homepage of www.planningportal.gov.uk redirects to a
session-based URL (example) We found ~18,000 of these URLs while
building a list of URLs for the site, and users may well have
bookmarked them, so we should redirect them.
This adds pre-emptive redirect that points to the homepage, which
will then redirect to whatever we map / to, which will avoid
having to duplicate that redirect destination..

:+1:

Looks right to me based on what I remember and what every other pre-emptive rule looks like.


F1-Class

Task
Create a README file
Description
In this file generate a text with the name of the subject and indicate that is a workbench
Deadline
April 18, 2024

Updated Files 👍🏻


Add file win1.ring   -  Test for gui lessons

Hello M.Mahmoud.
Is this correct? 🥇

Thanks

Looks good test, I will merge it

Thanks, If you have any question post it in Ring Group

Okay thank you very much.

You are welcome


KeepAlive with include parameter doesnt work for

Vue version
latest 3.4.33 +
Link to minimal reproduction
no link
Steps to reproduce
in my App.vue  I have
                <router-view v-slot="{ Component }">
                  <div class="relative h-screen overflow-x-hidden">
                    <Transition :name="transitionName">
                      <KeepAlive include="feed-screen">
                        <component :is="Component"
                          class="pview-component w-full h-screen momentum-scroll safe-area-bottom border-light-500 dark:(border-gray-700) "
                        />
                      </KeepAlive>
                    </Transition>
                  </div>
                </router-view>

If i use  KeepAlive with the include="feed-screen" and with
I also need the following. Because its not automatically picking up the name.
<script>
export default {
  name: 'feed-screen'
}
</script>

What is expected?
It was supposed to work without me doing

What is actually happening?
It doent work. KeepAlive doenst work at the specified page.
System Info
No response
Any additional comments?
No response

Please provide a runnable minimal reproduction.

You were correct.
i didnt know defineOptions({ name: 'feed-screen' }) was even needed.
thank you.


Feature Request: Keybinding to create dummy effect and open its dialog

Keybinding such as SHIFT-E to create a new effect on one selected token and open its dialog immediately so the GM can edit its name and duration. A default icon that could appeal to all such quick conditions could be added to Settings so each GM can se their own.
This solves a problem GM had when they need to create very quickly a new effect with a custom name and duration. An example of such usage is quickly creating Immunity to monster attacks for players who succeed in the save.

I can add this, but why not just use the existing Extempore Effect with shift-clicking to open the sheet?  That way an effect is immediately created and the user can immediately edit its name, icon, duration, etc - with the default system UI.
It seems to me that the only major difference with making it a keybinding is that the new effect's initial data (name, icon, duration, description) will be blank or have some default value, instead of depending on the chat message.  Is that a big enough difference for you?

Added in v1.2.0 (Ctrl+Shift+E but you can configure it), I hope this is helpful to you!
I made the icon random, but consistent as long as you don't pan or zoom;  this means that you can give the same icon to multiple player tokens a bit more easily.


I can't figure out how to file an issue

fooofoofoo

This issue was moved to Microsoft/BotBuilder-V3#2


fimplicit3() not supported

When using fimplicit3() to plot the 3-D implicit function defined by f(x,y,z) = 0, an error is printed.
f = @(x,y,z) x.^2 + y.^2 - z.^2;
fimplicit3(f)

fig2plotly(gcf, 'offline', false);

The previous code prints:
Error using response_handler (line 31)
Expecting (x, y) pairs

Error in makecall (line 32)
    response_handler(resp);

Error in plotly (line 28)
response = makecall(args, origin, structargs);

Error in plotlyfig/plotly (line 449)
                response = plotly(obj.data, args);

Error in fig2plotly (line 49)
p.plotly;

Error in untitled6 (line 6)
fig2plotly(gcf, 'offline', false);

Expected plot:

Examples on using fimplicit3() can be found on:
https://www.mathworks.com/help/matlab/ref/fimplicit3.html#bvds9ev-2_1

PR #334 fix this issue


Add Command.which(cmd) function to lua interface

I added the which function to the global Command table, which simply resolves the path for the command passed as an argument and returns nil if it can't find it.
An example of usage is:
local bin = Command.which('yazi')
if not bin then
  error('yazi not found')
end

Thanks for the PR! I have a few questions:

Are you sure the behavior of the which crate is consistent with Command? If they aren't consistent, there could be situations where which finds an executable but Command can't run it, or vice versa.
What was your X problem — why do you need to check if the executable exists first? Can't that be determined at runtime? Command returns a status code if the execution fails, indicating the executable doesn't exist.
Yazi's Command is meant to mirror Rust's Command as closely as possible, so I don't think it should be added to Command, maybe to ya instead, but we already have ya.which. Do you have any better name suggestions?

First of all, thank you for expressing your reasonable concerns; you give me the impression that you want to keep the project healthy and well-organized.

Command uses execvp or posix_spawn directly, so theoretically, they could be inconsistent with each other.
I simply wanted to create a fallback system using which since it has a simpler interface for that purpose.
I thought about it and didn’t include it in ya precisely because ya.which already exists, so I opted for Command.which. A second option could be ya.exepath.

Thanks for the explanation. Since it doesn't necessarily align with the Command behavior and the which crate just looks for executables in the file system, let's move it to fs: fs.executable() -> (Url, err).
If found, return the file URL and set err to nil; otherwise, return URL as nil and provide the corresponding err.

One thing isn't clear to me: what error should I return if I simply can't find the executable?

You can try creating a new error structure mapping and representing the Error from the which crate (https://docs.rs/which/latest/which/enum.Error.html).
If you're not sure how to do it, just leave a // TODO: xxx :)

I'm going to close this because it still needs some work and hasn't seen any activity recently. @shurizzle  thanks for the effort!


Adding Fixed Advisory GHSA-pxhw-596r-rwq5 for aws-ebs-csi-driver

$ wolfictl scan -r aws-ebs-csi-driver
📡 Finding remote packages
🔎 Scanning "/var/folders/kl/q9mydw095ln5s7wj971qcrx40000gn/T/x86_64-aws-ebs-csi-driver-1.30.0-r0-2520002970.apk"
✅ No vulnerabilities found
🔎 Scanning "/var/folders/kl/q9mydw095ln5s7wj971qcrx40000gn/T/aarch64-aws-ebs-csi-driver-1.30.0-r0-681887954.apk"
✅ No vulnerabilities found

merge this https://github.com/wolfi-dev/advisories/pull/4168


support nested keys

from the roadmap - https://github.com/kentcdodds/match-sorter/blob/master/other/ROADMAP.md
Notes:

don't worry about odd key names like name.first - https://twitter.com/kentcdodds/status/769921548232732672

Happy to hear any ideas on implementation details.

I'm sure there's a module that'll do it. Right now the build isn't setup to work with multiple files, but if you want to find a (small) module that can do it and make a pull request for that, then I'll figure out the build stuff.

@kentcdodds can we do something simple like this - https://github.com/conorhastings/match-sorter/commit/45722aabfd06a3589a554eb8c79443c47d084c2e

Perfect! I can merge that right away!

Oh also remove that item from the roadmap too


Use joins instead of includes - fixes #150

Thanks for your work on this one :)

Can't we use the built in uniq function for this?

Uniq behaves differently in Rails 3.1 and Rails 3.2....rails 3.2 acts on the query, 3.1 is post query which wouldn't play well with pagination I don't think.

Oh right we still support old :-)

I think that uniq() would still have the problem I found in #153.  I implemented it differently in #154 (sorry just realized that pull requests automatically create new issues) that avoids the post table entirely.


more tests

Coverage increased (+0.8%) to 88.046% when pulling f0a5044512319cf7012e019974d39f443465812a on moretests into e4b84d05c31465eb6d3ffc683dd3e543871364f7 on master.

Coverage increased (+0.8%) to 88.046% when pulling f0a5044512319cf7012e019974d39f443465812a on moretests into e4b84d05c31465eb6d3ffc683dd3e543871364f7 on master.

Coverage increased (+0.8%) to 88.046% when pulling f0a5044512319cf7012e019974d39f443465812a on moretests into e4b84d05c31465eb6d3ffc683dd3e543871364f7 on master.


Sync with MDC breaking changes branch

MDC is actively making breaking changes in the develop branch.
We should sync to the develop branch to try and get into the same release cadence as MDC, so there are no surprises when MDC v4 launches.

Changes at https://github.com/material-components/material-components-web/blob/v4.0.0-canary.e851d4f40.0/CHANGELOG.md#breaking-changes

We still need to investigate as to why the newest canary branch still fails to build


Fix model-checking bug

Oops! I introduced a bug while trying to check for models within photdata. quick fix!

Codecov Report

Merging #28 (ab9c80e) into master (ac2627d) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master      #28   +/-   ##
=======================================
  Coverage   39.48%   39.48%
=======================================
  Files          11       11
  Lines         666      666
=======================================
  Hits          263      263
  Misses        403      403

Impacted Files
Coverage Δ

PIPS/class_photdata/__init__.py
30.68% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ac2627d...ab9c80e. Read the comment docs.


How to use learned latent direction from .npy files

Hey there,
I've been eagerly setting up WarpedGAN on a Google Colab today and ran into a problem.
I was able to successfully run traverse_attribute_space and I see gender.npy, etc.
But these are (128,33) and ProGAN's z is (1,512).
I think I have to apply the loaded latent to the Support Set, but the exact mechanism is unclear to me.
Is there somewhere in the source that I can see how this works? How did you generate those nifty GIFs on the dev-eval branch?

You can see my awful, fledgling attempts at getting your stuff going here:
https://colab.research.google.com/drive/188bKhg_tNwjUVo4BXsiwywKnCSaT3e0x?usp=sharing
My goal for this experiment is to enter a bunch of English descriptors (skinny / fat, young / old, scared / excited), create attribute directions by adding a CLIP step into traverse_attribute.. (in the same fashion you have used those other classifiers), and then allow the end user to navigate through those latents using the learned descriptors directions, along with other manipulations.
I'm starting from ProGAN because I've had good luck with that family in other experiments.
I think I understand your guidance here: determine the best paths for each attribute using rank... and then use that path ID to retrieve workable Z's for the GAN space.
I guess create-gif kinda works from the output of traverse.. (in that it reads finished images) so I will try to understand the linkage there.
Thanks for your detailed and very rapid response. And for providing code that actually works out of the box! This may be a first in machine learning paper history. :)

You can see my awful, fledgling attempts at getting your stuff going here:
https://colab.research.google.com/drive/188bKhg_tNwjUVo4BXsiwywKnCSaT3e0x?usp=sharing
My goal for this experiment is to enter a bunch of English descriptors (skinny / fat, young / old, scared / excited), create attribute directions by adding a CLIP step into traverse_attribute.. (in the same fashion you have used those other classifiers), and then allow the end user to navigate through those latents using the learned descriptors directions, along with other manipulations.

Hey @tlack, first of all, thanks for taking the time to extend our method! We've also been thinking in this direction, and may try something in the future. Before everything, please have a look at another very relevant ICCV'21 paper. It's very close to what we do (they try to optimize a vector field), but they do that in a supervised way. They also have an NLP module for editing based on verbal instructions.

I'm starting from ProGAN because I've had good luck with that family in other experiments.
I think I understand your guidance here: determine the best paths for each attribute using rank... and then use that path ID to retrieve workable Z's for the GAN space.

I'm not trying to be cryptic or anything, I just need some time to refactor the script and provide an easy-to-follow piece of code. Regardless, what we really do, as we try to describe briefly in the paper as follows:

In order to obtain a measure on how well the paths generated by a warping function are correlated with a certain attribute, we estimate the average Pearson’s correlation between the index of the step along the path and the corresponding values in the attribute vector.

Thus, we compute the Pearson's correlation between the step of the path (i.e., the index of the path: 1, 2, ..., num_of_generated_images_in_path) and the values of the respective attribute. So, support that A is an MxN numpy array where the t-th row A_t = A[t, :] contains the values for an attribute for the t-th attribute and all images across a path. Then, the correlation (which technically is not exacrly Pearson's, but an "un-normalized" version of it) is given as:
A_t_idx = np.arange(A_t.shape[0])
corr = np.cov(A_t, A_t_idx)[0, 1] / np.sqrt(np.cov(A_t_idx))

I guess create-gif kinda works from the output of traverse.. (in that it reads finished images) so I will try to understand the linkage there.

create_gif.py is really trivial. It just takes a directory with the images generated by traverse_latent_space.py across a given path, for a given latent code, etc, for instance, via --dir=experiments/complete/ProgGAN-ResNet-K200-D512-LearnGammas-eps0.1_0.2/results/ProgGAN_4_F/56_0.15_8.4/435c92ab04f994fd192526b9107396747caf283a/ --path-id=96, i.e., the directory experiments/complete/ProgGAN-ResNet-K200-D512-LearnGammas-eps0.1_0.2/results/ProgGAN_4_F/56_0.15_8.4/435c92ab04f994fd192526b9107396747caf283a/paths_images/path_096/ and just creates the GIF -- that's only been created for the README.md :)

Thanks for your detailed and very rapid response. And for providing code that actually works out of the box! This may be a first in machine learning paper history. :)

Thank you! Please consider closing the issue if the above answer your questions. I'll push the remaining script asap, stay tuned :)


Replace resources.ToCSS with css.Sass due to deprecation of the former

Description

Start building sites …
hugo v0.134.2+extended darwin/arm64 BuildDate=2024-09-10T10:46:33Z VendorInfo=brew
WARN  deprecated: resources.ToCSS was deprecated in Hugo v0.128.0 and will be removed in a future release. Use css.Sass instead.

Issue

Closes: #

WARN deprecated: resources.ToCSS was deprecated in Hugo v0.128.0 and will be removed in a future release. Use css.Sass instead.

IMO, As resources.ToCSS was just deprecated, we should not remove it entirely. Instead you can mention deprecate  information in comments.

/area web-development

Just curious if you've diffed the generated files to see what might be different, if anything?

Just curious if you've diffed the generated files to see what might be different, if anything?

Personally, I see the case study pages as a low priority. I had a look and visually they seemed OK.

With hugo v0.140.0 this is not a warning, but an error:

ERROR deprecated: resources.ToCSS was deprecated in Hugo v0.128.0 and will be removed in Hugo 0.141.0. Use css.Sass instead.

Reference link to the docs https://gohugo.io/functions/resources/tocss/
This should be ok to merge as Hugo 0.133 (I guess thats what the live site is using based on netlify.toml) already calls css.SASS internally. See https://github.com/gohugoio/hugo/blob/c054cba0423fa7e677506fcec67d702486dec01e/tpl/resources/resources.go#L312

@Andygol I recommend a rebase against main

It was not a good idea to perform a rebase /shrug

What was the issue? I tried rebasing the branch to main locally and it worked without smoothly without any conflicts.

@SayakMukhopadhyay maybe I did it incorrectly but rebase cased this https://github.com/kubernetes/website/pull/48570#event-15789077270

Yeah, I believe a bad rebase caused the approval to be removed but maybe @sftim can reapprove once you rebase?
I can confirm that if you fetch the latest changes and rebase to main, it should go without a hitch.

/remove-area blog
/remove-area localization
/remove-area release-eng
/remove-lang es
/remove-lang ja
/remove-lang ko
/remove-lang ru
/remove-lang uk
/remove-lang zh
/remove-lang fr
/remove-lang pl
/remove-lang id
/remove-lang it
/remove-lang vi

Thanks
/lgtm
/approve


Prevent animation tick from getting out of range.

I run into a situation in which the second animation would occur seconds after the first frame. I think that this caused the tick to get out of range, turning
current_zoom + (diff*tick)

into a negative value, making the scene have negative width and height, which made it disappear, and then making the rulers jump into an infinite loop.
This pull requests ensures that the tick is within the valid range.

Code changed since then, thanks!


Current Arc is not an arc

Current arc should be moved to contrib and arc should be a simple line

Arc and ThickArc should be in contrib, and translate into path


An attempt at using raF instead of on scroll

/cc @mike-north
(can't figure out how to assign anyone for review...)


Crash with Facebook sdk

In my code, I initialize a singleton of OkHttpClient
private static OkHttpClient defaultOkHttpClient() {
        if(clientokHttp == null){
            int connectTimeout = AQUtility.getNetworkTimeOut(Constants.TYPE_HTTP_LOAD_IMAGE);
            clientokHttp = new OkHttpClient();
            clientokHttp.setConnectTimeout(connectTimeout, TimeUnit.MILLISECONDS);
            clientokHttp.setReadTimeout(DEFAULT_READ_TIMEOUT_MILLIS, TimeUnit.MILLISECONDS);
            clientokHttp.setWriteTimeout(DEFAULT_WRITE_TIMEOUT_MILLIS, TimeUnit.MILLISECONDS);
        }

        return clientokHttp;
    }

And here is the stacktrace:
java.lang.NullPointerException
at com.android.org.conscrypt.OpenSSLSocketFactoryImpl.createSocket(OpenSSLSocketFactoryImpl.java:94)
at com.android.okhttp.Connection.upgradeToTls(Connection.java:131)
at com.android.okhttp.Connection.connect(Connection.java:107)
at com.android.okhttp.internal.http.HttpEngine.connect(HttpEngine.java:294)
at com.android.okhttp.internal.http.HttpEngine.sendSocketRequest(HttpEngine.java:255)
at com.android.okhttp.internal.http.HttpEngine.sendRequest(HttpEngine.java:206)
at com.android.okhttp.internal.http.HttpURLConnectionImpl.execute(HttpURLConnectionImpl.java:345)
at com.android.okhttp.internal.http.HttpURLConnectionImpl.getResponse(HttpURLConnectionImpl.java:296)
at com.android.okhttp.internal.http.HttpURLConnectionImpl.getResponseCode(HttpURLConnectionImpl.java:503)
at com.android.okhttp.internal.http.HttpsURLConnectionImpl.getResponseCode(HttpsURLConnectionImpl.java:136)
at com.facebook.GraphResponse.java.util.List fromHttpConnection(java.net.HttpURLConnection,com.facebook.GraphRequestBatch)(SourceFile:253)
at com.facebook.GraphRequest.java.util.List executeConnectionAndWait(java.net.HttpURLConnection,com.facebook.GraphRequestBatch)(SourceFile:1130)
at com.facebook.GraphRequest.java.util.List executeBatchAndWait(com.facebook.GraphRequestBatch)(SourceFile:1032)
at com.facebook.GraphRequest.java.util.List executeBatchAndWait(java.util.Collection)(SourceFile:999)
at com.facebook.GraphRequest.java.util.List executeBatchAndWait(com.facebook.GraphRequest[])(SourceFile:983)
at com.facebook.GraphRequest.com.facebook.GraphResponse executeAndWait(com.facebook.GraphRequest)(SourceFile:958)
at com.facebook.GraphRequest.com.facebook.GraphResponse executeAndWait()(SourceFile:854)
at com.facebook.internal.Utility.org.json.JSONObject getAppSettingsQueryResponse(java.lang.String)(SourceFile:893)
at com.facebook.internal.Utility.org.json.JSONObject access$000(java.lang.String)(SourceFile:75)
at com.facebook.internal.Utility$1.void run()(SourceFile:802)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1112)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:587)
at java.lang.Thread.run(Thread.java:841)

FYI @nfuller
Can you isolate this?

Thanks for your quick reply.
It happened a lot on device ASUS ZenFone 4 ASUS_T00Q, OS version 4.4.2.
I don't know how to reproduce this bug. It's the stacktrace reported to my google play account.
In my application, I don't enable SPDY for the shared SSL context.

This all looks like the Android built-in copy of OkHttp and socket factory.
I couldn't isolate the exact version of the code, but I can tell from the stack trace that the platform-embedded version of okhttp / SSLSocketFactory is being used. The crash is highly likely to be because the SSLParametersImpl object is null (assuming the OEM hasn't modified the code themselves).
If so, something has caused the socket factory to end up with a null SSLParametersImpl object. Since the socket factory being picked up by OkHttp/HttpURLConnection will be the one provided by SSLSocketFactory.getDefault(), it's possible some code elsewhere in the app has configured a new instance, or modified the existing instance.
The SSLParametersImpl object is picked up with SSLParametersImpl.getDefault() or it is passed in, depending on which constructor is used. From a sampling of versions of the code, SSLParametersImpl.getDefault() doesn't look like it can return null. The one standard codepath I could find that passes SSLParametersImpl to the factory also guards against null (OpenSSLContextImpl).
The only similar stack trace I can find is here: https://groups.google.com/forum/#!topic/robovm/HU-SNvMSGnY - but that's in robovm and suggests misconfiguration.
Are you, or any of the libraries you're using, manipulating the socket factory, security provider or SSL context?

I'm using Facebook sdk and ACRA library in my application.
I'm afraid of them related to socket factory or SSL context.

No action for us to take here.


ServiceLocator use in app overriding Prism's use of ServiceLocator

We have a component that was developed to use the Prism framework (6.3 version) and it contains it's own shell, bootstrapper, etc.
This component was consumed inside a separate application which happens to make use of the ServiceLocator class for it's own purposes.
What we realized is that the consuming application's use of the ServiceLocator is overriding Prism's use of the ServiceLocator in the "embedded" component. Once the ServiceLocator is accessed at least once in the consuming app, all the lifetime controlled instances in Prism are removed (such as the RegionAdapterMappings, etc) and the embedded component no longer functions correctly.
This is presumably because ServiceLocator is a singleton.
Is there any workaround for this scenario that we may be missing? It seems that the only resolutions are:

Remove Prism implementation from the embedded component (probably not practical) OR
Remove/change the ServiceLocator implementation in the consuming app (may not be feasible)
Other?

Unfortunately you have the wrong repo, this "Prism" isn't the framework you're referring to.


Actionables

Actionables for #1 :

[ ] Update docs to make it clear that a clone into StylesPath is supported (all the readme's suggest manual copying
[ ] Add this project which is more a comprehensive collection of styles: vale-styles

I think the existing instructions list the required steps adequately: download a release, copy the style into your StylesPath, and include it in your config. There are many ways to go about implementing those steps and I don't think there's any reason to assume that typical Git operations wouldn't work as usual.
Those styles originally served as test cases in the actual Vale repo (I personally created every non-TTD style over there). As the test suite grew, I moved away from using those styles and TestTheDocs asked if they could maintain them. As is, though, they aren't more "comprehensive": most styles only include a few rules (e.g., the Rust style only contains two) and the styles themselves don't contain any tests. So, they don't meet the criteria for inclusion here (eventually, I'll probably expand upon some of them, though, as I did with Google).


Avoid unobserved exceptions (dev)

Don't throw from AdaptedPipeline.ReadInputAsync
Watch for unobserved exceptions in SampleApp

@cesarbs @pakrym


fix(xml2rfc): don't treat subseries ID as RFC ID

fix #260

Evidently the CI error is not related to the change.

Evidently the CI error is not related to the change.

@strogonoff, We might have to update the CI tests to show the actual errors.
I ran it locally, logs were written to ./test-artifacts/stderr.log.
See https://github.com/ietf-tools/bibxml-service/pull/291#pullrequestreview-1095783929

Looks like rfcs_ref should be rfcsubseries_ref in the test?

@kesara Let’s merge these changes now—tests are going to be updated in another PR.


postgresql: 14.3 -> 14.4

Description of changes
Fixes possible silent data corruption in indexes ( https://github.com/NixOS/nixpkgs/issues/177447 )
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[ ] Fits CONTRIBUTING.md.

please target it to staging https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md#rebasing-between-branches-ie-from-master-to-staging

please target it to staging https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md#rebasing-between-branches-ie-from-master-to-staging

Done.


OTAR Projects information collection source and mechanism

There is a pending pull request at opentargets/platform-input-support#49, to integrate OTAR projects information collection that needs to be finalised, by either externalizing the Google API access token and using the same google spreadsheet, or collecting the information from a different source.
Background
Currently, OTAR projects information is collected manually, by exporting the data from the spreadsheet as a TSV file, and fixing the name of one of the columns.
This process was going to be automated in PIS, but a recent conversation suggested the use of another source for this file content, e.g. GitHub.
ACTION Required
We need to agree on a final approach to this, so the automated collection mechanism can be finalized in PIS for OTAR projects data.

OTAR projects data collection implemented by this PR


Upgrade build settings for Xcode 7

All the suggested changes appear to be backwards-compatible.

Sets ENABLE_TESTABILITY to YES.
Modifies the schemes for testability.
Migrates to the new PRODUCT_BUNDLE_IDENTIFIER build setting.

YOLO


Ignore VS and Ionide settings

This is binary, per-user settings, and have them constantly in Git window is a noise.

Rather than committed per-use .gitignore settings to the repo, we prefer for the .gitignore in our repo to only contains settings for files that are produced by the F* build itself.
If you have some specific gitignore settings that you want to apply, you can do that without modifying F*'s .gitignore
See, for example: https://docs.github.com/en/get-started/getting-started-with-git/ignoring-files


[BUG] Opensearch 2.9.0 - Failed to initialize LogType config index and builtin log types

Describe the bug
I am trying to install the new version of opensearch on Ubuntu 20.04. But the cluster state stays at yellow.
To Reproduce
Steps to reproduce the behavior:

Install opensearch 2.9.0 on Ubuntu 20.04
configure a basic setting:

cluster.name: cluster
http.port: 9200
network.host: <local-ip>
node.name: test-node-1
path.data: "/var/lib/opensearch"
path.logs: "/var/log/opensearch"
plugins.security.disabled: true
transport.host: <local-ip>
transport.tcp.port: 9300
cluster.initial_cluster_manager_nodes: test-node-1
discovery.seed_hosts: test-node-1

start opensearch service
check logs

Expected behavior
Cluster state becomes green.
 ~# curl --silent --connect-timeout 3 --header 'Host: stats' --write-out '%{http_code}' "http://<local-ip>:9200/_cluster/health?pretty=true"
{
  "cluster_name" : "cluster",
  "status" : "yellow",
  "timed_out" : false,
  "number_of_nodes" : 1,
  "number_of_data_nodes" : 1,
  "discovered_master" : true,
  "discovered_cluster_manager" : true,
  "active_primary_shards" : 4,
  "active_shards" : 4,
  "relocating_shards" : 0,
  "initializing_shards" : 0,
  "unassigned_shards" : 3,
  "delayed_unassigned_shards" : 0,
  "number_of_pending_tasks" : 0,
  "number_of_in_flight_fetch" : 0,
  "task_max_waiting_in_queue_millis" : 0,
  "active_shards_percent_as_number" : 57.14285714285714
}

Plugins
Basic installation.
Screenshots
%
Host/Environment (please complete the following information):

OS: Ubuntu 20.04 (updates installed)
Version 2.9.0

Additional context
In the logs of opensearch I am able to discover the following informations:
[2023-08-02T11:07:51,126][ERROR][o.o.s.u.SecurityAnalyticsException] [test-node-1] Security Analytics error:
org.opensearch.ResourceAlreadyExistsException: index [.opensearch-sap-pre-packaged-rules-config/CWaJHMTdTlmZSg9zl5rPaA] already exists

[2023-08-02T11:07:51,149][WARN ][o.o.s.SecurityAnalyticsPlugin] [test-node-1] Failed initializing prepackaged rules
org.opensearch.securityanalytics.util.SecurityAnalyticsException: index [.opensearch-sap-pre-packaged-rules-config/CWaJHMTdTlmZSg9zl5rPaA] already exists

[2023-08-02T11:07:51,196][WARN ][o.o.s.SecurityAnalyticsPlugin] [test-node-1] Failed to initialize LogType config index and builtin log types

[2023-08-02T11:07:52,152][INFO ][o.o.c.r.a.AllocationService] [test-node-1] Cluster health status changed from [RED] to [YELLOW] (reason: [shards started [[.opensearch-sap-log-types-config][0]]]).

Complete log can be found at: https://justpaste.it/c9c32

  "number_of_data_nodes" : 1,
  "active_primary_shards" : 4,
  "active_shards" : 4,
  "unassigned_shards" : 3,

From the docs:

A yellow cluster status means the primary shards for all indexes are allocated to nodes in a cluster, but the replica shards for at least one index aren't.

You only have one node, but the replica shard needs to be on a different node.

indeed, the problem is solved on opensearch 2.10 and 2.11

The warning "Failed to initialize LogType config index and builtin log types" as mentioned in the issue title is still present in version 2.11
The cluster status is green though.


Add Support To full request or headers in custom resolvers

Hi ,
I would like to ask for a feature if is possible , the possibility to have the full request as 3rd parameter on custom resolvers.
Due that some info that comes in request can help to define the correct routing/proxy . Example define routing based on User Agent .
I already modified library and looks like works like charm

If you want a PR or any help on possible definition of this feature please comment.

The only problem I see with this approach is that the route cache may not work in all the cases. The key used for the cache is the route, so it does not take into consideration things like headers, etc.
https://github.com/OptimalBits/redbird/blob/master/lib/proxy.js#L541

Hi @manast  i was suggesting if there is possibility when i add a new custom resolve receive the full request or headers as an extra parameter .
I guess the route that is built and used for cache purposes will not suffer any modification.
I will just had a quick use case cause you know better than me the usage of redbird .
const proxy = new require('redbird')({
    port: 8080,
    resolvers: [
    function(host, url , REQ) {
       if(url != 'web' && isMobile(REQ.headers))
       {
        return '192.168.30:3000/mobile'
        }
        }
]});

If you can explain the impact and drawback i can probably design a better way to implement with some extra options in configuration etc...

Lets say that you create a custom resolver that for a given header returns different routes. Since redbird caches the incoming routes, the resolver will always return the same route for a given incoming route independently of the headers... so it will not work. A solution would be to disable the cache when using this kind of resolvers, but I am not sure that is a elegant a proper solution.

Yes having this extra object.
Will make posible to do a more precise match or extend resolvers with different possibilities.
You can use url and req.headers or other parameters to build your url .
Anyway  is just an extra an feature ... thanks for the support

This makes a lot of sense!
If I'm able to get access to the req object I can do a lot of smart things in the API-gateway (which is a good use case of redbird in microservices).
For example i could modify the req and forward or I could do authentication and authorization or as @romulocintra said based on user-agent I can serve the right request (mobile devices is a good use case)

I need this as well including an option not to cache as I would like to authenticate each request.


more granular stackdriver control with logging.enabled and metrics.enabled flags

This PR will add more granular control over Stackdriver and will allow having opt-in logging and metrics through logging.enabled and metrics.enabled flags.
Signed-off-by: Jon Yucel<EMAIL_ADDRESS>

any feedback on this?


No info on Advanced Phishing thresholds

Led here by link in O365 S&C Center when editing Advanced phishing thresholds. This page seems to have no information on said thresholds and neither do any of the Related topics.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: f4186938-9985-7168-674d-0403343bec2f
Version Independent ID: 86d4eb4a-f7f5-ceff-c58f-b268111cdec9
Content: Anti-phishing protection in Office 365
Content Source: microsoft-365/security/office-365-security/anti-phishing-protection.md
Service: o365-seccomp
GitHub Login: @MSFTTracyP
Microsoft Alias: tracyp

More specifically this link : http://go.microsoft.com/fwlink/?LinkId=869586

@tllampi - Thank you for submitting feedback.
I will get this issue over to the Microsoft 365 writing team for investigation.
Thank you for reporting and making the docs better. Much appreciated.
I made a note to request the team to update this when the work is complete.

@tllampi Thank you for your feedback. I have checked and the link presented in the S&C admin center is incorrect. I'll check with the author to see how we can get this corrected quickly. Meanwhile, the correct link would be https://docs.microsoft.com/en-us/microsoft-365/security/office-365-security/set-up-anti-phishing-policies
Thanks
Sri

@tllampi - From our understanding, the issue you raised has been answered by msbemba. If you feel it hasn't been answered, please re-open this issue.
Thank you for your contribution to make the docs better! Much appreciated!

Still requires doc owner's inputs.. Reopening issue

@MSFTTracyP - Can you please share your inputs on this issue?
Thank you.

Updated. Thank you.


Recover interactively when the folder is not specified or is wrong

Closes #40. I wanted to start adding some delight ✨ to the CLI, this is the first step.
If the person doesn't specify any folder, we will now check if there's a src or app in the current folder and suggest those. We will also suggest to run in the current folder. If it matches what the person wanted to do, then we will print what command they should run next time if they want to repeat it. If it doesn't, we will casually mention the correct usage and leave the person alone (without an error exit code).
If the person specifies a folder, but it doesn't exist or is a file (for example, when they don't use terminal autocomplete and make a typo), then we will assume that most of what they wrote is correct and will try to correct typos. For example, if they wrote pachages/stieger/scr, we can trace this path and realize that they probably meant packages/steiger/src and then suggest to run the command there.
Screenshots
If no folder was specified and there are no obvious candidates in the current folder:

If that's not what the person wants:

When there's a src in the current folder:

When they made a typo and there's an obvious candidate:

When they accept the suggestion, we're informing them of what command is actually being run now (so that they can copy it, for example):

Typos can occur in different path segments:

When there's a dist folder, we don't consider it as a candidate because it's very unlikely that someone wants to check dist:

When there are several possible candidates that the person could mean:

I've not finished reviewing yet but left some first comments

Also, question, should this be included in the next minor release? If so, then we need to change the destination branch to next

I don't think this is particularly ground-breaking, so I wouldn't mind including it in 0.5.4 as well

Yes, you're right 👍, I missed that point during the review


Formatting and syntax highlighting issue in ballerina IDEA plugin

Description:
Ballerina IDEA plugin grammar tree breaks for type check expressions inside the ternary expressions, as shown by the following example. Therefore the plugin is unable to recover formatting and some syntax highlightings.
Steps to reproduce:
Please refer the code snippet below.

Affected Versions:
0.990.0 and below

Closing the issue since the PR has been merged


Add-person Fields too narrow on half-screen window

I was setting up a study last night, and needed to add a person. With my browser occupying half my screen, the fields were narrow, but a lot of the browser space was unused.

@jwdebelius, want to solve this issue but not sure how to reproduce and the screenshot is gone. Could you let me know? Thanks.

It looks like Bootstrap has fixed the problem, thanks.
On Mon, Jul 11, 2016 at 11:58 AM Antonio Gonzalez<EMAIL_ADDRESS>wrote:

@jwdebelius https://github.com/jwdebelius, want to solve this issue but
not sure how to reproduce and the screenshot is gone. Could you let me
know? Thanks.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/biocore/qiita/issues/806#issuecomment-231830826, or mute
the thread
https://github.com/notifications/unsubscribe/AFR0fjOFjFnpblsvglj7g8JMn91g5Hefks5qUpJFgaJpZM4DU2HI
.

Thank you!


Back-End: Db Entity Relations

Discuss the relationships between the entities in our db model.

Done


[Feature request]: Perform sync automatically

Great work on this tool! Would you consider implementing the actual ffmpeg sync in there too?
E.g. sync start and trim any lagging part of the videos too, and output new videos with _synced appended to the name.
There's ffmpy for using ffmpeg in python which could be good for writing a function.
If you don't have time to look at it I can see if I can put together a pull request if I can figure it out. Alternatively, can syncstart be used within Python, and in that case what would a minimal example of that look like?
Thanks!

It can be done within Python. I just happened to use a shell script.
I wanted to do it over the week-end, but didn't find time.
I was thinking of keeping everything backward compatible,
and just add an option for this feature.
A pull request is very welcome.
For a usage of syncstart.file_offset see test_syncstart.py.

Sounds great to include it as another option. I'm gone for a while, but will try to take a look at it in a month's time. :-)

Any news on this? I was about to write a script for exactly this before I found this project.

It should do to make your own local bash script that uses syncstart.py for local situations where it has proven to be reliable. No plan to do anything in syncstart.py itself.