installation breaks nginx

Describe the bug
A clear and concise description of what the bug is.
the plugin doesn't seem to work with lets encrypt ?
To Reproduce
Steps to reproduce the behavior:
I wanted to test the plugin on a new instance of a server however I have the impression that there is an incompatibility with dokku ssl
here is the log
thanks in advance
root@v904:~# sudo dokku plugin:install https://github.com/dokku/dokku-letsencrypt.git
-----> Cloning plugin repo https://github.com/dokku/dokku-letsencrypt.git to /var/lib/dokku/plugins/available/letsencrypt
Cloning into 'letsencrypt'...
remote: Enumerating objects: 778, done.
remote: Counting objects: 100% (240/240), done.
remote: Compressing objects: 100% (159/159), done.
remote: Total 778 (delta 151), reused 152 (delta 80), pack-reused 538
Receiving objects: 100% (778/778), 159.66 KiB | 3.99 MiB/s, done.

See "systemctl status nginx.service" and "journalctl -xe" for details.
 failed!
root@904:~# journalctl -xe
-- Support: http://www.ubuntu.com/support
--
-- The unit run-docker-runtime\x2drunc-moby-a2a6c78a4e5451fa995bca7209ee8327b69c7e197d657ef0af04a27fb2d4309c-runc.MJVO4L.mount has successfully entered the 'dea>
Dec 30 20:25:23 v904.****.net systemd[498]: run-docker-runtime\x2drunc-moby-a2a6c78a4e5451fa995bca7209ee8327b69c7e197d657ef0af04a27fb2d4309c-runc.>
-- Subject: Unit succeeded
-- Defined-By: systemd
-- Support: http://www.ubuntu.com/support
--
-- The unit UNIT has successfully entered the 'dead' state.
Dec 30 20:25:23 v904.****.net kernel: cgroup: cgroup: disabling cgroup2 socket matching due to net_prio or net_cls activation
Dec 30 20:25:23 v94.****.net kernel: eth0: renamed from veth505c279
Dec 30 20:25:23 v44.****.net systemd-networkd[306]: veth7643134: Gained carrier
Dec 30 20:25:23 v44.****.net systemd-networkd[306]: docker0: Gained carrier
Dec 30 20:25:23 vm94.****.net kernel: docker0: port 1(veth7643134) entered blocking state
Dec 30 20:25:23 vm04.****.net kernel: docker0: port 1(veth7643134) entered forwarding state
Dec 30 20:25:23 vmi04.****.net sudo[25211]:    dokku : TTY=pts/0 ; PWD=/root ; USER=root ; COMMAND=/etc/init.d/nginx reload
Dec 30 20:25:23 vmi94.****.net sudo[25211]: pam_unix(sudo:session): session opened for user root by root(uid=0)
Dec 30 20:25:23 vmi04.****.net systemd[1]: Reloading A high performance web server and a reverse proxy server.
-- Subject: A reload job for unit nginx.service has begun execution
-- Defined-By: systemd
-- Support: http://www.ubuntu.com/support
--
-- A reload job for unit nginx.service has begun execution.
--
-- The job identifier is 1159.
Dec 30 20:25:23 vmi04.****.net nginx[25315]: nginx: [emerg] no "ssl_certificate" is defined for the "listen ... ssl" directive in /var/lib/dokku/da>
Dec 30 20:25:23 vmi04.****.net systemd[1]: nginx.service: Control process exited, code=exited, status=1/FAILURE
-- Subject: Unit process exited
-- Defined-By: systemd
-- Support: http://www.ubuntu.com/support
--
-- An ExecReload= process belonging to unit nginx.service has exited.
--
-- The process' exit code is 'exited' and its exit status is 1.
Dec 30 20:25:23 vmi04.****.net systemd[1]: Reload failed for A high performance web server and a reverse proxy server.
-- Subject: A reload job for unit nginx.service has finished
-- Defined-By: systemd
-- Support: http://www.ubuntu.com/support
--
-- A reload job for unit nginx.service has finished.
--
-- The job identifier is 1159 and the job result is failed.
Dec 30 20:25:23 vmi04.****.net sudo[25211]: pam_unix(sudo:session): session closed for user root
Dec 30 20:25:23 vmi04.****.net sudo[24879]: pam_unix(sudo:session): session closed for user dokku

Firstly, thank you for the complete list of the different steps that led to the error.
The bug comes from the way the plugin handles SSL, nothing to do with letsencrypt as it is totally independent.
Nginx doesn't seem to like having the ssl directive without having a certificate, I don't know why I never had the problem at first installation knowing that I've had several instances working for a while so maybe nginx, in the meantime, has made an update to avoid the ssl directive without a certificate.
From nginx.conf.sigil file
server {
  # ssl directive on listens are always here
  listen [::]:443 ssl http2;
  listen 443 ssl http2;

  ...

  # custom_ssl.conf file is only there when you activate ssl with
  # `dokku posteio:toggle-ssl` and contain certificate path
  include {{ $.POSTEIO_ROOT }}/custom_ssl.conf*;

Example content of custom_ssl.conf
ssl_certificate ${POSTEIO_ROOT}/data/ssl/server.crt;
ssl_certificate_key ${POSTEIO_ROOT}/data/ssl/server.key;
ssl_protocols TLSv1.2;
ssl_prefer_server_ciphers on;" > "${POSTEIO_ROOT}/custom_ssl.conf

custom_ssl.conf file exists because SSL is managed internally by Poste.io

Now that I fully understand the problem I'll do a fix as soon as possible.

Perfect, thank you for your answer

I have just released version v1.6 which fixes the problem :sunglasses:
https://github.com/D1ceWard/dokku-posteio/releases
Do not hesitate to open another issue if other problems arise.


Ability to skip bundle analysis for CI prod builds

It would be great to be able to skip the bundle analysis in cases where you are doing use an automated build tool such as travis or jenkins.
Could you add a constant or env parameter to optionally disable it e.g.
if (!E2E && !WATCH && ANALYZE_BUNDLE) {
  config.plugins.push(
    new BundleAnalyzerPlugin({ analyzerPort: 5000 })
  );
}

@Aigeec it's a constant already: https://github.com/qdouble/angular-webpack-starter/blob/master/constants.js#L11
https://github.com/qdouble/angular-webpack-starter/blob/master/webpack.config.ts#L219
Are you looking for it to be a npm flag?


Incorrect table rendering

Hi there, markdown tables is rendered incorrect even on your demo here.

Parser add extra children in table's children. How it can be resolved?

Probably just a tweak in a regex. I’ll take a look tonight or tomorrow
On Thu, Dec 21, 2017 at 10:34 AM Andrei Kiselev<EMAIL_ADDRESS>wrote:

Hi there, markdown tables is rendered incorrect even on your demo here.
[image: image]
https://user-images.githubusercontent.com/11617476/34262321-2336e1ae-e67d-11e7-89d6-043b1cc05e8c.png
Parser add extra children in table's children. How it can be resolved?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/probablyup/markdown-to-jsx/issues/138, or mute the
thread
https://github.com/notifications/unsubscribe-auth/AAiy1iSh3YuGvTPdZvTzQ973PSLb3NJ4ks5tCnqFgaJpZM4RJ-x1
.


GPU issue ?

cannot run :
Digest: sha256:de199a88ac62acf04daa7940e36da495716ff6224e2d6ff588598745417ae05a
Status: Downloaded newer image for ghcr.io/kth8/bitnet:latest
warning: not compiled with GPU offload support, --gpu-layers option will be ignored
warning: see main README.md for information on enabling GPU BLAS support
build: 0 (unknown) with Alpine clang version 17.0.6 for x86_64-alpine-linux-musl
main: llama backend init
Error occurred while running command: Command '['build/bin/llama-cli', '-m', 'Llama3-8B-1.58-100B-tokens-TQ2_0.gguf', '-n', '128', '-t', '2', '-p', 'The meaning to life and the universe is', '-ngl', '0', '-c', '2048', '--temp', '0.8', '-b', '1']' died with <Signals.SIGILL: 4>.

@alexmodesto73  This requires a CPU with AVX2 support from Intel Haswell/AMD Excavator or later generations.

ok :+1:


I would like a Discord icon

Hello.  Here is my Discord icon.

Blarhgh

Hi! We really appreciate your contribution, however brand-related icons are deprecated and we are not adding new ones, as discussed in https://github.com/feathericons/feather/issues/763.

What @locness3 said, nice art btw!

@wringit If you need a brand icon like discord checkout: https://github.com/simple-icons/simple-icons


Custom error messages

I've glanced through the docs, but haven't found a way to set my own validation error messages. Is this possible?

One trivial way to achieve that is by invoking self._error in your custom validator, see this snippet


Avoid external DID service on Cypress

rLogin uses did.rsk.co to fetch credentials. This makes integration tests fail sometimes

I can't tell which test this is that is failing, but this method mocks a response back from that service. Perhaps the test above does not invoke this method?

Maybe adding that interception in the beforeEach makes more clear that all requests are being intercepted. I don't remember now what test was but it makes no sense getting timeout for an intercepted request, so i guess there is a request not being intercepted somewhere. Not sure.


[SOLVED] Error: libindy.so: cannot open shared object file: No such file or directory

Following this walk-through led me to the error:
Error: libindy.so: cannot open shared object file: No such file or directory
    at Object.Module._extensions..node (node:internal/modules/cjs/loader:1168:18)
    at Module.load (node:internal/modules/cjs/loader:989:32)
    at Function.Module._load (node:internal/modules/cjs/loader:829:14)
    at Module.require (node:internal/modules/cjs/loader:1013:19)
    at require (node:internal/modules/cjs/helpers:93:18)
    at bindings (PATHTOMYFOLDER/indy-sdk/libindy/node_modules/bindings/bindings.js:112:48)
    at Object.<anonymous> (PATHTOMYFOLDER/indy-sdk/libindy/node_modules/indy-sdk/src/indyBinding.js:1:37)
    at Module._compile (node:internal/modules/cjs/loader:1109:14)
    at Object.Module._extensions..js (node:internal/modules/cjs/loader:1138:10)
    at Module.load (node:internal/modules/cjs/loader:989:32) {
  code: 'ERR_DLOPEN_FAILED'

This showed up by running:
npx -p @aries-framework/node is-indy-installed

EDIT: Solved by
sudo /sbin/ldconfig -v

Is this on macOS or Linux?

Linux, Debian (Kali)

Do you have any idea what could cause this issue @blu3beri? Should we add the command (sudo /sbin/ldconfig -v) to the troubleshooting section?

ldconfig -v just does ldconfig in verbose mode. This is extremely unlikely to be the fix. Maybe reloading the shell fixed it. I've checked the guide and this error means that it could not find Libindy.so in the common folders (/usr/local/lib, usr/lib, etc).

Ok, closing this for now. Can take another look if other people have the same issue


Issue with Argo datasets

https://seadatanet.geodab.eu/gs-service/services/essi/csw?service=CSW&version=2.0.2&request=GetRecordById&id=C4FCB80C939B2B9DC3E9686BCDB67507780799C3&outputschema=http://www.isotc211.org/2005/gmi&elementSetName=full
For this record the SA should find sensors, variables and platforms but it only finds variable. The vocabulary is already uploaded in the KB and is R27 for instruments
Second dataset:
Finds instruments
Cannot find anything else

SOLO Profiling Float SBE_0986 - 4901059 - Argo WHOI

APEX Profiling Float 7425 - 5905020 - Argo AUSTRALIA
For this one it finds nothing at all

still missing platform in first record

platforms appearing on wildcard match


Update Developer Guide

based on TA's comments in first pr

Pull Request Test Coverage Report for Build 44

0 of 0 (NaN%) changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 91.868%

Totals

Change from base Build 43:
0.0%

Covered Lines:
1480

Relevant Lines:
1611

💛  - Coveralls

Nice work with the more targeted user descriptions!


Align number

There is a way to align the number on left or right?

Thank you raising an issue. As of now this is not possible as this property is not exposed and defaults to TextAlign.center. I will expose this property in the next release. Hope that's ok. 😃

Thank you raising an issue. As of now this is not possible as this property is not exposed and defaults to TextAlign.center. I will expose this property in the next release. Hope that's ok. 😃


Better guard against second mod load

It seems that people have been getting a bug where the second OnScreenDebugInfo awakes before preloading is finished, so the LoadModsInit coroutine is started a second time. This guards against that.

At that point i think making the Preloaded flag into a state enum is a better way, could get rid of the loaded and ispreloading bools while being readable and maintainable

True


Client Allocation Request for: 广州市思歌智能科技有限公司

Client Allocation Questions
Core Information

Name: 广州市思歌智能科技有限公司
Website / Social Media: http://www.sigezn.com/
Region: Greater China
DataCap Requested: 100TiB
Addresses to be Notarized: f3u3unadf654vezf62cd4jo6r7h6qpkx26g5amcdc3oe6rmpmk2nfosfd2kjkdhj4ndvr626gsm7fhpmt7gg2q
Notary Requested: steven004

@kyokaki Please subscribe to notifications for this Issue to be aware of updates. Notaries may request additional information on the Issue.

Hey @kyokaki , thanks for your request. Can you kindly add more information / context here on:

yourself/ your organization (with links to official website/social media/news mentions etc)
Your history working on IPFS/Filecoin (notable contributions to the community, type of engagement shown over time etc)
Use case: type/source/quantity/diversity/scarcity of the data you plan to store on Filecoin
Miners you intend to allocate DataCap with allocation proportion(with redundancy/location/specific requirement of storage miners), if you are working with a service provider to store your data to Filecoin network, please name the provider.
How could people retrieve the data you store in Filecoin Network, do you have a tool/app for it?
What's your next plan for the data you plan to store in Filecoin Network? For-profit or not?
Would you be OK in posting deal transactions here?

Thanks

Closed due to no response.
@kyokaki , you could reopen it if you still need the datacap.


Add package.sh and improve tic-tac-toe.sh

A suggestion unrelated to this PR: there are global-util.sh and util.sh. global-util.sh is used by both the Python-related and the package-related harness scripts, while util.sh is used only by the Python-related scripts. It seems more appropriate to rename:

util.sh -> python-util.sh
global-util.sh -> util.sh

What do you think?

A request: if you address a specific concern, please leave a comment in the corresponding conversation, making this fact obvious. E.g., "Done."

There are now global-util.sh and python-util.sh. global-util.sh is used by both the Python-related and the package-related harness scripts, while python-util.sh is used only by the Python-related scripts. It seems more appropriate to rename: global-util.sh -> util.sh.
What do you think?

I agree and have done it already


How to reproduce the results in the leaderboard?

During the evaluation process, I noticed that the models have different lengths, such as qwen-128, and the length is measured using the tokenizer of gpt-3.5-turbo. For qwen 128k, should it be set as 128k in the configuration? Similarly, should kimi be set to 200k?

MAX_LENGTH="256000" # According to the context window of llm. The value of config takes precedence
for qwen 128k it should be 128k？
for kimi  is should be 200k?
Is my understanding correct?

Thank you for your attention to our work.
Considering the different compression rates of various tokenizers and reserving a portion of the length for output, we recommend setting the MAX_LENGTH of the 128K model to 110K and the MAX_LENGTH of the 200K model to 190K.


Move colFeatureData and related functions to SFE package

It seems that SFE is a more appropriate place for those. I can re-export them in Voyager so nothing is changed from the user's perspective.

Also need to deal with cbind and changes in sample_id when it comes to things like colFeatureData. So I'm more behind in alabaster.sfe than I initially thought. I also need to deal with writing things like colFeatureData to disk in a language agnostic way.


Customer needs support for IBM MQ Logs

Customer is looking to have support for IBM MQ Logs in SC4S. The MQ Appliance which is based on the Datapower appliances uses the RFC 3164 spec. Please see following documentation https://www.ibm.com/docs/en/mq-appliance/9.3?topic=targets-format-mq-logs-sent-log. They also provided pcap file for the logs. Appreciate I can be contacted here<EMAIL_ADDRESS>for the file.

Will continue the discussion on internal channels.

The solution is posted internally.

the solution posted internally implemented but some of the logs goes into main index as well. How can we resolve it


Implement sort for Starred nodes as well similar to activity log

MongoDB does not support case insensitive search as yet. Refer: https://jira.mongodb.org/browse/SERVER-90


Exception thrown when pasting example code into WYSIWYG editor

Version
1.4.8
Test Environment
Linux, Chromium 78.0
Current Behavior
Open the editor "basic" example, select the example below and paste into WYSIWYG editor:
var foo = function (bar) {
  return bar++;
};

Expected Behavior
No exceptions should be thrown, but the following exception is thrown:
TypeError: Cannot set property 'innerHTML' of null
    at VM25 tui-editor-Editor-full.js:107801
    at Array.forEach (<anonymous>)
    at WwClipboardManager._replaceNewLineToBr (VM25 tui-editor-Editor-full.js:107799)
    at WwClipboardManager._preparePaste (VM25 tui-editor-Editor-full.js:107947)
    at WwClipboardManager._onWillPaste (VM25 tui-editor-Editor-full.js:107813)
    at WwClipboardManager._executeHandler (VM25 tui-editor-Editor-full.js:107707)
    at VM25 tui-editor-Editor-full.js:107685
    at VM25 tui-editor-Editor-full.js:36952
    at forEachArray (VM25 tui-editor-Editor-full.js:11653)
    at Object.forEach (VM25 tui-editor-Editor-full.js:11730)

@docent
That's right. Thanks for the bug report.

Case 1
When plain text containing a newline is pasted into the editor, the newline should be changed to
.
foo
bar

Case 2
Newline characters should be preserved when text containing newline characters in the code block is pasted into the editor.

var foo = function (bar) {
  return bar++;
};


Added packet aggregation to mavfwd

Packet parsing is done via mavlink library.
Packet aggregation by packet count or buffered bytes.
MAVLINK_MSG_ID_ATTITUDE will flushed buffered packets, so no OSD latency is added.

wrong source<>destination


Cilium + HCCM

:tada: This PR is included in version 1.1.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


0.46 rc.2 - display:none crashes app

According to the docs https://facebook.github.io/react-native/docs/layout-props.html
display can be either flex or none. Unfortunatly with 0.46 rc.2 display none just crashes the app. On 0.43 - it also had issued. The app was hanging -> CPU went to 100% and memory was filling up. But on 46 the app just crashes
libsystem_kernel.dylib`__pthread_kill:
    0x109e8cd38 <+0>:  movl   $0x2000148, %eax          ; imm = 0x2000148
    0x109e8cd3d <+5>:  movq   %rcx, %r10
    0x109e8cd40 <+8>:  syscall
->  0x109e8cd42 <+10>: jae    0x109e8cd4c               ; <+20>
    0x109e8cd44 <+12>: movq   %rax, %rdi
    0x109e8cd47 <+15>: jmp    0x109e85caf               ; cerror_nocancel
    0x109e8cd4c <+20>: retq
    0x109e8cd4d <+21>: nop
    0x109e8cd4e <+22>: nop
    0x109e8cd4f <+23>: nop

Here is a repository where I've reproduced the issue:
https://github.com/compojoom/rn46crash
Just run yarn and afterwards launch the app in ios.
Additional Information

React Native version: 0.46 rc2
Platform: tested with iOS
Development Operating System: macOS
Build tools:XCode

hey @compojoom , i am facing the same issue, did you find any solution for this.

@japesh - a workaround would be to not use display none, but overflow: hidden and width: 0, height: 0.
But yea - display: none shouldn't lead to a crash of the App in the first place.

I'm encountering the same issue in 0.45.1 at iOS, but it looks good at Android.
export default class test123 extends Component {
  render() {
    return (
      <View style={{ display: 'none' }}>
        <Text>
          Why crash?
        </Text>
      </View>
    );
  }
}

Seems like it's been fixed in this commit:
https://github.com/facebook/react-native/commit/ac3f345b071fbf762e7224fc6357ab2f7080575c

ok, tested with ac3f345 - it seems to be fixed now.

thanks for the answer @compojoom  & @patw0929

The cpu jumps to 100% and  the app hang there if i apply ac3f345 to<EMAIL_ADDRESS>

On<EMAIL_ADDRESS>app crashes on ios when a view with display:none holds another component with styling. @compojoom provided a cool work around, but in my case I ended up using state to decide if to render or not.


Option to Label Daily Journal as Journal

Please select the area your Bug applys to. (Multiple selections are Possible)

[ ] Onboard. Initial vault setup and import/export pods
[X] Create. Note creation, lookup, snippets and templates
[ ] Retrieve. Backlinks, references, graph view
[ ] Structure. Refactoring, multi-vault and schemas
[ ] Publish. Sharing your repo with the world
[ ] Misc (Choose this if your not sure)

Describe the bug
Less of a bug report, more of a question.
Prior to Dendron 0.51.0, I was able to create daily journal notes with the following naming convention: journal.y.MM.dd.
With the update to Dendron 0.51.0, this ceased to work. I emptied the deprecated journal note fields in the VS Code settings, and attempted to restore the old setup in my dendron.yml. I have not been successful.
My dendron.yml setup is currently as follows:
journal:
    dailyDomain: journal
    name: journal
    dateFormat: y.MM.dd
    addBehavior: childOfDomain
    firstDayOfWeek: 1

If I leave dailyDomain empty then I am unable to create daily journal notes at all.
If I leave name empty then I am able to create daily journal notes with the naming convention: journal.y.MM.dd, but:

The title field in the frontmatter is not filled correctly.
I can no longer create journal notes with the naming convention: {domain}.journal.y.MM.dd.

I have combed through the Dendron site this past week, but I have been unable to find a setting for the dendron.yml that would replicate the old set up.
Is there an option to label daily journal notes as just "Journal" at this time?
Thank you.

This should work 🙂
journal:
    dailyDomain: journal
    name: journal
    dateFormat: y.MM.dd
    addBehavior: asOwnDomain
    firstDayOfWeek: 1

Please let me know if it doesn't.

Thank you for the suggestion. I have updated my my dendron.yml, and this has fixed issue 1. I am able to create daily journal notes with the naming convention journal.y.MM.dd and the frontmatter is being filled in correctly.
However, issue 2 remains unresolved. I still cannot create journal notes with the naming convention '{domain}.journal.y.MM.dd'. Trying to use the feature, regardless of the current domain, automatically fills in the note title as journal.y.MM.dd.
Is there a way to restore this functionality? Or is that not possible at this time?
Thank you.

Giving this issue a bump.
With the release of Dendron 0.93, the Calendar View has been enabled in my vault for the first time.
With my current dendron.yml setup:
journal:
    dailyDomain: journal
    name: journal
    dateFormat: y.MM.dd
    addBehavior: asOwnDomain

Using the Calendar View generates journal notes with the title format of journal.journal.y.MM.dd. For example, journal.journal.2022.05.03. This is despite my already having a journal note of journal.2022.05.03, created through the default Dendron command of Ctrl+Shift+I.
At the moment, these two methods for creating journal notes, the Calendar View and the lookup command, are not in agreement.
Please let me know if this should be spun of as its own issue.
Thank you.


support for displaying math special characters and formulas in documentation

Perhaps use math directive:
http://docutils.sourceforge.net/docs/ref/rst/directives.html#math

or use mathjax but not sure if this works on RTD

https://build-me-the-docs-please.readthedocs.io/en/latest/Using_Sphinx/UsingMathEquationsInSphinx.html

Turns out mathjax is built in


Fix Issue 10131 - To remove duplicates and keep order

This is the same as #5774 . I closed the PR and made a new one to some github branch mix-ups I made.

I'll add that this (and other related functions) is an important function for things like relational joins etc. Martin Odersky showed me some pretty amazing short example that do powerful things because of such.

After planning things with @RazvanN7 will close this in wait for scoped hashtables. cc @edi33416 :)


22 unit testing code coverage

Removed code that was directly committed to master
Added unit tests for full code coverage

Closing since xctool tests are failing


Update Windows CI settings

Following from discussion on #5028

Does not use rake -m for avoiding mixing output from rake tasks. Further, it appears building with -m introduces other issues while performing separate build and test tasks. The project builds in less than a minute so I do not think the parallelization helps.
Removes MSC build from github actions
Removes VS 2013 from Appveyor matrix as 2013 is no longer supported by MS (https://docs.microsoft.com/en-us/visualstudio/releases/2019/servicing)

@shuujii I think this addresses your comments?

Did you give up rake -m (multi-tasking) to build? Any specific reason?

@shuujii has a good point on #5028 (https://github.com/mruby/mruby/pull/5028#issuecomment-651647168) where running tests with -m makes interpreting test output difficult as all the output is mixed. I tried separating the build command using rake -m and the test command which does not use -m. However, building with -m and then testing without -m leads to some strange segfaults on all nix system, seen in this commit https://github.com/mruby/mruby/pull/5031/commits/b3dace6ae3d28417bf7061a560671734a5568de5
I can put the test back as one line using -m as that is what it was before. One, it is strange how the build process with -m causes a segfault. Two, I think it is a good point that running test with multitask makes output hard to figure out
I did turn on -v with tests though so we can see exactly what tests failed.

However, building with -m and then testing without -m leads to some strange segfaults on all nix system, seen in this commit b3dace6

It may be because MRUBY_CONFIG envvar is not set to the build action.

It may be because MRUBY_CONFIG envvar is not set to the build action.

Sorry, it's not just MRUBY_CONFIG. It's also CC, CXX, CFLAGS, etc.

🤦 You're right, I read the yaml file wrong. I thought the env key applied to all of that step, not just the run step. That will fix it.
Apologies if there is notification spam as I push more commits testing this. Not possible working with CI otherwise.

Thanks @shuujii that was the issue. Everything works now.

@RoryO can you remove -v from tests? It's too verbose when I look into logs. I will use -v on my box.

Thank you!


OMZ + zle reset-prompt prevents browsing history with arrow keys

I just installed zsh and oh-my-zsh (my previous shell was bash). My .zshrc is completely unmodified from oh-my-zsh's default settings. The "git" plugin is the only enabled plugin.
I created a very simple theme using this technique:
setopt PROMPT_SUBST
PROMPT='[%D{%L:%M:%S}] '
TMOUT=1
TRAPALRM() {
  zle reset-prompt
}

After enabling this theme, I am finding that the up and down arrow keys do not properly recall my history:

When I press the up arrow once, my most recent command is recalled, as expected.
When I press the up arrow a second time, nothing happens. I expected my next-most-recent command to be recalled.
When I press the down arrow after pressing the up arrow the first time, nothing happens. I expected the prompt to go back to the empty prompt I started with.

The output of history shows a full history.
If I replace my .zshrc with only the contents of the script above (essentially using the prompt settings from the theme but disabling oh-my-zsh), my up and down arrows work as expected.
If I go back to my oh-my-zsh .zshrc and comment out the zle reset-prompt line in my theme, my history works fine (but the clock is no longer live).
How can I use both oh-my-zsh and zle reset-prompt without causing my up/down arrows to behave differently? Is this a bug in oh-my-zsh, or a configuration error?

Not sure the reason but here is a temporary work around
TRAPALRM() {
    if [[ $WIDGET != *"complete"* && $WIDGET != *"beginning-search" ]]; then;
        ((C=((C+1) % 124) + 88));
        zle reset-prompt;
    fi
}

Can't reproduce in latest OMZ version and zsh 5.5.1. Reopen if this still happens.


No verification bypass option in session buildup

Great work! Please consider:
Change
import request.Session

to
import request

def __init__(self, url, username, password, verify=True, session=None):
        """Create a client for the given ePO server.

        :param url: Location of ePO server.
        :param username: Username to authenticate.
        :param password: Password to authenticate.
        :param session: Custom instance of :class:`requests.Session`,
            useful for configuring server verification.
        """
        self.url = url
        self.username = username
        self.password = password

        if session is None:
            session = requests.Session()

        self._session = session
        self._token = None

        self._verify = verify
        if not verify:
            requests.packages.urllib3.disable_warnings()

and
if any(kwargs.get(key) for key in ("data", "json", "files")):
            # Use post method if there is post data.
            r = self._session.post(url, verify=self._verify, **kwargs)
        else:
            r = self._session.get(url, verify=self._verify, **kwargs)

This allows the client to bypass certification verification in development situations

I don't think this needs to change. session is already an argument due to the need to control verify (either enable, configure, or disable it). And I don't think a library should automatically disable warnings in another library, that's something a user should be doing deliberately.

Understood - its not clear in the session documentation, but appears as though "verify" is an argument to the get/post methods, not the class definition/init. If so, verify cannot be set in the session object and passed to the Client() init

verify is an argument to Session.

verify is an attribute of Session https://docs.python-requests.org/en/latest/api/#requests.Session.verify

#Schooled - thanks!


Fix 'ray' imports

I see most modules expect to get ray from:
from isofit import ray

in order to possibly get the local-only wrapper. If this is a project expectation, I think it would be wise to implement something in the test suite that looks for improper imports. Thoughts?
I also removed one unused import ray.

Game to add to the test suite for this; this is a developer feature, but a popular one post implementation.  @jammont, any other thoughts?
Happy to merge this PR in though without objection, as it's a bug fix in it's own right.


ADBDEV-2435 6.19.1 sync

Here are some reminders before you submit the pull request

[ ] Add tests for the change
[ ] Document changes
[ ] Communicate in the mailing list if needed
[ ] Pass make installcheck
[ ] Review a PR in return to support the community

@seryozhasmirnov, please take a look at https://github.com/arenadata/gpdb/pull/299/commits/22c2fdafd29a51834aa2f245d8ed49665416bf46. It conflicts with your patch https://github.com/arenadata/gpdb/commit/886ea379dbab30d35cc42c24eee076fdffa1114d. We need to undestand differences between patches before resolving conflicts.


tk.ts_summary()

Create a tk.ts_summary() function similar to timetk in R: https://business-science.github.io/timetk/reference/tk_summary_diagnostics.html

This is finished. I just need to update the documentation.


TFL Shapes

An initial pass at creating shapes from the TFL API.
Notably we're missing a few shapes due to missing data or erronous data. In some cases stops are significantly distanced away from a path given in the lineStrings causing this program to not create a shape for it currently.
As a secondary pass I suppose we could do the following things to improve the situation...

Inject the stops themselves into the paths between two of the closest points in the lineStrings or at the end of the closest one.
If there are no line strings just use the stops themselves.

The second option I probably need to do before this will work with our importer anyways, so that will be done

This seems to work as is, right now, with our pgsql importer, so I'm ok with leaving this as is for now if you are

Yeah, this looks good enough for now.


hotfix/testingCenter -> dev

This change is

Reviewed 3 of 3 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

byuSuite/Classes/Reusable/Extensions.swift, line 977 at r1 (raw file):

extension UIView {
	func setGradientBackground(bottom: UIColor, top: UIColor) {

So does this function apply a gradient to the entire view? Or just part of the view (since we were thinking 25% or something like that)?

byuSuite/Classes/Reusable/UI/Cameras/CameraCell.swift, line 40 at r1 (raw file):

	override func awakeFromNib() {
		//Hide hidden view so that the gradient background does not appear until the image is loaded.
		infoView.isHidden = true

Can we do this from the storyboard?

byuSuite/Classes/Reusable/UI/Cameras/CameraCell.swift, line 41 at r1 (raw file):

		//Hide hidden view so that the gradient background does not appear until the image is loaded.
		infoView.isHidden = true
		infoView.setGradientBackground(bottom: UIColor(red: 0.0, green: 0.0, blue: 0.0, alpha: 1.0), top: UIColor(red: 0.0, green: 0.0, blue: 0.0, alpha: 0.0))

Is there a reason we can't use UIColor.black and UIColor.white?

Comments from Reviewable

Review status: all files reviewed at latest revision, 3 unresolved discussions.

byuSuite/Classes/Reusable/Extensions.swift, line 977 at r1 (raw file):
Previously, romrell4 (Eric Romrell) wrote…
So does this function apply a gradient to the entire view? Or just part of the view (since we were thinking 25% or something like that)?

this is a gradient for whole view that it is on. That is why this method is only called on the infoView, as that is the block overlay.

byuSuite/Classes/Reusable/UI/Cameras/CameraCell.swift, line 40 at r1 (raw file):
Previously, romrell4 (Eric Romrell) wrote…
Can we do this from the storyboard?

yes, I will move it.

byuSuite/Classes/Reusable/UI/Cameras/CameraCell.swift, line 41 at r1 (raw file):
Previously, romrell4 (Eric Romrell) wrote…
Is there a reason we can't use UIColor.black and UIColor.white?

we cannot, because fading from black to white is not the same from fading from 100% black to 0% black (which is the effect we want).

Comments from Reviewable

Review status: 0 of 3 files reviewed at latest revision, 2 unresolved discussions, some commit checks pending.

byuSuite/Classes/Reusable/UI/Cameras/CameraCell.swift, line 40 at r1 (raw file):
Previously, romrell4 (Eric Romrell) wrote…
:thumbsup:

Done.

byuSuite/Classes/Reusable/UI/Cameras/CameraCell.swift, line 41 at r1 (raw file):
Previously, romrell4 (Eric Romrell) wrote…
Could the first one at least be UIColor.black? And maybe we could create a UIColor.transparent?

Done.

Comments from Reviewable

Reviewed 3 of 3 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable


python310Packages.pyvicare: 2.27.2 -> 2.28.1

Diff: https://github.com/somm15/PyViCare/compare/refs/tags/2.27.2...2.28.1
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

@ofborg eval


Master

Merge to existing branch

Master can not be merged as it is too far behind, with other changes.


CosmosDB cache invalidator refactor

The cosmosdb cache invalidator needs to be more defensive about downstream sdk errors like:

cosmosdb failures at startup
kafka producer failures during processing

Description
These types of issues are most commonly related to configuration problems, so this refactoring mainly addresses these issues by exiting the application when these failure scenarios occur.
Deployments should handle termination by restarting the application, but typically the configuration issues will not be resolvable until the configuration is repaired, and exiting the application is aimed to bring increased visibility to the configuration problems as they happen.
Related issue and scope

[ ] I opened an issue to propose and discuss this change (#????)

My changes affect the following components

[ ] API
[ ] Controller
[ ] Message Bus (e.g., Kafka)
[ ] Loadbalancer
[ ] Invoker
[ ] Intrinsic actions (e.g., sequences, conductors)
[x] Data stores (e.g., CouchDB)
[ ] Tests
[ ] Deployment
[ ] CLI
[ ] General tooling
[ ] Documentation

Types of changes

[ ] Bug fix (generally a non-breaking change which closes an issue).
[x] Enhancement or new feature (adds new functionality).
[ ] Breaking change (a bug fix or enhancement which changes existing behavior).

Checklist:

[x] I signed an Apache CLA.
[x] I reviewed the style guides and followed the recommendations (Travis CI will check :).
[x] I added tests to cover my changes.
[ ] My changes require further changes to the documentation.
[ ] I updated the documentation where necessary.

@asteed Please review when you have time.

FYI CacheInvalidatorTests require cosmosdb connection - I have verified passing tests in a separate env that has cosmosdb enabled.

Codecov Report

Merging #4890 into master will decrease coverage by 6.46%.
The diff coverage is 0.00%.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7113b73...63d2b44. Read the comment docs.

Codecov Report
Attention: Patch coverage is 0% with 62 lines in your changes missing coverage. Please review.

Project coverage is 76.78%. Comparing base (7113b73) to head (63d2b44).
Report is 338 commits behind head on master.

Files with missing lines
Patch %
Lines

...e/database/cosmosdb/cache/ChangeFeedConsumer.scala
0.00%
32 Missing :warning:

...ore/database/cosmosdb/cache/CacheInvalidator.scala
0.00%
23 Missing :warning:

.../openwhisk/core/database/cosmosdb/cache/Main.scala
0.00%
4 Missing :warning:

...e/database/cosmosdb/cache/KafkaEventProducer.scala
0.00%
3 Missing :warning:

:exclamation:  There is a different number of reports uploaded between BASE (7113b73) and HEAD (63d2b44). Click for more details.
HEAD has 12 uploads less than BASE

Flag
BASE (7113b73)
HEAD (63d2b44)

16
4

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4890      +/-   ##
==========================================
- Coverage   83.24%   76.78%   -6.47%
==========================================
  Files         200      200
  Lines        9307     9334      +27
  Branches      392      378      -14
==========================================
- Hits         7748     7167     -581
- Misses       1559     2167     +608

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


New package: WykoOPDReader v0.1.2

Registering package: WykoOPDReader
Repository: https://github.com/jaakkor2/WykoOPDReader.jl
Created by: @jaakkor2
Version: v0.1.2
Commit: a55c4c1d3c6400b43c9cdbf01b077e77279d6647
Reviewed by: @jaakkor2
Reference: https://github.com/jaakkor2/WykoOPDReader.jl/issues/1#issuecomment-2439430523
Description: Reader for Wyko datasets (.opd)

Thank you for submitting your package! However, could you extend the documentation in the README a little bit more? It would probably be good for "Wyko OPD profilometer datasets" to be a link to some page that explains the format and gives some context. Please also explain what the type of data is that results from readopd, and what one might be able to do with that object.

[noblock] Thank you @goerz for taking the time to review new package entries.  Now I found Matlab script many by Veeco https://mtl.mit.edu/pipermail/labnetwork/attachments/20110711/1f04a0e6/attachment.ksh that seems be the best available description of the OPD format.  I added a link to that to README.md. Also, docstring for readopd had already a plotting example.  Hopefully these answers your concerns.

Closing in favor of https://github.com/JuliaRegistries/General/pull/118158
In the future, please do not change the version number when addressing issues with the registration.

Hopefully these answers your concerns

My question was about the type of data. It seems like it might be Dict. You'll want to document that, and which keys the dict has, and what information the dict values contain.


BWA to samtools pipe does not add header

While piping the output of BWA to samtools, add header to he bam file in the wdl. It does not generate error but it will improve the processing time.

Fixed in glb-2022-02 branch


PushNotifications: Add missing files to unoproj

This unbreaks master, which currently is broken due to #461
This PR contains:

[ ] Changelog
[ ] Documentation
[ ] Tests

@sebbert: Please don't send PRs from the public repo, send from your own fork instead.


Serving application with bazel run doesn't build dependent library

🐞 Bug report
Command (mark with an x)

[ ] new
[ ] build
[x] serve
[ ] test
[ ] e2e
[ ] generate
[ ] add
[ ] update
[ ] lint
[ ] extract-i18n
[ ] run
[ ] config
[ ] help
[ ] version
[ ] doc

Description
I have a monorepo containing an Angular application (called app) and an Angular library (called lib). Bazel is configured and we can build the application using the following command:
$ bazel build angular/app:build
(...)
INFO: 1 process: 1 internal.
INFO: Build completed successfully, 1 total action

However, serving the application with the following command fails because the library can't be resolved:
$ bazel run angular/app:serve
(...)
INFO: Analyzed target //angular/app:serve (0 packages loaded, 0 targets configured).
INFO: Found 1 target...
Target //angular/app:serve up-to-date:
  bazel-bin/angular/app/serve.sh
  bazel-bin/angular/app/serve_loader.js
  bazel-bin/angular/app/serve_require_patch.js
INFO: Elapsed time: 0.564s, Critical Path: 0.00s
INFO: 1 process: 1 internal.
INFO: Build completed successfully, 1 total action
INFO: Build completed successfully, 1 total action

The errors correspond to imports of elements contained in the library lib the application relies on.
app:serve:
ERROR in angular/app/src/app/core/components/app/app.component.ts:2:45 - error TS2307: Cannot find module 'lib' or its corresponding type declarations.

2 import { InternationalizationService } from 'lib';
                                              ~~~~~
angular/app/src/app/core/components/auth/confirm-email/confirm-email.component.ts:3:29 - error TS2307: Cannot find module 'lib' or its corresponding type declarations.

(...)

Our Bazel configuration is based on the one in this project: https://github.com/bazelbuild/rules_nodejs/blob/master/examples/angular_bazel_architect/BUILD.bazel#L13
🌍 Your Environment

$ ng version

Angular CLI: 10.2.1
Node: 12.19.1
OS: linux x64

Angular: 10.2.4
... animations, common, compiler, compiler-cli, core, forms
... language-service, localize, platform-browser
... platform-browser-dynamic, router
Ivy Workspace:

Package                            Version
------------------------------------------------------------
@angular-devkit/architect          0.1002.1
@angular-devkit/architect-cli      0.1002.1
@angular-devkit/build-angular      0.1002.1
@angular-devkit/core               10.2.1
@angular-devkit/schematics         10.2.1
@angular/cdk                       10.2.7
@angular/cli                       10.2.1
@angular/material                  10.2.7
@angular/material-moment-adapter   10.2.7
@bazel/bazelisk                    1.7.3
@bazel/ibazel                      v0.14.0
@bazel/rollup                      3.0.0
@bazel/typescript                  3.0.0
@bazel/worker                      3.0.0
@schematics/angular                10.2.1
@schematics/update                 0.1002.1
ng-packagr                         10.1.2
rxjs                               6.6.3
typescript                         4.0.5

Hi, Angular bazel is no longer supported by the Angular tooling team. Please see: https://dev.to/bazel/angular-bazel-leaving-angular-labs-51ja
Kindly open an issue in https://github.com/bazelbuild/rules_nodejs

Hi, Angular bazel is no longer supported by the Angular tooling team. Please see: https://dev.to/bazel/angular-bazel-leaving-angular-labs-51ja
Kindly open an issue in https://github.com/bazelbuild/rules_nodejs

@alan-agius4 thanks very much for your answer!

@alan-agius4 thanks very much for your answer!


[SQLite] Running our test suite spams the console with migration messages

Note: PRs addressing this issue should target the diesel-sqlite-support branch, not master. They should also not be made until #152 is merged into that branch.
When we establish a new SQLite connection in our tests, we immediately run the pending migrations. This spams the console. I have no clue why these aren't being swallowed.

I have a feeling this is linked to https://github.com/rust-lang/rust/issues/12309

Fixed by b25be2f


setting --log-level to ERROR or WARNING removes Job Summary block

azcopy version: 10.22.0 on Linux
./azcopy/azcopy copy '../filearchive/*' 'https://?' --overwrite ifSourceNewer --recursive --log-level "ERROR" --from-to=LocalBlob
The summary section in enclosed screendump (present in logfile when --log-level is set to INFO) is not displayed when setting --log-level to ERROR or WARNING.
It would be nice to have the summary section whatever --log-level is set.
-Maybe this is a feature because summary section is generated based on available content in the log file (i.e. only when INFO or DEBUG is set..)?

@FairW are you still experiencing this with the latest AzCopy? (10.24.0) We recently added a feature to print some of these summaries no matter the log level above Error https://github.com/Azure/azure-storage-azcopy/pull/2553

I tried version 10.24.0 - and you are right; using --log-level [ "ERROR" | "WARNING" ] now output s the summary block I was looking for.
-Thanks! Case closed.


"Can't support unit" message does not delete the unit

Has not been implemented yet...

This issue has been solved.


Rows Post Processing Error

Seeing a re-emergence of this issue on a recently release Parquet Dataset: https://github.com/huggingface/dataset-viewer/issues/602
Server error while post-processing the split rows. Please report the issue.
Error code:   RowsPostProcessingError

https://huggingface.co/datasets/parler-tts/mls_eng_10k

Yes, it's a known issue: https://huggingface.co/datasets/parler-tts/mls_eng_10k/discussions/1
-> https://github.com/huggingface/dataset-viewer/issues/2584
Hopefully we have a solution soon. cc @polinaeterna @albertvillanova  if you have more details


[feature] Service Accounts in Omni UI

Problem Description
Currently, can only create SA's from the CLI. Would love to be able to manage them through the UI.
Solution
No response
Alternative Solutions
We can use the CLI but it's hard to manage permissions and keep track of everything.
Notes
No response

Tracked in Omni repo


OpenSSL verification error

I'm getting an error when I connect to an https endpoint:

OpenSSL::SSL::SSLError: SSL_connect returned=1 errno=0 state=error: certificate verify failed

I'm able to fix it locally by modifying emitter.rb:
       if destination.scheme == 'https'
         http.use_ssl = true
         store = OpenSSL::X509::Store.new
         store.set_default_paths
         http.cert_store = store
       end

However I'm not sure what impact that may have on other users of the library.

Hi @larubbio. Thanks for letting us know about your error, and sorry for taking so long to get back to you about it.
I haven't been able to recreate the error myself. Do you by any chance remember any more details about what happened, such as what you were working on when the error appeared? Or if one specific https endpoint caused the problem?

We were unable to reproduce the error, so I'm closing this.


Missing st and se field in SAS token generated by Browser Storage Explorer (Preview)

Storage Explorer Version: browser version in azure portal
Build Number:
Platform/OS: Browser
Architecture:
Regression From:
Bug Description
The SAS url generated by browser storage explorer is invalid for at least 24 hours.
Steps to Reproduce
Go to Storage Explorer (preview) on browser, generate a SAS url on a blob resource
it would look like
https://xxx.blob.core.windows.net/yyy/zzz.tar.gz?sv=2018-03-28&sig=QqSHQfCTiP%2BlIcaEdRVh4BIeSYAyODspROSCny7NIkE%3D&sr=b

Expected Experience
The url generated should look like the one generated by the app,
https://xxx.blob.core.windows.net/yyy/zzz.gz?st=2019-06-12T04%3A25%3A36Z&se=2019-06-13T04%3A25%3A36Z&sp=rl&sv=2018-03-28&sr=b&sig=QbN3Qo%2BZk3RKe%2Frx1WPaHbtKdW96Es3qDsJxqF7o9uU%3D

This one works fine. You see, st and se fields are missed in the browser version.
I just noticed this problem about 12 hours ago. Before the browser version works fine. My main work station runs Linux, so I use the browser version all the time.

We don't manage anything in the Azure Portal. This is just for the standalone Storage Explorer desktop application. We'll reach out to them.

@craxal At least, can you confirm this issue? Until today, the bug is still there.

it looks like this bug is fixed for now.


Multiplatform .Net Core version

Hi, what about making this project compilable for .Net Core to support multiplatformity? I know there is WinPcap / LibPcap dependency, but how much is that port (un)real?

Related, the fact that the x86 and x64 assemblies are in two separated NuGet packages is very limiting, uniting them into a single package will be great (and actually the only way to reference Pcap.Net from a multi-target solution), please see Supporting multiple .NET framework versions.
Please tell me if I can be of any help to push this forward.

Wow,that's good news , I'm looking forward for it.

Hi @bricknerb, what do you say about a single x86-x64 NuGet package?

@microkost This is possible, proof is SharpPcap already does this, they also have abstracted libpcap, winpcap and airpcap. So I would say this is more than possible

I know this discussion is really old.
Are there any updates since 2018?
Aktually i am trying to get any pcap-nuget running in a .NetCore-application to realize a multiplatform dcp-search. This is not possible with the latest version of PcapDotNet, because it is not supported in .NetCore.
Are there any plans to make a .NetCore-version? Maybe you already got one?
Cheers

I'm pretty sure C++/CLI is only usable on Windows, which makes a .net core version kind of pointless.

I have started to make the library usable for .net core or 5+. Since C++/CLI is no longer supported (in .NET core), the only option left was to use P/Invoke.
Please have a look. It should work for Windows. But I don't think it's ready yet.
https://github.com/klaus0x7c4/Pcap.Net (Brand: fullManaged)


Add repository link and company info

Since current document does not have easy to find repository link and company info, it's hard to contribute to.

Fixed in #21


Cannot load bqplot to jupyterlab from dev. js Error: Plugin 'bqplot' failed to activate.

Hello,
I tried to clone this repository and install from dev to test in jupyter lab. I get the js console error Plugin 'bqplot' failed to activate.
index.js:268 Error: No provider for: jupyter.extensions.jupyterWidgetRegistry.
    at JupyterLab.push.2R+v.Application.resolveRequiredService (index.js:182)

To install, I ran:
cd bqplot
pip install -e .
cd js
jupyter labextension install .

Output of  jupyter labextension list:
JupyterLab v1.2.0
Known labextensions:
   app dir: <path>/miniconda3/envs/JupyterLabv1/share/jupyter/lab
        @jupyter-widgets/jupyterlab-manager v1.1.0  enabled  OK
        bdgenomics.mango.pileup v0.0.5  enabled  OK
        bqplot v0.5.5  enabled  OK*

   local extensions:
        bqplot: <path>/bqplot/js

How do I properly get the JLab extension running from dev? Thanks in advance.

I see you cloned bqplot. If you are using latest master you should use JupyterLab 2. and the latest version of ipywidgets.

Thanks @martinRenou! Where is required version for Jupyter Lab documented? I was unable to find this.

@akmorrow13 , have a look at this: #2798, it sheds some light. Also, here there is a table for front/back-end compatibility.

Thanks @martinRenou


[Unified Recorder] Updates the dev-tool commands to follow the new syntax

Fixes https://github.com/Azure/azure-sdk-for-js/issues/19094
Moving to the new syntax that works in both windows and linux.
TODO

[ ] Update template test commands
[ ] Update app-config migration PR
[ ] Update migration guide

Have the scripts already been changed to actually use the ["--"] args at runtime?

Great catch! @witemple-msft
Messed up. I thought it was working, but turned out it's working because of the default arguments.
Looking now!

Moving to draft since "--" still needs some work.
@witemple-msft is investigating.


Can't login with Chromium or Opera on Ubuntu

I can't login on my Ubuntu on Live Share with Chromium or Opera. It does work when I change the default browser to Firefox.
Program: VSCode
OS: Ubuntu 18.04.4 LTS
How the error occured:

Installed Live Share Extension
Click on 'Invite participants'
Click on message to login
Select 'Login with Microsoft'
Browser opens (Chromium or Opera doesn't matter)
Login to account (private or professional account didn't matter)
Click on 'proceed'
Pop up in browser occurs with something like: 'are you sure to let website execute xdg-open'
Click on 'accept'
nothing happens, VSCode doesn't receive anything

First I tried Opera, then Chromium and at the end Firefox
VSCodeLiveShare.log

As a workaround, can you try running this command: Live Share: Disable VSCode account authentication? This will revert the authentication to the old flow. Please let us know if this unblocks you.

@BrunoGuardia this looks like another issue in built-in auth flow in VSCode. If it is so, we should bug them.

Closing as stale. Please re-open if this continues to be an issue you are seeing.


Mdtools Support

I have been testing out build automation for a small test app/website and thought it would be useful to integrate the mdtool from Xamarin into Cake. It would allow iOS apps to be built from cake; I have written a very basic wrapper around it and proof of concept here if anyone would be interested in it.

@Meberem Haven't used mdtools myself. Is this something commonly used when developing Xamarin applications?
@Redth Do you have any input for this issue?

@Meberem  check out my Cake.Xamarin addin, I have MDTool support:
https://github.com/Redth/Cake.Xamarin/blob/master/Cake.Xamarin/Aliases.cs#L102
It's not documented in the README yet, hopefully @patriksvensson will add some documentation generators for 3rd party addins soon :wink:

@Redth Excellent. I will take a look at generating documentation as soon as there is some spare time. Shouldn't be that difficult.
@Meberem Are you happy with @Redth's answer? Maybe you two could collaborate on the Cake.Xamarin addin?
I'll close this issue for now, and we can re-open it if there's any more things that need to be discussed.

Looks good to me; I can get my iOS build working with cake! Thanks guys!


The azure account type is not shown in both linked accounts and firewall rule dialog

The account type icon doesn’t show. It might cause from moving the account account to mssql folder and the path to icon files are incorrect.

Fixed


Comment

Codecov Report

Merging #96 (f9583e9) into main (3359912) will not change coverage.
The diff coverage is n/a.

:exclamation: Current head f9583e9 differs from pull request most recent head 72b271a. Consider uploading reports for the commit 72b271a to get more accurate results

@@           Coverage Diff           @@
##             main      #96   +/-   ##
=======================================
  Coverage   91.96%   91.96%
=======================================
  Files          14       14
  Lines         809      809
  Branches      109      109
=======================================
  Hits          744      744
  Misses         52       52
  Partials       13       13

Impacted Files
Coverage Δ

formlessness/base_classes.py
89.18% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3359912...72b271a. Read the comment docs.


Updated Readme #10

Updated the readme to reflect how to do the following

Serve the project (npm run dev)
Build the project (npm run build)
Deploy the project

Thanks @Rasika-exol


Nested Routes

It is a common use case where a site structure needs to have nested routing.
Currently, only the top level URL routes can be routed via metal-router. It would be useful to be able to do something along the lines of:
<Router component={SomeComponent} path={some/path/:param1} />

...

class SomeComponent extends JSXComponent {
    render() {
        return {
            <div class="wrapper">
                <HeaderComponent />

                <Router component={FooComponent} path={some/path/:param1/view1} />

                <Router component={BarComponent} path={some/path/:param1/view2} />
            </div>
        }
    }
}

I always thought react-router had a nice API for this:
// Router Configuration
<Route path="/" component={App}>
    <Route path="about" component={About}/>
    <Route path="users" component={Users}>
        <Route path="/user/:userId" component={User}/>
    </Route>
    <Route path="*" component={NoMatch}/>
</Route>

// Resulting Component Trees...

// Route: /
<App/>

// Route: /about
<App>
    <About />
</App>

// Route: /user/23
<App>
    <Users>
        <User userId={23} />
    </Users>
</App>

// Route: /somerandomurl
<App>
    <NoMatch />
</App>

I'm not sure, but I think this layout can still be achieved with the current API. However I think there would be more boilerplate involved.

That would be pretty useful for us in terms of code cleanliness as well, as we currently have something like this.
<Router component={CreateMain} path={`${PortletConstants.urls.basePath}/main/create`} />
<Router component={CreateMain} path={`${PortletConstants.urls.basePath}/main/create/:model([a-zA-Z]+)`} />
<Router component={EditMain} path={`${PortletConstants.urls.basePath}/main/:portletMainId(\\d+)`} />
<Router component={EditMain} path={`${PortletConstants.urls.basePath}/main/:portletMainId(\\d+)/:action([a-zA-Z]+)`} />
<Router component={EditMain} path={`${PortletConstants.urls.basePath}/main/:portletMainId(\\d+)/edit/:model([a-zA-Z]+)`} />
<Router component={EditMain} path={`${PortletConstants.urls.basePath}/main/:portletMainId(\\d+)/edit/:model([a-zA-Z]+)/:action([a-zA-Z]+)`} />
<Router component={EditMain} path={`${PortletConstants.urls.basePath}/main/:portletMainId(\\d+)/edit/:model([a-zA-Z]+)/:entryId(\\d+)`} />
<Router component={EditMain} path={`${PortletConstants.urls.basePath}/main/:portletMainId(\\d+)/edit/:model([a-zA-Z]+)/:entryId(\\d+)/:action([a-zA-Z]+)`} />
<Router component={Index} path={this._defaultRoute} />

Agreed, this would be a really nice feature.

Just an update on this, I have a branch with this working, just waiting on #25 to get merged first.


admin page

What am I trying to do..
When I go http://myshop.com:3545/admin
..What's happening
show 'not found'

@boardgame1 Check if your .htaccess file is correct

I running on windows.
Is there additional setting?

@boardgame1
No, if you use Apache and yours .htaccess file is loaded , application must work fine

Hi, I am facing this similar issue. My .htaccess file is working fine but "http://localhost/SHOP/admin" gives 404

@singhalpiyush12  If you want to use the platform in subdirectory eg. "/SHOP", you must remove "RewriteBase /" line from .htaccess file.


fix: datagrid title

Contributes to #3184
addresses accessibility concerns in Datagrid by adding a title prop for the table component and adding titles to the table headers.

@matthewgallo thanks for pointing that out. fixes made. i believe my new approach addresses your concerns

just kidding. got it working locally before i pulled the latest and something broke

i'm going to close this and start a new PR based on the new code that matt has written to address this problem in https://github.com/carbon-design-system/ibm-products/pull/3344


Support for Alamofire 4.0 / Swift 3.0 / Xcode 8.0

It seems there is a lot of work to be done to make this compatible with the above dependency versions. I've gotten pretty far but the main blocker is the response serialization as the Alamofire project went a different direction with it.
Is there any progress made in this regard so far?

For sure we will update the wrapper at some point. Unfortunately I cannot give you any schedule because we currently do not have direct need for this.
If you need Swift 3 compatibility now please update the wrapper on your own. PRs are very welcome.

This is now a blocking issue as XCode 8.3 does not support swift before 3 anymore.

I created a fork compatibility for Swift 3+/Xcode 8+:
https://github.com/Enriquecm/cloudconvert-swift
I tested only the pdf conversion. Feel free to try the other features.
As soon as possible I will make a PR for this repository.

I'm having trouble getting that branch to compile. Getting Swift Compiler Errors in the AlamoFire 3.5.1 package.

I think I got it to work with Alamofire 4.0:
https://github.com/jasonboggess/cloudconvert-swift

Hi @jasonboggess , The trouble to compile is about the current CloudConvert version or my fork?

Your fork. I updated my podfile to point to your repo and the workspace wouldn't compile.

Hi @jasonboggess , I think you got the wrong branch or the wrong commit.
If you still need it, or some other developer needs this update.
Put the code below into your Podfile:
pod 'CloudConvert' , :git => 'https://github.com/Enriquecm/cloudconvert-swift.git', :commit => '5ca42909c585b274fd5caefe4be6d2c0a8e00ee0'

See See https://github.com/cloudconvert/cloudconvert-swift/pull/7


Train on a different dataset

Hello, @sacmehta!
I'm trying to train a neural network on my own database which consists of 5 classes.
To train the encoder, I use the command:
CUDA_VISIBLE_DEVICES=1 python3 main.py --data_dir=./DataBase --inWidth=480 --inHeight=360 --classes=5 --cached_data_file=data.p --batch_size=10
To train the decoder, I use the command:
CUDA_VISIBLE_DEVICES=1 python3 main.py --data_dir=./DataBase --inWidth=480 --inHeight=360 --classes=5 --cached_data_file=data.p --batch_size=5 --decoder=True --pretrained=./results_enc__enc_2_8_long/model_161.pth --scaleIn=1 --savedir=./results_dec_
After completing the training, I start testing the neural network:
CUDA_VISIBLE_DEVICES=1 python3 VisualizeResults.py --modelType=1 --inWidth=480 --inHeight=360 --scaleIn=1 --weightsDir=../pretrained/decoder/ --classes=5 --cityFormat=False
In the decoder folder are the weights (new) of the trained neural network (espnet_p_2_q_8.pth).
As a result, I get the following error:
RuntimeError: Error(s) in loading state_dict for ESPNet: 	While copying the parameter named "conv.conv.weight", whose dimensions in the model are torch.Size([5, 21, 3, 3]) and whose dimensions in the checkpoint are torch.Size([5, 24, 3, 3]).
How can I fix this error?

Hi,
The model files in test folder is slightly different from the one in train folder. That is why you are getting the error. Just replace the Model.py in the test folder with the one you used for training, and it should work.
A side note:
Since you are using 5 classes, ESP block might not be very effective in the decoder because it projects the feature maps into low-dimensional space which is equal to number of classes. To learn more better representations, you can follow this issue where we provided a work around to work on dataset with few classes.
https://github.com/sacmehta/ESPNet/issues/13


[TST] Debug flaky property tests

[WIP][IGNORE]

#3149  👈 (View in Graphite)
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

No more flaky tests that can be reliably reproduced


Function to run a top-level future on the thread-pool

I'm not sure how much sense this makes without a way to import the main thread into working for the thread pool (maybe that's possible?), but for consistency it would be nice to be able to use juliex from the top-level down, instead of the current example of using futures::executor::block_on to run the top-level future.
I tried using a basic utility function for this which just blocks the main thread waiting for the future to finish:
pub fn run<F>(future: F) -> F::Output
where
    F: Future + Send + 'static,
    F::Output: Send + 'static,
{
    let (tx, rx) = std::sync::mpsc::channel();
    juliex::spawn(async move {
        let result = await!(future);
        tx.send(result).unwrap();
    });
    rx.recv().unwrap()
}

@Nemo157 that's not a terrible idea tbh; the runtime-raw::enter function does something very similar. In theory we could move some things around so juliex implements a version of this, and runtime-raw's traits expect one of these to be implemented.
I reckon that would open us up for some performance improvements too later down the line, as the channel logic currently isn't great.

Maybe I haven't understood entirely how to use juliex, but I feel like there is a bigger problem here. The futures library has 2 convenient methods, at least on the LocalPool:

run -> block until all spawned futures have finished
run_until -> run until the topmost future has finished, ignoring other spawned tasks

This gives a level of control that juliex doesn't have:
fn main()
{
	use
	{
		async_runtime :: { *                                          } ,
		std           :: { time::{ Duration, Instant }, thread::sleep } ,
	};

	let program = async
	{
		let start = Instant::now();

		for i in 0..8
		{
			juliex::spawn( async move
			{
				sleep( Duration::SECOND );
				println!( "Time elapsed at task {} end: {} second(s).", i, start.elapsed().as_secs() );

			}).expect( "spawn task" );
		}
	};

	// futures::executor::block_on( program );
	run( program );

	// The program won't stay alive by itself
	//
	// sleep( Duration::SECOND * 2 );
}

In the example above, it doesn't matter if I use the run method suggested above or block_on. I suppose currently the most reasonable way to do this is to join all those futures, but if they would spawn more futures, all the way down there have to be synchronization mechanisms like channels to make sure the program doesn't exit prematurely...
Just had a look at the docs, it seems that for futures::executor::ThreadPool the run method corresponds to the run_until method of LocalPool. A tad bit inconsistent. I couldn't find a way to run the futures::executor::ThreadPool until all tasks are finished.

This is the most concise I have found so far (given that none of these tasks spawns any further):
use
{
	std           :: { time::{ Duration, Instant }, thread::sleep } ,
	futures       :: { future::{ FutureExt, join_all }            } ,
};

let program = async
{
	let start = Instant::now();
	let mut tasks = Vec::new();

	for i in 0..8
	{
		let (fut, handle) = async move
		{
			sleep( Duration::SECOND );

			println!( "Time elapsed at task {} end: {} second(s).", i, start.elapsed().as_secs() );

		}.remote_handle();

		rt::spawn( fut ).expect( "spawn task" );
		tasks.push( handle );
	}

	join_all( tasks ).await;
};

futures::executor::block_on( program );

@Nemo157 Trying to understand your original post, why do you want to run the future on a different thread if you block the current thread anyway? Is it about juliex API having a method like block_on so people don't have to import futures::executor::block_on?

Is it about juliex API having a method like block_on so people don't have to import futures::executor::block_on?

Yes, it feels weird to run different futures on different executors for no reason.

I suppose currently the most reasonable way to do this is to join all those futures, but if they would spawn more futures, all the way down there have to be synchronization mechanisms like channels to make sure the program doesn't exit prematurely...

Personally I feel this is appropriate, the application should be concerned with which futures are ones it needs to wait on and which it should cancel if the main ones all complete. This can even be done transparently by passing around Spawn wrappers that register the spawned futures into collections instead of just spawning directly onto the executor.
Luckily where I was using Juliex I didn't have to worry about all that as the appropriate semantics if the top-level future exited was to just cancel all the spawned futures anyway.

Thinking about the Spawn wrappers idea a little more I wonder if it would be better to have an API like
pub fn run<F, Fut>(create: F) -> Fut::Output
where
    Fut: Future + Send + 'static,
    Fut::Output: Send + 'static,
    F: FnOnce(&juliex::Handle) -> Fut,

so that the top-level future can take in a Spawn instance to pass around.


Move tfplan* files to .terraform folder

What's new:

Move tfplan* files to $ENV_DIR/.terraform folder

 Create output.txt and other non-important files in .terraform dir

 Safely remove output.json generation from ICMK


unpublished change is not in the published package

It looks like the version published on npm differs from the current documentation on the master branch, therefore the new functionality to support multiline prop groups which has already been merged to master it's not yet available when installing from npm. Cutting a new release should fix this issue.
PR of the added feature
Live Documentation on the master branch

That's because in every repository on github since its inception, the master/default branch doesn't necessarily match what's published.
If you want to check the docs for a published version, look at its tag: https://github.com/yannickcr/eslint-plugin-react/tree/v7.28.0/docs/rules
and if you check the PR you linked, you can see that it's not present in any release tag.
Additionally, if you check the changelog on master, you can see it's in the "unreleased" section. https://github.com/yannickcr/eslint-plugin-react/blob/master/CHANGELOG.md#unreleased
A merged but unreleased change isn't an "issue" and can't be "fixed". When we're ready to cut a release, we will, and until then, all of this stuff is SUPPOSED to be unreleased.

Thanks for explaining me that and pointing me to the correct reference of the docs. I've wrongly assumed that the master branch would reflect the latest version on npm, and the changelog.md to be exactly the same as the GitHub Releases but it turns out that the "unreleased" section it's only shown in the changelog.md file and as release and deploy are different things I was trying to use a feature that has developed but not been made available on npm yet.
Sorry for raising an invalid issue, I'll make sure to look at the docs in the tag that corresponds to the correct version on npm from now on.


feat(pie): support specifying coordinate system for pie series.

Brief Information
This pull request is in the type of:

[ ] bug fixing
[x] new feature
[ ] others

What does this PR do?

Add coordinate system support for pie series.
BMap extension supports convertToPixel & convertFromPixel API.

Fixed issues

#13851
plainheart/echarts-extension-amap#38

Details
Before: What was the problem?
It's not convenient and not direct to display the pie series on Geo/BMap/AMap/Calendar coordinate system.
After: How is it fixed in this PR?
Add a new option coordinateSystem for pie series.
Preview

Misc

[x] The API has been changed (apache/echarts-doc#xxx).
[ ] This PR depends on ZRender changes (ecomfe/zrender#xxx).

Related test cases or examples to use the new APIs
Please refer to test/pie-coordinate-system.html
Others
Merging options

[ ] Please squash the commits into a single one when merging.

Other information

@Ovilia @pissang Is this feature planned in v5.3.3 or v5.4?

This feature deserved to be introduced as an important feature in the 5.4 article. But I also can't wait to have it in our next version. @plainheart I think I will leave this decision to you:)

I had planned to release a new version of the amap extension for this feature in response to some developers' feedback. But it sounds better to introduce this feature in v5.4 so that the developer can know about it in time. I'm okay to leave it in v5.4. :D


validation AP fluctuation and validation loss curve increasing

Hello, I am training a custom dataset with YOLOX-nano model. I did not change the nano training parameters except the number of classes which is 1 for my dataset.  The Validation AP 0.50:0.95 looks like this:

Is it normal to see these fluctuations?
The other issue is calculating validation loss to see if it is overfitting. Is anyone try to log validation loss? I modified the code a bit to calculate validation loss. But somehow it looks weird. It fluctuates a lot  and it has an increasing trend.

And this is total training loss by the way:

What is going wrong? Does anyone have any idea to fix this?
Thanks.

Did you solve it?


[DONTMERGE] Will travis fail now?

See #776

Well it didn't fail only for the reasons I wanted. I'll continue on this tomorrow.

It worked actually:
Ran 470 tests in 35.960s
FAILED (errors=3)
ERROR: InvocationError: '/home/travis/build/spotify/luigi/.tox/nonhdfs/bin/python test/runtests.py -v'
___________________________________ summary ____________________________________
ERROR:   nonhdfs: commands failed
The command "tox -e $TOX_ENV" exited with 1.

@berkerpeksag It fails, but it's because other tests doesn't find server_test module https://travis-ci.org/spotify/luigi/jobs/51862320#L726. #782 actually fails for the right reason, there is a test that doesn't pass https://travis-ci.org/spotify/luigi/jobs/51936777#L753.

Closing in favor of https://github.com/spotify/luigi/pull/782


Detected as Virus

When installed the portable version:
Trojan:Win32/Wacatac.B!ml
On the 32-bit exe
i know its a false positive but still
:)

Unfortunately, there's nothing that can be done about this. Invisiwind does dll-injection into processes that it does not own, which is probably why it is detected as a virus.

In fact, it does everything you might expect a virus to do:

Virus-like command prompt window ✔
Enumerate all processes and inject code into a process it does not own ✔
Extracted from shady looking .zip file from the interwebz ✔
Forcibly hides a window (makes it seems like the program has something to hide? 😉) ✔


Make query expressions visible in Type object

io.requery.meta.Type internally contains a Set<QueryExpression<?>> expressions, which is however not exposed publicly.
Could you please make it visible through a getter on the type interface?

Hi what's the motivation for supporting this?

Hi.
I am writing some code that generically builds queries on the data model.
That code basically takes as input:

the class of the entity to query
the names of the attributes to select.
If an attribute name is dotted, It implies a 'navigation' into a related entity, which implies a SQL join.
To be able to specify the join condition, I must use the QueryExpression corresponding to the foreign key. That's why I need them exposed.
Do you have otherwise an alternative approach to specifying the join condition?


Place to put compatibility test recommendations.

Buildcraft
Natura
Ore shrubs

totemic and binnie's mods (Forestry addon)

IndustrialWires-1.6-24
immersivepetroleum-1.12.2-1.1.7
ImmersiveCables-1.12.2-<IP_ADDRESS>

You do know you can just go on the wiki and add them to the list right away, right? Like everyone else has been doing.

Wasn't aware that was possible.

@Velken @border999
Do any of you know how do I make Custom Cubic as a world-gen in my server.properties?
I mean, what's its name? (For ex, know how in order to generate Biomes O' Plenty world gen you have to write BIOMESOP in the server)

world type CustomCubic instead Default is server config.

Why is this still open if marked invalid?

no clue


feat(fab): Initial Implementation

#4469

@Garbee did another pass on the styles. PTAL

Codpen of the current state as well. Shadow update is already TODO'ed in the variable file, so I'm not going to duplicate the comment again.
With the typography stuff, let's also hold off just a bit until after the next sprint when we have the theme base done, as the typography should end up being more theme-bound then typography-bound. Unless we are now saying typography will be a big inter-linked dependency (which in this case would be a pretty needless one overall.)
I just need to add a README and this should be good for another pass.

FABs are still missing box shadows:
Resting/default shadow (6dp):
box-shadow: 0px 3px 5px -1px rgba(0, 0, 0, 0.2),
              0px 6px 10px 0px rgba(0, 0, 0, 0.14),
              0px 1px 18px 0px rgba(0, 0, 0, 0.12);

Active shadow (12dp):
 box-shadow: 0px 7px 8px -4px rgba(0, 0, 0, 0.2),
              0px 12px 17px 2px rgba(0, 0, 0, 0.14),
              0px 5px 22px 4px rgba(0, 0, 0, 0.12);

Just pushed the updated code and the codepen is updated with its output.
Removed the ::before psueudo element and just made it all work on ::after. Not sure why we were using both when only one is required.

@Garbee you want to shift that back to ::before given #4628 ?

Waiting on that PR to land before updating this one, that way we are good on the direction. Yea, should have removed the PTAL tag.

LGTM other than the nits @traviskaufman and I pointed out. Thanks, @Garbee!


Missing py.typed

This project does not ship with a py.typed file in the distribution, resulting in mypy not being able to locate the type annotations for the pep621 module.

Uh, I think I need to convert the module to a package to be able to do that.

Alternatively, we could install a .pyi file.

#10 is going to make me rename the module, so I am gonna take that opportunity to make the module a package, so that we can add a py.typed file.


Morph v0.25.0 v0.30.0

Summary
This PR adds morph migration files for v0.25.0-v0.30.0. Minor refactoring: moved helper functions to the utils file.
Ticket Link
https://mattermost.atlassian.net/browse/MM-47954
Checklist

- [ ] Telemetry updated
- [ ] Gated by experimental feature flag

[x] Unit tests updated

do we expect to run all morph migrations at least once over in-use databases?
No, I plan to run only new migrations. Morph stores the list of migrations that have been run in the IR_db_migrations table and doesn't rerun them. So, before running the first morph migration, I'll check the current legacy migration version and, based on that information, write corresponding morph migrations versions in the IR_db_migrations table.

No, I plan to run only new migrations. Morph stores the list of migrations that have been run in the IR_db_migrations table and doesn't rerun them. So, before running the first morph migration, I'll check the current legacy migration version and, based on that information, write corresponding morph migrations versions in the IR_db_migrations table.

So we could say that the last migration in the old(current) migration system will be to set the right status into the morph migrations data. is that what you have in mind?
Thanks for explaining.

So we could say that the last migration in the old(current) migration system will be to set the right status into the morph migrations data. is that what you have in mind?
Yes, that's correct.


Added a good joke

Short description of what this resolves:
It adds a new joke
Changes proposed in this pull request:
Adds an extra item in jokes.json

Fixes: #

Thank you for taking the time to contribute! This is sincerely appreciated. 😇
(Powered by GitMate.io)


Migrate Plum URIs to Figgy equivalents

Adds a data migration to migrate all Plum URIs to Figgy equivalents, and updates Canvas short ids and urls to use a slug based on label rather than using the new UUIDs in Plum for public user-facing site urls.

Codecov Report

Merging #173 into develop will decrease coverage by 0.83%.
The diff coverage is 39.28%.

@@             Coverage Diff             @@
##           develop     #173      +/-   ##
===========================================
- Coverage     95.3%   94.47%   -0.84%
===========================================
  Files           85       86       +1
  Lines         3747     3798      +51
===========================================
+ Hits          3571     3588      +17
- Misses         176      210      +34

Impacted Files
Coverage Δ

derrida/books/urls.py
100% <ø> (ø)
:arrow_up:

...ns/0008_instance_work_year_copy_unique_together.py
100% <100%> (ø)
:arrow_up:

...ida/books/migrations/0009_migrate_plum_to_figgy.py
31.25% <31.25%> (ø)

...ida/books/management/commands/import_digitaleds.py
83.87% <66.66%> (-0.88%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c888cd4...a4a7281. Read the comment docs.

@bwhicks I hear you on the error handling, but it's also a one-time migration so I don't know how much effort we should put into it.  What do you think about adding a check and printing out a warning if there are any plum urls in manifests, canvases, or interventions?
I added a deploy note about the need for a new auth token; I think it's ok if the migration fails if we don't have one configured.

@rlskoeser I agree re: not putting in much effort. Printing a warning would be just fine I think, if even that's necessar. I'm pretty sure that the output of the migration will be eaten by the Ansible deploy anyway (though for a one off delicate migration I could turn that degree of logging on).
Agreed on not wasting much time on it.


Update System Administrator control section for Office 2016

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

outlook/Concepts/Getting-Started/support-for-keeping-add-ins-enabled.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

#hold-off while I check one more thing with the devs

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

outlook/Concepts/Getting-Started/support-for-keeping-add-ins-enabled.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


feat(validation) ValidationRules.customRule message parameter take a function, eliminate third parameter

I would like to propose that the ValidationRules.customRule message parameter take a function, just like the rule evaluation does (or function|string).  Then eliminate the awkward final parameter and the config object.
Instead of this:
ValidationRules.customRule(
  'integerRange',
  (value, obj, min, max) => ... ,
  `\${$displayName} must be an integer between \${$config.min} and \${$config.max}.`,
  (min, max) => ({ min, max })
);

Rather this:
ValidationRules.customRule(
  'integerRange',
  (value, obj, min, max) => ... ,
  `(value, obj, min, max) => { `\${$displayName} must be an integer between \${min} and \${max}.`,
);

Or this:
ValidationRules.customRule(
  'integerRange',
  (value, obj, min ) =>{
        evaluator:  () => { return value >= min },
        message: `\${$displayName} must be an integer between \${min} and \${max}.`
    });

@dkent600 how would this work?

@jdanyow  Before I spend time trying to answer your question, can you tell me whether you are aware of any particular challenge to it?

Just looking for more info on how you think this should be implemented. It wasn't clear to me from looking at the pseudo code you provided how this would be achieved.
Here's some info on how it works today:
customRule takes four args:

name of the rule
function to evaluate the rule
message template
function that takes the rule's custom parameters and produces a config object that can be accessed in the message template.

When you use a custom rule via the fluent API the function to create the config object (#4) is evaluated to capture the rules configuration.
When a validation error is discovered the message template is used in conjunction with the captured configuration, object, display name, property and some other stuff to produce the message.

OK, thanks!
I presented two options:
A)  replace args 3) and 4) with a single arg which would be a function that returns the message template.  The function would take the same arguments as in 2).  Optionally this new arg could also be provided as a string.
B)  replace args 2) 3) and 4), with a single arg that would be a function that returns an object like this:
(value, obj, min ) =>{
        evaluator:  () => { return ....  value >= min },
        message: `The value for \${$displayName} must be at least ${min}.`
    });

If I may, I'm having trouble creating a custom rule that exposes a dynamic error message. I'm probably doing this wrong, but I'm trying to make a rule that takes a function and outputs a boolean that indicates whether it is valid or not. If an error occurs, that error is the validation message. (It's actually a service call, but that doesn't really matter.)
Right now, I have to do this to get it somewhat working, but as you can see it's not ideal:
ValidationRules.
	customRule("serviceCall",
		(value: any, object: any, serviceCallResult: ServiceCallDelegate, propertyName?: string) => {
			// Remove the previously generated error or we just keep adding new ones.
			if (this.previousServiceCallError) {
				this.validationController.removeError(this.previousServiceCallError);
				this.previousServiceCallError = null;
			}

			// Don't validate stuff that is not yours to validate.
			if (value === null || value === undefined) {
				return Promise.resolve(true);
			}

			// Perform the call and result in true or false to indicate validity. If something went wrong, add the error as a validation error.
			return serviceCallResult(value, object).
				then(x => x).
				catch(x => this.previousServiceCallError = this.validationController.addError(x.message, object, propertyName)).
				then(x => false);
		},
		// The custom rule doesn't have a predefined validation error. Passing 'null' here crashes it on some indexOf call it tries to do, presumably to check if it needs to replace parameters in the error message.
		"");

It seems to me that option B by @dkent600 comes close to supporting this scenario as well. If the evaluation of the rule could somehow return the error message, it would be much more dynamic. And if you always want to return the same message with variable parameters, you could simply return a constant string every time.
This might go against the concept of single rule evaluation, since you could use a single custom rule to validate everything you'd need to and return a different error message for every failed evaluation...

@Beijerinc I'm not sure 100% sure that this would work in javascript, but if so, it might be the way to make option B work for your case:
(value, obj, min ) =>{
        errorCode: any,
        evaluator:  () => {
            let isValid:boolean = [...];
            this.errorCode = [...];
            return isValid;
        },
        message: `\${$displayName} is not valid: ${this.errorCode}.`
    });

A feature to add or are we good to close this? @jdanyow

@dkent600 it's still not clear to me how these would work. I do agree the ValidationRules.customRule API is a little awkward and would like to improve it if there's an idea that will work within the constraints we have.
If I understand your suggestion correctly, this change would force people do define a new custom rule for every min/max value they need to validate.
When thinking about how to refactor this, make sure the .satisfiesRule('integerRange', 1, 100) side of things is also considered.

@jdanyow No problem.
This is what I like the best (in typescript), I hope it is more clear:
Suppose you declare customRule and ICustomRuleConfig as follows:
static customRule(name: string, config: (value: any, obj?: Object, ...constraints: any[]) => ICustomRuleConfig): void;

interface ICustomRuleConfig {
    evaluator: () => boolean;
    message?: () => string;
}

then call it as follows:
ValidationRules.customRule(
            'min',
            (value, obj, min) => {
                return {
                    evaluator: (): boolean => {
                        return value !== null && value !== undefined && value >= min;
                    },
                    message: (): string => {
                        return `The value for \${$displayName} must be at least ${min}.`;
                    }
                }
            });

A cleaner alternative, that would eliminate the ICustomRuleConfig  config object:
static customRule(name: string,
    evaluator: (value: any, obj?: Object, ...constraints: any[]) => boolean,
    message: (value: any, obj?: Object, ...constraints: any[]) => string): void;

ValidationRules.customRule(
            'min',
            evaluator: (value, obj, min) => {
                        return value !== null && value !== undefined && value >= min;
                    },
             message: (value, obj, min) => {
                        return `The value for \${$displayName} must be at least ${min}.`;
                    }
            });

I see what you mean now- I don't really like the mixed escaping of the interpolation expressions in the message that this kind of change would introduce.

I personally don't like the escaped bit at all.  Ideally I would want to find a way to eliminate it.
How about something like this:
ValidationRules.customRule(
            'min',
            evaluator: (value, obj, min) => {
                        return value !== null && value !== undefined && value >= min;
                    },
            message: (value, obj, context, min) => {
                        return `The value for ${context.displayName} must be at least ${min}.`;
                    }
            });

@jdanyow I leave this decision up to you. However, if you take @dkent600's idea, I think the parameters should be in the same order if possible. If that's not possible, then lets make sure to have clear documentation on how/why it's that way.

The other approaches involve more closures and do not significantly improve the clarity of the API (this is subjective of course, just my opinion here :smile:). Closing this because v1 has shipped and I don't want to introduce a big breaking change like this for a while.


feat: fire up test chains by first block: bitcoin#22818, dip1, dip8, dip20, brr - 3/n

Issue being fixed or feature implemented
What was done?
Backport bitcoin#22818 which helped to activate all forks from block-1 at regtest.
Activate next dash's softforks at block 1:

DIP-0001 (blocksize 2mb)
DIP-0020 (opcodes)
DIP-0008 (chainlocks)
BRR (block reward reallocation)

How Has This Been Tested?
Breaking Changes
All changes are relevant to RegTest only
Checklist:

[x] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have added or updated relevant unit/integration/functional/e2e tests
[ ] I have made corresponding changes to the documentation
[x] I have assigned this pull request to a milestone

@UdjinM6 , I would disagree with both patches.
https://github.com/dashpay/dash/commit/55aa14e7bfd69e3d15137ec0c912e38dad0c930a:
There are both values bad-txns-oversize and tx-size used in our (and bitcoin's) implementation.
bad-txns-oversize: https://github.com/dashpay/dash/blob/develop/src/consensus/tx_check.cpp#L34
tx-size: https://github.com/dashpay/dash/blob/develop/src/policy/policy.cpp#L73
I'd say inside ContextualCheckTransaction just has been used a wrong id for failure - let's correct it better rather than wrap it

https://github.com/dashpay/dash/commit/fde8ed17777eec038b41b13633bd804a94cb6360
That remove existing command line argument, I'd like to keep it for v21.2 just in case if anyone uses it.
I am going to create a new PR with removing bip147, dip3param, dip8param, etc when v22 will be branched-out.

@UdjinM6 , I would disagree with both patches.
55aa14e:
There are both values bad-txns-oversize and tx-size used in our (and bitcoin's) implementation.
bad-txns-oversize: https://github.com/dashpay/dash/blob/develop/src/consensus/tx_check.cpp#L34 tx-size: https://github.com/dashpay/dash/blob/develop/src/policy/policy.cpp#L73
I'd say inside ContextualCheckTransaction just has been used a wrong id for failure - let's correct it better rather than wrap it in numerous of exceptions to make it disappear in just particular 2 tests

bad-txns-oversize is a consensus level error and tx-size is a mempool policy error, the one you are changing is consensus level one, it was picked intentionally that way.

fde8ed1
That remove existing command line argument, I'd like to keep it for v21.2 just in case if anyone uses it. I am going to create a new PR with removing bip147, dip3param, dip8param, etc when v22 will be branched-out.

Sounds good

bad-txns-oversize is a consensus level error and tx-size is a mempool policy error, the one you are changing is consensus level one, it was picked intentionally that way.

Indeed, it makes sense.
Please check my force-push: I applied your changes and also dropped a global flag fDIP0001ActiveAtTip which is no need anymore


Ads Bug

When I play a YouTube video and then click the pause while loading an ads., but when the ads. is loaded successfully to display, the the video auto play. What should I do?

This library is uses YouTube IFrame player library. So if there is an issue, it is probably there.


synchronous mode

when I run the simulator in synchronous mode, it does not show any actor in the view(world) or I have a graphical problem but I could see that the simulation is running (through cmd), however, nothing is shown in the map.
Did anyone confront with the same problem before? or how can I fix it?
Thanks a lot

Is there a client that "ticks", meaning calls world.tick() regularly? What's your setup exactly? Why do you assume that an actor should be shown in (which?) view?

Is there a client that "ticks", meaning calls world.tick() regularly? What's your setup exactly? Why do you assume that an actor should be shown in (which?) view?

Thanks for message,
Why I assume that an actor should be shown? ...by actor I meant vehicles and I could not see results of spawn_actor() in the scene. However, when it is not in synchronous mode it spawns them. and I do not set anything for client tick

@kimiya66,
Did you manage to resolve this issue? I am having same problem.

Hello,
When you work in asynchronous mode the server updates as fast as it can. This, in exchange, may produce bounces in the fps as some situations may be resolved faster than others. Basically it works as common games.
Synchronous mode, however, is meant specially for simulation where we need consistency in timesteps, so what the server does is wait for the client to announce that it is ready, and then performs all the operations given (for example spawn_actor() ) taking as long as it needs, knowing that the simulation time is fixed (in 10 fps, it would mean 0.1 secs each calculation cycle).
Due to this behaviour it needs the client to call world.tick() in order to announce that "he has finished". I hope this was clear and useful to you.


feat: add ArtifactHub Verified Publisher

Signed-off-by: Engin Diri<EMAIL_ADDRESS>Summary
Hi @cpanato, @hectorj2f   and @sabre1041,
I would just need the id from the ArtifactHub Control panel to add to the artifacthub-repo.yml file. Its not a secret, so you could comment it into the PR or contact me in private. Or merge and added on your own. :)
See https://artifacthub.io/docs/topics/repositories/#verified-publisher for details.
Ticket Link

Fixes #20

PS: @sabre1041: you will see the verified tag only on the next update of the chart. Been there too, waiting for ages 😅


Proper Horse, Mule, Donkey and Llama structure.

The current Horse api expansion (in the 1.11 branch) is done in a way that allows it to backwards compatible. But with the introduction of the Llama's, I don't really the like the structure that the api ends up with: Llama extends Horse, and this doesn't make a lot of sense in the way that Llama's aren't even a part of the horse family. So I propose the following structure changes:

@gabizou

Llama's aren't even a part of the horse family

They are in minecraftia.

@Cybermaxke the goal of the API has never been to say what should be versus what is. If Minecraft's base engine is dictating that Llamas are extensions of Horses, then so be it. This is what we had to decide on a year and a half ago with regards to our entity hierarchy structures diverging from the vanilla base game.

This is amazing.
Can we pin this issue?
It has a flowchart.
I like flowcharts.

@gabizou There can always be an additional interface which represents the Horses, Donkeys, Mules and Llamas. Naming the base class Horse seems like a bad idea and may lead to confusion.

@Cybermaxke This is a design decision that has been made multiple times, and will not be reversed.
If you have a problem with hierarchies, go complain to Mojang.

Naming the base class Horse seems like a bad idea and may lead to confusion.

There's a very good reason to keep it named Horse: Backwards compatibility and exact representation of the underlying structure. As I said before closing the issue, this was a decision made in the past that isn't going to be changed.