Error with sending .zip file with send_file

Hi,
I want to create a dummy .zip file and send the response with the function send_file.
    memory_file = BytesIO()
    with zipfile.ZipFile(memory_file, 'w') as zf:
        zipinfo = zipfile.ZipInfo("test")
        zipinfo.date_time = time.localtime(time.time())[:6]
        zipinfo.compress_type = zipfile.ZIP_DEFLATED
        zf.writestr(zipinfo, "this is test zip content")
    memory_file.seek(0)
    return send_file(memory_file, attachment_filename='capsule.zip', as_attachment=True)

To see if the .zip file is processed and sent correctly I send the GET request via my browser.
The .zip file is sent, i download it but when I want to see the archive of the .zip I cannot because the .zip file is corrupted.
I updated the line 41 in the init.py file
    self.base64_content_types = set(base64_content_types or ["application/zip"]) or set()

I also tried doing the same thing without using AWSGI (using only python FlaskRESTful) and i had no issues.
Could you help me resolving this issue
Thanks

Hi, @Kurtuozan. I haven't investigated this yet, but I wanted to check: are you setting a Content-Type: application/zip header in your response?

Hi @slank,
No I didn't put the header Content-Type: application/zip.
I tried it now:
    memory_file = BytesIO()
    with zipfile.ZipFile(memory_file, 'w') as zf:
        zipinfo = zipfile.ZipInfo("test")
        zipinfo.date_time = time.localtime(time.time())[:6]
        zipinfo.compress_type = zipfile.ZIP_DEFLATED
        zf.writestr(zipinfo, "this is test zip content")
    memory_file.seek(0)
    return {
        'headers': {'Content-Type: application/zip'},
        'body': send_file(memory_file, attachment_filename='capsule.zip', as_attachment=True)
    }

When I send the request via my browser now I don't get the automatic download or any download.
I get this line in my browser eyJtZXNzYWdlIjogIkludGVybmFsIFNlcnZlc.
When I go look into the developer tools inside the tab i called the request i can see that Response Header of the response is:
Content-Length: 37
Content-Type: application/json
Date: Thu, 26 Sep 2019 07:24:26 GMT
Server: Werkzeug/0.15.5 Python/3.7.4
I just want to add that when i don't put the header content type and i call it like this
return  send_file(memory_file, attachment_filename='capsule.zip', as_attachment=True)
I get the corrupted .zip file

Hi, @Kurtuozan. When I base64 decode that value (eyJtZXNzYWdlIjogIkludGVybmFsIFNlcnZlc), I get what appears to be an error message: {"message": "Internal Serve
I think your original method was correct; no need to set the content type. What are you doing with the response you get from the server? Could the "corrupt" zip data actually be base64 encoded?

Hi, @slank
So the situation is that when I download the corrupted dummy.zip and I go into the terminal and run the command :
cat dummy.zip
I get a very long base64 encoded string. And when i decode that string and write it in a new file in linux: that file becomes not corrupted and I can extract the initial file that i wanted.
How can I overcome this issue so I don't have to decode it after i download the dummy.zip
Thank you for your help :)

Right. That makes sense. I apologize that I only have questions and not answers, but I'm hoping I can lead you in the right direction sooner than I could investigate myself.
I see that there is a transfer-encoding header we maybe should be setting.
https://www.w3.org/Protocols/rfc1341/5_Content-Transfer-Encoding.html
I think it's probably needed in AWSGI but I'm not super confident. Have you tried this with Flask locally, without AWSGI?

@Kurtuozan OK, so a colleague pointed me at this page about configuring content type handling in APIGW.
https://docs.aws.amazon.com/apigateway/latest/developerguide/api-gateway-payload-encodings.html
Are you using awsgi with APIGW or with ALB? Hopefully the former, and hopefully that link helps.

Hi @slank !
After debugging the issue, we managed to resolve it  by adding in the template.yaml under Globals/Api/BinaryMediaTypes this line   - application~1zip
We wanted to thank you for your fast responses and your time. You helped us narrowing the scope of possible solutions.
Thanks from my Team!

Glad I could help, and glad you figured it out!


setNewRoutePath called multiple times when setting URL manually in browser

Can be seen when using listener

This does not happen anymore


UNOR4: rebuild libfsp with I2C patch

Fixes nasty bug when calling Wire.requestFrom(x, 3) and the first byte of the response was > 0x80

At least now it matches the comment... :cold_sweat:


Applying custom map styles?

Hi! I just found this repo and am implementing it in a project I'm working on. Runs very smooth, thanks for this!
However, I want to apply my own map style to the map, and I fail to see how/where I can do that. Any ideas on how/if that can be done?
Also, where do I put other props for the map/markers, like icon for marker, assigning an info window to it and opening it on click etc? I noticed there seems to be a component called InfoWindow, but I couldn't find any documentation about it.
Thanks in advance, and thanks for the great repo!

@zth do you refer to stuff like this?
Custom map style:
http://git.io/vTkmW
Marker and InfoWindow
https://tomchentw.github.io/react-google-maps/#events/event-closure

@zth You can apply all google.map options as props to a <GoogleMap />. For example:
<GoogleMap mapStyles={/* YOUR MAP STYLES*/} />

Not mapStyles but styles.

Close this due to inactivity. Thanks @JanKantyPawelski  to point that out.

For me adding styles as a prop didn't work. I had to add the styles to the defaultOptions prop as one can see in this example.
https://github.com/tomchentw/react-google-maps/blob/master/src/app/pages/basics/StyledMapExample.js
It is also possible to add the custom styles to the options prop as options.styles.

you can find this on here its really useful and easy to use
https://github.com/tomchentw/react-google-maps/blob/master/src/app/constants/fancyMapStyles.json

If one of you can update your links that would make my night :D

New example:
https://tomchentw.github.io/react-google-maps/#!/InfoBox
Please read the  documentation site first!

How can i add custom style on the GoogleMap
import {withGoogleMap, GoogleMap, Marker, Polyline} from "react-google-maps";
<GoogleMap
mapStyles=[style object]
is not working

@anusree-mmlab
const exampleMapStyles = [] //Add some style
<GoogleMap
    defaultOptions={{ styles: exampleMapStyles }}
    >

Example here
Check fancy map styles here

Hey I am not sure if I actually ever got this working, because I know right
now I just have a greyscale filter. But Here is what my component
looks like[image:
Inline image 1]
where styles is [image: Inline image 2]
You can find/ create different mapstyle.json on Google map developer site.
Good luck!
On Tue, Nov 14, 2017 at 1:54 AM, Win Sandy Myint<EMAIL_ADDRESS>wrote:

@anusree-mmlab https://github.com/anusree-mmlab
const exampleMapStyles = [] //Add some style
<GoogleMap
defaultOptions={{ styles: exampleMapStyles }}
>
Example here https://tomchentw.github.io/react-google-maps/#!/InfoBox
Check fancy map styles here https://snazzymaps.com/
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/tomchentw/react-google-maps/issues/53#issuecomment-344174297,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AT-vXIBmM0k1Hc5tzZ9H0jiQw6noiOwNks5s2UdQgaJpZM4EclFw
.

@winsandymyint you did it! love you ❤

It is possible using the following way:
const exampleMapStyles = [{
		featureType: "water",
		elementType: "labels.text.fill",
		stylers: [
			{
				color: "#9e9e9e",
			},
		],
	}] //Add some style
<GoogleMap
    options={{ styles: exampleMapStyles }}
    >

I can confirm @anusree-mmlab method worked for me.
Just put your JSON style into a JS file as so:
export const MyStyle = [ YOUR STYLES HERE]
Then, in your map component:
import { MyStyle } from './MyStyle';

// other stuff

<GoogleMap ref={props.onMapMounted}
        defaultOptions={{ styles: MyStyle }}
        defaultZoom={8}
        defaultCenter={{ lat: -34.397, lng: 150.644 }} />

Little late to the party but nothing I do seems to quite work. I gave up on having ...
Style data as JSON (from snazzy maps) and placed within a exported variable named "greyMap" and saved the file as mapStyles.js
I then imported it into a component the GoogleMaps component is in import { greyMap } from "./mapStyles"
With my GoogleMaps component looking like
<GoogleMap 			id="map" 			zoom={9} 			center={hasLocation ? currentLocation : center} 			onLoad={(map) => setMapRef(map)} 			styles={greyMap} 		>
I tried defaultOptions={{ style: greyMap }} and got the same results. Not sure what I'm doing wrong!

@coderdix The repo of this project is unmaintained more than a year, and we had build new version https://www.npmjs.com/package/@react-google-maps/api
We had rewrite it to TypeScript, and updating it frequently: https://github.com/JustFly1984/react-google-maps-api/tree/master/packages/react-google-maps-api
You can enjoy autocomplete.
You can see our docs: https://react-google-maps-api-docs.netlify.app
Also a lot of examples: https://react-google-maps-api-gatsby-demo.netlify.app/ https://github.com/JustFly1984/react-google-maps-api/tree/master/packages/react-google-maps-api-gatsby-example/src/examples
The bundle size is much smaller: https://bundlephobia.com/result?p=@react-google-maps/api
Our Spectrum community: https://spectrum.chat/react-google-maps
Our Slack channel: https://join.slack.com/t/react-google-maps-api/shared_invite/enQtODc5ODU1NTY5MzQ4LTBiNTYzZmY1YmVjYzJhZThkMGU0YzUwZjJkNGJmYjk4YjQyYjZhMDk2YThlZGEzNDc0M2RhNjBmMWE4ZTJiMjQ
Enjoy!

I'm using that one I keep searching when I have an issue and posting on the wrong forum lol

my map keeps overflowing

my map keeps overflowing

Can you provide an screenshoot? And also the code you used in the example for us to be able to reproduce it...

my map keeps overflowing

Add position property as relative in mapContainerStyle props it will not overflow


ADD KALAAM first hindi programming language

दिखाए("Hello World")

Kalaam is the programming language in Hindi and has all the basic functionalities of a modern programming language. From for loops to while loops and from functions to conditional statements.
Anyone with a smartphone or a computer can start coding in Kalaam.

Kalaam is the programming language in Hindi and has all the basic functionalities of a modern programming language. From for loops to while loops and from functions to conditional statements.
Anyone with a smartphone or a computer can start coding in Kalaam.


lssue

I have a very strange idea, whether it is possible to implement header injection
Such as
sec-ch-ua-platform: "macOS"

The victim was carrying the header we injected throughout the visit


AppendToSequence: improve handling of scalar values

Ready for review @sambsnyd

Thanks for the fix @sullis !


.Net Framework compatibility

Hi, I have a question/need for some general knowledge surrounding coverlets compatibility with .NET Framework.
I'm receiving an error when attempting to generate code coverage for a test project that references Microsoft.ReportViewer.WebForms. The error is occurring because coverlet is looking in the .NET Core sdk folder for the necessary dll, and it's not there. The assembly is present elsewhere. Please see the warning below. This precedes the build failure.
Do you have any recommendations for a graceful way to point coverlet towards non .NET Core referenced assemblies?
C:\Program Files\dotnet\sdk\2.2.107\Microsoft.CSharp.CurrentVersion.targets(134,9): warning MSB3884: Could not find rule set file "AllRules.ruleset". [C:\source\SSDirectoryLibrary44\SSDirectoryLibrary44.csproj] C:\Program Files\dotnet\sdk\2.2.107\Microsoft.Common.CurrentVersion.targets(2110,5): warning MSB3245: Could not resolve this reference. Could not locate the assembly "Microsoft.ReportViewer.WebForms, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a, processorArchitecture=MSIL". Check to make sure the assembly exists on disk. If this reference is required by your code, you may get compilation errors.
Working in .NET 4.6.1
Xunit 2.4.1
coverlet 2.6.3

could be a dup can you try with https://github.com/tonerdo/coverlet/issues/72#issuecomment-399445565?

No luck with that unfortunately. The reference to ReportViewer is about 3 levels down and the assembly is in the gac.. Realizing this is probably more of a dotnet build question(?) Running a dotnet build with more verbosity to hopefully get something more to work with.

Can you provide a simple repro that generates that issue?I'd like to go deep on this issue and understand well the issue and maybe provide a solution.

I can try - I'll follow up on this in a bit!

Are you using this package? https://www.nuget.org/packages/Microsoft.ReportViewer.WebForms/

Using an older version - 9.0.21022.227
It's a 2008 Redistributable version of Report Viewer, found here: https://www.microsoft.com/en-us/download/details.aspx?id=577
In our solution we run our tests through visual studio using xunit.runner.visualstudio.2.4.1
We do not currently collect test coverage stats in any form..
Working on a repro now!

Hi @MarcoRossignoli please check out my sample repro here: https://github.com/eal61/framework_reportviewer_repro

Sure I'll check asap and let you know!

Ok try this...tell to msbuild to move asm on target folder

And after
D:\git\coverletissue\framework_reportviewer_repro (master -> origin)
λ dotnet test /p:CollectCoverage=true /p:Exclude=\"[Microsoft*]*,[xunit*]*\" /p:CoverletOutputFormat=cobertura
Esecuzione dei test per D:\git\coverletissue\framework_reportviewer_repro\A.Test\bin\Debug\A.Test.dll(.NETFramework,Version=v4.6.1)
Strumento da riga di comando per l'esecuzione di test Microsoft (R) Versione 16.3.0-preview-20190715-02
Copyright (c) Microsoft Corporation. Tutti i diritti sono riservati.

Avvio dell'esecuzione dei test in corso. Attendere...

L'esecuzione dei test è riuscita.
Totale test: 1
     Superati: 1
 Tempo totale: 1,8401 Secondi

Calculating coverage result...
  Generating report 'D:\git\coverletissue\framework_reportviewer_repro\A.Test\coverage.cobertura.xml'

+--------+------+--------+--------+
| Module | Line | Branch | Method |
+--------+------+--------+--------+
| A      | 100% | 100%   | 100%   |
+--------+------+--------+--------+
| B      | 0%   | 100%   | 0%     |
+--------+------+--------+--------+
| C      | 0%   | 100%   | 0%     |
+--------+------+--------+--------+

+---------+--------------------+---------------------+--------+
|         | Line               | Branch              | Method |
+---------+--------------------+---------------------+--------+
| Total   | 25%                | 100%                | 14,28% |
+---------+--------------------+---------------------+--------+
| Average | 8,333333333333334% | 33,333333333333336% | 4,76%  |
+---------+--------------------+---------------------+--------+

We need to filter out Microsoft.ReportViewer.WebForms.dll and xunit lib to avoid noise in warning(we skip to instrument dll with no local pdb).

You can also run coverlet as tool if you want e use every runner you need take a look to https://github.com/tonerdo/coverlet/issues/513#issuecomment-521180471

@eal61 news?

Your suggestion above fixes my build when I run dotnet build. When I run the dotnet test command it appears that the build finishes, but then code coverage isn't collected. Nothing is happening and when I cancel the process I get an error stemming from InstrumentationTask, similar to #340
Not sure why this is happening, especially since it seems that that issue should be resolved at this point

For context, here is the sequence of errors I'm getting. I'm not able to reproduce in the repro I attached earlier..
Build started, please wait... Build completed.
there is a long pause between these outputs, and then I attempt to kill the process
 Attempting to cancel the build... Attempting to cancel the build... Attempting to cancel the build... Attempting to cancel the build... Attempting to cancel the build... Attempting to cancel the build... Attempting to cancel the build... Attempting to cancel the build... Attempting to cancel the build... Attempting to cancel the build... Attempting to cancel the build... Attempting to cancel the build... ^C ..\packages\coverlet.msbuild.2.6.3\build\coverlet.msbuild.targets(24,5): warning MSB4220: Waiting for the currently executing task "Coverlet.MSbuild.Tasks.InstrumentationTask" to cancel. [C:\source\Tests\Tests.csproj]

When I run the dotnet test command it appears that the build finishes, but then code coverage isn't collected.

Weir...I need to repro to understand what's happening...or you could try to enable logging https://github.com/tonerdo/coverlet/blob/master/Documentation/Troubleshooting.md#msbuild-integration

I can try to enable logging

I deleted the bin folder in my test project and re-ran the dotnet test command. All tests were run successfully, but the coverage report is empty. Ran with logging enabled and I'm looking at the binlog now

Do you have any recommendations on what to look for in the msbuild.binlog file? looking at the [coverlet] tagged messages but nothing is jumping out at me

Mmm [coverlet] it's ok...if file is empty and log doesn't report nothing about coverlet seem like no instrumentation at all happened...can you try to share command line and project structure?

currently using the suggested command from the troubleshooting page. opencover.coverage.xml is 1KB and it just reports zeroes across the board.
dotnet --info:
.NET Core SDK (reflecting any global.json):
Version:   2.2.107
Commit:    2212cac826
Runtime Environment:
OS Name:     Windows
OS Version:  10.0.17134
OS Platform: Windows
RID:         win10-x64
Base Path:   C:\Program Files\dotnet\sdk\2.2.107\
Host (useful for support):
Version: 2.2.5
Commit:  0a3c9209c0
.NET Core SDKs installed:
2.1.101 [C:\Program Files\dotnet\sdk]
2.1.202 [C:\Program Files\dotnet\sdk]
2.1.503 [C:\Program Files\dotnet\sdk]
2.1.507 [C:\Program Files\dotnet\sdk]
2.2.107 [C:\Program Files\dotnet\sdk]
.NET Core runtimes installed:
Microsoft.AspNetCore.All 2.1.7 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.All]
Microsoft.AspNetCore.All 2.1.11 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.All]
Microsoft.AspNetCore.All 2.2.5 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.All]
Microsoft.AspNetCore.App 2.1.7 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
Microsoft.AspNetCore.App 2.1.11 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
Microsoft.AspNetCore.App 2.2.5 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
Microsoft.NETCore.App 2.0.6 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
Microsoft.NETCore.App 2.0.9 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
Microsoft.NETCore.App 2.1.7 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
Microsoft.NETCore.App 2.1.11 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
Microsoft.NETCore.App 2.2.5 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
To install additional .NET Core runtimes or SDKs:
https://aka.ms/dotnet-download
command line:
dotnet test C:\source\Console.Tests\Console.Tests.csproj  -c debug /p:CollectCoverage=true /p:CoverletOutputFormat=opencover /p:Include=[coverlet.] /p:Exclude="[Microsoft*],[xunit]*" -verbosity:diagnostic -bl:msbuild.binlog -noconsolelogger`
output following:
`C:\Program Files\dotnet\sdk\2.2.107\MSBuild.dll -noconsolelogger -nologo -bl:msbuild.binlog -distributedlogger:Microsoft.DotNet.Tools.MSBuild.MSBuildLogger,C:\Program Files\dotnet\sdk\2.2.107\dotnet.dllMicrosoft.DotNet.Tools.MSBuild.MSBuildForwardingLogger,C:\Program Files\dotnet\sdk\2.2.107\dotnet.dll -maxcpucount -nodereuse:false -property:Configuration=debug /p:CollectCoverage=true /p:CoverletOutputFormat=opencover /p:IncludeTestAssembly=true /p:Include=[coverlet.]* /p:Exclude=[Microsoft*],[xunit]* -restore -target:VSTest -verbosity:m -verbosity:quiet -verbosity:diagnostic C:\source\xfit\NetHealth.Console.Tests\NetHealth.Console.Tests.csproj
Build started, please wait...
Build completed.
Test run for C:\source\Console.Tests\bin\Debug\Console.Tests.dll(.NETFramework,Version=v4.6.1)
Microsoft (R) Test Execution Command Line Tool Version 15.9.0
Copyright (c) Microsoft Corporation.  All rights reserved.
Starting test execution, please wait...
Total tests: 7. Passed: 7. Failed: 0. Skipped: 0.
Test Run Successful.
Test execution time: 4.2788 Seconds
Calculating coverage result...
Generating report 'C:\source\Console.Tests\coverage.opencover.xml'
+--------+------+--------+--------+
| Module | Line | Branch | Method |
+--------+------+--------+--------+
+---------+------+--------+--------+
|         | Line | Branch | Method |
+---------+------+--------+--------+
| Total   | 100% | 100%   | 100%   |
+---------+------+--------+--------+
| Average | ∞%   | ∞%     | ∞%     |
+---------+------+--------+--------+

tried with /p:IncludeTestAssembly=true as well (suggested in #516 ) and got the same output

It's hard understand without a repro 😞 you can reach me on gitter chat and we can try with remote support if you want.

@eal61 any news?

dotnet test C:\source\Console.Tests\Console.Tests.csproj -c debug /p:CollectCoverage=true /p:CoverletOutputFormat=opencover /p:Include=[coverlet.] /p:Exclude="[Microsoft*],[xunit]*" -verbosity:diagnostic -bl:msbuild.binlog -noconsolelogger`

@eal61 why  /p:Include=[coverlet.] you don't have to instrument coverlet lib...can you try to remove and also upgrate to version 2.7.0 if you're using older one?

Close for stale conversation, feel free to re-open if needed.


[Bug]: can't download db backup

Description
I set up an S3 storage, and then a postgres database, and scheduled backups. Works great.
Minimal Reproduction (if possible, example repository)
If I try to download a backup by clicking the "download" button, I get a warning about deleting it.
So it looks like the download button is hooked up to delete.
Exception or Error
No response
Version
230

is this fixed for you in v232? Download works for me.

Yes it's working in 234.


Issues in dataset_create.py

Hi,
Recently I download your script and it works (Training set includes ['coat', 'kaftan', 'robe']).
But when I add ['Chino'] in the training set, and run dataset_create.py, it will meet a problem.
It will stop at a certain image and display an error.

I will meet the same problem if I add ['Jeans'] to the training set.

It seems some certain images will cause this issue.
I don't know if I should do some changes to the ‘crop function’. I think I need your help.
Thanks a lot!

I am having the same issue, for img_0000009.jpg inside Faux_leather-Trim_Blouse folder. And I am guessing its resolution is very smaller compared to other images in the folder.

I think so.
So I wonder how to modify the 'crop function'?

The issue is, selective_search is recommending boxes with 0 widths/height. To fix it just add the following code to selective_search.py and it should fix the issue.


Add fastdebug builds

Sometimes you need a debug build of the JDK, and currently the only way that I know of to get one of those, is to build it yourself. On some platforms, however, it can be quite an ordeal to get OpenJDK to build.
The AdoptOpenJDK has already done all the leg work to make the JDK build on the various platforms, and offer the binaries for download. It would be very helpful if another build with ./configure --enable-debug could be added to the list of builds.

@chrisvest I have just created one and added to the Jenkins dashboard - https://ci.adoptopenjdk.net/job/openjdk_debug_build_x86-64_linux/1/console, let me know if you are happy with this, I checked the ./configure command, summary of the help, only the below show debug related options:
  --enable-debug          set the debug level to fastdebug (shorthand for --with-debug-level=fastdebug) [disabled]
  --disable-debug-symbols disable generation of debug symbols [enabled]
  --disable-zip-debug-info
                          disable zipping of debug-info files [enabled]
  --with-debug-level      set the debug level (release, fastdebug, slowdebug)
  --debug-configure       Run the configure script with additional debug

--enable-debug is disabled instead we can use --with-debug-level=fastdebug

Hi @neomatrix369
Can you kick off a MacOS build? It's easier for me to check those artefacts. :)

@chrisvest there is usually a higher fee for MacOS builds, usually higher license costs, you might need to sort it out with @gdams  or @tellison ;) :p

Here's the MacOSX build - https://ci.adoptopenjdk.net/job/openjdk_debug_build_x86-64_macosx/1/console, please test out the binary to let us know if its what works for you as far as fastdebug binaries go.

@neomatrix369 Thanks, the binaries from that build are exactly what I needed.

@chrisvest cool stuff, even before we saw $$$ or £££ or Euros changing hands ;) Good one, could you please write a post of gather some info on fastdebug, how it works, what it is for? What do binaries with fastdebug contain and link back to us, these very rarely used types of binaries are not known to all and would be nice to spread awareness.

I'll close this issue for now if you please, once you have also shared some knowledge with us - maybe post it on the wiki if you don't mind.

Sure, will do.

If any one of you are at JCrete we might see some beer or watermelon change hands ;)

Watermelon sounds interesting, one way change right? Thanks for the gesture. Looking forward to the knowledge share.

I'm going to backlog this for now as we'd like to provide fast debug builds via the website as alternatives.
CC @Joe-Brady Have a think about how you might want to display this in both the UI and the API...

@karianna @neomatrix369 were these builds decomissioned? Can't find debug builds listed on https://ci.adoptopenjdk.net/ anymore.. This would be really nice to have.

@jakewins They were never commissioned.  It's something we need to add to the farm if we have enough spare capacity.  Is there a particular O/S and version of Java that you're after?

Well, there's another repo that hosts debug builds for Windows and the ones on Linux are easy to build locally, so the main target would be OS X. Versions are JDK8 & JDK9.

We're working with a major cloud provider for Windows hosts, stay tuned!

@karianna @neomatrix369 I see the build with debug symbols for linux (https://github.com/AdoptOpenJDK/openjdk-build/issues/146#issuecomment-314512338) has been removed. Any way to get it back? It's nice to build it at home but not very practical I find…

We're going to produce these as separate builds yes, not 100% sure of timeframe yet though.

@karianna thanks for the feedback! You can count me in as a potential user ;)

Looking for Pull Requests on this one for it to happen quickly.

Are there instructions anywhere on how to produce your own debug build? There's no root configure script any more in 2.0.0, if there ever was.

Just to summarise this issue, it's currently possible to create a fastdebug build at home but the concern right now is that we don't have the spare capacity to produce fastdebug builds as part of the pipelines.
Even if we do, we are currently awaiting PR's allow fastdebug builds as part of the pipelines. Is that accurate?

Just to summarise this issue, it's currently possible to create a fastdebug build at home but the concern right now is that we don't have the spare capacity to produce fastdebug builds as part of the pipelines.
Even if we do, we are currently awaiting PR's allow fastdebug builds as part of the pipelines. Is that accurate?

I believe that is correct, although some fastdebug builds are being produced for Eclipse OpenJ9 (@gdams will surface those to the website, they're available in the API)

@karianna @chrisvest  Hi, is there any available debug-version Openjdk for MAC？It seems most of link is invalid. thx

@karianna @chrisvest Hi, is there any available debug-version Openjdk for MAC？It seems most of link is invalid. thx

There currently isn't.  We'd need to enable the flags and do a bunch of testing.

FTR the OpenJDK build system has changed since Java 8 (I think this happened as part of Java 9, but not sure) so it’s pretty easy to make your own build if you want something more recent like Java 11.

@karianna I'm a little bit puzzled about the status.
In case a PR would be opened to enable fastdebug builds for hotspot windows variant would it most likely be merged or is something else blocking to enable these builds?

@karianna I'm a little bit puzzled about the status.
In case a PR would be opened to enable fastdebug builds for hotspot windows variant would it most likely be merged or is something else blocking to enable these builds?

A pull request would be most welcome :-)

If we're looking to produce regular fastdebug builds, and the primary barrier is that we don't have enough spare machine time to do it, is there any support for cancelling the normal builds on Saturdays and running fastdebug build generation then?
I say that on the assumption that most of us are primarily Monday-Friday, and while Sunday builds/tests can be triaged on Monday morning, Saturday builds/tests can be safely sacrificed (at least on the platforms we want fastdebug builds for).

@adamfarley I don't think the statement about machine shortage is still true. Even if it was, our (lack of) capacity isn't uniform across platforms. We have plenty of x64, aarch64 machines which are the platforms with the highest download numbers. So I'd rather enable daily builds, but not on all platforms.

I intend to turn on 'weekly' tests on one of the weekend builds, as part of https://github.com/AdoptOpenJDK/openjdk-build/issues/2189 and as they have not been running but did get triggered as part of the release (which runs nightly + weekly test lists).

So, to clarify and summarize the above points, once the re-release is through, we need a PR that creates fast-debug build jobs that are:

Hotspot-only
JDK Head, 15, 11, and 8.
On platforms:

MacOS X (Weekly)
Windows x86-64 (Weekly)
Linux x86-64 (Daily)

Does this sound correct, and do we want to link these builds on the website as a follow-on task?

We probably need these new builds to follow some sort of formalized framework, so we know we're always getting the information we need to make an informed decision.
Here's an issue to cover the creation of that framework: https://github.com/AdoptOpenJDK/TSC/issues/191

To add one use case for this to the pile, as far as I know, such a debug build would be needed to make use of
https://github.com/AdoptOpenJDK/jitwatch more easily.


⚠ Fortnite has degraded performance

In 8c47d25, Fortnite (https://fortnite.com) experienced degraded performance:

HTTP code: 200
Response time: 1494 ms

Resolved: Fortnite performance has improved in 6144402.


Android build failure

$ cmake -S . -B build \

-D CMAKE_TOOLCHAIN_FILE=$ANDROID_NDK_HOME/build/cmake/android.toolchain.cmake
-D ANDROID_PLATFORM=26
-D CMAKE_ANDROID_ARCH_ABI=arm64-v8a
-D CMAKE_ANDROID_STL_TYPE=c++_static
-D ANDROID_USE_LEGACY_TOOLCHAIN_FILE=NO
-D CMAKE_BUILD_TYPE=Release
-D UPDATE_DEPS=ON
-G Ninja
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working C compiler: D:/Users/Vector/AppData/Local/ndk/21.3.6528147/toolchains/llvm/prebuilt/windows-x86_64/bin/clang.exe - skipped
-- Detecting C compile features
-- Detecting C compile features - done
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: D:/Users/Vector/AppData/Local/ndk/21.3.6528147/toolchains/llvm/prebuilt/windows-x86_64/bin/clang++.exe - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
Starting builds in D:\Personal\Projects\LunarG_repo\vulkanTools\external\Android\Release\armv7-a
Installed Vulkan-Headers (v1.3.280) in 0.6241400241851807 seconds
Installed volk (vulkan-sdk-1.3.280) in 1.1439473628997803 seconds
-- Found Git: D:/Program Files/Git/mingw64/bin/git.exe (found version "2.32.0.windows.2")
-- Configuring done (13.6s)
CMake Error at cube/CMakeLists.txt:229 (target_link_libraries):
Target "vkcube" links to:

Vulkan::Headers

but the target was not found.  Possible reasons include:
* There is a typo in the target name.
* A find_package call is missing for an IMPORTED target.
* An ALIAS target is missing.

CMake Error at vulkaninfo/CMakeLists.txt:109 (target_link_libraries):
Target "vulkaninfo" links to:
Vulkan::Headers

but the target was not found.  Possible reasons include:
* There is a typo in the target name.
* A find_package call is missing for an IMPORTED target.
* An ALIAS target is missing.

-- Generating done (0.0s)
CMake Generate step failed.  Build files cannot be regenerated correctly.

Can you post the CMakeCache.txt, and any relevant CMake logs?
I can see that Vulkan-Headers was installed locally, but it seems that Vulkan-Tools was not made aware of it.
I assume the build is trying to use the clang compiler but I just want to confirm that.

Found 3 cmake cache files:
CMakeCache.txt
CMakeCache (1).txt
CMakeCache (2).txt

Arm 7 vs 8 also caught my attention.
.txt to make github happy.
android.toolchain.cmake.txt

So excuse my ignorance, but do you need to use a specific ndk with each android platform? I see that its using the 21.3.xxx ndk while the ANDROID_PLATFORM is 26.

I am very new to this android environment. Not sure how I ended up with three.

I'm not much better, and all of my android experience is on linux so I cannot rule out weirdness due to Windows.

25.2.9519653 is probably related to Khronos Samples.

Re-run the build using $ANDROID_NDK_HOME set to D:\Users\Vector\AppData\Local\ndk\26.2.11394342. Same error.

Closing this issue as I cannot reproduce the build error reported here. I've tested the Android build instructions on both Windows and Linux, using both the listed CMake command as well as the android.py helper script and everything worked as expected.


README update

update README to include information on what is generated, including a diagram of the folder structure

uploading directory image for new readme.


How to add a checkbox in the header like this

$dataTableFactory->create()
->add('selection', TextColumn::class, ['label' => '
<input type="checkbox" name="selectAll" id="selectAll">
'])

Raw markup is not supported in non-content fields, use Javascript to find and decorate the headers instead.

Thanks for your reply, I've done this in javascript and it's ok

👍


[SPARK-18025] Use commit protocol API in structured streaming

What changes were proposed in this pull request?
This patch adds a new commit protocol implementation ManifestFileCommitProtocol that follows the existing streaming flow, and uses it in FileStreamSink to consolidate the write path in structured streaming with the batch mode write path.
This deletes a lot of code, and would make it trivial to support other functionalities that are currently available in batch but not in streaming, including all file formats and bucketing.
How was this patch tested?
Should be covered by existing tests.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/67872/
Test FAILed.

Test build #3387 has started for PR 15710 at commit e9823e7.

Test build #67873 has started for PR 15710 at commit e9823e7.

Test build #67874 has started for PR 15710 at commit 1c906c9.

cc @ericl, @marmbrus, @zsxwing and @lw-lin (I guess this would supersede your old PR).

Test build #3387 has finished for PR 15710 at commit e9823e7.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Test build #67873 has finished for PR 15710 at commit e9823e7.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/67873/
Test FAILed.

Test build #67874 has finished for PR 15710 at commit 1c906c9.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/67874/
Test FAILed.

Test build #67877 has started for PR 15710 at commit 1c3a645.

Test build #67877 has finished for PR 15710 at commit 1c3a645.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/67877/
Test FAILed.

Test build #67912 has started for PR 15710 at commit 0742318.

Test build #67913 has started for PR 15710 at commit a2ea180.

Test build #67913 has finished for PR 15710 at commit a2ea180.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test build #67912 has finished for PR 15710 at commit 0742318.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/67913/
Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/67912/
Test PASSed.

Merged build finished. Test PASSed.

LGTM

Thanks, merging to master.


Kernel dies every time when I start training the model

Hi Shiva,
Thank you very much for a such clean and neat wrapper for training ML models. I am using t5(precisely t5-small) as the base to train my model for summarization. I use the dataset using datasets from huggingface. However, everytime when I initiate the training code, the kernel dies and restarts. Any help here is much appreciated!
Following is my code.
Import dependencies
%%capture
!pip install --user simplet5==0.1.4
!pip install transformers
!pip install wandb
!pip install pandas
!pip install datasets
!pip install --user simpletransformers

Load data using datasets from huggingface
import pandas as pd
import warnings
warnings.filterwarnings("ignore")
from datasets import load_dataset
dataset = load_dataset("scitldr")

Preparing the train and eval data
train_df = dataset["train"].to_pandas().copy()
train_df.drop(columns=["source_labels","rouge_scores","paper_id"],inplace=True)
train_df.rename(columns={"source":"source_text","target":"target_text"}, inplace=True)
train_df.count() ## No NaN found - zero 1992 dataset

train_df['source_text'] = train_df['source_text'].astype('str').str.rstrip(']\'')
train_df['source_text'] = train_df['source_text'].astype('str').str.lstrip('[\'')
train_df['target_text'] = train_df['target_text'].astype('str').str.rstrip(']\'')
train_df['target_text'] = train_df['target_text'].astype('str').str.lstrip('[\'')

train_df["source_text"]=train_df["source_text"].str.replace('\'','')
train_df["target_text"]=train_df["target_text"].str.replace('\'','')
train_df["source_text"]="summarize: "+train_df["source_text"]
train_df.to_csv("train.csv")

eval_df = dataset["validation"].to_pandas().copy()
eval_df.drop(columns=["source_labels","rouge_scores","paper_id"],inplace=True)
eval_df.rename(columns={"source":"source_text","target":"target_text"}, inplace=True)
eval_df.count() ## No NaN found - zero 1992 dataset

eval_df['source_text'] = eval_df['source_text'].astype('str').str.rstrip(']\'')
eval_df['source_text'] = eval_df['source_text'].astype('str').str.lstrip('[\'')
eval_df['target_text'] = eval_df['target_text'].astype('str').str.rstrip(']\'')
eval_df['target_text'] = eval_df['target_text'].astype('str').str.lstrip('[\'')

eval_df["source_text"]=train_df["source_text"].str.replace('\'','')
eval_df["target_text"]=train_df["target_text"].str.replace('\'','')
eval_df["source_text"]="summarize: "+train_df["source_text"]
eval_df.to_csv("eval.csv")

Loading simpleT5 and wandb_logger and finally loading the model and training code
from simplet5 import SimpleT5
from pytorch_lightning.loggers import WandbLogger
wandb_logger = WandbLogger(project="ask-poc-logger")
model = SimpleT5()
model.from_pretrained("t5","t5-small")
model.train(train_df=train_df[0:100],
            eval_df=eval_df[0:100],
            source_max_token_len = 512,
            target_max_token_len = 100,
            batch_size = 2,
            max_epochs = 3,
            use_gpu = True,
            outputdir = "outputs",
            logger = wandb_logger
            )

I am running this code on the following machine. A vertex AI workbench from Google Cloud.
N1-Standard-16 machine type  with 16 core and 60 GB Memory.  And added GPU P100.
Any help is much appreciated ! Thanks in advance!

[Fixed]
Debugged a bit and found that the pytorch version had some conflict on my Vertex AI managed notebook (pre-built containers with pytorch and transformers already installed). Created a custom container and also tried the code in user managed notebook and is working fine. Closing the issue.


SI: Adding test and recovery samples and changing vac samples to one entry

Hm, weird errors. As if it was not possible to get files from GitHub.

@jozemlakar due to a change in how the EHNs JSON schema URL works, the check for your PR currently fails. Could you update your branch to the latest main to incorporate the updated and working schema URL (specifically, the test script with said updated url)? Then we can see if there are any actual issues left.
Thanks!

@daniel-eder we have merged the main and that fixed the URL error. However now we have a problem with sc field (too large of precision in sc field). Will have to wait on Monday.

Failure is due to https://github.com/DIGGSweden/dgc-java/issues/66

@daniel-eder @SchulzeStTSI Why is a fine grained time a problem? It is unnecessary, yes, but still. By washing away these odd cases from the test files you actually give validators less data to parse. In my meaning, this shouldn't be an error.

@martin-lindstrom while I would agree, there is also the issue of validation apps that are failing on this. So if we say, we allow fine grained time, then we are also braking verifier apps. One of those "we are right, but at what price" things.

@martin-lindstrom while I would agree, there is also the issue of validation apps that are failing on this. So if we say, we allow fine grained time, then we are also braking verifier apps. One of those "we are right, but at what price" things.

One could argue that those validator apps should be interested in fixing the problem on their side instead of attempting to get all issuers to limit what is created...

@daniel-eder @SchulzeStTSI About date-time...
From the specification:
The date and time when the test sample was collected. The time MUST include information on the time zone. The value MUST NOT denote the time when the test result was produced.
Exactly 1 (one) non-empty field MUST be provided.
One of the following ISO 8601 formats MUST be used. Other options are not supported.
YYYY-MM-DDThh:mm:ssZ
YYYY-MM-DDThh:mm:ss[+-]hh
YYYY-MM-DDThh:mm:ss[+-]hhmm
YYYY-MM-DDThh:mm:ss[+-]hh:mm

Examples:
"sc": "2021-08-20T10:03:12Z"	(UTC time)
"sc": "2021-08-20T12:03:12+02"	(CEST time)
"sc": "2021-08-20T12:03:12+0200"	(CEST time)
"sc": "2021-08-20T12:03:12+02:00"	(CEST time)

I heard from @jozemlakar that you expect fractions and don't accept the above? Is that correct? If so, the test scripts need to be updated.

@daniel-eder @SchulzeStTSI @martin-lindstrom this is base on failed checks when I submitted samples without fractions. Checks failed because expected value was
'sc', '2021-06-07T16:51:35.000000Z'
our value was
'sc', '2021-06-07T16:51:35Z'


Create cmake configuration

Created initial cmake project
What was done

Separate in individual and independent libraries
Addded FreeRTOS as a library
Added googletests as a library (only on native builds, windows is not supported)
Added STM32 CMSIS as a library, will probably eventually be removed, only used for the provided linker script for now
Added STM32 HAL as a library
Provide a make flash command

What was not done because I have encountered problems

Add warnings
Treat warnings as errors, warning from external libs would throw errors. Would need to enable only on the project code
Compile googletests for arm, it only compiles natively for now, idk if it would really be usefull though

The next step

Debug on the device
Add CI
Add automatic code checks with LGTM

Cmake references used
https://cliutils.gitlab.io/modern-cmake/
https://github.com/ObKo/stm32-cmake
https://rix0r.nl/blog/2015/08/13/cmake-guide/

Everything seems to build. I was able to run the provided tests and run the program on native Ubuntu. Great job :+1:

Managed to build everything through WSL as well as CLion in Windows using WSL


Update Rabbitmq version to 3.12

Updated rabbitmq version to 3.12-management in tests for modules:

pixl imaging
cli
core
system

Needed to export DOCKER_DEFAULT_PLATFORM=linux/arm64 for it to work on Mac M1

Happy for you to emrge once you've resovled the conflicts


Improve WHERE clause code generation

@pereman2 points out few obvious WHERE clause code generation improvements we can make:
https://github.com/penberg/limbo/pull/121#pullrequestreview-2173136565

@Feilkin @jussisaurio FYI


[QUESTION] Safari support

Question
Hello, I was looking through everywhere but couldn't find any reason why Safari isn't supported browser for Dashy. I would love to use it, but since our devices are mainly from apple ecosystem, we are using Safari a lot. I would like to know why if possible. Thank you.
Category
Development
Please tick the boxes

[X] You are using a supported version of Dashy (check the first two digits of the version number)
[X] You've checked that this question hasn't already been raised
[X] You've checked the docs and troubleshooting guide
[X] You agree to the code of conduct

I don't experience any issues running on safari

I have only issues with the minimalist style of the UI:

and some small issues with the default UI, but I was just curious more than anything. Also when clicking on a phone (on iphone and on safari) I am always opening contextual menu for editing, which can be turned off in settings, so it's not that big of a deal either, it's just those small little things :)

Yeah, so Safari has a few weird quirks, but nothing which can't be fixed. To be honest, the main reason it's not officially supported, is because I don't have an Apple device I can test it on. But if you can send me screenshots of any bugs, I should be able to fix them just by sight.
Is that one in the screenshot the only issue you've come across, or is there more?

Yeah, so Safari has a few weird quirks, but nothing which can't be fixed. To be honest, the main reason it's not officially supported, is because I don't have an Apple device I can test it on. But if you can send me screenshots of any bugs, I should be able to fix them just by sight.
Is that one in the screenshot the only issue you've come across, or is there more?

I fully understand that, thank you for your answer. It is one of the worst problems I encountered, but not the only one for sure. I found quite a few while setting it up, but didn't take notes which is actually my bad. I will need to give it a look again. I would definitely took notes if I knew you would be willing to have a look at those, just wasn't sure since it's not even listed as supported browser and I know you have other stuff to fix and do for the supported browsers. Though I remember few of them:
There is a problem with the logo (if the user uploads one in settings). I was able to fix it with custom CSS by setting it a fixed height, otherwise it would look like this:

Next issue I noticed is that if I use custom CSS option in settings (the one that is used locally to browser, not globally) it doesn't actually work and messes some other stuff on the page. The only way to fix this is by removing local storage for that specific webpage, which reverts all the CSS changes with it.
Another stuff from what I recall is the issue with widgets on safari - or at least with few of them, in my case with glances. I checked on google chrome on my second device that I use, and it was correct there, so this has to be yet again because of safari. The percentage value for the current CPU and memory usage is not in the middle - which is causing the value to be almost invisible, depending on the color of the section and theme, in my case yellow. The value is put into the graph instead of the middle. This can be also simply fixed by the custom CSS, which I didn't have chance to do so yet.

Lastly, what I already mentioned in the previous reply here, while using the Safari app on my iPhone, while navigating and scrolling through the website UI or while opening links, I mostly always open the built-in contextual menu to edit stuff. I am not sure if this is intended or not since I don't have other device to try it out, and yes, we do have option to turn this contextual menu off like I mentioned as well, but what I personally would love to be able to is to disable it only on phones (since it can be pretty useful on desktop), or perhaps change how the right click is registered on the phones if somehow possible, since on smartphone we don't have option of difference between left / right click like on desktop, but just touch.
And now to deviate a bit from the main topic, I would also love to have some status of the rebuilding happening after making changes to the configuration from the UI. Often after making changes I am not sure if my changes were wrong or if it's cache, or if it's still rebuilding and without looking directly in logs it's a bit problematic to find out.
Otherwise, to not only make this look like I am searching for every possible bug or error in design etc. I am very happy altogether with Dashy, since it looks really classy, simple and minimalistic, works fast and is really one of a kind. One of the best home-fronts for my server I ever had. Changed from Organizr and I am happy I finally did, since it's much better looking and quick in my opinion.

@Lissy93 Think this is still relevant

Yeah, so Safari has a few weird quirks, but nothing which can't be fixed. To be honest, the main reason it's not officially supported, is because I don't have an Apple device I can test it on. But if you can send me screenshots of any bugs, I should be able to fix them just by sight.
Is that one in the screenshot the only issue you've come across, or is there more?

I fully understand that, thank you for your answer. It is one of the worst problems I encountered, but not the only one for sure. I found quite a few while setting it up, but didn't take notes which is actually my bad. I will need to give it a look again. I would definitely took notes if I knew you would be willing to have a look at those, just wasn't sure since it's not even listed as supported browser and I know you have other stuff to fix and do for the supported browsers. Though I remember few of them:
There is a problem with the logo (if the user uploads one in settings). I was able to fix it with custom CSS by setting it a fixed height, otherwise it would look like this:

Next issue I noticed is that if I use custom CSS option in settings (the one that is used locally to browser, not globally) it doesn't actually work and messes some other stuff on the page. The only way to fix this is by removing local storage for that specific webpage, which reverts all the CSS changes with it.
Another stuff from what I recall is the issue with widgets on safari - or at least with few of them, in my case with glances. I checked on google chrome on my second device that I use, and it was correct there, so this has to be yet again because of safari. The percentage value for the current CPU and memory usage is not in the middle - which is causing the value to be almost invisible, depending on the color of the section and theme, in my case yellow. The value is put into the graph instead of the middle. This can be also simply fixed by the custom CSS, which I didn't have chance to do so yet.

Lastly, what I already mentioned in the previous reply here, while using the Safari app on my iPhone, while navigating and scrolling through the website UI or while opening links, I mostly always open the built-in contextual menu to edit stuff. I am not sure if this is intended or not since I don't have other device to try it out, and yes, we do have option to turn this contextual menu off like I mentioned as well, but what I personally would love to be able to is to disable it only on phones (since it can be pretty useful on desktop), or perhaps change how the right click is registered on the phones if somehow possible, since on smartphone we don't have option of difference between left / right click like on desktop, but just touch.
And now to deviate a bit from the main topic, I would also love to have some status of the rebuilding happening after making changes to the configuration from the UI. Often after making changes I am not sure if my changes were wrong or if it's cache, or if it's still rebuilding and without looking directly in logs it's a bit problematic to find out.
Otherwise, to not only make this look like I am searching for every possible bug or error in design etc. I am very happy altogether with Dashy, since it looks really classy, simple and minimalistic, works fast and is really one of a kind. One of the best home-fronts for my server I ever had. Changed from Organizr and I am happy I finally did, since it's much better looking and quick in my opinion.

How did you solve it with custom css?

#1358  seems also relevant here.

Would be great if this would happen.
Dashy is absolute unusable on my iPhone 14 Pro.
The dashboard doesn't even load, neither with Safari, Chrome, Opera or Firefox.

Also linking #1443 to this.

Also linking #1443 to this.

Thank you!

I have only issues with the minimalist style of the UI:

I realize this comment is over a year old, but I can also report the same issue.


feat(autoware_motion_utils): set zero velocity after stop in resample trajectory

Description
Cherry pick of https://github.com/autowarefoundation/autoware.universe/pull/8768 for v0.29.0
Related links
Private Links:

TIER IV internal link

How was this PR tested?
PSim test and Evaluator test were performed.
Notes for reviewers
None.
Interface changes
None.

Effects on system behavior
None.

@takayuki5168
Could you confirm this PR as a reviewer of original PR? :pray:


Support fetching ssm values in .env

Issue
CloudFormation doesn't support using SSM secure string parameters as Lambda environment variables
Solution
# .env file
plain={{ssm:plain/prod}}
secret={{ssm-secure:secure/prod}}

The SSM is fetched by SST, and process.env.PASSWORD has the resolved value.
Workaround
Calling aws-sdk to fetch SSM value. This is cumbersome b/c you can't use await/async in Construct constructor
ssm.getParameter(key).promise().then(result => {
  // Do your stuff
})

_Requested by Adrian on Slack

This is a good example of something I think benefits from seperation from the CLI.  We could have a function in core with the  responsibility of managing loading environment variables.  The cli (and whatever else) can call into this and be unaware of implementation details

I like this idea of segregation. I have used https://github.com/segmentio/chamber for this in the past. This might be a source of inspiration for the API 👍

We decided not to implemen thtis for now and wait to understand the needs for this workflow better


HBASE-26691 Replacing log4j with reload4j for branch-2.x

does it also ban transitive dependencies on log4j and slf4j-log4j12?

Yes, if you do not want to ban transitive dependency, just add <searchTransitive>false</searchTransitive>

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 31s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s
No case conflicting files found.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ branch-2 Compile Tests _

+0 :ok:
mvndep
0m 25s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
4m  4s
branch-2 passed

+1 :green_heart:
compile
9m 22s
branch-2 passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 22s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 40s
the patch passed

+1 :green_heart:
compile
9m 25s
the patch passed

+1 :green_heart:
javac
9m 25s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
xml
0m 49s
The patch has no ill-formed XML file.

+1 :green_heart:
hadoopcheck
12m 49s
Patch does not cause any errors with Hadoop 3.1.2 3.2.1.

_ Other Tests _

+1 :green_heart:
asflicense
7m  7s
The patch does not generate ASF License warnings.

61m 27s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4050/1/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/4050

Optional Tests
dupname asflicense javac hadoopcheck xml compile

uname
Linux 77ad41f5b7e1 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / d9a20630b0

Default Java
AdoptOpenJDK-1.8.0_282-b08

Max. process+thread count
141 (vs. ulimit of 12500)

modules
C: hbase-logging hbase-common hbase-metrics-api hbase-hadoop-compat hbase-metrics hbase-hadoop2-compat hbase-client hbase-zookeeper hbase-replication hbase-http hbase-asyncfs hbase-procedure hbase-server hbase-mapreduce hbase-testing-util hbase-thrift hbase-rsgroup hbase-shell hbase-endpoint hbase-it hbase-rest hbase-examples hbase-shaded hbase-shaded/hbase-shaded-client hbase-hbtop hbase-compression/hbase-compression-aircompressor hbase-compression/hbase-compression-lz4 hbase-compression/hbase-compression-snappy hbase-compression/hbase-compression-xz hbase-compression/hbase-compression-zstd hbase-assembly hbase-shaded/hbase-shaded-testing-util hbase-shaded/hbase-shaded-testing-util-tester hbase-shaded/hbase-shaded-check-invariants hbase-shaded/hbase-shaded-with-hadoop-check-invariants hbase-archetypes/hbase-client-project hbase-archetypes/hbase-shaded-client-project . U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4050/1/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 31s
Docker mode activated.

-0 :warning:
yetus
0m  6s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ branch-2 Compile Tests _

+0 :ok:
mvndep
0m 26s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
4m 35s
branch-2 passed

+1 :green_heart:
compile
3m  1s
branch-2 passed

+1 :green_heart:
shadedjars
7m 17s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
14m 27s
branch-2 passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 22s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
4m 10s
the patch passed

+1 :green_heart:
compile
3m  4s
the patch passed

+1 :green_heart:
javac
3m  4s
the patch passed

+1 :green_heart:
shadedjars
7m 37s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
14m 27s
the patch passed

_ Other Tests _

-1 :x:
unit
174m  7s
root in the patch failed.

242m 42s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4050/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/4050

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 982f6a27e547 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / d9a20630b0

Default Java
AdoptOpenJDK-11.0.10+9

unit
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4050/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-root.txt

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4050/1/testReport/

Max. process+thread count
5878 (vs. ulimit of 12500)

modules
C: hbase-logging hbase-common hbase-metrics-api hbase-hadoop-compat hbase-metrics hbase-hadoop2-compat hbase-client hbase-zookeeper hbase-replication hbase-http hbase-asyncfs hbase-procedure hbase-server hbase-mapreduce hbase-testing-util hbase-thrift hbase-rsgroup hbase-shell hbase-endpoint hbase-it hbase-rest hbase-examples hbase-shaded hbase-shaded/hbase-shaded-client hbase-hbtop hbase-compression/hbase-compression-aircompressor hbase-compression/hbase-compression-lz4 hbase-compression/hbase-compression-snappy hbase-compression/hbase-compression-xz hbase-compression/hbase-compression-zstd hbase-assembly hbase-shaded/hbase-shaded-testing-util hbase-shaded/hbase-shaded-testing-util-tester hbase-shaded/hbase-shaded-check-invariants hbase-shaded/hbase-shaded-with-hadoop-check-invariants hbase-archetypes/hbase-client-project hbase-archetypes/hbase-shaded-client-project . U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4050/1/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 46s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s
No case conflicting files found.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ branch-2 Compile Tests _

+0 :ok:
mvndep
0m 29s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
5m  3s
branch-2 passed

+1 :green_heart:
compile
12m 29s
branch-2 passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 26s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
5m  4s
the patch passed

+1 :green_heart:
compile
11m 58s
the patch passed

+1 :green_heart:
javac
11m 58s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
xml
0m 54s
The patch has no ill-formed XML file.

+1 :green_heart:
hadoopcheck
16m 55s
Patch does not cause any errors with Hadoop 3.1.2 3.2.1.

_ Other Tests _

+1 :green_heart:
asflicense
8m  6s
The patch does not generate ASF License warnings.

77m 54s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4050/2/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/4050

Optional Tests
dupname asflicense javac hadoopcheck xml compile

uname
Linux b8ecb014db5c 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / d9a20630b0

Default Java
AdoptOpenJDK-1.8.0_282-b08

Max. process+thread count
141 (vs. ulimit of 12500)

modules
C: hbase-logging hbase-common hbase-metrics-api hbase-hadoop-compat hbase-metrics hbase-hadoop2-compat hbase-client hbase-zookeeper hbase-replication hbase-http hbase-asyncfs hbase-procedure hbase-server hbase-mapreduce hbase-testing-util hbase-thrift hbase-rsgroup hbase-shell hbase-endpoint hbase-it hbase-rest hbase-examples hbase-shaded hbase-shaded/hbase-shaded-client hbase-hbtop hbase-compression/hbase-compression-aircompressor hbase-compression/hbase-compression-lz4 hbase-compression/hbase-compression-snappy hbase-compression/hbase-compression-xz hbase-compression/hbase-compression-zstd hbase-assembly hbase-shaded/hbase-shaded-testing-util hbase-shaded/hbase-shaded-testing-util-tester hbase-shaded/hbase-shaded-check-invariants hbase-shaded/hbase-shaded-with-hadoop-check-invariants hbase-archetypes/hbase-client-project hbase-archetypes/hbase-shaded-client-project . U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4050/2/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 13s
Docker mode activated.

-0 :warning:
yetus
0m  6s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ branch-2 Compile Tests _

+0 :ok:
mvndep
0m 23s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
4m  7s
branch-2 passed

+1 :green_heart:
compile
2m 42s
branch-2 passed

+1 :green_heart:
shadedjars
7m 18s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
11m 23s
branch-2 passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 20s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 59s
the patch passed

+1 :green_heart:
compile
2m 45s
the patch passed

+1 :green_heart:
javac
2m 45s
the patch passed

+1 :green_heart:
shadedjars
8m  8s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
11m 49s
the patch passed

_ Other Tests _

-1 :x:
unit
344m 48s
root in the patch failed.

405m 24s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4050/2/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/4050

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 46f1969ace8f 4.15.0-153-generic #160-Ubuntu SMP Thu Jul 29 06:54:29 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / d9a20630b0

Default Java
AdoptOpenJDK-1.8.0_282-b08

unit
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4050/2/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-root.txt

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4050/2/testReport/

Max. process+thread count
2346 (vs. ulimit of 12500)

modules
C: hbase-logging hbase-common hbase-metrics-api hbase-hadoop-compat hbase-metrics hbase-hadoop2-compat hbase-client hbase-zookeeper hbase-replication hbase-http hbase-asyncfs hbase-procedure hbase-server hbase-mapreduce hbase-testing-util hbase-thrift hbase-rsgroup hbase-shell hbase-endpoint hbase-it hbase-rest hbase-examples hbase-shaded hbase-shaded/hbase-shaded-client hbase-hbtop hbase-compression/hbase-compression-aircompressor hbase-compression/hbase-compression-lz4 hbase-compression/hbase-compression-snappy hbase-compression/hbase-compression-xz hbase-compression/hbase-compression-zstd hbase-assembly hbase-shaded/hbase-shaded-testing-util hbase-shaded/hbase-shaded-testing-util-tester hbase-shaded/hbase-shaded-check-invariants hbase-shaded/hbase-shaded-with-hadoop-check-invariants hbase-archetypes/hbase-client-project hbase-archetypes/hbase-shaded-client-project . U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4050/2/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

The latest reload4j version is <IP_ADDRESS> with a few additional vulnerabilities fixed.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 37s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s
No case conflicting files found.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ branch-2 Compile Tests _

+0 :ok:
mvndep
0m 25s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 50s
branch-2 passed

+1 :green_heart:
compile
9m 27s
branch-2 passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 23s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 37s
the patch passed

+1 :green_heart:
compile
9m 30s
the patch passed

+1 :green_heart:
javac
9m 30s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
xml
0m 49s
The patch has no ill-formed XML file.

+1 :green_heart:
hadoopcheck
12m 48s
Patch does not cause any errors with Hadoop 3.1.2 3.2.1.

_ Other Tests _

+1 :green_heart:
asflicense
8m  6s
The patch does not generate ASF License warnings.

62m  1s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4050/3/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/4050

Optional Tests
dupname asflicense javac hadoopcheck xml compile

uname
Linux 090e7ff20101 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / 3021c58513

Default Java
AdoptOpenJDK-1.8.0_282-b08

Max. process+thread count
141 (vs. ulimit of 12500)

modules
C: hbase-logging hbase-common hbase-metrics-api hbase-hadoop-compat hbase-metrics hbase-hadoop2-compat hbase-client hbase-zookeeper hbase-replication hbase-http hbase-asyncfs hbase-procedure hbase-server hbase-mapreduce hbase-testing-util hbase-thrift hbase-rsgroup hbase-shell hbase-endpoint hbase-it hbase-rest hbase-examples hbase-shaded hbase-shaded/hbase-shaded-client hbase-hbtop hbase-compression/hbase-compression-aircompressor hbase-compression/hbase-compression-lz4 hbase-compression/hbase-compression-snappy hbase-compression/hbase-compression-xz hbase-compression/hbase-compression-zstd hbase-assembly hbase-shaded/hbase-shaded-testing-util hbase-shaded/hbase-shaded-testing-util-tester hbase-shaded/hbase-shaded-check-invariants hbase-shaded/hbase-shaded-with-hadoop-check-invariants hbase-archetypes/hbase-client-project hbase-archetypes/hbase-shaded-client-project . U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4050/3/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 35s
Docker mode activated.

-0 :warning:
yetus
0m  6s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ branch-2 Compile Tests _

+0 :ok:
mvndep
0m 26s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
4m 29s
branch-2 passed

+1 :green_heart:
compile
2m 59s
branch-2 passed

+1 :green_heart:
shadedjars
7m 15s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
14m 20s
branch-2 passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 22s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
4m 14s
the patch passed

+1 :green_heart:
compile
3m  1s
the patch passed

+1 :green_heart:
javac
3m  1s
the patch passed

+1 :green_heart:
shadedjars
7m 39s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
14m 23s
the patch passed

_ Other Tests _

-1 :x:
unit
15m  5s
root in the patch failed.

81m 29s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4050/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/4050

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 9673f80ff259 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / 3021c58513

Default Java
AdoptOpenJDK-11.0.10+9

unit
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4050/3/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-root.txt

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4050/3/testReport/

Max. process+thread count
836 (vs. ulimit of 12500)

modules
C: hbase-logging hbase-common hbase-metrics-api hbase-hadoop-compat hbase-metrics hbase-hadoop2-compat hbase-client hbase-zookeeper hbase-replication hbase-http hbase-asyncfs hbase-procedure hbase-server hbase-mapreduce hbase-testing-util hbase-thrift hbase-rsgroup hbase-shell hbase-endpoint hbase-it hbase-rest hbase-examples hbase-shaded hbase-shaded/hbase-shaded-client hbase-hbtop hbase-compression/hbase-compression-aircompressor hbase-compression/hbase-compression-lz4 hbase-compression/hbase-compression-snappy hbase-compression/hbase-compression-xz hbase-compression/hbase-compression-zstd hbase-assembly hbase-shaded/hbase-shaded-testing-util hbase-shaded/hbase-shaded-testing-util-tester hbase-shaded/hbase-shaded-check-invariants hbase-shaded/hbase-shaded-with-hadoop-check-invariants hbase-archetypes/hbase-client-project hbase-archetypes/hbase-shaded-client-project . U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4050/3/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 12s
Docker mode activated.

-0 :warning:
yetus
0m  7s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ branch-2 Compile Tests _

+0 :ok:
mvndep
0m 23s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
4m 10s
branch-2 passed

+1 :green_heart:
compile
2m 40s
branch-2 passed

+1 :green_heart:
shadedjars
7m 11s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
11m 31s
branch-2 passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 20s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
4m  0s
the patch passed

+1 :green_heart:
compile
2m 43s
the patch passed

+1 :green_heart:
javac
2m 43s
the patch passed

+1 :green_heart:
shadedjars
8m 10s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
11m 43s
the patch passed

_ Other Tests _

-1 :x:
unit
27m 16s
root in the patch failed.

87m  0s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4050/3/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/4050

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux eeb4f71f6350 4.15.0-162-generic #170-Ubuntu SMP Mon Oct 18 11:38:05 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / 3021c58513

Default Java
AdoptOpenJDK-1.8.0_282-b08

unit
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4050/3/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-root.txt

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4050/3/testReport/

Max. process+thread count
716 (vs. ulimit of 12500)

modules
C: hbase-logging hbase-common hbase-metrics-api hbase-hadoop-compat hbase-metrics hbase-hadoop2-compat hbase-client hbase-zookeeper hbase-replication hbase-http hbase-asyncfs hbase-procedure hbase-server hbase-mapreduce hbase-testing-util hbase-thrift hbase-rsgroup hbase-shell hbase-endpoint hbase-it hbase-rest hbase-examples hbase-shaded hbase-shaded/hbase-shaded-client hbase-hbtop hbase-compression/hbase-compression-aircompressor hbase-compression/hbase-compression-lz4 hbase-compression/hbase-compression-snappy hbase-compression/hbase-compression-xz hbase-compression/hbase-compression-zstd hbase-assembly hbase-shaded/hbase-shaded-testing-util hbase-shaded/hbase-shaded-testing-util-tester hbase-shaded/hbase-shaded-check-invariants hbase-shaded/hbase-shaded-with-hadoop-check-invariants hbase-archetypes/hbase-client-project hbase-archetypes/hbase-shaded-client-project . U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4050/3/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Basically in addition to replacing reload4j, the PR also simplifies dependency management.

can you also verify the test failure is unrelated?

I am testing my Hadoop reload4j patch, and then realized there are a lot of gotchas when building downstream applications.
Please try build HBase downstream applications with this change. I tried to merge this PR in my internal branch and then test but we're too far away from branch-2 and resulted lots of conflicts.

I am testing my Hadoop reload4j patch, and then realized there are a lot of gotchas when building downstream applications. Please try build HBase downstream applications with this change. I tried to merge this PR in my internal branch and then test but we're too far away from branch-2 and resulted lots of conflicts.

For HBase we have tried out best to not introduce log4j dependencies to our downstream users, they will only pull in slf4j, so I do not think it will break our users too much. But it is true that hadoop and zookeeper will introduce log4j and slf4j-log4j12 dependencies to downstreamer users, I suggest we do a round of cleanup, to avoid introducing these dependencies.
Thanks.

If there are no more concerns or updates, I will merge this tomorrow.

So do we plan to use reload4j for 2.x, or we plan to directly upgrade to log4j2?
I plan to backport the log4j2 changes to branch-2 and try to see if using the old log4j.properties is fine with log4j-1.2-api in place.

how about we get this in place for branches-2 now, so that we can stop shipping hbase 2 releases with an EOL log4j 1, but we plan for the log4j 2 changes to be the preferred path for whatever the next minor 2.x release is after the backport lands. (presuming the testing goes well.)

how about we get this in place for branches-2 now, so that we can stop shipping hbase 2 releases with an EOL log4j 1, but we plan for the log4j 2 changes to be the preferred path for whatever the next minor 2.x release is after the backport lands. (presuming the testing goes well.)

Fine by me~

Merged. Agreed, we can do this now and I will pick it all the way back to branch-2.4, and anytime we can commit log4j2 work when ready to branch-2.5 and branch-2.

I also committed an addendum that ups the reload4j version to the latest release at this time, 1.2.19, and fixes a couple of misses in shading and assembly configuration.


Minor typo correction

Bumped into this while swaping 0.2.0 for 0.3.0.
Great job by the way!

Can you squash this into one commit?

Done, I just found the other typo after submiting the PR. A test would have caught this second one.

Can you escalate merging this please?

Thanks so much!

I'm releasing this, but I'd like to mention that this handler option is going to be deprecated as I don't see any real value in being able to override the entire auth resource view function. This should be done be disabling the auth resource by setting JWT_AUTH_URL_RULE = None and registering your own auth handler.


Suggestion: node install option

I think this "docker-gifify" package is worthy of being linked to as an option for drop-in Dockerfile dependency installation:
https://github.com/bcbcarl/docker-gifify/blob/master/Dockerfile
I kind of can't believe how easy it made getting gifify running in gcloud containers.

Hey there's also https://github.com/maxogden/gifify-docker, linked in the readme, maybe update the readme and add it to the top somewhere? Thanks


Large refactor

Codecov Report

Merging #35 (2f0fdd6) into main (d9a479d) will increase coverage by 1.66%.
The diff coverage is 90.14%.

@@            Coverage Diff             @@
##             main      #35      +/-   ##
==========================================
+ Coverage   80.16%   81.82%   +1.66%
==========================================
  Files          30       34       +4
  Lines        2178     2405     +227
==========================================
+ Hits         1746     1968     +222
- Misses        432      437       +5

Impacted Files
Coverage Δ

src/include/coolerpp/common.hpp
71.42% <ø> (+21.42%)
:arrow_up:

src/include/coolerpp/coolerpp.hpp
100.00% <ø> (ø)

src/include/coolerpp/dataset.hpp
100.00% <ø> (ø)

src/include/coolerpp/index.hpp
100.00% <ø> (ø)

src/include/coolerpp/pixel_selector.hpp
100.00% <ø> (ø)

src/coolerpp_validation_impl.hpp
52.77% <20.00%> (+0.72%)
:arrow_up:

src/pixel_selector_impl.hpp
75.00% <81.89%> (-3.41%)
:arrow_down:

src/chromosome_impl.hpp
91.17% <88.42%> (-1.51%)
:arrow_down:

src/genomic_interval_impl.hpp
88.78% <88.78%> (ø)

src/pixel_impl.hpp
91.56% <91.04%> (+1.65%)
:arrow_up:

... and 15 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Subprocess or spark-submit error

I got past the block from issue #1 by downloading an academic license, and now I am running into an issue about subprocess starting spark-submit. Maybe I need to install something else?
E           subprocess.CalledProcessError: Command '['spark-submit', '/ihme/homes/abie/projects/2021/census-das-container/census2020-das-e2e/tests/gurobi_2_test.py', '--sparkworkers']' returned non-zero exit status 1.

/usr/local/anaconda3/lib/python3.6/subprocess.py:291: CalledProcessError
------------------------------------------------------------- Captured stderr call --------------------------------------------------------------
Exception in thread "main" java.io.IOException: Failed to create a temp directory (under /tmp) after 10 attempts!
       at org.apache.spark.util.Utils$.createDirectory(Utils.scala:311)
       at org.apache.spark.util.Utils$.createTempDir(Utils.scala:332)
       at org.apache.spark.deploy.SparkSubmit.prepareSubmitEnvironment(SparkSubmit.scala:324)
       at org.apache.spark.deploy.SparkSubmit.org$apache$spark$deploy$SparkSubmit$$runMain(SparkSubmit.scala:774)
       at org.apache.spark.deploy.SparkSubmit.doRunMain$1(SparkSubmit.scala:161)
       at org.apache.spark.deploy.SparkSubmit.submit(SparkSubmit.scala:184)
       at org.apache.spark.deploy.SparkSubmit.doSubmit(SparkSubmit.scala:86)
       at org.apache.spark.deploy.SparkSubmit$$anon$2.doSubmit(SparkSubmit.scala:920)
       at org.apache.spark.deploy.SparkSubmit$.main(SparkSubmit.scala:929)
       at org.apache.spark.deploy.SparkSubmit.main(SparkSubmit.scala)
=========================================================== 1 failed in 2.40 seconds ============================================================

Ah it looks like it might be a permissions issue with /tmp. I think it might be resolvable by running the following (from the top-level of the repository):
# Create folder to use as temporary storage
$ mkdir singularity_tmp
# bind the container's temporary directory to the new directory
$ singularity run --home $HOME --bind singularity_tmp:/tmp census_das.img

That gets me further, but I've got a new permission error now:
py.test tests/gurobi_2_test.py
============================================================== test session starts ==============================================================
platform linux -- Python 3.6.5, pytest-3.5.1, py-1.5.3, pluggy-0.6.0
rootdir: /ihme/homes/abie/projects/2021/census-das-container/census2020-das-e2e, inifile:
plugins: remotedata-0.2.1, openfiles-0.3.0, doctestplus-0.1.3, arraydiff-0.2
collected 1 item

tests/gurobi_2_test.py .                                                                                [100%]

=========================================================== 1 passed in 6.80 seconds ============================================================
mkdir: cannot create directory '/home/abie': Read-only file system

Ah bummer, this one looks like a poorly defined home directory in census2020-das-e2e/run_1940_standalone.sh, I just pushed a fix that should get you passed this hurdle (not going to promise you won't discover another issue...).

I think it is working now!
From: p-b-j<EMAIL_ADDRESS>Sent: Saturday, February 6, 2021 5:15 PM
To: p-b-j/census-das-container<EMAIL_ADDRESS>Cc: Abraham Flaxman<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Subject: Re: [p-b-j/census-das-container] Subprocess or spark-submit error (#2)
Ah bummer, this one looks like a poorly defined home directory in census2020-das-e2e/run_1940_standalone.sh, I just pushed a fix that should get you passed this hurdle (not going to promise you won't discover another issue...).
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/p-b-j/census-das-container/issues/2#issuecomment-774571180, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AAAMQJAHPGQXVNPMRS6NQWDS5XSSZANCNFSM4XGTXVDQ.

Added instructions for the first error to the README, and given that the second error was resolved (and we've moved to discussing further issues in #3), I'll close this issue.


Disable Select

I can't seem to get the disable to work. I can still make changes to the select.
I set both the disable and class
<select name="blah" disabled class="blah disabled"> ... </select>

Ideas? Thanks!

I modified your code to pass in the select field to the onBeforeChange, and used the css class. seems to work :)
function changeSelect(select) {
        let obj = $(select);
        console.log(obj);
        return !obj.hasClass('isDisabled');
    }

Hi, yes I noticed that too, just haven't had time to test everything thoroughly yet. I made a small change which disables all options if the select has the class disabled.
Let me know if it works now.


handler: fix osd containers handler

ceph_osd_container_stat might not be set on other osd node.
We must ensure we are on the last node before trying to evaluate
ceph_osd_container_stat.
Signed-off-by: Guillaume Abrioux<EMAIL_ADDRESS>

jenkins test luminous-switch_to_containers

jenkins test luminous-switch_to_containers

jenkins test pipeline

jenkins test luminous-switch_to_containers

jenkins test pipeline

jenkins test luminous-switch_to_containers


node id in from_networkx is always cast to int

In the add_graph_from_networkx  method the node id is forced to be an int:
https://github.com/QuantStack/ipycytoscape/blob/59e3440d8a77efb3ecae4867e1992d400be5b96c/ipycytoscape/cytoscape.py#L194-L197
But networkx nodes can be any hashable object (ref):

The most common choices are numbers or strings, but a node can be any hashable object (except None)

for example:
import ipycytoscape
import networkx as nx

class person:
    def __init__(self, name):
        self.name = name
    def __repr__(self):
        return str(self.name)
person1 = person('ian')
person2 = person('maleah')

G = nx.Graph()
G.add_node(person1)
G.add_node(person2)
G.add_edge(person1,person2)

cytoscapeobj = ipycytoscape.CytoscapeWidget()
cytoscapeobj.graph.add_graph_from_networkx(G)

throws a type error.
As far as I can I can tell the JSON examples use strings as ids for the nodes so I don't think it will break anything to allow more types for the from_networkx method.

Yep. That's a very good catch.
I'll add it to my backlog but feel free to tackle it too if you want to. I'm around if you have any more questions and also available here.

Sounds good, I won't have time until Friday but I'll fix this then. Unfortunately being a grad student involves more than having fun contributing to open source software :(
Looking at the cytoscapejs documentation for elements (ref) I think that the node id needs to be a string or at least castable to a string

id: 'n1', // mandatory (string) id for each element, assigned automatically on undefined

So maybe calling repr or str on the id is the correct thing to do?

So maybe calling repr or str on the id is the correct thing to do?

I don't think so.
You're right about the int, it doesn't make sense to have an id that's always an int, but I'm afraid that you can't pass a whole object to the graph as id  because it's an unserialized object. (I just tested it).
Maybe just serializing it works? Using the json module. But then, I think it'd make more sense to write something like:
        for node in g.nodes():
            node_instance = Node()
            node_instance.data = node
            self.nodes.append(node_instance)

Additionally, it's necessary to give an option to user to choose which id they want to use. Because to have a working cytoscape graph you must have an id, the rest of the attribute are optional.
We'd have to do the same for edges with target and source.
That's a fix, but maybe better solution would be to try to fit networkx class attributes in a cytoscape object.
So, if you have keywords in a networkx graph that match the keywords existent in a cytoscape graph you could make a better conversion from one to another. And the keywords that don't match could be just added to data.

but I'm afraid that you can't pass a whole object to the graph as id because it's an unserialized object.

Looking back on this I'm not sure I understand what you mean here. Is this why calling repr or str is incorrect?


Add support for wildcard allowed-endpoints

Codecov Report
Patch and project coverage have no change.

Comparison is base (2e72a9e) 68.29% compared to head (2e72a9e) 68.29%.

:exclamation: Current head 2e72a9e differs from pull request most recent head 61df839. Consider uploading reports for the commit 61df839 to get more accurate results

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@           Coverage Diff           @@
##              int     #377   +/-   ##
=======================================
  Coverage   68.29%   68.29%
=======================================
  Files          15       15
  Lines        1621     1621
=======================================
  Hits         1107     1107
  Misses        398      398
  Partials      116      116

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


how to use dihedral_fast.py？

Here's an example configuration file that uses it: https://github.com/benanne/kaggle-ndsb/blob/master/configurations/convroll_all_broaden_7x7_weightdecay_resume.py#L85


failed to convert certificate chain PEM to DER error on ingress

This doesn't seem to work in prod. HTTPS is unavailable.
I see the following error in ingress logs
2019/06/25 20:36:26 [error] 482#482: *46831 [lua] certificate.lua:77: call(): failed to convert certificate chain from PEM to DER: PEM_read_bio_X509_AUX() failed, context: ssl_certificate_by_lua*, client: <IP_ADDRESS>, server: <IP_ADDRESS>:443

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: ada58160-dc50-b977-d3bc-65f92406e16d
Version Independent ID: 5c596e04-fddb-effe-3b72-575f4df42d4e
Content: Create an HTTPS ingress with Azure Kubernetes Service (AKS) cluster
Content Source: articles/aks/ingress-tls.md
Service: container-service
GitHub Login: @iainfoulds
Microsoft Alias: iainfou

Thanks for the feedback! We are currently investigating and will update you shortly.

@gregory-fonkatz is HTTPS not available or is it just showing as not a valid cert?
I ran through this doc and used Prod and I found it still says it is not a trusted cert

However the HTTPS endpoints do work

@MicahMcKittrick-MSFT In my case HTTPS is not available.
I'm attaching an output of kubectl describe clusterissuer,certificate,order,challenge
cert-manager-output.txt

I found the problem, it was a problem with ingress configuration.

Hi @gregory-fonkatz im facing similar issue. What was the fix in the ingress config? Thanks.

Our problem was with the backend part of config, it was directly under spec. Once we created a section of rules with a host value corresponding to tls section and embedded the backend in it everything started working.
I guess you need to make sure that hosts in rules and tls match.
@kostas-rs

Ah i see, thank you @gregory-fonkatz.
Just for reference for people looking into this error, in my case the issue was with the ingress controller not having --enable-ssl-passthrough while having nginx.ingress.kubernetes.io/ssl-passthrough: "true" annotation in the ingress object.


[JASidePanels] to Nuget.

Fails to compile component with the following message -> https://gist.github.com/newky2k/bcb97aceb1d85867a93557744492ec38

There was a problem with Git and GitHub where the PR was disconnected from the fork.  This PR is patched and opened again in #357.


-notimeout has no effect after message : "Sending data..."

without -notimeout:
haxelib submit lib.zip
Http connection timeout. Try running haxelib -notimeout <command> to disable timeout

with -notimeour
haxelib -notimeout submit lib.zip
Password :
Sending data....
Http connection timeout. Try running haxelib -notimeout <command> to disable timeout

The timeout parameter is ignored for the next step (processing) https://github.com/HaxeFoundation/haxelib/blob/master/src/tools/haxelib/Main.hx#L654 but normally not for this one.
Maybe the error message is too broad https://github.com/HaxeFoundation/haxelib/blob/master/src/tools/haxelib/Main.hx#L482 and the error is not timeout related? (just guessing here)

This seems to be an issue with install as well:
C:\Users\juef>haxelib install openfl
Downloading openfl-3,5,3.zip...
Download complete : 0 bytes in 10.5s (0KB/s)
Http connection timeout. Try running haxelib -notimeout <command> to disable timeout

C:\Users\juef>haxelib -notimeout install openfl
Downloading openfl-3,5,3.zip...
Download complete : 0 bytes in 10.5s (0KB/s)
Http connection timeout. Try running haxelib -notimeout <command> to disable timeout

Looks like -notimeout only has effect on remoting calls, not on general http request, for which it should be done using Http.cnxTimeout field.

This should work now.


python312Packages.adafruit-io: 2.7.2 -> 2.8.0

Diff: https://github.com/adafruit/Adafruit_IO_Python/compare/refs/tags/2.7.2...2.8.0
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 344882 run on x86_64-linux 1

4 packages built:

python311Packages.adafruit-io
python311Packages.adafruit-io.dist
python312Packages.adafruit-io
python312Packages.adafruit-io.dist


Change "OpenAI" to "Azure OpenAI Service"

Please update the "OpenAI" title on this page to "Azure OpenAI Service" to be consistent with branding for our first-party service and avoid confusion with OpenAI's services.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 73dc6291-6e03-a862-d2d1-03a470ec5ca7
Version Independent ID: 4e344092-3693-4594-2872-3c914dc8a601
Content: Overview of Responsible use of AI - Azure Cognitive Services
Content Source: articles/cognitive-services/responsible-use-of-ai-overview.md
Service: cognitive-services
GitHub Login: @PatrickFarley
Microsoft Alias: pafarley

@mmonsma
Thanks for your feedback! We will investigate and update as appropriate.

@mmonsma
Thanks for reporting this! We have created a PR for this issue and the changes should go live soon.


Windows 10 64bit Anniversary SageTV UI Hangs

I did a fresh install of Windows 10 64bit Anniversary Update. SageTV log shows UI hangs.
Uploading SageTV Hangs.zip…

There doesn't seem to be any log files uploaded...just a link back to this issue itself.


trt_pose not utilizing the GPU on jetson Tx2

Hello All,
We are trying to develop an application which uses trt_pose, the model is too slow and the max we could extract was 15fps on Jetson Tx2, after nvpmodel and jetson_clocks. Also, I observed that through tegrastats, the code is not utilizing all the cores, and I believe the GPU cores have zero usage during runtime, even though it is enabled inside the code. Can you please help me in getting a boost in the performance? Thank you.

Hi AmoghBharadwaj,
Thanks for reaching out!
Do you mind sharing the code you used to optimize and execute the model?  Could you also share

JetPack version
PyTorch version
TensorRT version
torchvision version

Please let me know if you have any questions.
Best,
John

Hello John, Thank you so much for replying.
I am attaching the code for your reference.
Jetpack version : 4.3DP
Pytorch version : 1.5.0
TensorRT Version : 7.1.3
Torchvision version : 0.6.0
Regards,
Amogh Bharadwaj
trt_pose.txt

Hello John, also attaching the tegrastatus window capture for your reference.
the nvpmodel is in mode 0.

Hi AmoghBharadwaj,
Thanks for sharing.  I just took a brief look.
Does the timing that you witness include the OpenCV visualization?
What is the timing reported by just this section?
model_trt = TRTModule()
model_trt.load_state_dict(torch.load(OPTIMIZED_MODEL))

t0 = time.time()
torch.cuda.current_stream().synchronize()
for i in range(50):
    y = model_trt(data)
torch.cuda.current_stream().synchronize()
t1 = time.time()

print(50.0 / (t1 - t0))

Best,
John

Hello @jaybdub , sorry for the late reply.
The model is running fine and is using GPU power, I am able to run it near real time. I made a mistake while seeing the console window and thought it was not utilising gpu. All good now, Thank you so much for the support