Submit Plugin to the Plugin Hub

I was considering submitting the plugin now since I am now satisfied with the state of the plugin. That way, the reviewer can take their time when looking at the spaghetti code because I reckon it'll take 1-2 weeks until it's accepted - if it's accepted.
However, here is the list of issues/requests I want to close before I submit it so that I minimize any problems and push out a decently polished plugin:

[x] #21
[x] #19 (Implemented and pushed PR - Further testing just to be sure)
[x] #3

Potentially

[ ] #9 (Beta worlds will hopefully be up soon for the new run changes so I can test out the various items that I don't have available already)
[ ] #23

Submitting to the RuneLite Plugin Hub and awaiting result: https://github.com/runelite/plugin-hub/pull/6891
Currently submitted version does not include the potential tasks; however, I am now starting to work on supporting equipment that doesn't degrade the pouch, Last time I submitted a plugin to the Plugin Hub, they reviewed PRs from oldest to newest, so I won't include it to avoid jumping back at the end of the queue.

Plugin was approved and added to RuneLite: https://runelite.net/plugin-hub/show/essence-pouch-tracking


'CLIPTextTransformer' object has no attribute 'eos_token_id'

Using the README code I got the following
Traceback (most recent call last):
  File "/home/rockerboo/code/others/Kolors-MPS/mps.py", line 88, in <module>
    infer_example(
  File "/home/rockerboo/code/others/Kolors-MPS/mps.py", line 56, in infer_example
    text_features, image_0_features, image_1_features = clip_model(
                                                        ^^^^^^^^^^^
  File "/home/rockerboo/.pyenv/versions/3.11.6/lib/python3.11/site-packages/torch/nn/modules/module.py", line 1532, in _wrapped_call_impl
    return self._call_impl(*args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/rockerboo/.pyenv/versions/3.11.6/lib/python3.11/site-packages/torch/nn/modules/module.py", line 1541, in _call_impl
    return forward_call(*args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/rockerboo/code/others/Kolors-MPS/trainer/models/clip_model.py", line 113, in forward
    text_f, text_EOS = self.model.get_text_features(text_inputs) # B*77*1024
                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/rockerboo/code/others/Kolors-MPS/trainer/models/clip_model.py", line 38, in get_text_features
    text_outputs = self.text_model(
                   ^^^^^^^^^^^^^^^^
  File "/home/rockerboo/.pyenv/versions/3.11.6/lib/python3.11/site-packages/torch/nn/modules/module.py", line 1532, in _wrapped_call_impl
    return self._call_impl(*args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/rockerboo/.pyenv/versions/3.11.6/lib/python3.11/site-packages/torch/nn/modules/module.py", line 1541, in _call_impl
    return forward_call(*args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/rockerboo/code/sd-ext/transformers/src/transformers/models/clip/modeling_clip.py", line 723, in forward
    if self.eos_token_id == 2:
       ^^^^^^^^^^^^^^^^^
  File "/home/rockerboo/.pyenv/versions/3.11.6/lib/python3.11/site-packages/torch/nn/modules/module.py", line 1709, in __getattr__
    raise AttributeError(f"'{type(self).__name__}' object has no attribute '{name}'")
AttributeError: 'CLIPTextTransformer' object has no attribute 'eos_token_id'

I used the following which was in the config for the CLIP version used to make this model laion/CLIP-ViT-H-14-laion2B-s32B-b79K
    model_ckpt_path = "outputs/MPS_overall_checkpoint.pth"
    model = torch.load(model_ckpt_path)
    model.model.text_model.eos_token_id = 2
    model.eval().to(device)

And with that it runs.

Thanks for your question. If you need to modify the eos_token_id, please do so by setting model.model.config.text_config.eos_token_id=2. Additionally, the default value for eos_token_id is already 2, so you can skip this step.

Update transformers to the version in requirements.txt

Ok seems to be working. I think the requirements.txt wasn't working previously, and wasn't when I tried to reinstall the dependencies. Issue with deepspeed and pydantic. Numpy version 2.0 incompatible with datasets version I believe. No pillow or einops, so this is the requirements that worked for me.
accelerate @ git+https://github.com/huggingface/accelerate.git@d1aa558119859c4b205a324afabaecabd9ef375e
datasets==2.10.1
fire==0.4.0
hydra-core==1.3.2
rich==13.3.2
submitit==1.4.5
transformers==4.27.3
wandb==0.12.21

numpy==1.26.4
einops==0.8.0
pillow==10.4.0

# deepspeed==0.8.3

JUST add one line:
model.model.text_model.eos_token_id=2
like this:
model = torch.load(model_ckpt_path)
model.model.text_model.eos_token_id=2
model.eval().to(device)

JUST add one line: model.model.text_model.eos_token_id=2
like this:
model = torch.load(model_ckpt_path)
model.model.text_model.eos_token_id=2
model.eval().to(device)

Work for me, transformers-4.44.2.


How to do Ensemble of Expert Denoisers w/ refiner model

Trying to use this with sdxl base + refiner as documented here: https://huggingface.co/docs/diffusers/using-diffusers/sdxl#base--refiner-model. I am sharing the text_encoder_2 and vae between the base and refiner as  documented. Compiling the base model works great. When I try to compile the refiner in the StableDiffusionXLImg2ImgPipeline I am getting the following error:
RuntimeError: Tried to trace <__torch__.sfast.jit.trace_helper.___torch_mangle_687.TraceablePosArgOnlyModuleWrapper object at 0x1678ecbd0> but it is not part of the active trace. Modules that are called during a trace must be registered as submodules of the thing being traced.

The stack trace indicates it's failing at the text encoder:
File "/opt/conda/lib/python3.10/site-packages/diffusers/pipelines/stable_diffusion_xl/pipeline_stable_diffusion_xl_img2img.py", line 436, in encode_prompt

prompt_embeds = text_encoder(text_input_ids.to(device), output_hidden_states=True)

software versions:
Torch version: 2.1.2+cu121
XFormers version: 0.0.23.post1
Triton version: 2.1.0
Diffusers version: 0.24.0
Transformers version: 4.36.2
CUDA Version: 12.1
Stable Fast version: 1.0.0

Can you add an example to the readme for how to do this?

@shawnrushefsky
Try using the more detailed compilation functions. For example, there are two functions called compile_uent and compile_unet in the same Python module as compile. You can call these two functions instead for once.
The error occurs because the compiled parts of your pipeline cannot be recompiled. So you could explicitly compile them as you wish.

And usually, there is no need to share vae and text_encoder between the base model and the refiner, as they are relatively small models compared with unet. Doing so won't save a lot of memory.

Thanks!


Type argument in android bridge with SDK 4.12

It appears that the latest Android SDK release (4.12) breaks react-native-theoplayer. We just started getting this error when trying to build for react-native Android.
e:  /home/projects/playerapp/node_modules/react-native-theoplayer/android/src/main/java/com/theoplayer/PlayerEventEmitter.kt: (497, 96): Type argument is not within its bounds: should be subtype of 'QualityChangedEvent<Q!, ActiveQualityChangedEvent!>!'
e: /home/projects/playerapp/node_modules/react-native-theoplayer/android/src/main/java/com/theoplayer/PlayerEventEmitter.kt: (499, 115): Type argument is not within its bounds: should be subtype of 'QualityChangedEvent<Q!, ActiveQualityChangedEvent!>!'
e: /home/projects/playerapp/node_modules/react-native-theoplayer/android/src/main/java/com/theoplayer/PlayerEventEmitter.kt: (502, 121): Type argument is not within its bounds: should be subtype of 'QualityChangedEvent<Q!, ActiveQualityChangedEvent!>!'

Pinning any earlier version of the SDK with (for example):
THEOplayer_sdk = "4.11.0"
works fine; however, since that's not the default, the backwards incompatibility means that 4.12 will likely be grabbed by existing CI/CD pipelines and fail.
Please do let us know when there's a version of react-native-theoplayer that works with SDK 4.12.

+1 having the same issue 😟

@vidangelci @danychi thanks for flagging this!
We released a 1.8.2 with a fix for the event cast.


code textcolor in light mode

hi, me agian
there is the problem

i think code mode theme should be the same before, even in the dark mode

I haven't encountered this problem yet. Can you show me your config.js file?

ok isee ,i was misunderstanding at first, i thought light was defalut theme.
in my opinion, light should as same as vuepress default theme.


Game Addition

Can you add the game Sushi Striker: The Way of Sushido? And Super Mario 3D: All Stars?  EDIT: Can you also add the game Miitopia? Thanks so much!

I have added the game(s) you requested in the most recent release: https://github.com/hobby-grade/Nintendo-Switch-Discord-Status/releases/tag/<IP_ADDRESS>


Plugin for IntelliJ

Hi Ben
First thing, I loved the video and the idea, did not tried it yet but I already know I would like to implement a plugin for jetbrains ide.
Wanted to ask if that is ok with you if so I ll maybe have some questions along the way.
Cheers and great work!!
Jonathan

it's fine with me

Related #68 - Lack of API Docs


chore: add postpublish script and manual template updater

self-merging to test if the update script is working


When querying without a surname in FreeCEN2 it gives an error without showing validation errors

updated the code in test2

@sudaraka94 can you test this for us? :)


Tracking Issue for needs_drop

I'm about to submit a PR to provide intrinsics::needs_drop under mem; need a tracking issue. Here it is!

Oops, wrong repo!


[BUG] Most recent Event 'Self reported Symptoms' is not displayed on the Home screen

Describe the bug
Once the user submits the symptoms by Symptom check-in, the Most recent Event, 'Self-reported Symptoms,' is not displayed on the Home screen.
To Reproduce
Steps to reproduce the behavior:

Install the Safer app.
Complete the onboarding.
User role is selected as University student and verify the identity.
Complete the Covid onboarding steps.
Safer home screen is displayed.
Tap on Symptom Check-in and select the symptoms, and tap on submit button.
"Your Symptoms have been processed message is displayed and tap in OK button

Actual Result
Once the user submits the symptoms by Symptom check-in, the Most recent Event, 'Self-reported Symptoms,' is not displayed on the Home screen.
Expected behavior
The app should display "Most recent Event Self-reported Symptoms" on the Home screen once the user reports and submits the symptoms.
Smartphone (please complete the following information):

Device: [e.g. iPhone and Android]
Version [e.g. 2.10.22]

Retested this issue. This is fixed.


pytorch 0.3

After upgrade pytorch to version 0.3, the test file alexnet.py can not work correctly. How to solve this problem?

Hello @auroua. I've checked the new PyTorch and yes, something in the graph computation was changed. If you want to use this converter I only advise to downgrade your PyTorch version.
I noticed these changes:

https://github.com/nerox8664/pytorch2keras/blob/master/pytorch2keras/converter.py#L37 Is no longer accurate. There is some questions about new structure. For example, for Linear / Dense I've a new nodes ExpandBackward. So, I'm trying to figure it out.
Layer names was also changed.

Do you planning to support pytorch 0.3?


undo def -> lazy val toProto change

Other tests showed this significantly increased the memory overhead for
instances with concurrent deployment plans.

Thanks :)


[Bug] [ruby] Global Variable Assignments

Describe the bug
Global variable assignments don't appear to be handled yet, as shown by chatwoot
2024-11-11 13:35:42.381 WARN AstCreator: Could not represent expression: $alfred = ConnectionPool.new(size: 5, timeout: 1) do
  redis... (Unknown) (config/initializers/01_redis.rb), skipping
2024-11-11 13:35:42.395 WARN AstCreator: Could not represent expression: $velma = ConnectionPool.new(size: 5, timeout: 1) do
  config... (Unknown) (config/initializers/01_redis.rb), skipping

In other areas, I've simply modelled something like $velma to self.$velma as this is a dynamic field bound to a global state.
To Reproduce
Parse git@github.com:chatwoot/chatwoot.git

Fixed in #5107


What resolution size is recommended for MP4 videos? What should the bitrate be set to? Should the video use H.264 or H.265 encoding?

About Dataset Preparation,
What resolution size is recommended for MP4 videos? What should the bitrate be set to? Should the video use H.264 or H.265 encoding?
example： 1280X720, 5mbps below. recommended  H.264 encoder.
Is any suggestion here?

cc @zRzRzRzRzRzRzR

https://github.com/a-r-r-o-w/cogvideox-factory/blob/main/assets/dataset.md


How to use lampe in pure command line?

I want to add keyboard shortcuts for lampe in KDE or add aliases for my terminal. Just to switch on/off. But I don't know how to use lampe in pure command line because the only way to use it is to launch the bash-script interface.
Is there a possibility?

Currently it just supports interactive-mode. In early days I started with simple batch-mode. I have to look wether it can be easly achieved to support both:
So, something like this (brainstorming; option -s for "set" and quit):
lampe -s 2 y # light 2 on
lampe -s 1 n # light 1 off
lampe -s y # switch all lights on

would help you?

Yes! It would be great! :+1:

I will start something in a seperate branch. I'll let you know as soon there is something to try out.

You can now test the new oneshot-mode from branch "issue34-oneshot_mode".
All options should work, but I would not recommend starting sequences in oneshot-mode (needs further testing); I have tried following to start and stop blinking, which worked:
lampe -s 5 b
lampe -s Q # to end all sequences or
lampe -s 5 b # to just stop blinking of light 5

Have fun! (:

pull-request #35 waits for testing.

tested and merged to master, will be released with version 1.1.6


Monitor if process is down

Im using topbeat to gather system information including the processes running in it and storing the same to elasticsearch after parsing through logstash.
Im trying to configure elastalert to monitor if specifc process say, "nginx" is down in server. I tried using flatline but it wasnt working. Below are relevant parts of  the configuration:
**name: Process not running
type: flatline
threshold: 1
use_count_query: true
doc_type: process
index: topbeat-*
timeframe:
minutes: 5
filter:

and:

term:
host: "prod-app01"
term:
proc.name: "nginx"**

And the debug logs:
INFO:elastalert:Note: In debug mode, alerts will be logged to console but NOT actually sent. To send them, use --verbose.
INFO:elastalert:Starting up
INFO:elastalert:Queried rule Process not running from 2016-06-15 16:03 ART to 2016-06-15 16:08 ART: 1 hits
INFO:elastalert:Skipping writing to ES: {'hits': 1, 'matches': 0, '@timestamp': '2016-06-15T19:08:26.347513Z', 'rule_name': 'Process not running', 'starttime': '2016-06-15T19:03:26.337785Z', 'endtime': '2016-06-15T19:08:26.337785Z', 'time_taken': 0.0097169876098632812}
INFO:elastalert:Ran Process not running from 2016-06-15 16:03 ART to 2016-06-15 16:08 ART: 1 query hits, 0 matches, 0 alerts sent
INFO:elastalert:Sleeping for 299 seconds
INFO:elastalert:Queried rule Process not running from 2016-06-15 16:08 ART to 2016-06-15 16:13 ART: 0 hits
INFO:elastalert:Skipping writing to ES: {'hits': 0, 'matches': 0, '@timestamp': '2016-06-15T19:13:25.450825Z', 'rule_name': 'Process not running', 'starttime': '2016-06-15T19:08:26.337785Z', 'endtime': '2016-06-15T19:13:25.438628Z', 'time_taken': 0.012176036834716797}
INFO:elastalert:Ran Process not running from 2016-06-15 16:08 ART to 2016-06-15 16:13 ART: 0 query hits, 0 matches, 0 alerts sent
INFO:elastalert:Sleeping for 299 seconds

Seems to work after i comment out:
#use_count_query: true

Hi @vikas8190, thx for sharing this is also relevant for my altering system! do you think (or even know) if it's possible to write an elastalert rule for tobeat related data and get an alarm if a volume/hdd's space is more than 90% full?

@phermann1988  : Yes you can do it.
The disk space statistics are available as a "filesystem" type record from topbeat.
A filter similar to below should work for diskspace utilization between 90% to 100%.
filter:

and:

term:
_type: "filesystem"
range:
fs.used_p:
from: 0.9
to: 1

fantastic!! thank you @vikas8190. could you maybe post your whole working Process not running rule? if i try it with the snipped you posted above, it always get the following error:
elastalert.util.EAException: Error loading file myrules\process_flatline.yaml: C
ould not parse file myrules\process_flatline.yaml: mapping values are not allowe
d in this context
in "myrules\process_flatline.yaml", line 14, column 19
line 14, column 19 is the ":" before host (..term: host: "server01"..), so maybe sth is missing in my rule? (just coppied your code and changed the host and process name). thank you :-)

Well its a yaml file. So you have to format it properly(Direct copy paste of above wont work). Try this.
`filter:

and:

term:
_type: "filesystem"
range:
fs.used_p:
from: 0.1
to: 1`

Hi i want to measure the data from topbeat
Whenever range: fs.used_p: from: 0.9 to: 1
it alerts me with the details, even if single event occurs
Which rule should i use and what should be my default parameters

Try out adding below parameters to configuration file:
aggregation:
minutes: 1
realert:
minutes: 1
Change the values as u need. Read about what its used for elastalert documentation

Whenever i start the elastalert, it will start parsing the logs of topbeat from current time and also at intervals i provide in the config.yaml file
Does it parses all the logs in that duration or it parses the logs present at kibana for that period of time?
Because if i run instance after every one minute, i will be getting repeat values, right?
I can configure properly then, can you clear my doubt.
Thanks & Regards

@Pransh20 : I configured it using 'any' type rule
es_host: localhost
es_port: 9200
name: Disk space monitoring
type: any
index: topbeat-*
filter:
- range:
mem.used_p:
from: 0.9
to: 1
realert:
minutes: 30
alert:

"email"

email:

<EMAIL_ADDRESS>


Update dependencies

Currently the version of eslint specified in package.json is 4.19.1 while the latest version of eslint is 5.15.3.
This is producing errors.
e.g) "array-element-newline": "consistent" option is excluded and making "fatal: Error" :-(

hello @pcr910303
Thanks for the report, I released a new version.
Tell me if its ok

@Adezandee Thanks! Can confirm it is running well for all eslint projects :-)
I'm not sure if original behavior did not display any linter errors if .eslintrc.js is not present.
Currently it does...


Ruuvi data not identified to ruuvi data

I have a recently purchased Ruuvi device. Get only raw data with that although using -r switch.
length = 1
data = (31) b'\x03\x01\x1a\x8b\xdd\xb2\xe7\xc0\x15\x02\x01\x06\x11\xff\x99\x04\x03\x98\x02\x11\xc3\xf7\xff\x14\x03\xf1\x00I\x0b\xdd\xa3'
datalength = 21
datalength = 18
Adv Report:
ev type:
no connection adv
addr type:
random
peer:
c0:e7:b2:dd:8b:1a
length:
21
flags:
Simul LE - BR/EDR (Host): False
Simul LE - BR/EDR (Control.): False
BR/EDR Not Supported: False
LE General Disc.: True
LE Limited Disc.: True
Manufacturer Specific Data:
Manufacturer ID:
1177
Payload:
03:98:02:11:c3:f7:ff:14:03:f1:00:49:0b:dd
rssi:
-93

Hi,
Are you sure that is a Ruuvi tag?
What mode are you using? What firmware version?What data are you expecting?  The data seems to short for either URL or manufacturer specific data.
Can you run
python3 -m aioblescan -R
So I can see what aioblescan is trying to decode

Hi @frawau
Yes, it is absolutely a Ruuvi tag.
I added two files; one from aioblescan like you suggested and an other one from ttu/ruuvitag_sensor. Hope that helps.
aioblescan.log
ruuvitag.log

Hi,
I am a bit puzzled. I ran your raw data through the decoder and it worked...
How did you install aioblescan? Could you try cloning the github repo and install it from there?
Did you try running aioblescan with the Ruuvi tag in "URL" mode (Usually the default mode after power cycling)
The only difference I see between your data and mine is some extra null bytes in my packets

@fuggah what is your exact command line? If you don't limit the MAC addresses using the -m switch, you get all the advertisments from all the devices around you. There may be many.
This tricked me at first - there was so much information running thru my terminal that I did not even notice the ruuvi entries generated by -r switch.
@frawau is this intentional behavior? I thought that by giving a -r switch I would only get the ruuvi tag entries.

@petri , well it is so long ago this happened that I needed to spend some time recalling.
The command line was 'python3 -m aioblescan -m C0:E7:B2:DD:8B:1A -r 2>&1 >withMAC.log'
I also tried with 'python3 -m aioblescan -r 2>&1 >withoutMAC.log'
No matchstick.
The MAC address is copied from the working framework 'ruuvitag-logger' which is now running my cron.hourly and saving the data into a sqlite database.

@petri Yes it is how it is intended to work. The '-r' flag requests to try to decode the data as a Ruuvi tag data. To limit the packet displayed, use the mac filter.

Ok, so the result is that for some reason it cannot decode it as a Ruuvi tag. I need to make some comparison with ruuvitag-logger and aioblescan data. I bet there's a small difference how the data is decoded

Hi
You could have been using RAWv2. Check with the version I released yesterday. 0.2.6

Yo, sorry about the delay. Installed 0.2.6 and it seems to work now. Data is identified to Ruuvi data.


Generate aggregate coverage but publish a single Jar

NOTE: This will require an update to rocket-chip's project/plugins to include sbt-coverage (freechipsproject/rocket-chip#1004).


Weird Dialog/Window border behavior

application {
    val windowState =
        rememberDialogState(height = 250.dp)
    Dialog(
        onCloseRequest = ::exitApplication,
        state = windowState,
        undecorated = true,
        transparent = true,
        resizable = false
    ) {
        Box(modifier = Modifier.fillMaxSize().border((1).dp, color = Color.Black)) {
        }
    }
}

If transparent = false, the lower border is there, but it is thiner.

transparent with height 251.dp

transparent  = false with 251.dp

same with 252.dp

Its not specific to those values, 450 dp transparent will also not produce a lower border and etc

Like same issue , I try to add shadow
application {
    val windowState =
        rememberDialogState(height = 250.dp)
    Dialog(
        onCloseRequest = ::exitApplication,
        state = windowState,
        undecorated = true,
        transparent = true,
        resizable = false
    ) {
        App(
            pageModifier = Modifier.fillMaxWidth()
                .shadow(20.dp, RoundedCornerShape(5.dp)),
            title = {
                WindowDraggableArea {
                    PageTitle()
                }
            }
        )
    }
}

I can get shadow, and must add padding to show shaodw.
Is there any follow-up on this issue?

The original issue is no longer reproducible 1.6.0-rc02
@lizhongyue248 Please file a new issue, and provide a complete, minimal reproducer (the code you posted is missing the definition of App).

It is reproducible on non-integer system scale. On macOs it usually isn't possible to set, so it is needed to check on Windows/Linux.
Steps to reproduce:

set the system scale to 125% (on Windows it is in Display settings)
run the code:

import androidx.compose.foundation.border
import androidx.compose.foundation.layout.Box
import androidx.compose.foundation.layout.fillMaxSize
import androidx.compose.ui.Modifier
import androidx.compose.ui.graphics.Color
import androidx.compose.ui.unit.dp
import androidx.compose.ui.window.singleWindowApplication

fun main() = singleWindowApplication(undecorated = true) {
    Box(modifier = Modifier.fillMaxSize().border((1).dp, color = Color.Red))
}

resize. some sizes results in a white line on the right/bottom

(in 1.6.0-rc02 the hiding isn't reproducible, only the white line)
This happens, because the system resizes the window in pixels, but AWT reports the size in int points, and loses precision. The proper fix will be to read/subscribe to the size of the window via native code.
related issue: https://github.com/JetBrains/compose-multiplatform/issues/179 (slightly different because we had overlapping with system titlebar and window border)

Please check the following ticket on YouTrack for follow-ups to this issue. GitHub issues will be closed in the coming weeks.


Seismic

I'm trying to do an app that send you notifications every time a certain seismic wave happens,and send you a notification to your phone if you have the app downloaded.

That's not what this library is for. This detects when you shake your phone.


[SPARK-23475][WebUI]Skipped stages should be evicted before completed stages

What changes were proposed in this pull request?
The root cause of missing completed stages is because cleanupStages will never remove skipped stages.
This PR changes the logic to always remove skipped stage first. This is safe since  the job itself contains enough information to render skipped stages in the UI.
How was this patch tested?
The new unit tests.

cc @vanzin

Test build #87602 has started for PR 20656 at commit 82e7dda.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/998/
Test PASSed.

LGTM pending tests.

Test build #87602 has finished for PR 20656 at commit 82e7dda.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87602/
Test PASSed.

Thanks! Merged to master/2.3


When selecting command from history Nushell throws an error

Hey! Just a few questions so we can better help you

What error are you getting?
What version of Atuin are you running?
What version of NuShell are you running?

We require the very latest version of NuShell

Sorry, I meant to give a more detailed description of the error. Had a problem with the GitHub iOS app.
Error:

Atuin Version: 14.0.0
Nushell Version: 0.78.0

Maybe the error is caused by this breaking change from Nushell 0.77.2 to 0.78.0.?

It solved the problem as I changed this line in the ~/.local/share/atuin/init.nu file. Thanks! 😊


Symlinks shown as directories

Files that are a symbolic link to another files are shown as a directory in the tree-view. This makes it impossible to double-click on them and start editing them. Can somebody reproduce this? How can we fix?

Per SSH ?

Yes
On Wed, 2 Dec 2015, 15:29 Jan<EMAIL_ADDRESS>wrote:

Per SSH ?
—
Reply to this email directly or view it on GitHub
https://github.com/mgrenier/remote-ftp/issues/238#issuecomment-161315422
.

--
--
Emmanuel Frécon

This would be really nice if fixed.

I tried to fix this on a forked branch, put I'm not allowed to create a pull request. How would you like to get the changes to review?

??? Everybody is allowed to create a PR...
But you didn't push your changes to your fork, did you?
Can't see any new commits of you in https://github.com/ghoben/remote-ftp

sorry, my fault. I'm still struggling with the way GitHub works. I was creating a branch within your repository, I was was denied to sync them with the main repository. I committed into the fork and was able to create a pull request. I hope you are fine with the changes. If not let me know. I only adapted sftp.js connections.

Thanks for the PR :) Merged

Will be part of the next update

Great! Thanks.


Update sbt to 1.5.1

Updates org.scala-sbt:sbt from 1.4.9 to 1.5.1.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.scala-sbt", artifactId = "sbt" } ]

labels: library-update, semver-minor

Codecov Report

Merging #4 (5e265a3) into main (dff3455) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main       #4   +/-   ##
=======================================
  Coverage   83.63%   83.63%
=======================================
  Files           4        4
  Lines          55       55
=======================================
  Hits           46       46
  Misses          9        9

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dff3455...5e265a3. Read the comment docs.


Better documentation

I have just spent a lot of time trying to figure out what this mod can do, what features it has, and how to use it. There is no such information anywhere it seems. There should be information about this so new users can figure out how to use it/find out more about it before downloading.

I'll try to take care of that soon, but in the upcoming weeks I will have exams and I can't promise that I have time after them either. I will keep in mind that I want to add that though, to make it easier for players to use the mod and for programmers to modify it.

I just wanted to say exactly what that other guy said. I am super-confused, but this mod looks like exactly what I need. Would this be good for someone who decides to setup a second base? I would like to setup multiple bases and be able to access my storage at any one of them. Working on an underwater base right now.

I've added a very basic wiki to this project. I hope that that helps for now, however I do plan on expanding that whenever I have the time again.

I've added a very basic wiki to this project. I hope that that helps for now, however I do plan on expanding that whenever I have the time again.

When the Wiki Is expanded, i plan to add it to mineclone2 ingame using mcl_doc. So it would be a big help if you could complete it.
Thanks for all you have done so far!

I appreciate the offer. In game documentation would really help.
However completing the wiki will be a recurring task.
Currently there are some new features in development and the mod is not yet finished.
As new features are added I will keep expanding the wiki whenever I find the time.


Missing documentation on View prop 'elevation'

Description
Documentation on what styles can be given to a View have been removed in v0.44, and is now replaced with the simple line style?: stylePropType.  (I don't know if this is on purpose or not, but it's rather confusing, and not very informative)
As a consequence, documentation on style props mut now be found under Shadow Props and
Layout Props.
None of these pages include documentation on the Android-only elevation prop, that handles shadows on Android.
Reproduction Steps and Sample Code
See 0.43 View style prop vs 0.44 View style prop
Solution
It would be misleading to document the elevation prop on the Shadow Props page, as the props listed there are suppose to go into a StyleSheet, while the elevation is a prop on View. Instead I would recommend documenting the prop on the View documentation.
Additional Information

React Native version: 0.44
Platform: Docs
Development Operating System: Not applicable
Dev tools: Not applicable

bump

Hi there! This issue is being closed because it has been inactive for a while.
But don't worry, it will live on with Canny! Check out its new home: https://react-native.canny.io/feature-requests/p/missing-documentation-on-view-prop-elevation


feat: Support IAM Auth mode for memorydb cluster

Description
Support IAM auth mode.
Motivation and Context
https://github.com/hashicorp/terraform-provider-aws/pull/32027
Breaking Changes
No.
How Has This Been Tested?

[x] I have updated at least one of the examples/* to demonstrate and validate my change(s)
[x] I have tested and validated these changes using one or more of the provided examples/* projects

[x] I have executed pre-commit run -a on my pull request

This PR is included in version 2.1.0 :tada:


Android will loose focus if the contenteditable field is redrawn.  This forces keyboard close.

Android will loose focus if the contenteditable="true" field is also redrawn.
This restricts forcing redraw to the only the element instead of redrawing the contenteditable="true" element.

Hm. I'm worried that there could be other children of the contenteditable div in the DOM that wouldn't get removed if we only rekey the contents component.

I was wondering if there were any children @spicyj  - thanks for the clarification.
Would a more targeted updating method work?
Right now I'm thinking:

add a second key
determine if we're inputting from a virtual-keyboard
re-key only content="true" div if this is the case?
else re-key everything

Is there any chance of this getting merged sometime soon?

Hey @codejet, the concern here is we're not sure if this is the proper fix.  It fixes the keyboard issue, but due to a more targeted redraw we need to make sure it doesn't cause any other issues.

I don't think there should be any other children of the contentEditable div. As it is, I think I only pulled DraftEditorContents out into a separate component for shouldComponentUpdate purposes.
I'm actually wondering if it would always be safe to redraw only the DraftEditorContents when resetting the DOM.

The reset behavior is only needed for cut and composition events.
These events should only occur to contents that are definitely within the contentEditable.
These events should only occur on descendants of DraftEditorContents.

The case where I can see problems occurring is where a cut or composition discards the entire DraftEditorContents for some reason.
Would you mind giving this a try and going through the cut/composition parts of the manual test plan to see if it works?

It seems like select all then cut would delete the contents completely…

Dear god, please merge this

FYI Googlers: I was able to sidestep this problem by by disabling autocorrect on the contentdeditable element on Android.
https://davidwalsh.name/disable-autocorrect

@hellendag Your suggestion about only redrawing DraftEditorContents works like a charm. Here's a PR for that approach: https://github.com/facebook/draft-js/pull/907

@hellendag Your suggestion about only redrawing DraftEditorContents works like a charm. Here's a PR for that approach: https://github.com/facebook/draft-js/pull/907

May want to also check out https://github.com/facebook/draft-js/pull/907, looks like it tackles the same issue with a similar fix.

We ended up merging a similar PR - https://github.com/facebook/draft-js/pull/907 so closing this.


Neovide startup issue

I have an issue with neovide, thins happens on start but goes away after I open any other buffer or telescope window. Is there any way to fix that?

I noticed the same issue and after some debugging I found that the issue was in implementation of my custom top padding element. I used something like:
local top_padding = function(height_estimate)
    return function()
        local height = vim.api.nvim_win_get_height(0)  -- <= this was using current window
        local calculated = (height - height_estimate) / 2
        return math.ceil(math.max(1, calculated))
    end
end

local layout = {
    { type = 'padding', val = top_padding(50) },
    -- ...
}

So it was checking the current window height, which for a telescope window was of course incorrect. A simple fix was to check current buffer filetype and use the previous padding value:
local top_padding = function(height_estimate)
    local cached
    return function()
        -- Use cached value if redrawing from another window
        local filetype = vim.api.nvim_buf_get_option(0, 'filetype')
        if cached and filetype ~= 'alpha' then
            return cached
        end
        local height = vim.api.nvim_win_get_height(0)
        local calculated = (height - height_estimate) / 2
        cached = math.ceil(math.max(1, calculated))
        return cached
    end
end

@jedrzejboczar where do you use 'layout' property?

I'm not using the presets but defining layout using this setting, so it's require('alpha').setup { layout = ... }. If you're using a default theme than it's defining the layout, e.g. dashboard.

@jedrzejboczar still have this issue while using this fn for padding.. but it's definitely padding issue - displays normal with padding 0, but looks weird :)

Solved by adding empty lines to my ASCII logo 😆


HTTP Error while running evaluation script

Hi,
I am facing the below error when running the command: bash finetune_AMRbart_amrparsing.sh /path/to/pre-trained/AMRBART/ gpu_id
I am unable to find the cause and would really appreciate any help! Thanks a lot!

Hi,
Please refer to this issue.


Update index.html

Pull Request Checklist

[ ] I have added screenshots and videos to show the working of my code.
[ ] I have ensured that the screen size is set to 100% while making the video.
[ ] I have synced the latest fork with my local repository and resolved any conflicts.

kindly resolve merge conflicts and sync fork


custom config.filter function does not override inbuilt filter

Hi,
I am using madge for generating dependency graph for a commonJS codebase. I used the config to pass custom configuration setting for madge but what I found is that there is a filter function at madge/tree.js which is overriding my config.filter function.
If this is something that will be useful for madge I am open to make code changes.
Thanks!

You should use config.dependencyFilter for that. See https://github.com/pahen/madge#configuration


TFRS - Simplified BCeID & IDIR dashboard for Compliance & Exclusion reports updates

Title: Simplified BCeID & IDIR dashboard for Compliance & Exclusion reports filter updates
Description: Update dashboard as shown in screen captures and mock-ups. Replace the crossed out links with one new link shown in the mock-ups (ignore the updated dashboard layout/colours for now).
Current BCeID dashboard

New mock-up,  Click the link with the red arrow to see index page with default filtering.
https://preview.uxpin.com/59145260c7d8cc48969ac79401cc03d84843c3d9#/pages/161840337?mode=f
--
IDIR Analyst/Manager role dashboard

New mock-up,  Click the link with the red arrow to see index page with default filtering.
https://preview.uxpin.com/59145260c7d8cc48969ac79401cc03d84843c3d9#/pages/161899748?mode=f
--
IDIR Director role dashboard

New mock-up,  Click the link with the red arrow to see index page with default filtering.
https://preview.uxpin.com/59145260c7d8cc48969ac79401cc03d84843c3d9#/pages/161976046?mode=f
Acceptance Criteria:

[ ] Given I am a , When I am , then
[ ] Given I am a , When I am , then

Development Checklist:

[ ] A
[ ] B
[ ] C

Notes:

The new counts seem to now be slower to load than the other counts. It was hoped this simplified design would be faster to load.
The Director dashboard still has the top level count (shown as 12 above), this was to be removed. The three sub-bullets were to be move more as prrimary links as shown in the mock-up
The analyst dashboard needs the word 'compliance' capitalised

The line spacing / padding on the dashboard has been compressed. Can we please add some spacing between the lines of text on the dashboard.

the Compliance & Exclusion Reports panel line spacing looks better but there are other panels where the spacing has become scrunched, perhaps a CSS setting somewhere got changed? The 112 number used to be more aligned and level with the Notifications text.

same on the bceid side


Release v18.7.0 beta01

Details

Update the version of reCAPTCHA SDK to 18.7.0-beta01
Remove duplicate file https://github.com/GoogleCloudPlatform/recaptcha-enterprise-react-native/issues/56

Running locally the e2e tests pass. We will fix the CI moving forward.


Possibility of public db-s

Add possibility of public db-s (like FTP)

Prerequisite to this: #62 Add functionality to alter database / table

Partially (fully?) implemented as of 8db1598, though I asked @sorin-pop to double check if we're missing anything.

Implemented

wow. thank you for the fast resolution! :)


Catch-clause silences exception of type in other catch clauses

Related to #14 - Probably the same
In this case, where it was detected;
The catch clause catch (InvalidOperationException e) should propagate IOException (via Console.WriteLine) and not be affected by
catch (IOException e) { } - not be silenced.
try
{
    Console.Write("Write number: ");

    var number = Console.ReadLine();

    if (number is null)
    {
        throw new InvalidOperationException("Argument is null");
    }

    var parsedNumber = Process(number);

    Console.WriteLine($"The number was: {parsedNumber}");
}
catch (IOException e) { }
catch (OutOfMemoryException e) { }
catch (ArgumentOutOfRangeException e) { }
catch (InvalidOperationException e)
{
    Console.WriteLine(e.Message);
}

Fixed in https://github.com/marinasundstrom/CheckedExceptionsAnalyzer/commit/17db96877e29f3091663521a1b87b5c6494e0693


Unable to run in Mac M1

So, I am having an issue running the project on M1 Mac.
The error is as follows:
      #warning "Using deprecated NumPy API, disable it with " \
       ^
      src/fractalshades/mpmath_utils/FP_loop.c:790:10: fatal error: 'gmp.h' file not found
      #include "gmp.h"
               ^~~~~~~
      1 warning and 1 error generated.
      error: command '/usr/bin/clang' failed with exit code 1
      [end of output]

  note: This error originates from a subprocess, and is likely not a problem with pip.
  ERROR: Failed building wheel for fractalshades
Failed to build fractalshades
ERROR: Could not build wheels for fractalshades, which is required to install pyproject.toml-based projects

I tried to look into the issue and found a similar solution for missing gmp.h here at https://github.com/OpenZeppelin/nile/issues/22
However, the error still persists. I tried all the solutions mentioned, but am having issues running them.

Hi Biraj,
Unfortunately, currently only Linux & Mac OS are supported (mainly because, I only have access to those systems...)
To install on MAC you will need to install from source as I do not ship pre-built binaries, and a pre-requisite is to have recent versions of GMP, MPFR and MPC multi-precision arithmetic libraries installed on your system. I do not use Mac so I cannot help much more, if you manage to install I can only update the installation instruction I guess.
This SO question might help:
https://stackoverflow.com/questions/35360885/installing-finding-gmp-under-osx
I will keep this issue open for a while in case someone else can support.

Thank you! Will try a few things.

Hey @GBillotey. The issue is fixed. Thankyou for pointing me in the right direction. Have sent a PR. Please review! https://github.com/GBillotey/Fractalshades/pull/124

@biraj094 Thanks a lot for your feedback, I have merged #124 and will rebuild the doc soon.


Expose stream + device size in bytes

I forgot to do this in permissions

Not relevant for now, can be revisited later.


Reexporting features implicitly enables optional dependency

Problem
cargo check --features foo implicitly enables optional dependency bar given this manifest:
[features]
foo = ["bar/foo"]

[dependencies]
bar = { version = "0.1", path = "bar", optional = true }

The behaviour I would expect is bar not being enabled unless it's also specified in the --features.
If feature foo did in fact depend on bar, that could be specified like foo = ["bar", "bar/foo"].

Notes
Output of cargo version:
cargo 1.40.0-nightly (a429e8cc4 2019-10-04)

Thanks for the report!  This seems to be a duplicate of #3494, so I'm going to close in favor of that.


Unit test userstamp/history/timestamp for core models

Stemming from #198 we should make sure to userstamp/history/timestamp all this for the following controllers:

[ ] Patient
[ ] Pregnancy
[ ] Pledge
[ ] Call
[ ] Clinic
[ ] Note

We can be casual about it (just check respond_tos) but should have some representation of it in our controller and model tests, since we're relying on these for frontend functionality and not just auditing.

Sample code:
  describe 'mongoid attachments' do
    it 'should have timestamps from Mongoid::Timestamps' do
      [:created_at, :updated_at].each do |field|
        assert @note.respond_to? field
        assert @note[field]
      end
    end

    it 'should respond to history methods' do
      assert @note.respond_to? :history_tracks
      assert @note.history_tracks.count > 0
    end

    it 'should have accessible userstamp methods' do
      assert @note.respond_to? :created_by
      assert @note.created_by
    end
  end


Doesn't work in gcloud

curl <IP_ADDRESS>:8848/metrics
HELP python_gc_objects_collected_total Objects collected during gc
TYPE python_gc_objects_collected_total counter
python_gc_objects_collected_total{generation="0"} 340.0
python_gc_objects_collected_total{generation="1"} 33.0
python_gc_objects_collected_total{generation="2"} 0.0
HELP python_gc_objects_uncollectable_total Uncollectable object found during GC
TYPE python_gc_objects_uncollectable_total counter
python_gc_objects_uncollectable_total{generation="0"} 0.0
python_gc_objects_uncollectable_total{generation="1"} 0.0
python_gc_objects_uncollectable_total{generation="2"} 0.0
HELP python_gc_collections_total Number of times this generation was collected
TYPE python_gc_collections_total counter
python_gc_collections_total{generation="0"} 35.0
python_gc_collections_total{generation="1"} 3.0
python_gc_collections_total{generation="2"} 0.0
HELP python_info Python platform information
TYPE python_info gauge
python_info{implementation="CPython",major="3",minor="8",patchlevel="7",version="3.8.7"} 1.0
HELP process_virtual_memory_bytes Virtual memory size in bytes.
TYPE process_virtual_memory_bytes gauge
process_virtual_memory_bytes 1.77471488e+08
HELP process_resident_memory_bytes Resident memory size in bytes.
TYPE process_resident_memory_bytes gauge
process_resident_memory_bytes 1.9795968e+07
HELP process_start_time_seconds Start time of the process since unix epoch in seconds.
TYPE process_start_time_seconds gauge
process_start_time_seconds 1.61505511176e+09
HELP process_cpu_seconds_total Total user and system CPU time spent in seconds.
TYPE process_cpu_seconds_total counter
process_cpu_seconds_total 0.32
HELP process_open_fds Number of open file descriptors.
TYPE process_open_fds gauge
process_open_fds 7.0
HELP process_max_fds Maximum number of open file descriptors.
TYPE process_max_fds gauge
process_max_fds 1.048576e+06
HELP pvc_usage fetching usge matched by k8s csi
TYPE pvc_usage gauge

Hi ， could you  please run 'df -h' on your hosts and share the results?

There are too many lines, but I guess this one is about PVC
/dev/sdf        8.4G   47M  8.4G   1% /var/lib/kubelet/plugins/kubernetes.io/gce-pd/mounts/gke-data-bd2c320a-dyna-pvc-41e03eb9-503e-11eb-8f2d-42010a8001bd

Hi , please try this version "dockerid31415926/block-pvc-scanner:beta-v0.1.1",you can pulling that from docker hub
or build it from brache 'beta-v0.1.1'.

It's getting better.
In block scanner i've got some values:
curl localhost:8848/metrics
pvc_usage{volumename="gke-data-bd2c320a-dyna-pvc-6b0f9f4c-8d42-11ea-bc86-42010a80019b\n"} 0.01
pvc_usage{volumename="gke-data-bd2c320a-dyna-pvc-88516e02-9ae2-11ea-9512-42010a8000f0\n"} 0.01
pvc_usage{volumename="gke-data-bd2c320a-dyna-pvc-9c96e158-0638-11eb-ac6a-42010a80000e\n"} 0.14
pvc_usage{volumename="gke-data-bd2c320a-dyna-pvc-9c97c32f-0638-11eb-ac6a-42010a80000e\n"} 0.01

But pvc_mapping is still empty ;(

Logs from pvc-mapping pod contains this:
PVC: data-redis-redis-ha-server-1, VOLUME: pvc-1dcd062b-bb2a-11ea-9512-42010a8000f0, POD: redis-redis-ha-server-1
PVC: data-redis-redis-ha-server-2, VOLUME: pvc-299ea6c3-bb2a-11ea-9512-42010a8000f0, POD: redis-redis-ha-server-2

I think I found problem of scrapping. I'm trying to fix this now.

Both metrics exist now.

Problem is in this query now

This caused by volumename not match between pvc_usage and pvc_mapping. I have updated the code for block-pvc-scanner, you can download the image "dockerid31415926/block-pvc-scanner:beta-v0.1.1" again or build it from brache 'beta-v0.1.1'.

Hi kais271,
What about: /var/lib/kubelet/plugins/kubernetes.io/flexvolume/oracle/oci/mounts/ocid1.volume.oc1.eu-frankfurt-1.
How should be the scanner.py, specially the line 14  elif re.match ? Will this work when pvc_usage ?
Thank you.

Hi kais271,
What about: /var/lib/kubelet/plugins/kubernetes.io/flexvolume/oracle/oci/mounts/ocid1.volume.oc1.eu-frankfurt-1.
How should be the scanner.py, specially the line 14 elif re.match ? Will this work when pvc_usage ?
Thank you.

@andikercuku  The rex is used to get below data.

yes understand, so the get_pvc=os.popen("df -h|grep -E 'kubernetes.io/flexvolume|kubernetes.io~csi|kubernetes.io/flexvolume/oracle/oci/mounts'") and elif re.match("^ocid1.volume.oc1.eu-frankfurt-1",v):
Is this ok ?

yes understand, so the get_pvc=os.popen("df -h|grep -E 'kubernetes.io/flexvolume|kubernetes.io~csi|kubernetes.io/flexvolume/oracle/oci/mounts'") and elif re.match("^ocid1.volume.oc1.eu-frankfurt-1",v):
Is this ok ?

@andikercuku I think it will be ok. or, just  re.match("^ocid",v).

Hi kais271,
What about pod crash with this error:
File "./pod-pvc-mapping.py", line 23, in <module>     for vc in p['spec']['volumes']: TypeError: 'NoneType' object is not iterable

Hi kais271,
What about pod crash with this error:
File "./pod-pvc-mapping.py", line 23, in <module> for vc in p['spec']['volumes']: TypeError: 'NoneType' object is not iterable

@andik101 I think it's cased by no data in p['spec']['volumes'],you can add a 'print(p)' to debug, like below.


Add new constructor AsyncUnaryCall et al with Func<Task> for headers

AsyncUnaryCall (and the other call objects) have constructors that look similar to this:
public AsyncUnaryCall(
    Task<TResponse> responseAsync,
    Task<Metadata> responseHeadersAsync,
    Func<Status> getStatusFunc,
    Func<Metadata> getTrailersFunc,
    Action disposeAction)
{
}

The problem here is Task<Metadata> responseHeadersAsync is not lazy. Even if ResponseHeadersAsync is never awaited, a task that returns a metadata collection is always run. This is fine for Grpc.Core because a Metadata collection is always created, but Grpc.Net.Client is doing extra work for no reason.
A solution would be to add constructor overloads to the call objects that take Func<Task<Metadata>> responseHeadersAsyncFunc. Now the task can be lazy. It will only created be created and run if someone accesses the ResponseHeadersAsync property.
public Task<Metadata> ResponseHeadersAsync => responseHeadersAsync ??= responseHeadersAsyncFunc();

Would be fixed by https://github.com/grpc/grpc/pull/19609

I'm in the process of reviewing #19609

Replaced by https://github.com/grpc/grpc/pull/21365


chore(ci): Configure Wasm build pipeline

Closing in favor of https://github.com/dudykr/stc/pull/1082


how to access the HTMLElement of Button?

i'm trying:
<Button use:xxx on:click={more}>more...</Button>
and xxx() is called with what seems to be an empty object.
i'm trying:
<Button bind:this={my_button} on:click={more}>more...</Button>
and whatever my_button is set to, calling blur() on it (a HTMLElement method) has no effect.
To the contrary, with:
<button bind:this={my_button} on:click={more}>more...</button>
i can call my_button.blur() and it correctly removes focus from the element.

For what it's worth I'm interested in this because I want to call focus and blur on  components to enable inline editable components composed of a  when in uneditable mode and a sveltestrap  when in edit mode. When the span is clicked the component hides the span and shows the Input but I want to then focus that input so I need a reference to that element even though it's not the element that received the event (so I can't use event.target.focus())

Hi @christo ,
We just added a solution for Input (#298) which was released in v5.1.0, but I think the same approach will work for Button and will look to add this week.

Added in #303, should release soon

Hi, this is released in v5.1.1
Please reopen or comment if you see any issues.


Work around typst cli bug

https://github.com/typst/typst/issues/1937

It makes me slightly uncomfortable to add a quick fix like this for something that clearly should/will be resolved upstream. However, since that issue actually does create a problem... I'll open a new issue for us to remove this once it's been properly fixed.
Thank you for the help!


Dear author, how to generate the label? thx where is the "generate_label" script in the dir?

where is the "generate_label" script?

I also couldn't find the script of  "generate_label.py" in Label Generation, is this the same file as cross_view_transformers/scripts/generate_data.py?

nuscenes_dataset_generated.py?

Hello,
As @Bosszhe says, is the file generate_data.py
Just change the command to:
python3 scripts/generate_data.py
    data=nuscenes \
    data.version=v1.0-trainval \
    data.dataset_dir=/media/datasets/nuscenes \
    data.labels_dir=/media/datasets/cvt_labels_nuscenes \
    visualization=nuscenes_viz


[#13] Extend CI to publish update-site

use correct trunk name

I would hold this one until we are close to publish the first version. Otherwise we will pollute the repo with a lot of intermediate content.

Ar maybe we just try it to determine if it works at all and then unplug in a more elegant way?


Add post-release blog article about changes to Pod resources API

I'm intentionally covering multiple related enhancements with a single blog post.
Enhancements:

https://github.com/kubernetes/enhancements/issues/606
https://github.com/kubernetes/enhancements/issues/2403
https://github.com/kubernetes/enhancements/issues/3743

/hold
I mis-clicked and did NOT upload as draft ( :( ) so WIP+hold to prevent merge

/assign @onlydole

sorry for too early assign, my bad.

/unassign @onlydole
just way too early

/retitle [WIP] Add post-release blog article about changes to Pod resources API

Hi Comms here for Release 1.28 we are checking in to see if you are going to complete this blog as it is due..?

Hi Comms here for Release 1.28 we are checking in to see if you are going to complete this blog as it is due..?

Hi, I'll be working on this blog post this week (week ending August 4)

the PR is now content-complete

/cc @SergeyKanzhelev
Could you PTAL if you have time? I'd greatly appreciate your feedback

/hold
need to fix the recommendations about the client package

/hold cancel
In the last upload I made few minor fixes. I was looking for a good example of a client package, but I'm not yet in a position to recommend any, so I'm leaving this out from this blog post. The important part is that we really need to emphasize that reimplementing the client in a consumer project is still the recommended approach (!!!!), but this was already fixed in the past days.

/hold
Let's not merge this until v1.28 is released. OK to unhold once that has happened.

LGTM for blog team.
/approve

/hold cancel


Extend integration tests for coredump/backtrace

This just adds to work done in #1307
Resolves #1317

@iapaddler gave me his review comments directly.  We're choosing leave the SIGUSR2 handling (in our interposed sigaction() function) alone.  I agree that the unit test for SIGUSR2 isn't the correct one for SIGUSR2, so I'm backing it out.  Since I've resolved these review comments, I'm whacking merge.


chore: update test-harness & fix evaluation integration tests

This PR

Absorbs gherkin test changes.
Related Issues

Notes

Follow-up Tasks

How to test

Codecov Report

Merging #357 (b217e9c) into main (0e81b6c) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #357   +/-   ##
=======================================
  Coverage   99.67%   99.67%
=======================================
  Files          15       15
  Lines        1236     1236
  Branches       97       97
=======================================
  Hits         1232     1232
  Misses          4        4

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


computed_fields have inconsistent behaviour between model_dump and model_dump_json (part 2)

Initial Checks

[X] I confirm that I'm using Pydantic V2

Description
Was validating the changes made from https://github.com/pydantic/pydantic/issues/8250 and encountered a new issue.
The code submitted as a reproduction in the prior issue now works, so I've increased the complexity by one notch to reproduce a different failure. @sydney-runkle tagging you simply because you were so responsive on the prior issue and Im assuming this will have a similar fix :)
Importantly, the print output agrees between the two methods if you remove the computed function, or move it after y_is_none
I believe the issue is here: https://github.com/pydantic/pydantic-core/pull/1098/files#diff-9d4853412aaf93703485a5ed7c50c373184ec151d1d480a109e52430fedf9ca8R78
Where the code returns after the first None computed field, instead of simply moving onto the next field to check if it is None.
Example Code
from pydantic import BaseModel, computed_field

class Example(BaseModel):
    x: int
    y: int | None

    @computed_field
    def computed(self) -> None:
        return None

    @computed_field
    def y_is_none(self) -> bool:
        return self.y is None

if __name__ == "__main__":
    e = Example(x=1, y=None)

    print(e.model_dump(exclude_none=True))
    # {'x': 1, 'y_is_none': True}

    print(e.model_dump_json(exclude_none=True))
    # {"x":1}

Python, Pydantic & OS Version
pydantic version: 2.6.0
        pydantic-core version: 2.16.1
          pydantic-core build: profile=release pgo=true
                 install path: /home/sam/arenko/trade-selector/.venv/lib/python3.11/site-packages/pydantic
               python version: 3.11.4 (main, Jul  4 2023, 13:46:25) [GCC 11.3.0]
                     platform: Linux-<IP_ADDRESS>-microsoft-standard-WSL2-x86_64-with-glibc2.35
             related packages: typing_extensions-4.9.0 fastapi-0.109.0 mypy-1.8.0 pydantic-settings-2.1.0
                       commit: unknown

@Samreay,
Thanks for bringing this to our attention! Indeed, looks like this should be a pretty easy fix in pydantic-core.
Would you like to open a PR there with a fix, and we can get that change into our upcoming patch release of pydantic?

@Samreay,
I went ahead and opened that PR in core. I've verified that with the changes, here's the behavior in pydantic:
from pydantic import BaseModel, computed_field

class Example(BaseModel):
    x: int
    y: int | None

    @computed_field
    def computed(self) -> None:
        return None

    @computed_field
    def y_is_none(self) -> bool:
        return self.y is None

if __name__ == "__main__":
    e = Example(x=1, y=None)

    print(e.model_dump(exclude_none=True))
    # {'x': 1, 'y_is_none': True}

    print(e.model_dump_json(exclude_none=True))
    # {"x":1,"y_is_none":true}

See the core PR here: https://github.com/pydantic/pydantic-core/pull/1187


[Bug]: Empty test suites fail with "--passWithNoTests" CLI option set

Version
29.6.2
Steps to reproduce

Add a single test suite like this:

import {test} from "@jest/globals";

const externalCondition = false;

if(externalCondition) {
    test("this is skipped", () => {
        expect(false).toBe(false);
    })
}

run jest --passWithNoTests

Expected behavior
Successful execution, with output like this:
Test Suites: 1 passed, 1 total
Tests:       0 total

Actual behavior
Failed execution, this is the output:
Test Suites: 1 failed, 1 total
Tests:       0 total

Additional context
We are skipping tests based on external conditions (e.g. environmental variables) and sometimes it results in tests suites that are empty. --passWithNoTests does not work in this case.
Environment
System:
    OS: Linux 5.15 Ubuntu 20.04 LTS (Focal Fossa)
    CPU: (12) x64 AMD Ryzen 5 PRO 5650U with Radeon Graphics
  Binaries:
    Node: 16.13.0 - ~/.nvm/versions/node/v16.13.0/bin/node
    Yarn: 1.22.19 - /usr/bin/yarn
    npm: 8.1.0 - ~/.nvm/versions/node/v16.13.0/bin/npm
  npmPackages:
    jest: ^29.6.2 => 29.6.2

The documentation states that with the --passWithNoTests flag Jest will pass "when no files are found". If test files are selected, this flag has no effect.
For example, you could try selecting test files for a run conditionally using the testMatch config option.

@mrazauskas: ah reading comprehension on my end, sorry. Should have been a feature request not a bug report :)
We are testing a multi-tenant application and developed a system similar to gherkin/cucumber where we tag tests and they can be conditionally excluded them from being executed. e.g.
tag("@A @B")
test("A and B", ()=>{})

tag("@A @C")
test("A and C", ()=>{})

tag("@C")
test("C", ()=>{})

One can then execute specific tests by using a filter like @A or @C and not @B - this would run the 2nd and the 3rd test in the tests suite above.
The options you listed are unfortunately sub-optimal for our use case.

testMatch is not as flexible as cucumber filter expressions;
.skipped tests appear in reports.

Hm.. but semantically those are skipped test cases.
For example, if you would use .only the skipped cases are reported as skipped. I just try to show that this is not connected with the .skip modifier directly. Jest simply tells that some test cases in a test file were not executed. This is what I see in your example. Somehow it does not feel right to hide this information.
You can try to play with a custom reporter. For example, vscode-jest extracts test run result using custom reporter.

The correct option that would do a similar thing (conditionally executing tests) would be --testNamePattern, not --testMatch. It still shows tests as skipped, but does not fail the whole execution if there are 0 found tests in some test suite (file). From my example above, running jest --testNamePattern="X" (purposely matches 0 tests) produces this output:
Test Suites: 1 skipped, 0 of 1 total
Tests:       3 skipped, 3 total

and no other errors.

That’s right. --testNamePattern selects test cases by name, runs them and marks / reports all others as skipped. If all test cases in a file (or in other words, a test suite) are skipped, that file / suite is reported as skipped.
If you add .skip modifier to all test cases in a file manually or conditionally via some helper, the file will be reported as skipped.

does not fail the whole execution if there are 0 found tests

In the output you provided three test cases were found and reported as skipped. This is not the same as "0 found tests".

Yeah, you are of course right. I will change the helper to call the corresponding .skip functions instead of stripping out the call completely, and look into custom reporters. Thanks for help!


Add functions to compute genes where variants should be flagged

Currently, in the gnomAD browser, the "LC LoF" and "LoF Flag" flags are shown for a variant only if all the variant's transcript consequences are not HC or flagged, respectively.
@konradjk pointed out that on the gene and transcript pages, these flags should be based only on the variant's consequences in that gene or transcript.
https://macarthurlab.slack.com/archives/C02A348ML/p1542398082164000
Based on a variant's sorted transcript consequences, these functions compute the set of gene IDs where the variant should be flagged.

It looks like you added a couple functions but don't call them anywhere. is that on purpose?

Yes, it was intentional. They'll be called in the gnomAD browser's variant loading pipeline.
https://github.com/macarthur-lab/gnomadjs/blob/master/projects/gnomad/data/shape_gnomad_r2_1_for_browser.py


Use crates from RustCrypto org instead of rust-crypto

The following crates should cover all required functionality: sha2, ripemd160, hmac.

I think we may end up wanting our own rust-bitcoin/hash-utils repo or something like that, as we'll likely want to steal some fun things like the optimized double-sha256-64-bytes functions from Bitcoin Core to optimize merkle tree building and the like: https://github.com/bitcoin/bitcoin/blob/4437d6e1f3107a20a8c7b66be8b4b972a82e3b28/src/crypto/sha256.cpp#L577
We may want to use RustCrypto for ripemd160 and hmac, but unless they're more optimized or have fixed bugs from rust-crypto, why bother moving from something stable (as in unmaintained so will never change) to something being changed, at least for crypto implementations?

Reasons which I can name are:

significantly smaller dependency size, and as a consequence compilation time will be faster as well
no_std and wasm friendliness
completely pure Rust (if asm feature is not used)
additional optimizations (e.g. asm feature today, or utilization of Intel SHA intrinsics in future)

And if you are worried about changes, you always can pin crates to exact versions.

Yea, if/when we actually switch to something else we probably want to wrap it so that we can drop in our own asm when we want to optimize merkle tree. Note that one drawback of RustCrypto compared to rust-crypto is the use of an external "constant_time_eq" crate dep, which I'm skeptical LLVM won't optimize down to not-so-constant-time-eq https://github.com/cesarb/constant_time_eq/blob/master/src/lib.rs#L16
That said, its probably better than the one in rust-crypto, which doesn't build on anything except ARM and x86.

You always can check assembly, I've also checked MacResult behaviour with ctgrind and it didn't reveal any problems.

In C it looks like folks mostly mark things as volitile, which at least forces the read/writes-to-tmp-var to happen, which should be a pretty significant improvement, even if also not a guarantee. Mostly I can't find any documentation for LLVM IR NoInline handling if you do an LTO (or some profile-guided optimization or something) pass.

While subtle is probably better-maintained it looks like it does roughly the same thing under the hood (except instead of just XORing at the byte level it shifts down to one bit) but without the inline(never) until its done, and with an inline on the actual operation function, which seems much less general-purpose than you'd probably want, depends on how conservative you want to be, I suppose.

I've created a new crate which is sufficient for our purposes https://github.com/rust-bitcoin/bitcoin_hashes and depends only on byteorder (which rust-bitcoin also directly depends on, and which is small/simple enough I'm happy to just review it and keep it forever as a dep).
I'm not really concerned about constant-timeness for hashes. They're inherently branch-free (well, HMAC has a branch on key length, but key length is typically not a secret), use addition and bit-ops rather than multiplication or division, and within a few rounds (i.e. a few cpu cycles) they tend to completely scramble any secret input anyway.

@apoelstra
Well, if you prefer NIH, then it's an approach to take. Though, from the ecosystem development point of view (i.e. distributing maintenance burden, focusing development efforts, providing more eyes to inspect source code), I don't think it's the right approach. Plus if downstream crate will depend on RustCrypto crates and bitcoin we will get code duplication.
Feel free to close this issue if you'll decide to go with bitcoin_hashes.

When the Rust ecosystem stops including random extraneous dependencies, breaking things in minor releases, and being unable to compile on Debian's compiler, I will stop "NiH"ing functions that have been standardized for decades and have no need to ever change or use bleeding-edge language features or generic arrays or what have you.
BTW RustCrypto's hash library does not compile with rustc < 1.20, even with all features disabled, because it depends on multiple things that depend on block-buffer, which depends on generic-array, which depends on typenum, which uses associated constants.

RustCrypto crates are very strict in their versioning. Breaking changes (even if it's minimum supported Rust version bump) are done only with minor version bump, plus crates are CI tested against declared MSRV. When we'll finally get const generics new 0.x+1 crate versions will be published, thus crates with 0.x version constraint will not be broken. There was only a single case when these promise was broken, I've intentionally removed a buggy VariableOutput trait implementation from a crate to communicate issue to users.
If you really want to support Rust 1.14, then it's a valid reason to use your NIH implementation. Though I personally don't see much reason in doing it, as the mentioned Debian AFAIK packages Rust 1.24.

Thanks very much for your commitment to responsible dependency usage. Sorry for implying otherwise.
Unfortunately Debian stable ships 1.14.0 on arm64 and i386. Only on x86_64 do they have 1.24.

rust-bitcoin will probably also want weird bitcoin-specific things like highly-optimized-double-sha256-of-two-32-byte-buffers so I think it makes sense to forge our own way anyway.

One weird bitcoin-specific-thing we already have is a Sha256dHash type whose user-visible serialization is hex-encoded in reverse order. :upside_down_face:

Well, having bitcoin-specific part does not mean you need to write your own implementation of several algorithms. Plus I can expose via feature gate compress function which in future will support hardware acceleration. But honestly I don't think you'll get a win bigger than several comparisons.

It seems to shave quite a bit off in hash-heavy stuff, see https://github.com/bitcoin/bitcoin/pull/13191 (specifically the varsize -> size64 naive/1way benchmarks there).

Of course I was talking about general non-SIMD case. :)

The benchmarks I was referencing were both non-SIMD.

I don't know what you had behind "naive" code (and don't have desire to look into it), for that I know it could've been sub-optimal. In case of sha2 if you process two 32 bytes blocks you will not get wasteful copies, so overhead will be equal to zeroing out 32 byte buffer on stack and to several ifs. I guess the main win will be from usage of constant padding block.

rust-bitcoin will probably also want weird bitcoin-specific things like highly-optimized-double-sha256-of-two-32-byte-buffers so I think it makes sense to forge our own way anyway.

Well that isn't a valid reason to reimplement all hash algorithm that rust-bitcoin uses, only a new hash algorithm is implemented for that use case without rewriting all of them.

One weird bitcoin-specific-thing we already have is a Sha256dHash type whose user-visible serialization is hex-encoded in reverse order.

That's not a much of a problem, the Sha256dHash could still exist and SHOULD be constructed from the output of the hash functions, probably the hash functions found in RustCrypto organization. Anyway newer types for that exact purpose can be created e.g. ReversedSha256d, or newer methods e.g. reversed_str, etc.
I think this crate shouldn't suffer from the NIH syndrome, RustCrypto crates are very small and can be easily reviewed. I have been reading the bitcoin_hashes project source code and the first thing I noted is that it isn't compatible with the digest crate that is becoming the de facto standard for hash functions.
PD: Sha256dHash type name is too long, H256 is sufficient, the same for Uint256, U256 is sufficient, but this is content for another discussion in another issue, parity-bitcoin uses this approach and it seems they are doing well with that without too much hassle.

@apoelstra

Unfortunately Debian stable ships 1.14.0 on arm64 and i386. Only on x86_64 do they have 1.24.

I think I've seen you mention this many times already as a root of the problem. It seems to me that it would be easier to just accept that at least at the current state, distribution provided rust compiler binaries are going to be constantly stale, for years to come, and are therefore not very usable for project under active development. Rust is just not yet 50 years old and the roadmap is clear: new feature will be introduced every release, and people/projects will want to use them.
I am not sure what exactly are yours and other potential devs/users goals, but whatever they are, maybe it would be easier to adapt the rustup workflow and maintain and test against minimal supported version, that would (out of necessity) roll forward continously (but just not too fast).

Whatever users does rust-bitcoin have and will have in the future, they have implicitly accepted that they are using a language under active development, with a relatively immature ecosystem, and they will have to pay the price, by having to deal with changes. rustup, cargo and other tooling is there to help everyone.

Of course it's not compatible with digest, digest does not compile for me and it also has a nontrivial dependency tree.
My target users are people who care about being able to build their projects deterministically, vendor their dependencies and review the code that they've vendored. Rust is perfectly capable of supporting that, and I see no reason to introduce random dependencies on projects that undermine my ability to do so.
A language that hit 1.0 three years ago now is not "under active development" to the point where all of its users must be constantly updating their toolchains by replacing unsigned binaries with other ones. It would be obnoxious to require that, and it reflects poorly on the Rust community that there are such large portions of it who seem to think otherwise.

I think Andrew's point here was that there are projects that use rust-bitcoin in production and would like to use stable Debian and similar distros because they're stable and for a security-critical server and product that's pretty much ideal. Thus, accepting a newer rustc requirement would absolutely screw over some users. Other rust-bitcoin projects have later rustcs because they don't have this issue.
On August 9, 2018 8:20:34 PM UTC, "Dawid Ciężarkiewicz"<EMAIL_ADDRESS>wrote:

@apoelstra I am not specifically talking about digest here. It is, of
course, great to minimalize dependency tree, and decisions like this
have to be done on case by case basis. All I'm talking about is "Debian
Stable" argument.
1.0 is a statement of semantic versioning, not "being ready" for any
specific purpose or ceasing active development.  Considering how small
Rust stdlib is, and how much of important things (like serialization),
just recently reached 1.0 versions, it still a "language in progress".

all of its users must be constantly updating their toolchains by
replacing unsigned binaries with other ones.

I'm not advocating that. You're jumping from one extreme to the
other. There is a middle ground that is neither:

imparing interoperability by forcing use of 2 year old release,
"because Debian"
forcing users to update to each new release via rustup

Eg.Debian and other users can still install, checksum , verify, etc.
some blessed rust version that isn't 2 year old, even provided in a
deb package for them. You could estabilish a policy of providing a
blessed version on a yearly basis, and sticking to it for the following
year etc.

It would be obnoxious to require that, and it reflects poorly on the
Rust community that there are such large portions of it who seem to
think otherwise.

No need to get upset. :)
--
You are receiving this because you commented.
Reply to this email directly or view it on GitHub:
https://github.com/rust-bitcoin/rust-bitcoin/issues/98#issuecomment-411884305

I think Andrew's point here was that there are projects that use rust-bitcoin in production and would like to use stable Debian and similar distros because they're stable and for a security-critical server and product that's pretty much ideal.

I understand that, and I think it would be wonderful if they could build as much code as possible using rustc that comes with it. Similarly with any other Linux/OS distribution. I am not saying that anyone should rush to force others to update compiler. I to understand the value of stability/compatibility with older versions. The oldest rustc that can be supported, the better.
But if it comes in conflict with keeping up with Rust ecosystem, I think it would be better to ask these users to update their compiler, maybe helping them to find a way that would be a compromise between their security goals / convenience, and active development needs.
Most Rust projects (and many are used in production for important projects), maintains a minimal supported version, that gets bumped from time to time. I just think, at current state of Rust, a 1 year old compiler version is more reasonable that almost 2 years.
I'm not a Debian user, but I don't think there was anything magical about 1.14, and Debian maintainers are preparing new updates:
https://packages.debian.org/search?keywords=rust&searchon=names&suite=all&section=all
If I read it correctly, there is even 1.24 for amd64:
Package rustc

    stretch (stable) (rust): Rust systems programming language
    1.24.1+dfsg1-1~deb9u2: amd64
    1.14.0+dfsg1-3: arm64 i386

Are there any miscompilation bugs in Rust 1.14? If not, why should they be required to upgrade when part of their security-critical system depends on it? What if they've already done review of parts of it (I don't know if they have, but they might have), why should they be required to spend the time and money to review it again?
Are there any bugs in rust-crypto? Aside from possible performance improvements, what are we gaining by switching hash function implementations? Personally, I'd much much rather use a completely unmaintained and unupdated hash function implementation than one that is changing, at least for security-critical software, if that means copying an existing implementation into our own repo (with appropriate attribution), even better.

You are welcome to fork the project and require your users upgrade their compilers whenever one of your dependencies requires it, and to even deliberately include dependencies maintained by people who like to do this.
This project has actual users who are funding development, including myself, who have complained about the difficulty of reliably obtaining a toolchain, dealing with neverending lists of dependencies, vendoring said dependencies, auditing updates of them, fighting with cargo whenever minor releases break compilation, etc.
We are not going to break things for these users. Nobody has given a good reason to do so. We have a long-stated policy of minimizing dependency trees and maintaining compatibility with 1.14.  Some users have complained about breakage due to unnecessary dependencies in rust-crypto (see #96). It is obviously not a solution to replace it with another project full of unnecessary dependencies which cause breakage.
Matt and I both have many years' experience writing high performance high-assurance cryptographic software. I think we can handle implementing a couple of mathematical functions that are all over a decade old.

I think it's a fair game. Some people need this to compile on Stable Debian, or whatever else requirements, security policies or preferences they have, pay for etc. No hard feeling. However, the other arguments don't really convince me, and @newpavlov said exactly what I think.

Matt and I both have many years' experience writing high performance high-assurance cryptographic software. I think we can handle implementing a couple of mathematical functions that are all over a decade old.

With all due respect, I think this is an attitude from a C/C++ land, where everybody is afraid to change a single line of code anywhere because it might explode, shared code is scarce and cooperation is rare. It ignores both the state of Rust as an immature language and its cooperation-inducing features.
While I do see some merit there, I don't think it works for Rust ATM, (somewhat regrettably) and I would rather use (and potentially contribute to) a fork that integrates well with the ecosystem, instead of the one that will always be potentially a hindrance to integrate with other code.  Business-wise, I would rather pay for reviewing shared code, and use locking for ensuring security, than maintain own, potentially hard to upgrade code.
But I fully acknowledge that I'm mostly just leaching on somebody elses work (which I am thankful for) so I'll show myself the door now. :)

@apoelstra I don't want to get into the discussion, just making sure you're aware:
https://medium.com/@shnatsel/how-rusts-standard-library-was-vulnerable-for-years-and-nobody-noticed-aebf0503c3d6


renderSeries is called when updating graphic component

Version
4.4.0
Reproduction link
https://jsfiddle.net/w6yjs3ax/
Steps to reproduce
If there are a lot of series on chart the cost of updating the graphic element is too big.
Instead of render a single shape it also renders all series from scratch.
It happens when using chart.setOption({ graphic: ... }) method.
What is expected?
renderSeries isn't called
What is actually happening?
renderSeries is called

renderSeries is not supposed to be called if there is only graphic being updated. We will look into this issue.

@pissang Could you say when you will be able to look into this issue?

Probably in the version 4.9.0. Before the end of next month.

@pissang  any updated?

@ezubarev Sorry for the late reply. But we need to reschedule it to the 5.0


Help running Demo Application using Jaegar profile

Hi,
As per instructions of running your demo Application for Ocelot agent, I could start them using docker-compose on my Ubuntu 16.04.
But after sometime the - Petclinic Application is not available at port 8080.
It goes down. Please guide how to resolve this.
So, I cannot test the demo.
Also, please provide default userid and password for Various UIs.

Grafana Dashboard UI - what user/password to use
Config Server UI - what user/password to use

Regards
Arabinda

Hello @parabinda
the passwords for Grafana and the Configuration Server are listed in the documentation. For all components, the username is admin and the password demo.
It's hard to say why the demo is not running on your machine. Ensure that enough memory is available because the demo starts a lot of containers. Especially when using Docker for Windows or Docker for MacOS, the default settings does not provide enough memory for the Docker VM.
Another possible problem could be that some container are waiting for each other. In case their dependencies are not started within 2min, they will failling. You can increase this timeout by modifying the timeout=120s  parameter in the docker compose file.


Some corrections on the stats printer and PEP-0008

Made the code PEP-0008 compliant and optimized the stats printer to avoid printing unnecessary white spaces.

As seen in the selection on the screenshot the lines on stat have no extra selectable spaces after.

Hi! Thanks for the work :)
Would it be possible to do the PR without the pep8 changes? Most of the violations of pep8 where for readability, and the changed versions are mostly less readable (pep8 itself states that readability is a good reason to violate pep8, hehe).
The white spaces at the end of the stats are something strange. It sounds like someone did it on purpose, but I can't figure out why. Where you able to figure it out? Did you run some games to see if that change made things different in any way?

Ok, I'll be separating commits that make the PEP-008 changes (it's just the first one, although some of that was used in the further commits), but not without trying con convince you first :-) Which are the modifications you fell make the source less readable? Perhaps when printing some of the string templates calling .format() at the end, because the string object becomes too long and leads the method to a new line when breaking it. I think that if the string is too long it becomes unreadable anyways, even without calling .format() at the end, and needs to be chopped of (I usually program with Vim not folding long lines). If, for readability, we decide that folding lines is better, in vim becomes quite annoying trying to edit reaching the middle of the line of example.  Thats my case, but I think long lines bother all the time and not necessarily add readability.
Most of the if clauses I split into two or more lines I tried to keep the precedence of operators when breaking them (except for one case on utils.py I've just discovered :-/), so it should improve readability after all.

Speaking of the spaces after each stat line, on the stats printing in terminal.py, I think was made like that because when a stat becomes shorter (when HP decreases by one order of magnitude, or after a Hero re-spawning changing his HPs from "dead" to "100") leaves printed the last character (for example the last parenthesis enclosing author's bot), I figured that out having lines the exceeded the predefined length (Heroes with long enough name and long enough author name) where that patch wasn't enough.
Printing extra white spaces ensures only spaces are left behind, which won't bother if your terminal is wide enough, but could make the line fold on white spaces when the terminal is narrow :-/ My approach was to write only one space after (just one was needed, because HPs won't decrease on more than one order of magnitude and the only Thing that re-spawn with full life are Heroes changing his HPs from "dead" to a number, unless a Hero re-spawns with two or less digits' HPs that case is covered) and deleted after having the non white character overwritten.

better late than ever ;)


Add selectable default map provider

To make the life of the user easier, we should add default map providers via a select-property, along with the tile-url field.

check licenses/usage terms and make them transparent
some potential overviews:

https://wiki.openstreetmap.org/wiki/Tiles#Servers
https://github.com/DenisCarriere/map-providers
https://openmaptiles.org/
https://github.com/osmdroid/osmdroid/wiki/Map-Sources
https://wiki.openstreetmap.org/wiki/Slippy_map_tilenames
https://www.trailnotes.org/FetchMap/TileServeSource.html
https://en.wikipedia.org/wiki/Tiled_web_map

Non exhaustive list:

TomTom (check for free default trial key and license)
google
bing
is there a (truly) free satellite map providers?

Potentially free usage/license (to be checked)

"OpenStreetMap": "https://a.tile.openstreetmap.org/${z}/${x}/${y}.png"
"OpenStreetMap Germany": "https://a.tile.openstreetmap.de/${z}/${x}/${y}.png"
"OpenStreetMap France": "http://a.tile.openstreetmap.fr/osmfr/${z}/${x}/${y}.png"
"Humanitarian Focused OSM France": "http://a.tile.openstreetmap.fr/hot/${z}/${x}/${y}.png"
"WikiMedia OSM": "https://maps.wikimedia.org/osm-intl/${z}/${x}/${y}.png"
"WMFLabs Hike Bike": "https://tiles.wmflabs.org/hikebike/${z}/${x}/${y}.png"
"WMFLabs B&W Mapnik": "https://tiles.wmflabs.org/bw-mapnik/${z}/${x}/${y}.png"
"WMFLabs OSM No Labels": "https://tiles.wmflabs.org/osm-no-labels/${z}/${x}/${y}.png"
"Stamen Toner": "http://a.tile.stamen.com/toner/${z}/${x}/${y}.png"
"Stamen Water Color": "http://c.tile.stamen.com/watercolor/${z}/${x}/${y}.jpg"
"Thunderforest Cycle": "http://tile.thunderforest.com/cycle/${z}/${x}/${y}.png"
"Thunderforest Transport": "http://tile.thunderforest.com/transport/${z}/${x}/${y}.png"
"Thunderforest Landscape": "http://tile.thunderforest.com/landscape/${z}/${x}/${y}.png"
"Thunderforest Outdoors": "http://tile.thunderforest.com/outdoors/${z}/${x}/${y}.png"
"MeMoMaps": "http://tile.memomaps.de/tilegen/${z}/${x}/${y}.png"
"Open Topo Maps": "https://a.tile.opentopomap.org/${z}/${x}/${y}.png"
"CartoDB Light": "https://cartodb-basemaps-a.global.ssl.fastly.net/light_all/${z}/${x}/${y}.png"
"CartoDB Dark":  "https://cartodb-basemaps-a.global.ssl.fastly.net/dark_all/${z}/${x}/${y}.png"

I don't think that there is any tile server provider that has a license that would allow us to ship them in this plugin. AFAIK Google doesn't allow to use their URI at all and OSM restricts its usage to loading one tile per second or something like this. I also haven't checked the license of a lot of provides, so idk, maybe there is actually a provider that we could use.

@dseifert any hints/ideas on that?

I just checked a few providers and all of them prohibit us to use them:

OpenStreetMap
From https://operations.osmfoundation.org/policies/tiles/:

Heavy use (e.g. distributing an app that uses tiles from openstreetmap.org) is forbidden without prior permission from the Operations Working Group. See below for alternatives.

WikiMedia OSM
From https://foundation.wikimedia.org/wiki/Maps_Terms_of_Use:

The following are prohibited on the Wikimedia Maps service:

Excessive downloading (such as downloading significant areas of tiles for later offline usage)

Thunderforest
From https://www.thunderforest.com/terms/:

Registration is required before using any of our services.
Attribution must be given to both “Thunderforest” and “OpenStreetMap contributors”.

Even if there is a provider that allowed us to use them, there are more issues to tackle: When using default tile server we first need to satisfy their requirements (like showing their copyright in a corner of rviz) and second the GDPR. To satisfy the GDPR we would have to add some kind of privacy policy note at the very list (probably it's more complicated).
I think this is a lot of work for almost no benefit. Thus I'll close this.


Add UFRPE

Institution/School Name
{Universidade Federal Rural de Pernambuco}
Instiution/School Website
{ufrpe.br}
Email Users
<EMAIL_ADDRESS>Please place an x between the square brackets if yes
[x] Students
[x] Academic/Teaching Staff
[ ] Other/Support Staff
[ ] Alumni
[ ] Education Levels
Please place an x between the square brackets if yes
[x] Post-graduate research
[x] Graduate School
[x] College (University) or Undergraduate School or equivalent
[ ] Community College or equivalent
[ ] High School or equivalent
[ ] Elementary School or equivalent

@Biaducla ufrpe.txt: this request has an incorrect file path format, please ensure that you are familiar with     this repository rules located at the bottom of this page and change     your request accordingly. If you don't know how to change request, close it and open a new one.     If you are not able to make the pull request according the instructions, please send us an email to<EMAIL_ADDRESS>Please mention this request URL in the message.

@Biaducla ufrpe.txt: this request has an incorrect file path format, please ensure that you are familiar with     this repository rules located at the bottom of this page and change     your request accordingly. If you don't know how to change request, close it and open a new one.     If you are not able to make the pull request according the instructions, please send us an email to<EMAIL_ADDRESS>Please mention this request URL in the message.

@Biaducla ufrpe.txt: this request has an incorrect file path format, please ensure that you are familiar with     this repository rules located at the bottom of this page and change     your request accordingly. If you don't know how to change request, close it and open a new one.     If you are not able to make the pull request according the instructions, please send us an email to<EMAIL_ADDRESS>Please mention this request URL in the message.

@Biaducla ufrpe.txt: this request has an incorrect file path format, please ensure that you are familiar with     this repository rules located at the bottom of this page and change     your request accordingly. If you don't know how to change request, close it and open a new one.     If you are not able to make the pull request according the instructions, please send us an email to<EMAIL_ADDRESS>Please mention this request URL in the message.

@Biaducla ufrpe.txt: this request has an incorrect file path format, please ensure that you are familiar with     this repository rules located at the bottom of this page and change     your request accordingly. If you don't know how to change request, close it and open a new one.     If you are not able to make the pull request according the instructions, please send us an email to<EMAIL_ADDRESS>Please mention this request URL in the message.

@Biaducla Please confirm that email pattern for students and teachers is ufrpe.com, not ufrpe.br. If so, please provide us with a proof, which shows that the school recognizes the domain you are submitting as an official email domain for the students.

@Biaducla I am sorry, this request remains unanswered for a while. I have to close it without merging. Please reopen and comment if you have an update regarding the aforementioned issue. Thank you for the understanding!


.env validation for required vars, duplicates and regex matching

Description

Checking .env for duplicates https://github.com/adobe/aio-cli-plugin-app/issues/269
Existence of a duplicate will result in a message in the debug logs that can be seen using DEBUG=@adobe/aio-cli-plugin-app* aio app logs
Looking up in .env, cmd line args and process.env for required vars as defined in .env.schema if present
Look up is case insensitive
Validation of the variable values against regex if defined in .env.schema
Schema validation failure results in an error
Pending documentation

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] I have signed the Adobe Open Source CLA.
[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[x] I have added tests to cover my changes.
[x] All new and existing tests passed.

The technical debt argument on addition of a new file .env.schema by default through the default generator is a valid one.
While the tech debt cannot be nullified while adding a feature, I can think of two possible solutions here to minimize it.

Rename it to .app.schema since we are doing this only for the app plugin. It would still be a debt but only for the app plugin.
Do not put the file during app creation and make it's name configurable in .env via a variable say AIO_app_schemafile.
WDYT @purplecabbage @meryllblanchet @sarahxxu

Hi @Himavanth ,
I'd be for keeping things simple for the time being, especially that the initial request was about detection of duplicates.
What about dropping of the regexp matching for now? @sarahxxu wdyt?

We are now only doing the duplicate check. Since that is more common and we are only logging debug messages in case of duplicates, this PR will be closed in favour of https://github.com/adobe/aio-lib-core-config/pull/50.


Change cursor style

Describe the extension
This extension add an action for changing the style of your cursor.
Value can be :
default, pointer, help, progress, wait, cell, crosshair, text, move, grab, grabbing, not-allowed, zoom-in, zoom-out
List of all cursors can be found here :
https://developer.mozilla.org/fr/docs/Web/CSS/cursor
I've added the most important in description.
Checklist

[x] Extension has a proper name and description.
[x] Extension has tags (for example: "platform, brick, breakable").
[x] All behaviors have a description.
[x] All functions (actions, conditions, expressions) have descriptions.
[x] I confirm that this extension can be intergrated to this GitHub repository, distributed and MIT licensed.

Extension file
Extension_cursor.zip

Thanks! I've added this :)
Remember to always:

Use PascalCase for extension names. Don't include extension in the extension name. It's implicit.
Give a name to the function, even if there is only one. Games events will be stored using the function name.
Don't set parameters description that are too long. Prefer adding a longer description that will better fit on the UI.
No space before the ":" in English.
Put links to english documentation pages so that everyone can read them.

Apart from that, looks good. I made the fixes and added this 👍


Add formating option and fix locale

This pr adds formatting options for how it enters the text into the field and fixes the locale issues

@brianblakely


No source mappings for providers

From @golear91 on October 13, 2016 1:47
When debugging my Ionic2 application on an android device and connected via the Chrome Debugger, I see that the source mapping has nicely made my .ts files available for everything in the /pages folder however all of my services in the /providers folder are not available.

What gives?
when I debug using ionic serve i can see the /providers files in another form:

Copied from original issue: driftyco/ionic-cli#1529

Hi @golear91,
This issue was long since resolved. Please run npm install @ionic/app-scripts@latest. We're releasing<EMAIL_ADDRESS>tomorrow it has a ton of fixes, so go ahead and install that.
Thanks,
Dan

thanks!


Flow control buffer limits

Need a clarification with flow control.
We are using envoy proxy and we have some upstream which are actually slow, sometimes taking upto 22 seconds:
[2023-10-23T08:37:01.659Z] "POST /test.sl.EventDB.v1.EventDB/Create HTTP/2" 200 - 529 7 4006 4006 "-" "grpc-go/1.56.2" "77cab6b6-0638-430e-b59a-4c3b3029b3b5" "localhost:8887" "<IP_ADDRESS>:8080"
[2023-10-23T08:37:02.273Z] "POST /test.sl.EventDB.v1.EventDB/Create HTTP/2" 200 - 685 7 3392 3392 "-" "grpc-go/1.56.2" "f5042724-1468-41a8-b6d5-75a5af0370b7" "localhost:8887" "<IP_ADDRESS>:8080"
[2023-10-23T08:36:42.770Z] "POST /test.sl.EventDB.v1.EventDB/Create HTTP/2" 200 - 498 7 22895 22895 "-" "grpc-go/1.56.2" "5ae72910-3b33-4957-969d-731710bc3206" "localhost:8887" "<IP_ADDRESS>:8080"
In such a case envoy is buffering, resulting in out of memory.
In order to protect envoy we wanted to bring in flow control. The doubt is if we configure initial_stream_window_size and per_connection_buffer_limit_bytes to be less than the size of request, will envoy reject such requests?
For example: if I configure initial_stream_window_size as 1 MB and my request is 2 MB will envoy reject such requests?
Basically I dont want envoy to buffer, it should just forward the request to upstream without rejecting requests. Please give your valuable suggestions

Seems a dupe of https://github.com/envoyproxy/envoy/issues/30779


feat(parser): user defined value types

Resolves https://github.com/hyperledger-labs/solang/issues/746
Better suggestions on resolving ambiguity with type() builtin are welcome 😄

Perfect, thank you very much!

can we make a release after it's merged please? I want to incorporate these changes into Foundry's formatter 🙂

solang-parser 0.1.12 published, thank you!