Links in Contributing.MD file broken

Describe the bug
The links in the Contributing.MD file are broken, they seems to want to link to the Issues section, but are taking me to a 404 page.
To Reproduce
Steps to reproduce the behavior:

Go to https://github.com/abahmed/Deer/blob/develop/docs/CONTRIBUTING.md
Click any of the links in There are many ways to contribute:
Get 404

Expected behavior
A clear and concise description of what you expected to happen.
To take to Issues section on Github.

Working on this RN


Documentation: github org redirect caveat

This PR updates GitHub connector docs to notify users of our current workaround relating to #920. Part of the issue, users outside of the organization being able to log into dex-authenticated apps, was solved by https://github.com/coreos/dex/pull/1013.
Test cases for the above PR:

User not in a config org: fails
User in a config org but not in a config team: fails
User in a config org with no config teams: passes
User in a config org with no config teams, but already granted the app permission: fails <- issue
User in a config org and in a config team: passes

User in an org but not in any teams: fails

This should be, passes, right?
Also this diff conflicts with https://github.com/coreos/dex/pull/1018. Let's get that merged first.

@ericchiang updated test case descriptions to be more specific. If a user is in an org but not in any of the teams listed in the config, they should not get access.


Need a clarification why exactly the number 313

Hi,
I know that this is not the place for asking questions about the theory behind your research, but just I wanted to clarify the derivation of the number 313. I am trying to do a similar experiment on my own (https://github.com/preslavrachev/nn-photo-colorization), but I am approaching it from the ground up, basically setting up my own model and everything. I ended up reading your paper, and I got really interested in integrating some of your findings into my experiment. I understand the logic behind the ab space classification, but I can't exactly figure out why 313. Is this a heuristic you came up with, or is it something trivial that I'm just missing on?
I have to say, I am very interested to ML, but pretty new to the field, so please, excuse my ignorance, in case I have missed something extremely trivial.

hi@preslavrachev ,I try to give you my view.For RGB image,they get LAB image via color.rgb2lab() ,which L should be inside interval [0, 100], while A & B both inside [-127, 128].Then, they create gamut with 1010 bins based on condition that L=50.Consider convenience,assuming that A & B both start at -120 and end at 120,so each color channel has 25 discrete points,which are (-120,-110, ... , 0, ... , 110, 120).Now you see,313 actually is the result that 2525/2!!
But why the number 313 but not others?
I think 313 can fulfill the color needs while reduce compute cost.
BTW, All guess! welcome to debate.hah

I divide the ab gamut into 10x10 bins. However, in Lab colorspace, not all (a,b) values are actually used (aka "in-gamut"). You can see that in Figure 2b in our paper: https://arxiv.org/pdf/1603.08511.pdf. I keep the bins which are in-gamut.

Sorry ... I want to clarify. You mean  a(- 110 .. 110)/10 * b(-110..110)/10 = 484, and from 484 take 313 gamut included values. Am I right?


Install --purge-option?

We keep getting issues with old scrap, from previous versions of install scripts. I think we should have an install.sh --purge-option that will guarantee the removal of everything it has created.
So far, I think the only two "side effects"-folders we have are: ~/IncludeOS_build and ~/IncludeOS_install.

Since we now install to a single folder, just removing that folder is enough to fully uninstall, which is great. Closing this


Channel Subscriptions

The barebones version of this feature consist of the following changes:

[ ] A button on channel and file pages that allows a user to subscribe and unsubscribe to a channel.
[ ] User subscriptions are written and stored to local state (and optionally to api.lbry.io).
[ ] The landing page is modified to indicate recent content from subscribed channels.

Same issue -> https://github.com/lbryio/lbry-app/issues/715


Hide buttons in message header bar while editing topic

When a user is editing the topic inside the message header bar, we should hide the other buttons in the message header bar (resolve topic, mute topic) to minimize distractions/confusion.

CZO discussion

@zulipbot claim

I am unassigning myself since Andrew has already raised a PR for this

@zulipbot claim

@zulipbot claim

@zulipbot claim

I have unassigned as @Andrew1708 raised new PR.

I can't readily find the PR that did it, but I verified we completed this project (likely through a duplicate issue).


Error while installing moby-engine : Unable to locate package

Hi,
Following https://docs.microsoft.com/en-us/azure/iot-edge/how-to-install-iot-edge-linux , i am trying to install IoT Edge runtime on Ubuntu 16.04 LTS over raspberry Pi 3. I am seeing below error while installing moby-engine.
"E: Unable to locate package moby-engine"
I was able to perform all the steps w/o issues in the same version of Ubuntu over a PC.

Hi, there is more steps when arm is concerned -
try this link - https://docs.microsoft.com/en-us/azure/iot-edge/how-to-install-iot-edge-linux-arm


Flutter FFI plugin

Flutter's packages can be divided into 3 categories: Dart, Plugin, and FFI plugin.
https://docs.flutter.dev/packages-and-plugins/developing-packages#plugin-ffi
'FFI plugin' was introduced in Flutter 3.0. When a Flutter package is declared as 'FFI plugin' by modifying pubspec.yaml, Android NDK is automatically installed when other developers add the package as a dependency and compile the app. Therefore the dev users of this package don't need to install Android NDK manually.
https://github.com/flutter/flutter/pull/94101#discussion_r765682424
I confirmed that NDK is automatically being installed as expected in our package. Why don't we declare these packages as an 'FFI plugin' for the sake of cleaner README.md and easier integration?

I was not aware that ffi plugin installs NDK automatically. Thanks for the heads-up. This should definitely reduce the friction on Android.

Unfortunately this is not as straightforward. ffiPlugin doesn't really do anything. NDK is installed by gradle if the pugin build.gradle contains externalNativeBuild. In which case the build.gradle also needs to contain a ndk version.
There are some problems with this. externalNativeBuild requires either cmake or ndkBuild argument. cmake forces installing cmake (additional dependencies), while ndkBuild can have dummy makefile specified, but it requires at least ndk 24.0 to build on macOS/arm64.
What's worst is that after NDK installation the rest of plugin does not get access to ndkDirectory, only after gradle restarts (so first build fails with error).
Also this forces installation of NDK version specified in plugin, even if main project already contains newer NDK version. Which seems quite wasteful.
The biggest issue here seems to be that accessing android.ndkDirectory from the plugin fails right after installation.

I guess we can get around missing android.ndkDirectory by simply assuming it is ${android.sdkDirectory}/ndk/${version}. But in that case, I think it would be better to just have cargokit build tool install the NDK automatically.

I think this is going to be a better solution: https://github.com/irondash/cargokit/commit/7ce8af4aa69004ab960e60ccfb39941f16a8a740. I need to test it on windows though.

I tested it on windows and it works as expected:
INFO - Installing NDK 23.1.7779620...
Running Gradle task 'assembleRelease'...                          160.8s
√  Built build\app\outputs\flutter-apk\app-release.apk (49.4MB).

There's a regression however however and Rust versions newer than 1.68.2 can't build android binaries on windows: https://github.com/rust-lang/rust/issues/113711


added transition animation to social buttons and changed social butto…

…ns color for more unified design

hehe nice 🎆


Comment input loop

Type: Bug
Dear Microsoft, hello my friends.
i was testing about something in vue project. When i was testing i realized that in items features, when you want to comment something u can not comment it. I knew it wouldn't be done.  But i wanted to test it. When i tried with manually comment, it is going to loop.  İf you get contact with me, i can show you the problem
VS Code version: Code 1.74.1 (1ad8d514439d5077d2b0b7ee64d2ce82a9308e5a, 2022-12-14T10:30:51.966Z)
OS version: Windows_NT x64 10.0.19044
Modes:
Sandboxed: Yes

System Info

Item
Value

CPUs
Intel(R) Core(TM) i5-7300HQ CPU @ 2.50GHz (4 x 2496)

GPU Status
2d_canvas: enabledcanvas_oop_rasterization: disabled_offdirect_rendering_display_compositor: disabled_off_okgpu_compositing: enabledmultiple_raster_threads: enabled_onopengl: enabled_onrasterization: enabledraw_draw: disabled_off_okskia_renderer: enabled_onvideo_decode: enabledvideo_encode: enabledvulkan: disabled_offwebgl: enabledwebgl2: enabledwebgpu: disabled_off

Load (avg)
undefined

Memory (System)
7.89GB (1.73GB free)

Process Argv
--crash-reporter-id 9b4d6780-f394-440b-9741-683c6449d835

Screen Reader
no

VM
0%

Extensions (4)

Extension
Author (truncated)
Version

prettier-vscode
esb
9.10.3

material-icon-theme
PKi
4.23.0

LiveServer
rit
5.7.9

volar
Vue
1.0.14

A/B Experiments
vsliv368:30146709
vsreu685:30147344
python383cf:30185419
vspor879:30202332
vspor708:30202333
vspor363:30204092
vslsvsres303:30308271
pythonvspyl392:30443607
vserr242cf:30382550
pythontb:30283811
vsjup518:30340749
pythonptprofiler:30281270
vshan820:30294714
vstes263:30335439
vscorecescf:30445987
pythondataviewer:30285071
vscod805cf:30301675
binariesv615:30325510
bridge0708:30335490
bridge0723:30353136
cmake_vspar411:30581797
vsaa593cf:30376535
pythonvs932:30410667
cppdebug:30492333
vscaac:30438847
vsclangdf:30486550
c4g48928:30535728
dsvsc012cf:30540253
azure-dev_surveyone:30548225
vscccc:30610679
pyindex848cf:30577861
nodejswelcome1cf:30587006
282f8724:30602487
gswce1:30612156
iaj6b796:30613358
89544117:30613380
fim-prod:30623723
vscsb:30628654

/gifPlease

Thanks for reporting this issue! Unfortunately, it's hard for us to understand what issue you're seeing. Please help us out by providing a screen recording showing exactly what isn't working as expected. While we can work with most standard formats, .gif files are preferred as they are displayed inline on GitHub. You may find https://gifcap.dev helpful as a browser-based gif recording tool.
If the issue depends on keyboard input, you can help us by enabling screencast mode for the recording (Developer: Toggle Screencast Mode in the command palette). Lastly, please attach this file via the GitHub web interface as emailed responses will strip files out from the issue.
Happy coding!

https://user-images.githubusercontent.com/116713615/208689842-34eaf81c-4ed6-4a16-b522-708603e7fa2b.mp4

Does this reproduce when disabling all extensions? Press F1 and then choose Developer: Reload Window with Extensions Disabled

https://user-images.githubusercontent.com/116713615/208763535-bd98d7c2-31af-44cc-ab23-a26626d5beb0.mp4
there isn't any problem when all extensions are disabled

But when i manually disabled all extensions it still goes on.

If an extension is disabled manually and it is already activated, then a window reload is required until the extension is really disabled.
To further track down the culprit, you can use extension bisect:

run F1 > Help: Start Extension Bisect
(this will restart VS Code with half of your extensions disabled)
try to do the steps which reproduce the problem
if the problem reproduces, click "This is bad" (this narrows down the problematic extension to the half which was enabled)
if the problem does not reproduce, click "Good now" (this narrows down the problematic extension to the half which was disabled)
these steps will repeat until the problematic extension is found

initial
step
final

It was about my vue extension. Thanks for help. I will report it right now. Should i close this comment with completed?

Yes, please create an issue directly with the vue extension.


feat: remove all category from CRDs

In general, it's not desirable to list Starboard resources with kubectl get all command. Therefore, we should remove the all category from all CRDs. See also #1080.

@danielpacak If I'm not mistaken I think you've already done this in Oct 2021: https://github.com/aquasecurity/starboard/commit/b2e65889830c3ea2dbde58a231418ed2722f52f6
I believe the user in #1080 was using v0.14.1 before this change was made. Hope that helps.

We've only done that for cluster-scoped CRDs but we want to do the same for namespaced CRDs, i.e. ConfigAuditReport, and VulnerabilityReport


opentelmetry demo - prometheus targets are down

Question
Use Github Discussions.

opentelmetry demo - prometheus targets are down
please find attached

We have moved Prometheus to use OTLP write instead of scraping. Prometheus is now started without any scrape targets with #1174


added autosave/load switch

nice.
you should add a hotkey to reset then too.

Yep I'm doing that ;)

Nice !


Errors in Laravel 5.6

I use the latest version of laravel with PHPStorm. i did everything but still ide helper doesnt work as it should.. i still get errors like :
Return value is expected to be '\Illuminate\Http\Response', '\Illuminate\Http\Resources\Json\AnonymousResourceCollection' returned less... (Ctrl+F1)
Return value type is not compatible with declared.

and
Non-static method 'where' should not be called statically less... (Ctrl+F1)
Dynamic class method called as static.

auto completion works though.
This error is produced from the PHPDocs that are generated automatically by laravel. I return a collection and it doesnt recognise it.

i get the same problem, PHPStorm can't recognize where method of Model

I don't understand where the first error show up, can you provide your code?
For the second warning:
The where is not defined as a static method.
To avoid this warning, you can simply call the Model::query() first:
<?php
    User
        ::query()
        ->where('is_vip', true)
        ->count();

@BinotaLIU thanks

@BinotaLIU that query:: trick is a big help. Does it take away any benefit of eloquent?

@GigaMick No. You can check the source code, when you try to build a query with an Eloquent model, it will call Model::query() internally to new an Illuminate\Eloquent\Builder instance.
Eloquent\Model has never implement where/find... etc., all query method is handled by Model::__callStatic and Model::__call.
https://github.com/laravel/framework/blob/v5.6.26/src/Illuminate/Database/Eloquent/Model.php#L1557-L1583

@barryvdh you can close this unless you have another solution

@barryvdh this works nowadays correctly, issue can be closed :}


Anglian Water: Data issues

Anglian Water have confirmed that there are currently some data presentation issues for "pretty much every smart meter". Apparently this is due to "the signal side of things".
Currently usages may be inaccurate, perhaps once AW has sorted this out, the data can be pulled again via the force refresh statistics service call

Seems to be resolved now


persist: baseline persist data format

Fixes #803
This demonstrate how to use new virtcontainers/persist/api/ package brought by #874
This PR is only for demo, please don't merge it.
This is ready for review and merge now :-)

[x] state.json is removed, contents moved to persist.json
[ ] remove network.json
[ ] remove agent.json
[ ] remove devices.json
[ ] remove hypervisor.json
[ ] remove mounts.json
[ ] remove process.json

/test

/test

/test

@WeiZhang555 ping, any updates? Thx

/test

/test

/test

/test

/test

/test

/test

/test

Mark: ARM and FC are failing due to known issue: https://github.com/kata-containers/runtime/issues/1206 and https://github.com/kata-containers/runtime/issues/1221
Others all passed. This is ready for review now.
ping @kata-containers/runtime @sameo @sboeuf @bergwolf @gnawux

Update:

state.json is totally removed, we don't need it any more
Mark new storage implementation as "experimental", default value is false, enabling in configuration.toml will make kata-runtime run with the new persist driver. Issued a seperate PR: https://github.com/kata-containers/runtime/pull/1227

Next step:

adding more unit tests
include old storage files contents in "persist.json"

/test

Weird, I can't find the failing test case in Jenkins report and local test result. But go test ./virtcontainers/ get a return value "1"...

@WeiZhang555 - if it helps, I think you are not going mad :-)
I can't see/find the failure either. I was expecting to find some line such as:
Ran 8 of 8 Specs in 10.194 seconds
SUCCESS! -- 8 Passed | 0 Failed | 0 Pending | 0 Skipped

or similar at the end of the tests, but I don't see it - it just appears to quit and fail:
=== RUN   TestCreateSandboxEmptyID
--- PASS: TestCreateSandboxEmptyID (0.00s)
=== RUN   TestSandboxStateReadyRunning
time="2019-02-12T07:49:12Z" level=error msg="failed to start proxy" error="Invalid proxy parameters {id:foobar path: agentURL: consoleURL: logger:0xc0004ea690 debug:false}" params="{foobar    0xc0004ea690 false}" proxy type=invalidProxyType source=virtcontainers vm=foobar
FAIL	github.com/kata-containers/runtime/virtcontainers	4.093s
Makefile:532: recipe for target 'go-test' failed
make: *** [go-test] Error 1
Build step 'Execute shell' marked build as failure

It feels to me like something is broken somewhere (not necessarily in this PR), and maybe the tests/makefile can do a better job at catching and reporting what failed. I think I see this on at least one other PR as well. I'll /cc @chavafg for his insights on this...

@grahamwhaley
It's starting to drive me mad now....I tried to run parts of tests with
go test -v  -race ./virtcontainers/ -test.run TestSandbox

But all passed.
Only
go test -v  -race ./virtcontainers/

get a FAIL	github.com/kata-containers/runtime/virtcontainers	4.093s
It looks like something crashes the unit test but I can't find which one it is. I'm still strugging on this :(

@jodh-intel @sameo @sboeuf - any ideas?

/test

/test
@grahamwhaley I finally find the failed two test cases: TestContainerSetStateBlockIndex and TestContainerStateSetFstype.
 Even for a successful test, TestContainerStateSetFstype are not showed in result.
This could be some golang bugs, I didn't find a good way to flush the report, maybe need some hack from Golang.
This is so bad and it makes debugging so damn hard!

/retest

/retest

ping @sameo @sboeuf @bergwolf @egernst @gnawux

/test

/retest

@sboeuf @gnawux - I think this could do with a good review from the pov of moving forwards to define the store/load API/architecture for HA and rescue etc. (iiuc) Will you be able to review?

@grahamwhaley I don't have time today for this, but I will find some time next week. This is a major PR that requires attention from everybody.
@bergwolf PTAL too

Rebased & comments addressed.
/test

/test

/retest

/test

/test

/test

@WeiZhang555 the experienmtal PR has been merged.

@WeiZhang555 ping, any updates? This PR growing 😄

@raravena80 I am rebasing, some new fields was added to state.json, so I am cleaning unnecessary codes at the same time. See https://github.com/kata-containers/runtime/pull/1416

@WeiZhang555 nudge.

/test

ping @klynnrif

/test

All tests are green now 🍾 🎆

The last commit is for testing the experimental new store driver, which must be deprecated before merging. I'll remove the last commit for testing compatibility with original store
Last commit:
diff --git a/Makefile b/Makefile
index 072aca5..13c81fa 100644
--- a/Makefile
+++ b/Makefile
@@ -158,7 +158,7 @@ DEFMEMSLOTS := 10
 DEFBRIDGES := 1
 DEFDISABLEGUESTSECCOMP := true
 #Default experimental features enabled
-DEFAULTEXPFEATURES := []
+DEFAULTEXPFEATURES := "[\"newstore\"]"

/test

/test

@sboeuf

You use the same store wording that is already part of virtcontainers to store sandbox and containers data already with the store API located at virtcontainers/store.
This PR duplicates the way to store data, which should rely on the virtcontainers/store code instead. Is it something that you're planning fix as follow up PR?

No, the PR is meant to replace virtcontainers/store, they store data in different ways so can't share interface and logics, the final goal is to remove virtcontainers/store totally and rename newStore to store in release 2.0

@WeiZhang555

No, the PR is meant to replace virtcontainers/store, they store data in different ways so can't share interface and logics, the final goal is to remove virtcontainers/store totally and rename newStore to store in release 2.0

Ah that makes sense, thanks for the clarification. Make sure this is highly documented as this might create some confusion from a code base perspective.

LGTM

/test

ping @kata-containers/ci
We need a separate CI job for testing experimental features since experimental feature can run in different code path as this PR does.
I think we can reuse the exisiting job, such as jenkins-ci-ubuntu-18-04, the chosing Job must be "required" since breaking experimental features are also not allowed.
The modification for this experimental feature is adding one single line to configuration.toml
experimental=["newstore"]

Thanks!

@WeiZhang555 I have added an envar KATA_EXPERIMENTAL_FEATURES=true to the Fedora jobs, which I will set as "required" in github.
I opened PR https://github.com/kata-containers/tests/pull/1501 in the tests repo to make the necessary changes on the configuration.toml, ptal.

@chavafg
Cross refs to https://github.com/kata-containers/tests/pull/1501  and copying comments here:

I checked the CI job metrics: https://github.com/kata-containers/ci#ci-job-matrix and found that fedora didn't cover all test cases. Is that possible to also enable K8s test in Fedora Job? Since I found that my WIP PR (kata-containers/runtime#1575) about newstore feature was failing the K8s test and Fedora test doesn't cover it.


Remove unnecessary publish job requirement

Summary
Cleanup of the CircleCI workflow, there's no need to make publish job dependant of analyze, since analyze is already dependent on checkout_code

New pipeline:

Compatibility

OS
Implemented

iOS
✅

Android
✅

Checklist

[ ] I have tested this on a device and a simulator
[ ] I added the documentation in README.md
[ ] I updated the typed files (TS and Flow)
[ ] I added a sample use of the API in the example project (example/App.js)

Actually, does publish would need android_* jobs to be completed before?

there's no need to make publish job dependant of analyze
Did you mean there is no need to make publish depend on checkout_code?

Actually, does publish would need android_* jobs to be completed before?

It would be an improvement. The current setup is left over from when the android builds were very unreliable. Right now, they are passing consistently already for a long time, so we could make them required to pass before publishing.

:tada: This PR is included in version 4.0.1 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Response serialization and validation

What is the feature you are proposing?
Certain frameworks (eg: fastify) provide response validation for success or error payloads.
Is there support for such feature in hono? If not, is it something planned?
Context
Apart from obvious advantages like schema-first approach, this feature would greatly help securing API internals.
For example, when you have multiple unique IDs for DB records and you want to make sure that only external_id IDs are ever returned without accidentally leaking internal_id IDs.

Hi @sher
Thank you for sharing your opinion.

Is there support for such feature in hono? If not, is it something planned?

Hono does not have a future now. But there have been some discussions before. We tried to implement response validation in Zod OpenAPI, but declined because we thought we needed to work on Hono's core.
https://github.com/honojs/middleware/pull/184
I think it would be better to make the Response Validator as thin as the current hono/validator is very thin, and let other libraries do the real validation.

Thanks @yusukebe
Agree, that the hono API should be as thin as possible and delegate validation to whatever library user wants to use. Currently handlers can accept multiple request validation functions. As the sequence of serialization and validation is reversed in response compared to request, it seems better to handle this inside every handler function before returning data. But still this approach is not ideal, we want to specify the shape that has to be returned on every case and let the schema validator to handle the situation.
const schema = z.object({
  email: z.string().email(),
  password: z.string(),
});

app.post('/me', async function (c) {
  const user = D1.findOne({email: c.body.email});
  const parsed = schema.safeParse(user);
    if (!parsed.success) {
      return c.text('Invalid!', 401);
    }
    return parsed.data;
});

@yusukebe
How about adding response:* keys to validators like this?
const route = app.on(
  'LIST_OF_USERS',
  '/users',
  validator('response:200', (value, c) => {
    const parsed = schema.safeParse(value);
    if (!parsed.success) {
      return c.text('Invalid!', 401);
    }
    return parsed.data;
  }),
  validator('response:400', () => {
    return {
      q: 'bar',
    };
  }),
  (c) => {
    return c.json({
      success: true,
    });
  }
);

@sher
My idea is to create another validator like responseValidator to validate response content. Below are a rough implementation. I think it's difficult to infer the response type in the handler, and the code will be complicated. But if it can run correctly, it will be very convenient.
const validationErrorResponse = (reason: string) => {
  return new Response(reason, {
    status: 401, // We have to set proper status code
  })
}
type ResponseValidatorFnResponse<T = any> =
  | {
      success: true
      data: T
    }
  | {
      success: false
      reason: string
    }

type ResponseValidatorFn<T = any> = (
  value: any
) => ResponseValidatorFnResponse<T> | Promise<ResponseValidatorFnResponse<T>>

const responseValidator =
  (status: number, validationFn: ResponseValidatorFn) => async (c, next) => {
    await next()
    if (!c.res.headers.get('content-type')?.startsWith('application/json')) {
      c.res = validationErrorResponse('The content is not JSON')
      return
    }
    if (c.res.status !== status) {
      c.res = validationErrorResponse(`The status is not ${status}`)
      return
    }
    const value = await c.res.json() // Maybe we have to clone the response body.
    const result = await validationFn(value)
    if (result.success === false) {
      c.res = validationErrorResponse(result.reason)
      return
    }
    const newResponse = new Response(JSON.stringify(result.data))
    c.res = newResponse
  }

const schema = z.object({
  success: z.boolean(),
})

app.get(
  '/results',
  responseValidator(200, (value) => {
    const parsed = schema.safeParse(value)
    if (!parsed.success) {
      return {
        success: false,
        reason: parsed.error.message,
      }
    }
    return {
      success: true,
      data: parsed.data,
    }
  }),
  (c) => {
    return c.json({
      // Is not typed currently
      success: true,
    })
  }
)

I have the exact same case, I don't want some fields accidentialy leaking to the client.
It would be great to have compile time validation as well.

Hey there,
I'm dealing with an issue in my project where I'm using Zod for schema validation and Prisma for database interactions within a Hono TypeScript API. I would like TypeScript to throw an error if there's a mismatch between the returned/fetched types. For some types it works however, for response types it doesnt seem to work and also it doesnt infer correct type for the response types in openapi schema.
How I am tackling the validation of the 200 response type is simply by using const validatedUser = userGetSchema.safeParse(user) because otherwise, the OpenAPI schema does not match the response type for a 200 status code. As you may have guessed, this doesnt show any errors in the UI, unless I try to use the endpoint. Changing the select arguments of prisma.findMany either changes the response type in the OpenAPI schema or throws an error. However anything request related stuff are working for example calling request: { body: jsonContentRequired(userCreateSchema) } but not the response types. So to be able to show correct types I need to call each safeParse for zod schema before returning the data, which eventually makes me land in this issue :) Is there a more clearer way than what I am doing below for now? Or is this the only way for now? I may be doing something completely wrong as well, but just wanted to see if there is anything else I could do here and if there is a recommended way to achieve this tight coupling between Hono route, Zod schemas and Prisma queries with the help of rsponse serialization/validation.
Here's an example of my code:
// example schema
export const userGetSchema = UserSchema
  .omit({ password: true, salt: true })
  .extend({ settings: UserSettingsSchema.partial().nullable().optional() })
  .openapi('UserResponse')

type UserResponse = z.infer<typeof userGetSchema>

// example router
export const getOne = createRoute({
  path: '/users/{id}',
  method: 'get',
  tags,
  request: { params: IdParamsSchema },
  responses: {
    [HttpStatusCodes.OK]: jsonContent(userGetSchema, 'A user'),
    [HttpStatusCodes.NOT_FOUND]: jsonContent(notFoundSchema, 'User not Found' ),
    [HttpStatusCodes.UNPROCESSABLE_ENTITY]: jsonContent(
      createErrorSchema(IdParamsSchema),
      'Validation error',
    ),
  },
})

type GetOneRoute = typeof getOne

// example controller
const getOne: AppRouteHandler<GetOneRoute> = async (c) => {
  const { id } = c.req.valid('param')

  const user = await prisma.user.findUnique({
    where: { id },
    select: {
      ...defaultUserFieldsToReturn,
      settings: {
        select: {
          id: true,
          language: true,
          country: true,
        },
      },
      // ... other relations ...
    },
  })

  if (!user) {
    return c.json(
      { message: HttpStatusPhrases.NOT_FOUND },
      HttpStatusCodes.NOT_FOUND,
    )
  }

  const validation = userGetSchema.safeParse(user)

  if (!validation.success) {
    // here it actually works properly, if I dont include success, typescript screams
    return c.json({ success: false, error: JSON.parse(validation.error.message) }, HttpStatusCodes.UNPROCESSABLE_ENTITY)
  }

  // however here it is already parsed, so this will never complain actually
  // also I dont know how I can match this to prisma result
  return c.json(validation.data, HttpStatusCodes.OK)
}

export { getOne }

What I've Tried:

Parse the user data using userGetSchema.safeParse(user) to validate and return the types properly. This is important because otherwise, the fields don't show up correctly in the API reference or OpenAPI schema generated by Scalar.
Strongly couple Prisma query (findUnique and findMany) with Zod schemas to ensure type safety even before coming to the safeParse step so that it would actually show if zod schema & prisma select/include/attrs not matching to with no luck

Additional Information:
Environment:
Hono version: 4.6.13
Prisma version: 6.0.1
TypeScript version: 5.4.5
Zod version: 3.24.1

I'm still thinking about this issue.
One idea is using render() / setRenderer() API: https://hono.dev/docs/api/context#render-setrenderer
This is a minor function, but it's powerful. You can define the custom function to create a response from your data. In this way, you can validate the data for the response.
The middleware definition:
import { TypedResponse } from 'hono'
import { createMiddleware } from 'hono/factory'
import { HTTPException } from 'hono/http-exception'
import { StatusCode } from 'hono/utils/http-status'
import { ZodSchema } from 'zod'

declare module 'hono' {
  interface ContextRenderer {
    (data: any, status: StatusCode): TypedResponse
  }
}

type Params = Partial<Record<StatusCode, ZodSchema>>

export const responseValidator = (params: Params) =>
  createMiddleware(async (c, next) => {
    c.setRenderer((data, status) => {
      for (const [code, schema] of Object.entries(params)) {
        if (status.toString() === code) {
          const result = schema.safeParse(data)
          if (!result.success) {
            throw new HTTPException(401, {
              res: c.json(result.error.flatten(), 401)
            }) // invalid
          }
          return c.json(result.data)
        }
      }
      return c.json({ message: 'Invalid!' }, 401)
    })
    await next()
  })

Usage:
import { Hono } from 'hono'
import { responseValidator } from './response-validator copy'
import { z } from 'zod'

const app = new Hono()

app.use(
  '/',
  responseValidator({
    200: z.object({
      foo: z.string()
    })
  })
)

app.get('/', (c) => {
  return c.render({ foo: 'bar' }, 200)
})

export default app

You must use c.render when returning a response. Also, TypeScript support is lacking. However, I feel that this method may provide some hints.

At the first glance using c.render seems counterintuitive as someone would expect c.json to be validated as well. Anyway, let's discuss this matter further.

@sher Thanks. I understand what you mean. Another idea is to be able to extend c.json(). This would allow you to validate values, or serialize JSON other than with JSON.stringify()

Off topic, @yusukebe it's only 4 hours until the new year 2025🎄, you still handle reported issues. 良いお年を！

@sher Yes! Have a happy new year! 🎍


add exec debug

Issue
Solution

@delgod abandon?

@delgod abandon?

No reply. Abandone to keep the house clean. Feel free to reopen if necessary.


Fix robusted dionas not being recoverable

About the PR
Diona that have robusted themselves into a tree now drop their items before polymorphing, and can be recovered by chopping down the tree.
Why / Balance
The polymorph definition for this set revertOnDeath: true, but trees do not have a mobState that can die so that never worked. Further, this sends all items carried by the diona (including the nuke disk if they are holding it) into the ether leaving them unrecoverable.
Technical details
PolymorphSystem subscribes to DamageThresholdReached to detect imminent destruction and revert the polymorph on destruction if revertOnDeath is true. I figured this makes sense since destruction and death are about analogous here. There is a comment on DamageThresholdReached that says it's not being used anywhere else, but this is as good a first use as any I suppose.
Media

[x] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes
N/A
Changelog

:cl:

tweak: Diona now drop their items when robusted into a tree.
fix: Diona can be cut free from their robust tree-form.

There is one issue with this fix. Because polymorphing basically sends the chem system into stasis, the remaining solution is not processed or consumed. This means if there was 10u more robust harvest in system than required to polymorph, being cut free makes the diona process .5u of it and then polymorph again. This means it's trivial to get infinite wood from this, and is just a pain in general for the affected diona. Ideally, polymorphing would consume the 80u of robust harvest that it took to hit that limit, but I'm not sure if there's any simple way to do that with the current system without adding an ugly special-case in the revert-code. One way to resolve this is to just give up on reverting the Diona and just let them die as before, as dropping the inventory already resolves the most abusable part of current behaviour. Any suggestions on how best to resolve this is welcome.

They could receive a cooldown/immunity to being turned into a tree after being cut free instead.


Open Science Grid -> OSG

We're doing a small rebranding exercise to make the brand just "OSG" instead of "Open Science Grid (OSG)".
Where we can, please scrub the website - and images - to replace "Open Science Grid" with "OSG".

@bbockelm Do you know where I can images with the OSG replacement or should I create those?

I am not aware of any official logos with just “OSG”. I can try to get you some original logo files, though, and you are welcome to modify them. Eventually, it would be good for us to save the new logos in the same place (it’s called DocDB) that the old ones live.

I use the one here: https://github.com/opensciencegrid/opensciencegrid.github.io/blob/master/assets/images/osglogo-large.png
Think we will have to hand wrangle any accompanying OSG.


Login with google not working in Google Chrome incognito mode though working properly in normal mode .

Login with google is not working in incognito mode . Getting "idpiframe_initialization_failed', details: 'Cookies are not enabled in current environment." error . Any solution for this ?
Using react-google-login & OAuth2Client lib .

Login with google is not working in incognito mode . Getting "idpiframe_initialization_failed', details: 'Cookies are not enabled in current environment." error . Any solution for this ?
Using react-google-login & OAuth2Client lib .

Hi, have you checked your browser settings Settings -> Privacy and Security -> Cookies and other site data, and check Allow all cookies?

Yeah..... after allowing cookies it's working fine but I want the fuctionality without allowing cookies ..... any solution for that ?

Unfortunately, Google needs to use cookies when it authenticates the user, and the cookies are considered third-party cookies to your domain. The official documentation https://developers.google.com/identity/gsi/web/guides/migration#cookies has more info on this.

does anyone know if the new signin with Google API also suffers the same cookie issue? As it indicated that it does not use G_ENABLED_IDPS anymore, so was hoping it won't matter if the 3rd party cookies got turned off...

@connectdotz Doesn't seem like it  :( I just updated my system and the issue persists

Experiencing this issue as well -- is there any expectation that an update will fix this without requiring user's to adjust their settings?

@akhna10x There will be no fix... This is an (old) known issue that google doesn't really intends to fix and/or address as can be attested by the fact that the just released Google Identity has the exact same issue https://developers.google.com/identity/sign-in/web/troubleshooting#known_issues

@connectdotz The new Identity Services does in fact work. We were running into this same issue with some of our users over at instantdomains.com (both incognito windows and with 3rd party cookies disabled) and wound up migrating to the new system. Their docs are a little tough to follow but it does resolve this issue. Feel free to head over there to see for yourself. And feel free to reach out if you have questions
@gabycperezdias There is hope, their docs are a bit of a nightmare and it's not totally clear but the link that you provided is for the existing (gapi) system.

Hi everyone! We might have found a very simple workaround: https://github.com/pwa-builder/PWABuilder/issues/3286#issuecomment-1219798658 (confirmed from multiple websites).

Unfortunately, Google needs to use cookies when it authenticates the user, and the cookies are considered third-party cookies to your domain. The official documentation https://developers.google.com/identity/gsi/web/guides/migration#cookies has more info on this.

This is really annoying.


Add UI where users can design and test out their transformations

At the base of the app i.e / there should be an UI for user to start design and save transformations.

@saiswapnil123 Please change the design as needed, the above is just a sample UI, I came up with at that moment.


[IMPROVEMENT] Disabling dynamic compression

Using 2.9.5 and have and issue here. So I was trying to encode a 5.1 audio with in DD with 448 kbps, forced -31 dn and getting the dynamics compression for some reason (on top of lowering whole file volume even with -31 dn). Same results with -27 DN value. Am I missing something? Haven't have something like that with neither Dolby Media Production Suite or just ffmpeg.

@Qarmaa you should provide sample files

I feel the same about the DRC. Has anyone figured a way to keep DEE from messing up the volume levels ? One time i noticed DEE dialing down fine details such as wind and breaking glass etc.., ruining the experience. i had to input manual dialnorm to up the volume. On the other hand, it lifted up ambient noises. I just don't want the DEE to touch the volume.

Dolby reference player can disable DRC as follows and that will also produce no encoder delay (gapless at the start at least) and 32 bit integer file: "C:\Program Files\Dolby\Dolby Reference Player\gst-launch-1.0.exe" --gst-plugin-path "C:\Program Files\Dolby\Dolby Reference Player/gst-plugins" filesrc location=C:\tmp\atmos\gapless.eac3 ! dlbac3parse ! dlbaudiodecbin ac3dec-drop-delay=true ac3dec-drc-suppress=true out-ch-config=13 ! audio/x-raw,format=S32LE ! wavenc ! filesink location=Z:\zE.L111.wav

This Generates wav file from eac3 disabling the drc ?
Can it be used to encode eac3 without the drc ?
Thanks!

no

Can it be used to encode eac3 without the drc

FFmpeg EAC3 encoder does not do DRC, e.g.


repo maintenance (if anyone wants to help)

These tasks will help maintainability long term:

[ ] move off yarn@1 to something better (there is a pr for yarn@4, it needs reviewed)

Probably in order:

[ ] ditch jest (it's legacy / sunset (unofficially) in favor of vitest
[ ] convert tests to their own workspaces
[ ] convert test workspaces to esm, so they can use newer versions of dependencies which may no longer support cjs (glimmer, for example)

Some unknown unknowns, and may need discussion:

[ ] build inline the environments, we don't need glint's architecture to be so flexible, and we can reduce some complexity (aka have the Polaris experience be default and not require configuration)

I don't think we're using jest anywhere 🤔

Excellent! easy checkbox!


Problem building plugin with newer GeckoView Version

Hello everyone,
When bulding the GeckoView plugin with the newest version ("95.0.20211129150630"), several errors occur and it is no longer possible to build the plugin.
The erros are:

Any help in solving them would be much appreciated!
P.S.: My plan ist to get the plugin running with the newest version of gecko und eventually on arm64.

Whenever you update a major geckoview version you'll have to fix the inevitable API breaking changes. How you fix those errors is not predetermined and your best bet is first understanding what changed and why, then trial and error to fix them.

what are the benefits from the newer geckoversion?

Thanks for the reply. I just wanted to make the plugin more future proof

Nice, any luck fixing the errors or stuck on something in particular?

i found that the jdk was changed and the GeckoAPI changed also. Maybe we should update all things for code running, incloud the webview.cs code.

@Stormbreaker919 @jiulengjing if ya'll could try out the pull request version I'd appreciate it. Updated gecko engine to the latest version.

Sorry, that i have not answered in some time. In the meantime I decided to use another solution for my master thesis project.
Nevertheless I will try out your pull request when I find the time, to support your cool browser!


emulator crashes when using eyetoy and pausing

start with eyetoy emulation.
pause emulation
resume emulation
crash

Fixed some crashes with DShow and save state that on 64bit wanted to access freeze data pointer +4GB 😿 .
Some weirdness with DShow still like sometimes have to open settings multiple times with OBS virtual camera before it starts working.

this problem does seem to be fixed.


Switch ckan integration to govuk_solr6

https://trello.com/c/OxoHouSW
This:

gives the ckan app the ability to work with multicore solr and provision a solr core in such cases.
adds the govuk_solr6 module to s_ckan instance classes, though doesn't enable it by default.
goes on to enable govuk_solr6 and disable govuk_solr for the integration ckan.

This needs to be released hand-in-hand with an app release of the ckanext-datagovuk master-2.8 branch, because the 2.7 branch hasn't been patched to work with multicore solr.

Note: if this PR gets applied then reverted, the daemons might need a manual kicking because the new solr package won't get un-installed and will still be running as a daemon occupying the port the old solr (run as the jetty service`) wants to use. Stateful management is great.

FWIW I've tested this (on integration) with the "govuk_solr disabled/govuk_solr6 enabled" switch not flipped too, which should be the state that gets pushed out to staging and production following the merge of this. It safely continues to work the old way.


Cannot use Python interpreter in hidden/dot folder (selection menu doesn't display dot folders)

Issue Report Checklist

[x] Searched the issues page for similar reports
[x] Read the relevant sections of the Spyder Troubleshooting Guide and followed its advice
[x] Reproduced the issue after updating with conda update spyder (or pip, if not using Anaconda)
[ ] Could not reproduce inside jupyter qtconsole (if console-related)
[x] Tried basic troubleshooting (if a bug/error)

[x] Restarted Spyder
[x] Reset preferences with spyder --reset~~
[ ] Reinstalled the latest version of Anaconda
[x] Tried the other applicable steps from the Troubleshooting Guide

[x] Completed the Problem Description, Steps to Reproduce and Version sections below

Problem Description
I want to select a Python interpreter inside a "hidden" folder (~/.cache/pypoetry/). The interpreter selection menu doesn't display hidden/dot folders.
What steps reproduce the problem?

open Spyder
go to Tools > Preferences > Python interpreter
select "Use the following Python interpreter"
click the "Select file" button
Notice there are no folder names beginning with a period

Versions

Spyder version: 4.1.5
Python version: 3.8.5 64-bit
Qt version: 5.12.9
PyQt version: 5.12.3
Operating System name/version: Kubuntu 18.04.5

Dependencies

# Mandatory:
atomicwrites >=1.2.0           :  1.4.0 (OK)
chardet >=2.0.0                :  3.0.4 (OK)
cloudpickle >=0.5.0            :  1.6.0 (OK)
diff_match_patch >=20181111    :  20200713 (OK)
intervaltree                   :  None (OK)
IPython >=4.0                  :  7.18.1 (OK)
jedi =0.17.1                   :  0.17.1 (OK)
keyring                        :  None (OK)
nbconvert >=4.0                :  5.6.1 (OK)
numpydoc >=0.6.0               :  1.1.0 (OK)
parso =0.7.0                   :  0.7.0 (OK)
pexpect >=4.4.0                :  4.8.0 (OK)
pickleshare >=0.4              :  0.7.5 (OK)
psutil >=5.3                   :  5.7.2 (OK)
pygments >=2.0                 :  2.6.1 (OK)
pylint >=1.0                   :  2.6.0 (OK)
pyls >=0.34.0;<1.0.0           :  0.34.1 (OK)
qdarkstyle >=2.8               :  2.8.1 (OK)
qtawesome >=0.5.7              :  0.7.2 (OK)
qtconsole >=4.6.0              :  4.7.7 (OK)
qtpy >=1.5.0                   :  1.9.0 (OK)
sphinx >=0.6.6                 :  3.2.1 (OK)
spyder_kernels >=1.9.4;<1.10.0 :  1.9.4 (OK)
watchdog                       :  None (OK)
xdg >=0.26                     :  0.26 (OK)
zmq >=17                       :  19.0.2 (OK)

# Optional:
cython >=0.21                  :  None (OK)
matplotlib >=2.0.0             :  None (OK)
numpy >=1.7                    :  None (OK)
pandas >=0.13.1                :  None (OK)
scipy >=0.17.0                 :  None (OK)
sympy >=0.7.3                  :  None (OK)

This doesn't depend on Spyder but on the open dialog used in your operating system. In KDE you can simply do right-mouse click on that dialog to show your hide files:

Please try that and let us know if it works for you.

Works. Sorry about that. I've only ever used Ctrl+H.


Is to possible to configure pylance with additional custom builtins type definitions for a DSL

Idea is to have use python as base for domain specific language. So certain type stubs which are specific to this DSL can be write code straight in vs code editor without explicit import statements.
appreciate that by default we could have typings folder in code workspace to allow usage of custom type stubs.
but when writing actual code we still need to use import statement .
from custom_types import *
If we could somehow avoid this import statement in vs code editor, given that certain types (to be treated as builtins for this DSL) exist in typings directory in a certain file in code workspace.

Pylance doesn't hard-code the list of builtin symbols. These come from the builtins.pyi file, and you're free to override it if you'd like to add new builtins symbols. To do so, you can clone the typeshed github repo, make local edits, and use the python.analysis.typeshedPaths setting to point to your modified version. By default, pylance uses a bundle copy of these typeshed stubs.
Another option is to place your additional symbols in a custom_types.pyi file and import them under a TYPE_CHECKING conditional:
from typing import TYPE_CHECKING

if TYPE_CHECKING:
    from custom_types import *

The first option suits our needs better :)


Improve visibility for method: hasValidCountryCallingCode

we have telephone number's usage by format with country code-national numbers: The country code can be some numbers called internal country code we customized which not belong to standard ISO country codes. So we need one method to judge if the country code belong to ISO country codes and then to do some special logic.
So I found this method with private. so I advice to change to public for this method. Maybe it will be popular method to judge is country code is valid.
WDTY?

This change is

I am concerned about what you are doing here.

to format, you need a PhoneNumber object
to get one, you must parse some text calling "parse"
if you do this with an invalid country calling code, we will throw an exception.

Sounds like you aren't calling parse, in which case you are highly likely to be corrupting data, e.g. for Italian fixed-line numbers.
The only case where I could see this method being useful is for formerly valid country calling codes that no longer are, but in that case I would call isPossibleNumberWithReason on the number instead anyway since it'll tell you if the number seems plausible and if not why not. If the number is way too long or short, formatting it won't give you a very sensible output either....
In any case, you can just call  getRegionCodeForCountryCode and if it is ZZ (unknown), you know it's not a valid one.
Other alternatives: you can also getSupportedRegions and get the country calling code for each one and build the list yourself. Then you can also decide whether you want to include non-geographical entities too like international freephone, with getSupportedGlobalNetworkCallingCodes() which will return those.

@lararennie  Thanks for your feedback.
As you said, I doesn't want to parse phone number but just to judge if the country code is standard ones.
I can use your mentioned methods to write one method to meet requirements such as:
boolean hasValidCountryCallingCode(int countryCallingCode){
    String regionCode = getRegionCodeForCountryCode(int countryCallingCode)
    return !("ZZ".equals(regionCode )
}

but if change to public for hasValidCountryCallingCode() in PhoneNumberUtil.  it will avoid everyone need this requirement write the duplicated similar method.
WDYT?

If you do not call parse, you cannot call format and expect that there will be no data corruption.
No one has requested this before, so I can't see evidence for increasing our API surface exposure when it is a one-liner in client code, and I can't see a valid use-case for doing this anyway - we already have more use-case based methods.

@lararennie total agree with you. Thanks.


【Frontend】Add sampler_priority and repetition_penalty_range

To solve https://github.com/vllm-project/vllm/issues/8835,  add sampler_priority to control the execution order of the samplers, and add repetition_penalty_range to control  penalties sampler token range

Could someone help me review this PR?

[2024-11-04T07:22:51Z] =================================== FAILURES ===================================
--
  | [2024-11-04T07:22:51Z] __________________________ test_gpu_memory_profiling ___________________________
  | [2024-11-04T07:22:51Z]
  | [2024-11-04T07:22:51Z]     def test_gpu_memory_profiling():
  | [2024-11-04T07:22:51Z]         # Tests the gpu profiling that happens in order to determine the number of
  | [2024-11-04T07:22:51Z]         # KV cache blocks that we can allocate on the GPU.
  | [2024-11-04T07:22:51Z]         # This test mocks the maximum available gpu memory so that it can run on
  | [2024-11-04T07:22:51Z]         # any gpu setup.
  | [2024-11-04T07:22:51Z]
  | [2024-11-04T07:22:51Z]         # Set up engine args to build a worker.
  | [2024-11-04T07:22:51Z]         engine_args = EngineArgs(model="facebook/opt-125m",
  | [2024-11-04T07:22:51Z]                                  dtype="half",
  | [2024-11-04T07:22:51Z]                                  load_format="dummy")
  | [2024-11-04T07:22:51Z]         engine_config = engine_args.create_engine_config()
  | [2024-11-04T07:22:51Z]         engine_config.cache_config.num_gpu_blocks = 1000
  | [2024-11-04T07:22:51Z]         engine_config.cache_config.num_cpu_blocks = 1000
  | [2024-11-04T07:22:51Z]
  | [2024-11-04T07:22:51Z]         # Create the worker.
  | [2024-11-04T07:22:51Z]         distributed_init_method = get_distributed_init_method(
  | [2024-11-04T07:22:51Z]             get_ip(), get_open_port())
  | [2024-11-04T07:22:51Z]         worker = Worker(
  | [2024-11-04T07:22:51Z]             vllm_config=engine_config,
  | [2024-11-04T07:22:51Z]             local_rank=0,
  | [2024-11-04T07:22:51Z]             rank=0,
  | [2024-11-04T07:22:51Z]             distributed_init_method=distributed_init_method,
  | [2024-11-04T07:22:51Z]             is_driver_worker=True,
  | [2024-11-04T07:22:51Z]         )
  | [2024-11-04T07:22:51Z]
  | [2024-11-04T07:22:51Z]         # Load the model so we can profile it
  | [2024-11-04T07:22:51Z]         worker.init_device()
  | [2024-11-04T07:22:51Z]         worker.load_model()
  | [2024-11-04T07:22:51Z]
  | [2024-11-04T07:22:51Z]         # Set 10GiB as the total gpu ram to be device-agnostic
  | [2024-11-04T07:22:51Z]         def mock_mem_info():
  | [2024-11-04T07:22:51Z]             current_usage = torch.cuda.memory_stats(
  | [2024-11-04T07:22:51Z]             )["allocated_bytes.all.current"]
  | [2024-11-04T07:22:51Z]             mock_total_bytes = 10 * 1024**3
  | [2024-11-04T07:22:51Z]             free = mock_total_bytes - current_usage
  | [2024-11-04T07:22:51Z]
  | [2024-11-04T07:22:51Z]             return (free, mock_total_bytes)
  | [2024-11-04T07:22:51Z]
  | [2024-11-04T07:22:51Z]         from unittest.mock import patch
  | [2024-11-04T07:22:51Z]         with patch("torch.cuda.mem_get_info", side_effect=mock_mem_info):
  | [2024-11-04T07:22:51Z]             gpu_blocks, _ = worker.determine_num_available_blocks()
  | [2024-11-04T07:22:51Z]
  | [2024-11-04T07:22:51Z]         # Peak vram usage by torch should be 0.7077 GiB
  | [2024-11-04T07:22:51Z]         # No memory should be allocated outside of torch
  | [2024-11-04T07:22:51Z]         # 9.0 GiB should be the utilization target
  | [2024-11-04T07:22:51Z]         # 8.2923 GiB should be available for the KV cache
  | [2024-11-04T07:22:51Z]         block_size = CacheEngine.get_cache_block_size(
  | [2024-11-04T07:22:51Z]             engine_config.cache_config, engine_config.model_config,
  | [2024-11-04T07:22:51Z]             engine_config.parallel_config)
  | [2024-11-04T07:22:51Z]
  | [2024-11-04T07:22:51Z]         expected_blocks = (8.2923 * 1024**3) // block_size
  | [2024-11-04T07:22:51Z]
  | [2024-11-04T07:22:51Z]         # Check within a small tolerance for portability
  | [2024-11-04T07:22:51Z]         # Hardware, kernel, or dependency changes could all affect memory
  | [2024-11-04T07:22:51Z]         # utilization.
  | [2024-11-04T07:22:51Z]         # A 10 block tolerance here should be about 6MB of wiggle room.
  | [2024-11-04T07:22:51Z] >       assert abs(gpu_blocks - expected_blocks) < 10
  | [2024-11-04T07:22:51Z] E       assert 346.0 < 10
  | [2024-11-04T07:22:51Z] E        +  where 346.0 = abs((15441 - 15095.0))
  | [2024-11-04T07:22:51Z]
  | [2024-11-04T07:22:51Z] worker/test_profile.py:65: AssertionError
  | [2024-11-04T07:22:51Z] =========================== short test summary info ============================
  | [2024-11-04T07:22:51Z] FAILED worker/test_profile.py::test_gpu_memory_profiling - assert 346.0 < 10
  | [2024-11-04T07:22:51Z]  +  where 346.0 = abs((15441 - 15095.0))
  | [2024-11-04T07:22:51Z] ================== 1 failed, 1297 passed in 634.31s (0:10:34) ==================
  | [2024-11-04T07:22:53Z] 🚨 Error: The command exited with status 1
  | [2024-11-04T07:22:53Z] user command error: The plugin docker command hook exited with status 1
  | Running global pre-exit hook | 0s
  | Running plugin docker pre-exit hook

This PR has been open for three weeks, and I’m not sure if the VLLM team is interested in this change. If you are, could someone help me check why the tests here haven't passed?
@WoosukKwon @zhuohan123 @youkaichao @alexm-neuralmagic  @comaniac @njhill


npm run hot doesn't work with mix.version()

Laravel Mix Version: 4.0.14
Node Version : v10.15.0
NPM Version (npm -v): 6.4.1
OS: Windows 10

when i run
npm run hot
all working well before first changes in css or js files.
in console
[HMR] Waiting for update signal from WDS...
[WDS] Hot Module Replacement enabled.
After changes.
[WDS] App updated. Recompiling...
but if i disable mix.version() all working

Search before reporting, it has been reported tons of times

Thanks. but css still does not update

I worked around it by wrapping the mix.version call in an if statement:
if (!process.argv.includes('--hot')) {
    mix.version()
}

@ankurk91 while that might be true, this is the only thread I found and even that took me a while. So I am glad it was raised ... again!? Is there a fix planned to make them both work together? Is there an open ticket for it? Or can you link some old closed once for reference? Thanks!

Agree this should have been fixed within source code but no one cares.


Windows-IIS-Server

Describe the feature
How  deploy Nuxt 3 to Windows Server using IIS？
Currently documentation is non-existent for windows server deployments
Additional information

[ ] Would you be willing to help implement this feature?

~> https://github.com/unjs/nitro/issues/371


Request: Fix to remove docstrings in stubs (PYI021/docstring-in-stub)

I'd like PYI021 to provide an autofix (even an "unsafe" one is fine by me) to easily remove docstrings that may be generated by other tools. For example, https://github.com/microsoft/python-type-stubs/tree/main/stubs/sympy-stubs#remove-doc-comments has a custom script to remove docstrings that could be replaced by Ruff.

I'm leaning towards making this fix unsafe by default, just because it's fairly destructive and the docstring could have contained meaningful text.


Verovio + Emscripten 1.38.9 + Jest fails

For some reason when trying to instantiate a verovio toolkit in jest using a toolkit build in emscripten 1.38.9, we get TypeError: Cannot read property 'src' of null. and the test fails. I genuinely doubt the problem is in emscripten but using 1.38.8 hasn't produced this problem so we're using that as a workaround.
Jest 23.4.1
Verovio 2.0.0-dev-8ae560d

Still present in emscripten 1.38.10.

Works in emscripten 1.38.11.


ec.encode original volume maybe delete fail

Describe the bug
ec.encode command maybe fail when execute delete original volume step
command:
weed shell -master=xxxx
lock
ec.encode -collection=xxxx -volumeId=xxxx
unlock

log output:
markVolumeReadonly 154 on <IP_ADDRESS>:9334 ...
markVolumeReadonly 154 on <IP_ADDRESS>:9334 ...
markVolumeReadonly 154 on <IP_ADDRESS>:9334 ...
........
........
delete volume 154 from <IP_ADDRESS>:9334
delete volume 154 from <IP_ADDRESS>:9334
delete volume 154 from <IP_ADDRESS>:9334

<IP_ADDRESS> delete execute repeated, <IP_ADDRESS> not delete

System Setup
any cluster with more than 2 replica, for example: -defaultReplication=020
Screenshots

Additional context
i think this caused by the shared memory of the locations slice.While iterating through the locations and deleting the original volume, the master client will also update the members in the locations.
reproduce: add a sleep within the loop. file: weed/shell/command_ec_encode.go, line: 185

thanks for the detailed report and insights!


Add support for probing podman auth files.

@mthalman @baronfel ptal.
For reference: https://man.archlinux.org/man/containers-auth.json.5

@mthalman CI was not happy with my change to use C# 11. I've changed it back to C# 10. It should pass now.

@mthalman can you take a look?
This is part making the .NET SDK container tooling work well with podman.
Without this, the auth file created by podman login is not found.

Thanks for the review!
Once this is merged, can you make a new release, so it can be used by the dotnet/sdk repo?


Godeps update for crackcomm/cloudflare

Fixes rancher/rancher#4482
I didn't test out in a full rancher context, but locally it doesn't complain when registering my CloudFlare domain.
$ ./bin/external-dns
INFO[0000] Configured CloudFlare with zone "poxy.fr"
INFO[0000] DNSIMPLE_TOKEN is not set, skipping init of DNSimple provider
INFO[0000] GANDI_APIKEY is not set, skipping init of Gandi provider
INFO[0000] POINTHQ_TOKEN is not set, skipping init of PointHQ provider
FATA[0032] Failed to configure rancher-metadata: Error 403 accessing /version path

I just executed some test cases against this PR in Rancher server v1.0.1:
Add exposed service - PASS
Scale up service - PASS
Scale down service - PASS
Remove service - PASS
LGTM 👍

Any news ?

LGTM

@sdurrheimer is there a corresponding community-catalog PR? The image would be tagged with v0.4.0

@alena1108 I haven't done a community-catalog PR, but I can have a look if necessary.

@sdurrheimer thank you, I've just published the release, and pushed v0.4.0 image. The new catalog item should be the same as the previous one, except for the image tag.


ukko-\d.html is not generated in file cache mode

When [cache] type=file only ukko.html is generated. Since ukko.html now redirects to ukko-0.html (and these files don't seem to be generated in file caching mode), the web server returns error 404.

This appears to have been resolved.


compatibility with ckeditor

This is not an issue per se but a query. Is there any way we can make this plugin compatible with ckeditor? I have followed the suggestion mentioned by you and included contenteditable in mentions input.
But this part of the code is throwing me errors -
boundary = document.createRange();  boundary.setStart(node, this.start);  boundary.collapse(true);  rect = boundary.getClientRects()[0];  posX = rect.left + (window.scrollX || window.pageXOffset);  posY = rect.top + rect.height + (window.scrollY || window.pageYOffset);
I am unable to fix the errors found in _setDropdownPosition method. Is there any alternative?

Can you give a sample code showing how you initialize ckedit and mentionsInput?


🚨 test(VSecM Sentinel): 1100 add unit test and refactor app/sentinel

Increase on Coverage ratio
Description
Added unit tests to app/sentinel/oidc/engine package and refactored the codebase
Changes
List the major changes you have made in bullet points:

Dependency injection on app/sentinel/oidc/engine
Added unit tests

Test Policy Compliance

[x] I have added or updated unit tests for my changes.
[x] I have included integration tests where applicable.
[x] All new and existing tests pass successfully.

Code Quality

[x] I have followed the coding standards for this project.
[x] I have performed a self-review of my code.
[x] My code is well-commented, particularly in areas that may be difficult
to understand.

Documentation

[x] I have made corresponding changes to the documentation (if applicable).
[x] I have updated any relevant READMEs or wiki pages.

Additional Comments
Include any additional comments or context about the PR here.
Checklist
Before you submit this PR, please make sure:

[x] You have read the contributing guidelines and
especially the test policy.
[x] You have thoroughly tested your changes.
[x] You have followed all the contributing guidelines for this project.
[x] You understand and agree that your contributions will be publicly available
under the project's license.

By submitting this pull request, you confirm that my contribution is made under
the terms of the project's license and that you have the authority to grant
these rights.

Thank you for your contribution to VMware Secrets Manager
🐢⚡!

update: there is a minor test failure in the integration server.
@gurkanguray and I are investigating it.
Once we fix the issue; unless anyone disagrees, we can merge this.
Thanks for your contributions @gurkanguray .

Thank you @v0lkan, I believe I've fixed the issue. Ready for testing again 👍🏻


Uncaught Error: No matching bindings found for serviceIdentifier: Symbol(IContext)

Describe the bug
I've recently tried to upgrade from v1 to v2 Robotlegs Pixi, but receving the following error when trying to dispatch an event immediately after registering it:
Uncaught Error: No matching bindings found for serviceIdentifier: Symbol(IContext)
My app needs to run a series of commands at startup (as a SequenceMacro) before we add any views to stage. The only way I could do this in v1 was to configure the context with the following Config class:
@injectable()
export class AppConfig implements IConfig {

    @inject(IEventCommandMap)
    private commandMap: IEventCommandMap;

    @inject(IEventDispatcher)
    private eventDispatcher: IEventDispatcher;

    public configure () {
        this.commandMap.map(SystemEvent.INITIALISE, SystemEvent).toCommand(InitialiseGame);
        this.eventDispatcher.dispatchEvent(new SystemEvent(SystemEvent.INITIALISE));
    }
}

This worked fine in v1, but fails in v2. I've also tried to dispatch the event after initialized in the callback as well, but it fails silently.
this.context.install(MVCSBundle, PixiBundle)
            .configure(new ContextView(this._pixiApp.stage))
            .configure(AppConfig)
            .initialize(()=> {
                this.context.dispatchEvent(new SystemEvent(SystemEvent.INITIALISE));
            });

How should I be dispatching an event immediately after context initialisation in order to run my InitialiseGame seqence macro command?
TIA
Dan Rostron

This was an npm issue, deleting node_modules and re npm install worked.


"okButtonText" does not appear to be working in FireFox

when I customize my blurt with something such as the following:
blurt({
title: "Error",
text: error.GetSummaryDetailDataResult.Message,
type: "error",
okButtonText: "Close",
escapable: true
});
The okButtonText appears in both Chrome and IE but does not show up for any of my buttons in FireFox.  I'm using the latest version of all three browsers.
see below for a couple of sample screenshots:

@jonlarsen86 I would recommend you use http://bitwiser.in/medium-style-confirm/. Its api is the same as of blurt while I try to fix this.

Thanks, I'll take a look.
On Wed, Dec 2, 2015 at 12:45 AM, Brijesh Bittu<EMAIL_ADDRESS>wrote:

@jonlarsen86 https://github.com/jonlarsen86 I would recommend you use
http://bitwiser.in/medium-style-confirm/. Its api is the same as of blurt
while I try to fix this.
—
Reply to this email directly or view it on GitHub
https://github.com/brijeshb42/blurt/issues/2#issuecomment-161210802.


ANGULAR: Ambiguity Threshold in Distance metric menu

The ambiguity threshold button is displayed even for the default which is AVERAGE. This is confusing to the user.
Also the tooltip displayed when you hover over 'Ambiguity Threshold" is wrong. It's the same definition as 'genetic threshold'. (see image below)
The ambiguity threshold should be visible only if HIV-TRACE-g is selected as the method to deal with ambigs. Only then does the user decide what value to set. the algorithm uses this user set threshold to decide which sequences to resolve and which ones to average (see definition below):
HIV-Trace-g (Any sequence with no more than the selected proportion [0 - 1] will have its ambiguities resolved [if possible], and ambiguities in sequences with higher fractions of them will be averaged. This mitigates spurious linkages due to highly ambiguous sequences.)

Updated so that the ambiguity threshold only appears for HIVTRACE-G and RESOLVE (the only two that use that value), added to pending bugfix PR


Data Populate Overide Settings - Attached Sketch File

Which version of the plugin are you using?
[ x ] Data Populator for Sketch
[ ] Data Populator for Adobe XD
Is your feature request related to a problem? Please describe.
Allowing override population will enable us to use the same symbol but different key results [...]
Describe the solution you'd like
Manually set key values in override panel, run the plugin with presets to populate and override key values
Describe alternatives you've considered
Additional context
Ive attached a sketch example file with the results that i would like :)
Overide_datapopulator.sketch.zip

We’re using the latest 52.2 👍🏻😎

And latest plugin

@creativechris08 ok, so you need to use the {placeholder} in the layer name of the text layer, not the content of the override and it should work just fine!

This is know :) but this was a feature request to be able to have this option! Would this be possible or?

Please refer to attached sketch file. Using override text keys will allow the use for using One symbol but with many text key options. Something that is not currently possible using data populatior

I want to use only one symbol with (placeholder) text but have say 3 separate values without the order being random or having to use the plugin to create the grid. How would this be possible?

@creativechris08 ok, we already had this feature request before. This would be helpful if you for example want a single symbol in which you always have e.g. an image, a H1, a H2 and a Description. but in Case 1 you want it to be a Contact, in Case 2 a Product and they don't share the same key names – so you need to put the {placeholders} in the overrides. Right now, you need to define a Symbol for "Contact" and one for "Products".
on the other hand, it's already possible to have the order in the JSON in the populated grid. because the {placeholder} would always be {name}, but it will populate the grid sequentially along the order in the JSON (if random is 'off'). or maybe i don't get your point.

#94 is the original feature request.

@creativechris08 see #94 – we're trying to get this running in the next version…

@creativechris08 please check out v3.0.3!
https://www.datapopulator.com/sketch/changelog.html


[ACR] Handling SSL Error in check health

GitHub Issue: https://github.com/Azure/acr/issues/256
SSL Error raised

Non-existent container registry name entered

@ni-reis
@tjprescott
This checklist is used to make sure that common guidelines for a pull request are followed.

[ ] The PR has modified HISTORY.rst describing any customer-facing, functional changes. Note that this does not include changes only to help content. (see Modifying change log).

[x] I adhere to the Command Guidelines.

@tjprescott I understand you're moving to a different team. Whom should we be tagging in future to review and merge the PRs?

LGTM

@yugangw-msft Could you please review and merge this PR? The other reviewer (ni-reis) has approved the PR.


Fix DNSEndpoint owner reference for GRPCRoute

What type of PR is this?
bug
Which issue does this PR fix:
Sets correct owner reference for DNSEndpoint if parent is GRPCRoute.
What does this PR do / Why do we need it:
Prevents leaking DNSEndpoint resource.
If an issue # is not available please add repro steps and logs from aws-gateway-controller showing the issue:
Testing done on this change:

Automation added to e2e:

Will this PR introduce any new dependencies?:

Will this break upgrades or downgrades. Has updating a running cluster been tested?:
Does this PR introduce any user-facing change?:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

15 of 16 (93.75%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.05%) to 39.241%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

pkg/deploy/externaldns/dnsendpoint_manager.go
10
11
90.91%

Totals

Change from base Build<PHONE_NUMBER>:
0.05%

Covered Lines:
4012

Relevant Lines:
10224

💛  - Coveralls


[Suggestion] Certus Quartz compatability

Add compatability for certus quartz (applied energistics 2)
https://www.curseforge.com/minecraft/mc-mods/applied-energistics-2

Sry i'm late
I will add it soon
Thanks for Suggestion


Error on build due to not default package folder

Hi
I've got an exception when building due to the fact that my packages folder is not in the default location.
it tries to use Foundation\Data\packages\CNeptune.1.2.1\build\CNeptune.exe whereas the package folder can be found under packages\CNeptune.1.2.1\build\CNeptune.exe (it's a rootfolder for all projects and solutions).
Is there a possibility to adapt this that i lookt to the nuget.config repositorypath instead of the default path?

To reproduce this, create a NuGet.Config file with for example the following contents
<?xml version="1.0" encoding="utf-8"?>
<configuration>
  <config>
    <add key="repositoryPath" value="$\..\packages" />
  </config>
</configuration>

if such a file with $\..\packages is placed in a parent/ancestor folder to the project folder, CNeptune won't work.

A workaround is to replace
  <Import Project="c:\foo\bar\packages\CNeptune.1.2.1\build\CNeptune.targets" Condition="Exists('c:\foo\bar\packages\CNeptune.1.2.1\build\CNeptune.targets')" />
  <Target Name="EnsureNuGetPackageBuildImports" BeforeTargets="PrepareForBuild">
    <PropertyGroup>
      <ErrorText>This project references NuGet package(s) that are missing on this computer. Use NuGet Package Restore to download them.  For more information, see http://go.microsoft.com/fwlink/?LinkID=322105. The missing file is {0}.</ErrorText>
    </PropertyGroup>
    <Error Condition="!Exists('c:\foo\bar\packages\CNeptune.1.2.1\build\CNeptune.targets')" Text="$([System.String]::Format('$(ErrorText)', 'c:\foo\bar\packages\CNeptune.1.2.1\build\CNeptune.targets'))" />
  </Target>

in your .csproj with
  <PropertyGroup>
    <BuildDependsOn>
      $(BuildDependsOn);
      CNeptune
    </BuildDependsOn>
  </PropertyGroup>
  <Target Name="CNeptune">
    <Exec Command=""$(SolutionDir)\..\packages\CNeptune.1.2.1\build\CNeptune.exe" "$(ProjectPath)" "$(Configuration)"" />
  </Target>

(where you may need to modify the Command to your needs.


Recipe Model, Recipe Router | WIP

[x] - Model Added | Find by ID
[x] - Module export for getRecipeById
[ ] - Need Error Catching

[x] - Error Catching Added
Side Note:
Running into an issue with regarding my modules. Unsure what to do.

The find by id router added. Causing some issues. Error is above ^


[BUG] vela help needs clean up

The help page of vela cli is barely readable for now. We need to clean it up with Appfile-centric.
Suggesting changes:
✈ The Fully Extensible App Platform based on Kubernetes and Open Application Model.

Usage:
  vela [flags]
  vela [command]

Available Commands:

install            Install KubeVela.
up                 Apply an Appfile.

config             Manage application configurations.
env                Manage deployment environments.
delete             Delete applications.
exec               Execute a command in application container.
logs               Tail logs for application.
ls                 List applications.
port-forward       Forward one or more local ports to an application.
show               Get details of an application.
status             Get status of an application.
completion         Output shell completion code.
dashboard          Launch Dashboard (preview).
system             System settings.

workloads          List available workload types.
traits             List available operational features.
template           Manage templates and parameters
cap                Manage capabilities.

Flags:
  -h, --help   help for vela

Use "vela [command] --help" for more information about a command.

All these commands above are static so we could make vela cli just like any other cli. Usage of alternative commands are available on this doc., this should be enough for short term. For long term, we will see how the community react to those shortcut commands, I personally like $ vela init and $ vela autoscale very much.

How about regroup them into:

Getting Startedinstall            Install KubeVela.
up                 Apply an Appfile.

Managing Applicationsconfig             Manage application configurations.
env                Manage deployment environments.
delete             Delete applications.
exec               Execute a command in application container.
logs               Tail logs for application.
ls                 List applications.
port-forward       Forward one or more local ports to an application.
show               Get details of an application.
status             Get status of an application.

Managing Capabilitiesworkloads          List available workload types.
traits             List available operational features.
template           Manage templates and parameters
cap                Manage capabilities.

Systemcompletion         Output shell completion code.
dashboard          Launch Dashboard (preview).
system             System settings.

Per offline discussion, let's add Hidden: true to all of the following commands:
config             Manage application configurations.
env                Manage deployment environments.
delete             Delete applications.
exec               Execute a command in application container.
logs               Tail logs for application.
ls                 List applications.
port-forward       Forward one or more local ports to an application.
show               Get details of an application.
status             Get status of an application.

Should we keep vela status/port-forward? They are essential to charts operation and status checking.


Branch planner - dependencies are on original objects, not the branch objects, causing lock clashes

User Story
As a Terraform user, I want to be able to complete my operation whenever I make a change in a branch whose objects have dependencies, so that I can have focused visibility into the changes I’m applying in that branch and not be blocked.
Implementation/Steps

[ ] Delete the dependency block ("easy fix")
[ ] Do the planning independently. Not sure about side effect of doing this and how it would affect current chain of provisioning, however, so will observe what happens.
[ ] Ask @darrylweaver to see if it resolves the rest of his problem. (The duplication will not go away right now.)
[ ] If it doesn’t go away, then we’ll iterate.

Acceptance Criteria

[ ] The user no longer experiences locking of their operation (i.e. when two objects do similar planning on the same set of resources and the operation stops like a race condition).
[ ] The plan works for the objects with dependencies. The original resources get paused until the planning process is done, then the user can merge and resume the object.
[ ] User no longer sees duplicate output in situations where multiple objects per cluster generate multiple TF outputs.

When using several terraform CRs, where:

Target is used to target a particular resource for that terraform run
Dependencies are declared between terraform CRs
A shared state is used to deploy each target once only

The branch planner would create all the terraform CRs with the suffix -pr-XX
But the dependencies in the generated terraform CRs still point to the original resources.
This results in multiple terraform CRs running simultaneously and lock clashes.  Eventually all the terraform CRs will run to completion due to eventually gaining the lock file.
The terraform CRs should have the dependencies updated so that they run in the right order for the PR resources instead.
It should be noted that this would still not result in a correct plan in all cases, depending on the targets used and when no targets are used, but typically these would be duplicates of changes rather than missing any changes.
An example of this would be:
A single Terraform HCL directory defining a VPC, EKS cluster and K8s config.
3 Terraform controller CRs that have targets set of:
module.vpc
module.eks
and finally no targets set at all.
And dependencies so that the module.vpc runs first, then module.eks, then all the rest of the config for k8s.
For the branch planner:
When the module.vpc runs it identifies any changes to the VPC.
When the module.eks runs it identifies any changes to the EKS cluster.
When the no target runs it identifies all changes to the VPC and EKS cluster and K8s.
this results in PR comments that show all the changes, but VPC changes more than once.

@chanwit Some things for us to clarify based on my chat with @madAndroid:

Re: deleting the dependency block:  Is the dependency removal temporary? And do you reinstate them when the run is done?
In some contexts you will need the dependencies available, otherwise you will make the situation worse because the dependency is there for a reason. The dependencies are on the original objects. If you have shared state between resources you will see it.
How do we know this won’t cause bigger problems, what’s the impact?
Does this mirror TF behavior?

The technical stuff behind this scenario is quite complex. So I'm explaining here again:
Initially, you have a chain of Terraform objects with dependencies:
  (A)
   |
  (B)
   |
  (C)

Then you'd like to create a PR for object (B) and the Branch Planner would do the followings:

Suspend (B), so the state of (B) would change to suspended B. We'll denote with (B-s).

  (A)
   |
 (B-s)
   |
  (C)

We then clone (B-s) to (B') and we got this setup:

   (A)
    |  \
 (B-s)--(B')
    |  /
   (C)

We then remove (B') from the dependency chain because it would be planned independently (of cause it's still be able to read secrets from the original chain.

   (A)
    |
 (B-s)--(B')
    |
   (C)

After we happy with the PR, we merge (B') to (B-s). After resume (B-s) would become (B) and GitOps continues.

  (A)
   |
 (B)
   |
  (C)


gotools: 2020-10-27 -> 2021-01-13

Motivation for this change
Upstream update
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.
Result of nixpkgs-review pr 109314 run on x86_64-linux 1

5 packages built:

go2nix
gotools
vimPlugins.YouCompleteMe
vimPlugins.vim-go
ycmd

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.
Result of nixpkgs-review pr 109314 run on x86_64-linux 1

5 packages built:

go2nix
gotools
vimPlugins.YouCompleteMe
vimPlugins.vim-go
ycmd


add helper for removing module names section

Let me know if this would be accepted and I will add tests.

Hey, thanks for the PR!
The code makes sense although it seems to me a bit niche and implementable without this function. So this makes me wonder what is your use-case?

https://github.com/wasmx/wasm-chisel has a wasm sanitization tool which strips the name section from the module.  I understand if this is too niche to merge into the codebase.

The code makes sense although it seems to me a bit niche and the functionality seems to be implementable without this function.

I agree it is niche, but clear_start_section and clear_custom_section also exists, which may be considered similarly niche.
One reason to consider this PR is that the names section is a bit special, because it has a different section type once parsed.


Add troubleshooting note for pending admission checks

What type of PR is this?
/kind documentation
What this PR does / why we need it:
Just a quick note about what to look for when using admission checks. We should probably have a dedicated page for ProvisioningRequest and MultiKueue specifically, but I'll leave those for a follow up.
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:
@pajakd recently improved the messaging for ProvisioningRequest in #2007, but we can update that in a separate PR, after we cherry-pick this one.
I also opened #2121 to improve the Admitted condition during this time.
Does this PR introduce a user-facing change?

NONE

/cherry-pick website

I'm curious about whether we should provide the criteria to unsuspend Jobs in doc somewhere like:

QuotaReserved=True && Admitted=True
QuotaReserved=True && AdmissionCheck[*].state=Ready && Admitted=True

Don't you worry, I'm working on a state diagram for Workload statuses 😄
I can send it after fixing #2121

I'm curious about whether we should provide the criteria to unsuspend Jobs in doc somewhere like:

QuotaReserved=True && Admitted=True
QuotaReserved=True && AdmissionCheck[*].state=Ready && Admitted=True

Don't you worry, I'm working on a state diagram for Workload statuses 😄
I can send it after fixing #2121

Great to hear! Thank you!


Support pinning to a minor version

See, e.g., the way that setup-deno supports pinning to a major or minor: https://github.com/denoland/setup-deno?tab=readme-ov-file#latest-stable-for-a-major

(To do this, we need a way to query for releases.)

We currently query all available releases when updating the known checksums: https://github.com/astral-sh/setup-uv/blob/1785c7bde0a2a59e1567d8e62720f439ebdf1e2b/src/update-default-version.ts#L14-L26

Hello! Any progress on this?


Bug

Describe the bug
A clear and concise description of what the bug is.
I'm getting "Subscript out of range" in Excel when calling "LibFileTools"
on a MAC running the latest onedrive. I tried resetting onedrive and the error re-appeared. I also re-synced the local folder and still get the error. It seems to happen on one mac, it works on mine ok it seems.
in the following code (LibFileTools):
In the line "ReDim Preserve outdirs.arrDirs(1 To outdirs.dirCount)"
    If i = 0 Then
        lastRecord = lastRecord + chunkSize - leadingBuff
    Else
        lastRecord = lastRecord + i - leadingBuff
    End If
Loop Until lastRecord > size
ReDim Preserve outdirs.arrDirs(1 To outdirs.dirCount)

CloseFile:
Close #fileNumber
End Sub

Hi @dcircleinc
I just pushed a minor update. Does that fix the issue?

￼
And to be clear I am calling it using GetRemotePath(ThisWorkbook.FullName) which returns the URL.
I also have extra code if it returns a non http header to use localpath.
Ryan Taliercio
@.***

On Oct 1, 2024, at 4:19 PM, Cristian Buse @.***> wrote:
Closed #29 https://github.com/cristianbuse/VBA-FileTools/issues/29 as completed.
—
Reply to this email directly, view it on GitHub https://github.com/cristianbuse/VBA-FileTools/issues/29#event-14479029773, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAHBDF5STE27Z7MD7FQNCNLZZL7U5AVCNFSM6AAAAABOWJCXG6VHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJUGQ3TSMBSHE3TOMY.
You are receiving this because you were mentioned.

Mac VBA7 x64

Accounts found: 1
Name: Personal
ID: 95bbe8e999b9a6af
Has DAT: True
Is Valid: True

Providers found: 7
Base Mount: /Users/ryan/Library/Group Containers/UBF8T346G9.OneDriveSyncClientSuite/OneDrive.noindex/OneDrive
Is Business: False
Is Main: False
Mount Point: /
Sync ID: 564ad8ab-4e36-4f3a-9eff-0ae1bb13a24d
Web Path: https://d.docs.live.net/95bbe8e999b9a6af/
Sync Dir:
Base Mount: /Users/ryan/Library/Group Containers/UBF8T346G9.OneDriveSyncClientSuite/OneDrive.noindex/OneDrive
Is Business: False
Is Main: False
Mount Point: /Sofabed Cashsheets/
Sync ID: 564ad8ab-4e36-4f3a-9eff-0ae1bb13a24d
Web Path: https://d.docs.live.net/d60675b8af8da0f7/Sofabed Cashsheets/
Sync Dir:
Base Mount: /Users/ryan/Library/Group Containers/UBF8T346G9.OneDriveSyncClientSuite/OneDrive.noindex/OneDrive
Is Business: False
Is Main: False
Mount Point: /CASHSHEET TEMPLATES for Neil/
Sync ID: 564ad8ab-4e36-4f3a-9eff-0ae1bb13a24d
Web Path: https://d.docs.live.net/d60675b8af8da0f7/CASHSHEET TEMPLATES/
Sync Dir:
Base Mount: /Users/ryan/Library/Group Containers/UBF8T346G9.OneDriveSyncClientSuite/OneDrive.noindex/OneDrive
Is Business: False
Is Main: False
Mount Point: /Seigermans CASH SHEETS/
Sync ID: 564ad8ab-4e36-4f3a-9eff-0ae1bb13a24d
Web Path: https://d.docs.live.net/de05781aea838628/Documents/Seigermans CASH SHEETS/
Sync Dir:
Base Mount: /Users/ryan/Library/Group Containers/UBF8T346G9.OneDriveSyncClientSuite/OneDrive.noindex/OneDrive
Is Business: False
Is Main: False
Mount Point: /Natuzzi Cash Sheets/
Sync ID: 564ad8ab-4e36-4f3a-9eff-0ae1bb13a24d
Web Path: https://d.docs.live.net/8cc293ffa7f430b9/Natuzzi Cash Sheets/
Sync Dir:
Base Mount: /Users/ryan/Library/Group Containers/UBF8T346G9.OneDriveSyncClientSuite/OneDrive.noindex/OneDrive
Is Business: False
Is Main: False
Mount Point: /110 CASH SHEETS IN HERE/
Sync ID: 564ad8ab-4e36-4f3a-9eff-0ae1bb13a24d
Web Path: https://d.docs.live.net/51207bab5645f67e/CASH SHEETS IN HERE/
Sync Dir:
Base Mount: /Users/ryan/Library/Group Containers/UBF8T346G9.OneDriveSyncClientSuite/OneDrive.noindex/OneDrive
Is Business: False
Is Main: False
Mount Point: /Showplace CASHSHEETS/
Sync ID: 564ad8ab-4e36-4f3a-9eff-0ae1bb13a24d
Web Path: https://d.docs.live.net/39e895601e7750c9/Desktop/CASHSHEETS/
Sync Dir:

Oops I said it wrong here’s how I call it:
folderPath = ThisWorkbook.FullName
Debug.Print "Folder Path Initial: " & folderPath
  If (InStr(1, folderPath, "http") > 0) Then
 folderPath = GetLocalPath(folderPath)
  Debug.Print "Folder Path Remote: " & folderPath

End If

Ryan Taliercio
@.***

On Oct 1, 2024, at 4:19 PM, Cristian Buse @.***> wrote:
Closed #29 https://github.com/cristianbuse/VBA-FileTools/issues/29 as completed.
—
Reply to this email directly, view it on GitHub https://github.com/cristianbuse/VBA-FileTools/issues/29#event-14479029773, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAHBDF5STE27Z7MD7FQNCNLZZL7U5AVCNFSM6AAAAABOWJCXG6VHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJUGQ3TSMBSHE3TOMY.
You are receiving this because you were mentioned.


[Android] Fix onKeyPress so it provides the correct key when TextInput is at max length

Summary
Fixes #30747 making Android behave the same as iOS under the same scenario.
When autosuggest is enabled (which is the default), then the keypress is inferred based on cursor position. The issue appears when max length is reached where we can no longer guess the keypress based on cursor location alone.
The problem can be reproduced using the expo snack provided in the original issue:
https://snack.expo.io/PuyXgucEf
Changelog
[Android] [Fixed] -  Fix onKeyPress so it provides the correct key when TextInput has keybard suggestions and is at max length.
Test Plan
Tested using RNTester app in Components > TextInput > Event handling example and adding a maxLength prop.

Enter text in the input until maxLength is reached.
The value printed 'onKeyPress key' should be the actual key pressed.

Before
https://user-images.githubusercontent.com/24393922/104839131-376eab00-58fa-11eb-8bde-eaddefecd467.mov
After
https://user-images.githubusercontent.com/24393922/104839187-81f02780-58fa-11eb-9a77-91189d4edefc.mov

Regarding the commit: fix: backspace keypress not inferred when max length is 0:
It fixes an edge case issue introduced by the previous commit.
When maxLength is set to 1 or more and the max length is reached, the composing text never changes. So backspace can be inferred correctly. However, when maxLength is set to 0 then whatever the user types is appended to the composing text and therefore we can no longer infer the backspace keypress.
The videos below demonstrate the issue and the result of the fix introduced in this commit.
In both theses videos, maxLength is set to 0.
Before
https://user-images.githubusercontent.com/24393922/104837671-105fab80-58f1-11eb-9a7f-c293299e5a54.mov
After
https://user-images.githubusercontent.com/24393922/104837919-c4ae0180-58f2-11eb-81dc-fd199357238b.mov

Regarding the commit: fix: backspace keypress not inferred when max length is 0:
It fixes an edge case issue introduced by the previous commit.
When maxLength is set to 1 or more and the max length is reached, the composing text never changes. So backspace can be inferred correctly. However, when maxLength is set to 0 then whatever the user types is appended to the composing text and therefore we can no longer infer the backspace keypress.
The videos below demonstrate the issue and the result of the fix introduced in this commit.
In both theses videos, maxLength is set to 0.
Before
https://user-images.githubusercontent.com/24393922/104837671-105fab80-58f1-11eb-9a7f-c293299e5a54.mov
After
https://user-images.githubusercontent.com/24393922/104837919-c4ae0180-58f2-11eb-81dc-fd199357238b.mov

cc @JoshuaGross to check out this PR.
Quick turn around for a reported issue here: https://github.com/facebook/react-native/issues/30747

cc @JoshuaGross to check out this PR.
Quick turn around for a reported issue here: https://github.com/facebook/react-native/issues/30747