Other release tags should be accepted on exported symbols

So, Knip considers that stuff marked as @public is OK to be exported if not used since it is intended for external consummers of the code.
I think it should do the same for some of the other release tags:

@internal => report. This is intended for internal use only, if it is not used, it should be pruned.
@beta, @public => do not report. These are meant (also) for third party usage.
@alpha => I'm less sure 😅 I'd say do not report since it show that the intention is to open it later (even if 3rd party are encouraged to not use it…)

This pretty much prevents the use of @beta tags on external API since having both @beta @public is a big no, and Knip will keep reporting on the unused @beta symbol.

They do exist in TS doc. Iirc, only in API extractor I've seen them called "release tags".
Also seems like TS, TS doc and API extractor are more or less the same people at Microsoft: https://tsdoc.org/#whos-involved
The fact that there is an official TS doc spec hint that Knip should likely respect it when dealing with TS code 🤔

I've added @beta as a tag like @public, should be released soon!
Added some tests. Also see #193.

:rocket: This issue has been resolved in v2.19.7. See Release 2.19.7 for release notes.

Should have been a minor bump (new feature), not a patch bump. Oh well.

Awesome. Thanks.


Accordion default children prop is causing the component to break in my codebase

Duplicates

[X] I have searched the existing issues

Latest version

[X] I have tested the latest version

Current behavior 😯
I am basically trying to give children as a default prop i.e. <div /> in my component and when the user has dragged an Accordion but this is happening in the page -

the error in the console is as follows -

and when I click on the Accordion.js on the above -

I saw the type of Accordion children prop its -

Shouldn't it be just a React.ReactNode??
It works when I had given default children in the codesandbox as-
<AccordionSummary                 aria-controls="panel1a-content"                 id="panel1a-header"             >                 <Typography>Add Something to the Children</Typography>   </AccordionSummary>
But in my codebase I still get the same above error
Expected behavior 🤔
The component shouldn't break while adding it even if it doesn't have a children.
Steps to reproduce 🕹
Steps:
1.Open the sandbox and try giving different default values for the children -
https://codesandbox.io/s/silent-glade-8y80sp?file=/demo.tsx
2.
3.
4.
Context 🔦
I am trying to make an Accordion component for the implementors using a lowcode tool.

  Output from `npx @mui/envinfo` goes here.

Guys any eta for this?

Can you update the Codesandbox to actually show the issue? Yep, the accordion expects at least one element to be defined as children, as it shows it as a title in the accordion itself. Everything rest is considered a content that will be shown when the accordion is opened. This ensures that a11y will work as expected.

To be honest I am not able to reproduce it on the codesandbox but in my codebase whenever I drop an Accordion -

I mean I have possibly tried giving many possible default values for my children prop

We can't really do something without a reproduction that we can debug. I am closing the issue, feel free to re-open once you are able to reproduce this in a sandbox (it could be a GitHub repository too).


Error running dotdocker on Ubuntu 18.04

Describe the bug dotdocker fails with resolution error during configuration on an Ubuntu 18.04 VM
To Reproduce
make sure docker-proxy is stopped by running docker-proxy stop
sudo systemctl stop systemd-resolved (note - if I restart this before running dotdocker I get the same error)
add <IP_ADDRESS> to /etc/resolv.conf
sudo npm install -g dotdocker
kill any processes on ports 53, 80, 443
sudo dotdocker start
output:
sudo: unable to resolve host ip-*machine-ip*
  ❯ Start dotdocker containers
    ❯ Start proxy
      ⠏ Pulling codekitchen/dinghy-http-proxy:latest
        → 4c394a654280: Download complete
        Creating dotdocker-proxy
        Starting dotdocker-proxy
    ❯ Start dnsmasq
      ✔ Pulling andyshinn/dnsmasq:latest
      ✔ Creating dotdocker-dnsmasq
      ✖ Starting dotdocker-dnsmasq
        → (HTTP code 500) server error - driver failed programming external connectivity on endpoint dotdocker-dnsmasq (697c21fa66b20918b27c81da376
…
    Setting up DNS
(node:8818) UnhandledPromiseRejectionWarning: Error: (HTTP code 500) server error - driver failed programming external connectivity on endpoint dotdocker-dnsmasq (697c21fa66b20918b27c81da3761a7a38055af0ae7705d0c826afa9c35d883c5): Error starting userland proxy:
    at /usr/local/lib/node_modules/dotdocker/node_modules/docker-modem/lib/modem.js:257:17
    at getCause (/usr/local/lib/node_modules/dotdocker/node_modules/docker-modem/lib/modem.js:287:7)
    at Modem.buildPayload (/usr/local/lib/node_modules/dotdocker/node_modules/docker-modem/lib/modem.js:256:5)
    at IncomingMessage.<anonymous> (/usr/local/lib/node_modules/dotdocker/node_modules/docker-modem/lib/modem.js:232:14)
    at IncomingMessage.emit (events.js:203:15)
    at endReadableNT (_stream_readable.js:1129:12)
    at process._tickCallback (internal/process/next_tick.js:63:19)
(node:8818) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). (rejection id: 1)
(node:8818) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.

Expected behavior I would expect dotdocker setup to succeed.
Screenshots N/A (see log output above)
Additional context aj-may mentioned making sure no other process was running on port 53 and making sure Docker has permissions to listen on that port. I've checked the first but not the second - would the best way to do the latter just be to run sudo /usr/bin/docker daemon -H tcp://<IP_ADDRESS>:53 -H unix:///var/run/docker.sock?

I've gotten past that error and on to a later one:
✖ Starting dotdocker-dnsmasq
        → (HTTP code 500) server error - driver failed programming external connectivity on endpoint dotdocker-dnsmasq (7dae2c6db5e4deb199b0e24df6e
…
    Setting up DNS
(node:20519) UnhandledPromiseRejectionWarning: Error: (HTTP code 500) server error - driver failed programming external connectivity on endpoint dotdocker-dnsmasq (7dae2c6db5e4deb199b0e24df6eee7b131bc88ce0eb644cb74d4d411b630f3a5): Error starting userland proxy:
    at /usr/local/lib/node_modules/dotdocker/node_modules/docker-modem/lib/modem.js:257:17
    at getCause (/usr/local/lib/node_modules/dotdocker/node_modules/docker-modem/lib/modem.js:287:7)
    at Modem.buildPayload (/usr/local/lib/node_modules/dotdocker/node_modules/docker-modem/lib/modem.js:256:5)
    at IncomingMessage.<anonymous> (/usr/local/lib/node_modules/dotdocker/node_modules/docker-modem/lib/modem.js:232:14)
    at IncomingMessage.emit (events.js:203:15)
    at endReadableNT (_stream_readable.js:1129:12)
    at process._tickCallback (internal/process/next_tick.js:63:19)
(node:20519) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). (rejection id: 1)
(node:20519) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.


Fix file download

Seems like jupyterfs.metamanager.MetaManager class do not set root directory that ContentsManager expects. When we try to download a file, it will throw an error that path is not set. This PR fixes it.

@mahendrapaipuri I'm going to apply your fix on my fork: https://github.com/timkpaine/jupyter-fs/pull/6

@timkpaine Sure, let me know if everything works!! I notice that you are working on supporting this extension for JL4 as well. I would be happy to contribute if you need help!

done in https://github.com/jpmorganchase/jupyter-fs/pull/174


Highlight on template area if any of the section is focused by user

Looks like this is almost same as https://github.com/sadanandpai/resume-builder/issues/86?


Implement big-endian raw import

Another field to select between little- and big-endian raws in the open data menu would be  helpful.

Lieber Dieter Weber,
ich bin Benedikt Haas aus der AG von Christoph Koch; wir haben uns neulich gesehen. Die Anwendung ist eine Kamera an unserem modifizierten SEM (eine Lumenera Lu 170).  Aber falls die Implementierung aufwändig ist (was ich nicht vermutete) könnte ich nachvollziehen, dass es nicht gemacht würde, da unserer vermutlich doch ein eher seltener Fall ist.
Beste Grüße,
Benedikt Haas
On Nov 3, 2018, 12:23, at 12:23, Dieter Weber<EMAIL_ADDRESS>wrote:

@unsimulatable which camera or file format for pixelated STEM uses big
endian raw data? Implementing this option makes sense if there's a
specific use case.
--
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
https://github.com/LiberTEM/LiberTEM/issues/144#issuecomment-435580230

Implementation should be more or less straight-forward, reading big-endian files will have some performance impact though. Scheduling this for the 0.2 milestone, as we are very close to releasing 0.1.
Let me know if you'd like to have a try at implementing it yourself!

@unsimulatable @sk1p Sounds good! :+1:

By the way, fast endian conversion could be a nice first issue to try some performance engineering. The operation is simple enough and should be very, very fast if it is implemented right. The approach would be to test if built-in methods are fast enough, and if not build a faster one with numba.

Hi @unsimulatable - we just realized that this is already possible given the current raw reader! You can use the standard numpy way to denote endianess, for example for big-endian 16bit unsigned ints, use >u16. See the numpy documentation for details on dtype specification. Note that there was a bug in an unrelated code path that prevented endian-annotated dtypes from working, which I just fixed in<PHONE_NUMBER>f36671d47fc15d95ff1582996695dd, so in practice this only works with the latest development release.
So, the point now would be to add this to our documentation so that it doesn't get lost.
The performance overhead should not be so bad, but I didn't benchmark it in any comprehensive way.
Please, let me know if this works for you or if you need any more assistance!

Hi @sk1p, I tried it with the latest release version (the one I obtained by updating via pip) and using the correct expression for big-endian unsigned 16bit (which actually seems to be >u2) and I got an error (the message read just '>u2'). In comparison, if I just type something that is not a data type into the data type field, like xyz, the error message reads 'data type "xyz" not understood'.

Yes, >u2 is correct, sorry. Installing via pip (pip install libertem) gives you the latest stable release, 0.1, which does not yet have this bug fixed. You need the current development version for that to work, which means either installing via git (as described in our documentation), or using the continuously built AppImage (Linux only). If you'd like to keep up-to-date with current developments, keeping a local git clone is preferrable. Let me know if this works for you!

Yes, it works using the git clone. Thanks, problem solved!


Update grain placement docs

Fixes https://github.com/dotnet/orleans/issues/6376

Docs Build status updates of commit c62208b:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

Line 0, Column 0: [Error-config-not-found] Can't find docfx config file in 'W:\p0ux-s'.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


REST API: add support for bulk query for all CT Pids

Add support for bulk querying list of container names with their corresponding init pids.
Current behaviour  forces you to ask this info per container, for 500+ CTs this takes some time.

Unfortunately that particular query isn't as easy and cheap as it sounds as LXD itself doesn't know the PID of those containers and so will internally need to reach to liblxc for every container which is where most of the delay from querying container info comes from.
There is certainly a bit of overhead in doing an API call for every container, but based on previous testing, we're talking in the 5% range here, so not quite as big an improvement as you might be hoping for.
What exactly do you need the PID for in your case?

@stgraber I am using this to expose cgroup metrics to gather accounting data, statistics that LXD provides via API sadly are not enough for me.

@s3rj1k ok, then if you're already running scripts outside of LXD on the host you could likely just go fish out the paths under /sys/fs/cgroup directly. Either by assuming that the entry will start with the container name (may be followed by -1, -2, ...) or if you want to parse /proc/PID/cgroup to be completely sure to get the right cgroup, a cheap-ish solution is to locate the [lxc monitor] process for the container and then find its only child which would be the init process of the container.
That effectively lets you get the PID information for the container without ever having to talk to LXD or liblxc.

A pretty simple approach is:
LXCPATH=${1:-}

ps aux | grep '\[lxc monitor\]' | while read line
do
    set -- ${line}

    [ "${LXCPATH:-$13}" != "$13" ] && continue

    NAME="${14}"
    PID="$(pgrep -P ${2})"

    echo "${NAME} -> ${PID}"
done

I'm closing this issue as we'll not be adding a new API just to get container to pid mapping.
I'm however open to expanding the /1.0/containers?recursion API to allow the inclusion of the state of all containers in there (recursion=2) which would allow most cases of lxc list to work with a single, horribly slow query. That wouldn't really make things faster in this particular case though.
We'd also certainly consider adding more fields to the existing state API, possibly exporting the information you need in there so you don't need to go parse cgroups yourself (though that'll depend on exactly what metric you're extracting).


introduce HKT to vavr

support HKT encoding in Java,helpful to building Effect like thing in Java

How do you think it will be possible to do this in current version of Java?

Thanks for the suggestion. In Javaslang there were Kind1 and Kind2 for that purpose. But they had several caveats and I removed them. I was invited as an admin for
https://github.com/KindedJ/KindedJ, a library that wants to provide standard HKT interfaces for Java but I decided not to pollute Vavr’s API with this kind of abstractions.
Simply spoken, it isn’t currently possible in Java to implement higher-kinded types that work across deep type hierarchies. As a responsible library designer, I can’t add such a non-working feature into Vavr’s code base.
Another reason is my strategic decision to keep algebraic / math related API out of Vavr. Our functionality is inherently algebraic. I don’t see the necessity to move to a non-existing audience that does purely functional programming in Java using algebraic abstractions.


[DINGO-1723] Add url validation

🐕
/cc @zendesk/dingo
Description
A private app (and potentially any marketplace app) can contain JavaScript in the manifest.json file which gets executed from the {subdomain}.zendesk.com domain.
STEPS TO REPRODUCE

Update the url field in an app in the manifest.json file to "url": "javascript:alert(document.domain)"
Package the app and Upload the private App to your account.
One the app is installed, click on the App and as the url field is populated, you will see an option to click on the "developer website" link.
Click on the link and the javascript will trigger the alert within the context of the accounts subdomain.

An attacker can use this vulnerability to construct a request that, if issued by another application user, will cause JavaScript code supplied by the attacker to execute within the user's browser in the context of that user's session with the application, steal user's cookies, etc.
References
https://zendesk.atlassian.net/browse/DINGO-1723
Risks

[low] validate url

@zendesk/localization


Documentation on categorical judgments. Close #248.

@jonsterling We need a label for documentation.

@favonia

We need a label for documentation.

done


Update the Disbursements table by adding the status column

What
Update the Disbursements table by adding the status column.
Fix: also add the option to filter payments in the CANCELED state.
Why
User feedback.

stellar-disbursement-platform-frontend-preview is available here:http://sdp-frontend-pr194.previews.kube001.services.stellar-ops.com/


 Updates

Second set of changes to previous PR.

Coverage increased (+0.007%) to 91.583% when pulling ab32635fc1fa66eb7b1e9145e834fa21a534b23d on RickCarlino:password_fields into 7a8f16d4cf6249140958b405eac15cc5e3646d76 on FarmBot:staging.


Resolved Bug 522 : Storybook > Charts > Scatter Chart > Docs > Scatter Chart Icon Does Not Display Proper

Description

bug id :  #651- Design System > Elements > alert > With icon > Icon stroke field > Icon stroke field is not working #651-

bug id : #522-Storybook >Charts>Scatter Chart>Docs> Scatter Chart icon does not display proper.
Bugs Resolved :
bug id :  #651 : Icon stroke is no longer needed So commented out the property stroke
bug id : #522 : Chart icon displaying properly
Screenshots :

Changes Reviewed and PR Approved


Singularity build error downloading

I have been attempting to build the latest fmriprep (1.2.6) as a Singularity container using Singularity 2.6, and have been running into issues apparently in downloading the various layers:
singularity build FMRIPrep-1.2.6.simg docker://poldracklab/fmriprep:1.2.6
Docker image path: index.docker.io/poldracklab/fmriprep:1.2.6
Cache folder set to /pine/scr/t/r/trhenry/.singularity/docker
[1/28] ||----------------------------------|   0.0% ERROR Error downloading https://index.docker.io/v2/poldracklab/fmriprep/blobs/sha256:3add0dfae14aa1c9d695f63dccb63f29640912a45e27ae6b53d496e86dacea11. Do you have permission to write to /pine/scr/t/r/trhenry/.singularity/docker?
ERROR Error downloading https://index.docker.io/v2/poldracklab/fmriprep/blobs/sha256:bffb9e4658d2a307c690468069ca77d0fb7885669f8b930ad524034283afb524. Do you have permission to write to /pine/scr/t/r/trhenry/.singularity/docker?
ERROR Error downloading https://index.docker.io/v2/poldracklab/fmriprep/blobs/sha256:b1081868115e32040e9afeeb1702ab6056f2ac95f7a77232107ea3cc59888afe. Do you have permission to write to /pine/scr/t/r/trhenry/.singularity/docker?
ERROR Error downloading https://index.docker.io/v2/poldracklab/fmriprep/blobs/sha256:c832082614738021cf51d68e84457a45a3f85dbe0ddbb93000c5dc5aae77fe93. Do you have permission to write to /pine/scr/t/r/trhenry/.singularity/docker?
ERROR Error downloading https://index.docker.io/v2/poldracklab/fmriprep/blobs/sha256:4f64328238f2cf9841528bef1b9f8e1537bcb2bf51a0560054784ffb5e596e98. Do you have permission to write to /pine/scr/t/r/trhenry/.singularity/docker?
[2/28] |==|--------------------------------|   7.1% ERROR Error downloading https://index.docker.io/v2/poldracklab/fmriprep/blobs/sha256:83e3db7d3f3af26fd7ab31e87deca6788a1b5fc5ed2d538fd2b4c4000f8ab802. Do you have permission to write to /pine/scr/t/r/trhenry/.singularity/docker?

These types of errors occur when I build it on the university cluster (where space is not an issue), or on a local virtual machine (this virtual machine specifically).
They also occur even after deleting the .singularity cache directories, disabling singularity caching entirely, and/or setting the cache directories to folders that I definitely have read write permissions, see this issue  for some related errors.
Finally, I have no issues building other containers from dockerhub, though none have been quite so large as fmriprep. Do you folks have any advice for building the newest version? Thanks!

Hi @trh3, I've been stuck with docker2singularity since pre-2.5 times and it seems to save me quite a bit of trouble. My command line of reference is:
docker run --privileged -ti --rm -v /var/run/docker.sock:/var/run/docker.sock -v $PWD:/output singularityware/docker2singularity -m "/gpfs /scratch /work /home1 /share /share/PI /local-scratch /oak /opt/freesurfer/license.txt" poldracklab/fmriprep:1.3.0.post1

Then I manually upload the image to the cluster.
I have just tried to replicate your problem, but it seems to work for me. I would suggest to post this issue to singularity.


Is there a way to keep the original image at a high resolution instead of resizing it to 256x256 ?

It will require training a new model with higher resolution, but it will consume much more GPUs. Current model only supports the low resolution.

Got it. Thanks!


[No QA] Switch warnCPLabel trigger from pull_request to pull_request_target

Details
The warnCPLabel.yml workflow has been failing on any PR from a fork. This PR should fix that.
More discussion here.
Fixed Issues
$ n/a
Tests

Merge this PR.
Create a PR and give it the CP Staging label. OSBotify should comment on the PR explaining the implications of the CP Staging Label.
Create a PR from a fork of Expensify/App and give it the CP Staging label. OSBotify should comment on the PR explaining the implications of the CP Staging Label.

Tested On
n/a – Live testing in GH only.

Does it still need OS_BOTIFY_TOKEN to make a comment or would a github token do it?

I think just GITHUB_TOKEN would do it

Changing it would also have the side-effect of the comment not being left by OSBotify, but that's nbd if you think there's a reason to use only the GITHUB_TOKEN instead.

Which is "more secure" or "more secret"?

I think OS_BOTIFY_TOKEN has some additional permissions so is therefore "more secret". I can update this PR to change the token used.

Okay, beginning testing now

One reminder for the test steps, I think your main you branch or fork off of has to be up to date to have this updated workflow run

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

So if we see this fail on contributor fork's, I think they will have to merge main in

Step 2 (regression test) passed: https://github.com/Expensify/App/pull/4380

Nice, step 3 passed: https://github.com/Expensify/App/pull/4381

🚀 Deployed to staging         in version: 1.0.82-8🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by @francoisl in version: 1.0.83-1 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
failure ❌

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Rework log streaming and related functions

closes #1801
closes #1815
closes #1144
closes  #983
closes  #557
closes #1827
regression of #1791
TODO

[x] adjust log model
[x] add migration for logs
[x] send log line via grpc using step-id
[x] save log-line to db
[x] stream log-lines to UI
[x] use less structs for log-data
[x] make web UI work

[x] display logs loaded from db
[x] display streaming logs

[ ] make migration work -> dedicated pull (#1828)

TESTED

[x] new logs are stored in database
[x] log retrieval via cli (of new logs) works
[x] log streaming works (tested via curl & webui)
[x] log retrieval via web (of new logs) works

Codecov Report
Patch coverage: 7.89% and project coverage change: -0.04 :warning:

Comparison is base (f683c62) 38.89% compared to head (60cec1d) 38.86%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1802      +/-   ##
==========================================
- Coverage   38.89%   38.86%   -0.04%
==========================================
  Files         165      166       +1
  Lines       10349    10383      +34
==========================================
+ Hits         4025     4035      +10
- Misses       6060     6084      +24
  Partials      264      264

Impacted Files
Coverage Δ

pipeline/backend/docker/docker.go
0.00% <0.00%> (ø)

server/grpc/rpc.go
0.00% <0.00%> (ø)

server/store/datastore/log.go
32.75% <0.00%> (-23.13%)
:arrow_down:

server/store/datastore/migration/migration.go
36.00% <ø> (ø)

...tore/datastore/migration/017_remove_machine_col.go
50.00% <50.00%> (ø)

... and 2 files with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

@anbraten if you dont have time just push what we did discussed and I'll try to finish it

@6543 Would be nice if you cloud have a look. I've pushed all of my changes. Most things should be fine already. Missing is:

getting the id of a step (not workflow) in: agent/logger.go
testing streaming and loading of logs in UI

well I know why this was so buggy:
it's hard to make a match between the backend-"step"  and the representation in database ... as the pipeline/compiler() do initially create it and the id is added afterwards ... in that proccess this can easely be messed up and that's why there are some workarounds and why the step names have to be crafted  "in a certain way" to be able to obtain information back from it.
I think I have to add the step UUID refactor int this pull to be able to clean up the mess good enouth to make this work
later we can remove a lot of hacks...
how I propose a step lifecycle:

only pipeline compiler is allowed to create them -> it also assigns an uuid that can be used to find stuff
server stores uuid and it's the id used in grpc actions around the step
log pubsub / save ... uses step.uuid

for logs:

server <-grpc-> agent = StepUUID
api <-rest/stream-> server = StepID

As this is in RPC spec can we add also log entry type Command?

As this is in RPC spec can we add also log entry type Command?

there is no such thing in the proto3 file ... the only thing reverence the command is an TODO comment to add it later.
I can remove the code-comment for now if you like?


Table needs to be updated for PrimeReact 7.0.0

In PrimeReact 7.0.0 the DataTable component got changed quite a lot. So after updating to 7.0.0 some adjustments are needed.

Table Update branch has now been merged into master


Let users know how they can "gain access" to publish

Feature Description

Follow up based on: https://github.com/google/web-stories-wp/issues/1372#issuecomment-642446562
We should find a good way to let users know what they can do to gain access they lack in the tool. For example, if a user doesn't have the ability to Publish, we can let them know with a tooltip such as: "You don't have access to publish. Check with your administrator to request access."
We should consider other alternatives for this, but that's the initial proposal put forth by UX.
Alternatives Considered

Additional Context

Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance Criteria

If as user does not have capabilities to publish a story, disable "Publish" button.
When you hover over the publish button, display a tooltip with message "You don't have access to publish a story. Check with your administrator to request access."

Implementation Brief

Un-assigning WP pod as this has no interaction with WP, as it's only about adding a tooltip.

Closing in favor of #7762


Removed redundant injection code from previous merge

Changelog

removed injection code
renamed dist_file to map.html, which will be nested in an iframe within index.html

Thanks!


Add calibration uncertainty marginalization to dingo-pipe

This pull request adds the ability to marginalize over detector calibration uncertainty to dingo-pipe. This takes place during the importance sampling stage.
It adds the following keys to the INI files:

calibration-model
spline-calibration-envelope-dict
spline-calibration-nodes
spline-calibration-curves (not present in bilby-pipe)

Usage is explained in the documentation. It should be noted that these have slightly different interpretation than in bilby-pipe, where one typically performs inference over the calibration parameters rather than marginalizing over them.
In addition, there was a small refactoring of the calibration marginalization code to simplify it.
@jonaswildberger You probably need to update #131 to accommodate these additional INI keys.

Looks good overall! I will test things out a bit more tomorrow. Saraswati seems to not be able to ping github.com at the moment...


Add rustup, clippy and rustfmt to nix-shell

I noticed that running which cargo-clippy within nix-shell pointed to my system install, not the nix store.
We'll need to to be able to run clippy / rustfmt within nix-shell in CI as well ...

Added rustup as well because my global rustup installation was leaking into my build and breaking clippy: https://discord.com/channels/990354215060795454/992503915578933268/997436439845408869
This obviously isn't ideal but @elsirion and I couldn't think of a better option.


Cert renew

Pull request for Certificate Management sample playbooks

I took care of the DCO and pushed it. @adn1107

Signoff was not on this commit, the rebase was a risky merge; it is better to signoff on this after a clean merge.


Only yescrypt is accepted as hashing algorithm

Describe the Issue
The task "Check debian11cis_grub_user password variable has been changed | if password blank or incorrect type and not being set" in tasks/main.yml checks if the password contains $y$. This prefix signifies a yescrypt hashed password. But the CIS hardening guide specifies, that either SHA512 or yescrypt are acceptable hashing algorithms.
https://github.com/ansible-lockdown/DEBIAN11-CIS/blob/e2b418df1ef701ebc6ef7760ea20a0dea090ad1d/tasks/main.yml#L69-L75
Expected Behavior
All hashing algorithms stated in the hardening guide should be accepted. The task should check for either a $6$ prefix (SHA-512) or a $y$ prefix (yescrypt).
Actual Behavior
Only yescrypt is accepted as hashing algorithm.
Control(s) Affected
<IP_ADDRESS> Ensure strong password hashing algorithm is configured (Automated)
Environment (please complete the following information):

branch being used: devel
Ansible Version: 2.15.12
Host Python Version: Python 3.9.6
Ansible Server Python Version: Python 3.9.2

hi @fgierlinger
Thank you for taking the time to highlight this issue. I am raising a PR which should fix this issue and hope to get merged into devel asap.
Many thanks
uk-bolly

hi @fgierlinger
Thank you again for your time regarding this issue. You should find that this fix was merged into devel and is now in the main branch. I will close this issue, please feel free to reopen if this is not resolved as expected.
Many thanks
uk-bolly


Relative Uri building removes path from root

NEST/Elasticsearch.Net version:
7.0.0
Elasticsearch version:
7.0.0
Description of the problem including expected versus actual behavior:
We have elasticsearch located not in the root of url but in some folder. Almost real example: http://site.com/elasticsearch/ . When we try to make Search request with ElasticClient we are getting 404 error because somehow library uses absolute url( http://site.com/{index}/_search?... )
Where this problem appers
src/Elasticsearch.Net/Transport/Pipeline/RequestData.cs
line with
public Uri Uri => Node != null ? new Uri(Node.Uri, PathAndQuery) : null;
As per microsoft documentation of new Uri(Uri,string) in Remarks section

Additionally, if the relativeUri begins with a slash, then it will replace any relative part of the baseUri

And so, because SearchDescriptor creates /{index}/_search pattern - it will replace my /elasticsearch/ in Uri. Possible solutions are change of Uri construction or editing of PathAndQuery variable.
Steps to reproduce:

Create Uri with additional path
var node = new Uri("http://site.com/elasticsearch");
Create Settings
var settings = new ConnectionSettings(node);
Create ElasticClient
var client = new ElasticClient(settings);
Make client.Search request
You will get 404 error(well, because of site.com example url, but anyway you will be able to see OriginalExaption details and there will be http://site.com/{index}/_search?... url)

Provide DebugInformation (if relevant):
DebugInformation of ISearchResponse
Invalid NEST response built from a unsuccessful low level call on POST: /myindex/_search?typed_keys=true&ignore_unavailable=true
Audit trail of this API call:

[1] BadResponse: Node: http://site.com/elasticsearch/ Took: 00:00:14.2378572

OriginalException: Elasticsearch.Net.ElasticsearchClientException: Request failed to execute. Call: Status code 404 from: POST /myindex/_search?typed_keys=true&ignore_unavailable=true. ServerError: Type:  Reason: "Not Found"
Request:
{"query":{"bool":{"filter":[{"range":{"create_time":{"gte":"2019-04-22T00:00:00","lt":"2019-04-22T00:01:00"}}}],"must":[{"query_string":{"analyze_wildcard":true,"query":"*"}}]}},"size":5000}
Response:
{"statusCode":404,"error":"Not Found","message":"Not Found"}
OriginalException.DebugInformation (exactly here we can see full generated url)
FailureReason: BadResponse while attempting POST on http://site.com/myindex/_search?typed_keys=true&ignore_unavailable=true
Audit trail of this API call:

[1] BadResponse: Node: http://site.com/elasticsearch/ Took: 00:00:14.2378572

OriginalException: Elasticsearch.Net.ElasticsearchClientException: Request failed to execute. Call: Status code 404 from: POST /myindex/_search?typed_keys=true&ignore_unavailable=true. ServerError: Type:  Reason: "Not Found"
Request:
{"query":{"bool":{"filter":[{"range":{"create_time":{"gte":"2019-04-22T00:00:00","lt":"2019-04-22T00:01:00"}}}],"must":[{"query_string":{"analyze_wildcard":true,"query":"*"}}]}},"size":5000}
Response:
{"statusCode":404,"error":"Not Found","message":"Not Found"}
Exception:
Elasticsearch.Net.ElasticsearchClientException: Request failed to execute. Call: Status code 404 from: POST /myindex/_search?typed_keys=true&ignore_unavailable=true. ServerError: Type:  Reason: "Not Found"
Edit: Sorry for bad title and formating. This is literally my first report in github.

Thank you very much for reporting this! We changed url building in 7.0 alpha but your usecase is definitely one we have to support and always have done in the past.
I'm surprised we did not have a unit test to cover this will look into how this snuck through.

I've merged in #3700 to address in the next alpha release.


null pointer dereference after flutter upgrade

Hi team,
I've got an app that I've been working on for quite many months now, and while there were times early on when I would get occasional errors and issues, recently the app itself has been running fine while I've been doing my testing and adding new features.  The main screen of my app is primarily comprised of an AppBar, and a Tab view - one tab has a GoogleMap widget, the other tab has a scrolling List View.  There's some other screens like Settings, Search - which essentially just set different properties that control what is displayed on the map and in the list.
Just this week I had noticed that flutter was telling me there was an upgrade available (I have taken other flutter upgrades in the past), and I also checked recent versions of packages that I was using and noticed that a few were behind, so went ahead and did the flutter upgrade and brought my packages up to date.
One of the packages I'd been using was "firebase_admob" (https://pub.dev/packages/firebase_admob), and noted on this one that it was stating it would be deprecated and to transfer over to "google_mobile_ads", which I also went ahead and did.  The transition to that package was pretty easy.
However, when I started testing the app again, it would crash with the following exception:
D/EGL_emulation( 7501): eglMakeCurrent: 0xec4e08c0: ver 3 0 (tinfo 0xf7689880)
F/libc    ( 7501): Fatal signal 11 (SIGSEGV), code 1 (SEGV_MAPERR), fault addr 0x0 in tid 7532 (RenderThread), pid 7501 (.shows_near_me1)

Build fingerprint: 'google/sdk_gphone_x86/generic_x86:10/QSR1.190920.001/5891938:user/release-keys'
Revision: '0'
ABI: 'x86'
Timestamp: 2021-03-12 22:33:18+1100
pid: 7501, tid: 7532, name: RenderThread  >>> com.example.shows_near_me1 <<<
uid: 10147
signal 11 (SIGSEGV), code 1 (SEGV_MAPERR), fault addr 0x0
Cause: null pointer dereference
eax c5515000  ebx d87be864  ecx d86285c0  edx 0000001d
edi ca67b988  esi ec46c000
ebp ca67b94c  esp ca67b8ec  eip 00000000
backtrace:
#00 pc 00000000
#01 pc 0286c771  /system/product/app/TrichromeLibrary/TrichromeLibrary.apk!libmonochrome.so (offset 0x66c000) (BuildId: ffe50d4377c82928759c1f40f1b35ba9f411454a)
Lost connection to device.
Exited (sigterm)
With some debugging and troubleshooting, I got to the point of determining that the crash is occurring when my banner ad is shown (ie. when the "onAdLoaded" event occurs, for the ad listener, and this statement (as per example) runs:
bannerCompleter.complete(ad as BannerAd);
Then a whole bunch of further troubleshooting (including going back to "firebase_admob", but then still experiencing the same crash), I determine the following scenarios:

"load" the banner ad, but don't run the "bannerCompleter.complete..." statement (ie. that's the only statement that I comment out), and the app runs fine, and I can do all normal interactions with the app (including my Google Map widget)
don't display the Google Map widget, and then the banner ad loads and displays successfully, and I can interact with all other elements of the app (obviously, not the map, though)
display the Google Map widget and let the banner ad load and try to display, the crash will then occur at the point when the banner ad tries to display

So, essentially, without changing any other part of my app, I did the flutter upgrade, put some packages to their latest version, and migrated from "firebase_admob" to "google_mobile_ads", and I now get a crash exception when a banner ad tries to display - BUT ONLY when I also have a GoogleMap widget displaying.
Where to next to try and get a resolution to this?

Hi @craigjp99
From what I can see, the issue is related to a 3rd party plugin rather than to Flutter itself. Please open the issue in the dedicated repository.
Closing, as this isn't an issue with Flutter itself.
If you disagree, please write in the comments,
providing your flutter doctor -v, your flutter run -v,  your pubspec.yaml
a minimal reproducible code sample that does not use 3rd party plugins,
and I will reopen it.
Thank you

It is a little frustrating to see this problem wandering around in different repositories without a specific direction, I have this problem of displaying Google Maps + Admob. Before in the Firebase library and now as Google Mobile Ads, I believe that they are one of those problems that will never be solved, since, it is not possible to know the source of the problem and to be able to report in an assertive way. At first glance it seems like an integration problem, where AdMob (Android Native version) does not integrate well with the flutter engine, generating this problem without a father, I am very sad about this problem, since, I am an independent developer, so, my only alternative is to recreate my app entirely on native android to be able to get paid for the ads, but at the same time, it is such a huge and demotivating effort that I can't get started. I'm sorry, it was just an outburst regarding this problem
This error appears in different ways in different places:
https://github.com/googleads/googleads-mobile-flutter/issues/32
https://github.com/flutter/flutter/issues/78578
https://github.com/FirebaseExtended/flutterfire/issues/3529
https://github.com/flutter/flutter/issues/65594


Video not auto playing on mobile

On all mobile browsers video is not auto playing.

Needed to add playsInline for it to autoplay on mobile.


Warn about discarting const qualifier

Fixes #5639

I'd personally assign the rhs/lhs types to local variables at the beginning of the check function, but that's a style detail. I'm fine with this change, too.

I'd personally assign the rhs/lhs types to local variables at the beginning of the check function, but that's a style detail. I'm fine with this change, too.

I have no problem even with fixing the style. I applied the suggestion and merged master. If the CI is green and there won't be any comment, I will merge the PR.


Proof of Concept: custom fieldname support

This is a proof of concept to support validating CSVs that don't include a header row. The implementation allows a user to define a sequence of field names and passes these through to the underlying DictReader instances. The default behavior remains unchanged. I did a quick manual test with a slight modification of the example Vlad object and sample CSV contents from the readme.
If this is a useful construct, I'll be happy to fill in the documentation and tests for this option.
Resolves #88.

Example usage:
from vladiate import Vlad
from vladiate.validators import UniqueValidator, SetValidator
from vladiate.inputs import LocalFile

class CustomFieldnamesValidator(Vlad):
    source = LocalFile('vampires.csv')
    fieldnames = ['Column A', 'Column B']
    validators = {
        'Column A': [
            UniqueValidator()
        ],
        'Column B': [
            SetValidator(['Vampire', 'Not A Vampire'])
        ]
    }

Column A,Column B
Vlad the Impaler,Not A Vampire
Dracula,Vampire
Count Chocula,Vampire

» vladiate

Validating CustomFieldnamesValidator(source=LocalFile('vampires.csv'))
Passed! :)

Makes sense to me!


Update github checkout action version

Facing the issues mentioned at
https://github.com/actions/checkout/issues/23
Which is solved in the new version

This has been already addressed.


Detect dev vs non-dev environment for Google.Cloud.Diagnostic.* Libraries

Detecting dev vs non dev environments will allow for turning on and off features based on the environment.  This requires more investigation and thought about use cases.
cc @jskeet

Injecting in IHostingEnvrionment and using IsDevelopment() could work for this. Whats the scenarios?
I did this  in Orchard Core, but instead registered the middleware and services based on Environment

We just want to make sure we don't report unneeded diagnostic info when we are in development mode.

Closing for now having added this to the backlog


How to define Adapter or Convert for custom struct?

Adapters
To implement custom adapters, you might want to inspect the code here
https://github.com/laicasaane/tower_of_encosy/tree/main/Assets/Module.Core/Mvvm
You can start with this simple one though
https://github.com/laicasaane/tower_of_encosy/blob/main/Assets/Module.Core/Mvvm/TimeToStringAdapters.cs
Converters
For custom converters, you don't have to do anything. For example, with this code:
[ObservableProperty] public AddressableKey<Sprite> Key { get => Get_Key(); set => Set_Key(value); }

a converter for AddressableKey<Sprite> will be source-generated under the hood.
Size of Custom Structs
I support structs whose size is up to 128 bytes. By default, only 8-bytes structs are supported without doing anything. For larger ones, you have to add one of these symbols into your project.
UNION_SIZE_16_BYTES
UNION_SIZE_24_BYTES
UNION_SIZE_32_BYTES
UNION_SIZE_40_BYTES
UNION_SIZE_48_BYTES
UNION_SIZE_56_BYTES
UNION_SIZE_64_BYTES
UNION_SIZE_72_BYTES
UNION_SIZE_80_BYTES
UNION_SIZE_88_BYTES
UNION_SIZE_96_BYTES
UNION_SIZE_104_BYTES
UNION_SIZE_112_BYTES
UNION_SIZE_120_BYTES
UNION_SIZE_128_BYTES

In case your struct is larger than 128 bytes you would need to modify the source code to support it.
https://github.com/Zitga-Tech/ZBase.Foundation.Mvvm/blob/main/Packages/ZBase.Foundation.Mvvm/Mvvm/Union/UnionData.cs

I noticed that some types automatically set adapters. How is this achieved? Can my custom adapter do this?

Only C# built-in types are supported. Anything other than those you must implement a custom adapter.

I noticed that some types automatically set adapters.

Wait a minute, you mean the inspector functionality that automatically chooses converter for you?

I noticed that some types automatically set adapters.

Wait a minute, you mean the inspector functionality that automatically chooses converter for you?

Yes

Oh. It depends on whether the tool can find a converter for type A => type B direction. However you generally don't need a converter for type A => type A (identity) direction.
As you can see in the image, I have loading circle that rotates over time. I bind its Transform with an EulerAngles property that returns a Vector3. The binder for Local Euler Angles also receives a Vector3 parameter, so I don't need a custom converter for this binding.

For any direction that is Vector3 => other type you have to write the converter yourself, because the source generator just can't possibly know the logic behind that conversion.
You can inspect the code here to understand how to write a custom converter
https://github.com/Zitga-Tech/ZBase.Foundation.Mvvm/blob/main/Packages/ZBase.Foundation.Mvvm/Mvvm/Union/UnionConverters.t4.cs

Oops. I remembered it wrong!
You don't have to write any custom converter at all. But you're required to write a custom adapter for the direction Vector3 => other type.
I'm so sorry about this mistake.

This terrible mistake is the consequence of not having a proper documentation. However I can't write any document for this package right now. You might see this package in another form later on. But I do have some plan for that by the way. Stay tuned!

This terrible mistake is the consequence of not having a proper documentation. However I can't write any document for this package right now. You might see this package in another form later on. But I do have some plan for that by the way. Stay tuned!

I am very much looking forward to it. What are the significant improvements expected to be made in the new Mvvm library?

Oh. I don't intend for any improvement at first though. There will be a great change in the package structure. You should expect a monolithic/all-in-one package where I develop everything together. The internal code will see some changes too as I plan to update/replace some foundational code. You can think of this as a stage setup. Only after everything is in place, I will work on any meaningful improvement.


Some fixes for the release process and 0.6.0

I did some gitgrepping for old versions and found some cases not covered by make update-version so I just added them. In the long run we will want to have something better than this.

Updated.


[WILL-NOT-MERGE] Rework network layer by Netty

What changes in this PR?
Generally, this PR is aim to drop blocking socket and migrate network layer to Netty to achieve better performance and possibility to provide a Async Client API.
Currently implementation should be considered a prototype:

[x] Rewrite network layer by Netty
[x] Pass build
[x] Pass Unit Tests
[x] Pass Integration Tests
[x] Async Client API
[ ] ClickHouseSQLException should only use in JDBC interface
[ ] Avoid ByteBuf leak[1]
[ ] Support codec compressed Block
[ ] Elegantly handle half-response packet[2]
[ ] Better performance

[1] Netty ByteBuf use reference count to track ByteBuf lifecycle for GC-free when use off-heap allocator, and it provide a ResourceLeakDetector to detect leaked ByteBuf on runtime, which "leaked" means the ByteBuf has no referenced and can be GC, but it's reference counter > 0. It's no affect on heap ByteBuf.
[2] We have a offline discussion with @sundy-li @zhang2014 @zhicwu, and the solution is move decode process to a dedicated thread pool using blocking IO API rather than decode in Netty eventloop.

why close the PR?

why close the PR?

@zhou-hao Thanks for watching this PR. At the begining, I believe that Netty is the fastest network framework in Java world, so started this refactor, but it's not a fluky thing, I went back and forth and final decided to abandon it.
TL;DR The most important reason is I didn't get performance improvement but downgrade with Netty.
I will update the detail if I have time later.

感谢回复，看上去你是个中国人？那就中文交流？
我认为，netty并不能提升RPS，但是当单个操作耗时比较久时，是否更有优势？

@zhou-hao There may some international friends watching this issue, we can have a discussion offline in email or wechat if you are interested in it.
There is an important thing in network program (specific TCP based protocol here) is how to identify a packet(or frame)?
Typically, the protocol define a DELIMITER, or put the frame length at the frame header, but ClickHouse native protocol has none of them.
When I use netty to receive the packet, I didn't find a fast approach to detect is there a complete packet in buffer, so I choose the a simple way, try decode packet every time on receive the bytes, and cache the bytes if decode failed.
After second thought, I found a way to handle this issue, to build a huge state machine to track the decode state of packet, but it will cost lots of time, I didn't try it.

Thinks!!!

Another thing is that ByteBuf use reference counter to manage the lifecycle. After switching all byte[] to ByteBuf, user must ensure that close all Connection, Statement, ResultSet they created, otherwise, netty will complain memory leak (there is no leak if we use heap allocator, but off-heap does).
Even handle ByteBuf lifecycle properly, through the cpu profiler, I saw the performance downgrade, and a lot of time cost on ByteBuf allocate and recycle.
I'm not expert in memory management, maybe I don't use ByteBuf in properly, and I'm open to discuss/learn how to manage memory efficiently.

我认为，netty并不能提升RPS，但是当单个操作耗时比较久时，是否更有优势？

Yes, NIO style does. But I don't think ClickHouse is designed for such scenario.

How about using reactor netty to implement ClickHouse Client?

How about using reactor netty to implement ClickHouse Client?

Not familiar with this project, but as my understanding, it didn't solve the problems I list above.
ClickHouse support gRPC from v<IP_ADDRESS>-stable 2021-01-18, link: https://github.com/ClickHouse/ClickHouse/blob/master/CHANGELOG.md#clickhouse-release-v211215-stable-2021-01-18
I think it's a right direction of high performance. I'm more interesting in integration on ClickHouse with Spark now. I can't promise a roadmap/plan for this project, because I'm not salaried for it.


Get data in Row.cs from third table

It is possible to lookup data in row from Left Join table like this:
[DisplayName("Registrant ID"), Column("RegistrantID"), NotNull, ForeignKey(typeof(UsersRow)), LeftJoin("jRegistrant")]
but I need to make left join on left joined column, ie add third table, which entity is referenced in second (leftJoined) table.
any idea if that's possible?

Hi @ga5tan ,
just try it. In your case it would be on the UserId foreign field within the xyzRow where your [DisplayName("Registrant ID")...] declaration is.
Just do again the foreignKey(typeof()), LeftJoin("j");
I had done this long - long ago - and it had worked as I remember.
With kind regards,
John

thx @JohnRanger , it worked.
for some reason I had to specify source column in Origin tag as well, but it works!
this is second LeftJoin on already joined field:
[DisplayName("Code"), Origin("jRegistrant"), Expression("jRegistrant.[LoginId]"), ForeignKey(typeof(Respondents.Entities.UserLoginRow)), LeftJoin("jRespondent"), MinSelectLevel(SelectLevel.List)]
this is from third table:
[DisplayName("Code"), Origin("jRespondent","Username"), Expression("jRespondent.[Username]"), MinSelectLevel(SelectLevel.List)]

I have the same problem. Could you post the complete Row file?


xaochuk B3

Node
Name: xaochuk2
Id: 7ee8310cd5a35fd5
All start was very quickly with same duration. Both node starts time duration is about 2-3 seconds. Hard to measure approximate time, because it's to small.

rejected:B3
reason:missing logs for 3 different startup types

rejected:B3
reason:missing logs for 3 different startup types


Opening a new terminal does not auto activate (env)

I can't seem to get my Python venv to auto activate. I'm not sure why, and was hoping someone could help me out.
I've tried different shells (Bash, Powershell, CMD) and none seem to activate the venv.
If I manually activate the env then it works.
This is my settings.json if this helps:
{
    "python.pythonPath": "env\\Scripts\\python.exe"
}

Not sure what else would be required to troubleshoot this.

Seems to work if I remove other folders from my work space, but why?

Duplicate of #3325


Adding implicit scopes broken for clients requiring consent

I've been trying to implicitly add the LibgreGraph.UUID scope (to always get the lg.uuid claim added to tokens and userinfo) to our client configuration. But it breaks as soon as the client requires consent. (E.g. because trusted is not set to true or when the client sends prompts=consent with the authentication request.
E.g. this (trusted) client config works and successfully includes the lg.uuid claim in the response:
- id: works
  name: ownCloud Web app
  trusted: true
  implicit_scopes:
  - LibgreGraph.UUID
  secret: ""
  redirect_uris:
  - http://<IP_ADDRESS>
  - http://localhoyst
  origins: []
  application_type: native

while this one does not (only difference is the missing  trusted: true:
- id: broken
  name: ownCloud Web app
  implicit_scopes:
  - LibgreGraph.UUID
  secret: ""
  redirect_uris:
  - http://<IP_ADDRESS>
  - http://localhost
  origins: []
  application_type: native

How to reproduce
Start lico using the clients registry from https://gist.github.com/rhafer/8f94d55d39332589ba0cb80fd6c1b2ce#file-identifier-registration-yaml
export LDAP_UUID_ATTRIBUTE=entryUUID
export LDAP_....
bin/licod serve --listen <IP_ADDRESS>:9200 \
    --iss=https://ocis.owncloud.test \
    --signing-private-key private-key.pem \
    --encryption-secret encryption.key ldap  \
    --identifier-client-path identifier/build/ \
    --log-level debug \
    --identifier-registration-conf ~/.ocis/idp/tmp/identifier-registration.yaml

I used a slightly modified version of the go-oidc userinfo sample: https://gist.github.com/rhafer/8f94d55d39332589ba0cb80fd6c1b2ce#file-userinfo-go
which basically just return the userinfo of the authenticated user.
Just copied it into example/userinfo/app.go of a local clone of https://github.com/coreos/go-oidc and run it with:
CLIENT_ID=works go run example/userinfo/app.go
and point your brower to http://<IP_ADDRESS>:5556 (ideally a private window) with CLIENT_ID=works the browser should display the userinfo including the lg.uuid claim (provided the used LDAP server returns and entryUUID attribute for the user.
To reproduce the error use CLIENT_ID=broken go run example/userinfo/app.go and open a  new private session in the browser.
This time you should be prompted for consent and now the lg.uuid claim is missing from the userinfo. Shouldn't the implict_scopes always be include regardless of the given consent? Or alternatively shouldn't the consent page request consent for that scope if it's part of the implict scopes?
BTW, the problem is also reproducible for trusted clients that require consent. See line 82 on the example app.

I tried to reproduce this now and it works just fine for me.
The implicit scope ends up in the access token scp claim.
"scp": "email LibgreGraph.UUID openid profile",

Then also the response to the userinfo endpoint does include the lg.uuid claims as expected:
"lg.uuid": "L289TXkgRXhjaGFuZ2UgNCBBbGwvL2NuPTE0MDAwMDAwMDYwMDAwMDAtdXNlcjE",

The identifier registration looks like this:
clients:
  - id: playground.js
    name: OIDC Playground
    application_type: web
    implicit_scopes:
      - LibgreGraph.UUID
    redirect_uris:
      - https://mose4:8509/

So things seem to be fine. It has been a while since this issue was opened, so closing this here for now. If this should be still an issue please reopen for further investigation.


Radial Gradiant enhancement

Updated version of @jbergen
Better control for radial gradients #11

Closing as repo not maintained anymore


Implemented filtering on the ISM eplain API

Issue
#651
Description of changes:
Added POST method to ISM explain API to enable filtering on the policies. This does the same thing as GET, except adds in filtering. The request body should look as follows:
"filter": {
"policy_id": "my_id",
"state": "my_state_name",
"action_type": "my_action_type"
}
The filter only returns policies for which they match every filter given. If a filter is left out (ex. "policy_id"), any of that filter will be allowed.
CheckList:

[x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@Joshua152 thanks, this is good progress.
I put down some more details on the requirements of this feature https://github.com/opensearch-project/index-management/issues/651#issuecomment-1769110698, we can do this iteratively.

@Joshua152 maybe pull the change from #1022 back to this PR, and let's wrap on this. 😃

@Joshua152 this has been merged in, but the backport failed, can you manually apply this change to 2.x branch and create a PR please?


Hovering a map icon should apply the permit-hovered css class to the corresponding table row

@carrieEgg are there "hover" effects from Bootstrap that we could use on this table?  If so we should phase out our custom CSS in favor of Bootstrap's built-in capabilities.

@wrightgd Yep I'm in a process of sorting those things out :)


error when  'make'

I use ubuntu mate,but got the following error when doing make :
libraries/chain/CMakeFiles/eos_chain.dir/build.make:62: recipe for target 'libraries/chain/CMakeFiles/eos_chain.dir/chain_controller.cpp.o' failed
make[2]: *** [libraries/chain/CMakeFiles/eos_chain.dir/chain_controller.cpp.o] Error 1
CMakeFiles/Makefile2:1082: recipe for target 'libraries/chain/CMakeFiles/eos_chain.dir/all' failed
make[1]: *** [libraries/chain/CMakeFiles/eos_chain.dir/all] Error 2
Makefile:129: recipe for target 'all' failed
make: *** [all] Error 2

How can I fix it ?

The error is not present in the quoted output. Please show us the full output.

I think I might be hitting the same issue, here's the output:
In file included from /home/me/git/eos/libraries/chain/include/eos/chain/types.hpp:41:0,
                 from /home/me/git/eos/libraries/chain/include/eos/chain/global_property_object.hpp:28,
                 from /home/me/git/eos/libraries/chain/include/eos/chain/chain_controller.hpp:25,
                 from /home/me/git/eos/libraries/chain/chain_controller.cpp:25:
/home/me/git/eos/libraries/fc/include/fc/static_variant.hpp:388:34: error: partial specialization 'class fc::get_typename<T ...>' is not more specialized than [-fpermissive]
   template<typename... T> struct get_typename<T...>  { static const char* name()   { return typeid(static_variant<T...>).name();   } };
                                  ^~~~~~~~~~~~~~~~~~
In file included from /home/me/git/eos/libraries/fc/include/fc/reflect/reflect.hpp:19:0,
                 from /home/me/git/eos/libraries/fc/include/fc/time.hpp:138,
                 from /home/me/git/eos/libraries/fc/include/fc/log/logger.hpp:3,
                 from /home/me/git/eos/libraries/fc/include/fc/exception/exception.hpp:6,
                 from /home/me/git/eos/libraries/fc/include/fc/uint128.hpp:6,
                 from /home/me/git/eos/libraries/chain/include/eos/chain/global_property_object.hpp:25,
                 from /home/me/git/eos/libraries/chain/include/eos/chain/chain_controller.hpp:25,
                 from /home/me/git/eos/libraries/chain/chain_controller.cpp:25:
/home/me/git/eos/libraries/fc/include/fc/reflect/typename.hpp:18:30: note: primary template 'template<class T> class fc::get_typename'
   template<typename T> class get_typename{};
                              ^~~~~~~~~~~~

@Apercu Those errors can usually be fixed by adding -Wno-invalid-partial-specialization to your CXXFLAGS. Are you on Mac? If so, try uncommenting line 116 in CMakeLists.txt and commenting line 117.

Nope didn't help, and I'm not on Mach but on Arch, with GCC 7.1.1  & make 4.2.1. Any other fix you could think of?


HDDS-8459. Ratis under replication handling in a rack aware environment doesn't work

What changes were proposed in this pull request?
The scenario is described in the jira: https://issues.apache.org/jira/browse/HDDS-8459.
The fix here is using the correct RatisContainerReplicaCount object in RatisUnderReplicationHandler. And also to consider UNHEALTHY replicas when checking for over replication in RatisReplicationCheckHandler to fix the subsequent over replication.
How was this patch tested?
Added and modified unit tests. Also tested manually using docker compose.
Draft only because CI is still running in my fork: https://github.com/siddhantsangwan/ozone/actions/runs/4798311173/jobs/8536433251

@sodonnel Thanks for reviewing. Merging this now that CI is green here.


Unfocus TextField if it is disabled

If a TextField is disabled while it had focus you used to be able to continue typing in that text field. This PR fixes that by removing focus if a text field is disabled.
Fixes https://github.com/flutter/flutter/issues/18086.

 but please keep an eye out for regressions, this is subtle and fragile code.


$CK_HOST_CPU_NUMBER_OF_PROCESSORS undefined

In this make statement in installing TVM from source the environment variable $CK_HOST_CPU_NUMBER_OF_PROCESSORS is undefined, causing the make -j flag to think there are infinite jobs available.
Is this a problem with the meta description of this package installation (since I notice the variable is only available with need_cpu_info here)? Or perhaps a default value (such as 1, 2, or 4) can always be done in the ck end, regardless of the package meta, to prevent such issues?

Thank you for your feedback @hanwenzhu! I've noticed the same problem when compiling TVM. I will try to add some default value such as 2 for the TVM package. Will tell you when it's done.

Hi Thomas,
I believe I've fixed that. Can you please update your AI repo and try again:
ck pull all
ck install package --tags=tvm,src

Thanks!

I added new functionality to packages to set the number of processes for make (if supported by a given packge):
$ ck install package --j=4
Will be available in the release v2.5.6.

The issue is now fixed. Thank you!


Add schema for 'How Government Works' page

This is currently hardcoded in Whitehall but will need a content item to enable rendering in another application.
Note that all the details fields are optional as they will not be present when "reshuffle mode" is switched on.
Trello card
⚠ This repo is Continuously Deployed: make sure you follow the guidance ⚠
This application is owned by the publishing platform team. Let us know in #govuk-publishing-platform if you have any questions.
Follow these steps if you are doing a Rails upgrade.

The only other things that appear on the page that I could see being added to this schema (famous last words TM) is all the currently hard-coded organisations that appear on the page as examples (e.g. "Some departments, like the Ministry of Defence, cover the whole UK"). If they get reslugged / name changed, they're not going to get updated on this page.
We could add them in as links e.g. "uk_wide_org_example": MOD_CONTENT_ID etc, but this still requires an element of hard-coding this end (similar to this). So yeah, we're not going to get the benefits of dependency resolution here, but maybe we tolerate that.

I did think about adding these, but then realised there are 10 organisations named in this page, so we'd need to include them all.  In many changes (e.g. DIT being replaced by DBT), the existing organisation isn't renamed but replaced with a new one, so this would need manual changes anyway.  Additionally, at the moment, the names and slugs are hardcoded, and we update them manually when changes are made (e.g. changing Her Majesty's Inspectorate of Prisons to His Majesty's Inspectorate of Prisons).  So I don't think these are worth adding.  Maybe Find & View might want to review the content on this page once we've migrated it, to see what is actually the user need of these examples?

I did think about adding these...

Yep, agree with all your points here. Happy to leave as is.


New remrem generate

Implemented CLI and Service as seperate subprojects for Remrem-Generate.
Seperate binaries for CLI and Service.
Removed the dependencies for CLI and Service independently to respective projects.

Coverage increased (+15.1%) to 75.41% when pulling acb1e2048b1bbc82027b51b21e8f4cceb4deda03 on SantoshNC68:newRemremGenerate into ef0a4a9a3db0047a3e55cd8eeecd4c79e2445eda on Ericsson:master.

Coverage increased (+15.1%) to 75.41% when pulling 4aa4313f2b79bac3406937843c4279c19e2d995d on SantoshNC68:newRemremGenerate into<PHONE_NUMBER>b28c7b739a92e71b9fc248c26fb278 on Ericsson:master.

Coverage increased (+15.1%) to 75.41% when pulling 3d6f370dc19b2c1c2c8a8b2fd52d387938e7dd99 on SantoshNC68:newRemremGenerate into<PHONE_NUMBER>b28c7b739a92e71b9fc248c26fb278 on Ericsson:master.


Don't use bets to filter answers

Totalbets wasn't updating like our answer listener was, so I removed it. This allows new answers to show up in the top part as well as the comments section of FR questions.

I also switched the useLayoutEffect to useEffect bc the command line is always yelling about how it doesn't do anything, and useEffect seems to work just fine.

Do we need that probability filter? I can figure out a diff way to do it if so.


Wiki sample code error - prompt validation

Error: TypeError: context.sendActivity is not a function

Steps to reproduce:-

Use prompt validation for ageprompt.
input any age not in range of 1-100.

The fix:-
Use context.
await agePrompt.prompt(context, I'm sorry I didn't understand. Please enter an age between 1 and 100.);

Thanks... Fixed


helm template --output-dir multiple runs will produce incorrect manifests

Running  helm template csi-secrets-store secrets-store-csi-driver/secrets-store-csi-driver --output-dir blah
Will produce correct manifests, but if you run it a second time any files that contain helm hooks will get appended to and will have duplicate contents.  I would expect the files to be identical if you ran the command multiple times.
These will be the files that keep getting appended
        modified:   blah/secrets-store-csi-driver/templates/crds-upgrade-hook.yaml
        modified:   blah/secrets-store-csi-driver/templates/keep-crds-upgrade-hook.yaml

Output of helm version:
3.14.1
Output of kubectl version:
1.29.2
Cloud Provider/Platform (AKS, GKE, Minikube etc.):
N/A

I have identified the cause of this bug. Some code in helm template was copied from helm install, but the usage of the fileWritten map differs between the two, leading to incorrect behavior.
In helm install, the relevant code is:
https://github.com/helm/helm/blob/a958f3a9b65df7c809c88c180cc89886fee7768c/pkg/action/action.go#L185-L199
Here, the fileWritten map is updated after the file was written.
In contrast, the code in helm template is as follows:
https://github.com/helm/helm/blob/a958f3a9b65df7c809c88c180cc89886fee7768c/cmd/helm/template.go#L110-L133
The fileWritten was set by if the file exist instead of if the file was written.
So, if this file was already exist before the command execution, helm will append content into the file instead of recreate one.
I think set fileWritten when file was written instead of it exists can fix this bug.
@gjenkins8 Would you assign this issue to me? I'd like to rise a PR.

Encountered this bug aswell, and found this same cause after noticing it only happens with resources with helm hooks. Very annoying in certain use cases.


Exercise 8 - it is very easy to over-write the sample.dat file

Why don't you make it read only ?

@lmoresi claims that this is resolved.

https://github.com/ANU-RSES-Education/EMSC-4033/commit/9e0adeb1b5e76f1eeaf5a4af5979c9f85181432d


Graph does not update with state

I want to have a few graphs in separate cupertino segment.
When I switch between tabs the chart data is refreshed but the chart remains with the initial data (does not refresh - kind of like a singleton chart)
Each tab has a different date range (monthly, weekly etc...)

Could you add a minimum sample code to reproduce the issue here?

I updated the package, Could you try using the dependency in this way:
bezier_chart:
    git:
      url: git://github.com/aeyrium/bezier-chart.git
      ref: master

And run :  flutter packages upgrade
Let me know if it works.

Unfortunately the new version didn't fix the issue.
The build method:
  @override   Widget build(BuildContext context) {     return Column(       children: <Widget>[         Container(           width: double.infinity,           padding: EdgeInsets.symmetric(horizontal: 24),           child: CupertinoSegmentedControl(               unselectedColor: Provider.of<EventerTheme>(context).colorScheme.statisticsSelectedTabText,               borderColor: Provider.of<EventerTheme>(context).colorScheme.statisticsSelectedTabBg,               selectedColor: Provider.of<EventerTheme>(context).colorScheme.statisticsSelectedTabBg,               children: <int, Widget>{ //                DAY: Text(AppLocalizations.of(context).hourly, style: TextStyle(fontWeight: FontWeight.bold)),                 THIRTY_DAYS: Text(AppLocalizations.of(context).pastMonth, style: TextStyle(fontWeight: FontWeight.bold)),                 SIX_MONTHS: Text(AppLocalizations.of(context).pastSixMonths, style: TextStyle(fontWeight: FontWeight.bold)),               },               groupValue: _selectedSalesSegment,               onValueChanged: (int value) {                 setState(() {                   _selectedSalesSegment = value;                 });               }),         ), //        if(_selectedSalesSegment == DAY) //          chartByTimeSpan(widget.bloc.pastDaySalesTimeline.stream),         if (_selectedSalesSegment == THIRTY_DAYS)           SalesChart(widget.bloc.thirtyDaysSalesTimeline.stream),         if (_selectedSalesSegment == SIX_MONTHS)           SalesChart(widget.bloc.sixMonthsSalesTimeline.stream),       ],     );   }

add a minimum sample code to reproduce the issue please.  Did you add the dependency in your pubspec.yaml like I showed you ?

Updated with sample code, and yes, I used the git ref in the pubsec.yaml

sorry, I pushed some changes few minutes ago.  Could you try again?
Don't forget to run :  flutter packages upgrade , let me know if it works for you.

It works after the last update!
Thanks a lot.
BTW if you look at the code sample i posted above you can see that I wrapped the BezierChart with a Directionality class.
The reason is since my app works with several languages, a few of which are RTL.
When using the chart with an RTL language the bubbles don't work as they should.
Forcing the chart to LTR fixes this issue.
Just thought you should know.
Thanks again!

I'm having a similar issue.  Updating data. The Y Axis changes, but the Line and Bubble indicator data is not updated until you tap the chart.  Using selectedValue property.  We are also pulling the latest code from master.

There are two properties according the chart scale, selectedDate and selectedValue, which scale are you using?

SelectedValue
On Sun, Aug 11, 2019 at 10:14 AM -0400, "Diego Vel?squez L?pez" <notifications<EMAIL_ADDRESS>wrote:
There are two properties according the chart scale, selectedDate and selectedValue, which scale are you using?

You are receiving this because you commented.
Reply to this email directly, view it on GitHubhttps://github.com/aeyrium/bezier-chart/issues/10?email_source=notifications&email_token=AATBM2RZN3T66ZW7TUEIM4DQEANDJA5CNFSM4H3TYH2KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD4BBWHI#issuecomment-520231709, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AATBM2VVF3UTEVHKNC6LHDDQEANDJANCNFSM4H3TYH2A.

Which scale are you using?
On Sun, Aug 11, 2019, 9:39 AM Tim Ricciardi<EMAIL_ADDRESS>wrote:

SelectedValue
On Sun, Aug 11, 2019 at 10:14 AM -0400, "Diego Vel?squez L?pez" <
notifications<EMAIL_ADDRESS>wrote:
There are two properties according the chart scale, selectedDate and
selectedValue, which scale are you using?

You are receiving this because you commented.
Reply to this email directly, view it on GitHub<
https://github.com/aeyrium/bezier-chart/issues/10?email_source=notifications&email_token=AATBM2RZN3T66ZW7TUEIM4DQEANDJA5CNFSM4H3TYH2KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD4BBWHI#issuecomment-520231709>,
or mute the thread<
https://github.com/notifications/unsubscribe-auth/AATBM2VVF3UTEVHKNC6LHDDQEANDJANCNFSM4H3TYH2A

.

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/aeyrium/bezier-chart/issues/10?email_source=notifications&email_token=ABFL3UC24FIOROAVGYCCMEDQEAQCXA5CNFSM4H3TYH2KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD4BCD3I#issuecomment-520233453,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABFL3UBZZU7EWBDYOSBHNJ3QEAQCXANCNFSM4H3TYH2A
.

Custom


[feat] Streaming Update

Notable Changes:

Escape validator names in on-fail attributes

Add required_model_auth to Manifest class

Enable passing serializeable metadata to api

API streaming support

Refactor guard save & enable guard.use syntax for api

Fix Notebook Runs (#793)

Loosen otel requirements

Use semver for package versions in checks

Notebooks are failing for reasons unrelated to this PR, but we can't be assured of these changes until we fix them.  Working on that now.


DefinePlugin?

I'm trying to inject some global variables into my bundle using Webpacks DefinePlugin. Unfortunately, I can't get it to work. Does broccoli-webpack-cached suppresses this kind of manipulation somehow? Or am I using it the wrong way?
appJs = webpack(appJs, {
    entry: "./app/app.js",
    output: {
        filename: "app.js",
    },
    plugins: [
        new webpackLib.DefinePlugin({
            foo: "bar"
        })
    ],
    devtool: "cheap-module-inline-source-map"
});

In browser:
Uncaught ReferenceError: foo is not defined(…)

I hadn't used DefinePlugin before, and at first I was having the same problem as you. And then after reading around more, I saw how everyone was wrapping string literals with JSON.stringify(...). So I gave that a shot and things worked.
In other words, this worked for me:
    new webpack.DefinePlugin({
      SOME_CUSTOM_VAR: JSON.stringify("Yup, some custom var was inserted here!")
    }),

But this didn't:
    new webpack.DefinePlugin({
      SOME_CUSTOM_VAR: "Yup, some custom var was inserted here!"
    }),

Closing, but let me know if you still have any issues.


Make .Net Release Pipeline Public

Move archetype-net-release.yml into the public repo, Except for signing stage.
Add dependsOn: PublishPackage for PublishDocs and UpdatePackageVersion deployments.
Tested with Azure.Template.1.0.2-preview.7 and Azure.Template.1.0.2-preview.8
Included version changes to Azure.Template

Depends on https://github.com/Azure/azure-sdk-tools/pull/416 and https://dev.azure.com/azure-sdk/internal/_git/azure-sdk-build-tools/pullrequest/149?_a=overview

What is left for this PR?

What is left for this PR?

Am am syncing eng/common manually which should get this PR green.

/azp run net - core - ci


Upgrade to account for changes to @site.pages and @site.documents

What kind of change does this PR introduce? (check at least one)

[x] Bugfix
[ ] Feature
[ ] Code style update
[ ] Refactor
[ ] Build-related changes
[ ] Other, please describe:

Does this PR introduce a breaking change? (check one)

[x] Yes
[ ] No

There isn't any effort to support 0.x versions of bridgetown
The PR fulfills these requirements:

[x] All tests are passing
[x] New/updated tests are included

thanks @de-fluistervloot - I am in the process of contacting Ruby gems to see if I can become the owner of this gem.
I want to test this myself but my only concern is that this may not be backwards compatible. If it isn’t, I’ll have to think about releasing a major version vs. adding version checks and appraisal tests. Feedback welcome.

thanks @de-fluistervloot - I am in the process of contacting Ruby gems to see if I can become the owner of this gem.
I want to test this myself but my only concern is that this may not be backwards compatible. If it isn’t, I’ll have to think about releasing a major version vs. adding version checks and appraisal tests. Feedback welcome.

Shouldn't be too hard to support both I guess. But I'm not familiar enough with setting up testing against both 0.x and 1.x versions.

Giving this a test today.


Nested complex type issue

I've attached a sample repo. It has 3 automated integration tests. All those tests are calling the same odata action which accepts a nested complex type. Tests which are using http client are able to call the api but odata client fails to send a request due following exception:
Microsoft.OData.ODataException: The parameter 'ComplexType2' is of Edm type kind 'Complex'. You cannot call WriteValue on a parameter that is not of Edm type kinds 'Primitive', 'Enum' or 'Complex'.

You can also run the asp.net app, it opens swagger page for you. You can also take a look at $metadata by opening http://localhost:5000/odata/MyApp/$metadata
I'm using the latest version.
SimpleODataClientNestedComplexTypeIssue.zip
Thanks for your fantastic library (-:

Any news on this?

This may have been fixed as part of pull request #634.

This may have been fixed as part of pull request #634.

No, it's not. Check my PR #715

Released in 5.11.1.


[Android] AppRegistry.runApplication was called twice when wake up the app

Issue Description
It usually happens at the first time launch the new installed app.
Steps to Reproduce / Code Snippets

remove the app installed before
install the app
set the app to background
wait a moment
wake up the app

Additional Information

React Native version: 0.35.0
Platform(s) (iOS, Android, or both?): Android 4.2.1
Operating System (macOS, Linux, or Windows?): macOS

How is this causing a problem for your application? Usually you would not be relying on runApplication directly in any way. Ie, what do you see in the "steps to reproduce" that you do not expect to see.

When integrate with react-native-router-flux, it consoles "Key xxx is already defined!"

Hi there! This issue is being closed because it has been inactive for a while.
But don't worry, it will live on with Canny! Check out its new home: https://react-native.canny.io/feature-requests/p/android-appregistryrunapplication-was-called-twice-when-wake-up-the-app


Calling a method on variable properties crashes with infinite recursion

Godot version
4.0.dev latest
System information
Arch Linux
Issue description
When doing some quick refactoring for a project in 3.2 to 4.0, I tried to cut corners and refactored the old setget behavior like this:
var my_var:
    get:
        return get_my_var()

func get_my_var():
    return my_var % 3

func _ready():
    my_var = 3
    print(my_var)

However when running this script it crashes with a segfault. Looking at gdb there seems to be infinite recursion:
#0  0x000055e9d0245f28 in Variant::Variant (this=0x7fffa38660b0, p_object=0x55e9d3edf330) at core/variant/variant.cpp:2511
#1  0x000055e9cce5f6e8 in GDScriptFunction::call (this=0x55e9d3ed25a0, p_instance=0x55e9d3ef5910, p_args=0x7fffa386b8e0, p_argcount=0, r_err=..., p_state=0x0) at modules/gdscript/gdscript_vm.cpp:519
#2  0x000055e9ccdcc74d in GDScriptInstance::call (this=0x55e9d3ef5910, p_method=..., p_args=0x7fffa386b8e0, p_argcount=0, r_error=...) at modules/gdscript/gdscript.cpp:1501
#3  0x000055e9d054c53a in Object::call (this=0x55e9d3edf330, p_method=..., p_args=0x7fffa386b8e0, p_argcount=0, r_error=...) at core/object/object.cpp:811
#4  0x000055e9d0260475 in Variant::call (this=0x7fffa386b880, p_method=..., p_args=0x7fffa386b8e0, p_argcount=0, r_ret=..., r_error=...) at core/variant/variant_call.cpp:1017
#5  0x000055e9cce693e7 in GDScriptFunction::call (this=0x55e9d3ede610, p_instance=0x55e9d3ef5910, p_args=0x7fffa38710a8, p_argcount=0, r_err=..., p_state=0x0) at modules/gdscript/gdscript_vm.cpp:1487
...
#1481 0x000055e9cce693e7 in GDScriptFunction::call (this=0x55e9d3ed25a0, p_instance=0x55e9d3ef5910, p_args=0x7fffa4058c60, p_argcount=0, r_err=..., p_state=0x0) at modules/gdscript/gdscript_vm.cpp:1487
#1482 0x000055e9ccdcc74d in GDScriptInstance::call (this=0x55e9d3ef5910, p_method=..., p_args=0x7fffa4058c60, p_argcount=0, r_error=...) at modules/gdscript/gdscript.cpp:1501
#1483 0x000055e9d054c53a in Object::call (this=0x55e9d3edf330, p_method=..., p_args=0x7fffa4058c60, p_argcount=0, r_error=...) at core/object/object.cpp:811
#1484 0x000055e9d0260475 in Variant::call (this=0x7fffa4058c00, p_method=..., p_args=0x7fffa4058c60, p_argcount=0, r_ret=..., r_error=...) at core/variant/variant_call.cpp:1017
#1485 0x000055e9cce693e7 in GDScriptFunction::call (this=0x55e9d3ede610, p_instance=0x55e9d3ef5910, p_args=0x7fffa405e428, p_argcount=0, r_err=..., p_state=0x0) at modules/gdscript/gdscript_vm.cpp:1487
#1486 0x000055e9ccdcc74d in GDScriptInstance::call (this=0x55e9d3ef5910, p_method=..., p_args=0x7fffa405e428, p_argcount=0, r_error=...) at modules/gdscript/gdscript.cpp:1501
#1487 0x000055e9d054c53a in Object::call (this=0x55e9d3edf330, p_method=..., p_args=0x7fffa405e428, p_argcount=0, r_error=...) at core/object/object.cpp:811
#1488 0x000055e9d0260475 in Variant::call (this=0x7fffa405e3b0, p_method=..., p_args=0x7fffa405e428, p_argcount=0, r_ret=..., r_error=...) at core/variant/variant_call.cpp:1017
#1489 0x000055e9cce693e7 in GDScriptFunction::call (this=0x55e9d3ed17e0, p_instance=0x55e9d3ef5910, p_args=0x0, p_argcount=0, r_err=..., p_state=0x0) at modules/gdscript/gdscript_vm.cpp:1487
#1490 0x000055e9ccdcc74d in GDScriptInstance::call (this=0x55e9d3ef5910, p_method=..., p_args=0x0, p_argcount=0, r_error=...) at modules/gdscript/gdscript.cpp:1501
#1491 0x000055e9ce51b9c0 in Node::_gdvirtual__ready_call (this=0x55e9d3edf330) at ./scene/main/node.h:236
#1492 0x000055e9ce4fd01e in Node::_notification (this=0x55e9d3edf330, p_notification=13) at scene/main/node.cpp:145
#1493 0x000055e9ccac9721 in Node::_notificationv (this=0x55e9d3edf330, p_notification=13, p_reversed=false) at ./scene/main/node.h:48
#1494 0x000055e9ccac95ec in CanvasItem::_notificationv (this=0x55e9d3edf330, p_notification=13, p_reversed=false) at ./scene/main/canvas_item.h:47
#1495 0x000055e9ce486c7c in Node2D::_notificationv (this=0x55e9d3edf330, p_notification=13, p_reversed=false) at ./scene/2d/node_2d.h:37
#1496 0x000055e9d05497c0 in Object::notification (this=0x55e9d3edf330, p_notification=13, p_reversed=false) at core/object/object.cpp:841
#1497 0x000055e9ce4fe929 in Node::_propagate_ready (this=0x55e9d3edf330) at scene/main/node.cpp:190
#1498 0x000055e9ce4fe8c5 in Node::_propagate_ready (this=0x55e9d3d35b70) at scene/main/node.cpp:182
#1499 0x000055e9ce504867 in Node::_set_tree (this=0x55e9d3d35b70, p_tree=0x55e9d3aaa0e0) at scene/main/node.cpp:2450
#1500 0x000055e9ce540575 in SceneTree::initialize (this=0x55e9d3aaa0e0) at scene/main/scene_tree.cpp:402
#1501 0x000055e9cc88c32f in OS_LinuxBSD::run (this=0x7fffa4063f10) at platform/linuxbsd/os_linuxbsd.cpp:330
#1502 0x000055e9cc8875f6 in main (argc=9, argv=0x7fffa40643f8) at platform/linuxbsd/godot_linuxbsd.cpp:58

I don't know if this usage of properties is valid per se, but it certainly shouldn't segfault :slightly_smiling_face:
Steps to reproduce

Have a script with a variable with a get property that calls another method:

var my_var:
    get:
        return get_my_var()

func get_my_var():
    return my_var % 3

func _ready():
    my_var = 3
    print(my_var)

Run the game
It crashes with a segfault

Minimal reproduction project
MRP.zip

This code is indeed invalid as it creates infinite recursion, but maybe the GDScript analyser could figure it out and throw a helpful error.

Tested with a simpler script:
func inf_recursion():
	return 1 + inf_recursion()

func _ready():
	print(inf_recursion())

On master this always crashes, but on 3.3.3 this stops with a "Stack overflow" error, but only when launching from the editor; when launching directly (godot --path ...) it crashes the same way as above. Judging from the code, the stack overflow protection is enabled only for debug builds:
https://github.com/godotengine/godot/blob/44b1143f7bab84e3ce5c14406b908daf971e3745/modules/gdscript/gdscript_vm.cpp#L540-L545
https://github.com/godotengine/godot/blob/44b1143f7bab84e3ce5c14406b908daf971e3745/modules/gdscript/gdscript.h#L365-L370
Although this makes sense IMO, shouldn't the engine avoid crashing at all costs on normal builds? Either way, I'll bisect the regression on master in the meantime.

set: has the same issue.

As of 6b0b1a4c042175190381737e3000027ef912e6cb this is still an issue. It causes the editor on Windows 10 to crash if a script such as this is attached to a node in a Scene that is open in the editor:
@export
var my_property : int: # the type doesn't really matter
	set(value):
		set_my_property(value)
[...]
func set_my_property(value: int) -> void:
	my_property = value

The proper way to use method setter is
@export var my_property: int: set = set_my_property

The only thing that could be improved here is leading the user to the correct behavior.

In 3.5 setting/getting a variable from the same "class" as the variable doesn't call the setter/getter function; to intentionally do so simply required a self.variable syntax. This always seemed pretty intuitive to me, is there some reason for this to no longer be the case?
That is to say:
# outside the variable's parent object:

object .variable = value       # triggers setter, no infinite recursion

# inside the variable's parent object:

variable = value               # does not trigger setter, no infinite recursion
self.variable = value          # triggers setter, infinite recursion

It seems to me like OP's original example shouldn't have led to an infinite recursion in the first place, therefore making this a bug or a missing feature.  Just figured I'd bring that functionality up since I didn't see anyone mention it in the thread so far.

@cullumi This is intentional. The old different behavior of property and self.property is inconsistent and inconvenient.

The way it is now I'm forced to mimic C#'s set/get properties with an extra variable to store values on the side...

There was a suggestion/comment to add an annotation and my proposal. But they didn't get support.

inconsistent and inconvenient

Interesting... I've found the resulting method of doing these a lot more cumbersome and unintuitive, to be honest. Though I suppose writing "self" less times may be worth it for certain use cases.
I suppose I'll just resign myself to writing my setters using this odd approach, for now at least:
var dimensions :
   set(_dims): dimensions = dims(_dims)

(I'm leaving this here as an alternative for anyone else who stumbles across this post who doesn't want to write 4 lines of code for each property they need a setter for)

There is no crash in 4.0.3.


Add consumable-cooldowns plugin

Displays cooldown indicators for the various consumable item categories. To help players better understand when and when they can't consume items. See the README for more details.
For rendering the cooldown fill overlay I used the same draw/cache logic as the inventory tags plugin.

Please move your images outside of your src/main/resources/ directory, since that is packaged and distributed in the plugin jar. You can store it in the root of your project, or some other directory outside of src/.
LGTM otherwise

Please move your images outside of your src/main/resources/ directory, since that is packaged and distributed in the plugin jar. You can store it in the root of your project, or some other directory outside of src/. LGTM otherwise

Changed. 1MB+ of useless images in the package is definitely not ideal 😄. I've also included a minor fix for the action delay logic as it was incorrect before.


Location pathname is not always absolute

According to MDN,

Location.pathname Is a DOMString containing an initial '/' followed by the path of the URL. (source)

According to the HTML Standard, as part of the Location.pathname getter requirements,

Return "/", followed by the strings in url's path (including empty strings), separated from each other by "/". (source)

The function createLocation() (located here) does no such check for an absolute pathname. Instead, it allows users to create a location.pathname without the initial "/" character.
For me, this led to some unexpected behavior when I was calling browserHistory.push() with the relative pathnames from the location object to capture react-router URL parameters:
browserHistory.push(location.pathname + '/' + additionalPath);

Is this an intentional difference from the specification?

Which version of history are you using? location.pathname should always be absolute.

@mjackson This is relevant to the latest version of history hosted on npm, 4.3.0. Here is the simplest way I can create a location without an absolute pathname:
const history = require('history');
const location = history.createLocation({ pathname: 'foo/bar' });
console.log(location.pathname); // Prints "foo/bar"

createLocation is not designed to automatically make all paths absolute. It's not even recommended to use it at all in userland. That method mainly exists for library code, like react-history and react-router.
Every location you get from history.listen should be absolute, same as window.location.pathname. That's the only guarantee we provide.


instagram.setup(); Problem AllowAllHostnameVerifier--

java.lang.NoSuchFieldError: No static field INSTANCE of type Lorg/apache/http/conn/ssl/AllowAllHostnameVerifier; in class Lorg/apache/http/conn/ssl/AllowAllHostnameVerifier; or its superclasses (declaration of 'org.apache.http.conn.ssl.AllowAllHostnameVerifier' appears in /system/framework/framework.jar!classes3.dex)
at org.apache.http.conn.ssl.SSLConnectionSocketFactory.(SSLConnectionSocketFactory.java:146)
at org.apache.http.impl.client.HttpClientBuilder.build(HttpClientBuilder.java:966)
at org.brunocvcunha.instagram4j.Instagram4j.setup(Instagram4j.java:176)

@cemocanon  You need following dependencies in your environment, so install it
dependencies {
compile group: 'org.apache.httpcomponents' , name: 'httpclient-android' , version: '<IP_ADDRESS>'
}

i have this error, how can i resolve?
Duplicate class org.apache.http.Consts found in modules jetified-httpclient-android-4.3.5.jar (org.apache.httpcomponents:httpclient-android:4.3.5) and jetified-httpcore-4.4.10.jar (org.apache.httpcomponents:httpcore:4.4.10)

I also met, how to solve it?

Addressed in rewrite or no longer relevant.


no 1.0.3 version available

Swift 3 support is not live.  Pod keeps downloading older 1.0.2 version

I am seeing the same issue :(

@kurry421 I've done the same thing but I get an error that module compiled with swift 3.0.1 can not be imported into swift 3.1

You can use the Podfile by adding this line manually
pod 'PasscodeLock', :git => 'https://github.com/velikanov/SwiftPasscodeLock.git', :branch => 'master'
This repo is not the original one and only @yankodimitrov has access to push a new version to the Pod registry. Personally, I use this repo or my own fork.
I am not sure if this can be fixed somehow, whatever it happens, we have to ask for permission from @yankodimitrov, as this is his package and also his awesome contribution to the community.


Add images links

[ ]  add name placeholder to portfolio
[ ]  Add placeholders for images and links
[ ]  Add location placeholder for tags
[ ]  Add comment placeholder for feedback

[ ]  add name placeholder to portfolio
[ ]  Add placeholders for images and links
[ ]  Add location placeholder for tags
[ ]  Add comment placeholder for feedback

Good

Good


docs: rename the assigned variable

This PR fixes autocomplete = autocomplete( error.

autocompleteSearch is fine.


request: command line string

Hi
I'm not sure if it's possible somewhere (can't find it) but allowing the user to pass a command line string to mame (used for all games) would be very usefull.
For example in my case I would pass BGFX mode.

Feature already exists. F1 / Command Line switches.

Oh sorry!


Blurry Background Not Available in Pod

Any chance you'll be adding this to the pod soon?

Hi @thephatp,
Thanks for getting in touch. Absolutely! I'll be adding another feature from the list of upcoming features soon, which means it should be out within the next couple of days. I will let you know when it is.
Cheers,
Nima

Thanks, and I know this isn't the right place, but I need to say it somewhere--this customized alert view is incredible both from a design and from a customization perspective. It's exactly what I've been looking for, and I greatly appreciate all of the work you have done!!

@thephatp No worries at all! And I'm very glad to hear that, Thanks for saying it! It's exactly because of developers like you that I put a lot of effort and work into it to make sure it's useful and beautiful 👍 Be sure to stay posted on new libraries as well, and feel free to email me any suggestion you have!

@thephatp You can now use CocoaPod version 1.1.2 along with other new features including blur :) Enjoy! README.md has been updated with instructions on how to use them.


Resolve circular dependency between ONNXOps  and KrnlOps

From the cmake for ONNXOps:
## TODO: remove dependency of ONNXOps on KrnlOps
# OMONNXOps depends on symbols in OMKrnlOps, we do not specify
# linking dependency explicitly here because OMKrnlOps also depends
# on OMONNXOps, which is circular.

There are some major benefits to resolving the circular dependency:

The majority of the cmake files in the project use add_dependencies to manage dependencies between the various libs instead of target_link_libraries. target_link_libraries automatically adds the requested link libraries as a dependency in addition to carrying over any compilation flags, include directories or other libs that have been marked as dependencies. This greatly simplifies dependency management.
We would be able to set -Wl,-z,defs and ensure that all symbols exist when building shared libraries eliminating the possibility for any issues with the shared libraries.

It would be great to remove the dependency of ONNXOps on KrnlOps!

It is not that easy because we share code for shape inference and onnx-to-krnl lowering

It is not that easy because we share code for shape inference and onnx-to-krnl lowering

Does it make sense to move the shared code to a new library?

@caoimhinuibrian, currently half way through a solution. Requires a bit of engineering, not too much as IndexExpr are creating code that currently explicitly use Krnl, but I can work around this. Will push a PR today, probably. Looking forward to your input

@AlexandreEichenberger oh ... I was looking at it ... will stop now. I was pursuing a dependency injection idea to solve

#653 is implementing the changes. Please feel free to comment on it as you see fit


Emails go out of order sometimes

I have a suggestion:
It appears that emails can go out of order. If I were to enqueue multiple emails for a user a few seconds apart, they can be sent out in a random order. This breaks the user experience.
When a user signs-up, we enqueue a thank-you email. Once a specific activity is completed after that, another email is enqueued. This could be a few seconds to minutes apart. It would be nice if the order of those emails is preserved based on the email address and when it was enqueued.
Mail-Time 0.1.7
Node 8.9.1
Npm 5.6.0

Hello @theoutlander ,

Please post your definition of new MailTime({ /*...*/ });.
What version of nodemailer you're on?
.sendMail() method accepts sendAt option, you can order emails using this option;
Is this behavior easily reproducible? Want to make sure it's a bug, and not a network/mail protocol flaw.

I have noticed during our pre-production testing that in my first test the emails were out of order. I haven't tried to repro it, but we are testing our app for the next release so I will be able to answer it after a few more runs.
The sendAt option won't work most likely as these are supposed to be instantaneous emails. I don't know how much of a delay would need to be introduced and if the library would ensure the order of delivery.
Here's rest of the info you requested:
    "nodemailer": "^4.4.1",
    "nodemailer-mailgun-transport": "^1.3.6"

let mailServer = new MailTime({
  debug: true,
  db: db, // MongoDB
  type: 'server',
  strategy: 'balancer', // Transports will be used in round robin chain
  transports: transports,
  from: function (transport) { return `****Redacted****` },
  concatEmails: true, // Concatenate emails to the same addressee
  concatDelimiter: '<h1>{{{subject}}}</h1>', // Start each concatenated email with it's own subject
  template: MailTime.Template // Use default template
})

@theoutlander you have two options to tune:

Disable concatenation with concatEmails: false
Lower concatThrottling (which is 1 minute by default);

In a case you have describe user should receive only one email including both messages (sign up, and thank-you).

@dr-dimitru maybe should be add sort: {sendAt: 1} in __send? Because by default sort by _id (createdAt), so maybe the lastest add document's sendAt is the earliest.
___send(ready) {
    this.collection.findOneAndUpdate({
      $or: [{
        isSent: false,
        sendAt: {
          $lte: new Date()
        },
        tries: {
          $lt: this.maxTries
        }
      }, {
        isSent: true,
        sendAt: {
          $lt: new Date(Date.now() - (this.interval * 4))
        },
        tries: {
          $lt: this.maxTries
        }
      }]
    }, {
      $set: {
        isSent: true,
        sendAt: new Date(Date.now() + this.interval)
      },
      $inc: {
        tries: 1
      }
    }, {
      returnOriginal: false,
      sort: {sendAt: 1},
      projection: {
        _id: 1,
        tries: 1,
        template: 1,
        transport: 1,
        mailOptions: 1,
        concatSubject: 1
      }
    }