Subscription notifications UI improvements

"Disk usage %"

"Network Rx/Tx GB"

Ram ?
CPU ?
NuvlaEdge online
I propose a short info text: "Get notified when NuvleEdge changes status changes to offline or online."

I suppose that input fields will appear or be enabled when option is selected (e.g. Custom in days).
Custom [Input field][label days]
Perhaps Specify network interface is better than Use other network?.  Same thing for disk.
Other than that LGTM. Liked the sketch to show how it will look like.

I suppose that input fields will appear or be enabled when option is selected (e.g. Custom in days).
Custom [Input field][label days]
Yes, that's the plan!

Perhaps Specify network interface is better than Use other network?. Same thing for disk.
Thanks, that's way better: I didn't know what to call it, that's why I put the question mark at the end (not very obvious...).

Thanks for feedback!
I edited at the same time you were answering so I ask here again.
The input field for disk and network interface: Should this be a free text field or a dropdown with all possible options (if that is even reasonably feasible).

free text field for interfaces since network interfaces can be an id like we saw with konstan

Re the messages.
"Disk usage %"
Observes the primary partition.

Also, ATM collection of the per disk/partition metrics and their naming is not fully working on NE (just checked with @ignacio-penas). So, showing the row with "Specify disk name" doesn't make sense at the moment.
"Network Rx/Tx GB"
Default will observe the traffic on the default gateway on monthly basis (resets on the 1st of the month).

@konstan or @0xbase12 : Can one of you provide me with the French translations for

Observes the primary partition.
Default will observe the traffic on the default gateway on monthly basis (resets on the 1st of the month).

@konstan or @0xbase12 : Can one of you provide me with the French translations for
* Observes the primary partition.

* Default will observe the traffic on the default gateway on monthly basis (resets on the 1st of the month).

Surveille la partition principale.
Surveille le trafic sur la passerelle par défaut sur une base mensuelle (se réinitialise chaque 1er du mois).

Observes is it better to replace it with monitor?
Too much default in the second sentence. We remove the first one?


docs: format.selector flag

While troubleshooting the issue https://github.com/netsampler/goflow2/issues/245 I realized that there is no documentation on how to use the format.selector flag.
Please correct me if I'm wrong.
I've added a basic example on how to use it.

Alright.
If I may ask - how can this be done in v2?

v2 is more config file focused.
The following controls the file output in JSON/text
https://github.com/netsampler/goflow2/blob/1a5d58e3cf2f0fcbfd8030f8ea4a116e31bca712/cmd/goflow2/mapping.yaml#L1-L5
Unfortunately the docs are currently a bit sparse on this subject.


Upload large files (>195 GB)

Hi all,
According to the documentation:
https://msdn.microsoft.com/en-us/library/azure/ee691964.aspx
The maximum size of a blob is 195GB, my question is:
What should be the approach if we need to upload files bigger than 195GB
Thanks,

Split your blob until multiple pieces. Upload those to different blobs and when you download, reassemble. If you need some way of tracking on the blob where the next piece is, metadata would be one option.
Page blobs. The maximum size for a page blob is 1 TB.

Ok, thanks. So this should be managed before execute our scripts and call the framework.
Offtopic question: Do you know if this limitation was documented time ago? I started working with azure storage and blobs at the beginning of the year and I didn't see before this limitation on the official azure storage documentation.

Yes, this is has been in those docs for a very long time and the limitations have not changed in a very long time. Other docs such as this one also contain that data and one can actually verify the history of modification on public GitHub. Sorry if there was any confusion!


Acces sfaira ontologies

I would like access Sfaira ontologies and synonym matching functionalities in my Python code for genes and for cell types.
I want to write functions that would take as input cell type name OR gene name + organism and return whether this is a valid name and possibly suggest what a correct name would be. Currently the priority is only to check if gene name is a valid gene names for organism and if cell type is a valid Cell Ontology cell type.
David linked me https://github.com/theislab/sfaira/blob/3d89f688d9a91704fce49aa7648e8359eac21f0c/sfaira/versions/metadata/base.py#L737 . Does this work by only fuzzy string matching (e.g. could match "Beta"  to "beta cells" - different case/substring) or does it use all synonyms that can be extracted from Cell Ontology database download file (e.g. could match"beta" to "pancreatic B cell" - completely different words).
Also, please let me know if this can be done with current version of Sfaira or it would take a while to implement.

Good idea! Let's explicitly define an interface for this, how about this?
def map_celltype_to_ontology(
            source: str,
            match_only: bool = False,
            include_synonyms: bool = True,
            anatomical_constraint: Union[str, None] = None,
            n_suggest: int = 10,
    ) -> List[str]:
        """
        Map free text node name to ontology node names via fuzzy string matching.

        :param source: Free text node label which is to be matched to ontology nodes.
        :param match_only: Whether to include strict matches only in output.
        :param include_synonyms: Whether to include synonyms of nodes in string search.
        :param anatomical_constraint: Whether to require suggestions to be within a target anatomy defined within UBERON.
        :param n_suggest: Number of cell types to suggest.
        :return: List of high priority matches.
        """

This interface could be exposed essentially immidiately as it is very close to what we are already using internally.

Does this work by only fuzzy string matching (e.g. could match "Beta" to "beta cells" - different case/substring) or does it use all synonyms that can be extracted from Cell Ontology database download file (e.g. could match"beta" to "pancreatic B cell" - completely different words).

It does a lot of things internally, for the exact recipe you would have to look at the code (we are also interested in optimising this recipe if you find it not working well), in brief:

synonyms (such as "beta cell" and "pancreatic type B cell") are considered if include_synonyms==True, these synonyms are usually annotated in the cell ontology. So finding "pancreatic type B cell" from "beta" in a pancreas sample is not an issue.
we use anatomic information also, this is annotated in the doc string

This sounds great. So if I wanted to check if cell name was valid and if not return synonyms I would call something like
map_celltype_to_ontology(
            source=cell_name,
            match_only = False,
            include_synonyms= True,
            anatomical_constraint= None,
            n_suggest: int = 10)

Which would return a list of possible names from ontology. Then I would check if the source I used as input is in the returned list. -> In this case it is a valid ontology name. If source is not in returned list it is not valid and I would output list with suggestions.

Ok, we can add an additional parameter that lead to the string itself being returned if it is in the ontology. This is not always desired though so I would be careful with that: "stellate cell" is a valid term but in the context of a pancreas sample you might be able to narrow this down to a much more specific term, e.g. "pancreatic stellate cell", so if anatomic information is available I essentially never rely on perfect matches in my workflows.

Thanks for letting me know. Then I will also just use what your function returns (the list) followed by manual curation.

@Hrovatin this is available in dev now under sfaira.data.utils, usage is documented in the docstring.

There are a few problems with the function, see below:
map_celltype_to_ontology('beta','mouse')
/Users/karin.hrovatin/Documents/GitHub/sfaira/sfaira/versions/metadata/base.py:204: UserWarning: DAG was broken
  warnings.warn("DAG was broken")
[['activated CD8-positive, alpha-beta T cell, human', 'CD8-positive, CD28-negative, alpha-beta regulatory T cell', 'effector memory CD8-positive, alpha-beta T cell, terminally differentiated', 'basophil cell of pars distalis of adenohypophysis']]

map_celltype_to_ontology('beta cell','mouse')
/Users/karin.hrovatin/Documents/GitHub/sfaira/sfaira/versions/metadata/base.py:204: UserWarning: DAG was broken
  warnings.warn("DAG was broken")
[['cell', 'type B pancreatic cell', 'basophil cell of pars distalis of adenohypophysis', 'jejunal goblet cell']]

1.) We would prefer not to have cell types separated by organism. I also do not see online on Cell Ontology cell types being associated with only specific organisms. So where does the need for organism come from and what does it do?
2.) The fuzzy string mapping could be improved. If I input "beta" I do not get back official name 'type B pancreatic cell' - this is also problem online on cell ontology where with this search the 'type B pancreatic cell' is not among top hits. However, if I input "beta cell"  I get 'type B pancreatic cell', which is also high in online search. It seems odd that I get so different results based on whether I add "cell" or not.

Also, anatomical constraint does not work:
map_celltype_to_ontology('T','mouse',anatomical_constraint='blood')
/Users/karin.hrovatin/Documents/GitHub/sfaira/sfaira/versions/metadata/base.py:204: UserWarning: DAG was broken
  warnings.warn("DAG was broken")
Traceback (most recent call last):
  File "<input>", line 1, in <module>
  File "/Users/karin.hrovatin/Documents/GitHub/sfaira/sfaira/data/utils.py", line 38, in map_celltype_to_ontology
    matches = cu.prepare_celltype_map_fuzzy(
  File "/Users/karin.hrovatin/Documents/GitHub/sfaira/sfaira/versions/metadata/base.py", line 902, in prepare_celltype_map_fuzzy
    matchesi = matchesi.update({"anatomic_string_match": [
AttributeError: 'NoneType' object has no attribute 'update'

It also takes a while to run. So if checking multiple cell types would there be an easy way to remove redundant steps and speed it up - e.g. is there an object initialization step that takes a while or something similar?

Also, if i input perfect match I never get a list of suggestions desipte choices_for_perfect_match.
map_celltype_to_ontology(source='T cell',
...                                            organism='mouse',
...                                            include_synonyms=True,
...                                            anatomical_constraint=anatomical_constraint,
...                                            n_suggest=5,
...                                            choices_for_perfect_match=True,
...                                            keep_strategy=False
...                                            )
/Users/karin.hrovatin/Documents/GitHub/sfaira/sfaira/versions/metadata/base.py:204: UserWarning: DAG was broken
  warnings.warn("DAG was broken")
['T cell']
map_celltype_to_ontology(source='T cell',
...                                            organism='mouse',
...                                            include_synonyms=True,
...                                            anatomical_constraint=anatomical_constraint,
...                                            n_suggest=5,
...                                            choices_for_perfect_match=False,
...                                            keep_strategy=False
...                                            )
/Users/karin.hrovatin/Documents/GitHub/sfaira/sfaira/versions/metadata/base.py:204: UserWarning: DAG was broken
  warnings.warn("DAG was broken")
'T cell'

Thanks for all the feedback!

1.) We would prefer not to have cell types separated by organism. I also do not see online on Cell Ontology cell types being associated with only specific organisms. So where does the need for organism come from and what does it do? Also, I inputed organism mouse and got a resulting celltype that contains 'human'.

CO is not organism specific, it seems that in this case, they added a node which they believe to only occur in humans, which is why they might have labeled it this way. Here we would need to look into the T cell CO tree, happy to do that. Inputting mouse would not change that because the node in CO does not have an organism label. We could however counterselect nodes which have these human suffixes, this might be unsafe before we know exactly why they gave it this suffix though.

2.) The fuzzy string mapping could be improved. If I input "beta" I do not get back official name 'type B pancreatic cell' - this is also problem online on cell ontology where with this search the 'type B pancreatic cell' is not among top hits. However, if I input "beta cell" I get 'type B pancreatic cell', which is also high in online search. It seems odd that I get so different results based on whether I add "cell" or not.

"beta cell" is an exact synonym, this is why it s easy to find, the matches that you  are seeing come from different match strategies to cover as many possibilities as possible. I think you ll find the correct cell if you input beta and constraint by pancreas? We could check for a string matching that gives higher scores if the full string is not much longer than the query, this should penalize the hits you are seeing now.

3.) There is a warning.

This is from UBERON, this does not effect your query.

Also, anatomical constraint does not work:

Sorry I fixed this on another branch and did not merge, it is merged into dev now in #104

It also takes a while to run. So if checking multiple cell types would there be an easy way to remove redundant steps and speed it up - e.g. is there an object initialization step that takes a while or something similar?

Yes we could accept lists as input, most of the time is required for loading the ontology which is happening repeatedly if you call once for each cell type.

Also, if i input perfect match I never get a list of suggestions desipte choices_for_perfect_match.

I'm addressing this right now.

Also, if i input perfect match I never get a list of suggestions desipte choices_for_perfect_match.

I addressed this in #110, you can try it again now, it should work better, see also the additional arguments now!

Hi, thanks for correcting the code. However, this still does not work (it works if I use 'beta' or ['beta'] as query):
map_celltype_to_ontology(queries=['beta','alpha'],
                                          organism='mouse',
                                          include_synonyms=True,
                                          anatomical_constraint='pancreas',
                                          n_suggest=5,
                                          choices_for_perfect_match=True,
                                          keep_strategy=False,
                                          always_return_list=True
                                           )
/Users/karin.hrovatin/Documents/GitHub/sfaira/sfaira/versions/metadata/base.py:204: UserWarning: DAG was broken
  warnings.warn("DAG was broken")
Traceback (most recent call last):
  File "<input>", line 1, in <module>
  File "/Users/karin.hrovatin/Documents/GitHub/sfaira/sfaira/data/utils.py", line 66, in map_celltype_to_ontology
    if len(matches_i.values()) == 1 and isinstance(list(matches_i.values())[0], str):
AttributeError: 'bool' object has no attribute 'values'

Thanks for the bug report, this was an issue with list input, it s now fixed on dev also part of the unit testing!

@Hrovatin Is this still an issue?

Yes, it works now.


Feature/as refactor review

Remove IsXXX methods from Type
Replace uses of dynamicCast with as, when can be determined no change in behavior
Use free function's on RefPtr if can be determined no change in behavior
Added canAs method to DeclRefBase, such that if the result isn't needed, just the cast-ability it can be tested

This was used over having a free function 'as' for DeclRefBase

Moved 'as' from DeclRef to DeclRefBase - means only dependent on one template param (the target)
Small typo fixes

Should canAs be is?


Work around bugs in IE and Edge's Range.toString() implementation

Work around the issues with IE and Blink's implementation of Range.toString() described in https://github.com/tilgovi/dom-anchor-text-position/issues/4
The workaround uses a ponyfill for Range.toString() based on a fairly
direct translation of Blink's Range::toString() logic.
Tested with the existing tests for this package, plus those from the Hypothesis client. I also compared the output of the native implementation of Range.toString() and the ponyfill on the HTML single-page spec.
The native implementation of Range.toString() is several times faster (60-120ms on https://html.spec.whatwg.org/ vs. ~400ms for the ponyfill), so if we're happy with the approach here, I can follow it up with logic to use the native version if it doesn't have the bugs that IE/Edge's one has.
Fixes #4

Current coverage is 100% (diff: 100%)

Merging #5 into master will not change coverage

@@           master    #5   diff @@
===================================
  Files           1     2     +1
  Lines          36    70    +34
  Methods         1     7     +6
  Messages        0     0
  Branches        8    18    +10
===================================
+ Hits           36    70    +34
  Misses          0     0
  Partials        0     0

Powered by Codecov. Last update 0cb5a5c...703ce45

Excellent! Thanks, Robert.


No properties are defined for 'Model'

How frequently does the bug occur?
All the time
Description
We have migrated from objc Realm to RealmSwift ~>10.0. The crash happens on firebase distribution(test) builds and is not happening in Xcode or simulator, or real device connected to xcode.
Any ideas what is going on here?
//Somewhere in migration class
migration.enumerateObjects(ofType: RealmChannel.className()) { oldObject, newObject in
            if let id  = oldObject?["_id"] as? String {
                newObject!["id"] = id
            }
        }

import RealmSwift

class RealmChannel: Object {
    @Persisted(primaryKey: true) var id: String = ""
    @Persisted var name: String?
    @Persisted var followers: Int = 0
    @Persisted var countryFollowers: Int = 0
    @Persisted var badge: String?
    @Persisted var lastAccessTime: Int64 = Int64(Date().timeIntervalSince1970 * 1000.0)
    @Persisted var unread = false
    @Persisted var canDeletePost = false
    @Persisted var canBanChannelUser = false
    @Persisted var emoticon: String?
    @Persisted var descriptionKey: String?
    @Persisted var lastPostedTimestamp: Int64 = 0
    @Persisted var channelFeatures: String?

    convenience init(id: String) {
        self.init()
        self.id = id
    }
}

Stacktrace & log output
*** Terminating app due to uncaught exception 'RLMException', reason: 'No properties are defined for 'RealmChannel'. Did you remember to mark them with '@objc' in your model?'
*** First throw call stack:
(0x1a8dc1dc0 0x1bd91e7a8 0x101e82344 0x101f57530 0x101f57be0 0x1a8d26104 0x1a8c9a888 0x101f57a70 0x101f4ab50 0x1028a1228 0x1028a16a4 0x100a89c40 0x100a89ba0 0x1a89ae81c 0x1a89b00b4 0x1accde97c 0x100b5db2c 0x100a3dad8 0x100a3de14 0x100c60264 0x100c6072c 0x1ab7af980 0x1ab7b1414 0x1ab7b7560 0x1aae0b1ac 0x1ab374458 0x1aae0bd44 0x1aae0b804 0x1aae0bb54 0x1aae0b390 0x1aae138d4 0x1ab281e84 0x1ab38d268 0x1aae135cc 0x1aac3b4b4 0x1aac39e34 0x1aac3b0dc 0x1ab7b5700 0x1ab2ab4e4 0x1b83e65d8 0x1b8411d44 0x1b83f56a4 0x1b8411a0c 0x1a89ae81c 0x1a89b230c 0x1b8439fa0 0x1b8439c30 0x1b843a184 0x1a8d3c07c 0x1a8d3bf78 0x1a8d3b27c 0x1a8d3525c 0x1a8d349f4 0x1c040a734 0x1ab7b375c 0x1ab7b8fcc 0x1007ee040 0x1a89f0cf8)

Can you reproduce the bug?
Yes, always
Reproduction Steps
No response
Version
RealmSwift ~>10.0
What SDK flavour are you using?
Local Database only
Are you using encryption?
Yes, using encryption
Platform OS and version(s)
iOS 15
Build environment
Xcode version: 14
Dependency manager and version: 1.11.3

Hi @igormagurean ,
I am also facing same issue , did you mange to resolve this issue. Please let me know it's taking ages to find a workout.
I am using Xcode 14.2 and MacOS ventura.
Thank You

Not yet.

Hi @igormagurean , I am also facing same issue , did you mange to resolve this issue. Please let me know it's taking ages to find a workout. I am using Xcode 14.2 and MacOS ventura. Thank You

Not yet.

Hey.
We identified the issue, the problem was that we used SWIFT_REFLECTION_METADATA_LEVEL = none; Swift compiler flag in our RELEASE configuration and SWIFT_REFLECTION_METADATA_LEVEL = all; in DEBUG. We couldn't reproduce the issue in the DEBUG mode obviously because the reflection worked fine, and it seems that RealmSwift utilize heavily the reflection features of Swift. That's why it crashed on our TestFlight and Firebase builds.
I think we can close this issue ticket. (@igormagurean can you confirm?). But please make sure you reflect this in your installation documentation. It took us a while to figure out what can be wrong with our persistence layer.

None: No reflection metadata is emitted into the binary. Accuracy of detecting memory issues involving Swift types in the Memory Graph Debugger will be degraded and reflection in Swift code may not be able to discover children of types, such as properties and enum cases.


Collection re-render as no content when calling recomputeCellSizesAndPositions() method

I'm working in a responsive layout base on Collection and I need to recalculate cells sizes and position every time the window size changes. I've been told that for achieving this I need to call method recomputeCellSizesAndPositions(), but every time I do that the component Collection seems to loose cells information and fired up the noContentRenderer() method (even when every cell was perfectly rendered before resizing the window).
Have anybody cross this problem or had used recomputeCellSizesAndPositions() successfully? Even if @bvaughn told me that it looks like a component bug, I think that could be that I'm doing something wrong (I'm brand new in React):
I've put the test code in this repo just in case someone can take a look at it:
https://github.com/coluccini/virtualized-test/
The important part happens in this component:
https://github.com/coluccini/virtualized-test/blob/master/src/components/ListPage.js
Thanks a lot in advance!

Seems a legit Collection bug. Can be reproduced in the test harness app with the following modifications:
diff --git a/source/Collection/Collection.example.js b/source/Collection/Collection.example.js
index 53c2844..4efc5f8 100644
--- a/source/Collection/Collection.example.js
+++ b/source/Collection/Collection.example.js
@@ -68,6 +68,10 @@ export default class CollectionExample extends Component {
           </label>
         </ContentBoxParagraph>

+        <button onClick={() => this.Collection.recomputeCellSizesAndPositions()}>
+          recomputeCellSizesAndPositions
+        </button>
+
         <InputRow>
           <LabeledInput
             label='Num cells'
@@ -99,6 +103,7 @@ export default class CollectionExample extends Component {
               className={styles.collection}
               height={height}
               noContentRenderer={this._noContentRenderer}
+              ref={(ref) => this.Collection = ref}
               scrollToCell={scrollToCell}
               width={width}
             />

Whoops. Spoke too soon. Forgot about how I was generating random data on-demand in that component. The correct diff would be...
diff --git a/source/Collection/Collection.example.js b/source/Collection/Collection.example.js
index 53c2844..8826a4d 100644
--- a/source/Collection/Collection.example.js
+++ b/source/Collection/Collection.example.js
@@ -68,6 +68,15 @@ export default class CollectionExample extends Component {
           </label>
         </ContentBoxParagraph>

+        <button
+          onClick={() => {
+            this._columnYMap = []
+            this.Collection.recomputeCellSizesAndPositions()
+          }}
+        >
+          recomputeCellSizesAndPositions
+        </button>
+
         <InputRow>
           <LabeledInput
             label='Num cells'
@@ -99,6 +108,7 @@ export default class CollectionExample extends Component {
               className={styles.collection}
               height={height}
               noContentRenderer={this._noContentRenderer}
+              ref={(ref) => this.Collection = ref}
               scrollToCell={scrollToCell}
               width={width}
             />

...which dose not demonstrate the problem. Hm.

Haha! Looks like your demo project followed this same format, so the fix was actually the same thing. :)
diff --git a/src/components/ListPage.js b/src/components/ListPage.js
index f46ad18..63cb526 100644
--- a/src/components/ListPage.js
+++ b/src/components/ListPage.js
@@ -35,6 +35,7 @@ export default class ListPage extends Component {
   }

   handleResize() {
+    this._columnYMap = []
     this.setState({ width: window.innerWidth, height: window.innerHeight });
     this.refs.Collection.recomputeCellSizesAndPositions();
   }

Just reset your _columnYMap so when the sizes are re-measured, you aren't doubling things up. :)

We've just met and I think I already love you! Thanks you so much! We are going to use this in a production site. So I'll let you know how it goes and about any change we could end up doing. Thanks again for the help and for this amazing module!


Fixes Too Many Datapoints being hovered

Fixes #5231
While investigating core.interaction.js I noticed the culprit of this problem is xRange(mouseX). The reasoning behind this is when there are an excessive amount of data points more than one falls into the range of x causing there to be multiple datapoints hovered because they are so close together. Of course, when there are fewer data points (around 40 or less) this doesn't occur.
To fix this I made a separate function called xRangeSmall that narrows down the range of which a data point will be retrieved. In my testing, it only occurred when there was more than 40 data points on the graph so I added an else if to x: function(chart, e, options) that accounts for this problem when there are more than 40 data points. Feedback is welcome!
Result

JSFiddle

@benmccann I implemented your suggestion (remove the check for 40 datapoints) and transferred the functionality of inXRangeSmall to inXRange the code essentially functions the same from my testing, however, I think the tests performed with gulp test have to be changed to account for the new X range. For example:  https://github.com/chartjs/Chart.js/blob/master/test/specs/core.interaction.tests.js#L579 seems to push an error with the new X range.

Closing in favor of https://github.com/chartjs/Chart.js/pull/5578


MustC Speech Translation

Adding a Dataset

Name: IWSLT19
Description: The Speech Translation Task addresses the translation of English audio into German and Portuguese text.
Hompage: https://sites.google.com/view/iwslt-evaluation-2019/speech-translation
Data: https://sites.google.com/view/iwslt-evaluation-2019/speech-translation - all data under "Allowed Training Data" and "Development and Evalutaion Data for TED/How2"
Motivation: Important speech dataset

If interested in tackling this issue, feel free to tag @patrickvonplaten
Instructions to add a new dataset can be found here.

Hi @patrickvonplaten  I would like to work on this dataset.
Thanks!

That's awesome! Actually, I just noticed that this dataset might become a bit too big!
MuST-C is the main dataset used for IWSLT19 and should probably be added as a standalone dataset. Would you be interested also in adding datasets/MuST-C instead?
Description:
MuST-C is a multilingual speech translation corpus whose size and quality facilitates the training of end-to-end systems for speech translation from English into several languages. For each target language, MuST-C comprises several hundred hours of audio recordings from English TED Talks, which are automatically aligned at the sentence level with their manual transcriptions and translations.
Paper: https://www.aclweb.org/anthology/N19-1202.pdf
Dataset: https://ict.fbk.eu/must-c/ (One needs to fill out a short from to download the data, but it's very easy).
It would be awesome if you're interested in adding this datates. I'm very happy to guide you through the PR! I think the easiest way to start would probably be to read this README on how to add a dataset and open a PR. Think you can copy & paste some code from:

Librispeech_asr: https://github.com/huggingface/datasets/blob/master/datasets/librispeech_asr/librispeech_asr.py
Flores Translation: https://github.com/huggingface/datasets/blob/master/datasets/flores/flores.py

Think all the rest can be handled on the PR :-)

Hi @patrickvonplaten
I have tried downloading this dataset, but the connection seems to reset all the time. I have tried it via the browser, wget, and using gdown . But it gives me an error message. "The server is busy or down, pls try again" (rephrasing the message here)
I have completed adding 4 datasets in the previous data sprint (including the IWSLT dataset #1676 ) ...so just checking if you are able to download it at your end. Otherwise will write to the dataset authors to update the links.

Let me check tomorrow! Thanks for leaving this message!

cc @patil-suraj for notification

@skyprince999, I think I'm getting the same error you're getting :-/
Sorry, you can't view or download this file at this time.

Too many users have viewed or downloaded this file recently. Please try accessing the file again later. If the file you are trying to access is particularly large or is shared with many people, it may take up to 24 hours to be able to view or download the file. If you still can't access a file after 24 hours, contact your domain administrator.

It would be great if you could write the authors to see whether they can fix it.
Also cc @lhoestq - do you think we could mirror the dataset?

Also there are huge those datasets. Think downloading MuST-C v1.2 amounts to ~ 1000GB... because there are 14 possible configs each around 60-70GB. I think users mostly will only use one of the 14 configs so that they would only need, in theory, will have to download ~60GB which is ok. But I think this functionality doesn't exist yet in datasets no? cc @lhoestq

Also cc @lhoestq - do you think we could mirror the dataset?

Yes we can mirror it if the authors are fine with it. You can create a dataset repo on huggingface.co (possibly under the relevant org) and add the mirrored data files.

I think users mostly will only use one of the 14 configs so that they would only need, in theory, will have to download ~60GB which is ok. But I think this functionality doesn't exist yet in datasets no? cc @lhoestq

If there are different download links for each configuration we can make the dataset builder download only the files related to the requested configuration.

I have written to the dataset authors, highlighting this issue. Waiting for their response.

Awesome, actually @lhoestq let's just ask the authors if we should host the dataset no? They could just use our links then as well for their website - what do you think? Is it fine to use our AWS dataset storage also as external links?

Yes definitely. Shall we suggest them to create a dataset repository under their org on huggingface.co ? @julien-c
The dataset is around 1TB

Sounds good!
Order of magnitude is storage costs ~$20 per TB per month (not including bandwidth).
Happy to provide this to the community as I feel this is an important dataset. Let us know what the authors want to do!

Great! @skyprince999, do you think you could ping the authors here or link to this thread? I think it could be a cool idea to host the dataset on our side then

Done. They have replied back, and they want to have a call over a meet/ skype. Is that possible ?
Btw @patrickvonplaten you are looped in that email (pls check you gmail account)

Hello! Any news on this?

@gegallego  there were some concerns regarding dataset usage & attribution by a for-profit company, so couldn't take it forward. Also the download links were unstable.
But I guess if you want to test the fairseq benchmarks, you can connect with them directly for downloading the dataset.

Yes, that dataset is not easy to download... I had to copy it to my Google Drive and use rsync to be able to download it.
However, we could add the dataset with a manual download, right?

yes that is possible. I couldn't unfortunately complete this PR, If you would like to add it, please feel free to do it.


SwaggerUI is not working in Docker, but works locally. Only the SwaggerUI throws a 404 Not Found

Okay, I know this sounds weird ... but: The SwaggerUI is not working inside of Docker. ^^"
Let me explain what I did. When I write down everything like in the example for axum and I start the application with cargo run, I can see the swagger-ui and also see the /docs/openapi.json file.
Now the interesting part, when I compile the code inside docker and provide it inside docker only the swagger-ui endpoint (/docs in this example) is returning a 404 Not Found. But the interesting thing is, all other endpoints are working... Including the /docs/opanapi.json endpoint.
So, only the swagger-ui isn't working inside Docker. ^^"
I thought "maybe it's a compiled problem", so I copied the locally build binary (which worked on the machine and showed the swagger-ui) into the docker container, started it and "boom", no swagger-ui. ^^"
It's so weird that every endpoint is working, also the openapi.json endpoint (which shows the full generated openapi json), but only the swagger-ui HTML-Page is not working. There is really no difference inside the Docker container and my local machine (like I said, I copied the binary to prove my assumption).
I also tried bigger OS containers like ubuntu and smaller ones like alpine, in all containers every endpoint is working, except the swagger-ui. :(
Does someone have an idea what I could test/think of? I'm getting out of ideas. ^^"

I've created a small documentation change to pinpoint it better in the README. Maybe it will help out. :3

Maybe it makes sense that we pinpoint that "issue" out in the Readme, thank you very much! <3

Yeah, actually there is slight hint towards this in utoipa-swagger-ui README.md but it is not obivous to the eye.

Yeah, actually there is slight hint towards this in utoipa-swagger-ui README.md but it is not obivous to the eye.

Ah yeah, now I see what you mean. It wasn't quite obvious to me and two other people. So spending hours investigating that issue could be solved by pinpointing it out. :)

Ah yeah, now I see what you mean. It wasn't quite obvious to me and two other people. So spending hours investigating that issue could be solved by pinpointing it out. :)

True :slightly_smiling_face:

Relates to #268


Parallel processing of tables

It would be good if all the tables would be processed in parallel while taking into account the number of threads in the computer.

Should be an option in order not to saturate the hardware resources if it's a multipurpose server.

Or an option to control the level of parallelism like how many tables are processed in parallel.

https://github.com/bitalizer/db-migrator/commit/4ed57edeecd9c6ef1410e2760da1881eeb90b408


Update M06-Unit 7 Deploy and configure Azure Firewall using the Azure…

… portal.md
Module: 00
Lab/Demo: 00
Fixes # .
Changes proposed in this pull request:

Submitted by viggithub on behalf of MOC Labs Review


This way you would cherry-pick your other changes (for English version of the documentation) into this PR.

@1u0, sorry, I just open the PR on github, I didn't do it from my local respo. I hava translated the Chinese version of this doc and opened a PR to fix the typo of the Chinese version. Could I close this PR and open a new one that just fix these typos of the English version?

In my opinion, it would be better if you just submit both fixes (English version and Chinese version) in one PR. Because the change you are proposing is very small.
I've suggested you before to address this in #9538, by just rebasing and editing your changes.
I gave the last suggestion here, because it should be more easier for you to just cherry pick your changes from #9538 to here.
You don't need to (and shouldn't) open new pull requests for minor adjustments of already opened PR. This looses communication chain and distracts reviewers.
What I ask you in this PR is to run git cherry-pick 07c0404 and then git push origin patch-4 (assuming that origin points to YngwieWang/flink.git). If done correctly, we can close #9538 (as duplicate) and continue with only this PR.

@1u0 , I am greatly appreciated for your help and patient, and I am very sorry that my git skill is poor.
I followed your instruction and got some error. I think this time I'm still not doing the right thing.
I'm very sorry to trouble you and the community.

Hi @YngwieWang, no worries.
I've cherry-picked and combined your changes in my fork (https://github.com/1u0/flink/tree/pr-9538-docs-hotfix), but I cannot merge into main flink repo or update your fork (your PRs).
If you can manage to reset one of your PR branches (for example patch-1) and push to your fork, you should see the PR updated with changes.
If you still have difficulties with git, I can also open a new PR with your changes as a last resort. But first let me know if you are ok with that.

@1u0 , you can open a new PR with my changes, it's OK to me,  appreciate for your help.


Consider using another BRKGA implementation

Hello, Victor! I've been working on an optimization framework as a side project and I see that you implemented the BRKGA metaheuristic here. Optimum has a BRKGA implementation which may be more efficient, although I decided not to introduce parallelism in this first moment.
Optimum is a WIP, but I think the BRKGA implementation is fairly self-contained and probably won't change for a while. If I find time, maybe I'll do this experiment myself, but if you get interested, let me know. It would be the first use of optimum by another person, and I would appreciate feedback regards the documentation and API.

Thanks for sharing @dbofmmbt , i will most definelly checkout Optimum, but currently parallelism in indispensible for trade-optimizer, the runtime execution is already to long depending on the parameters of BRKGA, even running with a powerfull CPU. I had considered using a external package for the implementation, whitch would most definelly implement it in a better way than on trade-optimizer, probably the case for Optimum, but most often the lack of build-in parallelism was a deal breaker.
Maybe in a version 2, i can give it a shot of a PR with Optimum with more updates.
Thanks again for the contribution


Feature: smart context query reorderer

Consider a predicate flatten non trivial:
: ?flatten_nt(int[][]) -> int[].
?flatten_nt([]) -> [].
?flatten_nt([x]) -> x.
?flatten_nt(array) -> flattened {
    flattened = append<int>(x, y);
    y = flatten_nt(t);
    linked(x, t) = array;
}

Predicate will fail if we try to instantiate array from flattened:
?- flatten_nt(x) = [1,2,3]
* too broad error *

to change this behaviour queries should be reordered
?flatten_nt(array) -> flattened {
    linked(x, t) = array;
    y = flatten_nt(t);
    flattened = append<int>(x, y);
}

the idea is to do that automatically
qcontext may have order field (a vector with order calculated on scope entering)
[2, 1, 0]

Reorderings for each case can be generated during predfinal generation.
(Body linking for each arguments I/U permutation)

there is a room for improvement in adding support for unify, unify all, quantor statements


SampleGen: Access map entries in output handling

Allow accessing the value of a map entry by the key using {}. e.g., $resp.map{key}

PTAL @beccasaurus @vchudnov-g

Will there be a follow-up PR (at some point) for iterating through Map values? 😄
For accessing via key, I'm 👍
I love all of the test cases in the YAML and baselines look good to me!!
Thank you for this super quick follow-up to #2584
/cc @tswast

Ah, I didn't read #2584 carefully enough. This PR clearly doesn't solve iterating through map values :(
But we still need this PR :) So I'll leave it here and work on #2584 in a separate PR.
Edited the PR comment as well.

Np, we need this too! Both halves of the Map support equation. 😎
I'm guessing you'll need to play around for a sec to figure out whether we do something like
- loop:
    collection: $resp.some_map
    key: key_variable
    value: key_variable

... or something like ...
- loop:
    collection: $resp.some_map
    variable: key_value_pair
    body:
    - print:
      - "Hi from %s and %s"
      - key_value_pair.key
      - key_value_pair.value

... or? 🤷🏼♀


Couple of fixes for get_name

Fixed printing of BOOST_PFR_FUNCTION_SIGNATURE in print_config.cpp
Fixed producing a trash from the call boost::pfr::get_name<0, int[10]>()

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
397

Relevant Lines:
397

💛  - Coveralls


Typo in the documentation

Creation table service.feedback query has a typo.
Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 46d10c12-b07b-1541-0aa4-5f9336f81fab
Version Independent ID: e5d0e48b-dc13-0b42-3c72-f5c82ecd9592
Content: Dynamic data masking - Azure SQL Database
Content Source: azure-sql/database/dynamic-data-masking-overview.md
Service: sql-db-mi
Sub-service: security
GitHub Login: @Madhumitatripathy
Microsoft Alias: matripathy

@geertvl Thank you for the feedback. We are actively investigating and will get back to you soon.

@geertvl Thanks you for noticing the issue and creating a PR to update it. Really appreciate.
We will now proceed to close this thread. If there are further questions regarding this matter, please comment and we will gladly continue the discussion.


asio.hpp can't be found.

When I build the example, I can not find the file "asio.hpp" which is included in the file "asiohandler.h", any suggestions?

You need to install Boost Library. You can find in this link: http://www.boost.org/

I have installed boost, Now I have the following compile problem with the steps in the following:
I goto the folder [AMQP-CPP/examples/rabbitmq_tutorials]
1.cmake .
2.make
the output has a lot of errors such as:
/usr/include/amqpcpp/array.h:97:31: error: 'ptr' was not declared in this scope
_fields.push_back(ptr);
^
/usr/include/amqpcpp/array.h:102:30: error: 'ptr' was not declared in this scope
_fields[index] = ptr;
Seems the CMakeLists.txt has some problems, maybe need to change the content of  "include_directories"
Any suggestions?

I've been using g++ 5/gcc 5 to compile this library with -lboost_system and -lboost_filesystem in compiler options.

I am closing this issue. The boost-asio example does not come from me, and I am not so familiar with boost so I don't know how to fix it. It would be helpful if anyone could send in a pull request to solve these issues, otherwise I am going to remove this example as it seems to generate more questions than it answers.


iOS 12.3 Beta 2 - Upcoming changes

With iOS 12.3, the following changes are coming to HomeKit regarding TV Accessory:

It is no longer possible to select a specific input when the TV is off (see image)

Could you possibly add a way to not have the TV show up in the Apple TV Remote? I have an Apple TV and a Sony TV in my Living Room, and I want to be able to change the Input, but having two "Living Room" devices in the Remote app makes is cluttered. Love the plugin, by the way!

Could you provide more info regarding the customSpeaker parameter? It is not supported by iOS 12.2. Does it mean that Airplay 2 will be supported on existing TVs?

@bxlouis
the ‚Television Speaker Service’ is not supported atm by apple, therefore i have added custom speaker
With customSpeaker you are able to expose an alternative Axcessory as Speaker to HomeKit, eg Lightbulb or Speaker Service (Speaker Service is only visible in 3rd party apps like EVE etc)


2024 optd Goals

This is a first draft of a document detailing the high-level goals for optd that we have been talking about over the past few weeks. I've summarized it as 4 main goals, but there might be some higher-level visions that I'm missing.
There are still a lot of TODOs, mainly places where I don't really know what the decisions were or what the concept behind them is. One of the more important TODO places is the database schema layout, I don't fully understand the "left side of the whiteboard" (from our meetings).
There's also a very incomplete design section at the bottom with a few notes on things we talked about in our more recent meetings (I likely don't have time to go through that and make it more detailed any time soon).
My hope is that we can solidify some ideas now in writing so that we can start actually making progress, as well as to begin documenting the decisions we're making so that people can look back on this and understand why we've decided on what have done (really what will will do).
Feel free to comment, though this took a while and I need to focus on other things so I probably won't be able to address them quickly. Please make changes as necessary.

I would really prefer not to see a design document dropped into the root repo.
Is it possible to make this into a google doc and share it internally?

I would really prefer not to see a design document dropped into the root repo.

You can copy and paste it in then. I wanted to have something that was tracked my git and viewable by everyone, but it's not that important.

I think let's move this to Google docs for now.


Add autoselect feature

Closes #53

Looks good to me. Might want to update the docs too.
By the way, one way to make the maintainers perhaps more comfortable might be to demo the old and new behavior with a screencast http://www.screencast.com/

I've updated the typeahead docs here
I feel this feature is clear enough to not require a screencast, but happy to do so if you feel it's necessary.

@jcrben It has been working as expected in production.

+1 love to see this merged in

actually, @DanielApt, I built this myself and caught a bug. The onblurred event doesn't have any arguments passed in and thus the referenced $e is undefined.

$('.typeahead').bind('typeahead:render', function() {
  $('.typeahead').typeahead('moveCursor', +1);
});

@synth was the event passing issue introduced by this PR or was it a pre-existing 'feature' of the previous code-base? If it is pre-existing and adding the event argument later will not cause a regression, I think this could be merged in. Or am I misunderstanding the situation?

@MarkHerhold well, this code hasn't changed from twitter's codebase, so I'm pretty sure its always existed this way. :rocket: merge

Sorry, been a bit out of the loop on this one. Would you want me to add @synth's code snippet to my PR?

Moving this to the 0.11.3 milestone, since it's not clear if this is ready to go.
@DanielApt and @synth is the onBlur event issue resolved?

Just migrated from the old twitter typeahead for other reasons, but our clients miss this feature. Looking forward to seeing it in the next release.

+1 when can we see this merged?

@JonathanSeguin, When the merge conflicts are resolved. :wink:
I likely won't have time to look at this in the near future. If you or @hutch120 think you're up for it, feel free to resolve the conflicts and submit a new PR. I haven't even had a chance to see how extensive the conflicts are (could be a fairly simple fix).

@jlbooker See #148 for new PR

This was recently merged. Move to close.

Thanks guys! Since I added this feature into other repo and haven't check its committed in here...


Include a robot.txt to generally disallow all scraping

This could possibly be too restrictive, but going to start here and loosen restrictions if needed.

/gcbrun


icd: Add VkAndroidHardwareBufferFormatResolvePropertiesANDROID

CI Vulkan-Tools build # 1220 running.

CI Vulkan-Tools build # 1220 passed.


Format policy-configuration in policy-configuration-file.md

Pretty-formatted the json to increase readability.

@chcomley
IMPORTANT: When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

#sign-off


Error: ERROR CODE 218 - Keybase services aren't running - KBFS client not found

I'll start off by saying that i tried to search the issues here for a solution, but none of the suggestions for this or similar issues worked. The issue possibly started after an osx update, but i can't be quite sure of that.


This set of changes brings us to feature complete for canceling donations, and refunding subscriptions.

I'm going to do some optimizations, cleanup and a Stripe API update, and we probably will be at feature complete for stripe.
In views_donation.py misc. fixes to make all the webhooks work.
In donate/controllers added a fifth hook, charge.refunded and more error
handling.
In donate/models.py added a textwrap call to prevent overlength status
lines from failing the db transaction.  Some complicated new stripe
transactions to confirm payment refunds, and subscription cancellations.

👍


17 pocketguide

Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after):
Fix #17
Test URLs:

Before: https://main--sazerac-wheatleyvodka--hlxsites.hlx.page/
After: https://17-pocketguide--sazerac-wheatleyvodka--hlxsites.hlx.page/drafts/pocketguidepreview

Can you please publish (or at least preview) the template? It doesn't seem to work for me like this - I would like to see the pocket guide. Additionally, it would be good to change the check url of the PR to actually target a page that contains the pocket guide.

Seems like the pocketguide template was unpublished, yesterday it was visible. I republished it. I will change  the check url in this PR then.

so now we have
BP 1152+

1000-1152

below 1000


PR: Use Python module to launch pylint

I ran into a problem getting the right version of pylint to launch within the plugin since it's not configurable and expects 'pylint' to used for Python 2 and 'pylint3' or 'python3-pylint' to be used for Python 3.
In my configuration (Fedora 25) the system-installed pylint is 'pylint' and 'python3-pylint', however in order to use a newer version, I've installed pylint using pip3 and the --user option to install it under ~/.local. This creates a 'pylint' executable for Python3 in ~/.local/bin.
In order to use the newer version within Spyder, I have to modify my system PATH as well as rename or symlink ~/.local/bin/pylint to 'pylint3' or 'python3-pylint'.
My proposal is to avoid all this by using the pylint module which is already a requirement for Spyder. The module can be imported to determine the version and can be executed using '-m' for both cpython and pypy.
Here's my attempt to do this. It works well, but I'm not sure of there is a better way to do parts of it.

Thanks for your contribution. I don't know this bit of code, but in my experience with the unittest plugin calling modules with python -m is indeed more robust than using the executables.

@avylove, thanks a lot for your contribution! We'd like to include it in our upcoming release, so I'd like to ask you to rebase your branch against our 3.x branch.
As it's clearly stated in our contributing guidelines, changes to master are meant for the next major Spyder release, which could take 8 to 10 months to go out.

@rlaverde, what's the git command to do this?

@rlaverde, what's the git command to do this?

git rebase --onto <new_base> <old_base> <branch>
git rebase --onto 3.x master pylint_from_module

Rebased to 3.x. Not sure why that test is failing. Ideas?

@avylove, that failure was unrelated to your work. After a restart, all our test are passing.
@rlaverde, please open a PR and add those git commands to our Contributing guide. Thanks!

Found a bug in the original code I'd like to put a PR in for, but it touches the same lines. Should I wait until this gets commited to 3.x?
Basically need to add '--output-format=text' to the pylint options in order to account for things like output-format=colorized in pylintrc

Please do it here. Fortunately this PR hasn't been merged, so there's no problem with that.

@avylove, I did a quick review and everything looks good to me.
I think we should have done this after requiring pylint as a required dependency. Thanks a lot for helping us with this!


Incorrect Refund Amounts for Expense Refund with Payee Covering Payment Processor Fees

Describe the bug
Noticed this while working on https://github.com/opencollective/opencollective/issues/4691. It seems that when a user refunds a expense transaction where the payment processor fee has been payed by the payee, the refund expense has incorrect payment processor fees.
To Reproduce
Steps to reproduce the behavior:

Submit an expense with the payee paying the payment processor fees.
Refund the expense.
Notice the refund transactions.

Expected behavior
For expense refunds the payment processor fee should be 0 regardless of whether the payment processor fee is covered by the collective or the payee.
Screenshots
Expense and Refund Transaction from the Perspective of the Collective

Expense and Refund Transaction from the Perspective of the Payee

Looking at this further it seems that we intentionally add the paymentProcessorFee fee as a positive value to the refund when the payee is paying the payment processor fee.
https://github.com/opencollective/opencollective-api/blob/73abef105abd28b47f8d7746ec827c3384f7d451/server/lib/payments.js#L203-L216
This is what led to my confusion as the refund expense object has a paymentProcessorFee. Anyways, I think we can mitigate this by adding the payment processor fee directly to the amount and for this I've proposed a PR.
@Betree : Since you've worked on this part recently I've assigned this to you. Let me know if this approach is correct and if I missed anything here. 🤔

For expense refunds the payment processor fee should be 0 regardless of whether the payment processor fee is covered by the collective or the payee.

I don't agree with that, could you elaborate on why we would want the processor fees to always be 0 for expenses?
If I paid -100 in processor fees and they're fully refunded by the provider, I expect to see +100 for the processor fees on the refund. That way, the sum of the column will tell me that $0 was paid in processor fees. If I don't record this +100, the sum will inform that 100 were paid in processor fees, which is false.

I think the issue you're confronted with is only a problem of labeling. You want to do something like:
{!t.isRefund ?
  `Payment processor fees: ${t.paymentProcessorFees}`
  : `Refunded payment processor fees: ${t.paymentProcessorFees}`
}

For expense refunds the payment processor fee should be 0 regardless of whether the payment processor fee is covered by the collective or the payee.

I don't agree with that, could you elaborate on why we would want the processor fees to always be 0 for expenses?
If I paid -100 in processor fees and they're fully refunded by the provider, I expect to see +100 for the processor fees on the refund. That way, the sum of the column will tell me that $0 was paid in processor fees. If I don't record this +100, the sum will inform that 100 were paid in processor fees, which is false.

Here I think the labeling of the variables is what got me. Since on the API we use the same variable name paymentProcessorFeeInHostCurrency for both the transaction and the refund transaction I thought why we have payment processor fee on the refund. I was expecting to see something like, refundedPaymentProcessorFeeInHostCurrency but now your explanation solved it for me. Thanks. 👍🏽

I think the issue you're confronted with is only a problem of labeling. You want to do something like:
{!t.isRefund ?
  `Payment processor fees: ${t.paymentProcessorFees}`
  : `Refunded payment processor fees: ${t.paymentProcessorFees}`
}

This makes sense. I wasn't showing this refunded payment processor fee on the refund expenses currently but will look into adding it. Thanks. 👍🏽


rate and irate functions return a huge value

I use the sum+rate function to calculate the TPS,Raw data is typically in the tens of millions, and TPS is around a few thousand. But for a while, about two hours ,It suddenly went up to tens of billions.
Use offset to query normal
Kindly  please answer me  the reason. many thanks

Maybe you could write a query without those functions and tell us the raw samples? It's hard to tell what's happening. Also, which engine are you using? Are all components on the latest version?


WSB fixes (Windows SandBox)

The admin user has no rights to the machine winget..
..and as System you can't run the installations under Get-WingetStatus.
You'll have to install WAU (as admin or system) via WiGui and then search and install apps as System in WiGui.
As I do via NirSoft AdvancedRun

or, we can try to apply same prerequisites from WAU to WiGui, no ? :)

Happy birthday!

Thank you :)
So, if WAU is installed as system, does it still work ? in that case we need to install prerequisites with WiGui

I'll test again eventually. I have a dev in my fork for downloading and starting WinGui with AdvancedRun as System visible automatically.
Will try installing WAU as System first of all.

Well, now I know it...
...if you implement the full Winget Prerequisites for WiGui in Get-WingetStatus its a simple matter of ACL management in Windows SandBox, then you can run WiGui as an ordinary Admin:
#Check if Winget is installed, and install if not (fix ACL in WSB)
$WhoAmI = & whoami
if ($WhoAmI -like '*wdagutilityaccount') {
    #WindowsApps folder
    $Script:AppsLocation = "$env:ProgramFiles\WindowsApps"
    if (!(Test-Path $AppsLocation"\WSB.fix")) {
        & C:\Windows\System32\takeown.exe /F $AppsLocation /R /A /D Y
        & C:\Windows\System32\icacls.exe $AppsLocation --% /inheritance:r /grant:r Administrators:(OI)(CI)F /T /C
        New-Item -ItemType File -Force -Path $AppsLocation"\WSB.fix" | Out-Null
    }
    Get-WingetStatus
}
else {
    Get-WingetStatus
}

...I'm a dinosaur so I find myself using Windows native tools from PS instead of writing my own thing...
🤪


Questions about base models' training time, loss, etc.

Checks

[X] This template is only for question, not feature requests or bug reports.
[X] I have thoroughly reviewed the project documentation and read the related paper(s).
[X] I have searched for existing issues, including closed ones, no similar questions.
[X] I confirm that I am using English to submit this report in order to facilitate communication.

Question details
hello, 非常棒的工作！我在基础模型上进行了一些模型结构的调整，并在Emilia数据集上重新开始训练底模，想问下，loss到多少的时候模型开始可以正常发声呢？你们在训练开源的这个底模的时候，用了多少机器和时间能达到正常发声呢？多少时间能到收敛呢？

Hi @ruby11dog , we could use English to submit this report in order to facilitate communication. (Checks 4.)
Loss is not significant to see how training process goes as pred and gt boundries are mismatched.
We have posed all results and detailes of training and evaluation in our paper. For base model 8*A100 80G over one week to reach 1.2M updates, 200~400k to hear some aligned speech (say, intelligible)

using English to submit this report in order to facilitate communication.


Explorer on BSX gallery don't show any items

It Seems collections show something, but in an explorer-like gallery, I see nothing?

Collections seems ok

Originally posted by @yangwao in https://github.com/kodadot/nft-gallery/issues/3171#issuecomment-1159684521

Fixed along with @petersopko


Electron app cannot open after some successful attempts

Windows Build Number
22000.132
WSL Version

[X] WSL 2
[ ] WSL 1

Kernel Version
Linux version <IP_ADDRESS>-microsoft-standard-WSL2
Distro Version
Ubuntu 20.04
Other Software
Docker Desktop (Windows): Version 3.5.2
Microsoft Visual Studio Code - Insiders (Remote - WSL): Version 1.60.0
Repro Steps
git clone https://github.com/stackacademytv/master-electron
cd master-electron
npm install
npm start (or npm run watch)
Expected Behavior
Open electron app window directly
Actual Behavior
Whenever I restart the computer, the electron app window appears as expected for the first few times. However, at some point, it just doesn't show up any more. I don't know whether it is caused by some GPU problems or WSL problems.
Diagnostic Logs

<EMAIL_ADDRESS>watch /home/will/projects/electron
nodemon --exec electron .

[nodemon] 2.0.12
[nodemon] to restart at any time, enter rs
[nodemon] watching path(s): .
[nodemon] watching extensions: js,mjs,json
[nodemon] starting electron .
NVD3D10: CPU cyclestats are disabled on client virtualization
NVD3D10: CPU cyclestats are disabled on client virtualization
NVD3D10: CPU cyclestats are disabled on client virtualization
NVD3D10: CPU cyclestats are disabled on client virtualization

I installed the repo that you listed and tried running it around 10 times in a row. I wasn't able to reproduce this issue. Do you have any other repro steps here?
As well, could you please file this at the WSLg repro repro and we can follow up there?

Thanks for the response.
Well it seems the last few lines of error are gone after I installed the nvidia-340 apt package. The problem of electron app window not showing up is solved together with it.
Clearly now it is a GPU problem. Do I still need to file this at the other repo?

No I don't think so, thanks for filing it here!
It seems like the root cause here was a Linux binary based GPU issue. Since you're now in a working state, and I'm not able to reproduce this, I believe we can close the issue as there isn't anything actionable for this on the WSL team. Please let me know if you're still seeing this issue and would like me to reopen. Thank you!


Livewire V3

This PRs continues on the great work by @wverhoogt on https://github.com/enflow/livewire-twig/pull/14
We've modified the PR to move to a dot syntax, so that all livewire calls in Twig are namespaced.

@wverhoogt I'm hoping you can perhaps review these changes! Happy to learn your thoughts here.

I looked at your modifications, and like the idea fo namespacing. Your code is nice, well commented (I tend to use less comments).
I noticed something in LivewireTokenParser.php:
        if (! $stream->test(Token::NAME_TYPE, 'endpersist')) {
            throw new SyntaxError('Expected the "endpersist" tag.', $stream->getCurrent()->getLine(), $stream->getSourceContext());
        }

        $stream->next();  // Consume the 'endpersist' token

could be replaced by
        $stream->expect(Token::NAME_TYPE, 'endpersist');

a slight simplification.
Also, the current implementation of persist does not support other Livewire usage inside the persist block. I don´t know if that would be a problem, though.


Usecase a

Added tools and general info for usecase A

Spot availability searching script is updated and documented. Checks availability spanning a single year around the date of interest.


Vesta Control Panel Support

Hi,
I've just made password reset plugin for open source control panel vestacp.com. Please review it and let me know if it there is anything I should change or modify. Thanks

Thanks! Everything looks great.

@serghey-rodin,
Any additional guidance on how to properly configure your wonderful and much needed plugin?
I am getting "Could not save new password" even after assigning the fields in the configuration.
I am using {user:domain} of the vesta accounts hosting the email account.
I appreciate any assistance.

Seems there is an error in the vesta driver (since a recent roundcube update?), here is a topic on this which fixes the driver and seems to work inside roundcube which was generating the same error:
http://forum.vestacp.com/viewtopic.php?f=12&t=10114
I dont currently know enough to fix this plugin, I am including this here for further research and for anyone else looking into this.


Wekan v3.51 released

https://github.com/wekan/wekan/blob/master/CHANGELOG.md
http://releases.wekan.team/raspi3/wekan-3.51-arm64.zip

Oops sorry, I'll make new bugfix release first, and then add issue about it.


Npm version failsafe

Simple check to see if NPM is above a certain version during "make configure" step. Required version is stored as a variable and can be altered as needed. Tested on Ubuntu 18.04.
Note:
Newest available NPM version on Ubuntu/Debian APT is 3.5.2. It does not work.
Current version is 6.4.1. It does work.
I chose 6.0.0 as an arbitrary cutoff. If there is a known minimum working version, it should be set to that instead.

This seems like a good idea, but there's some things to fix.

You should make the PR against the 'next' branch since that's where new development happens.
The version check should probably be in the makefile, because the build system in next is a bit different and that reduces code duplication.
We could also add a failsafe for the GNU Make version since I remember having some problems with older versions of make.
You can just use the minimum version numbers stated in the documentation for the checks. I think I researched those a bit and they should work.

1 and 2. I'll review the next branch and retool the process if it's still required.
3. While I'm doing the research and planning for this, I can roll in the make requirements.
4. Perfect, I'll pull the requirements from both for planning.
It will be a few days, I'm sure, I've never worked with makefiles before and I'll have to learn. Thanks for the guidance.

Great! Makefiles can be a bit finicky at times but I'm sure you can make it work.


Compile problem with wasm32 using bracket-terminal 0.8.7

I'm pulling bracket-terminal into my project as a dependency and compiling for wasm:
 rustup target add wasm32-unknown-unknown
 cargo install wasm-bindgen-cli
 cargo build --release --target wasm32-unknown-unknown

I'm seeing the new errors:
error[E0432]: unresolved imports `glow::NativeFramebuffer`, `glow::NativeTexture`
 --> /home/dan/.cargo/registry/src/github.com-1ecc6299db9ec823/bracket-terminal-0.8.7/src/hal/gl_common/framebuffer.rs:3:24
  |
3 | use glow::{HasContext, NativeFramebuffer, NativeTexture};
  |                        ^^^^^^^^^^^^^^^^^  ^^^^^^^^^^^^^ no `NativeTexture` in the root
  |                        |
  |                        no `NativeFramebuffer` in the root

   Compiling async-executor v1.4.1
error[E0609]: no field `fitscreen` on type `hal::wasm::InitHints`
   --> /home/dan/.cargo/registry/src/github.com-1ecc6299db9ec823/bracket-terminal-0.8.7/src/initializer.rs:455:29
    |
455 |         self.platform_hints.fitscreen = fitscreen;
    |                             ^^^^^^^^^ help: a field with a similar name exists: `fullscreen`

Oops! I'll try and get that fixed, probably tomorrow. It looks like I missed a type alias.

Oops! I'll try and get that fixed, probably tomorrow. It looks like I missed a type alias.

Hi, at least could you please point out which was the prior version of bracket lib that was working to generate the wasm files following the instructions from you website?

You can change your dependency in Cargo.toml to read bracket-lib = "=0.8.1" and it should work. I'm working on a fix for this version now.

I have a few other fixes to roll up before I release 0.8.8. In the interim, you can use the latest version with WASM by using the following as your dependency:
bracket-lib = { git = "https://github.com/amethyst/bracket-lib.git" }

It compiles now; when I've had some more coffee, I'll do a full integration test.

Thanks! I can confirm the latest unreleased version works.
@jimmykiang - the last released version that works is 0.8.5

just confirming that my hello world example fails for me in the way described in this ticket on 0.8.7, (when following the wasm guide in the rust roguelike tutorial) but still works for me when I pin brackets-lib to master.

If you want to pin the most recent buildable commit (according to git's CI), you can do this :
bracket-lib = { git = "https://github.com/amethyst/bracket-lib.git", rev = "851f6f08675444fb6fa088b9e67bee9fd75554c6", features = ["serde"] }

In case you came here trying to compile Chapter 1 from "Hands-on Rust" you need to add
rltk = { git = "https://github.com/amethyst/bracket-lib" }
(not bracket-lib) as described here https://github.com/amethyst/rustrogueliketutorial/issues/201#issuecomment-1427829960

Thanks for posting the solution to the wasm build!
I was following the directions on running wasm on https://hands-on-rust.com/2021/11/06/run-your-rust-games-in-a-browser-hands-on-rust-bonus-content/ after finishing Hands-on Rust (Fantastic book, btw!) and luckily found this github issue with a fix.
Putting bracket-lib = { git = "https://github.com/amethyst/bracket-lib.git" } in my .toml worked for me to compile. There was a little confusion as the output files were going in to .wasm_help instead of wasm_help and slash vs backslash on the copied commands, but after I sorted that out, the Dungeon Crawler was running in my browser with a local python web server I ran using python3 -m http.server. I'm very excited about the possibility to self-host little proof of concept games.

I hope so. I've had a really nasty combination of being ill, overworked, a
crazy toddler and a bit of burnout. So I'm trying to get this into my
schedule and ease back into things.
On Mon, Feb 5, 2024 at 7:43 AM NaughtyDog6000 @.***>
wrote:

@thebracket https://github.com/thebracket
is there any plans to release a newer version (at least the patch for
wasm) so that people dont have to rely on a link to the GH repo and instead
can use cargo add as you would expect. If not could you add a warning to
readme / docs to state the last version that compiles wasm correctly?
—
Reply to this email directly, view it on GitHub
https://github.com/amethyst/bracket-lib/issues/301#issuecomment-1927043066,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ADRU435TLHRECSKA7STS65TYSDOZBAVCNFSM6AAAAAAQ5ZO2ICVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMRXGA2DGMBWGY
.
You are receiving this because you were mentioned.Message ID:
@.***>


⚠ Samsung has degraded performance

In b200983, Samsung (https://samsung.com) experienced degraded performance:

HTTP code: 200
Response time: 2951 ms

Resolved: Samsung performance has improved in 9d81255.


Dropdown focus management leads to inadvertent Tab-trap

Using version 2.0.26. As far as I can tell, this affects both v4 and v3 flavors.
Reproducing:

Go to the demo page
Open one of the Dropdown components using the keyboard
Hit shift + Tab to (try to) back up to the trigger button. Focus immediately shifts back to first menu item.

After some light digging in the source, I think this is what's going on: When trying to back out of the menu by tabbing backwards (shift-tab) and focusing the trigger element again, the keyHandler kicks in, isSameElement evaluates to true, throwing focus back to the first item, trapping the user in a focus loop where they are unable to move backwards (unless they close the Dropdown using other means). As far as I can tell, this is reproducible across browsers.
Suggested fix is, for me personally, that the automatic focusing of items is ditched altogether  (apart from when using arrow navigation once inside the menu) – I understand the rationale and trying to help the user, but I just think it's just a tad too helpful.
My hunch is that it's not something I think users are expecting, and it's not something I feel I've come across in other dropdown components, including the version from official Bootstrap.

I don't see that as an issue, I coded that on purpose, if you wanna get back to parent dropdown, you just hit Esc.

Kudos for reconsidering this.
This issue is currently blocking a release for a client project of ours, as it's considered a violation of keyboard accessibility (WCAG2.1, 2.1.2, No keyboard trap), so I've forked it for now and implemented a couple of fixes that I needed to see:

No automatic focusing of menu items on open (or shift-tabbing backwards to the trigger) - matches original Bootstrap functionality and follows keyboard accessibility conventions for dropdowns.
Uses event delegation of focus event to dismiss the dropdown if focus moves outside of menu - matches original Bootstrap functionality, required minor change to how on() and off() works (allowing the use of an options argument, as delegating focus requires the useCapture flag, pretty much. (This change to event delegation can likely be ditched if we would switch to the focusin event, which does bubble, but it's not supported in Firefox < 55.)
And, finally, fixes another issue where dismissing the dropdown always focuses the trigger element, which clashes with being able to focus other items on the page. As an example, try opening a dropdown on the v4 demo page (using either keyboard or mouse), and then click one of the collapsible sections for example. Focus is stolen back to the dropdown trigger as it closes. I've changed the hide() method to check for document.activeElement inside the menu, and only focus the trigger if that is true. This one should probably be opened as an issue of its own, if one doesn't already exist.

I'd be happy to open a PR for this (as soon as I get this project out the door) if you feel these are fixes that you'd be OK with.

I've checked your changes and seems to be OK at the first sight, for me personally I really want to keep the ability to navigate nested dropdown menus.

@emilbjorklund I've added this into the master, soon to add the modal intentional trap as well, please keep an eye on the master repository.
Thanks

LGTM. Cheers! 👍

Re: modal trap - have found some issues with the current approach in Safari, will try to investigate, but might be worth to hold off on that for now.


Sidebar to consider available height of parent div rather than window

Is your feature request related to a problem? Please describe.
Currently, the editor sidebar fills a height which appears to be related to the overall window, rather than the space that the pdfme editor occupies.
If pdfme is placed within a container (such as the playground) the sidebar is longer than the viewport area and the Add new field button is wrapped off the bottom:

You have to scroll down to see it.
Describe the solution you'd like
Make the panel and it's children set the the available height of the pdfme designer / form container rather than the window height.
Describe alternatives you've considered
Ideas for other ways to implement this are welcome. This could also be looked at as part of #248.
Additional context
No response

I don't think this is a bug.
I think you need to make sure the surrounding container for the Designer is the correct height. I have added a PR for the Playground for this.
We maybe want to update documentation though, I will check...

I will add a PR to the docs with a section to point people to examples of embedding the designer, than I think this can be closed.

@peteward
Can we close this issue?


derive class name from key, #81467

This PR is for https://github.com/microsoft/vscode/issues/81467. Instead of using the default id generator which created ids like 1, 2, 3, 4 etc uses the (already computed) key* when generating class names.
*the key is hashed so that we surely have something that is valid CSS

Thanks


Updated iWildCam default hyperparameters

Results: https://worksheets.codalab.org/worksheets/0x036017edb3c74b0692831fadfe8cbf1b

Holding off on this until we figure out the issue with iWC 2.0.


Migrate order discount id from int to UUID

Change order discount id from int to UUID.

Impact

[ ] New migrations
[ ] New/Updated API fields or mutations
[ ] Deprecated API fields or mutations
[ ] Removed API types, fields, or mutations
[ ] Documentation needs to be updated

Pull Request Checklist

[ ] Privileged queries and mutations are guarded by proper permission checks
[ ] Database queries are optimized and the number of queries is constant
[ ] Database migration files are up to date
[ ] The changes are tested
[ ] GraphQL schema and type definitions are up to date
[ ] Changes are mentioned in the changelog

Task linked: SALEOR-6403 Migrate IDs to UUID


TypeError: unsupported format string passed to Variable.format

Traceback (most recent call last):
File "train.py", line 207, in
main(parser.parse_args())
File "train.py", line 121, in main
optimizer=optimizer, train_loader=train_loader, args=args)
File "/home/user/2T-G/zyy/Deep_metric-master/trainer.py", line 62, in train
loss=losses, accuracy=accuracy, pos=pos_sims, neg=neg_sims))
TypeError: unsupported format string passed to Variable.format
I have encountered the above problem, can you help me solve it? Thanks

which version of pytorch do you use?

The code have already  update to pytorch 1.0, you may first try to update your pytorch to 1.0 version, and then to find whether the problem still exists.


Fix term date errors that prevented assigning Congress numbers to terms

...

Ok so one of our old issues (#185) was that we wanted to put a Congress number (or range) on each term. But the historical data had a lot of errors (mostly from senate appointments, possibly because my original scrape of bioguide didn't work right) where the date ranges on the terms didn't line up with valid term ranges, like senate terms longer than six years, or missing term boundaries where we know there should be according to the senate class.
This PR adds a test that checks that each term corresponds to a Congress number or valid range and fixes all of the remaining data errors so that now the test passes.
After this, we can go back and solve #185.

I added a second commit that fixes overlapping terms in historical data. We had a test that was disabled for historical data because of these errors. Now the test is enabled and there are no failures.


Re-implement boolean methods for custom type return

As per @dubek 's #67 suggestion I've researched and found in the FFI spec we can return custom types.  See custom_type_spec.rb
We'll match the types to the way Ruby already does.  This will be new behavior so we'll set this to release version 0.2.0

My thoughts quoted from the other thread on dealing with multiple types

Rust allows only 1 type to be returned and FFI even more so expects one type to be returned. To model multiple types we have to create our own type, which will wrap both types, which we can do in both Rust and FFI with Structs.
But then thinking about how to handle the struct in Ruby we might be adding something like raise struct.error if struct.error otherwise return struct.value . That Ruby conditional will likely cost us lots in performance
I'm not sure how deeply coupled the FFI lib is within the code that is written in itself. For example we can do callbacks which lets us evaluate a block in another call to "Rust" but still has the original method returning a type... which should be of one type of return.
I think the issue really comes down to how much we can cheat the one return type design and how much FFI will let us conditionally return that value without higher level Ruby code evaluating that condition.

If there is a noticeable performance hit on this it may be thrown out.

Here's an idea on hacking performance and allowing error messages without using Structs but using callbacks.  This is not working code, just for example.
def ruby_method_for_rust_implementation
  return_vals = [nil, TypeError]
  type = 0
  rust_thread_callback = RustThread.new { some rust callback thread pointer }
  return_vals[0] = call_to_rust_method(parameters, rust_thread_callback)
  return_vals[rust_thread_callback.result]
end

This is assuming that a hash index is faster than an if condition.  Also I'm a little unconformable with threads but as we're hopping between code bases it might be a good idea.  It might be a very bad idea.

I'll leave FasterPath methods with the same behavior.  If new behavior is needed for monkey-patches or refinements we'll just write alternative methods for those.


Three example detection network models (ped-100,multiped-500,facenet-120) are not available

Hi, I am running this demo code. In the DetectNet section, the pretrained detection network models(ped-100,multiped-500,facenet-120) are needed. However, the download links are invalid. Are there any other ways to download the pre-trained models?
thanks!
eric

Hi, I checked the links again and they are still up.   Are you able to access below?
https://drive.google.com/uc?export=download&id=0BwYxpotGWRNOUmtGdGIyYjlEbTA

it's ok now! thx


Added my data

Please add the hacktoberfest label.

Please resolve the merge conflicts. @Cheeh1

merge conflicts fixed. Thanks

Good job @Cheeh1
Congrats 🎉, your PR got merged. To be eligible for the swags from ClueLess. Follow this steps.

SignIn / SignUp in ClueLess Website .

Go to profile section from the top right hand corner.

Comment your profile URL under this comment tagging the person who merged your PR.

That’s it. Follow the leaderboard !
And don’t forget to share your achievement with your friends.


patches

this is more of an request than it is an issue,
for example with status2d modified to fit statuspadding + systray, you could turn it into a patch for others to use
the reason i had actually opened this issue is because i shamingly copied chadwm's updatesystrayicongeom but it gave me

which prompted me that i did something wrong.
will it ever be possible to turn most features implented in chadwm into it's own individual patch?

my friend a lot while patching the systray+status2d , maybe you could check the commit history +_+

my friend a lot while patching the systray+status2d , maybe you could check the commit history +_+

going through all of the commits or blames will take plenty of time, but due to the undocumented code it will be harder.
thanks for the suggestion but I have tried (probably not hard enough? who knows.)

@wael444 whether would you want to reset the position of systray?  The systray be put to the center of its panel? If yes, maybe you can view this site which is my repository of 'dynamic window manager'. Although I like mine, I recommend that the best choice is to use the 'chadwm'.
Make modifications while standing on the shoulders of giants.
Also, you can patch some patches you like but not on the official site to yours. For example, while you patch 'statuspadding' patch you will think that how to change the position, then you will find the corresponding function and make modifications. This process will make you study more and more knowledge.:)

@wael444 whether would you want to reset the position of systray?  The systray be put to the center of its panel? If yes, maybe you can view this site which is my repository of 'dynamic window manager'. Although I like mine, I recommend that the best choice is to use the 'chadwm'.

my way to doing my configurations is terrible but what I would do is to get the complete defaults then add my stuff on it

Also, you can patch some patches you like but not on the official site to yours.

many good patches on dwm are not on the patches site on suckless.org

For example, while you patch 'statuspadding' patch you will think that how to change the position, then you will find the corresponding function and make modifications. This process will make you study more and more knowledge.:)

thank you for helping.
though I got my systray icon size patch thanks to @baizeyv , I will still try to figure out how I can do the rest of the things that I would like it to do taking all of above into consideration.

@wael444 Did you mean this patch?
I merge the clean version patch just now.
(statuspadding+systray)

@baizeyv I'm not sure, I just need systray+statuspadding+status2d+(perhaps barpadding since I want to experiment) though thats already implemented in chadwm so I just simply copy.

@wael444 this
if you want to add barpadding, you can look at my repo.
function: drawstatusbar();
you could search content in this function.
Content: 'sp' or 'vp'
they are the marks of barpadding


Validate that the Store ID and Authorization Model ID are valid ULIDs

Related SDK Generator Issue: https://github.com/openfga/sdk-generator/issues/114

Resolved in #20


compose_box test: Use a layout similar to the message list page

This gives more vertical space above the compose box.  This will provide enough space for the autocomplete to appear without overflowing when we add tests for it.
This should be useful for both #928 and #1033. It doesn't aim to reproduce the exact things we do with MessageListPage.

before
after

LGTM, thanks! (Sorry for the delay; I meant to post LGTM earlier but I forgot.) Marking for Greg's review.

Thanks! LGTM; merging.


HV-872 optional relaxation of parameter validation

Started from version 5.0, rebased to master and merged to there. Built and unit tested.

hmm, looks a bit odd. There seem to be several commits which don't belong to master. Also I get merge conflicts? Could you try to create a local feature branch based of current HV master and apply your commits on it and re-create the pull request? Or maybe we can work out together where the rebase fails?

I agree it looked far more involved than it needed to. I'll try the local
feature branch approach. Admittedly, my GIT skills need development so
please feel free to advise.
Thanks,
Chris
On Mon, Jul 20, 2015 at 10:37 AM, Hardy Ferentschik <
<EMAIL_ADDRESS>wrote:

hmm, looks a bit odd. There seem to be several commits which don't belong
to master. Also I get merge conflicts? Could you try to create a local
feature branch based of current HV master and apply your commits on it and
re-create the pull request? Or maybe we can work out together where the
rebase fails?
—
Reply to this email directly or view it on GitHub
https://github.com/hibernate/hibernate-validator/pull/421#issuecomment-122904576
.

I'll try the local feature branch approach

Cool

my GIT skills need development so please feel free to advise.

 Try merging in your changes. Looking at your original pull request https://github.com/hibernate/hibernate-validator/pull/308
# there were only two commits, so you could try a cherry-pick and resolve all occurring merge conflicts
$ git cherry-pick c5b6b8eb1c352a6d2b31868afcf8e1246350a633

# resolve conflicts (follow merge instructions git cherry-pick will print)
$ git cherry-pick e02da73052021bbcf143999dc73784966e9891ba

# resolve conflicts (follow merge instructions git cherry-pick will print)

# make sure all still builds after merging and all tests including the new one pass
$ mvn clean install

# Push to your fork assuming it is called _origin_
$ git push origin HEAD

Once you have pushed to your fork you can use the Web UI to create the pull request. There are of course many other ways one could go about this, but this is the workflow I would try myself.

Hi @ctabeckey, If I read the PR history correctly, you haven't tried to fix the weird commit mix, correct?
If you could that would be awesome, otherwise, we will try and find time to do it.

@ctabeckey, could you give some quick feedback on whether you think you still can do the rebase or not? Thanks!

superseded by #448 which now applies to master


Preview handler error in Windows 8.1

AbcPreviewHandler fails to work under Windows 8.1/x64.
Other samples, such as a thumbnail provider works fine.
The SharpShell log says
Message: Abc Preview Handler: Instantiating preview handler.

And nothing more, so no other method with logging is called in SharpPreviewHandler.cs When the preview handler should be invoked, the preview pane in explorer shows ""This file can't be previewed because of an error in the Abc Preview Handler". I can't find any way of figuring out what has actually happened. Will explorer.exe/previewhost.exe log these problems anywhere in event log or similar)?
I did this:

Cloned from github
Built SharpShell + Sample with VS2013 (Default config : Debug/Mixed Platforms).
Installed abc preview handler from command line with srm install Path\To\AbcPreviewHandler.dll -codebase (Successful).

If I debug the ServerManager application and use "Test Server in Test Shell" the problem does not occur.
Edit: Implementing a previewhandler using the Windpws API Code Pack as a starting point works fine too.

After debugging it turns out it was a registration issue of some kind, coupled with a permission issue with logging (for some reason prevhost could not write to a logfile in \Temp after the registration). This can be closed.


Basic (s)-[p]->(o) query is not working when there is an RDFGraph in the db

kuzu> MATCH (s)-[p]->(o) RETURN count(*);
Error: Binder exception: Relationship pattern p with multiple rdf table labels is not supported.

We should be able to handle this.

This is duplicated with issue #2769


Stacks

This PR moves stacks (which represent evaluation environments, ie "terms with a hole") earlier in the development, and develops a notion of reducible stacks, ie counters of a given type A.
This should let us define reducible neutrals as those consisting of a variable, with a reducible type, in a stack reducible at that type, and get more precise information on what "reducible neutrals" look like, including the fact that they always are (deep) normal forms. This should please @ppedrot!

Kenji convinced me this is much harder than I though, leaving it out for now.


Add linting and cleanup accordingly

@karlpauls I know you can't approve your own PR, but it would be good to get your comments here regarding my changes.

LGTM!


Creating sample project and CI.

Adding the following:

CircleCI
Sample app
Codeowners
Pull request template
Detekt

Is the intention to make this public? If so, the PR template shouldn't reference our internal JIRA, instead using GitHub Issues.

@brycehendrix force pushed an update to the template and added hello world to the resource file.


External library source maps not included in the vendor chunk

🐞 Bug report
Command (mark with an x)
- [ ] new
- [ ] build
- [x] serve
- [ ] test
- [ ] e2e
- [ ] generate
- [ ] add
- [ ] update
- [ ] lint
- [ ] xi18n
- [ ] run
- [ ] config
- [ ] help
- [ ] version
- [ ] doc

Description
I have a simple Angular application, using an external library my-lib. This library comes with one minified main.js and main.js.map. main.js ends with //# sourceMappingURL=main.js.map.
In angular.json I have enabled "sourceMaps": true and I would expect all vendor source maps to be merged in the final vendors.js.map, but it does not seem to be the case. When I open Developer Tools -> Debugger -> webpack I see the original minified version of my external library, rather than the individual files inside it.
🔬 Minimal Reproduction

Create a simple library with 2 ts files and build it using tsc or webpack with sourcemaps. Run npm pack
Create a simple Angular application using the library as a npm package. Enable source maps in angular.json
Run ng serve and check Developer Tools

🌍 Your Environment

Angular CLI: 7.3.8
Node: 10.16.0
OS: win32 x64
Angular: 7.2.13
... animations, common, compiler, compiler-cli, core, forms
... http, language-service, platform-browser
... platform-browser-dynamic, platform-server, router

Package                            Version
------------------------------------------------------------
@angular-devkit/architect          0.13.8
@angular-devkit/build-angular      0.13.8
@angular-devkit/build-ng-packagr   0.13.8
@angular-devkit/build-optimizer    0.13.8
@angular-devkit/build-webpack      0.13.8
@angular-devkit/core               7.3.8
@angular-devkit/schematics         7.3.8
@angular/cdk                       7.3.7
@angular/cli                       7.3.8
@angular/material                  7.3.7
@angular/material-moment-adapter   7.3.7
@ngtools/json-schema               1.1.0
@ngtools/webpack                   7.3.8
@schematics/angular                7.3.8
@schematics/update                 0.13.8
ng-packagr                         5.1.0
rxjs                               6.4.0
typescript                         3.2.4
webpack                            4.29.0

Hi @boyanio, that is expected.
By default vendor sourcemaps are not enabled because they take a signification amount of time to generate.
To enable vendor sourcemaps you need to specify the vendorSourceMap option either via command line or angular.json
ng serve --vendorSourceMap

Thanks

Hi @alan-agius4 Thanks for the suggestion - I thought enabling sourceMap was enough. I did enable vendorSourceMap too, but to no avail - I do not see the individual sources in Developer Tools. Does the vendor source map actually collects each individual source maps from all vendors?

Yeah, you should be able to see them individually in the devtools, if the library offers proper sourcemaps. Are you for example able to view sourcemaps for rxjs? (Note that they might not be listed under webpack)
Try to use CTRL + P in devtools to look for a vendor sourcemap.
I also forgot to mentioned that you still need to enable sourceMap with vendorSourceMap?

@boyanio, managed to solve the issue?

Hi @alan-agius4 I tried to play around a bit more. I created a simple library and created a npm package out of it along with source maps. Next, I created a new Angular application and did npm i --no-save my-lib and used my my simple library inside app.component.ts. I enabled both source map options and when running npm start, I can see the source inside Developer Tools. However, when doing the same thing inside my real project (which is a way bigger), the source map does not seem to work. My angular.json looks like this in both projects:
"build": {
	"builder": "@angular-devkit/build-angular:browser",
	"options": {
	  "outputPath": "dist/apps/angular",
	  "index": "apps/angular/src/index.html",
	  "main": "apps/angular/src/main.ts",
	  "polyfills": "apps/angular/src/polyfills.ts",
	  "tsConfig": "apps/angular/tsconfig.app.json",
	  "aot": true,
	  "sourceMap": true,
	  "vendorSourceMap": true,
	  "assets": [],
	  "styles": [...]
},

Is there any limit on something that could break when the project is bigger?

@boyanio, no there isn't any limit. Another possibility is that the version you are using in your other other project has a bug that was fixed.

It seems indeed that it has been fixed in @angular-devkit/build-angular 0.801.3


Tiny issue with example

The example in the Readme.md says:
[r: js.makeFrame5("exampleFrame", "lib://com.lp-programming.maptool.utils/Page.html", getUserName())]

I suppose that should be getPlayerName() instead of getUserName().
Changing it works ;)

Yeah, oops.


Remove mantle

In the continuation of https://matrix.org/jira/browse/SYIOS-169, Mantle has been totally removed.
The pro is that we have the best performance.
The con is that we lost nice automatic conversion methods (dictionaryValue, NSCoding, NSCopying). These methods must be now coded by "hand" for each MXJSON derived class.

LGTM - the handling of 'unsigned' key in event description must be clarified with server team.


fix delete in the owncloud storage driver

In the owncloud storage driver when we delete a file we append the deletion time to the file name.
If two fast consecutive deletes happened, the deletion time would be the same and if the two files had the same name we ended up with only one file in the trashbin.
Because of this issue we had inconsistently failing tests in CI.

So maybe this sequence is the problem:
    And user "Alice" has deleted file "/textfile0.txt"
    When user "Alice" restores the file with original path "/textfile0.txt" to "/PARENT/textfile0.txt" using the trashbin API

The 1st step puts a textfile0.txt into the trashbin, with some timestamp.
The 2nd step, in the back-end, first deletes /PARENT/textfile0.txt and that goes in the trashbin as textfile0.txt, with some timestamp (*). The timestamp might be the same as the 1st step.
Then the restore happens. textfile0.txt in the trashbin might be the content from PARENT that was just put into the trashbin. That gets restored, and so effective "nothing happened".
I have a question about (*): when a file is deleted from a folder, I would have guessed that the file would be stored in a matching folder PARENT in the trashbin, to avoid this kind of file name clash, and to easily "guess" where the deleted file originally came from.

I would have guessed that the file would be stored in a matching folder PARENT in the trashbin

AFAIK this only happens if you delete the folder but not if you just delete a file from that folder.

So maybe this sequence is the problem:

And user "Alice" has deleted file "/textfile0.txt"
When user "Alice" restores the file with original path "/textfile0.txt" to "/PARENT/textfile0.txt" using the trashbin API

The 1st step puts a textfile0.txt into the trashbin, with some timestamp.

Yes, it's what triggers the bug but the collision avoidance code in the owncloud driver was wrong anyways. The os.Rename will overwrite an existing file. It won't return the os.ErrExist error.

https://drone.cernbox.cern.ch/cs3org/reva/1946/17/7
runsh: Total unexpected passed scenarios throughout the test run:
apiTrashbin/trashbinRestore.feature:108
apiTrashbin/trashbinRestore.feature:109
apiTrashbin/trashbinRestore.feature:110
apiTrashbin/trashbinRestore.feature:111

That's great - those scenarios were in expected-failures - I suppose they were failing "a lot of the time" before this fix.

@ishank011 @labkode this fixes a timing issue that can cause tests results to be less-predictable. Please review.