[Code Quality] Upgrade Project

Changes:

Upgrades LethalExpansion to use .netstandard 2.1
Changes dll references to be resolved via Paths.props and Dependencies.props

Specifically for @HolographicWings: here is the content to go into Paths.props to make it work as before:
<Project>
  <PropertyGroup>
    <GameAssembliesPath>C:/Program Files (x86)/Steam/steamapps/common/Lethal Company/Lethal Company_Data/Managed</GameAssembliesPath>
    <BepInExCorePath>C:/Users/Holog/AppData/Roaming/r2modmanPlus-local/LethalCompany/profiles/Default/BepInEx/core</BepInExCorePath>
    <LethalSDKPath>D:/Users/Holog/Documents/GitHub/LethalSDK/LethalSDK/bin/$(Configuration)/LethalSDK.dll</LethalSDKPath>
    <MoreCompanyPath>C:/Users/Holog/AppData/Roaming/r2modmanPlus-local/LethalCompany/profiles/Default/BepInEx/plugins/notnotnotswipez-MoreCompany/MoreCompany.dll</MoreCompanyPath>
  </PropertyGroup>
</Project>

Why ?

Its far more maintainable for other contributors, as they don't have to replace all of your references with their own. They just setup a Paths.props file detailed from CONTRIBUTING.md and they are good to go.
As for the .netstandard 2.1 upgrade, all mods should be targeting it as it's best practice.

I wanted .net core originally
Why 2.1 must be targeted ? Except or because it's the version that the game targets

Yes. 2.1 is what the game and Unity targets

Any update on this?

Any update on this?

Any update on this?

not yet, i'll look at it nextly

Ok as it turns out, the PostBuildEvent that copies the dll into that Build directory does not work.

Ok as it turns out, the PostBuildEvent that copies the dll into that Build directory does not work.

It work on my side

Ok as it turns out, the PostBuildEvent that copies the dll into that Build directory does not work.

It work on my side
For now I leave like that
If I begin to work with others peoples I may accept this PR
But not for now

As a result I will hold off on my other pull request then, as it was focused on improving code quality.

As a result I will hold off on my other pull request then, as it was focused on improving code quality.

no problem
i'm looking for active collaborators if you want to help more directly
i did an overdose in december, alone it's exhausting x)

Yeah I was waiting for the pr to be merged as we have access to new csharp language features that will make the code a lot nicer to work with

Yeah I was waiting for the pr to be merged as we have access to new csharp language features that will make the code a lot nicer to work with

I mean to add you as direct collaborator instead of making PRs


Start using fixed seeds for reproducibility

Unfortunately the places where I put the seeds do not suffice. Please help me find other sources of randomness!
It got a lot more stable, but not exactly the same still.

Difference in gamma predictions for two different trainings:

As it turned out, this was also a bug in scikit-learn 0.19.0, which got fixed in 0.19.1


Detekt does not autoformat when using with buildUponDefaultConfig

Expected Behavior
When using autoCorrect = true while having buildUponDefaultConfig = true, it should automatically fix formatting errors.
Observed Behavior
When using detekt with the formatting plugin and configured to autoCorrect = true and buildUponDefaultConfig = true (and an empty config, so basically it uses the default config) it does not automatically fix formatting issues, BUT if I tell detekt to generate the default config (./gradlew detektConfig) and use the generated default config as my config file and disable buildUponDefaultConfig = false it is automatically fixxing any formatting errors.
Steps to Reproduce

Use any empty Android Studio Project
Install detekt with following gradle settings and an empty config file (so it uses the default config file since buildUponDefaultConfig = true)

// Top-level build file where you can add configuration options common to all sub-projects/modules.
buildscript {
    ext.kotlin_version = "1.3.72"
    ext.detekt_version = "1.16.0"
    repositories {
        google()
        jcenter()
    }

    dependencies {
        classpath "com.android.tools.build:gradle:4.1.3"
        classpath "org.jetbrains.kotlin:kotlin-gradle-plugin:$kotlin_version"

        // NOTE: Do not place your application dependencies here; they belong
        // in the individual module build.gradle files
    }
}

plugins {
    id("io.gitlab.arturbosch.detekt").version("$detekt_version")
}

detekt {
    toolVersion = "$detekt_version"
    input = files("$projectDir")
    config = files("$project.projectDir/detekt-config.yml")
    buildUponDefaultConfig = true
    basePath = projectDir

    reports {
        reports {
            html.enabled = true
            xml.enabled = true
            txt.enabled = false
            sarif.enabled = false
        }
    }

    autoCorrect = true
}

dependencies {
    detektPlugins "io.gitlab.arturbosch.detekt:detekt-formatting:1.16.0"
}

allprojects {
    repositories {
        google()
        jcenter()
    }
}

task clean(type: Delete) {
    delete rootProject.buildDir
}

Run ./gradlew detekt
--> Results in errors, that could be auto fixed but don't get auto fixed

Change to buildUponDefaultConfig = true

Copy the default default-detekt-config.yml  into the detekt-config.yml or use ./gradlew detektConfig to generate the Config file from the default

Run ./gradlew detekt again
--> Formatting errors getting auto fixed

Context

Trying to use the autoCorrect feature with the buildUponDefaultConfig feature to have a cleaner version of a detekt-config, where only rules are written that fit our needs.
Your Environment

Version of detekt used: 1.16.0
Version of Gradle used (if applicable):  Gradle Version 6.5 with Android Gradle Plugin Version 4.1.3
Gradle scan link (add --scan option when running the gradle task):
Operating System and version: macOS Big Sur 11.2.3
Link to your project (if it's a public repository): -

Hey @w0rsti,
Sorry that this issue was not triaged 🙏
Do you still face this issue?
Can you try with Detekt 1.17.x and let us know if this is still happening?

Sorry for the late response. 🙏
It would be really great, if you could try to reproduce this issue with the latest detekt version. Please let us know. Thank you very much!

Closing. Don't hestiate to reopen if you can reproduce this issue with 1.17.x


Treat double names as a single name

In Germany, it is quite common to have double names (e.g. first names consisting of two first names). Unfortunately, their use currently leads to garbled output. Here is an example:
friends add friend "Anna-Lena Mustermann"
friends add friend "Lena Test"
friends add activity "went fishing with Anna-Lena"

that last command outputs
Activity added: "2016-01-20: went fishing with Anna-Lena Test Mustermann"

when one would expect something similar to
Activity added: "2016-01-20: went fishing with Anna-Lena Mustermann"

Note the recursive replacement: Anna-Lena turned into Anna-**Lena Test** which turned into **Anna-**Lena Test** Mustermann** in the friends.md database.
This certainly isn't what the user intends. I would suggest to treat en-dashes/minus signs as regular characters which don't indicate a splitting boundary.
p.s.: finally got it working :)

Hey @niklasfi, glad you got it working! Thanks for the bug report; you're right that this is a problem and not at all what's intended. The slight problem is that at least in my own experience it's not uncommon for names to have en dashes/minus signs next to them in normal writing. (As one example, I've seen lots of people use two en dashes, --, to serve as an em dash, particularly with monospaced fonts as in most shell environments.)
I'll think about how best to handle this (maybe longer regexes should always be checked before shorter ones?) and have a fix out as soon as I can (probably in about 24 hours—it would be shorter but this week is somewhat crazy for me at work).
Thanks for spotting this!

This ended up being trickier than I thought, but kind of fun to puzzle through as well. :smiley:

This is fixed in version 0.13, which I just released to RubyGems. Get it with friends update and you should be good to go!


Update README.md to comply with documentation

The main branch in this repository reflects the 0.16 release of twilight, currently available on crates.io as a release candidate. The documentation page is correct for 0.15, and the README here is correct for 0.16. Closing because there is no issue.


[5.7] Enable auto-resolution of command arguments

Passing the command arguments to the call() method enables auto-resolution of named arguments in the handle() command, similar to how route parameters are auto-resolved into Controller methods.
For example:
<?php

namespace App\Console\Commands;

use Illuminate\Console\Command;

class TestCommand extends Command
{
    /**
     * The name and signature of the console command.
     *
     * @var string
     */
    protected $signature = 'test {filename} {count?}';

    ...

    /**
     * Execute the console command.
     *
     * @return mixed
     */
    public function handle(string $filename, int $count = null)
    {
        $this->line($filename);
        $this->line($count);
    }
}

This sounds like something that could use some tests.

I am closing this pull request because it lacks sufficient explanation, tests, or both. It is difficult for us to merge pull requests without these things because the change may introduce breaking changes to the framework.
Feel free to re-submit your change with a thorough explanation of the feature and tests - integration tests are preferred over unit tests. Please include it's benefit to end users; the reasons it does not break any existing features; how it makes building web applications easier, etc.
Thanks!


CSUB-1234: Prepare for more self hosted runners

Description of proposed changes

Practical tips for PR review & merge:

[ ] All GitHub Actions report PASS
[ ] Newly added code/functions have unit tests

[ ] Coverage tools report all newly added lines as covered
[ ] The positive scenario is exercised
[ ] Negative scenarios are exercised, e.g. assert on all possible errors
[ ] Assert on events triggered if applicable
[ ] Assert on changes made to storage if applicable

[ ] Modified behavior/functions - try to make sure above test items are covered
[ ] Integration tests are added if applicable/needed

One successfull execution where everything gets provisioned, executes and then cleans up without issues:
https://github.com/gluwa/creditcoin3/actions/runs/10163068098/job/28109477863?pr=421
will schedule couple more to make sure there are no hidden issues and then we can start merging relevant bits into the public/private repositories.

2nd successfull execution:
https://github.com/gluwa/creditcoin3/actions/runs/10164737279/job/28111667753?pr=421
restarting for the last time!

Run #3 after a rebase shows lots of failures:
https://github.com/gluwa/creditcoin3/actions/runs/10177102896/job/28147819327?pr=421
All of them related to a post action hook (uploading cache) which takes several minutes and gets cancelled b/c the runner gets removed in the mean time.


Improve sparse dataset memory usage for hist tree method.

@hcho3  @RAMitchell
As part of refactoring DMatrix,  I'm trying to profile memory usage issue across XGBoost.  One glaring issue in hist method is that it uses feature index to build the histogram cut matrix.  For dense dataset this is optimal, but for sparse dataset this results in very huge waste of memory.  One particular reproducible dataset would be URL
The linked dataset has total size of 2.2 GB in text form.  After some optimizations and limiting to first 450000 lines of dataset, it still costs 28.6 GB of memory.  Here is a simple report from valgrind:

In some selected rows of above dataset, largest feature index is 3231962, but actual number of none zero columns is just 394.  Is there any way we can compress the histogram cut building into a form that doesn't depend on feature index?

And I need to see if it's possible to do feature grouping before building histogram cut.

When I was working on distributed hist, I f found hist were still built for all features even with col sampling. I thought this is the bottleneck and work on it
At that time, I added something like a featureIdToHistIndex (but I didn’t merge it since I found the real bottleneck is rabit)...is the similar approach enough here?

@CodingCat This is still at quantiles cut building stage.  I'm not sure about hist updater yet.  Your approach is my initial idea.  But maybe there are many other problems that I don't know.  So I figured I should ask for some suggestions here first.

Yes we should definitely look into cut building scalability with number of features. URL is a great test case. I would like to apply what we learn to the GPU algorithms as well.
Regarding training, I believe LightGBM has the concept of a sparse histogram. Another approach that I have seen is to switch to exact style split search when the number of training examples low (e.g. less than the number of features).

I think this is quite related to the problem we tried to solve with @hcho3 in our recent paper on block-distributed GBTs.
Using a sparse histogram representation gave us orders of magnitude improvements in histogram size. We could/should try to find a way for an efficient sparse histogram representation that does works with Rabbit's limitation of knowing the object size in advance.

@thvasilo Interesting.  Will read the paper later.  If there's available experimental source code then maybe I can help. :)

@trivialfis We implemented these algorithms from scratch but leaning heavily on the xgboost codebase. @hcho3 looked into open-sourcing this (work was done at Amazon) but there are some licensing issues there that are holding us back.
I think the important idea to consider is how can we get rid of all the redundant zeros that are currently being communicated in the gradient histograms.
Briefly: XGBoost will create histograms that for each feature will have as many bins as min(numBins, featureUniqueValues). Now for every leaf that has its own partition of data we create and communicate these histograms.
The issue is that as we grow the tree, it becomes more likely that buckets will have a zero value, as each leaf's partition ends up with fewer and fewer data points. Fewer data points -> less unique values to populate the bins.
For a continuous feature that will usually easily cover the say 255 buckets, we will always communicate 255 values, even if only a couple are non-zero. This is because Rabit and MPI require that the size of the objects being communicated to be known in advance. This leads to great amounts of redundant communication and memory use.
Similarly for the feature quantile sketches, we communicate at the beginning of learning their maximum possible size. The reality is that each worker's feature histograms will be much smaller, but because of the practical limitations of Rabit/MPI we need to communicate the max size. In our work we're using the parameter server, where each worker can send objects of arbitrary size and the reduction in communication is even more pronounced:

These types of gains would allow the quantile sketches to be communicated for each leaf, allowing for equivalent accuracy with smaller sketches, as shown in the original XGBoost paper (they call them local vs. global proposals) in Figure 3:

I hope to write a longer paper about these techniques in the future, we can talk with @hcho3 if you're interested in helping out.

@thvasilo Thanks for the explanation.  Will review the paper once #4488 is resolved.  This will greatly improve current histogram method.


DepthwiseConv2D layer

Cannot import DepthwiseConv2D layer in keras?

Upgrading your keras to the latest version will fix this issue

Thanks! It is the problem of keras version.
Thanks for your code sharing, besides I am wondering can the network be implemented to train or predict?
Best,
Yi


Use sync iterator in coro-prime-sieve for Dart

core-prime-sieve/1.dart uses async iteration which has considerable overhead.

Sync generators are not allowed in this problems, plz refer to https://github.com/hanabi1224/Programming-Language-Benchmarks/issues/279#issuecomment-1185155547

Ah, sorry, got it.
Just as a heads-up: In Dart 2.18.0 the async implementation has been rewritten. The sort of code used in coro-prime-sieve essentially is lowered into synchronous code. This leads to stack-overflows for higher n values (>1000).
One way to fix this is to replace yield i; in filter with yield await Future.microtask(() => i);


PSNR:Nan

Excuse me, I referred to the above conversation to modify my code, but still haven't solved the problem of the PSNR value being nan. I think the model still hasn't read the dataset. I would be very grateful if there have any suggestions about my problem.

python main.py --n_GPUs 1 --rgb_range 1 --chunk_size 144 --n_hashes 4 --save_models --lr 1e-4 --decay 200-400-600-800 --epochs 1000 --chop --save_results --n_resblocks 32 --n_feats 256 --res_scale 0.1 --batch_size 16 --model NLSN --scale 2 --patch_size 96 --save NLSN_x2 --data_train DIV2K

Have you solved this problem? I had the same problem


See https://github.com/alphagov/govuk-ruby-images/pull/103.

Thanks! I'll fix up the existing lints (wasn't expecting so many!) and/or the config before merging.


testing tab is not showing all tests collected

Type: Bug

Go to Testing Tab, click Refresh Tests,
It started collecting tests. I can see the tests are being collected in the Output tab
The collecting is completed with ======================= 1731 tests collected in 32.27s ========================

Expected Results:
I should see all 1731 tests in the Testing Tab.
Actual Results:

But in the Testing Tab, it's only showing 5 cases. All these 5 cases are diretcly writing code in the test methods.

All other cases will read data from a corresponding .yml file into the test code. And they are not showing in the Testing Tab.

It was working fine with previous version of VS Code.
 Thanks so much for the report! What plugins are you using for pytest? Sometimes these are not compatible with our plugin which handles building the test tree for the test explorer view. If you send over the plugins you use and a test which isn't appearing in the sidebar I can give it a try on my machine and see where it is not being interpreted correctly. Thanks!

@eleanorjboyd Thanks for your reply. This is the list of pytest plugins specified in my requirements.txt file:
pytest==6.2.5
pytest-assume==2.4.3
pytest-azurepipelines==1.0.4
pytest-forked==1.4.0
pytest-xdist==2.5.0
PyYAML==6.0
requests==2.27.1
If you need the complete requirements.txt, let me know. Thanks in advance.

With suggestions by @eleanorjboyd, I updated my pytest plugin to latest version and now the test tree is displaying all tests. Thanks a bunch for all your help.

Great stuff! Thanks for the follow up. Happy coding 🥳


removing square brackets from data testing function instruction

with square brackets, we get following error:
'take' operator: Failed to resolve table or scalar expression named '["Authentication"]'

#sign-off


Worthwhile reports Z3 timeout although Z3 is still running

Steps to reproduce:

Set Z3 timeout for the WW-project to 60s
Try to prove the following program correct:

Integer x
Integer y
Integer z := 0
Integer oldX := x
Integer oldY := y

while (y != 0)
  _invariant y >= 0 && oldX * oldY = x * y + z
{
      if (y / 2 * 2 != y) {
          z := x + z
          y := y / 2
          x := 2 * x
      }

      if (y / 2 * 2 = y) {
          y := y / 2
          x := 2 * x
      }
}
_assert z = oldX * oldY

WW immediately reports that Z3 has reached the timeout but Z3 is still running in the background.

This does not work when calling Z3 via a shell script. I have the following shell script called z3 (to be able to simulate timeouts):
#!/bin/bash
#  sleep 10
./z3bin $*

When a timeout occurs, the Z3 binary is not killed. It works when running z3 directly without the shell script in between.

I have no idea what to do there and I consider it minor enough to not work on for now.

Since z3bin is executed as the shell's child and destroy() does not ask, that is send some signal that could be handled, the Process to exit the shell cannot terminate its child process and z3bin is still running after Worthwhile has called destroy() on the shell's Process object. I agree with @leonhandreke that doing things like deciding which operating system Worthwhile is running on (for how to do the following), getting the shell's pid and killing it is "not work for now".


Numbers in json not working

Unless I wrap them in quotation marks

I have the same issue, it the text is empty when it's a number in Json

The issue should now be fixed. Let us know if it works for you.

thanks @lukasondrej!

Thanks @lukasondrej , now it working great!


Geocoder tool

Client wants a simple address-search tool, which zooms the map and that's it.
Chris had some good work on something even more complex https://github.com/GreenInfo-Network/nyc-crash-mapper/pull/81 This would do the geocode, then apply a filter to find crashes within a circle of that address. This need is significantly simpler, but the code in PR 81 may provide guidance as to UI and behavior.

@gregallensworth just FYI I was using Google Map's Geocoder and from what I hear their APIs are no longer "free" and require an API Key from what I understand, but yes I believe the React Redux integration should be a good starting point. Maybe a good alternative Geocoder would be Mapbox's? But not sure if that means you have to also use a Mapbox Basemap...
FYI the NYC Planning Dept has it's own free geocoder, and the team at NYC Planning Labs has built an service for it that has auto-complete: http://geosearch-docs.planninglabs.nyc/
This last option might be worth using as certain NYC addresses are notoriously difficult to geocode, e.g. places in Queens that have 4 streets in the same 1 block radius that share the same name but differ in their suffix.

Yeah, the Google changeup is significant, for a large number of people. Our usual go-to when not using Google is Bing, as their TOU are very open: "must be used in a web map"
But, that's really good information that there exists a NYC-specific geocoder. Thank you for the tip here.

No problem, I went ahead and integrated it with an auto-suggest component in the branch clh/geocoding. It's data is stored in the redux state.search. The saved search result just needs to be piped down to the map component. Some more css & ux tweaking is probably warranted as well.

Update: over the weekend I got the selected geocode result to display on the map. We could either leave it at that or add the ability to filter by radius to the geocode result. I started working on the latter, probably won't be too much effort.


Error using @ionic/core in another Stencil app

I'm submitting a ...  (check one with "x")
[ x ] bug report
Current behavior:
npm run dev in the stencil app throws these 2 errors (2 files are missing in the build/npm repo):
[ ERROR ]  ENOENT: no such file or directory, stat<EMAIL_ADDRESS>
[ ERROR ]  ENOENT: no such file or directory, stat<EMAIL_ADDRESS>
Adding empty files is enough to make it "work".
Expected behavior:
Dev build starts without error / missing files.
Steps to reproduce:

npm install @ionic/core
Add @ionic/core to stencil.config.ts in the collections property
npm run dev

Related code:
exports.config = {
  collections: [
    {
      name: "@stencil/router"
    },
    {
      name: "@stencil/redux"
    },
    {
      name: "@case-os/ui-kit" // This is the NPM package name of the lib!
    },
    {
      name: "@ionic/core"
    }
  ]
};

Confirmed in the IonicHN demo too. After fixed the error clear to fill='clear'.

Hey @snowyu, I don't understand. How did you fix it? Thanks!

this error happens without use clear @snowyu - i am not using clear or fill='clear'

@bitflower what version of @ionic/core are you running?

@jgw96 these:
  "dependencies": {
    "@ionic/core": "0.0.2-30",
    "@stencil/core": "^0.3.0-5"
  }

@bitflower can you update to<EMAIL_ADDRESS>please?

@jgw96  This error disappeared after updated to<EMAIL_ADDRESS>but the new error coming on the official IonicHN demo:
... Uhoh. Got error write EPIPE ...
Error: write EPIPE
    at _errnoException (util.js:1022:11)
    at WriteWrap.afterWrite [as oncomplete] (net.js:867:14)

Hey @jgw96 it worked! Thanks! Gotta stay up to date....
Not sure about closing. @snowyu's problem seems to be another one....

Thanks @bitflower ! Glad the latest fixed your issue (: @snowyu that looks like a separate issue, mind opening an issue on that here https://github.com/ionic-team/stencil ?


Adjust to RTC Engine API improvements

@mickel8, what is the status of this PR? Is it ready for review? We have merged PR for the RTC engine already.


Grammar mistake

changed "provides an FAQ" to "provides a FAQ"

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)
[x] My pull request targets the master branch of freeCodeCamp.
[x] None of my changes are plagiarized from another source without proper attribution.
[x] My article does not contain shortened URLs or affiliate links.

If your pull request closes a GitHub issue, replace the XXXXX below with the issue number.
Closes #XXXXX

Thank you for your contribution.


warning: could not update mtime for file

nix-doom-emacs-unstraightened causes nixos-rebuild to spew out about a thousand warnings that look like htis:
warning: could not update mtime for file '/root/.cache/nix/gitv3/1046h8msjsqdw1zsrbsza1c6q10hllxgy9hh76hyklfl0kc6s0f2/refs/heads/HEAD': No such file or directory
warning: could not update mtime for file '/root/.cache/nix/gitv3/1qzhy9ay3vh6696wn8xyyaz9lh6p8j9s9in1ggp2z0c0qv94w6s1/refs/heads/HEAD': No such file or directory

I'm not sure what's gonig on here—is nix-doom-emacs-unstraightened looking for cache files that don't exist on my systems (or other systems)?

I think these are a side effect of 2f89220bdcbf8118db82753672684d8e27d4fc4c. They should be safe to ignore (Nix seems to be attempting to mark the cache as fresh for something it doesn't actually cache). But if you see them on every build (not just the first one) and/or builds after the first one are slow it's possible my workaround for one caching issue is causing another caching issue...
Which version of Nix are you seeing this with?
Is rerunning nixos-rebuild reasonably fast? (Without working around that caching issue it can take minutes...)?
If this is "just" noise then I apologize but I don't know how to silence it (until https://github.com/NixOS/nix/issues/10773 is fixed upstream at which point I'll drop my workaround).

(I've dropped the workaround, at least temporarily, see #14. So you should not currently be seeing these messages. I may reinstate the workaround later depending on where #14 goes.)


update master protection workflow to latest version

Fix the failing PR to master workflow

LGTM, but we test it again...


feat: Support selecting specific token indices when applying and training steering vector

This PR adds support for selecting specific token indices when applying a steering vector, and for training steering vectors at different token indices for different prompts.
Steering at specific indices
A token_indices parameter was added to the apply and patch_activations methods of steering_vector. This lets the user select specific token indices at which a steering vector should be applied. token_indices can be either:

a list or list slice of integers, containing the indices at which to apply steering.
a tensor mask of 0s and 1s, where 1s denote the positions at which to apply steering.

The min_token_index parameter for apply and patch_activations is still supported. Passing min_token_index=n is equivalent to passing token_indices=slice(n,None)
Example
# the following will apply the steering vector at token indices 2, 4, and 7
target_token_indices = [2, 4, 7]
steering_vector.patch_activations(model, token_indices=target_token_indices)

# equivalently, token_indices can be a mask
target_token_indices = torch.tensor([1 if i in [2, 4, 7] else 0 for i in range(input_length)]
steering_vector.patch_activations(model, token_indices=target_token_indices)

Training at different indices for different prompts
Note: Updated on Feb 1st 2024
There are two ways of passing custom indices to train_steering_vector.

Via training data: SteeringVectorTrainingSample now optionally takes a read_positive_token_index and read_negative_token_index. The training_data argument of train_steering_vector can now also be a 4-tuple, with the last two values being the index of the positive and negative example respectively.
Via the token index argument: The read_token_index argument can now be a callable, mapping prompts to indices. It can still be an int, and by default will still be -1.

Example using training data
def get_x_index(prompt: str) -> int:
        tokenization = tokenizer.convert_ids_to_tokens(tokenizer.encode(prompt))
        return tokenization.index("ĠX")

training_data = [
        (
            "This is a short positive example. X <- probe here.",
            "This is a short negative example with different token length. X <- probe here.",
            get_x_index("This is a short positive example. X <- probe here."),
            get_x_index(
                "This is a short negative example with different token length. X <- probe here."
            ),
        ),
        (
            "Dummy text. This is a much longer positive example. X <- probe here. More dummy text.",
            "Dummy text. This is a much longer negative example with different token length. X <- probe here. More dummy text.",
            get_x_index(
                "Dummy text. This is a much longer positive example. X <- probe here. More dummy text."
            ),
            get_x_index(
                "Dummy text. This is a much longer negative example with different token length. X <- probe here. More dummy text."
            ),
        ),
    ]

steering_vector = train_steering_vector(
        model, tokenizer, training_data, layers=[2, 3, 4]
)

Example using read_token_index data
def get_x_index(prompt: str) -> int:
        tokenization = tokenizer.convert_ids_to_tokens(tokenizer.encode(prompt))
        return tokenization.index("ĠX")

training_data = [
        (
            "This is a short positive example. X <- probe here.",
            "This is a short negative example with different token length. X <- probe here.",
        ),
        (
            "Dummy text. This is a much longer positive example. X <- probe here. More dummy text.",
            "Dummy text. This is a much longer negative example with different token length. X <- probe here. More dummy text.",
        ),
    ]

# note how the get_x_index function is passed to train_steering_vector
steering_vector = train_steering_vector(
        model, tokenizer, training_data, layers=[2, 3, 4], read_token_index=get_x_index
)

Awesome work @Felhof!


fix(snapshot): listsnapshot show zero result when replica is deleted

ListSnapshot response no result, in following scenario

Replica has a single snapshot
replica is deleted

ListSnapshot will show 0 result as part of all snapshot query

bors try

I've pruned the network..
bors try


AccessPolicy "writeable" fields, vs. "readonly"

User Driven: https://discord.com/channels/905144809105260605/1133436813869064202
This should be part of a broader conversation on the next iteration of AccessPolicies.
There are cases when users want to lock down almost every field, except for a few status fields.
In this case, the user wants to lock down all fields on ServiceRequest except for ServiceRequest.note.

@rahul1 @mattwiller
Counter proposal...
Rather than adding "writeable", we deprecate "readonly", and move to "supported interactions".
It would be an array of FHIR interactions and operations: https://hl7.org/fhir/R4/http.html

Instance Level Interactions

read	Read the current state of the resource
vread	Read the state of a specific version of the resource
update	Update an existing resource by its id (or create it if it is new)
patch	Update an existing resource by posting a set of changes to it
delete	Delete a resource
history	Retrieve the change history for a particular resource

Type Level Interactions

create	Create a new resource with a server assigned id
search	Search the resource type based on some filter criteria
history	Retrieve the change history for a particular resource type

Whole System Interactions

capabilities	Get a capability statement for the system
batch/transaction	Update, create or delete a set of resources in a single interaction
history	Retrieve the change history for all resources
search	Search across all resource types based on some filter criteria

For example:
// full access (default)
['*'],

// readonly
['read'],

// readonly with history
['read', 'vread', 'history'],

// read with history and search
['read', 'vread', 'history', 'search'],

Is that too granular?  Would it be too annoying to list out all operations like that?
Or maybe "operations" should be separate?
That is the terminology that we use in our Subscription extension "supported interactions": https://www.medplum.com/docs/subscriptions/subscription-extensions#interactions
That was inspired by CapabilityStatement.rest.resource.interaction:

https://hl7.org/fhir/R4/capabilitystatement-definitions.html#CapabilityStatement.rest.resource.interaction
https://hl7.org/fhir/R4/valueset-type-restful-interaction.html

Or, as @mattwiller suggested, we could align with SMART scopes:

https://www.hl7.org/fhir/smart-app-launch/scopes-and-launch-context.html

We define permissions to support the following FHIR REST API interactions:

c for create

Type level create

r for read

Instance level read
Instance level vread
Instance level history

u for update

Instance level update Note that some servers allow for an update operation to create a new instance, and this is allowed by the update scope
Instance level patch

d for delete

Instance level delete

s for search

Type level search
Type level history
System level search
System level history

The main limitation here is that it does not include anything about FHIR operations.  When performing a FHIR Operation, we use the current user's permissions, so we could always defer at that level too.

Between those options, I would actually prefer aligning to the full set of RESTful interactions codes rather than SMART scopes, since the latter are more subject to change and should map down to the supported operations anyways.  The granularity of the operations feels pretty good to me, and I believe it will be critical to have a clear distinction between a user's inherent permissions (i.e. what they are allowed to do per access policies in a given context) and scopes (what a given token is permitted to do on behalf of a user)

Summary of our discussion offline:

fieldRules: [{path: 'status', action: read | write | hidden}]
For a given field, find the first rule in the that matches
Final rule should be `{path: '*', action: read | write | hidden}
TBD what happens if users omit this rule


We should switch to more standard naming conventions when working with chain names

The issue
Currently, across our SDKs and libraries, we reference the following chain specifiers:

ethereum
optimism
arbitrum
polygon
ethereum-goerli
optimism-goerli
arbitrum-goerli
polygon-mumbai
optimism-goerli-staging
localhost

However, these specifiers are specific to Tableland. For instance, ethersjs (and https://chainlist.org) use the following equivalent set:

mainnet (alias homestead)
optimism
arbitrum
matic
goerli
optimism-goerli
arbitrum-goerli
maticmum
optimism-goerli (with our own staging suffix?)

For localhost, I think hardhat has a convention here, and I think perhaps @joewagner also had an opinion on this one?
Describe the solution you'd like
It would be useful to adopt the above naming conventions in this repo, and in our SDK and CLI tooling, so that a) it is easier for devs to cross over when dealing with chains and networks, and b) so that our code is more directly compatible with ethers and other projects.
Describe alternatives you've considered
At the moment, supporting our own naming conventions require a mapping in the SDK or CLI from Tableland names to external names. This isn't the end of the world, but it does mean that we end up duplicating names across places, rather than having a single source of truth that we can just use "as is".

cc @sanderpick @brunocalza @dtbuchholz @joewagner

Looked at the implications of this today, and I like your suggestions.  The hardhat localhost convention works well with the newest version of local-tableland.
There is an issue with having multiple registries on the same chain, but adding -staging, -dev, etc... solves that problem nicely imo.

Hey @joewagner , do you think we could get this plus the update from testnet to testnets in for the network separation work this milestone? Do you have some time for this update? Perhaps we can publish it under a "next" or "dev" tag?

@carsonfarmer RE: naming conventions.
Last week I was working through building tests for hardhat projects, and @asutula has been building a local-tableland hardhat extension. There's been a need to distinguish between localhost and local-tableland.  This is because if hardhat is run with the network is equal to localhost Hardhat will be expecting a standalone hardhat node to already be running.
@asutula might have more to say here, but I believe that if we want to enable a hardhat plugin that sets up and runs local-tableland internally we have to support a name other than localhost
Maybe we can support both, and document the differences?

In my hardhat plugin, I'm leveraging a new/unique network name local-tableland. It is functionally the same as localhost but used by the plugin to distinguish between the user's intent to run hardhat tasks in the traditional/unmodified localhost mode vs the plugin's magic of running local-tableland mode instead. So, yes I think it would be nice to support local-tableland as a network in the SDK.

In that case, will the hardhat network that is running still be running at the same default port etc? As in, is there a world in which both a hardhat plugin (raw) and a hardhat plugin (tableland) will be running at the same time on different ports?

In that case, will the hardhat network that is running still be running at the same default port etc? As in, is there a world in which both a hardhat plugin (raw) and a hardhat plugin (tableland) will be running at the same time on different ports?

I can't think of a reason to do that.

Cool, then I think from the SDK's perspective, both scenarios are the same, and they are just "localhost". In both cases, it'll target 8080 for the API, and whatever the default hardhat JSON RPC API port is.

Yea, the settings for localhost and local-tableland should be exactly the same. The only distinction is external to the sdk, and only to determine correct intent/behavior around running local tableland or plain hardhat.

Peeerfect


feat: Additional diagnostics

Check on these and add when possible

OS version
Kernel version
Driver version
Docker version (only if docker is chosen)
GPU version
Root user us normal user
Network connectivity issue or firewall issue?
Storage Space
Secure boot on/off

All except secure boot detection implemented.
Secure boot detection requires a various array of additional software and root to run.


[fix][sec] Upgrade sqlite-jdbc to resolve CVE-2023-32697

Motivation
Error:  Failed to execute goal org.owasp:dependency-check-maven:8.1.2:aggregate (default) on project pulsar:
Error:
Error:  One or more dependencies were identified with vulnerabilities that have a CVSS score greater than or equal to '7.0':
Error:
Error:  sqlite-jdbc-<IP_ADDRESS>.jar: CVE-2023-32697(8.8)

Modifications
Upgrade sqlite-jdbc
Documentation

[ ] doc
[ ] doc-required
[x] doc-not-needed
[ ] doc-complete

Codecov Report

Merging #20411 (e5c526c) into master (f0e97f4) will increase coverage by 0.41%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master   #20411      +/-   ##
============================================
+ Coverage     72.45%   72.86%   +0.41%
+ Complexity    31898    31770     -128
============================================
  Files          1852     1864      +12
  Lines        138227   138416     +189
  Branches      15175    15188      +13
============================================
+ Hits         100150   100858     +708
+ Misses        30098    29538     -560
- Partials       7979     8020      +41

Flag
Coverage Δ

inttests
24.15% <ø> (-0.02%)
:arrow_down:

systests
24.90% <ø> (?)

unittests
72.16% <ø> (-0.05%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.
see 159 files with indirect coverage changes


RF <IP_ADDRESS> Documentation : GettingStartedGuide.md

To raise a new Pull Request, the following prerequisites need to be met. Please tick before proceeding:
-[x] a Github Issue was opened for this feature / bug.
-[ ] test coverage was added .
This addresses Issue https://github.com/hyperledgerkochi/KOBman/issues/39
Hi @asa1997 ,
As requested changes has been incorporated,please review and give LGTM comment if this is fine

@asa1997 ,
Closing the pull req for minor edits


Please provide TLS/SSL download option

Hello,
I noticed you are only supporting HTTP downloads.
re:
wget -c http://static.phpmd.org/php/latest/phpmd.phar
Would like to see this under https / TLS.
thanks,
nickg

All the phpmd.org and static.phpmd.org traffic should now go through HTTPS.

This made my project's Travis build fail.
$ wget -c http://static.phpmd.org/php/latest/phpmd.phar
--2016-03-04 08:28:14--  http://static.phpmd.org/php/latest/phpmd.phar
Resolving static.phpmd.org (static.phpmd.org)... <IP_ADDRESS>
Connecting to static.phpmd.org (static.phpmd.org)|<IP_ADDRESS>|:80... connected.
HTTP request sent, awaiting response... 301 Moved Permanently
Location: https://static.phpmd.org/php/latest/phpmd.phar [following]
--2016-03-04 08:28:14--  https://static.phpmd.org/php/latest/phpmd.phar
Connecting to static.phpmd.org (static.phpmd.org)|<IP_ADDRESS>|:443... connected.
ERROR: cannot verify static.phpmd.org's certificate, issued by `/C=DE/ST=NRW/L=Witten/O=Internet Widgits Pty<EMAIL_ADDRESS>  Self-signed certificate encountered.
    ERROR: certificate common name `*.ruhrtal.net' doesn't match requested host name `static.phpmd.org'.
To connect to static.phpmd.org insecurely, use `--no-check-certificate'.
The command "wget -c http://static.phpmd.org/php/latest/phpmd.phar" failed and exited with 5 during .

Fixed it by adding --no-check-certificate.
$ wget --no-check-certificate -c https://static.phpmd.org/php/latest/phpmd.phar

@manuelpichler How about using a Let's Encrypt cert? I have no experience with installing it on a dedicated server or whatever you use for phpmd.org, but on our shared hosting partner's cPanel it is a breeze.

@ravage84 it is a Let's Encrypt certificate.

@ravage84 it is a Let's Encrypt certificate
Btw. the organisation mentionend in the output Internet Widgits Pty Ltd was never-ever used by me. It seems here something totally different was/is broken, se here https://supportforums.cisco.com/discussion/12580191/malware-other-self-signed-ssl-certificate-only-allow-source-or-destination

Yeah, I guess the problem is Travis'side.
Probably their ISP uses some caching (which would make sense as they often fetch the same stuff). That caching server might have returned a self-signed cert...


Add a business_as_usual phase to the Cycle switcher

Context
We want to keep sandbox open right up until the start of the next cycle. Using the existing today_is_mid_cycle setting will result in providers thinking they won't be able to submit applications tomorrow... but tomorrow will never come. This will mean support queries, which we don't want.
Changes proposed in this pull request
Add a new today_is_business_as_usual phase to the switcher, which keeps the cycle open but doesn't show the banners.

the timing 😂


Duplicate function

To Reproduce
Steps to reproduce the behavior:

Create a function
Right click and duplicate
Try to change the name of the second function
See error

@shakao  we could just revert the duplicate feature in stable and remove the next-release tag here. And take our time to fix the issue. Let me know if you prefer that.

fixed


Untimely retry on repeated sending of a command associated with a custom cluster (TZ-1085)

Question
Hello,
I am trying to build a remote system with a remote and a receiver (both esp32-C6 or H2).
On this system, for safety reasons, the user has to press a button while he wants the receiver to drive a motor (for now it's just a simple LED). When he stops pressing the button, the motor has to stops within 300ms (timeout).
In order to achieve such a behaviour, i implemented a custom cluster (I'm not sure if this is even the best method though) from which i send every 100ms a custom command telling the receiver to keep the motor ON.
When its done i can send a 2nd command or just wait for the timeout to to stop it.
However, at that pace, it seems that sometimes a message may not be received or acknoledged. This ends in the command being sent again while the LED is supposed to be OFF and the LED starts for a short time to turn ON until next timeout.
I searched for a way to fix this behavior, but neither of the ZBOSS defines i could find and changed solved my issue.
What is the reason behind this behavior? Is the timing (100ms) too short to send such short commands? Is this even the right way to build my system or is there any other API i missed while searching?
Thanks a lot for the help you could provide.
Additional context.
No response

@Matthieu-Poulain,
To reproduce your issue, I created an example based on your description, which is attached. It works as expected on two ESP32H2 chip, their distance is about 50 cm.
We can discuss the issue based on this patch.
0001-test-send-frame-in-100ms-interval.zip

@Matthieu-Poulain,
To reproduce your issue, I created an example based on your description, which is attached. It works as expected on two ESP32H2 chip, their distance is about 50 cm.
We can discuss the issue based on this patch based on esp-zigbee-sdk (537b9aa) . 0001-test-send-frame-in-100ms-interval.zip

Hello,
I feel like an idiot...
I put a debug output to print the received command counter inside the receive handler function... Removing it seems to allow the proper working of the receiver. I really must be more careful with printf & ESP_LOGx functions...
Thanks a lot for your help


dropdownfield crash/freeze on large list

my client has a dropdownfield on a has_one relationship. they have added well over 2,000 items to the source array. when they try to use the dropdown, it crashes/freezes the browser.
SS framework 3.5

If you've scaffolded this field through DBForeignKey->scaffoldFormField(), it won't use a DropdownField for any lists with more than a hundred entries: https://github.com/silverstripe/silverstripe-framework/blob/master/src/ORM/FieldType/DBForeignKey.php#L64
If you have that many elements, a dropdownfield isn't a good idea, and you should use third party solutions like http://addons.silverstripe.org/add-ons/briceburg/silverstripe-pickerfield or http://addons.silverstripe.org/add-ons/sheadawson/silverstripe-select2


Profiler and Benchmark

This PR

introduces a profiler TritonProfiler to help track down performance bottlenecks
introduces a benchmark using criterion
factors out common helper functions in test cases and benchmark

Todos:

[x] write profiler
[x] factor out common procedures from test cases
[x] integrate profiler into prove
[x] integrate profiler into verify
[x] remove TimingReporter
[ ] take averages of multiple runs in profiler

This PR is ready for review. The remaining issue

[ ]  take averages of multiple runs in profiler

Is a nice-to-have but should not take up priority time. Therefore, I am moving it to an issue.


Linebreak introduces blanks

HTML source:
This is an example
';

Expected output:
This is an example\n![](logo.gif)

Actual output:
This is an example  \n![](logo.gif)

The actual output seems more correct. A BR in markdown is two spaces followed by a new line.


Using multiple discrete functions with TMOP for adaptivity

This PR will allow us to specify multiple discrete functions for r-adaptivity with TMOP.
Below is an example where we start with an indicator function and use it to derive discrete functions for size and aspect-ratio. The optimized mesh is obtained using the FD-based approach for TMOP.

PR
Author
Editor
Reviewers
Assignment
Approval
Merge

#1352
@kmittal2
@v-dobrev
@vladotomov + @v-dobrev
04/06/20
⌛due 04/20/20
⌛due 04/27/20

LGTM

@kmittal2, can you resolve the conflicts by merging master here?
Also, it will be good to mention this new capability in the CHANGELOG.

@kmittal2, can you resolve the conflicts by merging master here?
Also, it will be good to mention this new capability in the CHANGELOG.

Done.

Merged in next for testing...


[R-package] [ci] Add a CI job testing the R package with rchk

Summary
A continuous integration (CI) job should be added which tests the R package with rchk.
From that project's description,

This project consists of several bug-finding tools that look for memory protection errors in C source code using R API, that is in the source code of R itself and packages. The tools perform whole-program static analysis on LLVM bitcode and run on Linux.

Motivation
rchk can automatically find issues in C/C++ code used in an R package. Adding a CI job in this repository which runs rchk should provide higher confidence in releases and aid maintainers in catching user-facing issues before they make it into releases.
For example, I found that rchk run on the most recent CRAN release (3.2.1) would have caught the bug that led to #4045 (fixed in #4155).

ERROR: initialization function R_init_lightgbm(_DllInfo*) in C++ will not be used by R

Following the instructions at https://github.com/kalibera/rchk/blob/master/doc/DOCKER.md#checking-a-package-from-a-tarball to check the latest version of {lightgbm} on CRAN.
wget https://cran.r-project.org/src/contrib/lightgbm_3.2.1.tar.gz
mkdir packages
cp lightgbm_3.2.1.tar.gz packages
docker run -v `pwd`/packages:/rchk/packages kalibera/rchk:latest /rchk/packages/lightgbm_3.2.1.tar.gz

Results in logs that end as follows.
Installed libraries of package  lightgbm
[1] "/rchk/packages/libsonly/lightgbm/libs/lightgbm.so"

Library name (usually package name): lightgbm
ERROR: initialization function R_init_lightgbm(_DllInfo*) in C++ will not be used by R
ERROR: did not find initialization function R_init_lightgbm
ERROR: too many states (abstraction error?) in function strptime_internal
Analyzed 39643 functions, traversed 106572 states.

Rchk version: 3d653b7c8f92dac912532856b55f44d2986c6553
R version: 79889/R Under development (unstable) (2021-01-27 r79889)
LLVM version: 10.0.0

Description
If this job can be run on CI in less than 20 minutes, I think it should be included in the standard R checks run on every commit (https://github.com/microsoft/LightGBM/blob/47208894d819f1b8cef193e71f78e9a8c2f38462/.github/workflows/r_package.yml).
If not, it should be added as a standalone job that can be triggered by a comment like /gha run r-rchk. See https://github.com/microsoft/LightGBM/blob/47208894d819f1b8cef193e71f78e9a8c2f38462/.github/workflows/r_valgrind.yml for an example.
NOTE: when implementing this, the error too many states (abstraction error) in strptime_internal can safely be ignored. See https://github.com/kalibera/rchk/issues/22#issuecomment-656036156.
References
Many thanks to @fabsig for bringing this up in #4390.
See https://github.com/microsoft/LightGBM/issues/4390#issuecomment-866527566 for some details on the current state of this tool's output against master of LightGBM.

Per our policy in this project, I've added this feature request to #2302. Anyone is welcome to contribute this feature! If you'd like to contribute, say so in a comment here and this can be re-opened.

re-opening this as I am actively working on it.


MacOS error while starting the Blazor.Server-Project

I am using Visual Studio 2019 for MacOS and just followed the getting started section of the readme. Creating a project and trying to debug without doing any changes to it.
Selecting Blazor.Server project and debugging gave me couple of errors and the website was only on "Loading..." .
Inspecting it in the Browser gave me these errors:
[2020-06-24T21:47:46.294Z] Error: There was an unhandled exception on the current circuit, so this circuit will be terminated. For more details turn on detailed exceptions by setting 'DetailedErrors: true' in 'appSettings.Development.json' or set 'CircuitOptions.DetailedErrors'.

The package manager integrated in Visual Studio gave me  these errors:
Microsoft.JSInterop.JSException: Could not find 'BlazorXamarin' in 'window'.
Error: Could not find 'BlazorXamarin' in 'window'.
    at http://localhost:5080/_framework/blazor.server.js:8:30748
    at Array.forEach (<anonymous>)
    at p (http://localhost:5080/_framework/blazor.server.js:8:30709)
    at http://localhost:5080/_framework/blazor.server.js:8:31416
    at new Promise (<anonymous>)
    at e.beginInvokeJSFromDotNet (http://localhost:5080/_framework/blazor.server.js:8:31390)
    at http://localhost:5080/_framework/blazor.server.js:1:19202
    at Array.forEach (<anonymous>)
    at e.invokeClientMethod (http://localhost:5080/_framework/blazor.server.js:1:19173)
    at e.processIncomingData (http://localhost:5080/_framework/blazor.server.js:1:17165)
   at Microsoft.JSInterop.JSRuntime.InvokeWithDefaultCancellation[T](String identifier, Object[] args)
   at Microsoft.JSInterop.JSRuntimeExtensions.InvokeVoidAsync(IJSRuntime jsRuntime, String identifier, Object[] args)
   at BlazorMobile.Common.Components.BlazorMobileComponent.SetRemoteDebugEndpoint()
   at BlazorMobile.Common.Components.BlazorMobileComponent.OnAfterRenderAsync(Boolean firstRender)
   at Microsoft.AspNetCore.Components.RenderTree.Renderer.GetErrorHandledTask(Task taskToHandle)
The thread 1421905 has exited with code 0 (0x0).

I don't actually know what the problem is. I have updated the xamarin forms too.
I was trying to work with the iOS project. I am using xcode-simulator as debugging option for that and therefore I tried to debug the Server to get it running.

BlazorMobile default deployment has never been tested on MacOS.
I can't guarantee for now that all the pipeline is working as expected.
There is some events that should be done at build time, same, i never tested on it.
For the BlazorXamarin error, can you double check that your project is loading blazormobile.js in your index.html file ?
Also i think your first reported error is just a consequence of the second one you mentionned, as an exception has been thrown during the initial rendering.
Otherwise, keep in mind that the iOS deployment will not work on the simulator (at least the Web part, native is ok) because Apple decided to not support WebAssembly inside the iOS Simulator. So yes, if you don't have any Apple device, you can at least test the remote debugging functionnality with Server mode on MacOS and Native in the simulator.
I will try to do some test on my Mac tomorrow to see why it doesn't work by default.

Yes, BlazorMobile work with iOS, Android, UWP and with Electron for Desktop.
Using simulator doesn't work only for iOS.
So it works fine with Android, with a real device or a simulator.
I'm unable to reproduce your error even with a freshly created project.
Your main issue here is that it seem that the program doesn't find the Razor Class Library needed that reference the javascript file.
Can you check this:

That TestProject.Blazor.Server reference the BlazorMobile.Web package
That .NET Core 3.1.400-preview-015151 is installed on your machine
On my machine i have also .NET Core 5.0.100-preview.2.20176.6 installed, but i think it's a version installed by my current VS2019 Preview (16.7.0 Preview 2.0).
Preferably test this on Windows and with VS2019 Preview instead.
Additionnaly can you just tell me if the default Android project app run fine ?
Does starting the TestProject.Blazor project alone in Debug does works ? I mean that blazormobile.js does exist at boot and that the default app page start, even if we are not connecting it yet to a native end.

Hello, thank you again, I did the following steps, and here are the results:

Yes, the project reference to BlazorMoblie.Web is in the TestProject.Blazor.Server.
I had .NET Core 3.1.301 . Now updated to the .NET Core 5.0.100-preview.2.20176.6.
Tested on MacOS so far and it doesn't work. Also it doesn't work on Windows.
Look at this, I just recorded it : https://www.youtube.com/watch?v=JYOFAEhKEFk
The android project runs fine. All pages are working (Home Page, BlazorMobile Page, Count Page and FetchData Page).
Loook at this, I just recorded it also: https://www.youtube.com/watch?v=IsForYB_-4I
Yes the Testproject.Blazor runs only the BlazorMobile Page isn't not working in the Web.

Good !
Ok
Thanks for the video
Cool, so the issue with Razor Class Library is only related to the Server project. The WebAssembly project does publish then package all the required content, and as it's working in Android, this mean that the publish pipeline is ok on this side ! While using the Server for debugging, Visual Studio should soft link the referenced class library, as Razor Class Library are not published while doing debugging session, and it's by design. But for whatever reason it doesn't work on your machine. Does your current username folder have a space in it ? I mean, if you open %appdata% folder on Windows, does parent folder with your username with a space ?
It's expected that it doesn't work on the BlazorMobile page as the button open a Native dialog, and you are debugging in the browser. For make it working, you would have to launch your Native app on one side, and this project on the other side, and configure properly the IP and Port for remote debugging. Then clicking on the button would open the Native dialog in the native app, even if you clicked in the button from your browser. Read the documentation about the Remote debugging purpose.

In the end i think it's more about a Razor Class Library functionnality bug.
Are you using VS2019 or VS2019 Preview actually ?
You can find more informations about RCL issue here:
https://stackoverflow.com/questions/60040793/404-with-static-content-in-razor-class-library-rcl
https://github.com/dotnet/aspnetcore/issues/14562
One "dirty" quick workaround for now if you want to test and fix this issue later, would be to:

Open %userprofile%.nuget\packages\blazormobile.web\3.2.8\staticwebassets folder
Copy the blazormobile.js file to your TestProject.Blazor project, in wwwroot
Reference it directly instead of the RCL reference you have in index.html

But beware, by doing this, the file will not be automatically synchronized if some changes are done in the future in the plugin, as you will reference your own version of the file.
This workaround is mainly for you to test.
Oddly, i don't have any issue on my side with the same scenario and project name.

I am using on Mac Visual Studio 2019 Community and on Windows Visual Studio 2019 Enterprise.
Both had the same .net core sdk's. Yes on Windows I have spaces in the name, does this occur some problems?
Is it possible to add in an already existing Blazor WebAssembly the BlazorMobile? I mean like the additional Xamarin.Forms and add the NuGet-Packages to these also on the Blazor.Client? If yes I would try to rebuild it with the Blazor.Server I have built.

I have seen that sometime it may be problematic in some case if the current user folder as a space, as the space may be interpreted as a end of a path declaration. I'm not saying that you have this bug here, but it's just a sanity check as someone had some issue for this reason.
Yes of course you can use your own Blazor WebAssembly project with BlazorMobile.
The only thing is that i didn't write any Step by Step tutorial to do this for now, and even if i do it, it would be nice to write the "extended" version of this guide, meaning how to convert your Blazor web app stucture to a structure compatible with web (standalone) and mobile deployment at the same time.
Unfortunately, i'm a little busy theses days, si i can't write this yet.
I possible, can you please try with Visual Studio 2019 Enterprise Preview on Windows ? https://visualstudio.microsoft.com/fr/vs/preview/
Also, feel free to post here a ZIP file with your buggy project, that i can test on my machine.

Yes, a documentation for the integration of BlazorMobile into an existing Blazor WebAssembly project would be really great! I have tried it to add empty Xamarin.Forms and manually install all packages like in the template but can't get it running. With Xamarin.Forms I am getting rollback errors so I tried adding only the Android Application and add all NuGet packages but this was also not working for me. And if I got it running there were Internal 500 Errors.. I am doing something wrong I guess.
The .zip was too big to upload it here, so I just pushed it into this repository: https://github.com/brstkr/BlazorMobileTemplate
But as I said the code is untouched it is just the template for creating the project with this command:
dotnet new blazormobile -n MyProjectName

I will take a look tomorrow

Can this exception be occured by any launchSettings.json ? I added in the launchSettings.json the part which is in the BlazorWeb.Client project:

commented out "launchUrl" section
added the "environmentVariables" section also any "applicationUrl" section.

"MyProjectName.Blazor.Server": {
        "commandName": "Project",
        /* "launchUrl": "http://localhost:5080/"  <--- commented this part out */
        "environmentVariables": {
              "ASPNETTCORE_ENVIRONMENT": "Development"
          },
        "applicationUrl": "https://localhost:5001;http://localhost:5000"
       }
    }

Also I took the part in Program.csout for default project launch settings:
...
   //.UseKestrel(options =>
   //{
       //options.Listen(IPAddress.Loopback, 5080);
   //})
...

When you say "it worked again" does this mean that the blazormobile.js file loaded ?
The cause and consequence seems weird to me (and more likely a bug somewhere, but don't if it's related to this project or Microsoft).
The launchURL change does not have any incidence.
Listening on port 5080 is totally arbitrary, but this change is done in order to force Kestrel to launch in HTTP mode for the tests, instead of the default HTTPS.
Why ? It can of course load with HTTPS, but you may have an exception (but feel free to test) when the Blazor Server app will try to remote debug your specified endpoint (IP / Port). In order to communicate with the native side (either when deployed or for debugging purpose), the Web app try to connect to a websocket endpoint. If you are in HTTPS mode, the browser may enforce you to use the WSS protocol instead of WS, and as the native end does not carry any WSS / Certificate encryption, it will fail to communicate.
But i don't have done tests on this scenario recently. Are you able to communicate with a deployed Android app from your browser, when you set the correct IP (targeting the IP of your Android device), even with HTTPS enabled in your server project ?

No, it was kinda (working). The blazormobile.js was loading but were unable to connect and the WebSocket connection was not working("net::ERR_CONNECTION_REFUSED").  Communication with Android will probably not work.
I changed it back to the old version. Using IIS Express didn't cause so many problems at least the WebView loaded.

Interesting.
I remember someone that had exactly the same problem with static resources returning 404 while using "project deployment" but working while using IIS Express.
I don't know from where this error is coming, i can be wrong but this strange behavior with static resource is a .NET Core issue in my opinion, but i can be wrong.
If IIS Express mode is working with default template, you should be ok to do remote debugging with Android (or iOS, or anything) if you set every IP / Port correctly like stated in the doc.
Maybe an additional bit to check, any Firewall configuration that would prevent connecting, if you have issue.
Keep me informed !

Btw, I never got the web socket connection working properly, I always get that socket error @brstkr just mentioned above.

@arivera12 This is mandatory for remote debugging.
Please check :

IP and Port configurations on Blazor app.
Port configuration on Native side
That you have enabled debug capabilities for remote debugging. See https://github.com/Daddoon/BlazorMobile#enable-remote-debugging
Try to disable Windows firewall temporarily, as it may block ?
Check that your Device and PC can communicate on the same Network. Check your devices connectivity

@arivera12 This is mandatory for remote debugging.
Please check :

IP and Port configurations on Blazor app.
Port configuration on Native side
That you have enabled debug capabilities for remote debugging. See https://github.com/Daddoon/BlazorMobile#enable-remote-debugging
Try to disable Windows firewall temporarily, as it may block ?
Check that your Device and PC can communicate on the same Network. Check your devices connectivity

Let me give it a try

Hi, this article will help How to deal with the "HTTP 404 '_content/Foo/Bar.css' not found" when using Razor component package on ASP.NET Core Blazor app, now it works for me.

Thanks for the report ! I will try to address this in the doc in the future


parameterized the topic for input (default: scan) and output (default…

parameterized the topic for input (default: scan) and output (default: scan_cloud)
I need to convert various laser_scan topics into various pointclouds, with this modification you can run multiple nodes of laserscan_to_pointcloud (obviously with different names), each one with an input and output topic.

Topic parametrization is generally recommended to be performed via Remapping as it does not require any further coding. See for instance https://github.com/team-vigir/vigir_lidar_proc/blob/master/vigir_lidar_proc_launch/launch/lidar_proc.launch, where both topics are remapped based on arguments supplied to the launch file.


Start a program in user folder leaves file handle open in SYSTEM

Steps to reproduce
Requires an executable in user folder, for example, I have yarn installed by npm at C:\Users\chenximin\AppData\Roaming\npm

Start cmd.exe
Run yarn -v in cmd
Search for yarn.cmd in Process Explorer, found nothing

Start powershell.exe
Run yarn -v in PowerShell 5
Search for yarn.ps1 in Process Explorer again, found nothing

Start pwsh.exe
Run yarn -v in PowerShell Core
Search for yarn.ps1 in Process Explorer again

Expected behavior
Also found nothing
Actual behavior
Found a file handle opened in SYSTEM, so I can't delete this file

Environment data

Name                           Value
----                           -----
PSVersion                      7.2.0-preview.2
PSEdition                      Core
GitCommitId                    7.2.0-preview.2
OS                             Microsoft Windows 10.0.17763
Platform                       Win32NT
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0…}
PSRemotingProtocolVersion      2.3
SerializationVersion           <IP_ADDRESS>
WSManStackVersion              3.0

I don't have any anti-virus software, don't have any file sharing.

Is it the file https://github.com/yarnpkg/yarn/blob/3119382885ea373d3c13d6a846de743eca8c914b/bin/yarn.ps1#L1-L6 ? If so there node is started and I guess we could find more simple reproduce steps.

Is it the file https://github.com/yarnpkg/yarn/blob/3119382885ea373d3c13d6a846de743eca8c914b/bin/yarn.ps1#L1-L6 ? If so there node is started and I guess we could find more simple reproduce steps.

No, yarn is just an example, I have problem with all executables in my user folder, usually it's code-insiders.cmd and yarn.ps1.
After more researching I found that it only happens to PowerShell installed from Microsoft Store. I downloaded the .msi installer from GitHub releases and that one is fine. Maybe related to my old Windows 10 version and Microsoft Store.

No, yarn is just an example, I have problem with all executables in my user folder, usually it's code-insiders.cmd and yarn.ps1.
After more researching I found that it only happens to PowerShell installed from Microsoft Store. I downloaded the .msi installer from GitHub releases and that one is fine. Maybe related to my old Windows 10 version and Microsoft Store.

I found that it only happens to PowerShell installed from Microsoft Store

Thanks for your investigations!
/cc @SteveL-MSFT for information.

I found that it only happens to PowerShell installed from Microsoft Store

Thanks for your investigations!
/cc @SteveL-MSFT for information.


support_flow_sample_expanded_and_counter_sample_expanded

support flow sample expanded and counter sample expanded

I think this change is problematic.
It defines a new type called FlowSampleExpand, which has different fields than the regular FlowSample. The expanded format is just a different binary representation of the same data, so it is not reasonable to have a different JSON representation of them. As vflow aims to give a standard representation of the data on wire, regardless of minor differences in encoding, this doesn't sound like the way to go.
Also, there's a lot of code duplication here, while actually the different in compact vs. expanded boils down to just a few differences.

THIS PR IS LIVE-SAVING.


Inserted svg node not hidden properly

#13 addressed the issue, that inserted svg nodes hidden by setting width and height to zero, were still displayed by IE.
The solution has been setting visibility: hidden on the inserted svg node. This prevents the svg node from being rendered, nevertheless IE11 and Windows Mobile 8 IE evaluate the svg's intrinsic width and display unwanted scrollbars. Have a look at this example with IE or the screenshots below (top: IE with scrollbar; below: firefox renders as expected).

<!DOCTYPE html>
<html>
<head>
    <meta name="viewport" content="width=device-width">
</head>
<body>
<svg style="position: absolute; width: 0; height: 0; visibility: hidden" version="1.1" xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink">
    <title>Test image</title>
    <defs>
        <symbol id="icon" viewBox="0 0 100 100">
            <title>rect</title>
            <rect width="100%" height="100%" fill="red"/>
        </symbol>
    </defs>
    <text x="5" y="20" style="font-size:15">This text is shown when viewing the svg file directly... Some more characters to make this text wider: abcdefghijklmnopqrstuvwxyz</text>
</svg>

<svg style="width:25px; height:25px;"><use xlink:href="#icon"></use></svg>

</body>
</html>

Setting display: none is no viable solution as it breaks gradients. This has been discussed in #13.
I tried using position: fixed instead of position: absolute for the inserted svg node. This worked for me, but I'm unsure about possible side effects.

Thanks. I opted for using overflow: hidden. Should have used it in the first place!
Your solution works too. I don't think there are any side effects to using fixed positioning; other than perhaps performance issues.

Thanks. I opted for using overflow: hidden. Should have used it in the first place!

Obiously the best solution. Works like a charm. Thanks a lot!


Sibling Compliance

Hey there,
We've had some issues with node.contains not triggering when a number of sibling elements use your vue-clickaway directive. We've found a solution to this by using event.path.indexOf(element);. In the implementation it also solves Issue 23. In the updated a incremented the version for easier npm publishing, but feel free to do whatever you like with this.
Thanks for considering my PR and for the nice directive!
-Jono

Hi, thanks for making the PR!
I did not at first, but now I see why ev.path is better than el.contains. It tests whether the element was there at the time of the click, not whether it is there now, that the event has arrived to the top.
Regarding the polyfill for indexOf, I don't think it is needed. Virtually every browser supports it, and if it does not, it's better to polyfill at the app level, not at the library level.
I would also like to publish it as 2.2.0, not as 2.1.1.
With that in mind, I'm closing the PR, but I will integrate your changes. Good job!


Upstream2707

Описание PR

Changelog.yml
Лист чейнжлогов, смотреть подробнее..
- author: SlamBamActionman
  changes:
  - message: RGBee and Rainbow Carp plushies now cycle color when held/worn.
    type: Fix
  id: 6917
  time: '2024-07-14T10:26:34.0000000+00:00'
  url: https://github.com/space-wizards/space-station-14/pull/30023
- author: Winkarst-cpu
  changes:
  - message: Now grappling gun is clumsy proof.
    type: Tweak
  id: 6918
  time: '2024-07-14T10:26:56.0000000+00:00'
  url: https://github.com/space-wizards/space-station-14/pull/29904
- author: HahayesSiH
  changes:
  - message: It is now possible to pet cyborgs.
    type: Add
  - message: Clicking on cyborgs and opening the strip menu no longer unlocks them.
    type: Tweak
  id: 6919
  time: '2024-07-14T14:09:41.0000000+00:00'
  url: https://github.com/space-wizards/space-station-14/pull/30037
- author: deltanedas
  changes:
  - message: Fixed ninja shoes not working as magboots.
    type: Fix
  id: 6920
  time: '2024-07-14T15:11:40.0000000+00:00'
  url: https://github.com/space-wizards/space-station-14/pull/28586
- author: lzk228
  changes:
  - message: Scarves are eatable again.
    type: Fix
  id: 6921
  time: '2024-07-14T15:12:25.0000000+00:00'
  url: https://github.com/space-wizards/space-station-14/pull/29959
- author: Winkarst-cpu
  changes:
  - message: Now addgamerule command processes only valid game rules.
    type: Fix
  id: 6922
  time: '2024-07-15T19:18:33.0000000+00:00'
  url: https://github.com/space-wizards/space-station-14/pull/29912
- author: Jezithyr
  changes:
  - message: Removed the Geras ability from Slimes
    type: Remove
  id: 6923
  time: '2024-07-16T22:50:17.0000000+00:00'
  url: https://github.com/space-wizards/space-station-14/pull/29731
- author: K-Dynamic
  changes:
  - message: nerfed paraylze timer of all slippable objects (including soaps, water
      puddles, and clown-related items)
    type: Tweak
  id: 6924
  time: '2024-07-16T23:26:02.0000000+00:00'
  url: https://github.com/space-wizards/space-station-14/pull/27879
- author: EmoGarbage404
  changes:
  - message: Resprited wall signs.
    type: Tweak
  id: 6925
  time: '2024-07-17T04:35:19.0000000+00:00'
  url: https://github.com/space-wizards/space-station-14/pull/29806
- author: lzk228
  changes:
  - message: Added health examine for caustic and cold damage.
    type: Add
  id: 6926
  time: '2024-07-17T06:19:13.0000000+00:00'
  url: https://github.com/space-wizards/space-station-14/pull/29989
- author: lzk228
  changes:
  - message: Surgery saws now are normal-sized (no more pocket circular saw).
    type: Tweak
  id: 6927
  time: '2024-07-17T06:26:10.0000000+00:00'
  url: https://github.com/space-wizards/space-station-14/pull/29995
- author: Winkarst-cpu
  changes:
  - message: The super door remote is now able to control Syndicate doors.
    type: Fix
  id: 6928
  time: '2024-07-17T13:50:25.0000000+00:00'
  url: https://github.com/space-wizards/space-station-14/pull/30033
- author: Errant
  changes:
  - message: Vox are temporarily removed from Space Ninjas and all Unknown Shuttle
      ghostroles, until code supports giving them species-specific gear.
    type: Tweak
  id: 6929
  time: '2024-07-17T22:04:51.0000000+00:00'
  url: https://github.com/space-wizards/space-station-14/pull/30099
- author: Cojoke-dot
  changes:
  - message: You can no longer teleport objects that should not be in other objects
      into other objects with the Quantum Spin Inverter
    type: Fix
  id: 6930
  time: '2024-07-18T00:40:54.0000000+00:00'
  url: https://github.com/space-wizards/space-station-14/pull/29200
- author: Plykiya
  changes:
  - message: Stun batons no longer use up charges when hitting objects without stamina.
    type: Fix
  id: 6931
  time: '2024-07-18T00:48:09.0000000+00:00'
  url: https://github.com/space-wizards/space-station-14/pull/30136
- author: Sh18RW
  changes:
  - message: Moth can't eat boots with an item more
    type: Fix
  id: 6932
  time: '2024-07-18T22:34:18.0000000+00:00'
  url: https://github.com/space-wizards/space-station-14/pull/30019
- author: portfiend
  changes:
  - message: Reptilians display correct mask sprites in character customization screen.
    type: Fix
  id: 6933
  time: '2024-07-18T22:36:53.0000000+00:00'
  url: https://github.com/space-wizards/space-station-14/pull/30095
- author: Plykiya
  changes:
  - message: You no longer deal double damage to your first target when throwing an
      item.
    type: Fix
  id: 6934
  time: '2024-07-19T01:08:52.0000000+00:00'
  url: https://github.com/space-wizards/space-station-14/pull/30115
- author: deepdarkdepths
  changes:
  - message: Removed the description about geras in the Slime guidebook section.
    type: Remove
  id: 6935
  time: '2024-07-19T09:04:43.0000000+00:00'
  url: https://github.com/space-wizards/space-station-14/pull/30140
- author: Blackern5000
  changes:
  - message: Nuclear operatives are now able to purchase durable armor which is NOT
      space-proof.
    type: Add
  id: 6936
  time: '2024-07-19T09:38:26.0000000+00:00'
  url: https://github.com/space-wizards/space-station-14/pull/29845
- author: Plykiya, slarticodefast
  changes:
  - message: Explosive pens now correctly embed into their target.
    type: Fix
  id: 6937
  time: '2024-07-19T09:42:58.0000000+00:00'
  url: https://github.com/space-wizards/space-station-14/pull/30112
- author: ThatOneEnby1337
  changes:
  - message: News Reporters are now able to use markup tags in their reports without
      bricking the PDAs of readers
    type: Fix
  id: 6938
  time: '2024-07-19T14:18:39.0000000+00:00'
  url: https://github.com/space-wizards/space-station-14/pull/30169
- author: themias
  changes:
  - message: Mailing units are functional again
    type: Fix
  id: 6939
  time: '2024-07-20T02:31:26.0000000+00:00'
  url: https://github.com/space-wizards/space-station-14/pull/30174
- author: Ghagliiarghii
  changes:
  - message: Nuclear Operatives' Reinforcements now have a PDA!
    type: Tweak
  id: 6940
  time: '2024-07-20T02:59:31.0000000+00:00'
  url: https://github.com/space-wizards/space-station-14/pull/28088
- author: Plykiya
  changes:
  - message: Chameleon scarves now work again.
    type: Fix
  id: 6941
  time: '2024-07-20T03:00:28.0000000+00:00'
  url: https://github.com/space-wizards/space-station-14/pull/30156
- author: Aidenkrz
  changes:
  - message: The mass hallucinations event no longer affects non-humanoids.
    type: Fix
  id: 6942
  time: '2024-07-20T05:53:58.0000000+00:00'
  url: https://github.com/space-wizards/space-station-14/pull/28748
- author: buntobaggins
  changes:
  - message: Increased light radius on the Spationaut Hardsuit
    type: Tweak
  id: 6943
  time: '2024-07-21T03:29:21.0000000+00:00'
  url: https://github.com/space-wizards/space-station-14/pull/30049
- author: EmoGarbage404
  changes:
  - message: Fixed wires not updating UI on the Particle Accelerator.
    type: Fix
  id: 6944
  time: '2024-07-21T05:27:18.0000000+00:00'
  url: https://github.com/space-wizards/space-station-14/pull/28750
- author: CroilBird
  changes:
  - message: 6-pack of cola displays correctly when not being handled
    type: Fix
  id: 6945
  time: '2024-07-21T05:49:48.0000000+00:00'
  url: https://github.com/space-wizards/space-station-14/pull/29309
- author: metalgearsloth
  changes:
  - message: Fix muzzle flashes not tracking properly.
    type: Fix
  id: 6946
  time: '2024-07-21T06:09:17.0000000+00:00'
  url: https://github.com/space-wizards/space-station-14/pull/30163
- author: metalgearsloth
  changes:
  - message: Fix being able to throw items while your cursor is off-screen.
    type: Fix
  id: 6947
  time: '2024-07-21T06:13:28.0000000+00:00'
  url: https://github.com/space-wizards/space-station-14/pull/30164
- author: metalgearsloth
  changes:
  - message: Reset the scroll bar in the ghost warp menu whenever you search for a
      role. Previously it remained at your previous position and you would have to
      scroll up to see the first entry.
    type: Tweak
  id: 6948
  time: '2024-07-21T06:38:45.0000000+00:00'
  url: https://github.com/space-wizards/space-station-14/pull/30159
- author: Blackern5000
  changes:
  - message: The syndicate agent's cyborg weapons module now uses syndicate weaponry
      rather than NT weaponry.
    type: Tweak
  id: 6949
  time: '2024-07-21T07:04:33.0000000+00:00'
  url: https://github.com/space-wizards/space-station-14/pull/26947
- author: Winkarst-cpu
  changes:
  - message: Added ambience to the camera routers and telecommunication servers.
    type: Add
  - message: Now server's and router's ambience stops once they are unpowered.
    type: Fix
  id: 6950
  time: '2024-07-21T07:22:02.0000000+00:00'
  url: https://github.com/space-wizards/space-station-14/pull/30091
- author: Scott Dimeling
  changes:
  - message: Reduced the number of botanists in some stations, for optimal _workflow_
    type: Tweak
  id: 6951
  time: '2024-07-21T07:23:28.0000000+00:00'
  url: https://github.com/space-wizards/space-station-14/pull/29581
- author: metalgearsloth
  changes:
  - message: Escape pods won't show up on shuttle map anymore.
    type: Tweak
  id: 6952
  time: '2024-07-21T07:23:44.0000000+00:00'
  url: https://github.com/space-wizards/space-station-14/pull/29758
- author: IProduceWidgets
  changes:
  - message: an arabian lamp!
    type: Add
  id: 6953
  time: '2024-07-21T07:24:28.0000000+00:00'
  url: https://github.com/space-wizards/space-station-14/pull/27270
- author: osjarw
  changes:
  - message: NPCs no longer get stuck trying to pick up anchored pipes.
    type: Fix
  id: 6954
  time: '2024-07-21T07:28:37.0000000+00:00'
  url: https://github.com/space-wizards/space-station-14/pull/30061
- author: The Hands Leader - JoJo cat
  changes:
  - message: Train map is back into rotation
    type: Tweak
  id: 6955
  time: '2024-07-21T07:44:18.0000000+00:00'
  url: https://github.com/space-wizards/space-station-14/pull/30145

Медиа

Проверки

[ ] PR полностью завершён и мне не нужна помощь чтобы его закончить.
[ ] Я внимательно просмотрел все свои изменения и багов в них не нашёл.
[ ] Я запускал локальный сервер со своими изменениями и всё протестировал.
[ ] Я добавил скриншот/видео демонстрации PR в игре, или этот PR этого не требует.

Изменения
:cl: Шрёдька

tweak: Подтянуты коммиты с корвакса, 27.07.24

Фига, с первого раза все тесты
ахуе


Upgrade ember cli

Fix #361

Note that's the canary build which causes the tests failure. In theory we can temporarily disable it. What do you think?

@poteto may I ping you on this?

@stukalin issue on canary is fixed (see https://github.com/emberjs/ember-test-helpers/pull/1066), you could update @ember/test-helpers to 2.2.9+
But this scenario will probably still fails (see https://github.com/poteto/ember-cli-flash/pull/367, same import issue in this repo), maybe it is better to do the change on your PR so that we ensure ember-canary scenario will be ok?

@ndekeister-us thanks for the comment! I'll try this one out

@ndekeister-us fixed your comment. Would anyone else want to review/merge ther PR? @poteto ?

I don't work with Ember anymore so I don't think I can review this. Paging @sbatson5, @kategengler

I don't work with Ember anymore so I don't think I can review this. Paging @sbatson5, @kategengler

I haven't worked in Ember for a couple years now, unfortunately.

@kategengler may I ping you on this one then?

@poteto @sbatson5 if you both don't work with Ember anymore, would you be open to transfering the repo to https://github.com/adopted-ember-addons/ ?
instructions for that are available in https://github.com/adopted-ember-addons/program-guidelines#getting-your-addon-adopted

@poteto @sbatson5 if you both don't work with Ember anymore, would you be open to transfering the repo to https://github.com/adopted-ember-addons/ ?
instructions for that are available in https://github.com/adopted-ember-addons/program-guidelines#getting-your-addon-adopted

I'm just a maintainer and don't have the rights to transfer this repo. I support the decision, however!

@Turbo87 Yeah I think that's the best option. I'll reach out to get this transferred.

@rahulk94 thanks a lot! Anyone with the "i am able to press the merge button" permission? @sbatson5 @poteto would you mind? (Sorry for bothering you each time guys)

@poteto @Turbo87 any news on transferring the repo ?

Thanks for you works here. The changes looks good to me too :)
This update is needed if we want to use ember v4... do you think you can merge and release it?

@GreatWizard i don't have enough permissions unfortunately

👋 Sorry, for missing these pings. I can't cut a release if y'all are confident as we wait for the transfer to "adopted-ember-addons"

@poteto @sbatson5  if you can transfer this repo to me, I am an owner on adopted-ember-addons and I can get this transferred there. I will also need you to please make me an owner on npm, I am rwwagner90 there as well.


Bump cheffish to 17.1.8

Description

The bump pulls in fixes for Target mode.
Related Issue

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

[ ] I have read the CONTRIBUTING document.
[ ] I have run the pre-merge tests locally and they pass.
[ ] I have updated the documentation accordingly.
[ ] I have added tests to cover my changes.
[ ] If Gemfile.lock has changed, I have used --conservative to do it and included the full output in the Description above.
[ ] All new and existing tests passed.
[ ] All commits have been signed-off for the Developer Certificate of Origin.

@neha-p6 can you post the bundle update --conservative cheffish output for this?

Merging since VMs are passing and dockers are failing on a known issue.


[Bug]:  Unable to filter by severity when using compliance, service, etc.

Steps to Reproduce
I am running the following command, hoping to only get findings that are considered critical and high, however, I get an error when trying to do so:
prowler aws --compliance cis_2.0_aws --profile cloudops-dev --verbose --only-logs --severity high
This trows the following error:  prowler aws: error: argument --severity: not allowed with argument --compliance
I get the same error when I use services, checks, etc. The only time the filtering does work is when I do not add a specific compliance/check/category.
Expected behavior
The results of only the high and critical findings for my selected compliance/service
Actual Result with Screenshots or Logs
The command above to get the logs will not work, it exits immediately saying I cannot filter the severity
How did you install Prowler?
From pip
Environment Resource
Workstation
OS used
Mac
Prowler version

prowler --version Prowler 3.8.2 (it is the latest version, yay!)

Pip version

pip --version pip 23.2.1 from /opt/homebrew/lib/python3.10/site-packages/pip (python 3.10)

Context
No response

Hi @jicunningham we are going to review this and let you know
Thanks for using Prowler !!!

Thanks, appreciate all your hard work on this project!

Hi @jicunningham,
Right now the compliance execution loads all the checks included in the framework executed and does not allow filtering.
We are planning to include it sooner than later but in this moment is not available.
Can we help you with something else?

Thanks !! I'll close this, don't hesitate and open a new one even if you think it is only you fighting against Prowler
We are always happy to help !!


Create FACADE_CHEECHYUAN_ANG

Closes https://github.com/SporkDAOOfficial/ETHDenver-2023/issues/86

Closes https://github.com/SporkDAOOfficial/ETHDenver-2023/issues/151

Closes https://github.com/SporkDAOOfficial/ETHDenver-2023/issues/46


Snapshot: Missing language in output

New Issue Checklist

[x] Updated fastlane to the latest version
[x] I read the Contribution Guidelines
[x] I read docs.fastlane.tools
[x] I searched for existing GitHub issues

Issue Description
I'm missing the information which language is currently be processed.
I'm running snapshot with following configuration
+----------------------------+--------------------------------------+
|                    Summary for snapshot 2.63.0                    |
+----------------------------+--------------------------------------+
| devices                    | ["iPhone 7 Plus", "iPhone 8 Plus"]   |
| ios_version                | 11.0.1                               |
| languages                  | ["en-US", "de-DE"]                   |
| scheme                     | BirdeesSnapshotUITests               |
| output_directory           | /Users/nicole/Developer/Birdees/scr  |
|                            | eenshots                             |
| clear_previous_screenshots | true                                 |
| project                    | ./Birdees.xcodeproj                  |
| launch_arguments           | ["without-animations"]               |
| clean                      | true                                 |
| concurrent_simulators      | false                                |
| stop_after_first_error     | true                                 |
| output_simulator_logs      | false                                |
| skip_open_summary          | false                                |
| skip_helper_version_check  | false                                |
| reinstall_app              | false                                |
| erase_simulator            | false                                |
| localize_simulator         | false                                |
| buildlog_path              | ~/Library/Logs/snapshot              |
| number_of_retries          | 3                                    |
| xcode_path                 | /Applications/Xcode.app              |
+----------------------------+--------------------------------------+

I know that first "en-US" is processed, afterwards "de-DE". The output only says, which device is processed but not with which language:
[18:36:34]: Running snapshot on: iPhone 7 Plus
[18:55:14]: Running snapshot on: iPhone 8 Plus
[19:03:21]: Running snapshot on: iPhone 7 Plus
[19:13:53]: Running snapshot on: iPhone 8 Plus

I'm still unable to see the current processed language as there is no information in the logs.

Is this something that has worked in the past?

Yes, with a version for Xcode 8 I saw the current used language in the logs.

Ahhh, I think that's because with Xcode 9 we now run multiple simulators in parallel, meaning that it probably runs tests for languages for that specific device. Any specific reason you need to know the language it's running right now?

But are you really running multiple simulators with different languages in parallel? I have the feeling that each language is processed separately - thus there shouldn't be any problem showing the current language. For me this is important to get the status of current tests and get an overview what is processed already.

Hey @IchHabRecht - Yeah you're right we are only running parallel simulators with the same language at once. We should be able to print out which language is being run at a given time. That being said, I believe higher up in the output, it will say that it is running tests for each language individually. Could you share the full output so we can see exactly whats going on? Thanks! 🚀

Hi @ohayon which output do you mean?

I finally managed to test the latest stable version. The problem with seeing the current processed language is still valid.

Still an open issue


Cannot install submariner-operator from OCP OperatorHub

What happened:
When I install submariner-operator from OCP OperatorHub, the below error occurred
error creating clusterrolebinding submariner-lighthouse: ClusterRoleBinding.rbac.authorization.k8s.io "submariner-lighthouse" is invalid: subjects[0].namespace: Required value

What you expected to happen:
How to reproduce it (as minimally and precisely as possible):
Anything else we need to know?:
Environment:

Submariner version (use subctl version):
Kubernetes version (use kubectl version): ocp-4.6.4/kube-v1.19
Cloud provider or hardware configuration: AWS
OS (e.g: cat /etc/os-release):
Kernel (e.g. uname -a):
Install tools:
Network plugin and version (if this is a network-related bug):
Others:

https://github.com/operator-framework/community-operators/pull/2829

tested with the fix


Reactivate RuleEditor

LK-TDK parser package has to be migrated to Akribiqs repository first. Then the Editor can be migrated as well.


Discovery:  Use WASM backend

I just happened to stumble upon this video:  Building a Containerless Future with WebAssembly.
It might be related to what you're building here.
WebAssembly is the future of distributed computing. Its security, memory isolation, small footprint, and true portability are all advantages on the web, but become truly game-changing when used to build functions and services deployed in the cloud. This session illustrates how to host WebAssembly modules in Rust code, how to build modules in many different languages (including pros and cons of each), and how to securely grant cloud-native capabilities to these modules. Discussed in detail is the current state of the art in WebAssembly and what can be built with it today. Learn what developers can start doing now to build the containerless future where WebAssembly modules are the de-facto unit of immutable deployment in the cloud, at the edge, and even in IoT and embedded devices.

I don't think this relates to what we're up to. For one, we're not going to have a backend at all. For another, we want the frontend client to be as open and code-visible as possible, so sticking most or all of our code into WASM seems counter-productive.
We are already using an inline WASM module for the password hashing (Argon2), but I don't see us doing much more with WASM in this project, at least not from what I can currently see/plan.

If I'm missing something, I'm happy to be corrected. We already do the password hashing (argon2) in WASM, and we do the encryption using the built-in webcrypto. And we have all the appropriate security headers applied from the server to prevent any sort of XSS, CORS, unauthorized code (CSP and Subresource Integrity).
Can you elaborate on what you imagine could be more secure about our current client code if we used more WASM?

Also, I think you should be encrypting all of the data going over postMessage as well, if you're not doing so, and checking the origin on the receiving side.
To really trust a system, it would have to be majorly locked down in my opinion.
I say this because I have such a need for one myself.


fix: sealer run repair multiple sealer run problems

Describe what this PR does / why we need it
#1805
Does this pull request fix one issue?

Describe how you did it
Describe how to verify it
Special notes for reviews

Codecov Report
Base: 20.81% // Head: 21.70% // Increases project coverage by +0.88% :tada:

Coverage data is based on head (1dd0329) compared to base (f05c753).
Patch coverage: 11.17% of modified lines in pull request are covered.

:exclamation: Current head 1dd0329 differs from pull request most recent head b4c62bf. Consider uploading reports for the commit b4c62bf to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1812      +/-   ##
==========================================
+ Coverage   20.81%   21.70%   +0.88%
==========================================
  Files          71       72       +1
  Lines        6558     6557       -1
==========================================
+ Hits         1365     1423      +58
+ Misses       5012     4946      -66
- Partials      181      188       +7

Impacted Files
Coverage Δ

pkg/cluster-runtime/apps.go
0.00% <0.00%> (ø)

pkg/cluster-runtime/hook.go
4.13% <0.00%> (-0.38%)
:arrow_down:

pkg/cluster-runtime/installer.go
0.00% <0.00%> (ø)

pkg/runtime/kubernetes/kubeadm/kubeadm_config.go
15.78% <0.00%> (ø)

utils/net/iputils.go
30.63% <0.00%> (+5.39%)
:arrow_up:

utils/net/route.go
0.00% <0.00%> (ø)

utils/ssh/connect.go
0.00% <0.00%> (ø)

utils/ssh/platform.go
0.00% <0.00%> (ø)

utils/ssh/scp.go
0.00% <0.00%> (ø)

utils/ssh/sshcmd.go
0.00% <0.00%> (ø)

... and 9 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

only check common.DefaultKubeConfigFile is not enough , i think we could try to get nodes to determine whether the cluster is exist.


Shrink locale columns to 5 chars

Currently, the mapping for locale columns does not provide any length,
thus Doctrine falls back to the default size: 255 chars.
Not only such size is useless, but it also prevents using this library
with utf8mb4 charset, because InnoDB indexes are capped at 767 bytes,
and unfortunately: 4 * 255 = 1020 bytes.
For reference, here is the error with utf8mb4 charset:

SQLSTATE[42000]: Syntax error or access violation: 1071 Specified key
was too long; max key length is 767 bytes

Fixes #384 and #388.

Following comment on the initial issue (#388), I increased the limit to 5 chars.

Thank you for PR and nice detailed explanation :+1:


drivers: spi: rv32m1_lpspi: Fix null tx

Initialize the dummy data transfer so spi transfer is defined even for
an undefined tx data buffer.
This is part of a fix for #20589, together with PR #26031

Rebased on master and checked again, still works :-)

@henrikbrixandersen I added you as you did the i2c driver for the rv32m1 so are familiar with the rv32m1, hope this is ok :-)

Please rebase to the latest master. I think you're missing the commit that added the buildkite pipeline, hence the check is failing.

Please rebase to the latest master. I think you're missing the commit that added the buildkite pipeline, hence the check is failing.

Done, thanks!


Updated emit for __decorator and __metadata helpers

Fixes part of #2811, by deferring the execution of calls to Reflect.decorate and Reflect.metadata to when the helper is called rather than when it is defined.
This PR will not cover other concerns related to this binding, and does not attempt to reorder or move the position of any helper functions that we may emit.

:+1:
This needs to go into release-1.5 and then ported to master.

This is now in both master and release-1.5