Rulebook Activation fails

I'm running the docker-compose setup.
I created a rulebook activation via the GUI. The API-response for the activation is this:
  {
    "name": "test5",
    "rulebook_id": 14,
    "inventory_id": 3,
    "extra_var_id": 4,
    "working_directory": "/tmp",
    "execution_environment": "alpine:latest",
    "project_id": 4,
    "id": 11
  }

When saving the activation, the logs ouput this:
eda-postgres           | 2022-11-03 17:09:47.938 UTC:client backend:[2420]: LOG:  execute __asyncpg_stmt_70__: INSERT INTO activation_instance (name, rulebook_id, inventory_id, extra_var_id, working_directory, exe
cution_environment, project_id) VALUES ($1::varchar, $2::integer, $3::integer, $4::integer, $5::varchar, $6::varchar, $7::integer) RETURNING activation_instance.id, activation_instance.large_data_id
eda-postgres           | 2022-11-03 17:09:47.938 UTC:client backend:[2420]: DETAIL:  parameters: $1 = 'test5', $2 = '14', $3 = '3', $4 = '4', $5 = '/tmp', $6 = 'alpine:latest', $7 = '4'
eda-server             | [1] 2022-11-03 17:09:48,016 ERROR    Failed to start container: DockerError(900, 'Cannot connect to Docker Engine via unix:///run/docker.sock [Cannot connect to unix socket /run/docker.soc
k ssl:default [Permission denied]]')
eda-server             | [1] 2022-11-03 17:09:48,019 INFO     <IP_ADDRESS>:33316 - "POST /api/activation_instance HTTP/1.0" 500 Internal Server Error
eda-frontend           | <IP_ADDRESS> - - [03/Nov/2022:17:09:48 +0000] "POST /api/activation_instance HTTP/1.1" 500 21 "-" "Mozilla/5.0 (X11; Linux x86_64; rv:105.0) Gecko/20100101 Firefox/105.0" "-"
eda-server             | [1] 2022-11-03 17:09:48,021 ERROR    Exception in ASGI application
eda-server             | Traceback (most recent call last):
eda-server             |   File "/opt/app-root/lib64/python3.9/site-packages/aiohttp/connector.py", line 1378, in _create_connection
eda-server             |     _, proto = await self._loop.create_unix_connection(
eda-server             |   File "/usr/lib64/python3.9/asyncio/unix_events.py", line 244, in create_unix_connection
eda-server             |     await self.sock_connect(sock, path)
eda-server             |   File "/usr/lib64/python3.9/asyncio/selector_events.py", line 502, in sock_connect
eda-server             |     return await fut
eda-server             |   File "/usr/lib64/python3.9/asyncio/selector_events.py", line 507, in _sock_connect
eda-server             |     sock.connect(address)
eda-server             | PermissionError: [Errno 13] Permission denied
eda-server             |
eda-server             | The above exception was the direct cause of the following exception:
eda-server             |
eda-server             | Traceback (most recent call last):
eda-server             |   File "/opt/app-root/lib64/python3.9/site-packages/aiodocker/docker.py", line 248, in _do_query
eda-server             |     response = await self.session.request(
eda-server             |   File "/opt/app-root/lib64/python3.9/site-packages/aiohttp/client.py", line 536, in _request
eda-server             |     conn = await self._connector.connect(
eda-server             |   File "/opt/app-root/lib64/python3.9/site-packages/aiohttp/connector.py", line 540, in connect
eda-server             |     proto = await self._create_connection(req, traces, timeout)
eda-server             |   File "/opt/app-root/lib64/python3.9/site-packages/aiohttp/connector.py", line 1384, in _create_connection
eda-server             |     raise UnixClientConnectorError(self.path, req.connection_key, exc) from exc
eda-server             | aiohttp.client_exceptions.UnixClientConnectorError: Cannot connect to unix socket /run/docker.sock ssl:default [Permission denied]
eda-server             |
eda-server             | During handling of the above exception, another exception occurred:
eda-server             |
eda-server             | Traceback (most recent call last):
eda-server             |   File "/opt/app-root/src/src/eda_server/ruleset.py", line 123, in activate_rulesets
eda-server             |     await aiodocker.images.DockerImages(docker).pull(
eda-server             |   File "/opt/app-root/lib64/python3.9/site-packages/aiodocker/images.py", line 133, in _handle_list
eda-server             |     async with cm as response:
eda-server             |   File "/opt/app-root/lib64/python3.9/site-packages/aiodocker/utils.py", line 309, in __aenter__
eda-server             |     resp = await self._coro
eda-server             |   File "/opt/app-root/lib64/python3.9/site-packages/aiodocker/docker.py", line 240, in _do_query
eda-server             |     await self._check_version()                                                                                [0/7105]
eda-server             |   File "/opt/app-root/lib64/python3.9/site-packages/aiodocker/docker.py", line 192, in _check_version
eda-server             |     ver = await self._query_json("version", versioned_api=False)
eda-server             |   File "/opt/app-root/lib64/python3.9/site-packages/aiodocker/docker.py", line 300, in _query_json
eda-server             |     async with self._query(
eda-server             |   File "/opt/app-root/lib64/python3.9/site-packages/aiodocker/utils.py", line 309, in __aenter__
eda-server             |     resp = await self._coro
eda-server             |   File "/opt/app-root/lib64/python3.9/site-packages/aiodocker/docker.py", line 261, in _do_query
eda-server             |     raise DockerError(
eda-server             | aiodocker.exceptions.DockerError: DockerError(900, 'Cannot connect to Docker Engine via unix:///run/docker.sock [Cannot connect to unix socket /run/docker.sock ssl:default [Permission deni
ed]]')
eda-server             |
eda-server             | During handling of the above exception, another exception occurred:
eda-server             |
eda-server             | Traceback (most recent call last):
eda-server             |   File "/opt/app-root/lib64/python3.9/site-packages/uvicorn/protocols/http/h11_impl.py", line 407, in run_asgi
eda-server             |     result = await app(  # type: ignore[func-returns-value]
eda-server             |   File "/opt/app-root/lib64/python3.9/site-packages/uvicorn/middleware/proxy_headers.py", line 78, in __call__
eda-server             |     return await self.app(scope, receive, send)
eda-server             |   File "/opt/app-root/lib64/python3.9/site-packages/fastapi/applications.py", line 270, in __call__
eda-server             |     await super().__call__(scope, receive, send)
eda-server             |   File "/opt/app-root/lib64/python3.9/site-packages/starlette/applications.py", line 124, in __call__
eda-server             |     await self.middleware_stack(scope, receive, send)
eda-server             |   File "/opt/app-root/lib64/python3.9/site-packages/starlette/middleware/errors.py", line 184, in __call__
eda-server             |     raise exc
eda-server             |   File "/opt/app-root/lib64/python3.9/site-packages/starlette/middleware/errors.py", line 162, in __call__
eda-server             |     await self.app(scope, receive, _send)
eda-server             |   File "/opt/app-root/lib64/python3.9/site-packages/starlette/middleware/cors.py", line 92, in __call__
eda-server             |     await self.simple_response(scope, receive, send, request_headers=headers)
eda-server             |   File "/opt/app-root/lib64/python3.9/site-packages/starlette/middleware/cors.py", line 147, in simple_response
eda-server             |     await self.app(scope, receive, send)
eda-server             |   File "/opt/app-root/lib64/python3.9/site-packages/starlette/middleware/exceptions.py", line 75, in __call__
eda-server             |     raise exc
eda-server             |   File "/opt/app-root/lib64/python3.9/site-packages/starlette/middleware/exceptions.py", line 64, in __call__
eda-server             |     await self.app(scope, receive, sender)
eda-server             |   File "/opt/app-root/lib64/python3.9/site-packages/fastapi/middleware/asyncexitstack.py", line 21, in __call__
eda-server             |     raise e
eda-server             |   File "/opt/app-root/lib64/python3.9/site-packages/fastapi/middleware/asyncexitstack.py", line 18, in __call__
eda-server             |     await self.app(scope, receive, send)
eda-server             |   File "/opt/app-root/lib64/python3.9/site-packages/starlette/routing.py", line 680, in __call__
eda-server             |     await route.handle(scope, receive, send)
eda-server             |   File "/opt/app-root/lib64/python3.9/site-packages/starlette/routing.py", line 275, in handle
eda-server             |     await self.app(scope, receive, send)
eda-server             |   File "/opt/app-root/lib64/python3.9/site-packages/starlette/routing.py", line 65, in app
eda-server             |     response = await func(request)
eda-server             |   File "/opt/app-root/lib64/python3.9/site-packages/fastapi/routing.py", line 231, in app
eda-server             |     raw_response = await run_endpoint_function(
eda-server             |   File "/opt/app-root/lib64/python3.9/site-packages/fastapi/routing.py", line 160, in run_endpoint_function
eda-server             |     return await dependant.call(**values)
eda-server             |   File "/opt/app-root/src/src/eda_server/api/activation.py", line 309, in create_activation_instance
eda-server             |     await activate_rulesets(
eda-server             |   File "/opt/app-root/src/src/eda_server/ruleset.py", line 156, in activate_rulesets
eda-server             |     await container.delete()
eda-server             | UnboundLocalError: local variable 'container' referenced before assignment
eda-server             | [1] 2022-11-03 17:09:48,136 INFO     <IP_ADDRESS>:33324 - "GET /api/activation_instances HTTP/1.0" 200 OK
eda-frontend           | <IP_ADDRESS> - - [03/Nov/2022:17:09:48 +0000] "GET /api/activation_instances HTTP/1.1" 200 759 "http://localhost:8080/eda/activations" "Mozilla/5.0 (X11; Linux x86_64; rv:105.0) Gecko/20

It seems the container wants to be started but it's not working because of missing permissions. Is this supposed to work?

@rndmh3ro The value for execution_environment should be a full URL link to an existing image, e.g. quay.io/aizquier/eda-server:latest

Thanks!


Correct types in package.json

types and typings fields in package.json are pointing to a missing file. It may break imports (from Deno in my case).
<EMAIL_ADDRESS>

Hi, .d.ts is the correct name though for declaration files.

You are using .d.js.
This PR replaces .d.js with .d.ts.


Is Win , Is Kill , ....

those rules should have a check for if they were applied on an object that has the rule "is you" so the game ends for that win or lose
same as the solution for this level

saying baba is you and baba is win

Added this feature


[Bug] [server-zkmonitor] zkmonitor can't show for normal

Search before asking

[X] I had searched in the issues and found no similar issues.

What happened
when i use the newst version(v2.0)，find a question as follow：
the zk monitor in the monitor center can not show
What you expected to happen
zk monitor show list normal

How to reproduce
1、 deploy  V2.0
2、start
3、open zk monitor
Anything else
No response
Are you willing to submit PR?

[ ] Yes I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

Yes, I found it's a todo for registry-spi and the implement of RegistryCenterUtils.zookeeperInfoList()  is null.
Should it hide this menu if it is unimplemented?

I am willing to submit a PR，please assign the task to me.

@981433814
OK, it has been assigned, please link this issue to submit a PR


Possible typo?

https://github.com/WHMCS/sample-merchant-gateway/blob/de17ca61749ee9747e0beae0987d340c38c41e7f/modules/gateways/merchantgateway.php#L43
Is it supposed to be DisableLocalCredtCardInput or DisableLocalCreditCardInput?

You are absolutely correct. Submitting a fix for this now.

Still there 3 years later

Erm, it's not - commit e2df0b0 fixed it. The line has since been removed however since we now have a sample token module which demonstrates its use instead.

It is broken in the other sample module. Which I raised a new PR for, got wires crossed because of the similar names for both the modules.


Move arm cond to match guard

I did split the rename to another commit, yet Github UI still show entirely new file change. Please review using commits.

@unrealhoang sorry for a long delay here: it's been a very busy week for me :(

bors r+
Thanks!


just one dot was not in place

@pituach : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Actually there is another typo on the same place. One more dot which is not in place. The doc present ". (The value includes hashes of the rows contained in the transaction.)" instead of " (The value includes hashes of the rows contained in the transaction)."
First dot should be removed and second one should move to the right

Thanks, @pituach! I'll approve this.
#sign-off

This change is incorrect. I reverted it.

Hi Jeff @jborsecnik , what was wrong with the fix? I see that you wrote that it is incorrect. What am I missing here?
You had this before:

as input to the hash function. (The value includes hashes of the rows contained in the transaction.) The function cryptographically...

The fix is pretty clear (I think)

as input to the hash function (The value includes hashes of the rows contained in the transaction). The function cryptographically....

The point should not be inside the brackets but from the outside, otherwise there is no closure to the sentence before the beginning of the next sentence


dereference operation

fn main() {
  let a = 1
  let a_addr = &a // ref<i32>
  let b = *a // i32
}

Second part result at commit: caa7e70ae4512dfc43181d06a2d63348de149a4d

Complete at commit: 53ba21d2627d53b8530f18902da9dba89cc39673


Add saveWithoutHydrating method

Adds a $skipEntityHydration parameter to the validate method, and adds a saveWithoutHydrating method.

try to not change line spacing. That makes it hard to understand what's being really changed. We'll fix code styling in another issue (#268)
What's the point of the change? When you send a PR with a new feature, please elaborate a little bit on why is it needed, what's the use cases and such.

Closing as OP never responded and there were no reactions to the PR.


Dev - Speed Up Build Checks

Currently it builds the entire site and runs all the checks against all the files. It would be far faster to perform at least some of the checks against partial data that is figured out based on the changes made by the PR (just pick the changed files). Running proselint against changed files like this would be a good starting point.
It gets trickier with link validation as those can point anywhere within the site. Solving that would require a bit more (copy the existing site from gh-pages + perform a partial build to overlay on top of that).

Noted in #1380 -- let's track there. There's already some easy things we can do in terms of the order our checks are run I think.


Fix issue with Cancer Biomarkers detail view

The Cancer Biomarkers detail view for TP53 shows an error.
Can we please investigate and fix?

Ticket closed as bug fixed


Installation on Ubuntu

To be able to run gem install haste on Ubuntu, one has to install rubyand ruby-dev so the jsongem dependency can be build.

hacker


Restore identifiers missing from hi file

This fixes #614 by introducing a workaround for ghc droping some bindings that we still need.

I am sorry, that I have not looked into this further. I realized that this only one and not the TH issues I have. I will address the fixes, when I find the time.

Well that's what I reported at #614. I have a failing testcase linked there.
It is honestly not a blocker for this PR. Because this definitely fixes a bug.

@maralorn can you add your failing test case here with "known broken"?

(I will rebase the PR when it's declared ready to merge.)

All checks green. \o/

Thanks!


fix(mps-model-adapters): return null when resolving project module in an unresolvable project

Previously, the method failed while trying to cast null to a non-null type.

:tada: This PR is included in version 8.0.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Improvements for tablet users

Great project!! It would be great to improve the drag and drop functionality so that the dashboard is usable on mobile platforms. unfortunately arranging the dashboard is un-usable on these platforms

You are right, but at the moment i'm not sure how to improve the navigation for tablets.

I think that D&D will never work great on a mobile device. Another metaphor
could be to select (tap on the widget) the widget to move and then select
the destination hotspot (tap another widget or a button after all the
widgets in a column). Thsi way everything would be feasible with to tap
actions.
2015-07-11 11:41 GMT+02:00 Sebastian Sdorra<EMAIL_ADDRESS>
You are right, but at the moment i'm not sure how to improve the
navigation for tablets.
—
Reply to this email directly or view it on GitHub
https://github.com/sdorra/angular-dashboard-framework/issues/110#issuecomment-120599238
.

That would be a great solution Ivan. An user on a desktop would be able to use either method, but mobile devices that need to use click to move can. When it tested the framework on my phone, I was able to drag and drop just fine so I'm not sure if it is dependent on the device or browser. I was using a Samsung Galaxy S5 with Chrome.


Wrong event type for secure Azure AD B2C logout

Hi,
In the section called Secure your logout redirect  there is wrong event type applied to handle secure logout.
Instead of OnRedirectToIdentityProvider it should be OnRedirectToIdentityProviderForSignOut.
Below I present updates two snippets that should be used to implement secure logout:
Below snippet should be used in the point nr. 2:
private async Task OnRedirectToIdentityProviderForSignOutFunc(RedirectContext context)
{
    var id_token_hint = context.Properties.Items.FirstOrDefault(x => x.Key == "id_token_hint").Value;
    if (id_token_hint != null)
    {
        // Send parameter to authentication request
        context.ProtocolMessage.SetParameter("id_token_hint", id_token_hint);
    }

    await Task.CompletedTask.ConfigureAwait(false);
}

Below snippet should be used in the point nr. 3:
services.AddAuthentication(OpenIdConnectDefaults.AuthenticationScheme)
    .AddMicrosoftIdentityWebApp(options =>
    {
        Configuration.Bind("AzureAdB2C", options);
        options.Events ??= new OpenIdConnectEvents();
        options.Events.OnRedirectToIdentityProviderForSignOut += OnRedirectToIdentityProviderForSignOutFunc;
        options.SaveTokens = true;
    });

With current state of documentation, secure logout does not work. I would be grateful for the update as this can help many other developers. Thank you.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: d1940ab3-bb23-6363-8f22-dacfcde91c12
Version Independent ID: 7d0ab81c-9f28-a237-f4e0-36c312ba5d27
Content: Enable web app authentication options using Azure Active Directory B2C
Content Source: articles/active-directory-b2c/enable-authentication-web-application-options.md
Service: active-directory
Sub-service: b2c
GitHub Login: @kengaderdus
Microsoft Alias: kengaderdus

@Daniel-Krzyczkowski
Thanks for your feedback! We will investigate and update as appropriate.

@Daniel-Krzyczkowski
Thanks for reporting this! We have created a PR for this issue and the changes should go live soon.


Merge https://github.com/kubernetes-sigs/cluster-api-operator:main (e6bc25c) into main

This PR merges upstream's https://github.com/kubernetes-sigs/cluster-api-operator:main (e6bc25c) into main.
Check this comment for testing info.

/hold

/retest

/retest

/retest

/hold cancel


How to use with vim-plug

This is more of a how to question. I have vim-plug. My init.vim looks like:
Plug 'ThePrimeagen/refactoring.nvim'
Plug 'nvim-lua/plenary.nvim'
Plug 'nvim-treesitter/nvim-treesitter'

I also have done :TSInstall go and :TSInstall javascrript , But how do I do this, require('refactoring').setup({}) thinggy.
I tried to see if anything like :refactoring#setup, but it doesn't (which is expected, because I couldn't find anything in :help)
Can you please also add an instruction on how to use this?
nvim --version:
NVIM v0.5.1
Build type: Release
LuaJIT 2.1.0-beta3
Compilation:
Compiled by _nixbld1

Features: +acl +iconv +tui
See ":help feature-compile"

   system vimrc file: "$VIM/sysinit.vim"
  fall-back for $VIM: "
/nix/store/xxx-neovim-unwrapped-0.5.1/share/nvim

@amitavaghosh1 this plugin only works on nightly neovim, please update to nightly build and let us know if there is still an issue.

Oh, that's why I probably kept getting error like:
Error detected while processing /Users/amitava.ghosh/.config/nvim/init.vim:
line   98:
E5108: Error executing lua [string ":lua"]:1: module 'refactoring' not found:

okay I will try with nightly and repoen the discussion if requirerd.
thanks for getting back


problems with config stuff  v.02 vs v.03

The following code used to work (more or less) on v. 02. but not on v .03
I get an error :
python3 testMovement.py
Traceback (most recent call last):
File "testMovement.py", line 2, in
from animalai.envs.ArenaConfig import ArenaConfig
ModuleNotFoundError: No module named 'animalai.envs.ArenaConfig'
When I change the line to:
from animalai.envs.arena_config import ArenaConfig
Lower case arena_config, things start to run but then I get:
CrashReporter: initialized
Mono path[0] = '/Users/pneal/aao/may26/env/AnimalAI.app/Contents/Resources/Data/Managed'
Mono config path = '/Users/pneal/aao/may26/env/AnimalAI.app/Contents/MonoBleedingEdge/etc'
INFO:mlagents.envs:
'Academy' started successfully!
Unity Academy name: Academy
Number of Brains: 1
Number of Training Brains : 1
Traceback (most recent call last):
File "testMovement.py", line 16, in
env.reset(config=arena_config_in, train_mode=True)
TypeError: reset() got an unexpected keyword argument 'config'
When I change the reset line to:
env.reset(train_mode=True)
then I don't get the "justFood.yaml" environment, I get the huge default
environment with lots of obstacles, etc.
Best regards,
Phil Neal
+++++++++++++++++++++++cut here for original code ++++++++++++++++=
from animalai.envs.environment import UnityEnvironment
from animalai.envs.ArenaConfig import ArenaConfig
import matplotlib.pyplot as plt
env= UnityEnvironment(
file_name='env/AnimalAI',   # Path to the environment
worker_id=6,                # Unique ID for running the environment (used for connection)
seed=0,                     # The random seed
docker_training=False,      # Whether or not you are training inside a docker
no_graphics=False,          # Always set to False
n_arenas=1,                 # Number of arenas in your environment
play=True                  # Set to False for training
)
arena_config_in = ArenaConfig('configs/justFood.yaml')
env.reset(config=arena_config_in, train_mode=True)
#plt.ion()
def step(action):
info = env.step(action)
b1 = info['Learner']
img = b1.visual_observations
plt.imshow(img[0][0])
plt.close()

Hello,
config has been remained arenas_configurations_input, it works the same way as before. I will highlight this kind of changes in release notes in the future.
Benjamin

Hi Benjamin,
Thank you for all the work you have been doing on the AnimalAi environment.
A slight glitch:
In version 03
from animalai.envs.arena_config import ArenaConfig
worked ok.
But now , in version 04, it doesn't work and upon checking I have to use:
from animalai.envs.ArenaConfig import ArenaConfig
Should I be sending email to you directly about these
things or should I put them in the github 'issues'
section ?
Best regards,
Phil Neal
On Sun, May 26, 2019 at 2:00 PM Benjamin Beyret<EMAIL_ADDRESS>wrote:

Hello,
config has been remained arenas_configurations_input, it works the same
way as before. I will highlight this kind of changes in release notes in
the future.
Benjamin
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/beyretb/AnimalAI-Olympics/issues/11?email_source=notifications&email_token=AAOSQUQV4EZM4QJ6GVL27GDPXJ3XVA5CNFSM4HPWMRA2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWIEISI#issuecomment-495993929,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAOSQUSLBIK6TUDOOYVUBX3PXJ3XVANCNFSM4HPWMRAQ
.

Hi Phil,
You can leave questions here, it can always be helpful to others!
Regarding your issue it looks like you're not running v0.4 as animal.envs.arena_config is correct and works fine. Have a look at the three templates we're providing (visualizeArena.py, visualizeLightsOff.py and train.py), you'll find all syntax and dependencies needed.
Did you try a fresh install in a separate folder and virtual environment?

As @krisives mentioned, you also need to make sure that you update both the environment (by downloading the executable file here, as well as the codebase by pulling the code from the repo.
This should be the update process for every release in the future, I will mention it in the documentation as well.

Hi Benjamin,
Yep. I did a complete re-install and now it all works. Yay !!!
Sorry to worry you
Phil
MAC
macOS Mojave
version 10.14.5
UNITY
May 29 loading unity 2019.1.4f1
MLAGENTS
pip3 show  mlagents
Name: mlagents
Version: 0.8.1
PYTHON
Python 3.6.6
AnimalAI.app -- env_mac_v0.4.zip
On Wed, May 29, 2019 at 11:30 AM Benjamin Beyret<EMAIL_ADDRESS>wrote:

As @krisives https://github.com/krisives mentioned, you also need to
make sure that you update both the environment (by downloading the
executable file here
https://github.com/beyretb/AnimalAI-Olympics#requirements, as well as
the codebase by pulling the code from the repo.
This should be the update process for every release in the future, I will
mention it in the documentation as well.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/beyretb/AnimalAI-Olympics/issues/11?email_source=notifications&email_token=AAOSQUXJ3APZADI7EK2UCDDPXZEKHA5CNFSM4HPWMRA2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWOXYJY#issuecomment-496860199,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAOSQUVHCRS6LMMG5UDOYDDPXZEKHANCNFSM4HPWMRAQ
.

glad it worked! I'll close the issue as it's solved


add codeowner for mesh

This checklist is used to make sure that common guidelines for a pull request are followed.

For new extensions:

[ ] My extension description/summary conforms to the Extension Summary Guidelines.

If this PR is for a new extension or change to an existing extension, use the following to try out the changes in this PR:
docker run -it microsoft/azure-cli:latest
export EXT=<NAME>
pip install --upgrade --target ~/.azure/cliextensions/$EXT "git+https://github.com/williexu/azure-cli-extensions.git@codeowner#subdirectory=src/$EXT&egg=$EXT"

#signoff


[Compatibility] Outlook.com / Office 365 rendering

Done a email testing using the new Zurb Email with Litmus, and the button rendering doesn't support the padding / spacing for the button, and also row > column collapses are not rendering correctly on Outlook.com / Office365 web clients, where as gmail and yahoo all look 100% accurate.
Outlook / Office 365

Yahoo / Gmail

Am using the Inky markup and NPM to build the email, all other clients work (Outlook 2000 onwards, iOs etc) are 100% way it should be... Just the MS web based email clients is causing a issue.
Here is my mark up for the footer
  <row class="collapse">
    <columns small="12" large="12">
      <callout class="secondary">

        <row class="collapse">
          <columns small="10" large="6">
            <row class="collapse">
                <columns small="12" large="3">
Social
</columns>
                <columns small="3" large="2"></columns>
                <columns small="3" large="2"></columns>
                <columns small="3" large="2"></columns>
                <columns small="3" large="2"></columns>
            </row>
          </columns>
          <columns small="4" large="6"></columns>
        </row>
      </callout>
    </columns>
  </row>

And the button

   <button href="#" class="secondary text-center">Book your free place today</button>

Also span's seem to revert to the colour white as well..

Maybe you should consider adding a table inside the  (or button if you use inky) tag and add the padding to the td.
It does the trick for me but i had to review the global button foundation css to make it work for my own purpose (nothing generic enough though)

We're having a lot of trouble with emails rendering in conversation view. It sounds like the issue is not limited to Foundation for emails though.

Office 365 and Outlook.com strip  tags with empty or invalid href attributes. Try adding real URLs instead of # in your href attributes.

@hteumeuleu Good suggestion! We've seen this cause the buttons look different as well. Also invalid URL's will display next to the button.

We have the same issue when button wrapped around the centre tag. On Web Outlook (when message is nested) and Android 5.1.1 Outlook App, will display the button left aligned and link text in blue.


Question about MAX_ITER and IMS_PER_BATCH

Hi, thanks for your code. I have a question about your training scripts.
I see you set the MAX_ITER and IMS_PER_BATCH in the .sh file. If I decrease the batch size, do I need to increase the iteration?
Like you set 4 IMS_PER_BATCH on 2 gpus and 10000 MAX_ITER.
If I set 2 IMS_PER_BATCH on 2 gpus, do I need to double the MAX_ITER to 20000?

Hi, I typically set them to a "high enough" value so that my training does not get killed pre-maturely; and look at the logs to early-stop when the model converges.
With half the effective batch size, it should take more iterations but most likely less than twice. In any case, maybe set it to a high enough value, and see when it converges.

Hi, thanks for your explanation. Very useful.

i am glad 🙂


Have an UseCookieAuthentication overload that takes in instance of DataProtectionProvider

Based on the discussions to make the cookie compatibility between v4.5 and v5.0 apps, we need to have UseCookieAuthentication method take an instance of DataProtectionProvider which is shared among the apps.

Or put it on the options.

+1 to options, I can do this together with the identity changes

IMHO, the best option would be to provide an extension method around CookieAuthenticationOptions, that would internally set the ticket data format using a given data protector.
app.UseCookieAuthentication(options => {
    options.UseDataProtector(protector);
});

Well, today looks like there's the TicketDataFormat which takes the DataProtector in its ctor.
So if we leave cookies alone as is, identity could simply configure things via
options.TicketDataFormat = new TicketDataFormat(dataprotector);
This doesn't look unreasonable, maybe we should just leave things be?

We have a token binding feature coming that may require us to work directly with the DataProtection classes on a per request basis. In that case I think we'd want it on the options.

Related to https://github.com/aspnet/DataProtection/issues/85

As discussed in https://github.com/aspnet/Security/issues/363, what we have today with overriding the TicketDataFormat is enough for cookie sharing


Blocking Calls warnings

Just found this integration....great work!
This is a common thing with integrations now, and apologies if it's already reported, but I didn't see it anywhere.
2024-10-13 12:12:14.670 WARNING (MainThread) [homeassistant.util.loop] Detected blocking call to load_default_certs with args (<ssl.SSLContext object at 0x7ff759910c50>, <Purpose.SERVER_AUTH: _ASN1Object(nid=129, shortname='serverAuth', longname='TLS Web Server Authentication', oid='<IP_ADDRESS>.<IP_ADDRESS>.1')>) inside the event loop by custom integration 'monitor_docker' at custom_components/monitor_docker/helpers.py, line 162: self._api = aiodocker.Docker(url=url) (offender: /usr/local/lib/python3.12/ssl.py, line 713: context.load_default_certs(purpose)), please create a bug report at https://github.com/ualex73/monitor_docker/issues
For developers, please see https://developers.home-assistant.io/docs/asyncio_blocking_operations/#load_default_certs
Traceback (most recent call last):
  File "<frozen runpy>", line 198, in _run_module_as_main
  File "<frozen runpy>", line 88, in _run_code
  File "/usr/src/homeassistant/homeassistant/__main__.py", line 223, in <module>
    sys.exit(main())
  File "/usr/src/homeassistant/homeassistant/__main__.py", line 209, in main
    exit_code = runner.run(runtime_conf)
  File "/usr/src/homeassistant/homeassistant/runner.py", line 189, in run
    return loop.run_until_complete(setup_and_run_hass(runtime_config))
  File "/usr/local/lib/python3.12/asyncio/base_events.py", line 674, in run_until_complete
    self.run_forever()
  File "/usr/local/lib/python3.12/asyncio/base_events.py", line 641, in run_forever
    self._run_once()
  File "/usr/local/lib/python3.12/asyncio/base_events.py", line 1990, in _run_once
    handle._run()
  File "/usr/local/lib/python3.12/asyncio/events.py", line 88, in _run
    self._context.run(self._callback, *self._args)
  File "/config/custom_components/monitor_docker/__init__.py", line 115, in RunDocker
    await hass.data[DOMAIN][entry[CONF_NAME]][API].init(startCount)
  File "/config/custom_components/monitor_docker/helpers.py", line 162, in init
    self._api = aiodocker.Docker(url=url)

2024-10-13 12:12:14.748 WARNING (MainThread) [homeassistant.util.loop] Detected blocking call to load_verify_locations with args (<ssl.SSLContext object at 0x7ff759910c50>,) inside the event loop by custom integration 'monitor_docker' at custom_components/monitor_docker/helpers.py, line 162: self._api = aiodocker.Docker(url=url) (offender: /usr/local/lib/python3.12/site-packages/aiodocker/docker.py, line 392: context.load_verify_locations(cafile=str(certs_path2 / "ca.pem"))), please create a bug report at https://github.com/ualex73/monitor_docker/issues
For developers, please see https://developers.home-assistant.io/docs/asyncio_blocking_operations/#load_verify_locations
Traceback (most recent call last):
  File "<frozen runpy>", line 198, in _run_module_as_main
  File "<frozen runpy>", line 88, in _run_code
  File "/usr/src/homeassistant/homeassistant/__main__.py", line 223, in <module>
    sys.exit(main())
  File "/usr/src/homeassistant/homeassistant/__main__.py", line 209, in main
    exit_code = runner.run(runtime_conf)
  File "/usr/src/homeassistant/homeassistant/runner.py", line 189, in run
    return loop.run_until_complete(setup_and_run_hass(runtime_config))
  File "/usr/local/lib/python3.12/asyncio/base_events.py", line 674, in run_until_complete
    self.run_forever()
  File "/usr/local/lib/python3.12/asyncio/base_events.py", line 641, in run_forever
    self._run_once()
  File "/usr/local/lib/python3.12/asyncio/base_events.py", line 1990, in _run_once
    handle._run()
  File "/usr/local/lib/python3.12/asyncio/events.py", line 88, in _run
    self._context.run(self._callback, *self._args)
  File "/config/custom_components/monitor_docker/__init__.py", line 115, in RunDocker
    await hass.data[DOMAIN][entry[CONF_NAME]][API].init(startCount)
  File "/config/custom_components/monitor_docker/helpers.py", line 162, in init
    self._api = aiodocker.Docker(url=url)

2024-10-13 12:12:14.776 WARNING (MainThread) [homeassistant.util.loop] Detected blocking call to load_cert_chain with args (<ssl.SSLContext object at 0x7ff759910c50>,) inside the event loop by custom integration 'monitor_docker' at custom_components/monitor_docker/helpers.py, line 162: self._api = aiodocker.Docker(url=url) (offender: /usr/local/lib/python3.12/site-packages/aiodocker/docker.py, line 393: context.load_cert_chain(), please create a bug report at https://github.com/ualex73/monitor_docker/issues
For developers, please see https://developers.home-assistant.io/docs/asyncio_blocking_operations/#load_cert_chain
Traceback (most recent call last):
  File "<frozen runpy>", line 198, in _run_module_as_main
  File "<frozen runpy>", line 88, in _run_code
  File "/usr/src/homeassistant/homeassistant/__main__.py", line 223, in <module>
    sys.exit(main())
  File "/usr/src/homeassistant/homeassistant/__main__.py", line 209, in main
    exit_code = runner.run(runtime_conf)
  File "/usr/src/homeassistant/homeassistant/runner.py", line 189, in run
    return loop.run_until_complete(setup_and_run_hass(runtime_config))
  File "/usr/local/lib/python3.12/asyncio/base_events.py", line 674, in run_until_complete
    self.run_forever()
  File "/usr/local/lib/python3.12/asyncio/base_events.py", line 641, in run_forever
    self._run_once()
  File "/usr/local/lib/python3.12/asyncio/base_events.py", line 1990, in _run_once
    handle._run()
  File "/usr/local/lib/python3.12/asyncio/events.py", line 88, in _run
    self._context.run(self._callback, *self._args)
  File "/config/custom_components/monitor_docker/__init__.py", line 115, in RunDocker
    await hass.data[DOMAIN][entry[CONF_NAME]][API].init(startCount)
  File "/config/custom_components/monitor_docker/helpers.py", line 162, in init
    self._api = aiodocker.Docker(url=url)

You are the first one to report this. On which HA version are you testing it? And if you disable TLS/SSL, does it work?

I'm running 2024.9.3 now, and Monitor Docker 1.19.
I'm planning to update to 2024.10 this week, so I can see if the error recurs with that.  I can try disabling TLS at that time as well.
Also I should say, everything seems to work fine, I just get that error in the logs on every restart.

I think the issue is in aiodocker, the library doing all the docker connectivity. I will check if I can workaround this error.


Bumped capnproto to 0.5.1

If you'd rather also test both 0.5.0 and 0.5.1 I can change this PR.

Thanks!

@jparyani Do we leave this PR as it is or do we want to test against other versions of capnproto?

I'm fine with only testing against the latest. C++ Cap'n Proto is a fast moving library, and it's not unreasonable to expect people to keep it up to date. Also, now that the build will automatically download/build C++ Cap'n Proto if you don't have it installed, I imagine a lot of people won't ever run into an out of date library problem.


Is there are way to reduce the image size?

I have built this locally and have an image with 1.7Gb. When I am basically interested in running development domains on Weblogic this becomes a drag across the team.

I'm not sure if there's a way to reduce the overall size, hence I'm assigning this to @brunoborges. However, if you use btrfs as your storage option, Docker will automatically create subvolumes for each layer and reuse them across containers.

The scripts provided here are starters, that users can use to kick off their WebLogic on Docker deployments. Our certification and support is over the topologies as described in the whitepaper and related documentation.
Users are free to use different Docker techniques to achieve better image size compression if they want, such as what @Djelibeybi suggests, as well custom Dockerfiles that may save greater speace.


Help panel: some elements are not rendered properly

v1.22.2
Steps to reproduce:

Open a table
Add all types of viewers
For each viewer check the help panel

Expected results: all elements in the help panel should be rendered.
Actual results: looks like some formatting is not properly rendered. For example:

Please check this for all viewers types (and other places where such panel is applicalble)

This issue has been mirrored in Jira: https://reddata.atlassian.net/browse/GROK-17054


Fix broken link for CDS/Dynamics 365 SDK download

Fix broken link for CDS/Dynamics 365 SDK download on labs 6; task #2; point 1
Module: 6
Lab/Demo: 6 – Plugins
Task #2: Deploy the plugin
Changes proposed in this pull request:
-Fix broken link to get the Dynamics 365 SDK Tools

Hello @skulthm-ms ; have the same error page :
I have personally use the link suggested to continue the lab


Refactor http client

Summary
This PR addresses #111
It adds custom error types including RequestError, ResponseError, ValidationError, custom validation error types including InvalidDidError and InvalidServiceEndpointError.
The http-client is refactored to throw a custom error type in case of a failure, and return data only in case of success.
This PR only introduces more narrow custom error types for ValidationErrors. We can track adding more narrow custom error types for request and response errors here.

@kirahsapong we thinking about refactoring the rest of http-client in this PR or refactoring 1 method per PR?

@kirahsapong as much as i want to use msw, i think it may be in our best interests to stub fetch instead. I've been working on updating how we run browser tests, but even with those changes, conditionally switching between the msw import for node vs. browser is going to be tricky.
Did you have an approach in mind for conditionally switching between import { setupWorker } from 'msw/browser' and import { setupServer } from 'msw/node'?
Otherwise, i think we can follow this example from web5-js to mock fetch!

oh yeah! last thing to note would be that we probably should add a changeset to trigger a version bump. we should highlight that this is a breaking change and send the changelog over to devrel incase they've built any examples or written guides using TbdexHttpClient


[3.x] Set CSGPolygon path_interval step size and minimum to 0.01

3.x version of #52413.

Superseded by #52512.


Update text FormField to be optional

Problem
Currently the text field is required. This results in bad request for slash commands without arguments.
Proposed Solution
This commit marks it as optional so that standalone slash commands work without error.
Related Issue
Issue #4
Note: Updated gitignore file to ignore IDE related files.

@ddemid added a test for it.

Is this branch going to be merged? Asking because I've been using this library and just got my slack app rejected for the non-parameter slack command returning an error lol. Otherwise I'll use modasserbillah's branch.

Is this branch going to be merged? Asking because I've been using this library and just got my slack app rejected for the non-parameter slack command returning an error lol. Otherwise I'll use modasserbillah's fork branch in my deps. Thanks!

done. Sorry for delay


[5.9🍒] support parsing discard in place of _forget

Cherry-pick of https://github.com/apple/swift-syntax/pull/1644
SE-390 concluded with choosing the keyword discard rather than forget. This commit begins the process of deprecating the old keyword on the swift-syntax side.
rdar://108859077
(cherry picked from commit 2c97ee093a6d09d8001407abf7f0e23c530bb537)

@swift-ci please test


Carrier screening filter mode

Is your feature request related to a problem? Please describe.
Carrier screening of both parents for compound heterozygous variants is currently not possible (if the index does not carry both of them). Current guidelines recommend reporting carrier status as an incidental finding.
Describe the solution you'd like
Create a carrier screening filter preset.  Presets like existing compond heterozygous preset but with inheritance: Index Any, Father 0/1, Mother 0/1 in same gene.
Describe alternatives you've considered
It takes too long to search a panel for father and mother separately and then combine them manually.
Additional context
https://gfhev.de/de/veroeffentlichungen/2023_Zusatz-und_Zufallsbefunde.pdf

Not so easy. Needs adjustment of query engine. I would suggest doing this after ng data flows


added value for handle and fixed TcpSocket lifetime bug

I remember doing this pull request before but I didnt hear from you. Possibly I didn't press "create"?
as I talked to you, I changed the impl and also added a little value method for Handle because I couldnt get the value out on my code.

Please don't do two unrelated changes in one commit.
The inner structure of the handle is an implementation detail and is intentionally not exposed.

ok changed it back to only the bug fix.
Getting the value from handle would be really useful though, because without it, to have sockets controled from C++ I'd have to store each Handle in Rust side and give to C++ the number for the handle object.

You can't create a handle even with your change, can you?

Sorry didn't understand.
I want to create sockets in Rust by calling from C++. I cannot pass the handle to C++ so I wanted to pass the value of the handle. Then C++ could invoke methods on the socket because it knows its handle.

How would you call a method on the socket?

If C++ knows the handle number, it can call the C-callable Rust function with the handle number as an argument:
pub extern "C" fn socket_is_active(size_t handle) -> bool {
    let handle = Handle(handle);
    let mut socket = sockets.get::<TcpSocket>(handle);
    sockt.is_active()
}

But you can't use the constructor of Handle like that, see playground link. If we were to expose the internals of Handle it would make a lot more sense to make the inner field pub. I'm not yet sure if we should do that though.

Hmmm right didn't antecipate that because I didnt even start this part of the C interface. I've just wrote the part that returns the socket handle to C++.
Of course I can deal with it but since Rust does not have static variables I cannot simpy put these Handles in a static list on Rust and give its index back to C++. There are workarounds like lazy_static but not the right way. I could also place it in a Box and return the Box to C++ (on C++ I receive it simply as a void* and pass this void* back to Rust and receive on Rust as &mut HandleStruct).
Anyways, as you see, having access to the inner number of Handle (and having a way to create a Handle) would facilitate a LOT!

I could also place it in a Box and return the Box to C++ (on C++ I receive it simply as a void* and pass this void* back to Rust and receive on Rust as &mut HandleStruct).

I would very much prefer you to go this route, since it leaves smoltcp free to adjust the internal structure of the handles however it needs to.

Thanks for your contribution!


Shouldn't this work? #v3

Question
Issue with Transformer.js v3 and WebGPU
Description
Yesterday I installed transformer.js with the "v3" branch to test the new features with WebGPU, but I get an error.
Error Message
@xenova_transformers.js?v=3b2ad0ed:24861 Uncaught (in promise)
Error: This pipeline is not yet supported in Transformers.js v3.

My code
const transcriber = await pipeline("automatic-speech-recognition", "Xenova/whisper-small.en", {
    device: 'webgpu',
    dtype: 'fp32'
});

Additional Information
With the following code, it works perfectly fine:
const extractor = await pipeline('feature-extraction', 'Xenova/all-MiniLM-L6-v2', {
    device: 'webgpu',
    dtype: 'fp32', // or 'fp16'
});

Hi there. As you can see by the error message, this pipeline still a work in progress. We'll be putting out a whisper webgpu demo soon though, so stay tuned for updates!

I'm developing a project, is there an estimated date available for this feature? Thank you

Unfortunately not... Everything it still quite experimental at the moment.


WIP: Powershell make

Advantages:

Get-Help .\make.ps1 -Full :clap:
Parameter validation
Smarter about finding MSBuild.exe

Missing "DeprecatedTest" from help listing.

@alexmoore I figured that end-users wouldn't be as interested in that and other target that really are for our use. DeprecatedTest is still part of the ValidateSet for the Target parameter, however. Let me know if you'd like it added to the help.

+1 then, cheerio!


Fix customField generator

1. Why is this change necessary?
There is an error when you run bin/console framework:demo --attribute-sets=5.
In CustomFieldGenerator.php line 209:

  [TypeError]
  Shopware\Core\Framework\Demodata\Generator\CustomFieldGenerator::generateCustomFields(): Argument #3 ($attributes) must be of type array, null given, called in /var/www/
  html/vendor/shopware/core/Framework/Demodata/Generator/CustomFieldGenerator.php on line 72

The value "attributes" has been change to "customFields" but an element has been forgotten.
2. What does this change do, exactly?
Change the array key from attributes to customFields.
3. Describe each step to reproduce the issue or behaviour.
Run "framework:demo" command with some attribute set "--attribute-sets=5"
bin/console framework:demo --attribute-sets=5
5. Checklist

[x] I have rebased my changes to remove merge conflicts
[ ] I have written tests and verified that they fail without my change
[ ] I have created a changelog file with all necessary information about my changes
[ ] I have written or adjusted the documentation according to my changes
[ ] This change has comments for package types, values, functions, and non-obvious lines of code
[ ] I have read the contribution requirements and fulfil them.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

thanks for your contribution @PierreGauthier 👍🎉💙


Handler result error is ignore

https://github.com/micro/go-micro/blob/master/server/subscriber.go#L232
Currently it's impossible to handle return value from handler. Do you have some solution?

What return value? This is the subscriber. A subscriber does not return anything

Function fn returns error, but it's handle nowhere.

What should be the appropriate behaviour? Please PR the change

Now fixed with this commit https://github.com/micro/go-micro/commit/b39ec4472c0b6da5bcb6c80ab7acabe1da9d4e20


nosurf requires a middleware to be registered

Fix issue #2

I fixed this in the latest commit. Gave you credit too. I didn't want to have to do another commit on this to revert your change to nosurf.NewPure because that change wasn't needed.
Being a sample project it should output as much logging information as possible, the CSRF failure reasons included which the nosurfing alice constructor does over the nosurf.NewPure.
Thanks very much for finding that mispelling. I had given up in the interest in moving on to other things because I couldn't figure out what was going wrong, but I was looking in the totally wrong spot.


Export NeMo FastConformer Hybrid Transducer Large Streaming to ONNX

Following #843
This PR handles the transducer part.

CC @tempops @sangeet2020
Also CC @titu1994
NeMo fuses the decoder + joiner into a single model decoder_joint.
The disadvantage of the fusion is that it increases the computation overhead during decoding.
(I don't see any benefits of the fusion.)
This PR instead exports the decoder and joiner separately.

Hi,
Thanks for the PR.
I tried adding the meta-data and then exporting the model using your script. However, they dont look as expected..I mean the encoder part.
$ python show-onnx-transudcer.py
=========encoder==========
NodeArg(name='audio_signal', type='tensor(float)', shape=['audio_signal_dynamic_axes_1', 80, 'audio_signal_dynamic_axes_2'])
NodeArg(name='length', type='tensor(int64)', shape=['length_dynamic_axes_1'])
-----
NodeArg(name='outputs', type='tensor(float)', shape=['outputs_dynamic_axes_1', 512, 'outputs_dynamic_axes_2'])
NodeArg(name='encoded_lengths', type='tensor(int64)', shape=['encoded_lengths_dynamic_axes_1'])
=========decoder==========
NodeArg(name='targets', type='tensor(int32)', shape=['targets_dynamic_axes_1', 'targets_dynamic_axes_2'])
NodeArg(name='target_length', type='tensor(int32)', shape=['target_length_dynamic_axes_1'])
NodeArg(name='states.1', type='tensor(float)', shape=[1, 'states.1_dim_1', 640])
NodeArg(name='onnx::LSTM_3', type='tensor(float)', shape=[1, 1, 640])
-----
NodeArg(name='outputs', type='tensor(float)', shape=['outputs_dynamic_axes_1', 640, 'outputs_dynamic_axes_2'])
NodeArg(name='prednet_lengths', type='tensor(int32)', shape=['prednet_lengths_dynamic_axes_1'])
NodeArg(name='states', type='tensor(float)', shape=[1, 'states_dynamic_axes_1', 640])
NodeArg(name='74', type='tensor(float)', shape=[1, 'LSTM74_dim_1', 640])
=========joiner==========
NodeArg(name='encoder_outputs', type='tensor(float)', shape=['encoder_outputs_dynamic_axes_1', 512, 'encoder_outputs_dynamic_axes_2'])
NodeArg(name='decoder_outputs', type='tensor(float)', shape=['decoder_outputs_dynamic_axes_1', 640, 'decoder_outputs_dynamic_axes_2'])
-----
NodeArg(name='outputs', type='tensor(float)', shape=['outputs_dynamic_axes_1', 'outputs_dynamic_axes_2', 'outputs_dynamic_axes_3', 1025])

I am missing these meta-data
        "cache_last_channel_dim1": cache_last_channel_dim1,
        "cache_last_channel_dim2": cache_last_channel_dim2,
        "cache_last_channel_dim3": cache_last_channel_dim3,
        "cache_last_time_dim1": cache_last_time_dim1,
        "cache_last_time_dim2": cache_last_time_dim2,
        "cache_last_time_dim3": cache_last_time_dim3,

What could be the reason? Also, why do we need these information in the meta-data? Are these necessary and important to be supported by sherpa-decoder?
thank you

I just added the streaming CTC support for NeMo Hybrid fast conformer transducer+ctc.
Please see https://github.com/k2-fsa/sherpa-onnx/pull/857
I think you can use it as a reference to add the streaming transducer support.

I am missing these meta-data

You can find their usage at
https://github.com/k2-fsa/sherpa-onnx/blob/46e4e5b7acf3c80fd3d849f512d63d4e1f911d80/sherpa-onnx/csrc/online-nemo-ctc-model.cc#L229-L232
https://github.com/k2-fsa/sherpa-onnx/blob/46e4e5b7acf3c80fd3d849f512d63d4e1f911d80/sherpa-onnx/csrc/online-nemo-ctc-model.cc#L239-L240

I tried adding the meta-data and then exporting the model using your script.

Make sure you have followed
https://github.com/k2-fsa/sherpa-onnx/blob/46e4e5b7acf3c80fd3d849f512d63d4e1f911d80/scripts/nemo/fast-conformer-hybrid-transducer-ctc/export-onnx-transducer.py#L88
You have to use
"cache_support": True

in order to export a streaming model.

In case you have any confusions, please see the above screenshot for scripts about exporting streaming and non-streaming models.

thats so detailed explanation. Thank you so much @csukuangfj .
I think for using offline decoding I had set- "cache_support": False, that was the problem. But setting it to true solved the problem.
thanks again!

Hello! @sangeet2020 @csukuangfj I wanted to know if the FastConformer model scripts are available for microphone inference? I see only inference for online from file.
Thanks!

Yes, you can.
Please follow how we use streaming transducers in sherpa-onnx.
All you need to do is to use the model filenames for fast conformer transducers.


DOC: The link in the documentation for the graph operator is broken.

Information

retworkx version: 0.11.0
Python version:
Rust version:
Operating system:

What is the current behavior?
The Graph Operator link within https://qiskit.org/documentation/retworkx/api.html is broken.
Therefore I cannot read the documentation for retworkx.complement(), retworkx.union(), and retworkx.cartesian_product().
What is the expected behavior?
Steps to reproduce the problem
https://qiskit.org/documentation/retworkx/apiref/retworkx.complement.html
https://qiskit.org/documentation/retworkx/apiref/retworkx.union.html
https://qiskit.org/documentation/retworkx/apiref/retworkx.cartesian_product.html

Good catch, it looks like it was an oversight in #544 where we moved from stubs/ to apiref/ for the auto generated api documentation.  This is easy to fix and just requires removing the last reference to stubs in the api.rst.

This is fixed on the development version of the documentation: https://qiskit.org/documentation/retworkx/dev/apiref/retworkx.complement.html#retworkx.complement after the next retworkx release (whenever that is) the released documentation version will be updated.


Update apreq.h

multiply the CPU usage

Why? It seems more readable beforehand.

HI Eric .
This is for the CPU .
multiply and plus.
int x = 5+5; // C
if than faster of
int x = 2*5; // C
and this is for program usage and not for readability .
Thanks .
On Fri, Feb 19, 2021 at 3:52 PM Eric Covener<EMAIL_ADDRESS>wrote:

Why? It seems more readable beforehand.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/apache/httpd/pull/171#issuecomment-782042318, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/ASHDNETCNDIK336RECL755DS7ZJZTANCNFSM4X34OWHA
.

Is there some environment where this affects what happens at runtime?  https://en.wikipedia.org/wiki/Constant_folding

no
code optimization .
read :
https://stackoverflow.com/questions/6879114/multiplication-optimization
On Fri, Feb 19, 2021 at 4:48 PM Eric Covener<EMAIL_ADDRESS>wrote:

Is there some environment where this affects what happens at runtime?
https://en.wikipedia.org/wiki/Constant_folding
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/apache/httpd/pull/171#issuecomment-782068579, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/ASHDNERSULHE7DAD6O2WE2LS7ZQJXANCNFSM4X34OWHA
.

I don't see a benefit here as modern compilers precalculate "static" calculations like this during compilation and in the end the values you calculated manually will be used anyway during runtime. Hence we can use the more readable ones.

yes .
I don't know .
My compiler is gcc .
What is Apache httpd ( Apache http server ) compiler ?
gcc support this technology ( I don't know )
Okay .
Thanks
On Mon, Feb 22, 2021 at 12:46 PM Ruediger Pluem<EMAIL_ADDRESS>wrote:

I don't see a benefit here as modern compilers precalculate "static"
calculations like this during compilation and in the end the values you
calculated manually will be used anyway during runtime. Hence we can use
the more readable ones.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/apache/httpd/pull/171#issuecomment-783223953, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/ASHDNEQP54HX566RAHG7DEDTAIOIDANCNFSM4X34OWHA
.

gcc does these precalculations.


/bin/sh removed from gcr.io/cloudsql-docker/gce-proxy:latest

OCI runtime create failed: container_linux.go:345: starting container process caused "exec: "/bin/sh": stat /bin/sh: no such file or directory": unknown
I've pinned 1.15 for now, but it's not clear to me if this was intentional.

Duplicate of #317


Get spec from somewhere else

/packit copr-build

/packit copr-build

/packit copr-build

/packit copr-build

/packit copr-build


Implement Lowering Platform stepper control with a Raspberry Pi

Written by @austinlake04 :
I'm running into an error when running the lowering platforn server node. This is refering to the node lowering_platform_server.py in the directiory: src/science_servers/science_servers. The class definition is abstracted and can be found in template_servers.py in the same referred to earlier. This earlier is related to the dependency ticlib and the error occurs when initializing the stepper motor driver's object as shown on line 159 in template_servers.py. The error log can be shown below:
Traceback (most recent call last):
File "/home/jasper/dev/osiris_science/install/science_servers/lib/science_servers/lowering_platform_server", line 33, in <module>
sys.exit(load_entry_point('science-servers', 'console_scripts', 'lowering_platform_server')())
File "/home/jasper/dev/osiris_science/build/science_servers/science_servers/lowering_platform_server.py", line 8, in main     boot(LoweringPlatformServer())
File "/home/jasper/dev/osiris_science/build/science_servers/science_servers/template_servers.py", line 159, in __init__     self.driver = TicUSB()
File "/home/jasper/.local/lib/python3.8/site-packages/ticlib/ticlib.py", line 650, in __init__
self.usb.set_configuration()
AttributeError: 'generator' object has no attribute 'set_configuration'


make docker fails for firecamp-cassandra-init

firecamp-cassandra-init.docker-build.log.gz

Fixed! To avoid this from happening again, will delete the original image and build from scratch next time.

Still having issues :(
log.txt.gz

I tried it again. Works for me. Did you retry it? Could you please delete all local cassandra images and try it again?

Not sure why you still hit this issue. The cassandra dockerfile also includes the same build. After update the cassandra dockerfile to the latest, the init dockerfile could be built from cassandra dockerfile. The init task docker file could build from the cassandra dockerfile.

The patch was committed. Please let me know if you still have any issue to build the cassandra init docker image.

Your patch has solved the issue. Thank you!


Support setting LD_LIBRARY_PATH

This is minor, but it would be useful to have an option to set LD_LIBRARY_PATH to include ${Qt5_DIR}/lib. This is useful to run tests, for example. (I note this is only useful for linux, however).

Added in 2.12.0

Added in 2.12.0

Thanks!

Thanks!


Add config option

I need add config paramter to http request, how can I made it?

Which HTTP request are you referring to? There are about 6 $http calls in total.

I use authenticate function but I wat to set options parameter of its http request

+1

@furyscript One way around this until the enhancement gets made is to write an interceptor that adds the config parameter to requests to $authProvider.loginUrl.  Maybe not the most elegant solution, but did the trick for me.


[RV_DM]rv_dm_abstractcmd_testentry

This commit contain changes in #21381 testplan entry.

@rswarbrick kindly review it. Thanks


Opening sandbox terminal changes terminal style and window shape

Investigated using AppleScript and it does exactly the same thing… very weird.

Investigated using AppleScript and it does exactly the same thing… very weird.


Add %v for formatting vectors

Adds %v for formatting vectors. It works similarly to %f but is applied to each component of the vector. Supports all the formatting options that %f does such as amount of decimals and padding. A few examples:

Prints:

It works for Vector2/Vector3/Vector4/Vector2i/Vector3i/Vector4i. It treats the integer vectors as if they were regular vectors, just like %f treats integers. If integer vectors and floating point vectors should be treated different then it would make sense to have it as a seperate formatting character.
Implements https://github.com/godotengine/godot-proposals/issues/4972

Doesn't %f work with integers too? There's no reason to exclude integer vectors.

Doesn't %f work with integers too? There's no reason to exclude integer vectors.

If that works it's likely due to automatic type conversions as the code reads the value as a double.
The integer vectors don't automatically convert to normal vectors as far as I know. I could make %v work with integer vectors as well but it would be intresting to hear what other people think of this.

This should still make it into 4.0 right?

@akien-mga sorry for ping but can this get some sort of review? As the reactions show people are excited for this feature so it would be nice if it could be merged before 4.0 goes into beta and feature freeze.

Woo-hoo, thank you! Manually formatting vectors for print has been super annoying. I need it!
Yes, please support integer vectors as well. The usefulness comes in saving us from typing out every component. Alignment is also valuable. Any decimal points paramers can just be ignored in case the same print code is used for any vector type.
Does it properly handle Nan and INF vectors?

Woo-hoo, thank you! Manually formatting vectors for print has been super annoying. I need it!
Yes, please support integer vectors as well. The usefulness comes in saving us from typing out every component. Alignment is also valuable. Any decimal points paramers can just be ignored in case the same print code is used for any vector type.
Does it properly handle Nan and INF vectors? Does it print arrays of vectors w/ precision? (less important IMO).

Thanks for your support :D
I have updated it to work for integer vectors as well, just like %f works with integers. However if they should be treated differently (without decimals), like %d compared to %f then there should probably be a different formatting char for that. And in that case should there also be a vector version for octal and hexadecimal? It quickly becomes much more complex so lets keep it simple for now.
As for arrays of vectors that is also a different use case, which could be implemented in the future. All other formatting only works on a single typ tho, so it would be a bit confusing for %v to work both on vectors and arrays of vectors.
As for vectors with NaN and INF in them, they aren't really formatted correctly, but that is a problem with %f and should be tracked in its own bug report.
So overall I've tried to keep it simple, by working similarly to %f this can hopefully still make it's way into 4.0.

Looks OK, but you should also added test cases for this to validate it.

I added a bunch of testcases which also made me realised that it didn't work correctly for vectors with negative values, so I fixed that as well.

Thanks!

@MarcusElg : You are awesome. Many thanks!

As for vectors with NaN and INF in them, they aren't really formatted correctly, but that is also a problem with %f as well and should be tracked in its own bug report. They are printed as nan.000000

GDScript: print formatted of INF variable leads to weird output

For support of arrays see:


[refinery] several operators fail, some without an error, if not single quoted

The !=, >, >= operators only work if single quoted, but only >= throws an error - != and > silently pass an empty operator value to refinery, which causes the pods to fail to start.
Versions
Chart: 2.2.0
Helm: v3.12.3
Kubernetes cluster: EKS 1.24
Steps to reproduce
values.yaml contents:
            Conditions:
              - Field: fake.field
                Operator: =
                Value: equal
              - Field: fake.field
                Operator: !=
                Value: not equal
              - Field: fake.field
                Operator: <=
                Value: less than or equal
              - Field: fake.field
                Operator: '>='
                Value: greater than or equal
              - Field: fake.field
                Operator: <
                Value: less than
              - Field: fake.field
                Operator: >
                Value: greater than

helm upgrade --dry-run output:
            - Field: fake.field
              Operator: =
              Value: equal
            - Field: fake.field
              Operator: ""
              Value: not equal
            - Field: fake.field
              Operator: <=
              Value: less than or equal
            - Field: fake.field
              Operator: '>='
              Value: greater than or equal
            - Field: fake.field
              Operator: <
              Value: less than
            - Field: fake.field
              Operator: ""
              Value: greater than

Additional context

This is a result of the way that helm parses YAML files.
The only way I can see to address this would be to create and include a JSON schema for the entire chart. But our nested rules files -- even in the new model -- don't readily fit a JSON schema. I was originally going to try to do Refinery's validation that way and abandoned that approach after a series of roadblocks.
Does anyone have any other ideas? Otherwise, I'm tempted to just include "you should quote these operators" in the helm chart documentation.

@kentquirk I am curious, is this a direct result of helm and yaml or is it bc we run the rules through the tpl function?

YAML is defined so that ! and < are special characters, which messes things up when it's loaded, and Refinery correctly checks that the values it gets after processing are valid choices for operators, which is why it fails to start.
The problem is that YAML is weakly defined, so two of these operators are valid yaml but won't do what you want. The other one is just invalid. So the only fix would be to promote the validation to the operators directly.
As noted in our meeting, we can probably validate just the operator field (although note that it can occur at multiple levels of indentation).


[drake_bazel_external_legacy] Downgrade Bazel to minimum

This gives us better CI coverage of the legacy situation.

This change is

:lgtm: self-stamp.


Fix Markdown link formatting and spacing issues (#260)

This pull request addresses Issue #260 by fixing formatting issues in inline links and improving the handling of spaces around links in text.
Changes Made

Removed Extra Spaces in Links
Unnecessary spaces within inline links have been removed to ensure proper formatting:

Before: `[

2
](https://pubmed.ncbi.nlm.nih.gov/27572733/)`

After: [2](https://pubmed.ncbi.nlm.nih.gov/27572733/)

Added Space Before Links
A space is now added when a link directly follows a block of text, improving readability:

Before: text[1](https://example.com)
After: text [1](https://example.com)

Replaced Multiple Spaces After Links
Consecutive spaces after links are replaced by a single space to maintain clean formatting:

Before:
`native cellular environments 1

2.`

After:
native cellular environments [1](https://blog.delmic.com/subtomogram-averaging-in-the-cryo-et-workflow) [2](https://pubmed.ncbi.nlm.nih.gov/27572733/).

I welcome any feedback or suggestions to improve this pr.

Thanks! However, I don't think this is the right approach. In the original issue the user reference Perplexity URLs where these links are hovering citations similar to Wikipedia. We should use the Markdown footnotes syntax. markdown-converter.ts already has a citations → footnotes converter, but it's not handling this case well.


libpcl install directory is out of sync with velodyne drive dependency path

The libpcl will be installed in the directory

/usr/include/pcl*

and

/usr/lib/libpcl*

However, to build velodyne driver, it depends on the directory

/usr/local/include/pcl*

and

/usr/local/lib/libpcl*

@yuan8421 you can set the softlink in the path /usr/local/include

@fy2462 Thank you for advise. I've already do that. It will be nice if others would not do so.

Should have been fixed by the refactored dockerfile. Please refer to docker/build to have a try and file new issue if there is problem.

@xiaoxq Can I ask which commit fix this issue?

You can check the history of this file: https://github.com/ApolloAuto/apollo/blob/master/docker/build/installers/install_pcl.sh

I just found it. Thx reply though.


Fixes to the Security and Identity article

What's changed, or what was fixed?
In the Security and Identity article,

Replaced "listening into" with the more appropriate "listening in on".
Added missing comma.
Fixed some typos.

CC: @petele

:tada: This has been pushed live to https://developers.google.com/web/


Forceful scrollbar on item creation

Issue
If you just want to create a new item, it already goes over the border and forces a scrollbar.
The same goes for when dragging it to the right.
Expected Behaviour
I would expect that the creation of a new item does not force a scrollbar to appear and I would also expect that when dragging an item over the toolbar, no scrollbar appears.
Screencast

This is an old version issue and is no longer reproducible for me. We can close this issue @FelixTJDietrich @krusche


Back navigates to empty "new tab"

Open new tab (ctrl+t)
Type any website address, hit enter

AR: Observe Back button on the browser's top left corner - it's enabled (and navigates to to that empty "new tab" as well as Backspase click).
ER: Empty "new tab" should not be considered as an item of page back stack

Experiencing this bug as well

Chrome has behaved this way as long as I remember; I don't think it's this extension's job to fix that. Report a bug to the Chrome team instead.

Yeah, don't really think it's a bug too.

This isn't a bug. The new tab page is an actual page. People use it as a quasi home page now with their own favorites and google search. Chrome has always behaved this way.


Es7

upgrade to es7
initially began as es7 flag to upgrade code to but i used the flag to process the code itself.
and then leveraging es7 features to make the process faster

Nice work, thanks a lot! 💪


OneShot in AnimationTree does not return active = false when finished

Godot version:

3.2.2-beta4
OS/device including version:

Issue description:

OneShot node in AnimationTree does not change its "valid" property to false after it finished animation. In preview it does get to false but it won't in code or inspector view.
Steps to reproduce:
Create a OneShot node in an AnimationTree. Set its valid property to true in code. After its animation finishes, it is still as true.
Minimal reproduction project:

Can you provide a reproduction project please? It's much faster to find your issue this way.

This is probably related to the parameter, atleast it's what i noticed:
https://user-images.githubusercontent.com/8841352/111037430-36eb2000-8424-11eb-83f8-5002f56bf877.mp4

Still valid in Godot 3.5.stable.

Probably already fixed for 4.0 but it needs to be fixed for 3.x.

This is currently broken in 4.x, for LinuxBSD at least.  I'd have to move my project over to my Windows machine to see if it is broken there too.  OneShot never unsets active after animation completes..

Can confirm I'm seeing this behavior in v4.0.2.stable.official [7a0977ce2]
Fired off a oneShot animation and it's marked as active indefinitely - no way to know when/if the animation finished via the animationtree

@TokageItLab Shouldn't this have a 4.x milestone since it is not working on that? It is failing for me as well on 4.0.2.

I thought I had this issue in v4.0.2, but I figured out later that it was my own mistake.
I had a Blend2 going to the shot box of the OneShot visual node. Then on the Blend2 I was connecting a run animation with a sword swing.
What happened was that the run is a loop and the sword swing is a non loop. When I had the blend 2 moving only the arms for the sword swing and the blend_amount all the way to the swing, it would cast the animation once, and then keep the arms at the end of the animation of the swing, while the legs kept running.
On the other side of the OneShot, I had run again. The problem is that the shot connection was in fact a loop, so it never finished and never reset the arms.
Be careful not to put a loop on the shot section of the OneShot by mistake.

I had this issue on v4.1.1.stable.official [bd6af8e0e] and found that I needed to enable Sync for the oneshot to be deactivated.
Select the OneShot in AnimationTree and then check this box in Inspector:

The sync property docs say:

If false, the blended animations' frame are stopped when the blend value is 0.
If true, forcing the blended animations to advance frame.

Neither of those settings sound like they should fix this issue, so there may stil lbe a bug here.
(I experienced it while porting the 2d/skeleton project in godot-demo-projects.)


Help to load bounding boxes from script

Hi! great work with the plugin! It is super useful.
I am trying to use napari as a pointcloud visualizer, as part of this task I am doing a small trial on how to visualize bounding boxes. I figured out the way to add bounding boxes from script using:
viewer = napari.Viewer()
viewer.add_points(np.asarray(o3d_pc.points),size=0.05) #loading pointcloud
demo_box = np.asarray(obb.get_box_points())
viewer.add_bounding_boxes(demo_box, edge_width=.3)

this works great only if I have started manually the plugin in the viewer button, if I run the code without manually activating the plugin it would raise an error that viewer does not have attribute add_bounding_boxes. How can I add that to the start of the viewer?
Also, even though I could understand a bit the class boundingboxes layer it would be great if you could provide some info about it, I would be open to do a small example.py to guide on its use.

Hey @JuanIgnacioCG,
the solution is to import napari_bbox before using viewer.add_bounding_boxes:
import napari_bbox
viewer = napari.Viewer()
viewer.add_points(np.asarray(o3d_pc.points),size=0.05) #loading pointcloud
demo_box = np.asarray(obb.get_box_points())
viewer.add_bounding_boxes(demo_box, edge_width=.3)

The reason is that in order to use this custom layer I had to do some very ugly hacking (I add the method add_bounding_boxes to the Viewer class manually). If you want a clearer code, you could do:
from napari_bbox import BoundingBoxLayer
viewer = napari.Viewer()
viewer.add_points(np.asarray(o3d_pc.points),size=0.05) #loading pointcloud
demo_box = np.asarray(obb.get_box_points())
bb_layer = BoundingBoxLayer(demo_box, edge_width=.3)
viewer.add_layer(bb_layer)

Cheers,
David

Thanks a lot David,
it was so simple :,) , I tried with several names in the napari.add_widget... etc. Thanks a lot for the plugin it is super useful!.

No problem! Glad you like it :)


[feature request] add support for approvers

Overview
We’d like to implement a pluggable approvals system within Inspect to provide oversight and control over agent actions, particularly for tool calls and potentially dangerous operations.
Problem Statement
There is a need to implement a flexible approval mechanism for agent actions within Inspect AI to enable real-time monitoring of large agent eval runs, and to allow for human oversight where malice or otherwise interesting behavior is detected.
This will become increasingly useful as agents become more capable and can successfully pursue long horizon tasks using novel approaches. For example, in a task like “Earn 0.01 BTC” that may take a long time and involve many thousands of actions, we would like to avoid having to review each action but would also like to have potentially malicious actions flagged, e.g. if the agent appears to be spinning up a phishing website or writing malware.
In order to have this level of oversight, we need Inspect to support this concept of action approval. These approvals can include set of rules, human-in-the-loop or AI.
Proposed Solution
We do not take opinionated approach whether the approval mechanism should be implemented on the tool or solver level as there are benefits to both. We design the approval mechanism to be  flexible and possible to be used both inside of the tool or or on the solver level with the main interface being the AprroverManager that executes individual Approvers associated with tool calls.
Key Components:

Approvers

Functions that decide whether to accept, reject, terminate or escalate the action.
Approver functions receive TaskState + ToolCall as inputs and return ApproverDecision which is one of the enums:

approve = this actions seems fine, proceed

reject = this action seems malicious or otherwise erroneous, don’t execute it, sample again from the model
escalate = defer the decision to the next Approver
terminate = stop the agent

Approval Manager

ApprovalManager class initialized with a list of one or more Approvers, that it will run when the associated tool is requested, but before the tool is actually executed.
The job of an ApprovalManager is to handle the escalations between approvers, and  logging.
ApprovalManager contains the get_approval(..) method which returns a boolean.

This method executes the first Approver, then:,

if result is approve then return true
if result is reject then return false
if result is terminate then terminate the program (sigterm or return sentinel error or something)
if result is escalate then call the next Approver in the chain

If the Manager returns true then the action will be executed. If the Manager returns false then the action will not be executed and a message will propagate up explaining why

The explanatory message is passed backed to the LLM as output of the tool call.

Technical Considerations
This proposed solution does not need any changes to the inspect source code. In the longer term, to better integrate Inspect properly it’ll be necessary to:

Create async implementation of utils.input_screen() and make the UI async friendly
Implement an Approval extension point so that we can implement approval at higher levels (solver-level, sandbox-level) instead of on (just) on tasks
Hook the approver into the core of tool calling rather than needing new approver-specific tools
Add support for multiple humans concurrently reviewing actions that have gone to the Human-in-the-loop queue (this will be a special Approver that we’ll probably create next)

We might also want to think about:

Allowing n actions after an Approval: We might want to not run all of the Approvers each time a tool is called, especially if the Approver is something like AI-in-the-loop and definitely not if it’s Human-in-the-loop. In this case we may want to allow for a ‘runway’ where a single Approval enables some number of actions to be executed before Approval is requested again.

Different modes of operation for the Approval Managers: By default the Approval Manager will return whatever the first Approver says unless it says says Escalate, in which case it would defer to the next Approver. It might be required in future to have different modes for the Approval Manager. Perhaps we want a mode where we run all the Approvers and check that they all return accept in order to allow the action to execute, or maybe it’s sufficient for a single Approver to accept.

Next steps
We’re happy to implement the first version of approvers integrated into a new bash tool which will enable basic CLI approval for bash commands. We can put an example inside the examples folder. Any comments/suggestions will be much appreciated!
Longer term, we’ve discussed with J.J. that AISI will replace synchronous input with async implementation and then consider implementing improvements to Inspect (Approval extension point, core tool calling integration, async-friendly UI)

Support has been added here https://github.com/UKGovernmentBEIS/inspect_ai/pull/654

FYI we've implemented support for async approver UI here: https://github.com/UKGovernmentBEIS/inspect_ai/pull/958


PSR-2

Just a fixer run commit to match the new coding standard of PrestaShop:
$ php-cs-fixer fix . --level=psr2 --verbose
F.FFFFFFF
Legend: ?-unknown, I-invalid file syntax, file ignored, .-no changes, F-fixed, E-error
   1) gsitemap.php (indentation, elseif, psr0, braces)
   2) translations/index.php (linefeed, indentation, eof_ending)
   3) views/templates/admin/index.php (linefeed, indentation, eof_ending)
   4) views/templates/index.php (linefeed, indentation, eof_ending)
   5) views/index.php (linefeed, indentation, eof_ending)
   6) gsitemap-cron.php (linefeed, indentation, trailing_spaces, braces)
   7) index.php (linefeed, indentation, eof_ending)
   8) upgrade/install-2.2.php (linefeed, indentation, braces, eof_ending)
Fixed all files in 0.989 seconds, 12.000 MB memory used

Thank you for your report! This issue is fixed here: https://github.com/PrestaShop/gsitemap/pull/53


fix: dashboard edit/save errors

SUMMARY
Some functionality on dashboard edit isn't being properly updated in the UI after save, although it is being saved to the DB and shows up on a refresh.
Some items that this fixes:
Dashboard Title when edited in the modal does not refresh on save (done)
Empty json metadata errors silently (done)
If colorScheme is edited in json metadata, it should also update the dropdown in the edit modal and take precedence(done)
label colors in json metadata are not saving properly (done)
Also added wrapping to the json metadata window.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Save title and update color scheme

changing color scheme in metadata updates the dropdown

changing label color in metadata persists after save. You still need to refresh in order to see it updated in the chart, but we can fix that separately.

invalid color scheme string in json metadata shows an error
TEST PLAN
Cypress tests
ADDITIONAL INFORMATION

[x] Has associated issue: https://github.com/apache/incubator-superset/issues/10655
[ ] Changes UI
[ ] Requires DB Migration.
[ ] Confirm DB Migration upgrade and downgrade tested.
[ ] Introduces new feature or API
[ ] Removes existing feature or API

when running cypress locally/dev/docker we still need to change the baseUrl in cypress.json to hit port 8088. Will look into ways to make this configurable.

@eschutho I think @nytai  is working on a larger refactor of this functionality. Have you two talked on this?

yeah, we sorted it yesterday. I'm going to pick up the features that they wanted to add to this branch as well.

Codecov Report

Merging #10834 into master will decrease coverage by 4.93%.
The diff coverage is 3.33%.

@@            Coverage Diff             @@
##           master   #10834      +/-   ##
==========================================
- Coverage   65.76%   60.83%   -4.94%
==========================================
  Files         816      816
  Lines       38396    38413      +17
  Branches     3606     3617      +11
==========================================
- Hits        25253    23368    -1885
- Misses      13035    14859    +1824
- Partials      108      186      +78

Flag
Coverage Δ

#cypress
?

#javascript
61.63% <3.33%> (-0.05%)
:arrow_down:

#python
60.35% <ø> (-1.05%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...erset-frontend/src/dashboard/components/Header.jsx
34.35% <0.00%> (-18.00%)
:arrow_down:

...ntend/src/dashboard/components/PropertiesModal.jsx
38.23% <0.00%> (-22.48%)
:arrow_down:

...explore/components/controls/ColorSchemeControl.jsx
55.17% <ø> (-41.38%)
:arrow_down:

superset-frontend/src/components/EditableTitle.tsx
74.28% <100.00%> (-15.72%)
:arrow_down:

superset-frontend/src/SqlLab/App.jsx
0.00% <0.00%> (-100.00%)
:arrow_down:

superset-frontend/src/explore/App.jsx
0.00% <0.00%> (-100.00%)
:arrow_down:

superset-frontend/src/dashboard/App.jsx
0.00% <0.00%> (-100.00%)
:arrow_down:

superset-frontend/src/explore/index.jsx
0.00% <0.00%> (-100.00%)
:arrow_down:

superset-frontend/src/dashboard/index.jsx
0.00% <0.00%> (-100.00%)
:arrow_down:

superset-frontend/src/setup/setupColors.js
0.00% <0.00%> (-100.00%)
:arrow_down:

... and 208 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eded51b...7f2dead. Read the comment docs.

please excuse the rebase/force push after reviews have started, but I had to revert a binary file from the original commit, and it just seemed the most straightforward way.

@eschutho and @mistercrunch Thanks for the work, but this save flow really confused me. See how Set auto-refresh frequency, Set filter mapping etc works,

when user clicks Save button in the modal, it is only close Modal but not changes are not sent to server-side db
when user clicks Save button on dashboard header, the changes are sent to server-side and saved into dashboards table.

But this Edit dashboard properties flow, saved changes twice:

when user clicks Save button in the modal, it saved changes by calling /api/v1
when user clicks Save button on dashboard header, it saved changes by calling /save_dashboard/
Why does it have to save twice and calls different API?

I think we should have single API do save dashboard metadata job, and all the items in the edit dropdown list should behave the same.

@graceguo-supercat thanks for the additional feedback and they make sense to me. besides only having single API that does the job, we should also change Save label in the modal to Finish or Done to have more distinction from Save button on dashboard header.

There are some discussions around improving the UI here as part of a larger effort. @junlincc, let's sync on what we can tackle now vs later. Is anything here valuable to roll out in the short term?

Thanks for the feedback, too, @graceguo-supercat. I think @junlincc said that she touched base with you about improving those usability issues in a larger feature-improvement effort in the next round. Let me know if we want to move forward with any of these fixes in the near term.

Codecov Report

Merging #10834 into master will decrease coverage by 1.45%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #10834      +/-   ##
==========================================
- Coverage   61.50%   60.04%   -1.46%
==========================================
  Files         834      393     -441
  Lines       39557    24836   -14721
  Branches     3610        0    -3610
==========================================
- Hits        24329    14913    -9416
+ Misses      15047     9923    -5124
+ Partials      181        0     -181

Flag
Coverage Δ

#javascript
?

#python
60.04% <ø> (-0.74%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

superset/db_engines/hive.py
0.00% <0.00%> (-85.72%)
:arrow_down:

superset/db_engine_specs/hive.py
53.90% <0.00%> (-30.08%)
:arrow_down:

superset/db_engine_specs/presto.py
69.76% <0.00%> (-12.32%)
:arrow_down:

superset/db_engine_specs/mysql.py
79.59% <0.00%> (-12.25%)
:arrow_down:

superset/examples/world_bank.py
97.10% <0.00%> (-2.90%)
:arrow_down:

superset/examples/birth_names.py
97.59% <0.00%> (-2.41%)
:arrow_down:

superset/views/database/mixins.py
80.70% <0.00%> (-1.76%)
:arrow_down:

superset/models/core.py
87.43% <0.00%> (-1.68%)
:arrow_down:

superset/views/core.py
73.98% <0.00%> (-0.49%)
:arrow_down:

superset/connectors/sqla/models.py
89.47% <0.00%> (-0.27%)
:arrow_down:

... and 437 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9aef9c5...b366ff7. Read the comment docs.

retry tests

I rebased so that we can bring in the changes from https://github.com/apache/incubator-superset/pull/11220 into this PR. Everything here still saves when you close the modal, even after refreshing the dashboard without a save.

Hi @eschutho Thanks for the work!
Yes #11220 and #11305 caused conflicts for this PR, and we can make this PR work with it. The idea of preventing co-edit is, when dashboard is loaded, it carries the last_modified_time which was stored in the database. When user edit dashboard, we send out this last_modified_time with all the updates. /save_dash/ endpoint compares the last_modified_time from incoming request with current database: if incoming last_modified_time < current data, the dashboard is changed since user open dashboard, so the save request will be rejected.
So for the Dashboard Properties modal, right now the problem is it didn't send last_modified_time information when it calling /save_dash/ request, which happens after the first save is done. Dashboard Properties modal didn't use redux store, but you can manually add this parameter like this:
https://github.com/apache/incubator-superset/blob/8863c939ad01fe1e065ce60edc93a683e6828d80/superset-frontend/src/dashboard/reducers/dashboardState.js#L110
this can make sure the incoming request always newer than database record.

Sounds great, @graceguo-supercat. The fixes here are mostly around the modal save, although there are a few changes to the label colors on the second save that may not have an effect on the overall scope if the user doesn't save afterward. The edit property modal changes still work, though. I know that there are larger usability issues here to address around the double save. I wasn't necessarily trying to address any of the dashboard save issues in this PR, but if you think it would be beneficial to address that issue here as well, I definitely can. Would that be your preference?

I discussed this PR with PM in airbnb, we think should just fix the save dashboard metadata issue in this PR. For 2 save dashboard calls, it needs a bigger code refactor, we should address it later when we have a chance. Thanks!

Sounds great. Should we add your suggestion regarding timestamps in this PR or a future one?

Sounds great. Should we add your suggestion regarding timestamps in this PR or a future one?

should be in this PR. Otherwise after user save changes in Dashboard Properties modal, they will see error message (but actually changes are saved).

Thanks for the work! this PR is good now.

Great, thanks for your help @graceguo-supercat. Do you mind merging when ready? 🙏


group.list oldest is not working

Description
I've set the 'oldest' date to more than a month and the latest to current date. But it only fetches only one day data.
date_from = '2018-01-01' date_to = '2018-02-02' a = 'channels.history' oldest = (datetime.strptime(date_from, "%Y-%m-%d") - datetime(1970, 1, 1)).total_seconds() latest = (datetime.strptime(date_to, "%Y-%m-%d") - datetime(1970, 1, 1)).total_seconds() history = sc.api_call(a, channel=channel_id, oldest=oldest, latest=latest)
What type of issue is this? (place an x in one of the [ ])

[ x] bug
[ ] enhancement (feature request)
[ x] question
[ ] documentation related
[ ] testing related
[ ] discussion

Requirements (place an x in each of the [ ])

[ ] I've read and understood the Contributing guidelines and have done my best effort to follow them.
[ ] I've read and agree to the Code of Conduct.
[ ] I've searched for any related issues and avoided creating a duplicate issue.

Bug Report
Filling out the following details about bugs will help us solve your issue sooner.
Reproducible in:
slackclient version:
python version:
OS version(s):
Steps to reproduce:

Expected result:
What you expected to happen
Actual result:
What actually happened
Attachments:
Logs, screenshots, screencast, sample project, funny gif, etc.

Ah, this is an issue with how slackclient converts most params to strings before submitting... I'll fix this.

Thanks much Roach
On Tue, 6 Feb 2018 at 5:48 AM, Roach<EMAIL_ADDRESS>wrote:

Ah, this is an issue with how slackclient converts most params to strings
before submitting... I'll fix this.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/slackapi/python-slackclient/issues/283#issuecomment-363266219,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AcpLAyebCNLa1KSNzpVB_Rbu0ytmBuTrks5tR5pCgaJpZM4R3KCj
.

Note to self: attachments and dialogs are the only fields that need to  be converted to JSON strings

https://github.com/slackapi/slack-api-specs/blob/master/web-api/slack_web_openapi_v2.json

Fixed in 293, merged and released in 1.1.3

Many thanks Roach!!
Pleasure to use this handy package in our scripts :)
On Fri, Mar 2, 2018 at 4:21 AM, Roach<EMAIL_ADDRESS>wrote:

Fixed in 293, merged and released in 1.1.3
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/slackapi/python-slackclient/issues/283#issuecomment-369758989,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AcpLA1oNcran8x-1KBxrThPtY8A3wqh1ks5taHt-gaJpZM4R3KCj
.


validation error using nested parameters

Environment

FAST RPM Version: 1.5.0
BIG-IP Version: 15.1.2

Summary
Unable to nest parameters unless you have more than one loop
Steps To Reproduce
Create a nested templated
title: nested test
description: nested test
definitions:
  parent:
    title: parent
    description: parent
    type: array
  child:
    title: child
    description: child
parameters:
  parent: ["1","2","3"]
  child: hello

template: |
    {{ #parent }} {{ . }} {{ child }}{{ /parent }}

error
Failed to render template:
Error: Parameters failed validation:
{}

Validation error:
[
  {
    "keyword": "type",
    "dataPath": ".parent[0]",
    "schemaPath": "#/properties/parent/items/type",
    "params": {
      "type": "object"
    },
    "message": "should be object"
  }
]
    at Template.validateParameters (/home/erchen/projects/fast/node_modules/@f5devcentral/f5-fast-core/lib/template.js:910:19)
    at Template.render (/home/erchen/projects/fast/node_modules/@f5devcentral/f5-fast-core/lib/template.js:948:18)
    at /home/erchen/projects/fast/node_modules/@f5devcentral/f5-fast-core/cli.js:97:26

workaround
title: nested test
description: nested test
definitions:
  parent:
    title: parent
    description: parent
    type: array
  child:
    title: child
    description: child
parameters:
  parent: ["1","2","3"]
  child: hello

template: |
    {{ #parent }} {{ . }} {{ child }}{{ /parent }}
    {{ #parent }} {{ . }} {{ /parent }}

output
 1 hello 2 hello 3 hello
 1  2  3

Expected Behavior
ability to use nested elements in a single loop
Actual Behavior
error output

Thanks for reporting this issue. We are now tracking this bug internally with ID MYSTIQUE-342.

This appears to be working as intended. Variables found inside of a section are scoped to that section. In this case, FAST is looking for parent to be an array of objects with the properties . and child. Passing in an array of strings is indeed not valid. Something like this would work:
parameters:   parent:     - .: 1       child: hello     - .: 2       child: hello     - .: 3       child: hello
However, FAST does not currently provide a way to say a variable/parameter should be pulled from a global scope versus the local section's scope.

Closing. Please reopen if this continues to be an issue for you.