Date range selector not rendering selection when using format props

Example
Expo snack for reproduce able example: https://snack.expo.dev/@djoech/flash-calendar-format-bug
Description
Not sure if I am using the library wrong in some way or if it is an actual bug, however I can reproduce it in the snack.
I am saving a date-range selection into my context to share it across views. However once I start using <Calendar /> with a pre-selected date range useDateRange({ startId, endId }) the range will not be rendered correctly when I use any format props like  getCalendarDayFormat, getCalendarMonthFormat or getCalendarWeekDayFormat.
It renders correct if I use both without the other one, but together the bug occurs.
The date range flickers and then proceeds to not be rendered.
Example Code
import { Text, SafeAreaView, StyleSheet } from 'react-native';
import { Calendar, toDateId, useDateRange } from "@marceloterreiro/flash-calendar";
import { format } from 'date-fns'
import { useState, useEffect } from "react";

const today = toDateId(new Date());

export default function App() {
  // This state is simplified for the example. In my case it would come from a context.
  const [start, setStart] = useState(today);
  const [end, setEnd] = useState(today);

  const {
    onCalendarDayPress,
    isDateRangeValid,
    calendarActiveDateRanges,
  } = useDateRange({ startId: start, endId: end }); // I am setting the default range here because I want the data from my context to be pre-selected here

  useEffect(() => {
    // Every time the selected range changed I want to update my context (in this example the state)
    if (isDateRangeValid && calendarActiveDateRanges.length > 0) {
      const range = calendarActiveDateRanges[0];
      setStart(range.startId)
      setEnd(range.endId)
    }
  }, [calendarActiveDateRanges, isDateRangeValid]);

  return (
    <SafeAreaView>
      <Calendar
        // Any format function causes the range picker to not render correct after completing a selection
        getCalendarWeekDayFormat={
          date => format(date, "EEEEEE")
        }
        calendarColorScheme="light"
        calendarMonthId={today}
        calendarFirstDayOfWeek="monday"
        calendarActiveDateRanges={calendarActiveDateRanges}
        onCalendarDayPress={onCalendarDayPress}
      />
    </SafeAreaView>
  );
}

Let me know if I can help in some way!

Hi @zwenza, thanks for reporting it, and for providing the code to repro. I was able to investigate and understand the problem. Turns out it's being caused by the arrow function, which breaks referential equality:
https://github.com/user-attachments/assets/aae8f795-6611-46d0-841b-8fd6e20a089b
The reason this happens is due to the mechanism used by Flash Calendar to avoid re-rendering days unaffected by the selected range. Instead of a plain-old React state, I'm using an event-emitter to publish the range, and only the relevant days consume this event.
Why does referential equality matter?
When you use an arrow function for the date formatting, you break referential equality, and React thinks your Calendar updated. This causes BaseCalendar to re-render, and by consequence, the CalendarItemDay component.
Once CalendarItemDay re-renders, this line gets called, and resets the date range. It would require the event to be re-published.
Even though BaseCalendar re-rendered, the top-level component (Calendar) is stable, and does not re-render. This means the event does not get re-published.
You don't have to understand this part though, I'm only explaining in case you're curious. Avoiding re-renders was one of the most challenging pieces of Flash Calendar, and required this unconventional pub/sub approach 🙂.
I added some light docs on this here: #72
Let me know if it solves your problem!

Thank you very much for the explanation @MarceloPrado this makes perfectly sense!
And great addition to the docs in case someone stumbles over the same problem 👍


Unable to load the API using my project options

Team,
I have performed the following steps:
1-used ./gradlew bootRun, I am able to launch an instance of Burp.
Following instructions in https://github.com/vmware/burp-rest-api/issues/6 and https://github.com/vmware/burp-rest-api/issues/11.
2-copied my project and user options into "src/main/resources/static/" and then ran the gradlew executable present in the folder structure

What would be my next steps to run burp scans?

Fixed in https://github.com/vmware/burp-rest-api/pull/28


Network Authentication

Problem Description
To achieve the network authentication, it's required to detect the mobile number automatically, which will be fulfilled using header enrichment (Add requester mobile number) through network for the incoming request.
The service should be exposed using HTTPS, which prevent header enrichment.
any clue how to avoid this problem, without publish the service using HTTP (rejected from security perspective)?
Thanks

Hi @mohamedsaeedstc !
there are alternatives to header enrichment that are currently available.
The clue here is to find a solution which helps to identify Private IP address of a device and map it with MSISDN. Some potential options are:

AAA Server
GGSN
PCRF
RADIUS broadcast
SCEF

It gets more tricky when device is connected to WiFi - then it requires some special handling on a device side, e.g. force auth request to go over Mobile Data, or use EAP-AKA with a SIM.
I'm closing this issue, as this topic has been discussed several times.
I'd be happy to support, if you have more questions.

Hi @mohamedsaeedstc !
there are alternatives to header enrichment that are currently available. The clue here is to find a solution which helps to identify Private IP address of a device and map it with MSISDN. Some potential options are:

AAA Server
GGSN
PCRF
RADIUS broadcast
SCEF

It gets more tricky when device is connected to WiFi - then it requires some special handling on a device side, e.g. force auth request to go over Mobile Data, or use EAP-AKA with a SIM.
I'm closing this issue, as this topic has been discussed several times.
I'd be happy to support, if you have more questions.

@DT-DawidWroblewski : by using above options we can only validate the private IP & mobile number of the subscriber but further validation with destination IP/Server would not be feasible could you pls explain little bit more on this.


KYLIN-3987 Set a larger value of reducer num for fact distinct job

Can one of the admins verify this patch?

Codecov Report

Merging #621 into master will increase coverage by <.01%.
The diff coverage is 0%.

@@             Coverage Diff              @@
##             master     #621      +/-   ##
============================================
+ Coverage     25.33%   25.33%   +<.01%
  Complexity     5839     5839
============================================
  Files          1379     1379
  Lines         81808    81808
  Branches      11465    11465
============================================
+ Hits          20722    20723       +1
+ Misses        59061    59060       -1
  Partials       2025     2025

Impacted Files
Coverage Δ
Complexity Δ

.../java/org/apache/kylin/common/KylinConfigBase.java
13.08% <0%> (ø)
42 <0> (ø)
:arrow_down:

...rg/apache/kylin/cube/inmemcubing/MemDiskStore.java
69.6% <0%> (+0.3%)
7% <0%> (ø)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c42aafd...017dbdf. Read the comment docs.

Pull Request Test Coverage Report for Build 4425

0 of 1 (0.0%)  changed or added relevant line in 1 file are covered.
4 unchanged lines in 1 file lost coverage.
Overall coverage increased (+0.001%) to 27.811%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

core-common/src/main/java/org/apache/kylin/common/KylinConfigBase.java
0
1
0.0%

Files with Coverage Reduction
New Missed Lines
%

core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/MemDiskStore.java
4
78.12%

Totals

Change from base Build 4423:
0.001%

Covered Lines:
22752

Relevant Lines:
81808

💛  - Coveralls


How did you successfully declare a dependency on sc.fiji:Trainable_Segmentation?

When I try to declare a dependency on Trainable_Segmentation, I get the following error Could not find artifact sc.fiji:Trainable_Segmentation:pom:3.2.33 in central (https://repo.maven.apache.org/maven2)

Are there any unique steps you had to take to make the dependency resolution go through?
Thanks

Trainable weka segmentation is not supplied via maven central.
It comes via scijava:
https://imagej.net/develop/maven#repositories


[VL] A bug about replacing spark sort agg with gluten hash agg

Backend
VL (Velox) and  CH(ClickHouse)
Bug description
When the Final SortAggregate fallback, the Partial SortAggregate should also fallback to ensure data accuracy
A test query:
SELECT  T1.l_partkey,
        T2.p_comment,
        COALESCE(T2.active_label, T1.l_partkey) AS active_label
FROM    $table T1
LEFT JOIN
        (
            SELECT  t1.l_partkey l_partkey,
                    NULL active_label,
                    MAX(t1.p_comment) AS p_comment
            FROM    $table t1
            LEFT JOIN
                    $table t2
            ON      t1.l_partkey = t2.l_partkey
            GROUP BY
                    t1.l_partkey
        ) T2
ON      T1.l_partkey = T2.l_partkey

Spark version
None
Spark configurations
No response
System information
No response
Relevant logs
No response

Does this lead to inaccurate query results?

Does this lead to inaccurate query results?

Yes.

@weixiuli thanks, did you happen to check the reason why final sort agg is not converted to hash based?
thanks, -yuan

@weixiuli thanks, did you happen to check the reason why final sort agg is not converted to hash based?

The cause is that the active_label output of the Final agg is a NullType, and the Final agg is not supported.

@weixiuli thanks for sharing, saw the issue now. Maybe fixed with
https://github.com/oap-project/gluten/pull/2996
thanks, -yuan

Related issue: https://github.com/oap-project/gluten/issues/3391.


[8.x] Make:model --all flag would auto-fire make:controller with --requests

Following up on my recently-merged PR about --requests flag, I received at least a few comments on my Youtube/Twitter that it would be beneficial to include Form Requests generation when launching php artisan make:model Post --all (or -a for short).

Thanks for contributing to Laravel! ❤


Add Inbound Parse data parser #303

An attempt of tackling issue #303. I've also pretty much done the bulk of the work around the Inbound Server Example and Send module, but will create separate PRs to make the reviewing easier.
Essentially my best effort of porting the python parse class to node (https://github.com/sendgrid/sendgrid-python/blob/master/sendgrid/helpers/inbound/parse.py)
Changelog:

Adds mailparser npm dependency (required for parsing raw emails)
Adds parse.js module
Adds simple unit tests of the parse module

Example usage:
var Parse = require('sendgrid').parse;
var config = {
  keys: ['to', 'from', 'subject']
};

var parse = new Parse(config, request);

// Get Key Values
console.log(parse.keyValues());

// Get Attachments
parse.attachments(function(attachments) {
  console.log(attachments)
});

NB: I've sent email with my signed CLA, awaiting confirmation

Thanks again @jamsinclair for the PR,
Please take a moment to fill out this form so that we can send you some swag :)
With Best Regards,
Elmer


Upgrade to latest sbt-spiewak-sonatype

Codecov Report

Merging #102 (7a02cfe) into main (a144809) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #102   +/-   ##
=======================================
  Coverage   96.44%   96.44%
=======================================
  Files           5        5
  Lines         676      676
  Branches       57       57
=======================================
  Hits          652      652
  Misses         24       24

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a144809...7a02cfe. Read the comment docs.

Interesting that scala steward didn't see this.


Johndanz/ch8887/standardize-all-modals-with-new-design

https://app.clubhouse.io/augur/story/8887/standardize-all-modals-with-new-design
Lots of redesign work here, please check thoroughly through the various modals for any css quirks. Everything should be responsive and work on mobile as well.

This pull request introduces 3 alerts and fixes 1 when merging fef6c31835ec615484e008867a6e8da46158a622 into 4f0ca7af4b1556f509eb306fed9e202c9deafaf8 - view on LGTM.com
new alerts:

2 for Potentially inconsistent state update
1 for Superfluous trailing arguments

fixed alerts:

1 for Potentially inconsistent state update

Comment posted by LGTM.com

Coverage decreased (-0.03%) to 62.044% when pulling fef6c31835ec615484e008867a6e8da46158a622 on johndanz/ch8887/standardize-all-modals-with-new-design into 4f0ca7af4b1556f509eb306fed9e202c9deafaf8 on master.

Coverage decreased (-0.03%) to 62.044% when pulling fef6c31835ec615484e008867a6e8da46158a622 on johndanz/ch8887/standardize-all-modals-with-new-design into 4f0ca7af4b1556f509eb306fed9e202c9deafaf8 on master.

This pull request introduces 3 alerts and fixes 1 when merging 880a0b57d76c7b54c160fb9f17ecd76d8cfafdfd into 10035a72b082c2a54f9bc5542e4edd63d42eab9b - view on LGTM.com
new alerts:

2 for Potentially inconsistent state update
1 for Superfluous trailing arguments

fixed alerts:

1 for Potentially inconsistent state update

Comment posted by LGTM.com


feature flag the sharded queue

Is your feature request related to a problem? Please describe.
The sharded queue will certainly make the reconciliation process go much faster for resources since they do not have to share the same queue. However, downstream users may need time to adjust their modules to accommodate to this enhancement. We need to feature flag this feature so that users can switch when they are ready. In the future we can talk about deprecation and switching to only the sharded queue but we will play it by ear.
Definition of done:

[ ] docs around the env var
[ ] default to be the standard queue
[ ] an env var to switch to sharded queue

Describe the solution you'd like

Given the sharded queue comes out for reconcile and module authors are not ready for the change bc it would break their modules
When they update and bring in the newest release
Then they have the ability to turn off the sharded queue should they not be ready for it.

Describe alternatives you've considered
(optional) A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.

Working branches:

pepr  / 1019 (just continuing the partially-complete feature Case started)
pexex / 1019 (because identical branch names are easier to correlate across repo)


Named Query usage

instead of embedding the queries in the python code read them via the querymanager (currently implemented using yaml files)
start with Wikidata-Events query

add queries for Wikidata-Eventseries and GND-Events


Update configuration table

Closes #238
Replaces PR #239
Updates the table in the Configuration section with elements from the values.yml file.
This PR also adds a Python script that merges the descriptions in the current README.md file with elements from the values.yml and writes a new table in markdown to STDOUT.
$> git clone https://github.com/galaxyproject/galaxy-helm.git
$> cd galaxy-helm
$> python3 scripts/values_table.py ./README.md galaxy/values.yml > configuration.md

Thanks @ksuderman Looks great!


How to manage Oracle application sessions using WinAppDriver?

Hello all!
I've just discovered WinAppDriver capabilities to automate Windows applications,
My current effort is to investigate if WinAppDriver can properly handle various Oracle applications which all spawn from a single Oracle desktop application. So my questions are so far:

Are there any recommended ways to create and use dedicated WindowsDriver sessions ?

Should there be a one-to-one correspondence between one WindowsDriversession and one Oracle application ?

Should I firstly create a app=Root session before any other session? And should it have such similar details?
getAutomationName: null
getTitle: Desktop
getSessionDetails: {app=Root, platformName=Windows}
getWindowHandle: 0x00010010
getWindowHandles[]

Note: The main Oracle application into discussion here can be associated with such a session:
getAutomationName: null
getTitle: CS - Login
getSessionDetails: {app=C:\Program Files (x86)\Java\jre1.8.0_25\bin\jp2launcher.exe, platformName=Windows}
getWindowHandle: 0x00060B40
getWindowHandles[0x00060B40]

Is there a Java library of methods to handle a complex flow of user interactions between such non-native Windows application sessions?

Thanks in advance for any feedback on this matter!
Cheers,
Vladimir

Hi @vfilipescu,
Great to have you on-board. Please see the following sequential responses to your questions -

You can refer to our samples here as a resource on session creation and handling.

You can instantiate a session for each unique top-level Window you want to target - one way would be to use a desktop session and attach to different app-windows accordingly.

This is commonly referred to as the desktop session, and would depend on your particular use case. You can read more about instantiating a desktop/root session on our FAQ here. It doesn't necessarily matter when you create the desktop session.

You can take a look at our Java Calculator Sample for further reference on this - I recommend leveraging the Selenium-WebDriver JARs and the appium java client library. You'll want to use the import io.appium.java_client.windows.WindowsDriver; namespace.

Feel free to reach out for any further questions!


how to disable full screen notification

how to disable full screen notification

Hi! What notification are you talking about? The one that says something like: "yourdomain has requested full screen, allow or cancel"?
If so, that message is from the standard itself, and its a security measure that you cannot avoid

Im closing this for now, if you have further comments I'll reopen


Models

Describe the solution you'd like
Models such as a Post or User model that can be extended for CPTs and such. A Model class would provide an expressive interface for interacting with the WordPress tables rather than using the fragmented and inconsistent APIs provided by core.
For example:
// current way
$post = get_post(1);

echo $post->post_title; // title
echo get_permalink($post->ID); // permalink
echo get_the_post_thumbnail_url($post->ID, 'post-thumbnail'); // featured image

// new way
$post = new Post(1);

echo $post->title; // title
echo $post->permalink; // permalink
echo $post->featuredImage('post-thumbnail'); // featured image

WP_User, WP_Term, WP_Post could all be expanded on in some way to reduce the need for global helper functions. A better naming convention could also be utilized ($post->post_name doesn't adequately describe "slug" for instance). Following from Laravel's Model class, accessors, mutators, casts and more could be utilized for simple development.
Describe alternatives you've considered
Using the WP APIs has some cognitive load to remember the names of functions, the accepted parameters (WP functions quite often accept multiple types for one parameter), the error handling and other quirks such as using global $post or requiring an ID to be passed. It is possible (obviously) to use the core functions but a Model class would be nicer to write.
Additional context
Custom tables could also possibly also extend the Model class. It may be required to have a base class and then WP "models" extending this so the underlying model is table-agnostic.
A DB query builder would be able to return results with the correct models, simplifying queries, result manipulation etc. For the sake of keeping the feature request a manageable size, I suggest building out the Model first - WP_Query can be piped through a transformer to hydrate the models in order to use the underlying models, and the a query builder can be implemented at a later date.

For release in v2
AuthManager should have the option of returning a User model rather than WP_User. Set in the config.


Zellic passkey audit remediation

Fixes for all concern raised by Zellic team

3.1 The signature verification method Secp256r1.Verify doesn't check if the R and S !=0, which can lead to bypass the trivial signature.
3.2 Update the incorrect decoding of signature in _verifySignature method which will result in failing of transactions.
3.3 Google's Wycheproof have test vectors which should be run on all cryptography libs. Added the tests with the test vector dump
3.4 Remove the 1500 gas limit. We used the 1500 with estimations of EIP2165 (update precompile with gas optimisation) but some chains like BSC (will add on Aug 31, 23) don't support it and some transactions might fail with low gas limit on these chains.

please add the description in PR also when you have time.

TODO:

3.5 Secp256r1 curve test failure, while running the whycheproof it fails for these cases

Extreme value for k and s^-1 - Sage Script
k*G has a large x-coordinate

Recommendations:
The likely culprit is lack of consideration for the point at infinity when adding or doubling with modified Jacobians. The code comments link to the website Point-at-Infinity where the optimized algorithm used in the code is broken down. Some of the conditionals, where an early return POINT_AT_INFINITY is reached, are missing from the contract code. These checks should be implemented properly to check if the point at infinity occurs during calculations.
We also strongly reccommend to implement comprehensive test cases that go be- yond test vectors but also target edge cases in the calculations.

have we added test cases mentioned by audit (some edge cases) as negative test cases?

why there is this one json file added as part of the tests?

why there is this one json file added as part of the tests?

As mentioned in audit all the cryptographic curve should pass the Wycheproof test's cases. This json is taken from - https://github.com/google/wycheproof/blob/master/testvectors/ecdsa_secp256r1_sha256_test.json

TODO:

3.5 Secp256r1 curve test failure, while running the whycheproof it fails for these cases

Extreme value for k and s^-1 - Sage Script
k*G has a large x-coordinate

Recommendations: The likely culprit is lack of consideration for the point at infinity when adding or doubling with modified Jacobians. The code comments link to the website Point-at-Infinity where the optimized algorithm used in the code is broken down. Some of the conditionals, where an early return POINT_AT_INFINITY is reached, are missing from the contract code. These checks should be implemented properly to check if the point at infinity occurs during calculations. We also strongly reccommend to implement comprehensive test cases that go be- yond test vectors but also target edge cases in the calculations.

@AmanRaj1608 did you inform Kawach about this?

name of the PR has been changed but not the branch name


[haste] Don’t match directories that begin with a whitelisted pattern

The haste map implementation would include directories that start with a whitelisted directory name, e.g. 'parse5' for `{providesModuleNodeModules: ['parse']}'.

@facebook-github-bot shipit

Thanks for importing. If you are an FB employee go to Phabricator to review.


🪄 Enhancement - Can antd-phone-input work with react-hook-form?

Summary
Hi team,
I try to using antd-phone-input with react-hook-form.
It's not fill data into component
do you have any solution for this one?
and my code like below
useEffect(() => {
   reset({ ...formData } as object);
}, [formData, reset]);

<Form.Item
      label={'Phone number'}
    >
      <Controller
        name={'phone'}
        render={({ field }) => (
                <PhoneInput
                  size="large"
                  enableSearch
                  disableParentheses
                  {...field}
                />
              )}
      />
    </Form.Item>

Thank a lot

Hi @giangtran8396, please refer to [this][https://github.com/typesnippet/antd-phone-input/issues/64#issuecomment-1855867861]  answer.

Hi @ArtyomVancyan thank you. I will check right now


Upgrade terraform-provider-azurerm to v3.98.0

This PR was generated via $ upgrade-provider pulumi/pulumi-azure --kind=all --target-bridge-version=latest.
Manual changes:

Patch 5, internal/services/cosmos/cosmosdb_cassandra_cluster_resource_test.go: remove a non-existing Cassandra test and add two others
Patch 5, internal/services/network/virtual_network_resource_test.go: remove duplicate funcs TestVirtualNetworkResource_tagCount and tagCount (not sure why they were duplicated)
Patch 5, internal/services/storage/storage_account_data_source.go: adapt to API changes in code added by patch
resources.go: new mapping for static_web_app_function_app_registration

Upgrading terraform-provider-azurerm from 3.97.1  to 3.98.0.
Fixes #1931

/release minor


JWT expiration time is too short

Currently, the JWT expires in only 10 seconds. This makes debug/testing so struggling.
Could we have JWT expires in, for example, 1 min, which will not affect security significantly but can make the life of development much easier?

it's optional in security.toml


Error: Cannot find module 'generate-function'

Error: Cannot find module 'generate-function'
at Function.Module._resolveFilename (module.js:472:15)
at Function.Module._load (module.js:420:25)
at Module.require (module.js:500:17)
at require (internal/module.js:20:19)
at Object. (C:\Users\Admin\AppData\Roaming\npm\node_modules\ionic\node_modules\ionic-app-lib\node_modules\cordova-lib\node_modules\npm\node_modules\request\node_modules\har-validator\node_modules\is-my-json-valid\index.js:2:14)
at Module._compile (module.js:573:32)
at Object.Module._extensions..js (module.js:582:10)
at Module.load (module.js:490:32)
at tryModuleLoad (module.js:449:12)
at Function.Module._load (module.js:441:3)
Mind letting us know? https://github.com/driftyco/ionic-cli/issues

this error is occurring again and again. I have tried everything bt no use. Please help me to resolve the error. Thank you.

Could you provide me with the output from ionic info from within your project directory as well as the command you are running? Thanks, this should help in troubleshooting.

Sir, this is my output from "ionic info"
Dependency warning - for the CLI to run correctly,
it is highly recommended to install/upgrade the following:
Please install your Cordova CLI to version  >=4.2.0 npm install -g cordova

Your system information:
You have been opted out of telemetry. To change this, run: cordova telemetry on.
6.4.0
Ionic Framework Version: 2.0.0-rc.3
Ionic CLI Version: 2.1.13
Ionic App Lib Version: 2.1.7
Ionic App Scripts Version: 0.0.45
ios-deploy version: Not installed
ios-sim version: Not installed
OS: Windows 10
Node Version: v7.1.0
Xcode version: Not installed

Dependency warning - for the CLI to run correctly,
it is highly recommended to install/upgrade the following:
Please install your Cordova CLI to version  >=4.2.0 npm install -g cordova


Invalid argument supplied for foreach() in dtatables code

Summary of problem or feature request
I'm trying to use laravel-datatables for displaying entires of report. There will be many reports so I want to filter based on join. Also I want to denormalize some fields from report sections, so that "entries" contain all the data.
I get:
Invalid argument supplied for foreach()

yajra/laravel-datatables-oracle/src/DataTables.php line 52
Code snippet of problem
return DataTables::of(
            StatusReportEntry
                ::join(
                    'status_report_sections',
                    'status_report_entries.status_report_section_id',
                    '=',
                    'status_report_sections.id'
                )
                ->where('status_report_sections.status_report_id', '=', $report_id)
                ->select('status_report_entries.*', 'status_report_sections.title AS status')
        )->make(true);

System details

Kubuntu 16.04
PHP 7.0
Laravel Version 5.4.28
Laravel-Datatables Version 8.0.1

Were you able to follow the upgrade guide? https://yajrabox.com/docs/laravel-datatables/master/upgrade
I think your config is not updated. You need to force publish the new config.

Yeah. php artisan tinker config('datatables.builders') => null
It's fresh install. I followed guide on repo readme.markdown
Configs didn't copy, so I copied it manually.

php artisan vendor:publish --tag=datatables --force
Does nothing. No files changed.

I have those twe entries in app.php:
Yajra\DataTables\DataTablesServiceProvider::class,

'DataTables' => Yajra\DataTables\Facades\DataTables::class,

Works fine for me. Currently upgrading an app.
yajra@yajra-mbp: php artisan vendor:publish --tag=datatables --force
Copied File [/vendor/yajra/laravel-datatables-oracle/src/config/datatables.php] To [/config/datatables.php]
Publishing complete.

Maybe try rediscovering the package?
php artisan package:discover

This the new config should look like:
<?php

return [
    /**
     * DataTables search options.
     */
    'search'         => [
        /**
         * Smart search will enclose search keyword with wildcard string "%keyword%".
         * SQL: column LIKE "%keyword%"
         */
        'smart'            => true,

        /**
         * Multi-term search will explode search keyword using spaces resulting into multiple term search.
         */
        'multi_term'       => true,

        /**
         * Case insensitive will search the keyword in lower case format.
         * SQL: LOWER(column) LIKE LOWER(keyword)
         */
        'case_insensitive' => true,

        /**
         * Wild card will add "%" in between every characters of the keyword.
         * SQL: column LIKE "%k%e%y%w%o%r%d%"
         */
        'use_wildcards'    => false,
    ],

    /**
     * DataTables internal index id response column name.
     */
    'index_column'   => 'DT_Row_Index',

    /**
     * List of available builders for DataTables.
     * This is where you can register your custom dataTables builder.
     */
    'engines'        => [
        'eloquent'   => \Yajra\DataTables\EloquentDataTable::class,
        'query'      => \Yajra\DataTables\QueryDataTable::class,
        'collection' => \Yajra\DataTables\CollectionDataTable::class,
    ],

    /**
     * DataTables accepted builder to engine mapping.
     */
    'builders'       => [
        Illuminate\Database\Eloquent\Relations\Relation::class => 'eloquent',
        Illuminate\Database\Eloquent\Builder::class            => 'eloquent',
        Illuminate\Database\Query\Builder::class               => 'query',
        Illuminate\Support\Collection::class                   => 'collection',
    ],

    /**
     * Nulls last sql pattern for Posgresql & Oracle.
     * For MySQL, use '-%s %s'
     */
    'nulls_last_sql' => '%s %s NULLS LAST',

    /**
     * User friendly message to be displayed on user if error occurs.
     * Possible values:
     * null             - The exception message will be used on error response.
     * 'throw'          - Throws a \Yajra\DataTables\Exceptions\Exception. Use your custom error handler if needed.
     * 'custom message' - Any friendly message to be displayed to the user. You can also use translation key.
     */
    'error'          => env('DATATABLES_ERROR', null),

    /**
     * Default columns definition of dataTable utility functions.
     */
    'columns'        => [
        /**
         * List of columns hidden/removed on json response.
         */
        'excess'    => ['rn', 'row_num'],

        /**
         * List of columns to be escaped. If set to *, all columns are escape.
         * Note: You can set the value to empty array to disable XSS protection.
         */
        'escape'    => '*',

        /**
         * List of columns that are allowed to display html content.
         * Note: Adding columns to list will make us available to XSS attacks.
         */
        'raw'       => ['action'],

        /**
         * List of columns are are forbidden from being searched/sorted.
         */
        'blacklist' => ['password', 'remember_token'],

        /**
         * List of columns that are only allowed fo search/sort.
         * If set to *, all columns are allowed.
         */
        'whitelist' => '*',
    ],

    /*
     * JsonResponse header and options config.
     */
    'json'           => [
        'header'  => [],
        'options' => 0,
    ],

];

php artisan cache:clear
php artisan config:cache
Helped. DataTables see configuration now. Data is displayed properly. But search is not working becuase it treats 'status' as field on main table, and not joined one.
How to solve that?

Got it! JS datatable will look for name when passing search query data.
So issue is resolved :)


firestarter: hash mismatch

Describe the bug
7110bf59e9fa7e867ded61a1199b475c8451b8ef
building '/nix/store/miamjhr86rsx5l494jmhskyakmm22i1l-source.drv'...

trying https://github.com/tud-zih-energy/FIRESTARTER/archive/v1.7.4.tar.gz
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100   134  100   134    0     0    572      0 --:--:-- --:--:-- --:--:--   572
100 79570    0 79570    0     0   114k      0 --:--:-- --:--:-- --:--:--  857k
unpacking source archive /build/v1.7.4.tar.gz
hash mismatch in fixed-output derivation '/nix/store/ifh785pzf4zf9y7lhrnvm7kyj0drihw1-source':
  wanted: sha256:161mg0h1hvp6bxfjdhyfqrljvphys896mfd36254rbgzxm38ibi7
  got:    sha256:0zqfqb7hf48z39g1qhbl1iraf8rz4d629h1q6ikizckpzfq23kd0
cannot build derivation '/nix/store/y3bb96h3cx39pphm1q5l53gm9rsac3wq-firestarter-1.7.4.drv': 1 dependencies couldn't be built
error: build of '/nix/store/y3bb96h3cx39pphm1q5l53gm9rsac3wq-firestarter-1.7.4.drv' failed

I don't know if we should just update it or not.
To Reproduce
Steps to reproduce the behavior:

nix-build -A firestarter on master

Expected behavior
Screenshots
Additional context
Notify maintainers
@astro
Metadata

system: "x86_64-linux"
host os: Linux 5.4.47, NixOS, 20.09pre231796.22a81aa5fc1 (Nightingale)
multi-user?: yes
sandbox: yes
version: nix-env (Nix) 2.3.6
channels(bbigras): "home-manager, unstable-20.09pre231796.22a81aa5fc1"
channels(root): "nixos-20.09pre231796.22a81aa5fc1, nixos-hardware"
nixpkgs: /nix/var/nix/profiles/per-user/root/channels/nixos

Maintainer information:
# a list of nixpkgs attributes affected by the problem
attribute:
# a list of nixos modules affected by the problem
module:

I can reproduce the issue locally
It used to build previously https://github.com/NixOS/nixpkgs/pull/72334#pullrequestreview-309790046
The current firestarter.src is not in the Hydra cache because firestarter was never built by Hydra, so, unless someone else has the /nix/store/az95sr2aj3rcwyhp3wxy84zyx88x5kcy-source, we can't compare
Upstream tag doesn't appear to be updated, git repo doesn't use export-subst

It is not clear to me what has happened here.

Dear all,
the tag v1.7.4 has been changed after October 2019. It was not published for long as it involuntarily got into a commit. There have been no public releases for v1.7.4 marked on Github or our the FIRESTARTER Website as of October 2019.

Thanks everyone for the help. :heart:


Add some way to version our policy wasm files

The policy format already changed once (when we from WASI to waPC). There are chances this will happen again in the future (see the #28 ).
When the policy format changes, we have to find a way to not load policies written with the old format into policy-server.
Acceptance criteria

It's possible to query the spec version of a Kubewarden policy
Extra: the policy-server refuses to load older policies and exits with an error at boot time

@kkaempf we recently discussed that during one of our dailies. I think we both agree the later tag should be removed and this issue should be done before the initial release.
Am I right?

IIRC what we discussed is that we can introduce the versioning part after MVP, and re push wasm artifacts at some point with this metadata, given that there are very low chances that anybody is depending on this artifacts, cached somehow at this time.

This is done now


Improve documentation and folder structure

Moved all assets from data/ to docs/assets and updated respective paths in all files I could find. After the path changes, I can still build and use the simulator, but please check if I missed a path.
Moved hpc docs to docs/hpc
Changed scenario folder from example_data to data and updated corresponding paths
Made some formatting / readability changes to README.md

@SamanKazemkhani thanks for the review. I added the type back in, moved all *.obj files to assets, and updated the paths. Does this look good?

I don't see the *.obj files under assets/, though they've been deleted from data/.

I don't see the *.obj files under assets/, though they've been deleted from data/.

Not sure why but it was listed in the gitignore. They should be visible now.


Billing web UI improvements

Show the name of the org which is being worked with
Put a tooltip on the "x" button for existing payment methods
HTML title of the page is "ChiselStrike Inc Billing". Should probably be Turso?
There is nothing stopping the user from removing the only payment plan on record while the org is currently on the scaler plan. It's not clear what will happen in the future while this state persists (on scaler but no billing methods).
With multiple payment methods registered, deleting the default doesn't promote any of the others to be the new default. Not clear what the impact of this is.

I'll close that one since that UI is Stripe's.
Commenting on the ones that are under our control.

There is nothing stopping the user from removing the only payment plan on record while the org is currently on the scaler plan. It's not clear what will happen in the future while this state persists (on scaler but no billing methods).

I chose to not enforce at least one payment method because we still have to handle that case when somebody cancel's their credit card, for instance.
The behavior of a missing payment method will be the same as a failed payment - we'll notify users via email and downgrade their plan after a grace period.

HTML title of the page is "ChiselStrike Inc Billing". Should probably be Turso?

That is correct. Took me a while to figure out where to change this info, but we're updating it.

Edit: it should be ChiselStrike Inc Billing indeed. Because that is the name of the company.

@glommer If we show "ChiselStrike" for billing purposes, this could be very confusing to someone who is trying to make sense of their credit card bill, since we don't explicitly declare this anywhere else that I can see.

stripe has two settings for that. One is specifically for what goes in the credit card, and that one is Turso:

I guess I'm confused then why ChiselStrike needs to show up in the title.

it's the legal name of the company (for now)


esModuleInterop is ignored when using project references

TypeScript Version:  3.8.0-dev.20200111

Search Terms: "esModuleInterop", "esModuleInterop composite", "esModuleInterop project"
Code
Repository with short test case: https://github.com/cyberalien/typescript_esmoduleinterop_bug
Root tsconfig.json includes 2 projects: src/tsconfig.json and tests/tsconfig.json
Flag esModuleInterop is enabled in src/tsconfig.json and tests/tsconfig.json
However when running tsc -b, it throws error that esModuleInterop is not enabled.
Expected behavior:
Test case should compile without issues.
Actual behavior:
tsc throws following error:
src/get_uri.ts:1:8 - error TS1259: Module '"node_modules/@types/request/index"' can only be default-imported using the 'esModuleInterop' flag

1 import request, { Response } from 'request';
         ~~~~~~~

  node_modules/@types/request/index.d.ts:405:1
    405 export = request;
        ~~~~~~~~~~~~~~~~~
    This module is declared with using 'export =', and can only be used with a default import when using the 'esModuleInterop' flag.

Found 1 error.

Workaround:
Workaround to demonstrate that this is compiler issue, not code issue: to root tsconfig.json add this:
	"compilerOptions": {
		"composite": true,
		"esModuleInterop": true,
		"noEmit": true
	},

(see tsconfig-workaround.json in repository)
Then esModuleInterop becomes enabled in referenced projects.

Try setting "files": [], "include": [] in your root tsconfig.json. Otherwise it will be treated as a regular project which just happens to contain project references. By explicitly excluding all files, TypeScript will not attempt to use this tsconfig.json to compile files and instead only processes the project references.

That works.
However other options do work in referenced files, except for esModuleInterop. Does that mean esModuleInterop is treated differently than other options or is it a bug?

Try setting "files": [], "include": [] in your root tsconfig.json. Otherwise it will be treated as a regular project which just happens to contain project references. By explicitly excluding all files, TypeScript will not attempt to use this tsconfig.json to compile files and instead only processes the project references.

this does not work for me
in fact only putting compiler options directly into root tsconfig.json file works, which seems wrong to me

Try setting "files": [], "include": [] in your root tsconfig.json. Otherwise it will be treated as a regular project which just happens to contain project references. By explicitly excluding all files, TypeScript will not attempt to use this tsconfig.json to compile files and instead only processes the project references.

this does not work for me
in fact only putting compiler options directly into root tsconfig.json file works, which seems wrong to me

@khachaturs try putting "files" and "include" inside "compilerOptions".


feat: added support for enable_private_path_for_google_cloud_services field in replica instances.

This is to add the supported requested in https://github.com/terraform-google-modules/terraform-google-sql-db/issues/468
feat: Added support for enable_private_path_for_google_cloud_services field in replica instances.

/gcbrun

/gcbrun

/gcbrun


Add @cwasm/openbsd-bcrypt and @cwasm/openwall-bcrypt to benchmark

Hello!
I've spent the last night compiling some bcrypt code to wasm, and wanted to see how they held up against the Rust implementation. This PR adds two new Npm packages to the BCrypt benchmark: @cwasm/openbsd-bcrypt and @cwasm/openwall-bcrypt.
These are the results on my machine:
@node-rs/bcrypt x 15.42 ops/sec ±0.67% (14 runs sampled)
node bcrypt x 16.93 ops/sec ±0.12% (15 runs sampled)
bcryptjs x 3.69 ops/sec ±0.31% (7 runs sampled)
Async hash round 12 bench suite: Fastest is node bcrypt

@node-rs/bcrypt x 15.48 ops/sec ±0.07% (14 runs sampled)
node bcrypt x 443,290 ops/sec ±0.27% (90 runs sampled)
bcryptjs x 3.69 ops/sec ±0.35% (7 runs sampled)
Async verify bench suite: Fastest is node bcrypt

@node-rs/bcrypt x 4.14 ops/sec ±0.27% (15 runs sampled)
node bcrypt x 4.55 ops/sec ±0.06% (16 runs sampled)
bcryptjs x 3.70 ops/sec ±0.09% (14 runs sampled)
wasm OpenBSD x 3.70 ops/sec ±0.04% (14 runs sampled)
wasm Openwall x 4.12 ops/sec ±0.06% (15 runs sampled)
Hash round 12 bench suite: Fastest is node bcrypt

@node-rs/bcrypt x 2,491,253 ops/sec ±0.29% (98 runs sampled)
node bcrypt x 701,746 ops/sec ±0.44% (96 runs sampled)
bcryptjs x 150,612 ops/sec ±0.32% (94 runs sampled)
wasm OpenBSD x 3,364,578 ops/sec ±0.14% (95 runs sampled)
wasm Openwall x 762,250 ops/sec ±1.75% (88 runs sampled)
genSaltSync bench suite: Fastest is wasm OpenBSD

Seems like the Openwall implementation has 99.5% of the performance of this module, for hashSync! The OpenBSD implementation has the fastest genSaltSync 🐎

(rebased on main)
ping @Brooooooklyn, any chance of getting this merged?

(rebased on main)
ping @Brooooooklyn, any chance of getting this merged?

@LinusU Sorry, I just missed your pr and comments :(


cargo install failed

I was trying to build my docker image with cargo install --path . but it doesn't seem to be like working, does anyone know how to fix it?
version: 1.16.9

sorry, cargo build --release is working fine.


Take out any references to CoursePlus

E.g., you can see that it is present in index.Rmd and in config.yml :
* [CoursePlus Website](`r config::get("courseplus_web")`)
Don't replace it with anything, just remove it.

This one I can tackle for Monday!

@ehumph you rock, thank you!!


Tutorial?

So, first of all, what is the ban rate for this software now that vanguard is out? any reports yet? and second of all, its very unclear how to setup the stuff, cant find an .exe dlls or anything so im a bit confused on how it works.

also im on a 60% keyboard so that makes the "binds" even more confusing (home, end).


PEP-8 compliant code

Currently, the code isnt PEP-8 compliant - this should be done prior to a production release.

Fixed


[NTR/gene] Succinate-CoA ligase deficiency

Succinate-CoA ligase deficiency
https://ghr.nlm.nih.gov/condition/succinate-coa-ligase-deficiency
Succinate-CoA ligase deficiency is an inherited disorder that affects the early development of the brain and other body systems. One of the earliest signs of the disorder is very weak muscle tone (severe hypotonia), which appears in the first few months of life.
SUCLA2 or SUCLG1 gene. SUCLG1 gene mutations can cause fatal infantile lactic acidosis, while mutations in either gene can cause the somewhat less severe form of the condition.
Definition (free text, please give PubMed ID, if applicable, in format PMID:#######)
Parent term (use OLS, or your favorite ontology browser)
Your nano-attribution (ORCID) or URL for a working group

NOte that the related term for the sever form is
mitochondrial DNA depletion syndrome, encephalomyopathic form with methylmalonic aciduria (MONDO:0012791)
this term definitions says "Transmission is likely to be linked to maternal mitochondrial DNA.
but since the gene in question (see above)  is known to be SUCLG1 this comment is not true and should be removed.

actually I'm happy just to annotate to the severe form ( MONDO:0009504 | mitochondrial DNA depletion syndrome 9),
but this is also referred to as "Succinate-CoA ligase deficiency" s could this be added as a broad synonym"

could this be added as a broad synonym"

of course, done!


Some help with google podcasts

On a Mac OS - trying to load an example podcast from google podcasts into the podcast note, but I keep getting an error 'Couldn't load podcast - no internet connection'. I do have internet connection but still experiencing this error.
This is an example url, but none of them seem to work for me.
https://podcasts.google.com/feed/aHR0cHM6Ly93d3cub21ueWNvbnRlbnQuY29tL2QvcGxheWxpc3QvZDgzZjUyZTQtMjQ1NS00N2Y0LTk4MmUtYWI3OTAxMjBiOTU0LzZiZTVhMDFiLWNjYTQtNDg1Yi1hNDAyLWFiODYwMGQzZWVjMy82MjE4YmQ1Yy05NTk4LTQ3YjUtOGQ5My1hYjg2MDBkM2VlYzMvcG9kY2FzdC5yc3M/episode/YjA1ZDUyMjktMDJmMy00ODA2LWJjYmUtYWQ5ZjAxM2IxY2Ji?sa=X&ved=0CAcQkfYCahgKEwjIwI6Xjv3yAhUAAAAAHQAAAAAQ-QE

I tried it with the link you provided and it worked for me (on macOS).

Can you tell me which version of Podcast Note you have installed?

Version 1.1.2 - Not sure what the issue. It still doesn't work for me. Add a podcast note -> entered the url -> keeps giving me the error 'couldn't load podcast data.


Wip/gmt/5123 remove old

Pull Request Description
Remove old (Java) Regex library and replace with new (Truffle) library.
Important Notes
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:

[x] The documentation has been updated, if necessary.
[x] Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
[x] All code follows the
Scala,
Java,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
All code has been tested:

[x] Unit tests have been written where possible.
[x] If GUI codebase was changed, the GUI was tested when built using ./run ide build.

Various little things to check but generally LGTM.


Don't complete form on editable label enter key

Fixes
Fixes HAC-2120
Description
Don't submit form on an enter key press in the editable label field. The edit should be saved but the form should not be submitted.
Type of change

[x] Bugfix

/cc @karthikjeeyar @christianvogt

/approve
/lgtm

/retest

/retest

/retest

/rebuild

/retest

Closing due to build issue with this PR number


Calibration time lookup

I've added two routines to lookup the calibration time from files (just pulled out of ch_pipeline) and from the dataset IDs (new).
I need to test this a bit more, but I think it's mostly done.

I posted this comment in the wrong PR.  Deleting it from the ch_pipeline PR and moving it here.
I've generated a new file that contains calibration times between 2018/09/02 and 2020/12/30.  In the process, I fixed a problem with past files where the tref quantity was converted to a float32 during processing, which resulted in up to a 60 second difference with the true transit time.
The file is currently saved on cedar at
/scratch/ssiegel/chime/calibration_times/20180902_20201230_calibration_times.h5
Previously I saved these in the project space at
/project/rpp-chime/chime/chime_processed/gain/
but it looks like I am no longer owner of that directory.  Would you be able to return me as owner or grant me write privileges?
Here is the result of comparing the output of get_reference_times_file and get_reference_times_dataset_id for the periods where they overlap:
file_database_comparison_fix_float_fit_valid_expanded_v2.pdf

page 1: shows reftime, reftime_prev, interp_start, and interp_stop as a function of time.  The file-based method is shown in black and the dataset-id-based method is shown in red.
page 2: the difference between the file-based method and dataset-id-based method for times where both values are finite in units of hours.
page 3: same as page 2 but zooming in on +/- 15 minutes and shown in units of minutes.
page 4: the difference between reftime and reftime_prev (top) and interp_stop and interp_start (bottom).
page 5: same as page 4 but zooming in on +/- 15 minutes around the expected value of each quantity.

Below I summarize the discrepancies in the quantities being output.
reftime
missing files
There are two cases between 2020-10-22 and 2020-11-01 where the dataset-id-based method moves on to the next update, but the file based method gets "stuck" on an old update.
The generation of the calibration time file involves searching the chimestack acquisitions for times where the gains change from one sample to the next, and then matching the gains at those times to the gains saved in the chimegain acquisitions.  For some reason there are files missing from the 20201014T233944Z_chimestack_corr acquisition in the chime_online space.  Some of these files contain gain transitions, and so those transitions are never registered during generation of the file.  This is illustrated in the following figure that shows the start time of all available files in the chime_online space (blue) and compares to the gain update times (red):
20201014_acq_file_jumps.pdf
Perhaps this is due to chimestack data with a dataflag being moved from the online space to nearline?  I would have thought that, since this more recent data has not been processed by the pipeline, there would not be a dataflag indicating that it is bad.
Looking back through old slack messages, it appears the move of chimestack to nearline started on June 2, 2021.  The calibration times from 2020-04-01 to 2020-10-23 were created on Nov 2, 2020, so they shouldn't be affected by this move if it is indeed responsible.  The file-based calibration times after 2020-10-23 are affected by this problem.  Luckily we have the dataset-id-based method that we can use, although that has separate issues detailed below.
acquisition restarts
There are several cases where the dataset-id-based method stops registering a reference time.  In all cases this corresponds to invalid dataset ids due to correlator or kotekan restarts:

2020-11-04 21:32:00 to 2020-11-05 03:38:42

kotekan was apparently restart and the query returns an invalid dataset id (gain_20201104T213200.360047Z_timing).  Note that this did not corrrespond to a correlator restart and is not covered by a bad_calibration_fpga_restart dataflag.

2020-11-07 05:40:00 to 2020-11-08 02:59:11

kotekan was apparently restart and the query returns an invalid dataset id (gain_20201107T054000.496272Z_timing).  Note that this did not corrrespond to a correlator restart and is not covered by a bad_calibration_fpga_restart dataflag.

2020-11-15 01:22:14 to 2020-11-16 02:19:32

There was a correlator / kotekan restart and the query returns an invalid dataset id (gain_20201114T200428.578117Z_timing).  This is covered by a bad_calibration_fpga_restart dataflag.

2020-11-17 18:21:29 to 2020-11-17 19:08:37

kotekan was apparently restart and the query returns an invalid dataset id (gain_20201117T181841.190217Z_timing).  This is covered by a bad_calibration_fpga_restart dataflag.

2020-11-26 23:09:33 to 2020-11-27 01:40:37

kotekan was apparently restart and the query returns an invalid dataset id (gain_20201126T230630.094332Z_timing).  This is covered by a bad_calibration_fpga_restart dataflag.

2020-11-29 4:44:44  to 2020-11-30 04:57:22

kotekan was apparently restart and the query returns an invalid dataset id (gain_20201129T043826.610238Z_timing).  Note that this did not corrrespond to a correlator restart and is not covered by a bad_calibration_fpga_restart dataflag.

The calibration broker always multiplies the timing-only updates by the most recent point-source-based gains.  For future data, we could modify the calibration broker code so that it includes the name of the source that was used in every update_id.
For past data, we could create data flags after each acquisition restart, similar to how we create data flags for fpga restarts.  Alternatively, we could change the code so that as it is moving forward through the times, if it encounters an invalid update it replaces it with the last valid update.  This is probably a safe assumption for the more recent data for which the dataset-id-based method will be used.  This would not work within the daily pipeline if the acquisition restart happened to occur near the boundary of a sidereal day.  However, I suspect we may use this code for other stability analyses where larger spans of time are processed and for which this method should work.
Change in conventions
The second page of the pdf file indicates that occasionally there are very brief intervals where the reference time in the file is one day larger than the reference time from the dataset id.  The intervals here are actually single time samples that in all cases correspond to the start of a transition.  The file-based method includes the first sample in the transition and sets reftime to the new update and reftime_prev to the old update.  The dataset-id based method does not include the first sample in the transition and sets reftime to the old update and reftime_prev to NaN.
In the end this difference in conventions does not matter.  The first sample of the transition will be set to the old update in either case because of how the interpolation factor is defined.
I think it would be good to use the same convention just to avoid confusion in the future, however it would take me a while to understand the indexing in get_reference_times_file  to the point that I could fix it to match the result of get_reference_times_dataset_id.
reftime_prev
previously discussed problems
The previously described problem with the file-based method due to missing chimestack files shows up in the reftime_prev quantity around 2020-11-01.  The problem with the dataset-id-based method due to acquisitions restarts shows up around 2020-11-26.
transitional updates not registering new gain ids
Before 2020-11-01, there are a large number of instance where the file-based method identifies a reftime_prev, but the dataset-id-based method does not.  I have investigated one such instance on 2020-10-23.  For some reason, the "gain ids" are not changing for transitional gain updates.  The chimegain acquisition contains the transitional gain updates and the gain dataset in the chimestack acquisition is transitioning in the expected way, however the "gain id" is not changing during each transition.  This problem does not show up after 2020-11-01, so perhaps this is some initial bug during rollout that was subsequently fixed?
interp_start
previously discussed problems
In cases where we are transitioning to a new update from a previous "invalid" update (due to correlator/acquisition restart), the dataset-id-based method uses the time of the most recent valid non-interpolated update as the interpolation start time.
I think this is a bug and we should instead use the time of the most recent valid OR invalid non-interpolated update.
interp_stop
problem identifying full transition with file-based method
The calibration time file covering 2020-04-01 to 2020-10-23 was created on Nov 2, 2020 and the calibration time file covering 2020-10-23 to 2020-12-31 was created only a few days ago.  I seem to have lost the exact method that I was using for the former and as a result I was unable to properly identify all gain changes in the gain dataset of the chimestack files for the latter.  I am still trying to figure this out, but as of right now the interp_stop time ends up being roughly 2 minutes short compared to the dataset-id based method and the expected transition duration (5 minutes).

Here are the same set of plots after implementing the suggested changes:
file_database_comparison_fix_float_fit_valid_expanded_with_changes.pdf
Many of the discrepancies have been resolved.  The two methods are still using different conventions for reftime, which results in the 1 hour difference at the start of each update.
There is still one case around 2020-11-27 where the database-based method gives the incorrect reftime and reftime_prev.  In this case, there was a correlator restart, so the update_id was invalid, and before the restart was a deployment, so the chimestack was not archived.  As a result, the database-based method uses the reference time from the last valid update pre-deployment.  However that interval is covered by a bad_calibration_fpga_restart flag and would be excluded.

Should all be done now @ssiegelx. I've applied all your fixes. Thanks!


Task Manager opens up when changing the page

When I change to Control, Node, Staking, everytime the task manager pops up.
@daGscheid do we have some rules on when the task manager shows up on it's own?

We added a rule, that it opens up after installation, right @maxbehzadi82 ?

Right.If the services are already installed,after log in routing redirects to the node page.

Only 10s then will be close.
It was temporary solution.I will make it only for node page after installing.


Add aria-hidden for caption-number

To the right of the title is the number of articles, podcasts, or other things. When I navigate with a screen reader, I don't understand what the number 7 or 9 means. I can imagine that if there is a given number after the heading, then maybe it's about the number, but not the fact that everyone will think so. I think there are 2 options how to solve this problem. The first option is to hide it from the screen reader (I did) or add an aria-label with details. I have hidden the caption number because I don't think this information is important enough for people who use a screen reader. But if you disagree with something, I will be glad if you tell me your opinion

I wouldn’t say I like the idea of hiding content from SR users. It would be better to explain it instead.

Added aria-label

I changed the wording a bit, so it would be less repetitive:

articles, 7 in total, view all articles (link)

Thank you for the suggestion!


Hardcoded requirements versions?

https://github.com/docker/dockercloud-cli/blob/master/requirements.txt
If user doesn't hardcode this dependencies in dependent project any version change of six for example could break builds.
I suppose docker-cloud is a lib. Isn't it?
https://caremad.io/2013/07/setup-vs-requirement/

+1
Traceback (most recent call last):   File "/usr/local/bin/docker-cloud", line 5, in <module>     from pkg_resources import load_entry_point   File "/usr/lib/python2.7/dist-packages/pkg_resources.py", line 2749, in <module>     working_set = WorkingSet._build_master()   File "/usr/lib/python2.7/dist-packages/pkg_resources.py", line 446, in _build_master     return cls._build_from_requirements(__requires__)   File "/usr/lib/python2.7/dist-packages/pkg_resources.py", line 459, in _build_from_requirements     dists = ws.resolve(reqs, Environment())   File "/usr/lib/python2.7/dist-packages/pkg_resources.py", line 628, in resolve     raise DistributionNotFound(req) pkg_resources.DistributionNotFound: six==1.9.0

+1
Traceback (most recent call last):
File "/usr/bin/docker-cloud", line 5, in
from pkg_resources import load_entry_point
File "/usr/lib/python2.7/site-packages/pkg_resources/init.py", line 3138, in
@_call_aside
File "/usr/lib/python2.7/site-packages/pkg_resources/init.py", line 3124, in _call_aside
f(*args, **kwargs)
File "/usr/lib/python2.7/site-packages/pkg_resources/init.py", line 3151, in _initialize_master_working_set
working_set = WorkingSet._build_master()
File "/usr/lib/python2.7/site-packages/pkg_resources/init.py", line 663, in _build_master
return cls._build_from_requirements(requires)
File "/usr/lib/python2.7/site-packages/pkg_resources/init.py", line 676, in _build_from_requirements
dists = ws.resolve(reqs, Environment())
File "/usr/lib/python2.7/site-packages/pkg_resources/init.py", line 849, in resolve
raise DistributionNotFound(req, requirers)
pkg_resources.DistributionNotFound: The 'python-dockercloud==1.0.1' distribution was not found and is required by docker-cloud

same as satisha, the cli as a docker container is broken.

@jcrombez @satishsa1107 the dockercloud/cli image has been rebuilt and fixed

+1
Third party packages should be more relaxed on the version.


Add cookiecutter template tag

I assume this is a harcoded path which went unseen.

Hi @hkraal, this is actually deliberate. The way it works is:

The package is generated by cookiecutter . --no-input, resulting in the boilerplate/ directory.
Then the test suite is run from inside of boilerplate/.


Add support for parameterized types with type bounds

Is your feature request related to a problem? Please describe.
Currently it doesn't work to say that you have a function that is parameterized with certain bounds for the parameters.
Describe the solution you'd like
Syntax could be something like this, which already parses:
let f(X + Odd): X + Even;

Describe alternatives you've considered
There shouldn't be a need to specifically bound a parameter as far as I can see. The bounds can just be associated at the same level.

LM


Console Errors, isn't refreshing to the checkmark button after completed

Warning: Failed prop type: Invalid prop opacity of type object supplied to AnimatedCircularProgress, expected number.
Bad object: {
"backgroundColor": "transparent",
"position": "absolute",
"top": 0,
"left": 0,
"opacity": 1
}
in AnimatedCircularProgress (at main.js:119)
in SubmitButton (at App.js:97)
in RCTView (at View.js:113)
in View (at App.js:63)
in HomeScreen (at SceneView.js:35)
in SceneView (at CardStack.js:404)
in RCTView (at View.js:113)
in View (at AnimatedImplementation.js:1844)
in AnimatedComponent (at Card.js:27)
in Card (at PointerEventsContainer.js:55)
in Container (at CardStack.js:430)
in RCTView (at View.js:113)
in View (at CardStack.js:364)
in RCTView (at View.js:113)
in View (at CardStack.js:363)
in CardStack (at CardStackTransitioner.js:110)
in RCTView (at View.js:113)
in View (at Transitioner.js:187)
in Transitioner (at CardStackTransitioner.js:60)
in CardStackTransitioner (at StackNavigator.js:52)
in Unknown (at createNavigator.js:33)
in Navigator (at createNavigationContainer.js:202)
in NavigationContainer (at registerRootComponent.js:33)
in ExpoRootComponent (at renderApplication.js:35)
in RCTView (at View.js:113)
in View (at AppContainer.js:100)
in RCTView (at View.js:113)
in View (at AppContainer.js:121)
in AppContainer (at renderApplication.js:34)
----------------------------------------------------------------------------------------------------------
<Here's my usage of it>
<SubmitButton
onSubmit={()=>navigate('Chat', {user: 'Lucy'})}
buttonState={this.state.submitButton.buttonState}
buttonTextWhenReady={'Logged In'}
animationDuration={800}
/>

i have published new version. Can u check now

I think there might be issue in updating your state of button. Can u please double check.

Closing for now.

You can delete this issue, I was new to RN and didn't understand what I was doing

In fact - please delete this issue as it was fixed in the recent update.


Fix an issue in overlay network peer EP list maintenance

Fixes https://github.com/docker/docker/issues/17465
For overlay networks every node maintains a list of remote Endpoints (that are present on peer nodes). When one of those remote EPs go down the list wasn't getting deleted. On a container restart on one of the peers EP ID changes, but the name remains the same. So the extra entries in the list can lead to unintended delete of the service records, thus causing the issue reported in docker #17465
Signed-off-by: Santhosh Manohar<EMAIL_ADDRESS>

LGTM

LGTM


[PE-D][Tester C] Case Sensitivity Issue in Duplicate Name Detection

The TalentSG application does not recognize the same person if their names differ only in capitalization. When adding a candidate with a name that has different letter cases (e.g., "case insensitive names" vs. "Case Insensitive Names"), the system fails to detect the duplicate and allows both entries. This causes redundant records and could lead to data inconsistency.
expected:
The system should detect that the two entries refer to the same person and prevent the addition of the second entry, regardless of name capitalization. Name comparison for duplicate detection should be case-insensitive.
actual:
The system does not recognize the duplicate due to case differences in the name field and allows both entries, creating duplicate records.
to reproduce:
add n/case insensitive names p/98765432<EMAIL_ADDRESS>a/311, Clementi Ave 2, #02-25 dr/Software Engineer s/Java, Python, C++ ex/Project Manager at Google from 2010-2020 st/Interviewed
followed by
add n/Case insensitive names p/98765432<EMAIL_ADDRESS>a/311, Clementi Ave 2, #02-25 dr/Software Engineer s/Java, Python, C++ ex/Project Manager at Google from 2010-2020 st/Interviewed
does not throw error

Labels: severity.Medium type.FeatureFlaw
original: celeschai/ped#4

Duplicate of #228


ceylon.time.iso8601::parseDayOfMonth and parseDate fail for leap day

In the ceylon.time.iso8601 package, calling parseDayOfMonth("29", 2000, february) returns null because Month.numberOfDays is not passed the flag that indicates 2000 is a leap year. This leads to parseDate("2000-02-29") also returning null.

@luolong would you take a look please

Yes, I will.

Thanks

Fixed by @luolong.

Thanks, guys!


Fix a possible memleak in rsa_pub_encode

That seems to be only an issue for RSA-PSS with parameters.
Spotted by code review, so it looks there is no test coverage for this.

Checklist

[ ] documentation is added or updated
[x] tests are added or updated

This is master version of #22007

This pull request is ready to merge

Merged to master, 3.1, and 3.0 branches. Thank you for your contribution.


Add dynamic text sizing Closes #497

Pull request checklist

[X] All tests pass. Demo project builds and runs.
[X] I have resolved any merge conflicts.
[X] I have followed the coding style, and reviewed the contributing guidelines. Confirmation: 💪😎👊

This fixes issue #497

[X] implement dynamic type for cell labels (cellTopLabel, messageBubbleTopLabel, cellBottomLabel)
[X] implement runtime switching

What's in this pull request?

Add Dynamic Text instead of hardcoded font values. Also Add refresh notification for when the Accenebility setting is changed.

There is an error with a 9.3 simulator where the text will not change  found here
http://stackoverflow.com/questions/36204330/uicontentsizecategorydidchangenotification-not-working-on-simulator-ios-9-3-doe

That is connected to open radar:
http://www.openradar.me/radar?id=6083508816576512.

You can do it in old versions of the simulator. IE (9.2)

🍭

Cherry picked my fixes on to this new branch to clean things up.

[Current coverage][cc-pull] is 60.98% (diff: 90.48%)

Merging [#1747][cc-pull] into [develop][cc-base-branch] will increase coverage by 0.06%

@@            develop      #1747   diff @@
==========================================
  Files            62         62
  Lines          2239       2250    +11
  Methods         621        622     +1
  Messages          0          0
  Branches        135        135
==========================================
+ Hits           1364       1372     +8
- Misses          800        803     +3
  Partials         75         75

[][cc-pull]

Powered by Codecov. Last update [c1cc135...37463d8][cc-compare]
[cc-base-branch]: https://codecov.io/gh/jessesquires/JSQMessagesViewController/branch/develop?src=pr
[cc-compare]: https://codecov.io/gh/jessesquires/JSQMessagesViewController/compare/c1cc135a726bca99672b0c8e4e5ac2535c1406ea...37463d8755da79ab1b07b974e04aead5f0f58d0c?src=pr
[cc-pull]: https://codecov.io/gh/jessesquires/JSQMessagesViewController/pull/1747?src=pr

Thanks @MacMeDan ! 🎉

Going to merge and forward fix the comments I left.


dts: Add new DTS/binding parser

dts: Add new DTS/binding parser

Add a new DTS/binding parser to scripts/dts/ for generating
generated_dts_board.conf and generated_dts_board_unfixed.h.

The old code is kept to generate some deprecated defines, using the
--deprecated-only flag. It will be removed later.

The new parser is implemented in three files in scripts/dts/:

dtlib.py:
  A low-level .dts parsing library. This is similar to devicetree.py in
  the old code, but is a general robust DTS parser that doesn't rely on
  preprocessing.

edtlib.py (e for extended):
  A library built on top of dtlib.py that brings together data from DTS
  files and bindings and creates Device instances with all the data for
  a device.

gen_defines.py:
  A script that uses edtlib.py to generate generated_dts_board.conf and
  generated_dts_board_unfixed.h. Corresponds to extract_dts_includes.py
  and the files in extract/ in the old code.

  Note that dtlib.py and edtlib.py are general libraries (similar to
  Kconfiglib) that could be used for other stuff besides gen_defines.py.

testdtlib.py:
  Test suite for dtlib.py. Can be run directly as a script.

testedtlib.py (uses test.dts and test-bindings/):
  Test suite for edtlib.py. Can be run directly as a script.

The test suites will be run automatically in CI.

The new code turns some things that were warnings (or not checked) in
the old code into errors, like missing properties specified with
'category: required' in the binding for the node.

The code includes lots of documentation and tries to give helpful error
messages instead of Python errors.

Co-authored-by: Kumar Gala<EMAIL_ADDRESS>Signed-off-by: Ulf Magnusson<EMAIL_ADDRESS>

But it's missing the other half: it doesn't diagnose presence of property that is not in the yaml, such as a misspelled optional property.
That lack isn't worth blocking this, but if necessary I'll create an issue for it.

Would be easy to add later, if we want to require all properties to be listed in the binding. Suspect we might have lots of nodes that don't follow that now.

Would be easy to add later, if we want to require all properties to be listed in the binding. Suspect we might have lots of nodes that don't follow that now.

Probably not, unless this implementation (unlike the current one) generates defines for the extra properties.  If there are any, they can't be being used.

Would be easy to add later, if we want to require all properties to be listed in the binding. Suspect we might have lots of nodes that don't follow that now.

Probably not, unless this implementation (unlike the current one) generates defines for the extra properties. If there are any, they can't be being used.

Works like the old code. Thinking there might be a lot of unused stuff (or stuff that's undeclared because it's using some special path in the code). Maybe it's not that bad though...

Can't build nucleo_f401re board (sample hello_world), due to missing symbol CONFIG_RAM_SIZE
It is defined in arch/Kconfig:
config SRAM_SIZE
	int "SRAM Size in kB"
	default $(dt_int_val,DT_SRAM_SIZE)

DT_SRAM_SIZE is not defined anymore

Fixed by the latest force push. Thought I could make a small change without diffing generated_dts_board.conf before and after, but I couldn't. :P

(Slack is broken to me so pasting my point here)
Would be nice to introduce nodes sorting at some step.
From experience, this was useful in previous script when trying to debug and comparing 2 versions of generated output

@erwango
Since Slack is dead:
The order in the conf and header file matches the order in the .dts file now, so it should be consistent at least. Would be pretty easy to change though, if you have some case where that order is bad.

The order in the conf and header file matches the order in the .dts file now, so it should be consistent at least. Would be pretty easy to change though, if you have some case where that order is bad.

This is not that I see, actually. For instance nucleo_f401re board, gpio nodes order:
nucleo_f401re.dts_compiled: A, B, C, D, E, H
generated_dts_board_unfixed.h: A, E, B, D, C, H (Changing at each build)

@erwango
Try this patch and see if it fixes it. set() iteration order can vary between runs in Python.
diff --git a/scripts/dts/gen_defines.py b/scripts/dts/gen_defines.py
index 720c297615..9d8c43a9c7 100755
--- a/scripts/dts/gen_defines.py
+++ b/scripts/dts/gen_defines.py
@@ -72,7 +72,7 @@ def main():
             active_compats.update(dev.compats)

     out_comment("Active compatibles (mentioned in DTS + binding found)")
-    for compat in active_compats:
+    for compat in sorted(active_compats):
         #define DT_COMPAT_<COMPAT> 1
         out("COMPAT_{}".format(str2ident(compat)), 1)

@erwango
What's your python3 --version btw? Dictionary iteration order didn't match insertion order before Python 3.6.

$ python3 --version
Python 3.5.2

Tried your proposal, but it didn't work (didn't help sorting devices). But as I understand, this aims at sorting compatibles and not devices, so this is logical.

@erwango
Yeah, the device-is-there flags use a set(), so they can move around between runs even on Python 3.6+, unless you sort them somehow.
The rest of it is consistent for me, so I'm guessing it's because you have Python 3.5.


[BUG] Text is almost invisible in dark mode

Describe the bug
When using django admin's dark mode, the text color changes (I suppose it gets overwritten by django css) and it gets nearly invisible.
To Reproduce
Steps to reproduce the behavior:
I am using DALFRelatedOnlyField with Django 5.0.6. It is a simple FK field.
Expected behavior
A quick fix would be to change the text color to always be black. A more complex solution is to support themes.
Screenshots

Environment:

OS: OpenSUSE Tumbleweed
CPU: x86_64
Python version: 3.12
Django version: 5.0.6
Django Admin List Filter package version: 0.2.4
Browser Vendor and version: Mozilla Firefox 129.0

Oops, you're right! I never tested this in dark mode. 🙈

Great, thank you!


Problem indexing maps in from Local Directory source

Describe the bug
The in built MapSource.get_y() does not produce the correct value for y for the southern hemisphere ie, latitudes that are negative.
And when it is fixed, the images are then indexed in the wrong order for surrounding images (indicating a negative increment).
N.B. I did not have this issue with the online sources for some reason they output the correct indexing. So I may be introducing a bug with my LocalMapSource class.
To Reproduce
Code example showing the issue:
I am using a new source that loads the map images from a local directory (could be part of the bug):
LocalSource.py:
# coding=utf-8
"""
Local tiles provider for MapView
============================
"""

__all__ = ["LocalMapSource"]

import io
import threading
import math
import os

from kivy.core.image import Image as CoreImage
from kivy.core.image import ImageLoader

from kivy_garden.mapview.downloader import Downloader
from kivy_garden.mapview.source import MapSource
from math import atan, ceil, cos, exp, log, pi, tan
from kivy_garden.mapview.utils import clamp
from kivy_garden.mapview.constants import (
    CACHE_DIR,
    MAX_LATITUDE,
    MAX_LONGITUDE,
    MIN_LATITUDE,
    MIN_LONGITUDE,
)
from kivy.metrics import dp

class LocalMapSource(MapSource):
    '''
        Similar to the Source except references a local directory
        {dir}/{z}/{x}/{y}.png
        where {dir} is a local directory
    '''
    def __init__(self, directory, **kwargs):
        super().__init__(**kwargs)
        self.directory = directory
        self.attribution = ""
        self.projection = ''
        self.is_xy = self.projection == "xy"

    def fill_tile(self, tile):
        if tile.state == "done":
            return
        Downloader.instance(self.cache_dir).submit(self._load_tile, tile)

    def _load_tile(self, tile):
        # global db context cannot be shared across threads.

        filepath = os.path.abspath('{}/{}/{}/{}.png'.format(self.directory,
                     tile.zoom, tile.tile_x, tile.tile_y))

        if os.path.exists(filepath):

            im = CoreImage(filepath)

            if im is None:
                tile.state = "done"
                return

            return self._load_tile_done, (tile, im,)
        else:

            tile.state="done"
            return

    def _load_tile_done(self, tile, im):
        tile.texture = im.texture
        tile.state = "need-animation"

    def get_x(self, zoom, lon):
        if self.is_xy:
            return lon
        x = super().get_x(zoom, lon)
        return x
#This is an alternate implementation from openstreetmap.
#        n = 2.** zoom
#        lon = clamp(lon, MIN_LONGITUDE, MAX_LONGITUDE)
#        x =  int(((lon +180.)/360.)*n)
#        print('z {} lon {} x {}'.format(zoom, lon, x))
#        return x

    def get_y(self, zoom, lat):
        if self.is_xy:
            return lat
        y= super().get_y(zoom, lat)
        print("getY {} {} {}".format(lat, zoom, y))
        return y
#This is an alternate implementation from openstreetmap.
#        n = 2.**zoom
#        lat = clamp(lat, MIN_LATITUDE, MAX_LATITUDE)
#        lat_rad = math.radians(lat)
#        y= int(n*(1.-math.asinh(tan(lat_rad))/pi)/2.0)
#        print('z {} lat {} y {}'.format(zoom, lat, y))
#        return y

    def get_lon(self, zoom, x):
        if self.is_xy:
            return x
        return super().get_lon(zoom, x)

    def get_lat(self, zoom, y):
        if self.is_xy:
            return y
        return super().get_lat(zoom, y)

main.py:

from kivy.app import App
from kivy_garden.mapview import MapView, MapSource
from local_source import LocalMapSource
from kivy.uix.widget import Widget
from kivy.properties import (
        NumericProperty, ReferenceListProperty, ObjectProperty
        )

class MapViewApp(App):
    def build(self):
        mapview = MapView(
                zoom=11, lat=-27.5399, lon=152.8045)

        mapview.map_source=LocalMapSource('local_dir')

        return mapview

if __name__ == "__main__":
    MapViewApp().run()

Expected behavior
A clear and concise description of what you expected to happen.
I expect the system to display the map correctly. To produce the correct y index for the relevant image. And to order neighbours in the vertical direction correctly.
I found a fix for the y value of the center image by removing the negation in this clamp
https://github.com/kivy-garden/mapview/blob/216ea421cd037d52972c03a4c708efaaf3629dbe/kivy_garden/mapview/source.py#L162
That fixes the indexing issue. However the images are still in reverse order in the N-S direction. see image below:
Logs/output
If applicable, add screenshots to help explain your problem.
Platform (please complete the following information):
Linux, python 3.8

anch/commit
Additional context
Add any other context about the problem here.

I statically hosted my data on a nginx server and it worked correctly, so there is an issue with my LocalMapSource. Appreciate any help to debug.

Can you please tell me which kind of map data is in your local dir?

Hi @aamirawan7584 is is the same kind of map data that is hosted by a static file server, ie same directory layout, same data. Only difference is I am accessing my data from local file lookup instead of accessing the static file server.


[WIP] faster subspace methods (subsampling and other optional parameters)

Subspace methods can have cubic complexity with the number of samples and we believe that subsampling can be an efficient way to learn an approximate subspace

we should check https://scikit-learn.org/stable/modules/generated/sklearn.kernel_approximation.Nystroem.html#sklearn.kernel_approximation.Nystroem

Closing this because other more general implementation with Adapter/Transformer is coming


Fixes navigation for base class methods declared in other assemblies

Fix for #163

@ajryan,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by Microsoft. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot

@ajryan : Apologies this took some time. We've been heads down with a few release activities.

Thanks for the thorough review! I'll take some time to address the issues soon.

Last changes should resolve your comments. Sorry for the slow turnaround, and thanks again for welcoming my work!

No problem. Thanks again. This should just make #164 a simple flip of a switch now.


GCC's -fstack-protector fails to guard dynamic stack allocations on Aarch64

On September 12th, 2023 Meta's Read Team disclosed a vulnerability in GCC on AArch64 targets tracked as CVE-2023-40339 that causes GCC's stack smashing protection not to detect or defend against overflows of dynamically-sized local variables such as variable-length arrays or buffers allocated using alloca().
At the time of disclosure, all version of GCC from 5.4.0 to trunk as of 2023-05-15 were affected.
In response, Arm issued an advisory containing a patch that has been backported to GCC 7 - 13 and are incorporated to new releases of Arm GNU Toolchain.
Given that the Compiler Options Hardening Guide for C and C++ Guide recommends the use of GCC's stack smashing protection the guide should address this to ensure readers on Aarch64 targets benefit from stack smashing protection using patched version of GCC.

Are we trying to make sure developers know about all vulnerabilities in gcc?  If so, why are we stopping with this one just because it's new?  If not, why aren't we just telling people to use the latest, supported releases of GCC?

@ware - I think what's different is that (1) even using the latest supported release of upstream GCC won't fix the problem, and that (2) it's a huge bug specifically in its protection mechanism. Even when the fix is released, it'll take a while for this fix to propagate.
I think encouraging the use of the latest releases of compilers is in theory a good idea, though I think many developers of embedded systems would laugh and wonder when they'll be able to update to a compiler version that's only several years out of date :-(.
There's no point in noting all bugs, but this one seems different and worth noting.

I get that but I also don't how long it will be relevant.  You say "even when the fix is released" but it is released and already actively being integrated into Linux distributions.  I mean, I'll defer but Debian has it fixed in gcc-11, gcc-12 & gcc-13.  Yes, still not fixed in previous releases.
I get that this is in a security feature and that changes the profile, but security feature or not, if someone is using an older compiler, they can be vulnerable to any of these.  For example, CVE-2018-12886 is also about a bug in -fstack-protector on ARM.  I know there's embedded people using those affected compilers still.  Should we be warning them of that?
Again, I'll defer as I wasn't in the conversation that generated this issue, but the decision to put this in feels arbitrary.

ARM has release a patch and backported to GCC Releases 7-13.  The backported patch has been applied to all actively maintained release branches of GCC.  I don't know if ARM has asked the GCC Release Managers for an emergency release of the actively maintained branches, but the patch will be included in the next official instance of each release of GCC (GCC 11.5, GCC 12.4, GCC 13.3, and GCC 14.1).
Also, the Linux distros can backport the patch to their system compiler and optional compilers, e.g., Red Hat Developer Toolset.  Just because the upstream release doesn't contain the patch, doesn't mean that packaged versions of GCC are lacking the patch.  Most developers do not build GCC from sources, they use the package in their Linux distribution or an SDK provided by their vendor.
Yes, this is a security risk in code generated by GCC, but this is a best practices document, not an enumeration of all CVEs in all Open Source tools.  This bug will not be relevant as inhibiting best practices for all times.  As @ware states, this seems arbitrary.

Best practices is to use the -fstack-protector option.  Yes, that option or any other recommended option in the best practices guide may contain a bug at any arbitrary point in the past or future lifecycle of the software mentioned.  Is the best practices guide going to enumerate all previous bugs? Is it going to be updated each time that a bug or CVE is reported?
Maybe include a disclaimer that any of the recommended options can contain bugs and it's recommended that developers / users check for known vulnerabilities in the options and update to the latest release addressing bugs in the particular options that affect their platform.

Soon the Best Practices guide should recommend the newly proposed -fhardened option:
patch and thread

Thanks for the active input on this. I think the discussion here and in PR #235 is valuable in understanding the broader question of how to deal with issues which might undermine the effectiveness of the recommended options.
I think the point made by @edelsohn that trying to enumerate bugs is not something a best practices document should do is fair. I think not only would it be impractical to maintain, but I'd fear the guide would become too unwieldy to read as well.
At the same time, I'm troubled by leaving this particular issue unaddressed for the following reasons:

the list affected versions of GCC is extensive
in an ideal world the fix would propagate with upstream releases and distribution updates in a timely manner, but  as @david-a-wheeler points out, especially in embedded systems development it is (unfortunately) common that updates to the compiler may not be done routinely but for specific, perhaps sometimes pressing reasons

For adopters of -fstack-protector CVE-2023-40339 may be such a pressing reason and there may be at least some value in getting the word out through outlets such as the Compiler Hardening Option Guide.
I however, do acknowledge that the wording in ossf@2ff5054459777dfe178b925ef86c91cbe8a87ed3 strays too far in the 'enumerating CVEs' direction and do think it can be positioned more appropriately.
Based on the discussion so far, I see two possible ways forward:

a general disclaimer, as suggested by @edelsohn
for the broader question, articulating what criteria the guide should have for covering issues which may undermine the the effectiveness of the recommended options to avoid falling in the trap of covering arbitrary bugs
based on the above, either rewording #235 or settling with the general disclaimer if CVE-2023-40339 falls outside the chosen criteria

The -fhardened options should be addressed in a separate issue, I've opened #240 for this.


DO NOT MERGE: Performance question

I was trying to modify the chunking algorithm with an attempt at a Fail constructor, and I got a little bogged down by the implementation, which has 3 mutually recursive functions, one of which uses mutation to update the stream.  I decided to just try the simpler thing where we'd convert the Doc into a text/line stream, and render that in an immutable way.
The change is straightforward, and removes all the mutual recursion, but of course is slower.  Around 50%-70% slower from just running the benchmarker.  I have a couple questions:

Could some Scala expert give some intuition on why it's so much worse?  Is it all the extra allocations for Thunks?  I'm relatively new to Scala, and don't have a good sense of this.

I tried marking loop in best as @tailrec, but it complained about the loop in the Thunks.  (I had to change them to cheat.)  Since they're in a call-by-name position, I wouldn't think the compiler would consider them as a non-tail-call.  I tried changing Thunk to take () => A, and that didn't work either.  I maybe have a different understanding of what a tail call is, but I wouldn't think putting a call in a data structure would qualify as a non-tail-call.  What am I getting wrong?

Thank you!

for tailrec, the call can only appear in the tail position, no thunk calls. You need to use the cheat trick even for thunks.
As to performance, thunks are just slow. Internally we want to be nasty, mutable, etc... and just hide it from the users.
Make the fewest possible allocations, fewest use of closures and functions, etc... functions are not inlined very well by the java JIT, method calls for classes with few subclasses are best (few being like 1 or 2 subclasses, after that it becomes "megamorphic", which causes the JIT to not handle it as well).

Thanks!


challenges with tzdata in loading the Docker image

First thanks for the great work!!! Really looking forward to working with it.
Here is my data point on building the Docker image (I'm using focal building with ./build.bash noetic ). It kept getting hung up on tzdata - this seems to be a common problem in Docker (https://stackoverflow.com/questions/44331836/apt-get-install-tzdata-noninteractive)
Here was the solution that finally worked for me.
ARG DEBIAN_FRONTEND=noninteractive
RUN apt-get update && apt-get install -y tzdata
RUN unlink /etc/localtime
RUN ln -s /usr/share/zoneinfo/America/New_York /etc/localtime
Best,
dph

Hi,
This line
ARG DEBIAN_FRONTEND=noninteractive

is something we often use, and is already in the Noetic Dockerfile in the dockwater repo that we recommend to use:
https://github.com/Field-Robotics-Lab/dockwater/blob/a2a046cb36689cd0fb24ff53d8fcb1f04d1d4f5c/noetic/Dockerfile#L38-L43
The unlink and setting a hardcoded time shouldn't be necessary... I've never needed that locally.
In any case, thanks for posting a solution! As the issues board is a ticket queue of problems waiting to be solved, and this ticket isn't a problem, I'm going to close it. If people run into this issue, they can search in the issues board to find this ticket. Thanks!


removing extra pom file entires

@prashant1067 Please pull the newest changes from the master branch. I can already see that you are trying to work on outdated files


Sort list and add Greenhouse

Checklist:

[ ] Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
[ ] The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
[ ] I have written unit and/or e2e tests for my change. PRs without these are unlike to be merged.
[x] Optional. I've added My organization is added to the README.
[ ] I've signed the CLA and required builds are green.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


python setup.py install

running install_data
error: can't copy 'doc/trimage.1': doesn't exist or not a regular file

There. Forgot to add the doc page to the repository. Should be alright now! :)

aye aye. confirmed. thank you!


Split a Pane - commandLine

Under "Split a Pane" the Action "commandLine" (upper case L) is listed.
In order to set the command line to run in the new pane I needed to use "commandline" (with a lowercase l).

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 9f8ea878-10c3-84e3-1122-5d41d6ea360b
Version Independent ID: c752eba5-6680-16bc-7a4b-67de156a0f96
Content: Windows Terminal Key Bindings
Content Source: TerminalDocs/customize-settings/key-bindings.md
Service: terminal
GitHub Login: @cinnamon-msft
Microsoft Alias: cinnamon

Fixed. Closing. :)
https://docs.microsoft.com/en-us/windows/terminal/customize-settings/actions#split-a-pane


Add etcd support for service discovery

The problem faced currently?
Currently, we just have consul for a distributed mode setup. Etcd is a more popular store as compared to Consul
How can we solve it?
Lets add support for etcd!!

If you want this feature to be implemented, give it a thumbs up reaction, so that we can determine which features are important to you.
👍

Coming in v0.15.0


Add error handling when CDN fails

I'm planning to use the editor in an environment where the web app comes from a local network and the internet is not always reliable or available. I need a way to react to failed initialization (CDN loading) of the editor.
Are there any hooks or mechanisms I can use to implement this right now?
Currently I only get a logged error https://github.com/imguolao/monaco-vue/blob/37aca64a5cce3480960cfd0b8b7fe75e03c9f47a/packages/editor/src/hooks/useMonaco.ts#L10-L22 but haven't found a way to react to it properly.
I'm planning to fall back to a simple textarea. Maybe this fallback mode could also be a built-in feature of this plugin?

Try the following code ( copy to the local html file and open in your broswer ):
<!DOCTYPE html>

  <meta charset="UTF-8">
  <meta name="viewport" content="width=device-width, initial-scale=1.0">
  <title>UMD Example</title>

I would consider adding an ErrorBoundary component using the ErrorCaptured lifecycle to do the fallback.

I would consider adding an ErrorBoundary component using the ErrorCaptured lifecycle to do the fallback.

But I've been busy lately and need to wait.

The above fallback solution works for me. Thanks 🙏
I also like the direct import of the component instead of plugin install. I wasn't aware of this option since the documentation only mentions install.


Non PMDD at restore  - old copy

Name of the keeper using which the wallet was restored does not show up in the F&F list
User A was a keeper who was changed and then UserB was keeping the share. Restored via UserB, seems like non pmdd still has UserA's reference

Unable to recreate it. May be as Anant mentioned the data was not backedup.
Tried changing the contact to another contact and then restored, it worked,


create scdl domain

http://www.scdl.net/
http://www.scdl.net/distance-learning-in-information-technology.aspx
The IT industry has emerged as one of the fastest growing sectors of the Indian economy. Given the unprecedented growth of IT industry, organisations require manpower that is proficient in both information technology as well as business aspect. A successful IT enterprise will have the right mix of sterling technology systems and proven business strategies. Developing these systems requires extensive communication between technical developers, business managers and users.
With the rapid growth in international trade in various countries, Post Graduate Diploma in IT Management program with an emphasis on utilising information technologies for productivity and competitiveness, prepares you to succeed in your IT management career. The program's unique focus on the management of technology effectively prepares students for successful careers in the dynamic and fast-paced information technology marketplace.
In addition, the unique blend of courses will enable you to gain real world experience that will be invaluable to the development of your skills and your future employability. The curriculum produces students to succeed in IT management positions, which are projected to be amongst the fastest growing through the next decade.
Career Opportunities:
Project Manager, IT Manager, System Analyst, Business Analyst, Technical Leaders, Software Consultant etc.

@patilosfl What is the email domain of this organization? In other words, what the students' email addresses end with? @scdl.net? If yes, the filename in this request has to be lib/domains/net/scdl.txt in order to follow the repository rules. Please ensure you are familiar with this repository rules located at the bottom of this page and rename the file accordingly.

@patilosfl As soon as you rename the file, I'll satisfy your request as soon as possible because SCDL is in the list of AICTE approved institutions (A.Y. 2016-17) as on 30th April 2016.

@patilosfl I am sorry, this request remains unanswered for a while. I have to close it without merging. Please reopen and comment if you have an update regarding the abovementioned issue. Thank you for the understanding!


Questions to use melgan on my own dataset

Hi, I encounter some problems when I try to use melgan on my dataset.
The first one is that you comment in the default.yaml that we should leave the hop_length to 256. Why can't I change the value? Is this some limitations of the model structure?
The second question is that in the MelFromDisk class, you use a mapping in the __getitem__ under training set. What is this mapping used for? I think the input idx is between [0, len(wav_list)) and the mapping also has the same interval.

Is this some limitations of the model structure?

Yes, the model architecture upsamples the mel-spectrogram by 256 times, so the hop_length can't be changed.

What is this mapping used for?

I intended to use different batch for D/G update in a single epoch by using this random mapping.