Created TestSObjectBuilder.cls

For the foreseeable future, Nebula will remain an unmanaged package (Salesforce's requirements for managed packages make it difficult to make certain changes, like deprecating classes and methods). Ideally, it should be possible to easily upgrade Nebula between minor versions (example: v2.0 to v2.1). However, in order to provide test coverage, Nebula needs to occasionally create & insert records in unit tests. When deployed to an org with custom required fields, Nebula's tests will fail because the tests do not know about the custom fields.
To make upgrades easier - and to provide a reusable test data generator - the class TestSObjectBuilder has been created. I also plan to limit test data generation to 3 standard objects. If no required fields have been added to these objects, then no additional action will be needed to get Nebula to work. But if custom required fields have been added, then an additional class needs to be created to tell Nebula what fields & values to use for creating test records

Account - class 'TestAccountBuilder' that extends TestSObjectBuilder.Base must be created
Contact - class 'TestContactBuilder' that extends TestSObjectBuilder.Base must be created
Lead - class 'TestLeadBuilder' that extends TestSObjectBuilder.Base must be created

Since these classes will be created directly in the org and are not part of the Nebula repo, they will not be overwritten during upgrades. This will allow Nebula to be upgradeable without having to directly modify the framework.
Fixes #43

Closing this PR - I'm going to use a different approach instead.


Is docs-src/generate supposed to be missing?

I've noticed that the docs.js in scripts imports docs-src/generate, but no commands I run seem to produce that file.

That's dead code. The doc generation happens through gatsby now and that references our old build system.
scripts/docs.js and gulpfile.js can be removed.

Ah, I was having issues with hot reloading and thought that might be related, but the problem seems to be with gatsby's HMR. I think I found the root of the issue in an old closed thread though, so I'll see if I can situate that when I get home.

Also, I could PR in that code cleanup after I'm finished the time picker if you want to make an issue listing it and any other dead code that could be cleaned up.


Numeric issue in LayoutLm on CPU

What happened?
The output from IREE CPU and golden values mismatch.
Steps to reproduce your issue
Download the artifacts from https://storage.googleapis.com/iree-shared-files/nod-perf/hanchung/layoutlm_repro.zip
$ iree-compile --iree-mlir-to-vm-bytecode-module --iree-input-type=mhlo --iree-hal-target-backends=dylib-llvm-aot --iree-llvm-target-triple=x86_64-linux-gnu --iree-llvm-target-cpu-features=host core-input.mlir -o /tmp/a.vmfb
$ iree-run-module --module_file=/tmp/a.vmfb --device=local-sync --entry_function=forward<EMAIL_ADDRESS><EMAIL_ADDRESS>--print_max_element_count=1073741824

What component(s) does this issue relate to?
Compiler
Version information
No response
Additional context
No response

Coming from https://github.com/iree-org/iree/issues/9536#issuecomment-1166945952. The results are very different. E.g.,
Failed @ position 0 : -1.532623 v.s. 1.50368261

Sure! @powderluv FYI adding this bug to our hotlist.

@hanhanW Is 1.50368261 the correct value? I reran your sample on CascadeLake CPU and got the results which are very close to the expected_out.txt
I also ran the test https://github.com/nod-ai/SHARK/blob/main/tank/tf/hf_masked_lm/layoutlm-base-uncased_tf_test.py#L105 and it pass now.

Interesting... maybe it's fixed by other changes recently. I'll verify it again, thanks!

I verified that the numeric issues are gone. Sometimes it fails because of accuracy, but I think it's fine. Closing the issue.
@powderluv , the SHARK tests are not deterministic. The input data and expected output are changed between runs. Can we have deterministic tests in the integration tests? Otherwise, it's hard to verify if the issue is addressed.


Toggleable Dark Mode

It's me again! Still loving the app. Main source of music during the week. Like to have dark mode on everything, so i added it here as well.
Would love to help with anything else you may need or want to add! Have had a blast working on it. I have been wanting a little fun project to contribute to that is not work related and been really enjoying this one!

Amazing! I absolutely love this, thanks for adding it :) Yeah I will definitely take you up on that help, I'm glad you're liking working on it. I wasn't gonna update this much after its initial release but you've inspired me to keep chipping away at it. Feel free to come up with stuff you think would be cool to see.
I've pulled down the PR and did some minor styling tweaks/fixes for the ShortcutModal I added; the text was showing up black in dark mode. I'm new-ish to collabing on github so I'm assuming I should merge my version of the branch as a new PR w/ a comment referencing this PR, and then close this PR w/ a comment referencing the merged PR. I just want to make sure that you get credit for doing the implementation! Let me know if that's what I should be doing. Thanks again!!

Awesome! I believe you can actually add a commit to my branch since you pulled it down and a maintainer of the upstream repo. More Info. This should keep all the branches in sync and since it is all separate commits i still get the credit for the code changes in my commit in this pr and you would just approve this pr pulling all changes into master. Thanks for looking out for me and making sure i get the credit! I appreciate it.
Next thing i would love to add is a back end of some sorts to keep Local storage settings synced up.

Ah that's perfect! Thanks for the info, it's much appreciated. I'll shoot you an email to the address in your commits and we can get some stuff going :) Thanks again!


Make … html safe when rendering HiddenTextExpander

Without the html_safe call, the page rendered the actual … text instead of ...

LGTM!
any idea why this looks fine on the prod docs page?

probably something in the HTML -> markdown conversion


Bump BK version to 4.6.0-SNAPSHOT

Why?
Currently BK is on 4.6.0 development schedule. We are aligning the release schedule with BK schedule. so we need to depend on 4.6.0-SNAPSHOT. when BK 4.6.0 is released, the DL 0.6.0 library will be released as well.

close this, since PR #198 merged it.


Dropped srcset candidate for 2x images

Hello there,
I have an issue using the picture element in v5.2.2:
<picture>
   <source
      data-srcset="/img/c-djp/djp_1@0.3x.jpg?v=0 1x, /img/c-djp/djp_1@0.6x.jpg?v=0 2x'"
      media="(max-width: 400px)">
   <source
     data-srcset="/img/c-djp/djp_1@0.6x.jpg?v=0 1x, /user/themes/boanastories/img/c-djp/djp_1@1.2x.jpg?v=0 2x'"
     media="(max-width: 1536px)">
   <source
      data-srcset="/img/c-djp/djp_1@1x.jpg?v=0 1x, /img/c-djp/djp_1@2x.jpg?v=0 2x'"
      media="(min-width: 1537px)">
   <img data-src="/img/c-djp/djp_1@1x.jpg?v=0" alt="" class=" lazyloaded">
</picture>

I keep getting the error:

lazysizes.min.js?g-03e2ff4e:3: Failed parsing 'srcset' attribute value since it has an unknown descriptor.
Dropped srcset candidate "/user/themes/boanastories/img/c-djp/djp_1@2x.jpg?v=0"

Any idea how to solve this?

Damn, 5 min later I found my typo :-D Closing it!


any ways to get a tweet thread?

Hi, first of all, love this lib and thanks for putting it up.
I was wondering if there are methods to retrieve or build a thread from a tweet. It seems like "conversation_id" is the start of a thread, but im not sure how to go from here.
Any suggestions?

Hey, thanks. For that kind of data you'll need to use scraper.tweets_details(), then parse the nested data, looking for each result's items array. Here's one way you can do this:
from twitter.scraper import Scraper
from twitter.util import *
import pandas as pd

scraper = Scraper(session=init_session())

# example tweet
tweet = scraper.tweets_details([1476988122986647553], limit=500)

# unnest items and filter deleted tweets
items = [y for x in find_key(tweet, 'items') for y in x if not find_key(y, 'tombstone')]

# index into relevant data points
tweet_results = [x.get('result') for x in find_key(items, 'tweet_results')]

df = (
    pd.json_normalize(tweet_results)
    # remove duplicate replies if needed
    .drop_duplicates('rest_id')
    # clean up column names for illustrative purposes
    .assign(date=lambda x: pd.to_datetime(x['legacy.created_at']).dt.strftime("%Y-%m-%d %H:%M:%S"))
    .assign(root_tweet=lambda x: x['legacy.conversation_id_str'])
    .assign(text=lambda x: x['legacy.full_text'])
    .assign(tweet=lambda x: x['rest_id'])
    .assign(username=lambda x: x['core.user_results.result.legacy.screen_name'])
    # sort by newest replies to root_tweet
    .sort_values('date', ascending=False)
    .reset_index(drop=True)
)
df[[
    'date',
    'username',
    'tweet',
    'text',
    'root_tweet',
]]

Output

@trevorhobenshield thanks!!! you are the ultimate twitter jedi master :)


prove: Refactor calculateRoots to calculateHashes

calculateRoots is refactored to calculateHashes to support returning of the intermediate hashes that were calculated when hashing up to the root.
This is useful for updating cached proofs.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

84 of 98 (85.71%)  changed or added relevant lines in 2 files are covered.
21 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-1.0%) to 83.596%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

stump.go
0
1
0.0%

prove.go
84
97
86.6%

Files with Coverage Reduction
New Missed Lines
%

prove.go
21
90.64%

Totals

Change from base Build<PHONE_NUMBER>:
-1.0%

Covered Lines:
2227

Relevant Lines:
2664

💛  - Coveralls


Components are constantly re-rendered

If you clone cosmos-example and add a console.log in the render method of SimpleButton.jsx you will notice that every component is constantly re-rendered:

Is there any way to prevent that?

Is there any way to prevent that?

Currently, not really. The only time when this stops is when you focus on the fixture editor. When you're not focused on the fixture editor ComponentPlayground polls the loaded component for state changes and updates the fixture contents every 100ms...
... even when the state didn't change, which is were the problem lies.
Now, the thing is the props for the loaded component don't change, but the component renders because the parent (ComponentPlayground) renders. Why does the parent render? Because of the setState (3rd link below). But it shouldn't re-render if the state is the same.
So a quick solution might be to implement a PureRenderMixin implementation for ComponentPlayground.shouldComponentPlayground, but with deep comparison. My only worry is that it might be less performant to deep compare entire fixture (props/state) trees every 100ms than to trickle down the render without DOM changes to apply as a result, but I might be wrong.
FYI, here is the relevant code:

Where the interval is set
When the update is ignored
How fixture contents are updated with component state

Thank you for the detailed response! Much appreciated!
Perhaps we could represent the ComponentPlayground's state using something like Immutable.js, so that it would be trivial to implement shouldComponentUpdate?

Perhaps we could represent the ComponentPlayground's state using something like Immutable.js, so that it would be trivial to implement shouldComponentUpdate?

Yes, that thought went through my mind more than once, but I have zero experience with immutability and until recently myself and the company I work at were the only Cosmos users.
Sound like a good time to learn. Let me know if you have any ideas or insights :dancers:

@moretti fixed this in<EMAIL_ADDRESS>https://github.com/skidding/react-component-playground/pull/17
Remove cosmos-js from node modules, install again and should no longer render endlessly. Let me know if doesn't work as extended.


Content of file gets deleted when saving over a network mapped drive.

Description
I'm connected to my school's network mapped drive from my home computer (running Ubuntu). But when I try to save any files Atom deletes the contents of the files! What can I do to retrieve my files? Lost days of work.
Steps to Reproduce

[Connect over a network mapped drive]
[Open the file, try to save it]
[Content of file gets atomically deleted.]

Versions
Atom    : 1.25.1
OS: ubuntu 16.04 LTS

Thanks for the report  and sorry for the trouble here - can you share more details about the issue?

Is it not necessary to make changes to a file, you just open it and try to save it and the file content is deleted?
Can you reproduce with any file on the network drive (e.g. with a test file)?
If you can reproduce, do you get any error messages or see any errors in devtools console?
Do you see any errors in devtools console when you start Atom?
If you can reproduce, can you reproduce in safe mode (atom --safe)?
Did saving work fine previously and just started behaving like this recently?
Did you install Atom with one of the official installation methods mentioned in https://flight-manual.atom.io/getting-started/sections/installing-atom/?

Same problem here. For me it started about a week ago, but that's probably just because I'm lazy with updating my system. To answer your questions:

It's not necessary to edit a file. Just opening a file and hitting CTRL+S will do it every single time. However, when I do edit a file before I save it there seems to be a 1:2 or 1:3 chance for it to happen, which makes it even more strange. It is possible to undo (CTRL+Z) and save again to undo the damage.
Happens to every single file on the network share. It also doesn't matter if it's in a git controlled directory or not. The network share itself is a directory on our department's hpc cluster, 'mounted' with SFTP/GVFS through my file manager.
I don't get any error messages in the atom screen itself. Devtools console however does display some messages, which seem to differ for the type of file (shell vs python)

shell:
[Violation] 'setTimeout' handler took 68ms <embedded>:80180
[Violation] 'setTimeout' handler took 65ms <embedded>:80180
python:
[Violation] 'requestAnimationFrame' handler took 86ms
[Violation] Forced reflow while executing JavaScript took 41ms
[Violation] 'requestIdleCallback' handler took 72ms <embedded>:536
[Violation] 'requestAnimationFrame' handler took 51ms

I can't get the console open quick enough at startup, the only messages I'm able to catch are:
[Violation] 'requestIdleCallback' handler took 104ms index.js? [sm]:40
[Violation] 'requestIdleCallback' handler took 66ms index.js? [sm]:24
[Violation] 'requestIdleCallback' handler took 115ms
Tried starting atom with --safe, but the deletion problem persists, unfortunately
Started about a week ago, but the problem might be older than that since I hadn't updated in a few weeks. Before that I never experienced any problems like this one.
I did install atom with the official instructions under the Deb/Ubuntu paragraph: https://flight-manual.atom.io/getting-started/sections/installing-atom/#platform-linux

OS & atom version information:
Distributor ID:	Ubuntu
Description:	Ubuntu 18.04 LTS
Release:	18.04
Codename:	bionic
Atom    : 1.27.2
Electron: 1.7.15
Chrome  : 58.0.3029.110
Node    : 7.9.0
I hope this helps finding the problem

Thanks @PeanutCoder - if you try the different options under Settings > File System Watcher, does that make any difference?
Also, if you can try the 1.28 beta, does that have the same behavior in safe mode?

@rsese thank you for the suggestions. The Experimental filesystem watching library and Emulate with Atom events options seem to "lower the chance" for the deletion to happen (~1:5), but they do not prevent it entirely from happening. The other two options don't change anything regarding the deletion behaviour.
I'll check out the 1.28 beta when I have some spare time later this week, as this is happening on my workstation at work.

So this morning I still had the problem/bug. Over the course of the weekend there had been some unattended upgrades for which I had to reboot my computer. I upgraded the remaining packages as well and rebooted the system. Since then the problem seems to have been fixed. I've got no clue as to which package was the actual culprit, so I'll just include the entire list of packages that have been upgraded since friday, maybe it makes sense to you guys:
Start-Date: 2018-06-15  06:22:09
Commandline: /usr/bin/unattended-upgrade
Upgrade: perl-modules-5.26:amd64 (5.26.1-6, 5.26.1-6ubuntu0.1)
End-Date: 2018-06-15  06:22:09

Start-Date: 2018-06-15  06:22:12
Commandline: /usr/bin/unattended-upgrade
Upgrade: perl-base:amd64 (5.26.1-6, 5.26.1-6ubuntu0.1), libperl5.26:amd64 (5.26.1-6, 5.26.1-6ubuntu0.1), perl:amd64 (5.26.1-6, 5.26.1-6ubuntu0.1)
End-Date: 2018-06-15  06:22:15

Start-Date: 2018-06-15  06:22:18
Commandline: /usr/bin/unattended-upgrade
Remove: linux-headers-4.15.0-20:amd64 (4.15.0-20.21)
End-Date: 2018-06-15  06:22:19

Start-Date: 2018-06-16  06:30:07
Commandline: /usr/bin/unattended-upgrade
Upgrade: libmagic1:amd64 (1:5.32-2, 1:5.32-2ubuntu0.1), libmagic-mgc:amd64 (1:5.32-2, 1:5.32-2ubuntu0.1), file:amd64 (1:5.32-2, 1:5.32-2ubuntu0.1)
End-Date: 2018-06-16  06:30:09

Start-Date: 2018-06-18  12:33:31
Commandline: apt upgrade
Requested-By: peanutcoder (1000)
Upgrade: gnome-control-center-data:amd64 (1:3.28.1-0ubuntu1, 1:3.28.1-0ubuntu<IP_ADDRESS>), netplan.io:amd64 (0.36.1, 0.36.2), update-manager-core:amd64 (1:18.04.11, 1:<IP_ADDRESS>), gnome-control-center:amd64 (1:3.28.1-0ubuntu1, 1:3.28.1-0ubuntu<IP_ADDRESS>), gnome-software-plugin-snap:amd64 (3.28.1-0ubuntu4, 3.28.1-0ubuntu<IP_ADDRESS>), cups-pk-helper:amd64 (0.2.6-1ubuntu1, 0.2.6-1ubuntu1.2), update-manager:amd64 (1:18.04.11, 1:<IP_ADDRESS>), gnome-software:amd64 (3.28.1-0ubuntu4, 3.28.1-0ubuntu<IP_ADDRESS>), google-chrome-stable:amd64 (67.0.3396.79-1, 67.0.3396.87-1), python-apt-common:amd64 (1.6.0, 1.6.1), gdm3:amd64 (3.28.0-0ubuntu1, 3.28.2-0ubuntu1.2), command-not-found-data:amd64 (18.04.4, 18.04.5), ubuntu-release-upgrader-qt:amd64 (1:18.04.18, 1:18.04.19), gir1.2-gdm-1.0:amd64 (3.28.0-0ubuntu1, 3.28.2-0ubuntu1.2), nplan:amd64 (0.36.1, 0.36.2), apport:amd64 (2.20.9-0ubuntu7.1, 2.20.9-0ubuntu7.2), libgdm1:amd64 (3.28.0-0ubuntu1, 3.28.2-0ubuntu1.2), python3-distupgrade:amd64 (1:18.04.18, 1:18.04.19), python3-commandnotfound:amd64 (18.04.4, 18.04.5), ubuntu-software:amd64 (3.28.1-0ubuntu4, 3.28.1-0ubuntu<IP_ADDRESS>), python3-update-manager:amd64 (1:18.04.11, 1:<IP_ADDRESS>), ubuntu-release-upgrader-core:amd64 (1:18.04.18, 1:18.04.19), python3-apport:amd64 (2.20.9-0ubuntu7.1, 2.20.9-0ubuntu7.2), gnome-control-center-faces:amd64 (1:3.28.1-0ubuntu1, 1:3.28.1-0ubuntu<IP_ADDRESS>), apport-gtk:amd64 (2.20.9-0ubuntu7.1, 2.20.9-0ubuntu7.2), ubuntu-release-upgrader-gtk:amd64 (1:18.04.18, 1:18.04.19), command-not-found:amd64 (18.04.4, 18.04.5), apport-kde:amd64 (2.20.9-0ubuntu7.1, 2.20.9-0ubuntu7.2), desktop-file-utils:amd64 (0.23-1ubuntu3, 0.23-1ubuntu<IP_ADDRESS>), gnome-software-common:amd64 (3.28.1-0ubuntu4, 3.28.1-0ubuntu<IP_ADDRESS>), python3-problem-report:amd64 (2.20.9-0ubuntu7.1, 2.20.9-0ubuntu7.2), wireless-regdb:amd64 (2016.06.10-0ubuntu1, 2018.05.09-0ubuntu1~18.04.1), python3-apt:amd64 (1.6.0, 1.6.1)
End-Date: 2018-06-18  12:33:49

Ctrl-s or save from file menu deletes file content from any file opened via sftp.
This issue exists with a fresh install of Atom (1.26.1-1~webupd8~0) Ubuntu 16.04 LTS (no previous version of Atom installed)
Issue can me resolved by creating recovery directory under ~/.atom.
This folder is not being created by default on new install of Atom...
Deleting recovery directory recreates issue.

This has been resolved in 1.28 beta which auto-creates the recovery folder on first save of any file


gdrcopy deb dependency on gdrdrv-dkms is problematic for containers

In a container userspace, we would typically install the gdrcopy_.deb (gdrapi), but not gdrdrv-dkms.  Unfortunately, gdrcopy_.deb has a dependency on the kernel-mode driver deb package.  While that's fine on bare metal, it doesn't really make sense for a containerized deployment.
The way CUDA handles this is to have cuda-toolkit and cuda-drivers packages that do not advertise any dependency on each other, and there is a cuda metapackage that depends on both for ease of installation.  Could we do something like that here?

The PR has been merged. Closing this issue.


openFirstPaymentMethod not working with v5 sessions

The property openFirstPaymentMethod is not working with v5 sessions.  This is working for us on the older version, non-session workflow.
Windows, Chrome.

Hi @carter-roller ,
I didn't manage to reproduce this on my side. I tried with v5.11.0 and it seems to be working as expected. How are you setting the property?
For instance, I tried the following:
const dropin = checkout.create('dropin', {
    openFirstPaymentMethod: false,
    openFirstStoredPaymentMethod: false
}).mount('#dropin-container');

Thanks @ribeiroguilherme .  I did not realise there was separate options as per your example, I was putting all the configuration in await AdyenCheckout(configuration).
Confirmed working 👍

Thanks @ribeiroguilherme .  I did not realise there was separate options as per your example, I was putting all the configuration in await AdyenCheckout(configuration).
Confirmed working 👍


[TC-TCCMS-2.2] SDK has to be implemented for Refrigerator and Temperature Controlled Cabinet Cluster

Summary:
All-clusters-app has to be enabled with below mentioned Command :

[ ] ChangeToMode

All-clusters-app has to be enabled with below mentioned Attribute :

[ ]  SupportedModes

GitHub hash of the SDK that was being used
https://github.com/project-chip/connectedhomeip/commit/fa07cc9b30478d5f481db486507d738fae124017
Platform
raspi
Platform Version(s)
RPI - 4, 8GB RAM

Duplicate of https://github.com/project-chip/connectedhomeip/issues/27730

Test case removed from Test plan .


Still seeing "opening storage failed: block dir" on more recent version of prometheus

What did you do?
Restarted my prometheus-operator to increase the cpu limit. Once the restart was performed, my prometheus pod ended up in a CrashLoopBackOff state.
What did you expect to see?
Prometheus pod should have gracefully terminated and restarted with a higher cpu limit
What did you see instead? Under which circumstances?
Prometheus pod comes back in a CrashLoopBackOff state, many of the directories are missing meta.json file.
Similar to this issue: https://github.com/prometheus/prometheus/issues/4058
$ k logs -f prometheus-prometheus-operator-prometheus-0 -n monitoring prometheus
level=error ts=2020-04-04T21:42:45.231Z caller=main.go:727 err="opening storage failed: block dir: \"/prometheus/01E4WDCD2S7Y7X77KZJNZ1S30T\": open /prometheus/01E4WDCD2S7Y7X77KZJNZ1S30T/meta.json: no such file or directory"

Environment

System information:
Linux 4.9.0-11-amd64 x86_64
Kubernetes v1.15.10
Kops v1.15.0
Prometheus backend: NFS mount - AWS EFS (Elastic Filesystem)

Prometheus version:
v2.15.2

Prometheus configuration file:
default prometheus-operator config with increased cpu & memory limit/requests

Logs:

level=error ts=2020-04-04T21:42:45.231Z caller=main.go:727 err="opening storage failed: block dir: \"/prometheus/01E4WDCD2S7Y7X77KZJNZ1S30T\": open /prometheus/01E4WDCD2S7Y7X77KZJNZ1S30T/meta.json: no such file or directory"

NFS is not a supported filesystem.

I'm experiencing similar behavior with azure-file https://kubernetes.io/docs/concepts/storage/storage-classes/#azure-file randomly ending in CrashLoopBackOff state after a pod restart.
@brian-brazil  I wonder what are the supported / recommended file systems to be used with K8S;
I haven't found anything on the documentation providing guidance, any advice? thanks

Seeing the same on SMB (azurefiles) as well. I changed to Azure Disk.
Are SMB supported?

We are closing this as per our bug scrub. NFS is not supported by prometheus.
For SMB, we don't know if it is Posix-compliant. Can we know more about your setup? If you are having issue, please open a dedicated bug with straces so we can determine if we can support it.

Hi,@roidelapluie Is longhorn a supported filesystem?

Does anyone confirm that it's working on Azure file with SMB protocol ?

@flenoir Based on my experience I can confirm that Azure file does NOT work.
I was running a K8S pod with Azure file (SMB) for some time, and I experienced random DB corruptions; at that point if you don't what to loose the whole DB manual intervention is needed.
I ended up migrating to Azure Disk, not having problems since then.

I'm getting the same error:
opening storage failed: block dir: "/prometheus/01F6J0P4KBBWVJD2M8B1PE7C5E": open /prometheus/01F6J0P4KBBWVJD2M8B1PE7C5E/meta.json: no such file or directory
is there a way to fix this?


dialog.showModal function

hello.
I have some huge asp.net website projects, using showModalDialog for popups and using dialog-polyfill. As you know, mozilla doesn't support dialog.showModal() function anymore. So my website have problem for opening popups, all popups have return values too.
Changing config of mozilla disturbs users. Is there any solution for me to continue using this function and do not change config?

Have you tried using the dialog polyfill?

thanks but it didn't help me.
I'm searching minimum cost code changing solution, but I couldn't find anything yet.
I edited showModalDialog.js file and solved shoModal() and close() problem, but in async programming I have problem. because editing whole of my websites with spawn(function*(...)) is so hard and now return value is just undefined. I need something to pause code execution on window.showModalDialog(...) line and after closing popup program continues. something such yield does on generator.
would you help me?

The polyfill provides the eval() fallback if you don't want to use generators. It throws an exception in showModalDialog(), which stops running the code in the surrounding function. Then it evaluates the rest of the function code (with returnValue set) on dialog close.

thank you,
I used this, but after throwing exception, the page refreshes in my project!
why?
I compare my code with your demo and there is no different.

excuse me, I closed issue mistakely :))
please continue your helps.
thanks

The web page should not refresh on thrown exception unless some JS code in onerror handler forces to do so. Could you provide a minimal Proof of Concept on JSBin/JSFiddle?

I got several problems and decided to migrate to jquery modal at last, thank you


Clarify back-buffer identity changes

@john-h-k : Thanks for your contribution! The author(s) have been notified to review your proposed change.


the old database SQLite compatibility

Does your library will be compatible with SQLite? Can I normally use it with my old SQLite database without any modification?
I ask because I have in the production app with traditional  SQLite database with many lines of code and of course I have no way to remove these pieces of code.
I would like to add a new code(using your library) but not delete the old one.

You will almost certainly need to modify at least some of your production code in order to be able to effectively use the library. That being said, it's probably still doable.
One caveat up front: at this time, SquiDB only supports integer primary keys. If you use non-integer primary keys, you will probably have some difficulty using the library. We may remove this limitation in a future release, but don't have an ETA to share right now.
The first thing you'd need to do is define model specs for your table schemas. This will enable the code generator to generate model classes that you can work with in your AbstractDatabase subclass and DatabaseDao.
Our AbstractDatabase class is a wrapper around SQLiteOpenHelper. You will at minimum need to replace instances of SQLiteOpenHelper/SQLiteDatabase with a subclass of AbstractDatabase, since having more than one instance of SQLiteOpenHelper can lead to bad synchronization problems (see this StackOverflow post for more info).
Much of your production code could probably use a singleton instance of your AbstractDatabase subclass in place of calls to SQLiteDatabase. However, you wouldn't be getting many of the benefits of the library, since it's DatabaseDao that does the work of translating between model classes and SQL, ensuring type safety, etc. -- and the apis that DatabaseDao offers are different from those offered by SQLiteDatabase. They're a pretty simple wrapper, so it's all the same SQL under the hood, but it's not a drop in replacement. Furthermore, not all of the SQLiteDatabase apis are available via AbstractDatabase, so you'd probably need to update at least a few calls. Technically you could expose the underlying SQLiteDatabase from your AbstractDatabase subclass and call it directly, but I'd definitely recommend doing that as little as possible and phasing it out as soon as you could update your production code.
I think that the library would be much more useful to you if you updated your production code to use it fully. That being said, you could probably do it step by step and phase out old code over time, rather than immediately if you really wanted to.
Hope that answers your question!

I'm going to assume the lack of activity on this issue means it's resolved. Feel free to reopen it if there are any further questions!


Remove SauceCTL and WDIO GH Workflows

Description

Motivation and Context

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Documentation fix (typos, incorrect content, missing content, etc.)

Checklist

[ ] I have read the contributing document.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

@lysannep I also changed the deployment workflow so that it only runs when there are changes to the main branch. This should also reduce the amount of checks required to merge PRs.

Nevermind, apparently the build check is a required status 🤷

@spider-sauce Thank you! :rocket:


UriResolver does not look at host when scheme is present

When resolving a path for a base url, the combination of the guzzle package and this one results in the host not being set at all.
To explain: the buildUri method in the Guzzle Client always ensures a scheme. So if you have the following base/rel uri:
$base = new Uri('http://example.org');
$rel = new Uri('/foo'); # does not have a scheme

If you request $rel with Guzzle, and you have middleware that uses the resolve method to make a proper uri out of the two:
# in middleware, $rel now has a scheme added by Guzzle
$uri = Uri::resolve($base, $rel);

You would expect this to yield http://example.org/foo, yet the resolver checks for a scheme in $rel and if so, assumes the host is set and returns the normalized $rel without looking at the base uri:
https://github.com/guzzle/psr7/blob/64862e854f876bc5aee2996cab2f552db8586065/src/UriResolver.php#L69-L71
Which results in a uri without a host. Now I don't think it's incorrect that the scheme is added by Guzzle, which is why I create the issue in this repo instead. I think the resolve method should check for both scheme and host in the if statement I linked here above.

ping @mtdowling @Tobion

From what I infer from your description is that you are not using the Guzzle base_uri config option but instead have your own middleware that resolves the /foo URI?
And in your middleware you will receive http:/foo as URI due to the added scheme.
The resolve method should not be changed because it is according to a standard. What we can change is that the http scheme in https://github.com/guzzle/guzzle/blob/master/src/Client.php#L148 is only added if the URI has a host at all.

From what I infer from your description is that you are not using the Guzzle base_uri config option but instead have your own middleware that resolves the /foo URI?

Correct.

What we can change is that the http scheme in https://github.com/guzzle/guzzle/blob/master/src/Client.php#L148 is only added if the URI has a host at all.

That would be great, yes. Should I open a new issue in that repo?

Feel free to create a PR. The change is really simple.

Right, done: https://github.com/guzzle/guzzle/pull/1565


Jquery 2.1.3 & Bootstrap 3.3.1

Seem not to be compatible:
Console error: modal is not a function

I'll check it now

@Lesac76 can you try now with v0.6.2?

I had to deactivate the following line in the Controller where the modal is called:
//modal.element.modal();
And in the template I had to delete the top

Then it works in the old version 0.6 and in the newest 0.6.3 in all current browsers (chrome, firefox, ie, safari) but without the nice dark background and fade in.

Something is definitely wrong then, I've checked out the code to a clean location and it all works fine. Are you using the samples app? If so, make sure to use gulp not grunt to run it. Except for that it should work fine, backdrop included. And you'll need to use modal.element.modal to show the modal. What is your template looking like and what line did you delete?

https://github.com/dwmkerr/angular-modal-service/issues/14
You suggested on one of the older issues to extra include bootstrap modal. I tried that and it solved my problem. Seems like gulp wasn't including bootstrap js files.


Updated & fix integration of openscad-openjscad translator

This PR :

fixes the issues with the translator and our new infrastructure.
depends on an updated (read, cleaned up) translator within the JSCAD org.
removes the last 'hard dependency' : ie removes the js/libs folder from this project
fixed scad code display

Are you sure that the switch to SCAD syntax is correct? I believe there's code to determine the syntax and switch the editor to SCAD when SCAD is loaded.


"NameError:global name 'atexit' not defined" message with --include or --exclude bed files

Dear brentp,
I installed the dependencies commandr (1.3.2) and your toolshed (v0.4.4) and have used the poverlap function successfully except for when I specify --exclude or --include. I get the error below.
python poverlap.py poverlap --a shuffle.Spib.bed --b shuffle.Pu1.bed -g mm9.ChromInfo.txt --exclude mm9.bad.bed > test3.res
Traceback (most recent call last):
File "poverlap.py", line 374, in
main()
File "poverlap.py", line 370, in main
res = Run()
File "/home/benjamir/.local/lib/python2.7/site-packages/lib/python2.7/site-packages/commandr/commandr.py", line 308, in Run
return self.RunFunction(cmd_fn, cmd_name)
File "/home/benjamir/.local/lib/python2.7/site-packages/lib/python2.7/site-packages/commandr/commandr.py", line 421, in RunFunction
result = info.callable(**options_dict)
File "poverlap.py", line 318, in poverlap
a = zclude(zclude(a, exclude, True), include, False)
File "poverlap.py", line 231, in zclude
tmp = mktemp()
File "poverlap.py", line 28, in mktemp
atexit.register(rm, f)
NameError: global name 'atexit' is not defined

hi @benjasriga thanks for reporting. I just pushed a fix for this. Let me know if any problems.

You may be my newest hero. Thanks. Will try the new code.
Ben
On May 3, 2015, at 2:09 PM, Brent Pedersen - Bioinformatics <notifications<EMAIL_ADDRESS>wrote:
hi @benjasrigahttps://github.com/benjasriga thanks for reporting. I just pushed a fix for this. Let me know if any problems.
—
Reply to this email directly or view it on GitHubhttps://github.com/brentp/poverlap/issues/8#issuecomment-98526202.


Add support of os.PathLike T39020

[ ] API.import_project
[x] Drive.upload

Solved in f7baf0930c9eb773428e7a29f64a42ac64fa06b3


seg fault in remove_spread due to overflow of disp variable

Someone has reported a seg fault when deleting a lot of files.  This has been tracked down to overflowing the disp offset variable (signed int) in remove_spread.
https://github.com/hpc/mpifileutils/blob/123bb68c63ccb5203f3dcca2194295db46d06d7e/src/common/mfu_flist_remove.c#L228
This is currently a signed int, because MPI requires signed ints for displacement values in MPI_Alltoallv.  There is also no good way to create a datatype that would help, since we're dealing with variable length strings.
As a fix, we could batch this up into a sequence of Alltoallv operations, each dealing with at most 2GB at a time.  Or we could fallback to remove_direct and avoid the Alltoall calls.

Working to solve that here: https://github.com/hpc/mpifileutils/pull/188

Fixed with https://github.com/hpc/mpifileutils/commit/2ecf25d7cf582c6b41d33d879858631098d803ab


No obvious “back” action for GridFieldDetailForm (3.3)

Tentatively adding this as an issue...
When editing an item in a GridField, there is no obvious way of getting back to the parent record/page. The only way back is via the link in the breadcrumb trail, which is pretty small and hard to spot:

The breadcrumb looks nicer (and admittedly, re-adding the back button does kinda spoil the look - see below), but I’m concerned it’s not as easy to use. It took me far too long to spot!

I’ll look at re-adding the button but with the new button styles and see how that looks

Closed via d339642cac303e45fdb5e912a110cb233f1c7b59


Bulk Edit create new metadata does not work

Trying to add a metadata in the content page Bulk Edit option does not work.
Go to contents page
Select one or more contents
Press "Bulk Edit"
Attempt to add new metadata to any listed type
Metadata is created but not added to selected contents

Test

This issue is linked to Issue #67


Host PHP API Docs via netlify

This is step 2 and a follow up to https://github.com/open-telemetry/opentelemetry-php/issues/1378:
PHP is one of the few languages[^1] that does not have API Docs published yet. I provided a PR that adds phpDocumentor to the repo which creates the API Docs. What remains is where and how to host them. My proposal is that we host them via netlify, as this comes with a few advantages:

PHP SIG does not need to do their own hosting (via readthedocs, github pages), or maintain workflows, since this is covered by SIG Comms and netlify can pick up changes via commits similar to how the opentelemetry.io page is built today.
We can provide a *.opentelemetry.io location (php.api-docs.opentelemetry.io or opentelemetry.io/api-docs/php with a rewrite proxy)

What needs to be done:

Go into the netlify console, setup a new page (e.g. php.api-docs.opentelemetry.io), point it to opentelemetry-php repo, let it run
Setup the rewrite proxy for opentelemetry.io/api-docs/php
That's it :-)

Note, that this can also be a pilot and if this works well, we can provide something similar to other SIGs.
cc @open-telemetry/php-approvers @open-telemetry/docs-approvers
[^1]: only other language is swift

Overall, I like the idea of hosting via Netlify.
I'd like to suggest that the PHP API reference have the following canonical path:

/docs/languages/php/api

Just like for other languages. We can then separately decide what kind of aliasing we might want to have (or not have). WDYT?

Thinking about this more ... The OTel website has enough complexity already, that I'd avoid introducing the overhead of having to maintain subdomains like php.api.opentelemetry.io for each language.

The OTel website has enough complexity already,

This would be an independent netlify site, so not getting into the otel website itself except introducing redirects.

that I'd avoid introducing the overhead of having to maintain subdomains like php.api.opentelemetry.io for each language.

So you would rather have it the SIG PHP hosted themselves using github pages / read the docs, like other languages are doing it?

Sorry for the confusion: my comment wasn't about hosting on Netlify (which I'm ok with), it was about not introducing the <lang>.api.otel.io subdomains.

Sorry for the confusion: my comment wasn't about hosting on Netlify (which I'm ok with), it was about not introducing the <lang>.api.otel.io subdomains.

The subdomain would only be introduced for those languages that are hosted on netlify, because that looks better than https://main--opentelemetry-php.netlify.app/, except we only do the rewrite with proxy and have it under opentelemetry.io/path/to/it/php, although in that case I would prefer to have it outside the existing tree (i.e. /docs/languages/php/api), since we already see that this may lead to issues as in #5211, so opentelemetry.io/api/php might be a safer choice imho


arg.path misdefined?

It seems you are passing the path argument to args.out_path (line 332 in train.py). Is that the normal procedure?
Should that be commented out, in order to use the path argument in Multiscale dataset? Or is it expected that the dataset folders are inside the output_path?
Thanks!

The name of the arguments is misleading indeed. Sorry for that. However, the code should work as it is. Note that in line 332 in train.py 'path = args.out_path' but args.path is used later as an argument in Multiscale dataset.
Ivan


Fix Makefile docstrings and phony targets.

Overview
Some docstrings and phony targets were outdated/incomplete. Fix.
Checklist

[ ] New and updated code has appropriate documentation
[ ] New and updated code has new and/or updated testing
[ ] Required CI checks are passing
[ ] Visual proof for any user facing features like CLI or documentation updates
[ ] Linked issues closed with keywords

Codecov Report

Merging #2194 (41124dd) into main (687704e) will decrease coverage by 0.03%.
The diff coverage is 60.00%.

@@            Coverage Diff             @@
##             main    #2194      +/-   ##
==========================================
- Coverage   55.82%   55.80%   -0.03%
==========================================
  Files         216      216
  Lines       14060    14091      +31
==========================================
+ Hits         7849     7863      +14
- Misses       5422     5441      +19
+ Partials      789      787       -2

Impacted Files
Coverage Δ

nodebuilder/header/service.go
13.55% <0.00%> (-4.63%)
:arrow_down:

share/availability/discovery/set.go
88.88% <66.66%> (-2.03%)
:arrow_down:

das/state.go
86.29% <87.50%> (+1.21%)
:arrow_up:

das/checkpoint.go
100.00% <100.00%> (ø)

das/worker.go
95.65% <100.00%> (-0.87%)
:arrow_down:

share/availability/discovery/discovery.go
78.29% <100.00%> (+0.75%)
:arrow_up:

... and 2 files with indirect coverage changes


luaPackages.lua-resty-openidc: init at 1.7.2-1

Motivation for this change
I want to use lua-resty-openidc with openresty and keycloak to auth users with openid connect.
Things done
I did some basic test with openresty. The module seems to run. I didn't test any auth yet.

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

in principle it would be one commit per addition. It passed nixpkgs-review and looks fine.


React 0.14

Is anybody already using react-color together with react 0.14.0-beta1?
From my experience porting other projects mostly removing getDOMNode() and findDOMNode() is enough to make it work.
-    var container = React.findDOMNode(this.refs.container);
+    var container = this.refs.container;

yeah... kinda need these changes to play with Relay, which requires react >= 0.14.0-beta3.

After hunting down the findDOMNode uses, things in the src should be easily fixed.
I am not sure exactly how the modules folder works though.
Those are already transpiled to es5, but some of them uses React.findDOMNode as well.

Thank you, I'll close this because the topic will pop up once react is out of rc.

Ah, good point!
I will get @u9520107's stuff merged into a new branch for 0.14.0 this week and will merge that into master when its out of rc

Any progress here? I'm seeing the following trying to use with 0.14:
Warning: ColorPicker(...): React component classes must extend React.Component
invariant.js:39Uncaught Error: Invariant Violation: ColorPicker.render(): A valid ReactComponent must be returned. You may have returned undefined, an array or some other invalid object.

My Component:
import React from 'react'
import ColorPicker from 'react-color'

export default class ShipShop extends React.Component {
    render() {
        return (
            <div className="ShipShop">
                <ColorPicker />
            </div>
        )
    }
}

Ideas?

I've got the same error.

The last time I saw similar warnings, I was loading multiple versions of React and mixing them together. The components extending one version will not be recognized as a react component by another version.
Just a guess though.

Sorry for the delay on this guys. This has been aligned with react 0.14.0 you can use it by updating to<EMAIL_ADDRESS>


Remove duplicate v8 function reference

The function name has always been AdjustAmountOfExternalAllocatedMemory() for all versions supported by nan.

Ah, yes. The (omitted) point should have been that the argument type has changed from int to size_t and that NAN keeps it as int. Could you add a note about that as well?

Merged as 9347dc9f43bd4e5e54926fa38dd915b7d3fa3c08


Custom Claim Array always null with auth 0.29.1

Describe the bug
Custom Claim Array always null with auth 0.29.1
I've got a custom Claim configured like this
[[auth.session.accessToken.customClaims]]
key = 'account-ids'
value = 'account_memberships.account.id[]'
After upgrading to auth 0.29.1 its always "null".
"x-hasura-account-ids": "null",
Downgrading to 0.26.0 (the version i used before) and it works again.
"x-hasura-account-ids": "{"439cbb31-a2a4-4f01-b87d-1a650f66a797"}",
Anything changed i am not aware of?
To Reproduce
Steps to reproduce the behavior:

Update to auth 0.29.1
configure a custom claim (array)
value is always null
downgrade to 0.26.0
value is there

Thanks for the report, would you mind describing briefly the structure of your data to make sure we replicate exactly? Thanks again.

Would you mind testing 0.29.2-beta1, please?

Thanks for the report, would you mind describing briefly the structure of your data to make sure we replicate exactly? Thanks again.

users
> account_memberships
 > accounts

tables:
users
account_members (account_id, user_id)
accounts

Would you mind testing 0.29.2-beta1, please?

will do thanks!


Add a license?

Hi there! Thanks for making the code for this project available. I'm playing around with my own implementation of the cornercam (for a 6.865 class project, actually), but I noticed that there's no license for this project so, technically, its code can't be reused or modified. Would you be willing to add some open-source friendly license to the project? If your intent is to let people use the code without restriction, then MIT is probably a sensible choice, but it's of course up to you.

Hey, thanks for reaching out! I’ve added a license, let me know how it goes!
Thanks,
Vickie
On Sat, Dec 9, 2017 at 7:16 PM Robin Deits<EMAIL_ADDRESS>wrote:

Hi there! Thanks for making the code for this project available. I'm
playing around with my own implementation of the cornercam (for a 6.865
class project, actually), but I noticed that there's no license for this
project so, technically, its code can't be reused or modified. Would you be
willing to add some open-source friendly license to the project? If your
intent is to let people use the code without restriction, then MIT
https://opensource.org/licenses/MIT is probably a sensible choice, but
it's of course up to you.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/vye16/corner-camera/issues/1, or mute the thread
https://github.com/notifications/unsubscribe-auth/AFblW-BxG0jeolOPSXVxWBty1g9eVW8fks5s-yKvgaJpZM4Q8T3H
.

Thank you! I've put up my implementation here: https://github.com/rdeits/EdgeCameras.jl/blob/gh-pages/notebooks/demo.ipynb


Expose Browser Info to reporters

What is your Test Scenario?
I'd like to get the link to the Browserstack session URL that's being used for a test run, into my custom report so that someone can easily get view a test run. I have found the Browserstack url by digging through the TestController object:
fixture`Getting started`
    .beforeEach(async (t) => {
            const url = test.testRun.browserConnection.browserInfo.userAgentProviderMetaInfo;
    })

The problem is that I have no way of getting that URL to my custom reporter.  It'd be nice if I could have some type of mechanism for setting some "report data" for a test that can be accessed via the testRunInfo object in the reportTestDone() function in a custom reporter.
What are you suggesting?
It'd be nice to be able to somehow dynamically set data/properties, from within a test or hook, that can be accessed via a custom reporter.
What alternatives have you considered?
I've tried using the meta tags but I'm unable to dynamically set that value.
I tried setting a property in a beforeEach() function and have that property be used in a test.meta() tag. This, unfortunately, doesn't work.

Thank you for the detailed description. We already have a similar feature request: https://github.com/DevExpress/testcafe/issues/3584
We agree that this feature can be useful, however, we cannot give any estimates on this. If you want to create a PR with this feature, we will accept it and will help you.


[BUG] Whenever I download bloxstrap it opens up roblox

Acknowledgement of preliminary instructions

[X] I have read the preliminary instructions, and I am certain that my problem has not already been addressed.

What problem did you encounter?
I had bloxstrap before but i uninstalled it then after i tried to install it again it just opens up roblox. I used the discord server to get some help but i still couldn't fix this problem https://discord.com/channels/1099468797410283540/1260535221347029023.

Are you sure you're opening "Bloxstrap Menu" and not "Play Roblox"? The latter will always open the app (or the website if it's disabled, i think?)

(or the website if it's disabled, i think?)

Nope, not anymore

Are you sure you're opening "Bloxstrap Menu" and not "Play Roblox"? The latter will always open the app (or the website if it's disabled, i think?)

i dont even have the menu, i clicked the link where you download bloxstrap and after i open the folder it opens up roblox for me.

i dont even have the menu, i clicked the link where you download bloxstrap and after i open the folder it opens up roblox for me.

https://github.com/pizzaboxer/bloxstrap/wiki/Opening-the-Bloxstrap-menu ?

i dont even have the menu, i clicked the link where you download bloxstrap and after i open the folder it opens up roblox for me.

https://github.com/pizzaboxer/bloxstrap/wiki/Opening-the-Bloxstrap-menu ?
Yes i looked in my starting menu for it and i still cloudnt find it. Not even in the control pannel at the uninstall apps section

Sounds like a corrupted install - please send your logs! (%localappdata%/Bloxstrap/Logs)

Sounds like a corrupted install - please send your logs! (%localappdata%/Bloxstrap/Logs)

here

maybe this is also usefull

Where is that menu shortcut located? Right-click it and click "Open file location"

No, I'm talking about the file you selected, this one:

Where is it located?

I pressed on it then right clicked and it then open file location and it appears as bloxstrap exe

should i do a video proof?

Oh, I forget that Windows makes this really annoying.
Right-click on the shortcut, click "Properties", go to the General tab, and copy and paste the whole location field here.

C:\VTRoot\HarddiskVolume4\Users\Comorasu\AppData\Roaming\Microsoft\Windows\Start Menu\Programs\Bloxstrap

What is wrong with your computer? This doesn't make any sense.
Just so I can double check, if you go to %localappdata%, what path does it resolve to?

so if i press win + r and then type %localappdata% and i search for bloxstrap i find an empty folder

Oh, this is an antivirus thing. More specifically, Comodo's sandbox feature. Add an exception for it, reinstall Bloxstrap, and you'll be able to use it normally.


Remove CxxMappedDataArrayExample from the build until fixed

The CxxMappedDataArray example fails to build with current ParaView / VTK / Catalyst.  This just disables it from the build so the rest of the examples can still be used.

Fixed the issue.


admin ?  button enhanced for DWoC

Issue that this pull request solves
Closes: #297 (issue number)
Proposed changes
Brief description of what is fixed or changed
Types of changes
Put an x in the boxes that apply

[x] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation update (Documentation content changed)
[ ] Other (please describe):

Checklist
Put an x in the boxes that apply

[x] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] My changes does not break the current system and it passes all the current test cases.

Screenshots
Please attach the screenshots of the changes made in case of change in user interface

when the admin button is active, its active link has same styling as hover effects as per requirement in the issue.

when the admin button is not active

For small screens, on hover the white background has been removed.
Other information
Any other information that is important to this pull request
no

For small screens as well the button's text color should be white

For small screens as well the button's text color should be white

For small screens as well the button's text color should be white

The text color is white only. Just on hover, it becomes blue. Should I change make it white even for hover?

For small screens as well the button's text color should be white

The text color is white only. Just on hover, it becomes blue. Should I change make it white even for hover?

For small screens as well the button's text color should be white

The text color is white only. Just on hover, it becomes blue. Should I make it white even for hover? @Kajol-Kumari

Yeah, let's keep it same as what we have for large screens on hover

For small screens as well the button's text color should be white

The text color is white only. Just on hover, it becomes blue. Should I make it white even for hover? @Kajol-Kumari

Yeah, let's keep it same as what we have for large screens on hover

@Kajol-Kumari done.

@Kajol-Kumari done.


Add column reordering capability to Table class

This should be possible via the TreeView displaycolumns option and implementing the Tkdnd module.

Possibly want to do column hiding/showing as well


[#3944] fix(pyClient): Python client loss depends library in the requirements-dev

What changes were proposed in this pull request?
Add lose Python depends on library into requirements-dev.txt
cachetools==5.3.3
readerwriterlock==1.0.9

Why are the changes needed?
Fix: #3944
Does this PR introduce any user-facing change?
N/A
How was this patch tested?
CI Passed.

@coolderli @noidname01 Please help me review this PR, Thanks!

LGTM

LGTM!

@xloya can you please help to review. I asked the same question there, and you mentioned that it is not necessary as it already declared in another requirement file.

@xloya can you please help to review. I asked the same question there, and you mentioned that it is not necessary as it already declared in another requirement file.
@jerryshao According to the original issue stack, it seems to be another problem. My initial guess is that the pip install command is not executed locally based on the latest client, so related dependencies such as cachetools are not installed locally. We only specify cachetools dependency in the requirement.txt, but not in the requirement-dev.txt. Therefore, if there is no cachetools dependency locally and the integration test is executed directly, this problem will occur.

I think we have two solutions:

We configure the same dependencies in requirement.txt and requirement-dev.txt.
In the gradle script, we can first execute the pip install command to install the latest dependencies locally before running unit tests or integration tests. WDYT?


Build go binaries outside of Docker container

add Go builds to build script, and copy binaries to docker containers.

fixed in https://github.com/weaveworks/microservices-demo/pull/158


Add Merge OverLapping Numbers Problem in Stack And DSA 450 Section

🚀 Feature
I want to add Merge overlapping problem into DSA 450 and Stack Section, This problem was previously asked on Microsoft's Interview.
Have you read the Contributing Guidelines on Pull Requests?
Yes
Motivation
For Contrubution.
Pitch
It is a very known problem , and clears many in one single go.

/assign


Gluon use cases with Trilateral3 & linc_glfw

You can find some helpers I have created for use with Gluon, created with the help of haxeiomic.
They are still under dev:
https://github.com/nanjizal/kitGL/tree/master/src/kitGL/gluon
Graphical examples some animated using Trilateral3 using a linc_glfw window ( mac terminal code online ).
https://github.com/TrilateralX/TrilateralSamples/tree/master/gluon/
Currently Trilateral3 is quite modular all repos on my github so likely not ideal to setup just yet, but if you do try and get stuck to let me know.

Hey @nanjizal, this is great :), do mind if I move it into a markdown file inside the repo and link to it from the README?

Here's what I mean: https://github.com/haxiomic/gluon/blob/master/EXAMPLES.md

Sure.
Your original main class is here https://github.com/nanjizal/kitGL/blob/master/src/kitGL/gluon/Glwrapper.hx
I wrap it in a class that sets up generic interleave shader, you can feed that generically so it's not really tied to trilateral you just have to pass it XYZARGB data.
The api docs for kitGL are here.
https://nanjizal.github.io/kitGL/pages/kitGL/glWeb/InterleaveAlterGL.html
there are also api docs for dsHelper and trilateral3 and most of the other modules.

would love any further assistance on adding code for threads.
You will notice kitGL tries to set them up similar for Lime ( now working ) and NME, Heaps ( both compile but may not render ? ) , and WebGL ( working ).  I probably need some better naming InterleaveAlterGL and InterleaveDataGL are really rubbish names, but thought more important to get code working.

the idea is they dislocate the ugly GL stuff from drawing code.

kitGL does not have any direct dependancy really on trilateral3 it just a toolkit for assembling gl bits together.

I've not dug into your code but word of warning regarding adding threads: OpenGL doesn't support threads, so for your program to be stable all OpenGL commands must be executed on whichever thread hosts the opengl context (probably the main thread)
Typically multi-threading graphics programs run code on other threads to generate data and then synchronize with the main (OpenGL) thread to run the gl.* commands
WebGPU supports multi-threading and in the future when that gathers steam I will use it has my main haxe GPU API


chore(main): release 1.2.3

:robot: I have created a release beep boop
1.2.3 (2024-08-29)
Bug Fixes

spanish titles with seasons werent parsing as seasons. added spanish lang infer as well for this. (f890cf3)

This PR was generated with Release Please. See documentation.

:robot: Created releases:

v1.2.3
:sunflower:


support git & github branches in the templates downloader

Outline
In Embark (develop branch), it's possible to specify a template when creating a new project. for e.g embark new dwitter --template https://github.com/status-im/dappcon-workshop-dapp/ will create a new project with the contents of https://github.com/status-im/dappcon-workshop-dapp/.
The goal of this task is to support git URIs & github URLs that specify branches.
Acceptance Criteria
The following should be supported

Valid git URIs, for e.g:
** embark new dtwitter --template<EMAIL_ADDRESS>Valid github URLs with branches, for e.g:
** embark new dtwitter --template github.com/status-im/dappcon-workshop-dapp/tree/start-here

@iurimatias just let me know when I can start to work

Thank you so much for the work on this @eiselems could you drop your contact code for status on here so we can send you the SNT bonus at the end of the embark bounties? Thanks!

@StatusSceptre Gitcoin's Tip feature is also an option here to go through Github handles, but whatever works best 🙂
@eiselems Great work here! Would love to have you on Gitcoin Slack to tag you for future bounties + be on the lookout for a new batch of Embark bounties next week!

@StatusSceptre give me a day or so to install it and set it up (managing keys, phrases is not that easy on the go).
@vs77bb lets see how it works out 👍

@StatusSceptre here you go my status code 0x043fc5f0224b1ddbf3a5a897821169d7aad192b1111f095b9bc41854896ce221caf4e7b080d399a500517a2f9cf902722de6a07e7b428b1bd630b3af634402df2a


padim arguments improvements

Description
Fix #662 by creating the parameter n_features (nb of features/axes retained by the dimension reduction).
I also made it possible to use a custom backbone without modifying the source code.
This was limited by this hardcoded dict

If the backbone was not in the dict then the orig_dims and emb_scale could not be set.
These two don't need to be hardcoded, I made it be deduced from a dryrun feature extraction.
Changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] Refactor (non-breaking change which refactors the code base)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[x] This change requires a documentation update

Checklist

[x] My code follows the pre-commit style and check guidelines of this project.
[x] I have performed a self-review of my code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[X] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing tests pass locally with my changes

done
i further simplified a bit

Maybe it would be good to add a unit test for this function

@djdameln it didn't feel right to have such a specific test.
Instead i extracted the dryrun part and tested that. The logic in _deduce_dims is trivial now.

The conflict is only in anomalib/models/components/feature_extractors/__init__.py right?
Doesnt look so hard, whicever is merged second rebases.
@ashwinvaidya17 could you check if the new function in that file in #675 would work with the torchfx extractor? If not then it needs a subcase.

The conflict is only in anomalib/models/components/feature_extractors/__init__.py right?
Doesnt look so hard, whicever is merged second rebases.
@ashwinvaidya17 could you check if the new function in that file in #675 would work with the torchfx extractor? If not then it needs a subcase.

I am working on a design to make the feature extractor configurable. I think we can move dimension computation into the feature extractor class. Since the design might take time we can merge this one first and then I can update PR #675

Cool : )


[TACHYON-1506] Fix UnderStorageSystemInterfaceIntegrationTest.testListRecursive for S3

UnderStorageSystemInterfaceIntegrationTest.testListRecursive and UnderStorageSystemInterfaceIntegrationTest.testMkdirs fail because the S3UnderFileSystem interface logical

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Tachyon-Pull-Request-Builder/7678/
Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Tachyon-Pull-Request-Builder/7679/
Test PASSed.

Thanks for the fix @luoli523! I've left some minor comments

updated the PR, address some comments.
And mv the stripSlashIfPresent logic into the convertToFolderName method since there are other lines should do the same strip.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Tachyon-Pull-Request-Builder/7702/
Test PASSed.

Fix the conflict between amplab/master

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Tachyon-Pull-Request-Builder/7703/
Test PASSed.

LGTM

LGTM


After update cheat doesn't working

Was there any error message? Or is it still weighing an empty console? Try deleting offsets.json and restarting it.

thanks, its working


[Security patch] Apply MitM security patch from https-proxy-agent

https-proxy-agent version 2.2.1 contains a reported man-in-the-middle vulnerability. A security patch was issued and released in version 3.0.0.
This mejor version does not include breaking changes in the code but has removed support to legacy node engines (4,5,7). Code is still tested on 6, 8, 10, 12.
I would like to include this security patch here.

Version 3.0.0 release notes

This release fixes the MitM vulnerability reported via HackerOne. It is a breaking change because Node 4, 5, and 7 are no longer tested in CI (note that Node 6 is still supported).
Major Changes

Remove Node 5 and 7 from Travis: 590bc8b
Remove Node 4 from Travis: 6c804a2

Minor Changes

Update proxy to v1.0.0: d0e3c18
Test on Node.js 10 and 12: 3535951
Fix compatibility with Node.js >= 10.0.0: #73
Add .editorconfig file: 06ead2f
Add .eslintrc.js file: ae53572

Patches

Update README with correct secureProxy behavior: #65
Remove unreachable code: 46aad09
[TypeScript] Allow port to be a string: #72
Use an EventEmitter to replay failed proxy connect HTTP requests: #77

Credits
Huge thanks to @lpinca, @stoically, and @zkochan for helping!

origin

Complete changelog

Upgraded in v0.10.3, thanks!


Admin Content Search enhancement

I would like search capabilities in Admin Search Content like front-end search.
E.g. at the moment I have to find all content not containing some words in the body part.

Have you tried the Admin Content Search feature that you can enable?

But I am just talking about enhancing that feature. My request is not clear?

Sorry, I misread your request. You want to be able to negate your search query which you can't do currently in the Admin Content Search. I have tried to do this in the front-end search with "-" preceding my search text but this doesn't work for me. You seem to suggest that it does work for you in the front-end so, if that is the case, how are you doing it?
It is something that Lucene supports along with wildcards and other query syntax but I can't seem to get any of them working in Orchard.

It appears the "-" is being stripped off the query by the QueryParser on line 84 of LuceneSearchBuilder. Could be related to a known issue with special characters....
https://github.com/OrchardCMS/Orchard/issues/3887

in the admin back end (not Admin Content Search) you can design searches for projections (Search link in the left side of back end). Such part has just the features with the advanced filters I need.

@mattcowen it's stripped out on purpose, this is the goal of QueryParser. I just decided that whatever was typed in the box was the list of terms to search, not a technical query per se. I don't think we should support custom verbs in it. But we can always have an advanced search with more fields like excluded terms, sort criteria, content types, ...

Yes perhaps too technical for the average user. An advanced search sounds good way to go.
For those interested, an interesting discussion on this topic in the core Lucene project... https://issues.apache.org/jira/browse/LUCENE-4378

In fact it would be enough to me to leave Admin Content Search the same and add an "edit content" link for each item result in project search preview.

@GioviQ There is already such things, no? This is just the same standard content item list view with the actions on each item, including the Edit. Or just click the content item's title link.

@sebastienros I do not find any link to edit the items in this preview (see screenshot).

This preview contains all contet item without word "respirazione" in the body part.


volume is in pendig state in case of waitforfirstconsumer

Using LocalPV Device mode, I got the same problem as this issue of lvm-localpv https://github.com/openebs/lvm-localpv/issues/31, how to solve it under the current project? do I have to use nodeAffinity to tag my StatefulSet?
according to the description of @zwForrest:

In the case of waitforfirstconsumer, the pod will be scheduled by parameters, then the node will be selected by scheduler, but lvm did not participate in kubernetes scheduling. This means that the node selected by lvm and the one selected by kubernetes scheduler may not be the same.

k8s cannot sense the local device state of the node when scheduling?

This issue does not apply to v4 and newer versions. Device mode is no longer supported.


Foca fix

Description
Fixed the Dockerfile of the root directory so that it uses the local image in our pc.
Fixes # (https://github.com/elixir-cloud-aai/foca/issues/93)
Type of change
Please delete options that are not relevant.

[x] Bug fix (non-breaking change which fixes an issue)
[x] Documentation update

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] I have not reduced the existing code coverage

@uniqueg Any note why is test failing?


Multiple weather stations - Not all sensors are pulled.

Home Assistant release with the issue: 103.5

Last working Home Assistant release (if known): Not sure if ever worked in this situation
Operating environment (Hass.io/Docker/Windows/etc.):
Ubuntu Server 18.04 Docker - Hass.io Install

Integration:
Ambient Weather

Description of problem:
I have 2 weather stations on my Ambient Weather account. One is a WS-2000 and the other is a WS-2902a. One (ws2000) is at my home and I have 6 temp/humidity sensors attached in different rooms. This Christmas I added a WS-2902a at my parents home and it has no external temp/humidity sensors. I have both on my AW account so I can just compare stats.
I noticed recently that I lost all the temp sensors on my ws-2000 in HA, however, it did pull in both stations. I tested further by removing the 2nd station from the AW site and redoing the integration. This time all the temp/humidity sensors were pulled in as expected. Adding the 2nd station back and re-running the integration lost the sensors again. I also checked the Rest API and it appears that all the sensor data is being presented from both stations. Hence, why I am filing the bug report here.
I realize I am very much a special case as most people will not have 2 stations. I also can create another account for the 2nd station if needed as a workaround. However, I did want to present the problem in case there was a possible fix.
Happy to provide further testing and information if needed.
Problem-relevant configuration.yaml entries and (fill out even if it seems unimportant):

Traceback (if applicable):

Additional information:

Let's do some debugging using the underlying library (aioambient) – from a computer that has a command line, please do the following:

Clone aioambient and cd into it:

$ git clone https://github.com/bachya/aioambient
$ cd aioambient

Initialize the dev environment:

$ make init

Open example_websocket.py in a text editor and put your Ambient Weather API and App keys into lines 12 and 13, respectively:

API_KEY = "<YOUR API KEY>"
APP_KEY = "<YOUR APPLICATION KEY>"

Save and close your text editor.

 Scrub that output of anything sensitive (keys, MAC addresses, etc.) and paste the sanitized version here.


Add module metadata URI

Adding a function to return a metadata URI similar to ERC-721 tokenURI. This would allow frontends to easily access the metadata of modules in a standardized form.
Open question: should we also standardize the metadata schema? One idea could be (similar to 721):
json
{
    "title": "Module Metadata",
    "type": "object",
    "properties": {
        "name": {
            "type": "string",
            "description": "Name of the module",
        },
        "description": {
            "type": "string",
            "description": "Describes the module",
        },
        "image": {
            "type": "string",
            "description": "A URI pointing to a resource with mime type image/* representing an icon to be used for the module",
        },
        "additional_data": {
            "type": "object",
            "description": "An array of additional data that can be used to display on a frontend",
            "required": false
        }
    }
}

imo. its just a matter of time, someone hosts this on aws and does a switcheroo. Immutable and persistent would be sweet


Check for an XML Sitemap

Look for a sitemap at the address /sitemap.xml or look in the robots.txt file for the sitemap and check that it exists

I’m currently looking into the site map check.
My intention was to check:

Is there a default sitemap at the location: /sitemap.xml. If there is, try and call it, and check the HttpStatusCode from the response.
Check if a robots.txt file exists in the root of the website.
2a) if it does exist, process it and loop through each sitemap url and check the response code as per 1)

Closed as already merged in


Add a "duplicate" command

It would be cool if a "duplicate" command could be added..
Edit: Copy/Paste seem to work only across folders, not within the same folder.
Perhaps something like (note: I am not a bash god)
cp "${f[l]}" "copy_${f[l]}" ;;

Will do


Idle stack size is not checked.

I am using NuttX v9.1.0, on an STM32F427.
As I see, (at least) on Cortex-M architectures, the idle stack is placed right after BSS.
The top of stack is defined as:
#define IDLE_STACK      ((unsigned)&_ebss+CONFIG_IDLETHREAD_STACKSIZE-4)
This makes the assumption that there is enough memory after BSS to fit the idle stack. If BSS grows enough that there is less than CONFIG_IDLETHREAD_STACKSIZE free space, then the top of stack will fall outside the memory region.
Even worse, since this is not checked during build, there will be no warning or any indication of the problem. The system will just crash during initialization.
My proposition is to add an explicit memory region in the linker script to place the idle stack, so its position and size are well defined, and checked during build.

I was thinking... In a typical bare-metal application, usually the top-of-stack is defined as a linker symbol, since its size its not known. There things are much simpler, there is only one stack which takes all available space after BSS.
However, NuttX is a different thing. It has multiple stacks, all of which have a defined size in compile-time. There is no way for the stack to grow to take all remaining space after linking (and there would be no reason to do so).
So, why have the IDLE stack defined like that? Why not make it a statically allocated buffer?
E.g.
uint8_t g_idle_topstack[CONFIG_IDLETHREAD_STACKSIZE];

This way the stack will be allocated within BSS. The linker will be able to check its size and whether it fits.
It will also give the ability to set it to a specific memory region. An users' custom linker scripts will be able to place the stack to whatever memory region they like. Just as discussed in #2002, there will be no assumptions on how stuff should be mapped into memory.

No, you can't put g_idle_topstack to BSS section, since the startup code which zero out BSS section will corrupt your running(idle) stack.
Yes, you can define the idle stack as a global arrary, but you must put it into a special section(e.g. .noinit) in link script.

Well, I thought of BSS because in most systems BSS is zero'ed (or painted) very soon during initialization, in a no-return function. So usually overwriting it, is not a problem, because you will never pop anything from the "corrupted" portion.
Nevertheless, you are right. It has to be done correctly.
What is the most appropriate section to place the stack? .noinit? Or define a special section (which requires changes in all linker-scripts though...)?

Well, I thought of BSS because in most systems BSS is zero'ed (or painted) very soon during initialization, in a no-return function. So usually overwriting it, is not a problem, because you will never pop anything from the "corrupted" portion.

No, it may corrupt the variables you are using, the zero memory loop may never or premature terminate.

Nevertheless, you are right. It has to be done correctly.
What is the most appropriate section to place the stack? .noinit? Or define a special section (which requires changes in all linker-scripts though...)?

.noinit is already used in several linker script, so it's a good candidate. Yes, you have to change all linker-scripts, so I don't suggest this direction.
The idle stack size overflow isn't a common problem, do you really hit this issue?


File collection dependencies are not being added as inputs to the compileFlex task

I've discovered the surprising result that dependencies that are file collections do not get added as inputs to the compileFlex task. I believe there is extra logic needed in Compile.groovy's initInputDirectory() method to add file collections as inputs to the task.
I will experiment and see about submitting a PR to address this.

Closing issue since corresponding PR addresses problem.


Demo not working, responds with 403

Demo mentioned in readme at https://typescript-node-starter.azurewebsites.net/ is throwing following error: Error 403 - This web app is stopped.

@dpkshrma there may have been a issue with the host at the time you were trying to access the demo. I'm able to access and navigate through the core features of the demo without any issues. Can you confirm?

@speaud still 403 for me

@speaud 403 for me right now.

@amitport @welkie
I'm now seeing the 403 error as well. First time I'm seeing this. It is a hosting issue on Microsoft's end. There isn't anything that can be done on our end without Microsoft's intervention.
However you can follow the setup instructions in the readme to posture your own instance of this repo on Azure for free. That way, you can avoid dealing with hosting based issues where you don't have root access.

Seeing 403 as well.

Also seeing a 403.

Demo is working now. Probably can close this.

Demo (https://typescript-node-starter.azurewebsites.net/) is unavailable again!


Most general form of feedback loops

This pull request includes the most general form of feedback loops that was implemented in RxFeedback.swift. TODO:

Unit Tests
This is still a draft as I still need to add the unit tests for the new feedback loops. I am not very familiar with unit testing with TestScheduler. I will be doing some research to understand how it works.

Equatable
In the Swift version of this library, we are forcing the Query to be equatable. There was an overload that takes areEqual: (Query, Query) -> Bool. This was removed from RxFeedback.swift . @kzaher  I think this was needed for things like arrays because prior to Swift 4.2 Array<Equatable> was not Equatable. but I think we still need this overload in Kotlin because we need to call special methods for deep comparison of arrays.
If you agree, i will add an overload to the most general form that takes a (Query, Query) -> Boolean parameter.
Do you think we need this in Swift?

Optional<T>
Regarding the Optional type. I am not sure but I don't think this is needed. Maybe we can provide a new API without Optional and deprecate the current ones that use Optional. We can in a future version decide to remove them.
However,  we can keep the Optional type in the library as it can be used to wrap Kotlin nullables when we need to build streams with nullable values.

Nice! Thanks for contributing.
I went through the PR and I’m having hard time understanding what’s going
on. Namings like Lifetime... are not intuitive to me. Could you please
add some comments explaining what’s happening? For example, class comments
for the RequestLifetimeTracking and its nested classes.
Also, would love to get rid of the optional guy. In my apps I use the
Arrow’s optional. This generalization will help delete our version. Even if
we don’t manage to delete it, I’d like to make it internal and expose an
interface with standard kotlin types.
Thanks,
Marko
On Sun, 5 May 2019 at 16:44, eliekarouz<EMAIL_ADDRESS>wrote:

This pull requests includes the most general form of feedback loops that
was implemented on RxFeedback.swift. TODO:

Unit Tests
This is still a draft as I still need to add the unit tests for the
new feedback loops. I am not very familiar with unit testing with
TestScheduler. I will be doing some research to understand how this
works.
Equatable
In the Swift version of this library, we are forcing the Query to be
equatable. There was an overload that takes areEqual: (Query, Query)
-> Bool. This was removed from RxFeedback.swift . @kzaher
https://github.com/kzaher I think this was needed for arrays because
prior Swift 4.2 to handle cases like these: Array was not
Equatable. but I think we still need in Kotlin because we need to call
special methods for deep comparison of arrays.
We might need to add an overload to the most general form that takes a (Query,
Query) -> Boolean parameter.
Optional
Regarding the Optional type. I am not sure but I don't think this is
needed. Maybe we can provide a new API without Optional and deprecate the
current ones that use Optional. We can in a future version decide to remove
them.
We can keep though the Optional type as it can be used to wrap Kotlin
nullables when we need to have to build streams with nullable values.

You can view, comment on, or merge this pull request online at:
https://github.com/NoTests/RxFeedback.kt/pull/7
Commit Summary

Most general form of FLs:

Implemented the most general form of feedback loops.

Better handling of areEqual.
Added reactSafe for Equatable

File Changes

A
rxfeedback/src/main/java/org/notests/rxfeedback/AsyncSynchronized.kt
https://github.com/NoTests/RxFeedback.kt/pull/7/files#diff-0 (36)
M rxfeedback/src/main/java/org/notests/rxfeedback/Feedbacks.kt
https://github.com/NoTests/RxFeedback.kt/pull/7/files#diff-1 (272)

Patch Links:

https://github.com/NoTests/RxFeedback.kt/pull/7.patch
https://github.com/NoTests/RxFeedback.kt/pull/7.diff

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/NoTests/RxFeedback.kt/pull/7, or mute the thread
https://github.com/notifications/unsubscribe-auth/ABTW25PHCHFLVT2H7BNTYO3PT3XDVANCNFSM4HK3NCQA
.

--
Pozdrav,
Marko

@eliekarouz yes, that was because of compiler limitations :(.

@markotron I've refactored the feedback loops in Swift version so that they are all just simplifications of one general form. Seemed elegant to me.
The idea is to have a set of identifiable values controlling the lifetime of observable state machines. When a new value is added to a set, new observable state machine in effects is subscribed to. When it is removed the subscription is disposed/unsubscribed -> effectively killing the state machine inside the observable.
If the value for some key changes that is sent to the state parameter inside (intialQuery: Query, state: Observable<Query>) -> Observable<Event>.
We've renamed Query to Request. People were complaining about the name Query. I think it might make sense to rename to Kotlin version also.

I see. It does seem more elegant.
I’m still unfamiliar with some terminology that you use like: *observable
state machine, identifiable values *(is that just an object that can be
hashed?).
I get the general idea, I’ll take a look tmrw morning again and ask more
things probably :P
On Wed, 8 May 2019 at 20:37, Krunoslav Zaher<EMAIL_ADDRESS>wrote:

@markotron https://github.com/markotron I've refactored the feedback
loops in Swift version so that they are all just simplifications of one
general form. Seemed elegant to me.
The idea is to have a set of identifiable values controlling the lifetime
of observable state machines. When a new value is added to a set, new
observable state machine in effects is subscribed to. When it is removed
the subscription is disposed/unsubscribed -> effectively killing the state
machine inside the observable.
If the value for some key changes that is sent to the state parameter
inside (intialQuery: Query, state: Observable) -> Observable
.
We've renamed Query to Request. People were complaining about the name
Query. I think it might make sense to rename to Kotlin version also.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/NoTests/RxFeedback.kt/pull/7#issuecomment-490601683,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABTW25PFSCY7PO7JWXC7HVLPUMMVNANCNFSM4HK3NCQA
.

--
Pozdrav,
Marko

observable state machine -> Observable
identifiable values (requests) -> Some value that has an identifier. The value is used to check out should new value be sent. Identifier is used to know where to send it.

@markotron

Could you please
add some comments explaining what’s happening? For example, class comments
for the RequestLifetimeTracking and its nested classes.

Sure. Will work on it this weekend...

Btw. I suggest we drop the optional and introduce a breaking change. So that new versions actually have a form without the optional. In my app I use the arrow.Oprional and it’s annoying to have 2 optionals.
Also, I don’t follow the second bullet (equatable comment) in your PR message. In swift you don’t have the (Query, Query) -> Bool method?
One last question. Is Query the same as Request now? If yes, should we rename that?

Also, I don’t follow the second bullet (equatable comment) in your PR message. In swift you don’t have the (Query, Query) -> Bool method?

It was removed in RxFeedback.swift.

One last question. Is Query the same as Request now? If yes, should we rename that?
I can do this in another pull request. In RxFeedback.swift, they renamed Event to Mutation do you want me to do the same here too?

In RxFeedback.swift, they renamed Event to Mutation do you want me to do the same here too?

So Event --> Mutation and Query --> Request?
How do you define a state machine? You have a enum called State and an enum called Mutation (instead of Event)? What is the standard naming for mutations? Let's say that you have a login state machine and the user enters credentials, would you say that this emitted a CredentialsEntered mutation or CredentialsEntered event?

@markotron
We've renamed Mutation -> Event again. That was the feedback we got.
Query -> Request was an improvement.

Nice! I was hesitant a bit about that name :) Good!

@eliekarouz — what are the reminding things here? Tests?

@markotron

@eliekarouz — what are the reminding things here? Tests?

Mainly tests but not sure if I will be able to do anything this weekend.


Does not support users with non-trivial IPv6 address.

Since IPv6 address are often longer than IPv4 address, the database storage for the IP address gets truncated, causing failures when a user tries to log in.
I believe that one way to solve this is to use a GenericIPAddressField, which supports longer IP addresses, like IPv6.
This would, unfortunately, mean a database change, and I notice that Axes doesn't have any migration set up yet (such as South). I'm not sure what the migration strategy for this would be.

This is still broken because is_valid_ip() will fail for ipv6 since it's just using socket.inet_aton. BTW using socket.inet_aton directly will also fail to detect bad IP addresses like "127.0"
I would suggest using the built-in django validators (assuming they exist in the versions of django you want to target). I have done this in my fork, so you could easily lift it from there:
https://github.com/aclysma/django-axes/commit/ae52351561aeffcf1a5d4f8a6a06239f81c197f0
As an aside, that commit also removes the IP sanitization. In my opinion it's much better to let people do that for themselves in middleware for reasons mentioned here: http://django-ratelimit.readthedocs.org/en/latest/security.html#security-chapter

@aclysma Can you do a PR with those changes?

Per your request, I sent a pull request, but it includes all my changes, several of which are very opinionated.. you probably don't want to take some of them. It may be easier/safer to just lift the ip address validation code manually.

FYI the failed test test_log_data_truncated is failing because I removed storing GET/POST params (this is one of those opinionated changes that you likely don't want to take.)

@aclysma Looks great. Can you please send the PR only with the ip validation changes?

This should be fixed by now


Slider within a Modal does not update live on Android

Describe the bug
When creating a Slider within a Modal, the Slider.Thumb does not update when dragging in Android. Works perfectly fine in iOS.
To Reproduce

Create a Modal with a Slider child
Tap and drag the Slider.Thumb
See Slider.Thumb not following drag motion

Expected behaviour
Slider.Thumb to behave as it does on iOS where it follows along with the drag.
CodeSandBox/Snack link
snack template.
Platform
Android

NativeBase version 3.2.2
Device: Pixel 6/ Android Emulator
OS: Android 12
React Native version 0.63.4
Expo sdk version 43
node 16.13.1
yarn 1.22.11

Additional information
Works as expected on iOS. Issue only effect Android

HI @slewicki , thanks for reporting issue, we will fix it soon.

There's pretty much the same problem when Slider is wrapped into Actionsheet content.
Here's a Snack example:
https://snack.expo.dev/@404-html/native-base---slider-in-actionsheet
Looks like slider's thumb is not capturing drag gesture on Android and the only way to change slider's value is to tap on the track.

This is a problem with PanResponder. Related bug: https://github.com/facebook/react-native/issues/14295
Something like this worked for me:
<Slider.Thumb {...props}>
  <TouchableWithoutFeedback onPress={() => {}}>
    <Box position="absolute" top={0} bottom={0} left={0} right={0} />
  </TouchableWithoutFeedback>
</Slider.Thumb>

The TouchableWithoutFeedback hack doesn't fix the actionsheet/modal problem for me, fwiw.

Are there any updates to fix this issue?


Command cannot be used in this world

No console errors, just this when I type /wild.

You have to add to world the config

And what exactly do you mean? I've looked around the config file and other files there and nothing mentioned the world.

Look in the config there is a section called worlds you can manually add it there or you can use /wtp gui and then click add worlds/pots/biomes then click world and type in chat your world the minx the maxx the minz and the maxz

OI! I did something. I played with the /wtp gui a little and now I kinda did something..
everytime I type /wild it teleports me at the spawn, but on top of the building, and gives me this error:

That error literally tells me nothing I need the log for infor

[15:49:26 INFO]: Defeatings issued server command: /wild
[15:49:27 ERROR]: null
org.bukkit.command.CommandException: Unhandled exception executing command 'wild' in plugin Wild v3.14.2
at org.bukkit.command.PluginCommand.execute(PluginCommand.java:46) ~[craftbukkit-1.8.8.jar:git-Bukkit-e1ebe52]
at org.bukkit.command.SimpleCommandMap.dispatch(SimpleCommandMap.java:140) ~[craftbukkit-1.8.8.jar:git-Bukkit-e1ebe52]
at org.bukkit.craftbukkit.v1_8_R3.CraftServer.dispatchCommand(CraftServer.java:620) ~[craftbukkit-1.8.8.jar:git-Bukkit-e1ebe52]
at net.minecraft.server.v1_8_R3.PlayerConnection.handleCommand(PlayerConnection.java:1106) [craftbukkit-1.8.8.jar:git-Bukkit-e1ebe52]
at net.minecraft.server.v1_8_R3.PlayerConnection.a(PlayerConnection.java:966) [craftbukkit-1.8.8.jar:git-Bukkit-e1ebe52]
at net.minecraft.server.v1_8_R3.PacketPlayInChat.a(SourceFile:37) [craftbukkit-1.8.8.jar:git-Bukkit-e1ebe52]
at net.minecraft.server.v1_8_R3.PacketPlayInChat.a(SourceFile:9) [craftbukkit-1.8.8.jar:git-Bukkit-e1ebe52]
at net.minecraft.server.v1_8_R3.PlayerConnectionUtils$1.run(SourceFile:13) [craftbukkit-1.8.8.jar:git-Bukkit-e1ebe52]
at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) [?:1.8.0_172]
at java.util.concurrent.FutureTask.run(FutureTask.java:266) [?:1.8.0_172]
at net.minecraft.server.v1_8_R3.SystemUtils.a(SourceFile:44) [craftbukkit-1.8.8.jar:git-Bukkit-e1ebe52]
at net.minecraft.server.v1_8_R3.MinecraftServer.B(MinecraftServer.java:673) [craftbukkit-1.8.8.jar:git-Bukkit-e1ebe52]
at net.minecraft.server.v1_8_R3.DedicatedServer.B(DedicatedServer.java:335) [craftbukkit-1.8.8.jar:git-Bukkit-e1ebe52]
at net.minecraft.server.v1_8_R3.MinecraftServer.A(MinecraftServer.java:629) [craftbukkit-1.8.8.jar:git-Bukkit-e1ebe52]
at net.minecraft.server.v1_8_R3.MinecraftServer.run(MinecraftServer.java:537) [craftbukkit-1.8.8.jar:git-Bukkit-e1ebe52]
at java.lang.Thread.run(Thread.java:748) [?:1.8.0_172]
Caused by: java.lang.IllegalArgumentException: No enum constant org.bukkit.Effect.PORTAL
at java.lang.Enum.valueOf(Enum.java:238) ~[?:1.8.0_172]
at org.bukkit.Effect.valueOf(Effect.java:1) ~[craftbukkit-1.8.8.jar:git-Bukkit-e1ebe52]
at me.Qball.Wild.Utils.TeleportTarget.teleportPlayer(TeleportTarget.java:90) ~[?:?]
at me.Qball.Wild.Utils.TeleportTarget.teleport(TeleportTarget.java:46) ~[?:?]
at me.Qball.Wild.Wild.random(Wild.java:316) ~[?:?]
at me.Qball.Wild.Utils.GetRandomLocation.getRandomLoc(GetRandomLocation.java:57) ~[?:?]
at me.Qball.Wild.Utils.GetRandomLocation.getWorldInfo(GetRandomLocation.java:40) ~[?:?]
at me.Qball.Wild.Utils.CheckPerms.check(CheckPerms.java:33) ~[?:?]
at me.Qball.Wild.Commands.CmdWild.onCommand(CmdWild.java:45) ~[?:?]
at org.bukkit.command.PluginCommand.execute(PluginCommand.java:44) ~[craftbukkit-1.8.8.jar:git-Bukkit-e1ebe52]

Pastebin your config

https://pastebin.com/gPjCfaKJ

Alright your factions world is all messed up that may be the problem try to copy the format of world if I weren't on my phone I would do it for you

Don't really know what do you mean I don't want anything to be deleted.

Here give this a try https://pastebin.com/wYEZHd30

I pasted that in the config file, restarted, checked to see if the plugin worked, and it did.
After trying /wild literally nothing happened. Nothing in the chat, nothing in the console.

Thank you for trying, but it won't work sadly..
I checked twice if I pasted the right thing and I did and the same thing as last time, nothing.

Im baffled that should have worked

Any update?

Why did you give up on your server

Because I had to, in order to partnership with the (quite) big server mentioned above

Oh hope it works out but I'm closing this for now


WIP Rsgl

This is the start of RSGL platform. I think this brings to light the need for separate sound providers (like miniaudio for CLI, RSGL, glfw, etc.)
I am getting a ton of link-errors on mac, so I need to work that out before this is ready.

Sorry, disregard this. I should be targeting RGFW. I got them a bit mixed up. I will track dummy sound, in another issue.


Modified order of components to fix CSS border styling

This pull request fixes a CSS styling issue by reorganizing the components contained in the render method. Specifically, I moved the FormControl to be the first component.
After merging this pull request, the input element should have rounded corners on the left side (since it's the first child of an input group).

Any idea if this is going to get accepted?

Many thanks for the PR and apologies for the delay in it's review and acceptance. I'll take a look as soon as possible.

No problem at all! Sorry for being pushy. Thanks so much for the awesome plugin!

It seems that #52 broke this. Could you double check?


pybamm.erf and pybamm.erfc are missing documentation

Both pybamm.erf and pybamm.erfc are entirely missing from the documentation, but are present in the latest version of PyBaMM.

Actually, there are other functions missing too (e.g. ArcTan, ArcSinh, Sqrt) so it would be good to include all of them in the docs. It would also be good to reorganise functions.py so the functions appear in alphabetical order.

Yes should be easy to fix, just add the missing pieces to this file https://github.com/pybamm-team/PyBaMM/blob/develop/docs/source/expression_tree/functions.rst
Can you do this @partben ?


cmd/asm,cmd/compile: add support for shadow stack

X86_64 CPUs can support  Shadow Stack (SHSTK). SHSTK helps to mitigate against Return Oriented Programming (ROP) expoits, as well as others that target a process's call stack.
On linux binaries need to be marked with a note section .note.gnu.property marking support for GNU_PROPERTY_X86_FEATURE_1_SHSTK in order to support SHSTK. I believe Windows also supports SHSTK but have no knowledge of how.
Go should ideally support SHSTK on Linux and add the note section showing it does support it.  Provided Go does not change the stack I believe it should be sufficient for Go to mark the binaries it generates.
https://github.com/golang/go/issues/66054  is for the other half of Control-flow Enforcement Technology (CET).

I'm not sure it is simple. Go runtime switches goroutines by switching stacks (changing the value of SP). When the stack switches, the shadow stack may also need to be switched. If we want to support this, we may need to do something similar to what C setjmp/longjmp does.

@hjl-tools is this of interest to you or you can suggest someone who may be interested in it?

Just compile the run-time library with -fcf-protection should enable shadow stack if there are no custom context switching functions.

@hjl-tools In this case the runtime is written in Go, not C.  There is no -fcf-protection option.  There are custom context switching functions, written in assembler.

SHSTK is a palliative for C and C++ which allow ROP due to their deficient design and allowance for undefined behavior.
If one doesn't use unsafe, then ROP should not be possible in Go. This might negatively affect the performance of Go programs and is another example of how non C programming languages have to pay "C taxes" as it were. This should certainly remain optional.

This should certainly remain optional.

Sure. It should be optional (if we do this).