New CRI-O installation instructions

It looks like CRI-O has improved their installation instructions:
https://cri-o.io/
I'll check this out and update our code and hopefully this will be more reliable.

This technique didn't work when I included the CRI-O patch version like 1.23.2 or 1.24.0.  It looks we need to specify just the major and minor parts and then the script will install the latest patched version.
So the fix here is to just use the CRI-O major and minor versions when configuring this.
This means that its possible that when regenerating a node image for a CRI-O version that we may actually end up installing an upgraded point release.  This is probably OK, since point releases should still be compatible with older versions of Kubernetes with the same major/minor release version.
The only problem is that we'll be building our CRI-O executable from an older tag and then overwriting the newer official executable installed with our older version.  The solution is to:

[ ] Manually that the our CRI-O patch version is that same as the latest CRI-O patch version before we build a node image.

[ ] It would be really nice to automatically ensure that we're building the latest patch by querying CRI-O's tags

[ ] Allow the patch version to differ from the current Kubernetes version.

After looking at the instructions more closely, I don't believe they've actually changed.  I tweaked some of the build scripts in the neon-image prepare node... to clean up how I'm pinnng the version and I also install GOLANG v1.18.0 now.  I also ensure that runc is installed which may have not been present on my WSL2 distro.
CRI-O 1.24.0 is building now.

So I haven't found the source code for cri-o-runc and I've found people talking about CRI-O actually using runc.  I'm starting to believe that cri-o-runc is actually just a pinned version of runc.  If true, means that the most recent version of runc will probably be fine.

Closing this


TypeError: Cannot call method 'runInNewContext'

Hello,
I'm using Node.js v0.5.0-pre and when I run this code, I'm getting this error(test log). Is this a bug?
Thanks!

Problem is actual in node v0.6.5

For fixing open lib/server.js and edit
at top:
//Script = process.binding('evals').Script;
vm = require('vm');
change Script.runInNewContext to vm.runInNewContext

For fixing open lib/server.js and edit
at top:
//Script = process.binding('evals').Script;
vm = require('vm');
change Script.runInNewContext to vm.runInNewContext


Update REST docs for sendRawTransactions

Update this section to reflect the conversion to GET for single sends and POST for bulk sends, as per this PR change

This issue fulfilled by PR #210


Add reverse_list.exs

What does the program do ?
Reverses a given input list.
In what programming language it is written?
Elixir

Thank you for participating  in hacktoberfest ❣ if you liked working on this repo you can share it with friends and star this project for helping others


feat(useTernaryDarkMode): Add defaultValue parameter

This parameter will allow the user to set a default value for the dark mode when there's no value in the local storage.
Documentation is also updated to reflect these changes.
Use case
We want to allow users to choose a dark mode option, but for it to default to light - not to follow the system by default. This is because we want to slowly enable it as opt-in whilst it's in beta, but keep the 'system' option for this toggle.

@RobHannay thanks for all! I've done the same for useDarkTheme too and added some unit tests on top of that.


Project Console - Page is not auto refreshed after installing easycla app in github and clicking on Project Console

Background

Launch Project Console
Login as Project Manager
Click on Foundation
Click on CONNECT GITHUB ORGANIZATION
Enter valid github organization
Click CONNECT
Click INSTALL THE GITHUB CLA APP
Click OK on alert
User is navigated to github in new tab
Sign In to github if already not signed in
Click on Configure/Install
Select the organization
Click Install
Click on the project console browser tab
Observed the Project Console is not auto refreshed

Issue is still reproducible
After installing github org page was not auto refreshed

After I manually refreshed the page

Verified and working as per expectation

The old v1 console is deprecated and removed.


SQlite3 file to get installed

Dear colleagues,
When I try to connecto to the DB using cds connect, it shows an error that sqlite3 is not installed, when I try to install using npm install sqlite3 -D, it shows the following message:
user: bookshop $ npm install
npm WARN deprecated<EMAIL_ADDRESS>request has been deprecated, see https://github.com/request/request/issues/3142
npm WARN deprecated<EMAIL_ADDRESS>this library is no longer supported
npm WARN lifecycle The node binary used for scripts is /extbin/bin/node but npm is using /opt/nodejs/node-v10.23.0-linux-x64/bin/node itself. Use the --scripts-prepend-node-path option to include the path for the node binary npm was executed with.
_><EMAIL_ADDRESS>install /home/user/projects/bookshop/node_modules/sqlite3

node-pre-gyp install --fallback-to-build

node-pre-gyp WARN Using request for node-pre-gyp https download
node-pre-gyp WARN Tried to download(403): https://mapbox-node-binary.s3.amazonaws.com/sqlite3/v5.0.1/napi-v6-linux-x64.tar.gz
node-pre-gyp WARN Pre-built binaries not found for<EMAIL_ADDRESS>and<EMAIL_ADDRESS>(node-v64 ABI, glibc) (falling back to source compile with node-gyp)
make: Entering directory '/home/user/projects/bookshop/node_modules/sqlite3/build'
CC(target) Release/obj.target/nothing/../node-addon-api/nothing.o
make: cc: Command not found
make: *** [../node-addon-api/nothing.target.mk:99: Release/obj.target/nothing/../node-addon-api/nothing.o] Error 127
make: Leaving directory '/home/user/projects/bookshop/node_modules/sqlite3/build'
gyp ERR! build error
gyp ERR! stack Error: make failed with exit code: 2
gyp ERR! stack     at ChildProcess.onExit (/opt/nodejs/node-v10.23.0-linux-x64/lib/node_modules/npm/node_modules/node-gyp/lib/build.js:191:23)
gyp ERR! stack     at ChildProcess.emit (events.js:198:13)
gyp ERR! stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:248:12)
gyp ERR! System Linux 5.4.0-4-cloud-amd64
gyp ERR! command "/opt/nodejs/node-v10.23.0-linux-x64/bin/node" "/opt/nodejs/node-v10.23.0-linux-x64/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js" "build" "--fallback-to-build" "--module=/home/user/projects/bookshop/node_modules/sqlite3/lib/binding/napi-v6-linux-x64/node_sqlite3.node" "--module_name=node_sqlite3" "--module_path=/home/user/projects/bookshop/node_modules/sqlite3/lib/binding/napi-v6-linux-x64" "--napi_version=7" "--node_abi_napi=napi" "--napi_build_version=6" "--node_napi_label=napi-v6"
gyp ERR! cwd /home/user/projects/bookshop/node_modules/sqlite3
gyp ERR! node -v v10.23.0
gyp ERR! node-gyp -v v5.1.0
gyp ERR! not ok
node-pre-gyp ERR! build error
node-pre-gyp ERR! stack Error: Failed to execute '/opt/nodejs/node-v10.23.0-linux-x64/bin/node /opt/nodejs/node-v10.23.0-linux-x64/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js build --fallback-to-build --module=/home/user/projects/bookshop/node_modules/sqlite3/lib/binding/napi-v6-linux-x64/node_sqlite3.node --module_name=node_sqlite3 --module_path=/home/user/projects/bookshop/node_modules/sqlite3/lib/binding/napi-v6-linux-x64 --napi_version=7 --node_abi_napi=napi --napi_build_version=6 --node_napi_label=napi-v6' (1)
node-pre-gyp ERR! stack     at ChildProcess. (/home/user/projects/bookshop/node_modules/node-pre-gyp/lib/util/compile.js:83:29)
node-pre-gyp ERR! stack     at ChildProcess.emit (events.js:198:13)
node-pre-gyp ERR! stack     at maybeClose (internal/child_process.js:982:16)
node-pre-gyp ERR! stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:259:5)
node-pre-gyp ERR! System Linux 5.4.0-4-cloud-amd64
node-pre-gyp ERR! command "/opt/nodejs/node-v10.23.0-linux-x64/bin/node" "/home/user/projects/bookshop/node_modules/.bin/node-pre-gyp" "install" "--fallback-to-build"
node-pre-gyp ERR! cwd /home/user/projects/bookshop/node_modules/sqlite3
node-pre-gyp ERR! node -v v10.23.0
node-pre-gyp ERR! node-pre-gyp -v v0.11.0
node-pre-gyp ERR! not ok
Failed to execute '/opt/nodejs/node-v10.23.0-linux-x64/bin/node /opt/nodejs/node-v10.23.0-linux-x64/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js build --fallback-to-build --module=/home/user/projects/bookshop/node_modules/sqlite3/lib/binding/napi-v6-linux-x64/node_sqlite3.node --module_name=node_sqlite3 --module_path=/home/user/projects/bookshop/node_modules/sqlite3/lib/binding/napi-v6-linux-x64 --napi_version=7 --node_abi_napi=napi --napi_build_version=6 --node_napi_label=napi-v6' (1)
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR<EMAIL_ADDRESS>install: node-pre-gyp install --fallback-to-build
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>install script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
npm ERR! A complete log of this run can be found in:_
It seems there is an error to install sqlite3 with the actual version of npm, Any idea how to solve it?.
Best regards.
David.

This is an issue in SQLite3 itself specific to the 5.0.1 version.  It looks like the prebuilt binaries were left out: https://github.com/mapbox/node-sqlite3/issues/1424
If you fix the version to 5.0.0 temporary in the package.json then the install will work. This is a temporary workaround until SQLite project fixes the issue.

This is an issue in SQLite3 itself specific to the 5.0.1 version.  It looks like the prebuilt binaries were left out: https://github.com/mapbox/node-sqlite3/issues/1424
If you fix the version to 5.0.0 temporary in the package.json then the install will work. This is a temporary workaround until SQLite project fixes the issue.


Automatic encryption and hashing of data before putting it in the database

The problem faced currently?
With so many compliances floating all around us, it would be great if SC could encrypt / hash a certain set of fields before inserting it into the database. Encrypted fields must be decrypted before the result is sent to the user.
How can we solve it?
I think adding a directive to the schema we provide to SC will solve this problem

If you want this feature to be implemented, give it a thumbs up reaction, so that we can determine which features are important to you.
👍

The encryption part is taken care of by #621. What's left is hashing!


Everything is showing True in Is Toxic.

Problem encountered on https://dotnet.microsoft.com/learn/ml-dotnet/get-started-tutorial/evaluate
Operating System: windows
Provide details about the problem you are experiencing. Include your operating system version, exact error message, code sample, and anything else that is relevant.

Hello,
Thanks for reporting! Can you expand on everything? Have you tried specific examples from the test data source? Since the tutorial is training on a small dataset it might not be that accurate for custom text entered in.
Please train with a larger dataset or try examples from the training dataset.

I recommend to try the YELP sentiment analysis dataset.
It's not being used in the getting started tutorial because we have no legal approval for that dataset plus it doesn't come with a header in the file, so you'll need to edit the file and add the column names if you want to use it from Model Builder.
Try it out:
https://archive.ics.uci.edu/ml/machine-learning-databases/00331/sentiment labelled sentences.zip
If using the CLI, here are the steps:
https://docs.microsoft.com/en-us/dotnet/machine-learning/tutorials/mlnet-cli?tabs=windows

We should increase the size of the sample used in the getting started guide.
The 250-line sampled dataset is currently sized for a unit test; its small size is not valuable for example code, where a useful model is needed. Perhaps we should increase the size of the sample for use in the example. If the same dataset is used in unit tests, we should ensure the runtime of the unit tests are not adversely impacted. The only point of the unit tests are to see if something changed; they are not expected to make useful models.
Similar issues were mentioned in the main repo: https://github.com/dotnet/machinelearning/issues/708#issuecomment-425706329:

Try running on the full-sized dataset: https://aka.ms/tlc-resources/benchmarks/WikiDetoxAnnotated160kRows.tsv
The wikipedia-detox-250-line-data.tsv dataset is a 250 row sample of the original 160k rows. Training on this small of a sample won't create a useful model.

Resolving due to no activity. If you've tried a larger dataset and are still hitting this issue, please re-open. We're tracking the task of improving our sample data set with #323.
Thanks.


The VERSION_UNIQUE does not seem to work

I have the following
class VersionedWBSElement(Versionable):
    # wbs number is supposed to be unique
    wbs_number = models.CharField(max_length=100)
    wbs_description = models.TextField()

    VERSION_UNIQUE = [['wbs_number']]

I can still create duplicate with the same wbs_number despite the VERSION_UNIQUE
My workaround is install django-partial-index as a package
and then
from partial_index import PQ, PartialIndex, ValidatePartialUniqueMixin

class VersionedWBSElement(Versionable, ValidatePartialUniqueMixin):
    # wbs number is supposed to be unique
    wbs_number = models.CharField(max_length=100)
    wbs_description = models.TextField()

     class Meta:
          indexes = [
              PartialIndex(fields=['wbs_number'], unique=True, where=PQ(version_end_date__isnull=True))
          ]

And because I use DRF, my serializers.py looks like this:
from django.core.exceptions import ValidationError
from rest_framework import serializers
from dynamic_rest.serializers import DynamicModelSerializer

class VersionedWBSElementSerializer(DynamicModelSerializer):
    wbs_number = serializers.CharField()

    def validate_wbs_number(self, wbs_number):
        try:
            VersionedWBSElement(wbs_number=wbs_number).validate_unique()
       ## I added try-except in order to overwrite the error message
        except ValidationError as e:
            raise serializers.ValidationError("This WBS number already exists.")
        return wbs_number

Hi @simkimsia, sorry for the delay in replying to all your PRs and questions. Your engagement with Cleanerversion is deeply appreciated!
Regarding the VERSION_UNIQUE statement, I'm afraid we didn't make it clear enough it will have an effect with PostgreSQL only:

https://cleanerversion.readthedocs.io/en/latest/doc/historization_with_cleanerversion.html#unique-indexes
https://github.com/swisscom/cleanerversion/blob/master/versions_tests/tests/test_utils.py#L12

If you are using a PostgreSQL data store, you may have skipped, that VERSION_UNIQUE indexes have to be created explicitely as in https://github.com/swisscom/cleanerversion/blob/master/versions_tests/apps.py#L20
Otherwise, the VERSION_UNIQUE keyword will not have any impact.
I hope this helps.

@maennel thanks for responding :)
I used to use django-simplehistory and also softdeletable in django-modelutils but I decided to experiment with cleanerversions and I am beginning to like it more :)
By the way, when you say the indexes have to be created explicitly, what exactly do you mean? I saw the tests code, but I am still confused.

@maennel I am still not too sure but I think I will give this a try as well. Thanks!


Add code for Selction-Sort

@Thuva4 can you please tag this issue with hacktoberfest

I can write Java example if you want?

#162 Implementation in Ruby

#325 Done

Selectionsort #330


Use hermetic Python from rules_python for jsonnet

The previous patch used a custom toolchain from bazel_tools which is incompatible with Bazel 8

Hello @bazelbuild/bcr-maintainers, modules without existing maintainers (jsonnet) have been updated in this PR. Please review the changes.

@bazel-io skip_check unstable_url

@meteorcloudy @fmeum could you PTAL? Thx.


Change PR title to match merge commit title

Point: the merge commit of PRs should match the PR title.
We have a feature that automatically picks up the PR title to use as the commit title, but if we then change it (e.g. from “Update index.js” to something more apt) the PR will stay with the old title.

This feature may be unwanted, so it may warrant a checkbox like “also update the PR title”… or just a dynamic notice.
The title change can happen after the merge is done successfully and will have to remove the  (#124) reference to the PR itself

@issuehunt has funded $60.00 to this issue.

Submit pull request via IssueHunt to receive this reward.
Want to contribute? Chip in to this issue via IssueHunt.
Checkout the IssueHunt Issue Explorer to see more funded issues.
Need help from developers? Add your repository on IssueHunt to raise funds.

@sindresorhus has rewarded $54.00 to @bfred-it. See it on IssueHunt

:moneybag: Total deposit: $60.00
:tada: Repository reward(0%): $0.00
:wrench: Service fee(10%): $6.00


Bug with CORS in Leaflet CSS

The maps are currently looking a little wonky.

The issue seems to be that the Leaflet CSS file is blocked by CORS.

I haven't checked if other maps are affected by this.

Fixed in cfc7ea517c24eb5460d562e5bdae1e6999140223. Leaflet CSS is now local to the static/ dir so we don't rely on third-party hosting.


Bad URL timestamp on image

i got Bad URL timestamp on image  result

Can you explain it more clearly?

i was wrong, i got image from instagram feed with bad url timestamp, i solved it thx

Hello panji31
I am faced with the same issue from instagram feed's image  would you mind give me how did you do to fixe this issue.
Thank you so much

@tantelyalbert
try this https://github.com/falzm/instafeed


How can i use that in my mc 1.12.2 mod?

pls help i need to know that

when you compile the mod into a jar, run java -jar obfuscator.jar --jarIn modIn.jar --jarOut somesexymod.jar

thx


Make separate steps default behaviour

Coming back to this after a few months the default behaviour for the mocha test runner to do all the steps in one test seems a bit awkward. I suggest we make separateSteps: true the default behaviour.
@adamjmcgrath what do you think.

TBH am thinking of reverting back to separateSteps: false on our app, because tests timing out while your debugging steps can be a nuisance. eg.
Step A
Step B // Paused on breakpoint for > 5 secs (mocha timeout)
Step C // test times out and fails before this step is run
Rather than:
Step A, Step B, Step C // spend as long as you like on a breakpoint on Step B, you can still jump into Step C without the test stopping.
This might be a poorly configured mocha thing though, separateSteps: true does look nicer 😄


Introduce a flag to disable client hierarchy in tcgc

In this PR, I changed the default client hierarchy behavior for service not using @client and @operationGroup. Current default behavior and customization logic could refer doc. The original design will introduce a breaking change for existed branded services' client generation if they have sub namespace or interface in their tsp definitions. At that time, we went through all the existed branded services and added customization for them. But after the new version released, we received some service feedbacks such breaking changes impact their ongoing works (client structures are different, we told them to remove interface or use client.tsp to redefine the structure). Also, JS RLC always needs flattened result. This made me think of introducing a flag to control if we should regard tsp's namespace and interface as client hierarchy. Any thoughts?
@Azure/dpg-devs @Azure/dpg-owners

I think we need to figure out what to do if:

hierarchy is disabled and @operationGroup decorator is present ?
hierarchy is enabled and @operationGroup is present ? Is it correct to return the @operationGroup defined hierarchy layers instead of the original hierarchy layers ?

If we agree to deprecate @operationGroup decorator, I think have a flag to disable hierarchy makes sense, and if customers want hierarchy they could defined it with interfaces.


addition to allow-unmocked section of README

@izaakrogan slightly changed wording: https://github.com/pgte/nock/commit/5da238f1a0b37e89ac6c90ca32ab5494ae5bd56e

:+1:


Document the available slots

We had no possibility to document the slots of a component.
The analyzers can handle them now and the custom-elements-manifest have them too.

@slot - This is an unnamed slot (the default slot)
@slot start - This is a slot named "start".
@slot end

Please also define what you can put in the slot.
Like:
/**
 * ....
 * @slot {HTMLElement} icon - A icon to be displayed in the input.
 * @slot {HTMLElement [0..n]} items - Put your form items here
 * /


extensible science paper

[x] create extensible science paper repo with:

manuscript folder
code folder

[x] complete Dean's edits
[ ] update/refocus paper

[x] install in the cloud and create ami
[ ] update instructions to the cloud (obe: we're taking it a step further and that implementation is not yet complete)
[ ] rework intro to emphasize cloudiness
[x] acronym (potentially SICR)
[x] add section for extensibility instructions

"... bc this is a living breathing thing, the reproducible guidelines are specifically for reproducing these exact results, and we are continuing to extend this. To stay up to date, 1. type update, 2. your data, 3. swap out parameters, 4. swap out functions..."

Most of this is done but the contents are a bit out of date as we adjusted our aim. Opening new issue to summarize current objectives; closing this.


About Capcom (CPS-3) Emulation issues

There are casual frame drops, slow downs and stutters on CPS-3 games in general ( Street fighter 3rd Strike: Fight for the Future as example ). The best performance i could get so far is from Retroarch32 emulator with FBAlpha2016 core, but core options are rather limited considering other operating systems on this emulator. Is there a possibille performance gain with other Libretro Cores? If so is it possible to implement these cores under Capcom System? As far as i can see, the Emulation performance of Other OS for CPS-3 games are slightly superior than ArkOs at the moment. Thank you for your understanding.

I play that game regularly and I don’t suffer that issue using fbneo.  Are you using a good brand and authentic SD card such as Sandisk or Samsung?

As another follow up, using a FBAlpha v<IP_ADDRESS> sf3 third strike rom, my matches are smooth and flawless.  I did notice when I had frame throttling on, audio was crackly.  Make sure you’re not using frame throttle settings such as rewind or fast forward.

I am using genuine Sandisk Ultra, Extreme and Samsung Evo Plus cards, i currently have 4 cards in total that is dedicated to my RG351P with 3 different OS built into them.
1- ArkOs - Sandisk Extreme 128GB
2- Arkos - Samsung Evo Plus 256GB
3- 351Elec - Sandisk Ultra 128GB
4- Anbernic Stock OS - NoName 64GB
For comparison, 351Elec and Anbernic Stock OS has no stutters or slowdowns while performing special moves, dashing and when there is a flashy scene on the game, on my both ArkOs builds there are from time to time. Even NoName Card with Stock OS doesn't have any issues running these games in particular, so i think the issue i am having isn't related with Card. I am 100% sure that my SD Cards are genuine, I always buy my cards from reputable stores, for example i bought my Samsung Evo Plus Card from an Official Samsung Store.
For the frame throttle, I've never used fast forward and rewind functions. I rarely play strategic RPG games, i double checked it, and they are off by default.
I also tried to switch between the Hi clock And Normal Clock from the Advanced Menu section, but it didn't helped.
I am a huge Street Fighter Fan and CPS-3 versions of it are my all time favorites. I love using ArkOs and it is my preferred OS by far, that's why I have 2 different builds from it, and i think what you have done with it is spectacular, i can't thank you enough for this. If you can help me resolve my problem with this particular issue, i will really appreciate it. I only switch to 351Elec for playing only a handful of CPS-3 games, and i really want to migrate to ArkOs completely.

I have no clue how to address an issue I can't replicate on my end.  I'm a huge SF fan myself and if I had that issue, I would definitely try to resolve it but I'm not.  Perhaps try to do core updates in retroarch to see if maybe some updates resolve it?

How did you flash the SD cards and have you updated your builds online to the latest 1.6 03182021-1 build?

How did you flash the SD cards and have you updated your builds online to the latest 1.6 03182021-1 build?

Yes, both my builds are up to date. I am checking for new updates on a daily basis tbh. One of my builds is from V1,5 fresh ArkOS, and then updated to the latest version, and my other build is a ready to image called RetroArcade V.03 and they both have same performance.
Can I ask which emulator and core are you using? I am using Retroarch32 as emulator and FBALPHA2016 as the core.

I've checked my 351Elec core settings and it is using "Arcade(FinalBurn Neo)" core, and it has smooth gameplay with no stutters or slowdowns even performing super special moves, parry, and dash.

The default emulator and core for cps3 in ArkOS is retroarch and fbneo.  Again, it’s smooth on my end.  What program did you use to image the sd card with ArkOS.

I am using a Macbook Pro and i used Balena Etcher to write the image to Sd card

That's your problem.  Balena Etcher is not recommended for imaging ArkOS per the instructions I provided on the main page.  It will cause strange performance issues like your experiencing now.  For Mac OS X, Apple Pi Baker is best.  Look over the Mac OS X instructions on the main page and make sure you're following that.

The default emulator and core for cps3 in ArkOS is retroarch and fbneo. Again, it’s smooth on my end. What program did you use to image the sd card with ArkOS.

I know that it is like this by default. However the emulation by that configuration is actually like how RG350M emulates CPS-3 games, very choppy and stuttering. And every other system runs as is should be, so i don't see a reason for the program that i wrote can effect only that particular part of the image. I have witnessed other people having problems with CPS-3 games with regular Retroarch emulator, so i advised them to switch Retroarch32 and FBALPHA2016 Core to improve the performance. If you can DM me on FB, i can shoot a video and send it for you to see if you don't mind. My name is Vahit Dincman.

I am not on and don't use facebook.  I have checked with other users on the RGHandheld discord who have confirmed with me that the default retroarch and fbneo core give them smooth game play with sfiii 3rd strike on the rg351p/m, rgb10, oga, and rk2020.  They all confirmed as well that they following my imaging recommendation and have not experienced issues.  I can't explain why Balena Etcher causes issues with ArkOS with just writing, but I have witnessed that it does.  At this point, I will close this issue because there's not anything more I can do with this issue since I can't get anyone else to replicate this issue and you're using an unsupported image writing tool for this image.  I guess for CPS3, use 351elec or stock.  Take care.

Thanks for your time anyways, thumbs down was done by mistake by the way. I was trying to put a sad face haha 😅
I will try to write it again with a recommended software and try again.


[osx] Use Retina display scale

On Retina displays view/window coordinates are logical points not pixels and window.backingScaleFactor represents how many pixels are covered by single coordinate point.
This change effectively makes LAF UI 2x smaller on Retina displays, but allows drawing at native Retina resolution.
A picture is worth a thousand words: (NOTE: Click on the image to see it on full 2x/Retina scale)

Picture above depicts Aseprite using 400% scale on Retina and using TTF font instead of bitmap font.
I understand this change may be completely irrelevant for most of the Aseprite users using default UI settings, but if you want to use TTF font this change actually makes all TTF fonts look crisp on macOS Retina displays. And I prefer to have TTF font on my Retina display rather than default bitmap font, that I find hard to read 🙄

I agree that my contributions are licensed under the Laf license, and agree to future changes to the licensing.

Hi @nanoant, I like this because it makes even more similar to the Windows implementation (which uses the high DPI resolution). I'll review this next week (still not sure if we should make this optional). Thanks for the contribution!

@dacap Great, thanks. Indeed this makes the macOS Aseprite behavior on par with Windows. I was first using Aseprite on my Windows PC machine for Godot development, and then when I tried to use it on my Mac, I found out that despite being NSHighResolutionCapable Aseprite is not drawing at full Retina res. Hence the PR.
FYI I've just updated my PR as I forgot to handle display scale OSXWindow::setScale. I hope now all the necessary code paths are covered.


[WIP] Migrate legacy JavaScript to Rollup/Jest

Still includes all commits from #1240. Needs to be rebased once that's merged.

Turn Sprockets requires into imports
Keep assigning to pageflow global
Add imports for external libraries to make tests work
Build into dist using Rollup
Migrate specs to Jest
Remove Teaspoon

REDMINE-17203

Coverage remained the same at ?% when pulling ab80c98a26579f2ccbbac1f662d7ff4ce5cc3ce2 on tf:frontend-rollup-jest into 881adcde694076a76c8d7c289958b78c18d9196f on codevise:master.


Awake Module - Tray Icon Not Working Properly

Microsoft PowerToys version
0.84.1
Installation method
PowerToys auto-update, Microsoft Store
Running as admin
Yes
Area(s) with issue?
Awake
Steps to reproduce
I do not have steps to reproduce.
✔ Expected Behavior
Tray icon to appear normally as Windows start-up, and not suddenly gone missing. The right or left-clicking on the icon to pop up balloon to change the mode settings without having to go through inside the PowerToys window app to manually change within the module section.
❌ Actual Behavior
One day, suddenly Awake module is not working properly. Sometimes, the tray icon went missing, after restarting laptop or PowerToys, both as normal user and administrator, the Awake module pops up at the tray icon but right or left-clicking on it still does not work. I have to manually go to the module within the program itself to change mode settings.
Other Software
None.

Yes the only way to fix the tray icon I found is to do a clean reinstall while also deleting the appdata folders with settings that the uninstaller does not remove. After that the icon works again but breaks after each update past 0.84.0 so I am just going to not update my powertoys anymore since I also use fancyzones and redoing all my settings after each update is not feasible. I will wait for the next major version to see if this is fixed.

I had this same issue after the last update, v0.84.1
I had to exit PowerToys and restart it for the Awake icon to work properly again.

I tried uninstalling powertoys and removing any folders within appdata or common folders and reinstall it via GitHub files. Still problem. But I am on 0.84.1 version though. Not sure but I think the issue started to occur on the 0.84.0 update itself. The previous version was working alright. Even after restarting the app and restart the PC, still occurs.

I'm also facing the same problem. Either PowerToys v0.84.1 or Windows Update (KB5043076) broke it. This problem wasn't in v0.84.0. I updated to v0.84.1 yesterday and installed windows update (KB5043076) today.

version 0.83.0 works fine so I reverted to that.

I uninstalled version 0.84.1 and 0.84.0. Delete all folders related to PowerToys in Program Files, User AppData and ProgramData (if any). Downloaded from GitHub the previous release, namely the 0.83.0, installed it and voila. It works normally as it should. I think it has something to do with the changes in 0.84.0 and above. Not sure if I should close this thread as it is a workaround, not a fix.

facing the same, after a restart of computer or coming back from sleep, the icon is gone. closing powertoys, and opening it up again brings up the icon, and therefore, i assume, the functionality associated!

My Awake icon also disappears, but it is also not keeping my system awake. Are others having their system stay awake even with no icon?

Same issue here. Awake tray icon disappears on reboot. Restarting Powertoys or toggling Awake off and then back on gets the icon back.
Windows 11, 23H2

Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report!

That's great, maybe do something about it?


Reserved 'class' keyword used, unused statement

Reserved 'class' keyword used in line 27, unused statement in line 68, IE8 support (fix creating style object)

Thanks again dude!


"Călene" is listed in the drop-down menu

Description:
"Călene" is listed in the drop-down menu alongside its corresponding county and commune, according to the law
Precondition:
The website is up an running.

Step 1
Type "Călene" in the search bar.

Expected results
The location is listed in the drop-down menu as "Călene, Alba (Cugir)".


Back-end available?

Stumbled across the project and noticed the back-end is mentioned in the initial readme but points to a dead link, is the back-end still open source?

@DarkLotus thanks for your interest in this project. The back-end used to be open source but we recently made the repo private for security purposes. Happy to provide read access if you are curious.

@gzurbach  Hey that would be great, thanks for the speedy reply 👍

Sent you an email via http://www.gippslandweb.com.au. I'd like to discuss privately before granting you access. Cheers!


SaaS Guide is empty

On the getting started section of Readthedocs,
Default Plan
If you are using pinax-stripe for something like a Software-as-a-Service site with subscriptions, then you will want to also set the Stripe ID for a PINAX_STRIPE_DEFAULT_PLAN setting and install middleware. See the SaaS Guide for more details about working with subscriptions.
SaaS Guide doesn't have content.

I was hoping documentation would be added vs just removing the links.

I would prefer that too, but I'm not familiar enough with Pinax to add them myself.
Basically, this provides all the Models that most people will need when working with Stripe and the built-in webhook support is fantastic.  It appears to not be very opinionated on how to use it in an ecommerce application though. This is probably why theres so many plain old functions in the "actions" directory and not many forms or model methods.
Suggestion for new users:
View this tool as a great starting point instead of a complete turn-key solution to Stripe. Fork the repo, use the built-in models and webhook support, create your own forms, views and templates as needed.

No, forking would be a very bad idea.
There are forms and views in this app, and bootstrap templates exist in pinax-theme-bootstrap. Not everyone uses bootstrap which is why they live in the theme and not the app.
There is turn key example in the stripe starter project.

On Apr 20, 2017, at 8:41 PM, Michael<EMAIL_ADDRESS>wrote:
I would prefer that too, but I'm not familiar enough with Pinax to add them myself.
Basically, this provides all the Models that most people will need when working with Stripe and the built-in webhook support is fantastic. It appears to not be very opinionated on how to use it in an ecommerce application though. This is probably why theres so many plain old functions in the "actions" directory and not many forms or model methods.
Suggestion for new users:
View this tool as a great starting point instead of a complete turn-key solution to Stripe. Fork the repo, use the built-in models and webhook support, create your own forms, views and templates as needed.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

Link to starter project
https://github.com/pinax/pinax-starter-projects/tree/stripe

Also this might be helpful
https://youtu.be/TD72smkxbLw


Support Python3

Python2 is being deprecated and this library uses unicode methods for string handling in the other packages. Better clean that up and use six instead?

That's on my list :)
I don't know much of six but I do really want to stick with the latest, I will do more research.

Biggest suggestion is to use six's u() method. It will convert a "regular" string object to an unicode variant (Python 2 being unicode, Python 3 being str)
https://six.readthedocs.io/#six.u

There shouldn't be a lot to do here and may be able to do it myself.

bear with me on this matter, I am totally new to the whole Python2 <> Python3 compatibility (we Java folks don't have that problem) but I do want to learn.
Are you suggesting replacing:
bytedata = bytearray("%s\r"%(strcmd.strip()))
with
bytedata = bytearray(six.u("%s\r"%(strcmd.strip())), 'utf8')?
I can see the bytearray() function works in Python3 as well.

https://github.com/c3V6a2Vy/pyanova/pull/7
Can you please take a look?

I can take a look. I've started a local branch from your new branch with a number of other changes (mostly syntax updates and for testing locally).
Another suggestion is using Format strings instead of printf strings as future versions support them better.


Implements a version of tag generation where a common set of tags are repeatedly sampled

What does this PR do?
When generating dogstatsd contexts, the current approach simply generates completely random tags until the number of desired contexts is reached, which works, but doesn't reflect real-world usage of dogstatsd.
In the real world, tags are repeated amongst messages frequently and its usually the unique combinations that create cardinality.
Motivation
String interner experiments
Related issues
This currently under-generates cardinality dramatically. If I request 100k contexts, I only get 1268 contexts. This is due to the way the common pool is sampled.
This algorithm needs some work, but posting this early as a draft in case anyone has feedback/ideas.
Additional Notes
Anything else we should know when reviewing?

I like the direction this is taking.

closing in favor of #822


Insert links

When user trying insert links without selecting text, the links don't appear...
I thing library should insert URL or title into  tag (e.g. URL or title)and inserts it into editor.

~michalciolek
I ran into the same issue. I modified the zss_editor.insertLink function in ZSSRichTextEditor.js to be
zss_editor.insertLink = function(url, title) {
zss_editor.restorerange();
var html_code = '' + title + '';
zss_editor.insertHTML(html_code);
}
Use at own risk!

@pang0018 - Really not sure how that code would help.

Well link inserting was not working on my device when I cloned your project. If there is something better I am all ears!

Inserting links works correctly. What issues are having?

I don't recall, It was over 3 months ago. We ended up not using the link insertion part so it didn't matter. When we decide to use that I will post what issues I am having, if any.

I have the same question!!

insert links without selecting text，i get next content:
This is a test of the ZSSRichTextEditor by Zed Said Studio

I have just tested the links and they are working properly, I can not reproduce the issue you are encountering so for now I will close this issue. @szl-926929 @pang0018 @michalciolek if you can produce the exact steps you did when you came across this issue and I can reproduce the issue from those steps then I will re-open this issue.


test: add failing legacy tx

Motivation
Decoding this legacy tx through TxEnvelope::decode fails, but decoding it via TxLegacy::decode_signed_fields (or even TxLegacy::decode) works
Solution
Unsure as of yet
PR Checklist

[ ] Added Tests
[ ] Added Documentation
[ ] Breaking changes

nvm, i passed the wrong buffer -,-


fixed issue https://issues.shopware.com/issues/SW-23452

1. Why is this change necessary?
2. What does this change do, exactly?
3. Describe each step to reproduce the issue or behaviour.
4. Please link to the relevant issues (if any).
5. Which documentation changes (if any) need to be made because of this PR?
6. Checklist

[ ] I have written tests and verified that they fail without my change
[ ] I have squashed any insignificant commits
[ ] This change has comments for package types, values, functions, and non-obvious lines of code
[ ] I have read the contribution requirements and fulfil them.

Closed after talking to @snHolst


make the original font name available from getTextContent()

The fontName available from getTextContent() calls appears to be the name of the font loaded to be used in text layer rendering, which can be different from the actual font name loaded from the PDF.  For example, in a test PDF, I see getTextContent() always return fontName "Helvetica" for chunks which are "Arial", ""Arial,Bold" and "Arial,BoldItalic".
The original font name can be useful to applications in inferring information about the original PDF text, like determining whether adjacent text chunks belong together or not.  This can help applications improve selection and extraction efforts.
I wasn't able to find any other way to receive this information from the existing APIs, but many discussions/requests about how to retrieve similar information (such as https://github.com/mozilla/pdf.js/issues/7372).

Just so I understand, is the difference between fontName and originalFontName that the former may be different because of font substituations, i.e., if Arial is not available that it falls back to Helvetica? In that case, I'm fine with adding this property if it makes sense.
@Snuffleupagus Do you perhaps have an opinion/more context for this?

@Snuffleupagus Do you perhaps have an opinion/more context for this?

Yes, and I'm not convinced that the additional memory usage that this feature will incur is going to be acceptable given that this is essentially unused code (for e.g. the default viewer).
The problem, as I see it, is that this is adding a new property to every single textItem, and there can obviously be an arbitrary number of those per page (e.g. easily in the thousands).
The key itself isn't exactly short, but the main issue is that the "original" font name can be up to 127 bytes long (given that it's of type Name). All of this will add up, and given the specialized use-case it's not really clear that you want to add this type of overhead to all getTextContent/streamTextContent calls by default.

Good point, that sounds very reasonable to me. It can always be done in a custom deployment of PDF.js, so in that case I'm closing this as won't-fix.

Is there an alternative way to get the original font name?
If not, it does seem inefficient to add the original font name to TextItem, but what about adding it to TextStyle? Would a PR with that functionality be accepted? I'm not sure how feasible it would be to accomplish, but I wouldn't want to do the work if it wouldn't be accepted.
Based on this issue and the couple of thumbs up it's gotten (excluding my own :smile:), it seems like I'm not the only one that would be interested.
Thanks!

... as for whether my idea will be possible, it seems pretty trivial, e.g.
        textContent.styles[loadedName] = {
          fontFamily: font.fallbackName,
          originalFontName: font.name, // <--- here
          ascent: font.ascent,
          descent: font.descent,
          vertical: font.vertical,
        };

https://github.com/mozilla/pdf.js/blob/fa47d4b9b114579c8dd8971921c6ec2f23555105/src/core/evaluator.js#L2434-L2439
But would such a PR be accepted? Or is there another way to do this?
Thanks!

In case anyone ends up here trying to get the original font name, it's now possible thanks to #15659. Here's some sample code:
const { items, styles } = await pdfPage.getTextContent();

await pdfPage.getOperatorList();

for (const item of items) {
  if ('fontName' in item) {
    console.log('fontName=', item.fontName);
    console.log(
      'originalFontName=',
      page.commonObjs.get(item.fontName).name
    );
    console.log();
  }
}

And the output:
fontName= g_d0_f1
originalFontName= ArialMT

fontName= g_d0_f3
originalFontName= Arial-BoldMT

fontName= g_d0_f3
originalFontName= Arial-BoldMT

fontName= g_d0_f4
originalFontName= Arial-ItalicMT

fontName= g_d0_f4
originalFontName= Arial-ItalicMT

fontName= g_d0_f5
originalFontName= Arial-BoldItalicMT

fontName= g_d0_f5
originalFontName= Arial-BoldItalicMT


AddProperty doesn't work if you have "s in the string.

The original lib causes an error while doing this:
body := "{\"a\":\"b\"}"
vertex.AddProperty(client, "json", body)

# generated query is
# g.V().hasId("..").property("json", "{"a":"b"}")

# this patch, causes the generated query to be right:
# g.V().hasId("...").property("json", "{\"a\":\"b\"}")

Nice contribution @brugnara! I saw your comment on #5 so I look forward to seeing any other patches you make for AWS Neptune compatibility. I'd be interested in helping more with that work and doubling down on getting MS Cosmos DB working as well.

@damienstamates sadly my branch is not working with Neptune but with Tinkerpop and UUID as IDs only. Errors are on JSON.Unmarshal that fails when data comes from the DB and are going to be parsed into structs.
# error while doing `AddVertex`:
json: cannot unmarshal string into Go struct field VertexValue.id of type model.ID

As for now I moved to github.com/schwartzmx/gremtune but it is very chaotic for reading data from Neptune but I needed something working due time requirements :disappointed:
I'll wait for your feedback about this and #5 as you pointed out.
Many thanks and have a nice Christmas :+1:


add tls and tcp keepalive config for metrics service

Please provide a description for what this PR is for.
And to help us figure out who should review this PR, please
put an X in all the areas that this PR affects.
[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[X ] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure

@rshriram can you PTAL at this when you get some time?

@ramaraochavali: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

racetest_istio
7aed916310c026e81c109904b5956bae53f9494e
link
/test racetest_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test racetest_istio

cc @linsun

I think we allow unknown flags now
On Mon, Sep 16, 2019, 9:52 PM Shriram Rajagopalan<EMAIL_ADDRESS>wrote:

@rshriram commented on this pull request.
In pilot/cmd/pilot-agent/main.go
https://github.com/istio/istio/pull/17046#discussion_r324979818:

@@ -638,8 +643,8 @@ func init() {
"Connection timeout used by Envoy for supporting services")
proxyCmd.PersistentFlags().StringVar(&statsdUDPAddress, "statsdUdpAddress", values.StatsdUdpAddress,
"IP Address and Port of a statsd UDP listener (e.g. <IP_ADDRESS>:9125)")

proxyCmd.PersistentFlags().StringVar(&envoyMetricsServiceAddress, "envoyMetricsServiceAddress", values.EnvoyMetricsService.Address,

"Host and Port of an Envoy Metrics Service API implementation (e.g. metrics-service:15000)")

proxyCmd.PersistentFlags().StringVar(&envoyMetricsService, "envoyMetricsService", "",

How will this cause compatibility issues ? We can mark it as deprecated if
it does.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/istio/istio/pull/17046?email_source=notifications&email_token=AAEYGXK4QHBUKWXY3VTTUZLQKBPBXA5CNFSM4IWBQMNKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCE5A7UQ#discussion_r324979818,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAEYGXLZPLPRRZAAFELUUYTQKBPBXANCNFSM4IWBQMNA
.

Sorry, did not see @howardjohn's comment, yes we do allow unknown flags now https://github.com/istio/istio/blob/master/pilot/cmd/pilot-agent/main.go#L131. So should not be an issue.

@linsun @sdake Can you please take a look at this PR as well?

@howardjohn Can you PTAL at this?

@ramaraochavali: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-mixer-k8s-tests_istio
f839236e910d4daac0a0e8aaa17f76444873e76d
link
/test integ-mixer-k8s-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test integ-mixer-k8s-tests

@howardjohn Fixed the issue now. PTAL.

@ramaraochavali: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

racetest_istio
e6c0fa74118a1502e61ccc1d62dc4e06a5c9b13f
link
/test racetest

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test racetest

@ramaraochavali: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-mixer-k8s-tests_istio
e6c0fa74118a1502e61ccc1d62dc4e06a5c9b13f
link
/test integ-mixer-k8s-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test integ-mixer-k8s-tes

/test integ-mixer-k8s-tests

@ramaraochavali: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-mixer-k8s-tests_istio
e6c0fa74118a1502e61ccc1d62dc4e06a5c9b13f
link
/test integ-mixer-k8s-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test integ-mixer-k8s-tests

@howardjohn  do you think we should port the trim fix for AccessLogService to 1.3 branch?

@ramaraochavali: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-security-k8s-tests_istio
e6c0fa74118a1502e61ccc1d62dc4e06a5c9b13f
link
/test integ-security-k8s-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test integ-security-k8s-tests

@ramaraochavali: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-security-k8s-tests_istio
e6c0fa74118a1502e61ccc1d62dc4e06a5c9b13f
link
/test integ-security-k8s-tests

integ-new-install-k8s-tests_istio
9880d0a41359826a2d89b3779945ed413f31a5e8
link
/test integ-new-install-k8s-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ramaraochavali: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-security-k8s-tests_istio
e6c0fa74118a1502e61ccc1d62dc4e06a5c9b13f
link
/test integ-security-k8s-tests

integ-new-install-k8s-tests_istio
9880d0a41359826a2d89b3779945ed413f31a5e8
link
/test integ-new-install-k8s-tests

integ-mixer-k8s-tests_istio
9880d0a41359826a2d89b3779945ed413f31a5e8
link
/test integ-mixer-k8s-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ramaraochavali: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-new-install-k8s-tests_istio
9880d0a41359826a2d89b3779945ed413f31a5e8
link
/test integ-new-install-k8s-tests

integ-mixer-k8s-tests_istio
9880d0a41359826a2d89b3779945ed413f31a5e8
link
/test integ-mixer-k8s-tests

integ-security-k8s-tests_istio
9880d0a41359826a2d89b3779945ed413f31a5e8
link
/test integ-security-k8s-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test integ-security-k8s-tests


Add domain for nce.edu.np in reverse domain structure

Add domain for nce.edu.np in reverse domain structure

@silwalprabin First stage of verification passed, official domain is nce.edu.np as far as I verified. This is just an informational note. Pull request is still in the review. I appreciate your patience while waiting for the final decision.

@silwalprabin Thank you for your patience while waiting for a review and processing your request. Pull request merged.


Implement Certification Attribute

Critical Changes
Changes
Issues Closed
New Metadata
Unpackaged Metadata
Deleted Metadata
Testing Notes

Deprecating this PR.


Unable to update to 3.13.1: Missing file from release 3.13.1: win32-x64-57_binding.node

node --version
8.11.4
npm --version
5.6.0

Problem installing<EMAIL_ADDRESS>Downloading binary from https://github.com/sass/node-sass/releases/download/v3.13.1/win32-x64-57_binding.node
Cannot download "https://github.com/sass/node-sass/releases/download/v3.13.1/win32-x64-57_binding.node":

HTTP error 404 Not Found

and I didn't have python on this machine so the install failed.
First Question: what is the source of the 57 in "win32-x64-57_binding.node" is it wise to just modify it to 51?   Is the 57 related to the node version 8.11?

Wanted to log this for posterity.
Next course of action is to add python2 to this machine.

https://github.com/sass/node-sass/blob/master/TROUBLESHOOTING.md#404-downloading-bindingnode-file


add tests for x86

add tests for x86
Tested on Ubuntu 18.04 LTS, binary compiled with gcc 7.5.0.
*It runs properly on the local x86 machine, but segfault will appear when using qemu-i386 to run the patched binary file.
**Add{RO, RW, RWInit}DataPatch will fail when adding data of length 10,000.
fix clang cmd
fix inconsistent types of variable compile_flags
https://github.com/angr/patcherex/blob/feat/ezpz/patcherex/patches.py#L73
https://github.com/angr/patcherex/blob/feat/ezpz/patcherex/utils.py#L740

Should binaries be added here, rather than in the binaries repo? I see that many are already here, but in the interest of not having our repos blow up to hundreds of megabytes, it might be preferable to commit them there.
Also, I see nose being used. It would be preferable to use standard-library unittest or python's built in asserts in place of nose, as we are hoping to eventually drop that dependency.

@twizmwazin so, would you move the binary to angr/binary?
I think it makes sense.

Also, I see nose being used. It would be preferable to use standard-library unittest or python's built in asserts in place of nose, as we are hoping to eventually drop that dependency.

@twizmwazin
Thank you for the advise, I've replaced the uses of nose with python's built in asserts statement.

@twizmwazin so, would you move the binaries to angr/binary?
I think it makes sense.

I think moving binaries to the binaries repo would make sense, and would be consistent with other angr projects. To load them, we use the assumption that the binaries repo is cloned into the same folder patcherex is cloned into.

I've moved binaries to angr/binaries
https://github.com/angr/binaries/pull/54

@twizmwazin do you think this is good to be merged now?

A few notes:

There is a print statement in there that should be removed
Unless there is a reason to go against convention, test names should ideally be snake_case
The run_all function can likely be replaced with unittest.main()
pep8 dictates that there should be two newlines between module-level imports/functions/statements

With those minor tweaks, lgtm

@twizmwazin Thank you for your review. I've fixed them.


MINOR FIX: Fix GetRandomBoolean in AIModelServiceTests

The Ask
Our current implementation of GetRandomBoolean in AIModelServiceTests will always return false but we need it to return a random boolean.
How to Complete this Task

Fix GetRandomBoolean such that it returns a random boolean.
You can see how a similar issue was fixed with #248.

How to claim this issue?

Post on this issue a comment that says: "I claim this issue"
You will be given 24 hours to complete the issue - if no PR is opened within 24 hours someone else will claim it
If you have an open PR but is inactive for more than 24 hours from the last review comment we will shutdown your PR

I claim this issue


plugin:vite:css - internal server error on run of freshly cloned template (JS & TS)

Describe the bug
Followed the instructions in the "getting started" guide for either the JS or TS template, and I run into an error upon running the dev server for the project:

[vite] Internal server error: Cannot read properties of undefined (reading 'config')
Plugin: vite:css
File: C:/.../my-app/src/App.module.css
at getTailwindConfig

Not sure if this is a vite thing, a solid thing, a tailwind thing, or potentially an issue with my system, I've never tried solid before. I don't understand the call made to getTailwindConfig, because tailwind isn't even installed in the project and I've made no extra configurations. Not providing an example for the repro since this is a fresh install with no edits made.
Your Example Website or App
https://github.com/solidjs/templates/tree/master/ts
Steps to Reproduce the Bug or Issue

Go to https://www.solidjs.com/guides/getting-started
run the commands listed for either the JS or TS vite templates
upon running npm run dev, visit localhost:3000
see the error listed by vite

Expected behavior
As a developer, I expect a freshly downloaded & installed template to run properly, however I am running into an error without making any changes
Screenshots or Videos
No response
Platform

OS: Windows 10
Browser: Chrome
Version: 104.0.5112.102

Additional context
No response

found more info on this - vite/postcss weird thing where if you have parent directories that have postCSS config, it will try to use it. closing, sorry! https://github.com/vitejs/vite/issues/4678


FEATURE: Add some additional movement commands

Did you check the docs?

[X] I have read all the docs.

Is your feature request related to a problem? Please describe.
In some constellations of opened child nodes it is somewhat hard to get to the nodes I want to quickly. For example I'd like to go to the first or last child of an opened node or skip an opened node entirely.
Describe the solution you'd like.
Add commands for the following:

next/previous sibling (skips child nodes)
first/last sibling (jumps to the first or last sibling on the same nesting level)

Describe alternatives you've considered.
No response
Additional Context
No response

I'd also like to see this. Though, I think it might be possible using a custom command. I'll reply if I figure it out.

Another one I found missing from nvim-tree was to go to the parent node. I have something like:
parent = function(state)
    local node = state.tree:get_node()
    local parent_path, _ = utils.split_path(node:get_id())
    renderer.focus_node(state, parent_path)
end,

I've been using this:
local goToParent = function(state)
    local node = state.tree:get_node()
    renderer.focus_node(state, node:get_parent_id())
end

local goToParentAndClose = function(state)
    goToParent(state)
    local node = state.tree:get_node()
    if node:is_expanded() then
        fsc.toggle_node(state)
    end
end

I think your snippets are worth a PR ;)
If you have any interests, take a look at https://github.com/nvim-neo-tree/neo-tree.nvim/blob/main/lua/neo-tree/sources/common/commands.lua and https://github.com/nvim-neo-tree/neo-tree.nvim/blob/main/lua/neo-tree/sources/filesystem/commands.lua.

Since we already have this discussion going and I didn't want to create a new issue just for this: Is there a way to get the open commands to NOT automatically expand nested files and instead just open the top level file?

instead just open the top level file?

Do you mean folder?

I mean to have one command that does the following:

when run on a closed folder/directory -> expands it
when run on a file with other files nested under it -> opens the file without expanding it
when run on any other file -> opens the file

Number 2 is not possible right now as far as I know, because the built-in open command will always first expand files with nesting and then open it when you run it again on the same file.

Ok, got it.
Well unfortunately it is now hardcoded to expand the file if it is not expanded so I think you'll need a new feature request for that.


LP is not letting some plugins access the default group

Description
Im using AGMRanks plugin (https://www.spigotmc.org/resources/agm-ranks-rankup-plugin.75787/)
Long story short, the plugin needs to access the "default" group to work, which LP is not letting it do so.
I contacted the AGMRanks author thinking it was a problem ralted to his plugin, we discuss about it, and we reach the conclusion that this issue is caused by LP.
This code might be useful for the LP dev team:
https://git.agmdev.xyz/AGMRanks/blob/master/src/main/java/me/ashenguard/agmranks/ranks/RankManager.java#L45
https://git.agmdev.xyz/AGMRanks/blob/master/src/main/java/me/ashenguard/agmranks/Vault.java#L99
Reproduction Steps
Install AGMRanks and AGMCore (Dependency), Vault and LP.
AGMRanks will send a warn saying that plugin was disabled because there is no "default" group in the permission manager.
Expected Behaviour
AGMRanks should be able link/hook with the "default" group of LP
Server Details
git-Paper-66 (MC: 1.18) (Implementing API version 1.18-R0.1-SNAPSHOT)
LuckPerms Version
5.3.87
Logs and Configs
No response
Extra Details
No response

By default, the Vault getGroups method returns the display name of all loaded groups.
https://github.com/LuckPerms/LuckPerms/blob/664cad21a9c24954503a78b44ae218d13353a465/bukkit/src/main/java/me/lucko/luckperms/bukkit/vault/LuckPermsVaultPermission.java#L163-L168
You can make it return the group ids instead by changing the vault-group-use-displaynames config option.
https://github.com/LuckPerms/LuckPerms/blob/664cad21a9c24954503a78b44ae218d13353a465/bukkit/src/main/java/me/lucko/luckperms/bukkit/vault/LuckPermsVaultPermission.java#L314-L320


fix(protocol): can use custom content when Dubbo encode

Issues associated with this PR
1304
Solutions
also set payload when invoke DubboFrame.SetData, and make old raw nil
UT result
Unit Test is needed if the code is changed, your unit test should cover boundary cases, corner cases, and some exceptional cases. And you need to show the UT result.
Benchmark
If your code involves the processing of every request, you should give the Benchmark Result.
Code Style

Make sure Goimports has run
Show Golint result

please fix the conflict

we close this pr. if you still want this pr merged, fix the conflict and make a new one. thanks @Sharember


Typescript value type question

    export interface ValueViewerProps<T extends Cell<T, V>, V = string> {
        /** The result of the valueRenderer function */
        value: string | number | null;
        /** The current row index */
        row: number;
        /** The current column index */
        col: number;
        /** The cell's raw data structure */
        cell: T;
    }

 /** The properties that will be passed to the DataEditor component or function. */
    export interface DataEditorProps<T, V = string> {
        /** The result of the dataRenderer (or valueRenderer if none) */
        value: string | number | null;
        /** The current row index */
        row: number;
        /** The current column index */
        col: number;
        /** The cell's raw data structure */
        cell: T;
        /** A callback for when the user changes the value during editing (for example, each time they type a character into an input). onChange does not indicate the final edited value. It works just like a controlled component in a form. */
        onChange: (newValue: V) => void;
        /** An event handler that you can call to use default React-DataSheet keyboard handling to signal reverting an ongoing edit (Escape key) or completing an edit (Enter or Tab). For most editors based on an input element this will probably work. However, if this keyboard handling is unsuitable for your editor you can trigger these changes explicitly using the onCommit and onRevert callbacks. */
        onKeyDown: React.KeyboardEventHandler<HTMLElement>;
        /** function (newValue, [event]) {} A callback to indicate that editing is over, here is the final value. If you pass a KeyboardEvent as the second argument, React-DataSheet will perform default navigation for you (for example, going down to the next row if you hit the enter key). You actually don't need to use onCommit if the default keyboard handling is good enough for you. */
        onCommit: (newValue: V, event: React.KeyboardEvent<HTMLElement>) => void;
        /** function () {} A no-args callback that you can use to indicate that you want to cancel ongoing edits. As with onCommit, you don't need to worry about this if the default keyboard handling works for your editor. */
        onRevert: () => void;
    }

Why is value of type string or number or null and not simply of type V or V | string | number | null?
Thanks in advance.

I have the same question. I am using TypeScript and I wish to render a ReactNode as the cell value:
import React, { ReactNode } from 'react'
import ReactDataSheet from 'react-datasheet'
import 'react-datasheet/lib/react-datasheet.css'

interface GridElement extends ReactDataSheet.Cell<GridElement, ReactNode> {
  value: ReactNode;
}

class MyReactDataSheet extends ReactDataSheet<GridElement, ReactNode>{ }

export function Example() {

  const grid: GridElement[][] = [
    [
      { value: Example grid value }
    ]
  ]

  return (
    <MyReactDataSheet
      data={grid}
      valueRenderer={cell => cell.value} // TypeScript error here
    />
  )
}

However, I am getting the following TypeScript error:
No overload matches this call.
  Overload 1 of 2, '(props: DataSheetProps<GridElement, ReactNode> | Readonly<DataSheetProps<GridElement, ReactNode>>): MyReactDataSheet', gave the following error.
    Type 'ReactNode' is not assignable to type 'string | number | void | null'.
      Type 'false' is not assignable to type 'string | number | void | null'.
  Overload 2 of 2, '(props: DataSheetProps<GridElement, ReactNode>, context: any): MyReactDataSheet', gave the following error.
    Type 'ReactNode' is not assignable to type 'string | number | void | null'.

It looks like the valueRenderer property needs to return a string | number | void | null. In Javascript (rename to *.jsx and remove type annotations), this renders just fine. Is it possible to extend valueRenderer to include V as @shawnmitchell suggests?


Add Snowflake Reserved Words to Extension file

What type of PR is this?
 Improvement
What does this PR do / why is it needed ?
 Adding snowflake reserved words to extension file
Which issue(s) this PR fixes:

Fixes #
Other notes for reviewers:
Does this PR introduce a user-facing change?
 Yes, they will be able to query using reserved words

/easycla


Make Load method public Task

Is your feature request related to a problem? Please describe.
The loader includes an async Load method but it's private so if I want to use async code to load avatars I either have to fork your repo or create an extra async wrapper.
Describe the solution you'd like
It's just a minor change to make the Load method public and return Task<CompletionEventArgs>, so that the caller can decide if they want an async Task or using the event listeners.
Describe alternatives you've considered
I've forked the repo.

The feature is implemented https://github.com/readyplayerme/rpm-unity-sdk-avatar-loader/pull/76


Validate relative notebook path only in version > 1

This was also causing the red error message when the migration dialog appeared as pipeline version 1 had absolute paths.
Developer's Certificate of Origin 1.1
   By making a contribution to this project, I certify that:

   (a) The contribution was created in whole or in part by me and I
       have the right to submit it under the Apache License 2.0; or

   (b) The contribution is based upon previous work that, to the best
       of my knowledge, is covered under an appropriate open source
       license and I have the right under that license to submit that
       work with modifications, whether created in whole or in part
       by me, under the same open source license (unless I am
       permitted to submit under a different license), as indicated
       in the file; or

   (c) The contribution was provided directly to me by some other
       person who certified (a), (b) or (c) and I have not modified
       it.

   (d) I understand and agree that this project and the contribution
       are public and that a record of the contribution (including all
       personal information I submit with it, including my sign-off) is
       maintained indefinitely and may be redistributed consistent with
       this project or the open source license(s) involved.

Rather than adding a version check inside our validation why don't we just not validate prior to conversion?
As far as I can tell this line is extraneous and the source of this problem, we could just remove it:
https://github.com/elyra-ai/elyra/blob/2bfcf9a903e56fc08435ccd8b87d80fe0c5228ef/packages/pipeline-editor/src/PipelineEditorWidget.tsx#L914

This strikes me as a bit of a slippery slope and will likely lead to additional version checks scattered across the codebase when only the initial load of a pipeline should detect, and respond to, version levels and the rest of the code should be able to assume everything is at the expected version.
If this is an order of operations thing, then shouldn't version checks (with the possible trigger of migration) be performed before any validation?  If the user then chooses not to migrate, shouldn't they see the validation errors since their pipeline is indeed invalid?  I don't think we should give down-level users a false impression that their pipelines are valid when they're not (relative to the current software version).

currently, if the user chooses not to migrate the pipeline is not opened/showed. so the user has no option to open/view the pipeline without migrating. if this is the preferred behavior then we should validate only if no migration is needed or after a successful migration. @ajbozarth  i believe this should involve just moving the this.setAndVerifyPipelineFlow(pipelineJson); out of line 914 and into an else clause:
if (pipelineVersion !== PIPELINE_CURRENT_VERSION) {
  ...
} else {
   this.setAndVerifyPipelineFlow(pipelineJson);
}

I did as suggested by @vabarbosa but actually inside the setAndVerifyPipelineFlow to avoid duplication

I did as suggested by @vabarbosa but actually inside the setAndVerifyPipelineFlow to avoid duplication

This is still adding a version check inside validation code, just farther upstream. @kevin-bates point still stands. I'm not sure what you mean by "avoid duplication", why would handling this where we already do a version check be duplicating code?

Ok, this now only changes the opening validation phase.  And let all other validations as is.

Hmm.  It still seems like we should perform validation even after opting out of migration and the first check made during validation is that the version is a match.  In this case, unlike initial load, no migration wizard is presented, but the pipeline is flagged as invalid and the rest of the validation is not performed.  This would then display the pipeline to the user, allowing them to open notebooks, adjust properties, etc., but they must first go through the migration wizard before attempting to run.  (Of course, I'm sure I'm over-simplifying things here, but I'm hoping that kind of functionality could be achieved.)
Skipping validation entirely on a canceled migration still seems to give a false impression.  Perhaps I'm missing something.

Hmm. It still seems like we should perform validation even after opting out of migration and the first check made during validation is that the version is a match. In this case, unlike initial load, no migration wizard is presented, but the pipeline is flagged as invalid and the rest of the validation is not performed. This would then display the pipeline to the user, allowing them to open notebooks, adjust properties, etc., but they must first go through the migration wizard before attempting to run. (Of course, I'm sure I'm over-simplifying things here, but I'm hoping that kind of functionality could be achieved.)
Skipping validation entirely on a canceled migration still seems to give a false impression. Perhaps I'm missing something.

When you cancel a migration, you cancel the opening of the pipeline, and except for the async aspects of the behavior, you shouldn't have a UI to see the errors.

Ok. I thought the pipeline editor would still be functional after a cancelled migration. Thanks.


Update stats command

Currently shows barely important information.

Improve uptime text to display days and hours clearly.
Include library and runtime versions

Updated the uptime text and added memory usage


CSS dashboard - lack of arrows for asc and desc sort

This is a : CSS enhancement

[ ] bug

[X] enhancement

[ ] feature-discussion (RFC)

BootstrapUI Version: 1.4.1..

Bootstrap Framework Version: 3.3.7

jQuery: LIBRARY VERSION

Platform and Target:  who cares in this case ? :P

What you did
For adding this functionnality
I added this code in MY OWN
vendor/friendsofcake/bootstrap-ui/webroot/css/dashboard.css.
/*
 * Global add-ons
 */
/* added default values found in style.css
.asc:after {content: " \2193";}
.desc:after {content: " \2191";}
*/
/* these ones are more funkies */
.asc:after { content: " \e155"; }
.desc:after { content: " \e156";}

This code solves the lack of BootStrapUI css and now display gently small icons beside sorted columns header
Expected Behavior
by default sorted column headers should be displayed with an icon beside.
The classes "asc" and "desc" should be displayed if necessary
Actual Behavior
sorted column headers are not automagically gently displayed
with a small icon (arrow, whatever, …)
Even if in the html code a class "asc" or "desc" is generated,
these class are not considered by BootstrapUI css file.
Before you open an issue, please check if a similar issue already exists or has been closed before.
P.S. Remember, an issue is not the place to ask questions. You can use Stack Overflow
for that or join the #cakephp channel on irc.freenode.net, where we will be more
than happy to help answer your questions.

A PR here would be awesome :)

A PR here would be awesome :)

don't know how to do that !
Will try later during free time
Any way thank you for this plugin , nice and clean.


docs(other): updates the caravan blog post link on the help page

PR Type

[ ] Bug fix
[ ] Feature
[ ] Code style update (whitespace, formatting, missing semicolons, etc.)
[ ] Refactor (i.e., no functional changes)
[ ] Build related changes
[ ] CI related changes
[x] Documentation changes
[ ] Other (please describe below):

Description

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Does this PR fixes open issues?

[ ] Yes
[x] No

LGTM, thanks!


add test case, #3375

Codecov Report

Merging #3380 into master will decrease coverage by 0.00%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #3380      +/-   ##
============================================
- Coverage     80.35%   80.34%   -0.01%
+ Complexity     7456     7454       -2
============================================
  Files           157      157
  Lines         27893    27893
  Branches       6724     6724
============================================
- Hits          22414    22412       -2
- Misses         3460     3461       +1
- Partials       2019     2020       +1

Impacted Files
Coverage Δ
Complexity Δ

...main/java/com/alibaba/fastjson/util/FieldInfo.java
85.95% <0.00%> (-0.67%)
97.00% <0.00%> (-1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c416be...6ce4b2a. Read the comment docs.


Nancy Self Host: Connection Control over the HttpListener

Prerequisites

[x] I have written a descriptive pull-request title
[x] I have verified that there are no overlapping pull-requests open
[x] I have verified that I am following the Nancy code style guidelines
[x] I have provided test coverage for my change (where applicable)

Description

NancyHost in its original implementation did not allow a way for consumers to have control over the number of connections. This PR aims to provide a slice of control to consumers to allow them to specify the number of accept connections that can be listened for at a given time.
This implementation has been adapted from https://github.com/JamesDunne/aardwolf/blob/master/Aardwolf/HttpAsyncHost.cs#L107 , which outlines a simple semaphore to control the total number of Hot Tasks listening for a request. To allow consumers to specify the number of connections to fit their environment, I added a property to the HostConfiguration.cs, and specify a default value for it (4) in the default constructor. I've used JMeter locally pointing at the Nancy Self Hosting demo with 150 threads. The performance on my machine is anecdotal and doesn't really matter, but in all this change does not appear to degrade existing functionality. In the context of my environment, throughput was around 2,000/s for the original version that was awaiting on this.Process and with the default MaximumConnectionCount of 4 was around 4,000/s. Again, anecdotal and nothing anyone should take to the bank, but I wanted to provide that as some form of comparison.
I originally jumped in to remove an await call on this.Process as it would cause only one request to be processed at a time, however while in here I thought I could add a little extra bit of functionality for consumers. This will let consumers of Nancy.SelfHosting to fine tune their connection accept loop to meet their needs, as opposed to just throwing out hot this.Process task calls indefinitely.
I'm certainly open to changing this up, and really not sure what a "good" default value would be for the MaximumConnectionCount, as most consumers would probably want to set this after performing their own analysis of their needs and their service's performance.
Let me know your feedback as this functionality may not be helpful (though I think it's a nice feature) for Nancy.SelfHost, but at the minimum we need to take the await off of the this.Process call or I think we'll only be processing  one request at a time when this package is released :)

Hi @davidallyoung, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla2.dotnetfoundation.org.

TTYL, DNFBOT;

@davidallyoung, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.
Thanks, DNFBOT;

Does it make sense to make the connection count a function of the processor count? Something like https://github.com/aspnet/KestrelHttpServer/blob/dev/src/Microsoft.AspNetCore.Server.Kestrel/KestrelServerOptions.cs#L86 ?

I think tying the connection count to logical processor count is a good idea. Is this something we would want to allow consumers to override/set themselves?

Sure, I think this is a perfectly reasonable setting to have for power users. The rest can probably get by fine with the defaults.

@khellang I've rebased and added a new commit for settingthe default MaximumConnectionCount to 1/2 of the logical core count, similar to how the KestrelServerOptions were implemented.

Any thoughts from anyone on this feature?

Left a couple of minor review comments
Also, should this be labeled a Breaking Change? @khellang
Shouldn't be needed, right?

Jeez, somehow I messed up this commit. I performed the rebase from master after pulling upstream, but it looks like the other commits from master are still included.  Let me know what steps I should take to clean this up.  Once you have that, you can do git reset --hard <insert the SHA here>. Be sure to be on your self-host-blocked branch when performing this.
We have posted some instructions on how to handle changes on upstream, these should help you avoid this in the future https://github.com/NancyFx/Nancy/blob/master/.github/CONTRIBUTING.md#handling-updates-from-upstreammaster :D

Thanks @thecodejunkie  , I'm used to to SVN/TFS so still making noob mistakes with git! I'll try this out this evening after work.

@davidallyoung 👍

@davidallyoung any luck? Do you need any more assistance?

@thecodejunkie sorry, I haven't had a chance yet, this week has been one of those..... lol

Great success, thanks for the reflog tip @thecodejunkie that is handy! I will achieve non-noob status with git, I have faith! I got turned around because I made the mistake of looking at the "sync" view in the VS github plugin instead of just pushing immediately after I had rebased from master.  I'm stating to think I would be better off not looking at that ever again lol.

Another side note, I'm making a todo item for myself to document how this works in the Wiki for Nancy Self Host once it merges.

PS, is it normal to need to git push -f after rebasing?

Yep, totally normal. You've basically ripped out your commits, added the new commits from upstream (NancyFx/Nancy) and then replayed your commits at the end, which means you've effectively rewritten history (feels powerful, doesn't it) :wink:

It feels powerful enough to horrify me! Thanks @khellang!

@khellang happy to pull this now? 👍 from me

I can't seem to figure out how to approve my review comments since they're no longer available after the rebase?! =)

Thanks a ton for this, @davidallyoung! :heart:

No problem, I hope to contribute more! Thanks!

Just dropping a comment here to note that documentation has been updated for this.


[BEAM-13399] Add extra time buffer to reduce likelihood of flake in expansion service test

Increase timeout from 2 seconds to 15 seconds for expansion service ping check. Should address flake.

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Choose reviewer(s) and mention them in a comment (R: @username).
[ ] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

R: @lostluck @youngoli


Very tiny typing mistake on user settings template

Hi, I have noticed a very tiny typing mistake on the settings template when I was translating it to pt-br.

VSCode Version: 1.23.0
OS Version: Windows 10 Home Single Language Build 1709

Steps to Reproduce:

Open VS Code
File > Preferences > Settings
On DEFAULT USER SETTINGS the "files.maxMemoryForLargeFilesMB" setting description says "Controls the memory available to VS Code after restart when trying to open large files. Same affect as specifying --max-memory=NEWSIZE on the command line" but I believe it should be "Same effect as...". Effect instead of Affect.

The sentence is located at https://github.com/Microsoft/vscode/blob/0b5ff1f4a9aea6798b319ef739e69fab30ee3456/src/vs/workbench/parts/files/electron-browser/files.contribution.ts#L289
Does this issue occur when all extensions are disabled?: Yes
Thanks.

@sbatten I'm happy that this config is now owned by you, not me.


update doc reference for setting up a service account

First commit to the repo. The error sends you to a dead page. I updated the reference. I signed a CLA.

Thank you!


[New Architecture] LayoutAnimation Breaking

Description
After migrating to new architecture, the animation configured with LayoutAnimation are behaving differently, we can observe a kind of jerk in the animation. Attached the videos and repo for reproduction of the issue.
Also check in slow motion with simulator, eventually the views are not adopting the slow animation and breaking.
React Native Version
0.72.3
Output of npx react-native info
System:
OS: macOS 13.4.1
CPU: (12) arm64 Apple M2 Pro
Memory: 312.44 MB / 32.00 GB
Shell:
version: "5.9"
path: /bin/zsh
Binaries:
Node:
version: 16.20.0
path: /usr/local/bin/node
Yarn:
version: 1.22.19
path: /opt/homebrew/bin/yarn
npm:
version: 8.19.4
path: /usr/local/bin/npm
Watchman:
version: 2<IP_ADDRESS>
path: /opt/homebrew/bin/watchman
Managers:
CocoaPods:
version: 1.12.1
path: /Users/ravindragupta/.rbenv/shims/pod
SDKs:
iOS SDK:
Platforms:
- DriverKit 22.4
- iOS 16.4
- macOS 13.3
- tvOS 16.4
- watchOS 9.4
Android SDK: Not Found
IDEs:
Android Studio: 2022.2 AI-222.4459.24.2221.10121639
Xcode:
version: 14.3.1/14E300c
path: /usr/bin/xcodebuild
Languages:
Java:
version: 11.0.19
path: /usr/bin/javac
Ruby:
version: 3.0.4
path: /Users/ravindragupta/.rbenv/shims/ruby
npmPackages:
"@react-native-community/cli": Not Found
react:
installed: 18.2.0
wanted: ^18.2.0
react-native:
installed: 0.72.3
wanted: 0.72.3
react-native-macos: Not Found
npmGlobalPackages:
"react-native": Not Found
Android:
hermesEnabled: false
newArchEnabled: true
iOS:
hermesEnabled: false
newArchEnabled: true
Steps to reproduce
Use LayoutAnimation with New Architecture (Fabric) and observe issues with animation.
Snack, code example, screenshot, or link to a repository
Reproducible Demo App: https://github.com/ravindraguptacapgemini/reproducer-react-native-maps-events/tree/layout-animation-issue
Videos and Screenshot:
https://github.com/facebook/react-native/assets/97147467/d9e66cc5-0fd5-4881-91d9-dd9b684aba97
https://github.com/facebook/react-native/assets/97147467/b5b752b5-7d02-412d-a61d-7a8a82e6dbd2

@ravindraguptacapgemini thanks for the reproducer. Could you re-upload the New Architecture video as it's not loading at the moment?

@cortinico PFA for new architecture video:
https://github.com/facebook/react-native/assets/97147467/de528acb-dd69-4fe0-8130-1e88e60335ea

@cortinico Just checking if you got a chance to check for the issue. Thanks

+1

@cortinico , with fabric enabled LayoutAnimation is not working android . When I logout from home page and navigate to login , Its showing faded login screen .

This looks like a bug with LayoutAnimation on Fabric. We're happy to receive a PR or collaborate on a fix if someone is up for it.

@sammy-SC can you please build for Rosetta, may be some issue with Xcode build settings.

@sammy-SC Also the animations do no adopt to the simulator setting 'Debug -> Slow Animations'.

from the video it looks like the animation is not working at all and it only shows first and last frame.
Debug -> Slow Animation unfortunately won't work out of the box. The trouble is, the animation is not driven by CoreAnimation framework on iOS. The New Architecture has a cross-platform implementation and does not use animation primitives that host platforms offer.

I have tried the Rosetta option but I got the build failure I mentioned above. It looks like the compiler can't see some symbols.

@sammy-SC  checking for the issue.

@sammy-SC  There was some issue with architecture, just pushed the fix. You can check it now.

@sammy-SC were you able to check it?

Hello @ravindraguptacapgemini,
we are tracking this and incorporating resolving this into our planning.

I've created a minimal reproducer for this one https://github.com/coado/react-native-layout-animation-fabric-issue. The animation is not working on both iOS and android on the new architecture. The animation stops working when the useNativeDriver is set to false on fadeIn and fadeOut animations on iOS. On android it seems like it doesn't work in both cases.

The problem here is with mixing JS and native side animations and the view flattening on top of that. When there is an animation defined on JS side (like the one in the reproducer with useNativeDriver set to false) it sends properties updates to cpp which causes creation of update mutations for the corresponding animated view. In the provided repro there is also a LayoutAnimation configured to run on the next layout alongside the JS animation. It's registered as the inflightAnimation right before the first mutation update from the JS animation. So, when the update finally occurs, the algorithm will check for the potential conflict in the current layout animation with the mutation update in getAndEraseConflictingAnimations. One of the requirements for the conflict to happen is that the animated node (from the layout animation) is mutated directly. Even though in the above repro JS animations are updating background of the Animated.View and the layout animation update the bottom margin of its parent, the layout and JS animations are targeted at the same node, because of the view flattening, which causes those conflicts.
The solution to this problem is quite simple as we can set collapsable: false on the parent of the Animated.View to prevent the view flattening. In some cases the issue may not be registered at first, because some styles like: opacity, shadows or transforms prevent view flattening which sort of solves the problem, but changing these styles dynamically may reintroduce it.

I just discovered the same problem. It seems that the delete animation is not working anymore in the latests versions (75 and 74). Here is a expo-snack where you can see the problem. Create and delete of the items should animate in the same way but the animation is only there when items are added. When item is removed the item disappears immediately instead of fading out.
I tested the same code example in an old project with react-native 0.68 and there the animation of deleted items works pretty well. Is this issue known and are there any plans to fix this?

I just discovered the same problem. It seems that the delete animation is not working anymore in the latests versions (75 and 74). Here is a expo-snack where you can see the problem. Create and delete of the items should animate in the same way but the animation is only there when items are added. When item is removed the item disappears immediately instead of fading out.
I tested the same code example in an old project with react-native 0.68 and there the animation of deleted items works pretty well. Is this issue known and are there any plans to fix this?

It can be solved similarly to the above issue by setting collapsable={false} on the item component. Most of these types of issues occur, because of some conflict with the view flattening. The good thing is that they are relatively easy to solve, but sometimes it's hard to notice that flattening is the cause of the problem.

Can't seem to repro your minimal producer on Android @coado . Layout Animations do not run.

@coado I forget to mention that my snack it is not working on IOS. On android the example works fine. collapsable prop is only available for android and does not help in my case.

Can't seem to repro your minimal producer on Android @coado . Layout Animations do not run.

Hey, I've added the repro on iOS for now just to show the potential problem. I might add it on android as well 😅

@coado I forget to mention that my snack it is not working on IOS. On android the example works fine. collapsable prop is only available for android and does not help in my case.

Hey, collapsable can be set on both android and iOS on the new architecture. If it doesn't work, then there has to be problem with something else 🤔


Let users configure default Treasure Data API endpoint

This change let users configure default td.endpoint of all td-related
operators using system config. This is helpful especially for system
integrators who provides a digdag server for customers with a
pre-configured td.endpoint.
It doesn't use JVM system property because system property affects globally. It may impact badly when we want to support remote agents. On the other hand, with system config, remote agents will be able to get the config from the central server when it starts. This approach guarantees that all remote agents use consistent configuration.
There are some inconsistency around the word "endpoint" because some configuration assumes that "endpoint" contains "http" or "https", but td.endpoint doesn't. But it's ignored for now.

LGTM 👍
I left a minor comment, though


[RAY ODH] KR2: Ray in ODH

Kustomize overlays: these will be adapted from the prototype Ray+ODH integration that is currently deployed on the OPF Smaug cluster. This will take the form of one or more pull-requests against the ODH project. Success upon merging.
Acceptance Criteria:

[ ] This issue is done when the PR to integrate Ray as default option for ODH is merged

Started working on my own fork of odh-manifests and created a new feature branch from the PR above. I will use my fork's branch to keep track of my work on this issue. This branch also represents the deployment used for Ray on our teams DS cluster.

ray-workflows do not work in "client mode", that is on a cluster, at the moment. Here is the issue where the ray project is working on making this  feature available. https://github.com/ray-project/ray/pull/24789
Will skip this Ray feature for now.


[Question] SQL injection potential flaw?

Just want to ask, does anyone check is BulkInsert protected from SQL injections? I see that there are raw strings that we send to DB. Am I right that it is important to validate all the data to prevent security issues using that package?

Hi!
The raw strings are to write the placeholders (?) which is used to avoid SQL injection.  No value is ever written as raw SQL in this library but are passed as values to Exec. Also included in the raw string is the column names but they're passed via Quote. The column names are from your structs so they're not really affected by this, but if you named your columns to 105; DROP TABLE users it would still work.
I can't swear that gorm isn't vulnerable to injections but I think it's looks fine. It's more than five years old with nearly 20k stars so someone should've noticed that by now.


Add C++/WinRT when_any async helper

Complements #516 by adding a when_any helper function that creates an IAsyncAction object that will complete when any of the supplied awaitable objects have completed. The resulting async object can then either be waited upon using co_await when_any(...) or when_any(...).get().
 As I mentioned in #341, WinRT only allows waiting once. That means that any objects that may not yet have completed may not be waited on again in any way.
Here's an example:
using namespace std::literals;
using namespace winrt;
using namespace Windows::Foundation;

IAsyncAction wait_for(TimeSpan timeout)
{
    co_await timeout;
    printf("wait_for %lld\n", timeout.count());
}

int main()
{
    init_apartment();

    when_all(wait_for(3s), wait_for(2s), wait_for(1s)).get();
    puts("> when_all");

    puts("");

    when_any(wait_for(3s), wait_for(2s), wait_for(1s)).get();
    puts("> when_any");

    getchar();
}

And this program produces the following output:
wait_for 10000000
wait_for 20000000
wait_for 30000000
> when_all

wait_for 10000000
> when_any
wait_for 20000000
wait_for 30000000

Working on an improved version that returns the "winning" result.


the actual unique key is msg_id

Thank you!  The icon was meant to indicate a foreign key, but I can see that it's confusing and overloaded.  I'm going to remove it!


[Relay][Training] Add and fix gradients

Added the following gradient:

nn.global_avg_pool2d

Fixed the following gradients:

max
sum

New regression tests were added as well.
Many thanks to @Checkmate50 @dfujiki @xiaoweiw for contributing to this PR at the ADA TVM hackathon!

cc @MarisaKirisame


customLaunch to load an FXGL Application into an FX scene  doesn't work anymore

I tried to solve this cunstomLaunch but the feature doesn't exists animore

@benjimusmaximus please see the full sample using the latest version


Throw warning for using monitor in trainer

In the init method for monitor checkpoint, we should throw a warning for calling monitor key inside the trainer.

@teddykoker mind tackling this one? should be simple

@edenafek can you elaborate on this one? Not sure what you mean here ...

https://github.com/PyTorchLightning/pytorch-lightning/blob/7b64472ced732c6762978f2a3a844f6ef5261157/pytorch_lightning/callbacks/model_checkpoint.py#L310

https://github.com/PyTorchLightning/pytorch-lightning/blob/7b64472ced732c6762978f2a3a844f6ef5261157/pytorch_lightning/callbacks/model_checkpoint.py#L310

heh, I dont like this m="""...""" formatting :D


Improve the CSS

@Sujal-2820 I would like to change the CSS of this web page like changing the background., removing the background of the heading, etc.
Please assign me this issue under Hacktoberfest.

Sure @saurav2208, you can work on this issue


Use str_starts_with and str_contains where possible

Error: src/Generator/ValueGenerator.php:315:46: MixedArgument: Argument 2 of str_contains cannot be mixed, expecting string (see https://psalm.dev/030)

Unsure if it should go to baseline or not.


Frequently asked questions

Provider with builder is deprecated as told in documentation:
Provider<MyDatabase>(       builder: (context) => MyDatabase(),       child: MyFlutterApp(),       dispose: (context, db) => db.close(),    )
Better would be:
Provider<MyDatabase>(     create: (BuildContext context) => MyDatabase(),     child: MyApp(),     dispose: (context, db) => db.close(),   )

Thanks! I've fixed this on develop, so it will eventually go live with the next moor version.