ndt matching refactoring in head

Hi
I refreshed latest autoware stack and was running ndt matching on my test car  which was working perfectly as of commit April 15, 2016 [sha1: 08ad56ef0b6d59f4769912b35591493fecf76db8]. This was before the refactoring to  separate out voxel grid filter as it's own node. In  the previous version, ndt matching was consuming /points_raw and applying the voxel grid filter in the callback. With the latest code as of June 17, the car is not computing pose correctly. It works fine in simulation .
I think there is delay introduced because  now 2 nodes have to establish a  communication channel. Are there any other gotchas that others have encountered with this refactoring that could  be responsible for the observed behavior?

Hi @nsakar
After the refactoring to separate out voxel grid filter, ndt matching is computing correctly in our environment.
I think ndt matching was not publishing pose because matching score is small, or mistake the operation.
If you wanna improve accuracy, please try to reduce voxel size in sensing tab (but a execution time increases).
If there is a operation video, I may give more advice...

I think there is delay introduced because now 2 nodes have to establish a communication channel. Are there any other gotchas that others have encountered with this refactoring that could be responsible for the observed behavior?

It is true that there is delay, but I guess delay is less than 1 msec because communication data size is small and it communicate in localhost.

yes filter node is checked

Yes. I am already doing that. My functional code was as of April 16 commit where this change was baked in.
Regards
Nandini
From: Yuki Kitsukawa<EMAIL_ADDRESS>Sent: Monday, June 20, 2016 12:18 AM
To: CPFL/Autoware<EMAIL_ADDRESS>Cc: Sarkar, Nandini<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [CPFL/Autoware] ndt matching refactoring in head (#361)
@nsakarhttps://github.com/nsakar
In recent specification change, ndt_matching doesn't publish /current_pose. ndt_matching publish /ndt_pose. Please run vel_pose_mux node in computing tab before runnning ndt_matching. vel_pose_mux subscribes /ndt_pose and publishes /current_pose.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/CPFL/Autoware/issues/361#issuecomment-227066944, or mute the threadhttps://github.com/notifications/unsubscribe/AQcgG-8ojJOzvKNz1MBYvl5PP6m7J1Rzks5qNj6egaJpZM4I4_p6.

@nsakar
What is the voxel size of voxel_grid_filter in sensing tab?
If possible, can you provide the operation video of the screen? I will investigate.

1.01
From: Yuki Kitsukawa<EMAIL_ADDRESS>Sent: Monday, June 20, 2016 7:39 AM
To: CPFL/Autoware<EMAIL_ADDRESS>Cc: Sarkar, Nandini<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [CPFL/Autoware] ndt matching refactoring in head (#361)
@nsakarhttps://github.com/nsakar
What is the voxel size of voxel_grid_filter in sensing tab?
If possible, can you provide the operation video of the screen? I will investigate.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/CPFL/Autoware/issues/361#issuecomment-227161622, or mute the threadhttps://github.com/notifications/unsubscribe/AQcgG0a3BLH9_josj-EmNRaSon1MzmnWks5qNqYTgaJpZM4I4_p6.

After reverting the ndt_matching code to the apr 16 commit, my car drives correctly. I am wondering what changed between the calculations.
4.	Key observations
a.	After reapplying previous edits, it was found that the latest code works fine in simulation
b.	When attempt was made to run code on physical car, there were significant issues found in ndt_matching.
c.	Main refactoring done on ndt_matching included
i.	  Separation of concerns and application of single responsibility principle

Translates to 1 node was split into two which in turn added yet another IPC into the mix

d.	Experiments run on physical car:
i.	Latest code with voxel grid filter leaf size configured correctly [ 1.01]

Works fine for part of the trajectory. Fails at portions where rapid changes in angular pose encountered

ii.	Latest code with voxel grid merged in [ aka one node eliminating IPC]

Same result as above

iii.	Latest code with NDT matching overlaid with original functional code [ Apr 16 commit]

Works correctly

@nsakar
I see your situation. ICP is a different algorithm of scan matching and completely independent of NDT.
We always set the voxel size 2.0 so can you try again using this configuration?
By the way, was the map data made by ndt_mapping?
What kind of place are you conducting experiments?
If the map and real conditions are different to some extent due to the traffic or many parking cars, there is possibility that ndt_matching fails localization.

It was not working at all with voxel size 2.0. So I changed it to 1.01 as before. I am using the ndt_matching node and not the icp node.
Also the map was generated using ndt mapping.
I am testing on simulation environment where it works fine and also on physical car where I have issues.
Regards
Nandini
From: Yuki Kitsukawa<EMAIL_ADDRESS>Sent: Monday, June 20, 2016 5:49 PM
To: CPFL/Autoware<EMAIL_ADDRESS>Cc: Sarkar, Nandini<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [CPFL/Autoware] ndt matching refactoring in head (#361)
@nsakarhttps://github.com/nsakar
I see your situation. ICP is a different algorithm of scan matching and completely independent of NDT.
We always set the voxel size 2.0 so can you try again using this configuration?
By the way, was the map data made by ndt_mapping?
What kind of place are you conducting experiments?
If the map and real conditions are different to some extent due to the traffic or many parking cars, there is possibility that ndt_matching fails localization.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/CPFL/Autoware/issues/361#issuecomment-227311579, or mute the threadhttps://github.com/notifications/unsubscribe/AQcgGz8zrtkHP4mnlpz3HZuHMSgCNqZTks5qNzUAgaJpZM4I4_p6.

Can you check the computation time of scan matching? The computation time is published in /time_ndt_matching topic. If the computation is not finished in measurement interval of LiDAR (Velodyne: 100ms), there is possibility that ndt_matching fails localization.

The computation time is higher and does exceed 100 ms at points in trajectory where the car demonstrates weird behavior. It appears the new code has made the algorithm very sensitive. If you can throw some light on the possible causes it would be very helpful.

What LIDAR are you using?

velodyne
From: Yuki Kitsukawa<EMAIL_ADDRESS>Sent: Saturday, June 25, 2016 2:31 AM
To: CPFL/Autoware<EMAIL_ADDRESS>Cc: Sarkar, Nandini<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [CPFL/Autoware] ndt matching refactoring in head (#361)
What LIDAR are you using?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/CPFL/Autoware/issues/361#issuecomment-228526292, or mute the threadhttps://github.com/notifications/unsubscribe/AQcgG2kIC8I5pga8f7H3GiylBF3pMkV8ks5qPPVngaJpZM4I4_p6.

Which model? HDL-64e, HDL-32e, VLP-16...?

Vlp 16
From: Yuki Kitsukawa<EMAIL_ADDRESS>Sent: Saturday, June 25, 2016 2:35 AM
To: CPFL/Autoware<EMAIL_ADDRESS>Cc: Sarkar, Nandini<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [CPFL/Autoware] ndt matching refactoring in head (#361)
Which model? HDL-64e, HDL-32e, VLP-16...?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/CPFL/Autoware/issues/361#issuecomment-228526404, or mute the threadhttps://github.com/notifications/unsubscribe/AQcgG_CusRz69nb9lVD4GfwFM_OJNvW5ks5qPPYtgaJpZM4I4_p6.

Do you mount VLP-16 on on the roof of the vehicle? Is there enough height from the roof? If lower beams of VLP-16 hit the vehicle, there are not enough points for matching.

It is working fine with apr 16 ndt_matching code
From: Yuki Kitsukawa<EMAIL_ADDRESS>Sent: Saturday, June 25, 2016 2:45 AM
To: CPFL/Autoware<EMAIL_ADDRESS>Cc: Sarkar, Nandini<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [CPFL/Autoware] ndt matching refactoring in head (#361)
Do you mount VLP-16 on on the roof of the vehicle? Is there enough height from the roof? If lower beams of VLP-16 hit the vehicle, there are not enough points for matching.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/CPFL/Autoware/issues/361#issuecomment-228526975, or mute the threadhttps://github.com/notifications/unsubscribe/AQcgG_4tC8sjtMWtwlqLN2izrLp2iOdEks5qPPiQgaJpZM4I4_p6.

I didn't modify the matching algorithm itself. I confirmed the new code works in the same way as before both in simulation and in field operation. So I can't investigate without your rosbag or operation video of the screen.

Did you use offset = linear, zero or quadratic in field?
From: Yuki Kitsukawa<EMAIL_ADDRESS>Sent: Saturday, June 25, 2016 3:03 AM
To: CPFL/Autoware<EMAIL_ADDRESS>Cc: Sarkar, Nandini<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [CPFL/Autoware] ndt matching refactoring in head (#361)
I didn't modify the matching algorithm itself. I confirmed the new code works in the same way as before both in simulation and in field operation. So I can't investigate without your rosbag or operation video of the screen.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/CPFL/Autoware/issues/361#issuecomment-228528349, or mute the threadhttps://github.com/notifications/unsubscribe/AQcgGyQRj5BzBY2gxk3uXu3sCUy19Ywyks5qPPzsgaJpZM4I4_p6.

"linear" works the best. We always use "linear" both in simulation and field.

OK Thanks.
From: Yuki Kitsukawa<EMAIL_ADDRESS>Sent: Saturday, June 25, 2016 3:08 AM
To: CPFL/Autoware<EMAIL_ADDRESS>Cc: Sarkar, Nandini<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [CPFL/Autoware] ndt matching refactoring in head (#361)
"linear" works the best. We always use "linear" both in simulation and field.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/CPFL/Autoware/issues/361#issuecomment-228528678, or mute the threadhttps://github.com/notifications/unsubscribe/AQcgGyklwTc-Px4V3aD7KJI6Q97UM220ks5qPP4TgaJpZM4I4_p6.

I update the code and met the same question with you. @nsakar
Could you tell me which ndt_matching code are you using now?
Before  apr 16 or after  apr 16?
Thanks.

Hello all,
I am currently using autoware. First of all, I would like to thank you for your spectacular work. I want use ndt macthing with my rosbag file which composes only velodyne point and imu data. I filtered tf topics out from it. However whenever I launch the ndt matching with the rosbag file my car starts to spin around map. I provide transfer from base_link to Velodyne and as I understood ndt matching provide transfer from map to base_link but apperently I am missing something. Could you give some hint about how ndt macthing works?

@kerimyener How do you made the map, ndt_mapping? Did you indicate the initial position when starting ndt_matching?

@kitsukawa yes sir.  I used ndt mapping to create the map. Actually I followed these steps:
1-download kittidata (odometry data set)
2-used kitti2bag to converts data to bagfile(i changed velodyne frame id from velo_link to velodyne)
3-filter the dynamic transformation(world to base_link) out
4-create map by using ndt mapping
5-for localization in autoware
---without gnss
1-play rosbag and stop(use sim time true)
2-choose localizer(velodyne)
3-set tf between base_link and velodyne
4-upload pcd file
5-set tf between world to map(world map 0 0 0 0 0 0 )
6-choose voxel filter
7-choose ndt matching(choose initial pose ) you could see result in attachment

with gnss
5-set set tf between world to map(according to first msg of fix2pose(i added plane in geo_pos_conv.cpp) i set x y z r y p)
6-choose voxel filter
7-choose ndt matching
but either way i couldnt manage to overlap map and scan.
Thank you for your time

@kerimyener First, the map you are using is dense, so can you downsample PCDs using PCD filter in Map tab and load them instead of raw PCDs? I think that 0.2 for voxel size will work. Do you use same rosbag for localization using ndt_matching as mapping using ndt_mapping?

@kitsukawa Thank you for the information. It was the problem map was too dense. Now i can run the ndt matching properly

@kerimyener Glad to hear that.


Data types need an unambiguous indication of their associated type library.

Is your feature request related to a problem? Please describe.
I know that you're looking at ways to improve data type management. This is just one example of where it needs work.
If two or more data type archives have the same name, and have the same types defined in each, there's no way [that I know of] to determine to which of them a program's data type  belongs.
The following image shows such a difficult situation.

(In this case, one of the archives "can't be located", which complicates things even more.)
Suppose I try to create a new typedef. In the Create TypeDef window, if I pull down the Archive menu, there's no way to distinguish between the identically named libraries.

Another difficult case:

There's no way to tell which xc16 types is meant.
Describe the solution you'd like
I don't know that this would be a good solution, but perhaps whenever the name of a library is shown (as in the immediately preceding example) there could be some indicator as to whether it's a project archive or a file archive. That would be a start.

Referring back to what I said above:

(In this case, one of the archives "can't be located", which complicates things even more.)
When this happens--i.e., the icon to the left of the data type archive's name is a red diagonal slash--it can be difficult to untangle exactly which archive can't be opened, let alone the reason it can't, and then to rectify.


fix: disable auto block pr option of contributor-assistant/github-action

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

[ ] N
[x] Y

2. What is the scope of this PR (e.g. component or file name):

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

[ ] Affects user behaviors
[ ] Contains syntax changes
[ ] Contains variable changes
[ ] Contains experimental features
[ ] Performance regression: Consumes more CPU
[ ] Performance regression: Consumes more Memory
[ ] Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

[ ] N
[ ] Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

[ ] Unit test
[ ] Integration test
[ ] Benchmark (add benchmark stats below)
[ ] Manual test (add detailed scripts or steps below)
[ ] Other

Thank you for the contribution. Pls sign the CLA.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 66.189%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
2077

Relevant Lines:
3138

💛  - Coveralls

I have read the CLA Document and I hereby sign the CLA

recheck


Req: megafooty.com

Sorry for last request :(
https://megafooty.com/ please

I assume you are using some kind of Ad-Block. Turn it off and it will look like this.


test: packet forward middleware

Overview

Closing this b/c we decided in a sync to pursue a unit test instead of interchain tests.


Run line by line: movement of button is jarring

Testing #129467
I was expecting the run line by line button to stay in the same location the entire time so that I could quickly click through the cell without needing to move my cursor. Needing to move my cursor depending upon the timing/point in the journey felt unexpected.

Does the button have to move all the way to the left once it starts running?

Would be nicer if it started left of the run buttons


Andriod NDK changes on Windows

Describe the bug
The last Windows VM update seems to have caused some changes with the Android NDK location.  At the very least, the reported location which now contains spaces causes some problems.  Resolving the spacing issue results in libc++.a not being found.
Area for Triage:
Android
Question, Bug, or Feature?:
Bug, Question
Virtual environments affected

[ ] macOS 10.15
[ ] Ubuntu 16.04 LTS
[ ] Ubuntu 18.04 LTS
[ ] Ubuntu 20.04 LTS
[ ] Windows Server 2016 R2
[X] Windows Server 2019

Expected behavior
The NDK to be available at C:\ProgramData\Microsoft\AndroidNDK
Actual behavior
Using CMake to build an android executable with C++ statically linked fails.
Logs from an example run:
https://compnerd.visualstudio.com/swift-build/_build/results?buildId=33358&view=logs&jobId=f5e548e7-ba00-50d3-35db-b84d11db5ff1&j=f5e548e7-ba00-50d3-35db-b84d11db5ff1&t=4afff71e-00bf-5277-1a62-1ac69533f0db

Hello @compnerd,
Yes, you are correct, ANDROID_NDK_HOME variable has been changed in scope of pull request.
The current path is: "C:\Program Files (x86)\Android\android-sdk\ndk-bundle"
In order to properly reference this path in pipelines, you can use environment variables:
ANDROID_NDK_PATH
ANDROID_NDK_HOME

Please note that Visual Studio NDK was not removed and still available in agent machines.

Hello @Darleev,
Thanks for the info, this should help me restore the builds at least temporarily.  I can get through the space issues, though, I seem to be missing libc++.a.  This was previously at ${ANDROID_NDK_HOME}/sources/cxx-stl/llvm-libc++/libs/armeabi-v7a/libc++.a.  I'll check if this is related to the NDK itself or something else.

@compnerd
Previously, Visual Studio NDK was used as a default one on Windows images.
Recently, we have switched it to the official one provided by android tool manager in scope of #913.
It was a deliberate change that was done for two reasons:

Visual Studio NDK is very outdated and won't be updated in the future. On our images, we would like to provide the latest ndk that will be updated in future
We would like to be consistent with other images because Ubuntu and macOS images use official android ndk from android tool manager
Unfortunately, we didn't expect that it could be a breaking change for someone.
Also, I checked the lib you have mentioned, and currently it is placed in the following path:

${ANDROID_NDK_HOME}/sources/cxx-stl/llvm-libc++/libs/armeabi-v7a/libc++.a.16
${ANDROID_NDK_HOME}/sources/cxx-stl/llvm-libc++/libs/armeabi-v7a/libc++.a.17
….

If additional information or assistance is required, feel free to contact us.

@compnerd I'm going to close the issue.
Feel free to contact us in case of any questions, we will be glad to assist you further.

@Darleev - that sounds good, thanks for the information.  One quick thing - is there a good way to raise questions other than an issue?

@compnerd I think the most correct option in case of any questions is to ask them as an issue, do not hesitate to contact us, we are always happy to help.


Sm101 create message Test Coverage

Improves unit test coverage in the message views
Small fixes and refactors

Codecov Report

Merging #59 into master will increase coverage by 3.6%.
The diff coverage is 100%.

@@            Coverage Diff            @@
##           master      #59     +/-   ##
=========================================
+ Coverage   95.86%   99.46%   +3.6%
=========================================
  Files          24       24
  Lines         556      562      +6
=========================================
+ Hits          533      559     +26
+ Misses         23        3     -20

Impacted Files
Coverage Δ

...e_operations_ui/controllers/message_controllers.py
100% <100%> (+5.12%)
:arrow_up:

response_operations_ui/views/messages.py
100% <100%> (+27.69%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2605bea...366bfc6. Read the comment docs.


How to use my own CommentModel?

I have an own CommentModel in App\Models\Comment.
How should I tell the package to use my Model instead of yours?
Right now im overriding the Traits. Buts thats ... you know

You can see the answer on readme under

If you want to have your own Comment Model create a new one and extend my Comment model.

I´ve extended your Model
<?php

namespace App\Models;

use Spatie\MediaLibrary\HasMedia\HasMediaTrait;
use Spatie\MediaLibrary\HasMedia\Interfaces\HasMediaConversions;

class Comment extends \Actuallymab\LaravelComment\Models\Comment implements HasMediaConversions
{
    use HasMediaTrait;

    /**
     * The accessors to append to the model's array form.
     *
     * @var array
     */
    protected $appends = ['images', 'commentator'];

    /**
     * Register the conversions that should be performed.
     *
     * @return void
     */
    public function registerMediaConversions()
    {
        $this->addMediaConversion('thumb')
            ->width(368)
            ->height(232)
            ->sharpen(10)
            ->optimize();
    }

    public function addImage($pathToImage){
        $this->addMedia($pathToImage)->toMediaCollection();
    }

    /**
     * Get all Images
     * @return array
     */
    public function getImagesAttribute()
    {
        $imgs = $this->getMedia();
        $publicUrls = [];
        foreach ($imgs as $img){
            $publicUrls[]  = $img->getUrl();
        }

        return $publicUrls;
    }

    public function getCommentatorAttribute(){
        return ($this->commented_type)::select("id", "firstname", "name")->find($this->commented_id);
    }
}

But the Traits still uses yours. I think it should be in a config file, wich Model it should use.


Update Subscription modal translations

Update Subscription modal translations on the pages that they were missing.
Update punctuation on validation.json.

@sashko9807 I agree. Thanks for the review. I will close this PR and create a new one.


own lrucache?

attic has its own attic.lrucache implementation of a least-recently-used cache.
Python (since 3.2) has something quite similar in stdlib:
https://docs.python.org/3/library/functools.html#functools.lru_cache
So I was wondering if there are special reasons to have attic.lrucache and not just use the stdlib stuff.

the stdlib lrucache is just a function decorator and does not support enumeration of cache contents (and attic needs that).


windows_package fails due to version property as String when package is installed

Description
Follow up on #9770
Due to the enforcement of single version package and the way load_current_resource is done, populating the version property fails when a package is already installed.
The current resource version property is done here https://github.com/chef/chef/blob/7235856d859bbb32482b3f3b12f758b63a0eb8eb/lib/chef/provider/package/windows.rb#L65-L66
With the version property being defined as String since this MR
Both msi and exe provider used in package_provider.installed_version can ends up returning an array with map(..).uniq:

https://github.com/chef/chef/blob/7235856d859bbb32482b3f3b12f758b63a0eb8eb/lib/chef/provider/package/windows/exe.rb#L93-L98:

https://github.com/chef/chef/blob/7235856d859bbb32482b3f3b12f758b63a0eb8eb/lib/chef/provider/package/windows/msi.rb#L48-L59

Chef Version
16.0.275
Platform Version
Non relevant
Replication Case
Converge twice with a windows_package resource, the second run will fail.
Client Output
================================================================================
    Error executing action `install` on resource 'windows_package[Microsoft Visual C++ 2013 Redistributable (x64) - 12.0.40660]'
    ================================================================================
    Chef::Exceptions::ValidationFailed
    ----------------------------------
    Property version must be one of: String!  You passed ["12.0.40660.0"].
    Resource Declaration:
    ---------------------
    # In c:/chef/local-mode-cache/cache/cookbooks/vcruntime/recipes/vc12.rb
     24:     windows_package node['vcruntime']['vc12']['x64'][node['vcruntime']['vc12']['version']]['name'] do
     25:       checksum node['vcruntime']['vc12']['x64'][node['vcruntime']['vc12']['version']]['sha256sum']
     26:       source node['vcruntime']['vc12']['x64'][node['vcruntime']['vc12']['version']]['url']
     27:       installer_type :custom
     28:       returns [0, 3010]
     29:       options '/q'
     30:     end
     31:     windows_package node['vcruntime']['vc12']['x86'][node['vcruntime']['vc12']['version']]['name'] do
    Compiled Resource:
    ------------------
    # Declared in c:/chef/local-mode-cache/cache/cookbooks/vcruntime/recipes/vc12.rb:24:in `from_file'
    windows_package("Microsoft Visual C++ 2013 Redistributable (x64) - 12.0.40660") do
      package_name "Microsoft Visual C++ 2013 Redistributable (x64) - 12.0.40660"
      action [:install]
      default_guard_interpreter :default
      declared_type :windows_package
      cookbook_name "vcruntime"
      recipe_name "vc12"
      source "https://download.microsoft.com/download/0/5/6/056DCDA9-D667-4E27-8001-8A0C6971D6B1/vcredist_x64.exe"
      installer_type :custom
      options "/q"
      checksum "20e2645b7cd5873b1fa3462b99a665ac8d6e14aae83ded9d875fea35ffdd7d7e"
      returns [0, 3010]
    end

Stacktrace
N/A

Hi,
I got exactly the same error today and  came to raise the same issue.
`
Recipe: win-lbntools::default
* windows_package[WinAgents EventLog Translation Service] action remove
       ================================================================================
       Error executing action `remove` on resource 'windows_package[WinAgents EventLog Translation Service]'
       ================================================================================

       Chef::Exceptions::ValidationFailed
       ----------------------------------
       Property version must be one of: String!  You passed ["1.5"].

       Resource Declaration:
       ---------------------
       # In C:/Users/vagrant/AppData/Local/Temp/kitchen/cache/cookbooks/win-lbntools/recipes/default.rb

        37:     package node['winagent']['program_name'] do
        38:       installer_type  :custom
        39:       #source          node['winagent']['repo_url']
        40:       action          :remove
        41:       version         'abc'
        42:       options         ' /quiet /passive /norestart'
        43:       only_if         { node['winagent']['uninstall'] }
        44:     end
        45:   end

       Compiled Resource:
       ------------------
       # Declared in C:/Users/vagrant/AppData/Local/Temp/kitchen/cache/cookbooks/win-lbntools/recipes/default.rb:37:in `from_file'

       windows_package("WinAgents EventLog Translation Service") do
         package_name "WinAgents EventLog Translation Service"
         action [:remove]
         default_guard_interpreter :default
         declared_type :package
         cookbook_name "win-lbntools"
         recipe_name "default"
         version "abc"
         options " /quiet /passive /norestart"
         installer_type :custom
         only_if { #code block }
       end

       System Info:
       ------------
       chef_version=16.0.275
       platform=windows
       platform_version=10.0.14393
       ruby=ruby 2.7.1p83 (2020-03-31 revision a0c7c23c9c) [x64-mingw32]
       program_name=C:/opscode/chef/bin/chef-client
       executable=C:/opscode/chef/bin/chef-client

   Running handlers:
   [2020-05-06T12:42:03+00:00] ERROR: Running exception handlers
   Running handlers complete
   [2020-05-06T12:42:03+00:00] ERROR: Exception handlers complete
   Chef Infra Client failed. 0 resources updated in 19 seconds
   [2020-05-06T12:42:03+00:00] FATAL: Stacktrace dumped to C:/Users/vagrant/AppData/Local/Temp/kitchen/cache/chef-stacktrace.out
   [2020-05-06T12:42:03+00:00] FATAL: Please provide the contents of the stacktrace.out file if you file a bug report
   [2020-05-06T12:42:03+00:00] FATAL: Chef::Exceptions::ValidationFailed: windows_package[WinAgents EventLog Translation Service] (win-lbntools::default line 37) had an error: Chef::Exceptions::ValidationFailed: Property version must be one of: String!  You passed ["1.5"].

`
And also it ignore the property version of the resource windows_package
`
            37:     package node['winagent']['program_name'] do
            38:       installer_type  :custom
            39:       #source          node['winagent']['repo_url']
            40:       action          :remove
            **41:       version         'abc'**
            42:       options         ' /quiet /passive /norestart'
            43:       only_if         { node['winagent']['uninstall'] }
            44:     end
            45:   end
`

The same code work well with version 14 and 15

Fixed in current. Release incoming. Thanks for the report @Tensibai

Hey @tas50 do we know a date when we can expect the release by any chance? Sorry, we are kind of dead in the water on this resource until the fixes get released :)


How to use specific timecode?

I'd like to extract an image from a specific moment in the video. Possible?

Hi @GeoffreyPlitt currently, I only get the first frame as thumbnail. But your idea is interesting, I will add more options to get at a specific moment.

Hi, @phuochau
I got the thumbnail on Android version perfectly, but I cannot get it on iOS version at all.
The width and height are 0, so the image is not opened.
What was wrong?

@GeoffreyPlitt Did you figure out a way of getting the thumbnail from a specific timestamp in the video?

Yes, we switched to https://github.com/shahen94/react-native-video-processing


chore(owners): remove OWNERS files from orchestrator plugins

Confirmed with the @janus-idp/orchestrator team that they would prefer to use CODEOWNERS over OWNERS.  Deleting OWNERS to avoid dup assignments
Update CODEOWNERS to add the missing /plugins/orchestrator-swf-editor-envelope plugin

/lgtm
/approve


Omnisharp unable to load a relative reference in .net core project

Environment data
dotnet --info output:
.NET Command Line Tools (2.0.2)
Product Information:
Version:            2.0.2
Commit SHA-1 hash:  a04b4bf512
Runtime Environment:
OS Name:     Windows
OS Version:  10.0.16299
OS Platform: Windows
RID:         win10-x64
Base Path:   C:\Program Files\dotnet\sdk\2.0.2\
Microsoft .NET Core Shared Framework Host
Version  : 2.0.0
Build    : e8b8861ac7faf042c87a5c2f9f2d04c98b69f28d
VS Code version: 1.20.1
C# Extension version: 1.14.0
Steps to reproduce
I have a project with this structure:
root
--app
  --DotNetLambda
    --DotNetLambda.csproj
  --DotNetLambda.Test
    --DotNetLambda.Test.csproj

DotNetLambda.Test.csproj has a reference to the main project:
  <ItemGroup>
    <ProjectReference Include="..\..\app\DotNetLambda\DotNetLambda.csproj" />
  </ItemGroup>

Expected  behavior
Intellisense works in both projects.
Actual behavior
I get this error from OmniSharp:
[fail]: OmniSharp.MSBuild.ProjectLoader
        Unable to find project information for 'c:\www\tombola.infrastructure.international.dotnetlambda\app\DotNetLambda\DotNetLambda.csproj'. The project file may be invalid or missing targets required for restore.
[warn]: OmniSharp.MSBuild.ProjectManager
        Failed to load project file 'c:\www\tombola.infrastructure.international.dotnetlambda\app\DotNetLambda.Test\DotNetLambda.Test.csproj'.

If I change the link to an obviously broken one, I get The referenced project '..\..\adpp\DotNetLambda\DotNetLambda.csproj' does not exist.
If I change the reference to an absolute filepath copied from the error message, i.e. c:\www\tombola.infrastructure.international.dotnetlambda\app\DotNetLambda.Test\DotNetLambda.Test.csproj - it all works.
If I then change the full path to the relative one again, it still works until I reopen the project. I can live with an absolute url for me but I seem to get these issues all the time with OmniSharp - but there is literally nothing in the error message that seems useful to me in trouble-shooting?
The only thing that guarantees it to work is deleting any bin/obj folders, setting the reference to the absolute full path and re-opening.
I hope someone can look at this and see what obvious mistake I am making but I'm lost!

@cannontrodder Can you try updating to the most recent version of the .net sdk? I used the following commands to create project files with relative path references and I'm able to consume types from the console app in the test library:
mkdir project
mkdir test
dotnet new console -o project
dotnet new xunit -o test
dotnet add test\test.csproj reference project\project.csproj
dotnet new solution -n solution
dotnet sln solution.sln add test\test.csproj project\project.csproj

@rchande that worked, I'm feeling a bit silly for not trying that but it worked perfectly! I normally run in docker so tend to pull the latest down but this week I'm relying on the version installed by VS2017. For those that follow, this configuration immediately fixes the issue, hope it saves you time like @rchande  has for me :-)
.NET Command Line Tools (2.1.4)

Product Information:
 Version:            2.1.4
 Commit SHA-1 hash:  5e8add2190

Runtime Environment:
 OS Name:     Windows
 OS Version:  10.0.16299
 OS Platform: Windows
 RID:         win10-x64
 Base Path:   C:\Program Files\dotnet\sdk\2.1.4\

Microsoft .NET Core Shared Framework Host

  Version  : 2.0.5
  Build    : 17373eb129b3b05aa18ece963f8795d65ef8ea54

@cannontrodder Glad you got it working! I'm going to go ahead and close this bug.


Xcode 13 compiler error

Hello  everyone 👋
Seems like not all errors have been fixed. Could you please help?)))

Sorry, my bad. remove extra dependency. I don't know why it's happen but now it works.

The screenshot is not PathKit source and is a file from a different dependency you are using -> https://github.com/tuist/XcodeProj/blob/main/Sources/XcodeProj/Extensions/Path%2BExtras.swift .

Omg, double my bad ) sorry for interrupt

It looks like there's a patch released a few hours ago in https://github.com/tuist/XcodeProj/releases/tag/8.3.1


Fixed SheetJs XLSX package version issue

Type:
The following has been addressed in the PR:

There is a related issue?
Unit or Functional tests are included in the PR

Description:

I need this fix as well. It became impossible to use this library due to the issues it causes because of the git link usage instead of the version.

I need this fix as well. It became impossible to use this library due to the issues it causes because of the git link usage instead of the version.

you can try this as a temporary fix
npm i react-export-excel-hot-fix


[Feature Request] Allow for extending tags on elements

Hi! 👋
First off, thank you for this exceptional toolkit. It has significantly simplified visualizing my designs and is incredibly intuitive! 🙏
I'm working with a loosely coupled system spread across multiple directories (12+ and growing). It would be highly beneficial to have the ability to extend tags from one model to another without navigating the entire file structure.
I am not sure if this is the correct solution to the problem, but I can't think of anything else... 😥
Table of content:

Logical overview
Current implementation sample
Example usage
After enhancement

Here's an example to illustrate the scenario:
Logical overview:
ExternalSourceA -> ServiceA -> MessageBroker.TopicA -> MessageBroker.SubscriptionA -> ServiceB
ExternalSourceA -> ServiceA -> MessageBroker.TopicA -> MessageBroker.SubscriptionB -> ServiceC

Current implementation sample:
/src/serviceA.c4

model {
    serviceA = context 'service A' {
        controller = container 'controller'
    }

    externalSystemA -> serviceA
    serviceA -> messageBroker.topic
    serviceA.controller -> messageBroker.topic
}

/src/serviceB.c4

model {
    serviceB = context 'service B' {
        subFetcher = container 'subFetcher'
    }

    messageBroker.subA -> serviceB.subFetcher

}

/src/serviceC.c4

model {
    serviceC = context 'service C' {
        subFetcher = container 'subFetcher'
    }

    messageBroker.subB -> serviceC.subFetcher
}

/src/externalSystemA.c4

model {
    externalSystemA = context 'externalSystemA'
}

/src/messageBroker.c4

model {
    messageBroker = context 'messageBroker' {
        topic = container 'topic'
        subA = container 'subscriptionA'
        subB = container 'subscriptionB'
    }

    messageBroker.topic -> subA
    messageBroker.topic -> subB
}

/src/views.c4

views {
    // Define views for system interaction
    view context-externalSystem2ServiceB of serviceB {
        include *,
            serviceA,
            externalSystemA,
            serviceA.controller,
            messageBroker,
            messageBroker.topic,
            messageBroker.subA,
    }

    view context-externalSystem2ServiceC of serviceC {
        include
            serviceA,
            externalSystemA,
            serviceA.controller,
            messageBroker,
            messageBroker.topic,
            messageBroker.subB,
    }
}

Example usage:
    extend serviceA {
        #externalSystem2ServiceB
    }

    extend messageBroker {
        #externalSystem2ServiceC
        subA {
            #externalSystem2ServiceB
        }
    }

After enhancement:
/src/serviceA.c4

model {
    serviceA = context 'service A' {
        controller = container 'controller'
    }

    externalSystemA -> serviceA
    serviceA -> messageBroker.topic
    serviceA.controller -> messageBroker.topic
}

/src/serviceB.c4

model {
    serviceB = context 'service B' {
        subFetcher = container 'subFetcher'
    }

    extend externalSystemA {
        #externalSystem2ServiceB
    }

    extend serviceA {
        #externalSystem2ServiceB
    }

    extend messageBroker {
        #externalSystem2ServiceB
        subA {
            #externalSystem2ServiceB
        }
    }

    messageBroker.subA -> serviceB.subFetcher

}

/src/serviceC.c4

model {
    serviceC = context 'service C' {
        subFetcher = container 'subFetcher'
    }

    extend externalSystemA {
        #externalSystem2ServiceC
    }

    extend serviceA {
        #externalSystem2ServiceC
    }

    extend messageBroker {
        #externalSystem2ServiceC
        subA {
            #externalSystem2ServiceC
        }
    }

    messageBroker.subB -> serviceC.subFetcher
}

/src/externalSystemA.c4
...

/src/messageBroker.c4
...

/src/views.c4

views {
    // Define views for system interaction
    view context-externalSystem2ServiceB of serviceB {
        include
            *,
            element.tag = #externalSystem2ServiceB

    }

    view context-externalSystem2ServiceC of serviceC {
        include
            *,
            element.tag = #externalSystem2ServiceC
    }
}

That would be a great feature that would help me.
My use-case is that some of the model is auto-generated. But I would love to extend the generated parts with tags to allow e.g. color coding certain parts.


Script or instructions for moving Django to another server

Useful for setting up development environments and moving servers:

python manage.py dumpdata lovelace_website.json
python manage.py loaddata lovelace_website.json
(Manually?) move the media directory.

Could be better but we have some notes now: https://github.com/project-lovelace/lovelace-website/blob/838c05092c6c1200c89e01e8e60591ef16d6e383/populate_production_env.bash#L3-L9


i update to verison 1.2.1 find that i can't find Matrix4 class?

how should i solve this?

in version 1.0.0,it works fine.

Hi @wtus, If you haven't reset your IDE after updating I would recommend trying that first. We haven't moved/removed Matrix4

@jonahwilliams thanks,i restart my computer, it's fine now.

Glad to hear it is resolved!


Visual tweaks take 2

Added max-width to accommodate showing longer strings in pop-up.
Moved in-line style for body to styles.css
Text and button centered only for log in prompt

Sorry Rita, I am not getting emailed when you open pull requests here for some reason.  Maybe there's a setting I need to adjust; I'll take a look.  Will look over this now as well.

@reetssydney Ah, would you mind requesting a review from me when you open a PR?  You can do that on the right under "Reviewers."  If I appear as a suggested reviewer, you can just click the "Request" link; otherwise click the little gear icon and it will open a search box where you can search for me (and just click on my name when I appear to request my review).
That said—I've opened a PR that incorporates the copy updates you've made on popup.html.  (https://github.com/wikimedia/webextension-readinglists/pull/3).  Would you mind opening up a new PR on the official wikimedia repo with just the style updates, and add me as a reviewer?  I just went ahead and self-merged the initial commit last night, so there will be code there for you to update now. ;)


Make only checkbox clickable

I've noticed that I sometimes by mistake tick a checkbox in the plugin window, when I am trying to click something else or scroll the window (using touch). Would it be possible to tick the checkbox in the plugin only when you click the checkbox itself?

Good Idea. I would like that as well. Furthermore, you could make the rest of the line a link to open the note where the task sits. I usually have some context before/after my tasks and that would make navigating really easy.

Yeah, this is a good idea. Will do it


cleanup SqlDataRecord

Follow-up from https://github.com/dotnet/SqlClient/pull/1024 , This implements the suggested and agreed changes from that PR feedback.

remove EnsureSubclassOverride because there is no way to create an SqlDataRecord without the internal buffer that it is checking being set.
Ensure that all callsites with an ordinal parameter directly or indirectly (through GetMetaData or GetSmiMetaData) call ThrowIfInvalidOrdinal
remove the unused internal ctor
mark most fields as readonly

@Wraith2 I've looked at netcore SqlDataRecord class and found several interesting things:

Several things looks unused

The code in netcore SmiEventSink_Default class is quite strange - at least for me :) . I can't understand who will fill _errors and _warnings fields. If they are not used , maybe it is worth creating a static dummy class which does nothing in ProcessMessagesAndThrow.
_usesStringStorageForXml seems to have a constant "true" value

Yes, to the compiler in netcore builds. They might be used directly int he netfx build or used through reflection or inheritance. My current focus is on merging as much of the netcore and netfx codebases as possible and there are many peculiar or nonsensical things that will need resolving once that first task is finished.
Yes, as far as I can tell it's never used and when using SqlDataRecord the message sink functions turn up in profiles. Again, with deeper investigation on both codebases they may be possible to dummy out as you said, I just haven't tried to go deep yet. If you want to do so it would be welcome.
check if it's ever used in netfx, if not and there is no path to set it through inheritance then we could get rid of it.


Enable/disable specific progress bars

At the moment, huggingface_hub overrides tqdm progress bars to be able to enable and disable them globally either using HF_HUB_DISABLE_PROGRESS_BARS environment variable or enable_progress_bars/disable_progress_bars helpers (env variable having priority). These helpers are meant to be reused by other HF libraries built on top of huggingface_hub.
As mentioned by @BenjaminBossan on slack (private), the problem with this approach is that a library can disable progress bars from other libraries which can be misleading. A possible solution would be to add a new parameter group: Optional[str] = None to the progress bars working similarly to logger names. Then, we can enable/disable progress bars only from specific libs:
disable_progress_bars() # disable everything
disable_progress_bars("peft") # disable progress bar in a group starting by "peft" (e.g. `peft.foo.bar`)
disable_progress_bars("peft.foo")

Having something like this could prove useful to enable/disable progress bars when running PEFT, a transformers training or a huggingface_hub push without enabling/disabling other cases (typically disable some progress bars in a local training). And still have HF_HUB_DISABLE_PROGRESS_BARS to disable everything (typically disable all progress bars in a production environment). Such a change would be backward compatible and we could iteratively add groups to the existing progress bars we have.
No need to be as complete as the logging module. We can just work with prefixes and that's all. No need to handle configuration files or more detailed environment variables.

Other suggestion: instead of setting group="peft" manually in the library implementation, we could retrieve it from the stack traceback with a bit of Python magic (when group=None). Haven't tried it myself but it would make the change immediately backward compatible in existing libraries. I'm not so opinionated about it.

Hey @Wauplin i would love to start working on this as well. Since i am not quite sure this is what i understand and how i would proceed implementing it:

Extending tqdm helpers: Make disable_progress_bars, enable_progress_bars and are_progress_bars_disabled support new group parameter and update progress bar ininitialisation. Something like this:

def disable_progress_bars(group: Optional[str] = None):
    if group is None:
        _PROGRESS_BAR_STATES["_global"] = False
    else:
        _PROGRESS_BAR_STATES[group] = False

def enable_progress_bars(group: Optional[str] = None):
    if group is None:
        _PROGRESS_BAR_STATES["_global"] = True
    else:
        _PROGRESS_BAR_STATES[group] = True

def are_progress_bars_disabled(group: Optional[str] = None) -> bool:
    if group is None or group not in _PROGRESS_BAR_STATES:
        return not _PROGRESS_BAR_STATES["_global"]
    return not _PROGRESS_BAR_STATES[group]

Create global registery for progress bar states: Tracks the state of each group of progress bars. Something like

_PROGRESS_BAR_STATES = {"_global": True}  # Default is enabled for all

def _check_env_variable():
    return os.getenv("HF_HUB_DISABLE_PROGRESS_BARS") != "1"

_PROGRESS_BAR_STATES["_global"] = _check_env_variable()

Refactor the existing code to use the new tqdmhelpers

I would love to get started on this and look forward to your guidance and suggestions.

Hey @lappemic! Thanks for your contributions! So yes, that would be the general idea. More in details:

def disable_progress_bars(group: Optional[str] = None):

=> I would rename group to name to be more consistent with the logging module (e.g. logging.getLogger(name=...))

Create global registery for progress bar states: Tracks the state of each group of progress bars.

In general, yes.
In practice, the HF_HUB_DISABLE_PROGRESS_BARS constant should still be defined in constant.py so no need for _check_env_variable. I would keep the "states" dict and HF_HUB_DISABLE_PROGRESS_BARS completely separated (and used both in are_progress_bars_disabled with a priority on the env variable ofc).
Also keep in mind states must be handled in hierarchy. Here is an example of how it is meant to work:
>>> disable_progress_bars("peft.foo")
>>> are_progress_bars_disabled("peft")
False
>>> are_progress_bars_disabled("peft.something")
False
>>> are_progress_bars_disabled("peft.foo")
True
>>> are_progress_bars_disabled("peft.foo.bar")
True
>>> enable_progress_bars("peft.foo.bar")
>>> are_progress_bars_disabled("peft.foo")
True
>>> are_progress_bars_disabled("peft.foo.bar")
False

In practice, I would use nested dicts to handle those and navigate in the tree using parts from name.split("."). Be careful with cases where a node is disabled (must disable all of its children).
I would advice to treat None as "" and to avoid introducing a "_global" private key.
Does that make things clearer for you? Happy to review a draft PR anytime.

Hey @Wauplin, thanks a lot for your detailed feedback!
I'll definitely align with your suggestion on naming.
As for managing the "states" dict hierarchically, I understand it as follows:

Defining the "states" dict (like progress_bar_states) directly within tqdm.py
Implementing additional utility functions within tqdm.py to manage the hierarchical states (e.g. set_progress_bar_state and get_progress_bar_state).
Integrating this hierarchical logic into the existing utility functions (disable_progress_bars, enable_progress_bars, are_progress_bars_disabled).

Did I get this right? If so, I'm ready to start drafting a PR.

Yes exactly! Not sure the set_progress_bar_state/get_progress_bar_state helpers are necessary but if it helps, please go ahead and create them. We won't expose them publicly though (so please name them as private e.g. _set_progress_bar_state). Otherwise than that I think you're good to go!

Closed by https://github.com/huggingface/huggingface_hub/pull/2217. Thanks @lappemic!
cc @lhoestq @mariosasko @BenjaminBossan who requested in the past the possibility to disable only certain progress bars. This is now possible!
For example to disable all progress bars generated by huggingace_hub:
from huggingface_hub.utils import disable_progress_bars

disable_progress_bars("huggingface_hub")

# or more specifically
disable_progress_bars("huggingface_hub.lfs_upload")

to use this feature in datasets/peft, you must provide a name to your tqdm init:
from huggingface_hub.utils import tqdm

# Declare a progress bar under the `peft.foo` namespace.
with tqdm(range(5), name="peft.foo"):
    ...

Namespaces work similarly to logging, with hierarchical structure split by dots.


Update ome-version-comparison.md

Multiple branding templates is only available in Microsoft Purview Advanced Message Encryption

@JohanFreelancer9 Please copy review

Issue#https://github.com/MicrosoftDocs/microsoft-365-docs/issues/8730

@KCCross Gentle reminder

Learn Build status updates of commit f662a86:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

microsoft-365/compliance/ome-version-comparison.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

Closing as per the comment in #8730


Change [MeansImplicitUse] attribute on BDL so that unused params are treated as such

Adds ImplicitUseKindFlags.InstantiatedNoFixedConstructorSignature to [MeansImplicitUse] attribute for BDL.
The flag does exactly what we'd want, the BDL method itself is treated as used implicitly, but the params are not.

"More" info on jetbrains' site:
https://www.jetbrains.com/help/resharper/Reference__Code_Annotation_Attributes.html#ImplicitUseKindFlags
Discussed shortly on discord.

Seems to work well. I've increased the inspection level for this to warning because it seems like something we should always catch framework-side.
Open to opinion on whether we should make the same change on the osu! side.

Scratch that, turns out CI sees a lot more than my IDE does. Let's leave it as a hint for now.


Support overloading UDTFs

Type overloading of functions based on lazy or greedy hitting for type families (i.e. numerics, or floats/doubles)
The following example should work:
@omnisci('int32(Column<float>, RowMultiplier, Column<float>)',
         'int32(Column<double>, RowMultiplier, Column<double>)')
def mycopy(x, m, y):
    for i in range(len(x)):
        y[i] = x[i]
    return len(x)

xref: https://github.com/xnd-project/rbc/issues/175


Update min-gas-price default configuration

https://github.com/provenance-io/mainnet/blob/f2649bccec7507ba49ba066356dae44816f0fb61/pio-mainnet-1/node-app.toml#L11
The default min-gas-price needs to be updated to 1905nhash to match the existing market price value.

Also note that users who have this invalid value will see a panic if they use 1.3.1.  https://github.com/provenance-io/provenance/issues/333
We will be putting a better error message in to make the cause of the panic more clear.


Prevent double forward slash in URL

@sandersky 2 things.

oops, meant to just cancel that last comment, ended up closing the PR. Anyway, just wanted to ask for a unit test to exercise this. Thanks.


[CLEANUP] Fix Sonar issue on unit test

Not that it is very problematic, but it looks nicer following Sonar recommendations.
@eddie-martinez @ddiroma

🐸 JFrog Frogbot


Check for user in PostgresSQL server

make setup failed on a system with a fresh install of PostgreSQL
due to a missing 'django' user.

Dude, you are on a roll!!!


[WIP] Introduce WorkerOffer reservation mechanism for Barrier TaskSet

What changes were proposed in this pull request?
Currently, Barrier TaskSet has a hard requirement that tasks can only be launched
in a single resourceOffers round with enough slots(or sufficient resources), but
can not be guaranteed even if with enough slots due to task locality delay scheduling.
So, it is very likely that Barrier TaskSet gets a chunk of sufficient resources after
all the trouble, but let it go easily just because one of pending tasks can not be
scheduled. Futhermore, it causes severe resource competition between TaskSets and jobs
and introduce unclear semantic for DynamicAllocation.
This pr trys to introduce WorkerOffer reservation mechanism for Barrier TaskSet, which
allows Barrier TaskSet to reserve WorkerOffer in each resourceOffers round, and launch
tasks at the same time once it accumulate the sufficient resource. In this way, we
relax the requirement of resources for the Barrier TaskSet.
Besides, we have two features along with WorkerOffer reservation mechanism:
To avoid the deadlock which may be introuduced by serveral Barrier TaskSets holding the reserved WorkerOffers for a long time, we'll ask Barrier TaskSets to force releasing part of reserved WorkerOffers
on demand. So, it is highly possible that each Barrier TaskSet would be launched in the end.
Barrier TaskSet could replace old high level locality reserved WorkerOffer with new low level locality WorkerOffer during the time it wating for sufficient resources, to perform better locality at the end.
To integrate with DynamicAllocation:
The possible effective way I can imagine is that adding new event, e.g.
ExecutorReservedEvent, ExecutorReleasedEvent, which behaved like busy executor with
running tasks or idle executor without running tasks. Thus, ExecutorAllocationManager
would not let the executor go if it reminds of there're some reserved resource on that
executor.
How was this patch tested?
existed and added some, needs to add more.

ping @jiangxb1987


Register files.autoSave and files.autoSaveDelay as a language override setting.

I would like to configure auto-saving per language, which is not currently available for the settings files.autoSave and files.autoSaveDelay as shown in the following screenshots.

Here's that snippet from settings.json as text.
    "files.autoSave": "afterDelay",
    "files.autoSaveDelay": 1000,
    "[javascript]": {
        "files.autoSave": "off",
    },

For example, when writing a README or a backend server in Python, I appreciate the auto-save so that I can restart the server without pressing CTRL + S in each file I've modified. In contrast, when working on a JavaScript front-end with hot-reloading, I want the auto-save disabled so that my in-progress changes (e.g. a half-written JSX props list) don't break the site until I manually save the file(s).
Currently, I have to switch the auto-save setting each time I switch projects. When I'm working on a full-stack application, however, this quickly becomes tedious, and I typically give up the auto-save benefits for the backend.
VS Code Version Details

Previously at https://github.com/microsoft/vscode/issues/42170

This feature request is now a candidate for our backlog. The community has 60 days to upvote the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our documentation.
Happy Coding!

:slightly_smiling_face: This feature request received a sufficient number of community upvotes and we moved it to our backlog. To learn more about how we handle feature requests, please see our documentation.
Happy Coding!

https://github.com/microsoft/vscode/pull/200326 enables all auto save related settings to be per-workspace and per-language.


New Code For Node.js Sample Needed

The existing code for the node.js example is both complex and broken. It won't work with the most recent googleapis version. Below is code that is simple and will connect and authenticate. Querying is another issue, see open bug on this:
'var util = require('util');
var google = require("googleapis");
var SCOPES = ['https://www.googleapis.com/auth/userinfo.email',
'https://www.googleapis.com/auth/datastore'];
var datasetId = "";
credentials = new google.auth.JWT(
process.env['DATASTORE_SERVICE_ACCOUNT'],
process.env['DATASTORE_PRIVATE_KEY_FILE'],
null,
SCOPES);
credentials.authorize((function(jwtErr) {
if (jwtErr) {
errors = {'jwt auth error':jwtErr};
console.log(errors);
return;
}
var cloudstore = google.datastore('v1beta2').datasets;
'

Closing since we've removed the Node.js sample from the repo.
Check out gcloud-node as an option for accessing Google Cloud Datastore from Node.


Allow completion of dot directories

Fixes #3775, fixes #6543.
This makes zsh treat . and .. as directories to be completed. That means it will insert a slash (/) when these directories are provided in the command line.

Should this be off by default, since it's a change in completion behaviour?
(I was certainly surprised about the change and had to go digging to find that this was the cause.)

There were users surprised by the lack of this feature, and enabling it just means you have to type a letter after the dot to complete to hidden files, which I presume is your use case.


Preprocessing options

Super nice tool, very helpful!
The results are actually nicer than what I get from the cellpose CLI.
I think it is the preprocessing steps       .preprocess( ImageOps.Filters.median(1) ) .normalizePercentilesGlobal(0.1, 99.8, 10)
Could you by any chance point me to the closest scikit-image or cv2 equivalent?
Thank you so much

Hi @pakiessling,
Unfortunately I do not have the scikit-image or cv2 equivalents. Best
Oli


Feature request

After receiving otp..let site be ready for entering otp instead of clicking on box first..this will reduce time for log in. Also after entering 6 digit otp..let site directly show beneficiaries instead of submit otp button.

This is good ask.
I'm contemplating about wrong OTP input cases. Let's give it some time.

this would actually cause issue with wrong input.I would not suggest adding this feature


Slide partially covered in vertical slider with variable height elements

Hi,
I'm in need of some urgent assistance, as the project I'm working on has to be online in less than 24 hours.
If you have a look at the screenshot, you'll see the page: a two-part slider with a video player in the main container and a navigational vertical slider on the right

The trouble is one of the navigational elements is longer than the rest and I think that leads to the current slide (the top-most one) being partially covered.
Is there anything that I could do to correct this behaviour, short of making sure each navigational slide is of equal length.
Thank you!

Please create a jsfiddle with the problem so we can help.

https://jsfiddle.net/yypesh3d/1/
Should demonstrate the issue

Temp bug fix, match the height on all the slides before running slick on it. Shameless plug here.
$('.slides').match_height().parent('.slider').slick({
  vertical:true
});

I think the same issue as in #1803 is described.


Indices get formatted oddly for larger fonts

Mahabharata → 1st anuvaka → 3rd verse, toggle between deva and on iPad

Can't reproduce -- please share a specific URL and let me know what specifically looks odd.
And what do you mean by "toggle between deva and on iPad" ?
One issue I know of is that if you transliterate from devanagari -> roman -> devanagari again, the . character becomes a danda, which is strange. The root cause here is that there is no "source of truth" for transliteration data, which also prevents us from easily supporting Bengali script. I think once that's fixed, the problem I mention will also go away. I hope that's the problem you mean too.

Ah, I think this is a text width issue. The gray line above Click on words to see what they mean. shows the with of this text content. So the options are to either (1) make the text area wider or (2) make the body text smaller.
While I think about which I like better, do you have a preference?

Closing for now since we have a text size option, which means users can now resize text and avoid this issue.


Added animation library to Fabric.

Try merging beta/3.0.0 into this branch and see what linting errors remain.

Approved

This is really, really cool, @wdo3650! Super excited for these additions. Approved.
At some point--I don't want to block on this right now--one thing I'd love us to do is think about how we document these additions. I'm thinking on the documentation site, in the .md files under ghdocs, and in-code (e.g. JSDoc). We should include guidance for where, how, and when to use these methods, ideally with demonstrational examples.


Readme examples update

removed build status as the real badge equivalent is displayed just above in the Readme.
replaced Code Climate by Codacy as the badges for the former service are unreliable (#1518). Also, as Code Climate are not being very cooperative there is no point in giving them free advertising.
replaced Gratipay by Liberapay, its maintained fork.
added three new examples which showcase different usages of our badges.

I'm wondering though, why do we not insert real badge examples here? With a high maxAge parameter and static badges, it would probably put little extra load on the server.

I'm :+1: on replacing them with static badge examples

The result can be viewed here.


[LIBDEF] rethinkdbdash

I have been trying to create one for my own project.
If anyone else has started one, please do let me know. :)

I did start some work on typing it, although it's still a bit crude, it works for common usage. 🍰
https://gist.github.com/JohnyDays/26792b298b442353da00427f21609f4c

Brilliant, thanks for the share!  I'll look to merge this into mine.

@ctrlplusb I started working on rethinkdb driver (not rethinkdbdash). Don't have it publicly though. How would I share it with you?

@alexeygolev, brilliant thanks, every bit of reference will help.
Feel free to email me - sean [at] ctrlplusb [dot] com
Thanks!

@ctrlplusb have you received it (really sorry to use the issue but I'm not sure if the email went through)

@alexeygolev I've just checked, sorry, yes I have received it.  Thanks so much dude!
I have been finishing off another project - hoping to be rid of it within the next week, thereafter will be spending a considerable amount of time on this effort.  Complete up to us co-collaborating on this.
I'll ping you via email when I am getting ready to go.
Sorry about not picking that up sooner!

Closing as the rethinkdbdash project looks to be dead.


Remove -mpower8-vector and -mpower8-fusion

gcc enables these by defualt and clang doesn't support these flags.

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.


Forked-daapd ingress

I'm pushing a first try at ingress. It seems to work pretty well if you're accessing HA directly, as far as I can tell at least.
On the other hand if you're accessing HA through some reverse proxy (I'm using HAProxy on my router with SSL offloading) it's a bit trickier for the websockets, you either need a very long timeout or ideally I might add support for SSL directly into the addon's nginx, that way it could be done with a TCP backend. Not sure how the nabu casa works, I suspect it'll have the same issue.
I'm opening this to track it, I'm open to suggestions of course.
I need to play around with it a bit more but in the meantime for people with simpler setup this should work just fine.
Please let me know here if you have any problems with it.

First of all, thanks for this awesome addon.
In general it is working fine if I open in the browser: <IP_ADDRESS>:3689
But if via the supervisor I click on 'Open web UI', or via the sidebar, then I get the error:
Failed to connect to forked-daapd
Request failed (status: 404 Not Found, url: http://<IP_ADDRESS>:8123/api/hassio_ingress/WYy0JkD2dIHUvc1IIB7tA0rJH2AW03S0LWD_8aPJrIc//.api/config)

The url then is: http://<IP_ADDRESS>:8123/hassio/ingress/e4ac757a_forked-daapd

I'm also encountering this issue. Through Ingress I see:

Failed to connect to forked-daapd
Request failed (status: 404 , url: https://<redacted>/api/hassio_ingress/7RyaBzh0bDIQcKgAYqxTRZ3sjcfAPLzImaG5b8OCp_w//.api/config)

Same issue here. Any resoution?

I'm not sure you all have the same issue, but unfortunately most of the web UI depends on websocket connections made over port 3688. For @fredrikbaberg at least, since you mention you're using a reverse proxy, you'll need to configure that port to be proxied as well.
Without a reverse proxy it should work, as long as port 3688 is open on the same IP you're accessing HA through, but there again depending on setups that might be an issue.
There's been an update to the web UI since I've made this addon so some of that might be a bit better in the latest version, which I'll need to update the addon to, but I don't really expect it to not be a pain because of those websockets sadly.

I'm not sure you all have the same issue, but unfortunately most of the web UI depends on websocket connections made over port 3688. For @fredrikbaberg at least, since you mention you're using a reverse proxy, you'll need to configure that port to be proxied as well.
Without a reverse proxy it should work, as long as port 3688 is open on the same IP you're accessing HA through, but there again depending on setups that might be an issue.
There's been an update to the web UI since I've made this addon so some of that might be a bit better in the latest version, which I'll need to update the addon to, but I don't really expect it to not be a pain because of those websockets sadly.

I'm trying to understand the reverse proxy part. I have limited experience with reverse proxy, but am not conviced that is the issue for me.
I have Traefik in a separate VM from Home Assistant. There are three ways for me to access Home Assistant: External URL (through reverse proxy), internal URL or LAN IP. I get the same issue through all three methods of access: Request failed (status: 404 Not Found, url: http://\<intenal hostname or LAN IP\>:8123/api/hassio_ingress/\<redacted\>//.api/config). For external URL it's https and no port, but otherwise the same message.
If the issue was with reverse proxy, should it not work if I use internal URL or LAN IP?
I've redacted part of the URL, but there are two forward slash there (//.api/config), could the URL be incorrect?


PoC logging

PoC for logging extension.
It contains a temp hack capturing the current static Log factory and copies that into the new LogExtension.
The LogExtension is then accessible from anywhere you have access to the ActorSystem.
Some things to consider, I really don't want to create a new logger per ActorContext as that would be very expensive.
Maybe this can be solved with some form of shared ActorContext logger.
There are some examples showing how this new feature is used for Remote, Cluster and MemberList.
Thoughts?
This could all also be done w/o any form of extensions, just having a LoggerFactory prop on the actor system, so maybe this PR overcomplicates things here.

When getting the ActorSystem instance in the producer function, each actor can create its own logger using the extension. But in reality, I would use the static Serilog logger in each actor type, not per actor instance as it's completely unnecessary. That's the weakness of the Microsoft logging abstraction tbh.

Going down the DI route instead, we could easily have a singleton Logger open generics, which when fetched from the DI container yields a unique instance per T. e.g.  Logger
but, this would still eat cpu cycles resolving this. for each actor. I need to ponder this some more


Update README and docs

Various small updates of the README and docs. This also consolidates the development guidelines in the contributing section of the docs.

nice 👍 much better!


Support serialization of custom property

Fixes https://github.com/microsoft/typespec/issues/4266

API change check
API changes are not detected in this pull request.


Copy and Past in code block fails

For Bug Reports

BookStack Version: v0.16.1
PHP Version: 5.6.30-0+deb8u1
MySQL Version: 5.6.29-1~dotdeb+7.1

Expected Behavior
If I copy some code of a code block and paste it to another position in a code block, the code/text should appear IN the code block.
Actual Behavior
If you copy some code of a code block and paste it to another line in the (same) code block, the old code block gets splitted and a new code block with the pasted code appears! So you have three code blocks at the end.
Images:

Copy and Paste the line with "some code to copy"

Thanks both for confirming this issue. This is now fixed as of 968e7b8 as part of the revamped code editing experience. It will be released as part of the upcoming v0.17 release. Therefore I will go ahead and close this issue.


Disable audio instead of aborting

When I execute scrcpy, it prints
scrcpy 2.7 <https://github.com/Genymobile/scrcpy>
error: XDG_RUNTIME_DIR is invalid or not set in the environment.
INFO: ADB device found:
INFO:     -->   (usb)  ZY22GCTXNV                      device  motorola_edge_30
/usr/share/scrcpy/scrcpy-server: 1 file pushed, 0 skipped. 58.4 MB/s (71200 bytes in 0.001s)
[server] INFO: Device: [motorola] motorola motorola edge 30 (Android 14)
INFO: Renderer: opengl
INFO: OpenGL version: 4.6 (Compatibility Profile) Mesa 24.1.7
INFO: Trilinear filtering enabled
INFO: Texture: 1080x2400
ERROR: Could not open audio device: ALSA: Couldn't open audio device: Host is down
ERROR: Demuxer error

but if I instead call scrcpy --no-audio then it works.
When audio does not work, as above, scrpcy should either suggest to use --no-audio, or even better it should assume that --no-audio was provided and go forward.

See https://github.com/Genymobile/scrcpy/issues/4800#issuecomment-2028754860


Maintenance Offline Message don't work

Problem
When you activate the Maintenance Offline nothing change in the Site, the site still available and no offline message is display it.
Technical Details

Pagekit version: 1.0.12
Webserver: Apache/2.4.18 (Win32) OpenSSL/1.0.2e PHP/5.6.18
Database: mysql / 5.7.10-log
PHP Version: 5.6.18

Please go to the admin panel of your site and log out.
If you are logged out the frontend of your page should be unavailable.

Please reopen if the problem persists


Extended Protection NTLMv1 note formatting adjusted

Description:
Formatting was wrong, minor adjustment.

Squash and then will approve.


Switch to MkDocs

Draft for MkDocs transition, there are various things that need to be fixed still, since the conversion was lossy. This draft exists so people can view my progress:
Things that still need to be fixed

[ ] Formatting ( The way the text appears on the page )
I've mostly completed this, there are a few pages in the reference manual that need fixing.
[ ] Internal references to pages
Pandoc was unable to automate this, so I need to fix the existing references. One idea I have is to have terms automatically highlighted/cross-referenced by using abbreviations. This means less work when writing anyway, as you won't need to remember to cross-reference every time Targets or Factory is written for example.
[ ] Some image embeds
The image embeds are included using html figures rather than the MkDocs figure directive due to the automated conversion, not necessary to fix but would be nice to fix.
[ ] Asciinema player embedding
The Asciinema player can be included since you can use discrete inline HTML in MkDocs, a nice benefit.
[ ] Rebasing commits on master (converting the some of the PRs the have been made since starting)

Visual Difference
The MkDocs material theme is currently being used. This can be changed to the readthedocs theme, which matches our existing documentation if necessary, so there will be no visual difference.

@MatthewCroughan, is there a way I can "build" it locally on my machine?
I assumed it is only a mkdocs serve but I faced errors so I might be missing something

It worked for me. What errors did you get?

@angolini The build instructions are in the new README.md. I'll paste it here for fun:
Foundries.io Documentation
microPlatform documentation source for https://docs.foundries.io
Development Environment
There are 3 ways to get started developing this documentation. Each method
provides mkdocs with various plugins as defined in requirements.txt
Nix
Clone this repository and run nix-shell at the root.

git clone https://github.com/foundriesio/docs/
cd docs/
nix-shell

Then run mkdocs serve or use the other tools provided in this environment.
Docker
Clone this repository and run a container on the root.
Replace <your-git-directory> with the path to this git repository as you have
cloned it.

git clone https://github.com/foundriesio/docs/
cd docs/
docker run -v <your-git-directory>:/git matthewcroughan/mkdocs-foundries-env

Virtualenv
Ensure you have python3 and python3-virtualenv installed.

git clone https://github.com/foundriesio/docs/
cd docs/
Run the following:

$ virtualenv -p /usr/bin/python3 venv
$ . ./venv/bin/activate
$ pip install -r requirements.txt

Then run mkdocs serve

I think a change needs to be done to the 'boards' section. Each board should have either it's own page with 'details', 'preparation' and 'flashing' sections or these pages should be in the board separate directory. Right now navigation in the boards section looks broken.

Yes, the board section and the qemu section are the main reason I'm advocating for the switch. It's not possible in Sphinx to code these sections up and conditionally include files, such that we have one template that each board uses. This has to wait until I've fixed the formatting in the other sections though.
The steps I'm following are:

Fix formatting
Fix references
Reimplement pages that need redesigns (Like boards/qemu)

I'm not sure if this phase (the migration) is the best to also change the way the files are organized. I would be more worried about not loosing content now, and adjust anything later.
And I agree, the main point is to be able to use variables (we will need a bunch of them) and a better way to template some pages (such as board and qemu)

@MatthewCroughan what are you looking for on this review? Should I be looking for which kind of things? Missing pages? Formatting? Overall look'n'feel?

@MatthewCroughan what are you looking for on this review? Should I be looking for which kind of things? Missing pages? Formatting? Overall look'n'feel?

Formatting, though you see in https://github.com/foundriesio/docs/pull/218/commits/06524dc070990cb0b3fe154d54ee8855bb02e2dc that I have also overhauled the look-and-feel of the factory-definition. The reason for this is because there was no way to do it in the way we were via .rst anyway, so it makes some sense to just start again when the section is otherwise broken. The same will be true of  reference-manual/boards as well as reference-manual/qemu.
Right now, I'm just going through and fixing these formatting issues, it is probably not a good time for review. Though, if you want to submit PRs to this branch, you can. I will be working on the reference-manual/ folder until a commit message indicates I am done with it, I will also comment.
That means that the user-guide and tutorials folder can be worked on without interrupting me, if you feel like working on that.

As part of the rebase I just pushed, the reference manual has been reformatted, next is the tutorials/user-guide sections.

Docs for 18cbc94662ddc8e9f3ba2759789b6869a765b72b are browesable at: https://ci.foundries.io/projects/fio-docs/builds/937/mkdocs/artifacts/index.html

@MatthewCroughan - i've added CI for mkdocs. I'm seeing one issue with the CI of this. I tried to set strict: true to make mkdocs validate our links and it does not seem to have any affect. Not sure how you are managing the TODOs for this, but I'd add that onto the list "make sure broken links break CI"

I also assume you need me to update fioctl to product markdown manual pages?

@doanac

@MatthewCroughan - i've added CI for mkdocs. I'm seeing one issue with the CI of this. I tried to set strict: true to make mkdocs validate our links and it does not seem to have any affect. Not sure how you are managing the TODOs for this, but I'd add that onto the list "make sure broken links break CI"

I believe mkdocs -s will actually work, instead of putting strict: true into the yml file, they are different in an undocumented way.
There are a lot of utilities we can use to check links as a post-processing step, (something ran after mkdocs build) rather than something that happens in MkDocs natively. This is the style of MkDocs generally speaking. It leaves post-processing and pre-processing up to the user, rather than doing it all itself in a half-baked manner:

https://www.npmjs.com/package/markdown-link-check
https://github.com/magicmatatjahu/milv

I also assume you need me to update fioctl to product markdown manual pages?

Yeah, that would be great. The cobra argument parsing library that Fioctl uses can do it like this using GenMarkdownTree instead of GenReSTTreeCustom

Some thoughts on CI are that I'd like to have the ability to generate production docs locally.
So, to do that, I'm going to have every function first query whether PRODUCTION=1 is set in the environment. If it is, then it will execute and return a proper value. If not then it will place a null value into the docs.
Right now, the return value of functions defined in mkdocs/main.py are able to be referenced from within the docs like this:
mkdocs/docs/something.md
The return at the time of writing is v0.16
The current Fioctl version is {{ fioctl_version() }}

mkdocs/main.py

import os
# Some functions to insert in to the docs via Jinja2. For example:
# {{fioctl_version() }} will place the fioctl_version number into the markdown
# file in which it is called.

def define_env(env):
  "Functions for MkDocs Jinja2"

  @env.macro
  def fioctl_version():
      import urllib.request, json

      url = "https://api.github.com/repos/foundriesio/fioctl/releases/latest"
      response = urllib.request.urlopen(url)
      data = json.loads(response.read())

      return data['tag_name']

Some thoughts on CI are that I'd like to have the ability to generate production docs locally.

Maybe take the bulk of whats in the unit-test for this and move it to a gen-docs shell script. i'll do a quick change with that to get the ball rolling for you.

I believe mkdocs -s will actually work, instead of putting strict: true into the yml file, they are different in an undocumented way.

Neither works. I've added this to index.md:
[this is bad](http://blomberg.commmm)

and it just renders it.

Docs for 302ed84a90c16cb372143c1d44d5bc49af38703e are browesable at: https://ci.foundries.io/projects/fio-docs/builds/938/mkdocs/artifacts/index.html

Docs for 62bebff01e323f6e48dfab148497cdd880c5f15c are browesable at: https://ci.foundries.io/projects/fio-docs/builds/940/mkdocs/artifacts/index.html

Docs for 960faca2ce1ee8a6409b2a1361f1139eb89bc290 are browesable at: https://ci.foundries.io/projects/fio-docs/builds/941/mkdocs/artifacts/index.html

I've rebased this PR/Branch on master, coming up to date with the latest changes and converting .rst -> .md
At this point, people can contribute by making PRs against this mkdocs branch. The tutorials folder is completely untouched by me. This section and its contents are what I need the most help with. I've edited the first post in this PR to contain a checklist of what still needs to be done.

Docs for 9c37a25a2c562be6b08a840cdf5053bb922da248 are browesable at: https://ci.foundries.io/projects/fio-docs/builds/942/mkdocs/artifacts/index.html

Docs for 18a1a7ad683646e868bb7562bdc6b07d87bb5010 are browesable at: https://ci.foundries.io/projects/fio-docs/builds/950/mkdocs/artifacts/index.html

Docs for e78566910565cb1d32fd5ae0bd9d9afbcb8bb409 are browesable at: https://ci.foundries.io/projects/fio-docs/builds/994/mkdocs/artifacts/index.html


Default password Kibana

Hello,
I have installed elastic search with the default configuration and kibana too. Which is the default login password for kibana? admin admin doesn't work.

Here is my output when I install elasticsearch 7.15.0
helm install elasticsearch elastic/elasticsearch
W1123 16:31:48.647591  331839 warnings.go:70] policy/v1beta1 PodDisruptionBudget is deprecated in v1.21+, unavailable in v1.25+; use policy/v1 PodDisruptionBudget
W1123 16:31:48.795478  331839 warnings.go:70] policy/v1beta1 PodDisruptionBudget is deprecated in v1.21+, unavailable in v1.25+; use policy/v1 PodDisruptionBudget
NAME: elasticsearch
LAST DEPLOYED: Tue Nov 23 16:31:48 2021
NAMESPACE: test
STATUS: deployed
REVISION: 1
NOTES:
1. Watch all cluster members come up.
  $ kubectl get pods --namespace=test -l app=elasticsearch-master -w2. Test cluster health using Helm test.
  $ helm --namespace=test test elasticsearch

No mention of password


121 fix ci pipeline

Codecov Report

Merging #1 (352bedc) into main (0f26075) will decrease coverage by 6.34%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main       #1      +/-   ##
============================================
- Coverage     87.71%   81.37%   -6.35%
+ Complexity      190       50     -140
============================================
  Files            66       27      -39
  Lines           635      306     -329
  Branches         35       22      -13
============================================
- Hits            557      249     -308
+ Misses           71       56      -15
+ Partials          7        1       -6

Impacted Files
Coverage Δ

...otlin/de/codecentric/hc/report/AchievementRates.kt

...e/codecentric/hc/habit/habits/HabitController.java

...decentric/hc/gateway/security/ApplicationUser.java

.../src/main/kotlin/de/codecentric/hc/report/Habit.kt

...ric/hc/gateway/filters/AddRequestHeaderUserId.java

...otlin/de/codecentric/hc/report/ReportProperties.kt

...ader/propagation/HeaderPropagationConfiguration.kt

...in/kotlin/de/codecentric/hc/report/TrackedHabit.kt

...in/de/codecentric/hc/report/TrackedHabitService.kt

...odecentric/hc/gateway/security/SecurityConfig.java

... and 29 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0f26075...352bedc. Read the comment docs.


table from jobman images deformatted

The table that is shown in jupyter when executing !jobman images is deformatted (see image).

@sophiasw Would an option to generate a json output help you?

I don't think this is necessary. It seems the table width does not match the screen width and when the screen is to small, the right end of the table overflows and is overlayed with the left side. I think this issue would be solved if the Tags List would have two rows to list the tags, then it would only extend to a second row within the right column rather than to the left side of the table.
If this is not easily done, it can also stay like this - it's just a cosmetic error.

Would it be an option to give the table a fixed but smaller size that will fit most terminals? Maybe the entries with a long list of tags can receive an extra row that is empty in the Image Name column?
My guess is that users will only very briefly look at this table and wouldn't want to interact with it more. The information is all there and readable, so it should be fine either way.

I could go old school and make it 80 cols wide, default. Is that all right for you?

Sounds good to me.


Getting started images for link items should be links too

I clicked the play button and getting started made me feel silly, permanently lowering my self confidence.

cc @digitarald for content

cc @digitarald for content

@JacksonKearl what do you think about putting a link on the cover image as well for link buttons?

@JacksonKearl what do you think about putting a link on the cover image as well for link buttons?

Yeah we could do that

Yeah we could do that

Testing this out it made sense to me to treat all image clicks the same as their respective button clicks.

I find it very unexpected that clicking the image would trigger the action. I was clicking an image in the Codespace and it opened VSCode locally wanting to install the Codespaces extension?
Can we please reconsider this, esp. in the web clicking an image typically means to open the image in large. There is also no hand cursor indicating that a click works.

Scoped down to only apply to links and also give a pointer for the images on link-items.


Add symbol-table-full-json print option

Motivation
The current symbol-table-json output is too chatty since it does not filter anything from its output, i.e. it really is the JSON equivalent of symbol-table-full or symbol-table-full-raw print options.
This creates a problem for tools that want the symbol table output in an easy to consume format but don't want the full dump of the symbol table. Plus, it breaks the symmetry of the various symbol table printing options.
Solution

A new print option named symbol-table-full-json is added which behaves in exactly the same way as the current symbol-table-json option.
The behaviour of symbol-table-json is changed to output only the summarized version.

Test plan
See included automated tests.

Reassigning to runner.
Note that this will require modification to internal scripts to pass new flag.
I'm onboard on the description, but didn't read the code.

Note that this will require modification to internal scripts to pass new flag.

Specifically @DarkDimius means that this involves breaking changes at Stripe, that we will want to hold off merging / coordinate merging at the same time as we fix them.

@DarkDimius @jez Thanks, that's understandable. I've taken care to replace all current usages of the old flag to use the new full version in this codebase, and have noted instances where it might not even be necessary.
Alternatively, I could leave symbol-table-json as is and introduce a symbol-table-short-json (or similar), to ensure there are no externally visible changes. But that felt like it was breaking the symmetry and introducing a new concept into the print options, so I opted to not do that.

Alternatively, I could leave symbol-table-json as is and introduce a symbol-table-short-json (or similar), to ensure there are no externally visible changes. But that felt like it was breaking the symmetry and introducing a new concept into the print options, so I opted to not do that.

no, let's do it proper. :-) We'll merge it and roll it out carefully at Stripe.


ssh-keygen hangs when run from PowerShell 7.1.1 in Windows Terminal, cannot repro with new tabs

Environment
Windows build number: 10.0.18363.1256
Windows Terminal version (if applicable): 1.4.3243.0

PowerShell 7.1.1

C:\WINDOWS\System32\OpenSSH\ssh-keygen.exe
Product version: 'OpenSSH_7.7p1 for Windows'

Steps to reproduce
Run C:\WINDOWS\System32\OpenSSH\ssh-keygen.exe
Expected behavior
Input should be possible at the following prompt
Enter file in which to save the key (C:\Users\sbarizien/.ssh/id_rsa):
Actual behavior
No input is possible, the ssh-keygen.exe process needs to be terminated.
This behavior cannot be reproduced:

in PowerShell 7.1.1 not running within Windows Terminal
in other / new Windows Terminal tabs running PowerShell 7.1.1
in Windows PowerShell 5.1 running within Windows Terminal
on another machine running Windows 10 build 19042.746

So there is something special about this particular instance of PowerShell 7.1.1 running in that particular Windows Terminal tab.
I can keep that tab open as long as needed in order to diagnose the issue.

Hmm, this looks quite a bit like #7467, though that issue says it was fixed in 8.1. Could you test the latest version of ssh-keygen?

Hmm, this looks quite a bit like #7467, though that issue says it was fixed in 8.1. Could you test the latest version of ssh-keygen?

Where should I get pre-built binaries of OpenSSL 8.4 for 64-bit Windows 10 from?

Where should I get pre-built binaries of OpenSSL 8.4 for 64-bit Windows 10 from?

https://github.com/PowerShell/Win32-OpenSSH/releases

https://github.com/PowerShell/Win32-OpenSSH/releases

Issue repro'ed with C:\OpenSSH-Win64\<IP_ADDRESS>p1-Beta\OpenSSH-Win64\ssh-keygen.exe (MD5 = 301109080A5B375B34D4898EB9321C25)

Issue repro'ed with C:\OpenSSH-Win64\<IP_ADDRESS>p1-Beta\OpenSSH-Win64\ssh-keygen.exe (MD5 = 301109080A5B375B34D4898EB9321C25)

I hate to say, but I had to reboot my PC... so the issue isn't there anymore...

I hate to say, but I had to reboot my PC... so the issue isn't there anymore...

Ah. Well that's nice an annoying. I'd guess that this wasn't something that was caused by the Terminal if it went away after a reboot.
Since #7467 is so similar, I'm gonna close this as a dupe. Maybe in the future, someone will figure out what happened here.
Thanks for following up!
/dup #7467

Ah. Well that's nice an annoying. I'd guess that this wasn't something that was caused by the Terminal if it went away after a reboot.
Since #7467 is so similar, I'm gonna close this as a dupe. Maybe in the future, someone will figure out what happened here.
Thanks for following up!
/dup #7467

Just experienced the exact same issue with netsh launched from PowerShell 7.1.3 running in a Windows Terminal Preview 1.7.572.0 tab. In another (new) tab, the issue cannot be repro'ed.


Update Sam's twitter handle link in the README

probably the smallest PR of all time 🙂
thanks for making this plugin!

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.