Seriously rework release.nix, include dev scripts for all platforms

It's jolly annoying when Hydra builds all our packages but doesn't build the dependencies of some of the dev scripts you use. Similarly, although the hlint test will pass on darwin iff it passes on linux, running it on both means that the dependencies are definitely in the cache for local use.
The solution to this is conceptually obvious: add them to release.nix. However, in practice in the process of understanding what on Earth was going on in there I more or less rewrote it to something that makes more sense.
However, we'll have to see what Hydra makes of it...

I had to disable a few things on darwin, but we're a lot closer to it being good now.


SSL/TLS invalid cert

The server currently hands a cert that is only valid for the domain names:
DNS Name: brainpower.rip
DNS Name: www.brainpower.rip

A redirect from http to https pages would be nice, too.

Currently https://diff.pics redirects you to brainpower.rip too - which is a slight issue when using HTTPS everywhere.

This should be fixed now

@Fugiman the redirect's fixed, but all the assets are loaded via HTTP and blocked 😢


fix broken link

This change is

http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/5ca3409c64d4ffc4ae157e6a1c7b876184aa4f3a/


Compilation error with null safety

Upgrading my project using worker_manager from 4.0.0 to 4.0.1 leads to this compilation error:
../../../.pub-cache/hosted/pub.dartlang.org/worker_manager-4.0.1/lib/src/task.dart:12:27: Error: The parameter 'runnable' can't have a value of 'null' because of its type 'Runnable<A, B, C, D, O>', but the implicit default value is 'null'.
 - 'Runnable' is from 'package:worker_manager/src/runnable.dart' ('../../../.pub-cache/hosted/pub.dartlang.org/worker_manager-4.0.1/lib/src/runnable.dart').
Try adding either an explicit non-'null' default value or the 'required' modifier.
  Task(this.number, {this.runnable, this.workPriority});
                          ^^^^^^^^
../../../.pub-cache/hosted/pub.dartlang.org/worker_manager-4.0.1/lib/src/task.dart:12:42: Error: The parameter 'workPriority' can't have a value of 'null' because of its type 'WorkPriority', but the implicit default value is 'null'.
 - 'WorkPriority' is from 'package:worker_manager/src/work_priority.dart' ('../../../.pub-cache/hosted/pub.dartlang.org/worker_manager-4.0.1/lib/src/work_priority.dart').
Try adding either an explicit non-'null' default value or the 'required' modifier.
  Task(this.number, {this.runnable, this.workPriority});
                                         ^^^^^^^^^^^^
../../../.pub-cache/hosted/pub.dartlang.org/worker_manager-4.0.1/lib/src/executor.dart:81:23: Error: The argument type 'num' can't be assigned to the parameter type 'int'.
    final task = Task(_taskNumber,
                      ^
../../../.pub-cache/hosted/pub.dartlang.org/worker_manager-4.0.1/lib/src/executor.dart:156:7: Error: The argument type 'num' can't be assigned to the parameter type 'int'.
      _taskNumber,
      ^

I don't even have to use the plugin - these errors trigger as soon as I import package:worker_manager/worker_manager.dart in a file migrated to null-safe dart.

Please, update your dependencies and check pubspec.lock , thx!


Fix truncation of microseconds in iso8601 date inputs

Also fixes forced conversion to UTC as noted by @ianozsvald here

Coverage increased (+0.02%) when pulling 8f0791a13c98f5bb563b32c44f84b3f509ee63cb on dtfix into bf983cf706c9f55e5789f621f2ce9182f01d9636 on master.


Add some examples of getting token and using resource and storage clients

compute and network clients are TBD.

:+1:  Thanks for starting in on some of the docs for this.


Mupx bypasses ufw firewall rules. Can I config in mup.json?

When deploying with mupx, it seems to open up the firewall, regardless of how I have ufw setup. The issue is really that I don't want the meteor server reachable on both network interfaces of the machine. Can I configure the firewall or port binding options within the mup.json file? Since I'm already using ufw, I would prefer all of the firewall config to be done there.
Thanks,
Jay

Just tried adding BIND_IP="private_ip" to the mup.json file, but mupx could not verify the deployment.

I think the new version at kadirahq/meteor-up is already or going to have hooks, which might be a good way to make that happen?

Ok, I fixed this, but for mupx to be truly "production quality" something needs to change. This issue with docker publishing services in such a way that existing iptables rules are bypassed is a known problem that's been plaguing sysadmins for some time now. The easiest fix, from a mupx standpoint, would be for the /etc/default/docker file to be automatically edited and the following configuration added:
DOCKER_OPTS="--iptables=false"

This of course would mean that, if there is a firewall in place, a rule would need to be added to allow traffic to the meteor server's port. With ufw, it's simply something like:
ufw allow to <ip_address> port <meteor_port>

Because mupx binds the meteor port to all interfaces, and because the "Verifying deployment" step uses the loopback interface to do the verification, a mupx install will succeed without the firewall rule in place (which is a good thing I think). Therefore, all that's needed is to disable docker's iptables editing and to possibly inform the user that they might need to add a firewall rule to allow traffic.

You should make this optional feature request over at the new version where the development developers reside and monitor such comments kadirahq. I'm sure PRs are welcome as long as its none breaking and optional or at least optional to make a breaking change default at their discretion.
Thanks for the insights either way.
Glad to hear you resolved your issue.


App Release | App manager is allowed to upload duplicate roles

These are the following backend issues. (https://github.com/eclipse-tractusx/portal-backend/issues/868)
Issue #1

Users are allowed to upload the same CSV file with the same Role values any number of times, resulting in the same roles being repeated multiple times in the app's role list.
Current Behavior: The same role being repeated n times in the list and also does not allow to delete of the role.
Expected Behavior: It should ignore the duplicate role and also deletion of each recently uploaded should be working.

Steps To Reproduce:

Login to the Portal as App Manager
Register an App
Add/Input all the required data
Under Technical integration --> Download the CSV template and then upload it
Delete the recently uploaded CSV template and Upload it again (N Times)

Issue# 2

When the User deletes the uploaded file of roles then uploaded roles are not removed from the list.
Current Behavior: The Uploaded file was removed successfully but its associated roles remain as it is and due to that duplication of roles is happening in the section.
Expected Behavior: The Roles file should be deleted and its associated roles should be removed.

Steps To Reproduce:

Login to the Portal as App Manager
Register an app
Add/Input all the required data
Under Technical integration --> Download CSV template and then upload it back
Delete the recently uploaded CSV template
The roles will be unchanged. (The attached file's roles should be removed )

Proposed Solutions

While Onboarding a New App: At the Technical Integration step
Backend: API exists to upload the App Roles but the backend would need to change the API and ignore the duplicate role values while uploading the roles to the server

While Onboarding a New App: Delete all roles that were recently uploaded by the .csv file
Frontend: Frontend would be integrating this API and passing all the recently uploaded role's IDs to the API to delete the roles

While updating the Onboarded App: Delete all the roles that were recently uploaded by the .csv file
Frontend: Frontend would have to identify the recently uploaded roles (because in case of an update, already assigned roles would already be part of the app) and then pass the recently uploaded role IDs to the API to delete them from the database

@ss-nikunj  can we close this ? respective PR is merged


Prepare for pheomenolgy of autism working group

Summary
We've been invited by autism professor Jonathan Green to present on AutSPACEs and citizen science for a working group on the phenomenology of autism. The audience will be researchers, members of Autistica and autistic collaborators.
Deadline
The event takes place on the 25th April
What needs to be done?

[ ] Prepare and review presentation

Bastian Greshake and Georgia Aikenhead – The Turing Institute Platform for broad reach of experience. We have 20 minutes in the programme Jonathan sent through - may be useful to have time for discussion as well
Working on the slides here: https://docs.google.com/presentation/d/13R0qqtmH55LsZyTjWlzO_dGQ4UVMpCV7YDEjsH8_NGM/edit?usp=sharing

I think the 6 minutes was an original plan we made but looking at the schedule we have 20 mins (2:55-3:15). Jonathan also asks if there's anyone else we think we should invite - perhaps Susanna or James and maybe also Lucinda?

Presentation is currently 22 minutes

Right, I think the 20 minutes are the whole slot though, which I guess should include time for Q&A/discussion. Given the small group it would probably be best to leave at least half of the time for the discussion as there's a concrete overlap in interests!

Yep, agreed! I emailed Jonathan to double check but it would seem most useful to have discussion time

So should we aim for around 10 minutes/20 or so slides?

Yes, I would aim for 10 minutes presentation including AutSPACEs as an online platform, so I would keep the introduction/context quite low and no more than 1-2 minutes and really use the screenshots of the platform to talk about some of the design issues to motivate why AutSPACEs works as it does!

Here's an updated version: https://docs.google.com/presentation/d/13R0qqtmH55LsZyTjWlzO_dGQ4UVMpCV7YDEjsH8_NGM/edit?usp=sharing

There's still a lot of slides but I think they should be fairly quick to run through!

okay, looks good to me!

We went to the event and gave the talk! 🎉


PhpUnitSetUpTearDownVisibilityFixer - introduction

This fixer changes the setup and teardown function of phpunit classes to protected, to match its parent.
As talked about in #2538
This is ready for review

@keradus @SpacePossum Is this good for the next release, or are there still things that need to be fixed?

@BackEndTea please pull my commits in if you want to keep up working in this.
I think this looks good, but we've to wait for people to find the time to merge and release and such, please be patient with us, busy days! :)

No problem, just wanted to make sure that you weren't waiting for something from my side.

@BackEndTea
@SpacePossum , please finish review

I finished my review 19 days ago, we are waiting for a second OK

ah, didn't saw your approval on PR ;)

Thank you @BackEndTea.

Thank you @keradus @SpacePossum


Linked entrypoint command link to the right page#21139

Reference issue: https://github.com/kubernetes/website/issues/21139
Description:
File modified: web-ui-dashboard.md
Line no: 122
Local deployment:
The entrypoint command link navigates to the link shown in the address bar:

/assign @zacharysarah


gh-573 Update built-in Markdown editor

Resolves #573
Note: despite requesting multiple reviewers, I think @jamesrwelch should have the final say on how the new editor UI looks/functions. Other reviewers may leave feedback on the code changes.

Move HTML and Markdown controls to a new content module
Refactor markdown-text-area component

Clean up unused code
Simplify insert text functionality

Add new toolbar with common Markdown actions. Supports:

Bold
Italic
Heading
Block quote
Bullet and numbered lists

Improve link dialog selection and text insertion
Fix style of blockquotes
Change markdown preview to swap editor and preview panes
Add keyboard shortcuts
Add placeholder text
Add new tests to verify some of the editing functions of the Markdown editor

Screenshots

Sorry, @pjmonks - would you be able to resolve the conflicts on this one again please?  I promise I'll review it before any more PRs are accepted!

This is a really good piece of work.  Some minor comments as I'm going through:

@jamesrwelch Thanks for this feedback.
For two of your points - toggle/untoggle bold and inline vs block insertion - I should point out this is very basic/minimal text insertion. I looked at some source code for Markdown editors you could install instead and they all have some level of "intelligence" as to what is currently entered, specifically state tracking - is the cursor within a bold statement or not, what current numbered item in a list you're in etc. This is too complex for me to look into at the moment so I chose to do plain text insertion and hope the user could at least see the syntax each command uses to identify what they should do. Not ideal, but otherwise I see either a new task to fix these or look into a 3rd party library.
Your other 3 points I think I can easily put in though - preview pane max-height, correct keyboard shortcuts and insert a standard link. For the keyboard shortcuts, it would be useful to me if you gave me a list of what you would expect to use on a Mac for each command since I don't use a Mac myself.

For the keyboard shortcuts, it would be useful to me if you gave me a list of what you would expect to use on a Mac for each command since I don't use a Mac myself.

The same as you have, but using Cmd rather than Ctrl.  I think this might help:  https://stackoverflow.com/questions/3902635/how-does-one-capture-a-macs-command-key-via-javascript

Updates after feedback:

Preview pane has a minimum height now
New command added - insert standard link [link text](http://url)
Updated the keyboard shortcuts to also make sense on Mac OS too - @jamesrwelch please confirm these work as I cannot test them

Keyboard shortcuts are:
Mac OS:

'Bold (⌘ + B)',
'Italic (⌘ + I)',
'Heading (⌘ + H)',
'Quote (⌘ + \')',
'Numbered list (⌘ + Shift + L)',
'Bullet list (⌘ + L)',
'Link to URL (⌘ + K)',
'Link to catalogue element (⌘ + Shift + K)'

Other:

'Bold (Ctrl + B)',
'Italic (Ctrl + I)',
'Heading (Ctrl + H)',
'Quote (Ctrl + \')',
'Numbered list (Ctrl + Shift + L)',
'Bullet list (Ctrl + L)',
'Link to URL (Ctrl + K)',
'Link to catalogue element (Ctrl + Shift + K)'


[BUG] Metadata Injection in PromptTemplate Collapses into Single contents Variable and placeholder substitution doesn't work. Documentation missing.

During my conversion of the Devoxx 2024 demo code from VertexAi to OpenAi, I ran into a bug regarding prompt injection using placeholders.
When using the PromptTemplate class with metadataKeysToInclude to inject metadata fields into a prompt, the selected metadata fields are collapsed into a single "contents" variable rather than being exposed as individual variables. This behavior makes it impossible to reference specific metadata fields directly in the prompt, as only the combined content is accessible.
Expected Behavior:
Metadata keys selected via metadataKeysToInclude should be available as individual variables in the template, allowing for direct injection into the prompt.
Current Behavior:
The metadata fields selected by metadataKeysToInclude are collapsed into a single "contents" field, making it impossible to reference them individually.
Steps to Reproduce:
Checkout my fork _https://github.com/bbottema/conference-2024-devoxx.git_ at commit 1533186cfcfc74dab93c22360ac5995d1d88ef3c. Provide System env variable OPENAI_API_KEY.

Run the test that populates the quotes store: _39_custom_ingestion.java#shouldIngestDocuments().
(to speed this up and make debugging easier, consider limiting the quotes to a single one by changing return result to return result.subList(0, 1); in AbstractDevoxxTest.java#loadQuotes(String))
Run the test that demonstrates metadata injection using this store: _44_query_content_injector.java#shouldRetrieveDocument()

Observe that the LLM response will likely (in the case of GPT) mention that you should fill the %s placeholders, meaning the placeholders were not resolved. Further observe during debugging that the metadata fields, such as "md5" and "document_format", are collapsed into a "contents" variable internally rather than being injected into the prompt as individual fields.

It seems like there might be placeholders ("%s") in the information you provided, which are typically used to fill in specific details. Could you provide more context or specific details for a more complete answer?
Process finished with exit code 0

The specific api usage in the Devox 2024 demo code is the following snippet:
// Enhance the content retriever to add meta data in the prompt
RetrievalAugmentor retrievalAugmentor = DefaultRetrievalAugmentor.builder()
        .contentRetriever(contentRetriever)
        .contentInjector(DefaultContentInjector.builder()
                .promptTemplate(PromptTemplate.from("The document is about %s. The MD5 hash is %s."))
                // %s seems wrong, but {{document_format}} doesn't work either
                .metadataKeysToInclude(asList("document_format", "md5")) // folds into the 'contents' variable
                .build())
        .build();

Expected Result:
The metadata fields should be accessible as individual variables in the prompt (e.g., %s or {{metadata_field_1}}, {{metadata_field_2}}), allowing direct injection of values such as "md5" or "document_format".
Actual Result:
The metadata is collapsed into a single "contents" field, and individual metadata fields cannot be referenced directly in the prompt.
Possible Cause:
The issue seems to originate in the PromptTemplate.apply() method:
public Prompt apply(Map<String, Object> variables) {
    ensureNotNull(variables, "variables");
    return Prompt.from(template.render(injectDateTimeVariables(variables)));
}

Here, the metadata fields are being collapsed into the "contents" field, rather than being made available as separate variables in variables.

As you can see the metadata was successfully selected from the embedded chunks in the store, but they are not made available for template injection. Rather, they were resolved directly inside the contents variable.
Here's more details on the internals during debugging:

Here you can see that the template from the Devoxx demo uses %s template variables, while langchain4j internally uses inDoubleCurlyBrackets to fill in placeholders. Furthermore, as you can see, again, the selected metadata fields are not accessible to begin with, as they have been folded into the contents variable.
Suggested Fix:
Expose Metadata Fields Individually: Modify the logic to ensure that metadata fields selected via metadataKeysToInclude are accessible as separate variables in the prompt. Additionally, consider supporting %s and apply the selected fields in respective order.
Also, the documentation on this feature is empty:

Environment:

langchain4j version: 0.35.0
Java version: OpenJKD 23.0.1 (target Java 21)

Hi @bbottema, PromptTemplate.from("The document is about %s. The MD5 hash is %s.") is incorrect. It should have userMessage and contents placeholders like so: PromptTemplate.from("{{userMessage}}\n\nAnswer using the following information:\n{{contents}}");. This is indeed poorly documented, thank you for highlighting this, I will address this asap.
Regarding the ability to reference each individual variable, please open a feature request. You can also customize the behavior by extending DefaultContentInjector and overriding one of the format methods.

Please read my bug report carefully. {{userMessage}} also does not work with metadataKeysToInclude, as the selected metadata fields are not exposed for template substitution, instead they are folded into the contents variable, appended at the end.

Hi @bbottema

Please read my bug report carefully. {{userMessage}} also does not work with metadataKeysToInclude, as the selected metadata fields are not exposed for template substitution, instead they are folded into the contents variable, appended at the end.

As of now, metadata fields cannot be referenced in the prompt template. Setting metadataKeysToInclude just specifies which metadata keys should be appended to the contents block. This is not a bug, it works this way. If you wish to have more customization, you can either implement your own ContentInjector or extend DefaultContentInjector and override some methods.

This statement confuses me. Do I have it correct that the example demonstrated by Guillaume Laforge (Google) and Cédrick Lunven (DataStax) at Devoxx 2024 in Belgium is not currently supported by langchain4j? Did they use some kind of beta release or experimental branch? Here's the exact timestamp of the demo where they skim over this example.

I am afraid the example shown in the demo is not correct and does not work, unless there was some custome logic added. cc @glaforge @clun

Ok, well I'm not currently in need of this feature, so will leave the feature request to someone with a valid use case. I'll just remove this example from the demo project and continue my OpenAI conversion with the rest.
Thanks for confirming. And btw, I love langchain4j! It's so easy to make your own advanced RAG system with this.

@bbottema thank you! I've already added a javadoc note and will update the documentation with more details soon.
@glaforge @clun could you please update the example in your demo repo? 🙏

@glaforge @clun bump


refactor(transformer): rename OxcVec to AVec

use oxc_allocator::Vec as AVec as per naming convention suggested in https://github.com/oxc-project/backlog/issues/120

#6737  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @overlookmotel and the rest of your teammates on  Graphite

@Dunqing I don't know what you think of AVec? Is it too mysterious? Maybe AstVec would be better? I don't really mind what name we choose, but I think most important thing is to be consistent.


Update laravel-exception-handler for Laravel 5.3

I made some small changes to fix issues with Laravel 5.3

Thank you 👍


Removed dependency on Microsoft.IdentityModel.Clients.ActiveDirectory

Removed dependency on Microsoft.IdentityModel.Clients.ActiveDirectory/
Created WebRequestHelper class to help deal with making web requests and getting response.

@dev-kiranbanda
Once #62 goes in... I'll re-review this one for approval.

Please discard this PR - this is a draft PR for my comparison. We can close this PR. My other PR ( #62) already contains this change too :)


Feature: make DeskPad UX like Parallels

It would be nice if we could find a way to make DeskPad act less like a video output and more like an interactive VM. That might include:

[ ] moving mouse over DeskPad window actually transports it to the DeskPad Display
[ ] if you create a new window when DeskPad is focused, that window always opens on the DeskPad Display
[ ] if your mouse goes to any edge of the DeskPad window, it transports to the primary display

This app is a wonderful concept, will work great on my ultrawide monitor when I need to be able to share my display on a zoom call without it being at an insane aspect ratio.
For the above list of things, @lukepighetti do you have experience building applications to have that kind of behavior? I'm not very familiar with building Mac Apps like this, but am compelled enough by those features you wrote to explore what it would take to make it work that way.

This request is partially addressed in https://github.com/Stengo/DeskPad/pull/16. The lacking feature is to detect if the cursor is on the edge of the virtual cursor. In that case, we want to move the cursor to the display where the visible window is shown in the position corresponding to the edge of the window.
While the pull request is accepted, you can test the features in https://github.com/EarlOrlando/DeskPad/tree/earl/new_features.

Hey there! Just wanted to express how much I love this app. It's been a game-changer for my setup, especially when sharing my screen on MS Teams. Without it, my widescreen would feel underutilized. DeskPad really simplifies the process.
I'm excited about the potential for additional features. Implementing some of the suggestions from other users would definitely enhance usability and productivity.
One feature I'd particularly like, echoing @lukepighetti   's suggestion, is having the mouse automatically transition out of the virtual display when reaching the edge. Alternatively, having a shortcut in DeskPad to move the mouse out of the virtual display would also do the trick.
My 2 cent productivity tip: try using DeskPad alongside RectangleApp or a similar tool. You can set up shortcuts to quickly move windows between displays, further streamlining your workflow.

Thanks so much for your great work!


Error searching with piratebay - flexget-20.10.42

Expected behaviour:
Actual behaviour:
2017-05-08 17:00 ERROR    discover      trakt_movies_search Error searching with piratebay: Tried to set title to [email\xa0protected]

Steps to reproduce:

Step 1: ...

Config:
  trakt_movies_search:
  #
    template: movie
    priority: 3 # run after the movie queue fill task
    discover:
      what:
        - movie_list: traktmovielist
      from:
        - extratorrent:
            category: movies
        - iptorrents:
            rss_key: '{? iptorrents.passkey ?}'
            uid: '{? iptorrents.uid ?}'
            password: '{? iptorrents.pass ?}'
            category: Movie-HD-Bluray
        - piratebay:
            category: "highres movies"
            sort_by: seeds
        - rarbg:
            category: [ 42, 44, 45 ]
      interval: 1 hour
    list_match:
      from:
        - movie_list: traktmovielist

Full config: https://pastebin.com/4znLdZpY
Log:
2017-05-08 17:00 ERROR    discover      trakt_movies_search Error searching with piratebay: Tried to set title to [email\xa0protected]

Additional information:

Flexget Version: 2.10.42
Python Version: 2.7.3
Installation method: pip
Using Daemon? no
OS and version: Raspbian Jessie
Link to crash log:

This would seem to be coming from torrents such as e.g. this. A better example is one I found on Kickass Torrents.

Could be. I didn't get those errors before I updated my Flexget though (from a much earlier version), so it's something which has been introduced fairly recently.

What's up with those titles? And is this even a bug then?

Sounds more like bad data quality in the torrent names...
On Thu, May 11, 2017 at 7:17 PM, Or Carmi<EMAIL_ADDRESS>wrote:

What's up with those titles? And is this even a bug then?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/Flexget/Flexget/issues/1816#issuecomment-300857132,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AT9Ev8gTSF17bzzdXt9khk-3b1qGqoIfks5r40LGgaJpZM4NUKhv
.

I agree


Upgrade to golang 1.19/SDK 1.26

ref: https://github.com/openstack-k8s-operators/openstack-operator/pull/149

/assign @dprince
/assign @stuggi


Removed the problems empty array as it was useless.

Description of Work
Fixes #57
Removed the problems empty array. The problem object data is included in the test_results object so there was no use for it to be passed separately.
Testing Instructions

Run example_runScripts.py in the mantidpython terminal.
Check if the produced tables are the same.

I have merged in master but running the example script I get the error
C:\Midlertiddig\fitbenchmarking\fitbenchmarking\fitting_benchmarking.py in do_fitting_benchmark(nist_group_dir, cutest_group_dir, neutron_data_group_dirs, muon_data_group_dir, minimizers, use_errors, results_dir)
     94                        for problem_block in problem_groups[group_name])
     95
---> 96     probs, results = list(zip(*prob_results))
     97
     98     if len(probs) != len(results):

ValueError: too many values to unpack

I was thinking of adding all the @returns in issue #77 since I want to discuss some particular things about function descriptions.

As discussed


support for editing on mobile devices

Comment needs to be added somewhere that mobile editing does not work (perhaps the info on minimum screen width needs to be added too).

when working on this, fonts should be loaded dynamically as needed to save bandwidth (over 50MB).

New beta GUI editor will be responsive.


Scale animation differences

I have trouble to use the scaling when using ".animateScaleAndCenter(scale, point)", for the same scale value, the more the screen resolution is, the more the viewable area is.
The documentation is not clear about that, how it is working exactly ?
Basically I want to zoom to see a frame of the image, I have a "Rect object" with source coordinate.

The scale is a ratio of screen pixels to source image pixels, so it will vary with screen density. To show a rectangle, you can calculate the width or height of your rectangle in source image pixels, then calculate a scale based on the screen width.


Reproducible / Deterministic PDF output not possible

A deterministic PDF output is important for e.g. binary diff of the output files which have actually the same content as well as for automatically generated pdfs stored to repositories. Using pdfcrop would generate PDFs with a varying ID which is not even possible to be removed by editing the meta information.
The varying ID is caused by the varying temporary name of the texfile used by e.g. pdftex.
A program option to prefix the tex source code would
\pdftrailerid{0}
solves this problem.

Hm, yes sounds like a good idea. How do you set the creation date etc? With SOURCE_DATE_EPOCH? Or do you need an option here too?

Yes, SOURCE_DATE_EPOCH was my first attempt. This also worked as far as I remember.
Currently, I'm simply using the script below to remove all other meta information of a pdf. It's not really nice, but it works. Only the varying ID by using 'pdfcrop' turned out to be the final problem.
A more general solution in 'pdfcrop' might be to provide the possibility to add arbitrary tex code to the one which is automatically generated. Then everyone can add whatever tex commands he/she likes.
#! /bin/bash
TEMPFILE_QPDF=mktemp
for i in find $@ -name "output_*.pdf"; do
echo "+ Removing metadata: '$i'"
    # Remove metadata
    OUTPUT=`exiftool -overwrite_original -all= "$i" 2>&1`
    EXIT_CODE=$?

    if [[ $EXIT_CODE != 0 ]]; then
            echo "************************************"
            echo "An error occurred in 'exiftool' with exit code $EXIT_CODE"
            echo ""
            echo "$OUTPUT"
            echo "************************************"
            exit $EXIT_CODE
    fi

    OUTPUT=`qpdf --deterministic-id "$i" "$TEMPFILE_QPDF" 2>&1`
    EXIT_CODE=$?
    if [[ $EXIT_CODE != 0 ]]; then
            echo "************************************"
            echo "An error occurred in 'qpdf' with exit code $EXIT_CODE"
            echo ""
            echo "$OUTPUT"
            echo "************************************"
            exit $EXIT_CODE
    fi

    mv "$TEMPFILE_QPDF" "$i" || exit 1

done

Dear Ulrike,
I just figured out another corner case where the bit-wise reproducibility is not given.
It's not only
\pdftrailerid{0}
which needs to be added, but also
\pdfsuppressptexinfo15
to ensure a deterministic output.
Cheers, Martin

Pandoc is trying to address this issue too. They have different experimental solutions for the different Tex engines which you may find helpful. :-)


Implement infiniteScrollDisabled property (Issue 17)

This PR adds the infiniteScrollDisabled property as discussed in #17.

@orizens Do you have a planned release date for the 0.2 Milestone?

In about 2 weeks

Rebased on current master

hi @zoehneto
i release a mid release - 0.1.91 to make the last updated available sooner.
please make sure this feature aligns with the new code.
Also, i'm asking whether the use of ngOnChanges is necessary now?

I have already rebased on the latest code, only the tests are failing (should be fixed by PR #64). The ngOnChanges is necessary to detect changes in the bound variable at runtime (to make it dynamic).

Rebased on latest master again

hi @zoehneto
i made important updates to master. can you please update?

Rebased on current master.


Handle repo ownership transfer

Today I transferred brainy-table from my personal GitHub account to the organization I belong to. Now I'd like to unpublish old element reference from catalog, or to implement redirect (not sure that's really important right now, but still).
The repo was unpublished from bower registry, then transferred and re-published again. Strangely old link resolves to one of the older tags (1.1.2) in the title and lesser stars than repo actually has. Is it some king of caching issue?
/cc @samuelli

It has actually updated on the site, but the old version under web-padawan/brainy-table is likely being cached in your browser.


[MINOR][TESTS] Replace CONFIG_DIM1 with CONFIG_DIM2 in timestamp tests

What changes were proposed in this pull request?

A followup of #33640, it looks like the test purpose has 2 different dimensions
Why are the changes needed?

test fix
Does this PR introduce any user-facing change?

no
How was this patch tested?

existing tests
Was this patch authored or co-authored using generative AI tooling?
no

Merged to master.


Can't Detect Camera

After running the scene successfully, camera is not detected neither in the Camera of Windows nor in SharpCap Software. Kindly Help!

I also see that the camera is not detected everywhere. But I can see it on this online tool: https://it.webcamtests.com/


How to add attribute in request for downstream service?

I am trying to add request attribute for downstream service.
  exchange.getAttributes().put("test-attribute", "test");

But it is null when I try to get it by request.getAttribute("test-attribute"); in the downstream service.
Could anyone teach me how to do that?

Attributes don't go downstream. They are a webflux construct that allows passing of data during processing of a request. To pass something downstream it needs to be in a request parameter, header or body.

@spencergibb  I am poor at webflux, Could you give me more info/


add new user: the code to cut and paste into console

Hi: where do I get the "code", to cut and paste into the Developer console in Chrome?
"the code" is an image on this github page, so unavailable to cut.  Is it available somewhere I can cut from?
the "code" I am referring to is
var code captcha div... .. blah blah blah
apologises if I am being super daft.

It's printed to the console when you run user creation from the command line.
It's printed to the webpage when you run the tool in web server mode.  The screenshot in the readme is from this page


How to use getStyles function?

The docs say that I can look at inline style properties defined on a component using the 'getStyles' function. I'm not quite sure how to use this function on the component (or in fact on how to apply a function to any component). Can you please assist? Thanks.

That's only to point you to where the styles are being generated. You don't have to use them. you can pass any style you like via the style prop.

My intention was to use it to figure out which styles were being applied so i can learn and use it in my own designs.

@ee7klt Well that's a hard question, because right now, styles are counted as implementation detail. and aren't entirely documented. so you shouldn't relay on them so much. if you want to override them, you can do via the css className prop or the inline style prop.

getStyles() is an internal API, do not use it.

@ee7klt You may discover what styles were applied by looking at the source code for a component. For example, go to material-ui/lib/lists/list-item.js and find var styles to see the styles related to ListItem component.

getStyles() is an internal method, do not use it.

Then I think someone should update the docs:
"If you would like to add additional styling via CSS...Take a look at a component's getStyles function to see what properties are defined inline."
From: http://www.material-ui.com/#/customization/inline-styles
I +1 this, since it would be really nice to know which inline styles can be customized, before breaking out into CSS...but for now, into the source code I go....

Then I think someone should update the docs

@stephenrs I agree, the docs sounds quite outdated to me. To clarify things, I think that we should highlight the following points:

The getStyle should be considered a private method.
Users can use class names to overrides component, but need to apply the styles as !important.

Regarding the style approach, I think that we need to two following feature in order to make life easier for users:

Style need to be overridable. As highlighted by @alitaheri, you can use the style properties. They should always have a higher priority than the lib styles on the master branch.
On the next branch, the CSS specificity / order should provide the same feature.
As raised by @nathanmarks, it would be good for the style to be an injectable dependency. That's something css libs are really good at. We will investigate this point with the next branch.


Corrected date/time and locale configuration handling.

Ping?

But there are still two unresolved conversations with annoying questions of mine ;-)


Order model creation

Related Issue

Fixes #125

Proposed Changes

Created Order model in the models folder

Checklist

[x] Tested
[x] No Conflicts
[x] Change In Code
[x] Change In Documentation

@D-Ajay-Kumar Make sure to commit less as possible from next time. Commit all the files at once at last.

@D-Ajay-Kumar Make sure to commit less as possible from next time. Commit all the files at once at last.

Yes sure, sorry about that.


Update setup.cfg

Unrelated: Why don't we just skip the failing lock tests as know failures? Are you able to reproduce them locally?

I didn't have the time yet to look into oshmem_ubuntu failing so I didn't want to rule out a shmem4py issue. I reproduced osss_ubuntu failing and it seemed like OSSS is at fault (https://github.com/mpi4py/shmem4py/pull/16)


Crashes

Well the seems to crash a lot on my Samsung Galaxy Amp Prime  so is there anything I can do to fix this

@minislymortal if you updated to 0.15, that is the reason this stopped working.  BL is NOT 0.15 compatible.  If you follow the author on Twitter, you would see this is being worked on.  To prevent him from spending time reading this and closing it vs spending time working on the app, please close this issue.
If not, please post version numbers of MCPE and BL.  You probably have a mixed version issue.

Oh thank you so it was my Minecraft update
On Jun 30, 2016 3:53 PM, "Daniel Rozwood"<EMAIL_ADDRESS>wrote:

@minislymortal https://github.com/minislymortal if you updated to 0.15,
that is the reason this stopped working. BL is NOT 0.15 compatible. If you
follow the author on Twitter, you would see this is being worked on. To
prevent him from spending time reading this and closing it vs spending time
working on the app, please close this issue.
If not, please post version numbers of MCPE and BL. You probably have a
mixed version issue.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/zhuowei/MCPELauncher/issues/1142#issuecomment-229769584,
or mute the thread
https://github.com/notifications/unsubscribe/ATEy3PYTtCNjvDtgUxvMmIuVwD52bijRks5qRB7BgaJpZM4I8Fd1
.

@minislymortal Yes, so as I stated, please close this issue.


Run-time enhancements upgraded to Tomee7

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.0 out of 2 committers have signed the CLA.:x: Amritanshu Kumar:x: amritanshukrAmritanshu Kumar seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


Add 'origin' field to launch events

Lets us differentiate launches from different BinderHub
installations

/cc @betatim

Looks good.
Do you think we need some normalising capabilities or will need them? For example the OVH cluster can be reached via multiple hostnames, should we let the operator of the hub configure how to normalise those (into one hostname?)? I'm tending towards "no".

@betatim hmm, that's a good point actually. I think it might be a good idea to allow that - especially if we want to not expose the hostnames to end users. That'll futz with self.request.host.

@betatim updated


[Trivial] std.path: fix a -dip1000 compilable issue

Without this fix  and
string relativePath(CaseSensitive cs = CaseSensitive.osDefault)
(string path, lazy string base = getcwd())    temporarily attributed @safe
the reported errors are:
std/path.d(1742): Error: scope variable result may not be returned
std/path.d(1748): Error: template instance std.path.buildNormalizedPath!char error instantiating
std/path.d(1800):        while evaluating: static assert(buildNormalizedPath(["/foo/..", "/bar/./baz"][]) == "/bar/baz")
std/path.d(2873): Error: @safe function std.path.relativePath!cast(CaseSensitive)true.relativePath cannot call @system function std.conv.to!string.to!(ChooseResult!(ByCodeUnitImpl, Result)).to
Thus the remainder will be an error from std.conv.to!string.to only.

I won't pursue this PR any more, just closing it

I redid this as https://github.com/dlang/phobos/pull/6357 but I don't see how this PR makes it any more DIP1000 compatible. The return value of the function is always copied into fresh memory.


Feature Request: Add vehicle year in Fleet API vehicle_data endpoint

Per the docs, Pre-2021 Model S and X vehicles do not support the new command protocol, and the Fleet API will continue to work for these vehicles. The model is provided for the vehicle in the car_type field of the Fleet API vehicle data endpoint, but the year of the vehicle does not appear to be present in any Fleet API endpoint.
Can the year of the vehicle be added to the vehicle data endpoint so we can easily determine which cars to use the the Command SDK for and which to use the Fleet API for? We are not using the http proxy.

As a work-around, you can determine this dynamically by:
import "github.com/teslamotors/vehicle-command/pkg/protocol"

err := car.StartSession(ctx, nil)
if errors.Is(err, protocol.ErrProtocolNotSupported) {
    // use REST API
}

@sethterashima yes thanks for the suggestion. It would still be helpful to know the year during user onboarding so it is clear if you need to prompt the user to enroll the public key or not. It is also nice metadata to have to display to the user.

Hi @sethterashima ,
I see you've marked this issue as "completed". Does this mean the vehicle year is now available from the Fleet API vehicle_data endpoint?


Dereference symlinks on state restore

lilv_state_restore's retrieve callback should dereference symlinks by calling readlink.

load a file into a plugin. e.g. /file.test
save state. lilv generates two symlinks:

state-dir/file.test -> externals/file.test
externals/file.test -> /file.test

re-load plugin, restore state.  the plugin uses  state-dir/file.test

Now copy the plugin or save a preset. the file state-dir/file.test is used as new original.  This causes various issues.
Also simply inspecting which file the plugin uses only points to  state-dir/file.test. From a user's POV it would be nice if the plugin would show the canonical path.

Bump! I've just met the same problem.

The related issue:
https://github.com/sadko4u/lsp-plugins/issues/119
It think that using symlinks is completely wrong way.
Instead of such magic a dedicated mapping file can be used.
The benefits: before saving the preset, the file is recreated. Once new mapping is defined, the new record is just added to this mapping file. There is no need to monitor symlinks and manage them.
ilv spoils the file name and replaces it with symlink name on the first state load.
Consider there are two files in different folders 'AgogoHigh-0.wav'. The first one will be replaced as 'AgogoHigh-0.wav' but the second with 'AgogoHigh-0.wav.2'.
That's bad practice since some plugins may expect to receive original file name. Ater state load, the user will see some strange 'AgogoHigh-0.wav.2' in the interface which was never used before:

my 2c: I'd very much prefer to use OS provided features for instead of inventing a custom mapping file, particularly since https://github.com/lv2/lilv/commit/81babb758e614ae622b39849c0c65cf38505a912

my 2c: I'd very much prefer to use OS provided features for instead of inventing a custom mapping file

Several file systems like VFAT don't support symlinks. So if you store the project/preset on such file system, it will be completely malformed.
There is no difference between set of symlinks and one mapping file since both provide <key => value> mapping. But file solution is much better portable. And, moreover, you even don't need to control the removal of symlinks, just overwrite the file with new mapping data when required.
Hardlinks are not portable between volumes, you can not use them to guarantee the consistency of LV2 State/Preset file.

So if you store the project/preset on such file system, it will be completely malformed.

Try it :) lilv falls back to copy the file if links are not available.

Try it :) lilv falls back to copy the file if links are not available.

Moreover, it is inappriate solution. You get:

File copied instead of symlink'ed. Changing original file won't take an effect.
The copy of file will take extra space.
The file will be renamed if it's name collides with another file name.

Yet another case of corrupting session data in Ardour:
https://github.com/sadko4u/lsp-plugins/issues/120

Create new session, create bus, put multisampler_x12.
Open the UI, load some file, close UI.
Perform Session -> rename.
You will already get inconsistent session, without need to close it.

Yes, symlinks are awesome for all kinds of reasons.
That said, this is clearly a problem.  This is still open because I haven't had time to properly look into it, and I don't think effectively mutating state on load time is something to be done blindly/lightly.  That seems like it'd have even more unintended consequences.  Is such a state "equal"?  What if the user themselves picked a symlink (because that's how their content is organized or whatever)?  Is it really okay to completely eradicate any and all symlinking (which is what realpath would do)?  Should states where the user actually selected different paths but they happen to be the same one be equal?  Are there problems with states that aren't superficially equal (in that they have the same paths) being equal on loading?  And so on, and so on.
Then there's the Windows situation.  The obvious way to avoid all of this is to just use absolute paths everywhere, but then state can't be realistically archived/moved at all, which sucks quite a bit.  An option in the API would be good for this, though, but that's an API change.
... etc etc.  I'll try to find time to look into this, particularly since API changes are on the horizon anyway, but I think I need to actually write a half decent test suite and such because this is another thing that doesn't seem like it will end well at all by patching over scenarios in combinations of very complicated hosts and plugins that all do their own things and/or want some particular behaviour in some particular case.  This is a very complex problem space with a lot of trade-offs.
I don't see what a "mapping file" would do though.  If there's no links... mapping to/from what?

Should states where the user actually selected different paths but they happen to be the same one be equal

I think mapping many (virtual) to one (real) paths is possible without any problems. This will save the space if we will make the session 'portable'. Under portable session I mean the session where the files referenced by the state are copied into the project tree that contains such state.

Is it really okay to completely eradicate any and all symlinking (which is what realpath would do)

I think it is a good solution. The benefits:

you just read one file;
the directory does not blow up with symlinks. Many directory entries (which symlinks actually are) -> less performance while accessing to the directory entries;
you can manually edit the file by search&replace;
the solution is portable between any file system since any file system supports text files;
file contents is just replaced on save, no need to manage individual symlinks.

Should states where the user actually selected different paths but they happen to be the same one be equal

No, I think different paths to files should be always considered as different paths. If user does some magic on symlinks/hardlinks, then we should keep that's all on his own.

Are there problems with states that aren't superficially equal (in that they have different file paths) being equal on loading?

I think no.

I don't see what a "mapping file" would do though. If there's no links... mapping to/from what?

Here can be a simple example:
lv2fs://AgogoLow.wav=/path/to/samples/AgogoLow.wav
lv2fs://AgogoHigh.wav=/path/to/samples/AgogoHigh.wav
# etc

When the host archives the state, it just replaces absolute paths with paths to the copies stored inside the session, so we get:
lv2fs://AgogoLow.wav=external_data/AgogoLow.wav
lv2fs://AgogoHigh.wav=external_data/AgogoHigh.wav
# etc

Your responses to the "is it okay to eradicate any and all symlinking" and "should states ... be equal?" contradict one another.
If you want to preserve exactly what the user selected, even if it's a symlink, you can't just ram everything through realpath.

When the host archives the state

The entire point of this design is that anything can trivially archive the state.  Maybe the trade-offs aren't perfect and some of the symlink issues need to be sorted out, but having weird opaque state that needs to be specially handled by the host or LV2 specific tools is a really big burden.  It was avoided very much on purpose.
In any case, I still don't see the point of a mapping file.  If that's the situation, then just store the absolute paths in the state directly.  What benefit does referring to some strange URI in the state, then having to look up in some other file what file that actually refers to bring?

Your responses to the "is it okay to eradicate any and all symlinking" and "should states ... be equal?" contradict one another.

No, they don't. Consider we have a mapping file:
lv2fs://AgogoLow.wav=/path/to/samples/AgogoLow.wav
lv2fs://AgogoHigh.wav=/path/to/samples/AgogoHigh.wav

The plugin knows that lv2fs://AgogoLow.wav refers to some file and lv2fs://AgogoHigh.wav refers to some another file. And it always can obtain their real paths - /path/to/samples/AgogoLow.wav and /path/to/samples/AgogoHigh.wav
BUT the host and the plugin don't even need to take attention of what /path/to/samples/AgogoLow.wav and /path/to/samples/AgogoHigh.wav are. Are these both symlinks or hardlinks, or some other stuff - that doesn't matter. The user is responsible for that these files contain the required data for the plugin.

The entire point of this design is that anything can trivially archive the state

There is a problem of reading key-value file? Even grep/awk can do this.

If that's the situation, then just store the absolute paths in the state directly.

And forget about the portability of the session I suppose?

What benefit does referring to some strange URI in the state, then having to look up in some other file what file that actually refers to bring?

The main benefits are keeping the same behaviour for any operating system and keeping possibility to replace real paths by others from the host side just by editing one file. All other benefits I've provided in the previous post.

The main benefits are keeping the same behaviour for any operating system and keeping possibility to replace real paths by others from the host side just by editing one file. All other benefits I've provided in the previous post.

I don't see how these are benefits compared to just storing the actual paths in the state, all of these things are true then too.  Effectively this is storing the actual paths in the state, just with a bunch of extra complexity.
Can you describe something that would be possible with this, that isn't possible with simply storing the actual paths in the state?

Can you describe something that would be possible with this, that isn't possible with simply storing the actual paths in the state?

I think that by mapping files the plugin delegates to the host the possibility to move the file from one location to another.
From another side, if plugin does not map the file name, it strictly prohibits to change it.
For example, LSP Plugins may map files which are stored internally inside the bundle and do not exist on the file system. The only difference between real paths and builtin paths is that last start with the builtin:// prefix. Changing such paths may break the state of the plugin.

Right, I forgot about paths that don't show up transparently in the state, thanks.
I'm still extremely skeptical of losing all the advantages of the current approach, but that needs to work somehow anyway.

Right, I forgot about paths that don't show up transparently in the state, thanks.
I'm still extremely skeptical of losing all the advantages of the current approach, but that needs to work somehow anyway.

i'd vote for the mapping file as well. I think it's a cleaner approach to let the host manage paths however it wants and plugins would only save some kind of URI or ID given by the host (I'd just use an integer and add 1 for each new file) (or even the file hash!) that the host knows how to translate to the actual file. I mentioned the use of a file pool on IRC before, this is a similar concept.
the plugin should ideally only store a URI/ID/hash that translates to the actual file. the mapping file would keep a path to the actual file and the URI/ID/hash
also I'm not sure if this is already done with the current approach, but there should be a mechanism to prevent access to the same file by different plugins. eg. the host would copy the file to a temporary dir and let the plugin use the copy instead of the original.

Lilv's state interface intentionally does not "let the host manage paths however it wants".  It implements the clean/simple/portable approach that makes normal preset-like bundles, and uses symlinks for the path stuff for the above-mentioned benefits like being transparent to / archivable by every generic tool there is.  The only way some extra mapping file thing is a good idea is if it's literally impossible to make things work otherwise.  I'm not convinced that's the case, and I think y'all are much too keen to throw the baby out with the bathwater here.
That said, you are free to implement state however you want, though I definitely don't recommend doing so without very good concrete reasons.

One behavior could be to dereference the symlink twice in lilv_absolute_path(), for the following logic: if the saved state file is a symlink AND the symlink targets a file in state->link_dir, then dereference the symlink twice and preset the resulting path to the user. state->link_dir does not seem populated (I'm using Ardour master as the host atm), that might be the main blocking point for now. I can try to propose something if you feel like it's a proper solution.

It's probably very tedious and platform-specific to be so precise about symlinks, but it might be possible.  I am not sure what the advantage would be compared to just always doing it though?
(At a high level, this is stalled because I'm not really confident to touch it at all.  Only one non-trivial change to the state stuff has been merged in the past few years, and it seemed reasonable, so I did it... and it broke things.  I'm extremely wary of "does what I want for my plugin/host" sort of proposals to the libraries, with good reason.  Tests first.)

It's probably very tedious and platform-specific to be so precise about symlinks, but it might be possible. I am not sure what the advantage would be compared to just always doing it though?

You mean at the plugin level for example? I cannot be sure how the state is arranged within the state directory. One symlink, two symlinks, a file, ... Technically I guess there is a lot of freedom there? If someone uses some other mean that what lilv does now I mean.

(At a high level, this is stalled because I'm not really confident to touch it at all. Only one non-trivial change to the state stuff has been merged in the past few years, and it seemed reasonable, so I did it... and it broke things. I'm extremely wary of "does what I want for my plugin/host" sort of proposals to the libraries, with good reason. Tests first.)

I can understand this, no problem at all :slightly_smiling_face:  I am mostly then putting in a chip in there to argue that the user experience of finding oneself within a "saved state directory" is confusing. If we converge to a satisfactory solution I can try to help implement and test it out.

You mean at the plugin level for example? I cannot be sure how the state is arranged within the state directory. One symlink, two symlinks, a file, ... Technically I guess there is a lot of freedom there? If someone uses some other mean that what lilv does now I mean.

I just mean at the C code level in general.  Full dereferencing (i.e. realpath or GetFullPathName) is a thing you can do mostly anywhere, but I'm not sure about how portable the ability to choose how many "steps" you want to partially-dereference a symlink are.
i.e. there is no "twice" normally.  It just resolves all the way to the not-symlink file if you resolve it at all.

The "twice" is nice because lilv knows that it stores the state with this structure. I could go through all the symlinks to the real path at the plugin level, but you will have corner cases if the file loaded was a symlink in the first place. The output file would not be the file the user loaded, which is again not a great UX (albeit a better one for most users).

It doesn't really know any of that at load time, it just reads files from wherever.  That information would have be stored somehow, e.g. like @sadko4u was saying.  Probably the most consistent LV2ey way to do this would be to put information in a manifest.  That could be done in the state bundle, or even in the link directories themselves.

I'm not able to reproduce an issue here with current Ardour and LSP Multi-Sampler masters.  If I save a preset that uses some external file, the state on disk links to the external file as expected.  Changing the preset again does the same.  If I load the plugin in an Ardour session and save, the state in the session links to externals as expected.  If I close Ardour and re-load the session, this is loaded, and everything looks the same in the plugin UI.
Please provide precise reproduction instructions or close this issue.

Closing as I can not find a problem here, and the original ticket is a description of a proposed solution, not an issue.


Unsupported server args

Why the changes were made
Add unsupported args for the velero server via ConfigMap within the DPA namespace.
How to test the changes made

Run the tests
Deploy oadp with this change, then

Create ConfigMap with some name
Inside ConfigMap create key/value pairs, where key will correspond to the velero server argument name and value is it's value
Create DPA with annotation (replace  to adopt to your ConfigMap:
oadp.openshift.io/unsupported-velero-server-args=<ConfigMap-Name>
Verify the Velero server pod runs velero with the expected flags

Notes:

NonExisting ConfigMap referenced by the annotation will report error
Empty ConfigMap name will not cause override

/test all

/retest

/retest

For existing config map with no quotes in values the default cases did not work for me:
shubham@fedora ~/oadp-operator -  (mpryc-unsup-server) $ oc get po
NAME                                                              READY   STATUS      RESTARTS      AGE
0d14697ee7cbf27b228781c31c6c141a9225f4681ed99252ab37a0c70bx6hwc   0/1     Completed   0             9m51s
node-agent-4bk82                                                  1/1     Running     0             48s
node-agent-f8flz                                                  1/1     Running     0             48s
openshift-adp-controller-manager-759544c68f-wdm22                 1/1     Running     0             9m33s
ttl-sh-oadp-operator-bundle-2181163-1h                            1/1     Running     0             10m
velero-7c585cdf5-pt922                                            0/1     Error       3 (30s ago)   48s
shubham@fedora ~/oadp-operator -  (mpryc-unsup-server) $ oc logs velero-7c585cdf5-pt922
Defaulted container "velero" out of: velero, openshift-velero-plugin (init), velero-plugin-for-aws (init)
time="2024-06-21T16:37:55Z" level=info msg="setting log-level to INFO" logSource="pkg/cmd/server/server.go:199"
time="2024-06-21T16:37:55Z" level=info msg="Starting Velero server konveyor-dev (-)" logSource="pkg/cmd/server/server.go:201"
time="2024-06-21T16:37:55Z" level=info msg="1 feature flags enabled ['EnableCSI']" logSource="pkg/cmd/server/server.go:203"
An error occurred: invalid uploader type ''kopia'', valid upload types are: 'restic', 'kopia'
shubham@fedora ~/oadp-operator -  (mpryc-unsup-server) $ oc get cm my-config -oyaml
apiVersion: v1
data:
  features: EnableCSI
  uploader-type: kopia
kind: ConfigMap
metadata:
  creationTimestamp: "2024-06-21T16:33:01Z"
  name: my-config
  namespace: openshift-adp
  resourceVersion: "99653500"
  uid: c1e32569-966c-457b-8725-2b6092dd74c3
shubham@fedora ~/oadp-operator -  (mpryc-unsup-server) $

For existing config map with no quotes in values the default cases did not work for me:
shubham@fedora ~/oadp-operator -  (mpryc-unsup-server) $ oc get po
NAME                                                              READY   STATUS      RESTARTS      AGE
0d14697ee7cbf27b228781c31c6c141a9225f4681ed99252ab37a0c70bx6hwc   0/1     Completed   0             9m51s
node-agent-4bk82                                                  1/1     Running     0             48s
node-agent-f8flz                                                  1/1     Running     0             48s
openshift-adp-controller-manager-759544c68f-wdm22                 1/1     Running     0             9m33s
ttl-sh-oadp-operator-bundle-2181163-1h                            1/1     Running     0             10m
velero-7c585cdf5-pt922                                            0/1     Error       3 (30s ago)   48s
shubham@fedora ~/oadp-operator -  (mpryc-unsup-server) $ oc logs velero-7c585cdf5-pt922
Defaulted container "velero" out of: velero, openshift-velero-plugin (init), velero-plugin-for-aws (init)
time="2024-06-21T16:37:55Z" level=info msg="setting log-level to INFO" logSource="pkg/cmd/server/server.go:199"
time="2024-06-21T16:37:55Z" level=info msg="Starting Velero server konveyor-dev (-)" logSource="pkg/cmd/server/server.go:201"
time="2024-06-21T16:37:55Z" level=info msg="1 feature flags enabled ['EnableCSI']" logSource="pkg/cmd/server/server.go:203"
An error occurred: invalid uploader type ''kopia'', valid upload types are: 'restic', 'kopia'
shubham@fedora ~/oadp-operator -  (mpryc-unsup-server) $ oc get cm my-config -oyaml
apiVersion: v1
data:
  features: EnableCSI
  uploader-type: kopia
kind: ConfigMap
metadata:
  creationTimestamp: "2024-06-21T16:33:01Z"
  name: my-config
  namespace: openshift-adp
  resourceVersion: "99653500"
  uid: c1e32569-966c-457b-8725-2b6092dd74c3
shubham@fedora ~/oadp-operator -  (mpryc-unsup-server) $

Ok so it seems like the --uploader-type='kopia' is an invalid parameter to be passed. Maybe we should not surround any value at all?

@shubham-pampattiwar ok so I think we need to adjust slightly the way design is defined and implementation.
The problem is with how the args are later passed to the resulting velero Pod->Container spec and the problem is that the args are considered strings, so we have problems with wrapping one string into another.
      image: >-
        registry.redhat.io/oadp/oadp-velero-rhel9@sha256:06482afcea65eff184901c63cbe9fc6e5b3172d23857301ad4e7b4daf362e79c
      args:
        - server
        - '--uploader-type=restic'
        - '--fs-backup-timeout=1h'
        - >-
          --restore-resource-priorities=securitycontextconstraints,customresourcedefinitions,namespaces,managedcluster.cluster.open-cluster-management.io,managedcluster.clusterview.open-cluster-management.io,klusterletaddonconfig.agent.open-cluster-management.io,managedclusteraddon.addon.open-cluster-management.io,storageclasses,volumesnapshotclass.snapshot.storage.k8s.io,volumesnapshotcontents.snapshot.storage.k8s.io,volumesnapshots.snapshot.storage.k8s.io,datauploads.velero.io,persistentvolumes,persistentvolumeclaims,serviceaccounts,secrets,configmaps,limitranges,pods,replicasets.apps,clusterclasses.cluster.x-k8s.io,endpoints,services,-,clusterbootstraps.run.tanzu.vmware.com,clusters.cluster.x-k8s.io,clusterresourcesets.addons.cluster.x-k8s.io

Could you please paste here your broken velero Pod specification?

@mpryc Here you go:
shubham@fedora ~/oadp-operator -  (mpryc-unsup-server) $ oc get po velero-7c585cdf5-7kkkn -oyaml | grep args -7
    kind: ReplicaSet
    name: velero-7c585cdf5
    uid: c0a30d53-227c-4aa4-92dc-7670d9c06329
  resourceVersion: "101617132"
  uid: fb136af6-2c84-4a7e-802a-8d0b1744def9
spec:
  containers:
  - args:
    - server
    - --features='EnableCSI'
    - --uploader-type='kopia'
    command:
    - /velero
    env:
    - name: VELERO_SCRATCH_DIR

@mpryc Here you go:
shubham@fedora ~/oadp-operator -  (mpryc-unsup-server) $ oc get po velero-7c585cdf5-7kkkn -oyaml | grep args -7
    kind: ReplicaSet
    name: velero-7c585cdf5
    uid: c0a30d53-227c-4aa4-92dc-7670d9c06329
  resourceVersion: "101617132"
  uid: fb136af6-2c84-4a7e-802a-8d0b1744def9
spec:
  containers:
  - args:
    - server
    - --features='EnableCSI'
    - --uploader-type='kopia'
    command:
    - /velero
    env:
    - name: VELERO_SCRATCH_DIR

Interesting, ok so we need to modify that part, because it should be more of  - "--uploader-type='kopia'" or  - '--uploader-type="kopia"' .
I wonder how this behaves when it's the string of a format without ', so:
    kind: ReplicaSet
    name: velero-7c585cdf5
    uid: c0a30d53-227c-4aa4-92dc-7670d9c06329
  resourceVersion: "101617132"
  uid: fb136af6-2c84-4a7e-802a-8d0b1744def9
spec:
  containers:
  - args:
    - server
    - --features=EnableCSI
    - --uploader-type=kopia
    command:
    - /velero
    env:
    - name: VELERO_SCRATCH_DIR

@mpryc Yeah I think we need the command without any quotes:
    kind: ReplicaSet
    name: velero-7c585cdf5
    uid: c0a30d53-227c-4aa4-92dc-7670d9c06329
  resourceVersion: "101617132"
  uid: fb136af6-2c84-4a7e-802a-8d0b1744def9
spec:
  containers:
  - args:
    - server
    - --features=EnableCSI
    - --uploader-type=kopia
    command:
    - /velero
    env:
    - name: VELERO_SCRATCH_DIR

@shubham-pampattiwar rebased on a modified design/function and I think it's now correctly handling your ConfigMap as well other args passed. Please review.

/retest

/retest

/hold
review #1423 first

/retest

/retest

/test 4.16-e2e-test-aws

/retest

/retest

/unhold

Squashed all the commits into one and rebased on top of master which now includes #1423. Should be easier to cherry pick to other branch and it's easier to review.

/retest

/retest

PR worked for me with the latest changes:
shubham@fedora ~/oadp-operator -  (mpryc-server-args) $ oc get cm my-config -oyaml
apiVersion: v1
data:
  features: EnableCSI
  fs-backup-timeout: 10h
  uploader-type: kopia
kind: ConfigMap
metadata:
  creationTimestamp: "2024-07-01T23:07:27Z"
  name: my-config
  namespace: openshift-adp
  resourceVersion: "106776916"
  uid: 127a5904-da3f-4917-9483-f8fd177aba7b
shubham@fedora ~/oadp-operator -  (mpryc-server-args) $ oc get po velero-7b8c5dc7df-jr4s9 -oyaml | grep args -7
    kind: ReplicaSet
    name: velero-7b8c5dc7df
    uid: 3f20ea1e-9959-44d2-bf5b-e2ebdc2abe92
  resourceVersion: "106777116"
  uid: 688f8716-e0c0-4787-977c-0d66391acb95
spec:
  containers:
  - args:
    - server
    - --features=EnableCSI
    - --fs-backup-timeout=10h
    - --uploader-type=kopia
    command:
    - /velero
    env:
shubham@fedora ~/oadp-operator -  (mpryc-server-args)

/cherry-pick oadp-1.4


Fixes #1420 : .yaydoc.yml added to support yaydoc

Fixes #1420
Changes: .yaydoc.yml is added for documentation generation and also fixed markdown for proper generation of documentation
Screenshots for the change:

@pri22296 @imujjwal96 please check this

@sch00lb0y Can you share a link to the generated docs

@pri22296<EMAIL_ADDRESS>

@sch00lb0y  Check the global toctree, you'll have to make changes

@imujjwal96 are you asking me to add manual rst ?

Here automatic deploy actually describe INSTALLATION_HEROKU. Change INSTALLATION_HEROKU.MD  by changing # headings to ## and creating a # heading
# Heroku deployment docs or similar

@imujjwal96 @pri22296 I have updated<EMAIL_ADDRESS>

@mariobehling right now I'm fixing all the markdown issues in the sub project. The CNAME will be defined in the main project and it'll get deployed based on the main project configuration.

@sch00lb0y This repo already has a gh-pages branch. Please make sure, that you don't use that.

@mariobehling sure, documentation won't get deployment to the gh-pages


Release 0.3.0

Coverage remained the same at 85.196% when pulling 5ca02787aa54198b21401189c36f52bb8f1a6002 on mziccard:release-0.3.0 into 6daaf593796be51b5314477a0f33671241bf5b82 on GoogleCloudPlatform:master.


Two tasks actives at same time

Is posible to have two tasks actives at the same time? for example, one for Sass processing and another for browser sync??

No. As the name indicates, this is not a task-runner.


Assistance Needed Installation " mvn clean package" Fails

Hello I am trying to follow steps mentioned on website https://onetable.dev/docs/setup
Step 1: I have cloned the repository on machine
Step 2: I have java 11 and man installed on Mac through home brew

mvn clean package

Error

any help would be greatly appreciated or if you guys can provide direct link to jar file that would be great :D

Hi @soumilshah1995
Thanks for opening the issue. Can you confirm which branch you're on? I tried building a jar on main and was able to do so with mvn clean package.
For context:
sagarl@dev onetable % java --version
openjdk 11.0.11 2021-04-20
OpenJDK Runtime Environment AdoptOpenJDK-11.0.11+9 (build 11.0.11+9)
OpenJDK 64-Bit Server VM AdoptOpenJDK-11.0.11+9 (build 11.0.11+9, mixed mode)

sagarl@dev onetable % mvn --version
Apache Maven 3.9.4 (dfbb324ad4a7c8fb0bf182e6d91b0ae20e3d2dd9)
Maven home: /Users/sagarl/Downloads/apache-maven-3.9.4
Java version: 11.0.11, vendor: AdoptOpenJDK, runtime: /Library/Java/JavaVirtualMachines/adoptopenjdk-11.jdk/Contents/Home
Default locale: en_US, platform encoding: UTF-8
OS name: "mac os x", version: "11.5", arch: "x86_64", family: "mac"

sagarl@dev onetable % git status
On branch main
Your branch is up to date with 'origin/main'.

nothing to commit, working tree clean
sagarl@dev onetable %

@sagarlakshmipathy I am on main branch

"Could you please share the JAR file with me, possibly through a Google Drive link? I'm eager to explore OneTable and generate content for others. I would greatly appreciate your assistance in providing the JAR files. Thank you!"

@soumilshah1995 you can find the jars in the packages: https://github.com/onetable-io/onetable/packages/1986830 - you can use the bundled jar in the right hand side of the UI

Tim's referring to

You can then run sync using something like java -jar ~/Downloads/utilities-0.1.0-beta1-bundled.jar --datasetConfig my_config.yaml

Thanks a lot let me try  and play with it and open new issue if I see some weird error :D

@soumilshah1995 you have java version 21.0.1 set in your maven, we both have java 11 on our local.


ERROR in ./node_modules/selenium-webdriver/http/index.js Module not found: Error: Can't resolve 'http' in '/node_modules/selenium-webdriver/http'

'use strict';
const http = require('http');
const https = require('https');
const url = require('url');
const httpLib = require('../lib/http');
-- this is code from selenium-webdriver/http/index.js--

ERROR in ./node_modules/selenium-webdriver/http/index.js
Module not found: Error: Can't resolve 'http' in '/Users/mac/angular/restaurantApp/node_modules/selenium-webdriver/http'
ERROR in ./node_modules/selenium-webdriver/http/index.js
Module not found: Error: Can't resolve 'https' in '/Users/mac/angular/restaurantApp/node_modules/selenium-webdriver/http'
--these are the errors--

package.json
{
"name": "restaurant-app",
"version": "0.0.0",
"scripts": {
"ng": "ng",
"start": "ng serve",
"build": "ng build",
"test": "ng test",
"lint": "ng lint",
"e2e": "ng e2e"
},
"private": true,
"dependencies": {
"@angular/animations": "^6.0.7",
"@angular/cdk": "^6.3.3",
"@angular/common": "^6.0.3",
"@angular/compiler": "^6.0.3",
"@angular/core": "^6.0.3",
"@angular/flex-layout": "^6.0.0-beta.15",
"@angular/forms": "^6.0.3",
"@angular/http": "^6.0.3",
"@angular/material": "^6.3.3",
"@angular/platform-browser": "^6.0.3",
"@angular/platform-browser-dynamic": "^6.0.3",
"@angular/router": "^6.0.3",
"@auth0/angular-jwt": "^2.0.0",
"angular-material-icons": "^0.7.1",
"core-js": "^2.5.4",
"hammerjs": "^2.0.8",
"rxjs": "^6.0.0",
"zone.js": "^0.8.26"
},
"devDependencies": {
"@angular-devkit/build-angular": "~0.6.8",
"@angular/cli": "~6.0.8",
"@angular/compiler-cli": "^6.0.3",
"@angular/language-service": "^6.0.3",
"@types/jasmine": "^2.8.8",
"@types/jasminewd2": "~2.0.3",
"@types/node": "~8.9.4",
"codelyzer": "~4.2.1",
"jasmine-core": "~2.99.1",
"jasmine-spec-reporter": "~4.2.1",
"karma": "~1.7.1",
"karma-chrome-launcher": "~2.2.0",
"karma-coverage-istanbul-reporter": "~2.0.0",
"karma-jasmine": "~1.1.1",
"karma-jasmine-html-reporter": "^0.2.2",
"protractor": "~5.3.0",
"ts-node": "~5.0.1",
"tslint": "~5.9.1",
"typescript": "~2.7.2"
}
}

Hi @karanShinde7 and thanks for submitting this ticket. Could you please give me a bit more context?
What are you trying to do? What is the behaviour you're expecting and what are you seeing instead?
Thanks,
Jan

I found out it was importing the HttpClient class from selenium instead of angular/common/http
more detailed answer here
https://stackoverflow.com/questions/51287558/module-not-found-error-cant-resolve-http-in-selenium-webdriver


docs: update README for application metadata

As I had a hard time finding the right metadata, let's make sure others don't go through the same ;-)

Thank you for your contribution! I'll send another PR fixing the wrong en-us/en-gb we have in our readme file, but lets make sure we don't add any more of them.


Make list styles more specific

This is a cheap attempt to mitigate https://github.com/giantswarm/giantswarm/issues/14826
However it's not the right approach in terms of maintainability. Because it means that these tweaks have to be repeated the next time we want to update the header and footer styles.
Can we somehow ensure that all styles imported for the header and footer are prefixed by .site-header, site-footer so that they only apply to these containers? The side effects can otherwise be unpredictable.
Side notes: Also I noticed there is a lot of redundancy in the CSS we import. And I don't like the fact that we include it as inline CSS in every page instead of having it be part of a CSS file we load once.
So please see this PR as a discussion starter. @ubergesundheit @oponder

Could @giantswarm/chapter-front-end please take a look here?

Could @giantswarm/chapter-front-end please take a look here?


Does not work in Gatsby

Reproduction is simple, start a new gatsby starter project then follow the gatsby instructions on the website. Getting this error:
TypeError: theme.modes is undefined
useLocalStorage
node_modules/bumbag/es/utils/useLocalStorage.js:14

  11 | var _useTheme = useTheme(),
  12 |     theme = _useTheme.theme;
  13 |
> 14 | var isEnabled = theme.modes.enableLocalStorage;
  15 | var get = useCallback(function (key) {
  16 |   if (!isEnabled) return;
  17 |

Bumbag 1.0.2
Bumbag Gatsby Plugin 1.02
Gatsby 2.24.30

Heya! I tried to reproduce your example, but I couldn't get that error to pop up.
Did you make sure to include your <BumbagProvider> in your gatsby-browser.js file?
I have also added a Bumbag Gatsby Example if you wish to take a look at a working example in code.

Closing for now.

@jxom Its still not working as of 1.0.4. Heres a repo: https://github.com/robotmayo/bumbag-repro

Hmm, looks like there were dependency issues with npm... Can you try update to 1.0.8 and try again? thanks.

It appears to be working now as of at least 1.0.8. Thank you.

Woo!


setup sdk

Description
sets up pylons_fultter sdk

@kjawadDeveloper2  request changes have been implemented

@kjawadDeveloper2 changes have been implemented


add BDWTA whitelist

Codecov Report

Merging #21 (0df8e1d) into main (e875b64) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #21   +/-   ##
=======================================
  Coverage   83.92%   83.92%
=======================================
  Files          21       21
  Lines        1773     1773
=======================================
  Hits         1488     1488
  Misses        285      285

Impacted Files
Coverage Δ

ngs_tools/chemistry/SingleCellChemistry.py
93.16% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e875b64...0df8e1d. Read the comment docs.


[FIX ERROR] Refactor for function in plugins/rake-fast/rake-fast.plugin.zsh

WHAT
I modified a condition in oh-my-zsh/plugins/rake-fast/rake-fast.plugin.zsh .
WHY
If this plugin condition is [[ "$OSTYPE" = darwin* ]];,  the case of my stat An error will occur.
My stat doesn't have -c option because I'm using GNU core utilities that was installed in the Homebrew.
ERROR LOGS
My environments:
OS: OS X Yosemite
stat: 8.24 (GNU core utilities)
$ rake [TAB]
Try 'stat --help' for more information.
stat: invalid option -- '%'
Try 'stat --help' for more information.

_rake_does_task_list_need_generating:10: bad math expression: operand expected at `>='
stat: invalid option -- '%'
Try 'stat --help' for more information.
stat: invalid option -- '%'
Try 'stat --help' for more information.
_rake_does_task_list_need_generating:10: bad math expression: operand expected at `>='
stat: invalid option -- '%'
Try 'stat --help' for more information.
stat: invalid option -- '%'
Try 'stat --help' for more information.
_rake_does_task_list_need_generating:10: bad math expression: operand expected at `>='

@robbyrussell How about this changes?

Oops. My title is very long :cry:
Sorry.

Could anyone test this?
Cc: @mcornella @apjanke

This whole logic can be replaced with zsh specific operators. There are -nt (newer than) and -ot (older than) operators that can already do that without using stat. See https://github.com/robbyrussell/oh-my-zsh/pull/1655#issuecomment-67301041

@mcornella Awesome!! Thank you so much for telling me!
I fixed that and squashed commits :dancers:

The return $? line is not needed given that is, by default, what will happen once the function ends: the return code will not change. We can also join the file-exists check and the file-is-newer-than check:
_rake_does_task_list_need_generating () {
-   if [ ! -f .rake_tasks ]; then return 0;
-   else
-    if [[ "$OSTYPE" = darwin* ]]; then
-      accurate=$(stat -f%m .rake_tasks)
-      changed=$(stat -f%m Rakefile)
-    else
-      accurate=$(stat -c%Y .rake_tasks)
-      changed=$(stat -c%Y Rakefile)
-    fi
-    return $(expr $accurate '>=' $changed)
-   fi
+  [[ ! .rake_tasks -ot Rakefile ]]
}

Reasoning behind this from the docs above:

file1 -ot file2
true if file1 exists and is older than file2.

That is, it will return false if either:

.rake_tasks doesn't exist
.rake_tasks is older than Rakefile,

i.e. it will return false when we need to generate the .rake_tasks. We need to return true though, so we put the bang ! operator to negate it and that's all.
Note this means that if .rake_tasks and Rakefile are equally old we will regenerate the .rake_tasks file.

Oh wait, there's a pitfall to that succint version which is if there's no Rakefile the function will also return true. The less abbreviated version is more robust then:
_rake_does_task_list_need_generating () {
-   if [ ! -f .rake_tasks ]; then return 0;
-   else
-    if [[ "$OSTYPE" = darwin* ]]; then
-      accurate=$(stat -f%m .rake_tasks)
-      changed=$(stat -f%m Rakefile)
-    else
-      accurate=$(stat -c%Y .rake_tasks)
-      changed=$(stat -c%Y Rakefile)
-    fi
-    return $(expr $accurate '>=' $changed)
-   fi
+  [[ ! -f .rake_tasks ]] || [[ Rakefile -nt .rake_tasks ]]
}

The return $? line is not needed given that is

yeah, I know. but I though return $? is easy to understand :dash:
however you're right so i will fix that

I fixed that. Thank you for correcting my codes :smile:

Thanks for putting up with my OCD! :grin: Good to go :+1:

I'm happy :smiley:

sweet! thanks for fixing/refactoring @sachin21 :+1:

@KevinBongart Sure! :smile:


Comparison with Instant of u32::MAX is unsound

I try this code on a thumbv7em-none-eabihf target:
defmt::println!("{:?}", TimerInstantU32::<100_000_000>::from_ticks(u32::MAX) > TimerInstantU32::<100_000_000>::from_ticks(1000));

Output:
0.099983 false

Since u32::MAX > 1000, something seems to be wrong inside of const_cmp?

Hi, this looks correct to me.
Instant supports time which can roll over, so the maximum range is MAX/2 - 1.
I think the documentation needs clarification here

And thanks for bringing this to my attention!

Interesting, thanks for the explanation! What do you think about adding an Instant::MAX constant? :)

I see what you want, but it would be difficult.
As every instant is relative another instant there is no absolute MAX value, it's simply MAX/2 - 1 that is the relative offset that is valid.
Does that make sense?

Hmm, I think so. If we would define u32::MAX/2 - 1 as MAX, would it then be true that
Instant::MAX + Instant::from_ticks(1) > Instant::MAX

That is correct.

You can run this test to verify:
    #[test]
    fn yolo() {
        let max = Instant::<u32, 1, 1>::from_ticks(core::u32::MAX / 2 - 1);
        let maxpone = Instant::<u32, 1, 1>::from_ticks(core::u32::MAX / 2);

        assert!(maxpone > max);
    }


feat(carousel): add transition to carousel

There is no transition while slides change.

Any word on this? Seems like all the correct classes are there, but the transition does not work.

To be more specific, there are classes that need to be applied prior to switching the 'active' class. Should be 'prev right' or 'next left' on the upcoming slide before applying 'active', as well as the active slide should get the 'left' or 'right' class depending on direction selected.

Is this fixed now!! I'm having the same issue

I'm still having the same issue

Any updates on that?
Thank you!

I just looked at the bootstrap web sites for V3 and V4 at the demo of the carousel
and at what I am getting from this package and it looks like some markup is missing or wrong that it needs to make the slide transitions work.
the ol / li in the bootstrap sample is like this

but in this package the demo page does not have the data-target and data-slide
I suspect this is part of where it fails to do the effects.
I will try and work  with the code and see if I can make it work like the bootstrap site example and will post back on what I find.

Working on resolving this issue. Seems slides need classes like: left, right, next while transition going

it's funny there are multiple samples of carousels and they all seem to have the same missing feature.
also there is another project that his almost the same as this one that seems to say that there is an issues with animations and angular 2 that is blocking them.
see this:
https://github.com/ng-bootstrap/ng-bootstrap/issues/295
also I found this:
http://mlaval.github.io/angular2-bootstrap/
based on the early versions of angular 2 but it has the slide working !
I am trying to update that to the released angular  code and markup but I am really new to the angular and typescript stuff so it's taking a bit of time to learn how to get it working with the changes .
https://github.com/mlaval/angular2-bootstrap
hope that info helps some,....

just a heads up in case anyone is interested that other carousel almost works but something in the changes fro early to release is messing with my trying to make it work
http://mlaval.github.io/angular2-bootstrap/

any update ?

Any update on this issue? I tried manually add transition style
transition: transform .6s ease-in-out, -webkit-transform .6s ease-in-out, -o-transform .6s ease-in-out;
on .carousel-item but it is not working.

+1

Needs to add the classes: next or prev and left or right after the click for it works.

this will be very nice if we have a release build that works !!

+1

+1

+1

+1

+1

+1

+1

+1

+1

+1

+1
and you can try this components

+1

+1

+1

+1

Nice library, but without animations I will have to switch back to regular bootstrap that relies on jQuery.

in CSS component i added
.animated {
-webkit-animation-duration: 1s;
animation-duration: 1s;
-webkit-animation-fill-mode: both;
animation-fill-mode: both;
}
@-webkit-keyframes fadeIn {
0% {opacity: 0;}
100% {opacity: 1;}
}
@keyframes fadeIn {
0% {opacity: 0;}
100% {opacity: 1;}
}
.fadeIn {
-webkit-animation-name: fadeIn;
animation-name: fadeIn;
}
in html i added

<slide *ngFor="let img of carouselImages; let i = index"  class="animated fadeIn">

it works but the effect look like photo flash..

+1
I started to build an Angular 5 app using the newest Bs (first not ngx bs), but I couldn't control the carousel by jQuery. Then I found ngx bs, but the transition is missing of carousel. :/

I see this is on the roadmap now - NB feature. Hope it's done soon...

+1

So everyone just have carousels that change images without any kind of transition? Any ways to add any kind of transition so it doesn't seem so... sudden and uncontrolled?

I had to switch to use this one instead due to the lack of transition support: https://github.com/sheikalthaf/ngu-carousel
This one works well so far, very customizable.

why ngb-carousel don't take the css classes at the attribute "class" ??

To create sliding animation I've came out with next solution
in main styles.scss add
carousel.smart-slide {
  slide.item {
    animation-duration: 1s;
    animation-fill-mode: both;
    &.active {
      width: 100%;
      animation-name: carouselSlideIn;
    }
    &:not(.active) {
      display: table-cell;
      animation-name: carouselSlideOut;
    }
  }
}

@keyframes carouselSlideIn {
  0% { transform: translateX(100%); }
  100% { transform: translateX(0); }
}
@keyframes carouselSlideOut {
  0% { transform: translateX(0); }
  100% { transform: translateX(-100%); }
}

You can use it than in component like:
<carousel class="smart-slide">
  <slide></slide>
  <slide></slide>
  <slide></slide>
</carousel>

PS: The single problem left is that slides are always moving from right to left, no matter which arrow you've pressed. I will update answer when/if I resolve this

i have modified @griga input and added back animation
html
<carousel (activeSlideChange)="slideChange($event)" >
ts
slideIndex: number;   slideDirection:string = "hold";   slideChange(event){     if(this.slideIndex == undefined){       this.slideDirection = "hold";     }else if(this.slideIndex < event){       this.slideDirection = "forward";     }else{       this.slideDirection = "back";     }     this.slideIndex = event;   }
scss
`carousel{
.item {
animation-duration: 1s;
animation-fill-mode: both;
}
&.forward{
.item{
&.active {
width: 100%;
animation-name: carouselSlideIn;
}
&:not(.active) {
display: table-cell;
animation-name: carouselSlideOut;
}
}
}
&.back{
.item{
&.active {
width: 100%;
animation-name: carouselSlideInBack;
}
&:not(.active) {
display: table-cell;
animation-name: carouselSlideOutBack;
}
}
}
@keyframes carouselSlideIn {
0% { transform: translateX(100%); }
100% { transform: translateX(0); }
}
@keyframes carouselSlideOut {
0% { transform: translateX(0); }
100% { transform: translateX(-100%); }
}
@keyframes carouselSlideInBack {
0% { transform: translateX(-100%); }
100% { transform: translateX(0); }
}
@keyframes carouselSlideOutBack {
0% { transform: translateX(0); }
100% { transform: translateX(100%); }
}
}
`


Pod install error on Xcode 10.2

Getting the following error when trying to do pod install on latest Xcode 10.2
Installing PrettyColors 5.0.2

[!] Invalid `PrettyColors.podspec` file: undefined method `swift_versions=' for #<Pod::Specification name="PrettyColors">
Did you mean?  swift_version=
               swift_version.

 #  from /var/folders/0f/pbyp18ds4psf0d6_37twvfbc0000gn/T/d20190327-39339-1gjgqm1/PrettyColors.podspec:13
 #  -------------------------------------------
 #    spec.source_files = 'Source/**/*.{h,swift}'
 >    spec.swift_versions = ['3.0', '4.0', '4.2', '5.0']
 #    spec.requires_arc = true
 #  -------------------------------------------

I left a line note: https://github.com/jdhealy/PrettyColors/commit/afd4553a4db6f656521cfe9b1f70bece2748c7d8#r32935431

Thanks for the quick reply @ikesyo.


chore: improve linting setup to allow better tree-shaking

This PR applies some of the recommendations from this article, https://madelinemiller.dev/blog/reduce-webapp-bundle-size/, to the setup
The goal of these changes are to provide better safety through TypeScript eslint rules by giving access to type info (the Next config by default doesn't provide actual type information to the parser), and to ensure that the bundler/optimiser can do as much as possible
Tells the Eslint parser that the React import isn't important (as it's not with NextJS)
Uses type imports/exports, to substantially improve tree shaking capabilities
Applies the ESLint rules with pnpm lint --fix
Due to how simple this site is, improvements are minimal, but they prevent problems being introduced in the future

Rebase?

Rebased


Resource metrics

Describe your changes
Added resource & number of resources per tag metrics. Im aware that the changes were already made and most likely wont be accepted but I wanted to create a PR to continue to try and improve and show my work.
Related issue number/link

Fixes #187
Thanks for contributing! 🥳🚀🌳

Yeah, its a dupe of #195. I was wanting to give a proper review of this, but it was really difficult due to the auto-formatting creating large diffs.


need to make "about" and "home" as obvious buttons, put a box around them, cannot see that there is a home menu

Subject: need to make "about" and "home" as obvious buttons, put a box around them, cannot see that there is a home menu
Description:
need to make "about" and "home" as obvious buttons, put a box around them, cannot see that there is a home menu.
make heavy font, not grey font, coloured and grey writing cannot be seen by half of the population.  and make menus as headings, or are not seen.
good that you are using a clean square font already. thanks.
Results:
Backend version: develop-3b94a107
Frontend version: develop-3b94a107
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/96.0.4664.110 Safari/537.36
Page: https://app.couchers.org/profile/edit/home
User: mrmax (8829)

To solve this, we should add hover states to the "about", "home", and "references" navigation tabs on the following pages:
https://app.couchers.org/profile
https://app.couchers.org/profile/edit
We should also add a green indicator symbol (similar to what we do to the messages tab for new messages) to the "about" and "home" tabs if: 1. The user has never visited the page OR 2. They have any empty fields on one of those pages.

The profile pages need to be redesigned in general, closing this incremental req


C#/Bridge difference invoking methods that take DateTimes

Edit The original report was bogus; I was missing [Reflectable]. Now seeing the same behaviour as the original issue I had, so updated...
Deck: https://deck.net/1d3aebefc9eac274e0f1841491c8e0ba
DotNetFiddle: https://dotnetfiddle.net/fHsLRo
Code:
public class Program
{
    public static IEnumerable<object[]> testDataDates => new[] { new object[] { new DateTime(2017, 1, 1), new DateTime(2017, 1, 1) } };

    public static void Main()
    {
        var method = typeof(Program).GetMethod("LogDates");

        foreach (var dates in testDataDates)
        	method.Invoke(null, dates);
    }

    public static void LogDates(DateTime a, DateTime b) {
        Console.WriteLine(a.Year);
    }
}

It should output the current year (and does in DotNetFiddle) but fails in Bridge:
Bridge Console
System.Exception: TypeError: a.getFullYear is not a function
    at LogDates (https://dev.deck.net/RunHandler.ashx?h=-1382176977:33:48)
    at https://dev.deck.net/resources/js/bridge/bridge.js?17eba99:1591:45
    at https://dev.deck.net/resources/js/bridge/bridge.js?17eba99:1489:39
    at Function.Main (https://dev.deck.net/RunHandler.ashx?h=-1382176977:16:59)
    at https://dev.deck.net/resources/js/bridge/bridge.js?17eba99:3146:39
    at HTMLDocument.delayfn (https://dev.deck.net/resources/js/bridge/bridge.js?17eba99:459:21)
    at i (https://code.jquery.com/jquery-2.2.4.min.js:2:27151)
    at Object.add [as done] (https://code.jquery.com/jquery-2.2.4.min.js:2:27450)
    at n.fn.init.n.fn.ready (https://code.jquery.com/jquery-2.2.4.min.js:2:29515)
    at n.fn.init (https://code.jquery.com/jquery-2.2.4.min.js:2:24945)

Maybe related to boxing - if I examine a inside this method, it looks like something that is boxed:

[Reflectable] should be added (yes, we are working on #2732):
https://deck.net/4ae05031cc2bcd3c093c072662ea3da1
And with the attribute it ... gets a meaningfull DateTime related error:
TypeError: a.getFullYear is not a function

We will look at this issue. Thanks for reporting.

@LeonidVeriga Yeah sorry for the bad report - I fixed that up and then got the real error that I'd have in my production app. The links ot Deck + DNF above should be better samples now :-)

Looks like a wrong unboxing.
A workaround is to force unboxing in the log method by changing its parameter type. For example, LogDates1 or LogDates1:
https://deck.net/3d5f2e2ca7214a4db802ed740cab7726
    public static void LogDates1(object a)
    {
        if (a is DateTime)
        {
            var d = (DateTime)a;
            Console.WriteLine(d.Year);
        }
    }

    public static void LogDates2(DateTime? a)
    {
        if (a.HasValue)
        {
            Console.WriteLine(a.Value.Year);
        }
    }

Due to #2732 " Include Reflection metadata by default" [Reflection] is not mandatory anymore.


RFE: Option to run buildstream in slices

See original issue on GitLab
In GitLab by [Gitlab user @jjardon] on Jun 19, 2020, 16:40
In linux system this will allow to control the max amount of memory of CPU buildstream is allow to use, without affecting the rest of the system
See https://www.freedesktop.org/software/systemd/man/systemd.slice.html

In GitLab by [Gitlab user @cs-shadow] on Jun 22, 2020, 20:46
Hi [Gitlab user @jjardon], my systemd-foo isn't very strong. Can you pleae help me understand what is required here from the BuildStream side?
Because, I am failing to understand how this is supposead to work. AFAIK the slice configuration only applies to systemd units. And in general, BuildStream is not launched by systemd, but users directly. In theory, we could have a server-client model (like Bazel) but that's not the case currently. So, are you indirecly asking about having a build server model? Or maybe I'm missing somethinng completely.

In GitLab by [Gitlab user @cs-shadow] on Jun 22, 2020, 20:46
Hi [Gitlab user @jjardon], my systemd-foo isn't very strong. Can you pleae help me understand what is required here from the BuildStream side?
Because, I am failing to understand how this is supposead to work. AFAIK the slice configuration only applies to systemd units. And in general, BuildStream is not launched by systemd, but users directly. In theory, we could have a server-client model (like Bazel) but that's not the case currently. So, are you indirecly asking about having a build server model? Or maybe I'm missing somethinng completely.


Symfony 7 support

Can we drop the support of Symfony 4.4 and add support for symfony 7?
Than we do not need to add a BC Layer for MASTER_REQUEST. That is removed in symfony 7.
The new one is MAIN_REQUEST.
I am not sure what else need to be changed.

Symfony  7 is now out.  ApiPlatform now supports Symfony 7, but can't be installed via 'composer req api', because api-pack depends on this bundle.
Personally, I think it makes sense to drop support for any unsupported versions of Symfony (so ^6.4, ^6.3 and ^7.0), and drop 4.4.  That way, the MAIN_REQUEST issue isn't a problem.

@tacman I agree. Please see linked PR

Awesome!
symfony new --webapp api-test && cd api-test
composer req api
./composer.json has been updated
Running composer update api-platform/api-pack
Loading composer repositories with package information
Updating dependencies
Lock file operations: 4 installs, 0 updates, 0 removals
  - Locking api-platform/api-pack (v1.3.0)
  - Locking nelmio/cors-bundle (2.4.0)
  - Locking symfony/orm-pack (v2.4.0)
  - Locking symfony/serializer-pack (v1.3.0)

:-)

Thanks @Seldaek !!


Lost samll area

Hi guys:
I have a polygon Geojson file, when I create tiles, some small areas were lost.
Geojson file : geojson download
command:
tippecanoe -Z 17 -z 20 -pC -pf -pk -pt -ab -Q --no-tiny-polygon-reduction -pS --buffer=30 --layer=lmwz --force -o ./data/lmwz_17_20.mbtiles ./data/lmwz_17_20.geojson
picture of Geojson:

picture of tiles:

How can I fix my command?
Thanks a lot.
Thomas

I think this was a bug in Tippecanoe's polygon area calculations, which could in some circumstances overflow and choose the wrong winding order for a polygon. It has been fixed in the Felt version of Tippecanoe, https://github.com/felt/tippecanoe.
Mapbox:

Felt:

@e-n-f Hi, thank you.
All is OK.
Thomas