Add option to fail check on violations

Implements the idea of setting the status to failure on violations. Original seen in https://github.com/jwgmeligmeyling/pmd-github-action/issues/146.
It's implemented as an option called fail-on-violation and it defaults to false to keep the current behavior if not specified.

@bergander - thank you for the contribution :)


python import error

Problem: I followed https://github.com/Microsoft/LightGBM/blob/master/docs/GPU-Windows.md this method to install lightgbm in my windows computer (GPU) for python using. All things went well. But when I import it, python reported an OS error.
I found this problem also occurred in xgboost https://github.com/dmlc/xgboost/issues/908. They closed that issue by install python 64bit version. However, my python is 64 bit, but still reported this error.
Operating System: Windows 10
CPU: Intel 6700k
GPU GTX 1060
Python: Python 3.5.2 |Anaconda 4.2.0 (64-bit)| (default, Jul  5 2016, 11:41:13) [MSC v.1900 64 bit (AMD64)] on win32
Environment info
Operating System:
CPU:
C++/Python/R version:
Error Message:

import lightgbm
Traceback (most recent call last):
File "", line 1, in
File "C:\Users\bruce\Anaconda3\lib\site-packages\lightgbm-0.1-py3.5.egg\lightgbm_init_.py", line 9, in
from .basic import Booster, Dataset
File "C:\Users\bruce\Anaconda3\lib\site-packages\lightgbm-0.1-py3.5.egg\lightgbm\basic.py", line 31, in
_LIB = _load_lib()
File "C:\Users\bruce\Anaconda3\lib\site-packages\lightgbm-0.1-py3.5.egg\lightgbm\basic.py", line 26, in load_lib
lib = ctypes.cdll.LoadLibrary(lib_path[0])
File "C:\Users\bruce\Anaconda3\lib\ctypes_init.py", line 425, in LoadLibrary
return self.dlltype(name)
File "C:\Users\bruce\Anaconda3\lib\ctypes_init.py", line 347, in init
self._handle = _dlopen(self._name, mode)
OSError: [WinError 193] %1 is not a valid Win32 application

Reproducible examples

@brucebismarck
can you try using msvc build: https://github.com/Microsoft/LightGBM/wiki/Installation-Guide#windows-2
I think you build a 32-bit MinGW version.

Yes, I built with 32-bit MinGW.
I tried to use msvc to build, but  when I run cmake -DCMAKE_GENERATOR_PLATFORM=x64 -DUSE_GPU=1 .. in the command line, it says
C:\Users\bruce\LightGBM\build>cmake -DCMAKE_GENERATOR_PLATFORM=x64 -DUSE_GPU=1 ..
-- The C compiler identification is unknown
-- The CXX compiler identification is unknown
CMake Error at CMakeLists.txt:8 (PROJECT):
No CMAKE_C_COMPILER could be found.
CMake Error at CMakeLists.txt:8 (PROJECT):
No CMAKE_CXX_COMPILER could be found.
-- Configuring incomplete, errors occurred!
See also "C:/Users/bruce/LightGBM/build/CMakeFiles/CMakeOutput.log".
See also "C:/Users/bruce/LightGBM/build/CMakeFiles/CMakeError.log".
I am really a green hand in these things, any suggestions?

Did you have visual studio on your windows ?

I do have visual studio, and I will try to build with 64bit MinGW tomorrow. Thanks!

Hi Guolin,
I found my problem is because I am using static version rather than a dynamic version of the library. But not the problem of 32bit or 64bit I guess.
The problem diagnostics is described here.
http://catherineh.github.io/programming/2016/07/07/troubleshooting-windows-dll-imports-in-python
Do you know how to compile it to a dynamic version? Or which step is the most suspicious step made me get a static version?
I tried to use visual studio method,

@brucebismarck Can you provide the following?:

run this in a console to get the Python version: python -V
PATH environment variable full content

Which method did you use?

If MinGW, then you must compile Boost with the identical MinGW used to compile LightGBM
If Visual Studio, either use precompiled binaries (recommended) or use the identical Visual Studio compiler used to compile LightGBM/

Sure!
Python 3.5.2 :: Anaconda 4.2.0 (64-bit) (Because I am using keras, so I did not update python to 3.6)
PATH
C:\ProgramData\Oracle\Java\javapath;C:\Program Files\NVIDIA GPU Computing Toolkit\CUDA\v8.0\bin;C:\Program Files\NVIDIA GPU Computing Toolkit\CUDA\v8.0\libnvvp;C:\WINDOWS\system32;C:\WINDOWS;C:\WINDOWS\System32\Wbem;C:\WINDOWS\System32\WindowsPowerShell\v1.0;C:\Program Files (x86)\NVIDIA Corporation\PhysX\Common;%USERPROFILE%.dnx\bin;C:\Program Files\Microsoft DNX\Dnvm;E:\Program Files\MATLAB\R2016b\runtime\win64;E:\Program Files\MATLAB\R2016b\bin;E:\Program Files\MiKTeX 2.9\miktex\bin\x64;C:\Program Files\nodejs;C:\Program Files\PuTTY;
C:\Program Files\Git\cmd;C:\Program Files (x86)\mingw-w64\i686-6.3.0-posix-dwarf-rt_v5-rev2\mingw32\bin;C:\Program Files\mingw-w64\x86_64-6.3.0-posix-seh-rt_v5-rev2;C:\Program Files\boost\boost-build\bin;C:\Program Files\boost\boost-build\include\boost
I used MinGW and followed this tutorial https://github.com/Microsoft/LightGBM/blob/master/docs/GPU-Windows.md
The only difference is that in the Boost compilation, under c/boost/, I do not have 'lib' and 'share' folder as shown in the tutorial.

@brucebismarck can you try latest commit ?

@guolinke  I git cloned it again, but it reported the same error.
File "C:\Users\bruce\Anaconda3\lib\ctypes_init_.py", line 425, in LoadLibrary
return self.dlltype(name)
File "C:\Users\bruce\Anaconda3\lib\ctypes_init.py", line 347, in init
self._handle = _dlopen(self._name, mode)

@brucebismarck
can you remove ```C:\Program Files (x86)\mingw-w64\i686-6.3.0-posix-dwarf-rt_v5-rev2\mingw32\bin;`` from your path?

@guolinke  Cool!!!! I made it!!!! Thanks a lot guolin!


[jest-util] Add ErrorWithStack class

Summary
Removes the duplication of:
const error = new Error('whatever');
if (Error.captureStackTrace) {
  Error.captureStackTrace(error, someFunction);
}

Motivation: see @SimenB's https://github.com/facebook/jest/pull/7033#discussion_r219711554
Test plan

Added unit test for new class
All existing test should pass

Notes
I've not updated the expect package with this change as I believe it cannot depend on jest-util because of bundling for the browser, is this correct? cc/ @thymikee @rickhanlonii

I believe it cannot depend on jest-util because of bundling for the browser

Correct, but we should fix that. Or have like jest-isomorphic-utils and jest-node-utils instead.
(Yes, that was a joke, but you know what I mean)

Codecov Report

Merging #7067 into master will increase coverage by 0.06%.
The diff coverage is 35.29%.

@@            Coverage Diff            @@
##           master   #7067      +/-   ##
=========================================
+ Coverage   66.63%   66.7%   +0.06%
=========================================
  Files         251     252       +1
  Lines       10542   10521      -21
  Branches        3       3
=========================================
- Hits         7025    7018       -7
+ Misses       3516    3502      -14
  Partials        1       1

Impacted Files
Coverage Δ

packages/jest-jasmine2/src/jasmine/Env.js
0% <0%> (ø)
:arrow_up:

packages/jest-runner/src/run_test.js
3.07% <0%> (+0.09%)
:arrow_up:

packages/jest-jasmine2/src/error_on_private.js
0% <0%> (ø)
:arrow_up:

packages/jest-util/src/index.js
0% <0%> (ø)
:arrow_up:

packages/jest-cli/src/collectHandles.js
0% <0%> (ø)
:arrow_up:

packages/jest-each/src/bind.js
71.29% <100%> (-1.92%)
:arrow_down:

packages/jest-util/src/error_with_stack.js
100% <100%> (ø)

packages/jest-circus/src/index.js
72.54% <33.33%> (+6.92%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 49b2380...93bb48e. Read the comment docs.


Added number 2

please check the contributor.txt file it is conflicting with the main repo

Solved merge conflict.


Method not found: 'Void NLog.Targets.Wrappers.AsyncTargetWrapper..ctor(System.String, NLog.Targets.Target)'

Hi! Thanks for reporting this feature/bug/question!
Please keep / fill in the relevant info from this template so that we can help you as best as possible.
QUESTIONS are preferred on StackOverflow. You could expect a faster response there (but do include all the info below). Use the tag "nlog" https://stackoverflow.com/questions/ask
For .NET Core users, please check the platform support: https://github.com/NLog/NLog/wiki/platform-support
NLog version: 4.6.2
Platform: .Net 4.6.1
Current NLog config (xml or C#, if relevant)
<nlog>
  <targets>
  </targets>
  <rules>
  </rules>
</nlog>

What is the current result?
Sometimes application crashes because of this issue.
What is the expected result?
Application should always find constructor
Did you checked the Internal log?
No
Please post full exception details (message, stacktrace, inner exceptions)
System.MissingMethodExceptionApp.Service.Logging.Log.Configure():0
Method not found: 'Void NLog.Targets.Wrappers.AsyncTargetWrapper..ctor(System.String, NLog.Targets.Target)'.
Are there any workarounds?
NO
Is there a version in which it did work?
NO
Can you help us by writing an unit test?
Not sure

The missing constructor was introduced May 5, 2016 with NLog ver. 4.3.4
When you say:

Sometimes application crashes because of this issue.

Then I guess you have several installations where some fail. I'm guessing that the failing installations has the NLog.dll installed in the GAC, and because NLog is strong-named then it chooses the GAC-version.
Solution is to remove NLog.dll from the GAC on the individual machines, or to perform ilmerge of the NLog.dll for your application.

See also https://stackoverflow.com/a/55650444/201303

Closing this due to inactivity. Please let us know if this still an issue and please provide the requested info -
thanks!


Set title in file properties of PDF file

Is there a way to set the title property in the file properties in the generated PDF file.
As far as I can see the filename of the html file is taken as title property.

Sounds good.
Once working on the file properties may be it is worth to add other file properties as well. e.g. Author, Subject and Keywords
Here an idea https://stackoverflow.com/questions/51153026/puppeteer-pdf-title-and-author-metadata
Default settings could be:
Title: filename
Author: empty
Subject: empty
Keywords: empty

Alright, gonna set the title over the HTML.
For the other metadata there's no puppeteer support but might be adjustable with https://github.com/UglyToad/PdfPig which I am already using for generating the TOC page numbers.

With PdfPig it's easy to read the Metadata, however It seems like It can't be used it for editing it. Currently still looking for an easy way to edit XMP metadata in C#. Exiftool is nice but would need to create a wrapper for it that also works cross-platform. This sounds quite painful.


[Feature]: Botmatch detection

Are you on the latest version?

[X] I'm on the latest version

Is there a fix in progress related to your proposal?

[X] I have searched the existing issues

Is your feature request related to a problem? Please describe the problem.
Steam RPC has separate status for botmatches (#DOTA_lobby_type_name_bot_match), but dota2-rpc-client doesn't really detect it as a botmatch (just as a regular one).
Describe the solution you'd like
Would be nice to add botmatch support.
It would also be nice to have a robot icon in the corner of hero portrait (similar to smoke status) for botmatches as an additional indicator.
Dota 2 Patch
No response
Anything else?
No response

This one is a little more difficult. But I'll research if I can get the information directly from Steam RPC.
Currently I use Dota's Game Integration service, which is nothing more than a big JSON with lots of information. I still haven't found a way to detect a game with bots from this data. I believe that seeing this information directly from Steam RPC could be a solution.

Do you have any links about this? I never looked to see if it is possible to get this information.

This one is a little more difficult. But I'll research if I can get the information directly from Steam RPC.

I was working on a project similar to yours and researching the topic.
Advantage of using GSI: you don't need to log into Steam every time. With Steam RPC you either have to enter Steam Guard code every time or use another account to monitor status. Also, GSI has much more information.
But Steam RPC translates directly into Discord RPC (and it also has the "Main Menu", "Main Menu (Idle)", "In lobby" states).
I can't link any additional information on this though. ApexRPC was like a reference project to me, and the rest of stuff came from manually testing and logging results from different manipulations.

I still haven't found a way to detect a game with bots from this data

I suspected this might be a problem.

I believe that seeing this information directly from Steam RPC could be a solution.

This would require user to log into Steam, I think, and wouldn't get any advantages. Unless Steam SDK can provide this functionality, of course. If this is the case, I don't think it's worth it then.
Although IIRC you can get Steam RPC status from a player even if you are not on the player's friends list. So in theory it should be possible to make a bot/proxy which would check a person's status.
Another potential solution would be looking at the players list in the match (similar to what 9kmmr bot does). I didn't have prior experience with GSI, but I would assume that bots would have something suspicious in their data, e.g. Player->SteamID. I think this should be the best solution.

You're right, having to save steam login information might be a little out of scope.

I think it will be possible to create a bot detection with this information. I'll implement later and validate.


Missing dependency/relation between elasticsearch installation and plugin installation

Module version:
0.15.1

Puppet version:
3.8.7

OS and version:
CentoOS 7 and CentOS 6

Bug description
When providing a machine with a full elasticsearch cluster AND we specify the plugins since the first run, it fails due to non existing path <plugin installation path>/plugins/<plugin name>/.name
I suppose it is due config path and plugin path are customized via configdir and plugindir respectively.

Could you share an example puppet manifest that throws the error for you?

I will provide those informations later, but finally, as you stated in https://github.com/elastic/puppet-elasticsearch/issues/524, it seems related to

the checks at file system level on whether the plugins are present or not are done on the against the plugindir e.g. /opt/elasticsearch/plugin
there is no plugin there, so the installation proceeds
the plugins are installed in the default plugin directory /usr/share/elasticsearch with no clear log (even in debug & verbose)
the plugin installation starts but fails telling the plugin is already installed


Fix typo

Javascript -> JavaScript

@changeworld : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@changeworld Thanks for helping improve the documentation!
#sign-off


Font family names should be ASCII?

An anonymous expert wrote in to the Noto project,

Unicode (3,1,409) 'name' table strings are not limited to ASCII, so you should feel free to use Nüshu (not Nushu) when appropriate. The instances in the name.ID=3 and name.ID=6 strings are for the PostScript name, and should continue to use Nushu. The name.ID=1 and name.ID=4 string can definitely use Nüshu.

I believe to date, we need font family strings to be ASCII. We should have a FB check for that.
However, perhaps we can relax that requirement, so I'm filing this issue to

[x] 1. Confirm we do have a FB check for that (@felipesanches)
[ ] 2. Confirm if we can relax is (@davelab6)

yes!
com.google.fonts/check/name/ascii_only_entries:
https://github.com/googlefonts/fontbakery/blob/f2ace463ee447251ba5bf7513424d7ed7ed78b90/Lib/fontbakery/profiles/googlefonts.py#L1551-L1564


liquid include parameter

this {% if include.modal == true %} in include.html
this {% include include.html modal="test" %} in layout.
another in index.html
I do not sure what wrong with my code, passed but does not able to get the param in include.html.
I saw this documentation from jekll documentation. so assume it's bug of pretzel.
please correct me if I am wrong.

Pretzel use dotliquid for liquid processing and it seems that they haven't updated since a few years...
Sadly I haven't found another lib to replace it now, but if you know one I'll be happy to do the replacement.

Thanks for reply.  Tomorrow should have a look at dotliquid then.


Please assign this issue to me, as I have worked on it

This feature is related to the problem/issue that I am raising.
I will add the age feature in this issue using JavaScript as the main logic behind this task.
I will also add HTML and CSS to frame it in a nice order.
We can work on the CSS aspects of this issue.
I have worked with this feature before, so have the apt knowledge for it.
Steps Followed✅
Check the box with [x] If you followed all the steps.

[x] Is your feature request related to a problem? Please describe.
[x] Describe the solution you'd like
[ ] Describe alternatives you've considered
[ ] Additional context

Code of Conduct✅

[x] I agree to follow this project's Code of Conduct.
[x] I checked the current issues for duplicate problems.
[x] I have gone through project README.

It's not clear. What you want to solve and in which project.


Samples

Do you have any sample files of writing an FBX back from scratch?

Look in the source or modFBX.vb
It contains all the FBX code to write and read that Im using with the wrapper.

Look in the source for modFBX.vb
It contains all the FBX code to write and read that Im using with the wrapper.

Where is this file? Not sure which one you are talking about. Can't find in repository.

Im sorry.. It was very late and I was confused about where this post.
Its in my repo for TankExporter.

Also.. my code uses a different FBX naming structure than this one.
Have you tried AutoDesks community?
http://forums.autodesk.com/t5/fbx-sdk/bd-p/area-b64


Index Error

Hello Moritz,
Thanks for such a great implementation of Polygon based on SNIC...i am facing one small issue...so In some cases..I am observing that the polygonize code is giving index error with queue[-1]...I was hoping you could help out in finding a way to solve it.
Preview of the Error is below-
Traceback (most recent call last):
File "trial.py", line 33, in
graphs = polygonize(segmentation, seeds, rdp)
File "/home/sirzech/anaconda3/lib/python3.8/site-packages/pysnic/algorithms/polygonize.py", line 522, in polygonize
graphs = trace_isles(vertices, seeds, segmentation)
File "/home/sirzech/anaconda3/lib/python3.8/site-packages/pysnic/algorithms/polygonize.py", line 304, in trace_isles
vertices, edges = trace_edges_unsafe(px, py, direction, segmentation)
File "/home/sirzech/anaconda3/lib/python3.8/site-packages/pysnic/algorithms/polygonize.py", line 348, in trace_edges_unsafe
idx = queue[-1]
IndexError: list index out of range
Thanks,
Rahul Moorthy

Hi Rahul,
thanks for your feedback! I just had a look at the code and checked in a new commit, that hopefully resolves your error. If the change fixes your problem I will release a new version on pip later today.
Best,
Moritz

Yes, I tried it out now, it seems to be working...Thanks a lot...

I also wanted to know one more thing, instead of the vertices and edges...can the algo directly give the polygon? or do we need to write custom logic for that?

I currently have no plans for adding such functionality to the code, as there already exist more advanced libraries to handle polygons and/or meshes (e.g. OpenMesh). The extracted data structure is also likely to depend on the specific use case (- point list, half-edge structure, ...).
Just a remark about extracting polygons: Depending on the parameters, the SNIC algorithm can produce superpixels that are fully enclosed into others. Simply converting to polygons by tracing the edges may violate this topology, as the enclosing super-pixels may also cover the area of the enclosed ones. This may be problematic if you plan to do some calculations/statistics on them. If you simply want to visualize the superpixels, make sure to draw the graphs in the provided order. Graphs containing the enclosed superpixels are provided last in the returned graph list.
If you got some suggestions for adding such functionality in a proper way, I can try to free some time and add it to the repo.

I just want to visualize...and send the polygon coordinates...will keep in mind the point which you mentioned

Just in case you are encountering index out of bound errors in the polygonization method again - I just revised the code to cover some more edge cases. (Fixed the same error in another sub-method and prevented some edges from being mistakenly discarded).

Thanks a lot Moritz....just wanted to know...whether you have updated the same in the pip version of pysnic

Just updated the pip package. :+1:


WIP basic checked type

closes #9

Codecov Report
Attention: 26 lines in your changes are missing coverage. Please review.

Comparison is base (c5a09e0) 94.44% compared to head (874cb52) 79.85%.

Additional details and impacted files
@@             Coverage Diff             @@
##             main      #10       +/-   ##
===========================================
- Coverage   94.44%   79.85%   -14.59%
===========================================
  Files           3        4        +1
  Lines          54      139       +85
===========================================
+ Hits           51      111       +60
- Misses          3       28       +25

Files
Coverage Δ

src/AllocArray.jl
93.10% <100.00%> (-0.45%)
:arrow_down:

src/AllocArrays.jl
100.00% <ø> (ø)

src/alloc_interface.jl
100.00% <100.00%> (+4.54%)
:arrow_up:

src/CheckedAllocArray.jl
54.38% <54.38%> (ø)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


issue: Add keys to all maps and replace null with empty div

All maps implicit or explicit need to be using keys, see https://reactjs.org/docs/lists-and-keys.html Without it it produces weird hard to debug rendering bugs.
We should also replace all null and "" in conditional statements with empty div, see https://github.com/near/devgigsboard-widgets/pull/5

We actually need key on every div element https://t.me/NearSocialDev/1879

I checked all the widgets, and confirm that key is properly set everywhere it is needed.


[devicelab] Add flags to upload results to Cocoon

Description
Ports logic from flutter/cocoon agent to be directly included in the test runner script.
If service-account-file and task-key are passed on devicelab runs, it will attempt to upload the results to Cocoon.
This is needed for migrating the devicelab to LUCI as we are deprecating the Cocoon agent.
Related Issues
https://github.com/flutter/flutter/issues/66191 - Add support to devicelab test runner to upload results to Cocoon
Tests
I added the following tests:
Cocoon checks for validating the sent request and reading the service account file correctly.
Runner invokes cocoon upload when a service account file flag is passed.
Checklist
Before you create this PR, confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

[X] I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
[X] I signed the [CLA].
[X] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
[X] I read the [Tree Hygiene] wiki page, which explains my responsibilities.
[X] I updated/added relevant documentation (doc comments with ///).
[X] All existing and new tests are passing.
[X] The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
[X] I am willing to follow-up on review comments in a timely manner.

Breaking Change
Did any tests fail when you ran them? Please read [Handling breaking changes].

[X] No, no existing tests failed, so this is not a breaking change.
[ ] Yes, this is a breaking change. If not, delete the remainder of this section.

Abandoning as merge conflicts are hard with the yaml files.


Not Portable with params

What happened?
On webpage:
https://docs.zen-browser.app/guides/portable
is how to portable mode.
But, if i add param "-P" nothing portable...
Profile folder created in %AppData%
Reproducible?

[ ] I have checked that this issue cannot be reproduced on Mozilla Firefox.

Version
1.0.0
Severity impact
Critical
What platform are you seeing the problem on?
Windows
Relevant log output
No response

@IAmJafeth you've got this?

@IAmJafeth

Don't have a Windows machine right now, I can build a VM for testing it later
However, please note this guide is an unofficial/unsupported way to make Zen Browser installer portable.
Please use Zen's Windows portable version in the meantime  https://docs.zen-browser.app/guides/downloads
Based on my findings, I will update this guide accordingly

[!NOTE]
ETA: 24 hours

Closed with commit 573537a102f8abd1dd2ccaba508d5e31d8a3c648


pg_search_scope error with associations and scopes

class Establishment < ActiveRecord::Base
  include PgSearch
  pg_search_scope :search,
      against: [:name, :street, :neighborhood, :screen_name],
      associated_against: { profile: :description, kind_of_foods: [:name, :food] },
      using: { tsearch: {prefix: true} },
      ignoring: :accents
  has_and_belongs_to_many :kind_of_foods
  has_one :profile

  default_scope order: 'unaccent(establishments.name) ASC'

  def self.enabled
    includes(:profile).where("profiles.enable IS true")
  end

  def self.opened
    includes(:hours_of_operations)
    .where("hours_of_operations.week_day = ?", Time.now.wday)
    .where("first_closed = ? OR second_closed = ?", false, false)
  end

  def self.closed
    includes(:hours_of_operations)
    .where("hours_of_operations.week_day = ?", Time.now.wday)
    .where("first_closed = ? AND second_closed = ?", true, true)
  end
end

class EstablishmentsController < ApplicationController

  def index
    @establishments = @city.establishments.includes(:profile, :hours_of_operations).enabled
    @establishments = @establishments.search(params[:search])  if params[:search].present?
  end

PG::Error: ERROR:  invalid reference to FROM-clause entry for table "profiles"
LINE 1: ..., "establishments"."accepted_contract" AS t0_r19, "profiles"...
                                                             ^
HINT:  Perhaps you meant to reference the table alias "profiles_establishments".

 Restaurants Opened -->
    3:   <% @establishments.opened.each do |establishment| %>
    4:     <%= content_tag(:div, class: "restaurant", id: "establishment_#{establishment.id}") do %>
    5:
<%= link_to establishment.profile.logo? ? image_tag(establishment.profile.logo, alt: establishment.name) : image_tag('gruboo-default.png', alt: 'Gruboo Default'), city_restaurant_path(@city, establishment) %>

    6:

  app/views/establishments/_content.html.erb:3:in `_app_views_establishments__content_html_erb___690055410653268399_70155156458680'
  app/views/establishments/index.html.erb:6:in `_app_views_establishments_index_html_erb___452280125446139122_70155156525760'
  app/controllers/establishments_controller.rb:18:in `index'

  Rendered /Users/danieldocki/.rbenv/versions/1.9.3-p327/lib/ruby/gems/1.9.1/gems/actionpack-3.2.11/lib/action_dispatch/middleware/templates/rescues/_trace.erb (1.5ms)
  Rendered /Users/danieldocki/.rbenv/versions/1.9.3-p327/lib/ruby/gems/1.9.1/gems/actionpack-3.2.11/lib/action_dispatch/middleware/templates/rescues/_request_and_response.erb (1.3ms)
  Rendered /Users/danieldocki/.rbenv/versions/1.9.3-p327/lib/ruby/gems/1.9.1/gems/actionpack-3.2.11/lib/action_dispatch/middleware/templates/rescues/template_error.erb within rescues/layout (9.2ms)

But if I use unscoped, works correctly, but I need the enabled, closed and opened
@establishments = @establishments.unscoped.search(params[:search])

I just re-ran my test case against pg_search 1.0.0. It passes against Active Record 4.1 and 4.2, but fails for earlier versions.
Does pg_search 1.0.0 fix the issue for you?

@nertzy this is still the issue.
Your spec don't fail with activerecord 4.2 because .all returns Relation in latest versions. If you replace .all with .to_a you'll see an exception.

Thanks, I'll update my spec to populate the Relation using #to_a

My pretty horrible work around for this issue is to build a fresh relation by pulling the ids out of the relation returned by the search:
def sanitize_relation(relation_from_search)
  Model.where(id: relation_from_search.pluck('id'))
end

Maybe that helps someone.

Is there a fix for  it ??
Facing the same problem .
I have Slide and Library_Slide_Type model
class Slide < ActiveRecord::Base
   include PgSearch

  has_and_belongs_to_many :slide_library_types, join_table: "slide_libraries"

  acts_as_taggable
  acts_as_taggable_on :content_tag

  pg_search_scope :search_by_content , :against => [:text_content, :title, :notes],
                                                :associated_against => {slide_library_types: :name}

 def self.search(query)
    if query.empty?
      self.all
    else
      search_by_content(query)
    end
  end

  def self.tagged(tags)
    if tags.blank?
      self.all
    else
      tagged_with(tags)
    end
  end

  def self.libraries(libs, current_user)
    libs = current_user.slide_library_types.pluck(:id) if libs.blank?
    Slide.includes(:slide_library_types).where('slide_library_types.id in (?)', libs).references(:slide_library_types)
  end

  def self.deck_slide(deck_id)
    if deck_id == 0
      self.all
    else
      Slide.where(deck_id: deck_id)
    end
  end

end

class SlideLibraryType < ActiveRecord::Base
  has_and_belongs_to_many :slides, join_table: "slide_libraries"
end

Basically a User should search a slide with the tag or library_types or the content.
I have chained the method in controller which look as below
@library_slides =  Slide.libraries(library_types, current_user).tagged(tags).search(search_term)

But when content search is fired by user get the error as above :
SELECT "slide_library_types"."id" FROM "slide_library_types" INNER JOIN "user_libraries" ON "slide_library_types"."id" = "user_libraries"."slide_library_type_id" WHERE "user_libraries"."user_id" = $1  [["user_id", 1]]
SQL (2.1ms)  SELECT  DISTINCT "slides"."id", pg_search_fd2c8f1dc03ce50ff48749.rank, "slides"."id" AS alias_0 FROM "slides" LEFT OUTER JOIN "slide_libraries" "slides_slide_library_types_slides_join" ON "slides_slide_library_types_slides_join"."slide_id" = "slides"."id" LEFT OUTER JOIN "slide_library_types" "slide_library_types_slides" ON "slide_library_types_slides"."id" = "slides_slide_library_types_slides_join"."slide_library_type_id" INNER JOIN (SELECT "slides"."id" AS pg_search_id, (ts_rank((to_tsvector('simple', coalesce("slides"."text_content"::text, '')) || to_tsvector('simple', coalesce("slides"."title"::text, '')) || to_tsvector('simple', coalesce("slides"."notes"::text, '')) || to_tsvector('simple', coalesce(pg_search_18f11dc487a1e151dc85dd.pg_search_3f858e8a53fd0c6e6c13e7::text, ''))), (to_tsquery('simple', ''' ' || 'help' || ' ''')), 0)) AS rank FROM "slides" LEFT OUTER JOIN (SELECT "slides"."id" AS id, string_agg("slide_library_types"."name"::text, ' ') AS pg_search_3f858e8a53fd0c6e6c13e7 FROM "slides" INNER JOIN "slide_libraries" ON "slide_libraries"."slide_id" = "slides"."id" INNER JOIN "slide_library_types" ON "slide_library_types"."id" = "slide_libraries"."slide_library_type_id" GROUP BY "slides"."id") pg_search_18f11dc487a1e151dc85dd ON pg_search_18f11dc487a1e151dc85dd.id = "slides"."id" WHERE (((to_tsvector('simple', coalesce("slides"."text_content"::text, '')) || to_tsvector('simple', coalesce("slides"."title"::text, '')) || to_tsvector('simple', coalesce("slides"."notes"::text, '')) || to_tsvector('simple', coalesce(pg_search_18f11dc487a1e151dc85dd.pg_search_3f858e8a53fd0c6e6c13e7::text, ''))) @@ (to_tsquery('simple', ''' ' || 'help' || ' '''))))) AS pg_search_fd2c8f1dc03ce50ff48749 ON "slides"."id" = pg_search_fd2c8f1dc03ce50ff48749.pg_search_id WHERE (slide_library_types.id in (1))  ORDER BY pg_search_fd2c8f1dc03ce50ff48749.rank DESC, "slides"."id" ASC LIMIT 12 OFFSET 0
PG::UndefinedTable: ERROR:  invalid reference to FROM-clause entry for table "slide_library_types"
LINE 1: ...search_fd2c8f1dc03ce50ff48749.pg_search_id WHERE (slide_libr...
^
HINT:  Perhaps you meant to reference the table alias "slide_library_types_slides".
: SELECT  DISTINCT "slides"."id", pg_search_fd2c8f1dc03ce50ff48749.rank, "slides"."id" AS alias_0 FROM "slides" LEFT OUTER JOIN "slide_libraries" "slides_slide_library_types_slides_join" ON "slides_slide_library_types_slides_join"."slide_id" = "slides"."id" LEFT OUTER JOIN "slide_library_types" "slide_library_types_slides" ON "slide_library_types_slides"."id" = "slides_slide_library_types_slides_join"."slide_library_type_id" INNER JOIN (SELECT "slides"."id" AS pg_search_id, (ts_rank((to_tsvector('simple', coalesce("slides"."text_content"::text, '')) || to_tsvector('simple', coalesce("slides"."title"::text, '')) || to_tsvector('simple', coalesce("slides"."notes"::text, '')) || to_tsvector('simple', coalesce(pg_search_18f11dc487a1e151dc85dd.pg_search_3f858e8a53fd0c6e6c13e7::text, ''))), (to_tsquery('simple', ''' ' || 'help' || ' ''')), 0)) AS rank FROM "slides" LEFT OUTER JOIN (SELECT "slides"."id" AS id, string_agg("slide_library_types"."name"::text, ' ') AS pg_search_3f858e8a53fd0c6e6c13e7 FROM "slides" INNER JOIN "slide_libraries" ON "slide_libraries"."slide_id" = "slides"."id" INNER JOIN "slide_library_types" ON "slide_library_types"."id" = "slide_libraries"."slide_library_type_id" GROUP BY "slides"."id") pg_search_18f11dc487a1e151dc85dd ON pg_search_18f11dc487a1e151dc85dd.id = "slides"."id" WHERE (((to_tsvector('simple', coalesce("slides"."text_content"::text, '')) || to_tsvector('simple', coalesce("slides"."title"::text, '')) || to_tsvector('simple', coalesce("slides"."notes"::text, '')) || to_tsvector('simple', coalesce(pg_search_18f11dc487a1e151dc85dd.pg_search_3f858e8a53fd0c6e6c13e7::text, ''))) @@ (to_tsquery('simple', ''' ' || 'help' || ' '''))))) AS pg_search_fd2c8f1dc03ce50ff48749 ON "slides"."id" = pg_search_fd2c8f1dc03ce50ff48749.pg_search_id WHERE (slide_library_types.id in (1))  ORDER BY pg_search_fd2c8f1dc03ce50ff48749.rank DESC, "slides"."id" ASC LIMIT 12 OFFSET 0
Completed 500 Internal Server Error in 254ms (ActiveRecord: 21.0ms)
** [Raven] Event not sent due to excluded environment: development
ActiveRecord::StatementInvalid (PG::UndefinedTable: ERROR:  invalid reference to FROM-clause entry for table "slide_library_types"
LINE 1: ...search_fd2c8f1dc03ce50ff48749.pg_search_id WHERE (slide_libr...
^
HINT:  Perhaps you meant to reference the table alias "slide_library_types_slides".
 I've been really fixing my hair for over an hour for this problem. :+1:

I am just thinking about aliasing table name in relation method so the alias joins from active_record would work. Something like this:
`def selects_for_singular_association
columns.map do |column|
"#{column.full_name("r01")}::text AS #{column.alias}"
end.join(", ")
end
  def selects_for_multiple_association
    columns.map do |column|
      "string_agg(#{column.full_name("r01")}::text, ' ') AS #{column.alias}"
    end.join(", ")
  end

  def relation(primary_key)
    result = @model.unscoped.joins("INNER JOIN #{table_name} AS r01 #{on_join_query}").select("#{primary_key} AS id, #{selects}")
    result = result.group(primary_key) unless singular_association?
    result
  end

  def on_join_query
    foreign_key = @model.reflect_on_association(@name).foreign_key
    if contain_foreign_key?
      "ON r01.id =<EMAIL_ADDRESS>    else
      "ON r01.#{foreign_key} =<EMAIL_ADDRESS>    end
  end`

Then we need to randomize the alias name instead of hard coded "r01". A bit heavy though.


Click X & Y are slightly off on phones

If you place views with OnClickListeners into the bottom sheet view, only the top part of the view registers clicks on phones.
I resolved this by copying down the source code and changing line 446 to calculate the offset and push it down further (for some reason 24dp seems to be the magic number):
event.offsetLocation(isTablet ? getX() - sheetStartX : 0, sheetTranslation - getHeight() - (isTablet ? 0 : DesignUtils.convertDpToPixel(24)));
in onTouchEvent(). Full method with changes:
 @Override
    public boolean onTouchEvent(@NonNull MotionEvent event) {
        if (!isSheetShowing()) {
            return false;
        }
        if (isAnimating()) {
            return false;
        }
        if (!hasIntercepted) {
            return onInterceptTouchEvent(event);
        }

    ....
        } else {
            // If the user clicks outside of the bottom sheet area we should dismiss the bottom sheet.
            boolean touchOutsideBottomSheet = event.getY() < getHeight() - sheetTranslation || !isXInSheet(event.getX());
            if (event.getAction() == MotionEvent.ACTION_UP && touchOutsideBottomSheet && interceptContentTouch) {
                dismissSheet();
                return true;
            }

            /******* CHANGE MADE HERE *********/
            event.offsetLocation(isTablet ? getX() - sheetStartX : 0, sheetTranslation - getHeight() - (isTablet ? 0 : DesignUtils.convertDpToPixel(24)));
            getSheetView().dispatchTouchEvent(event);
        }

        return true;
    }

I should put in a pull request, but I'm not confident this is the appropriate way to address this. Ran this code on Sony Xperia Z3 Compact running 5.1.1 and a LG Optimus Exceed 2 running 4.4.2 and it resolved the touch point issue. On a Barnes & Noble Nook running 4.0.4 and a Nexus 7 running 5.1.1 work fine with the code as it is currently in the project.

24dp seems a little too magic-number-y. Could you post a screenshot or screenrecord of the behavior?

Agreed, thus why I posted here as opposed to putting in a pull request--definitely a "Uh, hardcoded value seems weird here" moment.
I'll see about a screen recording. The screenshot likely won't help since you need to see that my finger is touching the view dead-on but the click isn't being registered.

If you look at the screenshots below, with the touchpoints on the first card on the stars, only the first 1, with the touch point above the actual view, registered a click. All the others, despite actually touching the view, did not register a click.

Would like to also note, despite my other issue being opened (which uses the same magic number), this issue is unrelated. I removed any padding from my sheet view and it had no effect on this issue.

I've been thinking on this, and I'm drawing a blank as far as what could be going on here. I can't find any references to those devices misreporting their events, and also can't repro this myself (though I'm limited to genymotion and a nexus 6P). If you breakpoint it, does the touch event report this too?

To clarify, where would you like me to put a breakpoint and report back on the results? In the method that I modified?

right, breakpoint onTouch and see if the values match up if you turn on the pointer location developer option

I'm not going to bother you with this any further as I've moved to use Google's BottomSheet APIs. Thanks for your help...although if you are going to continue maintaining this library it's definitely still an issue (ultimately that's why I moved to Google's implementation).

Sorry I was still waiting for your follow-up but never heard anything, that's why I closed it.

No problem, I dropped the ball there. Sorry, in the middle of an all-out sprint to release, so I just didn't have time to sit and troubleshoot to figure out what was off. Even my workaround stopped being effective. I'll make a note on my calendar to take a look once I get this app out the door.

Sounds good, thanks!


Don't allow non-integer array sizes?

Currently floats are allowed for array sizes (they are converted to ints) (https://github.com/Vexu/arocc/blob/9f8f4f405d81a116552b08f2756334da59fedf05/src/Parser.zig#L2381) but clang and gcc both disallow this. Can I remove the code that allows floats for array sizes?

Can I remove the code that allows floats for array sizes?

Yup, I added it as a result of crash in fuzzing (81d709461c65a2b59eb8ae17be2392480e3e3bb1)  and didn't check GCC/clang behavior.


Looking forward to get involved and contribute to the community 🎉

First Name
Ishan
Last Name
Soni
Discord Username (if applicable)
Ishan#2801
Let us understand your motive.
I came to know about sid hacks from my friend. I really like the inclusiveness and the way everyone helps each other. I also want to give my contribution by helping others in the best possible way I can. We can build a really meaningful community that will empower others and make some awesome Open-source projects for community members to contribute to them, organize hackathons for active participation of everyone. These were the ways I can contribute to the community.

Hey @ItsMeIshan 👋🏻
Thanks for requesting an invite! Welcome to SidHacks Community 🎉
Before going ahead, I would want you to complete the below To-Do list.
Your To-Do List ✔

Accept the invitation sent to you via mail.
Change the appearance of this organization to "Public" from the people list here.
Join our Discord Server here.

Accept the Rules from #📓〡rules channel.
Introduce yourself to our community in 👋〡introduction channel.

Feel free to share your excitement on socials with #SidHacksCommunity. You can also tag me @siddharth_hacks.

Close this issue once you complete all the above points.

Looking forward to interacting with you in our community! Welcome once again! 🤓


⚠ Bofrost.lu has degraded performance

In 147a25c, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 843 ms

Resolved: Bofrost.lu performance has improved in 228dc36 after 6 minutes.


[Feature] Allow downloading data from a table as an Excel file

The table widget today can already export data as a CSV file, but importing CSV files into Excel is a painful process. Setting the encoding and CSV formatting settings when importing is a fragile and error-prone process.
So, if the table widget can export an Excel file directly, it'd be a lot more convenient export format to work with.

We will we showing download options as a dropdown > designs here


Fix for 'ERR max number of clients reached'  MasterListener Thread death

Hi @marcosnils @HeartSaVioR  @xetorthio
I've created a test case for issue #1329
Note that this PR doesn't yet include the actual fix ( Change the type of exception  catched to a broader one ) just the test that should fail in the current scenario. I'll add once we confirm the test is valid and up to standards
Haven't gotten round to running it yet though . Let me know what you think

@marcosnils @HeartSaVioR  my tests are failing because config set/get is not supported for redis-sentinel :disappointed:  - http://stackoverflow.com/questions/30376639/redis-sentinel-how-to-get-config-value
I'd like to hear your ideas on how to tackle this (aside from writing command line execution integrations to change values in the config file and restart it). Tnx

There is this PR https://github.com/antirez/redis/pull/2777 , but it looks like it never made it to production

@marcosnils any response here ?

@sheinbergon
Sorry for the late update. Seems like most of changes are indentation mismatch. Could you follow our code style? hbase-formatter.xml is for that, and you can import this to your IDE.
You can even make format to reformat whole things but it also change javadoc format and other files so it's only for fixing whole messed things.
I'll take a look at again when formatting issue is gone.

@sheinbergon
And if you can't make test because of the lack of Redis, you are not forced to do. I'm OK to drop the test.

@HeartSaVioR per your approval , I'll fix this PR to contain only the fix for this scenario


[Feature Request]: Want to Enhance Profile/My Account Page

Is there an existing issue for this?

[X] I have searched the existing issues

Feature Description
want to Improve UI of this page
Use Case
This feature Maintains Consinstency of Good user Experience
Benefits
No response
Add ScreenShots

Priority
Medium
Record

[X] I have read the Contributing Guidelines
[X] I'm a GSSOC'24 contributor
[X] I have starred the repository

@nishant0708 go ahead, will add level after seeing your pr

Okay Np.

Hey @sanket95droid @MAVRICK-1 can you add level tag to it please


Some Input Types not functioning in FireFox

Bug type
Component
Component name
Text Field
What happened?
Some InputTypes for the Text Field aren't functioning correctly in FireFox. I've tested this with the most recent FireFox version: 105.0.1. The "InputType.DateTimeLocal" shows a pop-up without the ability so select a time. The "month", "time" and "week" input types doesn't show a pop-up at all. The type icon is missing as well.
Expected looks for the components (shown in Edge):

Unexpected looks for the components (shown in FireFox):

Expected looks for the popup (shown in Edge):

Unexpected looks for the popup (shown in FireFox):

Expected behavior
Same behavior for the pop-ups in all browsers, possibly with different looks.
Reproduction link
https://mudblazor.com/components/textfield#input-types
Reproduction steps

Open this URL in Edge/Chrome: https://mudblazor.com/components/textfield#input-types.
Open the same URL in FireFox.
See the difference in behavior.

Relevant log output
No response
Version (bug)
6.0.16
Version (working)
No response
What browsers are you seeing the problem on?
Firefox
On what operating system are you experiencing the issue?
Windows
Pull Request

[ ] I would like to do a Pull Request

Code of Conduct

[X] I agree to follow this project's Code of Conduct

This is expected behavior. In both cases, you are seeing the browser specific input displays. If you wish to have a consistent datetime entry, use the MudDatePicker. 😄

This is expected behavior. In both cases, you are seeing the browser specific input displays. If you wish to have a consistent datetime entry, use the MudDatePicker. 😄

Thank you for your response. I was not aware that these popups are generated by the browser. I'm kinda confused because FireFox handles InputType.DateTimeLocal not only in a different way, but also a useless way (it only prompts for date, not for time).
I took a look at the MudDatePicker, but that one doesn't include time, just as the MudTimePicker doesn't include the date. I guess i'll redesign my forms. Thank you.


Fix titles case

This PR fixes titles case in the README file.

Thanks for the pull request. However I think that titles are fine as is.


chore: jxpy to 0.0.10

chore: Promote jxpy to version 0.0.10

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please assign
You can assign the PR to them by writing /assign  in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


FIxes to run dbbackup management command in Postgres for non-latin Windows.

Fix 'pg_dump too many command-line arguments' error in Windows / Postgres 9.4 (command-line arguments must precede database name).
Fix non-Latin bytes error result of pg_dump being displayed / logged as hex bytes instead of easily readable utf-8 string.

Thank for your contribution,
Could you tell me what was the error before this patch ?

It was pg_dump 'too many command-line arguments' error in Windows / Postgres 9.4

It fixed the same problem (pg_dump 'too many command-line arguments' ), I'm using Windows 10, PostgreSQL 10.3 and Django 2.0.4

Hi can you explain please why you rejected this pull request?

@momar07005 The PR hasn't been rejected.
It's just the project doesn't have active mainteners
And to accept this we must ensure it works with functional/unit tests and doesn't break non-windows users.

Merged with trust of community


Fix resolve on BLE from ip network commissioning.

IP network provisioning was incorrectly early-returning from the
resolve callback and not sending data through to the python stack
for BLE.
Problem
IP network commissioning broke the resolve portion of the BLE connection
Change overview
Fixes the OnNodeIdResolved function to remove early return that bypassed the python delegate.
Testing
Set up M5 with no network credentials. Connected via chip-device-ctrl using BLE
connect -qr "[qrcode]"
zcl NetworkCommissioning AddWiFiNetwork [nodeid] 0 0 ssid=str:[ssid] credentials=str:[pass] breadcrumb=0 timeoutMs=1000
zcl NetworkCommissioning EnableNetwork [nodeid] 0 0 networkID=str:[ssid] breadcrumb=0 timeoutMs=1000
resolve 0 [nodeid]
Last resolve used to fail, now it passes.

@cecille Thank you for the quick fix!


In the crt, the constraint should be "1 <= m[i]", but the assert is "1 < m[i]"

ac-library-rs
https://github.com/rust-lang-ja/ac-library-rs/blob/ee0d3df1aa0e7d3c65daaa7cc9d7fb13a46928f2/src/math.rs#L36
original ACL
https://atcoder.github.io/ac-library/document_en/math.html
https://github.com/atcoder/ac-library/blob/2a8bc7147f23a8783d7c0603330773117fde710e/atcoder/math.hpp#L40

Thank you for pointing it out.


Add support to ioredis

Hi,
I added an option named subEvent, so we could supply an ioredis client by providing the proper event as discussed here https://github.com/socketio/socket.io-redis/issues/60.
With this option we could use ioredis directly which would be great as it's a well deserved redis client.

+1
ioredis supports redis-cluster while node-redis doesn't and has a better performance

LGTM :+1:
@nkzawa @rauchg what do you think?

I think this is a really nice feature.
How/When can I get this from npm?
What about a new release of socket.io-redis?

FI, If can't wait the next release, npm install --save https://github.com/socketio/socket.io-redis

+1 for new release

Hi, with this new commit, can anyone tell me how do I exactly pass in an io-redis instance? Thank you very much!

@artofspeed Just pass messageBuffer as the subEvent option, and you'll be able to use an ioredis instance in the pubClient/subClient.
But this commit isn't out yet, we are still waiting for a new release


[Feature Request] Exception details

Hi! In the process of configuring CI/CD, I encountered exceptions. All network errors are not very informative:
🦋  Creating git tag...
🦋  New tag<EMAIL_ADDRESS>[command]/usr/bin/git push origin --tags
To https://gitlab.com/***/***/***.git
 * [new tag]<EMAIL_ADDRESS>-><EMAIL_ADDRESS>HTTPError: Response code 403 (Forbidden)
    at Request.<anonymous> (/builds/***/***/***/node_modules/got/dist/source/as-promise/index.js:118:42)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5) {
  code: 'ERR_NON_2XX_3XX_RESPONSE',
  timings: {
    start: 169332[73](https://gitlab.com/***/***/***/-/jobs/0000000000#L73)1[77](https://gitlab.com/***/***/***/-/jobs/0000000000#L77)94,
    socket:<PHONE_NUMBER>796,
    lookup:<PHONE_NUMBER>799,
    connect: 169332731[78](https://gitlab.com/***/***/***/-/jobs/0000000000#L78)02,
    secureConnect:<PHONE_NUMBER>810,
    upload:<PHONE_NUMBER>811,
    response: 169332731[80](https://gitlab.com/***/***/***/-/jobs/0000000000#L80)64,
    end:<PHONE_NUMBER>067,
    error: undefined,
    abort: undefined,
    phases: {
      wait: 2,
      dns: 3,
      tcp: 3,
      tls: 8,
      request: 1,
      firstByte: 253,
      download: 3,
      total: 273
    }
  },
  description: '403 Forbidden'
}
error Command failed with exit code 1.

It is unclear which part of the process the problem occurred with. It would be cool to see the details about the error 👉👈

Well, PR welcome.

Related https://github.com/jdalrymple/gitbeaker/issues/2600

The error has a cause object connected to it. In this cause object you can access the raw Response object from fetch, including all the connected instances methods for seeing more information about the request.
I try to parse out  the actual error messages, but sometimes they are not caught depending on the format that is returned

https://github.com/jdalrymple/gitbeaker/blob/52ef0e622de304d98afb811f4937560edefd8889/packages/rest/src/Requester.ts#L79-L86
@jdalrymple Thanks the codes here make a lot of sense to me for understanding the error structure.


A missing file causes failure with poor error message

This issue was originally created at: 2014-08-26 08:49:48.
This issue was reported by: managan.
managan said at 2014-08-26 08:49:48

If a Tex file inputs a missing file the builder errors out and the message is
totally obscure. There is a logic flaw that results in a an uninitialized
reference that needs to be fixed so we get the LaTeX error message instead of a
failure in the builder.

managan said at 2014-08-26 09:54:26

I put a patch for this issue in https://bitbucket.org/managan/scons_newglossary-fix
The test is not working yet. I need to figure out how to run a test and
distinguish a bad stderr result from a "good" stderr result.

bdbaddog said at 2015-09-30 19:23:55

Fix typo in summary

@managan - any chance you still have this patch?

@managan - any chance you still have this patch?

Found the original email that prompted this so I think I should be able to find it or reproduce it

Found the original email that prompted this so I think I should be able to find it or reproduce it

I have reproduced this. Could not find the original patch. Need to work on a test.

I have reproduced this. Could not find the original patch. Need to work on a test.

I reproduced the bug and the fix. No test deck yet. What is the link to the current development process of submitting a branch...

I reproduced the bug and the fix. No test deck yet. What is the link to the current development process of submitting a branch...

@managan  - https://github.com/SCons/scons/wiki/GitWorkflows

@managan  - https://github.com/SCons/scons/wiki/GitWorkflows

Thanks, still at the point of trying to figure out how to distinguish if SCons fails with an exception or just by failing to produce output. The user request was to avoid the exception and have SCons tell you what went wrong.
Are there tests that look for a specific type of failure? Or do you have to write a wrapper to latex like some do and just test the scanning failure...

Thanks, still at the point of trying to figure out how to distinguish if SCons fails with an exception or just by failing to produce output. The user request was to avoid the exception and have SCons tell you what went wrong.
Are there tests that look for a specific type of failure? Or do you have to write a wrapper to latex like some do and just test the scanning failure...

For clarity I am at this point. The stdout and stderr are expected but cause test.run to fail.
managan@rzalastor1[Scons_managan/scons]{master} python3 runtest.py test/TEX/missingInput.py
1/1 (100.00%) /usr/tce/packages/python/python-3.7.2/bin/python3 test/TEX/missingInput.py
/usr/WS2/managan/Scons_managan/scons/scripts/scons.py returned 2
STDOUT =========================================================================
scons: Reading SConscript files ...
scons: done reading SConscript files.
scons: Building targets ...
cd . && pdftex -interaction=nonstopmode -recorder test.tex
This is pdfTeX, Version 3.1415926-2.5-1.40.14 (TeX Live 2013)
restricted \write18 enabled.
entering extended mode
(./test.tex
! I can't find file `{preamble.tex}'.
l.2 \input{preamble.tex}
(Press Enter to retry, or Control-D to exit)
Please type another input file name
! Emergency stop.
l.2 \input{preamble.tex}
!  ==> Fatal error occurred, no output PDF file produced!
Transcript written on test.log.
pdftex returned an error, check the log file
scons: building terminated because of errors.
STDERR =========================================================================
scons: *** [test.pdf] Error 1
FAILED test of /usr/WS2/managan/Scons_managan/scons/scripts/scons.py
at line 620 of /usr/WS2/managan/Scons_managan/scons/testing/framework/TestCommon.py (_complete)
from line 723 of /usr/WS2/managan/Scons_managan/scons/testing/framework/TestCommon.py (run)
from line 427 of /usr/WS2/managan/Scons_managan/scons/testing/framework/TestSCons.py (run)
from line 65 of test/TEX/missingInput.py

For clarity I am at this point. The stdout and stderr are expected but cause test.run to fail.
managan@rzalastor1[Scons_managan/scons]{master} python3 runtest.py test/TEX/missingInput.py
1/1 (100.00%) /usr/tce/packages/python/python-3.7.2/bin/python3 test/TEX/missingInput.py
/usr/WS2/managan/Scons_managan/scons/scripts/scons.py returned 2
STDOUT =========================================================================
scons: Reading SConscript files ...
scons: done reading SConscript files.
scons: Building targets ...
cd . && pdftex -interaction=nonstopmode -recorder test.tex
This is pdfTeX, Version 3.1415926-2.5-1.40.14 (TeX Live 2013)
restricted \write18 enabled.
entering extended mode
(./test.tex
! I can't find file `{preamble.tex}'.
l.2 \input{preamble.tex}
(Press Enter to retry, or Control-D to exit)
Please type another input file name
! Emergency stop.
l.2 \input{preamble.tex}
!  ==> Fatal error occurred, no output PDF file produced!
Transcript written on test.log.
pdftex returned an error, check the log file
scons: building terminated because of errors.
STDERR =========================================================================
scons: *** [test.pdf] Error 1
FAILED test of /usr/WS2/managan/Scons_managan/scons/scripts/scons.py
at line 620 of /usr/WS2/managan/Scons_managan/scons/testing/framework/TestCommon.py (_complete)
from line 723 of /usr/WS2/managan/Scons_managan/scons/testing/framework/TestCommon.py (run)
from line 427 of /usr/WS2/managan/Scons_managan/scons/testing/framework/TestSCons.py (run)
from line 65 of test/TEX/missingInput.py

Any chance you can hop on discord to discuss? https://discord.gg/bXVpWAy

Any chance you can hop on discord to discuss? https://discord.gg/bXVpWAy


Add code suggestions to comments

When possible, add code suggestions to the warnings.
As an example,
Instead of…

macro_names

Invalid macro name the_macro on line 11. Use UPPER_CASE.

…say…

macro_names

Invalid macro name the_macro on line 11. Use UPPER_CASE.
QuickFix: replace it by THE_MACRO

What I've seen other projects do (not Erlang, but other linters) is link the results to a particular page in a Wiki. That way you don't have to make a release in case you make an error in the text or improve the way you want to suggest stuff. But they also have the warnings tagged and numbered (I'm not sure we want this).

It's a great idea, we just need to keep the wiki up-to-date.


jf npm install command throws 401 error message.

Describe the bug
jf npm install fails with “npm ERR! code E401” error even if configured with valid tokens.
Configured the .npmrc file and npm registry with CLI and configured the dependency repo using “jf npm-config” commands.
C:\Users\manojkumarm>jf npm install mocha 06:32:00 [Info] Running npm install. npm ERR! code E401 npm ERR! Incorrect or missing password. npm ERR! If you were trying to login, change your password, create an npm ERR! authentication token or enable two-factor authentication then npm ERR! that means you likely typed your password in incorrectly. npm ERR! Please try again, or recover your password at: npm ERR!     https://www.npmjs.com/forgot npm ERR! npm ERR! If you were doing some other operation then your saved credentials are npm ERR! probably out of date. To correct this please try logging in again with: npm ERR!     npm login {   "error": {     "code": "E401",     "summary": "Incorrect or missing password.",     "detail": "If you were trying to login, change your password, create an\nauthentication token or enable two-factor authentication then\nthat means you likely typed your password in incorrectly.\nPlease try again, or recover your password at:\n    https://www.npmjs.com/forgot\n\nIf you were doing some other operation then your saved credentials are\nprobably out of date. To correct this please try logging in again with:\n    npm login"   } }
But the same working with normal “npm install” commands.
C:\Users\manojkumarm>jf npm install danger 06:26:59 [Info] Running npm install. npm WARN config global --global, --localare deprecated. Use--location=globalinstead. npm WARN config global--global, --localare deprecated. Use--location=globalinstead. npm WARN config global--global, --localare deprecated. Use--location=globalinstead. {   "added": 130,   "removed": 0,   "changed": 0,   "audited": 377,   "funding": 0,   "audit": {     "vulnerabilities": {       "info": 0,       "low": 0,       "moderate": 0,       "high": 0,       "critical": 0,       "total": 0     },     "dependencies": {       "prod": 376,       "dev": 0,       "optional": 1,       "peer": 0,       "peerOptional": 0,       "total": 376     }   } } 06:27:49 [Info] npm install finished successfully.
Current behavior
jf npm install fails with the “npm ERR! code E401” error.
Configured the .npmrc file and npm registry with CLI and configured the dependency repo using “jf npm-config” commands.
C:\Users\manojkumarm>jf npm install mocha 06:32:00 [Info] Running npm install. npm ERR! code E401 npm ERR! Incorrect or missing password. npm ERR! If you were trying to login, change your password, create an npm ERR! authentication token or enable two-factor authentication then npm ERR! that means you likely typed your password in incorrectly. npm ERR! Please try again, or recover your password at: npm ERR!     https://www.npmjs.com/forgot npm ERR! npm ERR! If you were doing some other operation then your saved credentials are npm ERR! probably out of date. To correct this please try logging in again with: npm ERR!     npm login {   "error": {     "code": "E401",     "summary": "Incorrect or missing password.",     "detail": "If you were trying to login, change your password, create an\nauthentication token or enable two-factor authentication then\nthat means you likely typed your password in incorrectly.\nPlease try again, or recover your password at:\n    https://www.npmjs.com/forgot\n\nIf you were doing some other operation then your saved credentials are\nprobably out of date. To correct this please try logging in again with:\n    npm login"   } }
But the same working with normal “npm install” commands.
C:\Users\manojkumarm>jf npm install danger 06:26:59 [Info] Running npm install. npm WARN config global --global, --localare deprecated. Use--location=globalinstead. npm WARN config global--global, --localare deprecated. Use--location=globalinstead. npm WARN config global--global, --localare deprecated. Use--location=globalinstead. {   "added": 130,   "removed": 0,   "changed": 0,   "audited": 377,   "funding": 0,   "audit": {     "vulnerabilities": {       "info": 0,       "low": 0,       "moderate": 0,       "high": 0,       "critical": 0,       "total": 0     },     "dependencies": {       "prod": 376,       "dev": 0,       "optional": 1,       "peer": 0,       "peerOptional": 0,       "total": 376     }   } } 06:27:49 [Info] npm install finished successfully.
the
Reproduction steps

Configured Art instance with CLI “jf c add” and tested the connection.
Configured the npm repo using “jf npm-config”
Configured the npm registry using “jf npm config set registry”.
Run “jf npm login” and it will show a link and via the link logged in to Artifactory.
Run “jf npm install” which will throw an error “E401”.From the debug logs it shows “ verbose stack HttpErrorAuthUnknown: Unable to authenticate, need: Basic realm="Artifactory Realm"
The same token working with normal “npm install”
Downgraded the node version to 18.0.0 and below both “jf npm install” and “npm install” working fine.
Tested with 18.14.0, 18.14.1 and latest 19.17.0 etc. The "jf npm install" throws a 401 error.

`C:\Users\manojkumarm>jf --version
jf version 2.34.2
C:\Users\manojkumarm>node --version
v18.14.0
C:\Users\manojkumarm>npm --version
10.3.1
`
Expected behavior
The “jf npm install” should work with valid tokens and shouldn’t throw 401 errors.
JFrog CLI version
2.34.2
Operating system type and version
Windows, Mac and Linux
JFrog Artifactory version
NA
JFrog Xray version
NA

Hey @manojkumarm-git, thanks for reporting this issue; we are aware of it and working on it. For now, you can add this field to your .npmrc instead of the _auth field:
//<server-url>/artifactory/api/npm/<npm_remote_repo_name>:_auth = "<npm_auth_token>"
To generate the npm_auth_token:
curl -u <username>:<access_token> https://<server-url>/artifactory/api/npm/auth/
Let me know if it works for you.

Hi @omerzi , I tried the above configuration and got the same 401 output from "jf npm install".

Hey @manojkumarm-git, I opened a PR with a fix:
https://github.com/jfrog/jfrog-cli-core/pull/695
Once it's approved and released I'll let you know.

This is blocking all our releases too. @omerzi  I've raised 238557 with support, hopefully that will help you get this merged quicker.

Thanks for reporting this issue - @rvodden, @usinelogicielle & @manojkumarm-git!
We think that the root causes are two breaking changes introduced somewhere in npm 9.3.
We are also aware of the urgency and are working to deliver a fix quickly, with thoughts about keeping supporting old npm versions.
We'll keep you posted.

Hey @rvodden @usinelogicielle  @manojkumarm-git, JFrog CLI v2.34.5 has been released with a fix. I would appreciate it if you could let me know if it work for you. Thanks!

@omerzi I am still seeing a build failure, but I'm yet to establish if this is owing to jf cli or something unrelated - the error message has certainly changed, so we're definitely making progress! What I'm seeing now is:
definitely on the latest jf cli:
Run jfrog/setup-jfrog-cli@v3
Setup JFrog CLI
  Downloading JFrog CLI from https://releases.jfrog.io/artifactory/jfrog-cli/v2/2.34.5/jfrog-cli-linux-amd64/jfrog
  /opt/hostedtoolcache/jf/2.34.5/x64/jf config add setup-jfrog-cli-server --url https://humanisingautonomy.jfrog.io/ --access-token ***

results in this error:
Run jf npm ci --legacy-peer-deps
  jf npm ci --legacy-peer-deps
  shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}
  env:
    JFROG_CLI_ENV_EXCLUDE: *password*;*secret*;*key*;*token*;*auth*;JF_ARTIFACTORY_*;JF_ENV_*;JF_URL;JF_USER;JF_PASSWORD;JF_ACCESS_TOKEN
    JFROG_CLI_OFFER_CONFIG: false
    JFROG_CLI_BUILD_NAME: Testing upload_test_results_to_xray
    JFROG_CLI_BUILD_NUMBER: 147
    JFROG_CLI_BUILD_URL: https://github.com/HumanisingAutonomy/ha-foundation-github-actions/actions/runs/4[2](https://github.com/HumanisingAutonomy/ha-foundation-github-actions/actions/runs/4282157675/jobs/7456077569#step:5:2)82157675
    JFROG_CLI_USER_AGENT: setup-jfrog-cli-github-action/[3](https://github.com/HumanisingAutonomy/ha-foundation-github-actions/actions/runs/4282157675/jobs/7456077569#step:5:3).0.0
12:05:59 [Info] Running npm ci.
npm WARN deprecated<EMAIL_ADDRESS>Use @octokit/webhooks-types, @octokit/webhooks-schemas, or @octokit/webhooks-examples instead. See https://github.com/octokit/webhooks/issues/[4](https://github.com/HumanisingAutonomy/ha-foundation-github-actions/actions/runs/4282157675/jobs/7456077569#step:5:4)47

><EMAIL_ADDRESS>prepare
> mkdir -p dist && cp -r src/queries dist && ncc build --source-map --license licenses.txt

ncc: Version 0.31.1
ncc: Compiling file index.js into CJS
Error: error:0308010C:digital envelope routines::unsupported
    at new Hash (node:internal/crypto/hash:71:19)
    at Object.createHash (node:crypto:133:10)
    at hashOf (/home/runner/work/ha-foundation-github-actions/ha-foundation-github-actions/upload_test_results_to_xray/node_modules/@vercel/ncc/dist/ncc/index.js.cache.js:37:18[5](https://github.com/HumanisingAutonomy/ha-foundation-github-actions/actions/runs/4282157675/jobs/7456077569#step:5:5)5992)
    at ncc (/home/runner/work/ha-foundation-github-actions/ha-foundation-github-actions/upload_test_results_to_xray/node_modules/@vercel/ncc/dist/ncc/index.js.cache.js:37:18[6](https://github.com/HumanisingAutonomy/ha-foundation-github-actions/actions/runs/4282157675/jobs/7456077569#step:5:6)045[7](https://github.com/HumanisingAutonomy/ha-foundation-github-actions/actions/runs/4282157675/jobs/7456077569#step:5:7))
    at runCmd (/home/runner/work/ha-foundation-github-actions/ha-foundation-github-actions/upload_test_results_to_xray/node_modules/@vercel/ncc/dist/ncc/cli.js.cache.js:1:5512[8](https://github.com/HumanisingAutonomy/ha-foundation-github-actions/actions/runs/4282157675/jobs/7456077569#step:5:8))
    at 81[9](https://github.com/HumanisingAutonomy/ha-foundation-github-actions/actions/runs/4282157675/jobs/7456077569#step:5:9) (/home/runner/work/ha-foundation-github-actions/ha-foundation-github-actions/upload_test_results_to_xray/node_modules/@vercel/ncc/dist/ncc/cli.js.cache.js:1:5[16](https://github.com/HumanisingAutonomy/ha-foundation-github-actions/actions/runs/4282157675/jobs/7456077569#step:5:17)98)
    at __webpack_require__ (/home/runner/work/ha-foundation-github-actions/ha-foundation-github-actions/upload_test_results_to_xray/node_modules/@vercel/ncc/dist/ncc/cli.js.cache.js:1:59048)
    at /home/runner/work/ha-foundation-github-actions/ha-foundation-github-actions/upload_test_results_to_xray/node_modules/@vercel/ncc/dist/ncc/cli.js.cache.js:1:59260
    at /home/runner/work/ha-foundation-github-actions/ha-foundation-github-actions/upload_test_results_to_xray/node_modules/@vercel/ncc/dist/ncc/cli.js.cache.js:1:593[21](https://github.com/HumanisingAutonomy/ha-foundation-github-actions/actions/runs/4282157675/jobs/7456077569#step:5:22)
    at Object.<anonymous> (/home/runner/work/ha-foundation-github-actions/ha-foundation-github-actions/upload_test_results_to_xray/node_modules/@vercel/ncc/dist/ncc/cli.js:8:[28](https://github.com/HumanisingAutonomy/ha-foundation-github-actions/actions/runs/4282157675/jobs/7456077569#step:5:29)) {
  opensslErrorStack: [ 'error:0[30](https://github.com/HumanisingAutonomy/ha-foundation-github-actions/actions/runs/4282157675/jobs/7456077569#step:5:31)00086:digital envelope routines::initialization error' ],
  library: 'digital envelope routines',
  reason: 'unsupported',
  code: 'ERR_OSSL_EVP_UNSUPPORTED'
}
npm ERR! code 1

So it looks like jf cli is now succeeding! Give me a few minutes to work out why the next step is giving me that error. Thanks very much for the push on this. I really appreciate the pace at which you managed to get this fix out!

@omerzi yeah, that was nothing to do with you. jf cli is working perfectly again for us now. Thank you very much for your expedience is resolving this!

I'm glad to hear that @rvodden! Feel free to contact us if you have any further questions or need any assistance.


preliminary str parse and format methods

add undate parse and format methods (~ analogous to datetime.strptime and strftime) to allow parsing and formatting dates as strings using any defined formatter class (to be expanded later for more formatting options)
this resolves #87 and is something we can built out for more flexible formatting options later

@coderabbitai full review

@coderabbitai full review


IconButton is read as "Button" with VoiceOver on macOS desktop app

Is there an existing issue for this?

[X] I have searched the existing issues
[X] I have read the guide to filing a bug

Steps to reproduce

Turn on VoiceOver
Execute flutter run -d macos on the code sample
Focus the icon button

Expected results
The button is read as "this is a tooltip button"
Actual results
The button is read as "button"
Code sample
Code sample
import 'package:flutter/material.dart';

void main() => runApp(const MyApp());

class MyApp extends StatelessWidget {
  const MyApp({super.key});

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'Flutter Code Sample',
      home: Scaffold(
        body: IconButton(
          icon: const Icon(Icons.settings),
          tooltip: 'This is a tooltip',
          onPressed: () {},
        ),
      ),
    );
  }
}

Screenshots or Video
No response
Logs
Logs
https://pastebin.com/4A82aFF7

Flutter Doctor output
Doctor output
[✓] Flutter (Channel stable, 3.7.12, on macOS 13.4 22F66 darwin-arm64, locale
    en)
    • Flutter version 3.7.12 on channel stable at /Users/bourdakos/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 4d9e56e694 (8 weeks ago), 2023-04-17 21:47:46 -0400
    • Engine revision 1a65d409c7
    • Dart version 2.19.6
    • DevTools version 2.20.1

[✗] Android toolchain - develop for Android devices
    ✗ Unable to locate Android SDK.
      Install Android Studio from:
      https://developer.android.com/studio/index.html
      On first launch it will assist you in installing the Android SDK
      components.
      (or visit https://flutter.dev/docs/get-started/install/macos#android-setup
      for detailed instructions).
      If the Android SDK has been installed to a custom location, please use
      `flutter config --android-sdk` to update to that location.

[!] Xcode - develop for iOS and macOS (Xcode 14.2)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 14C18
    ✗ CocoaPods not installed.
        CocoaPods is used to retrieve the iOS and macOS platform side's plugin
        code that responds to your plugin usage on the Dart side.
        Without CocoaPods, plugins will not work on iOS or macOS.
        For more info, see https://flutter.dev/platform-plugins
      To install see
      https://guides.cocoapods.org/using/getting-started.html#installation for
      instructions.

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[!] Android Studio (not installed)
    • Android Studio not found; download from
      https://developer.android.com/studio/index.html
      (or visit https://flutter.dev/docs/get-started/install/macos#android-setup
      for detailed instructions).

[✓] VS Code (version 1.79.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version null

[✓] Connected device (2 available)
    • macOS (desktop) • macos  • darwin-arm64   • macOS 13.4 22F66 darwin-arm64
    • Chrome (web)    • chrome • web-javascript • Google Chrome 114.0.5735.133

[✓] HTTP Host Availability
    • All required HTTP hosts are available

! Doctor found issues in 3 categories.

Thanks for the report @bourdakos1
Can you take a look at this similar / related issue and check if it resemble your case ?

#111094 looks to be about duplicate readings when using the semantics widget, but the issue I’m seeing is no reading of the tooltip for the icon button widget


Field value empties when invalid

Here is the behaviour I see.  On 0.8.5.  I believe it is from something introduced in 0.8.3.
If a field has (say) a min and / or max range and you tab off it while it has an invalid value the field value is set to blank.
The reformatViewValue() function is run after a $commitViewValue and gets the $modelValue and runs the formatters over it and then sets the view value.  I suspect $commitViewValue does not actually commit the value from the view to the model if there are validation failures.  So, ngModel.$modelValue is actually undefined if the field view value fails validation  .. meaning the formatters are executed on an undefined value, and that undefined value then becomes the new view value.  Stuff goes blank then.
Perhaps consider using the $viewValue in reformatViewValue() rather than $modelValue?

Hi @StrayAlien I'm checking it.

Please, update to v0.8.6 and feel free to reopen this ticket if you have any problem.

Thanks @aguirrel.  That has resolved the issue.  Actually, it has also fixed another issue that an amount outside the min/max range (that is, failing validation) was not formatted with the currency sign and thousands separators.
Thanks again.


change MainWindow to display "Card Packs", with Cards in the side window

@jethrokuan is this equivalent to "replace PersonListPanel with CardListPanel"?

@yong-jie cardListPanel would have to go into the side window, the left panel is where the user would select the list of cards to review. That's not implemented yet, will need to wait for #41 to be pushed out, and more.

This is resolved with #56


Latest install (1.4.4) causes issues with HA Mobile App

I just installed version 1.4.4 and am having issues with the HA Mobile App now. Clicking on the Hamburger button within the HA Mobile App does nothing when Custom-Header is loaded in my config file. If I do not load Custom-Header on a reboot, the mobile app works as it should. This is even with commenting out the Custom Header settings in the ui-lovelace.yaml file.
Here is my config:
lovelace:
mode: yaml
resources:

url: /local/plugins/custom-header.js?v=1.4.4
type: module

I noticed that as well. Current workaround is to swipe from the edge to reveal the menu.

@luisiam this is very difficult to do with Google's gesture control..

Same here. 1.4.4 menu button doesn’t work on app or mobile site

@jes1417 glad that I am on iOS and the gesture works reasonably well

I got it figured out, Google's gesture control use that motion to go back but if you swipe slightly down while pulling off the edge of the screen the side drawer opens reliably.

Agreed, the gesture on the iOS app does the trick.

Why did you close the issue @sparment, it's not solved.

So, wait....  Is the intent just to live with a work-around?

Sorry. I assumed that if there was a solution it should be closed. This was my first issue created on GitHub...

A workaround is not a solution 😉

This has been addressed in the latest releases. Current release is 1.4.5. Close if this has been resolved, share any additional info if it has not.

The latest release 1.4.5 solved the issue. Thank you!


nodeID should be created by the commissioner APIs but not by the controller apps

Per 0.7 spec referred below (page 224) nodeID should be unique within the fabric, and fabricID is scoped to a RootCA.
Right now both python controller and chip-tool are hardcoding/randomly generating it in the app layer, while this should be left to SDK layer Commissioner APIs to make sure the nodeID generated is indeed unique to that fabric. Current implementation doesn't guarantee that.

Proposed Solution
<suggested fix, suggested enhancement>

The fundamental issue is the OperationalCredentialsDelegate has the wrong public interface, which fundamentally assume a "test" flow which has the controller assign the NodeID. There is no possibility of having the actual device attestation as part of the CSR processing by a CA, based on the public interface signature:
/**
     * @brief
     *   This function processes the CSR sent by the device.
     *   (Reference: Specifications section <IP_ADDRESS>. OpCSR Elements)
     *
     * @param[in] CSR             The Certificate Signing Request.
     * @param[in] CSRNonce        The Nonce sent by us when we requested the CSR.
     * @param[in] VendorReserved1 vendor-specific information that may aid in device commissioning.
     * @param[in] VendorReserved2 vendor-specific information that may aid in device commissioning.
     * @param[in] VendorReserved3 vendor-specific information that may aid in device commissioning.
     * @param[in] Signature       Cryptographic signature generated for all the above fields.
     */
    CHIP_ERROR ProcessOpCSR(const ByteSpan & CSR, const ByteSpan & CSRNonce, const ByteSpan & VendorReserved1,
                            const ByteSpan & VendorReserved2, const ByteSpan & VendorReserved3, const ByteSpan & Signature);

The DA signature is over the entire OpCSR elements, and having them split up prevents proper verification.
Similarly:
    /**
     * @brief
     *   This function generates an operational certificate for the given node.
     *   The API generates the certificate in X.509 DER format.
     *
     *   The delegate is expected to use the certificate authority whose certificate
     *   is returned in `GetIntermediateCACertificate()` or `GetRootCACertificate()`
     *   API calls.
     *
     * @param[in] peerId       Node ID and Fabric ID of the target device.
     * @param[in] csr          Certificate Signing Request from the node in DER format.
     * @param[in] serialNumber Serial number to assign to the new certificate.
     * @param[in] certBuf      The API will fill in the generated cert in this buffer. The buffer is allocated by the caller.
     * @param[in] certBufSize  The size of certBuf buffer.
     * @param[out] outCertLen  The size of the actual certificate that was written in the certBuf.
     *
     * @return CHIP_ERROR CHIP_NO_ERROR on success, or corresponding error code.
     */
    virtual CHIP_ERROR GenerateNodeOperationalCertificate(const PeerId & peerId, const ByteSpan & csr, int64_t serialNumber,
                                                          uint8_t * certBuf, uint32_t certBufSize, uint32_t & outCertLen) = 0;

The above API is called directly from inside the commissioner logic in CHIPDeviceController.cpp's ProcessOpCSR(), where the local commissioner assigns a node ID and serial number to the opcert, which is the reverse of the flow.
Suggested fix:

Separate OperationalCredentialsDelegate into more pieces, including a local sample CA interface.
If there is sample code, this should be delegate to a new CA sample interface called from the OperationalCredentialsDelegate, so that the core elements passed down are:
<CSR Information, CSR attestation signature, Attestation Challenge, DAC cert chain>. Those are what is needed to generate a legitimate operational certificate, and do so with device attestation in the picture.

Per 0.7 spec referred below (page 224) nodeID should be unique within the fabric, and fabricID is scoped to a RootCA.
Right now both python controller and chip-tool are hardcoding/randomly generating it in the app layer, while this should be left to SDK layer Commissioner APIs to make sure the nodeID generated is indeed unique to that fabric. Current implementation doesn't guarantee that.

Proposed Solution
<suggested fix, suggested enhancement>

Could you tell my how might I get the spec?

This is trivially addressable for integrating commissioner apps with the approach introduced in https://github.com/project-chip/connectedhomeip/pull/13294.

@msandstedt @cjandhyala is this still an issue? Does it need to be fixed for 1.0?

I believe we can now declare this as fixed with #13801, for which I had opened #13500.
Most recently, commissioners could specify fabric and node IDs to signing infrastructure, which allows for one type of solution where a local entity manages IDs and prevents collisions on fabrics.
But now signing infrastructure can also specify fabric and node IDs to commissioners, as the commissioner code will now extract these from certificates passed back through the operational credentials delegate.


Stuck on Usage!

I would like to do option 1 of Ussage but when cloning the repository later when using react-native-rename this error occurs:

Someone can help me?

HELP!

Hi @GaboMendez, can you share some of you desktop specs and info. It would help as a lot to understand the issue

⚠ This repository is no longer maintained.
If you are looking for expertise in your next React Native project, feel free to contact us!


Anyway to wrap text longer?

Which field, Title or Description? Is it every platform or just one?

Description field. On Both iOS and Android it seems to do it.

iOS it was showing multiple lines. Android it was only showing 1 line. I have enabled BigViewStyles on Android, and in the Notification Center, it now shows multiple lines. However in the HeadsUp notification, this is still limited to 1 line and there seems no way to expand this, from my initial research. BigViewStyles are enabled in package version 3.2.0


NumberInput: Marked as invalid if the value supplied is ''

https://github.com/carbon-design-system/carbon-components-react/blob/master/src/components/NumberInput/NumberInput.js#L156
What happens in the situation where you have an optional NumberInput field?
It seems there is no way to do this, my suggestion is to remove the check and let the consumer make all the decisions about validity with the invalid flag provided

Thanks @AndySeymour2904 for reporting! Sounds that it makes sense - Let’s see what others in the team think.

@asudoh Maybe better add property "strict" for this.


Some question and suggestion regarding the usecase of pagination_view.

what if I don't want to fetch the new list(pageFetch call) in some condition?
Currently, if I return the empty list for these types of conditions, then it stopped calling the pageFetch
method for future cases where actually I needed to load the upcoming list items.

Suggestion:
preloadedItems should handles the result which can be a future (can be fetched from network).
Or it should by default take an empty list if not provided preLaodItems, and handles the new update from pageFetch.

Sending an empty list when your condition is met in pageFetch is the current best solution.
This is can be done in the future update. But for now you can preload a list with [null] and check for null in itemBuilder and use a FutureBuilder to preload items in the null case.


Pickle save

Hack a save that works when compiled with mypyc

I'm not sure about how we should have the save and load dynamic, as in save and load pickle directly?


Optimizing query for memory usage

I am not sure if this is the right place to ask about things like query optimization, so point me in the right direction if it isn't :)
I have this query:
SELECT date, uniq(userID), count()
FROM
(
    SELECT
        id,
        date,
        userID
    FROM table
    WHERE blah
    GROUP BY
        id,
        date,
        userID
    HAVING count() = 8
)
GROUP BY date

It's a big table and I am hitting memory limits on my server. I am guessing that clickhouse keeps everything from the subquery in memory, and after it is done it wants to do the outmost query.
The thing is, I can imagine a workflow where this could work without storing everything from subquery in memory. If I run this query for one day only, it works. So if clickhouse knew how, it could run the subquery for each day, use the results for the outer query, and discard the data, then same for the next day, etc... The point is, it can be done.
Is there a way for me to somehow change the query so this could work? Query plan analysis and forcing probably doesn't exist here.

Great, thanks! This solves the failing issue, the query isn't failing anymore.
But still, it uses a huge amount of disc space, and the query is much slower because of writing/reading, and it doesn't have to be.

The thing is, I can imagine a workflow where this could work

Right now ClickHouse has very primitive query optimizer, and there are a lot of optimizations possible. You can contribute the project to make it better.  Or if you really need to get it done that way right now - you can do that optimization 'by hand': you will need to play a bit with query generation, i.e. really iterate through dates doing small selects and combine them with union.


Feature branch cannot restore cache made in main branch

Goal
create snapshots cache in main branch -> restore cache in feature branch to compare snapshots
Issue
Cache hit doesn't happen in the feature branch when trying to restore the main branch's cache.
Instead, it creates a new cache with the exactly same cache key(version).
Would this be a bug?
The feature branch is based off of main branch so the scope shouldn't be an issue here I believe.
(git checkout -b cache-test on main)
The What am I missing here and how can i make this work?

Also noticing searching cache for branch "main" is not returning anything, which seems odd.

# merge.yml - create cache on merge
- name: Store Snapshots Cache
      id: snapshots-cache
      uses: actions/cache@v3
      with:
          path: packages/**/src/**/*.*.tsx-snapshots
          key: ${{ runner.os }}-snapshots-${{ hashFiles('yarn.lock') }}

# pr-push.yml - restore cache on push
- name: Restore Snapshots Cache
      id: snapshots-cache
      uses: actions/cache@v3
      with:
          path: packages/**/src/**/*.*.tsx-snapshots
          key: ${{ runner.os }}-snapshots-${{ hashFiles('yarn.lock') }}
          restore-keys: |
             ${{ runner.os }}-snapshots-

Cache should have been restored from main and created a new cache in feature branch from those files. Can you check the logs if that is the case. Can you also check if the path in both cache steps in main and feature-branch same, that is given in debug log

I resolved this issue with creating the cache on push action on the main branch. It was previously triggered on pr close action. It would be great and save much time of other developers who wanna use actions/cache if it's mentioned in the documentation that only the cache that's generated by push can be accessible to its feature branches as nowhere in the documentation mentions this.

@axionos, can you please share the trigger condition present in your workflow file? Example-
name: Close Pull Request

# only trigger on pull request closed events
on:
  pull_request:
    types: [ closed ]

@kotewar this will trigger the workflow on pull request push.
Before:
name: Pull Request Close
on:
  pull_request:
    branches:
      - main
    types: [closed]

After:
name: Snapshot Update
on:
  push:
    branches:
      - main

Hi @axionos , when the pull_request trigger is used and if there is no cache to be restored i.e there is no matching cache in parent branch or default branch, the cache is created against the refs/pull/<PR_number>/merge( which is a merge branch created by GitHub by merging the PR target branch and the PR branch, check this ). The caches created against ``refs/pull/<PR_number>/merge` can only be used by this PR branch since this is a temp branch created for merging the PR.
In your case, for trigger type:
on:
  pull_request:
    branches:
      - main
    types: [closed]

Since there is no cache with key: Linux-snapshots-350c... in main ref, the cache is created against refs/pull/<PR_number>/merge'. If there would have been cache for main` ref, then that cache would have been restored.

Goal
create snapshots cache in main branch -> restore cache in feature branch to compare snapshots
Issue
Cache hit doesn't happen in the feature branch when trying to restore the main branch's cache.
Instead, it creates a new cache with the exactly same cache key(version).
Would this be a bug?
The feature branch is based off of main branch so the scope shouldn't be an issue here I believe.
(git checkout -b cache-test on main)
The What am I missing here and how can i make this work?

Also noticing searching cache for branch "main" is not returning anything, which seems odd.

# merge.yml - create cache on merge
- name: Store Snapshots Cache
      id: snapshots-cache
      uses: actions/cache@v3
      with:
          path: packages/**/src/**/*.*.tsx-snapshots
          key: ${{ runner.os }}-snapshots-${{ hashFiles('yarn.lock') }}

# pr-push.yml - restore cache on push
- name: Restore Snapshots Cache
      id: snapshots-cache
      uses: actions/cache@v3
      with:
          path: packages/**/src/**/*.*.tsx-snapshots
          key: ${{ runner.os }}-snapshots-${{ hashFiles('yarn.lock') }}
          restore-keys: |
             ${{ runner.os }}-snapshots-

I experience the same issue. The exact cache key exists on the default branch, but it is not used by runs for pull requests.

In my case, the master's cache was created in another workflow than the one that tries to retrieve the cache. However, it concerns the same composite action.
https://github.com/privacybydesign/irmamobile/blob/6a684d3a82de5e06371c02fa2e2f9e356a7d4bb4/.github/actions/setup-build-environment/action.yml#L46


[Bug] accident_count_by_severity - breaks on LTR

Describe the bug
accident_count_by_severity - when changing language to English,
the card content is close to the left
Expected:
Card content should be centered for all languages

Someone has already solved this problem

Could not reconstruct


Add getFormatInfo() to AddressFmt

This method will return the information that user interfaces need to present a locale-sensitive input form for addresses.

Approved. I've confirmed every test cases are passed between node, browser, and QT. 5.4. We should add more test cases.
I'm looking at file regionnames.json, (it's not a related question of this PR)
the key name is different per Country. some of them are number (even I couldn't guess the rule) and some of them are Alphabetic. Where are this data come from? I couldn't find tool code either.

oh. yes, I realize a file name combine with filePrefix +"names.json"
I checked the cldr-json data from  https://github.com/unicode-cldr/cldr-json and I couldn't get data name like '서울특별시' neither I wonder why that data doesn't provide json type.
For Korea, those kinds of number match with region name doesn't familiar. so I was curious.


L1 sync

Changes:

Write a "L1 tracker"

Resolves reorgs
Used to schedule the next block to process on top of any specific local view (to support multiple engines, and be more robust)
Watches for head changes to update tracker
Also polls to ensure nothing is missed if subscription is temporarily shaky

Write a "L1 downloader"

Fetches blocks concurrently
Fetches receipts concurrently, with parallel retrieval of receipts, split between workers
de-duplicate requests (TODO: needs pruning of old requests)

Organize L1 nodes as "sources"

Easier to mock a source interface than a full L1 node
L1 sources can be combined (TODO: head changes of only the first are respected, but downloads etc. are split). Maybe we'll optimize further later,  but at least the design can handle multiple sources

Organize L2 execution engines as "engines"

Keep all engines synced, even if they start at different places
Useful to have L2 redundancy as sequencer etc. (note that beacon nodes also support attaching multiple execution engines)

More node organization: engines, tracker, downloader etc. are all connected (subscriptions etc. are set up and torn down on close)

Status: discuss, some review, then merge into staging. Then driver PR next, and integration tests?
Fix #73

Merging into staging, Hopefully JG can review after holidays


Setup husky with pre commit hook

I separated the lint script and added it to the pre-commit hook along with the test script. I was not sure about adding the lint script to the GitHub actions so didn't add but if you want to add it there I will just add it there too.
@talentlessguy

Codecov Report

Merging #53 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #53   +/-   ##
=======================================
  Coverage   72.10%   72.10%
=======================================
  Files          18       18
  Lines         742      742
  Branches      200      200
=======================================
  Hits          535      535
  Misses        205      205
  Partials        2        2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b3be4b9...c012042. Read the comment docs.

LGTM, merging!

About the lint script, it's uneeded in actions imo. The action is used for checking if packages build with no errors and that tests pass.

@talentlessguy Yes that was my initial thought too .

@all-contributors please add RocktimSaikia for infra


cordova build ios --release bug

If used cordova build ios --release
The application is building, running, but not working. In the log, I see that there is no Cordova.
Is it all or just me? The latest version of the template
exception nativeEvalAndFetch : ReferenceError: Can't find variable: cordova

@VisualMafia I've fixed your issue the problem was happening because Cordova js main file is supposed to be in index.html file for release and development environments, please include this plugin to your release web pack config file:
const CordovaHtmlOutputPlugin = require('../webpack/plugins/CordovaHtmlOutputPlugin.js');  new CordovaHtmlOutputPlugin()
If you want to make sure that you are doing right check this commit before doing it:
https://github.com/caiobiodere/cordova-template-framework7-vue-webpack/commit/0f769825f6c9edb44754c1493923869bf6b8a365

Working, thanks


Update custom app org switch in teams-custom-app-policies-and-settings.md

Closes https://github.com/MicrosoftDocs/OfficeDocs-SkypeForBusiness/issues/9329.

Learn Build status updates of commit 94d2839:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

Teams/teams-custom-app-policies-and-settings.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

Learn Build status updates of commit f548264:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

Teams/teams-custom-app-policies-and-settings.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

Learn Build status updates of commit 336b45e:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

Teams/teams-custom-app-policies-and-settings.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

@ashishguptaiitb PR has been copyedited and is ready for final review, could you please check and merge? Thanks!

Folks, thanks for coordinating this. I shall have to review this internally with the PMs before acting on the bug or this PR.

Closing this old PR. The updated and accurate info was updated in the same help article.