Non-legacy search seems to always use git ignore

Issue Type: Bug
We have a project structure that looks like this:
\gameengine
     \.git
     \<various_engine_folders>
     \actualgame
            \.git
            \<more folders>

I have a workspace set up for this. In it I use
"search.useIgnoreFiles": false,

because otherwise the "actualgame" folder won't be searched - it's speciified in the gameengine's git ignore.
But now I started up VS Code after updating to the latest version and now search (find-in-files) would not find anything in the game folder, unless I opened a file that had the search term in it.
Use Global Ignore Files is false.
When I enabled "Use Legacy Search", the search started working again. It says it supports more text encodings, but we use UTF-8 with \n line endings throughout.
Are there any other settings I may have missed?


Nerds_Shall_Perish

Your checklist for this pull request
Author name
NoneOYoConcern
Author:
Gideon M. Hannsz

TrueCaedmonman
About your game
it is very game-like
What is your game about?
pushing boxes and

How do you play your game?
wasd to move, j to restart, and k to change the music

Code
Check off the items that are true.

[x] The game was made using the Sprig editor.
[ ] The game is placed in the in the /games directory.
[ ] The code is significantly different from all other games in the Sprig gallery (except for games labeled "demo").
[x ] The game runs without errors.
[x ] The name of the file/game contains only alphanumeric characters, -s, or _s.
[x ] The game name is not the same as the others from gallery

Image (If an image is used)

[ ] The image is in the /games/img directory.
[ ] The name of the image matches the name of your file.

Thanks for your PR!

At school
Get Outlook for iOShttps://aka.ms/o0ukef

From: Lucas Honda @.>
Sent: Tuesday, March 5, 2024 1:41:53 PM
To: hackclub/sprig @.>
Cc: ABSolute-L00ser @.>; Mention @.>
Subject: Re: [hackclub/sprig] Nerds_Shall_Perish (PR #1477)
@LucasHT22 requested changes on this pull request.
Thanks for the PR! Where did you hear about Sprig?
—
Reply to this email directly, view it on GitHubhttps://github.com/hackclub/sprig/pull/1477#pullrequestreview-1917962586, or unsubscribehttps://github.com/notifications/unsubscribe-auth/BGWSS4KGZ3ODON5FFDM7TPTYWYNYDAVCNFSM6AAAAABEHLS6LKVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTSMJXHE3DENJYGY.
You are receiving this because you were mentioned.Message ID: @.***>

what is this change request

Just for control purpose

This whole thing seems pretty sketchy

What would you do to make my work better?

Closing this PR due to inactivity. Please feel free to ping me and have this reopened / hopefully merged!


Nodeos folder non-existed after eosio installation with brew

I am trying to install and run an EOS node on macos.
I installed eosio and eosio.cdt with brew.
I used
brew tap eosio/eosio
brew install eosio

Everything went alright. But after installation the following folder was supposed to be created /usr/local/eosio which it did not.
Also, from what I know I should have a folder in my Application Support with the nodeos that was installed with eosio ( since  I want to edit the configuration file for nodeos ). However, I don't have the following folders.
/Users/[user]/Library/Library Support/eosio/nodeos
In the same way I installed eosio.cdt
brew tap eosio/eosio.cdt
brew install eosio.cdt

And it has been installed successfully as well.
Note that nodeos --help works, as well as eosio-cpp --help and cleos --help
I am not sure if I am doing something wrong or the folders have been changed.

Have you had previous installations of eosio on the system? If so, what versions?

Thanks for the respons.
No. This is the first time installing eosio.


Adds support for token based authentication

What does this PR do?
Adds support for using a Conjur authentication token for authorization. This allows the library to leverage Kubernetes authentication, removing the need for host and API keys.
Any background context you want to provide?
The code for this PR comes from the USAA engineering team.
What ticket does this PR close?
Closes #22
Link to build in Jenkins (if appropriate)
https://jenkins.conjur.net/job/cyberark--conjur-api-java/job/authn-kubernetes/ is green, but note that no additional tests have been added.
Has the Version and Changelog been updated?
Yes.

@RafiS3, I have picked up the coding work for this PR from Jason. I'm working on adding some additional CI tests for this change, but in case that doesn't get finished today before the holiday break, I wanted to go ahead and mention that the code changes themselves are ready for another review.
I have deferred adding to this PR for the file watching functionality that is present in the Go API. But I will file a new issue to continue enhancing the Java API with that capability. Since the bulk of this PR was a customer contribution, I'd rather get it merged as close to the original form as is acceptable and then continue to build on it as need or priority dictates.
Let me know what you think! Thanks!


Object.to_json gives unhelpful error message if no to_json defined

require "json"
class A

end

puts A.new.to_pretty_json

results in this rather unfriendly failure message:
in /opt/crystal/src/json/to_json.cr:15: wrong number of arguments for 'A#to_json' (given 1, expected 0)
Overloads are:
 - Object#to_json()

    to_json JSON::PrettyWriter.new(io, indent: indent)

In the perfect world it would have an error message that said something like "you need to define this method or call JSON.mapping"
Thanks!

What about having json define to_json as an abstract method?
require "json"

class Object
  abstract def to_json(io : IO)
end

class Foo
end

puts Foo.new.to_pretty_json

Error in ./issue-3450.cr:4: abstract `def Object#to_json(io : IO)` must be implemented by Reference

  abstract def to_json(io : IO)
               ^~~~~~~

@luislavena That can't work. An abstract method must be implemented by subclasses.
An alternative is to define a to_json(io) on Object that simply gives a better error message:
require "json"

class Object
  def to_json(io)
    {% raise "#{@type} doesn't define a `to_json(io)` method: either implement it or use JSON.mapping" %}
  end
end

class A
end

puts A.new.to_pretty_json

Output:
Error in ./foo.cr:12: instantiating 'A#to_pretty_json()'

puts A.new.to_pretty_json
           ^~~~~~~~~~~~~~

in ./src/json/to_json.cr:9: instantiating 'String:Class#build()'

    String.build do |str|
           ^~~~~

in ./src/string.cr:234: instantiating 'String::Builder:Class#build(Int32)'

    String::Builder.build(capacity) do |builder|
                    ^~~~~

in ./src/string.cr:234: instantiating 'String::Builder:Class#build(Int32)'

    String::Builder.build(capacity) do |builder|
                    ^~~~~

in ./src/json/to_json.cr:9: instantiating 'String:Class#build()'

    String.build do |str|
           ^~~~~

in ./src/json/to_json.cr:10: instantiating 'to_pretty_json(String::Builder)'

      to_pretty_json str, indent: indent
      ^~~~~~~~~~~~~~

in ./src/json/to_json.cr:15: instantiating 'to_json(JSON::PrettyWriter)'

    to_json JSON::PrettyWriter.new(io, indent: indent)
    ^~~~~~~

in ./foo.cr:5: expanding macro

    {% raise "#{@type} doesn't define a `to_json(io)` method: either implement it or use JSON.mapping" %}
    ^

in ./foo.cr:5: can't expand macro: A doesn't define a `to_json(io)` method: either implement it or use JSON.mapping

    {% raise "#{@type} doesn't define a `to_json(io)` method: either implement it or use JSON.mapping" %}
       ^~~~~

The output is still a bit long and it has "can't expand macro", but this could be improved. I don't know if this is a good solution, though.

@asterite doh, forgot that all classes would have to define it for it to work, sorry. :disappointed:
I wouldn't mind use the macro raise but perhaps the backtrace can also be collapsed?

@asterite that looks good to me, good idea.  It's either that or not add to_json to the Object class but make people include it themselves, ruby style
class A
extend JSONModule
end
or
make a new method required to be called like
JSON.add_methods which adds in all the to_json methods including the abstract one.
Or provide a sensible default 'to_json" (#inspect for instance has a default).
Thanks for your help here.

I think it results in a bad API that JSON defines to_json() etc. on every object, even if there is no implementation of to_json(builder : JSON::Builder), so
Maybe it could be a way to use finalize to define to_json() only if to_json(builder) is defined. But i don't know if this would cause other problems and it is probably more like a hack.
Then there is also #4169 suggesting an abstract module JSON::ToJson like rdp one above. This shouldn't be too much extra-effort, because most methods will be probably be generated by JSON.mapping. For other uses it might be helpful to create a macro Object.to_json which defines to_json(builder) and includes the abstract module.

With #5697, the code on top results in: Error in line 6: undefined method 'to_pretty_json' for A.

With code on top in Crystal 0.31.1. it gives
$ crystal e.cr
Showing last frame. Use --error-trace for full trace.

In /usr/local/Cellar/crystal/0.31.1/src/json/to_json.cr:22:7

 22 | to_json(json)
      ^------
Error: no overload matches 'A#to_json' with type JSON::Builder

Overloads are:
 - Object#to_json(io : IO)
 - Object#to_json()


visible columns incorrectly displayed

I ran into this situation when going to a record page -> 'view more' of a related record -> 'clear all' filters.

In this screenshot the columns to the right of 'iri' should not be display, and they are not displayed until clicking the 'clear all' button. Only 'term' and 'iri' should be visible. Also you'll notice that the columns to the right of 'iri' do not have a header.
I tested a different project deployment that is running a somewhat older version of chaise and it does not happen there. I suspect it is a bug since the introduction of faceting, even though faceting is not enabled on the above affected site.
@bugacov FYI

This is probably an ermrestjs bug as I think about it more.

I pushed a fix for this to master. The unfiltered function was not contextualizing reference and was returning an uncontextualized reference, which was causing this behaviour.

thanks!


Fix typo: Weaver -> Weather

I stumbled across https://pirateweather.net/ earlier and eventually found my way here. Thanks for building it!

Great catch, thank you!


[ Improvement ] Backport from 1.21-dev. The entropy whence the priva…

Backport from 1.21-dev. The entropy whence the private keys for wallets are generated needs to be cryptographically secure not merely computationally secure.
Some distros handle RNGs differently, some of that is addressed in this backport from 1.21-dev. If all fails, fallback on /dev/urandom.
Call tree that leads to this function call:

The function    GetOSRand( )  gets called here:
https://github.com/dogecoin/dogecoin/blob/f80bfe9068ac1a0619d48dad0d268894d926941e/src/random.cpp#L132-L151
Hashing SSL's RNG with GetOSRand( ) mitigates this some. But, this is an improvement nonetheless, per Linux docs:
https://github.com/torvalds/linux/blob/a4a78bc8ead44c3cdb470c6e1f37afcabdddfc14/drivers/char/random.c#L110-L121
.
@patricklodder @rnicoll @michilumin

This seems to be a non-deterministic problem. On this CI test feelimit.py failed. I ran all the rpc tests several times and I got the following results:

Passed all tests. (6x)
proxy_test.py failed. (1X)

@patricklodder  Can we re-run all the tests again?

I've restarted the CI, the problem was a mempool sync issue (which is 🤔 because it was on feelimit test, but unrelated to this PR). What was the error on proxy_test? Was it related to mempool synchronization or something else? I think I've seen randomness in proxy_test once or twice in the past.
I'll have to do a dive into the backport - do you have the commits this came from by chance?

@patricklodder Unfortuantely, I did not save the error for the proxy_test.py. I will run it a few more times to see if I can get it again.
There are A LOT of commits, but you I just copied that entire function verbatim from src/random.cpp from 1.21-dev, and then all the dependencies in code it needed to compile.
But, you can look at the Git blame for the history of all the commits:
https://github.com/ReverseControl/dogecoin-1/blame/1.21-dev/src/random.cpp#L276.
I actually think there is a simpler way to do this, on newer CPUS anyway,  but back porting should do for now.

Assigning to 1.14.5

I actually think there is a simpler way to do this, on newer CPUS anyway, but back porting should do for now.

RDRAND and RDSEED; supported on most processors (intel and AMD) from 2015 onward;  RDSEED has more/better entropy but requires Broadwell (5th Gen) or newer on the intel side and Ryzen (1st Gen) or newer on the AMD side.

@michilumin Yes!!! That is what I was alluding to when I said:

I actually think there is a simpler way to do this, on newer CPUS anyway, but back porting should do for now.

I will be implementing this on 1.14.5 as added entropy in addition to what is already there. I will take care of dealing with different processors and only using it when it is there.

This one fell out from the milestone for some reason - probably my mistake.
@ReverseControl I propose we do this hand-in-hand with #2482 and do one big key entropy fix?

@patricklodder I will look into this sometime soon. I just squashed the commits on #2482. Sorry it took so long; should've been included in 1.14.5.


regex mask that includes case insensitive flag is added to the mask

When using a regex mask that includes the case insensitive flag /i, the flag is getting applied as a mask character instead of being used by the regex. I am creating a regex for US states, but want to allow the user to enter upper or lower case.
Using the regex: /(?:AL|AK|AZ|AR|CA|CO|CT|DE|FL|GA|HI|ID|IL|IN|IA|KS|KY|LA|ME|MD|MA|MI|MN|MS|MO|MT|NV|NH|NJ|NM|NY|NC|ND|OH|OK|OR|PA|RI|SC|SD|TN|TX|UT|VT|VA|WA|WV|WI|WY|NE)/i the mask shows as /__/i.  How do I get the case sensitive flag to get used by the regex vs applied to the mask.
Thanks.

https://jsfiddle.net/te019ymv/
OS: Windows
Browser: Chrome
Inputmask version: 5.0.9

The regex option is meant to be used with strings. If you want to allow users to input in any case, use the following setup:
$('#state').inputmask({
  regex:"(?:AL|AK|AZ|AR|CA|CO|CT|DE|FL|GA|HI|ID|IL|IN|IA|KS|KY|LA|ME|MD|MA|MI|MN|MS|MO|MT|NV|NH|NJ|NM|NY|NC|ND|OH|OK|OR|PA|RI|SC|SD|TN|TX|UT|VT|VA|WA|WV|WI|WY|NE)",
  casing: 'upper'
});


Change title of "create new job" button

"The “+” button for creating a new tab is read by screen reader as “create new job tab”. It can be “Add new tab button”"
cc @prashantverma2014

So far I cannot quite reproduce this; specifically the word "new" does not appear for me. When I inspect the document accessibility tree, the name of the "+" button is "Create job". And I guess the screen reader adds "tab" to that. So we could call it "add new job", which the screenreader will turn into "add new job tab"? I don't want to call it "add new" just to get it to say "add new tab", because that's a bad description by itself (add new what? there will be some other features coming that could also have components called "add new ", so I want to be specific from the start)

I agree with changing it to "add new job",
From: Marisa DeMeglio @.>
Sent: Thursday, December 8, 2022 2:03 AM
To: daisy/pipeline-ui @.>
Cc: Prashant Ranjan Verma @.>; Mention @.>
Subject: Re: [daisy/pipeline-ui] Change title of "create new job" button (Issue #19)
So far I cannot quite reproduce this; specifically the word "new" does not appear for me. When I inspect the document accessibility tree, the name of the "+" button is "Create job". And I guess the screen reader adds "tab" to that. So we could call it "add new job", which the screenreader will turn into "add new job tab"? I don't want to call it "add new" just to get it to say "add new tab", because that's a bad description by itself (add new what? there will be some other features coming that could also have components called "add new ", so I want to be specific from the start)
—
Reply to this email directly, view it on GitHub https://github.com/daisy/pipeline-ui/issues/19#issuecomment-1341556842 , or unsubscribe https://github.com/notifications/unsubscribe-auth/ABYXNO5VZCN3A4X2YNZNHZTWMDX6FANCNFSM6AAAAAASXGYU3M .
You are receiving this because you were mentioned.  https://github.com/notifications/beacon/ABYXNO3APEZO2DK2HWQ4763WMDX6FA5CNFSM6AAAAAASXGYU3OWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTSP62EGU.gif Message ID: @.*** @.***> >

I would skip the "add". It's not better than "create" IMO (on the contrary). Just "New job" sounds perfect. And it's still fine if the screen reader adds "tab" to it. I can't check right now what the corresponding menu items are called, but I'd expect them to be called the same as the + button.

Ok so is "new job" (proposed wording) better than "create job" (existing wording)? I don't really see the difference.
The menu item is called "create a job" but that may undergo some changes too (see #7).

New job is closer to the terminology used in most apps including  some DAISY apps such as new project, new file, new folder etc.
From: Marisa DeMeglio @.>
Sent: Friday, December 9, 2022 1:27 AM
To: daisy/pipeline-ui @.>
Cc: Prashant Ranjan Verma @.>; Mention @.>
Subject: Re: [daisy/pipeline-ui] Change title of "create new job" button (Issue #19)
Ok so is "new job" (proposed wording) better than "create job" (existing wording)? I don't really see the difference.
The menu item is called "create a job" but that may undergo some changes too (see #7 https://github.com/daisy/pipeline-ui/issues/7 ).
—
Reply to this email directly, view it on GitHub https://github.com/daisy/pipeline-ui/issues/19#issuecomment-1343278556 , or unsubscribe https://github.com/notifications/unsubscribe-auth/ABYXNOZNBXP6Q6PVB2RM63LWMI4PRANCNFSM6AAAAAASXGYU3M .
You are receiving this because you were mentioned.  https://github.com/notifications/beacon/ABYXNO6PWRRRBBT2KS2V7XDWMI4PRA5CNFSM6AAAAAASXGYU3OWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTSQCDG5Y.gif Message ID: @.*** @.***> >

Indeed I was thinking the same. There isn't much difference between the two, but "new" is more common.

I am going to hold off on this until we sort out tab naming, because if we rename the "add job" button to "new job", then it has the same name as the default tab name, so you could have a tab list where everything is called "new job".
See #26 and #18

I face a different issue here. JAWS does not say that it is a button.
JAWS correctly says its name "Create job ctrl+N tab"
But JAWS does not recognize it as a button. Please check if it has role button assigned to it.

@avneeshsingh it's a tab:
<button role="tab" type="button">

I am still looking for a good accessible example of HTML tabs that contain controls. I sent an email about this last week which I did not receive replies to so I will create an issue and maybe get some discussion going. The problem is that something with role="tab" cannot contain interactive elements like buttons.

I have removed the "new job" button in favor of a menu item (and keyboard shortcut) in commit https://github.com/daisy/pipeline-ui/commit/0e57c9932fd75d64c24f914c2107f072498152f4


Apiversion of hdfs should be v1

i have an issue while installing hdfs , apiVersion v2 should be v1, how can i solve this problem ?

We do not support apiVersion v1.
We recommend you to use v2 and migrate to helm 3 since helm2 is legacy.


recalculate initialOffset on resize

Having media queries resize can cause change of current pageYOffset, so it need to be recalculated.
fixes

Problem example
https://www.webpackbin.com/bins/-KfSPua_dweMwmybwuIw
Gif

Here Header has media query on height,
initially hover me with Perimeter respond on hovers,
but after resize not.

@istarkov thanks for the reproduction! Did you verify that this change fixes the issue?

Yes you can check here https://www.webpackbin.com/bins/-KfT3Y1CMX0VKVMsC5mH


Does not work in Firefox's PDF.js

Too bad.

Is there a ticket here?

not at all, I just mentioned that in case someone would try to dive into
the source code thinking it's this program's fault that it doesn't work.
Feel free to close and add a note to README if you think that would
be helpful.
On Tue, 15 Sep 2020, 20:27 Paul Ritchie<EMAIL_ADDRESS>wrote:

Is there a ticket here?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/cornerpirate/JS2PDFInjector/issues/5#issuecomment-692893817,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AKFM2EW4NRHV7E2LBZKLDKDSF6WXRANCNFSM4RNQ3P5A
.

Thanks for the additional information.
I direct you to the readme which already states this works in Adobe and pretty much nowhere else:
When you open the produced PDF with the JavaScript injected in Adobe you should see your code execute. Mileage varys in other viewers and for certain Edge in Windows 10 does not execute.
I believe that other PDF readers are more sensible and don't have JavaScript :D


No tags in push register call [C#]

The provided documentation shows the ability to send notifications to a specific user with the "_UserId" tag, but doesn't show how to register for general tags.
Previously I would just use:
await client.GetPush().RegisterNativeAsync(uri, new string[] { "myTag" });
To register, but I can't find a similar method in the current SDK. Please put this overload, or similar, back in.

The plan is to allow the tag be part of the template that you pass in as the second parameter, following the same pattern as using the NH client SDK directly.  There are still some server hooks needed to allow verification of tags/etc as well on our server side yet.
As a workaround for now, you would need to either use the NH SDK directly or set up a custom API to send the tags and register them.

I have the same problem. Any update on this in the november update? How would the template be formed? Keep up the great work!

Adding:
https://github.com/Azure/azure-mobile-apps-net-server/issues/36
https://github.com/Azure/azure-mobile-apps-node/issues/241
To track this on the server level.
Client side, we'd initially probably just pass them up via the template top level property, "tags".  For details on the template see: https://msdn.microsoft.com/en-us/library/azure/mt621153.aspx
Long term we need to add a nicer API for working with templates to all the clients as well.

iOS: https://github.com/Azure/azure-mobile-apps-ios-client/issues/9
.Net: https://github.com/Azure/azure-mobile-apps-net-client/issues/12
JS: https://github.com/Azure/azure-mobile-apps-js-client/issues/22
Android:

closing base services issue, as now tracked in the new apps repos.

Maybe this issue should be left open for discussion, rather than fragment the conversation. There is clearly some design work that needs to be done here, and the result should be consistent across platforms.

It's mainly getting to parity with v1, but we can open a new issue on -apps if we think more design is needed as well.
Ignore the client issues, they are only tangentially related to this, those are placeholders for really a different discussion than tags support.


UI - Test RBAC role

I think we need to test RBAC role in the UI.
https://github.com/rancher/elemental/issues/332

@agracey - what are the expectations for RBAC in Elemental UI ? Who should be able to do what ?

Admin should have full access by default and any other user would need the role we created to do anything (including list).
Since it's relatively trivial to add roles ad hoc, I had figured we could get a few production use cases in to see how people use it. Then we could build in the common roles after we learn more.

I tried to create a Standard User with only "Elemental Administrator" and  I got 403 when I clicked on the OS management menu. After talking with dev, it will be fixed by https://github.com/rancher/elemental-ui/pull/26

https://github.com/rancher/elemental/pull/485 adds simple tests and I will provide more in a separate PR once the issue fixed by the UI team.
The idea is to run the k3s test as admin user and the RKE2 with a standard user granted with elemental-administrator role.


[SPARK-5537][MLib] Expand user guide for multinomial logistic regression

Test build #28033 has started for   PR 4801 at commit 096d0ca.

This patch merges cleanly.

Test build #28033 has finished for   PR 4801 at commit 096d0ca.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/28033/
Test PASSed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/28203/
Test FAILed.


Catch Egg Game

🎮 Game Request
To showcase your skills, collect the falling eggs from the chicken. Be quick and catch the eggs that are dropped by the chicken.
Point down the features
Scoring: Earn points for each egg caught.
Lives: Start with 5 lives. Lose a life for each egg missed. Game over when lives reach 0.
Select program in which you are contributing
GSSoC24
Code of Conduct

[X] I follow CONTRIBUTING GUIDELINE of this project.

Hey @narayani9120 , You can't have another issue before completing the previous one 😀
you already have the following 1 open issues 👀 ! :
#4405

Hey @narayani9120 ! Thank you so much for your raising the issue💗
It’s all yours, you can come anytime again and make some contributions! 🚀
Alone, we can do little, but together we can do so much! 😇

Hey @narayani9120 !
Thank you for raising an issue 💗
You can self assign the issue by commenting /assign in comment 😀
Make sure you follow CODE OF CONDUCT and CONTRIBUTING GUIDELINES 🚀
Don’t Forget to ⭐ our GameZone🎮
Make sure you join our Discord🕹

Hey @narayani9120! 🙂
It seems like you are not following proper guidelines !! 👀
Read documentation properly !!🙏
If you have any queries reach out to us on Discord🕹 .


Modify assertUrlRegExp to only accept matching regexp pattern

As discussed on https://github.com/Behat/Mink/pull/170
Let me know if the regex is fine now. Will use the same for https://github.com/Behat/Mink/pull/171 then

Nope. Regex should be:
/^the (?i)url(?-i) should match (?P<pattern>\/([^\/]|\\\/)*\/)$/

Something like that.

Closing, and raising another one to take into account the feedback.

@proofek just for your information, you don't need to close the PR and open a new one each time you get some feedback. Simply push to the same branch and the PR is updated.

Ooh. Didn't know that. Thanks for the info!


ReceiveMessageRequest.attributeNames is wrongly typed

Describe the bug
ReceiveMessageRequest.attributeNames has the type List<QueueAttributeName>?. Because of this, the actual values that are possible for this (that are even described in the functions documentation) aren't available. As a concrete example, there is no way to get the "SentTimestamp" Message Attribute directly, a possible workaround would be to use QueueAttributeName.All but will results in downloading attributes I'm not interested in.
Expected behavior
There should be a type like AttributeName (MessageAttributeName would be bad because messageAttributes and attributes are two different things on a SQS Message) which is used for the ReceiveMessageRequest.attributeName list generic type, so that the actual allowed values can be passed to the request.
Current behavior
You can only pass queue attribute names instead of attribute names available on SQS messages. The code documentation refers to values that you can't assign there.
Steps to Reproduce
SqsClient { region = myRegion }.receiveMessage {
    queueUrl = sqsUrl
    waitTimeSeconds = 20
    maxNumberOfMessages = 10
    attributeNames = listOf(QueueAttributeName.All) // here I actually just want to use "TimestampSent"
}

Possible Solution
No response
Context
No response
AWS Kotlin SDK version used
0.20.3-beta
Platform (JVM/JS/Native)
JVM
Operating System and version
Ubuntu 20.04 on WSL 2

the actual values that are possible for this (that are even described in the functions documentation) aren't available.

AWS SDKs are all generated from a model. In this case the ReceiveMessage.attributeNames targets the shape AttributeNameList which is a list of QueueAttributName. This is why the name is QueueAttributeName.

As to what you are trying to do I have to admit I had to play around with this to get it to work. The documentation for the ReceiveMessage request parameters indeed lists a handful of attributes including SentTimestamp. Immediately below that it lists the valid values which does not include most of the preceding names listed (the valid values do match the modeled enum values linked above though).
The values listed in the docs you are interested in seem to correspond with MessageSystemAttributeName enum (API ref docs).
I've created a ticket internally to either update the model or documentation. In the meantime you can provide values that are not modeled by using QueueAttributeName.fromValue. Here is an example of getting just the SentTimestamp

import aws.sdk.kotlin.services.sqs.SqsClient
import aws.sdk.kotlin.services.sqs.model.MessageSystemAttributeName
import aws.sdk.kotlin.services.sqs.model.QueueAttributeName
import aws.sdk.kotlin.services.sqs.receiveMessage
import kotlinx.coroutines.*

const val QUEUE_URL = "<my-queue-url>"

fun main(): Unit = runBlocking {
    SqsClient.fromEnvironment().use { sqs ->
        val resp = sqs.receiveMessage {
            queueUrl = QUEUE_URL
            attributeNames = listOf(
                QueueAttributeName.fromValue(MessageSystemAttributeName.SentTimestamp.value)
            )
            waitTimeSeconds = 2
        }

        println("attributes:")
        println(resp.messages!![0].attributes)
    }
}

Output:
attributes:
{SentTimestamp=1677073570750}

internal: V841124522

I switched over to the Java SDK as this here is still beta and I need it for production. There I also noticed this problem exists in the Java v2 SDK as well. The MessageSystemAttributeName is something I found there as well because in the Java SDK, the keys of .attributes are typed like this - that's not the case in the Kotlin SDK, here it's just string keys.
Anyways, thanks a lot for the quick response! The workaround with QueueAttributeName.fromValue sadly doesn't work on the java side, here it is restricted to the known values.

Oh and one remark regarding this:

I've created a ticket internally to either update the model or documentation

The documentation is right, so the model needs to be changed. QueueAttributeName contains keys related to the SQS itself, not the message. When receiving messages these are not relevant, instead one should provide values described by MessageSystemAttributeName.

This was fixed on 5/8/24.


Added Card Rows and fixed fonts

@Milcke Should I merge this one also?

@hellofaizan yep merge please man - we are getting too out of date

@Milcke Not able to merge. Help me resolve the merge conflict


Country flag emoji oddly displayed

There was a new feature introduced in https://github.com/ipinfo/cli/pull/124 (related issue: https://github.com/ipinfo/cli/issues/123) to show country flag emoji. This doesn't work as intended in my terminal app and shows country code oddly:

I tested with different terminal apps and this either shows oddly or doesn't show up at all based on chosen font. Some fonts do stretch this "emoji" so letters don't overlap, some don't. I really would appreciate this to be togglable. Thank you.

The other way around might be to allow or filter out some fields, which --field option seems to be designed for, though it doesn't work with pretty format and switches output to CSV 😢
The "filter out" option looks better as it would allow newly introduced fields to be shown up by default, which improves UX.

Pushed https://github.com/ipinfo/cli/commit/02e2503b7d0c38b0f1fa031edfceaedd41383aff - we'll release this soon.

@UmanShahzad Thanks a bunch!

Is there any timeline on the nearest release? This weirdness with flag is a bit annoying 😢

We've got a lot more changes coming along with that in the pipeline, so will be doing a significant release very soon. Stay tuned!

@UmanShahzad Any at least approx timeline? It make s ipinfo semi unusable to me =(

@yermulnik just released 3.0.0 which has this fix 👍

Yay! Appreciate that! 🕺🏻

Looking forward for the Brew tap to get this update soon 🤞🏻


Update lock-threads.yml

Make needs-triage and prioritized labels exempt from the stale labeler
Type of change

[ ] 🐛 Bug fix
[ ] 🌟 New feature
[ ] 🔨 Breaking change
[x] 📖 Refactoring / dependency upgrade / documentation
[ ] other:

Description
For issues that we have not yet triaged, or actively prioritized, we do not need the stale labeler to keep running. This change makes that so ✨

This PR has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.


Bug: takes two passes to remove period and trailing space in a header

[X] I have verified that I am on the latest version of the Linter

Describe the Bug
The linter needs to be run twice / manually make two passes in order to remove both a trailing period and space in a heading.
How to Reproduce
Steps to reproduce the behavior:

Turn on "Remove trailing punctuation in heading" and "Removes extra spaces after each line"
Create a note and create this heading ## Heading with trailing period and space.
Lint the file, notice the trailing space was removed but not the period
Lint again without making any changes, and notice the period was removed

Expected Behavior
Both the trailing period and space should be removed in one pass.
## Heading with trailing period and space

Device

[X] Desktop
[ ] Mobile

Thanks for reporting this @PatrickF1 . I am not sure this a bug, but I can see about ignoring whitespace when removing trailing punctuation. My guess is that there is whitespace after the punctuation causing it to assume that the punctuation is not truly trailing.
I will have to take a closer look to see if my understanding of the problem is correct.

I have a change that should take care of this. I will push it up shortly.

This should be on master and go out with the next release. Please let us know if there are any issues around it.

Wow that was super fast. Thank you Peter!

No problem. I was working on some other things, but since this was a pretty easy change, I decided to give it a shot.


Fixed error in Appendix - Data Analyses with Python & Jupyter

@Lakezh , can you please review and merge?


RadzenDataGrid column resize sticking on after click

On tables with a large column count (>20), if a user clicks or double clicks the resize control in the column header, that column can get "stuck" in a resizing state.
This is because the mouseup handler for the element has not been registered in JS (startColumnResize) before the user has released the mouse button.
There needs to be an onmouseup handler registered on the resize control that is also hooked up to stop resizing to catch this scenario.

Thanks @cvanstone however I'm unable to reproduce such problem on our demo: https://blazor.radzen.com/datagrid-dynamic

Can you?

Hi @enchev, yes, I just ran up the same demo with AllowColumnResize=true as the only modification, and after clicking the resize column splitter several times on a few of the columns it does eventually happen.
You can make it much easier to replicate in your demo by adding more rows into the table - PageSize=1000 and data = Enumerable.Range(0, 1000).Select(i =>
Then double click the resize splitter in 2 or more columns and you should see the behaviour (see attached video)
My application has some large data grids (up to 50 columns and typically around 250 rows), hence we see this constantly throughout.
https://github.com/radzenhq/radzen-blazor/assets/39767844/48b1ccb5-cafa-4312-b850-80007c32d805


Ability to migrate multiple namespaces in a database

I am testing with this repo and first impression is very good.
I have it working as a remote package in my monorepo. That repo has different apps which are deployed in Docker containers. When deploying a version of the app the migration should run. That is done in the Dockerfile just before starting the app.
The surrealdb database I use is configured with a root namespace where all customers have access, and per customer a namespace in the same database is created to create a multi-tenant setup. The root has other tables than the customer namespace.
This means 2 issues:

Multiple namespaces
Different migration querys per namespace

This means i have 2 kinds of migration .surql files. One for the root and one for all customer namespaces.
A solution could be to update the naming convention of like so:
0001.{namespace}.{do|undo}.{description}.surql and set the name of the namespace accordingly and check for that in the  index.js.
{namespace} could have a value like the namespace name (root) or a wildcard (.
We would need to check the namespaces available in the database and apply the migration to the specific namespace that has its own migrations and introspections tables.
Another approach would be to update the config.yaml where we can configure different namespaces and possibly assign some surql migration files to apply to those namespaces.
Please let me know how you feel about this change.
Regards Ronald

I think it's an excellent capability to have. I am wondering which path would lead to fewer mitigations or restrictions down the road. Would it be better if we could have namespaced folders under ./migrations? Or maybe namespaced versions, like {namespace}.0001.{do|undo}.{description}.surql? Both could be supported? I think my only concern is keeping the migrations table clean and versions linear, but namespaced versions would mean each namespace could have linear versions and not be as connected to other namespaces in migration history.
Unfortunately I'm still new to SurrealDB, so there is still much for me to learn about how it can/is used and how to build the best migration tool possible.
I'm definitely willing to implement this or accept any PRs for it.

If namespaces are used for multi-tenancy then they will usually have the same model/entities and thus the same version. Your concern is therefore justified. There are multiple architectures with not only multiple namespaces  but also might use multiple databases per project, use schema-definition tools etc.
There is another project that is written in rust and has some attention surrealdb-migrations. It uses a different approach where not only migrations are stored in surql files but the schema definitions and event definitions as well.
I have posted a general question on Discord in the tools section to check how the Surrealdb community looks at migrations in general. Maybe you can also have a look at the previous mentioned project and also check into Discord to see if we can get some attention for your project as well.

Thank you, that is helpful. So I'm thinking the starting point is determining the best approach for configuring Surrealigrate to know what to do for each database and how to simplify the administrative needs to maintain that. I only have my phone to browse with at the moment but I'll look into that rust project and see what their approach is this evening.


TowerOfHanoi

Tower of Hanoi CPP code

Not accepting CPP/C DSA codes
Alternative ->
1)Create a page using HTML & CSS Add DSA problem statement and solution in that
2)You can contribute in python and java OR
Ask for an issue assign
3)Contribute to Web Project


Colorize cut geometry

Allow section cuts to change the color for better visibility.
In the clipping fragment shader, if a fragment is within a certain distance of clip plane, instead of discarding it, change its color - color and distance being configurable.
This will result in colorizing geometry that is near the clip plane, emphasizing where the cut is happening.
For example, here is a manually edited screenshot of a public iModel where a clip plane is applied to the scene, but the circled area has geometry that is "cut" showing up as red because it is very near the clip plane.
Note: this is just for illustration purposes!  It would look better done for real, not done manually.

Example
To exaggerate the effect in the above example, edit edgeWidth and edgeColor as follows:
  clippingPlanes = new Cesium.ClippingPlaneCollection({
    planes: [
      new Cesium.ClippingPlane(
        new Cesium.Cartesian3(0.0, 0.0, -1.0),
        0.0
      ),
    ],
    edgeWidth: viewModel.edgeStylingEnabled ? 5.0 : 0.0,
    edgeColor: Cesium.Color.RED,
  });

The glsl ought to be dead simple: compute min distance of fragment to any plane (in pixels, not meters - may need to convert).
Probably add to ClipStyleProps something like:
  intersectStyle?: {
    color?: ColorDefProps; // default white
    width?: number; // in pixels, default 1
}

Transparency fixes are pushed to the branch.
Pending resolution of remaining comments.

https://github.com/iTwin/itwinjs-core/pull/6008

https://github.com/iTwin/itwinjs-core/issues/5910


Update requirements.txt

@benfred Only to be merged when CI container updated with cudf 21.10

Closing since #1356 already addresses it


Conversion cleanup

This change cleans up some of the type conversions - many were using a switch where
the v, ok style would work just as well.  Also use the type switch assignment
to avoid converting twice in the switches.  Finally, use %T in the error message
rather than using reflect directly.

I removed all the instances of p := p etc.


feat: Include site level metrics in the CWV response

Please ensure your pull request adheres to the following guidelines:

[ ] make sure to link the related issues in this description. Or if there's no issue created, make sure you
describe here the problem you're solving.
[ ] when merging / squashing, make sure the fixed issue references are visible in the commits, for easy compilation of release notes

If the PR is changing the API specification:

[ ] make sure you add a "Not implemented yet" note the endpoint description, if the implementation is not ready
yet. Ideally, return a 501 status code with a message explaining the feature is not implemented yet.
[ ] make sure you add at least one example of the request and response.

If the PR is changing the API implementation or an entity exposed through the API:

[ ] make sure you update the API specification and the examples to reflect the changes.

If the PR is introducing a new audit type:

[ ] make sure you update the API specification with the type, schema of the audit result and an example

Related Issues
https://jira.corp.adobe.com/browse/SITES-26928
Related PR's:
https://github.com/adobe/spacecat-audit-worker/pull/508
https://github.com/adobe/spacecat-api-service/pull/615
https://github.com/adobe/spacecat-shared/pull/470
Thanks for contributing!

:tada: This PR is included in version 1.81.0 :tada:
The release is available on:

v1.81.0
GitHub release

Your semantic-release bot :package::rocket:


Set up smtp server using JNDI

I'm using GitBlit 1.7.1 WAR in my Jetty 9 container and have a jndi resource for my mail server bound to mail/Session in my jetty.xml so all the deployed applications have the ability to send emails without me needing to specify it in each application's setup.
It would be a nice feature for the WAR version use this resource instead of needing to update the gitblit.properties file.

I would write the same item. In other words I completely agree with @walshta.


allow batching of component pool baking

create component pool mixin method making it easy to create a bunch of cells in the background without blowing the cpu..
e.g.
mc.pool.createCells(burstSize, callbackFunction, types: [{cellType: quantity}])

not going to do this, as the code to achieve this is pretty simple, and clients can just do it themselves, in a way most suitable for them.


Add file type detection for Inko

This adds file type detection for Inko.
While there's also a Vim plugin that does this (https://github.com/inko-lang/inko.vim), it includes more logic (e.g. indent and syntax rules). Some of that (most notably the syntax) might change such that upstreaming and maintaining it in Vim itself is a bit painful, hence this PR only includes the file type detection logic.

thanks!


Add Browserify support

CommonJS support is present in the library, and the dist/jquery.gridster.js file contains lines like require('./jquery.draggable.js'). However, the jquery.draggable.js file is not present in the dist folder, since it is concatenated into the main jquery.gridster.js file. The result is that Browserify cannot include this library.
Two possible solutions:

include src directory as an exception in .npmignore, so it is fetched via npm install
fix the CommonJS support to only require jquery in the dist folder and do not use relative paths

I would prefer options 2.  Would you please submit a pull request with the changes.

I would also prefer option 2 and tried to make it happen, but unfortunately did not find a way to remove those require('...') statements with grunt. Do you have any idea?

This was fixed on PR #116 by coping the required files into the dist folder. Not the most elegant solution but it will work until we have a new build system in place.


[PVM, GENESIS] Add ValidatorRewardsStartTime, refactor camino config in genesis

Why this should be merged
We have validator rewards that are collected on C-chain and then exported to P-chain. They are imported every X seconds (defined in vm params) on P-chain from genesis start time. And if the start time is in the past (which is the case), this results in a lot of these import blocks for every X seconds after the start time. This PR fixes this by adding validatorRewardsStartTime value in genesis - reward import will only happen if chaintime is not less, than this value.
This PR also puts camino config values in genesis into a single struct and makes genesis generation use that struct.
How this works
GetNextChainEventTime func will now get camino genesis config and then checks if validatorsRewardTime is before validatorRewardsStartTime. If it is - then it ignores it and returns stakerChangeTime.
How this was tested
Unit tests for genesis generation

The issue is resolved by https://github.com/chain4travel/caminogo/pull/167 with another approach


Completion grant

Codecov Report

Merging #886 (231023c) into main (22882c5) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #886      +/-   ##
==========================================
+ Coverage   83.89%   83.91%   +0.01%
==========================================
  Files         125      125
  Lines        1757     1759       +2
  Branches      211      214       +3
==========================================
+ Hits         1474     1476       +2
  Misses        283      283

Impacted Files
Coverage Δ

...s/core/shared/src/main/scala/data/Completion.scala
100.00% <ø> (ø)

...d/src/main/scala/net/message/CommandComplete.scala
92.18% <100.00%> (+0.25%)
:arrow_up:

This looks like a good candidate to re-target for series/0.6.x branch.


x86: Jump to absolute address

Is it possible to jump to an absolute address in x86 without using a register?


[Health Data DeIdentification - Azure Health AI Deidentification service ] API Review

New API Review meeting has been requested.
Service Name: Health Data DeIdentification - Azure Health AI Deidentification service
Review Created By: Graham Thomas
Review Date: 01/25/2024 08:00 AM PT
Onboarding Record: https://dev.azure.com/azure-sdk/Release/_workitems/edit/17897
PR:
Hero Scenarios Link: here
Core Concepts Doc Link: here
Description: Implemented all feedback from first meeting.
Detailed meeting information and documents provided can be accessed here
For more information that will help prepare you for this review, the requirements, and office hours, visit the documentation here

Meeting updated by Graham Thomas
Service Name: Health Data DeIdentification - Azure Health AI Deidentification service
Review Created By: Graham Thomas
Review Date: 01/25/2024 08:00 AM PT
Onboarding Record: https://dev.azure.com/azure-sdk/Release/_workitems/edit/17897
PR:
Hero Scenarios Link: here
Core Concepts Doc Link: here
Description: Implemented all feedback from first meeting.
https://github.com/Azure/azure-rest-api-specs/pull/27452
PR Link is here. Cannot add it because missing 'data-plane' label.
Previous PR is here:
https://github.com/Azure/azure-rest-api-specs-pr/pull/16602
Couldn't add it because it said 'not-found'.
Detailed meeting information and documents provided can be accessed here
For more information that will help prepare you for this review, the requirements, and office hours, visit the documentation here

Meeting updated by Graham Thomas
Service Name: Health Data DeIdentification - Azure Health AI Deidentification service
Review Created By: Graham Thomas
Review Date: 01/25/2024 08:00 AM PT
Onboarding Record: https://dev.azure.com/azure-sdk/Release/_workitems/edit/17897
PR: https://github.com/Azure/azure-rest-api-specs/pull/27452
Hero Scenarios Link: here
Core Concepts Doc Link: here
Description: Implemented all feedback from first meeting.
https://github.com/Azure/azure-rest-api-specs/pull/27452
PR Link is here. Cannot add it because missing 'data-plane' label.
Previous PR is here:
https://github.com/Azure/azure-rest-api-specs-pr/pull/16602
Couldn't add it because it said 'not-found'.
Detailed meeting information and documents provided can be accessed here
For more information that will help prepare you for this review, the requirements, and office hours, visit the documentation here

Meeting updated by Graham Thomas
Service Name: Health Data DeIdentification - Azure Health AI Deidentification service
Review Created By: Graham Thomas
Review Date: 01/25/2024 08:00 AM PT
Onboarding Record: https://dev.azure.com/azure-sdk/Release/_workitems/edit/17897
PR: https://github.com/Azure/azure-rest-api-specs/pull/27452
Hero Scenarios Link: here
Core Concepts Doc Link: here
Description: Implemented all feedback from first meeting.
https://github.com/Azure/azure-rest-api-specs/pull/27452
PR Link is here. Cannot add it because missing 'data-plane' label.
Previous PR is here:
https://github.com/Azure/azure-rest-api-specs-pr/pull/16602
Couldn't add it because it said 'not-found'.
Detailed meeting information and documents provided can be accessed here
For more information that will help prepare you for this review, the requirements, and office hours, visit the documentation here


Support scons custom_modules

custom_modules is used a lot in my build system, I had to inline two python files to restore this and it made my code style worse.
Currently the SCons is told the location of the builtin_api.gen.json is custom_modules/builtin_api.gen.json I don't remember the exact error.

Never head of custom_nodule any documentation about this?

https://docs.godotengine.org/en/stable/development/compiling/introduction_to_the_buildsystem.html#custom-modules

I use git subrepo to merge so not necessary.


using typings 1.0

There are changes in typings version 1.0 https://github.com/typings/typings/releases/tag/v1.0.0.
When will gulp-typings be using version 1.0?

@mattqs
I'll have a look when I find some time.
Meanwhile PRs are welcome.

v2.x.x on npm now relies on v1.x.x of typings-core.


Update golang Docker tag to v1.23

This PR contains the following updates:

Package
Type
Update
Change

golang
final
minor
1.22-bullseye -> 1.23-bullseye

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>5
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 54.614%

Totals

Change from base Build<PHONE_NUMBER>1:
0.0%

Covered Lines:
432

Relevant Lines:
791

💛  - Coveralls


Update icon should be different from install one

[x] Update icon should be different from install one

Suggestions:
https://user-images.githubusercontent.com/73800734/195964106-4c82da13-c87a-43eb-8857-feaedb1bc6e6.png
https://user-images.githubusercontent.com/73800734/195964147-e77c7ad4-5787-42a3-80c5-c17ca3496d7d.png

[ ] Also, version icon should be different from install one IMO

suggestions:
https://icons8.com.br/icons/set/version
https://user-images.githubusercontent.com/73800734/209727418-fdb16e9c-a754-4367-baa7-6a2fa8cef486.png (from first WingetUI version)

Also, version icon should be different from install one

Regarding the second item, they both represent the latest instalable version, so it would make sense to leave them the same

What about new versions?

Regarding the second item, they both represent the latest instalable version, so it would make sense to leave them the same

I guess it is mostly a matter of personal preference, but I find a little bit confusing that these two icons are the same:

Do you have any proposal for a new version icon?
It is true that it does not show quite the idea of versioning...

No, I was actually thinking about changing the install icon instead of the version one

Example https://img.icons8.com/dotty/512/software-installer.png

I reckon it kind of breaks the round-line windows 11 style, doesn't it?

I didn't find a similar round icon unfortunately

Do you have any proposal for a new version icon? It is true that it does not show quite the idea of versioning...

How about simply something like
https://icons8.com/icon/66762/circled-v
https://icons8.com/icon/66763/circled-v

i have noticed in the resources folder this icon that could be used for the version/instal,,

besides, there seems to be a few icons that are not used anywhere and can be removed.

Honestly, I reckon it wouldbe weird, since at the end of the day this is the outline of WingetUI's logo, what do you think?
Also, On which section would you put it?

Discovery section. I am not sure which icons to use, but I think it is not ideal to use the same icon for two different things


unpurged_txns is calculated but not posted

unpurged_txns is calculated at https://github.com/mackerelio/mackerel-plugin-mysql/blob/ccc92ec3a2d56952ffbc8166625868b935d69396/lib/mysql.go#L900-L908, but it is not posted anywhere.
It seems to have remained unposted since its implementation at https://github.com/mackerelio/mackerel-agent-plugins/pull/72.

fixed by https://github.com/mackerelio/mackerel-plugin-mysql/pull/15


Wrong exception message in pio_assembler.cpp

https://github.com/raspberrypi/pico-sdk/blob/95ea6acad131124694cda1c162c52cd30e0aece0/tools/pioasm/pio_assembler.cpp#L66
Should be 65536, not 65546.

Haha whoops. Feel free to create a PR against the develop branch.


Source rect hint

fixes https://github.com/wrbl606/floating/issues/4
breaking change because aspectRatio is now a named parameter

@deckerst Thanks for your work! Formatter found something to fix though. You can format your code to expected structure with:
flutter format lib test example/lib example/integration_test


subdomains?

Hi,
how can I manage subdomains (subdomain.awesomewebsite.com)? VueJs can't handle these and the webpack dev server docs refer to the publicPath. But the publicPath of this template looks way different.

Node: 6.9.5
npm: 3.10.10
OS: Debian 7.11

how can I manage subdomains (subdomain.awesomewebsite.com)?

Can you explain what you mean by "manage" in this conext?

Oh, yeah. Just to write in my config the name and path of subdomains. No dashboard control.


Issue3805 Cache references for next compilation

Guys.
You load same references 2 times:
1st with roslyn
2nd with nrefactory
Please choose one of this libries in future. Make some tests or something please.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Данил Попов seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

Now, when you build many projects in 1 time compilation superfast

Awesome, thank you for signing the CLA!
We will be pointing the base/target branch to our side's dev, that's where we pull everything together before making the release. It will probably show conflicts soon, as we merge other pull requests together, but your changes looks straightforward enough not to impose any "heavy" conflicts. We'll let you know if we get in trouble trying to merge it.
We usually ask for unit tests for issues fixed, but in this case I'm not sure we can come up with any. The very fact the unit test projects compiles should prove that the fix is not breaking anything.

Hi @colderlord,
We ran a variety of performance tests with and without this PR, and we're not seeing any performance improvements.

Are you seeing better performance improvements in your project(s)?

Hello!
I used as example your test project and maked my own TranslatorRunner and Translator.
As you can see i dont change any logic, thats why build time is the same. My optimization work when you build many projects, because i wrote cache for references in this PR.
Here is my example:
class Program
{
	private static string projectDir = @"C:\Users\d.popov\Documents\Visual Studio 2015\Projects\ClassLibrary1\ClassLibrary1\";
	private static string sourcePath = $"{projectDir}MyClass.cs";
	private const string LogFileNameWithoutExtention = "testProjectsBuild";

	static void Main(string[] args)
	{

		var logger = new Logger(null, true, new ConsoleLoggerWriter());
		logger.LoggerLevel = LoggerLevel.None;

		var translator = new TranslatorRunner
		{
			Logger = logger,
			Assembly = File.ReadAllBytes(@"C:\Users\d.popov\Documents\Visual Studio 2015\Projects\ClassLibrary1\ClassLibrary1\bin\Debug\ClassLibrary1.dll"),
			Sources = sourcePath,
		};

		var bridgeDll = AssemblyDefinition.ReadAssembly(@"C:\Users\d.popov\Documents\Visual Studio 2015\Projects\ClassLibrary1\ClassLibrary1\bin\Debug\Bridge.dll");
		translator.AddNestedTypes(bridgeDll.MainModule.Types);

		Stopwatch stopWatch = new Stopwatch();
		stopWatch.Start();
		translator.Translate(false); // 3 sec
		stopWatch.Stop();
		Console.WriteLine(string.Format("BuildAll Time {0}", stopWatch.Elapsed));

		Stopwatch stopWatch1 = new Stopwatch();
		stopWatch1.Start();
		translator.Translate(false); // 0,09 sec
		stopWatch1.Stop();
		Console.WriteLine(string.Format("BuildAll2 Time {0}", stopWatch1.Elapsed));

		Console.ReadKey();
	}
}

As you can see i use builded assembly to translate csharp to js. First translate will always slow (about 3 secs), next will be faster (0,09-0,1 secs) because of caching.
I measured on what takes the whole 3 seconds at compilation. And finded 2 places that i optimezed now. You took all references and compiled library, load them from disk and disassemble them every time. Because of caching this operation should be faster

#3805 (just referencing the issue from the pull request)


os: permit Rename to read-only file on Windows

On Windows 10, in Go 1.13, it used to be possible to rename over a read only file (like it is in Unix). In Go 1.14 it is not. I'm not seeing anything specific about this in the release notes, was this an intentional change?
func TestRenameRO(t *testing.T) {
	os.Remove("a")
	os.Remove("b")
	defer os.Remove("a")
	defer os.Remove("b")

	if err := ioutil.WriteFile("a", []byte("some data"), 0644); err != nil { // rw
		t.Fatal(err)
	}
	if err := ioutil.WriteFile("b", []byte("some data"), 0444); err != nil { // ro
		t.Fatal(err)
	}
	if err := os.Rename("a", "b"); err != nil {
		t.Error(err)
	}
}

PS C:\Users\JakobBorg\dev\test> go1.13.9 test
PASS
ok      _/C_/Users/JakobBorg/dev/test   0.048s
PS C:\Users\JakobBorg\dev\test> go1.14.1 test
--- FAIL: TestRenameRO (0.01s)
    rename_test.go:22: rename a b: Access is denied.
FAIL
exit status 1
FAIL    _/C_/Users/JakobBorg/dev/test   0.046s
PS C:\Users\JakobBorg\dev\test>

This probably seems to be side effect in https://github.com/golang/go/commit/16f0f9c8e1e767d10d483939981e3b2242554c33 but I think this is not regression.

syscall: respect permission bits on file opening on Windows
On Windows, os.Chmod and syscall.Chmod toggle the FILE_ATTRIBUTES_
READONLY flag depending on the permission bits. That's a bit odd but I
guess some compromises were made at some point and this is what was
chosen to map to a Unix concept that Windows doesn't really have in the
same way. That's fine. However, the logic used in Chmod was forgotten
from os.Open and syscall.Open, which then manifested itself in various
places, most recently, go modules' read-only behavior.
This makes syscall.Open consistent with syscall.Chmod and adds a test
for the permission behavior using ioutil. By testing the behavior
instead of explicitly testing for the attribute bits we care about, we
make sure this doesn't regress in unforeseen ways in the future, as well
as ensuring the test works on platforms other than Windows.
In the process, we fix some tests that never worked and relied on broken
behavior, as well as tests that were disabled on Windows due to the
broken behavior and had TODO notes.
Fixes #35033

Before go1.13 (before 16f0f9c), ioutil.WriteFile does not respect permission bits on Windows. So the file should always be 0666 eventhough if 0444 is specified. This is related on https://github.com/golang/go/issues/26295

I confirmed below fix this.
diff --git a/src/os/file_windows.go b/src/os/file_windows.go
index 96f934d039..581d382f75 100644
--- a/src/os/file_windows.go
+++ b/src/os/file_windows.go
@@ -313,10 +313,29 @@ func Remove(name string) error {

 func rename(oldname, newname string) error {
 	e := windows.Rename(fixLongPath(oldname), fixLongPath(newname))
-	if e != nil {
-		return &LinkError{"rename", oldname, newname, e}
+	if e == nil {
+		return nil
 	}
-	return nil
+
+	p, e1 := syscall.UTF16PtrFromString(fixLongPath(newname))
+	if e1 != nil {
+		return e1
+	}
+
+	a, e1 := syscall.GetFileAttributes(p)
+	if e1 != nil {
+		e = e1
+	} else {
+		if a&syscall.FILE_ATTRIBUTE_READONLY != 0 {
+			if e1 = syscall.SetFileAttributes(p, a&^syscall.FILE_ATTRIBUTE_READONLY); e1 == nil {
+				if e = windows.Rename(fixLongPath(oldname), fixLongPath(newname)); e == nil {
+					return nil
+				}
+			}
+		}
+	}
+
+	return &LinkError{"rename", oldname, newname, e}
 }

 // Pipe returns a connected pair of Files; reads from r return bytes written to w.

Yeah, the bug is in WriteFile, not Rename. Ugh.

Ah, I'm sorry of my short explaining. I'm thinking 16f0f9c was not regression but os.Rename can be improved like os.Remove.

On Unix, rename to a read-only file is permitted.  The directory must be writable.
So the question is whether os.Rename on Windows should make the effort to make this work the same way, by changing the file to not be read-only.  I guess we often try to do that on Windows, so it makes sense to me, but I don't feel strongly about it.
Any other opinions?
CC @alexbrainman @mattn

I agree with iant.

Any other opinions?

This bug does not affect me. But the fix will affect me - os.Rename will have to do more to implement this logic. We always adjust windows code to match whatever Unix syscalls implements.
Adding @zx2c4 since he is the author of 16f0f9c
Thank you.
Alex


moved test files for library into directory on the website.

Here's the test files—they include all of the files in that directory that appear to be data, not just the csv.csv file.

Cool.  Let me know when that's live, and I'll re-write my tests in the main repo to reference that.


Merge release notes for 0.17.2

Sorry , I have added one more release note https://github.com/submariner-io/submariner-website/pull/1146.


ipv6 filter flag follow-ups

[ ] consider warning if filter flag is defined as true, but config has ipv6 referenced ip-blocks, and thus that flag is ignored
[ ] add tests/examples with referenced ipv6 blocks that affect the output of connectivity map and semantic diff
[ ] specifically, revisit the fixes from https://github.com/IBM/network-config-analyzer/pull/577/files , and add a relevant example to demonstrate the effect of the included fix there.

Moved to NP-Guard repo. See here


[BEAM-4401] Use ElementEncoders for beam.Create

This ensures that any valid pipeline element can be passed to beam.Create.  The JSON encodings only work for a subset of valid PCollection types.

R: @herohde

Done.  I manually wrote a type that implements the proto.Message interface and cannot be JSON marshaled due to the faux oneof field.

LGTM
R: @jasonkuster Please merge! Thank you.

LGTM


identity: early draft of DefaultAzureCredential refactor

Super early draft of what I was thinking regarding refactoring opportunities here. The idea is that for each credential we can:

Identify all the preconditions it must hold (probably by looking at all the checks in each credential where we throw)
Check those preconditions in the create*Credential function.
if valid, create the credential and return it
otherwise, return a "NoOp" credential (called UnavailableDefaultCredential) that throws a CredentialUnavailableError with a message why it was skipped

The one question I have as I go through this is: how and when do we actually benefit from this? IMO we only benefit when we can really tighten up each credential's constructor to enforce prerequisites. If we can never do that this might not offer any real benefits?
Packages impacted by this PR
Issues associated with this PR
Describe the problem that is addressed by this PR
What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?
Are there test cases added in this PR? (If not, why?)
Provide a list of related PRs (if any)
Command used to generate this PR:**(Applicable only to SDK release request PRs)
Checklists

[ ] Added impacted package name to the issue description
[ ] Does this PR needs any fixes in the SDK Generator?** (If so, create an Issue in the Autorest/typescript repository and link it here)
[ ] Added a changelog (if necessary)

API change check
API changes are not detected in this pull request.

This refactor could help tremendously with https://github.com/azure/azure-sdk-for-js/issues/25024 and related issues:

We will no longer be throwing from a constructor... hopefully? The function won't even try to create the credential unless it has what it needs
CredentialUnavailble errors will be thrown in getToken, not in the constructor

Late to this party, but wanted to say I really appreciate the switch from extra subclasses of credential into factory functions for creating the "Default" flavor of other credential types.


feat: associate dart errors with replays

part of #2032 so #skip-changelog
Result after this PR

an error shows a replay - https://sentry-sdks.sentry.io/issues/4722238716/?project=5428562&query=is%3Aunresolved+issue.priority%3A[high%2C+medium]&referrer=issue-stream&statsPeriod=24h&stream_index=0
a replay shows an error - https://sentry-sdks.sentry.io/replays/46dbc60356204548bf96cb662d14b978/?project=5428561&project=5428562&query=&referrer=%2Freplays%2F&statsPeriod=24h&yAxis=count()

TODO

[ ] update tests of affected classes, if there are any

@buenaflor you've already reviewed the main replay PR so I've created this change as a separate one, so that it's easier to review. Please let me know if the changes are OK in general (because I'm not so sure around these areas of the code) and I'll update tests afterwards.

I'll update tests afterwards.

I've added the tests now


perf(message-parser): Use Set instead of Object.

Closing in favor of https://github.com/deepstreamIO/deepstream.io/pull/639

Thanks for the cleanup!


Added new CDN

PageCDN tightly compresses files with brotli (level 11) compression. For vue.js it saves additional 11KB in compressed file size. So, can be a valuable addition to the docs.
Further, if you are open to work with us, we can setup the vue repo on PageCDN to fetch updates through webhooks as new releases are available on github. This way, you can easily display PageCDN links in the docs as you currently do with unpkg and give vue users benefit of smaller compressed files and other features like immutable caching, etc.

Unfortunately at the moment we’d like to only suggest the most proven and popular CDN’s among developers instead. Thanks for the PR, though!


Feature request: split gulp build into multiple processes

I doubt gulp supports this, but it would be great if the gulp watch build task could be split into multiple processes. For example, I imagine the extensions could be built the same time that the rest of the source is built.
Maybe if there was a way, two gulp processes could be spawned, then waited upon before tasks dependent upon those two are run.
This is because on my system, the initial steps before incrementally building the modified typescript files seems to take very long.

gulp --tasks shows you that we have at least the following tasks: watch-extensions, watch-client.

Oh thanks! I didn't know about those.
And since there are already two separate tasks it would be nice if gulp watch ran them both in two separate processes rather than doing watch-client after watch-extensions.
However the compilation still takes some time. Would it be possible to further split up the watch tasks, maybe by the editor, platform, or workbench folders if they aren't dependent on each other? Or if they are, maybe split them between the electron main process & render process?


Enabled logit.io for production namespace

Context
https://trello.com/c/bjfo0jo9/1812-onboard-services-to-logitio
Changes proposed in this pull request
Added  enable_logit:true to  deployments for production , separatione,sandbox and migration.
After deployment , logs can be looked in to logit.io.

 Onboard services to Logit.io


The "require minimum confirmations" feature is not implemented

When idempotence is important, a client request should only be attempted to be fulfilled when the node is sure that the request exists, which requires a configurable parameter for how many blocks it should wait for. I think it's perfectly fine to not have this for now.
Tracked by https://api3dao.atlassian.net/browse/AN-160

See minConfirmations here
https://github.com/api3dao/api3-docs/blob/master/airnode/2-7-config-json.md#potential-update-to-nodesettings

Added as a part of config.json but not being used yet.

Is this v0.1.0 worthy?

If we're considering v0.1.0 an MVP, then no, but I don't think this is particularly difficult to implement though (?)

I guess we shouldn't mark things v0.1.0 on the basis that they are easy to implement so I won't

Closing this as an issue, as we removed the references to it in the docs and it became like any of the other features that are not implemented yet


[Heap] Express heap operations on UnsafeMutableBufferPointer

Heap currently uses regular array subscripting to access the contents of its storage. Array access is pretty fast, but it includes index validation that is (hopefully) unnecessary in Heap's case. I expect the optimizer is able to get rid of these index validations in some (but not all) cases; but it probably makes sense to not have them in the first place.
Rework the low-level heap implementation to operate on UnsafeMutableBuffer storage instead, turning index checks into debug-mode assertions rather than unconditional preconditions.
To do this, it would make sense to introduce a Heap._UnsafeHandle or _UnsafeHeap struct that consists of an UnsafeMutableBufferPointer value, and move most heap operation to that. We'll need to have closure-based read and update helpers that expose a read-only (or read-write) view of the Array storage. (Similar to how Deque and OrderedSet's hash tables work.)

The withUnsafeMutableBufferPointer implementations in Array and friends included ancient protection against concurrent mutations that actually made this slower than the original code for insert (but not for removals). This was fixed in the stdlib in apple/swift#38867 & apple/swift#38898. The insert code assumes these changes are in place, or else it will work a bit slower than expected. (These fixes ship in the stdlib SDK, so they're backdeployable. All we need to pick them up is to recompile the code with a future Swift release that contains them.)


add "type" of user account: brokered or not brokered

Will not be done until level of support for brokering is clearer.


Type issues in Pyright

Describe the bug
After upgrading to the latest version, we are seeing the following linter (pyright) errors:
error: "FakeRedis" is not exported from module "fakeredis"
Import from "fakeredis._server" instead (reportPrivateImportUsage)

Can you please provide the failing code snippet?

@cunla https://github.com/cunla/fakeredis-py/pull/116 should fix it.

I am not able to replicate this error.


Heroku button

Hi,
great work.
it would be nice to have a 1-click deployment on Heroku for example (or something similar).
https://devcenter.heroku.com/articles/heroku-button
Thanks.

Per Heroku documentation, Shiori would have to use a vendoring solution for dependencies:
https://devcenter.heroku.com/articles/go-support

Alternatively, Heroku supports Docker, so that could be a solution.


context with inboundReference

Hi,
Firstly, just wanted to say that I'm really enjoying this theme – so thanks for all the work you've put into it!
One of the things I like in https://github.com/mathieudutour/gatsby-digital-garden is that the inboundReferences include the context (e.g. here), whereas your implementation simply shows that there exists an inbound reference. My current "digital garden" uses https://github.com/andymatuschak/note-link-janitor, which also provides the context.
I've been looking at the code, though I'm not particularly familiar with js/gatsby/remark. Would it be easy to enable this feature? I'm happy to work on it as an excuse to learn some js.

Having spent some more time with the other foam/gatsby offerings, there are little things from each that I like. For instance, one nice thing about https://github.com/hikerpig/gatsby-project-kb/ is the ability to inline the ToC, and the ability to enable comments (https://gatsby-project-kb.vercel.app/examples/comment-system).
I'm also a fan of using sidenotes/marginnotes (from https://edwardtufte.github.io/tufte-css/), and have been trying to get something going. I'm slowly coming to the conclusion that I should probably just create my own fork/theme!

@dfeng , Thanks for your kind comments!
Maybe you can also custom the whole theme files, See this for more details,
An example of this theme, you can see this blog, it replaces many files with its own theme file, https://github.com/padosum/blog/tree/master/.layouts/src/gatsby-theme-primer-wiki , may be you can do similar things.
Anyhow, of course you can fork your own theme to match your needs.
Have fun!

I didn't get your exact meanings, for inboundReferences, this theme also has a detailed body preview, what's your point?

And this theme also has the ability of the ToC,  what do you mean the inline toc?

the ability to enable comments (https://gatsby-project-kb.vercel.app/examples/comment-system).

This is also enabled by this theme, because they are both gatsby themes, of course you can use the shadowing feature.
https://www.gatsbyjs.com/docs/how-to/plugins-and-themes/shadowing/
For example, https://github.com/padosum/blog uses this theme, and it has the comment feature.

I'm also a fan of using sidenotes/marginnotes (from https://edwardtufte.github.io/tufte-css/), and have been trying to get something going.

It's nice, but I don't know how to include it in my theme, it seems a little conflict with the sidebar toc?

the ability to enable comments (https://gatsby-project-kb.vercel.app/examples/comment-system).

This is also enabled by this theme, because they are both gatsby themes, of course you can use the shadowing feature.
https://www.gatsbyjs.com/docs/how-to/plugins-and-themes/shadowing/
For example, https://github.com/padosum/blog uses this theme, and it has the comment feature.

I'm also a fan of using sidenotes/marginnotes (from https://edwardtufte.github.io/tufte-css/), and have been trying to get something going.

It's nice, but I don't know how to include it in my theme, it seems a little conflict with the sidebar toc?

I didn't get your exact meanings, for inboundReferences, this theme also has a detailed body preview, what's your point?

Sorry. Should have been more explicit. I meant the fact that you get the context in the backlinks section: for instance, the - [[override-styles]] shows some approaches to change the appearance of the site. below.

Whereas in your version, you just show the link (following how Obsidian Publish does it).

The context you mentioned is a little content preview of that note?  But now it already has a hover preview of that note. I’m sorry still not get the point…

An example of this theme, you can see this blog, it replaces many files with its own theme file, https://github.com/padosum/blog/tree/master/.layouts/src/gatsby-theme-primer-wiki , may be you can do similar things.

Sweet! This is exactly what I'm looking for.

The context you mentioned is a little content preview of that note? But now it already has a hover preview of that note. I’m sorry still not get the point…

The difference is that when you start creating long notes like I do, then having the local context that you can just see (instead of hovering over each backreference, and locating the reference within the preview) is extremely helpful.
As an example from my current blog, which uses a different engine:

In your current setup, I would have to hover over each page to see the context. This way I immediately see where (and why) [[project-penalty]] has been linked.

Now I get it! Yes, it’s a great feature, let me inspect it, see what can I do. Thank you for the detailed explanation!

No, thank you!
Both https://github.com/mathieudutour/gatsby-digital-garden and https://github.com/hikerpig/gatsby-project-kb/ have the context. I had a quick look at their code, as it seemed like it shouldn't be too difficult (just save the node content), but I'm still not familiar enough with typescript.

Hi, @dfeng , I found the digital garden's inboundReferences implement is using roamsearch functions,
See:
https://github.com/mathieudutour/gatsby-digital-garden/blob/666422bfb72ba0e1df1dbccf86d9f4fc1a80e67f/packages/gatsby-theme-garden/src/utils/data-to-note.js#L34-L62
So it's not provided by local file.
If we want to do similar things, we must analyze the relative blocks maybe here:
https://github.com/theowenyoung/gatsby-theme-primer-wiki/blob/95c337ce514f609171193e427031a3077e25d8d0/references/lib/get-references.js#L40-L46
get more context nearby the link, and blabla.
If you are interested in this, I look forward to this feature! :)

I noticed https://github.com/andymatuschak/note-link-janitor/blob/master/lib/getBacklinksBlock.ts
do some similar things.
maybe we can reuse this code.
but for now, I have not willing to do this thing.


Fix build for SGX_DEBUG=1

Use cargo --release also in case of SGX_DEBUG=1 and hence also the corresponding target/release folder.
This still might not be the best debugging experience - but that would be a lot tougher to achieve (if not impossible), considering the nature of the enclave (which cannot be debugged by design).
Closes #375

It might not be optimal, but until now, we never made use of the debugger anyhow.
However, for your information, the enclave can be debugged if SGX_DEBUG=1, we just never made a setup accordingly because it is even harder to set up with remote development, which CLion does currently not support (at least in rust.)

It might not be optimal, but until now, we never made use of the debugger anyhow.
However, for your information, the enclave can be debugged if SGX_DEBUG=1, we just never made a setup accordingly because it is even harder to set up with remote development, which CLion does currently not support (at least in rust.)

Ah good to know! 🚀 It would certainly be nice in the future to have debug capabilities


-L, --listenOn Seems to fallback to <IP_ADDRESS>

Even if you define another IP Address (for example <IP_ADDRESS>) with the -L option, the dnscrypt-proxy instance that randomdns starts will still listen on <IP_ADDRESS>
Reproduce:
Start RandomDNS with Option
-L <IP_ADDRESS>:53
Effect:
The process randomdns will show the correct commandline option:
node randomdns -L <IP_ADDRESS>:53
but the actual dnscrypt will run on <IP_ADDRESS> anyway:
/tmp/dnscrypt-proxy-136461 --local-address <IP_ADDRESS>:53

Fixed in c8f5d59, thanks you!

Just released 1.3.1 so you just have to update it :smile:

Thanks mate!
Cheers


[SPARK-31771][SQL] Disable Narrow TextStyle for datetime pattern 'G/M/L/E/u/Q/q'

What changes were proposed in this pull request?
Five continuous pattern characters with 'G/M/L/E/u/Q/q' means Narrow-Text Style while we turn to use java.time.DateTimeFormatterBuilder since 3.0.0, which output the leading single letter of the value, e.g. December would be D. In Spark 2.4 they mean Full-Text Style.
In this PR, we explicitly disable Narrow-Text Style for these pattern characters.
Why are the changes needed?
Without this change, there will be a silent data change.
Does this PR introduce any user-facing change?

Yes, queries with datetime operations using datetime patterns, e.g. G/M/L/E/u will fail if the pattern length is 5 and other patterns, e,g. 'k', 'm' also can accept a certain number of letters.

datetime patterns that are not supported by the new parser but the legacy will get SparkUpgradeException, e.g. "GGGGG", "MMMMM", "LLLLL", "EEEEE", "uuuuu", "aa", "aaa". 2 options are given to end-users, one is to use legacy mode, and the other is to follow the new online doc for correct datetime patterns

2, datetime patterns that are not supported by both the new parser and the legacy, e.g.  "QQQQQ", "qqqqq",  will get IllegalArgumentException which is captured by Spark internally and results NULL to end-users.
How was this patch tested?

add unit tests

cc @cloud-fan thanks

Test build #122884 has started for PR 28592 at commit 78fb74a.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/27527/
Test PASSed.

Test build #122898 has started for PR 28592 at commit e178a6b.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/27541/
Test PASSed.

Test build #122884 has finished for PR 28592 at commit 78fb74a.

This patch fails PySpark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/122884/
Test FAILed.

Test build #122898 has finished for PR 28592 at commit e178a6b.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/122898/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/27568/
Test PASSed.

Test build #122926 has started for PR 28592 at commit 1d31ed2.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/27569/
Test PASSed.

Test build #122926 has finished for PR 28592 at commit 1d31ed2.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/122926/
Test FAILed.

Test build #122928 has started for PR 28592 at commit 1144c03.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/27571/
Test PASSed.

Test build #122928 has finished for PR 28592 at commit 1144c03.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/122928/
Test FAILed.

Test build #122935 has started for PR 28592 at commit 549a122.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/27577/
Test PASSed.

Test build #122937 has started for PR 28592 at commit c877ac5.

Build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/27579/
Test PASSed.

Test build #122938 has started for PR 28592 at commit b2abeeb.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/27580/
Test PASSed.

Test build #122935 has finished for PR 28592 at commit 549a122.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/122935/
Test FAILed.

Test build #122937 has finished for PR 28592 at commit c877ac5.

This patch fails Spark unit tests.
This patch does not merge cleanly.
This patch adds no public classes.

Build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/122937/
Test FAILed.

Test build #122938 has finished for PR 28592 at commit b2abeeb.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/122938/
Test FAILed.

Test build #122958 has started for PR 28592 at commit 1503042.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/27599/
Test PASSed.

Test build #122963 has started for PR 28592 at commit 052bfad.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/27605/
Test PASSed.

Test build #122964 has started for PR 28592 at commit 8141ef9.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/27606/
Test PASSed.

Test build #122958 has finished for PR 28592 at commit 1503042.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Test build #122963 has finished for PR 28592 at commit 052bfad.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Test build #122964 has finished for PR 28592 at commit 8141ef9.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/122964/
Test FAILed.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/122963/
Test FAILed.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/122958/
Test FAILed.

Test build #122986 has started for PR 28592 at commit 09b407f.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/27629/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/27633/
Test PASSed.

Test build #122990 has started for PR 28592 at commit 75fdbcb.

Test build #122986 has finished for PR 28592 at commit 09b407f.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
case class SparkListenerResourceProfileAdded(resourceProfile: ResourceProfile)

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/122986/
Test FAILed.

Test build #122993 has started for PR 28592 at commit 0a76ba3.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/27636/
Test PASSed.

Test build #122994 has started for PR 28592 at commit 5360d88.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/27637/
Test PASSed.

Test build #122993 has finished for PR 28592 at commit 0a76ba3.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/122993/
Test FAILed.

Test build #122999 has started for PR 28592 at commit ee1d62a.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/27642/
Test PASSed.

Test build #122994 has finished for PR 28592 at commit 5360d88.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/122994/
Test FAILed.

Test build #122990 has finished for PR 28592 at commit 75fdbcb.

This patch fails from timeout after a configured wait of 400m.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/122990/
Test FAILed.

Test build #123010 has started for PR 28592 at commit 3047f88.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/27654/
Test PASSed.

Test build #122999 has finished for PR 28592 at commit ee1d62a.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/122999/
Test PASSed.

Test build #123010 has finished for PR 28592 at commit 3047f88.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
case class SecondsToTimestamp(child: Expression)
case class MillisToTimestamp(child: Expression)
case class MicrosToTimestamp(child: Expression)

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/123010/
Test PASSed.

thanks, merging to master/3.0!

Hi @yaooqinn can you send a new PR for 3.0?

OK，thanks for merging


font awesome icons overwritten

the icon classes will be prefixed with: sidr-class
normal: class="fa fa-cube"
with sidre: class="sidr-class-fa sidr-class-fa-cube"
So the icons won't render.

To avoid this behavior, you can set the value of the option 'renaming' as false (http://www.berriart.com/sidr/#documentation).

Or just add some javascript to rename them back onOpen...This way you can still rename everything else:
$( 'a.wpex-toggle-mobile-menu' ).sidr( {
    name     : 'wpex-sidr-menu',
    speed    : parseInt( wpexLocalize.sidrSpeed ),
    source   : wpexLocalize.sidrSource,
    side     : wpexLocalize.sidrSide,
    displace : wpexLocalize.sidrDisplace,
    renaming : true,
    onOpen: function( name ) {

        // Hide if wrap clicked
        $( '#wrap' ).click( function() {
            $.sidr( 'close', 'wpex-sidr-menu' );
        });

        // Re-add correct font Icons
        $( "#wpex-sidr-menu [class*='sidr-class-fa']" ).attr( 'class',
            function( i, c ) {
            c = c.replace( 'sidr-class-fa', 'fa');
            c = c.replace( 'sidr-class-fa-', 'fa-');
            return c;
        } );

    },
    onClose: function( name ) {

        // Nothing yet

    }

} );

Not sure how efficient the code and if there is a better way, but it works.

I recommend you to use the renaming option.

If you use the renaming option though it prevents renaming for everything, using javascript as mentioned above still allows you to rename all other classes and ID's.

@wpexplorer yes, you are right. Your proposal is totally fine.
There is a pull request proposal to filter whick classes/ids are going to be renamed and I will valorate if it should go with the core.

Great!
I love seeing this repository active again! I have made some tweaks on my own as well but never submitted pull requests because I thought the repo was "dead" maybe I'll start submitting some ;)


exchange2007CompatibilityMode flag is now taken into account to create t...

...he request SOAP version header. Previously a Exchange2007_SP1 version was always sent as Exchange2007 (with potential problem like no access to PublicFoldersRoot). Now behaviour can be decided than to the flag.

Hi @itoche, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla.azure.com.

TTYL, AZPRBOT;

@itoche, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.
Thanks, AZPRBOT;

@itoche thanks for your contribution