[prop-types] It crash eslint when using spread operator in a flow type

Hello! This code crashs eslint:
type RawMazeData = {|
  ...MazeData,
  path: Array<[string, ActivePathBorders]>,
|};

Cannot read property 'type' of undefined
TypeError: Cannot read property 'type' of undefined
    at buildTypeAnnotationDeclarationTypes (C:\dev\repos\codimo\node_modules\eslint-plugin-react\lib\rules\prop-types.js:452:25)
    at C:\dev\repos\codimo\node_modules\eslint-plugin-react\lib\rules\prop-types.js:464:54
    at iterateProperties (C:\dev\repos\codimo\node_modules\eslint-plugin-react\lib\rules\prop-types.js:333:11)
    at buildTypeAnnotationDeclarationTypes (C:\dev\repos\codimo\node_modules\eslint-plugin-react\lib\rules\prop-types.js:463:11)
    at buildTypeAnnotationDeclarationTypes (C:\dev\repos\codimo\node_modules\eslint-plugin-react\lib\rules\prop-types.js:455:20)
    at C:\dev\repos\codimo\node_modules\eslint-plugin-react\lib\rules\prop-types.js:464:54
    at iterateProperties (C:\dev\repos\codimo\node_modules\eslint-plugin-react\lib\rules\prop-types.js:333:11)
    at buildTypeAnnotationDeclarationTypes (C:\dev\repos\codimo\node_modules\eslint-plugin-react\lib\rules\prop-types.js:463:11)
    at C:\dev\repos\codimo\node_modules\eslint-plugin-react\lib\rules\prop-types.js:681:38
    at iterateProperties (C:\dev\repos\codimo\node_modules\eslint-plugin-react\lib\rules\prop-types.js:333:11)

Edit: disabling this rules does not happen.
Thank you!

I can also say that babel itself could not run that code until the 6.24.1 (or a bit earlier) version

Wow, so fast! Fantastic!

Sadly I still get that issue:
TypeError: Cannot read property 'type' of undefined
    at buildTypeAnnotationDeclarationTypes (/Users/zeus/Documents/redux_demo/webapp/node_modules/eslint-plugin-react/lib/rules/no-unused-prop-types.js:426:25)
    at /Users/zeus/Documents/redux_demo/webapp/node_modules/eslint-plugin-react/lib/rules/no-unused-prop-types.js:681:25
    at iterateProperties (/Users/zeus/Documents/redux_demo/webapp/node_modules/eslint-plugin-react/lib/rules/no-unused-prop-types.js:287:11)
    at markPropTypesAsDeclared (/Users/zeus/Documents/redux_demo/webapp/node_modules/eslint-plugin-react/lib/rules/no-unused-prop-types.js:680:11)
    at markAnnotatedFunctionArgumentsAsDeclared (/Users/zeus/Documents/redux_demo/webapp/node_modules/eslint-plugin-react/lib/rules/no-unused-prop-types.js:814:7)
    at Object.handleStatelessComponent (/Users/zeus/Documents/redux_demo/webapp/node_modules/eslint-plugin-react/lib/rules/no-unused-prop-types.js:823:7)
    at EventEmitter.updatedRuleInstructions.(anonymous function) (/Users/zeus/Documents/redux_demo/webapp/node_modules/eslint-plugin-react/lib/util/Components.js:624:75)
    at emitOne (events.js:101:20)
    at EventEmitter.emit (events.js:189:7)
    at NodeEventGenerator.applySelector (/Users/zeus/Documents/redux_demo/webapp/node_modules/eslint/lib/util/node-event-generator.js:265:26)

Different rule, same issue. I will fix this one too.

This should be reopened, still a problem with the same stack on version 7.0.1.  I'll see if I can add a test PR that demonstrates it, I suspect it is due to the use of $Exact<> or shorthand {||}.

I've pulled master, I see {...data}, {|...data|} are working, I added {...$Exact<data>} and it too works, so my hunch was wrong.  I'll keep looking.

I've reproduced, it is the same thing I've found with flow plugins: I am spreading a type imported from a libdef (like flow-typed) and it is unresolved, therefore there are no children from the imported shape:

I've discovered that this problem is not isolated to libdefs, code that is present inside my project is failing to be validated using the object type spread, it appears to be because iterateProperties() makes no attempt to flatten the type, and  it calls fn(undefined, undefined) as the key/value.
I think this method will need to check if it is indeed an object type spread and flatten it in-line.

Unfortunately, it doesn't seem to matter what I put in the tests, they all pass, leading me to believe there is a problem in the tests.  e.g.:
{
      code: [
        'import type {Data} from \'./Data\'',
        'type Person = {',
        '  ...Data,',
        '  lastname: string',
        '};',
        'class Hello extends React.Component {',
        '  props: Person;',
        '  render () {',
        '    return
Hello {this.props.bar}
;',
        '  }',
        '}'
      ].join('\n'),
      parser: 'babel-eslint'
    }, {
      code: [
        'import type {Data} from \'some-libdef-like-flow-typed-provides\'',
        'type Person = {',
        '  ...Data,',
        '  lastname: string',
        '};',
        'class Hello extends React.Component {',
        '  props: Person;',
        '  render () {',
        '    return
Hello {this.props.bar}
;',
        '  }',
        '}'
      ].join('\n'),
      parser: 'babel-eslint'
    }

Both report as passing, and I cannot see how that could be true.
If @yannickcr will reopen this and advise me on the bad tests succeeding, I'm willing to take a shot at this.

I finally debugged my case close enough to add a test that breaks the current master.  It's a nested spread that breaks this code and proves this should be reopened.
{
      code: [
        'import type {BasePerson} from \'./types\'',
        'type Props = {',
        '  person: {',
        '   ...$Exact<BasePerson>',
        '   lastname: string',
        '  }',
        '};',
        'class Hello extends React.Component {',
        '  props: Props;',
        '  render () {',
        '    return
Hello {this.props.person.firstname}
;',
        '  }',
        '}'
      ].join('\n'),
      parser: 'babel-eslint'
    }

@rosskevin would you open a new issue for that, that links back to this one? The OP is fixed; your issue is slightly different :-)


Integrate Vite and Vitest. Add test for TextTextureRendererUtils.

This PR is a shot at upgrading our build system to use Vite (which uses rollup under the covers for production builds). I've attempted to replicate everything we have currently with rollup. The regular rollup build system remains untouched under the build npm command.
One of the benefits, and biggest motivator (for me), of switching to the Vite ecosystem is that we can take advantage of Vitest for unit testing. I've added that as well here along with a working test for the utility method created in rdkcentral/Lightning#442.
To build, simply run:
npm run build-vite

which will build all of the bundles necessary in parallel using another NPM package called concurrently.
To run tests, run:
npm test

Vitest also integrates with Visual Studio Code via a plugin with the same name. And it's really nifty.
Still to be done/worked out:

[x] Add lightning-inspect ES5 build
[x] Get the copyright header plugin (rollup-plugin-license) to work

Now using a custom Vite plugin which was very simple to write

[x] Verify that the bundles generated work as well as the pure rollup ones did.
[x] Move this PR to the rdkcentral/Lightning (once rdkcentral/Lightning#442 is merged)
[x] Remove vanilla rollup system (and have vite output to dist)
[x] Configure TypeScript definitions to be moved to dist folder

Just rebased and moved this PR over from my fork

Copyright scan failure
Commit: 389f1bcbb43b1dc939d7fe5af0fcfc90981cc409
Report detail: https://gist.github.com/rdkcmf-jenkins/f82812a980df2a4772bc57262592fd6b

This is pretty much ready for review! I've tested the build outputs of this in sample projects that utilize the lng CLI, Webpack and Vite. Both TypeScript and plain JavaScript. All projects build just fine. Could use another set of eyes and a sanity test before release.

Awesome! Does this change the output generated with the Lightning-CLI or is this just local to the Lightning repo build? Reason I'm asking is to see if we should check whether or not our build bundles break anything downstream with the Metrological CLI and their ability to upload it to the dashboard (and if it does, adjust accordingly).

It shouldn't. This should be building compatible bundles that are expected by Lightning-CLI. I've tested it in both a JavaScript and TypeScript project created with lng create. Both lng build and lng dev work as expected. I'm not sure what beyond that I'd need to look out for with regards to the Metro app store/etc.

Awesome! Does this change the output generated with the Lightning-CLI or is this just local to the Lightning repo build? Reason I'm asking is to see if we should check whether or not our build bundles break anything downstream with the Metrological CLI and their ability to upload it to the dashboard (and if it does, adjust accordingly).

It shouldn't. This should be building compatible bundles that are expected by Lightning-CLI. I've tested it in both a JavaScript and TypeScript project created with lng create. Both lng build and lng dev work as expected. I'm not sure what beyond that I'd need to look out for with regards to the Metro app store/etc.

OK. I guess we should submit an app and see it if works on Metro and give @robbertvancaem a headsup :)


Feature/fix tests

Add Linux build

I've never used Appveyor Linux support. How will this be reflected in status checks?

It just appears as a second project in appveyor with a second webhook, so should just show as a second required status check on the PR page. You can then have a second badge that shows the result of the other build (Eg see https://github.com/jeremyskinner/fluentvalidation and https://ci.appveyor.com/project/JeremySkinner/fluentvalidation-tq12c)
If you don't think it's a good idea, we can leave it for now.

Just added Linux webhook, too.

Thanks, the linux build is now passing. I had to make a couple of changes:

Removed the install line Install-PackageProvider -Name NuGet as this fails and isn't necessary (I'm not sure if we need it on the windows version either?)
Worked around coveralls install issue

Coveralls is registered on PS Gallery with the name "coveralls", but the module file is "Coveralls.psd1". The inconsistent casing means that Import-Module will fail as it can't find the module. I've hard-coded the path to the module for now, and I've opened an issue on the coveralls repo: https://github.com/JanDeDobbeleer/coveralls/issues/4


mitm.it not being replaced

I can't get the intercepted mitm.it page to appear when running mitmproxy -p 8088 and configuring an iPhone to use the machine running mitmproxy.
I've disabled cell data on the iPhone, and I can see the responses are being passed through mitmproxy and can be accepted or rejected.
So it's clear I have the proxy configured correctly, but mitmproxy is just not showing the magic page for some reason.

Works fine for me. Can you see requests to "mitm.it" in the proxy? Which version of mitmproxy are you running?

I could see requests to mitm.it in the proxy. to my knowledge it was running 0.13 (only just installed it today using sudo pip install mitmproxy) but I've just nuked the VM I had it in to try again due to messing up my configuration settings for my network. Will reply with more detailed version information once I  update the old VM snapshot I had.

Can't replicate, assume it had something to do with either an un-updated VM or botching the install or various combinations of the two.

I encounter similar problem after installing 0.9.2 with apt-get install mitmproxy.
But after install 0.13 with pip install mitmproxy command.
I can now see mitm.it
Maybe there is bug in 0.9.2 version which is in ubuntu package repo ..

0.9.2. is really outdated. You should not use that in any case.


PointAnnotation doesn't show the Text

Steps to reproduce
The PointAnnotation works under 2.0 but I it doesn't work under 2.1
For example,
public void Annotation(MarkerType shape, OxyColor color, double size, string text, DataPoint position)
{
    var annotation = new PointAnnotation
    {
        Shape = shape,
        Text = text,
        TextColor = color,
        TextHorizontalAlignment = HorizontalAlignment.Center,
        TextVerticalAlignment = VerticalAlignment.Middle,
        TextMargin = 0,
        TextPosition = position,
        FontWeight = FontWeights.Bold,
        Fill = OxyColors.Transparent,
        Stroke = SetTransparency(200, color),
        StrokeThickness = 2,
        Size = size,
        X = position.X,
        Y = position.Y
    };

    Model.Annotations.Add(annotation);
}

To Test it , call
Annotation(MarkerType.Circle, OxyColors.RoyalBlue, 8, "D", new DataPoint(60, 60));

Platform:
.Net 6.0 and WinUI
Expected behaviour
I expected to see a Circle Marker with Letter D inside. However, I only see a Circle with No Text.
If I export it as below , the pdf is correct
public static void ExportToPDF(this PlotModel model, Stream stream, float w = 1050, float h = 350)
{
    OxyPlot.SkiaSharp.PdfExporter pdfExporter = new OxyPlot.SkiaSharp.PdfExporter { Width = w, Height = h };
    stream.SetLength(0);
    pdfExporter.Export(model, stream);
    stream.Flush();
    stream.Close();
}

see the rendered PDF through Skia which suggests the core library is be behaving as expected
TSCO.L.PDF
The output from WinUI

Hello. Thanks for creating this issue.
The first thing I want to note is that this fork is an attempt to generalize the current WPF version of OxyPlot and the abandoned OxyPlot UWP - https://github.com/oxyplot/oxyplot-uwp. I'm sure there are many more issues like this here because the UWP version of OxyPlot hasn't been developed since 2019.
Second, I can fix it, but to save me a little time, you need to prepare a project with a small example of this problem so that I can quickly test a solution to it.

I have tried to attached a zip file but it is not allowed.
Let Me know how to send it to you.
Thanks

Perhaps you forgot to delete the bin and obj directories and the zip file is too big? Github allows you to attach zip files.

App1.zip
thanks

Issue fixed, NuGet package should be available in about 10 minutes


Dask not reporting pyarrow dataframe difference it detects

I posted this on SO, but not getting useful responses, so came to the source. I think it comes down to Dask changing to actually reporting the differences it finds in dataframes rather than dumping the entire enormous column lists. I find the more detailed metadata in the exception dump really contains no extra useful information.
I refer to this question - https://stackoverflow.com/questions/51439245/dask-dataframe-read-parquet-schema-difference/51550321#51550321
But the metadata returned by Dask does not indicate any differences between the different dataframes. Here is my code, which parses the exception details to find mismatched dtypes. It finds none. There are up to 100 dataframes with 717 columns (each is ~100MB in size).
    try:
        df = dd.read_parquet(data_filenames, columns=list(cols_to_retrieve), engine='pyarrow')
    except Exception as ex:
        # Process the ex message to find the diff, this will break if dask change their error message
        msgs = str(ex).split('\nvs\n')
        cols1 = msgs[0].split('metadata')[0]
        cols1 = cols1.split('was different. \n')[1]
        cols2 = msgs[1].split('metadata')[0]
        df1_err = pd.DataFrame([sub.split(":") for sub in cols1.splitlines()])
        df1_err = df1_err.dropna()
        df2_err = pd.DataFrame([sub.split(":") for sub in cols2.splitlines()])
        df2_err = df2_err.dropna()
        df_err = pd.concat([df1_err, df2_err]).drop_duplicates(keep=False)
        raise Exception('Mismatch dataframes - ' + str(df_err))

The exception I get back is:
'Mismatch dataframes - Empty DataFrame Columns: [0, 1] Index: []'

This error does not occur with fastparquet, but it is so slow that it is unusable.
I added this to the creation of the dataframes (using pandas to_parquet to save them) in an attempt to unify the  dtypes by column
    df_float = df.select_dtypes(include=['float16', 'float64'])
    df = df.drop(df_float.columns, axis=1)

    for col in df_float.columns:
        df_float[col] = df_float.loc[:,col].astype('float32')

    df = pd.concat([df, df_float], axis=1)

    df_int = df.select_dtypes(include=['int8', 'int16', 'int32'])

    try:
        for col in df_int.columns:
            df_int[col] = df_int.loc[:, col].astype('int64')
        df = df.drop(df_int.columns, axis=1)
        df = pd.concat([df, df_int], axis=1)
    except ValueError as ve:
        print('Error with upcasting - ' + str(ve))

This appears to work according to my above exception. But I cannot find out how the dataframes differ as the exception thrown by dask read_parquet does not tell me? Ideas on how to determine what it finds as different?
Update:
I saw that the schema dumped does have more detail of dtype, e.g. float32 rather than  float returned in the top part of the exception for each schema. So I added parsing of the more colex schema information:
import json
from operator import itemgetter

    try:
        df = dd.read_parquet(data_filenames, columns=list(cols_to_retrieve), engine='pyarrow')
    except Exception as ex:
        msgs = str(ex).split('\nvs\n')
        cols1 = msgs[0].split('metadata\n--------\n')[1]
        keys3 = (''.join(cols1)).split('pandas\': ')[1][2:].replace('\'\n            b\'', '')[:-32]+'}'
        dict1 = json.loads(keys3)

        cols2 = msgs[1].split('metadata\n--------\n')[1]
        keys3 = (''.join(cols2)).split('pandas\': ')[1][2:].replace('\'\n            b\'', '')[:-31]+'}'
        dict2 = json.loads(keys3)

        modified_column = self.dict_compare(dict1['columns'], dict2['columns'], 'name')
        print(modified_column)

def dict_compare(self, l1, l2, key):
    l1 = sorted(l1, key=itemgetter(key))
    l2 = sorted(l2, key=itemgetter(key))
    msg = ''
    for d11, d12 in zip(l1, l2):
        if d11[key] != d12[key]:
            msg += 'One dataframe has an additional key, either, - ' + d11[key] + ' or ' + d12[key]
            return msg
        for key1, value in d11.items():
            if value != d12[key1]:
                msg += 'For column ' + d11[key] + ', ' + key1 + ' value ' + value +\
                       ' does not match ' + d12[key1]+'\n'
    return msg

Guess what, no difference. But this is all Dask gives me so I am blind to the actual differences it detects.
To use Dask for big data we need better reporting of the differences in schemas between 2 or more parquet files given pandas's propensity to decide what dtypes are suitable on a dataframe by dataframe basis. The dump of the schema info is over 100KB for each dataframe in my case.

This is how I cut down the massive logging output to something I could deal with/ It may be useful to someone else, or a more suitable version built into Dask:
            try:
                ...
                df = dd.read_parquet(data_filenames, columns=list(columns), engine='pyarrow')
                df_cache = df.compute()
                ...

            except Exception as ex:
                # Process the ex message to find the diff, this will break if Dask change their error message
                msgs = str(ex).split('\nvs\n')
                cols1 = msgs[0].split('metadata\n--------\n')[0]
                filename = cols1.strip('Schema in ').split(' was different. \n')[0]
                kvs1 = (''.join(cols1)).split('was different. \n')[1]

                cols2 = msgs[1].split('metadata\n--------\n')[0]
                kvs2 = (''.join(cols2))[1:]

                key1 = kvs1.splitlines(1)
                key2 = kvs2.splitlines(1)

                diffs = difflib.unified_diff(key1, key2)
                output = u"\n".join(line for line in diffs)

                try:
                    remove_pattern = re.compile('-[a-z]')
                    add_pattern = re.compile('\+[a-z]')
                    remove = remove_pattern.search(output)
                    to_change = output[remove.start(): remove.start()+output[remove.start():].find('\n')]
                    to_change_column = to_change.split(': ')[0]
                    add = add_pattern.search(output)
                    change_to = output[add.start(): add.start()+output[add.start():].find('\n')]
                    change = change_to.split(': ')

                    if change[0][1:] == to_change_column[1:]:
                        # We have sufficient info to update the file in error and retry
                        ...

                    else:
                        raise Exception('Mismatch dataframes - different - ' + output)

                except Exception as ex1:
                       # Just print output so we can interpret


 -- BUG --

So... Trying to boot my device from flash, so inspecting your code... I'm pretty sure 31 in base 10, does not fit in 2⁴-1

RTFM


refactor onoff to separate async notification, standardize terminology, and add functionality

This PR separates generic resource management updates in #22853 from the new queued operation API, and adds an extension to the onoff manager intended to satisfy the use case of #22974 without having to change how cancellation is implemented.  It is intended as something like a rebaseable topic branch where the earlier commits are on a path to stabilization but are still impacted by changes in functionality and API due to evolution of later commits.
The PR branch:

refactors the onoff service to reduce space by putting static configuration data into a separate structure;
extracts the async notification infrastructure from the on-off service into a self-contained structure that can be used anywhere asynchronous operations may be used;
recasts the on-off service as a manager that is to be used by services (including API changes to make it more consistent with other managers to come);
reworks the API to support a change to how cancellation works, providing an ability for the last client waiting for an operation to cancel that operation, using techniques inspired by #23087 and prototyped in #23512;
reworks and extends API to support handling behavioral issues related to cancelling operations, by providing a monitor facility for synchronous notification of state changes in the underlying service;
adds an intermediary that converts asynchronous request and release API to synchronous requests and releases with callback notification when the desired state has been reached, which is an alternative approach that avoids cancellation but satisfying the use case of #22974.

@nordic-krch Yes, the previous implementation had several errors, not unexpected since I hadn't worked on the test suite yet.  The largest was not taking into account the need to release the mutex around two operations, then check for pending state changes after the mutex is complete.  The updated one appears to be correct.

Also, as with #22853, some work has to be done to deal with the fact that an onoff service might enter an error state so its reset capability needs to be reachable from the extended API.  This will come soon, for now I want to know whether this satisfies the functional requirements of the USB module's asynchronous request/release events as identified in https://github.com/zephyrproject-rtos/zephyr/issues/22974#issuecomment-591471296.

Regarding async_notifier: I still believe that such complex solution may not be needed. I want to look into extending onoff manager to support canceling even for last client. In theory it should be possible to move client from list to releaser and return success only to get notification when process is completed with -ECANCELED error (or error reported by the service). That would be cleaner imo.
In that case requesting with unknown client state would look like:
err = onoff_cancel(mgr, cli);
if (err ==  -EALREADY) {
  /* cli is in idle, we are in the settled state */
  onoff_init..callback(cli, started_cb);
  err = onoff_request(mgr, cli);
  /* handle potential error */
} else if (err == 0) {
  /* it means that manager was releasing and we managed to cancel it. */
}

and releasing looks similar:
err = onoff_cancel(mgr, cli);
if (err ==  -EALREADY) {
  /* cli is in idle, we are in the settled state */
  onoff_init_callback(cli, stopped_cb);
  err = onoff_release(mgr, cli);
  /* handle potential error */
} else if (err == 0) {
  /* it means that manager was transitioning to on and we managed to cancel it. */
}

In callback we are able to determine state: if started_cb results in -ECANCELED it means service is off (for this client). If stopped_cb results in -ECANCELED it means service is on (for this client).
The main goal would be to ensure that behavior is the same disregarding other clients requests (now that is not true since last one needs special treatment).

Regarding async_notifier: I still believe that such complex solution may not be needed.

Did you mean onoff_notifier here?
Note that onoff_notifier is far more general and useful than cancellation.  It is expected to handle an arbitrary sequence of request/release items asynchronous to the thing that will use the service once it's turned on.  It works even if neither transition can be cancelled.  It removes all of the management logic from the client, so client code doesn't have to know whether it has an outstanding request that needs to be cancelled.  All the client does is listen for change events.
I accept you've found a case for Nordic clocks where it appears to be safe to synchronously stop an in-progress non-instantaneous start transition, but don't accept that this is likely to be common.  So a solution that works to handle the original use case without involving cancelling in-progress requests and adding client-specific code seems valuable.  In fact it's probably how I'll handle queued_operation_manager use of onoff, because the need to support asynchronous reset becomes extremely complex without it.

@pabigot to move forward could you take out onoff notifier from this PR into another one? That should go in quickly then. That will allow onoff cancel improvement, qop manager and async_seq manager to become merge-able (based on master).

@pabigot to move forward could you take out onoff notifier from this PR into another one?

@pabigot do you plan to do that? It's getting harder to review PR's which contain unrelated changes (async_notify) like #23512

@pabigot to move forward could you take out onoff notifier from this PR into another one?

@pabigot do you plan to do that? It's getting harder to review PR's which contain unrelated changes (async_notify) like #23512

No, I don't.  Changes to cancelling and notification impact the whole onoff manager so I want the complete set of changes to that done in one PR.  It's likely #23512 will replace this PR but I haven't decided yet exactly where the cut between draft and real PR will be.  For now, do nothing more with this.

Changes to cancelling and notification impact the whole onoff manager

It does not impact renaming service to manager and extracting async_notify from onoff and moving transistion functions to external struct. So I would like to see those as separate PR which may go in very soon. It seems that onoff functional changes will take longer.
I'm pushing for that because there is other PR depending on extraction of async notify which is now blocked by onoff functional discussions which are not related to it.

Which PR is that, please?

@pabigot contribution guidelines states: "One general practice we encourage, is to make small, controlled changes." and even title of this PR suggests that there are 3 independent changes.
PR is #23075.

PR is #23075.

I understood that to depend on the queued operation manager in #23333 which is based on this branch.  Until yesterday that was potentially dependent on onoff_notifier, which was thought to be simplifiable by improving cancellation.  Today it isn't, but that could change.  (It does have a syntactic dependence on the notify callback changes motivated by cancellation.)

@pabigot contribution guidelines states: "One general practice we encourage, is to make small, controlled changes." and even title of this PR suggests that there are 3 independent changes.

They're not independent.  Each one can depend on the earlier ones, depending on what each enhancement provides.  This is a draft because things keep changing and I'm tired of maintaining three branches with pieces that get out of date and are hard to rebase.
If we're done changing the semantics and implementation of cancelling in-progress on-off transitions, then we can start to peel things off.  But I won't be confident of that until we have a solution you and I agree will work for #22974.  From my perspective right now the best solution is onoff_notifier.

I understood that to depend on the queued operation manager in #23333 which is based on this branch

no, that is #23371. #23075 is using async_notify extracted from onoff.
I don't see how this https://github.com/zephyrproject-rtos/zephyr/pull/23229/commits/c3c70730cdad8f30db0594a77b08627927a61f50 is dependent? it could go to master much faster than the rest. Same with https://github.com/zephyrproject-rtos/zephyr/pull/23229/commits/61b9df39d613c523920d096f5dd57e059f3d7de9 which i had ready in PR but you convinced me to taken it into your PR which won't get merged in near future.

This is a draft because things keep changing

That applies only to cancel/notifier work and not refactor onoff to separate async notification, standardize terminology part of PR.

onoff solution has been completedly redesigned, this branch is not viable.


Missing documentation for dynamic increment

This feature states to be "completed",
https://feedback.azure.com/forums/248703-api-management/suggestions/15161985-support-dynamic-n-for-quota-call-rate-limits
but there is no docs on how to achieve it

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: c64c31f4-ee3f-1482-14a8-3585ff5ef2de
Version Independent ID: 8e50e224-bfd8-061c-3203-4d19016d16dd
Content: Advanced request throttling with Azure API Management
Content Source: articles/api-management/api-management-sample-flexible-throttling.md
Service: api-management
GitHub Login: @vladvino
Microsoft Alias: apimpm

@evertonmc The quota policy supports a bandwidth attribute which defines
"The maximum total number of kilobytes allowed during the time interval specified in the renewal-period"
I believe this covers the scenario mentioned in the feature request.

It doesn't. The feature request refers to a custom N value for the increment, like: this requests costs 7 calls in the available quota.

@evertonmc My bad. Seems like I just read the part of the audio data.
@vladvino Do we support this?

Hi @miaojiang could you add some clarity to this?

@evertonmc  can you please elaborate on your scenario? How do you determine the N?

@miaojiang in my case, N will be based on the request payload (object count) but in other usecases the request “weight” could be also part of the header or a jwt-claim

@evertonmc, got it. There is a 'increment-count' attribute you can use in the policy. Somehow it was removed from the documentation, we will add it back.
<rate-limit-by-key calls="number" renewal-period="seconds"
    counter-key="expression like @(context.Subscription.Id) or a constant string"
    increment-count="optional, by default = 1"
/>

hi @miaojiang, thank you very much for revealing this (somehow) hidden attribute. It's exactly what we where looking for! Cheers!
I just tested this feature and it has a MAJOR bug, but I don't think that it belongs to the scope of this doc issue.
When increment-count is set in the quota-by-key policy and the (to-be-)incremented value exceeds the quota, the requests gets through once anyways. Which is probably by design, because incrementation happens after "response condition".
The problem is: Once this value get over the quota (lets say 101 for a quota of 100) it stucks at quota exceeded, even if I reset the quota through the REST API
So the question is: Would you point me to the right place to submit this bug to?

@evertonmc we will take a look. Would be great if you can submit a support ticket to properly track the issue.

@evertonmc Since the discussion is now outside the scope of this documentation, we will now proceed to close this thread. If there are further questions regarding this matter, please reopen it and we will gladly continue the discussion.

@miaojiang I will. Thanks

@evertonmc Reopening this issue for tracking updates to this doc with respect to the insights shared here.
Also, feel free to open a similar issue on the reference doc as well.

@miaojiang Were you able to get the example you referenced above added to the document?  Happy to add it if you can tell me which section it should go in.

#reassign:dlepow

Apologies for delay responding to this issue. I've created a work item to update the policy reference with the missing attribute in an upcoming doc sprint. According to our usual process, I'll proceed to close the issue for now. If you have further information or wish to continue the discussion, please feel free to contact us again. Thanks!
#please-close


typo on chapter 33.7 RVB (Bitmanip)

currently in 1.0.1
The Zbkb, Zbkx and Zbkx extensions are included in their entirety.
I assume it should be:
The Zbkb, Zbkx and Zbkc extensions are included in their entirety.
Zbkc

Note that I don't believe this was ever fixed and it therefore made it into the riscv-isa-manual at time of integration.  The text post integration reads: "The Bit-manipulation for Cryptography, Crossbar permutations and Crossbar permutations
extensions are included in their entirety."  As you can see, Crossbar permutations is duplicated.  This is in 33.7 in the RVB (Bitmanip) section.  Note that Zbkc is "Carry-less multiplication for Cryptography".
Therefore the fixed text should read "The Bit-manipulation for Cryptography, Crossbar permutations and Carry-less multiplication for Cryptography extensions are included in their entirety."


Add modal project details

Add project section and modal for project details using javascript
in this project

Added project section with javascript
Added modal with project details
updated readme to include last changes
Used linters.

Project Status: INVALIDATED :red_circle:
Hi @AjroudiRida ,
While you made a great effort in this project, I can't go ahead and review your code.

Invalid Code Review Request

This is because you have submitted a project, pair-programming activity, and as a result needs to have commits from both you and your partner or partners. 💯
However, if for some reason you have to do the project alone, then attach a screenshot of the message you received from student success stating that you can do the project alone in the pull request description 👍

Your Code Review Request will be marked as invalid in your Dashboard, so please submit a new one once you are ready 🙏
Cheers, and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me @NahnahAJ in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

Invalid Code Review Request does not count into the code reviews limit.


Failed to use Rotary_encoder_example  (IDFGH-5105)

Because I used pins 10 and 11 on the PCB , when I changed the GPIO pins in the example, there was an error.
I need to use four rotary encoders simultaneously。However, after I made four copies according to the template of the sample code, he made a mistake of interrupting the repeated registration. Could you please tell me how to solve this?
When I comment out the code that breaks registration, I can run all three at once, except for pins 10 and 11.

GPIO10 and GPIO11 on ESP32 are used by SPI flash by default, please refer to datasheet and  soc/esp32/include/soc/io_mux_reg.h for more details.
As for the example itself, if you want to drive multiple encoders with overflow handling (in interrupt handler), you need to alter the example, make sure calling pcnt_isr_service_install only once globally. And handle the overflow event for each pcnt unit respectively in the ISR callback.

Hello, I have read the io_mux_reg.h file, but I don't quite understand it.First I want to know if 10 and 11 can be modified to be used as encoders.Secondly, if possible, how to modify it？

Hi @zsjlovestudy GPIO11 is SPI_CS0_GPIO_NUM you can't use it for other purposes.

Hi @zsjlovestudy GPIO11 is SPI_CS0_GPIO_NUM you can't use it for other purposes.

Hello, could you please tell me if there are any other pins like 11 pins? Because I need to specify the pin  to PWM and encoder at present.

The following GPIOs are used by SPI Flash by default:
#define SPI_CLK_GPIO_NUM                            6
#define SPI_CS0_GPIO_NUM                            11
#define SPI_Q_GPIO_NUM                              7
#define SPI_D_GPIO_NUM                              8
#define SPI_WP_GPIO_NUM                             10
#define SPI_HD_GPIO_NUM                             9

In order to create multiple encoder instances the ROTARY_CHECK needs to be avoided from the pcnt_isr_service_install call. I added this switch to the "register interrupt handler" section of rotary_encoder_pcnt_ec11.c so that I could have multiple encoder instances.
	// register interrupt handler
	switch(pcnt_isr_service_install(0))
	{
		case ESP_OK:
			break;
		case ESP_ERR_INVALID_STATE:
			ESP_LOGI(TAG, "pcnt isr already installed");
			break;
		default:
			ROTARY_CHECK(1==0, "install isr service failed", err, ESP_FAIL);
	}

Does anyone want a pull request for something like this? Is this component going to be an "official" component one day?

Hi @camrbuss yes, the issue you found is correct. The interrupt is shared by PCNT channels, it should be installed only once.

Is this component going to be an "official" component one day?

We don't have a plan to raise the level of this example component, but we're working on new PCNT driver APIs to make that peripheral more flexible, especially for encoders use cases.

I ran into the same problem. I configured two encoder.


Lost the following code from HostSideView to Host

@fbiwarning commented on Mon Jun 03 2019
This page do not contain the code about HostSideView HostSideAdapter AddIn and Host.

文档详细信息
⚠ 请勿编辑此部分。 docs.microsoft.com ➟ GitHub 问题链接必须具有此部分。

ID: 0e6fd3c3-68eb-a164-f4cb-1ec07c7b233d
Version Independent ID: da8b15c4-734d-6cc6-fa2d-5f26bb697164
Content: 如何：创建作为 UI 的外接程序
Content Source: docs/framework/wpf/app-development/how-to-create-an-add-in-that-is-a-ui.md
Product: dotnet-framework
Technology: dotnet-wpf
GitHub Login: @dotnet-bot
Microsoft Alias: dotnetcontent

Hi team,
I'm moving this here because it looks like the user is requesting aditional examples
best

Thanks, @CeciAc. This is a case of some of the C# code and all of the Visual Basic code having been lost during a migration.


chore(main): release 0.6.46

:robot: I have created a release beep boop
0.6.46 (2023-06-29)
Documentation

fix urls (#169) (aaa5b75)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/rickstaa/stable-gym/releases/tag/v0.6.46 :sunflower:


JSONDecodeError while translating

Googletrans version:

[x] 4.0.0rc1
[ ] 3.1.0a0
[ ] 3.0.0
[ ] 2.x

I'm submitting a ...

[x] bug report
[ ] feature request

Current behavior:
During translation, a JSON decode error occured.
Expected behavior:
Translate and correctly return the translated text.
Steps to reproduce:
It randomly happear during a translation loop. Retrying the same loop, it doesn't happend.
Related code:
File: googletrans/client.py:198
data = json.loads(resp), where resp seems to be None.
Other information:
Traceback (most recent call last):
  File "translate.py", line 95, in <module>
    output[lang][page_name][key] = translator.translate(value, src='en', dest=lang).text
  File "[redacted]/venv/lib/python3.8/site-packages/googletrans/client.py", line 218, in translate
    data = json.loads(resp)
  File "/Library/Developer/CommandLineTools/Library/Frameworks/Python3.framework/Versions/3.8/lib/python3.8/json/__init__.py", line 357, in loads
    return _default_decoder.decode(s)
  File "/Library/Developer/CommandLineTools/Library/Frameworks/Python3.framework/Versions/3.8/lib/python3.8/json/decoder.py", line 337, in decode
    obj, end = self.raw_decode(s, idx=_w(s, 0).end())
  File "/Library/Developer/CommandLineTools/Library/Frameworks/Python3.framework/Versions/3.8/lib/python3.8/json/decoder.py", line 355, in raw_decode
    raise JSONDecodeError("Expecting value", s, err.value) from None
json.decoder.JSONDecodeError: Expecting value: line 1 column 1 (char 0)

The reason the resp is None could be the Google API returns 400 or 404 for translator's requests (which was in my case).
I was initializing Translator instance as:
Translator(service_urls=['translate.googleapis.com'])
which was casing the requests to fail with 404. Changed to:
Translator(service_urls=['translate.google.com'])
and it fixed the problem for me.


Where is the description of concrt.dll?

The concrt.dll is not mentioned unfortunately. But we can see the VS specific version like concrt140.dll in the VS2017 VC Redist folder. I guess it is missing. Could you please add the description?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 4f9074f9-b954-c810-e449-f2663c1546ce
Version Independent ID: 4b3b0d42-eae9-d7bb-4b5f-e505595204bc
Content: CRT Library Features
Content Source: docs/c-runtime-library/crt-library-features.md
Product: visual-cpp
GitHub Login: @corob-msft
Microsoft Alias: corob

added. should be visible by 08/20. thanks @CaryFan !


Use nox

Codecov Report

Merging #17 (eb207bc) into main (9fb151e) will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##            main     #17   +/-   ##
=====================================
  Coverage   0.00%   0.00%
=====================================
  Files         16      16
  Lines        906     869   -37
=====================================
+ Misses       906     869   -37

Impacted Files
Coverage Δ

hikari_clusters/brain.py
0.00% <0.00%> (ø)

hikari_clusters/server.py
0.00% <0.00%> (ø)

hikari_clusters/cluster.py
0.00% <0.00%> (ø)

hikari_clusters/payload.py
0.00% <0.00%> (ø)

hikari_clusters/callbacks.py
0.00% <0.00%> (ø)

hikari_clusters/ipc_client.py
0.00% <0.00%> (ø)

hikari_clusters/ipc_server.py
0.00% <0.00%> (ø)

hikari_clusters/info_classes.py
0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9fb151e...eb207bc. Read the comment docs.


Use /openapi.json as default location for OpenAPI data

This applies to the 3scale trait, which currently uses /api-doc by default.

Would you kindly let me know what exactly needs to be done so that I can try working on it?

Hi @rajatdiptabiswas, I think it's sufficient to change the default value in the threescale addon trait from "/api-doc" to "/openapi.json". Can you do it?

From what I understood, I believe I should change ThreeScaleDescriptionPathDefaultValue = "/api-doc" to ThreeScaleDescriptionPathDefaultValue = "/openapi.json" in line 67 of /addons/threescale/3scale.go
There are a few more mentions of /api-doc in 3scale_test.go, traits.yaml, and 3scale.adoc.  One more in line 44 of 3scale.go as well.
Do I need to make any changes to those?
I am hopeful I shall be able to make the required changes.
Kindly confirm if I have understood your instructions correctly.
Thanks in advance!

Yes, changing that variable plus the mention is ok.
traits.yaml, and 3scale.adoc can be manually changed or auto-updated running make generate-doc.


build(deps): bump sentry-cli from 2.12.0 to 2.21.2

This PR resolves []
Description
Bumps sentry-cli from 2.12.0 to 2.21.2

#nochangelog

Warnings

:warning:

✅ No changelog changes

  Generated by :no_entry_sign: dangerJS against 7900febbe7a4e9dcfa614d8c2255cd9738a79436


Update Emulator.cs

Initialization simplified

Yeah the thing is that this requires a more recent C# version. Keep in mind that this file is not compiled by "us" but rather by the "user", i.e., if you don't use a compatible C# version you'll get a very strange error message here...

Solved via the comment discussed in #8


[FEATURE REQUEST] Document component retention

Is your feature request related to a problem? Please describe.
Currently there are still a number of TODO`s in the following documentation:
https://github.com/epiphany-platform/epiphany/blob/cleanup/docs/home/howto/RETENTION.md
Describe the solution you'd like
See if this is still valid and document it to the latest version of Epiphany.
Describe alternatives you've considered
None
Additional context
None

DoD checklist

Changelog

[ ] updated
[ ] not needed

COMPONENTS.md

[ ] updated
[ ] not needed

Schema

[ ] updated
[ ] not needed

Backport tasks

[ ] created
[ ] not needed

Documentation

[ ] added
[ ] updated
[ ] not needed

[ ] Feature has automated tests
[ ] Automated tests passed (QA pipelines)

[ ] apply
[ ] upgrade
[ ] backup/restore

[ ] Idempotency tested
[ ] All conversations in PR resolved
[ ] Solution meets requirements and is done according to design doc
[ ] Usage compliant with license

Not going todo anymore feature requests for Epiphany.


Group_by delta not performing as expected for rain sensor

Checklist

[x] I updated the card to the latest version available
[x] I cleared the cache of my browser
[x] I verified that I'm really running the lastest version in my browser console
[x] I checked if there is another issue opened with the same problem

Describe the bug
I have a rain sensor that reports the total amount of rain in mm accumulated. I would have expected that the delta function would report meaning full values, however the values are not consistent with the values reported by utility meter and have zero values in periods where the total changes. I think it might have something to do with the sensor reporting values quite infrequently and only when the value changes. I attempted to get a csv file from the chart but it seems the timescale is broken in the csv
Version of the card
Version: 1.7.0
To Reproduce
This is the configuration I used:
type: 'custom:apexcharts-card'
header:
  show: true
  show_states: true
  colorize_states: true
series:
  - entity: sensor.regn_mgd
    name: delta 15min
    group_by:
      func: delta
      duration: 15min
  - entity: sensor.regn_mgd
    name: delta 2h
    group_by:
      func: delta
      duration: 2h

Screenshots
Same data with delta 15min and 2h

Raw data:

Expected behavior
Data whenever the graph changes
Desktop (please complete the following information):

Browser Firefox
Version 85.0.2

Smartphone (please complete the following information):

Device: [e.g. iPhone6]
OS: [e.g. iOS8.1]
Browser [e.g. stock browser, safari]
Version [e.g. 22]

Additional context
Add any other context about the problem here.

I don't think this can be considered a bug.
group_by generates buckets of duration of data based on the history. If there is not entry in the history for a specific bucket (because there is no state change within the time frame of the bucket) then the bucket receives the last known state only (by default). Which means delta can't work because there is only 1 value in the bucket.
Irregular timeseries is always inconsistent as we can't generate any data which does not exist.

I think there is something strange going on. My utility sensor which is based on the same sensor gives this plot

It is defined as an hourly utility sensor:
utility_meter:
  regn_time:
    source: sensor.regn_mgd
    cycle: hourly

The equivelent apexcharts-card results in this plot:

type: 'custom:apexcharts-card'
header:
  show: true
  show_states: true
  colorize_states: true
series:
  - entity: sensor.regn_mgd
    type: column
    group_by:
      func: diff
      duration: 1h

You should read my comment again, the result is what is expected based on how a timeseries work. Also utility_meter resets the data at the beginning of the hour and if there is any state change during the hour, it records the delta.
You have to think about your history in terms of points of data and not a line.
Eg:

at 3.30pm: state change to 2
no state change until...
at 5.30pm: state change to 5
at 5.45pm: state change to 6

Creating buckets of 1h will generate this (if your graph is aligned with the end of the hour end: hour in span) :

bucket 3pm -> 4pm: 2 (delta = 0, diff = 0)
bucket 4pm -> 5pm: 2 (because there is no value in the bucket, it uses the last known value by default. delta = 0, diff = 0)
bucket 5pm -> 6pm: [ 5, 6 ] (delta = 1, diff = 1)

That's it, you can't calculate a delta or a diff within each bucket because there is only one value. In your case that what is happening.

I get your comment regarding bins, but as you can see in my bottom picture, showing the raw data, there are changes in the state before 20.30 when the graph generated by the apex card begins. It would be strange if none of these changes fall within a bucket. Could it be a rounding error?

Add:
span:
  end: hour

This will align all the buckets to the exact hour. It might solve your problem. group_by's buckets are constructed from the end of the chart by default, not aligned to the hour.

I know i know. Please indulge me

These two graphs use almost the same yaml where one shows raw and another shows delta. I also tried diff
TOP
type: 'custom:apexcharts-card'
graph_span: 36h
header:
  show: true
  show_states: true
  colorize_states: true
span:
  end: hour
series:
  - entity: sensor.regn_mgd
    type: column
    group_by:
      func: delta
      duration: 1h

BOTTOM
type: 'custom:apexcharts-card'
graph_span: 36h
header:
  show: true
  show_states: true
  colorize_states: true
span:
  end: hour
series:
  - entity: sensor.regn_mgd
    curve: stepline
    group_by:
      duration: 1h

I understand why there is no rain after 17.00 but why no rain before 21? I guess the state changes just happen in an unfortunate way. If I change to 2h I do get some peaks before 21.00... Oh well I will stick to the utility meter :)

Read the link that I added to my previous post, you might understand better 😉


Autocomplete Doesn't works in any language.

VSCode Version: 1.4.0
OS Version: Ubuntu 16.04.1

Problem:
Autocomplete doesn't works in any language. I program in Java, JS, C and Go and I have the correct Plugins installed like Java language support for java and also d.ts files from typings. But it just doesn't works. I have followed guides that I found on the internet but it has not worked one time.
Also, Hovering over something should give a tooltip like popup with some details but it doesn't happens. It's plain notepad for me.
I am sure that OS is not a problem because I was using it on 14.04 and none of this was working then I upgraded to 16.04.1 and it still doesn't works. And I have dualboot with Windows 10 and none of this works on windows 10.
I am having this problem since last 40-45 days. All these features worked the first time I installed Vscode and it stopped working and hasn't worked ever since.
Installing language specific intellisense ts definitions using typings is actually not reliable and it has not worked for me.
I have no intention of wasting anyone's time on this problem and this is why I spent so much time tweaking things, googling and I have come up with nothing that can help.
Also, code formatting plugins don't work correctly.
Method's I have tried:
Reinstalling vscode.
Reinstalling OS.
Cleaning all the configuration files and reinstalling all the plugins and setting everything again
Nothing worked.
Help someone.

Solved. If I accidently or other wise close Vscode when it's downloading a extension then that extension stops working after install.
Solution:
Uninstall vscode.
Delete ~/.vscode
Delete ~/.config/Code

Reinstall.


Add keyword 'editor' to project's description

Add keyword editor to project's description, for friendly search

---
Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/5248009-add-keyword-editor-to-project-s-description?utm_campaign=plugin&utm_content=tracker%2F282001&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F282001&utm_medium=issues&utm_source=github).

@learning @zoli This seems like a pretty simple enhancement. Which description field needs the editor keyword? GoDoc? Github? Something else?

Done, Thanks.


Uncaught ReferenceError: JSONEditor is not defined

After upgrading to v6.0.0-rc1-final and core 5.3.2 everything broke and throws a console error: Uncaught ReferenceError: JSONEditor is not defined
Any ideas? Missing some dependencies maybe?

I just had the same issue, and tracked down what my problem was. I don't know that it's the same problem you're experiencing, though. Our issue was that we'd provided a custom index.html file. This file was not compatible with the newer version of Swashbuckle/Swagger-UI. Among other differences it was missing a script tag for lib/jsoneditor-min-js. This seems like a very error prone way for customizing the display, but it's the only method we're aware of. I don't know if this information will help you or not, but figured I should supply it.

Thank you yes this is quite likely the same issue as we also use a custom index.html. I'll give that a shot today, thanks for the suggestion!

This was an unfortunate "breaking change" to those of you using custom "index.html" files. Because the swagger-ui introduced a new dependency on JSONEditor, you could argue that it's a breaking change on their end and this should have been indicated with a new major version which would have made me think twice including it with the SB 5.x line.
On the flip side, a new major version seems like overkill too. For now, I'm going to apologize to you all for the breaking change and close the ticket.

So.. what exactly is the fix here?

Update your custom index file to pull in the required script (i.e. jsoneditor) as shown here https://github.com/domaindrivendev/Swashbuckle/blob/master/Swashbuckle.Core/SwaggerUi/CustomAssets/index.html


Automated Package Upgrade

:tada: This PR is included in version 5.0.375 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


[Bug]: About us page doesnot show all the products

Is there an existing issue for this?

[X] I have searched the existing issues

What happened?
the products in the navbar doesnot show kidsection and accessories.
Add Screenshots / Video Clip

I want to work on this issue.
Please assign me this issue under gssoc-extd,hacktoberfest-accepted and appropriate level.
@Tejashri-Taral @hars-21 @BrindaManani
What browsers are you seeing the problem on?
Chrome
Agreements

[X] I agree to follow this project's Code of Conduct
[X] I'm a GSSoC contributor
[X] I'm a Hacktoberfest contributor
[X] I want to work on this issue [Optional]
[X] I'm willing to provide further clarification or assistance if needed.

We want to keep the about us page simple. hence we didn't add this info.
you can still find and raise new issue


fix: not usable unlocked package with namespace

Description
The solution here is to go for an unlocked package with namespace and to provide mechanism to overcome the same namespace stub creation limitation
This PR provide a MockFactory outside the package, used to stub type in the same namespace
All the classes have the global modifiers where necessary
Thanks to @jongpie and @chazwatkins for the discovery of this issue and the global modifier
The package is a new one with the mockery namespace
Motivation and Context

closes #36
Based on #35 works
How Has This Been Tested?

Inside this PR with a new validation step

Could you confirm this please @jongpie?

@scolladon-sfdc done! Let me know if you need anything else!

We decided to go with non namespaced package
We think user will not likely have a namespaced and we also ship a mechanism to work with namespaced type

@scolladon-sfdc thanks for the update! I think it makes sense to go with a non-namespaced package since Test.createStub() doesn't support stubs from different namespaces. If you ever need some help with the repo again, just let me know!


Update layout of user profile page

Related to #436 and #444.
As noted in #436, the Devise-based user pages include the w-25 Bootstrap class, which makes the main content area of these pages unnecessarily narrow in most viewport widths:

Removing the w-25 class should help the user profile page as well, however, if we can tackle the suggested approach in #444, I'd suggest we could also make some other minor improvements to the user profile page, as outlined below.
Below is a mockup of the suggested improvement, followed by notes on specifics:

A: The suggested layout assumes the work in #444 has been completed, so the centered form and page title would likely be inherited from that work. (This layout doesn't match pages elsewhere in POD, but I think the user-related pages are distinct enough that it's fine, maybe even desirable, for them to have a separate layout.)

B: Page title is renamed User profile. This should also be changed to an h1 from the current h2, since the application is using page titles as h1s elsewhere. (I hope to do a more thorough a11y analysis of things during the workcycle.)

C: This is likely the trickiest part of this issue: separating the basic user profile fields from the change password fields. I think it's important, though, because the current form is potentially confusing (e.g., do you need to enter your password in the first password field if you are just changing your job title?). Also, I believe currently you are required to provide your current password to change the basic profile fields, which might be a native Devise thing but seems unnecessary for how the POD application will be used. This page is not accessible unless the user is logged into POD, which seems sufficient proof of identity to me for the user to change their name or job title (I wonder if the email address input should be a read-only field, though. Perhaps we'd want to prevent a user who was invited to join an organization using a specific email address from later changing that email address without the person who invited them to their organization knowing?). So my suggestion is those three fields make up a separate form that the "Update" button (btn-primary) submits.

The label of the first field is changed to "Email address". The input might be disabled, if people agree with my concern above.
"Cancel" returns the user to the previous page, same as the "Back" action does on the current profile page.

D: This section splits out the password fields as a new form for the user to change their password.

Section heading "Change password" is an H2
Fields are re-ordered so the user starts by entering their current password.
Hint is removed from current password field since the distinct section makes it pretty clear you need to enter all fields to change your password.
Field labels are changed for "New password" and "Confirm new password"
Submit button label is "Change password" and is a btn-secondary

E: Change the section heading to "Cancel your account" and make it an h2. Style the "Cancel account" button with btn-danger so it is more clearly a destructive action.

Additional (future?) layout updates
This might be too much for the current workcycle but in the future, the sections on this page might benefit from being separated  into three tabs:

Edit profile
Change password
Cancel account

For example, below I've kept the same section content as above (except for adding an intro paragraph to the Cancel account tab), but split the sections into tabs:

This arrangement would make things less cluttered and provide a better foundation for adding new user-specific features in the future (just add a new tab, or add fields to a current tabbed section) without creating an long, unwieldy page.

Relates to #156

@marlo-longley Good question. I would suggest "Cancel" takes the user to the previous page they were on. The current edit profile form has a "Back" link that does this. So the "Cancel" would use the same behavior as the current "Back."
A possible hitch with this is the new layout includes multiple tabs. So if the user completes a change in the first tab, say, and then goes to another tab in the profile and selects "Cancel" where does the user go? I think either back to the previously completed tab, or to the page they were on before going to the Edit profile section, are acceptable. Whichever works best with new code should be fine.


426 448 452 457 458 combined

Combined PR of:
#426
#448
#452
#457
#458

Sorry for the noise, wrong fork.


fix(bullmq): invalid name used for job retrieval

Information

Type
Breaking change

Fix
No

Used the wrong key for retrieving the job in the dispatcher

Todos

[X] Tests
[X] Coverage
[ ] Example
[ ] Documentation

:tada: This PR is included in version 7.51.1 :tada:
The release is available on:

v7.51.1
GitHub release

Your semantic-release bot :package::rocket:


BUG: Newsletter and message not clear after some time after some time input filed and message should be clear.

Is there an existing issue for this?

[X] I have searched the existing issues

What happened?

I will add that java script for clear input filed and message of thank you after submit.
Record

[X] I agree to follow this project's Code of Conduct
[X] I'm a GSSOC'24 contributor
[X] I want to work on this issue

@huamanraj @anuragverma108 @RishabhDhawad @RitiChandak Can anyone please assign me !
Also I have an issue my previous PR #2160 is merged but i don't get labels so please provide labels on that so my points will be count.

@huamanraj @anuragverma108 @RishabhDhawad @RitiChandak Can anyone please assign me !
Also I have an issue my previous PR #2160 is merged but i don't get labels so please provide labels on that so my points will be count.

there is no level for some too basic changes!!.

@huamanraj in PR #2160 i have added 40+ lines of code for every size of screen it is and you called that is basic ?
I think you should consider my efforts.
Thank You !

@huamanraj in PR #2160 i have added 40+ lines of code for every size of screen it is and you called that is basic ?
I think you should consider my efforts.
Thank You !

sorry i thought of other PR and judged without looking at it! it was our mistake that we haven't given any level!

@huamanraj It's Ok !
Thank You !


KubeArmor k8s controllers for arm64 platform

Feature Request
Short Description
KubeArmor supports ARM platform and we're done with testing some ARM based edge devices with apparmor LSM and in continuation to test various K8s-Engines with ARM based compute i.e. Azure Ampere, OKE Ampere.
We already providing some of the KubeArmor Artifacts i.e. kubearmor, kubearmor-init container image. for ARM platform.
We need to provide KubeArmor k8s controllers i.e. kubearmor-annotation-manager, kubearmor-host-policy-manager, and kubearmor-policy-manager for ARM plateform too.
Is your feature request related to a problem? Please describe the use case.
Currently KubeArmor k8s controllers are crashing on ARM based cluster.
kube-system   kubearmor-annotation-manager-7fc8d9b964-g8lhf    1/2     CrashLoopBackOff
kube-system   kubearmor-host-policy-manager-5644c558d8-grn7f   0/2     CrashLoopBackOff
kube-system   kubearmor-policy-manager-5cc6867465-7h4v5        0/2     CrashLoopBackOff

With the error related to incompatible binary format.
$ kubectl logs -n kube-system kubearmor-host-policy-manager-5644c558d8-grn7f
Defaulted container "kube-rbac-proxy" out of: kube-rbac-proxy, kubearmor-host-policy-manager
exec ./kube-rbac-proxy: exec format error

$ kubectl logs -n kube-system kubearmor-policy-manager-5cc6867465-7h4v5
Defaulted container "kube-rbac-proxy" out of: kube-rbac-proxy, kubearmor-policy-manager
exec ./kube-rbac-proxy: exec format error

Describe the solution you'd like
build and push kubearmor k8s controller for ARM platform too.

Ref #1084


Stream component errors

Hi,
Trying to use the new stream component, I get the following errors (sometimes it plays for a short period of time, otherwise it crashes HA).
no frame!
1:11 PM components/stream/worker.py (ERROR) - message first occured at 1:11 PM and shows up 20 times
decode_slice_header error
1:11 PM components/stream/worker.py (ERROR) - message first occured at 1:11 PM and shows up 20 times
non-existing PPS 0 referenced
1:11 PM components/stream/worker.py (ERROR) - message first occured at 1:11 PM and shows up 40 times

The stream works fine direct in Chrome or via VLC, the stream is a M3U8...

I'm also seeing:
https://***/lovelace/duck_coop:0:0 ResizeObserver loop limit exceeded

Rebooted my duck coop camera and it's working, will report back if it returns.

Reopening as I still see this, opening a stream often fails and causes HA to crash.

Same problem, after playing stream, HA crash

Do you have any orther FFMPEG components enabled or configured?  If not, let's re-visit this issue after 0.90.2, which should include #22338

I'm not having the crashing issue after playing a stream, but I do see the "ResizeObserver loop limit exceeded" and it takes a little longer than you might expect (10s of seconds) to load up the stream (generic camera). With subsequent openings of the camera, the stream loads quicker (couple seconds) but I still get the ResizeObserver error.
Not sure if the UI error actually has anything to do with it, or that's just how long the stream takes to load initially.

@Swiftnesses - Are you still having issues after 0.91.1?  Some changes were made that solved stream for some configurations.
@mtweten - 0.91 has a "Preload Stream" option that will solve that issue.

I still have the issue of "stream" component crashing Home Assistant. I'm using 0.95.4


Meta, 4th-wall-breaking contribution

A contribution about contributions...
I wasn't sure where to put this in relation to your other points, so I just put it at the end. You're welcome to move it around lol

Seems good! Thank you!


Minor Readme adjustments

On the systems i tried, the modifications in the PR are required to get the expected results, submitting for cross-checking

I have backported the first part of the PR into https://github.com/medooze/media-server-node/commit/54ef9a42d5c921ff137c0e0ea14ba9be75c53a88
thanxs for pointing it out!

Hi @lmangani!  we lost the CLAs signed in clahub, would you mind singing the following CLA for your contributions to the Medooze projects?
https://cla-assistant.io/medooze/clas


Jamie city card

There is almost no styling, but the base functionality is there and the less style sheets are set up for more styling

navigate to the /results route to see them rendered


Add anonymous-credentials review to wasabi/research-club

This PR adds anonymous-credentials transcript review to the wasabi/research-club directory.

Thank you for your submission. It appears that the transcript was submitted without any edits or changes made. Please ensure that you review and make necessary edits before submitting your work in the future.
If you have questions or you need help, feel free to join our Bitcoin Dev Project Discord.


⚠ Bofrost.at has degraded performance

In 366a061, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1960 ms

Resolved: Bofrost.at performance has improved in a77e174.


Strongly Connected Components

Would like to see Visualization of (1) Kosaraju’s and (2) Tarjan's Strongly Connected Components Algorithm in action.

Thank you for your suggestions, they're now added to our scope of new algorithms to add as well as the README.md.


Upload to external server

Hi,
I followed the RecordRTC-to-PHP demo to upload a video blob to my server. This works well, but because our website will be handling a decent amount of videos, we like to use a third party to store our videos on.
The API of the third party basically works like this (tested it, and it works):
$thirdparty_api = new ThirdPartyAPI('mykey', 'mysecret');
$response = $thirdparty_api->upload_file("path/to/file/video.webm", "file");

So I tried changing this:
$fileName = $_POST["video-filename"];
$uploadDirectory = "uploads/$fileName";
if (!move_uploaded_file($_FILES["video-blob"]["tmp_name"], $uploadDirectory)) {
  echo("problem moving uploaded file");
}

To this:
$thirdparty_api = new ThirdPartyAPI('mykey', 'mysecret');
$response = $thirdparty_api->upload_file($_FILES["video-blob"]["tmp_name"], "file");

But this gives me an error that the file doesn't exists. Any thoughts?

I think PHP deletes the temp-file after php-script ends the execution.
So I'll recommend this:

Move file from 'temp' to '$uploadDirectory' using move_uploaded_file method
Upload file from $uploadDirectory to ThirdPartyServer
Delete file from $uploadDirectory

Here is how it looks like:
$fileName = $_POST["video-filename"];
$uploadDirectory = "uploads/$fileName";

if (!move_uploaded_file($_FILES["video-blob"]["tmp_name"], $uploadDirectory)) {
  $thirdparty_api = new ThirdPartyAPI('mykey', 'mysecret');
  $response = $thirdparty_api->upload_file($uploadDirectory, "file");

   // after when/if third-party upload ends
   unlink($uploadDirectory);
}

Thanks for your reply. I played around with it a bit more and am now getting another error from the API "only video or image files are allowed", so my guess is it doesn't allow $_FILES["video-blob"]["tmp_name"] to be uploaded. Do you maybe know how I could bypass this?
I want to upload the video directly to the third-party cloud, because allowing people to upload videos to your own server is a major security risk, and I'm not security wizard myself. Also, our webserver probably isn't strong enough to handle al the videos (around uploads 30.000 each day, which can all be viewed by the community). So moving it to the server first, and then moving it to the third party kinda destroys the whole purpose why we would use a third party in the first place...


GSE113196_HumanBreastCellDiversity

HumanBreastCellDiversity
Ingest
https://contribute.data.humancellatlas.org/projects/f71d4ab7-8115-4208-83b6-bf03dec07b74/edit?tab=project_admin
GEO
GSE113196
Google Sheet
https://docs.google.com/spreadsheets/d/1N9K2xaWv5zbT8NbOFCfNrtXBS7JU9tqN4B4R47S72tg/edit#gid=138808022
Publication
https://www.nature.com/articles/s41467-018-04334-1

Sent the authors an email. There is very little information on the organoid protocol(s).

7706e2b2-4f83-48cf-bf4d-6814025a6787

Emailed the authors again, due to no response. Added an additional email address.

Changing the status to ineligible and closing this ticket - insufficient metadata and no response from authors.


RP-0 netkan not firing

the RP-0 netkan does not seem to be generating a .ckan. I released 0.44 last night, so a run should have occurred by now. Or is the netkan bot down?

Hmm, looks like the indexer indeed hasn't run in a couple days. I'll check it when I take my coffee break.
http://status.ksp-ckan.org

Thanks! :)

Looks like we're back rolling again. The indexer's cache partition filled up as a result from all the mods moving to spacedock.

Ah, that would explain it. Thanks, on behalf of all of us. :)

Np, a nice simple one :)


Fix minor typo

Fixes a minor typo of falsify.

Just touring the code base after watching the excellent recent talk from @rachitnigam. Noticed this tiny one and thought I would get my feet wet with the contribution flow :) Excited by the direction of filament and looking forward to contributing more!

Woo! All contributions welcome!! Let us know if you're trying to implement a design in Filament or want to hack on something that we can get you started!


Does this plugin support Ikea bulbs?

Since the new Ikea bulbs is compatible with the Hue-hub if they have been upgraded to the latest firmware, do you need to use this plugin or does it work out of the box?
https://developers.meethue.com/content/philips-hue-and-ikea-trådfri?page=2

With the new firmware, the IKEA bulbs pair with the Hue bridge and can be used by any Hue app.
As the Hue bridge only exposes Philips lights to HomeKit, you'll need homebridge-hue to expose the IKEA lights to HomeKit, just as for the Hue motion sensor or dimmer switch.

Is there a special trick for the Ikea lights? I tried it yesterday with no result.

What did you try?

Of course the firmware update :)
reset of the ikea bulb by power off and on 6 times
find bulb via hue app

The hue hub is ~5 meters away of the bulb
2017-08-13 9:33 GMT+02:00 Erik Baauw<EMAIL_ADDRESS>
What did you try?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/ebaauw/homebridge-hue/issues/147#issuecomment-322026948,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AOMDCw3wTIvAmzvtDtCMuHO9_SkqYcZUks5sXqbagaJpZM4OzN58
.

Did you double-check that the bulb reports firmware 1.2.21x?
I haven't actually yet tried it myself, but I read it can be done: https://developers.meethue.com/comment/3701#comment-3701.
You might need to touchlink the IKEA bulb with the Hue bridge, before the bridge finds the bulb.  Hold the powered-on bulb next to the Hue bridge and PUT {"touchlink": true} to /config through the Hue API, or, in Eve, use the Touchlink characteristic in bridge accessory provided by homebridge-hue.  Then, search for new lights from the Hue app as before.

I tested it today, and had no problem pairing the updated TRADFRI bulb E27 WS opal 980lm (v1.2.217) to my 2nd gen Hue bridge (v1707040932).  I didn't need to touchlink it or anything.
Note that you need to power cycle the bulb, after pressing Search in the Hue app.  I think this is needed for all lights, except for the Philips Hue lights.

I did some testing with the power cycle but no luck. How do I get to know the firmware? I do not own a IKEA hub :(

Op 14 aug. 2017 om 20:02 heeft Erik Baauw<EMAIL_ADDRESS>het volgende geschreven:
I tested it today, and had no problem pairing the updated TRADFRI bulb E27 WS opal 980lm (v1.2.217) to my 2nd gen Hue bridge (v1707040932). I didn't need to touchlink it or anything.
Note that you need to power cycle the bulb, after pressing Search in the Hue app. I think this is needed for all lights, except for the Philips Hue lights.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.

Then how did you upgrade the firmware?

I thought that you did the same as you never mentioned the hub. Now I see
that I made a wrong assumption ;)
2017-08-15 20:14 GMT+02:00 Erik Baauw<EMAIL_ADDRESS>
Then how did you upgrade the firmware?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/ebaauw/homebridge-hue/issues/147#issuecomment-322545436,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AOMDCzjubfgeNyd0CXQtqC92JD2UGUP4ks5sYeAUgaJpZM4OzN58
.

I never mentioned the IKEA hub, because I don't have one.  I updated the IKEA bulb firmware through deCONZ.


                                                 [DONE]
copying non-existen files...                                           [FAIL]

fix the first issue #3


Allow Action explain

“Allow – Authorizes the transaction, skipping all subsequent rules. This means that the specified request is added to the allow list and once matched, the request stops further evaluation and is sent to the backend pool. Rules that are on the allow list aren't evaluated for any further custom rules or managed rules.”
According to this, if I have a false positives on CRS and I’ll create a rule to allow request when certain regex is in the value of certain attribute on the JSON in the body in the request, then WAF stops checking such request using CRS (ie. for SQL injection in the header) and just passes it? This means custom rules aren’t really sufficient for preventing false positives on CRS rules?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 26c3e97e-759e-c50e-ce05-29dbd91830ab
Version Independent ID: 28f16dcd-4cef-366a-154e-b56f9c29b868
Content: Azure Web Application Firewall (WAF) custom rules
Content Source: articles/application-gateway/custom-waf-rules-overview.md
Service: application-gateway
GitHub Login: @vhorne
Microsoft Alias: victorh

@TomaszOledzki You should only make allow rules for things that you know will be ok to pass to the backend 100% of the time. Here is an example of a custom SQL rule.

@TravisCragg-MSFT Hey Travis with this new release I am not sure what has changed, anyway to know that? Also is it possible to change the PARANIOA LEVEL from default value of 4 to lets say 1? I understand that degrades security but is it possible somehow in Azure App Gate WAF to change the PARANIO LEVEL to 1 as I am not sure where the crf-setup.config exists and how we can change it? Any help on that?

@ketaanhshah What exactly are you referring to with the "PARANIO LEVEL"? Custom rules allow you to either Allow or Deny based upon the priority of the rule.

Thats correct the custom rules allow us but I was looking for an option where I can downgrade the PL from 4 to 1.  More details here on this thread:-
https://github.com/SpiderLabs/owasp-modsecurity-crs/issues/1449#issuecomment-501429738

@ketaanhshah I do not believe that you can change the default OWASP configuration, your best bet will be to make a custom rule.
I am following up now to get a definitive answer on if there is a way to change the Paranoia level, and will follow up here.

@TravisCragg-MSFT Thank you so much Travis that will be great as we have been struggling a lot to get out application go live on Azure just because of all the FALSE POSTIVES we getting and we really need this answer so in that case we will build the custom rules. One more question I had was..If we create a custom rule with lower number level for lets say allowing some SQLCI related warning we got from out of the box rule, in that case do we have to disable the out of the box BLOCK rule or that can remain enabled and our custom rule will superceed it and allow the request to pass thru?

@ketaanhshah You can disable most of the existing OWASP rules If you know which rule is giving you the issue.
If a custom rule is created and a request matches the custom rule, it will immediately be allowed or denied, and no further firewall checks will be made. If you have a custom allow rule, you will not need to disable a competing default rule.

@TravisCragg-MSFT you are wonderful sir, thank you so much again for super prompt response! Really apprecaite it a lot. I am fairly new to this and is there anyway you can guide me on how I can get some custom rules like REGEX rule, User agent string rule, etc.. for some of the following FP we getting?

Resource
ruleSetType_s
ruleSetVersion_s
ruleGroup_s
ruleId_s
action_s
site_s
details_message_s
details_data_s
details_file_s
details_line_s
hostname_s
Message
requestUri_s
count_

PROD2-APPGW
OWASP
3
942-APPLICATION-ATTACK-SQLI
942370
Matched
Global
Warning. Pattern match   "(?i:(?:["']\\s*?\\*.+(?:x?or|div|like|between|and|id)\\W*?[\"']\d)|(?:\^["'])|(?:^[\\w\\s\"'-]+(?<=and\s)(?<=or|xor|div|like|between|and\s)(?<=xor\s)(?<=nand\s)(?<=not\s)(?<=\|\|)(?<=\&\&)\w+\()|(?:["'`][\s\d]?[^\w\s]+\W?\d\   ..." at REQUEST_COOKIES:fs_uid.
Matched Data:<PHONE_NUMBER>414208:62 found within REQUEST_COOKIES:fs_uid:   rs.fullstory.comM4G4J`4703519480414208:6216073757261824
rules/REQUEST-942-APPLICATION-ATTACK-SQLI.conf
841

Detects classic SQL injection probings 2/2
/
1

PROD2-APPGW
OWASP
3
Default
0
Detected
Global
Warning. Operator GE matched 5 at   TX:anomaly_score.
rules/REQUEST-949-BLOCKING-EVALUATION.conf
57

Mandatory rule. Cannot be disabled. Inbound Anomaly Score Exceeded (Total   Score: 5)
/
14

PROD2-APPGW
OWASP
3
Default
0
Detected
Global
Warning. Operator GE matched 5 at   TX:inbound_anomaly_score.
rules/RESPONSE-980-CORRELATION.conf
73

Mandatory rule. Cannot be disabled. Inbound Anomaly Score Exceeded (Total   Inbound Score: 5 - SQLI=5,XSS=0,RFI=0,LFI=0,RCE=0,PHPI=0,HTTP=0,SESS=0):   Detects classic SQL injection probings 2/2
/
13

@TomaszOledzki You should only make allow rules for things that you know will be ok to pass to the backend 100% of the time. Here is an example of a custom SQL rule.

IMO omitting CRS on the first hit of custom rule is bad approach.

@TravisCragg-MSFT Thank you Travis, so one of our rules we wanted to write was for allowing the requests to go thru if the cookie contained "__RequestVerificationToken" and the value for this key in the cookie can contain "--" or some special characters and then it should be allowed to go thru. So if I had to create a custom rule for this, will something like this be correct? I am not sure how we evaluate both the Key and its value to contain "--" in this rule
`

`

@TravisCragg-MSFT @TomaszOledzki  and now with the new Custom rule I cant even associate the WAF policy with OLD Application Gateway created earlier in our environment V1 version, is this not allowed? I created a ticket/issue in for that:-
https://github.com/MicrosoftDocs/azure-docs/issues/33262#issue-455807476

@ketaanhshah I believe custom rules are supported on WAF v2 only. For WAF v1 you have to use "old" WAF exclusion lists: https://docs.microsoft.com/en-us/azure/application-gateway/application-gateway-waf-configuration#waf-exclusion-lists

@TomaszOledzki aah my God then it means we have to upgrade to V2 Gateway and use it as the exclusion list is not good enough of help here.

@TomaszOledzki I absolutely agree with you, the first hit is not enough reason to remove a rule.
@ketaanhshah Your best bet is to follow up with that ticket going forward

Thank you @ TomaszOledzki

@ketaanhshah If you would like to upgrade to a V2 Gateway, the process was recently released and you can find it here.

@TravisCragg-MSFT Thank you Travis this is exactly the place we used, and after doing this in our test/dev environment we re-read the warning logs and u wont blive you would ROFLOL what we found was the CRS issues/warnings were about a cookie and its value and all we needed was the exclusion rule! So we applied the exclusion rule and viola! even in V1 WAF we were able to do away all the warnings and anamolies we were getting! But in this process I learnt a lot and I really thank you for helping me throughout the way! I certainly can say now this is NEW Microsoft super prompt! super helpful!

@ketaanhshah Glad to hear that everything is resolved!

@TomaszOledzki is there anything else that I can assist you with regarding this issue?

@TomaszOledzki We will now proceed to close this thread. If there are further questions regarding this matter, please tag me in your reply. We will gladly continue the discussion and we will reopen the issue.


Make BoxDecoration replaceable.

Factor out a reusable interface called Decoration from BoxDecoration.
Make all the consumers of BoxDecoration and the erstwhile BoxPainter
into consumers of Decoration.
Make a BoxPainter be something you get from a Decoration, rather than
something to which you pass a BoxDecoration.
Rename Shape to BoxShape now that it's documented specifically as
applying to boxes.
Move EdgeDims to its own file.
Move FractionalOffset up so that it's with the other helper classes in
its file rather than alone at the end.
Minor change to RenderClipOval's hit testing to avoid taking an
unnecessary square root.
Rename BoxDecorationPosition to DecorationPosition since
RenderDecoratedBox now takes any Decoration.
Implement hit testing for rounded rects.
Rename AnimatedBoxDecorationValue to AnimatedDecorationValue, and make
it support lerping across any Decoration (by deferring to the objects
involved).

(This depends on the RRect changes to the engine that haven't been released yet.)

LGTM


feat(transformer/decorators): insert instanceBrand function

Current dependencies on/for this PR:

#2480  👈
main

This stack of pull requests is managed by Graphite.


Target framework dropdown is disabled with empty value after upgrade

Describe the bug
Upgrade assistant converted the project to SDK style (from .netframework 4.7.1) to netstandard2.0 but Target Framework drop down is disabled with empty in the properties window.
The project file

in properties window

To Reproduce

Exceptions (if any)

Further technical details

Windows version 10 (64-bit)
Include the output of dotnet --list-sdks

3.1.201 [C:\Program Files\dotnet\sdk]
5.0.202 [C:\Program Files\dotnet\sdk]
5.0.203 [C:\Program Files\dotnet\sdk]
5.0.300-preview.21180.15 [C:\Program Files\dotnet\sdk]
6.0.100-preview.3.21202.5 [C:\Program Files\dotnet\sdk]

Include the output of upgrade-assistant --version

0.2.227701+3e878899ae39105a278847a94a7c48f458cada83

Still having this issue. Is there a known work-around?

Please try latest Upgrade Assistant in Visual Studio or CLI, it was redesigned and now behaves differently.


fix: move menu reorg logic from crud app into Menu component

SUMMARY

Recently a PR was merged that reorganized some of the menu options into a settings dropdown. That logic was only applied to the crud react "app" https://github.com/preset-io/incubator-superset/blob/3e374dab076ae8baeab6148203ed1a74d1627a59/superset-frontend/src/views/App.tsx#L66
This PR moved that logic into the menu component so that all instances of the menu have the same reorg applied.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:

After:

TEST PLAN

👀  (this changes can be seen in sqllab, on master there's a Security and Manage dropdown, on this branch, those options live under the settings dropdown)

ADDITIONAL INFORMATION

[ ] Has associated issue:
[x] Changes UI
[ ] Requires DB Migration.
[ ] Confirm DB Migration upgrade and downgrade tested.
[ ] Introduces new feature or API
[ ] Removes existing feature or API

Codecov Report

Merging #10717 into master will decrease coverage by 4.66%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #10717      +/-   ##
==========================================
- Coverage   64.93%   60.27%   -4.67%
==========================================
  Files         789      360     -429
  Lines       37122    23222   -13900
  Branches     3555        0    -3555
==========================================
- Hits        24107    13996   -10111
+ Misses      12908     9226    -3682
+ Partials      107        0     -107

Flag
Coverage Δ

#cypress
?

#javascript
?

#python
60.27% <ø> (-0.04%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

superset/views/base_api.py
94.18% <0.00%> (-4.07%)
:arrow_down:

superset/db_engine_specs/postgres.py
97.43% <0.00%> (-2.57%)
:arrow_down:

superset-frontend/src/components/Select/index.ts

...hboard/components/gridComponents/new/NewColumn.jsx

superset-frontend/src/components/Pagination.tsx

.../src/explore/components/MetricDefinitionOption.jsx

...nd/src/views/CRUD/data/dataset/AddDatasetModal.tsx

superset-frontend/src/explore/reducers/index.js

.../src/dashboard/util/serializeActiveFilterValues.js

...t-frontend/src/dashboard/reducers/sliceEntities.js

... and 419 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e374da...2e8b64a. Read the comment docs.


add bdn comparisons for system-linq vs cistern

Besides adding more benchmarks, the core of this issue is done and merged now. This can probably be closed.


feat(pixels): add my new pixel

Checklist

[x] I ran npm test locally and it passed without errors.

[x] I only edited the _data/pixels.json file.

[x] I entered the username in the pixels.json that I'm also using to create this pull request.
[x] I acknowledge that all my contributions will be made under the project's license.

Known issue (#2046) encountered


feature support select tablets with nereids optimizer

Proposed changes
Issue Number: close #xxx

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall external

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 45.55 seconds
stream load tsv:          544 seconds loaded<PHONE_NUMBER>9 Bytes, about 131 MB/s
stream load json:         21 seconds loaded<PHONE_NUMBER> Bytes, about 107 MB/s
stream load orc:          66 seconds loaded<PHONE_NUMBER> Bytes, about 15 MB/s
stream load parquet:          31 seconds loaded 861443392 Bytes, about 26 MB/s
insert into select:          29.3 seconds inserted 10000000 Rows, about 341K ops/s
storage size:<PHONE_NUMBER>4 Bytes

run external

run p1


Not able to run the latest docker image

The new docker build has an error at runtime :
/app/flapi: error while loading shared libraries: libubsan.so.1: cannot open shared object file: No such file or directory
To reproduce the error :
docker run -it ghcr.io/datazoode/flapi:7bed7cfe7881bdc81a5a2051f6727d2b2c658b95 bash

Hey, unfortunately there seems still to be a glitch with the GH actions build:
latest != 7bed7cfe7881bdc81a5a2051f6727d2b2c658b95
So can you please use the image https://github.com/DataZooDE/flapi/pkgs/container/flapi/306431664?tag=latest for the moment. There I have fixed the missing GCC ubsan library already.

Works now


[FLINK-31706] [runtime] The default source parallelism should be the same as ex…

What is the purpose of the change
Currently, the sources need to set  execution.batch.adaptive.auto-parallelism.default-source-parallelism in the adaptive batch scheduler mode, otherwise, the source parallelism is only 1 by default. A better solution might be set as the default execution parallelism if no user configured.
Brief change log
Modified the default value of source-parallelism to be more reasonable.
Verifying this change
This change is already covered by existing tests, such as AdaptiveBatchSchedulerTest
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
The serializers: (no)
The runtime per-record code paths (performance sensitive): (no)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
The S3 file system connector: (no)

Documentation

Does this pull request introduce a new feature? (no)

can you spare some precious time to review? Thanks very much @Myasuka

@clownxc Thanks for creating this pr! I'm curious why you don't fallback the value of globalDefaultSourceParallelism to parallelism.default if necessary outside the constructor of DefaultVertexParallelismAndInputInfosDecider? This change will be much cleaner.
In addition, we do not require that parallelism.default must be a positive number. On the contrary, before version 1.17, users need to configure parallelism.default = -1 to enable concurrency derivation. WDYT?

@clownxc Thanks for creating this pr! I'm curious why you don't fallback the value of globalDefaultSourceParallelism to parallelism.default if necessary outside the constructor of DefaultVertexParallelismAndInputInfosDecider? This change will be much cleaner. In addition, we do not require that parallelism.default must be a positive number. On the contrary, before version 1.17, users need to configure parallelism.default = -1 to enable parallelism derivation. WDYT?
Thank you, I will try to modify the code as you say

@clownxc I've left some comments, PTAL!

Thank you very much for your review, I have modified the code, can you re-review the code when you are free, and make some comments.

@clownxc Please move to the original ticket. Any changes to break the previous behavior needs a discussion in the JIRA, that's why we did not assign anyone to take the ticket.
BTW, we think this change should be reasonable indeed, but a discussion is necessary.


Feature: Add a reference list of what variables to use to specify format

Currently, there is no reference list or document that list the variables that we can use to specify the format. I also google search and here in Github and can't find it. Can you add a reference list in the settings of what variables you can use? Thanks.

Hi, thanks for using this plugin!
What do you mean about the variables that you can use to specify the format? Do you mean how to change the attachment format for different types of attachments? If it is, I update the readme and the description in the setting. If it's something else, could you please explain it a little bit more?


Add User-Agent to SDK calls

In order for us to track cliv2 usage, we should include a unique user agent in our AWS SDK calls. One example of how to do that is here

copy/paste https://github.com/aws/amazon-ecs-cli/blob/master/ecs-cli/modules/clients/user_agent.go


[10.x] Fix docblock for Filesystem::hash()

Since the hash_file() function also returns false, Filesystem::hash() should also return false.

10.x isn't maintained any longer

Oops, I will create a PR for 11.x.


Proposal for a visual debug mode

Description
This likely borders on something that could be achieved with a package, but integrating it into the compiler might also make sense, depending on the scope. So I'm proposing the idea here.
When setting layouts, it is often difficult to determine where a particular (possibly unwanted) spacing comes from or what the dimensions/indents etc. of a single element are. Of course, you can use fills and strokes to some degree, but this is often burdensome or doesn't show the whole picture in an easy-to-overview manner.
Similar to the inspector in HTML/CSS environments or tools like geometry/showframe or lua-visual-debug in the LaTeX universe, a debug mode would be very useful.
This mode could show, for example:

Outlines of blocks and page parts without affecting the layout
Dimensions and x/y position of blocks and boxes without affecting content or layout
Spacings and paddings for each element
Whitespace, line and page breaks
Baselines and lines per element
Broken characters

Use Case
This approach would make debugging more intuitive, significantly reducing support requests and enhancing ease of use.
Rudimentary examples (not showing many possible features mentioned above):

Image Source: https://tex.stackexchange.com/questions/2083/how-can-i-visualize-boxes

I agree that something like this would be nice, though I'm leaning towards integrating it into tooling (web app / editor extensions) rather than the compiler. It's just much nicer to expose something like this in an interactive way.


Correct wrong CDN

The repo for CodeMirror is subject to potential changes, and codemirror.js disappeared. This PR fix it, by using a CDN for every CodeMirror stuff needed by markdownify.

Genius


Pre-training model not found.

Your work is excellent, and I am very interested in your work. I didn't find the model file [https://github.com/TomTomTommi/BiDAStereo/releases/tag/v0.0] when running your code. Can you update it?

Updated.