Notifications with same content

NOTE: Please test in a least two browsers (i.e. Chrome and Firefox). This
helps with diagnosing problems quicker.

Please confirm the following:

[x] I have read the README entirely
[x] I have verified in the issues that my problem hasn't already been resolved

Setup

Please provide the following details, the more info you can provide the
better.

Operating System: < Windows>
PHP Version: <5.6>
web-push-php Version: <1.0.0>

Please check that you have installed and enabled these PHP extensions :

[x] gmp
[x] mbstring
[x] curl
[x] openssl

Please select any browsers that you are experiencing problems with:

[ ] Chrome
[ ] Firefox
[ ] Firefox for Mobile
[ ] Opera for Android
[ ] Samsung Internet Browser
[ ] Other

Please specify the versions (i.e. Chrome Beta, Firefox Beta etc).

Problem

Please explain what behaviour you are seeing.

Here is the thing. I am sending a notification while having opened both Firefox and Chrome. It appears at the same time on both browsers correctly. So, i closed chrome and then i send more than one notifications of different content and then open it again and getting the latest notification showing up as many time as i pushed it on Firefox. What am i missing here?
Expected

Please explain what you expected to happen

Expected to see all my notifications that i pushed correctly. Instead i saw the last one duplicated...
Features Used

[x] VAPID Support
[ ] GCM API Key
[ ] Sending with Payload

Example / Reproduce Case

Please provide a code sample that reproduces the issue. If there is a
repository that reproduces the issue please put the link here.

My send.php
require('includes/app.inc.php');
use Minishlink\WebPush\WebPush;
$auth = array(
'VAPID' => array(
"subject" => "",
"publicKey" => "*****",
"privateKey" => ""
),
);
$method = $_SERVER['REQUEST_METHOD'];
$webPush = new WebPush($auth);
$push_query = mysqli_query("select * from ps");
while($push = mysqli_fetch_array($push_query)){
$res = $webPush->sendNotification(
$push['endpoint'],
'',
$push['key'],
$push['token'],
true
);
}
My service-worker.js
self.addEventListener('push', function(event) {
"use strict";
if (!(self.Notification && self.Notification.permission === 'granted')) {
return;
}
if (event.data) {
	const pushPromise = fetch('push-data.php')
		.then(function(response) {
			if (response.status !== 200) {
				console.log('Server code: ' + response.status);
			}

			return response.json().then(function(data) {

				var notificationData = {
					body: data.body,
					icon: data.icon,
					image: data.image,
					badge: data.badge
				};
				return self.registration.showNotification(data.title, notificationData);
			});
		});
	event.waitUntil(pushPromise);
}

});
Other

Please put any remaining notes here.

Found another approach and here it is just in case somebody needs it.
My send.php
$res = $webPush->sendNotification(
$push['user_endpoint'],
'{"title":"My title", "msg":"My message", "url":"https://www.google.com", "icon":"icon.png", "badge":"img/icon.png"}',
$push['user_key'],
$push['user_token'],
true
);
My service-worker.js
self.addEventListener('push', function (event) {
"use strict";
if (!(self.Notification && self.Notification.permission === 'granted')) {
return;
}
var mydata = event.data.json();
const sendNotification = body => {
    // you could refresh a notification badge here with postMessage API
	var notificationData = {
		body: mydata.msg,
		icon: mydata.icon,
		image: mydata.image,
		badge: mydata.badge
	};
	self.notificationURL = mydata.url;

    return self.registration.showNotification(mydata.title, notificationData);
};

if (event.data) {
    const message = event.data.text();
    event.waitUntil(sendNotification(message));
}

});
self.addEventListener('notificationclick', function(event) {
console.log('[Service Worker] Notification click Received.');
event.notification.close();
event.waitUntil(
clients.openWindow(self.notificationURL)
);

});


Permission from users to log usage

We need to make sure we ask permission from users the first time they start Elegit if it's ok to log usage data, and if not ok, to not do it. A popup when they start Elegit the first time would do it; store it in a user preference.
Secondarily, we should have a preferences screen where they can change this option. We'll undoubtedly have other preferences to add later.

Eric suggests for now putting it in the menus, perhaps.

Push to master, then make new builds so we can get people testing.

Permissions added, built, and released.


Change __callapi function

Most calls are POST requests, so add that branch of logic to function,
make default to it doesn’t need to be specified in functions.
Every function stub SHOULD be a POST request, but verify. For easier
coding, I added a debug argument to the Class constructor, which will
print out the body of the function (which should match what the API
explorer expects)

Ok, that's the last commit I'm going to make (for a few days at least). In theory, all the functions with rsid_list as the single keyword parameter and docstrings should work; I stopped testing after the first half-dozen or so.
So if you're good with this code, you can merge it in, then continue on with what you were doing. There should hopefully be enough examples here and working code for you to make some progress on the other functions outlined. I purposely have ignored the Queue* functions at this point, as they are a bit more complicated.

Hi Randy,
Thanks for all of this! It's really useful to look through. I'll start
looking at the functions. As for the Get/Post request, I always do Get
requests and it handles just fine, I assume post is a better protocol to
use. I'll start trying to find functions not here that are in RSiteCatalyst
and do my best.
Best,
Andy
On Wed, Mar 30, 2016 at 4:21 PM, Randy Zwitch<EMAIL_ADDRESS>wrote:

Ok, that's the last commit I'm going to make (for a few days at least). In
theory, all the functions with rsid_list as the single keyword parameter
and docstrings should work; I stopped testing after the first
half-dozen or so.
So if you're good with this code, you can merge it in, then continue on
with what you were doing. There should hopefully be enough examples here
and working code for you to make some progress on the other functions
outlined. I purposely have ignored the Queue* functions at this point, as
they are a bit more complicated.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
https://github.com/andymaheshw/AdobeAnalytics/pull/2#issuecomment-203615574

If a request has no arguments (such as GetReportSuites), then GET or POST will work. However, once  you get complex requests such as the Queue functions which can take dozens of arguments and hundreds of parameters, I think you have to use POST.
One more thing...for the functions I did, I didn't build the functionality for passing a string literal instead of a list; you might want to build that. For example:
GetElements(["zwitchdev"]) - works
GetElements("zwitchdev") - doesn't work
The solution is just to check the type of rsid_list on input, and if it is a string, then copy the string into a 1-length list.
Good luck, let me know how it goes!


When I  try to export to Windows from Linux breaks because missing files

The report:
core/os/dir_access.cpp:288 - Failed to open res://addons/qodot/bin/win64/libmap.dll
editor/project_export.cpp:977 - Failed to export the project for platform 'Windows Desktop'.
core/os/dir_access.cpp:288 - Failed to open res://addons/qodot/bin/win64/libqodot.dll
editor/project_export.cpp:977 - Failed to export the project for platform 'Windows Desktop'.

This is already documented at https://github.com/Shfty/qodot-plugin/wiki/9.-Project-Export
TL;DR you can safely exclude the parts of Qodot that throw these errors via the project export settings, provided that you're not using it to load maps at runtime. Otherwise, you'll need to download and ship the windows libs with your project.


External processor changes to the :path header are ignored by the router

Title: External processor changes to the :path are ignored by the router
Description:
When the external processor alternate the :path header, the router ignore the new path and
route the request as if it was never altered.
Repro steps:

Setup envoy with at least 2 cluster (clusterA and clusterB) and an external processor.
Configure and starts the external processor to alter requests path.

Before alteration, the request path should match clusterA match rules
After alteration, the request path match clusterB match rules

The request is routed to clusterA instead of clusterB

I have made a repo containing an environment to reproduce the bug: https://github.com/negrel/envoy-issue-ext-proc-go
Config:
admin:
  access_log_path: /dev/null
  address:
    socket_address:
      address: <IP_ADDRESS>
      port_value: 11001

node:
  cluster: service_greeter
  id: test-id

static_resources:
  listeners:
    - name: listener_0
      address:
        socket_address:
          address: <IP_ADDRESS>
          port_value: 10001
      filter_chains:
        - filters:
            - name: envoy.filters.network.http_connection_manager
              typed_config:
                "@type": type.googleapis.com/envoy.extensions.filters.network.http_connection_manager.v3.HttpConnectionManager
                stat_prefix: ingress_http
                codec_type: AUTO
                route_config:
                  name: local_route
                  virtual_hosts:
                    - name: local_service
                      domains: ["*"]
                      routes:
                        - match:
                            prefix: "/httpbin"
                          route:
                            prefix_rewrite: "/get"
                            cluster: httpbin
                        - match:
                            prefix: "/httpgo"
                          route:
                            prefix_rewrite: "/get"
                            cluster: httpbingo
                http_filters:
                  - name: envoy.filters.http.ext_proc
                    typed_config:
                      "@type": type.googleapis.com/envoy.extensions.filters.http.ext_proc.v3alpha.ExternalProcessor
                      failure_mode_allow: false
                      async_mode: false
                      processing_mode:
                        request_header_mode: "SEND"
                        response_header_mode: "SKIP"
                        request_body_mode: "NONE"
                        response_body_mode: "NONE"
                        request_trailer_mode: "SKIP"
                        response_trailer_mode: "SKIP"
                      grpc_service:
                        envoy_grpc:
                          cluster_name: ext_proc_cluster
                  - name: envoy.filters.http.router
  clusters:
    - name: httpbin
      connect_timeout: 2s
      type: LOGICAL_DNS
      dns_lookup_family: V4_ONLY
      lb_policy: ROUND_ROBIN
      load_assignment:
        cluster_name: httpbin
        endpoints:
          - lb_endpoints:
              - endpoint:
                  address:
                    socket_address:
                      address: httpbin.org
                      port_value: 443
      transport_socket:
        name: envoy.transport_sockets.tls
        typed_config:
          "@type": type.googleapis.com/envoy.extensions.transport_sockets.tls.v3.UpstreamTlsContext
    - name: httpbingo
      connect_timeout: 2s
      type: LOGICAL_DNS
      dns_lookup_family: V4_ONLY
      lb_policy: ROUND_ROBIN
      load_assignment:
        cluster_name: mockbin
        endpoints:
          - lb_endpoints:
              - endpoint:
                  address:
                    socket_address:
                      address: httpbingo.org
                      port_value: 80
    - name: ext_proc_cluster
      type: STATIC
      connect_timeout: 0.25s
      http2_protocol_options: {}
      load_assignment:
        cluster_name: ext_proc_cluster
        endpoints:
          - lb_endpoints:
              - endpoint:
                  address:
                    socket_address:
                      address: <IP_ADDRESS>
                      port_value: 18080

I think this is a cache issue from the router. The following patch fix the issue even though I should check if the path haven't been altered before clearing the cache.
Should I make a PR ?
diff --git a/source/extensions/filters/http/ext_proc/processor_state.cc b/source/extensions/filters/http/ext_proc/processor_state.cc
index afa1293e0..6994da83d 100644
--- a/source/extensions/filters/http/ext_proc/processor_state.cc
+++ b/source/extensions/filters/http/ext_proc/processor_state.cc
@@ -24,6 +24,10 @@ bool ProcessorState::handleHeadersResponse(const HeadersResponse& response) {
     headers_ = nullptr;
     callback_state_ = CallbackState::Idle;
     message_timer_->disableTimer();
+
+    filter_callbacks_->clearRouteCache();
+    ENVOY_LOG(debug, "route cache cleared");
+
     continueProcessing();
     return true;
   }

I think you need to set https://github.com/envoyproxy/envoy/blob/6834081f835d609606e77ef84d734e30fc403d58/api/envoy/service/ext_proc/v3alpha/external_processor.proto#L270 in the response to clear the route cache if path is modified.
CC @gbrail


Update flate2

This updates flate2 to version 1.0.11 which:

Updates to a new version of miniz_oxide with important safety fixes. It is 100% safe code now and forbids unsafe code.
Makes calls to miniz_oxide no longer go through the C API layer, which has soundness issues in the version currently used by reqwest
Drops most of the unsafe code from flate2 itself when used with Rust backend

I am aware that crate consumers normally use the latest available versions of dependencies. This change is meant to prohibit use of earlier versions due to soundness issues.

Thanks, but we now use async-compression instead of flate2 directly.


Is it possible to 'filter' the contents of the Fast Group Muter/Bypasser other than 'color'?

I discovered you could use the property panel to only show groups of a certain color - which is awesome.
But I'm wondering :
a) could you select a specific hexadecimal color? I tried but it didn't work.
b) could you use a regexp to EXCLUDE certain group names or color? Again here no dice, maybe it expects a certain notation.
BTW - amazing nodes.

Color I think uses comfy’s built-in group color names. The hexadecimal change depending on the theme and title/content of the group, etc; so that feels less stable, but maybe I can take another look.

Thank you so much! yes indeed a bit of an edge case as the 10 or so color provided 'should' be enoug but never understimate the insanity of 1,000 nodes worfklows ;)
No sweat, i fully undertand that regexp might be the better choice here. I think the docs could benefit from an example though because I'm unsure about what 'flavor' comfy expects (regarding delimiters, etc). Cheers!


Ensure config defaulting for ilab model evaluate works in all scenarios

When a user specifies a model, uses a flag as an override, etc  ensure via manual checking and new config tests that ilab model evaluate handles all default and non-default scenarios properly.
relates to #1369

@cdoern is this done?


Add license boilerplates; Remove some unused imports

Yeah, not that I know better, but looks fine to me (:


SITL gazebo with IRIS broken

The simulation in gazebo seems broken on master.
Steps to reproduce:
make posix gazebo

Then try to takeoff using:
pxh> commander takeoff

Bisect points to 010c9e937b23988b222de6a1f714b57690f7742f

This is odd, how did the SITL CI pass?

This works fine for me, I use gazebo 6.5.1.

It seems to be only my my Ubuntu 16.04 with gazebo7. Mac with gazebo7 is ok.

Works fine on Mac here as well after all clean actions (make and git). I'm on stack_abstraction which is a branch addressing a few OS-specific stack size issues. It might be worthwhile for you to try as well.

Did a fresh checkout of Firmware and all is good again :confused:.

The file Tools/sitl_gazebo/models/iris/iris.sdf was not re-generated/updated.
The following resolved the problem:
cd Tools/sitl_gazebo
git clean -d -f -x

@julianoes Try make distclean next time. I use it when jumping between branches with big changes, especially when submodules have been added/deleted/url changed.

This should be fixed by https://github.com/PX4/sitl_gazebo/pull/57, see https://github.com/PX4/sitl_gazebo/pull/57/commits/d9b9f5b96012bc90be2ceb05483788f6ae62dabd.


feat: Remove kubelet configuration from the v1 API

Fixes #N/A
Description

Remove the kubelet configuration field and validation

How was this change tested?

make presubmit

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.5%) to 78.853%

Totals

Change from base Build<PHONE_NUMBER>:
0.5%

Covered Lines:
8647

Relevant Lines:
10966

💛  - Coveralls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 0   changed or added relevant lines in 0 files are covered.
6 unchanged lines in 3 files lost coverage.
Overall coverage increased (+0.5%) to 78.853%

Files with Coverage Reduction
New Missed Lines
%

pkg/controllers/disruption/drift.go
2
89.09%

pkg/apis/v1/nodepool.go
2
75.95%

pkg/apis/v1beta1/nodepool.go
2
95.24%

Totals

Change from base Build<PHONE_NUMBER>:
0.5%

Covered Lines:
8647

Relevant Lines:
10966

💛  - Coveralls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 0   changed or added relevant lines in 0 files are covered.
4 unchanged lines in 2 files lost coverage.
Overall coverage increased (+0.5%) to 78.835%

Files with Coverage Reduction
New Missed Lines
%

pkg/test/expectations/expectations.go
2
93.69%

pkg/controllers/node/termination/controller.go
2
59.81%

Totals

Change from base Build<PHONE_NUMBER>:
0.5%

Covered Lines:
8645

Relevant Lines:
10966

💛  - Coveralls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 0   changed or added relevant lines in 0 files are covered.
2 unchanged lines in 1 file lost coverage.
Overall coverage increased (+0.5%) to 78.853%

Files with Coverage Reduction
New Missed Lines
%

pkg/controllers/node/termination/controller.go
2
59.81%

Totals

Change from base Build<PHONE_NUMBER>:
0.5%

Covered Lines:
8647

Relevant Lines:
10966

💛  - Coveralls

/unhold


Documentation: Drafting documentation for the Authentication code

Fleshing out the comment blocks so Jazzy can populate the documentation

You can generate the docs locally by running:
Scripts/build_api_docs.sh AzureCommunication


ec pk_encrypt data failed

I wanna use ec to encrypt and decrypt data like below, the key prase is right,but encrypt data is error.
./pk_encrypt ecpub.pem hello

  . Seeding the random number generator...
  . Reading public key from 'ecpub.pem'
  . Generating the encrypted value failed
  ! mbedtls_pk_encrypt returned -0x3f00
  !  Last error was: PK - Type mismatch, eg attempt to encrypt with an ECDSA key

so,did I do something wrong?I use this pk_encrypt by rsa like below is ok.
 ./pk_encrypt rsa_public_key_2048.pem helloworld
  . Seeding the random number generator...
  . Reading public key from 'rsa_public_key_2048.pem'
  . Generating the encrypted value
  . Done (created "result-enc.txt")

./pk_decrypt rsa_private_key_2048.pem
  . Seeding the random number generator...
  . Reading private key from 'rsa_private_key_2048.pem'
  . Decrypting the encrypted data
  . OK

The decrypted result is: 'helloworld'

I wonder ,whether something is wrong in ec?

@sbutcher-arm hi，could you help me about this？

Hi @linbeithree ,
as menitoned in the forum and in #851 , mbed TLS does not support ECC cipher schemes, as it is not a requirement by TLS protocol.
I am marking this issue as enhancement

Hi, @RonEld ,
Thanks for your feedback,I will use ECC for sign and verify,maybe it will support cipher schemes.

I found there is a function named "psa_asymmetric_encrypt/decrypt". Is it usable for ECC encryption/decryption? No example here.

psa_asymmetric_{encrypt,decrypt} only supports RSA-PKCS1v15 and RSA-OAEP. It does not support any ECC-based encryption method.
You can implement ECIES on top of ECDH, which is implemented in mbedtls_ecdh_xxx and psa_raw_key_agreement.


cabana: colorful logs based on activity

based on #26970
move relative code into util.cc/h to reuse them it in logview. @pd0wm any comment? is this OK for you?
Kazam_screencast_00050.webm

Looks good! I'll submit a PR for the colorful bits background once this is merged.


Update AnimatedChevronDownSmallVisualSource with updated design

New drop down chevron design is more responsive and has animations in multiple segments.

/azp run


Provision to customize kube-apiserver of Gardener shoot

Kubernetes provides various options in kube-apiserver .
I want to add additional options to customize my shoot's  kube-apiserver rather than using shipped in kube-apiserver options of shoot which gets created using shoot's yaml (other than configurable option such as featureGates, runtimeConfig and auditConfig).
Is there any way to customize and add options in kube-apiserver of shoot or a way to utilize "additionalParameters: []" defined over here

We don’t allow that on purpose to keep up Gardener‘s SLOs.
Gardener is a managed Kubernetes service and as such dictates what can be configured and what not. We won’t make such general configurability available, sorry.


Rules for construction of provider

If DDS.new produces IIIF3, it needs to construct a provider instead of separate logo etc.
https://iiif.io/api/presentation/3.0/#provider

What does this look like when it's just Wellcome?
What does this look like for archive content from other repositories?

Discussed - to be dealt with when we get to it. Here's an example from the spec, for reference. We'd change the homepage and logo to wellcomecollection:
{
  "provider": [
    {
      "id": "https://example.org/about",
      "type": "Agent",
      "label": { "en": [ "Example Organization" ] },
      "homepage": [
        {
          "id": "https://example.org/",
          "type": "Text",
          "label": { "en": [ "Example Organization Homepage" ] },
          "format": "text/html"
        }
      ],
      "logo": [
        {
          "id": "https://example.org/images/logo.png",
          "type": "Image",
          "format": "image/png",
          "height": 100,
          "width": 120
        }
      ]
    }
  ]
}

And the reason for this:
https://iiif.io/api/presentation/3.0/change-log/#1212-wrap-logo-in-a-structure-with-more-information-introduce-provider-property

Everything about Wellcome that the PDF CoverPage requires must be returned in the provider (e.g. address)

Example of Wellcome and partner provider:
https://iiif-test.wellcomecollection.org/dash/Peek/IIIF/b24967646
How to manage this info?
In old DDS, partner logos live in a folder on a shared internal network drive.
Unlike poster images, I don't think it makes sense for them to go in the storage service - they are presentation furniture, not preservation assets.
How about they live here, in GitHub:
https://github.com/wellcomecollection/iiif-builder/tree/master/src/Wellcome.Dds/Wellcome.Dds.Server/wwwroot/partners
And you can make changes/updates with simple PRs, here:
https://github.com/wellcomecollection/iiif-builder/blob/master/src/Wellcome.Dds/Wellcome.Dds.Repositories/Presentation/PartnerAgents.cs#L10
I think this is one for @chenshaw and @aray-wellcome

Hi Tom,
Whatever makes most sense – is there other presentation furniture stored on Github? E.g. if we have a default image to display for audio files or something along those lines.
Christy
From: Tom Crane<EMAIL_ADDRESS>Sent: 10 September 2020 10:58
To: wellcomecollection/platform<EMAIL_ADDRESS>Cc: Christy Henshaw<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [wellcomecollection/platform] Rules for construction of provider (#4472)
Example of Wellcome and partner provider:
https://iiif-test.wellcomecollection.org/dash/Peek/IIIF/b24967646https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fiiif-test.wellcomecollection.org%2Fdash%2FPeek%2FIIIF%2Fb24967646&data=02|01|C.Henshaw%40wellcome.org|a6c750bdac484bddf9f008d855700a49|3b7a675a1fc84983a100cc52b7647737|0|0|637353286980403131&sdata=u2Km1OeGPEVWQA4dReQYalsGjsscWxY0N4rc2iLmv2s%3D&reserved=0
How to manage this info?
In old DDS, partner logos live in a folder on a shared internal network drive.
Unlike poster images, I don't think it makes sense for them to go in the storage service - they are presentation furniture, not preservation assets.
How about they live here, in GitHub:
https://github.com/wellcomecollection/iiif-builder/tree/master/src/Wellcome.Dds/Wellcome.Dds.Server/wwwroot/partnershttps://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fwellcomecollection%2Fiiif-builder%2Ftree%2Fmaster%2Fsrc%2FWellcome.Dds%2FWellcome.Dds.Server%2Fwwwroot%2Fpartners&data=02|01|C.Henshaw%40wellcome.org|a6c750bdac484bddf9f008d855700a49|3b7a675a1fc84983a100cc52b7647737|0|0|637353286980403131&sdata=9kz68vP%2BI6zTpw1YSxfJ6KBModDdec%2BExoui8P%2FYDIA%3D&reserved=0
And you can make changes/updates with simple PRs, here:
https://github.com/wellcomecollection/iiif-builder/blob/master/src/Wellcome.Dds/Wellcome.Dds.Repositories/Presentation/PartnerAgents.cs#L10https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fwellcomecollection%2Fiiif-builder%2Fblob%2Fmaster%2Fsrc%2FWellcome.Dds%2FWellcome.Dds.Repositories%2FPresentation%2FPartnerAgents.cs%23L10&data=02|01|C.Henshaw%40wellcome.org|a6c750bdac484bddf9f008d855700a49|3b7a675a1fc84983a100cc52b7647737|0|0|637353286980413125&sdata=J65xxdXDNpZ7vVNuWxkC7yeXRF3eZ%2BoY%2F9boIkDh6no%3D&reserved=0
I think this is one for @Chenshawhttps://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FChenshaw&data=02|01|C.Henshaw%40wellcome.org|a6c750bdac484bddf9f008d855700a49|3b7a675a1fc84983a100cc52b7647737|0|0|637353286980413125&sdata=r2Xcc5oMvVqhdtzDQrcZBpvkRk%2BlOQ4lwL8NauJnV94%3D&reserved=0 and @aray-wellcomehttps://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Faray-wellcome&data=02|01|C.Henshaw%40wellcome.org|a6c750bdac484bddf9f008d855700a49|3b7a675a1fc84983a100cc52b7647737|0|0|637353286980423119&sdata=0sQxBs4fJYlrQH996Mhl1DhBYPrm7MzXcRqm%2BeWpBb8%3D&reserved=0
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fwellcomecollection%2Fplatform%2Fissues%2F4472%23issuecomment-690125685&data=02|01|C.Henshaw%40wellcome.org|a6c750bdac484bddf9f008d855700a49|3b7a675a1fc84983a100cc52b7647737|0|0|637353286980423119&sdata=egLNi4eVQBviOUxV5Zyw950fTp0bGWvpYl9bRx3UbRE%3D&reserved=0, or unsubscribehttps://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAAGOZHCIRI7DKORU42MVZ5DSFCPLPANCNFSM4M2HUXLA&data=02|01|C.Henshaw%40wellcome.org|a6c750bdac484bddf9f008d855700a49|3b7a675a1fc84983a100cc52b7647737|0|0|637353286980433114&sdata=2GKQdaLw2AYIzCzLj9bBMju3CcseyUJyTEPsHOpSMkY%3D&reserved=0.

Goof point - yeah, the audio and video placeholders, and the Wellcomecollection logo(s), can all be served along with the partner logos as static assets from the same webapp that serves the IIIF Presentation API. They then live in the iiif-builder GitHub repo and are easy to update.

Christy was quick! Yes, I think it's fine to have our preservation "furniture" and placeholders living in Github too. I can leave a note in our team's documentation about where it is as well and having someone on the Preservation team do a PR for us if we need to change or add a new one.

One last thing - the labels and homepage URLs here - I made a best attempt at what these should be (we only had the logo before). So they need checking!
https://github.com/wellcomecollection/iiif-builder/blob/master/src/Wellcome.Dds/Wellcome.Dds.Repositories/Presentation/PartnerAgents.cs#L10

Those URLs look good to me! They make sense.

I've hoovered up the logos from the shared drive and put them here:
https://github.com/wellcomecollection/iiif-builder/tree/master/src/Wellcome.Dds/Wellcome.Dds.Server/wwwroot/partners
Also the two Wellcome logos here:
https://github.com/wellcomecollection/iiif-builder/tree/master/src/Wellcome.Dds/Wellcome.Dds.Server/wwwroot/logos
If @jtweed is happy with the way these provider elements look then this issue could be closed.
This one has two providers, Wellcome and Glasgow University:
https://iiif-test.wellcomecollection.org/dash/Peek/IIIF/b24967646

Thanks @tomcrane - looks good to me with one caveat. @jennpb is currently working on a new section page for the collections and we should probably use the URL for that when it’s available, which it’s not yet but should be before this work is finished.

Yep, it's easy to change - I just put these in as best-guess placeholders.
One related thing - in the old manifests there's no provider - that's a IIIF3 thing. In old manifests we convey the info in a free text metadata field, that a viewer will just display. The new provider gives publishers the opportunity to say a lot more about themselves formally in the manifest, by adding what they want to an Agent type (many people wanted this).
If the material is from a third party, in the old version we have a free text metadata field that includes the partner logo, and text that says:

This material has been provided by [blah] where the originals may be consulted.

In the new version, I've just included two providers; Wellcome first, then the third party (I can swap the order). I haven't put that old text in yet.
Just having the two providers isn't explictly saying "if you want to look at this for real, come to Euston Rd", or "DON'T come to Euston Rd, it's actually in Glasgow - pop over the road to the station and see you later". Obviously the works page on wc.org can interpret the presence of two providers like this, and maybe that's fine for now - need to see what viewers (Mirador, UV etc) do with it.

I added the above text to the requiredStatement property.
https://iiif.io/api/presentation/3.0/#requiredstatement
A couple of examples:
b24967646 (from Glasgow)
  "rights": "https://creativecommons.org/publicdomain/mark/1.0/",
  "requiredStatement": {
    "label": { "en": [ "Attribution and usage" ] },
    "value": {
      "en": [
        "This material has been provided by The University of Glasgow Library where the originals may be consulted.",
        "This work has been identified as being free of known restrictions under copyright law, including all related and neighbouring rights and is being made available under the Creative Commons, Public Domain Mark.

You can copy, modify, distribute and perform the work, even for commercial purposes, without asking permission."
      ]
    }
  },

b18031511_0003
  "rights": "https://creativecommons.org/licenses/by-nc/4.0/",
  "requiredStatement": {
    "label": { "en": [ "Attribution and usage" ] },
    "value": {
      "en": [
        "Wellcome Collection",
        "You have permission to make copies of this work under a Creative Commons, Attribution, Non-commercial license.

Non-commercial use includes private study, academic research, teaching, and other activities that are not primarily intended for, or directed towards, commercial advantage or private monetary compensation. See the Legal Code for further information.

Image source should be attributed as specified in the full catalogue record. If no source is given the image should be attributed to Wellcome Library."
      ]
    }
  },

See https://github.com/wellcomecollection/iiif-builder/blob/master/docs/Altering-IIIF.md
Text and logos are now reasonably straightforward to change.


Building source code occured errors!!

Describe the bug
I tried to build the openpilot according https://github.com/commaai/openpilot/blob/master/tools/README.md. But some errors occured when i executed the command scons -u -j$(nproc) .
more information as follows:
/usr/bin/ld: tools/replay/libqt_replay.a(consoleui.o): undefined reference to symbol 'keypad' /usr/bin/ld: /home/wx/anaconda3/lib/./libtinfow.so.6: error adding symbols: DSO missing from command line clang: error: linker command failed with exit code 1 (use -v to see invocation) scons: *** [tools/replay/replay] Error 1 scons: building terminated because of errors.
OS Version
Ubuntu 20.04 LTS
openpilot version or commit
No response
Additional info
No response

Make sure that you have installed libncurses5-dev and libncursesw5-dev \ correctly and the tinfo is included in pkg config:

@: ncursesw5-config --libs
-Wl,-Bsymbolic-functions -lncursesw -ltinfo

Make sure that you have installed libncurses5-dev and libncursesw5-dev \ correctly and the tinfo is included in pkg config:

@: ncursesw5-config --libs
-Wl,-Bsymbolic-functions -lncursesw -ltinfo

Thank you, i have installed libncurses5-dev and libncursesw5-dev. I execute command ncursesw5-config --libs and the terminal can show me the same infomations:-Wl,-Bsymbolic-functions -lncursesw -ltinfo`. But i still can't build the op successfully.


Unpublished page causes a Gatsby build error

This sounds extremely similar to issue #8, however we can see explicit error messaging.
We are using Agility CMS, with Gatsby v2.32, gatsby-source-agilitycms v1.6.6, deploying with Gatsby Cloud to Netlify. We have set up the site according to Agility Gatsby CMS Starter instructions. I realize these are not the latest versions, but looking at the changelogs I can't see that this should be a reason for this error.
There is an unpublished page in Agility. The Gatsby Cloud build fails completely suring Building static HTML for pages because of a null reference to data.agilitypage within the data coming into the master page template (AgilityPage.js).
Why is gatsby-source-agilitycms sourcing unpublished pages from Agility? How can this be avoided?

Unpublished pages should NOT be coming through with your production mode builds.  The first thing I would check is that you aren't sourcing content in preview mode (ie: make sure you're using the Fetch API Key and AGILITY_API_ISPREVIEW=false).
I would get that setup locally and test with gatsby clean,  gatsby build, gatsby serve

ah thanks for the quick response - to be clear, this is in the preview mode. It's the CMS Preview build that fails and brings down the CMS Preview site.
In local development, the build starts up fine, and the site works normally other than when visiting the unpublished page route where it throws an error.

If you can show us the error you're getting the CMS Preview on Gatsby Cloud it might help.  @joshua-isaac  - tagging you on this in case you recognize anything.

Sure thing, here's a dump of the build log.
`15:32:10 PM:
Node version v12.22.1
15:32:11 PM:
Gatsby version Gatsby CLI version: 2.19.0
15:32:11 PM:
Gatsby version: 2.32.0
15:32:11 PM:
Note: this is the Gatsby version for the site at: /usr/src/app/www
15:32:11 PM:
INCREMENTAL_PREVIEWS
15:32:11 PM:
Setting gatsby to /usr/src/app/www/node_modules/gatsby
15:32:12 PM:
info Running Inc Build CLI v0.7.0
15:32:13 PM:
verbose 2.024097738 making initial clean build
15:32:14 PM:
success open and validate gatsby-configs - 0.046s
15:32:14 PM:
success load plugins - 0.365s
15:32:14 PM:
success onPreInit - 0.026s
15:32:14 PM:
success delete html and css files from previous builds - 0.044s
15:32:14 PM:
success initialize cache - 0.005s
15:32:14 PM:
success copy gatsby files - 0.061s
15:32:14 PM:
success onPreBootstrap - 0.020s
15:32:14 PM:
success createSchemaCustomization - 0.005s
15:32:14 PM:
AgilityCMS => Source Nodes Started (production)...
15:32:15 PM:
AgilityCMS => Starting Sync for en-ca - preview mode.
15:32:15 PM:
AgilityCMS => Touched 19854 nodes
15:32:15 PM:
AgilityCMS => Content Sync returned no item(s).
15:32:15 PM:
AgilityCMS => Page Sync returned 1 item(s).
15:32:15 PM:
AgilityCMS => Updating Sitemap channel corporatev2 in en-ca
15:32:15 PM:
AgilityCMS => Completed Sync for en-ca - preview mode.
15:32:15 PM:
AgilityCMS => Starting Sync for fr-ca - preview mode.
15:32:15 PM:
AgilityCMS => Content Sync returned 3 item(s).
15:32:15 PM:
AgilityCMS => Page Sync returned 1 item(s).
15:32:15 PM:
AgilityCMS => Updating Sitemap channel corporatev2 in fr-ca
15:32:16 PM:
AgilityCMS => Completed Sync for fr-ca - preview mode.
15:32:16 PM:
AgilityCMS => Creating sitemap nodes...
15:32:16 PM:
AgilityCMS => Source Nodes Completed.
15:32:16 PM:
verbose 4.290453347 Deleted 0 pages
15:32:16 PM:
verbose 4.289885141 Checking for deleted pages
15:32:16 PM:
verbose 4.290565156 Found 0 changed pages
15:32:16 PM:
success Checking for changed pages - 0.001s
15:32:16 PM:
success source and transform nodes - 1.441s
15:32:21 PM:
success building schema - 4.971s
15:32:21 PM:
AgilityCMS => Create Pages Started...
15:32:21 PM:
AgilityCMS => Homepage requests to /en-ca/Home will redirect to '/en-ca/'
15:32:21 PM:
AgilityCMS => Root requests to '/' will redirect to the default language path '/en-ca/'
15:32:21 PM:
AgilityCMS => 220 pages created from corporatev2 in en-ca
15:32:21 PM:
AgilityCMS => Homepage requests to /fr-ca/accueil will redirect to '/fr-ca/'
15:32:21 PM:
AgilityCMS => 207 pages created from corporatev2 in fr-ca
15:32:21 PM:
info Total nodes: 20754, SitePage nodes: 856 (use --verbose for breakdown)
15:32:21 PM:
success createPages - 0.405s
15:32:21 PM:
verbose 9.669752432 Checking for deleted pages
15:32:21 PM:
verbose 9.670631727 Found 855 changed pages
15:32:21 PM:
verbose 9.670067701 Deleted 0 pages
15:32:21 PM:
success Checking for changed pages - 0.001s
15:32:21 PM:
success createPagesStatefully - 0.054s
15:32:21 PM:
success Cleaning up stale page-data - 0.036s
15:32:21 PM:
success update schema - 0.310s
15:32:21 PM:
success onPreExtractQueries - 0.000s
15:32:22 PM:
success extract queries from components - 0.650s
15:32:22 PM:
success write out redirect data - 0.003s
15:32:22 PM:
info bootstrap finished - 10.732s
15:32:22 PM:
success onPostBootstrap - 0.001s
15:32:22 PM:
success run static queries - 0.125s - 2/2 15.95/s
15:32:24 PM:
success run page queries - 2.015s - 430/430 213.40/s
15:32:24 PM:
success write out requires - 0.022s
15:32:32 PM:
success Building production JavaScript and CSS bundles - 7.788s
15:32:32 PM:
success Rewriting compilation hashes - 0.008s
15:32:36 PM:
success Building HTML renderer - 2.824s
15:32:37 PM:
failed Building static HTML for pages - 1.207s
15:32:37 PM:
ERROR Building static HTML failed for path "/en-ca/pa-toolkit"
15:32:37 PM:
13 |
15:32:37 PM:
12 |   })
15:32:37 PM:

14 |   const page = JSON.parse(data.agilitypage.pageJson)

15:32:37 PM:
17 |     //replace the title with the title of the post
15:32:37 PM:
|                                            ^
15:32:37 PM:
16 |   if (dynamicPageItem) {
15:32:37 PM:
15 |
15:32:37 PM:
15:32:37 PM:
src/agility/utils.js:14:44
15:32:37 PM:
WebpackError: TypeError: Cannot read property 'pageJson' of null
15:32:37 PM:
15:32:37 PM:

utils.js:14

15:32:37 PM:

AgilityPage.js:187

15:32:37 PM:
src/AgilityPage.js:187:34
15:32:37 PM:
15:32:37 PM:
15:32:37 PM:
15:32:38 PM:
ERROR Failed to compile: Error: Exited with code 1`

Thanks! No doubt that's a bug - @joshua-isaac  can you take a look?  We may have fixed this already in V3, but it's worth a look to see if we need to patch that.

hello @steveshaddick, thanks for reporting this!
after testing on our end we can confirm this is a bug, i've created an internal ticket to get this fixed.
unfortunately, the only workaround as of now would be to delete the unpublished page :(
i can follow up with you as soon as this issue gets resolved.

thanks very much @joshua-isaac , I'll see about deleting the page. I'm sure you don't have a clear idea exactly when the bug might be resolved, but might it be within a week or two, or should we expect longer than that?

hi @steveshaddick, just wanted to follow up.
we've identified the root cause of the issue here and should have someone working on the ticket to resolve the problem next week.
again, will follow up with you :)
thanks!

thanks @joshua-isaac - I have a followup, actually, that may or may not be related. If it is not related, I can make a new issue thread.
In the preview site, we have a blog index page that shows recent blog articles. Its data source is from the graphql query allAgilityComponentBlogPost. On the preview site, this data seems to include posts that are deleted and sitting in the Recycle Bin. Meaning, on the preview site, deleted posts are appearing in the blog index page list.
Is this the same issue?


FileManager: Implement contentsEqual(atPath:andPath:)

Requires some more tests, especially for comparing directories.

@swift-ci please test

@swift-ci please test

@swift-ci please test

@swift-ci please test

I added some extra tests for deep subdirectories to check the recursion. It exposed a bug in copyItem(atPath:toPath:) (#1515) which will need to be merged before this and also I came across a bug in fileExists(atPath:isDirectory) (#1514)  which should also go in .

Great, thanks @spevans!

@swift-ci please test


Allow releases to appear on GitHub summary page

I currently have no way of keeping track of new releases when they are published.
Publishing the releases on GitHub would allow me to do so.
Any alternative that would provide an RSS feed would be fine with me.

Releases already published on GitHub https://github.com/svsool/vscode-memo/releases.

Ah, sorry for the noise. I must have been confused... too many opened tabs, maybe.

Actually I was convinced you didn't publish the releases on GitHub because they do not appear on the right side of the suppary page of the repo:

I've never seen that.

Interesting 🤔, I wonder why they are not shown.

Figured it out, it should be included now. 👍

Nice, thanks !


Merge debugger feature to master branch

Codecov Report

Merging #695 into master will decrease coverage by 0.03%.
The diff coverage is 3.31%.

@@            Coverage Diff            @@
##           master    #695      +/-   ##
=========================================
- Coverage    3.54%    3.5%   -0.04%
=========================================
  Files         384     421      +37
  Lines       13951   15124    +1173
=========================================
+ Hits          494     530      +36
- Misses      13457   14594    +1137

Impacted Files
Coverage Δ

...sion/GoogleCloudExtension/Utils/ProtectedAction.cs
0% <ø> (ø)
:arrow_up:

...ion/PublishDialogSteps/GceStep/GceStepContent.xaml
0% <ø> (ø)
:arrow_up:

...Extension.PowerShellUtils/RemotePowerShellUtils.cs
0% <0%> (ø)

...ogleCloudExtension.PowerShellUtils/RemoteTarget.cs
0% <0%> (ø)

...ion/GoogleCloudExtension/CloudExplorer/TreeNode.cs
0% <0%> (ø)
:arrow_up:

...xtension/AttachDebuggerDialog/HelpStepViewModel.cs
0% <0%> (ø)

...n/CloudExplorerSources/Gce/GceInstanceViewModel.cs
0% <0%> (ø)
:arrow_up:

...erDialog/InstallStartRemoteToolStepContent.xaml.cs
0% <0%> (ø)

...uggerDialog/InstallStartRemoteToolStepViewModel.cs
0% <0%> (ø)

...udExtension.PowerShellUtils/RemoteToolInstaller.cs
0% <0%> (ø)

... and 77 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 69dde76...65635af. Read the comment docs.

Is there anything in particular that we should be looking at? Is this just a merge, were there any particular areas of hard conflict that we should be looking at again?
If it is a clean (ish) merge then there's not much for us to look at.

Just merge.  I looked , there is no conflict.


npm start causing "npm WARN cannot run in wd"

I tried this and it didn't work.

npm start --unsafe-perm

I keep getting this error.

bower ESUDO         Cannot be run with sudo
You can however run a command with sudo using --allow-root option
npm ERR! weird error 1
npm ERR! not ok code 0
npm ERR! weird error 1
npm ERR! not ok code 0

Without --unsafe-perm I keep getting this error instead:

npm WARN cannot run in wd<EMAIL_ADDRESS>bower install (wd=/usr/share/nginx/angular-seed)

i saw the same error, but seems the website start and is running well.

0
On Sep 6, 2015 8:54 PM, "Bill W"<EMAIL_ADDRESS>wrote:

i saw the same error, but seems the website start and is running well.
—
Reply to this email directly or view it on GitHub
https://github.com/angular/angular-seed/issues/291#issuecomment-138154332
.

May be the same resolve as this issue:  https://github.com/angular/angular-seed/issues/227
Install bower separately with npm per final comment.

Closing as this is about a more general problem - not directly related to angular-seed itself.


CentOS 7: Unable to start Onivim 2

Some information from Discord thread:
Running with the -f and --checkhealth options produces the following output:
/tmp/.mount_OnivimyqQcEG/usr/bin/Oni2: /lib64/libstdc++.so.6: version CXXABI_1.3.8' not found (required by /tmp/.mount_OnivimyqQcEG/usr/lib/libmirclient.so.9)
/tmp/.mount_OnivimyqQcEG/usr/bin/Oni2: /lib64/libstdc++.so.6: versionCXXABI_1.3.9' not found (required by /tmp/.mount_OnivimyqQcEG/usr/lib/libmirclient.so.9)
/tmp/.mount_OnivimyqQcEG/usr/bin/Oni2: /lib64/libstdc++.so.6: version GLIBCXX_3.4.21' not found (required by /tmp/.mount_OnivimyqQcEG/usr/lib/libmirclient.so.9)
/tmp/.mount_OnivimyqQcEG/usr/bin/Oni2: /lib64/libstdc++.so.6: versionGLIBCXX_3.4.20' not found (required by /tmp/.mount_OnivimyqQcEG/usr/lib/libmircommon.so.7)
/tmp/.mount_OnivimyqQcEG/usr/bin/Oni2: /lib64/libstdc++.so.6: version CXXABI_1.3.9' not found (required by /tmp/.mount_OnivimyqQcEG/usr/lib/libmircommon.so.7)
/tmp/.mount_OnivimyqQcEG/usr/bin/Oni2: /lib64/libstdc++.so.6: versionGLIBCXX_3.4.21' not found (required by /tmp/.mount_OnivimyqQcEG/usr/lib/libmircommon.so.7)
Plus more lines that are very similar. I can't paste all of them as I exceed the message size limit.

It looks like that CentOS 7 bundles GCC 4.8, but some of the dependencies bundled by the AppImage kit require libstdc++ 6 >= 5.2. For example, libmirclient9 seems to require libstdc++6 >= 5.2: https://packages.ubuntu.com/xenial/libmirclient9
Checking distrowatch - it seems that Ubuntu / Arch / Mint / Manjaro all ship with newer versions of GCC, which is why we haven't hit this issue before.
I saw some similiar issues with other AppImages:

https://github.com/shadowsocks/shadowsocks-qt5/issues/534
https://github.com/shadowsocks/shadowsocks-qt5/issues/687

And there's a section in the AppImage docs about potentially handling this:
https://github.com/AppImage/AppImageKit/wiki/Creating-AppImages#libstdcso6

As a band aid, the user could try installing Developer Toolset 6-8, so as to get a more recent GCC version. Not a proper solution of course.

@adrian5 Good idea. Unfortunately, at least for Developer Toolset 7, the result is the same. I was the one that found this issue and had tried using the Developer Toolset then. That information didn't make it into the bug report though.

Saw a report that a user on RHEL 7.2 hit this as well (which also bundles GCC 4.8.x)
There are two potential solutions I see:

Investigate if we can down-grade our Azure CI Ubuntu machines to use GCC 4.8.x (or use another CI provider / distro that uses an GCC 4.8.x) - and release builds from there
Incorporate the custom AppRun solution here: https://github.com/AppImage/AppImageKit/wiki/Creating-AppImages#libstdcso6

Maybe it's worth checking how other projects do it? For example, the latest KDevelop appimage (see https://www.kdevelop.org/download) works just fine on CentOS 7.

Actually, I just checked and it looks like they are using a CentOS 6.10 docker image to build the appimage file.

Thanks @t-wiser !
Yeah, I think our main problem is that the Azure CI is limited to the Ubuntu 16.04 image. I just opened a PR to see if I could down-grade GCC there: https://github.com/onivim/oni2/pull/783
Otherwise, we could look at building on a VM or dockerfile to use either CentOS 6 or RHEL 7

FYI, with #784 , the builds we are producing for Linux are now built on CentOS 7 - which means we should have better compatibility.
@CrossR mentioned that the builds now work for him on CentOS 7 🎉

I have finally gotten around to verifying that this works for me as well on CentOS 7. This issue could probably be closed now, no?

Thanks for the confirmation @t-wiser ! Closing 👍


typescript find the maximum sum of a contiguous subarray (circular)

📑 Description
typescript file to  find the maximum sum of a contiguous subarray (circular).
🐞 Related Issue

Closes #4562
📋 Explanation of changes
add typescript file to  find the maximum sum of a contiguous subarray (circular).

📑 Description
typescript file to find the maximum sum of a contiguous subarray (circular).
🐞 Related Issue
Closes #4562
📋 Explanation of changes
add typescript file to find the maximum sum of a contiguous subarray (circular).

Dear @shokerm the provided issue-id doesn't look correct.
Please Correct the Issue-Id:- Closes #4562


make window movable while app boots

you can't drag the app around while it's in this initial state:

Same applies for window in "unexpected issue" state.

This has be fixed for the intro screen by applying -webkit-app-region: drag;
(However the window will only became draggable after restarting the app, refreshing doesn't help)


About training with NeRF-DS dataset

When I was training on the  NeRF-DS cup_ Novel_ view, the PSNR at 11000 iteration is about 30, but at 12000 iteration, the PSNR mutates to 5 and the loss soars to 0.49 and remains unchanged

Generally, this is a problem of excessively high learning rates. I solved this issue in my implementation by using an exponentially decaying learning rate through the Deformation Field.

可以提供一下训练的参数么，我也遇到了这样的问题

hi @changyq12, u can use the latest code for stable training.


feat(phones): Export PhoneFieldFlag component

PhoneFieldFlag is going to be used in the CountrySelect component as well

@Diyorbek I think PhoneFieldFlag  is not ready to be exposed yet. If you only need a flag component - it's better just to copy implementation or you can introduce new Flag component in @superdispatch/ui and replace PhoneFieldFlag with it.


Adding detail of how to check the OS/kernel version

Insert the command to check the version of OS and kernel
in order to get more detail in ISSUE_TEMPLATE.
Signed-off-by: Nguyen Hai Truong<EMAIL_ADDRESS>

Looks good. Thanks!


Add exclusive mode to an NPC

Introduces exclusive-mode (opposite functionality, basically), wherein an NPC can be created and is hidden from Players by default. Players will then need to be explicitly included to be seen, vs managing an "all-but-one" exclusion list.
This works in my local testing, though the verbage and naming of things is a bit hard to understand. I tried to keep with the API concepts so as not to break anything.
It seemed wise to make an NPC immutably exclusive since, once you choose to do exclusive, you have to use the opposite calls for checking visibility, but if you wish to make exclusive a mutable concept on an NPC, go for it.

I just looked over the PR an it looks a little bit weird to me. First of all there are now 2 sets which are used instead of one. That makes no sense as your code always checks and writes only against one of the sets. The other is redundant and can be removed - this might require some other changes. I think it might be a good thing if you can specify a predicate which decides wether a player should be included (or excluded based on the mode) instead of letting the user always call one of the methods instead (but it might be stuff we can introduce in another PR). On the other hand this change makes it more difficult for developers to work with npcs, especially if they dont know if a npc is exclusive or not - there should be one shared method which either in- or excludes the player.
Overall a good impression tho.

I believe I may've added the second list mostly to not break API as one list would've involved creating a lot of strangely "inverse" method calls. All for a different idea on how this should work, but mostly just wanted to take a stab at it.
I agree for simplicity it should be one list/calls, but wasn't quite yet willing to rewrite most of the logic to support it. Feel free to close if you'd like to tackle this with a different methodology.

@Cryptite I'm closing this for v2 now. In v3 I added the possibility to define a tracking rule which allows you to define (per npc) which players should get tracked. The api still has the possibility to force track a player, if you only want to track players added by the api.
I hope that resolves this pull request and the general issue you had in v2.


Get-Command -Syntax should work with aliases

Steps to reproduce
Get-Command -Syntax del

Expected behavior
del [-Path] <string[]> [-Filter <string>] [-Include <string[]>] [-Exclude <string[]>] [-Recurse] [-Force] [-Crede
ntial <pscredential>] [-WhatIf] [-Confirm] [-UseTransaction] [-Stream <string[]>] [<CommonParameters>]

del -LiteralPath <string[]> [-Filter <string>] [-Include <string[]>] [-Exclude <string[]>] [-Recurse] [-Force] [-
Credential <pscredential>] [-WhatIf] [-Confirm] [-UseTransaction] [-Stream <string[]>] [<CommonParameters>]

Actual behavior
Remove-Item

I just came here to log this. The existing behavior is most unhelpful.
One thought I have that differs from the above however is in the case of Get-Command -Syntax $someAliasName, I was thinking I'd prefer it show the actual alias mapping, followed by the syntax for the alias, especially since aliases shouldn't be used in scripts. The thinking behind this is that 100% of the time when I would use gcm del -syntax (or any alias in place of del), I'd be using the alias to save typing, as a shorthand to get the actual syntax for the command that will be invoked, and less as a command I actually want to invoke. So my expected behavior would look more like this:
del -> Remove-Item

del [-Path] <string[]> [-Filter <string>] [-Include <string[]>] [-Exclude <string[]>] [-Recurse] [-Force] [-Crede
ntial <pscredential>] [-WhatIf] [-Confirm] [-UseTransaction] [-Stream <string[]>] [<CommonParameters>]

del -LiteralPath <string[]> [-Filter <string>] [-Include <string[]>] [-Exclude <string[]>] [-Recurse] [-Force] [-
Credential <pscredential>] [-WhatIf] [-Confirm] [-UseTransaction] [-Stream <string[]>] [<CommonParameters>]

Or maybe the output should actually state "NOTE: del is an alias for the Remove-Item command", at the top or bottom of the output.

@Steve_MSFT potentially a solid hackathon/up-for-grabs issue?

@TylerLeonhardt A great Hacktoberfest issue.

Sounds like an interesting challenge so I'll give it a shot

This can be closed @iSazonov / @ChrisLGardner :-)


functions to add an alias domain for a tenant

Often when I am doing some type of multi-tenant I have the problem in regards two or three different domains needs to be able to access the same tenant, so What I try to do is create some functions to add that functionality to your current project

In the next major version (2.0.0), the domain property will be changed into an array -- domains; see #12.
Aliases could work as a temporary solution for 1.x, but it would be more complex than this PR's implementation.
Could you tell me more about the use case of multiple domains for a single tenant?
Thanks.

One use-case for multiple domains per tenant is when you allow them to bring their own domain name to your service.
So, considering you offer a SaaS platform at www.stancl-saas.com and I register as a tenant,
initial onboarding would give me a subdomain on your platform: drbyte.stancl-saas.com
but then when ready to go live I could point my DNS for: drbyte.com to your server,
which internally would treat it as an alias to the drbyte.stancl-saas.com tenant.
This would let me do plenty of testing and demo activity before committing past a trial or upgrading to a higher plan etc.

I see, thanks @drbyte. Okay, I'll make some changes to this PR and merge. I'll include the alias solution in 1.5.0 and the domains array solution in 2.0.0.

Actually, changing the interface is a breaking change. I just realized that as I was implementing a similar solution to this PR.
Therefore, this feature is coming in 2.0.0.
@clizaola If you really need this feature right now, you can copy RedisStorageDriver and add the alias method to it. If you add it to the StorageDriver interface as well, that change will result in conflicts when this package receives a minor update and you run composer update. I don't think you need to add it to the interface, though. You're getting an instance of RedisStorageDriver from the service container, so the worst case scenario should be that your IDE will shout at you.

Copy that @stancl, keep up the good work, I will be watching closely all the progress in this package! Thanks


What properties are searched?

The page states "The search filter is a free text search that uses multiple properties when retrieving the search results." but does not specify which properties are used.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 5159efcf-058c-7bf8-3bd4-a680224b72b6
Version Independent ID: f94e77f3-c166-cc46-de80-b4ca5e8e2803
Content: Search for sites - Microsoft Graph v1.0
Content Source: api-reference/v1.0/api/site-search.md
Product: sharepoint
Technology: microsoft-graph
GitHub Login: @JeremyKelley
Microsoft Alias: MSGraphDocsVteam

As part of a repository clean up effort we are closing older issues. If this issue remains, please: open a new issue, reference this issue, and provide any additional details that may help in resolution. Thank you for your understanding as we work to improve our responsiveness.


fix starter to support spring.datasource.type configuration

see #3392
this PR refers to #4642

Codecov Report

Merging #5612 (9bdd652) into master (4e6fc39) will decrease coverage by 0.02%.
The diff coverage is n/a.

Additional details and impacted files

@@             Coverage Diff              @@
##             master    #5612      +/-   ##
============================================
- Coverage     58.71%   58.70%   -0.02%
- Complexity    27675    27702      +27
============================================
  Files          1323     1331       +8
  Lines        127262   127409     +147
  Branches      23957    23973      +16
============================================
+ Hits          74728    74796      +68
- Misses        43254    43315      +61
- Partials       9280     9298      +18

Files
Coverage Δ

...t3/autoconfigure/DruidDataSourceAutoConfigure.java
100.00% <ø> (ø)

...ot/autoconfigure/DruidDataSourceAutoConfigure.java
100.00% <ø> (ø)

... and 12 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e6fc39...9bdd652. Read the comment docs.


Add weekly PyPI stats to daily report

Adds the PyPI stats to the daily report, which it pulls from Google's BigQuery.  Passed the pytest cases locally.
I'll work on have this auto-push commits to the bundle next.

I tried to avoid the same issue of "can't use secrets" this time, so I'm hoping it doesn't fail in the CI here (at least not for that reason).

Passed the other run of pytest so this new one should too since it's just logging changes!


Bug: group id is not right in the splitk dequant gemm kernel

In the splitk dequant gemm kernel, the group id is computed as below:
g_id = k // (groupsize // (block_k*split_k))

It is not right if we have block_k*split_k > groupsize, which will limit the size of block_k and split_k.
Instead, assume that groupsize is a multiple of block_k, group id should be computed as below:
g_id = (k * split_k + pid_k) // (groupsize // block_k)

where k * split_k + pid_k is the block id, and groupsize // block_k is the number of blocks in one group.

Great catch!
In the SplitK kernel, the block accesses will alternate and hence the pid_k is needed in the numerator to ensure proper mapping to g_id. Placement of split_k should also be in the numerator and not in the denominator as you've pointed out.
Feedback on the Triton kernels is appreciated, thanks for the contribution!


Error "Illegal value for token color" in notebook editor and interactive window

Bug: Notebook Editor, Interactive Window, Editor cells
Steps to cause the bug to occur

Ctrl+Shit+P  and select "Python: Create new Jupyter Notebook"

Actual behavior

Expected behavior
An empty code cell to start writing code. Also when opening existing jupyter notebooks, this covers the first code cell, making it inaccessible to edit/run.
Your Jupyter and/or Python environment

Jupyter server running: Local
Extension version: v2020.8.94248-dev
VS Code version: 1.47.1
Setting python.jediEnabled: No setting found
Setting python.languageServer: Jedi
Python and/or Anaconda version: 3.7.7
OS: Windows 10 Education
Virtual environment: conda

Developer Tools Console Output
[Embedded Page] Error: Illegal value for token color: webviewElement.ts:160
workbench.desktop.main.js:sourcemap:3864 [Embedded Page] Could not create web worker(s). Falling back to loading web worker code in main thread, which might cause UI freezes. Please see https://github.com/Microsoft/monaco-editor#faq
workbench.desktop.main.js:sourcemap:3864 [Embedded Page] Failed to construct 'Worker': Script at 'vscode-webview-resource://db7bd419-27be-44a4-8901-86c7131f1d93/file///c%3A/Users/mquiroga/AppData/Local/Temp/editor.worker.js' cannot be accessed from origin 'vscode-webview://db7bd419-27be-44a4-8901-86c7131f1d93'.
workbench.desktop.main.js:sourcemap:266 [Extension Host] Starting WebSocket: RAW/api/kernels/40a52acf-d368-4063-8315-41101374e147
workbench.desktop.main.js:sourcemap:266 [Extension Host] Kernel: connected (40a52acf-d368-4063-8315-41101374e147)
workbench.desktop.main.js:sourcemap:3864 [Embedded Page] Uncaught Error: Illegal value for token color:
Error: Illegal value for token color:
at e.getId (vscode-webview-resource://db7bd419-27be-44a4-8901-86c7131f1d93/file///c%3A/Users/mquiroga/.vscode/extensions/ms-python.python-2020.8.94248-dev/out/datascience-ui/notebook/monaco.bundle.js:1:465553)
at jo (vscode-webview-resource://db7bd419-27be-44a4-8901-86c7131f1d93/file///c%3A/Users/mquiroga/.vscode/extensions/ms-python.python-2020.8.94248-dev/out/datascience-ui/notebook/monaco.bundle.js:1:465290)
at Function.e.createFromParsedTokenTheme (vscode-webview-resource://db7bd419-27be-44a4-8901-86c7131f1d93/file///c%3A/Users/mquiroga/.vscode/extensions/ms-python.python-2020.8.94248-dev/out/datascience-ui/notebook/monaco.bundle.js:1:466485)
at Function.e.createFromRawTokenTheme (vscode-webview-resource://db7bd419-27be-44a4-8901-86c7131f1d93/file///c%3A/Users/mquiroga/.vscode/extensions/ms-python.python-2020.8.94248-dev/out/datascience-ui/notebook/monaco.bundle.js:1:465959)
at e.get [as tokenTheme] (vscode-webview-resource://db7bd419-27be-44a4-8901-86c7131f1d93/file///c%3A/Users/mquiroga/.vscode/extensions/ms-python.python-2020.8.94248-dev/out/datascience-ui/notebook/monaco.bundle.js:1:475626)
at e._toBinaryTokens (vscode-webview-resource://db7bd419-27be-44a4-8901-86c7131f1d93/file///c%3A/Users/mquiroga/.vscode/extensions/ms-python.python-2020.8.94248-dev/out/datascience-ui/notebook/monaco.bundle.js:1:538237)
at e.tokenize2 (vscode-webview-resource://db7bd419-27be-44a4-8901-86c7131f1d93/file///c%3A/Users/mquiroga/.vscode/extensions/ms-python.python-2020.8.94248-dev/out/datascience-ui/notebook/monaco.bundle.js:1:538548)
at Pe (vscode-webview-resource://db7bd419-27be-44a4-8901-86c7131f1d93/file///c%3A/Users/mquiroga/.vscode/extensions/ms-python.python-2020.8.94248-dev/out/datascience-ui/notebook/monaco.bundle.js:1:2444923)
at t._updateTokensUntilLine (vscode-webview-resource://db7bd419-27be-44a4-8901-86c7131f1d93/file///c%3A/Users/mquiroga/.vscode/extensions/ms-python.python-2020.8.94248-dev/out/datascience-ui/notebook/monaco.bundle.js:1:2443836)
at t._tokenizeOneInvalidLine (vscode-webview-resource://db7bd419-27be-44a4-8901-86c7131f1d93/file///c%3A/Users/mquiroga/.vscode/extensions/ms-python.python-2020.8.94248-dev/out/datascience-ui/notebook/monaco.bundle.js:1:2443483)
workbench.desktop.main.js:sourcemap:3864 [Embedded Page] Starting WebSocket: BOGUS_PVSC/api/kernels/40a52acf-d368-4063-8315-41101374e147
workbench.desktop.main.js:sourcemap:3864 [Embedded Page] Kernel: connected (40a52acf-d368-4063-8315-41101374e147)
workbench.desktop.main.js:sourcemap:266 [Extension Host] Starting WebSocket: RAW/api/kernels/0c760cfd-8a68-4ecb-b069-2d8a6ad7a410
workbench.desktop.main.js:sourcemap:266 [Extension Host] Kernel: connected (0c760cfd-8a68-4ecb-b069-2d8a6ad7a410)
Microsoft Data Science for VS Code Engineering Team: @rchiodo, @IanMatthewHuff, @DavidKutu, @DonJayamanne, @greazer, @joyceerhl

Had the same problem when using the below theme:
https://marketplace.visualstudio.com/items?itemName=konstantin.plain
Switching to a different theme solved the issue.
Switching, and then switching back to the problem theme, as mentioned by @mariadelmarq, did not help in my case.

Had the same issue, Bio syntax was the default theme, uninstalling Bio syntax and relaunching the software resolved that. thanks. But I need the Bio syntax theme as well.  How do I keep that plugin on and avoid this bug?

For notebooks, you could switch to VS code insiders. In insiders we're using a different editor which support all themes.
For the interactive window, there's no workaround. We just don't support that theme at the moment.

Thanks for your feedback. This issue will be addressed once VS Code adds native support for editing notebooks. Please see https://github.com/microsoft/vscode/issues/91987. You can experiment by using VS Code insiders, which defaults to the new notebook experience.


Fix flaky unit test

The ordering of YAML lists is not well defined and so this passed
tests locally and in CI by chance. Even trying to repeat the
flakiness failed at first because I was hitting the testing cache.
Removing the 2nd end var does little to limit the value of the test
and we also have functional tests (e2e integration tests) which
will hit this flow.
Signed-off-by: John Schnake<EMAIL_ADDRESS>

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@8f123df). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #679   +/-   ##
=========================================
  Coverage          ?   32.65%
=========================================
  Files             ?       60
  Lines             ?     3316
  Branches          ?        0
=========================================
  Hits              ?     1083
  Misses            ?     2140
  Partials          ?       93

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f123df...b409475. Read the comment docs.

Fixed a test that I saw fail on master (which passed on branch). Merging without review to get green and move forward with other merges/dev.


FF ONLY Towards 0.6.20.

Refer to this link for build results (access rights to CI server needed):
https://scala-webapps.epfl.ch/jenkins/job/scalajs-pr/4157/
https://scala-webapps.epfl.ch/jenkins/job/scalajs-matrix-build/5538/
Test PASSed.


[2.0] add nightwatch global with devServer's defined URL:Port (fix #241)

Fix for #241
This adds the devServer URL als a global and uses the port defined in /config/index.js for the URL
in the demo spec file, this global is used as the target url for the test instead of hardcoding http//localhost:8080

Is it possible in this version to specify a port via env variable?

As described, it uses the port from the config file, not from ENV

Wouldn't being able to specify the port from env be desirable? The use case is being able to easily run tests in a different port than the one used for dev, without having to mess a lot with the configuration. This would allow you to run the dev server at the same time as the tests for example.

This is a nice idea, but was not what I understood as the requested functionality from your issue #241 .
Can you open a new issue for this? As the e2e tests use the dev server as well, we will have to change server.js to support both at the same time with different ports.

The code I referenced #241 supports both dev config and env variables: https://github.com/vuejs-templates/webpack/blob/1.0/template/build/dev-server.js#L11
Has this been removed in more recent versions? I didn't fully understand what is the relationship of the branch dist with 1.0 and 2.0.

No, this still exists in the 2.0 branch (which is identical to the 1.0 branch except for changes nessessary to make it work with 2.0, which are very few).
The point is, it has to be added to the changes in nightwatch.conf.js of this PR as well. Can do that right now I guess.

Done

Great, thanks! 👍

LGTM!


Simplify Request#set_defaults

Removing the need for in if/else and uses the getter/setter methods
instead of the instance variables

Can you resolve the merge conflict?

@PericlesTheo thanks for your work! :)


Plugin not working

Whenever someone calls me the ringtone is not working it only worked the first time I enabled the plugin but any calls after that it didn't affect it.

Do you use the plugin NotificationSounds?
SecretRingTone and NotificationsSounds don’t work well together.

Oops… accidentally closed.

it isn't still working and i don't have notification sounds plugin
it still plays the normal sound


External course links are busted in navdiagram

I think these probably never worked but as it stands the link in themeA to a course in themeB is material/themeA/themeB/course rather than material/themeB/course

closed as completed via #125


Inconsist behavior for MqttApplicationMessageInterceptorContext.SessionItems with server

Describe the feature request
When do permission check with ApplicationMessageInterceptor, I found it also handle publish from server. But I didn't find an way to set MqttApplicationMessageInterceptorContext.SessionItems in that context, and found some other strange behavior.
Which project is your feature request related to?

Server

Additional context
https://github.com/chkr1011/MQTTnet/blob/master/Source/MQTTnet/Server/MqttClientSessionsManager.cs#L439

Unlike SessionItems for client, which can be set during ConnectionValidator, seems there is no way to init _serverSessionItems for server, which is only used by InterceptApplicationMessageAsync;

for ApplicationMessageInterceptor: sessionItems=_serverSessionItems for server, and senderConnection.Session.Items(never null) for client;
for UndeliveredMessageInterceptor: use sessionItems=null for server, and senderConnection.Session.Items(never null) for client;
https://github.com/chkr1011/MQTTnet/blob/7eb6d2d1e3d0480b89cbdafe0dc4380ea5dd055c/Source/MQTTnet/Server/MqttServerEventDispatcher.cs#L111
3. Seems MqttServer.ApplicationMessageReceivedHandler will be called for server, but MqttApplicationMessageReceivedEventArgs.ProcessingFailed is never used, so if it's just an recv event and should use ApplicationMessageInterceptor for perm instead?

Since the server is not "connecting" to itself there is no way to initialize these items. The only reason to have them is to have the application message interceptor always working. I can add the initial values for that dictionary to the server options so that these values are used after startup if this fits your needs.

Point 2 is indeed an issue. I fixed that.
Point 3 is not relevant for undelivered messages but since the interceptor signature is the same as for message interceptor is is just there. Maybe I should consider creating a dedicated interceptor for not process messages.

I close this because the issue is fixed.


Web Build Fixes

Prefer the U3D shell.html rather than generating one from the emscripten default. (Fixes #54)
Remove the custom emscripten toolchain file. Instead, use the one installed by the emsdk, which is available by calling the cmake_emscripten script through emcmake.
Backport a minor SDL change to setWindowTitle that is needed for newer versions of emscripten. As I have corrected it, it should be backwards compatible to old versions.
Add a click-to-play overlay and delay running the web assembly until the user click it. Untested on mobile. Fixes #53
Add a separate web workflow. This demonstrates how to use emcmake. Additionally, it should eventually be used to update samples on the website.

I tested the click to play on my phone and it worked fine, and I rebased onto the last change to master (I missed it earlier with having multiple remotes).
The mingw windows builds have been failing for a while now because of an issue with the action installing it (I think there is a workaround, but that can be done in a separate PR), as has the QA build.
If you want, I could disable the wasm builds within the Linux workflow, but otherwise I think it's ready to be merged.

Let's merge it!


[FEAT] Support for file name with custom date

Problem
I would like a custom date format to appear at the end of the file name
Solution
I think some form of parsing for the % symbol would be good.
For example, in Bash you might have
printf -v date '%(%Y-%m-%d %H:%M:%S)T\n' -1

Where %Y represents year,
%m represents month,
etc
I think all of the those in the string would be good to implement

%Y - year
%m - month
%d - day
%H - hour
%M - minute
%S - second

If you have another format that you would prefer that would work as well

@cgcel Is it okay if I make a pull request to implement this?

@cgcel I would be willing to implement this shortly, if you're open to collaborations.

Yes of course🎉

Your code has been merged, and I updated the code of autoDelete, thanks for your contribution!


Move remaining services over to jenkins deploy

Currently Jenkins is only deploying the web app to an auto-scale group - we should look to do the same for redis, solr. We likely should start with a single instance deploy for both for now (autoscale -> just 1 instance) - similar to the dev setup. The only critical thing here is ensuring we have actual uptime for both when AWS EAST inevitably goes down. It should spin up a new instance of either automatically if the old one is killed.

One comment here - if possible we should run all of these on 1 VMs with the load balancer pointing to it - this hopefully is the most cost effective way of dealing with this. We can deal with some down time when we release until we have more traffic.

If I've got it correctly. There is no point to use auto-scale group for Redis and Solr.
In fact auto-scale group is clusterization technology. However, Redis use their own cluster (see redis-trib.rb). If we will want to scale Solr horizontally, we should use its own sharding (e.g. ZooKeeper)
"...if possible we should run all of these on 1 VM..." Yes, it is possible to run all of the our containers: PostrgreSQL, Solr and all Redis nodes on 1 VM. To be more precise 1 VM for TEST and 1 VM for PROD.
I've never tried t2.nano. Should I try it or t2.micro is fine?

Let's try nano and if it's totally broken move up to micro?

Creating a new issue for the auto-redeploy of updated configuration/auto-recreation if the current VM goes down (my understanding would be that we would lose the DB changes and we'd need to manually spin a new VM up).


Add automated publishing of website with some extra cleanup

First of all sorry for huge PR but it's because there was some necessary cleanup added. I will explain here what changes were done so it is easier to review:

Rename of hugo-fresh theme to hugo-asyncapi and complete removal of readme and license from the old theme
resources and public folders are removed from the repository and added to .gitignore. Public dir is completely regenerated on hugo -t hugo-asyncapi, also some files in resources. Correct me if I'm wrong but looks like resources is not needed at all, I don't see where generated scss files are used. I did not find any explanation here https://gohugo.io/getting-started/directory-structure/ so maybe it is just some legacy and we just leave it as it is, in gitignore and that is it?
Add Netlify badge to landing page footer. Let me know if you like the location and the badge that I picked, others are listed here https://www.netlify.com/press/#badges
Add netlify build status to Readme
Some readme cleanup

Manual validation:

Main website is built here on every change to master branch of my fork - https://keen-banach-449f3a.netlify.com/. You can see there is no Netlify footer (initial build was done hugo -t hugo-fresh as rename of the theme is not in the master)
Link to preview you can see here https://github.com/derberg/website-2/pull/1 and you can see preview has a footer

Next steps:
Once this is merged I will do build setup on Netlify and configure preview generation
Related to #43

Preview do not work here of course as the build command is changed

@fmvilas thanks for the info about sass, looks like it is part of the theme. So looks like we can ignore resources dir on local and have it in .gitignore as is regenerated during build time
@fmvilas regarding the _redirects I removed it as I removed whole public dir as it should not be in the repo. Sorry, didn't notice it is not regenarated in the dir during build. Now I recreated the file in static dir to have it copied over to public dir
@jonaslagoni this is why I provided link to other badges so others can share opinion as I don't have one :) I changed the logo, have a look


Automate apama installation in system test workflow

Describe the bug
Apama installation should be part of the system test workflow definition so that the tests can reliably run on those. Earlier we were manually installing Apama on all test slaves, which was okay with just 4 slaves, but not scalable.

Update ancible playbook to install apama to RPi runners. No change on system test workflow.

Added the Apama installation to the Ansible playbook that we use to update and setup our Pis. I believe the installation is better located here than in the system test workflow.
https://github.com/thin-edge/thin-edge.io_qa/tree/main/Ansible


Bug, when I need to see the property of a field.

This happens to me when I go to view the property of a primary key.

This doesn't happen when I query a field like varchar.

Also occurs in a boolean field.

Also occurs in a Date field.

It doesn't happen in Blob fields.
It also happened in the previous version. And in this version of firebird too.

Debian 12.
How can I see the app's bug tracking?

It continues to break down in a clean environment.
Data types INTEGER, BIGINT, BOOLEAN among others.
Only with VARCHAR can the properties of the fields be displayed.

Employee DB... Same Problem.

Working in Debian's repository.
Version 0.9.6 Unicode

On Windows same problem with any BIGINT field. Doble clicking on it cause an fatal error:

if i remember correctly i had 9.0.8 previously and all was ok, so some recent change brake this.

Please, try to use latest snapshot (you can download Windows build from latest action currently building)
If it's working now, close this issue


Where's the Score?

I'm brand new to this project, but a skim of the CIS Docker Benchmark PDF mentions a "final benchmark score," therefore I'd assumed that with from this utility (in addition to other output) I'd end up with a score. However, I'm not spotting any score information in the output.
Is that unimplemented, or did I miss something?

Hi @jamiejackson, that has yet to be implemented. Will start working on it.
Thanks for the reminder.

Please test #266

Although I'm not sure of the scoring metadata for CIS Docker Benchmark, I can confirm that I do get a check tally and a score (below).
Where's the CIS Docker Benchmark scoring reference, by the way? I assume that the lower the score, the better, but I don't know the weight of each check, etc. I didn't spot that information in the PDF, but I may have overlooked it.
$ git clone https://github.com/konstruktoid/docker-bench-security.git
$ cd docker-bench-security
$ git checkout issue265

$ sudo sh docker-bench-security.sh

# ------------------------------------------------------------------------------
# Docker Bench for Security v1.3.4
#
# Docker, Inc. (c) 2015-
#
# Checks for dozens of common best-practices around deploying Docker containers in production.
# Inspired by the CIS Docker Community Edition Benchmark v1.1.0.
# ------------------------------------------------------------------------------

Initializing Mon Oct 23 15:02:51 UTC 2017

[INFO] 1 - Host Configuration
[WARN] 1.1  - Ensure a separate partition for containers has been created
[NOTE] 1.2  - Ensure the container host has been Hardened
[PASS] 1.3  - Ensure Docker is up to date
[INFO]      * Using 17.10.0 which is current
[INFO]      * Check with your operating system vendor for support and security maintenance for Docker
[INFO] 1.4  - Ensure only trusted users are allowed to control Docker daemon
[INFO]      * docker:x:993:ICF-HQ_15037,ICFI_11111,ICFI_22222,vagrant,jenkins
[PASS] 1.5  - Ensure auditing is configured for the Docker daemon
[PASS] 1.6  - Ensure auditing is configured for Docker files and directories - /var/lib/docker
[PASS] 1.7  - Ensure auditing is configured for Docker files and directories - /etc/docker
[PASS] 1.8  - Ensure auditing is configured for Docker files and directories - docker.service
[INFO] 1.9  - Ensure auditing is configured for Docker files and directories - docker.socket
[INFO]      * File not found
[INFO] 1.10 - Ensure auditing is configured for Docker files and directories - /etc/default/docker
[INFO]      * File not found
[WARN] 1.11 - Ensure auditing is configured for Docker files and directories - /etc/docker/daemon.json
[WARN] 1.12 - Ensure auditing is configured for Docker files and directories - /usr/bin/docker-containerd
[WARN] 1.13 - Ensure auditing is configured for Docker files and directories - /usr/bin/docker-runc

[INFO] 2 - Docker daemon configuration
[PASS] 2.1  - Ensure network traffic is restricted between containers on the default bridge
[PASS] 2.2  - Ensure the logging level is set to 'info'
[PASS] 2.3  - Ensure Docker is allowed to make changes to iptables
[PASS] 2.4  - Ensure insecure registries are not used
[PASS] 2.5  - Ensure aufs storage driver is not used
[INFO] 2.6  - Ensure TLS authentication for Docker daemon is configured
[INFO]      * Docker daemon not listening on TCP
[INFO] 2.7  - Ensure the default ulimit is configured appropriately
[INFO]      * Default ulimit doesn't appear to be set
default
[PASS] 2.8  - Enable user namespace support
[PASS] 2.9  - Ensure the default cgroup usage has been confirmed
[PASS] 2.10 - Ensure base device size is not changed until needed
[WARN] 2.11 - Ensure that authorization for Docker client commands is enabled
[PASS] 2.12 - Ensure centralized and remote logging is configured
[PASS] 2.13 - Ensure operations on legacy registry (v1) are Disabled
[PASS] 2.14 - Ensure live restore is Enabled
[PASS] 2.15 - Ensure Userland Proxy is Disabled
[PASS] 2.16 - Ensure daemon-wide custom seccomp profile is applied, if needed
[PASS] 2.17 - Ensure experimental features are avoided in production
[PASS] 2.18 - Ensure containers are restricted from acquiring new privileges

[INFO] 3 - Docker daemon configuration files
[PASS] 3.1  - Ensure that docker.service file ownership is set to root:root
[PASS] 3.2  - Ensure that docker.service file permissions are set to 644 or more restrictive
[INFO] 3.3  - Ensure that docker.socket file ownership is set to root:root
[INFO]      * File not found
[INFO] 3.4  - Ensure that docker.socket file permissions are set to 644 or more restrictive
[INFO]      * File not found
[PASS] 3.5  - Ensure that /etc/docker directory ownership is set to root:root
[PASS] 3.6  - Ensure that /etc/docker directory permissions are set to 755 or more restrictive
[INFO] 3.7  - Ensure that registry certificate file ownership is set to root:root
[INFO]      * Directory not found
[INFO] 3.8  - Ensure that registry certificate file permissions are set to 444 or more restrictive
[INFO]      * Directory not found
[INFO] 3.9  - Ensure that TLS CA certificate file ownership is set to root:root
[INFO]      * No TLS CA certificate found
[INFO] 3.10 - Ensure that TLS CA certificate file permissions are set to 444 or more restrictive
[INFO]      * No TLS CA certificate found
[INFO] 3.11 - Ensure that Docker server certificate file ownership is set to root:root
[INFO]      * No TLS Server certificate found
[INFO] 3.12 - Ensure that Docker server certificate file permissions are set to 444 or more restrictive
[INFO]      * No TLS Server certificate found
[INFO] 3.13 - Ensure that Docker server certificate key file ownership is set to root:root
[INFO]      * No TLS Key found
[INFO] 3.14 - Ensure that Docker server certificate key file permissions are set to 400
[INFO]      * No TLS Key found
[PASS] 3.15 - Ensure that Docker socket file ownership is set to root:docker
[PASS] 3.16 - Ensure that Docker socket file permissions are set to 660 or more restrictive
[PASS] 3.17 - Ensure that daemon.json file ownership is set to root:root
[PASS] 3.18 - Ensure that daemon.json file permissions are set to 644 or more restrictive
[INFO] 3.19 - Ensure that /etc/default/docker file ownership is set to root:root
[INFO]      * File not found
[INFO] 3.20 - Ensure that /etc/default/docker file permissions are set to 644 or more restrictive
[INFO]      * File not found

[INFO] 4 - Container Images and Build File
[INFO] 4.1  - Ensure a user for the container has been created
[INFO]      * No containers running
[NOTE] 4.2  - Ensure that containers use trusted base images
[NOTE] 4.3  - Ensure unnecessary packages are not installed in the container
[NOTE] 4.4  - Ensure images are scanned and rebuilt to include security patches
[WARN] 4.5  - Ensure Content trust for Docker is Enabled
[PASS] 4.6  - Ensure HEALTHCHECK instructions have been added to the container image
[PASS] 4.7  - Ensure update instructions are not use alone in the Dockerfile
[NOTE] 4.8  - Ensure setuid and setgid permissions are removed in the images
[PASS] 4.9  - Ensure COPY is used instead of ADD in Dockerfile
[NOTE] 4.10 - Ensure secrets are not stored in Dockerfiles
[NOTE] 4.11 - Ensure verified packages are only Installed

[INFO] 5 - Container Runtime
[INFO]      * No containers running, skipping Section 5

[INFO] 6 - Docker Security Operations
[INFO] 6.1  - Avoid image sprawl
[INFO]      * There are currently: 0 images
[INFO] 6.2  - Avoid container sprawl
[INFO]      * There are currently a total of 0 containers, with 0 of them currently running

[INFO] 7 - Docker Swarm Configuration
[PASS] 7.1  - Ensure swarm mode is not Enabled, if not needed
[PASS] 7.2  - Ensure the minimum number of manager nodes have been created in a swarm (Swarm mode not enabled)
[PASS] 7.3  - Ensure swarm services are binded to a specific host interface (Swarm mode not enabled)
[PASS] 7.4  - Ensure data exchanged between containers are encrypted on different nodes on the overlay network
[PASS] 7.5  - Ensure Docker's secret management commands are used for managing secrets in a Swarm cluster (Swarm mode not enabled)
[PASS] 7.6  - Ensure swarm manager is run in auto-lock mode (Swarm mode not enabled)
[PASS] 7.7  - Ensure swarm manager auto-lock key is rotated periodically (Swarm mode not enabled)
[PASS] 7.8  - Ensure node certificates are rotated as appropriate (Swarm mode not enabled)
[PASS] 7.9  - Ensure CA certificates are rotated as appropriate (Swarm mode not enabled)
[PASS] 7.10 - Ensure management plane traffic has been separated from data plane traffic (Swarm mode not enabled)

[INFO] Checks: 74
[INFO] Score: 34

That's basically the issue, the score is increased with a pass and decreased with a warn, and a higher score is most likely better. But there's no info stating that a 30+ score is good and if that is when including the Docker Swarm configuration.
I believe that it's just a reference point to be used internally.

Hi @jsto
The score basically tells you that you got so many warnings that the environment got a negative score.
I'm not sure how you got a negative score without seeing the actual output, but the script shouldn't go below 0.

Hi @konstruktoid
Thank you for the response. I was also surprised when we got a negative result. Normally, we would expect a score of pass over the total checks (for example 60/100) compliance score, so you can imagine our reaction with a non-positive result. :)
I am trying to understand how we came up with this number by taking the number of pass and warn on the .json file:
grep -o -i "NOTE" docker-bench-security.log.json | wc -l
9
grep -o -i "WARN" docker-bench-security.log.json | wc -l
40
grep -o -i "PASS" docker-bench-security.log.json | wc -l
40
grep -o -i "INFO" docker-bench-security.log.json | wc -l
29

but these don't add up to reach -8.
Are you using K8s or Swarm or something that's not a standard Docker installation?

We're using the following:
Client: Docker Engine - Community
 Version:           20.10.23
 API version:       1.41
 Go version:        go1.18.10
 Git commit:        7155243
 Built:             Thu Jan 19 17:33:56 2023
 OS/Arch:           linux/amd64
 Context:           default
 Experimental:      true

Server: Docker Engine - Community
 Engine:
  Version:          20.10.23
  API version:      1.41 (minimum version 1.12)
  Go version:       go1.18.10
  Git commit:       6051f14
  Built:            Thu Jan 19 17:32:04 2023
  OS/Arch:          linux/amd64
  Experimental:     false
 containerd:
  Version:          1.6.15
  GitCommit:        5b842e528e99d4d4c1686467debf2bd4b88ecd86
 runc:
  Version:          1.1.4
  GitCommit:        v1.1.4-0-g5fd4c4d
 docker-init:
  Version:          0.19.0
  GitCommit:        de40ad0

Besides the fact that it is an out-of-date version, running a basic Docker daemon shouldn't cause this.
I'll test it some more as soon as possible

We are planning to upgrade to 20.10.24-3, but nothing is on the roadmap for 23.0.x, yet.
Thank you so much @konstruktoid. I greatly appreciate the help.

Hi again @jsto,
I can't reproduce this.
What of docker-bench-security are you running?
Can you share a container example?


Rename request_adapter_trace -> request_adapter

As requested
Change request_adapter_trace to request_adapter.

Merged changes in main into PR.  Although it has been approved, I don't have appropriate permissions to merge it back into main.


Hosts: force adding hostname to ::1 causes issues with dnsmasq

https://github.com/NixOS/nixpkgs/blob/b68a6a27adb452879ab66c0eaac0c133e32823b2/nixos/modules/config/networking.nix#L174-L189
Here, adding the hostname to ::1 causes dnsmasq to respond to queries for the hostname with ::1:
$ host foobar
foobar.local.lan has address <IP_ADDRESS> # router running nixos
foobar.local.lan has address ::1 # it shouldn't do this

@kira-bruneau can you take a look please?

In short - I don't want hosts to contain ::1 localhost localhost.localdomain foobar

I'm not that familiar with this module, but I could take a look. Was there a specific reason you pinged me? It looked like @primeos added this.

@kira-bruneau Oh! Sorry about that. I followed the suggestion of someone to issue 'git blame' on a file in order to figure out who the last maintainer was. I'm new to Nix and NixOS and I really don't know how to properly find the right maintainer here yet. My apologies! :sweat_smile:

No worries! This almost seems like a bug in dnsmasq (because it's not also returning <IP_ADDRESS>)

It's doing this because of the fact that I'm using it a DNS server which uses /etc/hosts to answer to DNS requests. Not a bug, a feature : )

In short - I don't want hosts to contain ::1 localhost localhost.localdomain foobar

You should be able to use something like this (not tested):
networking.hosts = {
  "<IP_ADDRESS>" = lib.mkForce [ ];
  "::1" = lib.mkForce [ ];
}

Please re-open if something like this doesn't work.

It's doing this because of the fact that I'm using it a DNS server which uses /etc/hosts to answer to DNS requests. Not a bug, a feature : )

A bit of an "interesting" setup... :D But dnsmasq hopefully also has an option not to answer queries for addresses like ::1.

Hi @primeos thanks. There is an option to not respond to such queries (rebind-localhost-ok), but these hostnames are also used for, as it says in the man page, "black hole servers", and as such blocking it might disable such services.
I already tried to redefine <IP_ADDRESS> and ::1 in the way you suggested, but without the lib.mkForce. Using that, it seems to does the trick. Thank you. : )


Cache flattened schemas

Optimize flatten step by:

Cache the schemas of flattened parts (key or value)
Decouple flattened field value evaluation from schema evaluation. This would enable caching the schema once, and use it to calculate field values at each transform invocation,
Add simple JMH benchmarking to establish a baseline of improvements

Sample benchmark before caching (1000 nested levels):
Benchmark                       (nestedLevels)  Mode  Cnt  Score   Error  Units
FlattenStepBenchmark.doFlatten            1000  avgt    5  0.403 ± 0.014   s/op

and after:
Benchmark                       (nestedLevels)  Mode  Cnt  Score   Error  Units
FlattenStepBenchmark.doFlatten            1000  avgt    5  0.360 ± 0.017   s/op

is it still a draft ?

is it still a draft ?

It is. I'm was looking for feedback on performance improvement. For now I think the added complexity is not justified. Here is a baseline benchmark (without caching):
FlattenStepBenchmark.doFlatten              10  avgt    5  ≈ 10⁻⁴            s/op
FlattenStepBenchmark.doFlatten             100  avgt    5   0.002 ±  0.001   s/op
FlattenStepBenchmark.doFlatten            1000  avgt    5   0.147 ±  0.010   s/op

I'm thinking to close this PR for now and reconsider if there is a need. Also an event with 1000 nested levels is a big stretch!


feat: dependabot workflow automation for updating dependency

Proposed Changes
Manual control of dependency is fine but with a growing no. of distributed upstream dependencies, it becomes hard to manage. So, for that automation should be there to update dependencies. Further, CI Pipeline is there to test those changes.
Further, this will not update the dependencies automatically,  instead,  a PR will be opened with changes that can be reviewed and tested with CI.
Types of Changes
Automation workflow
Verification

Testing

Linked Issues

User-Facing Change

NONE

Further Comments

Signed-off-by: Pratik Raj<EMAIL_ADDRESS>

I'm not sure this is a good idea. Many of our dependent package versions are tied to what is in use by upstream Kubernetes for a given release. We are generally careful to use the same as what they use, or risk introducing bugs. Places where we deviate from upstream are usually intentional.


Add tvOS support

Compile native libs for ARM64/X86_64, put them in META-INF/robovm/libs/tvos

Fixed.


Addresses endpoint uses v3 instead of v2

For example client.rest.address.listAddresses sends to https://api.coinbase.com/api/v3/accounts/:id/addresses instead of using the SIWC base url (https://docs.cloud.coinbase.com/sign-in-with-coinbase/docs/api-addresses).
Using the custom request works:
client.rest.coinbaseRequest({
  baseURL: clientAdvanced.url.REST_SIWC,
  method: "get",
  url: `/accounts/${USDC_ACCOUNT}/addresses`,
});

I believe a similar thing happened for transactions, all the SIWC APIs under /accounts might be affected.

I appreciate you bringing this to my attention. Resolved in version 2.1.0


Multiple improvements and fixes

Hi, Im not sure if this repo is still being actively maintained, but if so, please see the following changes.
Changes
Breaking

(maybe) breaking: updated exists() to check systemctl list-unit-files. Units can exists here, but not have a status

Features

added unit_list_full() function which returns all three info columns from systemctl list-unit-files as a vector of structs. unit_list_full() now has the actually logic, with unit_list() reducing the result to a vector of strings with names.
added glob filter to unit_list() and unit_list_full() so you can filter for unit names. e.g. systemctl list-unit-files cron* would only return units starting with cron
added transient as a field for Unit struct, as it can appear
add Cntrl PID option for PID

Fixes / Improvements

updated dependencies
updated edition to 2021
removed default-env dependency, it's not needed and updated systemctl() and systemctl_capture() function with native env variables
add test for unit_list_full()
fix clippy warnings and deactive them for not-implemented parts
re-do the whole default() thing, most of it can be derived and will save on code
switch the Unit if...else to .strip_prefix(). It will return false if it doesnt work, or return back the value without prefix

@gwbres the pipeline is failing as per main branch. To fix it, we can revert https://github.com/gwbres/systemctl/pull/16/commits/e20fdfbff664fd92babefcf93320670a6a13fea4 , but that is an architectural decision I would leave up to you

@alexkunde
Thank for the many improvements ! let's merge them we'll fix the pipeline later


ReactCommerce

Added ReactCommerce built on react.js and redux

You've sent the same PR three times. This is spamming.