Recent regex update too greedy

Describe the bug
Updated rule (?i)aws_(.{0,20})?=?.[\'\"0-9a-zA-Z\/+]{40} match the follow string in a terraform file:
40 }
41
42 data "aws_iam_policy_document" "SecretsManagerRDSPostgreSQLRotationSingleUserRolePolicy" {
43   statement {
44

{
  "line": "data \"REDACTEDleUserRolePolicy\" {",
  "lineNumber": 42,
  "offender": "REDACTED",
  "offenderEntropy": -1,
  "commit": "XXXX",
  "repo": "XXXX",
  "repoURL": "",
  "leakURL": "",
  "rule": "AWS Secret Key",
  "commitMessage": "XXXX",
  "author": "XXXX",
  "email": "XXXX",
  "file": "XXXX",
  "date": "2021-09-01T08:14:33-03:00",
  "tags": "key, AWS"
 }

To Reproduce
Scan a terraform script file containing
data "aws_iam_policy_document" "SecretsManagerRDSPostgreSQLRotationSingleUserRolePolicy" {
Expected behavior
No match, it's not a AWS Secret Key.
Screenshots
Not applicable.
Basic Info (please complete the following information):

OS: Ubuntu 20.04.3 LTS
Gitleaks Version: v.7.6.1

Additional context
Maybe remove \'\" from [\'\"0-9a-zA-Z\/+] should be enough. Don't need to seek for quotation marks as delimiters.
But a sanity check is needed, and want to discuss first with community, understand if it really is a bug.
Thank you for that very nice tool :).
cc @zricethezav

@julianoborba I actually deleted this rule in the latest version of gitleaks. I will be providing community contribution guidelines and best practices on how to submit new rules soon. AWS needs to be revisited

Thank you very much.

Just updated from 7.6.1 to latest master and my regex's are really greedy now. Almost the entire file is being detected in each run.  Before 1Mb json output file w/842 detections, now 47Mb output file w/42 detections.
What's the new trick for regex's?

@agonzalez-plume what rule is bloating the report?

Can't say my regex is perfect, I have a .* in there, and a pretty liberal [\x20-\x7e], as well as a not expression for anything except ''
encryption[\]+",.[\]+"key[-\d+][\]+",[\]+"[\x20-\x7e][^]+[\x20-\x7e][\]+.*]]]

@agonzalez-plume having a .* means all bets are off as I'm not limiting the output by character length like I was before

Yeah, like most regexes there a couple of other ways I can write it.  Will take a look at making it simpler.

An update, it wasn't the ., it was the [^].  It's gobbling up the characters.  To fix, I added to not like closing brackets too (since it's a section delimiter for my text) -> [^*]] and now it's detecting it the same as 7.6.1


Clarifying that object equality is a.equals(b) in Intent for 2.12

@reactive-streams/contributors No semantical change, only clarification that it is a.equals(b) which is intended.

@reactive-streams/contributors Seems non-controversial. Can I merge?

I think it's ... HTTP 500.

@akarnokd ? Works for me: https://github.com/reactive-streams/reactive-streams-jvm/pull/343/commits/dad18725eea22455150fb8164f8d83e403087f13

GitHub staff resolved the 500 issues.

clarification that it is a.equals(b) which is intended

:+1:

@akarnokd :+1:

@reactive-streams/contributors Merging


Add resolver redundancy

The OneName resolver for handles is a central point of failure in the current OB1.0 design. Starting from version 0.14.0 of Blockstack Core, Duo Search will be running its own resolver.
Does it make sense to add Duo Search's handle resolver into the reference client? 3-way redundant Blockstack nodes via OneName, OB1 and Duo Search would mitigate the central point of failure.

We'd need to figure out how we'd want to do that. Query all resolves in the list? That would be slow. Rotate through the list on failure?

IMO a neat solution is to first randomize the list of resolvers and then rotate through the list on failure. The initial randomization makes sure that a single resolver doesn't have an opportunity to spy (IP harvesting, query harvesting) on the whole network.


Can't make it work

A bit frustrated trying to make this work, but it just doesn't, PDM works fine whenever I do pdm install -v or pdm sync
but after I try to run tox I run into the following:
See /var/folders/59/5yr8qg9n6gl1g9hqtgs127rmn4qv12/T/pdm-install-sxz9qti8.log for detailed debug log.
[InstallationError]: Some package operations are not complete yet
Add '-v' to see the detailed traceback

============================================================================================================================================ log end ============================================================================================================================================
ERROR: could not install deps []; v = InvocationError('/usr/local/bin/pdm install -p .tox/lint --no-default --group lint --no-self', 1)
____________________________________________________________________________________________________________________________________________ summary ____________________________________________________________________________________________________________________________________________
ERROR:   lint: could not install deps []; v = InvocationError('/usr/local/bin/pdm install -p .tox/lint --no-default --group lint --no-self', 1)

This are my tox.ini and pyproject.toml
[tox]
env_list = py{310},lint,typecheck
isolated_build = true

[testenv]
groups = test
commands =
    pytest tests/

[testenv:lint]
groups = lint
skip_install = true
commands =
    black --check bash_log2nl/
    flake9 bash_log2nl/

[testenv:typecheck]
groups = typecheck
skip_install = true
commands =
    mypy bash_log2nl/

[project]
name = "bash_log2nl"
version = "0.1.0"
description = ""
authors = [
    {name = "Gustavo Barrios", email = ""},
]
dependencies = [
    "sqlalchemy>=1.4.31",
    "pydantic[dotenv]>=1.9.0",
    "python-dotenv>=0.19.2",
    "sshtunnel>=0.4.0",
]
requires-python = ">=3.10"
license = {text = "MIT"}

[project.urls]
homepage = ""

[project.optional-dependencies]
[tool]
[tool.pdm]
[tool.pdm.dev-dependencies]
dev = [
    "pytest>=6.2.5",
    "pytest-cov>=3.0.0",
    "tox>=3.24.5",
    "tox-pdm>=0.3.2"]
lint = [
    "black>=22.1.0",
    "flake8>=4.0.1",
]
typecheck = [
    "mypy>=0.931",
]

[build-system]
requires = ["pdm-pep517"]
build-backend = "pdm.pep517.api"

[tool.pytest.ini_options]
addopts = "--cov=bash_log2nl --cov-report=term-missing"
testpaths = "tests"

[tool.pyright]
pythonVersion = "3.10"
typeCheckingMode = "strict"
include = ["bash_log2nl", "typings"]
exclude = ["tests"]
reportGeneralTypeIssues = false
reportConstantRedefinition = false
reportFunctionMemberAccess = false
reportImportCycles = false
reportIncompatibleMethodOverride = false
reportIncompatibleVariableOverride = false
reportMissingModuleSource = false
reportMissingParameterType = false
reportMissingTypeArgument = false
reportMissingTypeStubs = false
reportOptionalCall = false
reportOptionalIterable = false
reportOptionalMemberAccess = false
reportOptionalOperand = false
reportOptionalSubscript = false
reportPrivateImportUsage = false
reportPrivateUsage = false
reportUnboundVariable = false
reportUnknownArgumentType = false
reportUnknownLambdaType = false
reportUnknownMemberType = false
reportUnknownParameterType = false
reportUnknownVariableType = false
reportUnnecessaryComparison = false
reportUnnecessaryIsInstance = false
reportUnsupportedDunderAll = false
reportUntypedBaseClass = false
reportUnusedClass = false
reportUnusedFunction = false
reportUnusedImport = false
reportUnusedVariable = false
reportMissingImports = false

[tool.mypy]
mypy_path = "bash_log2nl"
check_untyped_defs = true
disallow_any_generics = true
ignore_missing_imports = true
no_implicit_optional = true
show_error_codes = true
strict_equality = true
warn_redundant_casts = true
warn_return_any = true
warn_unreachable = true
warn_unused_configs = true
no_implicit_reexport = true

[tool.black]
line-length = 88
target_version = ['py310']

Any help is greatly appreciated.

See /var/folders/59/5yr8qg9n6gl1g9hqtgs127rmn4qv12/T/pdm-install-sxz9qti8.log for detailed debug log.
[InstallationError]: Some package operations are not complete yet
Add '-v' to see the detailed traceback

Can I have the detailed error log?

Sure.
bash-log2nl on  master [!] via 🐍 v2.7.16
❯ pdm run tox
lint create: /Users/gustavo.barrios/Documents/Projects/bash-log2nl/.tox/lint
lint pdminstall: ['lint']
ERROR: invocation failed (exit code 1), logfile: /Users/gustavo.barrios/Documents/Projects/bash-log2nl/.tox/lint/log/lint-63.log
=========================================================================================================================================== log start ===========================================================================================================================================
Synchronizing working set with lock file: 10 to add, 0 to update, 0 to remove

Install pathspec 0.9.0 failed
Install pycodestyle 2.8.0 failed
Install click 8.0.3 failed
Install platformdirs 2.4.1 failed
Install mccabe 0.6.1 failed
Install black 22.1.0 failed
Install flake8 4.0.1 failed
Install mypy-extensions 0.4.3 failed
Install tomli 2.0.0 failed
Install pyflakes 2.4.0 failed
  Retry failed jobs
Install pathspec 0.9.0 failed
Install black 22.1.0 failed
Install mypy-extensions 0.4.3 failed
Install click 8.0.3 failed
Install mccabe 0.6.1 failed
Install flake8 4.0.1 failed
Install platformdirs 2.4.1 failed
Install pycodestyle 2.8.0 failed
Install pyflakes 2.4.0 failed
Install tomli 2.0.0 failed

ERRORS:
add pathspec failed:
Traceback (most recent call last):
  File<EMAIL_ADDRESS>line 58, in run
    result = self.fn(*self.args, **self.kwargs)
  File "/usr/local/Cellar/pdm/1.12.7/libexec/lib/python3.10/site-packages/pdm/installers/synchronizers.py", line 185, in install_candidate
    self.manager.install(can)
  File "/usr/local/Cellar/pdm/1.12.7/libexec/lib/python3.10/site-packages/pdm/installers/manager.py", line 38, in install
    installer(candidate.build(), self.environment, candidate.direct_url())
  File "/usr/local/Cellar/pdm/1.12.7/libexec/lib/python3.10/site-packages/pdm/models/candidates.py", line 304, in build
    self.prepare()
  File "/usr/local/Cellar/pdm/1.12.7/libexec/lib/python3.10/site-packages/pdm/models/candidates.py", line 257, in prepare
    downloaded = pip_shims.unpack_url(
TypeError: unpack_url() missing 1 required positional argument: 'verbosity'
add black failed:
Traceback (most recent call last):
  File<EMAIL_ADDRESS>line 58, in run
    result = self.fn(*self.args, **self.kwargs)
  File "/usr/local/Cellar/pdm/1.12.7/libexec/lib/python3.10/site-packages/pdm/installers/synchronizers.py", line 185, in install_candidate
    self.manager.install(can)
  File "/usr/local/Cellar/pdm/1.12.7/libexec/lib/python3.10/site-packages/pdm/installers/manager.py", line 38, in install
    installer(candidate.build(), self.environment, candidate.direct_url())
  File "/usr/local/Cellar/pdm/1.12.7/libexec/lib/python3.10/site-packages/pdm/models/candidates.py", line 304, in build
    self.prepare()
  File "/usr/local/Cellar/pdm/1.12.7/libexec/lib/python3.10/site-packages/pdm/models/candidates.py", line 257, in prepare
    downloaded = pip_shims.unpack_url(
TypeError: unpack_url() missing 1 required positional argument: 'verbosity'
add mypy-extensions failed:
Traceback (most recent call last):
  File<EMAIL_ADDRESS>line 58, in run
    result = self.fn(*self.args, **self.kwargs)
  File "/usr/local/Cellar/pdm/1.12.7/libexec/lib/python3.10/site-packages/pdm/installers/synchronizers.py", line 185, in install_candidate
    self.manager.install(can)
  File "/usr/local/Cellar/pdm/1.12.7/libexec/lib/python3.10/site-packages/pdm/installers/manager.py", line 38, in install
    installer(candidate.build(), self.environment, candidate.direct_url())
  File "/usr/local/Cellar/pdm/1.12.7/libexec/lib/python3.10/site-packages/pdm/models/candidates.py", line 304, in build
    self.prepare()
  File "/usr/local/Cellar/pdm/1.12.7/libexec/lib/python3.10/site-packages/pdm/models/candidates.py", line 257, in prepare
    downloaded = pip_shims.unpack_url(
TypeError: unpack_url() missing 1 required positional argument: 'verbosity'
add mccabe failed:
Traceback (most recent call last):
  File<EMAIL_ADDRESS>line 58, in run
    result = self.fn(*self.args, **self.kwargs)
  File "/usr/local/Cellar/pdm/1.12.7/libexec/lib/python3.10/site-packages/pdm/installers/synchronizers.py", line 185, in install_candidate
    self.manager.install(can)
  File "/usr/local/Cellar/pdm/1.12.7/libexec/lib/python3.10/site-packages/pdm/installers/manager.py", line 38, in install
    installer(candidate.build(), self.environment, candidate.direct_url())
  File "/usr/local/Cellar/pdm/1.12.7/libexec/lib/python3.10/site-packages/pdm/models/candidates.py", line 304, in build
    self.prepare()
  File "/usr/local/Cellar/pdm/1.12.7/libexec/lib/python3.10/site-packages/pdm/models/candidates.py", line 257, in prepare
    downloaded = pip_shims.unpack_url(
TypeError: unpack_url() missing 1 required positional argument: 'verbosity'
add click failed:
Traceback (most recent call last):
  File<EMAIL_ADDRESS>line 58, in run
    result = self.fn(*self.args, **self.kwargs)
  File "/usr/local/Cellar/pdm/1.12.7/libexec/lib/python3.10/site-packages/pdm/installers/synchronizers.py", line 185, in install_candidate
    self.manager.install(can)
  File "/usr/local/Cellar/pdm/1.12.7/libexec/lib/python3.10/site-packages/pdm/installers/manager.py", line 38, in install
    installer(candidate.build(), self.environment, candidate.direct_url())
  File "/usr/local/Cellar/pdm/1.12.7/libexec/lib/python3.10/site-packages/pdm/models/candidates.py", line 304, in build
    self.prepare()
  File "/usr/local/Cellar/pdm/1.12.7/libexec/lib/python3.10/site-packages/pdm/models/candidates.py", line 257, in prepare
    downloaded = pip_shims.unpack_url(
TypeError: unpack_url() missing 1 required positional argument: 'verbosity'
add flake8 failed:
Traceback (most recent call last):
  File<EMAIL_ADDRESS>line 58, in run
    result = self.fn(*self.args, **self.kwargs)
  File "/usr/local/Cellar/pdm/1.12.7/libexec/lib/python3.10/site-packages/pdm/installers/synchronizers.py", line 185, in install_candidate
    self.manager.install(can)
  File "/usr/local/Cellar/pdm/1.12.7/libexec/lib/python3.10/site-packages/pdm/installers/manager.py", line 38, in install
    installer(candidate.build(), self.environment, candidate.direct_url())
  File "/usr/local/Cellar/pdm/1.12.7/libexec/lib/python3.10/site-packages/pdm/models/candidates.py", line 304, in build
    self.prepare()
  File "/usr/local/Cellar/pdm/1.12.7/libexec/lib/python3.10/site-packages/pdm/models/candidates.py", line 257, in prepare
    downloaded = pip_shims.unpack_url(
TypeError: unpack_url() missing 1 required positional argument: 'verbosity'
add platformdirs failed:
Traceback (most recent call last):
  File<EMAIL_ADDRESS>line 58, in run
    result = self.fn(*self.args, **self.kwargs)
  File "/usr/local/Cellar/pdm/1.12.7/libexec/lib/python3.10/site-packages/pdm/installers/synchronizers.py", line 185, in install_candidate
    self.manager.install(can)
  File "/usr/local/Cellar/pdm/1.12.7/libexec/lib/python3.10/site-packages/pdm/installers/manager.py", line 38, in install
    installer(candidate.build(), self.environment, candidate.direct_url())
  File "/usr/local/Cellar/pdm/1.12.7/libexec/lib/python3.10/site-packages/pdm/models/candidates.py", line 304, in build
    self.prepare()
  File "/usr/local/Cellar/pdm/1.12.7/libexec/lib/python3.10/site-packages/pdm/models/candidates.py", line 257, in prepare
    downloaded = pip_shims.unpack_url(
TypeError: unpack_url() missing 1 required positional argument: 'verbosity'
add pycodestyle failed:
Traceback (most recent call last):
  File<EMAIL_ADDRESS>line 58, in run
    result = self.fn(*self.args, **self.kwargs)
  File "/usr/local/Cellar/pdm/1.12.7/libexec/lib/python3.10/site-packages/pdm/installers/synchronizers.py", line 185, in install_candidate
    self.manager.install(can)
  File "/usr/local/Cellar/pdm/1.12.7/libexec/lib/python3.10/site-packages/pdm/installers/manager.py", line 38, in install
    installer(candidate.build(), self.environment, candidate.direct_url())
  File "/usr/local/Cellar/pdm/1.12.7/libexec/lib/python3.10/site-packages/pdm/models/candidates.py", line 304, in build
    self.prepare()
  File "/usr/local/Cellar/pdm/1.12.7/libexec/lib/python3.10/site-packages/pdm/models/candidates.py", line 257, in prepare
    downloaded = pip_shims.unpack_url(
TypeError: unpack_url() missing 1 required positional argument: 'verbosity'
add pyflakes failed:
Traceback (most recent call last):
  File<EMAIL_ADDRESS>line 58, in run
    result = self.fn(*self.args, **self.kwargs)
  File "/usr/local/Cellar/pdm/1.12.7/libexec/lib/python3.10/site-packages/pdm/installers/synchronizers.py", line 185, in install_candidate
    self.manager.install(can)
  File "/usr/local/Cellar/pdm/1.12.7/libexec/lib/python3.10/site-packages/pdm/installers/manager.py", line 38, in install
    installer(candidate.build(), self.environment, candidate.direct_url())
  File "/usr/local/Cellar/pdm/1.12.7/libexec/lib/python3.10/site-packages/pdm/models/candidates.py", line 304, in build
    self.prepare()
  File "/usr/local/Cellar/pdm/1.12.7/libexec/lib/python3.10/site-packages/pdm/models/candidates.py", line 257, in prepare
    downloaded = pip_shims.unpack_url(
TypeError: unpack_url() missing 1 required positional argument: 'verbosity'
add tomli failed:
Traceback (most recent call last):
  File<EMAIL_ADDRESS>line 58, in run
    result = self.fn(*self.args, **self.kwargs)
  File "/usr/local/Cellar/pdm/1.12.7/libexec/lib/python3.10/site-packages/pdm/installers/synchronizers.py", line 185, in install_candidate
    self.manager.install(can)
  File "/usr/local/Cellar/pdm/1.12.7/libexec/lib/python3.10/site-packages/pdm/installers/manager.py", line 38, in install
    installer(candidate.build(), self.environment, candidate.direct_url())
  File "/usr/local/Cellar/pdm/1.12.7/libexec/lib/python3.10/site-packages/pdm/models/candidates.py", line 304, in build
    self.prepare()
  File "/usr/local/Cellar/pdm/1.12.7/libexec/lib/python3.10/site-packages/pdm/models/candidates.py", line 257, in prepare
    downloaded = pip_shims.unpack_url(
TypeError: unpack_url() missing 1 required positional argument: 'verbosity'

See /var/folders/59/5yr8qg9n6gl1g9hqtgs127rmn4qv12/T/pdm-install-hdv29cnt.log for detailed debug log.
[InstallationError]: Some package operations are not complete yet
Add '-v' to see the detailed traceback

============================================================================================================================================ log end ============================================================================================================================================
ERROR: could not install deps []; v = InvocationError('/usr/local/bin/pdm install -p .tox/lint --no-default --group lint --no-self', 1)
typecheck create: /Users/gustavo.barrios/Documents/Projects/bash-log2nl/.tox/typecheck
typecheck pdminstall: ['typecheck']
ERROR: invocation failed (exit code 1), logfile: /Users/gustavo.barrios/Documents/Projects/bash-log2nl/.tox/typecheck/log/typecheck-9.log
=========================================================================================================================================== log start ===========================================================================================================================================
Synchronizing working set with lock file: 4 to add, 0 to update, 0 to remove

Install mypy-extensions 0.4.3 failed
Install tomli 2.0.0 failed
Install typing-extensions 4.0.1 failed
Install mypy 0.931 failed
  Retry failed jobs
Install typing-extensions 4.0.1 failed
Install mypy-extensions 0.4.3 failed
Install tomli 2.0.0 failed
Install mypy 0.931 failed

ERRORS:
add typing-extensions failed:
Traceback (most recent call last):
  File<EMAIL_ADDRESS>line 58, in run
    result = self.fn(*self.args, **self.kwargs)
  File "/usr/local/Cellar/pdm/1.12.7/libexec/lib/python3.10/site-packages/pdm/installers/synchronizers.py", line 185, in install_candidate
    self.manager.install(can)
  File "/usr/local/Cellar/pdm/1.12.7/libexec/lib/python3.10/site-packages/pdm/installers/manager.py", line 38, in install
    installer(candidate.build(), self.environment, candidate.direct_url())
  File "/usr/local/Cellar/pdm/1.12.7/libexec/lib/python3.10/site-packages/pdm/models/candidates.py", line 304, in build
    self.prepare()
  File "/usr/local/Cellar/pdm/1.12.7/libexec/lib/python3.10/site-packages/pdm/models/candidates.py", line 257, in prepare
    downloaded = pip_shims.unpack_url(
TypeError: unpack_url() missing 1 required positional argument: 'verbosity'
add tomli failed:
Traceback (most recent call last):
  File<EMAIL_ADDRESS>line 58, in run
    result = self.fn(*self.args, **self.kwargs)
  File "/usr/local/Cellar/pdm/1.12.7/libexec/lib/python3.10/site-packages/pdm/installers/synchronizers.py", line 185, in install_candidate
    self.manager.install(can)
  File "/usr/local/Cellar/pdm/1.12.7/libexec/lib/python3.10/site-packages/pdm/installers/manager.py", line 38, in install
    installer(candidate.build(), self.environment, candidate.direct_url())
  File "/usr/local/Cellar/pdm/1.12.7/libexec/lib/python3.10/site-packages/pdm/models/candidates.py", line 304, in build
    self.prepare()
  File "/usr/local/Cellar/pdm/1.12.7/libexec/lib/python3.10/site-packages/pdm/models/candidates.py", line 257, in prepare
    downloaded = pip_shims.unpack_url(
TypeError: unpack_url() missing 1 required positional argument: 'verbosity'
add mypy-extensions failed:
Traceback (most recent call last):
  File<EMAIL_ADDRESS>line 58, in run
    result = self.fn(*self.args, **self.kwargs)
  File "/usr/local/Cellar/pdm/1.12.7/libexec/lib/python3.10/site-packages/pdm/installers/synchronizers.py", line 185, in install_candidate
    self.manager.install(can)
  File "/usr/local/Cellar/pdm/1.12.7/libexec/lib/python3.10/site-packages/pdm/installers/manager.py", line 38, in install
    installer(candidate.build(), self.environment, candidate.direct_url())
  File "/usr/local/Cellar/pdm/1.12.7/libexec/lib/python3.10/site-packages/pdm/models/candidates.py", line 304, in build
    self.prepare()
  File "/usr/local/Cellar/pdm/1.12.7/libexec/lib/python3.10/site-packages/pdm/models/candidates.py", line 257, in prepare
    downloaded = pip_shims.unpack_url(
TypeError: unpack_url() missing 1 required positional argument: 'verbosity'
add mypy failed:
Traceback (most recent call last):
  File<EMAIL_ADDRESS>line 58, in run
    result = self.fn(*self.args, **self.kwargs)
  File "/usr/local/Cellar/pdm/1.12.7/libexec/lib/python3.10/site-packages/pdm/installers/synchronizers.py", line 185, in install_candidate
    self.manager.install(can)
  File "/usr/local/Cellar/pdm/1.12.7/libexec/lib/python3.10/site-packages/pdm/installers/manager.py", line 38, in install
    installer(candidate.build(), self.environment, candidate.direct_url())
  File "/usr/local/Cellar/pdm/1.12.7/libexec/lib/python3.10/site-packages/pdm/models/candidates.py", line 304, in build
    self.prepare()
  File "/usr/local/Cellar/pdm/1.12.7/libexec/lib/python3.10/site-packages/pdm/models/candidates.py", line 257, in prepare
    downloaded = pip_shims.unpack_url(
TypeError: unpack_url() missing 1 required positional argument: 'verbosity'

See /var/folders/59/5yr8qg9n6gl1g9hqtgs127rmn4qv12/T/pdm-install-5tf3zdbk.log for detailed debug log.
[InstallationError]: Some package operations are not complete yet
Add '-v' to see the detailed traceback

============================================================================================================================================ log end ============================================================================================================================================
ERROR: could not install deps []; v = InvocationError('/usr/local/bin/pdm install -p .tox/typecheck --no-default --group typecheck --no-self', 1)
____________________________________________________________________________________________________________________________________________ summary ____________________________________________________________________________________________________________________________________________
ERROR:   lint: could not install deps []; v = InvocationError('/usr/local/bin/pdm install -p .tox/lint --no-default --group lint --no-self', 1)
ERROR:   typecheck: could not install deps []; v = InvocationError('/usr/local/bin/pdm install -p .tox/typecheck --no-default --group typecheck --no-self', 1)

bash-log2nl on  master [!] via 🐍 v2.7.16 took 12s
❯

The problem is from pdm/models/candidates.py  the verbosity is not being passed and thus breaking the whole thing, I've just tested changing function call and it works fine now.
Is this intended? I also checked pip to see if they changed the function signature but I don't see any changes related to it.
                downloaded = pip_shims.unpack_url(
                    self.link,
                    ireq.source_dir,
                    downloader,
                    hashes=ireq.hashes(False),

what is the version of PDM and pip in the tox env?

❯ pdm -V && pdm run python -m pip -V
Python Development Master (PDM), version 1.12.7
pip 22.0.2 from /usr/local/lib/python3.10/site-packages/pip (python 3.10)

Related to https://github.com/pdm-project/pdm/issues/874


Track invocation logs in the eventing module

This is primarily for debugging purposes.

If you want this feature to be implemented, give it a thumbs up reaction, so that we can determine which features are important to you.
👍

Done


WebView didn't show up Camera function with MAUI android platoform .net 8.0

Type of issue
Other (describe below)
Description
[Enter feedback here]
My WebView does not show the camera functionality when the user interacts with the web page. This issue affects the ability to capture or upload images from the page. I have already added the necessary camera-related permissions to the AndroidManifest.xml file and tried using the WebChromeClient method, but neither solution worked for me. Could you please provide sample source code or share working code if possible?
Page URL
https://learn.microsoft.com/en-us/dotnet/maui/android/platform-specifics/webview-mixed-content?view=net-maui-8.0
Content source URL
https://github.com/dotnet/docs-maui/blob/main/docs/android/platform-specifics/webview-mixed-content.md
Document Version Independent Id
8053e62d-9d3a-90fd-f59f-3f6427579147
Article author
@davidbritch
Metadata

ID: 8053e62d-9d3a-90fd-f59f-3f6427579147
Service: dotnet-mobile
Sub-service: dotnet-maui

Hi @eephyu
Take a look at https://learn.microsoft.com/en-us/dotnet/maui/user-interface/controls/webview?view=net-maui-8.0&pivots=devices-android#handle-permissions-on-android

Hi David,
Thank you for your help.
I had been followed given link documentation from day 1 and it wasn't working. That's why I am looking for working solution. You may have a look this repository [https://github.com/eephyu/WebViewCameraDemo]
as I created demo for anyone who can help me on this issue.
I had a page where can define html url and the next page will show the form to submit employee information with upload photo. You may follow default url that I had been hard coded or change based on your preferences.
https://github.com/eephyu/WebViewCameraDemo


Update the chips disabled state

COS:

Disabled should be removed from the variant, and change to a isDisabled property
add data-disabled and aria-disabled to the element when isDisabled is true
Add in the documentation that there is a disabled property available, but this property is only expected when the containing control is disabled, and is not meant to be used as a standalone chip

This is being done as part of the merging of Chip and Tag


Fix target dialog size, remove maximize button

Can you provide a quick description what the problem was and what is changed now? I haven't fully understood the sizing topic in Qt yet and its hard for me to judge whats happening here. Screenshots might help as well


Enforce proper commit formatting

Commits need to be formatted in the way semantic-release is expecting. We should investigate ways to enforce proper commit formatting, whether this is through husky, a CI based way, or some other alternative.

No Plan on working on this.


Describe what this fork brings in

Signed-off-by: Leandro Motta Barros<EMAIL_ADDRESS>Change-type: patch

@balena-ci I self-certify!


Change campaigns leaderboard datasource URL

Summary
The Safe Locking Service implementation changed recently, and the leaderboard by campaign endpoint is not under the v2 prefix anymore.
These changes can be seen here (approval is pending): https://github.com/safe-global/safe-locking-service/pull/100/files#diff-d790dada13951d227666cb46aa0ccc89033037f7a7a5e1ed86e9bbfbbe0ef65b
This PR modifies the datasource endpoints and renames functions/variables accordingly.
Changes

Changes the campaign leaderboard datasource URL from /v2/leaderboard/:campaignId to /v1/campaigns/:campaignId/leaderboard
Renames datasource functions accordingly.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

5 of 5 (100.0%)  changed or added relevant lines in 4 files are covered.
2 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.02%) to 92.848%

Files with Coverage Reduction
New Missed Lines
%

src/routes/transactions/entities/tests/human-description.builder.ts
2
80.0%

Totals

Change from base Build<PHONE_NUMBER>:
-0.02%

Covered Lines:
7091

Relevant Lines:
7345

💛  - Coveralls


can we use this project?

Hi,
We'd like to use this project in SpinDrops(.org), but there's no license on it - how do you feel about licensing?
Cheers,
Michael

Not a problem. I just added one in #2. My original intent was parallelize the underlying nanosvg library to work on the GPU and do fast font rendering, but I never had the time.

Awesome, thanks!


Crash when serializing division with LaTeX

Version: 0.4.4
Steps:

Initialize Compute Engine
Set jsonSerializationOptions.metadata = ['latex']
Parse 1/x
Try to print the MathJson for the resulting BoxedExpression.

Here's a quick node session replicating the problem:
> const ComputeEngine = require("@cortex-js/compute-engine").ComputeEngine
undefined
> let myCe = new ComputeEngine()
undefined
> myCe.parse("1/x").json
[ 'Divide', 1, 'x' ]
> myCe.jsonSerializationOptions.metadata = ['latex']
[ 'latex' ]
> myCe.parse("1/x").json
Uncaught TypeError: Converting circular structure to JSON
    --> starting at object with constructor 'global'
    --- property 'global' closes the circle
    at JSON.stringify (<anonymous>)
    at /Users/bengold/brilliant/node_modules/@cortex-js/compute-engine/dist/compute-engine.min.js:2:69692
    at Ne.serialize (/Users/bengold/brilliant/node_modules/@cortex-js/compute-engine/dist/compute-engine.min.js:2:69710)
    at ke.serialize (/Users/bengold/brilliant/node_modules/@cortex-js/compute-engine/dist/compute-engine.min.js:2:74791)
    at zt.serialize (/Users/bengold/brilliant/node_modules/@cortex-js/compute-engine/dist/compute-engine.min.js:2:267194)
    at vi (/Users/bengold/brilliant/node_modules/@cortex-js/compute-engine/dist/compute-engine.min.js:2:140335)
    at Oi.get json [as json] (/Users/bengold/brilliant/node_modules/@cortex-js/compute-engine/dist/compute-engine.min.js:2:163316)

Good find.
The problem occurred when requiring LaTeX metadata in a MathJSON output for a number, i.e. in the example above, it's actually "1" that causes an error to be thrown...
Fixed in 64e15037ddff7a3dbf2e0854729882aaa10bcb2e

Ahhh, that's a funny one! Fantastic, thanks.
Relatedly, we did run into a situation where we wanted the latex to be preserved for numbers -- if the user types in 1e3, we'd like to know both that they typed 1e3 AND that it's equal to 1000. Similarly for 000.113!

Yeah, that makes sense.
Right now, I think the latex output is omitted only if the serialization of the numeric value is identical to the generated (or input) LaTeX, but perhaps it would be simpler to just always include the LaTeX when it is requested (i.e. via the metadata prop), even if it was redundant with the numeric serialization...

The consistency seems totally fine to me.
When you get a chance, can you cut a release with 64e1503? We'd love to install directly to that hash, but our version of node is too low to do the rebuilding required :(

I've published<EMAIL_ADDRESS>that incorporate these changes and a corresponding<EMAIL_ADDRESS>

Thanks a million, Arno! Super excited to get these fixes (and some of the new features in compute engine) integrated :D


Integrate MARS atlas

suggested by Andrea Brovelli
atlas available at http://meca-brain.org/software/marsatlas-colin27/

Carrying to data integration.

re: data integration, should this not be an issue at https://jugit.fz-juelich.de/t.dickscheid/brainscapes-configurations/-/issues ?

Added to road map but we can create an issue after it is discussed perhaps?


Non-functional requirements

It would be very useful to identify the top non-functional requirements for the DINA system.
These requirements should guide general direction and influence architectural and design decisions. As a multi-modules, multi-institutions system, I would suggest the following list:

Maintainability
Testability
Documentation (code and user documentation)
Interoperability (e.g. JSON-API)
Extensibility

It doesn't mean other non-functional requirements are not important but more that in case of conflict, the requirement from the list above should be prioritized. e.g. Maintainability vs Performance

Agree, identifying these at high-level can guide the development and make sure if we agree on them. Currently some of there have been defined or suggested in the guidelines in more detailed way, but stating them on high-level can be more useful and give flexibility to find the a good implementation.


Add docker files for gazebo compilation

Address issue #29
Please @ernestmc check this PR

@garyservin you have a Dockerfile for intel now, please test it and let me know if it works.

On docker folder, you need to use the Makefile from that folder

@Shokman, ok building now. Can you specify the path in the README?

Did you check the nvidia driver version right?

What do you mean? Shouldn't I build with my current driver? I thought that was what nvidia-smi was returning. Did I get something wrong?

That is perfect. I just wanted to be sure that you specified your driver if it wasn't the 367.
PS: Readme edited.

Great, thanks!

@Shokman, trying to build the image and got the following error:
$ make gazebo7-intel gazebo7-intel
docker build  --build-arg gazebo_commit="64979ae" -t gazebo7 gazebo7
Sending build context to Docker daemon  5.12 kB
Step 1 : FROM ubuntu:xenial
Get https://registry-1.docker.io/v2/library/ubuntu/manifests/xenial: unauthorized: incorrect username or password
make: *** [gazebo7] Error 1

Do I need to configure something else?

Mmm.. Do you have your user added to the docker group? Also you can try to run the makefile with sudo.

@Shokman finally managed to build the dockerfile, but fails to open. Steps:
$ make NVIDIA_DRIVER="nvidia-340" gazebo7-nvidia gazebo7-nvidia
$  cd docker/
[/docker] $ ./run_simulator gazebo7-nvidia gazebo7-nvidia

and in the docker image:
gazebo@CrazyGoat:~/ws/generated_worlds$ gazebo city.world
X Error of failed request:  BadValue (integer parameter out of range for operation)
  Major opcode of failed request:  153 (GLX)
  Minor opcode of failed request:  3 (X_GLXCreateContext)
  Value in failed request:  0x0
X Error of failed request:  BadValue (integer parameter out of range for operation)
    Serial number of failed request:  24Major opcode of failed request:  153
  Current serial number in output stream:  25 (GLX)

  Minor opcode of failed request:  3 (X_GLXCreateContext)
  Value in failed request:  0x0
  Serial number of failed request:  24
  Current serial number in output stream:  25

yeah, that is a driver issue, check that the version of your driver's package is the same in the host and the docker image.

You might need to reinstall in your host the graphics card driver

In both places I get the same:
$ cat /proc/driver/nvidia/version
NVRM version: NVIDIA UNIX x86_64 Kernel Module  340.96  Sun Nov  8 22:33:28 PST 2015
GCC version:  gcc version 4.8.4 (Ubuntu 4.8.4-2ubuntu1~14.04.3)

Inside docker nvidia-smi fails:
gazebo@CrazyGoat:~/ws$ nvidia-smi
Failed to initialize NVML: Unknown Error

FWIW:
gazebo@CrazyGoat:~/ws$ sudo find / -name 'libnvidia-ml*'
/usr/lib/nvidia-340/libnvidia-ml.so.340.98
/usr/lib/nvidia-340/libnvidia-ml.so.1
/usr/lib/nvidia-340/libnvidia-ml.so
/usr/lib32/nvidia-340/libnvidia-ml.so.340.98
/usr/lib32/nvidia-340/libnvidia-ml.so.1
/usr/lib32/nvidia-340/libnvidia-ml.so

Ok, I'll give that a shot

Also I never tried with 340, you should check with a newer version too if that doesn't work.

btw, no dice with reinstalling things in the host

Please check that the host and docker's graphics card driver repo matches using
$ try apt-cache policy nvidia-xxx

You can change the repository being used here:
https://github.com/Shokman/terminus/blob/d52f204f7c4e52a4b80b3fcdb8cc21f3dcec738c/docker/gazebo7-nvidia/Dockerfile#L15

O, now it gets stuck on somewhere else, it tries to install the driver and asks the user about keyboard layout and the stays there forever.
See https://gist.github.com/garyservin/de299cde2f85f831442e5fbc0f54c2f5 for the log

@garyservin I updated the dockerfile. I tested it in my computer using prime and it works, let me know if it is ok now.

Alright, finally managed to get it working! @Shokman I commented out https://github.com/Shokman/terminus/blob/d52f204f7c4e52a4b80b3fcdb8cc21f3dcec738c/docker/gazebo7-nvidia/Dockerfile#L15 and rebuilt and it picked the right drivers. Not sure how do you want to handle that. Maybe add a use-graphics-drivers-ppa flag to the build script?

Excellent! we can add a buid argument in the makefile for that.

@Shokman where is gazebo installed after the build? Also, I don't see the /home/gazebo/ws/gazebo folder on my docker image, is that expected?

Gazebo is being installed in the default path. I made some modifications so we can access its code if you want to recompile it.

Ok, it seems to work for me too.

Can we merge this PR and close issue #29 then?

Yup!


get md5 value

hi
thanks for your work.
i want to get md5 value of signature for check in runtime my apk is orginal. your code back byte of all signature.
how can get this?

Hi. I updated my answer on SO .


[nrfconnect] Added possibility to use Lock commands in all-clusters-app

Problem
The All-clusters-app nRF Connect example did not support Lock commands invoked by the chip-tool.
Change overview
The feature map of the Door Lock Cluster has been set to 0,
and now all-clusters-app can process Lock/Unlock commands sent via chip-tool.
Testing
Tested manually on nRF52DK.

@Morozov-5F could you please review these to see whether empty callbacks returning true are spec-compliant if none of the interesting lock features are supported?

Bypassing known cirque issues


Render function on input removes reactivity

Version
2.5.17
Reproduction link
https://codesandbox.io/embed/oooq7o2q16?module=%2Fsrc%2FApp.vue
Steps to reproduce
Create a vue component js file with a render function which is simply an input and a value.
What is expected?
The input should stay reactive with the data, no matter if it's manually edited.
What is actually happening?
The input loses reactivity after being manually edited.
Extra info
https://stackoverflow.com/questions/53149991/render-function-on-input-removes-reactivity-in-vue

You are using attrs to set the value attribute. as soon as you edit the content of the input, the attribute's value is still updated in the DOM (you can check your console) but that attribute is no longer relevant to what is being displayed, because by spec, the value attribute is only the initial value, and as soon as the user changes it, it's no longer relevant even if you updater it later.
That's why in the render function generated by the template, Vue doesn't use attrs, it uses domProps. It looks something like this:
render(createElement) {
    return createElement("input", {
      domProps: { value: this.value }
    });
  }

Now, we don't change the attribute by changing the DOM, we change the property wiht javascript.
In vanilla javascript, the difference between the two concepts looks like this:
const el = document.querySelector('#yourelement')
// changing the attribute - this will have no effect once the user changes the input themselves:
el.setAttribute('value', 'new value')

// changing the DOM property - this will overwrite the changes that the user did:
el.value = 'new value'


Upgrade to babel 6

Fixes https://github.com/cloverfield-tools/cf-package/issues/41

This does not yet update the template/ generated code to babel6
Will add this before merge

><EMAIL_ADDRESS>build /home/ubuntu/cf-package
> babel lib --out-dir build

Error: Couldn't find preset "es2015" relative to directory "/home/ubuntu/cf-package"

fixed that one, but now i'm seeing a npm run audit error with nsp in circle-CI, don't know how to fix it yet

looks like audit fails on master also

Maybe node 0.10 is too old for all this? Switch to v4?

I'm on v4. updating nsp to v2 and it seems to work. another CI check incoming

circleci uses node 0.10 for now

\o/

oh, ic. it doens't look like node version was the issue. CircleCI is good now

note, that this fixes issue #41 and updates cf-package to babel 6. but the template is still on babel 5


I Don’t Understand FunctionCallToolDefinition - Request for Help

🚀 The feature, motivation and pitch
Please, I need a tool defined as FunctionCallToolDefinition to be executed by llama stack run.
I tried this definition and encountered the following error. I believe remote_execution parameter  doesn’t work as expected.
{ "input_shields": [ "string" ], "output_shields": [ "string" ], "type": "function_call", "function_name": "string", "description": "string", "parameters": { "property1": { "param_type": "string", "description": "string", "required": true, "default": { } }, "property2": { "param_type": "string", "description": "string", "required": true, "default": { } } }, "remote_execution": { "url": "http://example.com/", "method": "GET", "params": { "property1": { }, "property2": { } }, "headers": { "property1": { }, "property2": { } }, "body": { "property1": { }, "property2": { } } } }
                AgentConfigToolFunctionCallToolDefinition(                     type = "function_call",                     function_name = "PesquisaWebCPF",                     description = "Tendo um ou mais CPFs, utilize essa função para pesquisar todos os dados de um ou mais funcionários por CPF. Os dados retornados incluem dados cadastrais, financeiros, de férias, afastamentos, dependentes, endereço, telefones, e emails.",                     input_shields = ["string", "string", "string"],                     output_shields =  ["string", "string", "string"],                     parameters = {                         "cpfs": {                             "param_type": "array",                             "description": "Uma lista de números de CPF para pesquisa (formato: XXXXXXXXXXX).",                             "required": True                         }                     },                     remote_execution = {                         "url": "http://localhost/a.php",                         "method": "GET",                         "params": {                             "cpfs": "{cpfs}"                         }                     }                 ),
However, I don’t actually need remote_execution; instead, I’d like to embed a function directly into the agent by developing it as a tool in builtin.py. For example:class FunctionCall(SingleMessageBuiltinTool):
when calling remote_execution I get the following error:
Traceback (most recent call last):
File "/home/guilherme/.local/lib/python3.10/site-packages/starlette/_exception_handler.py", line 42, in wrapped_app
await app(scope, receive, sender)
File "/home/guilherme/.local/lib/python3.10/site-packages/starlette/routing.py", line 73, in app
response = await f(request)
File "/home/guilherme/.local/lib/python3.10/site-packages/fastapi/routing.py", line 346, in app
raise validation_error
fastapi.exceptions.RequestValidationError: [{'type': 'model_attributes_type', 'loc': ('body', 'agent_config', 'tools', 0, 'function_call', 'remote_execution', 'url'), 'msg': 'Input should be a valid dictionary or object to extract fields from', 'input': 'http://localhost/a.php'}]
INFO: <IP_ADDRESS>:46906 - "POST /agents/create HTTP/1.1" 400 Bad Request
Thanks,
Guilherme
Alternatives
No response
Additional context
No response

The error suggests that incorrect request params to /agents/create. remote_execution is a placeholder and not being consumed currently.
You can find a sample example using function_call in https://github.com/meta-llama/llama-stack-apps/blob/22deb4a795632b630ef3ac9c5072b6bb98af9d67/examples/agents/e2e_loop_with_custom_tools.py#L44-L65

This is one of the examples that doesn't work. I have already mentioned this in other topics. Moreover, the example is confusing because it doesn't show the execution being done with llama stack run but rather separately on the client side. In the example, I don’t see the integration between a custom function and other memory functions being part of the neural network’s execution plan.
It would be helpful for people like me if the development team’s responses were more detailed, spending more time understanding the issue. For instance, there is a manual, and you mention that the remote_execution parameter in FunctionCallToolDefinition cannot be consumed. So, how can one know what works and what doesn’t within the current documentation?
Your example e2e_loop_with_custom_tools.py doesn’t run using ollama; it gives the following error: ValueError: Shield llama_guard not served by provider: meta-reference. Make sure there is a Safety provider serving this shield.
It is not possible to run without ollama because, through meta-reference, I couldn’t find a way to manage more than one network card to distribute max_seq_len in memory across two or more cards, and provider_type meta-reference also leads to VRAM overflow.
I have been studying your library daily because I believe in the project, but the brief responses pointing to issues that do not work or lack relevance to the integrated execution of the tools provided on the Llama Stack server make it very challenging.
I am going to develop my own plugin on the server, similar to those that exist today for PhotogenTool, BingSearch, and BraveSearch. It would be more helpful if you could guide me on the path I should take to add this new plugin and inform me if your team plans to improve the integration of a custom function directly on the Llama Stack server so that this custom function becomes part of the execution plan for turn steps.
Could you please help me, sir?
Thank you very much.

@JoseGuilherme1904 Thanks for the detailed feedback, and I'm sorry you found the existing pointers is not helpful.

Moreover, the example is confusing because it doesn't show the execution being done with llama stack run but rather separately on the client side.

You are right. The example with custom tool using the function_call tool in AgentConfig's tools as ToolDefinition (code pointer).
For Builtin tools, these will be executed on the Llama Stack server. For custom tools, these are defined by client and executed by client after getting Agent's response, and parsing the output (code).
By implementing FunctionCall(SingleMessageBuiltinTool), this will be a CustomTool that is executed on the client, using function_call tool definition.
For current supported Builtin tools (e.g. PhotogenTool, BingSearch, BraveSearch) that are executed on the llama stack server, you may find example implemenetations in this code pointer: https://github.com/meta-llama/llama-stack/blob/main/llama_stack/providers/inline/agents/meta_reference/tools/builtin.py#L2

example e2e_loop_with_custom_tools.py doesn’t run using ollama; it gives the following. error: ValueError: Shield llama_guard not served by provider: meta-reference. Make sure there is a Safety provider serving this shield.

This is a separate common error that we are addressing. You can temporarily bypass running safety shields with the script by using the --disable-safety flag.

I have been studying your library daily because I believe in the project, but the brief responses pointing to examples that do not work or lack relevance to the integrated execution of the tools provided on the Llama Stack server make it very challenging.

Thanks for your feedback! We are actively working on improving the documentation and overall usage of our APIs. For example, we have WIP of using custom tools here

I am going to develop my own plugin on the server, similar to those that exist today for PhotogenTool, BingSearch, and BraveSearch. It would be more helpful if you could guide me on the path I should take to add this new plugin and inform me if your team plans to improve the integration of a custom function directly on the Llama Stack server so that this custom function becomes part of the execution plan for turn steps.

To add the builtin tool on the server, you can take a look at this code pointer where existing builtin tools are implemented. We are also in the process of refactoring and improving the registration of tools in Agents, and will keep you updated on our progress!
Hopefully that answers your question a bit. Happy to chat with you in more detail!

Wow, thank you so much yanxi0830. I’ll read and study everything very carefully and attentively.
Thank you, thank you so much.


Only add Camel dependencies for a deployment when used

With automatic inclusion of Camel Components in deployments we allow exploitation of any security vulnerabilities which exist in camel. If one deployment uses camel, other deployments not using camel could still be vulnerable to camel vulnerabilities. It would be preferable to have an implicit deployment trigger to include camel only when it was being used.
In implicit deployment trigger could be the inclusion of a @Resource(java:jboss/camel/context/system-context), or @ContextName could trigger the inclusion of the Camel Components. For the change to be effective, camel should only be loaded in the deployment where it is being used. For more for other implicit deployment triggers, check the Wildfly documentation
https://docs.jboss.org/author/display/WFLY9/Implicit+module+dependencies+for+deployments.
CrossRef: https://issues.jboss.org/browse/ENTESB-4085

The argument that the user deployment should not be able to load Camel classes is not valid. Any deployment can load any publicly exposed type from any module that is in the hierarchy.
Is there maybe another argument to wire camel in based on some trigger? The trigger we currently have is the existence of the Camel subsystem in the config.

Let's compare Camel to the CDI subsystem. A deployment wouldn't be able to load any CDI class until the deployment trigger (beans.xml) caused the wired in those dependencies.
With Camel as it stands you can load it's classes without any deployment trigger.

You cannot do
new DefaultCamelContext();

but you can always do
loader.loadModule("...camel.core").getClassLoader().loadClass("...DefaultCamelContext")

CDI is a standard and has (a standard) descriptor which is mandatory. Camel does not have such a descriptor/discriminator - we would need to invent it. Our value proposition is however that you can simply access Camel from JavaEE without additional config.
Classloading convenience is may not be a strong enough argument to introduce such a descriptor/discriminator

Hiram convinced me that we should do this on the basis of deserialization frameworks that work on the TCCL. It is feasible that an object gets instantiated by an external attacker that then executes an arbitrary cmd on the target system.

There are currently three triggers that can be used to enable Camel for a deployment

a deployment that contains a *-camel-context.xml descriptor
a deployment that contains a type annotated with @CamelAware
a deployment that contains a type annotated with @ContextName


Improve image_picker android dependencies

Fixes https://github.com/flutter/flutter/issues/20482

image_picker only depends on android.support.v4.content.FileProvider and android.support.v4.app.ActivityCompat. Both are included in the utils package.
The full appcompat is not needed.

I'm not sure why the old build gradle used api instead of implementation for the dependency. api is not required, so I fixed that as well.

See also this PR https://github.com/flutter/plugins/pull/712 which I'm waiting for it to be merged

@goderbauer Done.
While we are at it, can you take a look at https://github.com/flutter/plugins/pull/716?

I think the analyzer issues are now resolved? I bumped the version number again because 0.4.7 was already taken

Can you also update the version in the pubspec.yaml?

done

This is live on pub now.

@goderbauer we started getting issues with this today. Although this might seem a small change but its not a revision change. Because of the dependency change it should at least be a minor version change. I believe that's in the semver recommendations. Either way, it breaks a lot of builds that use image_picker: "^0.4.6" caret restriction.
Currently any 3rd party library, firebase/google or other that depend on play-services currently will break. All of the play service libraries depend on play-services-basement. Which in it's latest version com.google.android.gms:play-services-basement:15.0.1 depends on com.android.support:support-v4:26.1.0.
So for the moment we're building against image_picker 0.4.7.
https://mvnrepository.com/artifact/com.google.android.gms/play-services-basement/15.0.1

@slightfoot To fix this, add this to your build.gradle:
dependencies {
    ...
    implementation 'com.android.support:support-v4:27.1.1'
}

@goderbauer The dependency change introduced by this PR caused issues for quite a few people (at least 2 reports today. I also experienced issues when I added Firebase to my app a few days ago, because Firebase ships with an old version of the support library.
To fix this, one must explicitly add the full support library as a dependency.
Maybe it would be better to add the full support library dependency again? It is technically not required for image_picker (and increases the APK size by 1MB), but makes it easier to use for people who use Firebase or other outdated libraries.

@sir-boformer For now we should probably change the dependency back. Do you want to send a PR?

I'm having this issue trying to using the current package of image_picker


Correcting initial value for private file_version

revert changes.

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@975f97f). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master      #50   +/-   ##
=========================================
  Coverage          ?   69.79%
=========================================
  Files             ?        6
  Lines             ?      394
  Branches          ?       74
=========================================
  Hits              ?      275
  Misses            ?       63
  Partials          ?       56

Impacted Files
Coverage Δ

src/process_data.c
54.54% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 975f97f...4b8be74. Read the comment docs.


Add typing for barcode

barcode/barcode.d.ts
check list

[ ] is collect naming convention?

https://www.npmjs.com/package/barcode
http://bower.io/search/?q=barcode
others?

[X] has a test file? (barcode/barcode-tests.ts or others)
[ ] pass the Travis-CI test?

thanks mate!


Can't publish package!

I am in china, and I want to publish a  package  to pub, when i run pub publish , I receive some error:
Waiting for your authorization...
Authorization received, processing...
Connection failed (OS Error: No route to host, errno = 65), address = accounts.google.com, port = 443

and I run curl accounts.google.com

<TITLE>Moved Temporarily</TITLE>

Moved Temporarily

The document has moved here.

I have used the shadowsocks to proxy my network, and still failed, but the google.com is available in browser.
any other ways to publish packages to pub ?

@wendux: were you able to resolve this?

yes I resolved by using  VPN.  sad......


darkred and red colors are swaped

https://github.com/graphite-project/graphite-web/blob/0.9.x/webapp/graphite/render/glyph.py#L59
https://github.com/graphite-project/graphite-web/blob/0.9.x/webapp/graphite/render/glyph.py#L44
They are actually swaped. Red is darker than darkred.

@deniszh this is still happens in recent 1.1 :)

same thing is also true for green <-> darkgreen, blue <-> darkblue,

Agreed, will make PR. Thanks!


How to find the size of decodedFrame2() output

Hi,
I'm facing issue on few android devices while copying the data from DecodeFrame2()
This is my code:
    uint8_t* m_yuvData[3];
    SBufferInfo yuvDataInfo;
memset(&yuvDataInfo, 0, sizeof(SBufferInfo));
m_yuvData[0] = NULL;
m_yuvData[1] = NULL;
m_yuvData[2] = NULL;
     DECODING_STATE decodingState = m_decoder->DecodeFrame2(bufferData, bufferDataSize, m_yuvData, &yuvDataInfo);

if(yuvDataInfo.iBufferStatus == 1)
{
        int yStride = yuvDataInfo->UsrData.sSystemBuffer.iStride[0];
    	int uvStride = yuvDataInfo->UsrData.sSystemBuffer.iStride[1];
        uint32_t width = yuvDataInfo->UsrData.sSystemBuffer.iWidth;
       uint32_t height = yuvDataInfo->UsrData.sSystemBuffer.iHeight;
       size_t yDataSize = (width * height) + (height * yStride);
       size_t uvDataSize = (((width * height) / 4) + (height * uvStride));
            size_t requiredSize = yDataSize + (2 * uvDataSize);
           	uint8_t* yuvBufferedData = (uint8_t*)malloc(requiredSize);

.// when i move yuvData[0] to another location i am getting crash.
memcpy(yuvBufferedData, yuvData[0], yDataSize);
memcpy(yuvBufferedData + yDataSize, yuvData[1], uvDataSize);
memcpy(yuvBufferedData + yDataSize + uvDataSize, yuvData[2], uvDataSize);
}
The above code snippet is working on high end android devices. but on few android devices after processing first frame, second frame onwards i am getting crash in first memcpy() statement.
What is wrong in this code? and how to calculate the buffer size from the output of DecodeFrame2().
If i process alternative frames(instead of 30, just 15 frames alternative ones), it is copying fine.
Please help me to fix this?

It is for Standard resolution images (640*480)

This is for 640 * 480 resolution. I am receiving Frame from Camera, and uncompressing the frame(Demux)->decoding frame(H264)->YUVtoRGB conversion. These all happening in single thread. Till decode part its working fine. I've written the output of Decoder into .yuv file and played on YUV player. It is playing fine. But when i tried to Copy the output of Decode into another buffer(for YUV to RGB conversion), it is crashing on low end devices. First frame completing all the stages successfully. Second frame failing consistently.

which module did the second frame fail in?

yDataSize is wrong, it should be  (height * yStride);
uvDataSize should be (height/2 * uvStride)


GH-7348:remove duplicate AcceptanceTestBase

PR description
Fixed Issue(s)

fixes #7348
Thanks for sending a pull request! Have you done the following?

[ ] Checked out our contribution guidelines?
[ ] Considered documentation and added the doc-change-required label to this PR if updates are required.
[ ] Considered the changelog and included an update if required.
[ ] For database changes (e.g. KeyValueSegmentIdentifier) considered compatibility and performed forwards and backwards compatibility tests

Locally, you can run these tests to catch failures early:

[ ] unit tests: ./gradlew build
[ ] acceptance tests: ./gradlew acceptanceTest
[ ] integration tests: ./gradlew integrationTest
[ ] reference tests: ./gradlew ethereum:referenceTests:referenceTests

@optimusprike looks good in principle but there's some compilation issues

@optimusprike are you still working on this/

closing due to inactivity


Deploy to Azure buttons ok?

I can't get the blue Deploy to Azure buttons to work.
Is there a trick for using these?

Which browser are you using? I found that it didn't work in Edge, but Chrome is fine.

Hi @johnd-ms,
Do you still experience problems with the Azure buttons for deployment? They work for me.
Regards,
Francisco


[Adaptive] Resource explorer does not pick up changes to files within a folder

Run a sample bot here. Set breakpoint here
Drop a new folder with one or more dialog files under \Dialogs\ folder.
Notice that you will see the breakpoint hit for the folder change but not for any of the individual .dialog files that have changed.

This issue is supposed to be fixed in this PR: https://github.com/microsoft/botbuilder-js/pull/2342


Vanhite Sprite pokes missing in the 1.4.0 version of the Texture Pack

I thint this does not need any further explanation, the sprites of the Vanhite pokes are all missing (not the model). There is a screenshoot as an example.

This is an issue with your resource pack. Restarting the client fixes this. Closing


cjs format should not replace "exports.default =" to "module.exports = " when "exports.default =" in last line

a reproduction or simple code  @pi0
https://github.com/gaoletian/mkdist-issues-192
// src/Foo.ts
export enum Type {
    Foo,
    Bar
}

export default class Action {}

// dist/Foo.js
"use strict";

Object.defineProperty(exports, "__esModule", {
  value: true
});
module.exports = exports.Type = void 0;
var Type = exports.Type = /* @__PURE__ */(Type2 => {
  Type2[Type2["Foo"] = 0] = "Foo";
  Type2[Type2["Bar"] = 1] = "Bar";
  return Type2;
})(Type || {});
class Action {}
module.exports = Action;

// test.js
const foo = require('./dist/Foo');
console.log(foo);
console.log(foo.Type);

$ node test.js
foo =  [class Action]
foo.Type = undefined

Hi! 👋
Firstly, thanks for your work on this project! 🙂
Today I used patch-package to patch<EMAIL_ADDRESS>for the project I'm working on.

Here is the diff that solved my problem:
diff --git a/node_modules/mkdist/dist/index.mjs b/node_modules/mkdist/dist/index.mjs
index 1403db8..7b1582a 100644
--- a/node_modules/mkdist/dist/index.mjs
+++ b/node_modules/mkdist/dist/index.mjs
@@ -59,7 +59,9 @@ const jsLoader = async (input, { options }) => {
   }
   const isCjs = options.format === "cjs";
   if (isCjs) {
-    contents = jiti("").transform({ source: contents, retainLines: false }).replace(/^exports.default = /gm, "module.exports = ").replace(/^var _default = exports.default = /gm, "module.exports = ").replace("module.exports = void 0;", "");
+    contents = jiti("")
+      .transform({ source: contents, retainLines: false })
+      .replace("module.exports = void 0;", "");
   }
   let extension = isCjs ? ".js" : ".mjs";
   if (options.ext) {

This issue body was partially generated by patch-package.

Hi dear @gaoletian. The syntax change is intentional to fix issues with certain bundlers. Would you please share your case which replacing exports.default to module.exports make issues? (a reproduction or simple code) 🙏🏼

a reproduction or simple code
https://github.com/gaoletian/mkdist-issues-192

Thanks for making reproduction and sorry for checking late.
For reference, this was the original hotfix https://github.com/unjs/mkdist/commit/94444df  to address IPX/Unstorage regression with .cjs bundling as a result of a behavior change in Jiti (babel) changes that broke Netlify builder.
<EMAIL_ADDRESS>(before - fine) ><EMAIL_ADDRESS>(problematic) ><EMAIL_ADDRESS>(fixed with hotfix)
I will see if can find smaller workaround only for that case and also working with your reproduction 👍🏼


CI: test workcraft execution

@danilovesky PTAL

Don't merge yet, looking into OSX at the moment.

@danilovesky green finally, PTAL :)

Great job, thanks!


error: ‘LLVMInitializeBPFTargetInfo’ was not declared in this scope……

llvm and clang are 12.0.0
After make -j8:
[ 65%] Linking CXX static library libresources.a
[ 65%] Built target resources
In file included from /home/book/mycpp/bpftraceForArm/src/ast/bpforc/bpforc.cpp:60:0:
/home/book/mycpp/bpftraceForArm/src/ast/bpforc/bpforcv2.cpp: In static member function ‘static std::unique_ptr<bpftrace::BpfOrc> bpftrace::BpfOrc::Create()’:
/home/book/mycpp/bpftraceForArm/src/ast/bpforc/bpforcv2.cpp:26:3: error: ‘LLVMInitializeBPFTargetInfo’ was not declared in this scope
   LLVMInitializeBPFTargetInfo();
   ^~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/book/mycpp/bpftraceForArm/src/ast/bpforc/bpforcv2.cpp:26:3: note: suggested alternative: ‘LLVMInitializeX86TargetInfo’
   LLVMInitializeBPFTargetInfo();
   ^~~~~~~~~~~~~~~~~~~~~~~~~~~
   LLVMInitializeX86TargetInfo
/home/book/mycpp/bpftraceForArm/src/ast/bpforc/bpforcv2.cpp:27:3: error: ‘LLVMInitializeBPFTarget’ was not declared in this scope
   LLVMInitializeBPFTarget();
   ^~~~~~~~~~~~~~~~~~~~~~~
/home/book/mycpp/bpftraceForArm/src/ast/bpforc/bpforcv2.cpp:27:3: note: suggested alternative: ‘LLVMInitializeX86Target’
   LLVMInitializeBPFTarget();
   ^~~~~~~~~~~~~~~~~~~~~~~
   LLVMInitializeX86Target
/home/book/mycpp/bpftraceForArm/src/ast/bpforc/bpforcv2.cpp:28:3: error: ‘LLVMInitializeBPFTargetMC’ was not declared in this scope
   LLVMInitializeBPFTargetMC();
   ^~~~~~~~~~~~~~~~~~~~~~~~~
/home/book/mycpp/bpftraceForArm/src/ast/bpforc/bpforcv2.cpp:28:3: note: suggested alternative: ‘LLVMInitializeX86TargetMC’
   LLVMInitializeBPFTargetMC();
   ^~~~~~~~~~~~~~~~~~~~~~~~~
   LLVMInitializeX86TargetMC
/home/book/mycpp/bpftraceForArm/src/ast/bpforc/bpforcv2.cpp:29:3: error: ‘LLVMInitializeBPFAsmPrinter’ was not declared in this scope
   LLVMInitializeBPFAsmPrinter();
   ^~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/book/mycpp/bpftraceForArm/src/ast/bpforc/bpforcv2.cpp:29:3: note: suggested alternative: ‘LLVMInitializeX86AsmPrinter’
   LLVMInitializeBPFAsmPrinter();
   ^~~~~~~~~~~~~~~~~~~~~~~~~~~
   LLVMInitializeX86AsmPrinter
src/ast/bpforc/CMakeFiles/bpforc.dir/build.make:62: recipe for target 'src/ast/bpforc/CMakeFiles/bpforc.dir/bpforc.cpp.o' failed
make[2]: *** [src/ast/bpforc/CMakeFiles/bpforc.dir/bpforc.cpp.o] Error 1
CMakeFiles/Makefile2:1277: recipe for target 'src/ast/bpforc/CMakeFiles/bpforc.dir/all' failed
make[1]: *** [src/ast/bpforc/CMakeFiles/bpforc.dir/all] Error 2
Makefile:140: recipe for target 'all' failed
make: *** [all] Error 2

Where did you get your LLVM install from? It sounds like LLVM was compiled without BPF support

Where did you get your LLVM install from? It sounds like LLVM was compiled without BPF support

I get my LLVM install from https://github.com/llvm/llvm-project/releases,
then i run 'cmake ../ -DLLVM_TARGETS_TO_BUILD=X86 -DCMAKE_BUILD_TYPE='  for getting makefile.
Is option of cmake wrong? :(
there is my system and config of  BPF：
book@100ask:~$ uname -a
Linux 100ask 5.4.0-81-generic #91~18.04.1-Ubuntu SMP Fri Jul 23 13:36:29 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

book@100ask:~$ egrep -i 'BPF' /boot/config-$(uname -r)
CONFIG_CGROUP_BPF=y
CONFIG_BPF=y
CONFIG_BPF_SYSCALL=y
CONFIG_BPF_JIT_ALWAYS_ON=y
CONFIG_IPV6_SEG6_BPF=y
CONFIG_NETFILTER_XT_MATCH_BPF=m
CONFIG_BPFILTER=y
CONFIG_BPFILTER_UMH=m
CONFIG_NET_CLS_BPF=m
CONFIG_NET_ACT_BPF=m
CONFIG_BPF_JIT=y
CONFIG_BPF_STREAM_PARSER=y
CONFIG_LWTUNNEL_BPF=y
CONFIG_HAVE_EBPF_JIT=y
CONFIG_BPF_EVENTS=y
CONFIG_BPF_KPROBE_OVERRIDE=y
CONFIG_TEST_BPF=m

-DLLVM_TARGETS_TO_BUILD=X86 you want to add bpf there

-DLLVM_TARGETS_TO_BUILD=X86 you want to add bpf there

-DLLVM_TARGETS_TO_BUILD='X86;BPF'    Is that right？
Thank you very much!!! :)

Seems unrelated to bpftrace, please reopen if necessary.


add input validation for < & > characters, remove string from settimeout calls

add some frontend fixes to safeguard against xss data insert:

add input validation check against < and > characters (only for now)
based on Content Security Policy documentation, https://developer.mozilla.org/en-US/docs/Web/HTTP/CSP, remove string from setTimeout calls.

@ivan-c is correct, but this still seems like a reasonable front end change.  Any opposition to merging as is?

@pbugni Nope, was only waiting on your feedback on whether or not to wait on the backend implementation


Managing Config

Hi,
This isn't exactly an issue, and more of a question instead.  I have been using mastertheboss quite a bit as a point of reference, whilst I have spent a considerable amount of time researching and playing the trial and error game.
So the question, I have 10 different servers, each running multiple JBoss instances (not in domain mode).
The standalone.xml files vary a little between each and it isn't each trying to manage them all.   Without setting up a whole platform that would cover this plus any future activities, what is the best way to manage just this setup alone?
Thanks :)

Sorry for unattending this request and thanks for following my tutorial. Overall, the purpose of the "issues" area is about bug founds in the tutorials. I'd say you could opt for properties if all your servers have the same subsystems. other than that, Domain should be the recommended approach.


Make local non-presubmit test target explicit.

(i.e. make test.integ.galley => make test.integ.galley.local)

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: ozevren
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

tests/integration/OWNERS [ozevren]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: nmittler, ozevren
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

tests/integration/OWNERS [nmittler,ozevren]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ozevren: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/integ-framework-k8s-presubmit-tests.sh
2f7084750e195cc774b8d5cc314df36e2f394c50
link
/test integ-framework-k8s-presubmit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ozevren: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/integ-framework-k8s-presubmit-tests.sh
2f7084750e195cc774b8d5cc314df36e2f394c50
link
/test integ-framework-k8s-presubmit-tests-master

prow/integ-galley-k8s-presubmit-tests.sh
2f7084750e195cc774b8d5cc314df36e2f394c50
link
/test integ-galley-k8s-presubmit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ozevren: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/integ-framework-k8s-presubmit-tests.sh
2f7084750e195cc774b8d5cc314df36e2f394c50
link
/test integ-framework-k8s-presubmit-tests-master

prow/integ-galley-k8s-presubmit-tests.sh
2f7084750e195cc774b8d5cc314df36e2f394c50
link
/test integ-galley-k8s-presubmit-tests-master

prow/integ-istioctl-k8s-presubmit-tests.sh
2f7084750e195cc774b8d5cc314df36e2f394c50
link
/test integ-istioctl-k8s-presubmit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ozevren: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/integ-framework-k8s-presubmit-tests.sh
2f7084750e195cc774b8d5cc314df36e2f394c50
link
/test integ-framework-k8s-presubmit-tests-master

prow/integ-galley-k8s-presubmit-tests.sh
2f7084750e195cc774b8d5cc314df36e2f394c50
link
/test integ-galley-k8s-presubmit-tests-master

prow/integ-istioctl-k8s-presubmit-tests.sh
2f7084750e195cc774b8d5cc314df36e2f394c50
link
/test integ-istioctl-k8s-presubmit-tests-master

prow/integ-mixer-k8s-presubmit-tests.sh
2f7084750e195cc774b8d5cc314df36e2f394c50
link
/test integ-mixer-k8s-presubmit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ozevren: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/integ-framework-k8s-presubmit-tests.sh
2f7084750e195cc774b8d5cc314df36e2f394c50
link
/test integ-framework-k8s-presubmit-tests-master

prow/integ-galley-k8s-presubmit-tests.sh
2f7084750e195cc774b8d5cc314df36e2f394c50
link
/test integ-galley-k8s-presubmit-tests-master

prow/integ-istioctl-k8s-presubmit-tests.sh
2f7084750e195cc774b8d5cc314df36e2f394c50
link
/test integ-istioctl-k8s-presubmit-tests-master

prow/integ-mixer-k8s-presubmit-tests.sh
2f7084750e195cc774b8d5cc314df36e2f394c50
link
/test integ-mixer-k8s-presubmit-tests-master

prow/integ-pilot-k8s-presubmit-tests.sh
2f7084750e195cc774b8d5cc314df36e2f394c50
link
/test integ-pilot-k8s-presubmit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ozevren: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/integ-framework-k8s-presubmit-tests.sh
2f7084750e195cc774b8d5cc314df36e2f394c50
link
/test integ-framework-k8s-presubmit-tests-master

prow/integ-galley-k8s-presubmit-tests.sh
2f7084750e195cc774b8d5cc314df36e2f394c50
link
/test integ-galley-k8s-presubmit-tests-master

prow/integ-istioctl-k8s-presubmit-tests.sh
2f7084750e195cc774b8d5cc314df36e2f394c50
link
/test integ-istioctl-k8s-presubmit-tests-master

prow/integ-mixer-k8s-presubmit-tests.sh
2f7084750e195cc774b8d5cc314df36e2f394c50
link
/test integ-mixer-k8s-presubmit-tests-master

prow/integ-pilot-k8s-presubmit-tests.sh
2f7084750e195cc774b8d5cc314df36e2f394c50
link
/test integ-pilot-k8s-presubmit-tests-master

prow/integ-security-k8s-presubmit-tests.sh
2f7084750e195cc774b8d5cc314df36e2f394c50
link
/test integ-security-k8s-presubmit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ozevren: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/integ-framework-k8s-presubmit-tests.sh
2f7084750e195cc774b8d5cc314df36e2f394c50
link
/test integ-framework-k8s-presubmit-tests-master

prow/integ-galley-k8s-presubmit-tests.sh
2f7084750e195cc774b8d5cc314df36e2f394c50
link
/test integ-galley-k8s-presubmit-tests-master

prow/integ-istioctl-k8s-presubmit-tests.sh
2f7084750e195cc774b8d5cc314df36e2f394c50
link
/test integ-istioctl-k8s-presubmit-tests-master

prow/integ-mixer-k8s-presubmit-tests.sh
2f7084750e195cc774b8d5cc314df36e2f394c50
link
/test integ-mixer-k8s-presubmit-tests-master

prow/integ-pilot-k8s-presubmit-tests.sh
2f7084750e195cc774b8d5cc314df36e2f394c50
link
/test integ-pilot-k8s-presubmit-tests-master

prow/integ-security-k8s-presubmit-tests.sh
2f7084750e195cc774b8d5cc314df36e2f394c50
link
/test integ-security-k8s-presubmit-tests-master

prow/integ-telemetry-k8s-presubmit-tests.sh
2f7084750e195cc774b8d5cc314df36e2f394c50
link
/test integ-telemetry-k8s-presubmit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ozevren: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/integ-framework-k8s-presubmit-tests.sh
2f7084750e195cc774b8d5cc314df36e2f394c50
link
/test integ-framework-k8s-presubmit-tests-master

prow/integ-galley-k8s-presubmit-tests.sh
2f7084750e195cc774b8d5cc314df36e2f394c50
link
/test integ-galley-k8s-presubmit-tests-master

prow/integ-istioctl-k8s-presubmit-tests.sh
2f7084750e195cc774b8d5cc314df36e2f394c50
link
/test integ-istioctl-k8s-presubmit-tests-master

prow/integ-mixer-k8s-presubmit-tests.sh
2f7084750e195cc774b8d5cc314df36e2f394c50
link
/test integ-mixer-k8s-presubmit-tests-master

prow/integ-pilot-k8s-presubmit-tests.sh
2f7084750e195cc774b8d5cc314df36e2f394c50
link
/test integ-pilot-k8s-presubmit-tests-master

prow/integ-security-k8s-presubmit-tests.sh
2f7084750e195cc774b8d5cc314df36e2f394c50
link
/test integ-security-k8s-presubmit-tests-master

prow/integ-telemetry-k8s-presubmit-tests.sh
2f7084750e195cc774b8d5cc314df36e2f394c50
link
/test integ-telemetry-k8s-presubmit-tests-master

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
2f7084750e195cc774b8d5cc314df36e2f394c50
link
/test istio-pilot-e2e-envoyv2-v1alpha3-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ozevren: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/integ-framework-k8s-presubmit-tests.sh
2f7084750e195cc774b8d5cc314df36e2f394c50
link
/test integ-framework-k8s-presubmit-tests-master

prow/integ-galley-k8s-presubmit-tests.sh
2f7084750e195cc774b8d5cc314df36e2f394c50
link
/test integ-galley-k8s-presubmit-tests-master

prow/integ-istioctl-k8s-presubmit-tests.sh
2f7084750e195cc774b8d5cc314df36e2f394c50
link
/test integ-istioctl-k8s-presubmit-tests-master

prow/integ-mixer-k8s-presubmit-tests.sh
2f7084750e195cc774b8d5cc314df36e2f394c50
link
/test integ-mixer-k8s-presubmit-tests-master

prow/integ-pilot-k8s-presubmit-tests.sh
2f7084750e195cc774b8d5cc314df36e2f394c50
link
/test integ-pilot-k8s-presubmit-tests-master

prow/integ-security-k8s-presubmit-tests.sh
2f7084750e195cc774b8d5cc314df36e2f394c50
link
/test integ-security-k8s-presubmit-tests-master

prow/integ-telemetry-k8s-presubmit-tests.sh
2f7084750e195cc774b8d5cc314df36e2f394c50
link
/test integ-telemetry-k8s-presubmit-tests-master

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
2f7084750e195cc774b8d5cc314df36e2f394c50
link
/test istio-pilot-e2e-envoyv2-v1alpha3-master

prow/e2e-mixer-no_auth.sh
2f7084750e195cc774b8d5cc314df36e2f394c50
link
/test e2e-mixer-no_auth-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ozevren: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/integ-framework-k8s-presubmit-tests.sh
2f7084750e195cc774b8d5cc314df36e2f394c50
link
/test integ-framework-k8s-presubmit-tests-master

prow/integ-galley-k8s-presubmit-tests.sh
2f7084750e195cc774b8d5cc314df36e2f394c50
link
/test integ-galley-k8s-presubmit-tests-master

prow/integ-istioctl-k8s-presubmit-tests.sh
2f7084750e195cc774b8d5cc314df36e2f394c50
link
/test integ-istioctl-k8s-presubmit-tests-master

prow/integ-mixer-k8s-presubmit-tests.sh
2f7084750e195cc774b8d5cc314df36e2f394c50
link
/test integ-mixer-k8s-presubmit-tests-master

prow/integ-pilot-k8s-presubmit-tests.sh
2f7084750e195cc774b8d5cc314df36e2f394c50
link
/test integ-pilot-k8s-presubmit-tests-master

prow/integ-security-k8s-presubmit-tests.sh
2f7084750e195cc774b8d5cc314df36e2f394c50
link
/test integ-security-k8s-presubmit-tests-master

prow/integ-telemetry-k8s-presubmit-tests.sh
2f7084750e195cc774b8d5cc314df36e2f394c50
link
/test integ-telemetry-k8s-presubmit-tests-master

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
2f7084750e195cc774b8d5cc314df36e2f394c50
link
/test istio-pilot-e2e-envoyv2-v1alpha3-master

prow/e2e-mixer-no_auth.sh
2f7084750e195cc774b8d5cc314df36e2f394c50
link
/test e2e-mixer-no_auth-master

prow/e2e-dashboard.sh
2f7084750e195cc774b8d5cc314df36e2f394c50
link
/test e2e-dashboard-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ozevren: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/integ-framework-k8s-presubmit-tests.sh
2f7084750e195cc774b8d5cc314df36e2f394c50
link
/test integ-framework-k8s-presubmit-tests-master

prow/integ-galley-k8s-presubmit-tests.sh
2f7084750e195cc774b8d5cc314df36e2f394c50
link
/test integ-galley-k8s-presubmit-tests-master

prow/integ-istioctl-k8s-presubmit-tests.sh
2f7084750e195cc774b8d5cc314df36e2f394c50
link
/test integ-istioctl-k8s-presubmit-tests-master

prow/integ-mixer-k8s-presubmit-tests.sh
2f7084750e195cc774b8d5cc314df36e2f394c50
link
/test integ-mixer-k8s-presubmit-tests-master

prow/integ-pilot-k8s-presubmit-tests.sh
2f7084750e195cc774b8d5cc314df36e2f394c50
link
/test integ-pilot-k8s-presubmit-tests-master

prow/integ-security-k8s-presubmit-tests.sh
2f7084750e195cc774b8d5cc314df36e2f394c50
link
/test integ-security-k8s-presubmit-tests-master

prow/integ-telemetry-k8s-presubmit-tests.sh
2f7084750e195cc774b8d5cc314df36e2f394c50
link
/test integ-telemetry-k8s-presubmit-tests-master

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
2f7084750e195cc774b8d5cc314df36e2f394c50
link
/test istio-pilot-e2e-envoyv2-v1alpha3-master

prow/e2e-mixer-no_auth.sh
2f7084750e195cc774b8d5cc314df36e2f394c50
link
/test e2e-mixer-no_auth-master

prow/e2e-dashboard.sh
2f7084750e195cc774b8d5cc314df36e2f394c50
link
/test e2e-dashboard-master

prow/e2e-bookInfoTests-v1alpha3.sh
2f7084750e195cc774b8d5cc314df36e2f394c50
link
/test e2e-bookInfoTests-envoyv2-v1alpha3-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ozevren: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/integ-framework-k8s-presubmit-tests.sh
2f7084750e195cc774b8d5cc314df36e2f394c50
link
/test integ-framework-k8s-presubmit-tests-master

prow/integ-galley-k8s-presubmit-tests.sh
2f7084750e195cc774b8d5cc314df36e2f394c50
link
/test integ-galley-k8s-presubmit-tests-master

prow/integ-istioctl-k8s-presubmit-tests.sh
2f7084750e195cc774b8d5cc314df36e2f394c50
link
/test integ-istioctl-k8s-presubmit-tests-master

prow/integ-mixer-k8s-presubmit-tests.sh
2f7084750e195cc774b8d5cc314df36e2f394c50
link
/test integ-mixer-k8s-presubmit-tests-master

prow/integ-pilot-k8s-presubmit-tests.sh
2f7084750e195cc774b8d5cc314df36e2f394c50
link
/test integ-pilot-k8s-presubmit-tests-master

prow/integ-security-k8s-presubmit-tests.sh
2f7084750e195cc774b8d5cc314df36e2f394c50
link
/test integ-security-k8s-presubmit-tests-master

prow/integ-telemetry-k8s-presubmit-tests.sh
2f7084750e195cc774b8d5cc314df36e2f394c50
link
/test integ-telemetry-k8s-presubmit-tests-master

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
2f7084750e195cc774b8d5cc314df36e2f394c50
link
/test istio-pilot-e2e-envoyv2-v1alpha3-master

prow/e2e-mixer-no_auth.sh
2f7084750e195cc774b8d5cc314df36e2f394c50
link
/test e2e-mixer-no_auth-master

prow/e2e-dashboard.sh
2f7084750e195cc774b8d5cc314df36e2f394c50
link
/test e2e-dashboard-master

prow/e2e-bookInfoTests-v1alpha3.sh
2f7084750e195cc774b8d5cc314df36e2f394c50
link
/test e2e-bookInfoTests-envoyv2-v1alpha3-master

prow/e2e-bookInfoTests-trustdomain.sh
2f7084750e195cc774b8d5cc314df36e2f394c50
link
/test e2e-bookInfoTests-trustdomain-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ozevren: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/integ-framework-k8s-presubmit-tests.sh
2f7084750e195cc774b8d5cc314df36e2f394c50
link
/test integ-framework-k8s-presubmit-tests-master

prow/integ-galley-k8s-presubmit-tests.sh
2f7084750e195cc774b8d5cc314df36e2f394c50
link
/test integ-galley-k8s-presubmit-tests-master

prow/integ-istioctl-k8s-presubmit-tests.sh
2f7084750e195cc774b8d5cc314df36e2f394c50
link
/test integ-istioctl-k8s-presubmit-tests-master

prow/integ-mixer-k8s-presubmit-tests.sh
2f7084750e195cc774b8d5cc314df36e2f394c50
link
/test integ-mixer-k8s-presubmit-tests-master

prow/integ-pilot-k8s-presubmit-tests.sh
2f7084750e195cc774b8d5cc314df36e2f394c50
link
/test integ-pilot-k8s-presubmit-tests-master

prow/integ-security-k8s-presubmit-tests.sh
2f7084750e195cc774b8d5cc314df36e2f394c50
link
/test integ-security-k8s-presubmit-tests-master

prow/integ-telemetry-k8s-presubmit-tests.sh
2f7084750e195cc774b8d5cc314df36e2f394c50
link
/test integ-telemetry-k8s-presubmit-tests-master

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
2f7084750e195cc774b8d5cc314df36e2f394c50
link
/test istio-pilot-e2e-envoyv2-v1alpha3-master

prow/e2e-mixer-no_auth.sh
2f7084750e195cc774b8d5cc314df36e2f394c50
link
/test e2e-mixer-no_auth-master

prow/e2e-dashboard.sh
2f7084750e195cc774b8d5cc314df36e2f394c50
link
/test e2e-dashboard-master

prow/e2e-bookInfoTests-v1alpha3.sh
2f7084750e195cc774b8d5cc314df36e2f394c50
link
/test e2e-bookInfoTests-envoyv2-v1alpha3-master

prow/e2e-bookInfoTests-trustdomain.sh
2f7084750e195cc774b8d5cc314df36e2f394c50
link
/test e2e-bookInfoTests-trustdomain-master

prow/e2e-simpleTests.sh
2f7084750e195cc774b8d5cc314df36e2f394c50
link
/test e2e-simpleTests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ozevren: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/integ-framework-k8s-presubmit-tests.sh
2f7084750e195cc774b8d5cc314df36e2f394c50
link
/test integ-framework-k8s-presubmit-tests-master

prow/integ-galley-k8s-presubmit-tests.sh
2f7084750e195cc774b8d5cc314df36e2f394c50
link
/test integ-galley-k8s-presubmit-tests-master

prow/integ-istioctl-k8s-presubmit-tests.sh
2f7084750e195cc774b8d5cc314df36e2f394c50
link
/test integ-istioctl-k8s-presubmit-tests-master

prow/integ-mixer-k8s-presubmit-tests.sh
2f7084750e195cc774b8d5cc314df36e2f394c50
link
/test integ-mixer-k8s-presubmit-tests-master

prow/integ-pilot-k8s-presubmit-tests.sh
2f7084750e195cc774b8d5cc314df36e2f394c50
link
/test integ-pilot-k8s-presubmit-tests-master

prow/integ-security-k8s-presubmit-tests.sh
2f7084750e195cc774b8d5cc314df36e2f394c50
link
/test integ-security-k8s-presubmit-tests-master

prow/integ-telemetry-k8s-presubmit-tests.sh
2f7084750e195cc774b8d5cc314df36e2f394c50
link
/test integ-telemetry-k8s-presubmit-tests-master

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
2f7084750e195cc774b8d5cc314df36e2f394c50
link
/test istio-pilot-e2e-envoyv2-v1alpha3-master

prow/e2e-mixer-no_auth.sh
2f7084750e195cc774b8d5cc314df36e2f394c50
link
/test e2e-mixer-no_auth-master

prow/e2e-dashboard.sh
2f7084750e195cc774b8d5cc314df36e2f394c50
link
/test e2e-dashboard-master

prow/e2e-bookInfoTests-v1alpha3.sh
2f7084750e195cc774b8d5cc314df36e2f394c50
link
/test e2e-bookInfoTests-envoyv2-v1alpha3-master

prow/e2e-bookInfoTests-trustdomain.sh
2f7084750e195cc774b8d5cc314df36e2f394c50
link
/test e2e-bookInfoTests-trustdomain-master

prow/e2e-simpleTests.sh
2f7084750e195cc774b8d5cc314df36e2f394c50
link
/test e2e-simpleTests-master

prow/e2e-simpleTests-minProfile.sh
2f7084750e195cc774b8d5cc314df36e2f394c50
link
/test e2e-simpleTestsMinProfile-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ozevren: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/integ-framework-k8s-presubmit-tests.sh
2f7084750e195cc774b8d5cc314df36e2f394c50
link
/test integ-framework-k8s-presubmit-tests-master

prow/integ-galley-k8s-presubmit-tests.sh
2f7084750e195cc774b8d5cc314df36e2f394c50
link
/test integ-galley-k8s-presubmit-tests-master

prow/integ-istioctl-k8s-presubmit-tests.sh
2f7084750e195cc774b8d5cc314df36e2f394c50
link
/test integ-istioctl-k8s-presubmit-tests-master

prow/integ-mixer-k8s-presubmit-tests.sh
2f7084750e195cc774b8d5cc314df36e2f394c50
link
/test integ-mixer-k8s-presubmit-tests-master

prow/integ-pilot-k8s-presubmit-tests.sh
2f7084750e195cc774b8d5cc314df36e2f394c50
link
/test integ-pilot-k8s-presubmit-tests-master

prow/integ-security-k8s-presubmit-tests.sh
2f7084750e195cc774b8d5cc314df36e2f394c50
link
/test integ-security-k8s-presubmit-tests-master

prow/integ-telemetry-k8s-presubmit-tests.sh
2f7084750e195cc774b8d5cc314df36e2f394c50
link
/test integ-telemetry-k8s-presubmit-tests-master

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
2f7084750e195cc774b8d5cc314df36e2f394c50
link
/test istio-pilot-e2e-envoyv2-v1alpha3-master

prow/e2e-mixer-no_auth.sh
2f7084750e195cc774b8d5cc314df36e2f394c50
link
/test e2e-mixer-no_auth-master

prow/e2e-dashboard.sh
2f7084750e195cc774b8d5cc314df36e2f394c50
link
/test e2e-dashboard-master

prow/e2e-bookInfoTests-v1alpha3.sh
2f7084750e195cc774b8d5cc314df36e2f394c50
link
/test e2e-bookInfoTests-envoyv2-v1alpha3-master

prow/e2e-bookInfoTests-trustdomain.sh
2f7084750e195cc774b8d5cc314df36e2f394c50
link
/test e2e-bookInfoTests-trustdomain-master

prow/e2e-simpleTests.sh
2f7084750e195cc774b8d5cc314df36e2f394c50
link
/test e2e-simpleTests-master

prow/e2e-simpleTests-minProfile.sh
2f7084750e195cc774b8d5cc314df36e2f394c50
link
/test e2e-simpleTestsMinProfile-master

prow/istio-pilot-multicluster-e2e.sh
2f7084750e195cc774b8d5cc314df36e2f394c50
link
/test istio-pilot-multicluster-e2e-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ozevren: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/integ-framework-k8s-presubmit-tests.sh
2f7084750e195cc774b8d5cc314df36e2f394c50
link
/test integ-framework-k8s-presubmit-tests-master

prow/integ-galley-k8s-presubmit-tests.sh
2f7084750e195cc774b8d5cc314df36e2f394c50
link
/test integ-galley-k8s-presubmit-tests-master

prow/integ-istioctl-k8s-presubmit-tests.sh
2f7084750e195cc774b8d5cc314df36e2f394c50
link
/test integ-istioctl-k8s-presubmit-tests-master

prow/integ-mixer-k8s-presubmit-tests.sh
2f7084750e195cc774b8d5cc314df36e2f394c50
link
/test integ-mixer-k8s-presubmit-tests-master

prow/integ-pilot-k8s-presubmit-tests.sh
2f7084750e195cc774b8d5cc314df36e2f394c50
link
/test integ-pilot-k8s-presubmit-tests-master

prow/integ-security-k8s-presubmit-tests.sh
2f7084750e195cc774b8d5cc314df36e2f394c50
link
/test integ-security-k8s-presubmit-tests-master

prow/integ-telemetry-k8s-presubmit-tests.sh
2f7084750e195cc774b8d5cc314df36e2f394c50
link
/test integ-telemetry-k8s-presubmit-tests-master

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
2f7084750e195cc774b8d5cc314df36e2f394c50
link
/test istio-pilot-e2e-envoyv2-v1alpha3-master

prow/e2e-mixer-no_auth.sh
2f7084750e195cc774b8d5cc314df36e2f394c50
link
/test e2e-mixer-no_auth-master

prow/e2e-dashboard.sh
2f7084750e195cc774b8d5cc314df36e2f394c50
link
/test e2e-dashboard-master

prow/e2e-bookInfoTests-v1alpha3.sh
2f7084750e195cc774b8d5cc314df36e2f394c50
link
/test e2e-bookInfoTests-envoyv2-v1alpha3-master

prow/e2e-bookInfoTests-trustdomain.sh
2f7084750e195cc774b8d5cc314df36e2f394c50
link
/test e2e-bookInfoTests-trustdomain-master

prow/e2e-simpleTests.sh
2f7084750e195cc774b8d5cc314df36e2f394c50
link
/test e2e-simpleTests-master

prow/e2e-simpleTests-minProfile.sh
2f7084750e195cc774b8d5cc314df36e2f394c50
link
/test e2e-simpleTestsMinProfile-master

prow/istio-pilot-multicluster-e2e.sh
2f7084750e195cc774b8d5cc314df36e2f394c50
link
/test istio-pilot-multicluster-e2e-master

prow/e2e_pilotv2_auth_sds.sh
2f7084750e195cc774b8d5cc314df36e2f394c50
link
/test istio_auth_sds_e2e-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

/test e2e-dashboard-master

/test istio-pilot-e2e-envoyv2-v1alpha3-master

/test e2e-bookInfoTests-envoyv2-v1alpha3-master

/test integ-galley-k8s-presubmit-tests-master

/test integ-framework-k8s-presubmit-tests-master

/test istio_auth_sds_e2e-master

/test e2e-simpleTests-master

/test e2e-mixer-no_auth-master

@ozevren: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/integ-security-k8s-presubmit-tests.sh
2f7084750e195cc774b8d5cc314df36e2f394c50
link
/test integ-security-k8s-presubmit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


[core] gemma2 full context length support

the scheduler treats it as a model without sliding window, and sliding window is only used for computation.
FIX #6220
FIX #8580

fixes https://github.com/vllm-project/vllm/issues/9517

Just a heads up: the paged attention kernel we use for the xFormers backend doesn't support sliding window attention. This PR will introduce a slight correctness bug in the xformers backend.

for xformers, we keep the original behavior of capping the max-model-length.

This looks great! Which attention backend do you recommend for gemma 2 now?

@noamgat the default one (flash attention) should work.

Hi! Thanks for this fix.
Can you, please, tell me when the release with this fix is planned?


External forcing

Codecov Report

Merging #78 (3d95c98) into main (f9fc262) will decrease coverage by 38.18%.
The diff coverage is 70.00%.

:exclamation: Current head 3d95c98 differs from pull request most recent head 8502948. Consider uploading reports for the commit 8502948 to get more accurate results

@@             Coverage Diff             @@
##             main      #78       +/-   ##
===========================================
- Coverage   86.55%   48.37%   -38.18%
===========================================
  Files          88       88
  Lines        5088     5091        +3
===========================================
- Hits         4404     2463     -1941
- Misses        684     2628     +1944

Impacted Files
Coverage Δ

src/bodies/set.jl
65.62% <50.00%> (-34.38%)
:arrow_down:

src/bodies/state.jl
48.48% <60.00%> (-51.52%)
:arrow_down:

src/integrators/constraint.jl
92.45% <100.00%> (-7.55%)
:arrow_down:

src/mechanics/momentum.jl
40.35% <100.00%> (-59.65%)
:arrow_down:

src/simulation/simulate.jl
100.00% <100.00%> (ø)

... and 62 files with indirect coverage changes
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Canthv0 simpleadmin

Issue:
Importing existing Get-SimpleAdminAuditlog script into github under a managed location.
Reason:
Moving the script to a proper location for maintaining.

It looks like this is failing due to formatting.
Please run .build\CodeFormatter.ps1 -Save from PS7 to auto-format, and manually fix the issues called out by PSScriptAnalyzer.

The readme should also be moved to under docs.
@bill-long do we want this script under "Admin"?

Admin sounds fine. I'll push a commit to move the readme.

This PR is still pending action from @Canthv0

Remove disclaimer and author
Fix typo identified by Lukas
Run CodeFormatter -Save to fix the build issues as noted by Lukas

@Canthv0 the script failed to match the formatting because of new requirement to have an empty line at the end of the file.

Ok I think I have everything fixed now.


Decorate a class

Requesting review
Project requirements:

Create a class Nameable.
Turn your Person class to Nameable
Prepare base Decorator
Prepare CapitalizeDecorator and TrimmerDecorator

Thanks @KDlamini


ANY IMPROVEMENTS IN MY PROJECT?

I would like to create an .env file in order to make the path easier to change for all users.


Chunk uploads

Moves to using blocks for HTTP calls so that only one connection is used for multiple events.

This has been solved differently. Thanks for your contribution, however, @davidashman!
The new release is v4.0.0.