trying to fix the docker network issue in travis

@PLoic it seems like using the default docker given address (<IP_ADDRESS>) is solving our curl issue.
see https://github.com/docker/docker/issues/13847

I just restart the CI and the build still failing :/

Ok, I will try something else on this branch.

We not have the same error : https://travis-ci.org/dldl/sphinx-server/builds/177160275

I will try a arp -d <IP_ADDRESS> on the hosting machine (not the docker container) to check if it solves anything.

It should be OK now. Can you confirm ? Thx

Sounds good for me


Fullbleed editor's note support

Some articles start with Editor's Note eg on https://www.golfdigest.com/story/favorite-golf-insiders-tv-broadcasters-personalities-reporters-power-poll

We could support it with eg a document wide metadata field

@icaraps do we need import changes for this?


Questions about using API.

Hi, Huchenme :
I used this API in my flutter open source project flutter_wanandroid.
Your project is very good.Thank you very much!

Thanks, do you mind add your project here: https://github.com/huchenme/github-trending-api/issues/20?
And I will update README as well to list your project

by the way, nice project! 👍


Ancient Comics (Pt-Br Source) shows no content.

Source information
Ancient Comics 1.4.31
Source language
Portuguese Brazilian
Steps to reproduce
It doesn't show the content in the app only in the WebView.

Expected behavior
Show content in the app.
Actual behavior
You can only see the content in WebView.
Mihon/Tachiyomi version
0.16.5
Android version
Android 12
Other details
No response
Acknowledgements

[X] I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open or closed issue.
[X] I have written a short but informative title.
[X] I have updated the app to version 0.15.3.
[X] I have updated all installed extensions.
[X] I have tried the troubleshooting guide.
[X] If this is an issue with the app itself, I should be opening an issue in the app repository.
[X] I will fill out all of the requested information in this form.

@EvaldoCeBr Ancient is changing their website. Visit their discord channel.

@EvaldoCeBr Ancient is changing their website. Visit their discord channel.

Maintenance is over and the extension is not working.

Theme change.


Use fully-qualified container image references

We use a lot of short container references like ubuntu:20.04 or containerbase/base. But these can sometimes be confusing, especially as we are also pushing images to the GitHub container registry ghcr.io. And they are also not standardized across container runtimes. For example, running podman pull ubuntu:20.04 will result in the error Error: short-name "ubuntu:20.04" did not resolve to an alias.
Instead we should use fully-qualified references, like docker.io/library/ubuntu:20.04 or docker.io/containerbase/base.

all done


fix(export-env): export app config vars

Explicitly call the sub-env function to export an app's config variables, which are in the ENV_DIR directory.
Also ensure the environment variables are exported in the main shell of the program instead of a subshell. The use case here is to pass flags to pip via PIP_* environment variables. https://pip.pypa.io/en/stable/user_guide/#environment-variables

these environment variables are only to be made available to specific steps of the build process, not the entire compile phase. They are sensitive. For example, $ pip install has the ability to run any arbitrary Python code.

@RenaultAI what flags specifically would you want to use? No one has requested this before :)

You're right! I neglected to see the change from a security point of view.
The specific pip flag is --process-dependency-links, which can be enabled via the PIP_PROCESS_DEPENDENCY_LINKS environment variable. With pip version 8.0.0 and newer, this flag can be provided in the requirements file however. I created the pull request to provide a consistent solution.
Perhaps a better change is to add ^PIP_ to the environment variable whitelist?

The intended (and recommended) solution is to add --process-dependency-links to your requirements.txt file.


How do I make popper flip inside on the same side

Reproduction demo
https://codesandbox.io/s/2zjjvxz0qj
Steps to reproduce the problem

Click to open a right placed popper.
Since there is not space on the right, it flips to left and since there is no space on the left as well, it pushes inside.

What is the expected behavior?
It shouldn't flip like this when there is no space left as well as right. Instead it would be ideal to remain on the same side, just pushed inside.
Packages versions

react-popper: 1.0.2

Apologies if there is already a configuration for this.

I just found out that there is a modifier named inner that does this, but it always makes popper render inside. I want it to do whenever there is not space at the specified placement prop.

@FezVrasta any solution?

It's not supported. A custom modifier can do that

thanks for replying, could you please give some hint at least on how a custom modifier would achieve that?

You should replace the built in flip modifier and make it apply the inner modifier when you want it to

alright, thanks a ton. I will try this :)

hi @FezVrasta, could you please tell me how do I do the overriding of flip modifier? I want it to call the orginal flip modifer + some things...right now it seems, once if use the custom flip fn function, the original behviour can't be accessed.

https://stackoverflow.com/questions/53554105/how-to-reuse-popper-js-modifier-when-overriding-it
done

hi, @FezVrasta do i need to provide more info on the question? please help


Add dolar-cripto-ar extension

Description
This extension allows you to view real-time quotes of various Argentine dollars (CCL, MEP, and Blue) and popular cryptocurrencies (ETH, BTC)
Screencast

Checklist

[x] I read the extension guidelines
[x] I read the documentation about publishing
[x] I ran npm run build and tested this distribution build in Raycast
[x] I checked that files in the assets folder are used by the extension itself
[x] I checked that assets used by the README are placed outside of the metadata folder

@pernielsentikaer Thanks for the feedback! I've made the changes that you asked for.

If you clear Local Storage and try to use the menubar, then it flickers with the text "blue" and the current, can you look into that?

Raycast17062024-4CIhBKll.png.mp4

It should be working fine now! thanks for the feedback.

Hey @koaladlt ! Is this ready for another review?

Hey @koaladlt ! Is this ready for another review?

Yes it is :)

Thank you so much for your contribution, again! After testing it out, I was missing some kind of indication of which unit is "active". Have you considered adding a check mark (or any kind of mark) on the list next to the unit which is showing at the moment?

Thanks for your feedback! :) I added a check mark to the select unit so the user knows which one is selected.


Need reference for Eratosthenes image

Eratosthenes image on Rights page has attribution but no link. Need to add link to References page.

Reference added to References page


Feature request: Optional start node for guarantees service

Some times I only care about one starting node in the guarantees service. It would be great to be able to be able to provide this to speed up the estimated time predictions when planning.

should be easy enough to do. I'm focusing on ECAI now, do you want it this week, or can I leave it for next?

Next week is fine.


Integrate Klaro and Google Analytics

Fix: https://github.com/substrate-developer-hub/substrate-developer-hub.github.io/issues/227
TODO:

[x] Link to privacy policy page.
[x] Fix the klara in chinese pages.

Possible bug?
On localhost if I look at the cookie settings, and turn google analytics on, and then I refresh the page, and look at cookie settings again, it is now turned off.
I also do not see the prompt....

On localhost if I look at the cookie settings, and turn google analytics on, and then I refresh the page, and look at cookie settings again, it is now turned off.

I haven't reproduced this scenario, we can work together to figure it out.

@kirushik The "toggle all" doesn't work as expected. Since we want the cloudflare to be always required, but "toggle all" can disable it in storage but not make it gray in the UI. We better hide it so that it won't confuse the user IMO.

@kaichaosun OK, I've just discovered that we're doing the same CSS trick for hiding the "toggle all" option on parity.io as well — so it's OK to use it here as well.
Other than that — nice job, let's merge it :shipit: !

WOO!


ip_adapter-plus_sdxl_demo  init  ip_model = IPAdapterPlusXL(pipeline, image_encoder_path, ip_ckpt_plus, device, num_tokens=16)

raise RuntimeError('Error(s) in loading state_dict for {}:\n\t{}'.format(
RuntimeError: Error(s) in loading state_dict for Resampler:
size mismatch for proj_in.weight: copying a param with shape torch.Size([1280, 1280]) from checkpoint, the shape in current model is torch.Size([1280, 1664]).

@wangyong860401 you should use https://huggingface.co/h94/IP-Adapter/tree/main/models/image_encoder (vit-h)

Ok, I will try again. Thank you. There is a small bug, that is __ init__. py does not import IPAdapterPlusXL

@wangyong860401 you should use https://huggingface.co/h94/IP-Adapter/tree/main/models/image_encoder (vit-h)

Hi @xiaohu2015! I made the exact same mistake @wangyong860401 did when implementing this yesterday. After experiencing the same issue and doing side-by-side comparisons I realized XL plus uses the standard image encoder. I don't think there's anything that needs to be done about that in the repos (maybe a note somewhere but that's all,) but I'm curious, why does XL Plus use the 1.5 encoder model?

@wangyong860401 hi, you can refer to https://github.com/tencent-ailab/IP-Adapter#sdxl_10.

same question with @painebenjamin
Then why we need https://huggingface.co/h94/IP-Adapter/tree/main/sdxl_models/image_encoder ?


Cloned object with extended generic type cannot have values assigned to its existing keys

TypeScript Version:  3.8.3
Search Terms:
"Type 'string' cannot be used to index type"
"Type 'string' cannot be used to index type clone"
Code
type Obj = { [index: string]: any }
function f<T extends Obj>(original: T) {
  const o1 = { ...original }
  const o2 = {} as Obj
  Object.keys(o1).forEach(k => {
    // Error: Type 'string' cannot be used to index type 'T'.
    o1[k] = 1 // this should be ok
    o2[k] = 1 // why would this be ok if the above is not?
    const a = o1[k]  // and this is fine?
  })
}

Expected behavior:
The error should not exist as:
(1) o1 has the keys as in T.
(2) T extends Obj. So even if (1) was not true, it should be ok.
It's does not seem right that the next two assignments are ok if o1[k] = 1 is not.
If this is intended behavior, like the one in #32704, I just can't make sense of it. Specially considering the similar assignments that do not raise errors.
Actual behavior:
o1[k] = 1 yelds "Type 'string' cannot be used to index type 'T'."
Playground Link:
https://www.typescriptlang.org/play/index.html#code/C4TwDgpgBA8gRgKygXigbygbQJYDsAmEAHgFxQDOwATngOYC6ZAhriFAL4BQAZgK64BjYNgD2uKNwA8AFSjFgEAuViIAfAAoRNWniYAbMtICU6KJyhQBYylBEBGFKYB0Lrdh259Hc5evBbAEyOaOxQTMrwCD6REEJOANYQIOSadkZO3FoAokwCABbq8Siq6D4W9pjx9I4OAPS1UMB52MrkeSK8evhQcNAi8WWBldWodQ0A7nls4x1djc3KvbZF2Nzz0ExwIgBu0C1QuCLAAPw+7Eac7EA
Related Issues:
#31661, #32704

I think I got why the TS behaves as it does above: there is no way to know what type o1[k] already has, so it is not possible to assign a number to it safelly.
But  I just stumbled upon another similar issue for which this explanation would not hold. This piece of code:
function f<S extends { [i: string]: any }>(t: S, s: S) {
  const r: Partial<S> = {}
  const set = Object.keys(t).reduce((prev, k) => {
    return {
      ...prev,
      [k]: (value = t[k]) => {
        if (value !== s[k] || k in r) {
          // Error: Type 'string' cannot be used to index type 'Partial<S>'.
          r[k] = value
        }
      }
    }
  }, {})
  return {set, r}
}

The expected behavior would be for the error to not exist because whatever the nature of value, it is the same as t[k]. Therefore, assigning it to r[k] does comply with the type definition for r.
Playground link: https://www.typescriptlang.org/play/index.html?ssl=16&ssc=2&pln=1&pc=1#code/FAMwrgdgxgLglgewgAhAHgMrIKYA8bYQAmAzsgN7IDacAXMiTAE5wQDmAuvQIYQCeyAL4A+ABQx6GADQNJASgrBkyKEkbIm9AArcm8bgBtMw5AF4KgpSrUwG2W+YDyAIwBW2WADoA1tj4lxOU8mbCIwKGxRUQAHEIA3GW8FUxNyK2UQmDAmFDTlfORPItjsBPT8qm8uZFE4wzBsM2QYSo5k1PKCuBAauoMG5ABCU3MSVuQAHwnkb2RWDQU8guWAehXkABU+aMaAckYWdl2VXggEW2dGsBJQ5oQ54jxm7b2dPThDY13PTuWmcfMfQav2UlmWQnKYKEMnIgjkVky2VyNxgMiYlkEQA

This is all intended behavior; different code will typecheck differently (this is how it's possible that some programs are OK but others aren't). One aspect is that Object.keys doesn't return keyof T; see other issues on this.

Thanks for answering, Ryan.
"Object.keys doesn't return keyof T". Right, that helps understanding why TS cannot check this properly. Issue #34591 looks to be similar and it includes a suggestion to iterate with for...in instead.
When you say "This is all intended behavior": Object.keys based iterators are fairly commom practice. So, it would probably make sense to have some documentation on what is exaclty the intended bahavior for these cases, why there is no type-safe way to iterate over an object with a generic set of keys and what the proper options around it look like.
"different code will typecheck differently". Yeap, amen!


feat!: Upgrade MySQL2 to latest version

Changes

Upgrades mysql2 version to ^3.9.7

TL;DR
I don't believe anything is breaking change in terms of db-migrate-mysql, locally all 44 tests are passing using this branch. None the less, to stay on the safe side, I'd release this as v3 of db-migrate-mysql.
Notable changes from v2 to v3 - mysql2

CI

Usage of release-please
Node v18 as default

Community files

Code of conduct
Readme
Typos fix
Security.md
Typings

Updated .d.ts files
New exports in index.js

One
Two

Added support for two new auth plugins

mysql_clear_password
mysql_native_password
Source

Added MFA support in client handshake
Few changes in Quit command - On first glance did not find usages of it
Added more charset constants
Added reverse map for types
Implementation for toPacket; No more throw NotImplemented
Replace throw error with return cb(error)

Taken from this comparison: https://github.com/sidorares/node-mysql2/compare/v2.3.3...v3.0.0#diff-17a31987f7995e11080c24188e0c50f5fbf8436863484273cdb723444da78e5dR177

Hey @wzrdtales, would you mind taking this a look? 🙏

Hi. We're running into issues with this critical vulnerability, so the changes in this PR would be a big help to us as well.

Do you think it's ready to merge @wzrdtales ? It fixes some critical vulnerabilities that should be fixed a long time ago. I'll be glad if you can merge and tag 🙃

I think we can release this, I will release the corresponding driver as a major version though as I can't guarantee nothing breaks.


API for hive registration

There need to be http endpoints for registering and updating Hives. Registration information should include hostname, MAC address and IP address.

Isn't this complete?


[nRF] on-target tests accidentally run twice

nrfjprog.py will apply two resets; this causes the application to be run twice.
This is an inconvenience/usability issue for now, and will become a bigger problem
when there exists automated on-target testing.
Flashing file: /home/sebo/zephyr/tests/crypto/mbedtls/b/zephyr/zephyr.hex
Erasing user available code and UICR flash areas.
Applying system reset.
Parsing hex file.
Reading flash area to program to guarantee it is erased.
Checking that the area to write is not protected.
Programing device.
Parsing parameters.
Writing.
Parsing parameters.
Writing.
Applying system reset.
Run.
Applying pin reset.
Board with serial number 682851688 flashed successfully.

Either nrfjprog.py should keep the core halted to make sure the core doesn't run twice,
or there should exist some kind of communication between the host and the target to make sure
the test is ready to be executed.

***** BOOTING ZEPHYR OS v1.10.99- - BUILD: Dec 18 2017 08:44:51 *****

Running test suite test_mbedtls_fn

===================================================================

starting test - test_mbedtls

starting test - Performing mbedTLS crypto tests:

  SHA-224 test #1: passed

  SHA-224 test #2: passed

  SHA-224 test #3: ***** BOOTING ZEPHYR OS v1.10.99- - BUILD: Dec 18 2017 08:44:51 *****

Running test suite test_mbedtls_fn

===================================================================

starting test - test_mbedtls

starting test - Performing mbedTLS crypto tests:

  SHA-224 test #1: passed

  SHA-224 test #2: passed

  SHA-224 test #3: passed

  SHA-256 test #1: passed

No longer applicable


Keyboard shortcut

Does Nilesoft Shell has keyboard shortcut options?
If has, how I can configure it to my items?

For example for my item which creates new blank file in explorer, I want to run it by pressing CTRL + N when active window is explorer:
item(title='Create blank file' cmd=io.file.create('zfile', null, true) image=\uE10E)

NS doesn't support global keyboard shortcuts - it just displays information about them (or displays whatever you tell it to). You can use another 3rd party app to make the global keyboard combination - with the combination of the two programs you will achieve the desired result

Yeah, I can use AutoHotkey, but, for best performance, better explorer integration and a lot of Nilesoft Shell stuff/functions/proprietes will allow me to do a lot more, easier and faster in one program.

@DanRotaru what was your solution? I'm trying to do the same here, but for "copy as path" it used to be ctrl+shift+c but now its missing.

the original command "copy as path" with the keyboard shortcuts "ctrl+shift+c" is there, in the screenshot you shared: at the bottom of the menu where the cursor is captured

modify(find='"Copy as path"' keys='Ctrl+Shift+C')

add this line in shell.nss before import 'imports/modify.nss'

Yeah, I can use AutoHotkey, but, for best performance, better explorer integration and a lot of Nilesoft Shell stuff/functions/proprietes will allow me to do a lot more, easier and faster in one program.

@DanRotaru what was your solution? I'm trying to do the same here, but for "copy as path" it used to be ctrl+shift+c but now its missing.

In your case you already have explorer native keyboard shortcut (CTRL + SHIFT + C), If you want to just display this shortcut in Shell context menu, you just add keys parameter, or how @RubicBG mentioned use modify command.
Initial I'm talking about a bit different, to execute context menu commands with keyboard. For example like you create a new menu item, "Open this file with my custom program", and create keyboard shortcut for it, e.g. CTRL + / (for now you can only display this shortcut keyboard, but not execute by keypress), always when you press CTRL + /, select a file, and active process is explorer, will be executed this command (open your selected file in specific program). Can be a lot of any others use-cases what can boost a lot your work productivity, using just a single app with owns APIs.
How I specified you can use other apps for that, like Autohotkey. There you can specify keyboard shortcut, write a code which will determine if explorer is active window, and if is selected or not file. Autohotkey provides APIs to work with, but I've open this topic just because for better performance, and as feature request for this util Shell app if is possible to create owns APIs to working with, maybe just some basic like I previously said, not same as autohotkey. That's all:)

@DanRotaru Ah, thank you for this. I was using CTRL+SHIFT+C on my files but whenever i went to paste it nothing was happening.
Bur seriously, i'm not sure what was making it not work.

Can be a lot of any others use-cases what can boost a lot your work productivity, using just a single app with owns APIs.

I understand now. You'd rather use something from within nilesoft shell in order to increase performance over using autohotkey


Its possible Disable Specific days of week?

Hi,
its not possible Disable Specific days of week?
thanks

Not for the moment but I've planned to add it

#60

Hi
@T00rk @donovansolms  can you help me disable specific hours in timepicker i.e, night hours from 10pm onwards?
Thank you


Set up a High Availability etcd Cluster with kubeadm

When starting kubelet with the provided unit file 20-etcd-service-manager.conf in https://kubernetes.io/docs/setup/production-environment/tools/kubeadm/setup-ha-etcd-with-kubeadm/, kubelet crashes, stating that all of the specified flags are either deprecated or completely unknown:
Jun 01 21:46:27 VF001695 kubelet[30937]: Flag --address has been deprecated, This parameter should be set via the config file specified by the Kubelet's --config flag. See https://kubernetes.io/docs/tasks/administer-cluster/kubelet-config-file/ for more information.
Jun 01 21:46:27 VF001695 kubelet[30937]: Flag --pod-manifest-path has been deprecated, This parameter should be set via the config file specified by the Kubelet's --config flag. See https://kubernetes.io/docs/tasks/administer-cluster/kubelet-config-file/ for more information.
Jun 01 21:46:27 VF001695 kubelet[30937]: Flag --cgroup-driver has been deprecated, This parameter should be set via the config file specified by the Kubelet's --config flag. See https://kubernetes.io/docs/tasks/administer-cluster/kubelet-config-file/ for more information.
Jun 01 21:46:27 VF001695 kubelet[30937]: E0601 21:46:27.359201   30937 run.go:74] "command failed" err="failed to parse kubelet flag: unknown flag: --container-runtime"
Jun 01 21:46:27 VF001695 systemd[1]: kubelet.service: Main process exited, code=exited, status=1/FAILURE

If this service file is no longer valid, the documentation should not include it.

/language en
/kind support

it seems kubeadm and kubernete versions are mismatching.
In kubernetes v1-27, the --container-runtime  flag has been removed.
ref: https://kubernetes.io/blog/2023/03/17/upcoming-changes-in-kubernetes-v1-27/#removal-of-container-runtime-command-line-argument

/retitle migrate deprecated flags to config in kubeadm HA etcd page

steps
edit this section
https://kubernetes.io/docs/setup/production-environment/tools/kubeadm/setup-ha-etcd-with-kubeadm/#setting-up-the-cluster
change the example to this
cat << EOF > /etc/systemd/system/kubelet.service.d/kubelet.conf
# Replace "systemd" with the cgroup driver of your container runtime. The default value in the kubelet is "cgroupfs".
# Replace the value of "containerRuntimeEndpoint" for a different container runtime if needed.
#
apiVersion: kubelet.config.k8s.io/v1beta1
kind: KubeletConfiguration
cgroupDriver: systemd
address: <IP_ADDRESS>
containerRuntimeEndpoint: unix:///var/run/containerd/containerd.sock
podManifestPath: /etc/kubernetes/manifests
EOF

cat << EOF > /etc/systemd/system/kubelet.service.d/20-etcd-service-manager.conf
[Service]
ExecStart=
ExecStart=/usr/bin/kubelet --config=/etc/systemd/system/kubelet.service.d/kubelet.conf
Restart=always
EOF

systemctl daemon-reload
systemctl restart kubelet

/help

/assign

@neolit123
Raised PR, please confirm the changes.


Possible beta for  Regression Modeling?

The current task that I'm trying to run requires regression modeling, and I'm wondering if there is any progress for creating a model for regression analysis? For example, if there is some beta code or something similar that I could use, it would be greatly appreciated.

The current task that I'm trying to run requires regression modeling, and I'm wondering if there is any progress for creating a model for regression analysis? For example, if there is some beta code or something similar that I could use, it would be greatly appreciated.

+1


Add basic compatibility with marathon-lb

Add compatibility with labels: HAPROXY_GROUP and HAPROXY_0_VHOST.

HAPROXY_GROUP become a new tag
HAPROXY_0_VHOST become a rule Host:

https://github.com/mesosphere/marathon-lb

/cc @containous/traefik

I'm hopping this to be merged in 1.1 :angel:

@emilevauge done :)
don't hesitate to tell me if this isn't enough

@guilhem needs rebase on v1.1 branch :)

@emilevauge done :)

I think you can squash with 1 button (to remove "merge" commit)


Parameters for dynamic configuration

The dynamic configuration manifest should also include:

Hardware device type (ESP BOX, ESP BOX Lite)
A user label and/or description

Static IP/Gateway/DNS options would be handy. I didn't see that in the current config.

Static IP/Gateway/DNS options would be handy. I didn't see that in the current config.

Nevermind, it looks like you already have it from the screenshot of WAS in another post. Cheers!

Yes, but it doesn't support static IP. Binding a MAC address to a specific IP address will have to be done in your router/DHCP server for now.

Device type was added in c02b457d915d25da88773c7d2d6b2422d4c59d0d.

Once we merge https://github.com/toverainc/willow-application-server/pull/15 this can be closed.


Remove confusing text about control flow after CATCH-statement

In the fourth paragraph under the Remarks header, remove the last sentence since its content is confusing and it is better explained in the leading sentence of the following paragraph.

... If the END CATCH statement is the last statement in a stored procedure or trigger, control is passed back to the statement that called the stored procedure or fired the trigger.
When the code in the CATCH block finishes, control passes to the statement immediately after the END CATCH statement. ...

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 5733f776-615e-9e0e-7df2-8adacf4c3b09
Version Independent ID: 2f6cc6e5-8479-87d1-de8d-9ac97551925d
Content: TRY...CATCH (Transact-SQL) - SQL Server
Content Source: docs/t-sql/language-elements/try-catch-transact-sql.md
Product: sql
Technology: t-sql
GitHub Login: @rothja
Microsoft Alias: jroth

@Bartolomeus-649 -- thank you for your feedback.  I am looking into this document.

@Bartolomeus-649 -- after investigation, I think the existing sentence should stay, as it clarifies a particular case.
I am closing this issue now.  You are welcome to @ mention me for any followup.  We hope to hear from you again.

@WilliamAntonRohm It might clarify one particular case, but at the same time it directly raises the issue abut  what happens when this is not the case. It's normally best when explaining something to  give the generic, broad picture of how something work first, and then, if there are special circumstances which require further explanation, you do them afterwards.
So, if you want to keep it, then it should be moved to after the generic statement. As it is now, it appears like there is something special, "an exception to normal", that happens when the last statement in a CATCH is also the last statement in the procedure.

@Bartolomeus-649 -- you make a good point.  I've updated the document and it should be live by tomorrow.


Refactoring build time configuration

The current configuration mixes build time and runtime config. To separate them, here is what I can come up for build time configuration:
# Certificate to verify SGX enclaves
mr_signer_path = "cert/mr_signer"

# Service provider's root CA certificate to verify clients
sp_root_ca_cert_path = "cert/ca.crt"

# Intel Attestation Service root CA certificate to verify attestation report
ias_root_ca_cert_path = "cert/AttestationReportSigningCACert.pem"

# Auditors' public keys to verify their endorsement signatures
auditors_public_key_path = [
    "auditors/godzilla/godzilla.public.der",
    "auditors/optimus_prime/optimus_prime.public.der",
    "auditors/albus_dumbledore/albus_dumbledore.public.der"
]

# RPC max message size
rpc_max_message_size = 409600

This is also related to #131.

According to #135, mr_signer_path is useless. Here is an update of the build time config file:
# Service provider's root CA certificate to verify clients
sp_root_ca_cert = { path = "../cert/ca.crt" }

# Intel Attestation Service root CA certificate to verify attestation report
ias_root_ca_cert = { path = "../cert/AttestationReportSigningCACert.pem" }

# Auditors' public keys to verify their endorsement signatures
auditor_public_keys = [
    { path = "../auditors/godzilla/godzilla.public.der" },
    { path = "../auditors/optimus_prime/optimus_prime.public.der" },
    { path = "../auditors/albus_dumbledore/albus_dumbledore.public.der"},
]

# RPC max message size
rpc_max_message_size = 409600

The corresponding generated code will be like this:
format!(r#"
    pub struct BuildConfig<'a> {{
        pub sp_root_ca_cert: &'a [u8],
        pub ias_root_ca_cert: &'a [u8],
        pub auditor_public_keys: &'a [&'a [u8];{}],
        pub rpc_max_message_size: u64,
    }}

    pub static BUILD_CONFIG: BuildConfig<'static> = BuildConfig {{
        sp_root_ca_cert: {},
        ias_root_ca_cert: {},
        auditor_public_keys: {},
        rpc_max_message_size: {},
    }};"#,
        config.auditor_public_keys.len(),
        sp_root_ca_cert,
        ias_root_ca_cert,
        auditor_public_keys,
        config.rpc_max_message_size
    )

Fixed by #139.


Geometry and Mesh information lost when creating the xacro file

I have the problem that the tags with the information "visual" and "collision" completely disappear during most conversions from urdf to xarco format.
Is there a reason why this can happen?
URDF

Xacro

The script checks if the mesh file for a link exists and deletes all  and  tags for links if this is not the case. I used this to create some links that are purely for tf but have no mesh themselves (typical examples are stuff like base_link, tool0, ...). It might be that there is something going wrong there.
The corresponding code is in these lines https://github.com/SammyRamone/sw2urdf_ros2/blob/69d7443494238a207857b51645736b07c6e63c31/conversion_urdf_ros_2_ros2.py#L152-L164
Basically it goes through all stl files it can find and checks which links are using these. The corresponding links keep their visual and collision tags and all others are removed.
First, you can check if stl_files array contains any members. If not your stl files are not correctly found for some reason.

Thanks for your help,
I did uncomment the lines and found that 'visual' and 'collision' apears twice, e.g. visual/visual

That could be the reason:

Here line 118 and line 124 seems to be the same.

Ah correct this line is duplicated somehow. It probably never triggered any issues because my source and target URDF names where different. I removed the duplicated line in the last commit.
This wrongly changed names probably lead to the STL files not being found and then being removed later. Please try again with the newest version if it works.

Have tested it right now.
It seem to work properly!
Thank you very much!
Another small suggestion for improvement.
At the beginning we could search for the Solidworks output folder, and if it doesn't exist, we could leave the script directly.

Another small suggestion for improvement. At the beginning we could search for the Solidworks output folder, and if it doesn't exist, we could leave the script directly.

Good suggestion, I added it in the last commit.

Another small suggestion for improvement. At the beginning we could search for the Solidworks output folder, and if it doesn't exist, we could leave the script directly.

Good suggestion, I added it in the last commit.

Thank you very much!


Show Tags for Post

show tags for post

If you want i can do the part in the create-view as i've played around with the medium.js-contenteditable before :)


Update Dockerfile definition

Description
Update the Dockerfile definition according to the Spring Boot documentation. For security, absolute paths are implemented in the execution of the jar.
Checklist

[x] The pull request is complete according to the guide of contributing
[ ] Automated tests are written
[x] The documentation is up-to-date
[x] The pull request has a descriptive title that describes what has changed, and provides enough context for the changelog
[ ] If the pull request has changed structural files, you have implemented an UpgradeAction according to the guide
[ ] If the pull request has a new Gradle Task, you should add Analytics according to the guide

Sorry @luisgomez29 for not merge your pull request, this change will be made on java 21 support


fix: add support for null value in boolean editor

Bugfix, fixes: #57
Created a new boolean editor, which is select, so that it allows null, true and false as options to it.

What do you think about this change @MildTomato? The only problem with select input is that it's not auto open on editting.
on Enter, it will show the select input

user needs to click it again to be able to select the item

@harshithpabbati, do you have any suggestion for the problem above? I wonder if we can automatically show the dropdown list on entering editing state


How to change ButtonBarView Layout Direction Dynamically??

Hello Team,
I am using this library with the combination of side menu.
i have ButtonBarPagerTabStripViewController with 4 tab items like (barItem1, barItem2,barItem3,barItem4).
In English layout, it was displayed in order 1,2,3,4 and when I change the language to Arabic need to change "ButtonBarView Layout Direction". So it can display in the same order with reverse direction.

Fixed.


Mast: Watch merestone.com

Mast requests the watch of the watch_keyword merestone\.com. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

merestone\.com has been seen in 1 true positive, 0 false positives, and 0 NAAs.

Approved by tripleee in Charcoal HQ


You must have at least one Order Status.

When trying to save settings I get the error message 'You must have at least one Order Status.'
Yet in the Order Statuses sections there is no way to create these?

I uninstalled and reinstalled the package and all is well, presumably the upgrade from <IP_ADDRESS> to <IP_ADDRESS> caused this problem, not sure if really an issue at this point?

I reckon this could still be a problem with the update.
But it's a bit strange that they'd disappear, the only place where they are wiped is during install (incase there was a previous install), they shouldn't have been touched during upgrade...


Add Kubernetes kustomize support

What does this change
Kubernetes mixin add kustomize support，so we can use porter in CI/CD or other various scenes.
What issue does it fix
N/A
Notes for the reviewer
The command line of kubectl add -k flag, and the mixin definition can use k8s manifest and kustomize both for deploy complex environment
Checklist

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: JiangZhaoYang sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

Since kubernetes mixin kubctl already up to the latest (v1.15.x) version, and kubctl version > 1.14.x support kustomize, so i add it. I think it can provide more scenes to be used for Porter.

Thank you for the PR @JiangZhaoYang !
Before reviewing and testing out the logic in this PR, I wanted to mention that we'd prefer the Kustomize logic be contained in its own mixin.  We'd been meaning to rename the pre-existing Kubernetes mixin to kubectl to make clearer its intended scope.  With this in mind, having a separate kustomize mixin focused on the corresponding cli would be preferable.
Coincidentally, it looks like there is a pre-existing Kustomize mixin in https://github.com/donmstewart/porter-kustomize.  I wonder if it makes sense to see if we can build off of this mixin first (perhaps add some examples, add changes, etc.)?  WDYT?
Also, perhaps for future reference (if you hadn't already seen it), new Porter mixin repo creation and distribution steps exist in https://github.com/deislabs/porter-skeletor.  This should be the fastest track towards setting up a new mixin repo and using it in Porter bundles.

Oops, I did not found kustomize mixin in this repo, so I add it. Thanks for detailed reply. I think whether to create a separate mixin for Kustomize depends on whether Kubectl supports it well. At this time, Kubectl is not fully compatible with Kustomize, so use separate Kustomize mixin maybe a good choice. I will check https://github.com/donmstewart/porter-kustomize to see if i can do something

Great, thank you @JiangZhaoYang .  Indeed, we need to think about how to enable mixin discovery for those that are developed under organizations outside of deislabs -- otherwise they can/will be easily missed.

Since it sounds like we've decided to have this in a separate repository I am going to close this PR. If you need help finding a home for it, just let us know!


Debug console for karate UI

Code changes for https://github.com/intuit/karate/issues/576 and https://github.com/intuit/karate/issues/575

Relevant Issues : (compulsory)
Relevant PRs : (optional)
Type of change :

[1 ] New feature
[1] Bug fix for existing feature
[ ] Code quality improvement
[ ] Addition or Improvement of tests
[ ] Addition or Improvement of documentation

@babusekaran thanks I may take a day to check this.


Upgrade project to RN61 with CocoaPods

Remove componentWillMount functions
Remove PushNotificationIOS
Add pod install step to lerna bootstrap

Todo:

[ ] Figure out CI
[ ] Remove iOS sample projects from CI (no desire to maintain them with CocoaPods or at all)

It seems like the latest version of Detox works fine with v0.61.4 of react-native as well: https://github.com/msand/react-native-svg-e2e/pull/13

This PR is only bureaucracy to get the test project and CI to work with 61.x. Detox on iOS should support RN 61 without issues as far as I know.

Any known issues on android? At least building and taking screenshots of all the tests in the rnsvg-e2e repo seem to work correctly.

Android is tracked here: https://github.com/wix/Detox/issues/1731

@rotemmiz Reminder. Thanks

You're welcome @LeoNatan 😗

It just werks???

Somehow the builds are red now - with stuff related to pods, @LeoNatan could you check it out plz?

@d4vidi Sure

@d4vidi The error is caused by postinstall somehow:

08:06:53 lerna ERR! execute Error occured with 'undefined' while running 'npm run postinstall'

And since cocoa pods looks for its dependencies in node_modules/, it fails.


398441

Good morning.  I'm sure it is something simple but I'm getting an error when I try to run the process-migrator -- mode=export --config=./configuration.json command.  For my sourceURL I have tried both https://XXXXXX.visualstudio.com and https://dev.azure.com/XXXXXX and every time I run the command, I get [Configuration validation] Missing or invalid source account url: 'undefined'
It looks like I ran the installation in the C:\Windows\System32 so that is where I am running the command.
Any help?
Thank you,
Ford

I was putting the URL in the wrong place.  It should be "sourceAccountUrl":"https://XXXX.visualstudio.com"

We will release an update addressing previous problems. For new issues, create a ticket, and we'll resolve it promptly. Thank you .


Identifying winners in CONTRIBUTORS.md and cleaning up README.md

I added the trophy emoji to the winners of each challenge (except day 7). Also added to the table in README.md

From all of us on the Cloud Advocacy team at Microsoft, thank you for creating this pull request!
Have a Happy Holiday season!


add opensea and etherscan indexed function and variable

Hello, ens team,
We have noticed display issues on NFT marketplaces and etherscan that could be fixed by adding a few variables.

The unidentified contract can be fixed by adding a variable "name" in the smart contract (maybe inside the erc1155Fuse.sol file) that the user could set up using the contract at contract deployment.

The max Total supply issue on Opensea can be fixed by adding a function named "totalSupply()"

Thank you for your time.

Hi sorry for the very slow reply to this.
We will add the name to the contract, but we won't be adding the total supply as it adds additional overhead to the contract for limited gain. I'll open a new PR for this instead editing this PR, so I'll close this. Thanks for the original PR.


Change carb ratio incriminates to 0.1 g/U

Is it possible to set carb ratio in less than 0.5 g/U incriminates?
Would be good to make small tweaks like from 5.5 to 5.3 opposed as 5.5 to 5.0.

Done 1d237e7c7245db3340a7c18bc76266d3fd34776f


Add example of literalinclude syntax to the manual how-to guide

#66 makes use of the literalinclude directive to pull content from a source file and display it in the docs. Since the contributors' guide does not currently include an example of how to do that, one should be added.

I wouldn't mind doing this since I just added it. Do you think we should add this to Section 5.4.7: Other test blocks"?
I haven't responded to an issue before, but it seems the easiest way to handle this would be through a pull request referencing this issue. How does that sound?

@timothyas yes that would be the best place I think.
FYI I'm in the process of adding significant content/edits to that chapter; howeverI think it might merge ok automatically, at worst we can hand-merge into my PR.

You probably already know, but if you include "fixes #66" or "closes #66" or one of a number of similar keywords in a commit message or the pull request description, then GitHub will automagically link the PR and this issue, and close the issue when the PR is merged.


[AVM Module Issue]: Feature Request: VMSS autoscaling settings

Check for previous/existing GitHub issues

[x] I have checked for previous/existing GitHub issues

Issue Type?
Feature Request
(Optional) Module Version
0.4.0
(Optional) Correlation Id
No response
Description
I would like for this AVM module to have the ability to set custom autoscale settings

This feature is available in CAF modules and this functionality could be added with azurerm - azurerm_monitor_autoscale_setting https://registry.terraform.io/providers/hashicorp/azurerm/latest/docs/resources/monitor_autoscale_setting

Update: Functionality has been proposed as a seperate AVM module as avm-res-insights-autoscalesettings @ https://github.com/Azure/Azure-Verified-Modules/issues/1684


Transfer R analysis and plotting example notebooks from the Terra Not…

…ebooks Playground workspace.
Also updated title at the top of the notebook to reflect that of the filename.

@carbocation this LGTY?

Unrelated to this PR:

@akovalsk see comment from @melissachang and consider updating https://github.com/DataBiosphere/notebooks/pull/9
I will revert the README changes I made in https://github.com/DataBiosphere/notebooks/pull/6 in lieu of those in https://github.com/DataBiosphere/notebooks/pull/9

Looks good to me. Thanks @deflaux !


raftstore: remove applying snapshot count

Signed-off-by: Ryan Leung<EMAIL_ADDRESS>
What problem does this PR solve?
Issue Number: close #10094
Problem Summary: Since https://github.com/tikv/tikv/pull/4066, the applying_snapshot_count is no longer taking effect because it is never assigned a value.
What is changed and how it works?
What's Changed: This PR remove it since it has already been contained in receiving count. See https://github.com/tikv/tikv/blob/f81592b0f18b76e79b4f146124c0c1625867e222/components/raftstore/src/store/snap.rs#L1428
Related changes

Need to cherry-pick to the release branch

Check List
Tests

Unit test (existing tests are not affected)

Release note

Fix the issue that the apply snapshot count is always zero.

/merge

/merge

I don't get it. So this PR doesn't fix the problem by actually assigning the apply count, instead, relying on the wrong receiving count?

I don't get it. So this PR doesn't fix the problem by actually assigning the apply count, instead, relying on the wrong receiving count?

IMO, the applying count isn't very useful.

Why? It can hint whether the is a snapshot taking long time or whether jitters are caused by applying snapshots.

Why? It can hint whether the is a snapshot taking long time or whether jitters are caused by applying snapshots.

Otherwise, we won't take a long time to find that it has a problem. Currently, we can get the applying time through another metrics.

Why? It can hint whether the is a snapshot taking long time or whether jitters are caused by applying snapshots.

Otherwise, we won't take a long time to find that it has a problem. Currently, we can get the applying time through another metrics.

Applying time only shows up when it's finished. For example, a stuck apply won't show in the metrics.


Pull Request Fails in Circle Ci when the job needs download a cache created in a previous job

Current behavior:
Greenkeeper Pull Request Fails in Circle Ci when the job needs download a cache created in a previous job

Desired behavior:
Should be able to download cache folder for run build job.
job with error: https://circleci.com/gh/ngChile/escalando-aplicaciones-con-angular/346?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-checks-link

heya @gpincheiraa, could you explain how this is specific to Greenkeeper?


inputmode not working

Describe the bug
I want to set inputmode to get the correct keyboard on touch devices but it its not working.
I tried it on Windows with Firefox and iOS Safari.
The attribute is never set.
Example
oInput.inputmask('decimal', { positionCaretOnTab: false, inputmode: "numeric", radixPoint: ",", allowMinus: poWidgetFormat.AllowNegative, rightAlign: false, integerDigits: poWidgetFormat.MaxLength, digits: 0 });
Please complete the following information:

OS: iOS and Windows
Browser Safari and  Firefox
Inputmask version 4.0.8 and 5.0.0-beta.258

@movedoa ,
I found a typo in inputmode.
Can you have a try with version  5.0.0-beta.270
Also verify that you os/browser supports it. https://caniuse.com/#feat=input-inputmode

It works with your fix. Thx.
Is 5.0.0 ready for production?
If not could you backport this to 4?

@movedoa ,
I give you the choice.  I also released v4.0.9 with a fix for inputmode.
Although 5.0.0 beta is, in my opinion, superior to the 4.x branch already, there are some small issues to iron in the numeric alias, before I want to release 5.0.0.

Thank you very much. Great work.


Update date_select_with_label opts handling in forms_helper.rb

coverage: 93.441% (-0.002%) from 93.443%
when pulling 59c54495e31fca18b858e614a19f72521a86f353 on date-select-option-refinement
into cd2ee21bb2985c8638da23cb231a74f2bac06bef on main.


Add support for .tak audio

This is really a suggestion, not an issue, however it may be worth looking at TAK audio in addition to FLAC for lossless audio, as it allows for even better lossless compression than FLAC.  There's a CLI version of the compressor available, so parameters should be able to be passed in using a similar method as the other supported codecs are.  Here's some information about TAK if you're not familiar with it: https://wiki.hydrogenaud.io/index.php?title=TAK

I looked into this a bit. The TAK encoder only seems to be working with .wav files, where I need it to work with pcm files. (raw audio data, as it is on the CDDA)
FFmpeg works well , because it supports converting from and to PCM CD Audio out of the box, also ffmpeg does seem to have some TAK functionality but it only supports decoding from it, not encoding to the format. (which can't work, we need both encoding+decoding)
Perhaps there is a way to quickly convert a PCM->WAV so it can be passed to the TAK encoder. I want to avoid copying PCM files to entirely new WAV files, Perhaps there is a way of adding some header data at the beginning of the PCM files to convert them to WAV? And them from TAK->WAV I could just strip the headers and have raw PCM.
I'm leaving this open, I will come back to it!

Yeah, it works, I can do this with piping output from ffmpeg to takc. So a PCM can be converted to TAK on the fly. And the codec does seem to be fast and produce nicely compressed results.
I'll implement this soon!

Nice!


feat(sdl): can set credentials

One can select an image repository and enter credentials after this. Available in the SDL Builder, but not in the deployment UI.
ref #467

The credentials for private repos are optional, since not all repos are private. The way you implemented it is great, we just need to add a flag like "hasGpu" and conditionally add the validation. So a simple checkbox like the hasGpu to toggle the form controls should do it.
Is there a reason behind the canChangeCredentials? We would like to have it in all the SDL builder instances (SDL Builder page and new deployment page).

I added the flag canChangeCredentials because I figured it is not needed for templates on the Deploy page. Now I see it is very much needed there too, so removed. Now it is all the same for Deploy and SDL Builder.
Added a checkbox with label "Private" on top the box, revealing credential fields only when you click it.


CLI: try to delete non existing registry entry just returns not readable error

[user@PC woodpecker]$ ./dist/cli/linux_amd64/woodpecker-cli registry rm --hostname docker.io test/testCI
[user@PC woodpecker]$ ./dist/cli/linux_amd64/woodpecker-cli registry rm --hostname docker.io test/testCI
 FTL error running cli error="client error 500: Error deleting registry \"a\". sql: no rows in result set"

woodpecker version: d02dfe993f4cc94bd8e87f454e17bbea8eea592d

is it just to catch the error and return the error, while deleting using CLI? If so,  I can return just return "hostname and repo does not exist", if not then can you explain bit more. I would want to contribute

I have raised pull request for this issue, can you please review it.


Setting "editor.tabSize" is ignored

I have setting "editor.tabSize": 4. But "format document" command change indents to 2 spaces.
It happens in Svelte-files only.

Using a prettier config file works, thank you.

@UnwrittenFun I've Prettier extension installed, with the following manual setting:
"prettier.tabWidth": 4
But svelte formatting isn't respecting that. Do I explicitly need a prettier config file or should the VSCode Setting work as well?

You currently specifically need a prettier config file

It's not working with a prettier config file. I assume I can just add to the top level directory and that I don't need to install anything prettier related that doesn't come with this plugin.

To piggyback on @ricardomatias last comment - it looks like you need to restart VS Code after editing the .prettierrc file, not just adding it. If I have a tabwidth of 2 and restart, it formats correctly. If I change it to 4, the reformat doesn't do anything. I have to restart VS Code then re-run the reformat. Then it'll change to 4.


README updates

@homu r+

:pushpin: Commit 325031f has been approved by poteto

:zap: Test exempted - status


Fix data-pause documentation for carousel

Carousel option data-pause expects boolean “false”. “null” causes js error!

That's true we have an error with this message : CAROUSEL: Option "pause" provided type "null" but expected type "(string|boolean)"


Fixing handling ImageRepoSecret in worker pod

Since moving to using container-runtime and init-container for pull kernel module container image, we need to set the ImageRepoSecret(if defined) in the worker Pod and also there is no need for mapping ImageRepoSecret and secrets of the SA into worker pod volumes (was need for crane) This PR does the following:

set ImageRepoSecret into the worker Pod, if defined in the KMM Module 2) remove creating volumes for SA's secret and ImaRepo secret in the
worker pod
remove pullSecretHelper interface implementation as not needed 4) uni-test updates

/test operator-upgrade

/test e2e

/test operator-upgrade

/test operator-upgrade

/override ci/prow/operator-upgrade

/lgtm

cherry-pick release-2.2

/cherry-pick release-2.2


Add Codecov and  Maintainability badges

Codecov Report

:exclamation: No coverage uploaded for pull request base (develop@61fe1b0). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             develop      #12   +/-   ##
==========================================
  Coverage           ?   78.16%
==========================================
  Files              ?       42
  Lines              ?      458
  Branches           ?        0
==========================================
  Hits               ?      358
  Misses             ?      100
  Partials           ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 61fe1b0...5f6b9ef. Read the comment docs.


Add baseline profiles

@keyboardsurfer any chance you can give this a review to see if I'm doing this correctly? This commit should be representative of all of the other changes.
Some questions that I had are:

Is it possible to only have one baseline-profiles module instead of one per sample app?
How frequently should the profiles be updated? On every merge into main? When releasing? Is there a standard way of doing it (e.g. manually vs CI, etc...)?


Pr 15

rebase #15

Is there a chance that this PR be merged @rwjblue? Else I will have to use the @stefanpenner 's branch...

I don't even remember writing this :p

Thank you @rwjblue @stefanpenner and @ramybenaroya :)

Could someone please update the broccoli-jshint NPM package with this new and very useful feature.

@rwjblue @stefanpenner
yes its been a while...looks like, its still not published. This is really required

@SSS2557 it was published, about 2 months ago.

oh!
sorry about the call out then :)
For some reason, I can't get it to work, looks like we may have a bug :cry:
I'll dig in to see whats up and keep you posted in any case

I'll dig in to see whats up and keep you posted in any case

:+1:


document need to build automationtool and automationtoollauncher manually?

Related to my experiences in #12: When those weren't built, binary builder failed in somewhat cryptic ways. It took me some poking around to figure out that they're built as part of UE4. Either i'm doing something wrong or it might be good to document that those need to be made manually first (and maybe anything else). Probably optimally those errors would be caught and replaced with instructive output?

Documentation added. Thanks to @tng2903


make "smart_cond" api public and reusable

Fix #13903
Move the implementation of "smart_cond" and "constant_value" from tensorflow/python/layers/utils to tensorflow/python/ops/control_flow_ops and add corresponding test and expose smart_cond to tensorflow/python/ops/standard_ops.
@martinwicke should I implement the API in this way or not? As I think ops should be lower level API than layers and smart_cond should be a kind of ops. It's my first time to contribute to TensorFlow. Please feel free to correct me if there's any problem with the design and codes.
Tips, I closed the former PR #13938 and create a new since there's some signature/info problem with that PR.

@netheril96 Good point, I changed the naming schema. By the way @drpngx do you think we should remove the fn1 fn2 parameters in cond API? They seems redundant.

Jenkins, test this please.

The XLA tests are failing because of this:
FAIL: //tensorflow/compiler/tests:conv3d_test_gpu (shard 5 of 5) (see /var/lib/jenkins/workspace/tensorflow-pull-requests-xla/bazel-ci_build-cache/.cache/bazel/_bazel_jenkins/eab0d61a99b6696edb3d2aff87b585e8/execroot/org_tensorflow/bazel-out/local_linux-py3-opt/testlogs/tensorflow/compiler/tests/conv3d_test_gpu/shard_5_of_5/test.log).
INFO: From Testing //tensorflow/compiler/tests:conv3d_test_gpu (shard 5 of 5):
==================== Test output for //tensorflow/compiler/tests:conv3d_test_gpu (shard 5 of 5):
Running test tensorflow/compiler/tests/conv3d_test_gpu --test_device=XLA_GPU --types=DT_FLOAT,DT_DOUBLE,DT_INT32,DT_INT64,DT_BOOL,DT_COMPLEX64 on GPU 4
Traceback (most recent call last):
  File "/var/lib/jenkins/workspace/tensorflow-pull-requests-xla/bazel-ci_build-cache/.cache/bazel/_bazel_jenkins/eab0d61a99b6696edb3d2aff87b585e8/execroot/org_tensorflow/bazel-out/local_linux-py3-opt/bin/tensorflow/compiler/tests/conv3d_test_gpu.runfiles/org_tensorflow/tensorflow/compiler/tests/conv3d_test.py", line 24, in <module>
    from tensorflow.compiler.tests.xla_test import XLATestCase
  File "/var/lib/jenkins/workspace/tensorflow-pull-requests-xla/bazel-ci_build-cache/.cache/bazel/_bazel_jenkins/eab0d61a99b6696edb3d2aff87b585e8/execroot/org_tensorflow/bazel-out/local_linux-py3-opt/bin/tensorflow/compiler/tests/conv3d_test_gpu.runfiles/org_tensorflow/tensorflow/compiler/tests/xla_test.py", line 35, in <module>
    from tensorflow.python.ops import variables
  File "/var/lib/jenkins/workspace/tensorflow-pull-requests-xla/bazel-ci_build-cache/.cache/bazel/_bazel_jenkins/eab0d61a99b6696edb3d2aff87b585e8/execroot/org_tensorflow/bazel-out/local_linux-py3-opt/bin/tensorflow/compiler/tests/conv3d_test_gpu.runfiles/org_tensorflow/tensorflow/python/ops/variables.py", line 27, in <module>
    from tensorflow.python.ops import control_flow_ops
  File "/var/lib/jenkins/workspace/tensorflow-pull-requests-xla/bazel-ci_build-cache/.cache/bazel/_bazel_jenkins/eab0d61a99b6696edb3d2aff87b585e8/execroot/org_tensorflow/bazel-out/local_linux-py3-opt/bin/tensorflow/compiler/tests/conv3d_test_gpu.runfiles/org_tensorflow/tensorflow/python/ops/control_flow_ops.py", line 75, in <module>
    from tensorflow.python.ops import variables
ImportError: cannot import name 'variables'

Some missing dependency?

Jenkins, test this please.

Jenkins, test this please.

Someone from tensorflow needs to trigger the builds, sorry you can't do it yourself.

Same sycl issue, let's try again.

Jenkins. test this please.

@drpngx @martinwicke Seems that it needs to resolve a merge conflict.

@martinwicke @drpngx Please retest the function again as there ware some merge conflicts before. Thanks

Jenkins, test this please.

Seems that docker build failed:
Build timed out (after 90 minutes). Marking the build as failed. tensorflow/tools/ci_build/ci_build.sh: line 130: 16143 Terminated docker build -t ${DOCKER_IMG_NAME} -f "${DOCKERFILE_PATH}" "${DOCKER_CONTEXT_PATH}" ERROR: docker build failed. Dockerfile is at /var/lib/jenkins/workspace/tensorflow-pull-requests-cpu-python3/tensorflow/tools/ci_build/Dockerfile.cpu

Infra failure. You passed other GPU Py3 tests though, so this is fine to merge. @sb2nov FYI.

@sguada WDYT of @GeorgyZhou argument?
@GeorgyZhou please pull rebase and push again

Nagging Assignee: It has been 14 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Sync and fix the failing tests

@GeorgyZhou can you fix the failing test? constant_value is apparently used in contexts which require the current behavior.

Here's the log:
File "/tmp/botexec/bazel-out/k8-opt/bin/tensorflow/python/keras/backend_test.runfiles/org_tensorflow/tensorflow/python/layers/normalization.py", line 544, in call
training_value = utils.constant_value(training)
File "/tmp/botexec/bazel-out/k8-opt/bin/tensorflow/python/keras/backend_test.runfiles/org_tensorflow/tensorflow/python/layers/utils.py", line 220, in constant_value
return control_flow_ops.smart_constant_value(pred)
File "/tmp/botexec/bazel-out/k8-opt/bin/tensorflow/python/keras/backend_test.runfiles/org_tensorflow/tensorflow/python/ops/control_flow_ops.py", line 2103, in smart_constant_value
raise TypeError('pred must be a Tensor or a Python bool.')
TypeError: pred must be a Tensor or a Python bool.

Sure. I will resubmit soon today

Thanks for lint correction! @martinwicke

Anybody can merge it or can review it? @drpngx @martinwicke

Thanks for the ping!


ENH: Add pcoa biplot method

Allows users to project descriptors into an existing PCoA matrix
Brief summary of the Pull Request, including any issues it may fix using the GitHub closing syntax:
Adds a new method to project variables into a PCoA matrix. This depends on busywork to update the conda recipe (as the method depends on scikit-bio 0.5.3).
A subsequent q2-emperor PR will allow for users to see these results.
questions:
I wondered whether or not I should add an annotation to the PCoAResults type. Namely something like PCoAResults[Biplot]. This way this method would output a PCoAResults[Biplot] artifact that can only be consumed by q2-emperor's biplot method. If reviewers think this makes sense, I'll add the proper changes in q2-types.

I think using PCoAResults % Properties("Biplot") would make sense, since the biplot is just extra information making the PCoAResults a more refined type. It would be usable anywhere PCoAResults is useable, but then methods can request the specialized variant if needed explicitly.

Just one comment, otherwise LGTM


Google Smart Home Not Working

we have submitted google smart home twice for google certification. First time it got rejected because we did no implement report state. But device operation through google home was successful and there were no issues.
Second time the rejection reason is google home is not responding for EXECUTE intent. before shipping our devices we tested our devices using google assistant it was working fine. Now when i look in google log i can see two errors

Back_end FAILURE
Agent Responded Empty Json

When i say turn on and turn off intents, devices are operated but assistant is not responding back
This was working fine earlier and i have not made any changes
Then i have created a new project with the same back end code and that was working fine. we did not change anything for our side and the newly created project was working and google home was responding also.

I see you also filed this issue on the public issue tracker, so I'm closing this instance.


Image Source URI vs URL

When adding an image that references a remote file, Android accepts only uri and iOS accepts both uri and url. This is a frustrating bug as you can be working in iOS fine and it breaks silently in Android (images just don't render). Even in the examples this bug exists: url vs uri in the same file.
Looking at the type definition, uri is the correct one. We should probably have a good error message if you use url instead.

React Native version: 0.43.0 (but the issue exists on master as well)
Platform: both
Development Operating System: MacOS

Can you send a PR to fix the documentation issue? We should be using uri consistently.

@hramos 👌 https://github.com/facebook/react-native/pull/13496

Hi there! This issue is being closed because {:search=>"repo:facebook/react-native is:open is:issue updated:<2017-05-25 -label:"Good First Task" -label:"Help Wanted" ", :message=>"it has been inactive for a while"}. Maybe the issue has been fixed in a recent release, or perhaps it is not affecting a lot of people. Either way, we're automatically closing issues after a period of inactivity. Please do not take it personally!
If you think this issue should definitely remain open, please let us know. The following information is helpful when it comes to determining if the issue should be re-opened:

Does the issue still reproduce on the latest release candidate? Post a comment with the version you tested.
If so, is there any information missing from the bug report? Post a comment with all the information required by the issue template.
Is there a pull request that addresses this issue? Post a comment with the PR number so we can follow up.

If you would like to work on a patch to fix the issue, contributions are very welcome! Read through the contribution guide, and feel free to hop into #react-native if you need help planning your contribution.


weather example does not work?

Hello. The weather app example didn't work. I followed the tutorial and my code didn't work. I tried it with the code here, it didn't work either.
I also changed the api key to mine. It didn't help.
The error in the console
Uncaught TypeError: Super expression must either be null or a function, not undefined
Is it only for me? or does anybody have a same issue?

I have the same exact problem.  Using my api key did not improve.

This appears to be related to the spark-lines plugin.   Installing version 1.6.0 should resolve the issue (at least it did for me).
https://stackoverflow.com/questions/45604732/super-expression-must-either-be-null-or-a-function-not-undefined-when-using-rea


Fix warnings in animation and animationWithKeyPath: methods

This fixes the new warnings that come up with Xcode 6.

Can you please update the pod spec?  Thanks for continuing to support this great Controller!

@DoctorG will with the next iteration, which I can currently only say is coming soon (a point update addressing glitches and quality, no API changes). For now I recommend you use it like so:
pod 'PKRevealController', :git => 'https://github.com/pkluz/PKRevealController.git', :commit => ' b9e7521'

or (if you are into always running the most recent version)
pod 'PKRevealController', :git => 'https://github.com/pkluz/PKRevealController.git', :head

I didn't realize you could do that.  Thank you!


Implement Provider interface for modular and non-modular apps.

This makes it possible to build applications and libraries with a sole compile-time dependency on secp256k1-api. At runtime either the native (aka foreign or ffm) or Bouncy Castle implementation (when complete) can be "used".

Define the Secp256k1Provider interface and two implementations with no-arg constructors.
Add the get() and getByName() methods to the Secp256k1 interface
Update module-info files with provides and uses statements.
Add resource files for service provider location in non-modular apps.
Remove direct dependencies on implementations from the examples
Run the Java example application as a modular application
Switch the Kotlin example default app to Ecdsa.java

@schildbach I just converted this to Draft, because I think the following PRs should be merged first:

PR #43
PR #44
PR #45

Once those are merged this one can be rebased.

PR #47 breaks out one minor change from this PR that can be merged separately.

I'll review this once the others are merged and this one rebased.

@schildbach Ready-for-review!


GetWalks does not work with FederatedOperations

Describe the bug
Since 2.0.0, we prefer users to use a FederatedOperation rather than the deprecated graphIds option. However, this does not work as an operation within GetWalks. This is problematic as it is undocumented and relies on users using a deprecated option.
To Reproduce
Steps to reproduce the behaviour:

GetWalks(input=1, operations=[FederatedOperation(operation=GetElements(), graphIds=[A])])
This operation will not build

Expected behaviour
It should work fine with both the graphIds option and a FederatedOperation.
Stack trace and errors
ConnectionError: HTTP error 500 : {"statusCode":500,"status":"Internal Server Error","simpleMessage":"Operation chain is invalid. Validation errors: \nNo hops were provided. A hop is a GetElements operation that selects at least 1 edge group."}

Additional context
Looking at the stack trace, this seems related to this check inside the GetWalks validation:
https://github.com/gchq/Gaffer/blob/dde023fb2f4a2c585612f3a382f4f76b1933aada/core/operation/src/main/java/uk/gov/gchq/gaffer/operation/impl/GetWalks.java#L163-L174
Platform

Gaffer Version: [e.g. 2.0.0]

Isn't it possible to workaround this issue by placing the GetWalks inside the FederatedOperation? At least for where a single graph is queried? I don't see an easy solution otherwise. It works with the deprecated option because the federation is applied at a different level.
FederatedOperation is not a core operation, so it can't be referenced from GetWalks. I think it would be reasonable if GetWalks only supported the operations provided in that code snippet. Adding special handling for FederatedOperation into the operation probably isn't practical as it would require refactoring the FederatedOperation to make use of some kind of intermediate core class - to hold the information about the inner GetElements.
Assuming that hops value of 0 is not useful, I would suggest changing GetWalks to provide an error explaining which Operations are meaningful to use with it.
Alternatively, this could be fixed by introducing a special FederatedGetWalks operation.

Isn't it possible to workaround this issue by placing the GetWalks inside the FederatedOperation? At least for where a single graph is queried?

This would result in the whole GetWalks going to one subgraph, whereas instead we want to walk across multiple subgraphs.

FederatedOperation is not a core operation, so it can't be referenced from GetWalks

This is correct, eventually though I realised that FederatedOperation could implement the Operations interface (and probably should have all along). In my solution I just added it to get these tests passing, but I think that FederatedOperation should be refactored to make proper use of the Operations interface: https://github.com/gchq/Gaffer/issues/3078.


Redis exception if configuration is missing

I noticed that if the user enable the 'Redis Output Cache' for any reason (maybe by mistake), the site will go down until provided the appropriate configuration (valid connection string), I think this module should check for it's configuration and if it's not presented it must disable redis cache functionality without throwing an exception.

i think there is an outstanding PR for this - https://github.com/OrchardCMS/Orchard/pull/6876

Yes, you are right, this fix is not included in Orchard 1.10.1, maybe in future releases.

True, I fixed it.


Fixed the compatibility issues for recent Rust Nightly (1.29 / 6a1c0637c 2018-07-23)

Thank you very much for contributing!


Metadata version mismatch for module<EMAIL_ADDRESS>found version 4, expected 3, resolving symbol ComponentsModule

found version 4, expected 3, resolving symbol ComponentsModule
Hi there!
I created an app with angular and covalent time ago. I've been developing it for long time. It happens that now, when I've tried to install it in another machine I realized I had a problem. I'm trying to solve it since four days and I still not knowing what should I do for it to run.
This is what I get when I execute ng serve
ng serve
** NG Live Development Server is listening on localhost:4200, open your browser on http://localhost:4200/ **
Date: 2018-04-17T11:25:07.655Z
Hash: 0e59115234bd4a862168
Time: 17887ms
chunk {inline} inline.bundle.js (inline) 3.85 kB [entry] [rendered]
chunk {main} main.bundle.js (main) 1.96 MB [initial] [rendered]
chunk {polyfills} polyfills.bundle.js (polyfills) 1.08 MB [initial] [rendered]
chunk {scripts} scripts.bundle.js (scripts) 104 kB [initial] [rendered]
chunk {styles} styles.bundle.js (styles) 2.2 MB [initial] [rendered]
chunk {vendor} vendor.bundle.js (vendor) 15.1 MB [initial] [rendered]

ERROR in Error: Metadata version mismatch for module<EMAIL_ADDRESS>found version 4, expected 3, resolving symbol ComponentsModule in PROJECT_PATH/src/app/components/components/components.module.ts, resolving symbol ComponentsModule in PROJECT_PATH/src/app/components/components/components.module.ts
    at syntaxError (PROJECT_PATH/node_modules/@angular/compiler/bundles/compiler.umd.js:1729:34)
    at simplifyInContext (PROJECT_PATH/node_modules/@angular/compiler/bundles/compiler.umd.js:24979:23)
    at StaticReflector.simplify (PROJECT_PATH/node_modules/@angular/compiler/bundles/compiler.umd.js:24991:13)
    at StaticReflector.annotations (PROJECT_PATH/node_modules/@angular/compiler/bundles/compiler.umd.js:24418:41)
    at _getNgModuleMetadata (PROJECT_PATH/node_modules/@angular/compiler-cli/src/ngtools_impl.js:138:31)
    at _extractLazyRoutesFromStaticModule (PROJECT_PATH/node_modules/@angular/compiler-cli/src/ngtools_impl.js:109:26)
    at includeLazyRouteAndSubRoutes (PROJECT_PATH/node_modules/@angular/compiler-cli/src/ngtools_impl.js:66:25)
    at Array.reduce (<anonymous>)
    at Object.listLazyRoutesOfModule (PROJECT_PATH/node_modules/@angular/compiler-cli/src/ngtools_impl.js:54:36)
    at Function.NgTools_InternalApi_NG_2.listLazyRoutes (PROJECT_PATH/node_modules/@angular/compiler-cli/src/ngtools_api.js:91:39)
    at AotPlugin._getLazyRoutesFromNgtools (PROJECT_PATH/node_modules/@ngtools/webpack/src/plugin.js:240:66)
    at _donePromise.Promise.resolve.then.then.then.then.then (PROJECT_PATH/node_modules/@ngtools/webpack/src/plugin.js:493:24)
    at <anonymous>
    at process._tickCallback (internal/process/next_tick.js:188:7)

I'm trying whatever but I see myself far of any kind of solution. I understand is a compatibility problem about versions but I don't understand the logs. What version of what package?
Sorry about my ignorance, maybe is something super simple to fix but I don't know how to do it.
Here it is the package.json of the app in case it helps...
{
  "name": "covalent",
  "version": "1.0.0-beta.8-1",
  "private": true,
  "description": "Teradata UI Platform built on Angular Material",
  "keywords": [
    "angular",
    "components",
    "reusable"
  ],
  "scripts": {
    "e2e": "protractor",
    "e2e-test": "protractor ./protractor.conf.js",
    "lint": "tslint --format codeFrame -c ./tslint.json \"./src/**/*.ts\" -e \"./src/**/typings.d.ts\" -e \"./src/environments/**\"",
    "postinstall": "ng build --aot -prod",
    "reinstall": "rm -rf node_modules tmp deploy dist && npm i",
    "webdriver-update": "bash ./node_modules/.bin/webdriver-manager update",
    "test": "ng test --code-coverage --single-run --sourcemap=false",
    "coverage-win": "start chrome ./coverage/index.html",
    "coverage-mac": "open -a \"Google Chrome\" coverage/index.html",
    "coveralls": "cat ./coverage/lcov.info | node ./node_modules/coveralls/bin/coveralls.js",
    "bump-dev": "gulp bump-version",
    "bump-patch": "gulp bump-version --ver patch",
    "bump-minor": "gulp bump-version --ver minor",
    "bump-major": "gulp bump-version --ver major",
    "aot": "./node_modules/.bin/ngc -p deploy/platform/tsconfig-aot.json && tsc -p src/platform/tsconfig-aot.json",
    "build": "bash scripts/build-release",
    "npm-publish": "npm run build && bash scripts/npm-publish",
    "nightly-publish": "npm run build && bash scripts/nightly-publish",
    "ghpages-deploy": "./node_modules/.bin/ng build --base-href /covalent/ --aot -prod --sourcemap=false && bash scripts/ghpages-deploy",
    "start-release": "bash scripts/start-release",
    "finish-release": "bash scripts/finish-release",
    "combat-training": "bash scripts/combat-training",
    "heroku-prebuild": "echo This runs before Heroku installs your dependencies.",
    "heroku-postbuild": "echo This runs afterwards.",
    "start": "node server.js"
  },
  "engines": {
    "node": "7.10.0",
    "npm": "3.10.10"
  },
  "repository": {
    "type": "git",
    "url": "https://github.com/teradata/covalent.git"
  },
  "bugs": {
    "url": "https://github.com/teradata/covalent/issues"
  },
  "license": "MIT",
  "author": "Teradata UX",
  "contributors": [
    "Kyle Ledbetter<EMAIL_ADDRESS>    "Richa Vyas<EMAIL_ADDRESS>    "Ed Morales<EMAIL_ADDRESS>    "Jason Weaver<EMAIL_ADDRESS>    "Jeremy Wilken<EMAIL_ADDRESS>    "Jeremy Smartt<EMAIL_ADDRESS>    "Ilsun Park<EMAIL_ADDRESS>    "Steven Ov<EMAIL_ADDRESS>  ],
  "browserslist": [
    "last 2 versions",
    "ie 11"
  ],
  "dependencies": {
    "@angular-devkit/schematics": "0.0.34",
    "@angular/animations": "^4.4.3",
    "@angular/cdk": "^2.0.0-beta.12",
    "@angular/cli": "1.4.2",
    "@angular/common": "^4.4.3",
    "@angular/compiler": "^4.4.3",
    "@angular/compiler-cli": "^4.4.3",
    "@angular/core": "^4.4.3",
    "@angular/forms": "^4.4.3",
    "@angular/http": "^4.4.3",
    "@angular/material": "^2.0.0-beta.12",
    "@angular/platform-browser": "^4.4.3",
    "@angular/platform-browser-dynamic": "^4.4.3",
    "@angular/platform-server": "^4.4.3",
    "@angular/router": "^4.4.3",
    "@covalent/chips": "^0.9.1",
    "@covalent/code-editor": "^1.0.0-beta.1",
    "@covalent/core": "^1.0.0",
    "@covalent/dynamic-forms": "^1.0.0",
    "@covalent/highlight": "^1.0.0",
    "@covalent/http": "^1.0.0",
    "@covalent/markdown": "^1.0.0",
    "@covalent/search": "^0.9.1",
    "@covalent/text-editor": "^1.0.0-alpha.4",
    "@ngx-translate/core": "8.0.0",
    "@ngx-translate/http-loader": "1.0.2",
    "@swimlane/ngx-charts": "5.3.1",
    "angular2-qrscanner": "^0.1.12",
    "angular2-virtual-scroll": "^0.3.2",
    "classlist.js": "^1.1.20150312",
    "core-js": "^2.4.1",
    "d3": "^4.4.0",
    "express": "^4.16.2",
    "hammerjs": "^2.0.8",
    "highlight.js": "9.11.0",
    "ng2-clipboard": "^1.0.35",
    "ngx-gallery": "^3.1.1",
    "ngx-infinite-scroll": "^0.8.3",
    "ngx-scroll-event": "^1.0.8",
    "ramda": "^0.25.0",
    "require-dir": "^1.0.0",
    "rxjs": "^5.5.2",
    "showdown": "1.6.4",
    "ts-clipboard": "^1.0.15",
    "tslib": "^1.7.1",
    "typescript": "~2.3.2",
    "web-animations-js": "2.3.1",
    "webdriver-manager": "^12.0.6",
    "zone.js": "^0.7.8"
  },
  "devDependencies": {
    "@types/fs-extra": "^4.0.0",
    "@types/hammerjs": "^2.0.30",
    "@types/jasmine": "2.5.38",
    "@types/node": "~6.0.60",
    "@types/selenium-webdriver": "^2.52.0",
    "autoprefixer": "7.1.2",
    "codelyzer": "~3.0.0",
    "coveralls": "^2.12.0",
    "fs-extra": "^4.0.0",
    "glob": "^6.0.4",
    "gulp": "3.9.1",
    "gulp-bump": "2.1.0",
    "gulp-help": "1.6.1",
    "gulp-if": "2.0.1",
    "gulp-postcss": "7.0.0",
    "gulp-sass": "3.1.0",
    "gulp-sourcemaps": "1.6.0",
    "gulp-typescript": "3.1.4",
    "gulp-util": "3.0.7",
    "jasmine-core": "~2.5.2",
    "karma": "~1.4.1",
    "karma-chrome-launcher": "~2.0.0",
    "karma-cli": "~1.0.1",
    "karma-coverage-istanbul-reporter": "^0.3.0",
    "karma-firefox-launcher": "^1.0.1",
    "karma-jasmine": "^1.1.0",
    "karma-jasmine-html-reporter": "^0.2.2",
    "karma-phantomjs-launcher": "1.0.1",
    "merge2": "1.0.2",
    "node-sass": "^4.7.2",
    "phantomjs-prebuilt": "2.1.14",
    "protractor": "~5.1.0",
    "rollup": "^0.41.6",
    "rollup-plugin-commonjs": "8.0.2",
    "rollup-plugin-node-resolve": "^3.0.0",
    "semver": "5.2.0",
    "ts-node": "^3.0.4",
    "tslint": "5.2.0",
    "uglify-js": "^2.8.14"
  }
}

Looks like you are on Angular 4 but have the carrot on the code editor:
"@covalent/code-editor": "^1.0.0-beta.1",
Which will give you the latest code-editor that is using Angular 6.
If you want to stay on Angular 4 then use this Code Editor dependency (remove the carrot to peg to the version):
"@covalent/code-editor": "1.0.0-beta.1",


Set force_ssl to true in production only

Motivation and Context

Recommend all network traffic be secure in production mode. The main reason to enable this is to turn on HSTS and secure cookies:
https://api.rubyonrails.org/v6.1.3/classes/ActionDispatch/SSL.html
Your Changes

Description:

added config option

Type of change (select all that apply):

[x] Other (please specify): security updates

Testing

Questions and Comments (if applicable)

Checklist

[x] I have performed a self-review of my own code.
[x] I have fixed any Hound bot comments.
[ ] I have verified that the TravisCI tests have passed.
[ ] I have reviewed the test coverage changes reported on Coveralls.
[ ] I have described any required documentation changes below.

Required documentation changes (if applicable)

tests currently failing because of #5192


[Rust] Fix validate record reference with implicit namespace

What is the purpose of the change
The validate_internal function is not propagating schema's sub-namespaces resulting in validation error of valid value. This PR fixes the issue checking wether a record in the schema has a namespace and passing it through the recursive call to validate_internal instead of using by default the top level namespace.
Verifying this change
This change added tests and can be verified as follows:

Run cargo test

Documentation

Does this pull request introduce a new feature? (no)
If yes, how is the feature documented? (not applicable)

Hey @martin-g, is this something I can do? not sure how to create the jira ticket

JIRA ticket attached

Thank you for the contribution, @andrewinci !


The current makefile can't build the test subdirs

Like vector, rect etc. Currently they can only be built manually.

Well, OK, I forgot that the test sources should go to src/test/... and then they do get compiled into ./test, which is the /target/ dir! (Good enough for now, but later deciding where (static) test assets should live (in the test src or the test target dir?) will be a headache...)


Confusing ... suggestion showing in ts files on arrow functions

Issue Type: Bug
repo

Using TS 3.2
Open a ts file:

const a = (x) => x;

Bug
Notice the ... under x. When you move the cursor over the ..., we offer the convert to braces / remove braces refactoring
This behavior is really confusing. Accepting these refactors will not get rid of the ..., which is actually an infer type suggestion
VS Code version: code-oss-dev 1.30.0 (Commit unknown, Date unknown)
OS version: Darwin x64 18.2.0

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-4770HQ CPU @ 2.20GHz (8 x 2200)

GPU Status
2d_canvas: enabledchecker_imaging: disabled_offflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onnative_gpu_memory_buffers: enabledrasterization: enabledvideo_decode: enabledvideo_encode: enabledwebgl: enabledwebgl2: enabled

Load (avg)
5, 5, 5

Memory (System)
16.00GB (0.15GB free)

Process Argv
.

Screen Reader
no

VM
25%

Root cause https://github.com/Microsoft/TypeScript/issues/28702 but I'm just going to disable these suggestions entirely on broken TS versions


Node efficiency

Kevin - I updated the "nodeEfficiency" function that I wrote so it now uses the tag path similar to the function you wrote, "estNodeEff".  It should not affect anything else in the package.  It makes a few different assumptions that your function, which we may need to discuss at some point.  Let me know if you have any questions.

Important to note - the upstream/downstream switch still needs the capHist file to be filtered for only those fish moving upstream or downstream.  The switch in the function just changes the nodes being looked at for marks and recaptures.


api_docs: Deduplicate common constructs in zulip.yaml

This PR deduplicate various common constructs, like narrow, to live in components and be shared between the documentation for multiple endpoints.

@orientor FYI.

@zulipbot remove "has conflicts"

@zulipbot remove "has conflicts"

Thanks for working on this @shubhamgupta2956!  I merged the first half of the branch, after a few edits to some of the descriptions to be clearer.  I stopped because in some of the more complex descriptions, like EmojiName, there are details that are different between the descriptions of the parameter for the different cases that are important, like when the include_custom_profile_fields parameter was added for a given endpoint.
Can you rebase the branch to put the migrations parameters that don't have this sort of issue where the text is significantly different for a reason first, so that we can merge those commits and shrink this branch?
And then we'll need to figure out a strategy for handling descriptions of parameters that, for example, need to be documented as new in only one place.

@timabbott I had rebased the branch. IMO commits till IncludeSubscribers does not have any issue as you mentioned.

EmojiCode definitely has that sort of issue; can you move it to the end?

@timabbott I had moved EmojiCode to the end. I missed the slight wording difference due to which I didn't put it in end.

@zulipbot remove "has conflicts"

I merged this as the series ending with 5ea942caffff3e8268bad8157310a9c801b14684; that last commit reverts some of the mistakes made earlier in the series (which removed important documentation).
One thing that isn't great about this common-object system is that it limits our ability to describe situations where a parameter's meaning (or version history) is different in different places it's referenced.  Hopefully that won't be too big of a problem.


ParameterServer restart crashes distributed training process

I've tried running distributed TensorFlow with Supervisor and new MonitoredTrainingSession and I observe following behavior if Parameter Server is restarted.  Code is available at http://pastebin.com/HBUicRp2.  I'm using TensorFlow freshly built from r1.0.
At first, this error happens which is OK:
INFO:tensorflow:Error reported to Coordinator: <class 'tensorflow.python.framework.errors_impl.UnavailableError'>, {"created":"@1487751897.191020037","description":"EOF","file":"ex
ternal/grpc/src/core/lib/iomgr/tcp_posix.c","file_line":235,"grpc_status":14}
W tensorflow/core/framework/op_kernel.cc:993] Unavailable: {"created":"@1487751897.191020037","description":"EOF","file":"external/grpc/src/core/lib/iomgr/tcp_posix.c","file_line":
235,"grpc_status":14}
         [[Node: Assign_1_S295 = _Recv[_start_time=0, client_terminated=false, recv_device="/job:worker/replica:0/task:0/cpu:0", send_device="/job:ps/replica:0/task:0/cpu:0", send_
device_incarnation=8036561443230364107, tensor_name="edge_30_Assign_1", tensor_type=DT_INT64, _device="/job:worker/replica:0/task:0/cpu:0"]()]]
W tensorflow/core/framework/op_kernel.cc:993] Unavailable: {"created":"@1487751897.191020037","description":"EOF","file":"external/grpc/src/core/lib/iomgr/tcp_posix.c","file_line":
235,"grpc_status":14}
         [[Node: Assign_1_S295 = _Recv[_start_time=0, client_terminated=false, recv_device="/job:worker/replica:0/task:0/cpu:0", send_device="/job:ps/replica:0/task:0/cpu:0", send_
device_incarnation=8036561443230364107, tensor_name="edge_30_Assign_1", tensor_type=DT_INT64, _device="/job:worker/replica:0/task:0/cpu:0"]()]]
W tensorflow/core/framework/op_kernel.cc:993] Unavailable: {"created":"@1487751897.191020037","description":"EOF","file":"external/grpc/src/core/lib/iomgr/tcp_posix.c","file_line":
235,"grpc_status":14}
         [[Node: Assign_1_S295 = _Recv[_start_time=0, client_terminated=false, recv_device="/job:worker/replica:0/task:0/cpu:0", send_device="/job:ps/replica:0/task:0/cpu:0", send_
device_incarnation=8036561443230364107, tensor_name="edge_30_Assign_1", tensor_type=DT_INT64, _device="/job:worker/replica:0/task:0/cpu:0"]()]]

However, after Parameter Server is restarted, I see this error in logs and training worker crashes:
I tensorflow/core/distributed_runtime/master_session.cc:909] DeregisterGraph error: Aborted: Graph handle is not found:<PHONE_NUMBER>000729. Possibly, this worker just restarted.
I tensorflow/core/distributed_runtime/master_session.cc:909] DeregisterGraph error: Aborted: Graph handle is not found:<PHONE_NUMBER>000727. Possibly, this worker just restarted.
I tensorflow/core/distributed_runtime/master_session.cc:909] DeregisterGraph error: Aborted: Graph handle is not found:<PHONE_NUMBER>000731. Possibly, this worker just restarted.
I tensorflow/core/distributed_runtime/master_session.cc:909] DeregisterGraph error: Aborted: Graph handle is not found:<PHONE_NUMBER>000723. Possibly, this worker just restarted.
I tensorflow/core/distributed_runtime/master_session.cc:909] DeregisterGraph error: Aborted: Graph handle is not found:<PHONE_NUMBER>00072b. Possibly, this worker just restarted.
Traceback (most recent call last):
  File "tf_dist_mnist.py", line 140, in <module>
    tf.app.run(main=main, argv=[sys.argv[0]] + unparsed)
  File "/usr/local/lib/python2.7/dist-packages/tensorflow/python/platform/app.py", line 44, in run
    _sys.exit(main(_sys.argv[:1] + flags_passthrough))
  File "tf_dist_mnist.py", line 107, in main
    mon_sess.run(train_op, feed_dict={image: image_, label: label_})
  File "/usr/local/lib/python2.7/dist-packages/tensorflow/python/training/monitored_session.py", line 478, in __exit__
    self._close_internal(exception_type)
  File "/usr/local/lib/python2.7/dist-packages/tensorflow/python/training/monitored_session.py", line 511, in _close_internal
    self._sess.close()
  File "/usr/local/lib/python2.7/dist-packages/tensorflow/python/training/monitored_session.py", line 739, in close
    self._sess.close()
  File "/usr/local/lib/python2.7/dist-packages/tensorflow/python/training/monitored_session.py", line 827, in close
    self._coord.join()
  File "/usr/local/lib/python2.7/dist-packages/tensorflow/python/training/coordinator.py", line 386, in join
    six.reraise(*self._exc_info_to_raise)
  File "/usr/local/lib/python2.7/dist-packages/tensorflow/python/training/queue_runner_impl.py", line 234, in _run
    sess.run(enqueue_op)
  File "/usr/local/lib/python2.7/dist-packages/tensorflow/python/client/session.py", line 767, in run
    run_metadata_ptr)
  File "/usr/local/lib/python2.7/dist-packages/tensorflow/python/client/session.py", line 965, in _run
    feed_dict_string, options, run_metadata)
  File "/usr/local/lib/python2.7/dist-packages/tensorflow/python/client/session.py", line 1015, in _do_run
    target_list, options, run_metadata)
  File "/usr/local/lib/python2.7/dist-packages/tensorflow/python/client/session.py", line 1035, in _do_call
    raise type(e)(node_def, op, message)
tensorflow.python.framework.errors_impl.UnavailableError: {"created":"@1487751897.191020037","description":"EOF","file":"external/grpc/src/core/lib/iomgr/tcp_posix.c","file_line":235,"grpc_status":14}

I expect it to recover from latest checkpoint instead.

@jhseu we discussed this on TF Dev Summit and you recommended raising issue.

Thanks! Adding to my todo list (but may not get to it for a little bit).

Sent out a fix internally.

Will you backport to Supervisor's managed_session as well?  It's still listed on TensorFlow documentation website as one of the recommended ways to do simplified session management - https://www.tensorflow.org/programmers_guide/supervisor

My understanding is that managed_session never did recovery for failed workers. Also, Supervisor is eventually going away.

AFAIK it is has similar level of recoverability as MonitoredTrainingSession (before your fix).  Here's my observations for Supervisor's managed_session:

Parameter Server failure.  Training throws UnavailableError on all workers.  All workers crash.  After restart of failed PS and all workers, training continues from the last checkpoint.
Chief worker failure.  Training freezes.  After chief worker is restarted, training continues from the last checkpoint.
Non-Chief worker failure.  Training freezes.  After failed worker is restarted, training continues from the last iteration.
Backup worker failure.  Training continues, with potential slowdown.  After failed backup worker is restarted, training continues with original pace.

Since it's still widely advertised a lot of people may jump to use it.

@alsrgv @jhseu Hi, sorry to comment on this closed issue.
But I'm wondering will training freezes if non-chief workers failure in the latest release (v1.5.0)?


[KED-1619] logging.yaml configuration reference

I'd like to understand what valid entries in logging.yaml files are. Searching the kedro docs did not provide the info I was looking for. Is related to https://github.com/quantumblacklabs/kedro/issues/344 .

There's an example in the docs but this relates to native Python logging, nothing special that Kedro does on top.

@lorenabalan Thanks for the hint. anyconfig.validate (data, schema, ac_schema_safe=True, ac_schema_errors=False, **options) was what I was looking for.


chore: remove duplicate classNames for button

The button size variants had duplicate padding classNames which were giving eslint errors

@EuanMorgan Thanks for contributing


Add exponentiation by constant to FieldGadget

Could you slightly generalize the implementation to be like the corresponding code in Field:
https://github.com/scipr-lab/zexe/blob/4ae139cc80a7763e4e5999e36cdfdc4f57148b9d/algebra-core/src/fields/mod.rs#L118

btw the tests are failing with incorrect output

I'm pretty confused, am I testing wrong?
z/r1cs-std> git branch
  master
* pow
z/r1cs-std> cargo test
Finished test [unoptimized + debuginfo] target(s) in 0.04s
<snip>
test result: ok. 26 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out

I think you need to try it with cargo test —all-features
On Fri, Feb 28, 2020 at 7:43 PM Dev Ojha<EMAIL_ADDRESS>wrote:

I'm pretty confused, am I testing wrong?
z/r1cs-std> git branch
master

pow
z/r1cs-std> cargo test
Finished test [unoptimized + debuginfo] target(s) in 0.04s

test result: ok. 26 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/scipr-lab/zexe/pull/114?email_source=notifications&email_token=AAYSJ6SUOFJ6TNNUN5U3J4DRFHKXJA5CNFSM4K5U2I22YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOENLCQYY#issuecomment-592848995,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAYSJ6QCYHBBRTNVGG6PSKTRFHKXJANCNFSM4K5U2I2Q
.

Fixed, the error got introduced when I switched to bit iterator syntax.
Feels a bit weird that the default for tests on r1cs-std is to have the r1cs tests off though

They test the constraints, but the curve and field gadgets are behind feature-flags because not everyone might want all the different options

(btw thanks for the PR!)

Thanks for the expl!


Allow binary buffers

This will allow sending binary buffers by converting to a base64 string before storing to cache.  I added an option flag 'binary' to enable this feature.
#51
router.get('/image/:guid', cache.route({binary: true}), function(req, res){
 ...
    res.status(200).send(new Buffer(body, 'binary'));
}

+1

@MDBox, do you want to add a test for the binary flag? :)

Sure, I can look at adding a test case.  Maybe this weekend.

Awesome. And add yourself to contributors in package.json.

Test case added.

@MDBox thanks!


Suggestion : Split documentation in two parts.(i.e README.md and CONTRIBUTING.md)

I think we should split up the documentation in two parts. Currently it is only readme which also has contribution guidelines. Separating them into two would make the documentation clean.

Thanks for opening the issue. Contribution guidelines don't seem to take up much of the README.md file. So, it would be kinda unnecessary to make a separate file for little content. But still, let's wait for more inputs from others. @aayusharora @mariobehling @geekyd What do you suggest about this issue. Would love to hear more opinions. Thanks!!


Fix telemetry reporter logging

Description
Log info message only if the update is really available.
Checked manually.
Readiness checklist

[ ] I added/updated unit tests.
[ ] I added/updated integration/compatibility tests.
[ ] I added/updated comments and checked rendering.
[ ] I made spot refactorings.
[ ] I updated user documentation.
[ ] I ran task all, and it passed.
[x] I ensured that PR title is good enough for the changelog.
[x] (for maintainers only) I set Reviewers (@FerretDB/core), Labels, Project and project's Sprint fields.
[x] I marked all done items in this checklist.

There is another thing to improve, but not in a rush


User script doesn't work

@rakleed commented on Fri Feb 17 2023
AdGuard version
2.9.2
Browser version
Safari 16.3/Chrome 110
OS version
13.2.1 (22D68)
What filters do you have enabled?
No response
What Stealth Mode options do you have enabled?
No response
Support ticket ID
No response
Issue Details
Steps to reproduce:

Install user script from https://greasyfork.org/en/scripts/15222-imdb-tomatoes or https://github.com/chocolateboy/userscripts/blob/master/src/imdb-tomatoes.user.js
Go to https://www.imdb.com/title/tt7366338/

Expected Behavior
The user script works correctly.
Actual Behavior
The user script doesn't work. Log from browser console:
[Log] id: – "tt7366338"
[Log] cached error (expires: 17/02/2023, 15:36:42): – "error fetching API (420 Connection Error)"

Screenshots
No response
Additional Information
Before updating to version 5, the script worked correctly.
And in Chrome, through the Tampermonkey or Violentmonkey extension, the script works correctly.

@EldritchEevee commented on Mon Feb 20 2023
Addon requires a rewrite with MV3 compatibility. MV2 MUST be dropped.

@ngorskikh any news?


Support integration with on-prem Gitlab

It seems that currently only Gitlab.com is supported (as opposed to self-hosted Gitlab instances) for token storage. It'd be great to be able to sync tokens with our on-premise Gitlab. Will this be supported in the future?

did you try adding the baseUrl to your credentials?

Thanks for the reply. Sorry, you can file this as PECAB.


Add support to skip Leaders that don't have enough points.

I really appreciate your library, and would love to see another update. Towards that end, I have tried to read a DXF file made with a converter, and it had some single point leaders in it. The rest of the file had good data when I skipped the bad leaders. I previously attempted to fix the issue by allowing single point leaders by assuming a horizontal text angle, but that changed a lot more code and might not be wanted, since (I think) AutoCad doesn't like leaders with just 1 point either.
I'm not sure if I added the option the right way - If that's wrong somehow, please let me know how you'd like it and I will have a go at it.
Example file: Civil Drawings AutoCAD2000.zip

Fair enough, but it does not require so many changes, just return null in the ReadLeader method when the number of vertexes is less than two. Having the option to skip those leaders is not necessary since the Leader constructor will not allow to create them hence the exception when trying to load the file.


feature request: Import Code-Snippes and MermaidJS Pictures

Hey, I saw that this plugin is converting my code snippets and MermaidJS pictures into text. Is there any possibility to display them correctly in WordPress?

I'm also using mermaid.  I have two possible solutions:

Integrate with WP Mermaid:
On WordPress I've installed the WP Mermaid Plugin by Terry Lin.  It renders Mermaid server side if it finds a block containing mermaid.  One option would be for this plugin to work with "WP Mermaid" by modifying the content as it posts such that

sequenceDiagram
Alice->Bob: Hello Bob, how are you?

becomes
[mermaid]
sequenceDiagram
Alice->Bob: Hello Bob, how are you?
[/mermaid]

Second option:  Doesn't require a server side dependency.
Render the mermaid diagram client side into an image, upload the image, and replace the mermaid markdown with the generated image.  This is ideal from an Obsidian user perspective as the diagram will be rendered with the same style as displayed in Obsidian.